Corrections for byte literals, spacing, minor function change, and updated the examples.

It looks like a bigger change than it is due to the tab -> 4 spaces changes in mysmb.py (to comply with the Python style guide) and removal of trailing whitespace. There were missing byte literals in places they were required and the examples were updated. It's confirmed that the code now successfully runs against Windows XP.

Hey thanks for the contribution! Initial review looks good on my end. I'm going to test a few more things before I pull it in. You mentioned you had a successful run against Windows XP, so I assume that's where you ran into some issues before. If you could post screenshots of your validation to show your use case working. (Not required by any means, just helpful for a sanity check).
For future reference. If you ever do make a style change like this, try and do so in separate commits at least. I certainly appreciate the change in making the code cleaner, but it is a lot to review. Separate commits make it is easier for a reviewer to see the distinct technical/versus non-technical changes more easily. Fortunately, this only impacts two relatively small code files so no big deal, wasn't too difficult to review.
I'll pull it in as soon as I complete testing on my end, but if you are able to upload any artifacts from your test please do so at any time.

Thanks Casey. I totally understand about breaking up the commits, sorry
about that! My apologies!
I'm doing my OSCP and used the code to break into some Windows XP lab
machines but due to Offensive Security's policies I unfortunately can't
send out any screenshots of the exploit in their environments. :\ Prior to
the changes zzz_exploit.py wouldn't run correctly in Python3 so I stepped
through it with pdb and made adjustments as required. In its current state
the RemoteShell still doesn't work but smb_send_file() is confirmed to
work. If I have some time to look into the RemoteShell and correct it I'll
make sure to do another pull request.
On Sat, Oct 24, 2020 at 11:19 AM Casey Erdmann<EMAIL_ADDRESS>wrote:

Hey thanks for the contribution! Initial review looks good on my end. I'm
going to test a few more things before I pull it in. You mentioned you had
a successful run against Windows XP, so I assume that's where you ran into
some issues before. If you could post screenshots of your validation to
show your use case working. (Not required by any means, just helpful for a
sanity check).
For future reference. If you ever do make a style change like this, try
and do so in separate commits at least. I certainly appreciate the change
in making the code cleaner, but it is a lot to review. Separate commits
make it is easier for a reviewer to see the distinct technical/versus
non-technical changes more easily. Fortunately, this only impacts two
relatively small code files so no big deal, wasn't too difficult to review.
I'll pull it in as soon as I complete testing on my end, but if you are
able to upload any artifacts from your test please do so at any time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/3ndG4me/AutoBlue-MS17-010/pull/22#issuecomment-716016738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATKOELAEAFK4XKU45Y5PT3SMMEBNANCNFSM4S5WYZZQ
.

No worries!
I was able to test, and I actually did successfully get a session with the RemoteShell() function via a browser pipe on Windows XP SP3. The section of example code from lines 898-908 that you commented out prevents me from pulling this "as is" in as it would break the current functionality of getting a shell. Currently the zzz_exploit.py code is incompatible with python3 without your changes to byte literals so I'd love to merge this in, but it works just fine getting the limited SMB shell with python2 so I do not want to remove this example code.
Based on my testing, your changes work just fine on python2 and python3 with the standard SMB shell example code. If you can uncomment lines 898-908 I will happily re-test and move this back in. Not sure what issues you encountered in getting RemoteShell() to work in the OSCP lab, but it does not seem to be a universal issue as it seems to be working just fine on my end. Please try to restest on another system. If you are unable to, still resubmit the PR with the uncommented example and I'll be restesting either way so we can get these changes merged in.
Excellent PR in regards to the byte literals, as this is code I missed during my python3 overhaul, but I can't merge this in with that example code commented out.
Code to uncomment:
    # example of creating a remote shell on the remote host (may not work at the moment...)
    if mode == 'SERVER':
        serverThread = SMBServer()
        serverThread.daemon = True
        serverThread.start()
    service_name = ''.join([random.choice(string.ascii_letters) for _ in range(4)])
    shell = RemoteShell(share, conn, mode, service_name)
    shell.cmdloop()

    if mode == 'SERVER':
        serverThread.stop()

Screenshot of this PR with uncommented example code working with python2:

Screenshot of this PR with uncommented example code working with python3:

Excellent. I will create that pull request now! In my test on XP SP1 build
2600 it failed as follows:

[*] make this SMB session to be SYSTEM
[+] current TOKEN addr: 0xe1cdf338
Bad TOKEN_USER_GROUP offsets detected while parsing tokenData!

Done

Derrick
On Sat, Oct 24, 2020 at 11:52 AM Casey Erdmann<EMAIL_ADDRESS>wrote:

No worries!
I was able to test, and I actually did successfully get a session with the
RemoteShell() function via a browser pipe on Windows XP SP3. The section of
example code from lines 898-908 that you commented out prevents me from
pulling this "as is" in as it would break the current functionality of
getting a shell. Currently the zzz_exploit.py code is incompatible with
python3 without your changes to byte literals so I'd love to merge this in,
but it works just fine getting the limited SMB shell with python2 so I do
not want to remove this example code.
Based on my testing, your changes work just fine on python2 and python3
with the standard SMB shell example code. If you can uncomment lines
898-908 I will happily re-test and move this back in. Not sure what issues
you encountered in getting RemoteShell() to work in the OSCP lab, but it
does not seem to be a universal issue as it seems to be working just fine
on my end. Please try to restest on another system. If you are unable to,
still resubmit the PR with the uncommented example and I'll be restesting
either way so we can get these changes merged in.
Excellent PR in regards to the byte literals, as this is code I missed
during my python3 overhaul, but I can't merge this in with that example
code commented out.
Code to uncomment:
# example of creating a remote shell on the remote host (may not work at the moment...)
if mode == 'SERVER':
    serverThread = SMBServer()
    serverThread.daemon = True
    serverThread.start()
service_name = ''.join([random.choice(string.ascii_letters) for _ in range(4)])
shell = RemoteShell(share, conn, mode, service_name)
shell.cmdloop()

if mode == 'SERVER':
    serverThread.stop()

Screenshot of this PR with uncommented example code working with python2:
[image: python2_example]
https://user-images.githubusercontent.com/14339392/97088528-6f1dcd80-15ff-11eb-94f6-1688633d73ff.png
Screenshot of this PR with uncommented example code working with python3:
[image: python3_example]
https://user-images.githubusercontent.com/14339392/97088536-7f35ad00-15ff-11eb-8dc4-d2691ac0804a.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/3ndG4me/AutoBlue-MS17-010/pull/22#issuecomment-716030939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATKOELHBOG5V7JJMXXARI3SMMH7TANCNFSM4S5WYZZQ
.

Awesome, just validated the change and will merge it in shortly. Looks like the error you're seeing could be related either to SP1 or just that target in particular so just a note for future viewers of this PR.
Looks like it's not working due to encountering this error:
[-] got exception CRITICAL:root:SMB SessionError: STATUS_OBJECT_NAME_NOT_FOUND(The object name is not found.)
Which could be based on the SP0/SP1 workaround not successfully working (could be hit or miss I'm no expert on this particular caveat, so take that with a grain of salt):
Bad TOKEN_USER_GROUP offsets detected while parsing tokenData!
RestrictedSids: 0xe1b37720
RestrictedSidCount: 0x1f4
userAndGroupCount: 0x4c
userAndGroupsAddr: 0xe1cdf3c0
Attempting WINXP SP0/SP1 x86 TOKEN_USER_GROUP workaround
userAndGroupCount: 0x3
userAndGroupsAddr: 0xe1cdf3c0

Either way excellent contribution, good luck on your OSCP!


Can we model Exploding Palm?

I'm trying an Exploding Palm build http://www.d3planner.com/345537055. I'm using the Impending Doom rune, which does no damage until death, then provides a massive explosion of damage. I'm finding this very powerful in-game, but I can't figure out how to model it in the Planner. The EP's effectiveness is based on (1) lots of density, and (2) killing white mobs. The simulator is showing EP as being 1.08% of my damage, and I can tell you that this is definitely NOT the case.
So can the simulator model EP, and if so, do I need to modify the parameters to make this work?

Okay there were a few bugs with it that I just fixed.
In the simulator, EP is always applied to the first target without the debuff, but the 'Buff stacks' condition only checks the debuff on the first target (in your case, the elite that never dies). You need to use 'Debuff targets' instead, and make it equal to the actual number of targets in the simulation (4). Also, you should probably adjust the 'death rate' parameter in events, because the Auto setting is a bit weird.
At 10 deaths/minute EP comes out at around 10% damage - does that seem right?

Thanks for getting back to me on this. I may not be understanding how to use the Debuff Targets option, but I am getting 39 uses of EP but no damage. As far as whether 10% damage for EP makes sense, that's really, really hard to say. I'm only recently playing EP/Inna's build. As I ramp up in difficulty level, I'm finding that my Mystic Allies kill less and less, and EP kills more and more. Single white mobs are killed by my allies before I can even get to them. But I blow up groups with great regularity.
I guess that has to do with Monster Health, which is kind of a semi-unknown in the Simulator. Also, it depends on the cluster size. I recently did the Cow Level on T12, and I was exploding whole screens, dozens and dozens of cows.

Bump

Yep, monster health is calculated in a weird way unless you explicitly specify it, so group calculations are kinda hard to do correctly.


Mispelled word fixed on spanish doc

Corrected a spelling error in the documentation in Spanish. For better compression.
Closes #1285

Thanks @AbreuY!


The sub modes under Bible does not open to new windows

The modes under Bible -does not open to a new tab on clicking
Translation
OBS
Audio
MT

looks like button's functionality is disabled.


#3330 broke Dialog Dispose

I broke something in

#3330

Not sure how I missed this in my testing.... and clearly more/better unit tests are needed.
Repo:

Run UI Catalog
Hit Ctrl-A to show About box
Close About box
Exit UI Catalog

You'll get an assert that the Dialog for the about box was not disposed.

Well, it seems that you need to dispose the toplevel on the End method.
        // Do NOT dispose .Toplevel here. It was not created by
        // Run, but Init or someone else.
        runState.Toplevel?.Dispose ();
        runState.Toplevel = null;
        runState.Dispose ();

No. That's not correct.
The creator of the object needs to be responsible for its lifetime.
With my fix, anywhere someone creates a toplevel to pass to Run must dispose the object after Run returns.
I've got a pr in profess that will fix all instances in the solution.

My thinking about this isn't the disposing on the End method that cause the issue, but the disposing that is done on the Begin method if the Top isn't the same passed by the parameter, which normally is the one created by the Init method and is this one that need to be disposed on the Shutdown method, because it may not been called by the Begin method. So, on the End method the runstate.Toplevel must be disposed because they was created by the Begin method.

But I think that disposing the Top, the one created by the Init method and not added to the toplevel's stack, on the Begin method is the right procedure, because it will never be used and we to set the Top by the one passed on the parameter. What issue do you have before you done the #3313?

What issue do you have before you done the #3313?

Window w = new ();
w.Ready += (s,e) { Application.RequestStop() }; // Causes `End` to be called
Application.Run(w);
if (w.SomeProperty) {} // Invalid - w has been disposed
Applicaton.Run(w); // Invalid - w has been disposed

See this new unit test:
[Fact]
    public void End_Should_Not_Dispose_ApplicationTop_Shutdown_Should ()
    {
        Init ();

        RunState rs = Application.Begin (Application.Top);
        Application.End (rs);

#if DEBUG_IDISPOSABLE
        Assert.True (rs.WasDisposed);
        Assert.False (Application.Top.WasDisposed);
#endif

        Assert.Null (rs.Toplevel);

        var top = Application.Top;

        Shutdown ();

#if DEBUG_IDISPOSABLE
        Assert.True (top.WasDisposed);
#endif

        Assert.Null (Application.Top);
    }

If the old End behavior is reverted this test fails.
Tons of unit tests re-use Toplevels passed to Run. It's only luck that they work. Adding [TestRespondersDisposed] to them causes them to fail.
If Init creates a toplevel, Shutdown should clean it up, not End. (Init does and Shutdown does, in ResetState).
If Begin creates a toplevel, Stop should clean it up, not End. (Begin doesn't).
If Run (Toplevel) creates a toplevel, End should clean it up (Run (toplevel) doesn't, End doesn't and doesn't need to).
If Run<T> creates a toplevel, End should clean it up (Run<T> does, End doesn't - this is technically incorrect right now).
If a Toplevel is created and passed to Run, the code that created it should clean it up.

Window w = new ();
w.Ready += (s,e) { Application.RequestStop() }; // Causes `End` to be called
Application.Run(w);
if (w.SomeProperty) {} // Invalid - w has been disposed
Applicaton.Run(w); // Invalid - w has been disposed

But isn't normal that referencing a toplevel (w) after the call Application.Run(w) it already been disposed by the End method due the call to the Application.RequestStop() method?
We need to have sure what is the right behavior before continue.

But isn't normal that referencing a toplevel (w) after the call Application.Run(w) it already been disposed by the End method due the call to the Application.RequestStop() method?
We need to have sure what is the right behavior before continue.

Before #3330 Application.End did this:
        runState.Toplevel?.Dispose ();
        runState.Toplevel = null;
        runState.Dispose ();

        // BUGBUG: Application.Top is now invalid?!?!

This is incorrect behavior:
a) Application.Top often points to the same object as runState.Top. Disposing that object is Bad.
b) Application.Current also oftent points to that same object.
An example of Scenario code that SHOULD fail (it would if we threw exceptions on property access for disposed objects) is Notepad:
        var open = new OpenDialog { Title = "Open", AllowsMultipleSelection = true };

        Application.Run (open);

        if (!open.Canceled)
        {
            foreach (string path in open.FilePaths)
            {
                if (string.IsNullOrEmpty (path) || !File.Exists (path))
                {
                    return;
                }

                // TODO should open in focused TabView
                Open (new FileInfo (path), Path.GetFileName (path));
            }
        }

If this code is changed to the below, the bug would be illustrated:
        var open = new OpenDialog { Title = "Open", AllowsMultipleSelection = true };

        Application.Run (open);

        Assert.True (open.WasDisposed);

It's only luck that the check for open.Cancelled works because open has been Disposed by End.
My fix does this:
        // Do NOT dispose .Toplevel here. It was not created by
        // Run, but Init or someone else.
        runState.Toplevel = null;
        runState.Dispose ();

(and changes RunState.Dispose to not thow an exception).
I believe the new code is correct. Run does not create runState.Toplevel, whoever called Run did. So End should not dispose it.
The downside of the "Fix" is that it means anyone who creates a Toplevel to pass to Run must be smart about managing the lifecycle of that instance, calling Dispose as needed. So, for example, the Notepad scenario needs to look like this:
        var open = new OpenDialog { Title = "Open", AllowsMultipleSelection = true };

        Application.Run (open);

        bool canceled = open.Canceled;

        if (!canceled)
        {
            foreach (string path in open.FilePaths)
            {
                if (string.IsNullOrEmpty (path) || !File.Exists (path))
                {
                    break;
                }

                // TODO should open in focused TabView
                Open (new FileInfo (path), Path.GetFileName (path));
            }
        }

        open.Dispose ();

This is incorrect behavior:
a) Application.Top often points to the same object as runState.Top. Disposing that object is Bad. b) Application.Current also oftent points to that same object.

It's true that Application.Top often points to the same object as runState.Top when it's also the same object as the Application.Current.
The Application.Current always point to the same as runState.Top if it's still running. On overlapped toplevel's if the stack is changed during a RunLoop, the runState.Top is checked against the Current and if it isn't the same object then the runState.Top is set to the Current.

Application.Currentalways point to the same asrunState.Topif it's still running. On overlapped toplevel's if the stack is changed during a RunLoop, therunState.Topis checked against theCurrentand if it isn't the same object then therunState.Topis set to theCurrent`.

We really need some tight-focused unit tests for all this. It's crazy complicated and the only code that really exercises it are the "BackgroundWorker" Scenarios which are NOT good test cases as they are convoluted and do many things.
Since you have a good idea in your head of how this is supposed to work, could you please engineer some unit tests that prove #3399 does/does not break the logic?

Toplevel created by the Application.Init shouldn't be moveable, otherwise it will behave badly because it represent all the available space on a terminal.

A possible fix on this PR https://github.com/tig/Terminal.Gui/pull/24.


add course plugin

Purpose
Add course plugin to enable publishing of
course glimpse for any course on any page of the CMS
This allows the creation of custom course presentation pages or sections.
Proposal

[x] Add course plugin
[x] Add style
[x] Add tests

the fails are from a test server being unavailable: "received unexpected HTTP status: 503 Service Unavailable"


Need to be able to override target namespace and accessibility

As decided across languages, in Search we need to move all (or at most) models to a new namespace, i.e. Azure.Search.Documents.Indexes.Models. These models are all in a single swagger (we have two), but the old generator way of changing the target namespace (..x-ms-code-generation-settings.namespace) doesn't work. Having something we can define on the models via transform would be helpful, as creating custom models with the [CodeGenModel] attribute is not only a large effort (hence the label assigned to this issue), but untenable since new models are added with some frequency. We want them to go to the right place by default to avoid more customization work when not otherwise needed.
@pakrym also said we could take this opportunity to change the accessibility modifier as well.
This might also apply to operations that would go into Azure.Search.Documents.Indexes; however, there's only a few and easier to move. That said, the hand-written clients for Search we're still keeping in the main, i.e. Azure.Search.Documents, namespace, but we don't expose the generated operations directly.
Also, not all models will necessarily move. [CodeGenModel] support should ignore the intended namespace, i.e. if we put a custom model with a matching source name in Azure.Search.Documents.Models that should be in Azure.Search.Documents.Models.Indexes.Models otherwise, the namespace should be Azure.Search.Documents.Models.

Alternatively, if not temporarily, Search could change the default project namespace since it would be easier to redefine the 18 models from searchindex.json than the (currently, but growing) 152 models from searchservice.json. This does add some complexity to development, though, since any new code will default to that namespace and is something we'll have to watch very carefully in review. It's not ideal. Changing something like https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp.V3/Output/Models/Types/ObjectType.cs#L45-L48 to handle this would be a more scalable solution.


Consolidate CSV and FastCSV Suites

We can avoid code duplication by refactoring these two suites.
cc @brkyvz

Closed by #135


Fonts missing.

I guess you speak about the squares with a question mark inside, that replaces text in some menus ? If so the bug is perfectly known : when I changed the way assets where loaded as now I use a mount point to know where assets are located, however the fonts in question are referenced using old pathes that obviously do not work I'll fix that in the next update.

The problem is fixed on my local repo

Tell me if the new version fixed fonts issues...


Microsoft is directing its users to their “Databricks representative”?

Why would Microsoft be directing its users to their “Databricks representative”? Why would we not be contacting our Microsoft contacts?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e67ef993-6a06-2ff7-0461-303c8e42445d
Version Independent ID: 1e308f72-3f97-d522-858f-580f94e2bed8
Content: Azure Databricks SQL Analytics concepts - Azure Databricks - SQL Analytics
Content Source: databricks/sql/get-started/concepts.md
Service: azure-databricks
Sub-service: databricks-sql-analytics
GitHub Login: @mssaperla
Microsoft Alias: saperla

@GregDSmith  Thanks for the feedback! Currently, I'm working with the product team to get clarity of the above statement?

@GregDSmith As per the communication with the product team.  To get access to the ADB SQL Analytics you need to reach out to your sales representative at Microsoft.
In case, if you do not have a sales representative at Microsoft. I would suggest you file a support ticket and with a strong business use case.
Once you have created a support ticket, I would request you to share the support request number so that I can route it to the Azure Databricks team to enable access to the ADB SQL Analytics.
Hope this helps.

@GregDSmith  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Media details categories empty immediatly after upload, even though correctly uploaded

Steps to reproduce:

Install latest 2.11 branch ( 8cd9bd5524248e51ec626aeb2b0a62b3d320fd27 ), prodDebug
Upload a picture with various categories
Wait for the upload to finish
Tap the picture in the home activity
Media details open, check categories
Expected: The categories I entered. Actually: "None selected"
Wait 10 minutes
Repeat from step 4: Same problem
Kill app (real kill from Android settings > Apps) then reopen: Same problem

Not a critical bug, but I am sure some users will wonder why their categories are "lost".
Device and Android version:
Samsung S10e, Android 9
Example
https://commons.wikimedia.org/wiki/File:Seaplane_maintenance_at_Trans_Maldivian_Airways_terminal.jpg

Hey, if this is still open I would like to work on it.

It is yours! 🙂

@nicolas-raoul  are you still facing this issue on one of the latest commits?

Seems fixed :-)


Disabling Undo option

How to disable Undo feature?

What do you mean by Undo feature.

This button "undo"

It's currently not possible to disable this feature (only the revert action that removes the temp file from the server can be disabled), why do you want to disable it? What is the use case?

Because we don't want to let users delete files from this component

Existing files? I assume a user can remove files they themselves dropped?

Yes, but not from this component :)

Okay, thanks for clarifying! Final question, if you don't mind, how are you using FilePond? It helps to know the use case to determine how to best integrate this feature.

Please, this is very important. There are many many cases you just want to avoid this, for example whenever a file is uploaded, it is processed and takes effect immediately. It would be meaningless to allow the user to revoke this file.

@rayax86 That would mean there's no way for the user to alter the interface state? The file is uploaded and stays green? Is that correct?

@rikschennink That's the idea. Just need to show a tick in the button and don't register any onclick handlers on it.

@rayax86 The Just in your sentence is where the problem is. It's never just doing something. 😊
If I leave the button, it indicates the user can click it, but it won't do anything ( as it does not trigger any events ). The subtext shows to "tap to undo" but as there's no button there's nothing to tap. Removing the subtext makes the design look unbalanced, etc.
I've set up the situation on my dev machine but it's weird to upload a file and not be able to then remove it or revert your decision. It's like if this text box I'm typing this comment in would not allow me to use my backspace button.

@snuuve @rayax86 I just published version 1.4.0 which now has a allowRevert setting which defaults to true, set it to false to disable the undo feature.

@rikschennink Thanks for the update 👍
By "leaving the button" I actually mean "show something that looks the same as the button but don't allow the user to click it". Sorry I didn't make it clear.
As for your statement "It's like if this text box I'm typing this comment in would not allow me to use my backspace button", please consider cases similar to Google Instant: whenever you type in something, it triggers a change of state in the application. It might not be your case but is indeed my case.
All in all thanks for the update, this is such an awesome component. Keep up the great work!

@rayax86 No problem!
I'm still struggling to understand the use case :)

i would like to be able to change the text from tap to undo to tap to continue or something

@LordRampantHump you can do so with the labelTapToUndo property
https://pqina.nl/filepond/docs/patterns/api/filepond-instance/#labels

Please provide this feature.. for disabling remove/undo button.. sometime i need that user can only see initial files but has no right to remove those files..

@nehadhiman6 allowRemove and allowRevert should cover that

I changed revert to null and updated the tap label. This works for my use case.
server: {
  revert: null,
},
labelTapToUndo: 'tap to close',

Between, I don't understand who looks for the file delete feature in the upload component? Still, thank you for the plugin.


DH keypair error with JRuby

I'm seeing a certificate problem in JRuby 1.7.19 (2.0.0p598) when bundler hits
https://gist.github.com/nertzy/ad266b8049d161b8cfbd
See also here: https://github.com/heroku/heroku-buildpack-ruby/issues/365

I think we updated certificates since then. Let me know if it still doesn't work.

The issue still persists today.
https://github.com/bundler/bundler/issues/3588
Using http works. Using https doesn't work and results in Java::JavaLang::RuntimeException: Could not generate DH keypair.
/cc @headius

It still doesn't work.  Changing from https to http makes it work.

@ravn Can  you check to see if it works on the mirror at https://rails-assets.tenex.tech ?

It appears to work correctly.  This is with jruby <IP_ADDRESS>.


etcd master sometimes fails with flags

Repro:
From the root checkout of etcd:

./build
cp bin/etcd ./
Change Procfile slightly: for node3, instead of running bin/etcd, run etcd -- which is the binary we just copied
goreman start

...and node3 fails to run. Why?
$ goreman start
13:59:47 etcd1 | START
13:59:47 etcd2 | START
13:59:47 etcd3 | START
13:59:47 proxy | START
13:59:47 etcd3 | flag provided but not defined: -initial-advertise-peer-urls

The other two work. Why?

@barakmich I cannot reproduce this on Mac and CoreOS. Probably you messed up the Procfile? Or you run another etcd, which is a binary at some other place?

 Closing

@barakmich can you explain the solution you used?


Commenting is not supported outside diff hunks error even if I am inside the diff hunk

I checkedout the PR https://github.com/Microsoft/vscode/pull/56053 and trying to add a comment on a hunk when I got the Commenting is not supported outside diff hunks

And the output says PR is no longer valid

@ramya-rao-a does the diff view you see only contain partial diff?

After doing a git fetch origin master, I can comment


Save terminal tabs between sessions

Hello @sburlyaev
I searched on github for a idea terminal plugin that implements https://youtrack.jetbrains.com/issue/IDEA-117946#u=1467737379896 like this https://youtrack.jetbrains.com/issue/IDEA-134884 for example. I did not find it but I found yours.
Do you think, it will be possible to implement it easily in your project or if it's hard i can provide help and/or ask also help to the IntellijDea thread.
Regards

Hi @billmetangmo ,
my plugin is not an implementation of terminal itself - it just invokes a prefered terminal from your PC (e.g. Command Prompt, GitBash, iTerm). It is not linked to specific project, it is just another window in your OS.
So, you need to contact JetBrains team to move it forward.
Regards.

Oki. Thanks very much for your response :)

:thumbsup: You are welcome!


Curious new build behaviour, almost certainly user error but reportable

I swapped the latest version of Autonomie-Master for the late 2019 version using FTP.
It broke my site. I fixed the problem by reinstating the CSS, Font and JS folders in the top level directory, the newer build at Github stores these in the assets directory.

I saw, that you are using a CDN. Is it possible to reset the CDN? I have tested it several times and I am running the latest version of Autonomie on notiz.blog and I have no issues like that.

I use a managed host, which makes that harder as I may be offline a while waiting for the refresh.

Oh, OK! Can you keep me up to date if something changes? Where do you host?

Pressable.


UWP projects in VS 2015 RTM

Thank you for this great library. I've been able to use it for Windows 8.1 store apps with no issues. I am now trying to use with UWP (Win 10) apps because I am eager to try the serial port device that is now available to us in UWP. However, the UWP project code is not compatible with Visual Studio 2015 RTM (you built them with a pre-release version of the Win 10 SDK), and I'm having trouble importing/converting them to VS 2015 RTM. Do you have any plans to update these projects?

Good call! I'll try and get it done tonight.

Done!

Much appreciated! All working well, after an oddity on my end:
I am using a BU-353-S4 USB GPS receiver.  It uses a Prolific PL-2303 HXD USB to serial bridge, and I'm on the most recent (9/4/2015) drivers from Prolific.
Win32 apps recognized the NMEA stream coming off the COM port just fine, but my Windows 10/UWP app (and your test UWP app) would not read any incoming data from the serial port device. After comparing with a working UWP serial example (https://ms-iot.github.io/content/en-US/win10/samples/SerialSample.htm), I made the following change to your test app:
    serialDevice.BaudRate = 4800;
    var _foo = serialDevice.BaudRate;  // had to insert this
    serialDevice.DataBits = 8;

It's as if the the baud rate setting wouldn't stick until it was accessed. Weird!
Anyway, this is probably a bug in the Prolific device driver and/or my specific setup/hardware. I wanted to share this with you in case other people in your line of work are using USB devices in UWP apps with similar hardware.


After purging a specific variant, that variant may still be present in the cache

If you are using Vary, you might purge a specific variant, but that variant may still be present in the cache and served to clients.
In this example, the following sequence of requests is made for the Waifu: Mokou variant:
GET (MISS)
GET (HIT)
PURGE (404)
GET (HIT)

In this example, the following sequence of requests is made for the Waifu: Mokou variant:
GET (MISS)
GET (HIT)
GET (MISS)
PURGE (200)
GET (HIT)

Both of these tests "pass" over here on OSX 10.12.1 with nginx 1.9.15 and ngx_cache_purge 2.3.

Exactly same problem. I just found https://github.com/nginx-modules/ngx_cache_purge, maybe it's fixed.

@taosx My impression is that this issue is pretty fundamental to the way nginx's cache's Vary support works. So I would be surprised and impressed if someone fixed it from the module side.
I guess I should take this to the nginx mailing list. The issue is much less severe in the absence of ngx_cache_purge though, because the worst that can happen is like... you can MISS for some variant when you should HIT after some other variant gets deleted by LRU. Then you will store 2 copies of the same variant for a while.

Ok, I had a look and you can definitely successfully purge all variants of a resource if you use ngx_walk_tree. I think this will take linear time in the size of your entire cache. I don't really want that.

I investigated this, and decided that just as @sharpobject says, ngx_walk_tree will look at every file in the cache, and worse, the plugin will (in ngx_http_purge_file_cache_delete_partial_file) read each of those files to find the cache_key stored inside to decide if it matches the partial key.
Worse, it will then delete the file from disk, but if you have another layer of cache, like the file_open cache, the cache entry will not be invalidated, so it's possible that it can still be served from memory. You'd need to set fcn->exists = 0; for the relevant ngx_http_file_cache_node_t *fcn, I guess, but how do you find that?
Disclaimer: This is the first time I've looked at NGINX sources. Don't trust anything I speculate about.


WIP: FreeSurfer env

@larsoner I am trying to source SetUpFreeSurfer.sh before running the FreeSurfer command, but can't get it to update env; do you know how to do that?
CC @agramfort

but can't get it to update env; do you know how to do that?

We did this for PySurfer for a while with:
https://github.com/nipy/PySurfer/pull/132
https://github.com/nipy/PySurfer/pull/149
At some point but it ended up being fragile (it broke things on OSX, Linux, or both, can't remember offhand).
Are you on OSX? If so this workaround (what we do now in PySurfer) might be sufficient:
https://github.com/nipy/PySurfer/blob/master/surfer/io.py#L184

Codecov Report

Merging #4719 into master will increase coverage by <.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #4719      +/-   ##
==========================================
+ Coverage   87.83%   87.84%   +<.01%
==========================================
  Files         349      349
  Lines       65756    65750       -6
  Branches    11309    11308       -1
==========================================
+ Hits        57759    57760       +1
+ Misses       5128     5121       -7
  Partials     2869     2869

Hm, the error I get is below, also after I add the following to _prepare_env:
        ld_path = op.join(fs_home, 'lib', 'gcc', 'lib')
        if 'DYLD_LIBRARY_PATH' in env:
            env['DYLD_LIBRARY_PATH'] = ld_path + ':' + env['DYLD_LIBRARY_PATH']
        else:
            env['DYLD_LIBRARY_PATH'] = ld_path

In [2]: mne.bem.make_watershed_bem('fsaverage', '.', overwrite=True)

Running mri_watershed for BEM segmentation with the following parameters:

SUBJECTS_DIR = .
SUBJECT = fsaverage
Results dir = ./fsaverage/bem/watershed

Running subprocess: mri_watershed -useSRAS -surf ./fsaverage/bem/watershed/fsaverage ./fsaverage/mri/T1.mgz ./fsaverage/bem/watershed/ws

Mode:          use surfaceRAS to save surface vertex positions
Mode:          Saving out BEM surfaces

*********************************************************
The input file is ./fsaverage/mri/T1.mgz
The output file is ./fsaverage/bem/watershed/ws
dyld: lazy symbol binding failed: Symbol not found: ___emutls_get_address
  Referenced from: /Applications/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ___emutls_get_address
  Referenced from: /Applications/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
  Expected in: /usr/lib/libSystem.B.dylib

(u'', u'')
---------------------------------------------------------------------------
CalledProcessError                        Traceback (most recent call last)
<ipython-input-2-5182d048f8c8> in <module>()
----> 1 mne.bem.make_watershed_bem('fsaverage', '.', overwrite=True)

/Users/christian/Code/mne-python/mne/bem.py in make_watershed_bem(subject, subjects_dir, overwrite, volume, atlas, gcaatlas, preflood, show, verbose)

/Users/christian/Code/mne-python/mne/utils.pyc in verbose(function, *args, **kwargs)
    726         with use_log_level(verbose_level):
    727             return function(*args, **kwargs)
--> 728     return function(*args, **kwargs)
    729
    730

/Users/christian/Code/mne-python/mne/bem.py in make_watershed_bem(subject, subjects_dir, overwrite, volume, atlas, gcaatlas, preflood, show, verbose)
   1107                 'Results dir = %s\n' % (subjects_dir, subject, ws_dir))
   1108     os.makedirs(op.join(ws_dir, 'ws'))
-> 1109     run_subprocess(cmd, env=env)
   1110
   1111     if op.isfile(T1_mgz):

/Users/christian/Code/mne-python/mne/utils.pyc in run_subprocess(command, verbose, *args, **kwargs)

/Users/christian/Code/mne-python/mne/utils.pyc in verbose(function, *args, **kwargs)
    726         with use_log_level(verbose_level):
    727             return function(*args, **kwargs)
--> 728     return function(*args, **kwargs)
    729
    730

/Users/christian/Code/mne-python/mne/utils.pyc in run_subprocess(command, verbose, *args, **kwargs)
   1217         err_fun = subprocess.CalledProcessError.__init__
   1218         if 'output' in _get_args(err_fun):
-> 1219             raise subprocess.CalledProcessError(p.returncode, command, output)
   1220         else:
   1221             raise subprocess.CalledProcessError(p.returncode, command)

CalledProcessError: Command '['mri_watershed', '-useSRAS', '-surf', './fsaverage/bem/watershed/fsaverage', './fsaverage/mri/T1.mgz', './fsaverage/bem/watershed/ws']' returned non-zero exit status -6

IIRC that looks a lot like the errors I got with PySurfer on OSX without the fix there. Maybe the DYLD_LIBRARY_PATH needs to be prepended instead of appended...
Do the PySurfer tests pass for you?

And to be clear, you have already sourced the Freesurfer setup script in a terminal (and the command works in the terminal) before running this Python script?

And to be clear, you have already sourced the Freesurfer setup script in a terminal (and the command works in the terminal) before running this Python script?

Ah no, if I do that then the command works :) , the point of this was to try to add it in the Python wrapper. If that is not doable then I guess we should raise a better error requesting the user to quite Python, source the setup script, and retry?

I'd just improve the error message. But if you want to follow the trail of PRs/issues I linked to and try to make that solution work properly to avoid this extra step, that's fine by me

@christianbrodbeck okay to close this one, then?


Removes clcollins from reviewers

This removes me from the reviewers group in the OWNERS file, since I'm
not involved with the project directly anymore.
Signed-off-by: Christopher Collins<EMAIL_ADDRESS>

Codecov Report

Merging #581 (56a5bc1) into master (50eb9ff) will not change coverage.
The diff coverage is n/a.


Clear views array on job_create event

Fixes juttle/outrigger#83
When running a different program from our original program, there
was an issue with the old views getting reinstantiated because they
still existed in redux store. This change resets the views in the store
to an empty object so new views are only instantiated when we have info
about them.

@go-oleg

looks good


initial Fastlane structure

For F-Droid inclusion, see #1
This is just the "basic starter package", please build on it and e.g. move in the screenshots currently stored in /Screenshots – they should go to fastlane/metadata/android/en-US/images/phoneScreenshots/. Be welcome to use my Fastlane Cheat Sheet for orientation.

I just merged the PR and moved the screenshots to the phoneScreenshots folder.

Thanks! Looks good. Just updated the config on my end so Fastlane will be considered when pulling the next release. For F-Droid itself, we can simply adjust the commit: value for the initial version to point to the Fastlane commit instead of the last tag – as Fastlane was the only thing added/changed after that.
Urn, that is once you've fixed versionName: while the tag says v0.1.3, you've set versionName "v0.0.3-beta03(14022022)" – that doesn't match and thus makes automated updates impossible. The tag name should include either versionName or versionCode, optionally with a fixed prefix or suffix. So may I suggest you set versionName "0.1.3" so it matches – and we then start with that commit at F-Droid?

Hi @IzzySoft I will fix set this in the next release. versionName will be "0.1.4", versionCode will be 4, and tag will be v0.1.4. Will that be fine?

That sounds perfect, yes! Thanks! Please let us know once it is in place.


Can not pass the code checking, nothing hapens

Describe the Issue
Can not pass the code checking, nothing happens.
entering the string and pressing the check button has no effect and I can't get through this step.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/step-41
Your code
const allCategories = {
  299: { category: "Career Advice", className: "career" },
  409: { category: 'Project Feedback', className = 'feedback' }
};

Expected behavior
after pressing 'Check Your Code' button message must appear bellow it and text on the button must change to some thing like 'Go to the next step'
Screenshots

System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

There's syntax error in the above code:
SyntaxError: unknown: Invalid shorthand property initializer. (10:49)

   8 | const allCategories = {
   9 |   299: { category: "Career Advice", className: "career" },
> 10 |   409: { category: 'Project Feedback', className = 'feedback' }
     |                                                  ^
  11 | };
  12 |
  13 | const timeAgo = (time) => {

I'm going to leave issue open for now, as it might be worth improving how this problem is communicated (other than in console, which might not be open).

Yes I know about this error. but should not the pressing the test button gets a msg or something - the issue is that nothing happens when I press the button

expected the msg like one on the screenshot but it is not there when mistakes on the step mentioned above

The Python curriculum has the opposite problem. If there is a syntax error, the first hint shows as the "failure" reason.
In the Python curriculum's case, there are two kinds of test:

Just testing the Camper\s code as a string
Testing the Camper's code by evaluating it

As far as I am aware, we always evaluate the JS code. So, I think we are best with a default message showing up:

Your code failed to run. Check the console for more information.

I vote for showing a default message since this comes up frequently in the forum.
I am going to go ahead and open this up for contribution to get the ball rolling

Aren't we supposed to close this issue now since #54694 has fixed it?

I think this is fine to close, yeah


Reducer plugins should be able to receive actions from other forms

Feature Request
What is the current behavior?
https://github.com/erikras/redux-form/issues/1127 introduced a behavior where redux-form plugins only receive actions that belong to that form. I would say this is pretty counterintuitive and prevents some behaviors that would be nice to have, particularly in scenarios where you're using destroyOnUnmount: false.
What is the expected behavior?
I would expect plugins to receive all actions. It sort of goes against the redux paradigm that I would not receive certain actions in the reducer based on some part of the action (in this case action.meta.form). In the plugin, I could check whether a given redux-form action is coming from my form or not.
This would be a breaking change so we'd probably have to introduce it as an option.
Other information
Here is the line where the existing behavior happens: https://github.com/erikras/redux-form/blob/master/src/createReducer.js#L806

Published fix in v8.1.0.


Windows Support

Hi, the methods
loop.add_signal_handler()
loop.remove_signal_handler()
are not supported on Windows per the asyncio documentation (see here: https://docs.python.org/3/library/asyncio-platforms.html#asyncio-windows-subprocess). For Celery it is possible to circumvent this by installing the gevent package and setting the "--pool=gevent" argument for the worker process.
I was wondering if it is possible to implement a similar argument for the SAQ settings or if that is out of scope? Thanks.

windows was already supported
SIGNALS = [signal.SIGINT, signal.SIGTERM] if os.name != "nt" else [signal.SIGTERM]

did something here change?

closing this as out of scope for now


error: unknown option '--rerun'

It seems such code below not going to a correct way
https://github.com/serenity-js/serenity-js/blob/master/packages/cucumber/src/cli/CucumberOptions.ts
 asArgumentsForCucumber(version: Version): string[] {       console.log(version)         return Object.keys(this.config)             .reduce(                 (acc, option: keyof CucumberConfig) =>                     isNotEmpty(this.config[option])                         ? acc.concat(this.optionToValues(option, this.config[option], version))                         : acc,                 [ 'node', 'cucumber-js' ],             )             .concat(this.config.rerun ?? []);     }
cucumberOpts from my side
    cucumberOpts: {       rerun<EMAIL_ADDRESS>   }
Result will show as picture:
I do think<EMAIL_ADDRESS>should be remove, if not, will go wrong with " error: unknown option '--rerun' "

Hi, @jan-molak
Good for you, I appreciated it very much, I will try this fixed version


Installing brew broke suid apps in /usr/local/bin

Install brew changed the ownership of all files in /usr/local to my account, which broke suid apps in /usr/local/bin. They now run as me, and they are meant to run as other users.
This is also a security issue. /usr/local/ shouldn't be a directory a user can just change the contents of. That's what the home directory is for.

As I'm sure you've already figured out, you'll need to reset ownership as needed for your local configuration as the generic installer doesn't support that case.
In the future, always fill out the complete template regardless of whether you think it's relevant.

I did a chmod back to root of /usr/local. Changed the suid programs back to their correct ownerships.
I still think this is a bug that will catch the average user, who might not understand what just happened.  Surely you should be more careful about changing existing suid binaries.

For that matter, their config files got their permissions changed too. They weren't meant to be readable.

The installer told you what it was going to do and you accepted it.


piping included

Please look at my code and review it :smiley:

@pv2k  please fix the conflict

I will look into it.


False positive "invalid_ref" for IDs on links

I'm trying to implement footnotes. Here's my footnote, this would go inline in a paragraph:
[1]($link.ref("1").attrs("footnote")

Later in the text, I'd have the content for the footnote, as another link:
[^1]($link.url("https://example.com").id("1"))

However, I get an error saying that "1" is an invalid ref. If I change the second snippet to be a heading instead of a link, then it works as expected.
[EDIT] Maybe ref thinks that only sections can be linked to? I can see why that would be reasonable in most cases, but in the case of footnotes this is a bit annoying because I don't want all my footnotes to show up in the table of contents.

Linking to ids defined in the same content page is a corner case (totally legitimate one, but still) that is not implemented yet. We had some false negatives before when linking to non-section Ids from superhtml, but this one is a separate thing.
Now that v0.7.2 is out, this is currently at the top of my list for missing features to implement.

Nvm I've actually now looked into it and I already had implemented this, I just forgot about it lol.
I tried to reproduce the bug but failed: the ref gets recognized successfully and everything is linked successfully.
Make sure you're using the latest release of Zine and then please commit a full repro in a branch for me to take a look at. What's almost certainly happening is that the footnote is placed in a location of the markdown AST where I forgot to properly record seen IDs.


Nice! Thanks!


update goreleaser version to get darwin/arm64 support

Description

  • building binaries
   • DEPRECATED: skipped darwin/arm64 build on Go < 1.16 for compatibility, check https://goreleaser.com/deprecations/#builds-for-darwinarm64 for more info.

the goreleaser version skips the darwin/arm64 build
Related Issues

#414
Motivation and Context

Without a darwin/arm64 build it is not possiable to run this provider on a M1 Mac
How Has This Been Tested?

the build step of make release-no-publish run successfully
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

I approved a run of tests on CI, let's wait for results...


Support for next.js ^3

Just wondering where it is on the road map...

Just tested it with<EMAIL_ADDRESS>and seems to work great.

Updated peerDependencies in version 1.0.27

Yea I forked and came to same conclusion. Great lib!


Use 11ty collections to display all PAR data

This change demonstrates how to collect all PAR scores on a page when using the newer 11ty-data-cascade-style setup for per-page scoring.
The key insight here is to take advantage of 11ty's Collections feature. Within a given template, this allows us to iterate over the data for many pages across the site. While it's typically useful for generating things like sitemaps or blog listings, we can also use it to list the PAR data.
This PR currently uses the generic collections.all built-in collection to get all pages. For more control over the list, check out the 11ty docs for more details on how to do fine-grained filtering and sorting in a custom collection.

Straight to the goods: https://jbum-par-stats-jj-v2.pr.digital.ca.gov/pr/jbum-par-stats-jj-v2/par-statistics/


refactor: Remove redundant regex prefix from class names and fix capitalization.

References

Depends on PR#58.
To review in parallel with PR#58, diff against PR#58 locally. In the repo run:

git fetch upstream pull/58/head:pr-58
git fetch upstream pull/59/head:pr-59
git diff pr-58 pr-59

Description
Additions:

Add <algorithm> to TaggedTransition.hpp as reordering of includes caused by file name changes causes previous clang-tidy warning to become a compiler error.

Renames:

DFAByteState to ByteDfaState
DFAUTF8State to Utf8DfaState
NFAByteState to ByteNfaState
NFAUTF8State to Utf8NfaState
Template parameters named DfaState/DfaStateType to TypedDfaState
Template parameters named NfaStateType to TypedNfaState
RegexDFA* to Dfa*
RegexNFA* to Nfa*
NFA* to Nfa*
DFA* to Dfa*
LALR1Parser to Lalr1Parser

Does not rename:

*AST* as there are too many instances of this and it will create conflicts with future PRs that are already submitted. This will be fixed in separate clang-tidy PRs for each file in the future.

Validation performed
Previously existing tests still succeed.

Summary by CodeRabbit
Release Notes

New Features

Introduced a new Dfa class for representing Deterministic Finite Automata.
Added methods for state management and intersection operations in the Dfa class.

Renaming and Refactoring

Renamed RegexNFA to Nfa and RegexDFA to Dfa across the codebase for consistency.
Updated related types and method signatures to reflect the new naming conventions.
Changed casing of LALR1Parser to Lalr1Parser for uniformity.

Documentation

Updated documentation comments for consistency, including renaming references to LALR1Parser to Lalr1Parser.

Bug Fixes

Corrected type references in various classes and tests to ensure proper functionality with the new naming conventions.

These changes enhance clarity and maintainability while introducing new capabilities for finite automata handling.

Before we proceed, a quick question: do we really need to differentiate DFA state type and NFA state type? Can we have a generic type to mark whether the input is byte or unicode?

Just to clarify: we don't necessarily do this in the current PR, but it's some design decision we should make

Before we proceed, a quick question: do we really need to differentiate DFA state type and NFA state type? Can we have a generic type to mark whether the input is byte or unicode?

Yea, one of the other PRs combine these into a single type.

Before we proceed, a quick question: do we really need to differentiate DFA state type and NFA state type? Can we have a generic type to mark whether the input is byte or unicode?

I thought one of the other PRs already posted combine these into a single type, but it seems that's not the case. I'll add a PR to combine the types.

Do u think we can do it in this PR? 'cuz reviewing the current renaming changes and then reviewing another PR that has a lot of overlapped overwrite would duplicate the work


L10n.load should return synchronous future, otherwise black frame is shown

Currently the implementation of load() function returns Future
  static Future<L10n> load(Locale locale) {
    final name = (locale.countryCode?.isEmpty ?? false)
        ? locale.languageCode
        : locale.toString();
    final localeName = Intl.canonicalizedLocale(name);
    return initializeMessages(localeName).then((_) {
      Intl.defaultLocale = localeName;
      final instance = L10n();
      L10n._current = instance;

      return instance;
    });
  }

However, this causes a black frame to appear just before the MaterialApp renders (e.g. like here, but I see this also in our app when we rebuild MaterialApp).
This is frame by frame view of our app when the MaterialApp is rebuilt:
https://user-images.githubusercontent.com/16854239/194139457-af5ac13a-9e1e-43d7-b355-734594da37dd.mp4
It should by default return SynchronousFuture (see example here). I succeeded with something like this:
  static Future<L10n> load(Locale locale) {
    final name = (locale.countryCode?.isEmpty ?? false)
        ? locale.languageCode
        : locale.toString();
    final localeName = Intl.canonicalizedLocale(name);
    initializeMessages(localeName).then((_) {
      Intl.defaultLocale = localeName;
      final instance = L10n();
      L10n._current = instance;

      return instance;
    });

    return SynchronousFuture<L10n>(L10n());
  }

Would you need a reproducible example?

Hi @orestesgaolin,
Thanks for reporting this!
This should be fixed now with the intl_utils 2.8.1.
Note that the intl_utils allows deferred loading of localization files (the use_deferred_loading config option), so the released fix should only work if deferred loading is disabled.
Related issues: flutter#87926, flutter#93865, flutter-intl-vscode#76
I'm closing this issue as resolved.
In case you notice any irregularity, feel free to reopen it.

Thanks a lot! Should the delegate get regenerated after this fix? I updated the extension and arb files, but my L10n delegate is still unchanged.

All right, I think I know what's the issue now:
My dependencies, using Flutter 3.3.8:
dev_dependencies:
  bloc_test: ^9.0.3
  flutter_test:
    sdk: flutter
  very_good_analysis: ^3.0.1
  intl_utils: ^2.8.1

And the pub get output:
Running "flutter pub get" in my-app...
Because test >=1.16.0-nullsafety.19 <1.16.6 depends on test_api 0.2.19 and test >=1.16.6 <1.17.10 depends on analyzer ^1.0.0, test >=1.16.0-nullsafety.19 <1.17.10 requires test_api 0.2.19 or analyzer ^1.0.0.
And because test >=1.17.10 <1.20.0 depends on analyzer >=1.0.0 <3.0.0 and test >=1.20.0 <1.21.2 depends on test_api 0.4.9, test >=1.16.0-nullsafety.19 <1.21.2 requires test_api 0.2.19 or 0.4.9 or analyzer >=1.0.0 <3.0.0.
And because test >=1.21.0 <1.21.6 depends on analyzer >=2.0.0 <5.0.0 and test >=1.21.6 <1.21.7 depends on test_api 0.4.14, test >=1.16.0-nullsafety.19 <1.21.7 requires test_api 0.2.19 or 0.4.9 or 0.4.14 or analyzer >=1.0.0 <5.0.0.
And because test >=1.21.7 <1.22.0 depends on test_api 0.4.15 and test >=1.22.0 depends on test_api 0.4.16, test >=1.16.0-nullsafety.19 requires test_api 0.2.19 or 0.4.9 or 0.4.14 or 0.4.15 or 0.4.16 or analyzer >=1.0.0 <5.0.0.
And because intl_utils >=2.8.0 depends on analyzer ^5.0.0 and every version of flutter_test from sdk depends on test_api 0.4.12, one of intl_utils >=2.8.0 or test >=1.16.0-nullsafety.19 or flutter_test from sdk must be false.
And because my_app depends on bloc_test ^9.0.3 which depends on test ^1.16.0, intl_utils >=2.8.0 is incompatible with flutter_test from sdk.
So, because my_app depends on both flutter_test from sdk and intl_utils ^2.8.1, version solving failed.
pub get failed (1; So, because my_app depends on both flutter_test from sdk and intl_utils ^2.8.1, version solving failed.)
exit code 1

Fixed that by:
dependency_overrides:
  analyzer: ^5.2.0

I updated the extension and arb files, but my L10n delegate is still unchanged.

Only the messages_all.dart file should be updated.

Because test >=1.16.0-nullsafety.19 <1.16.6 depends on test_api 0.2.19 and test >=1.16.6 <1.17.10 depends on analyzer ^1.0.0, test >=1.16.0-nullsafety....

Regarding the problem with dependencies, the intl_utils 2.8.1 now depends on the analyzer: ^5.0.0.
Great if dependency override fixed it.


Staging testing - Borrow spotlight login prompt

Original issue #2438
Estimate 1

Have you tried local wallet as well?
Clear browser cache and try, then import a local wallet and try.

@VerevkinAlexander ping

@sschiessl-bcp
No I have not. Thanks, I'll try as soon as possible.

@sschiessl-bcp
I have tried local wallet, and result is the same - no issue.

Ok thank you!


Feature: Added CRC-8 Checksum

Addresses https://github.com/gchq/CyberChef/issues/543
Calculates the CRC-8 checksum for a given input. Allows the user to select a checksum algorithm from a drop down.

Excellent stuff. Thanks very much for this contribution, it's always great to add support for more algorithms.
I added CRC-8 to the 'Generate all hashes' operation (which also calculates all supported checksums).


Allow functions that override _d_throwc to call original implementation

Implements what I suggested here<EMAIL_ADDRESS>Allows users to override _d_throwc but still let's them call the original implementation (onThrow) in this case.
I chose onThrow because it follows the pattern used for _d_assert which calls OnAssertError

If you want to change the language semantics for throwing errors to abort, then you should lobby for that change. If you don't want to wait please maintain this hack in your own druntime copy.
While I partly agree about this change (and we recently introduced abort), first constructing an Error and then aborting is a weird implementation.

See #1337 for the abort function.


fix: Enables scroll content for Modal widgets in CRUD template

Description
Enables scrolling for Modals in CRUD templates

In fixed mode, this will help the user to avoid an extra step
In auto-layout mode, this is must have since we don't provide the user an option to enabled scrolling.

PR fixes following issue(s)
Fixes #23340
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview

Closing this PR since this is not the right way to update CRUD templates. We make use of an internal app to do so.
We've documented it here.


Failure with KeyError on second cASO run

Description
The first time caso runs it seems to work:
# caso-extract
2019-09-11 16:30:34.996 11276 INFO caso.extract.manager [-] Extracting records for project 'ccfe'
2019-09-11 16:30:50.281 11276 INFO caso.extract.manager [-] Extracted 1250 records for project 'ccfe' from 1970-01-01 00:00:00 to 2019-09-11 15:30:34.995996
2019-09-11 16:30:50.282 11276 INFO caso.extract.manager [-] Extracting records for project 'jintrac'
2019-09-11 16:30:57.037 11276 INFO caso.extract.manager [-] Extracted 217 records for project 'jintrac' from 1970-01-01 00:00:00 to 2019-09-11 15:30:34.995996
2019-09-11 16:30:57.038 11276 INFO caso.extract.manager [-] Extracting records for project 'lz'
2019-09-11 16:31:51.333 11276 INFO caso.extract.manager [-] Extracted 6021 records for project 'lz' from 1970-01-01 00:00:00 to 2019-09-11 15:30:34.995996

But the second time it is executed:
# caso-extract --config-file
/opt/caso/etc/caso/caso.conf
2019-09-11 16:46:09.333 11420 INFO caso.extract.manager [-] Extracting records for project 'ccfe' {}
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager [-] Cannot extract records for 'ccfe': KeyError: u'02acf02a-b635-4276-8558-c519b9dcf187'
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager Traceback (most recent call last):
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager   File "/opt/caso/lib/python2.7/site-packages/caso/extract/manager.py", line 104, in _extract
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager     extract_to)
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager   File "/opt/caso/lib/python2.7/site-packages/caso/extract/nova.py", line 281, in extract_for_project
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager     if records[ server.id].status == "completed":
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager KeyError: u'02acf02a-b635-4276-8558-c519b9dcf187'
2019-09-11 16:46:14.449 11420 ERROR caso.extract.manager

A clear failure due to not having unit tests :cry:


Added list manipulation methods

closes #66

Add proper details in the the PR then i will merge it.

Add proper details in the the PR then i will merge it.

@UTSAVS26 : okay done


Issue-37: Set up a Custom Domain Name

Domain name should be similar to "flatematefinder", if not exact. The domain extension doesn't matter, but post the website link as a comment and mark the issue as done when you're completed.

http://flatmatefinder.xyz/


Prepare for 3.2.0 release

Let's not merge that for now, I restarted the job and it looks better.

The release was successful in the other PR second run so I will close this.

ok thanks @gsmet we have a  3.2.0 tag
let me know if you need anything else

It should be all good now. Thanks.


fix vpa chart values

How to categorize this PR?

/kind bug
/priority normal
What this PR does / why we need it:
make verify  on the current master throws a chart render error.
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/loki/charts/utils-templates resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/utils-templates
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/utils-templates resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/utils-templates
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/charts/application/charts/utils-templates resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/utils-templates
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/charts/application/values.yaml resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/values.yaml
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/charts/runtime/charts/utils-templates resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/utils-templates
walk.go:74: found symbolic link in path: /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/charts/runtime/values.yaml resolves to /Users/d060239/go/src/github.com/gardener/gardener/charts/seed-bootstrap/charts/vpa/values.yaml
Error: YAML parse error on seed-bootstrap/charts/vpa/charts/runtime/templates/deployment-admission-controller.yaml: error converting YAML to JSON: yaml: line 9: could not find expected ':'

Use --debug flag to render out invalid YAML

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@timuthy
Release note:

make verify on the master branch is fine. Also locally:
$ make verify
> Check
Executing golangci-lint
Executing go vet
Executing gofmt/goimports
All checks successful
> Check Helm charts
Checking for chart symlink errors
Checking whether all charts can be rendered
All checks successful
> Format
> Test

It is also failing after make install-requirements?

/status author-action

Thanks @ialidzhikov , I had helm > v3 installed so downgrading fixed the issue.
Nonetheless, deploymentLabels is referenced in the helm chart so should also be added in the values.yaml to be consistent?
When upgrading to helm v3 this will also throw a chart rendering error.

/remove king/bug


Remove miq_ae_dialog_spec.rb

We don't actually build dialogs this way, instead using the dialogs
stored as yaml files in the miq_dialogs table.  This test was only
serving as a legacy performance test, so it's not needed.  This saves 15
seconds, and also removes the most database intensive test (11664 SQL
statements)
@gmcculloug Please review
cc @jrafanie  :scissors:

:+1:


feat: port SetTheory.Game.Pgame

This just needs someone to deal with the termination proofs (which use the custom tactic) at this point, I think


feat: 0x1C - SHR opcode

SINCE
GROUP

Constantinople
Comparison & Bitwise Logic Operations

Index 1 is top of the stack. See PUSH.NotesShift the bits towards the least significant one. The bits moved before the first one are discarded, the new bits are set to 0.Stack inputshift: number of bits to shift to the right.value: 32 bytes to shift.Stack outputvalue >> shift: the shifted value. If shift is bigger than 255, returns 0.SINCE	GROUP
Constantinople	Comparison & Bitwise Logic Operations
Index 1 is top of the stack. See [PUSH](https://www.evm.codes/#60).
Notes
Shift the bits towards the least significant one. The bits moved before the first one are discarded, the new bits are set to 0.
Stack input
shift: number of bits to shift to the right.
value: 32 bytes to shift.
Stack output
value >> shift: the shifted value. If shift is bigger than 255, returns 0.
Error cases
The state changes done by the current context are reverted in those cases:
Not enough gas.
Not enough values on the stack.

Down to try this for funzies :)


MemoryError when train_lpcnet

I train the model on another dataset, the features size is :

It seems that all data is loaded into CPU memory. My machine has 100GB+ CPU memory, and 8GB GPU memory. I met the memory error, when do train_lpcnet.py.
lambda_1 (Lambda)               (None, None, 128)    0           feature_dense2[0][0]
                                                                 feature_dense2[0][0]
__________________________________________________________________________________________________
concatenate_2 (Concatenate)     (None, None, 512)    0           reshape_1[0][0]
                                                                 reshape_2[0][0]
                                                                 lambda_1[0][0]
__________________________________________________________________________________________________
gru_a (CuDNNGRU)                [(None, None, 384),  1034496     concatenate_2[0][0]
__________________________________________________________________________________________________
concatenate_3 (Concatenate)     (None, None, 512)    0           gru_a[0][0]
                                                                 lambda_1[1][0]
__________________________________________________________________________________________________
gru_b (CuDNNGRU)                [(None, None, 16), ( 25440       concatenate_3[0][0]
__________________________________________________________________________________________________
dual_fc (MDense)                (None, None, 256)    9216        gru_b[0][0]
==================================================================================================
Total params: 1,259,334
Trainable params: 1,259,334
Non-trainable params: 0
__________________________________________________________________________________________________
Traceback (most recent call last):
  File "./src/train_lpcnet.py", line 104, in <module>
    pred_in = ulaw2lin(in_data)
  File "/home/storage11/heyunchao/Torch_Programs/LPCNet/src/ulaw.py", line 11, in ulaw2lin
    return s*scale_1*(np.exp(u/128.*math.log(256))-1)
MemoryError

Could someone tell me what I am wrong?

I rewrite train_lpcnet.py to use model.fit_generator, then problem solved.
If someone wants to use my modified version. I will create a pull request.

If someone is in interest, here is the PR: https://github.com/mozilla/LPCNet/pull/15


Added Focus Nodes

Added focus nodes to all the forms.
This PR closes #31 .
Focus Nodes of authentication forms : #34

@Nitish145 please let me know if I have missed any form.

@Nitish145 can you please review this.

Pull Request Test Coverage Report for Build 415571532

0 of 28 (0.0%)  changed or added relevant lines in 3 files are covered.
186 unchanged lines in 12 files lost coverage.
Overall coverage increased (+3.2%) to 62.584%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ui/views/groups/assignment_details_view.dart
0
6
0.0%

lib/ui/views/profile/edit_profile_view.dart
0
11
0.0%

lib/ui/views/projects/edit_project_view.dart
0
11
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/models/projects.dart
1
90.74%

lib/services/local_storage_service.dart
1
26.32%

lib/ui/views/profile/edit_profile_view.dart
1
0%

lib/ui/views/groups/assignment_details_view.dart
2
0%

lib/ui/views/projects/edit_project_view.dart
2
0%

lib/ui/views/home/home_view.dart
3
92.31%

lib/utils/image_test_utils.dart
3
78.26%

lib/services/API/projects_api.dart
6
93.7%

lib/utils/router.dart
22
54.84%

lib/ui/views/profile/profile_view.dart
26
0.98%

Totals

Change from base Build 397502284:
3.2%

Covered Lines:
2601

Relevant Lines:
4156

💛  - Coveralls

Can you merge this ? @Nitish145


OutdatedModelError after restart the server

Hello @rvinzent , we are using your code to create dynamic models. However, after we shutdown the django server and restart using python3 manage.py runserver <IP_ADDRESS>:8000 , we would no longer be able to write new rows into the dynamic models we created before the restart. More specifically, when we call annotations_m.objects.create(**kwargs) (annotations_m is a model from calling .as_model()), we get a OutdatedModelError from check_model_schema in dynamic_models/factory.py.
Before we restart the server, we do not get such Exception when calling the '.create(**kwargs)` function.
Could you please help us out?

@YinanDanielZhou what are you using for Django cache? If the cache is still alive while you restart the server then I think it will become invalid. I am planning on re-implementing this cache and "outdated model" check whenever I find the time/motivation.
Please don't hesitate to fork the repo and submit a PR if you can find a fix 🙂

There is no specifications about cache in the settings.py so I am guessing it is using the default cache. Could you please explain to me more what this check_model_schema does? I don't really understand Called on pre_save to guard against the possibility of a model schema change     between instance instantiation and record save. I will try to fix it myself.

hey @rvinzent , I was not able to find a good fix to it and I am thinking of just ignoring the OutdatedModelError. What kind of danger would that cause?

@YinanDanielZhou it would help me out a lot of you are able to provide some code with a reproduction if the bug.
The error is intended to prevent the case when a model is generated, and then the schema is updated, so the model shouldn't be used anymore and a new one should be generated with as_model().
If you ignore it you might see some other database errors but I don't think anything with ruin your data.

Hi, I'm also experiencing the same problem.
For reference, I'm using django rest framework to dynamically create CRUD endpoints for the dynamic schemas
    def get(self, request: Request, *args, **kwargs):
        slug_schema = ModelSchema.objects.get(name="loans")
        SlugModel = slug_schema.as_model()
        instance = SlugModel.objects.create(**{
            "name": "TEST NAME",
            "description": "TEST DESCRIPTION"
        })
        print(instance.id, flush=True)
        return Response(status=HTTPStatus.OK)

The ModelSchema loans is loaded into the database via django fixtures and migrations.
When I run the above, I get the following error:

I also have pytest test cases for this using an SQLite database and it works flawlessly there.
Any pointers on how to fix this?

I believe I've found the issue and fixed in in #27 and #28.
The fix has been released on version 0.2.1rc0.
@ric-sapasap @YinanDanielZhou would either of you mind confirming that the fix works?
Thanks!

Copy on this @rvinzent. Will test the soonest. Thank you! :+1:

Hi, just tested this. It works for my use case. Thank you so much @rvinzent!

@ric-sapasap  Great! I re-released this fix as 0.3.0 because I removed some public methods and added a migration to remove a private field _modified on the ModelSchema model.
I'll go ahead and update the wiki. Thanks for testing!


List by walking key path does not work in a loop

Describe the bug

From the forum: The list by walking key path block does not appear to work when placed in a lop.
Affects

[ ] Designer
[ ] Blocks editor
[x] Companion
[x] Compiled apps
[ ] Buildserver
[ ] Other... (please describe)

Expected behavior

The block should work as intended whether it is placed in a loop or not.
Steps to reproduce

Create a list containing some dictionaries
Create a loop over the length of the list
Construct a key path that includes the index and a walk all at level block
Run the code and see that nothing happens

After looking into this further, it appears that the issue has to do with how Kawa handles (or rather, doesn't) having a fully qualified static field referenced from code that is within a macro. The walk all at level block maps to com.google.appinventor.components.runtime.util.YailDictionary:ALL. This seems to work when the code is a a top level construct, but once you put it inside of the loop, Kawa throws an invalid syntax exception. I also tried to switch to using just YailList, since we define it as an alias within runtime.scm, but that also fails but due to the fact that Kawa maps it to a package instance rather than resolving the alias.


Give the parser hints about variable names for implicit multiplication

Suppose the answer to a mathematical expression part is x*(1+x). A student might write x(1+x).
Currently, the parse interprets x(...) as a function application. It could be given a hint that x is a variable, so x(...) is an implicit multiplication.

We've thought more about this and decided it's a can of worms. There's no robust way of deciding when a juxtaposition of a name and a bracket should be multiplication, and an option to explicitly set the behaviour is unlikely to be used.
We've decided to just leave in the warning "function is not defined".

We're going to try adding an option to insist on single-letter variable names (#345) and no unknown functions. Those will instead be interpreted as implicit multiplications.
e.g. xy = x*y and x(x+1) = x*(x+1).

See also #513

Here's one that just tripped me up, and shows that we can't parse first and then turn function applications into multiplications: e^x(2x+2y) is e^( x(2x+2y) ), not e^x * (2x+2y) using the current parser.

#513 is closed, but it doesn't deal with the case e^x(x+1). I think it's fair to see the implicit multiplication as having higher precedence than explicit multiplication.

A student entered something like 5xe^(2x+1), which was rewritten to 5(x*e)^(2x+1) using "Force single letter variable names".
The x needs to be pulled away from the exponentiation, which makes things harder. Maybe this does all need to happen during parsing, after all.

I think the two problems I identified to do with exponentiation are now fixed, so I'll close this.


unexpected keyword argument 'experimental_python_types'

Hey there,
For Trino, the trino python client introduced a breaking change:
https://github.com/trinodb/trino-python-client/blob/master/CHANGES.md?plain=1#L27-L34
I believe this results in soda breaking for trino.
I think this line can be removed: https://github.com/sodadata/soda-core/blob/main/soda/trino/soda/data_sources/trino_data_source.py#L88
Terminal output:
soda test-connection -c configuration.yml -d ov
[16:28:19] Soda Core 3.0.26
[16:28:19] Could not connect to data source "ov": Connection.__init__() got an unexpected keyword argument 'experimental_python_types'
  | Connection.__init__() got an unexpected keyword argument 'experimental_python_types'
[16:28:19] Could not connect to data source "ov": Connection.__init__() got an unexpected keyword argument 'experimental_python_types'
  | Connection.__init__() got an unexpected keyword argument 'experimental_python_types'
Unable to connect to 'ov'.
Traceback (most recent call last):
  File "/home/robbert/.local/bin/soda", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3/dist-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/home/robbert/.local/lib/python3.10/site-packages/soda/telemetry/soda_tracer.py", line 78, in wrapper
    raise e
  File "/home/robbert/.local/lib/python3.10/site-packages/soda/telemetry/soda_tracer.py", line 71, in wrapper
    result = fn(*original_args, **original_kwargs)
  File "/home/robbert/.local/lib/python3.10/site-packages/soda/cli/cli.py", line 559, in test_connection
    has_valid_connection = ds.has_valid_connection()
AttributeError: 'NoneType' object has no attribute 'has_valid_connection'

Thank you @vijaykiran !


how to push images to Container Registry (harbor)

hello,
i used this IAC to setup pare metal cluster.
the thing related to CR is not clear, what will be the port ,URL, username and password. that should be passed to viya4-Deployment.
viya4-deployment is talking about tfstate but it's not created here and not used

That feature snuck in there, currently we can provision a machine for CR but the installation process is not yet implemented.
I will be updating the example files/doc to remove that and add a TODO file for the CR installation.


docs: replace references to publish plugin w/ generateNotes

Merging this PR will publish the following release:

3.1.1 (2018-02-11)
Bug Fixes

dry-run is always set, remove use in conditional (830d931)


resource_vm_qemu: allow . (dot) in name of virtual machine

fixes #885

@vilhelmprytz thanks for you PR but it's not how regex works, in fact also the actual regex is totally broken

@vilhelmprytz thanks for you PR but it's not how regex works, in fact also the actual regex is totally broken

@mleone87 Can you please clarify? I believe the regex itself is correct, but I don't know about the specific Go implementation.

@vilhelmprytz have you tested this regex?

@mleone87 Yes, I have!


Use C++ header instead of C one insite generated cpp files

On some platform functions are not defined in the global  namespace


Automatic CI to fetch, merge, filter tools and create static pages

Working CI that weekly fetches all tools stepwise and then merges them into all_tools.tsv;
updates the main branch via git pull -s recursive -X ours merge strategy.
Tested on my main branch.
The filter and static CI are triggered automatically when all_tools.tsv is changed in the main branch.

hang on with the review, I need to rebase https://github.com/paulzierep/galaxy_tool_extractor/tree/main first ...

I went the fast way to get this done, so we can finalize the publication, its working with the stats and the instance check now: https://github.com/galaxyproject/galaxy_tool_metadata_extractor/pull/35; @nsoranzo I took your review into account !

I went the fast way to get this done, so we can finalize the publication, its working with the stats and the instance check now: https://github.com/galaxyproject/galaxy_tool_metadata_extractor/pull/35; @nsoranzo I took your review into account !


multisig added (#201)

no objection on merging but was talking with @JBotwina to make PR only when some technical modules are developed

no objection on merging but was talking with @JBotwina to make PR only when some technical modules are developed

which technical module?


Kube bench proposed security fixes

Disable profiling endpoints for control plane components
Enable service account lookup in etcd
Disable kubelets read-only ports
Hardening TLS configuration for Kubernetes >= 1.10
Do not repair malformed updates in apiserver
Fix insecure API server port enabled in >= 1.11

/test puppet-tarmak-acceptance-centos v1.10

/assign @JoshVanL
Can you give that a review please?

/unassign

/lgtm

/approve


[VS Code] vscode.languages.onDidChangeDiagnostics is not a function

#its not share

@Gauavsingheknous Thanks for reporting this issue!  However, we need some more information to help you out.

What OS and OS version are you using?
When did you see this error appear?
Can you send us your logs? You can run the "Live Share: Export Logs" command and either drag-and-drop the zip into a comment here or email them to<EMAIL_ADDRESS>

@Gauavsingheknous Also, what version of VS Code are you in?  This can happen with older versions.  Update to the latest (1.22.2 for stable) and see if that resolves it for you.


Microsite/tips plugin

Hey, I just made a Pull Request!
Add new plugin named tips. You can find some images here https://github.com/dweber019/backstage-plugin-tips/tree/main/plugins/tips
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Un-stale 😉

Nice thanks! :tada:


doc: generate program usage automatically

@gaborbernat btw, at least for my PRs, please use rebase instead of squashing the commits.
8fdbd931aed8cfcec01226f59df5a465e09f2219 has a bunch of random changes that should be in their own commits.
Sorry for being picky! I really care about git history.

IMHO if you think they should have been separate commits they should have been separate pul requests.🤷♂

It doesn't make sense to me to create 4 pull requests for commits that are part of a logic block. When I group commits into one pull request, it's my way of saying that they should be merged at the same time. The commits are logically linked and should be reviewed together, but this doesn't mean they should be the same commit. Does that make sense?

Makes sense, I just think in one pr one feature/bugfix. So at the end one pr is one commit. Makes revert also easy and straight forward to use.

I usually don't use this model, it might not be an issue when you are dealing with simple stuff but I have found that it does not scale well in terms of complexity. I've found myself needing to retrace the steps leading to certain changes in codebases, this is significantly easier if we have small commit logically separated. For me git history is also documentation, I sometimes add some context on the change, why it's needed and/or how it works. All that metadata is lost when you the commits are squashed.
I understand that not everybody does this, and that is fine. In the future just try to remember to change the merge button to rebase in my commits if you can :smiley:.
Also, reverting multiple commits is almost the same.
git revert HEAD~6..HEAD~8

I guess we use git differently. I personally view the in between commits as noise only useful for review time, but not at all once merged.

FWIW I also try and keep my git history pristine. Each commit is a logically independent change, and frequently one that can at least mostly be rolled back independent of the other changes.
The biggest downsides to doing rebase-merge or merge commits vs. squash merges are:

A lot of tools can't be configured as "this must pass on every commit", so it's common to find random commits in a PR that won't pass the test suite or the linters or something (which can make automated git bisect runs a bit annoying).
It's a lot of overhead to ask your random contributors to do interactive rebases to clean up their history, and it makes it a lot harder to just click the "merge" button on a good PR.

One of the biggest downsides of "always squash merge" we've already run into together — when dateutil's test suite stopped working because of a change in tox, we did a git bisect and found that it was some mega-PR with tons of semi-related changes in it. I had to throw it to you to uncover what was going on, where smaller, granular changes even within a single PR would have highlighted the exact issue from the start.
I think it's reasonable to default to using squash merges for contributors who are not obviously curating their commit history, but to do rebase merges for people like @FFY00 and myself.

I had to throw it to you to uncover what was going on, where smaller, granular changes even within a single PR would have highlighted the exact issue from the start.

I consider this a worthwhile trade-off for myself. In that case, I don't think the fix would have been any easier if it would have been separate PR. And I'm 99% sure I would have not made that one change separate PR. That changeset was a major rework of a part of the tool that touched multiple parts, so was made more with one big sweep, not many small changesets; that could have been kept separate.

so it's common to find random commits in a PR that won't pass the test suite or the linters or something

Personally I always try to avoid this. I try to make sure everything works on every commit.

It's a lot of overhead to ask your random contributors to do interactive rebases to clean up their history, and it makes it a lot harder to just click the "merge" button on a good PR.

This is true, and it is my main use of the squash and merge feature. Btw, Github enables the "allow maintainers to push to my branch" checkmark by default, so if you really want to, you can fix it for them :smile:. I don't generally do this, but it has happened in the past.


Allow uploading unpublished scores to bCourses

@jathak @epai - One of you two want to merge - you'll have to hit the force merge button. CircleCI isn't going to run since it was created from a fork.

@Sumukh Sounds good, will do that next time. Thanks!


fix bind to local address (UDP plugin)

Codecov Report

Merging #132 into master will decrease coverage by -0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   60.97%   60.96%   -0.01%
==========================================
  Files         340      340
  Lines       20874    20875       +1
  Branches     2363     2363
==========================================
- Hits        12728    12727       -1
- Misses       7265     7269       +4
+ Partials      881      879       -2

Impacted Files
Coverage Δ

...c/main/java/kg/apc/jmeter/samplers/UDPSampler.java
39.6% <0%> (-5.4%)
:x:

...ava/kg/apc/jmeter/jmxmon/JMXMonConnectionPool.java
83.87% <0%> (+6.45%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c5575...4d5d212. Read the comment docs.


One Way to Bypass  Memory Limit for Join ?

Based on the document  on join and global join, clickhouse seems to cache the right table in memory and then perform join.
I am running clickhouse - <IP_ADDRESS>  in docker with 13 GB memory.  I hit a memory limit for this query
select *
from small_table
JOIN large_table
using nid
INTO OUTFILE 'out.csv' FORMAT CSVWithNames;

But I am able to complete it if I switch the table
select *
from large_table
JOIN small_table
using nid
INTO OUTFILE 'out.csv' FORMAT CSVWithNames;

The result is written into file on the fly. I have no issues if I run either query in sqlite.  Is it possible to internally switch the right/left tables ?

I have no issues if I run either query in sqlite.
sqlite is  OLTP database and able to use NestedLoop (and index access)
CH is OLAP database and always uses HashJoin (and has no index access)
So CH always put the right table into memory.

Is it possible to internally switch the right/left tables
No. CH always put the right table into memory. Almost all queries look like
from HUGETABLE left outer join SMALLTABLE
CH does not have an cost-based-optimizer and does not need one because HUGETABLE is the left by nature.


agate: 2.4.1 -> 2.5.0

Motivation for this change
Bump agate to 2.5.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112922 run on x86_64-linux 1

1 package built:

agate

Result of nixpkgs-review pr 112922 at 5050ed3f run on aarch64-linux 1

1 package built:

agate

1 suggestion:

warning: unused-argument
Unused argument: installShellFiles.
Near pkgs/servers/gemini/agate/default.nix:1:39:
  |
1 | { lib, fetchFromGitHub, rustPlatform, installShellFiles }:
  |                                       ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112922 run on x86_64-darwin 1

1 package failed to build and already failed to build on hydra master:

agate: log https://termbin.com/6oqfp

darwin patch:
diff --git a/pkgs/servers/gemini/agate/default.nix b/pkgs/servers/gemini/agate/default.nix
index 285de8d7e06..be3012740f5 100644
--- a/pkgs/servers/gemini/agate/default.nix
+++ b/pkgs/servers/gemini/agate/default.nix
@@ -1,4 +1,4 @@
-{ lib, fetchFromGitHub, rustPlatform, installShellFiles }:
+{ lib, stdenv, fetchFromGitHub, rustPlatform, installShellFiles, Security }:

 rustPlatform.buildRustPackage rec {
   pname = "agate";
@@ -13,6 +13,8 @@ rustPlatform.buildRustPackage rec {

   cargoSha256 = "sha256-B07itUftDj3yVMDc/2VetwYs74fZBa1tmeELbbQ39P0=";

+  buildInputs = lib.optionals stdenv.isDarwin [ Security ];
+
   meta = with lib; {
     homepage = "https://proxy.vulpes.one/gemini/gem.limpet.net/agate";
     changelog = "https://proxy.vulpes.one/gemini/gem.limpet.net/agate";
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 5011e4e707a..57bc29abe06 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -705,7 +705,9 @@ in

   afpfs-ng = callPackage ../tools/filesystems/afpfs-ng { };

-  agate = callPackage ../servers/gemini/agate { };
+  agate = callPackage ../servers/gemini/agate {
+    inherit (darwin.apple_sdk.frameworks) Security;
+  };

   agda-pkg = callPackage ../development/tools/agda-pkg { };

Result of nixpkgs-review pr 112922 run on x86_64-linux 1

1 package built:

agate


React to EF changes

Fix build after https://github.com/aspnet/EntityFramework/commit/de4f73e9517ba75f69064e45ff30d2755a3981d3
@anpete @natemcmaster

Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:shipit:


[cdc_stream] [cdc_sync] Add integration tests

Port the Stadia Python integration tests to the open source project.
Ideally, run them in an action, but that might be tricky as it requires multiple VMs to talk to each other.

Fixed by #42 and #44.


Decoding error on OPEN_ORDER

I got below errors:
Decoding error on OPEN_ORDER: unprocessed data left on queue (["",null]). Please report to https://github.com/stoqey/ib (505) [-1]

Hello,
Thanks for reporting.
This error shown up when my TWS got auto updated, then disappeared and doesn't show anymore. I guess this was an IB issue.
Could you confirm that we can close this issue?
Thanks

I was getting this too and fixed it with below as orderCancel can be null:
      tokens.push(orderCancel?.extOperator);
      tokens.push(orderCancel?.manualOrderIndicator);

https://github.com/stoqey/ib/blob/bac20cfe79091257644764f8f77f9e508696415d/src/core/io/encoder.ts#L583
https://github.com/stoqey/ib/blob/bac20cfe79091257644764f8f77f9e508696415d/src/core/io/encoder.ts#L584