Align logo to the right in readme

I think this is better for user to see the content, so we don't have to scroll all the way under logo.

Hi @jcs090218! Great to see you contributing around spotDL!
Would you be interested in joining the spotDL development team?
Thanks for this contribution! :)

Hi @jcs090218! Great to see you contributing around spotDL!
Would you be interested in joining the spotDL development team?
Thanks for this contribution! :)

Hi @Silverarmor! I would definitely like to join and contribute to this project! :D
Let me know if you need anything from me! Thanks!

Hi @Silverarmor! I would definitely like to join and contribute to this project! :D
Let me know if you need anything from me! Thanks!

@jcs090218
I have added you to the organisation. You should receive an email from GitHub, or you can accept it at https://github.com/spotDL.
Please also join the spotDL discord @ https://discord.gg/xCa23pwJWY

@jcs090218
I have added you to the organisation. You should receive an email from GitHub, or you can accept it at https://github.com/spotDL.
Please also join the spotDL discord @ https://discord.gg/xCa23pwJWY

@jcs090218 I'm not able to see you on the Discord server. Could you please mention me there?
@Silverarmor#8494

@Silverarmor Mentioned! Let me know if you need anything. I don't know why discord doesn't link with my GitHub account. 😕


about-section

Hey @shalini-tiwari The photo's resolution is so less that it is getting pixelated. We can use a little more resolution image.

@cosmo3769 That image had less resolution, so I changed the image instead.


Bug - Dropdown menu with ampersand (&)

Describe the bug
We are trying to use the SDDS dropdown component. However, one of the options in our dropdown list includes a "&" (ex: Staffan & Solin). When having this option in the selection it changes the "&" to "&"
To Reproduce
Steps to reproduce the behavior and be very detailed
I changed the data from "Stockholm" to "Stockholm & Stockholm" in the codesandbox demo example and the behavior is same there if you try to pick city "Stockholm & Stockholm" in the "City-Dropdown list" but when it is selected the label becomes "Stockholm & Stockholm".
codesandbox link with changed data: https://codesandbox.io/s/boring-feather-lf03n?file=/src/Form/Form.js

Go to https://codesandbox.io/s/boring-feather-lf03n?file=/src/Form/Form.js
Click on City-dropdown list
Select Stockholm & Stockholm
See wrong value as label it will be "Stockholm & Stockholm" instead of Stockholm & Stockholm

Expected behavior
A clear and concise description of what you expected to happen.
I would like to see Stockholm & Stockholm in the dropdown menu.
Version of SDDS or which package
Latest
System information:
Please complete the following information, don't forget version
Chrome latest
AB#957

I am working on this one currently. The update is expected to go out next Wednesday.

This is fixed in our latest release. I am closing this now.


improvement - Show duplicate mounts

Will it be possible for lfs to highlight duplicated mounts?
┌────────────────────────────┬────┬────┬─────┬─────────┬─────┬─────┬──────────────────┐
│         filesystem         │type│disk│used │   use   │free │size │mount point       │
├────────────────────────────┼────┼────┼─────┼─────────┼─────┼─────┼──────────────────┤
│/dev/nvme0n1p2              │xfs │SSD │ 26Gi│26% █▍   │ 74Gi│100Gi│/                 │
│/dev/nvme7n1p1              │xfs │SSD │ 17Gi│66% ███▍ │8.4Gi│ 25Gi│/var/Data         │
│/dev/mapper/vg1-LVvarStriata│ext4│LVM │ 17Gi│66% ███▍ │8.4Gi│ 25Gi│/var/Data         │
│/dev/nvme8n1p1              │xfs │SSD │8.4Gi│56% ██▊  │6.6Gi│ 15Gi│/usr/local/App    │
│/dev/nvme4n1p1              │xfs │SSD │216Mi│ 2% ▏    │ 11Gi│ 11Gi│/var/App-local    │
│/dev/nvme1n1                │xfs │SSD │1.6Gi│32% █▋   │3.4Gi│5.0Gi│/home             │
│/dev/nvme6n1p1              │xfs │SSD │1.0Gi│34% █▊   │2.0Gi│3.0Gi│/var/log          │
│/dev/nvme3n1                │xfs │SSD │372Mi│18% ▉    │1.6Gi│2.0Gi│/tmp              │
└────────────────────────────┴────┴────┴─────┴─────────┴─────┴─────┴──────────────────┘

Somehow the old mount was not removed in the fstab and seems that both were mounted at the same time with the second one taking priority.

I'd accept other opinons but right now I wouldn't do that:
There are valid reasons to have two filesystems hooked to the same mount-point.
More generally  it's very difficult to analyze and detect that a configuration is invalid. And detecting only one (or a few) strange cases isn't really going to help IMO.

I was not thinking to show invalid config. Just to pair same mounts points by colour or bold.


vercel部署失败

20:33:19.884chat:build: Failed to compile.
20:33:10.884chat:build:
20:33:10.885chat:build:src/app/(chat)/pricing/page.tsxchat:build: Typeerror: Page"src/app/(chat)/pricing/page.tsx"does notmatch the required types of a Next.js Page.20:33:10.885chat:build:"prices”is not avalid Page export field.
20:33:1885
20:33:10.885chat:build:
2:33:11.032
chat:build:ELIFECYCLECommand failed with exit code 1chat:build:ERROR: command finished with error: command(/vercel/path/apps/chat) pnpm run build exited (1)command (/vercel/patha/apps/chat) pnpm run build exited(1)
20:33:11.050
20:33:11.050
20:33:11.051
20:33:11.052
20:33:11.053
20:33:11.053
Tasks:
Cached :
Time:
20:33:11.054Summary:
2 successful，3totalcached，3total
1m5.588s/vercel/path0/.turbo/runs/2QeLVh1EJu3r5pX2hblxDRG7tBj.json
20:33:11.054
20:33:11.054ERROR run failed: command exited (1)
20:33:11.075Error: Command"npx turbo run build"exited with 1
20:33:11.428BUILD_UTILS_SPAWN_1: Command"npx turbo run build"exited with 1

same problem

同等待解决

1

在配置文件里加一句这个

 在配置文件里加一句这个

pageExtensions:['page.tsx','page.ts','page.jsx','page.js'],


Add utility to convert from deprecated ingestion related configs to the new IngestionConfig.

Description
Since we are moving towards IngestionConfig for ingestion related configurations, we need a utility to auto-convert the older TableConfigs where some of these ingestion configs are present inside of other configs (eg IndexingConfig).
In the PR, we add a conversion utility to create IngestionConfig for legacy TableConfigs.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7046 (4f85c04) into master (18c0d9d) will decrease coverage by 7.95%.
The diff coverage is 36.66%.

@@             Coverage Diff              @@
##             master    #7046      +/-   ##
============================================
- Coverage     73.38%   65.42%   -7.96%
  Complexity       12       12
============================================
  Files          1454     1454
  Lines         72091    72121      +30
  Branches      10441    10448       +7
============================================
- Hits          52903    47185    -5718
- Misses        15654    21523    +5869
+ Partials       3534     3413     -121

Flag
Coverage Δ

integration
?

unittests
65.42% <36.66%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...i/config/table/ingestion/BatchIngestionConfig.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...ot/spi/config/table/ingestion/IngestionConfig.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...he/pinot/common/utils/config/TableConfigUtils.java
86.04% <50.00%> (-7.42%)
:arrow_down:

...a/org/apache/pinot/minion/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/minion/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pache/pinot/common/utils/grpc/GrpcQueryClient.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...t/core/startree/plan/StarTreeDocIdSetPlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../core/startree/plan/StarTreeTransformPlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 339 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c0d9d...4f85c04. Read the comment docs.

Please add conversion to use FieldConfig instead of individual configurations as well.
Also, we need to mark this for release notes (I assume we will deprecate the older configs  in this PR, and remove support for them at some point later in time).


fix: Haiku 3.5 pricing instead of two sonnet

Pull Request Template
⚠ Before Submitting a PR, Please Review:

Please ensure that you have thoroughly read and understood the Contributing Docs before submitting your Pull Request.

⚠ Documentation Updates Notice:

Kindly note that documentation updates are managed in this repository: librechat.ai

Summary
Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.
Change Type
Please delete any irrelevant options.

[x] Bug fix (non-breaking change which fixes an issue)

Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] My changes do not introduce new warnings
[x] Local unit tests pass with my changes

keeping 3.5 and 3-5 variations due to how different API providers name that series of models, will update this today


Set keystore type to PKCS12

$subject
Relates issue https://github.com/wso2/product-is/issues/21614

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11736426763

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11736426763
Status: success


Rewrite if-else chain as switch

I run gocritic locally and this is its only complaint about azidentity.

/check-enforcer evaluate


Improvements on command descriptions

Small adjustments. Making sure command descriptions have a better wording.

First letter should be uppercase
Correct English plural

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-19925
Please use this issue to track the state of your pull request.


[macos] add reties for dotnet download

Description
improve image generation robustness by adding retry for dotnet download
Related issue:
https://github.com/actions/runner-images-internal/issues/5064
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos11,macos12


[Obsidian] Vault not found (but location is correct)

Extension
https://github.com/raycast/extensions/tree/main/extensions/obsidian
Description
The official Raycast extension for Obsidian fails to find my Vault.
I have tried:

A vault located in the standard iCloud location (/Users/samm/Library/Mobile Documents/iCloud~md~obsidian/Documents/Main)
A vault located in iCloud drive (/Users/samm/Library/Mobile Documents/com~apple~CloudDocs/Obsidian/Main)
Creating a new Vault
Quoting and unquoting the path
Adding/removing \ before the space in the path
Updating all plugins, Raycast, Obsidian

Adding the parent path (containing multiple vaults) - this results in a different error

Steps To Reproduce

Create a new Obsidian vault in the default location (/Users/Username/Library/Mobile Documents/iCloud~md~obsidian/Documents/VaultName
Add the path to the extensions settings
Try to search for a note in the vault

Current Behaviour
No vaults found
Expected Behaviour
Vault(s) found
Logs
Error: Worker terminated due to reaching memory limit: JS heap out of memory

NodeError:errors:406:5
[kOnExit]:worker:313:26
Worker.<computed>.onexit:worker:229:20

@raycastbot it's linked in the issue?

oo maybe similar to https://github.com/raycast/extensions/issues/11445

Thanks for reporting. For debugging purposes, how many notes do you have?
I believe the issue is that the extension loads the entire vault into memory to perform searches, and if you have a lot of notes, or possibly enough large notes, it crashes. Do you happen to know the file size of your largest note?
The bottom line is that I need to find the right time to fix this as I think it's going to be a bit complicated, and take time to try out a few different ideas that might lead to nothing. (Note to readers: if someone else wants to take this on I'm happy to guide, code review, etc - beginners are welcome too).
I'm hoping there's a way to just execute a shell command to grep the contents, but I'll have to read other extensions to see how it's being done there. This might not solve it.
Alternatively, it might require creating a database that syncs the notes content locally. I'd like to avoid this duplication but it could lead to a better search experience than native obsidian.
@pernielsentikaer you mentioned previously raycasts new search. I searched the docs for a new feature but didn't find anything. Do you have any suggestions? How would the team recommend searching an entire large directory and all its contents?

Howdy Kevin,

the extension loads the entire vault into memory

Oh my...
I don't have that big of a vault compared to others I know, but it certainly seems far too big to have loaded into memory just to open/search notes.

Currently at 2385 but will only keep growing.

The bottom line is that I need to find the right time to fix this as I think it's going to be a bit complicated

Totally understood, no expectations, open source hugs etc etc etc
I'll have a look at the Obsidian API, while I'm no web-dev I've been known to hack up some JS/TS now and then. If I do come up with something I'll let you know.

Actually, this looks interesting: https://github.com/coddingtonbear/obsidian-local-rest-api?tab=readme-ov-file

It appears they search through every file one by one.
https://github.com/coddingtonbear/obsidian-local-rest-api/blob/216bffcc4739e9428c71396c1b06e9dcd7d093ea/src/requestHandler.ts#L787
That's one idea I had but it could potentially be slow as well. I didn't realize there was an obsidian sdk actually so maybe the cached file and search builder they have there makes it faster.
Could you try that rest library out and tell me if it's fast on your vault?
Implimenting this would require creating custom search in raycast which is fine and I've done before elsewhere, but I just worry if it will be slowing things down for the 99% too. We could make it opt-in though as well. Better than just crashing!

I just tried it out with some standalone code and it's very fast, less than a second to perform a search across my whole database.
import axios from 'axios';
import https from 'https';

const API_URL = 'https://<IP_ADDRESS>:27124'; // Replace with the appropriate URL and port
const API_KEY = 'REDACTED'; // Replace with your actual API key

// Create an instance of the https agent
const httpsAgent = new https.Agent({
  rejectUnauthorized: false, // Allow self-signed certificates
});

// Configure axios with the base URL, authorization header, and httpsAgent
const api = axios.create({
  baseURL: API_URL,
  headers: {
    'Accept': '*/*',
    'Authorization': `Bearer ${API_KEY}`,
    'Content-Type': '*;/*',
    // 'Content-Type': ' text/markdown',
  },
  httpsAgent: httpsAgent, // Use the httpsAgent to allow self-signed certificates
});

// define an interface for a document
interface Document {
  filename: string;
  content: string;
  score: number;
  matches: unknown[];
}

// Function to discover configured vaults
async function getFileContent(filename: string): Promise<string> {
  try {
    const response = await api.get(`/vault/${filename}`);
    return response.data;
  } catch (error) {
    console.error(`Error getting file content: ${filename}`);
    throw error;
  }
}

async function createOrUpdateFile(filename: string, content: string): Promise<void> {
  try {
    await api.put(`/vault/${filename}`, content, {
      headers: {
        'Content-Type': 'text/markdown',
      },
    });
    console.log(`File "${filename}" created or updated successfully.`);
  } catch (error) {
    console.error(`Error creating or updating file: ${filename} - error: ${error}`);
    throw error;
  }
}

async function searchDocuments(query: string): Promise<Document[]> {
  try {
    const response = await api.post('/search/simple/', null, {
      params: {
        query: query,
      },
    });

    // create a map of the filenames, scores, and matches
    const documents: Document[] = response.data;
    const results = documents.map((document) => ({
      filename: document.filename,
      score: document.score,
      matches: document.matches,
    }) as Document);

    return results;

  } catch (error) {
    console.error(`Error searching documents: ${query} - error: ${error}`);
    throw error;
  }
}

// Example usage
(async () => {
  try {

    // Create or update a file
    await createOrUpdateFile('testfile.md', '# New File\n\nThis is the content of the new file.');

    // Get the content of a file
    const fileContent = await getFileContent('testfile.md');
    console.log('File content:\n\n', fileContent);

    // Search for documents
    const searchResults = await searchDocuments('query');
    console.log('Search results:', searchResults);
  } catch (error) {
    console.error('An error occurred:', error);
  }
})();

  {
    filename: 'Bear/You Are Not Google – Bradfield.md',
    score: -37.5022,
    matches: [ [Object], [Object], [Object] ]
  },
  {
    filename: 'Bear/Scientists rise up against statistical significance.md',
    score: -36.9055,
    matches: [ [Object], [Object] ]
  },
  {
    filename: 'Bear/Five Tips For a Healthier Postgres Database in the New Year.md',
    score: -36.64960000000001,
    matches: [ [Object], [Object], [Object], [Object] ]
  },
  {
    filename: 'Bear/Facebook’s war on free will  Technology  The Guardian.md',
    score: -32.612500000000004,
    matches: [ [Object] ]
  },
  ... 131 more items
]
node api.js  0.09s user 0.01s system 50% cpu 0.196 total

Ok then a Raycast custom search implimentation (which might already be implemented actually) using the official sdk search wrapper, and iterating over every file seems likely to be the best approach.
Thanks for investigating that. I'll take a closer look at it. I'll try for this weekend and will follow up.

If you also wanted to take a look, I'll describe the important files (I didn't initially write this code so I may miss something)
The NoteLoader class loads in all the notes and media items for a vault, and is consumed by the cache mechanism. Thayt's then used by the useNotes hook, which is loading the cache (so all the notes) into memory.
useNotes is used throughout the extension. This alone could probably be optimized though as (I could be wrong here) I believe it's loading a new copy of the vault every time the hook is invoked in a component (which it may not be invoked that often per command lifecycle anyway).
There needs to be a list of notes though that show up before a search takes place so the user can see recent notes, navigate up/down, etc, but we could also have some sort of lazy loading mechanism that fetches notes on demand as you near the end of the list (so 50 notes on start, then when the users scrolls to note 40 we fetch the next set of 50, etc etc)
For searching, there already is a custom search implimentation here, but it searches the cache of notes mentioned above. An interation on this would involve removing this and adding a search mechanism more simlar to what we just talked about.
So in summary,

We could try to confirm whether the valut cache is being loaded into memory multiple times and optimize that, and that might actually be a good enough solution for now. It would also be fairly easy to fix as it would just involve editing the useNotes hook. It might not help if someone has 1 million notes though...

After that, we need to explore

Removing rhe cache mechanism
Impliment lazy loading of notes as the user scrolls down
Impliment a search using the sdk's search helpers and iterating over every file one by one


Unexpected argument '--format' found caused by upgrading Ruff to latest version

Hi team, about 7 hours ago Ruff was updated to the latest version: https://github.com/jpetrucciani/ruff-check/commit/fbcc7f8ec57b44548034d0cf4542b91904f2fc26
However, Ruff removed support for the --format argument breaking the latest version of this action: https://github.com/astral-sh/ruff/pull/7984
We get this error in all our actions that use this check:
+ ruff --version
+ ruff --format github '--ignore=E402' --fix '--line-length=90' text2song-service/
ruff 0.1.0
error: unexpected argument '--format' found

Proposed fix. Either:

lock version of Ruff to previous version
migrate to new flag.

Thanks for making this action!

Thanks for the note! I'll get this fixed up and re-tagged

@main and @0.1.0 both should now be fixed up with the new flag!


SVG support when generating PDF ?

Generation of PDF is broken if the documentation include SVG images.
One workaround is to convert SVG into PDF before processing everything with sphinx, as described there. I successfully implemented that locally. But since readthedocs does not use Makefile, it "skips" the conversion step.
Would it be interesting to support SVG to PDF conversion out of the box for all projects ? That would add step in the build process of reathedocs build server.
Or would another way be preferable ? I suppose we could do something with Virtualenv and setup.py install. But I am not very familiar with that, so I'd rather ask first ...

Here's my lame workaround.
https://github.com/Pylons/pyramid/pull/1500

+1
Thx @stevepiercy for workaround!

i found this answer for SVG + LaTeX: http://tex.stackexchange.com/questions/122871/include-svg-images-with-the-svg-package

Does it work on ReadTheDocs ?

it doesn't, but it may be that i have another unrelated problem: https://readthedocs.org/builds/isuma-media-players/2875649/

i get this:
LaTeX Warning: File `design3g.*' not found on input line 1996.

i think the workaround above implied there was a generated PNG version, which i don't have / want to bother with here...

well, i ended up doing that: i can't make this work SVG in here, even without RFTD, it seems like like a sphinx bug as well - i'd be curious to see what's going on on that side.
because you can't just \includegraphics{file.svg} in LaTeX. It just doesn't support SVGs. And that's what Sphinx/RTD is doing... so you need a different directive there. this discussion has also good insight:
http://stackoverflow.com/questions/6473660/using-sphinx-docs-how-can-i-specify-png-image-formats-for-html-builds-and-pdf-im
i ended up using:
.. only:: latex

  .. image:: design3g.png

.. only:: html

  .. image:: design3g.svg

And in my makefile:
%.png: %.svg
	inkscape -z -D --file=$< --export-png=$@

When i change the SVG, i do make file.png by hand because i suspect RTD will not obey my makefile... as described in the summary above. anyways, inkscape is probably not installed...

Seems like this is a Sphinx issue, not a Read the Docs one. SVG support would be implemented there, not on our side. Their issue tracker is here: https://github.com/sphinx-doc/sphinx

@ericholscher yet one of the things that was identified in this thread is how Sphinx-only builds would work because they would run the Makefile to generate the PNG/PDF files on the fly. RTD skips that, which makes it impossible to not pre-render the PNG files in the git repository, which makes unnecessary overhead.
It would be nice if RTD would at least provide a way to generate those files on the fly...
I opened an issue in Sphinx re. SVG support regardless.

For reference: https://github.com/sphinx-doc/sphinx/issues/1907

Thanks!

On May 29, 2015, at 3:16 AM, Adrien Crivelli<EMAIL_ADDRESS>wrote:
For reference: sphinx-doc/sphinx#1907
—
Reply to this email directly or view it on GitHub.


How many levels of async is appropriate?

Trying to setup a new AspNetCore app here.  The controller can be async, so are error handling middleware and various filters.  Plus IAsyncRequestHandler, micro ORM's FetchAsync and async remote services calls ...
Do I need async all the way to be truly effective?

Async in C# tends to lead to "async all the way down" structures. So, yes, it's not unusual.

@ardalis That's an insanely fast response!  You must be multithreaded async head to toe!!

Email alerts... also, async isn't all about speed so much as letting the proc do other things instead of just waiting. :)

lol you replied to an async question nearly sync.
So what doesn't need to happen necessarily is that all methods be marked as
"async". If you can return a Task instead of awaiting, you should do that
instead because the async/await state machine isn't free.
On Thu, Sep 21, 2017 at 11:11 AM, Steve Smith<EMAIL_ADDRESS>wrote:

Email alerts... also, async isn't all about speed so much as letting the
proc do other things instead of just waiting. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jbogard/MediatR/issues/195#issuecomment-331205790,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGYMitEZ_gU1qVp485JnknpBXM5B0Dbks5skorGgaJpZM4Pfh5d
.

@jbogard since mediator awaits all requests by default now, if I have a handler that is making a query to the database that might be long running, the application will treat that work as async even if it is a normal synchronous operation right?  Is the value of using async / await in the handler when you are going to be awaiting other asynchronous work?

The benefit is not for the client, but for the server so that it doesn't
block that thread while waiting for I/O to complete.
On Thu, Sep 21, 2017 at 5:22 PM, Aaron Roberts<EMAIL_ADDRESS>wrote:

@jbogard https://github.com/jbogard since mediator awaits all requests
by default now, if I have a handler that is making a query to the database
that might be long running, the application will treat that work as async
even if it is a normal synchronous operation right? Is the value of using
async / await in the handler when you are going to be awaiting other
asynchronous work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jbogard/MediatR/issues/195#issuecomment-331298280,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGYMmMcmmRTcFdBj2sfxUqMe7qJYF83ks5skuGzgaJpZM4Pfh5d
.

If you can return a Task instead of awaiting, you should do that
instead because the async/await state machine isn't free.

You mean like this?
public class MyController : BaseController  {
    public Task<List<string>> Get(MyRequest request) {
        _mediator.Send(request);

public class MessageListHandler : IAsyncRequestHandler<MyRequest, List<string>> {
    public Task<List<string>> Handle(MyRequest request)  {
            return _database.FetchAsync<string>("MyQuery");

I read about it, sounds eliding async/await is not as simple as eliding async/await ...
And just found out IMediator is async only now.  What if the controller is synchronous?  Do I just return _mediator.Send(request).Result?  Or is there other preferred option?  Thanks.

Don't make the controller synchronous :) just make it async.

That's what I end up doing.  And for WebApi, clients generated via swagger spec are all async anyway.  Thanks for the help.


Add support for SignedTypedData request

Thank you for reporting this issue we will get back to you shortly

added in #102


TfLite: Internal error: Cannot create interpreter: Didn't find op for builtin opcode 'CONV_2D' version '5'

I was trying to create the digit classifier Android app from codelabs
At runtime, I get this error:
E/AndroidRuntime: FATAL EXCEPTION: pool-2-thread-1
Process: org.tensorflow.lite.codelabs.digitclassifier, PID: 18122
java.lang.IllegalArgumentException: Internal error: Cannot create interpreter: Didn't find op for builtin opcode 'CONV_2D' version '5'
Registration failed.

    at org.tensorflow.lite.NativeInterpreterWrapper.createInterpreter(Native Method)
    at org.tensorflow.lite.NativeInterpreterWrapper.init(NativeInterpreterWrapper.java:72)
    at org.tensorflow.lite.NativeInterpreterWrapper.<init>(NativeInterpreterWrapper.java:63)
    at org.tensorflow.lite.Interpreter.<init>(Interpreter.java:237)
    at org.tensorflow.lite.codelabs.digitclassifier.DigitClassifier.initializeInterpreter(DigitClassifier.kt:66)
    at org.tensorflow.lite.codelabs.digitclassifier.DigitClassifier.access$initializeInterpreter(DigitClassifier.kt:31)
    at org.tensorflow.lite.codelabs.digitclassifier.DigitClassifier$initialize$1.run(DigitClassifier.kt:48)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:923)

I have tried changing the tflite version on build.gradle. Any other ideas on how to resolve this issue?

try to use the same version of Tensorflow in the Android app in build.gradle.

try to use the same version of Tensorflow in the Android app in build.gradle.

Check out the version of Tensorflow which you use while training, Use the same version in android build.gridle(app).
I use tensorflow 2.4.0 (which is latest) in colab while training, so I put (implementation 'org.tensorflow:tensorflow-lite:2.4.0')  in my android build.gridle(app)


Please invite me to the GitHub Community Organization

Name
Emmanuel
Discord Username (if applicable)
#81
Additional Context
No response

Welcome to ChryzHub @EnebeliEmmanuel 🥳


Update FAKE script

FAKE script is outdated and fails on run targets. It seems targets are not updated for .NET Core projects.
Repro steps
> git clone https://github.com/aardvarkplatform/aardvark.docs.git
> cd aardvark.docs
> .\build.cmd Run_HelloWorld

Expected behavior
Window with running HelloWorld application
Actual behavior
---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target               Duration
------               --------
Restore              00:00:02.6882440
Compile              00:00:13.2544624
AddNativeResources   00:00:00.0006768
Default              00:00:00.0001035
Run_HelloWorld       Failure
Total:               00:00:16.0819240
---------------------------------------------------------------------
Status:              Failure
---------------------------------------------------------------------
---------------------------------------------------------------------
  1) System.ComponentModel.Win32Exception (0x80004005): The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Fake.ProcessHelper.start(Process proc) in D:\code\FAKE\src\app\FakeLib\ProcessHelper.fs:line 45
   at Fake.ProcessHelper.asyncShellExec@461-2.Invoke(Unit unitVar) in D:\code\FAKE\src\app\FakeLib\ProcessHelper.fs:line 465
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@841.Invoke(AsyncParams`1 args)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.FSharp.Control.AsyncBuilderImpl.commit[a](AsyncImplResult`1 res)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronouslyInCurrentThread[a](CancellationToken token, FSharpAsync`1 computation)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout)
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
   at FSI_0005.Build.clo@15.Invoke(Unit unitVar0) in D:\Workspace\aardvark.docs\build.fsx:line 16
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in D:\code\FAKE\src\app\FakeLib\TargetHelper.fs:line 626
---------------------------------------------------------------------

Related information

Windows 10
.NET Core 2.2.301

hi. unfortunately aatdvark.docs seems to be a bit in zombie state. have you tried walkthroug and template repositories? aardvark.base has newest build script which we should port over here.

@haraldsteinlechner I'll try. Thanks!

aardvark.base has the newest build script with newest fake. this would be
best :)
Evgeniy Andreev<EMAIL_ADDRESS>schrieb am Mi., 31. Juli 2019,
18:39:

@haraldsteinlechner https://github.com/haraldsteinlechner I'll try.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aardvark-platform/aardvark.docs/issues/19?email_source=notifications&email_token=AAD5KAPWJBCF2TO35KQU77DQCG52TA5CNFSM4IIIOCLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H23RI#issuecomment-516926917,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5KAM3T4CWP6EZRXVFU33QCG52TANCNFSM4IIIOCLA
.

oh. docs might also reference old packages in paket. dependencies. i just
upgraded walkthroug today - this one is on head packages...
i am currently on my mobile but well an upgrade would be awesome
Harald Steinlechner<EMAIL_ADDRESS>schrieb am Mi., 31. Juli
2019, 18:41:

aardvark.base has the newest build script with newest fake. this would be
best :)
Evgeniy Andreev<EMAIL_ADDRESS>schrieb am Mi., 31. Juli 2019,
18:39:

@haraldsteinlechner https://github.com/haraldsteinlechner I'll try.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aardvark-platform/aardvark.docs/issues/19?email_source=notifications&email_token=AAD5KAPWJBCF2TO35KQU77DQCG52TA5CNFSM4IIIOCLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H23RI#issuecomment-516926917,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5KAM3T4CWP6EZRXVFU33QCG52TANCNFSM4IIIOCLA
.


Holistic Performance does not meet

Please make sure that this is a solution issue.
System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in Mediapipe):

My code based on your example [mediapipe/examples/android/src/java/com/google/mediapipe/]

I add  addMultiStreamCallback to check performance as :
processor.getGraph().addMultiStreamCallback(
OUTPUT_LANDMARKS_STREAM,
packets -> {
Packet packet = packets.get(0);
           long currTimeMs = System.currentTimeMillis();
           float fps = 1000 / (currTimeMs - oldTimeMs);

           float avr = getFpsAverage(fps);

           if (packet.isEmpty()) {
               Log.i(TAG, "[0] report rate : " + fps + ", " + avr);
           } else {
               Log.i(TAG, "[1] report rate : " + fps + ", " + avr);
           }

           oldTimeMs = currTimeMs;
       });

OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4):
Linux Ubuntu 22.04

MediaPipe version:
v<IP_ADDRESS>

Bazel version:
bazel 5.2.0

Solution (e.g. FaceMesh, Pose, Holistic):
Holistic

Programming Language and version ( e.g. C++, Python, Java):
android (c++, Java)

Describe the expected behavior:
I expected It worked over 20 fps on device, but It worked under 10 fps when all landmarks(face, body pose, hand) were detected.
it was mentioned your blog : https://ai.googleblog.com/2020/12/mediapipe-holistic-simultaneous-face.html
My chipset is qcs8250 (I think my device is better than S9+)
:56:49.479 7373-7430/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.4
2022-07-29 10:56:49.608 7373-7426/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.4
2022-07-29 10:56:49.751 7373-7429/com.lge.myholistic I/MainActivity: [1] report rate : 6.0, 7.1
2022-07-29 10:56:49.878 7373-7429/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.1
2022-07-29 10:56:50.002 7373-7431/com.lge.myholistic I/MainActivity: [1] report rate : 8.0, 7.2
2022-07-29 10:56:50.137 7373-7430/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.2
2022-07-29 10:56:50.253 7373-7431/com.lge.myholistic I/MainActivity: [1] report rate : 8.0, 7.2
2022-07-29 10:56:50.365 7373-7429/com.lge.myholistic I/MainActivity: [1] report rate : 9.0, 7.5
2022-07-29 10:56:50.488 7373-7426/com.lge.myholistic I/MainActivity: [1] report rate : 8.0, 7.5
2022-07-29 10:56:50.615 7373-7431/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.4
2022-07-29 10:56:50.740 7373-7432/com.lge.myholistic I/MainActivity: [1] report rate : 8.0, 7.5
2022-07-29 10:56:50.865 7373-7432/com.lge.myholistic I/MainActivity: [1] report rate : 7.0, 7.5
2022-07-29 10:56:50.985 7373-7433/com.lge.myholistic I/MainActivity: [1] report rate : 8.0, 7.7
Standalone code you may have used to try to get what you need :
If there is a problem, provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab/repo link /any notebook:
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:

addtionally,
I wrote BUILD file to make aar:
load(
    "//mediapipe/java/com/google/mediapipe:mediapipe_aar.bzl",
    "mediapipe_aar"
)

mediapipe_aar(
    name = "mediapipe_holistic_lge",
    calculators = ["//mediapipe/graphs/holistic_tracking:holistic_tracking_gpu_deps"],
)

Hi @ar0127 ,
Do you have still issue w.r.t this issue?

Hi @sureshdagooglecom
Yes, I have this issue still.
I built aar and I used it with your holistic graph with no modification.
I just followed your guide.
I want to get your opion to improve performance.
thanks

Hi @sureshdagooglecom
I reopened the issue.
I didn't know the the issue closed when i wrote comment.

Hi @ar0127 ,
Could you please share complete w.r.t above issue.


Tweaks

I have some commits that you could find interesting.
Relevant mentions:

One of them is about the recent issue  #77
Another uncomments the test for "Continuation_NewlinePreceding" mentioned in #27

excellent work, great job with the individual commits with the associated tests inside each


Replace MapBasedRow with ArrayBasedRow for groupBy

MapBasedRow is a row backed by a hash map which can incur substantial overheads while adding and getting items. This can become more significant as the result size grows.
Since the column order in the result is decided and fixed when a query is submitted, we can use ArrayBasedRow instead which is backed by an array.

Hi jihoonson,
Are you proposing to replace  /api/src/main/java/org/apache/druid/data/input/MapBasedRow.java with a array backed row class and modify the references?

Hi @PannerselvamVelmyl. Basically yes, it's correct. But I think there're something more we can do. For example, with ArrayBasedRow, the result column order is always fixed, so that we can avoid serializing/deserializing the column names when sending intermediate data from historicals to the broker. This would reduce the intermediate data size.


Update Check Engine Evaluation job to support QA

[ ] Modify existing Check Engine evaluation job to recognize QA data and iterate through a batched plan

Duplicate Ticket


openssl fips not building correctly on MINGW64 Windows

It looks like this has been fixed in openssl master by this commit: https://github.com/openssl/openssl/commit/41bee3e8fb749504f21f78dbf3eca85e5b84820b#diff-2245023265ae4cf87d02c8b6ba991139
What is the appropriate way to get this merged into an openssl-fips release?
Thanks in advance!

Sorry, but it won't happen by the OpenSSL project.

@richsalz I understand - Do you have any guidance on where would be the correct place to post this? I couldn't find any documentation on the openssl website or any other places. (I thought this might be correct place since the openssl-fips branches are located in this repo)

The issue is that you cannot change a single line of code without resubmitting the validation.  We're not going to re-open the existing validation; we currently are only the "owners" of 1747. The other two are owned by a private consultant who has not yet turned them over to the project.
We are interested in doing FIPS work, but our focus is going to be on a new certification rather than maintaining the old ones. And as I said, we don't have the rights to them anyway. Hopefully that will change.


Adding entries to Pod /etc/hosts with HostAliases

Hi,
On this page: https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/
I found a sentence that is hard to understand because of the double negative.
The sentence is in the first paragraph:
"""
Modification not using HostAliases is not suggested because the file is managed by the kubelet and can be overwritten on during Pod creation/restart.
"""
It would be easier to read and understand by replacing the double negative:
"Modification using the HostAliases field in the PodSpec is recommended because changes made in other ways may be overwritten by the kubelet during Pod creation or restart."
o7

Hi @GergelyMolnar Could you please provide the URL of the page in the issue where you are suggesting an improvement?
/triage needs-information

Sure, the page is here: https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/

Good spotting it. it should be corrected.
I would like to work on it if triage accepted.

/language en

/assign

I think the issue is resolved as the PR get merged.
So closing this issue.
/close


API Backup code generation has been moved into a BackupCodeGeneratorInterface service

The default length is now 9 characters (alphanumeric, mixed case) and the default number generated is now 15 instead of 9.
Resolves https://github.com/silverstripe/silverstripe-mfa/issues/71

We can follow up with a test if required.


cmake could not find llvm

For some reason cmake could not find llvm, despite the fact I have it installed on my system:
$ llvm-config --version
7.1.0

Operating system
Gentoo Base System release 2.6
Cmake version
cmake version 3.14.6
Ninja version
1.8.2
Compiler name and version
gcc 8.3.0
Full cmake and/or ninja output
cmake.out.txt
clickhouse master branch, commit 843f8303b019b3cb7d04ec20d4d0387a1e9f601a

Do you really need llvm for your build?
Actual problem is:
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
CYRUS_SASL_SHARED_LIB (ADVANCED)
linked by target "orc" in directory /home/murat.kabilov/ClickHouse/contrib/orc/c++/src

Yeah, problem with SASL is there, but still, it could not find LLVM.

fixed here - https://github.com/yandex/ClickHouse/commit/54a5b801b708701b1ddbda95887465b9f7ae5740#diff-4f3f04aa07e7cdba3c4a995ef7e5c85dR22

We don't depend on system LLVM anymore: https://github.com/ClickHouse/ClickHouse/pull/8258


Implement netCDF intermediate files

If netCDF translation of the source .hex is successful, the resulting .nc files should be a fraction of the source file size. Using this, we can stage the data at different processing steps to make it easier for reruns, troubleshooting, and modifying procedures.
As discussed 20240612:

[ ] Between parsing and assmebly
[ ] Before fitting
[ ] Before analysis

The final products will be the exported data, which would be similar to the "before analysis" stage (though binned and returning fewer derived variables)

Added notes to #63 . This will be happening during refactoring and no longer warrants its own issue.


[Spotify Player] Make song title scroll

Extension
https://www.raycast.com/mattisssa/spotify-player
Description
Make song titles scroll across the menu bar if the title is longer than the set maximum chars to display.
Who will benefit from this feature?
Anyone who wishes to have the name to be fully displayed while conserving menu bar space.
Anything else?
No response

Good idea. We currently don't have an API for this. I'd be hesitant to implement it using something such as setInterval since the menu bar commands are always running.


deploy script for authorize-idp-access-tokens fails

Describe the bug
when i run deploy-authorize-idp-access-tokens.sh, i get errors.  one of them (seemingly the first) is from sed.
Deploying Apigee artifacts...
sed: can't read ./rendered/sharedflowbundle/policies/VK-IdentifyClientApp.xml: No such file or directory

indeed the file is not there.  but, the file VA-IdentifyClientApp.xml does exist.  so it looks like a mismatch.
in addition, after this error (which should be fatal) the script keeps running, and produces further confusing errors.
generally, this script would benefit from better error handling.  for example, i would suggest adding "|| exit" to the sed command.
To Reproduce
run ./deploy-authorize-idp-access-tokens.sh .  examine the output.
Expected behavior
deploy should run with no errors, and exit with status 0.
Additional context
running on a cloudtop VM.  my org is in staging.

Fixed


EntityIndex is not generated on non IComponent component

Hi,
I use asset store version. This class produce component, but no EntityIndex
[CreateAssetMenu, Player]
public class MagicData : ScriptableObject
{
    [PrimaryEntityIndex] public int Index;
    ...
}

while this component generates fine along with player.GetEntityWithMagic method
[Player]
public class MagicComponent : IComponent
{
    [PrimaryEntityIndex] public int Index;
    ...
}

Is this intended behavior? I want to translate my SO settings into components. For now I create MagicData and Magic components side by side to get data with indexers  together
Cheers

Hi,
entity index only works on field of components.
But you can easily create you own custom entity index (example from the unit tests)
or even simpler, add a generic one directly to the contexts in the beginning of your app
        player.AddEntityIndex(new Entitas.PrimaryEntityIndex<PlayerEntity, int>(
            "Magic",
            game.GetGroup(PlayerMatcher.MagicComponent),
            (e, c) => ((MagicComponent)c).Index));

see https://github.com/sschmid/Match-One/blob/master/Assets/Sources/Generated/Contexts.cs#L67-L70


Clean node_modules before npm i

We experience CI build failures when running e2e tests. Some of the packages in node_modules crash the tests. It is safer to clean the node_modules first and then npm i.

I'm not sure about his change. If there is a problem for E2E tests we should clean the node_modules directory as part of e2e setup script.

okay, moved the change to local-setup in this PR https://github.com/keep-network/local-setup/pull/53


2.1.5 Permanent Carbon Forest

Call me a cynic, but I'm not convinced that these will remain 'permanent' beyond about 100 years. Even in a best-case scenario, destructive events like wildfire, landslip and volcanic activity will likely impact many of these areas at least once over the next ~500 years, significantly enough to trigger a reclassification. As such I suggest that carbon forestry would better be captured under 2.1.1/2.1.2 along with an attribute noting carbon as the target commodity (on the same level as logs, woodchip etc). One could retain some sense of optimism by including a second attribute for planned harvest cycle frequency (n years, with 'infinite' allowed for carbon).

I definitely prefer carbon being noted as a commodity, and not having a class 2.1.5 Permanent carbon forest, due to both the nebulous idea of "permanent" and becase it would be better to indicate at the secondary level whether it is exotic or indigenous species. I'm not sure how some downstream software would cope with an infinite value, so perhaps I'd suggest a nominal value like 999.


Update mailbox count on web socket

I've noticed that when the mailbox is empty and it gets an email, the delete all button doesn't remove the disabled attribute because count isn't getting updated.
This should fix it so it'll be updated when new emails come in

Thanks for reporting the bug and trying to provide a fix. Unfortunately this solution would result in the delete button being enabled when one was viewing a search (with no results) too. I have just added a slightly different fix for this in 56d61ae that works when viewing just the main mailbox (ie: the one the websocket updated) as the search view is not dynamically updated via the websocket feed. I really do appreciate your effort though!


Include RVA information with find_frames for the entire stack

I needed this functionality for my profiler, and I thought it could potentially be useful to others. I'm not sure if my address calculation is exactly right, so that may need to be reviewed.

Can you show how your profiler is using this information, maybe with a screenshot?
The addresses you compute here are the start address of the "inline range" which contains the looked-up address. But is this information useful? A single inlined call may be compiled to multiple non-contiguous ranges of instructions, and you'll just get one arbitrary range here. There may be more instructions from the same call earlier on in the outer function.

I'm using the start address of the range to subtract from the address my profiler returns for a sample. Depending on where the instruction pointer is, it can generate different flamegraph stacks, rather than them being all combined on a callstack.

Oh, heh, I meant a screenshot of the output, e.g. of a flamegraph. Not a screenshot of the code :)

it can generate different flamegraph stacks, rather than them being all combined on a callstack.

I'm not sure I understand what you mean by that. Can you give an example?

Closing due to lack of response. Please let me know if this is still needed.


redid broken example

the current example is broken, I redid it with clear comments and working code

Hey this is great! I actually have a few questions.
I am running a local MEV-geth instance with the following configurations
geth --goerli --syncmode light --http --signer=...

and I run Python 3.9.1 and install all the dependencies via poetry install.
With this setup, when I run your updated example.py script, I get the following error.
    tx["gas"] = math.floor(w3.eth.estimate_gas(tx) * 1.2)
AttributeError: 'Eth' object has no attribute 'estimate_gas'

I suspect that this is

either due to --syncmode light
or that I am running against the goerli testnet.

Could you clarify under what setup you ran your script and validated that it is functional?

Hi! Sorry for the delay! Was supposed to look at this today, but Oslo is slowly opening up again. Will validate the PR tomorrow :)
Thank you for the contribution!

@epheph all PRs that are open now should be merge-able, just want to double check the new example before a final go ahead :star:

Hey @N0K0 @GHowlett , thank you for the helpful example... I was going a further step and adding 3 transactions in the bunle as seen below:
bundle = [
    {"signed_transaction": signed_tx_1.rawTransaction},
    {"signed_transaction": signed_tx_2.rawTransaction},
    {"signed_transaction": signed_tx_3.rawTransaction}
]

I am seeing several instances where only 1 of the 3 is being included in the block, is this because of goerli testing?
Also whenever I include opts, my bundle is never mined, is there a problem with how i am sending the opts:
opts = {}

block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
targetTime = int(timestamp+1000)
opts = {'minTimestamp':timestamp ,
        'maxTimestamp':timestamp + 1000,
        'revertingTxHashes':[False,False,False]}

for i in range(1, 5):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
        'maxTimestamp':timestamp+1000,
        'revertingTxHashes':[]}

for i in range(1, 10):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
        'maxTimestamp':timestamp+1000,
        'revertingTxHashes':[]}

for i in range(1, 10):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

the default is to not allow reverting transactions, it's written in the library code. Not sure how some could be getting through 🤔

Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
        'maxTimestamp':timestamp+1000,
        'revertingTxHashes':[]}

for i in range(1, 10):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

the default is to not allow reverting transactions, it's written in the library code. Not sure how some could be getting through 🤔

yeah not sure myself, i did several tests and it seemed to be the case, maybe it's a goerli thing

Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
        'maxTimestamp':timestamp+1000,
        'revertingTxHashes':[]}

for i in range(1, 10):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

the default is to not allow reverting transactions, it's written in the library code. Not sure how some could be getting through 🤔

yeah not sure myself, i did several tests and it seemed to be the case, maybe it's a goerli thing

the exact code in the lib is
"revertingTxHashes": opts["revertingTxHashes"] if opts else []
so even on the testnet it should default to no reverted txs but maybe there's something else going on

Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
        'maxTimestamp':timestamp+1000,
        'revertingTxHashes':[]}

for i in range(1, 10):
    w3.flashbots.send_bundle(bundle,
                             target_block_number=block_number + i,
                             opts=opts)

the default is to not allow reverting transactions, it's written in the library code. Not sure how some could be getting through 🤔

yeah not sure myself, i did several tests and it seemed to be the case, maybe it's a goerli thing

the exact code in the lib is
"revertingTxHashes": opts["revertingTxHashes"] if opts else []
so even on the testnet it should default to no reverted txs but maybe there's something else going on

yeah I believe it could be random from the goerli relayer point, and i though this change fixed it while in fact it didn't and was by pure chance...

Might have been some version difference. Does it still happen?
On Sun, Jun 20, 2021, 12:15 PM kaleb-keny @.***> wrote:

Alright, I believe adding the opts fixes the issue noted up, as some
transactions are assumed to be allowed to drop from the bundle by default,
correct me if I'm wrong 😅 ...
block_number = w3.eth.block_number
timestamp = w3.eth.getBlock(block_number)["timestamp"]
opts = {'minTimestamp':timestamp,
    'maxTimestamp':timestamp+1000,

    'revertingTxHashes':[]}

for i in range(1, 10):
w3.flashbots.send_bundle(bundle,

                         target_block_number=block_number + i,

                         opts=opts)

the default is to not allow reverting transactions, it's written in the
library code. Not sure how some could be getting through 🤔
yeah not sure myself, i did several tests and it seemed to be the case,
maybe it's a goerli thing
the exact code in the lib is
"revertingTxHashes": opts["revertingTxHashes"] if opts else []
so even on the testnet it should default to no reverted txs but maybe
there's something else going on
yeah I believe it could be random from the goerli relayer point, and i
though this change fixed it while in fact it didn't and was by pure
chance...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flashbots/web3-flashbots/pull/24#issuecomment-864530900,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKBSFNY5OVW5XIN7XEQ6ATTTW5UJANCNFSM46APMFGA
.

Might have been some version difference. Does it still happen?
…
On Sun, Jun 20, 2021, 12:15 PM kaleb-keny @.***> wrote: Alright, I believe adding the opts fixes the issue noted up, as some transactions are assumed to be allowed to drop from the bundle by default, correct me if I'm wrong 😅 ... block_number = w3.eth.block_number timestamp = w3.eth.getBlock(block_number)["timestamp"] opts = {'minTimestamp':timestamp, 'maxTimestamp':timestamp+1000, 'revertingTxHashes':[]} for i in range(1, 10): w3.flashbots.send_bundle(bundle, target_block_number=block_number + i, opts=opts) the default is to not allow reverting transactions, it's written in the library code. Not sure how some could be getting through 🤔 yeah not sure myself, i did several tests and it seemed to be the case, maybe it's a goerli thing the exact code in the lib is "revertingTxHashes": opts["revertingTxHashes"] if opts else [] so even on the testnet it should default to no reverted txs but maybe there's something else going on yeah I believe it could be random from the goerli relayer point, and i though this change fixed it while in fact it didn't and was by pure chance... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKBSFNY5OVW5XIN7XEQ6ATTTW5UJANCNFSM46APMFGA .

yeah it just happened again, ran 2 tests, one went with full bundle the other a single transaction
https://goerli.etherscan.io/txs?block=5001397&p=2
https://goerli.etherscan.io/txs?block=5001410

I could use some validation that my comments here are accurate. @N0K0

You are correct that be default revering TXes should not be allowed past the relay.
Ref https://docs.flashbots.net/flashbots-core/miners/mev-geth-spec/v02

@epheph @obadiaa, any toughts/logs from the relay that might help?

any chance someone could add another example that uses the .buildTransaction() on an actual contract instead of raw eth transfer params?

bump

bump

bump

bump

overhauled the example a while back, seems like this can be closed.
Feel free to re-open if you have changes you would like to see in the new example.


Backup Client Restores .result() is always Null, not able to retrieve JobID

Package Names and versions:
-- azure-common==1.1.28
-- azure-core==1.31.0
-- azure-identity==1.18.0
-- azure-mgmt-recoveryservices==3.0.0
-- azure-mgmt-core==1.4.0
-- azure-mgmt-recoveryservicesbackup==9.1.0
Operating System: MacOS Sonoma Version 14.6.1 (23G93):
Python: 3.11.9:

Describe the bug
There are multiple things that are wrong regarding the backup_client.restores.begin_trigger.

For the IaasVMRestoreRequest, there is recover_point_id, but actually it is .name and not .id - missconception
When restore is triggered, there is no way how to get any particular information about the restore (for example JobID). I need to get information what was restored (disk objects), so atleast the JobID is needed. The only working method is .status() but for other atributes in the response body methods are totally missing. I would assume that .result() will help me with that, but that is also problem since it always returns Null
When the restore ends up in Succesfull state, the response does not even contain body anymore, since the token used in the request URL is already dead. Which means that response is with code 204.

To Reproduce
def az_restore_data_disks(backup_client: RecoveryServicesBackupClient, restore_point: object, rsv: object, container_uri: str, protected_item_uri: str, storage_account_id: str, restored_vm_rg_id: str, restored_vm_name: str, bckp_item_source_resource_id: str):
    """
    Restore the data disks of the VM - separate process, will be mounted to the VM later
    :param backup_client: The Recovery Services Backup client object.
    :param restore_point: The restore point object used for restoring disks as source - retrieved from az_retrieve_latest_recovery_point.
    :param rsv: The Recovery Services Vault object - retrieve from az_retrieve_recovery_services_point.
    :param container_uri: The container name of the backup item (Prefix as: learn.microsoft.com/en-us/rest/api/backup/recovery-points/list).
    :param protected_item_uri: The protected item URI of the backup item.
    :param storage_account_id: The ID of the storage account, where the restore should be performed.
    :param restored_vm_rg_id: The ID of the resource group - VM from which the restore is located.
    :param restored_vm_name: The name of the restored VM - questdb.
    :param bckp_item_source_resource_id: The source backup item Resource ID.
    Manual reference to this task: https://learn.microsoft.com/en-us/azure/backup/backup-azure-arm-restore-vms#restore-disks
    NOTE: Yes really - the restore point is called ID in the API, but it is actually the NAME of the restore point.
    """
    myprint(f"Restoring data disks for VM {restored_vm_name} within resource group {restored_vm_rg_id}")    # Define the restore request
    myprint("All variables to check:")
    myprint(f"  Vault name: {rsv.name}")
    myprint(f"  Storage account ID: {storage_account_id}")
    myprint(f"  Source resource ID: {bckp_item_source_resource_id}")
    myprint(f"  Location/region: {rsv.location}")
    myprint(f"  Resource group name: {rsv.rg_name}")
    myprint(f"  Container name: {container_uri}")
    myprint(f"  Protected item name: {protected_item_uri}")
    myprint(f"  Recovery point NAME (Although called ID in params): {restore_point.name}")
    myprint(f"  Target VM resource group ID: {restored_vm_rg_id}")

    # Create the restore request
    restore_request = IaasVMRestoreRequest(
        create_new_cloud_service=False,
        encryption_details={
            "encryption_enabled": False,
        },
        original_storage_account_option=False,
        recovery_point_id=restore_point.name,
        recovery_type='RestoreDisks',
        region=rsv.location,
        source_resource_id=bckp_item_source_resource_id,
        storage_account_id=storage_account_id,
        target_resource_group_id=restored_vm_rg_id,
    )
    # Wrapping it into restore request resource object
    restore_request_resource = RestoreRequestResource(properties=restore_request)

    # Trigger the restore request
    restore_operation = backup_client.restores.begin_trigger(
        vault_name=rsv.name,
        resource_group_name=rsv.rg_name,
        fabric_name="Azure",
        container_name=container_uri,
        protected_item_name=protected_item_uri,
        recovery_point_id=restore_point.name,
        parameters=restore_request_resource
    )

    # Wait for the restore operation to finisht
    myprint(f"Restore operation initiated. Polling for completion...")

    # Polling mechanism to wait for the job to complete
    timeout = 3600  # Timeout in seconds (1 hour)
    interval = 30  # Polling interval in seconds
    elapsed_time = 0

    while elapsed_time < timeout:
        if restore_operation.done():
            break
        status = restore_operation.status()
        myprint(f"Current restore job status: {status}")

        time.sleep(interval)
        elapsed_time += interval

    if elapsed_time >= timeout:
        myprint("Timeout reached while waiting for the restore job to complete.")
    else:
        myprint(f"Restore operation completed with status: {status}")
        if status == "Failed":
            myprint("Restore operation failed!")
            sys.exit(1)
        elif status == "Cancelled":
            myprint("Restore operation was cancelled!")
            sys.exit(1)

Expected behavior

Should be clear - missnamed
I don't think it should respond with Null always to the .result(). It should give us back the response as an object for example (for the response see below). I need to get the disks, that were recovered, so I can further work with them (mount them etc.).

Screenshots
From this response, I can get only status with the .status(). So once the restores.begin_trigger is finished I can only tell it is finished, but I cannot work further with the retrieved disks. Properties, name etc. is not reachable.

If there is anything I missunderstood I would appreciate any help. Thank you and have a great day!

Thanks for the feedback, we’ll investigate asap.

@ChenxiJiang333 Please help on this issue.

got it

Hi, @MartinZvelebil, please know that python SDK is auto generated by swagger definitions.
For issue 1, the property name recover_point_id was generated from here that SDK owner cannot make any change on it.
For issue 2, by these definitions: trigger the long time operation restore, get the result of a long time operation, I guess it's somehow expected to have response with code 204 when trying to get the result of restore operation and it's all decided by the service behavior.
Both of the issues would need support from service team, please open an issue at https://github.com/Azure/azure-rest-api-specs/issues to report them. To make the log file of an API calling, you can follow https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/debug_guide.md.

Please report the issue in the https://github.com/Azure/azure-rest-api-specs repo


Extension is not appearing on marketplace

I was searching from OSSCode Extensions Panel and with ext install keifererikson.nightfox. But I hadn't success, :(. I love this theme.

Are you still unable to install this extension @Atreyu-94?

I installed it from vsix extension file :). But it doesn't appear on marketplace yet.

I'm not very familiar with OSSCode but it should handle extensions the same way I assume.

The extension appears when searched on the standard VSCode. I'm unsure how I can get OSSCode to handle it correctly.


clean up

after withdrawing tokens, if the pool got 0
remove the id from the user list. https://github.com/The-Poolz/Locked-pools/blob/2b7172c32054866ba26cf7c8e3b480abcbbc3666/contracts/LockedPoolz.sol#L32

close on #22


concatenating strings doesnot work

Challenge Concatenating Strings with Plus Operator has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

// Example
var ourStr = "I come first. " + "I come second.";

// Only change code below this line

var myStr = "This is the start." + "This is the end.";

@heenabegum167 Thank you for reporting this issue. Take a look at the strings once more. You're almost there.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!


xmlns snippet invalid for attribute suggestion

Description:
The xmlns snippet suggested for attributes is invalid.
Adds the following
xml x = xml `<foo xmlns "" as ns;>hello world</foo>`;

whereas ideally only the xmlns keyword is required to do something like
xml x = xml `<foo xmlns:ns="http://abc.def">hello world</foo>`;

Steps to reproduce:
public function main() {
    xml x = xml `<foo xmln>hello world</foo>`; // accept xmlns here
}

Affected Versions:
1.0.0

This is a false positive we are having at the moment. Currently we do not have a way to identify that the cursor is within the xml. Will update the progress with the latest source pruner revamp


2.10.0 element-ui-common.js Cannot read property 'disabled' of null at VueComponent.hide

2.10.0 element-ui-common.js Cannot read property 'disabled' of null at VueComponent.hide
Chrome console error
element-ui.common.js:2330 Uncaught TypeError: Cannot read property 'disabled' of null
at VueComponent.hide (element-ui.common.js:2330)
at Object.documentHandler (clickoutside.js:39)
at clickoutside.js:25
at Array.forEach ()
at HTMLDocument. (clickoutside.js:24)
Firefox console error
TypeError: this.triggerElm is null[Saber más] element-ui.common.js:2330
hide
element-ui.common.js:2330
hide self-hosted:981:17 createDocumentHandler/<
clickoutside.js:39
./node_modules/element-ui/lib/utils/clickoutside.js/</<
clickoutside.js:25
forEach self-hosted:268:13 ./node_modules/element-ui/lib/utils/clickoutside.js/<
clickoutside.js:24

+1. We were missing a dropdown slot on one of our el-dropdown which was resulting in any el-select or dropdown not working on our app.
Adding the following fixed it
<el-dropdown-menu slot="dropdown" />

hello，is there anyone having solved it？

+1.I have add the follow but no work:
<el-dropdown-menu slot="dropdown" />

Did you find a soluton @dolphinfine ?

@androidfanatic I did it, it solved the "disabled" error, but I can't find any el-option in my el-select since there is this error..

@maximesahagian  did you find any solution?

@jeffysam6 yes, it came from Jquery conflict, I had to remove Jquery from my VueJS app

in my case, the same error was trigger from el-dropdown if there was no el-dropdown-menu inside
if someone still fighting with this, el-dropdown should be next places to check

hello i am facing this issue too, but I didn't have jQuery in my project. Error in every pages

Having the same issue.
Running 2.15.2, no jQuery.  slot="dropdown" does not solve it.

We were conditionally showing a dropdown menu with:
<el-dropdown-menu slot="dropdown" v-if="...">

This was causing the element to not be found because it wasn't there. Using v-show instead solved this for us:
<el-dropdown-menu slot="dropdown" v-show="...">

Have a try everyone!
import App from './App';
import ElementUI from 'element-ui';
import 'element-ui/lib/theme-chalk/index.css';

ElementUI.Dropdown.methods.hide = function hide() {
  var _this2 = this;

  if (!this.triggerElm || this.triggerElm.disabled) return;
  this.removeTabindex();
  if (this.tabindex >= 0) {
    this.resetTabindex(this.triggerElm);
  }
  clearTimeout(this.timeout);
  this.timeout = setTimeout(function () {
    _this2.visible = false;
  }, this.trigger === 'click' ? 0 : this.hideTimeout);
}

new Vue({
  components: { App },
  template: '<App/>',
}).$mount('#app');

+1. We were missing a dropdown slot on one of our el-dropdown which was resulting in any el-select or dropdown not working on our app.
Adding the following fixed it
<el-dropdown-menu slot="dropdown" />

the same issue for me ~ thanks

Ok the issue in my code was that I had an <el-dropdown> with no child <el-dropdown-items>. Trivial repro: put this in your components:
  <el-dropdown />

Works for me, thanks!

感谢您的来件，邮件已收到。


[509] Change load to loadUnaligned

Cherry-pick https://github.com/apple/swift-syntax/pull/2312 to package-release/509.

Same fix as https://github.com/apple/swift-package-manager/pull/6929 since the code in swift-syntax is based on what is
in SwiftPM.

✅ Local testing succeeded.


Chrome and Firefox are not able to load certain web pages

Use the following test example to reproduce the issue:
import { Selector } from 'testcafe';

fixture `Chrome tests`
    .page `https://www.apple.com`;

test('Basic test', async t => {
    await t
        .click(Selector('#ac-globalnav a').withText('Mac'))
        .click(Selector('#ac-globalnav a').withText('iPad'))
        .click(Selector('#ac-globalnav a').withText('TV')); //this step hangs in Chrome and Firefox
});

Refer to the private ticket for additional info
Your Environment details:

testcafe version:                  1.14.0
node.js version:                    v12.18.0
command-line arguments:  testcafe chrome test.js
browser name and version: Chrome 90
platform and version:           macOS 10.15

Try to check if it works with version 1.10.0

I cannot load this page under TestCafe 1.10.1: https://www.apple.com.

The issue relates to incorrect processing of the Desctructuring assignment in some cases.
I created a separate issue in the testcafe-hammerhead repository: https://github.com/DevExpress/testcafe-hammerhead/issues/2627
As for this issue, I found that the cause is in the hls.js script file:
for (let [e, t] of this.sbContexts) { // we have `e` declaration here
    let e = t.sourceBuffer;           // and another declaration here
    if (e) {                          // but these are different variables
        if (!e.ended) return;
        if (e.updating) return void (this._needsEos = !0);
    }
}

We can work around the issue if we rename the e variable inside the loop as follows:
for (let [e1, t] of this.sbContexts) { // we have `e1` declaration here
    let e = t.sourceBuffer;            // and `e` declaration here
    if (e) {
        if (!e.ended) return;
        if (e.updating) return void (this._needsEos = !0);
    }
}

I was able to work around this issue by using Request Mocks and modifying the source code of hls.js. Please note that this is a temporary workaround specific to this site. If anything changes in the hls.js file, the workaround may stop working.
Here is the code:
import { Selector, RequestMock } from 'testcafe';

const fetch = require('node-fetch');

fixture `Chrome tests`
    .page `https://www.apple.com`;

let hljs = null;

const mock = RequestMock()
    .onRequestTo(async request => {
        if (request.url.includes('hls.js')) {
            const res = await fetch(request.url);

            hljs = await res.text();

            hljs = hljs.replace('let[e,t]of this.sbContexts', 'let[e1,t]of this.sbContexts');

            return true;
        }

        return false;
    })
    .respond((req, res) => {
        res.statusCode = '200';
        res.headers['content-type'] = 'text/javascript';

        res.setBody(hljs);
    });

test.requestHooks(mock)('Basic test', async t => {
    await t
        .click(Selector('#ac-globalnav a').withText('Mac'))
        .click(Selector('#ac-globalnav a').withText('iPad'))
        .click(Selector('#ac-globalnav a').withText('TV')); //this step hangs in Chrome and Firefox
});

I modified the initial hls.js file using the Request Mocks mechanism. I renamed the e variable in a specific code line to prevent the error from being processed inside testcafe-hammerhead.
I'll close this issue. Please refer to https://github.com/DevExpress/testcafe-hammerhead/issues/2627


Allow selection of bom_copy and parameter_copy when making a new variant

Thanks, I hesitated adding this as new Variants were copying everything by default, I did not want to alter the behavior.


fixed a typo

@jurajsucik : Thanks for your contribution! The author, @wmgries, has been notified to review your proposed change.

Hi @jurajsucik,
Thank you for finding this typo - we really appreciate the contribution.
#sign-off
Thanks,
Will


HAASIO 2024.04 AppDaemon fails to start after initial installation

Problem/Motivation
AppDaemon app fails to start after initial installation
Expected behavior
To actually start
Actual behavior
Error associated with secrets.yaml file not found. Not Appdaemon folder or yaml files are created to modify.
Steps to reproduce
See log info:
s6-rc: info: service legacy-services: starting
[10:54:34] INFO: Starting AppDaemon...
s6-rc: info: service legacy-services successfully started
Traceback (most recent call last):
File "/usr/bin/appdaemon", line 8, in
ERROR Error loading secrets file: /config/secrets.yaml
sys.exit(main())
^^^^^^
File "/usr/lib/python3.11/site-packages/appdaemon/main.py", line 417, in main
admain.main()
File "/usr/lib/python3.11/site-packages/appdaemon/main.py", line 276, in main
if "appdaemon" not in config:
^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

I have the same issue, my config/appdaemon folder appears empty as well o_O

Make sure you have a secrets.yaml in your add-on config directory. It's not the same as the home assistant config directory.

I hit the update button by accident this morning instead of start. I tried resetting to default settings using the addon UI. Now it seems my scripts and dashboard are gone in my hassio vscode instance. Will have to investigate tonight.

Regarding the issue I reported. So I hit the update button by accident, and no questions asked it upgraded me past https://github.com/hassio-addons/addon-appdaemon/releases/tag/v0.15.2 - which moves the configuration to a container specific share. My configuration was moved there. After changing the secrets path it worked again like before. I suspect people who have auto update on will have breakage because of things like that. Perhaps if the addon can move config, it can do a simple find and replace in the configfile too next time?


Import bundle gem generated scaffolding

Import the scaffolding that would have been created if we initialized the project with bundle gem, instead of starting from scratch. This adds project support for testing and release management, including publishing to a gem server, with the help of rake.
Restructure the palletjack-tools files to match bundler requirements and conventions.

Dependency versions should be downgraded in tools/palletjack-tools.gemspec as well.


[GHC 7.10.1-RC2] shake and vector-algorithms test suites hang

Whenever nix runs ./Setup test for vector-algorithms or shake with GHC 7.10.1-RC2 the tests run forever, I left them running for 6 hours(!) on an i7 3770K. The tests don't give me any failing messages, they just run until I hit ctrl+c
GHC 7.8.4 does not have this issue
vector-algorithms
http://lpaste.net/120194
shake
http://lpaste.net/120195
strace on shake build
http://lpaste.net/120197
I originally asked for help on #ghc but pacak could not reproduce these issues, and he told me to try running shake-test directly instead of running ./Setup test (which runs runhaskell). When I overrode checkPhase to run the local binary directly the test fails immediately because it can't find a file that hasn't been created yet. (Probably created by installPhase?)
Direct run of ./dist/build/shake-test/shake-test
http://lpaste.net/120199
Direct run of the test from vector-algorithms:
http://lpaste.net/120398
Note that disabling the test suite for these 2 packages works fine, and projects that depend on them work as intended

I observe the same problem, but I have no idea what's causing it.

@peti Compiling Setup.hs with -threaded should fix the issue. The problem is that the Cabal library uses the FFI to wait for the test process to finish, and uses a thread to consume the output of the test process (it's passed to a pipe). Without -threaded, the FFI call will block the whole program and the pipe consumers never run, therefore filling up the pipe.

See haskell/cabal#2398

Ah, very nice catch. Thanks for the pointer.

Thanks for the help, @bennofs !

BTW, I have submitted a work-around for this at haskell/cabal#2913 that does not require a threaded Setup.


Tick count change the graph rendering

I've a bar chart with a lot of x tick, correctly rendering.
When specifying a tick count, the graph is not correctly rendered anymore.
http://jsfiddle.net/fo044xqo/1/ (play with count or remove it to see original chart)
Is there a way to hide ticks without changing the chart rendering ?

Curious. I think I've recently run into that myself, actually. Marking as bug.


Wrong Bazel version check when building from source

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 14.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.5
Python version: Python 2.7.6
Bazel version (if compiling from source): 0.10.1
GCC/Compiler version (if compiling from source): 4.8.5
CUDA/cuDNN version: 8.0 / 7.0
GPU model and memory: GeForce GTX 970, 4GB VRAM
Exact command to reproduce: bazel build --config=opt --config=cuda //tensorflow/tools/pip_package:build_pip_package

Describe the problem
I am trying to build TensorFLow 1.5 with Bazel 0.10.1 from the Google apt repo (http://storage.googleapis.com/bazel-apt).
The build immediately fails with a misleading error message:
Current Bazel version is 0.10.1, expected at least 0.5.4
because the build script is comparing strings instead of integers of the version numbers.
Backtrace:
$ bazel build --config=opt --config=cuda //tensorflow/tools/pip_package:build_pip_package
ERROR: /home/christian/Development/tensorflow/WORKSPACE:15:1: Traceback (most recent call last):
	File "/home/christian/Development/tensorflow/WORKSPACE", line 15
		closure_repositories()
	File "/home/christian/.cache/bazel/_bazel_christian/d6e111ab803bbbeb04cac5fc3b321976/external/io_bazel_rules_closure/closure/repositories.bzl", line 69, in closure_repositories
		_check_bazel_version("Closure Rules", "0.4.5")
	File "/home/christian/.cache/bazel/_bazel_christian/d6e111ab803bbbeb04cac5fc3b321976/external/io_bazel_rules_closure/closure/repositories.bzl", line 172, in _check_bazel_version
		fail(("%s requires Bazel >=%s but was...)))
Closure Rules requires Bazel >=0.4.5 but was 0.10.1
ERROR: Error evaluating WORKSPACE file
ERROR: /home/christian/Development/tensorflow/WORKSPACE:41:1: Traceback (most recent call last):
	File "/home/christian/Development/tensorflow/WORKSPACE", line 41
		tf_workspace()
	File "/home/christian/Development/tensorflow/tensorflow/workspace.bzl", line 48, in tf_workspace
		check_version("0.5.4")
	File "/home/christian/Development/tensorflow/tensorflow/workspace.bzl", line 38, in check_version
		fail("\nCurrent Bazel version is {}, ...))

Current Bazel version is 0.10.1, expected at least 0.5.4
ERROR: Error evaluating WORKSPACE file

Yes, version check uses alphabetical order wrongly before 1.6, and I believe the bug has been fixed in the master branch.

Had the same problem, this fixed it. Thanks!

Can this fix be backported to 1.5 so that people can build a stable version from source?

@christian-rauch I rechecked the r1.5 branch, and found that 6fcfab77 patch, fortunately, has been merged since 13 days ago, see:
https://github.com/tensorflow/tensorflow/blob/5b10b3474bea72e29875264bb34be476e187039c/tensorflow/workspace.bzl#L45
So, could you pull the latest codes on r1.5 branch, and take a test again? Thank you.

The r1.5 branch works. I previously checked out the v1.5.0 tag, in the assumptions that both point to the same commit.

Good news! Could you close the issue since it has been fixed ?

Yes. But maybe the current r1.5 branch could be tagged, such that the next person that tries to build v1.5.0 doesn't need to dig into the same issue.


feature request: Support for 3206MSO

Please could you consider support for the Pico 3206 MSO?
Thank you.

See https://github.com/glscopeclient/scopehal-pico-bridge/issues/17

Picoscope3000 series+MSO are supported now (https://github.com/glscopeclient/scopehal-pico-bridge/pull/19 & https://github.com/glscopeclient/scopehal/pull/481 are merged now)
Please provide a feedback and close that issue

Would love to test this but it doesn’t appear to be included in the MSYS package and there are no instructions for building it.

You can use those steps with msys2/mingw64
All following steps are to be done in a MinGW64 shell (notin a MSYS shell, which also getsinstalled by the MSYS2 installer)
pacman -S mingw-w64-x86_64-gcc mingw-w64-x86_64-cmake mingw-w64-x86_64-make
pacman -S mingw-w64-x86_64-glm mingw-w64-x86_64-libsigc++ mingw-w64-x86_64-gtkmm3 mingw-w64-x86_64-yaml-cpp mingw-w64-x86_64-glew
pacman -S mingw-w64-x86_64-opencl-icd
##################################
For Release Windows
##################################
cd ~
git clone https://github.com/azonenberg/scopehal-apps.git --recurse -submodules
cd ~
cd scopehal-pico-bridge
mkdir build
cd build
cmake -G"MinGW Makefiles" -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release ..
mingw32-make -j8
cd ~
mkdir scopehal-pico-bridge_build_release
cd ./scopehal-pico-bridge/build
cp C:/msys64/mingw64/bin/libstdc++-6.dll ~/scopehal-pico-bridge_build_release/
cp C:/msys64/mingw64/bin/libgcc_s_seh-1.dll ~/scopehal-pico-bridge_build_release/
cp C:/msys64/mingw64/bin/libwinpthread-1.dll ~/scopehal-pico-bridge_build_release/
cp ./src/ps6000d/ps6000d.exe ~/scopehal-pico-bridge_build_release/
cp ./lib/log/liblog.dll ~/scopehal-pico-bridge_build_release/


microbundle bundles of the "debug" package with "--target node" results on ReferenceError: navigator is not defined

microbundle bundles of the "debug" package with "--target node" results on ReferenceError: navigator is not defined
https://github.com/icaro-capobianco/debug-microbundle-repro
Workaround is to have debug included as external either through the --external flag or by avoiding unknown dependencies altogether.
https://github.com/developit/microbundle/issues/880

There's nothing really to do here, debug is used by millions of projects without issues surrounding this at the moment. I've never seen this bundler before so I assume they're probably doing something wrong.
Please let me know if that's not the case.


Add aliased links to hydra built PDF's to the readme

Hydra builds our documents, so we should:

[ ] Make sure all latex files that are compiled should be compiled by hydra.
[ ] Make sure that the aliased links to the latest built artifacts are mentioned in the README.


[Minor] Short circuit ApplyFunctionRewrites if there are no function rewrites

Which issue does this PR close?
Relates to #9373 and #9375.
Rationale for this change
I'm dealing with a situation where we have deeply nested plans, which we want to execute and stream the data into storage (Parquet/Delta), and we're hitting the stack overflow problem observed in the aforementioned issues.
Since this is on a write path we don't really need the analyzer/optimizer rules (I think), which are a part of the problem due to tree node recursion that takes place there. This is not an issue, since those can easily be opted out of via with_analyzer_rules/with_optimizer_rules.
However, the tightest bottleneck as per lldb is actually ApplyFunctionRewrites, which can't be opted out of, even though after https://github.com/apache/datafusion/pull/11155 it has no rewrite rules by default.
What changes are included in this PR?
Make ApplyFunctionRewrites simply bail out of the plan transformation/rewrite if it has no rules to apply (the default case presently).
Are these changes tested?
I wanted to add a test that checks for reference equity of the in/out plans but then recalled AnalyzerRule::analyze takes ownership of it.
So the only test is that I see a higher stack overflow threshold with this change.
Are there any user-facing changes?
None.

https://github.com/apache/datafusion/blob/f044bc8371d5b4e1e51a9026f3eccac16a6d4648/datafusion/optimizer/src/analyzer/mod.rs#L139-L141
Is it better to opt it out here?

https://github.com/apache/datafusion/blob/f044bc8371d5b4e1e51a9026f3eccac16a6d4648/datafusion/optimizer/src/analyzer/mod.rs#L139-L141
Is it better to opt it out here?

Makes sense to me, pushed the update.

Thanks @gruuya

However, the tightest bottleneck as per lldb is actually ApplyFunctionRewrites, which can't be opted out of, even though after https://github.com/apache/datafusion/pull/11155 it has no rewrite rules by default.

Maybe we should simply remove them 🤔