Button redlines

The first phase of listing out button's color values. Does this meet your expectations?

The first phase of listing out button's color values. Does this meet your expectations?

Are these values to be hardcoded into the templates, or are they just the literal values for things like "SystemForegroundColor".
If so, I think it would be helpful if that value name could be included in the redlines - so consistency can be maintained with other control templates with the same border colours, or fill/foreground/background colours.

The first phase of listing out button's color values. Does this meet your expectations?

Are these values to be hardcoded into the templates, or are they just the literal values for things like "SystemForegroundColor".
If so, I think it would be helpful if that value name could be included in the redlines - so consistency can be maintained with other control templates with the same border colours, or fill/foreground/background colours.

We definitely won't be hardcoding colors into the control templates because Button must continue to support Light, Dark, and High Contrast themes. I debated what best to list and would love @Chigy's input on this question. What makes this a little complicated are the levels of obfuscation between a color value and what actually gets referenced in the control template.
For example, the Button control template uses the ButtonBackground theme resource, which is defined as <StaticResource x:Key="ButtonBackground" ResourceKey="SystemControlBackgroundBaseLowBrush" />. In tern, SystemControlBackgroundBaseLowBrush is defined as <SolidColorBrush x:Key="SystemControlBackgroundBaseLowBrush" Color="{StaticResource SystemBaseLowColor}" />, and finally SystemBaseLowColor bottoms out with actual hex values like <Color x:Key="SystemBaseLowColor">#33FFFFFF</Color> or <Color x:Key="SystemBaseLowColor">#33000000</Color> depending on theme.
So I'm wondering how useful it will be to call out SystemBaseLowColor, etc in this table because it doesn't tell the whole story.

We definitely won't be hardcoding colors into the control templates because Button must continue to support Light, Dark, and High Contrast themes. I debated what best to list and would love @chigy's input on this question. What makes this a little complicated are the levels of obfuscation between a color value and what actually gets referenced in the control template.
For example, the Button control template uses the ButtonBackground theme resource, which is defined as <StaticResource x:Key="ButtonBackground" ResourceKey="SystemControlBackgroundBaseLowBrush" />. In tern, SystemControlBackgroundBaseLowBrush is defined as <SolidColorBrush x:Key="SystemControlBackgroundBaseLowBrush" Color="{StaticResource SystemBaseLowColor}" />, and finally SystemBaseLowColor bottoms out with actual hex values like <Color x:Key="SystemBaseLowColor">#33FFFFFF</Color> or <Color x:Key="SystemBaseLowColor">#33000000</Color> depending on theme.
So I'm wondering how useful it will be to call out SystemBaseLowColor, etc in this table because it doesn't tell the whole story.

This redline document, who is it for...  Those contributing and building the control/templates? Developers who may be styling and re-templating the control in the future?
Giving the final resolved colour is fine for those recreating the control designs - but looses the contextual information the assigned resources give.
Then if you take the Outlined Button Border Colour, would it use the same colour/resource as the CheckBox Border, or the ComboBox, TextBox border colours?  If they all share the same resource, that means there is a cohesive choice on the part of the design team.
There is a heirachy leading to the final resolved colour, so what levels do people need to be made aware of?

<Button Border="Black"/> (Local styling)

OutlinedButtonBorderBrush (Lightweight Control level styling)

SystemControlForegroundBaseMediumLowBrush (Theme level styling)

SystemBaseMediumLowColor (System level styling)

#66FFFFFF (Resolved colour)

@mdtauk , the redline is for the engineer to make the style and make changes to our controls as well as for those who might want to copy the style where they cannot (like WinForms, WPF customers) since I heard those developers express interest for redlines when I talked with them at conferences.

Then if you take the Outlined Button Border Colour, would it use the same colour/resource as the CheckBox Border, or the ComboBox, TextBox border colours? If they all share the same resource, that means there is a cohesive choice on the part of the design team.

That is the model our color system has already. We don't document this today because we have not heard request for this info, we don't have resources to document and maintain, etc.

@mdtauk , the redline is for the engineer to make the style and make changes to our controls as well as for those who might want to copy the style where they cannot (like WinForms, WPF customers) since I heard those developers express interest for redlines when I talked with them at conferences.

If the engineers are the ones updating the controls, then they should surely not be using hex colours, but instead using the appropriate ThemeResources.

@mdtauk , that's what we do but since we don't have those documented, engineers typically find the system theme color based on the hex provided and we make sure they are the ones we want them using.

@mdtauk , that's what we do but since we don't have those documented, engineers typically find the system theme color based on the hex provided and we make sure they are the ones we want them using.

So once the Resources have been assigned, would these redlines be updated to document both the resolved colour, and the System/Theme Resource?  Also some of those Theme Resources will use the same colour, but have a different contextual usage, and so an Outlined Button Border, shouldn't use SystemControlDisabledBorder for instance, as the border is used whilst the control is active.

So once the Resources have been assigned, would these redlines be updated to document both the resolved colour, and the System/Theme Resource?

@mdtauk , if we have unlimited resources that'll be how we would like to do, but we are unable to document and maintain such information so that'll have to be queried from the source code. I know that's not a good answer but that's the reality.
We do look at the colors systematically and assign the right color, change the related color if that's good for the system, etc. That's why seemingly small changes take a long time to design and plan.

Ok, so accepting it is a decision based on speed, if not thoroughness right now @chigy, I see no reason to pursue it further.
As to the values that have been added so far.  Those Outline button styles...

The values look as if they have been lifted directly from the Fabric Web implementation, which does not match the colour values you would find in the Windows Theme Resources. (The colours are warmer greys, and not using transparency like the Default Button Fill.

1. Button Text Colour
2. Button Fill Colour
3. Button Border Colour

State
Fill style
Accent style
Outline style
Ghost style

Rest
1. #FF000000 (100% Black) no change 2. #33000000 (20% Black) no change
1. #FFFFFFFF (100% White) no change 2. 100% Accent color no change
1. #FF000000 (100% Black) 2. Transparent 3. #66000000 (40% Black)
1. #FF000000 (100% Black) 2. Transparent

Hover
1. #FF000000 (100% Black) no change 2. #1A000000 (10% Black)
1. #FFFFFFFF (100% White) no change 2. 100% AccentLight1 color
1. #FF000000 (100% Black)  2. #19000000 (10% Black) 3. #66000000 (40% Black)
1. #FF000000 (100% Black) 2. #1A000000 (10% Black)

Pressed
1. #FF000000 (100% Black) no change 2. #66000000 (40% Black) no change
1. #FFFFFFFF (100% White) no change 2. 100% AccentDark1 color
1. #FF000000 (100% Black) 2. #33000000 (20% Black) 3.  #66000000 (40% Black)
1. #FF000000 (100% Black) 2. #33000000 (20% Black)

Disabled
1. #66000000 (40% Black) no change 2. #33000000 (20% Black) no change
1. #66000000 (40% Black) no change 2. #33000000 (20% Black) no change
1. #66000000 (40% Black) 2. #00000000 (Transparent)  3. #66000000 (40% Black)
1. #66000000 (40% Black) 2. Transparent color

@mdtauk , you are correct. We are lifting the values from Fabric right now because there is no direct customers on Windows/shell that is using outline design today.
Would you be interested in proposing color model matching that to the Window design for Outline version of the style? Or the table you added your proposal?

@mdtauk , you are correct. We are lifting the values from Fabric right now because there is no direct customers on Windows/shell that is using outline design today.
Would you be interested in proposing color model matching that to the Window design for Outline version of the style? Or the table you added your proposal?

@Chigy  I have a proposal about altering the Light and Dark theme colours to make them less stark and more in line with other UI platforms - so the resolved colours would be part of that change.
Proposal: Improve the default Light and Dark Theme colours #920
The table above is specifically about bringing it into line with the existing Windows control styles, using existing Theme Resources - so if the Outline Style is added along with Ghost style - they will be consistent with the XAML controls.
If these redlines are there to guide those building the new control styles - the values used should be as close to the final values as possible - to save work changing them after the design team finalises the design comps.
The 40% Black colour is the same as those used by the Text Box, Combo Box, and other Picker controls - as buttons will sit alongside those controls in a Form very often.

The table above is specifically about bringing it into line with the existing Windows control styles, using existing Theme Resources - so if the Outline Style is added along with Ghost style - they will be consistent with the XAML controls.

@mdtauk , thanks!
I have a few feedback on your design:

I think # 3 should be # 4 in your table since # 3 is focus rect. :)
Why are you making the hover color slightly different from the other styles?
Shouldn't disabled outline be different color (lighter) than the rest of the states?

I copied the existing table from the commit, so that may need updating too. But I have edited it now to correct it.

Why are you making the hover color slightly different from the other styles?

The Hover is different in the Ghost style, and the Outline style from Fabric Web is more subtle than the Filled Styles in UWP - so I thought Outline and Ghost should match, and semantically I believe it works.

Shouldn't disabled outline be different color (lighter) than the rest of the states?

I seem to remember with the placeholder text color, there being an issue with contrast ratios.  The disabled Text is a 40% Black value, and so I felt a different value for the border, may not be visible enough - but it could be made 20% Black.  It should be consistent with the Disabled borders for TextBoxes, CheckBoxes, ComboBoxes, and other Picker controls.
At the moment, those TextBoxes and Pickers are filled in when defaulted - but that would make the Outlined Button more visible than it is in it's Rest state - which could be a problem.

Pushing forward with thinking through the Outlined button style.
Toggle Button

Here are some initial thoughts.  I made some changes to the existing Filled and Accent button styles, as well as came up with an idea for the Outlined and Ghost Styles.

With Accent style being made formal, I felt the Default ToggleButton should probably not use it for its toggled state, to avoid confusion.  So I use an "inverted" approach which gives emphasis.
Like with the text and picker controls, I gave the Outlined buttons a 2px border, using the accent colour, for their toggled state. (I am not entirely happy with both Default and Accent styles sharing the same Toggled on state design, but apart from adding a border when toggled, I can't immediately think of a better approach)
I took the idea of the selection indicator from the Pivot control, and used it for the Toggle State on the Ghost style buttons.

@mdtauk , thanks for exploring. I personally don't feel Accent styled button makes sense to be toggled... Toggled ON state is basically accented to indicate it is ON. So in a way, ON state is the accent style. Does that make sense?
There is a design direction team who makes the call around where to use accent color, etc. Since they are not telling us to change the use of accent color, I'd like to stay within the current design system (i.e. toggle on is the accent). This is unless the new proposed design makes it so much better for usability. In this case, it is interesting but I am not sure if it makes it better. It is just different.

@mdtauk , thanks for exploring. I personally don't feel Accent styled button makes sense to be toggled... Toggled ON state is basically accented to indicate it is ON. So in a way, ON state is the accent style. Does that make sense?
There is a design direction team who makes the call around where to use accent color, etc. Since they are not telling us to change the use of accent color, I'd like to stay within the current design system (i.e. toggle on is the accent). This is unless the new proposed design makes it so much better for usability. In this case, it is interesting but I am not sure if it makes it better. It is just different.

So I guess the best thing is to only offer Outlined, Filled, and Ghost style for the ToggleButton control, with Accent only available on the Button?

@mdtauk , thanks for exploring. I personally don't feel Accent styled button makes sense to be toggled... Toggled ON state is basically accented to indicate it is ON. So in a way, ON state is the accent style. Does that make sense?
There is a design direction team who makes the call around where to use accent color, etc. Since they are not telling us to change the use of accent color, I'd like to stay within the current design system (i.e. toggle on is the accent). This is unless the new proposed design makes it so much better for usability. In this case, it is interesting but I am not sure if it makes it better. It is just different.

So I guess the best thing is to only offer Outlined, Filled, and Ghost style for the ToggleButton control, with Accent only available on the Button?

Yes. I personally feel very confused by the accent/dark button. It really does not communicate clearly which one is on or off... At least we have a mental model in Windows that accent color is associated with the on/selected state.

Will Buttons use the Semibold font weight like Edgium and Fabric Web, as opposed to the regular weight like UWP XAML and FastDNA. as well as Hyperlinks and Body text?

200% scale


Create an initial release

Now that the upstream changes in legion have landed in a released version of legion, I think we can look to publish this crate.

[ ] Ensure all dependencies are up to date
[ ] Asset-uuid and atelier-core are used as dev-dependencies. Not sure if cargo will allow publishing in this state?
[x] Merge #3 (possibly with edits :) )
[ ] Review naming. For example, I was thinking about renaming Prefab to UncookedPrefab (we also have a CookedPrefab
[ ] I've considered merging legion-prefab and legion-transaction. Now I'm looking at it, is seems like legion-prefab is doing RON serialization and transaction is doing bincode serialization. I suppose it's because prefabs generally get saved to disk and transactions are temporary in-memory. Regardless, I think the only justification for keeping the crates separate is that legion-transaction adds a dependency on bincode. I don't think there is much value in keeping them separate.
[ ] Commenting pass - both API and some basic explanation of what's going on inside functions.
[ ] cargo metadata (categories/keywords/description/authorship for crates.io)
[ ] examples?
[ ] unit tests?
[ ] readme updates, any sort of announcement we want to do

I feel that much of the above could easily be pushed off to 0.2. Additionally we should keep an eye on bincode to release 1.3.0. We are somewhat blocked from publishing until https://github.com/servo/bincode/issues/321 is resolved.

FYI I pushed a legion-0.3 branch. It may make sense to archive the current legion-0.2 compatible HEAD to a legion-0.2 branch if we pull legion-0.3 to be the new master branch

Just an update, legion-0.3 is now on the master branch and the bincode dependency issue was resolved.
Added CI but had to exclude examples as there was a compile error.


KTlint web-ui demo project

KTlint is so awesome project and we love it <3 so much that on our free time we have created a demo of ktlint standard and custom rulesets to show it for everyone. Enjoy: https://ktlint-demo.herokuapp.com/
Thank you so much for your work, guys! 👍

Nice :+1:
Where I could look on the app sources and do you want to add a link to project readme?

@Tapchicoma yes, the link is on the bottom of the page :) https://github.com/akuleshov7/diKTat-demo
Yeah, I guess it will be good to add it to readme. You won’t mind if I will do it?

Yeah, I guess it will be great and useful to add it to readme. You won’t mind if I will do it?

Personally I don't mind to add this link to README. Feel free to open a PR.


If RemovePlist is set to True, loss of functionality

When testing the master branch, if RemovePlist is set to True and a key is escrowed, Crypt loses the most of the new functionality:
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L61
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L97
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L130
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L146
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L163
https://github.com/grahamgilbert/crypt2/blob/master/Package/checkin#L184-L193
Perhaps this should be set to RemoveKey vs RemovePlist. This would require the least amount of code changes, however it is a breaking change due to the administrative burden.

These line numbers don't really make sense now, so I don't really know what is being referred to here.

I don't even remember anymore. Let's close for now.


Stuck in RTL_STATE_RETURN

Describe the bug
Just experienced a very dangerous bug on today's latest upstream master. My quad got stuck in a state where RTL was seemingly always engaged when in an auto flight mode. I have no idea how the stuck RTL state even got triggered, as I did not issue an RTL command. As soon as a noticed the weird behavior I issued a land and it just started flying straight at me (it's home location) but it didn't first ascend like an RTL normally should. I was able to land the quad manually and I attempted another takeoff. This time, as soon as takeoff completes it switches to loiter (as it should) and again just started flying straight at me. I interrupted it and brought it down manually. The log got cut off mysteriously and it did not produce a log for the short flight afterwards. Unfortunately I only have the first 4 seconds of the flight when the bug cropped up :confused:.
To Reproduce
I tried to reproduce this and I could not. This happened after about 40 minutes of flight time with this build. I had issued many RTLs and LANDs during this time with no issues. Just randomly the quad started flying straight at me so I landed it manually (because issuing land was causing it to fly right at me too). This behavior persisted until I rebooted the vehicle.
Heres the log, it is pretty useless though
https://review.px4.io/plot_app?log=0873f769-503b-4cf4-a795-0a59e3442719

I don't know if there's much we can do without data, unless someone else has seen this before and knows where the origin might be


Additional frameworks

Don't have some spare time at this point to fork and PR, but in future you may want to add:

Basscss
Concise CSS
Furtive

Thanks for this! Hadn't heard of these before... will add them in ASAP :+1:

Done! Unfortunately Basscss could not be added since it only uses custom classes and so isn't really a drop-in CSS framework. Feel free to re-open this at a later point if you want to modify the Basscss classes to work out of the box!


Proposal: Create classes for targets and modules

TypeScript is able to transpile to a number of different JavaScript levels (targets) and a number of different loader frameworks (modules).
Basically, each target and each module are just a peculiar manifestation of the same task, having a common core for performing the basic task of transpilation.
Moreover, targets and modules may come and go over time.
To me - from an architectural perspective - this screams for a provider pattern, having a basic emmitter class utilizing a Target provider interface and a Module provider interface for dealing with the different peculiarities of a target and module, resp.
Looking at src/compiler/emitter.ts, it's currently a huge dump bin for all of this code. The code in the file is hard to find, hard to maintain and it's hard to add new targets and modules.

So I suggest to split emitter.ts into a class with no notion of targets or modules and into a number of Target and Module providers:
<src>

| -- <compiler>

  | -- <Modules>
    | -- IModule.ts
    | -- system.ts
    | -- amd.ts
    | -- commonjs.ts

  | -- <Targets>
    | -- ITarget.ts
    | -- es3.ts
    | -- es5.ts
    | -- es6.ts

  | -- emitter.ts

`emitter.ts` might then look similar to this:
```ts
class emitter
{
  constructor(IModule module, ITarget target)  { ... }
transpile(source) : string  {...}   // returns transpiled string
}

`emitter.ts` should contain all the boilerplate code that's not related to a target's or module's peculiarities. This boilerplate code should then call appropriate interface methods on the provided target/module providers to be able to create a target/module aware result.

Naming the target/module classes like the corresponding compiler option will make it easy to safely add/remove targets/modules to the compiler.

We are working on rewriting the emitter into a series of transformations on the tree. this should allow for adding extensibility points in the future to handle module transformations in a way that is not natively supported by the TS compiler today. Please see https://github.com/Microsoft/TypeScript/issues/5595 for more details.
and you can see the work done so far in https://github.com/Microsoft/TypeScript/tree/transforms

closing in favor of #5595

Excellent :clap:


How to use customized segmentation mask for test?

I want to replace the OneFormer used in your demo with some other segmentation models (for instance, SAM), now suppose I have
input_img: H1 * W1 * 3, uint8
input_mask H1 * W1, binary 0,1
ref_img: H2 * W2 * 3, uint8
ref_mask: H2 * W2 binary 0,1

How should I modify the demo code to get correct structure and appearance guidance features? Thanks for your help in advance!

Also，

Yes the image should be torch.float32 and [-1，1] and mask should be of type int(), so it can be binary as well

@Lotayou btw, if I understand correctly, to run this with a different segmentation model you are not only going to need a binary mask, but also the panoptic and semantic segmentation masks
If I understand correctly, you pass to get_appearance: {the input image and the panoptic mask (which isn't binary)} and {the reference image and the reference mask (which is binary)}  (but please correct me @vidit98 if wrong)

Yes, that is correct and if a different segmentation model is used the class mapping should match that of the trained model else a new model has to be trained. The pipeline @CesarERamosMedina  is talking about is for the demo, however, I see the picture above from the model definition.

I actually meant from the model itself. I think the code in your gradio app makes two calls to that function, one with a binary mask and one with a non-binary mask


relatedItem should be available in bibl

From<EMAIL_ADDRESS>on August 30, 2013 11:13:23
In the ODD, <relatedItem> is a member of model.biblPart, which means it should be available within <bibl>.  However, it is strangely missing from the definition of model.biblPart in the RNG schemas.
<elementSpec ident="relatedItem" module="MEI.shared">
<desc>(related item) – Contains or references another bibliographic item which is related to the present one.
<classes>
<memberOf key="att.datapointing"/>
<memberOf key="att.common"/>
<memberOf key="att.bibl"/>
<memberOf key="att.facsimile"/>
<memberOf key="att.pointing"/>
<memberOf key="model.biblPart"/>
</classes>
etc.
<define name="model.biblPart">
<choice>
<ref name="model.editionLike"/>
<ref name="model.respLike"/>
<ref name="biblScope"/>
<ref name="creation"/>
<ref name="extent"/>
<ref name="genre"/>
<ref name="imprint"/>
<ref name="physLoc"/>
<ref name="recipient"/>
<ref name="series"/>
<ref name="textLang"/>
</choice>
</define>
Creating an RNG schema using the customization service results in a schema that does contain recipient in model.biblPart.  Perhaps simply replacing the current 2013 RNG schemas with newly-generated ones would be sufficient.
Original issue: http://code.google.com/p/music-encoding/issues/detail?id=175

From<EMAIL_ADDRESS>on August 31, 2013 09:04:59
Labels: -Priority-Critical Priority-High

From<EMAIL_ADDRESS>on February 07, 2015 13:28:40
This appears to have been a problem related to the customization process that has since been resolved.
Status: Invalid


[BUG] j.insert_data uses all CPU capacity when database is too big

Describe the bug
Inserting a large dataset in JAI is crashing the CPU process.
To Reproduce
Steps to reproduce the behavior:

Insert large dataset (~4M de linhas)

Expected behavior
Insert data and go on fast.

Solved by #304


Dropdown options missing IDs

Note: this issue is part of several steps that should be taken to make the Select2 list options accessible, see #3735 and #4349.
Each item in the results list should always have an unique ID to be used as value for aria-activedescendant on the search field (or on the selection element when the search is hidden).
Without aria-activedescendant (and aria-owns and other aria attributes), assistive technologies can't understand which item in the list is currently "highlighted", thus they can't announce its content.
As far as I see, Select2 is based on various "data adapters" to normalize the data to pass to the widget. See BaseAdapter, SelectAdapter, ArrayAdapter, AjaxAdapter, etc. On the other hand, each item object in the results list is "normalized" by a _normalizeItem() function which in turn calls generateResultId()
If I'm not wrong, this is the relevant call in src/js/select2/data/select.js
if (item._resultId == null && item.id && this.container != null) {
  item._resultId = this.generateResultId(this.container, item);
}

It seems this fails for some adapters (e.g. array, ajax, tags) because at this point this.container is null. See in the screenshot below "red", "blue", and "green" don't have an ID:

I'd appreciate any feedback here. Also, I'm not sure I can find a fix without help from someone with more advanced coding abilities than me :) Wondering what to do here, maybe the simpler thing would be using a different way to generate a unique ID?

This appears to only happen for items passed in as data, making it an issue in the ArrayAdapter.


Use first if multiple files returned by where.exe

What I did
I added code for when "where.exe" finds multiple solc executables. Previously this would cause the solc compiler to be not found when trying to compile a file. Now only the first line of output from where.exe is kept and everything works as expected.
Related issue: #
How I did it
How to verify it
Checklist

[x] I have confirmed that my PR passes all linting checks
[ ] I have included test cases
[ ] I have updated the documentation (README.md)
[ ] I have added an entry to the changelog

Outdated- we changed to shutil.which()


Implement module utils::perfmeters

Will help evaluating performances and time consuming.

completed, with minimalist first version.


Fix several issues reported by FindBugs

Addresses several issues reported by FindBugs. (#241)

Remove unused field and local variable
No one references it. (Anonymous classes may look like they would reference it later, but they are actually referencing another 'appEngineHelper' qualified with 'final'.

Copy an array when storing it (i.e., not a ref to a mutable outside object)
Security issue. It is currently storing a reference to a mutable external array. I've checked all usages of 'setWatchExpression' function in the codebase, and it is safe to make a copy. I reckon that performance impact of copying is negligible.

Start method names with lower case letters
Close() -> close(), Create() -> create(). Not sure if they were intended though.

Always close ZipFile as soon as possible
Not sure if it is tolerable to let it open for a while in this situation.

LGTM once you've changed the message text and squashed the commits.


Conditionally use PureComponent instead of Component

Working to resolve #1297.  Conditionally using React.PureComponent instead of React.Component

Coverage increased (+0.3%) to 84.907% when pulling e362c8e053af600a095f93fea1ff3ec582364a27 on getaroom:PureComponent-Upgrade into ebf83a1eb3bd3745d6a73dea671d93d23585d1a6 on airbnb:master.

@ljharb what does the jsdoc comment need to be? Your linting system is different than I am used to working with.

Also, @majapw this PR only resolves most of the avoidable re-rendering issue.  As I mentioned in #1297, I was not able to resolve some re-rendering on DayPickerNavigation or on DayPicker

(what are you used to working with that’s not eslint?) i believe it’s /** @extends React.Component */ but I’ll have to check the docs and get back to you. You can test by introducing a lint error, verifying that it fails when it extends React.Component, verify that it passes when extending baseClass, and then verify that it fails with the JSdoc comment.

@ljharb not in that way.  I guess I never knew about being able to do that is a better way of describing it.

@AntiFish03 here's an example: https://github.com/yannickcr/eslint-plugin-react/pull/513#issue-64025078

@AntiFish03 what's the reasoning that the baseClass stuff needs to be in a function, instead of caching it once at module load time?

It doesn't have to be. Just trying to keep it similar to what is used in react-with-styles as was requested.

travis-ci decided to have some timeout issues there for no apparent reason... @ljharb care to restart that and everything should be good to go

After a few discussions, i wonder if it'd be worth it to try something like this?
/** @extends React.Component */
class Foo extends React.PureComponent || React.Component {
  [React.PureComponent || 'shouldComponentUpdate'](nextProps, nextState) {
     return shallowCompare(this, nextProps, nextState);
  }
}

Otherwise, your change LGTM.

@ljharb, Change made as requested anything else?

@ljharb, Readme updated.

@majapw, @ljharb There you go both of those pieces should be fixed now

So fun fact, I believe that this breaks react-dates in IE10. sigh It seems to be related to how this is transformed by babel (current working theory is something about the double-extends).
I'm seeing Cannot call a class as a function coming from<EMAIL_ADDRESS>

@majapw all of a sudden I am getting
Warning: DateRangePickerInputController has a method called shouldComponentUpdate(). shouldComponentUpdate should not be used when extending React.PureComponent. Please extend React.Component if shouldComponentUpdate is used.

Is this something you are seeing also?

@AntiFish03 locally or in storybook? on the latest version?

@majapw, Locally from master.


API

instead of the running the program in command line, is there a way/tutorial I could follow to call its API in my code? Thank you

There's no tutorial but you can always pull the functions in the scripts directly into your own code and run it. won't be that straightforward due to the config file.
Also not recommended at this time, as CLI is undergoing rapid development and function names are likely to change.


updated to ASC details

the trial period is now 30 days and the feature is now GA in Azure government.

@rkarlin : Thanks for your contribution! The author, @gsacavdm, has been notified to review your proposed change.


Path issues

Path is not aligned on every floor.
Path animation changes based on the length of the path.
Paths on a single floor are not working.
No icons at the start/end of the path.

2 and 3 are fixed


netrc optional change

Clone of https://github.com/JFrogDev/cocoapods-art/pull/12
Working with employer to get CLA signed should hopefully have this early next week

Thanks @marchinram.
Please let us know when the CLA is signed and we'll merge this.

@eyalbe4 I got approval for this, however my work email is different than my github email, will that matter or does need to match?

@eyalbe4 The CLA has been signed, the signer's name is Matt Kamen, did you receive? Or does it need to be manually sent?

@marchinram,
I'm afraid the CLA must be signed with the same github email address and name of the committer...
You can either ask the person who signed the CLA to submit a new pull request or sign the CLA.

@eyalbe4 I signed CLA do you receive automatically or do I need to email you?

hey @eyalbe4. Thanks for merging this. We realized after the merge that this only solved the first half of the issue which was pulling the podspecs from artifactory. We didn't realize that the artifactory server was the one putting in the source line to the podspec and at that point it doesnt include any credentials. So now pod install is failing because the source file doesnt have the authentication information that was now added in the repo add step.
The solution seems to be modifying the source line of the downloaded podspec and including the credentials from the stored repo url. I cant decide if that feels hacky or necessary. Any thoughts?

I personally could yeah, we were just trying to avoid the .netrc file since we are distributing the pod in question to external parties. The .netrc file seemed like an excessive step to request that they modify their environment outside of the project workspace for this to work. It definitely appears as if it will be the only solution for now.


Alias laravel using /Users/andreas variable instead of /home/andreas.

On a mac where the homedirectory is in /User/{username} instead of /home/{username} this alias broke my laravel comand. This fix is tested on mac and on linux ubuntu.

Nice catch - looks good to me!


feat: gas price for postage batch creation

This add functionality to specify Gas Price for the creation of postage batch as introduced in https://github.com/ethersphere/bee/pull/1769

The test is failing because the check for the short git hash expects exactly 8 hex characters.
However based on the answer of this it seems that on some systems the minimum length is 7 characters and for git the minimum is actually 4 characters.
Please note also that based on the documentation of git this is only the minimum length, but since git returns a unique short hash it may be longer than that.
Based on this I would suggest to change the {8} to {4,} (4 or more) in the regex.

Thanks Attila! Good suggestion. Yeah this PR is based on version of bee-0.6.0 before it had the regex fix.


Files with Certain Unicode Characters Don't Upload

Client Code
>>> r = requests.post("http://server/upload", files={"file": (u'\u0412\u0430\u043b\u044e\u0442\u043d\u043e\u0435\u0437\u0430\u043a\u043e\u
043d\u043e\u0434\u0430\u0442\u0435\u043b\u044c\u0441\u0442\u0432\u043e.\u0420\u0438\u0441\u043a\u0438\u043a\u043e\u0440\u0440\u0435\u043a\u0442\u0438\u0440\u043e\u0432\u043a\u0438\
u0442\u0430\u043c\u043e\u0436\u0435\u043d\u043d\u043e\u0439\u0441\u0442\u043e\u0438\u043c\u043e\u0441\u0442\u0438.doc', file_bytes)})

Server Code
@route("/upload", method='POST')
def upload():
    if request.files.file != "":
        data = request.files.file
    else:
        data = None

    if data is None:
        abort(400, "No file provided")

    return {"status": "success"}

Result:
>>> r.status_code
400
>>> r.text
'...No file provided..'

Using UWSGI.

To be clear, the problem is with file names, not the files themselves?

Well, the application is told that there is no file in this case.  Maybe I
should be reporting this further upstream since it may not be strictly a
bottle problem.
On Tuesday, May 24, 2016, Eric Wieser<EMAIL_ADDRESS>wrote:

To be clear, the problem is with file names, not the files themselves?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/bottlepy/bottle/issues/852#issuecomment-221321867

Let me clarify my question:

Files with Certain Unicode Characters Don't upload

Is this:

Files with certain unicode characters in their name don't upload
Files with certain unicode characters in the file's contents don't upload?

It's the first one.  "Files with certain unicode characters in their name don't upload".

The requests urllib3 library uses extended header attributes, which I suspect cgi.FieldStorage does not understand.
Content-Disposition: form-data; name="file"; filename*=utf-8''%D0%92%D0%B0%D0%BB%D1%8E%D1%82%D0%BD%D0%BE%D0%B5%D0%B7%D0%B0%D0%BA%D0%BE%D0%BD%D0%BE%D0%B4%D0%B0%D1%82%D0%B5%D0%BB%D1%8C%D1%81%D1%82%D0%B2%D0%BE.%D0%A0%D0%B8%D1%81%D0%BA%D0%B8%D0%BA%D0%BE%D1%80%D1%80%D0%B5%D0%BA%D1%82%D0%B8%D1%80%D0%BE%D0%B2%D0%BA%D0%B8%D1%82%D0%B0%D0%BC%D0%BE%D0%B6%D0%B5%D0%BD%D0%BD%D0%BE%D0%B9%D1%81%D1%82%D0%BE%D0%B8%D0%BC%D0%BE%D1%81%D1%82%D0%B8.doc

I'm not really sure yet.

Confirmed. And it seems that werkzeug or the stdlib email library don't parse these either. Support for RFC 2231 seems to be rare.


Update create-pods.md

updated correct command with -

Learn Build status updates of commit 628c829:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AKS-Hybrid/create-pods.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@vishnuvizz Thank you for catching that! #sign-off


descargas2020.py is broken

descargas2020.txt

Expected behaviour:

Actual behaviour:
Hi!!!
The website descargas2020.org doesn't exist. The new websites are pctmix.com and pctmix1.com
Steps to reproduce:

Step 1: ...
Use this rss: https://www.synologia.com/rss/pctmix.com

Config:
templates:
  global:
    free_space:
      path: /media/multi
      space: 3000
    regexp:
      reject:
        - WEBRip: {from: title}
        - Subt: {from: title}
        - subtitulo: {from: title}
        - HDTV: {from: title}
  tv:
    upgrade:
      tracking: yes
    timeframe:
      wait: 1 minutes
      target: 720p+
    series:
      - Servant
    set:
      path: /media/multi/descargando/
      content_filename: "{{series_name}} {{series_season|pad(2)}}x{{series_episode|pad(2)}}"
      move_completed_path: /media/multi/videos/SERIES/{{series_name}}/
      main_file_only: yes
      hide_sparse_files: yes
      keep_subs: yes
    deluge: yes
tasks:
  tv:
    rss:
      url: https://www.synologia.com/rss/pctmix.com
    template: tv
    manipulate:
      - title:
          replace:
            regexp: 'Temp. '
            format: 'S'
      - title:
          replace:
            regexp: ' Capitulo '
            format: 'E'
      - title:
          replace:
            regexp: 'Temp. \d+'
            format: ''
      - title:
          replace:
            regexp: '\[Cap.(\d?\d)(\d\d)\]'
            format: ' S\1E\2'
      - title:
          replace:
            regexp: '\[Cap.(\d?\d)(\d\d) Final\]'
            format: ' S\1E\2'
      - title:
          replace:
            regexp: '\[HDTV 720p\]'
            format: ' 720p'
      - title:
          replace:
            regexp: '\(HDTV 720p\)'
            format: ' 720p'
      - title:
          replace:
            regexp: '\[HDTV 720\]'
            format: ' 720p'
      - title:
          replace:
            regexp: '\(HDTV 720\)'
            format: ' 720p'
      - title:
          replace:
            regexp: '\(HDTV 720p AC3 5.1\)'
            format: '720p'
      - title:
          replace:
            regexp: 'HDTV 720p'
            format: '720p'
      - title:
          replace:
            regexp: '\[HDTV 1080p\]'
            format: ' 1080p'
      - title:
          replace:
            regexp: '\(HDTV 1080p\)'
            format: ' 1080p'
      - title:
          replace:
            regexp: '\[HDTV 1080\]'
            format: ' 1080p'
      - title:
          replace:
            regexp: '\(HDTV 1080\)'
            format: ' 1080p'
      - title:
          replace:
            regexp: '\[HDTV\]'
            format: ' HDTV'
      - title:
          replace:
            regexp: '\(HDTV\)'
            format: ' HDTV'
      - title:
          replace:
            regexp: '\[V.O.Sub. Español Castellano\]'
            format: ' subtitulo'
      - title:
          replace:
            regexp: '\[V.O. Subt. Castellano\]'
            format: ' subtitulo'
      - title:
          replace:
            regexp: '\[[^\]]*\]'
            format: ''
      - title:
          replace:
            regexp: '-  '
            format: ''
      - title:
          replace:
            regexp: '  '
            format: ' '
      - title:
          replace:
            regexp: 'S(\d)E'
            format: 'S0\1E'

#### Log:

It says like "Unable to locate torrent ID from url xxxx"
Sorry, I don't save it

Additional information:

FlexGet version:3.1.102
Python version: 3.8.5
Installation method: pip
Using daemon (yes/no): yes
OS and version: Ubuntu 20.04

The solution is attached in descargas.2020.txt:
Change
REWRITABLE_REGEX = re.compile(
r'https?://(www.)?(descargas2020|tvsinpagar|tumejortorrent|torrentlocura|torrentrapid).(org|com)/'
)
for:
REWRITABLE_REGEX = re.compile(
r'https?://(www.)?(descargas2020|tvsinpagar|tumejortorrent|torrentlocura|torrentrapid|pctmix|pctmix1).(org|com)/'
)
Change:
if match:
torrent_id = match.group(2).rstrip('/')
for:
if match:
torrent_id = match.group(2).rstrip('/')
else:
scripts = soup.findAll('script', attrs={'type':'text/javascript'})
for script in scripts:
if "window.location.href" in script.text: #script with window.location.href captured
resultado = re.search('window.location.href = "(.*)";', script.text).group(1)
if resultado:
if resultado.startswith('//pctmix'):
direccion = 'https:' + resultado
return direccion
After this changes I have THIS log:
"Error while registering plugin descargas2020. A plugin with the same name is already registered"
I think I have to register the plugin but I don't know how to register it.
With this changes decargas2020.py work.
All the best,
Toni
(Sorry for my English)

I'll try to check whats going on with this.. But your code will not work, let me see what I can do

Sorry, I can't simulate this test case! I tested your config, without any changes, and it works without a problem! Is this still a problem? Can you provide more details like detailed log with debug?
If it's all working please close Issue!
Thank You

Hi Soloam,
I'm sorry but there are a lot of changes in pctmix1.com since I posted my file here.
I have changed
DESCARGAS2020_TORRENT_FORMAT = 'https://descargas2020.org/download/{:0>6}.torrent'
for
DESCARGAS2020_TORRENT_FORMAT = 'https://pctmix1.com/download/{:0>6}'
in my file and It's works again.
The new changes of the pctmix are now compatible with the original descargas2020.py (maybe they have gone back) so I close the issue.
Thank you and I'm sorry for the inconveniences!!!


Eclipse Like RFC Gateway Support?

Great job on the project,
Sadly i am unable to use it for day to day development because my main dev server has blocked the ports for the webservices.
RFC Gateway port 3300 and sap gui 3200 are accessible to me, hence im able to use eclipse adt fine.
Is there any reason you didnt use the rfc gateway for connection just like eclipse?
if you have any technical insight on that im considering to fork the project to get an rfc gateway compatible version!
Edit: i found that https://github.com/SAP/node-rfc is probably the technical info i will need to make a sufficient fork
Edit 2:
i have tried out the node-rfc library and was indeed able to replicate the quicksearch function on the ADT service, looks like with a good amount of work the RFC Gateway could be used as an alternative to the webservice on your https://github.com/marcellourbani/abap-adt-api

const noderfc = require("node-rfc");

const client = new noderfc.Client({ dest: "HCM" });

(async () => {
    try {
        await client.open();

        const request_line = {
            METHOD: "GET",
            URI: "/sap/bc/adt/repository/informationsystem/search?operation=quickSearch&query=TEST&maxResults=50",
            VERSION: "HTTP/1.1"
        }

        const sadt_request = {
            REQUEST_LINE :  request_line,
            HEADER_FIELDS : [ { NAME: "Accept", VALUE: "application/xml" }  ],
            MESSAGE_BODY : new Buffer(2)
        };

        const result = await client.call("SADT_REST_RFC_ENDPOINT", {
            REQUEST : sadt_request,
        });

        console.log(result.RESPONSE.MESSAGE_BODY.toString());
    } catch (err) {
        console.error(err);
    }
})();

I never tried it because depends on binaries with questionable licensing you have to install from your sapgui distribution (or at least it used to).
Might be possible to plug it in as an alternate transport for abap-adt-api.
If you're able to make it work I'll merge it, otherwise I'll try myself but don't hold your breath ;)

so i tried to implement it into the extension directly, but it turned out the sapnwrfc sdk has some problems with electron / vscode extensions in particular: https://github.com/SAP/node-rfc/issues/144
so instead i wrote a very simple expressjs server which exposes the RFC gateway to localhost to act just like the normal ADT Web Service.
Then all i need to do is enter localhost as the system parameter in the vscode extension and it works like a charm:
https://github.com/andwehrm/rfc-connector
btw, even the stateful operations work with this without having the plugin installed on my 7.40 System
the only problem im currently facing is that i only receive empty message bodies from the CDS checking "checkrun" api of the extension

Great idea!
As for the cds API my money is on a bug in the extension / api library
I never do any cds, so I have little feedback on them


Allows to set an already existing textarea as in-/output for grid editor

This PR adds an option to specify an already existing textarea as in-/output.

Useful, thanks.


Instance code generation uses and/or/not type symbols instead of text

In a file with this class:
lawless class C[a] {
    pub def f(g: a -> a & ef1, h: a -> a & ef2): a & ef1 and ef2
}

This is generated when I try to create an instance.
instance C[a] {

  pub def f(g: a -> a & ef1, h: a -> a & ef2): a & ef1 ∧ ef2 = ???

}

The ∧ symbol is invalid syntax.

You mean that the formatting is broken?

This problem is really in the compiler, right?

Yes, the formatting produced is "display" formatting, but it's not suitable for code generation.

This problem is really in the compiler, right?

I would guess so.

I mean ∧ should just be changed to and.

I mean ∧ should just be changed to and.

Yes, that's the simplest solution

I think this has been fixed.


Release/v1.4

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
bugfix for merchant total amount
✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Technical explanations to help your peers review your work - including environments, credentials, etc.
🙈 Screenshots
For all UI changes

description 1
description 2

img1
img2

👯♀ Paired with
@github-handle or "nobody" if you did not pair.

conflicts

conflicts


Private Accessors

This replaces the defunct #599

YESSSSSS. I was just about to create a new pull request like this myself today, haha.

I'd love to see these methods merged so that support node 7 in native modules is easy. Is there anything left to be done?  I have a couple days of time that I could try to help move this along.

The pull request must pass code review by another collaborator before it can be merged.

Thanks. I'll try to add such tests before merging.
On December 19, 2016 1:31:57 PM GMT+02:00, Ben Noordhuis<EMAIL_ADDRESS>wrote:

bnoordhuis approved this pull request.
LGTM.  Suggestion for additional tests: check that private and
non-private properties don't conflict when getting/setting/deleting.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/nodejs/nan/pull/630#pullrequestreview-13534276

Merged as a86255cb357e8ad8ccbf1f6a4a901c921e39a178


Block launcher For Intel

New block launcher for (Intel Only) can't instal mod , can't see skin on multiplayer , and capes it looks like old block launcher :( i hope you Fix it

try again? I've released a few more betas after the first one.

same it doesnt works :(

@parju is Safe Mode off? Did you install MCPE from the Play Store?

yes safe mod off and iam install mcpe from playstore and iam try to uninstall and reinstall again but still doesnt work :( mu device zenfone 5

My device is acer A1-840FHD and i have same problem.

I get an error on my Nexus Player trying to ran this app. Any help?

@freekiller201020 what's the error?

when you add Intel atom support?


[hidapi] update to 0.11.2

What does your PR fix?

This implements hid_get_input_report with the Linux hidraw backend
plus fixes a few bugs on Windows.

Which triplets are supported/not supported? Have you updated the CI baseline?

all

Does your PR follow the maintainer guide?

yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

Thanks for the update!


Updated GPO links to TallyArbiter repo

The links in the PGO section pointed towards the old external repo for gpo-listener. Links are now updated to point to the section within TallyArbiter.

Thanks!


Blog app: add API endpoints

In this branch, we implemented the following;

[ ] Created an API endpoint to list all posts for a user.
[ ] Created an API endpoint to list all comments for a user's post.
[ ] Created an API endpoint to add a comment to a post.
[ ] Our API endpoints receiveS JSON and respond JSON as well.

Here is a screenshot of our API
Posts

Comments

Joy's commits :
https://github.com/arnoldnekemiah/blog/commit/8aa69d9a2cafac8703ce91c205d80e67890c9a8c
https://github.com/arnoldnekemiah/blog/commit/efb1a099bce68df277470f9473077de6c6f5312d
Arnold's commits:
https://github.com/arnoldnekemiah/blog/commit/6f4b849a0621657eff1a1f746d6230adf69d0586

Hello  @Whoistolu,
I need you to clarify something, Do we have to add an extra folder for API such that we have 2 controllers? or we make changes on the same controller and make it be in the API folder?


No Availability of calendar component

I have gone through the components and found a need for calendar component. happy to create one

We’d love to have one, but this would have to be a primitive first. This isn't prioritised yet so I’d suggest for now, you can use a third-party one and style it using the Radix Themes CSS tokens so that it looks part.

I have a fully functioning prototype made purely with Radix components. Shouldn't be hard to implement into the base package? Radix team, let me know :)

@tresabhi can you please share the source code of this datepicker?

@vorant94 I wouldn't call this the most stable as it does live currently in the dev branch in my project. I am also not fully satisfied by the API, I may switch out the Date instances in the props and events for just a tuple of date, month, and year.
https://github.com/tresabhi/blitzkit/blob/dev/src/components/DatePicker.tsx


fix doctr

I had a typo and the docs where not generated when #34 was merged. Here is how they look now: https://ocefpaf.github.io/python-gsw/

Nice!


Cutting off lane lines at horizon

Hi is there anyway to remove lane lines before a certain y value? the current tested output of my model has lines being extended more than wanted so I would like to cut extra lane lines at a certain horizon. Thanks

@nathannzw You should check the postprocess procedure code and you will find what you want:)

Yup found it, thanks!


wrong position in ie7 when rotate image

I have run this code in ie 7, the get wrong position, but running ok in other browser.
var degree1 = 0.001;
var src1 = document.getElementById("handle").src;
var R = Raphael("holder", 590, 550),
handle = R.image(src1, 70, 36, 408, 408);
handle.transform('r' + degree1);
I think this is a floating-point overflow problem, so I suggest to be changed the code

return rad * 180 / PI% 360;
-->
return Math.round ((rad * 180 / PI% 360)* 1000) / 1000;

in file raphael.js line 517.
and the line 513, 506 should be be the same.

I was able to confirm that the suggested change does fix this issue for ie5, ie7, and ie8.  It appears only the last 3 decimal places affect the result, so perhaps it's overkill to reduce all the way to 3 decimal places.
 return 0.000990013774108022 // fails
 return 0.000990013774108 // works

Thanks to both :D


Build binaries for OS package managers

This change adds some scripts that should allow us to build deb and rpm packages. The only requirements are docker, bash, and any valid alluxio tarball.
To build a deb package:
$ ./dev/packaging/build.sh <alluxio_tarball>

To build an RPM
$ ./dev/packaging/convert.sh <alluxio_deb_pkg>

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8547/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8550/
Test PASSed.

@LuQQiu since you have some experience in building packages, could you take a look? Thanks :)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8563/
Test FAILed.

Thanks for pointing this out. I thought it was more standard
Either way, I actually think it's possible to remove the usage of realpath all together. I will push an update soon

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8591/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8596/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8598/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9419/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder-jdk11/28/
Test FAILed.


Style/StringLiterals: reports offense on \u0060 and \u0022

Expected behavior
Not to return error.
Actual behavior
$ rubocop text.rb
Inspecting 1 file
C

Offenses:

text.rb:1:25: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
OpenStruct.new(content: "\u0060")
                        ^^^^^^^^
text.rb:3:25: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
OpenStruct.new(content: "\u0022")
                        ^^^^^^^^

1 file inspected, 2 offenses detected

Steps to reproduce the problem
$ cat text.rb
OpenStruct.new(content: "\u0060")
OpenStruct.new(content: "\u00b4")
OpenStruct.new(content: "\u0022")
OpenStruct.new(content: "\u201d")

RuboCop version
$ rubocop -V
0.39.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.0 x86_64-darwin15)

I guess the cop is trying to tell you to switch those two. Autocorrect changes the two that it can:
rubocop master % ./bin/rubocop text.rb --only Style/StringLiterals --auto-correct
Inspecting 1 file
C

Offenses:

text.rb:1:25: C: [Corrected] Prefer single-quoted strings when you don't need string interpolation or special symbols.
OpenStruct.new(content: "\u0060")
                        ^^^^^^^^
text.rb:3:25: C: [Corrected] Prefer single-quoted strings when you don't need string interpolation or special symbols.
OpenStruct.new(content: "\u0022")
                        ^^^^^^^^

1 file inspected, 2 offenses detected, 2 offenses corrected
rubocop master % cat text.rb
OpenStruct.new(content: '`')
OpenStruct.new(content: "\u00b4")
OpenStruct.new(content: '"')
OpenStruct.new(content: "\u201d")

Now I'm surprised the other two weren't changed.

The other 2 are not ASCII.
This is expected behavior. I suggest this issue can be closed.


SetFlag Not working after update last version

SetFlag Not working after update last version

@SelvaMacApp Please fill out the issue template because I have no more information about your issue.

@SelvaMacApp try this))
self.mobileNumber.setFlag(for: FPNOBJCCountryKey.US)

Error: Ambiguous use of 'setFlag(for:)'
There is a conflict between the two public methods
public func setFlag(for countryCode: FPNCountryCode)
and @objc public func setFlag(for key: FPNOBJCCountryKey)

It does shows Ambiguous use of 'setFlag(for:)'. But if I use with FPNCountryCode.AE like this .setFlag(for: FPNCountryCode.US then it works.


⚠ File access (beta) has degraded performance

In 58c2929, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 13769 ms

Resolved: File access (beta) performance has improved in 3191c79.


Auto-commit happens even if tests fail

Maybe we should disable auto commit until we have a solution here?

I enabled this on our main branch. Will try auto merging today to make sure it works.


Case and assign examples on website don't appear to work

When I try to run either the 'case' or 'assign' examples from the dropdown menu on the website, I get an error The Verilog code did not produce a valid netlist.
When I run cello in eclipse using those verilog files, I get an error saying Exception in thread "main" java.lang.IllegalStateException: Error in abstract circuit.  Exiting. which traces back to line 236 in the following block:
try {
    abstract_lc = getAbstractCircuit(_options.get_fin_verilog(), ucf);
} catch(Exception e) {
    throw new IllegalStateException("Error in abstract circuit.  Exiting.");
}

I have a couple guesses for why the error arises but neither appear to be correct:
For the case statement, it seems like part of the problem may be that out1 should be declared as output reg out1;  since it's in analways block. However, doing so doesn't seem to fix the problem (also other verilog files like the 'Full Demo' would presumably need that line as well but don't so I guess that statement gets automatically written in the parser?).
For the assign statement, one issue that I see is that on this line:
 assign out1 = w0 | (a & c);
c is used but is never declared as in input. However, changing that to a b doesn't fix the issue.

I've noticed some bugs in the current parser, too. It's not really a proper parser to begin with, i.e. there is no parse tree, I think it just sort of cherry-picks supported cases by line scanning. I'm working on a rewrite of the parser now in Antlr, structural verilog is done, I'm near done with continuous assign statements, haven't started case statements yet. Hopefully issue a like this will disappear or be easier to diagnose.

Hmm ok. What do you think of using something external to parse the verilog and then parsing the output itself? There must be some sort of standard file format for circuits and it seems like that may solve a lot of headache down the road as Cello moves toward supporting more complex verilog.
I'm not sure if there's anything to do this (which I guess would be why it made sense to write a custom parser in the first place) but on first glance, it looks like ABC can already output a file in BENCH format (https://people.eecs.berkeley.edu/~alanmi/abc/abc.htm). This file looks like it could be parsed pretty straightforwardly?

I was definitely hoping that a java verilog parser was already in existence and I poked around looking for parsers before starting the Antlr thing I'm working on, but I didn't find much that looked very promising. I see ABC can output a few formats, but their website says supported input includes only "a very limited set of structural verilog." There's another tool called Icarus verilog, but it's written in C++ and only seems to provide command-line tools, I assumed that would be kinda hacky to intergrate. It seems decent though, if you're desparate you might be able to hook that up to ABC in the meantime. I think ABC is the next step after the parsed verilog anyway, after the and-inverter graph is built from the netlist.
Antlr seems nice, it makes the parsing very modular. It definitely makes adding new functionality less of a headache than adding more to the existing parser.


Trouble reading LZW compressed TIFF

Hi Tischi,
BigDataProcessor is unable to properly read LZW compressed tiff files.

I was trying to push our plugin at my lab here, in order to deal with tiff datasets only to find that it fails to open LZW compressed tiffs.
Here is the calibrated tiff file which I tried to open using BDP:
https://drive.google.com/file/d/1kN_TMJHcyAyQOCegBWVAzJclo2aGZEOv/view?usp=sharing
(This tiff opens fine in ImageJ)
Initial debugging shows that error is in OpenerExtension.java at https://github.com/tischi/fiji-plugin-bigDataProcessor2/blob/cc0e87c13238adbdbc6e2207a79d48b138e9972e/src/main/java/de/embl/cba/bdp2/OpenerExtension.java#L1066
where the readStart+ readLength value becomes more than the RandomAccessFile length for some z and file data is not read anymore.

I also tried to re-save a normal tiff using LZW compression and attemped to load it back. It seems the z slices are not read at all. But there is no error at the above mention line of code.

I am on it but OpenerExtension and related TIFF reading logics are mostly a black box for me.
Can you too dig in for a faster fix?

Detailed analysis of the issue(s) revealed 3 hidden issues within the TIFF save code.

Saving TIFF using LZW compression is flawed since the axis order changed. The newly saved tiff stack has only one frame per stack saved. This is because if the no. of channels is 1, this becomes the new z once the ImagePlus conversion happens.

Normal, uncompressed, tiff stacks’ saving is implicitly flawed. When we convert the 3D RAI to ImagePlus, again the axis order is switched. But we don’t realize it as the tiff writer anyway saves the new XYC stack (with C=27, for example), instead of XYZ stack.
We don’t realize as its cleverly named –C001-T001.tiff. Therefore loading these files next time also don’t cause a problem as the file loading is based on file name format and not on real metadata of the tiff. However, the tiff metadata clearly shows ‘channels = 27’.

Newly saved Tiff data has no calibration information.

Luckily the fix for all these are the same: call Utils.wrapToCalibratedImagePlus method. :)
So, these bugs are fixed now.
Note that the real issue of LZW Tiff (from my lab/working group) loading error is still open. This tiff opens fine in ImageJ(FIJI) directly but not in BDP.


flit and flit_core can be out of sync

For example
$ pip install flit==3.6.0
[...]
$ python -c "import flit_core; print(flit_core.__version__)"
3.7.0

This was detected, because the 3.7.0 release broke some build workflows (still investigating what exactly happened, see omnilib/ufmt#56) although flit==3.6.0 is pinned.

Sorry about that.
I'm not sure that 'out of sync' is really the problem, though - I think the changes in #499 may simply have broken it for you.
I don't think your pinning in requirements-dev.txt affects this at all: pre-commit uses pip install . which will look at pyproject.toml, and set up an isolated build environment with flit_core according to the [build-system] table.

I don't think your pinning in requirements-dev.txt affects this at all: pre-commit uses pip install . which will look at pyproject.toml, and set up an isolated build environment with flit_core according to the [build-system] table.

True. The pinning would only solve this for the development environment.

The breakage you're seeing has just been reported as #530. I'll leave this one open for the lower-priority discussion about what the dependency relationship between flit and flit_core should be.


Add SelectedItem example to enum extension

Fixes #568
Docs for Toolkit PR: none
What changes to the docs does this PR provide?

Adds another example to the enum extension markdown page, to highlight binding to an enum property with a combobox.
PR Checklist
Please check if your PR fulfills the following requirements:

[x] Correctly picked the right branch to base the change off (dev for new features, master for typos/improvements)
[ ] For new pages, used the provided template
[ ] For new features, added an entry in the Table of Contents
[ ] Ran against a spell and grammar checker
[x] Contains NO breaking changes

Other information

Docs Build status updates of commit 4232107:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/extensions/EnumValuesExtension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6a05b07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/extensions/EnumValuesExtension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f494438:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/extensions/EnumValuesExtension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Handle server termination by signal

What type of PR is this?
/kind feature
What this PR does / why we need it:
We now listen on SIGINT and SIGTERM to be able to handle server cleanup in a sane way.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/lgtm


Various changes to permit building locally and under GitHub actions in a fork.

fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/140
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/143
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/142
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/70
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/67
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/146
Also address out of date GitHub actions, problems with GitHub release and slow builds of conda workshop image.

Also...
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/145
fixes: https://github.com/vmware-tanzu-labs/educates-training-platform/issues/144


[WIP] set spawn as default method for starting multiprocessing

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2690
Fixes #2694
Type of changes
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test in docker image with multiprocessing mode
[ ] Test on MacOS with multiprocess mode
[ ] Test in docker image with cuda
Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

closing this for https://github.com/kserve/kserve/pull/2718


polymer broken on linux firefox

https://github.com/uProxy/uproxy/pull/639 introduces this regression, I believe.
I hear that this is preventing @salomegeo from doing any firefox testing. If this is indeed blocking, than it needs to be a priority to fixed the events we use on buttons so that they work generally.

@salomegeo - this is fixed right?


[DUOS-869][risk=no] Add user id to call

Addresses
https://broadinstitute.atlassian.net/browse/DUOS-869
Changes
Add the user id into the admin call

Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] PR is labeled with a Jira ticket number and includes a link to the ticket
[ ] PR is labeled with a security risk modifier [no, low, medium, high]
[ ] PR describes scope of changes

In all cases:

[ ] Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
[ ] Get PO sign-off for all non-trivial UI or workflow changes
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

This is the wrong approach to the problem.


Enhancement: enabling PowerManagement on Laptops

As reccomended by the nixos wiki page on laptops, you want to enable PowerManagement on laptops. And - if understand this correctly - this is a collection of weird configuration quirks you generally want to enable on specific devices, including laptops.
So my suggestion is to enable this option when you enable quirks for a laptop.
As an alternative solution, I also suggested adding it to the hardware-configuration generated by nixos-generate-config upon install. This issue can be found over on nixpkgs

I was just coming here to close this myself due to User Error.
Somehow the hardware-module line got lost in my configuration and I did not realize this.


Issue #185: Convert calendars if possible wrt Julian-Gregorian gap

🚀 Pull Request
Description
Test and possible proof-of-concept
Takes care of issue #185, and also allows conversion between julian and standard calendars if all datetimes are before 1582-10-5 0:0:0

Ready for review -- with cftime 1.5.2 all test pass. But this I leave to you.

Thanks for this @larsbarring, it looks like it should be useful new functionality.  However I think it may be necessary and sufficient to check the reference date in the unit, rather than checking the value dates themselves.  For example, if we have two units with references after the "gap" and inspect some date values before the gap, we have:
import cf_units

modern_standard = cf_units.Unit("days since 1582-10-20", calendar="standard")
modern_proleptic_gregorian = cf_units.Unit("days since 1582-10-20", calendar="proleptic_gregorian")

print("standard:", modern_standard.num2date(-20))
print("proleptic_gregorian:", modern_proleptic_gregorian.num2date(-20))

standard: 1582-09-20 00:00:00
proleptic_gregorian: 1582-09-30 00:00:00

So the standard/julian date is 10 days before the proleptic gregorian one, but these two dates represent the same actual day, so the conversion seems valid.
Conversely if our reference dates are before the "gap" but our values are after:
ancient_standard = cf_units.Unit("days since 1582-10-01", calendar="standard")
ancient_proleptic_gregorian = cf_units.Unit("days since 1582-10-01", calendar="proleptic_gregorian")

print("standard:", ancient_standard.num2date(20))
print("proleptic_gregorian:", ancient_proleptic_gregorian.num2date(20))

we actually get two different dates:
standard: 1582-10-31 00:00:00
proleptic_gregorian: 1582-10-21 00:00:00

What do you think?

Thanks for this @rcomer ! -- I hadn't thought along these lines, which of course are much simpler. One possible snag would be that the Julian and proleptic Gregorian calendars have different methods for defining leap years (the 400 year difference). But when in each calendar this difference kicks in I am not sure.

@rcomer Having now mulled over your idea a bit more I think that you are right! And that  it is even more general than what I was considering.
In the real world continuum of time a day is just a convenient and useful unit. And the real world calendars (standard, julian and proleptic_gregorian) are just three alternative methods for labelling these days; sometimes the labels overlap and sometimes not. As the calendars, i.e. the "labelling methods", are well-known is should be possible to convert between them (at least for dates onwards from 1-1-1).
Is this a fair interpretation of what you suggest?

@larsbarring, yes that's what I'm thinking - different labels for the same actual sequence of days.  I have to admit I hadn't begun to consider what happens at or before 1-1-1 though!

@rcomer, from your first comment I take it that you might already have a PR on its way? Anyway, I will close this PR because because following this approach will result in rather different code.

@larsbarring no I haven't made a branch for this.  I only got as far as playing with the units in a terminal to produce the output I showed.


disk-smart3: Added Windows support

This makes it possible to run disk-smart3 on Windows.
Disk listing is based on smartctl --scan.
Therefore disks are also addressed "unix style" (/dev/sda, /dev/sdb, etc.), a difference is that the --ignore argument takes the device including the path (so /dev/sda instead of only sda) - somehow this could certainly be unified if needed...
I haven't touched README.rst or icingaweb2-module-director/disk-smart.json, but did of course tests with a random bunch of hard disks (my USB Backupplattenhaufen 😅) - works.
Some Icinga service screenshots:

Thank you for your contribution!


jj2lsj's parity limitation

As highlighted in a recent email by @cffischer, jj2lsj crashes on lists with both parities present, and does not print out any warnings ( I think?). Only @gaigalas knows how hard it would be to extend the routine, and how much time it would take. We all have many things to do.
I would consider this "enhancement" having relatively low priority, but should nevertheless be adressed at some point.
Maybe a quick solution would be to add a check in jj2lsj and stop with an informative warning text for such lists?

Lines around "
do LS_number = 1, asf_set_LS%csf_set_LS%nocsf
if ((asf_set_LS%csf_set_LS%csf(LS_number)%parity == "+" &
!Changed by cychen
!.and.  ISPAR(iw1) == 1)  .or.                        &
.and.  ISPAR(NCFMIN) == 1)  .or.                        &
(asf_set_LS%csf_set_LS%csf(LS_number)%parity  == "-" &
!Changed by cychen
!.and.  ISPAR(iw1) == -1)) then
.and.  ISPAR(NCFMIN) == -1)) then
"  to deal with both parities.

Lines 220 and 222 in jj2lsj_code.f90 should be modified.

Thank you @CYChenFudan! Let's see what @gaigalas thinks! We want to be sure that this works, and does not have an effect on other connected codes such as the radiative transition codes.

@jongrumer You are welcome. By the way, we also modified the codes to deal with He-like ions (including both 1snl and 2lnl configurations), and the large-scaled transfermation (the indices of array exceeding 2^31). I am wondering how to upload these modifications.

@jongrumer You are welcome. By the way, we also modified the codes to deal with He-like ions (including both 1snl and 2lnl configurations), and the large-scaled transfermation (the indices of array exceeding 2^31). I am wondering how to upload these modifications.

Ok! Sounds interesting! The standard procedure is to:

Create a new branch from the master branch named with your initials + topic, i.e. for example: "CYC/He-large-scale". You can do this directly in the online interface, or locally. Make sure you start off from the latest master version.
Add all your changes as logically separated and well-explained commits on this new branch.   Try to stay synced with master as you work on this new development branch. This makes life easier when you're finally going to merge with master.
When you're happy and the modified code works as expected, make sure you test it carefully, create a pull request here in the online github interface, where you ask for your development branch to be merged into the master branch.
With the pull request active, it's then possible for the rest of the team to test and discuss your suggestions. At some point we will decide (me currently) if the pull request should be merged or not.

It all sounds a bit complicated (if you haven't done it before) but in reality it's actually not that bad.
The github help pages have a lot of info on this standard workflow.
Great to see more people joining the development! I'll come to Shanghai on ASOS, we can discuss more then!
Jon

OK. I'll try. Let's discuss at Shanghai.

Please help me out with the following error in jj2lsj program
Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
Backtrace for this error:
#0  0x7f18add6832a
#1  0x7f18add67503
#2  0x7f18ad5fcf1f
#3  0x7f18adedcb8b
#4  0x7f18adeddcbb
#5  0x7f18adee10a8
#6  0x7f18adee272c
#7  0x564dc56bc3ac
#8  0x564dc56be025
#9  0x564dc56ad3ee
#10  0x7f18ad5dfb96
#11  0x564dc56ad419
#12  0xffffffffffffffff
Segmentation fault (core dumped)
Regards
Ahmed

The ability to run both parities at the same time is addressed in Chen's patches in PR #45.
@CYChenFudan Does this patch also include your enhancement for large indices related to the He-calculations you adressed in the comment above?
"By the way, we also modified the codes to deal with He-like ions (including both 1snl and 2lnl configurations), and the large-scaled transfermation (the indices of array exceeding 2^31)."

@jongrumer  No, the other enhancements are not yet included in F90-version.  We'll find some time for them in the future.


Comments flagged as "unrecognized block"

HTML-style comments are correctly ignored when rendering, but a warning is flagged saying "Ignoring unrecognized block"
<!-- This comment raises a warning -->

Hey @Animeye can you give us a (minimal) blueprint example? Thanks.

It may only be doing this within certain sections.  Additionally, the warning does not appear when the page is first loaded -- it only appears once some content has been changed (even adding a blank line is sufficient).  The following should replicate the issue:
FORMAT: 1A
HOST: http://polls.apiblueprint.org/

# Polls API

<!-- This comment is fine -->

# Data Structures

<!-- This comment raises a warning -->

@Animeye Unfortunately Data Structures section does not allow any text at all except the MSON Named Types. Not even description text is allowed which is why the comment above is raising a warning.

@Animeye at the moment, the HTML-style comments can be used only where  description is expected

Sorry to resurrect this, but why doesn't the Data Structure section follow the API Blueprint spec on section structure?


How to upgrade from 1.3.6 to the latest stable version 2.0.2 based on kubernetes

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
From the upgrade documents recommended by the official documents, you can only see the upgrade based on the virtual machine deployment mode, not kubernetes Therefore, refer to the previous upgrade method from the source code based on tag: 2.0.2. Dolphin scheduler / SQL / upgrade / 2.0.2 was not found_ Schema, only dolphin scheduler / SQL / upgrade / 2.0.1 schema is the latest. Is it missing?
What you expected to happen
It is hoped that the kubernetes based deployment upgrade method will be added to the upgrade document recommended by the official document, and the dolphin scheduler / SQL / upgrade / in tag: 2.0.2 will be completed,
How to reproduce
Try upgrading 1.3.6 to 2.0.2 based on kubernetes
Anything else
There is nothing for the time being
Version
2.0.2
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Found out how to upgrade in kubernetes

Found out how to upgrade in kubernetes

hello，how to upgrade in kubernetes。I haven't found a way yet。


wbe.contours_from_raster doesn't work

whitebox version: whitebox-workflows 1.1.0
Python version: 3.11
Operating System: Windows
I am trying to generate contour curves from the following code:
import whitebox_workflows as wbw
wbe = wbw.WbEnvironment()
raster = wbe.read_raster('test.tif')
wbe.contours_from_raster(
raster,
'contours.shp',
contour_interval = 10,
base_contour = 57
)
However, the following error appears:
TypeError: WbEnvironment.contours_from_raster() got multiple values for argument 'contour_interval'
I tried using the default value, however the following error appears:
TypeError: argument 'contour_interval': must be real number, not str

This repo is not for whitebox_workflows. Please open an issue at https://github.com/jblindsay/whitebox-tools/issues


Comfyui doesn't recognize Animatediff nodes

I was following a Youtube tutorial by MDMZ on the install of AnimateDiff. I used the ComfyUI Manager to install it, but when I loaded the workflow from the tutorial, I got the following error message from the picture below. It said that "TypeError: widget[GET_CONFIG] is not a function." When I read the comments for this Youtube tutorial, other people were having the same error, but I saw no solution. So I then uninstalled AnimateDiff and reinstalled it but no change. I then went to your page, https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved and loaded your txttoimg workflow and got the following error from the picture below. It said, "When loading the graph, the following node types were not found: ADE_AnimateDiffLoaderWithContext..."

Here is the output from my CMD window:
C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --cpu --windows-standalone-build
** ComfyUI start up time: 2023-10-15 04:24:18.339773
Prestartup times for custom nodes:
0.0 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
Total VRAM 16099 MB, total RAM 16099 MB
Set vram state to: DISABLED
Device: cpu
VAE dtype: torch.float32
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
Adding extra search path checkpoints D:\AI\sd.webui (1)\webui\models/Stable-diffusion
Adding extra search path configs D:\AI\sd.webui (1)\webui\models/Stable-diffusion
Adding extra search path vae D:\AI\sd.webui (1)\webui\models/VAE
Adding extra search path loras D:\AI\sd.webui (1)\webui\models/Lora
Adding extra search path loras D:\AI\sd.webui (1)\webui\models/LyCORIS
Adding extra search path upscale_models D:\AI\sd.webui (1)\webui\models/ESRGAN
Adding extra search path upscale_models D:\AI\sd.webui (1)\webui\models/RealESRGAN
Adding extra search path upscale_models D:\AI\sd.webui (1)\webui\models/SwinIR
Adding extra search path embeddings D:\AI\sd.webui (1)\webui\embeddings
Adding extra search path hypernetworks D:\AI\sd.webui (1)\webui\models/hypernetworks
Adding extra search path controlnet D:\AI\sd.webui (1)\webui\extensions\sd-webui-controlnet\models
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
Traceback (most recent call last):
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved_init.py", line 2, in
from .animatediff.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\nodes.py", line 18, in
from .motion_module import InjectorVersion, eject_params_from_model, get_injected_mm_params, inject_params_into_model, load_motion_lora, load_motion_module
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\motion_module.py", line 11, in
from .motion_module_ad import AnimDiffMotionWrapper, has_mid_block
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\motion_module_ad.py", line 9, in
from .motion_utils import GenericMotionWrapper, InjectorVersion, BlockType, CrossAttentionMM
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\motion_utils.py", line 5, in
from comfy.ldm.modules.attention import attention_basic, attention_pytorch, attention_split, attention_sub_quad, attention_xformers, default
ImportError: cannot import name 'attention_basic' from 'comfy.ldm.modules.attention' (C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Cannot import C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: cannot import name 'attention_basic' from 'comfy.ldm.modules.attention' (C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Loading: ComfyUI-Manager (V0.34)
ComfyUI Revision: UNKNOWN (The currently installed ComfyUI is not a Git repository)
Registered sys.path: ['C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\init.py', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\custom_pycocotools', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\custom_oneformer', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\custom_mmpkg', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\custom_midas_repo', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\custom_detectron2', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\controlnet_aux', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\src', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\comfy', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages\git\ext\gitdb', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\python311.zip', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages\win32', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages\win32\lib', 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages\Pythonwin', '../..']
C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\node_wrappers\dwpose.py:26: UserWarning: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device (super slow)
warnings.warn("Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device (super slow)")
FizzleDorf Custom Nodes: Loaded
Traceback (most recent call last):
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 936, in exec_module
File "", line 1073, in get_code
File "", line 1130, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\custom_nodes\init.py'
Cannot import C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\custom_nodes module for custom nodes: [Errno 2] No such file or directory: 'C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\custom_nodes\init.py'
Import times for custom nodes:
0.0 seconds (IMPORT FAILED): C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\custom_nodes
0.0 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet
0.0 seconds (IMPORT FAILED): C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved
0.1 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite   0.1 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
0.3 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux
0.3 seconds: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_FizzNodes
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json

The widget thing I'm pretty sure is unrelated to AnimateDiff-Evolved, so I think I can't help with that.
As for the import error in AnimateDiff-Evolved, your ComfyUI is outdated - if you update ComfyUI, that should go away. Let me know what (or if any) errors remain once you update ComfyUI!

I got the similar error today just after I update the latest version of comfyui.

Traceback (most recent call last):
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-animatediff_init.py", line 2, in
from .animatediff.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-animatediff\animatediff\nodes.py", line 13, in
from .motion_module import MotionWrapper
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-animatediff\animatediff\motion_module.py", line 8, in
from comfy.ldm.modules.attention import (
ImportError: cannot import name 'CrossAttentionDoggettx' from 'comfy.ldm.modules.attention' (C:\DEV\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Cannot import C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-animatediff module for custom nodes: cannot import name 'CrossAttentionDoggettx' from 'comfy.ldm.modules.attention' (C:\DEV\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Traceback (most recent call last):
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved_init.py", line 2, in
from .animatediff.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\nodes.py", line 18, in
from .motion_module import InjectorVersion, eject_params_from_model, get_injected_mm_params, inject_params_into_model, load_motion_lora, load_motion_module
File "C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\motion_module.py", line 7, in
from comfy.ldm.modules.attention import CrossAttentionBirchSan, CrossAttentionDoggettx, CrossAttentionPytorch, FeedForward, CrossAttention, MemoryEfficientCrossAttention
ImportError: cannot import name 'CrossAttentionBirchSan' from 'comfy.ldm.modules.attention' (C:\DEV\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Cannot import C:\DEV\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: cannot import name 'CrossAttentionBirchSan' from 'comfy.ldm.modules.attention' (C:\DEV\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)

I will open an issue on comfyui.

@ultimatech-cn you have the opposite problem of the OP - you have an outdated version of AnimateDiff-Evolved, and your ComfyUI is (probably) up to date. Update AnimateDiff-Evolved (and ComfyUI for good measure), and you'll be good. Btw you can stick with just AnimateDiff-Evolved to avoid potential compatiblity/double injection issues with the other animatediff repo, although hypothetically as long as you don't use their ksampler with my loader it should be ok.

Thanks, It works well.

@ultimatech-cn you have the opposite problem of the OP - you have an outdated version of AnimateDiff-Evolved, and your ComfyUI is (probably) up to date. Update AnimateDiff-Evolved (and ComfyUI for good measure), and you'll be good. Btw you can stick with just AnimateDiff-Evolved to avoid potential compatiblity/double injection issues with the other animatediff repo, although hypothetically as long as you don't use their ksampler with my loader it should be ok.
You can reference the example workflows on my README to see how to use the loader - you can use any KSampler you'd like with it.

@JerryOver did updating ComfyUI fix your problem?

So when I tried to run update_comfyui.bat, I got this message... I am new to comfyui.
C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\update>..\python_embeded\python.exe .\update.py ..\ComfyUI
Traceback (most recent call last):
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\update\update.py", line 45, in
repo = pygit2.Repository(str(sys.argv[1]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\python_embeded\Lib\site-packages\pygit2\repository.py", line 1759, in init
path_backend = init_file_backend(path, flags)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_pygit2.GitError: Repository not found at ..\ComfyUI\
C:\Users\hinso\OneDrive\Documents\ComfyUI_windows_portable\update>pause
Press any key to continue . . .

I am having almost the same issue - first install of ComfyUI to use with Animatediff Evolved. The Animatediff Evolved does not install correctly, and gives same error when installing an example workflow "When loading the graph, the following node types were not found: ADE_AnimateDiffLoaderWithContext".
I tried updating Comfyui and Animatediff but it did not help. Did a clean reinstall but the problem persists.
Screenshot: https://i.imgur.com/Fr0spkm.png

@olegpars can you screenshot all the errors you see during install or while using?

@Kosinkadink thank you for your fast response!
Here is a screenshot: https://i.imgur.com/06YyHMW.png

@olegpars Looking at your error, it cannot load up AnimateDiff-Evolved because your ComfyUI is outdated. Your AnimateDiff-Evolved is up to date, as it is correctly looking for attention_basic, but your ComfyUI does not have it, which means it is outdated. Make sure your portable version is getting updated properly, and if it is not, you may just need to download a new portable version and try again.

Wow, thank you! I updated it through Comfy Manager and it all works now.
Strange thing is i already tried updating comfyui in the previous install, but it did not help. Now everything works just fine. Thank you again for your help!

Do you know why I'm having trouble updating? I'll put here what it said again:
C:\Users\hinso\OneDrive\Desktop\ComfyUI_windows_portable\update>..\python_embeded\python.exe .\update.py ..\ComfyUI
Traceback (most recent call last):
File "C:\Users\hinso\OneDrive\Desktop\ComfyUI_windows_portable\update\update.py", line 45, in
repo = pygit2.Repository(str(sys.argv[1]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\hinso\OneDrive\Desktop\ComfyUI_windows_portable\python_embeded\Lib\site-packages\pygit2\repository.py", line 1759, in init
path_backend = init_file_backend(path, flags)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_pygit2.GitError: Repository not found at ..\ComfyUI\
C:\Users\hinso\OneDrive\Desktop\ComfyUI_windows_portable\update>pause
Press any key to continue . . .

I had the same error, and I solved Updating ConfyUI, Thanks, It works well.