Use Jetty v9.4.7

Upgrade to newest Jetty and add support for empty HTTP header values.
Release notes Jetty: http://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00111.html

From performance numbers it seems we must skip this one. And report differences back to jetty.

I have reported the issue on our Webtide support channel.


[SMN] Add option to replace Emerald Ruin III with Ruin III

Figured I'd try my hand at implementing #41 myself, seems to work fine. Any feedback is appreciated.

Would like to see the restrictions on level and GCD actually put into the code.

I'll have to see if I can figure out how that is done for the GCD, for the level itself it won't actually matter anymore since I've made it so it doesn't override Emerald Rite (the upgraded version from level 72 onwards).

Accidentally discarded the commits by trying to resync the fork, sorry about that.

@GayPotatoEmma this has become conflicted.

@GayPotatoEmma this has become conflicted.

Will take a look tomorrow


fix: NavigationItem, better typing, story to check props

Description
NavigationItem improve typing, add stories to check tslint does not complain with expected props for button or link

@seedy should we merge this before the next release?

@seedy should we merge this before the next release?

@gndz07 I'm merging it. Thanks for asking. I think it's ok to merge it for next release, the change has a fairly low impact, compared to other changes already merged for next release.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Plugin API to add layer

Leader
User story
The user wants to add layers from a plug-in. For example, when developing a plug-in that displays the current location, or a plug-in that acquires data from an external source and displays it on a map, this is not possible because layers cannot be added. Supporting this feature would further increase what plug-ins can do on the post-publication page and encourage the development of more versatile plug-ins.
Requirements
Plugin API should expose the functionality which allows plugins to add layers

Plugins can get the list of 'extenstionId' of layers
Plugin can add layers with selected extension ID

Examples
Testing list

[ ]

About the getExtensionIds API i got some comments here. I agree and also think provide the supported types in the API document is better. I've removed this API from code.


Intellisense Suddenly Stopped Working For Standard Headers & Included Directories

Brief Issue Summary
A couple of days ago my intellisense just suddenly stopped working across all projects on one of my machines. It still works without issue on two of my other machines.
There are no compilation problems.
The error across projects is one, or both of these:
#include errors detected based on information provided by the configurationProvider setting. Squiggles are disabled for this translation unit (D:\home\Documents\workspace\test\main.cpp).C/C++(1696)
cannot open source file "iostream"C/C++(1696)

CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.89.1",
  "cmtVersion": "1.17.17",
  "configurations": [
    {
      "folder": "d:\\home\\Documents\\workspace\\test",
      "cmakeVersion": "3.27.0",
      "configured": false,
      "generator": "Visual Studio 17 2022",
      "usesPresets": false,
      "compilers": {}
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": null
    }
  ]
}

Debug Log
[main] Building folder: test clean
[expand] expanding cmake
[main] Saving open files before configure/build
[expand] expanding cmake
[expand] expanding cmake
[main] Configuring project: test
[main] Saving open files before configure/build
[expand] expanding D:/home/Documents/workspace/test
[expand] expanding ${workspaceFolder}/build
[driver] Start configure
[driver] Running pre-configure checks and steps
[expand] expanding --no-warn-unused-cli
[expand] expanding -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE
[expand] expanding D:/home/Documents/workspace/test
[expand] expanding ${workspaceFolder}/build
[cmakefileapi-driver] Configuring using kit
[cmakefileapi-driver] Invoking CMake D:\Program Files\CMake\bin\cmake.EXE with arguments ["--no-warn-unused-cli","-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE","-SD:/home/Documents/workspace/test","-Bd:/home/Documents/workspace/test/build","-G","Visual Studio 17 2022","-T","host=x64","-A","x64"]
[proc] Executing command: "D:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -SD:/home/Documents/workspace/test -Bd:/home/Documents/workspace/test/build -G "Visual Studio 17 2022" -T host=x64 -A x64
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","APPDATA":"C:\\Users\\alexm\\AppData\\Roaming","APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL":"1","CHROME_CRASHPAD_PIPE_NAME":"\\\\.\\pipe\\crashpad_8100_YFNGTIPOYHXUPYKD","COMPUTERNAME":"DESKTOP-AT7I1EQ","CUDA_PATH":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","CUDA_PATH_V11_7":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","FPS_BROWSER_APP_PROFILE_STRING":"Internet Explorer","FPS_BROWSER_USER_PROFILE_STRING":"Default","GIT_INSTALL_ROOT":"C:\\Users\\alexm\\scoop\\apps\\git\\current","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\alexm","LOCALAPPDATA":"C:\\Users\\alexm\\AppData\\Local","LOGONSERVER":"\\\\DESKTOP-AT7I1EQ","NUMBER_OF_PROCESSORS":"16","NVTOOLSEXT_PATH":"C:\\Program Files\\NVIDIA Corporation\\NvToolsExt\\","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","OculusBase":"D:\\Oculus\\","OneDrive":"C:\\Users\\alexm\\OneDrive","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_INSTALLER":"ws","POSH_THEMES_PATH":"C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"AMD64 Family 25 Model 33 Stepping 2, AuthenticAMD","PROCESSOR_LEVEL":"25","PROCESSOR_REVISION":"2102","PSModulePath":"C:\\Users\\alexm\\scoop\\modules;C:\\Users\\alexm\\Documents\\WindowsPowerShell\\Modules","PUBLIC":"C:\\Users\\Public","Path":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\bin;C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\libnvvp;D:\\Oculus\\Support\\oculus-runtime;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\NVIDIA Corporation\\NVIDIA NvDLISR;C:\\Program Files\\dotnet\\;D:\\Program Files\\Git\\cmd;C:\\Program Files\\NVIDIA Corporation\\Nsight Compute 2022.2.0\\;C:\\Program Files (x86)\\NVIDIA Corporation\\PhysX\\Common;D:\\Program Files\\CMake\\bin;C:\\Users\\alexm\\scoop\\apps\\mpv\\current;C:\\Users\\alexm\\scoop\\apps\\gsudo\\current;C:\\Users\\alexm\\.cargo\\bin;C:\\Users\\alexm\\scoop\\shims;C:\\Users\\alexm\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\alexm\\.dotnet\\tools;C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code\\bin","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","TMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","USERDOMAIN":"DESKTOP-AT7I1EQ","USERDOMAIN_ROAMINGPROFILE":"DESKTOP-AT7I1EQ","USERNAME":"alexm","USERPROFILE":"C:\\Users\\alexm","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\alexm\\AppData\\Roaming\\Code\\CachedData\\dc96b837cf6bb4af9cd736aa3af08cf8279f7685","VSCODE_CRASH_REPORTER_PROCESS_TYPE":"extensionHost","VSCODE_CWD":"C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\314a266c-1.89.1-main-sock","VSCODE_L10N_BUNDLE_LOCATION":"","VSCODE_NLS_CONFIG":"{\"locale\":\"en-us\",\"osLocale\":\"en-gb\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"8100","windir":"C:\\WINDOWS"}
[cmake] Not searching for unused variables given on the command line.
[cmake] -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
[cmake] -- Configuring done (0.0s)
[cmake] -- Generating done (0.0s)
[cmake] -- Build files have been written to: D:/home/Documents/workspace/test/build
[cmakefileapi-parser] Read reply folder: d:\home\Documents\workspace\test\build\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-e0f330c2cc55407660a2.json","cmakeFiles-v1-90bd3c1b4326a1e67d16.json","codemodel-v2-07d580433e355fb35a33.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2024-05-20T10-23-09-0490.json","target-ALL_BUILD-Debug-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-MinSizeRel-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-Release-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-RelWithDebInfo-1d799d7c8ad4f3dfd0ce.json","target-cpp_calculator-Debug-5fab62b26c5e54e00c72.json","target-cpp_calculator-MinSizeRel-9d5fd37290e004d750ce.json","target-cpp_calculator-Release-721c392063aa8aa10718.json","target-cpp_calculator-RelWithDebInfo-78587a903ab309c09417.json","target-ZERO_CHECK-Debug-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-MinSizeRel-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-Release-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-RelWithDebInfo-e762b46fe473d63bdeb8.json","toolchains-v1-f37fa449fbe2cdf34182.json"]
[expand] expanding cmake
[expand] expanding cmake
[cache] Reading CMake cache file d:/home/Documents/workspace/test/build/CMakeCache.txt
[cache] Parsing CMake cache string
[expand] expanding cmake
[expand] expanding cmake
[expand] expanding cmake
[build] Starting build
[driver] Start build clean
[expand] expanding --build
[expand] expanding d:/home/Documents/workspace/test/build
[expand] expanding --config
[expand] expanding Debug
[expand] expanding --target
[expand] expanding clean
[expand] expanding -j
[expand] expanding 18
[expand] expanding --
[proc] Executing command: chcp
[proc] Executing command: "D:\Program Files\CMake\bin\cmake.EXE" --build d:/home/Documents/workspace/test/build --config Debug --target clean -j 18 --
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","APPDATA":"C:\\Users\\alexm\\AppData\\Roaming","APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL":"1","CHROME_CRASHPAD_PIPE_NAME":"\\\\.\\pipe\\crashpad_8100_YFNGTIPOYHXUPYKD","COMPUTERNAME":"DESKTOP-AT7I1EQ","CUDA_PATH":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","CUDA_PATH_V11_7":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","FPS_BROWSER_APP_PROFILE_STRING":"Internet Explorer","FPS_BROWSER_USER_PROFILE_STRING":"Default","GIT_INSTALL_ROOT":"C:\\Users\\alexm\\scoop\\apps\\git\\current","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\alexm","LOCALAPPDATA":"C:\\Users\\alexm\\AppData\\Local","LOGONSERVER":"\\\\DESKTOP-AT7I1EQ","NUMBER_OF_PROCESSORS":"16","NVTOOLSEXT_PATH":"C:\\Program Files\\NVIDIA Corporation\\NvToolsExt\\","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","OculusBase":"D:\\Oculus\\","OneDrive":"C:\\Users\\alexm\\OneDrive","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_INSTALLER":"ws","POSH_THEMES_PATH":"C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"AMD64 Family 25 Model 33 Stepping 2, AuthenticAMD","PROCESSOR_LEVEL":"25","PROCESSOR_REVISION":"2102","PSModulePath":"C:\\Users\\alexm\\scoop\\modules;C:\\Users\\alexm\\Documents\\WindowsPowerShell\\Modules","PUBLIC":"C:\\Users\\Public","Path":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\bin;C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\libnvvp;D:\\Oculus\\Support\\oculus-runtime;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\NVIDIA Corporation\\NVIDIA NvDLISR;C:\\Program Files\\dotnet\\;D:\\Program Files\\Git\\cmd;C:\\Program Files\\NVIDIA Corporation\\Nsight Compute 2022.2.0\\;C:\\Program Files (x86)\\NVIDIA Corporation\\PhysX\\Common;D:\\Program Files\\CMake\\bin;C:\\Users\\alexm\\scoop\\apps\\mpv\\current;C:\\Users\\alexm\\scoop\\apps\\gsudo\\current;C:\\Users\\alexm\\.cargo\\bin;C:\\Users\\alexm\\scoop\\shims;C:\\Users\\alexm\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\alexm\\.dotnet\\tools;C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code\\bin","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","TMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","USERDOMAIN":"DESKTOP-AT7I1EQ","USERDOMAIN_ROAMINGPROFILE":"DESKTOP-AT7I1EQ","USERNAME":"alexm","USERPROFILE":"C:\\Users\\alexm","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\alexm\\AppData\\Roaming\\Code\\CachedData\\dc96b837cf6bb4af9cd736aa3af08cf8279f7685","VSCODE_CRASH_REPORTER_PROCESS_TYPE":"extensionHost","VSCODE_CWD":"C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\314a266c-1.89.1-main-sock","VSCODE_L10N_BUNDLE_LOCATION":"","VSCODE_NLS_CONFIG":"{\"locale\":\"en-us\",\"osLocale\":\"en-gb\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"8100","windir":"C:\\WINDOWS","NINJA_STATUS":"[%s/%t %p :: %e] "}
[build] MSBuild version 17.9.8+b34f75857 for .NET Framework
[build]
[driver] Build completed: 00:00:00.352
[cmakefileapi-parser] Read reply folder: d:\home\Documents\workspace\test\build\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-e0f330c2cc55407660a2.json","cmakeFiles-v1-90bd3c1b4326a1e67d16.json","codemodel-v2-07d580433e355fb35a33.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2024-05-20T10-23-09-0490.json","target-ALL_BUILD-Debug-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-MinSizeRel-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-Release-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-RelWithDebInfo-1d799d7c8ad4f3dfd0ce.json","target-cpp_calculator-Debug-5fab62b26c5e54e00c72.json","target-cpp_calculator-MinSizeRel-9d5fd37290e004d750ce.json","target-cpp_calculator-Release-721c392063aa8aa10718.json","target-cpp_calculator-RelWithDebInfo-78587a903ab309c09417.json","target-ZERO_CHECK-Debug-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-MinSizeRel-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-Release-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-RelWithDebInfo-e762b46fe473d63bdeb8.json","toolchains-v1-f37fa449fbe2cdf34182.json"]
[expand] expanding cmake
[expand] expanding D:/home/Documents/workspace/test
[expand] expanding ${workspaceFolder}/build
[build] Build finished with exit code 0
[expand] expanding cmake
[cache] Reading CMake cache file d:/home/Documents/workspace/test/build/CMakeCache.txt
[cache] Parsing CMake cache string
[expand] expanding cmake
[main] Building folder: test
[expand] expanding cmake
[main] Saving open files before configure/build
[expand] expanding cmake
[expand] expanding cmake
[expand] expanding cmake
[build] Starting build
[driver] Start build ALL_BUILD
[expand] expanding --build
[expand] expanding d:/home/Documents/workspace/test/build
[expand] expanding --config
[expand] expanding Debug
[expand] expanding --target
[expand] expanding ALL_BUILD
[expand] expanding -j
[expand] expanding 18
[expand] expanding --
[proc] Executing command: "D:\Program Files\CMake\bin\cmake.EXE" --build d:/home/Documents/workspace/test/build --config Debug --target ALL_BUILD -j 18 --
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","APPDATA":"C:\\Users\\alexm\\AppData\\Roaming","APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL":"1","CHROME_CRASHPAD_PIPE_NAME":"\\\\.\\pipe\\crashpad_8100_YFNGTIPOYHXUPYKD","COMPUTERNAME":"DESKTOP-AT7I1EQ","CUDA_PATH":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","CUDA_PATH_V11_7":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7","ComSpec":"C:\\WINDOWS\\system32\\cmd.exe","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","ELECTRON_RUN_AS_NODE":"1","FPS_BROWSER_APP_PROFILE_STRING":"Internet Explorer","FPS_BROWSER_USER_PROFILE_STRING":"Default","GIT_INSTALL_ROOT":"C:\\Users\\alexm\\scoop\\apps\\git\\current","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\alexm","LOCALAPPDATA":"C:\\Users\\alexm\\AppData\\Local","LOGONSERVER":"\\\\DESKTOP-AT7I1EQ","NUMBER_OF_PROCESSORS":"16","NVTOOLSEXT_PATH":"C:\\Program Files\\NVIDIA Corporation\\NvToolsExt\\","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","OculusBase":"D:\\Oculus\\","OneDrive":"C:\\Users\\alexm\\OneDrive","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","POSH_INSTALLER":"ws","POSH_THEMES_PATH":"C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\themes","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"AMD64 Family 25 Model 33 Stepping 2, AuthenticAMD","PROCESSOR_LEVEL":"25","PROCESSOR_REVISION":"2102","PSModulePath":"C:\\Users\\alexm\\scoop\\modules;C:\\Users\\alexm\\Documents\\WindowsPowerShell\\Modules","PUBLIC":"C:\\Users\\Public","Path":"C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\bin;C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.7\\libnvvp;D:\\Oculus\\Support\\oculus-runtime;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\NVIDIA Corporation\\NVIDIA NvDLISR;C:\\Program Files\\dotnet\\;D:\\Program Files\\Git\\cmd;C:\\Program Files\\NVIDIA Corporation\\Nsight Compute 2022.2.0\\;C:\\Program Files (x86)\\NVIDIA Corporation\\PhysX\\Common;D:\\Program Files\\CMake\\bin;C:\\Users\\alexm\\scoop\\apps\\mpv\\current;C:\\Users\\alexm\\scoop\\apps\\gsudo\\current;C:\\Users\\alexm\\.cargo\\bin;C:\\Users\\alexm\\scoop\\shims;C:\\Users\\alexm\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Users\\alexm\\.dotnet\\tools;C:\\Users\\alexm\\AppData\\Local\\Programs\\oh-my-posh\\bin;C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code\\bin","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","SystemDrive":"C:","SystemRoot":"C:\\WINDOWS","TEMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","TMP":"C:\\Users\\alexm\\AppData\\Local\\Temp","USERDOMAIN":"DESKTOP-AT7I1EQ","USERDOMAIN_ROAMINGPROFILE":"DESKTOP-AT7I1EQ","USERNAME":"alexm","USERPROFILE":"C:\\Users\\alexm","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\alexm\\AppData\\Roaming\\Code\\CachedData\\dc96b837cf6bb4af9cd736aa3af08cf8279f7685","VSCODE_CRASH_REPORTER_PROCESS_TYPE":"extensionHost","VSCODE_CWD":"C:\\Users\\alexm\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\314a266c-1.89.1-main-sock","VSCODE_L10N_BUNDLE_LOCATION":"","VSCODE_NLS_CONFIG":"{\"locale\":\"en-us\",\"osLocale\":\"en-gb\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"8100","windir":"C:\\WINDOWS","NINJA_STATUS":"[%s/%t %p :: %e] "}
[build] MSBuild version 17.9.8+b34f75857 for .NET Framework
[build]
[build]   1>Checking Build System
[build]   Building Custom Rule D:/home/Documents/workspace/test/CMakeLists.txt
[build]   main.cpp
[build]   cpp_calculator.vcxproj -> D:\home\Documents\workspace\test\build\Debug\cpp_calculator.exe
[build]   Building Custom Rule D:/home/Documents/workspace/test/CMakeLists.txt
[driver] Build completed: 00:00:01.282
[cmakefileapi-parser] Read reply folder: d:\home\Documents\workspace\test\build\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-e0f330c2cc55407660a2.json","cmakeFiles-v1-90bd3c1b4326a1e67d16.json","codemodel-v2-07d580433e355fb35a33.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2024-05-20T10-23-09-0490.json","target-ALL_BUILD-Debug-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-MinSizeRel-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-Release-1d799d7c8ad4f3dfd0ce.json","target-ALL_BUILD-RelWithDebInfo-1d799d7c8ad4f3dfd0ce.json","target-cpp_calculator-Debug-5fab62b26c5e54e00c72.json","target-cpp_calculator-MinSizeRel-9d5fd37290e004d750ce.json","target-cpp_calculator-Release-721c392063aa8aa10718.json","target-cpp_calculator-RelWithDebInfo-78587a903ab309c09417.json","target-ZERO_CHECK-Debug-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-MinSizeRel-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-Release-e762b46fe473d63bdeb8.json","target-ZERO_CHECK-RelWithDebInfo-e762b46fe473d63bdeb8.json","toolchains-v1-f37fa449fbe2cdf34182.json"]
[expand] expanding cmake
[expand] expanding D:/home/Documents/workspace/test
[expand] expanding ${workspaceFolder}/build
[build] Build finished with exit code 0
[expand] expanding cmake
[cache] Reading CMake cache file d:/home/Documents/workspace/test/build/CMakeCache.txt
[cache] Parsing CMake cache string
[expand] expanding cmake
[extension] [9683] cmake.cleanRebuild finished (returned 0)

Additional Information
I've reinstalled VS Build Tools, tried Visual Studio Community Edition, reinstalled both the C/C++ plugins and cmake-tools, with not much change in result. It does seem to pick up the standard library headers when I'm using the base C/C++ intellisense rather than the cmake-tools one.
The issue persists with the most basic of cmake projects, with just a "hello, world" main.cpp added to an executable:
CMakeLists.txt
cmake_minimum_required(VERSION 3.6)
project(hello_world CXX)

add_executable(hello_world main.cpp)
target_include_directories(hello_world PRIVATE ".")

main.cpp
#include <iostream>
int main() {
    std::cout << "hello, world" << std::endl;
}

Seems to work when launching through the Developer command prompt, but I've not previously launched it through that and it's worked fine up until recently.

@AlexMainstone Thank you for your github issue! We were wondering if your problem is currently recurring. If it still recurs, could you provide us with the following information?

Could you provide us with your reproduction file?
Is your problem occurring after build this project?

Use the extension "C/C++" with version 19.9 will fix this

@AlexMainstone What version of C/C++ are you currently using? If the problem is still reproducible, could you switch the C/C++ version to v1.19.9 and try again to see if the problem is reproducible?
Methods for switching versions

Reverting to the previous version seemed to work, thank you.
Is this an issue that needs to be brought up in the C/C++ repo? Is anyone aware if this is now intended behaviour for this extension?


Use componentconfig api

In https://github.com/kubernetes-sigs/descheduler/pull/380, we deprecated some component-level flags in favor of new policy config fields. Though, looking at our ComponentConfig API I think adding them to policy might have been a duplicate.
However we don't seem to be using the ComponentConfig API anywhere now. We should determine a plan for this api and decide if we want to move ahead with using it or get rid of it (before we add any more component-level fields to the Policy api, if that's what we want to do)

Correction, we do use this API internally however I'm proposing that we expose it for external configuration as well
/cc @seanmalloy @ingvagabund
@ravisantoshgudimetla or @aveshagarwal, could either of you provide some insight as to the original plan for the componentconfig api and if it was meant to be exposed?

could either of you provide some insight as to the original plan for the componentconfig api and if it was meant to be exposed?

As I recall, by the time the descheduler was delivered to this world, component config was the default way of configuring new components. The component config got serialized as a json/yaml and served through a config map that got attached to a container as a volume and passed to the component through --config (or its variation) flag.
Checking history of cmd/descheduler/app/options/ I don't see CC has ever been passed to the descheduler through a flag.

In #380, we deprecated some component-level flags in favor of new policy config fields. Though, looking at our ComponentConfig API I think adding them to policy might have been a duplicate.

DeschedulerConfiguration type's fields are currently used as value holder for various descheduler options. Thus the reason why those fields are duplicated. Given all three --node-selector, --max-pods-to-evict-per-node and evict-local-storage-pods are deprecated, NodeSelector, MaxNoOfPodsToEvictPerNode and EvictLocalStoragePods fields are deprecated as well and will get removed eventually. So the duplication is only temporary for 12 months or 2 releases (whichever is longer) since the deprecation was announced.

However we don't seem to be using the ComponentConfig API anywhere now. We should determine a plan for this api and decide if we want to move ahead with using it or get rid of it (before we add any more component-level fields to the Policy api, if that's what we want to do)

Depends on which component-level field is to be added. Anything related to strategies goes to the Policy API, everything else to CLI options/CC fields. Versioned Component Configuration Files gives good reasons to prefer CC over flags.
+1 for keeping CC and adding new --config option.

Given all three --node-selector, --max-pods-to-evict-per-node and evict-local-storage-pods are deprecated, NodeSelector, MaxNoOfPodsToEvictPerNode and EvictLocalStoragePods fields are deprecated as well and will get removed eventually.

Those flags are deprecated, but the configuration options shouldn't be, right? So those would be configurable by CC

In other words, we deprecated the ability to pass node-selector as a flag but we aren't trying to get rid of that option entirely

Those flags are deprecated, but the configuration options shouldn't be, right? So those would be configurable by CC

In other words, we deprecated the ability to pass node-selector as a flag but we aren't trying to get rid of that option entirely

That is correct

Ok, just wanted to clarify. Yeah in that case the duplication isn't a problem, thanks for clearing that up. I don't see any reason not to revive CC then

+1 for keeping CC and adding new --config option.

I'm good with this too.

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale
This came up again in some other PRs like https://github.com/kubernetes-sigs/descheduler/pull/662
We should decide what to do with the CC types. At this point, they are just redundant for all the config values we have in Policy.
I think you could make a case that the CC should be just component-specific settings while Policy has the settings for individual strategies. But is that a functional improvement and is the change worth it for users?
Perhaps we should look at just removing the CC types altogether to clean up the code. Any thoughts either way?

If we drop the CC code we can always put it back once it becomes relevant. We might eventually promote the policy into the CC?


Add a license to the repository

I recently came across your project QGSS2022 and I noticed that the repository github.com/marcocecca00/QGSS2022 currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Thank you for you advice!

Thanks


Change description of Save function #126

Signed-off-by: John M. Horan<EMAIL_ADDRESS>

LGTM!


Static files/directory config for appsettings.json

Add support for configuring static files/directories with appsettings.json just like how nginx allows it.
The key can be default Address or it could be named Path to seperate it.
Nginx also allows to specify an index file like index index.html; this could also be used as another value "Index": "index.html"
"ReverseProxy": {
    "Routes": [
      {
        "RouteId": "route1",
        "ClusterId": "cluster1",
        "Match": {
          "Path": "{**catch-all}"
        }
      }
    ],
    "Clusters": {
      "cluster1": {
        "Destinations": {
          "cluster1/destination1": {
            "Address": "/linux/path/here/"
          }
        }
      }
    }
  }

Duplicate of #187
This is tangential to YARP's primarily concern as a library for routing to external sources. We do consider static file config important in the pre-built exe scenario that would be comparable to nginx.
I don't envision this as being part of the cluster config, none of the cluster settings make sense for static assets. I expect it would use a different config section entirely.

What is missing here (possibly more from asp.net than Yarp) is a standard config section for configuring static files. In the same way that you add the config provider to Yarp, it would nice to be able to specify a config section that would map to a StaticFileOptions instance enabling the configuration of folders, headers, auth, content types etc from config rather than code.
Not that difficult to write, but probably not a high priority for Yarp v1.

Duplicate of #187


custom data files in aspnet

I have a somedata.dat file I need in my app and use File.OpenText("data/somedata.dat") file to access it.  On Windows the "data" directory is expected in the wwwroot/ directory but on linux it's expected to be in the approot/ directory.  I assume the former is correct but is this a bug on linux or do I need to access the file in a different manner?
using: rc1-final

This statement is confusing:

On Windows the "data" directory is expected in the wwwroot/ directory but on linux it's expected to be in the approot/ directory.

What do you mean expected to be?
To help the situation, can you make a sample application and push it to github with instructions on what you did? That way we can both run the application without too many assumptions.

I mean File.OpenText("data/somedata.dat") tries to look for it in wwwroot/data/somedata.dat when running under windows but approot/data/somedata.data when running the same code under linux.
I'll work on a sample.

To further clarify my less then stellar (initial) description.

I create an empty mvc app in visual studio on Windows
add the following lines to startup.cs -- Configure() method
try
{
System.IO.File.OpenText("data/somedata.txt");
}
catch(Exception ex)
{
Console.WriteLine(ex.Message);
}
Created a folder in wwwroot called data
Created a txt file in wwwroot/data called somedata.txt with some added text
Ran app IN visual studio w/o incident
Drop to DOS
Run dnu publish
go to myapp/src
Run dnu restore
go to src/myapp/bin/approot (where project.json is)
run dnx web
Receive exception that bin/output/approot/data/somedata.txt cannot be found

To me:

There's a mismatch btwn visual studio layout and "publish" layout (there is no "approot" in vs)
While I get that running dnx web from approot will set approot to be the "running" directory, aspnet must know enough to pull the js/css/image from wwwroot?

Invariably, 1) where is the correct place to store local files that will be accessed at runtime by my app and 2) what's the proper procedure to access them via pathing.

Use IApplicationEnvironment.ApplicationBasePath to find config files in the project root. The inconsistency between File.Open is basically relying on the working directory to be the same between the 2 OS's and it just isn't. When running under IIS and the platform handler the working DIR is wwwroot. So it's better to use physical paths rooted on ApplicatonBase rather than relative paths

cool tx


Best Practices Integration

Should we integrate this?

I dont see why not, but I would say it is a bit early for that since we dont really have a website yet and bunch of other things


Support for Dual-Arm Robot URDFs and Automatic Task Generation in RoboGen

Hi~
I am exploring the possibility of integrating dual-arm robot configurations. Specifically, I am interested in whether it is possible to import URDF files for dual-arm robots and use RoboGen to automatically generate tasks and demonstrations? Could you provide guidance on how to achieve this with RoboGen?

Hi,
Thanks for your interest in our project.
It should be easy to import two robotic arms; I think you just need to import two arms in sim.py. These are the lines where we load the robot: https://github.com/Xingyu-Lin/softagent_rpad/blob/navin_dev/dressing_motion/curl/train_perturb.py#L257-L259. I think you just need to load another arm here.
For generating tasks with dual arms, you might need to change the task proposal prompt here: https://github.com/Genesis-Embodied-AI/RoboGen/blob/main/gpt_4/prompts/prompt_manipulation.py#L10. You can modify the prompt to tell GPT-4 that there are two arms in the scene.
For demonstration generation:
For the motion planning part, you probably need to modify the motion planning utils such that it can plan path for two robots: https://github.com/Genesis-Embodied-AI/RoboGen/blob/main/manipulation/motion_planning_utils.py#L8-L18. I think just adding another instance of PbOMPLRobot for the second robotic arm should work.
For the RL part, I think you probably need to modify the observation and action space to support both arms. The observation and action function are defined here in sim.py: https://github.com/Genesis-Embodied-AI/RoboGen/blob/main/manipulation/sim.py#L910, and https://github.com/Genesis-Embodied-AI/RoboGen/blob/main/manipulation/sim.py#L750


Release azure-cli-configure 0.1.1b3

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

GitHub release created. https://github.com/Azure/azure-cli/releases.


Custom query string for list is always removed.

I am trying to do custom pagination according to the real server spec, so I need to get query string from request to transform the response in router.render like this.
GET /posts?limit=10&offset=20
router.render = function (req, res) {
  console.log(req.query); // got empty object {} ???
  res.json({
     data: res.locals.data.slice(req.query.offset, req.query.offset + req.query.limit),
  });
}

Unfortunately, json-server removes all query that is not in the scope. So I cannot use query limit and offset. How can I make it work?

I was able to access query strings using req._parsedOriginalUrl.query

Just an additional note, you will need to convert the query string to a number.

@ahmadalfy Oh nice, I can finally access the custom query although they are just a raw string not an object. Thanks a lot. 😄


catppuccin-gtk: 0.7.2 -> 0.7.3

Changelog: https://github.com/catppuccin/gtk/releases/tag/v0.7.3
Diff: https://github.com/catppuccin/gtk/compare/v0.7.2...v0.7.3
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks reasonable since colloid has been updated in Nixpkgs, won't break anything in GNOME 45


ObjectInitializer doesn't provide functionality to create a default instance for Objects which support multiple instances

It would be good if there is a method to create instances of objects which support multiple instances  in oma specs by default.

Hello,
I'm not sure to understand what you mean by "default instance" but the ObjectInitializer.setInstancesForObject() method allows you to provide multiple instances for a given object ID.
Is it what you are looking for?

I tried the 'setInstanceForObject()' method. It is being correctly added to the 'instances' hash map in the initializer. But after that how do I create 'ObjectEnabler's ? When I use the 'create()' method, it calls the 'createNodeEnabler()' method. Inside that method, an 'instances' hash map is created and it will be empty when the ObjectEnabler for objects supporting multiple instances is created.

Hi @msangoi ,
I'm very sorry for posting this issue. I was using old JAR files from leshan-tuto repository. That was causing the problem. The new code works perfectly. Closing the issue. Sorry for bothering.


Add minimum withdrawal amount admin setting

This will prevent a malicious user from sending multiple single-satoshi withdrawals to fill up the database.
Just check the payment amount from the decoded pay request here: https://github.com/yzernik/squeakroad/blob/e5edf72abeb2c6bf6093b23c3c23777a161504d3/src/withdraw.rs#L111

Nevermind. There is already a limit on number of withdrawals per user per day.


update dev dependencies and add prepublish command

refs #1092
Running npm publish will build the dist folder and publish it.

Thanks! I'll republish right away.


Feature/hghk 172 implement data model for permissions on items

Fixes #172
Implements a permission model for items
PR checklist

[x] dev-branch has been merged into local branch to resolve conflicts
[x] tests and linter have passed AFTER local merge
[x] localization is supported (Guide)
[ ] another dev reviewed and approved
if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo) not applicable, since it contains no user facing changes

Todo for this branch:

[ ] Fix item controller and views because item.owner got deleted. This might cascade to the notification system.
[ ] Write proper migrations that actually migrate the database instead of just deleting the old columns
[ ] Add proper tests for the new data model

At the moment, this PR ensures that existing functionality does not break. However, there are many missing features concerning groups as item owners, for example showing and setting group owners as well as related stuff (e.g. notifications).
Nevertheless, these features should not be part if this PR, since we do not know the specific implementation details and requirements and this PR should only add the data model.

Is there a Review needed by a PO?

We don't think so, see the PR description

At the moment, this PR ensures that existing functionality does not break. However, there are many missing features concerning groups as item owners, for example showing and setting group owners as well as related stuff (e.g. notifications).
Nevertheless, these features should not be part if this PR, since we do not know the specific implementation details and requirements and this PR should only add the data model.

The item editing form does not appear to work properly. The current owner is not displayed when I open the edit page. However, I can set a new owner and that is persisted.


WC v2: QR code is not recognised when copy/past from buffer is used

Steps:

open WC v2
open https://react-app.walletconnect.com/ in another tab
select the QR code and copy it to buffer
go to the WC safe app and passt it
Current result: The QR code is not recognised and connection is not established
Expected result: copy/past from buffer should work for the QR code in the WC v2

I couldn't reproduce this


[Title Bar Customization] Should "caption_controls_overlay" be swapped for a new "display" mode?

Originally discussed in #202, but breaking it out into it's own issue.
@kenchris:

Have you considered making it another display mode? Like "standalone-captions-controls" or similar? Now there is this big overlap with display

I know that might make it turn into display: "browser" in UAs that don't understand it, but if there is agreement, adding support to existing browsers to map "standalone-captions-controls" to "standalone" is just a few lines or code - so they don't need to commit to actually implement the whole feature

Description
Add a new "display" mode: "standalone-controls-overlay".
The new fallback display mode order could be either:

Option 1
Option 2

fullscreen or standalone-controls-overlay
fullscreen

standalone
standalone-controls-overlay

minimal-ui
standalone

browser
minimal-ui

browser

Option 1: prevents an unexpected fallback from fullscreen to standalone-caption-controls when developing a web app targeted at both mobile (supports fullscreen) and desktop (does not surpport fullscreen)
Option 2: linear fallback pattern starting from the least UA-controlled UI and flowing down to most UA-controlled UI
Pros/Cons
Pros:

Cleaner than adding a new member to the manifest that has overlap with "display" and is only ever enabled for one display mode.

Cons:

The possible fallback order is either confusing (solution 1), or may have unexpected consequences (solution 2)

Alternatives
One alternative approach would be to add a new "display_modifiers" member which accepts a list of modifiers which work in conjunction with specific "display" modes.
In the example below, if the PWA were installed on a mobile device that supports fullscreen mode, then the PWA would also enable the fictional "fullscreen-sample-modifier". If it were instead installed on a desktop device, then it would be installed in "standalone" mode, and the "standalone-controls-overlay" modifier would be enabled, which here implies that there would be a small caption controls overlay in the top corner in lieu of a full-width title bar.
{
  "display": "fullscreen",
  "display_modifiers": [
    "standalone-controls-overlay",
    "fullscreen-sample-modifier"
  ]
}

This approach is extensible and allows new modifications to be added to each of the display modes without having to alter the fallback order.

@aarongustafson It would be great to get your thoughts on the fallback order and the alternative "display-modifiers" option

I’m kind of intrigued by the display modifiers concept, to be honest. Although I would prefer to see something like this:
{
  "display": "standalone",
  "display_modifiers": {
    "titlebar": false
  }
}

I could see this allowing devs to (potentially) make other modest UI tweaks as well. Like removing the refresh button from Minimal UI:
{
  "display": "minimal-ui",
  "display_modifiers": {
    "refresh-button": false
  }
}

Or explicitly removing the back button from standalone:
{
  "display": "standalone",
  "display_modifiers": {
    "back-button": false
  }
}

You could also use it to (potentially) customize the browser instance:
{
  "display": "browser",
  "display_modifiers": {
    "home-button": false,
    "refresh-button": false,
    "favorites-bar": false
  }
}

If we decided to go down this path, it would require an additional explainer that defines the various keys and the matrix of when & where they would be applicable (as well as which controls should never be disabled, probably on a per-display mode basis).

This seems very desktop specific... I wonder how it will translate to mobile; although I get the modifiers would just be hints. I don't think we want the ability to take things away from users though (as it's the user's UI, not the websites) - the Web app should maybe be able to request things:
"ui_controls": ["nav-buttons"],

This seems very desktop specific... I wonder how it will translate to mobile; although I get the modifiers would just be hints.

Those examples are pretty desktop-focused, but this could be used for any platform. E.g. maybe developers want to be able to use fullscreen on phones without notches, but standalone on phones with notches. Then they don't have to set safe-area-insets on each of the pages in their app, and normal system icons (battery, signal, etc.) can fill that top area. For this we can add a "fallback-to-standalone-if-notch" display modifier (the name isn't great, but it's just an example).

I don't think we want the ability to take things away from users though (as it's the user's UI, not the websites) - the Web app should maybe be able to request things

When a developer sets the display mode of their app, they're already choosing to take controls away from the user. By setting "display": standalone" on desktop, you "take away" the back and refresh buttons from the user relative to "minimal-ui".
However, we could achieve the same result using your "request" approach by requesting to add UI components instead of disabling them. So instead of disabling the back button on minimal-ui
"display": "minimal-ui",
"display-modifiers": {
  "back-button": "false"
}

you could enable the refresh button with standalone
"display": "standalone",
"display-modifiers": [ "refresh-button" ]

I've updated the explainer to use the "request things" approach:
"display": "standalone",
"display-modifiers": [ "caption-controls-overlay" ]

I'll leave this issue open for a bit to leave room for more discussion/feedback

Thanks @amandabaker. We probably want to abstract out a general set of controls that are a bit abstract. We've heard that navigation control is pretty important, obviously (but it may be that UAs just start providing those by default... or we modify the Manifest spec to suggest always including those for standalone + minimal UI).
Sorry for being thick, but I'm still not sure what "caption_controls_overlay" are? 🙈 Could someone provide a screenshot with an arrow or something so I can understand what those are?

@marcoscaceres  The "caption-controls-overlay" is the black overlay in the top right corner which includes the caption controls. It's similar to standalone, except it cuts off the page title so that the developer can draw in that space instead (hence the display modifier that builds upon standalone). You can read more in this section the explainer.

Like Aaron said above, this will need its own explainer, so I'll get that out in a bit. But for the scope of this Title Bar Customization explainer, I'm just going to leave the one use case we have defined here.

Thanks for the clarification. I'm trying to think if there is an equivalent of this on MacOS or other OS... trying to figure out if it's a generalizable thing.

@marcoscaceres The nomenclature doesn't match, but the concept is the same. MacOS calls them “window controls.”

Hello, I've been meaning to reply on this for a long time. I think this conversation should move over to Manifest because it's a much wider issue than just title bar customization. This is something we've had numerous discussions on over the years, but for some reason, I don't think there's actually a Manifest issue dedicated to it. So, I just made one: w3c/manifest#856
I really don't want us to add more display modes. This is very similar to my tabbed application mode proposal, where I also initially proposed your Option 1 (inserting a new display mode that falls back to standalone, which makes the fallback list into a DAG). This isn't really workable as we add more of these features, because they are unable to be mixed and matched.
What if I want a tabbed application mode where I can also control the caption controls? What if I want caption controls with minimal_ui? The linear, or even DAG, fallback chain, makes it very inflexible. This is not the extensible web.
So I am very much in favour of more flexible individual controls. The display_modifiers concept seems good to me and is similar to what I've proposed in the past (but with a bit of a different angle, which is that it's changing the existing semantics of display; the problem being they have no well-defined semantics). I've mentioned @aarongustafson 's display_modifiers in my big post on w3c/manifest#856. Let's continue this discussion there.
I was coincidentally talking to @dmurph about this today and I think it's something he wants to look into (we kind of need to resolve this before we spec title bar customization or tabbed application mode).

Transferring discussion to the new WICG repo: https://github.com/WICG/window-controls-overlay/issues/4


Adding eventListener for custom event from gnav.init() and match the …

…cta href if it is existed.
Jira ticket: MWPW-106285
Testing URL:
Main: https://main--business-website--adobe.hlx3.page/drafts/cmillar/gnav/
This change: https://gnav-banner-match--business-website--adobe.hlx3.page/drafts/cmillar/gnav/
You should see the footer banner CTA's URL is matching with Gnav's one.

I also created a PR for adobecom/gnav: https://github.com/adobecom/gnav/pull/9.

Fix the linting errors (either use the console abstraction or use an eslint-diable), otherwise 👍 .

That console log is from scripts/delayed.js which isn't even part of this PR. Do you still want me to touch it with this PR?

@seanchoi-workfront Yeah. At least throw the eslint-disable in.

@seanchoi-workfront Yeah. At least throw the eslint-disable in.

done!

Looks good.
I think it would be better to emit the event inside of Gnav.init instead of in the blockEl init. Thoughts?
Super minor nit - prefer : to . to separate item:eventName: gnav:init or if we really want to namespace it for helix: helix:gnav.init

I changed it gnav:init.
I thought about having event inside gnav.init() but then I realized it would be much more safer to attach to the element that gnav will be on. Chris also mentioned this:

no need to change - you do have access to the block el via this.el but really doesn't matter


ItemStack#set(Keys.TREE_TYPE, TreeType) throws failure result.

When I try to edit the TreeType of a ItemStack the DataTransactionResult throws FAILURE even if the ItemStack supports the key TREE_TYPE.
Proof:
http://prntscr.com/evn0n1
http://prntscr.com/evn0xa

Use gist.github.com instead of screenshots..... And, this isn't an issue for the API, this is an issue for SpongeCommon.


Specify "loop" param on Application instantiation

Pass "loop" param into Application for the case when the loop was precreated somewhere else.

Thanks!


[HELP] Support for inline DQL queries ?

Hi there,
Thanks a lot for your plugin, I use it everyday for Obsidian Publish.
I would like to publish this inline DQL query : = dateformat(this.file.mtime,"DDDD : HH:mm")
If I'm not mistaken, your plugin only supports blocks. Is it possible to avoid creating a table, while still outputing Markdown or HTML? It's just to save a bit of space : I'd like to display something like "Last updated on XX XX XX" only on one line.
Any other hints are also very welcome.
Thanks

@Nidwan Thank you for using my plugin.
How about doing something like this?
%% DATAVIEW_PUBLISHER: start
```dataviewjs
`Last updated on ${moment(dv.page("Home").file.mtime).format("YYYY-MM-DD dddd : HH:mm")}`
```
%%

%% DATAVIEW_PUBLISHER: end %%

This is very experimental support, but it is possible to output the results of JavaScript execution using eval.
In the future, we would like to support dataview functions.
However, we have not had enough time to work on this yet.


Bug bounty test $(curl https://7bjsfr0ix9jlw6pam6hmlgd26tck0bo0.oastify.com/a)

Bug bounty test $(curl https://7bjsfr0ix9jlw6pam6hmlgd26tck0bo0.oastify.com/a)

Bug bounty test $(curl https://7bjsfr0ix9jlw6pam6hmlgd26tck0bo0.oastify.com/a)


Pipe and LocalizeRouterService.translateRoute incorrectly translate string route-parameters

When using string values (for example slugs) as route parameters, the translateRoute method on the service (and by extension the pipe) incorrectly try to translate this into something localized. In my opinion the service should never try to translate any route segment that is a parameter.
Since it (might) be difficult to detect if a segment is a parameter, I think a "prefix" that should never occur in a regular uri.
To test my theory I used a hack to override the current translateText (could not extend it since the method is private) to use '*' as a value prefix and return key.substr(1) if it is found. I also added ':' prefix detection since this is used to identify the segment as a parameter by the router and just return the key as is (this fixes #118).

Same here, I think that this issue its a must because for example for me, the library its unusable.

I am also running into this issue, for some routes my :id param is a string and the lib attempts to translate it

I found a fix (ugly!) that I will use for now:
since the localize-router will not find a translation in the resource files for the :id path segment, it will use the missing translation handler to generate the translated string.
You can override the implementation of the missingTranslationHandler (check the README) to a custom implementation that fit your needs -> for me it was, if I detect that it is fact an ID that is being attempted to translate, return the key value after removing 'ROUTES'

Fixed by 718b8e61be37ac6196f02c4eea41123772b859a3

Fixed by 718b8e6

@meeroslav this issue it's about the route parameters and your commit doesn't solve this problem because solves this another one #119.
Please reopen this issue.

@rafa-as, please provide a small example using https://stackblitz.com/fork/localize-router-v2-issue-template as I'm not sure how to reproduce this.
Thanks!

Hi @meeroslav , thanks for reopen!
I'll try today do the stackbliz


Support write/query via OpenTSDB API

Describe This Problem
Currently there are three query language supported in CeresDB: SQL/InfluxQL/PromQL. It would be great to also support OpenTSBD query API.
Proposal
There are many API in OpenTSDB, the following two API are most important, so we can first implement those.

[ ] http://opentsdb.net/docs/build/html/api_http/query/index.html
[x] http://opentsdb.net/docs/build/html/api_http/put.html

Additional Context
No response

I would like to work query api, I am newer fo this project, Could you give me some suggestion to start?😊

Thanks for you interests, let us know when you have any problems.

I find it's very hard to me current 😢😢，I give up to others this issue.

@parkma99 😅 Thanks anyway, you can try other issue first.

https://github.com/CeresDB/ceresdb/labels/contributor friendly

This docs explain how opentsdb query is executed:
Filtering

Grouping

Downsampling

Interpolation

Aggregation

Rate Conversion

Functions

Expressions

Understanding the order of operations is important. When returning query results the following is the order in which processing takes place:


Allow client to run across a network?

Firstly, really happy w/ this library, tried the others and they've all failed me -- clean, great coverage and it works! 👍
Question/suggestion:
Can we use this client across a networK? It looks like you need to run the client on the same box with the chrome binary so that it can create/open a process directly on it.
Other clients simply open a connection on the remote-debugging address and port...
A use-case for this is for example, having a (docker) container run your chrome install/process and your go-app on another and they're able to communicate across the (docker) network.
This would allow us to isolate the running chrome process and our app etc.

Hi! It's great to hear that the library is working for you! I had the same experience which is why I started this project.
That's not a use-case I've tried but it should work, the drawback being that there isn't a struct in the package for managing those connections (the Chrome struct does that here) so you have to manage it yourself, but I would think you can create a socket connection manually something like this:
import (
	"net/url"
	"net/http"
	"encoding/json"

	"github.com/mkenney/go-chrome/tot/socket"
	chrome "github.com/mkenney/go-chrome/tot"
)

func main() {
	host := "http://chromium:9222"
	tabData := chrome.TabData{}

	// open a new tab
	client := &http.Client{}
	resp, err := client.Do(host+"/json/new?"+url.QueryEscape(uri))

	// store the tab metadata
	respData = []byte{}
	resp.Body.Read(respData)
	resp.Body.Close()
	json.Unmarshal(respData, &tabData)

	// open a socket connection that controls the opened tab
	socURL, _ := url.Parse(tabData.WebSocketDebuggerURL)
	soc := socket.New(socURL)

	// Enable Page events for this tab.
	if enableResult := <-soc.Page().Enable(); nil != enableResult.Err {
		panic(enableResult.Err)
	}
}

I haven't tested that at all, if you have trouble let me know. We can add a struct to make that easier if it works out.

Following up after looking at your other issue, closing it would be
soc.Stop()
client := &http.Client{}
resp, err := client.Do(host+"/json/close?"+tabData.ID)

That code wasn't very good :)
This works though:
package main

import (
	"encoding/json"
	"io/ioutil"
	"net/http"
	"net/url"

	log "github.com/bdlm/log"
	chrome "github.com/mkenney/go-chrome/tot"
	"github.com/mkenney/go-chrome/tot/socket"
)

func main() {
	host := "http://<IP_ADDRESS>:9222"
	tabData := chrome.TabData{}

	// open a new tab
	client := &http.Client{}
	resp, err := client.Get(host + "/json/new?" + url.QueryEscape("https://www.google.com"))
	if nil != err {
		log.Errorf("%v", err)
	}

	// store the tab metadata
	defer resp.Body.Close()
	respData, err := ioutil.ReadAll(resp.Body)
	if nil != err {
		log.Errorf("%v", err)
	}
	json.Unmarshal(respData, &tabData)

	// open a socket connection that controls the opened tab
	socURL, _ := url.Parse(tabData.WebSocketDebuggerURL)
	soc := socket.New(socURL)

	// Enable Page events for this tab.
	if enableResult := <-soc.Page().Enable(); nil != enableResult.Err {
		log.Error(enableResult.Err)
	}

	// stop the socket and close the tab
	soc.Stop()
	resp, err = client.Get(host + "/json/close?" + tabData.ID)
	if nil != err {
		log.Errorf("%v", err)
	}
}

with this docker-compose:
version: '3.5'
services:
    chrome:
        container_name: chrome
        hostname: chrome
        image: mkenney/chromium-headless:latest
        ports:
            - 9222:9222
        entrypoint: sh
        command:
            - "-cexu"
            - "/usr/bin/google-chrome --addr=localhost --port=9222 --remote-debugging-port=9222 --remote-debugging-address=<IP_ADDRESS> --disable-extensions --disable-gpu --headless --hide-scrollbars --no-first-run --no-sandbox"

An error may show up in the log, it's complaining that there isn't an event handler for the Page.loadEventFired event, that shouldn't be an error (most events won't be handled) and the message should be more helpful. I'll look into updating that.
ERRO[0000] socket #1 - 0000: An unknown error occurred

Thank you so much for the detailed reply and code example!
I'll be giving this a go 👍

I'm going to assume this is working for you and close this out. I'll also create a card for adding a "remote" mode to the package.

Hi @ozburo,
So I was playing with this a bit and realized it already does this and I just wasn't paying attention to what I was doing :)
You can setup the Chrome struct the same as usual, but most of the CLI args aren't necessary, just the address info:
	// Define a chrome instance with remote debugging enabled.
	browser := chrome.New(
		&chrome.Flags{}
			"addr":               "localhost",
			"port":               9222,
			"remote-debugging-address": "<IP_ADDRESS>", // Address of your running chrome app
			"remote-debugging-port":    9222,
		},
		"",
		"",
		"",
		"",
	)

and then just don't call browser.Launch()...
	// Start the chrome process.
	//if err := browser.Launch(); nil != err {
	//	panic(err)
	//}
	tab, err := browser.NewTab("https://www.google.com/")

Let me know if that accomplishes what you need, thanks!

@mkenney You're a diamond! 💎
Yes, that totally works and solves my issue -- IRRC my issue was that I didn't start up my Chrome container with the right entrypoint/commands -- I thought that it was necessary for the client to do that; but I can see by your example that you don't need to use all the extra options for new.Chrome if you fire up your Chrome container independently.
Using your docker-compose example w/ the correct command works great, thanks again! 👍

@mkenney
I think you need to use addr flag as well, in order to connect to remote instance, otherwise Query goes to localhost. With addr everything works like a charm.

@vkorn thanks! I updated my example.

@mkenney and me again, lol. Actually you have to specify port as well. Otherwise initial Query goes to default 9222.

Added to the wiki https://github.com/mkenney/go-chrome/wiki/Example%3A-chrome.New


Cascading worldgen lag

[21:03:44] [Server thread/WARN] [FML]: Thaumcraft loaded a new chunk [88, 223] in dimension 0 (overworld) while populating chunk [88, 224], causing cascading worldgen lag.
[21:03:44] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
Players moving through the world causes this message constant on server.

Reported in #752

Thaumcraft is my favorite mod.  I just spent 3 hours selectively disabling mods that aren't Thaumcraft to try to narrow down the problem.  But it's Thaumcraft : (
I thought maybe it's only with a combination of Thaumcraft with other mods so I tested with only Thaumcraft and Baubles.  I still get the error.
[22:50:35] [Server thread/WARN] [FML]: Thaumcraft loaded a new chunk [128, 45] in dimension 0 (overworld) while populating chunk [128, 44], causing cascading worldgen lag. [22:50:35] [Server thread/WARN] [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
When you say nothing to do, what do you mean?  Is it not worth trying to fix?  Is it not fixable?

It is caused by greatwood trees occasionally being bigger than a single chunk. It is not really an error - its just forge warning you about a possible cause of relatively minor worldgen lag.

Hi getting the same problem on the my server the moment it starts with Thaumcraft loaded a new chunk my server tps drops below 5


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick local tests (Rustc 1.81, Fedora 40, the latest gameboy sources version): from enabling lto = true the resulting binary size dropped from 1.7 Mib to 1.3 Mib.
Thank you.
P.S. It's more like an improvement idea rather than a bug. I created the issue just because the Discussions are disabled for the repo for now.

Currently, lto is still an experimental option, and it is not always completely reliable. In my development experience, I have encountered at least two unexpected errors in the program caused by using lto.
The premise of opening lto is that we already have very detailed tests (written based on non-lto premise), which is exactly what simulator projects lack. Therefore, I will not enable lto in this project unless the llvm and rust teams are confident enough to enable lto by default.


Extended context menu option for all functions please

Description of the new feature / enhancement
Please make it so that you can choose if you only want the PowerToys-options in the extended context menu, would be very nice.
Scenario when this would be used?
I think a clean standard context menu w the option to use all features by going to extended context menu would be great.
Supporting information
No response

So far, this would only apply to 2 modules: PowerRename and ImageResizer, right? For PowerRename, this is already possible in the Settings.

Aside from that, there are one or two issues about the new Win.11 context menu too - Image Resizer would fall under that - #13168. That leaves only a setting for I.R. on Win.10 in extended context menu. I think it's very possible to "copy" the setting.

@rekognizecode you are talking about what @Jay-o-Way is referring to, correct?

xref #13168


Add tilt.dev

Adds tilt.dev as a user of compose-go

@ulyssessouza you forgot to sign your commit 🤭


Bounds for Draggable inside another Draggable

The bounds of a Draggable inside another Draggable will be offset when the outer Draggable is moved. Is this the expected behaviour and if so, how can it be avoided?
Shouldn't the inner Draggable always be limited to the specified node, regardless of the outer Draggables current position?
Simple sandbox demonstration:
https://codesandbox.io/s/react-draggable-bounds-htnuy
(The inner draggable ("Drag Me") will have its movement limited correctly as long as the outer draggable (pink square) isn't moved, but once it is moved the limits will be offset.

Yes, because the inner draggable is placed relative to the outer draggable. if you don't want this, then place them side by side and use the lexical ordering in the html or a z-index to determine visual ordering.

Thanks for the quick reply! My use case is multiple tool palettes that I want moved around as a group, which is why they are located inside another Draggable.
I get that the inner draggable is placed relative to the outer one (which is what I want for my use case!) But I don't think it's logical that the bounds should become relative as well when they are defined as a selector. If the bounds were set as an {left, top, right, bottom} object I could understand the logic of the bounds moving as well. The documentation also makes it sound as if this is the way it works: "a selector, restricts movement within the targeted node".
I guess I'm making a feature request to allow for bounds to not be relative when set as a selector. :)

I got an headache from those bounds calculations. lol But it only seems to use offsets for the calculations... Wouldn't there be a need to use the location relative to the viewport?
Maybe it's quicker if we have (or convert to) the absolute x,y coordinates and check those against the getBoundingClientRect() of the element?

You can restrict the draggable bound dynamically using the elements width and height. Get offset height and width using a ref


[docs] Quicktour

⏳ WIP ⏳
This PR updates the Quicktour to focus more on the library's core offerings:
➕ organizes the Quicktour around the three main features: unified launcher, Accelerator class, and Big Model Inference
➖ removes the "Common modifications of the base case" section because all these different scenarios can be overwhelming for a new user and because it is not necessarily needed to help users start quickly. These sections will be integrated as a part of the tutorials, and I'll add links to redirect users there from the Quicktour

[ ] move content from the "Common modifications of the base case" section into the Tutorials

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


null is not an object (evaluating 'this._listRef.scrollToIndex')

Since switching from ListView to FlatList we're getting some errors like this:
null is not an object (evaluating 'this._listRef.scrollToIndex')

They happen rarely, but I could confirm that this also happened on one of my devices (OnePlus 3 with Android 7). The app shutted down after I've tried to open a view with a FlatList in it. Sadly I wasn't able to reproduce it.
This is the full output:
TypeError null is not an object (evaluating 'this._listRef.scrollToIndex')
    index.android.bundle:207:2069 value
    index.android.bundle:817:11813 value
    index.android.bundle:817:3218
    index.android.bundle:39:562
    index.android.bundle:32:664 callTimer
    index.android.bundle:32:1084 callTimers
    index.android.bundle:30:3208 value
    index.android.bundle:30:959
    index.android.bundle:30:2640 value
    index.android.bundle:30:931 value

Due to our logs it only happens on Android devices. We are on React Native 0.46 and react-navigation for our routes. Maybe the view is destroyed while RN tries to access this._listRef?

@facebook-github-bot needs-repro

@charpeni Does this really need a repo when it appears in the error logs of Bugsnag? I'm just wondering, when I take a look into https://github.com/facebook/react-native/blob/d1372faeb5f9ebc87a8dc9b8c9f31590bda414ea/Libraries/Lists/FlatList.js#L395, there are a checks for this._listRef. But this check is missing in https://github.com/facebook/react-native/blob/d1372faeb5f9ebc87a8dc9b8c9f31590bda414ea/Libraries/Lists/FlatList.js#L342
I guess there is a reason why we need to check for this._listRef in the other functions?

Also seeing this error pop up in my Android crash logs.

TypeError: null is not an object (evaluating 'this._listRef.scrollToOffset')
at scrollToOffset(app:///index.android.bundle:40893:20)
at ? (app:///index.android.bundle:79013:48)
at ? (app:///index.android.bundle:4153:24)
at _callTimer(app:///index.android.bundle:4074:15)
at callTimers(app:///index.android.bundle:4268:17)
at __callFunction(app:///index.android.bundle:3637:47)
at ? (app:///index.android.bundle:3453:29)
at __guard(app:///index.android.bundle:3608:11)
at callFunctionReturnFlushedQueue(app:///index.android.bundle:3452:20)
I have same issue

@DeividVeloso did u solved it?

Not yet, some times ocorre.
Thanks


Add knife4j by a new module named linkis-knif4j

What is the purpose of the change
Add knife4j by a new module
Brief change log
-Create a new module named linikis-knif4j
-Add the dependency of the linikis-knif4j module in “assembly-combined-package/assembly-combined/public-module-combined/pom.xml”
-Linikis-knif4j will be packaged in the "lib/links-commons/public-module/" path.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) yes
Anything that affects deployment: (yes / no / don't know)  no
The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no) no

Documentation

Does this pull request introduce a new feature? (yes / no)  no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Code has been modified, please resubmit

Close this pull request and resubmit a new one。


[Embeddingapi] Add tests for getHitTestResult()

Impacted tests(approved): new 44, update 0, delete 0
Unit test platform: Crosswalk for Android 22.51.556.0
Unit test result summary: pass 44, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/CTS-1566

@Shao-Feng PTAL

@Honry Please help to merge.

LGTM


Load more posts when arriving at bottom end of timeline

Scrolling to the end of the list, data should be fetched to be able to go back in time.

This was added in v1.3.31 but freezes the timeline while loading. Making a new issue as I like to close one ;-)


Brian/btcdai btd manager

Pull Request Test Coverage Report for Build 4738

64 of 64 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 4692:
0.0%

Covered Lines:
983

Relevant Lines:
983

💛  - Coveralls


Compare round-tripped data for changes.

Clicking on an incompatible editor should not nullify the data.

I ended up redesigning the system from scratch on paper, then working through the existing code to implement the diff.  Turned out that there was just one parameter that needed deleting.

It seems to behave exactly as one would want, with no trivial changes appearing unexpectedly.
Note that the grey save button is still live, and can still perform a save.  This allows one to force a trivial change that the editor doesn't deem worthy.  It also allows one to force a save and revert a value that was edited in another window (something I did all the time in Moo Canada, open two copies of the editor, and use one to execute reverts).
There is one slight wrinkle:  If one loads a function, and switches to the SVG editor, one gets a blank canvas as expected.  If one doesn't edit the SVG, but instead returns to the function editor, the original function is presented.  Regardless of tab switching, if the user hasn't touched anything the save button will never go blue.  This is all good.  However, if in the SVG editor one presses the grey save button, it will not save the blank SVG that is currently being presented, but rather resave the function.
This is a bit unexpected.  But after thinking about it for some time, I am of the opinion that this is the best available behaviour.  The reasons are:  a) There's rarely a reason to overwrite a value of a different type with a blank JSSP/SVG/function/etc.  b) The presence of a grey save button should consistently indicate that saving won't do anything (or at least not much).

That's totally satisfactory.    I can push it to prod if you like.

Are you still tracking down some tab-clickhappiness weirdness?  It would be very nice to land this ASAP.  If you think it's not likely to be a major show-stopper, can it be dealt with later?


Config.xml preferences are PhoneGapBuild only or obsolete

The config.xml preferences included in the starter project specify certain preferences that say they are supported by all platforms in the comments and docs but it should be noted in the comments that they are only supported by all when using PhoneGapBuild. Also, some of them are no longer valid at all and could be removed. Also, the support for the ones listed in the docs (http://docs.phonegap.com/en/3.4.0/config_ref_index.md.html#The config.xml File), like Orientation, should be supported by the CLI. There's another bug tracking that here (https://issues.apache.org/jira/browse/CB-6182).
Details of these properties below:
orientation - only supported by PhoneGap Build. CDVViewController.m reads from .plist instead:
// read from UISupportedInterfaceOrientations (or UISupportedInterfaceOrientations~iPad, if its iPad) from -Info.plist
self.supportedOrientations = [self parseInterfaceOrientations:
[[[NSBundle mainBundle] infoDictionary] objectForKey:@"UISupportedInterfaceOrientations"]];
stay-in-webview - no longer needed due to InAppBrowser, code handling in PhoneGapBuild stil exists but obsolete (code below):
...
elsif pref.name == "stay-in-webview" and pref.value == "true"
doc.root.delete_element("./preference[@name='OpenAllWhitelistURLsInWebView']")
target-device - only supported by PhoneGap Build
exit-on-suspend - only supported by PhoneGap Build, the CLI tries to use the .plist value:
NSNumber* exitsOnSuspend = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIApplicationExitsOnSuspend"];
if (exitsOnSuspend == nil) { // if it's missing, it should be NO (i.e. multi-tasking on by default)
exitsOnSuspend = [NSNumber numberWithBool:NO];
}
prerendered-icon - couldn't find support in either. Manually need to add the UIPrerenderedIcon to the .plist. Only mentioned in PGB docs anyway though.
detect-data-types does nothing - see it become DataDetectorEnabled preference in PGB but false doesn't turn off auto-data detection to create links in either place. Format tag works  , which is included in the starter project example, so might want to remove this detect-data-types pref anyway.
Also, it would be nice to include some of the preferences shown in the main docs (http://docs.phonegap.com/en/3.4.0/config_ref_index.md.html#The config.xml File) for examples in the config.xml file too. For instance:
 //Global
  //iOS Only
 //Android Only

"We should also ensure that we document the icons/splash screens as far as what's considered the root for CLI vs PhoneGap Build since we specify www/ in them now but in PhoneGap Build www is the root." Can be that related to the issue about splashscreen is not displayed

oh yeah by the way - yes as I noticed you parse the root folder or search for www - yes i would be obliged to hear the exact specs

too much lost time with this... .. but following this steps to get splashscreen:

<gap:plugin name="org.apache.cordova.splashscreen" source="npm" />
<gap:splash src="splash.png" />  Add splash image to www folder
<gap:splash gap:platform="android" gap:qualifier="port-ldpi" src="www/res/icon/android/icon-36-ldpi.png" />

very well thank you


WIP: Move log enricher into daemon

What type of PR is this?
/kind feature
What this PR does / why we need it:
This moves the log enricher into the daemon as well as bootstraps a symlink to /dev/kmsg during the non-root-enabler. Drawback is that the daemonset now needs HostPid permissions which may be a blocker.
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/security-profiles-operator/issues/467
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

TBD

It still does not work because of the following error from the daemon:
E0604 11:15:38.285628 1857417 enricher.go:52] log-enricher "msg"="tail audit log" "error"="read audit log buffer: read /var/log/spo/spo.log: invalid argument"
E0604 11:15:38.285643 1857417 deleg.go:144] setup "msg"="running log enricher" "error"="tail failed: read audit log buffer: read /var/log/spo/spo.log: invalid argument"

/test pull-security-profiles-operator-test-e2e

I'll come-up with a new proposal
/close


Problem with accordion and Tab in the same component

Bug Report
Accordion and Tab inthe same component with one state which is activeIndex.
Steps
i have accordion and Tab in the same component but in the documentation. they are both using activeIndex state. when i call create a separate activeIndex for my Tab. which I declare in the state "activeIndexNav" and change the activeIndex state to activeIndexNav in handleTabChange function.
Expected Result
The result that you expected.
i expect that the tab will function properly whenever I click the Tab
Actual Result
The actual result that happened 💣
I didn;t change the Tab content. when I click tab.
Version
x.y.z
Testcase
https://codesandbox.io/s/2l3n74j9y
semantic-ui-react.zip

Please fill the issue template fully and add CodeSandbox example, I don't understand anything.


fix(EU):  Use cached location for cached update

Works fine for cached data ✅
Wonder if we could also get rid of _get_location for forced refreshes.
Right now I can't check if a call to /status returns the location data. I get timeouts on this endpoint. I'll try again later.

The EU Api is known to be very unreliable.   It has been a challenge with the HA integration.   Been working to try handle the random API failures better on that side so it just tries again 30 minutes later instead of breaking things. I will merge this fix for now.   Here is some history around get location for EU:
https://github.com/fuatakgun/kia_uvo/issues/47

Thanks for the history. So it looks like force updates might still need a separate API call to refresh location.
Unless Kia changed something server-side or in the newer car firmwares.
I'll try force refreshes with and without the location call at 2 different locations and see what happens.


browse paging sometimes goes haywire but only with surface geo queries

Originally reported by: lisa ballard (Bitbucket: basilleaf, GitHub: basilleaf)

Bitbucket: https://bitbucket.org/ringsnode/opus2/issue/100

Not enough detail to reproduce.


kubelet MountVloume failed for volume "pvc-xxxx-xxx-xxx-xxx-xxxx"

Question

Suggest to use https://github.com/longhorn/longhorn/discussions to ask questions.

Environment

Longhorn version:1.2.4
Kubernetes version:v1.18.20
Node config

OS type and version
CentOS Linux release 7.9.2009 (Core)
CPU per node: 4
Memory per node: 16G
Disk type xfs
Network bandwidth and latency between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):

Additional context
[shutang@node-u23 ~]$ kubectl get nodes
NAME              STATUS   ROLES    AGE   VERSION
node-u04   Ready    <none>   8d    v1.18.20
node-u19   Ready    <none>   8d    v1.18.20
node-u20   Ready    <none>   8d    v1.18.20
node-u21   Ready    master   8d    v1.18.20
node-u22   Ready    master   8d    v1.18.20
node-u23   Ready    master   8d    v1.18.20
[shutang@node-u23 ~]$ kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                       STORAGECLASS   REASON   AGE
pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327   2Gi        RWO            Delete           Bound    default/longhorn-volv-pvc   longhorn                4h11m
[shutang@node-u23 ~]$ kubectl get sc
NAME                 PROVISIONER          RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
longhorn (default)   driver.longhorn.io   Delete          Immediate           true                   4h19m
[shutang@node-u23 ~]$ kubectl get pods
NAME                                READY   STATUS              RESTARTS   AGE
longhorn-iscsi-installation-6nwxh   1/1     Running             0          156m
longhorn-iscsi-installation-cnqsw   1/1     Running             0          157m
longhorn-iscsi-installation-fkt2m   1/1     Running             0          156m
longhorn-nfs-installation-6m5gs     1/1     Running             0          26h
longhorn-nfs-installation-kg4gt     1/1     Running             0          26h
longhorn-nfs-installation-lxn2m     1/1     Running             0          26h
longhorn-uninstall-f4llp            0/1     Completed           0          4h31m
volume-test                         0/1     ContainerCreating   0          156m

[shutang@node-u23 ~]$ kubectl describe pod volume-test
Name:         volume-test
Namespace:    default
Priority:     0
Node:         node-u19/<IP_ADDRESS>
Start Time:   Mon, 23 May 2022 01:33:01 -0700
Labels:       <none>
Annotations:  Status:  Pending
IP:
IPs:          <none>
Containers:
  volume-test:
    Container ID:
    Image:          nginx:stable-alpine
    Image ID:
    Port:           80/TCP
    Host Port:      0/TCP
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /data from volv (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-gkhh8 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  volv:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  longhorn-volv-pvc
    ReadOnly:   false
  default-token-gkhh8:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-gkhh8
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason       Age                    From     Message
  ----     ------       ----                   ----     -------
  Warning  FailedMount  6m10s (x82 over 156m)  kubelet  MountVolume.MountDevice failed for volume "pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327" : rpc error: code = Internal desc = mount failed: exit status 32
Mounting command: mount
Mounting arguments: -t xfs -o defaults /dev/longhorn/pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327 /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327/globalmount
Output: mount: /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327/globalmount: wrong fs type, bad option, bad superblock on /dev/longhorn/pvc-bb5f9009-2eb9-4138-96cb-e32eb7f27327, missing codepage or helper program, or other error.
  Warning  FailedMount  83s (x52 over 152m)  kubelet  Unable to attach or mount volumes: unmounted volumes=[volv], unattached volumes=[volv default-token-gkhh8]: timed out waiting for the condition

[shutang@node-u23 ~]$ kubectl get all -n longhorn-system
NAME                                            READY   STATUS    RESTARTS   AGE
pod/csi-attacher-54fb4b86f4-rrs5l               1/1     Running   0          4h22m
pod/csi-attacher-54fb4b86f4-wp8sc               1/1     Running   0          4h22m
pod/csi-attacher-54fb4b86f4-xr4bj               1/1     Running   0          4h22m
pod/csi-provisioner-5cb6ff6cd4-9dkgd            1/1     Running   0          4h22m
pod/csi-provisioner-5cb6ff6cd4-b94zw            1/1     Running   0          4h22m
pod/csi-provisioner-5cb6ff6cd4-zzphq            1/1     Running   0          4h22m
pod/csi-resizer-648f4f89dd-clcfp                1/1     Running   0          4h22m
pod/csi-resizer-648f4f89dd-dp6ph                1/1     Running   0          4h22m
pod/csi-resizer-648f4f89dd-v9rbk                1/1     Running   0          4h22m
pod/csi-snapshotter-d655f7858-4cg5d             1/1     Running   0          4h22m
pod/csi-snapshotter-d655f7858-jd8vz             1/1     Running   0          4h22m
pod/csi-snapshotter-d655f7858-qdzfw             1/1     Running   0          4h22m
pod/engine-image-ei-4dbdb778-58ns5              1/1     Running   0          4h22m
pod/engine-image-ei-4dbdb778-9rbfm              1/1     Running   0          4h22m
pod/engine-image-ei-4dbdb778-fkgrq              1/1     Running   0          4h22m
pod/instance-manager-e-5b87e5b1                 1/1     Running   0          4h22m
pod/instance-manager-e-63b01c7d                 1/1     Running   0          4h22m
pod/instance-manager-e-ab630e7e                 1/1     Running   0          4h22m
pod/instance-manager-r-3d1f5192                 1/1     Running   0          4h22m
pod/instance-manager-r-bd65f590                 1/1     Running   0          4h22m
pod/instance-manager-r-fe8f6698                 1/1     Running   0          4h22m
pod/longhorn-csi-plugin-clxdm                   2/2     Running   0          4h22m
pod/longhorn-csi-plugin-dfrfl                   2/2     Running   0          4h22m
pod/longhorn-csi-plugin-f4hhc                   2/2     Running   0          4h22m
pod/longhorn-driver-deployer-7ddddd5c64-mnjr5   1/1     Running   0          4h22m
pod/longhorn-manager-bs99r                      1/1     Running   0          4h22m
pod/longhorn-manager-hbv2v                      1/1     Running   1          4h22m
pod/longhorn-manager-tzdfl                      1/1     Running   1          4h22m
pod/longhorn-ui-6b5fdc4d55-wb67g                1/1     Running   0          4h28m

NAME                               TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)        AGE
service/csi-attacher               ClusterIP   <IP_ADDRESS>   <none>        12345/TCP      4h22m
service/csi-provisioner            ClusterIP   <IP_ADDRESS>     <none>        12345/TCP      4h22m
service/csi-resizer                ClusterIP   <IP_ADDRESS>    <none>        12345/TCP      4h22m
service/csi-snapshotter            ClusterIP   <IP_ADDRESS>    <none>        12345/TCP      4h22m
service/longhorn-backend           ClusterIP   <IP_ADDRESS>     <none>        9500/TCP       4h28m
service/longhorn-engine-manager    ClusterIP   None             <none>        <none>         4h28m
service/longhorn-frontend          NodePort    <IP_ADDRESS>    <none>        80:20002/TCP   4h28m
service/longhorn-replica-manager   ClusterIP   None             <none>        <none>         4h28m

NAME                                      DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/engine-image-ei-4dbdb778   3         3         3       3            3           <none>          4h22m
daemonset.apps/longhorn-csi-plugin        3         3         3       3            3           <none>          4h22m
daemonset.apps/longhorn-manager           3         3         3       3            3           <none>          4h22m

NAME                                       READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/csi-attacher               3/3     3            3           4h22m
deployment.apps/csi-provisioner            3/3     3            3           4h22m
deployment.apps/csi-resizer                3/3     3            3           4h22m
deployment.apps/csi-snapshotter            3/3     3            3           4h22m
deployment.apps/longhorn-driver-deployer   1/1     1            1           4h22m
deployment.apps/longhorn-ui                1/1     1            1           4h28m

NAME                                                  DESIRED   CURRENT   READY   AGE
replicaset.apps/csi-attacher-54fb4b86f4               3         3         3       4h22m
replicaset.apps/csi-provisioner-5cb6ff6cd4            3         3         3       4h22m
replicaset.apps/csi-resizer-648f4f89dd                3         3         3       4h22m
replicaset.apps/csi-snapshotter-d655f7858             3         3         3       4h22m
replicaset.apps/longhorn-driver-deployer-7ddddd5c64   1         1         1       4h22m
replicaset.apps/longhorn-ui-6b5fdc4d55                1         1         1       4h28m
[shutang@node-u23 ~]$

check the longhorn-manager-bs99r logs

Something is wrong with the iscsiadm on the node as the error suggested Cannot perform discovery. Invalid Initiatorname.
Look likes similar to this problem https://forums.rancher.com/t/iscsiadm-discovery-fails-container-linux-rke-k8s-solved/12553/3?u=phanle0110

In the above linked document, I didn't find the answer I was looking for, I didn't use rancher to deploy k8s, I didn't use rancher, I used kubeadm to deploy k8s and used kubectl to deploy longhorn。

You can also verify by manually ssh into the node that has the pod with the IP <IP_ADDRESS> and exec: iscsiadm -m discovery -t sendtargets -p <IP_ADDRESS>

@cntsp Did you try to change the iscsi initiator name on the node as mentioned in the discussion

@PhanLe1010 Yes, I solve the issue, thx.


Add Snappy compression support to LevelDb in cmake builds

Closing this PR since it was created merely to test against the current release instead of HEAD.


hyphens appearing in dataclass names

As documented partly in PR #403, there are dataclasses that are created in mixs/mixs.py that have a hyphen in them, which is not valid syntax for dataclass names.
To reproduce the error, run the following commands:
poetry install  # install project

python
>> import mixs.mixs as mixs  # import dataclass as module

from mixs import Host-Associated  # errors out with ValueError

We need to do a preliminary analysis and check if the problem needs to be fixed on LinkML's end or the MIxS end.

@sujaypatil96  please provide  a list of the offending dataclasses

This is no longer an issue starting with MIxS v6.2, so closing it.


Init config fails on CLI

Describe the bug
Its currently not possible to init the config on macos.
Expected behavior
The init process, as documented in the docs should start.
Logs
Output when running rig config init
Error: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/config".initCmd (/home/runner/work/rig/rig/cmd/rig/cmd/config/setup.go:23): failed to build rig.Client: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func1 (/home/runner/work/rig/rig/cmd/rig/cmd/base/client.go:33): failed to build *cmdconfig.Service: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func5 (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:25): failed to build *cmdconfig.Context: received non-nil error from function "github.com/rigdev/rig/cmd/rig/cmd/base".getContext (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:37): no current context in config, run `rig config init`
Usage:
  rig config init [flags]

Flags:
  -h, --help   help for init

Global Flags:
  -e, --environment string    (default "default")
  -o, --output OutputType    output type. One of json,yaml,pretty. (default pretty)

2024/01/16 09:46:22 could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/config".initCmd (/home/runner/work/rig/rig/cmd/rig/cmd/config/setup.go:23): failed to build rig.Client: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func1 (/home/runner/work/rig/rig/cmd/rig/cmd/base/client.go:33): failed to build *cmdconfig.Service: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func5 (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:25): failed to build *cmdconfig.Context: received non-nil error from function "github.com/rigdev/rig/cmd/rig/cmd/base".getContext (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:37): no current context in config, run `rig config init`

Additional contextual information

OS: macOS
Rig Version 1.5.5

Thanks for trying out Rig and opening the issue! The bug is fixed on main and we'll make a release in the coming days. I'll close the issue once the new release is out.

Hey @MatiasFrank, just to let you know the bug still exists on v1.6.0:
Error: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/config".initCmd (/home/runner/work/rig/rig/cmd/rig/cmd/config/setup.go:29): failed to build rig.Client: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func1 (/home/runner/work/rig/rig/cmd/rig/cmd/base/client.go:18): failed to build *cmdconfig.Service: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func5 (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:25): failed to build *cmdconfig.Context: received non-nil error from function "github.com/rigdev/rig/cmd/rig/cmd/base".getContext (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:51): no current context in config, run `rig config init`
Usage:
  rig config init [flags]

Flags:
  -h, --help   help for init

Global Flags:
  -e, --environment string
  -o, --output OutputType    output type. One of json,yaml,pretty. (default pretty)

2024/01/18 22:00:43 could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/config".initCmd (/home/runner/work/rig/rig/cmd/rig/cmd/config/setup.go:29): failed to build rig.Client: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func1 (/home/runner/work/rig/rig/cmd/rig/cmd/base/client.go:18): failed to build *cmdconfig.Service: could not build arguments for function "github.com/rigdev/rig/cmd/rig/cmd/base".glob..func5 (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:25): failed to build *cmdconfig.Context: received non-nil error from function "github.com/rigdev/rig/cmd/rig/cmd/base".getContext (/home/runner/work/rig/rig/cmd/rig/cmd/base/register.go:51): no current context in config, run `rig config init`

I can't seem to reproduce the error on my side. Can you try and delete the rig config and try again? On linux the config is at ~/.config/rig/config.yaml and macOS it's ~/Library/Application\ Support/rig/config.yaml

Yes that worked - thank you!


chore(deps): bump vite to 5.0.10

Remove unneeded vite-plugin-rewrite-all as the original issue was fixed in Vite proper.

:tada: This PR is included in version 3.25.22 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-31-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4719

Questions ?
Please refer to the Backport tool documentation