New rule: prefer-exact-props

This rule checks if non-exact objects are used for defining prop types when using Flow along with using normal objects for prop types instead of something like prop-types-exact to enforce only passing the exact props to a component.
The exact prop wrapper functions for non-Flow usage are configurable by adding the exact property to an object setting in the propWrapperFunctions config option.
Closes #1455

Do you think it should be a global setting instead of just an option for the rule? I'm unsure of the other use cases for it being a global setting.

@jomasti if it were a global setting, then other rules could access it to "unwrap" propTypes for their own uses.

@ljharb Wouldn't these particular "exact props" functions still be in propWrapperFunctions in order to facilitate that?

@jomasti right; the idea is that i'd be able to move forbidExtraProps etc out of propWrapperFunctions and into this new setting.

I guess an alternative schema for the existing setting could be:
"propWrapperFunctions": [
  "Object",
  { "property": "freeze", "object": "Object" },
  { "property": "forbidExtraProps", "exact": true }
]

What exactly is missing before this can be merged? Can we maybe split this task and add support for libs like airbnb/prop-types in an other task?

@maxammann that support already exists; see the "propWrapperFunctions" setting in the readme.
This PR needs to be updated per the above comments.

After doing some digging, it looks like the failures on ESLint 3 are due to versions 7.22+ of babel-eslint using eslint-scope over escope if available. This combination of the two results is weird errors for TypeAlias and maybe others. I'm not sure what I should do to rectify this.

We could modify the dep range, and for eslint 3 in Travis.yml manually downgrade it?

We could modify the dep range, and for eslint 3 in Travis.yml manually downgrade it?

Would you prefer for the before_script to be extracted to a separate script with this extra logic?

Downgrading to a working version of babel-eslint breaks other tests, so it doesn't seem viable.

Yes, using<EMAIL_ADDRESS>with eslint@3 breaks tests that use object spread in type aliases and the short syntax for fragments.

So what is it exactly about this pr that causes this breakage?

What happened to this PR? Is there any other rule that can/should be used?
I would love to enforce the usage of exact from prop-types-exact in our project as it seams to have only advantages and no disadvantages...

Codecov Report

Merging #1547 (675dfae) into master (f233eb7) will increase coverage by 0.02%.
The diff coverage is 99.05%.

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   97.44%   97.47%   +0.02%
==========================================
  Files         110      111       +1
  Lines        7294     7395     +101
  Branches     2665     2699      +34
==========================================
+ Hits         7108     7208     +100
- Misses        186      187       +1

Impacted Files
Coverage Δ

index.js
100.00% <ø> (ø)

lib/rules/prefer-exact-props.js
98.82% <98.82%> (ø)

lib/util/propWrapper.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f233eb7...675dfae. Read the comment docs.


Store: Resolve app stats reference in store package

This file in the store package has a reference to app stats:
src/frontend/packages/store/src/reducers/api-request-reducers.generator.ts

... not anymore. closing


[Dashboard] Removing empty top level tabs crashes the dashboard builder

Expected results
When removing empty top-level tab, the page should not crash
Actual results
https://user-images.githubusercontent.com/335541/106976486-57c9a280-670d-11eb-8f97-09c692d796f9.mp4
There are a couple of bugs or inconveniences related to adding tabs in dashboard builder:

Adding top level tab does not have proper drop indicator
Collapsing the top level tab makes the whole page crush if you have deleted the all tabs in it
Deleting the last tab collapses the tab container to a weird-looking state. We should probably either redesign it or just disabling deleting the last tab

How to reproduce the bug

Try add a top-level tab

Environment
Latest master
Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

I'm pretty darn sure this was fixed a long time ago, so I'll optimistically close it. Happy to re-open if it rears its ugly head again.


Fannkuch redux d

Added different implementations in D:
1 : from 1.cr
1-i, 1-im : from 1-im.cpp
2-i : from 2-i.rs
2-im : from 2-im.rs
It is just a ported version of code from different languages. Better and more iDiomatic code could be added later.

Looks like there're merge conflicts

Looks like there're merge conflicts

It seems the problem with bench_d.yaml
I don’t know why the new part for this problem git assessed as conflict

@hanabi1224 do you know what to do to eliminate this conflict?

@hanabi1224 now the conflict should be resolved.


Sync the changes of nightly docker-compose file from PR 166 of developer-scripts

The nightly docker-compose file from developer-scripts repository has changed due to issue #165 fixes.
This PR is to harmonized the changes of docker-compose file from the PR #166 of developer-scripts repository
Signed-off-by: Jim Wang<EMAIL_ADDRESS>

@tingyuz  @michaelestrin  changes made in this PR.   Once this one is merged, it should Fixes developer-scripts issue #165. Thanks.


fix: #151, materials now update meshes on uniform setting. [#95480122]

@adnan-wahab do you have an example with and without this fix?
@redwoodfavorite @FarhadG can you review?

before: https://api-te.famo.us/codemanager/v1/containers/0e578483-207f-44ae-8ac8-3762962dfa31/share
after: https://api-te.famo.us/codemanager/v1/containers/0e578483-207f-44ae-8ac8-3762962dfa31/share

@adnan-wahab you have two different PR's on the same branch.  Please close this and make a feautre branch for each.


Depth of grid space

The zScan.json file in the raw pumprobe folder has the following structure (aside from the waveform)
 'latencyShiftPermutation': 258,
 'V/um': 0.125,
 'waveType': 'triangle',
 'etlCalibrationMindpt': -1,
 'etlCalibrationMaxdpt': 1,
 'piezoEtlClockLock': False,
 'volumeHeight': 30,
 'volumeHeightUnits': 'um',
 'etl dpt/um': 0.05,
 'etlVMin': 0,
 'etlVMax': 5

Should the grid spacing information for the z axis be pulled from the V/um field or the volumeHeight?
From the parent library pumpprobe uses for I/O, it seems as if the volumeHeight is not used: https://github.com/leiferlab/wormdatamodel/blob/2ab956199e3931de41a190d2b9985e961df3810c/wormdatamodel/data/recording.py#L615

@emosb In NWB, we characterize the ImagingPlane using a grid_space that in the volumetric case describes the 'distance' of each dimension of a voxel in micrometers - is the volumeHeight field valid for this? I didn't see any usage of the field in the wormdatamodel

To my understanding looking through wormdatamodel, the volume height is determined by the Voltage stored in the second column of other-frameSynchronous.txt (which I believe is actually the voltage supplied to one of the Electrically Tunable Lenses and not the Piezo - I will check on this!). The voltage stored here is then multiplied by 1/0.125 (0.125 = the V/um) and by 1/0.42 (0.42 = a hardcoded um/pixel) to get a z value in pixels. I am not sure whether the choice to use pixels as the unit is necessary in later steps of the pipeline - I can get back to you on that.
If you want grid spacing in um, I believe based on the wormdatamodel code it is more accurate to use the V/um field. Checking with the first full volume in the hermaphrodite dataset, converting V to um this way gives a full volume height of 29.93 um. The second is 29.97 um. I think 30 um is generally what the volume height is set to but there is some error in the actual volume acquisition.

Sounds great, I did not think to check that field on the other-frameSynchronous.txt file
I will use that plus V/um value in the configuration file to scale them into physical units


Dylibso is noticing some tracing issues

Zach (cc'd) is making great progress on getting the Observe SDK traces merged with compute node (host) traces so they both show up in the same sink (in this case Jaeger) using the trace id configured by the host, however we've run into a couple of snags and could use your assistance.
Although some of traces from both the host (looks like mostly background tasks) and the wasm module are making into Jaeger, it's missing the context around the wasm execution and we're getting some otel errors from Bacalhau that look like the following:
13:33:47.323 | ERR pkg/telemetry/common.go:18 > Error occurred while handling spans error="traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8"
13:34:37.327 | ERR pkg/telemetry/common.go:18 > Error occurred while handling spans error="traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8"

We're having some trouble unwinding the source of the error as it appears that a global error error handler is being used. Also appears we're getting these errors on the main branch with the Observe SDK disabled as well. The Observe SDK is also reusing the Bacalhau Otel client config so we're reasonably confident both are using the same protocol (e.g. grpc/protobuf).

cc @zshipko @wikiwong
I've recreated the setup locally and checked out your fork. Tl;dr: I can't observe any issue, and the tracing seems to be working as intended (see below screenshot).

The telemetry errors you are seeing appear to be coming from inside the library that provides our IPFS node. When I remove the IPFS node (by running an external node instead) the errors disappear. So I believe you can safely ignore this – all of the traces from Bacalhau appear to be transmitting correctly.
I can see context around the WASM execution in the form of pkg/compute.ExecutorBuffer.Run as shown in the screenshot. Do you not get this? Are you expecting more/different context?
I can also see the Observe SDK traces appearing.

Thank you - using this setup it seems to work correctly!
Before I wasn't seeing the pkg/compute.ExecutorBuffer.Run events in jaeger, but maybe it is just a configuration issue. I was also using bacalhau devstack for my tests before.
Very excited to see this working!

@simonwo after discussing further, we're going to make the tweak to utilize Bacalhau's OTel client for the Wasm tracing as well.  We'll notify once we get that in, do some additional testing, then sync back up to talk about next steps for getting this merged.  Let us know if there's anything else you'd like to see before getting this merged!

Thanks! I'm closing this issue now and we can continue discussion in the PR.


[QoI] Fix position of the fix-it related to raw representable conversion

Part of the fix-it for conversion from optional to raw representable
was inserted at the incorrect position which produces invalid expression.
Resolves: rdar://problem/32431736

@swift-ci please smoke test


Prisma info log level doesn't emit event

Bug description
When setting the client log level, if you set { emit: 'event', level: 'info' } you won't get a log about the pool initializing with connections. If you set { emit: 'stdout', level: 'info' }, you do.
How to reproduce
Omitting some boilerplate, this will emit a log event when initializing:
const client =   new PrismaClient({
  datasources: { db: { url: '...' } },
  log: [{ emit: "stdout", level: "info" }]
})

await client.$connect()

// emits this log:
// prisma:info Starting a postgresql pool with 21 connections.

While setting it up to emit as an event, we don't get that log about the pool starting:
const client =   new PrismaClient({
  datasources: { db: { url: '...' } },
  log: [{ emit: "event", level: "info" }]
})

client.$on('info', (e) => {
  console.log('info event', e)
})

await client.$connect()

// no event is emitted

Expected behavior
Get the same info printout about the connection pool starting when emitting info levels as events.
Prisma information
Schema not relevant
Environment & setup

OS: macOS
Database: CRDB v22.8
Node.js version: 16.20

Prisma Version
prisma                  : 4.13.0
@prisma/client          : 4.13.0
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 1e7af066ee9cb95cf3a403c78d9aab3e6b04f37a (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 1e7af066ee9cb95cf3a403c78d9aab3e6b04f37a (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.13.0-50.1e7af066ee9cb95cf3a403c78d9aab3e6b04f37a
Default Engines Hash    : 1e7af066ee9cb95cf3a403c78d9aab3e6b04f37a
Studio                  : 0.484.0
Preview Features        : tracing, extendedWhereUnique

I'm experiencing the same issue.

I could not reproduce with the information you provided 🤔 (and could not either with the latest version)
Is this still an issue for you @AndrewSouthpaw?

Can confirm this is fixed now (or I was just completely wrong originally, who knows)!


MH-12885 Capture Agent Access Management

This patch adds the possibility to configure which user (groups) have
access to which capture agents. Whenever a new capture agent is
registered, a new role is generated which a user needs to have when
changing scheduling information affecting the capture agent.
This includes:

Editing schedule information of scheduled events
Changing the workflow settings of scheduled events
Scheduling new events
Deleting scheduled events
Deleting capture agents

The administrator as well as the organization administrator always has
access to all capture agents. For other users, access can be configured
by adding/removing the generated roles using the admin UI.
Here some user stories describing the reasoning behind this feature:

As person responsible for scheduling, I do not want other users to mess up with capture agents I'm responsible for
As a user, I want to be able to manage my recordings, including cutting of the video
As a user, I want to see upcoming recordings ("scheduled events"), so that I know what will be recorded for me in case other persons are responsible for the actual recording
As a institution, I might have several independent groups of people that are responsible for different sets of capture agents

Visually, this PR does not change much, but here are some impressions:
There are know three possibilities considering adding scheduled events:

The logged in user is system administrator (ROLE_ADMIN), tenant administrator () or has permissions to access all capture agents: Opencast will behave exactly the same as those roles have access to all capture agents

The logged in user is neither system administrator nor tenant administrator. He has only access rights to a subset of capture agents: The Add Event wizard looks still the same but the user can only select capture agents he has permissions to access

The logged in user has access to no capture agents at all: In that case, the Add Event Wizard has been adopted as this is the most common kind of users in Opencast setups that work with unprivileged users:

Users with no access to capture agents can see scheduled events based on the access policy, but they are not allowed to edit technical scheduling information:

This work is sponsored by SWITCH.

I will rebase & extend this PR shortly since #231 is now merged

Done

Hi @gregorydlogan
Thanks for taking the review!
I've realised that this PR is currently missing the documentation and created a PR for that. @krinnewitz Can you please merge that PR?

Argh... damn!
@krinnewitz I've provided some fixes to the community which once again break one of your pull requests... sorry for that :-)
Can you please fix the merge conflicts?

ok, done @staubesv

@krinnewitz, more conflicts.

I fixed the conflicts. Thanks @gregorydlogan for your review so far. plapadoo is on vacation this week, so there won't be any more fixes till Friday.

@gregorydlogan thanks for your review so far. I have resolved the issues you came up with. Feel free to continue the review :-)

Looks great guys.  Sole complaint is that the CA is still visible there's no obvious reason why I couldn't schedule against it as a user who does not have permissions to use it.  Is this by design?  Either way, this seems like a reasonable PR to me!

Thanks @gregorydlogan. You mean the CA's you don't have write access to shouldn't show up in the "locations" area of the adminUI? I have no strong feelings about that. Maybe you still want to see that the CA exists and which status it has?

@krinnewitz Yeah, fair enough.  This would be low impact even if the users aren't supposed to be able to see the agents, so let's see if we have complaints before we go to the work of fixing that :)


#18 - godaddy_domain_record.mydomain: data must be between 1..255 cha…

…racters in length

changed godaddy_domain_record.record.data validation if type is SOA (data must be an empty string)
if the GoDaddy API returns an an actual error, we log out the whole message body

The logging change is "bad", but it is definitely better than nothing. The problem is that errResp.Code and errResp.Message are now duplicates, but I cannot fix this (at least right now, this is the first time I touch Go code).
To have an idea what the issue can be, you need at least the field.

Hey @scream314 - Thanks for submitting a PR. I've added additional logging on error and changed the validation range to 0..255 in lieu of the pull request.


Add guidance about width limited task group

TaskGroup can technically support "tons of" work to be submitted into it, but this can be wasteful memory wise as those tasks will often just sit around doing nothing.
Show an example that is based on what we've shown before in wwdc talks like here:
https://developer.apple.com/videos/play/wwdc2023/10170/?time=687
That explains how to manually control the width of a task group.

One more much higher-level comment I just thought of. Is actually about incremental adoption?

Applied all comments and made it into a new file since it's not "incremental adoption" per se


Number normalizer

⏱ Before you start

[х] Have you checked if a similar PR has already been requested?
[х] Have you built and ran the app?

↗ Related/Fixed issues

Related: #246
Fixed: #246

📄 Description

Added number normalizer helper. It's static class, which can be used everywhere.
Also, I changed a bit repository overview.
💭 Motivation and Context

📸 Assets (if appropriate):

@hunterlan This is a bit fussy, but can you fix this?

no problem!

Already been merged tho, LGTM.

I've meant to use library such as DataSizeUnits.

@DeveloperWOW64 We should've used something library for this such as 'DataSizeUnits'.

@DeveloperWOW64 We should've used something library for this such as 'DataSizeUnits'.

Why? It's not necessary, current convertor is working well

Yeah. Of course, Thank you for your contribution. But I didn't want to use helpers but converters. The reason why is easy to convert value on XAML code.

It is not necessary to add observable strong properties for converted values. Converters on XAML is just able to be converted as you expected with no properties.


Docummentation added example

Goals :soccer:
Provide developers an example of how to obtain the http status code from the response.
Implementation Details :construction:
Took me a while to find the http code so I decided that could be good to have it on the Response Handling docummentation example.
Testing Details :mag:
Not needed

I'm sorry, I meant you should branch off of master, make your change, and then make a PR targeting master, not any of the alamofire5 branches.


Remove dual err check

Logging the error makes more sense than just returning as the error would be hidden instead of logged.
Enjoying the book and learning a lot :)

Good catch, I don't know how this happened! If the err is not used anywhere in the block, could you change that to if with a short statement?
like:
if err := stream.Send(req) != nil {
  log.Fatalf("unexpected error: %v", err)
}

Yeap done. I think I noticed some other places where the error handling was split rather than the short statement form, so I assumed it was a style preference!

Feel free to change the non-inlined error checks if you found others. Thank you for the contrib.


records not working as expected.

My assumptions are based on this gist from @sokra.
Specifically in Level 3:

Changes to the code base invalidate only affected chunks. Font, images, etc. are only invalidated on change.

Here's a quick screencast demonstrating what I'm seeing: https://youtu.be/zWbFosBhea8
And here's the code: https://github.com/kentcdodds/es6-todomvc/tree/lesson/hashing-even-better
I feel like I either must be doing something wrong, misunderstanding the feature, or there's a bug.

That's the tricky part... You missed one step:

Use an inlined manifest chunk to move the chunkhash mapping into the HTML file. (CommonsChunkPlugin with minChunks: Infinity and inline the resulting file)

Here it's explained with more details: https://github.com/webpack/webpack/tree/master/examples/chunkhash
Here is why:
Somewhere there must be a list of all chunkhashs so the runtime can load them. This list is included the entry chunk. This means in you case it's in the vendor file. As the chunkhashs list always changes when any chunkhash changes the vendor chunk is updated too often. The trick above inlines it into the html file.
There is an possible optimization to this process, but nobody implemented it yet. You can store the chunkhash map in a global variable (via plugin) and inline only this smaller json file into the HTML. This would inline less code, meaning more code is cached. But the difference is not soo big (1kb).

Hmmm... I'll give it a look tomorrow. Not certain I understand. But thanks for explaining!


Create an APi

Propose a new feature/change:
Create a generic api that can create tests and provide a callback to notify on result. ( similar to webpagetest)
Allow presentation formats of JSON, CSV, Html

eg: https://sites.google.com/a/webpagetest.org/docs/advanced-features/webpagetest-restful-apis

Hi @grantkemp,
If I've understood correctly you want an API for the online service, correct? If that's the case, there is no plan for that. The reason is that behind the scenes we use the same code than this project, we just have a bunch of containers running it and some code to orchestrate it. You can take a look in the online-service project.
I'd recommend you to use the command line directly, take a look at the getting started guide. There's already support for different result outputs by changing the formatter. If there are more you'd like to see, please open an issue for each one! The CLI will also allow you to tweak the configuration, what rules you want to run, what should be a warning or an error, etc.
Thanks!

Thanks @molant - If there is a plan to do this there is a tool we have used elsewhere that will allow scaling and also orchestrating it in multiple territories - I am happy to help with this - but wanted to make sure it was something that was going to be potentially considered.
Since its not on the list - will leave it for now - but thank you for sharing an awesome tool - I would like to include it in a talk I am doing at a conference in a few weeks.

I would like to include it in a talk I am doing at a conference in a few weeks.

@grantkemp Let us know if we can help with any information.


ContentNote link does not work

When you click on a content note in the timeline, the link redirects to "/lightning/r/AttachedContentNote/[ContentNoteId]/view" where it should be going to "/lightning/o/ContentNote/home?recordId=[ContentNoteId]" so the note is viewable with rich text editor.
Also, when you expand a ContentNote in Timeline, none of the selected fields resolve and preview.

Thanks for submitting this issue!
The link to the correct page is fixed in release 3.19 @silverlakezombie

Unfortunately, AttachedContentNote cannot be queried: https://developer.salesforce.com/docs/atlas.en-us.object_reference.meta/object_reference/sforce_api_objects_attachedcontentnote.htm
So we would need to create a workaround solution only for this object to be able to resolve fields. I'm afraid we will not pick this up on short notice...


SPDX license.

Compiler throws warning: Warning: SPDX license identifier not provided in source file. Before publishing, consider adding a comment containing "SPDX-License-Identifier: <SPDX-License>" to each source file. Use "SPDX-License-Identifier: UNLICENSED" for non-open-source code. Please see https://spdx.org for more information. even if license is correctly set.

#99

#99


__builtin_setjmp/__builtin_longjmp crashes when mrb_load_exec

Target platform: Windows 10 (21H2)
Toolchain: llvm-mingw-20230130-ucrt-x86_64

When I execute mrb_load_exec and it throws an exception, it crashes.
I noticed that the information here says that we should use the standard C library functions declared in <setjmp.h> in user code instead of the builtins.
So I tried editing the <throw.h>:
#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__)
#define MRB_SETJMP _setjmp
#define MRB_LONGJMP _longjmp
// #elif defined(__MINGW64__) && defined(__GNUC__) && __GNUC__ >= 4
// #define MRB_SETJMP __builtin_setjmp
// #define MRB_LONGJMP __builtin_longjmp
#else
#define MRB_SETJMP setjmp
#define MRB_LONGJMP longjmp
#endif

This time there was no crash. I hope this message is helpful~

It was fixed once, but then later reverted.
https://github.com/mruby/mruby/commit/4fc69ce3bc8f2ccac53a253ad02614380df491d4
Is it ok if this issue is not reopened?

This change made mrbtest to fail often. It was unacceptable for us.
If @LanzaSchneider reopens the issue, it's OK. But without further information, we can do little.


Importing macros from a different template file works, but from _self does not

Description
I've found that importing a macro using _self inside a nocache tag throws an error.
For example, if you have template_example.twig with a macro defined at the top, then this fails.
{% macro rendyEntry(entry) %}
    ...macro code here
{% endmacro %}

{% nocache %}
{% import _self as macros %}
...

However, importing them from a different file works as expected.
{% nocache %}
{% import "_partials/macros" as macros %}
...

Additional information

No-Cache version: 2.07
Craft CMS version: 3.7.7
PHP version: 7.3.28

Handy plugin! 👍

Thanks for reporting this, @mjatharvest. In that context _self is considered to be the nocache block, so it's correct that importing from _self didn't work, but it turned out that trying to import from the same template file by specifying the template name (which definitely should work) wasn't working either, so that should now be fixed in No-Cache 2.0.8.

Terrific, thanks for clarifying _self and for resolving the other issue as well 👍


protocol22: Bump Rust dependencies

Unfortunately I have had to disable the dependecy-check script since, after adding multi-protocol support, it completely falls apart when using RC versions.

Can confirm that locally when using this PR with quickstart the CLI is passing tests and deploying and constructing contracts!

Awesome!!

I will make an official release on Monday


Integrate ndfits.update for OVRO-LWA refraction parameters in FITS

Utilize ndfits.update within save_refraction_fit_param to streamline the inclusion of OVRO-LWA's refraction correction parameters in FITS files. This update ensures compatibility and efficient handling of both compressed and uncompressed FITS formats.
Revise header keywords to utilize the 'RFR' prefix, aligning with the FITS standard's 8-character limit for keyword names

I think we do not really need to add the new table columns for the refraction shifts.

Both directly modifying CRVALi/CRPIXi in the FITS header and adding table columns are feasible options. The choice is yours. The newly implemented ndfits.update function enhances our flexibility, allowing updates or additions of header keywords and new table columns, compatible with both compressed and uncompressed FITS. It's designed to facilitate writing information to FITS, as already outlined in refraction_correction. I believe @peijin94 can quickly implement a code to update CRVALi/CRPIXi using ndfits.update.

I have the following suggestion:
level-1: ndfits wrapped file, with px,py and shift_x, shift_y appended into the meta and 2 column.
CRVAL1, CRVAL2 both original ones
level-1.5: ndfits files but with data shifted aligned, remove shift_x and shift_y.
CRVAL1, CRVAL2 is [0,0]
In our server, we don't save level 1.5, because it is easy and fast to make 1.5 from 1.0.
For outside users, no need to know how the shift is done, and shift_x,y
they will get a simple level 1.5 fit we produced on request,
More experienced users can have level 1.0 and do refraction by themselves and tweak the refraction correction parameters.

This PR is good to merge from my point of view. @binchensun please proceed to merging if there are no other problems
Then I will proceed to modify the corresponding parts in ops


F#3342 treat string measure

Description
Druid's virtual expression can treat String result. For example, you can get the result of time_format(max(__time), 'yyyy-MM-dd') without error. But Metatron Discovery can only treat double measure. So we need to treat String type measure.
Related Issue :
https://github.com/metatron-app/metatron-discovery/issues/3342
How Has This Been Tested?

Create Caculation measure column in Druid.
The fomula looks like this : TIME_FORMAT( maxof(__time), 'yyyy-MM-dd' )
Draw Gridchart. Place caculation column on value shelf.
Make sure the date is represented correctly.

Need additional checks?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ x ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x ] I have read the CONTRIBUTING document.
[ x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ x ] I have added tests to cover my changes.

Additional Context

deploy to 1


gradle plugin: also list tasks in subprojects

With this fix gradle autocomplete also lists tasks in subprojects (separated by ':') and task and project names containing '-'. I also simplified the mathing by using awk.

cc @matthewmccullough

Same as in #3813, but also allows for hyphens and simplifies the math.
If this works, you have my :+1:

Hi, Robby went with #3813 instead, but this is still relevant since it reads hyphens and simplifies the number of commands used. Can you rebase so we can merge this as well?


add setter for version on ProjectPackage

This enables support for dynamically setting the package version
(e.g., from a plugin)
Resolves: python-poetry/poetry#5493
Resolves: python-poetry#

[x] Added tests for changed code.
[ ] Updated documentation for changed code.

I just added a test that the hash does not change and removed the todo. Iirc, we've added type ignore in such cases before.


Reproducing the results in the GMN paper

Hi, thanks for releasing the GMN code, which is really well written ! I am currently trying to use GMN, and when I run the sample code, I notice that the auc on validation is around 70%. Could u please give some hints about how to reproduce the results in the paper (i.e., auc around 90% for the GED task)?
Would increasing training step works? If so, how large should it be? Thanks !

Hi, if you train the model for 500k steps it should reach a reasonably good performance.  If you really care about this task you can train as much as you can afford and we haven't observed any overfitting as you can generate a enormous amount of training data.

Yeah, there is no overfitting ! Would u mind to tell a little more about other hyper-parameters including but not limited to batch_size? Since I still cannot reach 90%.

Hi, the batch size we used was 50 for this task, and the best performance was achieved sweeping over a few things, most importantly: training mode (pair vs triplet), share message passing layer parameters or not.  When training with pairwise loss, the margin was set to 0.1, and when training with triplet loss the margin was set to 1.0.  Learning rate etc. are just set to the default in the code.
I no longer remember the exact combination that led to the best performing model, but a grid search over these things should be able to get you close to the reported performance.

I have just rerun the experiments and was able to reproduce the paper results or better.  The most important hyperparameter for this task / metric is training mode, you should set it to triplet.  Training on pairs is quite a bit worse than training on triplets up to 500k steps.
In our experiments we set the batch size to 50 but this does not play as significant of a role as the training mode.


Add the Pipefiles : Pipfile and Pipefile.lock to manage the virtual env

with pipenv
Add a notebook conform_video.ipynb to generate numpy arrays from videos

not ready to merge: need to agree on the development environment


[Proposal] Change cancellation webhook to correct hook from Stripe API

As discussed in closed PR https://github.com/laravel/cashier/pull/150
There is corresponding doc changes here as well: https://github.com/laravel/docs/pull/1277

So just to confirm you have tested this with a real cancellation? :)

I've tested it with the Stripe Test API.
If you want to leave this PR for a few days - I'm happy to try this fork on my app and confirm.

I'll go ahead and merge it and I can test it too because I actually have a little Cashier test application (should probably open source that - heh). Once we've tested it I'll tag it.

Yeah this is at least partially broken. Firstly because since the subscription has been deleted from Stripe. Trying to delete it again will ALWAYS break.

Because cancel() is calling back to Stripe and re-telling it to cancel the subscription?
Hmmm... so is there a command in Cashier that only cancels a subscription on the Cashier side - without a call back to Stripe?
i.e.
if (($billable) && ($billable->subscribed())) {
         $billable->subscription()->cancelOnlyForCashier();
}

I fixed it in a recent commit.
On Wed, Mar 25, 2015 at 10:49 AM, Laurence Ioannou<EMAIL_ADDRESS>
wrote:

Because cancel() is calling back to Stripe and re-telling it to cancel
the subscription?
Hmmm... so is there a command in Cashier that only cancels a subscription
on the Cashier side - without a call back to Stripe?
i.e.
if (($billable) && ($billable->subscribed())) {
$billable->subscription()->cancelOnlyForCashier();
}
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/cashier/pull/151#issuecomment-86091301.

Cool - your worth more money... :)


Disable b374k

What should I disable so that this package doesn't work in my hosting?
I mean I want to disable the use of this package - what should I disable in my PHP or Nginx setting so that it will not work?
Please help, Thank you so much in advance

Don't allow php to interpret files in any of your upload directories.


Where the sources?

This repo looks like you have forgotten to commit sources

They're on different branches, master is currently empty.


No LIDAR Lite data through DISTANCE_SENSOR msg in QGC

Guys I'm not being able to get LIDAR Lite data through DISTANCE_SENSOR message in QGC in any way. I confirmed that the driver is working and publishing data, but can't get that data to be received by Mavlink msg in QGC. From PX4Flow sonar, in the other hand, I can receive DISTANCE_SENSOR msg with data when this one is connected.
Can anyone reproduce this problem or give a solution to this? I reviewed the code and it seems to be ok, but two or more pairs of eyes looking is always better. Tried with master branch and jgoppert:cart_pos_estimator branch, from which this PR is being made.

Yes. I have noticed this from the beginning.
When two at connected, only data from the sensor which bags the topic is coming through (i.e The driver which starts first)
We need a multi-sub in the mavlink message with subscription handles to 2 instance IDs for this to work, I think. (we should see alternating messages in QGC then)

By default, the normal orb_subscribe sets instance ID to zero, iirc, hence the Lidar data shouldn't be coming through in QGC even when its is only connected.
I'm unable to test the above hypothesis since my wiring is deep routed and I cannot  disconnect the Flow module.
Edit :  I could disable the flow driver startup which should prove my guess.

@mhkabir the problem is not just that. I'm aware that multi-sub is not working but the thing here is just that LIDARLite is now the only ranger I have connected and I can't get a DISTANCE_SENSOR msg received on QGC. Don't know what is happening, cause I think it was working in the first driver+DISTANCE_SENSOR support implementation.

By default, the normal orb_subscribe sets instance ID to zero, iirc, hence the Lidar data shouldn't be coming through in QGC even when its is only connected.

Since it is the only one connected, it should work since when I have only LIDAR Lite connected I get rangefinder0 when issuing ls /dev.

 The instance ID is set to 1 in the lidar driver, which mavlink sender shouldn't even subscribe to, the way its done currently.

I tried some other stuff like setting an instance here: https://github.com/PX4/Firmware/blob/master/src/modules/mavlink/mavlink_messages.cpp#L2219 but it didn't help.

Also, in the new implementation of @jgoppert PR of LPE, I set https://github.com/PX4/Firmware/blob/master/src/modules/mavlink/mavlink_messages.cpp#L2234 to msg.id = dist_sensor.id;

The instance ID is set to 1 in the lidar driver

Are you sure? Where is that defined in the default code?

Oh wait. Hmm. When I say ID I mean the ID which uORB assigns to the topic.
Then it should be according to order the drivers start up. Instance ID in the topic is different from what I mean.

@TSC21 try with latest LPE, I have it working.

@jgoppert you got msg in QGC with LIDAR data?

Yes.

Hmm ok I will test when possible. What did you change so it could work?

I set the subscription identifier to 1 in LPE. Also make sure you have the servo rail powered with a battery for the lidar.

Also make sure you have the servo rail powered with a battery for the lidar.

Yes that I always had.

I set the subscription identifier to 1 in LPE.

You mean that setting a subscription in a module sets the Mavlink stream? That's new to me xD Will try when I have the vehicle with me.

In the driver it was set to instance 1, so had to set the instance to 1 in
the sub. But now after syncing with master, had to set it back to 0. Never
had a problem seing it in qgc though.
On Jun 10, 2015 7:17 AM, "TSC21"<EMAIL_ADDRESS>wrote:

Also make sure you have the servo rail powered with a battery for the
lidar.
Yes that I always had.
I set the subscription identifier to 1 in LPE.
You mean that setting a subscription in a module sets the Mavlink stream?
That's new to me xD Will try when I have the vehicle with me.
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2297#issuecomment-110704238.

hmm.. what do you have in your rc.usb and extras.txt files?

I'm not usnig an extras.txt file. I'm using the ll40ls enable flag.

Ok, I looked into this. I tried starting the ll40ls first with the param and second with the extras.txt:
param: SENS_EN_LL40LS 1
ll40ls start pwm happens before mavlink is started and ll40ls gets the ORB class instance 0.
Mavlink subscribes to instance 0 and the message arrives in QGC.
extras.txt
The file extras.txt is called pretty much at the end of the startup, so after mavlink. This means mavlink creates the distance_sensor topic with instance 0. When the ll40ls finally starts up it sees the topic as already used/blocked and creates another one, so ORB class instance 1.
This means 0 does never get updated and mavlink/QGC does not get distance_sensor updates.
I think this is a flaw of the uORB multi pubsub that needs to be fixed. For now, the advice is to use the SENS_EN_LL40LS parameter instead of the extras.txt.

Yes, this is exactly what I observed. The uORB instance ID gets assigned in the order of driver startup.
For me, this complicates things even more, since the flow driver also bags a topic instance.

@mhkabir Yes, but I don't actually worry about Flow vs. Lidarlite right now but rather about mavlink vs. Lidarlite...

@LorenzMeier ping.

This should be fixed on master now - can you re-try?

I believe this is fixed.


CORS issue across frames

We tried setting up satellizer with the Twitter provider, but fail to get things to work. We run a client on one server and a backend API on another server. The latter does the actual token exchange.
The following error is thrown in popup.pollPopup:
Blocked a frame with origin "http://localhost:8000" from accessing a cross-origin frame

One thing we tried is adding CORS headers to the API backend, but this does not seem to fix the issue. The response headers are set as follows (as reported by Chrome):
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: HEAD, GET, POST, OPTIONS
Access-Control-Max-Age: 21600

Does anyone have experience with using satellizer in this kind of setup?

This is a CORS configuration example that works on Node.js/Express. I hope helps.
// Middleware CORS (Allow Origins)
var whitelist = ['http://localhost:9000', 'http://<IP_ADDRESS>:9000', 'http://mycompany.com' ];
app.use(cors({
  origin: function(origin, callback) {
    var originIsWhitelisted = whitelist.indexOf(origin) !== -1;
    callback(null, originIsWhitelisted);
  },
  credentials: true,
  allowedHeaders: ['Content-Type', 'Authorization', 'X-Requested-With', 'Accept', 'Origin' ]
}));

Thanks @carlosazaustre.
Same problem.
replace app.use(cors());
with your snippet, working now.

app.use(cors()); enables by default all origins. It's the same than:
app.use(cors({
  origin: '*'
}));

With a whiteList you only allow access to specific domains to your API.

Using app.use(cors()) doesn't seem to work for me, only the whitelist approach.... weird... any solution?

I also had the problem and wasted a whole day. My back-end is based on gServ (a Groovy REST server). The only way I could proceed was to disable it, but launching chrome with the command-line option --disable-web-security. More info at:

http://peter.sh/experiments/chromium-command-line-switches/
http://www.chromium.org/developers/how-tos/run-chromium-with-flags

I do recommend adding a few lines to the docs regarding CORS and how to deal with it.

Using app.use(cors()) doesn't seem to work for me, only the whitelist approach.... weird... any solution?

This won't help because CORS is a subset of the Same-Origin policy that applies only to AJAX calls.
I don't think it's possible to read the DOM via popup/iframe if server ports don't match.


Feature/assignment

flows summarize

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


FEATURE 1: Number Scroll to select donation - $5 to $99

Idea 1) One of those number flict scroll wheels
idea 2) A set of buttons.. [+$1] [+$5] [+$10] and a [Donate] button to trigger the final amount?

Added a NumberPicker in a8644af


Travis CI: Test off-by-default configurations as well

Just noticed that cmake -DUSE_OPENAL_BACKEND=ON has been broken (by me probably)...
Therefore, test all configuration in CI to avoid this happening in future.

Travis CI seems to disregard both Github push and pull request notifications...


Progress getting stuck, uploads not failing or completing

For users with slower connections, it has been reported that progress seems to "freeze" randomly and the upload doesn't fail.
The problem was tracked down to a race condition that can occur where the uploader incorrectly reports a number of chunk uploads in progress after the bandwidth monitor scales back concurrency.
The root cause of this issue was due to not having any error handling logic around web workers, as well as not having the ability to cancel an XHR for signatures.
This is a bug in 2.0.0 - 2.0.8.

Fixed in 2.0.9. Commit: 782e82aa2e21d203eb798773387ba066567055db.


Set Batch job names

Description
Set job names for Batch jobs, like "idseq-staging-12345-align", so they can be easier to identify and track in the Batch/ECS API.

btw you can also test this locally in Rails console with commands like Sample.last.pipeline_runs[0].pipeline_run_stages[0].host_filtering_command Sample.last.pipeline_runs[0].pipeline_run_stages[1].alignment_command


Update to Assistants example

This example lets you chat with an assistant. It goes through the basic steps of sending queries, doing runs, and retrieving results.

Thank you for PR!
It requires a bit of updates - I left few comments.

I was able to review this today. There are bunch of warnings and requires a bit cleanup, do you mind taking a look please?
I'd suggest leave the old example as it is and add this as a new example.
warning: unused imports: `ChatCompletionRequestSystemMessageArgs`, `CreateChatCompletionRequestArgs`, `CreateThreadAndRunRequestArgs`, `CreateThreadAndRunRequest`, `MessageContentTextObject`, `Role`, `config::OpenAIConfig`
 --> examples/assistants/src/main.rs:2:86
  |
2 | ...::{CreateMessageRequestArgs, CreateRunRequestArgs, CreateThreadRequestArgs, CreateThreadAndRunRequestArgs, CreateThreadAndRunRequest, CreateChatCompletionRequestArgs, ChatCompletionRequestSystemMessageArgs, Role, RunStatus, MessageContent, MessageContentTextObject, C...
  |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^                             ^^^^^^^^^^^^^^^^^^^^^^^^
3 | ...t, config::OpenAIConfig,
  |       ^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unreachable expression
   --> examples/assistants/src/main.rs:144:5
    |
39  | /     loop{
40  | |         println!("How can I help you?");
41  | |         //get user input
42  | |         let mut input = String::new();
...   |
142 | |         }
143 | |     }
    | |_____- any code following this expression is unreachable
144 |       Ok(())
    |       ^^^^^^ unreachable expression
    |
    = note: `#[warn(unreachable_code)]` on by default

warning: unreachable pattern
   --> examples/assistants/src/main.rs:136:17
    |
136 |                 _ => {
    |                 ^
    |
    = note: `#[warn(unreachable_patterns)]` on by default

warning: unused variable: `message_obj`
  --> examples/assistants/src/main.rs:52:13
   |
52 |         let message_obj = client
   |             ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message_obj`
   |
   = note: `#[warn(unused_variables)]` on by default

In addition few observations:

perhaps README can be updated too. For example it helps for me or anyone looking at this example to just cargo run and copy paste the inputs from README.
Ask user for deletion of assistant at the end of example?

Both are not required but good to have, makes it easier for anyone to run example and cleanup.

Do you think you could walk me through creating a function in the api. I can't quite figure it out. I'd like to add a clause that creates the function the ai calls to close the program and deconstruct the assistant and thread

Hey this is well written example, I see you put great effort in writing README as well. Many many thanks!
Thank you for your patience too, this has been a long wait!


Identical shares have different naming convention in oc10 and ocis

Describe the bug
When a user receives the identical share from different user the naming convention of the file/folder is different to that of oc10. Let's say a user has accepted the share foo from two different users,   in the case of oc10 the name will be foo, foo (2) while for ocis it's  foo, foo (1)
Steps to reproduce
Steps to reproduce the behavior:

As einstein create a folder foo/ and share it to user moss
As user moss accept the share
As user marie create a folder foo and share it to user moss
As moss accept the share

Expected behavior
I'm putting oc10 as expected. The shares should be displayed as foo and foo (2)
Actual behavior
The shares are displayed as foo and foo (1)

Setup
Latest master

Similar issue here: https://github.com/owncloud/ocis/issues/4289

Cosmetic, but could save support times 😄

Whatever we decide here also might have effect on the current implementation of file/folder conflict handling in web. More specifically, whenever we find a file or folder name that already exists (e.g. upload, copy, move, create new folder, create new file) we propose new file/folder names starting with (1).
E.g. if you have a folder test, try to upload a folder test and choose Keep both in conflict resolution, web will use test (1) as new folder name. I personally like that. Starting to count at (2) is not my personal preference.
For comparison, when creating copies of a file/folder in macOS finder, the behaviour is as follows:

have a folder test
copy and paste once -> copy receives name test copy
copy and paste another time -> copy receives name test copy 2
(nothing in parenthesis and the first printed number is 2, because the 1 is omitted on the first copy).

Would be interesting to see what Windows or Linux have to offer in that regard.
Since the file/folder name conflict handling in web and the share name duplicate handling in oCIS do in fact match, I'd vote for not changing it and accepting the difference between oCIS and oc10. Happy to discuss.
cc @tbsbdr @pmaier1

@SwikritiT could you please fill out the bug description text? 😇

My Ubuntu 20.04 UI does this:

If I don't want to Replace (overwrite) an existing file, then I have to enter a new name myself. There is no auto-generating of a new file name.

@SwikritiT could you please fill out the bug description text? innocent And for latest master a commit id would be beneficial (but IMO not needed for this particular issue).

Done!

@pmaier1 Please let us decide that quickly.
I am fine with starting with (1) for the first duplicate.

I am fine with starting with (1) for the first duplicate.

I'm fine with that, too.

@SwikritiT please sort out the tests so that they understand what is the numbering for oCIS (from 1) and oC10 (from 2).
Have a think about the best way to do it - do we put it in the test code, or explicitly in feature files or?

@SwikritiT please sort out the tests so that they understand what is the numbering for oCIS (from 1) and oC10 (from 2). Have a think about the best way to do it - do we put it in the test code, or explicitly in feature files or?

Okay!

I think there is still a bug with how the names are generated, the code does not seem to look into the current situation, but remembers the counter:

as user1 create a folder
as user2 create a folder with the same name
as user1 and user2 share the folder with user3
as user3 accept both shares
as user1 and user2 delete the shared folders
as user1 and user2 forget everything about what you have done
repeat steps 1-4
now for user3 the folders are called folder and folder (2)
repeat steps 5-6
repeat steps 1-4
now for user3 the folders are called folder and folder (3)

I think there is still a bug with how the names are generated, the code does not seem to look into the current situation, but remembers the counter:
1. as user1 create a folder

2. as user2 create a folder with the same name

3. as user1 and user2 share the folder with user3

4. as user3 accept both shares

5. as user1 and user2 delete the shared folders

6. as user1 and user2 forget everything about what you have done

7. repeat steps 1-4

8. now for user3 the folders are called `folder` and `folder (2)`

9. repeat steps 5-6

10. repeat steps 1-4

11. now for user3 the folders are called `folder` and `folder (3)`

This seems to be a duplicated of: https://github.com/owncloud/ocis/issues/8471 which has been fixed.
For sharing NG there is a related issue, we're currently trying to address: #8961


Table directive throwing error + syntax errors in sample data

I've thrown together a quick Plunkr that should be a minimal usage of the table plugin:
http://plnkr.co/edit/CF4chERLDEuZE4z76Zs9?p=preview
You get a JS error in the console Expression 'undefined' used with directive 'ganttTable' is non-assignable!
Digging into the code, it seems that:
api.directives.on.new(scope, function(directiveName, sideContentScope, sideContentElement) {
  if (directiveName === 'ganttSideContent') {

(line 922 in assets/angular-gantt-plugins.js) never fires as the API never sees a ganttSideContent  directive get created, hence I can't seem to get any side menu.
I've tested against the latest released version and against the current code in master.
Finally, the example code on this page: https://www.angular-gantt.com/configuration/data/ has incorrect single quotes around the keys in the example data:
$scope.data = [{name: 'Milestones', height: '3em', sortable: {enabled: false}, classes: 'gantt-row-milestone', color: '#45607D', data: 'Can contain any custom data or object',
  tasks: [
    {name': 'Kickoff', color: '#93C47D', from: '2013-10-07T09:00:00',

The "name" key under the tasks array has a single quote.

Thanks for reporting this issue @Rodeoclash.
I've fixed the docs part, and investigating the table one. The API IS fired, but for some reason there something undefined somewhere :)

Ok, i've found the fix, it's only one character long :)

No problem, thanks for the quick fix!


[master] RI-90 Create ironic config script for gating

This reverts the previous patch into master.

Can one of the admins verify this patch?

recheck_cit_xenial_deploy_with_swift

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

tempest image failure, looking into it

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

recheck_cit_xenial_deploy_swift

It looks like this is failing on this known issue: https://rpc-openstack.atlassian.net/browse/RO-2781

@odyssey4me addressed


Empty block regression test fix

This PR should fix the empty_block_validation_regression test and make it test what it was supposed to test again.
Closes #3513

bors r+


hide /org section from search engines

Summary of changes
Asana Ticket: No Ticket
Prevent search engines from indexing pages under the /org directory.

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

@phildarnowsky I had originally added a function to apps/site/lib/site_web/views/helpers.ex with the function below, but I thought it might be overkill for this purpose. Let me know what you think -- thanks!
  @doc """
  Determine if a requested path begins with /org/
  """
  @spec is_org_page(String.t()) :: boolean
  def is_org_page("/org/" <> _), do: true
  def is_org_page(_), do: false

@ryan-mahoney yeah overkill IMHO


desync basemap

Hi
when using the plugin my basemaps are desync: tiles around print area aren't refreshed and zoom is impossible (no console error). A workaround is to manually select another basemap after printing but I don't know how to code that in my page.
I've attached my map and code.
Greetings
bug_print_fdc_google.zip

Hi
Thanks for reporting this issue. Problem solved in current version v0.3.9, please check it out and write me it something is still not working as expected.
Regards,
Igor

It's all good now. Thx for support.


Change type of EtcdDiskSizeGB from string to int

What this PR does / why we need it:
This PR changes the data type of EtcdDiskSizeGB from string to int.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Fixes #2231
Special notes for your reviewer:
NA

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: shubheksha sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

You'll want to change the parameter type here

Yep, identified it. It needs to be changed in the part file.

As I feared, if we upgrade a cluster previously deployed using the prior (string) type spec:
time="2018-03-05T20:20:47Z" level=info msg=validating...
time="2018-03-05T20:20:50Z" level=info msg="Error returned by LoadContainerService: json: cannot unmarshal string into Go struct field Properties.orchestratorProfile of type int"
time="2018-03-05T20:20:50Z" level=fatal msg="error parsing the api model: json: cannot unmarshal string into Go struct field Properties.orchestratorProfile of type int"

@jackfrancis, ah right - this will break previously deployed clusters using the string type. How can we get around this? Is there any way we can use the string type for backward compatibility but use int going forward?

@shubheksha Firstly, thanks for tackling this! I think we'll want to address this more generally in terms of "how do we adapt upgrade implementation so that it doesn't depend literally on the type specification of the template at the time of initial deployment". That will unblock lots of future issues like this one.

Closing this PR and the referring issue as well.


New Check for API Audience

A new check for the Zalando rule 219 - Must provide API Audience has to be implemented.

@roxspring We introduced two new rules (215 should, 219 must). Just wanted to inform you. You will probably want to deactivate them in your installation.


"Calendar file not found" error after servers merging

Add option to regenerate all users calendars.
https://samgozman.sentry.io/issues/4118727365/?project=4504271049523200&referrer=project-issue-stream

If calendar is exist in db but not in FS - force recreation


pathlib support for skbio.io

This PR addresses issue #2058, #1983, and #1421 with an extremely simple fix to add support for Python's pathlib module. Based on the examples from issues #2058 and #1983, I believe this enables skbio.io.read and skbio.io.write both to handle Path objects. Please test rigorously as this seems almost too easy!
Please complete the following checklist:

[x] I have read the contribution guidelines.

[ ] I have documented all public-facing changes in the changelog.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied.

It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[x] This pull request does not include code, documentation, or other content derived from external source(s).

Note: This document may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

@wasade Yeah that smoke test seems to work fine, thanks for the suggestion.


[release-4.14] OCPBUGS-15168: fix(oauth): Do not proxy IBM Cloud IAM endpoints

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

Details in this issue:
https://issues.redhat.com/browse/OCPBUGS-15168

Details in this issue:
https://issues.redhat.com/browse/OCPBUGS-15168

/hold
these might not be needed if main auto syncs still

/refresh


Protocol incompatability in connect()

Hello,
I've interesting issue here, which I've managed to solve, but I thought I'd flag it anyway.
I've got two domain controllers, which are one and and the same, but referenced by an External IP and Internal IP;
'domain_controllers' => ['xx.xxx.xxx.xxx', '192.168.22.x']
In development, the LDAP connection works out of the box on the local IP.
In production, the connection fails on the External IP (the usual Bind error) and I managed to narrow it to this;
http://php.net/manual/en/function.ldap-connect.php#75571
Removing the prefixed protocol of ldap::// in favour of the standalone IP means I can now connect.
We are on;
LSB_VERSION=base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch```

I honestly don't know if this is a bug, or some manifestation of a Networking/NAT issue our side.

Being a bit new to Laravel, I wonder if you could give me an example of how to extend Ldap::connect() to make my own connection. Right now, I'm reverting to changing the PROTOCOL value in the ConnectionInterface.

Thanks,
Mike

How would I (elegantly) change/override that PROTOCOL const?

Hi @moth, this is a good question.
Either way if it's an issue on your end or not, I think this use case should be covered anyway just for availability.
I've added these methods in the root Adldap2 repository which you can then override in your own connection class: https://github.com/Adldap2/Adldap2/commit/2e439d96605a5692fa39b3c324ebb80364ad03ad.
Once you've created your own connection class and extended the Adldap\Connections\Ldap class, you can specify it in your config/adldap.php configuration:
use Adldap\Connections\Ldap as BaseConnection;

class Ldap extends BaseConnection
{
    protected getProtocol()
    {
        //
    }
}

// config/adldap.php

'connection' => App\Connections\Ldap::class,

Thanks. Sorry to be dim, but do you have any docs around the creation of that connection class? I'm unsure as to where it should be sat in my App.

No problem. That's really up to you where you want the class to be located. I guess that's the beauty of Laravel, it's all up to you and what works in your application.
Here's the small amount of documentation for extending / creating a new connection: https://github.com/Adldap2/Adldap2/blob/master/docs/connecting.md#custom-connections.


[Feature Request] Locally build documentation for API preview

Motivation
To fully understand the API of torchrl, maybe it can be a temporal solution for users to build docs locally to review the API
Solution
A make doc command like cd docs && make html && cd _build/html && python3 -m http.server
Checklist

[x] I have checked that there is no similar issue in the repo (required)

You're totally right, @nicolas-dufour suggested the same. The doc needs some cleaning but once it's done we'll take care of this.
On the long term the doc will sit on PyTorch (hopefully during next fall) so we're not considering using a dedicated domain or readthedocs.


DPLA bulk data compare errors

Error when retrieving DPLA bulk data compare for DataTables.
Additionally, as these could get large, might be helpful to provide export of comparison:

combined spreadsheet of matches and misses, with record_id?

Fixed.


SwiftEmitModule normal x86_64 Emitting\ module\ for\ rnmapbox_maps (in target 'rnmapbox-maps' from project 'Pods')

SwiftEmitModule normal x86_64 Emitting\ module\ for\ rnmapbox_maps (in target 'rnmapbox-maps' from project 'Pods')
This error, I have seen in a large project and even started a project from scratch and I still see it. I have spent about 18 hours so far trying to investigate a solution with no luck.  Hopefully someone here has seen or someone can help. Thanks.

fixed with moving RNMaps variable to top of podfile. if anyone runs into this.
`$RNMapboxMapsImpl = 'mapbox'
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
platform :ios, '12.0'`


Update clr-enabled-server-configuration-option.md

add missing quote
correct capitalization

@aharpervc : Thanks for your contribution to the Azure documentation! The author, @MikeRayMSFT, has been notified to review your proposed change.

See the terminology usage at Common Language Runtime (CLR). https://docs.microsoft.com/en-us/dotnet/standard/clr

I see that that example is sentence case in body text. And I can certainly update this PR for sentence casing. However, it's listed here as title case https://www.visualstudio.com/license-terms/ecma-c-common-language-infrastructure-standards/ and in the linked docs here, "Common Language __" is always title cased even in body text.
Since these docs have been around for awhile, is it a recent development that "common language __" should always be sentence cased?

@aharpervc : Thanks for your contribution to the Azure documentation! The author, @MikeRayMSFT, has been notified to review your proposed change.

@aharpervc - I'm actually running this by a terminologist here to verify. I appreciate you bringing the inconsistency to our attention. I'm going to hold this to verify.
Thanks,
Mike

The terminologist answer is that common language runtime is not a name and so it should be lowercase. Thanks again for the submission. #sign-off


Remove Psychosis Gun ammo limit

Have as many allies as you want! I'm guessing the limit on the N64 was for RAM reasons, which isn't an issue anymore! Let's have as many allies as we want! You can now have your own personal army following you around.

It's not just the RAM. The game has a limited amount of character slots, so theoretically on levels with respawning guards you can manage to crash it by doing this long enough. It's not that big of a deal though.


The logic router SLL routing congestion problem? when "Build the SDx Project"

First of all, thank you for the awesome open source project!
I got the same Errors repeatedly several times when generating bitstream, and cannot solve them on my own. This is my first time using Xilinx products. Could you help me to locate the errors? Thank you so much!
My environment is:

Ubuntu 18.04
Vitis 2020.2
Alveo U250

I follow the tutorial of README before, modified some variables or files like vu9p.json, SA_ROWS, etc. They all running well, except the  "C simulation" and  "Bitstream".
1. C simulation stack but hls verified success?
It takes near one hour to finish the C simulation, according to the vitis_hls.log file, but the command vitis_hls -f hls_script.tcl stacked with info HW acceleration..., and the csim.exe program running backend nonstop with increasing memory allocation continually to hundreds of GB.  The `hls_script.tcl' file is modified as follows.

Click to show modified "hls_script.tcl"
open_project pose_prj
set_top top_kernel
add_files 2DPE_U1.cpp
add_files 2DDataFeedCollect_U1.cpp
add_files 2DDataCollect_U1.cpp
add_files 2DDataFeed_U1.cpp
add_files common_header_U1.h
add_files cnn_sw.cpp
add_files kernel.cpp
add_files util.h
add_files -tb tb_pose.cpp -cflags "-Wno-unknown-pragmas" -csimflags "-Wno-unknown-pragmas"
open_solution "solution1" -flow_target vitis
set_part {xcu250-figd2104-2L-e}
create_clock -period 10 -name default
config_interface -m_axi_addr64 -m_axi_alignment_byte_size 64 -m_axi_latency 64 -m_axi_max_widen_bitwidth 512 -m_axi_offset off -register_io off
config_rtl -register_reset_num 3
#source "./pose_prj/solution1/directives.tcl"
csim_design
# csynth_design
# cosim_design
# export_design -format ip_catalog

exit

But when I open the pose_prj and solution1 in the Vitis HLS IDE windows program and run the C simulation, it finished normally!
This is not a normal situation, right?
2. Bitstream logic routing failed
The error info from v++ log/bash is as follows when I run "make all" to generate the bitstream under the System directory.

Click to show log/bash Error Info
...
[23:59:25] Starting logic routing..
[00:04:32] Phase 1 Build RT Design
[00:17:49] Phase 2 Router Initialization
[00:17:49] Phase 2.1 Fix Topology Constraints
[00:19:51] Phase 2.2 Pre Route Cleanup
[00:21:23] Phase 2.3 Global Clock Net Routing
[00:23:56] Phase 2.4 Update Timing
[00:38:46] Phase 2.5 Update Timing for Bus Skew
[00:38:46] Phase 2.5.1 Update Timing
[00:45:54] Phase 3 Initial Routing
[00:45:54] Phase 3.1 Global Routing
[00:45:54] Phase 3.1.1 Global Routing
[00:45:54] Phase <IP_ADDRESS> Build GR Node Graph
[00:51:01] Phase <IP_ADDRESS> Run Global Routing
[03:36:22] Run vpl: Step impl: Failed
[03:36:23] Run vpl: FINISHED. Run Status: impl ERROR

===>The following messages were generated while processing /home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1 :
ERROR: [VPL 35-3339] The router is unable to resolve localized SLL routing demand. Use SSI placer directives or location constraints that reduce localized SLL routing congestion.
ERROR: [VPL 35-368] Router failed to resolve global congestion
ERROR: [VPL 18-1000] Routing results verification failed due to partially-conflicted nets (Up to first 10 of violated nets):  level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_19_fifo2_local_U/internal_full_n_i_2__1253_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_19_fifo2_local_U/mOutPtr_reg_n_0_[0] level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_1_fifo0_local_U/mOutPtr[1]_i_3__681_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_CS_fsm_state36 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/done_reg_275_reg[0]_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0_i_2__32_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_enable_reg_pp0_iter0
ERROR: [VPL 60-773] In '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/runme.log', caught Tcl error:  problem implementing dynamic region, impl_1: route_design ERROR, please look at the run log file '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/runme.log' for more information
WARNING: [VPL 60-732] Link warning: No monitor points found for BD automation.
ERROR: [VPL 60-704] Integration error, problem implementing dynamic region, impl_1: route_design ERROR, please look at the run log file '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/runme.log' for more information
ERROR: [VPL 60-1328] Vpl run 'vpl' failed
ERROR: [VPL 60-806] Failed to finish platform linker
INFO: [v++ 60-1442] [03:36:24] Run run_link: Step vpl: Failed
Time (s): cpu = 00:09:18 ; elapsed = 11:57:20 . Memory (MB): peak = 1592.766 ; gain = 0.000 ; free physical = 305154 ; free virtual = 335238
ERROR: [v++ 60-661] v++ link run 'run_link' failed
ERROR: [v++ 60-626] Kernel link failed to complete
ERROR: [v++ 60-703] Failed to finish linking
INFO: [v++ 60-1653] Closing dispatch client.
makefile:87: recipe for target 'binary_container_1.xclbin' failed
make: *** [binary_container_1.xclbin] Error 1

The run log file mentioned by log/bash Error info above FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/runme.log prints details error info as follows.

Click to show Tcl and route_design ERROR from "runme.log"
... ...

Time (s): cpu = 00:33:41 ; elapsed = 00:24:17 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 407946 ; free virtual = 437010
Netlist sorting complete. Time (s): cpu = 00:00:03 ; elapsed = 00:00:04 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 408048 ; free virtual = 437112
Netlist sorting complete. Time (s): cpu = 00:00:00.84 ; elapsed = 00:00:00.84 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 407441 ; free virtual = 436506
INFO: [Physopt 32-603] Post Physical Optimization Timing Summary | WNS=-2.056 | TNS=-25811.687 |

Summary of Physical Synthesis Optimizations
============================================

-------------------------------------------------------------------------------------------------------------------------------------------------------------
|  Optimization   |  WNS Gain (ns)  |  TNS Gain (ns)  |  Added Cells  |  Removed Cells  |  Optimized Cells/Nets  |  Dont Touch  |  Iterations  |  Elapsed   |
-------------------------------------------------------------------------------------------------------------------------------------------------------------
|  DSP Register   |          0.000  |          0.000  |            0  |              0  |                     0  |           4  |           1  |  00:00:23  |
|  Critical Path  |          0.169  |         88.503  |           15  |              0  |                    38  |           0  |           2  |  00:07:45  |
|  Total          |          0.169  |         88.503  |           15  |              0  |                    38  |           4  |           3  |  00:08:13  |
-------------------------------------------------------------------------------------------------------------------------------------------------------------

Netlist sorting complete. Time (s): cpu = 00:00:00.93 ; elapsed = 00:00:00.94 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 407202 ; free virtual = 436268
Ending Physical Synthesis Task | Checksum: 1d23b120a

Time (s): cpu = 00:35:36 ; elapsed = 00:26:11 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 407054 ; free virtual = 436120
INFO: [Common 17-83] Releasing license: Implementation
793 Infos, 609 Warnings, 8 Critical Warnings and 0 Errors encountered.
phys_opt_design completed successfully
phys_opt_design: Time (s): cpu = 00:57:40 ; elapsed = 00:32:15 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 408942 ; free virtual = 438008
Command: route_design
Attempting to get a license for feature 'Implementation' and/or device 'xcu250'
INFO: [Common 17-349] Got license for feature 'Implementation' and/or device 'xcu250'
INFO: [DRC 23-27] Running DRC with 8 threads
INFO: [Vivado_Tcl 4-198] DRC finished with 0 Errors
INFO: [Vivado_Tcl 4-199] Please refer to the DRC report (report_drc) for more information.
Running DRC as a precondition to command route_design
INFO: [DRC 23-27] Running DRC with 8 threads

... (lots of similar WARNING as follows) ...
WARNING: [DRC AVAL-318] DSP_dynamic_PCIN_tieoff_only_on_bottom_sites: The DSP48E2 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_compute_wrapper144_U0/grp_U1_compute_fu_20/fadd_32ns_32ns_32_7_full_dsp_1_U817/top_kernel_ap_fadd_5_full_dsp_32_u/inst/i_synth/ADDSUB_OP.ADDSUB/DSP.OP/DSP48E1_BODY.ALIGN_ADD/DSP2/i_no_versal_es1_workaround.DSP is not placed on a bottom site of the device, has OPMODE[5:4] driven by active nets (value '01' uses PCIN bus), and ties some or all of its PCIN bus pin(s) to GND, but that connectivity is only available for the bottom DSP site. Care should be taken for the effect on that PCIN if the DSP site below it is used.
... ...

INFO: [Common 17-14] Message 'DRC AVAL-318' appears 100 times and further instances of the messages will be disabled. Use the Tcl command set_msg_config to change the current settings.
INFO: [Vivado_Tcl 4-198] DRC finished with 0 Errors, 872 Warnings
INFO: [Vivado_Tcl 4-199] Please refer to the DRC report (report_drc) for more information.

Starting Routing Task

Router Utilization Summary
  Global Vertical Routing Utilization    = 0.00062449 %
  Global Horizontal Routing Utilization  = 0.000658939 %
  Routable Net Status*
  *Does not include unroutable nets such as driverless and loadless.
  Run report_route_status for detailed report.
  Number of Failed Nets               = 1963685
    (Failed Nets is the sum of unrouted and partially routed nets)
  Number of Unrouted Nets             = 1764108
  Number of Partially Routed Nets     = 199577
  Number of Node Overlaps             = 2

Phase 3 Initial Routing

Phase 3.1 Global Routing
Number SLLs per Column: 1440
Estimated SLL Demand Per Column:
  SLR [2-3]        1 (  0%)     4 (  0%)     8 (  1%)    16 (  1%)    14 (  1%)    19 (  1%)    59 (  4%)   616 ( 43%)   820 ( 57%)   656 ( 46%)   123 (  9%)   180 ( 12%)   135 (  9%)   208 ( 14%)   422 ( 29%)    41 (  3%)  Demand:  3322 Available: 23040 Utilization(%): 14.42
  SLR [1-2]        1 (  0%)     1 (  0%)     1 (  0%)   219 ( 15%)   436 ( 30%)   613 ( 43%)   325 ( 23%)   695 ( 48%)  1265 ( 88%)   501 ( 35%)    22 (  2%)    10 (  1%)    73 (  5%)     0 (  0%)     0 (  0%)     0 (  0%)  Demand:  4162 Available: 23040 Utilization(%): 18.06
  SLR [0-1]        0 (  0%)     0 (  0%)     0 (  0%)   217 ( 15%)   324 ( 22%)   369 ( 26%)    21 (  1%)   370 ( 26%)  1258 ( 87%)   494 ( 34%)    24 (  2%)    12 (  1%)    74 (  5%)     1 (  0%)     0 (  0%)     0 (  0%)  Demand:  3164 Available: 23040 Utilization(%): 13.73

Phase 3.1.1 Global Routing

Phase <IP_ADDRESS> Build GR Node Graph
Phase <IP_ADDRESS> Build GR Node Graph | Checksum: 18ac746d9

Time (s): cpu = 01:53:03 ; elapsed = 00:46:59 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 375726 ; free virtual = 404795

Phase <IP_ADDRESS> Run Global Routing

Global Iteration: 0
    Total GR Congestion: 5757
    Total GR Congestion: 2344
    Total GR Congestion: 1698
    Total GR Congestion: 1103
    Total GR Congestion: 861
ERROR: [Route 35-3339] The router is unable to resolve localized SLL routing demand. Use SSI placer directives or location constraints that reduce localized SLL routing congestion.
ERROR: [Route 35-368] Router failed to resolve global congestion
Phase <IP_ADDRESS> Run Global Routing | Checksum: 11edc1b5d

Time (s): cpu = 04:41:41 ; elapsed = 03:09:30 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 309478 ; free virtual = 338553
Phase 3.1.1 Global Routing | Checksum: 1f686373d

Time (s): cpu = 04:43:18 ; elapsed = 03:11:09 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 312449 ; free virtual = 341505
Phase 3.1 Global Routing | Checksum: 1f686373d

Time (s): cpu = 04:44:51 ; elapsed = 03:12:42 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 311773 ; free virtual = 340830
Phase 3 Initial Routing | Checksum: 1f686373d

Time (s): cpu = 04:46:23 ; elapsed = 03:14:14 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 311072 ; free virtual = 340131

Router Utilization Summary
  Global Vertical Routing Utilization    = 0.00062449 %
  Global Horizontal Routing Utilization  = 0.000658939 %
  Routable Net Status*
  *Does not include unroutable nets such as driverless and loadless.
  Run report_route_status for detailed report.
  Number of Failed Nets               = 1963685
    (Failed Nets is the sum of unrouted and partially routed nets)
  Number of Unrouted Nets             = 1764108
  Number of Partially Routed Nets     = 199577
  Number of Node Overlaps             = 2

Congestion Report
North Dir 1x1 Area, Max Cong = 11.2676%, No Congested Regions.
South Dir 1x1 Area, Max Cong = 5.6872%, No Congested Regions.
East Dir 1x1 Area, Max Cong = 3.57143%, No Congested Regions.
West Dir 1x1 Area, Max Cong = 17.3077%, No Congested Regions.

------------------------------
Reporting congestion hotspots
------------------------------
Direction: North
----------------
Congested clusters found at Level 0
Effective congestion level: 0 Aspect Ratio: 1 Sparse Ratio: 0
Direction: South
----------------
Congested clusters found at Level 0
Effective congestion level: 0 Aspect Ratio: 1 Sparse Ratio: 0
Direction: East
----------------
Congested clusters found at Level 0
Effective congestion level: 0 Aspect Ratio: 1 Sparse Ratio: 0
Direction: West
----------------
Congested clusters found at Level 0
Effective congestion level: 0 Aspect Ratio: 1 Sparse Ratio: 0

INFO: [Route 35-580] Design has 10 pins with tight setup and hold constraints.

The top 5 pins with tight setup and hold constraints:

+--------------------------+--------------------------+----------------------------------------------------------------------------------------------------------+
|       Launch Clock       |      Capture Clock       |                                                 Pin                                                      |
+--------------------------+--------------------------+----------------------------------------------------------------------------------------------------------+
| clk_kernel_00_unbuffered_net |clk_kernel_00_unbuffered_net |level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_res_transfer_wrapper181_U0/grp_U1_res_transfer_fu_22/ap_enable_reg_pp1_iter0_reg/D|
| clk_kernel_00_unbuffered_net |clk_kernel_00_unbuffered_net |level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/weight_load_U0/ap_enable_reg_pp18_iter0_reg/D|
| clk_kernel_00_unbuffered_net |clk_kernel_00_unbuffered_net |level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_op0_transfer_wrapper54_U0/grp_U1_op0_transfer_fu_20/ap_enable_reg_pp0_iter0_reg/D|
| clk_kernel_00_unbuffered_net |clk_kernel_00_unbuffered_net |level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/start_for_upsample_U0_U/internal_full_n_reg/D|
| clk_kernel_00_unbuffered_net |clk_kernel_00_unbuffered_net |level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_res_transfer_wrapper181_U0/grp_U1_res_transfer_fu_22/ap_enable_reg_pp1_iter1_reg/D|
+--------------------------+--------------------------+----------------------------------------------------------------------------------------------------------+

File with complete list of pins: tight_setup_hold_pins.txt

INFO: [Route 35-17] Router encountered errors. Please check the log file for details
ERROR: [Constraints 18-1000] Routing results verification failed due to partially-conflicted nets (Up to first 10 of violated nets):  level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_19_fifo2_local_U/internal_full_n_i_2__1253_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_19_fifo2_local_U/mOutPtr_reg_n_0_[0] level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/PE2_1_fifo0_local_U/mOutPtr[1]_i_3__681_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_CS_fsm_state36 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper431_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/done_reg_275_reg[0]_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2ReadData0_fu_249/ap_enable_reg_pp0_iter0_i_2__32_n_0 level0_i/level1/level1_i/ulp/top_kernel_1/inst/grp_engine_fu_248/conv_U0/grp_kernel_fu_236/U1_DataCollect2Engine0_wrapper432_U0/grp_U1_DataCollect2Engine0_fu_24/grp_U1_Data2WriteData0_fu_227/ap_enable_reg_pp0_iter0

Time (s): cpu = 04:53:21 ; elapsed = 03:18:55 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 310951 ; free virtual = 340013
INFO: [Common 17-83] Releasing license: Implementation
807 Infos, 709 Warnings, 8 Critical Warnings and 3 Errors encountered.
route_design failed
route_design: Time (s): cpu = 05:19:09 ; elapsed = 03:29:06 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 310951 ; free virtual = 340013
Writing placer database...
INFO: [Timing 38-480] Writing timing data to binary archive.
Writing XDEF routing.
Writing XDEF routing logical nets.
Writing XDEF routing special nets.
Write XDEF Complete: Time (s): cpu = 00:06:08 ; elapsed = 00:02:02 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 302574 ; free virtual = 336389
INFO: [Common 17-1381] The checkpoint '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/level0_wrapper_routed_error.dcp' has been generated.
write_checkpoint: Time (s): cpu = 00:19:33 ; elapsed = 00:13:29 . Memory (MB): peak = 35086.227 ; gain = 0.000 ; free physical = 304775 ; free virtual = 334860
ERROR: [Common 17-39] 'route_design' failed due to earlier errors.

INFO: [Common 17-206] Exiting Vivado at Mon Jan 11 03:36:22 2021...
[Mon Jan 11 03:36:22 2021] impl_1 finished
WARNING: [Vivado 12-8222] Failed run(s) : 'impl_1'
wait_on_run: Time (s): cpu = 00:00:22 ; elapsed = 09:31:02 . Memory (MB): peak = 5117.031 ; gain = 0.000 ; free physical = 305002 ; free virtual = 335081
INFO: [OCL_UTIL] internal step: log_generated_reports for implementation 'output/generated_reports.log'
INFO: [OCL_UTIL] internal step: problem implementing dynamic region, impl_1: route_design ERROR
INFO: [OCL_UTIL] status: fail (route_design ERROR)
INFO: [OCL_UTIL] log: /home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/runme.log
ERROR: caught error: problem implementing dynamic region, impl_1: route_design ERROR, please look at the run log file '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/runme.log' for more information
[03:36:22] Run vpl: Step impl: Failed
INFO: [OCL_UTIL] current step: vpl.impl failed. To rerun the existing project please use --from_step vpl.impl
problem implementing dynamic region, impl_1: route_design ERROR, please look at the run log file '/home/jumpchan/master/develop/FlexCNN/SDx_project/System/_x/_xocc_link_binary_container_1/vivado/vpl/prj/prj.runs/impl_1/runme.log' for more information
INFO: [Common 17-206] Exiting Vivado at Mon Jan 11 03:36:22 2021...

The makefile under System dir is as follows

Click to show modified "makefile"
#
# this file was created by a computer. trust it.
#

XILINX_SDX = /tools/Xilinx/Vitis/2020.2
# compiler tools
# XILINX_VIVADO_HLS ?= $(XILINX_SDX)/Vivado_HLS
XILINX_VIVADO_HLS ?= /tools/Xilinx/Vitis_HLS/2020.2

#SDX_CXX ?= $(XILINX_SDX)/bin/xcpp
SDX_CXX ?= g++
#XOCC ?= $(XILINX_SDX)/bin/xocc
XOCC ?= $(XILINX_SDX)/bin/v++
RM = rm -f
RMDIR = rm -rf

#SDX_PLATFORM = xilinx_aws-vu9p-f1-04261818_dynamic_5_0
#SDX_PLATFORM = xilinx_vcu1525_xdma_201830_1
#SDX_PLATFORM = xilinx_u250_gen3x16_base_3
#SDX_PLATFORM = xilinx_u250_gen3x16_xdma_shell_3_1
SDX_PLATFORM = xilinx_u250_gen3x16_xdma_3_1_202020_1
XILINX_XRT = /opt/xilinx/xrt

# host compiler global settings
#CXXFLAGS += -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/opt/tools/xilinx/SDx/2018.3/runtime/include/1_2/ -I/opt/tools/xilinx/SDx//2018.3/include/ -O2 -Wall -c -fmessage-length=0 -std=c++14 -I/opt/xilinx/xrt/include/
CXXFLAGS += -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/tools/Xilinx/Vitis/2020.2/include/ -I/tools/Xilinx/Vivado/2020.2/include/ -O2 -Wall -c -fmessage-length=0 -std=c++14 -I/opt/xilinx/xrt/include/
#LDFLAGS += -L/opt/xilinx/xrt/lib/ -lxilinxopencl -lpthread -lrt -lstdc++ -L/opt/tools/xilinx/SDx//2018.3/runtime/lib/x86_64
LDFLAGS += -L/opt/xilinx/xrt/lib/ -lxilinxopencl -lpthread -lrt -lstdc++ -L/tools/Xilinx/Vitis/2020.2/lib/lnx64.o

# kernel compiler global settings
XOCC_OPTS = -t hw --save-temps --report system --max_memory_ports top_kernel --platform $(SDX_PLATFORM) -O3 --sp top_kernel_1.m_axi_gmem1:bank0 --sp top_kernel_1.m_axi_gmem2:bank1 --sp top_kernel_1.m_axi_gcontrol:bank0

#
# OpenCL kernel files
#

BINARY_CONTAINERS += binary_container_1.xclbin

BUILD_SUBDIRS += binary_container_1
BINARY_CONTAINER_1_OBJS += binary_container_1/top_kernel.xo
ALL_KERNEL_OBJS += binary_container_1/top_kernel.xo

ALL_MESSAGE_FILES = $(subst .xo,.mdb,$(ALL_KERNEL_OBJS)) $(subst .xclbin,.mdb,$(BINARY_CONTAINERS))

#
# host files
#

HOST_OBJECTS += src/cnn_sw.o
HOST_OBJECTS += src/host.o
HOST_OBJECTS += src/xcl2.o

HOST_EXE = pose_prj.exe

BUILD_SUBDIRS += src/

#
# primary build targets
#

.PHONY: all clean
all: $(BINARY_CONTAINERS) $(HOST_EXE)

clean:
	-$(RM) $(BINARY_CONTAINERS) $(ALL_KERNEL_OBJS) $(ALL_MESSAGE_FILES)  $(HOST_EXE) $(HOST_OBJECTS)
	-$(RM) *.xclbin.sh
	-$(RMDIR) $(BUILD_SUBDIRS)
	-$(RMDIR) _xocc*
	-$(RMDIR) .Xil

.PHONY: incremental
incremental: all

nothing:

#
# binary container: binary_container_1.xclbin
#

#binary_container_1/top_kernel.xo: ../src/hw_kernel.cpp ../src/util.h /opt/tools/xilinx/Vivado/2018.3/include/hls_stream.h /opt/tools/xilinx/Vivado/2018.3/include/ap_int.h /opt/tools/xilinx/Vivado/2018.3/include/ap_fixed.h
binary_container_1/top_kernel.xo: ../src/hw_kernel.cpp ../src/util.h /tools/Xilinx/Vitis_HLS/2020.2/include/hls_stream.h /tools/Xilinx/Vitis_HLS/2020.2/include/ap_int.h /tools/Xilinx/Vitis_HLS/2020.2/include/ap_fixed.h
	@mkdir -p $(@D)
	-@$(RM) $@
	$(XOCC) $(XOCC_OPTS) -c -k top_kernel --max_memory_ports top_kernel --messageDb $(subst .xo,.mdb,$@) -I"$(<D)" --xp misc:solution_name=_xocc_compile_binary_container_1_top_kernel -o"$@" "$<" --kernel_frequency 310

binary_container_1.xclbin: $(BINARY_CONTAINER_1_OBJS)
	#-@echo $(XOCC) $(XOCC_OPTS) -l --nk top_kernel:1 --messageDb $(subst .xclbin,.mdb,$@) --xp misc:solution_name=_xocc_link_binary_container_1 --remote_ip_cache /home/centos/src/project_data/200G_workspace/openpose_sdx/ip_cache -o"$@" $(+) > binary_container_1.xclbin.sh
	-@echo $(XOCC) $(XOCC_OPTS) -l --nk top_kernel:1 --messageDb $(subst .xclbin,.mdb,$@) --xp misc:solution_name=_xocc_link_binary_container_1 --remote_ip_cache /home/jumpchan/master/develop/project_data/openpose_sdx/ip_cache -o"$@" $(+) > binary_container_1.xclbin.sh
	#$(XOCC) $(XOCC_OPTS) -l --nk top_kernel:1 --messageDb $(subst .xclbin,.mdb,$@) --xp misc:solution_name=_xocc_link_binary_container_1 --remote_ip_cache /home/centos/src/project_data/200G_workspace/openpose_sdx/ip_cache -o"$@" $(+) --kernel_frequency 310
	$(XOCC) $(XOCC_OPTS) -l --nk top_kernel:1 --messageDb $(subst .xclbin,.mdb,$@) --xp misc:solution_name=_xocc_link_binary_container_1 --remote_ip_cache /home/jumpchan/master/develop/project_data/openpose_sdx/ip_cache -o"$@" $(+) --kernel_frequency 310

#
# host rules
#

src/cnn_sw.o: ../src/cnn_sw.cpp ../src/util.h
	@mkdir -p $(@D)
	#$(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/opt/tools/xilinx/SDx/2018.3/runtime/include/1_2/ -I/opt/tools/xilinx/Vivado/2018.3/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"
	$(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/tools/Xilinx/Vitis/2020.2/include/ -I/tools/Xilinx/Vivado/2020.2/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"

src/host.o: ../src/host.cpp ../src/xcl2.hpp ../src/util.h
	@mkdir -p $(@D)
	#$(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/opt/tools/xilinx/SDx/2018.3/runtime/include/1_2/ -I/opt/tools/xilinx/Vivado/2018.3/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"
	$(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/tools/Xilinx/Vitis/2020.2include/ -I/tools/Xilinx/Vivado/2020.2/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"

src/xcl2.o: ../src/xcl2.cpp ../src/xcl2.hpp
	@mkdir -p $(@D)
	# $(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/opt/tools/xilinx/SDx/2018.3/runtime/include/1_2/ -I/opt/tools/xilinx/Vivado/2018.3/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"
	$(SDX_CXX) $(CXXFLAGS) -DSDX_PLATFORM=$(SDX_PLATFORM) -D__USE_XOPEN2K8 -I/tools/Xilinx/Vitis/2020.2/include/ -I/tools/Xilinx/Vivado/2020.2/include/ -O2 -Wall -c -fmessage-length=0 -o "$@" "$<"

$(HOST_EXE): $(HOST_OBJECTS)
	# $(SDX_CXX) -o "$@" $(+) $(LDFLAGS) -lxilinxopencl -lpthread -lrt -lstdc++ -L/opt/tools/xilinx/SDx/2018.3/runtime/lib/x86_64
	$(SDX_CXX) -o "$@" $(+) $(LDFLAGS) -lxilinxopencl -lpthread -lrt -lstdc++ -L/tools/Xilinx/Vitis/2020.2/lib/lnx64.o

3. How to get hardware resource info? (may not be the problem of error, but still a problem)
I have modified the json file in dse of auto_compile. But I get two versions of the info between the Alveo card Data Sheet and the Vitis project setting. So I choose the smaller one. Could I get the correct info with some commands or programs certainly?

Click to show two versions of U250 card

Public paper and some Data Sheet version:

{
    "BOARD": "u250",
    "LUT": 1341000,
    "FF": 2750000,
    "BRAM18K": 4000,
    "DSP": 11508,
    "LUT_THRES": 0.8,
    "FF_THRES": 0.8,
    "BRAM18K_THRES": 0.8,
    "DSP_THRES": 0.8
  }

Vitis project setting version

{
    "BOARD": "u250",
    "LUT": 1728000,
    "FF": 3456000,
    "BRAM18K": 5376,
    "DSP": 12288,
    "LUT_THRES": 0.8,
    "FF_THRES": 0.8,
    "BRAM18K_THRES": 0.8,
    "DSP_THRES": 0.8
  }

Thanks for trying out our project.

It is normal for the C simulation to take a long time. You can add #define DEBUG_engine to the util.h file to make sure the simulation is proceeding. Note that you should comment this line for hardware emulation/generation.

I would guess this is because you are using too many resources that makes it hard for the tool to do the P&R. Could you reduce the maximum tiling sizes (the first 7 lines in params.h) and the systolic array size and retry?

You should see the same numbers for a board everywhere. One exception for it is the number of BRAMs as some sources report the number of 18Kb BRAMs while the others use 36Kb blocks. The DSE assumes that the json file contains the number of 18Kb blocks so you can use the bigger number. You can double-check this number by opening the Vitis GUI and clicking on the board name, or look at any report generated by the tool (.rpt files).


update to operator sdk

Huge update, need to get added for main.go to compile

ibm-mongodb-operator-6fcc7d648d-g8sxz       1/1     Running   0          7m34s
icp-mongodb-0                               2/2     Running   0          7m13s
icp-mongodb-1                               2/2     Running   0          4m11s
icp-mongodb-2                               2/2     Running   0          2m2s

/lgtm


Ops Server install guide: page 27 remove extra line

on page 27, the example for the PublishToOpsServer.py contains an extra line "\Server\ServiceDefinitions"

Fixed in Esri\ops-server-config v.next. Closing issue.


Vagrantfile updates

I don't think the export statements are necessary.
Some other things should be done here possibly (if possible), like hiding the vagrant user, setting locale etc.

Except changes to the gnome-session which aren't possible from the Vagrantfile without actually running a gnome-session, the rest of the customization of the VM can be done.
I believe this can be closed.


Duplicating WS's and data

Log Analytics Report data Workspaces monitored under each capacity are duplicating same data...

Seems you are using the PBIASEngine template. Please try to use the Workspace column from the Operation table.

And, please try the FabricASEngineAnalytics.pbit

I have tried the FabricAS template, and it is completely empty

Please double check the Fabric Item Id. It is the semantic model Id, not the reportId.
Or just leave it blank.

Here is what exactly i did ...

And

How did the "Fabric Workspace Id" and "Fabric Item Id" parameters look like for you?

i dont see any difference ..

Not sure how the ... get into the (). Could you please try reopening the pbit file, enter the Log Analytics workspace and load?

additionally, i am seeing these errors when i opened template..

i am using the latest version of desktop power bi software...

it looks the same

I was able to load the template using the April release after getting the same warnings. The warnings should be fixed by the coming May release and can be ignored for now.
The parameters show as ... in the Aprile release.
Could you please double check the Log Analytics Workspace Id to be the same as the one used for the PBIASEngine.pbit?