Feature: transform the display

Closes #41
@anandubey let's continue discussions in here.

There is a large refactor incoming, which greatly affects cfg.
I am happy to merge it to your repo.
I'll need to have push access... applying a large merge as a patch is not viable.

I have added you to the collaborators list. I hope now you will have the push access.

Thanks @anandubey
I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

master at 1.6.0 has been merged, along with the patches above.
The large change resulted from refactors when adding the IPC API. A lot of src/cfg was moved to src/marshalling
I've pre-emptively added !!transform to the YAML schema
You'll need test it with the example client when you have finished adding all the TRANSFORM enums.

Nudge @anandubey
Any updates on this one?
This is really close to complete and I look forward to releasing it!

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

No worries. There is no hurry at all.
Good luck in the new role!

Thanks for your work on this @anandubey, and totally understand about prioritizing paid job.
It would be great to get output transforms in tho. Do you anticipate having time to get this merge ready going forward, or alternatively, would you be open to handing it off?
If C was fresher in my mind I would volunteer (and my ADHD brain likes to say yes) but I shouldn't.

would you be open to handing it off?

That would be fantastic!
I just cannot allocate the time to finish this one off...

make cppcheck
cool!

way-displays is also set up for ccls live checking in the editor.
alright! I use helix which uses clangd by default but I can change it in languages.toml.

alright! I use helix which uses clangd by default but I can change it in languages.toml.

All good; clang is preferred. gcc is only used by default for legacy packaging reasons.

Added development information to https://github.com/alex-courtis/way-displays/blob/master/CONTRIBUTING.md

Want to try to get this in before #83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)
I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

Want to try to get this in before https://github.com/alex-courtis/way-displays/issues/83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)
I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

Oh yes please!
I've added a lot of unit tests on master, so that should make this easier RE merge etc.

#133


OAuth guides

These are the guides we need for OAuth (all I can think of):

[x] OAuth through redirect.  (Navigating to /auth/github) published here
[ ] OAuth through a popup window where both Web client and API server are on the same domain.
[ ] OAuth through a popup window on where the Web client and API server are on different domains

[ ] https://github.com/feathersjs/feathers-authentication-oauth1/issues/6
[ ] https://github.com/feathersjs/feathers-authentication-oauth2/issues/7

[ ] Token-based OAuth, like passport-github-token
[ ] React Native OAuth with a webview
[ ] React Native OAuth with deep linking

[ ] https://github.com/feathersjs/feathers-authentication-oauth1/issues/7
[ ] https://github.com/feathersjs/feathers-authentication-oauth2/issues/8

[ ] Customizing the OAuth payload.

Seems like some of this might exist, already.  I'm planning on aggregating it all out into the Guides section of the docs, since it doesn't really qualify as API docs.

Are you planning to organize it so people can cut and paste working code from it? I think that would be most productive for many users.

https://github.com/feathersjs/feathers-authentication-oauth2/issues/40


Add variables for ports

This enables setting ports for HTTP and TLS.  It will be needed to make it compatible with ports 80/443.

Closed by #8


test bug

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behaviour, i.e running a test or running a HTTP client such as curl...
Expected behaviour
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):

OS: [e.g. iOS]

incomplete, won't fix


the current Apicurio Registry API is not built to be idempotent ?

The readme says:
some of them being that this is a "broken by design" approach as the current Apicurio Registry API is not built to be idempotent and used in such a way

If so, what would you recommend when multiple teams use one Apicurio registry?
AWS Glue schema registry provides a way to manage schemas in the declarative manner using Terraform:

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/glue_schema

so I'm wondering what is the main difference between Apicurio registry and AWS Glue schema registry

@carlesarnal thank you for your continuous support and I'd be glad if I could get your reply 🙇♂


Support bulkhead group

Related to Spring Cloud OpenFeign Issue 514.
These changes required the latest version of Spring Cloud Commons.

PR to the 1.0.x branch 104


Feature: multiple directions

Describe the problem 🧐
Is it possible to use multiple directions depending on the link selected with a custom attribute?
Have i missed the info on this and how to apply multiple directions based on navigation paths?
Describe the propsed solution 😎
Custom HTML attribute?
Alternatives considered 🤔
writing additional js to get this to work.
How important is this feature to you? 🧭
I cannot use swup without it
Checked all these? 📚

[X] I have read and searched the official docs
[X] I have checked discussions and existing issues for related problems
[X] I agree to follow this project's Code of Conduct
[X] I have provided all necessary information to the best of my knowledge

@ShaneSheppard This isn't currently possible and not planned from our side. But feel free to submit a pull request with an implementation, and we'll happily take a look at it.


Database Transactions in tests do not roll back, for non-default database connection

If I have two MySQL databases setup up, and I run tests that affect the non-default database, the DatabaseTransactions trait seems to have no effect.
I double-checked this by starting a new Laravel 5.1.11 project and created a Route::resource with just @show, @edit and @update controller methods. I created two databases, configured my project with the db credentials and added a posts table manually to the non-default database. I also created a 'Post' model that specifies the non-default database as its connection.
When using this site, it works as expected. When running an automated test with the DatabaseTransactions trait, the database change will stick.
use Illuminate\Foundation\Testing\DatabaseTransactions; was included at the top of the test, and use DatabaseTransactions; was included as the first line inside the test class.

Not really a bug I'm afraid. You need to start transactions on other connections yourself I'm afraid.

Not sure what you're trying to suggest. Perhaps you could give an example?
I need to be able to use database transactions when integration testing. I'm unable to test a large proportion of my application because I can only run transactions on the default database. I don't see why Laravel would deliberately not let me run database transitions on more than one database.

@GrahamCampbell
I have stumbled upon the same issue as @tomturton.
Why not give people an option to make DatabaseTransactions trait applicable to a testing connection for example? Or any other optional connection for that matter?

I'm a little new to this myself, so take this with a grain of salt.  But after looking at the content of that trait, it looks like if you add a property to your test class called "connectionsToTransact", and assign it to an array of connection names, the trait will handle transactions on whatever databases you like.

I have the same issue and google here, I write down my solution and hope helpful:
If you have multiple databases, for the transaction on the non-default database,, you need to specify the
connection like this:
DB::connection("your_connection_name")->transaction(function() {
// ...
});

FYI, fixing this is as easy as adding a $connectionsToTransact property to your TestCase.php (or whatever base class you want in your tests)...

(shared/tenant are both database connection names in my config)

I had the same problem today. If anyone will have similar problem and happens to use MySQL, check engine used by tables having problem with transactions. If they're using MyISAM, changing it (and default if possible) to InnoDB might help.

for those suggesting to use $connectionsToTransact, I cant seem to find where it uses that variable in the source code. Can anyone point me in the right direction to investigate more on this?

Similar problem today (Laravel 5.5). Solved it this way:
try {
    \DB::setDefaultConnection('non_default_connection');
    \DB::beginTransaction();

    // your database interaction here

    \DB::commit();
    \DB::setDefaultConnection('default_connection');
} catch (\Exception $e) {
    \DB::rollBack();
    \DB::setDefaultConnection('default_connection');
}

@GTCrais I'm looking to do this except with both my default and a non default connection. I want both to execute successfully or neither. How can I do this using this method?

You can't roll queries for different connections in the same transaction.

@GTCrais Bummer... Thanks!

I tried following @tomschlick's solution but for some reason no tests are running with
protected $connectionsToTransact = ['main', 'tenant'];
However, removing 'main' and leaving it as protected $connectionsToTransact = ['tenant']; allows tests to run...but data is not cleared on the 'main' database connection.
Tests seem to be running okay with an sqlite database.
Has anyone experienced this or might have an idea on how to make it work?
Did a lot of dump()s around the core. The only thing that struck me as odd is that the DatabaseManager->connection() function, called in RefreshDatabase->beginDatabaseTransaction() (the loop looping connectionsToTransact ) is called multiple times during a single test (like 40-50)..not sure if that is normal. I guess it is and I just don't understand why it does it.

@denitsa-cm I had a similar problem running tests with Laravel and Postgres, also getting the Too many connections message.
My solution was to set the PDO to use persistent connections:
'options'   => [                 PDO::ATTR_PERSISTENT => env('DB_PERSISTENT', true)             ]
Just to clarify this was used only to run tests in Codeship CI, not in production.

@dericlima Thanks for the tip. Will try it :)

@denitsa-cm keep in mind that transactions are not supported by default in MySam engine, so you should make sure you are using  InnoDb.
https://dev.mysql.com/doc/refman/5.6/en/myisam-storage-engine.html

@dericlima Its help with too many connections, but now its PDOException: There is already an active transaction

I was struggling with this issue for a while (Laravel 5.8). I tried many variations on the provided traits, setting connections, initiating transactions (statically or on the connection object) and nothing was working.
I then found that calls to DB::statement() and DB::unprepared() were canceling my transactions. Essentially, I had in setUp():
if ($this->testDatabase == 'mysql') {
    DB::setDefaultConnection('mysql_tests');
    DB::beginTransaction();

    $this->beforeApplicationDestroyed(function () {
        DB::rollBack();
    });

    DB::statement('some SQL prep');
    DB::unprepared('a long SQL string');
}

Once I placed the call to beginTransaction() after the statement/unprepared code, then transactions worked.
My guess is that statement() and unprepared() call some lower level code that reinitializes the connection, thereby losing the transaction session. But I don't really know, I just hope this discovery helps some folks.

Solution "    $table->engine = 'InnoDB';"
public function up()     {         Schema::create('password_resets', function (Blueprint $table) {             $table->string('email')->index();             $table->string('token')->index();             $table->timestamp('created_at')->nullable();             $table->engine = 'InnoDB';         });     }


Link to survey in deadlines sidebar doesn't do anything.

Now the bottom link does the same thing as the top link. https://github.com/pwnall/seven/commit/1b60d7e65ea9d9e45906eab9e7c58e5904e3ec13


Add tests for AdaLoRA, fix a few bugs

So far, there have been no tests for AdaLoRA. This PR adds tests similar to the existing ones. While working on those tests, a few bugs were encountered and fixed.
The changes to AdaLoRA that I made:

Linked to paper abstract, not pdf.
Don't assume that target modules have a .bias attribute (same as for LoRA).
Fixed an issue where it was assumed that if an output object from forward has a .loss attribute, it is a scalar, when it can be None.
Fixed an issue that when init_lora_weights=False, the weights were still initialized to be an identity transform.
Fixed an issue when lora_dropout=0 (resolves #730).
When replacing modules, if a target module is a ModuleList or ModuleDict, they are now skipped instead of raising an error that the module type is not supported. My reasoning was that it is never intended to change those modules, so if their names are matched, it must be a false positive. The issue arose because for some target modules, the names are just "k" etc., and since we match with endswith, this can easily lead to modules like "block" to match.

A few open questions:

A bunch of models were commented out in TRANSFORMERS_MODELS_TO_ADALORA_TARGET_MODULES_MAPPING, which I added back in, since they were required to run the tests. Apparently this just worked, so I'm not sure why they were commented out. Is it safe to add them or do they have issues?
The test test_hf_internal_testing_tiny_random_GPT2LMHeadModel_adalora fails with RuntimeError: mat1 and mat2 shapes cannot be multiplied (6x32 and 96x32). Not sure what is happening there, but it needs to be resolved and it would be great if someone else can help debugging.
My impression is that some of the AdaLoRA issues used to exist in LoRA as well but were fixed since then in LoRA. But since the AdaLoRA code is duplicated, it has not been fixed accordingly. Either we should think about some sort of code re-use (e.g. abstractions) or we have to be super careful in the future to check all places that need to be fixed.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I suggest we can maybe skip that test for now and address that fix in a follow up PR

Sounds good, I pushed a change to skip the test.


Extra & ExtraTemplate management

Small changes to the extra & extra_template model to improve the handling of postal codes
Add all views and html templates for extra templates
Add basic extra templates as fixtures to be imported together with test data
Add possiblity to activate and deactivate extras per region

In addition to the global extra templates, I extended the PR to the management of extras per region.


Fix for global aggregations without property

Fixes #1196
This wasn't detected by the tests, so we should add some. There is a unit test already, but it wasn't failing; I guess _resolveAliases wasn't being call. We should either call _resolveAliases in that test or add some new render test using globalCount.
Pending

[x] Add globalCount() test

I've introduced calls to _resolveAliases in the global aggregations unitary tests, so that the problem would now be detected for that test.
I have no idea why after that a e2e has broken 🤷♂

That failing timerange e2e test seems to now be unstable. I have no permissions to rerun the test, but it's passing here on the very same code: https://circleci.com/gh/CartoDB/carto-vl/17687?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link


Retraining from scratch yields worse results

Hello,
As written in the paper (2.2 Deriving Architectures) I tried to re-retrain from scratch the best derived model, but it surprisingly gives worse result when I retrain it from scratch than if I would keep the original (shared) weights.
I expected training the best model (dag) from scratch to be faster and eventually have a better perplexity, but it's not the case.
I do the following:

Launch ENAS with the --load_path argument, which loads a previous run, and the --mode test, which will call a custom test method inside the trainer class
(In the test method) I reset the shared weights with self.shared.reset_parameters()
I derive the best model (dag)
Then I train this model from scratch, iterating over the train set for N epochs (like in the train_shared method)

The following picture shows the loss and ppl during the "normal" training (first slope) and after reseting the shared weights (second slope). The second slope only trains the same best model (dag).

Has anyone any idea about why resetting the shared weight and re-training from scratch is so bad?

Just to make sure I'm understanding: when you say first slope you're referring to the part of the graph from 0 to 60.00K on the x axis? And the 2nd slope starts at 80.00k? So you did the self.shared.reset_parameters() at 60.00K, correct?
I guess I'm not too surprised at this result. There's very little information in the paper about this retraining step - it's all in section 2.2 under Deriving Architectures: "We then take only the model with the highest reward to re-train from scratch" - that's it. If you look at the enas implementation from the paper authors (https://github.com/melodyguan/enas) you'll see that there are two scripts: ptb_search.sh and ptb_final.sh. The latter script is used to retrain the best found dag (and in fact they've hard-coded the best found dag to be exactly the one found in the paper). Doing a comparison between them I notice that several parameters are different between the two: The lstm_hidden_size is 720 in ptb_search.sh while it's 748 in ptb_final.sh, for example, and the parameters related to learning rate are very different as well.

Yes, correct. The second part starts at around 80k.
Interesting, I will try to use the same parameters and compare the results, thanks for the suggestion.

#35

@nkcr were you able to better results with the parameters from the TF code?

No, not really. I didn't investigate much but with a quick matching from the tensorflow implementation I got worse results.


Improve docs for PROTOCOL and HTTP_ADDR options

Fixes: https://github.com/go-gitea/gitea/issues/2230

LGTM

LGTM


update slack link

Description
update expired slack link with a permanent invite link

Job PR-356/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-356/1/index.html


[🐞] SPA resume (probably) needs to be fixed for upcoming v2 changes

Which component is affected?
Qwik City (routing)
Describe the bug
Explanation
SPA resume (popstate after refresh/reload) needed to exist outside of Qwik in order to keep it simple and not pull in anything that is not already being used on a page.
For this reason, when a popstate occurs on a page where SPA context was lost, it only directs the page back into the useNavigate pipeline when an already-existing useNavigate context exists on the page, and falls back to location.href refreshing.
This functionality solves all cases:

No SPA-related code loaded on MPA-only pages.
Pages with useNavigate ctx will be restored into the SPA pipeline.
Edgecase of "leaf node" which is arrived at via Link/useNavigate, but does not contain either, and a refresh occurs. It isn't possible to differentiate this page from a purely MPA during SSR, no useNavigate ctx can be included.

Problem
The simple and quick way of hooking back into the useNavigate ctx was to:

Check the page for a Link, specifically an a element with the attribute q:key="AD_1".
This elm then gets duplicated in a way that is invisible, and a new attribute q:nbs (Nav BootStrap) would be attached.
This attr tells the Link component to ignore the href attr and instead call: nav(location.href, { type: 'popstate' })
The modified Link elm gets click() and is pushed through the loader normally, resuming the app, everything just works.

This was simple even though it only works if the official Link component is present, and I didn't understand internals enough to decipher and jiu-jitsu a hand-crafted way to directly detect and hook any case of useNavigate ctx on the page from the qwik/json in the time available. (that would've needed adapting to v2 as well)
With the upcoming Qwik v2 changes as they appear in this blog post: https://www.builder.io/blog/qwik-2-coming-soon. It appears the current method of detecting a Link described above might not work anymore. Can someone confirm this?
Solution(s)
If this does turn out to be an issue, some possible solutions:

Find new way to detect Link component, probably from qwik/vnode/qwik/state, and simply adjust the current behavior.
Jiu-jitsu a way to detect any case of useNavigate, even with just nav() or custom Links, and somehow hook into this directly.

Unfortunately I do not currently have the time it would require to setup a dev environment on v2 and investigate and decipher a way to adjust this behavior. Hopefully the few minutes it took to explain this issue in detail is helpful to someone in solving this.
For reference, here are the current parts of the code that are described above:
https://github.com/BuilderIO/qwik/blob/157f7b01df22448638f7cc55546a051aa4eea5f0/packages/qwik-city/runtime/src/spa-init.ts#L74-L78
https://github.com/BuilderIO/qwik/blob/157f7b01df22448638f7cc55546a051aa4eea5f0/packages/qwik-city/runtime/src/link-component.tsx#L70-L72
Reproduction
N/A
Steps to reproduce
No response
System Info
N/A

Additional Information
No response

Thanks Jordan! Question: how about always including the spa context, would that also solve it? Is it that huge?

Hmm I'm afraid I don't understand. Apart from the contexts' data that Link uses,  what needs to be shipped to the client to enable SPA?

partially fixed https://github.com/QwikDev/qwik/pull/6022


cannot get cron to work

After setting up a crouton chroot, cron does not seem to work.
What I've done:

setup crouton following steps in README
sudo enter-chroot
crontab -e

added * * * * * echo "hi from cron" >> /home/matt/hiFromCron.txt"
after a few minutes, see no output at either /home/matt within the chroot or at the "real" /home/matt outside of the chroot (I went there and added a matt directory)

ps -A | grep cron returns nothing. It definitely looks like cron is not running.
But doing sudo /etc/init.d/cron start just produces "Rather than invoking init scripts through /etc/init.d, use the service(8) ..."
So I do sudo service cron start and get "Unknown job: cron"
And sudo start cron gives me "start: Unknown job: cron"
I'm not convinced this is a Crouton specific issue, but hoping I can get some pointers on what to try next.

What is the best way to run scripts inside the chroot at shutdown or reboot, for cleanup, etc.? Thanks!

There's no official mechanism for it at the moment.  You may be able to make a script that gets run from rc.local that does nothing but wait for SIGTERM, and then performs your cleanup tasks.  unmount-chroot will SIGTERM all child processes if it can't unmount everything, and then SIGKILL five seconds later (so hopefully your cleanup takes less than five seconds :) ).

Hmm. Thanks. Five seconds can be pretty tight for some stuff though.

You could modify unmount-chroot to change that timeout.  Otherwise, you'll probably have to try some other approach.  Also worth noting is that while there's a system dbus message that gets fired on shutdown, crouton doesn't actually respond to it, so even the SIGTERM approach may not work for the shutdown case...


Ground track refactor

Convert unit Radians to Degrees for ground track.

Fixed in https://github.com/mihai-dinculescu/msfs-2020-gps-link/releases/tag/v0.3.2.


Polkit working incorrectly, always asks for password

Issue description
I have attempted to add a rule that allows command to be run without a password. For some reason polkit seems to always ask for the user's password even when authorization shouldn't be needed.
Steps to reproduce
Create a rule, for example :
    polkit = {
      enable = true;
      extraConfig = ''
      /* Allow members of the wheel group to execute the defined actions
      * without password authentication, similar to "sudo NOPASSWD:"
      */
      polkit.addRule(function(action, subject) {
        if ((action.id == "org.john.zfs" ||
             action.id == "org.john.zpool") &&
            subject.isInGroup("wheel"))
        {
            return polkit.Result.YES;
        }
      });
      '';
    };

With an associated action, which I have added by creating a package with writeTextFile and adding it to my system packages: :
environment.systemPackages = with pkgs;
    # Packages..
      ++ [ (pkgs.writeTextFile {
            name = "org.john.zfs.policy";
            destination = "/share/polkit-1/actions/org.john.zfs.policy";
            text = ''
            <?xml version="1.0" encoding="UTF-8"?>
            <!DOCTYPE policyconfig PUBLIC "-//freedesktop//DTD polkit Policy Configuration 1.0//EN"
            "http://www.freedesktop.org/software/polkit/policyconfig-1.dtd">
            <policyconfig>

              <vendor>John Ramsden</vendor>
              <vendor_url>https://ramsdenj.com/</vendor_url>

              <action id="org.john.zfs">
                <description>Run zfs</description>
                <message>Authentication is required to run zfs as (user=$(user), user.gecos=$(user.gecos), user.display=$(user.display)$
                <defaults>
                  <allow_any>yes</allow_any>
                  <allow_inactive>yes</allow_inactive>
                  <allow_active>yes</allow_active>
                </defaults>
                <annotate key="org.freedesktop.policykit.exec.path">${pkgs.zfs}/sbin/zfs</annotate>
              </action>

              <action id="org.john.zpool">
                <description>Run zpool status</description>
                <message>Authentication is required to run zpool status as (user=$(user), user.gecos=$(user.gecos), user.display=$(user.disp$
                <defaults>
                  <allow_any>yes</allow_any>
                  <allow_inactive>yes</allow_inactive>
                  <allow_active>yes</allow_active>
                </defaults>
                <annotate key="org.freedesktop.policykit.exec.path">${pkgs.zfs}/sbin/zpool</annotate>
              </action>

            </policyconfig>
            '';   } )
      ];

Now when I attempt to run zfs <something>, or zpool <something>, i'm always asked for my user's password. Shouldn't my command just run?
Technical details

System: (NixOS: 17.03.928.69d9061908 (Gorilla))
Nix version: (nix-env (Nix) 1.11.8)
Nixpkgs version: ("17.03.928.69d9061908")

Any news on this issue?


[5.2] Added compileUrl() and compileAsset() functions

Added @url and @asset blade directives since they may frequently be used in blade templates.

Can you write tests for this?


--testnet flag does not work: There is no deposit contract at given address: TBD

Describe the bug
I cannot seem to figure out how to connect to the Medalla or Altona testnets.
Expected behavior
Run lodestar beacon run --testnet medalla to connect to the testnet.
Steps to Reproduce

Run lodestar beacon run --testnet medalla
See error

2020-08-03 00:24:14  [NODE]             info: Starting eth2 beacon node - LODESTAR!
2020-08-03 00:24:14  [DB]               info: Connected to LevelDB database at .lodestar/beacon/chain-db
2020-08-03 00:24:14  [CHAIN]            info: Chain not started, listening for genesis block
(node:52833) UnhandledPromiseRejectionWarning: Error: There is no deposit contract at given address: TBD
    at EthersEth1Notifier.initContract (/usr/local/share/.config/yarn/global/node_modules/@chainsafe/lodestar/lib/eth1/impl/ethers.js:343:13)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async EthersEth1Notifier.startProcessEth1Blocks (/usr/local/share/.config/yarn/global/node_modules/@chainsafe/lodestar/lib/eth1/impl/ethers.js:366:7)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:52833) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:52833) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Desktop (please complete the following information):

OS: ArchLinux
Branch: master
Commit hash: 02d82b2d550c596fa91ced65194ccb9c33f58175

Same with init:
~/.opt/chainsafe/lodestar master
❯ lodestar beacon init --testnet medalla --rootDir $HOME/.lodestar

~/.opt/chainsafe/lodestar master
❯ lodestar beacon run --testnet medalla --rootDir $HOME/.lodestar
2020-08-03 00:31:25  [NODE]             info: Starting eth2 beacon node - LODESTAR!
2020-08-03 00:31:25  [DB]               info: Connected to LevelDB database at /home/user/.lodestar/beacon/chain-db
2020-08-03 00:31:25  [CHAIN]            info: Chain not started, listening for genesis block
(node:53863) UnhandledPromiseRejectionWarning: Error: There is no deposit contract at given address: TBD
    at EthersEth1Notifier.initContract (/usr/local/share/.config/yarn/global/node_modules/@chainsafe/lodestar/lib/eth1/impl/ethers.js:343:13)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async EthersEth1Notifier.startProcessEth1Blocks (/usr/local/share/.config/yarn/global/node_modules/@chainsafe/lodestar/lib/eth1/impl/ethers.js:366:7)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:53863) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:53863) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

This issue has been fixed with recent patches. @q9f if you experience it again from the latest master, please reopen


Fix memory leak warning (#476)

What:
Don't run setState on unmounted components. Fixes #476

Why:
To prevent a possible memory leak plus removing a warning being emitted in the console from React.

How:
In #476 you proposed two different solutions for this and I decided to go for the solution with the _isMounted flag. That flag was already used for other things so it felt natural to just go with that solutions for this as well. Although I still think that clearing the timeouts is a better and more robust overall solution for the problem, so it might be worth revisiting this later.
I'm unsure if you would like me to add tests for this? If you would like that, I'd like some guidance on how you would like that to be implemented.

Checklist:

[x] Documentation (Don't think any new documentation is needed)
[x] Tests
[x] Ready to be merged

[x] Added myself to contributors table

I've now added tests for this as well. I've not worked a lot with either Jest or react-testing-library so if there is anything that you want me to edit please tell me and I'll try to fix it 😄

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

:tada: This PR is included in version 2.0.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update git repo url for uuid

Related to https://github.com/remind101/empire/issues/718
The repo has now been completely moved away from Google Code: fetching it fails as opposed to just return a warning like before.
❯ go get code.google.com/p/go-uuid/uuid
package code.google.com/p/go-uuid/uuid: unable to detect version control system for code.google.com/ path

Nevemind, this is not needed. For some environmental reason, go build was not using my vendor directory.


train over AWS SSM?

Description
SSH connectivity to EC2 instances when done right are often established through a bastion host. Increasingly, bastion hosts are being displaced in favor of proxying commands through AWS Systems Manager (SSM), thereby removing a somewhat vulnerable and often forgotten piece of infrastructure. train "supports" execution via ssh through bastions today through a somewhat hacky way (basically configure ~/.ssh/config; no supported flags). It would be excellent if train also supported using SSM for test execution/transport as direct or indirect SSH access becomes unnecessary. We just need the SSM agent present, connectivity to AWS, and a suitable IAM user/role/policy.
Train and Platform Version
All.
Possible Solutions
I haven't yet dug into the code here to figure out where and how this could be implemented. It's better to start a conversation around the idea first.
SSM isn't a direct drop in for SSH and comes with its own way of managing documents of potential executable commands. I'm mostly wondering if anyone familiar enough with both train and SSM has considered this alternative approach and if they met any significant roadblocks, including project direction.

@brandoconnor Thank you very much for that idea. We tried to prototype a backend that uses the ec2 run command as the backend. The challenge with that approach is that it is difficult (not impossible) to implement and even more difficult to maintain. You would need to track multiple ec2 run command calls and the output files for those commands are difficult to parse.
I think you will like what we are going to announce at ChefConf. Therefore, I'd like to revisit your question next week.


Store previously attached signint signal so that it can be restored

Coverage increased (+0.005%) to 92.349% when pulling 1b7b691cfcaa2db016d02120a1e3a48c7bfb98e6 on gl3nn:restore-signint-signal into 240f6d1810ba67fb4efbae8fefa996425a15a02e on kayak:master.


Using as an ESM package with htm

Hello :)
The title says most of it, i tried to use fre with htm as an ESM module so no compile time (i'm using skypack.dev for the import) and i get errors.
When i do : import { h, render, useState } from 'https://cdn.skypack.dev/fre';
i get an error saying the package doesn't export h
Uncaught SyntaxError: The requested module 'https://cdn.skypack.dev/fre' does not provide an export named 'h'

and when i do import fre from 'https://cdn.skypack.dev/fre';
i get a warning:
build:fre@v2.0.0-rc7-AqBU1BZDjxJhcj7ShvUU:14 [Package Error] "fre" could not be built.
Installing package...
No "exports" main defined in fre/package.json
No "exports" main defined in /tmp/cdn/_AqBU1BZDjxJhcj7ShvUU/node_modules/fre/package.json

and an error after that :
build:fre@v2.0.0-rc7-AqBU1BZDjxJhcj7ShvUU:15 Uncaught Error: [Package Error] "fre" could not be built.
    at build:fre@v2.0.0-rc7-AqBU1BZDjxJhcj7ShvUU:15

This is the really basic repo for testing if you want to look into to see if i made any obvious mistake :)
https://github.com/wcastand/esm-fre

I am orry, because the default export of fre is is UMD format, I want to know whether the ESM format is the mainstream and whether I should change the default export?
I haven't used skycdn, but unpkg can be downloaded module property from packacg.json
import { h,render } from 'https://unpkg.com/fre?type=module

I am orry, because the default export of fre is is UMD format, I want to know whether the ESM format is the mainstream and whether I should change the default export?
I haven't used skycdn, but unpkg can be downloaded module property from packacg.json
import { h,render } from 'https://unpkg.com/fre?type=module

Thank you for your reminding. I found the problem where. It seems that the export property of package.json does not conform to skycdn specification.
We'll revise it right away, maybe tonight. @timeTravelCYN
https://docs.skypack.dev/package-authors/package-checks

Thank you for your reminding. I found the problem where. It seems that the export property of package.json does not conform to skycdn specification.
We'll revise it right away, maybe tonight. @timeTravelCYN
https://docs.skypack.dev/package-authors/package-checks

@wcastand
We have released a new version. And strictly abide by skycdn specifications. Thanks @timeTravelCYN
At the same time, I pull a PR to you to fix some grammatical food of htm.
I used to use fre + htm, which is very convenient.

@wcastand
We have released a new version. And strictly abide by skycdn specifications. Thanks @timeTravelCYN
At the same time, I pull a PR to you to fix some grammatical food of htm.
I used to use fre + htm, which is very convenient.

Working perfectly now!! nice thanks!
https://fre-demo.vercel.app/
https://github.com/wcastand/esm-fre

Working perfectly now!! nice thanks!
https://fre-demo.vercel.app/
https://github.com/wcastand/esm-fre


Error - panic: mmap, size 134217728: EDC5132I Not enough memory

The first time running Prometheus worked as expected. The second time it failed.
After removing the tsdb, it's able to successfully start up.
Any suggestions?
Our MAXMMAPAREA(131072) is defined in BPXPRMxx (number of pages), which looks to be 500+MB of data space storage.
First time

Second time

prometheus.yml
global:
scrape_interval:     10s
scrape_timeout:      10s
evaluation_interval: 10s
scrape_configs:

job_name: "prometheus"
static_configs:

targets:

mvs-sysa.hewitt.com:9090

job_name: "demo"
static_configs:

targets:

demo.promlabs.com:10000
demo.promlabs.com:10001
demo.promlabs.com:10002

@bluecivet, @jlee3227  do we need a new release with your changes in https://github.com/ZOSOpenTools/prometheusport/pull/1?

Upgraded and tested several starts/stops along with running some queries...looks good.
thanks


[Task]: APIs for published and unpublished Navigation config

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Adding new database schemas
Update existing API for GET /pages (with added nav schema)
Update existing API for PUT /applications/{applicationId} (which can update nav schema)
Test Cases

Reopening this issue, because the #19272 doesn't solve it completely as the current API implementation requires the frontend to pass "unpublishedNavigationSetting" and "publishedNavigationSetting" separately as payloads to update in the database, whereas the actual implementation should be:-
User only updates the EDIT mode configurations (i.e unpublishedNavigationSetting) and as the user clicks on Deploy button, the PUBLISH mode configurations (i.e publishedNavigationSetting) should automatically be cloned from the EDIT config already set by the user. The frontend is not required to hit the API twice, sending individual fields.


Build: Ignore BrowserStack generated file

BrowserStack-runner is generating this binary file to the project's root

Guessing it's from the local tunnel? Anyway, LGTM.

Yes, it is.

Let's report this on their end, instead of ignoring the issue. I've ignored it for too long myself.

Same for that pid file.

Makes sense. :+1:

Created a ticket: https://github.com/browserstack/browserstack-runner/issues/105


[Bug] READ and WRITE events do not capture the correct client IP in the host field

event table (from Grafana):

shipped in ff6b457


Path to CONTRIBUTING link is broken

[] I've read the CONTRIBUTING guidelines

steps
create a new issue in github.com/sbt/sbt
problem
text is auto-filled asking you to read a CONTRIBUTING guideline at - [] I've read the [CONTRIBUTING](https://github.com/sbt/sbt/blob/1.x/CONTRIBUTING.md) guidelines
This link is dead
expectation
The link is not dead

Thanks for the report!


Perf Automation application

C# application which runs perf tests (in any language) from a test manifest file
Should be merged to main to unblock language perf pipelines
May be substantially refactored or rewritten, so a thorough code review seems unnecessary at this time

Some light suggestions at a skim. Approving to unblock you but I think this is another instance that touches on our debate between script vs. code when it comes to shelling out and extensibility. So I'd love to follow up and see what pieces of this tool we can make common to all of engsys if we go in the direction of a c# engsys CLI app.

@mikeharder did we figure out what our plan is to keep these build and run commands in-sync with the language build commands? Is the expectation that if any of those change then the perf tests will break and then someone will have to come and update this tool?

@weshaggard: I agree the perf tooling should be refactored and/or re-designed.  Part of this is the build and run commands, which also includes modifying project files to change dependency versions (e.g. building from source vs. shipped packages).  Currently, this logic is written in C# code in this app.
One aspect is whether this should be C# code, PowerShell scripts, or written in the target language (e.g. Java implements this in Java code, JS in JS code, etc).  Another aspect is whether this code should live in the tools repo, or distributed across all the language repos.
We might end up with a hybrid model, where there is a central PerfAutomation C# app in the tools repo handling all the language-agnostic logic, but it shells out to scripts in each language repo that handle the language-specific steps of modifying dependencies, building, and running.
The highest priority right now is to get some form of daily perf pipelines running on main to catch regressions, even if the tooling is suboptimal. It was a conscious choice to get the pipelines running with the current tooling, rather than delaying even longer while the tooling is being re-designed.
But I will be revisiting this shortly after we get the pri-1 perf pipelines running in main.

Thanks @mikeharder that sounds reasonable to me. If you don't already have one I'd suggest filing an issue to track the refactoring/re-design work for this once the other work is done.

Yes and please keep me in the loop for your design stages.


f8a: PRs also need registry credentials to push images

https://github.com/openshiftio/openshift.io/issues/1257

Can one of the admins verify this patch?

[test]

@vpavlin LGTM, PTAL :-)

Please do not merge yet :)

@vpavlin ready 😉


Display new available commands after dcos cluster setup

We've extracted the job, marathon, node, package, service, and task
commands into a dcos-core-cli plugin which gets automatically
installed during dcos cluster setup.
To make this new behaviour clear to users we're displaying the new
available commands at the end of the setup flow:
$ dcos cluster setup ...
[...]
dcos-core-cli [================================================] 22.6 MiB / 22.6 MiB
dcos-enterprise-cli [================================================] 26.0 MiB / 26.0 MiB
New commands available: backup, job, license, marathon, node, package, security, service, task

@mesosphere-ci run integration tests


Ability to perform airgrabs/airdrops

A Tools interface that allows for easy airgrabs/airdrop claiming.
The available tokens should be pulled from our wallet contract to avoid having to update the UI.

This was part of the 0.7.3 release.


Improve the UI of magic link notifications

Is your suggestion related to an experience ? Please describe.
Currently UI of magic link notification shows following, and better to improve this UI.

Describe the improvement

Improve the UI with match with the product theame
Add for functionality will increase the user experience.

[ ] "Back" button to navigate again user name page
[ ] Add link resend button
[ ]  Add contact detail for support if any case user not receive the email
[ ] Add link to log my account so user can update email there.

Additional context

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


bug: native-web and native-mobile missing from package.json

Description
native-web and native-mobile missing from package.json.
all wrappid packages must have "latest" written as version.

Merged to main. Closing as done.


Add better link for How to Code courses

Add the Systematic Program Design course (which consists of both parts of How to Code) as the main link and move How to Code to alt.
This version of the course does not seem to expire and has access to the questions, which are under paywall in the current linked course. While you cannot submit the solution to the questions, you can see them and see answers by clicking on "Show answers".
Related discord messages: 1, 2
Since the course material is the exact same, I do not think this change is major enough to need an RFC, but if it is needed, I will open one.

Very interesting find. Thanks for identifying. And for providing supporting links.
I think its worth keeping the alt as the book site. It presents the material in a different modality rather than the same lectures on the same platform. Willing to switch that back?
I am a little concerned about the fact that this course doesn't have a front page.

Systemic Program Design:

HtC:

But feedback (questions that you can answer and check) is more important.

I think its worth keeping the alt as the book site. It presents the material in a different modality rather than the same lectures on the same platform. Willing to switch that back?

I did not want to remove it, just forgot about it. Added it back.

I am a little concerned about the fact that this course doesn't have a front page.

Yes, I am also concerned about this. It may confuse some people, but as you said it also brings many improvements which are more important.


if init is paused/pausing, exec state should be the same

if init is paused/pausing, exec state should be the same

Any reason why this couldn't be merged?

@zzzzzzzzzy9 could you pls rebase against main to pick up latest CI changes?

@mxpv Done.


Planned Database Maintenance

We're doing a planned upgrade to our database and there may be momentary downtime.

The upgrade is starting now.

The upgrade is now complete. Monitoring now.

Everything is looking good!


[Bug]: Inconsistent widget selection while using keyboard shortcuts

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Shift + selecting typically selects consecutive elements, so selecting the first and 4th element in a sequence automatically selects 1,2,3 & 4 but this behaviour is random on Appsmith canvas and does not follow this behaviour
Steps To Reproduce

Drop mutliple widget of the same kind (eg: all buttons) and different kind ( eg: button, stat box, input etc) on the latest Anvil instance - make sure these groups of widgets are inside the same zone
Press down on Ctrl and select a few widgets at random and observe single widget selection happens as expected
Press down on Shift and select widgets at random as seen in the video and observe widgets in between these are not selected as per expected behaviour

Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
https://www.loom.com/share/19069aeaa5b64fd2b96f66d80e58996f
Version
cloud

@marks0351 @ramsaptami Could you check how it works with the latest changes.

it works!! 🎉


Is the gadfly.org domain going away?

I just went to the docs and got a landing page as if there's no site:
This domain is registered at

This domain was recently registered at Namecheap. Please check back later!

looks like http://dcjones.github.io/Gadfly.jl/ is existing and according to my browser history, is already in use for at least 3 months?

You're right.  The link from the readme goes there, but there's a link in the repo description which is what I normally click on.  Who can change that link?

i guess the owner of the repository?

Last time I was on gadflyjl.org was on April 17th, I guess this coincides with @dcjones being AWOL

I changed the link in the readme a while back, but it looks like only @dcjones can change that description.

The website is also back.
On Fri, 6 May 2016, 06:16 Alex Mellnik<EMAIL_ADDRESS>wrote:

I changed the link in the readme a while back, but it looks like only
@dcjones https://github.com/dcjones can change that description.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/dcjones/Gadfly.jl/issues/832#issuecomment-217282413

@vchuravy -- The web site is up, but the content there hasn't been regenerated in a long time.  The old documentation has lead to a few issues being opened: #789.

I might be able to get Daniel to point the website at github pages and then the http://gadfly.org domain will stay synced with the generated docs.

Both sites are currently broken. http://dcjones.github.io/Gadfly.jl/ redirects to http://gadfly.org which doesn't work. 😕

Not sure what is going on. The github.io domain was working earlier today.

I opened a new issue #896 for tracking this. In the mean time, I have a semi recent version of the docs at http://tamasnagy.com/Gadfly.jl/

So I alerted Daniel to the problem, he said he updated the doc links last night so that's probably the culprit. He hopes to push a fix tonight.

http://gadfly.org now points to https://dcjones.github.io/Gadfly.jl/ and should stay synced in the future.


feat: Support auto size for text with non-start alignment

Closes https://github.com/marc2332/freya/issues/1029

todo: tests!


MSAL_GUARD_CONFIG factory invoked before APP_INITIALIZER promise resolves with standalone component bootstrapping

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.10.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
3.0.13
Public or Confidential Client?
Public
Description
This is a project that demonstrates that the MSAL_GUARD_CONFIG factory is called before the APP_INITIALIZER promise is resolved.
From Angular's documentation

The provided functions are injected at application startup and executed during app initialization. If any of these functions returns a Promise or an Observable, initialization does not complete until the Promise is resolved or the Observable is completed.

Steps to reproduce

Clone: https://github.com/jefedeltodos/app_initializer_msal_issue
Install the dependencies with npm i
Start the application with npm start
Open http://localhost:4200 in a browser.

Expected Results

The APP_INITIALIZER is invoked and the promise is resolved.
The MSAL_GUARD_CONFIG factory is invoked (along with the other MSAL components)
The application loads successfully in the browser.

Actual Results

The APP_INITIALIZER is invoked, but the Promise has not resolved.
The MSAL_GUARD_CONFIG factory is invoked.
An Error is thrown because the startup config values are unavailable because the APP_INITIALIZER promise hasn't yet resolved.
The APP_INITIAIZER promise is resolved, and the config values are ready.
The application does not load in the browser due to the previous error.

Notes

This only appears to be an issue when the default route is protected with canActivate: [MsalGuard].
If the default route is not protected, the application loads as expected.

Error Message
This issue arises early in the application bootstrapping before the MSAL gets involved.  The problem is that the MSAL_GUARD_CONFIG factory method is being invoked before the promise of the APP_INITIALIZER has been resolved.
The error message that occurs is due to the environment-specific configuration values not being present because the MSAL bootstrapping happens before the APP_INITIALIZER promise resolves.
MSAL Logs
[vite] connecting...
app.config.ts:11 appInit called
app.config.ts:77 MSALGuardConfigFactory called
core.mjs:6531  ERROR Error: Environment is uninitialized
at _AppStartService.getEnv (app-start.service.ts:40:13)
at Object.MSALGuardConfigFactory [as useFactory] (app.config.ts:78:37)
at Object.factory (core.mjs:3322:38)
at core.mjs:3219:47
at runInInjectorProfilerContext (core.mjs:866:9)
at R3Injector.hydrate (core.mjs:3218:21)
at R3Injector.get (core.mjs:3082:33)
at injectInjectorOnly (core.mjs:1100:40)
at ɵɵinject (core.mjs:1106:42)
at Object.MsalGuard_Factory [as factory] (azure-msal-angular.mjs:339:34)
handleError @ core.mjs:6531
Show 1 more frame
Show less
app-start.service.ts:29 got config: Object
core.mjs:29749 Angular is running in development mode.
client.ts:173 [vite] connected.
Network Trace (Preferrably Fiddler)

[ ] Sent
[ ] Pending

MSAL Configuration
{
  auth: {
    clientId: env.msalConfig.auth.clientId,
    authority: env.msalConfig.auth.authority,
    redirectUri: '/',
    postLogoutRedirectUri: '/'
  },
  cache: {
    cacheLocation: BrowserCacheLocation.LocalStorage
  },
  system: {
    allowNativeBroker: false, // Disables WAM Broker
    loggerOptions: {
      logLevel: LogLevel.Trace,
      loggerCallback: (level, message, containsPii) => {
        if (containsPii) {
          return;
        }
        switch (level) {
          case LogLevel.Error:
            console.error(message);
            return;
          case LogLevel.Info:
            console.info(message);
            return;
          case LogLevel.Verbose:
            console.debug(message);
            return;
          case LogLevel.Warning:
            console.warn(message);
            return;
          default:
            console.log(message);
            return;
        }
      }
    }
  }
}

Relevant Code Snippets
import { APP_INITIALIZER, ApplicationConfig } from '@angular/core';
import { provideRouter, withDisabledInitialNavigation, withEnabledBlockingInitialNavigation } from '@angular/router';
import { routes } from './app.routes';
import { AppStartService } from './services/app-start.service';
import { ApiResponse, SpaEnvironment } from './models';
import { HTTP_INTERCEPTORS, provideHttpClient } from '@angular/common/http';
import { BrowserCacheLocation, BrowserUtils, IPublicClientApplication, InteractionType, LogLevel, PublicClientApplication } from '@azure/msal-browser';
import { MSAL_GUARD_CONFIG, MSAL_INSTANCE, MSAL_INTERCEPTOR_CONFIG, MsalBroadcastService, MsalGuard, MsalGuardConfiguration, MsalInterceptor, MsalInterceptorConfiguration, MsalService } from '@azure/msal-angular';

function appInitPromise(appStartService: AppStartService): () => Promise<ApiResponse<SpaEnvironment>> {
  console.info('appInit called');
  return () => appStartService.initPromise('./assets/config.json');
}

export function loggerCallback(logLevel: LogLevel, message: string) {
  console.log(message);
}

export function MSALInstanceFactory(appEnvironmentService: AppStartService): IPublicClientApplication {
  console.info('MSALInstanceFactory')

  const env = appEnvironmentService.getEnv();

  return new PublicClientApplication({
    auth: {
      clientId: env.msalConfig.auth.clientId,
      authority: env.msalConfig.auth.authority,
      redirectUri: '/',
      postLogoutRedirectUri: '/'
    },
    cache: {
      cacheLocation: BrowserCacheLocation.LocalStorage
    },
    system: {
      allowNativeBroker: false, // Disables WAM Broker
      loggerOptions: {
        loggerCallback,
        logLevel: LogLevel.Info,
        piiLoggingEnabled: false
      }
    }
  });
}

export function MSALInterceptorConfigFactory(appEnvironmentService: AppStartService): MsalInterceptorConfiguration {
  console.info('MSALInterceptorConfigFactory');

  const env = appEnvironmentService.getEnv();

  const protectedResourceMap = new Map<string, Array<string>>();
  protectedResourceMap.set(env.apiConfig.uri, env.apiConfig.scopes);

  return {
    interactionType: InteractionType.Redirect,
    protectedResourceMap
  };
}

export function MSALGuardConfigFactory(appEnvironmentService: AppStartService): MsalGuardConfiguration {
  console.info('MSALGuardConfigFactory called');
  const env = appEnvironmentService.getEnv();
  return {
    interactionType: InteractionType.Redirect,
    authRequest: {
      scopes: [...env.apiConfig.scopes]
    },
    loginFailedRoute: '/login-failed'
  };
}

const initialNavigation = !BrowserUtils.isInIframe() && !BrowserUtils.isInPopup()
    ? withEnabledBlockingInitialNavigation() // Set to enabledBlocking to use Angular Universal
    : withDisabledInitialNavigation();

export const appConfig: ApplicationConfig = {
  providers: [
    provideHttpClient(),
    provideRouter(routes, initialNavigation),
    {
      provide: APP_INITIALIZER,
      useFactory: appInitPromise,
      multi: true,
      deps: [AppStartService],
    },
    // MSAL
    {
      provide: HTTP_INTERCEPTORS,
      useClass: MsalInterceptor,
      multi: true,
    },
    {
      provide: MSAL_INSTANCE,
      useFactory: MSALInstanceFactory,
      deps: [AppStartService],
    },
    {
      provide: MSAL_GUARD_CONFIG,
      useFactory: MSALGuardConfigFactory,
      deps: [AppStartService],
    },
    {
      provide: MSAL_INTERCEPTOR_CONFIG,
      useFactory: MSALInterceptorConfigFactory,
      deps: [AppStartService],
    },
    MsalService,
    MsalGuard,
    MsalBroadcastService,
  ],
};

Reproduction Steps

Clone https://github.com/jefedeltodos/app_initializer_msal_issue
Install the dependencies with npm i
Start the application with npm start
Open http://localhost:4200 in a browser.

Expected Behavior

The APP_INITIALIZER is invoked and the promise is resolved.
The MSAL_GUARD_CONFIG factory is invoked (along with the other MSAL components)
The application loads successfully in the browser.

Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge, Safari
Regression
No response
Source
External (Customer)

I don't know if this is an MSAL issue, or a general Angular issue that should be opened with them.


feat: update to latest ipld-resolver

needs:

https://github.com/ipld/js-ipld-resolver/pull/76

npm test died unexpectedly :(


Setting sync fails after signing in with MSAL

Testing #234768

Backup and Sync Settings
Sign in
Choose Microsoft
After login successfully, I got following error and setting sync didn't continue with the new account

This should have fixed it:
https://github.com/microsoft/vscode/pull/236011


arch: arm: userspace: minor refactor in z_arch_is_user_context

Refactor z_arch_is_user_context() for ARM, so it uses
the CMSIS CONTROL_nPRIV_Msk instead of the hard-coded 0x1.
Fix also some typos.
Signed-off-by: Ioannis Glaropoulos<EMAIL_ADDRESS>Trivial. No behavioral change.

Doesn't harm to backport it, but no real value, either.

The cyclic inclusions of the cmsis headers in ARM builds is a real challenge....


Ability to check the BackgroundImage property of a WinForm control

Describe the feature
I want to check a label's backgroundImage to know if it has a backgroundImage or not. and that's a label control, but FlaUi displays it as a panel and there is no relevant property for the background image on it.
Workarounds
Right now I'm using a not-so-good solution, which is to take a picture of the control and compare it to the expected picture. This method is inefficient. And I have not found a better solution to this issue.
Additional context
Another solution that comes to mind is to be able to store a logical or numerical value in a control attribute and be able to check the value of the stored attribute instead of checking the background image. However, this solution has two problems: firstly, the source code must be changed, and secondly, there is no common property for the control displayed with the control used in the source code.

UIA is not very good with images. I think there is no default property for a background image at all anywhere.
The workaround with taking a picture is ok and should work. The only other way is to create your own AutomationProperty where you set either the picture or the number as you descripe. This of course needs an adjustment of the application and even registering new UIA properties, which I've never tried with WinForms, just with WPF, where it is pretty straight forward.


get_height_magnet for HoleMagnet classes

To simplify the function comp_FEMM_dict it would be great to have a get_height_magnet method for the HoleMagnet daughter classes (HoleM50, HoleM51...).

Closed with #12


ReactJS automatically assigns a value to empty prop with the name of the prop itself

Description
In ReactJS when you use a component that takes a prop without value, the beautifier automatically assigns to that props a string containing the name of the props itself.
Input Before Beautification
This is what the code looked like before:

test

Expected Output
The beautified code should have looked like this:

test

Actual Output
The beautified code actually looked like this:

test

Checklist
I have:

[x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue

Any update on this issue guys?

The problem remains. Could not have an option in the settings for this?

This is fixed in the latest version of Pretty Diff.  We just need to get the latest version of Pretty Diff into the application.


Create a queue maintenance bot

Currently we are totally and utterly unable to affect any real change on the issue queue because we get another 5 issues for every 1 we close. Most of these are garbage issues that should be pointed at the Google Group or Gitter channel, but the cognitive load of having them open is brutal.
To that end (And massive thanks to @laurence-hudson-tessella for the brilliant suggestion), I've started work on a Mary Poppins config for C3, which I'm developing at https://github.com/aendrew/c3-issue-bot. Please feel free to PR.
Will close this issue once the bot is deployed.

Any luck with Mary Poppins @aendrew ?


[WIP]Fix profiler for plugins like redirect

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #121

Documentation
n/a

License
MIT

This is a work in progress proposal to fix #121.
The issue occurs when a plugin like redirect is triggered, it's code create a new request and then calls $first($newRequest). By doing so, the data collector is completely messed up and show the new request in the stack which created the request and in a new request stack.
We have to find a way to not mess the display. My proposal is to inject in the debug stack a plugin that when called with a RequestInterface mark the beginning of a new request and when called with a ResponseInterface mark the end of the current request.
If called with a RequestInterface twice without intermediary call with ResponseInterface, we could mark the beginning of a new request and also mark this new request as coming from the first one.
The current changes in this pull-request are only made to show how the current display gets cluttered.
Current panel rendering (1.8MB png)
HttplugBundle configuration:
httplug:
    clients:
        centrale:
            config:
                timeout: 2
            factory: httplug.factory.guzzle6
            plugins:
                - App\Http\Plugin\AuthorizationPlugin
                - add_host:
                    host: 'localhost'
                - header_set:
                    headers:
                        Accept: application/json
                - httplug.plugin.error
                - httplug.plugin.logger
                - httplug.plugin.redirect
    plugins:
        logger:
            logger: monolog.logger.httplug

The triggered request was GET /api/user which redirects to /api/entities/1e24fb4a-e250-11e6-b52d-0242ac140002
To Do

[ ] Write a fix!
[ ] Update CHANGELOG.md.

Using objects is probably better and will help to write tests :)
If you look at my screenshot, the output is completly cluttered.
Initial request was GET /api/user which redirects to /api/entities/1e24fb4a-e250-11e6-b52d-0242ac140002.
What do you think about stopping the current profile when a new request start and mark this new request as child of the first one?

What do you think about stopping the current profile when a new request start and mark this new request as child of the first one?

Yes, lets try that.

Keep in mind that you can also have request in parallels when doing async, this is why tracking origin of redirect request is very hard.

Keep in mind that you can also have request in parallels when doing async, this is why tracking origin of redirect request is very hard.
Thanks for this reminder. What about adding an uuid as header in messages for better tracking? The only drawback I see is begin a header so it will be sent with the request! But only when using the profiler.

What about adding an uuid as header in messages for better tracking? The only drawback I see is begin a header so it will be sent with the request! But only when using the profiler.

I have a hard feeling with custom header, but the more i see the RedirectPlugin the more i think it's the only way to do that

We could use X-Request-ID: f058ebd6-02f7-4d3f-942e-904344e8cde5 (https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Common_non-standard_request_fields)
I didn't yet know well all httplug internals, but where could we copy the header from the request to the response to continue tracking?

According to https://github.com/php-http/HttplugBundle/blob/master/Collector/DebugPlugin.php#L11 the debug plugin is inserted between each plugin. Could we write something like this:
        return $next($request)->then(function (ResponseInterface $response) use ($request, $collector, $clientName, &$depth) {
            //Copy the header from request to response.
            $response->withHeader('X-REQUEST-ID', $request->getHeader('X-REQUEST-ID');
            $collector->addResponse($response, $clientName, $depth--);

            return $response;
        }, function (Exception $exception) use ($collector, $clientName, &$depth) {
            //Do something here too.
            $collector->addFailure($exception, $clientName, $depth--);

            throw $exception;
        });

We could also, just before sending the request to the client, remove the header to don't get it sent and add it in the response returned by the client.

i did not look into the code in detail, but can't we use our code to track it in the callback we pass? i just think having to change request / response in any way to track them is wrong - but also should not be needed.

something like
        $id = generate_uuid();

        return $next($request)->then(function (ResponseInterface $response) use ($request, $collector, $clientName, &$depth, $id) {
            ...

            return $response;
        }, function (Exception $exception) use ($collector, $clientName, &$depth) {
            //Do something here too.
            $collector->addFailure($exception, $clientName, $depth--);

            throw $exception;
        });

After some valuable thoughts with @dbu on Slack, I propose a new solution for tracking messages.
The idea is to decorate each stack plugin with a DebugPluginDecorator which wraps the $next and $first callback before calling the plugin.
As you can see in the following code, each response or failure is linked to the corresponding request. This allows for any request to get the corresponding response or failure when rendering a row in the panel.
Each request object is linked to the previous one which allows to get the request message chain.
When a request is added to the collector with addFirstRequest, it's marked as a new request which will be displayed as #Request {id} in the profiler.
With such tracking we should avoid mess created by async requests and by plugins that use the $first callback.
class DebugPluginDecorator implements Plugin
{
    /**
     * @var Plugin
     */
    private $plugin;

    /**
     * @var Collector
     */
    private $collector;

    /**
     * @param Plugin $plugin
     */
    public function __construct(Plugin $plugin, Collector $collector)
    {
        $this->plugin = $plugin;
        $this->collector = $collector;
    }

    /**
     * {@inheritdoc}
     */
    public function handleRequest(RequestInterface $request, callable $next, callable $first)
    {
        $wrappedNext = $next;
        $wrappedFirst = $first;
        $originalRequest = $request;

        $nextWrapper = function (RequestInterface $request, callable $next, callable $first) use ($wrappedNext, $originalRequest) {
            $this->collector->addRequest($request, $originalRequest); //Add the request to the collector with the original request as parent.
            return $wrappedNext($request, $next, $first)->then(function (ResponseInterface $response) use ($originalRequest) {
                $this->collector->addResponse($response, $originalRequest); //Add the response corresponding to the original request.
                return $response;
            }, function (Exception $exception) use ($originalRequest) {
                $this->collector->addException($exception, $originalRequest); //Add the exception corresponding to the original request.
                throw $exception;
            });
        };

        $firstWrapper = function (RequestInterface $request, callable $next, callable $first) use ($wrappedFirst, $originalRequest) {
            $this->collector->addFirstRequest($request, $originalRequest); //Add the request as a first request to the collector with the original request as parent.
            return $wrappedFirst($request, $next, $first)->then(function (ResponseInterface $response) use ($originalRequest) {
                $this->collector->addResponse($response, $originalRequest); //Add the response corresponding to the original request.
                return $response;
            }, function (Exception $exception) use ($originalRequest) {
                $this->collector->addException($exception, $originalRequest); //Add the exception corresponding to the original request.
                throw $exception;
            });
        };

        $this->plugin->handleRequest($request, $nextWrapper, $firstWrapper);
    }
}

I added the concept of profiles to keep together the request, response and failure of every executed plugin.
To get the tracking working, each plugin has to be decorated with a DebugPluginDecorator.
Such implementation still lack tracking profile chain. I'm looking for ideas for this topic.
I didn't tried yet, but this implementation will also suffer of the same request sent more than once. Ideas are welcome for this topic too!

A profile is the result of one plugin execution. However this lack storage is not perfect as executing the same request will override values. I probably should not hash profile to avoid such case.

I have something working locally. Should I care BC? I'm asking for BC because I made a lot of changes in the profiler internals to get this working.

Awesome. Yes, we should care about BC. Though, you should know our BC promise. http://docs.php-http.org/en/latest/httplug/backwards-compatibility.html
I've just checked quickly. But I think your changes are safe.

I pushed my new profiler implementation. I didn't fixed tests yet as we have to chose to break BC or not. I also didn't added yet unit tests. I also need to make styleci and scrutinizer happy!

Code is now ready to review.
After getting this PR merged, we will be able to deprecate the debug_plugins as there are no longer used by the profiler.

@dbu I addressed all changes you requested.
I tried this new profiler in a specially crafted symfony app.
If you think it's valuable, I could add functional tests :)

If you think it's valuable, I could add functional tests :)

well, this is no production feature, so i think its ok without them. some amount of functional tests would not hurt but we should probably focus on things that might break in a live system. if the debug mode has an issue its not as terrible.

I'm working on fixing unit tests. I replaced $this->expectsException calls with $this->setExpectedException which is deprecated since phpunit 5.2. But I don't think there is an alternative that works with older phpunit and does not throw any deprecation notice.
I also have an error I don't understand. Could someone look at https://travis-ci.org/php-http/HttplugBundle/jobs/201864827#L291?

I addressed the "code cleanups". I added constructors for Profile and Stack and removed no longer used set methods.

For the build still failing, is it possible to re-trigger a build on master. It may be related to something incompatible since twig 2.0 is out (https://travis-ci.org/php-http/HttplugBundle/jobs/186351795#L192).

Just made a quick test. Im using a plugin client with RedirectPlugin and RetryPlugin. Im sending a request to http://www.happyr.com which should redirect to https://happyr.com and then to https://happyr.com/sv
Im getting 3 requests which is fine. But I am not too sure the response is correct in all requests. See screenshot.

The output may looks weird as in request 2, in the response column of the redirect plugin, you get the final response from request 3 and in the same happens with the response column of the redirect plugin from request 1 being exactly the same as the final response from request 2.

The output may looks weird as in request 2, in the response column of the redirect plugin, you get the final response from request 3 and in the same happens with the response column of the redirect plugin from request 1 being exactly the same as the final response from request 2.

Exactly, could we change that somehow? Or, would it make sense? Do we want to change that? What do you think?

At some point, I wanted to display that request 2 is from redirect plugin in request 1 stack and the same for the request 3. I didn't spent lot of time on it. I think it need to add more tracking, probably by wrapping the $first callback to know when a plugin is making a new request from the current one (in opposition of a totally new request sent from the client).

@Nyholm I pushed class documentation. What kind of informations should I add to the changelog?
Tracking request hierarchy will be improved in an other PR.

awesome work, thanks a lot!


jsk_recognition: 1.2.14-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository jsk_recognition to 1.2.14-1:

upstream repository: https://github.com/jsk-ros-pkg/jsk_recognition
release repository: https://github.com/tork-a/jsk_recognition-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.3
previous version for package: 1.2.10-0

audio_to_spectrogram

No changes

checkerboard_detector

No changes

imagesift

No changes

jsk_pcl_ros
* [jsk_pcl_ros] add tf_duration parameter in depth_image_creator (#2535 <https://github.com/jsk-ros-pkg/jsk_recognition/issues/2535>)
* Contributors: Shumpei Wakabayashi

jsk_pcl_ros_utils

No changes

jsk_perception
* remove packages=['jsk_perceptoin'] (#2536 <https://github.com/jsk-ros-pkg/jsk_recognition/issues/2536>)
* fix

Contributors: Kei Okada

## jsk_recognition

- No changes

## jsk_recognition_msgs

- No changes

## jsk_recognition_utils

- No changes

## resized_image_transport

- No changes

closing due to https://github.com/ros/rosdistro/pull/26880#issuecomment-706518061. Sorry for trouble.


Rename 'project' to 'collection'

#644

No idea why codecov says the coverage dropped 1.72%.   Literally the only changes are renaming things.

Ah sorry, just realized today that the API has typo:
COLLECTIONS = "/dp/v1/collection",
COLLECTION = "/dp/v1/collection/{id}",

instead of using plural 😄
COLLECTIONS = "/dp/v1/collections",
COLLECTION = "/dp/v1/collections/{id}",

CC: @Bento007 @seve
Thank you!


python312Packages.tencentcloud-sdk-python: 3.0.1169 -> 3.0.1170

Diff: https://github.com/TencentCloud/tencentcloud-sdk-python/compare/refs/tags/3.0.1169...3.0.1170
Changelog: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.1170/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 320630 run on x86_64-linux 1

4 packages built:

python311Packages.tencentcloud-sdk-python
python311Packages.tencentcloud-sdk-python.dist
python312Packages.tencentcloud-sdk-python
python312Packages.tencentcloud-sdk-python.dist


Webscale Logging

Adds a Loki installation to make our logging webscale.
Log querying is:

Faster (through replicas and caching)
Easier (through new Grafana plugins and features of Loki 3.0)
WEBSCALE (through the % increase of Golang in our stack)

Converting this to a draft temporarily to address the following:

[ ] Update Olli to factor in change of API URL
[ ] Investigate potential benefits of hooking Loki into AlertManager (could be nothing, but there is an option and I'm not sure what it does)
[ ] Add Prometheus scrape flags onto Loki as well as the Loki Canaries to monitor log aggregation issues

[ ] Related to this, seeing if Minio has a Prometheus endpoint and scraping off that might not be a bad shout.

Hi Joe, thanks for your hard work on this draft. Product would like some more data on this "webscale" concept. Can we quantify by how much our service has become more webscale and what the customer impact is?
We've recently been having robust conversations with Bingus Ltd, one of our largest prospective enterprise customers, about their concerns migrating to our service. They expressed doubt over whether our service is sufficiently webscale to handle the kind of traffic they expect to bring our way. Product is seriously considering adding webscale to our 2024 roadmap. Looking forward to hearing about how we can WOW our customers with this technology! - M

Hi Joe, thanks for your hard work on this draft. Product would like some more data on this "webscale" concept. Can we quantify by how much our service has become more webscale and what the customer impact is?

Mark, THANK YOU!
We now deploy 3 REPLICATED versions of Loki, all able to ingest and process logs, we load balance the distribution of logs to AGENTS (NOT government ones), located on each node.
We deploy CANARIES to ensure that Loki is active and able to ingest logs.
We deploy MINIO to retain our distributed logs, it is AI-READY!
We deploy a GATEWAY to bring traffic to one of the 3 Loki replicas.
We deploy a CACHE to cache chunks of logs for queries without having to reach out to Minio, this uses MEMCACHED! (WEBSCALE, SOFTWARE!)


Infinite recursion occurs when calling MallocExtension::instance() from a custom operator new

Hi!
I have encountered a problem that was discussed in these issues:

https://github.com/gperftools/gperftools/issues/852
https://github.com/gperftools/gperftools/issues/718

I have prepared a minimal example to reproduce it.
#include <gperftools/tcmalloc.h>
#include <gperftools/malloc_extension.h>

void* operator new(size_t size)
{
    auto ptr = tc_malloc(size);
    auto sz = MallocExtension::instance()->GetAllocatedSize(ptr);
    // log size allocation ...
    return ptr;
}

void operator delete(void* p) _GLIBCXX_USE_NOEXCEPT
{
    tc_free(p);
}

int main()
{
    auto pi = new int;
    delete pi;
    return 0;
}

Compile it with:
clang++ -g main.cpp -Wl,-rpath,. -L. -ltcmalloc_minimal

Calling MallocExtension::instance() leads to calling operator new, which, in turn, leads to calling MallocExtension::instance(). This causes an infinite recursion.
I have tried two solutions:

Compiling the tcmalloc_minimal library with the linker option -Bsymbolic, which forces the library to use functions implemented inside itself (especially operator new). The problem with this solution is that I can't track memory allocations inside the tcmalloc library in this case.
You can add add_link_options(-Wl,-Bsymbolic) in CMakeLists.txt and rebuild the library.

Another approach proposed in issue 718. Using placement new fixes the problem. You can see a possible fix in this
placement_new.patch

Which solution is the best?

yes, it makes sense. I am frankly surprised we didn't do it earlier. Applying this shortly.

yes, it makes sense. I am frankly surprised we didn't do it earlier. Applying this shortly.

Applied. Thanks.
Next time, please consider offering proper git patch so that I don't have to be formal author of your commit and risk forgetting to refer to your contribution in the NEWS file.

Applied. Thanks.
Next time, please consider offering proper git patch so that I don't have to be formal author of your commit and risk forgetting to refer to your contribution in the NEWS file.


Introduction texts

It would be great if someone can first write the introduction texts for the front page of repository as of now it looks like empty.
Or else,  we can put in our meeting agendan to generate some README.md

for example here

I can do it

This is closed by the addition of README.md file in the repository here


feat(utxoBulk): Adding REST API endpoint for UTXO bulk queries

:tada: This PR is included in version 1.11.0 :tada:
Your semantic-release bot :package::rocket:


feat: ajour page gestion des organismes

fix #2770

:tada: This PR is included in version 3.15.0 :tada:
The release is available on:

GitHub release
v3.15.0

Your semantic-release bot :package::rocket:


Box Scores Lineup Order

Is there an order to the lineup? I can't seem to understand the array order.
For example, from the two teams of the same matchup:
matchup = box_scores[0]
print("Home Team")
for player in range(0, len(matchup.home_lineup)):
    print(matchup.home_lineup[player].name + "\t" + matchup.home_lineup[player].position)
print("\nAway Team")
for player in range(0, len(matchup.away_lineup)):
    print(matchup.away_lineup[player].name + "\t" + matchup.away_lineup[player].position)

Output:
Home Team
Michael Thomas  WR
Joe Mixon       RB
Derrick Henry   RB
Brandin Cooks   WR
Tyler Boyd      WR
Phillip Lindsay RB
Austin Ekeler   RB
Tarik Cohen     RB
Austin Hooper   TE
Ben Roethlisberger      QB
Donte Moncrief  WR
Stephen Gostkowski      K
Golden Tate     WR
Will Dissly     TE
Ravens D/ST     D/ST

Away Team
Christian McCaffrey     RB
Antonio Brown   WR
Devonta Freeman RB
Cooper Kupp     WR
Sony Michel     RB
Devin Singletary        RB
Matt Ryan       QB
Vance McDonald  TE
Rams D/ST       D/ST
Dante Pettis    WR
Courtland Sutton        WR
Tyrell Williams WR
Matt Bryant     K
Kalen Ballage   RB
Jaylen Samuels  RB

I assumed the lineup would follow ESPN lineup order with QB typically first, but I can't see a pattern to the order. Finding it hard to loop through lineup to calculate values like starter scores vs. bench scores.

Found a workaround by using slot_position.

Yeah the slot_position is used for where they are lined up in


Apply function makes profiling impossible in Firefox

Instead of seeing a full breakdown, you just see the entire CPU time taken up by calls to A:
/* Apply
   Applies the function f to the arguments args. If the application is under-
   saturated, a closure is returned, awaiting further arguments. If it is over-
   saturated, the function is fully applied, and the result (assumed to be a
   function) is then applied to the remaining arguments.
*/
function A(f, args) {
    if(f instanceof T) {
        f = E(f);
    }
    // Closure does some funny stuff with functions that occasionally
    // results in non-functions getting applied, so we have to deal with
    // it.
    if(!(f instanceof Function)) {
        f = B(f);
        if(!(f instanceof Function)) {
            return f;
        }
    }

    if(f.arity === undefined) {
        f.arity = f.length;
    }
    if(args.length === f.arity) {
        switch(f.arity) {
            case 0:  return f();
            case 1:  return f(args[0]);
            default: return f.apply(null, args);
        }
    } else if(args.length > f.arity) {
        switch(f.arity) {
            case 0:  return f();
            case 1:  return A(f(args.shift()), args);
            default: return A(f.apply(null, args.splice(0, f.arity)), args);
        }
    } else {
        var g = function() {
            return A(f, args.concat(Array.prototype.slice.call(arguments)));
        };
        g.arity = f.arity - args.length;
        return g;
    }
}

I'm not sure if much can really be done about this. Really, it probably just reflects a problem with Firefox, if it doesn't seem to detect .apply() calls. But I'm wondering if maybe it could be worked around, somehow.

 Getting rid of it has been a TODO thing for a long time, but hasn't been done yet.

It looks like apply exists to curry non-curried functions. But that begs the question: why isn't everything already curried?

In browsers that support them, ES6 splats are an option. The first branch becomes:
    if(args.length === f.arity) {
        switch(f.arity) {
            case 0:  return f();
            case 1:  return f(args[0]);
            default: return f(...args);
        }

The second:
    } else if(args.length > f.arity) {
        switch(f.arity) {
            case 0:  return f();
            ase 1:  return A(f(args.shift()), args);
            default: return A(f(...args.splice(0, f.arity)), args);
        }

The third:
    } else {
        var g = function() {
            return A(f, args, ...Array.prototype.slice.call(arguments));
        };
        g.arity = f.arity - args.length;
        return g;
    }

Given how this simplifies things, it might be possible to simplify and inline this? Who knows.
Not sure yet if it improves performance or profiling.

In the STG we get back from GHC there are still partial applications, so they need to be handled somehow. A() is a catch-all solution to that problem, but not a very good one.

I'd test this out, but I've had trouble setting up an environment where I can develop Haste. It doesn't seem to like booting within a cabal sandbox, for example.

I decided to just install globally instead from git. Unfortunately, now my code won't run at all: https://github.com/valderman/haste-compiler/issues/324

However, it seems the profiling situation wasn't quite as bad as I thought it was. I might not have been looking in the right place in the tree before.


Will importing from a flat file like a CSV ever be possible?

Hey,
I love Pocketbase and it is a great project. But, I'm trying to build a small POS (Point of Sale) software using Pocketbase and it is going great but I'm thinking about what would happen if I get a customer that has an existing POS. How will I import his existing data from his current POS into mine?
I've read a couple of questions about this topic from last year but just wondering if this will get added in the near future.
Thank you, and keep up the good work!

Please check https://github.com/pocketbase/pocketbase/issues/48#issuecomment-1211775627.

How will I import his existing data from his current POS into mine?

You can insert the data directly into the pb_data/data.db file using the sqlite3 tool (eg. sqlite3 pb_data/data.db '.import test.csv foo --csv'), but keep in mind most of the time you'll have to adjust the data so that it can match with your PocketBase collections structure. There is no automated solution for this.
If you need help with the import, feel free to open a new Q&A discussion provide more details about your collections structure and the data you want to import and I'll try to help.

sqlite3 pb_data/data.db '.import test.csv foo --csv'
doesn't work for me ??

@amirkhalil22 It works fine for me. It could be something specific to the windows cmd.
In any case, you don't have to execute it as one-line. You can run sqlite3 pb_data/data.db and then type .import YOUR_CSVFILE YOUR_TABLE --csv.
You can find more information about the SQLite cli in https://sqlite.org/cli.html.


ratelimit: dynamic configuration of max_calls and duration via redis

In order to be able to adjust our rate limiting on the fly it would be good to be able to dynamically configure it through redis.
This allows the values to be changed without deploying or restarting worker. This will allow us to slowly approach our API quotas.
The main risk is increased traffic to redis. I think redis should be able to handle a couple hundred requests per second easily though. So I'm not too worried. In the worst case we can cache the config value in memory though and update it every couple seconds (maybe using something like go-cache).
To set the values:
trvs redis-cli travis-production REDIS_URL set worker-rate-limit-gce-api-1:gce-api:max_calls 3000
trvs redis-cli travis-production REDIS_URL set worker-rate-limit-gce-api-1:gce-api:duration 100s

That should make the rate-limiter perform 3000 calls per 100 seconds across all workers in production-1.
refs https://github.com/travis-ci/reliability/issues/222

I guess this is pretty close to a circuit breaker. :)


Actually useful doc comments

eg on each mod we have the mod name as a doc comment..

Pushed in #46


The usage in the README incorrect

The README states:
Use the following command to run this script:

`python3 graph_ql.py graph_ql_authorization_key jira_authorization_key jira_url jira_project_key`

However, the code requires an additional arg as indicated in arguments.py
vulnerabilities_issue_created_track_path = sys.argv[5]

May I know what will be the value of vulnerabilities_issue_created_track_path?


Minor spec fixes

This PR just corrects a couple of tiny issues I had with the saltpack spec.
First, it changes uses of "MB" to be "MiB", and adds the definition of 1 MiB (= 2^20 bytes) the first time it is referred to in each page of the spec. This is a really tiny pedantic thing, but I had to double check with the Go implementation when implementing the spec from scratch myself, since people often mean 10^6 bytes when they say MB. No worries if you don't want to merge this one :smile:
Second, it updates specs/saltpack.md to be in line with the current working links to the parts of the spec, and fixes a very small formatting bug in specs/saltpack_encryption_v2.md, which makes it appear weirdly when the Markdown is parsed.
Thanks!

LGTM. Thanks again!

We've pushed saltpack.org, so you should see these changes live now.

Perfect, thank you!


NoAnimation Property in LUA?

Describe your problem here.
can you have the 'dad' character not play an anim using LUA?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

dad.stunned


Improve the message when run coverage while there are no tests

🐛 Bug Report
When you run jest with --coverage but there are no tests, it shows error "Jest: Coverage data for global was not found."
To Reproduce

Delete all test files e.g. *.test.js

Run jest --config=jest.json --coverage with below configuration in jest.json:

{
  "testEnvironment": "node",
  "coverageThreshold": {
    "global": {
      "branches": 90,
      "functions": 90,
      "lines": 90,
      "statements": -10
    }
  },
  "collectCoverageFrom" : [
    "*.js"
  ]
}

Expected behavior
A simple and clear error like "No tests found", or simply skipping coverage, or coverage report as usual (and failed 100%).
Link to repl or repo (highly encouraged)
https://github.com/Tiendq/lego-part-loader
Run npx envinfo --preset jest
System:
    OS: macOS Sierra 10.12.6
  Binaries:
    Node: 10.0.0 - /usr/local/bin/node
    Yarn: 1.6.0 - /usr/local/bin/yarn
    npm: 5.6.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^22.4.3 => 22.4.3

I'd like to try this if no one is on it 😄

Go for it :)

I'm looking into this issue and I can't seem to reproduce the issue so I'm quite lost.
I've run jest --config=jest.json --coverage on the repo that @Tiendq provided above and got the following message
No tests found
In /Users/jayhwang/Documents/bug-test
  7 files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - 0 matches
  testPathIgnorePatterns: /node_modules/ - 7 matches
Pattern:  - 0 matches
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There is no sign of Jest: Coverage data for global was not found.
I also tried it with the master branch of jest and got the following
No tests found
In /Users/jayhwang/Documents/bug-test
  7 files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - 0 matches
  testPathIgnorePatterns: /node_modules/ - 7 matches
Pattern:  - 0 matches

You need to include --coverage

I did include coverage
jest --config=jest.json --coverage

@misoguy I couldn't reproduce it too :(, I checked package.json history and Jest version is still same.

I am getting same issue here, my case has one more option: --changedSince=master

I could reproduce @zlk89 case, it seems that there is something unstable here.
jest --config=jest.json --coverage --changedSince=master

I am getting same issue here, my case only in watch mode --watch.
pakage.json
...
  "jest": {
    "transform": {
      "^.+\\.tsx?$": "ts-jest"
    },
    "testRegex": "/tests/.*\\.spec\\.tsx?$",
    "moduleFileExtensions": [
      "ts",
      "tsx",
      "js",
      "jsx",
      "json",
      "node"
    ],
    "collectCoverage": true,
    "coverageDirectory": "coverage",
    "coverageThreshold": {
      "global": {
        "branches": 80,
        "functions": 80,
        "lines": 80,
        "statements": -10
      }
    }
  },
...

bash Jest
$ npx jest --watch

No tests found related to files changed since last commit.
Press `a` to run all tests, or run Jest with `--watchAll`.
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|
Jest: Coverage data for global was not found.

bash envinfo
$ npx envinfo --preset jest

  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
  Binaries:
    Node: 10.0.0 - /usr/local/bin/node
    Yarn: 1.6.0 - /usr/local/bin/yarn
    npm: 6.0.1 - /usr/local/bin/npm
  npmPackages:
    @types/jest: ^22.2.3 => 22.2.3
    jest: ^22.4.3 => 22.4.3

@misoguy kindly ask if there is any update on this?

@zlk89 I'm sorry, lately I didn't really find time... Feel free to take this issue if you'd like, if not I'll try to find time to tackle this issue soon 😄

I also want to try it too but it won't be done quickly, I'm new to Jest codebase :) and it seems that the issue happens with many cases.

Here's where that error is thrown, should be able to add the check you need somewhere in that function with a nice explination