Minifier settings

Subject of the issue
which options are used when minimizing jquery.validate.js
I tried to minimize the original file again with https://skalman.github.io/UglifyJS-online/
The result is not valid.
Your environment

version of jquery-validate: 1.18.0
which browser and its version: ie11.09600

please find our build setup in https://github.com/jquery-validation/jquery-validation/blob/3a7e59365429598ef8612e8d57580870178c5a52/Gruntfile.js#L72
usually minifying an already minified lib is not supported by those minify tools and therefore can lead to errors.
Will close for now. Feel free to ask further questions regarding this topic here. We can re-open if required.


[Doc] Modules Update

This pull request has automatically created by PinpointAutoBot
Updated Item : [elasticsearch-rest-high-level-client, google-http-client, netty-all, grpc-stub] has been updated
*Updated item list may differ if this PR is updated*

Codecov Report

Merging #6362 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6362      +/-   ##
==========================================
+ Coverage   39.57%   39.58%   +<.01%
==========================================
  Files        3063     3063
  Lines       91425    91425
  Branches    11839    11839
==========================================
+ Hits        36185    36193       +8
+ Misses      52262    52250      -12
- Partials     2978     2982       +4

Impacted Files
Coverage Δ

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
75% <0%> (-10%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.1% <0%> (-4.64%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.9% <0%> (-1.94%)
:arrow_down:

...m/navercorp/pinpoint/profiler/AgentInfoSender.java
84.15% <0%> (-1%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.4% <0%> (+0.32%)
:arrow_up:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.98% <0%> (+0.7%)
:arrow_up:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0032ef...29b045a. Read the comment docs.


update pkg-config test to work on windows

part of https://github.com/SCons/scons/pull/3052

Current CI builds from my branch:
Appveyor: https://ci.appveyor.com/project/dmoody256/scons/build/1.0.413
Travis: https://travis-ci.org/dmoody256/scons/builds/383995503


Request testing of AMD card users

General description of bug:

What happened: I had 2 gpus on my laptop: AMD integrated GPU and NVIDIA 3060 Mobile (discrete gpu), fastfetch detected AMD as dGPU but no NVIDIA 3060 Mobile
What should happen: NVIDIA 3060 Mobile should be detected to dGPU but not AMD integrated GPU
Fastfetch version used: fastfetch 2.10.2-debug (x86_64)
Did it work in an older version: IDK
Where did you get the binary: ArchLinux Offcial Repository
Does this issue still occurs in the latest dev build?

Often helpful information:
Screenshot:

The content of the configuration file you use (if any):
There has no configuration file i used
Output of fastfetch --list-features:
threads
vulkan
wayland
xcb-randr
xcb
xrandr
x11
drm
gio
dconf
dbus
imagemagick7
chafa
zlib
xfconf
egl
glx
osmesa
opencl
libpulse
libnm
libddcutil
videodev2
Directx Headers
Proprietary GPU driver API
System yyjson

FYI: when i run fastfetch with flag --gpu-force-vulkan, outputs is correct:

I think is these codes cause wrong detection: https://github.com/fastfetch-cli/fastfetch/blob/bdd2908e6ae152bf011797230ec40881c89f9623/src/detection/gpu/gpu_linux.c#L67

I actually don't have an AMD GPU. Can you paste the result of following command here?
cat /sys/class/drm/card{0,1,2}/device/{mem_info_vram_total,mem_info_vram_used,mem_info_vis_vram_total,mem_info_vis_vram_used,mem_info_gtt_total,mem_info_gtt_used,smartshift_apu_power,smartshift_dgpu_power,smartshift_bias}

I actually don't have an AMD GPU. Can you paste the result of following command here?
cat /sys/class/drm/card{0,1,2}/device/{mem_info_vram_total,mem_info_vram_used,mem_info_vis_vram_total,mem_info_vis_vram_used,mem_info_gtt_total,mem_info_gtt_used,smartshift_apu_power,smartshift_dgpu_power,smartshift_bias}

Here is what you need:
4294967296
1009135616
4294967296
1009135616
31523540992
201281536

你别把报错信息删了，我分不清哪个数据对应哪个文件。。。

或者你看下官方文档，对照一下你系统的文件，看看有没有能区分是独显和集显的。
https://docs.kernel.org/gpu/amdgpu/driver-misc.html

Seems no one can be used to identify the GPU type.
Let's disable the GPU type detection

hwmon interface seems contain interesting data. Notably

Northbridge voltage (APUs only)
GPU memory clock (dGPU only)

https://www.kernel.org/doc/html/v5.10/gpu/amdgpu.html#hwmon-interfaces
What do ls -l /sys/class/drm/card?/device/hwmon?/{freq1_input, in1_input} and cat /sys/class/drm/card?/device/hwmon?/{freq1_input, in1_input} print?

hwmon interface seems contain interesting data. Notably

Northbridge voltage (APUs only)
GPU memory clock (dGPU only)

https://www.kernel.org/doc/html/v5.10/gpu/amdgpu.html#hwmon-interfaces
What do ls -l /sys/class/drm/card?/device/hwmon/hwmon?/{freq1_input, in1_input} and cat /sys/class/drm/card?/device/hwmon?/{freq1_input, in1_input} print?

FYI:
Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

.r--r--r-- 4.1k root 29 4月  15:01 /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

.r--r--r-- 4.1k root 29 4月  15:01 /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

400000000

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

943

It seems card1 doesn't has files or symlinks as you said but only card0 (a.k.a amdgpu)

I'm sorry. It should be cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input

I'm sorry. It should be cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input
And what does ls -l /sys/class/drm/card0/device/hwmon/hwmon? print?

It seems card1 doesn't has files or symlinks as you said but only card0 (a.k.a amdgpu)

It was expected. All these files are amdgpu only

FYI:
Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon?:
lrwxrwxrwx 1 root root    0  4月29日 15:01 device -> ../../../0000:05:00.0
-r--r--r-- 1 root root 4096  4月29日 15:01 freq1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 freq1_label
-r--r--r-- 1 root root 4096  4月29日 15:01 in0_input
-r--r--r-- 1 root root 4096  4月29日 15:01 in0_label
-r--r--r-- 1 root root 4096  4月29日 15:01 in1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 in1_label
-r--r--r-- 1 root root 4096  4月29日 15:01 name
drwxr-xr-x 2 root root    0  4月29日 09:57 power
-r--r--r-- 1 root root 4096  4月29日 15:01 power1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 power1_label
lrwxrwxrwx 1 root root    0  4月29日 09:57 subsystem -> ../../../../../../class/hwmon
-r--r--r-- 1 root root 4096  4月29日 15:01 temp1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 temp1_label
-rw-r--r-- 1 root root 4096  4月29日 09:57 uevent

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input:
NO SUCH FILE OR DIRECTORY

I have implemented a version. It should correctly detect the GPU type of your AMD iGPU and NV dGPU. It should also print the GPU frequency for the AMD iGPU (in your case, 0.4GHz should be printed)
https://github.com/fastfetch-cli/fastfetch/actions/runs/8878225530/artifacts/1456489814

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input:
NO SUCH FILE OR DIRECTORY

Cool!

I have implemented a version. It should correctly detect the GPU type of your AMD iGPU and NV dGPU. It should also print the GPU frequency for the AMD iGPU (in your case, 0.4GHz should be printed)

cool, i will test it.

If you specify --gpu-driver-specific, fastfetch should print more information for both iGPU and dGPU.

seems not working, emmm

https://github.com/fastfetch-cli/fastfetch/actions/runs/8878546945/artifacts/1456557467
This one please.

https://github.com/fastfetch-cli/fastfetch/actions/runs/8878546945/artifacts/1456557467
This one please.

It seems working right now, cool.

This one: https://github.com/fastfetch-cli/fastfetch/actions/runs/8878762801/artifacts/1456601026

AMD driver only reports current GPU frequency, while fastfetch reports max frequency for both CPU and non-AMD GPUs. I wonder if I should remove it.

@CarterLi  i think i need to test new gpu detection is working on Wayland, wait plz

What does /sys/class/drm/card0/device/uevent print?

@CarterLi i think i need to test new gpu detection is working on Wayland, wait plz

seems to working on Wayland.

What does /sys/class/drm/card0/device/uevent print?

What about /sys/class/drm/card0/device/revision

card1 if you needed:

I think it's enough to close this issue. Thanks for your help.


Thousand separators for honor display disappears whenever honor score is updated

So, thousand separators for honor display was a recent addition to CW platform. It makes your honor look like this:

However, I noticed since the day it was out that sometimes the separators disappears from an already open webpage:

I just spent a little time experimenting, and it seems that whenever a user's honor score is updated (due to completed kata. Not sure about other honor sources, can't test them readily) the honor display is updated too, but the thousand separator isn't inserted in the updated display.
This happens in the same tab you just completed a kata on as well, so testing it is as easy as to just find a random 7kyu kata and complete it.

1000's separator is also absent from the number displayed on user profile page, user profile badges, etc

I think this is caused by the following code:
App.PubSub = {
  // ...
  handleModelUpdate: function(e) { // {id: string, updates: {honor: number}}
    console.dir(e);
    if (e.updates)
      return Object.keys(e.updates, function(t, n) {
        return $("[data-rt='" + e.id + ":" + t + "']").text(n) // <--
      })
  }
}

Object.keys seems to have multiple non-standard definitions in application.js, but I think the above uses the following:
function keys(t, n) {
  var r = Object.keys(t);
  r.forEach(function (e) {
    n.call(t, e, t[e])
  })
  return r;
}


Definition of "Recovered"

How is "recovered" defined? Please add a note to the chart. Does "recovered" include only hospitalised cases who are discharged? Is it only those who have tested negative after a positive test? How are people who test positive and then self isolate with no hospitalisation removed from the "active" cases?
"Recovered" seems very low given that here were 121 active cases 3 weeks ago.

Recovered is currently only hospitalised cases who recovered and were discharged. As was mentioned in today's press conference the government is working on technical solution to relay the actual recovered number.

It would be better to call it "Discharged" rather than "Recovered".  I would add a total for "Hospitalised" or "Admitted" and group it with "In treatment", "Deaths" and "Discharged", where "Hospitalised" is the sum of these three.
Getting figures for "recovered" and "deaths" for people who were not hospitalised may be hard to track on a daily basis.  Better to stick to what we know.

Terviseamet changed their wording to make it clear that it is not recovered, but rather just released from the hospital. We have updated our application to reflect this change and also removed active cases for the time being as it is not clear how many patients have recovered, in the sense that they have no symptoms or have given a negative test.


Updated example to build and run on latest React Native

Summary
While trying to submit a separate PR, I wanted to add something to the test app to allow testing that. I tried a few times, but due to bugs and changes since the version of React Native that was included, I couldn't get it to work.
This fix:

Upgrades react-native for the example app. It takes as much of the config from a fresh npx react-native init project as possible
Upgrades dependencies to be compatible with latest react-native

Made example app use Podfiles, per new versions
Upgraded flow, ran yarn validate:flow
Upgraded detox, ran build and test commands; made Android DetoxTest use androidx libraries and upgraded package.json commands

Adds new commands to package.json to run the example app, modeled off of react-native-webview

yarn start:ios runs iOS - tested on Simulator
yarn start:android runs Android - tested on real device

Tips for reviewers
All manual changes to the React Native boilerplate have comments with "added for" in them, so a quick Ctrl + F wil find most of those.
Test Plan

Tested by running:
yarn install
yarn test

yarn start:ios
yarn start:android

# Adjust settings for device in package.json if needed before these blocks
yarn test:detox:android:build:debug
yarn test:detox:android:test:debug
yarn test:detox:android:build:release
yarn test:detox:android:test:release
yarn test:detox:ios:build:debug
yarn test:detox:ios:test:debug
yarn test:detox:ios:build:release
yarn test:detox:ios:test:release

What's required for testing (prerequisites)?
Nothing other than the commands above
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[X] I have tested this on a device and a simulator (no iOS device, only emulator)
[ ] I added the documentation in README.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

@bartolkaruza - you seem to be the main maintainer! Thanks a lot for your work on this repo. Take a look and see if this might be something you're interested in merging.

@bartolkaruza - thanks for maintaing this package! Can you take a look at this change? It's very helpful to submit this before #178

@hsource thank you for this, awesome contribution (from maintainer point of view :))! I've updated the circleci build orb on master, which should solve the build issue on this PR. Could you try rebasing on master to see if that worked?

It wasn't passing due to a missing set of setup lines required for the circleci orb. I added them to android/app/build.gradle and it works now

@hsource Perfect, thank you!

:tada: This PR is included in version 1.7.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add CONTRIBUTING.md, pull_request_template.md and ISSUE_TEMPLATE.

To see this running:
issues:
https://github.com/ederign/notebooks/issues/new/choose
PR:

@thesuperzapper ^

@jiridanek @thesuperzapper, can we merge this as a starting point?


CSV mode, usernames are without quotes

Hi,
First of all, thanks for such an useful utility!
Now, when I tried to export some chat history, I found that one username has ',' in it, and usernames field is not surrounded by quotes. Can you please change CSV writer to put quotes around username field?
Thanks,

@Kosat I think, we need to quote all usernames.

Nope, according to the rfc4180 we can use quotes only when needed. If a field doesn't contain 'problematic' characters then the quotes can be omitted.
Check this part of RFC. Note the part (6), where they use quotes in row 1: "aa ... ccc" and then in row 2: zz ... xxx they don't use quotes because there are no special characters in fields there.
   6.  Fields containing line breaks (CRLF), double quotes, and commas
       should be enclosed in double-quotes.  For example:

       "aaa","b CRLF
       bb","ccc" CRLF
       zzz,yyy,xxx

Ignore the 01efdd0. It should be like in 5f155fd.

You can now check v0.3.4 release.


Add from_base64url Presto Function

Resolves: https://github.com/facebookincubator/velox/issues/4336

Thanks @aditi-pandit for your feedback. I have accommodated all the suggestions.
Not sure why the format check is failing though, any suggestions?

Can you run make format-fix to fix the formatting?

@ashokku2022 : The linux-build failure shows a failure for fromBase64Url test. Please can you investigate.
173: [  FAILED  ] StringFunctionsTest.fromBase64Url

@aditi-pandit I ran fuzzer as follow, here is the output
velox_expression_fuzzer_test  --seed 123456 --duration_sec 60 --repro_persist_path --logtostderr=1 --minloglevel=0  --only from_base64url  --v=1 2>&1 | tee fuzzertest.out
from_base64url
E20230322 06:05:01.909464 6389639 Exceptions.h:68] Line: /Users/ashokku/velox/./velox/functions/lib/string/StringImpl.h:435, Function:fromBase64Url, Expression:  Base64::decode() - invalid input string: string length cannot be 1 more than a multiple of 4., Source: USER, ErrorCode: INVALID_ARGUMENT
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

Seeing 0, I was bit unclear about its output so I ran fuzzer for already implemented scalar function like from_base64 and from_hex and output for them were similar. Please let me know if I am doing something wrong. Thanks!
from_base64
E20230322 06:14:26.242478 6396509 Exceptions.h:68] Line: /Users/ashokku/velox/./velox/functions/lib/string/StringImpl.h:417, Function:fromBase64, Expression:  Base64::decode() - invalid input string: invalid characters, Source: USER, ErrorCode: INVALID_ARGUMENT
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

from_hex
E20230322 06:18:54.691723 6400229 Exceptions.h:68] Line: /Users/ashokku/velox/./velox/functions/lib/string/StringImpl.h:371, Function:fromHex, Expression:  Invalid hex character: z, Source: USER, ErrorCode: INVALID_ARGUMENT
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

@aditi-pandit looks like fuzzer test failed in linux-build, however, locally it succeed for me. Can you look into it please?
I20230323 11:51:06.154752 7636365 ExpressionFuzzer.cpp:1158] ==============================> Done with iteration 17556
I20230323 11:51:06.154791 7636365 ExpressionFuzzer.cpp:972] ==============================> Top 1 by number of rows processed
I20230323 11:51:06.154806 7636365 ExpressionFuzzer.cpp:974] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230323 11:51:06.154819 7636365 ExpressionFuzzer.cpp:978] from_base64url 17557 100.00% 305767
I20230323 11:51:06.154836 7636365 ExpressionFuzzer.cpp:984] ==============================> Bottom 1 by number of rows processed
I20230323 11:51:06.154850 7636365 ExpressionFuzzer.cpp:986] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230323 11:51:06.154863 7636365 ExpressionFuzzer.cpp:991] from_base64url 17557 100.00% 305767
I20230323 11:51:06.154878 7636365 ExpressionFuzzer.cpp:1004] ==============================> All stats sorted by number of times the function was chosen
I20230323 11:51:06.154891 7636365 ExpressionFuzzer.cpp:1006] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230323 11:51:06.154904 7636365 ExpressionFuzzer.cpp:1010] from_base64url 17557 100.00% 305767

Thanks @ashokku2022 . Please can you squash your commits if possible.


Some question about time-related attribute of a client.

Hi, I'm new here and use the wakaama client and server for testing lwm2m.
Now I'm trying to add time-related attributes(PMIN/PMAX) to get notify on server.
Some problems I don't understand:
(1) If I set the time attribute to /5, it doesn't sending the notify of all the resources under the /5 object.
(2) If I set the time attribute to /5/0/1 then it is not possible to set time attribute to /5. (But it works in reversed way.
(3)If I set /5 to 100/200(PMIN/PMAX) and /5/0/1 to 10/20(PMIN/PMAX), what should be the correct behavior for observing
/5 ?
BTW, how do I set the timeout of writing command on server ?
Thanks in advance.

I don't know how it behave in wakaama.
But at a LWM2M specification point of view, I understand that :
(1) I'm not sure I get you but if you mean that "if pmin/pmax is set at /5 level then those attributes are applied to all resources under /5" then it's correct to me.
(2) it should be possible to set pmin/pmax at both level, object (/5) and resource(5/0/1) level in any order.  (so looks like a bug)
(3) 100/200(PMIN/PMAX) should be used for /5.
See for more details : http://www.openmobilealliance.org/release/LightweightM2M/V1_1_1-20190617-A/HTML-Version/OMA-TS-LightweightM2M_Core-V1_1_1-20190617-A.html#5-1-1-0-511-Attributes-Definitions-and-Rules

Hi, it is so happy to get your response. : )
(1) I use the time to set PMIN/PMAX to object 5 then observe /5, but it doesn't
send the notify of all resources value under object 5 (/5/0/1, /5/0/3...) as I expected.
One more question, is it possible to clear the time-related attribute of a client ?
Thanks a lot!

Still from a specification point of view (I don't know if this is implemented in wakaama), this is possible using an empty attribute with WRITE-ATRIBUTES request.
See : http://www.openmobilealliance.org/release/LightweightM2M/V1_1_1-20190617-A/HTML-Version/OMA-TS-LightweightM2M_Core-V1_1_1-20190617-A.html#6-3-4-0-634-Write-Attributes-Operation

Parameter
Required
Default Value
Notes

<NOTIFICATION> class Attributes
Yes

Indicates which Attributes are concerned. When an Attribute is specified without value, it means this Attribute value is unset at the level specified in the operation (Object, Object Instance, Resource, or Resource Instance levels).

Just in case that was not clear, to remove pmin/pmax on /5, send : Write-Attributes /5?pmin&pmax

Just in case that was not clear, to remove pmin/pmax on /5, send : Write-Attributes /5?pmin&pmax

Thanks. It seems no way to do that on Wakaama now ? (with which operation ?)

I don't know we must wait from active committers to get more details about Wakaama behavior.
But there are some hint (toClear) which show that maybe this is possible :

https://github.com/eclipse/wakaama/blob/459ac9217ce3a84de90f3a021686e9d61d2f4c91/include/liblwm2m.h#L641L650
https://github.com/eclipse/wakaama/blob/10d5b725c0b2009f7e91588958ab5c776f9d13ae/core/observe.c#L334

Noted, thanks for your reply.

@sbernard31 Maybe I have misunderstood but I am not sure about "(3) 100/200(PMIN/PMAX) should be used for /5." since pmin pmax are attached on resource level even thou they can be assigned on object level.
In the example given by @Asher9977 all resources under /5 except /5/0/1, i.e., /5/0/3, /5/0/5 ... will have 100/200(PMIN/PMAX) attached, whereas /5/0/1 will have 10/20(PMIN/PMAX) attached. So wouldn't an observe on /5 have 10/20(PMIN/PMAX) since one resource will trigger the update more frequently?

I have the same understanding of observation, assignation, and attachment. Maybe I have misunderstood assignation and attachment. If the attachment is the same as assignation then the expected behavior would be as described in https://github.com/OpenMobileAlliance/OMA_LwM2M_for_Developers/issues/478 but my understanding is that it is not.
"So currently, I'm lost... 😅", me too

@tuve there is some news at https://github.com/OpenMobileAlliance/OMA_LwM2M_for_Developers/issues/478 (but still not clear to me for now),  maybe you should watch the issue.
(Maybe already done but) In a more general way, I think it could be a good idea that the whole Wakaama team  (@rettichschnidi, @mlasch , @qleisan)  watch those github repositories :

https://github.com/OpenMobileAlliance/OMA_LwM2M_for_Developers/issues
https://github.com/OpenMobileAlliance/lwm2m-registry/issues

I think those are good place to discuss about the specification all together (Wakaama, Leshan, OMA and probably other devs)


"Tohanu Nou" is listed in the drop-down menu

Description:
"Tohanu Nou" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Tohanu Nou" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oraș Tohanu Nou, BRAȘOV (ZĂRNEȘTI)".


7.0 release date?

Since 7.0 just came out of Elasticsearch, how long will it typically take for NEST to be updated to 7.0?
I see there's already a branch for it.

We will be releasing an alpha for 7.0.0 soon, looking at either tomorrow (friday) or monday baring anything major showing up.
If you want to move already: https://ci.appveyor.com/nuget/elasticsearch-net

has preview builds for 7.x e.g NEST version 7.1.0-ci20190411T072428.
Also hosts namespaced packages e.g NEST.v7 which allows you to more gradually move towards 7. All types in that package live in Nest7 or Elasticsearch.Net7.

Why an alpha?
There will be some more breaking changes after that release

grouping of NEST client methods, e.g now you have client.CloseJob and client.MachineLearningInfo()both pertain toMachine Learningbut are hard to discover to we will move these toclient.MachineLearning.CloseJob()andclient.MachineLearning.Info(). Api's such as Search() Bulk() Index()` won't be moved.

Lowlevel client will be cleaned up, we now generate methods for every PATH + httpmethod + Sync/Async making manouvring the lowlevel client a chore. We will introduce namespacing here as well as culling the ammount of generated methods

NEST has an interface for each response. Since all of these have one implementation this adds unnecessary weight to the assembly. They were added to facilitate mocking ages ago https://github.com/elastic/elasticsearch-net/pull/59 but we feel that mocking the client usually indicates you are not mocking components but implementations. cc @ThomasArdal

NEST uses a dispatch mechanism to go from highlevelclient.Search() to lowlevelClient.Search() this is all generated code thats adds to the weight of the dll that we like to cull as well see: #3658

Several more refactorings of internals and performance related improvements will go in as well.
So why release?
The current 7.x branch is tested against 7.0.0 and ready to go,

It deals with the type removal on Elasticsearch server side
Includes our move away from our internalized Json.NET (NEST) / SimpleJson (Elasticsearch.NET) to an internalized UTF8Json which brings performance improvements.

7.0.0 GA
No date is set but it has our complete focus at the moment but no target release date exists as of yet. We are looking for some (3-4) additional weeks to get all our desired changes in.

How can i install the alpha version ?
i got
This XML file does not appear to have any style information associated with it. The document tree is shown below.

How likely is that the the v6.x client would work against a v7 cluster assuming it doesn't hit any of the deprecated bits in elastic? Is this a worthwhile consideration or would using the pre-release 7/x library be preferable to this?

I'm looking forward to this release, it will be interesting how hard it is to implement custom serialization naming :).

We have just released 7.0.0-alpha1!
Nuget: https://www.nuget.org/packages/NEST/7.0.0-alpha1
Release Notes: https://github.com/elastic/elasticsearch-net/releases/tag/7.0.0-alpha1

@andrewrimmer - we wouldn't recommend using a 6.x client against a 7.x cluster. You'd be better going with the alpha1 release as above ^

Any news on the release date?

@aaronsarkissian not at this time; we are working hard on getting to GA as soon as possible

We have released 7.0.0-alpha2!
Nuget: https://www.nuget.org/packages/NEST/7.0.0-alpha2
Release Notes: https://github.com/elastic/elasticsearch-net/releases/tag/7.0.0-alpha2
Thank you to everyone who has opened issues and submitted feedback with 7.x so far, it is very much appreciated 👍

Any news on the progress towards 7.0.0?

@kbandrew we're looking at putting out a beta in the very near future, and are collecting issues that must be addressed for this in #3563.

Closing this ticket, please keep tracking https://github.com/elastic/elasticsearch-net/issues/3563 for updates on the 7.0.0 release.

Just wondering, can this Nest v7 used for Elasticsearch v6.x? Or it must pair with Elasticsearch v7 and not backward compatible?

@leelcs I remember that they were saying to avoid using different versions of the Nest and Elasticsearch. In some cases, it just throws an error but even if it works in other cases, it may cause unexpected behaviors. The main reason may be from the JSON parser differences in 6 and 7.

Currently the 7.0.0 GA client is recommended for use against a 7.0.0 cluster.
That said, we did run the integration tests against a 7.1.1 server and they all passed, not every test passed when run against a 7.2.0 cluster - it will be very much at your own risk and not something we recommend if you choose to do this.
Using a 6.x client against a 7.x cluster, or vice-versa, is not recommended - as mentioned above there are very likely to be substantial differences in the requests/responses across major versions.

@codebrain I am surprised that the 7.0.0 client is not recommended for the latest 7.x version of elasticsearch. We have been waiting for the 7.x client, and assumed it would be better to install the latest version of elasticsearch (to pickup teething issues and fixes in elastic). Are you able to expand on what sort of tests were failing on 7.2?
My expectation was that there would be no breaking changes between minor versions of elasticsearch, is that not the case?
When I looked at the .net client compatibility matrix, I had assumed  that any 7.x client should work against any 7.x cluster, and that if you are behind the elastic minor version that there may be new features not yet supported.
In terms of planning future cluster upgrades, should we always be looking to keep in perfect sync with the major.minor version of the .net client?
Lastly do you have any idea when the 7.2 client might be ready?
In general is it a case of the .net client dropping when it is ready, or do you have rough targets on the lag between the elastic version dropping and when the .net client will add support?
Sorry for all the questions :), and thanks for all the great work.

@codebrain did you have any comments/thoughts on my previous post? Would it be better for me to raise a separate issue?


XGBoostError  when  run custom_rmsle.py

macOS Catalina, xgboost 0.90.

XGBoostError: [16:01:20] src/metric/metric.cc:23: Unknown metric function rmsle

when run demo custom_rmsle.py

To run the custom_rmsle, you will need to compile XGBoost from the latest source, as 0.90 release is not compatible with it.

@hcho3 Can we set the link of doc to latest release instead of master?  Or a more obvious label that shows one is reading doc in master branch?

There is the version selector at the bottom right corner of the doc page. I do think that the version can be made clearer. See example at https://cmake.org/cmake/help/v3.12/command/target_link_libraries.html


Publishing to only specific topics makes empty client id and session items

Describe the bug
I am using MQTTnetApp to test my implementation with MQTTnet broker. This is a very weird problem I found: messages I published to the topic /v1/me/device/configuration/request makes empty MqttApplicationMessageInterceptorContext. Messages are intercepted with the same method, and getting client Id is done on each message intercept. It works fine, except if the topic is on the one written above.
I am curious if there are limitations, or reserved words that causes that to happen.
Which component is your bug related to?

Server

To Reproduce
Steps to reproduce the behavior:

Using this version of MQTTnet 3.1.2
Build the broker with this simple ApplicationMessageInterceptor and connection validator:

private async Task ProcessMessage(MqttApplicationMessageInterceptorContext arg)
    {
        string? clientId = arg.ClientId;
        var deviceId = (string) arg.SessionItems["username"];

    private async Task ValidateConnection(MqttConnectionValidatorContext arg)
    {
        string? clientId = arg.ClientId;
        string? deviceId = arg.Username;

        if (string.IsNullOrEmpty(deviceId))
        {
            arg.ReasonCode = MqttConnectReasonCode.NotAuthorized;
        }
        else
        {
            Device? device = await Device.WithId(deviceId);
            arg.SessionItems["username"] = arg.Username;
            arg.ReasonCode =
                device is null ? MqttConnectReasonCode.BadUserNameOrPassword : MqttConnectReasonCode.Success;
        }
    }

With MQTTnetApp (Multimeter), publish a message to /v1/me/device/configuration/request
See error (null client Id, and empty session item).

Expected behavior
I expect it to work just like all the other topics.
Screenshots

Thanks in advance!
Edit: I now changed the topic to /v1/me/device/config/req and it does happen too

My bad, that empty client ID one comes from messages that is meant to be replies. I then return if client ID is empty to ignore it.


Bot stops sending messages

After a short amount of time messages from our bot does not go into chat.
var client = new irc.client({
    options: {
        debug: true,
        debugIgnore: ['ping'],
        logging: false,
        tc: 1
    },
    identity: {
        username: 'DolphinBot23',
        password: 'oauth:xxxx'
    },
    channels: [channel]
});

the connection is established and he can send messages, after a few seconds (maybe 30) the connection is still there but the bot doesn't send any messages. This is urgent.

It doesn't send any messages but does it receive messages ?

It receives messages. It also answers them but the messages don't go into chat.

I will look onto this right now but I can't promise you any fix if I can't reproduce this error..

client.prototype.say = function(channel, message) {

console.log(channel);
console.log(message);

    var self     = this;
    var deferred = q.defer();
    // Socket isn't null and channel has been joined..
    if (self.socket !== null && self.currentChannels.indexOf(utils.remHash(channel).toLowerCase()) >= 0) {
        self.socket.crlfWrite('PRIVMSG ' + utils.addHash(channel).toLowerCase() + ' :' + message);
        deferred.resolve(true);
    } else { deferred.resolve(false); }

    return deferred.promise;
};

when I add that, the messages and the right channel are displayed in the output. But the never make it into chat. I haven't change anything to our bot.

This is so strange.. everything is fine on my end with a bot using TC1 and another one with IRCv3 tags.. what if you add console.log(err); right after this line ? Also, did you try with another server ? maybe one of the new Twitch chat server is eating the messages ?

I think it is a problem with this. I connect to two channels, but in self.currentChannels there is only the second channel.

Can you replace the content of client.js with this and tell me if it works ? https://gist.github.com/Schmoopiie/a0fb13cc22256255d894

Bot just restarted with your file

Come in http://www.twitch.tv/schmoopiie/

I can't our stream is running but it seems to be fine so far. :-)
Our channel is http://www.twitch.tv/laurenevans23

Alright, let it run 5 minutes and keep me updated

Yepp, it works really fine. Was it a bug in your library?  :-)

Yes it was a problem related to TWITCHCLIENT 1.. the way the library works is that it is initializing the internal variables when the bot joins a channel, but TC1 makes it trigger the join event multiple times for that channel so I had to make it check if it's the bot joining and not someone else.

It works now. Our chat has 100+ people and I'm the only mod, so I need a bot on my side. ;-)

Yeah, I am on the channel :smile: I will bump the version again I guess.. 3 version bump this morning -_-

Thank you for fixing it so fast. <3

My pleasure ;-)


Please publish version 1.9.1 to fix compatibility with Twitch add-on 2.1.0

https://github.com/khloke/play-to-xbmc-chrome/pull/131 was merged into master, but has not been published to the chrome web store. Twitch support is currently broken. I have to manually patch the extension to get it working. It's a pain because Chrome frequently reloads the extension and loses the patch.

See also #126

Done. It should be live in about 24 hrs.


[STORM-2744] add in restart timeout for backpressure

JIRA-STORM-2744
Backpressure mechanism relies on zookeeper to transfer signals.
If at some point, the topology wants to turn off the throttle but zookeeper failed to delete the backpressure node, then the throttle will be on. And in that case, it's very likely that the znode will never be deleted and thus the throttle will always be on. The spouts will stop indefinitely.
We want to add a restart timeout so that even the above case happens, the spouts can continue to work.

I did some simulation test.
The command I ran is:
storm jar /tmp/storm-loadgen-2.0.0-SNAPSHOT.jar org.apache.storm.loadgen.ThroughputVsLatency --rate 20000 --counters  12 --splitters 6 --spouts 3 -t 60 -c topology.workers=3

The behavior before the code change:
At about timestamp 241, I created a znode under backpressure/topology-id manually. Quickly the rate (tuple/s) dropped and became 0. At about timestamp 391, I deleted the znode manually. The rate increased and the spouts were catching up. This is the expected behavior of original storm.

The behavior after the code change:
At about timestamp 211, I created a znode (with timestamp set to System.currentTimeMillis()) under backpressure/topology-id. The rate dropped quickly. Then after 30s, the spouts were catching up. Even though the znode I created still exists in zookeeper, it's no long valid because its timestamp is out of date.

@govind-menon @srdo @knusbaum  Thanks for the review. Will address them soon

@govind-menon @srdo  I think I have address all your comments. I tested it with different configs. Could you please take another look when you get a chance? Thanks

@govind-menon @srdo are you OK with the changes?

+1, thanks @Ethanlm.


Manage Peers using wg-api

I would like to manage remote wireguard installs without having to copy the wireguard config files there and reloading wg.
wg-api seems to be a perfect fit for this usecase as it allows to create and remove peers using the api. Persistence is ensured using SaveConfig in the wg-quick config.

i am thinking about rewriting whole project to use wg-api but a couple of things are blocking:

all components in docker containers ?
how to manage networking rules (nat) ?

Personally I have wg-gen-web running in docker on my Synology nas, wireguard on my rpi4 and wg-api in docker on rpi4.

I would suggest using https://github.com/WireGuard/wgctrl-go directly (that is also what wg-api uses internally), so you do not need an separate container for wg-api. I use it myself in https://github.com/h44z/wg-portal and it works flawlessly.


Textures with transparency?

Hi there
Right now, if I use PNGs or SVGs with transparency as textures for my bodies, the background will always be white.
My goal is to use the built in fillStyle option and, at the same time, have a texture with transparency on top of that.
Is this possible? Am I missing something?
Thanks for your help!

I'm pretty sure this would most likely be a limitation of the HTML canvas, as opposed to the matter.js library.

The sprites example shows using transparent PNGs. I've not tried using SVGs as sprites though, but assume it should work the same if canvas supports it. The built in renderer doesn't support using both sprites and filled shapes at the same time unfortunately though, you'd have to add your own support for that.


Add RSS Feed Information to FAQ

Also add translation support? But it should be self-explanatory to anyone reading it.

Coverage remained the same at 24.341% when pulling a4f0fbff58d0c95e962b6e9a70a832441c134485 on yiiTT-add-rss-feed-info into 3e22adca7b83862868fe44558bd4abd7186fc36e on dev.

Coverage remained the same at 24.341% when pulling d469a76a8b16c11febc98c0c6e1600250c3f0eeb on yiiTT-add-rss-feed-info into 3e22adca7b83862868fe44558bd4abd7186fc36e on dev.

Coverage remained the same at 33.139% when pulling bfece93de91d5002af5f41b9acacfaa923132da8 on yiiTT-add-rss-feed-info into de1ace16246da4dce4fe73debb47df68039a696e on dev.


[Question] EventProcessorClient is very slow to initialize each partition

Describe the bug
When starting an EventProcessorClient, it takes approximately 10 seconds to connect to each partition in the EventHub. In our case, we have 30 partitions, which means it takes ~300 seconds for the client to start up.
Expected behavior
In the v4 version of the client, it connected to all 30 partitions in under a second. The v5 version seems to be a huge step down in terms of startup performance. I'm hoping it's just some setting we can configure ...
Actual behavior (include Exception or Stack Trace)
Notice the timestamps:

To Reproduce
var blobClient = new BlobContainerClient("<SA connection string>", "<container name>");
var eventHubclient = new EventProcessorClient(blobClient, "<consumer group>", "<EH connection string>");

eventHubclient.StartProcessingAsync();

Environment:

Azure.Messaging.EventHubs.Processor 5.0.1
Windows 10.0.18363 (1909)
.NET 3.1.101
Visual Studio 16.4.5

Hi @TaffarelJr, thank you for reaching out with feedback.   The current load balancing implementation for the processor is tuned for helping multiple processors share the load without a high degree of contention for each partition, which results in partitions "bouncing" between processors as they are added/removed, causing processing for those partitions to slow down.
We recognize that there are scenarios where this isn't an ideal design and those using fewer processors with a higher partition count would see a slower initialization, such as you are.  I'm happy to say that we're currently working through a plan to expose the ability to tune configuration of the load balancer to allow for more aggressive claiming of partitions and an adjustable lease duration.
It is our hope that these additional options should allow you more control over load balancing so that you can find the right balance for your scenario.  Unfortunately, I don't have any dates that I can share at the moment, but I can confirm that this is something we would like to release in the near-term and are actively working on.

It looks like the discussion here has tapered off.   I'm going to close this out to reflect that.  Please feel free to reopen if there's additional insight that we can provide.


[New Feature]: Update DAPA Endpoint name in api-gateway

Checked for duplicates
Nope.
Alternatives considered
Yes, no satisfying alternative exists.
Related problems
No, but will make urls more memorable/easier for a user.
Describe the feature request
Currently, to access data/collections within a unity environment (dev, test), one needs to access the API Gateway and then interact with an /am-uds-dapa endpoint. This is fine for internal use, but since it gets exposed to the user for collection, granule, and processes calls, i'd like this to be a bit more generic.
Can we update the builds and environments to create a /data endpoint? This would be a bit clearer and consistent across the environments. We'll need to work with @jjacob7734 from U-AS to get this working as it will impact him as well.
Ideally, we'd support both endpoints (/am-uds-dapa AND /data) and be able to monitor traffic as we switch them over. I'm curious if we should also add a version there? /data/v1/collection... to allow us to version the API if needed. I've included Ramesh here to discuss the versioning options and to make him aware.

This is a change in terraform API gateway repo in U-CS (i think) plus this variable during deploy time.

From UDS deployment terraform uds_base_url needs to be updated if it is not cloudfront URL but API gateway URL.
dapa_api_prefix also needs to be updated.
unity-rest-api-gateway-oas30.yaml also needs to be updated, but this is a deprecated location. I'm not sure the new location.
I think only those 3 places needs to be updated for a different prefix like /data.

@wphyojpl and @ngachung , Instead of centrally managing  unity-rest-api-gateway-oas30.yaml, now we update API gateway paths using terraform. These terraform scripts does not have to be in a single centralized terraform script. Anyone who has access to update the API Gateway can execute the terraform script to add/update paths in API Gateway.
The following code example shows the way to update an existing API Gateway with Terraform.
https://github.com/unity-sds/unity-cs-infra/blob/main/terraform-shared-services-api-gateway-updater_module/main.tf
cc: @galenatjpl


Can't create optional input

I need an optional input lets say I expect data like {name: "some name", age: 18} or {name: "some name"} but don't want {name: "some name" age: null} and this is impossible to do now or I can't find a way how to do it.
As an example I wrote a test for this, of course this does not pass:
class OptionalInputTest extends PHPUnit_Framework_TestCase
{
    /**
     * @dataProvider dataProvider
     */
    public function testNewFeature($data, $isValid)
    {
        $inputFilter = new \Zend\InputFilter\InputFilter();
        $inputFilter->add([
            'name' => 'foo',
            'required' => false,
            'allow_empty' => false,
            'continue_if_empty' => true,
            'validators' => [
                ['name' => 'StringLength', 'options' => ['min' => 2]],
            ],
        ]);

        $inputFilter->setData($data);

        if ($isValid) {
            $this->assertTrue($inputFilter->isValid());
        } else {
            $this->assertFalse($inputFilter->isValid());
        }
    }

    public function dataProvider()
    {
        return [
            [['foo' => null], false],
            [['foo' => ''], false],
            [[], true],
            [['foo' => "bar"], true]
        ];
    }
}

Maybe I overthinking this?

What you have there is correct. When I ran the above, every one of those passed except the third data set, [[], true]. This makes sense, because:

Value is not required
But value is allowed to be empty
and validators are run if the value is empty

In this case, absence of the value is the same as having a null value when you validate the set.

I understand that this is almost the same but for me it is BC because before this https://github.com/zendframework/zend-inputfilter/issues/4 it was possible to do this.
And now I will have to move this check from input filter to maybe hydrator because:
// when ['foo' => null]
$filter->getData(); // returns ['foo' => null]
// when ['foo' => '']
$filter->getData(); // returns ['foo' => '']
// when []
$filter->getData(); // returns []

they all are considred empty and when I pass this data to hydrator null and '' are run by hydrator but last one is ignored.
@weierophinney how could I solve this with inputfilter?


Add packaging tests to continuous integration

Similar to how unit tests were added to CI in #1144, it would nice to add tests for packaging a game that uses the Cesium Unreal plugin.
We see various issues from users related to packaging, so an automated way to validate this workflow is valuable. @kring
Unreal has a tutorial for packaging here
Example workflow:

Open the Unreal samples project in Unreal Editor
On the main toolbar, find the Platforms drop down
Select Windows->Package Project
Select some folder to output to
Wait until it's done

Some references for packaging problems that people have...
https://github.com/CesiumGS/cesium-unreal/issues?q=is%3Aissue+packaging+
https://community.cesium.com/search?q=%23cesium-for-unreal packaging


Add static functions to calculate ssl buffer sizes

Add two, so far unused functions to calculate the input and output ssl buffer sizes.
This solves IOTSSL-2937.
Note: this PR results in compiler warnings, since the functions are unused.

Thanks, @AndrzejKurek
We should include this commit in a PR that uses these functions. We can't merge them standalone. It breaks CI, plus maybe we find the functions aren't exactly right in current form when we try to use them.


Set more exciting text around Horizon exploration

Just tryna make it a little more hyphy :sunglasses:

Preview is available here:http://laboratory-pr965.previews.kube001.services.stellar-ops.com/

Oh wait I'll wait for the upstream v2 merge


Make rotation unit more clear

Added it to the summary element.  Fixes #219

Docs Build status updates of commit 4d313e0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/VisualElement.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Kafka<IP_ADDRESS>

Update Kafka Dependency

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   64.57%   64.57%
=======================================
  Files          16       16
  Lines         494      494
  Branches       35       35
=======================================
  Hits          319      319
  Misses        175      175

Impacted Files
Coverage Δ

...ala/cakesolutions/kafka/akka/TrackPartitions.scala
75.51% <ø> (-2.05%)
:x:

.../cakesolutions/kafka/akka/KafkaConsumerActor.scala
57.27% <ø> (+0.46%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383daea...abe20da. Read the comment docs.


add new icon MS teams device

Description
To add a new icon MS Teams Device, which will be used to represent a type of device in dialpad web settings -> Your user devices (replace '#' in the red rectangle).

The new icon is:

Pull Request Checklist

[x] Ask the contributors if a similar effort is already in process or has been solved.
[x] Review the contribution guidelines.
[x] Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
[x] Ensure all gulp scripts successfully compile.
[x] Update, remove, or extend all affected documentation.
[x] Provide a description what is being changed, extended, or removed.
[x] Link to any issue(s) this request is resolving.
[x] Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] Request a review from Drew Chandler, Joshua Hynes, or Ted Goas.

Obligatory GIF

hey @raodialpad , thanks for the PR. Are you working with a designer on this? I'm curious where this icon came from.
If you're not working with a designer, is there a reason we couldn't use <IconMicrosoftTeams /> by itself rather than combining it with <IconHashtag />?

hey @raodialpad , thanks for the PR. Are you working with a designer on this? I'm curious where this icon came from.
If you're not working with a designer, is there a reason we couldn't use <IconMicrosoftTeams /> by itself rather than combining it with <IconHashtag />?

Thanks Drew for the review, the new icon is created by Vicky @vcheng-dialpad, I think the reason is that we use it as a type of device and to differentiate it from the MS Teams brand icon that will be used in other scenarios.

hey @raodialpad , thanks for the PR. Are you working with a designer on this? I'm curious where this icon came from.
If you're not working with a designer, is there a reason we couldn't use <IconMicrosoftTeams /> by itself rather than combining it with <IconHashtag />?

Thanks Drew for the review, the new icon is created by Vicky @vcheng-dialpad, I think the reason is that we use it as a type of device and to differentiate it from the MS Teams brand icon that will be used in other scenarios.

I see. So, since this table is representing a list of devices and this icon represents single device on which MS Teams is installed, a user would have to add each individual device on which they have MS Teams (i.e. their laptop, their phone, their tablet, etc.). Am I understanding it correctly?

I see. So, since this table is representing a list of devices and it sounds like this icon represents only a single device on which MS Teams is installed, a user would have to add each individual device on which they have MS Teams (i.e. their laptop, their phone, their tablet, etc.). Am I understanding it correctly?
We do not tell the platform differences for Teams, we treat them all as one single device, so, for example, if user installed Teams on both laptop and phone, our our site, it is just one MS Teams device.

I see. So, since this table is representing a list of devices and it sounds like this icon represents only a single device on which MS Teams is installed, a user would have to add each individual device on which they have MS Teams (i.e. their laptop, their phone, their tablet, etc.). Am I understanding it correctly?

We do not tell the platform differences for Teams, we treat them all as one single device, so, for example, if user installed Teams on both laptop and phone, our our site, it is just one MS Teams device.

That makes much more sense and has been my experience as a previous MS Teams users. Anyone calling me on Teams calls me on all devices, not just a single device.
I'm talking to Vicky about this right now as well. Will get back to you soon!

closing this PR cause we will use current MS Teams icon.


HashSet addition

Currently, TreeSet allows for the definition of a Comparator and I have often felt like being able to define the hashing/equals function in the same way for HashSet etc. would be seriously useful. It came up today in discussion
Eg.
Example 1:
public static <T> HashSet<T> of(Function<? super T,?> keyProperty, T... values)
This would use the function keyProperty to get a property value to be used with a default hash/equals strategy which currently delegates to HashArrayMappedTrie
So, the current public static <T> HashSet<T> of(T... values) could set it's hashing function to Function.identity() by default.
Then, when supplying the value to be added/removed, etc to the the underlying Trie, it would always delegate to the Hashing Function
This would be a handy addition that would be easy enough to implement. Thoughts?

I may have already answered myself with HashSet.distinctBy(Function<? super T> keyExtractor)
Which makes for a fluent function like HashSet.distinctBy(MyObject::id).add(new MyObject(1));

I may have already answered myself with HashSet.distinctBy(Function<? super T> keyExtractor)

If I understood you correctly, it will not help you. For your use case you should use wrapper class which holds the object and the hashing function. Or you can overwrite hashCode method in your object.
It is possible to add requested functionality to HashSet and HashMap, but I'm not sure this would be seriously useful as you said... @danieldietrich ?

@ruslansennov Something close already exists: HashSet.distinctBy(MyObject::getId).of(new MyObject()); But it doesn't appear that the resultant set from that call actually returns a HashSet where the hashing is based on the result of the function.
As for hash/equals - Yes, I could do that; it's Java 101. To do that would require me modifying the original object or creating a new object. And, if we are following the java equals/hash bible, then equals must reject any subclass.
This would be an easy implementation. HashSet would contain a Function that would extract the key with every call and pass it along for the hash/equals compute.
In the constructor you would have
private HashSet(Function<? super T, ?> keyExtractor) {
   this.keyExtractor = keyExtractor
}

private HashSet() {
   this(Function.identity());
}

@Getter
@AllArgsConstructor
@EqualsAndHash
public class MyObject {
     private Integer id;
     private String something;
}
Set<MyObject> mySet = HashSet.keyedBy(MyObject::getId).add(new MyObject(1,"foo"));
mySet.contains(new MyObject(1,null); // true, second argument is ignored

Set<MyObject> oldSet = HashSet.keyedBy(MyObject::getId).add(new MyObject(1,"foo"));
oldSet.contains(new MyObject(1,null)); // false, assuming it doesn't blow up with a null

I am looking for functional parity with TreeSet
Basically, a method to override identity without defining a new object. Just like TreeSet

I think we should not bake a key-extractor functionality into HashSet. I see several cons:

it would increase the memory footprint and lower the runtime performance
it would increase the complexity of the underlying algorithms (Hash Array Mapped Trie), see #1391
it is uncommon compared to other collection libraries.

We could still achieve the behavior by

implementing equals and hashCode according to the required indexing behavior
using wrapper types, if the above is not possible
using a HashMap instead of a Set
using a workaround, like distinctBy (as mentioned above)

The memory usage part is a bit puzzling - I imagine a single variable reference added. But, technically, yes it would increase the memory footprint.
It would also, technically, reduce runtime by the functional call the extract the key with every call.

I concede these points but see them as not detrimental.
You're alternatives counter points:

This doesn't address the point of the proposal: I may not be in control of that and overriding these methods in a subclass would (again, following strict java guidelines) fail equality
Wrapper class is same as last bullet point. Since you would need to override 2 functions then it makes a simple functional approach to wrapping the object trickier.
Agree. Just more verbose
As I suggested in a follow up, this might work. But when I looked at the code it looks more like a 1-time view of the data.

When I look at how it's currently done the hashCode is determined based on the key input and thus this should/would be a transparent change.
Using a HashMap is essentially the same but more verbose (IMO) - I also thought of a downside to my own thoughts (just to prove I am reasonable): Once the set is created with such a function it would be entirely lost that it's not behaving as the default set. Then again, this case exists for TreeMap too.
The whole idea is for sake of convenience and code brevity. Since it's your show @danieldietrich if you're entirely against the idea then just close the ticket.

I like the idea. We could do it by introducing
@FunctionalInterface
interface Equal<T> {

    static <T> Equal<T> naturalEquality() {
        return Objects::equals;
    }

    boolean areEqual(T t1, T t2);
}

Our HashSet and HashMap are backed by HashArrayMappedTrie (HAMT) nodes, similar to TreeSet and TreeMap are backed by RedBlackTree (RBT). Currently RBT nodes own a reference to the underlying Comparator. We should remove that ref and add the comparator as argument to each method of RBT. Then we are able to keep only a single ref to the comparator in the wrapper TreeSet or TreeMap.
For HashSet/HashMap it would work the same way. Only these wrappers store a reference to Equal. The methods of the HAMT types need an additional argument of type Equal.

I would recommend EqualityChecker as name for such an interface.

Equal is a common name. For example it is known from Scalaz (see here and here).
Equal is a predicate a type is attributed with. EqualityChecker is more like a noun, a subject that does s.th. on its own. This is not the way we think. In fact Equal (resp. areEqual) is a function that is called from the outside. A function is used, it does not act by itself.


[xhr]validCORSHeaders throws cors error when origin is "null" (null but type is string)

Basic info:

Node.js version:
v7.10.0

jsdom version:
v9.10.2

Minimal reproduction case
Sorry I could not describe reproduction code.
My reproduction code uses jest and axios, I don't catch the detail reason.
I have got Cross Origin null forbidden error in my test case.
  function validCORSHeaders(xhr, response, flag, properties, origin) {
    const acaoStr = response.headers["access-control-allow-origin"];
    const acao = acaoStr ? acaoStr.trim() : null;

   // ----- debug code ----
    console.log(typeof origin) // string "null"
    console.log(typeof acao) // object null
    // throw error because acao !== origin is truthy!!

    if (acao !== "*" && acao !== origin) {
      properties.error = "Cross origin " + origin + " forbidden";
      dispatchError(xhr);
      return false;
    }
   // ....
    return true;
  }

I don't know why this origin prop is string, but I found the origin = "null" code is here.
https://github.com/tmpvar/jsdom/blob/master/lib/jsdom/living/xmlhttprequest.js#L690
Question

is this a known issue?
which origin value is correct? "null" or null.

Sorry, without a reproduction case, I don't think we can work on this. It sounds like it's working as intended. It's possible to have an origin of "null" (e.g. any opaque origin serializes as null) and to not have an ACAO header (thus acao is null). In which case it's correct to dispatch an error.
Happy to reopen if you can create a minimal reproduction case that works different in browsers.

@tly1980 thanks. You just saved my morning!  👍

@tly1980 I have no idea how you found this, but you put an end to hours of pain and suffering.
Thank you so much.

When using nock, you can fix easily by adding response headers :
      nock('http://api.test.url')
      .defaultReplyHeaders({ 'access-control-allow-origin': '*' })
     .get('/foo').reply(200, 'bar');

@tly1980 I owe you a :beer:

Hi Folks,
I would love to take the credits, however, I am not the first one who solve this out:
I solved it by reading this (SO thread) [https://stackoverflow.com/questions/42677387/jest-returns-network-error-when-doing-an-authenticated-request-with-axios]
Credits goes to this (buddy: Daniele Dellafiore )  [https://stackoverflow.com/users/510671/daniele-dellafiore]

@tly1980 you're a life saver. 👍

I'm using Mocha, how can I change my test environment for it?

Solved with Mocha (not really Mocha at all but Axios). This is what I did.
https://github.com/jsdom/jsdom/issues/2319#issuecomment-410362266

@tly1980 do you have solution for mocha?


run-wasm helper (cargo-run-wasm) for testing the wgpu runner on the web.

Opening as draft because this is blocked on wgpu::backend::web being completely broken:

~~https://github.com/gfx-rs/wgpu/issues/3430~~

the short version is that they made a Copy type convertible to a type that implement Drop, leading to a kind of UAF ("use after free") but specifically in the context of wasm-bindgen's Rust->JS value ownership

TODO(@eddyb): consider hot reloading.
EDIT: blocked on:

#1036

EDIT: this is now possible thanks to:

https://github.com/gfx-rs/wgpu/pull/3657

Had to work around some sRGB complications (and push constants) but it finally works!

cargo run-wasm --package example-runner-wgpu --bin wgpu_runner

(defaults to serving the result of the build on http://localhost:8000)

google-chrome-unstable --enable-features=Vulkan --enable-unsafe-webgpu http://localhost:8000

So I found a hackaround for the wgpu misuse of wasm-bindgen thing, see https://github.com/gfx-rs/wgpu/issues/3430#issuecomment-1480625569.
(Yupp, it's just leaking - can't UAF if there's no free - and it can be done quite fine-grained!)
Not sure how one would automate injecting it, but it's easy enough to edit the .js file by hand for testing.

On another note, we sadly can't use push constants, but that may change soon (Chrome seems to have them anyway?).

I added PushConstant-as-read-only-StorageBuffer emulation, and using that and #1018 I get:


import_legacy_api config option doesn't work

import_legacy_api config option doesn't work
Steps to reproduce

Install qcodes
Set "import_legacy_api": true in qcodesrc.json
import qcodes

Expected behaviour
The legacy API to be imported into the qcodes namespace:  https://github.com/QCoDeS/Qcodes/blob/29646a80d63da3b1f1c54503e031ef5fcab59b5a/qcodes/init.py#L24-L50
Actual behaviour
qcodes not imported due to circular import in type annotations:
(scanning-squid-test) DN0a22c3aa:Documents LoganBVH$ grep "import_legacy_api" /Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/configuration/qcodesrc.json
        "import_legacy_api": true,
(scanning-squid-test) DN0a22c3aa:Documents LoganBVH$ python -c "import qcodes"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/__init__.py", line 41, in <module>
    from qcodes.loops import Loop, active_loop, active_data_set
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/loops.py", line 55, in <module>
    from .actions import (
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/actions.py", line 5, in <module>
    from qcodes.utils.threading import thread_map
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/utils/threading.py", line 29, in <module>
    from qcodes.dataset.measurements import res_type
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/dataset/__init__.py", line 23, in <module>
    from .measurements import Measurement
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/dataset/measurements.py", line 679, in <module>
    class Measurement:
  File "/Users/LoganBVH/opt/anaconda3/envs/scanning-squid-test/lib/python3.8/site-packages/qcodes/dataset/measurements.py", line 696, in Measurement
    station: Optional[qc.Station] = None,
AttributeError: partially initialized module 'qcodes' has no attribute 'Station' (most likely due to a circular import)

I realize I can just import the legacy modules directly, but this config option should probably either be fixed or removed.
System
It would be helpful to provide such information:
operating system
MacOS Monterey 12.1
If you are using a released version of qcodes (recommended):
qcodes version: 0.31.0

@loganbvh thanks for the bug report this should be fixed by #3781 (But that will also deprecate this option going forward so I would recommend updating the imports to not use this option)


Release a new version to npm

Is it possible to release a new version to npm? There's a (merged) fix I need and I don't want to use the git repository as a dependency.

I don't see any changes to this repository other than upgrades. What version are you running?

Oh, looks like the release didn't go through. Lemme fix.

Correction: the release is out. (See https://www.npmjs.com/package/ember-plupload). The tag wasn't created in git. I just pushed the tag.


bugfix: SingleTableGPTModel._sample_with_data  "has no attribute 'result'"

Fixes a typo in SingleTableGPTModel._sample_with_data
Description
SingleTableGPTModel._sample_with_data: Line 518 returns pd.DataFrame(self.result, columns=final_columns), but SingleTableGPTModel has no attribute self.result. This should instead be the local variable "result" defined at line 494. This correction also follows the structure of SingleTableGPTModel._sample_with_metadata at line 478
Motivation and Context
Currently, the workflow of fitting a SingleTableGPTModel with a dataframe and then sampling results fails, whereas fitting with metadata instead before sampling succeeds.
If SingleTableGPTModel.fit(df) is called with df being a DataFrame, then subsequent calls to SingleTableGPTModel.sample fail with the error "AttributeError: 'SingleTableGPTModel' object has no attribute 'result'".
When SingleTableGPTModel is fit with a full dataframe and not just metadata, the model's use_raw_data flag is set to True, and calls to model.sample call self._sample_with_metadata which has a typo causing this error.
How has this been tested?
I ran into the error in the sdg_example_LLM_2 colab notebook. After adding my OPEN_AI_KEY and running the full notebook successfully, I added and ran this cell which gave me the error:
model = SingleTableGPTModel()
model.set_openAI_settings(OPEN_AI_BASE, OPEN_AI_KEY)
model.gpt_model = "gpt-3.5-turbo"

model.fit(df)
# this may take a while
model.sample(4, off_table_features = ['owns house'])

2024-04-17 15:45:02.734 | INFO     | sdgx.models.LLM.single_table.gpt:_fit_with_data:247 - Fitting model with raw data...
2024-04-17 15:45:12.819 | INFO     | sdgx.models.LLM.single_table.gpt:_fit_with_data:272 - Fitting model with raw data... Finished.
2024-04-17 15:45:12.825 | INFO     | sdgx.models.LLM.single_table.gpt:sample:388 - Sampling use GPT model ...
2024-04-17 15:45:12.829 | INFO     | sdgx.models.LLM.single_table.gpt:_sample_with_data:493 - Sampling with raw_data.
2024-04-17 15:45:12.831 | INFO     | sdgx.models.LLM.base:_form_dataset_description:122 - No dataset_description given in current model.
2024-04-17 15:45:12.839 | INFO     | sdgx.models.LLM.base:_form_message_with_offtable_features:108 - No off_table_feature needed in current model.
2024-04-17 15:45:12.909 | INFO     | sdgx.models.LLM.single_table.gpt:ask_gpt:166 - Ask GPT with temperature = 0.1.
2024-04-17 15:45:19.826 | INFO     | sdgx.models.LLM.single_table.gpt:ask_gpt:179 - Ask GPT Finished.
2024-04-17 15:45:19.829 | INFO     | sdgx.models.LLM.single_table.gpt:extract_samples_from_response:360 - Extracting samples from response ...
2024-04-17 15:45:19.831 | INFO     | sdgx.models.LLM.single_table.gpt:extract_samples_from_response:372 - Extracting samples from response ... Finished, 4 extracted.

---------------------------------------------------------------------------

AttributeError                            Traceback (most recent call last)

[<ipython-input-7-7a17bdb3b69f>](https://localhost:8080/#) in <cell line: 7>()
      5 model.fit(df)
      6 # this may take a while
----> 7 model.sample(4, off_table_features = ['owns house'])

1 frames

[/usr/local/lib/python3.10/dist-packages/sdgx/models/LLM/single_table/gpt.py](https://localhost:8080/#) in _sample_with_data(self, count, *args, **kwargs)
    516         # return result
    517         final_columns = self.columns + self.off_table_features
--> 518         return pd.DataFrame(self.result, columns=final_columns)

AttributeError: 'SingleTableGPTModel' object has no attribute 'result'

I then added and ran this cell to test the corrected method, which gave me results and no error:

from sdgx.models.LLM.single_table.gpt import *
def _sample_with_data(self, count, *args, **kwargs):
    """
    This function samples data with a given count and returns a DataFrame with the sampled data.

    Args:
        count (int): The number of data samples to be generated.
        *args: Variable length argument list.
        **kwargs: Arbitrary keyword arguments.

    Returns:
        pd.DataFrame: A DataFrame containing the sampled data.

    """
    logger.info("Sampling with raw_data.")
    result = []
    remaining_cnt = count
    while remaining_cnt > 0:
        # get the current count
        if remaining_cnt - self.query_batch >= 0:
            current_cnt = self.query_batch
        else:
            current_cnt = remaining_cnt
        # select data / form message
        sample_list = self._select_random_elements(self._sample_lines, current_cnt)
        message = self._form_message_with_data(sample_list, current_cnt)
        # ask_gpt
        response = self.ask_gpt(message)
        # get result from response
        generated_batch = self.extract_samples_from_response(response)
        # update result
        result += generated_batch
        # update remaining_cnt
        remaining_cnt = remaining_cnt - current_cnt

    self._result_list.append(result)

    # return result
    final_columns = self.columns + self.off_table_features
    return pd.DataFrame(result, columns=final_columns)

# Replace the erroneous version of the method with the new corrected method
SingleTableGPTModel._sample_with_data = _sample_with_data

# Rerun the call that failed before
model.sample(4, off_table_features = ['owns house'])

Types of changes

[ ] Maintenance (no change in code, maintain the project's CI, docs, etc.)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

CI failed for: https://github.com/sphinx-doc/sphinx/issues/12303, seems not releated for this pr
Waiting for @MooooCat review

CI failed for: sphinx-doc/sphinx#12303, seems not releated for this pr
If docs build still fail, we can fix it in another pr
Waiting for @MooooCat review

Judging from the existing code modifications, this failed job should not be affected.
I'll re-run the failed job first to see if it passes.
（May need to fix the issue via another PR.）

The job did not fail after re-running, we can merge the PR.
Will open a new issue to record the information about this failed job.


Make elements props not override each other

Fixes #31
The problem was caused by Object.assign changing the target object.  When this target was again run against, it would be a different value.

IE doesn't support Object.assign, so we may want a polyfill here...
https://github.com/sindresorhus/object-assign

IE doesn't support Object.assign, so we may want a polyfill here...
sindresorhus/object-assign

Just created #34


yarn prepack results in error "Cannot find name 'queueMicrotask'"

Summary
Generating a new plugin and running yarn prepack results in an error from the Typescript compiler.
Steps To Reproduce:

Generate a new plugin with sfdx plugins:generate
cd into the directory that is created
run yarn prepack

Expected result
Compilation is successful.
Actual result
Error is displayed:
yarn run v1.22.10
$ rm -rf lib && tsc -b && oclif-dev manifest && oclif-dev readme
node_modules/@sinonjs/fake-timers/types/fake-timers-src.d.ts:11:28 - error TS2304: Cannot find name 'queueMicrotask'.

11     queueMicrotask: typeof queueMicrotask;
                              ~~~~~~~~~~~~~~

Found 1 error.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Additional information
SFDX CLI Version: sfdx-cli/7.103.0 darwin-x64 node-v14.17.0
OS and version: MacOS 10.14.6
Node version: v13.2.0

@fransflippo Thank for bring this issue to our attention. We are working on a permanent fix for this issue. In the mean time try this workaround.
yarn remove @types/node
yarn add @types/jsforce -D
yarn prepack

Thanks @peternhale, I had the same issue with a newly-generated plugin and your suggested workaround fixed it for me :-)

Thank you @peternhale , that works!

@fransflippo Thank for bring this issue to our attention. We are working on a permanent fix for this issue. In the mean time try this workaround.
yarn remove @types/node
yarn add @types/jsforce -D
yarn prepack

This worked for me, thanks!


Fix flaky OfflineClusterIntegrationTest on server response size tests

The flakiness comes from the assert statement which can fail when table config change is not picked up by TableCache yet

Codecov Report

Merging #11926 (b60db41) into master (8d49b11) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11926      +/-   ##
============================================
- Coverage     61.40%   61.40%   -0.01%
- Complexity     1145     1147       +2
============================================
  Files          2378     2378
  Lines        128851   128851
  Branches      19926    19926
============================================
- Hits          79127    79126       -1
+ Misses        44002    43996       -6
- Partials       5722     5729       +7

Flag
Coverage Δ

custom-integration1
<0.01% <ø> (ø)

integration
<0.01% <ø> (ø)

integration1
?

integration2
0.00% <ø> (ø)

java-11
61.38% <ø> (+26.64%)
:arrow_up:

java-21
34.64% <ø> (-26.66%)
:arrow_down:

skip-bytebuffers-false
61.40% <ø> (+<0.01%)
:arrow_up:

skip-bytebuffers-true
?

temurin
61.40% <ø> (-0.01%)
:arrow_down:

unittests
61.40% <ø> (-0.01%)
:arrow_down:

unittests1
46.62% <ø> (+<0.01%)
:arrow_up:

unittests2
27.63% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dashboard resize makes it impossible to resize table columns

https://github.com/dotnet/aspire/assets/95136/b93843c7-34f1-4fef-a4a5-6b3745a72e4b

@adamint reach out to Vincent Baaij on the Fluent UI side for support here

I am unable to reproduce this anymore. Closing


api/server: don't print warning if serving on localhost

Fixes bug #10728
Docker-DCO-1.1-Signed-off-by: Matt Williams<EMAIL_ADDRESS>(github: mattyw)

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-10728" git@github.com:mattyw/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Quote from my comment mentioned issue:

It needs to be warning no matter what it's binding to if --tlsverify isn't set.

Binding to any interface is a major security risk if not using --tlsverify, so I would prefer to make it always warn if not using --tlsverify.

yes can we remove !strings.HasPrefix(addr, "<IP_ADDRESS>") && !strings.HasPrefix(addr, "localhost") && so it always prints

PTAL

LGTM

LGTM


ionic and ng2-translate

an error occurred when trying to implement ng2-translate with ionic2 - reason missmuch of angular version.
the error:
TypeScript error: C:/code/.../node_modules/ng2-translate/ng2-translate.d.ts(1,10): Error TS2305: Module "C:/code/../node_modules/@angular/core/index"
has no exported member 'ModuleWithProviders'
please provice in your md file how to get an older version of you module
tnx

Ionic 2 is still on angular 2 RC4, and ng2-translate requires RC5 (with the new ng modules).
You should fix the version of ng2-translate to 2.2.2 until you can upgrade angular

Perfect right! :dancers:

I'll add a note to the readme tomorrow :)

I just added an example folder with an ionic 2 example, hope this helps !


ci/cd, github actions

CI:

check code style
run tests
deploy image to docker hub
update tag, verstion inside build.gradle, release new version on github

1,2,3 - on PR to any branch
4 - after merging dev into master


NPM reports vulnerability during installation

Hi, I am attempting to use this package in one of my Nuxt app and NPM reports a vulnerability with it. When I run npm run audit, this is what I get.
lodash.pick  >=4.0.0
Severity: high
Prototype Pollution in lodash - https://github.com/advisories/GHSA-p6mc-m468-83gw
No fix available
node_modules/lodash.pick
  v-slick-carousel  *
  Depends on vulnerable versions of lodash.pick
  node_modules/v-slick-carousel

2 high severity vulnerabilities

As it says no fix available, I can't use the npm-related fix command.

Hi @bikathi ,
Thanks for raising this issue. I have looked into the problem and identified that the "lodash.pick" package causes the warning you reported as it has a security issue identified in Github Advisory. So far there is no patch to the package which would fix the issue which is why it said no fix available. Fortunately, this vulnerability should not have an actual impact because it poses a threat if "property identifiers are user-supplied" which isn't the case in VSlickCarousel.
Nonetheless, after reviewing its usage (only three uses in props.ts), I think it is possible replace it with a custom method instead.


Connection not private in Chrome when clicking on https://ok-b.org/

Just thought I would mention (using latest Chrome on MacOS):

@mhulse, thank you very much for reporting this.
We have to investigate this, since I don't see it. What's your version of chrome?

Hi @crufter, thanks for the quick reply. Sorry that I did not provide this information in my first post:
Version 53.0.2785.143 (64-bit)
As I went to view the version, Chrome updated. I'm restarting Chrome now and will see if that helped.
Maybe this is just a problem with my computer/browser? I would hate to waste anyone's time here.

@mhulse You are not wasting our time, we appreciate feedback. I don't think the problem is on your end, if other encrypted sites work for you, this should as well.
I upgraded to the latest chrome and I can't see the issue, I have seen some alerts due to cached html where we loaded jquery from a 'http' source, but this is something else I believe.
I will try my best to reproduce this. Will come back to you, thanks.

Whoa, after upgrading to:
Version 54.0.2840.59 (64-bit)
It works!
Thanks so much for your quick replies and help!
I think we're good. Closing.
Oh, and thanks for the awesome tool!

Nice one! You are welcome, and thanks for using and helping to improve!


Need output of eas secret:list command in JSON format

Do you understand that any feature requests opened in this repository will be closed?
Yes

I am writing a github workflow to update eas secrets. For which I need to fetch list of secrets in json format, then get id of a particular secret and delete this and then create a new secret with same name and new value.
Or do we have any other way to get a secret id by its name?


CAP-21/40 Experimental Implementation

This is an experimental implementation of CAP-21 and CAP-40. Intended use is experimentation only. Some features of the applications modified in this PR are simply commented to limit the scope of the changes required.

Closing in favor of the horizon-protocol19 branch.


Duckling endpoint not passed to pod when external is True and an external URL is provided

https://github.com/RasaHQ/helm-charts/blob/e7e72f4a3333cb42430c0f49d001cb7d03fdaf74/charts/rasa/templates/helpers/_duckling.tpl#L5
This results in the following:
if false or (true and (not true)) resulting in false. We need this to be true when external = true and external url = true.
{{- if or .Values.duckling.install (and .Values.duckling.external.enabled .Values.duckling.external.url) -}} would be better.
This means the duckling endpoint is not provided to the pod here:
https://github.com/RasaHQ/helm-charts/blob/e7e72f4a3333cb42430c0f49d001cb7d03fdaf74/charts/rasa/templates/_containers-env.yaml#L21-L23

Thanks for the issue, @yennycheung will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

One can get around this issue by manually adding to the envs of the rasa pod.:
- name: “RASA_DUCKLING_HTTP_URL”
   value: “http://{duckling_service}:8000”


Remove the Parameter override from the build.

https://github.com/FPGA-MAFIA/fpga_mafia/blob/931deaa13c92a1fe5d29dee95ba23c76531a68f2/build.py#L241C16-L241C16
I think there is room for creating a script that can override the parameter value by name - both in source (AKA rtl) and in verif
The way it should work is as following:
In the cfg file add a field that is called "parameter_override"
{
    "I_MEM_OFFSET": 0,
    "I_MEM_LENGTH": 65536,
    "D_MEM_OFFSET": 65536,
    "D_MEM_LENGTH": 61440,
    "crt0_file"   : "crt0_mini_rv32e.S",
    "rv32_gcc"    : "rv32e -mabi=ilp32e",
    "name"        : "rv32e",
    "rtl_parameter_override"  : {
        "RF_NUM_MSB"  : 31,
        "RF_NUM_LSB"  : 0,
        "OTHER_EXAMPLE" : 31
    },
    "verif_pkg_parameter_override"  : {
        "TIMEOUT" : 1000000,
        "OTHER_EXAMPLE" : 65403540
    }
}

Then in the "build" call a new script that you need to create that accepts the list of parameters you need to change.
Make sure use correct regular expression so it overrides only the "parameter  = value" instances
The scipt will search, find and replace the values that are mentioned in the cfg json file.
The scipt will also log the info by printing to the screen what he found, where, and what he has changed.
During the find replace - add a comment in the line of parameter
Example:
parameter EXAMPLE = 15; // Note: This line was inserted using parameter override script

Note:
This Parameter change will actually change the value of the RTL!!
This is fine - as long as we test correctly the different parameter variations in the workflow.
This is not the best solution because this may cause many redundant commit changes in the git. (the Change in Value is tracked in the git add/commit flow)
But i think for us - this is a good solution.
(We are not really expected to manually change the RTL parameters very often. but we want to make sure they are correct)
I will note that the alternative is override the parameter value in the command line (simular to what i just added) but i have some trouble with overriding specific values in the param_pkg.
Another good alternative is to pass the parameter in the instance of each module -> but this also can get annoying.
I think will need to this to the most common parameter overrides so we can simply intergrade different version of the same module in the same system. (similar to what we did with the RF_NUM_MSB which is getting override in the module instance)
I think you can do this fairly simple
Let me know if you have any questions

As we discussed, instead of of using the json file to list the parameters,
Use a dedicated file under "scripts/ovrd_params/<name_of_parameter_variation>.csv"
Use the script scripts/ovrd_params.py -dut  -ovrd_file <path_to_file> to execute the override csv
Note:
In the builder - if there is a cfg file, and the cfg file contains the "ovrd_params": "file_name" options -> make sure to run the parameter overide script acording to the "DUT" and "FILE_NAME"

Just to clarify - this is how the cfg will let the build know we need to run the script ovrd

@roman012285 - i see that you implemented the example in my first comment (Which we discussed and said is the wrong approach) - i guess you missed the last comment.
Sorry for the confusion.


Message.IsMessageSignatureValid throws an exception

Hi,
We use Amazon AWS.SimplenotificationService nuget provided signature validation for ConfirmSubscription message validation.
To get the received message, we read the body content with UTF-8 encoding and detectEncodingFromByteOrderMarks flag is set to true. Then use the following -
var decoded = WebUtility.UrlDecode(encodedJson);
var message = Message.ParseMessage(decoded);
so calling the below api to verify the signature -
message.IsMessageSignatureValid()
throws an exception
The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.
This was working all this while but is failing suddenly. Could you please take a look what is going wrong?
Expected Behavior
Signature validation for SNS message should pass using the API IsMessageSignatureValid

Current Behavior
Using IsMessageSignatureValidation() throws an exception
The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.

Possible Solution

Steps to Reproduce (for bugs)
Read the body content with UTF-8 encoding and detectEncodingFromByteOrderMarks flag is set to true. Then use the following -
var decoded = WebUtility.UrlDecode(encodedJson);
var message = Message.ParseMessage(decoded);
so calling the below apito verify the signature -
message.IsMessageSignatureValid()
Context

Your Environment

AWSSDK.Core version used: <IP_ADDRESS>
Service assembly and version used:
Operating System and version: Windows 10
Visual Studio version: 15.9.3
Targeted .NET platform: .Net framework version 4.7.03190 (.Net core app)

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

Update -
Convert.FromBase64String(amazonSnsMessage.Signature) throws an exception
Invalid length for a Base-64 char array or string.
Basically, the signature returned from amazon sns is not a valid base64 encoded string

Can someone look into the issue please?

Hi @raghumirajkar,
Good morning.
I was going through issue backlog and came across this one. Please let me know if this is still an issue. If yes, request you to share basic code solution which is giving you the above error.
Thanks,
Ashish


APIM. Fix redis protocol requirement for VNET.

@maksimkim,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@maksimkim : Thanks for your contribution to the Azure documentation! The author, @antonba, has been notified to review your proposed change.

#sign-off


Two (or more) spaces in filename or folder name issue

Hi matt
I have problem when using browse mode and if a file or folder contains more than one space in it's name. Then caddy just shows the name just with one space.
Is it possible that caddy shows the exact name for files (and folders)?

Hmm, I'm not having that issue. Can you provide more details or a screenshot of what you're seeing? The file names appear correctly for me (even files with more than one space).

I created one folder with name "test[SPACESPACE]files" and one file that is "net[SPACESPACESPACE]iso.txt" but you can see that there is just one SPACE on list

I tested with both Firefox and Opera browsers and the result is same

Oh, you mean consecutive spaces. Thank you for clarifying. That's makes sense, since HTML ignores extra whitespace. I've got my hands kind of full right now but maybe @pyed could take a look at this? Should be easy enough with one or two lines of CSS.

Thanks @pyed!

Thank you both @pyed @mholt

@mholt @pyed
Hi
Your correction just applies to the names not title.
I created a folder with name "88[4SPACES]99":

But trim on title:


SW-18532 - SEO path conflict: old URLs not correctly released

When an old SEO url (s_core_rewrite_urls with main = 0) uses a path, that is needed for a different controller action, it is not updated correctly.
See SW-18532

Questions
Answers

Why?
old SEO urls cannot be used by other pages, once used

BC breaks?
no

Tests exists & pass?
no automated tests

Related tickets?
https://issues.shopware.com/issues/SW-18532

How to test?
see ticket

Requirements met?
except entry in update.md

Thanks, has been merged with edbc4241fb51cc8af169b8c89fe924c52aab89f1.


[SPARK-35501][SQL][TESTS] Add a feature for removing pulled container image for docker integration tests

What changes were proposed in this pull request?

This PR adds a feature for removing pulled container image after every docker integration test finish.
This feature is enabled by the new propoerty spark.tes.docker.removePulledImage.
Why are the changes needed?

For idempotent.
I'm trying to add docker integration tests to GA in SPARK-35483 (#32631) but I noticed that jdbc.OracleIntegrationSuite consistently fails(https://github.com/sarutak/spark/runs/2646707235?check_suite_focus=true).
I investigated the reason and I found it's short of the storage capacity of the host on GA.
 ORACLE PASSWORD FOR SYS AND SYSTEM: oracle
The location '/opt/oracle' specified for database files has insufficient space.
Database creation needs at least '4.5GB' disk space.
Specify a different database file destination that has enough space in the configuration file '/etc/sysconfig/oracle-xe-18c.conf'.
mv: cannot stat '/opt/oracle/product/18c/dbhomeXE/dbs/spfileXE.ora': No such file or directory
mv: cannot stat '/opt/oracle/product/18c/dbhomeXE/dbs/orapwXE': No such file or directory
ORACLE_HOME = [/home/oracle] ? ORACLE_BASE environment variable is not being set since this
information is not available for the current user ID .
You can set ORACLE_BASE manually if it is required.
Resetting ORACLE_BASE to its previous value or ORACLE_HOME
The Oracle base remains unchanged with value /opt/oracle
#####################################
########### E R R O R ###############
DATABASE SETUP WAS NOT SUCCESSFUL!
Please check output for further info!
########### E R R O R ###############
#####################################
The following output is now a tail of the alert.log:
tail: cannot open '/opt/oracle/diag/rdbms/*/*/trace/alert*.log' for reading: No such file or directory
tail: no files remaining

With this feature, pulled container image is removed and keep the capacity for jdbc.OracleIntegrationSuite in GA.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

I confirmed the following things.

A container image which is absent in the local repository is removed after test finished if spark.test.container.removePulledImage is true.
A container image which is present in the local repository is not removed after the finished even if spark.test.container.removePulledImage is true.
A container image is not removed regardless of presence of the container image in the local repository even if spark.test.container.removePulledImage is true.

Test build #138872 has started for PR 32652 at commit 60ea4fd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43394/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43394/

Test build #138872 has finished for PR 32652 at commit 60ea4fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138872/

cc: @dongjoon-hyun @HyukjinKwon

Test build #138951 has started for PR 32652 at commit da66bb1.

Thank you for pinging me, @sarutak .

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43471/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43471/

Test build #138951 has finished for PR 32652 at commit da66bb1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43471/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138951/


ModuleNotFoundError: No module named 'LoadPairs'

Installed with pip. It seems this version is changed.

When trying to install thru git using the following command:
pip install git+https://github.com/Crypto-AI/pypoloniex
I get the following error:
`ERROR: unknown command "instal" - maybe you meant "install"
(py3) ahmed@ahmed-dwtc:~/anaconda3/envs/py3/lib/python3.6/site-packages/stocktalk$ pip install git+https://github.com/Crypto-AI/pypoloniex
Collecting git+https://github.com/Crypto-AI/pypoloniex
Cloning https://github.com/Crypto-AI/pypoloniex to /tmp/pip-gku_271b-build
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/home/user/anaconda3/envs/py3/lib/python3.6/tokenize.py", line 452, in open
buffer = _builtin_open(filename, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-gku_271b-build/setup.py'
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-gku_271b-build/`

same here, i installed via pip

one fix for python3 will be to modify the file init.py and change the following:
Original
from LoadPairs import LoadPairs
Changed
from .LoadPairs import LoadPairs

Install through Github, I haven't updated the package on PyPi. If someone wants to upgrade it to Python 3 feel free to submit a pull request.
I'm surprised people are still using this package.


Enable class element ordering on the project

More than 30 files would need to be changed.
Closing this for now.
Please see https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1628#issuecomment-191183515
We will enable this after dropping support for 1.x

Sure. I just enabled it to see what the state was myself. CBA to run to too, so this PR got travis to do it. ;)


DatastoreTemplate#convertEntitiesForRead very slow (17 second delay)

Version: 1.2.0.RC2
I am making a call with the DatastoreTemplate that freezes for ~17 seconds every call.
EDIT: Removed the code, the issue is that I have a lot of recursive references in some of my table definitions. What I would like to know is if there is a way to tell Spring not to do a deep search for every reference on an entity. I haven't been able to find one and projection still seems to take a long time to execute (though I need to dig into this a little more).
Any help is greatly appreciated.

Actually this might not work since I removed all the references, I will need to include all the references from these entities in an archive.

Is there a way to exclude deep entity references being pulled in a query? I'm looking at Projection atm, but it would be nice if it was possible to ignore deep References on a given call.

We support projections and that's probably the most appropriate solution at the moment.
The performance you're quoting still sounds pretty bad. Are there many roundtrips to the database? @dmitry-s Any thoughts on this?

Yes, there are additional database calls for entity reference resolution. Let me see if there is a way to workaround that.

Lazy loading could help with that issue.
@meltsufin what do you think?

Sure, it makes sense. We already have an issue for it: #1101.


Sort insertion

Challenge
Insertion Sort

[x] code sort func
[x] tests
[x] blog post

API
def insertion_sort(arr):
    # BigO == n^2
    # My own take, without using pseudo code.

TESTS

[x] func exists
[x] sort 5
[x] all same
[x] sort zero array
[x] sort 1000 random

Blog
https://marvincolgin.com/index.php/2019/08/12/insertion-sort/

TODO @marvincolgin this is a bubble sort, not an insertion sort. Fix, relabel and write a insertion-sort.

OOPS, this was supposed to be a insertionsort, but I wrote bubble sort. Making a new pull-req.