PyDreo should not have a dependency on HA

A recent set of PRs included a dependency on HomeAssistant in PyDreo; that shouldn't be there.
I apologize I missed this in the code reviews.
@iRonin , @andy-cooper , your two changes added or updated this.  If either of you want to take a crack at fixing, that'd be great, else I'll take care of it.

@JeffSteinbok happy to try to help if you point me to the right direction. I pretty much reused the existing code but maybe introduced some dependency on constants? Let me know what to look at.

Basically, there are dependencies on constants from HA.  Even if the values happen to be the same, they need to be mapped from HA to PyDreo from the HA layer.  PyDreo should eventually move into a separate repo and have zero dependencies on HA.  Right now, it's there as a convenience.

Thet could have been me. The plugin uses HA architecture so if anything the constants should be extracted as lightweight dependency for both HA core and plugins.
However it's been already heavily used in your plugin:
This could be me:
from homeassistant.components.climate import (
    FAN_ON,
    FAN_OFF
)

but there's been heavier dependencies like this:
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import (
    CONF_IP_ADDRESS,
    CONF_PASSWORD,
    EVENT_HOMEASSISTANT_STOP,
    Platform,
)
from homeassistant.core import Event, HomeAssistant
from homeassistant.exceptions import ConfigEntryAuthFailed, ConfigEntryNotReady
from homeassistant.helpers.device_registry import DeviceInfo
from homeassistant.helpers.entity import EntityDescription
from homeassistant.helpers.update_coordinator import (
    CoordinatorEntity,
    DataUpdateCoordinator,
    UpdateFailed,
)

In what file is that?

I did search for from homeassistant

The only instances other than constants and one type are in the Dreo folder, which is ok.  It's just the PyDreo folder that's an issue.
https://github.com/search?q=repo%3AJeffSteinbok%2Fhass-dreo+homeassistant+path%3A%2F^custom_components\%2Fdreo\%2Fpydreo\%2F%2F&type=code

@iRonin, @andy-cooper  please have a look at this branch.  I can't test heaters or AC so I may have broken things, but this is the general direction.
https://github.com/JeffSteinbok/hass-dreo/tree/infra/fixdeps

@andy-cooper - For the heaters where you use angles for Swing Mode, is that what Dreo actually supports or does it support arbitrary angles?  If the preset angles are just a thing for the UX in HA, then we should move that up a level and expose just the angle number in PyDreo.

Apologies for not seeing this sooner - took at look at the changes and they LGTM. Made a comment in the commit.
Regarding the oscillation angles - as far as I understood from looking at the Dreo doc, the heaters themselves only support those particular angles; they don't support arbitrary angles.

Thanks. I'll have another look and see what makes sense. It's a bit odd overloading swing mode and angle like this. Need to think about it a bit more.

@JeffSteinbok there are some conflicts with my chefmaker-support branch which I'm using locally. I'll test all the changes once I have resolved the conflicts.

I'm sure there are lots. :(  I also did a bunch of PyLint fixes.
If you can send me the JSON blobs that Dreo sends back for your devices, that would be super-helpful.  I can inject them and see at least if I'm parsing right.

@iRonin do you have some sample JSONs?  I'm trying to figure out exactly what to do with your WH739S and the angle.

@JeffSteinbok I emailed it to you after your previous message

The AC I've got supports only on/off oscillation, there are no angles.

Ok, thanks.  Sorry, then it's @andy-cooper  that I need JSON from. :)

In your new branch:
    def __init__(self, preset_modes: list[FanMode], deviceRanges: dict, hvac_modes: list[HVACMode] = None,

deviceRanges shouldn't be device_ranges?

Yeah, lots is busted.
I'm going to also auto-detect modes and speeds and simplify the config greatly.  So, don't bother looking yet.  I'll let you all know when it's ready for a good look.

Too bad you didn't merge the existing PR's before these changes. Will be a lot of work for us to resolve conflicts. I had my Chef Maker branch ready and live on mine and someone else's.

That’s unfortunate.
Are your PRs ready to go? If so, I could integrate them and deal with the forward merge.
-Jeff
On Aug 23, 2024, at 6:46 PM, Cyprian Kowalczyk @.***> wrote:

Too bad you didn't merge the existing PR's before these changes. Will be a lot of work for us to resolve conflicts. I had my Chef Maker branch ready and live on mine and someone else's.
—
Reply to this email directly, view it on GitHubhttps://github.com/JeffSteinbok/hass-dreo/issues/159#issuecomment-2307983782, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABX5XT5KMWCAAAGG6ZVWZGLZS7QWRAVCNFSM6AAAAABM6RLGJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE4DGNZYGI.
You are receiving this because you were mentioned.Message ID: @.***>

You've got my devices json. I've been running it on https://github.com/JeffSteinbok/hass-dreo/pull/113 locally and there was another user who deployed my forked repo where this PR is on master.

Ok. I bit off more than I can chew at the moment. Is your PR ready to merge? I'll do that first. @iRonin

I'm AFK but yesterday it looked master was just one small commit ahead. I can merge master and test later today.

Awesome. Let me know. I can pop on and merge it.

Your change is merged.  Published a 0.8.0b1 release for you to test.  If all is good, I'll make a non-pre-release version.
Note that I still have to fix the HA dependency issue this thread was started for originally.

Tested it locally and LGTM 👍🏻

Awesome.  @andy-cooper  - I'll give you a bit longer, then I'll publish as non pre-release.

Just tested against the main branch and everything seems to work fine for my heaters.


The common frontend is crashing on a slightly modified version of the flutter gallery app.

Crash running a branch of flutter_gallery with small changes to the Flutter package with
--preview-dart-2
Repro steps using an android debug build.
Clone this branch
https://github.com/jacob314/flutter/tree/CRASH_DART_2
cd examples/flutter_gallery
flutter run --preview-dart-2
tweak widget_inspector.dart line 745 or probably anywhere in package:flutter and trigger a hot reload.

Crash

Build output:
Performing hot reload...
compiler message: Unhandled exception:
compiler message: Crash when compiling file:///usr/local/google/home/jacobr/git/flutter/3/flutter/examples/flutter_gallery/lib/main.dart,
compiler message: at character offset null:
compiler message: NoSuchMethodError: The getter 'typeArguments' was called on null.
compiler message: Receiver: null
compiler message: Tried calling: typeArguments
compiler message: #0      Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
compiler message: #1      _TypeSubstitutor.visitSupertype (package:kernel/type_algebra.dart:441)
compiler message: #2      Substitution.substituteSupertype (package:kernel/type_algebra.dart:309)
compiler message: #3      StrongModeMixinInferrer.generateConstraints (package:front_end/src/fasta/type_inference/type_inferrer.dart:1683)
compiler message: #4      StrongModeMixinInferrer.infer (package:front_end/src/fasta/type_inference/type_inferrer.dart:1727)
compiler message: #5      ClosedWorldClassHierarchy._topologicalSortVisit (package:kernel/class_hierarchy.dart:781)
compiler message: #6      ClosedWorldClassHierarchy._initialize (package:kernel/class_hierarchy.dart:705)
compiler message: #7      new ClassHierarchy (package:kernel/class_hierarchy.dart:38)
compiler message: #8      SourceLoader.computeHierarchy (package:front_end/src/fasta/source/source_loader.dart:574)
compiler message: #9      KernelTarget.buildOutlines (package:front_end/src/fasta/kernel/kernel_target.dart:250)
compiler message: <asynchronous suspension>
compiler message: #10     IncrementalCompiler.computeDelta.<anonymous closure> (package:front_end/src/fasta/incremental_compiler.dart:158)
compiler message: <asynchronous suspension>
compiler message: #11     CompilerContext.runInContext.<anonymous closure> (package:front_end/src/fasta/compiler_context.dart:103)
compiler message: #12     _rootRun (dart:async/zone.dart:1126)
compiler message: #13     _CustomZone.run (dart:async/zone.dart:1023)
compiler message: #14     runZoned (dart:async/zone.dart:1501)
compiler message: #15     CompilerContext.runInContext (package:front_end/src/fasta/compiler_context.dart:103)
compiler message: #16     IncrementalCompiler.computeDelta (package:front_end/src/fasta/incremental_compiler.dart:57)
compiler message: <asynchronous suspension>
compiler message: #17     IncrementalCompiler.compile (package:vm/incremental_compiler.dart:33)
compiler message: <asynchronous suspension>

It appears this issue is fixed by
https://github.com/flutter/flutter/pull/14832
closing for now.

I spoke too soon.
Known repro steps that still apply on tip of trunk:
Edit widget_inspector.dart line 745 tweaking the const color value slightly.

/cc @kmillikin @peter-ahe-google

I get the same stacktrace for https://github.com/dart-lang/sdk/issues/32313 .

Update: I am trying to create a standalone example of this specific issue. Once that's done I will create a bug report in the dart repo and port the link here.

@jacob314 I think this is fixed by https://github.com/dart-lang/sdk/commit/13067387a4d549aafa971dc70a2e408686bac21d.  Let me know when you can verify it.

@a-siva as soon as the new dart-sdk is rolled into flutter engine, I'll try it out with my flutter branch.

A new version of the dart-sdk was rolled into flutter this morning (the roll was at version 1aaebedd7045a44ba92bb1bb27c3a8bc25d74856)


Only create labels for polygonal geometries

Refs https://github.com/mapzen/tilequeue/issues/21

@nvkelso Could you review please?

LGTM


API Documentation

NOTE

The API documentation can currently be found under http://localhost:8000/api/docs/
you need to apply the DB migrations for this to run. See the README

@maltaesousa I had to make some changes in the tests but only because the name of the attribute changed. The logic of the teat is still the same.

Thanks for this PR! Can you please add drf-spectacular to requirements.txt before merging?

@maltaesousa I regenerated the requirements.txt but it removes the information about the python version on some of the packages. do you need that?

@marionb Yes, those information are important for the build. With the new requirements.txt, the build of the docker image gets broken. You can test it with docker build -t sitn/geoshop-dev-api --build-arg ENV_FILE=.env.local .

OK thanks I will take a look and re-add that.
by the way what tool are you using to generate the requremens.txt in that way?

When I started that in 2019, I was using pipenv which I thought it was a great tool. It turned out to not be as good as I thought. So If you have any suggestions, I'll be happy to switch :)
Maybe we should update the Docker base image to something closer to what you use at camptocamp so we can use your tools?

@maltaesousa I suggest that we move to poetry and setup a pyproject.toml . I'll have a look with @marionb on monday

@maltaesousa I think the python builder should be a separate issue/PR. I have created one here https://github.com/camptocamp/geoshop-back/issues/17

Agree so is it ok to just change the requirements manually to add this drf-spectacular==0.27.1 so it doesn't break the build and  migrate to poetry in another PR?

@maltaesousa
Yes, If it is OK for you I will merge this now.
I added the package to the existing requirements.txt and we will add the poetry in another PR.


0.5.1b Visual bug with sandpaper and rose quartz

Describe the Bug
When you are polishing rose quartz with a piece of sandpaper in your main hand and you drop it during polishing, it drops as a usual sandpaper with a glitchy rose quartz in it.
Reproduction Steps

Get a piece of sandpaper and rose quartz and start polishing
While it's being polished, press Q and drop the sandpaper which won't give the quartz back
Done, You've got a glitchy rose quartz texture "glued" to the sandpaper
(bug disappears when you pick them up again)
...

Expected Result
IDK choose something:

You only drop the sandpaper but the r.quartz gets back to your inventory
You drop the sandpaper and the r.quartz as two separate items
Just fix the glitchy combination of textures and maybe add a unique texture of sandpaper with r.quartz

Screenshots and Videos
No response
Crash Report or Log
It's a soft bug
Operating System
Windows 10 Pro
Mod Version
0.5.1b
Minecraft Version
1.19.2
Other Mods
I currently use CreateDeco, and ExtendedDrawers (it's just StorageDrawers for new versions of Minecraft) but the bug also happened without those mods, on pure Create.
Additional Context
No response

Upd: Checked again and the bug doesn't disappear when you pick up the glitchy sandpaper but does when you use it again (RMB to start polishing)

going to consider this a duplicate of #906, same as forge


Enhance Documentation

Hmmm.  It's difficult to provide an update to this issue when there's no description provided.
We've got a working process now to provide improved navigation and structure to OPEA documentation published to https://opea-project.github.io and @tomlenth and @preethivenkatesh are working on an improved Getting Started developer flow using the ChatQnA example.  I'll defer to them to provide an update.


Close #300 - support @nest.HttpCode() function

When @nest.HttpCode() being used, it would be adjusted into both swagger and SDK

Bug of Github, I should send another PR for release note.


Perform a Rollback on a DaemonSet

kubectl rollout history daemonset <daemonset-name>

kubectl rollout history daemonset <daemonset-name> --revision=1

Does this operation have a corresponding OpenApiinterface, I want to operate through RestfulAPI，I didn't find it

/language zh
/kind support

/sig docs

I think we can Retitle this to "Query on Perform a Rollback on a DaemonSet".

The rollout sequence of a Deployment is stored in the annotation deployment.kubernetes.io/revision. Another related annotation is deployment.kubernetes.io/revision-history. kubectl performs the rollout operations based on the data stored there.
/close
/kind support

my deployment has 4 history
[root@node8 ~]# kubectl rollout history deployment bx-devops-agent -n bx-devops
deployment.apps/bx-devops-agent
REVISION  CHANGE-CAUSE
1         <none>
2         <none>
3         <none>
4         <none>

[root@node8 ~]# kubectl describe deployment bx-devops-agent -n bx-devops
Name:                   bx-devops-agent
Namespace:              bx-devops
CreationTimestamp:      Wed, 23 Nov 2022 19:32:36 +0800
Labels:                 app=bx-devops-agent
Annotations:            deployment.kubernetes.io/revision: 4
Selector:               app=bx-devops-agent
Replicas:               1 desired | 1 updated | 1 total | 1 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge
Pod Template:
  Labels:           app=bx-devops-agent
  Service Account:  bx-agent
  Containers:
    *********
    Mounts:            <none>
  Volumes:             <none>
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      True    MinimumReplicasAvailable
  Progressing    True    NewReplicaSetAvailable
OldReplicaSets:  <none>
NewReplicaSet:   bx-devops-agent-749768cd (1/1 replicas created)
Events:          <none>

no annotation  deployment.kubernetes.io/revision-history ?

why don't you do API call and then examine the JSON body?


Adjustments on page nsxt-3-0-install.html

Replaced "NSX Manager" with "NSX-T Manager".
Removed the redundant part of the login URL.
Corrected typos

Which other branches should this be merged with (if any)?
At least some are present since 1.8

Sorry for the multiple commits. I was a bit confused because some issues I found while reading the doc are now already fixed in 1.11 doc, some in 1.10+, but it seems that a lot persist in 1.9. I understand that 1.9 is not maintained.
There are some other varying case used on "Logical Router"/"logical router" and on "Logical Switch"/"logical switch", which I'm not sure if it's intended or an issue.
There's also another issue with the MTU documentation. As far as I know, it is incorrect to state that overlay traffic requires an MTU at 9000. It is recommended to use "1600 or greater" (one page among others: https://docs.vmware.com/en/VMware-NSX-T-Data-Center/3.0/administration/GUID-F7C976EF-2C0D-42D6-ACB5-13453BACD281.html). So the doc should say "1600", not "9000", unless there's an additional requirement for TKGI which should be explained.
Similarly, the statement that "NSX-T Edge Nodes must be connected to a port group that supports > 1600 bytes" is inaccurate, since the MTU should be greater or equals to 1600, not strictly greated to 1600. So > should be replaced by ≥.

I'll log the MTU point in a separate issue


[api-minor] Stop exporting, by default, a few additional Font properties (PR 11777 follow-up)

This is similar to the "isSymbolicFont"-property, which is no longer exported by default after PR #11777.
Both "isMonospace" and "isSerifFont" are internal properties, used during font parsing and building of the glyph mapping on the worker-thread.
However both of these properties are completely unused on the main-thread and/or in the API, and accessing them they will now require setting the fontExtraProperties-option when calling getDocument.

/botio test

Thanks!


Update event

Adds a new update event which is fired every time that the map is moved, the viz changes (including animation) or new data is loaded. This is very practical for reacting to render external widgets.
cc: @rubenmoya

+Tests please ;)

How do you imagine testing this? I mean, you would need to know when dataframes are added, when map is moved... I don't want to create a lot of fake internals and test the implementation

I'm not very happy using a generic event for lots of things, so we should revisit this in the future. But since its part of the API it should have tests to cover all its functionality.
To tackle this we must implement "user tests" to work with a real map (div). Let me help you with that ;)

UPDATE: added user tests and a bit of refactoring/renaming.
LGTM, but @davidmanzanares take a look please :wink:

:+1: Thanks!


Fix ios module test typo

Fix typo in ios module test that caused flakes
Fixes https://github.com/flutter/flutter/issues/89175
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman Do you know what's the benchmark failure here? Doesn't seem to relate to the PR but my other framework PR didn't hit this. (This is synced with master)
cc @godofredoc

Lots of infra failures on that benchmark in try jobs: https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark
File an infra ticket and infra on-call can diagnose.

Filed https://github.com/flutter/flutter/issues/94946

ci.yaml validation failed, created infra ticket: https://github.com/flutter/flutter/issues/95027


Is it for programming video teaching video tutorial?

Dear author:
i'm  teaching programming in video tutorial. And i want to show code in slides in an elegant and interactive way.
Current I found Carbon is good enough to show static code image in an element way. However it's static and can not show code animation line by line , or paragraph by paragraph.
I find your great Glorious tool can show code in an interactive way. and I have some questions.

Can Glorious export the animation to a gif file? so that i can embed it in ms office.
Can I control the line or paragraph show time? i mean, can i set it show after n seconds, or even show it after i click?
Can i easily export a gif of a file by giving  any source file?

Thank you.

Hello, @dragen1860!
Let me see if I can help you:

The idea of Glorious Demo was in fact to avoid having to generate a .gif to show it on a website. Differently from a gif, you can build your animation with just HTML/CSS/JS using Glorious Demo API. That said, it's not possible to export the animation built as a .gif. If you really need a .gif, I'd recommend to build your animation using Glorious Demo and, then, record your screen using Giphy or Gifox.
Yes. For every step of your animation you can pass an option called onCompleteDelay. Doing so, the next step of your animation will delay the amount of milliseconds you set on the previous step before to be played. In this example, I have written the first function immediately and waited 5 seconds before writing the second one.
As explained on the answer 1, no.

I hope this answer to be useful for you. In case you have more doubts, don't hesitate to ask me 👍
Have a nice day!

Thank you. It helps a lot!


Add signs to "permeable" blocks for Item Exchange relays

Can you give some reasoning for this request?

Even if you want to do this, you'd want to add the wall-sign equivalents too.

Even if you want to do this, you'd want to add the wall-sign equivalents too.

Ah, might be better to do some rewriting to switch to allowing any transparent and blacklisting then

Can you give some reasoning for this request?

Signs are counted as transparent in other areas, it makes sense that exchanges should be able to pass through them. Visually they don't even block the "signal" in the same way glass might be expected to, as they do not cover the chest.

I'm opposed as this is against the spirit of the permeable blocks for shop relays, and signs wouldn't help protect a shop like glass or iron bars do

Signs are non-solid though. They don't protect chests but they do block relays in unexpected ways given that the game treats them as transparent in every other situation. As it stands, this is an inconsistency in how transparent blocks are handled. See the attached screenshots for more context as to how this is a) unintuitive and b) inconsistent with other behaviour. Both situations depicted are essentially the same, a non-full block between a relay, yet one works and the other doesn't.

I'm opposed as this is against the spirit of the permeable blocks for shop relays, and signs wouldn't help protect a shop like glass or iron bars do

Yeah, tbh, the notion that any permeable block MUST add protection kinda implies that the AIR block types should be removed.

Not a desired change for the server, doesn't fit with the intentions of shop relays


When I click the edit contact button, getting add contact

When I click the edit contact button, getting add contact page. it should point to edit page

same thing for me on iOS

Marked as duplicated of #75

Marked as duplicated of #75


Create example code for X9 files which can be linked to from the README

What were you trying to do?
See code examples for creating X9 files on README.md

Is this talking about the following? Could we include the read and write examples without that table? Since there are only two links let's just display them in a paragraph.


Auto-update Python documentation for 1.28.0

Closing in favor of https://github.com/grpc/grpc/pull/22586


[AlertIOS] UIAlertView is deprecated in iOS 9.0

warning: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

Detecting the iOS version, and if is the 9+ use this new controller UIAlertController, if is old version use the UIAlertView.

This would be a great PR, but I don't think it's urgent.
Even better than doing an explicit version check would be to use if ([UIAlertController class].

@jadsonlourenco Looks like this has been fixed by https://github.com/facebook/react-native/commit/cf0a28265ab931acfd5d2db339c41f6cde800da5.
Can you double check and close the issue if everything works?

@christopherdro Yes, I can confirm that!
But I get the same warning on file RCTUtils.h yet, just one now.

@jadsonlourenco I think the warning is something that we're just going to have to live with for now and doesn't really require an open issue. Glad to hear it works for you now!

@christopherdro I understand. Thanks for all!

the same issue

@KeithZhang Could you provide us more info on how your calling it?

@KeithZhang you can't call the Alert from a Modal component. I hope this to be possible in the near future.


Added test cases for cid.buffer

Added two more test cases for CID.buffer, for both versions 0 and 1.
(Cf. Issue $46.)

@realharry As you contribute a lot recently, I'd like to point you to our JS Code Guidelines: https://github.com/ipfs/community/blob/master/js-code-guidelines.md It also contains information about the commit message format we use. It's not a big deal for now as I can easily change it when merging the commit.


[Request]: Possible Support For the Sx Prop

It seems like a lot of the inspiration from v3 came from chakra-ui and styled-system. It really does look great.
Our team really enjoys using the sx prop because it groups styles in a relatively readable manner vs. the prop based style approach.
Chakra and Theme UI currently support this approach. Do you think there'd be any consideration in supporting the sx prop in NativeBase?

@cmaycumber We're considering adding sx prop in NativeBase. This will help the user to pass any valid CSS to the element.
However, we can pass any valid react style attribute in _android, _ios or _web props.
<Box
 _web={{
    style: { backgroudColor: "red"}
   }}
   _ios={{
    style: { backgroudColor: "blue"}
   }}
>
  Hello!
</Box>

Hope to add sx prop soon, thank you!

Does the closed as completed status mean that this feature was included in the latest version? Or was it simply marked as stale?
I still feel like this would be valuable from an organization standpoint (all styles live in the sx prop). Obviously, it's all personal preference, but it seems pretty standard in other libraries.


Add -v flag to get the version of binary

Is your feature request related to a problem? Please describe.
Nop, just to be as all your other tools, I would like to get the binary version with the -v flag.
Describe the solution you'd like
"freeze -v" command should print the version of the binary
Thanks for all the wonderful tools

Hey @sgaunet, this is implemented in https://github.com/charmbracelet/freeze/pull/69!
Thank you for opening this issue, the --version flag will be included in the next release!


ARROW-12204: [Rust][CI] Reduce size of Rust build artifacts in integration test

Rationale
The integration test has a fixed size builder docker image and has builds from several Arrow implementations.
The Rust build artifacts (compiled binaries) in the integration tests still consume ~ 1GB of space even after https://github.com/apache/arrow/pull/9879 (see @pitrou 's comment on  https://github.com/apache/arrow/pull/9884#issuecomment-813037756).
Changes

Only build the arrow-integration-testing crate (which has the binaries needed for integration testing) rather than all of them
Remove incremental build artifacts
Moves cargo check  to ensure we can build arrow without default features to a github action and out of the integration test

This should both speed up the rust build as part of integration testing as well as reduce the amount of disk space required in the builder (both peak and after the rust build).

By the way, you can run integration tests locally using archery docker run conda-integration. It's probably faster than waiting for Github Actions :-)

Se here for installing Archery.


Camera not disposing

I have disposed the local and remote stream but still, I get this
I/org.webrtc.Logging(21849): CameraStatistics: Camera fps: 30.
What will be the possible fix for this solution?
I am disposing of everything.
  var helper = widget._helper;
      var rid = helper.roomId;
      var client = helper.client;

      if (_localVideo != null) {
        // stop local video

        print("\n LOCAL STREAM");

        var stream = _localVideo.stream;
        await client.unpublish(_localVideo.mid);
        await stream.dispose();

        await _localVideo.dispose();
        _localVideo = null;
      }

      _remoteVideos.forEach((item) async {
        var stream = item.stream;
        print("\n\n\n\n $item \n\n\n REMOTE VIDEOS");
        try {
          await client.unsubscribe(rid, item.mid);
          await stream.dispose();
        } catch (error) {}
      });
      this.setState(() {});
      _remoteVideos.clear();
      await widget._helper.close();

      this.setState(() {
        userDevice = {};
      });

      Navigator.of(context).pop();

Any update on this?
I have developed the app with this and we are launching this app end of this month.
Please help me :(

@rajababu3 your Issue report is lacking in Information. In my usecase, it is disposing.
What Developers need to know, what an Issue report should contain is:

Your version of the framework.
What Device did you have used?
What Os your device is Running? This is an multiplatform framework.
Android has multiple camera implementations. What camera version do your device use?
never ask someone to fix your code. That sample code is not helpful. if it is not telling anything. provide maybe an sample app via fork of the demo app?


Migrate from Travis to GitHub actions

Hi @hashhar, I think this PR Resolves Issue #10850.
I am not sure if this is still needed but here you have a PR to consider.
Please let me know if maybe I am missing something.
Regards!

@cla-bot check

@hectorhuol Sorry for the delay.
Can you apply these two comments and squash all commits into a single one called "Migrate from TravisCI to GitHub Actions".
I'll merge accordingly.
Hi @hashhar, no problem, I just applied the suggestions and squashed the commits, please let me know if something else is needed

Thanks @hectorhuol


upload: Allow arbitrary topic order

#
head
base
diff
date
summary

0
f2506f16
df295937
diff
Mar 12 13:31 PM
1 file changed, 14 insertions(+), 19 deletions(-)

Reviews in this chain:
└https://github.com/Skydio/revup/pull/155 upload: Allow arbitrary topic order


[Feature] Add Abundant Number Calculator

Description
Abundant number: A number is called abundant if the sum of its proper divisors is greater than the number itself. For example, 12 is an abundant number because its proper divisors are 1, 2, 3, 4, and 6, and 1 + 2 + 3 + 4 + 6 = 16, which is greater than 12.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Proceed @sharmi4590

Provide your PR @sharmi4590


LE Audio: Allow server to initiate Codec Config procedure

Required by ASCS/SR/ACP/BV-07-C PTS test case.

After this refactor the stream has to be configured by the server app before calling the bt_audio_unicast_server_config_ase(). The function initializes the selected ASE and configures its codec. Finally, attaches the configured stream to the ASE.
The bt_audio_unicast_server_foreach_ase() allows to reach id, state and dir of each ASE, which the server app needs. This approach helped bt_audio_ep to stay safe and untouched by external code.
Added example usage of bt_audio_unicast_server_foreach_ase() into in the unicast server BSIM test.


feat: support AVM in bb-prover-exec

#6666  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

app_circuit_witness_generation_time_in_ms (FPC:fee_entrypoint_public): 241 (-31%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 2,034 (-20%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 24,160 (+16%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,727 (+1%)
1,550
713 (+1%)
779 (+3%)
776 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,452
9,464
9,464

l1_rollup_execution_gas
616,093
616,105
616,105

l2_block_processing_time_in_ms
1,353 (-2%)
5,053 (-1%)
10,068 (-2%)

l2_block_building_time_in_ms
46,600
184,523 (-1%)
368,439

l2_block_rollup_simulation_time_in_ms
46,427
183,882 (-1%)
367,168

l2_block_public_tx_process_time_in_ms
25,487 (+2%)
103,751 (-1%)
209,646 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
9,958
15,245 (-1%)

node_database_size_in_bytes
14,487,632
21,319,760

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
proving_time_in_ms
input_size_in_bytes
output_size_in_bytes
proof_size_in_bytes
num_public_inputs
size_in_gates

private-kernel-init
164
3,449 (-3%)
24,715 (+2%)
20,630
64,614
89,536
2,731
1,048,576

private-kernel-inner
625
3,937 (-4%)
51,795 (-2%)
92,318
64,614
89,536
2,731
2,097,152

private-kernel-tail
547
2,688 (-3%)
41,963 (-4%)
90,237
77,498
10,656
266
2,097,152

base-parity
6.76 (+6%)
1,259 (-2%)
2,819 (+1%)
128
64.0
2,208
2.00
131,072

root-parity
49.5 (-1%)
62.7 (-8%)
49,887 (-1%)
27,084
64.0
2,720
18.0
2,097,152

base-rollup
811 (+5%)
2,340 (-4%)
85,673 (-4%)
119,610
756
3,648
47.0
4,194,304

root-rollup
115 (-2%)
74.9 (-8%)
22,381 (+2%)
25,297
620
3,456
41.0
1,048,576

public-kernel-app-logic
524
2,744 (-2%)
50,683 (-3%)
104,941
86,302
114,784
3,520
2,097,152

public-kernel-tail
1,191 (-1%)
:warning: 24,160 (+16%)
177,065 (-1%)
395,386
7,522
10,656
266
8,388,608

private-kernel-reset-small
599 (+1%)
:warning: 2,034 (-20%)
47,872 (-3%)
120,733
64,614
89,536
2,731
2,097,152

merge-rollup
28.6
N/A
N/A
16,534
756
N/A
N/A
N/A

public-kernel-setup
627 (-1%)
N/A
N/A
104,941
86,302
N/A
N/A
N/A

public-kernel-teardown
529 (-15%)
N/A
N/A
104,941
86,302
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
8,208 (-1%)
92,927 (-2%)
N/A
N/A
114,784
3,520
4,194,304

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms
proof_size_in_bytes
proving_time_in_ms
size_in_gates
num_public_inputs

ContractClassRegisterer:register
1,344
9,944
465 (+1%)
N/A
N/A
N/A
N/A

ContractInstanceDeployer:deploy
1,408
9,944
41.3
N/A
N/A
N/A
N/A

MultiCallEntrypoint:entrypoint
1,920
9,944
1,444 (-1%)
N/A
N/A
N/A
N/A

SchnorrAccount:constructor
1,312
9,944
1,019 (-3%)
N/A
N/A
N/A
N/A

SchnorrAccount:entrypoint
2,304
9,944
2,141
16,768
49,964
2,097,152
457

Token:privately_mint_private_note
1,280
9,944
1,164 (-15%)
N/A
N/A
N/A
N/A

Token:transfer
1,376
9,944
4,112 (-7%)
16,768
54,246 (-6%)
2,097,152
457

Benchmarking:create_note
1,312
9,944
997 (+2%)
N/A
N/A
N/A
N/A

FPC:fee_entrypoint_public
1,344
9,944
:warning: 241 (-31%)
N/A
N/A
N/A
N/A

SchnorrAccount:spend_private_authwit
1,280
9,944
79.9 (+3%)
N/A
N/A
N/A
N/A

Token:unshield
1,376
9,944
3,349 (-3%)
N/A
N/A
N/A
N/A

FPC:fee_entrypoint_private
1,376
9,944
4,174 (-4%)
N/A
N/A
N/A
N/A

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.1 (-2%)
17.9
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.642 (-2%)
0.551
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.4
80.9
261 (-2%)
507 (+1%)
986 (-1%)
1,952 (-1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.526
0.499
0.474 (-2%)
0.474 (+1%)
0.468 (-1%)
0.466 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
61.8
119 (-1%)
377 (-1%)
745
1,466 (-1%)
2,920 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.537
0.537 (-1%)
0.512 (-1%)
0.513
0.508 (-1%)
0.508 (-1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
66.2

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.588

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
83,794
665,117

Transaction size based on fee payment method
| Metric |  |
| - |  |


adding comments from issue disucssion on ho to build gu and other rel…

…ated topics

Cherry-picked on main via 4bc4ed5a609bba054afa30f27181940686dbf847.


Update README.md

@all-contributors please add @akhil0203  for contributions

@all-contributors please add @akhil0203 for code


Getting an error while editing the details

Any idea about following error?
ERROR TypeError: Cannot read property 'vEvents' of undefined
Angular version: 8.0.2

I am facing the same issue.. @viniston Did you manage to find a solution, by any chance?

@ansalian No luck so far. I didn't try to fix it.

Do you have more info about this error?
The full stack trace or a demo code?


Added cargo install into readme

I appreciate the effort, but I don't think the readme needs this as it's pretty short.


refactored models

Removed the tag and tagged models and their references.  Also updated the user model to have a unique value.

Looks good!


How to integrate with @monaco-editor/loader

and why not bundle the output into a JS file ?

 error  in ./node_modules/antlr4ng/dist/index.mjs

Module parse failed: Unexpected token (6:9)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| // src/atn/Transition.ts
| var Transition = class {
>   static {
|     __name(this, "Transition");
|   }

And how to resolve this problem ?


Supply depot parameter for BasicAuthValidator::validate

Currently, BasicAuthValidator::validate only supplies username and password, and returning true will enter the handler for that request. However, before entering the handler, we want to record some information regarding the current account, such as account level, privilege, or something else we want to use in the handler.
Change async fn validate(&self, username: &str, password: &str) -> bool; to async fn validate(&self, username: &str, password: &str, depot: &mut Depot) -> bool; would be helpful to implement these functions.

只更新主分支了，因为是破坏性更新，不打算在 hyper 1.0 之前再发不兼容的版本了。


Add actions to label future release branch with hold and milestone

Create a GitHub action to add a label hold and add a milestone future-release against dev-future-release branch.
The GitHub action will only trigger for branch that matches the following pattern: dev-[0-9].[0-9][0-9] (ex. dev-1.20)
The GitHub action will only trigger when a pull request first opens and when it reopens after closing.
The GitHub action will NOT trigger when the PR owner changes base from master to dev-1.20
This work was done based on a conversation from SIG Docs Q3/Q4 Planning Meeting where we discussed the idea of adding more automation to remove manual work for the Sig Release Docs team.
To be able to successfully run the actions, a secret needs to be created in the k/website repo, named GITHUB_ACTIONS_TOKEN that contains a token that allows calling the GitHub API to add a label and a milestone. (Secret name can be changed)
Prow was also considered as a possible tool, but since this is only for k/website and for dev-future-release branches, I believed GitHub Actions was a better choice
/hold
until the secret is created and to get feedback from @kubernetes/sig-docs-leads

@annajung , Why do you need the hold label?

The docs release team uses hold label to make sure that k/k PRs are merged in before docs PR can be merged.
With a placeholder deadline placed before the code freeze deadline, most of all PRs made to the dev-1.20 (future release branch) is a placeholder and the enhancement owner has until code freeze to get k/k PRs merged. Therefore, most docs PRs need to be on hold until we can confirm k/k PRs have made it in.
Therefore, I thought it would be best to automatically add hold for every PR and remove the label once one of the docs release team members confirms k/k PR was merged in. This also removes the accidentally merging docs PR into the future branch.
From my experience so far, it's kind of rare to not have a hold label
This also reminds me that I should probably modify Documenting a feature for a release to explain why the hold was placed and when it will be removed. I can add that in later today!

Adding a hold on every PR is definitely a way of "controlling" the workflow of the incoming pull requests.
Typically, "future release" PRs should be triaged and determined if the content is ready for review.
If the content is incomplete or needs more edits, or the feature is not ready, the PR is not approved.
If there is content in the pull request, the PR should be reviewed so that there is not a backlog of reviews and
merges toward the end of release. It is okay to have pull requests "sit" without an explicit "hold" until the
corresponding feature is merged. Sounds like you would have more confidence in the process if an enforced
hold is put in place.

That makes sense Karen! I am open to feedback and can make changes to this.
I personally like the hold label where I can use to query to get the status of the open PRs and I really like the fact that we'll never accidentally merge in PRs that's not ready without someone explicitly removing the hold label.
However, I also want to make sure this is something that will work for all future releases not just my personal preference :D I will wait until others chime in to decide on the hold label.

Also relevant: PR #24554 (about code ownership for GitHub Actions)

How about we get the milestone labelling done, as it's uncontroversial, and then make a separate PR that considers also automatically holding PRs for the upcoming release branch.
Would that work?

I really like that idea @sftim
Created a separate PR for just the milestone functionality https://github.com/kubernetes/website/pull/24835
I will clean up this PR to contain only the hold functionality

Closing out this PR as team agreed to leverage prows functionality.
Captured the concern with automatically apply hold label in https://github.com/kubernetes/website/issues/24960
/close


Update sbt to 1.6.0

Updates org.scala-sbt:sbt from 1.5.8 to 1.6.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report

Merging #203 (107c456) into main (c67be7a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   70.51%   70.51%
=======================================
  Files           4        4
  Lines          78       78
  Branches        4        4
=======================================
  Hits           55       55
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67be7a...107c456. Read the comment docs.


Update pulumi-terraform

This PR pulls in the default value fixes from pulumi-terraform. As yet, we are not bumping the version of the upstream provider until it is safe to have breaking changes.

I've pushed an update here to bump pulumi-terraform up to 129ae82 (unmerged into pulumi-terraform) to verify that the tests are fixed.


Font-family difference between platforms

Details
This PR fixes the font-family difference between platform
Fixed Issues

https://github.com/Expensify/Expensify.cash/issues/2491
Tests

Send the following message on mobile

  *`test`*
  _`test`_

Italics and bold must be applied.
View the message on desktop / web / ios / android

QA Steps

Click on the text input
Send a message the following messages

1. *`bold`*
2. _`italic`_
3. `normal`
4. *_`italic and bold`_*

The fonts should be applied like in web / desktop

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Do you could send the name of the fonts? @shawnborton
I saw that the names is different from the file name, like this one:
https://www.expensify.com/font/GT-America-Standard-Bold-Italic.woff") format("woff"), url("https://www.expensify.com/font/GT-America-Standard-Bold-Italic.woff2

Yeah, the file names are confusing but if we ignore the file names for a moment, the font family's name is GT America Exp, and within this family we have many sub-weights and styles. So for that matter, given that we only have one font family for our brand, I wonder if we don't really need to refer to the formal family name but rather we can just refer to the style? For example, we'd have:

Regular (this is the default)
Regular Italic
Bold
Bold Italic
Monospaced Regular
Monospaced Regular Italic
Monospaced Bold
Monospaced Bold Italic

There should be a corresponding font file for each one of those styles above. Let me know if that makes sense!

There should be a corresponding font file for each one of those styles above. Let me know if that makes sense!

More or less @shawnborton, because it could be a little confused, in the web we use  just refer to the style and in the other platforms (android and ios) we use GTAmericaExpMono-Bd.
In my opinion a good approach is to use the same name in all platforms (web, android and ios)

If you need to standardize on a font fame name, I think GTAmericaExp works well. Then from here, you would have my list above as the sub-styles of the family.

@thierrysantos To verify, have you tested this on all 5 platforms with the most recent fonts that @shawnborton provided?

@Luke9389 this changes that @shawnborton made just impact in the web.
Fetching the new fonts from expensify:

Web

Awesome. Thanks!

All you @TomatoToaster!

@thierrysantos Just posted a few friendly concerns. Thanks.
@Luke9389 Kindly let me know if I can do review comments. I worked over it earlier so reviewed it to make sure there are no regressions.

@parasharrajat Thank you for your review 🤘🏽

Yea @parasharrajat, feel free to leave review comments!

@Luke9389 @parasharrajat I update the PR with your suggestions 🤘🏽


Validate Mgmt Cluster Bundles Version on Workload Cluster Create

Validates that the management cluster's bundle is the same version or newer than the bundle version used to create a workload cluster.
Issue #, if available:
Follow up to https://github.com/aws/eks-anywhere/pull/5263#issuecomment-1476999424 for ticket https://github.com/aws/eks-anywhere/issues/5105.
Description of changes:
Validates management/CLI bundles versions on workload cluster creation.
Testing (if applicable):
Ran create workload cluster commands with valid and invalid bundles, validations succeeded/failed as expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Add win32 platform options to select process DPI awareness

What does the pull request do?
Adds DpiAwareness option to the win32 platform options to allow setting of the process dpi awareness. The default DPI awareness, ie Per-Monitor DPI aware, remains.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0038966-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Converted name input text to lower case

Thanks for this PR, however I don't really understand the use case for this change. Would you mind elaborating?

Yeah, thanks for your reply, I tried using a JavaScript method to modify
the user input, because I had an issue when parsing data to render icons,
so I needed to convert those strings being parsed to lowercase before
rendering.
For example, I received some basic data from an API. So when I parsed the
data directly to the component, I got question marks (e.g. "Car" and
"Motorcycle").
I think adding that small piece of code will make the component more
flexible for user input.
Best regards,
Ridwan Ajibola
On Thu, Sep 10, 2020, 20:04 Joel Arvidsson<EMAIL_ADDRESS>wrote:

Thanks for this PR, however I don't really understand the use case for
this change. Would you mind elaborating?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/oblador/react-native-vector-icons/pull/1241#issuecomment-690629576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMFWKGBCVLKKVRPWY2WPTD3SFEPKZANCNFSM4Q7MFQXA
.

OK, thanks, but I think it's better if you fix this on your end instead :-) Will close for now!


Add Wigner plotting via CairoMakie

Checklist

[x] Please read Contributor Covenant Code of Conduct
[x] Any code changes were done in a way that does not break public API
[x] Appropriate tests were added and tested locally by running: make test.
[x] Any code changes should be julia formatted by running: make format.
[x] All documents (in docs/ folder) related to code changes were updated and able to build locally by running make docs.

Description
This PR introduces plotting capabilities in QuantumToolbox (starting from the plot_wigner function implemented in QuTip).
To reduce the impact on loading time, I wrote an extension for the CairoMakie library, such that the necessary code is not loaded by default. Moreover, this allows extending the scheme to additional plotting libraries like PyPlot or Plots (although I haven't done it).
The plot_wigner function implements 2D and 3D projections of the Wigner and reproduces QuTip's output as faithfully as possible.
Related issues or PRs
fix #86

By the way, is it also possible to generate our logo with this function ?
I mean following the tutorial here: https://qutip.org/QuantumToolbox.jl/stable/tutorials/logo

I would say yes. Indeed, it would be a good thing to apply this function directly in the tutorial of the logo.

@albertomercurio
any idea on this ?
I'm not familiar with Makie.jl...

As Lorenzo said, we can use plot_wigner in the logo tutorial up to a certain point. Then we use image instead of heatmap, because I create a custom image basically.
But still, it is a good idea to directly using it in the tutorial.

Then sorry for the delay in bringing the PR to its final form. I hope I'll be able to finish adding tests and docs in the following days.

Then sorry for the delay in bringing the PR to its final form. I hope I'll be able to finish adding tests and docs in the following days.

It's okay, take your time.

I have changed the target branch from main to dev/visualization.
I think the extension test structure and also the corresponding CI pipeline configs need to be modified, which I can do it afterwards.
Apart from that, I have a few more comments below.

Thanks @ytdHuang for your input. I updated the docs to match your suggestions.
The only thing I left as it was is the use of :two_dim and :three_dim, as I don't think your suggestion would work (:(2d) is an Expr, not a Symbol - see above).
If you have advice on how to change it to 2d I'd be happy to do it. I also think it would be more natural.

I have changed the target branch from main to dev/visualization.
I think the extension test structure and also the corresponding CI pipeline configs need to be modified, which I can do it afterwards.
Apart from that, I have a few more comments below.

How exactly do you want to change the structure? I can also try to do it directly in this PR

It would be better to make this extension be an independent test group, so that the original core tests doesn't need to install CairoMakie.jl. This also need to change the settings of runtests CI pipeline. I can do it afterwards.


doc for bicep linter rule max asserts

Add doc for bicep linter rule src/Bicep.Core/Analyzers/Linter/Rules/MaxNumberAssertsRule.cs.
Include this new doc in the bicep table of contents

@mumian - this is a new article suggestion.
If you decide the content is something that you want in your doc set, someone on the content team will need to become the listed owner of the article in the metadata. That person will need to work with the external contributor to refine the article as much as possible in the public repo, then the FTE will need to pull the content to the private repo for staging, validation, and Acrolinx and to get it merged.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@mumian - can you help us advance this aging PR that's assigned to you?  Should this be assigned to someone else or closed?
Thanks, PR review team

#assign-reviewer:anthony-c-martin

I sent an email to @anthony-c-martin today.

@mumian @anthony-c-martin - thanks for approving. As mentioned, the commits will need to be moved to the private repo. Can you do that, or would you like our assistance?

I have created a new PR - https://github.com/MicrosoftDocs/azure-docs-pr/pull/262023.
#please-close


Automated cherry pick of #10514: fix(monitor): registry alertPanel in mcclient

Cherry pick of #10514 on release/3.7.
#10514: fix(monitor): registry alertPanel in mcclient

Codecov Report

Merging #10515 (23e44d8) into release/3.7 (0ff3997) will increase coverage by 1.90%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.7   #10515       +/-   ##
================================================
+ Coverage         5.98%    7.88%    +1.90%
================================================
  Files              848      110      -738
  Lines           131795    13361   -118434
================================================
- Hits              7887     1054     -6833
+ Misses          123206    12187   -111019
+ Partials           702      120      -582

Flag
Coverage Δ

aFlag
7.88% <0.00%> (+1.90%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/util/imagetools/imagetools.go
40.50% <0.00%> (-2.74%)
:arrow_down:

pkg/monitor/alerting/eval_context.go
34.82% <0.00%> (-2.18%)
:arrow_down:

pkg/hostman/diskutils/nbd/lvmutils.go
4.70% <0.00%> (-0.24%)
:arrow_down:

pkg/monitor/alerting/rule.go
1.78% <0.00%> (-0.09%)
:arrow_down:

pkg/util/sysutils/kvm.go
2.91% <0.00%> (-0.06%)
:arrow_down:

... and 680 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7858f3e...23e44d8. Read the comment docs.


Commits schema updates for integer over bigint

I rule and have completed some work on Case Manager that's ready for review!
I keep seeing this change when I'm doing the build, so opening this PR to figure out if we want it, or want to figure out how to keep bigints
This pull request makes the following changes:

runs the build & seed
commits the schema changes

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

I have no earthly idea why this is happening and it is definitely driving me up the wall! but I think we do want FK refs to be bigints, even if strictly speaking we will never even get close to the point where a difference between int and bigint will matter.

Running through a git bisect, I see the first time this pops up is on https://github.com/DARIAEngineering/dcaf_case_management/pull/2537, the PR downgrading back to 3.0.2 & doing a few dep bumps. Strange. more digging needed.

I don't think we need this anymore


CdsServiceClient Authorization Timing out after App Is Idle for long time

I am using CdsServiceClient in Azure Function and if we send a request which basically needs to connect to Dynamics 365 using CdsServiceClient then it is throwing exception with Authentication is Anonymous but with subsequent retry it works. Below is code for initializing CdsClient
    public CdsServiceClient Create(string connectionString)
    {
        _logger.TraceVerbose("Creating CrmServiceClient");
        CdsServiceClient client = new CdsServiceClient(connectionString);

        if (!client.IsReady)
        {
            _logger.TraceError("CrmServiceClient is not ready! Please check your connection string in your \"App.config\"");
        }

        _logger.TraceVerbose("Connected To CRM");
        return client;
    }

Could you give us a sense for "how long" ?
this sort of situation usually appears when the token lifespan of the access token differs from the what Azure AAD is requiring.
thanks

I don't have the exact time with me but yeah usually I see this error after I trigger the function approx. 1 hour of my previous run or somewhere near.  Is there a way to refresh the Token within the lifespan of AAD token automatically?

We have exercised this a few different ways and are not seeing it repro.. the system is auto refreshing the token for client secret if the token expires within 15 seconds.
There is a question on if what is happening is the token's reported expiration is different then what AAD is actually enforcing.  Do you happen to know if there is a conditional access policy that has been applied to your tenant?
Comment on this...
We are going to defer looking into this one any further as we are close to releasing the updated version of the auth stack using MSAL which materially changes how this is done.   MSAL internally handles determining token refresh more efficiently then ADAL.net did and we have shifted over to using the onboard token refresh behaviors in the upcoming release.
Im going to park this for the moment and come back to it once we have shipped the updated MSAL based client.


fix: use default headers in getContents()

The purpose of this pr is to decrease chance of anti-bot detection.
Modify getContents() so that it by default uses the firefox 102 headers as suggested by [0]. Tweak _http_request() so that its http headers are passed as an associative array.
Unfortunately the http headers as not passed as an associative array to getContents(). So they must be normalized first and then merged with the default values. Might be some issues regarding header name casing but not doing anything about now.
[0] https://github.com/lwthiker/curl-impersonate/blob/main/firefox/curl_ff102

I haven't found any bridges which bypasses anti-bot response because of this pr but I think it helps a little but. It also doesn't hurt. These headers will be ignored if using the curl-impersonate library (i think).


[BUG] Local rank mismatch error when training on nodes with different number of GPUs

Describe the bug
When training Megatron-DeepSpeed models on nodes with different number of GPUs (e.g., node 0: 2 GPUs, node 1: 4 GPUs), local rank mismatch error (AssertionError: expected local-rank to be the same as rank % device-count.) occurs in https://github.com/microsoft/Megatron-DeepSpeed/blob/main/megatron/initialize.py#L207.
I found that this is caused by local ranks set by DeepSpeed launcher mismatching the local ranks set by Megatron-DeepSpeed.
Specifically, while DeepSpeed assigns local ranks corresponding to global ranks sequentially (e.g., global ranks: [2, 3, 4, 5] -> local ranks: [0, 1, 2, 3]), Megatron-DeepSpeed decides each local rank as global rank % device count of the node (e.g., global ranks: [2, 3, 4, 5] -> local ranks: [2, 3, 0, 1]).
To Reproduce

Clone https://github.com/microsoft/Megatron-DeepSpeed and prepare to run training scripts (e.g., https://github.com/microsoft/Megatron-DeepSpeed/blob/main/examples/MoE/ds_pretrain_gpt_350M_dense.sh) as guided.
Prepare a cluster where each node has different number of GPUs (e.g., two nodes each with 2 and 4 GPUs, respectively).
Execute a training script.

Expected behavior
Training starts normally without an error in such setup. Because DeepSpeed document does not restrict that all nodes must be homogeneous (i.e., exacltly the same number of GPUs), I expected training to work properly for clusters where nodes have different number of GPUs.
ds_report output
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
 [WARNING]  using untested triton version (2.0.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/home/ubuntu/.local/lib/python3.9/site-packages/torch']
torch version .................... 1.10.0+cu111
deepspeed install path ........... ['/home/ubuntu/.local/lib/python3.9/site-packages/deepspeed']
deepspeed info ................... 0.8.3, unknown, unknown
torch cuda version ............... 11.1
torch hip version ................ None
nvcc version ..................... 11.1
deepspeed wheel compiled w. ...... torch 0.0, cuda 0.0

Error log
Traceback (most recent call last):
   File "/home/ubuntu/Megatron-DeepSpeed/examples/MoE/../../pretrain_gpt.py", line 345, in <module>
     pretrain(train_valid_test_datasets_provider, model_provider, forward_step,
   File "/home/ubuntu/Megatron-DeepSpeed/megatron/training.py", line 107, in pretrain
     initialize_megatron(extra_args_provider=extra_args_provider,
   File "/home/ubuntu/Megatron-DeepSpeed/megatron/initialize.py", line 79, in initialize_megatron
     finish_mpu_init()
   File "/home/ubuntu/Megatron-DeepSpeed/megatron/initialize.py", line 60, in finish_mpu_init
     _initialize_distributed()
   File "/home/ubuntu/Megatron-DeepSpeed/megatron/initialize.py", line 216, in _initialize_distributed
     assert args.local_rank == device, \
 AssertionError: expected local-rank to be the same as rank % device-count.

System info

OS: Ubuntu 18.04
GPU count and types: Two machines, each with 2 T4 GPUs and 4 T4 GPUs, respectively
Python version: 3.9.4

Launcher context
deepspeed launcher
Docker context
N/A. Did not use Docker images.

I fixed this issue and checked it's working fine. If it's okay, I will submit a pull request for this.

I faced a similar issue when trying Megatron-deepspeed demo of LLAMA2 13B using 2 nodes with 4 GPUS when PP is set to 8. The local rank on second node is different from the environment variable.

Traceback (most recent call last):
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/pretrain_gpt.py", line 354, in <module>
Traceback (most recent call last):
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/pretrain_gpt.py", line 354, in <module>
    pretrain(train_valid_test_datasets_provider,
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 137, in pretrain
Traceback (most recent call last):
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/pretrain_gpt.py", line 354, in <module>
    pretrain(train_valid_test_datasets_provider,
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 137, in pretrain
    model, optimizer, opt_param_scheduler = setup_model_and_optimizer(
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 581, in setup_model_and_optimizer
    pretrain(train_valid_test_datasets_provider,
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 137, in pretrain
    model, optimizer, opt_param_scheduler = setup_model_and_optimizer(
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 581, in setup_model_and_optimizer
    model, optimizer, opt_param_scheduler = setup_model_and_optimizer(
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 581, in setup_model_and_optimizer
    model, optimizer, _, opt_param_scheduler = deepspeed.initialize(
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/__init__.py", line 186, in initialize
    model, optimizer, _, opt_param_scheduler = deepspeed.initialize(
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/__init__.py", line 186, in initialize
    model, optimizer, _, opt_param_scheduler = deepspeed.initialize(
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/__init__.py", line 186, in initialize
    engine = PipelineEngine(args=args,
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/pipe/engine.py", line 67, in __init__
    engine = PipelineEngine(args=args,
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/pipe/engine.py", line 67, in __init__
    engine = PipelineEngine(args=args,
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/pipe/engine.py", line 67, in __init__
    super().__init__(*super_args, **super_kwargs)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 237, in __init__
    super().__init__(*super_args, **super_kwargs)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 237, in __init__
    super().__init__(*super_args, **super_kwargs)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 237, in __init__
    self._do_args_sanity_check(args)
    self._do_args_sanity_check(args)  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 985, in _do_args_sanity_check

  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 985, in _do_args_sanity_check
    self._do_args_sanity_check(args)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 985, in _do_args_sanity_check
    env_local_rank == args.local_rank
    env_local_rank == args.local_rank
AssertionError: Mismatch in local rank setting, args.local_rank=7 but env['LOCAL_RANK']=3.
AssertionError: Mismatch in local rank setting, args.local_rank=6 but env['LOCAL_RANK']=2.
    env_local_rank == args.local_rank
AssertionError: Mismatch in local rank setting, args.local_rank=5 but env['LOCAL_RANK']=1.
 > number of parameters on (tensor, pipeline) model parallel rank (0, 4):<PHONE_NUMBER>
Traceback (most recent call last):
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/pretrain_gpt.py", line 354, in <module>
    pretrain(train_valid_test_datasets_provider,
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 137, in pretrain
    model, optimizer, opt_param_scheduler = setup_model_and_optimizer(
  File "/beegfs_mount/yan_li/codes/Megatron-DeepSpeed/megatron/training.py", line 581, in setup_model_and_optimizer
    model, optimizer, _, opt_param_scheduler = deepspeed.initialize(
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/__init__.py", line 186, in initialize
    engine = PipelineEngine(args=args,
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/pipe/engine.py", line 67, in __init__
    super().__init__(*super_args, **super_kwargs)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 237, in __init__
    self._do_args_sanity_check(args)
  File "/beegfs_mount/yan_li/codes/DeepSpeed/deepspeed/runtime/engine.py", line 985, in _do_args_sanity_check
    env_local_rank == args.local_rank
AssertionError: Mismatch in local rank setting, args.local_rank=4 but env['LOCAL_RANK']=0.

The log of network splitting.
stage=0 layers=7
     0: _to_float16
     1: EmbeddingPipe
     2: ParallelTransformerLayerPipe
     3: ParallelTransformerLayerPipe
     4: ParallelTransformerLayerPipe
     5: ParallelTransformerLayerPipe
     6: ParallelTransformerLayerPipe
stage=1 layers=5
     7: ParallelTransformerLayerPipe
     8: ParallelTransformerLayerPipe
     9: ParallelTransformerLayerPipe
    10: ParallelTransformerLayerPipe
    11: ParallelTransformerLayerPipe
stage=2 layers=5
    12: ParallelTransformerLayerPipe
    13: ParallelTransformerLayerPipe
    14: ParallelTransformerLayerPipe
    15: ParallelTransformerLayerPipe
    16: ParallelTransformerLayerPipe
stage=3 layers=5
    17: ParallelTransformerLayerPipe
    18: ParallelTransformerLayerPipe
    19: ParallelTransformerLayerPipe
    20: ParallelTransformerLayerPipe
    21: ParallelTransformerLayerPipe
stage=4 layers=5
    22: ParallelTransformerLayerPipe
    23: ParallelTransformerLayerPipe
    24: ParallelTransformerLayerPipe
    25: ParallelTransformerLayerPipe
    26: ParallelTransformerLayerPipe
stage=5 layers=5
    27: ParallelTransformerLayerPipe
    28: ParallelTransformerLayerPipe
    29: ParallelTransformerLayerPipe
    30: ParallelTransformerLayerPipe
    31: ParallelTransformerLayerPipe
stage=6 layers=5
    32: ParallelTransformerLayerPipe
    33: ParallelTransformerLayerPipe
    34: ParallelTransformerLayerPipe
    35: ParallelTransformerLayerPipe
    36: ParallelTransformerLayerPipe
stage=7 layers=8
    37: ParallelTransformerLayerPipe
    38: ParallelTransformerLayerPipe
    39: ParallelTransformerLayerPipe
    40: ParallelTransformerLayerPipe
    41: ParallelTransformerLayerPipe
    42: MixedFusedRMSNorm
    43: LMHeadPipe
    44: float16_to_fp32
  loss: CrossEntropy

``

I faced a similar issue when trying Megatron-deepspeed demo /examples_deepspeed/generate_text.sh using 1node 8gpus.
My deepspeed version is 0.12.6
A complete error log is this:
building GPT2BPETokenizer tokenizer ...
Traceback (most recent call last):
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/tools/generate_samples_gpt.py", line 178, in <module>
    main()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/tools/generate_samples_gpt.py", line 120, in main
    initialize_megatron(extra_args_provider=add_text_generate_args,
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 86, in initialize_megatron
    finish_mpu_init()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 66, in finish_mpu_init
    _initialize_distributed()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 212, in _initialize_distributed
    assert args.local_rank == device, \
AssertionError: expected local-rank to be the same as rank % device-count.
 > padded vocab (size: 50257) with 47 dummy tokens (new size: 50304)
Traceback (most recent call last):
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/tools/generate_samples_gpt.py", line 178, in <module>
    main()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/tools/generate_samples_gpt.py", line 120, in main
    initialize_megatron(extra_args_provider=add_text_generate_args,
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 86, in initialize_megatron
    finish_mpu_init()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 66, in finish_mpu_init
    _initialize_distributed()
  File "/mnt/VMSTORE/ygz/Megatron-DeepSpeed/megatron/initialize.py", line 212, in _initialize_distributed
    assert args.local_rank == device, \
AssertionError: expected local-rank to be the same as rank % device-count


Allow setting a proxy

I'm currently working on a project for a client where all outbound HTTP calls need to go through a proxy server. I see that an HttpClient is used internally in the sink, but there's no injection point for a HttpMessageHandler anywhere. I suggest another optional parameter in the EventCollector constructor and extension method: proxyAddress, which is exactly what it looks like. This can then be passed in to the EventCollectorClient constructor and be used to create a HttpClientHandler using the provided proxy.
I'd be happy to create a PR for this.

@Wedvich sounds great.  Similar to https://github.com/serilog/serilog-sinks-splunk/issues/26 we need to open up HttpMessageHandler

Perhaps similar to the Seq sink? https://github.com/serilog/serilog-sinks-seq/blob/dev/src/Serilog.Sinks.Seq/Sinks/Seq/SeqSink.cs#L53

Great work @Wedvich now to get a release out.


ML 8.1 : RNN(D)

Description
📌  Issues for Week 8
Welcome to 'ML' Team, good to see you here
:arrow_forward: This issue will helps readers in acquiring all the knowledge that one needs to know about ----
RNN.
:red_circle: To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
✔ Domain : Machine Learning
:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/ML_for_Seqential_Data_&_Visual_Data Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

:white_check_mark: To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Documentation

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

ML Batch: 03
Aditya Kumar
Type: Documentation

Please assign this issue to me.
Name: Vidhi Bhatt
Domain: ML Batch 3
Serial no: 490
Github link: https://github.com/VidhiBhatt01

Name: Hrugved Kolhe
Batch: 3
GitHub Profile
[x]  Documentation
Interested

Tanvi Deshmukh
batch-5
plz assign to me.

Please assign this issue to me.
Name: Mann Shah
Domain: ML Batch 3
Github link: https://github.com/Mann-tech13
Documentation

/assign Documentation


Passing incorrect error

Whoops, this includes half a fix for another issue I'm working on, will update.

Squashed and merged as ba4273d72910686aa829a37d2dce911e920673a9.


SELECT query that starts with a blank line wont work using DataFrameClient

When writing long queries I tend to put split them onto serveral lines. The parenthesis and backslash Python string merge methods will work, but not the multiline string if you dont start with the SELECT keyword on the first line.
Example that works:
result = client.query("""select temperature from temperature
where time > '2017-03-13 10:40:00.000'
and time < '2017-03-13 12:30:00.000'
order by time""")

Example that does not work but should IMO:
result = client.query("""
select temperature from temperature
where time > '2017-03-13 10:40:00.000'
and time < '2017-03-13 12:30:00.000'
order by time""")

Code location: https://github.com/influxdata/influxdb-python/blob/master/influxdb/_dataframe_client.py#L143
Proposed fix: Add a call to Python's str.strip() method on this line.
I can write a pull request if you are ok to merge it (should be one line of code + verifying tests results + maybe adding a new test for this scenario).

As a user, I might prefer the DataFrameClient to throw an exception if it is unable to return a DataFrame.

This issue is addressed in pull requests 404.


Add support for provenance tracking

Codecov Report

Merging #50 (4fd2848) into dev (fce9cac) will increase coverage by 2.27%.
The diff coverage is 91.25%.

@@            Coverage Diff             @@
##              dev      #50      +/-   ##
==========================================
+ Coverage   62.71%   64.98%   +2.27%
==========================================
  Files          45       46       +1
  Lines        2336     2519     +183
  Branches      410      436      +26
==========================================
+ Hits         1465     1637     +172
- Misses        767      776       +9
- Partials      104      106       +2

Flag
Coverage Δ

unittests
64.98% <91.25%> (+2.27%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mosaic/provenance.py
89.47% <89.47%> (ø)

mosaic/__init__.py
100.00% <100.00%> (ø)

mosaic/columns/abstract.py
79.34% <100.00%> (+1.01%)
:arrow_up:

mosaic/datapanel.py
76.85% <100.00%> (+1.23%)
:arrow_up:

mosaic/mixins/copying.py
91.66% <100.00%> (+5.62%)
:arrow_up:

mosaic/mixins/mapping.py
71.42% <100.00%> (+0.93%)
:arrow_up:

mosaic/ops/concat.py
90.32% <100.00%> (+0.66%)
:arrow_up:

mosaic/ops/merge.py
81.66% <100.00%> (+0.63%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce9cac...4fd2848. Read the comment docs.


Add smtp codec (client side only).

Motivation:
When writing a SMTP client a provided SMTP codec that follows RFC2821 is useful.
Modification:
Add client side codec and test.
Results:
People who want to write a SMTP client can reuse the codec.

@trustin please check

@trustin ping :)

@trustin PTAL

Looks great all in all. Just some trivial stuff.

Please feel free to cherry-pick after addressing the comments above. LGTM!

Cherry-picked into 4.1 (562d8d220028fbb3d62028bc5879a121dff2fdbd)


Chaining commands

Add chaining to commands (particularly add, delete, etc). Example:
!add sku=5021;6&intent=sell+!add name=Ellis' Cap&intent=bank
(+ as an example separator)

Thanks for the suggestion.

Closing the issue since this feature was added in #692 and successfully merged in to master.

Closing the issue since this feature was added in #692 and successfully merged into master.

not as requested, but it's pretty much similar, so yeah thank you 👍


AI Assist to build with Burr

Is your feature request related to a problem? Please describe.
Hi there, Burr is a popular repository to build agents. But most copilots aren't able to help with the latest syntax. So we created a custom AI Assist trained on this repo code + issues.
Please try it here.
It is also mentionable as a badge in readme and can help devs landing on the repo build apps for their use cases.

hope this helps!

@samyakkkk cool. Does it verify the code works? or at least contains no syntax  / wrong method errors?

Also how quickly does it update? We push new features regularly -- so it would be great if it surfaced what version/date of "burr" it knows about somewhere in the UI.

@skrawcz we reindex once a month, but can make it more frequent for Burr agent.
Great note about including the last indexing date. We shall have that in place shortly!

For running the code, we haven't added sandboxing since many users just use the IDE extension and run code directly.
The syntax generated is reliable for most cases. If there are wrong params or import mistakes, users can share that error back to the agent and it will fix it.

Repositories like Flame, RAG Techniques and many more are using the agent.
We can also provide you with a free discord bot that can assist users in the server and also learn from messages.
Best!

@samyakkkk happy to try it for discord. What's required for that?

@skrawcz for sure. If you decide to add the badge to the readme, we can immediately setup the discord bot and send a link.
We've had to set this policy so it help us grow while being able to keep the product free.

Sure. I'll bite. done.
If your backend is in python - happy to help get it on Burr and the app be quite meta ;)


angular ng-repeat shows all the images at once.

i have this view file where i have used slick.

  <slick infinite="true" slides-to-show="4" slides-to-scroll="1">

  </slick>

below is the output.

how can i use ng-repeat

Try calling slick.reinit() after the ng-repeat has finished rendering. You can do this by using $timeout and using jQuery to get the slick object.


Add background color to mobile bonds

Quick UI Fix, adds background color to the bonds on Mobile.

Nice, but missing the margin between each card

Thanks again! Starting to think I'm legitimately blind 👀


[Snyk] Security upgrade express from 4.19.1 to 4.19.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

591/1000  Why? Recently disclosed, Has a fix available, CVSS 6.1
Open Redirect SNYK-JS-EXPRESS-6474509
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: express
    The new version differs by 2 commits.

b28db2c 4.19.2
0b74695 Improved fix for open redirect allow list bypass

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect

Updated in #821


New Theme: hugo-stellar-theme

Ported Stellar template from html5up.
Here is the link https://github.com/antonpolishko/hugo-stellar-theme
Port is inspired by Highlights
Cheers

Hello @antonpolishko,
thank you for sharing this theme with us :+1:
When testing your theme with the build script for the Hugo theme site I got a warning that the theme.toml can't be parsed properly, because the homepage string was closed with two double-quotes. Could you fix that?

And please create an new folder called content inside the exampleSite directory. You can make this directory trackable by adding an empty file like .gitkeep inside content.
Otherwise Hugo complains about the absence of the folder.

@digitalcraftsman fixed

theme.toml can't be parsed properly, because the homepage string was closed with two double-quotes

I actually linked line 21 containing the link to the website of the original theme author. The homepage for your theme in line 8 is optional.

now should be fixed

Everything looks good now. I added the stellar theme a moment ago. It should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.


Suggestion: add function to read the parameter estimates of a BEAST2 posterior file

I have written a function that reads a .log file to obtain a data.frame with all parameter estimates in the MCMC. I suggest to add that function to this repository.
Do I have a green light to submit a Pull Request?

Sure.

Added by sending a Pull Request, that got accepted.


mathInfo: unset undefined (None) attributes

see conversation at https://github.com/robotools/fontMath/pull/176#discussion_r350184142

the only thing this really changes is that when number lists have unequal lengths the resulting field will be set to None instead of taking the value from the first operand.

correct. I added a test for that too.


Removed virtual package option from persistent deps.

Fixes #3 .
The apk add command which should add the libjpeg-turbo-dev dependency does not install anything. This is because in the base image php:7.2-fpm-alpine the virtual package name .persistent-deps was already used and was not removed with apk del .persistent-deps (and it shouldn't be).
Here's what apk add --help says about --virtual
-t, --virtual NAME      Instead of adding all the packages to 'world', create a new virtual package with the listed dependencies and add that to 'world'; the actions of the command are reverted by deleting the virtual package

I guess this means that any consecutive apk add with the same virtual package name will not add any packages because the virtual package is already added to 'world'.

I've fixed this issue for another environment, but I've forgot this one... Thanks for your contribution!


Add AllowOpportunistic flag to job classAd

Fixes #5994
This flag (allowOpportunistic) can be set during workflow assignment, which will make it down to the job classAd and then sites (initially T1_US_FNAL) can use that in order to forward jobs to another kind of resources.
Passes my initial test, though more testing/pylint/unittests are needed (if in time for testbed tomorrow).
@ticoann @hufnagel please review

test this please

added/fixed a few tests. I still have one more commit to make to fix the pylint stuff, hold on a bit more please Seangchan!

I'm done with my changes. Now we just wait for jenkins to get the new commit and go over it.

Com'on! I fixed testA_BulkDAOs because it failed in my VM. Let me take another look.

I lost my pylint changes while fixing this conflict. I guess because I used another computer and I did not pull all the indexes from my remote branch to my local... Anyways, we won't die if we let pylint changes off for this PR.
@ticoann feel free to merge it as soon as tests are green (pylint will fail for sure, spec changes)


How to show traffic lines on Route progress

how to draw traffic lines on route progress, please help we how to identify the start and end positions to draw traffic lines
import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:here_sdk/routing.dart' as Routing;
import 'controller/map_controller.dart';
import '../../theme/ui_style.dart';
/// A widget that displays the progress on the route as a progress bar.
class RouteProgress extends StatelessWidget {
/// Length of the route.
final int routeLengthInMeters;
/// Remaining distance of the route.
final int remainingDistanceInMeters;
/// Constructs a widget.
RouteProgress({
Key? key,
required this.routeLengthInMeters,
required this.remainingDistanceInMeters,
}) : super(key: key);
@override
Widget build(BuildContext context) {
return CustomPaint(
size: Size.infinite,
painter: _RoutePainter(
routeLengthInMeters: routeLengthInMeters,
remainingDistanceInMeters: remainingDistanceInMeters,
travelledColor: Theme.of(context).colorScheme.onSecondary,
remainingColor: Theme.of(context).colorScheme.secondary,
currentColor: UIStyle.currentPositionColor,
),
);
}
}
class _RoutePainter extends CustomPainter {
static const double _kLineWidth = 5;
static const double _kPositionSize = 10;
final int routeLengthInMeters;
final int remainingDistanceInMeters;
final Color travelledColor;
final Color remainingColor;
final Color currentColor;
_RoutePainter({
required this.routeLengthInMeters,
required this.remainingDistanceInMeters,
required this.travelledColor,
required this.remainingColor,
required this.currentColor,
});
final MapController mapController = Get.find();
@override
void paint(Canvas canvas, Size size) {
Paint paint = Paint();
double currentPosition = (routeLengthInMeters - remainingDistanceInMeters) /
routeLengthInMeters *
(size.width - _kLineWidth * 4) +
_kLineWidth * 2;
paint.color = travelledColor;
paint.style = PaintingStyle.stroke;
paint.strokeWidth = _kLineWidth;

canvas.drawLine(Offset(_kLineWidth * 2, size.height / 2),
    Offset(currentPosition, size.height / 2), paint);

paint.strokeWidth = 1;

canvas.drawCircle(Offset(_kLineWidth, size.height / 2), _kLineWidth, paint);

paint.strokeWidth = _kLineWidth;
paint.color = Colors.blue;

canvas.drawLine(Offset(currentPosition, size.height / 2),
    Offset(size.width - _kLineWidth * 2, size.height / 2), paint);

paint.strokeWidth = 1;
canvas.drawCircle(
    Offset(size.width - _kLineWidth, size.height / 2), _kLineWidth, paint);

Path currentPositionShape = Path()
  ..moveTo(_kPositionSize, 0)
  ..lineTo(-_kPositionSize, -_kPositionSize)
  ..lineTo(-_kPositionSize / 2, 0)
  ..lineTo(-_kPositionSize, _kPositionSize)
  ..lineTo(_kPositionSize, 0);
Matrix4 matrix4 = Matrix4.identity();
matrix4.translate(currentPosition, size.height / 2);
currentPositionShape = currentPositionShape.transform(matrix4.storage);

paint.style = PaintingStyle.fill;
paint.color = currentColor;
canvas.drawPath(currentPositionShape, paint);
paint.style = PaintingStyle.stroke;
paint.color = Colors.white;
canvas.drawPath(currentPositionShape, paint);

}
@override
bool shouldRepaint(covariant CustomPainter oldDelegate) {
return false;
}
}

Hi, Step-by-Step Breakdown to Draw Traffic Lines (MapPolyline) on the Map Based on Traffic Levels

Each route is composed of multiple sections, and each section contains a list of spans. A span includes the traffic jam factor trafficSpeed.jamFactor.
We need to draw a MapPolyline for each span using its GeoPolyline (geometry. vertices).
The colour of the polyline should be determined based on the jamFactor and our specific requirements, using MapPolylineSolidRepresentation.
Finally, all created polylines should be added to the map scene using addMapPolylines.

Here’s a simplified example to illustrate how this code looks:
import 'package:here_sdk/routing.dart' as here;

MapPolyline? _createPolylineV1({required List<GeoCoordinates> polylineCoordinates, double? factor}) {
    return MapPolyline.withRepresentation(
      GeoPolyline(polylineCoordinates),
      MapPolylineSolidRepresentation(
        MapMeasureDependentRenderSize.withSingleSize(RenderSizeUnit.pixels, 5.0),
        getTrafficColor(factor),
        LineCap.round,
      ),
    );
  }

  Color getTrafficColor(double? factor) {
    if (factor == null) return Colors.transparent;
    if (factor < 2.0) return Colors.green;
    if (factor < 4.0) return Colors.yellow;
    return Colors.red;
  }

  void _showTraffic(here.Route route) {
    final List<MapPolyline> newPolylines = <MapPolyline>[];
    for (final here.Section section in route.sections) {
      for (final here.Span span in section.spans) {
        final double? currentJamFactor = span.trafficSpeed.jamFactor;
        if (currentJamFactor != null) {
          final MapPolyline? polyline = _createPolylineV1(
            polylineCoordinates: span.geometry.vertices,
            factor: currentJamFactor,
          );
          if (polyline != null) {
            newPolylines.add(polyline);
          }
        }
      }
    }
    mapController?.mapScene.addMapPolylines(newPolylines);
  }

Please adapt this sample code accordingly, as it might contain some bugs.

Hi, Step-by-Step Breakdown to Draw Traffic Lines (MapPolyline) on the Map Based on Traffic Levels

Each route is composed of multiple sections, and each section contains a list of spans. A span includes the traffic jam factor trafficSpeed.jamFactor.
We need to draw a MapPolyline for each span using its GeoPolyline (geometry. vertices).
The colour of the polyline should be determined based on the jamFactor and our specific requirements, using MapPolylineSolidRepresentation.
Finally, all created polylines should be added to the map scene using addMapPolylines.

Here’s a simplified example to illustrate how this code looks:
import 'package:here_sdk/routing.dart' as here;

MapPolyline? _createPolylineV1({required List<GeoCoordinates> polylineCoordinates, double? factor}) {
    return MapPolyline.withRepresentation(
      GeoPolyline(polylineCoordinates),
      MapPolylineSolidRepresentation(
        MapMeasureDependentRenderSize.withSingleSize(RenderSizeUnit.pixels, 5.0),
        getTrafficColor(factor),
        LineCap.round,
      ),
    );
  }

  Color getTrafficColor(double? factor) {
    if (factor == null) return Colors.transparent;
    if (factor < 2.0) return Colors.green;
    if (factor < 4.0) return Colors.yellow;
    return Colors.red;
  }

  void _showTraffic(here.Route route) {
    final List<MapPolyline> newPolylines = <MapPolyline>[];
    for (final here.Section section in route.sections) {
      for (final here.Span span in section.spans) {
        final double? currentJamFactor = span.trafficSpeed.jamFactor;
        if (currentJamFactor != null) {
          final MapPolyline? polyline = _createPolylineV1(
            polylineCoordinates: span.geometry.vertices,
            factor: currentJamFactor,
          );
          if (polyline != null) {
            newPolylines.add(polyline);
          }
        }
      }
    }
    mapController?.mapScene.addMapPolylines(newPolylines);
  }

Please adapt this sample code accordingly.

I was trying to show the traffic lines on  top of bottom navigation progress line

Hi, Step-by-Step Breakdown to Draw Traffic Lines (MapPolyline) on the Map Based on Traffic Levels

Each route is composed of multiple sections, and each section contains a list of spans. A span includes the traffic jam factor trafficSpeed.jamFactor.
We need to draw a MapPolyline for each span using its GeoPolyline (geometry. vertices).
The colour of the polyline should be determined based on the jamFactor and our specific requirements, using MapPolylineSolidRepresentation.
Finally, all created polylines should be added to the map scene using addMapPolylines.

Here’s a simplified example to illustrate how this code looks:
import 'package:here_sdk/routing.dart' as here;

MapPolyline? _createPolylineV1({required List<GeoCoordinates> polylineCoordinates, double? factor}) {
    return MapPolyline.withRepresentation(
      GeoPolyline(polylineCoordinates),
      MapPolylineSolidRepresentation(
        MapMeasureDependentRenderSize.withSingleSize(RenderSizeUnit.pixels, 5.0),
        getTrafficColor(factor),
        LineCap.round,
      ),
    );
  }

  Color getTrafficColor(double? factor) {
    if (factor == null) return Colors.transparent;
    if (factor < 2.0) return Colors.green;
    if (factor < 4.0) return Colors.yellow;
    return Colors.red;
  }

  void _showTraffic(here.Route route) {
    final List<MapPolyline> newPolylines = <MapPolyline>[];
    for (final here.Section section in route.sections) {
      for (final here.Span span in section.spans) {
        final double? currentJamFactor = span.trafficSpeed.jamFactor;
        if (currentJamFactor != null) {
          final MapPolyline? polyline = _createPolylineV1(
            polylineCoordinates: span.geometry.vertices,
            factor: currentJamFactor,
          );
          if (polyline != null) {
            newPolylines.add(polyline);
          }
        }
      }
    }
    mapController?.mapScene.addMapPolylines(newPolylines);
  }

Please adapt this sample code accordingly.

Thank you for the reply, how to erase traffic lines as user passes through it.