Plans around reference to Fluent UI 9!

What type of issue is this?
Updating referred Fluent UI library to latest version.
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Issue description
I have a general question around when & whether this library will update its reference to Fluent UI 9. Currently it points to older version and in controls like IconPicker, it is fetching icons from previous version and not Fluent UI 9 icons.
This is important as these controls are super useful however need to know plan around referring latest libraries.
Kindly answer and elaborate so it is clear.
Best Regards,
Nishant.

I'm also keen when SPFx will support Fluent UI 9 (aka Fluent 2.0). Not only for sp-property-pane but also for ModalDialog or BaseDialog and such.

Fluent 2.0 is a design language.
Fluent UI 9 is an implementation of Fluent 2.0. They are two completely different things.
Then, there is another thing to consider, which is the SPDialog Framework. It gets/got updated with every new version of SPFx simply because it's essentially backed into the complete SPFx ecosystem.
Very little information is available on which Fluent UI version it uses. From the dependencies, one would assume it's Fluent UI 8. https://www.npmjs.com/package/@fluentui/react.
Nevertheless, both SPFx and Fluent UI 9 implementations are built on a legacy implementation for Dialogs, which, In a supported way, relies on DOM Injection and DOM manipulations outside of the WebParts boundary. They are still built in a form IE11 supports with fewer functionalities than the OOTB '' HTML element.
This HTML element can be placed in any web part and function as dialogues or modal dialogues.
Of course, the styles are missing, but you get more functional web parts.
Recently, hTWOo UI ditched the IE 11 implementation of dialog and implemented state of the art. Both the pure HTML Dialog implementation as well as the HTWOO React Dialog implementation are more versatile than the current Fluent UI 9 implementation.
One single control can be served as:

Sidebars - left and right
Top bars
Bottom bars
as well as for status message bars

This is all made possible using the correct HTML element without event functionality-wise bleed to the rest of the page.
Also, this dialogue helps to handle return values from the dialogue into your web part in a native OOTB way.

If I try to be specific:
In my Org, designer used Fluent UI 2 kit to design pages and have used latest Fluent UI icons.
In my dev side, I have referred corresponding Fluent UI 9 react controls and all fine here.
Issue is if I use IconPicker from this spfx controls react repo, it pick icons from older icons library. This has side effects such as icons name are different.
So I would like to know if there is plan around updating Fluent UI reference here such that controls like IconPicker shows icons from Fluent UI 9. I am sure there would be other benefits too if we keep reference to latest library.
Best Regards,
Nishant.

Thank you very much for the clarification. When your designer use Fluent UI 2 kit - the can design applications for Windows Devices. Fluent 2 was introduced with Windows 11 first, and Windows is still the first-class citizen for those design kits.
For example, the new Fluent UI icons have been released for over a year and still need to find their way into the web world fully.
The "new" Microsoft Teams Client is the first application to use Fluent 2 and Fluent UI 9. Recently, the Microsoft List has been updating to Fluent UI 9, too, but this doesn't mean that the rest of SharePoint and "ALL" components got the same update.
Specifically, the new Icons selector is also available for certain web parts. Still, you need reusable control as a third-party developer, as it seems to be targeted at first-party developers.
If you like to use Fluent UI 9, you can use it today in your React Applications, npm install it and start developing with it.
The major issue would be the incompatible theming engines between Fluent UI 8 and 9.
The best approach is to tell your designer to keep using Fluent 1 until Fluent 2 becomes generally available in all applications. For that, we need to have Microsoft inform you when it is fully migrated, not only from a design but also from a technical perspective.
We need to know the details to ensure we reach equilibrium with Fluent 2 in SharePoint and all the other web-based applications.
Would you be able to find the latest icons? You will find them here: https://github.com/microsoft/fluentui-system-icons
or use an open-source tool such as @pnp/spfx-controls-react icon picker. The PNP reusable controls are open for contributions and are a community effort to support 3rd party developers with tools such as an icon picker. This is probably your best option because no official icon picker control is available anyway.
When someone from the community submits a PR to update those icons to the latest Fluent 2 icons, it will become available in a matter of days rather than a month.
or another option like mentioned before is hTWOo Icons - https://lab.n8d.studio/htwoo/htwoo-core/patterns/design-tokens-icon-overview/design-tokens-icon-overview.rendered.html or via the npm package.

Then, there is another thing to consider, which is the SPDialog Framework. It gets/got updated with every new version of SPFx simply because it's essentially backed into the complete SPFx ecosystem.
[...]
Recently, hTWOo UI ditched the IE 11 implementation of dialog and implemented state of the art. Both the pure HTML Dialog implementation as well as the HTWOO React Dialog implementation are more versatile than the current Fluent UI 9 implementation.

This sounds pretty good. As for my usecase - I'm displaying a dialog from an extension, a commandbar button to be precise. So I don't have any React-Code directly. That's why using the SPDialog-class of the SPFx frameworks is so convenient. I guess I would need to use React.createPortal to create myself a react-element where I could insert react-components like the HTWOO components you mentioned.

Well but in case of a dialog from an application customizer - that's a 6 liner:
<button id="dlgOpener">Open Dialog</button>
<dialog id="mydialog">Dialog Cotent.</dialog>

and the following script
document.getElementById('dlgOpener').addEventListener('click', () => {

   const myDialog = document.getElementById('myDialog');
   myDialog.openModal()

}

Of course you still need to have close button on rely on the ESC key. ;)

Maybe I'm missing something, but where would I put the HTML in a ListView Command Set extension?
And: do you have some sample spfx-solution that is using the hwtoo-react components?

@henningeiben I was able to code up a sample for you that demo's a very simple implementation of the dialog in a command set. Hopefully this helps you. The corresponding blog post is here: https://julieturner.net/post/htwoo-dialogs-command/

wow - that's amazing. I just looked into that and once you see it, it seems kinda obvious.

Glad I could help.


Edit flow points to wrong path when httpAdminRoot in use

Solving issue #25 broke "Edit flow" link.
Looks like commit https://github.com/andrei-tatar/node-red-contrib-ui/commit/9e8b5ac7494c9248e41e3fbf8e1a20acb3f28e5d should be changed a bit

Edit flow will actually be removed.
But there will be a way of adding custom button links on that same spot.
I, for example, expose only the node-red ui on the internet and not the node-red editor so there's no point in having the "Edit flow" button.


Removes Travis CI testing for HHVM

Issue #18

Crud - Didn't see that this one was already PR'd too - Removing HHVM testing will help with getting some of the other PRs to be testable successfully.

Thanks for contributing! Even though someone else took care of this issue, this still counts for #hacktoberfest. You should be able to check your progress here: https://hacktoberfest.digitalocean.com


Add versioning to docs

The current docs work well for 0.11 version of wasmd/cosmwasm (last stable launchpad version... running on heldernet).  Actually, some of the commands are only for 0.10, like coralnet.
However, they are not working for the current master (0.13, soon 0.14) running on stargate that introduced a lot of changes to wasmd. The only solution I see to support both current testnets is to add some doc versioning, a drop-down where people can select to view the older launchpad version, or the current master (and we can maintain a few older checkpoints for heavily used older versions).
Unfortunately, this is not currently supported by vuepress :( https://github.com/vuejs/vuepress/issues/1018
However, there is a plugin that does attempt to handle this, by copying the docs to a folder (we can put all current docs in 0.11/launchpad for example, then open a new one for 0.14/stargate): https://titanium-docs-devkit.netlify.app/guide/versioning.html
This is an example of a repo doing a similar strategy "by hand": https://github.com/nuwave/lighthouse/tree/master/docs
It would be great to set this up before resolving the numerous issues to update the docs to stargate. As many people are still using the launchpad version (as this has much more mature tooling for the sdk and client)

Absence of multi version support is quite disappointing with vuepress. This problem occurred to me before and I searched for vuepress versioning and could not find such thing back then. I was thinking to offer migration to another docs platform in the future when wasmd is branching. @ethanfrey thanks for finding this repo. No need for migration now 💯

Absence of multi version support is quite disappointing with vuepress. This problem occurred to me before and I searched for vuepress versioning and could not find such thing back then. I was thinking to offer migration to another docs platform in the future when wasmd is branching. @ethanfrey thanks for finding this repo. No need for migration now 💯

Checked titanium versioning plugin, this is from their website:
Your theme must be able to properly handle versioned page links. See the Titanium theme for a modified version of the VuePress default theme that is compatible with the versioning plugin.
I looked at https://github.com/cosmos/vuepress-theme-cosmos and it does not support versioning. Maybe we can the maintainers to support versioning? Should not be a lot of work for them and beneficial to cosmos-sdk docs. @ethanfrey ideas?

Checked titanium versioning plugin, this is from their website:
Your theme must be able to properly handle versioned page links. See the Titanium theme for a modified version of the VuePress default theme that is compatible with the versioning plugin.
I looked at https://github.com/cosmos/vuepress-theme-cosmos and it does not support versioning. Maybe we can the maintainers to support versioning? Should not be a lot of work for them and beneficial to cosmos-sdk docs. @ethanfrey ideas?

Sounds good. I will pass this along

Sounds good. I will pass this along

@lovincyrus Can you provide some guidance on how you achieved versioning on the Cosmos SDK docs with our docs package? 🙏

@lovincyrus Can you provide some guidance on how you achieved versioning on the Cosmos SDK docs with our docs package? 🙏

Oh I cosmos-sdk had versioning support for some time awesome. @lovincyrus great if you could detail how to use it in https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/readme.md

Oh I cosmos-sdk had versioning support for some time awesome. @lovincyrus great if you could detail how to use it in https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/readme.md

@lovincyrus great if you could detail how to use it in https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/readme.md

Versioning and version switcher has been implemented on cosmos sdk docs and tendermint docs. — "vuepress-theme-cosmos": "^1.0.179"

It is however broken atm because the issue couldn't be tested or reproduced locally. The latest version of vuepress-theme-cosmos was immediately merged with the master without any testing on docs-staging (https://docs.staging-cosmos.network). ☹

The current versioning method was built to specifically handle the use cases of the official docs, such as http://docs.cosmos.network/master, https://docs.cosmos.network/v0.39/intro/overview.html. Ref: https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/global-components/TmSelectVersion.vue#L25 The official docs are what we maintain, docs with path prefixes, and deployed using S3.
Current approach: Makefile and versions file to generate version prefixes to the docs url: (/master, /v0.39) and deployed on S3.
To implement versioning for Cosmwasm, there are some prerequisites:

Versioned docs (/0.11, /0.13, /0.14) must be cloned before the build using pre.sh

tendermint https://github.com/tendermint/tendermint/blob/master/docs/pre.sh
cosmos-sdk https://github.com/cosmos/cosmos-sdk/blob/master/docs/pre.sh

Once the versioned docs are available in the .vuepress/dist, Netlify deployment should be able to access the versioned docs given the right configs with config.js.

Steps to implement versioning w/ Makefile + S3 Deployment

add versions to .vuepress/config.js

versions: [
  {
    "label": "v0.39",
    "key": "v0.39"
  },
  {
    "label": "master",
    "key": "master"
  }
],

edit docs/versions for Makefile to loop through and generate versioned docs.

master              master
launchpad/backports v0.39

Makefile

https://github.com/cosmos/cosmos-sdk/blob/master/Makefile#L195 to build versioned docs and docs with path prefixes in the deployment.

Lmk if anything is unclear. @orkunkl

@lovincyrus great if you could detail how to use it in https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/readme.md

Versioning and version switcher has been implemented on cosmos sdk docs and tendermint docs. — "vuepress-theme-cosmos": "^1.0.179"

It is however broken atm because the issue couldn't be tested or reproduced locally. The latest version of vuepress-theme-cosmos was immediately merged with the master without any testing on docs-staging (https://docs.staging-cosmos.network). ☹

The current versioning method was built to specifically handle the use cases of the official docs, such as http://docs.cosmos.network/master, https://docs.cosmos.network/v0.39/intro/overview.html. Ref: https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/global-components/TmSelectVersion.vue#L25 The official docs are what we maintain, docs with path prefixes, and deployed using S3.
Current approach: Makefile and versions file to generate version prefixes to the docs url: (/master, /v0.39) and deployed on S3.
To implement versioning for Cosmwasm, there are some prerequisites:

Versioned docs (/0.11, /0.13, /0.14) must be cloned before the build using pre.sh

tendermint https://github.com/tendermint/tendermint/blob/master/docs/pre.sh
cosmos-sdk https://github.com/cosmos/cosmos-sdk/blob/master/docs/pre.sh

Once the versioned docs are available in the .vuepress/dist, Netlify deployment should be able to access the versioned docs given the right configs with config.js.

Steps to implement versioning w/ Makefile + S3 Deployment

add versions to .vuepress/config.js

versions: [
  {
    "label": "v0.39",
    "key": "v0.39"
  },
  {
    "label": "master",
    "key": "master"
  }
],

edit docs/versions for Makefile to loop through and generate versioned docs.

master              master
launchpad/backports v0.39

Makefile

https://github.com/cosmos/cosmos-sdk/blob/master/Makefile#L195 to build versioned docs and docs with path prefixes in the deployment.

Lmk if anything is unclear. @orkunkl


Revisit icon hash calculations for Cities

The formula in calculateIconHashForAllCards needs support for 6 icons instead of 4 icons, as well as arrows and fountains.

This isn't technically complete yet. Complex Numbers wasn't the only spot where we were relying on the hash.

Never mind, I guess Complex Numbers was the only thing that depended on it!


Short solution needed: "ffmpeg zoom" (ffmpeg)

Please help us write most modern and shortest code solution for this issue:
ffmpeg zoom (technology: ffmpeg)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to zoom video


Added Circular pb Gradient option

I have added code to the draw method of the DefaultDelegate that  uses
a SweepGradient  and canvas rotations with values based on the current
startAngle and sweepAngle to create a  nice gradient effect IF the user
sets the use_gradient attribute to “true”.

https://youtu.be/z6bYy9BLe8o video of gradient progress bar feature


plugins/sources/git.py: Do not checkout submodules by default

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Nov 25, 2018, 19:39
Background
We do not really want, as a default, to download things from internet the user have not specify in their .bst files

In GitLab by [Gitlab user @jjardon] on Nov 25, 2018, 19:40
mentioned in merge request !972

In GitLab by [Gitlab user @jjardon] on Nov 25, 2018, 20:01
mentioned in merge request freedesktop-sdk/freedesktop-sdk!722

In GitLab by [Gitlab user @jjardon] on Nov 27, 2018, 09:38
assigned to [Gitlab user @jjardon]

In GitLab by [Gitlab user @tristanvb] on Nov 29, 2018, 12:03

We do not really want, as a default, to download things from internet the user have not specify in their .bst files

I think the fact that the git module has submodules at a given commit, is an indication that those modules are required to build.
I think the deciding factor to consider here (asides from this being a breaking change which is already quite bad, we've been making far too many of these this cycle and hope we can stop doing it completely in one cycle or two...) is what is more convenient for the user ?
Consider the average: for all of the projects we tend to build which have submodules, do project authors have to disable checking out of submodules more than they would have to enable checking out of submodules ?
Also consider the case where a project author tracks a git source, and the new ref now points to a commit which has submodules; it seems to me quite disingenuous for their build to fail as a result of tracking, just because they did not consider having to manually enable checking out of the new submodules.
It also seems to me the motivation here is mostly just an optimization, which is good to consider but secondary to having things "just work out of the box".
In other words; BuildStream should provide an experience which "just works" as much as possible, while requiring the minimal amount of setup from the project author. If the project author wants to go ahead and optimize the build to exclude the download of a submodule which for some reason is unneeded for the build, then they can explicitly go ahead and do that... but at least by default things "just work".

In GitLab by [Gitlab user @tristanvb] on Nov 29, 2018, 12:17
Honestly regardless of the comments above about why I think we currently do have the correct default, I'm very inclined to reject this solely based on the fact that it is a very invasively breaking change.
Literally any project which uses any git sources which have submodules would break as a result of this change - while I know for a fact that a known project like gnome-build-meta has several (probably even close to 10, definitely more than 5) elements which have submodules which the authors previously did not have to care about - it stands to reason that there is a very good chance this breaks any projects that we dont know about and track closely - it's a very unfriendly change.

In GitLab by [Gitlab user @jjardon] on Nov 29, 2018, 13:56
[Gitlab user @tristanvb] ok, looking at https://gitlab.com/BuildStream/website/issues/24, I though some breaking changes were allowed in this cycle
If this is not the case, and even if I think this default behaviour is broken, would you be happy to change this MR to update the docs to warn about this?

In GitLab by [Gitlab user @nanonyme] on Nov 29, 2018, 17:55
[Gitlab user @tristanvb] note that also devs from Gnome were shocked after realizing the default. It seems likely most Buildstream users will turn the feature off by default before 1.4 is out and set explicit submodules where necessary. Of course, if you can assume everyone has projects done this way, this won't really be such a breaking change anymore...

In GitLab by [Gitlab user @tristanvb] on Nov 30, 2018, 07:06
We discussed this at length on IRC yesterday, the log of which starts here
I still firmly believe the default we have is the correct one, while I agree that users need to have more assistance and increased awareness around which of their modules happen to use, or start using a submodule.
There are some opinions on both sides of this, and as there is even a semantic to change the default project wide, there is no grounds to introduce a breaking change for this, so we will not.
For the sake of completeness, I will summarize my understanding of the arguments on either side:

Disable submodules by default
This proposal is largely driven by a module (I'm still not sure which one, gstreamer ?) which does something I consider to be rather fringe and unexpected; i.e. it does a conditional initialization of it's submodules from it's build scripts depending on what is found on the host system.
I.e. it will build its own copy of something depending on whether a dependency exists.
This fringe case, or set of cases is/are causing freedesktop-sdk maintainers frustration because they were not previously informed of the module even using any submodules; so their natural reaction is to presume that "Hey, I didn't ask for these submodules explicitly, so why am I using them ?"
I still hold the firm opinion that the not knowing part of this is the issue, not the default behavior. And the not knowing part can be easily addressed in another way which does not introduce a breaking change and also adds further value to BuildStream.

Enable submodules by default
The normal mode of operation of a project which uses submodules is that the module code shares something with other git repositories and it is not conditionally enabled by build scripts.
The defaults of BuildStream should always be optimized towards having things "just work" out of the box, once things are found to not work as a maintainer expects, then explicit settings can be added to individual .bst files in those cases, but the default case should "just work" for the majority.
Changing the default of submodules to be disabled as opposed to the current default, is proposing that elements which inadvertently use submodules break the majority of the time, until the user figures out on their own that the module in question needs a submodule to be explicitly enabled.
BuildStream does not have any way to know, or much less inform the user, that the reason for a build breaking after adding a new element or running bst track, is because the user forgot to go ahead and explicitly enable the submodule. The most likely scenario is that the user gets a broken build telling them "No rule to build foo.c", and let them figure it out for themselves.

Both scenarios have their drawbacks, but the drawbacks of enabling submodules by default are much less common, and can be addressed with better messaging, while the drawbacks of changing them to be disabled by default make life inconvenient for a larger spectrum of cases, and cannot easily be addressed by other means (as stated, we cannot know that a build failed because of a submodule, that BuildStream was not told to expect).
Better messaging
Throughout the above text I've been alluding to addressing the current frustrations with better messaging, I'll elaborate on what is meant by this here:

The git plugin supports explicit mentions of the URLs and paths of submodules it is expected to use, this is important to ensure project relocatability (building the same project from different, relocated source URLs), and is mandatory in the case of using source mirroring fallback urls, both of which rely on source aliasing to work.

Since there are features which cannot work without explicit aliasing of the submodule URLs, it stands to reason regardless that the user should be warned whenever a git source starts using a submodule that is not declared in the .bst file (which can happen when the source is added, or as a result of bst track).

Of course if a specific module wants to explicitly ignore / disable usage of submodules, the said warning is irrelevant to tell the user, since the user is already explicitly ignoring the submodule portion of the git input.

As with other warnings, these can always be configured as fatal, if a project wants to enforce that all git sources have the URLs specified, it can error out when they are not.

While this warning is already important to add regardless of this issue, in order to ensure proper aliasing of project input URLs, it will also have the side effect of raising awareness whenever a submodule inadvertently presents itself, leaving the user the choice of whether to explicitly ignore it or not - without damaging the default use cases of "Things just working with a warning".

In GitLab by [Gitlab user @jjardon] on Nov 30, 2018, 08:14
[Gitlab user @tristanvb] I think you are still missing the point. This issue is about control. The idea that having a look to my .bst files I know what exact elements are being built (and yeah, I want it to fail if some module tries to download something I have not specify in any if my .bst files)
The gstreamer case was an example, but a lot more can exist
About

There are some opinions on both sides of this

sorry, but you are you are the only one I know thinking the current default is the good one
Now, if changing the default is totally not an option I think we should improve this situation with:

Documentation
warnings in the build logs (which maybe we can make fatal)

In GitLab by [Gitlab user @tristanvb] on Nov 30, 2018, 09:01

[Gitlab user @tristanvb] I think you are still missing the point. This issue is about control.

You have control regardless of the default, the default is just not what you expect it to be.
I maintain that in either case, the issue is about awareness of what is what, which is what the warning approach will provide.

There are some opinions on both sides of this

sorry, but you are you are the only one I know thinking the current default is the good one

I think this is rather inflammatory, people don't tend to complain when things work. Your proposal clearly suggests a situation which causes things to not work by default; most of the time. As soon as we change things which cause things to not work by default, then the other side of the argument will be more apparent, and in the form of complaints.

Now, if changing the default is totally not an option I think we should improve this situation with:

I do think that this breaking change is not an option, it is not a simple CLI invocation change that will be a temporary annoyance to a few users at upgrade time, it is a change that breaks virtually any project which uses submodules.
We need to be even more careful about breaking the projects we don't know about than the ones we do know about and can patch; even if the numbers of those might be small, we need to focus on inspiring confidence in those who don't openly communicate with us, and we need to put a stop to the breakage fiaso as soon as possible.
When we talk about moving plugins into separate repositories etc, we might have an opportunity at that time to provide a transition to an alternative API for the git plugin at which time this conversation could happen again more meaningfully, but for concrete reasons I think I have explained very clearly (as opposed to just claiming "everyone doesnt expect this", which I think is rather hand wavy and not an argument backed up by facts), I will most probably remain in the enabled by default camp of that conversation, unless more real arguments based on fact present themselves later.

Documentation

This looks like simply a statement in the git plugin documentation front and center which says that This plugin will automatically stage the submodules by default, which is true. Perfectly acceptable one liner merge request I think.

warnings in the build logs (which maybe we can make fatal)

Yes, which I have already outlined and suggesting, and are useful in either case.

In GitLab by [Gitlab user @jjardon] on Nov 30, 2018, 12:27

I think this is rather inflammatory,

sorry, that was not my intention
I will submit a MR for the docs shortly

In GitLab by [Gitlab user @sstriker] on Nov 30, 2018, 20:28
For what it's worth, in my case we needed to turn submodules off as well.

In GitLab by [Gitlab user @jjardon] on Dec 2, 2018, 21:05
mentioned in commit f4e2a04b6d02a1c3a06c8cc1003343bed0e532e6

In GitLab by [Gitlab user @jjardon] on Dec 2, 2018, 21:06
mentioned in merge request !983

In GitLab by [Gitlab user @jjardon] on Dec 3, 2018, 09:37
mentioned in commit efe1bbd8bd410e268115e6f54a0562bfa9922dec

In GitLab by [Gitlab user @jjardon] on Dec 3, 2018, 11:14
mentioned in commit 9022a778827ad5fe6f39daa835aff6002dccf14c

In GitLab by [Gitlab user @jjardon] on Dec 3, 2018, 14:38
unassigned [Gitlab user @jjardon]

In GitLab by [Gitlab user @jjardon] on Apr 18, 2020, 14:11
mentioned in commit 4ecefebcc18547b422d401cf5556c9821d02934b

In GitLab by [Gitlab user @jjardon] on Apr 18, 2020, 15:31
mentioned in commit 3bcbcaff7363f47507003126fd81f0b4366f89cf

In GitLab by [Gitlab user @jjardon] on Apr 20, 2020, 15:57
mentioned in commit c9a1588f44abb71e93f584d88816dc30ded6ef40

In GitLab by [Gitlab user @jjardon] on Apr 20, 2020, 16:03
mentioned in commit 594b3dbc2fe952c7668ea2d1290856a1bbf9138a

In GitLab by [Gitlab user @jjardon] on Apr 20, 2020, 22:36
mentioned in commit 7d37de3b5bd828a9439b939afcf237df2f601b6d

In GitLab by [Gitlab user @jjardon] on Apr 22, 2020, 17:37
mentioned in commit c89b5c7c5297845d6a5d2fe33b3290f85391ff64

In GitLab by [Gitlab user @jjardon] on May 1, 2020, 20:05
mentioned in commit 25125d38ee54ac79056e246f900477e06490dbcb


Add MIT License to repo

to this one?

Assuming you can openly license RFCs/docs?

@denisnazarov http://www.rfc-editor.org/faq/#copyright


List index out of range when running inference

Hello @YixingHuang, I managed to setup the libraries in correct version and probably configs too.
However, when I am running the following command
python deepMedicRun -model ./examples/configFiles/deepMedicPlus/model/modelConfig_wide1_deeper.cfg -test ./examples/configFiles/deepMedicPlus/test/testConfig.cfg -load ./examples/output/saved_models/pretrainedModels/deepMedicWide1.high_sensitivity.model.ckpt -dev cuda0
I am getting such an error:
##########################################################################################
#                 Starting full Segmentation of Testing subjects                        #
##########################################################################################

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~         Segmenting subject with index #0       ~~~~~~~~
 Loading subject with 1st channel at: /home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/examples/data_test/PATIENT1002_VISIT2_T1CE.nii.gz

ERROR: Caught exception from main process: list index out of range
Traceback (most recent call last):
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepMedicRun", line 180, in <module>
    session.run_session(sess_device, model_params)
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/frontEnd/testSession.py", line 129, in run_session
    res_code = inference_on_whole_volumes(*([sessionTf, cnn3d] +
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/routines/testing.py", line 542, in inference_on_whole_volumes
    _) = load_imgs_of_subject(log, "",
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/dataManagement/sampling.py", line 473, in load_imgs_of_subject
    path_to_lbl = paths_to_lbls_per_subj[subj_i]
IndexError: list index out of range

Finished.

I have set up testChannels_t1c.cfg and testPriorChannels_t1c.cfg as mentioned in https://github.com/YixingHuang/DeepMedicPlus/issues/2
I have also removed the contents of testGtLabels.cfg and testRoiMasks.cfg
Do I need to put anything in them and prepare some additional file to run the model? Thank you very much for your help!

Hi @damiankucharski
"I have also removed the contents of testGtLabels.cfg and testRoiMasks.cfg": you also need to put the corresponding paths for the testRoiMasks.cfg and testGtLabels.cfg (for computing prediction accuracy).

Thanks @YixingHuang, I prepared the files and it went further but I am getting another error. I will open next issue.


Add option for TpchBenchmark to print custom statistics

Add  --include_custom_stats option that will include custom statistics along with execution statistics.
Also, add a check to ensure the drivers are finished before printing statistics.

@mbasmanova I extended the waitForTaskCompletion API to include the wait time as well. Can you please take a look and import again? Thanks.

I extended the waitForTaskCompletion API to include the wait time as well. Can you please take a look and import again?

Thanks. Re-imported. It might be helpful for waitForTaskCompletion to return a boolean indicating whether the wait was successful or not. The caller can then wrap it in ASSERT_TRUE(waitForTaskCompletion(task)). The EXPECT_TRUE inside the waitForTaskCompletion will print a warning, but would not halt further execution.

@mbasmanova good idea! made this change. However, ASSERT_TRUE requires the function return type to be void and cannot be inside main. So added another helper function.


CAMEL-11845: Migrate easymock and powermock to mockito

Migrate camel-cxf-transport from easymock to mockito.

Thanks for the PR it has been merged. Do you mind closing this?


Add column information to OpCode

This information is needed to support better diagnostics location from pytype.

Can you add some background on why you're doing this?

Done, I just added to the PR description.


Move s2s-babel-handler

Coverage decreased (-0.1%) to 95.346% when pulling 571321207f3d5937a07adffd166115991c35ea61 on pr-babel-handler into 57fc93c685fdf2ae32465a915c45ec03acdb9776 on master.


Vote registration takes more than 30min and failed

I tried twice to register to vote, but each time it took more than 30min to respond. The coin was sent but got no feedback (frozen at step 3 and cannot enter the step 4)
Is there any hardware requirement to vote?

@dipterix sorry to hear about your trouble!
There is no special hardware requirements to vote.
Please make sure to:

not let your machine go to sleep / hibernation during voting registration
try to have the Daedalus window focused during voting registration step 3
before attempting to register make sure to restart your machine and have only Daedalus Mainnet running.

Let us know if this helped 🙏

@nikolaglumac I followed your suggestions. It failed after running for hours. (Daedalus went back to re-sync with the mainnet)
In addition, I also aligned my computer time with my local time (+- 0.01s).
I'm using macbook pro 2017 with 4 core i7, 16GB RAM and 256 GB NVMe SSD.
The Ada was sent successfully within minutes, but waiting for confirmation took so long.

And you didn't see it getting confirmed in the Voting registration wizard step 3?

I don't think so. It was stuck in the 3rd step trying to confirm, not "confirmed". I don't know what's the interface next.

Would you be so kind to do send us the logs?

Sure, that'll be the best. Is there any way to get the logs?

Please use the “Download logs” option from application menu.

@dipterix any news on the logs?

@nikolaglumac sorry for being late. I just sent to your gmail

Thanks! I have checked them and they are not helpful as the information we need was already "rotated out" in the logs.
So we can only get this information if you do another attempt to register and then send us logs 10 mins after the registration attempt.

Thanks. The bug is fixed after upgrading to 3.3.1


Breadcrumbs pull from theme pallette

Origin: https://github.com/opensearch-project/oui/pull/131/files#r1043948677
Right now breadcrumbs have their own specific theme. We should likely pull from the official theme.

This was fixed in a previous PR


ADBDEV-824 Fix concourse script to run in our CI

We need to run regression tests for each our commit/PR.
I think it is a good idea to use Pivotal scripts to achieve
this target because we don't want to support our separate
pipelines.
But concourse scripts are quite tight with the Pivotal build process.
They use tarballs with proprietary components like quicklz library
during the build process. So I suggest:

disable python vendoring. We use gpdb with system python in production
remove steps which required proprietary quicklz library
provide build dependencies in the build environment (sigar, libuv)
use actual zstd library which provides higher compress ratio

Obviously, we will periodically get conflicts when we merge upstream changes.

I have rebased this over current adb-6.x.


Malformed rule error

I get the following error:
2015/11/14 12:42:23 Failed to load filters: Malformed rule "_gsdata_/**"

...when using:
rclone sync --checksum --bwlimit=1M --filter-from="rclone-filters.txt" acd:sites ~/sites

But no errors when using:
rclone sync --checksum --bwlimit=400k --filter-from="rclone-filters.txt" ~/sites acd:sites

This is my rclone-filters.txt file:
- _gsdata_/**
- _saved_/**
- node_modules/**
- bower_components/**
- **.git/**
- .DS_Store
- Thumbs.db
- .vagrant/**
- .sass-cache/**
- **.bower**
- .debris/**
- *.com*
- Icon?
- .otto/**
- files/cache/**
- files/tmp/**
+ .gitignore

I just updated to v1.25 and received no malformed rule errors prior to the update. I updated to fix this issue.

I tried to reproduce this but failed.
The filtering code didn't change from v1.24 to v1.25.
That error comes from the bit of code where rclone is checking that the rules start with +  or - .
So it looks like one of these

maybe there is an invisible control char in your filters file
maybe rclone's line parser isn't working on your platform

So to help resolve that, can you

email me a zip (I don't want email to interfere with the line endings hence the zip) of the rclone-filters.txt file (to<EMAIL_ADDRESS>or alternatively post a hex dump of the file (eg using xxd -g1 rclone-filters,txt if using linux)
tell me which platform (OS, 32/64 bits, OS version) you are using
double check you get different behaviours with the same file for rclone v1.24 and v1.25 - I find that hardest of all to understand so I'd really appreciate a double check.

Thanks
Nick
func (f *Filter) AddRule(rule string) error {
	switch {
	case rule == "!":
		f.Clear()
		return nil
	case strings.HasPrefix(rule, "- "):
		return f.Add(false, rule[2:])
	case strings.HasPrefix(rule, "+ "):
		return f.Add(true, rule[2:])
	}
	return fmt.Errorf("Malformed rule %q", rule)
}

I did some further troubleshooting at your request and found that the problem lies elsewhere. At first I thought it was an issue using rclone with aliases because I got no errors using v1.25 when not using this alias:
alias pullsites='rclone sync --checksum --bwlimit=1M --filter-from="rclone-filters.txt" acd:sites ~/sites'

The baffling thing is, though, that through tinkering around with the alias and switching around rclone versions, using the alias, not using the alias, etc, I've stopped getting the error completely on one computer and started getting a different error on another computer using the alias or not.
2015/11/15 10:47:33 Starting bandwidth limiter at 1MBytes/s
2015/11/15 10:47:33 Unknown command "acd:sites"

I get this error using either version of rclone even though rclone lsd acd:sites works. So basically, I broke rclone on one of my macs. :)
I'm using OSX El Capitan on both computers. Here's the hex dump but the issue doesn't seem to be with the filters file itself.
0000000: 2d205f6773646174615f2f2a2a0a2d20  - _gsdata_/**.-
0000010: 5f73617665645f2f2a2a0a2d206e6f64  _saved_/**.- nod
0000020: 655f6d6f64756c65732f2a2a0a2d2062  e_modules/**.- b
0000030: 6f7765725f636f6d706f6e656e74732f  ower_components/
0000040: 2a2a0a2d202a2a2e6769742f2a2a0a2d  **.- **.git/**.-
0000050: 202e44535f53746f72650a2d20546875   .DS_Store.- Thu
0000060: 6d62732e64620a2d202e76616772616e  mbs.db.- .vagran
0000070: 742f2a2a0a2d202e736173732d636163  t/**.- .sass-cac
0000080: 68652f2a2a0a2d202a2a2e626f776572  he/**.- **.bower
0000090: 2a2a0a2d202e6465627269732f2a2a0a  **.- .debris/**.
00000a0: 2d202a2e636f6d2a0a2d2049636f6e3f  - *.com*.- Icon?
00000b0: 0a2d202e6f74746f2f2a2a0a2d206669  .- .otto/**.- fi
00000c0: 6c65732f63616368652f2a2a0a2d2066  les/cache/**.- f
00000d0: 696c65732f746d702f2a2a0a2b202e67  iles/tmp/**.+ .g
00000e0: 697469676e6f72650a0a0a            itignore...

Glad you've managed to fix it.
If you do see the error again and can reproduce it then do reopen the issue.
Thanks
Nick


MethodNotFound SerializedSkin.getArmSize()

Seems there's not getArmSize() in SerializedSkin in the latest 2.5.5-SNAPSHOT
https://paste.gg/p/anonymous/94088ceea32141cbb97dd2824f734915

If you're running maven, I suggest force updating your dependencies with mvn -U
It's likely that the bedrock-common is out of sync with the bedrock-v390 module

That sorted it out. Thanks


Clean loopbacks in TestDaemonNoSpaceLeftOnDeviceError

After #22172 some machines do not seem to properly release the loopback devices used in TestDaemonNoSpaceLeftOnDeviceError. I could reproduce it in trusty-3.13 and our arm ci also seems affected. https://jenkins.dockerproject.org/job/Docker Master (arm)/1679/console https://jenkins.dockerproject.org/job/Docker Master/label=centos && devicemapper/5328/console
This version manually releases the loopbacks. I've confirmed it working locally and in an arm ci box.
We can also consider reverting #22172 and investigating what the original problem was that caused us to use containers for mount calls.
cc @cpuguy83
Signed-off-by: Tonis Tiigi<EMAIL_ADDRESS>

Either option sounds good to me, revert to take this.  It looks like fedora was having an known issue with the original pr and was merged anyways.

No the pr fixed the issue with fedora.
The issue seems to be the mount binary expecting loop devices in a different location than they are.

LGTM

LGTM

This test is always failing on Fedora though (after https://github.com/docker/docker/pull/22172 and this PR):
----------------------------------------------------------------------
FAIL: docker_cli_daemon_test.go:1917: DockerDaemonSuite.TestDaemonNoSpaceLeftOnDeviceError

docker_cli_daemon_test.go:1934:
    c.Assert(err, checker.IsNil)
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc8220919c0)} ("exit status 1")


Fix issue #5914

Fix typo #hacktoberfest2020

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@scanum @JohanFreelancer9 can you please add the label hacktoberfest-accepted to this PR?

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Allow Focusing Datasheet Element

As seen on the demo page, when the user clicks a button outside of the datasheet, they are forced to click again onto the datasheet in order to resume typing. As default functionality this is fine, but it would be nice to expose a way to re-focus the datasheet so that the user can seamlessly resume typing after clicking an external button without needing to click back onto the datasheet where they were.
This is especially useful for button effects that change the users selection, so that they can then instantly start typing.
Fantastic component library by the way, it's incredibly flexible!

@Zetal911 - We can't know how the control will be consumed (for example what else is on the page). I don't think this is possible?

AFAIK if the ElementReference for the Cells or Sheet itself are exposed to the user, it's possible to call FocusAsync() on those elements in order to focus them. This would let me handle my own button events, perform whatever actions I want, and then set the focus back to the datasheet afterwards.

@Zetal911 - @ref="_datasheet" wont allow you to get the handler you need?

@ADefWebserver The Datasheet class has ElementReferences inside of it that I can access using reflection, but I'd prefer to avoid using reflection if at all possible. The Datasheet itself can't be used for this directly, as far as I'm aware.

@Zetal911 - No need for reflection. This should work:

@ADefWebserver Hi, I appreciate the help, but I don't see how that addresses the issue at hand. I'm not trying to set the focus to an arbitrary input field or other component that has an accessible ElementReference.
For clarity, when you do @ref="datasheet" on the  component, it will give you a Datasheet object. The Datasheet class does not extend ElementReference, and it can't be used to call FocusAsync() or as a parameter to that Javascript function, since it is not a valid HTML element.
Hopefully this helps clear things up.

@anmcgrath - Perhaps exposing _innerSheet in https://github.com/anmcgrath/BlazorDatasheet/blob/main/src/BlazorDatasheet/Datasheet.razor will expose what is needed?

Hi guys, at the moment the focus management is pretty rudimentary, there is a private variable in Datasheet.razor.cs: IsDataSheetActive. When this is false, key input doesn't trigger the editor to open which is what I think @Zetal911 wants to have more control over.
I can see that one method of giving more control would be to add a function to Datasheet.razor.cs such as SetDatasheetActive.
I don't know how well it would work triggering this on a button press for example, as the sheet itself listens to window events to set this flag but I'd be happy to give this a go.
Another issue with this is that if there is more than one datasheet on the page we would be relying on the user to manage which sheet is active. Not such a big problem I guess?

@anmcgrath Hey! I just wanted to pop in to confirm that you are absolutely correct! My mistaken tunnel vision on HTML 'Focus' was a total red herring.
I just used reflection to set the IsDataSheetActive value to true after my button press, and it works completely as expected now which is fantastic.
For those curious, this was the line of I code I used. I'll keep this around for now, but I'll definitely keep an eye here to switch out of reflection as soon as I can!

typeof(Datasheet).GetProperty("IsDataSheetActive", BindingFlags.NonPublic | BindingFlags.Instance)!.SetValue(MyDataSheet, true);

I've added the capability for you to set the datasheet as active in the latest commit:
await _datasheet.SetActiveAsync();

This will now you to re-focus the sheet to receive keyboard input as required.
with an extra event:
<Datasheet OnSheetActiveChanged="..."/>


Account recovery with a small residual balance stuck in pending

I recently attempted to recover my pool account after having removed the Lightning Terminal app in Umbrel as part of troubleshooting connectivity.  Upon running he accounts recover process it seemingly worked, but my account is now stuck in "PENDING_OPEN"
umbrel@hoz-umbrel:~$ sudo docker exec -it 412f /bin/bash
bash-5.1$ pool --tlscertpath=/data/.lit/tls.cert --rpcserver=localhost:8443 --macaroonpath=/data/.pool/mainnet/pool.macaroon accounts recover
{
        "num_recovered_accounts": 0
}
bash-5.1$ pool --tlscertpath=/data/.lit/tls.cert --rpcserver=localhost:8443 --macaroonpath=/data/.pool/mainnet/pool.macaroon accounts list
{
        "accounts": [
                {
                        "trader_key": "03802dacb679b5055fb9cc057bc26fd906a2cb9a62daf3aaa84cb848b13888f1d0",
                        "outpoint": "bc3b0115804c64ca7d01c6968a309f27ab49c698b293b8da81d71ae5a3b6985e:0",
                        "value": 7483,
                        "available_balance": 7483,
                        "expiration_height": 705794,
                        "state": "PENDING_OPEN",
                        "latest_txid": "bc3b0115804c64ca7d01c6968a309f27ab49c698b293b8da81d71ae5a3b6985e"
                }
        ]
}

Further troubleshooting of container in Umbrel showed the below log entry:
unable to resume account 03802dacb679b5055fb9cc057bc26fd906a2cb9a62daf3aaa84cb848b13888f1d0: rpc error: code = Unknown desc = minimum account value allowed is 0.001 BTC
refer to https://lightningcommunity.slack.com/archives/C01E0PRQ960/p1629110370057200 for more context

Let me add some context to the issue:
When we recover the account, if the account is in open/pending open in the server side, the client sets the account status to StateInitiated.
Then the flow calls the resumeAccount. The account will then goes throw StateInitialited -> PendingOpen -> Open. One of the steps in PendingOpen  is an rpc call to InitAccount to the auctioneer, which will fail if the account does not have an amount of  >100k sats.


Support deleting transitions on workflows

Description:
Once a transition is created there is no way back
**Acceptance Criteria: **

Provide a component to delete created transitions on workflow edit page

Hello , is there any updates on this? I wish to contribute however im pretty new to programming. So far i have tried to convert the on_delete = PROTECT to on_delete = models.CASCADE for the transitionmeta model and converting the transitionmeta field within transition from on_delete = PROTECT to on_delete= models.SET_NULL , it seems to be working but i am not sure if there is any repercussions in doing so

Hi @neowenshun , this has nothing to do with delete permissions between models. If you use river-admin, you would notice that it doesn't have the capability of deleting transitions. Making transition metas protected when there are transitions belong to it is a desired feature. One can simply delete all the transitions first before deleting the transition meta if it is really wanted to delete it. This is by design choice so that one can't delete the entire history just by deleting a transition meta. These operations require more attention.


Remove .gitmodules - dependency on UA-.NETStandard repository

The project UA Model Compiler uses NuGet packages but the repository still refers to the url = https://github.com/OPCFoundation/UA-.NETStandard.git.

Not clear why this is a problem.
The submodule is needed for testing and development.

According to the repository rules all feedback is applied to a private repository, hence I am no longer a willing helper to contribute to further development of the code. I am transferring this issue to my public fork mpostol/UA-ModelCompiler#7 where the modification will be applied directly and available for the public immediately. Further questions and proposals - you may have - should be provided using the discussion panel of the fork or by adding comments to the mentioned issue. Let's work out it with you and for you.
Cloe it with wontfix reason.


Add detailed trigger docs

Adding more info about the inner workings of the trigger - both to help onboard new devs and to help troubleshooting for both us and the customers. Will be continuing to add more to this as I go along, but this should be enough to at least get a good grasp on the main stages of execution it goes through.
Plus this includes fancy Mermaid flowcharts! See https://github.com/Azure/azure-functions-sql-extension/blob/chgagnon/triggerDocs/docs/TriggerBinding.md for the rendered view.

I tried adding links but couldn't get them to work. Clicking on them would just show an error. This seems to be because of how Github renders the charts - it's done in an iFrame which then seems to block navigation (presumably because of XSS concerns).
I'll keep trying though, I couldn't find any issues about it so maybe I was just doing it wrong.


Migrate to cats-effect 1.0.0

When it's close to be released and main libraries have adopted it

IMO: We can start a branch now where I can PR  the instances for ConcurrentEffect.

Why don't you just ignore cats? What is the penalty of not doing so?
If you are going to generalise, such that cats is an instance of that generalisation, I contend that you need to use a language that is superior to scala to successfully achieve this goal. One that is suitable for writing compilers.

Penalty:

No interop with http4s and related libraries, wherein we lose out in total ecosystem atm.

If you are going to generalise, such that cats is an instance of that generalisation

It's not a generalization. I'm referring to something very specific I spent hours with @jdegoes and @edmundnoble discussing in the cats-effect channels only to be overriden by a silly notion of "cancellation".

I contend that you need to use a language that is superior to scala to successfully achieve this goal.

Already on it boss. Doesn't mean I'm completely out of scalaz though, which is why I'm making this comment.

No interop with http4s and related libraries,

I don't necessarily agree that those libraries are useful. But putting that aside, and supposing they are useful, then why not fork and fix, at the very least?

Because the huge amount of time required to fork and fix for scalaz is better spent writing haskell.

Why don't we implement just the "useful" bits and throw NonsenseException for the rest? namely cancellable crap and friends.
Are you aware of a single useful lib that is abstracting over Concurrent? I think with Effect we have pretty much everything covered. I'm using an specialized Applicative with @@ for running stuff in parallel in my own code.

Hi all, just saw this issue ...
The implementation and laws of Cats-Effect are an on-going process and we are learning as we go.
In the end my hope is that we'll have a set of type classes that are generic and useful enough that you don't need to throw NonsenseException.
Version 0.10 had indeed assumptions about behavior that were not supported by ZIO, but we made a lot of progress since then. More progress is still needed in refining the laws (see #90 and typelevel/cats-effect#281), but it is my belief that the foundations are good and hopefully 1.0.0 will be good to go.
So just dropping a note that in case something doesn't work or doesn't make sense, drop me a line and we'll look at it, since supporting Scalaz's new IO has been a goal ever since it was announced. @jdegoes has been providing a lot of feedback already, for which I'm grateful.
Cheers,

Hi @alexandru,
I think all the cancelable stuff will never make much sense in ZIO given the core design decisions which are unlikely going to change. I think @jdegoes and @jmcardon were clear about that in typelevel/cats-effect#192 but that input was not considered (at least yet).
Do you see possible to split Concurrent? and push cancelable stuff down in the hierarchy to a new TC say CancelableEffect and leave things in Concurrent that make sense for ZIO such as fork, race and bracket so we can go one step forward and implement the instance for it.

I think all the cancelable stuff will never make much sense in ZIO given the core design decisions which are unlikely going to change. I think @jdegoes and @jmcardon were clear about that in typelevel/cats-effect#192 but that input was not considered (at least yet).

That issue has been considered, and was fixed partially in typelevel/cats-effect#237. More work needs to be done, but by 1.0.0 I'm confident we'll fix all laws — as you very well know, generic type classes and laws are hard to get right — which is why Scalaz has been a goal, since when designing type classes you end up specializing them for the "reference" implementation via non-obvious assumptions.

Do you see possible to split Concurrent? and push cancelable stuff down in the hierarchy to a new TC

Not sure what you mean. Bracket is at the top of the hierarchy. And Concurrent is defined by fork (start in our vocabulary) and race. The cancelable builder can be derived from bracket 😉

I would be happy to talk possible improvements btw 🙂
Just wanted to make it clear that the auto-cancelable model of ZIO is being accommodated and if we have laws left that do not work for ZIO then we'll treat that as a bug.
It's hard for me however to spot inconsistencies, I'm caught up between work, multiple OSS projects and life in general 🙂 therefore I can't familiarize myself with ZIO as much as I wanted. So input is very much appreciated.

You right, we are already implementing Bracket via Effect instance and we are passing the tests for that so not sure what you mean by "derive from bracket".
Concurrent has a few methods named something like *cancel* which I think are the ones causing problems with the tests not passing. I know start and race are in Concurrent already that's why I asked to only leave those which are the actual ones related to concurrency and move all the cancel-related ones to a separate TC, then obviously the tests are also moved and we no longer have issues to implement an instance for Concurrent.
Do that make sense?

If there are no theoretical blockers and no one else is currently doing it, I may implement it

@kaishh As far as I know, there are no blockers. Just a matter of someone putting in the work.

I've ran into a blocker with .runSyncStep in cats-effect-1.0.0-RC2 that doesn't really map to ZIO at all... postponing till http4s switches to RC3

@kaishh you can just return Left(source)  from it. Nobody uses it anyway and it was removed in RC3.

@kaishh we should not merge to master til it's released IMO. So I would suggest to keep your branch up2date with the latest RC regardless of which version TL libs support

That's a good idea actually, wait for 1.0.0. We are releasing 1.0.0 of Cats-Effect this Monday. Updates to all libraries will follow afterwards, not sure about the timeline.
@rossbaker what do you think of the timeline for Http4s?

Wrong Ross Baker :) @rossabaker

Damn 🙂 thanks for the correction

@kaishh Thanks for the update and your ongoing work on this!
@alexandru Looking forward to 1.0! 🎉

Can this be closed, since https://github.com/scalaz/scalaz-zio/pull/247 has been merged?

@jdegoes Can we release 0.2.9?

@kaishh Will do!

Thanks!


Adds throwing of an error for invalid interval parameter strings.

Also adds a test to validate the throwing behavior.
Closes #42.

Thanks!


Say Gex support when?!?!?!?

Description:
I propose the addition of "Say Gex" functionality to enhance the client experience. Currently, this feature is not available, and its inclusion would significantly improve user interaction.
Context:
The introduction of "Say Gex" would allow Gex to audibly communicate, providing a more dynamic and engaging experience for users. This enhancement aligns with the goal of improving overall client satisfaction.
Expected Behavior:
Upon implementation, users should be able to utilize the "Say Gex" feature to receive audible responses or information from Gex, contributing to a more interactive and user-friendly environment.
Additional Information:
I am eagerly awaiting the addition of this feature, as it holds the potential to elevate the client experience significantly.

i support this request fully


Team 6 Blog

are all issues solved?

are all issues solved?

Yes, I think the phrasing issues mentioned in these three comments are fixed.

@zhexjtu Hello Zhe, I believe the phrasing issues mentioned in the three comments have been fixed. Could you please review it once more to confirm it's ready for merging this pull request?

Yes, we have updated the file according to the feedback from Zhe.


Pass the state back to RPs along with the accessCode

At the moment it's passed through in the idToken. It should be passed in along with the accessCode.

Should be done in conjunction with https://github.com/gchq/stroom/issues/535


Add Kubeflow 1.8.1 release page

/lgtm

@thesuperzapper @zijianjoy Can you approve?

cc @kubeflow/kubeflow-steering-committee This PR is to add Kubeflow 1.8.1 release notes, released since April 8th. Can you help approve?


Define dir on Python _DynamicStub instances.

A minor point of annoyance I've found when working with GRPC's generated Python code is that dir(), doesn't produce useful output for stubs, because attribute accesses are dynamically dispatched based on the contents of self._cardinalities.  This becomes most notable in fancy shells like IPython, which use the output of __dir__ to generate autocomplete suggestions.
This patch makes _DynamicStub.__dir__ return the list of attributes that the user is likely to be actually interested in, namely the list of keys available in self._cardinalities.
I'm happy to add a test for this if it's an acceptable change, though someone may have to show me the right place to add such a test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Jenkins: this is ok to test.
Thank you for the pull request!

@ssanderson: yeah, there's nothing wrong here but we'd much rather see this change (if applicable) made against the code elements of the final API. What is it that has you still using the code elements of the Beta API?

The application where I'm using a grpc stub was initially set up using the beta api, and we hadn't updated under the (I think mistaken?) belief that we'd also have to update the server which isn't under our control.  From some initial testing, it looks like updating the client doesn't actually change the wire protocol, so I assume that means it's safe to switch to the stable client api without any server changes.  If that's the case, then I think this can be closed, since just doing stub = SomeStub(channel) produces a stub that has all its methods as instance attributes, which means the default __dir__ implementation does the right thing.

I could go either way. A while ago I drew a line in the sand and said "no new work on the Beta API; everyone with a complaint about it should migrate off of it" but what I'm now realizing is that what I actually meant was "no new work" by me. Since you've done the work here... well it's not covered by tests... and it's in code that we want to die at some point hopefully as soon as possible... but if you asked for this to be merged, I'd happily merge it. It's tiny and isolated from everything else.

@nathanielmanistaatgoogle I'm fine with having better completion be a carrot for folks to migrate to more stable APIs.  Speaking of which, I ported over our grpc client code today to use the GA API.  It generally went swimmingly, but one issue I'm running into is that it looks like the exceptions raised by various RPC calls have changed?  Previously our retry/error handling code was catching and handling AbortionError, whereas now we seem to be seeing subclasses of RpcError.  I assume that's expected behavior?  Are there any other gotchas I should be aware of while upgrading?

@ssanderson: yes, that's expected. It's part of the overall "there is no relationship between the two APIs; don't mix code elements from the two" circumstance. The only other gotcha is that there's no substitute for grpc.beta.implementations.google_call_credentials in the GA API; the resolution of that omission is being tracked in issue 8621.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @ssanderson isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
The Linux Foundation CLA GitHub bot


Correctly return finished

Hi,
I think this change makes the behavior of resume more semantically correct.
Consider the following code
void routine_func()
{
    std::cout << "step1" << std::endl;
    coroutine::yield();

    std::cout << "step2" << std::endl;
    coroutine::yield();

    std::cout << "step3"<< std::endl;
    coroutine::yiel3();

     std::cout << "done" << std::endl;
}

int main()
{
    coroutine::routine_t rt = coroutine::create(routine_func);

    std::cout << coroutine::resume(rt) << std::endl;
    std::cout << coroutine::resume(rt) << std::endl;
    std::cout << coroutine::resume(rt) << std::endl;
    std::cout << coroutine::resume(rt) << std::endl;

   return 0;
}

I think it is reasonable to expect an output  like
step1
0
step2
0
step3
0
done
-2

I would also suggest to add an enum like this
enum ResumeResult{
    INVALID = -1,
    FINISHED = -2,
    YIELD = 0
};

Cheers
Davide

After co-routine is created, it will not start to run until thread owner resumes it. This behavior makes co-routine more flexible, splits object instantiating and routine running.

The PR doesn't affect the behavior when routine is created

PR means ?

PR = Pull request :)
What I mean, is that in the example I provided, the 4th resume would return 0, even if the end of the coroutine was reached.
I think it is more intuitive that -2 (finished) is returned instead... since the couroutine finished at resume #4 .


[WIP] Support for non-linux hosts

The current gcc-arm-none toolchain implementation forces use of the linux download url to retrieve the gcc-arm-none-eabi-9-2019-q4-major compiler. This causes builds to not work properly when compiling on a host os such as Mac OSX.
I made a rudimentary attempt at implementing a fix for this but I don't think its necessarily correct. I've never built a Bazel extension so I was mostly fumbling through the source and the documentation to get to this approach. What I would have liked to have found was a way to directly access the host_platform rather than relying on the os attribute of the repository_ctx's os object which doesn't seem like it is the same. On Mac repository_ctx.os.name is "mac os x" but the actual host_platform should be "osx". Given that strange name I backed off of a sweeping change since I don't have a windows or linux machine that I could test off of to verify what the repository_ctx.os.name is in those environments.
If there is a better approach to this I'd be happy to reimplement it in a more idiomatic fashion if you point me in the right direction to do so.
I found this other extension that only focuses on the compiler https://github.com/d-asnaghi/bazel-arm-none-eabi. There might be a way to make your extension use that one? Happy to explore some options if you want me to.

Hi Brad, thanks for looking into this!
This has definitely been on my TODO list for a while now and I haven't got around to it just yet. I did look into doing this using the platforms API. As far as I can tell, the platforms api is configured in the analysis phase, however WORKSPACE rules are evaluated before the analysis phase. You can see this here. As a general guideline, you can't (there might be exceptions) access stuff in BUILD files from a WORKSPACE rule but can access functionality from a *.bzl file.
It does seem like we are stuck with the repository_ctx option at least for the moment. I currently dual boot between windows and linux so I can work on the Windows side of things but I don't have a mac. Getting this working on mac should be relatively straightforward as the shell behaves roughly the same.
There is some additional work that needs to be done with the other tools i.e. openocd
Does this work for you on mac after the new changes?

Yes, this works fine on my Mac now with this change. My main concern was not knowing what the repository_ctx.os.name value is on windows or linux and if it differs based on type. Alpine vs. Ubuntu for example. If this is the path we are going to take, I would suggest that we do something similar to what I did with the "mac os x" check for whatever value repository_ctx.os.name is set to on windows and default to linux for everything else. Worst case you have to add in a few more ifs at some point if there is some other variant that isn't covered.

I've just tried this on my linux system, which seems to work fine for now.
I have been thinking about simplifying this significantly down to just a simple dictionary. There is an example here. What are your thoughts on this?

Sounds good to me. You want me to update the code in this PR to do that or would you like to do it yourself?

If you can do that and test it on your mac then that would be fantastic. I will be adding mac osx to the CI, but I probably won't get that done until next week.

Yes, not a problem. I'll take care of it and we can review.

Wonderful, do you perhaps have a device that will work with openocd? It would be great to test those rules on mac, but I can't necessarily do that via the CI as the scripts themselves depend on external hardware.

Yes, my device uses a nrf52832 as the SOC so I can test openocd as well. I'll try to get all of this taken care of this weekend.

I think I'm happy with this change as is, for just the mac osx support. I'm going to merge this now as I have CI integration working.

For reference I have opened a new tracking issue #10


great!

How amazing and interesting your repository code is ！！
Do you have Python version of your algorithm ？

hey @zcdliuwei thank you for your interest in this project. this project is written in javascript and i currently don't have plans to port it to other programming languages.
there are however other projects that do similar things in other programming languages, including python.

https://github.com/MauriceGit/Delaunay_Triangulation
http://www.degeneratestate.org/posts/2017/May/24/images-to-triangles/


Resumable uploads malformed body

Same as for the multipart issue we had a few days ago now they went on to screw things with resumable uploads. just wanted to let you know

Well, it's working for me. Make sure you're using the latest release and check out this test script: https://github.com/Elringus/UnityGoogleDrive/blob/master/Assets/Scripts/TestFilesCreateResumable.cs

Yes sorry didn't update, was still using the old version, although I found a bug in the newer one, you are adding a new line or space symbol at the end of the file after uploading to the drive
I just found this out, I was uploading my files first then I run the script another time and if the hashes match no update is necessary, and it is wrong for every file
I opened the files with a text editor and noticed that the file I downloaded from the drive had 1 extra line at the end could you please look into this?
Da: "Artyom Sovetnikov"<EMAIL_ADDRESS>A: "Elringus/UnityGoogleDrive"<EMAIL_ADDRESS>Cc: "HerotechDevs" a.centili@herotechnology.it,"Author"<EMAIL_ADDRESS>Data: Tue, 13 Nov 2018 03:07:03 -0800
Oggetto: Re: [Elringus/UnityGoogleDrive] Resumable uploads malformed body (#32)
Well, it's working for me. Make sure you're using the latest release and check out this test script: https://github.com/Elringus/UnityGoogleDrive/blob/master/Assets/Scripts/TestFilesCreateResumable.cs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I reverted also from resumable to the normal multipart update. and the multipart is the one causing the issues since I just reverted back to resumable and it is working as intended

Good catch! I've removed the extra new line in the latest release: https://github.com/Elringus/UnityGoogleDrive/releases/tag/v0.23-alpha


userns sets mount and other setuid binaries to the remapped uid

Description

Steps to reproduce the issue:

Enable userns support
Create a new image with userns
Launch a privileged container with --userns=host
ls -l $(which mount)

Describe the results you received:
-rwsr-xr-x 1 jenkins jenkins 30664 Mar 29  2015 /bin/mount

Describe the results you expected:
-rwsr-xr-x 1 root root 30664 Mar 29  2015 /bin/mount

Additional information you deem important (e.g. issue happens only occasionally):
Docker creates the root filesystem of the image, but inside the userns. So mount is owned by the remapped user and not root. This causes issues where I have tools that bind mount /proc and /sys to other places on the fly, since mount refuses to work when it's not root.
00:06:12.714 mount: only root can use "--options" option (effective UID is 100000)

Output of docker version:
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 21:44:32 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 21:44:32 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 2
 Running: 0
 Paused: 0
 Stopped: 2
Images: 6
Server Version: 1.12.3
Storage Driver: aufs
 Root Dir: /var/lib/docker/100000.120/aufs
 Backing Filesystem: extfs
 Dirs: 16
 Dirperm1 Supported: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: overlay bridge null host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor
Kernel Version: 3.13.0-52-generic
Operating System: Ubuntu 14.04.5 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.955 GiB
Name: do-build-alpha-x64-intel
ID: W6ZI:OHNQ:I7L2:67KE:ZNC7:FXZF:GWNY:QGAK:EDRH:DIXM:PGZI:EUTT
Docker Root Dir: /var/lib/docker/100000.120
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Digital Ocean Ubuntu 14.04 droplet

ping @cpuguy83 @estesp

Thanks, I believe we discussed this on IRC.
At the moment this is the best we can do.
When userns is enabled, all images are chowned to the remapped root.
When something like shiftfs is merged into the kernel we can improve on this.

@cpuguy83 isn't --userns=host handled differently? In that case, that single container does not use remapping?

With --userns=host the container process is not placed in a new user namespace (meaning that it falls under whatever user namespace the daemon was started in, which might be the root user namespace; e.g. unmapped).  But the images have already been remapped because the daemon is running with the graph root for the mapping found at daemon start with --userns-remap=

Thanks @estesp I wasn't aware of that. Yes, then there's probably not much we can do currently.


Table file branch import and export to a file

Includes the ability to import table numbers along with the number of seats from a file, and to export all of the table information in the system into a text file.

Looks good, but does the pom.xml need to be committed?


Front End

Added new front end components.  Wrote errors components and pod components.
If you haven’t added my repo as a remote repo, run git remote add rob https://github.com/Hydroelectric29/Kubiquity.git
Create a new branch and pull my work: git checkout -b errors-nodes-fe && git pull rob main.
Run npm install && npm run watch
In second terminal, run npm start
Make sure app loads; make sure you can see the Errors / Error and Nodes / Node components with the mock data.
We have our GET requests commented out because FE is not connected to BE.
Styling is not included in this PR.
Data is currently mocked .  Based on what we might use in production.  Fetch request inactive.

@Hydroelectric29 @JefZheng @davidzhangnyc one thing I just noticed from looking at this PR is that all our files should have new lines at the end, and all our tabs should be two spaces, not four.
https://stackoverflow.com/questions/29972396/how-can-i-customize-the-tab-to-space-conversion-factor
https://stackoverflow.com/questions/44704968/visual-studio-code-insert-new-line-at-the-end-of-files

Overall just some minor styling changes needed. If you run eslint, it should fix the styling. Good PR!

These minor style changes will get fixed in the next FE PR, either from me or Rob.


Bug deploying new program

I tried to deploy the mainnet program past 2 weeks and it keep failing - https://prnt.sc/w57Geq7jEUQ4
solana program deploy always throw blockhash expired.
Solana version tried 1.14.17, 1.17.31
May i know how to resolve this issue

Possible workaround while waiting for the fix: https://github.com/anza-xyz/agave/issues/1018#issuecomment-2076608485

Same issue 35534


SLF4J-related fixes

Coverage decreased (-0.05%) to 88.491% when pulling 3200bb70d961a71c2fc050f5750501c7d921f227 on dtrebbien:patch-4 into f98a0b0a2549530cc83314c68df04b989229d200 on Netflix:master.


Does not work for multiple indexes

Hello! Thank you very much for this helpful and useful addon and for the Dexie!
It would be even better, if it would working with multiple indexes.
For example "*groupsIds -> group.id"
May be I have some problem with architecture of my app's DB, but I need that for example one item could be a member of 2 or more groups. (user is admin and buyer at same time, or MacBook is notebook and PC and topseller at the same time).
getForeignKeys() method doesn't cut off prefixes of fields before searching by index. But may be the problem is some deeper in core...
Thanks

Thanks for the request. Indeed support for many-to-many would be a nice feature. Part of the problem is how it parses indexes, but I believe that wouldn't solve it all. Anyone who have the time to fix this, please send a PR.

@dfahlander
I'm interested in this, could you provide a bit of info or references to how current multi index columns are handled?


Insights skeletons

Replaces "Loading..." text with the Insights skeleton component.
Fixes https://github.com/project-koku/koku-ui/issues/691
Initial loading state:

Cost loaded, while other cards are loading:

Codecov Report

Merging #737 into master will increase coverage by 0.07%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   76.69%   76.76%   +0.07%
==========================================
  Files         224      227       +3
  Lines        3634     3658      +24
  Branches      632      632
==========================================
+ Hits         2787     2808      +21
  Misses        758      758
- Partials       89       92       +3

Impacted Files
Coverage Δ

...wsReportSummary/ocpOnAwsReportSummaryAlt.styles.ts
100% <ø> (ø)
:arrow_up:

...rts/awsReportSummary/awsReportSummaryAlt.styles.ts
100% <ø> (ø)
:arrow_up:

...rts/ocpReportSummary/ocpReportSummaryAlt.styles.ts
100% <ø> (ø)
:arrow_up:

...s/ocpReportSummary/ocpReportSummaryItems.styles.ts
100% <100%> (ø)

...reports/awsReportSummary/awsReportSummaryItems.tsx
82.6% <100%> (+2.6%)
:arrow_up:

...pOnAwsReportSummary/ocpOnAwsReportSummaryItems.tsx
82.6% <100%> (+2.6%)
:arrow_up:

...eports/ocpReportSummary/ocpReportSummary.styles.ts
100% <100%> (ø)
:arrow_up:

...reports/ocpReportSummary/ocpReportSummaryItems.tsx
82.6% <100%> (+2.6%)
:arrow_up:

...ReportSummary/ocpOnAwsReportSummaryItems.styles.ts
100% <100%> (ø)

...eports/awsReportSummary/awsReportSummary.styles.ts
100% <100%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a88aa...d383ba2. Read the comment docs.

LGTM :+1:


drivers: rtc: add driver for the nxp pcf8523 rtc

Add Kconfig to allow configuring the RTC device driver initialization priority.
Add Kconfig for setting the RTC driver log level.
Add a device tree binding for the NXP PCF8523 Real-Time Clock (RTC) and calendar.
Add RTC device driver for the NXP PCF8523 Real-Time Clock (RTC) and calendar.
Add definition for the Adafruit Data Logger Shield. This shield is equipped with a PCF8523 RTC, an SD card slot, a couple of user LEDs and a prototyping area.
Add a build-only test for the NXP PCF8523 RTC driver since no in-tree boards have this chip.

@bjarki-trackunit, @nordicjm, @gmarull: Thank you for reviewing. I have tried to address the comments. Please revisit.


update Power control diagram

Need to include separate sensing and control of 5V power for each PCA9685 board, and separate control for 3.3 V.

updated power design document Power-control-2.odg added to ..docs/circuitry.


HA Shelly Integration not working after updating Shelly to "fw": "20210318-141402/v1.10.0-geba262d"

After downgrade to 1.9.x everything works fine.
Don't know if the error is her or in ha componet

Hi,
we need some more information:

device type ?
unicast or multicast setting ?
any error in HA log ?

Simone

All of my devices.
I have the error Shelly1, Shelly1 PM.   Shelly Dimmer is still on 1.9.x.
HA-Log:
Config entry 'PV_Balkon' for shelly integration not ready yet. Retrying in background
2021-03-18 23:25:58 WARNING (MainThread) [homeassistant.config_entries] Config entry 'shelly1-eltern' for shelly integration not ready yet. Retrying in background
2021-03-18 23:25:58 WARNING (MainThread) [homeassistant.config_entries] Config entry 'shelly1-jiska' for shelly integration not ready yet. Retrying in background
2021-03-18 23:25:58 WARNING (MainThread) [homeassistant.config_entries] Config entry 'shelly1-silas' for shelly integration not ready yet. Retrying in background
If I downgrade to 1.9.x it is ok.
Don't know where to get the information if unicast or multicast.

Found it.
Was my fault. PICNIC - Problem in chair not in computer.


The GLTF transparency is not rendered correctly in Filament (Sceneform 1.16.0)

Describe the bug
The GLB transparency is correctly rendered in some 3D viewers like Microsoft Windows 3D Viewer or Three.js GLTF viewer (https://gltf-viewer.donmccurdy.com/), but not correctly rendered in Fillament
To Reproduce
Steps to reproduce the behavior:

Use the sceneform sample from Sceneform Android SDK 1.16.0:
https://github.com/google-ar/sceneform-android-sdk/tree/master/samples/gltf
Test with the diamond.glb file that exported from diamond.blend Blender file
Expected behavior
The transparency is displayed
Screenshots
Expected:

Actual:

Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):

Device: Samsung Galaxy S9
OS: Android 10.0

Attached the GLB and original Blender file:
diamond.zip

The glTF file is loaded properly. It is marked transparent as it should be but the alpha value is 1 (fully opaque). The first screenshot at the top doesn't show transparency but just reflections. They also appear with Sceneform/Filament,  just less obvious because it's a different IBL.

No, it both has transparency and reflection
In the Thress.js player:

In windows 3D Viewer:

Can you open the GLB and check?

I did and its baseColorFactor is 1,1,1,1 or opaque white.

Note that I also tried exporting from Blender into a new gltf file and I got the same result. The alpha value of the principled bsdf is set to 1 in Blender so that may be the reason?

I also checked, there's no extension used in the glb file. No transparency shows up in https://gltf-viewer.donmccurdy.com/ either:

If I change the baseColor's alpha channel in Blender to a value less than 1 then the object shows up with transparency as expected in Filament and other viewers.

OK thank you @romainguy

Hi guys! I'm experiencing some issues using sceneform-ux:1.12.0 with sceneform:assets:1.15.0 regarding the loading of models via web. The issue I'm referring to is the transparency. So, I applied the alpha using Blender as suggested, but when loading it into the app it isn't as tranparent as I'd like since it seems sceneform is applying to it a sort of white color I don't really want. I'm attaching the settings I'm using in Blender and the code snippet used to load it.

This is the material I'm using, which as you can see it should be transparent without any white color. My base color values are R: 1, G: 1, B: 1, A: 0.05.

This is the code snippet I'm using:

Thanks in advance for any help!

Your asset is white in Blender, depending on your lighting environment what you are seeing is perfectly normal. Try with black instead.

Hi, now I'm experiencing another problem. The issue on hand is that I'm trying to map textures on a transparent material in Blender but what I actually get is an opaque texture. This is the texture I'm using: https://www.spaarkly.it/models/carreraGlasses/texture/lenti_BaseColor.png
and these are the screenshots I took in Blender:

So, what I'm wondering is: in case I want to apply a transparent texture what's the correct approach?

You have to connect the alpha channel of your texture to the Alpha input of the Principled BSDF in Blender.

Hi @romainguy  .
i am a little confused on this topic. I'm trying to import into sceneform assets at runtime. I created a fake object that I overwrite in runtime with the desired gltf. textures are also loaded in runtime respectively: baseColorMap, normalMap, metallicMap, roughnessMap.
this is my pbr_material.mat
`material {
name : "Textured material",
parameters : [
{
type : sampler2d,
name : baseColorMap
},
{
type : sampler2d,
name : normalMap
},
{
type : sampler2d,
name : metallicMap
},
{
type : sampler2d,
name : roughnessMap
}
],
requires : [
uv0
],
shadingModel : lit,
blending : transparent
}
fragment {
void material(inout MaterialInputs material) {
vec3 normal = texture(materialParams_normalMap, getUV0()).xyz;
material.normal = normal * 2.0 - 1.0;
    prepareMaterial(material);

    material.baseColor = texture(materialParams_baseColorMap, getUV0());
    material.metallic = texture(materialParams_metallicMap, getUV0()).r;
    material.roughness = texture(materialParams_roughnessMap, getUV0()).r;
}

}`
this the custom_material.sfa generated by sceneform
`{
materials: [
{
name: 'Material',
parameters: [
{
baseColorMap: 'DiffuseMap',
},
{
normalMap: 'NormalMap',
},
{
metallicMap: 'MetallicMap',
},
{
roughnessMap: 'RoughnessMap',
},
{
alphaFactor: 0.5,
},
],
source: 'sampledata/materials/pbr_material.mat',
},
],
model: {
attributes: [
'Position',
'Orientation',
],
collision: {},
file: 'sampledata/materials/custom_material.obj',
name: 'custom_material',
recenter: 'root',
scale: 0.5,
},
samplers: [
{
file:'src/main/res/raw/custom_material_default_diffuse.jpg',
name: "DiffuseMap",
},
{
file:'src/main/res/raw/custom_material_default_metallic.jpg',
name: "MetallicMap",
params: {
usage_type: 'Data',
}
},
{
file:'src/main/res/raw/custom_material_default_roughness.jpg',
name: "RoughnessMap",
params: {
usage_type: 'Data',
}
},
{
file:'src/main/res/raw/custom_material_default_normal.jpg',
name: "NormalMap",
params: {
usage_type: 'Normal',
}
},
],
version: '0.52:1',
}
`
I set the model at runtime like this
`  Uri baseColorSource = Uri.parse(TEXTURE_BASE_COLOR);
Uri metallicSource = Uri.parse(TEXTURE_METAL);
Uri roughnessSource = Uri.parse(TEXTURE_ROUGHNESS);
Uri normalSource = Uri.parse(TEXTURE_NORMAL);
    customMaterial = new CustomMaterial(this, baseColorSource, metallicSource, roughnessSource, normalSource);
    this.materialFuture = customMaterial.getBuilder().build();

renderableFuture = ModelRenderable.builder().setSource(this, RenderableSource.builder()
.setSource(this, Uri.parse(GLTF_ASSET),
RenderableSource.SourceType.GLTF2).setRecenterMode(RenderableSource.RecenterMode.ROOT)
.build()).build();
    renderableFuture.thenAcceptBoth(materialFuture, (renderableResult, materialResult) -> {
        customMaterial = materialResult;
        renderableModel = renderableResult;
        renderableModel.setMaterial(customMaterial.getValue());
    });`

part of the build of the custom_material class
`
CompletableFuture build() {
AndroidPreconditions.checkUiThread();
        CompletableFuture<ModelRenderable> renderableFuture = createMaterialRenderable();
        CompletableFuture<Texture> defaultColorFuture = createTexture(R.raw.custom_material_default_diffuse, Texture.Usage.COLOR);
        CompletableFuture<Texture> defaultMetallicFuture = createTexture(R.raw.custom_material_default_metallic, Texture.Usage.DATA);
        CompletableFuture<Texture> defaultRoughnessFuture = createTexture(R.raw.custom_material_default_roughness, Texture.Usage.DATA);
        CompletableFuture<Texture> defaultNormalFuture = createTexture(R.raw.custom_material_default_normal, Texture.Usage.NORMAL);
        CompletableFuture<Texture> baseColorFuture = createTexture(baseColorSource, Texture.Usage.COLOR);
        CompletableFuture<Texture> metallicFuture = createTexture(metallicSource, Texture.Usage.DATA);
        CompletableFuture<Texture> roughnessFuture = createTexture(roughnessSource, Texture.Usage.DATA);
        CompletableFuture<Texture> normalFuture = createTexture(normalSource, Texture.Usage.NORMAL);

        return CompletableFuture.allOf(
                renderableFuture,
                baseColorFuture,
                metallicFuture,
                roughnessFuture,
                normalFuture,
                defaultColorFuture,
                defaultMetallicFuture,
                defaultRoughnessFuture,
                defaultNormalFuture
        ).thenApplyAsync(aVoid -> {
            CustomMaterial customMaterial = null;
            try {
                customMaterial = new CustomMaterial(
                        renderableFuture.get().getMaterial(),
                baseColorFuture.get(),
                        metallicFuture.get(),
                        roughnessFuture.get(),
                        normalFuture.get(),
                        defaultColorFuture.get(),
                        defaultMetallicFuture.get(),
                        defaultRoughnessFuture.get(),
                        defaultNormalFuture.get()
            );
            } catch (Exception ex) {

            }

            return customMaterial;
        });
    }

    private CompletableFuture<ModelRenderable> createMaterialRenderable() {
        return ModelRenderable.builder()
            .setSource(context, R.raw.custom_material)
        .build().exceptionally(new Function<Throwable, ModelRenderable>() {
            @Override
            public ModelRenderable apply(Throwable ex) {
                Log.e("TAG", "unable to load custom_material renderable", ex);
                return null;
            }
        });
    }

    private CompletableFuture<Texture> createTexture(Uri sourceUri, Texture.Usage usage){
        return Texture.builder().setSource(context, sourceUri)
            .setUsage(usage)
            .setSampler(
            Texture.Sampler.builder()
                    .setMagFilter(Texture.Sampler.MagFilter.LINEAR)
                    .setMinFilter(Texture.Sampler.MinFilter.LINEAR_MIPMAP_LINEAR)
                    .build()
            ).build().exceptionally(new Function<Throwable, Texture>() {
                @Override
                public Texture apply(Throwable ex) {
                    Log.e("TAG", "Unable to load texture from $sourceUri", ex);
                    return null;
                }
            });
    }

    private CompletableFuture<Texture>  createTexture(int id, Texture.Usage usage) {
            return Texture.builder().setSource(context, id)
                .setUsage(usage)
                .setSampler(
                        Texture.Sampler.builder()
                                .setMagFilter(Texture.Sampler.MagFilter.LINEAR)
                                .setMinFilter(Texture.Sampler.MinFilter.LINEAR_MIPMAP_LINEAR)
                                .build()
                ).build();
    }

}

}`
I can't understand if the changes have to be made in blender or inside my custom material to load transparent runtime textures. the previous steps work well when I don't need to apply a texture to my object. Could you help us? now I think I'm crazy


Override parameter template with a config file

Is there a way to do the parameter template override with a config file instead of directly editing it in the Azure Devops release pipeline?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

@tucane Thanks for reaching out to us. We are actively investigating into your query and will update you shortly.

@djpmsft Can you please take a look at this ?

@tucane, To override the ARM parameter template, please use the custom parameters file.
You create a file called 'arm-template-parameters-definition.json' in root of your git repository and everytime you publish/export an ARM Template, the parameters will be generated based on those specifications rather than the default ARM ones.
Is this what you are looking to do?

Hey @djpmsft sorry for the confusion but this isn't what I was asking. We've already figured out how to use the arm-template-parameters-definition.json to define the arm parameters.
My question is on if there is a way for us override the parameters in this step with an external config file instead of directly editing in the box. Our team would prefer to edit this part with a config file instead of directly doing it in the pipeline to prevent accidental edits.

So the config file being used is specified in the 'Template parameters' section. By default, it isARMTemplateParametersForFactory.json in your publish branch. If you point this at a separate config file, then the generated parameters will be different.
Override template parameters is an optional property that allows you to overwrite what is set in template parameters

We're looking to do override template parameters, since we are following the ADF CI/CD guide to deploy the one template to different environments.
Our process:
1.working in dev adf -> making changes -> publish -> generate arm templates in the repo
2. use the arm templates in the repo to deploy to a prod adf through Azure Devops pipeline and override template parameter(for example, different storage url and compute resources than dev adf).

@tucane, your ask is very clear.
Unfortunately I don't think this is the correct forum for this specific question. ADF integrates with DevOps but we do not own this specific task (it can actually be used for any Azure resource).
Can you ask this question on this page? https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops#arguments
DevOps would know whether or not you can use a config file

Thanks @djpmsft, will be directing this question to them.


Better support for CJK characters.

Previously, the Unicode range of the CJK chractaters only includes Chinese charactaters, Japanese Kanji, and CJK Symbols and Punctuation. The range are used by traditioanl Korean as well. This commit further includes Hiragana and Katakana in Japanese, and Hangul Syllables and Hangul Jamo in Korean to make CJK support more complete.
Here's a Japanese Example.
Before:

After:

Thanks for the upgrade!


feat : lemmas about AddMonoidAlgebra.{divOf, modOf}

[x] depends on: #7582

This PR is not finished yet, need to translate these result about AddMonoidAlgebra to MvPolynomial

Can you merge master?

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.


Python version trove classifiers.

Hello! Was wondering if Python version classifiers could be added so that pytzdata can be detected properly by services like pyup.io as to whether this module is Python 3 ready.
At a minimum:
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 3'

This would require a new push to pypi but I'm sure something minor like this can wait if a new release isn't planned.

Thanks! It will be published to pypi when a new version of the Olson Database is released.


Error handling for empty password field.

If we want to be more specific and not catch all TypeErrors, we could check for empty PW earlier, after line 146:
username, password = interactive_get_username_password()

Branch can be deleted after merge.

Solves #40

Looks good. Could be improved if we explicitly checked that username is None or password is None, since the error assumes they are actually empty (and not some other kind of TypeError), but probably not worth the effort here.