Why doesn't my CarE2 Work?

I really have no clue why this E2 won't work. Basically, what I'm trying to do is when I press W, the wheels on the car go forward. When I press S, they need to go backwards, but they don't. Is there something I'm missing?
From here:
@name CarE2
@inputs W S
@outputs LeftWheels RightWheels
if(S == 0)
{
LeftWheels = 0
RightWheels = 0
}
if(S == 1)
{
LeftWheels = -1
RightWheels = -1
}
if(W == 1)
{
LeftWheels = 1
RightWheels = 1
}
if(W == 0)
{
LeftWheels = 0
RightWheels = 0
}
To here.

Just checking, have you wired the inputs W and S to pod controller and then linked that to vehicle?
Also, use Discord, you will get much better help there.

Yes. Yes I have. Also, there's a discord for wiremod?

Yep, there is Discord for wire, here.
Anyways, here, take mine gist.
So, if you have linked Pod Controller to some vehicle, wired it all up, once you enter it, press +forward (by default W key), it will set LeftWheels, RightWheels and LeftAndRightWheels to 1. If you stop holding forward key W, they will be set back to 0. If you hold down +back (S) and +forward (W) keys together, they will be set to 0, and if you only hold +back (S) key down, they will be set to -1.
Simple. Also, they will be always 0 as long as you don't wire things up.
Tip: Use Debugger tool to help you see values of inputs/outputs of wire gates.
@Divran How about to close this issue?

Here's a much better way of doing it
@name CarE2
@inputs W A S D
@outputs LeftWheels RightWheels

local ForwardSpeed = 1 #Change this to your liking
local TurningSpeed = 1 #Change this

LeftWheels = (W-S) * ForwardSpeed + (D-A) * TurningSpeed
RightWheels = (W-S) * ForwardSpeed + (A-D) * TurningSpeed

@Divran Thanks!


Metrics Related

The default  weights for evaluation is set at micro if this can be customised according to user inputs by adding an argument, it would have been much better

Hey,
I'm sorry for the inconvenience. But have you tried the latest version? It generates a prompt for user-specified weights.
Please let me know if you face any problems.
Thanks,
Ritam

Yes, thanks for the update, I would take a moment to appreciate your and your team effort


how to convert voc index to ppm

Hi sirs,  thanks for this great chip as well as the libraries your company provided. I did tried chip SGP40, acquired VOC index through your company's gas-index-algorithm and it works just fine. However, as we would like to the air quality in PPM unit and have no idea to convert with each other. could you please help for that. Thanks in advanced.

Hi,
SGP40 does actually not provide a value in PPM neither there is a formula to convert the measured value to it. The raw value you get is in so called VOC ticks (these ticks are proportional to the logarithm of the resistance of the sensing material), which are then usually process by the VOC algorithm to get a VOC index. You can set the algorithm parameters to fit your use case.

Thanks for detailed explanation. I thought you might have an equation to convert voc index into ppm as your SPEC mentioned the measurement range (ppm unit) of TVOC. I will read the source codes and figure it out myself. Thanks again for your kind suggestion.


Fix MetadataService connections leak

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8555 (d6d505a) into 3.0 (8739374) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #8555      +/-   ##
============================================
- Coverage     62.94%   62.77%   -0.18%
  Complexity      310      310
============================================
  Files          1117     1117
  Lines         46735    46690      -45
  Branches       7010     6998      -12
============================================
- Hits          29416    29308     -108
- Misses        14057    14117      +60
- Partials       3262     3265       +3

Impacted Files
Coverage Δ

...vent/listener/ServiceInstancesChangedListener.java
77.72% <100.00%> (+0.11%)
:arrow_up:

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-20.69%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
43.47% <0.00%> (-15.22%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../remoting/transport/netty4/NettyClientHandler.java
62.06% <0.00%> (-6.90%)
:arrow_down:

...moting/transport/netty4/NettyEventLoopFactory.java
30.00% <0.00%> (-6.37%)
:arrow_down:

...pache/dubbo/remoting/transport/AbstractServer.java
57.14% <0.00%> (-5.72%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8739374...d6d505a. Read the comment docs.


Include all data we're omitting

There's some data we're specifically omitting to not make tldData.json too big, but honestly that should be on the consumer to strip down the JSON file before inclusion in their app... Big file is fine for the default I think

Maybe include a custom webpack loader to help with above?


The test leanlaketest_old times out on FreeBSD

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
2001/2001 Test #1991: leanlaketest_old ..........................................***Timeout 1500.01 sec

Context
[Broader context that the issue occured in. If there was any prior discussion on the Lean Zulip, link it here as well.]
Steps to Reproduce
Regular tests
Versions
4.8.0
FreeBSD 14.1

Unfortunately, FreeBSD is not on our list of supported platforms and there are no plans to change that


IOU - Disabled tags in NewDot are still displayed in expense after being deselected

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.64-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4501633
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to https://staging.new.expensify.com/
Log in as Collect WS Employee.
In a WS chat create a expense request with a tag and open it
As WS Admin disable the tag that was just used in the request
As Employee navigate to the request details of the request made before
Click on the tag field
Verify the disabled tag is displayed in the list as selected and deselect it
Click on the tag field again

Expected Result:
Disabled tag is not displayed in the list
Actual Result:
Disabled tag is displayed in the list and you are able to select it again. Error appears Tag no longer valid
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/93e859c3-697c-4b92-959a-b29e2e68fd1a

View all open jobs on GitHub

We think this issue might be related to the #collect project.

waiting for proposals

waiting for proposals :)

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

Hi Mykhailo, glad to have you working on this :D I'm going to assign this issue to you

Hey!
I've investigated the problem. Actually, there is not any bug on the app's side. The problem happens because of the delay. The app sends a request to the backend, once an admin enables/disables some tags. Right after that, the backend prepares a message to all workspace members. It uses the Pusher. At this moment we can see this delay because the backend needs some time (+-30-40 secs) for me at least to send an update. So we can ask an internal engineer if it is possible to speed up the Pusher messages, but I am not sure that it is possible.
Details

https://github.com/Expensify/App/assets/57314631/4404ec54-3bc1-41e3-8f66-bb224cff78c4

I posted my conclusion above. Please review 🙂

I've asked engineering if we can speed up pusher

not overdue. this is a backend bug

Bumped question for engineering if we can/would speed up pusher


OpenWrt makefile doesn't build

Hi, using the current master openwrt Makefile, the build fails with the following verbose output:
mkdir -p /home/ubuntu/openwrt/dl
SHELL= flock /home/ubuntu/openwrt/tmp/.v3.1.tar.gz.flock -c '  	/home/ubuntu/openwrt/scripts/download.pl "/home/ubuntu/openwrt/dl" "v3.1.tar.gz" "x" "" "https://github.com/xHasKx/luamqtt/archive/"    '
Cannot find appropriate hash command, ensure the provided hash is either a MD5 or SHA256 checksum.
Makefile:49: recipe for target '/home/ubuntu/openwrt/dl/v3.1.tar.gz' failed
make[2]: *** [/home/ubuntu/openwrt/dl/v3.1.tar.gz] Error 255
make[2]: Leaving directory '/home/ubuntu/openwrt/feeds/jng_lua_openwrt/luamqtt'
time: package/feeds/jng_lua_openwrt/luamqtt/download#0.17#0.10#0.27
package/Makefile:111: recipe for target 'package/feeds/jng_lua_openwrt/luamqtt/download' failed
make[1]: *** [package/feeds/jng_lua_openwrt/luamqtt/download] Error 2
make[1]: Leaving directory '/home/ubuntu/openwrt'
make[1]: Entering directory '/home/ubuntu/openwrt'
make[2]: Entering directory '/home/ubuntu/openwrt/target/linux'
make[3]: Entering directory '/home/ubuntu/openwrt/target/linux/ar71xx'
make[3]: Nothing to be done for 'download'.
make[3]: Leaving directory '/home/ubuntu/openwrt/target/linux/ar71xx'
make[2]: Leaving directory '/home/ubuntu/openwrt/target/linux'
time: target/linux/download#0.03#0.03#0.07
make[1]: Leaving directory '/home/ubuntu/openwrt'

Hi @lePereT , please check again, I've updated the Makefile in commit 5324a6909816a0e528240034d9d285020906b8dd

Also, you may try to use a bash script https://github.com/xHasKx/luamqtt/blob/master/openwrt/make-package-without-openwrt-sources.sh


Mod 10 - Python - Prepare to use the Face SDK - fail

Hello @ivorb I'm using - and students at the course as well- the code provided here. I'm sending Python code use during current AI102 I'm teaching. From a population of 10 students , half of them used Python version and all failed at same point. C# version is working without problems.
We think it's a path related situation due to seem that the image file is not able to get it.
Adding face-api folder to allow you to check and test.
Let me know, students are waiting for an answer.
Best regards,
face-api.zip
Originally posted by @mpaione in https://github.com/MicrosoftLearning/AI-102-AIEngineer/issues/141#issuecomment-1178863457

So, from June 11th, the Face service (and Video Indexer) are restricted to organizations who have explicitly requested access. See https://docs.microsoft.com/en-us/azure/cognitive-services/computer-vision/overview-identity
This is likely the cause of the issue. Nothing we can do I'm afraid.

Thanks for the reply, if that the situation the lab will fail in C# as well and it’s not the situation, lab fail on Python code only, C# works fine.
Marcos Paione
<EMAIL_ADDRESS>From: Graeme Malcolm @.>
Sent: viernes, 8 de julio de 2022 14:09
To: MicrosoftLearning/AI-102-AIEngineer @.>
Cc: mpaione @.>; Mention @.>
Subject: Re: [MicrosoftLearning/AI-102-AIEngineer] Mod 10 - Python - Prepare to use the Face SDK - fail (Issue #143)
So, from June 11th, the Face service (and Video Indexer) are restricted to organizations who have explicitly requested access. See https://docs.microsoft.com/en-us/azure/cognitive-services/computer-vision/overview-identity
This is likely the cause of the issue. Nothing we can do I'm afraid.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/AI-102-AIEngineer/issues/143#issuecomment-1178914558, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADGYD7YCI5IVBEBFHQDFLY3VTAK4TANCNFSM53AUWTDQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Yes. Thank you.
We're working on that.


Parse some values like a CSV

This helps to handle the case where a key/value is like "foo\bar baz", as these should not be split on space inside quotes.

Hi @ss23
Thank you so much for your quality contribution.
Apologies for the delay in reviewing, but I see no issues, and shall be merging now.


allow custom videoPath in url

requirement from the popcorntime fork

hmm. this seems a bit weird / coupled to me. i'd be open to a catchAll: true option that would return the index file instead of 404 though

I'm building a application who's uploading files and my file provider store files by file name using the last param like https://server.com:1233/myfile.mp4 i'd like to see that be supported for peerflix.


⚠ RPC server - Figment Solana has degraded performance

In 85297b3, RPC server - Figment Solana ($FIGMENT_SOLANA_RPC_URL) experienced degraded performance:

HTTP code: 429
Response time: 124 ms

Resolved: RPC server - Figment Solana performance has improved in 7fb68bd.


Expand button for the log command doesn't work on Sierra

If I run the Git Log command (Bundles -> Git -> Log) and try to click on the + button, in the output that is generated by the command, nothing happens. Looking in the web inspector, the following JavaScript error occurs:
TypeError: Not enough arguments
	setAttribute (toggle.js:19)
	toggle_diff (toggle.js:19)
	Global Code (Script Element 2:1)

I see that this has been fixed. I used an older version.


Drop inherits, buffer-alloc dependencies

Buffer.alloc and Buffer.from were added in Node 6. inherits is not needed if we use a class.
This change only drops support for Node 4 and lower, which no one should be running at this point. Especially since Node 6 is already EOL and Node 8 is about to be EOL in December 2019. :)
I also removed package-lock.json which is not useful in packages since it doesn't get published to npm. It's existence only ensures that package authors get outdated deps that the users are not going to get.
This is not a breaking change since the exposed interface is still the same, i.e.
var stream = mp4.decode()

and
var stream = mp4.encode()

I know this is a lot of code to review.

For: https://github.com/brave/brave-browser/issues/5490

3.1.0


Improves the image viewer demo by adding rollover, screen refresh controls, and invert function

The viewer will now jump to image 0 if down is pressed on the last photo, or jump to the last if up is pressed on image 0.
To invert the display, press B.
To switch between TURBO and FAST refresh speeds, press C.
To jump to / switch between MEDIUM and SLOW speeds, press C while holding the USER button.

I know that the built-in demos are mainly supposed to be simple(ish) examples of the various functions and functionality of the badge, so you don't want them to be too complex- but I think at least adding the rollover would make the image demo much more satisfying to use.

Thank you! I'm all for extra features as long as they don't over-complicate things, but this is going to conflict with a pretty huge rewrite of parts of  badgerOS so bear with me!
I'm working on today's release, which will change a bunch of things (for the better, generally) and we can go from there if you're willing!

Absolutely! Let me know when the merges are/release is done and I will re-implement the changes in the new images.py and resubmit.

Alright. I'll wait for v1.18.6 and go from there.
The new appstate stuff adds a level of complexity (and coolness), but I'll make sure the inverted state and refresh speed states are stored through it. Though all four speeds will probably just cycle with one button, now that USER is harder to use!
I probably won't update my own badge past 1.18.4. I am either doing something interactive or putting something on the screen and turning it off, so the loss of a button combo isn't worth it!

Okay to move the goalposts again, Badger 2040 and Badger 2040 W are now combined and moved here: https://github.com/pimoroni/badger2040
If you're willing, these changes should be made over there!


test: add e2e tests for Flatcar Linux

Signed-off-by: Cosmin Cojocar<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:
Does this PR introduce a user-facing change?

Add E2E tests for cluster running on Flatcar Linux

/ok-to-test

@saschagrunert @janetkuo @JAORMX The base e2e tests passed, please could you have a look over my changes?
I am trying to enable the eBPF profile recording in a different pull request. Thanks

@saschagrunert @JAORMX The e2e tests passed now with containerd.

Great work @ccojocar :pray:!


[Bug] Device to Server RPC Requests not working via Edge

Describe the bug
We're using device to server RPC requests, which works as expected when connecting the device to the TB server directly or via a gateway using the MQTT api.
However, when the device is connected to TB Edge, the edge can't relay the RPC call to the server and throws the following error:
java.lang.RuntimeException: Unsupported msg type TO_SERVER_RPC_REQUEST
	at org.thingsboard.rule.engine.edge.AbstractTbMsgPushNode.onMsg(AbstractTbMsgPushNode.java:65)
	at org.thingsboard.server.actors.ruleChain.RuleNodeActorMessageProcessor.onRuleChainToRuleNodeMsg(RuleNodeActorMessageProcessor.java:135)
	at org.thingsboard.server.actors.ruleChain.RuleNodeActor.onRuleChainToRuleNodeMsg(RuleNodeActor.java:102)
	at org.thingsboard.server.actors.ruleChain.RuleNodeActor.doProcess(RuleNodeActor.java:61)
	at org.thingsboard.server.actors.service.ContextAwareActor.process(ContextAwareActor.java:45)
	at org.thingsboard.server.actors.TbActorMailbox.processMailbox(TbActorMailbox.java:142)
	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1426)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

Edge rule chain:

The documentation of the Action - push to cloud rule node states that it only accepts the following msg types:
POST_TELEMETRY_REQUEST
POST_ATTRIBUTES_REQUEST
ATTRIBUTES_UPDATED
ATTRIBUTES_DELETED
ALARM
, so the TO_SERVER_RPC_REQUEST message type is missing.
Is there a different way to implement this functionality or is this a bug?
Your Server Environment

own setup

TB 3.4 running in k8s
TB Edge 3.4 running in Docker on the edge

Your Device

Connectivity

MQTT

To Reproduce
Steps to reproduce the behavior:

Send device to server RPC request via MQTT directly to TB edge and observe the Push To Cloud rule node throwing the above error.

Expected behavior
The device to server RPC request should be relayed to the server regardless of the TB edge being used or the device being connected to the server directly

hi @thirstyfish
Could you please provide more information on your use case? Why you would like to send this RPC Request from the device to the cloud and not process it directly on the Edge?
That's is true, push to cloud rule node doesn't support these types of messages.
We are going to update the default Edge Root Rule chain and remove Success connection to push to cloud rule node.
But still, please provide more details on your use case, so we can provide you with a solution to your problem.

Hi @volodymyr-babak  - thanks for your response.
We're using device to cloud RPCs to estimate uplink latency (RPC roundtrip time) for now.
However, in the future, the following use cases would be introduced:

calls to 3rd party commercial APIs that are not possible to distribute access keys for to every single edge instance so they need to be called from a single cloud service via an RPC from the edge.
calls to frequently changing business rules/logic that's outside the scope or impractical to manage in ThingsBoard and is managed in a different cloud service

We could rely on a simple protocol built on top of client side / shared attributes for up/down comms for all the above scenarios but it unnecessarily overcomplicates things and would be inelegant.
It'd also be ideal to be able to expose the same capabilities to edge devices regardless of whether they're connected to a TB edge server or to a local gateway device that's connected to the cloud TB via the MQTT gateway API.

@volodymyr-babak any update on this? I'm also interested in this feature.
Specially in this part:

It'd also be ideal to be able to expose the same capabilities to edge devices regardless of whether they're connected to a TB edge server or to a local gateway device that's connected to the cloud TB via the MQTT gateway API.

hi @thirstyfish @AndreMaz
at the moment RPC requests are works only for the local device session.
But we consider this as a bug/enhancment, that should be addressed in future releases.
We are going to design this feature and provide an update on the expected release of version 3.4.2 or 3.5.
The general problem in this feature is round trip from cloud to the device over edge and usage of general downlink queue for all types of messages.
Probably we are going to introduce some kind of high-priority queue to achieve RPC and shared attribute subscription from cloud to end device over the edge.

Thanks @volodymyr-babak
Just to clarify, could you please confirm that the downstream (cloud => edge => device) RPCs don't work either at the moment, not just the upstream (device => edge => cloud) RPCs which were the original topic for this ticket?
Bumped into this downstream issue today and just want to ensure we're not debugging something that's not supposed to work yet.
Thanks!

@thirstyfish
sorry for the delay - somehow I missed your latest comment on this topic.
Could you please provide more details on your downstream RPC request? Is it oneway or twoway?
Both these RPC requests from the cloud to the device connected to the edge should be working and we have integration tests special for these cases:
https://github.com/thingsboard/thingsboard-edge/blob/master/msa/edge-black-box-tests/src/test/java/org/thingsboard/server/msa/edge/DeviceClientTest.java#L462
Is your device assigned to a single edge?
Do you have in the downlink section of the edge any 'Pending' requests?

Thanks for getting back on this @volodymyr-babak
We've put the testing of TB-edge on hold for now, so re-deployed it to retest and the downstream RPCs seem to be working fine now.
It may have been an issue with the device <-> edge assignment as you pointed out, apologies for the false alarm.
Do you have a planned ETA for the upstream RPCs by any chance?
Cheers

Hello @thirstyfish
pull request was created yesterday
https://github.com/thingsboard/thingsboard/pull/7592
I hope to fit this fix into 3.4.2 release, that is coming soon (approx. 2-3 weeks)

That's great news, thanks for the update @volodymyr-babak !
Cheers

pull request was merged. fix is already in the master branch and is going to be available next release.


Always stick to header

Hi,
Your library is great :+1: , thank you so much for sharing it.
Can we make scroll 1 sticky header to always on the top (stick with status bar), and rest of the content to go underneath.
If we can do so, it would be great help.
Thanks. :)

I second this request.  Looking for a way to work around it now.

+1

@zeeshankhan even I am trying to do the same thing.. any help?


chore(deps): Update dependencies 12.07.22

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support exporting

Support exporting off of a read only filestore

@tacaswell @danielballan ready for review!

Thanks. Hope exams are going well!

Thank you, we'll see, coding is my release valve.


Ability to ignore some links/references

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] This issue affects my Ory Cloud project.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe your problem
From what I understand in the docs, we can ignore files using paths in a .reference-ignore file or directly using the .ignore input field filled wiht paths.
I would like to be able to ignore some issue links that should not raise a new reference closed issues.
Describe your ideal solution
I don't know what the best way is to do this, but either using a list of urls, or by placing a comment near the link in the code ?
The comment in the code seem really verbose, so maybe a list of urls is a better idea. Passing it through a github action field input could be a good thing ?
Workarounds or alternatives
None
Version
v1.3.3
Additional Context
No response

I am very sorry for the late response, somehow missed the notification.
Your use case is definitely a good idea, I actually had the same problem already myself. I think it makes sense to add something to the comment itself. You might reference one issue on purpose somewhere, but maybe you would like to be notified elsewhere. Also, managing a separate file seems like to much work for me, if you could just add an exclamation mark (or similar) before the link in the comment.

Awesome ! Thanks !

You're welcome :wink:


support for http://www.w3.org/2005/xpath-functions/math/

http://manage.dimagi.com/default.asp?138135#938211


Fix the reconnection backoff accidentally resetting when thrown out of certain IRC servers

Only reset reconnect backoff when we can confirm a successful connection was made
Add changelog entry

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description

Fixes #3313

@Felanbird it's set right here :) https://github.com/Chatterino/chatterino2/blob/fix/dont-reset-reconnection-backoff/src/providers/irc/IrcConnection2.hpp#L34

@Felanbird it's set right here :) https://github.com/Chatterino/chatterino2/blob/fix/dont-reset-reconnection-backoff/src/providers/irc/IrcConnection2.hpp#L34

👍 - I misunderstood the purpose of the <4> when playing with it myself

Looks good to me


fix boilerplate error in /bin and /prow directory

parts of https://github.com/istio/istio/issues/8996

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @stewart-yu. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu, sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @ rshriram

/assign @linsun

/approve
pending pass shellcheck test.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, linsun, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/retest

@stewart-yu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
e29c4f794437ebb68357383e8a9ac70624b02d5c
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-mcp

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, linsun, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stewart-yu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
9a6d9a88cb8d158975fecbb6bc57119164ebec90
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stewart-yu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
9a6d9a88cb8d158975fecbb6bc57119164ebec90
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
9a6d9a88cb8d158975fecbb6bc57119164ebec90
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stewart-yu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
9a6d9a88cb8d158975fecbb6bc57119164ebec90
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stewart-yu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
9a6d9a88cb8d158975fecbb6bc57119164ebec90
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Passing an undefined query param can prevent the url from updating

Version
3.0.2
Reproduction link
https://plnkr.co/edit/yJJpcKuhYQwdOk3nZcZs?p=preview
Steps to reproduce

Start with the url /?q=foo&color=bar.
this.$router.push({query: {q: 'foo', offset: undefined}})

What is expected?
I expect the url to change to /?q=foo
What is actually happening?
The url does not change

I'm doing search filtering using query params. Every time I change a filter, I
add/remove/modify the appropriate param, and reset my pagination by setting
an offset param to undefined. In my app, the combination of removing a param
and offset not being set to begin with, causes the route not to update.
This issue is easy enough to work around, but it took me a while to figure out
what was going on.

For the moment the way to do it is to remove the property from the object (instead of providing undefined). The thing is it is kept in $route.query which shouldn't in order to be consistent when coming directly by entering the url
Technically, removing the query parameters would be a breaking change so I will keep this open for next major version

@posva To be clear, using undefined to remove a query parameter already works:

Start with /?q=foo
this.$router.push({query: {q: undefined}})
The url changes to /

Using undefined only fails in some circumstances.

I'm talking about this, these are how the tests should be written: undefined values should be removed from resulting query object
 it('should work consistently', () => {
    router.push({ query: { bar: 'bar' } })
    router.push({ query: { bar: undefined } })
    expect(location.hash).toEqual('#/')
    expect(router.app.$route.query).toEqual({ })
  })
it('should support the example use case', () => {
    router.push({ query: { q: 'foo', color: 'bar' } })
    router.push({ query: { q: 'foo', color: undefined } })
    expect(location.hash).toEqual('#/?q=foo')
    expect(router.app.$route.query).toEqual({ q: 'foo' })
  })

Technically it would be a breaking change

Closing as this was fixed in v4


Move futures-util tests into futures/tests

Currently, most combinator tests are in futures/tests, and some remaining tests are in some files of futures-util. It is probably better to put this in one folder (it will be easier to find).

Thanks! This has a conflict with master, but I'll merge when that's resolved.

Rebased (and Travis passed).

merged


Add NREL GHA runner WIF setup

Overview
Helps with catalyst-cooperative/nrel-fuel-and-industry-inputs#5.
What problem does this address?
The NREL github runner didn't have access to the archives on GCP.
What did you change?

put archives.catalyst.coop bucket under terraform management
add service account, permissions, and WIF for NREL GH runner

Testing
Here was the terraform plan. It took two applys to actually get it to stick since the service account took a little time to create.
Terraform will perform the following actions:

  # google_service_account.nrel_finito_inputs_gha will be created
  + resource "google_service_account" "nrel_finito_inputs_gha" {
      + account_id   = "nrel-finito-inputs-gha"
      + disabled     = false
      + display_name = "NREL FINITO inputs github action service account"
      + email        = (known after apply)
      + id           = (known after apply)
      + member       = (known after apply)
      + name         = (known after apply)
      + project      = "catalyst-cooperative-pudl"
      + unique_id    = (known after apply)
    }

  # google_storage_bucket_iam_member.nrel_finito_inputs_archiver_gcs_iam["roles/storage.insightsCollectorService"] will be created
  + resource "google_storage_bucket_iam_member" "nrel_finito_inputs_archiver_gcs_iam" {
      + bucket = "archives.catalyst.coop"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member = (known after apply)
      + role   = "roles/storage.insightsCollectorService"
    }

  # google_storage_bucket_iam_member.nrel_finito_inputs_archiver_gcs_iam["roles/storage.objectCreator"] will be created
  + resource "google_storage_bucket_iam_member" "nrel_finito_inputs_archiver_gcs_iam" {
      + bucket = "archives.catalyst.coop"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member = (known after apply)
      + role   = "roles/storage.objectCreator"
    }

  # google_storage_bucket_iam_member.nrel_finito_inputs_archiver_gcs_iam["roles/storage.objectViewer"] will be created
  + resource "google_storage_bucket_iam_member" "nrel_finito_inputs_archiver_gcs_iam" {
      + bucket = "archives.catalyst.coop"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member = (known after apply)
      + role   = "roles/storage.objectViewer"
    }

  # module.gh_oidc.google_service_account_iam_member.wif-sa["nrel-finito-inputs-gha"] will be created
  + resource "google_service_account_iam_member" "wif-sa" {
      + etag               = (known after apply)
      + id                 = (known after apply)
      + member             = "principalSet://iam.googleapis.com/projects/345950277072/locations/global/workloadIdentityPools/gh-actions-pool/attribute.repository/catalyst-cooperative/nrel-fuel-and-industry-inputs"
      + role               = "roles/iam.workloadIdentityUser"
      + service_account_id =<EMAIL_ADDRESS>
    }

Plan: 5 to add, 0 to change, 0 to destroy.

@e-belfer more of an FYI - and @zschira more of an "actually review this terraform setup" thing.

@e-belfer if NREL is switching to onedrive, it seems this might be outdated now?

@zschira We still will be working on this project through December and who knows, there may be future iterations. So for now I think we should keep it as is / not take it down.

Since this reflects the latest infra state in GCP we should merge it. Otherwise I can't make new changes to infrastructure without basing my terraform config off of this branch. If we want to undo the NREL WIF changes later it's very easy to just delete all this stuff and make terraform remove the infrastructure.


Update Readme.md

Alright I know I have said that giving away your cookies may not be that detrimental but at the same time, you're making it seem way too safe. While it seems that your account may not be stolen you can absolutely get for example impersonated in the forums. Rather than ltoken being "quite safe" it's closer to it being detrimental in the wrong hands.
Awareness is key. It's better to inform users what the implications of giving away your cookies are rather than broadly claim that it's not a big deal.


Fix failing spec on expire_after_seconds index option.

Mongoid mappings where changed in this commit: https://github.com/mongodb/mongoid/commit/2a4ad4f6 So I reflected those changes to mongoid-rspec

Added fix for failing build on ruby 1.9.3. It seems that travis CI is using outdated version of bundler. Updating bundler before build helps to solve this issue


bintray.com/rabbitmq/rpm/erlang is going away

Moved to bintray.com/rabbitmq-erlang/rpm/erlang.
Closes #220.

Something's not right w/ the existing Pipfile it seems, I'll try to sort this out.

Moving this work to, https://github.com/sensu/sensu-ansible/pull/222 for me to poke at the Travis failures.


"Măeriște" , "Criștelec" , "Giurtelecu Șimleului" , "Mălădia" , "Uileacu Șimleului" are listed in the drop-down menu

Description:
The villages are listed in the drop-down menu alongside its corresponding county and city, according to the law
Preconditions:  the  website is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Măeriște"

Expected results
The location appears in the drop-down menu as "Sat Măeriște, SĂLAJ (Măeriște)"

Step 2
Write in the search bar "Criștelec"

Expected results
The location appears in the drop-down menu as "Sat Criștelec, SĂLAJ (Măeriște)"

Step 3
Write in the search bar "Giurtelecu Șimleului"

Expected results
The location appears in the drop-down menu as "Sat Giurtelecu Șimleului, SĂLAJ (Măeriște)"

Step 4
Write in the search bar "Mălădia"

Expected results
The location appears in the drop-down menu as "Sat Mălădia, SĂLAJ (Măeriște)"

Step 5
Write in the search bar "Uileacu Șimleului"

Expected results
The location appears in the drop-down menu as "Sat Uileacu Șimleului, SĂLAJ (Măeriște)"

Step 6
Write in the search bar "Doh"

Expected results
The location appears in the drop-down menu as "Sat Doh, SĂLAJ (Măeriște)"


Support to upload avatar image with more formats (.bmp, .jpg, .tiff, etc.) instead of .png only

@WindSpiritSR @sh1luo @oranges-eating

@hsluoyz Seems to have been resolved.

Hi @hsluoyz Can I work on this issue as a contributor?

@prsndp sure!

Already done.


onAfterTransition is fired before transition is completed

According to the documentation:

onAfterTransition - fired after any transition

However, when I fire a new transition inside my implementation of onAfterTransition, I get the following error:

transition is invalid while previous transition is still in progress

Is this the expected behaviour? If so, how can I catch a transition AFTER it completes, so I can fire new transitions?

You need to fire the new transition in a setTimeout();
Take a look at #143.

Not really. As I explained in #143, it's pretty standard for any event-driven system to have to back out of the event loop before you can fire another event.  The timeout achieves this.

@rickbsgu Okay, but here's my perspective, for what it's worth:

If onAfterTransition is fired after the transition concludes, why does it block transitions within it as if the transition is still happening? The way the lib works right now, there appears to be no difference between onTransition and onAfterTransition.
If this timeout method is an accepted and encouraged solution to the problem, why isn't it implemented in some way on the lib's side?

After- and Before- transitions are events, not the transition itself.  Events have to be handled as events.  How would it be solved on the lib side?  If it sent an event in a timeout loop what event should it fire?  It doesn't know, only you know that.  If you received an event from a timeout, you're still in an event when you want to fire a new one, so you're stuck with the same situation.
If you've ever done any Windows or other event-based programming, you still run into the same situation - you have to back out to the event loop before you can fire another event (usually...)

@rickbsgu The first paragraph is not really making sense to me, sorry...
Let me try to clarify my question again:

I declare a state machine with three states: A, B and C and two transitions AtoB and BtoC;
A is the initial state;
I implement the onAfterTransition method to fire the BtoC transition;
I fire the AtoB transition, changing the current state from A to B;
onAfterTransition is called, tries to fire the BtoC transition, but fails, because the AtoB transition isn't complete yet.

The problem here, from my point of view, is that the onAfterTransition method should be called when the AtoB transition is completed, according to the documentation. It shouldn't, therefore, have any problems firing a new transition, ie. BtoC, since the previous one is completed.
If this isn't the case, and onAfterTransition is called before AtoB is completed, what's the point of having both onTransition and onAfterTransition?
Also, if the fix is to wrap the BtoC transition call in a timeout event, why isn't this wrapping being done by the lib, if the transition AtoB is complete?

@anticore totally agree. onAFTERtransition sounds like transition is completed already but in a fact it's not.

@anticore totally agree. onAFTERtransition sounds like transition is completed already but in a fact it's not.


Add feature to 'not' set the external.table.purge when converting from legacy managed to external.

Added option -np|--no-purge.  This will remove the external.table.purge=true from the target tables.


Do not show Created on DetailsPane when there's no timestamp.

Signed-off-by: Juho Heikka<EMAIL_ADDRESS>It would show <unknown> ago if creationTimestamp was missing.

Might need to update some snapshots but we will see

Oh yeah looks like. it

Might need to update some snapshots but we will see

Updated snapshots.


Fixed #484

Problem:
Transaction level should be per thread not per Database class.
Solution:

Using ThreadLocal to manage transactionLevel.

This issue was easily reproducible with simple P2P sample app.


Use g.Expect instead of gomega.Expect on gomega.Eventually.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Use g.Expect instead of gomega.Expect on gomega.Eventually.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/cc @mimowo


cannot re-use a name that is still in use

Output of helm version:3.0.3
Output of kubectl version:Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:30:10Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:22:30Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
platform rke
helm install rancher rancher-latest/rancher   --namespace cattle-system   --set hostname=rancher.comune.intranet
error  cannot re-use a name that is still in use

In the namespace cattle-system there is an existing application named rancher. Helm is protecting you from installing two applications with the same name in the same namespace. If you fun helm ls --namespace cattle-system you should see an existing application with the name rancher already there.
You can use a different name, different namespace, or if the application named rancher should not longer be there you can delete it. Unless you meant to upgrade the application rather than install a new one.

helm ls --namespace cattle-system
NAME   	NAMESPACE    	REVISION	UPDATED                                STATUS	CHART        	APP VERSION
rancher	cattle-system	1       	2020-02-05 10:10:23.144025441 +0100 CETfailed	rancher-2.3.5	v2.3.5

it seems be ok now. I reinstalled the package

Just wanted to comment on what I did. I just ended up deleting the namespace and trying again

helm ls --all-namespaces
kubectl delete namespace cattle-system
kubectl create namespace cattle-system
helm install rancher rancher-latest/rancher --namespace cattle-system --set hostname=rancher.DOMAIN --set ingress.tls.source=letsEncrypt --set letsEncrypt.email=EMAIL

for Helm 3 we need to add the namespace for deletion:
helm delete -n my-namespace my-release

for Helm 3 we need to add the namespace for deletion:
helm delete -n my-namespace my-release

@sven5  saved the day, thanks


Update CONTRIBUTORS.md

Motivation
hi! Not sure if this counts 😆 , but I opened a few issues a while back: https://github.com/ProjectOpenSea/seaport/issues?q=is%3Aissue+author%3A%40me+is%3Aclosed
Cheers

LOL


Timeline: images preview isn't working when timeline post is shown on separate page

Example: https://una.io/page/timeline-item?id=954
Discussion: https://una.io/page/view-discussion?id=452

Repost doesn't work on View Post page too.


Adding support for setting the device id at runtime.

The device id is set per-thread. There is still work to be done in order to make this seamlessly work with withDevice() and multiple threads. The state should be essentially cloned when a new thread is started.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@rxwei , would be great to get your feedback on swift code as usual.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow


Add acknowledgements

Hi @StRigaud,
I'm proposing to add a section acknowledgements to the readme. Feel free to expand the text to also acknowledge other funding sources.
Thanks!
Best,
Robert

Done :)


Missing flow typing in reducers

Hi,
I am using flow throughout my whole application, including reducers, actions etc.
I'd like to use the defined types from redux-forms as well. But in the docs I can only find information about Props, nothing about the store.
I tried finding clues in the code, but it doesnt seem to exist there either.
Is this planned for the near feature? I would love to know =)

@wouter-willems What flow types are you missing? What is your version?

This is outdated, but thank you for the reply!


To-do: Solve symbols for every file used by the target methods

Right now, the UnsolvedSymbolVisitor generates synthetic classes solely for files specified in the "--targetFiles" arguments. So if a file is not specified in the "--targetFiles" arguments, even if that file is used by the target methods, UnsolvedSymboVisitor will not create any synthetic classes for unsolved symbols in that file. Consider these two files, Foo.java and Baz.java:
Baz.java:
package com.example;
import com.mypackage.ToolA;

public class Baz {
    public static ToolA getTool() {
        return new ToolA();
    }
}

Foo.java:
package com.example;

class Foo {
    void bar() {
        Baz.getTool();
    }
}

If the target file specified is Foo.java and the target method is com.example.Foo#bar(), then UnsolvedSymbolVisitor will not create any synthetic file for class ToolA, since ToolA is an unsolved symbol in Baz.java, which is not specified as a target file. And we will get an UnsolvedSymbolException when we try to resolve the return type of Baz.getTool() during the phase of TargetMethodFinderVisitor.

The tricky part of this issue is that it is difficult to figure out which files are used by the target methods if the corresponding symbols are not solved. This is one of the limitations of JavaParser. Another solution is simply to add all files existing in the codebase to UnsolvedSymbolVisitor, instead of just the files specified in the "--targetFiles" arguments.


Incorrect route generation when using layout folder

Describe the bug
When using a _layout folder with index.tsx, a route with path '/' instead of id is generated, causing the application to crash with the error "Invariant failed: Duplicate routes found with id: /".
Tested on versions 1.45.0 & 1.44.0

Your Example Website or App
https://stackblitz.com/edit/github-kksgcv
Steps to Reproduce the Bug or Issue

npm run dev

Expected behavior
Expected to generate a layout route with id instead of path
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Firefox
Version: 129.0b2

Additional context
No response

Since pathless/layout routes have no effect on the generated URL, this would evaluate at runtime where you have two index routes.
So this is what happens when you have it as such.

File
Generated URL

src/routes/index.tsx
/

src/routes/_layout/index.tsx
/

If you want the index to share the same layout contents as you have defined in src/routes/_layout.tsx, then you need to delete the src/routes/index.tsx file and only retain the src/routes/_layout/index.tsx one.
You may want to read up on the Routing Concepts guide: https://tanstack.com/router/latest/docs/framework/react/guide/routing-concepts


Agent lock functionality?

Would it be possible to use the API to add the ability to lock agents, similiar to Recon Bolt? Just curious.

Hey!
Yes. Valorant provides an API for selecting and then locking agents early.
This isn't a feature implemented into Valorant Companion for two reasons;

Agent-locking is a highly detectable feature and Valorant Companion aims to be as invisible to Riot Games as possible and at the same time providing as many features as possible.
Valorant Companion aims to be helpful but also non-disruptive. We want players to be able to have certain information but don't want them to be able to "cheat". Locking agents with inhumane speed just isn't fair in a gameplay perspective.

Following API-steps are required to achieve Recon Bolt's functionality:

Selecting a character: https://glz-{region}-1.{shard}.a.pvp.net/pregame/v1/matches/{matchId}/select/{agentId}
Then locking the character: https://glz-{region}-1.{shard}.a.pvp.net/pregame/v1/matches/{matchId}/lock/{agentId}

Please overthink using tools like Recon Bolt. Not just is there a high chance of you losing all your skins, but also is it disruptive against players without such tools.


Preserve comments for schema.sql

WHAT

Preserve comments for schema.sql

when execute migrations to DB, wrench should strip comments in the schema file.
when load schema from DB, wrench should preserve comments and then apply comments to the schema file.

WHY

would like to write comments to the schema file although Spanner does not recognize comments.

Can we expect any improvement with this issue in the near future?
We have lots of problems with documenting our migration SQLs in separate files. It would be much nicer to keep comments in the SQL scripts but currently wrench doesn't support them.
If this issue won't be solved, I would propose a different idea. I would also strip the comments but not with regexps. I don't think this approach is reliable enough. I would rather parse the input rune-by-rune and switch between string, comment and normal mode according to the subsequent characters.
Can I start working on it?


Dry run queries fail with 404:Not found job

While using the library to execute a query in dry run mode, I got an error like the following: 404 GET https://bigquery.googleapis.com/bigquery/v2/projects/MYDATASET/queries/None?maxResults=0&location=US: Not found: Job MYDATASET:US.None
The code I used to execute the query is:
from pybigquery.api import ApiClient

credentials_info = {
  "type": "...",
  "project_id": "...",
  "private_key_id": "...",
  "private_key": "...",
  "client_email": "...",
  "client_id": "...",
  "auth_uri": "...",
  "token_uri": "...",
  "auth_provider_x509_cert_url": "...",
  "client_x509_cert_url": "..."
}

engine = create_engine('bigquery:///MYDATASET?dry_run=true', credentials_info=credentials_info)
query = 'SELECT column1 FROM `myschema`.`mytable` LIMIT 1'

try:
    with engine.connect() as conn:
      results = conn.execute(query)

When I execute the query with an engine that does not specify the dry run (e.g. engine = create_engine('bigquery:///MYDATASET', credentials_info=credentials_info)), the results are returned correctly.
Am I missing some parameters or special configuration for dry run queries?

Is your goal just to check query syntax with this dry run configuration? Would you expect conn.execute to return an empty list?
I suspect this is an issue with the underlying DB-API.
from google.cloud import bigquery
from google.cloud.bigquery import dbapi

query_config = bigquery.QueryJobConfig(dry_run=True)
client = bigquery.Client(default_query_job_config=query_config)
conn = dbapi.connect(client=client)
cur = conn.cursor()

# This line fails with "404 job not found" when in dry_run mode.
cur.execute(
    """
    SELECT country_name
    FROM `bigquery-public-data.utility_us.country_code_iso`
    WHERE country_name LIKE 'U%'
    """
)

results = cur.fetchall()
print(results)

Fails with:
$ python try_dbapi.py
Traceback (most recent call last):
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/cloud/bigquery/dbapi/cursor.py", line 175, in execute
    self._query_job.result()
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/cloud/bigquery/job.py", line 3210, in result
    timeout=timeout,
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/cloud/bigquery/client.py", line 1287, in _get_query_results
    retry, method="GET", path=path, query_params=extra_params, timeout=timeout
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/cloud/bigquery/client.py", line 556, in _call_api
    return call()
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/api_core/retry.py", line 286, in retry_wrapped_func
    on_error=on_error,
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/api_core/retry.py", line 184, in retry_target
    return target()
  File "/Users/swast/miniconda3/envs/scratch/lib/python3.7/site-packages/google/cloud/_http.py", line 423, in api_request
    raise exceptions.from_http_response(response)
google.api_core.exceptions.NotFound: 404 GET https://bigquery.googleapis.com/bigquery/v2/projects/swast-scratch/queries/None?maxResults=0&location=US: Not found: Job swast-scratch:US.None

@diego-serrano-glean Would you mind filing a feature request over at https://github.com/googleapis/python-bigquery/issues ?

My goal is to check query syntax, and optionally get some stats, namely show the total bytes processed.  Is that something I can do with pybigquery?
The issue was filed at https://github.com/googleapis/python-bigquery/issues/118

I'm not aware of anywhere that pybigquery exposes the job stats such as total bytes processed. Is that something you've seen in other SQLAlchemy connectors?

Checking the syntax would be enough.  Is that available in pybigquery?

The underlying DB-API throws an exception on bad syntax. The same is true of pybigquery.

Closing, as I believe this has been fixed by the change to google-cloud-bigquery.


Mark splash test flaky until proved stable.

Mark splash test flaky until proved stable.

feel free to land on red without waiting for tests, since this will fix the redness


Add 'jaxrs20' profile to the testsuite to run integration tests in ja…

…xrs 2.0 mode

@kanovotn can you have a look at the testsuite regression please?

@asoldano issue is fixed.


About the Google Colab

even this is free, it also has a capacity in which it reaches the limit you no longer use the GPU, and you'll just have to use another account :D

Yes but that's just what happens when you use free stuff. Also, if you reach the limit, usually the next day you can use it again.


Add aes_ocb cipher to default provider

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

ping
This old PR has been rebased and updated (based on other cipher implementations).

You haven't declared the internal arrays properly...
clang  -I. -Icrypto/include -Iinclude -Iproviders/common/include -Iproviders/default/include -Iproviders/common/ciphers -Icrypto -Iproviders/common/macs -Iproviders/common/kdfs -Iproviders/default/macs -Iproviders/default/ciphers -Iproviders/default/kdfs  -fPIC -arch x86_64 -O3 -Wall -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmissing-prototypes -Wstrict-prototypes -Wno-unknown-warning-option -Wswitch-default -Wno-parentheses-equality -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Wincompatible-pointer-types-discards-qualifiers -Wmissing-variable-declarations -DL_ENDIAN -DOPENSSL_PIC -DOPENSSLDIR="\"/usr/local/ssl\"" -DENGINESDIR="\"/usr/local/lib/engines-3\"" -DMODULESDIR="\"/usr/local/lib/ossl-modules\"" -D_REENTRANT -DNDEBUG -D_DEFAULT_SOURCE -ansi  -c -o providers/default/ciphers/libcrypto-lib-cipher_aes_ocb.o providers/default/ciphers/cipher_aes_ocb.c
providers/default/ciphers/cipher_aes_ocb.c:487:1: error: no previous extern declaration for non-static variable 'aes256ocb_functions' [-Werror,-Wmissing-variable-declarations]
IMPLEMENT_cipher(ocb, OCB, AES_OCB_FLAGS, 256, 128, OCB_DEFAULT_IV_LEN * 8);
^
providers/default/ciphers/cipher_aes_ocb.c:462:25: note: expanded from macro 'IMPLEMENT_cipher'
    const OSSL_DISPATCH aes##kbits##mode##_functions[] = {                     \
                        ^
<scratch space>:36:1: note: expanded from here
aes256ocb_functions
^
providers/default/ciphers/cipher_aes_ocb.c:488:1: error: no previous extern declaration for non-static variable 'aes192ocb_functions' [-Werror,-Wmissing-variable-declarations]
IMPLEMENT_cipher(ocb, OCB, AES_OCB_FLAGS, 192, 128, OCB_DEFAULT_IV_LEN * 8);
^
providers/default/ciphers/cipher_aes_ocb.c:462:25: note: expanded from macro 'IMPLEMENT_cipher'
    const OSSL_DISPATCH aes##kbits##mode##_functions[] = {                     \
                        ^
<scratch space>:85:1: note: expanded from here
aes192ocb_functions
^
providers/default/ciphers/cipher_aes_ocb.c:489:1: error: no previous extern declaration for non-static variable 'aes128ocb_functions' [-Werror,-Wmissing-variable-declarations]
IMPLEMENT_cipher(ocb, OCB, AES_OCB_FLAGS, 128, 128, OCB_DEFAULT_IV_LEN * 8);
^
providers/default/ciphers/cipher_aes_ocb.c:462:25: note: expanded from macro 'IMPLEMENT_cipher'
    const OSSL_DISPATCH aes##kbits##mode##_functions[] = {                     \
                        ^
<scratch space>:134:1: note: expanded from here
aes128ocb_functions
^
3 errors generated.

You haven't declared the internal arrays properly...

Yes I have - it was missing a include for the declaration of the functions

it was missing a include for the declaration of the functions

Ah ok

Thanks. Merged to master.


NATIVE-53: Fix flow for connect()

The fix was quite easy. Probably you forgot to push some flow types which cause these problems

Also make sure that there is only one flow types file for react-i18next. I think there are currently two.

@maxammann Thanks!


Multisig on multiple servers

here: https://github.com/Bit-Wasp/bitcoin-php/blob/master/examples/tx.spend.p2sh.multisig.php The problem is, that I need to pass the signature from one server to another, because I won't have all private keys on one single server. So this:
// several calls to sign are necessary this time
$input->sign($privKey1);
$input->sign($privKey2);

Needs to be done on 2 servers in 2 different requests. I thought of serializing after the first sign, sending it to another server and sign it there again. But how should the code look like? I did not find anything yet how to do it. Thanks for your help in advance

I thought of serializing after the first sign, sending it to another server and sign it there again.

That's exactly it! Check out the examples for decoding a tx from hex. You'll need to pass around the scripts and stuff too :)


Prettier stops working when installing the plugin

Describe the bug
When installing the plugin, Prettier stops working. It had never happened to me before, today I decided to create a NextJS project and when I added prettier next to the plugin, the code formatting stopped working completely.
To Reproduce
Steps to reproduce the behaviour:

Install Prettier
Install prettier-plugin-tailwind
Press CTRL + S and format on save doesn't work

Expected behaviour
I expect to "format" the code on save, but this doesn't work. I already tested in other projects and works just fine.
Versions:

prettier-plugin-tailwind version: 2.2.10
Operating system: Ubuntu 20.04
NPM/Yarn version: Yarn v1.22.10

Its likely due to the new utilities introduced in https://github.com/tailwindlabs/tailwindcss/releases/tag/v2.1.0

See https://github.com/Acidic9/tailwind-classes-sorter/issues/4
A fix is to disable JIT for formatting, by changing the tailwind.config.js:
module.exports = {
  // This "hack" ensures your IDE detects all normal Tailwind classes, while JIT is used when compiling the project.
  // All the normal Tailwind classes should show up in code completion. It can't show all the new classes generated by JIT.
  mode: process.env.NODE_ENV ? 'jit' : undefined,
};

For the Googlers out there:

✖ prettier -w -u:
/project-path/node_modules/tailwindcss/lib/plugins/backdropBlur.js:26
      matchUtilities({
      ^

TypeError: matchUtilities is not a function
    at /project-path/node_modules/tailwindcss/lib/plugins/backdropBlur.js:26:7
    at /project-path/node_modules/tailwindcss/lib/util/processPlugins.js:69:5
    at Array.forEach (<anonymous>)
    at TWClassesSorter._default [as processPlugins] (/project-path/node_modules/tailwindcss/lib/util/processPlugins.js:63:11)
    at /project-path/node_modules/tailwind-classes-sorter/lib/index.js:179:52
    at Array.forEach (<anonymous>)
    at TWClassesSorter.getAllSelectors (/project-path/node_modules/tailwind-classes-sorter/lib/index.js:167:14)
    at new TWClassesSorter (/project-path/node_modules/tailwind-classes-sorter/lib/index.js:47:37)
    at Object.<anonymous> (/project-path/node_modules/prettier-plugin-tailwind/lib/index.js:10:25)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)

If you experience this symptom, take the above medicine. (mode: process.env.NODE_ENV ? 'jit' : undefined)

This fix doesn't work in a number of scenarios, especially when using eslint with prettier either via cli or vscode extension. The matchUtilities is not a function error is triggered in both places.

I'd recommend switching to https://github.com/francoismassart/eslint-plugin-tailwindcss with --fix to handle the sorting.
It handles jit mode perfectly.
To keep IDE code completion working with, I still include the NODE_ENV toggle above, but set jit on Tailwind inside .eslintrc.js:
const tailwindConfig = require('./tailwind.config');
tailwindConfig.mode = 'jit';

module.exports = {
  // Rest of config is omitted
  rules: {
    'tailwindcss/classnames-order': 'warn',
    'tailwindcss/no-custom-classname': 'warn',
    'tailwindcss/no-contradicting-classname': 'error',
  }
  settings: {
    tailwindcss: {
      config: tailwindConfig,
      whitelist: customTailwindClasses,
    },
  },
}

Thanks, I did give that eslint-plugin-tailwindcss a go this morning but it's very slow and I have a post-commit hook to run the linter and it added about 30 seconds to my commit times on a not-yet-huge project so was a no go.

Having this same issue. Just disabled jit mode for now as this was in a relatively small and new toy project as well, but obviously down the line it'd be nice to have this plugin and tailwind jit working nicely together.
Anything we can do to help?


FIX: The toggle button in the Calendar web app is not visible properly.

Describe the bug
The toggle button in the Calendar web app is not visible properly .It needs some adjustments.
Expected behavior
The toggle button should be clearly visible.
Screenshots (Mandatory)

Additional context (Mandatory )
I am going to rectify the problem with the help of CSS.
Kindly assign me for this issue.
Thank you.
Are you contributing under any open-source program ?

Yes under KWOC.

@Abhishek-465 Please don't raise more than 2 issues at a time.
I have already assigned u 2 issues. Try to work on those.
After the completion of those PR's I will assign you this.

Ok Thank you @apu52 i am working on the other issues and after completion kindly assign me this one.

@Abhishek-465 I have assigned you now!!
You can work on this issue


Add option to getTables

Add a getTables command that will produce a json file in the same structure as the existing getTables request in db-extractor-oracle.
Timeouts will be ancient history

closed by #60


Problems switching layers and it doesn't show up in debug mode

Hi)

ArchLinux
kernel version: 5.16.16-arch1-1
keyd version: 2.3.1.rc.r11.845495a-1
Microsoft Ergonomic Keyboard

Yesterday I updated to the latest version from the repository and now switching to alt_vim layer doesn't work.
I tried to debug this, but in debug mode the information about switching layers is no longer displayed.
In version 2.2.7.beta.r0.dac9d69-1 everything works. After no longer.
Config:
# Microsoft Ergonomic Keyboard (LXM-00001)
[ids]
045e:082c

[main]

rightalt = layer(ralt)
leftalt = layer(lalt)

rightshift = layer(rshift)
leftshift = layer(lshift)

rightcontrol = layer(rcontrol)
leftcontrol = layer(lcontrol)

#left = esc
#right = esc
#up = esc
#down = esc

[rshift:S]

[lshift:S]

[lcontrol:C]
leftshift = swap(lcontrol_lshift)
rightshift = layer(rshift)

[rcontrol:C]

[lcontrol_lshift:C-S]
leftalt = swap(lcontrol_lshift_lalt)
rightalt = layer(ralt)

[lcontrol_lshift_lalt:C-S-A]
leftmeta = swap(fakemeta)

[fakemeta:M]
rightalt = layer(ralt)
rightshift = layer(rshift)
rightcontrol = layer(rcontrol)

[ralt:G]
leftalt = layer(alt_vim)
#leftalt = swap(alt_vim)

[lalt:A]
rightalt = layer(alt_vim)
#rightalt = swap(alt_vim)

[alt_vim]
control = layer(alt_vim_control)
shift = layer(alt_vim_shift)
meta = layer(alt_vim_meta)

h = left
j = down
k = up
l = right
w = C-right
b = C-left

x = delete
0 = home

/ = C-f

[alt_vim_control:C]
f = pageup
b = pagedown

[alt_vim_shift:S]
4 = end

h = S-left
j = S-down
k = S-up
l = S-right
w = C-S-right
b = C-S-left

[alt_vim_meta:M]

2.3.0-rc was a major release. I recommend reading the changelog (and rereading the man page). From what I can see, your config can be drastically simplified to something like
# Microsoft Ergonomic Keyboard (LXM-00001)
[ids]
045e:082c

[main]

rightalt = layer(ralt)
leftalt = layer(lalt)

rightshift = layer(rshift)
leftshift = layer(lshift)

rightcontrol = layer(rcontrol)
leftcontrol = layer(lcontrol)

#left = esc
#right = esc
#up = esc
#down = esc

[rshift:S]

[lshift:S]

[lcontrol:C]
leftshift = swap(lcontrol_lshift)
rightshift = layer(rshift)

[rcontrol:C]

[lcontrol_lshift:C-S]
leftalt = swap(lcontrol_lshift_lalt)
rightalt = layer(ralt)

[lcontrol_lshift_lalt:C-S-A]
leftmeta = swap(fakemeta)

[fakemeta:M]
rightalt = layer(ralt)
rightshift = layer(rshift)
rightcontrol = layer(rcontrol)

[ralt:G]
leftalt = layer(alt_vim)
#leftalt = swap(alt_vim)

[lalt:A]
rightalt = layer(alt_vim)
#rightalt = swap(alt_vim)

[alt_vim]
control = layer(alt_vim_control)
shift = layer(alt_vim_shift)
meta = layer(alt_vim_meta)

h = left
j = down
k = up
l = right
w = C-right
b = C-left

x = delete
0 = home

/ = C-f

[alt_vim_control:C]
f = pageup
b = pagedown

[alt_vim_shift:S]
4 = end

h = S-left
j = S-down
k = S-up
l = S-right
w = C-S-right
b = C-S-left

See in particular the new section on 'composite layers'.

Thanks!
Man page link from readme is dead.
https://github.com/rvaiya/keyd/blob/v2.3.0-rc/man.md

Thanks for letting me know. I'm closing this for know, but feel free to open another issue if you have problems.


Fix T1 site cores ResourceControl logic

Fixes #12121
Status
not-tested
Description
Given that Tier0 configuration sets this value <=100% (e.g. 12.5), the integer division would always return 0, hence not changing any of the default thresholds.
With the current change, we can now properly calculate a percentage of the site slots (e.g. 1250 for CNAF).
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
It has to go together with this T0 PR: https://github.com/dmwm/T0/pull/5007
External dependencies / deployment changes
None

Sorry Alan, I fail to catch the rationale for this change.
Could you provide some example values for infoSSB[site]['slotsCPU'] before being updatesd and self.t1SitesCores ? is self.t1SitesCores set to an integer in the range [0, 100] and nobody noticed before that self.t1SitesCores // 100 always return 0? Which value should be <= 100%?

To be on the safe side, I am now casting the result to an integer.
Dario, no problem! Yes, the problem is that that division always return 0. I expected the multiplication to take precedence in that expression, but it looks like division goes first, bringing the result to 0, see:
>>> slotsCPU * t1SitesCores // 100
1250.0
>>> slotsCPU * (t1SitesCores // 100)
0.0

So I could actually have kept the integer division and simply enforce the precedence (plus casting, to be on the safe side, given that resource slots are integer).

Antonio and I worked on vocms0502 resource control operational issues, and we ended up applying this patch to the agent.
Now T1 thresholds are looking Okay. With that, I am proceeding with the merge of this PR.


enable display  of spaces

Issue Type: Feature Request
would be nice if we can have the feature for any source file to show the invisible space characters so that formatting can be easy.
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.17763

This exists already: View: Toggle Render Whitespace.

Thanks a lot @Alex Ross .
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Alex Ross<EMAIL_ADDRESS>Sent: Monday, May 27, 2019 2:38:15 PM
To: microsoft/vscode
Cc: prashanjitghosh; Author
Subject: Re: [microsoft/vscode] enable display of spaces (#74391)
Closed #74391https://github.com/microsoft/vscode/issues/74391.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/74391?email_source=notifications&email_token=AKIQKSNZDR6K2LXUL5JQLUDPXOQH7A5CNFSM4HPZZLB2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORUYRD4A#event-2368803312, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKIQKSJZPSKGVVRM6BNPPXTPXOQH7ANCNFSM4HPZZLBQ.


Documentation: make it clearer about the node.js version to use

Hello guys :)
I got an issue while trying to work with the replicate library due to the fact I was running my project with node.js 16 without the nodejs experimental flag
I think it should be cool to add something in the library documentation in order to explain it or maybe update the engines in the package.json to force the end user using node.js version > 18
I can create a PR in order to fix that :)

Hi @Kawacrepe. This is currently documented in the README, under the "Constructor" heading:

The client makes requests to Replicate's API using fetch. By default, the globalThis.fetch function is used, which is available on Node.js 18 and later, as well as Cloudflare Workers, Vercel Edge Functions, and other environments.
On earlier versions of Node.js and other environments where global fetch isn't available, you can install a fetch function from an external package like cross-fetch and pass it to the fetch option in the constructor.

Replicate should work on any supported version of Node provided that there's a fetch function available, so I'm not sure updating the engines for the package would be appropriate.

When using yarn as a package manager, I can't get it to install on node 16.
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.1"
warning<EMAIL_ADDRESS>The engine "git" appears to be invalid.
error Found incompatible module.

Unfortunately, my only real option is to fork the package and change the engines value to allow me to install it.


connlib: investigate packet drops because socket is busy (os error 11)

When running a UDP iperf test, we start seeing "os error 11" IO errors when trying to write to the socket as soon as you up the banwidth above what your actual network link can handle. Additionally, I've seen this error on Android when running a speedtest via https://speedtest.cloudflare.com.
Whilst these packets have to be dropped somewhere, it shouldn't be in our code. Instead, it would be better if a kernel buffer somewhere overflows as those might be tuned / controlled by the user.
So far, my investigation discovered that we seem to get false-positive "write readiness" from the UDP socket. In other words, even though we call poll_send_ready, the socket isn't actually ready to accept data at the moment.
I don't yet know, what a good fix for this is. One idea I had was to buffer the packet if we fail to write it due to OS error 11 and always empty the buffer first before we read more data (or the buffer has a certain size). quinn-udp allows us to write multiple packets at once using GSO, meaning even if we buffer dozens of packets, those could all be written using a single syscall.

Draft PR is here: https://github.com/firezone/firezone/pull/3808


chore: fix typos

Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Fix typos
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[ ] build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
[ ] ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
[x] docs: Documentation-only changes
[ ] feat: A new feature
[ ] fix: A bug fix
[ ] perf: A code change that improves performance
[ ] refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
[ ] style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
[ ] test: Adding missing tests or correcting existing tests

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[x] No, this PR doesn't involve a new deployment, git tag, docker image tag
[ ] Yes

Breaking change label
Does this PR have the breaking-change label?

[x] No, this PR is not a breaking change
[ ] Yes

These are comments generated by geth's abigen.


Did not word for me

I like the idea of this workflow. It could be very useful and appreciate your efforts, but unfortunately it
did not work for Alfred 3.6.1 ( May 12, 2018).
I have unchecked gmail from Web search tab.
When I type "gmail and hit enter, it gives inbox, sent, etc."   but if i enter them it leads to the browser.

Also, How to add gmail api to keychain, do we have to do this or the workflow ask us to do this?
It did not ask, just shows inbox,sent,junk, etc folder names.

I have the same issue here.

I'm having this issue as well. I thought it was Alfred 4, but it does this.
I even erased the config folder in ~/Library for gmail-alfred but it didn't ask me to login again


Extension request: NGChat Extension

[ ] Extension name: NGChat Extension
[ ] Extension GitHub or homepage: https://marketplace.visualstudio.com/items?itemName=SeasaltAI.vscode-ngchat

There's no available source code for it, I don't think we'll be able to import this.


The super-resolution effect of subtitles or text in video is poor

Recently, we use real-basicvsr network to restore many videos with subtitles. For some subtitles or text in the video, the effect of super resolution is poor.
I would like to ask if your team has encountered such problems in the process of research.


Parsing Binary Numbers Fails

I can't get the sample code from the slides to parse correctly. This means Goblint can't even start to analyze it.
#include <assert.h>
#include <stdlib.h>

#define ANY_ERROR 0b0101  // 5
int main() {
  int state;
  int r = rand() % 3;  // {r 7→ [0; 2],state 7→ [MIN INT; MAX INT]}
  switch (r) {
    case 0:
      state = 0b0000; /* 0 */
      break;
    case 1:
      state = 0b1000; /* 8 */
      break;
    default:
      state = 0b1010; /* 10 */
      break;
  }
  // {r 7→ [0; 2],state 7→ [0; 10]}
  assert((state & ANY_ERROR) == 0);
}

I think it's caused by https://github.com/BinaryAnalysisPlatform/FrontC not being able to parse the binary numbers (0b0000, 0b1000, 0b1010).
FIX: For now, it's fine to just rewrite all the binary numbers into their decimal form. But someone should look into this theory and maybe try to fix it

Problem is for sure the FrontC library, it does not support parsing by 0b prefix as it is not part of any c standard, just an addon in gcc and clang, so I dont know if this is something we can or should implement in goblint or anytwhere else...


Moved from dep to go modules

close #149

I couldn't found semaphoreci integration config...

I couldn't found semaphoreci integration config...

Just did it myself just now cuz of the build failure. Thanks.


[Bug]: nsys cannot track the cuda kernel called by the process except rank 0

Your current environment
PyTorch version: 2.2.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.2 LTS (x86_64)
GCC version: (Ubuntu 11.3.0-1ubuntu1~22.04.1) 11.3.0
Clang version: Could not collect
CMake version: version 3.26.4
Libc version: glibc-2.35

Python version: 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0] (64-bit runtime)
Python platform: Linux-5.4.56.bsk.9-amd64-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.1.105
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A100-SXM4-80GB
GPU 1: NVIDIA A100-SXM4-80GB
GPU 2: NVIDIA A100-SXM4-80GB
GPU 3: NVIDIA A100-SXM4-80GB
GPU 4: NVIDIA A100-SXM4-80GB
GPU 5: NVIDIA A100-SXM4-80GB
GPU 6: NVIDIA A100-SXM4-80GB
GPU 7: NVIDIA A100-SXM4-80GB

Nvidia driver version: 535.129.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.3
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.3
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 57 bits virtual
Byte Order:                      Little Endian
CPU(s):                          128
On-line CPU(s) list:             0-127
Vendor ID:                       GenuineIntel
BIOS Vendor ID:                  Intel(R) Corporation
Model name:                      Intel(R) Xeon(R) Platinum 8336C CPU @ 2.30GHz
BIOS Model name:                 Intel(R) Xeon(R) Platinum 8336C CPU @ 2.30GHz
CPU family:                      6
Model:                           106
Thread(s) per core:              2
Core(s) per socket:              32
Socket(s):                       2
Stepping:                        6
CPU max MHz:                     3500.0000
CPU min MHz:                     800.0000
BogoMIPS:                        4600.00
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 invpcid_single ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local wbnoinvd dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid md_clear pconfig flush_l1d arch_capabilities
Virtualization:                  VT-x
L1d cache:                       3 MiB (64 instances)
L1i cache:                       2 MiB (64 instances)
L2 cache:                        80 MiB (64 instances)
L3 cache:                        108 MiB (2 instances)
NUMA node(s):                    2
NUMA node0 CPU(s):               0-31,64-95
NUMA node1 CPU(s):               32-63,96-127
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Enhanced IBRS, IBPB conditional, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected

Versions of relevant libraries:
[pip3] numpy==1.22.2
[pip3] onnx==1.14.0
[pip3] pytorch-quantization==2.1.2
[pip3] torch==2.2.1
[pip3] torch-tensorrt==1.5.0.dev0
[pip3] torchdata==0.7.0a0
[pip3] torchtext==0.16.0a0
[pip3] torchvision==0.16.0a0
[pip3] triton==2.2.0
[conda] Could not collectROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.0.post1
vLLM Build Flags:
CUDA Archs: 5.2 6.0 6.1 7.0 7.5 8.0 8.6 9.0+PTX; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    GPU6    GPU7    NIC0    NIC1    NIC2    NIC3    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      NV12    NV12    NV12    NV12    NV12    NV12    NV12    PXB     SYS     SYS     SYS     0-31,64-95      0             N/A
GPU1    NV12     X      NV12    NV12    NV12    NV12    NV12    NV12    PXB     SYS     SYS     SYS     0-31,64-95      0             N/A
GPU2    NV12    NV12     X      NV12    NV12    NV12    NV12    NV12    SYS     PXB     SYS     SYS     0-31,64-95      0             N/A
GPU3    NV12    NV12    NV12     X      NV12    NV12    NV12    NV12    SYS     PXB     SYS     SYS     0-31,64-95      0             N/A
GPU4    NV12    NV12    NV12    NV12     X      NV12    NV12    NV12    SYS     SYS     PXB     SYS     32-63,96-127    1             N/A
GPU5    NV12    NV12    NV12    NV12    NV12     X      NV12    NV12    SYS     SYS     PXB     SYS     32-63,96-127    1             N/A
GPU6    NV12    NV12    NV12    NV12    NV12    NV12     X      NV12    SYS     SYS     SYS     PXB     32-63,96-127    1             N/A
GPU7    NV12    NV12    NV12    NV12    NV12    NV12    NV12     X      SYS     SYS     SYS     PXB     32-63,96-127    1             N/A
NIC0    PXB     PXB     SYS     SYS     SYS     SYS     SYS     SYS      X      SYS     SYS     SYS
NIC1    SYS     SYS     PXB     PXB     SYS     SYS     SYS     SYS     SYS      X      SYS     SYS
NIC2    SYS     SYS     SYS     SYS     PXB     PXB     SYS     SYS     SYS     SYS      X      SYS
NIC3    SYS     SYS     SYS     SYS     SYS     SYS     PXB     PXB     SYS     SYS     SYS      X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

NIC Legend:

  NIC0: mlx5_0
  NIC1: mlx5_1
  NIC2: mlx5_2
  NIC3: mlx5_3

🐛 Describe the bug
I try to profile vllm with nsys and run mixtral inference with tp_size = 8. When I opened the generated req file with nsys gui, I found that except for the rank 0 process, other processes did not capture the cuda kernel call, that is, there was no cuda hw line. This is the screenshot of nsys gui.

Below are nsys command and python script.
# nsys cmd
nsys profile -t cuda,nvtx  --sample=none  --cpuctxsw=none -o org_tp  python3 offline_inference.py

# sample code for this problem, offline_inference.py
from vllm import LLM, SamplingParams

prompt_token_ids = [
                    [100 for i in range(8 * 1024)], # 8k
                    [100 for i in range(8 * 1024)], # 8k
                    [100 for i in range(8 * 1024)], # 8k
                    [100 for i in range(8 * 1024)], # 8k
                    [100 for i in range(32 * 1024)] # 32k
                   ]
# Create a sampling params object.
sampling_params = SamplingParams(temperature=0.8, top_p=0.95, max_tokens=2)

# Create an LLM.
llm = LLM(model="mistralai/Mixtral-8X7B-Instruct-v0.1",
          tensor_parallel_size = 8,
          disable_log_stats=False,
          enforce_eager=True)

# Generate texts from the prompts. The output is a list of RequestOutput objects
outputs = llm.generate(prompt_token_ids=prompt_token_ids, sampling_params=sampling_params)

I also try to profile each worker like this : [How ray support Nsight System Profiler] https://docs.ray.io/en/latest/ray-observability/user-guides/profiling.html#nsight-system-profiler 。But it has no effect, still no cuda hw line ，
# in vllm/executor/ray_gpu_executor.py:95
worker = ray.remote(
    num_cpus=0,
    num_gpus=num_gpus,
    scheduling_strategy=scheduling_strategy,
    runtime_env={ "nsight": "default"},
    **ray_remote_kwargs,
)(RayWorkerVllm).remote(self.model_config.trust_remote_code)

This is a problem about ray, which has been solved. The detailed is in https://github.com/ray-project/ray/issues/42139#issuecomment-2141724352


fix(dependencies): upgrading prescribe to fix a bug in script writing

Previously, if a script and its contents were written over several doc.writes it'd write the
contents outside the scripts text node
#172

👍 ✨ 🚀

Coverage remained the same at 89.324% when pulling 25f889c185a67625d502c56fbbb21d1021cbe6c5 on jnewman-upgrade-prescribe into b6dd607e017163f739160920373f60e16e0dcfb9 on master.


Can't launch on Linux

steamworks.js native module error, tested on Ubuntu 18.04 through WSL2

Have resolved this for the time being by not loading steam stuff but this will need addressing when steamworks integration is started properly


Add support for archive assemblies

Initial implementation (allowing an archive assembly to be attached to any mesh object) is done.


chore: removed failing line of deploy-operator make command

Signed-off-by: jamesmilligan<EMAIL_ADDRESS>

This PR

removed failing line of deploy-operator make command

Codecov Report

Merging #193 (ee3836b) into main (2bd953f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #193   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          1       1
  Lines        122     122
=====================================
  Misses       122     122

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Service factory refactor

General overview of the changes:

Removes the components.rs module and almost everything that was in it.
Adds a ServiceBuilder struct.
Removes construct_service_factory!. You are now supposed to define your own functions (eg. new_full and new_light) that create the service using the ServiceBuilder.
Adds a lot of generics to Service and adds an AbstractService trait that you are expected to use in practice when you pass the Service around.

I started with very clean and detailed commits, but since I keep getting conflicts with master, and that rebasing is very painful, I rushed the end a bit more. I'd still recommend to review commit by commit.
All commits up to and including Fix the node-cli tests don't break the API. Only the commits afterwards are breaking changes. I would suggest to merge that PR in two parts: up to that commit, then the rest, so that we can revert "the rest" if the refactoring blocks Polkadot. This is because updating Polkadot will not be trivial, and I don't want to take the blame for delaying Kusama because this PR was merged too eagerly. I opened #3384 with the first part separately.
Remains to be done before merging:
- Restore the sync test of node-cli. This test is the one victim of this refactoring, and I need a bit more time figuring out how to restore it.

As mentioned in the other PR, I can continue piling up changes, but there's an arbitrary point where I have to stop and submit it.

I don't understand why we have all these new macros. We wanted to get rid of the macro and not introduce multiple new ones.

If you're talking about the macros in node, one is an unfortunate consequence of the fact that some of the Substrate tests are using the node. Both macros can probably be removed after more future refactoring.
If you're talking about the macros within substrate-service, they are purely internal and similarly I'm going to remove them in the future.
As mentioned, there are tons of changes to make (including the ones you raised in your review), but I didn't want to have a PR that conflicts with half of Substrate.

Can you maybe at least do the basic review comments that do not touch a macro? If you say to all comments "I don't want to push any other commit", I don't see any reason at all why someone should review this 🤷♂
I understand that you want to get this in relative fast, to reduce the number of conflicts. But then please at least address the obvious stuff, like the RA, RtApi generic arguments, the incorrect named file etc. After that we can merge, if we see the final version in the next pr. I also have some ideas and requirements and don't want to make sure I don't miss something across multiple prs.
Otherwise the service stuff will probably calm down after we have Kusama released.

Should be ready for review/merging. I fixed most of the remarks, and would like to delay the ones that aren't trivial to fix in order to get this in sooner.


Add support for floating point numbers

The number of decimal points shouldn't matter as the values will be rounded to nearest whole integer.

Released with version v1.5.0.


Roll Jenkins JDK 8 changes into ./scripts/jenkins-test

See #989.

What needs to be done here?  I don't see anything JDK related except for the -XX:MaxPermSize=1g maven flag that might be deprecated on JDK8.


Allow SDS NewResponse with no request object

Once we switch to the snapshot cache, we will not be calling SDS NewResponse with a request object.
This PR does not make that switch, but allows the NewResponse function to be called with a nil request object.
This PR also has one other big change, which is to switch from an Inbound Validation secret context for each inbound service, to a single inbound validation context for all services. This makes our secret generation logic much simpler, while simultaneously reducing resource consumption across the fleet.
I've also removed some unnecessary  test cases, particularly those which were exercising already tested paths, and were testing unexported methods. This sticks with the go recommendation to keep unit tests on exported methods, to avoid internal changes breaking tests.

Codecov Report

Merging #5049 (bdf2ad2) into main (765b0c8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:exclamation: Current head bdf2ad2 differs from pull request most recent head ab0e35d. Consider uploading reports for the commit ab0e35d to get more accurate results

@@            Coverage Diff             @@
##             main    #5049      +/-   ##
==========================================
+ Coverage   68.72%   68.76%   +0.03%
==========================================
  Files         216      214       -2
  Lines       16154    16036     -118
==========================================
- Hits        11102    11027      -75
+ Misses       4992     4949      -43
  Partials       60       60

Flag
Coverage Δ

unittests
68.76% <100.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cli/verifier/envoy_config.go
65.12% <100.00%> (-0.39%)
:arrow_down:

pkg/envoy/sds/builder.go
100.00% <100.00%> (+10.47%)
:arrow_up:

pkg/envoy/sds/response.go
90.00% <100.00%> (+4.51%)
:arrow_up:

pkg/envoy/xdsutil.go
95.69% <100.00%> (-0.38%)
:arrow_down:

pkg/ticker/ticker.go
82.66% <0.00%> (-4.00%)
:arrow_down:

pkg/envoy/secrets/secrets.go

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.