Whitespace interpretation

I am not sure I understand the "whitespace rule":

There are no special rules for whitespace. All whitespace characters are captured by the Character rule.

Considering the dog example. In the following fragment:
Conservation status [Domesticated]
Scientific classification [
  Kingdom [Animalia]
  ...

The "Scientific classification" key, according to the rule is actually the string "\nScientific classification " (with a trailing space)  and the key "Kingdom" is actually "\n  Kingdom ", right?
And on Windows where  the end of line is "\r\n", this document would have different key values...
Is it what you intended?
Shouldn't the specification clarify how leading and trailing whitespaces (including newlines) are to be interpreted?
Phil

Hello,
Thanks for the question!
Indeed there are no rules for whitespace -- this is by design.
You point out a good reason why this might be the right choice: operating system differences.
Whitespace is the concern of one level above Jevko, which should ideally be occupied by standardized formats.
One such format, which does not have a spec yet, but is pretty much defined is codenamed Easy Jevko. Here are libraries for working with it in JS and Lua that I wrote (~ v0.1.0):

https://github.com/jevko/easyjevko.js
https://github.com/jevko/easyjevko.lua

This format specifies how to interpret the different parts of Jevko into programming language data structures, such as tables/maps/objects, arrays/lists, and strings. This includes the treatment of whitespace in a sensible way: in your example Scientific classification and Kingdom would be keys in a map and they would be properly trimmed. Notice that this format does that automatically and disallows untrimmed keys entirely (which is a good thing in 99.9% of cases).
This should certainly be clarified somewhere. I'm not sure specification is the right place, but I'll figure something out.
Thanks again for your input!

Thanks for your prompt response. I will have a look at Easy Jevko!

Huh, I forgot about this issue. Found it today and it inspired me to write this: https://github.com/jevko/writing/blob/main/2023-09-08-jevko-whitespace.md
With that I'm closing the issue.


[BUGFIX] Timing/Threading bug in MQTT Provider

Fixed a bug where depending on the timing of operations in different threads, tracking of request/responses for Provider operations could end up in an unexpected state and cause an operation to never complete.

Refactored operations management into a helper class in the Provider

Making this lock-free was a bold choice.  Without a lock, you have to be able tp prove that any possible interleaving of operations is valid and that's not easy.
Here's an interleaving that breaks:
Thread A is calling publish (calls establish_operation)
Thread B is where the PUBACK comes back  (calls complete_operation)
Thread A:
calls PUBLISH
Thread B:
received PUBACK
calls complete_operation
checks the pending queue, this returns False since thread A hasn't added it yet.
<-- thread switch -->
Thread A:
PUBLISH operation returns MID
calls establish_operation
adds MID to pending queue
checks unknown queue, this returns False,
function is done
Thread B:
(continuing where it left off, right after B decided this wasn't in the pending queue)
adds to unknown queue
function is done


Modules aren't properly declared

Describe the bug, including details regarding any error messages, version, and platform.

org.apache.arrow.flight.grpc isn't exported
JDBC driver uses 'flight.sql.jdbc.core' which doesn't match other packages like 'org.apache.arrow.flight.core'

So it seems we can't fix the automatic module name for the JDBC driver since Avatica is packaged in a way that it can't become an automatic module :/

So it seems we can't fix the automatic module name for the JDBC driver since Avatica is packaged in a way that it can't become an automatic module :/

Is it because Avatica is shaded with package name transformed? (It might be a dumb question since I'm still new to JPMS).

I didn't save the error but IIRC it had to do with service providers


feat: (WIP) started conversion of tapable to TypeScript

Still very work in progress. One thing to note, is that TS doesn't support ..args that are not the final parameter. There is an ugly workaround that would have to be considered. https://github.com/Microsoft/TypeScript/issues/7347

not ideal, but the API could change to be Promise-based instead of callback based.
applyPluginsAsyncSeries(name: string, ...args: Array<any>): PromiseLike

That's probably an entire bikeshedding session on its own though...
/ducks out before someone throws a shoe

I mean promises would be really cool is just that it would be a ginourmous breaking change.

promise is good. Breaking change is inevitable when introducing awesome feature in most of time.
As webpack 2 will be incompatible with webpack 1. Introducing breaking change would affect webpack 2 basically

One thing worth mentioned is documentation. Especially, the apply method overlay the built-in one worth documenting why doing this, what this do, how to use it.
As webpack grows so popular, the core concept is one of the most important thing to be clarified, for further improvement.

I agree with you. Most users don't even understand Tapable or the entire webpack internals. It certainly is an opprotunity to fix that through code quality.

Types are on hold at the moment. Would require potentially a design change especially with delegation.


Setting for refresh on save is too vague

...
I also would like to mention that the name "On Changes to Saved Files" is not very clear to me. How about "On saving changes" or something similarly simple?

originally by @konsth191 at https://github.com/microsoft/vscode-livepreview/issues/235

Reviewing this, I believe that something like "On Saving Changes" would be sort of unclear also, since some file watchers just overwrite existing files. Would that count as "Saving Changes?". I still think that "On Changes to Saved Files" is clearer, but let me know if you have extra input on this.

I concur. It is unclear what the “to Saved Files” part is supposed to mean in “On Changes to Saved Files”. Was the intent to distinguish this from “On Changes to Unsaved Files”?
If it means “On save”, then please name it as such.

It's "On Changes to Unsaved Files" because changes might not necessarily be from the user explicitly saving from the editor (eg: filewatchers changing the file can trigger it).

Thank you for this clarification. On my version of VSCode I see “On Changes to Saved Files”. Either way, it is unclear and does not mean “On changes by a human being”.


RFC: Read the Tos of edx

EDX tos is the most abusive one i have ever seen, why are so many courses requiring me to basically waiver any and all of my rights?

I'm sorry to hear that you find edX's terms of service abusive. edX is a platform partnering with many of the world's most respected educational institutions to bring free and low cost educational content to users. We've found that on many topics they offer the best option for learners.
If you feel that edX courses should be replaced, we welcome feedback on specific reasons why (the assertion that the tos is abusive needs to be backed up with concrete examples). As stated in our contributing guidelines, "While it is acceptable to point out problems, all successful changes naturally require a plan for fixing the problem."

@waciumawanjohi In the case of EdX, there may be some real concerns in the near future. This is because, EdX was acquired last week by a private organisation who has sort of announced that EdX will no longer be non-profit.
As per this class-central article,

In an unexpected turn of events, a nonprofit made hundreds of millions of dollars for its two nonprofit owners. Last week, we learned that the public company 2U is acquiring Harvard and MIT-backed edX for $800 million in cash, and that edX will no longer be a nonprofit.

A suggested alternative for EdX might be to look for equivalent courses that are directly run by professors themselves through their own course sites. py4e would be a good example.

Very true that edX is no longer a non-profit. (I've been reading about the sale, I'm glad to see other OSSUnians doing so as well!) We should keep in mind that Coursera is not a non-profit organization either. As you've pointed out, there have been some cases, like py4e, where the course creators have made materials available on their own site. RFCs to replace courses, backed up with evidence of specific advantages to students, are always welcome!

I find edX to be a terrible platform in general. It's not always clear that you never get to take a course again after the deadline if you don't pay. Suggesting that students simply create another account is something that goes against edX's TOS. Since most edX courses have an alternate source (OCW, etc.), I propose making those the main and linking to edX as an alternative.

Linking issue opened by @rachel83az : https://github.com/ossu/computer-science/issues/920

I think the longer term solution is to find alternative courses on different platforms that are better in qualitty. Most EdX courses do not have a free substitute (like OCW), only the MIT ones do.
Even in case of MIT, the edx versions have active TAs which make the edx version superior.
For example, please see the RFC I created (#933) which replaces 2 EdX courses with coursera ones.


tests/kernel/gen_isr_table fails on mimxrt1050_evk

Tested on master commit 8cf8db3a73aa0658d728006e93d9ef5e0361a1b2, and tags v1.12.0, v1.11.0.
***** Booting Zephyr OS v1.12.0-1423-g8cf8db3 *****
starting test - Test gen_isr_tables
IRQ configuration (total lines 160):
isr1 isr=0x00000add irq=159
isr2 isr=0x00000b05 irq=158
Checking _irq_vector_table entry 159 for irq 159
triggering irq 159
isr1 ran
Checking _irq_vector_table entry 158 for irq 158
triggering irq 158
isr2 ran
interrupt 158 didn't run once, ran 1 times
FAIL - main
===================================================================
===================================================================
PROJECT EXECUTION FAILED

cc: @hakehuang

Actually this issue is not NXP specific, I am able to reproduce it on an STM32F7 board. I believe it is Cortex-M7 specific, as this CPU is superscalar and with a longer pipeline than other Cortex-M CPUs.


Support inputs with units in YAML files

Many of the HYDRAD inputs require units. Currently these cannot be read/written to the yaml config file. Need to add support for this.
Could be something like:
input_name:
  value: 10
  unit: "cm / s"

There would need to be a bit of wrapper code on the YAML I/O to make sure these are handled properly.

Resolved by #27.


@popicons/react-native doesn't work

Sorry for opening again, but the issue isn't fixed yet 😅
Just in case if you missed it: https://github.com/uxthings/popicons/issues/4#issuecomment-2396839993

Hey @filipgrkinic, a gentle ping regarding above :)


added pep8speaks, pep8 config, ran autolint

autopep8 --in-place --aggressive --aggressive -r --max-line-length=120  .

Hello @seanbudd! Thanks for submitting the PR.

In the file modules/ModelChangeDetector.py, following are the PEP8 issues :

Line 20:80: E501 line too long (114 > 79 characters)
Line 28:80: E501 line too long (100 > 79 characters)
Line 32:80: E501 line too long (89 > 79 characters)
Line 36:80: E501 line too long (120 > 79 characters)
Line 37:80: E501 line too long (80 > 79 characters)
Line 39:80: E501 line too long (99 > 79 characters)
Line 40:80: E501 line too long (82 > 79 characters)
Line 45:80: E501 line too long (92 > 79 characters)
Line 47:80: E501 line too long (88 > 79 characters)
Line 49:80: E501 line too long (109 > 79 characters)
Line 52:80: E501 line too long (118 > 79 characters)
Line 53:80: E501 line too long (110 > 79 characters)
Line 54:80: E501 line too long (119 > 79 characters)
Line 55:80: E501 line too long (108 > 79 characters)
Line 56:80: E501 line too long (80 > 79 characters)
Line 59:80: E501 line too long (113 > 79 characters)
Line 62:80: E501 line too long (114 > 79 characters)
Line 63:80: E501 line too long (119 > 79 characters)
Line 64:80: E501 line too long (83 > 79 characters)
Line 67:80: E501 line too long (113 > 79 characters)
Line 71:80: E501 line too long (113 > 79 characters)
Line 72:80: E501 line too long (101 > 79 characters)
Line 73:80: E501 line too long (93 > 79 characters)
Line 77:80: E501 line too long (82 > 79 characters)
Line 80:80: E501 line too long (114 > 79 characters)

In the file modules/commands/CompareCommand.py, following are the PEP8 issues :

Line 7:80: E501 line too long (111 > 79 characters)
Line 24:80: E501 line too long (99 > 79 characters)
Line 28:80: E501 line too long (97 > 79 characters)
Line 30:80: E501 line too long (95 > 79 characters)
Line 39:80: E501 line too long (108 > 79 characters)
Line 50:80: E501 line too long (93 > 79 characters)
Line 51:80: E501 line too long (115 > 79 characters)


🐛 Broken links - PDF files can't be downloaded

Cc: @adamcogan @tiagov8 @bradystroud @Marxoz @JackDevAU

From email: SSW.Rules - Broken link
Describe the Bug

PDF file link is broken and can't be downloaded on this rule - SSW.Rules | Do you know the best learning resources for Angular?
This issue are happening on other pages where it contains PDF file links.
I've looked at the content repo and find PDF files referenced in 2 ways:

[The ng-book](https://www.ng-book.com/2) - This link doesn't work, because website tries to find the file from website's deployed location. 404 page will be displayed when the link is clicked.
[Print out this PDF](https://github.com/SSWConsulting/SSW.Rules.Content/blob/main/rules/the-war-room-does-your-scrum-room-have-the-best-scrum-image/8StepstoScrum.pdf) - This doesn't download the file, only redirects user to PDF file location on GitHub repo

Need to find a way to make it work like images work with relative links.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.ssw.com.au/rules/the-best-learning-resources-for-angular/
Click on "Liitle Book of Angular" on Books section
See error

Expected Behavior

PDF files can be downloaded when use clicked to the link
Tasks

[x] Investigate the ways to solve problem. Relative link, or some other options ?
[ ] ~Implement solution and fix the broken links~

Screenshots

Figure: It is trying to find file from website's hosted location, but the file is not there actually
Thanks!

This issue was caused by the rule on Cloudflare which converts PDF file name to lowercase, which leads to Not Found page.
This issue has been resolved and that rule on Cloudflare was modified to ignore the transformation of PDFs.
Big thanks to @amankumarrr for resolving this issue 🎉
Now PDFs can be viewed on SSW Rules
https://www.ssw.com.au/rules/adeba22e49f60d809b5f41ad5583329a/Little-Book-Angular.pdf


Is it possible to avoid overriding of handlers method?

Hi. I'm trying to implement adding slug automatically on create. In custom handler I can see that we can only fully override create method. There is no middleware to put beforeCreate.
My code is looking a bit ugly
const handler = new MongoStore({
  url: mongoUrl
});

const oldCreate = handler.create.bind(handler);

handler.create = function (request, newResource, callback) {
  newResource.slug = 'testSlug';
  oldCreate(request, newResource, callback);
};

Is there a way to write code better?

Not at this time, sorry. Some kind of middleware interface on the handler functions is an interesting idea, I'll keep it in mind :+1:


Health check, small refacto, improve logs

Perform a health check instead of arbitrary sleep
Move functions to do_meili_tools.py
Improve some log messages

Closes #86

I'm not a big fan of the while loop that could become an infinite loop because there is no timeout limit, but I can guess this is complicated to put a timeout on this kind of check... It might take several minutes, right?

I agree @curquiza. The problem is that this is always used for a required step and we can't go further until it is completed. You can of course stop the running script at any time, but there is no reason to do anything else if this hasn't worked yet.
And yes, some of them can take several minutes

I'm not a big fan of the while loop that could become an infinite loop because there is no timeout limit, but I can guess this is complicated to put a timeout on this kind of check... It might take several minutes, right?

I agree @curquiza. The problem is that this is always used for a required step and we can't go further until it is completed. You can of course stop the running script at any time, but there is no reason to do anything else if this hasn't worked yet.
And yes, some of them can take several minutes

@curquiza
I'll fix #96 in a new PR and format files (to avoid poluting this PR)

@curquiza
I'll fix #96 in a new PR and format files (to avoid poluting this PR)

About the infinite loop, it is indeed possible and a better solution should be found. As for now this is run by hand, so is not a big issue, but this can certainly be improved!

About the infinite loop, it is indeed possible and a better solution should be found. As for now this is run by hand, so is not a big issue, but this can certainly be improved!

bors try

bors try


Bugfix V3.0.2

I think this PR should already include a solution to #199

I think there is no bugfix for the lookup of shells with encoding. It needs to be completely removed from the openAPI specification und substituted by #19


Check systemd version before using --pipe

I ran into this while trying to run repro on a Debian machine. By default, Debian buster ships with systemd 241. repro uses systemd-nspawn --pipe - this flag was added in 242.
This PR adds a systemd version check and uses it to check if --pipe can be used in the systemd-nspawn call.

Sidenote unrelated to the PR, you can install systemd-container/buster-backports to get repro to work on debian stable :)

Thanks!
Yep, that's what I ended up doing. I got repro (and rebuilderd) running fine on the box.

Yo!
Sorry for the delay in review.
I'm not too fond of duplicating the systemd-nspawn command, could we try do something like like this instead? https://github.com/archlinux/archlinux-repro/blob/master/repro.in#L197-L200

Apologies for my own long delay, @Foxboron! Please let me know if this does the trick. I'm not super bash-savvy. :smile:

I reworked the commit slightly and commited since it wasn't the correct bash substitution. I believe this should work. Thanks for the patch :)
https://github.com/archlinux/archlinux-repro/commit/b6f1b4b0f3771de6fc9697e5aace9c5494f6b89b


fix: make pull request id optional value

to not break circleci pipelines on main branch

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(plugin-git): remove duplicate no-reply contributors

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[X] New feature
[ ] Documentation update
[ ] Other

Description
A user might use multiple mechanisms of contributing code, some directly using their username and email, and others automated, typically with a "noreply" email address. Right now, this causes pages that use the "contributor" to have this somewhat awkward field:

This change treats the noreply addresses as the "same contributor", if one exists with the same name.
If a file has no such "noreply" addresses, or if there is no corresponding "normal" contributor, the field is unchanged.
Discussion: https://github.com/vuepress/vuepress-next/discussions/1336
Changes
Before
plugin-git % pnpm build && node -e 'import("./lib/node/utils/getContributors.js").then((mod)=>{mod.getContributors(["runatlantis.io/docs/README.md"], "/Users/lukemassa/atlantis").then((value)=>{console.log(value)})})'

><EMAIL_ADDRESS>build /Users/lukemassa/vuepress-next/ecosystem/plugin-git
> tsc -b tsconfig.build.json

[
  { name: 'Luke Kysow', email<EMAIL_ADDRESS>commits: 6 },
  {
    name: 'Luke Kysow',
    email<EMAIL_ADDRESS>    commits: 2
  }
]

After
plugin-git % pnpm build && node -e 'import("./lib/node/utils/getContributors.js").then((mod)=>{mod.getContributors(["runatlantis.io/docs/README.md"], "/Users/lukemassa/atlantis").then((value)=>{console.log(value)})})'

><EMAIL_ADDRESS>build /Users/lukemassa/vuepress-next/ecosystem/plugin-git
> tsc -b tsconfig.build.json

[ { name: 'Luke Kysow', email<EMAIL_ADDRESS>commits: 6 } ]

@lukemassa Sorry for delay. Have you checked this one? https://github.com/vuepress/vuepress-next/issues/537

I am actually "upvote" for this kind of changes, it's common to merge a pr and create a new commit through things like github, and people can choose to hide their emails:

It's definitely better if we can recognize and remove them in plugin.

Maybe we'd better merge the commits count instead of simply remove it?

Yes, we can merge it if a same name already exists in same file commit, and maybe just remove the email field if not found.

I added some code to sum up the contributions:
plugin-git % pnpm build && node -e 'import("./lib/node/utils/getContributors.js").then((mod)=>{mod.getContributors(["runatlantis.io/docs/README.md"], "/Users/lukemassa/atlantis").then((value)=>{console.log(value)})})'

><EMAIL_ADDRESS>build /Users/lukemassa/vuepress-next/ecosystem/plugin-git
> tsc -b tsconfig.build.json

[ { name: 'Luke Kysow', email<EMAIL_ADDRESS>commits: 8 } ]

Thanks for your contributions! ❤


DB_CLEANUP_TIME doesn't work with blobxfer location

Problem
Cleanup of old backups doesn't work with blobxfer.
A code cleanup commit, removes database cleanup process with blobxfer.
Should be:
case "${BACKUP_LOCATION,,}" in
                "file" | "filesystem" | "blobxfer" )

Additional Feature
Additional configuration value:
Add an environment variable to explicitly enable clean remote directory with blobxfer.
BLOBXFER_REMOTE_CLEANUP the default value is false.
When BLOBXFER_REMOTE_CLEANUP  is true the S3 storage should sync with --delete --delete-only.

I can't quite recall why I removed it from that case statement, but it was causing problems, which is how it ended up this way. What I will do is add another case option strictly for blobxfer and replicate a couple of the lines in filesystem which will also remove the if statement checking if BLOBxfer is there - I feel this will be cleaner and will introduce in next release.

Don't worry!
I suspect this line was missing in original first version.
if [ "${BACKUP_LOCATION,,}" = "blobxfer" ] ; then
I like this variant because otherwise, the filesystem cleanup would have to be done in two places.
But it's your choice. Let me know if you want me to correct it and put it in its own option case. I can prepare it for you.

I splitted 'blobxfer' cleanup in a own option case. #191

I swapped the branches from master to main around yesterday which closed your PR. I've included my own variant in 3.7.0 which should restore blobxfer syncing for you. Let me know..

I have test it - cleanup works. You can close the issue for all I care. Thank you.

Great! Glad its working again, thanks for your contributions.


fix: passing object to log when used via nestjs Logger

Fixes https://github.com/iamolegga/nestjs-pino/issues/353
It took some additional effort compared to what I originally expected, because I found another bug.
When you use nestjs Logger, it automatically passes isTimestampEnabled to the instance methods as the third argument. See here: https://github.com/nestjs/nest/blob/master/packages/common/services/logger.service.ts#L114.
When I merged message and context objects, this third argument became second, so pino treated it as the message and overrode the msg property with it. So msg was always false. I couldn't think of anything better that simply swallowing the isTimestampEnabled argument since it is not quite applicable to nestjs-pino.
Before my merging, this third argument was treated as the first format string argument by pino, so it was also a bug.

Closing this PR, details are provided in related issue, so let's move all discussions there, please


Regenerate all Java APIs

This picks up the Pubsub changes, and the changing of exception test error code. See https://github.com/googleapis/api-client-staging/pull/211 for discussion

LGTM


A method to construct a logger that uses the first available name that avoids overwriting

The behavour of TensorFlow.jl if you have a logger set to path mypath
is to try mypath2 then mypath3 and so forth until it finds a free name.
It might make sense to have overwrite take 3 options:

Append (current behavour if false)
Overwrite (current behavour if true)
IncrementFilename (my suggested behavour)

Good idea.
The standard way to do this would be with a symbol, so something along the lines of :append, :overwrite and :increment?

That kind of use of symbols is an antipattern and a holdover from before julia had Enums.
I suggest either Enums or singleton types, if you want to dispatch on it.
Dispatching on it seems over-engineered.
Therefor Enums.

Solved by #9be2eb0 .
The enum values are, at the moment, tb_overwrite, tb_append, and tb_increment. I'm not very happy with this naming, but I think that exporting some very generic names such as overwrite, append and increment would not be wise.
Also, I should have a look at how the increment behavior works in tensor board so that we can match it. At the moment if logdir="test", then subsequent runs will be test_1, test_2, etc... which is kind of inconsistent as the first run will just be in a folder named test.


Adding "advancedPHP" to your Theme

Heyho,
I saw your theme and noticed a growing popularity.
I'm asking if you could add "advancedPHP" to your theme. It's one of my own extensions and I want to provide more theme coverage for my users.
You can find a theme development documentation in its repo: https://github.com/dennisosaj/advancedphp.novaextension
I would really appreciate it. Thanks!

Hi there @dennisosaj ! You know, I'm a user of advancedPHP as well, and so, naturally, I took a peek at your 'extended syntax' for highlighting — and I did consider to add support for it as well, but, alas, other things took precedence... I guess that your message is my excuse to get back to work, 🤣
Thanks for the heads-up!

Hi there @dennisosaj ! You know, I'm a user of advancedPHP as well, and so, naturally, I took a peek at your 'extended syntax' for highlighting — and I did consider to add support for it as well, but, alas, other things took precedence... I guess that your message is my excuse to get back to work, 🤣
Thanks for the heads-up!

Done 😄 You can try it out... I have compared it with what is produced by the 'standard' PHP-HTML extension, and, as far as I could test it, it works... feel free to report any issues...
Cheers, and thanks again!

Done 😄 You can try it out... I have compared it with what is produced by the 'standard' PHP-HTML extension, and, as far as I could test it, it works... feel free to report any issues...
Cheers, and thanks again!

Hi, I didn't got a notification in my mailbox so I was randomly checking my open issues and saw that you already closed it ^^ I took a look into it and it looks beautiful <3
I will add it to the supported theme list in my next update. Thanks a lot!


[stable/ark] Support backup location prefixes

What this PR does / why we need it: Supports prefixes in backup buckets, needed in case you have other objects in the bucket, so that ark verifies the backup directory structure correctly.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Documented in Ark/Velero here: https://github.com/heptio/velero/blob/v0.10.1/docs/api-types/backupstoragelocation.md#main-config-parameters.
LGTM.

This issue is currently already pending in 2 PRs. https://github.com/helm/charts/pull/11068 and https://github.com/helm/charts/pull/11430

No problem, I will close


Request for configuration detail to implement UAICRL in highD environment.

Hi, I was impressed by your great work, so we would like to compare your method with our progressing work.
However, I found that the configuration files for reproducing the UAICRL method in highD environment were missing in this repository.
├── HighD_velocity_constraint
│   ├── highD_environment_configurations_no_velocity_penalty-40.yaml
│   ├── highD_environment_configurations_velocity_penalty-40.yaml
│   ├── train_Binary_highD_velocity_constraint-1e-1.yaml
│   ├── train_Binary_highD_velocity_constraint.yaml
│   ├── train_DICRL_QRDQN_CVaR_highD_velocity_constraint-1e-1.yaml
│   ├── train_DICRL_QRDQN_CVaR_highD_velocity_constraint.yaml
│   ├── train_DICRL_QRDQN_EXP_highD_velocity_constraint-1e-1.yaml
│   ├── train_DICRL_QRDQN_EXP_highD_velocity_constraint.yaml
│   ├── train_GAIL_highd_velocity_constraint-1e-1.yaml
│   ├── train_GAIL_highd_velocity_constraint.yaml
│   ├── train_ICRL_highD_velocity_constraint-1e-1.yaml
│   ├── train_ICRL_highD_velocity_constraint.yaml
│   ├── train_VICRL_highD_velocity_constraint-1e-1.yaml
│   ├── train_VICRL_highD_velocity_constraint.yaml
│   ├── train_ppo_highD_velocity_constraint.yaml
│   └── train_ppo_lag_highD_velocity_constraint.yaml

Although there were not train_UAICRL_highD_*.yaml files, we found that there were train_DICRL_QRDQN_*.yaml files.
According to the contents of the configuration files, I guess that for UAICRL method for highD environment utilizes QRDQN instead of SplineDQN as distributional method.
Therefore, I could reproduce the result like Figure 4 in the paper if I utilize DICRL_QRDQN_EXP_highD_velocity_constraint-1e-1.yaml file, is that right?
I wonder why you utilize QRDQN instead of SplineDQN for highD. The answer would provide great insight for me.
Furthermore, this repo contains only one expert file scene-DEU_LocationALower-11_1_T-1_len-206.pkl for highD. Did highD's expert data use expert data from Guiliang/ICRL-benchmarks-public repository?

Hi, thanks again for your insterest.
Apologies for not uploading the UAICRL YAML file earlier. The primary reason is that in the HighD environment, the expert demonstrations are more diverse compared to MuJoCo, reducing the need to train the GFlowNet for trajectory augmentation. Additionally, the GPU memory required for GFlowNets in this environment is quite substantial. Therefore, we recommend using distributional RL methods for policy learning.
Regarding QRDQN and SplineDQN, SplineDQN is more complex and demands more training time. On the other hand, QRDQN is relatively simpler, and our previous empirical results on this environment indicated that QRDQN performs similarly or even better than SplineDQN. Hence, we opted for QRDQN.
As for the dataset, we utilized the benchmark's dataset.
For your experiments, I suggest trying both methods of QRDQN and SplineDQN, and fine-tuning them for comparison. You could also consider adding the GFlowNet module to the HighD environment if you have sufficient GPU resources.


cocobu_box for visual genome

First of all, thank you for making your work public. It has really been very helpful.
I am trying to use this implementation (specifically the transformer model) on the visual genome dataset -- I was able to find the cocobu_att and cocobu_fc equivalents, but not the equivalent of cocobu_box. How was cocobu_box generated?
Can the transformer model work without cocobu_box, or does it require it? Can the equivalent for the visual genome dataset be found anywhere?

cocobu_box is something I tried and doesn't seem to work much. Since bottom up is generated from each detected bounding boxes, cocobu_box is basically the coordinates of each boxes.
transformer works without cocobu_box.
there is currently no VG.


[sram_ctrl,dv] Increase wait_cycles for rand_reset tests

In the sram_dv_increase_timeout_reset test, we are waiting to issue a reset when no outstanding TL-UL are in the fly. This wait timed out in some of the tests. Increasing the wait timer lets the test pass.

This is kind of reasonable, I suppose but it's not beautiful (because the "wait until we're not doing anything before we issue a reset" logic is rather silly!)
@martin-velay knows quite a bit about this too, so it might be worth having a chat with him: there's probably a cleaner way to do this, and the resulting sequences will be quite a bit shorter.

This is kind of reasonable, I suppose but it's not beautiful (because the "wait until we're not doing anything before we issue a reset" logic is rather silly!)
@martin-velay knows quite a bit about this too, so it might be worth having a chat with him: there's probably a cleaner way to do this, and the resulting sequences will be quite a bit shorter.

Yes I agee this requires more work in the future. Something similar is in this PR #25647 .


Is it possible to convert lyra into C?

lyra depends on eigen. It is difficult to convert eigen to C. What should i do？|･ω･｀)

We haven't looked into having a C interface for Lyra, so I am not sure about the potential issues, but thank you for your request.

We haven't looked into having a C interface for Lyra, so I am not sure about the potential issues, but thank you for your request.

Thanks.


Developer-intended toast showing up after login

Xamarin.Auth Issue
Version

[ ] nuget version = <IP_ADDRESS>

Steps to reproduce
I am seeing a popup upon native auth on Google after returning from the Google account selection page which fades after a bit: If CustomTabs Login Screen does not close automatically, close CustomTabs by navigating back to the app. From the wording, I assume the message is intended for developers:

@hardcodet
Check Xamarin.Auth.CustomTabsConfiguration. class.
Set the warning message to null and it will not be shown.
NOTE: alpha API, subject to changes!! Undocumented for that reason.

That was easy - thanks! :)
Note for others - the property is the following. Just set it when initializing Xamarin.Auth in your main activity:
//don't show warning message when closing account selection page
CustomTabsConfiguration.CustomTabsClosingMessage = null;


Responding to notification JSON-RPC objects

The Issue
The daemon, when sent a notification JSON-RPC object, will still respond, rendering the daemon not strictly compliant with JSON-RPC.
https://www.jsonrpc.org/specification#notification
Steps to reproduce

Send a JSON-RPC notification object (equivalent to a request object with id = null).
(as an example, a status API call)

Expected behaviour
The daemon shouldn't respond, as per the JSON-RPC specification.
https://www.jsonrpc.org/specification#notification
"The Server MUST NOT reply to a Notification, including those that are within a batch request."
Actual behaviour
The daemon will respond to the notification as if it were a regular request.
System Configuration

LBRY Daemon version: v0.20.2
Operating system: Ubuntu/Linux

Anything Else

"Fixing" this is only necessary if LBRY's daemon is intended to be strictly JSON-RPC compliant. IMO, this likely is going to break potential 3rd-party interfaces that don't adhere to the JSON-RPC specifications when fixed. Though, if/when fixed, the daemon will have actual compliance and will be more deterministic for batch request objects that have notifications interspersed.

I don't believe we have any Notification end points in the current API; all endpoints return some JSON response.
The jsonrpc.org v2.0 specification that you linked to presents the JSON-RPC over HTTP support "with some limitation" as an afterthought which sounds a bit strange to me. I would argue that single request/response HTTP style communication is the most common way that APIs are exposed while the JSON-RPC specification is heavily slanted towards something more suited for persistent full-duplex communication (such as via WebSockets).
We do have plans to add WebSocket support to the daemon and this will be conformant to the jsonrpc.org specification v2. There are no current plans to have the simple daemon HTTP JSON RPC API become conformant  (see previous paragraph), more likely in the long run the HTTP JSON RPC API would be dropped altogether in favor of a new REST API. For simple / command line use cases it would be encouraged to use the REST API and for anything requiring more complex interaction we'd encourage developers to use the WebSocket API.


Do we need a way to tombstone APIs that have been removed across all versions?

Clear and concise description of the problem
Today, we can indicate that something has been removed in a given API version, but is still supported in earlier versions. However, we do not have a natural way of expressing that a previously existing API has been removed across all API versions short of either a) deleting it from the service description (which also erases all historical traces of said API/generated docs etc.) or b) adding an at-removed for the first API version (which is kind of a lie/incorrect).
Being able to say that something used to exist but has been removed could be helpful for posterity/figuring out how to update code that used to work.
Checklist

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Move to discussions


Enable multiple http/https service ports for ingress controller

What this PR does / why we need it:
This is related to the feature request in the issue #8170.
It should be possible to expose multiple http/https ports from Ingress Controller Service.
Special notes for your reviewer:
It is possible with Ingress Controller Service to expose multiple http/https that map to ingress' 80/443 ports. But It is not possible to achieve the same with nginx-ingress helm chart. For example the following service definition for Ingress Controller.
apiVersion: v1
kind: Service
metadata:
  labels:
    app: nginx-ingress
  name: nginx-ingress-controller-svc
spec:
  loadBalancerIP: xx.xxx.xxx.xxx
  ports:
  - name: 80-http
    nodePort: xxxxx
    port: 80
    protocol: TCP
    targetPort: http
  - name: 8080-http
    nodePort: xxxxx
    port: 8080
    protocol: TCP
    targetPort: http
  - name: 443-https
    nodePort: xxxxx
    port: 443
    protocol: TCP
    targetPort: https
  - name: 8443-tcp
    nodePort: xxxxx
    port: 8443
    protocol: TCP
    targetPort: https
  type: LoadBalancer

/ok-to-test


(Potential) Bug when used in Fastboot mode

Just starting this now because I know it'll be something to look into with the incoming v3 stuff.
The potential bug revolves around {{did-update}} modifier not running in Fastboot mode. The initial @content will be output on the <FroalaEditor> template, but if any changes to @content occur in Fastboot mode they won't be picked up because the {{did-update this.updateContent @content}} modifier won't run (modifiers don't run in Fastboot mode).
The reason @content won't be updated through the template is because of how the editor needs to handle changes. Typically the @content is rendered through the template, then the Froala Editor is initialized and any further @content changes must come through Froala's html.set(). Therefore, the @content is "disconnected" after initial render.
It seems like the fix would be a {{did-update}} helper that would run in Fastboot mode too but be able to handle @content changes appropriately depending on if the editor was initialized or not.

Was able to work around this issue!


Make the $children instance property a reactive array

I wanted a computed property that re-evaluates every time the $children instance property is updated, in my case this was every time a component was added/removed from the DOM.  on each change I wanted to return a list of all component names currently active in the DOM.  This however did not function as expected because $children is not reactive.
see fiddle which shows the issue:  https://jsfiddle.net/ajanes92/k729g6jb/26/
I managed to work around it by creating a reactive array in the ready method based on this.$children, see updated fiddle here: https://jsfiddle.net/3mwpd96r/1/
is there a reason why $children is not reactive? And if not can it be made reactive so it can be used in computed properties as per my requirements?
Thanks
Andres

If your components are generated from a reactive array, it's easy to make it.
Just change children to children.filter((x)=>x) or some way you can check if a item should be show  as a item in your component list.
fiddle: https://jsfiddle.net/k729g6jb/34/
Hope it would help.
BTW..
I don't think it is necessary to make $children reactive. I think only data should be reactive.

@Twiknight was right. $children is about components, not data, and thus shouldn't be reactive. Vue's reactivity simply doesn't work that way (DOM events, as in your case).


When trying to access edit page for Load Balancer Config page, we get redirected to an error page

Server version - V0.16.0
Steps to reproduce the problem:
Balancing->Configurations-> choose any configuration-> From Balancer Config ->choose Edit option:
We get the following error message:
http://<IP_ADDRESS>:8080/static/fail
"Error
e.map is not a function
Reload to try again"
This happens always for the LB that is configure with stickiness.

This is happening on configs that use appCookieStickiness ("Use existing cookie") because the config has a property named 'length' and JavaScript is a terrible language.  @alena1108 is going to rename the field in #540 and then I'll update the UI.

v0.17.0
Verified fixed


False Positives

@lisinge there are some false positives in the disposable file. It would be great if you can remove them or implement a whitelist the users can overwrite.
com.ar: This matches all domains ending in com.ar which is wrong in my opinion. Also yandex.com is a valid email provider that should be removed

I would happily accept a PR that removes all the false positives

@lisinge I did the whitelist approach in the linked PR

Thanks! I replied to your PR!


github error

when pasting the code into proxmox console, I get the following:
[INFO] Using 'local-lvm' for storage location.
[INFO] Container ID is 101.
Getting URL for latest Home Assistant disk image...
[ERROR] 0@96 Github has returned an error. A rate limit may have been applied to your connection.
Can anyone help?
Thanks in advance

Same. Been troubleshooting it for an hour. Any help is appreciated.

Same. Been troubleshooting it for an hour. Any help is appreciated.

I wonder if it is an issue with to many people accessing at once?

Only thing I can find is it may possibly be related to a new release of Hassio that possibly requires an update to the script. I'll give it 24hrs no and try again.

Only thing I can find is it may possibly be related to a new release of Hassio that possibly requires an update to the script. I'll give it 24hrs no and try again.

I got tired of waiting, went with this install
https://community.home-assistant.io/t/supervised-install-on-proxmox/194460

Same problem here..

latest 4.8 release does not have a vmdk.gz asset
you can force it to release 4.7 by modifying line 87 to
url = 'https://api.github.com/repos/home-assistant/operating-system/releases/26885064'

same problem as you

Problem has been resolved with latest commit.

@whiskerz007 Thanks for the quick update. As a newbie, I couldnt figure out how to modify the file myself.

Awesome, thanks for the update
On Thu, 28 May 2020 at 23:35, whiskerz007<EMAIL_ADDRESS>wrote:

Problem has been resolved with latest commit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/whiskerz007/proxmox_hassos_install/issues/70#issuecomment-635424994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUONNPCX5HKO4EEONHFXODRT2AFVANCNFSM4NMXA4FQ
.

--
Wesley Wark +61 (0)433677311


hopefully fix Windows git hangs with RemoteClassLoader.force

hopefully fixes #203, see remarks there for details

blocked for now by #231

hmm, I don't think I put this in the right place... uploading it and running chef-client doesn't make the setting show up at https://scala-ci.typesafe.com/computer/jenkins-worker-windows-publish/configure


fastlane: -> 2.79.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

ill reopen after fix (easier to just do run the update script again from correct branch then try to fix this)


Deleting currently played file bug

If you delete a file that you're currently playing and close the program; then the program crashes on startup.

Should be fixed in the upcoming release.
Always set your pointers to NULL after you free the memory they point to... >_>


feature request: separation between server and client.

Hello,
It may be out of the scope of the project, but I do not know indeed. But please, consider this model.
The idea is to separate all the process between a server, what basically would be the responsible to build and store the ports/pkgs per client, and a client what could be installed on several hosts/jails and hold all the options selected for that specific client.
This would be more or less what already can be made with profiles, but a lot of more practical and scalable.
Thank you.

repositories are not 1:1 (1 repository per 1 user).
They are 1:many (1 repository for many users).
The "client/server" model doesn't make sense to me in the context of a repository.

Yes exactly, it would not be 1:1, but many internal repositories as clients, or group of clients.
In practice, someone whom have several small or very busy machines where he/she want/need to use custom packages, could use a powerful, or eventually a dedicated one, to build pkgs for the entire infrastructure using a automated process.
On the server side, it would receive the request from the clients with its specifics configurations, and maybe "CPUTYPE?" too, build them and store in the directory of that client or group (clients with identical needs). One time the request from a client be done, the server send a message to the client to it download and make the upgrade. So, the server would act more like a build agent who also store the packages.
I usually do not do this kind of feature request because I do not code, and so I could not help to make the things happen, but I think something like this would be very handy for sysadmins with several installations/jails.
Thank you.

As you guess, you're describing profiles.
Each repository can be individually customized, and that's done with unique *-make.conf files and options directories and obviously unique package directories for output.
There is nothing "more efficient" then this.  Each repository requires every desired package and their dependencies to be built.
I can't envision what you are asking for because you already have the most efficient method available.

Yes, same thing but with remote request capabilities. A remote machine, with the hypothetical "synth-client" could request ports to be built on another machine, the hypothetical "synth-server". When those packages were built, automatically download and install it like we can do locally today.
Basically the same behavior we have today, but could also be done remotely.
Thank you.

What's stopping you now?
It's not like synth can't be run under a cron job.  Anything that can dispatch shell commands could do this.

Ok, I will look how to do this like you say.
Thank you.

Look at the SYNTHPROFILE environment variable on the synth man page.
You can execute synth with any profile and any build list.  You just need to have the mechanism for issuing those commands.  It's definitely out of scope for Synth, especially given how easy it is to command (even remotely).


App keeps refreshing with log: Server connection lost polling for restart

Describe the bug
In certain situation the app keeps refreshing indefinitely giving this log in console: server connection lost polling for restart.
I'm using vite 2.4.2 with https, react and typescript.
Reproduction
I noticed this happen in this 2 situations:

Using Brave with a CORS extension enabled on the page (in my case is CORS Unblock). Weirdly using Chrome with the same Chromium version and same extension doesn't cause the problem
Running vite with the --host flag and accessing it with my phone (Safari on iOS 14) via the shared url: https://192.168.1.xxx:3000. Removing the https option "solves" the problem on iOS.

System Info
System:
    OS: macOS 11.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 808.27 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
Binaries:
    Node: 14.17.3 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.13 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 91.0.4472.114
    Firefox: 88.0.1
    Safari: 14.1.1

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Got the same problem on 2.3.7 as well. It can be reproduced if you have hmr.host set to localhost in your vite.config.js
...
  server: {
    hmr: {
      protocol: 'ws',
      host: 'localhost'
    }
  },
...

Solution: Remove the whole hmr key in your vite.config.js
I personally think the host option doesn't make any sense.
it should be something like this:
...
  server: {
    hmr: {
      protocol: 'ws',
      port: 3000
    }
  },
...

@to vitejs devs: maybe on iOS, you should detect we've set localhost for hmr.host and prevent the flicking / constant page refresh / or ignore the hmr.host: 'localhost'.
The good news is that I got 15000 pageviews on Google Analytics in a few seconds, it make me feel my app is super successful ;-)

@dmx374 I haven't set hmr.host. I tried with a blank vite + typescript + react project and got the same problem. The only params I set are server.https.key & server.https.cert.
I'm wondering if the certificate has something to do with it. I used the following command to crete it:
mkcert -key-file ssl/key.pem -cert-file ssl/cert.pem localhost

I can reproduce this with a vanilla yarn create vite altered by adding the following vite.config.ts:
import { defineConfig, ConfigEnv } from 'vite';

export default defineConfig((_configEnv: ConfigEnv) => {
    return {
        server: {
            // host: '<IP_ADDRESS>',
            port: 3000,
            strictPort: true,
            hmr: {
                port: 6000
            },
        },
        base: './'
    }
});

Are y'all running your projects in docker containers? When I run the server in docker I experience this issue and hot reload is also broken. When I run the server locally, though, instead of in a container, I don't get this error and hot reload works as expected.

@mrweiner I personally don't, I run it locally.

@mrweiner My minimal reproduction involved no Docker containers, but I first experienced it in conjunction with Docker, which motivated me to find a minimal reproduction.

I'm having the same issue (vite 2.4.4). I run the vite server in a docker container, and use lvh.me to resolve to localhost.

Also started having this problem, but only in Chrome. Changing the various server.hmr settings has no effect. I even downgraded to vite 2.1.5 but still the problem occurs. I think maybe Chrome made a change that causes the websocket to lose connection? Can anyone confirm this works in other browsers with default hmr settings?

Hi
Just chiming in, same issue, no proxy, no docker. Tested various server.hmr combinations, including setting server.host to a named host (ie company.dev) with an associated certificate, added to the browser trusted list.
The websocket connection keeps failing. I am using current Edge but also tested in Chrome.
NB: all is well with same setup under HTTP.

Would you test your projects using<EMAIL_ADDRESS>?

@patak-js I have the same problem described above and now I also get this error:
[vite] Internal server error: Unexpected token } in JSON at position 542
Plugin: vite:esbuild
  File: /.../vite-project/src/main.tsx

I'm not sure what it could be.

Would you test your projects using<EMAIL_ADDRESS>?

just tried it, still no luck.

UPDATE: tried 2.5.0-beta.2, same issue

I was not able to resolve it with any of the suggestions. The only temporary fix was npm ci and that only works until the first time hotreload is triggered. What's more, I am not having this problem in Firefox, only in Chrome on linux. Very confusing.

@pzmosquito can you please share your full config?
I've managed to get this to not reload. The WS never connects, but at least it doesn't reload and I can use non-built/non-minified JS/TS(x) files.
server: {
    // host: '<IP_ADDRESS>',
    // https: true,
    hmr: {
      host: 'ad345ds2.ngrok.io',
      // port: 443,
      // protocol: 'wss',
    },
  },

Uncommenting https or port makes Vite enter the endless reloading loop.
PS I'm using ngrok tunnel.

@pzmosquito can you please share your full config?
I've managed to get this to not reload. The WS never connects, but at least it doesn't reload and I can use non-built/non-minified JS/TS(x) files.
server: {
    // host: '<IP_ADDRESS>',
    // https: true,
    hmr: {
      host: 'ad345ds2.ngrok.io',
      // port: 443,
      // protocol: 'wss',
    },
  },

Uncommenting https or port makes Vite enter the endless reloading loop.
PS I'm using ngrok tunnel.

import path from "path";
import { defineConfig } from "vite";
import reactRefresh from "@vitejs/plugin-react-refresh";

export default defineConfig({
    mode: "development",
    resolve: {
        alias: {
            _: path.resolve(__dirname, "src"),
        },
    },
    plugins: [
        reactRefresh(),
    ],
    clearScreen: false,
    server: {
        host: "<IP_ADDRESS>",
        port: 3000,
        strictPort: true,
        hmr: {
            port: 443,
        },
    },
});

Not sure how this is related, but this was caused by the CORS Unblock extension on my machine. Once I had disabled it, the refresh stopped happening. 🤷
https://chrome.google.com/webstore/detail/cors-unblock/lfhmikememgdcahcdlaciloancbhjino

In CodeSandbox traffic is routed to port 3000 from an SSL proxy on port 443. Vite will by default look for port 3000, instead of port 443. The only configuration needed to make it work was changing the HMR port.
server: {
    hmr: {
      port: 443
    }
  }

Working codesandbox: https://codesandbox.io/s/vite-hmr-fix-4259-h6c2l?file=/vite.config.ts:180-227

I tried all of the above solutions and finally found a solution that works for me. 🎉
Here's what works for me:

I start ngrok ngrok http 3000
I use ngrok to load my website in an iframe (this is needed in my case because my website is loaded within a third-party website and I can only configure my website url that they will show to users in an iframe)
I start localtunnel npm package that I install globally: npm install -g localtunnel
I use localtunnel to listen for WebSocket connections on port 3036: lt --port=3036

So in my case:

I use ngrok for initial page load and HTTP/S traffic
I use localtunnel for ws connection for Vite (HMR)

I solved the problem，you need fix Charles -> SSL PRoxying Settings -> *:4

43

I experienced this same issue when building with docker. In the container my app runs on port 3000, however, as I have another app running on that port on my local I am using 3001 as my host port. From my docker-compose.yml for my Svelte+Vite app:
  web-frontend:
    build:
      context: ./svelte-vite-frontend-dock
      dockerfile: Dockerfile
    volumes:
      - ./svelte-vite-frontend-dock:/usr/src/app
      - /usr/src/app/node_modules
    ports:
      - 3001:3000
      - 24678:24678

Clues above in posts regarding people using reverse proxies made me realize that I needed to add this to my vite.config.js file:
server: {
    hmr: {
      clientPort: 3001,
    },
  },

This immediately fixed my issue.

@pzmosquito can you please share your full config?
I've managed to get this to not reload. The WS never connects, but at least it doesn't reload and I can use non-built/non-minified JS/TS(x) files.
server: {
    // host: '<IP_ADDRESS>',
    // https: true,
    hmr: {
      host: 'ad345ds2.ngrok.io',
      // port: 443,
      // protocol: 'wss',
    },
  },

Uncommenting https or port makes Vite enter the endless reloading loop.
PS I'm using ngrok tunnel.

import path from "path";
import { defineConfig } from "vite";
import reactRefresh from "@vitejs/plugin-react-refresh";

export default defineConfig({
    mode: "development",
    resolve: {
        alias: {
            _: path.resolve(__dirname, "src"),
        },
    },
    plugins: [
        reactRefresh(),
    ],
    clearScreen: false,
    server: {
        host: "<IP_ADDRESS>",
        port: 3000,
        strictPort: true,
        hmr: {
            port: 443,
        },
    },
});

need to set strictPort=true, thanks a lot

There are two issues that talk about similar/the same issue. This one and Vite HMR is unusable behind reverse proxies with random port numbers for client.
I posted my config there, so here it is here as well:

Ahhh, well you could try my setup. It works, but uses two tunnels.
Here's how I configured everything:

vite.config.ts:
// ...
export default defineConfig({
// ...
  server: {
    hmr: {
      host: `some-ngrok-subdomain.loca.lt`,
      port: 443,
    },
  },
// ...

package.json:
"devDependencies": {
  "localtunnel": "2.0.1",
  "ngrok": "^4.2.2"
}

And then I start everything:
./node_modules/.bin/lt --subdomain=some-ngrok-subdomain--port=3036
./node_modules/.bin/ngrok http -subdomain=some-ngrok-subdomain

Happy to report for gitpod.io users who faced the same issue as the dev environments are likewise hosted in containers, changing the hrm.port to 443 solved the issue immediately.
vite.config.ts:
// ...
export default defineConfig({
// ...
  server: {
    hmr: {
      host: `some-ngrok-subdomain.loca.lt`,
      port: 443,
    },
  },
// ...

None of the methods mentioned here worked when using nginx and localhost:3000

Thanks for the quick reply but it doesn't seem to work

Maybe related https://github.com/vitejs/vite/issues/6068

Hi,
I'm developing in localhost with Docker, and for me, the valid config is:
export default defineConfig({   server: {     **host: true,**     port: 5000       }, .... }
Or try to use ssl with mkcert (https://github.com/FiloSottile/mkcert#installation)
I hope it helps.

I'm quite sure that this is not related to Docker nor ngrok. My app is running locally and I had the same issue- if I enable a CORS extension my app was constantly refreshing.
If you experience the same have a  look into your web developer tools console logs and enable "Preserve logs" - you may see error messages like WebSocket connection to 'ws://localhost:xxxx/' failed.
What was working for me is to don't open my app via "http://localhost:xxx" but "http://<IP_ADDRESS>:xxx" instead - no config change necessary.
If you don't like to use "http://<IP_ADDRESS>..." in your URL for some reason it may also work if you change your hmr config to use <IP_ADDRESS> as a specific host like this:
server: {         hmr: {             host: '<IP_ADDRESS>'         }     },

Because I wanted to achieve a local-to-git-to-codesandbox flow, here is how I got Vite working for both local development and CodeSandbox without the refresh issue.

Add an extra dev script with a new sandbox mode. I called it sandbox:

  "scripts": {
    "dev": "vite --host",
    "sandbox": "APP_ENV=sandbox vite",
    "build": "vite build",
    "preview": "vite preview"
  },

Set vite.config.js to pick up on that accordingly (avoiding the clientPort from local dev):

{
  server: process.env.APP_ENV === "sandbox" ? { hmr: { clientPort: 443 } } : {};
}

Create a codesandbox.config.json config for the new startScript:

{
  "container": {
    "startScript": "sandbox"
  }
}

Working sandbox:
https://codesandbox.io/s/react-three-fiber-vite-starter-ferv7g
Git repo:
https://github.com/benjaminmiles/react-three-vite

I am experiencing this issue with 2.9.1 inside a docker container.

@aflansburg https://github.com/vitejs/vite/issues/4259#issuecomment-999092118
Could you kindly be asked to post your entire docker-compose setup with Nginx conf, Node and latest SvelteKit working and its config with the Vite websockets ?
Likewise anyone else that works with a Docker environment and got the websockets working with a Node app through Nginx, it would be great to be able to have a look at how you have set up things to work, thank you.

@aflansburg #4259 (comment) Could you kindly be asked to post your entire docker-compose setup with Nginx conf, Node and latest SvelteKit working and its config with the Vite websockets ?
Likewise anyone else that works with a Docker environment and got the websockets working with a Node app through Nginx, it would be great to be able to have a look at how you have set up things to work, thank you.

Sure thing, this is my setup / config, hope this helps.
docker-compose.yaml
version: '3.7'

services:

  # Node for client app
  vue-symfony-scaffolding-client-node:
    container_name: vue-symfony-scaffolding-client-node
    build: docker/containers/client-node
    restart: unless-stopped
    stdin_open: true                # Needed for HMR
    environment:
      - CHOKIDAR_USEPOLLING=true    # Needed for HMR
    ports:
      - 14365:3000
    volumes:
      - ./app/client:/var/www
    networks:
      - app-network

  # Nginx for server app
  vue-symfony-scaffolding-server-nginx:
    container_name: vue-symfony-scaffolding-server-nginx
    build: docker/containers/server-nginx
    restart: unless-stopped
    ports:
      - 13100:80
    volumes:
      - ./app/server:/var/www
      - ./docker/containers/server-nginx/etc/nginx/conf.d:/etc/nginx/conf.d
    depends_on:
      - vue-symfony-scaffolding-server-php
      - vue-symfony-scaffolding-server-mysql
    networks:
      - app-network

  # PHP for server app
  vue-symfony-scaffolding-server-php:
    build: docker/containers/server-php
    container_name: vue-symfony-scaffolding-server-php
    restart: unless-stopped
    tty: true
    environment:
      SERVICE_NAME: php
      SERVICE_TAGS: dev
    working_dir: /var/www
    volumes:
      - ./app/server:/var/www
    networks:
      - app-network
    depends_on:
      - vue-symfony-scaffolding-server-mysql

  # MySQL for server app
  vue-symfony-scaffolding-server-mysql:
    image: mysql:8.0
    container_name: vue-symfony-scaffolding-server-mysql
    command: --default-authentication-plugin=mysql_native_password
    restart: unless-stopped
    tty: true
    ports:
      - "34472:3306"
    volumes:
      - dbdata:/var/lib/mysql/
    environment:
      MYSQL_ROOT_PASSWORD: wGgfBcJzfSer2mLgh5Na5QKaZ
      MYSQL_DATABASE: vue_symfony_scaffolding
    networks:
      - app-network

  # Node websocket server
  vue-symfony-scaffolding-websocket:
    container_name: vue-symfony-scaffolding-websocket
    build: docker/containers/websockets
    restart: always
    stdin_open: true                # Needed for HMR
    environment:
      - CHOKIDAR_USEPOLLING=true    # Needed for HMR
    ports:
      - 46295:46295
    volumes:
      - ./websocket:/var/www
    networks:
      - app-network

# Networks
networks:
  app-network:
    driver: bridge

# Volumes
volumes:
  dbdata:
    driver: local

Here is my vite.config.ts:
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import { fileURLToPath, URL } from 'url'
import Components from 'unplugin-vue-components/vite'

export default defineConfig(({ command }) => {
    return {
        plugins: [
            vue({ reactivityTransform: true }),
            Components({}),
        ],

        base: (command === 'build') ? './' : '/',

        resolve: {
            alias: {
                '@': fileURLToPath(new URL('./src', import.meta.url)),
                '@img': fileURLToPath(new URL('./src/assets/img', import.meta.url)),
            },
        },

        server: {
            host: true,

            hmr: {
                clientPort: 14365
            }
        }
    }
})

And my Nginx config (these may not be the actual port numbers used):
server {
    listen 80;

    server_name app.booking-jojo.com;

    client_max_body_size 100M;

    location /ws/ {
        proxy_pass http://localhost:46295;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
    }

    location /api/ {
        proxy_set_header X-Real-IP  $remote_addr;
        proxy_set_header X-Forwarded-For $remote_addr;
        proxy_set_header Host $host;
        proxy_pass http://localhost:41166/;
    }

    location / {
        proxy_set_header X-Real-IP  $remote_addr;
        proxy_set_header X-Forwarded-For $remote_addr;
        proxy_set_header Host $host;
        proxy_pass http://localhost:47344;
    }
}

@aflansburg #4259 (comment) Could you kindly be asked to post your entire docker-compose setup with Nginx conf, Node and latest SvelteKit working and its config with the Vite websockets ?
Likewise anyone else that works with a Docker environment and got the websockets working with a Node app through Nginx, it would be great to be able to have a look at how you have set up things to work, thank you.

Hi sorry for the delay. My project is public monorepo and can be seen here. I haven't been able to work on it as of late, but essentially components are:

rails API only backend
svelte frontend w/ vite for tooling
nginx proxy

Closing as https://github.com/vitejs/vite/pull/8650 covers most reported cases here. Please try 3.0.0-beta.1.
If it is still not working with 3.0.0-beta.1, please create a discussion or a issue.


Improve the getting-started docs

Previously, we had a section that made the user follow some steps from the local_dev.md. I think this was confusing. So I copied the steps that the user needed to follow from the local_dev.md, and made the getting_started.md doc a series of steps that a user can follow to try the software out quickly.
Other minor improvements

Adding line breaks to make things a little clearer for folks trying this out on their own hosts v/s starting docker containers
Copied some introductions and definitions from the Cluster API book
Added some more context behind why we need to make changes to the kubeconfig before providing it as input to the agent
Instructing users to deploy calico manifest 3.20. Because thats what the Cluster API book does as well.

LGTM


Overhaul of MODData

This WIP PR overhauls the MODData class with the following aims:

[ ] easier for the user to select featurizers (probably now pushed to the next PR)
[x] make RR and NMI calculations more modular so they can be tested more effectively
[x] allow for easier re-use of old calculations, and checkpointing of new descriptor calculations
[x] some general tidying

Good work. Good to see things are going on :+1:

Just a comment out of a few discussions with @ppdebreuck and Gian-Marco, it might be good to allow for other forms of functions than the one that is currently implemented, i.e. not restricting ourselves to nmi/(maxcrossnmi^p+c) but being able to directly pass a callable.

Apologies for the delay, my tests now exactly match the current output of MODData (down to the values of features, and which features remain in df_featurized after cleaning). I had to tweak some more field names that had previously been hardcoded to other values, but we can soon move all of this to the "presets" package so that the paper can be reproduced as its stands.

Once we're ready to merge this I'll also squash this down to fewer commits so I'm not flooding the commit log, perhaps @ppdebreuck you could just confirm the changes in the last couple of commits as they are?

Looks like there's just one more test failure on the CI to fix (passes locally)

So the problem is caused by the following: unfortunately the latest pymatgen/scipy versions fill null values in partial RDFs slightly differently, so this feature gets dropped every time. For now, I've pinned the version of pymatgen to maintain consistency with the paper.


Add code highlight widget

I started something similar right after FlutterCon. And I implemented one specific widget that I found necessary for slides: the code highlight widget. It uses flutter_highlight.
Status
READY
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Can you also add a small example to the README file under the "Widgets" section? Similar to the FlutterDeckBulletList widget. Just let me know since I can update it myself before the release ✌

@mkobuolys everything should be resolved 👌


New version supporting v2.6.0

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
Can we get a new version released supporting 2.6.0? Just think this needs to be bumped and publish new chart.
https://github.com/traefik/traefik-helm-chart/blob/master/traefik/Chart.yaml#L6

Hello @nodesocket and thanks for your interest in Traefik,
We are working on it, this also implies updating the experimental support of Gateway API to v1alpa2, as described in https://github.com/traefik/traefik-helm-chart/issues/549.

Just FYI, we just upgraded to 2.5.7 which also didn't have a chart update...
Looks like I might as well go to 2.6.0 now :)


Please update revpop-core/programs/README.md

On https://github.com/Revolution-Populi/revpop-core/tree/master/programs#revpop-programs there are still references to "bitshares" and a link to "Delayed node" which was removed on commit: 2131f3a2924dfebfa4780a92ed0668d88ce2eb3a

Hi @TropikalMonkey !
Thanks for your comment! We are currently doing a lot of research now and do not have time to update all the documentation although this task is in the plans.
I see you have prepared a request with changes https://github.com/TropikalMonkey/revpop-core/commit/134d97500bc33524c03b919bfed9ca7345c0f03a but sent it to your fork of the project.
Could you please send your request here too? Thank you!

Thx, done.


Provide a shell derivation

The current examples recommend pkgs.mkShell for providing development shells:
devShells.default = pkgs.mkShell {
  inputsFrom = builtins.attrValues self.checks.${system};

  # Additional dev-shell environment variables can be set directly
  # MY_CUSTOM_DEVELOPMENT_VAR = "something else";

  # Extra inputs can be added here
  nativeBuildInputs = with pkgs; [
    cargo
    rustc
  ];
};

It would be nice if we could provide a craneLib.rustShell function that looked something like this:
{ lib
, mkShell
, rustPlatform
, rust-analyzer
, cargo
, rustc
}:

{ checks ? {}
, inputsFrom ? []
, nativeBuildInputs ? []
, rust-analyzer ? rust-analyzer
, ...
}@args:
let
  inherit (builtins) removeAttrs;

  cleanedArgs = removeAttrs args [
    "checks"
    "inputsFrom"
    "nativeBuildInputs"
    "rust-analyzer"
  ];
in
mkShell (cleanedArgs // {
  inputsFrom = builtins.attrValues checks ++ inputsFrom;

  nativeBuildInputs =
    [
      rustc
      cargo
    ]
    ++ lib.optional (rust-analyzer != null) rust-analyzer
    ++ nativeBuildInputs;
}
// lib.optionalAttrs (rust-analyzer != null) {
  RUST_SRC_PATH = rustPlatform.rustLibSrc;
})

Does this sound like a good idea? If so, I can put up a PR.

I don't mind having a common helper to cut down boilerplate! Feel free to open a PR (and we can iron out specific details there)


Sideburn colors don't change with "Hair" color

Ingame, when changing the color of the hair, I noticed that the hair on the sides of Mario's head doesn't change, and it looks odd when altering hair color. I haven't tested this with Luigi/Wario, but it could be the case for them too.

Actually, I noticed this too. Thank you for pointing this out.

I think this has been around for a while. I don't know why it happens, but maybe the sideburns are considered a separate part of Mario's model by the game?

Sideburns are their own textures and aren't changeable even if I tried to set up a grayscale version due to how sm64's light system works
You can replicate this behavior in emu as well, since CCs can't modify the color of a texture that's already on a shaded face


Raw bytes not always shown in WX console

Observed that certain HIL tests executed manually via the GUI do not always pass. This tends to happen in cases where raw bytes are sent from the Arduino (test codes L or S, for example). However, this is just initial assessment so the issue might extend to other tests as well. It is also unclear why these tests sometimes pass and sometimes fail, like shown in the attached screenshot. The issue appears to e WX-related only, because the logger always correctly shows all the expected data.
Need further investigation to understand the true extents and origins of the problem before trying to fix it.

If this issue is caused by non-ASCII or non-Unicode bytes, one way to address it would be to print their hexadecimal codes or Unicode escape characters.


update to v0.6.0 Featuretools (using primitive refactor)

https://github.com/Featuretools/featuretools/pull/364

I'm seeing many warnings like /Users/lecrintech/projects/python/demos-featuretools/demo7/v0.6.0/predict-olympic-medals/env3.7/lib/python3.7/site-packages/sklearn/utils/deprecation.py:58: DeprecationWarning: Class Imputer is deprecated; Imputer was deprecated in version 0.20 and will be removed in 0.22. Import impute.SimpleImputer from sklearn instead.
can we fix those before merging?


qbittorrent: make portable, persist

I would wait for one of these is merged: https://github.com/qbittorrent/qBittorrent/pull/9584 https://github.com/qbittorrent/qBittorrent/pull/9349 and then add qbittorrent-portable to extras, keeping nonportable available

I see merit in keeping qbittorrent intact if only for compatibility with previous installations.
As for portability: I imagine that env_set will break installation of qbittorrent alongside qbittorrent-portable, maybe something like this can work meanwhile we wait for a proper portable edition?
    "bin": [
        [
            "qbittorrent.exe",
            "qbittorrent",
            "--portable"
        ]
    ],
    "shortcuts": [
        [
            "qbittorrent.exe",
            "qBittorrent",
            "--portable"
        ]
    ],

I use this method inside my bucket:
https://github.com/Ash258/scoop-Ash258/blob/master/bucket/qBittorrent.json


TS Namespace + Small bug fixes + Reorg

Created FeatureLibrary. Once imported, users can now access pl.col("a").ts namespace for every feature that can be lazily generated.
Improved perf for has_duplicate_min/max by 10-20% by reducing some redundant computation.
Rewrote longest_strike_above/below_mean because ....max().fill_null() will not work when input is Series. When .max() is called, series input will result in a Python int result which does not have .fill_null()
Small docstring changes

@topher-lo

I added some small changes

Improved perf for index_mass_quantile by 10-20% by reducing the amount of computation. Also fixed a misplaced +1 in the old implementation.
Reverted first/last_location_of_min/max, as the issue went away in 0.19.7 for me... Very strange. So we can keep the og implementation going forward.

@MathieuCayssol We can show off the perf difference for first/last_location_of_min/max vs. tsfresh on 0.19.7, again magnitudes faster ( because Polars' underlying arg_min_max is handled by a super fast Rust package... I didn't do anything)


update googleads version to 10.0.0

update googleads version to 10.0.0

I think the readme link should also be changed to API 201802 from API 201710.

Current API version is 201710. Only the DFP API has been updated to 201802 yet.


Minor problems in the Separation logic description

In the description of the separating conjunction example (in Separation logic section of Foundations) either x should be replaced with z or vice versa.

Thanks for the report; this has been fixed!


SAK-42139 Messages / default sort order should be date instead of label

I don't understand the purpose of this change. I think Date is a valid default sort for an inbox. I have left a comment on the Jira issue.

@fostersdesign Default is LABEL and should be DATE, it's a bug introduced when the new columns were added, the index wasn't updated.

Thank you for clarifying, @mpellicer. The Jira issue's summary confused me. Thank you for correcting the summary.


How can I save data to users computer?

Describe the problem
I want to save data to users computer when they are using the executable, so that when they close it and launch it later their data still exists. How can I accomplish this?

How can I accomplish this?

What have you already tried?

I personally use JSON files for this. Just create a file inside the same directory as the compiled code and edit it using python. Not sure if this is the best option, but it's the one I'm most familiar with.

Show some code 😉

Hi! I would like to work on this issue as my first contribution for the project. Could you help me get started by giving me some pointers so that I can head in the right direction?


[itkDataImageWriterBase] sync fct to be the one on medInria

Sync this function to be the same as in medInria, because it creates problem merging.
If we need to change something, we can change it on medInria.
:m:

(changed the description of this PR. Can wait after the release if needed)


#364: split render / build argument handling

Hey @haleyk10198 thanks for working on thsi. Anything I can do to help?


Shrink the Hardware

It's nice, but it presently uses a ESP32 coded with TASMOTA, and a serial link to an Arduino.
I think the entire functionality could be ported to the ESP32. Unfortunately, we'd lose some of the nice features TASMOTA supplies.
An ESP-cored alternative would need means to:

connect and supply WiFi SSID and key
configure for the MQTT broker
set pass keys to open and close the "service"
set the callsign to be used for the service

A webserver would certainly be a favoured means to achieve most of these nice features presently supported by TASMOTA.

ESP8266 now completely functional as an MQTT interface. Rather than Talkie, ESP8266Audio has been deployed, which contains ESP8266SAM. this is a very similar voice synthesiser, but much more flexible. It uses the I2C UART as a stable PWM generator for the output.
The MT8870 is still (presently) required to decode DTMF sequences, so the ticket remains open.

See also this issue.


Upgraded sbt to 0.13.7 and scalajs-react to 0.7.0.

I updated the code using also the new format <. for tags and ^. for attributes.

@aparo thanks much for contribution .


Adds stand-alone channel overrides example

This adds a standalone channel overrides example and example document to address #329. This completes the job of #330 by removing the channel override information from the vehicle state example and guide pages. It also tidies up the "running the example" section on the vehicle state example.
Note that the new example and example page has a big disclaimer saying that this shouldn't be used, but that if you need to you should post an issue explaining why so we can find a better alternative. I don't have a separate guide section on this because it isn't something we want to promote.
This has not yet been tested. The example page(s) "guess" at what the output should look like. I will test and update those sections as soon as there is a DK version I can use.

This also now tidies up the vehicle state example and docs to remove the MAVLInk message stuff that is no longer needed now that is in its own example. @mrpollo @tcr3dr Can I get this merged please?


Update app settings pages

Resolved / Related Issues

Closes #8 (if we can)

Details of Changes

Added the possibility to change the theme of the App (Light/Dark)

Validation

[x] Built and ran the app
[x] Tested the changes for accessibility

Screenshots (optional)

Known bugs

The app doesn't save the theme selection after reopening the app

Ok, seeing the code i saw that the settings manager has an option to choose the theme. Need to take a look to it, that's why i made this a draft

just coded. so, no dependencies. you can delete it.

Ok! But i need to take a look for it by the way.

Ok!

If you're looking for the bug that doesn't save the theme, i need to say that the theme helper already have the option to save the theme and load it. If you go to the App.xaml file, you can see that there is an ThemeHelper.Initialize(). It does that function

Thank you. but I will improve only UI!
If I can afford it, I will refer to it.

I'm gonna translate the app to the Spanish

Nice! I thought on it!

Updated UI

How do you feel?

WinUI is a little bit buggy

oh. nice! no problem!

I had put the pencil icon in the theme selection instead of the brush because I couldn't find it hahah

The way that i did the theme color saving is not the best, but by the moment, we can keep it

nice. Whatever it is, both the language and the theme have been preserved and restored.

Yeahh haha nice

(mine 0:14 AM) so I have to sleep. bye. and I'll think about the "About Us" UI tomorrow.

Ok! Good night! I'll try to do it by seeing other apps if you want

yea. especially Files' settings and PowerToys, DevToys,,,

Yep! Ok, so i'm gonna do a draft and you see if you like it!

yeah. it's very complicated.

why did you copied FluentIcons to our projects? you considered in windows 10?

i changed fontfamily name "Fluent Icons" to "FluentIcons"

Ok, nice!

why did you copied FluentIcons to our projects? you considered in windows 10?

? I didn't understand. I putted the font in the assets folder to use the Fluent Icons in the settings views and some others

in fact, you can use without specifying.

can you see discrod?

Add Dev label in app icons

Nice!

you want to stay in private member?
or you can go in public member (setting).

What's the difference?

But i can be a public one!

Oh, i see. I can be public!

Nothing in particular. ;)

I thought on doing th website, but first is better to do the main app features

yeah. i think the same as you.

But I will sleep (1:21 am now)

Ok, no problem! Sorry men, and good night!

Now i'm going to sleep (0:53 AM Now), tomorrow morning i'll be taking a look to the issues and things that i can do. I f you want, give me a list of things to do and i will be taking a look to them. Thanks!

when change language, load custom restart info bar:

but it does not work.

No problem! later i take a look to it

Sorry omg, these are mine worst ever weeks

you dont have to keep previous code.

nice

What is the goal of this PR?
Add theme changablity?
You want to merge?

For the users, i think that we can do a flyout

What is the goal of this PR? Add theme changablity? You want to merge?

At first, it was for implementing the Dark/Light modes

what kind?

Like this, but for users, i can do a draft

oh this is Rise media player.

oh this is Rise media player.

Yep

So. What is your ultimate goal?

Let me make a Photoshop fast draft

this Rise Media Player's expandable content user control is very to windows 11 settings!
Do you want to include this feature?

Like this! More worked, of course, but this is the idea

In app, something like this

You want to create settings pages as dialogs?

OHHHH. SORRRY

You want to create settings pages as dialogs?

No, just account switching

OHHHH. SORRRY

No problem!

you taking about account page?

you taking about account page?

If you want, ok!

uhm, I'm sorry, I don't understand at all.

you want to change accoutn selector to dropdown?

Ok, i tell you, sorry. I want to change

okok.

And convert that to a ContentDialog

Like this

ok, why?

Oh, it's ok, so we can keep it! It was an idea haha

I'm sorry for my lack of understanding

No problem! I explained that bad as f*ck

so, merge this? or still stay?

We can merge it

Ill fix codefactor

Ok!


providers.file: Changes in bind-mounted dynamic config file are ignored until restart

Do you want to request a feature or report a bug?
Bug (probably)
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[x] No

What did you do?
I configured a dynamic config file dynamic.toml with watch = true. The config file is a bind mount in a docker container.
What did you expect to see?
I expect traefik to notice changes in dynamic.toml within some seconds and apply them.
What did you see instead?
traefik ignores any changes. A restart is necessary to apply changes in dynamic.toml
Output of traefik version: (What version of Traefik are you using?)

Xeon E3 1240L v3 / 16GB / Ubuntu Server 16.04 / Docker
docker-compose.yml:
version: '2'

services:
  traefik:
    image: traefik:v2.0
    ports:
      - "80:80"
      - "443:443"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - /storage/docker/traefik/acme.json:/etc/traefik/acme/acme.json
      - /storage/docker/traefik/traefik.toml:/etc/traefik/traefik.toml
      - /storage/docker/traefik/dynamic.toml:/etc/traefik/dynamic.toml
      - /etc/letsencrypt/live/gofferje.net/fullchain.pem:/etc/traefik/gn_fullchain.pem
      - /etc/letsencrypt/live/gofferje.net/privkey.pem:/etc/traefik/gn_privkey.pem
    networks:
      - web_services

networks:
  web_services:
    external:
      name: web_services

traefik.toml (excerpt):
[providers.docker]
  exposedByDefault = false

[providers.file]
  filename = "/etc/traefik/dynamic.toml"
  watch = true

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
No relevant log output. File changes are simply ignored.

Coming across this too. Even starting a shell in the traefik container and editing the file with vi doesn't get traefik to update.

The workaround is to mount and use a directory instead of a file..

That doesn't fully work for me. It only refreshes the config if a new file is created, if an existing file is changed, the config is not reloaded either.

[providers.docker]
  exposedByDefault = false

[providers.file]
  filename = "/etc/traefik/dynamic/"
  watch = true

That's what I have (but directory instead of filename). If /etc/traefik/dynamic/ contains foo.yml when traefik starts, modifying foo.yml does nothing at all to the config, but a simple touch bar.yml and it picks up changes to both files.
I've changed my code now so that it removes the dynamically generated file and creates a new one and traefik is picking it up, but just overwriting the file and it doesn't, even with watching a directory.

you also need to mound the directory instead a file. ^

I do, my traefik.yml contains:
providers:
  file:
    directory: "/etc/traefik/dynamic/"
    watch: true

I have a bind mount for ./traefik-dynamic/:/etc/traefik/dynamic/. That directory contains generated.yml. If I edit that file, traefik doesn't pick up the changes. I have to either delete it first and write to it (some editors do this silently) or create a 2nd file in the mounted / watched directory.

Closed by #5939.


Support non-native arithmetic

Currently, the circuit doesn't support Q values that are outside of the p prime of the circuit. This is a limitation. Solution is to add support to non-native arithmetic. A possible tooling to use is https://github.com/privacy-scaling-explorations/halo2wrong

[ ] Support with non-efficient polymul

Also rework of halo2wrong https://github.com/kilic/halo2wrong2 could be considered


[Workshop] Possibility to open a set for the workshop if the limit of places for the workshop is filled.

Environment: Windows 10, 64-bit, Google Chrome 107.0.5304.107.
Reproducible: always.
Preconditions
1.Registered Service Provider with the ownership form "комунальна".
2.The SP has a workshop with a set seat limit (for example 3).
3.The workshop has the status of "набір призупинено" as all places for the workshop are occupied.
Steps to reproduce
1.Log in as a SP.
2.Go to the "Мої гуртки" tab of SP cabinet (by clicking the button in the top right corner).
3.Click the "Відкрити набір" button on the workshop card.
4.Click on the "Підтвердити" button of the displayed confirmation pop-up.
Actual result
When the workshop is full, you can open the set again. There is no message about the lack of free seats and the need to change the number of seats for the workshop.

Expected result
When clicking the "Відкрити набір" button on the workshop card, a message appears about the lack of free seats and an offer to change the number of seats for this workshop.
Labels to be added
"Bug", Priority ("medium"), Severity ("medium"), Type ("UI, "Functional").

Fixed

Fixed


⚠ Bofrost.lu has degraded performance

In 9c7d5b1, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 957 ms

Resolved: Bofrost.lu performance has improved in b3420ad after 6 minutes.


Update permissions and remove simulation mode

Updates permissions to match https://github.com/stolostron/governance-policy-addon-controller/pull/6 and make setting the ownerRef work, and removes the simulation mode.
This PR should be synchronized with https://github.com/stolostron/klusterlet-addon-controller/pull/96 so that exactly one controller is managing the addons.

/hold

/unhold


[W4.4b][T09-A1] Koh Yee Ru

Change address to follow a strict format of a/BLOCK, STREET, UNIT, POSTAL_CODE.
Amend UserGuide and test cases as a result in places that involves addresses.
Add  /W or -w commands in runtests.bat/runtests.sh to ignore line ending and whitespaces when testing program.

@iNekox3 Some comments added. Please close the PR after reading comments.


Invader movement not saved

Moved direction control from player object back to invader sprites. Not sure why I did that in the first place!


[Docs] InternVL2 1B evaluation results

📚 The doc issue
Hello. I run InternVL2 1B on textQA following https://github.com/OpenGVLab/InternVL/blob/main/document/How_to_evaluate_internvl_chat_v1_5.md
GPUS=8 bash evaluate.sh model_ckpts/models--OpenGVLab--InternVL2-1B  vqa-textvqa-val-ocr --dynamic --max-num 24
and onlyget 0.6046 acc which is much lower than

the results you provide.

I would like to know if there is any problem. Thanks.
Suggest a potential alternative/fix
No response

I solve this problem by changing vqa-textvqa-val-ocr to vqa-textvqa-val.   It looks that the ocr tokens are not useful fir InterVL.

It would be highly appreciated if the authors could provide a readme for the evaluation of InternVL2. Thanks.🤔

Hi, the document of evaluating InternVL2 is provided at here:
https://internvl.readthedocs.io/en/latest/internvl2.0/evaluation.html


Suggestion - Presets

I was thinking. We should have preset that we can create and set for the sources.  I often switch between them and always find it hard to remember which ones I had set. Presets would eliminate that problem.  Here is an EXTREMELY rough example,

Here's the current interface I came up with and that can be found in nightly:

Not the most beautiful, but functional.

Function > Looks

One thing I'm concerned about is the amount of white space.


Remove the tested architectures from the README

The list of tested architecture is difficult to maintain exhaustive and
up to date. It ends up being confusing.

I specified that PBxplore needs weblogo 3. A more thorough test of the minimum version of weblogo that works with PBxplore might be usefull.


Pretty confusing typo

Hi, it's not really worth a PR but on 2nd line of the Usage section of your readme, I think you wrote 'lazygit' instead of lazycli;
Unless I misunderstood (in which case it should be clarified), this is a typo that can be very confusing!

whoops, serves me right for prefixing all my projects with 'lazy'. Fixed!


[FEATURE] add in-memory provider to SDK

Add InMemoryProvider to SDK. See spec.
Tasks:

add provider
add tests
replace e2e tests here with InMemoryProvider.

see Java equivalent.
Parent issue: https://github.com/open-feature/dotnet-sdk/issues/126

fwiw @toddbaert I'm looking at this, limited bandwidth, but interested in completing this

Hey @CommCody ! I've assigned you.
It's no problem if this takes some time. I'll keep it assigned to you for now.

@CommCody are you working on this?
This issue looks interesting and I will be happy to collaborate with you.

Mildly, I do have some work on my fork. My time is limited however, so I'm not very actively working on it.

Can I continue from where you left?

Can I continue from where you left?

@NeerajGartia21 if @CommCody has a partial implementation, maybe you'd be better off working on the Java reconnect tests, or on the Error enhancements in JS you recently commented on.

Cool, that sounds good.

Hi @toddbaert I was updating my code to further implement this issue, but now I can't build the main branch anymore. the build fails with:

E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to refer
ence them from your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs
E:\openfeature-dotnet-sdk\src\OpenFeature\OpenFeature.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to reference them fro
m your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs [E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj]

If I disable the following line in Directory.Packages.props my issues are gone:
    <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />

I have the following sdk installed: 8.0.101

Thanks @CommCody, there was a similar report over the weekend, so looking into this.

Fwiw I'm running these commands on windows 11. Directly against the dotnet cli.

@CommCody Hey! Unfortunately this has become a bit of a blocker.
If you aren't able to finish this in the next few days, would you mind if I take it over? I'm glad to pick up where you left off if you give me a branch, and will maintain as much of your work as possible, and make you a commit co-author.


InMemoryReadJournal.eventsByPersistenceId returns deleted messages

In commit 9ce9a6b "find deleted messages" you changed the way currentEventsByPersistenceId (and therefore eventsByPersistenceId) worked so that they now return deleted messages. I think the expected behaviour for them would be to not return deleted messages. I believe that's how your akka-persistence-jdbc library works, messages flagged as deleted are filtered out.
I stumbled across this while writing test code which was supposed to test that the correct messages we're being deleted, but the journal was always returning them despite the fact they were deleted.
So I think this is a bug, but could be wrong.
Thanks

Thanks for creating the issue. I'll take a look at it.

You were absolutely correct, it was a bug. It should be fixed in release v<IP_ADDRESS> and should be synced on Maven Central the following hours/days.

I've updated to v<IP_ADDRESS> this morning and my tests which were previously failing are now passing. Thank you for fixing the bug and for fixing it so quickly. Both this and akka-persistence-jdbc are great libraries.

Thanks!


MarkDown update: replace deprecated HTML tags

Description:

As requested in issue ticket #9449 (<strong> tags causing issue in localized articles), this Pull Request aims to remove HTML tags known to cause layout and readability issues in the MS Docs document pages, Frame Overflow being a frequent and obvious layout-breaking issue in translated articles.

Thanks to @TinaMcN for pointing out the issue itself and the most requested articles in need of correction to resolve this issue.
Changes proposed:

Replace HTML tag <strong> </strong> with its MD equivalent ** **
Replace single asterisk * with underscore _ (when combined with **)
Simplify usage of bold formatting (** **) to only the outer pair
Replace HTML tag <em> </em> with MarkDown underscore _ _

Whitespace changes:

Remove redundant end-of-line (EOL) blanks (trailing space)
Normalize spacing in numbered lists and bullet point lists to 1 space
Replace end-of-file (EOF) consecutive blank lines with 1 NewLine
Normalize layout spacing in MarkDown tables (consistency)
Normalize layout to 1 blank line after H2, H3, H4 headings
Allow up to 2 blank lines spacing (not 3 or more), ex. H1 page title

Additional notes:
There may be some more improvements in these articles than described above, both from the initial PR edits as well as from copy review (ideally performed by @JohanFreelancer9 and any of the MS Docs team members) during the review time of this PR. Feel free to suggest further improvements, preferably using the MS Docs conventions & codestyle.
Ticket closure or reference:
Closes #9449

#sign-off (for now)

#sign-off

Thank you for the follow-up, both of you. 👍🏼