Events Feed RSS to JSON

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-101
This is complete when:

[ ] The tockify RSS feed is converted into a JSON format for the mobile app
[ ] The event card displays the list of events
[ ] The detail vew of each event displays

I've created a rough implementation for this on my repo.
There are several issues I have encountered:

XML dependency version difference
The flutter_test dev dependency has a dependency for an older version of the xml package. This causes a version solving error as a new package I introduced, xml2Json, relies on a newer version of the xml package. I've removed flutter_test for now.

Some content provided by the RSS feed are causing issues
There are seemingly random backslashes in some parts of the contents returned from the RSS feed. They are causing format exceptions. All event information will not show up in the app until these are caught individually on a per-event basis.

Not everything that we had before is here
Unless I'm missing where they're at, a few things are missing that we previously had. Notably the link for the 'Learn More' button is missing. Instead a link to the Tockify event is given, and that page has the link to learn more.

Extraneous info
There's a lot of extra info given that isn't relevant. It was kept due to the conversion method used for XML to JSON. It's probably possible to get rid of it and clean up the events_model file but for now you'll have to sift through it.


Sortable list in a ruby on rails app using turbolinks

Hi,
I tried to reproduce the simple sortable list in a ruby on rails app. This app is using Turbolinks (https://github.com/rails/turbolinks). Turbolinks prevents the browser from recompiling the JavaScript and CSS between each page change. Only the body and title is changed, making the app a little bit faster.
Here is the problem:
When i load the page for the first time, my list is rendered correctly and react dnd works fine. However, if i visit the page for a second time,  the react components of my list are rendered, but the dnd part dont work anymore: when i try to drag and drop an item, the beginDrag function is executed, but no hover is detected. After that, when i try to drag for the second time, i get this error message : "Invariant Violation: Cannot call beginDrag while dragging". If i don't refresh the page, all the other attempts lead to the same error message.

Turbolinks prevents the browser from recompiling the JavaScript and CSS between each page change.

Browsers don't recompile JS and CSS on page change. I'm afraid this is not a correct description of what Turbolinks do. In any case, using React with Turbolinks seems very error-prone to me because both try to manage the DOM. React will freak out if something else changes the DOM.
It's hard to say something else without seeing a reproducing case, but we are unlikely to support this scenario anyway because it's contrary to how React works.

Hi @gaearon,
disclaimer: I am @m-baaziz manager
I would definitely agree with you to say that turbolinks and react do not play nicely with each other. However in this case, rendering the list in react works just great. This starts going wrong when we try to dnd our component for the second time.
It is perfectly ok for you not support this scenario, however would you have any idea of the cause of the problem ? Here is a detailed description of the issue :

Load the home page using cmd-R (the home page does not contain the sortable link)
Navigate to the list page: react  :heavy_check_mark:  and react-dnd :heavy_check_mark:. This is the first time the whole bundle.js file coming from browserify is loaded.
Leave the page and go somewhere else : turbolinks does replace the whole body upon each request without recompiling css and js. We are talking here about the standard js and css from our Rails app. The react part has been removed from the dom since we are no longer in the list page.
Come back to the list page without pressing cmd-R: The list is correctly displayed, so react :heavy_check_mark:, but react-dnd :heavy_multiplication_x:. This is the second time bundle.js is loaded.

The only assumption I see here is that bundle.js has a global state somewhere, and it is probably coming from react-dnd. Do you think it is what is happening ?
I anyone uses a pjax for example, and then tries to render a react component in this page, he could have the same problem.

We've worked around this issue by disabling turbolinks on this page, which is not a big deal

Can I ask you to prepare a repro case without Turbolinks?
e.g. simulate what it does to the page.

Will do. This is a good idea. In particular it might help find possible annoying bugs in react-dnd. By the way, this library really rocks
Sent from my iPhone

On 17 Sep 2015, at 17:17, Dan Abramov<EMAIL_ADDRESS>wrote:
Can I ask you to prepare a repro case without Turbolinks?
e.g. simulate what it does to the page.
—
Reply to this email directly or view it on GitHub.


Android: App crashes are being caused when checking if Crashlytics is enabled

Bug report

CHECKLIST

[x] I have read the issue reporting guidelines

[x] I confirm this is a suspected bug or issue that will affect other users

[x] I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.

[x] I have read the documentation thoroughly and it does not help solve my issue.

[x] I have checked that no similar issues (open or closed) already exist.

Current behavior:
Crashlytics is reporting app crashes caused by this plugin when it is checking if Crashlytics is enabled prior to logging an exception.
Expected behavior:
Checking whether Crashlytics is enabled should not cause a  native app crash
Crash stack trace:
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.app.Activity.getSharedPreferences(java.lang.String, int)' on a null object reference
       at org.apache.cordova.firebase.FirebasePlugin.getPreference(FirebasePlugin.java:2820)
       at org.apache.cordova.firebase.FirebasePlugin.isCrashlyticsEnabled(FirebasePlugin.java:1894)
       at org.apache.cordova.firebase.FirebasePlugin.logExceptionToCrashlytics(FirebasePlugin.java:3031)
       at org.apache.cordova.firebase.FirebasePlugin.access$1300(FirebasePlugin.java:115)
       at org.apache.cordova.firebase.FirebasePlugin$11.run(FirebasePlugin.java:784)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:919)

Hi, is this released? which version should I use? Because I started getting the same issue reported in firebase crashanytics and play console crash report. I have this in config file


Fix a bug that doesn't scroll to the desired tab if you quickly tap different tabs.

If a user taps on a tab, the desired tab animates to become at the center of the tab view.
If the user taps on another tab just IMMEDIATELY after the new tab is at center, nothing happens.
This is caused by the fade animation causing a block in responding to UI events.
The solution was to add the option UIViewAnimationOptions.AllowUserInteraction so that the tab responds to tap gestures.

Hi @DaniArnaout, thanks for your contribution!

Hi @azurechen, great job with ACTabScrollView. You can take a look of how we integrated it in our app Saily : https://itunes.apple.com/us/app/saily-buy-sell-preloved-used/id846198889?mt=8

Hi @DaniArnaout,
I am sorry I can't use your app because it show me "Saily is not available in your area yet", but I can play the game!
And your app looks so amazing!
However, It is a great pleasure for me that you use my lib to build a great product!
I am looking forward your app be available in my country!

@azurechen Yeah, the app is only available in the US. Check out this screenshot from  https://s3.amazonaws.com/sailybucket/open-source/ACTabScrollView/Saily.png
I'll try to help with this as much as my time permits. Thanks again!


Add Medical Operators

Description
Adds medical operators, and in general, the framework for other operator types.
Closes #62
Changes the dev packageId to proper format.
Problems
Mechanoids in the player's colony don't show up in a tab, so you can't assign them to areas
Possible solutions

Patch whatever handles the animal tab to allow operators in the list
Rely on a mod that adds mechanoids to the list

VFE - Mechanoids - Tab - Probably the best option so far
VFE - Mechanoids
Mechanoid Foundry
Mechanoid Reassembler

Code our own damn mechanoid tab

Probably won't be doing this, because that would be tedious.

Just don't worry about it.

Appears VFE-Mechanoid-Tab works with operators fine. Made an issue over on that repo to re-work dependencies on that mod, since it doesn't seem to explicitly require VFE mods to operate.
Can probably not worry about the tab, and list it as a recommended mod.

Update
Everything working as expected, utilizing VEF's Mechanoid comps for a charging base/dispenser.
Art Needed
Going to need an operator dispenser asset, non-rotatable (so just the south facing variant). Operator Dispensers are trapezodial tower-like machines that contain a pedestal for operators to rest upon.

There's one for each of the different operator types.


Investigate mean of each class

Mean in feature space, and mean in image space of:

IR
Radio
Where two classes are host galaxies and non-host galaxies

The mean IR image of each galaxy is the same, regardless of whether there is a radio source in that galaxy.
The mean radio image differs depending on whether there is a radio source, though this may be due to noise (low sample size for having a radio source).
Haven't done feature space, as I don't have a feature space yet, but I expect the same result.


Documentation for public API

Description

This PR includes code comments mainly for type definitions of parameters and return types.
Motivation and Context

This will make the developer experience a bit better.

How Has This Been Tested?

Travis CI passed.
Modified the exported constants unit test.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have read the code of conduct.
[x] I have read the contributing guide.
[ ] I have updated the documentation accordingly (if applicable).

Ill merge this one.


Add tests for analytics events

Context: https://czi-sci.slack.com/archives/C0247APK621/p1689975403873809?thread_ts=1689975111.876849&cid=C0247APK621

CC: @ainfeld @dsadgat
I think given the huge amount of analytics events we have now, I think we should start:

Adding testing analytics events as part of the e2e test requirements in the analytics issue template
Retroactively update e2e tests to test existing analytics events

For #2, maybe we can break it down by pages in this epic and just pull one ticket in every sprint or so?
Thank you!

Removing CI/CD label, since this is really about improving test coverage. While testing is under the CI/CD "umbrella", it's not strictly about enabling the mechanics of a CI/CD workflow.

@metakuni @dsadgat This is no longer considered CI/CD work (see above comment), so leaving up to regular work scheduling processes to prioritize this.


webview_flutter is not opening download links on android.

I've tried to click on a  download link on my android device in debugging mode. However, nothing happens. Is there any possible solution for this?
I'm currently using webview_flutter: ^0.3.22+1 . Tried the webview_flutter: ^0.3.22 but still the same.

I found a similar closed issue but it seems like the PR is for iOS and not android. Correct me if I'm wrong.

Hi @autumnlewjb,
Please provide flutter doctor -v and a minimal complete reproducible code sample that shows the issue you are facing.
Thanks.

Please provide flutter doctor -v and a minimal complete reproducible code sample that shows the issue you are facing.

While trying to make a reproducible code as requested, I noticed that I was able to open some links with target=_"blank" attribute. After some inspections, I found out that my issue is actually as described in the issue #39321 - problem opening download links.
Since the issue I'm encountering is posted and still opening at the time being, I think it's better to close this issue after mentioning the similar issue as mine.
A big thanks to @darshankawar for corresponding.


Add filter according to date in order grid.

Framework Version:0.1.1
Add filter according to date in order grid so that orders are filterable according to date.

Framework Version: 0.1.3
Added


Persist config choice by user in session storage

If the same content is used for multiple (configured) projects, the sidekick extension will show a config picker. Current.y the user choice is only persisted in the global window scope. Every reload will trigger the config picker again.
It would be more user-friendly to remember the selection for the duration of the browser session.

:tada: This issue has been resolved in version 6.19.0 :tada:
The release is available on:

GitHub release
v6.19.0

Your semantic-release bot :package::rocket:


Refactor Publisher, Admin, & Devportal theming directory and file name

Describe your problem(s)
We have to make the theming procedure/story constant across all the three portal and update the docs,
What we have to do is:

Change the name of the default theme file in the /site/public directory as userTheme to eliminate the confusion between defaultTheme.js file in the /source directory

Put the userTheme.js file inside /site/public/theme/ directory

@tmkasun , thanks loads for logging this Git issue based on our offline discussion.

Closing as per above commit message


Get arch and memory for OpenBSD

Add libsysctl support for OpenBSD : code imported from https://github.com/ibara/sysctlbyname
Get arch and memory for OpenBSD

Thanks for contributing to bsdfetch @lcheylus!


Fix bug with bias and slopes padding in ALiBi

After rearranging the shapes in https://github.com/lucidrains/x-transformers/commit/73a99f3d85a9b93cea6e09c721b66d555695d0cd, the number of unalibied heads was computed incorrectly and models with AliBi failed with RuntimeError.

@ilya16 :man_facepalming: oh yes, thank you! long time no talk and hope you are well :)


[NO-JIRA] Bump yard to 0.9.36 to address CVE

TLDR
Bumps yard to 0.9.36 (up from 0.9.32) to address a CVE flagged by Dependabot, and which is also surfaced on our operational dashboard.
Risks

Low, might break the gem.

This has already been fixed.


Development max

mainly refactored the output and other functions that were affected by the changes; fixed smaller bugs

Merged with PR #14


docs: document shielded pools consensus rules from 7.1.2 Transaction Consensus Rules

Motivation
We need to document all consensus rules.
Specifications

Designs

Solution
Closes https://github.com/ZcashFoundation/zebra/issues/3428
This also moves one rule that was in the wrong place (and it has a small mistake, which was already reported - I left the original wording), and adds one rule from https://github.com/ZcashFoundation/zebra/issues/3212 which is closely related.
Review
@dconnolly and/or @upbqdn
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

Follow Up Work

Accepting the suggestion dismissed the review, @upbqdn or @dconnolly can you reapprove?

This also moves one rule that was in the wrong place (and it has a small mistake, which was already reported - I left the original wording)

What was the mistake?

This also moves one rule that was in the wrong place (and it has a small mistake, which was already reported - I left the original wording)

What was the mistake?

I posted here. In section 3.6, the first consensus rule: "The Spend transfers and Action transfers of a transaction" should read as "The Spend transfers and Output transfers of a transaction". Should I open a ticket for it?


Update texld---ps-2-0.md

Fix minor coordinates typo

@Brimson : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Export createPlugin function by default on TS definitions

Proposed Release Notes

Update TypeScript definitions to export createPlugin function by default instead of a plugin instance

Links
Related to #144
Details
This definition allows us to use the plugin function as follows:
import createNewRelicApolloPlugin from '@newrelic/apollo-server-plugin'

@Module({
  imports: [
    GraphQLModule.forRoot({
      plugins: [
        createNewRelicApolloPlugin({}),
      ],
    }),
   // ...

With the current definitions, it's not possible to invoke the createPlugin function as needed, as the default export only refers to an instance.

Fixed the CI issue with this PR: https://github.com/newrelic/newrelic-node-apollo-server-plugin/pull/146

@luads merged in the fixes from the main branch. We just need you to sign the CLA via the CLA workflow tool so we can get this merged.
Thanks!

Manually tested, works! Merging...


refactor Xorshift128: remove eval, reconfigure types

This is my attempt at refactoring some of the code to get rid of eval. It also removes the functionality for "splitting" a 64bit RNG into a 32bit one (as this is actually more general than just this case).
Of course, you're free to take what you want, I just wanted to give an idea of how we can reduce the amount of metaprogramming.

Alright, I just followed the official approach, so there were the functions splitting 64bit to 32bit ones..

Maybe the SplitRNG stuff should be defined outside in common.jl?

Certainly, there's nothing specific to Xorshift there.


As a user, I want to be able to search for my friend in the friendbook

so that I am able to view all the details I have stored about him

Already tested and default implementation works alongside with FriendBook.
I will close this issue then.


This link is no longer valid

Thank you for your outstanding open-source work.
I have a few questions:
This link is no longer valid: https://faubox.rrze.uni-erlangen.de/dl/fiUNWMmsaEAavXHfjqxfyXU9/door.zip.
colmap_wrapper==1.1.5 is not compatible with the aruco-estimator project.

The link should now work again!
Unfortunately I have no quick answer for the colmap wrapper. My first guess would be to install colmap wrapper from source

The link should now work again!
Unfortunately I have no quick answer for the colmap wrapper. My first guess would be to install colmap wrapper from source

Thank you for your prompt reply. I have a small question: Is this the correct dataset? The mapping results don't quite match those described on the GitHub introduction page.

For the frustum you could decrease the size here: vis.visualization(frustum_scale=0.7, point_size=0.1).
And for the missing dense point cloud you can specify it while loading the colmap project. I guess this broke while modifying colmap wrapper


Added my data

First time contributor, hoping to learn more about open source.

Great work @NandoLofi


fix: use DigiThinkIT Travis badge

Pull Request Test Coverage Report for Build 1029

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-49.4%) to 0.0%

Totals

Change from base Build 1025:
-49.4%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


GitHub communication best practices

Author: Edward R.
EB member: Ross B.
Here is a possible article on communication best bractices on github
I brief read suggested a lot of interesting and useful tidbits.
For me, it helps me put the right thinking cap on when starting an action on GitHub.

@markcmiller86, I read the whole thing and I am in violent agreement.  Some great bits:

Email is a terrible, terrible collaboration medium, and an even worse mechanism for storing organizational knowledge.

The great thing about issues and pull requests, in contrast to say, email, is that they can be bifurcated when topics diverge.

I have been arguing some of this stuff  for years but can't see to get traction.  People just always revert back to using email when they should be communicating through comments in Issues.  Very frustrating.
And, I have argued for BSSw to:

Unless it’s a minor typo, so irrefutable that no one would possibly question it or need to be notified of the change, the only way to change community content is with a pull request. It doesn’t matter if it’s code, configuration, or internal policy.

But I also want to note that several of the items relate to weaknesses in it GitHub Issues compared to say JIRA.  For example:

Be mindful of noise

Use checklists to make blockers explicit

are workarounds for the weaknesses of GitHub Issues.  In JIRA, you can have minimal (or no) "Watchers" and then explicitly mention people you want to get emails about your updated comment.
I think it would be great to have a curated content article for this but have a disclaimer or two like this to note the weaknesses of using GitHub issues as a communication medium.

@markcmiller86, I read the whole thing and I am in violent agreement. Some great bits:

Email is a terrible, terrible collaboration medium, and an even worse mechanism for storing organizational knowledge.

The great thing about issues and pull requests, in contrast to say, email, is that they can be bifurcated when topics diverge.

To play devil's advocate.. Folks who have not used git, github issues and pull requests (think non-technical program/project managers) tend to find it intimidating! It does have a learning curve.

I have been arguing some of this stuff for years but can't see to get traction. People just always revert back to using email when they should be communicating through comments in Issues. Very frustrating.

Some reasons I have been given is that emails (1)  feel more personal, (2) limited distribution, (3) available offline on local machine, (4) not archived on the web....I see some value in these reasonings  for perhaps some topics but I agree that for collaboration, emails do not work! For ex: I simply cannot figure out the github issue discussions via the emails I receive.

@rinkug said:

For ex: I simply cannot figure out the github issue discussions via the emails I receive.

What do you mean?

@rinkug said:

For ex: I simply cannot figure out the github issue discussions via the emails I receive.

What do you mean?

I mean that its much easier to use the github web interface to read  and write comments coherently rather than trying to follow the issue conversations via the email notifications that one receives. This issue can perhaps be resolved by better formatting the github notification emails or putting more content in them - but in the larger scheme of things independent of github, emails are not the best method for facilitating discussion.

I mean that its much easier to use the github web interface to read and write comments coherently rather than trying to follow the issue conversations via the email notifications that one receives. T

In my opinion the best way to provide context is to do what I just did here.  You quote some targeted statement or question from a prior GitHub comment when you respond to it.  This should give enough to understand the context for that GitHub email.  To see the fuller context, just go to the GitHub issue itself.  This is much better than email threads.

I mean that its much easier to use the github web interface to read and write comments coherently rather than trying to follow the issue conversations via the email notifications that one receives. T

In my opinion the best way to provide context is to do what I just did here. You quote some targeted statement or question from a prior GitHub comment when you respond to it. This should give enough to understand the context for that GitHub email. To see the fuller context, just go to the GitHub issue itself. This is much better than email threads.

Agree!

@rusu24edward ... I would like to ask if you might be interested in reading the referenced article here and writing a short curated content article (a paragraph or two to introduce topic and/or summarize key points) for the bssw.io site? Let me know.

Ping @rusu24edward

Currently setting this to "Early October Issue". Might move it to later once new milestone tags are created and based on authors preference.

Sorry for my delay on this. Will have this done before October.

Just submitted through the contribution portal.

@rusu24edward said:

Just submitted through the contribution portal.

Where is that, specifically?

@bartlettroscoe, it looks like @rusu24edward used the form on bssw.io site. Those entries get routed on a google sheet in the ideas-ecp drive sub-folder.
I went ahead and grabed the text and have put it below...
Ben Balter’s article “15 rules for communicating at GitHub” presents exactly so: 15 communication rules that GitHub employees follow to improve their overall workflow, rules that establish a communication strategy from which modern software development can greatly benefit. From these rules, here are the key underlying points that stand out to me:
Be flexible with tickets. Many of us think of tickets as fully completed thoughts that require time and money to resolve. However, a ticket can be a question, a suggestion, an early idea that flowers into a great new feature, etc. A ticket is just the start of a conversation, and software teams can improve by cultivating an environment that promotes communication.
Asynchronous communication means that everyone can get involved in the conversation. Instead of notifying a single @employee, you can notify the entire @team on a distributed and easy-to-track platform (such as GitHub issues). This opens up the conversation to whoever on your team is willing to get involved. Which leads to the next point:
Only communicate if you can give time to the issue at hand.  If you have thoughts on an issue, you better have time to back up those thoughts before you share them. Otherwise, your comments can sidetrack or stall the conversation. As Balter says, “Avoid drive-by opinions.”
Finally, I feel it necessary to point out that having rules only matters if the team is dedicated to following them. I can think of many ways to break every one of Balter’s 15 rules. For example, you can enforce PR reviews by locking the merge button without approval, but this only matters if your reviewers are dedicated to actually reviewing the PR instead of blindly approving (say, because of a lack of time). For communication rules to effect positive change, the team must understand the context of the rule—why it is—and must agree to practice it. If so, then these communication strategies can provide a great boost in the pursuit of Better Scientific Software.
Eddie Rusu
Computational Scientitst
Lawrence Livermore National Laboratory

See PR #424


Drive transfer causes orphaned files/folders in root

gam user  transfer drive
The command reliably creates a folder for the user in the target account, to receive the transferred files/folders. However, with unpredictable inconsistency, not all user folders or files end up transferring into that target folder. Often (but not always), some files and/or folders are left in the target account Drive root (put better, some files/folders do not get the target folder ID applied to them as a parent attribute)
This prevents me from running scripts to handle scores of users at a time; I have to do each one, then move errant files or folders into the target folder the script does, at least, reliably create.
The implication is that such scripts need to always be superintended with a browser open to the target Drive account. That's rough when you have a couple hundred accounts to transfer.  It's also painful because while orphaned folders appear at the top of a drive screen above the folder they should be in, any orphaned files will appear only after the folders are listed -- requiring scrolling to check for each operation.
Yeah, I know -- it's a first world problem. Mostly I just need this to operate reliably, entirely unattended.

GAM has no visibility into the per-file transfer process and thus no way to fix this. You should test if the same issue occurs when initiating a transfer from the admin console and file a support ticket with Google.

It executes flawlessly (and also almost instantly for even large numbers of files) from Google. No orphaned files or folders at all (tried several users with large collections). Won't be able to troubleshoot much with Google on this.   ;-)
Is there no way to kick off the same process Google does, which appears to be some "just do 'em all right away!" process? The individual file transfer process just doesn't work reliably.
For me, anyway. I'd be interested to know whether anyone else experiences this.
I run into this problem with 10-20% of the accounts I transfer.

gam<EMAIL_ADDRESS>transfer drive<EMAIL_ADDRESS>only transfers files owned by old@domain and not in the trash. Does this account for the files not transferred?

No, that's not it. The files and folders all transfer OK. Occasionally, some just don't make it into the destination folder created for them. They're left lying in the root of the destination account.
Are sharing permissions retained for the transferred documents/files? The particular accounts I'm working with don't have any sharing on their files, so I'm not able to determine that -- although I can see that the source account isn't retained as an editor/viewer. It'd be nice if there were parameters for the command that would enable the original owner to be a viewer/commenter/editor, or to be removed -- as well as a separate switch to determine whether all other sharing were retained, or removed.
But the inconsistent performance is my main concern.

Send me an email at<EMAIL_ADDRESS>so we can try to test a theory
of mine.
Ross
On Wed, Jan 4, 2017 at 1:27 PM, rasqual<EMAIL_ADDRESS>wrote:

No, that's not it. The files and folders all transfer OK. Occasionally,
some just don't make it into the destination folder created for them.
They're left lying in the root of the destination account.
Are sharing permissions retained for the transferred documents/files? The
particular accounts I'm working with don't have any sharing on their files,
so I'm not able to determine that -- although I can see that the source
account isn't retained as an editor/viewer. It'd be nice if there were
parameters for the command that would enable the original owner to be a
viewer/commenter/editor, or to be removed -- as well as a separate switch
to determine whether all other sharing were retained, or removed.
But the inconsistent performance is my main concern.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/issues/378#issuecomment-270491632, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIU8L4-zD4X-SmiJbiZMvrgK_A_vsY81ks5rPA6_gaJpZM4LaA5Q
.

--
Ross Scroggs
<EMAIL_ADDRESS>

Hey guys.
I have a similar problem. What did you do to solve this case?
GAMADV-XTD3 6.31.09
Path: /root/bin/gamadv-xtd3/gamadv-xtd3


Nyx cycle changes

This pull request should be reviewed after PR 309.

To summarize, any changes that look like they would directly interfere with AMX/FMX rastering will not remain because it is not going to be used for the MD2 rastering code. We will likely split the rastering code into a different function to make the call with exporter. Those changes were never ever intended to be brought into master, and were not written to be.

we have agreed that to expedite the code review process, NYX-specific changes that are will affect AMX/FMX LSDC will be handled following the full approve of NYX for proprietary users.

None of this looks like it has any impact on data security?

Please see my comment just below yours - there seems to be only one place where data security could be an issue within this pull request. The comment refers to a new function used to write out images and is implicitly using the current working directory instead of explicitly using the visitDirectory

@mskinner5278 do you think you have addressed all of the issues with the pull request that have been brought up?

@mskinner5278 do you think you have addressed all of the issues with the pull request that have been brought up?

Yep, let me know if you want more changes added.


panic: E11000 duplicate key error collection

Hi,
i got an issue which come back again and again...
On 19th june from pm2 log :
tomox-sdk  | panic: E11000 duplicate key error collection: tomodex.orders inde                                                                                x: hash_1 dup key: { hash: "0x0061d1169f15bb504425021c2d01344fdb983cb2426f548423                                                                                561f3b800e28de" }
Today from pm2 log :
tomox-sdk  | panic: E11000 duplicate key error collection: tomodex.orders inde                                                               x: hash_1 dup key: { hash: "0x0662ac5fbc781630fea45f537bc5438b8a95a03888625ca80c                                                               9ddfb039604744" }
Each time, i have to delete docker container and volume and proceed to a reinstallation of mangodb.

fixed in https://github.com/tomochain/tomox-sdk/commit/031db915ddd90d5846c37061b7a324095e14545c

Is this get fixed with fast install procedure? i got the same error again, how can i update it ?

Now you just need to run the quickstart script to update tomox-sdk to v1.2.3

@thanhson1085 awesome, thanks


Item selection doesn't work in Bottom Sheet

If I try to select any item in horizontal carousel inside column of a Bottom Sheet, the selection/clickable doesn't work.

I don’t see how this could be something related with compose destinations 😅
what made you think it is?

I did a POC with Official Bottom Sheet (ModalBottomSheet - Material3) and Compose Destinations both.
Official BottomSheet was working fine but in Compose Destinations I was facing this issue.

In your PoC with material 3, was this bottom sheet registered as a navigation destination too? Meaning, could you navigate to it?

Official Bottom Sheet was not a Navigation Destination.
But other one was a compose destination

Ok, but if your other PoC was not using compose destinations, now you can use compose destinations with a material 3 bottom sheet as part of one of those destinations.
The style bottom sheet is not meant to replace the material bottom sheet. There are situations where you’d prefer one and situations where you’d prefer the other. It’s completely fine and expected to mix and match 🙂

Let me know how it goes for you ! Thanks you

Thank you for quick response and explanation @raamcosta


Elements with different namespace prefix are detected as DIFFERENT instead of SIMILAR

When comparing these two XMLs:
// Actual = <Root xmlns:x=""http://namespace.com""><x:Elem></x:Elem><x:Elem2></x:Elem2></Root>
// Expected = <Root xmlns:y=""http://namespace.com""><y:Elem></y:Elem><y:Elem2></y:Elem2></Root>

with "similar" behavior, it should return no differences. But it does report:
Expected element tag name 'x:Elem' but was 'y:Elem' - comparing <x:Elem...> at /Root[1]/Elem[1] to <y:Elem...> at /Root[1]/Elem[1] (DIFFERENT), Expected element tag name 'x:Elem2' but was 'y:Elem2' - comparing <x:Elem2...> at /Root[1]/Elem2[1] to <y:Elem2...> at /Root[1]/Elem2[1] (DIFFERENT)

Encountered in v2.5. @bodewig has already located the bug, see second-to-last post in https://github.com/xmlunit/user-guide/issues/12 for details.
Best regards,
D.R.

root cause see https://github.com/xmlunit/user-guide/issues/12#issuecomment-337508977
the fix will be to do the same as the Java version - and to write a Unit test :-)

I've just released 2.5.1, it is already available from nuget.org as well as https://github.com/xmlunit/xmlunit.net/releases/tag/v2.5.1

Very nice! Thank you for the quick fix! Will give it a try on Monday! 👍

I still ran into this problem although I was using 2.5.1. Then I tried 2.6.0 and tested with exactly the same xml as referenced above. For me it looks like the issue is still not fixed.
Error message was: Assert.IsFalse failed. Expected namespace prefix 'x' but was 'y' - comparing <x:Elem...> at /Root[1]/Elem[1] to <y:Elem...> at /Root[1]/Elem[1]


Adding yarn install path to %PATH%

For some reason, out of nowhere App Services stopped finding my npm executables, meaning that yarn could not be located.
The error will manifest itself something like,
...
remote: Verifying Yarn Install.
remote: D:\local\AppData\npm\yarn -> D:\local\AppData\npm\node_modules\yarn\bin\yarn.js
remote: D:\local\AppData\npm\yarnpkg -> D:\local\AppData\npm\node_modules\yarn\bin\yarn.js
remote: +<EMAIL_ADDRESS>remote: updated 1 package in 2.114s
remote: Installing Yarn Packages.
remote: yarn install v1.6.0
remote: [1/5] Validating package.json...
remote: [2/5] Resolving packages...
remote: success Already up-to-date.
remote: $ yarn run build
remote: 'yarn' is not recognized as an internal or external command,
remote: operable program or batch file.
remote: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
remote: error Command failed with exit code 1.
remote: Failed exitCode=1, command=D:\local\AppData\npm\yarn install --production
remote: An error has occurred during web site deployment.
remote:
remote: Error - Changes committed to remote repository but deployment to website failed.
To https://xxxxxx.scm.azurewebsites.net:443/xxxxxx.git
   d7de8b7..8d52910  master -> master

My fix was to add the path to NPM executables to the batch PATH environmental variable.
SET PATH=%PATH%;D:\local\AppData\npm

so it now looks like this,
:: 3. Install Yarn
echo Verifying Yarn Install.
call :ExecuteCmd !NPM_CMD! install yarn -g
SET PATH=%PATH%;D:\local\AppData\npm

:: 4. Install Yarn packages
echo Installing Yarn Packages.
IF EXIST "%DEPLOYMENT_TARGET%\package.json" (
  pushd "%DEPLOYMENT_TARGET%"
  call :ExecuteCmd yarn install --production
  IF !ERRORLEVEL! NEQ 0 goto error
  popd
)

I don't know if other's are experiencing this issue, but if they are, I hope this leads them here. I am not 100% sure if the path will stay the same in every scenario, or it needs to be set in a more dynamic way, else you should be able to use this small addition in these scripts.

I ran into this same problem yesterday. Unfortunately didn't see this issue in the repo or could've saved myself a few hours of troubleshooting :)
Anyways, came to the same conclusion that the PATH should also be set. I used the following snippet to set it in a more "dynamic" way:
FOR /F "tokens=* USEBACKQ" %%F IN (`npm config get prefix`) DO (
SET "PATH=%PATH%;%%F"
)

Basically, it calls npm config get prefix which should report the install location for npm packages. Then store that value in the PATH variable.
Final version:
:: 3. Install Yarn
echo Verifying Yarn Install.
call :ExecuteCmd !NPM_CMD! install yarn -g
FOR /F "tokens=* USEBACKQ" %%F IN (`npm config get prefix`) DO (
SET "PATH=%PATH%;%%F"
)
IF !ERRORLEVEL! NEQ 0 goto error```

Does this not result in the PATH constantly being made longer?


VScode lags on powerful PC

VSCode Version: 1.20.1
OS Version: Windows 10 Home 64-bit

Steps to Reproduce:
It has occured since a first-time clean installation. Every action (Input, selection, scrolling) has a small but very noticeable amount of lag (approx. 0.5s lag) every 10 seconds or so. This occurs on newly created empty files as well. CPU usage is normal (<5%) and RAM usage is normal (250mb).
PC Specs:
Intel Core i7-7700HQ 2.80GHz
8GB DDR4 RAM
Samsung 256GB SSD
(Nvidia GTX1060 GPU)

Does this issue occur when all extensions are disabled?: Yes

@OwenLearnsToCode
Does this reproduce using the insiders version?

@alexandrudima
I installed the insiders version just now, and upon testing, it had significantly less lag spikes. But it does still occur, though rarely.

@OwenLearnsToCode The insiders has the advantage that it is a fresh install of VSCode. Namely, it lacks your:

settings
keybindings
user profile (history and such)
extensions
opened folders (i.e. it starts with an empty window).

Is it perhaps one of the things above that would cause the slowdown?

@alexandrudima
Considering that I've been having the lag spikes ever since I freshly installed VS Code a few days ago, it shouldn't be one of those reasons. And speaking with my experience with other programs, usually performance issues don't result in sudden lag spikes.

@OwenLearnsToCode Can you create a profile when you notice something is laggy:
To get a CPU profile of the renderer process:

Run F1 > Toggle Developer Tools
Go to the three dots burger menu
Choose More Tools > JavaScript Profiler
Start a new CPU profile
Do the actions that lead to slowness
Save the CPU profile to a file and attach it

CPU-20180306T162417.zip
Here. After I started the profile, I began randomly selecting, highlighting and scrolling. It lagged once right before I stopped the profile.

@OwenLearnsToCode Thanks for the profile, but unfortunately I don't see any blocking activity taking more than 10 or 20ms. It all looks ... rather ... normal and boring. i.e. nothing stands out nor is blocking the UI thread...
So I am thinking the lag is not caused by the renderer process or, at least, not by our code running in the renderer process. I wonder if Chromium has compatibility issues with your GPU. Could you try launching code-insiders --disable-gpu ?

@alexandrudima
That might very well be the reason! The lag spikes were gone after disabling the gpu! Come to think of it, it's probably because of the dual GPU on my laptop. Is there a recommendation for a way of solving this? Meanwhile, I'll play with the GPU switching settings... Thanks so much

@OwenLearnsToCode
For GPU driver issues, it is best to seek help / report issues at https://bugs.chromium.org/p/chromium/issues/list . It is best if you can reproduce this lagginess in Chrome and report it there.
If you cannot reproduce in the latest Chrome, it could be that the incompatibility issues have already been resolved, as VS Code is on an oldish version of Chromium, v58.


Set Chart Height to 100%?

Hi, is there a way to set the chart height to 100% of the parents height? I am on version 0.2.4-Alpha as I am still using .NET Core 3.1.
I have tried to do:
options.Chart.Height = 100%
and set the component's height to:
Height = "@("100%")"
But neither worked for me.

Hi,
According to https://github.com/apexcharts/apexcharts.js/issues/140 it should be possible if the parent container has a set height.

Clean up


Import issue: for Exchange and ExtraFilters

When i tried importing Exchange and ExtraFilter is gave an error "cannot import name 'Exchange' from 'tvscreener.field'".

Looks like the Exchange was moved to tvscreener.filter


Standardise how we represent repositories in the Dev Docs

What
This PR changes our old applications.yml file to a new repos.yml file, meaning we can now explicitly add non-apps to the Developer Docs, such as govuk_publishing_components. The old Applications class is now Repos. URLs have changed too, i.e. /apps/*.html => /repos/*.html. An attempt to rename App to Repo was attempted, but proved problematic, so will continue in a separate PR: #3373.
Now, a repo is only considered to be an app if it is hosted somewhere. There are a couple of visual changes as part of this PR:
Applications on GOV.UK page

Before
After

Individual app pages

Before
After

Why
The former applications.yml file was intended for just applications, but over time, non-apps were added, in order to benefit from the documentation centralisation that the GOV.UK Developer Docs provides.
This situation was somewhat confusing for non-developer stakeholders and developers alike, when trying to ascertain how many apps there are and who is responsible for them.
The definition of an 'app' is somewhat woolly. On GOV.UK, an 'app' tends to mean something that is deployed to the standard GOV.UK infrastructure, e.g. a publishing or frontend app. This is in contrast to other things that could be considered an 'app', e.g. the Seal, and other things that could not be considered an 'app', e.g. govuk_app_config.
I initially considered breaking these down into separate YAML files, in #3300, to better name each group. However, this opened a can of worms - what do we name each group, how granularly do we break down groups, do we maintain alphabetical or chronological order, or subgroupings preceded with a special comment? - and it was decided in a Developer Tools meeting to simply stick to one list of 'repos' instead.
Trello: https://trello.com/c/oUsgzZnk/247-standardise-how-we-represent-repositories-in-the-dev-docs

@maxgds I can look at removing references to app_name in #3373 (where I will be renaming the App class to Repo). I had attempted to do so here, but it broke the build and is likely to require further changes like the app_name change you've suggested, so I think would be best continued in a separate PR. Quite keen to get this PR merged first, due to its size and also because any changes to the existing application.yml in the meantime will require a multi-commit rebase.
NB, I agree APIs don't feel like apps, but they are treated as apps in the context of our infrastructure, the fact we deploy them, etc. Because it's so subjective/contextual, I've opted to treat everything as a 'repo' as far as possible, rather than get caught up in naming and grouping (as I originally tried to do in #3300).

Both the ratonale and the code look good to me - I like the idea of repos and apps being separated out.
I am also a tad confused about some of the remaining variable names, but I agree given the size and momentum here perhaps we can merge this as the user-facing change and document a need for a separate tidy up ticket in issues?
You want me to approve or to get a few more 👀 on this first?

Thanks @huwd! I'd appreciate the ✅ so it's ready to go, but I'll give it another day or so before I merge (and will pop a reminder for people in Slack tomorrow if they want to review).

Thanks Kevin - I'll attempt to address those comments in #3373. 👍


Update typings

I have updated the typings to be according to the official "module-function" template
"comment-parser" is a module function since it exposes a single function to be called. (for future modules you make, please do not do that, since it is not compatible with the ES6 module import syntax)
https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-function-d-ts.html

If you want to see some example of Typescript code using "comment-parser" check my project repo if you like: https://github.com/jhm-ciberman/docs_gm/blob/master/src/parser/JSDocParser.ts

Awesome! Thanks for your contribution, will publish it soon

Thanks! If you need some help with this or other open source project in JS, please let me know 😄


bug: NavController pop immediately after Alert dismiss

Type: bug
Ionic Version: 2.x
Platform: all
My use case:
The user opens a feature that requires localization permission, so I show an ionic alert, explaining why.
If the user dismiss the alert, or cancels it, I go back immediately.
This is what happens:
Uncaught TypeError: Cannot read property 'nativeElement' of undefinedAlertPopOut
@ app.bundle.js:56628Animation.createTransition @ app.bundle.js:42002(anonymous function)
@ app.bundle.js:47954run @ app.bundle.js:1183NgZone.runOutsideAngular
@ app.bundle.js:17434NavController._beforeTrans @ app.bundle.js:47949(anonymous function)
@ app.bundle.js:47923run @ app.bundle.js:1183arguments.(anonymous function)
@ app.bundle.js:1581

    showConfirm() {
        const alert = Alert.create({
            title: `Location required`,
            buttons: [
                { text: 'Cancel', handler: () => this.cancelConfirm() },
                { text: 'Continue', handler: () => this.continueConfirm() }
            ]
        });
        this.nav.present(alert);
    };

    cancelConfirm() {
        //setTimeout(() => this.nav.pop(), 1000); //  it works
        this.nav.pop(); // Uncaught TypeError: Cannot read property 'nativeElement' of undefinedAlertPopOut
    }

I want to ask for an advice about how to use the Alert API, I found it horrible.

    showConfirm() {
        this.alertButton = 0;
        const alert = Alert.create({
            title: `Location required`,
            subTitle: 'Your location is needed in order to match you with people close geographfically. </br></br>Your location will NEVER be shared or leaked to 3rd people.',
            buttons: [
                { text: 'Cancel', handler: () => this.alertButton = 1 },
                { text: 'Continue', handler: () => this.alertButton = 2 }
            ]
        });
        alert.onDismiss(() => {
            console.log(this.alertButton);
            switch (this.alertButton) {
                case 0: // background dismiss
                case 1: // cancel button
                    this.cancelConfirm();
                    break;
                case 2: // continue button
                    this.continueConfirm();
                    break;
                default:
                    throw "bad state!";
            }
        });
        this.nav.present(alert);
    };

    cancelConfirm() {
        console.log("CANCEL!!");
        setTimeout(() => this.nav.pop(), 1000);
    }

    continueConfirm() {
        this.requestPosition();
    }

Since I also want to catch dismiss event by clicking the background I have to hack around...
it would be great if the onDismiss() callback returns an object like:
{
    "inputs": getValues(),
    "button": <<buttonid>>,
}

"button" == null --> dismiss by tapping background.

I'd recommend using the handlers on the button, instead of trying to put all your logic in the onDismiss. Have you seen these examples? https://github.com/driftyco/ionic/blob/2.0/ionic/components/alert/test/basic/index.ts

Also, can you not always navigate forward and rely on the cancel button to go back? Can you just have the alert come up, and if they click confirm, then you run your logic?

@adamdbradley

I'd recommend using the handlers on the button, instead of trying to put all your logic in the onDismiss. Have you seen these examples?

Using the button handlers is great sometimes, but how do I catch the dismiss event even when the alert is dismissed by a click in the background?

Also, can you not always navigate forward and rely on the cancel button to go back? Can you just have the alert come up, and if they click confirm, then you run your logic?

I could do that, but from a UI/UX view point, I want to use the page "blurred" content as a inceptive to make users accept localization permissions.
I want this:

User press the button.
User can the cool stuff behind the alert button! they want the alert to disappear, so they accept!

What if there was a role property that could be added to a button, and when the user taps on the background to close, it would fire the button handler that had role: 'cancel'? This way you wouldn't have to add in if/switch statements in onDismiss. I also think we'd change style on actionsheet to use role instead.

And one addition comment, any app that uses the Cancel handler like this: https://github.com/driftyco/ionic/blob/2.0/ionic/components/alert/test/basic/index.ts#L32-L39
to do something relevant is broken from the UI/UX view point if they do not handle the background tap somehow. And right now there is not a way to do it without hacking around onDismiss().

@adamdbradley

What if there was a role property that could be added to a button, and when the user taps on the background to close, it would fire the button handler that had role: 'cancel'? This way you wouldn't have to add in if/switch statements in onDismiss.

It could work, yes!
question: is there any situation where you have to handle differently cancel and background tap?
it is an open question, but if you think the answer is NO. then go ahead with your role idea!!

I also think we'd change style on actionsheet to use role instead.
I read it again :) yeah! good idea. I totally support the idea.

Ok, I think I'll add that in then. As far as the nav pop goes the reason you're having issues is because the page you're on and the alert share the same ion-nav, so when you pop while the alert is actively going out then things get confused. I'll be fixing it soon that overlays do not share the same ion-nav as pages which should solve your problem.

@adamdbradley great!
one more thing: for API completion, it would be great if the onDismiss() callback returns the role (optional):
onDismiss((input, role) => {} )

is that possible right? it would not break existing code!
role would be == "cancel" when background tap! simple, consistent and clean.

Good idea, I added to have the button's role passed as the second arg in the dismiss method.

@adamdbradley good job!
thank you for the awesome support and for this framework, i used to be a JS hater and now I am enjoying a lot building a high quality app with ionic!

I also made an example showing how you can dismiss the alert, then pop the page:
https://github.com/driftyco/ionic/blob/2.0/ionic/components/nav/test/basic/index.ts#L161
The challenge with trying to pop the navigation while also dismissing the active alert is that they share the same nav controller, which is actually a good thing when it comes to controlling pages and making sense of the stack. But if you pop the alert and immediately pop the page before it, there won't be a smooth transition. So it's better to pop the page after the alert has dismissed. Hope that helps.


Automated building and testing

Investigate alternatives to provide automated building of thunk modules and overall testing,

Since the need for the thunk module was removed using cdecl, the main goal now is to automate some testing.

Packaging can be automated on CI too now that DSS C-API has pre-built releases.


Close connections on cluster retryable errors

so that a new TCP connection is used to fetch new routing table
When server side routing is used with a load balancer using the same TCP connection will get you to the same back end. Even if the intervening load balancer has detected a problem it will not necessarily kill open tcp connections
closing the tcp connection and getting a new one after a cluster-retriable error ensures that you get a connection to a server that any intervening components think is healthy

I think your fix is spot on.
I just pushed https://github.com/neo4j-drivers/testkit/pull/248, so we may detect a similar issue with other drivers.

@fbiville FYI I leave this in your hands to merge / close / ammend as you see fit.
I just created this PR as a way to communicate my idea about a fix. I'm not intending to do actually do anything else with this PR

No problem, thanks for the initial fix. I'll wait for the Testkit PR to be validated before going further.


Share Multiple

Ability to share multiple images and videos.

shareToSocialMediaWithMultipleMedia method now provides this functionality! Sorry for such a long method name 😅


Add title description support to custom tree views

Re-opening for tracking the API.

@eamodio thanks for reopening this...
BTW, are upvotes necessary here too? 😁

Nah, this will hopefully be shipping in 1.50

Haha.. that’s great!
Thank you!


Enable multiple endpoints from configuration dialog

PyImageJ allows you to specify plugins in your initialization string. It would be nice if we could allow this also.
Unfortunately, I have no idea whether confuse and/or magicgui support List[String], so we'll have to find that out. If they don't, we will need to split the current string setting by a comma, or something.

The jgo convention currently is to separate multiple endpoints with the plus + symbol.

The jgo convention currently is to separate multiple endpoints with the plus + symbol.

Well, that's good to know, thanks!
In that case, it's probably as simple as documenting that this is how you do it in the configuration section of the README


refactor(lib/decoder): 优化变量名

const headerLength = type === RpcCommandType.RESPONSE ? 20 : 22;

第一眼看去，以为是header的长度。。。。

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f54c356). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   96.78%
=========================================
  Files             ?       30
  Lines             ?      777
  Branches          ?        0
=========================================
  Hits              ?      752
  Misses            ?       25
  Partials          ?        0

Impacted Files
Coverage Δ

lib/decoder.js
92% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c356...6a9f3c2. Read the comment docs.


Refine SPARQL query to ignore CORD19 triples

@matentzn could you have a look at this SPARQL query?
Before today's rebuild, this returned 30 or so rows, but now is including 30k or so CORD19 triples like this:
<http://identifiers.org/uniprot/P0DTC2> | bl:related_to | <https://www.example.org/UNKNOWN/CORD_027f86c44365e0ba6a6c26e24134c4c3e98a72ef>
Can you help me tweak this SPARQL query to ignore these triples?

FWIW, they CORD19 items are all bl:Publications that are provided_by “SciBite-CORD-19” - see for example results of this SPARQL query:
DESCRIBE <https://www.example.org/UNKNOWN/CORD_09de57e5401565a1e80361d32b09ce66b3a988c8>

closed by #227


[New game]:

🎮 Game Request
The objective of Pac-Man is to navigate through a maze, consuming all the dots while avoiding ghosts. Four ghosts, each with their own unique color and behavior, roam the maze. The ghosts are constantly chasing Pac-Man, attempting to capture him.  The player's goal is to score as many points as possible before losing all their lives.
Point down the features

Maze: The game takes place in a maze consisting of corridors, walls, and dots. The maze is typically displayed from a top-down perspective.

Pac-Man: The player controls Pac-Man, a small, circular character with a big mouth. Pac-Man can move in four directions (up, down, left, and right) through the corridors of the maze.

Dots(Pellets): The maze is filled with small dots that Pac-Man must eat. Each dot consumed adds points to the player's score.

Ghosts: Four ghosts, each with its own unique color and behavior, roam the maze. The ghosts are constantly chasing Pac-Man, attempting to capture him.

Lives: Pac-Man begins the game with a set number of lives. Losing a life occurs when Pac-Man collides with a ghost. When all lives are lost, the game ends. Lives are indicated by Pac-Man symbol at the bottom of the maze

Score: Every time Pac-Man eats a dot the score will be increased(initially it starts at 0) and the score will be reset if game is over. The Score is presented at the bottom of the maze

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Sampath-Vatsavaya !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Sampath-Vatsavaya ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Add automerge bot

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/zc.recipe.egg-feedstock#4.


_got-dir

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36032d47-681c-e39e-331a-14f178d7e583
Version Independent ID: 46c574db-a657-f2a9-9d0f-dfb9a83a124f
Content: Creating and Throwing Exceptions (C# Programming Guide)
Content Source: docs/csharp/programming-guide/exceptions/creating-and-throwing-exceptions.md
Service: unspecified
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

No feedback. Closing.


Error when trying to "View in 1Password" action

Diagnostic
Workflow version
2024.2
Alfred version
5.5
macOS version
14.5
Architecture
arm64
Preferences
Dict {
mod_cmd = open_and_fill
mod_none = view_in_1password
}
1Password version
8.10.34
op version
2.29.0
Launchd job
NOT loaded
NOT installed
Debugger output
[10:49:11.932] ERROR: 1Password[Automation Task] Task Error (127): /bin/zsh: can't open input file: /Users/(username)/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/Automation Tasks/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855

More details
The folder exists on my filesyste, but it seems to be empty:
$ ll /Users/(username)/Library/Caches/com.runningwithcrayons.Alfred/Workflow\ Scripts/Automation\ Tasks/
total 0
drwxr-xr-x  2 (username)  staff    64B 25 Jun 13:44 .
drwxr-xr-x  6 (username)  staff   192B  2 Jul 10:49 ..

Update the Automation Tasks then reboot your Mac and try again.

Too easy 😅, worked like a charm. Thanks for the quick reply!


How to disable GPU in Windows 10?

Hello:
I want to use your repo for upscale some videos (mp4 format).  But I don't have usable GPU.  For all those Python package using GPU, it simply not work.
However, my PC has 32-core CPU, so I think my CPU is powerful enough to run the program.
Please advise on how to disable GPU and run the program only on CPU.
I am using Windows 10 (Version 21H2) and my IDE is Visual Studio 2022 (Version 17.2.3).
Thanks,

Both PyTorch and NCNN backends can be forced to run on CPU.
For NCNN, just set the GPU id to -1.
In the case of PyTorch, you would need to install python in your system with all the required dependencies. PyTorch needs to be installed for use with CPU only.
In general, don't expect it to run any fast, even on your processor. CPU inference is slow in general.

Thanks!


data revision

[x] time zones
[ ] region codes
[ ] US airports
[ ] wiki links

Update Wiki links for languages and text excerpts starting with 872f931


Running on CPU without using GPU. In case there is no CUDA compatibility.

Is it possible to run this on a machine with no GPU? Also, is it possible to run it on a machine that is not CUDA-enabled?

I found a workaround for this.
You need to comment line 47, and edit line 137 in spiga/framework.py file.
line 47:
 # self.model = self.model.cuda(gpus[0])
and line 137:
# data_var = data.cuda(device=self.gpus[0], non_blocking=True) data_var = data


feat: Add support for Tags and Tag Categories

Adds support for tags and tag-categories to the Airtable Ingestor.
Also adds the ability to use the environment variable DEFAULT_UNLICENSED=true to make all the content unlicensed by default - currently it is set with the always license.

[x] Feature

Jira

https://ostmodern.atlassian.net/browse/SL-2227

Codecov Report

Merging #67 (031ee52) into main (824202c) will decrease coverage by 0.98%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   87.33%   86.34%   -0.99%
==========================================
  Files          67       67
  Lines        1421     1450      +29
  Branches      430      451      +21
==========================================
+ Hits         1241     1252      +11
- Misses        173      188      +15
- Partials        7       10       +3

Impacted Files
Coverage Δ

apps/media/hooks/useBrandWithSeasonBySlug.tsx
80.95% <ø> (ø)

packages/ingestor/src/lib/airtable.ts
100.00% <ø> (ø)

packages/lib/src/skylark/skylarkApiHelpers.ts
84.87% <20.00%> (-5.96%)
:arrow_down:

packages/ingestor/src/lib/skylark/sets.ts
84.05% <33.33%> (-7.61%)
:arrow_down:

packages/ingestor/src/lib/skylark/utils.ts
93.75% <75.00%> (-6.25%)
:arrow_down:

packages/ingestor/src/lib/skylark/create.ts
95.30% <78.57%> (-1.33%)
:arrow_down:

packages/ingestor/src/lib/constants.ts
100.00% <100.00%> (ø)

packages/react/src/header/header.component.tsx
73.68% <100.00%> (+1.46%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to use 2 inputs?

Basically I'm trying to run ffmpeg command
ffmpeg -i ready.avi -i k.wav -codec copy -shortest output.avi

It add audio to my video-file and that's it.

I'm not sure it'll work in this case, but global_args has helped me with multiple inputs in other cases.
  ffmpeg
  .input('ready.avi')
  .output('output.avi', codec='copy', shortest=None)
  .global_args('-i', 'k.wav')
  .run()
)```

Thank you! Only place on the internet to document such a common use case! I really wish ffmpeg-python could support this like
ffmpeg.input('video_only.mp4').input('audio.wav').output('output.mp4', vcodec='copy', acodec='copy')

try with
inv = ffmpeg.input('video_only.mp4')
ina = ffmpeg.input('audio.wav')
out = ffmpeg.output(ina, inv, 'output.mp4', vcodec='copy', acodec='copy')
out.run()

Amazing! It works well and is elegant. I like


Docker build with tags requires containerRegistry

Thanks for the updating the task to version 2. Unfortunately the task input and example for each command is still not clear enough :( I tried over and over to use build and push docker image separately, the tags I put during build kept missing when pushing.
Turns out, reading from https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/DockerV2/dockerbuild.ts, it requires containerRegistry  defined so tags will be added to the fully qualified image name to push. Can you please update this page as containerization in CI/CD is more common these days.
    let imageNames: string[] = [];
    // if container registry is provided, use that
    // else, use the currently logged in registries
    if (tl.getInput("containerRegistry")) {
        let imageName = connection.getQualifiedImageName(repositoryName, true);
        if (imageName) {
            imageNames.push(imageName);
        }
    }
    else {
        imageNames = connection.getQualifiedImageNamesFromConfig(repositoryName, true);
    }
    ...
    let tags = tl.getDelimitedInput("tags", "\n");
    let tagArguments: string[] = [];
    // find all the tag arguments to be added to the command
    if (imageNames && imageNames.length > 0) {
        imageNames.forEach(imageName => {
            if (tags && tags.length > 0) {
                tags.forEach(tag => {
                    tagArguments.push(imageName + ":" + tag);
                });
            }
            else {
                // pass just the imageName and not the tag. This will tag the image with latest tag as per the default behavior of the build command.
                tagArguments.push(imageName);
            }
        });
    }
    else {
        tl.debug(tl.loc('NotAddingAnyTagsToBuild'));
    }

Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d9dbf88-7e55-d427-145e-d36b04fb197f
Version Independent ID: a3f30c00-817c-9c05-7a57-3f2bf618821e
Content: Docker task - Azure Pipelines
Content Source: docs/pipelines/tasks/build/docker.md
Product: devops
Technology: devops-cicd
GitHub Login: @thomps23
Microsoft Alias: shasb

Unsure about your specific reason for wanting the build and push to be separate but I was able to follow the example under 'Build and Push' to login to both my Docker Hub & Azure Container Registry and then do one 'Build and Push'. This resulted in both of my registries each getting a copy of each image/tag combo. It sounds like this might be the behavior you're looking for?

My scenario is after all unit tests passed, I run the image as container then perform separate set of integration tests.
Images only tagged as latest and pushed to registry when all integration tests against a running container passed so I am sure that when Azure container service spin it up there will be no issue in containerised app.

I am able to run docker task (Run ) in background and task completes successfully. I am looking to stop container at the end of pipeline (Docker stop .....) in another task at the end of pipeline. I do not see stop command in docker task. Any suggestion to stop containers in docker task.

I agree with this issue. Docker build and docker tag dont require credentials (dockerregistry connection) to run. Why are they a requirement? If the team only wants to run docker build, why is a service connection required?

We noticed this too, while converting to yaml pipelines. We only use this task for building the docker file and then use an AWS task to push the image to ECR.
That means we cannot tag our image with the docker task.

Workaround is to pass --tag in build arguments like this:
--tag $(ImageTag)

Another case for separating Build and Push is also simply to pass build arguments, which is clearly indicated on this documentation page.
It happens for example if you want to use --build-arg, you can't buildAndPush then.

This cost us an hour to figure out. Please update the documentation.


begin to ucp-ify interlock service clusters

template image org and version
apply ucp service naming convention
drop -Debug from argument examples

Deploy preview for modest-edison-79d82e ready!
Built with commit 5e4dcb62d05965c4bbe96d146f94a25321632b96
https://deploy-preview-7238--modest-edison-79d82e.netlify.com

Todos for this section:

remove suggestion to deploy a swarm, since ucp already did this for the reader
check that proxy replicas defaults to 1, and increase it to 2 (otherwise updates would interrupt traffic)

... but those can follow-up.
@adamancini: ptal!

@adamancini : can you please review, so I know whether or not to merge this? thanks!


WIP update projects

Updates to projects after recent spacy-nightly refactors.
Trying to get the CI go back to green.

I think we shouldn't really have spacy-nightly itself as a requirement anywhere – that's likely just going to cause us problems down the line because the projects themselves are executed via spaCy already (and we now have a mechanism for specifying version dependencies if we need to: by setting spacy_version to a version range in the project.yml).
In the FastAPI project, the requirement was needed for the Docker setup, I think. We should probably add a note about that in the requirements.txt.

Quick status update:

I think the failure for the "speed" project on Windows should be fixed with the encoding fix in https://github.com/explosion/spaCy/pull/6234
The FastAPI & Emerson projects will fail until we've released new spacy-nightly models with the "strings.json" serialized

Update: test_textcat_goemotions_project should pass with the latest small fix I made to spaCy.

Yay, green!
I reviewed once more, and looks good to me.


revert front-load patches. add option to limit stack size

This reverts two patches that attempted to front-load the cost of evaluating arguments pushed onto the stack. They were both broken. The failures were detected by one of the fuzzers, but we don't run those on CI (yet, there's a separate PR for that).
In addition to reverting the two bad patches, a third commit splits outs parts if the LIMIT_HEAP flag into a LIMIT_STACK. This way the stack and heap limits can be employed independently.

this PR (running the fuzzers) demonstrate the failure these reverted patches caused: https://github.com/Chia-Network/clvm_rs/pull/235


tests/network: switch from 23.10 (EOL) to 24.04 (LTS)

@tomponline tests/network is not tested on GHA (so all red in CI is to be ignored) as it requires SR-IOV NICs. We usually run it through testflinger (on luma) but testflinger is in downtime this week.

We should get the non physical tests working in github too.

Just to be 100% sure, you are referring to the macvlan ones, right?

Yeah anything that doesn't require a physical nic


Failed to find instance type option (g4dn.2xlarge)

Version

Karpenter: v0.5.3

Kubernetes: v1.21.5
Expected Behavior

I created a provisioner with instance type "g4dn.2xlarge" and taint "gpu-worker" (both spot and on-demand)
I'm expecting to deploy pods with toleration "gpu-worker" and pods should be running on a "g4dn.2xlarge" node.
Actual Behavior

I confirmed that this instance type is available on the region, but karpenter does not spin up a node.
Steps to Reproduce the Problem

Create a provisioner with instance types "g4dn.2xlarge"
Resource Specs and Logs

2022-04-04T13:39:13.718Z	ERROR	controller.provisioning	Failed to find instance type option(s) for [testing-us-east-2/testing-us-east-2-master-mastermind-2]	{"commit": "5047f3c", "provisioner": "gpu-worker"}

Can you upgrade to the latest version v0.8.0 and see if the issue still exists?  The helm chart format changed somewhat between v0.5.3 and v0.8.0, there is some additional information about the changes at here

Could you provide us your provisionerSpec and enable debug logs on the Karpenter controller?

Can you upgrade to the latest version v0.8.0 and see if the issue still exists? The helm chart format changed somewhat between v0.5.3 and v0.8.0, there is some additional information about the changes at here

issue was resolved in v0.8.0
thank you!


Unable to resolve dependencies using gem install

When I try to install the mosql gem I get the following error
ERROR:  While executing gem ... (Gem::DependencyError)
    Unable to resolve dependencies: mosql requires bson (~> 1.10); bson_ext requires bson (~> 1.12.1)

There is also a problem with the mongo requirement which requires bson (~>3.0)
Instead requiring bson_ext (~> 1.10) and mongo (~>1.10.0) ought to fix the issue.  I was able to get it up and running by installing
mongo 1.10.0
bson 1.10.2
bson_ext 1.10.0

and building the gem. Don't know if this is cause by ancient repos or what, but figured I'd let some know :)

I just pushed a 0.4.3 – does that resolve your issue? Our dependencies in the gem are unfortunately sloppy at present :(

Yep! That works for me now.


SEO and Analytics in header

Hi,
As I mentioned in minima theme, there are couple useful things located in header like SEO and google analytics included, take a look: https://github.com/jekyll/minima/blob/master/_includes/head.html . Could you please also include these? It will be really helpful.
Thanks

Would you like to make a pull request to add these? 😄


Add More Apps to Shortcut Panel

Description of the new feature / enhancement
Hello, Dear Developers Team, I wanted to request an important feature that unfortunately is still not available for PowerToys. I love the program and the apps (tools) that it provides, but it would make the life a little bit easier and better if there was an opportunity to add my favorite tools to the "Shortcuts" panel. (basically, be able to customize it with my favorite tools). Because I could not find how to add some of the apps that frequently use to that Shortcut panel that appears in the right corner of the screen when you press the power-toys button in the system tray.
It would be super convenient! 🤩
Thank you for cooperation and thank you for making our lives easier.
Scenario when this would be used?
when I press the icon of PowerToys in system tray, and the Shortcut bar appears.
Supporting information
I would also suggest making possible enabling the favorite apps in PowerToys via shortcut, one of my favorite apps (tools) is Keyboard Manager, but there are some others I use quite frequently too, and none of them are available on the shortcut panel.

What apps would you like? The ones available are the ones that are invokable.

/needinfo

/needinfo

Dear Aaron, thank you for your reply. It would be cool if it is possible to make the shortcut panel fully customizable, so I can add any apps I like to it instead of the default layout (which is yes, good, but not exactly populated with tools that I use frequently).
To begin with, it would be really helpful to have a "keyboard manager" tool as part of the layout - it is the tool that I use most frequently:

I would appreciate any support you can provide in this regard.

I think maybe the ask is for an activation shortcut vs. a toggle to enable/disable?
If that is true, I would also like to see that.  For instance, I can never remember the chord to enable the Mouse Tools, but they are handy to enable on occasion - so instead of going into the setting of each to look at the activation chord, an activation toggle in this panel would be great UX.

/dup https://github.com/microsoft/PowerToys/issues/28680


Expose nanobus

Not sure if this is a wanted feature, but here we go.
Currenty bel is exposed so one can import it by choo/html. This expoes nanobus in the same way on choo/ee.
Main reason for this is that there are many places one would benefit from using an event emitter to do stuff in an application where the code is not directly bound to choo but the code lives among choo (example of such code can be code doing operations on a map).
If one have such, its desirable to be able to use the same event emitter, and version, as bundeled in choo to reduce the final bundle size. By being able to get hold of the event emitter in choo like this one will be a bit more safeguarded on this.

I was also thinking about exposing nanocomorph. There might be value in ensuring a consistent module version of some of the ingredients like bel, nanobus and nanomnorph.

Perhaps naïvely i just rely on npm to resolve this for me.  we use nanobus in a lot of our friend end and since npm 3 > dedupes on install we just install it along side.
Also a lot of our components don't rely on choo directly.  we install bel and nanobus since those are the components being used.
I'm not against this pr though

On vacation rn so I'll keep it short. Think I'd probably just rely on
importing it from npm because through deduping it means you'll only have
one copy anyway.
Bel is exposed b/c its required for choo to work as intended, exposing
nanobus isn't the case for that. Were using 10 or so deps, exposing them
seems a bit like clutter imho.
I know it's a small change, but I don't think we should merge this.
On Tue, Jul 25, 2017, 18:10 Todd Kennedy<EMAIL_ADDRESS>wrote:

Perhaps naïvely i just rely on npm to resolve this for me. we use nanobus
in a lot of our friend end and since npm 3 > dedupes on install we just
install it along side.
Also a lot of our components don't rely on choo directly. we install bel
and nanobus since those are the components being used.
I'm not against this pr though
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/choojs/choo/pull/536#issuecomment-317786153, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACWlei5F2aFCFLxXxyLxvjbtdNsfZFxSks5sRhNdgaJpZM4OiVj6
.

I don't have strong feelings either way.

Hello! I have two thoughts on this:

There's been discussion about possibly removing bel as a dependency to avoid the choo/? require pattern and reduce dependencies (see #617). I'd argue it's probably best to reduce the number of require endpoints dependent on file organization (preferably to zero), rather than create another one.

The instance of nanobus used by choo is currently exposed as choo.emitter -- while I understand the motivation to want to use the same nanobus module for other tasks to reduce bundle sizes, complicating choo's API might not be a price worth paying. Ensuring the nanobus version you're using is same as choo's and relying on npm to dedupe seems like a better strategy to me.


Internal performace (#154)

test(core): ⚡ Test diff

test(core): ⚡ Test msg/hook

Pull request template

Type of changes

[ ] CI
[ ] Bugfix
[ ] Feature
[x] Generic maintenance tasks
[ ] Documentation content changes
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no URL changes)
[x] Improving performance of the project (not introducing new features)
[ ] Other (please describe):

Issue Number: #146
What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

Few functions and such differences in parsing? :eyes:


Add Python 3.11 to the Github Actions

This needs to be added to the test and release actions.

Fixed in #65.


Write manual test cases for "SingaporePage: https://prayersconnect.com/regions/provinces?id=209&cid=3", and "FijiPage: https://prayersconnect.com/regions/provinces?id=15&cid=3".

Please write a manual test case for "SingaporePage: https://prayersconnect.com/regions/provinces?id=209&cid=3", and "FijiPage: https://prayersconnect.com/regions/provinces?id=15&cid=3" which involves breaking down the functionality of the webpage into specific steps that can be tested.
Please use this Google doc for your test cases.
https://docs.google.com/spreadsheets/d/1O1NJRmobfNfk6cGgc5BWHCMhRSjF6vJK3C-AljYxgHo/edit?usp=sharing

Manual test case link for Singapore:
https://docs.google.com/spreadsheets/d/1O1NJRmobfNfk6cGgc5BWHCMhRSjF6vJK3C-AljYxgHo/edit?usp=sharing
Manual test case link for Fiji:
https://docs.google.com/spreadsheets/d/1O1NJRmobfNfk6cGgc5BWHCMhRSjF6vJK3C-AljYxgHo/edit?usp=sharing
Manual test case link for Bangladesh:
https://docs.google.com/spreadsheets/d/1O1NJRmobfNfk6cGgc5BWHCMhRSjF6vJK3C-AljYxgHo/edit?usp=sharing
@LeonSubhan

Thank you


Check Wiki for hijacked links

Like our Wiki at LibreCAD yours has been hijacked too.
Check your Wiki history.
Especially commit 75bba70.
I checked this because the user neitann, who hijacked ours, has also a fork of OpenBLAS.
User neitann is already reported to GitHub support by me.
Also user rumiv, who did the last two commits in your Wiki, same as in our Wiki.

Right, thanks. It is a pity that the wiki here has quite poor security options.

It started even earlier.
https://github.com/xianyi/OpenBLAS/wiki/Installation-Guide/_compare/b8da0e8523b898a2206d1e2fe99dbfb4ebb0ffa8...c3b1ca5b4dc79d9a86588562cc214de62b21d563

First one is  cecf8cf
virustotal

I had blocked and reported the offending users to github support, after reverting the latest edit (which was hijacked again the following night, and again put back by me). Kudos to Isuruf for rewriting it as a proper interwiki link, I am now waiting for xianyi's decision whether to lockdown the wiki.


Port L2a -> L2b JPL II&T code: Divide by EM gain

There is some useful discussion about this in Issue #46 (which I'm closing, to have it superseded by this one).

Baseline is to simply used the commanded EM gain. Assume this is in the header. See "Data header wishlist" section in "Data Formats" page.

It is strange, in the cgi_iit_drp code they look for those keywords:
if 'EM_GAIN' in hdul[1].header:
em_gain = hdul[1].header['EM_GAIN']
if 'CMDGAIN' in hdul[1].header:
em_gain = hdul[1].header['CMDGAIN'] , so CMDGAIN would get the preference over EM_GAIN?

I believe CMDGAIN is the K-gain, not the commanded EM Gain. I've been.
Pushing to include that in the header as well.
On Mon, Mar 18, 2024, 8:15 AM JuergenSchreiber @.***>
wrote:

It is strange, in the cgi_iit_drp code they look for those keywords:
if 'EM_GAIN' in hdul[1].header:
em_gain = hdul[1].header['EM_GAIN']
if 'CMDGAIN' in hdul[1].header:
em_gain = hdul[1].header['CMDGAIN'] , so CMDGAIN would get the preference
over EM_GAIN?
—
Reply to this email directly, view it on GitHub
https://github.com/roman-corgi/corgidrp/issues/49#issuecomment-2004186957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEK2SJEU5RLMLC3VDZDEXKLYY4AHZAVCNFSM6AAAAABDSHXFUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE4DMOJVG4
.
You are receiving this because you commented.Message ID:
@.***>

As far as I understand this: The K-gain is the number of electrons per DN (unit e/DN), and the EM_GAIN is the number of electrons activated by a photon (unit e/photons), is this correct?

The EM gain is more of a electrons-out per electron-in-from-your-pixel as I
understand it (after the electron multiplying process). Your understanding
of K-gain is the same as mine.
On Mon, Mar 18, 2024, 8:26 AM JuergenSchreiber @.***>
wrote:

As far as I understand this: The K-gain is the number of electrons per DN
(unit e/DN), and the EM_GAIN is the number of electrons activated by a
photon (unit e/photons), is this correct?
—
Reply to this email directly, view it on GitHub
https://github.com/roman-corgi/corgidrp/issues/49#issuecomment-2004215266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEK2SJC32EGB3EWBZPYYJRLYY4BUBAVCNFSM6AAAAABDSHXFUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGIYTKMRWGY
.
You are receiving this because you commented.Message ID:
@.***>

Thanks, I see, it is the electron multiplication gain. So EM gain is number of electrons per photo-electron. Do we plan to have a unit keyword in the header, I don't find it in the data format document?

It is strange, in the cgi_iit_drp code they look for those keywords: if 'EM_GAIN' in hdul[1].header: em_gain = hdul[1].header['EM_GAIN'] if 'CMDGAIN' in hdul[1].header: em_gain = hdul[1].header['CMDGAIN'] , so CMDGAIN would get the preference over EM_GAIN?

EM_GAIN and CMDGAIN are the same thing, commanded EM_GAIN, it is a residual from different codes and I wanted the IIT wrapper to be robust to those two keywords existing in parallel and representing the same thing. From now on we should use the keywords described in that page: https://collaboration.ipac.caltech.edu/display/romancoronagraph/Data+Formats, so we can forget EM_GAIN. We should define a new keyword for the measured em gain but this keyword should be in the header of calibrated data instead of the L1 science header.

Thanks, I see, it is the electron multiplication gain. So EM gain is number of electrons per photo-electron. Do we plan to have a unit keyword in the header, I don't find it in the data format document?

Sure, you can add it to the data header wish list: https://collaboration.ipac.caltech.edu/pages/viewpage.action?spaceKey=romancoronagraph&title=Data+Formats#DataFormats-Dataheaderwishlist

When the EM gain is measured, it should set EMGAIN_M and EMGAIN_E header keywords to be the measure value and its error.

So I guess we need an additional function that calculates the EMGAIN and error? It would be good to raise another issue on this. I am a fan of being as modular as possible, that will help when it comes to debugging. So better more small functions than big functions.

Closing as this was implemented in PR #73


bug: failed to parse :host pseudo class

Did you check existing issues?

[X] I have read all the tree-sitter docs if it relates to using the parser
[X] I have searched the existing issues of tree-sitter-css

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)
No response
Describe the bug
I have installed the latest version of the parser (commit hash: 6a442a3cf461b0ce275339e5afa178693484c927)
When using the :host pseudo class without arguments, I get errors in the parsed tree.
https://developer.mozilla.org/en-US/docs/Web/CSS/:host
Steps To Reproduce/Bad Parse Tree
The following fails to parse:
:host {
    display: block;
}

This is the AST that I get when I use the InspectTree command in neovim:
(stylesheet ; [0, 0] - [3, 0]
  (ERROR ; [0, 0] - [2, 1]
    (class_name) ; [0, 1] - [0, 5]
    (ERROR) ; [1, 4] - [1, 5]
    (class_name) ; [1, 5] - [1, 7]
    (ERROR) ; [1, 7] - [1, 11]
    (ERROR))) ; [1, 13] - [1, 18]

If I write the following:
:host() {
     display: block;
}

It parses correctly.
Expected Behavior/Parse Tree
It's valid to write the :host pseudo class without arguments.
I don't have a lot of knowledge about writing grammars with tree-sitter but I suspect that this line may be the one causing the conflict:
https://github.com/tree-sitter/tree-sitter-css/blob/6a442a3cf461b0ce275339e5afa178693484c927/grammar.js#L183
Repro
:host {
    display: block;
}

/cc @amaanq , :host is really critical to css spec!

Hey @jordimarimon  are you going to open a PR with your change  https://github.com/jordimarimon/tree-sitter-css/commit/2b7ecb8ee7327ecaddc209c6037b65e63c3380c8 ? /cc @amaanq

Sorry for the late response @mohamedmansour, I didn't create a pull request because I wasn't quite sure that my approach for fixing the issue would be the best.
What I have done is make optional the arguments in some pseudo classes which may be desirable or not depending if it's a good thing for the grammar to accept more broader inputs.
I don't see it as a bad thing as I'm using treesitter inside neovim and in my case is for syntax highlighting, so I prefer the grammar to accept invalid CSS also, as this way when I'm in the middle of writting something, the AST doesn't have errors and the highlighting looks fine.
If it's okay for the maintainers of this grammar what I have done, I can open a pull request!

@amaanq CSS :host parameter is more broken than before now, can we merge @jordimarimon  PR in? Would love to maybe contribute to this repo as well since treesitter CSS needs better syntax support in Zed @maxbrunsfeld

@jordimarimon  can you please open the PR? And we can see how it goes

@jordimarimon  I tested your change and I am getting error, unless I am loading it wrong

Ah it does work @jordimarimon  I had to run npx tree-sitter generate before npm run install