Crystal added New Cyclic Sort Java Program with explanation and complexity.

Hey , I made Cyclic Sort Algorithm in Java Kindly review and merge to the main branch.

Good job!


auto Expand Attribute in config

Feature request: Maybe it would be a good idea to add another switch in the settings in the "More" section to restore the autoExpandAttribute function.

Good idea.


Issues/#1065 literal emptylang

Signed-off-by: Bart Hanssens<EMAIL_ADDRESS>This PR addresses GitHub issue: #1065 .
Briefly describe the changes proposed in this PR:

Throw an InvalidArgumentException when SimpleLiteral is created with an empty language tag
Added unit test

Another option would be to change the type to xsd:string when an empty language tag is provided, but that would probably be confusing

sorry for being so late with my feedback, but I could only now see the effect in an issue that popped up here recently. I am afraid this is not fully spec compliant, see:
https://www.w3.org/TR/swbp-xsch-datatypes/#sec-values-easy-examples

In addition, [RDF Semantics] explicitly sanctions identification of RDF plain literals without language tags with corresponding typed literals with datatype xsd:string.

So, I'd really prefer a transparent type fix than an Exception, which forces the caller to handle simple literal assignments in a try-catch block.

I don't think this has anything to do with compliance to the spec really: RDF4J allows you to create plain literals without language tags, and it identifies those with corresponding xsd:string-typed literals.
If you are calling ValueFactory.createLiteral(text, language) it's your responsibility to check that that language tag is legal (for performance reasons the ValueFactory doesn't do full language tag validation itself). The empty string is a bit of a corner case, admittedly, but at the end of the day it's the caller's responsibility.

Fwiw there is a feature request for convience "static factory methods" (see #1325), I'm thinking that more flexible support for this kind of case could be part of that.

Yes I agree @jeenbroekstra, just in our use case it was a bit awkward, since we wanted to call ValueFactory.createLiteral() always with a datatype, and that is actually forbidden and results in an Exception, because (this is true to spec) when using a language tag, the datatype is anyway fixed to rdfs:langstring. So yes, it was the callers mistake after all.


expose more methods on bluebird promise

Bluebird is a very appealing promise implementation. This is in part due to its synchronous inspection and fluent methods. To take advantage of this, I've exposed some more methods on bluebird promises which I would like to be able to use.

Coverage remained the same at 100.0% when pulling dd79bbbbc8a7d8486e7d94bb6a6e5216f0c52237 on stems:master into ba7a3202914110c36bdb98a2574584cf57d9bdd2 on request:master.

Hi @acarl005 , Bluebird-specific methods are not exposed because it risks naming conflicts with the underlying request library.  I hadn't realized the potential name clashing issue. In that case, using rp(...).promise().spread(...) is a perfectly acceptable workaround!

Alright, perfect. Have a great day!


every minute problem

Both following directive
every 1.minute ...
every '* * * * *'  ...
generate
0 * * * * ...
I am on c7675c81d34131f7107b2930c207c9b994895a08

my mistake, sorry


Per World GameRules not working

I'm using this link to get different commands for changing a gamerule for one world.
https://github.com/Multiverse/Multiverse-Core/wiki/Command-Reference#gamerule
I have a Minigame server and I also have a survival world, I want certain gamerules to be changed in the survival world so it acts like normal singleplayer survival.
eg, I have FireTick turned off and I have used the command
/mv gamerule doFireTick true Survival, and still when setting fire to a tree the fire does not spread even though MultiVerse has told me that FireTick is True,
Plugins that might conflict are worldedit, worldguard & essentials
I've gone through my configd and I can't see and conflicting settings.
Is there anything else I can try? I really do need this resloved.
Thanks.

No longer the case, ticket closed due to time frame.


Issues with dynamiclistener

Darren identified some flakiness with dynamiclistener which seems to be related to changes made.
This is impacting Rancher; the certs keep updating. This will require more investigation and resolution before v1.19.1 release.

From @brandond

K3s is using a branch of dynamiclistener with the expiration fix on it, but without the wrangler updates. It works for how k3s stores and loads certs, and the clients it communicates with. Darren pulled my change out of master to get Rancher working again.
At some point when wrangler settles down, we will want to move k3s off that branch back to master, and update everything to use the new version of wrangler. That will involve touching a bunch of stuff (k3s, helm-controller, etc) and as per @ibuildthecloud shouldn’t happen until after wrangler settles down a bit more. At that point we will need to find a fix that works both for k3s and rancher. I now understand what I did that is causing problems for Rancher, and can at some point update the fix so that it doesn’t break it. That doesn’t have to happen ASAP though, since nothing is blocked and we are fine with Rancher and k3s using different branches for the moment.
The problem has to do with Rancher not storing a copy of the dynamiclistener cert outside of Kubernetes (like k3s does), which means that it generates new key material every time it start up. This used to be handled by the merge code preferring the cert+key from the Kubernetes datastore, but I changed that to prefer the newer cert, which for Rancher uses a new key, which in turn makes browsers suspicious.

TL;DR - can ship 1.19 as-is. need to revisit later

Thanks, I had just come here to cross-post that ;)

This is a tech debt issue. May cause issues going forward.

At some point, we'll need to update wrangler, and this will come up then.

@brandond - upgrade to 1.22 might force us to update this

Will think about where this fits in with rancher/rke2#1026 and our general task for updating wrangler in the k3s-io ecosystem. I thought we had an issue for the latter but now I'm not finding it.


WIP: When picking, remove inapplicable projectors

What does this implement/fix?
Pick'ing may entirely eliminate a certain channel type from the resulting object. However, the list of projectors in info['projs'] will remain unchanged. This can lead to problems in later processing steps, where situations may arise where one is trying to apply a projector for a channel type that is not present in the data anymore.
MWE:
import mne
from mne.datasets import sample

data_path = sample.data_path()
raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
raw = mne.io.read_raw_fif(raw_fname, preload=True)

raw.set_eeg_reference(projection=True)
raw.pick_types(meg=False, eeg=True)  # Drop MEG data
raw.plot_projs_topomap()

With master:
A problem arises because although we dropped all MEG data, the MEG projectors are still present.
Traceback (most recent call last):
  File "/private/tmp/mwe.py", line 10, in <module>
    raw.plot_projs_topomap()
  File "/Users/hoechenberger/Development/mne-python/mne/io/proj.py", line 280, in plot_projs_topomap
    fig = plot_projs_topomap(self.info['projs'], self.info, cmap=cmap,
  File "/Users/hoechenberger/Development/mne-python/mne/viz/topomap.py", line 324, in plot_projs_topomap
    use_info = pick_info(info, pick_channels(info_names, ch_names))
  File "<decorator-gen-8>", line 21, in pick_info
  File "/Users/hoechenberger/Development/mne-python/mne/io/pick.py", line 489, in pick_info
    raise ValueError('No channels match the selection.')
ValueError: No channels match the selection.

With this PR:
The MEG projectors get removed during the pick:
Removing projector <Projection | PCA-v1, active : False, n_channels : 102>
Removing projector <Projection | PCA-v2, active : False, n_channels : 102>
Removing projector <Projection | PCA-v3, active : False, n_channels : 102>

WIP because

I'm looking for feedback, obviously
tests are missing
not sure if this would demand a deprecation cycle

Thanks!

, where situations may arise where one is trying to apply a projector for a channel type that is not present in the data anymore.

This actually shouldn't be a problem, it should just be np.eye in that case. If it breaks something it's a bug downstream that we should fix first (regardless of whether or not we do adopt the behavior in this PR)

If it breaks something it's a bug downstream that we should fix first

Ok, since there's a MWE in my first comment, we can use this as a bug report :)

… although the problem here is not exactly about applying a projector, but about plotting it!

Actually looking at the code and the problem, this probably is the right way to go. Let's get #8007 in, rebase this, and then see if we can fix any errors that crop op

Thanks @larsoner, I will pick up working on this shortly.
(current code also contains a bug, which I realized wile drafting #8003)

Will rebase on master after #8005 and #8007 have been merged.

Rebased on master.
In #8003, we changed the Note in del_proj():
        .. note:: The projection vector can only be removed if it is inactive
                  (has not been applied to the data), unless the channels it
                  was applied to no longer exist in the data.

Once this PR gets merged, however, the case "the channels [the projector] was applied to no longer exist in the data" shouldn't be possible anymore through use of the public API, right? Because the only way to remove channels is by picking, and this PR will ensure that picking also drops unusable projs. So I'm wondering if I should drop this part from the del_proj() docstring as part of this PR?

I tried to capture the warnings in a test but it doesn't seem to work -- pytest claims no warning of any kind has been emitted, even though the warnings do appear on stdout!
        with pytest.warns(RuntimeWarning, match='Removing projector.*'):
>           raw.pick_types(meg=False, eeg=True)
E           Failed: DID NOT WARN. No warnings of type (<class 'RuntimeWarning'>,) was emitted. The list of emitted warnings is: [].

Any idea what might be the issue?

Ok let's see what CI says… I'm worried I will have to handle the new warning in 123456 different tests individually…

… or I could just turn it into an logger.info. WDYT? Where do we draw the line between info and warning?

This to me should just be logger.info. warnings should be if it's likely someone is doing something bad that could break something. Nobody's code should break (in principle at least) because we remove projs that don't apply to the data

CI is failing because AverageTFR doesn't inherit from ProjMixin and therefore doesn't have a drop_proj() method. What to do about that?

I'm fine with keeping the drop projections as a separate function, but I don't see a good reason for _pick_drop_channels not to call it. I think it's less convoluted actually. pick_drop_channels should do everything required to pick and drop channels from an instance once you know the indices, one of which is (now) to drop irrelevant projectors.
Going in the direction you're advocating, we shouldn't even have a _pick_drop_channels but instead split it into one that picks just from info, one that just drops data if preloaded, etc., and replicate these calls four or five places now and more later if we add another mixin method that needs to _pick_drop...

@larsoner Ok, implemented in bed0dcd

CI is failing because AverageTFR doesn't inherit from ProjMixin and therefore doesn't have a del_proj() method. What to do about that?

@larsoner Any thoughts on this one? I've never worked with  AverageTFR  so I'm not sure what's the best approach here.

You could check to see if it has that attribute and only call it if it does

@larsoner Done

@larsoner This is good to go from my end. Let me know if you would like me to rebase.

Thanks @hoechenberger


fix(dropdown): fix default select

Describe pull-request
The dropdown option default select picks the wrong default option if one of the values is included in another.
Example:
export default function App() {
  const data = `[
    {"label": "Denmark","value":"1384"},
    {"label": "Sweden","value":"4"}]`;
  return (
    <div className="App">
      {/* 1384 is Denmark, but Sweden is selected in the dropdown*/}
      <sdds-dropdown-filter data={data} default-option="1384" />
    </div>
  );
}

See codebox for example: https://codesandbox.io/s/tegel-dropdown-test-wqzyqo?file=/src/App.tsx
Solving issue
Solving github issue #493 and Azure task AB#2427
How to test
I tested it by including the provided code example in storybook and made sure it worked, but didn't push that.
Start with looking at the code and see if it's a potentially good solution.
Screenshots

PS: Nice that the user provided codesandbox, however, there was a version 5 with a beta tag that is old and does not bring changes done in 4.10.1 - I changed it, but still issue is there.
It is more of heads-up.


Tiny fonts and UI glitches when using (super) high-resolution

I've tried the AGDX Studio on my Macbook's Bootcamp windows partition. I noticed that the editor font is way too tiny and the editor status bar shows cut fonts.
It could be the monitor is that retina display (4k) resolution, but even when I change to a lower resolution like 1600x900 the problems persist.
For the editor font, I couldn't find a way to increase the fonts, but I assume it will have something, right?

Does Bootcamp have DPI settings? Could you try 200% DPI?

I'll also add font size to the editor toolbar (and a new toolbar :) )

Added Inc/Dec font size in code editor.
(Use the Zoom In and Zoom Out buttons on the main toolbar)
Still need to update the icons to a scalable set

Added DPI fixes and Text zoom to Release 0.2.1


Consider safer access to deeply nested object properties

Currently, _formatAttachment and formatMessage parse received attachments and messages by directly trying to access deeply nested properties of the objects (e.g.: blob.story_attachment.media.image.width). This has the consequence that if any of the properties in this chain has a value of null/undefined, the access will fail with a TypeError.
One way to achieve safer access to such properties is to check if each one of them is non-null and defined, e.g.:
if (blob && blob.story_attachment && blob.story_attachment.media && blob.story_attachment.media.image) {
    return blob.story_attachment.media.image.width;
} else {
    return undefined;
}

Another alternative is _.get(obj, path) by lodash which allows us to do this:
_.get(blob, 'story_attachment.media.image.width')

and this returns undefined if any of the properties cannot be accessed.
I want to point out that this issue is not a bug report per se, but rather a request for consideration, since implementing this suggestion may make changes made by Facebook harder to spot and debugging harder.
However, if we evaluate which message properties are integral and absolutely necessary to be returned to the users of the API and which are somewhat okay to be missing or to return a default value (until there's a fix), we can make those format functions less fragile.

I don't disagree with this, anything that could be null should be checked and JS does not make that easy.   I started with exporting the .get functionality from lodash to see about replicating that, but honestly was over 100 lines and still was not done with all the imports.
Here is a simplified version I think would work well for our use:
/*
	Call SafeGet to get a value that may have a parent that is null.  Similar to lodash get.
	SafeGet supports two calling syntaxes:
		SafeGet(obj,"par1","par2","leaf");
		SafeGet(obj,"par1.par2.leaf");
*/
function SafeGet(obj /*, args */){
	if (obj == null)
		return undefined;
	var path = Array.prototype.slice.call(arguments, 1);
	if (path.length == 0)
		return undefined;
	if (path.length == 1 && path[0].indexOf("."))
		path = path[0].split(".");
	let index = 0;
	const length = path.length;
	while (obj != null && index < length) {
		obj = obj[path[index++]];
	}
	return (index && index == length) ? obj : undefined;
}

assuming @Schmavery agrees with the approach I can put a PR together. There is some performance hit,  lodash does cache the figuring out of the path, however ours is simpler and so I am not sure would benefit greatly from caching.
I would also recommend we move to allowing for 'failed' parsing of attachments.  Maybe try/catch the entire thing and if failed create an attachment_failed object with the attachment source and the exception message rather than the infinite loop it ends up in now.

@mitchcapper There is the npm package lodash.get that only has the _.get function exported.

@ivkos it is almost 1K lines of code, it handles a lot of use cases but I am not sure it is worth importing something so large for our simple cases.

Hey guys, I read this issue wrong the first time and didn't realize that the api is failing "in an infinite loop". Can someone clarify what happens? Many exceptions get thrown but the app doesn't crash completely? One way or another that shouldn't be happening, we only want one error per exception.
There are some great suggestions in this thread. I think that first things first, the main issue that's standing out to me is that we're getting "spammed" with errors that we can't catch (as far as I understand).  I think that at a high level, we should be not throwing from calls like listen(), instead catching any exceptions and calling the callback with an error. I thought this was already the behaviour but maybe something slipped up. If we do that, then unrecognized exceptions will still cause errors, but they should be ones that you can handle in your code (and then tell us about!).
I can understand the motivation behind wanting default values for fields.  However, in our experience, this leads to the api being incredibly difficult to maintain and debug because facebook can quietly change the format whenever they want.  We rely on our amazing users to help us notice when this happens and update the formatting functions in one place so that they don't have to update their own code.
This attempt to format attachments was a decision we made recently to try and give that same experience for attachments.  We formerly didn't format them at all and made users figure out how they were laid out. The ramp up to full support is a little rocky as we try and figure out what all the possible attachments are but hopefully, with all of your help, it can end up improving the experience overall

So I would have to check my code.  It probably isn't the api that infinite loops but I am guessing:

Api throws an exception when parsing the attachment of a message
My code auto-restarts the connection on error
The API re-reads the same message and trys to parse it again
So technically it is my code causing the loop but in reality:
*) We can catch the error.  Yes we shouldn't have any exceptions in parseAttachments if we 100% understand the API.  As you mention however FB can change the API so when they do I think it would be better to set an attachment_parse_failed field and provide the raw attachment object as another field.  Yes this is not useful for code that is expecting attachments, but would allow them to continue to operate until the library gets updated.
*) I agree that if we add something like SafeGet to prevent null accessors we may not detect API changes as fast as we throw fewer exceptions.  We would still get  bug reports that say image_width is set to undefined rather than the proper size.  On the plus side a small API change on facebooks part to a field name would not result in the entire attachment being unable to be parsed.  I see the argument both ways.

It is great to have errors/api changes noticed right away but it would also be fantastic if the library did not catastrophically fail in an unrecoverable way on any change.

I think we're on the same page here. The listen callback takes 2 arguments, an error and a message. In the case where anything in the parsing of a message fails, we should catch the exception and call the callback with the error (which can contain whatever we want, including the original attachment).
People should already be checking this error value, so an issue in parsing an attachment shouldn't cause the app to "catastrophically fail in an unrecoverable way on any change".

Ok so in checking my code I only restart the connection if the error status code is 400 (normally re-login) so the looping behavior is library driven.  If I understand your proposal it is to try/catch around the message parsing.  On failure call the callback with an error object containing the original exception and  the message that couldn't be parsed.
Correct?

That's right

@mitchcapper I've just tried your workaround (i.e. wrapping the formatDeltaMessage call in try/catch and calling the globalCallback with the error) and it works.
Although I don't really understand how listen() works, I think the underlying issue might be related to how listen() gets called recursively. But it would take way too much effort to refactor and will be hard to test.

@ivkos thanks a lot for trying it out. Can you make a quick PR with the change? I'm happy to explain more about how listen() works and drill deeper into this but would be nice to at least fix the bug for now.

@Schmavery #554

Closed for now by #554 and https://github.com/Schmavery/facebook-chat-api/commit/7552ce69561ac424cf6461e4c0cd8762ae2a7b9f. Thanks all.


[Bug Report] Interceptor may throw a IllegalStateException: cache is closed

I am using the following code to add a custom header:
    OkHttpClient.Builder builder = getBuilder()
            .addInterceptor(new Interceptor() {
                @Override
                public Response intercept(Chain chain) throws IOException {
                    Request request = chain.request()
                            .newBuilder()
                            .addHeader("Session-Token", accessToken)
                            .build();
                    return chain.proceed(request);
                }
            });

But sometimes I get an error:
Fatal Exception: java.lang.IllegalStateException: cache is closed
   at okhttp3.internal.DiskLruCache.checkNotClosed(DiskLruCache.java:635)
   at okhttp3.internal.DiskLruCache.edit(DiskLruCache.java:453)
   at okhttp3.internal.DiskLruCache.edit(DiskLruCache.java:447)
   at okhttp3.Cache.put(Cache.java:244)
   at okhttp3.Cache.access$000(Cache.java:135)
   at okhttp3.Cache$1.put(Cache.java:147)
   at okhttp3.internal.http.HttpEngine.maybeCache(HttpEngine.java:389)
   at okhttp3.internal.http.HttpEngine.readResponse(HttpEngine.java:633)
   at okhttp3.RealCall.getResponse(RealCall.java:241)
   at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:198)
   at co.voggle.core.ApiProvider$3.intercept(ApiProvider.java:149)
   at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:187)
   at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:160)
   at okhttp3.RealCall.access$100(RealCall.java:30)
   at okhttp3.RealCall$AsyncCall.execute(RealCall.java:127)
   at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
   at java.lang.Thread.run(Thread.java:818)

The error makes sense but I don't understand how to work around it, as I do not have the required objects in the intercept(Chain chain) method to check if the cache is closed or not.
It would be okay to drop the call if the cache is closed.
I am using OkHttp via Retorofit for my android application

Don't close the response cache?

@swankjesse I am not explicitly closing the cache, its probably getting closed by Retrofit.
I could catch the exception in chain.proceed(request) but then I don't know what to return in the intercept method. Would returning null be fine?

Retrofit knows nothing about the cache.
On Mon, Jun 6, 2016 at 10:54 AM Vedant Agarwala<EMAIL_ADDRESS>wrote:

@swankjesse https://github.com/swankjesse I am not explicitly closing
the cache, its probably getting closed by Retrofit.
I could catch the exception in chain.proceed(request) but then I don't
know what to return in the intercept method. Would returning null be fine?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/2605#issuecomment-223983479, or mute
the thread
https://github.com/notifications/unsubscribe/AAEEEbOXVJMT6Snk_ZKg5GHZkCEgdIBDks5qJDSJgaJpZM4IusBX
.

Maybe put a breakpoint in the Cache.close() code and see who calls that?

This is the code I use to setup OkHttp and Retrofit:
    OkHttpClient.Builder builder = new OkHttpClient.Builder();
    builder.cache(new Cache(new File(context.getCacheDir(), "ok-http-cache"),
            1024 * 1024 * 5)) // 5 MB cache
            .addInterceptor(new Interceptor() {
                @Override
                public Response intercept(Chain chain) throws IOException {
                    Request request = chain.request()
                            .newBuilder()
                            .addHeader("Session-Token", accessToken)
                            .build();
                    return chain.proceed(request);
                }
            });

    Retrofit retrofit = new Retrofit.Builder()
            .baseUrl(BASE_URL)
            .addConverterFactory(getGsonFactory())
            .client(builder.build())
            .build();

Now, how can I put a breakpoint or handle the exception?

+1, we have the same problem sometimes in our app.

With great pain, I am using the following hack:
                    Request request = chain.request()
                            .newBuilder()
                            .addHeader("Client-Key", CLIENT_KEY)
                            .build();
                    try {
                        return chain.proceed(request);
                    } catch (IllegalStateException ignored) {
                        LogWrapper.e(TAG, "error in client key interceptor", ignored);
                        // return a dummy response (that again has to be appropriately handled in the client)
                        return new Response.Builder()
                                .protocol(Protocol.HTTP_1_1)
                                .body(ResponseBody.create(MediaType.parse("text/plain"), "cache is closed"))
                                .request(request)
                                .code(CLIENT_INTERNAL_ERROR_CODE) // 599
                                .build();
                    }
                }

@vedant1811 are you certain you aren't closing the cache? Can you reproduce with a simple example or test case?

Yes I am sure :) This is the only place I use the OkHttp.Cache class (I searched and there was only 1 such import). It could be an issue in retrofit if not here.
I will try to make a simple example or test case to reproduce this.

Thanks. Looking forward to something that’ll help us figure this out

I have the same issue,how to resolve it

I have the same issue ,too,so anyone  can resolve that?

We are using the following code to add a header:
OkHttpClient httpClient = new OkHttpClient.Builder()
.addInterceptor(
new Interceptor() {
@Override
public Response intercept(Interceptor.Chain chain) throws IOException {
Request original = chain.request();
Request.Builder builder = original.newBuilder();
builder.header("Session-Token", accessToken);
Request request = builder
.method(original.method(), original.body())
.build();
try {
return chain.proceed(request);
} catch (IllegalStateException e) {
Log.e(TAG, "error in client key interceptor", e);
throw new IOException(e);
}
}
})
.addInterceptor(interceptor)
.addNetworkInterceptor(REWRITE_CACHE_CONTROL_INTERCEPTOR)
.cache(cache)
.build();
In Android M we have this problem. If storage permission in app is disabled and then enable this permission we get an error:
java.lang.IllegalStateException: cache is closed
at okhttp3.internal.cache.DiskLruCache.checkNotClosed(DiskLruCache.java:646)
at okhttp3.internal.cache.DiskLruCache.get(DiskLruCache.java:433)
at okhttp3.Cache.get(Cache.java:194)
at okhttp3.Cache$1.get(Cache.java:144)
at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:70)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:124)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.java:212)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:170)
at okhttp3.RealCall.access$100(RealCall.java:33)
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:120)
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)

@MariannaVR could you provide an executable test case to demonstrate the problem?

No obvious action to take on this.

@MariannaVR how to resolve it,please? thanks!


[TACHYON-1082] Remove unused Tachyon parameters definition from Tachyon.Constants

Just remove constants:
DEFAULT_MASTER_MAX_WORKER_THREADS
DEFAULT_WORKER_MAX_WORKER_THREADS
https://tachyon.atlassian.net/browse/TACHYON-1082

Can one of the admins verify this patch?

Jenkins, test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5899/
Test FAILed.

@shuhuai007 Thanks for the patch, could you clean up the git history? It seems like other changes got mixed in.

ok to test

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5936/
Test PASSed.

LGTM

Actually, it looks like there are other commits here. Could you clean up the state? Thanks!

I have remove  other commits

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5961/
Test PASSed.

+1 LGTM, thanks for the patch!


How to add custom Markdown syntax?

Hi,
First, thanks for MMMarkdown - it performs well and I think it's awesome!  I really appreciate you making this available!  :-)
I'm working on a Markdown app where I want to add a few features that are not directly supported by Markdown:

Hard page breaks
Font size control

So for example, I'd like to specify some Markdown like:
# Here is a headline

Some text

---

New page (--- acts as a page break)

--- tiny

Text is now tiny due to "--- tiny" tag

I'm not married to the use of --- or --- tiny, they could be whichever characters.  I just need to add these custom tags.
Can you please give me some pointers how you think it might be easiest to do this in MMMarkdown?  I'm happy to code it myself and offer a pull request if you'd like to add it back to the main codebase, but I was hoping you could point me in the right direction and suggest the code path most likely to be successful. :-)  Also, if you had suggestions as to which types of characters for my custom tags might work best I'd appreciate that as well.
Thanks again for making this great code available.
Best Wishes.

If you're adding new block tags (top-level content like a list or paragraph, not inner content like emphasis or strong), then you'll want to add them to MMParser. In particular, see _parseBlockElementWithScanner: and add your new element there. You may also need to add a new type to MMElement to return for your content and then add support for it to MMGenerator.
That's a rough guideline of how I'd go about it. Feel free to ask questions if you get stuck.

Thanks!  I'll take a look and if I end up adding some new tags, I'd be happy to writeup a Wiki how-to for the repo's wiki if that helps.


Document breaking getter interface

I'd propose to mention it in:

the release tag of v0.10
in the wiki

https://github.com/integritee-network/worker/pull/972

Mentioning this in the wiki is not that easy, because there is almost no RPC documentation. So I'm corssing that one.

The breaking interface is now mentioned in:

the release: https://github.com/integritee-network/worker/releases/tag/v0.10.0
the wiki: https://github.com/integritee-network/docs/blob/7d1202d5984be7e070c5017d15ac6560af4a6d95/4-development/4.4-sdk/4.4.6-rpc-interface.md#getter


Java 7 support for problems?

Reading the docs, I only saw support for Java 8.
Android requires Java 7 (doesn't seem to have integrated 8 yet)
http://developer.android.com/sdk/installing/index.html?pkg=studio
Would the attached gist issue be related to Java 7 Support?
https://gist.github.com/masters3d/12f973f262e957b2c998
Thanks

See pull request.


Resolution readout can sometimes print out all possible resolutions

In some cases, the resolution readout might return a list of possible resolutions rather than the current one. I can't seem to reproduce it, but here's an image of what this looks like:

Resolution is fetched in one of two ways:

through X11
through /sys/class/drm/device/modes

Resolved in https://github.com/Macchina-CLI/libmacchina/commit/48ab192467da813b539d2a70eb2f9b98a7c7ac1c


Support Alter Table Clause For External Table

5 alter operation be supported:

RENAME
ADD COLUMN
DROP COLUMN
MODIFY COLUMN
REORDER COLUMN

Fix #4697
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation Update (if none of the other choices apply)
[] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] If this change need a document change, I have updated the document
[x] Any dependent changes have been merged

This PR can also be applied with Elasticsearch external table. This is so good


Typos

http://opml.org/spec2.opml links to http://support.opml.org/basicOutlining, a page which returns a 404.
http://opml.org/history/aboutOpml11.opml In The Original Post, there are several <s which should be <s; this causes the text such as <cloud> and <head> to be invisible.

@mincerafter42 -- thanks for these notes, I believe I have fixed both.


WIP: feat/cli

[x] Bootstrap package.json
[x] Let template folder overwrite existing files
[x] Delete files/directories that should be cleared
[x] Add more validation for if it is secure to create project in the desired location
[x] Transform given keywords into array
[x] Validate author
[x] Validate package name
[x] Validate version name
[x] Bootstrap package name with given directory name

You can test as following
$ npm install -g<EMAIL_ADDRESS>
$ node-package-blueprint <some-directory>


fix: incident reportedBy from currently logged in user ID

Fixes https://github.com/HospitalRun/hospitalrun-frontend/issues/2539
Changes proposed in this pull request:
Access current userLoginID with Redux useSelector Hook (to fix issue https://github.com/HospitalRun/hospitalrun-frontend/issues/2539)
Get fullName user associated with userLoginID and show in 'reportedBy' in the report incident file.
Changed version lodash "4.17.15" to version "4.14.182" (to fix npm start issues)
Changed version chalk "^5.0.0" to version "~4.1.2" (to fix npm start issues)
Changed version types/node "17.0.0", to version "~15.6.1" (to fix npm start issues)
After fix:

@tehKapa Can you please review the PR. Thanks


query.proto edits for comments, non-substantive

just to make sure the many PR suggestions in the many forks and branches are captured in the development branch, I made the editorial suggestions here for query.proto
see comments in files changed view
Closes part of #177
Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

The develop branch that @barriebyron use on this PR looks very old. It has 135 commits behind. Merging with the latest develop branch doesn't seem to catch all the updates. Since this edit is trivial, it might be better to have another PR that is based of the latest develop branch. I'll make another PR for this.


Add '.drop' method

View rendered readme.md

@rultor merge

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)


chore: Remove lodash times in favor of foundation fn

See https://github.com/AztecProtocol/aztec-packages/pull/3775#discussion_r1444857703 for context

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 009f66d9 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,888
868,184
3,448,148

l1_rollup_execution_gas
866,997
3,746,237
23,304,913

l2_block_processing_time_in_ms
1,358 (+2%)
5,315
21,063 (-1%)

note_successful_decrypting_time_in_ms
526 (+1%)
1,133 (-1%)
4,158

note_trial_decrypting_time_in_ms
34.6 (+5%)
35.0 (-17%)
134 (-1%)

l2_block_building_time_in_ms
14,887 (-1%)
59,126
237,747

l2_block_rollup_simulation_time_in_ms
10,585
41,965 (-1%)
169,729

l2_block_public_tx_process_time_in_ms
4,269 (-1%)
16,921
67,690

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,965 (-3%)
29,755 (+2%)

note_history_successful_decrypting_time_in_ms
2,859 (+5%)
5,256 (-5%)

note_history_trial_decrypting_time_in_ms
92.0 (-32%)
180 (+20%)

node_database_size_in_bytes
3,615,902
3,721,400

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
210
44,709
25,561

private-kernel-ordering
136
30,953
14,809

base-rollup
1,074
128,374
881

root-rollup
82.3
4,088
889

private-kernel-inner
286
71,236
25,561

public-kernel-private-input
201
31,891
25,561

public-kernel-non-first-iteration
200
31,933
25,561

merge-rollup
9.66
2,608
881

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,487
31,878

Damn, totally forgot about this PR. Thanks @alexghr!

@alexghr fixed, can I get your review?


feat(connector): [Noon] Use connector_response_reference_id as reference

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
I have added reference that's sent to noon payments order to the TransactionResponse in transformer.rs of noon that's present in the connector directory.
https://github.com/juspay/hyperswitch/blob/main/crates/router/src/connector/noon/transformers.rs
Motivation and Context
Closes  #2339
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[x] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Hey @sudharsangs  :wave:,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!


CI测试

啥都没改

@Howard229 我们正在排查这个问题。

@Howard229 We have confirmed that Rocky 8/9 has upgraded LLVM related package to 17 recently, which breaks our CI because 17 is not supported by PostgreSQL 11 any more. So I removed the RPM packaging test in GitHub Actions in #515.
Thanks for your reporting, you can rebase your branch with POLARDB_11_DEV and go on. Happy hacking on PolarDB-PG :)

/reset


Single label detection

In my annotation file, I have two labels (cassava and weed). I'm performing 2 actions(filtering and renaming of the classes) and proceeding with a single label for model training.
Reasons for the above 2 steps:

Filtering one label because I don't know how to perform multi label
Renaming the cropname (cassava) as Tree because it throwed keyerror if kept as such

All other steps - training, evaluation and prediction are done as per the documentation. Kindly refer the file for more details.
Issue:

All objects are detected (though filtered out for one). If it is misclassified, it is fine but here it is not the case.
All are detected as tree and not as cassava

main.zip
Predicted Image:
sample_output.zip

Nice work on this issue @jyo94!

All objects are detected (though filtered out for one). If it is misclassified, it is fine but here it is not the case.

Distinguishing between these two will be a bit tricky without the multi-class setup since they are both plants that appear somewhat similar relative to the background. It would probably require a fair bit of training data to overcome this. There are some other approaches, but let's start with seeing if we can get your multi-class setup up and running.

All are detected as tree and not as cassava

You can change the label name for a single class model by setting the label_dict argument when creating the model
m = main.deepforest(label_dict={"cassava":0})

There's an example in the docs for birds.


bash auto-completion

Ubuntu 20.04
qpdf version 9.1.1
for file in *; do qpdf <Tab>

bash: compgen: warning: -C option may not work as you expect
basic_string::at: __n (which is<PHONE_NUMBER>3709551615) >= this->size() (which is 0)

Though just qpdf <Tab> works correctly..

After enabling bash completion (eval $(qpdf --completion-bash) since it is missing on Fedora), I can confirm this in Fedora 31 and 32. It is probably a general problem with the way qpdf's completion works.
qpdf is the only program using the -C option for completion on my system.

I was being lazy by using -C. It's not very robust and causes different problems with zsh. Probably the correct fix is to be unlazy when implementing completion. Using -C is better than nothing but not as good as it should be.

For what it's worth, aws cli also uses -C and has exactly the same problem. This may be a bash bug, and not a qpdf bug. Bash is passing a negative argument in a place where one would not be expected. I'll have to check the bash docs and make sure my expectations are not off.

I can still reproduce with 5.1.0 unfortunately, not sure which version you tested.
[red@cted ~]$ sudo qpdf bash: compgen: warning: -C option may not work as you expect
basic_string::at: __n (which is<PHONE_NUMBER>3709551615) >= this->size() (which is 0)

[sudo] password for da:
sudo: a password is required
[red@cted ~]$ for file in *; do qpdf bash: compgen: warning: -C option may not work as you expect
basic_string::at: __n (which is<PHONE_NUMBER>3709551615) >= this->size() (which is 0)
^C
[red@cted ~]$ qpdf --version
qpdf version 10.3.1
Run qpdf --copyright to see copyright and license information.
[red@cted ~]$ bash --version
GNU bash, version 5.1.0(1)-release (x86_64-redhat-linux-gnu)
[...]

Sorry, I can reproduce it. I accidentally tested it using zsh.  Anyway, it is at least partially a bash problem....but I can make qpdf sanitize the information passed in from bash, which it should be doing anyway, so I'll leave this open and fix that aspect of it.

Note to self: study this using my compgen example script...

I fixed qpdf's messing up on string bounds when given invalid inputs, but of course I can't fix that bash is giving qpdf invalid inputs. After this fix, you just get
bash: compgen: warning: -C option may not work as you expect

Too bad I used zsh by mistake and this missed the train for 10.3.2. Oh well. There will be another release at some point.

No worries, I don't consider this a high priority issue :wink: Thanks for taking care of it anyways, would be nice to have it fixed at some point.


VK_NUMPADx keys are not accepted if Numlock is off

Describe the bug
I maintain a driver for the Neo ergonomic keyboard layout (documentation is unfortunately all in German). Due to the complex layering system we need to remap all keys (including the Numpad) using a low level keyboard hook. Because the Windows keyboard stack sends weird fake Shift key events when Numlock is enabled, we automatically disable it, as we have our own mechanism for switching between numbers and navigation keys anyway. With Numlock disabled however, the calculator app doesn't react to VK_NUMPADx key events anymore. Almost any other application doesn't have a problem with that and just inputs the number as usual.

Steps To Reproduce
Disable Numlock and somehow send a VK_NUMPADx key event. No number is entered in the calculator window.
Expected behavior
The sent number appears.
Device and Application Information

OS Build: 10.0.19042.0
Architecture: X64
Application Version: 10.2103.8.0
Region: de-DE
Dev Version Installed: False

Requested Assignment
I'm just reporting this problem.  I don't want to fix it.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

This seems to be an issue across WinUI apps. I just encountered the same problem in the Mail app (VK_NUMPADx events cause the cursor to move there).


Processing after callback

I'm working with the Go shim right now.
I'd like to be able to response to a message very quickly but continue processing in the background. The API that is triggering this function will retry if it doesn't receive a response within 3s, so it is critical to respond before background processes complete or else I have do find a way to dedup requests.
The way I have it set up is after apex.HandleFunc completes, I wait for a sync.WaitGroup to complete before func main returns.
The problem with this is that as soon as the handler returns a result, the callback is executed on the shim.
Because the shim has ctx.callbackWaitsForEmptyEventLoop = false, lambda kills the process before the waitgroup finishes.
Is there any way that we can update the shim to accommodate this desired behavior?
I think ctx.callbackWaitsForEmptyEventLoop would have to be true, but when I've tested with this, the function just times out and doesn't stop which is why it was set to true in the first place.
Do you have any suggestions?

First, That seems like job queue. You can build your own task queue using Lambda with SQS.
In this case, This article might be helpful: https://cloudonaut.io/integrate-sqs-and-lambda-serverless-architecture-for-asynchronous-workloads/
Second, Lifecycle of Lambda function.
In this case, It would be nice if you read article that describing lifecycle of Lambda functions.
I recommend reading these two links:

Understanding Container Reuse in AWS Lambda - AWS Compute Blog
https://aws.amazon.com/ko/blogs/compute/container-reuse-in-lambda/

https://github.com/apex/apex/commit/1fe6e91a46e76c2d5c77877be9ce0c206e9ef9fb#commitcomment-20396626

From AWS docs: "By default, the callback will wait until the Node.js runtime event loop is empty before freezing the process and returning the results to the caller".
The callbackWaitsForEmptyEventLoop flag doesn't work as you have in mind, it simply allows you to write "sloppy" JavaScript which does not call callback() properly. So if you used wg.Wait() in the Go case it that would be fine, but there's no way to do background work in Lambda, you have to delegate to SNS/SQS/Kinesis etc as @mooyoul mentioned.

I should mention that you could also use https://github.com/apex/invoke to invoke.Async() another function to do the 'background' work. Async invokes appear to be powered by SNS, and will retry automatically (3 times) on error.

Thanks for all the answers. I addressed my issue by just invoking another lambda func asynchronously. However, it still seems like there should be some way to respond quickly to a request but still do a minimal amount of work after the response.

Definitely leave a note if you find anything, but I don't think that's possible now by-design, since it would have no way to report potential timeouts etc.


Build of mpich fails on freeBSD

With master, executing in top directory, gcc 7.0.0 specified in paths as shown. No installed mpich on this system. Script correctly attempts to build mpich and proceeds to download and compile the source.
If it matters:
$ cmake --version
cmake version 3.7.1
$ flex --version
flex 2.5.37
$ ./install.sh -c /home/jerryd/gcc/usr/bin/gcc -C /home/jerryd/gcc/usr/bin/g++ -f /home/jerryd/gcc/usr/bin/gfortran
... after a while compiling ...
/usr/bin/install -c -m 644 index.html /home/jerryd/dev/opencoarrays/prerequisites/installations/mpich/3.1.4/share/doc/mpich/index.html
install: /home/jerryd/dev/opencoarrays/prerequisites/installations/mpich/3.1.4/share/doc/mpich/index.html: No such file or directory
*** Error code 71
Stop.
make[3]: stopped in /usr/home/jerryd/dev/opencoarrays/prerequisites/builds/mpich-3.1.4
*** Error code 1
Stop.
make[2]: stopped in /usr/home/jerryd/dev/opencoarrays/prerequisites/builds/mpich-3.1.4
*** Error code 1
Stop.
make[1]: stopped in /usr/home/jerryd/dev/opencoarrays/prerequisites/builds/mpich-3.1.4
*** Error code 1
Stop.
make: stopped in /usr/home/jerryd/dev/opencoarrays/prerequisites/builds/mpich-3.1.4
2017-01-28 00:18:30 UTC [     info] Cleaning up. Done
2017-01-28 00:18:30 UTC [     info] Cleaning up. Done

can you add the the configure line? Also, were there any other errors or warnings? If you could upload the entire log that would be great.

install log
install-opencoarrays.log.txt

Well i meant what configure was passed to mpich... I should be able to pull it out of the logs... this looks like a task for @rouson probably, not sure I'll have much time for this anytime soon.

From the installation log, it appears the configure line was something like
/home/jerryd/dev/opencoarrays/prerequisites/downloads/mpich-3.1.4/src/mpl/configure --disable-option-checking '--prefix=/home/jerryd/dev/opencoarrays/prerequisites/installations/mpich/3.1.4' --disable-versioning 'CC=/home/jerryd/gcc/usr/bin/gcc' 'CXX=/home/jerryd/gcc/usr/bin/g++' 'FC=/home/jerryd/gcc/usr/bin/gfortran' --cache-file=/dev/null --srcdir=/home/jerryd/dev/opencoarrays/prerequisites/downloads/mpich-3.1.4/src/mpl

@jerryd Because this happens a ways into the MPICH build, this is probably something to post to an MPICH forum.   I'm unlikely to be able to sort out the issue.  If you have time, please contact the MPICH mailing list.  For now, I'm going to mark this as "won't fix" only because I'm not at all certain we can sort this out ourselves and you have access to package management so hopefully you can still progress.


feat(entity-link): allow links to open in same tab [MA-2617]

Summary
https://konghq.atlassian.net/browse/MA-2617

And the PR to update usage in the consuming app (Gateway Manager MFE):
https://github.com/Kong/konnect-ui-apps/pull/2455/files

@adamdehaven @portikM I cheated and added some internal padding on the ExternalLinkIcon, so that it ends up being the same size as the Copy icon:

I made the assumption (and correct me if I'm wrong) that this was just a tad too big:


Transfer views and urls from 'Classnote' app to 'accounts' app

We want to transfer all the views and URL mappings related to accounts present in classnote app to accounts app where actually they should be. Only views to be transferred and not the templates, the templates should have the same path as they have at present.

Cool I will do it. Please assign me this issue.

Sure! You're great to go!
Issue assigned to @IgnisDa

Issue fixed by @IgnisDa


babel uglify

https://github.com/RReverser/babel-plugin-uglify
This could potentially speed up the uglify part of the production compilation.
Haven't tried it myself yet.

Feel free to reopen after try out


fix: don't show docker section when using colima

Description

fix docker section on mac os systems with docker running in colima

LGTM. Thanks.

:tada: This PR is included in version 3.16.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


k8s journey: Deploy broker to production for new AWS Redis Service

As part of this journey we now need to deploy this new Redis service to production for CG user beta testing
Acceptance Criteria

[ ] CG Team review and merge staging branch into master
[ ] Verify CG Support and CG Customer Documentation is complete and in the correct place

Security considerations

[ ] Verify with cg-compliance members that SCR for new service was filed

Implementation sketch

[ ] Deploy broker change via pipeline
[ ] Validate prod broker is registered and working as expected
[ ] Build CG Customer documentation on how the customer can migrate their data from legacy to new service
[ ] Change log for CG Customers on what to expect with the new service
[ ] Deliver notice to CG Mgmt and CG BU that service is now live for beta testing

Closing item to create new smaller tasks to complete the ticket process in a more timely fashion


Comments: Let them use Cake

It would be great if you could share an example project that shows how to share common cake tasks.. Especially common.csx being used across different applications. Thanks!

Hi @nskerl thanks for the comment! I've added a basic repo to try and demonstrate the ideas in the blog post. https://github.com/CBurbidge/BuildLib
It's hard to generalise build tasks in a way which is better than the already set Cake aliases, so i haven't implemented much but I hope the project helps.
I've changed the structure a bit, Install.ps1 -> Init.ps1 and git.ignore is appended or created at the base project. The install.ps1 seems to being replaced by init.ps1 and after using a similar project I decided that appending the required things to the .gitignore is a better way to go.
The trick to sharing the library across projects is to create it into a nuget package and keep most of the logic in the common.csx file.
IMO it makes to keep as much stuff in there as possible. So instead of building an application version number in the build.cake file it makes more sense to have a method which retrieves it from the common code. This allows for company wide conventions to be codified without too much disruption from upgrading the packge to different version numbers.

Thanks so much! This is really helpful.


chore: disable issues and direct ppl to web-components repo [skip ci]

Description
All component-related issues (for any version of the component) should be opened either in the web-components monorepo (if it's reproducible with TypeScript and HTML, without Vaadin Flow / Java), or in the flow-components monorepo (if it's about the Java API). This repository remains open only to be able to release fixes for the versions of this web component used with Vaadin 10, 14 and Vaadin 19 for as long as they are maintained.
In order to make this clear for users, this PR

updates the README to make the role of this repo and its relationship with the the web-components monorepo very clear
disables new issues in this repo: any attempt to create a new issue here would direct users either to the web-components or to the flow-components monorepo

Related to: https://github.com/vaadin/components-team-tasks/issues/584
Type of change

[ ] Bugfix
[ ] Feature
[x] Internal change

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[ ] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Better header matching

Update from previous pull request: Used branch, added test.
isset() is not a good choice if the header is null. Headers shouldn't be null, but Guzzle is giving me null headers in my application. However, then isset($firstHeaders[$key]) is false, and thus it returns false. I've corrected this with array_key_exists.
Second, the checks for headers should be reciprocal. We should be checking that headers on the current request aren't missing from the cassette's request. My code isn't perfectly efficient... you could keep track of which comparisons have already been done. But it it works and is clear to read and understand I think.

On the url_stat stuff, it's a separate issue enitrely. I'm not sure how to exclude it from the pull request. I asked a question on how to deal with it on stackoverflow, so you can ignore it here. I'm sorry I'm new to pull requests like this, but I found some documentation on how to rebase a pull request to ignore this part.

Hey Tyler, thank you very much for this. I've simplified the request matching in this commit and took over your tests.
What is the the url_stat stuff about? :-) Can you create another issue for it please? It might be related to #33.

Released 1.2.2


Sign FParsec-Pipes with a strong name

Users of my library graphql-net are attempting to deploy to SharePoint and having troubles because FParsec-Pipes is not signed on NuGet:
https://github.com/ckimes89/graphql-net/issues/69

Check out 0.3.1.
This release features an improved name (up to 60% stronger) that won't bend or shatter under the strain of running in Sharepoint.


TBoxCSV type in the data uploader requires owl filename to be in the IRI

I believe the agreed prefixes for our ontologies should be in the form of https://www.theworldavatar.com/kb/ontosomething/, ending with a slash, not # or the owl filename. However, the data uploader does not seem to like that. If the IRI of the TBox does not contain the owl filename, it will throw an exception.
e.g. in usually the first line of our csv files,
OntoDispersion,TBox,https://www.theworldavatar.com/kg/ontosomething/,https://www.w3.org/2007/05/powder-s#hasIRI
will fail, and
OntoDispersion,TBox,https://www.theworldavatar.com/kg/ontosomething/OntoSomething.owl,https://www.w3.org/2007/05/powder-s#hasIRI
will pass.
I think using public void generateTBox(String csvFileNamePlusPath) instead of public void generateTBox(String csvFileNamePlusPath, String outputFilePlusPath) might solve this.

I don't think this error is coming from the data uploader as it just passes file names to the TBoxGeneration object. And that other version of the generateTBox method would only add the generation of the LaTeX file.
I think it is the manager.getOntologyFormat(ontology) argument in this line that is the issue. Setting that to .owl, or even better taking the extension from the owlFilePath argument, will probably fix the issue.


Port pyUSID.ImageTranslator to ScopeReaders.ImageReader

One question would be where this reader would live. Perhaps we need to make another sub package called other or generic. I would prefer generic since it prevents people from putting scientific Readers into something vague.

Tests need to be ported as well


ci: Fix build for nodejs binding on macos

We should only include daily used commands in package.json. For other commands, we can use yarn run napi xxx directly and document them if necessary.

We should only include daily used commands in package.json. For other commands, we can use yarn run napi xxx directly and document them if necessary.

🤣 This is too simple.

🤣 We should not run prepublishOnly on our local machine.

cc @suyanhanx for final review.


Consider changing sequence data filter for initial data pull from --updated-after to --released-after

Looking at this line: https://github.com/reichlab/variant-nowcast-hub/blob/57e41557dc41b92ca1b937be8e5cf6325bc819a2/data-pipeline/src/covid_variant_pipeline/assign_clades.py#L39
I am not sure exactly what the --updated-after filter does.  It's probably worth double checking that it reliably gets us everything we need.  It may be that using --released-after will get us to a safer/more inclusive data set that definitely includes all sequences with a collection date on or after the specified date.

The --updated-after was just a way to ensure a small subset of the data for faster iteration when testing everything.
In a live version of this, will we need to use any dates at all? I.e., would it hurt to download the entire set of COVID-19 (homo sapien) genome data each time the pipeline runs? I think I saw in the dataset CLI docs that they maintain a cache of that, and I'd like to explore it.

This change was merged into the variant-data-pipeline as part of https://github.com/reichlab/variant-nowcast-hub/pull/15


Provide More Flexibility in Federated Service DNS Naming

I am using Federated Service DNS with ExternalDNS to expose a Service from an Istio service mesh. The Istio Gateway resource is used to expose mesh applications outside the Kubernetes cluster. The Gateway resource is front-ended by a Kubernetes Service. More details can be found here.
MultiClusterServiceDNSRecord uses the name field to match the correct Service resource for creating an external DNS name and for the DNS A/TXT resource record prefix. For example:
Service:
apiVersion: v1
kind: Service
metadata:
<SNIP>
  labels:
    app: istio-ingressgateway
    chart: gateways-1.0.1
    heritage: Tiller
    istio: ingressgateway
    release: RELEASE-NAME
  name: istio-ingressgateway
  namespace: istio-system
<SNIP>
spec:
<SNIP>
  selector:
    app: istio-ingressgateway
    istio: ingressgateway
  sessionAffinity: None
  type: LoadBalancer
status:
  loadBalancer:
    ingress:
    - ip: $LB_IP

MultiClusterServiceDNSRecord:
apiVersion: multiclusterdns.federation.k8s.io/v1alpha1
kind: MultiClusterServiceDNSRecord
metadata:
  name: istio-ingressgateway
  namespace: istio-system
spec:
  federationName: federation-system
  dnsSuffix: daneyon.com
  recordTTL: 300

ExternalDNS Resource Records:
NAME                                                                                TYPE  TTL    DATA
daneyon.com.                                                                              NS    21600  ns-cloud-c1.googledomains.com.,ns-cloud-c2.googledomains.com.,ns-cloud-c3.googledomains.com.,ns-cloud-c4.googledomains.com.
daneyon.com.                                                                              SOA   21600  ns-cloud-c1.googledomains.com. cloud-dns-hostmaster.google.com. 1 21600 3600 259200 300
istio-ingressgateway.istio-system.federation-system.svc.daneyon.com.                      A     300    $LB_IP
istio-ingressgateway.istio-system.federation-system.svc.daneyon.com.                      TXT   300    "heritage=external-dns,external-dns/owner=my-identifier"
istio-ingressgateway.istio-system.federation-system.svc.us-west1.daneyon.com.             A     300    $LB_IP
istio-ingressgateway.istio-system.federation-system.svc.us-west1.daneyon.com.             TXT   300    "heritage=external-dns,external-dns/owner=my-identifier"
istio-ingressgateway.istio-system.federation-system.svc.us-west1-b.us-west1.daneyon.com.  A     300    $LB_IP
istio-ingressgateway.istio-system.federation-system.svc.us-west1-b.us-west1.daneyon.com.  TXT   300    "heritage=external-dns,external-dns/owner=my-identifier"

Instead of creating A/TXT records in the form of istio-ingressgateway.istio-system.federation-system.svc.us-west1-b.us-west1.daneyon.com, I would prefer these records represent the app I am trying to expose instead of the Istio Ingress Gateway. Can the name field in MultiClusterServiceDNSRecord either:
A. Only be used to match the Service and use annotations or labels to provide the DNS record prefix.
B. Only be used as the DNS record prefix and use annotations or labels to match the Service.

/cc @shashidharatd

@danehans, the naming scheme of the DNS record is designed to accommodate all services in all namespaces that are possible within federation and is designed to fallback to other zone, region if there are no service shards in current cluster.
However, i agree with your requirement as you expressed. So my suggestion would be that we include optional dnsPrefix field in MultiClusterServiceDNSRecord and when specified, the controller writes one more record like dnsPrefix.dnsSuffix for that federated service and include all service shards in all clusters as targets.

/cc @quinton-hoole2

@danehans @shashidharatd Just to let you know that I've seen this issue but not yet had time to digest it and reply yet.  There are a lot of moving parts and constraints regarding federated DNS, for example:

I seem to recall a practical limit of 6 components to a DNS record in kubernetes, and
resolution within a cluster, and between clusters needs to work correctly via CNAME records
there were some security considerations regarding hijacking of DNS records between tenants, by e.g. crafting special service names and/or federation names.

I think that the federation-v1 solution addressed 1 and 2 but not 3.  Current federation-v2 probably the same.  It's not clear which of the above @danehans adheres to. It seems at least 1 gets violated?  Perhaps give it some more thought in light of the above until I have more time to digest it all.

I like @shashidharatd's idea of using dnsPrefix. If dnsPrefix is not provided, then the prefix of the resource record is constructed using the value of Name. With that said, I would like to get feedback on the  idea of adding FederatedServiceDNSRecord so multiple MultiClusterServiceDNSRecord's that simply differ by dnsPrefix can be managed as a single resource and use overrides to manage the differences.

I like @shashidharatd's idea of using dnsPrefix. If dnsPrefix is not provided, then the prefix of the resource record is constructed using the value of Name. With that said, I would like to get feedback on the idea of adding FederatedServiceDNSRecord so multiple MultiClusterServiceDNSRecord's that simply differ by dnsPrefix can be managed as a single resource and use overrides to manage the differences.

overrides is for variation of resource across multiple clusters. I am not clear about achieving what you are asking for.

@shashidharatd adding dnsPrefix to the API was a big help. However, I believe it's even more helpful if this prefix was used to create additional zone/region specific resource records. This will allow users to have a consistent prefix with Istio resources that control ingress/egress traffic. I propose using the <dnsPrefix>.<namespace>.<federation>.<svc>.<avl-zone>.<region>.<federation-domain> if <dnsPrefix> is specified in ServiceDNSRecord instead of <svc>.<namespace>.<federation>.<svc>.<avl-zone>.<region>.<federation-domain>. I believe this will help for any service that gets exposed through a service/ingress controller (i.e. NGINX). Thoughts?

@shashidharatd I'm not fully convinced this should be closed yet. I feel we can still provide a better UX. This is the ServiecDNSRecord that I must use for the federated istio use case:
apiVersion: multiclusterdns.federation.k8s.io/v1alpha1
kind: ServiceDNSRecord
metadata:
  name: istio-ingressgateway
  namespace: istio-system
spec:
  domainRef: external
  dnsPrefix: bookinfo
  externalName: bookinfo
  recordTTL: 300

If externalName is specified, what are your thoughts about also creating a CNAME record like what  dnsPrefix provides?


Ignoring hidden properties is impossible

I have an ugly class structure where type B inherits from type A and hides some properties using the new keyword.
When I ignore this property, HotChocolate adds the property from type A instead of leaving it out completely.
I have added a test to this PR that demonstrate this. I hope you can find the best way to fix it.

Thanks for your effort.

Never mind.


duplicate building-an-image.md for java

Use Ubuntu first and install all the things (bloat)
Then refine the layers for minimizing container size (alpine or maven base, combining commands)


Bug Report - Weird effect on down icon

Environment
Microsoft Windows [Version 10.0.18362.207]
Windows Terminal version (if applicable): 0.2.1831.0

Steps to reproduce
Open Windows Terminal,
Click on down icon,
Instead of having the effect on the dropdown, it was highlighted on both plus and down icon,
There was a delay from the effect too,
The down icon was highlighted but after 0.5 seconds later the plus icon gets highlighted too.
Apart from that, I am wondering if the dropdown is supposed to fit the side of the terminal?
Expected behavior

Instead of adding effects on both icon, add it on the icon that was being clicked.
OR
The delay of the effect should be eliminated.

Actual behavior
Screenshot belows show what it looks like:

Actually this makes sense, because by clicking dropdown button you're having options to create new tab with selected shell 🤔

This is just how the "SplitButton" works. Sorry!


ci: work towards using GitHub actions

Travis CI sadness

Not waiting for win/appveyor feedback here. GHA feedback looks great. Merging.

Not waiting for win/appveyor feedback here. GHA feedback looks great. Merging.


Show a Dialog after each link is created

What is the current behavior?
"

[ ] Implements a share button to share URL.
[ ] Implements a QR Code scan.
[ ] JPG image sharing not fixed.

What is the new behavior?

When the URL card is created show the share dialog.

Added a share button to the card for sharing the URL.

@paultech4u thank you soo much for the PR! 🥳🥳🥳 Can you please make it so that the dialog box has the short url (only the code) part in bold in the centre above the sharing options with the copy button on the right of the short url and when clicked it should automatically take the current domain, like it already does and shows a small message that it has been copied :)
Also there are a lot of conflicts in your PR with the master branch, I request you to pull in all the latest changes and test the url sharing again and then commit.

The short URL is the same as the custom URL the problem now is that the short URL is not a valid URL I don't know if you are aware of these

issues.

@paultech4u I didn't get you there, you mean if i enter the long url in the short url as well, its not valid? Because the screenshot shown only material in short URL

@monizb I have resolved all the in my branch please do check it.

@paultech4u still looks like you have many conflicts, please rectifiy them im adding the accepted label as of now

@monizb I have resolved the issues.


PHP: Third-party package for 5.4.0+

There are third-party packages, such as delight-im/PHP-Cookie, which supports the SameSite attribute and the None value (since v3.2) on PHP 5.4.0+.

I'll drop this in, thank you!


Committing assignment 2 - please ignore merge conflict, it is caused by Holly fixing bug on main branch which I've dealt with prior to her commit

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completing Assignment-2
What did you learn from the changes you have made?
KNN can not be the solution to all stats problems
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
maybe use logical models
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Didn't understand random.seed, but google taught it
How were these changes tested?
ran the code
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

Please ignore merge conflict, it is caused by Holly fixing bug on main branch which I've dealt with prior to her commit

Thanks


Setup UI runs dkg

This code is a mess, but it runs. It was used to do a demo at Adopting Bitcoin.
Got it rebased and now just need to clean it up some more. I should probably split it into a few commit, too.

Please mark as ready for review once it is, I keep seeing activity but assume it's unfinished so far.

Yup still unfinished. Want to clean up the code a bit more before marking ready.

This is ready for review.
It currently crashes after DKG succeeds because DKG & federation consensus use the same port and it seems like DKG fails to release it's port.

First pass impression on the setup UI
Making these notes in case they seem reasonable to include in iterations of the experience

It's not clear if each guardian should pick a name for the federation, or if the fed name is an alias localized to each guardian
I wish API socket address and external url selection were automated. Give me defaults. Maybe let me change them via an "advanced config" view or later (is that possible?)
I really wish Consensus socket address and external url selection were automated. Similarly, give me defaults. Maybe let me change them via an "advanced config" view or later (is that possible?)
Pick a default network for me. Mainnet will do. Let me select an alternative network via "advanced config" or later if possible
Future wish: Make the whole setup UI one of those neat tutorial UIs that walk you through the steps and let's you know how far you've progressed

Bug

I can set a negative number of guardians from the UI. Maybe I just don't like other guardians that much


"Module parse failed"

Using of "preLoaders+loaders" causes "Module parse failed":
module.exports = {
  module: {
    preLoaders: [
      {test: /\.js$/, loader: "eslint-loader", exclude: /node_modules/}
    ],
    loaders: [
      {test: /\.js$/, loader: "babel-loader", exclude: /node_modules/}
    ]
  }
}

ERROR in ./index.js
Module parse failed: ./node_modules/babel-loader/index.js!./node_modules/eslint-loader/index.js!./index.js Line 3: Unexpected token
You may need an appropriate loader to handle this file type.

This is strange, I've got exactly same setup and don't have any issues.
Maybe you need babel-eslint in your .eslintrc?

@nkbt I will try to create a repo with example witch causes this error. Let me some time to do it.

It seems you just need babel-eslint as a parser for eslint ;)
Reopen if that is not the case, but each time I got this issue, it's just that I use an esNOTEXISTING feature :)

I have the same issue even if I add babel-eslint parser to .eslintrtc:
module.exports = {
  module: {
    preLoaders: [
      {test: /\.js$/, loader: "eslint-loader", exclude: [/node_modules/, /lib/]}
    ],
    loaders: [
      {test: /\.js$/, loader: "babel-loader", exclude: [/node_modules/, /lib/]}
    ]
  }
}

{
  "env": {
    "browser": true,
    "es6": true
  },
  "parser": "babel-eslint"
}

What is your input file that trigger an "Unexpected token" issue?
This have probably nothing to do with the fact that you are using eslint as a preloader.
But if you think it is, making a pull request to add a failing test might help us :)

It fails on this line and it works fine if I remove the preloader:
import { accountService } from 'services/account.service.js';

And it says:
... Line 1: Unexpected token
You may need an appropriate loader to handle this file type.
| import { accountService } from 'services/account.service.js';
|
...

You don't have this issue if used as a loader before (=> after in the array definition) of babel-loader?

I do have it in this case as well.

The issue seems related to eslint. Not this loader.
Do you get the same issue via eslint cli?

@MoOx I don't get this issue using eslint cli directly.

@MoOx I seems that I also don't have it using eslint cli directly.

I have the exact same issue with all the latest packages installed. Using eslint-loader as a preloader fails!

@MoOx please reopen it until it will be fixed.

Would love to re-open, but I don't have sufficient rights to do so!
Let me know. Thx.

Can someone open a PR with a failing test?
I don't have the issue at the moment, maybe it's related to a recent eslint change?

Having the same problem

This module is open source and covered by tests. It is very easy to start working on it: clone the project, the npm install && npm test.
So if you encounter a bug, please take the time to fix it (reminder: Open Source projects work even better with multiples contributors).
If don't want to take the time to fix it because you have others priorities, at least make a pull request with a failing test to expose the bug to the world in order to facilitate things for people that will fix it.
Thanks !

Hi I have the same issue. I wasn't able to run the tests without errors yet. So I've create the repository which demonstrates the bug https://github.com/Halama/eslint-loader-debug

Thanks a lot, that will helps. It's look like it's related to your version of babel.
Can everyone involved here tell which version of babel you are using? babel@6?
(I still use babel@5, that probably why I don't have the issue yet)

This might be related https://github.com/babel/babel-eslint/issues/199 / https://github.com/babel/babel-eslint/pull/202 but I am not sure

@MoOx I'm using "babel": "^6.0.15"

    "babel-core": "^6.1.2",
    "babel-eslint": "^4.1.4",
    "babel-loader": "^6.0.1",
    "babel-preset-es2015": "^6.1.2",
    "babel-preset-react": "^6.1.2",
    "babel-runtime": "^6.0.14",

So like I said, it looks like it is related to the  babel-eslint issue mentioned above (not upgraded to babel 6 yet).

I don't use babel@6 and here is my config:
{
    "babel": "^5.8.29",
    "babel-core": "^5.8.30",
    "babel-loader": "^5.3.2",
    "eslint": "^1.7.3",
    "eslint-loader": "^1.1.0",
    "webpack": "^1.12.1"
}

@MoOx Could you please tell us about the progress?

I didn't do anything yet because I don't have the issue with all my current project atm.
Also see https://github.com/MoOx/eslint-loader/issues/66#issuecomment-154508816 if you want to help.

Everything is now working great for me after upgrading to the latest babel, etc..
Thanks. G.

Problem was in babel-loader, for babel@5 you may use<EMAIL_ADDRESS>it works fine with preLoaders

Thanks for reporting this babel issue.

same problem here after migrating to Webpack 2.0 even with babel-loader 6 and 7
ERROR in ./src/index.jsx
Module parse failed: /var/www/images-shelf/node_modules/eslint-loader/index.js!/var/www/images-    shelf/src/index.jsx Unexpected token (18:12)
You may need an appropriate loader to handle this file type.
| render() {
|         return (
|             <h1>
|                 Test
|             </h1>

"babel-cli": "^6.18.0",
"babel-core": "^6.21.0",
"babel-eslint": "^7.2.2",
"babel-jest": "^18.0.0",
"babel-loader": "^6.4.1",
"eslint": "^3.12.2",
"eslint-config-airbnb": "^13.0.0",
"eslint-loader": "^1.7.1",
rules: [
        {
            enforce: "pre",
            test: /\.jsx?$/,
            loaders: "eslint-loader",
            include: [
                config.paths.src
            ]
        },

@stilllife00 did you find out how to fix it?

OK my issue was that I was using rules + loaders at the same time. Only using rules fixes it!


Blocked popups causes infinite loop error

If no popup window is shown because popups are blocked by the browser, the following error will be produced:
{
"errorUrl": "http://localhost:3000/landing",
"errorMessage": "TypeError: Cannot read property 'closed' of undefined",
"stackTrace": [
"{anonymous}()@http://localhost:3000/assets/js/satellizer.js:588:28",
"Array.wrappedProgressback@http://localhost:3000/js/angular/angular.js:11591:88",
"{anonymous}()@http://localhost:3000/js/angular/angular.js:11559:28",
"{anonymous}() (Scope.)$eval@http://localhost:3000/js/angular/angular.js:12702:28",
"{anonymous}() (Scope.)$digest@http://localhost:3000/js/angular/angular.js:12514:31",
"{anonymous}() (Scope.)$apply@http://localhost:3000/js/angular/angular.js:12806:24",
"tick@http://localhost:3000/js/angular/angular.js:9048:36"
],
"cause": ""
}
This error will be generated repeatedly and infinitely; I don't know why that is so. See http://i.imgur.com/hLixE1B.png

Had a look into it a bit more; if the popups is blocked, the library will try and reference properties of the nonexistent object. I've put in a pull request to fix it. The 'infinite loop' style behaviour was from the 35ms timeout to poll the window.

Thanks, I will review your PR over the weekend. Things have been a bit crazy at work with the hard deadline by next week for the upcoming website launch.


Add validator and update validators

See #13
Change:

Add validator and verify message
Update validators

Codecov Report

Merging #148 into master will decrease coverage by 1.28%.
The diff coverage is 55.73%.

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
- Coverage     87.76%   86.47%   -1.29%
- Complexity      717      722       +5
============================================
  Files            47       48       +1
  Lines          1569     1627      +58
============================================
+ Hits           1377     1407      +30
- Misses          192      220      +28

Impacted Files
Coverage Δ
Complexity Δ

src/Validators/BooleanValidator.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Validators/HexValidator.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Validators/AddressValidator.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Validators/NonceValidator.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Validators/StringValidator.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Validators/QuantityValidator.php
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

src/Validators/TagValidator.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Validators/IdentityValidator.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Validators/BlockHashValidator.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Validators/Validator.php
16.66% <16.66%> (ø)
5 <5> (?)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fc44d...dcb0721. Read the comment docs.


feat: add latest release of hgctl

Ⅰ. Describe what this PR did
xref: #229
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #275 (eb12c68) into main (a5edad1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head eb12c68 differs from pull request most recent head f0b76f8. Consider uploading reports for the commit f0b76f8 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   44.37%   44.37%
=======================================
  Files          34       34
  Lines        5311     5311
=======================================
  Hits         2357     2357
  Misses       2787     2787
  Partials      167      167


Problem with starting up

Hi edolganov,
Thank you for your great efforts.
I have followed all the instructions for pre-build and build process.
when I open the browser with url <IP_ADDRESS>:10280 for access to index page, the page could not be reached. only two command prompt appeared:
H2Server cmd message: TCP server running at tcp://<IP_ADDRESS>:9092 (others can connect)
Chat-Central-Server cmd:
....
16:15:44,056 INFO  [SocketServer] Start CacheSever [port:12160, threadsCount:30]
16:16:44,062 INFO  [BillingOps] reinitAccsBlockedCache...
16:16:44,546 ERROR [TimerExt] PaypalPaymentsSynchService-sync: can't schedule: och.comp.db.base.exception.UniversalSqlException: can't select: query='SELECT id, userId, payProvider, payType, payStatus, amount, created, updated, externalId, details, comment  FROM payments  WHERE  payProvider=? AND payStatus=?  ORDER BY updated DESC;', errorMsg=Table "PAYMENTS" not found; SQL statement:
SELECT id, userId, payProvider, payType, payStatus, amount, created, updated, externalId, details, comment
FROM payments
WHERE  payProvider=? AND payStatus=?
ORDER BY updated DESC; [42102-177]
16:16:44,546 ERROR [BillingOps] can't reinitAccsBlockedCache: och.comp.db.base.exception.UniversalSqlException: can't select: query='SELECT id, uid, created, name, serverId, tariffId, tariffStart, tariffLastPay, tariffChangedInDay, tariffPrevId, feedback_notifyOpsByEmail  FROM chat_accounts;', errorMsg=Table "CHAT_ACCOUNTS" not found; SQL statement:
SELECT id, uid, created, name, serverId, tariffId, tariffStart, tariffLastPay, tariffChangedInDay, tariffPrevId, feedback_notifyOpsByEmail
FROM chat_accounts; [42102-177]

Thank you for your help!
I want to start the chat application but I faced an error.
Thanks

Hi edolganov,, i also face the same problem.

i'm getting the same error, someone here get to fix this issue?


🐛 [firebase_messaging] iOS - Existing UNUserNotificationCenterDelegate causes FirebaseMessaging.onMessage to no longer to fire

Bug report
One Line Summary
If a UNUserNotificationCenterDelegate is assigned to UNUserNotificationCenter.currentNotificationCenter.delegate by the app developer or another plugin / SDK then FirebaseMessaging.onMessage doesn't fire in the app's dart code.
Details
The root of the issue that FLTFirebaseMessagingPlugin.application_onDidFinishLaunchingNotification has a shouldReplaceDelegate flag that can omit assigning notificationCenter.delegate in some cases. This happens if notificationCenter.delegate != nil however it also checks if AppDelegate``conformsToProtocol UNUserNotificationCenterDelegate is true. However the latter is always true in a Flutter app, it really should be checking for FlutterAppLifeCycleProvider on notificationCenter.delegate instead.
Steps to reproduce
Steps to reproduce the behavior:

On a new Flutter project follow the Add Firebase to your Flutter app guide.
Add firebase_messaging to your app.
Add the FirebaseMessaging.onMessage.listen to your app.
Send a notification through the Firebase Console, ensure your FirebaseMessaging.onMessage.listen fires to ensure you have everything setup.
Open the AppDelegate.m.
Create a new class the implements the UNUserNotificationCenterDelegate protocol.
Under application:(UIApplication *)application:didFinishLaunchingWithOptions:(NSDictionary *)launchOptions add the following to assign it.

myNotifDelegate = [MyUNUserNotificationCenterDelegate new];
UNUserNotificationCenter.currentNotificationCenter.delegate = myNotifDelegate;

🐛 Observer FirebaseMessaging.onMessage.listen no longer fires.

AppDelegate.m (Click To Expand)
@interface MyUNUserNotificationCenterDelegate : NSObject<UNUserNotificationCenterDelegate>
@end
@implementation MyUNUserNotificationCenterDelegate
- (void)userNotificationCenter:(UNUserNotificationCenter *)center
    willPresentNotification:(UNNotification *)notification
  withCompletionHandler:(void (^)(UNNotificationPresentationOptions options))completionHandler
{
    NSLog(@"MyUNUserNotificationCenterDelegate:Handle push from foreground" );
    completionHandler(UNNotificationPresentationOptionAlert
                    | UNNotificationPresentationOptionSound
                    | UNNotificationPresentationOptionBadge);
}

- (void)userNotificationCenter:(UNUserNotificationCenter *)center
didReceiveNotificationResponse:(UNNotificationResponse *)response
  withCompletionHandler:(void (^)())completionHandler
{
    NSLog( @"MyUNUserNotificationCenterDelegate:Handle push from background or closed" );
    NSLog(@"%@", response.notification.request.content.userInfo);
    completionHandler();
}
@end

static MyUNUserNotificationCenterDelegate* myNotifDelegate;

@implementation AppDelegate
- (BOOL)application:(UIApplication *)application
    didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
    [GeneratedPluginRegistrant registerWithRegistry:self];

    myNotifDelegate = [MyUNUserNotificationCenterDelegate new];
    UNUserNotificationCenter.currentNotificationCenter.delegate = myNotifDelegate;

    return [super application:application didFinishLaunchingWithOptions:launchOptions];
}
@end

Expected behavior
Expect FirebaseMessaging.onMessage.listen to continue firing, as well as MyUNUserNotificationCenterDelegate.

Additional context
Other iOS Notification SDKs to be able to set their own UNUserNotificationCenterDelegate. This plugin should not break when other SDKs set their delegate, nor should this SDK break others.
Related
PR bug introduced in
@Salakar created PR #4043 that added the following code:
if ([GULApplication sharedApplication].delegate != nil &&
     [[GULApplication sharedApplication].delegate
              conformsToProtocol:@protocol(UNUserNotificationCenterDelegate)]) {
    // Note this one only executes if Firebase swizzling is **enabled**.
    shouldReplaceDelegate = NO;
}

While this did address an infinite swizzling bug when app developers add UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate to their AppDelegate.swift it also created the issued outlined here. To address this the conformsToProtocol check should be done on notificationCenter.delegate and instead of [GULApplication sharedApplication].delegate and should check for protocol FlutterAppLifeCycleProvider instead of UNUserNotificationCenterDelegate. This looks like a mistake in the PR #4043 code, as the title for the PR is "don't replace UNUserNotificationCenter delegate when protocol conforms to FlutterApplicationLifeCycleDelegate".
Related issues

https://github.com/OneSignal/OneSignal-Flutter-SDK/issues/348

Flutter doctor
Click To Expand
[✓] Flutter (Channel unknown, 2.10.5, on macOS 12.3.1 21E258 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc3)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] IntelliJ IDEA Community Edition (version 2022.1)
[✓] VS Code (version 1.66.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.16.2
Flutter SDK 2.10.5
my_example 1.0.0+1

dependencies:
- cupertino_icons 1.0.4
- firebase_core 1.17.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_messaging 11.4.1 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.0
- charcode 1.3.1
- clock 1.1.0
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- firebase_core_platform_interface 4.4.0 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.6.4 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 3.5.1 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.4.1 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta typed_data vector_math]
- js 0.6.3
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.3
- meta 1.7.0
- path 1.8.0
- plugin_platform_interface 2.1.2 [meta]
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.8 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.1

Thanks for the detailed report and analysis. Using steps to replicate, I was able to observe that FirebaseMessaging.onMessage.listen isn't triggered.
Maybe this issue is same / related: https://github.com/firebase/flutterfire/issues/8624
/cc @Salakar

@darshankawar @Salakar I opened a PR to address this bug:
https://github.com/firebase/flutterfire/pull/8822

PR https://github.com/firebase/flutterfire/pull/8822 has been merged addressing this issue so closing this issue.


Traversing

At the time of writing this issue, I can feel that I'm duplicating some sections of the rules.
For example, the code below has already been written twice.
fn validate(){
 if let Statement::Class(class) = self.statement {
            for member in &class.body.members {
                if let ClassMember::ConcreteMethod(concretemethod) = member {
                    let MethodBody {
                        comments: _,
                        left_brace: _,
                        statements,
                        right_brace: _,
                    } = &concretemethod.body;
                    {
                        /// Execute logic.
                    }
                }
            }
        }

}

I need to create a way to reuse it. There should be a function  find_members_and_execute or something like that.

As part of https://github.com/denzyldick/phanalist/issues/47 I will do a refactoring and will try to submit it during the weekend. Let's get back to it afterward.


omstart for hitting 'Level 4' with cursor before coroutine animation finishes

achievement

could happen from pressing Z before coroutine animation finishes?


bsc tokenlist address checksums

Hey, I wish I was able to intercept you before you finished this work. We have an effort in a repo here to consolidate all of our addresses, where we perform checksum checks prior to merging: https://github.com/beefyfinance/address-book
Here's the PR that integrates this: https://github.com/beefyfinance/beefy-app/pull/504

So this is no longer needed right?

@MirthFutures no we don’t need this PR, I cross checked the changes with the address book, it was already correct there


Add support for ACTION_SEND or such on Android

It would be better if the plugin supports ACTION_SEND or such by parsing intent's EXTRA_STREAM.

Thanks for the contribution.


Should we never got dist folder?

I think that its a better way to never commit dist folder. This repo is for source but our CI will publish on separated repo for bower bower-mighty-js and specific npm publish part.

:+1: I agree.
Therefore, we won't waste our time merging compiled versions.

Can I close it ? 👯

You can :wink:

Awesome