Auto completion is not working

Actual behavior (Required!)
auto completion is not working
Expected behavior (Required!)
completion feature to work
The steps to reproduce actual behavior (Required!)

using pathogen:
cd ~/.vim/bundle/
git clone https://github.com/airblade/vim-rooter.git
cd ~/.vim/bundle
git clone https://github.com/artur-shaik/vim-javacomplete2.git
add the required config : in config section

" javacomplete2 config
autocmd FileType java setlocal omnifunc=javacomplete#Complete
nmap <F4> <Plug>(JavaComplete-Imports-AddSmart)
imap <F4> <Plug>(JavaComplete-Imports-AddSmart)
nmap <F5> <Plug>(JavaComplete-Imports-Add)
imap <F5> <Plug>(JavaComplete-Imports-Add)
nmap <F6> <Plug>(JavaComplete-Imports-AddMissing)
imap <F6> <Plug>(JavaComplete-Imports-AddMissing)
nmap <F7> <Plug>(JavaComplete-Imports-RemoveUnused)
imap <F7> <Plug>(JavaComplete-Imports-RemoveUnused)

Environment (Required!)

OS: ManjaroOS 18.1.2
Vim version: Vi IMproved 8.1
Neovim version: N/A

Q&A
did the minimal .vimrc [check]
I have enabled logs with JCdebugEnableLogs and the output ofJCdebugGetLogContent is empty
I set g:JavaComplete_JavaviLogLevel to 'debug', then set g:JavaComplete_JavaviLogDirectory, and put here server logs, too.
copied from a previous issue
let g:JavaComplete_JavaviDebug = 1 [that was set blindly to be honest]
let g:JavaComplete_JavaviLogLevel = "debug"
let g:JavaComplete_JavaviLogfileDirectory = "~/"

Screenshot (Optional)

Additional Notes:

Import features are working fine
I've tried the compile javavi with this output as stated here

> mvn compile
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for kg.ash.javavi:javavi:jar:1.0-SNAPSHOT
[WARNING] 'dependencies.dependency.systemPath' for kg.ash.javavi.apache.logging.log4j:log4j-api:jar should not point at files within the project directory, ${basedir}/../javavi_log4j-api.jar will be unresolvable by dependent projects @ line 29, column 25
[WARNING] 'dependencies.dependency.systemPath' for kg.ash.javavi.apache.logging.log4j:log4j-core:jar should not point at files within the project directory, ${basedir}/../javavi_log4j-core.jar will be unresolvable by dependent projects @ line 36, column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ------------------------< kg.ash.javavi:javavi >------------------------
[INFO] Building javavi 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ javavi ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ javavi ---
[INFO] Nothing to compile - all classes are up to date
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.805 s
[INFO] Finished at: 2019-12-29T10:31:41+02:00
[INFO] ------------------------------------------------------------------------

but nothing changed.

Have you tried to press <C-x><C-o> after dot?
On 12-29 (00:37), Abdullah khaled wrote:

Actual behavior (Required!)
auto completion is not working
Expected behavior (Required!)
completion feature to work
The steps to reproduce actual behavior (Required!)
1. using pathogen:
cd ~/.vim/bundle/
git clone [1]https://github.com/airblade/vim-rooter.git
cd ~/.vim/bundle
git clone [2]https://github.com/artur-shaik/vim-javacomplete2.git
 2. add the required config : in config section
" javacomplete2 config
autocmd FileType java setlocal omnifunc=javacomplete#Complete
nmap  (JavaComplete-Imports-AddSmart)
imap  (JavaComplete-Imports-AddSmart)
nmap  (JavaComplete-Imports-Add)
imap  (JavaComplete-Imports-Add)
nmap  (JavaComplete-Imports-AddMissing)
imap  (JavaComplete-Imports-AddMissing)
nmap  (JavaComplete-Imports-RemoveUnused)
imap  (JavaComplete-Imports-RemoveUnused)
Environment (Required!)
 • OS: ManjaroOS 18.1.2
 • Vim version: Vi IMproved 8.1
 • Neovim version: N/A

Q&A
did the minimal .vimrc [check]
I have enabled logs with JCdebugEnableLogs and the output
ofJCdebugGetLogContent is empty
I set g:JavaComplete_JavaviLogLevel to 'debug', then set
g:JavaComplete_JavaviLogDirectory, and put here server logs, too.
copied from a previous issue
let g:JavaComplete_JavaviDebug = 1
let g:JavaComplete_JavaviLogLevel = "debug"
let g:JavaComplete_JavaviLogfileDirectory = "~/"
Screenshot (Optional)
[3]screenshot
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [4]view it on GitHub, or [5]unsubscribe.
References
Visible links

https://github.com/airblade/vim-rooter.git
https://github.com/artur-shaik/vim-javacomplete2.git
https://camo.githubusercontent.com/bab1fee2d46f3d010f1cbb2628f12dd2775ee689/68747470733a2f2f692e6962622e636f2f505948323378682f53637265656e73686f742d323031392d31322d32392d31302d30332d32382e706e67
https://github.com/artur-shaik/vim-javacomplete2/issues/432?email_source=notifications&email_token=ABFDHO2P5IG2OXM5IRP2IELQ3BOUDA5CNFSM4KAZCXO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDCV7MA
https://github.com/notifications/unsubscribe-auth/ABFDHO5VJGLFQ3Y4G2EAPMDQ3BOUDANCNFSM4KAZCXOQ

--
Best regards,
Artur Shaikhullin

oh my bad!, it worked thank you


lnd does not listen on <IP_ADDRESS>:9735 either by default or with explicit listen=<IP_ADDRESS>:9735

Background
lnd does not listen on <IP_ADDRESS>:9735 with default configuration.
lnd does not listen on <IP_ADDRESS>:9735 with listen=<IP_ADDRESS>:9735 explicitly configured.
It does in both cases listen only on :::9735 (ipv6).
When I specified ipv4 address of the interface explicitly (listen=x.x.x.x:9735) it starts to listen on that ipv4:port as expected (and stops listening on :::9735 (ipv6)).
But I am still not getting any inbound connections from peers. I am advertising my external static IP behind which I am NAT'd.
Your environment

version of lnd
0.5.0-beta-rc1
which operating system (uname -a on *Nix)
Linux raspberrypi 4.14.66-v7+ #1137 SMP Fri Aug 24 16:36:53 BST 2018 armv7l GNU/Linux
version of btcd, bitcoind, or other backend
bitcoind 0.16.2
any other relevant environment details
NAT behind fixed IP

Steps to reproduce
modify lnd.conf
check netstat -nat
Expected behaviour
lnd should listen for ipv4 connections.
Actual behaviour
lnd listens only for ipv6 connections.

Can you confirm that nodes are actually unable to connect inbound and it isn't an issue with your NAT set up?

I can confirm it is not a NAT issue - took a pcap which shows inbound traffic from the internet to my node <IP_ADDRESS>:9735:
11:26:35.417257 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [S], seq<PHONE_NUMBER>, win 29200, options [mss 1460,sackOK,TS val 950082794 ecr 0,nop,wscale 7], length 0
11:26:35.417385 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [S.], seq 302073097, ack<PHONE_NUMBER>, win 28960, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 950082794,nop,wscale 7], length 0
11:26:36.394000 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [.], ack 1, win 229, options [nop,nop,TS val 950083038 ecr<PHONE_NUMBER>], length 0
11:26:36.394483 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [P.], seq 1:51, ack 1, win 229, options [nop,nop,TS val 950083039 ecr<PHONE_NUMBER>], length 50
11:26:36.394620 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [.], ack 51, win 227, options [nop,nop,TS val<PHONE_NUMBER> ecr 950083039], length 0
11:26:36.410600 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [P.], seq 1:51, ack 51, win 227, options [nop,nop,TS val<PHONE_NUMBER> ecr 950083039], length 50
11:26:37.389884 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [.], ack 51, win 229, options [nop,nop,TS val 950083287 ecr<PHONE_NUMBER>], length 0
11:26:37.391401 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [P.], seq 51:117, ack 51, win 229, options [nop,nop,TS val 950083288 ecr<PHONE_NUMBER>], length 66
11:26:37.391469 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [P.], seq 117:135, ack 51, win 229, options [nop,nop,TS val 950083288 ecr<PHONE_NUMBER>], length 18
11:26:37.391493 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [P.], seq 135:157, ack 51, win 229, options [nop,nop,TS val 950083288 ecr<PHONE_NUMBER>], length 22
11:26:37.407806 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [P.], seq 51:69, ack 157, win 227, options [nop,nop,TS val<PHONE_NUMBER> ecr 950083288], length 18
11:26:37.407944 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [P.], seq 69:92, ack 157, win 227, options [nop,nop,TS val<PHONE_NUMBER> ecr 950083288], length 23
11:26:38.374651 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [.], ack 92, win 229, options [nop,nop,TS val 950083534 ecr<PHONE_NUMBER>], length 0
11:26:38.376358 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [F.], seq 157, ack 92, win 229, options [nop,nop,TS val 950083534 ecr<PHONE_NUMBER>], length 0
11:26:38.383507 IP <IP_ADDRESS>.9735 > <IP_ADDRESS>.40696: Flags [F.], seq 92, ack 158, win 227, options [nop,nop,TS val<PHONE_NUMBER> ecr 950083534], length 0
11:26:39.208120 IP <IP_ADDRESS>.40696 > <IP_ADDRESS>.9735: Flags [.], ack 93, win 229, options [nop,nop,TS val 950083742 ecr<PHONE_NUMBER>], length 0

pcap file:
lnd1.zip
Still no inbound peers established:
netstat -an | grep 9735
tcp        0      0 <IP_ADDRESS>:9735          <IP_ADDRESS>:*               LISTEN
tcp        0      0 <IP_ADDRESS>:45206         <IP_ADDRESS>:9735       ESTABLISHED
tcp        0      0 <IP_ADDRESS>:42152         <IP_ADDRESS>:9735     ESTABLISHED
tcp        0      0 <IP_ADDRESS>:37630         <IP_ADDRESS>:9735      ESTABLISHED
tcp        0      0 <IP_ADDRESS>:33158         <IP_ADDRESS>:9735     ESTABLISHED
tcp        0      0 <IP_ADDRESS>:53426         <IP_ADDRESS>:9735     ESTABLISHED

If you have those 4 inbound peers, then it would appear that you're able to accept inbound payments. Why are you expecting inbound peers to automatically arrive at your node? Out of the box, lnd will listen on IPv4, and IPv6 as well is available.

Isn't that unusual?

Bitcoin peers need to connect inbound in order to receive new blocks etc. Lightning peers only really need to be established if you have a channel with another node.
Closing this as the networking stack is working fine, and it isn't unusual for you not to have existing connections which aren't actually peers seeking to open channels, or maintain already exposed channels.

@Roasbeef :Thank you for your explanation.
My point was that out of the box lnd seemed to be listening only on ipv6 (no ipv4) as checked by output of netstat -an:
tcp6       0      0 :::9735                 :::*                    LISTEN

As opposed to e.g. bitcoin port 8333:
tcp        0      0 <IP_ADDRESS>:8333            <IP_ADDRESS>:*               LISTEN
tcp6       0      0 :::8333                 :::*                    LISTEN

But then when I tested the connection to port 9735 it worked, even though it still showed as tcp6:
tcp6       0      0 <IP_ADDRESS>:9735          <IP_ADDRESS>:55491         ESTABLISHED

I did not realize it is due to RFC 3493.
Sorry for opening unnecessary issue.

@doc-sportello  I stumble across the same issue, where I only see port 9735 opened for IPv6, not IPv4.  I don't know how to test the connect to port 9735.  Any suggestions?
Also, I don't see RFC 3493 is related to this issue.  Can you elaborate more?  I'm sure I'm not the only one that come to this place and still feel puzzled after reading the discussion.
Thanks!

@doc-sportello  I stumble across the same issue, where I only see port 9735 opened for IPv6, not IPv4.  I don't know how to test the connect to port 9735.  Any suggestions?
Also, I don't see RFC 3493 is related to this issue.  Can you elaborate more?  I'm sure I'm not the only one that come to this place and still feel puzzled after reading the discussion.
Thanks!

@monkey-jsun Did you perhaps specify listen=localhost in your config? If you change or supplement that with an explicit <IP_ADDRESS> (or whatever ipv4 address) it should work.


java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().

I use alpha07, the crash occurs in Android 6.x so far
In SystemJobService.java, it says
WorkManagerInitializer has been disabled but WorkManager is not manually initialized in
Application#onCreate.  This is a developer error and we should throw an Exception.
I have no idea why it happens, I just use default instance by api WorkManager.getInstance (without custom Configuration)
@Override
public void onCreate() {
        super.onCreate();
        mWorkManagerImpl = WorkManagerImpl.getInstance();
        if (mWorkManagerImpl == null) {
            // This can occur if...
            // 1. The app is performing an auto-backup.  Prior to O, JobScheduler could erroneously
            //    try to send commands to JobService in this state (b/32180780).  Since neither
            //    Application#onCreate nor ContentProviders have run, WorkManager won't be
            //    initialized.  In this case, we should ignore all JobScheduler commands and tell it
            //    to retry.
            // 2. The app is not performing auto-backup.  WorkManagerInitializer has been disabled
            //    but WorkManager is not manually initialized in Application#onCreate.  This is a
            //    developer error and we should throw an Exception.
            if (!Application.class.equals(getApplication().getClass())) {
                // During auto-backup, we don't get a custom Application subclass.  This code path
                // indicates we are either performing auto-backup or the user never used a custom
                // Application class (or both).
                throw new IllegalStateException("WorkManager needs to be initialized via a "
                        + "ContentProvider#onCreate() or an Application#onCreate().");
            }
            Logger.warning(TAG, "Could not find WorkManager instance; this may be because an "
                    + "auto-backup is in progress. Ignoring JobScheduler commands for now. Please "
                    + "make sure that you are initializing WorkManager if you have manually "
                    + "disabled WorkManagerInitializer.");
        } else {
            mWorkManagerImpl.getProcessor().addExecutionListener(this);
        }
    }

The stack trace is
Fatal Exception: java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().
at android.app.ActivityThread.handleCreateService(ActivityThread.java:3077)
at android.app.ActivityThread.-wrap4(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1571)
at android.os.Handler.dispatchMessage(Handler.java:111)
at android.os.Looper.loop(Looper.java:207)
at android.app.ActivityThread.main(ActivityThread.java:5728)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:789)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:679)

Thanks for reporting this.
I'm closing this issue because I cannot reproduce it in this codelab.
If you think that this is a problem of the WorkManager library, please open a bug on the WorkManager public issue tracker: https://issuetracker.google.com/issues/new?component=409906&template=1094197
Please reopen if you still think this is an issue with the codelab.

25 May 16:13 on app version 35
Condor PHQ525 (PHQ525), Android 6.0
Report 1 of 4
java.lang.RuntimeException:
at android.app.ActivityThread.handleCreateService (ActivityThread.java:2888)
at android.app.ActivityThread.-wrap4 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1428)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:148)
at android.app.ActivityThread.main (ActivityThread.java:5438)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:762)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:652)
Caused by: java.lang.IllegalStateException:
at androidx.work.impl.background.systemjob.SystemJobService.onCreate (SystemJobService.java:68)
at android.app.ActivityThread.handleCreateService (ActivityThread.java:2878)


Enable strict null in MSSQL extension

Next up after this is full strict mode, but this should help a lot in the meantime to ensure type correctness.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 42.252%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePathPage.ts
1
57.02%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
30864

Relevant Lines:
67815

💛  - Coveralls


Visual bug of toast

Toast creates odd vertical effect when fading out: https://youtu.be/6hGcz4UzKZI

Reproduced. Thanks!

I replaced my custom toast with the Notyf library. This issue will be closed when v0.5.0 is released.


prevent losing focus when clicking on a tab

Let's assume that a text input has the focus right now. When I click on a tab the focus is lost.
I've tried the following code but it doesn't work.
      //this works fine
      document.body.addEventListener("mousedown", event => {
          event.preventDefault();
      });

      //this doesn't work
      let allTabs = document.querySelectorAll('.chrome-tab');
      allTabs.forEach(element => {
          element.addEventListener("mousedown", function(event) {
              event.preventDefault();
          });
      });

I've found the solution.
First there's no need for the the portion that doesn't work. Then you need to edit draggabilly javascript file.
Search for the following line and remove it or comment it:
this.pointerDownBlur();


Update Jenkinsfile

Many thanks for submiting your Pull Request :heart:!


Added enableConfirmPassword for registration form.

Completes #35

I don't understand why travis is linked to github if travis cannot successfully build from github.

Thanks, this looks great! I'll merge this in once I wrap up my current project.
For the record: the reason PR's aren't running on travis is because I've got my personal Stormpath API credentials stored in Travis CI. Anyone could submit a PR that basically says: console.log(process.env.STORMPATH_API_KEY_ID) to view my credentials -- that's why travis is configured to ONLY run tests on the master / develop branches, since we control those directly.
It's annoying, I know -- but it's for security ^^

This is included in the latest release -- but I disabled it by default. I still think it's best to have this as an optional field, but not on by default.
I think the way UX is going (into the future) is to require as little info as possible.


mv empty subfolder causes deadlock

Please use the following bug reporting template to help produce actionable and reproducible issues:

A brief description
Bash crashes when trying to move an empty subdirectory - must restart computer (AFAIK) to recover
e.g.
root@MACHINE:/mnt/c/bash4/p3/process_content# mv voyage/vc/ .

with vc being an empty subdirectory sends bash into an unrecoverable state

Expected results
I would expect it would move the folder or give an error, or respond to cntrl-c
Actual results (with terminal output if applicable)
I have to actually restart Windows to  get bash back
Your Windows build number
Build 14393.0
Steps / commands required to reproduce the error
root@MACHINE:/mnt/c/bash4/p3/process_content# mv voyage/vc/ .
Strace of the failing command
N/A
Required packages and commands to install
windows ubuntu bash

Confirming, also tested on 14393.0

Thanks for reporting this, looks like we have a deadlock due to so incorrect behavior on how we're treating paths with trailing slashes.
This is related to #650

Arg deadlocks are not fun. Good luck! ;)

When I use mv command in bash. deadlock for me.

Thanks for reporting this issue, this issue has been fixed internally and will be in a future flight.

I can confirm it's fixed on build 14901. Thanks!

Fixed in 14901 and later.

This one has been marked as fixed for a while. Closing.

I was able to get it to hang just now with a new version of bash trying to rename a directory on the desktop mv employees_db-full-1.0.6.tar/ employeesdb You can downplay the file here https://launchpadlibrarian.net/24493586/employees_db-full-1.0.6.tar.bz2

@EvanCarroll - What Windows version are you running?

Windows 10.

Which specific build of Windows 10? If you run winver from the Start menu, it should tell you the specific build on the second line (Version XXXX OS Build XXXXX.XXX).

Having the same issue: 1607/14393.693

I'm having the same issue, winver reports 1607/14393.693.

This issue is fixed in 14901 and later, and you guys are on 14393 (Anniversary Update). You would need to be on a Windows Insider build for this to be fixed, or to wait for the Creators Update coming later this year.

Thanks for the update @JasonLinMS. Too bad the fix won't come out in a regular windows update :(

@lkgarrison - Fear not, Creator's update is coming soon.

"Don't worry it's fixed in a major update coming soon" is unsatisfactory for a bug resulting in driver/kernel deadlock on user input.
Why is this not an urgent security update for those running lxss?

@whorfin -- why would a hang in a default-off and beta-only feature, where the hang only affects that feature, justify an urgent security update?

@whorfin If you want the last fixes, you have to wait for Creators update or be on an insider build. From what I could gather, WSL is not something modular enough to be updated separately, it's an internal component and is deeply integrated with changes on the Windows kernel.
On Windows insider builds, this has been fixed a long time ago.

If a bug allowed someone to exploit Linux on Windows and cause dead lock would a security update be in order? Or is it just when people run into these issues because of the totally normal lack of interest on Microsoft to actually get this right?

@EvanCarroll -- what threat model are you assuming?

I'm not assuming any threat model. I'm posing a hypothetical question. This isn't a mere bug. This was causing a hard lock in Windows under regular user-permissions. In such case when the bug is one that can be replicated and surpasses the permissions of the user -- such as forcing a hard-restart or other unrecoverable condition does it really do you any favors to say it doesn't "justify an urgent security update."
The reason why I'm not posing a threat model is because it's blatantly obvious, and I don't want to be insulting. But we can do that. Run an FTP server as a non-admin using Bash on Windows then,

Issue an MKDIR, put nothing in the directory.
Issue an RNFR/RNTO using FTP.

There is a threat model. A remotely exploitable repeatable hard-crash using any FTP server running on Bash on Windows.

Thanks for stating the threat model.  A wide variety of people post in this forum; to some, this stuff is obvious, but others don't even understand the concept of a "threat model" to begin with.  Obviously the type of response that's useful for the former case is rather different from what's useful in the latter.
I would clarify a bit:  General Windows hard-crashes have, to my knowledge, been getting fixed promptly, even when triggered by WSL.  The concern here is crashes and hangs whose impact is contained within the WSL environment.
In this particular case, I might re-phrase things as "if someone installs and runs an explicitly-unsupported and known-buggy configuration (WSL is not trying to support daemons yet, and if you've made a serious effort at running a network service under WSL with any sort of uptime guarantees then you have surely encountered issues) in an environment that is explicitly labeled as "Beta", then someone can DoS that service and that entire environment."
I think that's absolutely a valid threat model.  Personally, though, I don't care :-)
I mean, it would be nice, but there are other issues in WSL that I care more about.  Like, for example, implementing the rest of the Linux permissions/security model:  All files accessible from Windows ("DrvFs") are effectively chmod 777'ed right now.  Consider someone who serves their Web app out of DrvFs (which has been recommended here on various occasions for interop purposes).  Threat model, attacker who can upload files to your Web service; exploit risk is that they can edit the Web service's code, upload and run Linux executables, even upload and run Windows executables and break out of the WSL sandbox.  Also, as far as I know, many of the ulimit and kernel-namespacing APIs are either unimplemented or stubs; code that depends on those features for security is not secure under WSL.  And so on.
The closest analogy that I can think to draw on the Linux side, though I realize it's imperfect, is to Wine.  You can, if you want to, run Windows system services on Linux under Wine.  But people don't even bother to report security issues with the Wine environment.  That's not what Wine is about.  And, certainly as of the initial Anniversary-edition release of WSL (which is the only version that contained this particular issue), that wasn't what WSL was about, either.  As WSL continues to mature, perhaps as it gets to the point where the "Beta" label is no longer really needed, I do hope that Microsoft starts patching this type of issue immediately.

Thanks, that's all I was looking for. Bash on Windows can take your system to a grinding halt with a mere FS-command and the level of importance placed on remedying that is roughly summed up with "wait six months and see." That's fine everyone has to start somewhere and most every project at a large corporation starts off as being-unimportant.
Hell, I'm glad Microsoft is doing something but kernel deadlock on user input being acceptable doesn't quite raise to the level of maturity that I want.
I understand and reject your analogy to WINE. I understand this is WINE in reverse, but reject that the frame of security-problems (which this would be) introduced by WINE would be treated the same way to Linux distributions. The link provided has two WINE security vulnerabilities.

CVE-2006-0106, Debian addressed this, patched it, and released the patch the very same month as a security update. See the links to the security update at the bottom of the page here In addition that design flaw was inherited: WPM inherits a design flaw from the Windows GDI API, which may lead to the execution of code through GDI escape functions in WMF files. You can find the bug they emulated here.
CVE-2005-0787, This was actually patched and released before the CVE was published. You can find the WINE issue here.. It also went out as a security release..

In short, things you can do with WINE that you shouldn't be able to do, like kernel dead-lock the system, go out on a fix somewhere, whether it's in an underlying libc bug, a kernel bug, a driver bug, or otherwise.
And, keep in mind WINE -- with one exception -- has only certified one non-game in the Platinum and Gold list. It's predominately used for playing games. That's why I'm excited about this project. Bash on Windows has the potential to bring real software to great gaming platform, albeit one that likes to kernel deadlock.

Some good discussion here, I just want to add a couple of minor points.  Servicing a product like Windows is an extremely difficult and expensive problem.  Every update that is pushed out has to be vetted and analyzed for any potential risk to the install base.  When WSL was initially released we had very few users and was marked as a beta feature.  Both of these factors contribute to the servicing team being less likely to accept the bugs that we wanted to backport.  I acknowledge that we could have probably done a better job of arguing the merits of this particular bug.
Moving forward we re-evaluating what kinds of issues we will backport to the stable version of Windows.  I agree with you, it's unacceptable for a bug like this to go unfixed for 6 months and I will fight to do better in the future.
Here's a rough idea of the types of bugs I think we should be backporting:

Bugchecks
Security issues
Deadlocks or other hangs that cause the driver or usermode service to become unresponsive
Targeted syscall bugfixes that unblock large scenarios - this one is very case-by-case.


Binding of binding requires intermediate div wrapper for now

See this issue
https://github.com/davedawkins/Sutil/issues/23

This is fixed in 1.0.0-beta-002


Rolled back to 1px minimum

Fixes https://github.com/CartoDB/cartodb/issues/10634
This PR rolls back the changes made in https://github.com/CartoDB/cartodb/pull/10597 for https://github.com/CartoDB/cartodb/issues/10358
Now reverted to the previous behaviour.

CR @javierarce


Couldn't find the xsel binary and fallback didn't work.

I run npx semantic-release-cli setup, and I provided these configs
? What is your npm registry? https://registry.npmjs.org/
? What is your npm username? eng.dibo
? What is your npm password? [hidden]
? What is your NPM two-factor authentication code? 060355

but the following error occurred
OS: Debian GNU/Linux 10 (buster)
ERR! semantic-release Error: Couldn't find the `xsel` binary and fallback didn't work. On Debian/Ubuntu you can install xsel with: sudo apt install xsel
ERR! semantic-release     at makeError (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:14:11)
ERR! semantic-release     at xselWithFallback (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:31:10)
ERR! semantic-release     at processTicksAndRejections (internal/process/task_queues.js:94:5)
ERR! semantic-release  Error: Couldn't find the `xsel` binary and fallback didn't work. On Debian/Ubuntu you can install xsel with: sudo apt install xsel
ERR! semantic-release     at makeError (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:14:11)
ERR! semantic-release     at xselWithFallback (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:31:10)
ERR! semantic-release     at processTicksAndRejections (internal/process/task_queues.js:94:5) {
ERR! semantic-release   stack: "Error: Couldn't find the `xsel` binary and fallback didn't work. On Debian/Ubuntu you can install xsel with: sudo apt install xsel\n" +
ERR! semantic-release     '    at makeError (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:14:11)\n' +
ERR! semantic-release     '    at xselWithFallback (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:31:10)\n' +
ERR! semantic-release     '    at processTicksAndRejections (internal/process/task_queues.js:94:5)',
ERR! semantic-release   fallbackError: Error: Command failed: /home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/fallbacks/linux/xsel --clipboard --output
ERR! semantic-release   /home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/fallbacks/linux/xsel: Can't open display: (null)
ERR! semantic-release   : Inappropriate ioctl for device
ERR! semantic-release
ERR! semantic-release
ERR! semantic-release       at makeError (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/execa/index.js:174:9)
ERR! semantic-release       at /home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/execa/index.js:278:16
ERR! semantic-release       at processTicksAndRejections (internal/process/task_queues.js:94:5)
ERR! semantic-release       at xselWithFallback (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/lib/linux.js:29:11)
ERR! semantic-release       at Object.default (/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/semantic-release-cli/src/lib/github.js:25:32) {
ERR! semantic-release     code: 1,
ERR! semantic-release     stdout: '',
ERR! semantic-release     stderr: "/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/fallbacks/linux/xsel: Can't open display: (null)\n" +
ERR! semantic-release       ': Inappropriate ioctl for device\n',
ERR! semantic-release     failed: true,
ERR! semantic-release     signal: null,
ERR! semantic-release     cmd: '/home/sh_eldeeb_2010/.npm/_npx/4b6729947d3d91fc/node_modules/clipboardy/fallbacks/linux/xsel --clipboard --output',
ERR! semantic-release     timedOut: false,
ERR! semantic-release     killed: false
ERR! semantic-release   }
ERR! semantic-release }

closin issue for trying to install xsel with sudo apt install xsel


amendment: assign the serial number to the amendment list object

Tracking the serial number allows for check if amendments have changed since last check without checking of the list one by one

High Level Overview of Change

Context of Change

Type of Change

[X] New feature (non-breaking change which adds functionality)
[X] amendment

Before / After
When amendment activates the new field Sequence in the amendments object will be increased 1. Before the field does not exist.

Time and resources are limited, but in general, yes - RippleX engineers make an effort to review contributions from external developers in the community. We have other priorities, so it may take some time for us to get to your PR, but we will.
Can you share the motivations for this PR? How is this change beneficial? How do you weigh that against the downsides (more code/complexity, more memory/compute use, etc)?

The serial number allows for easy check of if new amendments have activated and with it server does not need to load and process the amendment object that has not been changed.

At least for now, once an amendment is enabled - that is, added to the Amendments list - there is no mechanism for it to be removed[^1]. That means that the size of the Amendments list will change whenever a new amendment is enabled (strictly increasing currently). Would the size of the list not be a perfectly good substitute or proxy for a serial number?
[^1]: I would be remiss if I did not mention that there have been discussions and efforts to remove amendments from the list after they've been active for several years, and removed / retired from the code. So far, none of those designs have come to fruition. I think it's safe to say that even if such a mechanism were to be introduced, any implementation would remove several old amendments with one new amendment. (It would be absurd to add an entry that only removes one other entry if the goal is to save space.) Thus, if that were to occur, the size of the list would not strictly increase, but it would change any time an amendment was enabled.

Hi @a-noni-mousse - do you have any thoughts on the comments above?
It should be straightforward to compare the amendment object itself to see if there have been changes; and if the format of the data is a problem, you could compare a hash of the object in order to detect changes.

If there's no reply for a while, this PR will be closed due to inactivity. You'll always be welcome to open a new PR (or reopen this one) if you still feel the change is worth making.

Closing due to inactivity. Suggested alternatives are detailed above, e.g. compare the amendment object itself, or a hash of that object. However, if that is insufficient for your use case, please feel free to re-open, or open a new PR.


Remove WIP and personal branches from official repository

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
kubernetes/kubernetes.github.io repository contains obsolete/WIP/other unofficial branches.
Good practices with github repositories is to use personal forks for all WIP changes.
Proposed Solution:
Remove all branches except master and release-*.
Page to Update:
https://github.com/kubernetes/kubernetes.github.io/branches

/remove-lifecycle stale
/lifecycle frozen

@nikhita @jimangel @zacharysarah anyone of you able to delete the merged branches https://github.com/kubernetes/website/branches/all ? thank you

anyone of you able to delete the merged branches https://github.com/kubernetes/website/branches/all ?

I can, but will leave it to either @zacharysarah or @jimangel to do it since they are more familiar with the website repo. :)

I've deleted some. When https://github.com/kubernetes/test-infra/pull/11984 merges, we can delete more. 😄

Whether we remove dev-* branches is an open question, but all personal and WIP branches are now removed. https://github.com/kubernetes/website/branches/all
/close

@DanyC97 Thanks for circling back on this btw :)


Genre model - name is unique but not case sensitive, for that slug unique is raising issue

Solved.


[update] Improve line-height for external link

@pramodjodhani Does this work well with browser zoom/cross-browser?


Docs: add notes on dependencies, fix links

Updates docs (README, INSTALL) with some notes on the required dependencies when using the artifacts outside of the build system.

BTW., at least on my end, on Debian-based systems I need to install nss-plugin-pem to fulfill the libnsspem.so requirement — libnss3 is not enough.

@lwthiker updated, but also please do see the note on nss-plugin-pem above.

curl tries to load both libnssckbi.so and libnsspem.so. Up until now with all my experimentation it was always enough to let it load libnssckbi.so alone. But I guess there are use cases where libnsspem.so is needed as well. I think if that's the case we should add it to the list of dependencies.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Ankit Modanwal
Discord Username (if applicable)
No response
Additional Context
Mostly i love to find out bugs quickly throughout my experience and keep learning and growing which inspires me too.

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Implement Kaspa address generation

Currently only supports addresses that will work with schnorr. ECDSA address generation to follow.
bech32.c and bech32.h code from https://github.com/sipa/bech32/tree/master/ref/c with edits for kaspa

Codecov Report
Patch coverage: 83.72% and project coverage change: -7.67 :warning:

Comparison is base (f739567) 87.70% compared to head (bf0c313) 80.03%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
- Coverage   87.70%   80.03%   -7.67%
==========================================
  Files          11       13       +2
  Lines         431      521      +90
==========================================
+ Hits          378      417      +39
- Misses         53      104      +51

Flag
Coverage Δ

unittests
80.03% <83.72%> (-7.67%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/cashaddr.c
81.57% <81.57%> (ø)

src/address.c
92.85% <100.00%> (ø)

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update iLogger.md with correct example syntax

AddApplicationInsights method does not accept an App Insights Connection String and requires an Instrumentation Key. Using the provided example syntax prevents the app from logging to App Insights at all.
Current AddApplicationInsights code showing Instrumentation Key requirement is here:
https://github.com/microsoft/ApplicationInsights-dotnet/blob/main/LOGGING/src/ILogger/ApplicationInsightsLoggingBuilderExtensions.cs#L37

@kmscode : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Thanks for the PR. This is the correct code.
@bwren could you merge and publish. The current public doc is incorrect..


Typo in the README.md file #23

#48

Please resolve conflicts.

@vyasriday i have fixed the conflicts

@akshay-s-770 It would be great if in addition to link to each folder you can also provide a link to the corresponding blog as the folders are anyway visible in the folder. Linking them doesn't make much sense without links to the blogs.

closing due to no activity on this.


DRUM KIT(dark mode)

Project title
Drum kit
Project Description
adding dark mode toggler to drum kit
Stack:
[x] Html
[x] CSS
[x] JavaScript

@harshita2216 this issue has been solved. Can you please close this issue?


Norwegian Moneropedia entries (P–R)

Reminder that this needs to be adapted to #1313. There is a very small but important change in the entry "Ring Size"

Reopened in #1319


Add footer to charts, add freezing line to temperature charts, and improve chart colors

Closes #93.
Closes #95.
Closes #98.
STR:

Choose a location to load a report.
Choose a seasonal temperature chart that has freezing values present. There should be a faint gray "Freezing" line that is displayed behind the boxplot/scatter markers. Make sure this works for both Fahrenheit and Celsius.
Each model should have its own scatter marker symbols & the same color in three different shades representing the three different scenarios. This should be the case for both temperature and precipitation charts.
Both the temperature and precipitations charts should now have footers that explain the boxplot and shaded region, along with credits.
No hover text should show up when you hover over the boxplot. Explanation of the boxplot is now in the footer.

This looks good except for two things -- "Freezing" doesn't show up for me (!!) and the text for part of the footer isn't centered.
I tried three MacOS browsers (Safari, Firefox, Chrome) and I also did an rm -rf node_modules then nom install to see if perhaps I had an out-of-date or stuck library.  No dice.  I also tried resizing my monitor to give ample space around the charts (screen resolution thing?) -- did not help.
Super confusing, is it possible that the non-centered text and the missing Freezing have something to do with one another?  May need someone else to recreate so we can isolate what's up here.


Upgrade gemfire dependencies to the latest GA release

As a developer, I'd like to upgrade to the latest gemfire GA dependencies.

Note: the latest is already Spring Data Kay which is Spring Framework 5.0 base line.
I'm afraid the previous Spring Data Gemfire might not be compatible with the latest Geode.

@sabbyanandan - what sort of update are you looking for?
@artembilan - What do you mean?

I'm afraid the previous Spring Data GemFire might not be compatible with the latest Geode.

Both Spring Data GemFire and Spring Data Geode are part of the Spring Data Release Train now, as of Kay.
I will be publishing a blog post soon on this, but essentially, in Kay, Spring Data GemFire is based on Pivotal GemFire 9.1.0, which is itself based on Apace Geode 1.2.0.  Spring Data Geode Kay, is based on Apache Geode 1.2.1.
One of my quote unquote goals of Spring Data GemFire/Spring Data Geode is that the dependencies are interchangeable, and today, that is true for SDG^2 Kay.
Hope this helps. Let me know if you have more questions.  I will be publishing the blog post on this soon.

Thank you @jxblum for explanation!
Looks like all you are saying is about SD Kay. What I mean that we can't upgrade here to SF 5.0 yet...

@jxblum: We are still on SF 4.x line - are there plans to backport the gemfire/geode compatibility?

Hmmm, OK well I am not sure I am still following exactly, but SD Kay is based on Spring Framework 5, which means both Spring Data GemFire and Spring Data Geode are based on SF 5.

@sabbyanandan - so, both SD GemFire Ingalls and SD Geode 1.0.0.INCUBATING-RELEASE are based on SF 4.x.
However, it is not possible to have a version of Spring Data Geode and Spring Data GemFire that are compatible before Kay because GemFire/Geode (not Spring) changed their packaging.
You see, the version of SD GemFire that was based on SF 4.x is also based on GF 8.2.6, which is not source/binary compatible with Apache Geode since Pivotal GemFire 8.2.x had not been based on Apache Geode yet.  GemFire 8.2.2+ is on-the-wire/protocol compatible with Pivotal GemFire 9.x servers though.

If we had released a SD line between Ingalls and Kay (which we had a branch for at one time (was SDG 1.10.x) with no intention of doing anything at all with it), then we could've had a SD GemFire based on SF 4.x and GemFire 9.0, which would be compatible with SD Geode.

If I'm interpreting this correctly, we cannot have the existing sink interact with the latest GF/Geode until the app itself is refactored to SF 5.x/Boot 2.x stack. Did I get that right?

Yes, that is correct.  It is 1 or the other.
It is not currently possible to support both Apache Geode (with SD Geode) and Pivotal GemFire (with SD GemFire) prior to SD Kay, simultaneously (not without jumping through code hoops, primarily because the package namespace in GemFire/Geode are different prior to GemFire 9, which will affect your imports and runtime class resolution).
Hope this helps.


Dropdown Overlay shoud close on outside click.

The dropdown overlay was not dismissed on outside mouse click .

Fixed v.0.0.5


[6.0] AST: Remove incorrect optimization from ASTContext::getOpenedExistentialSignature()

6.0 cherry-pick of https://github.com/apple/swift/pull/72919.

Description: It is no longer true that the existential signature of any P is always just <Self where Self: P>, because P might be ~Copyable, in which case any P is really any P & Copyable. Just remove the micro-optimization here, because if we're building an existential signature, we're likely going to be doing generic signature queries, and then we'll need a Requirement Machine anyway.

Scope of the issue: This happened to manifest in the SIL optimizer when performing the concrete existential peephole with any Sendable, since Sendable is now ~Copyable, but any number of code paths could have run into this.

Radar: Fixes rdar://problem/126079282.

Reviewed by: @hborla

@swift-ci Please test


Cannot use remote.app in renderer

I have a database connection in renderer dir and I have to get userData path using app.getPath.
Here is the code:
import { remote } from 'electron'
let databaseAddress = path.join(remote.app.getPath('userData'), 'db.db')

But it thorws an error which is:

Node version: v10.15.0
NPM version: 6.4.1
vue-cli version: 3.2.1
Operating System: Ubuntu 18.10

you try direct electron. app not in remote.
 import electron from 'electron' let databaseAddress = path.join(electron.app.getPath('userData'), 'db.db')

only electron not {electron}:
import electron  from 'electron'

Sorry.
This one doesn't throw any errors in terminal, but:


[Release Radar Request]

Open Source Project name
Crypto Profit
What is your project?
A crypto profit/loss calculator with FIAT conversion and
Version
2.0.0
Date
November 29 2021
Description of changes
Improved UI
Currency Marquee
Dark Mode improved
GitHub Repo
https://github.com/fcancelinha/crypto-profit
Website
https://fcancelinha.github.io/crypto-profit/
Link to changelog
https://github.com/fcancelinha/crypto-profit/releases
Social media
no
Anything else to add?
 Keep rocking!

Sorry we couldn't include this in the November Release Radar as that had already shipped. Please definitely submit again for v2.0 and we'd love to consider your project 😄


Provide wheel packages at pypi for python 3.6 on windows

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 x64
TensorFlow installed from (source or binary): binary(expect)

Describe the problem
Providing wheel packages at pypi for python 3.6 on windows would be helpful. As it is the latest anaconda python version.

Please see #6999


plotmafSummary insists on reusing old plot windows

Using maftools 1.0.40 with R 3.3.0 and BioConductor 3.4 on a Windows machine. (All of BioConductor has just been upgraded to the latest version.)
I have two different MAF files, and want to compare the results of plotmafSummary in side-by-side windows.  However, even if I call "windows()" to initialize a new device, it insists on plotting the second version in the first window (even though it was marked as "inactive" when the command was issued). That is, you get this behavior:
plotmafSummary(maf2) # appears in dev 2
windows() # creates new dev 3
plotmafSummary(maf3) # still appears in dev 2
You can work around this by creating a bunch of windows and killing the lower-numbered ones, which may hint at the source of the problem. In other words, if you use the following commands, you can display three different MAF files:
windows() # open dev 2
windows() # dev 3
windows() # dev 4
# manually kill devices 2 and 3
plotmafSummary(maf4) # shows in dev4
windows() # new dev 2
windows() # new dev 3
# manually kill dev 2
plotmafSummary(maf3) # shows in dev 3
windows() # new dev 2
plotmafSummary(maf2) # shows in dev 2
Anything else, however, and subsequent calls to plotmafSummary appear in the window with the lowest device number.

I am not sure how to arrange them in same window, since a plotting window is already defined while arranging multiple plots through grid.


Add: Maeil Business TV

Channel Name
Maeil Business TV
Alternative Names (optional)
No response
Network (optional)
Maeil Broadcasting Network
Owners (optional)
Maeil Business Newspaper
Country
KR
Subdivision (optional)
No response
City (optional)
Seoul
Broadcast Area
s/KR
Languages
kor
Categories (optional)
news
NSFW
FALSE
Launched (optional)
1995-03-01
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://www.mbn.co.kr/
Logo
https://upload.wikimedia.org/wikipedia/commons/thumb/b/bf/MBN_Logo.jpg/1200px-MBN_Logo.jpg
Notes
No response

https://iptv-org.github.io/channel?id=MaeilBusinessTV.kr


[chiptest] Add support for door lock app tests

Problem
Door lock tests are skipped when running tests with ./scripts/tests/run_test_suite.py.
Change overview

Added door lock application to run command (--door-lock-app)
Fixed PEP8 warnings in chiptest Python files

Testing
Running test suite on Linux:
./scripts/tests/run_test_suite.py \
    --target-glob "DL_*" \
    --chip-tool out/examples/chip-tool/chip-tool \
    run \
      --all-clusters-app out/examples/all-clusters-app/chip-all-clusters-app  \
      --door-lock-app out/examples/door-lock-app/chip-door-lock-app \
      --tv-app out/examples/tv-app/chip-tv-app

Issues

Test DL_UsersAndCredentials is failing....

Fast tracking, given this has had enough time for review.

/rebase

@woody-apple I think that this PR will have to wait a little bit more. After adding door lock app to the test suite, an error has emerged. There is a use after free error reported by clang thread analyses. Currently, I'm trying to resolve this use after free issue. Maybe I should convert this PR into a PR draft?


Support new version of cert-manager

Fixed apiVersion of cert-manager to a newer version.

thanks @t4i5uKE!


Implement Table empty + focus outline

Depends on

#1225

Why?
Provide missing features for OnyxTable.
Design
Figma table definitions

Out of scope

#1421

Acceptance criteria

[x] offer empty state
[x] implement focus style when accessing the table with tab

Definition of Done

[x] covered by component tests
[x] screenshot tests are updated
[x] follow-up tickets were created if necessary
[x] updated version + documentation is deployed
[x] Storybook can show the feature
[x] Storybook code snippet of new/changed examples are checked that they are generated correctly
[x] Set task to In Approval

Approval

Storybook Empty Table
Storybook focused table -> access table with tab.
[x] approved by designer @jannick-ux
[x] approved by dev @larsrickert

Implementation details

Use the exisiting empty component
prefer CSS implementation, e.g. with &:has(tbody tr) selector

@jannick-ux Open question

Reconsider skeleton for simple table to be replace by a lading indicator style?

loading indicator and skeleton state have two different purposes. Skeleton is for building up the component. Loading indicator is for processing an input. Thats the reason why we commited to skip the loading indicator for the simple table.


Limited feedback in large VS Code workspace

I have a largish VS Code workspace; at the moment it contains 13 projects, each of these contains one crate or virtual workspace in the root. After starting VS Code, rust-analyzer reports "workspace loaded, 2268 rust packages", and there's no output in the debug console.
However, after loading this workspace, I only get very limited feedback from rust-analyzer. For example, if I change a field name to be incorrect, there's no error (as in, red underlining). However, syntax errors are correctly flagged (for example, if I remove the comma between two items in imports).
I'm using rust-analyzer master as my daily driver, updated every few days. Currently running 9d786ea221b27fbdf7c7f7beea0290db448e0611.

For example, if I change a field name to be incorrect, there's no error (as in, red underlining).

That kind of errors comes from cargo watch I believe, not ra itself. Does cargo watch get run for all cargo workspaces/projects?

I have "Enable Cargo Watch On Startup" set to true in the VS Code config, if that's what you're asking.

I was thinking about if the ra ext does actually run cargo watch for all projects of a vscode workspace.

@matklad seems to suggest it should work in https://github.com/rust-analyzer/rust-analyzer/issues/1834#issuecomment-531013068.

@matklad do you have any feedback on what might be going on here? Is there something else I could do to debug this? I'd be potentially down with hacking on this if there is a clear path to get it working again.

Haven't looked into this yet, but my understanding is that, while in theory we support multi-workspace setups, no plumbing has been done to actually enable this.
Hm, now that I actually look at the code, there's code that tries to handle this use-case

https://github.com/rust-analyzer/rust-analyzer/blob/5c3ccc55082838524f695ffe40138fd8e805db70/crates/ra_lsp_server/src/main_loop.rs#L66
https://github.com/rust-analyzer/rust-analyzer/blob/5c3ccc55082838524f695ffe40138fd8e805db70/crates/ra_lsp_server/src/main.rs#L43-L49

I am not sure if this code actually works (as you can guess from the fact that I don't even remmeber that this code exists :) ), as I am not using multi-workspace myself.
So, the thing to do here would be:

add some printfs around that lines, to see if they actually work
add a multi-workspace workspace test to heavy_tests.rs (semi-unrelated, but we should refactor heavy-tests such that there's only a single heavy test that check everything, because initint a heavy test is really slow).

I've been setting up a new machine where I actually saw this working. My current hypothesis is that it'll fail if one of the workspaces has a compilation bug (or potentially a dependency conflict).

I'm also seeing this as I'm going through https://github.com/rust-lang/rustlings
It prints out workspace loaded, 114 rust packages, then no code-completion, no errors, no definitions etc.
Verified both with vscode and vim using coc

@daern91 features seem to work fine for me in that repo, can you retest?

@djc are you still seeing this?
(Marking S-actionable, if you look at this in the future and the OP hasn't answered, ping me so we can close it.)

@daern91 features seem to work fine for me in that repo, can you retest?

@djc are you still seeing this?
(Marking S-actionable, if you look at this in the future and the OP hasn't answered, ping me so we can close it.)

@daern91 seems to be talking about a Cargo workspace, whereas I was talking about a VS Code workspace that contained many projects, where each project is its own Cargo workspace. Do you have reason to assume this works now? I moved away from working like that because of this bug.

@daern91 seems to be talking about a Cargo workspace, whereas I was talking about a VS Code workspace that contained many projects, where each project is its own Cargo workspace. Do you have reason to assume this works now? I moved away from working like that because of this bug.

@daern91 features seem to work fine for me in that repo, can you retest?
@djc are you still seeing this?
(Marking S-actionable, if you look at this in the future and the OP hasn't answered, ping me so we can close it.)

Thanks a lot for the response! I just tested it on my end and it works with the code inside the src folder, like in your screenshot.
However, it still fails with any of the exercises, for example when hovering over or trying to write a new println!() statement here: https://github.com/rust-lang/rustlings/blob/master/exercises/enums/enums1.rs#L12
Could you please test again?

Workspaces and features are not usable as is.
Just to be clear, this is the workspaces I'm talking about: 6f17d4d860ac73eca3b1aabce9b3ae8572b47c41/rust-general.code-workspace
...not the ones in a Cargo.toml.
Here is the config I tried: 6f17d4d860ac73eca3b1aabce9b3ae8572b47c41/ailre_genrel/.vscode/settings.json
Obviously, that config is explicitly only good/usable in the one crate.  VSCode insists the config is only valid in a root folder.
This setting cannot be applied in this workspace. It will be applied when you open the containing workspace folder directly.
I get that this could be a new bug, but there are so many.
This could be a bug in VSCode, but they need to know how that bug effects this project.  Better to have two bug reports pointing at each other than a situation where both projects are abundantly against fixing the bug and insist the other project will fix it.  Please settle such disputes on your own and stop insisting I somehow need to be in the middle playing telephone.

@cheako What you're asking for seems to be basically #10298; this is unrelated. Also,

Please settle such disputes on your own and stop insisting I somehow need to be in the middle playing telephone.

First, this seems to be coming out of nowhere, unless I missed some discussion elsewhere.
Second, this is an open-source project. If you want something to be done, the best way to achieve that is to do it yourself or at least be helpful; the attitude you're showing here is not likely to lead to success.

@daern91 These files in rustlings are not part of a crate and are built by a special build system in rustlings, which is why rust-analyzer doesn't work so well in them. There's a potential fix in the rustlings repo: https://github.com/rust-lang/rustlings/pull/911


restore premium selection after amount/frequency change

Restores the premium gift selection after the amount/frequency changes (if that premium is still available).
Test page: https://protect.worldwildlife.org/page/67513/donate/1?assets=remember-premium-selection
It does have jump between different premiums being selected, but it looks like that behaviour already exists on WWF's pages. Their main concern is fixing the premium changing when the frequency is changed via the checkbox near the submit button (when doing a one-time donation, there's an upsell to yearly and previously this changed their premium).
Since WWF have a slightly custom premium setup, it might be worth testing this with another client too? But I can't see that it would cause any issue.
Productive task: https://app.productive.io/2650-4site-interactive-studios-inc/tasks/7959493

What do you think about adding a small background color delay on the premium to prevent the visual "popping" that can happen when the value gets repopulated after an amount change? Recording: https://cln.sh/4Xd14xyw
[data-engrid-theme] .en__pg .en__pg__body{
   transition: background-color 200ms ease-in;
}


Running error

Hi Team,
Several times, when i reload the webpage, i get following error,

sqlalchemy.exc.OperationalError
OperationalError: (_mysql_exceptions.OperationalError) (2006, 'MySQL server has gone away') [SQL: u'SELECT setting.id AS setting_id, setting.name AS setting_name, setting.value AS setting_value \nFROM setting \nWHERE setting.name = %s \n LIMIT %s'] [parameters: ('maintenance', 1)]

Full error following as below:

This is the Copy/Paste friendly version of the traceback. You can also paste this traceback into a gist:  create paste
Traceback (most recent call last):
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 2000, in call
return self.wsgi_app(environ, start_response)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/werkzeug/contrib/fixers.py", line 152, in call
return self.app(environ, start_response)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1637, in full_dispatch_request
rv = self.preprocess_request()
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/flask/app.py", line 1837, in preprocess_request
rv = func()
File "/var/www/testdomain.com/adns/app/views.py", line 64, in before_request
maintenance = Setting.query.filter(Setting.name == 'maintenance').first()
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2469, in first
ret = list(self[0:1])
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2292, in getitem
return list(res)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2571, in iter
return self._execute_and_instances(context)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2586, in _execute_and_instances
result = conn.execute(querycontext.statement, self._params)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 914, in execute
return meth(self, multiparams, params)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 323, in _execute_on_connection
return connection._execute_clauseelement(self, multiparams, params)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1010, in _execute_clauseelement
compiled_sql, distilled_params
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1146, in _execute_context
context)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1341, in _handle_dbapi_exception
exc_info
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause
reraise(type(exception), exception, tb=exc_tb)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1139, in _execute_context
context)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 450, in do_execute
cursor.execute(statement, parameters)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/MySQLdb/cursors.py", line 205, in execute
self.errorhandler(self, exc, value)
File "/var/www/testdomain.com/adns/flask/lib/python2.7/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
raise errorclass, errorvalue
OperationalError: (_mysql_exceptions.OperationalError) (2006, 'MySQL server has gone away') [SQL: u'SELECT setting.id AS setting_id, setting.name AS setting_name, setting.value AS setting_value \nFROM setting \nWHERE setting.name = %s \n LIMIT %s'] [parameters: ('maintenance', 1)]
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it. For code execution mouse-over the frame you want to debug and click on the console icon on the right side.
You can execute arbitrary Python code in the stack frames and there are some extra helpers available for introspection:
dump() shows all variables in the frame
dump(obj) dumps all that's known about the object
Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

This is problem with connectivity between the application and MySQL. Please double check your MySQL server config to avoid error "MySQL server has gone away"


Parse Error

Parse Error:
Basics_pi=1
Message:
-- PARSE ERROR ------------------------------------------------------------- elm
Something went wrong while parsing repl_value_7's definition.
4| repl_value_7 =
5|   Basics_pi=1
^
I was expecting to see an expression, like x or 42.
Also I got this error using Basics_e

I think it is because of the capital letter. Saying basics_pi = 1 in the REPL should be fine. Not sure the goal here, but I recommend asking around for help on http://elmlang.herokuapp.com/


Unexpected error during attach new image if quotas limit is reached

Description
When user reached his system disks size quota and tries to attach new image, he will see an error:
Unexpected error executing code for particular method, detected by Xmlrpc-c method registry code. Method did not fail; rather, it did not complete at all. Assigning to already instantiated xmlrpc_c::value

To Reproduce

Create new Group
Create new VM
Chgrp for this VM
Add group Quotas for System disks
Try to overuse it

Expected behavior
Reliable error message, that quota limit for system disks has reached
Details

Affected Component: Oned
Hypervisor: KVM
Version: 5.8.0-5.8.4

Additional context
Add any other context about the problem here.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

I just wanted to append that problem still persist on 5.10.2

xml method call, just for the confirmation that it is oned problem, not sunstone
<!---------- INPUT ------------>

<?xml version="1.0"?>
<methodCall>
    <methodName>one.vm.attach</methodName>
    <params>
        <param><value>oneadmin:deadbeefdeadbeefdeadbeefdeadbeef</value></param>
        <param><value><i4>419</i4></value></param>
        <param><value><string>DISK=[SIZE=1024, IMAGE_ID=210]</string></value></param>
    </params>
</methodCall>

<!--------- OUTPUT ------------>

<?xml version="1.0" encoding="UTF-8"?>
<methodResponse>
<fault>
<value><struct>
<member><name>faultCode</name>
<value><i4>-500</i4></value></member>
<member><name>faultString</name>
<value><string>Unexpected error executing code for particular method, detected by Xmlrpc-c method registry code.  Method did not fail; rather, it did not complete at all.  Assigning to already instantiated xmlrpc_c::value</string></value></member>
</struct></value>
</fault>
</methodResponse>

<!---------- END -------------->

Fixed in 6.0.3


Multiple zones and labels

It would be awesome to be able to specify multiple zones and labels. Please consider adding such a feature.
My personal use case is to filter 2 zones out of 3. 3rd is public area and I want to filter it out.

In the v4 pre-release you can configure dependent cameras. You could configure two different cameras in the card (which are really the same Frigate camera, just with each of the two zones) -- the configure each camera as a dependent of the other.
This would mean that whenever you view these cameras, it also shows you the events of the "other" camera.
Maybe this is roughly the effect you are looking for? [Benefit of this approach is also that it can show events for entirely different cameras, or even different Frigate servers]

I will check this out after new frigate release. Thanks for the information. But yeah ..it sounds rough. Allowing selecting multiple zones and labels in place for that, seems to be much more natural way of achieving this, without workarounds like this one

without workarounds like this one

Perhaps I don't understand your usecase enough, but the whole point of the dependent camera feature is actually to allow one zone to be dependent on another (e.g. you are viewing the live stream of a front door, and you also want events for a zone related to that camera).
Anyway, give it a shot and lets discuss how we can make it better! Thanks.

Ok, this works, dependency is quite usable, because I have two cameras that share some zones.
But this for my issue is still some kind of workaround ..I have two same cameras to switch.
My exactly use case is that I have 3 zones -entrance, place for my car and street. As I want to record clips for all cars on the street, I want to filter it out from frigate-card events, so it would be awesome be able to use
cameras:
 - frigate:
   - zone:
     - entrace
     - car_place

Support for array in zone and label params would be more intuitive and straightforward
If it's not a way You see it, just close issue.

I agree this is more intuitive for a case when it's a single camera, and will keep it open for future work.
It may not be trivial to implement due to the integration only supporting searching for one zone per camera, but I can find ways around this or fix the integration.
Thanks for the continued feedback @luzik !


Build failure: sage

Steps To Reproduce

build sage

Build log
[3/7] Cythonizing cypari2/gen.pyx
[4/7] Cythonizing cypari2/handle_error.pyx

Error compiling Cython file:
------------------------------------------------------------
...
    >>> pari('warning("test")')
    """
    global cb_pari_err_handle
    global cb_pari_err_recover
    cb_pari_err_handle = _pari_err_handle
    cb_pari_err_recover = _pari_err_recover
                          ^
------------------------------------------------------------

cypari2/handle_error.pyx:152:26: Cannot assign type 'void (long) except *' to 'void (*)(long) noexcept'. Exception values are incompatible. Suggest adding 'noexcept' to type 'void (long) except *'.
Traceback (most recent call last):
  File "/build/cypari2-2.1.3/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 66, in <module>
    setup(
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/__init__.py", line 103, in setup
    return distutils.core.setup(**attrs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 185, in setup
    return run_commands(dist)
           ^^^^^^^^^^^^^^^^^^
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
    dist.run_commands()
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
    self.run_command(cmd)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/dist.py", line 963, in run_command
    super().run_command(command)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/nix/store/jvcnqcf2n22rg3qfav8fwpbl7947x6kc-python3.11-wheel-0.42.0/lib/python3.11/site-packages/wheel/bdist_wheel.py", line 368, in run
    self.run_command("build")
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
    self.distribution.run_command(command)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/dist.py", line 963, in run_command
    super().run_command(command)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/command/build.py", line 131, in run
    self.run_command(cmd_name)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
    self.distribution.run_command(command)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/dist.py", line 963, in run_command
    super().run_command(command)
  File "/nix/store/7fnhc3nd125lq9vzw6bghsvbnmcc8mc1-python3.11-setuptools-69.0.2/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "setup.py", line 46, in run
    self.distribution.ext_modules[:] = cythonize(
                                       ^^^^^^^^^^
  File "/nix/store/xx59gyk65a4s5vrmql8dyddx69dbvwfi-python3.11-cython-3.0.6/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1154, in cythonize
    cythonize_one(*args)
  File "/nix/store/xx59gyk65a4s5vrmql8dyddx69dbvwfi-python3.11-cython-3.0.6/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1321, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: cypari2/handle_error.pyx
/nix/store/v5irq7wvkr7kih0hhnch5nnv2dcq8c4f-stdenv-linux/setup: line 1557: pop_var_context: head of shell_variables not a function context

Notify maintainers

@timokau @omasanori @raskin @collares
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.72, NixOS, 24.05 (Uakari), 24.05.20240117.842d9d8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Duplicate of #282383


Android - Not able to receive notifications for request/send/split money

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to mweb chrome and login with User A
Go to the chat with User B (Make sure to login with UserB on android - latest version- 1.3.17-5)
From User A account on mweb chrome , try to send text messages and notice that notification is well received in User B side on android
But now try to send/request money and notice that on the receiver side of User B, notification is not received

Expected Result:
Notification should be received for request/send money as well in a similar how it is received with messages
Actual Result:
Notification is not received for request/send money on android but works well with messages
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/6f7c48cd-d334-4fdb-8ee0-e4ec952b7a24
https://github.com/Expensify/App/assets/93399543/a4f8117f-cb02-4657-9a96-4a423ebbaf07
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684991900955059
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014bb5a28ad3690437
Upwork Job ID:<PHONE_NUMBER>029507072
Last Price Increase: 2023-05-31

@kbecciv I think by mistake you have kept someone else's GH handle on the initial reporter. My GH handle is @priya-zha. Thanks.

@priya-zha Corrected

@priya-zha does User A have to be using android mWeb or can they message User B from any platform to reproduce this bug?

@kadiealexander I tried using User A on Web chrome and mweb chrome and the bug was reproducible. I haven't tried on ioS/ mac or on android.

Thanks @priya-zha! I tested this with myself on mac web chrome as user A and @jliexpensify on Android native app as user B, and @jliexpensify got both notification types:

Sure.Let me check

Are you testing it on a real device or emulator ? I updated the app from the playstore and it shows the latest version as 1.3.19-7 and in this version, I'm still able to reproduce the bug. Also, the users doesn't need to be in the same device. because I logged in with User A on web chrome (laptop) and User B on android.  I am unable to see the version 1.3.20-1.

Real device (Pixel 3a) - I just updated on the Google store for the 2nd round of testing with Kadie.

Assigning @jliexpensify as this is an android issue. We were able to determine that the notifications above are from our old app, so no newdot notifications came through.

This may actually be a feature request, I'm not sure if we've ever sent push notifications for IOU activity

This will need to be internal and is not testable by external contributors.

Brought conversation to slack: https://expensify.slack.com/archives/C02HWMSMZEC/p1685751895005119, proposed updated notification logic here

Created PR: https://github.com/Expensify/Web-Expensify/pull/37725

PR merged ~12 hours ago

@roryabraham good to close this one? Looks like it's deployed to Prod already.

Yep

@roryabraham I'm the external reporter for this bug.

Oh, my mistake. @jliexpensify let's pay the bug reporting bonus for this, then close it out.

Had to make a new listing (I swear Upworks is so frustrating these days!) - https://www.upwork.com/jobs/~0161fd70cf89389a56
Invited you @priya-zha

Accepted. Thanks.

Paid and closed job!


Settings GUI Polish

Issue Type: Polish

In terms of maybe polishing the GUI a bit:

Make font sizes more consistent:

Looking at developer tools, I can see titles such as "Commonly Used" at 24px, then subtitles such as "Cursor" at 20px, but the normal text is only 13px, this could probably be at font size 16px.
This would also let people distinguish between setting name and setting description better, rather than having to rely on the slight change on font-weight and the structure.
Small text such as "Modified" can remain as is, since it isn't really part of the title, it's just a mini info textbox really.
Description text could probably remain as is, maybe increase it to 14px since brackets sometimes looks a bit squished

Layout

First of all, the way settings are separated are by large padding spaces. Whilst personally, I would prefer it how Atom does it (rendering certain settings based on the active tab), I can't really argue with that, so here are my propositions:

How about just a <hr> to denote changes in categories, say from Text Editor to Workbench.
Titles should definitely have underlines
Instead of constant padding-top or bottom, just halve the current figure, and split that between top and bottom. It makes it look much nicer, especially when a setting is elected and that box comes about, it looks really off.

Some other stuff

That box that appears when selecting something in the GUI, perhaps make it themable, and make it respond to whether its a dark or light theme. The box could just be the opposite, so a dark theme would have a light box etc. If unfocused, just make it change again
Allow showing of the equivalent json setting. Whilst present in some areas for explanation, you might as well make it show throughout. Be consistent, and can still help people too (though from what I've heard, most people will stick to JSON)

From what I've seen, when the GUI edits the settings.json, it just tacks it onto the end. I've seen this when I edit the file. I use both the GUI and JSON, you can guess for which reason. Anyways, since the GUI organises it, could it not organise the settings.json? I have my one split into different blocks relating to what section it belongs to.
If you click a dropdown (maybe textbox too?) of an uncollapsed setting, it should collapse too in my opinion. It would be helpful to newer people (since that's what I've heard this GUI is for, right?)

Feel free to disagree, add your ideas whatever. These are just suggestions for polish. Thanks!

Thanks for the feedback! I am in the process of getting rid of the row selection and expand/collapse behavior right now which will definitely change some things. Will keep this in mind as I continue working on the UI. FYI @misolori

@roblourens One more thing, if the viewport of the editor is small enough and the GUI is opened, the ToC disappears completely, and there seems to be no dropdown for it. Was this intended or just wasn't implemented?

That's by design. There's not enough room for it and users can still scroll or search. Maybe collapsing it into a dropdown would be a good thing to do in the future

Would it be possible, since it's a GUI and all, to have a sidebar that is toggleable. It'd be hidden by default of course, but perhaps a button that you can click which slides it out over the main settings, then close it? It might defeat the purpose of scrolling and all, but as the ToC essentially is the way to go around navigation, I still feel it could provide benefits. As reference, atom has a popup arrow to the right of the screen which opens outline view, perhaps something similar but for ToC?

I'm not planning on any other UX changes like toggling the table of contents. It does get hidden when the settings editor is narrow, but it's useful and I don't want to complicate things by making it toggleable.


add new blog post

Adds a new blog post

Really interesting the details about this improvement, and nice work @anonrig!


Torrentseeding with RaspiBlitz

To increase the number of seeders of the torrent file and to speed things up it would make sense to let the RaspiBlitz seed the torrent once it is downloaded.
There are some things to consider: At the moment after torrent download, the torrent gets renamed/moved and the directory is used for the bitcoind - so seeding an active used directory is not a good idea. To instead of moving the torrent it would need a copy after download. The 1TB HDD has enough space for that. But the copy could add another 2h of setup time.
The the best way would be from my perspektive: When user chooses torrent download, another dialoge is asking if the user would like to share/seed the torrent after download permantly. If "YES" then instead of movng the files they get copied after download. And Transmission gets added to the systemd services - starting everytime on boot.

Transmission could be part of the Services menu, so one could help to seed even if did not use the torrent option to download the blockchain. Also could help to seed SDcard images, or anything really given enough disk space.

Its a logical thing to do - and there is even another benefit of seeding new torrents: the user always has a fresh torrent copy of the blockchain available - so in case of data corruption no long waiting time, just copy over done :)

Is there a way to limit the upload speed of the seed?
I have an internet connection with an upload speed significantly lower than download speed. When the upload speed limit is hit, the download speeds drop significantly.
On typical torrent download clients, there is usually an option to limit upload speed. Is there a config file where I could set that up?

recommend to add this to v1.1 milestone ... because having a seeding blockchain ready means also that in case of data corruption of the one in action it means to have a replacement ready

Decided to add an experimental "Backup Torrent Hosting" feature to the v1.2 release, that can be activated in the SERVICES section.

TODO: make rtorrent NICE to reduce CPU priority
https://www.nixtutor.com/linux/changing-priority-on-linux-processes/
TODO: Open Incomming Ports on FireWall and set Port-Range on starting rtorrent
https://github.com/rakshasa/rtorrent/wiki/CLI-Usage

OK now rtorrent plays NICE and just on IDLE. Ports or open on new sd card build and user info is there.
TODO: Test old torrent download - check if any side effects
TODO: Test torrent quick replacement on blockchain data corruption

This feature is a bit half backed and just an experimental part of the v1.2 release. I was not able push Torrent Download/Seeding enough into the background so that CPU and USB-HDD-Bandwith keep making problems.

My first look, it seems many are using the Deluge torrent client which is supposedly light weight run as a daemon with remote UI/access.  Needs more research.

@fluidvoice I reasearch into alternatives to rtorrent like Deluge may make sense for a future release.
For v1.2 I think I leave it as it is to experiment with. So I move the ticket to finish to a future realease.

Now with RP4 the torrents get less and less important. Seeding from the raspiblitz in the past did not worked well and so I think OK to burry this idea.


Add cachingEnabled to @ManyToMany annotation

Feature request.
Please!

if you want it, just copy paste the generated class file and add it. the annotation should not get that complex.


Wrong background color on selected variables after restoring schemes

Hi,
I observe another issue with the matlab_schemer.

This happens, when I export my current scheme, load another scheme from the scheme folder and then restore my saved scheme back. Also the M-Lint hints on the right side are black and not orange.
Regards,

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28278846-wrong-background-color-on-selected-variables-after-restoring-schemes?utm_campaign=plugin&utm_content=tracker%2F19271142&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19271142&utm_medium=issues&utm_source=github).

Hi @LoGGoL,
I was not able to reproduce the bug. It seems that schemer_export has erroneously outputted black for the M-Lint background and warning colours.
If this is correct, the exported scheme will contain these lines:
Colors_M_Warnings=C-16777216
ColorsMLintAutoFixBackground=C-16777216

Can you check for me that this is the case?

The reason will be because unassigned colours (colours which have never been changed from the default since installing MATLAB) are returned as black when using the function to fetch the preference colour - com.mathworks.services.Prefs.getColorPref. As far as I have been able to ascertain, there is no way of telling whether a specific colour is unassigned or genuinely is black.
Currently, the only solution is to ensure every colour is assigned by manually setting every colour (even if it setting it to be the same as the default value, this still works). This is described in the help for schemer_export.

Did you follow the IMPORTANT NOTE: section of the help for schemer_export before exporting?

If not, could you try this and see if it resolves the issue?

This error should not have been possible since version v1.2.1, which introduced [checks for each preference panel to ensure the values have been set before exporting them].(https://github.com/scottclowe/matlab-schemer/commit/0bb4e679a10af83d8ebedb32e5551aabd37985f3)
Consequently, I do not understand how this issue has arisen. Without additional details on how to produce this error, I am unfortunately forced to close this bug with the issue unresolved.
If anyone experiences this bug again, please reopen this issue.


Update tested AGP versions

from 7.3.0-rc01 to 7.3.1
from 7.4.0-alpha10 to 7.4.0-beta02

@bot-gradle test AST

OK, I've already triggered the following builds for you:

AllSmokeTestsPullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.