gulpfile.js in File-New Project template needs to be improved

A few things specifically that should be changed.

The Copy task needs to return a stream. Currently it returns nothing which is bad practice and would make it impossible to extend the gulpfile. For example, I would not be able to create a task that runs in sequence after the Copy task. Consider doing something along the lines of the running-task-steps-per-folder recipe (https://github.com/gulpjs/gulp/blob/master/docs/recipes/running-task-steps-per-folder.md).

Is this eval("var project = " + fs.readFileSync("./project.json")); required? When I write it as var project = fs.readFileSync("./project.json"); it still seems to work.

Overall though, I think the file could be improved. When I talk to people in the community about using bower and tasks runners in ASP.NET, one of the big complaints is about all the manual wiring that is needed. It would be really nice if we could design a default gulpfile.js file such that after installing a new bower package, the required files would be automatically copied to the wwwroot/lib folder. If we could do that, we would solve 90% of the problems people are having with this new approach.  I know that it won't work in every situation, but we should be able to design something that works most of the time.
Some variation of what is presented in this blog should work (http://blog.simontimms.com/2015/01/22/getting-bower-components-in-gulp/).
I would be happy to help with this but I don't think the project templates are in a public repo. Is there any way for us to contribute to the project templates?

For reference, I am referring to the following gulpfile.js that is created by File - New Project:
/// <binding Clean='clean' />

var gulp = require("gulp"),
  rimraf = require("rimraf"),
  fs = require("fs");

eval("var project = " + fs.readFileSync("./project.json"));

var paths = {
  bower: "./bower_components/",
  lib: "./" + project.webroot + "/lib/"
};

gulp.task("clean", function (cb) {
  rimraf(paths.lib, cb);
});

gulp.task("copy", ["clean"], function () {
  var bower = {
    "bootstrap": "bootstrap/dist/**/*.{js,map,css,ttf,svg,woff,eot}",
    "bootstrap-touch-carousel": "bootstrap-touch-carousel/dist/**/*.{js,css}",
    "hammer.js": "hammer.js/hammer*.{js,map}",
    "jquery": "jquery/jquery*.{js,map}",
    "jquery-validation": "jquery-validation/jquery.validate.js",
    "jquery-validation-unobtrusive": "jquery-validation-unobtrusive/jquery.validate.unobtrusive.js"
  }

  for (var destinationDir in bower) {
    gulp.src(paths.bower + bower[destinationDir])
      .pipe(gulp.dest(paths.lib + destinationDir));
  }
});

Alternatively, the template could switch to using JSPM, and then all packages would be under wwwroot without the need to move them first. As a bonus, the request URLs are versioned, like<EMAIL_ADDRESS>

@madskristensen @rustd @DamianEdwards

Moving to JSPM seems a bit too opinionated to me but I would agree with all of @dpaquette's points. I'd also suggest that we might consider including js minification as part of the default gulpfile. It is extremely common and the structure of the file with minification included would not change dramatically if a user wanted to swap in a different minification tool.

jspm support is so essential, it is becoming the de facto for client side management of libs, at least include support for that :)

I'm on the same page here, and if we're talking about improvements I'd like to add a bit about the importance of having an out-of-box tool and pattern in place for the bundling & minification.
@Eilon I know you've said that we'll need to rely on gulp/grunt/whichever for this, which is cool, but I think that is should be part of this template. It may end up being opinionated by means of having to select a specific library to do the lifting, but like in other parts of the project templates, a link to a post on http://asp.net/ would suffice to explain what's going on and how to swap out the libraries for something of your own choosing.
Bundling and minification are not going away, even though they are being dropped from ASP.NET. My feeling is that if we're going to be asking devs to start mucking around with gulp tasks, we may as well give them a starting point. Having a task exported that is visible in the Task Runner gives a much lower jump-off point.

@MisterJames indeed. Pinging @madskristensen @rustd @DamianEdwards  again because I vaguely recall that we might have just added some better content on this for the template to show how it's done... but those three guys would have to confirm.

+1
The default gulpfile is very spartan. My suggestions:

Add CSS minification and concatenation. I am using LESS too but that may be too opinionated.

minifyCss = require("gulp-minify-css")
concat = require("gulp-concat")

Add JavaScript concatenation and minification.
uglify = require('gulp-uglify')
Add image compression:

imagemin = require("gulp-imagemin")
size = require("gulp-size")
gulp.task("compress-images", [], function () {
    var sources = [
        paths.images + "**/*.{png,jpg,jpeg,gif,svg}"
    ];
    gulp.src(sources)
        .pipe(imagemin())
        .pipe(gulp.dest(paths.images))
        .pipe(size());
});

Add a watch to a folder containing an empty css and js file for the site.

:+1: @MisterJames and I hope to get some help with HTML minification, too. Right now, it's hand-to-hand combat (e.g., https://github.com/aspnet/Razor/issues/61#issuecomment-116785326 & https://github.com/aspnet/Razor/issues/423).

+1
Having simple minification and bundling in a template would be nice. Also, being opinionated here is a good thing, the template could serve as a sample for some hard decisions the developer needs to do when starting a new project, like do I keep the minified files along source ones inside wwwroot? I copy them over a dist directory? How I deal with testing the release version now that is outside the wwwroot directory? How all of this fits with the publish wizard? and so on...

Thanks to @dpaquette, I've made improvements to my gulpfile.js. Only the absolute minimum gets placed in the wwwroot folder.
I'm using LESS but you could just as easily use SASS. CSS and JavaScript is concatenated and minified with .map source files included. I also log the sizes of the files before and after minification to the console. Everything is fully commented with links to the Gulp packages too.
I noticed a lot of examples duplicate src, concat, minify, dest steps just for slightly different use cases. I have experimented with using gulp-if to get rid of the duplicate code e.g. If the file extension is CSS rather than LESS, don't run gulp-less. I think that is a good approach to take in those situations. All the tasks start with an array of source files which can be easily added to and extended.

So, to make it clear - what is the recommended way for bundling and minification?
For now project template provides B&F task for user static (I mean .js and .css files) placed in wwwroot/js directory, but what about bower packs, placed in wwwroot/lib? These static files are hosted 'as is', without any compression or combining.

I think the default you get from File->New Project, where bower packages are dumped in wwwroot is the simplest solution but the wrong one for a real production site. I think this is kind of admitted in this blog post by Scott Hanselman where he says:

At some point you'll want to graduate to a more formal process and want to move your bower client libraries back out

Scott Hanselman

He then goes on to show a better approach which is what the project templates originally did, which was to have a bower_components folder and copy only the required files into the wwwroot.
In my ASP.NET MVC Boilerplate project template, I've gone with this more 'formal' approach.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Add single command to RN changelog generator script and refactor

Description
What issue are you trying to solve?
Create a new command to format a single commit as well as remove the token dependency for getting commit data
How does this change address the issue?

Makes the default behavior as a command
Create a single command
Extract out util functions

Test plan
Compared the following command before and after these changes:
# before
node lib/index.js --repo ~/react-native --changelog ~/react-native/CHANGELOG.md --base 0.67-stable --compare main
# after
node lib/index.js --repo ~/react-native --changelog ~/react-native/CHANGELOG.md --base 0.67-stable --compare main --token [mytoken]

and verified tests pass via yarn test:local

Can you run yarn change at the workspace root and add a change log?

Have addressed all the above comments and is ready for another look!
Have verified that running the following is the same as on main:
node lib/index.js --repo ~/react-native --changelog ~/react-native/CHANGELOG.md --base v0.66.4 --compare v0.67.0-rc.6 --token TOKEN

and running single command looks like:
node lib/index.js single -c 3bd11599c9d6aca5fa29ad291e9ad8b4a353bef4
https://api.github.com/repos/facebook/react-native/commits/3bd11599c9d6aca5fa29ad291e9ad8b4a353bef4
- Update bump-oss-version.js to guide releaser through release actions ([3bd11599c9](https://github.com/facebook/react-native/commit/3bd11599c9d6aca5fa29ad291e9ad8b4a353bef4) by [@lunaleaps](https://github.com/lunaleaps))
{
  doesNotFollowTemplate: false,
  changeCategory: 'general',
  changeType: 'failed',
  fabric: false,
  internal: true,
  turboModules: false
}

FYI: https://github.com/microsoft/rnx-kit/releases/tag/%40rnx-kit/rn-changelog-generator%400.2.0


Pushing updates live

@TaraMeyer,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Improve account controller usability

Make private variables for passPhrase & secondPassPhrase
return all account info to _account in constructor using AccountService.GetByAddress.
Remove all passPhrase & secondPassPhrase parameters in all methods in AccountController.  Replace with the _ variables

ok Agreed, nice suggestion


How should we list contributors in Cargo.toml(s)?

Now that we're going to start publishing our crates (#838), how what should we put for authors  in the Cargos.toml? All the crates have different authors listed, usually just whoever first created that package. What should we change them to to keep them consistent across everything? Relevant section in cargo docs

As I wrote a fairly large portion of the code, I don't mind being put as author. I prefer however something like rustpython team or something like that. Is this possible?

As package names I would prefer this:

rustpython-parser
rustpython-compiler
rustpython-bytecode
rustpython-vm

I propose to release rustpython-parser as the first package, since this is the least changing one.

I think we could, maybe something like:
authors = ["RustPython contributors <github.com/RustPython/RustPython/contributors>"]

I propose:
authors = ["RustPython Team"]

Sounds good to me!

I'll make a PR for this.

Unscribe me
On Wed, Jul 3, 2019, 12:48 PM coolreader18<EMAIL_ADDRESS>wrote:

Closed #1094 https://github.com/RustPython/RustPython/issues/1094.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RustPython/RustPython/issues/1094?email_source=notifications&email_token=AMLSORXQ7WOLXBVZZKQQFJTP5TJ5ZA5CNFSM4H4NT5R2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSKCU3EI#event-2458209681,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMLSORQTFDUUWTCNVCOU7FLP5TJ5ZANCNFSM4H4NT5RQ
.

There's a link at the bottom of this email for you to unsubscribe, I'll put it right here too: https://github.com/notifications/unsubscribe-auth/AMLSORQTFDUUWTCNVCOU7FLP5TJ5ZANCNFSM4H4NT5RQ.


Likes are not retrieved unless logged in

Instagram made a changes not allowing to see who liked the photo unless we are logged in.
I propose quick fix for those who need to solve this:
To solve it, one simple solution is to just add a cookie to the browser, thus getting logged in automatically.
You can get your instagram cookie if you use InstaPy, it is saved in logs file.
Let's say we name cookie: "insta_cookie.pkl" and we put it into logs folder.
Than to crawl_profile.py file, we add at the beginning:
import time
import pickle

and just after browser declaration (cca line 25) we add:
try:
    browser.get("http:www.google.com")
    time.sleep(1)
    for cookie in pickle.load(open('logs/insta_cookie.pkl', 'rb')):
                browser.add_cookie(cookie)
    time.sleep(1)
except:
    print ("adding cookie failed")

It is up to discussion is we want to include logging in feature into this project as well.

Nice job, but I think it's not a good practice to use cookies to log in because maybe someone didn't log in with his/her browser (which mostly true because people use mobile for instagram usage) and it'll fail so in my opinion its a better approach to log in completely (at least for first time and then save it for next use)

Hey @imansh77 I cannot merge this request, this would break every installation of instagram profilecrawl. you changed the complete behavior from calling the script with serval usernames to a script with just one username and credentials.
Please rewrite your code so the user login is optional.
perhaps by putting the user/pw settings into the script like Instapy does it....


Type is template

when I using
template<class T> using Width = NamedType<T, struct WidthTag>;
template<class T> using Height = NamedType<T, struct HeightTag>;
template<class T>
class Rectangle
{
public:
    Rectangle(Width<double> width, Height<double> height) : width_(width.get()), height_(height.get()) {}
    ......
}

so in the main.cpp, I have to write this:
Rectangle<double>  r(Width<double>(10), Height<double>(12));

I have to repeat double few times.

when I put it into class:

template<class T>
class Rectangle
{
public:
    using Width = NamedType<T, struct WidthTag>;
    using Height = NamedType<T, struct HeightTag>;
    Rectangle(Width width, Height height) : width_(width.get()), height_(height.get()) {}
    ......
}

so in the main.cpp, I have to write this:
Rectangle<double>  r(Rectangle<double>::Width(10), Rectangle<double>::Height<double>(12));

I have a better choice or make it better?

Befora C++17; use a free function to have automatic type deduction
In C++17: There is template type deduction for classes


Absolute wicket pathes don't work if deployment URL contains a path

By default I'm deploying to localhost:8080/orienteer-war which breaks most of the @MountPath wicket annotations (e.g. ListOClassesPage is annotated with @MountPath("/classes")) and causes resources to be unavailable on the server.

Is it related only menu panel on the left?
If you navigate manually to classes pages: can you navigate then by links?

All manual navigation works, all links of the menu panel on the left skip the deployment prefix.


Added path config for FBA widgets

This adds a mini version of what will become the widget path configuration file. It still needs to be reconciled with namespacing and such that's going on in the ease-dev-campaign branch, which in turn will need some updates in the Narrative.
This is put here to hopefully ease the way in the short term (pre-RSV) for linking the Narrative to use the FBA widgets that are currently only in ui-common.
There will be a parallel PR in the narrative repo shortly...

PR in narrative: https://github.com/kbase/narrative/pull/365

This is just adding a single file that doesn't touch anything else. It also seems to have all the dependencies in order when testing on dev. After an offline discussion with Mike, we decided it's best to merge and test on narrative-ci.


Print the error message from the environment configuration scripts at once

Here are two examples to show the difference before and after this change.

Example 1
Parameters

sdk: A
arch: x64

Comparison of GHA summary
Before

(X) <job_name>
     [ERROR:vcvarsall.bat] Invalid argument found : A

(X) <job_name>
     Could not setup Developer Command Prompt: invalid parameters

After

(X) <job_name>
     Could not setup Developer Command Prompt: invalid parameters [ERROR:vcvarsall.bat] Invalid argument found : A

Comparison of GHA log
Before
...
Error: [ERROR:vcvarsall.bat] Invalid argument found : A
Error: Could not setup Developer Command Prompt: invalid parameters
...

After
...
Error: Could not setup Developer Command Prompt: invalid parameters
[ERROR:vcvarsall.bat] Invalid argument found : A
...

Example 2
Parameters

sdk: 10.0.10240.0
arch: x64

Comparison of GHA summary
Before

(X) <job_name>
     [ERROR:winsdk.bat] Windows SDK 10.0.10240.0 : 'C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\um' not found or was incomplete

(X) <job_name>
     [ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***

(X) <job_name>
     [ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run

(X) <job_name>
     [ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.

(X) <job_name>
     [ERROR:VsDevCmd.bat] Where [value] is:

(X) <job_name>
     [ERROR:VsDevCmd.bat] 1 : basic debug logging

(X) <job_name>
     [ERROR:VsDevCmd.bat] 2 : detailed debug logging

(X) <job_name>
     [ERROR:VsDevCmd.bat] 3 : trace level logging. Redirection of output to a file when using this level is recommended.

(X) <job_name>
     [ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3

(X) <job_name>
     [ERROR:VsDevCmd.bat] vsdevcmd.bat > vsdevcmd.trace.txt 2>&1

As you can see, they are too much. And I have no idea why "Could not setup Developer Command Prompt: invalid parameters" is not here.
After

(X) <job_name>
     Could not setup Developer Command Prompt: invalid parameters [ERROR:winsdk.bat] Windows SDK 10.0.10240.0 : 'C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\um' not found or was incomplete [ERROR...
     show more

(X) <job_name>
     Could not setup Developer Command Prompt: invalid parameters
     [ERROR:winsdk.bat] Windows SDK 10.0.10240.0 : 'C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\um' not found or was incomplete
     [ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
     [ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
     [ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
     [ERROR:VsDevCmd.bat] Where [value] is:
     [ERROR:VsDevCmd.bat]    1 : basic debug logging
     [ERROR:VsDevCmd.bat]    2 : detailed debug logging
     [ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
     [ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
     [ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
     show less

Comparison of GHA log
Before
...
Error: [ERROR:winsdk.bat] Windows SDK 10.0.10240.0 : 'C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\um' not found or was incomplete
Error: [ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
Error: [ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
Error: [ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
Error: [ERROR:VsDevCmd.bat] Where [value] is:
Error: [ERROR:VsDevCmd.bat]    1 : basic debug logging
Error: [ERROR:VsDevCmd.bat]    2 : detailed debug logging
Error: [ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
Error: [ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
Error: [ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
Error: Could not setup Developer Command Prompt: invalid parameters
...

After
...
Error: Could not setup Developer Command Prompt: invalid parameters
[ERROR:winsdk.bat] Windows SDK 10.0.10240.0 : 'C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\um' not found or was incomplete
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
[ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
[ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
[ERROR:VsDevCmd.bat] Where [value] is:
[ERROR:VsDevCmd.bat]    1 : basic debug logging
[ERROR:VsDevCmd.bat]    2 : detailed debug logging
[ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
[ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
...

Oh no, I did a wrong conflict resolution.

Thank you for editing the text content. It should be collapsed it by default.
And I'm sorry I didn't make the progress smooth, please squash all the commits into one commit to avoid an ugly history.

@pzhlkj6612, no worries. As long as it applies cleanly, it's good.
I more or less default to squash-merging anyway unless there is a particular reason to do otherwise.
Thank you for your contributions!


Var calculation fails with non-pandas Dataframe

When using dask-cudf, the new parallel variance calculation will fail (PR https://github.com/dask/dask/pull/4865/) . This is probably due to two main causes

__array_interface__   isn't fully implemented: np.X (var/nansum) may not be supported but can be added see https://github.com/rapidsai/cudf/issues/1728
Tightly using pandas signatures: pd.Series -> Series(), pd.concat -> Concat

I'm not sure what the best action here is but I think there are two solutions:

fix cudf to work with the various numpy calls and update dask with generalized dataframe things
detect non-pandas dataframes and dispatch to old variance calculation

My preference is for option 1. Does the cudf side of things sound difficult?

I don't think it should be too bad -- i'll look at it shortly and come back with an update

I added __array_function__ to cuDF for numpy dispatch but ran into some trouble with dask core bits.  I didn't fully appreciate this at the outset, but using dask-array means the object being passed around needs to support much/all of the dask-array.  Parallel variance will eventually call to_dask_array -- a dask_cudf.Series currently does not support enough of the array like things to make it all the way through the array reduction machinery.
Another thing we could do is vendor in the old variance work into dask-cudf -- this would be a short term solution
cc @mrocklin

cc @pentschev (in case you have thoughts here 😉)

It looks like the most relevant changes in #4865 were in the dataframe context, which I don't know much about.
@quasiben if you need any help with __array_function__ I can try to take a look at it tomorrow.

That's correct. It was the __array_function__ bit that I thought you might find interesting. 😉

We'll work on fixing cuDF upstream and as a stopgap we can vendor over the old variance code so as to not slow down Dask. Thanks all!

In a chat with @mrocklin we briefly experimented with use cupy.array on the dask_cudf.Series obj.  This gets you quite far but trouble arises with the nansum.  Nansum has not been implemented but there is a TODO in the cupy src:
https://github.com/cupy/cupy/blob/0e4141428d4dace8d13e10ac58c844d3bb0d23c5/cupy/math/sumprod.py#L66
@pentschev would this be difficult to add ?

Not sure yet, I will take a look at it soon. Possibly, a specialized reproduction of sum will do.

Might be worth taking a look at PR ( https://github.com/cupy/cupy/pull/2222 ), which implements some other nan functions. The same strategy could be leveraged by nansum without too much difficulty.

Thanks @jakirkham for mentioning that PR, I would not have seen that otherwise! :)

More generally, it looks like we're now computing dataframe variance computations using numpy-like functions.  This causes problems with gpu dataframes/arrays due to null-handling, but I could imagine that it would also cause problems with other non-numpy compatible dtypes in the future (though perhaps those don't exist).

@quasiben could you try out https://github.com/cupy/cupy/pull/2252 and see if it works for you?

https://github.com/cupy/cupy/pull/2252 has just been merged, let me know if you encounter any issues with that @quasiben .

I will try this out tomorrow.  Thanks!

I believe we can close this now as a lot of work has gone into cudf to support __array_function__ calls:
In [1]: import cudf

In [2]: import dask.datasets

In [3]: ddf = dask.datasets.timeseries()

In [4]: cdf = ddf.map_partitions(cudf.from_pandas)

In [5]: cdf.head()
Out[5]:
                       id     name         x         y
timestamp
2000-01-01 00:00:00   983   George  0.355031 -0.200610
2000-01-01 00:00:01  1011    Kevin -0.784447 -0.212326
2000-01-01 00:00:02   991   George -0.295418  0.403791
2000-01-01 00:00:03   989  Norbert  0.474926 -0.494320
2000-01-01 00:00:04   963   Ingrid -0.845560 -0.586977

In [6]: cdf.x.var().compute()
Out[6]: 0.33295403416731695

In [7]: ddf.x.var().compute()
Out[7]: 0.33295403416731695


Issue with split view causes back button to break and app to become unresponsive

I'm using:
BlueBubbles installed from the windows store, version <IP_ADDRESS>
Issue:
In split view, if you press the back button on the right side (to hide the current settings page) and then try to press the back button on the left side, nothing will happen and various parts of the app then become non-functional. For instance, the back button breaks, the buttons in the change name dialog break, and attempting to right click the taskbar icon does nothing. The only way to get the app working again is force quit it and relaunch.

Steps to reproduce

While in split view mode, navigate to the settings page
Press the right-side back button
Press the left-side back button
App is now broken

Built the desktop app myself off of the latest version of the development branch (currently 34070330b48a135dee1c95a3e0e4467f8e410283). It appears the issue no longer occurs on this version.

Good to know, will close when there is a release


Bower article needs to be updated for changes to bower component installation

Manage Client-Side Packages with Bower was written for previous script installation / management which put bower_components in root and copied distributable scripts to wwwroot via gulp. That has been changed to installing bower components directly in wwwroot via .bowerrc.

@jongalloway Is this the new approach as of the Beta 8 release? I'm willing to tackle this article rewrite if the team needs some assistance. Just let me know.

@scottaddie Yup, this should be in beta8 (shipping this week), so if you want to submit a PR for this update that would be great. You can see what the beta8 templates look like in the newly public Templates repo: https://github.com/aspnet/Templates/tree/release/src/BaseTemplates/StarterWeb

@danroth27 Thank you for the info! Will start on this tonight.

@danroth27 Submitted a pull request. Let me know if something doesn't look quite right. I'm still learning Git.

@scottaddie I'm not seeing the PR

@Rick-Anderson Here you go. It was already merged: https://github.com/aspnet/Docs/pull/550


Delete through TestPage

1. Describe
If I'm not mistaken, it's still not possible to delete records using the test page. With ongoing improvements & enhancements of the app from the Microsoft side, tests are automated tests are the keystone for all companies...
We had an issue with our process that is started once the record is deleted by the user as there was a change from CZ localization.
We could prevent it by creating a simple AL test, but without support for deleting records through the test page, we can not...
I found #3253 from 2018 that it's on your backlog

Hi, this is not in our immediate backlog, so we don't have an ETA on when this will happen. The best way to get traction on this is to post it on BCIdeas at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release.


Clarity on lock retry behaviour inside and outside transactions

I'm seeking clarification about the lock retry behaviour when running the migration outside of a transaction.
In the docs you explicitly state the retry behaviour when the migration runs inside a migration

When statement within transaction fails - the whole transaction is retried.

However when running the migration without a transaction via disable_ddl_transaction! it's not clear in the docs but my assumption is that the LockRetrier does the same. E.g. in the test code it shows the migration is retried by the LockRetrier mechanism (if set).
Can you please clarify the behaviour is as I assume. I'm happy to get a PR up to update the configuring.md doc as well.

Yes, your assumption is correct. Please do open a PR.

Hmm, I'm not sure if https://github.com/fatkodima/online_migrations/blob/9cebfd00b870ab246e813d8109767ccaf10a7df6/test/lock_retrier_test.rb#L49 is as clear as it could be.
$migrate_attempts is only incremented once, here. After that, add_column :users, :name, :string tries, and fails.
The change in https://github.com/fatkodima/online_migrations/pull/51 implies that now  add_column :users, :name, :string will be retried. If that's the case, I would expect this test to have an infinite loop, or to have the lock be removed and the column cleanly added. If the latter is the intended behaviour, I think the test should assert that. But I think what's more likely is that there is no retrying happening at all in this test.
Given that, I think what the docs should say is:

When a statement within transaction fails, the whole transaction is retried. If any statement fails when running outside a transaction (e.g. using disable_ddl_transaction!), that statement will not be retried.

@fatkodima @camallen what am I missing?

The $migrate_attemps is equal to 1, because we actually run the whole migration change method only once. It demonstrates, that we do not retry the whole transaction (because there is no even one).
But we run add_column multiple times.
The runtime of the whole migration looks like this:
def change
  $migrate_attemps += 1
  add_column ... => raises lock error
  add_column ... again.. => raises lock error again
end

Ahhh now I see what's going on. https://github.com/fatkodima/online_migrations/blob/2040b8699e470e6dd29cc2be2daddb0b511b1bc5/lib/online_migrations/migration.rb#L27 is where each statement is wrapped with a lock retrier. Neat 👍


handle config.active_record.logger = nil

FIxes #168

duplicated in #175

That's not really a duplicate because this supports Logger (I just noticed it's missing a parenthesis though)


[Q] How to store images as files and efficiently reference them in tables?

Hello,
I would like to save images into a directory so I have the raw images available locally (save the file locally then call wandb.save()), and then I would also like to log references to these images into tables (use image = wandb.Image(filepath) and wandb.Table(image). I don't want the image data repeated / stored twice, since the images are relatively large (several MB each). I'm planning on storing a few hundred images per run.
Will this approach above avoid data being stored twice? I know I can use the API to extract the images from the table but I want to store the images as raw files for easier post-processing.
Thanks!

Hi @collinmccarthy , not sure if what you had in mind is the most efficient way of working with an image dataset. You can use artifact.add() to log tables to the Artifacts section of your run instead of the workspace. This could be useful if you have a dataset that you want to log once and then reference for future runs. See here in our docs, and additionally this report example on the above. Please let me know if this works for you use case.

Hi @collinmccarthy , following up on this request. Do you still need assistance with your logging images workflow
?

Hi @collinmccarthy, since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!

Hi @MBakirWB sorry for the delay here. A couple of things to clarify my goals:

I do want to log to the workspace so I can see / compare tables across runs easily
I am going to log this image every run (to see how good my segmentation predictions are)

An ideal workflow for me would be the following:

Create an image and save it locally to filepath
Log the image directly to my files and get the saved path with saved_image= wandb.save(filepath)
Use that previous path to add the file to a table in the workspace with wandb.Table(saved_image)

I would hope the wandb.Table call would recognize that the path I gave it was within a wandb subfolder and therefore not create a second image (png) file in my media/ directory. There would only be one version of the file in my files folder for the run, from when I called wandb.save(). Does this make sense?
Anyway, it's not the biggest deal, and from what I can tell this is more of a feature request. At a higher level I want to be able to create wandb.Table objects in my workspace that are simply different ways of viewing the data that's already there, not duplicating it. But I can imagine that would be a more difficult change to implement so I understand if this is not a realistic request. I'll go ahead and close this ticket since my question is answered. Thank you!


Remove extra spaces from holiday names

Coverage decreased (-0.0001%) to 99.63% when pulling 06a17336074b01221e228eb9cda7ea1d74e958b8 on KJhellico:fix-spaces into 5c9ab076dd007d165a4beac92e184ee9b8b50527 on dr-prodigy:beta.

:+1:


[Templates] Create sample template for Success Email

Description:

We need to create a few sample email templates using react-email so that people can easily pick and use those templates as per their needs. This ticket is for creating a sample email template for the Success Email. People can use this template for sending successful emails to the receivers, for example: "You have been registered to our platform successfully", "Thank you for subscribing to our newsletter", "Your password has been reset successfully", etc.

Reference:
You can watch this video to get complete info about the package and how to use it to build clean and responsive email layouts easily.
Outcome:

A sample email template for the Success Email using react-email and TypeScript, under the samples/ folder.

i'm interested can i join

Sure @ayobamiseun, go ahead. Do let me know if you need any help.
Also, make sure to drop a star on the repo to support the project and open-source🌟😇

Hey, I'm interested in working on this issue. Can you please assign this to me?

and can you please specify the path where I could exactly find this folder?

Hi @KartikeyDubeyKD, thanks for showing interest to work on this issue. Please go ahead and do the changes.
Right now there is no samples/ folder, you can create one at the root of the project just like example/.
Do let me know if you need any additional help.
Also, make sure to drop a star on the repo to support the project and open-source🌟😇

Hi @KartikeyDubeyKD @ayobamiseun, any update on the process?
If you're still working on it or need any help, feel free to ping here. Otherwise we can assign the issue to someone else.

I'm working on it, I'll finish it today. Sorry for the delay

hey @niloysikdar, can you guide me on getting started in this contribution? :)


Add auto import setting as a language status item

Since we changed the default value of "python.analysis.autoImportCompletions" to false, it would be nice if we could expose auto imports in the language status menu alongside type checking mode, to make it more discoverable.

This issue has been fixed in prerelease version 2023.10.11, which we've just released. You can find the changelog here: CHANGELOG.md


Updated availability table

@Antvgski : Thanks for your contribution! The author, @mlee3gsd, has been notified to review your proposed change.

sign-off


⚠ Bofrost.fr has degraded performance

In fffb463, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1417 ms

Resolved: Bofrost.fr performance has improved in a1e5bf4.


notification-bar: rename 'warning' style to 'danger'

Since the background-color is $danger-color, we should rename this class to make it consistent.
I gripped the codebase for "notification-bar", and fixed all the references I found.
Resolves #3164.

Thanks @alexwlchan !
@di, this is ready to merge, but will require updates to PyPI theme:
https://github.com/python/pypi-theme/blob/master/pypi_theme/templates/testpypi-banner.html#L1
https://github.com/python/pypi-theme/blob/master/pypi_theme/templates/pypi-banner.html#L1

@nlhkabu We should merge changes there, make a new release of pypi-theme, and then merge this PR, so I'm going to put the blocked label on this until then.

@di, PR made on PyPI theme.


Open GEXF - To clear or not to clear.

To clear or not to clear. (the current graph)

Which graph?

The graph displayed in the widget before the new .gexf file is opened


Can not install offcial Python Extension into a container (but can install other extensions)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:

Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:37:28.172Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.5.0

OS Version:

This is the OS version of the container in remote machine.
root@592bb763c392:/# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

This is for the remote machine.
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
VERSION_CODENAME=stretch
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

This is local machine (A Mac where Vscode software installed)
macOS Catalina
10.15.5

Steps to Reproduce:

I start a new container as usual, and first use remote ssh to connect to remote machine, then from remote machine connect to the new container.

I first saw this prompt message, so of course I go to the extension bar and try to install Python.

But it is always in installing state.

The logs is like:

I can install any other extension (compared to the above pic,  extension Python for VSCode has been successfully installed, but Python is still installing. because this, I believe this weird phenomenon is not due to my network...)

Supplementary material:
Is it possible due to my container name (very simple, just two numbers 22)? But this name works before...

What's happening when you click on Install in Container buildim... button? If it is not installing, can you please share following logs?

F1 > Open View... > Log (Window)
F1 > Open View... > Log (Remote)

Hi @sandy081 , after I restart/reset all three (my Mac, my remote Debian, delete and re-run a new container on that Debian), now Python extension can be successfully installed —— and unfortunately, the bug (only Python extension cannot be installed but all other extensions can) cannot be reproduced at present 😅.


browser support?

Should this work on browser?
I have tried to use nottinygc in our WASI project, but it fails.
With the standard tinygo GC the execution runs successfully.

Tested using @wasmer/wasi npm package and also https://github.com/bjorn3/browser_wasi_shim
We are using tinygo 0.28 (current dev branch).
Any hint is welcome! Thanks.

Hi @p4u - to be honest browser support isn't a priority but with a wasi shim present, I don't see a reason it generally wouldn't work as the usage of wasi is relatively limited.
Can you confirm you are compiling with -scheduler=none as in the README? That stack trace looks somewhat familiar as what I see when forgetting the flag - currently unfortunately the scheduler isn't supported as I haven't been able to figure out how to debug the crash when not disabling it.
If you are using that flag, would you be able to share anymore details such as the whole tinygo invocation, or even the Go source code if it's public?

The code is public yes, I'll polish it a bit and provide the repository link.
Thanks for your work.

I have been able to reproduce the same behavior with wasmtime.
I'm using the following command to compile on tinygo 0.28.1
tinygo build -target=wasi -opt=1 -gc=custom -tags="custommalloc nottinygc_finalizer" -scheduler=none -o artifacts/g16_prover.wasi wasi/main.go
Now the error has a trace that points to nottinygc@v0.3.0/gc.go:54:20
GC Warning: Out of memory - trying to allocate requested amount (4112 bytes)...
Error: failed to run main module `artifacts/g16_prover.wasi`

Caused by:
    0: failed to invoke command default
    1: error while executing at wasm backtrace:
           0: 0x17369 - abort
                           at /home/p4u/repos/vocdoni/tinygo-fresh/lib/wasi-libc/libc-bottom-half/sources/abort.c:5:5
           1: 0x1792d - sbrk
           2: 0x1437 - <unknown>!GC_unix_get_mem
           3: 0x1753 - <unknown>!GC_init_headers
           4: 0xa899 - <unknown>!GC_init
           5: 0xb0af - <unknown>!GC_generic_malloc_inner
           6: 0xb3b6 - <unknown>!GC_generic_malloc
           7: 0xb445 - <unknown>!GC_malloc
           8: 0x1ce74 - runtime.alloc
                           at /home/p4u/go/pkg/mod/github.com/wasilibs/nottinygc@v0.3.0/gc.go:54:20
           9: 0x2b328 - <unknown>!runtime.initAll
          10: 0x2b163 - runtime.run
                           at /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/scheduler_none.go:24:9              - _start
                           at /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:21:5
    2: wasm trap: wasm `unreachable` instruction executed

Thanks, it's good to hear we can repro outside browser as it'll be easier to debug. If it also repros with wazero, it has some nice debugging features that may help even more. Will be happy to give it a try if you're able to share a repo.
In the meantime, I have created a branch with bdwgc compiled with debug symbols, it might give some more info if you try building with it instead
https://github.com/wasilibs/nottinygc/tree/bdwgc-dwarf
go get github.com/wasilibs/nottinygc@04597e1e005659483aa197a30c68aeb8070d0e0f
That being said, the most interesting would be the line number within sbrk, unfortunate that for some reason we're getting the line number in wasi-libc's abort but not sbrk 😿
I have tried one guess though, if you can try it out that would be great
https://github.com/wasilibs/nottinygc/commit/a17c52165f0439687410f4344507c657487e16f2
go get github.com/wasilibs/nottinygc@a17c52165f0439687410f4344507c657487e16f2

Using 04597 and wazero
GC Warning: Out of memory - trying to allocate requested amount (4112 bytes)...
error instantiating wasm binary: module[] function[_start] failed: wasm error: unreachable
wasm stack trace:
	.abort()
		0x164e2: /home/p4u/repos/vocdoni/tinygo-fresh/lib/wasi-libc/libc-bottom-half/sources/abort.c:5:5 (inlined)
	.sbrk(i32) i32
	.GC_unix_get_mem(i32) i32
	.GC_init_headers()
	.GC_init()
	.GC_generic_malloc_inner(i32,i32) i32
	.GC_generic_malloc(i32,i32) i32
	.GC_malloc(i32) i32
	.runtime.alloc(i32) i32
		0x1c016: /home/p4u/go/pkg/mod/github.com/wasilibs/nottinygc@v0.3.1-0.20230616010811-04597e1e0056/gc.go:54:20 (inlined)
	.runtime.initAll()
	._start()
		0x2af72: /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/scheduler_none.go:24:9 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/panic.go:52:7 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:21:5 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/interface.go:91:16 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:73:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:91:21 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1613:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1101:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1082:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1122:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1135:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:321:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:368:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:442:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1291:19 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1280:26 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1261:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1229:59 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:478:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:646:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:512:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:770:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:624:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:271:12 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/algorithm.go:615:8

Same output using a17c521 and wazero
GC Warning: Out of memory - trying to allocate requested amount (4112 bytes)...
error instantiating wasm binary: module[] function[_start] failed: wasm error: unreachable
wasm stack trace:
	.abort()
		0x164e2: /home/p4u/repos/vocdoni/tinygo-fresh/lib/wasi-libc/libc-bottom-half/sources/abort.c:5:5 (inlined)
	.sbrk(i32) i32
	.GC_unix_get_mem(i32) i32
	.GC_init_headers()
	.GC_init()
	.GC_generic_malloc_inner(i32,i32) i32
	.GC_generic_malloc(i32,i32) i32
	.GC_malloc(i32) i32
	.runtime.alloc(i32) i32
		0x1c016: /home/p4u/go/pkg/mod/github.com/wasilibs/nottinygc@v0.3.1-0.20230616013945-a17c52165f04/gc.go:54:20 (inlined)
	.runtime.initAll()
	._start()
		0x2af72: /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/scheduler_none.go:24:9 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/panic.go:52:7 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:21:5 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/interface.go:91:16 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:73:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:91:21 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1613:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1101:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1082:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1122:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1135:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:321:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:368:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:442:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1291:19 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1280:26 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1261:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1229:59 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:478:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:646:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:512:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:770:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:624:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:271:12 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/algorithm.go:615:8

Let me know if there is anything else I can try. I wonder if the issue is related to mimalloc C library. Would it make sense to try an updated version of it?
I am preparing the repository, so you can try to reproduce. It is not easy because there are many repositories forked and modified, and even tinygo requires some small modifications (related with reflect package).

Thanks a lot for trying 🙏
I did try updating mimalloc a little back and ran into this issue, let's see if anyone can help with it
https://github.com/microsoft/mimalloc/pull/758
But if your app is entirely TinyGo, you won't be exercising mimalloc at all so maybe not an issue. This library originated in code using TinyGo with re2 c++ library linked in to fix it's regexp support, in such scenarios mimalloc gets used.
Thanks for using wazero, it has a parameter to log function calls - it'll be a huge dump but I would use it to see what the parameter to the sbrk call is. If it seems like a tough task happy to try it after the repo becomes ready. Yeah I've been down the custom TinyGo road too 😅

Thanks for using wazero, it has a parameter to log function calls - it'll be a huge dump but I would use it to see what the parameter to the sbrk call is. If it seems like a tough task happy to try it after the repo becomes ready. Yeah I've been down the custom TinyGo road too sweat_smile

So, your work on nottinygc might be a game changer for us and all the people trying to use WASI+tinygo. Memory management is a big issue on browsers when using WASM. Thus, I'll do whatever is in my hands to help you debug this issue. What's the wazero parameter to log function calls?

But if your app is entirely TinyGo, you won't be exercising mimalloc at all so maybe not an issue. This library originated in code using TinyGo with re2 c++ library linked in to fix it's regexp support, in such scenarios mimalloc gets used.

Understood.

Apologies, while direct usage of wazero can log wasm function calls, it looks like the CLI only exposes host function logging. Let me see if this is something changable
https://github.com/wasilibs/wazero/blob/main/cmd/wazero/wazero.go#L185

Apologies, while direct usage of wazero can log wasm function calls, it looks like the CLI only exposes host function logging. Let me see if this is something changable
https://github.com/wasilibs/wazero/blob/main/cmd/wazero/wazero.go#L185

I could modify wazero source code locally and install a version with this flag always enabled.

Ah! I understand wrong the issue. So I'm using wazero cli for runing the WASI binary.
Here the output:
wazero run --hostlogging=all artifacts/g16_prover.wasi                                                                                 INT ✘
--> ._start()
	==> wasi_snapshot_preview1.environ_sizes_get(result.environc=54892,result.environv_len=54888)
	<== errno=ESUCCESS
	==> wasi_snapshot_preview1.fd_prestat_get(fd=3)
	<== (prestat=,errno=EBADF)
	==> wasi_snapshot_preview1.clock_time_get(id=monotonic,precision=1)
	<== (timestamp=7416046245433,errno=ESUCCESS)
	==> wasi_snapshot_preview1.clock_time_get(id=monotonic,precision=1)
	<== (timestamp=7416046258808,errno=ESUCCESS)
	==> wasi_snapshot_preview1.clock_time_get(id=monotonic,precision=1)
	<== (timestamp=7416046260113,errno=ESUCCESS)
	==> wasi_snapshot_preview1.clock_time_get(id=monotonic,precision=1)
	<== (timestamp=7416046261331,errno=ESUCCESS)
	==> wasi_snapshot_preview1.args_sizes_get(result.argc=65168,result.argv_len=65208)
	<== errno=ESUCCESS
GC Warning: Out of memory - trying to allocate requested amount (4112 bytes)...
error instantiating wasm binary: module[] function[_start] failed: wasm error: unreachable
wasm stack trace:
	.abort()
		0x164e2: /home/p4u/repos/vocdoni/tinygo-fresh/lib/wasi-libc/libc-bottom-half/sources/abort.c:5:5 (inlined)
	.sbrk(i32) i32
	.GC_unix_get_mem(i32) i32
	.GC_init_headers()
	.GC_init()
	.GC_generic_malloc_inner(i32,i32) i32
	.GC_generic_malloc(i32,i32) i32
	.GC_malloc(i32) i32
	.runtime.alloc(i32) i32
		0x1c016: /home/p4u/go/pkg/mod/github.com/wasilibs/nottinygc@v0.3.1-0.20230616013945-a17c52165f04/gc.go:54:20 (inlined)
	.runtime.initAll()
	._start()
		0x2af72: /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/scheduler_none.go:24:9 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/panic.go:52:7 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:21:5 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/interface.go:91:16 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:73:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/hashmap.go:91:21 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1613:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1101:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1082:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1122:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1135:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:321:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:368:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:442:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1291:19 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/env.go (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1280:26 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1261:22 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:1229:59 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:478:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:646:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:512:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:165:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:770:15 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/arch_tinygowasm.go:624:24 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/runtime_wasm_wasi.go:271:12 (inlined)
		         /home/p4u/repos/vocdoni/tinygo-fresh/src/runtime/algorithm.go:615:8

Thanks a lot for these repro directions! So I think a major issue is "--initial-memory=2147483648". A big difference between TinyGo's allocator and this one is that TinyGo assumes ownership of the entire heap, while here we request memory for usage, and things like mimalloc an also request from the heap, they each get pages that don't collide.
--initial-memory is the amount of memory reserved by the binary but is not about capacity - for a model where the allocator takes over the entire heap, it does effectively allow it to "preallocate", but otherwise it is more about how much memory is used by the data segment etc of the wasm binary. And when --initial-memory == --max-memory, for a system like nottinygc, that means there is no more memory left to request so it fails with out of memory. It is important for initial-memory to not be set when using nottinygc (I didn't think about this issue until debugging this so this looks like a good point to add to the docs, thanks).
For preallocating a fixed-size heap, a flag could be added to wazero or similar because in the end it is the runtime that sets up the heap, just like it would be the JVM doing it. It might also be possible for this library to provide a utility function to call on startup for it, and presumably even just something like _ = make([]byte, 2*1024*1024) would accomplish something similar.
So I tried removing the flag and now have this mysterious error I haven't seen before, though some logic does seem to be run
GC Warning: Failed to expand heap by 131072 KiB
GC Warning: Failed to expand heap by 131072 KiB
GC Warning: Failed to expand heap by 131072 KiB
GC Warning: Failed to expand heap by 64 KiB
GC Warning: Out of Memory! Heap size: 4012 MiB. Returning NULL!

Will keep on looking but wanted to give this update just in case it could spur any ideas too.

Looking at the traces closer, it does look like at startup, the heap is growing up to 2GB, which is the limit causing the Failed to expand heap. When I remove --max-memory, then it goes up to 4GB, which allows it to get past startup, but then still fails at that limit.
While I have seen cases where TinyGo's default allocator will have fragmentation causing out-of-heap where nottinygc fixes the problem, it doesn't mean things are ideal with nottinygc either. Just want to confirm, does this sound like a problem with the garbage collector or is it possible the code itself has a memory leak unrelated to GC?

BTW, bdwgc, the library this wraps, has many environment variables which work just fine with -env option to wazero run, for example GC_PRINT_STATS
https://github.com/ivmai/bdwgc/blob/5520e1c8379615bab14ac0ee0a8e8ff57ce586e2/docs/README.environment#LL20C1-L20C15
Also, it looks like it already has a GC_INITIAL_HEAP_SIZE option which may be what you need for presizing, though first we need to get it to actually work before optimizing :)

Looking at the traces closer, it does look like at startup, the heap is growing up to 2GB, which is the limit causing the Failed to expand heap. When I remove --max-memory, then it goes up to 4GB, which allows it to get past startup, but then still fails at that limit.
While I have seen cases where TinyGo's default allocator will have fragmentation causing out-of-heap where nottinygc fixes the problem, it doesn't mean things are ideal with nottinygc either. Just want to confirm, does this sound like a problem with the garbage collector or is it possible the code itself has a memory leak unrelated to GC?

The code performs hundreds of thousands of arithmetic operations. For doing so, it stores in memory enormous tables of uint64[4]. There might be a leak, but I think it is just the normal behavior. It might be that 4 GiB is not enough.
I used initial/max memory tinyGo flags because in my understanding there is some issue with memory expansion in the browser. For some reason, if I don't set --min-memory to the maximum required amount for the heap memory, the program stops its execution when the min is reached.
However, if nottinygc can properly expand the memory on browser, I don't need to set the minimum. The code will be a little slower because it requires to expand, but should not be relevant.
Finally, it might be that the code you are testing requires more than 4 GiB. In that case, it cannot be executed on browsers. I would need to perform some changes and optimizations. On previous tests, I achieved 1.8 GiB, so should be possible.
Now that I know the min-memory issue (IMHO it would be ideal if nottinygc crashes in compilation time if min-memory is set by tinyGo), I will try again with the previous code and see if it works.
I greatly appreciate your help.

So, I can confirm there is some issue when using nottinygc regarding the memory allocation. And this seems a deeper problem.
I have rolled back to the more optimized code I have. This code has been tested on several browsers and works.
Without using nottinygc, I'm able to execute the code and the runtime allocates up to 1.74 GiB (I have profiled it, but I can also see the number using the top command during the execution).
File: g16_prover.wasi
Type: alloc_space
Time: Jun 19, 2023 at 10:03am (CEST)
Duration: 21.70s, Total samples = 1.74GB

Same code using nottinygc (removing the --min and --max memory flags of tinyGo).
Memory allocation goes up to 18 GiB and crashes GC Warning: Out of memory - trying to allocate requested amount (16384 bytes).... Probably it reaches some operating system limit.
In my opinion, there is some issue with nottinygc related to how the memory is liberated. It might be that it's not "fast" enough and the heap grows without opportunity to decrease?  Maybe you never tested before with a program that performs thousands of operations and allocates so much memory at once?
I'm not certain how to proceed from this point. What do you think?

I have updated the repositories so the version of the code that consumes 1.74 GiB can be tested. Just in case it is useful for something...
You would need to add these three commits on top of the current tinyGo dev branch: https://github.com/vocdoni/tinygo/tree/wasi3
Then you can checkout wasi_nottinygc branch of gnark-prover-tinygo and execute the test.
git clone  https://github.com/vocdoni/gnark-prover-tinygo -b wasi_nottinygc
make prover-tinygo-g16-wasi-wasmtime

Thanks for updating the repo @p4u - I will investigate a little more later this week. I'm not confident I will find anything great, but let's see. Unfortunately bdwgc is also a conservative GC, so while it seems to perform much better than the TinyGo default GC, it may end up using extra memory anyways in this sort of application. I will try running the code with some bdwgc debug variables to see if it's possible to understand the behavior better.

Hi @p4u - just did a brief look again and noticed the crash stack trace showing regexp
		         <Go type>:156:32 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/regexp.go:872:15 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/regexp.go:191:14 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/syntax/parse.go:71:29
	.regexp.MustCompile(i32,i32) i32
		0x5b303: /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/regexp.go:137:16 (inlined)
		         /Users/anuraag/git/tinygo/src/runtime/runtime.go:76:22 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/sort/sort.go:26:21 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/regexp.go:317:24 (inlined)
		         <Go type>:156:32 (inlined)
		         /opt/homebrew/Cellar/go/1.20.5/libexec/src/regexp/syntax/parse.go:71:29
	.runtime.initAll()
	._start()
		0x49dd8: /Users/anuraag/git/tinygo/src/runtime/scheduler_none.go:24:9 (inlined)
		         /Users/anuraag/git/tinygo/src/runtime/runtime.go:76:22 (inlined)
		         /Users/anuraag/git/tinygo/src/runtime/extern.go:26:21 (inlined)

I couldn't git grep regexp in your repo but perhaps a dependency uses it. I have found regexp with tinygo to be mostly unusable even with nottinygc, it can even fail to compile some expressions outright. It might be tricky if it's being used by a dependency, but would you be able to give go-re2 a try?
https://github.com/wasilibs/go-re2

Hi @p4u - it's been a long time I don't know if you are still looking at this. After seeing another similar repro, I had some hints and have made a patch. Basically

Large amounts of random data
Using most of the 32-bit limit

cause the default conservative GC to fail because the probability of misidentifying pointers goes up tremendously. bdwgc has a note about it here
https://github.com/wasilibs/nottinygc/pull/24
So I have started adding type information, starting with only arrays
https://github.com/wasilibs/nottinygc/pull/24
There is more that can be done, but I believe arrays are probably the most significant issue so if you still are interested, perhaps you can try the latest version of main and see if it helps you? For context, I could confirm it fixes the issue with random embedded files (i.e., large byte arrays of random data in global variables) reported in https://github.com/corazawaf/coraza-proxy-wasm/issues/234

Hi @p4u - having not heard back I am going to go ahead and close this issue, but feel free to reopen if you want to continue investigating.

Hey @anuraaga I'm busy with other stuff right now and due to the issues I skipped using nottinygc. However, I think this is a very important and useful feature for WASM+tinygo, so I hope I can find some time in the future to test it.
Thans for your work.


feat(connector): [Coinbase] Add order id as the reference id

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Relevant documentation here. I'm not 100% sure what code is in the documentation but they haven't provided more clarity, the only other identifier for the transaction is id, so I've used that.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

Fixes #2326
How did you test it?

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

@Ceres445 Thanks for the PR

Hey @Ceres445
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!


broken link in page https://help.sap.com/docs/btp/sap-business-technology-platform/managed-application-router?version=Cloud

Issue description
on the page there is a broken link:

-------------------------------------------------------------------------------------------->
Feedback Type (Optional)
None
Page Title on SAP Help Portal (prefilled)
Managed Application Router
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/btp/sap-business-technology-platform/managed-application-router?version=Cloud

Hello @bvarwig!  Thanks for pointing this out.  We fixed the broken link.  You will be able to see this change on SAP Help Portal after the next content update.

I am closing this GitHub issue as the link is fixed.


Reduce npm package

The small npm package size is one of the key features of this package. There is a reason to use every micro-optimization for art reasons.
For instance, adding and calling clean-publish  instead of npm publish will remove devDependencies, lint-staged, etc from package.json.

Thanks! With clean-publish I was able to go from 12 kB to 10.9 kB But I feel it's not the limit.
Wanna try minifying the code to see If i can stay below 10.0 kB.

I was able to go below 10.0 kB by removing docstrings and other non relevant stuff from sources in npm. Think the next stage is automating the process with github actions
Gonna close the issue for now, Thanks!


[BUG] milestones tab ui is not consistent with others

Description
in milestones tab: there is no padding between add milestone button and alert.
Screenshots
currently:

it should be like event tab:

Additional information
No response

Thank you for raising the issue  👍

Hi. I can work on this issue. Please assign it to me

Sure, assigned to you @ZeeMonk-pixel

Thank you. I was looking at the picture for the events above, there's margin to the left and right of the alert, should I add that to the milestone or just give a margin top and bottom. Which of the frames below works? 1 or 2?
FRAME 1

FRAME 2

Good question 👍  We should be consistent, where do the existing margins come from and I would do the same

Great


Update 03-database-notifications.md

External notification information

[ ] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Sending database notifications is explained in the section right above it: "Sending database notifications".


Add ETH

Add ETH

0xf165145e054Ee968F88295E42283af4335d798d0

Is there any problem?
If you wanna to submit token, please check the README carefully.
Please don't open any meaningless issues


Stage deployment

Currently if we want to update the database, the service has to be down overnight.  This should be fixed.

This reload came about when "semantic_type" duplicates were discovered in the redis database. Since this DB had undergone numerous reloads of other data subsets duplicates were presumed elsewhere so a reload was warranted.
I think we have a couple options going forward:
1.) Load another redis instance and create a backup of it. wipe then reload the backup on the production instance. it is unknown at this writing how long it will take to reload this DB from a backup as it contains ~40GB of data.
2.) get smarter about how things are reloaded and avoid creating duplicate records so the refresh can be done "in place".  I am looking into this now.

i modified the code a bit to not allow duplicate entries into the cache.
on the last reload of the database i used the approach of creating an entirely new cache instance and replaced the production version with it.


Refactoring RXingResultPoint usage

Since this is a library that works with images, naturally there's a ton of 2D point math going on in the code. I feel like putting in effort here will have a big return on investment, since it's such an integral part of the program logic.
Some points that can be improved in particular:

The struct seems to be mostly passed around by reference. This means we end up with dereferences everywhere and the code is harder to follow. The struct itself only holds two floats, so passing it by value would be better I think.
Point logic can be refactored in some places to make the intent clearer.
Some functions expect rectangles, which are typed as &[RXingResultPoint]. A dedicated rectangle type would be better here for type safety.

I'm opening a PR that addresses the first point, and I'd like to tackle points 2 and 3, though that's a more long-term goal.

I'll add to this by saying: we might do the same math in multiple places. I know that there is a module where result point math is done, a place in math_utils, and a bunch of op implementations as well. It all over the place. I think in the c++ ported parts of datamatrix I'm more likely to have passed it by value.

I see that besides RXingResultPoint there's also a Point struct and a ResultPoint trait. What do you think about removing the latter two and renaming RXingResultPoint into just Point or something similar? All it does is it holds X and Y coordinates, so the RXingResult- suffix feels unnecessary since the struct doesn't hold anything RXing-related.

I feel fine with that chain of logic. The Point is probably from something I ported from C++ and was in an hurry and didn’t spend any time figuring out what I had already done. The ResultPoint is because the java has an interface for it, but I don’t know how useful that is. I think there might be something to be said for making a generic version of it that can handle f32, f64, u32, u64. The C++ version does that, but I don’t remember why.

I've edited the original comment to include a list of goals for this issue. Let me know if you have any suggestions or comments.

I’ll have to double check, but I don’t think this should require a full version bump to 0.4.0.
Well, now that I’ve typed that I think I am wrong. We do expose that through both the serde binding and through the ResultMetadata return value. I don’t mind moving to 0.4, but I’d like to batch up some other breaking changes and do them together.
Other things I’d like to do in 0.4: possibly migrate to using a HashSet for the EncodeHints and DecodeHints because the HashMap has never been rust reasonable and only made sense in Java, POSSIBLY actually do the work to move the reader chain that includes Binarizer, LumaSource, and Reader to use generics instead of &dyn Trait. I should make a milestone for that.

If renaming RXingResultPoint is a breaking change, we can still refactor the repo to use Point and use an alias to not break things for the user:
pub type RXingResultPoint = Point;

Once we're reading for a version bump, it'll be as simple as removing the alias. Does this sound good or am I missing something else besides the renaming that also makes it a breaking change?
I've already created an alias type actually; I had to because a proc macro needed it; take a look at this commit.

That should be fine, actually (there is another rust trick I forgot!).
In the not so distant future I’m going to move those macros into the main repository and rearrange things so that the root of this repository is a workspace with the proc-macro crate and the main library (as suggested in #7). That seems less prone to failures when making changes across the two.

Reopened because it was autoclosed when I merged in #13

Yeah, that's a bit sucky. From what I can tell, the only way to link an issue inside a PR without write privileges is by writing Closes #number, but it auto-closes the issue as well. Wish there was a Related to #number that linked but didn't auto-close.
Anyway, next up I'm planning to tackle the various number conversions related to point creation, as well as replacing various (f32, f32) pairs with actual point values.

fe8f89cd29960f70dce641eb08f3f01d0d71c462 addresses "Remove the Point type in the aztec module"


Site being flagged by Avast Antivirus

kindly inform the AV company as False positive

You can safely uninstall Avast or set exclusion rules

Here's more information, at least when I'm getting this notification. It wasn't triggering this a couple of days ago. So something changed on the JS, or on Avast's end

@ryanbenson
This scanner just flags whatever ends with *.js as suspicious. It doesn't even bother fetching the actual content of the URL. It isn't helpful at all.

I would not call Avast as the most reputable software out there either. Other scans are clean https://www.virustotal.com/gui/url/8045fe2d42eb174d88e678cbe3ec4a85526c2d1cdbcea18c82c3cb4332b5563f/detection
The reference to the URL has lived there since ever https://github.com/MadeBaruna/paimon-moe/blob/a13901524bbc7d791495b707640145696850ab5e/src/app.html#L19
The content would be automatically generated by plausible.io
If anything you should contact plausible.io or Avast directly.

@jogerj

I would not call Avast as the most reputable software out there either.
...
Other scans are clean

Avast has a pretty good reputation. It's not perfect, but it's not genuine to say it's not reputable. Probably the thing hurting their reputation the most is their privacy concerns, not their security. https://selabs.uk/reports/home-endpoint-protection-2022-q2/ shows it's ranked pretty high in security.
And other scans are clean, that's why I posted Google's, as they say it's clean too.

Google is flagging it as safe: https://transparencyreport.google.com/safe-browsing/search

For why it's being flagged, I can't tell you. I posted more information to help because the original issue report didn't have much to go off of. You're right that it could simply be them flagging Plausible.io as a whole.
But like I said, something changed either on a recent release, or on security scanners to start flagging the script, or the domain.
Agreed that the best course is to reach out to Avast and/or Plausible about this. They'd be able to determine the root cause of it being flagged.

@RaSan147 Can you confirm this happens still, or if it's fixed?
I just tried it and the Avast alerts no longer appear. I didn't whitelist/exclude anything on my end. Things may have cleared up with the false positive report.

I'll re check by removing from whitelist...

@RaSan147 thanks for checking! It should be resolved. Avast responded and verified on their end too it should be good now

The reported URL was checked by Avast virus specialists and based on the findings the detection was removed. The website is now marked as clean in the Avast virus database. This change may take up to 1 hour to take full effect. Please accept my apology for the inconvenience caused.

If the detection persists after 1 hour, please update the Avast virus database

Fixed, closing issue


[v0.19.x] Ensure the correct version is reported by the build process

Backport of #104
Closes #105

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
ℹ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12383160772. Examine the logs at this URL for more detail.

Thank you!!!!

Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!


set up categories with random  / pregen images

-image API that will pull random pics from categories like "puppies", "cats" etc

we decided to not implement categories as part of our MVP


Load sitemap.xml

If a website has a registered sitemap, it should be used to load all pages and start monitoring performance using lighthouse.
This ticket is about loading sitemap, creating database, and having a strategy to keep it up to date.

Look at https://pypi.org/project/ultimate-sitemap-parser/ :)


scichart background color change to default if multiple charts are plotted

Hello
This is a follow up from my previous questions.
Using the same repository I shared with you, please try to add a few more chanrts - so that dashboard display multiple charts of same kind, for example, multiple line charts.
The line charts are configured with background white, but once I added multiple line charts the first line chart's background became black
Please advise, thanks.

To fix the problem, please add sciChartSurface.background = "white"; for each chart, src/components/Line/Line.tsx component does not have it now

Thanks, I probably missed it, but I do remember some times it's black and
after reload it became white, I will let you know if I see it again.
On Wed, Nov 4, 2020, 6:21 AM Michael Klishevich<EMAIL_ADDRESS>wrote:

To fix the problem, please add sciChartSurface.background = "white"; for
each chart, src/components/Line/Line.tsx component does not have it now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ABTSoftware/SciChart.JS.Examples/issues/12#issuecomment-721674143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2HZBSKKFVJVMZFDMYSXU3SOE2KNANCNFSM4TJHO7IQ
.

Hi
Here is a screenshot of my safari version and the app I have - the charts
do not plot..
thanks.
Sally
On Wed, Nov 4, 2020 at 11:06 AM sally an<EMAIL_ADDRESS>wrote:

Thanks, I probably missed it, but I do remember some times it's black and
after reload it became white, I will let you know if I see it again.
On Wed, Nov 4, 2020, 6:21 AM Michael Klishevich<EMAIL_ADDRESS>wrote:

To fix the problem, please add sciChartSurface.background = "white"; for
each chart, src/components/Line/Line.tsx component does not have it now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ABTSoftware/SciChart.JS.Examples/issues/12#issuecomment-721674143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2HZBSKKFVJVMZFDMYSXU3SOE2KNANCNFSM4TJHO7IQ
.

--
╭(╯o╰)╮♫♫♫♫♫

Hi @puremood2002 , I do not see the screenshot. And please the information into this issue "scichart.js chart not working with safari (13.0.4)" https://github.com/ABTSoftware/SciChart.JS.Examples/issues/13
As far as I understand the background problem is resolved, therefore I am closing the ticket

Hi
I just attached the screenshot to #13, it is still an issue, thanks.
On Fri, Nov 6, 2020 at 4:23 AM Michael Klishevich<EMAIL_ADDRESS>wrote:

Hi @puremood2002 https://github.com/puremood2002 , I do not see the
screenshot. And please the information into this issue "scichart.js chart
not working with safari (13.0.4)" #13
https://github.com/ABTSoftware/SciChart.JS.Examples/issues/13
As far as I understand the background problem is resolved, therefore I am
closing the ticket
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ABTSoftware/SciChart.JS.Examples/issues/12#issuecomment-722973200,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2HZBRDG23ZO2MC4UTQPVTSOO57JANCNFSM4TJHO7IQ
.

--
╭(╯o╰)╮♫♫♫♫♫


[optimize]: Reduce virtual-site-data.mjs runtime module size

What problem does this feature solve?
In huge scale doc site project, the virtual-site-data.mjs will be 100, 000+ lines, which may be 3M+.
This results in the startup time of the entry, thus even we enable lazy compilation, it still need 1s to load the entry.
We can do something to split this file.

The virtual-site-data seems unnecessary, as its purpose is only to achieve automated navigation bars. We should consider how to optimize the logic.
In addition, it scanned and parsed all MD files once, which increased the build time to some extent.


Allow client-side rate-limiting to be disabled

In https://github.com/cert-manager/website/pull/1458 I attempted to disable client-side rate-limiting of API requests,
by setting kubernetesAPIQPS: -1 in the controller config.
It should be possible,  but -1 was rejected by the config validation function.
config:
  apiVersion: controller.config.cert-manager.io/v1alpha1
  kind: ControllerConfiguration
  kubernetesAPIQPS: -1
  kubernetesAPIBurst: -1

kubectl logs -n cert-manager cert-manager-f4948ff9-6sfm2

E0409 13:34:03.843673       1 main.go:39] "error executing command" err="error validating flags: [invalid value for kube-api-burst: -1 must be higher than 0, invalid value for kube-api-qps: -1 must be higher than 0]" logger="cert-manager"

FluxCD have implemented a mechanism to detect whether API Fairness and Queuing is enabled by the API server,
and disable the client-side rate-limiting in that case:

https://github.com/fluxcd/pkg/issues/269
https://github.com/kubernetes/kubernetes/blob/6813625b7cd706db5bc7388921be03071e1a492d/staging/src/k8s.io/client-go/rest/config.go#L351-L364

Kubernetes client-go are also considering ways to disable the client-side rate limiter when server-side rate limiting is enabled:

https://github.com/kubernetes/kubernetes/issues/111880

/kind feature

xref:

https://github.com/cert-manager/istio-csr/issues/144
https://github.com/cert-manager/istio-csr/issues/217


Cannot read property 'sendToHost' of undefined

I see this error in the console every time the page loads.

ooh, I think I know how to fix this one!
My console reports ipc module is deprecated. Use require("electron").ipcRenderer instead
So that probably needs to be updated for you.
I'll try to submit a fix, but I'm having trouble building the project.

With the latest patches, the ipc stuffed is removed(will be added the node integeration soon for a richer functionality). There should not be any more issues around this. Feel free to reopen if it exist with latest patch.


ESLint warning about a race condition when assigning an awaited result to body

Hey guys... recent ESLint update warns me about the following (screenshot): any hint about how to solve this?
Because I'm lacking ideas and I'm not sure whether this is valid or not: I may reassign ctx.body later, but given value at that moment is the value I awaited for. Right?
Infos: https://eslint.org/docs/rules/require-atomic-updates

The rule (require-atomic-updates) is pretty weird in Koa context because it assumes multiple promises can resolve and assign to ctx.body. In practice, Koa (actually koa-compose) only runs one mw (promise) at a time so this rule is ... weird. I'd turn it off, or at least disable it for ctx.body assignments.


clean up power_2_above

tweak
clean up power_2_above

Pull Request Test Coverage Report for Build 1581
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 88.633%

Totals

Change from base Build 1580:
0.004%

Covered Lines:
2347

Relevant Lines:
2648

💛  - Coveralls


Document how to import everything if desired

import models now only brings in those functions defined in the init for models. If we want to expose everything, we have to do import models._distributions as dist, for example, then look inside dist. Document how to do this somewhere.

Done in ef05964


Create method to update account balance for custom accounts

Created a method that can be used to update the balance of custom accounts.
Account name in Personal Capital and new balance are accepted as parameters.
This can be used to write programs that scrape data from sources not supported by Personal Capital, and update the balance in Personal Capital.

Password argument change integrated in patch version 2.0.1.

@JamaicanMoose Thanks for the feedback, I have made your requested changes.
Inspecting the updatebalance call in the network tab shows that the PC website makes the call by including the entire account object. I did try with only the accountid, but it does not update the balance.

@CarterMcAlister i did some inspection myself and confirmed that the website does use many of the parameters from the account object when updating some manual account types. I also noted that updating OTHER_ASSETS requires very few (however your code works when updating it presumably because the server ignores it). If you remove ownershipType: null (which as far as I can tell would override any existing ownershipType in the account object and make a note in the readme and function comment noting the asset type the payload was designed for (and that the code might work for other account types) I'm all good with approving it.

@JamaicanMoose I have removed ownership types and added clarifying comments as to what asset types are supported by updateBalance. I have also added methods to support the Manual Investment Holdings asset.


Rhythm and lead guitar model separation request

Is there a model to separate rhythm and lead guitar, if not how to train a model, I can't find any guid on the internet. Thank you

Also wondering this, need it for a guitar solo separation with the backing guitar


GH-40085: [C++][FS][Azure] Validate containers in AzureFileSystem::Impl::MovePaths()

Rationale for this change
Cross container moves aren't supported yet (and might never be).
What changes are included in this PR?

More careful checks related to trailing slashes
Check that containers are the same before calling a Rename that assumes src and dest are on the same container

Are these changes tested?
Yes, new tests were added.

Closes: #40085

@Tom-Newton


[Feature Request]: Add the Explore more page, which includes all the features categorized and arranged.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Explore features page

Contain all the features in an organized manner
easy to locate a feature
theme stays intact

Use Case
Will help the users navigate through the features easily

Descriptions of the features
benefits of the features
link to the feature

Benefits
Saves confusion and time .
Gives purpose to the explore now button
Better UI
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Can you please try to complete it by EOD 9PM

Okay ill do it!!

Sent a request in linkedin connect ..we will discuss there


Linux install code_1.16.1-xxx.deb is not working

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:19:37.192Z)
OS Version: Linux x64 4.10.0-33-generic
Extensions:

Extension
Author (truncated)
Version

vscode-docker
Pet
0.0.16

code-settings-sync
Sha
2.8.3

vscode-twig-pack
baj
1.0.0

phpserver
bra
2.0.0

gitignore
cod
0.5.0

githistory
don
0.2.3

gitlens
eam
5.0.0

vscode-great-icons
emm
2.1.16

php-debug
fel
1.11.1

file-icons
fil
1.0.5

sublime-babel-vscode
jos
0.2.8

materialize-snippets
len
1.1.2

vscode-apache
mrm
1.1.1

sublime-keybindings
ms-
2.9.1

php-docblocker
nei
1.2.0

LiveServer
rit
2.1.1

bootstrap4-vscode
the
2.4.0

bootstrap-3-snippets
wcw
0.1.0

(1 theme extensions excluded)

Steps to Reproduce:

Download the package from https://code.visualstudio.com/docs/?dv=linux64_deb
Try to install it via terminal
it will give you a message "bash: syntax error near unexpected token `('"

Sorry in advance about this post I just don't know where to report this. It is not code related problem but please do check.

After downloading the deb archive I could install with sudo apt install ./code_1.16.1-1505406497_amd64.deb without problems.

Publishing was delayed, should all be fine now.

Thanks


Install prestissimo by default

Should this package install https://github.com/hirak/prestissimo by default? This is a widely used composer plugin to speed up your installs by a magnitude.
If there is interest, I'm willing to add a PR later today.

In my testing prestissimo on windows did not help much.
Also this will be integrated in composer 2.0 (composer/composer#5293)
Till 2.0 composer release we can integrate this on macOS and ubuntu here
Please submit a PR on the develop branch.

@georgeboot Can you give me an ETA on your PR, or I will add this in the next release.

@georgeboot Thanks for your contribution.


[documentation] Consider using Algolia for a better UX ?

Hey guys, first of all, I love Middleman, like everyone else here, at Algolia.
As I tweeted you, I took the liberty to clone your documentation, to see how Algolia's DocSearch could improve the search experience. And honestly, I quite like it.
I often hear people saying that your search engine is not as optimal as it should be, and I think you could make it way better, using Algolia :)
Give it a try, and feel free to ping me back if you liked it!
https://demo.algolia.com/middleman/
DEMO :

— A fan of yours.

That is awesome. Only using the current solution because it was the easiest at the time. Would happily accept a PR for this.
Glad you're enjoying Middleman!

Hey @tdreyno !
Wonderful, I think I'll ping you really soon :)

So! Finally :) We're done with it!
Expect a PR in the day!
Cheers


CellReference is null

Description
I have excel files that I'm trying to map but CellReference is null for each cell but, if I Open the file with Microsoft Office and save, after that if I try to map again CellReference is not null for each cell. I think is a bug in the library.
Information

.NET Target: netstandard2.0
DocumentFormat.OpenXml Version: 2.9.0

Expected
CellReference not null for all the case

Thanks @rmboggs  for taking a look. @AlejandroFerrandiz since we haven't heard from you in a while, I'm going to close the issue. If you still feel that this is an SDK issue, feel free to reopen to continue the discussion.

I m also facing same issue? Any solution or help?

Same issue

Same

I have also same :/

I solved my case, when I expor excel from the system, if I want to import it I got this ıssue, but If I create excel by writing down, there wasnt a problem, so I realize it, exporting method was not assignin cellreferences, excel should do it basically but didnt, so I just added a cellreference create method
 private string CreateCellReference(int column)
        {
            string result = string.Empty;
            //First is A
            //After Z, is AA
            //After ZZ, is AAA
            char firstRef = 'A';
            uint firstIndex = (uint)firstRef;
            int mod = 0;

            while (column > 0)
            {
                mod = (column - 1) % 26;
                result += (char)(firstIndex + mod);
                column = (column - mod) / 26;
            }

            return result;
        }

private Cell CreateCell(string colValue, int ColIndex, int rowIndex)
        {
            Cell cell = new Cell();
            cell.DataType = CellValues.String;
            cell.CellValue = new CellValue(colValue);
            cell.CellReference =CreateCellReference(ColIndex + 1) + rowIndex;
            return cell;
        }

a basic example for using
for (var i = 0; i< productsTable.Columns.Count; i++)
                {
                    var column = productsTable.Columns[i];
                    columns.Add(column.ColumnName);
                    Cell cell = CreateCell(column.ColumnName, i,1);
                    headerRow.AppendChild(cell);
                }

Created this solution from this
https://github.com/OfficeDev/Open-XML-SDK/issues/1003#issuecomment-895405954

Hello, I'm getting what seems to be the same issue. When downloading an excel file and trying to access the cells using OpenXML, the CellReference for all the cells is set to none until I open and save the file manually.
Just wondering if there is a way to get around this as I don't have much control over how the file is created and don't think I can really apply caglarsarikaya's solution.

I m also facing same issue? Any solution or help?

Hey all - in the future, instead of piling on a closed issue, please open a new one so we can continue the conversation. when doing so, it brings it to our attention and can be linked to the previous one to show that there may be more here. I'll reopen this one for now to see if there's anything we can do