An option to not automatically format the data as lowerCamelCase

Is your feature request related to a problem? Please describe.
Right now we are formatting the data as lowerCamelCase automatically, but we want to let the data as it is.
Describe the solution you'd like
Add an option to not automatically format the data as lowerCamelCase. This option will not effect the errors or data field, only with the data inside the data field.

This should not be the case. We have a test to validate that:
QueryMiddlewareTests.cs -> HttpPost_Casing

Or do you mean that we automatically make the schema types case compliant?
public class Foo
{
   string Bar { get; set; }
}

becomes:
type Foo {
   bar: String
}

I will look into how we can do that. Maybe I will split this one and first allow this on a type basis and then introduce a global default.

this one is possible since 10.0


Gem automatically assumes it's being used for Govuk projects

I've been trying to use this template in http://www.services.buckscc.gov.uk/
However, we don't intend to send any analytics to gov uk. The template assumes that we are, in this section:
<% unless content_for?(:exclude_analytics) %>

We didn't spot this until we actually tried to deploy to a production environment. It was a bit of an unpleasant surprise.
We've had to create a tag that simulates an :exclude_analytics component in order to avoid sending unwanted data to gov uk. Otherwise our site crashes because there is no GOVUK_APP_DOMAIN environment variable defined (used here)
<%= content_for :exclude_analytics do %>
     <%= true %>
<%= end %>

Unfortunately we have several sections where this has had to be included, because we use the theme in different parts of the site (authentication, admin area).
Wouldn't it be more efficient to remove this check:
<% unless content_for?(:exclude_analytics) %>

And replace that entire block with a default analytics block?
Or even simpler, could we disable the analytics section from the config file?
# config/initializers/govuk_admin_template.rb
GovukAdminTemplate.configure do |c|
  ...
  c.analytics = false
end

The exclude_analytics flag was created before the config was added. I think a config flag makes sense. PRs welcome.
For context, the analytics are included by default to prevent GOV.UK admin apps from being created without any analytics, this used to be a problem when new apps were spun up. Some further debate about this can be found on the PR that initially added the exclude_analytics flag:
https://github.com/alphagov/govuk_admin_template/pull/80
https://github.com/alphagov/govuk_admin_template/pull/63#issuecomment-85449236

The change that introduced the analytics (https://github.com/alphagov/govuk_admin_template/pull/59) had the intention: "This will prevent new apps from forgetting to include analytics." For this reason it'd be preferable if the template includes analytics by default and a flag can be set to disable it, perhaps disable_google_analytics. This would also ensure backwards compatibility.

I'd be interested to learn what you're using the gem for and how it’s worked out.

We're using it for an admin section for  http://www.services.buckscc.gov.uk/.
I'll look into adding a PR.

It doesn't look like people outside the govuk organization can open pull requests. Can I get access to push my changes up?


urls' update in setup_test.sh and adding sra-tools to environment.yml

Hi Ilya,
Recently we have been using the distiller-sm pipeline in the Fudenberg lab and we found the following problematic steps / have the following suggestions:

We got 404: Not Found error while running the setup_test.sh file

wget --no-check-certificate http://hgdownload-test.cse.ucsc.edu/goldenPath/sacCer3/bigZips/sacCer3.chrom.sizes
wget --no-check-certificate http://hgdownload-test.cse.ucsc.edu/goldenPath/sacCer3/bigZips/chromFa.tar.gz

We think it should be changed to:
wget --no-check-certificate http://hgdownload.soe.ucsc.edu/goldenPath/sacCer3/bigZips/sacCer3.chrom.size
wget --no-check-certificate http://hgdownload.soe.ucsc.edu/goldenPath/sacCer3/bigZips/chromFa.tar.gz

We also noticed that the environment setup file does not include SRA-toolkit.
It might be good to install it within the conda environment by adding:

dependencies:
  - sra-tools

to the environment.yml file.

Sorry I missed this somehow!
Thank you for the fixes Paulina, good catch for the links! Thy used to work, something must have changed on the UCSC side...
Why do you think the sra-tools are needed in the main environment? I think it is only used inside a rule, and that rule has its own environment with sra-tools in it.

Sure!
Regarding the environment, when I was running setup_test.sh before installing sra-tools, the fastq-dump command couldn't have been found. Installing sra-tools fixed this issue.


Live tab breaks when you click away from it

Reproduce as follows.
Inspect:
GtClassCoderHeaderElementExamples new coderHeaderElementForClass
It should open on the "Live" tab. Click away to the "Raw" tab and back again. The view is broken.

Hi @onierstrasz,
please, can you elaborate what does not work? Maybe I do not see what you refer to. Here, I share how it works for me (two days old developer image):

My bad. It is broken in the Morphic window. The Live view just disappears.

OK. It works perfectly in the GT inspector. I guess we do not care about the Morphic window.


add CVE-2015-0860 to security errata

Flagged by Nessus
dpkg
ensure >= 1.17.5ubuntu5.5

ii  dpkg                                1.17.5ubuntu5.5                       amd64        Debian package management system
showing proper ver in vagrant allinone


Some Rails logger changes to start alerting

Replace Airbrake.notify with LogUtil.log_err_and_notify just to get things in the Rails log as well. Most of the time we won't ACTUALLY get an Airbrake notif for repeat events since it seems to auto-"mute".

LongRunningSampleEvent block will just write that into the log when a sample has been running for over the threshold.

So the plan is to set up a simple alert in Datadog to email or Slack the on call person when it sees SampleFailedEvent or LongRunningSampleEvent in the log, for example.

need to fix the schema


how can I avoid having the background style when I'm not using a module?

with the cava module for example when waybar starts i have the background style that appears without the module being loaded.
then when i launch for example ncspot or firefox the module loads and no problem.
is there a way to remove the background style when waybar starts?
cava-module :
...
"cava": {
    "cava_config": "$XDG_CONFIG_HOME/cava/config",
    "bars": 14,
    "method": "pulse",
    "source": "auto",
    "bar_delimiter": 0,
    "noise_reduction": 0.75,
    "format-icons" : ["▁", "▂", "▃", "▄", "▅", "▆", "▇", "█"]
  },
...

style.css :
...
#cava {
  padding: 0 10px;
  background-color: #4c566a;
  color:#d8dee9 ;
  box-shadow: inset 0 -1px #d8dee9;
}
...

I am having the same issue with the same module. Is there anything that can be done with this? There are several other modules that still apply the styling even though it is not loaded

If I understood correctly, the hide_on_silence modifier will fix it.
Like this :
"cava": {
    "framerate": 60,
    "autosens": 1,
    "bars": 12,
    "method": "pipewire",
    "source": "auto",
    "bar_delimiter": 0,
    "input_delay": 2,
    "sleep_timer": 2,
    "hide_on_silence": true,
    "format-icons" : ["▁", "▂", "▃", "▄", "▅", "▆", "▇", "█" ],
    "on-click": "kitty cava"
},


Allow load and export from Azure Blob storage (WASB) using non-native path

Please describe the feature you'd like to see
Once we've introduced the Azure Blob Storage file location (WASB) #905 #1275 the next step is to make sure we can have load and export operations using the non-native path.
Describe the solution you'd like
Users should be able to load and export files using WASB using non-native path
Sub Tasks

[ ] https://github.com/astronomer/astro-sdk/issues/1486
[ ] https://github.com/astronomer/astro-sdk/issues/1485

Acceptance Criteria

[ ] All checks and tests in the CI should pass
[ ] Unit tests (90% code coverage or more, once available)
[ ] Integration tests (if the feature relates to a new database or external service)
[ ] Example DAG
[ ] Docstrings in reStructuredText for each of  methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
[ ] Exception handling in case of errors
[ ] Logging (are we exposing useful information to the user? e.g. source and destination)
[ ] Improve the documentation (README, Sphinx, and any other relevant)
[ ] How to use Guide for the feature (example)

Supporting @luanmorenomaciel and  @mateusoliveiraowshq to get this done :)


Add BucketedCounter class

https://jira.jivesoftware.com/browse/SEARCH-2740

Closing this pull request and opening a new pull request that merges to develop instead of master.


Revise and resubmit changes

I tried to make this a bit easier to review by containing each major section update in a single commit. So, if you wanted, you could review each separately.

125 files changed is a new record 😄


haskellPackages.monad-bayes: Jailbreak for GHC 9.*

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I tested by building haskell.packages.ghc923.monad-bayes and haskellPackages.monad-bayes.

@ofborg build haskell.packages.ghc924.monad-bayes haskell.packages.ghc942.monad-bayes haskell.packages.ghc902.monad-bayes

Ah, I cannot build these with borg it seems, because they are still marked broken?

On 9.4.2 it doesn't build anymore/yet because of dependency build failures (base-compat). On 9.0 and 9.2 it still builds.

On 9.4.2 it doesn't build anymore/yet because of dependency build failures (base-compat). On 9.0 and 9.2 it still builds.

Don't expect much on the 9.4 set, no time was spent on that so far. E.g. the base compat problem is probably already half-fixed by bumping its version. Right now 9.4 just uses the LTS-19 constraints.

LGTM, thanks!

In the future, feel free to run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh to actually mark the package unbroken.  It generally saves us a little bit of time.


Update contribution guideline

We need to update the language in https://github.com/thisdot/open-source/blob/main/CONTRIBUTING.md. See https://docs.google.com/document/d/1iJFkuf1jNOOqh79qsegiy-SgQDoV61PJ_3FQNXjObJI/edit for details.

@dustinsgoodman I cannot see any difference between the current contribution.md file and that google document. Are you sure you saved your version, or added the comments there?


Use SystemClock.elapsedRealtime() to fill mScheduledAt field

Related to #237
Use SystemClock.elapsedRealtime() to fill mScheduledAt field

Thanks for your help, but like you explained in #237, this won't be helpful and instead more confusing.


doc: add documentation for host exerciser sample

Signed-off-by: anandaravuri<EMAIL_ADDRESS>

Coverage remained the same at 76.167% when pulling dd444e4853ceadf8f931049f06dc59c9faf0caf6 on aravuri/helpbk_doc into 6f540f974fa1e4d088f332f71e404b7f29dc3f0e on master.

Coverage remained the same at 76.167% when pulling dd444e4853ceadf8f931049f06dc59c9faf0caf6 on aravuri/helpbk_doc into 6f540f974fa1e4d088f332f71e404b7f29dc3f0e on master.


4.3 can't open Vulkan Mobile project (Windows 10 with HD Graphics 5500)

Tested versions

Reproducible in: 4.3-stable

System information
Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Mobile) - Intel(R) HD Graphics 5500 (Intel Corporation; <IP_ADDRESS>63) - Intel(R) Core(TM) i5-5300 CPU @ 2.30GHz (4 Threads)
Issue description
the problem is that after updating to 4.3, opening a project will cause godot to stop responding in my vulkan(mobile) pc and if i check the cmd console there will be a lot of errors showing up infinitely
the bug has appeared in 4.3 and if i go back to 4.2.2 and use it with the proper .bat file for opengl, there wont be any problems.
Steps to reproduce
open godot 4.3-stable, open your project
Minimal reproduction project (MRP)
the project i opened was a new project, so there wasnt anything in it and the bug can be reproducible with an empty, new project

Please show the errors that you are getting

Intel(R) HD Graphics 5500 (Intel Corporation; <IP_ADDRESS>63)

This issue is very likely an Intel driver bug, but sadly they no longer support your hardware.
I would suggest trying to update your Intel graphics drivers to the latest version from Intel, which seems to be this <IP_ADDRESS>71 from 2021: https://www.intel.com/content/www/us/en/download/18369/intel-graphics-driver-for-windows-15-40.html
The number is lower than your <IP_ADDRESS>63, but Intel versioning is a mess, apparently that version is from 2018: https://drivers.softpedia.com/get/GRAPHICS-BOARD/INTEL/Intel-HD-Graphics-Driver-20-19-15-4963.shtml
Aside from this, you can also test previous dev/beta/RC snapshots from https://godotengine.org/download/archive/ to pinpoint where the regression happened, so we can see if it could be worked around. But it's very likely part of some major Vulkan renderer changes which caused it to run into this Intel driver bug, which we can't fix ourselves.

thanks guys
the problem was actually the graphics card as you all mentioned!


Add multi-domain/forest support for DSAccount

Resolves #100.

This is great, thanks! I have merged your ADSI and Test-PasswordQuality code into my own commit, but I have implemented changes in DsAccount in a slightly different way. Please review commit 4bd98076879cdb91c77383a8d37630ad031e708e.


Python testing UI does not allow you run all the tests in the file

See below. There is no play button on the class to run all the tests.

I'm expecting something similar to this (look at line 8):

But the testing explorer does allow you run a group of tests at once, so not sure why its missing in the ui.

@shanewazabbas You should see a button on the explorer for file:

And class:

It is a bug that we don't show the play on the class itself. But the play is available from the explorer.

Hello! We have just finished our testing rewrite and are beginning the rollout to users. I have tested this issue with the re-write and I am no longer reproducing the bug! If you would like to try it yourself, you need to add this setting to your users settings.json "python.experiments.optInto": ["pythonTestAdapter"]. Let me know if it doesn’t work for you and we can re-open this issue. Thanks!


Updated docs for Joyent Triton

Joyent's Triton offers Docker service on bare metal with no need to configure Docker hosts. Each docker run provisions the container on an available compute node in the selected data center. Some background on this can be found in https://www.joyent.com/developers/videos/bryan-cantrill-virtualizing-the-docker-remote-api-with-triton and https://www.joyent.com/developers/videos/docker-and-the-future-of-containers-in-production. There's a screencast of how this works to deploy a clustered database in https://www.joyent.com/blog/couchbase-in-docker-containers.
The Triton Elastic Container Service for Docker replaces our previous Docker service based on KVM hosts.
I was waiting to update these docs based on https://github.com/docker/machine/pull/1197, but I'm not clear on when that will proceed, so I moving ahead now with what we have.
Signed-off-by: Casey Bisson<EMAIL_ADDRESS>

+1 Having the docs for running on Triton right in the documentation will make it a lot easier for myself when I forget how to set it up on a new machine.

LGTM?

ping @moxiegirl @thaJeztah

@misterbisson I'm kind of thinking we should point to Joyent's documentation for installing Docker. I can from this blog https://www.joyent.com/blog/container-service-preview that they are more detailed than on this page.   Also "Docker CLI tools" isn't really our product but Joyent's and it is confusing to see this here.
This is what we did for AWS:
http://docs.docker.com/installation/amazon/
WDYT?

I agree with @moxiegirl here; We should guide the users to Joyent's documentation. Joyent will need those docs anyway, so better link there than to copy, at the risk things get out of sync.

Thanks @moxiegirl and @thaJeztah for the review. I'll take a look at the AWS documentation, but I should clarify that "Docker CLI tools" is a Docker thing, not Jeyent's. These include docker, docker-compose, docker-swarm and hopefully docker-machine soon too. Unlike AWS, Joyent exposes a Docker API endpoint, so using it is a matter of pointing the Docker apps on your laptop to that endpoint (one endpoint per data center).
Joyent's docs for installing and configuring this are here: https://docs.joyent.com/public-cloud/api-access/docker

@misterbisson Hmm, I must have misread the Joyent doc.  If a user installs Docker Engine they user will get the Docker command line interface (CLI).   I don't typically use Docker CLI tools because it seems redundant.... @thaJeztah has a near encyclopedic knowledge of Docker ... Seb do you recall this in use?

Hm, if I understand correctly here, "Docker CLI (tools)" is not really a product, but more a short way of describing the docker binaries on the command line. So, yes, any user working with docker on the command line is using the "Docker CLI tools", but I don't think we refer to them like this, but just as "using docker (-compose/-machine/-swarm) on the command line"

@misterbisson have you had the time yet to look at this? (Just a friendly reminder)

@thaJeztah I got sidetracked, but I'm hoping to update the PR to change the language this weekend. Thank you.

No worries, I was just browsing through open PRs to check up on their status. Just ping us when you're done :+1:

ping @misterbisson ? :smile:

Do we mind carrying this?

@cpuguy83 I'll carry.

Thanks @moxiegirl!


PowerShell Integrated Console unusable with no internet

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T18:36:31.751Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.2.11

tslint
eg2
0.16.0

PowerShell
ms-
1.4.1

debugger-for-chrome
msj
3.1.6

Steps to Reproduce:

Disconnect computer from internet
Launch VSCode with a project that uses PowerShell Integrated Console.

Expected:

To be able to use the Integrated Console without internet.

The picture below shows the console that is unusable.

Please report against the powershell extension https://github.com/PowerShell/vscode-powershell

Right!  Sorry for the time spent.  I noticed today I inadvertently posted this issue here.  Thanks and no problem, here is the issue in vscode-powershell.


New command: m365 spo file sharinglink clear

Usage
m365 spo file sharinglink clear
Description
Removes all sharing links of a file
Options

Option
Description

-w, --webUrl <webUrl>
The URL of the site where the file is located

-u, --fileUrl [fileUrl]
The server-relative (decoded) URL of the file. Specify either fileUrl or fileId but not both

-i, --fileId [fileId]
The UniqueId (GUID) of the file. Specify either fileUrl or fileId but not both

--scope [scope]
The scope of the sharing link

--confirm
Don't prompt for confirmation

Examples
Removes all sharing links from a file without prompting for confirmation
m365 spo file sharinglink clear --webUrl https://contoso.sharepoint.com/sites/demo --fileId daebb04b-a773-4baa-b1d1-3625418e3234 --confirm

Removes all sharing links from a file by url with prompting for confirmation
m365 spo file sharinglink clear --webUrl https://contoso.sharepoint.com/sites/demo --fileUrl /sites/demo/shared%20documents/document.docx

Additional Info
In this case, it will be useful to reuse the command m365 spo file sharinglink list to get a list of all the sharing links and remove these.

looks ok to me 👍
@MathijsVerbeeck  you rock 🤩

Few remarks:

Description:
Removes all sharing links to of a file

Options:
|Option|Description|
|------|-----------|
|-u, --fileUrl [fileUrl]|The server-relative URL of the file to retrieve. Specify either fileUrl or fileId but not both|
|-i, --fileId [fileId]|The UniqueId (GUID) of the file to retrieve. Specify either fileUrl or fileId but not both|
|--confirm | When specified do not Don't prompt for confirmation|

Description of your 2nd example is not quite right 😊

Other than that, looks good! 👍

Few remarks:

Description:
Removes all sharing links ~to~ of a file
Options:

Option	Description
-u, --fileUrl [fileUrl]	The server-relative URL of the file ~to retrieve~. Specify either fileUrl or fileId but not both
-i, --fileId [fileId]	The UniqueId (GUID) of the file ~to retrieve~. Specify either fileUrl or fileId but not both
--confirm	~When specified do not~ Don't prompt for confirmation
3. Description of your 2nd example is not quite right 😊
Other than that, looks good! 👍

Changed your suggestions. Seems like copy pasting can be hard sometimes... 😄

Looks good to go! Do you want to work on this @MathijsVerbeeck or do you want to open it up?

Feel free to open this up, however, it might be useful to clarify the last question from Waldek in #3996

Let's indeed use the spo file sharinglink list command to retrieve all links. However I suggest that we don't use spo file sharinglink remove because this will give us a lot of overhead since that command fetches the file in every execution.

I'm willing to work on this!

Awesome!

@MathijsVerbeeck, maybe a last minute suggestion. We could add a --scope option here as well like we do in the list command. Does that make sense?

Sure, if we would like to remove only let's say anonymous sharing links, it definitely makes sense.

Looking at the specs @MathijsVerbeeck, @milanholemans, it's not clear to me what the scope option does and what kind of value it expects. Should we make that more clear in the docs?
Also: we could add a -s short.

Agree but in the PR, scope is defined as Scope of the sharing link. Possible options are: anonymous, usersororganization. If not specified, all links will be removed. is this clear enough?

That's certainly clear @milanholemans, @MathijsVerbeeck, could you add a -s short for scope?


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-no_rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-no_rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-no_rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-no_rbac-no_auth

prow/e2e-suite-rbac-auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-no_rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-no_rbac-no_auth

prow/e2e-suite-rbac-auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-no_rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-no_rbac-no_auth

prow/e2e-suite-rbac-auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-no_rbac-auth.sh
1e934ea3d3d4580f6a5056c44fbb6563555ca96a
link
/test e2e-suite-no_rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[9.x] Opt-in Model::preventAccessingMissingAttributes() option

Sometimes, an appropriate optimization is to only select the database columns that you need for a specific feature/view. Unfortunately, this comes with the trade-off of having to then keep your select() statement in sync with the attributes you're accessing elsewhere in your app. This can lead to bugs that are harder to catch, because they fail silently.
For example, imagine you have a high-traffic index view for a model, and the model consists of many columns of potentially large data. To speed up that page, you choose to select only the 3-4 columns that you need for that view. Later, you add a flagged field to that model, and update the view to call @if($model->flagged) ..., but forget to update the select() statement in your controller. Your "flagged" logic will happily treat null as falsy, and your app will continue showing flagged items on that view because of the select() oversight.
This PR offers an opt-in solution: Model::preventAccessingMissingAttributes().  When set to true, Eloquent will throw a MissingAttributeException when trying to retrieve an attribute that does not exist (after checking accessors/casts/relations/etc). It will only throw this exception if both the attribute is missing and the model exists in the database. This lets you safely use things like the null coalescing assignment operator on new models while guarding against accidentally treating "null because this wasn't retrieved" the same as "null because this value is null in the database".
For example, this would trigger an exception:
Model::preventAccessingMissingAttributes();

$user = User::select('name', 'email')->first();

$user->status ??= 'new';

// Triggers MissingAttributeException: "The attribute [status] either does not exist or was not retrieved."

But, this will still work:
Model::preventAccessingMissingAttributes();

$user = new User();

maybeInferUserStatusSomehow($user);

$user->status ??= 'new';

It's also worth noting that if you want an attribute to always be null by default, you can always set that on a model-by-model case:
class User {
  protected $attributes = [
    'status' => null,
  ];
}

Personally, I never use select() on Eloquent models because of this concern. Having an option to guard against missing attributes would definitely make me more comfortable with making select() optimizations from time-to-time.
Credit for this goes to @aarondfrancis — he started working on something similar on his Twitch stream and then brought on a lively conversation about it on Twitter. This is a slightly different approach to the problem, but is very heavily inspired by that conversation.

Does this do anything to address any of the problems that were associated with this prior PR?
https://github.com/laravel/framework/pull/29089

This does address the issue with un-persisted models. I'm running our production tests right now with the flag turned on, and so far the only issues that I've run into are:

One third-party package that relied on the "null by default" behavior. My thought here is that if you want to use that package, you either PR a fix or don't enable this feature until they account for it.
Several actual bugs in our code base (places that were doing @if($model->[attribute that has been renamed]) and blissfully continuing, assuming that that attribute was false).

I've confirmed that the relation code example in that PR does in fact work here:
$model = new Model();
$model->relation()->associate($relation); // This works fine

I can dig into MorphTo and HasManyThrough a little more, since that I was brought up in that PR, but I'm fairly certain they work fine.

I just also confirmed that both of these cases work fine (both mentioned in the original PR):
Comment::with('commentable')->get();
Country::has('posts')->get();

The only other gotcha I've run into is a piece of code that was checking if a count had been loaded via withCount() and if not, loading it lazily. Something like:
if (! isset($user->friends_count)) {
  $user->loadCount('friends');
}

Had to be refactored to:
if (null === $user->getAttributeValue('friends_count'))) {
  $user->loadCount('friends');
}

It might be nice to add a new helper method for "is this attribute in the $attributes array?" but I was trying to keep the scope of this PR as small as possible…

It might be nice to add a new helper method for "is this attribute in the $attributes array?" but I was trying to keep the scope of this PR as small as possible…

@inxilpro should an exception be thrown at all when checking for property existence with isset? I'd expect isset() to quietly return false just like it would when checking a non-existent property on a "normal" object. An easy way to achieve this would be to try-catch the new exception within the __isset() function, but I don't know if that is desirable

should an exception be thrown at all when checking for property existence with isset?

This is something I went back and forth on. Here's the scenario that's not ideal:
// Some call that only selects specific data
$team = $user->teams()->select('id', 'slug')->first();

// Elsewhere…
$team->name ??= "{$user->name} Team";

Now I've accidentally overwritten the team's name because I didn't realize that the name hasn't been retrieved from the database. If the __isset() operation handles this missing attribute in a try/catch, this bug still exists. My preference is that preventAccessingMissingAttributes would result in this triggering an exception. If the value is null, then isset() will return false. But if the attribute wasn't retrieved for an existing model, isset() will throw an exception. In the end, that feels true to the spirit of the feature.

Now I've accidentally overwritten the team's name because I didn't realize that the name hasn't been retrieved from the database.

Maybe I'm misunderstanding here, but to me it seems like the wrong operator was used if the goal was not to assign a property. If the intention is to use this feature to spot the fact that you (accidentally) assigned a property that wasn't selected, then you forgot to cover basic assignments (e.g. $team->name = 'Laravel team').
Right now this would work:
$team = Team::query()->select('id')->firstOrFail();
$team->name = 'Laravel team';

But this would throw:
$team = Team::query()->select('id')->firstOrFail();

if (! isset($team->name)) {
    $team->name = 'Laravel team';
}

To me this doesn't make much sense, because these snippets essentially do the same thing except one of them guards against overwrites. I think this feature should only focus on trying to access a value that was not selected, and should excude isset and set.

I'm using my version of this (a bit different implementation because I also disable some other features of the model) for a long time and despite some additional code I have to add sometimes like hasAttribute() check, I'm way more satisfied with this than just pure fail silently, can't describe how many times I've got an error where I forgot to pick a relation key and it doesn't hydrate the relations or pure errors where the field is missing bus is checked by some methods. I can safely say that I'm not going back to the silent fail way ever again.
My only change from my experience would be to include the model type in the error message like:
The attribute [{$key}] either does not exist or was not retrieved for \Models\User model.`

because in loops or mixed lists of multiple models it's difficult to pinpoint which model is exactly failing

@axlon Personally, I think the following is a good balance:
// Works fine with un-persisted models
$user = new User();
isset($user->email); // returns false

// Throws exception when the column is not selected, because I can't know if it's
// not set because it's NULL in the database, or because I didn't fetch the data
$user = User::select('id', 'name')->get();
isset($user->email); // throws a MissingAttributeException

// Works fine when the column is selected
$user = User::select('id', 'name', 'email')->get();
isset($user->email); // returns true if email attribute is not null

@donnysim that's a great point. I'll update the exception.

@inxilpro that's exactly the behavior I would expect. Calling isset on an attribute I didn't select should definitely throw, IMO, because Laravel doesn't know if I left it out of the selection on purpose or not! (And of course, this is all opt-in, so we have a little more leeway.)

Added shouldBeStrict method to easily enable all of this "strict" behavior added recently. 😎

Model::shouldBeStrict() should be added to skeleton

@taylorotwell Trying to access relationship, which is defined with wrong foreign key should also throw error? Now it returns null: https://github.com/laravel/framework/issues/36353


Cursor often renders incorrectly

This is using neovim v0.4.3 and the current HEAD of neovide.   This is also running with zero configuration.
Often the cursor will become invisible or render incorrectly.  For example:
When on the 'o' character it appears:

But when moved to m character it goes black:

This effect where part of the cursor appears black often occurs when moving around as well

Another example of it being half-visible:

It also inexplicably changes color sometimes:

What platform? This looks like a skia bug in vulkan

This is on macOs Catalina 10.15.3

How did you install the vulkan drivers?

I followed the instructions in the readme and executed brew cask install apenngrace/vulkan/vulkan-sdk

Hrmm. Then I'm not sure I have anything for you. This is an upstream issue with skia that has something to do with your platform. I am slowly working on an in house renderer so that we can get rid of the skia dependency but thats not going to happen for a while.

Ok no problem.  Was there a recent skia upgraded that might have caused this?  This was rendering perfectly fine fairly recently.

ok interesting. Maybe it was the anti aliasing change? Gimme a bit and I'll toggle it off
Sent with GitHawk

I added a setting g:neovide_cursor_antialiasing which controls the antialiasing features of the cursor. Can you try setting that variable to v:false and see if that effects the issue?

Ok so yeah this completely fixes this issue 👍
Thanks

Awesome


Refactor sycalls.lua

Earlier we take this library for our idea. And we refactored a syscalls file for the logical view.
Out can check it out
I suggest make it same.
Split a syscalls.lua file to  files.

Yes, I agree we should split syscalls.lua into separate files!

Fixed in https://github.com/multitheftauto/amx/pull/62


Develop a Vite plugin for getStoreApi

Is your feature request related to a problem? Please describe.
Running the tinybase command line each time may get a bit tedious.
Describe the solution you'd like
Watch the schema files automatically with a Vite plugin.

This is possible, but generally I am hoping people move to using the schema-based typing (https://tinybase.org/guides/schemas-and-persistence/schema-based-typing/) rather than the code generation approach (in the long run).
Leaving the issue open though.

I see! Perhaps it would be nice to add to the documentation the pro/cons of each approach


ofAsyncMsg is blocking UI

Why we are using Async.StartImmediate? In my project it is blocking the UI. I think we should use Async.Start instead.
https://github.com/fsprojects/Fabulous/blob/e6407ce0058152f123d9faba1f559906b9af7d95/src/Fabulous.Core/ElmishCmd.fs#L47

Async.StartImmediate seems to be the recommended way when dealing with UI.
It runs by default on the current thread (UI thread) and only switches to another thread when needed, coming back to the first one when done.
Also it's more or less the default behavior of async/await of C#.
I also think it helps performance by preventing unnecessary thread switching.
Like the timer example, no need to start a new thread to ask another thread to wait for 200ms before going back to the UI thread.
Thread switching is really costly, especially on mobile.
If you need to do a long running operation, take a look at the docs:
https://fsprojects.github.io/Fabulous/update.html#threading-and-long-running-operations

Note that nearly all of Fabulous's program update loop could in theory be run of the UI thread in a dedicated background thread, only switching to the UI to actually update the view elements.
The problem is, some user operations like calls to various Xamarin.Essentials operations need the UI thread, and the user would have to code for that.  So at the moment they know that both view and update and called on the UI thread.
@TimLariviere I do wonder what the right thing is here - perhaps I made the wrong call - keep it in mind? Thread switching is costly, but blocking the UI thread is more costly still?

Thanks for reply. If the ofAsyncMsg is designed to be like this, it is ok for me, because I can just extend the Cmd module very easily by myself.

Thread switching is costly, but blocking the UI thread is more costly still?

@dsyme From what I saw in general for Xamarin, in async block, people tend to only do asynchronous I/O via the .NET Framework (web request, file access, etc. -- which don't block the calling thread) and almost never do any computation that could impact the UI responsiveness.
If they do, they quickly learn to start a new thread (Task.Run) and this seems commonly accepted.
So all in all, I think it's ok to let the user choose when to actually switch to the thread pool.
Most of the time, it won't be needed and this prevents unwanted performance issues.

I agree with @TimLariviere. Most Xamarin Apps run on the UI thread and execute non-blocking async calls. I would question if the work performed on the background thread would be justified in general. Plus having to sync to the UI thread for certain operations, e.g. Xamarin.Essentials would be a headscratcher for newcomers.

OK, well, good to have this checked.
Keep it in mind should people start hitting scenarios where the cost of view reevaluation and diffing becomes a cause of significant UI thread blocks. It might be easy and safe to add an option to do those specific operations off the UI thread. (That might mean skipping UI updates should model updates be triggered faster than the view updates are processed, eg by a flood of async events)


how to jump into another page of same website in app?

if i add button with link of another page of my same website, like if from my home page tab,  i added button to this link-https://julienrenaux.fr/contact/ it takes me to webview, but i want to open this contact page into the app, how to do that?

Have you tried to play with those options? https://github.com/shprink/wordpress-hybrid-client/blob/develop/config/config.default.cson#L49-L50
docs https://github.com/apache/cordova-plugin-inappbrowser#cordovainappbrowseropen

yes i have, but its not that i want to jump to apps about page by clicking button which is created in home page..

You want that the content of you post/page/customPost link to pages within the app? Deep linking? This is not implemented

yes deep linking. is it possible or not?
but in local host when i use http://localhost:8080/#/public/pages/430 this types of link it allow to jump into my content.. so i thought maybe in app also its possible.

possible maybe but not easy. Not on the scope of v2.

okay if there is any way please let me know the, thanks @shprink

Closing in favor of https://github.com/shprink/wordpress-hybrid-client/issues/148


Tidy up susecon work

Codecov Report

Merging #148 into v2-master will increase coverage by 0.57%.
The diff coverage is 58.27%.

@@              Coverage Diff              @@
##           v2-master     #148      +/-   ##
=============================================
+ Coverage      52.19%   52.76%   +0.57%
=============================================
  Files            762      844      +82
  Lines          20403    22018    +1615
  Branches        3530     3712     +182
=============================================
+ Hits           10649    11618     +969
- Misses          9754    10400     +646


[DPG Design] Consider whether we want to make RequestContext required in protocol methods when generating convenience methods

For DPG v1.0 GA, where we would add convenience methods manually, the guidance was what is documented here: https://github.com/Azure/azure-sdk-for-net/blob/main/doc/DataPlaneCodeGeneration/DeveloperDrivenEvolution.md#create-the-convenience-method-with-new-signature
This has us adding the Value suffix to a convenience method if it introduces an ambiguous call site with the protocol method.  If we are adding protocol methods to a GA'ed convenience client and the convenience APIs cannot be changed, we would make RequestContext required instead of suffixing the protocol method.
We should consider now that we can generate convenience APIs alongside protocol methods, that we can make RequestContext required in all cases to disambiguate methods rather than adding a suffix to the convenience API.
This raises questions about how we could detect whether a protocol method with an optional RequestContext has GA'ed or not and can be changed.  Given the implications for versioning, this issue is out of scope for the DPG v1.1 August MVP.

duplicate with https://github.com/Azure/autorest.csharp/issues/2887

close this one as duplicate 0f #2887


Using TextAffinity to determine caret placement

Closes #549.
Old behavior:
https://user-images.githubusercontent.com/1316184/171486869-2059dea1-5852-42ad-96cb-d82a1814bd75.mov
New behavior:
https://user-images.githubusercontent.com/1316184/171486892-88b1478c-d8a3-4b81-8e09-bf09ee22ac90.mov
I have a handful of tests failing locally but they also fail on main without any changes, so are presumably unrelated. Hopefully the CI run sorts it out.

@matthew-carroll: just want to ping you on this PR since it's been sitting around for a while and #549 is still open. It should be up to date with main and with the tests added in #623 have been updated to match the new behavior.

Thanks @jmatth
@angelosilvestre can you take a look at these changes to give me a 2nd pair of eyes on the code? Can you think of anything that's missing?
@miguelcmedeiros would you mind giving this PR branch a try in Superlist and see if anything weird happens with caret placement, or expanded selections?

@miguelcmedeiros would you mind giving this PR branch a try in Superlist and see if anything weird happens with caret placement, or expanded selections?

@matthew-carroll, tested it out with Superlist and didn't find any regression with regards to caret placement or expanded selections.

Added tests for upstream/downstream caret positioning at line breaks, plus an extra test to ensure affinity doesn't change the rendering if the caret isn't at a line break.

So taking a step back for a minute, I don't think the caret rendering tests belong in this PR. To fix the bug I changed how an Offset is translated to a NodePosition, such as when clicking or tapping on the document. Caret rendering is the other way around: given a DocumentPosition, figure out where to position the caret. I haven't touched that codepath.
It looks like the behavior I actually changed is tested in super_editor_robot_test.dart. I can add new tests to make sure for a given input (tap at the end of a wrapped line) we get the expected output (document selection has the correct offset and affinity). That will cover the changes introduced in this PR and prevent regressions to the old behavior.

@jmatth I think that we should add affinity to both code paths at the same time. I don't think it makes sense to support the concept of affinity logically but not graphically, or in input but not output. Can you try to make the change across the board?

I don't think it makes sense to support the concept of affinity logically but not graphically...

It's already supported graphically. It's admittedly a bit difficult to do but it's possible to get a text position with an upstream affinity on the main branch right now and it displays just fine.
I took another pass at testing and there are now tests for how TextAffinity is handled in three areas outlined below:
Unit tests
The behavior that actually changed was on TextNode and TextNodeSelection, and those changes have been covered by unit tests since I opened this PR. Nothing really interesting here.
Gesture Input
We want to verify that for a tap at a given location, the document selection is updated correctly. This shouldn't depend on the caret rendering.
I've added two tests to supereditor_gestures_test.dart and updated one in supereditor_robot_test.dart to handle this. Which file each test goes in is kind of an academic exercise though, as there's a circular dependency between those two tests: the robot tests depend on the gesture system, and the gesture tests use the robot.
Caret rendering
We want to verify that the caret renders at the correct location given different text affinities. This shouldn't depend on the gesture system. This seems to belong in caret_test.dart, but the existing tests in there all use taps to change the selection. I wrote the new affinity tests to manipulate the selection directly through the DocumentComposer instead. This should also help alleviate the "the caret is displayed where the editor displays it" cyclical logic. There's still a bit of that in there since SuperEditorInspector.calculateOffsetForCaret depends on DocumentLayout to find where it thinks the caret should be, but I think it's fine. If that situation needs to be improved then there should just be more tests on those DocumentLayout methods so we can rely on them.

@matthew-carroll ready for another look. The current state is

findOffsetOfLineBreak no longer relies on the widget tester, so all the tests are still using this method rather than hard-coding the offset of the line break. Let me know if we should still go with hard-coding for some reason, but the affinity tests will fail if findOffsetOfLineBreak develops a bug and returns an offset not at a line break so I think this is fine
I updated findCaretOffsetInDocument on the inspector to support finding Android and iOS carets. It just checks for desktop, Android, and iOS carets in sequence and returns the offset for the first one it finds
The affinity tests in caret_test.dart test for the upstream/downstream caret offsets relative to the offset of the caret when placed at the start of the paragraph


cmd/cli: Add mesh list command

Please describe the motivation for this PR and provide enough
information so that others can review it.
Please mark with X for applicable areas.

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [x]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests / CI System      [x]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Resolves #1598

LGTM once conflicts are resolved.


Passing react context variables via a Custom renderer

Hey all,
I found in the issues that people are passing components over to react-markdown via the renderers parameter but I would like to simply pass over some variables to be rendered in markdown. What is the easiest way to do this?
Example
My component
...React stuff
const ReactMarkdown = require('react-markdown/with-html');
import {markdownFile} from "markdown.md"

const myComponent = () => {
    const [{myContextInfo}, dispatch] = useContext(Context);

    return (
    <ReactMarkdown
         source={markdownFile}
         escapeHtml={false}
         renderers={{
              // id like to pass over an object of data here or something simple
              someElement : {
                  propOneFromComponent : myContextInfo.propOne,
                  propTwoFromComponent : myContextInfo.propTwo
              }
         }}
     />
    )
}

Markdown File
| | | |
|-|-|-|
| Info: |  propOneFromComponent |
| Info2: | propTwoFromComponent |

Note:
I noticed that also when trying to implement the "code blocks method" that the component seems to re-render constantly (pink areas flashing/highlighted areas in the development tools, where the information renders to)

The code block method I am using is this:
const renderers = {
      code: ({ language }) => {
        if (language === 'infoOne') {
          return "infoOne: " + myContextInfo.propOne
        }
        if (language === 'infoTwo') {
          return "UI Version: " + myContextInfo.propTwo
        }
        const className = language && `language-${language}`
        const code = React.createElement('code', className ? { className: className } : null)
        return React.createElement('pre', {}, code)
      }
    }


After installing Chinese CorelDRAW 2020, I can't see the tools.

After installing Chinese CorelDRAW 2020, I can't see the tools.
Is there a C language version? Assembly language is a mystery and I can't understand it.
C:\Program Files\Corel\CorelDRAW Graphics Suite 2020\Programs64\Addons\SmartDepart

To show plugin icon you need to reset property panel to it defaults. Icon only shows when "combine (Ctrl+L)" icon shows. So plugin don`t works with text (need convert text to curves before use).

I have mixed Delphi7/FASM 32-bit debug code compilable as exe. Polygon-intersection routine and curve to polyline converter in FASM, rest of code in Delphi.

Thank you for your reply. I tried it in CorelDRAW 2020 but it still didn't work. I guess the reason is:
CorelDRAW 2020 and X7 UI libraries have changed, and the API has changed.
Because I learned C/C++ to build CPG yesterday, CorelDRAW X6 64bit worked fine, but the command button built in CorelDRAW 2020 was wrong and could not be used.
VGCore::CommandBarControlPtr ctl ...;
The CommandBarControlPtr class has changed in CDR2020

You are not one, who tells me about it difference in corel versions. Recently I have wrote a little tool, and it also don`t work in 2020 - https://www.cyberforum.ru/coreldraw/thread3169753.html. But it work fine in X7, 2018, 2024.
I see you use SetCustomIcon - this method don`t work since 17 version of corel. In newer versions you must use SetIcon2 instead - this method accept only ico files.

Also in my recearch i found interesting feature of old versions CorelDraw - it possible to include icon as base64 code immideately in xslt. But this feature no longer supported.

Here another example in delphi - https://forum.rudtp.ru/attachments/cpg-example-7z.164729/. This 32-bit cpg should work in x3 and higher. It installs in "Draw\Plugins" dirrectory (if dirrecory not exists - just create it).

https://github.com/hongwenjun/CorelDRAW-CPG/tree/main/03_ClearFill
03_ClearFill in my CPG learning project was compiled with the SDK of CorelDRAW 2020. It runs correctly under CorelDRAW X6, but fails under CorelDRAW 2020. There is a difference between the high and low versions, which is a real headache.
STDMETHODIMP CVGAppPlugin::raw_StartSession()
{
  try
  {
    m_pApp->AddPluginCommand(_bstr_t("ClearFill"), _bstr_t("Clear Fill"), _bstr_t("Clears fill from selected objects"));

    // CorelDRAW X6 使用 VGCore::CommandBarControlPtr ctl
    // CorelDRAW 2020 使用  VGCore::ICUIControlPtr ctl，能通过编译，不过运行目前有错误
    VGCore::ICUIControlPtr ctl = m_pApp->CommandBars->Item[_bstr_t("CorelVBA")]->Controls->AddCustomButton(VGCore::cdrCmdCategoryPlugins, _bstr_t("ClearFill"), 0, VARIANT_TRUE);
//    _bstr_t bstrPath(m_pApp->Path + _bstr_t("Plugins64\\ClearFill.bmp"));
    ctl->SetIcon2(_bstr_t("guid://d2fdc0d9-09f8-4948-944c-4297395c05b7"));
    m_lCookie = m_pApp->AdviseEvents(this);
  }
  catch(_com_error &e)
  {
    MessageBox(NULL, e.Description(), _T("Error"), MB_ICONSTOP);
  }
  return S_OK;
}

Locate the error of CorelDRAW 2020 CPG creating button icons,
Comment out the code for creating button icons, and then test using the same function code in VBA,
Create a button for CPG plug-in to use, and it can call "clear fill color" normally
Sub Macro1()
    With CommandBars.Item("Test")
      .Visible = True
      Set ctl = .Controls.AddCustomButton(cdrCmdCategoryPlugins, "ClearFill")
      ctl.SetIcon2 ("guid://a8e62a7a-d5d2-4a05-8d5d-e07d6bd21993")
    End With
End Sub

Code  from ToastyСut
cominvk Controls,AddCustomButton,cdrCmdCategoryMacros,strMacroName,1,0,Control
As you see "index" is 1 (in your code its 0) and "temporary" is false (in your code its true). As I remember that parameters may result to crash Corel with some "incorrect" values. I picked that values in many tryes.

Thank you, Master. The button icon added in CorelDRAW 2020 can be used normally. I hope your tool can also be repaired and used normally.

I have checked work in Corel 2020 both x86 and x64 versions - it`s all right.

I have checked work in Corel 2020 both x86 and x64 versions - it`s all right.

IVGApplicationPtr app(L"CorelDRAW.Application.22"); // The version I installed before could not bind to Windows COM, probably because of this.
I installed a new version today, which can bind to Windows COM normally, so I can use your plug-in.
Annoying things: Today, CDR2020 cannot use VBA GMS plug-in under Windows Chinese system:

Last night I wrote some interesting code for curve intersection:
https://git.lyvba.com/hongwenjun/cdrapp/src/master/cdrapp.cpp
bool isDPCurve(IVGShapePtr s) {
  auto dpc = (s->Type == cdrRectangleShape) || (s->Type == cdrEllipseShape) ||
             (s->Type == cdrCurveShape) || (s->Type == cdrPolygonShape) ||
             (s->Type == cdrBitmapShape);
  return dpc;
}
IVGShapePtr CreateBoundary(corel *cdr, IVGShapePtr s) {
  //  auto scp = s2->CreateBoundary(0, 0 , true, true);
  //  This is only supported by API X7 and above, so now just draw a rectangle
  BoundingBox box;
  s->GET_BOUNDING_BOX(box);
  auto scp =
      cdr->ActiveLayer->CreateRectangle2(box.x, box.y, box.w, box.h, ZERO_4PC);
  return scp;
}
// VGCore::IVGShapePtr VGCore::IVGShape::CreateBoundary ( double x, double y,
// VARIANT_BOOL PlaceOnTop, VARIANT_BOOL DeleteSource ); VGCore::IVGShapePtr
// VGCore::IVGShapeRange::CreateBoundary ( double x, double y, VARIANT_BOOL
// PlaceOnTop, VARIANT_BOOL DeleteSource ); VARIANT_BOOL
// VGCore::IVGCurve::IntersectsWith ( struct IVGCurve * Curve )
void test_IntersectsWith(corel *cdr) {

  auto sr = cdr->ActiveSelectionRange;
  if (1 < sr->Count) {
    bool isIn = false;

    auto s1 = sr->Shapes->Item[1];
    auto s2 = sr->Shapes->Item[2];

    if (isDPCurve(s1) && isDPCurve(s2)) {
      isIn = s1->GetDisplayCurve()->IntersectsWith(s2->GetDisplayCurve());
    } else if (isDPCurve(s1)) {
      // Group text and other types such as OLE to create a temporary boundary range
      auto scp = CreateBoundary(cdr, s2);
      isIn = s1->GetDisplayCurve()->IntersectsWith(scp->GetDisplayCurve());
      scp->Delete();

    } else if (isDPCurve(s2)) {
      auto scp = CreateBoundary(cdr, s1);
      isIn = scp->GetDisplayCurve()->IntersectsWith(s2->GetDisplayCurve());
      scp->Delete();
    } else {
      auto scp = CreateBoundary(cdr, s1);
      auto scp2 = CreateBoundary(cdr, s2);
      isIn = scp->GetDisplayCurve()->IntersectsWith(scp2->GetDisplayCurve());
      scp->Delete();
      scp2->Delete();
    }

    if (isIn)
      Test_Intersect(cdr);   // Another interesting code
  }
}


Changelog Euwe-3

consolidated based on lists from Satoe
[skip ci]

@Fryguy ready for you.

@miq-bot add_label documentation


Text holder master

Should add backgrounds to the text holders

Should merge with the main branch master

First check for compatibility


Plot viewer does not come up

Root cause, initial render for the plot viewer was not returning anything. React crashes when this happens.

Validated


Not recognizing Windows 10

According to https://stackoverflow.com/questions/32193855/c-check-if-windows-10, code such as https://github.com/bkaradzic/bgfx/blob/master/src/bgfx.cpp#L1571 does not reliability detect Windows 10. It detects the os as windows 8.
Also, goto statements..
So it is choosing weird renderers.

What about goto statements?
D3D11 is for now default for Win10 intentionally. D3D12 is still WIP.

Goto statements are considered bad practice because they can make code harder to read and follow, leading to spaghetti code. Personally I think there's a time and a place for them and the "no goto statements" rule is a bit too cut and dry. They're a great way to exit deeply nested loops.

Yeah I know about dogma, and don't agree with it. But what's bad about use of gotos in bgfx? First what's broken, unreadable, etc. what's alternative, etc. propose fix. ;)

I personally don't care haha, it's fine by me.
If I'm going to play devils advocate though, I would say that the way goto was used here: https://github.com/bkaradzic/bgfx/blob/master/src/bgfx.cpp#L1696 takes a few extra seconds of examination to figure out what you're doing. If it was replaced with a while (true) and break when renderCtx is not NULL it would accomplish the same thing and read easier. It's really just nitpicking though.

while (true) == C4127: conditional expression is constant... ;)

for(;;) - no warning :)
but I think there is no difference between goto and loop, it takes few seconds to figure out just because the label is too far

Bike shedding... :)
If you ignore goto/for(;;)/while (true) for a moment, and look what that code does, there is actually much more elegant way of doing it. Current implementation kind of evolved into that state, but if I was about to write whole function from scratch right now there is way better way of picking right renderer with less code.

I added command line options to select renderer. You can add --d3d12 when running on Win10 to select D3D12 renderer backed.


Support extending files_to_watch

Language modules should be able to extend files to watch. Not sure how this would fit into the current setup, but goal would be that they could register files that are important for direnv and direnvrc script to watch.
Examples would be yarn.lock, requirements.txt... Currently these are only updated when a new shell is opened and might leave the current env in a old/unexpected state. Current workaround is modifying one of the files it watches eg add whitespace to devenv.nix to make sure a refresh is triggered, but this is easy to forget and error prone.

Language modules should be able to extend files to watch

Cool idea! We could do something similar to how we handle imports.
https://github.com/cachix/devenv/blob/6ee4b6b00eb33c323a03310429b641aa90f541a4/direnvrc#L118-L122

Current workaround is modifying one of the files it watches

You can watch any file you like in .envrc with direnv's watch_file. Add this to your .envrc:
watch_file yarn.lock requirements.txt

use devenv

eg add whitespace to devenv.nix to make sure a refresh is triggered

N.B. touch devenv.nix is quick way to do the same.

@sandydoo yea had a similar idea like you did, just not sure how language modules would exposes files to watch, this would somehow require devenv to have already parsed nix files.

You can watch any file you like with direnv's watch_file. Add this to your .envrc:

True, and this will trigger a refresh, but this if statement won't trigger, so doesn't really do much
if [[ ! -e "$profile_rc" || "$need_update" == "1" ]];
then
  log_status "updated devenv shell cache"
else
  log_status "using cached devenv shell"
fi

N.B. touch devenv.nix is a quick way to do the same.

Thought of that as well, but main problem is that this doesn't get checked into git, hence doesn't work for teammembers (which is the main issue).

True, and this will trigger a refresh, but this if statement won't trigger, so doesn't really do much

Ah, I forgot we had caching! Maybe nix_direnv_watch_file?

yea had a similar idea like you did, just not sure how language modules would exposes files to watch, this would somehow require devenv to have already parsed nix files.

Bit of a chicken and egg problem. I think there's 3 things that need to happen:

Export the list of files to watch. This can either be an env var or a file in .devenv. enterShell is one place to do it. This list will be created after running devenv print-dev-env.
Watch files on initial shell creation. Fetch the list of files and watch_file them. This ensures we reload the shell when those files are touched after the first ever evaluation. Maybe this can be made conditional on whether this is the first ever run?
Watch files on subsequent shell reloads. Before running use devenv, we read the list of files and add them to files_to_watch.

Overlooked that nix_direnv_watch_file was available in envrc, using that before use devenv already works like a charm, thanks for that.

I was thinking of implementing it like this:

Export DEVENV_EXTRA_FILES_TO_WATCH as env variable in nix config (language modules can extend this)
And use like this (pseudo code)

nix_direnv_watch_file "${files_to_watch[@]}"

local layout_dir profile_rc
layout_dir=$(direnv_layout_dir)
profile_rc="${layout_dir}/devenv-profile$(_nix_argsum_suffix "${files_to_watch[@]}").rc"

if [[ -e "$profile_rc" ]];
  DEVENV_EXTRA_FILES_TO_WATCH=$(read_from $profile_rc)
  nix_direnv_watch_file $DEVENV_EXTRA_FILES_TO_WATCH
fi

local need_update=0
local file=
for file in "${nix_watches[@]}"; do
  if [[ "$file" -nt "$profile_rc" ]]; then
    need_update=1
    log_status "$file changed, reloading"
    break
  fi
done

if [[ ! -e "$profile_rc" || "$need_update" == "1" ]];
then
  # We need to update our cache
  local env
  if ! env=$("${DEVENV_BIN}" print-dev-env); then
    log_error "failed to build the devenv environment. devenv.nix may contain errors. see above."
    exit 0
  fi

  if [[ ! -e "$profile_rc" ]]; then
    DEVENV_EXTRA_FILES_TO_WATCH=$(read_from $env)
    nix_direnv_watch_file $DEVENV_EXTRA_FILES_TO_WATCH
  fi

  echo "$env" > "$profile_rc"
  log_status "updated devenv shell cache"
  _nix_import_env "$profile_rc"
else
  log_status "using cached devenv shell"
  _nix_import_env "$profile_rc"
fi

I'm willing to look into PR if you agree or have a better way

I put down some ideas: https://github.com/cachix/devenv/pull/1186. Seems to work!
The above should also work. I guess you want to grep out the variable from the script? Only thing to keep in mind is that we need to watch any news files added to the list. The second [[ ! -e "$profile_rc" ]] check would prevent that.

Yea I was wrong to assume that any change to files_to_watch would create a new checksum hence a new profile_rc, so would indeed miss some cases.

Wouldn't it be easier and more robust to use something like Reflex (https://github.com/cespare/reflex)? You could create Nix options to watch specific files, integrate them into a writeShellScriptBin, and execute it on startup.


behaviotree_cpp_v3: 3.5.0-2 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository behaviotree_cpp_v3 to 3.5.0-2:

upstream repository: https://github.com/BehaviorTree/BehaviorTree.CPP.git
release repository: https://github.com/BehaviorTree/behaviortree_cpp_v3-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.7
previous version for package: 3.4.0-1

behaviortree_cpp_v3
* added IfThenElse and  WhileDoElse
* issue #190 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/190>
* unit test added
* reverting to a better solution
* RemappedSubTree added
* Fix issue #188 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/188>
* added function const std::string& key (issue #183 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/183>)
* Contributors: Davide Faconti<EMAIL_ADDRESS>* added IfThenElse and  WhileDoElse
* issue #190 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/190>
* unit test added
* reverting to a better solution
* RemappedSubTree added
* Fix issue #188 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/188>
* added function const std::string& key (issue #183 <https://github.com/BehaviorTree/BehaviorTree.CPP/issues/183>)
* Contributors: Davide Faconti<EMAIL_ADDRESS>

Holding for sync.


Add types and allow empty app ID

This change makes sense and is simple enough, but you've got a couple of missing double quotes in your type JSON tags.

I'm not sure if I should be more scared that Go never raised an error or that none of my tests picked it up

@warent Some IDEs (I use GoLand) will call out/highlight malformed tags.

The go vet tool will warn about incorrect struct tags

What's the status on this PR? This conflicts with the current master but if it's still needed, I can merge.
(Also, please don't hesitate to ping me on Twitter [@thatmikeflynn] as my GitHub notifications are impossible to keep up with and for some reason this repo is always at the bottom of the list.)

@mikeflynn given what @rking788 mentioned how difficult would it be to add a CI check (with go vet) to PRs?

That would be great! Have either of you set that up with GitHub PRs before? Any way you can point me in the right direction?

so I'm not sure if there is a different way that I have never tried before. but the only way I can think of is to setup a travis.ci build for the repo (free for open source projects) and then run go test and go vet in the build script. A sample script can be found in the go-cmp project. Actually now that I am reading the # 86 pull request on that project it sounds like vet is running automatically with go 1.10. so it would just need to be the go test command.

I can try to setup something on my own fork of this project and then, once I get it working, I'll ping y'all.

@rking788 @mikeflynn PR for adding Travis CI (with instructions!): https://github.com/mikeflynn/go-alexa/pull/45

Looks like this can no be rebased and then merged?

So this got kind of lost in the shuffle. Still important? If someone can resolve the conflict we can merge.


PLRAM is broken

This breaks splag. We need to support PLRAM here.

Where will PLRAM be placed?

Check this 2dfce5c8ced0b3948197f753d48a902698bde30c


Responsive Ads

Is there an example of how to setup responsive ads with next-google-dfp?

In slots define your sizes
{         divId: "div-id",         slotId: "slot-id",         sizeMappings: [[970, 250], [970, 90], [728, 90]],     }
And for the ad component try the following.
<Ad id="banner-ad" width={'auto'} height={'auto'} />
It worked for me. Hope it helps you as well.

Hi @2xSamurai thank you for helping @zlever01. We're soon going to work on a better documentation site and different example projects.


Add custom writer for arguments structures

Closes #68.

Coverage decreased (-1.0%) to 98.744% when pulling 35fc32f3e589142baf892503272335a0f8518786 on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.

Coverage increased (+0.3%) to 100.0% when pulling 4c044e1489a85c2a3d679103528c64fc694474b2 on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.

Coverage increased (+0.3%) to 100.0% when pulling eee14658c234c514a68f8b036c1df04fb9c705f2 on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.

Coverage increased (+0.3%) to 100.0% when pulling ec3240ed5e4445cb712659477de7162371d49f27 on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.

Coverage increased (+0.3%) to 100.0% when pulling 759896afc765a1814d05d1686e8aa911c1390ea4 on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.

Coverage increased (+0.3%) to 100.0% when pulling 7c755c3a883448d976edbff8ebf7a2330a07173d on 68-args-print into 06d640dfebab0b0ddc86016d4d38a0c80d862d55 on master.


add @stack('content')

Question
Answer

Issue or Enhancement
Enhancement

License
MIT

What's in this PR?
jsut added single line @stack('content') to enable @push to 'content'
Checklist

[x] I've tested changes manually, since I didn't manage to figureout how jeroennoten/Laravel-AdminLTE/tests work, I'm getting errors like
Failed asserting that directory "test-folder-copy" does not exist.

I'd be happy if you helped me for running /tests
Thanks

@AMoktar Please, give me some time. Before merging I would like to check if it's convenient to add @stack() to other yielded sections too.

Ok, I did not find any other section where adding @stack() may be useful. In content it makes sense, so you can keep extending an already defined view to @push() additional content to it.