Determine the signed object type from the object itself, not its name.

Currently, we use the file ending to decide what kind of object we are dealing with. The more robust way would be to use the eContentType field of the signed object.

 But.. the extensions are defined in the RFCs. A ROA MUST use .roa, a certificate .cer etc. This was done specifically for implementations that have a hard time inspecting and then parsing/validating - signed objects are all similar, but CRLs and certificates are quite different. I think you can judge best how easy/hard this is to implement in routinator, and when to do it.

Should have checked the RFC first. I seemed to remember the ending was a SHOULD. In this case, everything is fine (we check the correct content type when decoding an object).


Next battle is not recognized (stage counter simularity at 50%)

Before opening an issue:
[O] I tested the latest release
[O] I looked at other issues (even the closed ones)
[O] I read the Troubleshooting Guide
[O] I'll fill this template properly
Your issue will get closed/locked by the bot in case proper info isn't provided
If you open unnecessary/dumb issues, you'll be rewarded with appropriate tags.
Describe the bug
It doesn't  recognize when 2nd battle starts when I use the "next battle>>" in the command maker (it uses normal command cards instead of set autoskill properties) but when I use "next turn" it recognizes the next battle and uses the set autoskill properties.
Stage counter simularity is set to 50% for better recognition but it doesn't work.
Screenshots
Video
Device Info (please fill at-least 'Device model'):
Device model: Samsung Galaxy S20+
Screen size: 6.7 inch
Android Version: Android 10
RAM: 12GB

I'm getting the same issue. You're encountering it only on the Finals - Garden node right? It must be the weird lighting in the background or something messing with the battle counter. I'm getting a similar issue where Battle 1, turn 2 triggers the battle 2 autoskills. If I'm able to one turn everything, there's no issues. But if Battle 1 takes more than one turn, then there's a chance the battle 2 stuff gets triggered and screws everything up.

I'm getting the same issue. You're encountering it only on the Finals - Garden node right? It must be the weird lighting in the background or something messing with the battle counter. I'm getting a similar issue where Battle 1, turn 2 triggers the battle 2 autoskills. If I'm able to one turn everything, there's no issues. But if Battle 1 takes more than one turn, then there's a chance the battle 2 stuff gets triggered and screws everything up.

Exactly what's happening to me. I tried changing battle counter similarity to no avail and tried installing older versions of FGA with no success either so I have to assume it has to do with the lighting on the stage. I turned on debug mode and saw it check the stage counter and even though it was 1 it'd activate my skills for 2 which then leads to wave 2 activating all my final wave skills.

Sadly it doesn't look like it's fixable.

Sadly it doesn't look like it's fixable.

Could you explain why? Maybe we can offer some ideas. I would think gathering more frames on the battle counter could improve the accuracy, even if the background is messing with it.

@salmonrumpnova What I'm seeing is that the lights take about 3 seconds to pan. You would have to compare 100s of images then.

@reconman What about using the fade-to-black transition battle screen as the trigger?

I was seeing this happen as well and was about to open another issue.  Would it be possible to have an optional setting for a battle to check for the intermediate screen between waves or something instead of relying solely on the turn counter in the upper right corner?  (Another possibility that might be more surefire is letting the user set up an image of the enemies in the waves to trigger knowledge of when you've transitioned.  That would likely be hard to handle as a quick fix though.)
Assuming those aren't possible, is it possible to work around this (or at least reduce the chance of it occurring) by increasing the threshhold for the stage counter image recognition?

I noticed the same thing on the Finals-Garden Stage.
The script which let the party facecard the first Wave to build gauge and then NP'd W2+W3 worked at the first few tries then suddenly not anymore. It seemed to randomly work again then jump to other parts of the battle actions.
The script suddenly choose the actions for Wave 2 on Wave 1 after the first turn and didn't wait for W2. I have been trying find out what i did wrong, but it seems people here also had this problem, so i also think the jumping pillar placement and the moving lights behind the Wave number counter mess this up.
Chances are good that if you don't NP nuke W1 + W2 and facecards can't finish it, it will load in the actions for the next Wave in the current one.

Also getting this issue on Finals Arena where FGA activates the script for wave 2 despite being on wave 1. The stage counter similarity is at 95%. It might be the background of the stage that is triggering this bug.

@HayanShiro is on KR server and from their other issue #461, their problem is not configuring the regions properly.
For the NA guys, the background animations varies a lot in Gilfest Finals nodes, so, you're better off either using 3T comps or just farming manually if you want to go for RNG comps.
I have a few workarounds in mind but none of them are simple enough to be get done before Gilfest ends.

My side of the issue is fixed by making FGA full-screen just like FGO. Should I keep this open or closed?

Since the NA folks have taken over this issue, I'll just leave this open.

I'm running 70% similarity with a comp that's a bit RNG and it's working well. Here's the video. I usually don't 3T stuff because I want to prioritize Mystic Code and Bond EXP.
Anyway, the point of this setting is to control how similar the saved stage counter screenshot should be when compared to the actual screen for the script to consider that the stage has changed. It's kinda counterintuitive, but the higher you set it, the less tolerant the script will be. By setting it to 95%, if the background of the quests changes only so slightly, the script will think the stage has changed, which is the opposite of what you want. Therefore, you should set it to a value lower enough for the script to disregard minor background changes but still high enough for the script to detect actual stage changes. There isn't a 100% effective bullet-proof value you can use for all quests, so a little experimentation to find one that works for you is to be expected.

@potchy I don't really know since I mostly 3T, but many people have told me that they tried values from 50-70 but didn't work well. Some people even said it's not failing consistently, which I think is possible since the background fluctuates heavily in this round.
I'm thinking of picking up the white pixels from the screenshot for Battle counter and only use them for matching. Not sure if that'll be any better, but I guess it's worth a try.

Anyway, the point of this setting is to control how similar the saved stage counter screenshot should be when compared to the actual screen for the script to consider that the stage has changed. It's kinda counterintuitive, but the higher you set it, the less tolerant the script will be. By setting it to 95%, you're expecting a near perfect match

I was wondering if I had reversed those, but hadn't gotten around to trying the opposite.  First try at 60% didn't recognize the transition into Wave 3, but the second at 70% looks to be running fairly well.
I'm only running into this on an account that I play around with which is pure support characters, so I don't really have any pure 3T comps since I have no characters with damaging NPs . :)  If I have a few failures on the runs, I'll live with that-- I think the comp I have should power through without dying when it happens, it's just going to take considerably longer.  And if I'm running it through Automata that shouldn't really matter much.
I'll take the quality of life improvement that Automata represents even with uncertainty over trying to run manually. :)

Hmm, using only white pixels for detection does seem to work well (at least on this node)
Have been tuning it since yesterday and I think it's in a good state at least for this Gilfest node.
I don't think I'll finalize this before Gilfest ends since I need to test this out on different nodes to see how effective this is.
Here's the build if anyone wants: https://github.com/MathewSachin/Fate-Grand-Automata/actions/runs/270940199
This can be installed side-by-side with the PlayStore version.
The Stage Counter Similarity fine-tune setting is not used in this build.

Ran into the same issue, tried with 95% and 99% similarity, but found it was using wave 2 and 3 skills on wave 1.
I'm currently running it with 75% similarity and it's working well for me.
Just ran my autoskill using the CI build and it worked well using the default settings.
Device model: Samsung S8

Just tested the new build and it didn't recognize the transition to Wave 2 for me.  I turned on debug mode and from what I can tell, it wasn't looking at the full round value-- (i.e. instead of highlighting the 2/3, it just highlighted the 3)--though it was very quick, so it's possible I misinterpreted.  I'm using Nox, so I don't think there's a full screen mode to activate, plus the Google Play version was recognizing waves.

I think i have the same problem, in the battle script my chacha should use her NP in the third wave but sometimes she uses it in the second wave and when this happen i usually lose the battle and this is happening in the Finals-Garden Stage too.

I made further improvements in picking just the white pixels from the stage counter snapshot by cropping out the black regions around the white pixels.
Currently using Agartha - Great Underground River (Jungle Voyage) for benchmarks (#408) since Gilfest is over now.
And, that change seems to be working fine and distinguishing waves with good enough similarity values too.
Latest build: https://github.com/MathewSachin/Fate-Grand-Automata/actions/runs/293738304
If anyone knows of a node with more background animation near the stage value, do let me know.

Okeanos - Isle of Wyverns and the pirate ship are where I ran into this problem other than Gilfest. It doesn't happen as much as Gilfest maybe like 1/15 times as opposed to Gilfeststs 1/5 when going on default settings. Best of luck, you've really made something great here.

NP Spam setting is not working on the second wave in the Oni Land food court. In the first battle of wave, there is a bug that clicks on space with NP, but after the second battle of the same wave does not click NP, but only selects cards.
I'm not sure, but I think it's because of a similar cause.

I think that i getting the same problem in this Christmas event, sometimes the servants don't use the NP in the last wave

Also sometimes they use the NP in the second wave instead of the third wave

Also sometimes they use the NP in the second wave instead of the third wave

I have the same problem in Christmas event

Wasn't sure if this is the proper issue to reply on, but I'm facing a similar issue running the Enma-tei event, except I suspect it's different than an issue with image recognition:
I have scripts setup to run through the different "Task" stages for the event.  They're not 3T setups.  Instead they prioritize Art cards for the first 2 battles then spam NP on the 3rd.  For battle 1 and  2, I select different targets for servants to pick off first.  As an example, I have a setup for Abby, Hokusai, and Nero Bride that looks like this:
g3,#,i3t1,#,abdefh3j456
Basically using a skill in battle 1, targeting an enemy and using a skill for battle 2, and using all skills + NPs in battle 3.  When I load the app for the first time, go into battle, and start the script, it will successfully go through the quest without missing a beat for at least 3 runs, where the script promptly stops when it hits the AP refresh screen.
However, if I refresh AP myself, repeat the quest, and tell the script to run again, it will always commit the 1st battle's setup in the 1st turn and the 2nd battle's setup in the 2nd turn, regardless of which wave it's in.
I had switched on Debug mode to see what was happening.  When the app is loaded up initially and the script runs, the output seems to be correct (green boxes on the correct battles, red boxes when the battle has changed).
I recorded a couple videos to show their behavior (they were too big to upload so I threw them unlisted on Youtube):
https://youtu.be/oCjv6-6wvYg
This video shows a full round that works properly; this was the first script run since the app had loaded.
https://youtu.be/aiZfrnAHf00
This video was taken after choosing to repeat the quest manually, then running the same script again.  It shows the incorrect behavior with skills being used in wrong battle turns.  I let it finish the quest and auto-repeat to show that it works correctly in the second quest.
I'm guessing the battle counter isn't resetting properly once script goes off?  I tried looking at the code myself but I'm not proficient in Kotlin.
I'm using Bluestacks with Oneplus 3T profile.  I had this behavior in both the regular release version and the newest canary version.

Wasn't sure if this is the proper issue to reply on, but I'm facing a similar issue running the Enma-tei event, except I suspect it's different than an issue with image recognition:
I have scripts setup to run through the different "Task" stages for the event.  They're not 3T setups.  Instead they prioritize Art cards for the first 2 battles then spam NP on the 3rd.  For battle 1 and  2, I select different targets for servants to pick off first.  As an example, I have a setup for Abby, Hokusai, and Nero Bride that looks like this:
g3,#,i3t1,#,abdefh3j456
Basically using a skill in battle 1, targeting an enemy and using a skill for battle 2, and using all skills + NPs in battle 3.  When I load the app for the first time, go into battle, and start the script, it will successfully go through the quest without missing a beat for at least 3 runs, where the script promptly stops when it hits the AP refresh screen.
However, if I refresh AP myself, repeat the quest, and tell the script to run again, it will always commit the 1st battle's setup in the 1st turn and the 2nd battle's setup in the 2nd turn, regardless of which wave it's in.
I had switched on Debug mode to see what was happening.  When the app is loaded up initially and the script runs, the output seems to be correct (green boxes on the correct battles, red boxes when the battle has changed).
I recorded a couple videos to show their behavior (they were too big to upload so I threw them unlisted on Youtube):
https://youtu.be/oCjv6-6wvYg
This video shows a full round that works properly; this was the first script run since the app had loaded.
https://youtu.be/aiZfrnAHf00
This video was taken after choosing to repeat the quest manually, then running the same script again.  It shows the incorrect behavior with skills being used in wrong battle turns.  I let it finish the quest and auto-repeat to show that it works correctly in the second quest.
I'm guessing the battle counter isn't resetting properly once script goes off?  I tried looking at the code myself but I'm not proficient in Kotlin.
I'm using Bluestacks with Oneplus 3T profile.  I had this behavior in both the regular release version and the newest canary version.

@TheErwin what similarity value are you using?
(More options -> Fine-tune -> Stage Counter Similarity (%)
I'm running 70% and it seems to be doing okay.

@TheErwin what similarity value are you using?
(More options -> Fine-tune -> Stage Counter Similarity (%)
I'm running 70% and it seems to be doing okay.

@potchy I tested it with 70% and it seems to be the same result.  I've worked around it by closing the app and relaunching it anytime I want to restart a script.  Thankfully I only have to do it if the script uses skills/NPs in between battles.

@potchy I tested it with 70% and it seems to be the same result.  I've worked around it by closing the app and relaunching it anytime I want to restart a script.  Thankfully I only have to do it if the script uses skills/NPs in between battles.


How to create a VM with an existing/stored SSH key pair?

I could only find examples of how to create a VM with new SSH key:
...,
"linux_configuration": {
    "ssh": {
        "public_keys": [
            {
                 "path": "",
                 "key_data": "",
             }
        ]
     }
},
...

However I'm yet to find an example of how to create a VM that uses an existing pair, the equivalent of this functionality in the UI:

Thanks for the question! Redirecting this to the right person

@BigCat20196 I'm using the Python SDK, otherwise I would not be opening this issue in this repo :)

@00Kai0 do we have samples for this scenario?

/unresolve

Hi @DeepSpace2,  it may use this keyword.
...
"secrets": [
        {
          "sourceVault": {
            "id": "string"
          },
          "vaultCertificates": [
            {
              "certificateUrl": "string",
              "certificateStore": "string"
            }
          ]
        }
      ],
...


ipython display only shows last

what beaker does:

what it should do

i thought i had filed this before and even had a branch with a partial fix, but i can't find them anymore.

1484


lisa.datautils: Add SignalDesc for clk_* events

FIX
Add SignalDesc for clk_set_rate, clk_enable, clk_disable so that
requesting the dataframe for one of these will always provide the
occurence before the beginning of the trace window for each clock name.

@Leo-Yan this might affect the plot (in a good way) as it will ensure that e.g. trace.df_event('clk_set_rate) will provide an "initial condition" event for each clock name when windowing the trace. With the df_refit_index used in the plot method, the timestamp of that initial event will be moved to match the trace window start so the plot should be as expected.
Otherwise, the plot would only start on the first occurrence of the event inside the window.

Thanks for the info, @douglas-raillard-arm.  Based  on your description, the change for "the initial event will be moved to match the trace window start" looks good to me.


Add Example Creating Excel Document using Node.js

Looks like exceljs is pretty good package to demo.

https://www.brcline.com/blog/how-to-write-an-excel-file-in-nodejs


Portable

Hey Seth
I've finalised the PCL library version of numl.  Basically I removed Console references and fixed Ject support.  One part I wasn't sure on was Exclusions in Descriptor (see method WithString in Descriptor).  Let me know if it needs further work or is it deprecated anyway?
There is now a platform wrapper for Ject so that the client provides a means to list assemblies and types rather than Ject trying to do it on it's own from within numl portable.
I've also added the regression models and various bug fixes from my last commit.
All tests passed without any issues.
Chris

I promise I'm not ignoring this! The wrapper is an excellent idea.

Hah, now I believe you 😊
I also have a heap more changes to come shortly.

I'm trying to get it to work on coreclr now - a lot of the stuff you did should work although I think I am going to remove the whole AppDomain stuff. If they don't fully qualify their types....


[New Core]: The FairyLand Story

GitHub Username
jotego
Repository Name
jtbin
Pre-release

[ ] The GitHib release which contains the openFPGA core is labeled as a pre-release.

Asset Filter
No response
Path
pocket/zips/jotego.jtflstory.zip

Sorry, JT hasn't pushed the files to JTBIN yet... I just assumed it would be there, it's been a few hours since the Patreon post went up.


Multiple function parameters default to the same name

This is a case where the blocks UI generates code that won't compile.

Okay, I was wrong.  Apparently the error is detected before actually calling the server to build.  But it would be nice if the second parameter were given a unique name by default.


Aeon ZTP reports model "Cumulus-VX" for Ubuntu VMs

Trying to use Aeon ZTP to provide the 'finally' script only (no os-selector.cfg), the GUI reports the wrong hw model. See screenshot.

resolved in Apstra/aeon-venos#18


[FEATURE] Provide permanent claim for external ID

Is your feature request related to a problem? Please describe.
Currently we do not have a consistent way of transmitting the external ID (eg. UIN). It is now clear that this will be needed in some situations where services need to integrate with other services outside of the ROKWIRE ecosystem.
Describe the solution you'd like
We should add an "external_id" claim to the token to be filled with these identifiers.
Describe alternatives you've considered
An alternative would be to open an API on the Core BB to allow other services to retrieve the external ID associated with a Core BB account ID, however this would produce significant additional overhead.

We would like to be able to support multiple external IDs for various systems. In order to do this, the claim should actually be a map called external_ids where named external IDs can be entered.


Installed Aurora. cant get the game to work for CSGO.

What are you experiencing an issue with?

[ ] Aurora
[x] Aurora supported game, (CS:GO)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
csgo profile should be working.
Actual behavior:
i installed the old verison of logitech cs:go interactions and i got it to work. but it was delayed with 1 minute. so i downloaded Aurora the same way. followed all instructions and when im in windows application aurora and click csgo. i get it to work when i test it. when i click patch Aurora GSI. i find the config files in cfg folder. i look on youtube for answeres and this guy says the patch button dont work.  https://www.youtube.com/watch?v=inphGpCn3Jk
i have installed it the same way as he did. and i have looked on former issues and went to %appdata% and deleted folder. and reinstalled. nothing happends. when i get ingame the keyboard go from "csgo" mode as it shows in desktop and it goes to the standard "wave" format. wtf am i doin wrong?
How often does this problem occur?

This problem occurs... (every time)
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

What is the version of Aurora you are experiencing this issue with?

My version is... (0.6.0b)
Please include any logs, screenshots, or files that are related to this issue:

my log: https://pastebin.com/7kguY2NZ

this is what it says inside the gamestate intregation file:
""Aurora"
{
"uri" "http://localhost:9088/"
"timeout" "5.0"
"buffer"  "0.1"
"throttle" "0.1"
"heartbeat" "0.5"
"data"
{
"provider"            "1"
"map"                 "1"
"round"               "1"
"player_id"           "1"
"player_state"        "1"
"player_weapons"      "1"
"player_match_stats"  "1"
}
}"
is this correct? it seems like the cfg wont work with game

Yes that GSI config appears to be correct. When you descibe how the keyboard is displayed in-game is it showing the desktop effects when you are ingame or is it showing the CS:GO effects and not updating? I couldn't quite understand what you were describing in your main post. You can try the latest development release to see if that changes anything.

This is what happends, https://www.youtube.com/watch?v=PyLoNDt_xkQ&feature=youtu.be

Looks like Aurora doesn't detect csgo running.
Try running Aurora as admin. Try changing the Application Detection Method (see Aurora settings).

Changed it from Windows Event to Foreground app scan. still dosnt work...

Did you try running it as admin? Can you post the log from the attempt you made in the video?

https://pastebin.com/AdXjuERH

i always run it as admin

Could you try this build to see if it makes a difference?

now it talks with the game. only thing that dont work now is the team colors on the keyboard but i can programm that my self. thx alot for the help.

What's the issue with the team colours?

never mind i just saw it was a setting that it dims after 10 secounds i removed it and all works perfectly

Closing as issue is resolved with latest commit to dev.


Ensure Date(time) fields are only converted to Nullable when they're not in the primary key

As I reported in this issue, the fact that all Datetime fields are converted to Nullable caused synchronization issues when these fields are part of the table's primary key.
With this PR, I propose that this conversion to Nullable is only done when the field is not part of the table's primary key.
Implementation details:

Change definition of to_sql_type method not to convert Datetime fields to Nullable by default.
Create new method to_sql_type_non_primary_key method that ensures Datatime fields are converted to Nullable.
Change definition of create_empty_table to call to_sql_type_non_primary_key when the field is not part of the primary key, calling to_sql_type otherwise.

While there, formatted the code of connectors.py with ruff formatter to reduce the number of warnings/violations returned by pre-commit. It seems that a lot of other files are also not formatted, but decided to keep the number of non-functional code changes to a minimum.

Hey @BTheunissen , as this is my first PR in this repo and I see you were the one introducing the nullification of datetime fields in this commit, would love your opinion and review here! Thank you


Convert HTML to PDF with Docraptor

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

This closes #5084

@mercymeave, how are you doing.  I have made the requested changes that were suggested by @lalith1403. You may have a look at it. It's a duplicate.

@lalith1403, all the requested changes committed. You may have a look at it. Thanks.

I had made a few changes in the earlier PR. please incorporate them as well.

Hello @lalith1403, I have incorporated them in this PR.

Hello @lalith1403, I have incorporated them in this PR.

Taking a look

Hello @lalith1403, I have incorporated them in this PR.

Taking a look

@mercymeave, Thanks

Hello @lalith1403, I have incorporated them in this PR.

Taking a look

@mercymeave, Thanks.

@mercymeave, I have incorporated the changes you had made.

When you create a new PR, learn to incorporate the changes in the previous PR. Seems like you created a new file that ignored the changes I had made in the previously closed PR.

great point @mercymeave
cc: @taves-hub lets be sure to go through the entire article to catch any issues that may have not been caught by our peer reviewer.
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

@hectorkambow, Hello sir, I double-checked my PR for grammatical errors and updated it. If you don't mind, I would like you to have a look at it. Thanks

Waiting for peer reviewers approval.

@mercymeave hello. I have incorporated all the changes. You can have a look and give guidance where necessary. Thank you.
cc
@lalith1403

@mercymeave Any updates?

@mercymeave Any updates?

finalizing

@lalith1403, hello sir. I was requesting if you can give this PR a final review since you had started it before closing the previous PR, which you were about to Merge. Thank you.

@lalith1403, hello sir. I was requesting if you can give this PR a final review since you had started the previous PR before closing it. Thank you.

Yes. I will review it by EOD

jumping on this one


fix crash on empty topic

Trivial fix; a return (or else branch) was missing, causing control flow to execute a failing code path.

Nice! I will review it this weekend and merge!
Thanks!

Thanks!


Enable Stage #2 Azure Security

Enable all the Security components like:

Sentinel
Defender for Endpoint

All the recommendations from Security team for Best Practices.

Reference: https://journeyofthegeek.com/2023/03/

https://atlas.mitre.org/

The Network Isolation configuration was added to the bicep in order to deploy zero trust architecture.


Documentation updates

Refine the README, including updated instructions for using the ucalgary built Docker images.

It looks like @kinghuang hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

Sorry, wrong repo.


[test] Keep track of the bundle size of TrapFocus

Closes #15450

Issue will be marked as wontfix?

@eps1lon Ok, I have removed the "close" description. We are at 1.52 kB gzipped (taking the shared modules into account). Let's see if an actual issue is reported, so far, the discussion seems to be about:

v3 is broken
v4 is good
I have built this nice package, interested in a win-win deal?


Error in word2vec: model from Google Cloud Storage was not downloaded

Hello, good day!
Thank you for your work. I'm trying to run automated patent landscape notebook, but I've got an error I could not figure out.
Trying to run block Download Embedding Model if Necessary from patent landscape notebook, I got the following error message:

InvalidResponse                           Traceback (most recent call last)
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\client.py in download_blob_to_file(self, blob_or_uri, file_obj, start, end, raw_download, if_generation_match, if_generation_not_match, if_metageneration_match, if_metageneration_not_match, timeout, checksum)
718         try:
--> 719             blob_or_uri._do_download(
720                 transport,
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\blob.py in _do_download(self, transport, file_obj, download_url, headers, start, end, raw_download, timeout, checksum)
960             )
--> 961             response = download.consume(transport, timeout=timeout)
962             self._extract_headers_from_download(response)
C:\Anaconda\envs\new-environment\lib\site-packages\google\resumable_media\requests\download.py in consume(self, transport, timeout)
167
--> 168         self._process_response(result)
169
C:\Anaconda\envs\new-environment\lib\site-packages\google\resumable_media_download.py in _process_response(self, response)
184         self._finished = True
--> 185         _helpers.require_status_code(
186             response, _ACCEPTABLE_STATUS_CODES, self._get_status_code
C:\Anaconda\envs\new-environment\lib\site-packages\google\resumable_media_helpers.py in require_status_code(response, status_codes, get_status_code, callback)
98         callback()
---> 99         raise common.InvalidResponse(
100             response,
InvalidResponse: ('Request failed with status code', 404, 'Expected one of', <HTTPStatus.OK: 200>, <HTTPStatus.PARTIAL_CONTENT: 206>)
During handling of the above exception, another exception occurred:
NotFound                                  Traceback (most recent call last)
 in
3 model_name = '5.9m'
4 model_download = W2VModelDownload(bq_project)
----> 5 model_download.download_w2v_model('patent_landscapes', model_name)
6 print('Done downloading model {}!'.format(model_name))
~\patents-public-data\models\landscaping\word2vec.py in download_w2v_model(self, landscape_bucket, model_name)
54         bucket = client.bucket('patent_landscapes')
55         blob = bucket.blob(checkpoint_list_file)
---> 56         checkpoints = blob.download_as_string(client=client).decode()
57         checkpoint_file = 'n/a'
58
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\blob.py in download_as_string(self, client, start, end, raw_download, if_generation_match, if_generation_not_match, if_metageneration_match, if_metageneration_not_match, timeout)
1385             stacklevel=1,
1386         )
-> 1387         return self.download_as_bytes(
1388             client=client,
1389             start=start,
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\blob.py in download_as_bytes(self, client, start, end, raw_download, if_generation_match, if_generation_not_match, if_metageneration_match, if_metageneration_not_match, timeout, checksum)
1294         client = self._require_client(client)
1295         string_buffer = BytesIO()
-> 1296         client.download_blob_to_file(
1297             self,
1298             string_buffer,
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\client.py in download_blob_to_file(self, blob_or_uri, file_obj, start, end, raw_download, if_generation_match, if_generation_not_match, if_metageneration_match, if_metageneration_not_match, timeout, checksum)
729             )
730         except resumable_media.InvalidResponse as exc:
--> 731             _raise_from_invalid_response(exc)
732
733     def list_blobs(
C:\Anaconda\envs\new-environment\lib\site-packages\google\cloud\storage\blob.py in _raise_from_invalid_response(error)
4059     )
4060
-> 4061     raise exceptions.from_http_status(response.status_code, message, response=response)
4062
4063
NotFound: 404 GET https://storage.googleapis.com/download/storage/v1/b/patent_landscapes/o/models%2F5.9m%2Fcheckpoints%2Fcheckpoint?alt=media: Not Found: ('Request failed with status code', 404, 'Expected one of', <HTTPStatus.OK: 200>, <HTTPStatus.PARTIAL_CONTENT: 206>)

They problem may be with the folder patent_landscapes in Google Cloud Storage. I couldn't access it manually. The message is:

Sorry, the server was not able to fulfil your request.

Thank you in advance!

Hi, same problem here ! Seems this folder doesn't exist anymore. Where can we find it ?

Hi, same problem here ! Seems this folder doesn't exist anymore. Where can we find it ?

Maybe someone has a local copy they can put up?


Implement more flags for 'restic forget'

Moving forward with this project, it might be worth considering to dynamically allow all possible parameters for restic instead of statically implement each and everyone. But that will be a lot of refactoring and breaking changes :)

I've added two more changes:

Implement dry-run for 'restic forget'
Sort forget parameters alphabetically

Hope it's fine to just "mix" it into this PR.

Hope it's fine to just "mix" it into this PR.

It's okay on this one, but try to keep the PRs narrowly scoped and avoid adding scope after a review starts. I've written up guidelines to get your PRs merged as quickly as possible here:
https://mtlynch.io/code-review-love/

baurmatt force-pushed the forget_keep branch from cb44cd8 to 45b874c now

Can you try to avoid force-pushing? It makes it hard to review your changes. I merge the PRs with squash and merge, so all the commits get squashed into a single one on merge.

It looks like these changes are breaking the build:
https://app.circleci.com/pipelines/github/mtlynch/resticpy/226/workflows/722eb347-ba7b-4bdf-8053-3fafb96506f8/jobs/494
You can run these tests locally with ./dev-scripts/build, and you can set them to run automatically on every commit with ./dev-scripts/hooks/enable-hooks.

Thanks! :) I sometimes just miss running tests before pushing 🙈 Automatically running them on commit doesn't work because I have global hooks defined in ~/.gitconfig:
[core]
  hooksPath = /Users/mbaur/.git-hooks

Howevery.... I've fixed all of those bugs the linting/testing complained about, just one is missing where I don't have a good idea for it:
restic/internal/forget.py:7:0: R0913: Too many arguments (11/10) (too-many-arguments)

I guess it's just what I've mentioned in the PR description.

I guess it's just what I've mentioned in the PR description.

I've just added #87 to fix that, although I'm open to a dynamic approach if you want to open an issue sharing a sketch of how that would work.


Support PEP 345 Project-URL metadata list

A Project-URL list is supported in v1.2 PKG-INFO metadata with
pkginfo 0.6 or later, and is used primarily by PyPI to display
helpful hyperlinks in a generic manner. Add support here to be able
to pass it through setup.py. See the corresponding section of the
Core Metadata Specifications from the Python Packaging User Guide
for details:
https://packaging.python.org/specifications/core-metadata/#project-url-multiple-use

After some reflection on the core metadata spec and PEP 345, I believe I've interpreted the multi-use option format incorrectly and will need to re-spin this.


Mobile version

Is it possible to develop a mobile version of this addon?

Yes, I am currently working on a version for Firefox Android.

Latest release adds support for mobile browsers. Firefox Beta and Nightly can add the add-on via custom collections.


Pango broken on darwin

Describe the bug
Pango now requires harfbuzz to build built with coretext, which is fine because we have harfbuzzFull. However, pango's include path for it is just #include <hb-coretext.h> when it should be #include <harfbuzz/hb-coretext.h>
I'm not sure how to tell meson to use a different include path :/
To Reproduce
on darwin: nix-build -A pango
Expected behavior
builds
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@marsam ..... nice, not sure why i didn't think of that :(


feat: add internal/testing-only opts._elasticApm to facilitate APM agent tests

Expected usage in APM agent tests is something like:
const apm = require('../..')  // note the import path is not "elastic-apm-node"
const log = pino(ecsFormat({ _elasticApm: apm }))
// ...

This allows the APM agent tests to use the local APM agent working copy to test APM tracing integration in the logger.
This is going to be used to test https://github.com/elastic/apm-agent-nodejs/pull/2127

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #84 opened

Start Time: 2021-06-28T20:03:36.330+0000

Duration: 11 min 31 sec

Commit: 738b26fc8aeeebd5fdee38151ff1f86c25bc5ed0

Trends :test_tube:

Steps errors
Expand to view the steps failures

Run tests

Took 1 min 38 sec . View more details on here
Description: .ci/run-test.sh

Run tests

Took 1 min 39 sec . View more details on here
Description: .ci/run-test.sh

Run tests

Took 1 min 39 sec . View more details on here
Description: .ci/run-test.sh

Run tests

Took 1 min 38 sec . View more details on here
Description: .ci/run-test.sh

Log output
Expand to view the last 100 lines of log output

[2021-06-28T20:14:03.226Z]             ok 3 - logged record matches expected record
[2021-06-28T20:14:03.226Z]             1..3
[2021-06-28T20:14:03.226Z]         ok 4 - ecsPinoFormat case: can log non-HTTP res & req fields # time=3.445ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]         # Subtest: ecsPinoFormat case: `base: {}` should avoid "process" and "host" fields
[2021-06-28T20:14:03.226Z]             ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]             ok 2 - should be equal
[2021-06-28T20:14:03.226Z]             ok 3 - logged record matches expected record
[2021-06-28T20:14:03.226Z]             1..3
[2021-06-28T20:14:03.226Z]         ok 5 - ecsPinoFormat case: `base: {}` should avoid "process" and "host" fields # time=2.879ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]         # Subtest: ecsPinoFormat case: `base: null` should not break ecs-logging format
[2021-06-28T20:14:03.226Z]             ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]             ok 2 - should be equal
[2021-06-28T20:14:03.226Z]             ok 3 - logged record matches expected record
[2021-06-28T20:14:03.226Z]             1..3
[2021-06-28T20:14:03.226Z]         ok 6 - ecsPinoFormat case: `base: null` should not break ecs-logging format # time=2.86ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]         # Subtest: ecsPinoFormat case: no message in log call should be fine
[2021-06-28T20:14:03.226Z]             ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]             ok 2 - should be equal
[2021-06-28T20:14:03.226Z]             ok 3 - logged record matches expected record
[2021-06-28T20:14:03.226Z]             1..3
[2021-06-28T20:14:03.226Z]         ok 7 - ecsPinoFormat case: no message in log call should be fine # time=3.272ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]         1..7
[2021-06-28T20:14:03.226Z]     ok 1 - ecsPinoFormat cases # time=653.404ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     # Subtest: convertReqRes:true and HTTP req, res
[2021-06-28T20:14:03.226Z]         1..7
[2021-06-28T20:14:03.226Z]         ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]         ok 2 - should be equal
[2021-06-28T20:14:03.226Z]         ok 3 - expect truthy value
[2021-06-28T20:14:03.226Z]         ok 4 - should be equal
[2021-06-28T20:14:03.226Z]         ok 5 - http.request.method
[2021-06-28T20:14:03.226Z]         ok 6 - http.response.status_code
[2021-06-28T20:14:03.226Z]         ok 7 - user_agent.original
[2021-06-28T20:14:03.226Z]     ok 2 - convertReqRes:true and HTTP req, res # time=58.426ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     # Subtest: convertErr is true by default
[2021-06-28T20:14:03.226Z]         ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]         ok 2 - should be equal
[2021-06-28T20:14:03.226Z]         ok 3 - should be equal
[2021-06-28T20:14:03.226Z]         ok 4 - should be equal
[2021-06-28T20:14:03.226Z]         ok 5 - should match pattern provided
[2021-06-28T20:14:03.226Z]         1..5
[2021-06-28T20:14:03.226Z]     ok 3 - convertErr is true by default # time=8.493ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     # Subtest: convertErr does not blow up on non-Errors
[2021-06-28T20:14:03.226Z]         ok 1 - should be equal
[2021-06-28T20:14:03.226Z]         ok 2 - should be equal
[2021-06-28T20:14:03.226Z]         ok 3 - should be equal
[2021-06-28T20:14:03.226Z]         ok 4 - should be equivalent
[2021-06-28T20:14:03.226Z]         1..4
[2021-06-28T20:14:03.226Z]     ok 4 - convertErr does not blow up on non-Errors # time=5.423ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     # Subtest: convertErr=false allows passing through err=<non-Error>
[2021-06-28T20:14:03.226Z]         ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]         ok 2 - should be equal
[2021-06-28T20:14:03.226Z]         ok 3 - rec.err is unchanged
[2021-06-28T20:14:03.226Z]         ok 4 - no rec.error is set
[2021-06-28T20:14:03.226Z]         1..4
[2021-06-28T20:14:03.226Z]     ok 5 - convertErr=false allows passing through err=<non-Error> # time=5.004ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     # Subtest: createEcsPinoOptions with no formatters.log
[2021-06-28T20:14:03.226Z]         ok 1 - expect truthy value
[2021-06-28T20:14:03.226Z]         ok 2 - should be equal
[2021-06-28T20:14:03.226Z]         ok 3 - should be equal
[2021-06-28T20:14:03.226Z]         ok 4 - should be equal
[2021-06-28T20:14:03.226Z]         ok 5 - should be equal
[2021-06-28T20:14:03.226Z]         1..5
[2021-06-28T20:14:03.226Z]     ok 6 - createEcsPinoOptions with no formatters.log # time=5.353ms
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z]     1..6
[2021-06-28T20:14:03.226Z]     # time=771.925ms
[2021-06-28T20:14:03.226Z] }
[2021-06-28T20:14:03.226Z]
[2021-06-28T20:14:03.226Z] 1..2
[2021-06-28T20:14:03.226Z] # time=7322.897ms
[2021-06-28T20:14:03.226Z] ERROR: Coverage for lines (98.86%) does not meet global threshold (100%)
[2021-06-28T20:14:03.226Z] ERROR: Coverage for branches (98.73%) does not meet global threshold (100%)
[2021-06-28T20:14:03.226Z] ERROR: Coverage for statements (98.86%) does not meet global threshold (100%)
[2021-06-28T20:14:03.226Z] ----------|----------|----------|----------|----------|-------------------|
[2021-06-28T20:14:03.226Z] File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
[2021-06-28T20:14:03.226Z] ----------|----------|----------|----------|----------|-------------------|
[2021-06-28T20:14:03.226Z] All files |    98.86 |    98.73 |      100 |    98.86 |                   |
[2021-06-28T20:14:03.226Z]  index.js |    98.86 |    98.73 |      100 |    98.86 |                72 |
[2021-06-28T20:14:03.226Z] ----------|----------|----------|----------|----------|-------------------|
[2021-06-28T20:14:03.257Z] $ docker stop --time=1 9ccdb2a2396822a1a46f69ec4df1ce051071fe5e8865b8139e76c4f44e64700c
[2021-06-28T20:14:04.596Z] $ docker rm -f 9ccdb2a2396822a1a46f69ec4df1ce051071fe5e8865b8139e76c4f44e64700c
[2021-06-28T20:14:06.044Z] Failed in branch Test - Node.js v15
[2021-06-28T20:14:06.427Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_ecs-logging-nodejs-mbp_PR-84
[2021-06-28T20:14:06.566Z] [INFO] getVaultSecret: Getting secrets
[2021-06-28T20:14:06.619Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-06-28T20:14:07.503Z] + chmod 755 generate-build-data.sh
[2021-06-28T20:14:07.503Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-84/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-84/runs/1 FAILURE 630891
[2021-06-28T20:14:07.503Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-84/runs/1/steps/?limit=10000 -o steps-info.json
[2021-06-28T20:14:07.503Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-84/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-06-28T20:14:07.753Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-06-28T20:14:08.665Z] Retry 2/3 exited 22, retrying in 2 seconds...

<EMAIL_ADDRESS>published


Can not create secondary zone

PDA version
0.4.0
Python version
3.8
Steps to Reproduce

Click on 'create zone'
Fill Zone name like myzone1.test.org
Zone Type Secondary  and point primary dns IP  , SOA-EDIT-API as DEFAULT

via pdnsutils zone with the same values created correctly
Expected Behavior
A new zone record should have been created with the specified values
Observed Behavior

Zone created without Primary IP

This has been fixed in 0.4.1, see #1502

Tested
all OK!


Flow Setup (Mac & maybe others)

Need to put a note in the setup instructions.
Whenever I need to run the sumo-gui (or whenever the gui needs to be initialized), there's an error that states: FXApp::openDisplay: unable to open display :0.0
In order to get the gui running, you need to open up Xquartz in your computer first and keep it running. Then, you can run the sumo/flow commands and run the simulations.

Good catch.

This is in now.


In the CloudEvents cases make message.ID=ce-type

In Endpoints and Message specs - maybe?
Can we make this a MUST?
Proposal:
Just in message spec: RECOMMEND that msg.ID=ce-type when CE is being used, for easy ID maintenance

Agreed on 9/24 call


DISP-S1 CalVal SAS 0.4.3 PGE Integration

Ticket to track integration of new 0.4.3 SAS delivery into DISP-S1 PGE

[ ] Update SAS version number to 0.4.3 in disp_s1_pge.py
[ ] Update container build script to use disp-s1:0.4.3 as base image
[ ] Update SAS Yamale Schemas for DISP-S1 to latest from ADT repository. This includes the schema for the Algorithm Parameters RunConfig
[ ] If SAS Yamale schemas have changed, make sure changes are reflected in the sample DISP-S1 RunConfigs bundled with the repository
This should include the DISP-S1 RunConfig within the examples directory, as well as the baseline and algorithm RunConfigs used with the unit tests
If sample values are needed for new RunConfig fields, consult the examples provided with the "golden" dataset stored in Artifactory-FN
[ ] Examine metadata from a sample DISP-S1 output product, and if metadata is now available, use it to update the ISO.xml template
The opera.util.tiff_utils.get_geotiff_metadata() can be used to extract all available product metadata from one of the expected output product GeoTIFFs included in the "golden" delivery from ADT
For each entry in the metadata dictionary extracted from the product, there should be a corresponding entry within the MeasuredParameters section of the template
[ ] Create the expected input and output archives used with the Integration test from the samples provided by ADT
This involves splitting out the input data (including ancillaries) and expected outputs from the "golden" data on Artifactory into separate .zip files for each, then uploading the new archives to S3
[ ] Rerun the unit test suite for DISP-S1 to ensure all tests pass
[ ] Rerun the DISP-S1 Integration Test to ensure it passes using the new expected assets for the calval delivery

https://github.com/opera-adt/disp-s1/blob/main/src%2Fdisp_s1%2Fpge_runconfig.py


BatchAI: Renaming file (again)

I added this file in PR #517, but gave it the wrong name (shouldn't have had the dash). I tried renaming the file in PR #519, but that PR gave a warning about a random file I didn't touch. So I'm trying again here with a clean PR.

OPS Build status updates of commit 1275266:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml
:warning:Warning
View (azure-node-latest)
Details

:warning:Warning

Details

docs-ref-services/batchai.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml

[Warning] Uid(microsoft-cognitiveservices-speech-sdk) has already been defined in docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml.

[Warning] Multiple input files would generate to the same output path overwriting each other. Please rename at least 1 of following input files to ensure that there will be only one file to generate to the output path: "docs-ref-services/batchai.md, docs-ref-autogen/overview/BatchAI.yml".
[Warning] Multiple input files would generate to the same output path overwriting each other. Please rename at least 1 of following input files to ensure that there will be only one file to generate to the output path: "docs-ref-services/batchai.md, docs-ref-autogen/overview/BatchAI.yml".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit d5d3054:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/batchai.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml

[Warning] Uid(microsoft-cognitiveservices-speech-sdk) has already been defined in docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off - The files I touched look correct. I don't know why the file docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml is being referenced here, but I don't know what the file is or how to fix it.

@Taojunshen, does @garyericson need to address that warning, or can it be ignored?

@Taojunshen disregard - Robert went ahead and merged it. :smile:
@garyericson you're GTG.


[Bug] Playgrounds autogeneration does not support Angular 16 required inputs

Is this a regression?
No
Description
New Angular 16 feature with required inputs generates wrong results:
@Component({
  selector: "ng-doc-playground-1",
  template: `
		<icon [{ required: true }]="properties['icon']" [size]="properties['size']" [strokeWidth]="properties['strokeWidth']" [color]="properties['color']"></icon>
	`,
  standalone: true,
  imports: [CommonModule, pageEntity.playgrounds["IconPlayground"].target],
  changeDetection: ChangeDetectionStrategy.OnPush,
})

Docs: https://angular.io/api/core/Input
Please provide the exception or error you saw
Error: .ng-doc/docs/guides/docs/playgrounds.ts:18:3 - error NG5002: Opening tag "icon" not terminated.

18   <icon [{ required: true }]="properties['icon']" [size]="properties['size']" [strokeWidth]="properties['strokeWidth']" [color]="properties['color']"></icon>
     ~~~~~~~~~~~~~~~~~~

OS
Unix (Linux, macOS, etc.)
Browser
None
Node version
v18.16.0
Anything else?
Leaving for future improvements :wink:

Ah I see, I didn't check that after the migration to Angular 16, but I'll fix it as well, thank you!

:tada: This issue has been resolved in version 16.6.2 :tada:
The release is available on:

v16.6.2
GitHub release

Your semantic-release bot :package::rocket:


refactor listener config loading

Not for merge until the 1.2.0 window opens.
This is prep work for #561, but it makes sense on its own, and the full change for #561 is messy enough that we may not want to do it unless discussions with the hashbang people proceed further. This change will also be helpful if we do #448 ("sts-only listener" will become a flag on listenerConfig, analogous to "is this listener TLS?" and "is this listener Tor?").
Anyway, another benefit of this change is that reading the certificates now takes place as part of the config load, so it solves the case where you get part of the way through the rehash and then it fails because the certs are missing or their permissions are bad.

Just a heads-up, the public plaintext listener is disabled in this rewrite of the default config, with instructions on how to reenable it. I can reverse that decision if necessary.

Let's keep exposing the plaintext listener on 6667 for now. My opinion on it is: We need to keep exposing a listener on 6667 by default, being one of the most well-used ports for IRC. We don't, however, need to expose a real listener on it. Once #448 is done we can have it do that by default (and make it an easy flick of a switch to turn it back into a normal listener).

After the 6667 listener is re-enabled and the :6697 message issue raised above are addressed, this is fine to merge in. Thanks for the awesome fixes :)


Run 1.6 billon demo is much slow than description on A100 GPU?

I run 1.6 billion parameters demo, it cost 1:46:27 on first step and 2:12:56 on second step.
it's much slower than below.
Actor: OPT-1.3B Reward: OPT-350M | 2900 Sec | 670 Sec | 1.2hr | 2.2hr
Is there any thing to tune other than run:
python train.py --actor-model facebook/opt-1.3b --reward-model facebook/opt-350m --deployment-type single_gpu
Thanks

I'm using A100 which have better performance than A6000.

After the train, when i run the final model.
It responds very weird.

@tcluoct I ran step1 with A6000 using the latest version of DeepSpeed and DeepSpeedExamples, and it was much faster than the time you reported.
Can you update them to the latest version and measure the time for data loading/forward/backward/step?

Closing because we have no further information. Feel free to reopen if the problem still exists.


fix: crd groupby logic

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re https://github.com/kcl-lang/kcl/issues/1542
fix: crd groupby logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 14.214%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/options/import.go
0
1
0.0%

pkg/import/crd/groupby.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.02%

Covered Lines:
85

Relevant Lines:
598

💛  - Coveralls


Soundcloud Links fail, "Suspicious exception for loading item [URL] , This url does not appear to be a playable track."

Running https://github.com/jagrosh/MusicBot on a Windows 10 PC. Can confirm soundcloud links were functioning as of 3 days ago, and youtube links are still working.
Example error in the java console:
[19:39:30] [WARN] [DefaultAudioPlayerManager]: Suspicious exception for loading item https://soundcloud.com/user-694398002/excuse-my-rudeness-but-could-you-please-die
com.sedmelluq.discord.lavaplayer.tools.FriendlyException: This url does not appear to be a playable track.
	at com.sedmelluq.discord.lavaplayer.source.soundcloud.DefaultSoundCloudHtmlDataLoader.load(DefaultSoundCloudHtmlDataLoader.java:31)
	at com.sedmelluq.discord.lavaplayer.source.soundcloud.SoundCloudAudioSourceManager.loadFromTrackPage(SoundCloudAudioSourceManager.java:202)
	at com.sedmelluq.discord.lavaplayer.source.soundcloud.SoundCloudAudioSourceManager.processAsSingleTrack(SoundCloudAudioSourceManager.java:179)
	at com.sedmelluq.discord.lavaplayer.source.soundcloud.SoundCloudAudioSourceManager.loadItem(SoundCloudAudioSourceManager.java:116)
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItemOnce(DefaultAudioPlayerManager.java:437)
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItem(DefaultAudioPlayerManager.java:419)
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$createItemLoader$0(DefaultAudioPlayerManager.java:218)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at com.sedmelluq.discord.lavaplayer.tools.OrderedExecutor$ChannelRunnable.executeQueue(OrderedExecutor.java:98)
	at com.sedmelluq.discord.lavaplayer.tools.OrderedExecutor$ChannelRunnable.run(OrderedExecutor.java:87)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Let me know if there's more info I can provide to assist.

This got fixed with #570 and update today. Update to 1.3.64 and try it again?

I see. I'm not the owner of the bot's git project but I've managed to manually update before, I'll give it a shot. Thanks

Ok after finally managing to set up Maven, I have updated the musicbot with the latest lavaplayer and it DOES resolve this. Closing, thanks again!


final block of xml wasn't formatted as xml

added "xml" at top of code block

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ry8806 : Thanks for your contribution to the Azure documentation! The author, @mani-ramaswamy, has been notified to review your proposed change.

#sign-off


fix(v2alpha1): fix can not update EMQX resource

do not generate emqx node cookie in default webhook, generated it in generated functions.
fix https://github.com/emqx/emqx-operator/issues/480

Coverage increased (+1.7%) to 75.621% when pulling c19bf4526358394dd4caf46bd33e3ca26814543d on Rory-Z:fix/fix-can-not-update into cebcc517f3a98eb4c0dc89416c723e26e293da28 on emqx:main.


Speaker Issue

I was transcript an audio file in which only one person speak but in the response I got 3 speaker. Is there anything I need to fix at my end?

@IAmVinnnn Take a look at this section of the documentation:  Speaker Labels.
It documents the speaker labels feature but also describes some of the oddities that you may encounter in speaker labels results.  The interface is still beta at this time, and its recognition of speakers is not perfect. It can identify extra speakers based on the audio that it encounters.  Specifically, under "Performance considerations," the documentation states
Performance for audio with a single speaker can be poor. Variations in audio quality or in the speaker's voice can cause the service to identify extra speakers who are not present. Such speakers are referred to as hallucinations.
So what you're seeing may just be an unavoidable artifact of the audio for a single speaker.  Audio quality can help performance, so if there is any way to ensure cleaner input, you might try that.

This issue is fairly old and there hasn't been much activity on it. Closing, but please re-open if it still occurs.


Keyboard hidden after select

When closing the select screen the keyboard is hidden / closed. The first action after selecting some text would be to use it with the keyboard so to have to open the keyboard every time is a pain in the neck.
Informations

Device : iPad 7 generation
OS : iOS 14.2
WebSSH Pro version : 14.8.11

To Reproduce
Steps to reproduce the behavior:

Long press on the main window
Choose “Select” from the pop-up
Close the select screen with the X top-right
Observe the keyboard is now missing

Hello @ash34 👋
That's a good issue, thank you!
You are right : if keyboard was opened before selecting text it should appear again when exiting selection window
I plan it for this release because I think it should be fixed soon.
Have a nice day ☀

I'm working on it right now

Hello @ash34 👋
Could you try 14.8.13?

Yes, that’s solved it.


django 1.7 compatible

on django 1.7
sudo picostk init db
results in
Traceback (most recent call last):
  File "/usr/local/bin/picostk", line 429, in <module>
    args.handler(args)
  File "/usr/local/bin/picostk", line 311, in process_init_cmds
    instance.init_db()
  File "/usr/local/bin/picostk", line 197, in init_db
    management.call_command('syncdb', interactive=True, verbosity='1')
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 93, in call_command
    app_name = get_commands()[name]
  File "/usr/local/lib/python2.7/dist-packages/django/utils/lru_cache.py", line 101, in wrapper
    result = user_function(*args, **kwds)
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 73, in get_commands
    for app_config in reversed(list(apps.get_app_configs())):
  File "/usr/local/lib/python2.7/dist-packages/django/apps/registry.py", line 137, in get_app_configs
    self.check_apps_ready()
  File "/usr/local/lib/python2.7/dist-packages/django/apps/registry.py", line 124, in check_apps_ready
    raise AppRegistryNotReady("Apps aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.

somewhat similar error is
 Traceback (most recent call last):
  File "/usr/local/bin/picostk", line 10, in <module>
    execfile(__file__)
  File "/home/pstk/picostack_app/picostk", line 431, in <module>
    args.handler(args)
  File "/home/pstk/picostack_app/picostk", line 254, in run_as_daemon
    daemon_runner.do_action()
  File "/usr/local/lib/python2.7/dist-packages/daemoncxt/runner.py", line 186, in do_action
    func(self)
  File "/usr/local/lib/python2.7/dist-packages/daemoncxt/runner.py", line 131, in _start
    self.app.run()
  File "/home/pstk/picostack_app/picostack/deamon_app.py", line 142, in run
    self.step()
  File "/home/pstk/picostack_app/picostack/deamon_app.py", line 137, in step
    self.vm_manager.destory_machines()
  File "/home/pstk/picostack_app/picostack/vm_manager.py", line 217, in destory_machines
    self.remove_machine(machine)
  File "/home/pstk/picostack_app/picostack/vm_manager.py", line 367, in remove_machine
    machine.delete()
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 895, in delete
    collector.collect([self])
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/deletion.py", line 219, in collect
    for related in get_candidate_relations_to_delete(model._meta):
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/deletion.py", line 67, in <genexpr>
    f for f in candidate_model_fields
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/deletion.py", line 62, in <genexpr>
    opts.get_fields(include_hidden=True) for opts in candidate_models
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/options.py", line 740, in get_fields
    return self._get_fields(include_parents=include_parents, include_hidden=include_hidden)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/options.py", line 802, in _get_fields
    all_fields = self._relation_tree
  File "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 60, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/options.py", line 709, in _relation_tree
    return self._populate_directed_relation_graph()
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/options.py", line 681, in _populate_directed_relation_graph
    all_models = self.apps.get_models(include_auto_created=True)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/lru_cache.py", line 101, in wrapper
    result = user_function(*args, **kwds)
  File "/usr/local/lib/python2.7/dist-packages/django/apps/registry.py", line 168, in get_models
    self.check_models_ready()
  File "/usr/local/lib/python2.7/dist-packages/django/apps/registry.py", line 131, in check_models_ready
    raise AppRegistryNotReady("Models aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Models aren't loaded yet.


StandaloneWindows bundle name

Hi,
We are still using this asset, thanks again!
We are building and uploading our ABs using Unity Cloud (in the Post Process step).
It seems that if we build the ABs with "Windows 64" as the build target the output folder is named StandaloneWindows64, same for the manifest.
private static void BuildAssetBundles() {
  var buildPath = GetAssetBundleFolder();

  if (Directory.Exists(buildPath)) {
    Directory.Delete(buildPath, true);
  }

  Directory.CreateDirectory(buildPath);

  // Build asset bundles for the current platform
  BuildPipeline.BuildAssetBundles(buildPath, BuildAssetBundleOptions.None, EditorUserBuildSettings.activeBuildTarget);
}

private static string GetAssetBundleFolder() {
  return "Assets/StreamingAssets" + "/" + EditorUserBuildSettings.activeBuildTarget;
}

But ofc in AssetBundleUtility.GetPlatformForAssetBundles the bundle name is always set to StandaloneWindows and not StandaloneWindows64.
Not quite sure what to make of that, the best solution would probably be to rename the output folder and manifest during Cloud Build for the windows 64bit target.
Or we could check if windows is 64bits at runtime using this method and select the appropriate bundle name.

My understanding is that StandaloneWindows and StandaloneWindows64 are actually the same types when it comes to asset bundles, which is why AssetBundleUtility.GetPlatformForAssetBundles is written the way it is.  What might be easiest is to change your BuildAssetBundles script to build bundles for StandaloneWindows when the active build target is StandaloneWindows64. Alternatively you could modify AssetBundleUtility.GetPlatformForAssetBundles to return StandaloneWindows64 when the build target is StandaloneWindows64.

Thank you, I created a small helper that I use while building the ABs to get the platform name
        private static BuildTarget GetAssetBundleBuildTarget(BuildTarget target) {
            switch (target) {
                case BuildTarget.StandaloneWindows64:
                    return BuildTarget.StandaloneWindows;
                case BuildTarget.StandaloneLinux64:
                    return BuildTarget.StandaloneLinux;
                default:
                    return target;
            }
        }

            BuildPipeline.BuildAssetBundles(buildPath, BuildAssetBundleOptions.None, GetAssetBundleBuildTarget(EditorUserBuildSettings.activeBuildTarget));

We can close this issue !


fix(version): update @angular/core to 4.3.7

fix(version): update @angular/core to 4.3.7
This PR was generated by UpdateBot

[merge]

Replacing previous commit

[merge]


GH Actions: version update for ramsey/composer-install

The action used to install Composer packages and handle the caching has released a new major (and some follow-up patch releases), which means, the action reference needs to be updated to benefit from it.
Refs:

https://github.com/ramsey/composer-install/releases/tag/2.0.0
https://github.com/ramsey/composer-install/releases/tag/2.0.1
https://github.com/ramsey/composer-install/releases/tag/2.0.2

Thanks @jrfnl

@gmazzap FYI - the same test failure as I saw in #114 is also happening here. Is unrelated to the PRs, but I haven't got time at this moment to look into it. Means that, as this is now merged, master is failing.

Thank @jrfnl I saw that. I'll try to have a look as soon as I can.
It seems the shebang line on top of PHPUnit php entrypoint file (in the version installed on PHP 7.2, so 8.something) is causing troubles. Which is strange considering that it is before the first php opening tag...


Resolve page-unload-barrier waiting after a timeout (workaround for #437, #664)

/cc @inikulin @helen-dikareva @georgiy-abbasov @VasilyStrelyaev
We fix the situation when the beforeunload event is raised but the page is not unloading (it occurs if it was click on a download link or in the situation described in #664).
So, with this fix we resumes the test if the page is not unloaded after 15 seconds after the beforeunload event.
In usual case it can be delay between beforeunload and unload events if the server responses with some timeout (it can be hard work on the server or a query to a database or smthg else).
We were planning to use the hammerhead feature to fix this, but it takes to much time to implement it. So I think we should add this temporary fix as a workaround for now to have not this problems in the release version

\r-

@testcafe-build-bot \retest

lgtm

lgtm

lgtm

FPR /cc @VasilyStrelyaev

lgtm

thanks


Emscripten compilation support?

It would be really cool if appleseed supports Emscripten compilation.  Since appleseed is almost entirely c++ library, I think it might not be that difficult.
FYI: someone worked on cycles emscripten compilation few years ago: https://github.com/paulfitz/emcycles

I agree that it would be awesome. However, although compiling appleseed itself with Emscripten shouldn't be too difficult, compiling all third party dependencies (including LLVM itself!) is a tall order.


recipe update 2024.10.1 build 1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Reverting to an older rasterio version to fix a bug in Sentinel-2 processing

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


[DOCUMENTATION] Fix typos

Hi, great work on the library! I'm reading the documentation, it's very interesting. I spotted a few typos in the documentation, would it be okay if I proof-read the documentation, corrected the typos and opened a PR for that?

Hi, thanks for submitting an issue and for reading the documentation !
Please feel free to proof-read the documentation and open a PR. Just make sure there is no warning when you build the documentation with make html. If you only modify the documentation files, there's no need for installing the development environment.
Thanks !


Most popular Algorithms asked in Interviews.

Description
Here, I will be listing most popular Algorithms Definitions, where to use it along with its psuedo code where applicable.
Domain
Interview Prep
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign Document

@syedareehaquasar can you close this issue and other merged/done issues

sure

@syedareehaquasar I can close only issues that were opened by me.


Revisit configuration

Values from Flags aren't being parsed anymore. This means we don't get expected values. Config is also spread over env vars and command line args.
Options:

Move config to files (eg yaml or toml)
Standardise on env vars or command line args

We should also review config options and decide if we need and is the default useful?
Also:

Follow-up from #142

make tickers configurable
make stats dataset configurable
move dataset and other similar config to config file

Config items have been refactored and cleaned up in #197


Implement string restrictions.

length
minLength
maxLength
whitespace=preserve|replace|collapse

cherry-picked as 53df72984dbedca5739303e6c97e882be28c496b


current app version can't handle real sized genesets ( ~ 1k genes)

this is the same issue as #256  where becuase of browser cookie size limits can't store a good sized geneset in cooke.  this issue is to fix it in the current production version since the branch that was fixed in is not ready for production
discovered that you could use flask-session2 which requires an upgrade from flask 1 to flask 2.2 which could have repercussions other libs and for the app itself.
see current dev requirements file : https://github.com/krishnanlab/geneplexus_app/blob/dev/requirements.txt
and the commit 04643a3cb8228cb3676a5ed2c2c08dcceae8952b for the PR.  This uses a db backed session which
which contains several libs for user account database which are not needed for production (flask dance, sqlalchemy etc), would use filesystem instead `app.config['SESSION_TYPE'] = 'filesystem'

Revisiting this and for the  main branch.   the solution here is to use https://pypi.org/project/flask-session2/ and a backend.  We aren't using a database so need to use either the file system backend.  The downside for this is that files could grow unless this lib will prune sessions as needed.  Could potentially use sqlite with the 'peewee' library which is much lighter than Flask-sqlalchemy but again need a method to determine the system is culling sessions.

this fix works for me for a 500 element geneset.  @ChristopherMancuso  would you please try the app with one of your "large" genesets ?

@billspat a list of 2000 genes worked great


Time Complexity of GPyOpt

What is the time complexity of GPyOpt?
Let's suppose GPyOpt should find the optimum of a n-dimensional real space and has already sampled N points, how long does it take to find the next point to evaluate? When looking at the optimisations I have run so far it seems to be something like O(n*n*N).

There is unlikely a clear cut answer to this, as gpyopt is very configurable. The most important factors are:

invert the covariance matrix of the GP, that is O(N^3)
optimize acquisition, default optimizer in gpyopt is L-BFGS, and it requires the above inversion every step the optimizer, so that would be O(n*N^3)

however note that depending on acquisition function and the choice of the model these might be fluctuate quite a bit. and also note that there is no set number for how many iterations it will take for optimizer to converge, although there might be some pre-set max

i suppose this can be closed, please reopen if above does not answer fully


Account for null values in AnimatedPositioned

I was using animated positioned an I wanted to move a widget from the top of a stack to the bottom. I was using top: 0, bottom: null and then setting the state to top: null, bottom:0. This made the widget move, but no animation. I'm told that since it's interpolation between the values of the old position and new, it can't have null values, since that wouldn't make sense.
This makes since with that explanation, but it doesn't from an outside view. Could the widget be a little "smarter" and determine its relative position and use that for interpolation rather than the values if interpolation from a null value?

Bump

+1 I'm currently having the same problem...


Cannot save advanced indexing options

Describe the bug

Open settings as an admin
Toggle to advanced
Go to the indexing options and change a setting. Example in picture is Folder reindexing sensitivity
Try to save and cannot.

The save button is still grayed out, and unable to be pressed.
Other settings work and are saveable.
Screenshots

Environment (please complete the following information):

OS: Server: Debian 10, Client: Win 10
Browser: Both Chrome 80 and Firefox 74

Used app version:
Docker latest (1.8)

Hi, thanks for the report.
I started at a new  company that has strong restriction on hobby projects. It will take some time until I sort it out, so I cannot give you a date when it will be ready. Until then you can manually change the config file.
Patrik

This issue is related to #161. See more explanation there.
TL;RD: New version should solve it.

Thanks, I updated to nightly and I am having no more issues.


OSX support

Right now the plugin supports iOS apps only, but Cordova and Swift are also available for OSX

Did you have a try with this plugin in an OSX context ? What issues do you encounter ?
I'm not really comfortable with the OSX version of Cordova,  I'll use Electron in that case.

It wasn't immediately obvious how I would need to update the plugin code to get it going under OSX so I haven't tried it yet. I was looking at using it because I am wrapping a (proprietary) library in a cordova plugin and the library works on OSX so it would be convenient to test the plugin code this way.

Interested in the same, and just found this issue. Did either of you ever get a chance to look at this since the most recent comment ~8 months ago? Happy to try to help too (though we're using the https://github.com/bitjson/cordova-plugin-swift-support fork only because [that's the one that cordova-plugin-qrscanner depends on, no idea why they're apparently preferring to leave their fork divergent rather than attempting to merge upstream? /cc @bitjson -- any interest in merging back here, or explaining in your README the purpose of continuing to maintain a divergent fork? Thanks:)

Hey @jab – info in this thread: https://github.com/akofman/cordova-plugin-add-swift-support/issues/24
TL;DR:
probably use this one, not my fork
(but my fork will stay as-is for https://github.com/bitpay/cordova-plugin-qrscanner)

@bitjson That link to #24 is really helpful, thanks! (Just sent you a PR to add that info to your README so others can find it more easily in the future.)
We'll probably stick to using your fork, since we already depend on cordova-plugin-qrscanner, and it seems better to not depend on both swift-support plugins as long as we can avoid it.
While we're here, do you have any interest in adding OS X support to your fork? (I'd ask that by opening a new issue for it in your repo, but it looks like issues are disabled there. Any interest in going into https://github.com/bitjson/cordova-plugin-swift-support/settings and enabling issues?)
Thanks again!

Just a wanted to try pinging you again @bitjson and @akofman - would love to know each of your interest in collaborating on adding OS X support (even if only to merge a patch), thanks!

Hey,
I close this issue because I think #37 responded to your needs.

#37 did not fix it but I just submitted a pull request that does

Pull request is #46

The resulting project doesn't build :/ but this gets us closer


REQUEST: New membership for

GitHub Username
zstone12
Requirements

[x] I have reviewed the community membership guidelines (https://github.com/cloudwego/community/blob/main/COMMUNITY_MEMBERSHIP.md)
[x] I have joined to the Slack Channel and Feishu Group Chat (for Chinese)
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more CloudWeGo repositories

List of contributions to CloudWeGo

Doc Contribution

https://github.com/cloudwego/cloudwego.github.io/pull/382
https://github.com/cloudwego/cloudwego.github.io/pull/445
https://github.com/cloudwego/cloudwego.github.io/pull/402
https://github.com/cloudwego/cloudwego.github.io/pull/452
https://github.com/kitex-contrib/opensergo/pull/2

Code Contribution

https://github.com/hertz-contrib/registry/pull/6
https://github.com/hertz-contrib/requestid/pull/7
https://github.com/kitex-contrib/opensergo/pull/3
https://github.com/cloudwego/hertz-examples/pull/53
https://github.com/kitex-contrib/obs-opentelemetry/pull/5
https://github.com/hertz-contrib/pprof/pull/3
https://github.com/cloudwego/hertz/pull/299
https://github.com/hertz-contrib/gzip/pull/4

Code Review of CloudWeGo

https://github.com/hertz-contrib/keyauth/pull/1
https://github.com/hertz-contrib/registry/pull/24
https://github.com/hertz-contrib/registry/pull/8
https://github.com/hertz-contrib/secure/pull/1
https://github.com/cloudwego/cloudwego.github.io/pull/361
https://github.com/hertz-contrib/sessions/pull/2

Issues about CloudWeGo

https://github.com/kitex-contrib/obs-opentelemetry/issues/4
https://github.com/cloudwego/hertz/issues/414

Thank you for your active contribution to the Hertz extension Code Review.❤

+1, thanks for your contribution.

+1 Welcome~

+1, :thumbsup:

+1~

+1，Welcome~

+1，Welcome~

+1

Hi, your request has been reviewed by the CloudWeGo community management team and passed with majority approval. Congratulations !
You have been invited to join CloudWeGo org and hertz-contrib as a public member, as well as Hertz Committer Team in CloudWeGo. Your certificate is here.
Please check Responsibilities and privileges for more details.
Welcome to Join us !


Goimports is broken in go-mode

What did you expect to happen?
Write go code and press SPC-f-s to save. All missing imports will be added and all unnecessary imports will be removed.
What actually happened?
No missing imports are added and no unnecessary imports are removed
Additional details:
My config works before latest doom upgrade.
And if I invoke M-x gofmt manually, goimports works fine, it seems the before-save-hook doesn't work anymore.
System information:

```
SYSTEM  type       darwin
        config     x86_64-apple-darwin19.6.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
        path       (~/.yarn/bin ~/.config/yarn/global/node_modules/.bin ~/.nix-profile/bin ~/.emacs.d/bin /usr/local/opt/llvm/bin ~/.cargo/bin ~/SDK/sciter-sdk/bin.osx/ ~/.pub-cache/bin /Library/Frameworks/Python.framework/Versions/3.7/bin /usr/local/sbin ~/SDK/flutter/bin /usr/local/share/dotnet ~/Documents/Gocode/bin /usr/local/apache-ant-1.9.3/bin ~/SDK/android-sdk-macosx/tools ~/SDK/android-sdk-macosx/platform-tools ~/SDK/android-sdk-macosx /usr/local/apache-ant-1.9.3/bin ~/SDK/android-sdk-macosx/tools ~/SDK/android-sdk-macosx/platform-tools ~/SDK/android-sdk-macosx ~/SDK/cocos2d-x-3.7.1/templates ~/SDK/cocos2d-x-3.7.1/tools/cocos2d-console/bin /opt/local/bin /opt/local/sbin ~/.nvm/v0.10.26/bin /usr/local/j2objc-0.9.5 /usr/local/mongodb/bin /usr/local/gradle-2.1/bin /usr/share/java/apache-maven-3.0.5/bin ~/SDK/android-sdk-macosx/platform-tools ~/SDK/android-sdk-macosx/tools ~/Documents/Gocode/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /opt/X11/bin /usr/local/git/bin /usr/local/ant/bin /usr/local/go/bin /nix/store/zcrj9cifa44yn0qi4darydpgm5qxczq5-emacsGccDarwin/libexec/emacs/28.0.50/x86_64-apple-darwin19.6.0/)
EMACS   dir        ~/.emacs.d/
        version    28.0.50
        build      Nov 02, 2020
        buildopts  --prefix=/nix/store/zcrj9cifa44yn0qi4darydpgm5qxczq5-emacsGccDarwin --disable-build-details --with-modules --with-ns --disable-ns-self-contained --with-nativecomp --with-ns CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200
        features   JPEG TIFF PNG RSVG GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES NATIVE_COMP THREADS JSON PDUMPER
        traits     (server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        build      HEAD -> develop fcdd23829 2020-11-01 16:25:38 -0500
        elc-files  0
        modules    (:completion company (ivy +icons +prescient +childframe) :ui doom doom-dashboard hl-todo modeline ophints (popup +all +defaults) treemacs vc-gutter (window-select +numbers) workspaces :editor (evil +everywhere) file-templates (format +onsave) multiple-cursors rotate-text snippets word-wrap :emacs dired electric undo vc :term vterm :checkers syntax :tools (eval +overlay) lookup lsp :os macos :tools magit rgb taskrunner :lang (dart +flutter +lsp) emacs-lisp (go +lsp) json (javascript +lsp) lua markdown org rest sh web yaml :config (default +bindings +smartparens))
        packages   ((lsp-ui :disable t) (literate-calc-mode) (tiny))
        unpin      (n/a)
        elpa       (n/a)
```

Probably gofmt is formatting a region and not the whole file. When reformatting partial code goimports  is not called because there are some cases that don't work smoothly.

A quick fix is invoke gofmt in before-save-hook.
(add-hook 'go-mode-hook
          (lambda ()
            ...
            (add-hook 'before-save-hook
                      (lambda ()
                        (gofmt))))
          100)

Here's a quick fix meanwhile:
(after! go-mode
  (setq gofmt-command "goimports")
  (add-hook 'go-mode-hook
            (lambda ()
              (add-hook 'after-save-hook 'gofmt nil 'make-it-local))))

It seems like gopls can do it if you have the +lsp flag enabled. I've looked at lsp-mode but it only refers to old issues that has changed since.


Sparkc 505 b2.0

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with success


CAPTCHAs.IO Integration

Hi,
I'd like to ask support for integration of https://captchas.io/ captcha solving service.
Thanks!
Glenn Prialde

No.
Additionally, I find it interesting that this is present on that website:
https://reel.geel.tf/ppilk7jlkjx0jf7j6mfv.png
You don't get to simultaneously acknowledge why captchas are important for businesses, while simultaneously offering a way to get around them.
Do it yourself.

Oh man, that's comedy gold.


chore(ci): disable depguard linter

Since we do not customise config of depguard, let's disable it as advised in https://github.com/Kong/kubernetes-testing-framework/pull/693#issuecomment-1573662370. It unblocks PRs:

https://github.com/Kong/kubernetes-testing-framework/pull/693
https://github.com/Kong/kubernetes-testing-framework/pull/694
https://github.com/Kong/kubernetes-testing-framework/pull/695

Codecov Report
Patch coverage has no change and project coverage change: -5.82 :warning:

Comparison is base (ca03c8e) 59.81% compared to head (5cdc517) 54.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   59.81%   54.00%   -5.82%
==========================================
  Files          43       43
  Lines        3474     3474
==========================================
- Hits         2078     1876     -202
- Misses       1127     1353     +226
+ Partials      269      245      -24

Flag
Coverage Δ

integration-test
54.00% <ø> (-5.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Doc Feedback: Use of the word 'API' in simple letters.

The abbreviation 'API' has been written as 'api' in many places in the APIM docs. Two such places are given below.
Location : https://apim.docs.wso2.com/en/latest/WIP/configuring-api-security-audit/
Top most topic..
See the first note (same repeated) - https://apim.docs.wso2.com/en/latest/Learn/Analytics/AnalyzingAPIMStatisticsWithBatchAnalytics/viewing-api-statistics/

Fixed in https://github.com/wso2/docs-apim/pull/707


easy: ci tests for Move external crates

Description
Adds a CI step for test of Move crates in our new external crates.
Test Plan
CI tests

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Can we land this yeti?


Adds a landing page

Overview
This pull request adds a landing page to the website which looks like this:

Issue it closes
Closes #10

This looks amazing!


[Event Change] Table 38 "Purchase Header" - procedure SendRecords()

------------------ Change IntegrationEvent Attribute ----------------------
IncludeSender : true, GlobalVarAccess : true
-------------------------------------------------------------------------------

[IntegrationEvent(TRUE, TRUE)]
local procedure OnBeforeSendRecords(var PurchaseHeader: Record "Purchase Header")
begin
end;

GlobalVarAccess was deprecated in 16.x, there is concept of protected var instead. You can list here the global vars that have to be protected and accessible from extensions.
Please put the code surrounding the place, where you expect a new event call, as a text not as a screenshot.
It helps us finding the right place quickly if you put enough code to identify the unique place.


arch/arm64: mem barrier interface Align with riscv

arch/arm64: mem barrier interface Align with riscv
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

[Experimental Bot, please feedback here]
This PR does not fully meet the NuttX requirements yet.  While it provides a summary and mentions impact and testing, it lacks crucial details.  Here's a breakdown:
Missing/Insufficient Information:

Summary: While the title gives a general idea, the summary needs more detail.  It should explain why aligning the memory barrier interface with RISC-V is necessary.  What problem does it solve? What are the benefits? Is this a bug fix, a performance improvement, or something else?  It also lacks any mention of related issues.
Impact: The placeholder text remains. The author must fill out this section with specifics.  Even if the answer is "NO" for each item, it should explicitly state that.  For example, "Impact on user: NO".  If there is an impact,  it needs a description.  For instance, if the change affects driver code, explain how.
Testing:  The placeholder text remains. This section is critical.  The author needs to provide concrete details about their testing environment (host OS, compiler version, target architecture, board, configuration) and include actual logs from before and after the change to demonstrate the impact and verify the fix/improvement.  Simply saying "works as intended" is not sufficient.

To make this PR compliant, the author needs to:

Expand the Summary:  Provide a detailed explanation of the change's purpose and rationale. Include links to any related issues.
Complete the Impact Section:  Address each point specifically, even if the answer is "NO". Provide detailed explanations for any "YES" answers.
Provide Thorough Testing Information:  Specify the host and target environments used for testing and include actual logs demonstrating the behavior before and after the change.

By providing this missing information, the PR will meet the NuttX requirements and enable reviewers to effectively evaluate the proposed changes.

I don't agree with this change. ISB, DMB and DSB are well documented ARM/ARM64 instructions, so the naming is coherent already.
If you insist, you can remove the ARM64_ prefix, but even that is unnecessary IMO, as it would require updating all downstream code as well for no benefit.
Can you explain what is the motivation for this change? Why must we use similar names to RISC-V in arch specific code?

If you want to share the same driver around the different arch, it's important to keep this basic operation same around all arch.

I don't agree with this change. ISB, DMB and DSB are well documented ARM/ARM64 instructions, so the naming is coherent already.
If you insist, you can remove the ARM64_ prefix, but even that is unnecessary IMO, as it would require updating all downstream code as well for no benefit.
Can you explain what is the motivation for this change? Why must we use similar names to RISC-V in arch specific code?

If you want to share the same driver around the different arch, it's important to keep this basic operation same around all arch.

If a common set of barrier macros are needed in the common kernel drivers, then you can define a common set of macros that the arch specific macros are forwarded to, instead of renaming the existing ones.

I don't agree with this change. ISB, DMB and DSB are well documented ARM/ARM64 instructions, so the naming is coherent already.
If you insist, you can remove the ARM64_ prefix, but even that is unnecessary IMO, as it would require updating all downstream code as well for no benefit.
Can you explain what is the motivation for this change? Why must we use similar names to RISC-V in arch specific code?

If you want to share the same driver around the different arch, it's important to keep this basic operation same around all arch.

If a common set of barrier macros are needed in the common kernel drivers, then you can define a common set of macros that the arch specific macros are forwarded to, instead of renaming the existing ones.

Why do you insist keep two set of macros (__DSB and ARM64_DSB/RISCV_DSB) which has the same functionality?  developers may randomly select one to use, which just make the confusion and inconsistence.

I don't agree with this change. ISB, DMB and DSB are well documented ARM/ARM64 instructions, so the naming is coherent already.
If you insist, you can remove the ARM64_ prefix, but even that is unnecessary IMO, as it would require updating all downstream code as well for no benefit.
Can you explain what is the motivation for this change? Why must we use similar names to RISC-V in arch specific code?

If you want to share the same driver around the different arch, it's important to keep this basic operation same around all arch.

If a common set of barrier macros are needed in the common kernel drivers, then you can define a common set of macros that the arch specific macros are forwarded to, instead of renaming the existing ones.

Why do you insist keep two set of macros (__DSB and ARM64_DSB/RISCV_DSB) which has the same functionality? developers may randomly select one to use, which just make the confusion and inconsistence.

Because ISB, DMB and DSB are arch specific instructions. The barrier macro names (DMB and ISB) are poorly chosen for risc-v as it does not have these instructions (fence with params is used instead).
I think in arch specific code it is fine to use ISB DSB and DMB because like I said they are well documented ARM/ARM64 instructions. If generic barrrier macros are needed in the common kernel code, UP_MB and such is better like you said.
If you insist we remove the arch specific macros then go ahead but I don't see the confusion, as they are macros for well known ARM instructions


Support allow-prereleases from Poetry

Required Information
Using dephell 0.7.8 with Python 3.7.5
Description
Performing any dephell command with a pyproject.toml which contains an "allow-prereleases" tag (e.g. black = {allow-prereleases = true, version = ">19"}) strips that tag from the pyproject.toml.
Poetry is deprecating the older "allows-prereleases" in favor of "allow-prereleases" for consistency, so Black will have to support the new field.

The report was reproduced.
Suppose that pyproject.toml looks like this.
[tool.poetry.dependencies]
python = "^3.7"

[tool.poetry.dev-dependencies]
black = {version = ">19", allow-prereleases = true}

After exec dephell deps add --from=pyproject.toml black, pyproject.toml will be following.
[tool.poetry.dependencies]
python = "==3.*,>=3.7.0"
black = ">19"

If it has "allows-prereleases" key, dephell won't remove the key.
BTW: tool.poetry.dev-dependencies is removed even though black is located in the dev-dependencies section. Is it another issue?

Fixed in #323