new interaction file PMID:19111658

I made a file of physical interactions for PMID:19111658, based on the file that worked for #565. I committed it in svn on Friday but the annotations aren't showing up yet (there'll be a pile for swi6 and a few for other genes).
Does the loader do the "load PMID_*_interactions.tab2.txt" thing, analogous to PHAFs and modification data files?
Shout if I should fix anything in the file - it's pombe-embl/external_data/interactions/PMID_19111658_interactions.tab2.txt

I made a file of physical interactions for PMID:19111658,

I've tried loading it locally and it was fine.

Does the loader do the "load PMID_*_interactions.tab2.txt" thing, analogous to PHAFs and modification data files?

Currently it has the file name for PMID:25795664 hard coded.  I'll change it to load anything in that directory that ends with ".tab2.txt"

Cool; thanks. I don't think we'll have nearly as many of these as we do PHAFs, but it doesn't hurt to future-proof.

Looks OK:
https://www.pombase.org/reference/PMID:19111658

yup, thanks!


Feature: re-sampling of the starting point

I think I might have forgotten to add some contribution of the starting point when computing the likelihood function. This needs checking.

More importantly, before merging, the sampler of the starting point needs to be implemented in a non-centrally parametrised way... Closing for now


feat(codebuild): Overide context variables with input values

Hi there @ArtiomTr, hope it's alright I open a PR here.
Since July 7th 2023, AWs can now supports github actions inside their codebuild containers see https://aws.amazon.com/fr/about-aws/whats-new/2023/07/aws-codebuild-github-actions/
But they don't support github actions that relies on context object that comes from github. So I cannot use this (amazing) github action.
Inside codebuild container I can access to these variables, since codebuild can listen github events.
So I would like to be able to use your package, with parameters that I gave to it.
The idea is still to fallback on context if you don't provide those variables.
Happy to discuss more about it :)

Hello @celoprd,
Is this thing urgent? Currently, I have very little time to review this PR, maybe I'll be able to check it out this weekend.

Hello @ArtiomTr thanks for you quick answer, not urgent at all :)

Hello again, this pull request is still in draft. It just to get the idea :). If this can be ok, I will add tests and update documentation

Hello @ArtiomTr , do you know when you'll have some time to check it ? not really the code for now, but some discussions abiut the subject

Hello @celoprd :wave:,
Sorry for late response. I've been thinking about this, and I have few concerns:

First of all, I would like to move all codebuild related options into one. With that, it will be 100% clear why these options are required, and how to use them. Also, this will ensure that if someone wants to configure and run this action under codebuild, they have to specify all of these options.
As stated in section "Limitations of the GitHub action runner in CodeBuild", not only github context is unsupported, but also PR editing is disallowed. I think this action is practically useless without ability to add comments to a PR. However, I believe that with correct token permissions this could be achieved.
I don't have ability to test this. I've never used AWS before, so I am absolutely unfamiliar with it's ecosystem. Can I test this? Do I have to pay to test this? Can tests be automated, so I don't accidentally break things?

Thank you for your patience.


Add GetBans API

Since we have setban and clearbanned api in swagger:
Add /api/Network/GetBans
Returns an array of bans from peers.json in json format.
If I have some time this weekend I'll send a PR for it.

#3764

Closing as @zeptin 's PR has been merged.


Make offsetGridLines behavior consistent and add new offset option to scales

Document says

offsetGridLines
If true, the bars for a particular data point fall between the grid lines. If false, the grid line will go right down the middle of the bars.

However, the current implementation doesn't change the positions of grid lines, and bars stay between the grid lines regardless of whether it is true or false. Instead, only the positions of labels are shifted.
When a chart has mixed data types (e.g. bar and line) and offsetGridLines is false, the grid line goes right down the middle of the bars as the document explains. This seems to me the correct behavior even for non-mixed charts when offsetGridLines is false.
Another problem is that the right most bar is completely hidden (in case of a bar chart) or bars at the both edges are hidden partially (in case of a mixed chart) when offsetGridLines is false. Calculation of the bar width is also incorrect.

In case of time scale charts, offsetGridLines has no effect, and bars are drawn as if it were set to true. It makes more sense to me that the center of a bar is positioned at the time that the data point refers as the default behavior. The behavior of the offsetGridLines option should be consistent across different scales.
The other issue is that the width of bars and padding are calculated based on the number of the ticks. If the number of the samples are fewer or more than the number of the ticks, unnecessary margin or overlaps will appear.

This PR contains the following changes to resolve the issues above.

Detect whether a chart has bars and set chart.hasBar
Deprecate chart.isCombo
Add sampleSize option for scales, which specifies the width for each sample
Add getSampleSize() to scales and the bar width is calculated based on its return value instead of the tick size
Modify getPixelForValue(), getPixelForTick() and buildTicks() in scales to adjust the range of the scale and to make sure that all bars will be displayed
For the consistent behavior, bars are shifted to the left by one half of the sample width so that the grid line goes right down the middle of the bars, then shifted to the right only when offsetGridLines is true
Lines and bubbles are shifted when offsetGridLines is true (not when chart.isCombo is true)
Add tests

sampleSize is specified not in pixels or in a ratio to the tick size, but in the scale-dependent unit. For example, the format for moment.duration() is used for time scale. In this way, the chart will be able to support responsive designs and zooming.
The following images compare the current version (on the left) and the proposed version (on the right).

Below are charts with time scales.

Below are charts with time scales with sampleSize option.

Below are examples of line-only charts and horizontal bar charts.

This PR fixes the following open issues.
Time scale bar charts overlap #2323
This PR solves the overlap issue, and also aligns the time and the center of bars.
Bars on time axes are poorly positioned and sized #2415
This seems the same problem as #2323. Not sure if this fixes the issue because there is no fiddle or screenshot, though.
Chaning the width of bars with datetime x-axis? #3263
The width of bars can be changed using sampleSize added with this PR.
Time scale bugs in bar and line charts type #3297
The missing bar problem is discussed in #3297. This happens because the last bar is beyond the right limit, and this PR fixes it.
time in x axis displayed incorrectly #3613
This seems the same problem as #3297. This PR solves the issue that array gets left shifted with one value.
Ticks for bar charts of type time are not centered #3682
Now, the ticks, the grid lines and the center of bars are all aligned when offsetGridLines is false.
[BUG] bar charts scales are inconsistent when type: 'time' and unit: 'week' OR 'month' #3747
This is the overlap issue similar to #2323. This PR fixes it.
Time axis issues #3780
This is also the overlap issue this PR can solve.
Mixed chart layout issue #3913
This PR makes sure a bar no longer overlap the y axis.
[FEATURE] option to center line labels and points between grid lines on the x axis like in bar charts #4051
This can be achieved by setting offsetGridLines to true with this PR.
[SUPPORT/FEATURE] Display the data points in a bar-chart as a time period (from-to, eg. for energy consumption) #4343
As discussed in #4343, if each bar represents the same amount of time then this PR will work well.
Line Bar Points not matching Bar Chart width #4471
Similar to #3682. Now, the ticks, the grid lines and the center of bars are all aligned when offsetGridLines is false.
[BUG] Scaling of time axes on bar charts #4560
This seems the same problem as #3297 and #3613. This PR fixes it.

@nagix thanks for the incredibly detailed PR notes. I will try and look at the code soon.

Below are the time scale charts with gridLines.offsetGridLines = true, tick.mode = linear | series and tick.source = auto | labels. It looks ok now. There are overlaps when gridLines.offsetGridLines is false, but that problem cannot be solved when tick time and sample time are not aligned, and the fixed sample size (sampleSize option) should be used in that case.

@nagix looks like there's still a rebase needed

Just resolved conflicts.

I think there's a bug here with mode: series and offsetGridLines: false. See the screenshot below. It causes the bars to be different widths.

I tested with an updated version of the financial chart pointed at a locally built version of chart.js with npm link: https://github.com/chartjs/chartjs-chart-financial/tree/chartjs-2.7
I sent a PR to add a similar sample to this repo https://github.com/chartjs/Chart.js/pull/4554. I was hoping it would be helpful to you in debugging, but it doesn't seem to work when I change type: 'line' to type: 'bar'

@nagix I want to thank you for the truly awesome description and all the time you've put into fixing this issue
I think there's one main issue, which is that it's making many other classes aware of the bar chart when they shouldn't need to know about the bar chart. It would be preferable to keep the fix contained within the bar chart as much as possible. If the bar chart looks at the ticks of the axis hopefully it should be possible to calculate the bounds of the bar

@benmccann Thanks for reviewing this, and I understand your concern. To make it simpler, how about the following idea?

Don't use sampleSize option
The default bar size is the size of the tick interval that the data sample is on

In case of a category scale, it will be a fixed size. In case of a time scale, it will depend on the tick configuration

When detecting overlap with the next bars, recalculate the size individually so that they fit each other

That sounds reasonable to me. @simonbrunel thoughts?
Simon and I were talking about the one point below

The default bar size is the size of the tick interval that the data

I think we came to the conclusion that it might be nice to have an option that switches this between two modes. One is the mode you mentioned. The other is a mode where you force the bars to be equally sized (the size of the closest two ticks). Here's a use case for what I'm talking about: imagine you're plotting a daily stock with a bar chart. You set mode:linear. I think you would want five equally sized bars with a space for the weekend followed by five equally sized bars for the next week. In this case it would be strange if the bars for Monday and Friday were much bigger than the bars for Tue, Wed, Thurs

Here's a sample that can be used to reproduce the bug I mentioned above when mode: series and offsetGridLines: false: https://raw.githubusercontent.com/benmccann/Chart.js/offsetGridlineExample/samples/scales/time/financial.html

Also, I haven't tested with your PR, but currently on master, if you try to plot a bar on a time scale, there's one point that doesn't get plotted (I'm not sure if it's the first or the last). That might be something else we want to test for

@nagix the latest commits from master are showing up in your PR now for some reason. I think you'll need to rebase

I have changed the code so that the bar controller and the scales don't depend on each other as much as possible. Now bar controller calculates the bar width based on the return value of the getPixelForValue function.

Remove sampleSize option
Calculate the grid line offset based on the minimum interval between samples
Add code to support ticks.mode and ticks.source option in the time scale
Modify the interpolation table to support lookup for tick indexes
Adjust the range of scales so that all bars can be displayed

@benmccann The issue you reported has been fixed. Also, the last bar is plotted on a time scale, which was reported in #3297.

@nagix can you squash and rebase?

Thanks @nagix for this awesome work. I think there is still one (implementation) issue, can you post a screenshot of bars on a time scale with mode: 'linear', source: 'labels', with labels at irregular times:

@nagix will you be able to squash and rebase to get the latest commits from master to stop showing up in your PR? i'm very excited for this improvement to make its way in!

@nagix thanks again for this PR! is there anything we can do to help you figure out the rebase process?

Sorry for the late response. I did squash and rebase to the latest master.
I have also added several tests to the time scale, category scale and bar controller to cover the ticks.offset, barThickness and maxBarThickness options.
When barThickness is not specified, the bar width will be sized based on the minimum interval between bars in the chart to avoid overlaps, and all bars will have the same width. When 'max' is set to barThickness, the bar width will be maximized individually, and each bar can have a different width.

Thanks @nagix!  There are some great changes here!

Checking in here thanks to @etimberg. Amazing PR! Could you kindly share any fiddle that shows a combined bar/line chart, preferably with lines using x/y notation instead of labels?

I have updated the code based on the discussion with @simonbrunel. I removed barThickness: 'max' option, and the bars are sized automatically so that they take available widths without overlap by default.

@andig Does this help for you?
https://jsfiddle.net/nagix/657fxL8r/

@nagix might be good to update/simplify the PR description to keep it synced with the new implementation? Also, if you can list tickets for sure fixed by this PR at the end of the description, like in this PR (with Fixes #.... prefix), then tickets will be automatically closed as soon as this PR will be merged.

@nagix I've experimented somewhat with this PR and must say that I'm delighted. One thing I've noticed is that when I set scale.time.unit: 'day' I will still get gridlines at each x days at certain zoom levels. That is of course confusing. How should gridline spacing for bar charts over time series be handled- separate issue?

@andig For your first question, time.unitStepSize: 1 will solve the problem. For your second question, gridLines.offsetGridLines: true is the solution with this PR if the tick interval is 1 day, and data points are at 00:00 every day. This option is set to true for a category scale but false for a time scale by default.

@nagix thanks for your feedback!

time.unitStepSize: 1 will solve the problem.

That has become stepSize now? Will check. Unfortunately overshadowed by https://github.com/chartjs/Chart.js/issues/4635 for me.

For your second question, gridLines.offsetGridLines: true is the solution with this PR if the tick interval is 1 day, and data points are at 00:00 every day. This option is set to true for a category scale but false for a time scale by default.

Right. Unfortunately that is not sufficient for combines line/bar charts for physical units. If you think about electrical power (W) and daily consumption (Wh) it only makes sense to draw the bar (and the associated label) in the middle of the day. Otherwise the bar for daily consumption will overlap 2 days if plotted at 00:00 hours.
But that sounds like a separate issue that is not part of this PR. Thanks!

@simonbrunel For #3747, this PR fixes a bar overlap issue as follows, but if it expects all bars to have one day width, it needs to wait for barThickness: 'min' or similar option as we discussed.
https://jsfiddle.net/nagix/vs8jve63/
https://jsfiddle.net/nagix/uLkn5jjc/
The same is true for #3780. If it expects the same bar width, this PR doesn't completely fix it. I removed these ticket numbers from the PR description just in case.
https://jsfiddle.net/nagix/53oejjav/1/
It fixes #3579 as you suggest.

@andig You are right, time.unitStepSize was replaced with time.stepSize. I understand that gridLines.offsetGridLines doesn't fix your problem because lines and grid lines have to stay but bars and labels need to be shifted. How about moving bars by adding 12 hours and shifting labels by labelOffset option?

@nagix is this PR ready to be merged?

@simonbrunel Yes, it is ready.

Woo! This is great! Thanks so much @nagix!
Will you be submitting a PR to add barThickness: 'min' next?

yay! Thank you!  Do you think this would warrant a new release?

@nagix
Just wanted to confirm if all the fixes done as part of this PR are available in chart.js release. We are using version 2.6.0 and that does not contain these fixes.
By when these fixes will be available ?
Thanks

@myadav-etindia this PR is in the master branch and will probably released with 2.7.0. See http://www.chartjs.org/docs/master/developers/ for how to get access to the development releases (= master branch).

@andig
Thanks. Got the latest.

@andig
Tentatively by when would the chart.js 2.7.0 release be available ?

@myadav-etindia I wouldn't know really- it's a question for the maintainers. My feeling is though that there is still a lot of movement that would not warrant a realease in the near future. You could still use a snapshot of the current master right now.

My team previously extended elements.rectangle because the existing Rectangle element assumed that the 'x' was the central point whose x1 and x2 were calculated dividing the width by 2. Our extended element assumes that x is the start and x + width = x2. I'll need to check this out to see if this is even needed anymore but I'm assuming it's not which would be a huge boon for us.

I was really pleased with the work done here, but one thing I'm confused about is the intention of how this handles time series line charts.
I have daily data that I'd like to present with labels grouped and labeled by month. That is, the gridLine should appear at the first of the month, but I'd expect the tick label (say "Sep" or "Jan") should appear centered between the two. It seems like with offsetGridLines: true, it appears visually the way one would expect, but the gridlines correspond to the halfway point in the month.
This fiddle illustrates what I mean: https://jsfiddle.net/y152r1nh/4/
Hovering over the point on the line before the label "Jan" gives me dates for "December 15". Am I misunderstanding how to use this feature, or is that an oversight?

This feature is moving the gridlines for bar charts. I.e. if you're drawing a bar chart and don't want the grid line through the middle of the bar then move the gridlines over. What's you're asking for is a feature probably more like offsetLabels: true

@benmccann Thanks. So that just plain doesn't exist, huh? I guess I'll look into how to implement such a thing.

@nagix What if you have an interval of days? for example: from day 20 to day 23. When setting the values, the bar graph distorts.


Error during compiling

I'm receiving the following error when compiling a program which uses the ADS1X15.h file:
Compilation error: call to 'bool Adafruit_ADS1X15::begin(uint8_t, TwoWire*)' uses the default argument for parameter 1, which is not yet defined
Specifically it is coming in twice as follows:
In file included from G:\My Drive\My Documents\3D Print Files\Analyzer\files\o2_analyzer\o2_analyzer.ino:25:0:
C:\Users\bridg\OneDrive\Documents\Arduino\libraries\Adafruit_ADS1015/Adafruit_ADS1015.h:157:31: error: expected primary-expression at end of input
bool begin(uint8_t i2c_addr = ADS1X15_ADDRESS, TwoWire wire = &Wire);
^
G:\My Drive\My Documents\3D Print Files\Analyzer\files\o2_analyzer\o2_analyzer.ino: In function 'void setup()':
G:\My Drive\My Documents\3D Print Files\Analyzer\files\o2_analyzer\o2_analyzer.ino:98:13: error: call to 'bool Adafruit_ADS1X15::begin(uint8_t, TwoWire)' uses the default argument for parameter 1, which is not yet defined
ads.begin(); // ads1115 start
^
exit status 1
Can anyone explain how I can resolve this error (I'm very new, sorry if this is an easy fix I just don't know how to do yet)?
Thank you.

o2_analyzer.txt

Thanks for opening this issue. I will come back to it later today.

Compilation error: call to 'bool Adafruit_ADS1X15::begin(uint8_t, TwoWire*)' uses the default argument for parameter 1, which is not yet defined

Apparently the compiler is using theAdafruit library and not mine.
Assuming you are using the Arduino IDE, you must got to the menu FILE->Preferences
You must set the verbose option for compilation and uploading.

In the output of the compilation you can see which library is used.
To force the use of a specific library move the other (conflicting) libraries "out of sight" of the compiler.
So move it from the libraries folder to  "other_libraries" folder.

If it is your intend to use the Adafruit library, you should open an issue in that repo (or on the Arduino Forum), as then it is not a problem of this library.
Note: Both AdaFruit and I have a library for this ADS1115 and although functional similar they do not share a compatible interface.

@jlcnuke
As there is no further information I assume the issue does not relate to this library and will be closed.


Master Review Ticket: Variant Analysis, Exome sequencing data analysis

Topic: Variant Analysis, Title: Exome sequencing data analysis
Tutorial Link
Component: Hands-on
Contribution: Language simplification & grammar, Methods & Materials
Testing at Galaxy EU
Test history
Issues Found
Tutorial Agenda Item#2: Variant Calling
Hands-on: Annotating Variants
Step 3: Annotate your variants with some functional information

Details: Unable to use downloaded genome from SnpEff or when using locally installed genome (native index) Genome hg19.
SnpEff tool version not mentioned in tutorial: ADD
EU has what looks like older tool version: SnpEff Variant effect and annotation (Galaxy Version 4.3r.1)
Most current version in MTS: 4.3+T.galaxy1
MTS Link
Open issues for tool v4.3+T.galaxy1: #1787

Testing at Galaxy Main
Test history
Issues Found
Tutorial Agenda Item# 1 Data-preprocessing:
Hands-on: Data pre-processing
Step 3 Import the reference genome:

Details: Reference genome in tutorial not in shared library. Downloaded genome from from EU and imported to ensure it was the correct file. File is here.

Tutorial Agenda Item# 3 Post-processing:
Hands-on: Post-processing
Step 1 Use the tool GEMINI load in Gemini to create a database out of our combined VCF file and the PED file

Details: Error when attempting to run Gemini load during the tutorial

Error Message Link

Fatal error: Exit code 1 ()
CADD scores are not being loaded because the annotation file could not be found.
Run gemini update --dataonly --extra cadd_score to install the annotation file.
GERP per bp is not being loaded because the annotation file could not be found.
Run gemini update --dataonly --extra gerp_bp to install the annotation file.
Gemini cannot open this annotation file: /galaxy/main/deps/gemini/0.18.1/iuc/package_gemini_0_18_1/49de32b47548/gemini_data/hg19.gwas.bed.gz.
Have you installed the annotation files?  If so, have they been moved or deleted? Exiting...
For more details:
http://gemini.readthedocs.org/en/latest/content/#installation.html\#installing-annotation-files
WARNING:galaxy.datatypes.binary:<galaxy.datatypes.binary.GeminiSQLite object at 0x2b46c9d68390>, set_meta Exception: no such table: version

Testing at Galaxy AU
Test History
Issues Found
Tutorial Agenda Item# 1 Data-preprocessing:
Hands-on: Data pre-processing
Step 3 Import the reference genome:

Details: Reference genome in tutorial not in shared library. Downloaded genome from from EU and imported to ensure it was the correct file. File is here.

Tutorial Agenda Item# 2 Variant Calling:
Hands-on: Generating FreeBayes calls
Step 3 Run FreeBayes

Details: Able to select options and run FreeBayes but returns with error.
Error Message Link

Fatal error: Exit code 93()
index file /cvmfs/data.galaxyproject.org/byhand/hg19/seq/hg19.fa.fai not found, generating...
could not open index file /cvmfs/data.galaxyproject.org/byhand/hg19/seq/hg19.fa.fai for writing!
index file /cvmfs/data.galaxyproject.org/byhand/hg19/seq/hg19.fa.fai not found, generating...

@bgruening @bebatut just working through the exome-seq tutorial in preparation of a course tomorrow and found one additional issue:
The dbSNP file at https://zenodo.org/record/60520/files/dbSNP_138.hg19.vcf does not seem to have any SNP ids. Could it be that the wrong file got uploaded to zenodo? To me it looks as if it contains the variants called from the RS024M-MOTHER sample.

Hey @wm75 can you check if this is still an issue?

These issues are all about the previous version of the tutorial and have been addressed in its rewrite.


[HOTFIX] [ZEPPELIN-1863] Travis Selenium CI fail

What is this PR for?
Currently, the Selenium CI test of Travis regarding every PR is failing.
I think because it is after merging #1777 PR.
Here is error log.
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[2]//div[@class=\"control ng-scope\"]//ul[@class=\"dropdown-menu\"]/li[1]"}

Results :
Tests in error:
  ZeppelinIT.testAngularRunParagraph:291 » NoSuchElement Unable to locate elemen...

What type of PR is it?
[Bug Fix | Hot Fix]
Todos

[x] fix code regarding this problem

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1863
How should this be tested?

None

Screenshots (if appropriate)

None

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@soralee CI is green now. Thanks for the quick fix!
Merge into master as a hotfix.


split_words == true as default?

Would it make sense to have split_words equal to true as the default? Assuming environment variable names whose parts are split (e.g., MONGO_URI, SERVER_PORT) may be more readable.
Unless there is a reason this does not make sense as the default, I would be happy to submit a corresponding PR.
What do you think?

Or perhaps a new ProcessX function that takes options? One of the options being to split_words for all fields?

@markphelps and maybe the current prefix could also be consumed as an option in the ProcessX function. Looks nice! Except there will now be potentially two methods to do the same thing...
@kelseyhightower what do you think about this?

This possibly would have been a better call from the beginning, but I don't think it's a good enough reason to break backwards compatibility.


New Extension: Invoicing

This extension allows users to create "traditional" invoices (not in the lightning sense) that contain one or more line items. Line items are denominated in a user-configurable fiat currency. Each invoice contains one or more payments up to the total of the invoice. Each invoice creates a public link that can be shared with a customer that they can use to (partially or in full) pay the invoice.

Open to feedback on this with regards to available features, etc, while in draft PR mode!
Todo:

[x] Make sure to rebase to main
[x] Run make format
[x] Write tests
[x] Add migrations for new extensions to tools/conv.py
[x] Write README.md for extension

This is awesome! Congrats!
It would be cool to have a printable version of the invoice, for the merchant, probably needed for accounting.

That makes sense. I've now pushed an update to the extension that has @media print CSS rules, and a print button next to the share button. I've attached a sample.
invoice.pdf

Not adding any tax and discount input?

Great PR! Couple comments:

I have done an unsolicited Edit of your top post with a checklist of things to do before a merge.

As you  might have noticed, we have tests now! With this PR, there is a postgres test that's failing.
psycopg2.errors.UndefinedObject: type "invoice_status_type" does not exist context: ERROR at setup of test_core_views_generic

Could you also a couple of tests for this extension specifically? We don't have many extension tests yet, but it would be great to test at least the API and some expected responses.

Let me know if you need any help. This pipeline is new territory for LNbits but it will make life a lot easier in the future!

Is there a guide to making these tests? I notice there has been a pause here. Tests are important of course, but we dont want to discourage people making extensions by creating too much complexity. If tests are some extensions are expected to have an example is needed first.

I wouldn't say it's expected but definitely encouraged as a best practice. Most extensions don't have tests. There is no guide yet but i could write one in the dev docs.
For now, the existing tests should serve as a basic example. It's quite easy really. The simplest thing to do is to call the API endpoints and see if you get what you expect. More testing is always possible.

Would be nice if we can add a predefine items into the extension..... who is going to type items each and every time. I got a restaurant with lots of items, if I can select those items quickly when creating invoice, thats better.

Would be nice if we can add a predefine items(with price) into the extension..... who is going to type items each and every time. I got a restaurant with lots of items, if I can select those items quickly when creating invoice, thats better.

I get your point, but that would make a full fledged Point of Sale software... I see it like, the merchant has already a PoS system/software running, where he makes the entries of products! He could then enter a pointer to the invoice generated on the PoS, a number or something!
What you describe would have merchants, adding products to the DB!

Hi @leesalminen , I'm trying to make this pass checks, and maybe tweak it a litlle bit, if that's ok! Can i rename this to accounting, instead of invoices ?

woohooo!! only tests missing!!
@callebtc will take bleskomat as guide but, i'll bug you if i need insight...

@leesalminen could you write the README for this extension?

@leesalminen could you write the README for this extension?
Also, what's the reason for having the invoice created as draft as default? even I set it to be open on creation, i need to go and update it by hand to change status to open! can I change this behaviour?

Also, what's the reason for having the invoice created as draft as default? even I set it to be open on creation, i need to go and update it by hand to change status to open! can I change this behaviour?

I've just pushed a fix for this bug. Had to set a specific property in models.py

@leesalminen could you write the README for this extension?

Just pushed up a readme.

Great extension! I was just playing with it and found that this happens when you enter a fiat value smaller than 0.01

Great job! LGTM. Merging after all checks are green.

Found a little issue with the mobile layout. Can it be adjusted for smaller screens? I guess that's also something we could do better in LNbits generally.

Found a little issue with the mobile layout. Can it be adjusted for smaller screens? I guess that's also something we could do better in LNbits generally.

See https://github.com/lnbits/lnbits-legend/pull/874


Outline verification incorrect

Describe the bug
With small PCB's, the outline verification is incorrect and causes the panelised output to have no edgecuts whatsoever.
as you can see in the screenshots, the layout validation is a fraction of the size of the PCB.
To Reproduce
Steps to reproduce the behavior:
import gerbers, set JLC type, set panel to 8x5 (breaks even at 2x1)
Expected behavior
A panelised PCB to be created
Screenshots

Desktop (please complete the following information):

OS: Linux

Hi,
wanted to use this project to panelize files from eagle. But i think i have found the same problem :)

PCB verification outline is scaled a bit, and wont align with PCB.
gerbv rendering is correct. I dont know where is the problem. Maybe some hints on where to look in the code ? Same output is from pcb-tools, so i think the underlying project might be the problem.

Hi,
I dont know if this is relevant to @jamosaur , but here is fix for "my" problem.
diff --git a/Pcb.py b/Pcb.py
index b4d5c81..709e5da 100644
--- a/Pcb.py
+++ b/Pcb.py
@@ -77,7 +77,7 @@ class PcbPrimitive:

 class PcbOutline:

-    def __init__(self, path, size, verbose=False):
+    def __init__(self, path, size, verbose=True):

         self._valid = True

@@ -137,7 +137,7 @@ class PcbOutline:
                         good = y_delta == 0.0
                         self._horizontal.append(PcbPrimitive(line, edge, good))

-            self._scale = size / max(self._max_x, self._max_y)
+            self._scale = size / max(self._max_x-self._min_x, self._max_y-self._min_y)
         else:
             self._min_x = 0.0
             self._min_y = 0.0

My gerber's origin is not at 0,0 but slightly offset. The max_x and max_y needs to be offset by this _min_x/y otherwise the scale will get scewed.


eq_op base implementation

eq_op base implementation
Is not completed. I still have work to do.
Changes

I added a new file for the eq_op lint.
I created the comparison directory for the eq_op tests.
I added some tests to see the behaviour of the code that I have.
I added the lint in the plugin.rs file.

I'm stuck trying to figure out how to detect when there is an expression that is calling functions or methods. If you check the tests, there is a test where I'm calling a function in an expression test.get(). For the diagnostic, it should ignore it, but I dont know how to detect something like that in the code, so that there is no diagnostic for these kind of situations. Dont know if somebody can bring some light to this.

Is weird that my commit says that I changed the bool_comparision tests when I did not. I think I have to be on a commit before right? @0xLucqs

any news ?

I have not been spending time in it. I dont know if Im gonna be able to solve it.

Ok i'll be able to provide more help next week

I would like to take over this one

I wanted to solve other issues that I had that I knew that are easier than this one xD


Question: Doctrine columns order

This is a question rather than an issue, something that's been bugging me for a while. Long story short, every time I setup a fresh Symfony project and create entities/tables, when I add relation columns like User and such, the order will be something like:
id|title|description|user_id
And then I have to edit the entity to arrange the order and then drop the table and make another migration to maintain the order I want. With this demo, somehow this is magically solved. Any entity/table created always arranges the id fields in the proper order.
So the above results in:
id|user_id|title|description
I do not need to edit the entity and re-arrange variables and functions, I can just add on relations because it will be properly ordered.
How and why? Is there some settings/package or something?
Please advise.

Hello.
This is the issue tracker for the Symfony Demo application and not a public support forum. Please post your question either on StackOverflow or one of these discussion boards.

https://github.com/symfony/symfony/discussions/
https://github.com/doctrine/orm/discussions/


[SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype

What changes were proposed in this pull request?
This is a backport of #23575
When parsing datatypes from the json internal representation, PySpark doesn't support decimals with negative scales. Since they are allowed and can actually happen, PySpark should be able to successfully parse them.
How was this patch tested?
added test

Test build #131800 has started for PR 30503 at commit 1f1592e.

Test build #131800 has finished for PR 30503 at commit 1f1592e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

There was a community request at SPARK-33445 and SPARK-26645 for backporting this to branch-2.4.
Since Apache Spark 2.4.x is LTS, it would be great if we can have this.
cc @HyukjinKwon , @BryanCutler , @srowen , @viirya

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131800/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36399/

Thank you, @viirya !
Merged to branch-2.4.

Nice, thanks @dongjoon-hyun and @viirya.


access<EMAIL_ADDRESS>(github)

See https://golang.org/wiki/GithubAccess
https://github.com/orgs/golang/teams/go-assignees
and
https://github.com/orgs/golang/teams/go-approvers
I'm joing the go-cloud team and am following http://g3doc/company/teams/go/community/#github.
If only go-assignees is more appropriate for now, that's fine.

I am using github fine without this, so closing.


Explicitly ignore return value in consoleLogHandler() from writev()

Fixes the following build error:
logging/source/RialtoLogging.cpp:113:34:
error: ignoring return value of 'ssize_t writev(int, const iovec*, int)',
declared with attribute warn_unused_result [-Werror=unused-result]
writev(STDERR_FILENO, iov, 5);
^
cc1plus: all warnings being treated as errors
Signed-off-by: Damian Wrobel<EMAIL_ADDRESS>--
Summary: Explicitly ignore return value in consoleLogHandler() from writev()
Type: fix
Owner: Damian Wrobel
Test Plan: None
Dependencies and Impacts: None

https://jenkins.code.rdkcentral.com/job/github-triggered/23381/ started

https://jenkins.code.rdkcentral.com/job/build-component/58638/ started.

build-rpi-mc-wpe-dunfell Console Log uploaded to Gist URL: https://gist.github.com/b015a35a5745c24bb3dd52e12549f48d

build-rpi-hybrid-wpe-dunfell Console Log uploaded to Gist URL: https://gist.github.com/fe021f1697e48b57d3f59c7a21321f59

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/16821/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/28578/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/24191/ started

https://jenkins.code.rdkcentral.com/job/build-component/59917/ started.

build-brcm-refboard Console Log uploaded to Gist URL: https://gist.github.com/ce55ac74df70be7d472a696b42721590

build-brcm-va Console Log uploaded to Gist URL: https://gist.github.com/4f32cbf0ce480058089d565089830a9f

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130203/

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/130202/


Converting postgres date property to js value converts it to a date instead of string

Describe the bug
Since version 5.7.0 of mikro-orm the behaviour of fetching at property with postgres column type "date" changed.
The postgres date type is stored as a string in the format "yyyy-mm-dd" in the database.
It was parsed as a string by mikro-orm up until v 5.6.16. But now it is parsed as a js Date object. I could not find something related to that change in the release notes.
I have a custom type i'm using to convert the db value to a js object of CalendarDate:
import { EntityProperty, ValidationError, Platform, Type } from '@mikro-orm/core';
import { CalendarDate } from 'calendar-date';

export class CalendarDateType extends Type<CalendarDate, string> {
  convertToDatabaseValue(value: CalendarDate | string | undefined | null): string {
    if (value instanceof CalendarDate) {
      return value.toString();
    }

    if (!value || value.toString().match(/^\d{4}-\d{2}-\d{2}$/)) {
      return value as string;
    }

    throw ValidationError.invalidType(CalendarDateType, value, 'JS');
  }

  convertToJSValue(value: CalendarDate | string | null | undefined): CalendarDate {
    if (!value || value instanceof CalendarDate) {
      return value as CalendarDate;
    }
    return new CalendarDate(value);
  }

  compareAsType(): string {
    return 'date';
  }

  getColumnType(prop: EntityProperty, platform: Platform): string {
    return platform.getDateTypeDeclarationSQL(prop.length);
  }

  toJSON(value: CalendarDate): CalendarDate | string {
    return this.convertToDatabaseValue(value);
  }
}

In the convertToJSValue function the value was always a string but is a js date object now. Is that intended? Of course i can work with that and convert the date to the string i need, but the whole point of storing the date without time information in the DB, is to not deal with conversion of dates in different timezones.
Versions

Dependency
Version

node
18

typescript
5.04

mikro-orm
5.7.2

I need to see a complete reproduction for such issues, this is most probably not about your type implementation, rather about the value returned from database being saved in the entity snapshot wrongly.

One of the things that changed in postgres is that the type overrides are now scoped only to the ORM instance of the postgres client, before it was altered globally.
https://github.com/mikro-orm/mikro-orm/commit/5594c469f05d2c1fc76f3cc1a388f5e7162f4e72#diff-845d1587d2aabfa92fa22ab79ebb2eeaaed044eb22a3c4aa5f592500693d420cR19
As by default it is the postgres client that convers the string to date object, if its done by MikroORM, it would have to be your code (the mapped type implementation) most probably.

Thanks for the quick reply! I added a minimal reproduction here:
https://github.com/co-sic/node-mikro-orm-playground
This is working as it is, but if you change the mikro orm version to >=5.7.0, it will produce an error.

Ok, no need for repro, it's caused by that change I mentioned above, apparently, the local overrides are not taken into account, when I switch back to the global overrides it works fine.
So for now a workaround could be doing this somewhere, e.g. in your ORM config file:
import { types, defaults } from 'pg';

types.setTypeParser(1082, str => str);

I will try to isolate this more when I have some spare time, sounds like its a bug in the pg library, if so it would be better to report it and let them fix it.

Oh wait, now I see it, I moved the line with types inside the forceUtcTimezone if block!

Thank you for the quick fix, much appreciated! :)


Go Live [Oct 07] (#7185)

Update feed.atom (#7146)

[Doc Improvement][Add sso command bot code snippet for teamsfx sdk][2665913] (#7051)

Add sso command bot code snippet

Fix typo

Update link

docs: add sso for message extension api director

.

.

.

.

.

.

.

coding tag updated

Co-authored-by: turenlong<EMAIL_ADDRESS>Co-authored-by: wenyutang-ms<EMAIL_ADDRESS>Co-authored-by: v-vpaliwal<EMAIL_ADDRESS>Co-authored-by: v-sdhakshina<EMAIL_ADDRESS>Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

[Doc Issue][Describe how to handle status codes from bot APIs][2466522] (#6335)

got issue

Adding status codes

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Adding status codes

minor edits

adding status codes

Adding codes

minor edits

Minor update

minor edits

Status code update

Minor edits

Minor edits

Update conversation-messages.md

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor updates

Minor updates

Update conversation-messages.md

Updates

Update conversation-messages.md

Update conversation-messages.md

Updates

Update conversation-messages.md

Co-authored-by: v-habibaumme<EMAIL_ADDRESS>Co-authored-by: v-npaladugu<EMAIL_ADDRESS>

[Doc Improvement][UI updates on create tab][2668497] (#7145)

updates as per testing

minor edits

minor edits

minor edits

[]Doc Improvement][Update provision in cloud resources][2668619] (#7150)

update-provision-cloud-resources

Interchanged Use an existing Azure AD app for your bot to Use an existing Azure AD app for your Teams app. and
Use an existing Azure AD app for your Teams app to  Use an existing Azure AD app for your bot.

Update provision.md

updated for Visual studio code and Visual studio

Update publish.md

[Doc Improvement][Collaboration control review][2658603] (#7119)

Update collaboration-control.md

Update collaboration-control.md

Update collaboration-control.md

Doc improvement

Update app-with-collaboration-controls.md

Update collaboration-control.md

Update collaboration-control.md

Update collaboration-control.md

Update install-collaboration-control.md

Update install-collaboration-control.md

Update app-with-collaboration-controls.md

Update app-with-collaboration-controls.md

Worked on as per the standards

Update collaboration-control-power-automate.md

Working on editing the content as per the standards
Co-authored-by: v-spharish<EMAIL_ADDRESS>Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

Update submission-checklist.md

[Doc Improvement][Remove deprecated "packageName" value from app manifest schema article][2651838] (#6959)

Updated the article

Edited and removed the occurrence of packageName in the article.

Co-authored-by: v-jganga<EMAIL_ADDRESS>Co-authored-by: v-vpaliwal<EMAIL_ADDRESS>
minor updates (#7169)

Co-authored-by: v-habibaumme<EMAIL_ADDRESS>
Doc improvement (#7166)

Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

[Doc Improvement][Adding space after see Virtual Assistant and skills architecture] (#7178)

Doc improvement

Doc improvement

Doc improvement

Doc improvement

minor changes

[Doc Improvement][Spell check] (#7184)

Spell check

Update removal-page.md

Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

[Doc Improvement][Typo fix tools and SDK] (#7182)

Update build-environments.md

updates

updates

Co-authored-by: Wajeed-msft<EMAIL_ADDRESS>Co-authored-by: rentu<EMAIL_ADDRESS>Co-authored-by: turenlong<EMAIL_ADDRESS>Co-authored-by: wenyutang-ms<EMAIL_ADDRESS>Co-authored-by: v-vpaliwal<EMAIL_ADDRESS>Co-authored-by: v-sdhakshina<EMAIL_ADDRESS>Co-authored-by: v-habibaumme<EMAIL_ADDRESS>Co-authored-by: v-silakshmi<EMAIL_ADDRESS>Co-authored-by: v-npaladugu<EMAIL_ADDRESS>Co-authored-by: v-sdhakshina<EMAIL_ADDRESS>Co-authored-by: v-ypalikila<EMAIL_ADDRESS>Co-authored-by: v-spharish<EMAIL_ADDRESS>Co-authored-by: v-ajiths<EMAIL_ADDRESS>Co-authored-by: v-ksar<EMAIL_ADDRESS>Co-authored-by: v-jganga<EMAIL_ADDRESS>

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/enable-and-configure-your-app-for-teams-meetings.md
96
5
link
:white_check_mark:

msteams-platform/resources/m365-plugins/m365-plugins-overview.md
94
8
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
21
link
:white_check_mark:

msteams-platform/samples/app-templates.md
91
47
link
:white_check_mark:

msteams-platform/samples/app-with-collaboration-controls.md
92
17
link
:white_check_mark:

msteams-platform/samples/virtual-assistant.md
91
15
link
:white_check_mark:

msteams-platform/tabs/how-to/build-adaptive-card-tabs.md
94
6
link
:white_check_mark:

msteams-platform/tabs/how-to/create-personal-tab.md
93
13
link
:white_check_mark:

msteams-platform/tabs/how-to/create-tab-pages/removal-page.md
90
7
link
:white_check_mark:

msteams-platform/tabs/how-to/tabs-in-sharepoint.md
92
5
link
:white_check_mark:

msteams-platform/toolkit/AAD-manifest-customization.md
95
10
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-SDK.md
98
3
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-multi-env.md
98
19
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
92
20
link
:white_check_mark:

msteams-platform/toolkit/add-capability.md
94
6
link
:white_check_mark:

msteams-platform/toolkit/build-environments.md
93
3
link
:white_check_mark:

msteams-platform/toolkit/create-new-project.md
97
6
link
:white_check_mark:

msteams-platform/toolkit/debug-overview.md
95
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


vault-bin: 1.8.1 -> 1.8.2

https://github.com/hashicorp/vault/releases/tag/v1.8.2

Motivation for this change
Bot PR missed vault-bin in the bump.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136211 run on x86_64-linux 1

1 package built:

vault-bin


Fix markdown title in no-raw-text doc

Coverage remained the same at 73.036% when pulling e4629b58dd65f56ca3192b3e4ae63954c6db9330 on ter-informatique:fix-markdown-title into 010856c5551006c4ba164f84c6bcf4696cc294f7 on Intellicode:master.

Coverage remained the same at 73.036% when pulling e4629b58dd65f56ca3192b3e4ae63954c6db9330 on ter-informatique:fix-markdown-title into 010856c5551006c4ba164f84c6bcf4696cc294f7 on Intellicode:master.


LocalSearchDecider should not select NoChangeMove, even with ListVariable(allowsUnassigned=true)

(Credit to @TomCools for finding this one)
Side 1 of the story
In VRP, with @PlanningListVariable(allowsUnassigned=true), a Construction Heuristic step can choose not to assign a visit. This is represented as a NoChangeMove, because no change happens for that CH step. That is fine.
Local Search's ChangeMoveSelector on the other hand, should never select a NoChangeMove: either it assigns it, unassigns it or changes it. It cannot do nothing for a step.
Side 2 of the story
In VRP, with @PlanningListVariable(allowsUnassigned=true), if the CH leaves all visits unassigned (for example because all visits assignments break a hard constraint), the Local Search shouldn't just end with "no doable move" (and a bunch of NoChangeMove bail outs in trace logging), see below.
Why doesn't a move that breaks a hard constraint wins the LS step?
14:17:13.567 [main        ] TRACE Bailing out of neverEnding selector (Filtering(FromSolutionPropertyValueSelector(visits))) to avoid infinite loop.
14:17:13.567 [main        ] TRACE         Move (ai.timefold.solver.core.impl.heuristic.move.NoChangeMove@4a3631f8) filtered out by a selection filter (Doable moves only).
14:17:13.567 [main        ] TRACE         Move (ai.timefold.solver.core.impl.heuristic.move.NoChangeMove@4a3631f8) filtered out by a selection filter (Doable moves only).
14:17:13.567 [main        ] TRACE Bailing out of neverEnding selector (Filtering(FromSolutionPropertyValueSelector(visits))) to avoid infinite loop.
14:17:13.567 [main        ] TRACE         Move (ai.timefold.solver.core.impl.heuristic.move.NoChangeMove@4a3631f8) filtered out by a selection filter (Doable moves only).
14:17:13.567 [main        ] TRACE Bailing out of neverEnding selector (Filtering(Union([ListChangeMoveSelector(FromSolutionPropertyValueSelector(visits), ElementDestinationSelector(FromSolutionEntitySelector(Traveler), Filtering(FromSolutionPropertyValueSelector(visits)))), ListSwapMoveSelector(FromSolutionPropertyValueSelector(visits), FromSolutionPropertyValueSelector(visits)), ai.timefold.solver.core.impl.heuristic.selector.move.generic.list.kopt.KOptListMoveSelector@78a773fd]))) after (193060) attempts to avoid infinite loop.
14:17:13.568 [main        ] WARN      No doable selected move at step index (0), time spent (778). Terminating phase early.
14:17:13.568 [main        ] INFO  Local Search phase (1) ended: time spent (778), best score (0hard/0medium/0soft), move evaluation speed (0/sec), step total (0).
14:17:13.570 [main        ] INFO  Solving ended: time spent (778), best score (0hard/0medium/0soft), move evaluation speed (254/sec), phase total (2), environment mode (REPRODUCIBLE), move thread count (NONE).
0hard/0medium/0soft
[]

@triceo: Reproducer here: https://github.com/TomCools/nomove-bug-reproducer

There are three components to this issue:

There is a off-by-one error inside of of the selectors, causing the situation where no doable move was ever found. #1249 fixes that.
Having fixed that, another issue was uncovered in our Late Acceptance implementation. Since the CH already produces a better score than local search ever could (0/0/0), the Late Acceptance list is filled with this score. Local Search can not produce a move to beat that, end therefore LA is stuck in an infinite loop, never ending the first step. This issue requires some deeper thinking on how to fix it, and will be fixed in a different PR.
The NoChangeMoves are necessary in the Move Selector framework to support random nearby selection. They can not be removed. They also do not present an issue - the issue was the off-by-one error, and the NCMs were a red herring, drawing attention away. With Move Streams, this will all change and NCMs will go away.

I will close this issue once a fix for the off-by-one error is merged, and we'll discuss approaches to fixing the issue with LA.


Wild Magic Surge Auto Detect Not Working

When my sorcerer player casts a spell of 1st level or higher, there is no auto detect roll for wild magic surge. I've checked the module settings and wild magic surge auto detect is turned on (Enabled - Standard PHB) and that it's pointed at the correct roll table.
I've tried disabling and enabling the module but the issue still persists. Any suggestions for how to fix this?
Foundry version: 0.8.8 (running on ForgeVTT)
DnD 5e Helpers version: 2.0.8
Here's the error that is in my console when my sorcerer casts a spell 1st level or higher:
VM4625:8 Error: This is not a registered game setting
    at ClientSettings.get (foundry.js:1146)
    at VM3844 switchtochat.js:35
    at Function._call (eval at <anonymous> (listeners.js:56), <anonymous>:4:14)
    at Function.callAll (foundry.js:153)
    at ClientDatabaseBackend.callback (foundry.js:8681)
    at foundry.js:8620
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:8620)
    at ClientDatabaseBackend._createDocuments (foundry.js:8516)
    at async Function.createDocuments (document.mjs:332)

I'm sorry this is happening. Is there any way to find out what setting its looking for? I dont see 5e Helpers in that stack trace 🤔

I do have 5e helpers installed and activated though so that shouldn't be the issue. The name of the Tides of Chaos feature is "Tides of Chaos" which is also what the feature is called in my sorcerer's actor. Maybe the error that I grabbed last time was the wrong one. I tried it again and got this error this time:
Uncaught (in promise) TypeError: Cannot read property 'length' of undefined     at trafficCop (assets.forge-vtt.com/bazaar/modules/autoanimations/0.5.21/src/router/traffic-cop.js:39)     at setUpMidiNoA (assets.forge-vtt.com/bazaar/modules/autoanimations/0.5.21/src/autoAnimations.js:435)     at assets.forge-vtt.com/bazaar/modules/autoanimations/0.5.21/src/autoAnimations.js:245     at Function._call (eval at <anonymous> (assets.forge-vtt.com/bazaar/modules/lib-wrapper/<IP_ADDRESS>/lib-wrapper.js:1), <anonymous>:4:14)     at Function.callAll (foundry.js:153)     at BetterRollsWorkflow._next (modules/midi-qol/src/module/workflow.js:715)
I also get this error in the console when I open the 5e Helpers' settings:
VM1132:8 TypeError: Cannot read property 'querySelector' of null     at init.js:42     at Function._call (eval at <anonymous> (libWrapper-consts.js:8), <anonymous>:4:14)     at Function.call (foundry.js:179)     at HelpersSettingsConfig._render (foundry.js:2097)     at async HelpersSettingsConfig._render (foundry.js:2729)
Not sure if this helps. Sorry I can't be more precise here.

This paints a better picture. Does this occur with all other modules turned off? It appears to be a result of module conflicts somehow.

 Now that I tried it with all other modules turned off, I get these two warnings in the console:
foundry.js:9738 The Document#_id property is deprecated in favor of Document#id or Document#data#_id.  Support will be removed in 0.9.0 get _id | @ | foundry.js:9738  lookupProperty | @ | handlebars.min.js:27  eval | @ | VM5430:11  c | @ | handlebars.min.js:27  d | @ | handlebars.min.js:27  e | @ | handlebars.min.js:28  renderTemplate | @ | foundry.js:3627  async function (async) |   |    renderTemplate | @ | foundry.js:3626  displayCard | @ | entity.js:681  roll | @ | entity.js:486  async function (async) |   |    roll | @ | entity.js:442  _onItemRoll | @ | base.js:839  (anonymous) | @ | base.js:565 dispatch | @ | jquery.min.js:2 v.handle | @ | jquery.min.js:2

So, with all other modules turned off, you only see these two warnings (which are benign and part of the dnd5e system, iirc), but the functionality still doesnt work?
And to make sure, you have ticked the Wild Magic Surge in the actor's special traits?
Thanks for bearing with me on this.

Ah that's what I was missing! My actor didn't have the Wild Magic Surge trait ticked in special traits! I feel silly now.
Thanks a lot for your patience and help. It's working as intended now!


puppet_linux: Track number of seconds since puppet last ran.

:eyeglasses: @captncraig @gbrayut

LGTM

Great! thanks (I had wondered how this worked for others)


Auth Problem

When i try register its okey working succesfuly and give me password its olrayt but when i try login, its gives an exception: "Auth response error" help me

This API old and not worked


enhancement/improved the middleware authjs file

Improvements made were:

[x]  Check if the user still exists
[x] Checking if the user recently changed password after the token was issued
[x] Added the already logged in user on request object for easy access down the middleware pipeline

Made changes to the user router, user controller and user model files.

@vishalverma9572 I think part of these errors are occurring because there is only a branch currently main branch and making a pull request will try to merge with it, I suggest creating another branch where we can make a pull request to like a dev branch, which can then be merged with the main branch by a member of the team.

@ugz-man, , I've created a dev_branch from the main branch. You can now work on that, and if it looks good, I'll merge it into the main branch.
And I'm closing this PR. Please create a new one on the dev_branch.

@ugz-man ,  if you want I can make you maintainer of that branch for some time

@vishalverma9572 Thank you very much for the opportunity, but I really can't handle a task like that right now, Thank you very much.


Remove duplicate examples

There is a lot of code duplication between the examples, which makes it
hard to see the different approaches. The file based example is also
missing instructions how to obtain "sockex1".
Keep the example loading from a byte array, since it covers more parts
of the API.

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   59.03%   59.03%
=======================================
  Files          24       24
  Lines        1877     1877
=======================================
  Hits         1108     1108
  Misses        605      605
  Partials      164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371e351...064cba4. Read the comment docs.


blockchain-tree: add unit tests for update_block_hashes and remove_block

I'm closing this because we don't need more test coverage for this since this is scheduled for deprecation soon


Feature/#184562415 retry create vm on fallback datastore if create vm fails with a full datastore

vsphere has two (or more datastores) that run at high capacity we can
end up in a situation where the datastore that is prioritized via the
weighting provided in the selection pipeline cannot fit ALL VMs that
need to be created. That wouldn't be a problem if we wouldn't run these
in threads. Since the threads are not aware about each other and do the
same weighting, both threads, when running at the same time, will pick
the same datastore.
Though if that datastore can only fit one more VM, then one of the
threads will raise the newly introduced error. To avoid erroring a bosh
deployment that would otherwise succeed, we can retry the create_vm on
the next datastore from the selection pipeline if we encounter that
start_vm fails with GenericVmConfigFault. To properly handle this error,
this introduces and update to the retry judge. We did internally retry this
error when encountered since it wasn't int the list. That internal retry
to power_on added additional runtime to the deployment but didn't
solve anything.
To my understanding this behaviour should be specific to usage of
multiple datastores (as opposed to the cpi using a datastore cluster) so
no change was added to the codepaths dealing with clusters. additionally
this whole behaviour only applies to the DS chosen for the ephemeral
disk. The error message for a failed deployment was:
Error running task 'Drm.ExecuteVmPowerOnLRO'. Failed with message 'Module MonitorLoop power on failed. ' and fault mes
sage 'Module MonitorLoop power on failed. ,Failed to extend swap file /vmfs/volumes/<GUID>/vm-<GUID>/vm-<GUID>.vswp
from 0 KB to 67108864 KB : No space left on device,Current swap file size is 0 KB.,
Failed to extend the virtual machine swap file,Could not power on virtual machine:
No space left on device.,Failed to power on VM.,Failed to start the virtual machine.'.

This scenario is now retried under the condition that the selection
pipeline contained other possible datastores that were less appropriate
at time of check. To avoid restarting the checks we just cache the
fallback datastores in the newly introduced attribute of VmPlacement.

@selzoc @nouseforaname has added tests for vm_placement_selection_pipeline.rb do you want to look over this?

LGTM 👍


cyclonedx SBOM is broken - missing primary

when feeding http://quadblockquiz.org:4000/.well-known/sbom/quadquizaminos.0.14.2-cyclonedx-sbom.1.0.0.json into other SBOM tools, they complain the file fails cyclonedx checks.
In particular it is missing the application field defining the primary component (quadblockquiz)

Looking into the issue, seems there was a problem with the metadata . From the CycloneDX v1.4 JSON Reference, inside the metadata, there is the component  property which has required fields(type and name) . Here is the  generated cyclonedx json file metadata , the component is missing the name field.
"metadata": {
   "timestamp": "2022-02-10T08:27:21Z",
   "tools": [
     {
       "vendor": "CycloneDX",
       "name": "Node.js module",
       "version": "3.1.1",
       "hashes": [],
       "externalReferences": []
     }
   ],
   "component": {
     "type": "library",
     "description": " ",
     "licenses": [
       {
         "license": {
           "id": "MIT"
         }
       }
     ]
   },
   "licenses": []
 },`

When I validate the file using the cyclonedx-cli validate command  I get the following output
Unable to validate against any JSON schemas.
BOM is not valid.

Updating cyclonedx/bom to v3.4.1  have solved the problem


Actuator endpoint override behaves incorrectly

As discussed here: https://github.com/spring-cloud/spring-cloud-commons/issues/354
Although endpoints are named differently, app still fails to start.
 Caused by: java.lang.IllegalStateException: Found multiple extensions for the endpoint bean environmentEndpoint (environmentEndpointWebExtension, environmentWebEndpointExtension)
 	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.convertToEndpoint(EndpointDiscoverer.java:199) ~[spring-boot-actuator-2.0.2.RELEASE.jar:2.0.2.RELEASE]
 	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.convertToEndpoints(EndpointDiscoverer.java:184) ~[spring-boot-actuator-2.0.2.RELEASE.jar:2.0.2.RELEASE]
 	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.discoverEndpoints(EndpointDiscoverer.java:124) ~[spring-boot-actuator-2.0.2.RELEASE.jar:2.0.2.RELEASE]
 	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.getEndpoints(EndpointDiscoverer.java:116) ~[spring-boot-actuator-2.0.2.RELEASE.jar:2.0.2.RELEASE]
 	at org.springframework.boot.actuate.endpoint.web.PathMappedEndpoints.lambda$getEndpoints$1(PathMappedEndpoints.java:69) ~[spring-boot-actuator-2.0.2.RELEASE.jar:2.0.2.RELEASE]
 	at java.util.LinkedHashMap$LinkedValues.forEach(LinkedHashMap.java:608) ~[na:1.8.0_151]

I'm unable to reproduce this. Can you provide a complete, minimal, verifiable sample that reproduces the problem?  It should be available as a GitHub (or similar) project or attached to this issue as a zip file.
It shouldn't ever get into that state since the one from spring cloud is created first and the one in boot is conditional on missing bean.

Sorry, I'm not able to start a new project to try and recreate this issue. I could probably get my project into a portable state and attach it as a zip. Is that acceptable?

yes, a zip is fine.

Well, as I was moving my dependencies around to prepare this project to zip up, the issue resolved itself and I am no longer able to recreate it. I have been bouncing around among Spring-Boot and Finchley versions, so maybe this was a cached class file somewhere? At any rate, there would be no point in attaching the project, since it is no longer exhibiting the error.


matchers: rename someElement to anyElement

This issue was originally filed by @seaneagan

since Iterable.some was renamed to Iterable.any

This issue has been moved to dart-lang/test#212.


[[[UIApplication sharedApplication] delegate] window]

If there's SceneDelegate in the project, there's no window in AppDelegate, crash

@993695620 Hey! Your AppDelegate must have a field
var window: UIWindow?
Pay attention that the field is optional; if you've got a non-optional app still crashes.

Try this solution:
[SOLUTION]


in website layout edit ends in wsod

Hi,
when you try to edit an existing layout of a static website you can't store your changes.
After klick the browser reloads to /item and results in a WSoD.
have a nice day - MicMee

#fixed

thanks


[R-package] logo in documentation

See the following links:

https://github.com/microsoft/LightGBM/pull/3327#issue-471319731
https://pkgdown.r-lib.org/reference/build_favicons.html

To close this issue, generate favicons for the pkgdown site for the R package.

Closed via #3336.


git push origin  not working

I was just trying out the sandbox mode and I found out that pushing tags into the remote repo does not work and makes the entire sandbox to be left hanging (no further git commands work, they are "waiting")
Steps for shortest reproduction:

start sandbox mode
git clone
git tag v1 master
git push origin v1 (hangs)

Ah yeah Im not surprised this breaks; we should at least error out, but I
dont see supporting tags in remotes yet.
On Thu, Jul 27, 2017 at 2:54 AM, dave-alcarin<EMAIL_ADDRESS>wrote:

I was just trying out the sandbox mode and I found out that pushing tags
into the remote repo does not work and makes the entire sandbox to be left
hanging (no further git commands work, they are "waiting")
Steps for shortest reproduction:

start sandbox mode
git clone
git tag v1 master
git push origin v1 (hangs)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pcottle/learnGitBranching/issues/435, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABFRn1nGVSXUU-UW84QF34EdSCGSsyxfks5sSF5mgaJpZM4OlDTM
.

--
Peter M Cottle
UC Berkeley 2012
UC San Diego 2011


Use anonymous authentication to store data on firebase

🚀 Feature Request
Use anonymous authentication to store data on firebase.
🔈 Motivation
It will allow to protect the database and only allow access to authenticated users.

Closed by #11


Team update - Mar 23, 2022

This is a  @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with XXX...
- Thanks for Jo's work on the XXX repo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>
- I had a meeting with ABC

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...
- Could somebody take a look at ...

**My availability for next week**
- I'll be off on XXX day...
- I've got several meetings this week...

:mag: Needs Triage:
The Needs Triage issues require an initial assessment and labeling.

Investigate accessibility statements

:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

Updates from last week :heavy_check_mark:

No real updates yet, but coming soon!

Challenges I faced and things I'd like assistance with 🙏

The usual... balancing commitments

My availability for next week

I'll be available all next week

Meeting minutes:

Gabriel gives updates. No updates since last week. Still balancing commitments.
Isabela gives updates. Same as above, a few extra notes:

Gabriel asks for some more context about RIT. RIT is the Rochester Institute of Technology. It has a minor related to Open Source, which requires students to do some open source work. Isabela met with some students, created the issue above as a starting point for those students. Maybe something will come out of it, maybe not. But we have at least made a connection.
Isabela is working on fixing the JupyterLab/Accessibility Docs. She could use eyes on the issue linked above.

Giving Gabriel the tea on the cancelation of the Jupyter accessibility workshop. tl;dr-- not enough people registered.

Longer discussion/brainstorming about how to create a collective audit, or some new kind of collective workshop (like the alt text workshop)

Tony gives updates. Says he doesn't have any. Gabriel empathizes. Isabela asks how she can help.
Long discussion with Gabriel about demands of Conda Store.

tl;dr-- In order for Gabriel to meet demands of this a11y team, he needs to go from being actively involved with Conda Store to being passively involved (or not involved)

Tony wonders if there should be more coordination between the people working on accessibility


Motion blur fixes

Currently experimental support for xform based motion blur is available.
We need to add:

More stable time sampeled xform motion blur
Support for other imageable time sampeled xform motion blur
Deforming mesh motion blur
Velocity based motion blur

As of 18/12/2020 these are implemented. There is a known slow down with deforming motion blur. This will be addressed soon.


[Bug] Request disappears when moving request without selected workspace

Insomnia Version: 6.2.0
Operating System: Win 10

Details
After putting hard work into setting up my request and writing documentation my request just disappeared. Why? I accidentally clicked "Move" in Request setting dialog:

This is very frustrating experience. Should there not be a validation before you move a request to a blackhole?
Also why on earth do the dialogues not have an OK or Save or Apply buttons? Instead they automatically apply settings. This is extremely counter-intuitive for Windows users at least. To successfully exit the dialog and have my changes applied I need to press "X" in the top right corner. I always pause for a second to make sure I'm not actually cancelling my changes.
I clicked Move because of muscle memory. The way that button is positioned it looks like an OK button if you're not careful.

I agree that it's frustrating and it definitely wasn't done on purpose, that's for sure! Some bugs are bound to slip through the cracks
🤗

Thank you for your prompt response.


Add several obsolete no-op methods

This pull request adds some required no-op methods which are part of the 'Obsolete features' section of the HTML specification.
Specifically, clear(), captureEvents() and releaseEvents() on document:
https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-clear
And the latter two again on window:
https://html.spec.whatwg.org/multipage/obsolete.html#dom-window-captureevents
It also implements the External interface used for window.external, no-ops for the two SearchProvider methods that go with it and a to-upstream test for this.
Finally, I took the opportunity to remove some unimplemented IDL for the alternative stylesheets API which has been removed from the CSSOM specification.

Awesome stuff! Thanks especially for the tests; they're obviously the hardest part!


Saving queries for percolator

I'm trying to save percolate queries in ES (version 1.5.2) using JEST wrapper, however, ES does not like the query I'm passing in. Here's a snippet of what my code looks like;
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder();
searchSourceBuilder.query(QueryBuilders.matchQuery("stock", "apple"));
saveDoc(searchSourceBuilder, "1", "_percolator", "stocks");

public JestResult saveDoc(Object doc, String docId, String indexName, String type) {
    Index index = new Index.Builder(doc).id(docId).index(indexName).type(type).build();
    return client.execute(index);
}

I end up with an error "{"error":"RemoteTransportException[[kili-1][inet[/<IP_ADDRESS>:9300]][indices:data/write/index]]; nested: PercolatorException[[default] failed to parse query [1]]; nested: NullPointerException; ","status":500}"
Is there something obvious that I'm doing wrong?

After much debugging, it turns out if if I pass the string version of searchSourceBuilder (searchSourceBuilder.toString()) to Index.Builder(..), saving queries works as expected. What I am not sure about is, why do I have to do this explicitly for SearchSourceBuilder objects, but the same isn't true for my own POJOs.

why do I have to do this explicitly for SearchSourceBuilder objects, but the same isn't true for my own POJOs

That's because the former one is a builder not a POJO and GSON can't (and does not need to) handle that. As you discovered builder.toString() is the way to go.


[TRG 5.02] Apache-2.0 License file missing in Chart

The Apache License file has to be included in the Charts directory, so it is included in the released archive. See https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-02/
blocks #108

Valid point 👍🏻 I will add it

@SebastianBezold  I created a PR waiting for your approval https://github.com/eclipse-tractusx/digital-product-pass/pull/117

PR merged this issue is ready to be closed :)


Implement global Corruption Tracker application

A way to track each character's Corruption (and reasons for it) would be incredibly useful as opposed to e.g. writing it down on a Journal entry. It would probably need to be implemented with recourse to socketlib because each connected player's Corruption value needs to be displayed and can be modified by the player (on their sheet) or the GM (through this app).
Needs further discussion.

Since we now have Journals v2 I would say tracking it in a journal is good enough. If you want to have it a certain design / UI there's now lots of new APIs for creating custom JournalEntrySheet / JournalPageSheet, but I'm not sure if it's worth the time

Agreed. Can be closed IMO.

Done & done :)


[BUG] api router bug

Describe the bug
micro api --handler=rpc not works
go-micro/v2@v2.80/api/router/registry/registry.go:129
end := api.Decode(sep.Metadata)  // sep.Metadata is always empty

What are you trying to do?
call rpc service by using http post

What did you expect to happen?

What happens instead?

{"id":"go.micro.api","code":500,"detail":"service not found","status":"Internal Server Error"}

How to reproduce the bug:
the service name: xxx.service.greeter
the service method: Greeter.Call
$ micro --auth_namespace='xxx' api --namespace=xxx --handler=rpc
$ go build && ./greeter-service
$ curl --location --request POST 'localhost:8080/service/greeter/greeter/call' \
--header 'Content-Type: application/json' \
--data-raw '{"name":"jack"}'
{"id":"go.micro.api","code":500,"detail":"service not found","status":"Internal Server Error"}%

Environment:
Go Version: please paste go version output here
$ go version
go version go1.14 darwin/amd64

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/t5w0rd/Library/Caches/go-build"
GOENV="/Users/t5w0rd/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/t5w0rd/proj/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/t5w0rd/proj/community/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/n5/9srywmjs1bg3z63c5hhzlnyh0000gr/T/go-build968216784=/tmp/go-build -gno-record-gcc-switches -fno-common"

<EMAIL_ADDRESS>modify code at line 202:
201     ropts := []resolver.Option{ 202         //resolver.WithNamespace(nsResolver.ResolveWithType), 203         resolver.WithNamespace(nsResolver.Resolve), 204         resolver.WithHandler(Handler), 205     }
rebuild micro:
cd<EMAIL_ADDRESS>go build
go install

@doubleycn nonono, this is not the same.

this is the same . so meta is empty, but micro can work.
this question is because of the namespace.
{"id":"go.micro.api","code":500,"detail":"service not found","status":"Internal Server Error"}
version info:

micro<EMAIL_ADDRESS><EMAIL_ADDRESS>
examples info:
github.com/micro/examples/greeter/srv:
run srv
cd github.com/micro/examples/greeter/srv
go run main.go

micro list services
go.micro.srv.greeter

micro call go.micro.srv.greeter Say.Hello '{"name": "john"}'
{
	"msg": "Hello john"
}

it is ok. now reg namespace is go.micro.srv.greeter
dlv found:
github.com/micro/go-micro/v2@v2.8.1-0.20200604083217-bd3ef6732811/server/grpc/grpc.go:684
(dlv) p service
*github.com/micro/go-micro/v2/registry.Service {
	Name: "go.micro.srv.greeter",
	Version: "latest",
	Metadata: map[string]string nil,
	Endpoints: []*github.com/micro/go-micro/v2/registry.Endpoint len: 1, cap: 1, [
		*(*"github.com/micro/go-micro/v2/registry.Endpoint")(0xc0003bffb0),
	],
	Nodes: []*github.com/micro/go-micro/v2/registry.Node len: 1, cap: 1, [
		*(*"github.com/micro/go-micro/v2/registry.Node")(0xc0000a2a20),
	],}

dlv api for http call.
curl http://localhost:8080/greeter/say/hello -H "Content-Type: application/json" -X POST --data '{"name":"jj"}'

=> 114:	func (c *cache) get(service string) ([]*registry.Service, error) {
   115:		// read lock
   116:		c.RLock()
   117:
   118:		// check the cache first
   119:		services := c.cache[service]
(dlv) p service
"go.micro.srv.api.greeter"

notice：
service = go.micro.srv**.api.**greeter
but srv namespace is go.micro.srv.greeter
so not found service req.meta is empty.
found error:
{"id":"go.micro.api","code":500,"detail":"service not found","status":"Internal Server Error"}
modify srv code
service := micro.NewService(
		micro.Name("go.micro.srv.api.greeter"), // add api for name
	)

run
go run main.go

micro list services
go.micro.srv.api.greeter

curl http://localhost:8080/greeter/say/hello -H "Content-Type: application/json" -X POST --data '{"name":"jj"}'
{"msg":"Hello jj"}

this is work!

Closing as there was a response to resolution.

@doubleycn thanks for your reply, but can you test micro api by using --handler=rpc instead of --handler=api?

ok, thanks a lot.
After reading examples/api/rpc, I found a difference between the new and old versions.
And understood this text:
"notice：
service = go.micro.srv**.api.**greeter
but srv namespace is go.micro.srv.greeter"


Persist divider location

Currently this is manually set and not configured but it does need preserving in order to support the auto update feature.

Should really persist system digest configuration too.
Possibly configure orientation of divider too?


TP2000-432 QuotaAssociation objects have been created with the same main and sub quota

TP2000-432 QuotaAssociation objects have been created with the same main and sub quota

Why

It shouldn't be possible to create an association where the same definition is both the parent and the child.
It shouldn't be possible to create overlapping definitions for the same quota order number.
Therefore, we should formalise the above as business rules.
What

Adds two new rules, tests, and updates model business rules lists

Codecov Report

Merging #635 (e2ed6be) into master (0a08c9d) will decrease coverage by 0.00%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   93.20%   93.20%   -0.01%
==========================================
  Files         323      323
  Lines       20620    20639      +19
  Branches     1649     1651       +2
==========================================
+ Hits        19219    19236      +17
  Misses       1096     1096
- Partials      305      307       +2

Impacted Files
Coverage Δ

quotas/models.py
99.09% <ø> (ø)

quotas/business_rules.py
96.29% <75.00%> (-1.35%)
:arrow_down:

quotas/tests/test_business_rules.py
99.49% <100.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a08c9d...e2ed6be. Read the comment docs.


Update text.rs

Without this change, you cannot use #[derive(Default)] with a structure containing a TextBuffer

Thank you

Happy to help


Nested Routes

Support Route Strings like /product/@id/@!view{reviews,pricing} to tell Vike that the route paramter view is "nested":

Changing the route parameter view shouldn't scroll the page to the top.
Using {reviews,pricing} tells Vike that the route parameter view only accepts the values reviews and pricing.
Vike sets pageContext.url.pathnameRoot = '/product', and upon nested navigation pageContext.nestedNavigation = ['view']. (So that data fetching tools such as vike-react-query can tell whether the re-render was triggered by a nested navigation and thus cache more aggressively. Concretely, vike-react-query could use pageContext.url.pathnameRoot as cache condition.)

// /pages/product/+route.js

export default '/product/@id/@!view{reviews,pricing}'

Similarly for Route Functions:
// /pages/product/+route.js

export default () => {
  return {
    routeParams: {
      view: 'pricing',
    },
    // Same logic as above
    keepScrollPosition: ['view'],
    // Or using pageContext.urlPrevious to directly control whether to scroll the page to the top
    keepScrollPosition: true,
  }
}

Open questions:

I'm not sure about the syntax /product/@id/@!view{reviews,pricing}, it feels like there could be a cleaner syntax?
Can we infer the structure of such string in TypeScript land? For typesafe links without code-gen.
How about making Vike always treat paramters other than the first one as nested? For changing this default behavior, the user can use a Route Function => no need for a new syntax anymore (other than {reviews,pricing}).

Actually, it isn't clear whether subsequent route parameters should trigger a scroll-to-the-top?

Is {reviews,pricing} really worth it? Isn't using a guard() good enough? With the previous point, we wouldn't need any new syntax.
How can vike-react-query know what data belongs to what nested parameter? How about a new component hook that does nested routing + data fetching?

The nested layout DX has been considerably improved. Closing in favor of https://github.com/vikejs/vike/issues/1689.


Document how to tell Rancher to ignore a node

I reorganized this page because I'm about to add a new section to it, and I don't want to just tack it on, because in the long term that could make it cluttered.
So I added a table of contents and tried to group similar items together, just to prepare it for taking a new section.
I made two corrections in the organization commit as well:

There was a note warning people that "Currently, the timeout setting is not enforced while draining a node. This issue will be corrected as of Kubernetes 1.12." That version of k8s is in the past, so I changed it to "The timeout setting was not enforced while draining a node prior to Kubernetes 1.12."
There were two misleading references to node pools, saying that they "automatically" replace deleted nodes. I clarified that to say that they will only automatically replace nodes if you enable node auto-replace.

I'm trying to pin down some details but this is the draft of the new section:
Labeling a Node to be Ignored by Rancher
Available as of 2.3.3
Some solutions, such as F5's BIG-IP integration, may require creating a node that is never registered to a cluster.
Since the node will never finish registering, it will always be shown as unhealthy in the Rancher UI.
In that case, you may want to label the node to be ignored by Rancher so that Rancher only shows nodes as unhealthy when they are actually failing.
You can label nodes to be ignored by using a setting in the Rancher UI, or by using kubectl.
Labeling Nodes to be Ignored with the Rancher UI
To add a node that is ignored by Rancher,

From the Global view, click the Settings tab.
Go to the ignore-node-name setting and click Ellipsis (...) > Edit.
Enter a name that Rancher will use to ignore nodes. All nodes with this label will be ignored.
Click Save.

Result: Rancher will not wait to register nodes with this name. In the UI, the node will displayed with a grayed-out status.
If the setting is changed afterward, the ignored nodes will continue to be hidden.
Labeling Nodes to be Ignored with kubectl
To add a node that will be ignored by Rancher, use kubectl to create a node that has the following label:
cattle.rancher.io/node-status: ignore

Result: Rancher will not attempt to sync with this node.
If the label is added before the node is added to the cluster, the node will not be shown in the Rancher UI.
If the label is added after the node is added to a Rancher cluster, the node will not be removed from the UI.
If you delete the node from the Rancher server using the Rancher UI or API, the node will not be removed from the user cluster if the nodeName is listed in the Rancher settings under ignore-node-name.

This should be considered a draft PR

Viewing the changes in a web browser
git clone https://github.com/catherineluse/docs.git
cd docs
git fetch -a
git checkout ignore-node
./scripts/dev

Then view http://localhost:9001/rancher/v2.x/en/cluster-admin/nodes


Add new hero animation

Related to #2381
Maybe it should be merged into update-landing-ui rather than main.
The only significant change is in Hero.tsx

Preview:
https://dotland-9wzm47dwf1w0.deno-staging.dev/hero_preview
(broken:)
https://dotland--hero-202209.deno-staging.dev/hero_preview

Got this error:
TypeError: Cannot read properties of undefined (reading 'rid')
    at https://deno.land/std@0.154.0/node/_process/streams.mjs:137:35

awesome! i will copy the component


elliot get - "--json" flag is missing

According to the documentation, the output of the get subcommand can be formatted in JSON using the --json flag, but this flag is missing.
 > elliott get --json 40392
Usage: elliott get [OPTIONS] ADVISORY
Try "elliott get -h" for help.

Error: no such option: --json

This is a feature that was lost when we switched over from called the ET api ourselves to using https://github.com/red-hat-storage/errata-tool/
Is json output something that would be helpful to you? If so, I can try and make time to reimplement, otherwise I will just update the documentation.

Yes, Json output is useful. It much safer than use grep/awk to parse elliott's output.

Hi, we need this to process the output in our pipeline.  Having to parse the text to get to the list of builds is very brittle.
I'd dare to say reinstating --json should be a high priority.

Just to add a +1 here.
json would make it easy to integrate elliott in other tools and workflows due to built-in support for parsing / marshaling json objects, etc.

I've opened https://github.com/red-hat-storage/errata-tool/issues/156 , but this seems like it is a more specific use-case for listing builds in an advisory. In other words, it sounds like some other tools are consuming the JSON from the elliot CLI, and you would not want the "DEBUG: ..." prefix, etc.
Can these tools use the Python errata-tool library directly, or do they need to shell out to elliot?
If they must shell out, would you please give an example of the exact JSON you need for this?

That is a good question:
"Can these tools use the Python errata-tool library directly, or do they need to shell out to elliot?"
In my specific case that is what I am doing for replacing elliott "get" due to the loss of --json.
It was basically a one line change.   The big value of elliott comes from operations like "create".
But we were trying to consolidate operations by always calling elliott, which has been mage into a Jenkins step (or global variable) in the RHPROD shared library, aptly named 'elliott' :-)
The step idea a few details (like kerberos authentication) and code using it becomes more clear than code calling an endpoint with an URL repeated in many places.
And if the API changes someday there is only one place to change.  It just happened with the Ansible Tower.
In summary, it would still be preferable to use elliott with the --json flag than calling the API directly.

There's a lot of context I'm missing here unfortunately. I'm not familiar with RHPROD, or the point about kerberos, but we've not yet had to break the API for python-errata-tool, and we follow semver there.
What is the example JSON you need for elliot get? I guess I can look back through the Git history of this project and find a point where it was working?

I'm working on adding --json back to elliott get as well as adding it to elliott find-builds over at https://github.com/openshift/elliott/pull/37
I wasn't particularly aware of the concerns about the API changing, and I probably should pay more attention to it, would be nice if errata-tool could serve as something of a facade for the API, but for now it seemed easiest to just work with what the API gives back.

Nice! thanks @sosiouxme ! 👍

@sosiouxme I'd like to merge https://github.com/red-hat-storage/errata-tool/pull/160 and then cut a new release of that project. I will be on vacation for the latter half of this week, so I will plan to tag and release the new python-errata-tool version to PyPI Apr 29th.

I've pushed errata-tool v1.19.0  to https://pypi.org/project/errata-tool/ today.

Thanks, then I can officially require it :)

Hi guys, is ET v1.19.0 deployed to production yet?

What does it mean to deploy a version to production?

I mean, be in the ET that we are currently using.  I was assuming that you had "stage" and set release dates like Koji (Brew).  I just want to know if we can use this now in the RHPROD library (part of the CPaaS initiative)

Oh ok. I'm not part of the Errata Tool team. I just maintain the errata-tool Python library, and I don't have a schedule for that.

Issue was resolved. didn't check for how long it was resolved already, but using the current latest version https://pypi.org/project/rh-elliott/0.2.14/ gives us a beautiful JSON output.
$ elliott get 40392 --json -
{
    "actual_ship_date": null,
    "assigned_to_id": 3001603,
    "batch_id": null,
    "cloned_from_id": null,
    "closed": 0,
    "content_types": [
        "docker"
    ],
    "contract": null,
    "created_at": "2019-03-19T14:02:52Z",
........


Click event triggered twice

Hi
I have a test case where we expected the zoom module to be opened when the user clicks on the zoom button. It works on mobile when I tap the button manually. The problem I'm facing is when I run the test on a real mobile device using the remote tool from test cafe. The zoom panel is opened and then closed, I checked the events and the button is getting clicked twice.
The double click does not happen on desktop devices, or when I click/tap it manually you can verify it at:
http://test-viewer.kristianhristov.com/test/A2-simple-with-zoom.html
(On desktop devices zoom button is not displayed, but zoom module opens when you click the viewport)

const testCaseName = `Zoom`;

fixture(testCaseName).page('http://test-viewer.kristianhristov.com/test/A2-simple-with-zoom.html');

test("Zoom panel should be opened when clicked", async t => {
    let mainZoomCnt = await Selector('.cylindo-zoom-imagery').parent();

    await t.wait(20000).click(Selector('.threesixty-button'));

    await t.debug();

    await t
        .wait(10000)
        .expect(mainZoomCnt.exists).ok()
        .expect(mainZoomCnt.visible).ok();
});

testcafe version:                   1.8.5

node.js version:                    v10.13.0

command-line arguments:  testcafe "remote"  "-S" "-s" "artifacts/screenshots" "-p" "${USERAGENT}${FIXTURE}_${TEST}.png" "test/spec/complete/A1-*.spec.ts" "--app" "node test/serve.js" "--speed" "1" "--quarantine-mode" "--qr-code"

browser name and version: Chrome mobile 84.0.4147.105

platform and version:          Huawei mate 20 lite

I changed the test code and was able to reproduce the issue: a click event on the zoom button (which appears only with a mobile version) is triggered twice.
This test fails although it shouldn't:
import { Selector } from 'testcafe';

const testCaseName = `Zoom`;

fixture(testCaseName).page('http://test-viewer.kristianhristov.com/test/A2-simple-with-zoom.html');

test("Zoom panel should be opened when clicked", async t => {
    const zoomPanel = await Selector('.cylindo-zoom-imagery');

    await t
        .expect(zoomPanel.visible)
        .notOk('Zoomed viewport should not be visible before click on zoom button');

    await t.click(Selector('.threesixty-button'));

    await t
        .expect(zoomPanel.visible)
        .ok('Zoomed viewport should be visible after click on zoom button');
});

It is possible to run the following command:
npx testcafe "chrome:emulation:device=iPhone 4" test.js

(or use the remote mode)
Thank you for bringing this to our attention. We'll update this issue when we have any news.

@wentwrong any ETA for this issue? This is really urgent for us and this is not the only event that is being triggered twice, some other clicks are being triggered multiple times too...

Unfortunately, at the moment we cannot give any ETA for this bug. Once we have news to report, we will notify you here.

Do you think it is important to list you some other examples where I noticed the same behavior here?
One more thing that I think is important to mention is that we have enabled touch and click events at the same time in case users have devices with touch screen and mouse. This is because we don't know which device will be used to execute the functionality, so, we have both listeners enabled. Internally we handle it with preventDefaults, stopPropagation and stopImmediatePropagation, etc.

@Esteban26
Hello,

Do you think it is important to list you some other examples where I noticed the same behavior here?

At present, we have all the information we need to process this issue. If you encounter any other issues after the fix is published, please report them.

This is because we don't know which device will be used to execute the functionality, so, we have both listeners enabled.

Thank you for the information. Our goal in this case is not to break the native behavior.

To the team:
I researched the issue. It occurs because the zoom view is toggled on two events: touchend and  mousedown. It is shown on touchend and then it's immediately closed on mousedown. However,  without TestCafe it works, since the target site calls the preventDefault method on the touchend event, so mousedown is not raised. Thus, to fix the issue, we need to support the case when the preventDefault method is called on the touchend event to prevent mousedown.

Hi @AlexKamaev, do you have any update on this issue?

Hello @Esteban26,
There are no updates yet.

thanks!

thanks!


pull request for e2e test at 12/17/2016 18:45:20

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


create xsl solution for adding implementation_set > localid

I believe that this will be easier for editors to use than a Python solution
This is also related to the idea to include an .xpr file in the repo with transformation scenarios set up; editors could CTRL + SHIFT + T while working in a prop_set to generate local ids as implementation_sets are added

Refer to structure of @localid_prop: start_localid var


Tries to compile node_modules

Hello,
Using the last version of ST3 and your plugin, as I hit CTRL+B or F7, it takes ages in the console then show up tons of errors concerning node_modules..while the project compiles fine on the command line
how can I fix this ?
I already exclude these folders in my project settings
        "folder_exclude_patterns":
        [
            "node_modules",
            "dist",
            "meta"
        ],

thanks

please delete this, I found I had another _node_modules folder
may bad


Revert "print python coverage results to console"

Reverts colcon/colcon-core#331 - see https://github.com/colcon/colcon-core/pull/331#issuecomment-606892768.

For convenience I readded the value to the mixin: colcon/colcon-mixin-repository#22 (as originally proposed).

@mikaelarguedas FYI.