Connecting multiple gridlys (griddles? :)) for drag and drop

Anyway to connect multiply gridlys on a page so we can drop elements between them like ShapeShift.js (which isnt' supported anymore and has bugs)
Thanks,
J

@noctivityinc Not currently supported (a pull request with this feature would be welcome).

Would seriously like to see this feature added, otherwise looking to use other plugins. Shame because gridly is beautiful.

Hi @LukeXF ,
A pull request supporting this feature would be great. It isn't a use case I need for my use with Gridly but I'd be happy to answer questions / merge a PR.
Kevin


Implement latin_1 in Rust

Based on the PyPy implementation. The encoding function needs some work with respect to error handling.
Requesting @coolreader18 as a potential reviewer, as they wrote the architecture for the encodings module and the error handling function(s).

I'm not sure if unicode_encode_ucs1 is reusable for other encodings, since anything >ucs1 would be some way of splitting the ucs2/ucs4 into parts, at which point it's just a different encoding.

unicode_encode_ucs1 is applicable to latin_1 and ascii, so that's why I put that function outside the module.

That is the correct way to add a new encoding; if that's what you were looking for.

While I was implementing this, I came across something that stymied me. In PyPy, the unicode_encode_ucs1 function references an error handler that is not yet implemented here. How would that error handler be implemented in Rust?

Originally posted this in #3118 but it makes more sense here
re: the ucs1 helper function, I think it makes more sense to abstract over utf8/ascii than ascii/latin1, since we use a utf8 str type (so we can just validate + extend_from_slice for utf8/ascii) whereas CPython has UCS1 as a buffer (so they can just validate + memcpy for ascii/latin1). Finishing up #3118 made me remember why I did that; in our implementation of codecs, ascii and utf8 just naturally have a lot of shared code where the alternative is true in CPython.


Update docker file to build from scratch

Codecov Report

Merging #84 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   78.87%   78.81%   -0.06%
==========================================
  Files          22       22
  Lines        1505     1506       +1
==========================================
  Hits         1187     1187
  Misses        244      244
- Partials       74       75       +1

Impacted Files
Coverage Δ

daisy/workflow/workflow.go
81.05% <33.33%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781200c...614d061. Read the comment docs.


Video cannot be played when updating react-native-video version 6x

Version
6.0.0
What platforms are you having the problem on?
Android
What happened?
Hello everyone, I am encountering a problem after updating React Native Video from version 5.2 to 6. Here’s the issue:
I have a Screen A that contains a list of videos for users to select and post. Selecting a username will navigate to Screen B, which contains a list of posts by that user. Screen C is the detailed post with an accompanying video. The problem I’m facing is that I can’t play the video on Screen C. Could you please let me know the reason and how to fix it? Thank you.
react native
0.72.5

I don't see any easy reason for this issue. Did you check the logcat ?

If using expo, delete your android build and rebuild it. Can also try removing node_modules and reinstalling packages.

I don't see any easy reason for this issue. Did you check the logcat ?

I have checked the logcat but couldn’t find any errors or issues. I am using react-navigation v6.

https://github.com/TheWidlarzGroup/react-native-video/assets/63105978/f1cde0f4-2567-4956-b965-f796acf6dd07
here is the video

It looks like react native video doesn't receive source prop...
Are you able to reproduce on a small sample and share it ?

The source prop has a value but it can’t play the video. I’ve tried hardcoding the source but it still can’t play. However, if I use navigation.replace, the video plays normally. This is the URI of a video and the code.
https://video.fireant.vn/d18efa81-cdae-4b02-96c8-9dc7eeb85789/-ufoko_nSf
<Video
id={data.postID.toString()}
ref={refVideo}
style={{height: '100%', width: '100%'}}
resizeMode="contain"
source={{
uri: data.videoUrl
}}
poster={data.videoThumbnailUrl}
bufferConfig={{
minBufferMs: 500,
maxBufferMs: 1000,
bufferForPlaybackMs: 500,
bufferForPlaybackAfterRebufferMs: 500,
backBufferDurationMs: 5000,
cacheSizeMB: 0
}}
// bufferingStrategy="DEPENDING_ON_MEMORY"
paused={pausedVideo}
posterResizeMode="contain"
ignoreSilentSwitch="ignore"
useTextureView={false}
playInBackground={false}
playWhenInactive={true}
onLoad={onLoad}
repeat={true}
disableDisconnectError={true}
preferredForwardBufferDuration={500}
onEnd={onEnd}
onLoadStart={onLoadStart}
onError={e => console.log('ERROR', e)}
/>

Just try to play with:
    {
      uri: 'https://video.fireant.vn/d18efa81-cdae-4b02-96c8-9dc7eeb85789/-ufoko_nSf',
      type: 'mp4',
    },

It works fine in sample ...


Chat "login" strangely only works sometimes, and only for "big" collabs

Firefox latest version, I enabled cross-site cookies and followed all the FAQ/Guides and in general I tried just about everything but for some reason, when I'm watching just one stream through holodex, I cannot type in chat (I get the mouseover "login to your account or else!") prompt.
But during big collabs, it works fine. Here's a screenshot for proof:

I'm using hyperchat but I tried with/without, there is no change.
Any idea why this is happening? I can only think that it's somehow related to the fact that my youtube account is kind of a "brand" account (the one which I'm member of the channels with).
But that doesn't explain why it works for big collabs but doesn't work for single streams...
Anything else I can provide, let me know please...

Not too sure why it's like that. Try disabling all your extensions.
For accounts, try switching between branded/nonbranded accounts on youtube.com and then checking if it changes anything on Holodex.

Thanks. Actually the multiview was a red herring - because I set up the layout before the stream and then I closed/opened firefox at some point (and I have it set to reopend all previously opened tabs). On reopen, it worked. Even with a single-stream layout. So I experimented with a few addons and found out that it was caused by PrivacyBadger. Disabling the relevant cookie blocking inside the addon made it work fine without needing to restart the browser. I had forgotten I was using the addon since it works kinda autonomously, Can't believe I haven't tried it myself.
Thanks for the correct pointer.


Header option does not work on devices with Reduce motion enabled

Header option works well when Reduce motion is disabled, but when enabled, seems like the script does not only bypass smooth scroll but even the header option.

Yes, that's correct. The script completely bails when reduce motion is disabled.

Thinking about this more, I can see the use case here: You'd still like to keep the content below the fixed header, but with perhaps a hard jump instead of an animated scroll?

Exactly. I would have to creatine a workaround for Reduced motion devices only. Also most dev probably don't know about this option so it could create issues with fixed elements on some devices. It Should only turn off the animated motion feature.

Fixed with https://github.com/cferdinandi/smooth-scroll/releases/tag/v16.1.0


Make confirmation dialogs modal

Partial fix for https://github.com/Microsoft/vscode-azuretools/issues/151

When are you going to do this for all of the extensions? 👼

@nturinski Just waiting for two more PRs to be reviewed and then all extensions will be done :)


Default Python packages should include azure_identity

Many of the Python packages (like azure_keyvault) need authentication. Without azure_identity, it's not possible to use them.
Can you please inform the responsibles?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab2945fc-8494-0437-3994-605136b1cb27
Version Independent ID: 68c40fee-cda6-8a93-962b-4448084e7c22
Content: Default Python packages in Azure Automation
Content Source: articles/automation/default-python-packages.md
Service: automation
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@aellwein Thanks for your feedback. I will share the feedback with Automation Product team. I would also recommend you navigate here  and share your feedback or suggestions directly with the responsible Azure feature team and clicking the vote button of your suggestion to raise visibility and priority on it.
As there are no further documentation changes, we will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


Use JS version of amcl in nodejs environments

I'm trying to port some academic caller code using amcl 2.2 from a Browser dummy page to a testing framework (probably Jest). Along the way I noticed that all the JS code of amcl (in both version 2.2 and version 3) does not use commonjs or es6 module exports, so it only works when loaded into global scope in browsers.
Are there any plans for nodejs based command line testing or packaging as a commonjs or es6 module? I'd offer to help out with this if this direction is supported by the maintainers.

At https://github.com/webmaster128/amcl-js-module I started a wapper around amcl JS with

CommonJS module exports
Unit tests
TypeScript definitions

It bundles amcl unchanged and does not try to change the library in any way. Currently only AES and Uint64 are exported as a proof of concept. If this is interesting for anyone, let me know. I'll probably extend this from time to time.

Update: I made the repo private as long as it is in a draft state. But I'm still working at this and will publish as soon as I am happy with the state.


Fix/14480: Wrong text in SRS dialog "Andere warnen nicht möglich" for error MIN_TIME_SINCE_ONBOARDING

Description
Show new warn alert text for SRS precondition error MIN_TIME_SINCE_ONBOARDING.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14480
Screenshots

Please take the issue https://github.com/corona-warn-app/cwa-wishlist/issues/871 into consideration. Internal ticket: https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14519


IE11: Figure with .img-fluid is not resized

The fluid image in a figure container is not resized at all making it overflow the content area.
On MacOS with Safari 11.0.2 it looks fine:

On Win 7 with Internet Explorer 11 .0.9600.18015 it looks like this:

Does seem to be somewhat related to display: inline-block on figure as deactivating that property (falling back to 'display: block' makes it look fine on IE11:

There have been related issues (#20970, #21360, #21886, #21888) describing this behavior for older versions of Firefox or which are closed to inactivity. There doesn't seem to be a fix for IE11 (which is a supported version I suppose).
I created a minimal example on JS Bin.

easy pick

.img-responsive has the max-width:100%; display:block; and height:auto; styling. I wonder if the 'Reponsive Images' section on https://getbootstrap.com/docs/4.0/content/images/ should be updated from .img-fluid to .img-responsive?

Fixed in #30809.


Add krew manifest

and set up installation of binary as kubectl-scout with LICENSE

https://krew.sigs.k8s.io/docs/developer-guide/plugin-manifest/


/usr/bin/ld: converter-sample.o:(.data.rel+0x0): undefined reference to `asn_DEF_PDU'

I am getting this when I am trying to run Makefile in ubuntu
There is comment related to this in converter-sample.c but I couldn't understand it
/* Convert "Type" defined by -DPDU into "asn_DEF_Type" */

PDU is usually the the top most object you want to decode.
By setting the -DPDU option then the converter-sample will via. macros set the PDU you want to decode. Otherwise you would have to program it yourself manually.
Look at the quickstart example
You for example have a grammar like this:
TestModule DEFINITIONS ::= BEGIN

    Circle ::= SEQUENCE {
        position-x INTEGER,
        position-y INTEGER,
        radius INTEGER (0..MAX)
    }

    Rectangle::= SEQUENCE {
        length INTEGER,
        width INTEGER
    }

END

Because this effectively have two PDUs to choose from you could make two different converters from it like so
gcc -DPDU=Circle -I. -o CircleDecoder.exe *.c
and
gcc -DPDU=Rectangle -I. -o RectangleDecoder.exe *.c

Hey I tried this and I am getting the decoder. Now the decoder takes an argument iber which is what I understand is the ber encoded data. Now I have a ber encoded string which I want to decode, how should I pass it to the decoder? I tried passing it directly but that didn't worked.

There are multiple ways to do this. Again read the quickstart example
And there is also the documentation.
It is hard to help when I can't see the code. And i don't know what you want to decode it to.
Long code short.
char buf[1024]; /* Temporary buffer */
asn_dec_rval_t rval; /* Decoder return value */
Circle_t *circle = 0; /* Type to decode. Note this 0! */
FILE *fp; /* Input file handler */
size_t size; /* Number of bytes read */
char *filename="E:\\path\\to\\der\\data.der"; /* Input file name */

/* Open input file as read-only binary */
fp = fopen(filename, "rb");
if(!fp) {
    perror(filename);
    exit(1);
}

/* Read up to the buffer size */
size = fread(buf, 1, sizeof(buf), fp);
fclose(fp);

if(!size) {
    fprintf(stderr, "%s: Empty or broken\n", filename);
    exit(1);
}

/* Decode the input buffer as circle type */
rval = ber_decode(0, &asn_DEF_Circle, (void **)&circle, buf, size);

if(rval.code != RC_OK) {
    fprintf(stderr, "%s: Broken Circle encoding at byte %ld\n", filename, (long)rval.consumed);
    exit(1);
}

/*Encode to whatever you want into a buffer*/
// choose what output should be
enum asn_transfer_syntax osyntax = ATS_BASIC_XER;
asn_TYPE_descriptor_t *pduType = &asn_DEF_Circle;
asn_encode_to_new_buffer_result_t res = asn_encode_to_new_buffer(NULL, osyntax, pdutype, circle);


appveyor: use CARDANO_SL_BRANCH to set backend branch

Let's wait for CI to confirm it works.

Where this CARDANO_SL_BRANCH would be taken from?

Ah, ok, I see.  I'll use the old way for now.

@darko-mijic windows installer should be ready soon :)


API key or steam_guard_code

Hi, It is not relevant to api. steam_guard_code was sending to me  in runtime which is I can't fill it right way.
Do we have to use API key or something? Please helps this issue. Thank you.

If we use steam_guard_code as referred and launched again steam sends another code. Seems never gonna work properly everytime it sends different one.

Use dev branch. https://github.com/RJacksonm1/node-dota2/tree/dev
Run app, get steamguard code, stop app
Save steamguard code into config, run app, remove steamguard code from config
Save sentry file so steamguard is bypassed

OR
Make a new account without steamguard.

Keep in mind that using the same account for bot, as the one you use in steam will have lots of weird interactions, like logging each other out.

And this library is all about steamguard. No API keys.
Re-open this issue if you are still stuck, or make a new issue with a specific question.


Thermostat Valve (Moes ZigBee TRV)

Log Message

2024-03-28 14:19:24.106 WARNING (MainThread) [custom_components.tuya_local.config_flow] Device matches None with quality of 0%. DPS: {"updated_at":<PHONE_NUMBER>.0052001, "4": false, "9": "closed", "14": 30}

Information about DPS mappings

"result": {
    "properties": [
      {
        "code": "mode",
        "custom_name": "",
        "dp_id": 1,
        "time":<PHONE_NUMBER>020,
        "value": "auto",
        "range": [
          "auto",
          "manual",
          "TempHold",
          "holidays"
        ]

      },
      {
        "code": "temp_set",
        "custom_name": "",
        "dp_id": 2,
        "time":<PHONE_NUMBER>551,
        "value": 22,
        "min": 5,
        "max": 45,
        "scale": 0,
        "step": 1
      },
      {
        "code": "temp_current",
        "custom_name": "",
        "dp_id": 3,
        "time":<PHONE_NUMBER>213,
        "value": 200,
        "scale": 1
      },
      {
        "code": "switch_rapid",
        "custom_name": "",
        "dp_id": 4,
        "time":<PHONE_NUMBER>775,
        "value": false
      },
      {
        "code": "countdown_rapid",
        "custom_name": "",
        "dp_id": 5,
        "time":<PHONE_NUMBER>044,
        "value": 0,
        "unit": "min",
        "min": 0,
        "max": 720,
        "scale": 0,
        "step": 15
      },
      {
        "code": "work_state",
        "custom_name": "",
        "dp_id": 7,
        "time":<PHONE_NUMBER>291,
        "value": "closed",
        "range": [
          "opened",
          "closed"
        ]

      },
      {
        "code": "window_check",
        "custom_name": "",
        "dp_id": 8,
        "time":<PHONE_NUMBER>775,
        "value": false
      },
      {
        "code": "window_state",
        "custom_name": "",
        "dp_id": 9,
        "time":<PHONE_NUMBER>666,
        "value": "closed",
        "range": [
          "opened",
          "closed"
        ]
      },
      {
        "code": "child_lock",
        "custom_name": "",
        "dp_id": 13,
        "time":<PHONE_NUMBER>702,
        "value": true
      },
      {
        "code": "battery_percentage",
        "custom_name": "",
        "dp_id": 14,
        "time":<PHONE_NUMBER>825,
        "value": 30,
        "unit": "%",
        "min": 0,
        "max": 100
      },
      {
        "code": "week_program11",
        "custom_name": "",
        "dp_id": 101,
        "time":<PHONE_NUMBER>446,
        "value": "BwAuCR4sER4sFh4qCAAuCwAsER4sFx4qCAAuCwAsER4sFx4q"
      },
      {
        "code": "BoostTime",
        "custom_name": "",
        "dp_id": 103,
        "time":<PHONE_NUMBER>375,
        "value": 200
      },
      {
        "code": "Valve_Ratio",
        "custom_name": "",
        "dp_id": 104,
        "time":<PHONE_NUMBER>401,
        "value": 0
      },
      {
        "code": "FillTemp",
        "custom_name": "",
        "dp_id": 105,
        "time":<PHONE_NUMBER>380,
        "value": 0
      },
      {
        "code": "Eco_Mode",
        "custom_name": "",
        "dp_id": 106,
        "time":<PHONE_NUMBER>274,
        "value": false
      },
      {
        "code": "Eco_Temp",
        "custom_name": "",
        "dp_id": 107,
        "time":<PHONE_NUMBER>959,
        "value": 14
      },
      {
        "code": "MaxSettemp",
        "custom_name": "",
        "dp_id": 108,
        "time":<PHONE_NUMBER>965,
        "value": 30
      },
      {
        "code": "MinSetTEMP",
        "custom_name": "",
        "dp_id": 109,
        "time":<PHONE_NUMBER>085,
        "value": 10
      }
    ]
  },
  "success": true,
  "t":<PHONE_NUMBER>829,
  "tid": "094c1c23ecf811ee92ae463057fe9a2e"

[CodeTypeValues Valve.txt](https://github.com/make-all/tuya-local/files/14788868/CodeTypeValues.Valve.txt)

Product ID

b6wax7g0
Information about how the device functions

https://moeshouse.com/products/moes-zigbee-trv-by100?pr_prod_strat=e5_desc&pr_rec_id=71af205d1&pr_rec_pid=6557597368401&pr_ref_pid=6862492532817&pr_seq=uniform
https://www.zigbee2mqtt.io/devices/BRT-100-TRV.html

The log message is missing, seems to be replaced by a file name.
And the dps info is insufficient as it is missing the lists of allowed values or range for each item, and whether they are read-write or readonly.

I don't know why, but link in topic doesn't work. I'll leave it here.
Log Message:
home-assistant_tuya_local_2024-03-28T11-19-29.671Z.log
dps:
CodeTypeValues Valve.txt

Unfortunately, it doesn't work. Does not detect this equipment. I am attaching the log:
2024-04-11 21:10:14.938 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Loaded device config moes_trv_thermostat.yaml
2024-04-11 21:10:14.938 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Not match for Radiator valve, missing required DPs: [{'108': 'int'}, {'109': 'int'}]
home-assistant_tuya_local_2024-04-11T18-10-22.999Z_11-04.log

Sorry, I forgot to mark the second copy of these two dps as optional.

Rapid heating (id 4, switch_rapid). The description of this parameter is missing in the code.

It was an oversight.  I initially interpreted this as on/off switch for the thermostat, and combined it with hvac_mode, but realised it was a wrong interpretation, so moved it partially to preset_mode instead, as boost, but as you say, the dp was missing so it will not work.

Filler temp (id 105, FillTemp). This parameter characterizes the adjustment in the temp_current parameter.

This was not obvious from the name, but now that I have the extra dp info, I can see the range (-9 to 9) so it can be broken out into a separate entity now.

countdown_rapid (id 5). Didn't show this parameter at all.

It is showing in your screenshot as "Boost timer"

temp_set (id 2) didn't change value in device

From the screenshot, your device is in eco mode, so the temperature will be affecting the eco mode temperature (id 107)

boost timer (id 103 BoostTime) didn't change value in device

There are two dps with the same meaning (dp 4, range 0 - 12 hours; dp 103 range 100 to 900 seconds).  I am not sure how they interact, and what the expectation is for them, but the boost switch on dp 5 seems to be grouped with the dp 4 timer, so I implemented that, and left this one as a read-only attribute, as anyway I had no range info for it at the time..

work_state (id 7) is Working status (diagnostic parameret)
This is implemented as hvac_action (heating / idle) on the climate entity.

I couldn't add device
log:
2024-04-21 18:12:51.054 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Loaded device config moes_trv_thermostat.yaml
2024-04-21 18:12:51.054 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Not match for Radiator valve, missing required DPs: [{'1': 'str'}, {'105': 'int'}]

I couldn't add device log:
2024-04-21 18:12:51.054 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Loaded device config moes_trv_thermostat.yaml
2024-04-21 18:12:51.054 DEBUG (MainThread) [custom_components.tuya_local.helpers.device_config] Not match for Radiator valve, missing required DPs: [{'1': 'str'}, {'105': 'int'}]

I added to this parametrs optional: true . Start testing

This problem still  actual.


Allowing order querying of properties

in eg. Klass1.all(:order => Klass1.name.asc)

I don't see how this is better than just Klass.all(:order => :name.desc) Maybe I'm missing something. Anyway, I'm closing this now.

Klass.all(:order => Klass.customer.name.desc)


Contributor documentation updates

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR addresses a comment brought up in #953 (https://github.com/Ouranosinc/xclim/pull/953#discussion_r763186599)

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

[ ] bumpversion patch has been called on this branch
[ ] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

Updated the documentation to point to the Sphinx reStructuredText Primer
Revised a line that suggested that this is a volunteer-led project
Ran pre-commit autoupdate (black now at v21.12b0)

Does this PR introduce a breaking change?
Nope.
Other information:

Coverage remained the same at 90.654% when pulling 81489157d42fbe8cf6903a934844e0e9df5a4925 on contributor_updates into f248b5c7923ad5bc588f1ba6d04085b1cce2c8b4 on master.


VS Code delays file save operation

VSCode Version: 1.4.0
OS Version:  Mac 10.11.6

Steps to Reproduce:

Create file watcher via (gaze, chokidar) on a source file that is open in VS Code and run it.
Let the document be idle in VS Code for a few minutes. Important.
Save the document.

Expected:
File watcher to notice the file change immediately.
Actual:
File changes are noticed a few seconds later (up to 10 seconds). But if you make subsequent changes, they are noticed almost immediately.
At first I thought it was gaze's fault, then I tried chokidar, then I tried chokidar in polling mode, they all behaved the same way. But when I touched the files they are always immediately noticed.
Which means...
The problem seems to be VS Code delaying the save operation. I've looked through whole code path and couldn't find the culprit myself unfortunately.
Why is it important?
Because when you are trying to see the result of automated tests and they are delayed, it is really annoying.

I am very sorry to hear you are having issues with VS Code. I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!

Same


Added a sample pipeline and data for a testing the pipeline

This is the first titanic pipeline.  It was tested on CDAP Sandbox with the included titanic.csv file and executed successfully.

LGTM


Trivy: check if store is compatible with trivy before trying to run the scanner on images stored there

Already covered in https://github.com/project-zot/zot/pull/1034


*: Save Xenon's metadata to persistent storage. #406

What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #406
What this PR does?
Summary:
MySQL and Xenon mount the same volume but use different subpath.
     containers:
        - name: mysql
           volumeMounts:
              mountPath: /var/lib/mysql
              subPath: mysql
              ...
        - name: xenon
           volumeMounts:
              mountPath: /var/lib/xenon
              subPath: xenon

Xenon cannot see MySQL dir.
 kubectl exec -it sample-mysql-0 -c xenon -- ls /var/lib/
apk     misc    udhcpd  xenon

MySQL cannot see Xenon dir.
kubectl exec -it sample-mysql-0 -c mysql -- ls /var/lib/
alternatives  dnf        misc         mysql-keyring  rpm        systemd
dbus          games      mysql        portables      rpm-state
dhclient      initramfs  mysql-files  private        selinux

Special notes for your reviewer?

LGTM


MP-CNN Bugfixes and Improvements

Some bugfixes and improvements for MP-CNN. Results on SICK exceeds paper performance and results on MSRVID gets very close.

Fix bug in pooling - previously pooling kernel size for holistic conv output was specified incorrectly - and code would crash if number using a non-default number of holistic filters that's not 300
Results from infinite ws are now properly pooled
Ability to configure optimizer (Adam or SGD), patience, learning rate reduce factor after plateau

SICK dataset

Implementation and config
Pearson's r
Spearman's p

Paper
0.8686
0.8047

PyTorch using README config
0.8763
0.8215

MSRVID dataset

Implementation and config
Pearson's r

Paper
0.9090

PyTorch using README config
0.9050

@Impavidity please review?

LGTM.


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc9 in position 0: invalid continuation byte

Crash Report
This crash report was reported through the automatic crash reporting system 🤖
Traceback
  File "/usr/local/Electron-Cash-3.1.6/lib/util.py", line 613, in run_with_except_hook
    run_original(*args2, **kwargs2)
  File "/usr/local/Electron-Cash-3.1.6/lib/interface.py", line 233, in run
    socket = self.get_socket()
  File "/usr/local/Electron-Cash-3.1.6/lib/interface.py", line 139, in get_socket
    s = self.get_simple_socket()
  File "/usr/local/Electron-Cash-3.1.6/lib/interface.py", line 103, in get_simple_socket
    l = socket.getaddrinfo(self.host, self.port, socket.AF_UNSPEC, socket.SOCK_STREAM)
  File "/usr/lib/python3.5/socket.py", line 733, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc9 in position 0: invalid continuation byte

Reporter
This issue was reported by 1 user(s):

Electrum Version
Operating System
Wallet Type
Locale

3.1.6
Linux-4.9.0-6-amd64-x86_64-with-debian-9.4
standard
fr_FR

Additional Information
The reporting user(s) did not provide additional information.

https://bugs.python.org/issue26227
This was fixed in Python > 3.5.1, from what I can tell from the cpython bug above.  Either this should be closed as noise, or we should enforce a minimum Python version in the code.

but the reporter is not on Windows? Linux-4.9.0-6-amd64-x86_64-with-debian-9.4

You're right, I missed that.  There are no fixes for this, for Linux, for 3.5.

Given that, I'd assume user error and bad data.


ORC-1291: Fix NPE in TypeDescription.hashCode() for primitive types

What changes were proposed in this pull request?
This PR aims to fix NPE in TypeDescription.hashCode() for primitive types.
Why are the changes needed?
To fix a regression at 1.8.0.
How was this patch tested?
Pass the CI with the newly added test case.

cc @williamhyun and @wgtmac

Thank you for approval and merging, @williamhyun !


Replace if/loop conditions dependency on input signals with ternary operator.

For compatibility with github.com/iden3/circom-witnesscalc.
Description
For now, circom-witnesscalc does not support input signals in the branch and loop conditions. I have replaced few such conditions with ternary operator that is supported by circom-witnesscalc. Now the witness for circuit https://github.com/zk-passport/openpassport/blob/main/circuits/circuits/register/register_rsa_65537_sha256.circom can be calculated using iden3/circom-witnesscalc.
The demo for this witness generation can be found in https://github.com/olomix/witnesscalc-tests repository. All commands required to install dependencies, generate witness and then validate it are specified in the ./run.sh script. It can be run from the repository directory and all dependencies would be installed locally inside this directory. Repository can be safely deleted afterward without any trash in the system. Everything script installs and generates are documented inside comments of this script.

Apparently removing the optimization in long div might be changing constraints, we should get the constraint count with and without these changes, and see how significant the difference is.


Mia isn't executing commands from discord users when DMed.

I brought this up a few times a while back, I'm assuming it got lost in chat so I will post it here, this way it lingers a bit longer. When DMing Mia, she should take messages such as /list or /seen and execute them as if they were done in a patched channel. In addition, saying "Shut up Mia" or "Thanks mia" does absolutely nothing anymore. This hasn't been working since september 24th.

This has since been patched, no longer an issue.


model registry: update MLOps diagrams

Based on previous feedback from:

https://github.com/kubeflow/website/pull/3698#issuecomment-2069810560
https://github.com/kubeflow/website/pull/3698#discussion_r1597274742

Reorganize diagrams as follows:

make MLOps inner Vs outer cycle smaller just to introduce the concept
re-use overall architecture diagram for Kubeflow introduced with https://github.com/kubeflow/website/pull/3728
2.a. use similar style from https://www.kubeflow.org/docs/components/training/overview/#why-training-operator- and adapt to highlight the Model Registry box

Quick demo:

This actualize the agreement from:

https://github.com/kubeflow/website/pull/3698#discussion_r1607299980

@StefanoFioravanzo @andreyvelich wdyt ?

I liked the diagram @tarilabs ! /lgtm

/hold for review

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

thanks! I'm starting to followup on received feedback which I didn't have bandwidth to act upon before.
It is a valid comment, even tho I'd say for the most past some components mainly push and occasionally pull (or viceversa) but I concur a bidirectional symmetric arrow might just be good enough, will do 👍

@StefanoFioravanzo with 8b3b40e revised as follows:

"Model Development" bidirectional: I can totally see the interactivity in both directions, especially during "inner loops" iterations
"Model Serving" the direction was mean to flow from Model Registry, to KServe

I've left the other arrows unchanged, since in those automated components I would expect the components to index/catalog the result into the Model Registry

All comments in this PR looks addressed to me,
and socialized this PR with all the folks who had original comments (links in first message) that this PR is meant to follow-up on--as agreed.
/remove-hold


[add] transmission: Session data metainfo plugin

Motivation for changes:
Add Transmission session data, such as global settings, to each entry.
Useful to filter based on transmssion settings.  For example, don't add
new entries to transmission when a download limit is enabled.
Detailed changes:
Not much to say here, it's pretty simple.  I copied the PluginTransmissionInput class and modified it to simply add the transmission session settings to each entry.  Working for me locally with the example from the docstring.
Config usage if relevant (new plugin or updated schema):
transmission_session:
  username: "myusername"
  password: "mypassword"
if:
  # Don't add items if downloading is paused
  - "transmission_speed_limit_down_enabled and transmission_speed_limit_down == 0":
      "reject"
  - "transmission_alt_speed_enabled and transmission_alt_speed_down == 0":
	    "reject"

Interesting idea, this is just metadata plugin and should be named as such. I see check_subs breaking the naming convention. Not that the convention is grest as is ...

this is just metadata plugin and should be named as such

I don't see any clear example of how I should name it, @paranoidi:
$ git --no-pager grep -n -e 'etadata' -- './flexget/plugins/**.py'

Can you clarify?

I see check_subs breaking the naming convention

I don't see check_subs in my changes.  Can you clarify?
Thanks!


Flash Attention 2 Output not Equal to PyTorch scaled_dot_product_attention in MusicGen Inference

I swapped out the Torch attention function for Flash Attention 2 in the MusicGen project here like so:
if self.memory_efficient:
    p = self.dropout if self.training else 0
    if _efficient_attention_backend == 'torch':

        x = torch.nn.functional.scaled_dot_product_attention(
        q, k, v, is_causal=attn_mask is not None, dropout_p=p)
        y = flash_attn_func(q, k, v, causal=attn_mask is not None, dropout_p=p)

        assert torch.allclose(x, y, atol=1e-5), "flash_attn_func and scaled_dot_product_attention are not equal"
    else:
        x = ops.memory_efficient_attention(q, k, v, attn_mask, p=p)

but the resulting tensors were not equal (my assertion halted execution) during inference like so:
import torchaudio
from audiocraft.models import MusicGen
from audiocraft.data.audio import audio_write

model = MusicGen.get_pretrained('melody')
model.set_generation_params(duration=8)  # generate 8 seconds.
descriptions = ['happy rock', 'energetic EDM', 'sad jazz']
wav = model.generate(descriptions)  # generates 3 samples.

for idx, one_wav in enumerate(wav):
    # Will save under {idx}.wav, with loudness normalization at -14 db LUFS.
    audio_write(f'{idx}', one_wav.cpu(), model.sample_rate, strategy="loudness", loudness_compressor=True)

Additionally ignoring the above significant divergence which affects model output, I also run into the following issue during inference
Number of heads in key/value must divide number of heads in query

Since num_heads stays at 1 but the k num_heads scales with the number of tokens in the context window.
However, I assume this will be solved by the forthcoming inference optimizations mentioned here.

The right comparison is
(FlashAttention in fp16/bf16 - standard attention in fp32) vs (standard attention in fp16/bf16 - standard attention in fp32).
What are the two differences ^^^ in your use case?

Sorry I'm not quite sure what you're hinting at. I'm comparing FlashAttention 2 FP16 vs Torch's Memory Efficient SDP Attention FP16.

I think for scaled_dot_product_attention you need to transpose the first and the second axes of qkv. It requires a different layout.

@tridao I've checked the differences you suggest, and they are of the same order as you thought they would.
Still could you explain where the difference between FlashAttention in fp16 and standard attention in fp16 is coming from?  Cheers

import torch.nn.functional as F

B = 1; T = 3; nh = 32; C = 64

# q = torch.arange(B * T *  nh * C).reshape([B, T, nh, C]).float();
# k = torch.arange(B * T *  nh * C).flip(dims=(-1,)).reshape([B, T, nh, C]).float();
# v= torch.arange(B * T *  nh * C).reshape([B, T, nh, C]).float() ** 1.5
q = torch.randn([B, T, nh, C])
k = torch.randn([B, T, nh, C])
v = torch.randn([B, T, nh, C])

out = F.scaled_dot_product_attention(q.permute([0, 2, 1, 3]).cuda(), k.permute([0, 2, 1, 3]).cuda(), v.permute([0, 2, 1, 3]).cuda(), dropout_p=0.0, is_causal=False).permute([0, 2, 1, 3])

import math
def func(q, k, v, use_causal=False):
    q, k, v = q.permute([0, 2, 1, 3]), k.permute([0, 2, 3, 1]), v.permute([0, 2, 1, 3])
    # attn = (q @ k.transpose([0, 1, 3, 2])) * (1.0 + math.sqrt(k.shape[-1]))
    attn = (q @ k) * (1.0 / math.sqrt(k.shape[-1]))
    if use_causal:
        attn = masked_fill(attn, self.causal_mask[:, :, :T, :T] == 0, float('-inf'))
    attn = F.softmax(attn, dim=-1)
    out = attn @ v # (B, nh, T, T) x (B, nh, T, c) -> (B, nh, T, c)
    out = out.permute([0, 2, 1, 3]) # (B, T, nh, c)
    return out

out2 = func(q.cuda(), k.cuda(), v.cuda(), use_causal=False)

print((out2 - out).abs().mean()) # about 0.3

I use torch.float32 in unit test and find the difference between normal attention and flash attention is about 0.3. I think the precision is enough, but the difference is large.  Could someone tell me why ?

With torch.float32 F.scaled_dot_product_attention does not call FlashAttention (only implemented for fp16 and bf16). You can ask in the Pytorch github.

should I be worried about the difference?


Compiler complains 'Model not quantized' on quantization-aware trained models

Hi, there!
I'm trying to port MobileBERT to EdgeTPU. It's 26MB after quantization (originally 96MB), so I guess I may be able to run it on 4~5 EdgeTPUs. However, the edgetpu_compiler reports Model not quantized on my quantized model.
This is how I converted the model:
converter = tf.lite.TFLiteConverter.from_saved_model('.')
converter.optimizations = [tf.lite.Optimize.DEFAULT]

quantized_tflite_model = converter.convert()
open('model.tflite', 'wb')

I downloaded the model here. Since the model contains FakeQuant ops, I guess it's trained using quantization-aware training.
BTW, do you think it's possible to run BERT models on EdgeTPUs? I'm afraid it may contain some unspported ops.
Thanks!

@fandahao17
I don't know too much about mobilebert (or bert) so I can't immediately tell if it would be fully supports, unfortunately.
Also, I guess the FakeQuant does indicates quant aware training but I still see int32 and float ops, could you give post training quantization a go?

Thanks for your rapid reply!
I inspected the converted .tflite file and found that it indeed isn't fully quantized. Thus, I guess it's a MobileBERT or tflite issue. Thanks!


Mono font rendering

Version of embedded-graphics in use (if applicable): 0.7
Target: simulator

Description of the problem/feature request/other
I've come to realize while trying to make precise calculations with text height, that the Mono font rendering size differs from what I expected.
I couldn't open the .raw font files but it seems to me that even using the baseline as a character height leaves a few pixes above, when rendering them.
Is there something I'm missing or haven't viewed that can shed some light on this issue?
Test case (if applicable)
use embedded_graphics::{
    mono_font::{ascii::FONT_10X20, MonoTextStyle},
    pixelcolor::Rgb555,
    prelude::*,
    text::Text,
};

use embedded_graphics_simulator::{OutputSettingsBuilder, SimulatorDisplay, Window};
use embedded_graphics::{ mono_font::{ascii::FONT_10X20, MonoTextStyle}}
fn main() -> Result<(), Box<dyn std::error::Error>> {
    let mut display = SimulatorDisplay::<Rgb555>::new(Size::new(320, 240));

    let font = FONT_10X20;
    let color = Rgb555::WHITE;
    let character_style = MonoTextStyle::new(&font, color);

    Text::new("1234567890", Point::new(0, font.baseline as i32), character_style)
        .draw(&mut display)
        .unwrap();
    Text::new("ABCDEFG", Point::new(130, font.baseline as i32), character_style)
        .draw(&mut display)
        .unwrap();

    let output_settings = OutputSettingsBuilder::new()
        .scale(3)
        .pixel_spacing(0)
        .build();

    Window::new("Text size check", &output_settings).show_static(&display);
}

The fonts are also included as PNG files in the repo: https://github.com/embedded-graphics/embedded-graphics/blob/master/fonts/png/ascii/font_10x20.png
You are correct that all glyphs in the ASCII subset have empty pixel rows at the top. But there are glyphs from other subsets, like Ź from https://github.com/embedded-graphics/embedded-graphics/blob/master/fonts/png/iso_8859_16/font_10x20.png which use the upper rows of the glyph bounding box.

Do you know which font sizes have how many pixels offset?
I'd like to make some precise calculations based on the font size so I have to take into account the empty rows for the ASCII subset.

No, I don't, this information isn't contained in the source BDF files. You will either need to count the empty pixels manually or write some code to determine the offset.

Sorry, my previous post wasn't correct. The BDF files contain the height of the uppercase letter: https://github.com/embedded-graphics/embedded-graphics/blob/7db5e737a366e26b37e56681bb5d3162c1e822cc/fonts/src/5x7.bdf#L29
With this information you should be able to calculate the necessary offset.

Ohhh. Ok, then at least the information is there! now I need to do a font that only takes this height into account.


Allow encrypted passwords

Description:
At the moment passwords and API keys are stored in plain-text in the configuration.yaml file. This PR is a RFC for the feature of encrypted/hashed passwords as opt-in.
Related issue (if applicable): Story
Example entry for configuration.yaml (if applicable):
http:
  api_password: $5$rounds=535000$PEN/g8jYEZT.81GW$SISbV67EfbJOITelNNeZUKZ/s6KY2rT3CjW5vW2diwB

The script script/gen_hash.py is a helper to created the needed hash. Only the http component is supported at the moment.
Checklist:

[ ] Local tests with tox run successfully.
[ ] TravisCI does not fail. Your PR cannot be merged unless CI is green!
[ ] Fork is up to date and was rebased on the dev branch before creating the PR.
[ ] Commits have been squashed.
If code communicates with devices:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

I think the idea of storing hashed passwords for http to be a good idea.
Some problems that I foresee is that both the remote instances API and the MQTT server need to be able to access the password. The problem here is that if we can decrypt a password we're pretty much giving a false sense of security. So that makes it pretty much impossible at this point.
This all should probably be part of a bigger overhaul to add a proper authentication layer. But I don't know how that would look right now.

For future reference, I think bcrypt is currently a better (more secure) way of hashing passwords than sha256, after reading a couple of blogs about the subject.

bcrypt is excellent for this, but so is sha256, albeit being more crackable by GPUs and custom ASIC attacks. FWIW, NIST suggests PBKDF2. All of these are quite good and considered very resistant to cracking.
For @fabaff it does seem like hashlib would be preferable over passlib however. @balloob is right there.

I switched to hashlib for the hashing. Sorry the title was misleading.
While an approach like Ansible Vault would add extra protection for sensitive data like password and API key it would make it hard to auto-restart Home Assistant without user interaction.

@fabaff I will be closing this PR in favor of the result of this discussion. It should make everything better https://community.home-assistant.io/t/migrate-http-stack-to-wsgi-based-framework/576


Does pytorch_lite work on iOS 12?

Based on this thread:
https://github.com/pytorch/pytorch/issues/102833

it is unclear whether LibTorch 1.13 actually works or not on iOS 12.

Two users say it is not working, but one user says it is working fine (see this post: https://github.com/pytorch/pytorch/issues/102833#issuecomment-1820125165).
the author of the above mentionned post also described the problem here: https://forums.swift.org/t/swift-concurrency-back-deploy-issue/53917/32

LibTorch 2.1.0, which has been released (I don't know where to grab it from?) does not seem functional on iOS 12, according to the same user.

For now I think will need someone with iOS 12 to test package to make sure if it works or not, I don't have an iOS device 😕


Adopt structure from poc

@usingtechnology @swcurran I reviewed what Jason put together in the POC repo and I think it's a great starting point for this repo. I'm sure we'll refine and adapt but I like having something to start with.
Any objections? @usingtechnology how would you like to move things over?

Awesome.  Jason, do you mind forking the new repo, copying the files over and doing a PR into the new repo?  That would probably be easiest.  Include things like any workflows (are there any?) and any .gitignore and the like settings.

Will do... no workflows in place there (yet).
I'll just seed it with the latest basicmessage_storage plugin from traction and get as up-to-date as I can.

We've got a structure in place. Thanks again @usingtechnology. Closing...


Bootstrap Django project

set up basic project
when navigation to root i should see the description of project, top right corner should be login button
clicking sign in should navigate me to /login

hi, I would be happy to help
just to be clear, Do you want it to use Bootstrap or pure CSS?

@Parham-Mehrabi bootstrap meant to basically start fresh project. I use Tailwind for CSS. Changes in master already.


Can't play games on mobile with Sprig Beta

When on a phone you don't have access to the buttons and stuff to play a game.
Current editor:

New editor:

OS: Android 13
Browser: Kiwi (Chromium)
Device: Pixel 6a

Is it on a specific deployment url or smth cause I still can't get the buttons :(


Remove trailing spaces from range check on UUID parser

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

Thanks! LGTM

LGTM

LGTM


Typo in readme

Just a small unimportant note: The third example has a typo:
    seg->setOpacity(128|

Thanks for pointing that out.  I’ll take a look and fix it.
Geoff Moehrke
@.***

On Apr 16, 2021, at 6:55 AM, Steffen @.***> wrote:
Just a small unimportant note: The third example has a typo:
seg->setOpacity(128|

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/gmoehrke/FastFX/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOZFQL64TLMSFUDYHGZPHHTTJAQUVANCNFSM43BMSVYQ.


[Bug]: Different Image Size support with Phi-3-Vision and torchvision dependency

Your current environment
I encountered a few issues while running phi-3-vision with the vllm built from current main branch.

Dependency:
torchvision is a dependency under image_processing_phi3_v.py
Currently it is only included in requirements-test.txt, not requirements-common.txt. But importing the image processor also needs torchvision be available during imports.

Different Image Size Support

I have built a vllm docker based on the latest main branch.
I have the following script to resize the stop_sign.jpg before sending to vllm API server.
python send_phi3v_request.py

import base64
import requests
import time
import random
import numpy as np  # To calculate the mean
import json
import os
from PIL import Image

# Parameters
num_iterations = 20  # Number of times to repeat the request

# To store latencies for each iteration
latencies = []
ttfts = []
output_processing_times = []
output_throughputs = []

# Function to encode the image
def encode_image(image_path):
  with open(image_path, "rb") as image_file:
    return base64.b64encode(image_file.read()).decode('utf-8')

def get_image_size(image_path):
    with Image.open(image_path) as img:
        # Get the dimensions
        width, height = img.size
    return width, height

def resize_image(image_path, sizes, output_dir):
    # Open the image
    with Image.open(image_path) as img:
        # Iterate over the desired sizes
        for size in sizes:
            # Resize the image
            width, height = img.size
            print(f"Image original size: {width, height}")
            resized_img = img.resize(size)
            # Create a file name for the resized image
            base_name = os.path.basename(image_path)
            name, ext = os.path.splitext(base_name)
            resized_img_name = f"{name}_{size[0]}x{size[1]}{ext}"
            resized_img_path = os.path.join(output_dir, resized_img_name)
            # Save the resized image
            resized_img.save(resized_img_path)
            print(f"Saved resized image: {resized_img_path}")

# Path to your image
image_path = "/home/changsu/images/stop_sign.jpg"
image_files = [image_path]

sizes = [(256, 256), (384, 384), (512, 512), (1024, 1024)]
output_dir = 'resized_images'
os.makedirs(output_dir, exist_ok=True)
resize_image(image_path, sizes, output_dir)

image_files = []
directory_path = "/home/changsu/resized_images"
for root, dirs, filenames in os.walk(directory_path):
    for filename in filenames:
        image_files.append(os.path.join(root, filename))

# Loop for the specified number of iterations
for _ in range(num_iterations):
    # Generate 96 lines with varying numbers of tokens
    # inputs = ["1 " * 256 for _ in range(num_lines)]
    for image_idx, image in enumerate(image_files):
        # Getting the base64 string
        base64_image = encode_image(image)

        payload = {
        "model": "/models/Phi-3-vision-128k-instruct",
        # "model": "/models/llava-v1.6-mistral-7b-hf",
        # "model": "/models/llava-v1.6-34b-hf",
        "messages": [
            {
                "role": "user",
                "content": [
                {
                    "type": "text",
                    "text": "What's the content of the image?"
                },
                {
                    "type": "image_url",
                    "image_url": {
                    "url": f"data:image/jpeg;base64,{base64_image}"
                    }
                }
                ]
            }
        ],
        "max_tokens": 300,
        "temperature": 0.0,
        "stream": True,
        }

        # metrics
        ttft = 0
        total_request_time = 0
        tokens_received = 0
        time_to_next_token = []
        generated_text = ""
        output_throughput = 0
        total_request_time = 0
        output_start_time = 0
        output_processing_time = 0

        # Start the timer
        start_time = time.monotonic()

        # Send the POST request
        response = requests.post(
            "http://localhost:8000/v1/chat/completions",
            # "http://localhost:9922/v1/chat/completions",
            headers={"Content-Type": "application/json"},
            json=payload,
            stream=True,
        )

Server Launch Command
docker run -tid --gpus \"device=0\" --shm-size 5g \
        -p 8086:8000 -v /mnt/data/models:/models \
        --ulimit nofile=65535:65535 \
        -v $(pwd)/entrypoint.sh:/entrypoint.sh \
        --entrypoint /entrypoint.sh \
        --name vllm-main-phi3-v-1gpu-p8086 \
        vllm:main-phi3-v \
        --tensor-parallel-size=1 \
        --model=/models/Phi-3-vision-128k-instruct \
        --image-input-type="pixel_values" \
        --image-feature-size=1921 \
        --image-token-id=32044 \
        --image-input-shape="1, 3, 1008, 1344" \
        --trust-remote-code # Need for Phi-3-vision only as its config needs to be loaded from HF model files

🐛 Describe the bug
To run the file, there would raise an error:
Traceback (most recent call last):
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 43, in _log_task_completion
    return_value = task.result()
                   ^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 550, in run_engine_loop
    has_requests_in_progress = await self.engine_step()
                               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 523, in engine_step
    request_outputs = await self.engine.step_async()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/engine/async_llm_engine.py", line 236, in step_async
    output = await self.model_executor.execute_model_async(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/executor/gpu_executor.py", line 117, in execute_model_async
    output = await make_async(self.driver_worker.execute_model
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/worker/worker.py", line 281, in execute_model
    output = self.model_runner.execute_model(seq_group_metadata_list,
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/worker/model_runner.py", line 749, in execute_model
    hidden_states = model_executable(
                    ^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/model_executor/models/phi3v.py", line 315, in forward
    inputs_embeds = self.vision_embed_tokens(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/vllm/lib/python3.11/site-packages/vllm/model_executor/models/phi3v.py", line 253, in forward
    hidden_states[positions[idx, 0],
RuntimeError: The expanded size of the tensor (1937) must match the existing size (2509) at non-singleton dimension 0.  Target sizes: [1937, 3072].  Tensor sizes: [2509, 3072]

Debugging Progress
Upon checking, I didn't see any resize done for images input to Phi-3-vision. See https://github.com/vllm-project/vllm/blob/main/vllm/model_executor/models/phi3v.py#L271. Is this intended?
I saw there is a resize in Llava-Next. And by doing something similar to https://github.com/vllm-project/vllm/blob/main/vllm/model_executor/models/llava_next.py#L94-L104, I was able to run my test script successfully.

cc @Isotr0py if you can take a look

vLLM hasn't fully supported dynamic shape image input yet. And we can add a patch to resize images temporarily.
Seems that #5276 can support dynamic shape image input if it's merged. Let's wait for it to be finished.


Multiple rate limiters using same key fail to behave as expected

Laravel Version: 10.1.5
PHP Version: 8.2.1
Database Driver & Version: Redis 6.x

Description:
Reopening https://github.com/laravel/framework/issues/45088 (closed because issue was originally filed under Laravel 8.x). This issue persists in Laravel 10.
Using multiple rate-limiters that use the same key does not work as expected. If the key is the same, only the first rate limiter is ever triggered.
Additionally, because both limiters use the same key, the count of remaining requests is decremented by the amount of times the same key is used.
Steps To Reproduce:
Define a simple rate limiter that returns an array of limits, using the same key.
RateLimiter::for('maps', function (Request $request) {
    return [
            Limit::perMinute(3)->by($request->ip()),
            Limit::perDay(30)->by($request->ip())
        ];
});

The above code will only apply the first limit, but the "Remaining" is decremented by two because both use the same key.

Can you try using different keys as a workaround?
RateLimiter::for('maps', function (Request $request) {
    return [
            Limit::perMinute(3)->by('per-minute:' . $request->ip()),
            Limit::perDay(30)->by('per-day:' . $request->ip())
        ];
});

Internally, the Rate Limiter uses the Cache Store to store its individual limiters, so I don't think a workaround is easy.
Maybe adding the $maxAttempts and $decayMinutes to the key limiter under the hood, could solve the problem.

@rodrigopedra Yes; I'm using that workaround (https://github.com/laravel/framework/issues/45088#issuecomment-1327623381) having just encountered the issue for the first time. If it's challenging to fix, it probably warrants a note in the docs; it took me quite some time to realize there was something framework-level happening.

This is expected right now and unfortunately there's no wat around this. We'd appreciate a PR to the docs.


626: e2e tests for update delete topics

[ ] Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "X" next to an item)

[x] No need to
[ ] Manually(please, describe, when necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings(e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct

also, backend didn't compile Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project kafka-ui-api: Compilation failure: Compilation failure:  Error:  /home/runner/work/kafka-ui/kafka-ui/kafka-ui-api/src/main/java/com/provectus/kafka/ui/mapper/ClusterMapper.java:[48,11] No property named "metrics.bytesOutPerSec" exists in source parameter(s). Did you mean "null"?...


Repo browser bug when repo is created after deadline

NoMethodError in Submissions#repo_browser
Steps to reproduce:

Create an assignment whose deadline has passed
Log in as a student and navigate to the assignment (to create the group)
Switch back to admin, and collect the assignment
Go to submissions view and click on the repo of the student whose repo folder was created after the deadline.

Here is the error
Showing /data2/markus/instance/test2015/app/views/submissions/repo_browser.html.erb where line #69 raised:
undefined method `[]' for nil:NilClass
Extracted source (around line #69):
67
68
69
70
71
72
    <% if @grouping.is_collected %>
       <%= "#" + @grouping.submissions.last.revision_number.to_s + " ( " +
<EMAIL_ADDRESS>{|rev| rev[:num] == @grouping.submissions.last.revision_number }).first[:date],
         format: :long_date) + " )" %>
    <% else %>
       <%= t('none') %>

I'm working on this, but if any of the people who have worked on this code have an obvious fix, please let me know.


Beginning code

I'm a beginner I need more hint to give me a good go ahead of 🏦

What is it you're looking for, sorry?

I’m a new beginner on git I need a mentorship I’m going to bring in more
business for us ?
On Mon, Oct 30, 2023 at 7:26 PM stellarpower @.***>
wrote:

What is it you're looking for, sorry?
—
Reply to this email directly, view it on GitHub
https://github.com/stellarpower/new_cast-Implementation/issues/1#issuecomment-1785808223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDJBVW2M64FQ6NLONLGVTKLYB7WLTAVCNFSM6AAAAAA6WCHP42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHAYDQMRSGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

This probably isn't the right repository for learning git then - maybe try this page here. Not sure how you came across it as I haven't touched this in ages, and I don't think anybody else has looked at recently, so would be interested how you ended up on this page :sweat_smile:

Thanks, I'll check it out.
On Mon, Oct 30, 2023 at 8:58 PM stellarpower @.***>
wrote:

This probably isn't the right repository for learning git then - maybe try this
page here https://docs.github.com/en/get-started/quickstart/hello-world.
Not sure how you came across it as I haven't touched this in ages, and I
don't think anybody else has looked at recently, so would be interested how
you ended up on this page 😅
—
Reply to this email directly, view it on GitHub
https://github.com/stellarpower/new_cast-Implementation/issues/1#issuecomment-1785942644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDJBVWZYZ4DOIHITDOICTQTYCABGFAVCNFSM6AAAAAA6WCHP42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHE2DENRUGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

You're welcome. Also I'd look for a git tutorial or something similar, but issues are used specifically for people's projects and managing those.


Unable to go get

The instructions say to use go get handler.emperror.dev/sentry.

Chances are this handler has never been migrated to the new package path concept (emperror.dev/handler/something).
I'll try to migrate it to the new structure tomorrow.

Should I open issues on the other handlers that haven't been updated as well? (Airbrake, Bugsnag, Rollbar, and Stackdriver all are like this)

Hm, I'm fairly sure that stackdriver is already updated, but the rest looks affected as well. I will update all of them.

Sorry it took so long. I've updated the remaining packages. Can you please test it? If it works, I'll tag new versions.

go get emperror.dev/handler/sentry works now. Thank you!


mds.load("pbmc10k_multiome") does not add files to uns

Hey,
attempting to follow the https://muon-tutorials.readthedocs.io/en/latest/single-cell-rna-atac/pbmc10k/2-Chromatin-Accessibility-Processing.html tutorial. Instead of downloading the data manually & preprocessing it like in the tutorial chapter before, I am getting the data with mudatasets like:
mdata = mds.load("pbmc10k_multiome")
The MuData object then looks like (might already be some scanpy filtering here, but not important):
MuData object with n_obs × n_vars = 11909 × 144978
  var:	'feature_types', 'gene_ids', 'genome', 'interval'
  2 modalities
    rna:	11909 x 36601
      var:	'gene_ids', 'feature_types', 'genome', 'interval'
    atac:	10069 x 106086
      obs:	'n_genes_by_counts', 'total_counts', 'NS'
      var:	'gene_ids', 'feature_types', 'genome', 'interval', 'n_cells_by_counts', 'mean_counts', 'pct_dropout_by_counts', 'total_counts'

However, with ac.pl.fragment_histogram(atac, region='chr1:1-2000000') I then run into:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/tmp/ipykernel_404935/4071406051.py in <module>
----> 1 ac.pl.fragment_histogram(atac, region='chr1:1-2000000')

~/miniconda3/envs/bp2/lib/python3.9/site-packages/muon/_atac/plot.py in fragment_histogram(data, region, groupby, barcodes)
    339         raise TypeError("Expected AnnData or MuData object with 'atac' modality")
    340
--> 341     fragment_path = adata.uns["files"]["fragments"]
    342     fragments = tools.fetch_regions_to_df(fragment_path=fragment_path, features=region)
    343

~/miniconda3/envs/bp2/lib/python3.9/site-packages/anndata/compat/_overloaded_dict.py in __getitem__(self, key)
     98             return self.overloaded[key].get()
     99         else:
--> 100             return self.data[key]
    101
    102     def __setitem__(self, key, value):

KeyError: 'files'

IMO this is either an issues with the served MuData object here or an unflexible implementation of fragment_histogram
What is the best solution here, @gtca ?
Thank you!

Oh wait, maybe I need one of with_info=True, full=True...

Yeah, that was indeed the issue. Sorry, me being naive :)


Incorrect mouse position when showing Excalidraw editor inside Dialog window

Bug description
Mouse is incorrectly capturing the position over components (and the start of arrows etc.) when the editor is shown inside the Dialog window (I use one from https://github.com/shadcn-ui/ui).
Steps to reproduce

Go to https://coursition.com/demo/excalidraw/edit
Add component Excalidraw
Open the editor
Use the editor and see that things behave "weirdly" about the mouse position - the arrow starts in another place, and you can't edit objects (like arrows, squares etc.) at their position but your mouse needs to be a bit below and to the right.
Resize the window so that the size of the Excalidraw window also changes (open DevTools => Mobile emulator => close DevTools).
Everything should work correctly.

Current outcome
Position of the mouse is fixed only after the window resizes.
Expected outcome
Position of the mouse is correct all the time.
Related bugs
I reported the same thing inside Novel - https://github.com/steven-tey/novel/issues/234 but there it is even worse because the position of the mouse is not fixed when I resize the window. Seems to be related to the calculation of coordinates.

So I went a bit more in-depth and it seems like the size of Excalidraw Window is calculated incorrectly.
Before window resize:

After window resize:

You can clearly see that the dimensions of the canvas element are now correct.

Hello ,I'm new to open source can you  assign this issue to me.

I can't, but maintainer of the repo could. Anyways it doesn't really matter, you can try to do it without assignment. It is better to start than wait. :)
@mause-01

Hey @BleedingDev thanks for opening up this issue. Could you maybe create a sandbox where the editor is embedded inside a dialog window?
https://docs.excalidraw.com/docs/introduction/development#code-sandbox

Hi @ryan-di, I will try it. :) My project is open source, so I could Link to it as well, but that is not minimal reproducible example.

I am not able to reproduce it in Code Sandbox. :/ Can I force Excalidraw to recalculate the size without changing the window size? Because consistently fixes it.

i'm seeing the same thing frequently, but it's hard to repro reliably.


Update README.md

prow tests

/test e2e

So made some progress on launching origin extended tests from a jenkins PR via ci-operator.  The changes to access Jenkins REST via an execpod are working.
We even have one passing test.
However, our pipelines are now failing with errors like not being able to find the oc embedded in the Jenkins instance:
[workspace] Running shell script
+ oc start-build openshift-jee-sample-docker --from-file=target/ROOT.war -n e2e-test-jenkins-pipeline-czkqm
<EMAIL_ADDRESS>line 2: oc: command not found

oc is something the jenkins image build injects into the image, injecting it into one of the directories in the path ... from what I see in the image build log, it seems we are injecting it where we usually do.
Will need to investigate the PATH variable that is created when the image is built via ci-operator, or other related factors, and look for any differences.
Also need to investigate all the failures, see if there is anything additional.
@bparees @smarterclayton @stevekuznetsov fyi ... and if something obvious to you comes in mind, of course chime in here.  Otherwise I'll report back when I have some findings.

Will need to investigate the PATH variable that is created when the image is built via ci-operator, or other related factors, and look for any differences.

yeah dumping the $PATH and also do and ls of the dir where you expect oc to be seem like reasonable next steps.  Since this command is part of a Jenkinsfile, i assume we're confident it's executing inside the jenkins container, right?

On Fri, Aug 3, 2018 at 2:35 PM Ben Parees<EMAIL_ADDRESS>wrote:

Will need to investigate the PATH variable that is created when the image
is built via ci-operator, or other related factors, and look for any
differences.
yeah dumping the $PATH and also do and ls of the dir where you expect oc
to be seem like reasonable next steps. Since this command is part of a
Jenkinsfile, i assume we're confident it's executing inside the jenkins
container, right?

yeah the command not found error came from pipeline job run output
It without question is in a jenkins

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/jenkins/pull/673#issuecomment-410340253,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADbadJP-y2yfNQtcZptm9SePTz6AgYayks5uNJfngaJpZM4VuDIe
.

So first, a correction in my description of how oc gets injected into the jenkins image.
Today, the jenkins image starts with "FROM openshift/origin" (for our centos image) and
"FROM registry.access.redhat.com/openshift3/ose" (for our rhel image)
We hence pick up the oc binary from those base images.  We no longer download
the oc archive, then extract and copy over.
The oc binary is at /usr/bin in these cases.
It also is present at /usr/bin in the "IMAGE_TESTS" image, based
on my tests with ci-operator and using a reduced form of cluster-e2e
template.  That test image is based on openshift/origin-v3.11:tests.
However, I added ls -lR dumps of /usr/libexec and /usr/bin in a debug
version of the Jenkins Dockerfile in the openshift/jenkins:gabemontero-patch-2
branch.
Sure enough, there is no oc to be found.
In my master.json config file for ci-operator, I'm current basing
my Jenkins image off of openshift/origin-v3.11:base
Looking at the tags in the openshift namespace on api.ci
I saw origin-v3.11:cli.
After switching to that, sure enough, the oc binary is
at the same /usr/bin location it was in the other examples.
I'll be crafting a PR momentarily.

/test e2e

(the jenkins image should include the oc binary now with the new master.json)

OK, test failed, but progressed to the next layer of the onion, now that oc is available.  The tests did get much further along.  Will start posting analysis / next steps as I uncover them.

The first type of error is trying to create a temp git repo for some of our build testing.  As part of that we call https://github.com/openshift/origin/blob/master/test/util/client.go#L35-L37, which is suppose to use the test namespace in creating the dir.
The Namespace() call is returning "integration" (typically the test namespaces are some form of random string) and then subsequent attempts to access the file fail:
stat /tmp/openshift-integration: no such file or directory

integration is the default name used after not finding any value for the env var OS_TEST_NAMESPACE
I do see in our extended builds controller compat test we explicitly set the env:  https://github.com/openshift/origin/blob/master/test/extended/builds/controller_compat.go#L25
My guess is this is a requirement for running ext tests either via the e2e framework, or on prow/gcp clusters, or some such.
Pending a course correction from someone, I'll craft a PR which sets that env var in the same fashion for the jenkins tests.

The second flavor of error is trying to access files based on the ARTIFACT_DIR env var.  It is missing in these runs.  The jenkins tests actually use this setting as part of its env var subtitution for some of the jobs it defines (things like NAMESPACE for example).
In investigating how it is set, it appears to be set in the various extended test scripts in the openshift/origin repo.  Those scripts are bypassed with our e3e templates, which invoke ginkgo and the extended.test binary directly.
I could again test for the value of ARTIFACT_DIR early in the tests and set if it is unset to the test templates well known location .... maybe explicitly setting ARTIFACT_DIR in the test template is another option.

Pending a course correction from someone, I'll craft a PR which sets that env var in the same fashion for the jenkins tests.

seems like this should be set more universally so other tests don't run into this down the road.

/test e2e

no more signs of the ARTIFACT_DIR complaint with the latest run, but the stat /tmp/openshift-integration: no such file or directory is still showing up.
Investigating.....

/test e2e

nope ... e2e failure same as before.
waiting on https://github.com/openshift/origin/pull/20563 to merge, and the openshift/origin-v3.11:test IST on api.ci to get subsequently updated

/test e2e

we have a successful e2e run against all the jenkins ext test in openshift/origin using the jenkins-2-centos:latest image built from this branch @bparees

@stevekuznetsov @smarterclayton fyi as well ... I got the e2e test for jenkins working with the latest run https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_jenkins/673/pull-ci-jenkins-e2e-canary/13/
thanks again for all the assistance


WIP: Add hosts data source

Hello @ddelnano,
this PR should solve #122.
This is still WIP. TODO: sorting
This commit also found a way into the PR.
Should I revert it? Or just resolve conflicts?

Before you edited the PR description you mentioned that there was a bug in #120? That was released in v0.15.0 but I forgot to put it in the release notes (which are updated now).

Should I revert it? Or just resolve conflicts?
Whatever is easiest. I'm not too opinionated about it since when it's ready we will squash and merge the PR.

Thanks @ddelnano. Tested your branch and cherry-picked into this PR. Error seems to be fixed 👍🏽
I may switch to client side filtering and add some sorting to this.
After that this should be ready to merge.

@gohumble apologies for missing your latest updates. I'll try to give this a look tomorrow.

@ddelnano never mind. Just added sorting. Faced some issues when trying to filter on the client side. So I kept the server side filtering. Maybe you have a clue on that. Have tested this within my development branch. Seems to work just fine.
Still WIP because i wanted to test this a little more and still have to add some docs.

I think we should close this PR in favor of #142. I took this branch as a base and improved the acceptance tests. Thank you so much for all your work on this and I would appreciate of review of the other PR.


[Bug] Toolbar and hotkeys bugs

Describe the Bug

[ ] https://github.com/OHIF/Viewers/issues/3831
[ ] https://github.com/OHIF/Viewers/issues/3848
[ ] https://github.com/OHIF/Viewers/issues/3896
[ ] https://github.com/OHIF/Viewers/issues/3200
[ ] https://github.com/OHIF/Viewers/issues/3947

There seem to be various bugs that are related to the toolbar, and hotkeys.
Basically the requirements are
There should be 3 types of tools/icons that we support in the toolbar: Toggles, Actions, Tools
There are bugs regarding toggles states and nested menu behaviour which I will explain next.
Toggles

Toggles (they have on and off state e.g., imageSync, referenceLines, CINE player etc.)
should be able to run by ON or OFF state by default, e.g., should be able too choose to run the viewer with references lines on (issue reported here) and here)
They can live on the toolbar as primary or secondary (nested)
Upon user interaction (either mouse/touch click or hotkeys) they should show a different ON state color (as we do have for reference lines for instance)

Current Bugs for Toggles:

Go to here
On the right most menu, click on the dropdown
Click on a toggle (e.g., reference lines, CINE player works fine for some reason)
see the window level tool is lost and the user cannot window level by mouse primary
Correct behaviour: The reference line toggle should not affect the mouse primary as it is only toggle of an state

pretty sure this bug is in setToolActive in the commandsModule
Fixed in https://github.com/OHIF/Viewers/pull/3961

Nested Menu wrong behaviour for actions

Select rectangle on the right most menu (nested)
Then select the rotate right
See now the rotate right is highlighted
Correct behaviour: should not be highlighted, only put on the top, highlight light blue should be associated with only active tool

Fixed in https://github.com/OHIF/Viewers/pull/3961
Nested Menu wrong behaviour for toggles

Select rectangle on the right most menu (nested)
create 1x2 layout
Then select reference line tool
See it moves the reference lines to the top with correct color (dark blue)
click on the reference lines (which is now in top) again
see the color does not change but the functionality becomes toggled
If you do the same thing with image overlay, it should get turned off and become the top (since its default is on), but it wrongfully stays as ON as dark blue highlight

Fixed in https://github.com/OHIF/Viewers/pull/3961

Hotkeys
Hotkeys are not connected to the toolbar
Easy case

Hit Z on the keyboard
see zoom is now on mouse primary
see the zoom icon is not set properly and still window level is highlighted

Harder case

Hit R on the keybaord
see the image rotates
the toolbar does not change any state
Correct behaviour: Should detect there is a rotate right on the last nested icons, and bring that to the top, ideally it should flashes/highlights that as a user interaction too

What would happen if there is a active tool in the nested menu, and the hotkey for another nested icon is clicked?

Again I think we should priotize the user intend which is the lastes

Minor Details
Dropdowns should not hide the primary tool

If you click on any item on the dropdown it correctly moves to the top but it get disappeared from the dropdown for some reason which is weird.
Fixed in https://github.com/OHIF/Viewers/pull/3961
Steps to Reproduce
s
The current behavior
s
The expected behavior
Toggle Improvements
Separate State from Interaction: Ensure that toggling a feature only changes its on/off state, not other tool interactions.
Configurable Defaults: Add startup settings so users can preset which toggles should open in an "on" state by default.

Nested Menu Logic
Action vs. Tool Prioritization: Nested actions should not override active tools unless clearly intended by the user. Clicking a tool in a nested menu should both execute it and prioritize it visually.

Visual & Hotkey Alignment
Update Highlighting: When a hotkey changes the active tool, the toolbar visuals must change in tandem.
OS
s
Node version
s
Browser
s

@sedghi , I don't follow above exactly.  It seems like this work is trying to address this bug (#3911 ) also.  I have assigned someone to look at  #3911 internally.    Please let me know if there is overlap.

@wayfarer3130 Do you have anything in progress to solve some of these by any chance that Ibrahim can take over?

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.


Link Multiple Auth Providers to a Firebase Account

Basic Information
Auth providers create duplicate Firebase account

[ ] Link the auth providers

Other Information
https://firebase.google.com/docs/auth/web/account-linking
Potential scopes:

I think that we first need to create users in firestore, and then allow users to link their external authentication methods to their user. Might need a signup page, where they create an account, and use their external auth
Leaving this issue for now until we have the users set up in firestore

I think that we first need to create users in firestore, and then allow users to link their external authentication methods to their user. Might need a signup page, where they create an account, and use their external auth
Leaving this issue for now until we have the users set up in firestore

Now that I understand better about which UID we're using, I think I have all I need to get started


Can you add borders between Columns / Rows and around Headers on a table?

Problem

I would like to add more formatting to a table - such as borders around columns and header so that it is easier to read.  Is this possible? From what i see thats only possible in a Block.
Solution

Alternatives

Additional context

I made this work-around with manually computed rectangle locations.

I hope it helpful when this requested enhancement is not yet available.


Staging dev

Description
Step 3 in the plan described in #377. To be merged only after #379 and after checking that deployments ID don't change for any of the affected networks

I just deployed on my side and all Subgraphs got the same IDs:
Arbitrum:

https://thegraph.com/hosted-service/subgraph/mendesfabio/balancer-arbitrum-v2
https://thegraph.com/hosted-service/subgraph/balancer-labs/balancer-arbitrum-v2-beta

Polygon:

https://thegraph.com/hosted-service/subgraph/mendesfabio/balancer-polygon-v2

https://thegraph.com/hosted-service/subgraph/balancer-labs/balancer-polygon-v2-beta

Gnosis:

https://thegraph.com/hosted-service/subgraph/mendesfabio/balancer-gnosis-v2
https://thegraph.com/hosted-service/subgraph/balancer-labs/balancer-gnosis-v2-beta

Goerli:

https://thegraph.com/hosted-service/subgraph/mendesfabio/balancer-goerli-v2
https://thegraph.com/hosted-service/subgraph/balancer-labs/balancer-goerli-v2-beta

BNB:

https://thegraph.com/hosted-service/subgraph/mendesfabio/balancer-bnb-chain-v2
https://thegraph.com/hosted-service/subgraph/balancer-labs/balancer-bnbchain-v2-beta


[T2A2][T16-A1]WU MENGCI

Ready for review:
[LO-Collections]
[LO-Enums]
[LO-Refactor]
[LO-MethodAbstraction]

Avoid accumulating unrelated changes into a single PR.
Tip: If you are currently on branch1 and want to create a new branch2, you need to switch back to master branch before creating branch2. If not, changes in branch1 will appear in the PR created from branch2 later.
@wmc0098 some comments added; please take a look.
please close the PR once you have noted the suggestions.


ngif not working in template

Hi again,
I want to use template in cell. I need to use ngif but it not working. the Template is in the html component file and it look like this :
<template #cellTpl let-column="column" let-row="row" let-value="value" let-i="index">     <div *ngif="column.wa_status != undefined && column.wa_status == 1" class="cell-status-1">         {{value}}     </div>     <div *ngif="column.wa_status != undefined && column.wa_status == 2" class="cell-status-2">         {{value}}     </div>     <div *ngif="column.wa_status != undefined && column.wa_status == 3" class="cell-status-3">         {{value}}     </div>     <div *ngif="column.wa_status != undefined && column.wa_status == 4" class="cell-status-4">         {{value}}     </div> </template>
Chrome log this error :
`Unhandled Promise rejection: Template parse errors:
Can't bind to 'ngif' since it isn't a known property of 'div'. ("
<template #cellTpl let-column="column" let-row="row" let-value="value" let-i="index">
<div [ERROR ->]*ngif="column.wa_status != undefined && column.wa_status == 1" class="cell-status-1">
{{valu"): MdsapDatatableComponent@17:9
Property binding ngif not used by any directive on an embedded template. Make sure that the property name is spelled correctly and all directives are listed in the "directives" section. ("
...
`
regards,

use *ngIf instead of *ngif
18 lis 2016 5:08 PM "jibhey"<EMAIL_ADDRESS>napisał(a):

Hi again,
I want to use template in cell. I need to use ngif but it not working. the
Template is in the html component file and it look like this 👍
<template #cellTpl let-column="column" let-row="row" let-value="value"
let-i="index"> <div *ngif="column.wa_status != undefined &&
column.wa_status == 1" class="cell-status-1"> {{value}}  <div
*ngif="column.wa_status != undefined && column.wa_status == 2"
class="cell-status-2"> {{value}}  <div *ngif="column.wa_status !=
undefined && column.wa_status == 3" class="cell-status-3"> {{value}}
 {{value}}
Chrome log this error :
`Unhandled Promise rejection: Template parse errors:
Can't bind to 'ngif' since it isn't a known property of 'div'. ("
<template #cellTpl let-column="column" let-row="row" let-value="value"
let-i="index">
]*ngif="column.wa_status != undefined && column.wa_status ==
1" class="cell-status-1">
{{valu"): MdsapDatatableComponent@17:9
Property binding ngif not used by any directive on an embedded template.
Make sure that the property name is spelled correctly and all directives
are listed in the "directives" section. ("
...
`
regards,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/swimlane/angular2-data-table/issues/295, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADUVbInQPSS_sTCDW4F9EqI2Gsn68IqXks5q_c2PgaJpZM4K2pO7
.

ooh ! ok, bad mistake after a long working day. sorry for this :)

so @jibhey  please close issue


Issue with running latest version 0.11.0 on Rails with puma clustered mode (killed thread rule_poller)

Steps to reproduce:
gem install rails -v 2.5.1
rails new ~/xray-app
cd ~/xray-app
echo "gem 'aws-xray-sdk', require: ['aws-xray-sdk/facets/rails/railtie']"  >> Gemfile
bundle install
echo 'workers 2' > config/puma.rb

$ bundle exec rails server
=> Booting Puma
=> Rails 5.2.1 application starting in development
=> Run `rails server -h` for more startup options
[2204] Puma starting in cluster mode...
[2204] * Version 3.12.0 (ruby 2.5.1-p57), codename: Llamas in Pajamas
[2204] * Min threads: 0, max threads: 16
[2204] * Environment: development
[2204] * Process workers: 2
[2204] * Phased restart available
[2204] * Listening on tcp://localhost:3000
[2204] Use Ctrl-C to stop
[2204] - Worker 0 (pid: 2245) booted, phase: 0
[2204] - Worker 1 (pid: 2246) booted, phase: 0
2018-10-05 17:46:50 +0200: Rack app error handling request { GET / }
#<ThreadError: killed thread>
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/rule_poller.rb:16:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/rule_poller.rb:16:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/lead_poller.rb:24:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:33:in `block in start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:31:in `synchronize'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:31:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:43:in `sample_request?'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/facets/helper.rb:36:in `should_sample?'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/facets/rack.rb:30:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/railties-5.2.1/lib/rails/engine.rb:524:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/configuration.rb:225:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:658:in `handle_request'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:472:in `process_client'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:332:in `block in run'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/thread_pool.rb:133:in `block in spawn_thread'
2018-10-05 17:46:51 +0200: Rack app error handling request { GET /favicon.ico }
#<ThreadError: killed thread>
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/rule_poller.rb:16:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/rule_poller.rb:16:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/lead_poller.rb:24:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:33:in `block in start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:31:in `synchronize'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:31:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/sampling/default_sampler.rb:43:in `sample_request?'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/facets/helper.rb:36:in `should_sample?'
/usr/local/lib/ruby/gems/2.5.0/gems/aws-xray-sdk-0.11.0/lib/aws-xray-sdk/facets/rack.rb:30:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/railties-5.2.1/lib/rails/engine.rb:524:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/configuration.rb:225:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:658:in `handle_request'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:472:in `process_client'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:332:in `block in run'
/usr/local/lib/ruby/gems/2.5.0/gems/puma-3.12.0/lib/puma/thread_pool.rb:133:in `block in spawn_thread'
^C[2204] - Gracefully shutting down workers...
[2204] === puma shutdown: 2018-10-05 17:46:56 +0200 ===
[2204] - Goodbye!
Exiting

It looks like once you enable clustered mode (worker setting in Puma) the background thread for polling sampling rules is being killed unexpectedly.

Hi, thank you four reporting the issue. I'm able to reproduce this based on steps you provided.
The issue here is that when Puma forks the worker process it only duplicates the master thread itself. Any background thread that is a child of the master is not carried to the worker. I'm able to fix this and run the multi-processing normally by having the RulePoller check and create the background thread on the flight.
We will release the fix soon. Please let me know if you have any concerns.

Hey @haotianw465, that sounds exactly like what we need 👍
Thanks for the explanation, that makes a lot of sense!

The issue is fixed in the patch release v0.11.1.


Delete McSniperPy

hey im done with the McSniperPy and got my Name but i wonder how to delete it and i found nothing on the web for it so please help me.

pip3 uninstall mcsniperpy

or pip uninstall mcsniperpy

or whatever prefix you used to install