fix: respect trailing semicolon setting for last statements

Problem
https://github.com/rust-lang/rustfmt/issues/5797 fixed the trailing_semicolon rule, allowing it only for the last expression in the block. The side-effect of this change is that such snippet
fn main() {
    println!("{}", greet());
}

fn greet() -> String {
    return "Hello, b!".to_string();
}

will not get formatted into
fn main() {
    println!("{}", greet());
}

fn greet() -> String {
    return "Hello, b!".to_string()
}

(notice the ; in the greet function), even though return is the last expression here. It's happening because the implementation of is_last_expr() additionally checks for the type of expression for some reason unknown to me https://github.com/rust-lang/rustfmt/blob/46e5f14ae2300967d57ab8d032f446c07e0ed415/src/stmt.rs#L74-L88
Solution
This PR fixes that by checking only the is_last field of the Stmt struct when deciding whether to emit the semicolon.
fn main() {
    println!("{}", greet());
}

fn greet() -> String {
    return "Hello, b!".to_string();
}

fn foo() {}
fn main() {
    return;
    foo()
}

➜  rustfmt git:(trailing-semicolon-last-stmt) cargo run --bin rustfmt -- --check -- ~/Projects/semicolon/src/main.rs
   Compiling rustfmt-nightly v1.7.0 (/Users/shekhirin/Projects/rustfmt)
    Finished dev [unoptimized + debuginfo] target(s) in 0.61s
     Running `target/debug/rustfmt --check -- /Users/shekhirin/Projects/semicolon/src/main.rs`
Diff in /Users/shekhirin/Projects/semicolon/src/main.rs:3:
 }

 fn greet() -> String {
-    return "Hello, b!".to_string();
+    return "Hello, b!".to_string()
 }

 fn foo() {}

As you can see, the example from the original PR is still not getting formatted, while the trailing comma for the last return statement gets removed.

Pending test case

Will probably be a little while before I'm able to review this, but I wanted to note that there's a semi related PR (https://github.com/rust-lang/rustfmt/pull/6149) that adds a new option to trailing_semicolon. It feels like this would be complimentary to that work, but I'm not 100% sure.


Feature request: Timer & import:Export

Feature request: Timer
Please add a timer and a way to import/export.

@cocoonkid can elaborate on what a timer is?


List of Challenges Made By Performance

With ability to delete

This is similar to challenges#index

This is no longer necessary. All the intended information can be found elsewhere


Sort keys in foam.core.JSON to get predictable cross-platform output

Why don't we already get predictable cross-platform output? Isn't the order dependent on the models, which are the same for all platforms?

Key order is notoriously un-spec'd on the web. I don't know whether all major browsers now, by implementation accident, do the same thing, but it certainly didn't used to be the case that they did.

Do you have a use-case where you specifically need this? It seems like people shouldn't be writing software which is fragile to the ordering of something that's specified to be unordered (although, V8 does order).

We have checked-in mini-databases that contain pretty-printed JSON (that we plan to move to pretty-printed FON). Re-gathering said data and writing it out should result in no diff, regardless of the browser/platform used to re-gather the data.

The current output will follow the order that the properties are declared
in the model, which will keep the output stable if you're not re-arranging
properties in the model.
On Wed, Jan 18, 2017 at 1:39 PM, Mark Dittmer<EMAIL_ADDRESS>wrote:

We have checked-in mini-databases that contain pretty-printed JSON (that
we plan to move to pretty-printed FON). Re-gathering said data and writing
it out should result in no diff, regardless of the browser/platform used to
re-gather the data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2-experimental/pull/207#issuecomment-273561907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHJP_cjEZpOi5bu4UO69UkleFzLXoe53ks5rTlxYgaJpZM4LmGN1
.

Oh this is not a model you're serializing, just some plain javascript
object.
Even still, it seems the only benefit of keeping the output stable is that
your diff's will look nicer if you are checking these values into source
control.  I'm not sure that's worth it.
On Wed, Jan 18, 2017 at 1:43 PM, Adam Van Ymeren<EMAIL_ADDRESS>wrote:

The current output will follow the order that the properties are declared
in the model, which will keep the output stable if you're not re-arranging
properties in the model.
On Wed, Jan 18, 2017 at 1:39 PM, Mark Dittmer<EMAIL_ADDRESS>wrote:

We have checked-in mini-databases that contain pretty-printed JSON (that
we plan to move to pretty-printed FON). Re-gathering said data and writing
it out should result in no diff, regardless of the browser/platform used to
re-gather the data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2-experimental/pull/207#issuecomment-273561907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHJP_cjEZpOi5bu4UO69UkleFzLXoe53ks5rTlxYgaJpZM4LmGN1
.

I discussed this with Kevin offline; he feels okay with this on a default-false config parameter. I've pushed a change to reflect this strategy.


Code First migration creates table and throws already exists

We've made changes to code first context strategy with Azure Mobile Server API to work with multiple database instances each acting as a tenant. You can read below what we've done to context and configuration.cs hoping we'll achieve it but the problem is that when an endpoint on the api's TableController is accessed and the migrations are run at run time, we see an exception that says the migration we're applying already exists which in fact was created and then it throws exception describing it already exists.
Exception message: Column names in each table must be unique. Column name 'LeadType' in table 'dbo.Customers' is specified more than once.
Stack trace:   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at System.Data.Entity.Infrastructure.Interception.DbCommandDispatcher.<NonQuery>b__0(DbCommand t, DbCommandInterceptionContext`1 c)
   at System.Data.Entity.Infrastructure.Interception.InternalDispatcher`1.Dispatch[TTarget,TInterceptionContext,TResult](TTarget target, Func`3 operation, TInterceptionContext interceptionContext, Action`3 executing, Action`3 executed)
   at System.Data.Entity.Infrastructure.Interception.DbCommandDispatcher.NonQuery(DbCommand command, DbCommandInterceptionContext interceptionContext)
   at System.Data.Entity.Internal.InterceptableDbCommand.ExecuteNonQuery()
   at System.Data.Entity.Migrations.DbMigrator.ExecuteSql(MigrationStatement migrationStatement, DbConnection connection, DbTransaction transaction, DbInterceptionContext interceptionContext)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatementsInternal(IEnumerable`1 migrationStatements, DbConnection connection, DbTransaction transaction, DbInterceptionContext interceptionContext)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatementsWithinTransaction(IEnumerable`1 migrationStatements, DbTransaction transaction, DbInterceptionContext interceptionContext)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatementsWithinNewTransaction(IEnumerable`1 migrationStatements, DbConnection connection, DbInterceptionContext interceptionContext)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatementsInternal(IEnumerable`1 migrationStatements, DbConnection connection, DbInterceptionContext interceptionContext)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatementsInternal(IEnumerable`1 migrationStatements, DbConnection connection)
   at System.Data.Entity.Migrations.DbMigrator.<>c__DisplayClass30.<ExecuteStatements>b__2e()
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.<>c__DisplayClass1.<Execute>b__0()
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute[TResult](Func`1 operation)
   at System.Data.Entity.SqlServer.DefaultSqlExecutionStrategy.Execute(Action operation)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatements(IEnumerable`1 migrationStatements, DbTransaction existingTransaction)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteStatements(IEnumerable`1 migrationStatements)
   at System.Data.Entity.Migrations.DbMigrator.ExecuteOperations(String migrationId, VersionedModel targetModel, IEnumerable`1 operations, IEnumerable`1 systemOperations, Boolean downgrading, Boolean auto)
   at System.Data.Entity.Migrations.DbMigrator.AutoMigrate(String migrationId, VersionedModel sourceModel, VersionedModel targetModel, Boolean downgrading)
   at System.Data.Entity.Migrations.DbMigrator.Upgrade(IEnumerable`1 pendingMigrations, String targetMigrationId, String lastMigrationId)
   at System.Data.Entity.Migrations.DbMigrator.UpdateInternal(String targetMigration)
   at System.Data.Entity.Migrations.DbMigrator.<>c__DisplayClassc.<Update>b__b()
   at System.Data.Entity.Migrations.DbMigrator.EnsureDatabaseExists(Action mustSucceedToKeepDatabase)
   at System.Data.Entity.Migrations.DbMigrator.Update(String targetMigration)
   at System.Data.Entity.MigrateDatabaseToLatestVersion`2.InitializeDatabase(TContext context)
   at System.Data.Entity.Internal.InternalContext.<>c__DisplayClassf`1.<CreateInitializationAction>b__e()
   at System.Data.Entity.Internal.InternalContext.PerformInitializationAction(Action action)
   at System.Data.Entity.Internal.InternalContext.PerformDatabaseInitialization()
   at System.Data.Entity.Internal.LazyInternalContext.<InitializeDatabase>b__4(InternalContext c)
   at System.Data.Entity.Internal.RetryAction`1.PerformAction(TInput input)
   at System.Data.Entity.Internal.LazyInternalContext.InitializeDatabaseAction(Action`1 action)
   at System.Data.Entity.Internal.LazyInternalContext.InitializeDatabase()
   at System.Data.Entity.Internal.InternalContext.GetEntitySetAndBaseTypeForType(Type entityType)
   at System.Data.Entity.Internal.Linq.InternalSet`1.Initialize()
   at System.Data.Entity.Internal.Linq.InternalSet`1.get_InternalContext()
   at System.Data.Entity.Infrastructure.DbQuery`1.System.Linq.IQueryable.get_Provider()
   at System.Linq.Queryable.Where[TSource](IQueryable`1 source, Expression`1 predicate)
   at AuthController.saveUserToken(Int32 userId, String accessToken, TenantDataCtx _dbContext) in C:\Users\Administrator\Source\Repos\app-api\Mobile.Api\Controllers\AuthController.cs:line 100

Tried to reproduce by
I have created a "AzureMobileApi" from template and made the same changes as our main API. The template comes with a "ToDoItem" entity data object. I've then made these changes to achieve multi tenancy:
In ToDoItemController:

		protected override void Initialize(HttpControllerContext controllerContext)
		{
			base.Initialize(controllerContext);
			var connectionStringBuilder = new System.Data.SqlClient.SqlConnectionStringBuilder();
			connectionStringBuilder.DataSource = "Server";
			connectionStringBuilder.InitialCatalog = "T1";
			connectionStringBuilder.UserID = "user id";
			connectionStringBuilder.Password = "password";
			var connectionString = connectionStringBuilder.ToString();

			var context = new MobileServiceContext(connectionString);
			DomainManager = new EntityDomainManager<TodoItem>(context, Request);
		}

               //Used for migrations using Add-Migration only
		public MobileServiceContext() : base("MS_TableConnectionString")
		{
		}

		public MobileServiceContext(string connectionString) : base(connectionString)
		{
			var migrationConfiguration = new Configuration();
			Database.SetInitializer(new MigrateDatabaseToLatestVersion<MobileServiceContext, Configuration>(true, migrationConfiguration));
		}

Testing this in a unit test by calling contextObject.ToDoItems.ToList();

Created the DB, Table and added migrations to the history table. The same doesn't work on the actual project and fails after creating the db from scratch, adding all the migrations up to date and then throws exception as mentioned above.
Further technical details
EF version: 6
Database Provider: (EntityFramework.SqlServer)
Operating system: (e.g. Windows 10)
IDE: (e.g. Visual Studio 2017 15.6)

@amythn04 The exception looks like the same database might be being migrated concurrently. How do you ensure that only one machine/process/thread is attempting to migrate any given database?

@ajcvickers would you please shed some light on how you figured there's more than one machine/process/thread attempting to migrate the db?
To answer your question: How do you ensure that only one machine/process/thread is attempting to migrate any given database?
We currently don't because we didn't consider that would be something we have to ensure. We'll come up with a strategy to do this which shouldn't be too difficult in our scenario. This, however, may not be the current problem source because we've only recently released to production and this was happening in UAT where there aren't those many users to truly have a concurrent db update on a single tenant.
With regards to the actual problem itself [when it occurred], we have fixed the issue in that specific case by deleting the migration entry for that specific change and dropped the columns that were causing the issue. When we ran again, we were able to get the migrations applied and the api was fine. Although the multi-tenant strategy we have implemented using EF6 code first provides a lot of operational ease, the fact that this may happen when we have large number of users does haunt us.
I would really love to find out what it actually causing this issue.

@amythn04 It's not that I figured that out. But attempting to create the same column twice is something that could happen if this was the case, and migrating from code on first use is a very common way to get into this situation, which is why its not recommended for most situations.
Beyond this, I don't know what might be causing this. We're likely going to need to be able to reproduce what you are seeing to be able to investigate fully.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


New exposed accessor functions

Added some accessors here and there to read values hidden at the moment. And added couple sugar accessors.

@vincenthz @NicolasDP @disassembler
https://github.com/input-output-hk/rust-cardano/pull/693#issuecomment-494574901


Is a class "Network" or "Grid" needed?

Description of the issue
A class called Network or Grid was proposed in #13, is it needed? If yes, what should be it's definition?
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every new entry in the ontology should have an annotation
[ ] classes should arise from concepts rather than from words
[ ] class or property names should follow the UpperCamelCase

@Bachibouzouk should I tick the workflow box or the person thats going to solve the issue?

@Bachibouzouk should I tick the workflow box or the person thats going to solve the issue?

I would leave it for the person assigned to this issue (the main point here is to highlight to people that a workflow exists :))

We have an ElectricalGrid with the definition:  "An electrical grid is an interconnected network for delivering electricity from producers to consumers.
Source: https://en.wikipedia.org/wiki/Electrical_grid"
Can we define a grid then just as "An interconnected network"?

This was also mentioned here to #36

grid: BFO: object with subclasses 'electricityGrid', 'gasGrid', etc
definition: assembly of systematically connected elements that can work as a supply system

I am not sure if grid is an object or object aggregate?!

thanks for the link, then I'm going to implement this


Error on website

I think something broken in your web that appear like this.
Appreciate your contribution.

Broken for me as well.

Love it, admin is fast on this, appreciate it so much.


Made cLightingThread own its callbacks

We do have a UniquePtr that should be used instead of the lengthy and underscore-y std::unique_ptr

I personally thing the project typedefs are a barrier to newcomers. At least with the std types every c++ project has them. But with our typedefs, they need to be learned specially for our project.

Merge or are you going to insist on UniquePtr.

I'm too soft :P


Dump config in project folder first time model is ran

When working with a lot of configurations it is convenient to get the complete config in a human-readable format in the project folder, which can be checked against the parameters given by the config itself.

Handled in https://github.com/directgroup/direct/commit/129dab0332e567b9d0edfe2b3eb02f0fd3678b7c. Can still have improvements by diffing the dictionaries. Suitable for now.

Will close this. The configuration is properly saved to the project directory, and during inference this file is loaded. Diff'ing configurations is an interesting topic, but perhaps the best way to keep track of results is to create a new config instead of changing one, and initializing the new model with the old.


gltfpack: export obj?

I know it isn't core to your project, but thought I would ask anyway, because it's an excellent app!
Looking at using this for gamedev 3D models, but having issues with the .glb/.gltf formats (converting them back to .obj via assimp, no texture and no UV's - not looking for support here).
Would it be possible to export the optimized mesh in obj format?
Possibly like a debugging mode, seeing the verts, uv, faces in text etc.
I guess the mtl file wouldn't need to be recreated as it would be the same.

Upon some reflection I think this is outside the scope of meshoptimizer/gltfpack.
Meshoptimizer is already providing algorithms that are easy to integrate. It should be fairly straightforward to build an .obj processing tool using it.
gltfpack is designed as an opinionated tool that optimizes glTF files. It does support .obj files as an input, the motivation there is primarily that some files are just not available other than in .obj format, so it's easier to test the tool if it supports .obj inputs. Additionally, .obj is a simple format and as such any .obj file can be represented reasonably well by glTF structures.
The reverse doesn't quite hold. To get from glTF scene structure back to .obj, you need to perform a set of simplifications to the structure to get back to the small subset that works in .obj. The indexing is different, and to optimize it for .obj output size you may want to process the indices in a different way than you do for glTF as glTF files are render-ready, so the structure is different. Quantization isn't representable in .obj so it needs to be disabled, which changes defaults based on output file format.
These could be mitigated by making a separate .obj to .obj processing pipeline. But gltfpack isn't designed for that, and .obj parsing code that exists there right now targets cgltf scene structures, so at this point we're past "maybe gltfpack can also output .obj files" and way into "maybe gltfpack can also have an independent .obj to .obj optimizer".
Plus .obj files aren't even efficient as a representation. Any pipeline that uses .obj -> gltfpack -> .obj would benefit from upgrading the tail of the pipeline to support .gltf.
Of course it's fine that existing tools like assimp can be inserted into the processing along with gltfpack to get here, but handling this in a first-class manner isn't aligned with the goals of this project.


fix: add missing prettyDOM export to typings file

exports prettyDOM from dom-testing-library in the
react-testing-library's typings file.

Fixes: #108

What:  adds an export for prettyDOM in react-testing-library's typing's file.
Why:  to prevent the Typescript compiler from erroring.

How:  an export line was added to the react-testing-library's typing's file.
Checklist:

[ ] Documentation - N/A
[ ] Tests - N/A
[x] Ready to be merged
[x] Added myself to contributors table

Not sure what's up with all those diffs in the README...

I think it may have to do with prettier or some other sort of markdown auto formatter. Recently I noticed another PR that changed all the bullet lists in markdown from using - to * as the bullet points, and now your PR is reverting that back.

:tada: This PR is included in version 3.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unnecessary images are not cached.

This is my code where the above bug occurs.
https://github.com/project-violet/violet/blob/dev/lib/pages/viewer/vertical_viewer_widget.dart
Whatever method I use, all images are live.
So the imageCache.clear(); function doesn't work.
I've erased the problematic functions and tested image.network, networkimage, and cachednetworkimage.
Using PaintingBinding.instance.imageCache.clearLiveImages(); works fine, but this doesn't seem to be the preferred solution.
I think https://github.com/flutter/flutter/issues/47378 is not my problem.
The only thing is that the images are not cached when the widget is disposed.

Hi @violet-dev
cached_network_image is a 3rd party plugin,
if the problem is specific for said plugin please open an issue in the dedicated github;
if you believe the issue is with flutter itself please provide
your flutter doctor -v,
your flutter run --verbose
and a minimal complete reproducible code sample that does not use 3rd party plugins
Thank you

This problem occurs intermittently for all image widget using imageprovider, such as image.network, networkimage, and cachednetworkimage.
First, I could solve this problem by calling ImageChache::evict directly.
This doesn't seem to be a fundamental solution. I will make a sample code later and post it.
[√] Flutter (Channel beta, 1.19.0-4.3.pre, on Microsoft Windows [Version 10.0.18362.900], locale ko-KR)
    • Flutter version 1.19.0-4.3.pre at C:\Dev\flutter
    • Framework revision 8fe7655ed2 (3 weeks ago), 2020-07-01 14:31:18 -0700
    • Engine revision 9a28c3bcf4
    • Dart version 2.9.0 (build 2.9.0-14.1.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at F:\android-sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = F:\android-sdk
    • Java binary at: F:\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at F:\Android\Android Studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
    • VS Code at C:\Users\rollrat\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.12.2

[√] Connected device (4 available)
    • SM N960N            • 28bc93d820057ece • android-arm64  • Android 9 (API 28)
    • AOSP on IA Emulator • emulator-5554    • android-x86    • Android 9 (API 28) (emulator)
    • Web Server          • web-server       • web-javascript • Flutter Tools
    • Chrome              • chrome           • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

Hi @violet-dev
Can you please provide your flutter run --verbose and a minimal reproducible code sample that does not use 3rd party plugins
Thank you


[Question] How to pass props to previous screen when back button pressed (or any other button)?

Version

react-native-router-flux v4.0.17

So I have a form on screen A and when I tap a button, screen B is opened, I fill some data and want to pass it back to screen A on pressing back or some Save button. How can this be achieved?

Try Actions.pop({refresh: DATA})

This is possible for a custom button, but how can I pass {refresh: DATA} when back in header is pressed?


tests: add test for bug 7264

Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:

Merged in #2059, thanks!


Appropriate fields are highlighted in case of errors

The "title" input fileld should be highlighted only when there is an error (e.g. empty field).
Other fields should be highlighted in case of errors.

I deleted the red outline and we are just using the alert that provided html just like below.


move style.js inside index.js

I would like to move style.js inside index.js.
Having it in a separate file doesn't add anything extra because:

it is not reused in any other files
the library is very small and all the style are applied to ModalSelector
I think it would make it easier the development process and the debugging from user that just have a peak from under node_modules

anyone against it?

While I'm also a proponent of simplicity, a monolithic file is counter productive for development.  As the project becomes more complex, a long single file is harder read and more difficult to optimize.  Styles in particular are a good separation of functionality for a separate file.  This also allows changes to a separate style file without polluting the code.

yes it's a trade-off,
the way I see it having a separate file is good for development (when there are many people contributing and the files get long)
but for users that want to take a look from the installed node_modules directory it is painful having the default style props in index.js and the relative style in a separate sheet.
Anyway I am happy to keep it separately.


Updating to Joel's latest PR for go-amqp that removes the session mux

@jhendrixMSFT , getting a failure with your latest patch, specifically when using websockets:
=== RUN   TestNewClientWithWebsockets
/home/ripark/src/_/sb-test-latest-go-amqp/sdk/messaging/azservicebus/client_test.go:110:
Error Trace:	client_test.go:110
Error:      	Received unexpected error:
(connlost): invalid protoHeader
Test:       	TestNewClientWithWebsockets

@richardpark-msft where can I find more info on the failing test?

@richardpark-msft I have a repro now, investigating...

@richardpark-msft fix applied, great catch.


How to send text input from user in realtime api? Docs aren't clear

I am completely confused.  How does one send text to the realtime API.  I understand how to using the raw Openai Realtime api, but can't get it working via livekit.

Good point - looking at the code I think text-only is not supported? But this would be perfect for testing as the audio is very costly! Any input from the maintainers?

we don't currently support text-only mode. however, it isn't necessary to use our OpenAI plugin in order to use the Realtime API within Agents — you can simply use Agents to orchestrate the jobs and then call OpenAI's API directly via the Realtime SDK.


[Bug]  Volume viewports not working on ios

Describe the Bug
Hello, how are you?
Volume viewports do not work on ios on any version of IOS 17.0 or higher

Steps to Reproduce

Go to any example that includes a volume viewport. e.g. https://www.cornerstonejs.org/live-examples/volumeannotationtools .

The current behavior
The images are not displayed and in the console you can see the following message.

The expected behavior
Make it work the same way it works on IOS 16.x.x or less.

OS
IOS 17.0 , 17.1.4 , 17.2,  17.4.1
Node version
18.13.0
Browser
Chrome 90+

I created this PR which would be good enough for a lot of use cases (except the PT Scaled data)
https://github.com/cornerstonejs/cornerstone3D/pull/1212


Migrate all development to Docker container

After some windows issues, migrate the development to docker container to ensure the same environment after deploy.

The docker file was created and tested.
The bot is running and the development ia based on a virtualenv inside the Arch Linux.
More tests will be implemented to fully migration to the Docker.


[CMO] In preparation -> Ready for dispatch / Changes in labels and their order

Also Change:
Type->Mode of Transport
Add Volume UoM:

Meters
Feet/inch

Weight UoM
-Kg/Tone
Weight
Destination Address
•	Country
•	PO box
•	City
•	Street
•	Building
Conditions:mandatory


Unable to build gtk+3-3.24.8 on Mac OS X Mojave

Issue description
Unable to build gtk+3-3.24.8 on Mac OS X Mojave
The build ends with 4 errors all due to the same missing symbol.
gdkwindow-quartz.c:2213:25: error: use of undeclared identifier 'NSWindowCollectionBehaviorFullScreenAllowsTiling'; did you mean 'NSWindowCollectionBehaviorFullScreenAuxiliary'?
                        GDK_QUARTZ_ALLOWS_TILING);
                        ^~~~~~~~~~~~~~~~~~~~~~~~
                        NSWindowCollectionBehaviorFullScreenAuxiliary
gdkwindow-quartz.c:2191:34: note: expanded from macro 'GDK_QUARTZ_ALLOWS_TILING'
#define GDK_QUARTZ_ALLOWS_TILING NSWindowCollectionBehaviorFullScreenAllowsTiling
                                 ^
/nix/store/r74pkmkah26ph78kw5wc4bb7sq87jfdh-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:97:5: note: 'NSWindowCollectionBehaviorFullScreenAuxiliary' declared here
    NSWindowCollectionBehaviorFullScreenAuxiliary NS_ENUM_AVAILABLE_MAC(10_7) = 1 << 8      // windows with this collection behavior can be shown with the fullscreen window.
    ^

It appears that the version of the AppKit framework in my nix store is from a version of OS X which doesn't include the symbol NSWindowCollectionBehaviorFullScreenAllowsTiling, whereas the version in /Library/Developer does.
$ diff -U 20 -wb /nix/store/r74pkmkah26ph78kw5wc4bb7sq87jfdh-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/NSWindow.h /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h

[...]
 typedef NS_OPTIONS(NSUInteger, NSWindowCollectionBehavior) {
     NSWindowCollectionBehaviorDefault = 0,
     NSWindowCollectionBehaviorCanJoinAllSpaces = 1 << 0,
     NSWindowCollectionBehaviorMoveToActiveSpace = 1 << 1,

     /* You may specify at most one of NSWindowCollectionBehaviorManaged, NSWindowCollectionBehaviorTransient, or NSWindowCollectionBehaviorStationary.  If unspecified, the
     NSWindowCollectionBehaviorManaged NS_ENUM_AVAILABLE_MAC(10_6) = 1 << 2,         // participates in spaces, exposé.  Default behavior if windowLevel == NSNormalWindowLev
     NSWindowCollectionBehaviorTransient NS_ENUM_AVAILABLE_MAC(10_6) = 1 << 3,       // floats in spaces, hidden by exposé.  Default behavior if windowLevel != NSNormalWindo
     NSWindowCollectionBehaviorStationary NS_ENUM_AVAILABLE_MAC(10_6) = 1 << 4,      // unaffected by exposé.  Stays visible and stationary, like desktop window

     /* You may specify at most one of NSWindowCollectionBehaviorParticipatesInCycle or NSWindowCollectionBehaviorIgnoresCycle.  If unspecified, the window gets the default
     NSWindowCollectionBehaviorParticipatesInCycle NS_ENUM_AVAILABLE_MAC(10_6) = 1 << 5,     // default behavior if windowLevel == NSNormalWindowLevel
     NSWindowCollectionBehaviorIgnoresCycle NS_ENUM_AVAILABLE_MAC(10_6) = 1 << 6,            // default behavior if windowLevel != NSNormalWindowLevel

-    /* You may specify at most one of NSWindowCollectionBehaviorFullScreenPrimary or NSWindowCollectionBehaviorFullScreenAuxiliary. */
+    /* You may specify at most one of NSWindowCollectionBehaviorFullScreenPrimary, NSWindowCollectionBehaviorFullScreenAuxiliary, or NSWindowCollectionBehaviorFullScreenNon
     NSWindowCollectionBehaviorFullScreenPrimary NS_ENUM_AVAILABLE_MAC(10_7) = 1 << 7,       // the frontmost window with this collection behavior will be the fullscreen win
-    NSWindowCollectionBehaviorFullScreenAuxiliary NS_ENUM_AVAILABLE_MAC(10_7) = 1 << 8      // windows with this collection behavior can be shown with the fullscreen window
+    NSWindowCollectionBehaviorFullScreenAuxiliary NS_ENUM_AVAILABLE_MAC(10_7) = 1 << 8,     // windows with this collection behavior can be shown with the fullscreen window
+    NSWindowCollectionBehaviorFullScreenNone NS_ENUM_AVAILABLE_MAC(10_7) = 1 << 9, // The window can not be made fullscreen when this bit is set
+
+    /*         You may specify at most one of NSWindowCollectionBehaviorFullScreenAllowsTiling or NSWindowCollectionBehaviorFullScreenDisallowsTiling, or an assertion will
+
+     The default behavior is to allow any window to participate in full screen tiling, as long as it meets certain requirements, such as being resizable and not a panel or
+    NSWindowCollectionBehaviorFullScreenAllowsTiling NS_ENUM_AVAILABLE_MAC(10_11) = 1 << 11,       // This window can be a full screen tile window. It does not have to have
+    NSWindowCollectionBehaviorFullScreenDisallowsTiling NS_ENUM_AVAILABLE_MAC(10_11) = 1 << 12      // This window can NOT be made a full screen tile window; it still may b
 } NS_ENUM_AVAILABLE_MAC(10_5);
[...]

Steps to reproduce
nix-shell -p gtk3
Technical details

system: "x86_64-darwin"
host os: Darwin 18.6.0, macOS 10.14.5
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.2.2
channels(pauls): "nixpkgs-19.09pre177248.ed1b59a98e7"
nixpkgs: /Users/pauls/.nix-defexpr/channels/nixpkgs

Can you try updating your channels?  I think this was resolved at some point in the last month. ed1b59a98e7 looks old

Updated, and looks to have been resolved. Thanks


feat: Refactor all code to use the Google Typescript Styling Guide

feat: Added gts formatter
fix: Refactored all code to use the Google Typescript Styling Guide

This pull request resolves issue #26


output parquet, unique zcta files, split output

make output more similar to zcta2county

momentarily we will not split the output xwalk


Fix PyYaml cython error

https://pypi.org/project/PyYAML/5.4.1/
try migrating to 6.0.2
https://github.com/DiamondLightSource/blueapi/pull/596#issuecomment-2312829659

nothing in the repo seems to reference the 5.4.1 version...

Collecting PyYAML (from blueapi==0.4.5a3.dev2+gb677a55b)
  Downloading PyYAML-5.4.1.tar.gz (175 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [54 lines of output]
      running egg_info
      writing lib3/PyYAML.egg-info/PKG-INFO
      writing dependency_links to lib3/PyYAML.egg-info/dependency_links.txt
      writing top-level names to lib3/PyYAML.egg-info/top_level.txt

      ```

      the CI error

the installation with specific override in pyproject.toml into "PyYaml>=6.0.2" takes ages

and it doesn't look like it would stop on its own after 7 minutes locally

nevermind, this PR should fix it
https://github.com/DiamondLightSource/blueapi/pull/607#pullrequestreview-2267954905


Parity process does not exit when closing app

goes with failing test as a bonus: https://github.com/ethereum/grid/commit/aa56eff4080f07da453d0bda12f647e38a14fb01

Poking around here... the proc does eventually successfully get killed (and reaches STOPPED state) if left alone for long enough to hit Parity's timeout:

So, that's encouraging, but waiting 5 mins between restarts is a pretty good buzzkill for prototyping standards. kill('SIGQUIT') (rather than 'SIGINT) does nuke the Parity proc and looks relatively clean from a UI perspective, but at the expense of not shutting down other processes (e.g. Geth) cleanly. Continuing down the rabbit hole...


refactor: Change let to const

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

感谢PR，合并分支需要指向 develop

时间有点久了，先关闭，可以重新提交一个，目标指向develop分支~


Add more html elements to the page.

At present, the page is very plain and boring.

Added as requested.


v2.1.0

Update workflow to play with external web better
Fix some issues
Update deps

Coverage decreased (-4.0%) to 88.413% when pulling 9d34da9f652df909fe97769c154da2fc590af63d on v2.1.0 into 7cdd22c725fec3f92c6d93c98adcbbbdfd8d5c7e on master.


Error using BatchInterceptor with browserInterceptors in browser environment.

Still getting the issue from here: https://github.com/mswjs/interceptors/pull/361#issuecomment-1455223410
Type 'readonly [FetchInterceptor, XMLHttpRequestInterceptor]' is not assignable to type 'readonly Interceptor<any>[]'.
  Type 'FetchInterceptor | XMLHttpRequestInterceptor' is not assignable to type 'Interceptor<any>'.
    Type 'FetchInterceptor' is not assignable to type 'Interceptor<any>'.
      Types have separate declarations of a private property 'symbol'.ts(2322)

import { BatchInterceptor } from '@mswjs/interceptors';
import browserInterceptors from '@mswjs/interceptors/presets/browser';

const interceptor = new BatchInterceptor({
  name: 'interceptor',
  interceptors: browserInterceptors,
});

This looks to be because the exports in package.json for "." does not include a browser config.
It should be something like this:
{
 // ...
  "exports": {
    ".": {
      "browser": {
        "types": "./lib/browser/index.d.ts",
        "require": "./lib/browser/index.js",
        "import": "./lib/browser/index.mjs",
        "default": "./lib/browser/index.js"
      },
      "types": "./lib/node/index.d.ts",
      "require": "./lib/node/index.js",
      "import": "./lib/node/index.mjs",
      "default": "./lib/node/index.js"
    },
    // ...
  },
  // ...
}

Hey, @steve-zhu-sh. Thanks for reporting this.
This is strange. We do have the browser export for the /presets/browser path:

(Modern) Export condition
CommonJS placeholder

Can you please make sure you're using the latest version of @mswjs/interceptors? Perhaps a version mismatch issue. If not, a reproduction repository would be the way forward to resolve this. Thanks.

Hi @kettanaito , the /preset/browser path does have the browser export, but the . path also needs a browser export, otherwise the definition for BatchInterceptor is not compatible with browserInterceptors. Since BatchInterceptor is imported from the . path.

Here's the entire exports change needed for clarity:
  "exports": {
    ".": {
+     "browser": {
+       "types": "./lib/browser/index.d.ts",
+       "require": "./lib/browser/index.js",
+       "import": "./lib/browser/index.mjs",
+       "default": "./lib/browser/index.js"
+     },
      "types": "./lib/node/index.d.ts",
      "require": "./lib/node/index.js",
      "import": "./lib/node/index.mjs",
      "default": "./lib/node/index.js"
    },
    "./ClientRequest": {
      "browser": null,
      "types": "./lib/node/interceptors/ClientRequest/index.d.ts",
      "require": "./lib/node/interceptors/ClientRequest/index.js",
      "import": "./lib/node/interceptors/ClientRequest/index.mjs",
      "default": "./lib/node/interceptors/ClientRequest/index.js"
    },
    "./XMLHttpRequest": {
      "browser": {
        "types": "./lib/browser/interceptors/XMLHttpRequest/index.d.ts",
        "require": "./lib/browser/interceptors/XMLHttpRequest/index.js",
        "import": "./lib/browser/interceptors/XMLHttpRequest/index.mjs",
        "default": "./lib/browser/interceptors/XMLHttpRequest/index.js"
      },
      "types": "./lib/node/interceptors/XMLHttpRequest/index.d.ts",
      "require": "./lib/node/interceptors/XMLHttpRequest/index.js",
      "import": "./lib/node/interceptors/XMLHttpRequest/index.mjs",
      "default": "./lib/node/interceptors/XMLHttpRequest/index.js"
    },
    "./fetch": {
      "browser": {
        "types": "./lib/browser/interceptors/fetch/index.d.ts",
        "require": "./lib/browser/interceptors/fetch/index.js",
        "import": "./lib/browser/interceptors/fetch/index.mjs",
        "default": "./lib/browser/interceptors/fetch/index.js"
      },
      "types": "./lib/node/interceptors/fetch/index.d.ts",
      "require": "./lib/node/interceptors/fetch/index.js",
      "import": "./lib/node/interceptors/fetch/index.mjs",
      "default": "./lib/node/interceptors/fetch/index.js"
    },
    "./RemoteHttpInterceptor": {
      "browser": null,
      "types": "./lib/node/RemoteHttpInterceptor.d.ts",
      "require": "./lib/node/RemoteHttpInterceptor.js",
      "import": "./lib/node/RemoteHttpInterceptor.mjs",
      "default": "./lib/node/RemoteHttpInterceptor.js"
    },
    "./presets/node": {
      "browser": null,
      "types": "./lib/node/presets/node.d.ts",
      "require": "./lib/node/presets/node.js",
      "import": "./lib/node/presets/node.mjs",
      "default": "./lib/node/presets/node.js"
    },
    "./presets/browser": {
      "browser": {
        "types": "./lib/browser/presets/browser.d.ts",
        "require": "./lib/browser/presets/browser.js",
        "import": "./lib/browser/presets/browser.mjs",
        "default": "./lib/browser/presets/browser.js"
      }
    }
  },

Hi @kettanaito, when you have the chance could you take a look at the comments above?

Hey, @steve-zhu-sh. Thanks for describing the issue and even proposing a fix!
I'm wondering if the error here isn't in having src/index.ts in the browser build's entries? I'd rather the browser bundle reused the root-level exports as those are meant to be environment-agnostic (if they aren't, that's a bug).
At the same time, I don't have the time to reorganize the entire exports right now so your solution should work as well. Let me give it a try.

Released: v0.25.12 🎉
This has been released in v0.25.12!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Hey, @steve-zhu-sh. Thanks for describing the issue and even proposing a fix!
I'm wondering if the error here isn't in having src/index.ts in the browser build's entries? I'd rather the browser bundle reused the root-level exports as those are meant to be environment-agnostic (if they aren't, that's a bug).
At the same time, I don't have the time to reorganize the entire exports right now so your solution should work as well. Let me give it a try.

I think with the build process (and export contract) you've selected, that isn't possible. Even if the root-level exports that you've implemented in TypeScript pre build step are environment-agnostic, since you've split the build into to different environments, it seems there could be things that potentially break that environment agnostic implementation. Since browser and node may have different levels of javascript support, as a contrived example, if you build node for es6 support, but the browser for es3, there could be different levels of transpilation required for the two builds even for the shared environment agnostic modules.
I think some other library authors may choose to build to the most recent version of ecmascript and let the library consumer handle transpilation. Or at least support node and let the consumer handle browser transpilation since the user probably needs to handle that anyway for their own code due to varying levels of browser support for the different versions of ecmascript.
tsup config reference:
import { Options, defineConfig } from 'tsup'

const nodeConfig: Options = {
  entry: [
    './src/index.ts',
    './src/presets/node.ts',
    './src/RemoteHttpInterceptor.ts',
    './src/interceptors/ClientRequest/index.ts',
    './src/interceptors/XMLHttpRequest/index.ts',
    './src/interceptors/fetch/index.ts',
  ],
  outDir: './lib/node',
  platform: 'node',
  format: ['cjs', 'esm'],
  dts: true,
}

const browserConfig: Options = {
  entry: [
    './src/index.ts',
    './src/presets/browser.ts',
    './src/interceptors/XMLHttpRequest/index.ts',
    './src/interceptors/fetch/index.ts',
  ],
  outDir: './lib/browser',
  platform: 'browser',
  format: ['cjs', 'esm'],
  dts: true,
}

export default defineConfig([nodeConfig, browserConfig])


Dynamic object keys question

I am trying to figure out the correct way to declare an object that has both static and dynamic properties. Am I doing this correctly? Or is there a different / better way?
type ObjectTypes = {
  exists: string;
  sometimesExists?: string;

  // If any other keys exist, they should follow this pattern:
  [field: string]: {
    some: number;
  };
};

const passes_flow1 = (): ObjectTypes => {
  return {
    exists: 'some string',
    other: {
      some: 123,
    },
  };
};

const passes_flow2 = (): ObjectTypes => {
  return {
    exists: 'some string',
  };
};

const fails_flow1 = (): ObjectTypes => {
  return {
    exists: 'some string',
    sometimesExists: 'other string',
    other: {
      some: 'should be a number',
    },
  };
};

console.log(passes_flow1());
console.log(passes_flow2());
console.log(fails_flow1());

(Linking issue https://github.com/gcanti/babel-plugin-tcomb/issues/100)

Closing since this issue hasn’t seen a lot of activity. Sorry about that 😣
Please reopen with a reproduction on https://flow.org/try if you are still having issues!

+1 - an example use case for dynamic keys could be a basic key/value store:
{
   id2342343: "ensure I'm a string",
   id3243424: "ensure I'm a string",
   id4232333: "ensure I'm a string"
}


Adds NewHTTPSubsegments

It's currently impossible to use a custom httptrace.ClientTrace with *xray.HTTPSubsegments because opCtx is not exported.
This PR adds a func NewHTTPSubsegments(opCtx context.Context) *HTTPSubsegments to allow people with already existing httptrace.ClientTrace to plug in AWS X-Ray.

@jeromegn , thank you for your fix and I already merge it into our branch. Close this thread.


the prgrm shuts down as soon as one enters an input after selecting a branch from the menu

the application shuts down as soon as one enters an input after selecting a branch from the menu

the application shuts down as soon as one enters an input after selecting a branch from the menu

We will we soon fixing this :)


Add support for wsl --restart option

Is your feature request related to a problem? Please describe.
Sometimes when WSL env starts lagging, nothing can beat a simple restart. Right now this is achieved by executing 2 commands: wsl --shutdown and then starting back up my Ubuntu.
Describe the solution you'd like
wsl --restart would simply achieve exactly above in a single step.
Describe alternatives you've considered
Alternative is doing this in 2 steps as described above or create user custom macro which achieves smth similar.
Additional context
None

Thanks for the suggestion, we are not planning on implementing this.


Create "Getting Started" page of asushares.com website.

There currently isn't much material for developers to easily make contributions. A "Getting Started" guide would be extremely helpful.

First draft is online at: https://www.asushares.com/technology/getting-started/


Known issues (please check here before opening an issue)

Note: If your error relates to CraftTweaker, please remember to include your CraftTweaker.log file, even if it seems unrelated.
#125 Special compatibility is required for the Harvest spell to work with Rustic crops, especially those on crop stakes or vines. Edit: Simple Corn and Tea, the Story have also been added to this list. Workaround: You will need to harvest these by hand, as otherwise the plants' growth is reset to 0 and no drops are given.
#208 Carrying multiple pouches introduces confusion to the spell system, as it generally checks the first pouch it encounters (generally in the Baubles slot, if installed) for herbs and then ignores any future pouches. If your herbs are split amongst multiple pouches, it may be confusing for you. Workaround: Make sure the pouch you want herbs to be drawn from is on your hotbar or otherwise before other pouches.
#211 Pyre HUD may sometimes not display properly. Workaround: The cause of the issue is still uncertain, so there is no workaround at this time.
#328 The mod Transmutation Alchemy causes a conflict with Runic Shears, preventing them from being used. Workaround: Uninstall Transmutation Alchemy.
#355 Roots particles (and other additive particles) lose all colour with some version of Electroblob's Wizardry. If you are experiencing this and looking for a cause, this may be the issue. (This was a stale issue and the root cause may have been fixed in the meantime).
No issue: a special compatibility mod is required in order to support Dynamic Trees. This affects saplings grown and causes the Wildroot Growth ritual to spawn some seeds.
No issue: (related to the above): the Spreading Forest ritual doesn't support Dynamic Trees and most likely will not support Dynamic Trees.

gonna close this isssue since it's quite outdated and most of its issues have been already fixed


[ci skip] adding user @jorisv

Hi! This is the friendly automated conda-forge-webservice.
I've added user @jorisv as instructed in #26.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #26

Welcome @jorisv !


fix typo in func comments

fix typo in func comments.
Signed-off-by: zhukj<EMAIL_ADDRESS>

LGTM

Current coverage is 54.55% (diff: 100%)

Merging #1861 into master will decrease coverage by 0.26%

@@             master      #1861   diff @@
==========================================
  Files           103        103
  Lines         17250      17250
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           9456       9410    -46
- Misses         6649       6700    +51
+ Partials       1145       1140     -5

Powered by Codecov. Last update fef7386...c3d624c

LGTM 👍

LGTM


How do I access the "source" object in Java?

I'm looking to run the following command in my Java handler():
if (event.source === 'serverless-plugin-warmup')
Is it possible?

It should be.
I don't use Java, but based on the examples like https://github.com/serverless/examples/blob/master/aws-java-simple-http-endpoint/src/main/java/com/serverless/Handler.java it seems that the event is your input which seems to typically be a Map<String, Object>.
So to get the source property you should do something like:
if (input.get("source").equals("serverless-plugin-warmup"))

maybe you need to cast input.get("source") to String.
Let me know if this helps.


libs.mm_utils: add validate_no_unexpected_input_fields

Codecov Report

Merging #49 into develop will decrease coverage by 0.32%.
The diff coverage is 20%.

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
- Coverage    71.48%   71.15%   -0.33%
===========================================
  Files           16       16
  Lines          782      787       +5
  Branches       106      108       +2
===========================================
+ Hits           559      560       +1
- Misses         177      181       +4
  Partials        46       46

Impacted Files
Coverage Δ

cl_sii/libs/mm_utils.py
34% <20%> (-1.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08568a0...3c68ba2. Read the comment docs.


Resonsive Blog post

Issue: #958
Screenshots

Please close this PR under GSSOC'24 Level 3

@mukilan2815 Adjust this gap like this in desktop view and then make it responsive again

You can take reference from this website I am attaching the link here - Dev.to website Desktop and responsive as well

need to remove that space in mobile layout ah?

@mukilan2815 did you complete this as well desktop?

Completed everything bro u can merge now

@mukilan2815 just for confirm did you update sync fork?

@mukilan2815 You are very delayed in replying. I am responding to all of your messages quickly, but by the way, I noticed that you did not make any changes to the desktop view as I mentioned earlier.

can u please explain me again. what are the things i need to do? I have made it responsive for mobile and i didnt make anything change in desktop view

can u please explain me again. what are the things i need to do? I have made it responsive for mobile and i didnt make anything change in desktop view. I am replying the message once i see it sorry for the delay bro..

Okay no problem @mukilan2815  do one last thing update sync fork and please resolve your conflict as well

Done everything

@mukilan2815 See here are the below changes which you made:
This is your deployment changes 👇

And the current deployment website 👇

Hope you understand the changes is made problem with desktop view please resolve this we need it as soon as possible

In mine the size  reduces right?

@mukilan2815 Look at the video below; I will provide voice instructions as well.

https://github.com/user-attachments/assets/76a5343a-f564-43a7-a6d8-bb08471bbe8f

Ok bro i got it i will update soon

Check it now bro

check it now bro

@mukilan2815 I apologize, but I need to close this pull request for now. Please don't be discouraged!


DEIS_DEPLOY_PROCFILE_MISSING_REMOVE broken

DEIS_DEPLOY_PROCFILE_MISSING_REMOVE was set to true in our controller (quay.io/deis/controller:v2.16.0) and it does not seem to clean up the Procfile processes from the deis api structure object.
After removing the process types from the Procfile and redeploying we still see them in the structure object:
...
    "structure": {
        "web2": 0,
        "worker": 2,
        "web": 1,
        "worker-two": 0
    },
...

EDIT: We tested it 4 times and deployed 4 times to make sure this was so.

Is there another way to remove the procfile types?

that is intended behaviour. The behaviour is you should not see any pods running in the cluster.

I see. Thanks!
We were thinking the processes should disappear from the API. What is the best way to remove those zombie processes from the deis-controller API then? Let's say we will never use web2 ever again. Is there a way we can make it disappear from the deis app api structure completely?

So the problem is that, the structure (processes) are not removed from the app object api call.
This is a problem because if you try to use structure object to send a subsequent API call to /scale endpoint, you would not be able to do it...
{    "detail": "Container type web2 does not exist in application" }

In the above scenario, we are using an API output from one API to feed into another dependent endpoint and it does not work. Thus, the Procfile variable should remove the process_types from the structure object of app if possible.


html lang parameter not changes when switch language

Hi,
<html lang="en">
persistance when you change language. any easy fix?
thanks

As far as I know, SvelteKit currently does not provide a simple solution for this (yet). So you could use this workaround using SvelteKit hooks...


Added httptrace support

Replaced http-trace with more tag and fixed the trace implementation.

Is this your first time contributing to a Google project? If so, could you please review and sign the Google CLA? https://cla.developers.google.com/ to sign.

Done, thanks

Thanks!


Could not resolve entry module "src/renderer/src/main/index.ts".

informations:

Mac OS 14.4.1

step:

clone the code;
yarn add better-sqlite3 and vue-slider-component;
yarn run dev

screenshot:

Hello! Thank you for using vutron template.
There was a known issue with the vite-plugin-electron module configuration that we are using.
We now have a fix that resolves this issue and has been merged into the master branch.
Could you please pull the new changes, or follow the fix below to see if it resolves the issue?
If the issue persists, please reopen this issue.
Manual workaround

Open vite.config.mts
add root option into (plugins -> electronPlugin -> vite) every each keys: root: resolve('.'),

Since I left the comment, I realized there was one more thing I should have added. I've updated the comment.
Regards,


[WIP] Add Media legend using the title typed by user

Description (required)
Fixes #1831
What changes did you make and why?
Tests performed (required)
WIP
Screenshots showing what changed (optional - for UI changes)
WIP

Hi @maskaravivek , I was wondering if we should create a feature branch for this due to the https://github.com/commons-app/apps-android-commons/issues/1831#issuecomment-575771417 blocker. So we can merge your PR when it's ready, but it won't go into master until #3222 is fixed. What do you think?

Is there any slack or community group link?

Hi @maskaravivek , I was wondering if we should create a feature branch for this due to the #1831 (comment) blocker. So we can merge your PR when it's ready, but it won't go into master until #3222 is fixed. What do you think?

Yes, sure @misaochan. To which branch should I base my PR?

@maskaravivek I just made https://github.com/commons-app/apps-android-commons/tree/media-legend from master, you can base on that one. :)
@prince-09 we don't use Slack, sorry. We do have a Hangouts community that you can request to join via https://hangouts.google.com/group/YAC3Cso3QPnGopM66

@misaochan Should I base my PR to structured-data instead of media-legend?

I don't think so, as it is a separate feature, right? The idea is that structured-data should be merged into master before media-legend is.

I think targetting structured data makes sense here from just glancing at the code

I have rebased my PR on the structured data branch.

Remind me to test this again when the SDC branch uploads work for me. :)

Once conflicts are fixed we can test and merge this. :)


Loading the assembly requires having reference to its interface-containing assembly as well

Describe the bug
The assembly containing the implementation for the contract (interface) can't be done without explicitly referencing
the assembly which contains the definition of the contract (interface)
To Reproduce
Steps to reproduce the behavior:

Using this version of the library '0.3.0'
Add breakpoint inside ``
Run Facade project from
https://github.com/godrose/netcore-load/tree/master
Hit localhost:32064/api/warehouse

Expected behavior
Call is handled successfully
Actual behavior
IWarehouseRepository implementation can't be located
Notes
Observe how reverting the changes from the commit godrose/netcore-load@d5e945c would fail the call.
This functionality also works in one of the old pre-release packages, 0.3.0-beta.36, for example.
Additional context
.NET Core 3.0, VS 2019, Test Explorer

There are two facade projects in your repro. I'm not exactly sure what I'm looking for.

@natemcmaster You're right. Use SomeAssembly.Facade as it's much clearer what's going on there.

I read the code and I'm still not 100% I understand what you're trying to do, but it appears to me that at least one problem is that you're creating a unique assembly loader per .dll here: https://github.com/godrose/netcore-load/blob/b09327732a891b174b83e9ef8e6c453a56abfc3f/Samples.Specifications.Server.Facade/Startup.cs#L26-L29
I think there may be a general misunderstanding here of how PluginLoader is supposed to be used. Generally, each plugin should be in a directory of its own with the plugin's dependency .dll's in that same directory. Easiest way to prepare a plugin is with dotnet publish. See https://github.com/natemcmaster/DotNetCorePlugins#the-host for a more detailed description.

@natemcmaster
So the general idea in my example is to have all plugins compiling in the same directory. It is the solution configuration which will decide whether the specific plugin is eventually built. This is useful for the cases where I would like to substitute implementations of a particular interface and test the app behavior.
I examined the example you provided within the link. It states that each assembly file indeed has its own loader
var loader = PluginLoader.CreateFromAssemblyFile(
                    pluginDll,
                    sharedTypes: new [] { typeof(IPlugin) });
                loaders.Add(loader);

So I don't really see how it's different from what I'm doing.
The question here is what happens if you use
var loader = PluginLoader.CreateFromAssemblyFile(
                    pluginDll,
                    config => config.PreferSharedTypes = true);
                loaders.Add(loader);

instead and remove the explicit reference to the project containing the IPlugin interface.
Will it still work? Should it?

The distinction I was trying to make was that 1 plugin = 1 plugin loader. There might be multiple assemblies per plugin, but you should still only use 1 instance of PluginLoader. The assembly you pass to PluginLoader is the "entry" assembly, also called the "default" assembly. All dependencies of the default assembly will be found and loaded by PluginLoader. Normally, the dependencies of the plugin sit in a directory next to the default assembly.
 PreferSharedTypes only handles sharing between the host and the plugin, not between multiple plugins, so this might be why
you're code is having trouble finding implementations of IWarehouseRepository.


refactor path generator

Fixes a bug in the recipe, which up until now staged the same (NorESM) file for all models.

@cisaacstern can we run any two of these recipes to see if they now actually produce the correct output? Sorry for missing this bug earlier.

/run recipe-test recipe_run_id=342

/run recipe-test recipe_run_id=343

/run recipe-test recipe_run_id=346


Expose list of in-progress operations

Feature discussion / request

Since our code relies heavily on asynchronous events, unit tests are not inherently aware of when all the background actions are done. In practice this sometimes results in fixture part of the tests trying to delete data that is still referenced from the data that is still in the process of being inserted from the previous test (e. g. audit kicks in which is of no benefit for the most of the tests)

If knex would somehow expose data about whether or not there are any active queries or inserts at this point, this would allow to implement client-side logic which would patiently wait for everything to wrap up before cleaning the data.

I'm not sure this is possible at all currently - does knex track unfinished operations at all or purely relies on event-based listeners?
I will be able to implement this functionality if it gets approved, but I would need some directions :).

Knex does not track on going queries, but it provides events so that you can track them. I don't think that bookkeeping should be implemented as knex core functionality (I have written various query / transaction timer statistics implementations using knex events for our projects).
Basically you just need to listen knex.on('query',...) and respective error / result events. There is unique identifier stored in every query which can be used to match different events to be for the same query.
If other collaborators disagree lets open this again.

@elhigu Yeah, makes sense if there isn't already existing bookkeeping mechanism in place. Thanks!


Some badges are not working

I have only two badges (license and downloads) on my repo and both are not working?
Though when i visit the link directly it takes way more time but at least loads successfully :|
Any fixes or alternatives?

If they time out when you view them on GitHub but work when you visit the URL directly this means the badge is taking >4 seconds to load when GitHub's camo proxy tries to load it and it gives up. I suspect this is a dupe of https://github.com/badges/shields/issues/1568 but sometimes it is related to a particular upstream service taking a long time to respond.

Got the same problem

even higher load time in my case

Closing as dupe of #1568 if we could move the conversation over there 😄
Feel free to reopen if you think this may be unrelated.

@RedSparr0w cool! no problem will go to #1568 if necessary 😃


uthentication failed: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1076)

'''
in cmd set below environment variables
set AZURE_CLIENT_ID="xxxxxxxxxxxxxxxxxxxxxxxxxxx"
set AZURE_CLIENT_SECRET="xxxxxxxxxxxxxxxxxxxxxxxxxxx"
set AZURE_TENANT_ID="xxxxxxxxxxxxxxxxxxxxxxxxxxx"
'''
from azure.identity import DefaultAzureCredential
from azure.keyvault.secrets import SecretClient
credential = DefaultAzureCredential()
secret_client = SecretClient(vault_url, credential=credential)
secret = secret_client.get_secret("AYXDDWDEV")
getting below error:
Authentication failed: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1076)
also tried below approach and end up with same error:
from azure.identity import ClientSecretCredential
from azure.keyvault.keys import KeyClient
from azure.keyvault.secrets import SecretClient
credential = ClientSecretCredential(tenant_id, client_id, client_secret)
secret_client = SecretClient(vault_url, credential=credential)
secret = secret_client.get_secret("AYXDDWDEV")
Can someone please help?
Thanks,
Srikanth

@skanthb thanks for the feedback! Someone from our team will take a look at this //cc: @chlowell @mayurid

Looks like you're missing a root certificate. In this case you'd be using requests for transport, which uses certificates from certifi (docs). Which platform are you on, and which version of requests and certifi do you have installed?

requests==2.22.0
requests-oauthlib==1.3.0
Im running the code on windows 10 laptop-Python 3.7.5 within work network and then accessing Azure key vault using Azure python SDK.
https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/identity/azure-identity#defaultazurecredential
https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/keyvault/azure-keyvault-secrets#retrieve-a-secret
Thanks,
Srikanth

Does this network have a traffic inspecting proxy? If so, you'd see an error like this if requests doesn't trust that proxy's certificates.
I'd guess the failing request is to login.microsoftonline.com. You can try it without the Azure SDK:
import requests
requests.get('https://login.microsoftonline.com/')

Thanks @chlowell you are correct. Its proxy issue. I got a http proxy url and tried doing below and it worked.
from azure.storage.blob import BlobServiceClient
from azure.storage.blob._shared.base_client import create_configuration
http_proxy = 'http://xxxxxxxxxxx:yyyy'
Create a storage Configuration object and update the proxy policy.
config = create_configuration(storage_sdk='blob')
config.proxy_policy.proxies = {
'http': http_proxy
}
blob_service_client = BlobServiceClient.from_connection_string(connection_string, _configuration=config)
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/storage/azure-storage-blob/samples/blob_samples_proxy_configuration.py
Thanks,
Srikanth

Great, I'm glad you got it working. However, all clients should accept the proxies keyword argument, and it would be safer to use that because underscored things are internal and may change in future releases. For BlobServiceClient, you'd want something like this:
from azure.storage.blob import BlobServiceClient

proxies = {"http": "http://xxxxxxxxxxx:yyyy"}

blob_service_client = BlobServiceClient.from_connection_string(connection_string, proxies=proxies)

I opened #9311 to track updating the storage samples, and am closing this issue because the original problem is solved.


[Doc] Branch 2.5

Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.23 out of 24 committers have signed the CLA.:white_check_mark: gengjun-git:white_check_mark: mofeiatwork:white_check_mark: Astralidea:white_check_mark: amber-create:white_check_mark: kimmking:white_check_mark: decster:white_check_mark: fzhedu:white_check_mark: EsoragotoSpirit:white_check_mark: Smith-Cruise:white_check_mark: letian-jiang:white_check_mark: srlch:white_check_mark: Seaven:white_check_mark: meegoo:white_check_mark: sduzh:white_check_mark: kevincai:white_check_mark: packy92:white_check_mark: Czkonverse:white_check_mark: evelynzhaojie:white_check_mark: banmoy:white_check_mark: sevev:white_check_mark: DanRoscigno:white_check_mark: trueeyu:white_check_mark: andyziye:x: mergify[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


About Page Cleanup

About Page cleanup
What user problem are we solving?
Currently, About.js dumps all the html in one render function. It becomes a bit confusing to make changes to it, so I delegated specific sections of About.js to separate render helper functions.
What solution does this PR provide?
better delegation of responsibilties
Testing Methodology
manually validate that About.js renders properly
Any other considerations

Very important PR. Exactly how we want to fix the other big files. Thanks for doing this Karthik. Feel free to merge it in

@farisdurrani so im safe to merge?


installation_automatic_annotation.md guide needs to update to reflect the path change in develop branch

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

installation_automatic_annotation guide needs to update to reflect the path change
Expected Behaviour

Follow the guide and load dextr model into cvat
Current Behaviour

nuctl complaints it can't find Python exe if I strictly follow the steps in guideline
Possible Solution

Instead of running
nuctl deploy --project-name cvat \
  --path serverless/openvino/dextr/nuclio \
  --volume `pwd`/serverless/openvino/common:/opt/nuclio/common \
  --platform local

run
nuctl deploy --project-name cvat \
  --path serverless/openvino/dextr/nuclio \
  --volume `pwd`/serverless/common:/opt/nuclio/common \
  --platform local

@waterfall414 , thanks for the report. Do you think you can send us a PR with the fix inside documentation?

@nmanovic, no problem. Just created one in https://github.com/openvinotoolkit/cvat/pull/2847


Support GroupsAccumulator accumulator for udaf

Which issue does this PR close?

Closes #8793 .
What changes are included in this PR?

Support GroupsAccumulator accumulator for udaf

cc @alamb

@guojidan  -- thanks again for your work on this PR. I am quite interested in getting this PR merged, so if you don't think you'll have a chance to work on it this week I would be happy to try and help as well

sorry, I have been very busy the other day, but I am come back 😄

sorry, I have been very busy the other day, but I am come back 😄

No worries -- thank you for working on this


Front - Admin - Update status of campaign automatically

Create a crontab in server to change the status of campaign :

DRAFT --> OPEN if the start date is the current date
OPEN --> CLOSE if the end date is the current date
CLOSE --> ARCHIVED updated with a button in the Admin front

#!bin/bash

## Required jq (https://stedolan.github.io/jq/download/)

# Variables
STATUS_DRAFT="DRAFT"
STATUS_OPEN="OPEN"
STATUS_CLOSED="CLOSED"
STATUS_ARCHIVED="ARCHIVED"
ONE_CAMPAIGN_OPEN=false

echo "Date of execution: $(date)"

# Get the list of campaigns
campaigns=$(curl -s -X GET http://localhost:8000/wp-json/xpeho/v1/qvst/campaigns | jq -r '.[] | @base64')

# Iterate over the list of campaigns
for campaign in $campaigns
    do
        campaignId=$(echo $campaign | base64 --decode | jq -r '.id')
        campaignName=$(echo $campaign | base64 --decode | jq -r '.name')
        campaignStatus=$(echo $campaign | base64 --decode | jq -r '.status')
        campaignStartDate=$(echo $campaign | base64 --decode | jq -r '.start_date')
        campaignEndDate=$(echo $campaign | base64 --decode | jq -r '.end_date')

        # Check if the campaign is draft
        if [ "$campaignStatus" == "$STATUS_DRAFT" ]
            then
                echo "The campaign $campaignName is DRAFT with dates $campaignStartDate - $campaignEndDate"
                # Check if the campaign start date is today
                if [ "$campaignStartDate" == "$(date +%Y-%m-%d)" ]
                    then
                        # Update the campaign status to OPEN
                        curl -s -X POST -H "Content-Type: application/json" -d "{\"status\":\"$STATUS_OPEN\"}" http://localhost:8000/wp-json/xpeho/v1/qvst/campaigns/$campaignId/status:update
                        echo "The campaign $campaignName has been OPEN"
                        ONE_CAMPAIGN_OPEN=true
                fi
        fi

        # Check if the campaign is open
        if [ "$campaignStatus" == "$STATUS_OPEN" ]
            then
                echo "The campaign $campaignName is OPEN with dates $campaignStartDate - $campaignEndDate"
                # Check if the campaign end date is today
                if [ "$campaignEndDate" == "$(date +%Y-%m-%d)" ]
                    then
                        # Update the campaign status to CLOSED
                        curl -s -X POST -H "Content-Type: application/json" -d "{\"status\":\"$STATUS_CLOSED\"}" http://localhost:8000/wp-json/xpeho/v1/qvst/campaigns/$campaignId/status:update
                        echo "The campaign $campaignName has been CLOSED"
                        ONE_CAMPAIGN_OPEN=false
                fi
        fi

    done

# Connect to the firebase database
FIREBASE_EMAIL="***"
FIREBASE_PASSWORD="***"
FIREBASE_API_KEY="***"
FIREBASE_ACCESS_TOKEN=$(curl -s -X POST -H "Content-Type: application/json" -d "{\"email\":\"$FIREBASE_EMAIL\",\"password\":\"$FIREBASE_PASSWORD\",\"returnSecureToken\":true}" https://identitytoolkit.googleapis.com/v1/accounts:signInWithPassword?key=$FIREBASE_API_KEY | jq -r '.idToken')

# Update the value enabled on the document campaign in the cloud firestore
curl -s -X PATCH -H "Content-Type: application/json" -H "Authorization: Bearer $FIREBASE_ACCESS_TOKEN" -d "{\"fields\":{\"enabled\":{\"booleanValue\":\"$ONE_CAMPAIGN_OPEN\"}}}" "https://firestore.googleapis.com/v1/projects/***/databases/(default)/documents/***/***?updateMask.fieldPaths=enabled&key=$FIREBASE_API_KEY"


Remove typing dependency

Description:
The typing module in already included in Python 3.5, as 3.5 is now the minimum version this can be removed.
It is already patched out by Arch Linux and meta-homeassistant
Related issue (if applicable): fixes #13238
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Please run script/gen_requirements_all and update package_constraints.txt if necessary.

requirements_all.txt is not up to date
home-assistant/package_constraints.txt is not up to date
Please run script/gen_requirements_all.py

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Is possible to read the contour information when using brush?

I cannot read the contour or segmentations information when I using brush tools, and didn't find the information in cache. Is any way to read the information?
I'm using the brush example that demo provided.

right now, no, our tools only act on labelmaps currently, we have plans to be able to convert labelmaps to contours and vice versa


Don't explicitly check for Failed or Cancelled Statuses

Between discussion at #1137 and a few rounds of revision at #1159 we arrived at an optimisation where tasks that are both heavily hit and very likely to return in a completed state are checked for a status of either RanToCompletion, Canceled or Faulted and a path is taken where no await is needed for any of those.
The Canceled and Faulted tasks are returned immediately, allowing that state to be passed to the caller.
However, these are exceptional cases, and if we just continued the subsequent await would raise the appropriate exception. Checking for all three cases instead of just RanToCompletion is optimising for those exceptional conditions at cost (in the form of a larger comparison segment of code) to the more common cases of the task either being completed or still running.
Simplify this back to a check just for RanToCompletion.

Hmm, I'm not fused either way. I like that there is slightly less code.


Can the coveralls comments on PRs be turned off?

They spam me with notifications 😅

I thought I was the only one 😂.
Disabled for good.

🎉 🎉 🎉
😛


Fix Content-Type

JSONAPI expects Content-Type to be application/vnd.api+json. After #203 was merged, the return type changed to application/json.
This PR fixes that.

this isn't quite gonna do it, but i'll fix this shortly.

We're returning the right thing now after switching one of our backend gems.  I'll add some tests to make sure we don't drop this when we are doing proxying via an API gateway to enable auth.
Closing this off in light of this.  Thanks for pointing it out and offering up a fix!


Latin turned letters g, insular g, t design issues

gᵷᵹꝿɽⱹtʇƍ U+0067 U+1D77 U+1D79 U+A77F U+027D U+2C79 U+0074 U+0287 U+018D in Roboto:

According to @moyogo in https://github.com/googlei18n/noto-fonts/issues/507, ᵷꝿ U+1D77 U+A77F should have their bottom aligned to the baseline, ʇ U+0287 should have the bottom of its vertical bar on the baseline.

For ʇ U+0287, I corrected the initial comment regarding Arimo and Tinos, and Cousine:

ʇ U+0287 should have the bottom of its vertical [horizontal] bar on the baseline

Here’s what gᵷᵹꝿɽⱹtʇẟƍ should look like

This is what they look like in Version 2.001047

When turned, ascenders become descenders, descenders become ascenders, baseline becomes x-height, x-height becomes baseline.
Additionally ᵹ and ꝿ, or ẟ and ƍ should not differ in shape: if ᵹ has a closed loop so should ꝿ, if ẟ has no angle so should ƍ.


Update Word.Range.ComputeStatistics.md

This is a known problem with the statistics being thrown off by the end-of-cell marker. Please include this so that it is known for the Range method.
Or create a new page specifically for Table.Cell.Range.ComputeStatistics where this can be shown.
https://stackoverflow.com/a/70426205/1623971

Docs Build status updates of commit e1798d6:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

I can not read the instructions. It shows me a 403 forbidden error.


some rough ideas on JS-style routing

...Following the message flow in the Jira Issue CORE-2050
This is rough concept PR and can be discarded, but this was my thought as to how to keep the same code organization within a slightly different RPC flow
CC: @keybase/react-hackers

:+1: I like it (although we shouldn't merge this version)


Simplify build

I got tired of doing this manually every time I needed a new management cluster.

Drat. Did it again


modified progress bar component

Modified progress bar component.

Hi @giteshk11! Thanks for your PR.
Nice work on that, really appreciate the gradient you made. Lovely.
Before accepting the PR, I have one request that I didn't specified on the issue but it is important: the progress will move as the user makes the choices. So, imagine a scenario in which the user is having 10 steps of choice, the progressbar will start with 0%, then the user makes the first choice and the progress moves to 10%. The users makes the second choice and the progress moves to 20% and so on until 100%. But, there must be the solution must have the flexibility of moving between non-linear progress, like from 0% to 20% or from 50% to 80%. So, I'd like to know what about creating css classes to represent those percentages of progress so we can define the width of progress bar by using this class, like:

 => 10% progress

 => 20% progress

 => 30% progress
...

One last thing... I just added some commit and PR guidelines to the CONTRIBUTING.md file. I think it would be good to take a look them as they have some good practices for open source projects and in the next PR we will work following those guidelines.

@tiagostutz rather than created different classes why don't we just use javascript to make the dynamic?

@tiagostutz rather than creating different classes why don't we just use javascript to make the dynamic?

We will use JS (React) to dynamically add this CSS progress class to the component, but with the behavior itself is visual and is better to rely on CSS. I mean, if we want to just put this progress bar starting at 50%, we just need to add this CSS class. This pattern is used by Bootstrap and other CSS frameworks to decouple visual behaviors and aesthetics from the used context.
I'm building a unit test here to test this behavior and enhancing the ProgressBar component so it will be more clear what I mean.
I'm pushing it to your branch for you to take a look, is that ok?

@tiagostutz sure,push it

Just pushed it. You can update and take a look please.

@tiagostutz I saw that you are using bootstrap how about we use utilize the bootstrap attributes and it would look something like this

@tiagostutz I saw that you are using bootstrap how about we use utilize the bootstrap attributes and it would look something like this
<div className={`progress`}> <div role={`progressbar`} className={`progress-bar`} aria-valuenow={valueNow} aria-valuemin={valueMin} aria-valuemax={valueMax} style={{ width: valueNow + "%" }} >

Totally, @giteshk11 ! Go ahead.!
The more “bootstrap native” we keep the solution, the better. Thanks for pointing out.

@tiagostutz I have changed the code and made it bootstrap native. I have added a prop that can change the width of the progress bar. I tested it by changing the width from the dev tools but I don't know how to test it properly. And also we have to modify unit tests as well.

I've pulled the code here, made some adjustments and pushed again. I tested in dev tools and adjusted the unity tests as well; take a look and if you think we can enrich the testes, let me know.
I think this PR is good to be merged now. What do you think?

I've changed the background colour to the gradient to make it look better and I've checked the test cases as well, looks good to me and tests ran successfully, so you can merge this PR 😄.

Nice! I loved the gradient... =)


Job hangs when terminology service configured but can't connect

Steps to reproduce:

Configure the terminology service to a server that is not available.
Make a request which involves use of the terminology service.
Observe that the request hangs indefinitely.

The expected behaviour is that the server would respond immediately with a 503 response code and an OperationOutcome explaining that the connection to the terminology service failed.

I think the issue is not really so much with Spark as it seem to fail immediately  in this situation but rather with our/hapi exception handling. In particular the exception we are getting is:
package ca.uhn.fhir.rest.client.exceptions;

import ca.uhn.fhir.rest.server.exceptions.BaseServerResponseException;
import ca.uhn.fhir.util.CoverageIgnore;

@CoverageIgnore
public class FhirClientConnectionException extends BaseServerResponseException {
  private static final long serialVersionUID = 1L;

  public FhirClientConnectionException(Throwable theCause) {
    super(0, theCause);
  }

  public FhirClientConnectionException(String theMessage, Throwable theCause) {
    super(0, theMessage, theCause);
  }

  public FhirClientConnectionException(String theMessage) {
    super(0, theMessage);
  }
}

(that is after unwrapping SparkException).
which is in a way a malformed BaseServerResponseException  in the sense that it has status code 0 which will l be returned to the confused client by default error handling for this type of exceptions.


⚛  Upgrade to React 18

Fixes #28

Still some issues with rendering (OrbitControls)

would love for this to get merged

All fixed.

Version v2.1.0 has been released!


replace use of logger.warn with logger.warning

logger.warn is deprecated and should be replaced by logger.warning see https://docs.python.org/3/library/logging.html#logging.Logger.warning.
This isn't critical but removes some potential for users of alto2txt to see DeprecationWarnings.

This was addressed in commits 18103f6 and ec66a8f.


fix: calculate skipTest when test name available

@ValentinH Is there anything more you need from me to approve workflow, merge & release?

No sorry, I was just waiting to be on my computer to merge and release it 😊

I really need to take the time to setup an automatic release action 😅

Released as https://github.com/ValentinH/jest-fail-on-console/releases/tag/v3.0.2

Thanks for the contribution @owlcode  🎉

Thanks for your time 👍


clone student-repos fails if any repo exits in target dir

Presently, once a failure happens you have to _start over without any repos cloned - there is not skipping of existing repos possible.

I want to re-run in a dir with some repos cloned but the process was interrupted.
I want to update all repos that exist to latest main (default) branch for all repos

@NukeManDan Just submitted a pull request to that fixes this issue. I was having the same problem :)

@zrdaley can we close this now that my PR has been fully merged :)

fixed by https://github.com/github/gh-classroom/pull/39


chore(http): clean code - split controllers, add test

Hi 👋
Few commit to clean the http-server module a bit.

split controllers
add few tests

I finally, delete the spec test I added, found it useless.
WDYT?


hotfix/dockeryarn : npm -> yarn

What was added

switched to yarn instead of npm for package management
edited Dockerfile to use yarn

hopefully better performance in ec2 t2.micro

Related Issues

link related issues here
REPO_NAME #issueNum

Future Works

What else should be done ?

Checklist

[x] I have performed unit tests
[x] I have added necessary docs
[x] I have checked for potential bugs & issues

I will merge this without review, as it is urgent @nurgissas


SSF Tweaks

Prevent User from receiving notifications for his/her comments.
(Sunflower - 'Watch') Bug fix - I assumed the url to be of the form "task/id" but it can also be  "task?task.uid=urn:uuid=...."

@nursix Not related to this commit, But I need some clarification on this:
https://github.com/flavour/eden/blob/master/modules/s3/s3rest.py#L1482
the transform expects a full path ? or a relative path(i.e, from request.folder) ?
If it expects a full path(which I think it does), Is it good(or safe) to expose the directory structure publicly in the url, I think I've read that it isn't good to do so(security issues) ?

The "transform" variable doesn't take a file path but a URL. This can be used to specify an external transformation stylesheet, i.e. one that is not located on the Sahana server.
For internal stylesheets, you should actually put the stylesheet into static/formats and then just use the respective format extension (like .odt, .have).

@nursix What if it needs to be template specific ?
For eg: I want to add more fields in task rss feeds

You can override r.XSLT_PATH in the prep, e.g.:
if r.representation == "rss":
    r.XSLT_PATH = "modules/templates/ssf/rss"

...and put your custom stylesheets into that folder.
But at this point I don't quite see why it would be template-specific? What fields were you thinking of?

(saying that because so far Sunflower is the only application using project/task.rss - so it could be a precedent)

right now, Task feeds only include the description and title, so I wanted to add more fields such as status, project, and tag...

@nursix Is it fine if it goes in static/formats/rss ?

I think those can very well be in static/formats/rss!
What I would recommend, however, is to move any resource-specific XSLT in the export.xsl into a sub-stylesheet, and then import it into the main rss (I've done similar things in s3csv/hrm/person.xsl).
This makes it more maintainable - and if we really wanted to move that into the template at some point, we don't need to rewrite everything.

Okay :)

@nursix
How does importing prevent rewriting ?
say, I import "project.xsl" in "export.xsl", that href would be w.r.t that folder, so how would you reuse it or prevent re-writing everything if moved in the template ?

Status, project & Tag all seem very generic things to be in the general export.trss

Very easy to see: having resource-specific xsl (i.e. the  respective xsl:template's) in sub-stylesheets which are then imported into main export.xsl makes it easy to exchange just those sub-stylesheets rather than having to dig through a mega-monster-everything-in-one-file stylesheet with hundreds of embedded templates.
So, if we would want to replace the generic project/task RSS - then we could just move your project_task.xsl into the sunflower template - and write a new default one, rather than having to write a new all-in-one export.xsl.

That is btw the main purpose of xsl:include and xsl:import - the ability to modularize stylesheets.
Since RSS is in no way limited to only a handful of resources, but can theoretically be applied to each and everything - and yet every resource has specific needs, we are likely to end up with one xsl:template per resource.
Hence, having only the root template ("s3xml") and the fallback in the master stylesheet, but the resource-specific parts in separate stylesheets makes it a lot easier to maintain.
I don't mind that to be per module, however - i.e. hrm.xsl, project.xsl, org.xsl ... to avoid over-fragmentation (and some parts may be re-usable between resources of the same module anyway). But avoiding a behemoth like person.xsl would be very much what I'd recommend.

@flavour - yes, I would think so. They seem generic enough, nothing template-specific there.

+1 to module-specific format extensions. Per resource isn't required, but a behemoth isn't desired either.


Can't move SimpleBar in IE11

I'm attempting to add SimpleBar to an ESRI Layer List widget. Everything is working great in Chrome and Firefox, but in IE11 SimpleBar does not want to move. I have SimpleBar working on other map elements in IE11, but for some reason Layer List doesn't work. Here is a JSFiddle: https://jsfiddle.net/rxj5j7sf/37/
I appreciate any advice. Thank you.

I'm getting the same problem with IE11, the scroll bar appear but it doesn't work.

Should be fixed in the latest version.

Still have this problem with 2.5.1 - scrollbar is there but not moving at all.

Issue still appearing on 2.5.1 in IE11

I had the same problem. After the investigation, it seems that the problem is not with the plugin but with IE11 flexbox bugs, In some cases .simplebar-scroll-content height equals parent flex container height. And because of that, there are no scrollable element.
I found simple reproduction of this behavior:
https://jsbin.com/suyojonezu/1/edit?html,output
The solutions I've found:

fix height of the parent
wrap the parent with display: flex block and add flex-basis: 100% to the parent.

Still not working. However @arturkin workaround seems to work. But its not prefered to have a fixed height of the parent.

Set max-height to class .simplebar-scroll-content too will fix it


Miniaturizer seems broken

Just noticed it isn't highlighting blocks or shrinking anything at all. Probably broke during the great convergence or when we extracted a pile of stuff to the Core module
It needs more work anyway and there are related concepts like #583 that could be nice to work into an overhaul. Also still really want that dynamically created normal block from a miniaturized selection ;-)

The miniaturizer was removed a long time ago, last traces in #1582. Closing as outdated.


Result of new m.Main() is an Empty object

Presently I am wanting to write code that is used in the browser with the es6-module-loader and babel. The code is transpiled in the browser with babel.
I run my tests with qunit in this callback:
var classToTest;//this will be tested by qunit later
System.transpiler = 'babel';
System.import('app/main').then(function (m) {
  classToTest = new m.Main(); //this will be tested by qunit later
  runTests();
});

However when this runs classToTest is just an empty object when inspected in the debugger () so my tests fail:
classToTest value at line : runTests();
   Main {}

The strange thing is Main performs all the things it is meant to do:
import ShoppingCart from './shoppingCart'
export class Main {
  constructor() {
    //todo look at a way to run this code after all dom is loaded
    //document.addEventListener("DOMContentLoaded", function (event) {
    //});

    //check if cart has stored items otherwise init with default items
    let cart;
    let items = localStorage.getItem("items");
    console.log(items);
    let parsedItems = JSON.parse(localStorage.getItem("items"));

    if (parsedItems === null) {
      cart = new ShoppingCart(['Ferrari F40', 'S Class', 'Tesla'], document.querySelector('#app'))
      //
    } else if (parsedItems === "") { //its been saved before but is empty (user deleted all items)
      cart = new ShoppingCart([], document.querySelector('#app'))
      //
    } else { // has user saved items
      cart = new ShoppingCart(parsedItems, document.querySelector('#app'))
    }
  }
}

I don't see any rarely used API here, and no reason for why that wouldn't work. I think that the problem is in the integration with qunit. You should try to replicate the bug in a small test project.
BTW use ```JS to start a JavaScript code block in a github issue.

hi @MajorBreakfast would you be able to try this project out?
https://github.com/QuantumInformation/vanilla-es6-shoppingcart/commits?author=QuantumInformation
If you run the test.html and look at this line you will see that classToTest is {}
    var classToTest;//this will be tested by qunit later
    System.transpiler = 'babel';
    System.import('app/main').then(function (m) {
      classToTest = new m.Main(); //this will be tested by qunit later
      runTests();
    });

I am seeing the same issue.

@crsmithdev can you clarify what you mean that you're seeing the same issue?

@QuantumInformation it could be worth ensuring you're running the latest version of Babel as well here.

@QuantumInformation the class in https://github.com/QuantumInformation/vanilla-es6-shoppingcart/blob/master/app/main.js#L3 has no prototype methods - so you will be getting an empty object for the class. Closing as this is a class implementation issue - just let me know if you have any further questions.


Change default behaviour of all transclusions to show note-title as heading

Hello! I know I can use ![[Some Other Note|{{title}}]] in my transclusion source, but I find it troublesome. Couldn't we have an option in plugin options to change this behaviour for all published notes?

Great suggestion. I don't see why not. I'll look into it when I find the time.


start to play video when it fully loads

I have some issues for mobile platforms performance, when connection is slow video in player starts to lag. Does okvideo has option to start playing clip only when it's fully loaded?

You're beholden to Youtube