Suggestion: put prototype in var for better minification

I recently developed a module in TS, meant for the web, so it is also being minified.
I reviewed the output file and found that the word prototype is not minified (naturally, since it is a reserved word). But my module ended up having 153 occurrences of prototype, which amounted to 1.34 KB out of a total of 21KB in the minified file (I am using Google Closure Compiler with the ADVANCED_OPTIMIZATIONS flag).
So I had an idea that can reduce that by putting the prototype into a variable before using it in every class definition.
Example:
Code
class Greeter {
    greeting: string;
    constructor(message: string) {
        this.greeting = message;
    }
    greet() {
        return "Hello, " + this.greeting;
    }
    bla() {
        return this.greet() + this.greeting;
    }
    moreBla() {
        return this.greet() + this.greeting;
    }
    blablabla() {
        return this.greet() + this.greeting;
    }
}

class Hello extends Greeter {
    greet() {
        return "Goodbye";
    }
}

let greeter = new Greeter("world");

let button = document.createElement('button');
button.textContent = "Say Hello";
button.onclick = function() {
    alert(greeter.greet());
    var x = [greeter.bla(), greeter.moreBla(), greeter.blablabla()];
    console.log(x);
}

document.body.appendChild(button);

Actual behavior:
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var Greeter = (function () {
    function Greeter(message) {
        this.greeting = message;
    }
    Greeter.prototype.greet = function () {
        return "Hello, " + this.greeting;
    };
    Greeter.prototype.bla = function () {
        return this.greet() + this.greeting;
    };
    Greeter.prototype.moreBla = function () {
        return this.greet() + this.greeting;
    };
    Greeter.prototype.blablabla = function () {
        return this.greet() + this.greeting;
    };
    return Greeter;
}());
var Hello = (function (_super) {
    __extends(Hello, _super);
    function Hello() {
        _super.apply(this, arguments);
    }
    Hello.prototype.greet = function () {
        return "Goodbye";
    };
    return Hello;
}(Greeter));
var greeter = new Greeter("world");
var button = document.createElement('button');
button.textContent = "Say Hello";
button.onclick = function () {
    alert(greeter.greet());
    var x = [greeter.bla(), greeter.moreBla(), greeter.blablabla()];
    console.log(x);
};
document.body.appendChild(button);

Suggested behavior:
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var Greeter = (function () {
    function Greeter(message) {
        this.greeting = message;
    }
    var p = Greeter.prototype;
    p.greet = function () {
        return "Hello, " + this.greeting;
    };
    p.bla = function () {
        return this.greet() + this.greeting;
    };
    p.moreBla = function () {
        return this.greet() + this.greeting;
    };
    p.blablabla = function () {
        return this.greet() + this.greeting;
    };
    return Greeter;
}());
var Hello = (function (_super) {
    __extends(Hello, _super);
    function Hello() {
        _super.apply(this, arguments);
    }
    var p = Hello.prototype;
    p.greet = function () {
        return "Goodbye";
    };
    return Hello;
}(Greeter));
var greeter = new Greeter("world");
var button = document.createElement('button');
button.textContent = "Say Hello";
button.onclick = function () {
    alert(greeter.greet());
    var x = [greeter.bla(), greeter.moreBla(), greeter.blablabla()];
    console.log(x);
};
document.body.appendChild(button);

Updating title to "minification" since that's usually what people call it when optimizing for download size

This sounds like it could be a suggestion for the Closure compiler.  It does these sorts of rewrites in other circumstances, so perhaps there's a good reason it doesn't do it here.

@evmar I thought of that, but since Closure Compiler is not the only minification tool I figured it might be better to change the TS output itself. I can switch minification tools every day, but converting my code to a different language is a lot less likely to happen.

I'm not sure whether this would really reduce the gzipped output size. After gzipping, the string 'prototype' is only stored once. It would be interesting to see some numbers on this, maybe someone can create, well, a prototype 😅 and compare the numbers.

Ungzipped size still matters for parse speed, but that's of course much harder to measure deterministically

Minifiers (Closure/Uglify/etc.) will typically not mangle property names, because it doesn't know which are "safe".  Then there are property names that are "magical" like prototype which they will never mangle.  Therefore the only reasonable way to allow a minifier to shorten such things is to create a reference to it that can be mangled.
My personal opinion is that down-emitting in the fashion suggested above would not have any negative consequences and doesn't make the down emit unclear (except maybe instead of the terse p it would be more clear to use something like var proto = Class.prototype which is more readable and would be mangled easily by a minifier if desired.

The output for subclasses could be shrunk further if __extends returned the prototype it creates.
Before: __extends(Hello, _super); var p = Hello.prototype;
After: var p = __extends(Hello, _super);

Accepting PRs. Be sure to handle name collisions (e.g. a reference to an outer p in the method bodies needs to not be shadowed).

anybody knows why TS compiles protos "great" again in 2022?
https://www.typescriptlang.org/play?target=1&jsx=0&module=5&ts=3.3.3#code/AQYwNghgzlwGYHsHAN4FgBQxvAA4FcAjMASxGEIgCcAKASlUx2eAjAFMqAXGgIkqq86AbiY4AvmOwFiZChABe9RlhbY2nHv0VDRq7OJyZJGTOGiwBwdgA8u7AHYATWImTp982nQ9r1HbhoARjopYBMTTEwaB3YAdy96OgA6AXogA

This bug was filed in 2016, which is possibly before Closure Compiler supported ES6 classes natively.  Today, I think the right way to solve this problem is to have TS and Closure emit ES6, or if you must downlevel you could downlevel with Closure.
So from that perspective, I think you could close this bug.  I don't think optimizing ES5 output is worth worrying about these days.
@GeneGenie you can change the target emit to ES6 in the playground to fix your output too.

Yeah, I agree this isn't worth any additional effort at this point.


Comparing 2 empty strings produces CanopyReadException

Test case
(nth 2 "td.data-table__body-title").Text == row.To // both sides evaluate to an empty string
Actual behavior
Throws CanopyReadException
Expected behavior
Does not throw exception, just passes and continues.

You want to use === for unit test style equality checking.
== takes a selector on the left and a value on the right, and will find the element and try over and over until the values are equal.

Yep, seen it now. Would it be an idea to provide a useful warning in case
of empty strings?
On Jan 19, 2017 17:54, "Chris Holt"<EMAIL_ADDRESS>wrote:
You want to use === for unit test style equality checking.
== takes a selector on the left and a value on the right, and will find the
element and try over and over until the values are equal.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lefthandedgoat/canopy/issues/334#issuecomment-273832030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHYgyiL8f0her6_Z1As9aEq9wq8Fh2aks5rT5VAgaJpZM4LoF3U
.

Using this example
start chrome
url "http://www.pdfpdf.com/samples.html"
(nth 2 "div").Text == ""

I get this error
Couldn't find any elements with selector '', did you mean:
	日本語
	Sales
	FAQ's
	PDF4U
	Links
canopy.types+CanopyEqualityFailedException: can't find element

2nd div on that page has an empty Text property which you can see with the selector '' part in the error.
The only way that I can reproduce a CanopyReadException is this
null == ""
== can actually take a string or an alert, thus its not string == string its 'T == string and null can be a null object or null string.  I throw a read exception if its not a string or not a IAlert and null is neither in this case I guess.
Does this help clear it up?  Just an odd scenario for some reason.

I must've misdiagnosed something cause I get that read exception. Thanks
for the clarification, I've now moved to === but if I get a chance I'll
investigate further. Mainly wanted to prevent weird errors from preventing
canopy adoption :)
On Jan 19, 2017 18:23, "Chris Holt"<EMAIL_ADDRESS>wrote:

Using this example
start chrome
url "http://www.pdfpdf.com/samples.html"
(nth 2 "div").Text == ""
I get this error
Couldn't find any elements with selector '', did you mean:
日本語
Sales
FAQ's
PDF4U
Links
canopy.types+CanopyEqualityFailedException: can't find element
2nd div on that page has an empty Text property which you can see with the selector
'' part in the error.
The only way that I can reproduce a CanopyReadException is this
null == ""
== can actually take a string or an alert, thus its not string == string
its 'T == string and null can be a null object or null string. I throw a
read exception if its not a string or not a IAlert and null is neither in
this case I guess.
Does this help clear it up? Just an odd scenario for some reason.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lefthandedgoat/canopy/issues/334#issuecomment-273840416,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHYg7ZEuhvHm7EXulO1JnvyhvJSK0i9ks5rT5wmgaJpZM4LoF3U
.

Thanks I understand.  Maybe I can improve it.  Can you post the full error and stack trace?

Error:
was unable to read item for unkown reason
Stack:
   at canopy.wait.innerwait@10[b](Stopwatch sw, Double timeout, FSharpFunc`2 f) in C:\projects\canopy\src\canopy\wait.fs:line 25
   at canopy.wait.waitResults[a](Double timeout, FSharpFunc`2 f) in C:\projects\canopy\src\canopy\wait.fs:line 10
   at canopy.core.op_EqualsEquals[a](a item, String value) in C:\projects\canopy\src\canopy\canopy.fs:line 511
   at SomeProject.UiTests.SomeBuildingsTab.compareRow(SomeBuildingRow row) in C:\code\SomeProject\test\SomeProject.UiTests\SomesPage.fs:line 64
   at SomeProject.UiTests.CreateSomePageTests.all@58-2.Invoke(Unit _arg4) in C:\code\SomeProject\test\SomeProject.UiTests\CreateSomePageTests.fs:line 108
   at canopy.runner.tryTest[a,b](a test, b suite, FSharpFunc`2 func) in C:\projects\canopy\src\canopy\runner.fs:line 134

Ok thanks.  I should be able to repro this correctly now.

I couldn't repro with "" == ""
If the page you are testing public?  Maybe I can recreate the issue that way.

Yes it's public. I'll see what I can do.
On Jan 20, 2017 23:01, "Chris Holt"<EMAIL_ADDRESS>wrote:

I couldn't repro with "" == ""
If the page you are testing public? Maybe I can recreate the issue that
way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lefthandedgoat/canopy/issues/334#issuecomment-274191555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHYg4qIQJXlVuaXRhVL29hajkiF5a3Gks5rUS6ygaJpZM4LoF3U
.

Is this still an issue @koenmetsu?

No, closing it would be fine for me.
On Jul 27, 2017 01:49, "Amir Rajan"<EMAIL_ADDRESS>wrote:

Is this still an issue @koenmetsu https://github.com/koenmetsu?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lefthandedgoat/canopy/issues/334#issuecomment-318215750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHYgwRjM4UYn1wIv_6_mQpDsIniQxXKks5sR9CJgaJpZM4LoF3U
.


merge folders bug on windows

...
Seeing
ERROR: PCRE compilation error: unknown property name after \P or \p at offset 33

stack trace seems to show
mergefolders # 73

which is the line
newpath = replace(root, Regex("^$src")=>"$dst")

need to investigate what's causing the problem whether it's

the Regex declaration that fails
the replace that fails

solved with the providential use of escape_string


Feat: Add impelementaion of add new participant endpoint

This also includes #59. Room is needed for a participant to be saved in db therefore signing a participant up for a room can be done here. A Participant hits the endpoint through a specific room anyway.
Closes #54 and #59.

The endpoint itself is not tested by XUnit test. I've tested manually.


Nested Dropdown elements have unexpected hover behaviour

Nested Dropdown elements appear to be applying their own set of rules. This causes issues when the 'on' behaviour is set to 'hover', and animation quirks for grandchildren Dropdowns.
See the Fiddle for an example: http://jsfiddle.net/scottfreeman/y0vz71gf/

http://jsfiddle.net/9htuLqdb/
You dont need to add ui dropdown to submenus of a dropdown.
The formatting however appear to be receiving sub-menu formatting on child dropdown menus. I'll take a look.

Fixed in next along with menu rewrite.


Handles removal of module and removal of student

Handles removal of module by module code and removal of student by matricNo

usage example:
`ClassroomManager` classroomManager = ClassroomManager.getInstance();
classroomManager.handleModuleDeletedByModuleCode(targetModuleCode);
classroomManager.handleStudentDeletedByMatricNo(personToDelete.getMatricNo().matricNo);

Coverage decreased (-0.1%) to 55.823% when pulling<PHONE_NUMBER>d688682c616c6cef05302e9ff80cd2 on zhicaizack:bugSquash into 123c4c0879b74825feabcd75fb87d572edf6c8fc on CS2113-AY1819S1-T16-1:master.


Fix #682, move to cdn.botframework.com

@compulim,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

For your conveniences, this is roughly how it look after npm pack (i.e. what goes to the CDN and npm registry):
09/08/2017  03:28 PM    <DIR>          .
09/08/2017  03:28 PM    <DIR>          ..
09/05/2017  04:31 PM             3,199 adaptivecards-hostconfig.json
09/08/2017  03:27 PM               273 botchat-fullwindow.css
09/08/2017  03:27 PM            16,381 botchat.css
09/08/2017  03:27 PM           464,694 botchat.js
09/08/2017  03:28 PM    <DIR>          built
09/08/2017  03:27 PM            88,598 CognitiveServices.js
09/05/2017  04:31 PM             1,111 LICENSE
09/08/2017  03:23 PM             3,037 package.json
09/08/2017  02:44 PM            16,541 README.md
               8 File(s)        593,834 bytes

Oooh I didn't know about the whiltelist, that's much better. Do we just publish to npm using npm publish as normal?

It will be exactly the same, npm publish would publish our whitelisted files to the registry.
I was using npm pack to emulate a publish and dig into the content to double-check we are doing things right.


Make TVD display as positive for trajectory viewers

Child of #258

Blocked on 3D implementation by:
https://github.com/plotly/plotly.js/issues/1940
Options:

contribute to the project to fix this at the src
hack our front end to hell trying to make this 'work'
stop using turntable controls and manually force the camera upside down
deal with negative TVD in 3D charts
do not use plotly (THREE has no problem with this, but you have to do everything yourself)


public let kUDTrustRoot = "public-key-generated-in-signal-server-step-3"

Hello Lovely People
Trying to get the iOS app working...
in the setup process is asking for the value for kUDTrustRoot
I cannot find any reference to it anywhere, but it says pub key generated in step 3
but which step 3  ???!1
any help would be awesome
thanks

Step 3 of the sever guide
https://github.com/madeindra/signal-setup-guide/tree/master/signal-server-2.92

Thank you for that but still not working
The developer thinks we need websockets installing ..
https://github.com/signalapp/WebSocket-Resources
Has anyone got the iOS client working ?!?
Thanks
Adam
On Fri, 13 Aug 2021 at 00:10, Made Indra @.***> wrote:

Step 3 of the sever guide
https://github.com/madeindra/signal-setup-guide/tree/master/signal-server-2.92
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/madeindra/signal-setup-guide/issues/127#issuecomment-898031197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO2CLAN7MN3R3DURUKS4E3T4RIFFANCNFSM5CBMQULA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Sure, we deployed Signal-Server, Signal-iOS and Signal-Android with dependencies. Of course this manual is starting point and  does not cover number of complex issues that should be resolved.

Ah great Alex good to hear.
Do u have any tips or pointers to get the iOS version working ?
We have the server and the android app working just fine.
Adam
On Mon, 16 Aug 2021 at 14:15, Alex Yavorskiy @.***>
wrote:

Sure, we deployed Signal-Server, Signal-iOS and Signal-Android with
dependencies. Of course this manual is starting point and does not cover
number of complex issues that should be resolved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/madeindra/signal-setup-guide/issues/127#issuecomment-899501064,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO2CLEUACKPMNUQ4C33VALT5EFOPANCNFSM5CBMQULA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Sure, we deployed Signal-Server, Signal-iOS and Signal-Android with dependencies. Of course this manual is starting point and does not cover number of complex issues that should be resolved.

I have server up and client setup is also done. Messages are going through push notifications but not through websocket when both sender and receivers are online. Did you face such type of issue?

Ah great Alex good to hear. Do u have any tips or pointers to get the iOS version working ? We have the server and the android app working just fine. Adam
…
On Mon, 16 Aug 2021 at 14:15, Alex Yavorskiy @.***> wrote: Sure, we deployed Signal-Server, Signal-iOS and Signal-Android with dependencies. Of course this manual is starting point and does not cover number of complex issues that should be resolved. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO2CLEUACKPMNUQ4C33VALT5EFOPANCNFSM5CBMQULA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Hey as  you mentioned, your andorid app is working. Can you please help me for below issue.
I have server up and client setup is also done. Messages are going through push notifications but not through websocket when both sender and receivers are online. Did you face such type of issue?


Starting appfabric service from console can cause other issues.

Many experts have written that starting the service from services console can leave your farm in non working state and in some cases might have to rebuild the SharePoint farm.
This article states : "4. Restart the Distributed Cache service on all cache hosts. To restart the Distributed Cache service, go to Services on Server in Central Administration, and Start the Distributed Cache service on all cache hosts in the farm."
After RAM update each host starts automatically and incase one fails it is recomended to use AFC command or SP distributed cache command set e.g.
Start-CacheHost –ComputerName $env:computername –CachePort 22233
Please double check if this is correct statement.

@UmrG  Thank you for submitting feedback and contributing to the docs. Please link the documentation you are referring to.

https://docs.microsoft.com/en-us/sharepoint/administration/manage-the-distributed-cache-service
<--Restart the Distributed Cache service on all cache hosts. To restart the Distributed Cache service, go to Services on Server in Central Administration, and Start the Distributed Cache service on all cache hosts in the farm.-->

@UmrG I'm not seeing the issue. The instructions look fine.

Hey Trevor,
Sorry man, You are correct. I over looked section of the article. Please ignore.

@UmrG Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


SGF-845 - Fix ContinuousQueryListenerContainerTests

Mock PoolImpl instead of Pool to prevent a ClassCast in the tests.

@jujoramos Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jujoramos Thank you for signing the Contributor License Agreement!

2 things:

When writing Unit Tests and mocking the collaborators for the Subject Under Test (SUT), it is uncommon to mock the actual implementing class of the collaborators used by the SUT (e.g. In this case, SDG's ContinuousQueryListenerContainer class's use of a Geode Pool instance).

Rather, in the spirit of "coding to interfaces", the SUT should only ever refer to and use an instance of a Pool by the Pool interface.  That is indeed what the SDG ContinuousQueryListenerContainer class does.  In fact, most of SDG adheres to, and only uses Geode interfaces for Geode objects.  There are few Exceptions here and there because the intended functionality is not appropriately exposed in a Geode interface.

Geode's PoolManager naively assumes all Pool instances managed by the PoolManager are Geode PoolImpl objects, for which I have filed a bug for in Apache Geode GEODE-7159.

One of the development tasks I am hoping to accomplish by/during Spring Data Neuman/2.3 for SDG, will be to replace SDG's existing test framework with Spring Test for Apache Geode (STDG).
Indeed, the existing test framework bits in SDG formed the foundation for the STDG project itself, which is used by SBDG and SSDG, extensively.  I just need to go back an retrofit SDG's supporting test infrastructure to use STDG now.
One of the many things STDG needed to handle and account for properly was in fact GEODE-7159, particularly when a "mock" Pool gets registered with Apache Geode's PoolManager, which is required in some test cases for SDG, SSDG and SBDG.  STDG now contains special logic to avoid the ClassCastException to what you alluded to above, even when a mock Pool is registered with the PoolManager.  This test class tests that very thing, particularly when the PoolManager.close() method is invoked, which gets called by the test class indirectly here, then here and specifically, here.  It is PoolManager.close() that naively assumes all Pool objects are PoolImpl objects, thereby causing the ClassCastException, which is why STDG is careful to make sure all (framework) "managed" Pool objects properly cleaned up before PoolManager.close() is called.
Anyway, given the information above, I will not be merging this PR.
Thank you for your contribution.

👍


ZEPPELIN-1048: Pandas support for python interpreter

What is this PR for?
What type of PR is it?
Feature
Todos

[x] fix NPE in logs on empty paragraph execution
[x] matplotlib: refactor zeppelin_show(plt) -> z.show(plt)
[x] pandas: support z.show(df)
[x] update docs

What is the Jira issue?
ZEPPELIN-1048
How should this be tested?
"Zeppelin Tutorial: Python - matplotlib basic" should work, and
import pandas as pd
rates = pd.read_csv("bank.csv", sep=";")
z.show(rates)

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes

It is ready to be merged now.
TODOs will be addressed in different PR, after #1063 is merged

I saw https://issues.apache.org/jira/browse/ZEPPELIN-1048 marked 0.7.0 as a fix version.
Not a strong opinion, and i don't think it should be blocker for 0.6 release. But If we're going to change api from zeppelin_show(plt) to z.show(plt), how about apply this api change to 0.6 branch?
While zeppelin_show() introduced recently, now API change cost is not high. But once 0.6.0 released and people starts use zeppelin_show(), API change cost will be increased.

I left few notes on documentation and help()  function. Looks good to me.

Thank you guys for the prompt reviews!
@Leemoonsoo agree on API change and I'm glad to have it merged in 0.6, updated JIRA
@minahlee review addressed in 3b1ad36
If there is no more discussion, going to merge it to master and branch-0.6

cherry-picking to branch-0.6 fails with merge conflicts as master and branch-0.6 diverged

done in 97f25e2


DartPad allows you to lock yourself out.

DartPad runs code immediately when loading the page.
If that code runs forever, like main(){for(;;);} then the page stays unresponsive and you can't change the code. Opening DartPad in a new tab lads the same code again, making you stuck.
Please make some way to get out of this loop.

@lrhn yeah - thanks, we've fixed this, the next push of the UI server will stop it re-running the same code again when the page reloads.
In the meantime, there is a work around, you can clear the local storage associated with DartPad. If you're using chrome navigate to this url 'chrome://settings/cookies#cont' filter for DartPad and clear all the local content.
Sorry for the inconvenience.

It would still be great if running Dart code didn't block the UI, but I guess that's not easy when it can access the DOM.

I agree, but as you say doing that with the DOM is really complicated


Could not find package for installation

Despite having a completely fresh install of composer with no defaults changed I get the following message when running composer require mikehaert1/phpwkhtmltopdf (in a completely empty directory)
[InvalidArgumentException]
Could not find package mikehaert1/phpwkhtmltopdf at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability

I can't reproduce that. There are many stable releases. You can verify this also on packagist:
https://packagist.org/packages/mikehaertl/phpwkhtmltopdf
I've also tried again locally and it works. Maybe your connection was down or some problem with packagist. But nothing I can fix here.

Oh, and is this a 1 instead of an l on the end of mikehaertl? ;)

The 1 instead of l was it! Thanks, I obviously just can't read...


chore: add #2693 hash to git blame ignore revs

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2691

PR #2693

PR #2697   👈

This comment was auto-generated by Graphite.

Won't make sense for this specific lint rule since it was manually fixed, but this is a demo of how draft PRs for ignore-revs could be co-authored with applied codemods to make sure we ignore their revs.


Update users.asciidoc

Thanks a lot four adding OYO! Could you only rework the commit so it only lists the company name? We've considered linking, but then it'd seem odd to do it for some but not for others. That is, we could add a "details" link as for some of the other cases, where there's a blog with details on the specific Debezium usage. Thanks again!

Applied. Thanks a lot, @ayush-chauhan!


Unable to re-build pointcloud_preprocessor in Docker

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
I am trying to investigate some issues in the concatenate_data component, and wanted to debug it.
However I find that I cannot re-build the pointcloud_preprocessor package.
Part of my Dockerfile is as follows:
ARG AUTOWARE_BASE_TAG=humble-latest-prebuilt-amd64
FROM ghcr.io/autowarefoundation/autoware-universe:${AUTOWARE_BASE_TAG}

RUN apt-get install -y -qq \
  python3-pip curl wget git python3-vcstool

# pull autoware src for development/debugging
ENV AUTOWARE_WS_DIR /autoware
RUN wget https://raw.githubusercontent.com/autowarefoundation/autoware/main/autoware.repos -O /tmp/autoware.repos
RUN mkdir -p ${AUTOWARE_WS_DIR}/src
RUN vcs import ${AUTOWARE_WS_DIR}/src < /tmp/autoware.repos
RUN vcs pull ${AUTOWARE_WS_DIR}/src

After building with the default AUTOWARE_BASE_TAG, inside the container I run:
cd /autoware
colcon build --packages-select pointcloud_preprocessor

The build quickly reaches 94% progress, and then seems to get stuck forever, e.g:
[8min 56.8s] [0/1 complete] [pointcloud_preprocessor:build 94% - 8min 56.2s]

Any suggestions would be appreciated.
Expected behavior
pointcloud_preprocessor package builds successfully.
Actual behavior
Build gets stuck.
Steps to reproduce

Build Docker image using partial Dockerfile above

cd /autoware
colcon build --packages-select pointcloud_preprocessor

Versions
Host OS: Ubuntu 22.04. Hardware resources should be adequate (i7, 16 GB RAM).
Docker container is run with --memory 12g --memory-swap 20g --cpus 8
Possible causes
Not sure, the pointcloud_preprocessor CMakeLists.txt seems quite normal.
Additional context
I have not tested this exhaustively, but e.g.
colcon build --packages-select tier4_localization_msgs

finishes as expected.

It seems likely to be caused by insufficient memory,preferably 32g of RAM


Big thanks and advice about SSR (server side render)

Good day, Andrea! Want to say why using lighterHtml and love it. I always start from basics. First,  made a project using js native template literals. But the whole component rerender every time (main cons for me) so started to search something like dom diff. I knew about react, angular, vue but i dont want to use something very complicated. I want to control and understand as much as i can what really library do. For me react and others do too much. There is just no control for me. Why i should use them if lighterhtml is smaller, render views faster, every event in control. Nested components - no problem. I dont use Classes and now dont understand why they are better (maybe my skills just not so good or project not so big to use components based on Classes or maybe not). Structure of my component. Want to share with you and others:
const component = (function() {
const state = {
  something: '',
  array: []
};
const actions = {
  mutateState: (e) => {
    state.something = e.currentTarget.value;
    renderComponent();
  }
};
const htmlMain = state => html`
  <input oninput=${actions.mutateState} type="text" placeholder="" value=${state.something}>
`;
const renderComponent = () => {
  const container = document.getElementById('element');
  render(container, () => htmlMain(state));
};
return {
  actions: actions
};
})();

I cant see any cons in this for now. I have tried nested component and it works like a charm.
Now i tnink more and more about SSR. Main cons of clientside render is SEO. Without SSR it going to be low. Only google can crowl data that fetched in clientside websites. I saw viperHtml, basicHtml but its a lack of examples and documentation. I know about prerender.io and maybe it good for a start, but in future want to control as much as i can. And my knoweldge of NodeJs and Express is 0 now. I saw hackerNews example its good one.
What roadmap would you recommend to make my project SSR? From basics to complicated. Almost always i using examples and documentation as the starting point. HackerNews example based on viperHtml best choice?

@alexey13 apologies for the late answer, but I'm planning to release lighterssr too, so you can create pages on the server side, similarly to how you do on the client.
Unfortunately, I am lacking free time these days, so I cannot say when this will happen.
Meanwhile, please have a look at viperHTML, which should really not be too difficult to grasp.


Update storage-considerations.md

mentioning the slot in Consistent routing through virtual networks

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


limit allocation in fuzzerGridDisk around gridDisksUnsafe

Coverage remained the same at 99.039% when pulling f0ffb73ffafcdd3055c93997abd8d836c9bfd347 on isaacbrodsky:fuzzergriddisk-limit-griddisksunsafe into 505a698402d94b21ce61975e06e24374ecc4f41b on uber:master.