Add CodeQL Workflow for Code Security Analysis

Summary
This pull request introduces a CodeQL workflow to enhance the security analysis of this repository.
What is CodeQL
CodeQL is a static analysis tool that helps identify and mitigate security vulnerabilities. It is primarily intra-function but does provide some support for inter-function analysis. By integrating CodeQL into a GitHub Actions workflow, it can proactively identify and address potential issues before they become security threats.
For more information on CodeQL and how to interpret its results, refer to the GitHub documentation and the CodeQL documentation (https://codeql.github.com/ and https://codeql.github.com/docs/).
What this PR does
We added a new CodeQL workflow file (.github/workflows/codeql.yml) that

Runs on every pull request (functionality to run on every push to main branches is included as a comment for convenience).
Runs daily.
Excludes queries with a high false positive rate or low-severity findings.
Does not display results for git submodules, focusing only on our own codebase.

Validation
To validate the functionality of this workflow, we have run several test scans on the codebase and reviewed the results. The workflow successfully compiles the project, identifies issues, and provides actionable insights while reducing noise by excluding certain queries and third-party code.
Using the workflow results
If this pull request is merged, the CodeQL workflow will be automatically run on every push to the main branch and on every pull request to the main branch. To view the results of these code scans, follow these steps:

Under the repository name, click on the Security tab.
In the left sidebar, click Code scanning alerts.

Is this a good idea?
We are researchers at Purdue University in the USA. We are studying the potential benefits and costs of using CodeQL on open-source repositories of embedded software.
We wrote up a report of our findings so far. The TL;DR is “CodeQL outperforms the other freely-available static analysis tools, with fairly low false positive rates and lots of real defects”. You can read about the report here: https://arxiv.org/abs/2310.00205
Review of engineering hazards
License: see the license at https://github.com/github/codeql-cli-binaries/blob/main/LICENSE.md:
Here's what you may also do with the Software, but only with an Open Source Codebase and subject to the License Restrictions provisions below:

Perform analysis on the Open Source Codebase.

If the Open Source Codebase is hosted and maintained on GitHub.com, generate CodeQL databases for or during automated analysis, CI, or CD.

False positives: We find that around 20% of errors are false positives, but that these FPs are polarized and only a few rules contribute to most FPs. We find that the top rules contributing to FPs are: cpp/uninitialized-local, cpp/missing-check-scanf, cpp/suspicious-pointer-scaling, cpp/unbounded-write, cpp/constant-comparison, and cpp/inconsistent-null-check. Adding a filter to filter out certain rules that contribute to a high FP rate can be done simply in the workflow file.

@no1wudi Pinging to check in on a possible followup to this PR?

@b4yuan Thanks for your countribution, should the error be fixed ?

Get it, thanks.

@b4yuan thanks for submitting the PR! It is really a good method to improve WAMR's code quality. IIUC, we should address the issues reported below before merging this PR?
https://github.com/bytecodealliance/wasm-micro-runtime/security/code-scanning?query=pr%3A2812+is%3Aopen

Merge this PR and will create another PR to enhance it: (1) add more compilation combinations to build many kinds of iwasm with different features enabled, (2) run the CI only in nightly-run, disable it when a PR is created, since it takes long time to run the build script.

@b4yuan Thanks again for contributing this PR, it is really important to improve the code quality of WAMR project. I have merged this PR and submitted another PR (#3246) to enhance it and make it nightly run only. We will look into the issues reported then, and try to enable triggering CodeQL when PR is created in the future.


nixos/installer: use libinput over synaptics

Motivation for this change
noticed ofborg not being able to eval because of an assertion, this is to help remedy it
example failure
I believe this bug was introduced in #68233
cc @worldofpeace
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Now that I think about it, we could probably do away with explicitly setting this altogether in the installer expression. Not sure which would be more correct.

i would do ofborg test installer, but it seems to be incredibly resource intensive with building a new kernel.

See also https://github.com/NixOS/nixpkgs/pull/67305

I did, the issue I'm trying to fix is that ofborg is erroring on all other PRs right now because that one image has both synaptic and libinput enabled.

noticed ofborg not being able to eval because of an assertion, this is to help remedy it

Ahh, that was pretty sneaky.
I think I'll push https://github.com/NixOS/nixpkgs/pull/67305/commits/6b0cc753d84941230e61bbfe52a3e61417055c71 since we've pretty much agreed on that, and I will test the image briefly.

b3a06f10d1e950e1349e08e8952c2e1d0f8bf473


You can invoke a snackbar's action while it's being closed

Bug type
Component
Component name
MudSnackbar
What happened?
You can keep clicking the same snackbar for the entirety of the hide transition and perform the same OnClick action.
https://github.com/MudBlazor/MudBlazor/assets/7112040/c54567c8-70ab-4b47-b204-1bd78926b783
Expected behavior
I don't think you should be able to do this as many apps will assume that their code will only be executed once and that could be dangerous. I am not sure many are relying on the opposite behavior as it is now - I definitely did not expect it. On the other hand it's a breaking change.
Reproduction link
https://www.mudblazor.com/components/snackbar#custom-action-handling
Reproduction steps

Show a clickable snackbar
Click it once
Keep clicking as many times as you want during the hide transition

Relevant log output
No response
Version (bug)
6.17.0
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows, Android
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@henon I could take care of this in #8334 and add tests but it is a breaking change 🤷♀
Just seems dangerous to me

It is not a breaking change if it is a bug fix. The behavior is indeed unintended and unexpected. I am for fixing it.

It is not a breaking change if it is a bug fix. The behavior is indeed unintended and unexpected. I am for fixing it.

I'll take care of it as soon as #8334 is merged to keep it clean

@henon #8383 is ready to review


Ability to share posts on social network

This feature will allow readers to share a particular post on social networking site. I've adopted this feature from mimimal mistakes' theme so simple
As a user of the theme myself I wanted to give my readers ability to share a post to increase outreach and engagement

Hi @hbk-ronak, thanks for using the theme! Firstly, I really appreciate you taking the effort to make this PR.
Unfortunately, I'm afraid I don't intend to have this as a feature currently. Tale is meant to be a minimal and lightweight baseline theme, so having too many additional features is not what I'm going for here. So sorry! 🙏

Thanks Chester. I didn't know about the design philosophy you were following.


run: fix execute_local_docker() not properly catching ctrl-c

fix #1246.

switched to using docker stop instead using a pre-determined container name. Kind of just chose the name arbitrarily, if you think there is a more appropriate name just lmk.

That will break a pair of concurrent builds, no?

Squash the PR please.


Fix crash when loading from empty arrow table

Codecov Report

Merging #61 (dd40419) into main (4b4a72c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   77.45%   77.45%
=======================================
  Files          52       52
  Lines        3712     3712
=======================================
  Hits         2875     2875
  Misses        837      837


remove mermaid diagrams until they are more useful

more useful =

showing class to class relationships
not showing a multi-page box of slots for huge classes like Biosample

The class to class relationships seems to be satisfied now?
Not showing a huge box of all slots when the number of slots is too large hasn't been satisfied yet, and I'll work on it

Closing this.  Mermaid diagrams looking real nice on the documentation for the schema!


[Bug] Some times the danger ci fails in GitHub enterprise

Request failed [422]: https://github.pactual.net/api/v3/repos/bankingmobile/banking-ios-pix/pulls/314/reviews
Response: {
"message": "Unprocessable Entity",
"errors": [
"Position is invalid"
],
"documentation_url": "https://docs.github.com/enterprise/3.0/rest/reference/pulls#create-a-review-for-a-pull-request"
}
Feedback: https://github.pactual.net/bankingmobile/banking-ios-pix/pull/314#issuecomment-50072

It seems that is trying to post on an invalid line, what is your Dangerfile doing?

@MaatheusGois
This is not actually a bug. This is how github works.
In a GitHub PR you cannot comment in whatever line you want even from their webpage.
To illustrate it further you can comment here only in the lines inside the blue box.


Extent support for nil values

I found the need to use luas nil but could not find any documentation for it. Also I was not sure if it can be reliably detected to be different than zero (0).
This updates the readme and adds more tests to ensure this. kaguya::NilValue is now basically the C++98 version of nullptr_t
Also some minor readme fixes.

Current coverage is 88.66% (diff: 90.90%)

Merging #42 into master will decrease coverage by 0.79%

@@             master        #42   diff @@
==========================================
  Files            26         24     -2
  Lines          2827       2417   -410
  Methods         837        714   -123
  Messages          0          0
  Branches        301        267    -34
==========================================
- Hits           2529       2143   -386
- Misses           44         47     +3
+ Partials        254        227    -27

Powered by Codecov. Last update 180b299...d37fb0a

Thank you!

A little bit to fast... There were some compilation errors I was trying to fix (did not get them on my machine)
I hope they were all fixed by my last commit


Corrected arguments for ipv6 usage

Followup to #76

@SystemRage This is also needed desperately - it corrects the usage instructions to match the ipv6 environment!

No problems boy.


[CT-2838] Stop skipping test_metric_deferral

We currently @pytest.mark.skip test_metric_deferral. We should at this time be able to un-skip this test with some minor tweaks. Additionally, if the test is broken for real reasons, this issue should be converted to fixing the functionality as well.
Acceptance Criteria

test_metric_deferral is no longer skipped
test_metric_deferral passes (and not because it's rigged)

deferral likely doesn't work for metrics today because of order of parsing & deferral


Consider to rename IURIDisplayService

I find the IURIDisplayService hard to understand. I think we generally talk about resource labels, so why not go with IResourceLabelService?

Thanks for feedback, however we use URI eveywhere in our API in favor of resource.
So why not IUriLabelService
fyi @jrieken

Works for me too.


PPO2 load model

Error while saving the PPO2 model. The observation_space parameter is always loaded with the same Box value (-1.7727938890457153, 1.6625347137451172, (128, 1), float32)

Please fill in the issue template (e.g. full code to replicate the issue).


Ooops! An unexpected error seems to have occured. Why not try refreshing your page? Or you can contact your administrator if the problem persists.

I installed the Company Communicator with the Powershell Guide, now after adding it to a Team I get following error:
"Ooops! An unexpected error seems to have occured. Why not try refreshing your page? Or you can contact your administrator if the problem persists."
I'm in the UPN-Sender List and the deployment was successful.
Thanks for your help.

Hi @lman-SL,
Thank you for raising the query, there are multiple reasons why this error might occur, can you please double check during the app registration process you’ve selected multi-tenant for author and user apps. If yes, can you also check the app insights to see if any exceptions getting logged there and share it with us to troubleshoot further.

Hi @Porkai-Pandian
Thank you for your response.
Following for the App registration:
Communicator App registration:

API Permissions all granted
I seem to have 2 Client Secrets
I have following error in the token Config:

Communicator-Author App Registration:

Again 2 Client Secrets
No API Permission here

Communicator-Users App Registration:

2 Client Secrets here again
No API Permissions

For the Communicator App registration only Single-Tenant
For the Author and User App registration Multi-Tenant

@Porkai-Pandian
Maybe we could schedule a Teams Meeting together to have a look at the current problem I'm facing and to analyze further.
Please send me your E-Mail Address so I can schedule a Meeting for us.

I have the same problem with V5.
The steps followed in V5 are the same as indicated in the instructions.
I have removed all security in the API and it allows me to work "correctly".

Thank you

I haven't found where to set this setting?
Could you please tell me where I can change that?
Kind regards
Manuel

@lman-SL This code is in the solution. Find all "[Autorize" and comment it. Deploy the apps service and test.
Be careful that we are left without security.

@jmfloreszazo it's advisable not to modify the authorize which might lead to other issues and we'll not be able to support in such cases.
@lman-SL you shared the exception count, can you please share the exception details

@Porkai-Pandian Thanks for the advise, I understand the derived problems, it was to see where the error occurred. It is already limited and it is an authorization problem.

Hi everyone, is this resolved already? I have the same issue

Hi @Porkai-Pandian I'm having the same issue in my demo tenant.  It seems to happen when I draft my first message after not having been signed in for at least a day.  Usually after the first (sometimes second) failure, it seems to work.

Hi @lman-SL ,
Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses. Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up.


build: adjust Package.swift for Windows builds

This extends some of the special handling for Windows to allow building
the full llbuild package currently on Windows with SPM.  With this set
of changes and one workaround, it is possible to build all of llbuild
with SPM:
swift build -Xcc -IS:\Library\sqlite-3.36.0\usr\include -Xlinker -LS:\Library\sqlite-3.36.0\usr\lib -Xswiftc -use-ld=lld %DEVELOPER_DIR%\Platforms\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\windows\x86_64\swiftCore.lib

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test macOS platform

@swift-ci please smoke test macOS


CORs Filter should allow mapping to be configurable

A property cors.mapping to specify the URL mapping for the CORs filter would be useful

Released in 0.84


Allow the default refresh.yml file to exist in multiple locations

Rather than limit the configuration to just refresh.yml, this allows for developers to use their preferred yaml file extension, and allows for the dotfile prefix convention that is implemented by other tooling.

When a config, c flag is explicitly set, only that file is looked for.
Don't exit the run action if no configuration is found, the defaults are sane.
Tell the configuration file that ends up being used.

There's also a few minor err != nil cleanups I added while I was in the file, nothing logic changing.

Unrelated note: I've opened a PR for goreleaser/godownloader so the project can benefit from a shell installer. Thought you'd like to know!

Awesome! once the tests run I'll merge and release. Thanks.


Pull color code into its own file and add new suggestions algorithm.

@ckundo any objections?

Great work! LGTM.


YouTube's UploadAsync() is failing on UWP apps

In a UWP app, I am having issues uploading YouTube videos successfully using the latest versions of the NuGet packages. (Latest is <IP_ADDRESS>2).
If the video size is very small (I suspect smaller than the chunk size), it succeeds. Otherwise it fails to upload by continuously reporting that 0 bytes were uploaded.
I've found that the breaking change occurs in version <IP_ADDRESS>9. UploadAsync() works in the previous version, <IP_ADDRESS>9.
I will try to create a GitHub repo to demonstrate the issue.

I created a demo repository to show the issue happening.
https://github.com/timforever/UWP-YouTube-Upload-Test
To get it building using VS 2015, all that needs to be done is to open the solution file, and copy in your client_id.json file for the Google API. And make sure you're building for x86 or x64.

@timforever: Thanks for the repo. We don't currently support UWP, but I'll see if I can take a look. We're hoping to support UWP in the v2 release, which should be available early 2017. See #787 for v2 details.

This is still an issue in <IP_ADDRESS>9

@ptallett we still don't support UWP please see #787

UWP is not currently supported, so closing this issue for now.
If we decide to support UWP then our test suite, which includes tests for this media uploader, will be run on UWP so if there is a bug it'll be discovered and fixed.


fix(internal-pages): Disable refresh button for Bookmarks and History…

Resolves #520
QA:
Bookmarks and History pages are not composed of webview instances, thus they have no reload behavior. This PR disables refresh button for those pages.

this doesnt address the case of opening the history/bookmarks from shortcut keys / menus nor directly entering into the address bar.

@joshuef Is this still the case? I pushed a commit to handle it a bit differently.

@hunterlester CI failing with:
 TypeError: Cannot read property 'includes' of null
      61 |             icon="reload"
      62 |             aria-label={I18n.t("aria.reload_page")}
    > 63 |             disabled={activeTab.isLoading || activeTabUrl.protocol.includes( PROTOCOLS.INTERNAL_PAGES )}
         |                                                                    ^
      64 |             onClick={handleRefresh}
      65 |           />
      66 |         </Col>

So i think we just need first check protocol exists

Still failing w/ linux ci :| @hunterlester


Redesign of nodes: Using configuration node for bridge; Using custom …

…JSON object as described in API; Replaced error output with node.error;
I would appreciate if you merge the changes and publish to npm so i don't have to create a second version of the nodes.
Thanks.

Did you ever publish this on npm?
I am thinking of doing the same to fix #12 and show an error on the node when there are issues.

I had a look into this.
While I absolutely appreciate the efforts I do think that we are all better off if this goes into another repository:
It has basically nothing to do with the original source and seems to be completely incompatible with the current version (even every identifier is different) so I assume people who upgrade would be irritated at best. Or did I miss something here?

You are right. I published to node-red-contrib-hueplus.
Thanks for previous work.


1.2 Ganyu Update + Name Update

Updated with Ganyu (chara, talent, constellations) and updated all the descriptions and names of weapons, skills, talents, etc. that were changed in the last few updates.

you're amazing

you're amazing

I only briefly went through a few of the patch notes, so I hope I didn't miss anything :X

I only briefly went through a few of the patch notes, so I hope I didn't miss anything :X


Add FILE and LINE Magic Constants

Adds __FILE__ and __LINE__ Magic Constants
Finishes https://github.com/myst-lang/myst/issues/36

Awesome! Looks great!
Thanks for the picking this one up :)


Changelog for 1.16 and 1.17

Does rustup  1.16 and 1.17 bring any new improments over older versions?
Those new features would be better documented in CHANGLOG.md.

When we were discussing the 1.17.0 release in our weekly meetings we decided that as CHANGELOG.md hadn't been touched since 1.13.0 we were okay with not bothering for 1.17.0.
If you wanted to generate a backfill for it, I'd be pleased to review it.  But I don't have the time/mental space for it right now myself.


feat: Add mongodb as a default database for application

Related issues
Resolves https://github.com/OqixDevs/OqixTS/issues/60
Type of pull request

[x] New feature
[ ] Bug fix
[ ] Refactoring
[ ] Feature update
[ ] Other

Describe your PR in detail
This PR adds mongodb database as a default database for the application. It utilizes mongodb atlas shared tier since it is fairly generous, later with the application would grow too large we might want to reconsider alternatives...
It uses Prisma as ORM

Ok I think it is ready for the review.
/cc @xvanick1

Suggestion for the possibility of re-verifying with the requirement of deleting old verification assigned to the thesis. Request to add the date of verification to the user object.

Reverify option is little bit complicated since we need to define when is user able to reverify - For example there is big difference when the user is kicked from the server and when he leaves on its own. Is only situation when he can reverify when he leaves on its own or do we want to have option to "lift the ban". If the second option is true, then I would suggest leaving it for now and making it separate feature.
As for the the date of verification. Do you have something in mind how we would use it? Because first of all I would like to keep amount of data we store to minimum (mainly to protect students) and we also have currently quite a few people who are already verfied therefore simplest thing would be to add same date to each one, and I do not find that too useful :thinking: .

Suggestion for the possibility of re-verifying with the requirement of deleting old verification assigned to the thesis. Request to add the date of verification to the user object.

Reverify option is little bit complicated since we need to define when is user able to reverify - For example there is big difference when the user is kicked from the server and when he leaves on its own. Is only situation when he can reverify when he leaves on its own or do we want to have option to "lift the ban". If the second option is true, then I would suggest leaving it for now and making it separate feature.
As for the the date of verification. Do you have something in mind how we would use it? Because first of all I would like to keep amount of data we store to minimum (mainly to protect students) and we also have currently quite a few people who are already verfied therefore simplest thing would be to add same date to each one, and I do not find that too useful 🤔 .

In my opinion only re-verification when user leaves server should be available, as currently in this case, the record is still in database.
Regarding the second request, I see it useful for security reasons when auditing suspicious behaviour... for example cases when there would be some leak from the server, we can filter out users verified in that period and check their behaviour about the leak.
For the users that are already verified, we can use the date of joining the server or just keep the field empty in their case.

Converted back to draft since I am finishing the work on kicked and banned reverification and needs little bit more work.

Now we have also states removed and banned. These states work this way:
removed -> user kicked, left or ban was removed - user can verify again (also new user can verify using proper credentials.
banned -> user is not able to verify again.
verified -> no other user can verify using these credentials

/lgtm


error: '__config' file not found  and __functional_base with  include; use "quotes" instead and no template named 'unary_function'; did you mean 'binary_function'?

Describe the bug
A clear and concise description of what the bug is.
Steps To Reproduce
Steps to reproduce the behavior:

use nix-shell  env.nix :https://pastebin.com/NriZqB6R
build and install smokegen (https://github.com/commonqt/smokegen) it works well.
build smokeqt https://github.com/commonqt/smokeqt . I got errors https://pastebin.com/Xm4kkjEV

Expected behavior
build smokeqt successfully with qt and clang provided by nixos.
Screenshots
No
Additional context
NO
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.58, NixOS, 22.05 (Quokka), 22.05.2134.e43cf174846`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"home-manager-22.05.tar.gz, nixos-22.05"`
 - channels(prehonor): `"home-manager-22.05.tar.gz"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I'm not sure this is a nixpkgs bug. Your bug report is hardly actionable for the following reason:

your env.nix contains paths to hour home directory (/home/prehonor/CLionProjects/EQL5), which might influence your build.
smokeqt has neither readme nor installation instructions. How are we supposed to build it?
smokeqt has been last updated 2 years ago; building it with newest compilers and libraries from nixpkgs may by a problem. Perhaps smokeqt requires older versions, but it's hard to tell without README.
Mixing C++ stuff compiled by different compilers (gcc and clang) is often problematic.

I suggest narrowing the scope you this issue a bit.

I'm not sure this is a nixpkgs bug. Your bug report is hardly actionable for the following reason:
* your `env.nix` contains paths to hour home directory (`/home/prehonor/CLionProjects/EQL5`), which might influence your build.

* smokeqt has neither readme nor installation instructions. How are we supposed to build it?

* smokeqt has been last updated 2 years ago; building it with newest compilers and libraries from nixpkgs may by a problem. Perhaps smokeqt requires older versions, but it's hard to tell without README.

* Mixing C++ stuff compiled by different compilers (gcc and clang) is often problematic.

I suggest narrowing the scope you this issue a bit.

There is simple guide  from https://github.com/commonqt/commonqt5,


[Feature][Core][Connector-V2] Unified The way of setting JobName

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
In connector-v2, flink can set job name use job.name in env in config. But spark can't set job name(application name) at now.
Our goal:
Both flink and spark:

User can use same way to set job name in command.
User can use same way to set job name in env in config.

Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I want to give it a try


Suggestion: Add 'cache' kwarg to handlers to inject the cache backend.

This is a suggetion- we could add a cache reserved kwarg, which will cause starlite to inject the cache backend to route handlers:
from starlite import Cache, get

get("/")
async def handler(cache: Cache) -> dict | None:
   return await cache.get(...)

This is merely an ergonomics improvement, because users can access the cache already by going the somewhat longer route of doing this:
from starlite import Request

get("/")
async def handler(request: Request) -> dict | None:
   return await request.app.cache.get(...)

Given that it is pretty easy for a user to write a small convenience dependency to do the same, e.g.,:
@get("/")
def using_the_cache(cache: Cache) -> ...:
    ...

def provide_cache(request: Request) -> Cache:
    return request.app.cache

app = Starlite([using_the_cache], dependencies={"cache": Provide(provide_cache)})

Add to that it would be breaking for anyone already using cache as a parameter name in a signature and I'm not sure it is worth the churn.
Maybe something we could consider is curating a collection of dependencies that users could use if they want - basically would save them the hassle of having to write the dependency function for common things like this. E.g., from starlite.dependencies.lib provide_cache. It could be a good middle ground. Thoughts?

That's a very good idea

Idea purely inspired by this issue, so I don't really have any thoughts beyond that, but I'm sure there would be a few different things that can be accessed through the request via a couple of hops like the cache..
What about a structured log instance that is pre-bound to some app/request context?
We could always start with recipes in the docs to see if there's enough interest to warrant the work of maintaining them.

Ok. But we still need to inventory what we want to add - even as recipes

Shall we make a new issue, or hijack this one?

Shall we make a new issue, or hijack this one?

Hijack

@peterschutt so what should we include?

Hello, thanks for the awesome framework.
If you're looking for ideas for recipes, I'm right now looking at overriding dependencies when writing tests. I'm trying it now, I can contribute to that if you all decided it's a good recipe.

Hello, thanks for the awesome framework.
If you're looking for ideas for recipes, I'm right now looking at overriding dependencies when writing tests. I'm trying it now, I can contribute to that if you all decided it's a good recipe.

You're welcome 😉
Sure, we are keen on PRs


re-add speedtest-cli to deps

i removed this accidentally - i'll fix later

Fixed speedtest-cli issue


Improve error handling from AOS requests

ReliableRun class will catch AOS exceptions and try to suggest changes. Other errors pass through. If a suggestion is found, or it does not make sense to retry, the request is not repeated. Every AOS error is shown to the user.
Example of an error with an inline TSG:

resolves #105
#patch

@Antonstockmarr this PR is ready except that it needs to uptake main, please merge main into this and ensure things look good - then ping @Omaaarz or me and we can get it in 😊. Thanks!


vnc password in VNC test

Adds password to VNC test #374
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

LGTM! Thanks for taking care of this so quickly!


if address/port is in use, REPL enters broken state

an error is raised to the REPL:
BindException Address already in use  sun.nio.ch.Net.bind (Net.java:-2)

but the piggiebacking continues anyway, and :cljs/quit must be entered to unbreak things.

Caused by cemerick/piggieback#26, closing in favor of that.


[pulsar-broker] add configuration to set number of channels per bookie

Motivation
Add config to configure number of channels per bookie in broker's bk-client.

/pulsarbot run-failure-checks

ping @sijie

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

need to cherry-pick to 2.6.2.


add windows installation guide and Shift Risk Left key features

What type of PR is this?
/kind documentation

What this PR does / why we need it:
add windows installation guide and Shift Risk Left key features in readme
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 71.997%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
4741

Relevant Lines:
6585

💛  - Coveralls


Predicting number of failures for a given time hard coded

From the first few lines of utility/prediction/Detailed_prediction.R:
get_prediction_k <- function(model,params, t_offset,tn,n){
	# ! -----> #print(">>>>>>>>>")
	# ! -----> #print(params)
	if("JM_N0" %in% names(params)){
		est_faults <- JM_MVF_cont(params,tn + t_offset) - JM_MVF_cont(params,tn)
	}
	else if("GM_D0" %in% names(params)){
		est_faults <- GM_MVF_cont(params,tn + t_offset) - GM_MVF_cont(params,tn)
	}
	else if("GO_aMLE" %in% names(params)){
		est_faults <- GO_MVF_cont(params,tn + t_offset) - GO_MVF_cont(params,tn)
	}
	else if("DSS_aMLE" %in% names(params)){
		est_faults <- DSS_MVF_cont(params,tn + t_offset) - DSS_MVF_cont(params,tn)
	}
	else if("Wei_aMLE" %in% names(params)){
		est_faults <- Wei_MVF_cont(params,tn + t_offset) - Wei_MVF_cont(params,tn)
	}
	else{
		est_faults <- "Not Implemented"
	}

Predictions about number of failures for a given time period are hard coded to models at the moment. This should be changed in order to support the addition of new models.

Note that above included models such as the Jelinski-Moranda provide an estimate for failure number, whereas the non-default Musa-Okumoto has a hard coded string.

@RichardMuri , the issue has been solved in the develop branch as shown here
If you'd like you can copy and paste that function to your local code. Or you can use the develop branch, it has a number of significant changes (code should be easier to read and includes FC models among other things) and is fairly stable.


Implement QueryStackTraceLogger using StackWalker

Implement QueryStackTraceLogger using the Stack-Walking API.
This is potentially more efficient because:

We render into one StringBuilder

this avoids all intermediate, small String allocations
this also avoids the intermediate List<String> allocation holding the individual lines

We only allocate StackTraceElement for the frames we are interested in
We do not need to walk the frames after the first frame in packageNamePrefix
We avoid allocating the StackTraceElement[]
We do not walk the stack and create the log message if QueryStackTraceLogger has not at least level debug. This can be helpful if you want to always register QueryStackTraceLogger but be able to toggle it using the log level.

The code quite is still not as elegant as I would like. I especially hate the nested ifs and the AtomicBoolean but the output is the same. It's also not ideal that the stack trace ends in o.hypersistence.utils.hibernate.query.QueryStackTraceLoggerTest.lambda$0(QueryStackTraceLoggerTest.java:48) rather than io.hypersistence.utils.hibernate.query.QueryStackTraceLoggerTest.testJPQL(QueryStackTraceLoggerTest.java:39). There seems to be no way to determine whether a method is a lambda short of running a regex against the method name or checking Method#isSynthetic().
This requires JDK 9. So you may only want to use is for Hibernate 6+ unless you want to build a Multi-Release JAR

Thanks, I'll review it when I have some time.

Fixed.


Add cm secrets filter

Added cleaning of unused Secrets and ConfigMaps, for more details read README or:
go run main.go secrets namespace -h
go run main.go configmaps namespace -h

May I suggest we use ConfigMap and Secret everywhere (instead of e.g. config map)?

Updated the code, rebased on master and squashed commits into one single commit


Missing  X & Y Axis Separator Lines and out of place x axis label

Hi Beto,
Good day, I've been using this control for quite some time now and loving it.
I tried to update the control to the latest version but encountered some sort of a bug.
Some of the axis separator lines are missing. The code are still the same as the one before but for some reason it stop on painting some lines. Also the x axis seems to extend to the lowest part where the x axis labels were located.
I'm trying to downgrade my version to the last one but failed to do so.
Thanks.
Regards,
Billy Joel

Live-Charts version
0.9.3

.Net Version
4.5.1

Windows
7

Been trying to add some screenshots but encountering some kind of error

Hi Billy I am sorry for this issue, i'll try to reproduce with the info you gave me, there are many ways to roll back, from the package manager run these commands in that order:
PM > Uninstall-Package LiveCharts.Wpf
PM > Uninstall-Package LiveCharts
PM > Install-Package LiveCharts.Wpf -version 0.9.2
Hope this helps you

Thanks...
I really appreciate your reply.

I rolled back #449 this should now go back to normal with https://github.com/beto-rodriguez/Live-Charts/commit/39bdf10492b6989547ba3d23ab46e31999bb4671
version <IP_ADDRESS> will be published in a couple of hours with this fix.
Thank you very much Billy for all the reports you've made to the library.


Manually parenthesize tuple expr in B014 autofix

Summary
Manually add the parentheses around tuple expressions for the autofix in B014.
This is also done in various other autofixes as well such as for
RUF005,
UP024.
Alternate Solution
An alternate solution would be to fix this in the Generator itself by checking
if the tuple expression needs to be generated at the top-level or not. If so,
then always add the parentheses.
                } else if level == 0 {
                    // Top-level tuples are always parenthesized.
                    self.p("(");
                    let mut first = true;
                    for elt in elts {
                        self.p_delim(&mut first, ", ");
                        self.unparse_expr(elt, precedence::COMMA);
                    }
                    self.p_if(elts.len() == 1, ",");
                    self.p(")");

Test Plan
Add a regression test for this case in B014.
fixes: #6412

Current dependencies on/for this PR:

main

PR #6415   👈

This comment was auto-generated by Graphite.


fix(build): windows platform build output path error

Description

fix #17584
path.posix.relative and path.relative resolve differently when the path starts with lowercase.
import path from 'node:path'
path.posix.relative('c:/a', 'C:/a/index.html') // => '../../C:/a/index.html'
path.relative('c:/a',  'C:/a/index.html') // => 'index.html'

Thanks, working perfect now.


eaygar/vSphereAutomationSDK65Integration

vSphere Automation SDK Integration.

@eaygar I'm not sure what's going on, but I'm assuming you aren't actually meaning to create PRs for this stuff. It seems pretty clear you are customizing this for use on your fork. I'm going to go ahead and close this PR for now.

Oh, I was trying to make changes to our custom fork. Sorry!

Not a problem! Enjoy and feel free to submit any feedback you have!

Certainly! So far so good! Btw, I still need to improve the performance on the pulling categories/tags/associations for multiple objects with their names and descriptions.
Please recall my slack message.


Update to LLVM 12.0.0

First commit has a workaround for LLVM regression #16668. The last two commits simply update the LLVM image and children dependencies. See commits for details.

test-me-please


[Feature Request] Allow self signed certificates

Is your feature request related to a problem? Please describe.
I can't connect to my local proton mail instance without allowing self signed certificates as the protonmail bridge wraps all connections in them.
Describe the solution you'd like
A little tick box in the UI would be nice to ignore/accept self signed certificates
Describe alternatives you've considered
Not entirely sure what I could do to work around this in this configuration
Additional context
I'm using a local installation of Proton Mail - Bridge. This is running on docker with ports 25 and 143 exposed externally.

You'd need to load your CA cert into the HA container each update in order to get this to work.
This is out of the scope of the integration.

imap allows passing SSL context, which can skip cert validation. You can add a checkbox to allow the user to not verify the SSL cert. This is very common in HA integrations since it is very likely for people to use self-signed certs for various reasons locally.
This is the only way to connect to Proton Mail via IMAP since everything is E2E encrypted. It is hard to find to market share numbers since providers do not regularly post how many users they have, but Proton Mail is likely the 4th or 5th largest email provider now. Either right behind or before Yahoo! mail, but still behind Gmail, Outlook and Apple.
Supporting Proton is better than not supporting it. Unverified SSL checks are better than not support and/or not using SSL at all.


How to save VAE model

I have a problem when I want to save the VAE model after the training. This is because this
z = Lambda(self.sampling, output_shape=(self.latent_dim,))(
    [z_mean, z_log])

Specifically, the Lambda layer cannot be saved into file. Could you give me any advice to save it?

I just searched around and realize lambda layer is very fragile. we will have to replace that with a custom layer.

for self-reference: https://github.com/keras-team/keras/issues/6442

I solve this problem. While saving the paramters of VAE model, I also save the the initial parameters of VAE class at the same time.

I solve this problem. While saving the paramters of VAE model, I also save the the initial parameters of VAE class at the same time.

HI, can you give me some snippets on how you saved the VAE Model for reference? I am having the same issue.

I can't save Deep svdd model, Could you tell me how you saved VAE model?

As the poster of the issue said, you save the model first, then you save the class.
In the VAE class, there is a build model function. In fit function, it calls the build model function and assign it to self.model_. What you need to do is that you first use keras.save to save the self.model_. Then you make self.model_ = None. Then you can joblib.dump the whole class.
When you load, you first use joblib.load to load the class, then you use keras.load to load self.model_. And you put self.model_ inside the class.
But this will cause error. As I searched, when you are loading the keras model, you need to load the custome Lamda function inside the Lamda layer which is self.sampling. So what you need to do is that copy the self.sampling function in your file, and load it using custome object.
The order looks like this:
Save:
.model_.save()
.model_ = None
joblib.dump(, path)
Load:
 = joblib.load(path)
.model_ = keras.models.load_model(path, custom_objects={'sampling': sampling})
It works for me. But it needs some testing. At least there is no error saving and loading.

@jjjzy Thanks for this information. This sounds like a workaround for now.

Thanks for your help.

I solve this problem. While saving the paramters of VAE model, I also save the the initial parameters of VAE class at the same time.

兄弟，能分享下代码吗谢谢


Add support for construction/assignment from two different integer ty…

…pes.
Improve tests - check for mixed construction, and test domain_errors occur at the correct boundaries.

Edward, here's the PR for mixed-argument construction.  The header was pretty much fine after all with mostly just the "obvious" changes required.  The tests have been significantly enhanced to codify what we expect to happen when constructing from a different type to *this.
I do notice that there are quite a few warnings from the header which really should be silenced, likewise C++14 constexpr support would be nice, but that's all for the future...

The tests pass but I am concerned that the new tests are only for positive numerators and denominators. Shouldn't this also work with mixed positive and negative numerators and denominators ? If so should we not have tests for mixed positive and negative numerators and denominators with mixed types, just to be complete ? Or am I being too picky ?

On 27/03/2017 15:15, Edward Diener wrote:

The tests pass but I am concerned that the new tests are only for
positive numerators and denominators. Shouldn't this also work with
mixed positive and negative numerators and denominators ? If so should
we not have tests for mixed positive and negative numerators and
denominators with mixed types, just to be complete ? Or am I being too
picky ?

The code in BOOST_AUTO_TEST_CASE(conversions){...} pretty
comprehensively tests both maximally positive and negative values, and
then that incrementing/decrementing them results in the expected
domain_error.  Likewise I hope, all the combinations of smaller/larger
types and signed/unsigned variations are tested in there (ah not quite,
just updated for the trivial cases where we're converting from a
narrower type).
What else am I missing?

This email has been checked for viruses by AVG.
http://www.avg.com

There are a few more variations I will add to the test but I will do so after the merge.

Merged #15 https://github.com/boostorg/rational/pull/15.

Thanks!
If we're being pedantic there is still one possible issue: namely, what
should be the result of
rational(INT_MAX, INT_MAX/2)   ?
Currently it will throw a domain error which is at least safe, where as
previously it silently truncated the inputs and produced the incorrect
result "1".
We could however, change the code to construct a temporary
rational<common_type<T, U>::type> and then convert from that if we
wanted to support this corner case.  But I can't imagine many people
being affected....

This email has been checked for viruses by AVG.
http://www.avg.com

I think we are doing the right thing even if we are theoretically "breaking" some code.

On 28/03/2017 10:57, Edward Diener wrote:

I think we are doing the right thing even if we are theoretically
"breaking" some code.

+1.
On second thoughts it also gets very complex if we try to normalize
prior to assignment as there may not be a suitable safe common type
available - for example if the args are mixed intmax_t and uintmax_t.
So I think perhaps leaving it as it is is best.

This email has been checked for viruses by AVG.
http://www.avg.com


custom kernel possibly messing with OpenVPN

So I just tested this by doing a fresh install of Ubuntu 16.04 LTS. After the fresh install, I used this guide http://www.htpcguides.com/force-torrent-traffic-vpn-split-tunnel-debian-8-ubuntu-16-04/ to set up split tunnel VPN. At the end of the tutorial, everything checks out and "sudo -u vpn -i -- curl ipinfo.io" pulls up the right info. After this I installed rclone latest beta, then your scripts. After installing the custom kernel, I rebooted and uname -a verified that it loaded the custom 4.4.52. However, the previous command to check the vpn user's curl info timed out. So to check if the custom kernel was the issue, I rebooted into the original generic kernel and the curl command worked again. I know you've said the custom kernel is mostly the defaults with a couple adjustments, but is there any reason why it would conflict with my split tunneling?

I suspect the package ipinfo.io is missing, net filter is also missing. Looking to get this added shortly.

hmm, I ran this command using the same kernel with no issues.
Do you get any errors on /var/log/messages?

I don't seem to have /var/log/messages in my logs folder, but /var/log/syslog doesn't have anything that would help either.
plex@TreyFive:~$ uname -a
Linux TreyFive 4.4.52 #1 SMP Fri Mar 3 15:38:10 GMT 2017 x86_64 x86_64 x86_64 GNU/Linux
plex@TreyFive:~$ sudo -u vpn -i -- curl ipinfo.io
[sudo] password for plex:
curl: (6) Could not resolve host: ipinfo.io
plex@TreyFive:~$ curl ipinfo.io
{
  "ip": "7x.xxx.xx.x4",
  "hostname": "x.com",
  "city": "North Hollywood",
  "region": "California",
  "country": "US",
  "loc": "x,x",
  "org": "AS20001 Time Warner Cable Internet LLC",
  "postal": "x"

Looks like VPN user is having issues.
Su - vpn
Then try the curl as the user.
On 9 Mar 2017, at 17:43, Andrew Tran<EMAIL_ADDRESS>wrote:
I don't seem to have /var/log/messages in my logs folder, but /var/log/syslog doesn't have anything that would help either.
plex@TreyFive:~$ uname -a
Linux TreyFive 4.4.52 #1 SMP Fri Mar 3 15:38:10 GMT 2017 x86_64 x86_64 x86_64 GNU/Linux
plex@TreyFive:~$ sudo -u vpn -i -- curl ipinfo.io
[sudo] password for plex:
curl: (6) Could not resolve host: ipinfo.io
plex@TreyFive:~$ curl ipinfo.io
{
"ip": "7x.xxx.xx.x4",
"hostname": "x.com",
"city": "North Hollywood",
"region": "California",
"country": "US",
"loc": "x,x",
"org": "AS20001 Time Warner Cable Internet LLC",
"postal": "x"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Nope getting the same "Could not resolve host" issue. Just tried creating another user to run deluge behind the split tunnel VPN and it gets the timeout error.

Can you ping any hosts when your another user?
On 9 Mar 2017, at 18:03, Andrew Tran<EMAIL_ADDRESS>wrote:
Nope getting the same "Could not resolve host" issue. Just tried creating another user to run deluge behind the split tunnel VPN and it gets the timeout error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Created new user (non-VPN split tunnel) and everything works.
plex@TreyFive:~$ sudo useradd newuser
[sudo] password for plex:
plex@TreyFive:~$ su newuser
Password:
To run a command as administrator (user "root"), use "sudo <command>".
See "man sudo_root" for details.

newuser@TreyFive:/home/plex$ curl ipinfo.io
{
  "ip": "7x.xxx.xxx.x4",
  "hostname": "x.com",
  "city": "North Hollywood",
  "region": "California",
  "country": "US",
  "loc": "x,x",
  "org": "AS20001 Time Warner Cable Internet LLC",
  "postal": "x"
}newuser@TreyFive:/home/plex$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=57 time=9.13 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=57 time=9.66 ms
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 9.133/9.399/9.665/0.266 ms

In the guide I linked in the original post, under "Change Reverse Path Filtering" it mentions the kernel routing the traffic correctly. Could the issue be here? For the record, I haven't applied your sysctl.conf file in the scripts.

I will read the guide properly and refer back to you.
On 9 Mar 2017, at 18:16, Andrew Tran<EMAIL_ADDRESS>wrote:
Created new user (non-VPN split tunnel) and everything works.
plex@TreyFive:~$ sudo useradd newuser
[sudo] password for plex:
plex@TreyFive:~$ su newuser
Password:
To run a command as administrator (user "root"), use "sudo ".
See "man sudo_root" for details.
newuser@TreyFive:/home/plex$ curl ipinfo.io
{
"ip": "7x.xxx.xxx.x4",
"hostname": "x.com",
"city": "North Hollywood",
"region": "California",
"country": "US",
"loc": "x,x",
"org": "AS20001 Time Warner Cable Internet LLC",
"postal": "x"
}newuser@TreyFive:/home/plex$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=57 time=9.13 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=57 time=9.66 ms
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 9.133/9.399/9.665/0.266 ms
In the guide I linked in the original post, under "Change Reverse Path Filtering" it mentions the kernel routing the traffic correctly. Could the issue be here? For the record, I haven't applied your sysctl.conf file in the scripts.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

This is resolved in the new kernel <IP_ADDRESS> https://github.com/jaketame/plexgsuite/tree/master/kernel


Multiple displays support

Hello. Thanks for your work. It compiles and runs successfully with esp-idf@esp32s3. But i need to support 8 same displays simultaneously. They are ordered and inder way to me from aliexpress . Is it possible? Any help appreciated. Thanks.

I haven't used more than one display in any of my projects. But you should have some options on implementation.

if the displays all need to be identical you could wire them all in parallel
if each display needs to be unique, you can parallel the SPI lines and provide dedicated DC/CS pins.

Very likely you will run into performance issues with more than a handful of displays due to SPI transfer speed.


Clicking on Child Element in Dashboard Triggers Parent Element Click Event

When clicking on an edit button in the Dashboard, the copy-to-clipboard function, which is set on the card container, is also triggered.

Thank you for the bug report! .


[BUG] Connection disconnect automatically, after sometime auto start when we go to QR page & reload multiple times

Describe the bug
After successfully connecting my number through the WhatsApp QR code on my portal, the connection automatically disconnects after some time, resulting in missed messages. Reloading the QR page multiple times triggers an auto-start of the connection, but the issue persists.
To Reproduce
Steps to reproduce the behavior:

Connect the number through the WhatsApp QR code on the portal.
After some time, the connection automatically disconnects.
Reload the QR page multiple times to trigger an auto-start, but the issue persists.

Expected behavior
I expected the WhatsApp QR code connection to remain stable and not disconnect automatically, allowing me to send and receive messages consistently without interruptions.
Environment (please complete the following information):

Is this on a server?
What do your connectOptions look like?
Do you have multiple clients on the same IP?
Are you using a proxy?

Additional context

The issue occurs when connecting through the WhatsApp QR code on my portal.
Reloading the QR page multiple times triggers an auto-start of the connection, but it is not a permanent solution.
The Plesk panel's real-time updates logs showed the following error entry:

Timestamp: 2023-07-01 15:16:55
Error: <IP_ADDRESS>
Response Code: 400
Request Method: GET
Endpoint: /socket.io/?EIO=4&transport=websocket&sid=Z9_lZsPWyb6YvVa9AAAA
User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
Error Code: 784

Any assistance in resolving this issue would be greatly appreciated.

Literally no one knows your "qr code portal". Also this doesnt seem like a baileys issue.

I'm using Bailey's

If anyone have resolution, please let me know

@SheIITear Who are you? Why you are closing the conversation? It's not spam. I really need help

@SheIITear Do you even have a knowledge of this? Just annoying, I see you have many tickets closed by yourself without giving any resolution. Member will automatically close if he/she get any solution.  @SheIITear is one of the top contributors of this lib. your issue doesn't look like it's because of Baileys, check your code first.
if you don't know what you are doing, you should hire someone to do it for you. don't create unnecessary issues here.

@bentacos Before commenting anything check the ticket details first.

this part:
Endpoint: /socket.io/?EIO=4&transport=websocket&sid=Z9_lZsPWyb6YvVa9AAAA
already tells that this is not caused by baileys, socket.io doesn't ship with baileys by default. don't make me get my belt.

@SheIITear Who are you? Why you are closing the conversation? It's not spam. I really need help

As I said above, no one knows what your qr code portal is.
That endpoint is not used in baileys nor is plesk and that 400 makes it more clear that the issue is in your own code.

Hence I close your issues. This is not a baileys bug. If you want help with other stuff ask on proper places, like github discussions or the discord server.

@SheIITear im thinking that this guy probably bought a script with baileys as lib somewhere and thinks baileys is owned by that script author


Auto load profile on subjob change

I need this to set some keybinds based on my subjob without having to change my main.

You don't get to choose what features LAC core has, if you want to maintain your own branch you are welcome to but this isn't a feature I want to have present.  You could just as easily add something inside your profile that detects a change in subjob and redoes binds.


SRLinux + vJunos-switch lab-example

I was curious what the meaning of this line was in the srlvjunos01 lab example:
      image: registry.srlinux.dev/pub/vr-vjunosswitch:23.2R1.14

and why we wouldn't flag the image as vrnetlab/vr-vjunosswitch:23.2R1.14 instead? I like the idea of being able to pull these VMs as docker images from some public registry but was curious on why you chose this to flag the image.

This is an internal name that I accidentally committed. This repo is not available publicly, I'll amend it

fixed in 722c201


Fix failing link tooltip Karma test

These tests have been disabled:
should display the link tooltip correctly
They should be fixed and enabled.

@miina - @embarks and I are still seeing this test fail intermittently :(
https://github.com/google/web-stories-wp/pull/6957/checks?check_run_id=2272538982

Eh, okay. It passed 3 times in a row so thought it got fixed :/
Will disable the test in another PR again.

After some investigation this is where I've gotten to:
After re-running this test in CI a few times, we finally hit this error: Error: no node found for selector.

This bug can generally be fixed with page.waitForSelector but it looks like the tests don't have access to puppeteer's page object, right?
Initially it was not reproducible locally, but that was because we were running it in a browser. This test fails consistently when run locally in headless mode.
When run locally in headless mode, we see a slightly different error: Error: Node is either not visible or not an HTMLElement which suggests that the element is not in puppeteers viewport. The puppeteer docs state that the click method should scroll the element into view though, and that works when testing in the browser. I'm hoping that both errors are coming from the same problem, since they're similar errors
It seems to me that the fixture.events.click method is not scrolling the link input into view when in headless mode before we try to click. I've found some threads online that suggest using page.evaulate to ensure that an element is scrolled into view.
@miina @swissspidy I want to try using the page.evaluate method to try to fix this text but I don't know where puppeteer's page object is being kept in our custom puppeteer setup. Do y'all have any ideas about how we could get access to the page object?

This bug can generally be fixed with page.waitForSelector but it looks like the tests don't have access to puppeteer's page object, right?

Not at the moment. We use  Testing Library's waitFor function most of the time for that, e.g. await waitFor(() => fixture.screen.getByRole(...))

When run locally in headless mode, we see a slightly different error: Error: Node is either not visible or not an HTMLElement which suggests that the element is not in puppeteers viewport. The puppeteer docs state that the click method should scroll the element into view though, and that works when testing in the browser. I'm hoping that both errors are coming from the same problem, since they're similar errors.

Puppeteer does indeed scroll. And perhaps the issue in this case is not the scrolling.

It seems to me that the fixture.events.click method is not scrolling the link input into view when in headless mode before we try to click. I've found some threads online that suggest using page.evaluate to ensure that an element is scrolled into view. However, I've tried using element.scrollIntoView and have had no luck.

This comment from that thread you linked to seems very relevant:

So, .click() call is failing likely because the pointed element actually has the 0x0 rectangle, which often happens when element is simply a wrapper.

This seems worth testing.

I want to try using the page.evaluate method to try to fix this text but I don't know where puppeteer's page object is being kept in our custom puppeteer setup. Do y'all have any ideas about how we could get access to the page object?

I'm not sure you really need that.
page.evaluate() simply evals a function in the page context (i.e. in the dev tools browser console). But in the Karma tests you're already in the page context and can access elements using the Testing Library utils and the fixture.
In other words, you don't need to do page.evaluate(()=> ...) when you can just do document.querySelector(...) or fixture.screen.getBy.. in tests.
FWIW, karma-puppeteer-launcher and karma-puppeteer-client are the packages exposing Puppeteer functions to the test suite (then consumed by karma-fixture / fixture.events

Thanks for the well written reply @swissspidy. It really helped narrow down what I was doing wrong.
I was running npm run test:karma:edit-story -- --headless but it was failing because the viewport size was not being set. I assumed that the config in jest-puppeteer.config.cjs was setting the viewport, but I was wrong. Running the test with npm run test:karma-edit-story -- --headless --viewport=1600:1000 made the tests pass ✅
Ended up adding some waitFors to make sure the elements were rendered before trying to click them.


Request to merge Development into main

Dear  reviewer, below are the pull requests we merged to complete the project requirements, our team consisted of three developers (@flemton , @LarryIVC, @muneeb3123 ) working together with different ideas and merge conflicts but we emerged victorious against those merge conflicts 😄  , here are the PRs and commits:

initialise and install linters
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/33 from muneeb3123/main-class
Merge branch 'setup' into book-label
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/35 from muneeb3123/book-label
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/36 from muneeb3123/console-app
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/39 from muneeb3123/test-game-author
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/40 from muneeb3123/feature/music-class
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/41 from muneeb3123/feature/genre-class
Merge branch 'preserve-data-game-author' of github.com:muneeb3123/rub…
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/42 from muneeb3123/setup
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/43 from muneeb3123/preserve-data-game-author
Merge branch 'feature/tests-student-B' into feature/preserve-data-b
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/45 from muneeb3123/feature/preserve-data-b
Merge pull request https://github.com/muneeb3123/ruby-capstone/pull/46 from muneeb3123/preserved-data-a
Merge branch 'dev' into games-auhtor-methods
Merge branch 'games-auhtor-methods' into dev
Any requested changes are welcome, also, specific commits can be found in each PR, cheers 🥂

Thanks, @VICTOR-CHUKWU, for your review and feedback, have a nice day.


Door "closed" treated as active trigger

What is the feature?
Description

Contact sensors used as door sensors when closed should be treated as active triggers.
Additional Information

Because Home Assistant treats open as on and closed as off this integration reports open as an active trigger and closed as not active. This should be reversed as a closed door with motion in the room suggests higher probability of occupancy over an open door with no or recent motion.

Wouldn't it be more logical to categorize doors separately rather than classifying them as Motion Sensors?
Creating separate categories for doors and motion sensors in area occupancy detection can offer several benefits:
Improved Accuracy: By categorizing doors separately, you can more accurately track entry and exit points. This helps in distinguishing between people entering or leaving a space, leading to more precise occupancy data.
Enhanced Data Analysis: Separate categories allow for more detailed analysis. For example, you can analyze patterns of door usage independently from general motion, providing insights into traffic flow and peak usage times.
Just a thought.

There will be a new release in the next few days, I have created more device categories I'll add one for doors, good idea :)

I agree it would be nice to have Doors as its own category but my original point of having a door closed treated as active is seperate. Even if there's an invert checkbox option that new category, just so closed doors are considered active triggers.

I agree it would be nice to have Doors as its own category but my original point of having a door closed treated as active is seperate. Even if there's an invert checkbox option that new category, just so closed doors are considered active triggers.

Understood, ill have a think about how to implement that as a toggle or something

Thanks

Thanks for your amazing work and efforts @Hankanman


Update dolt.py

add missing word in docstring

Thank you @CaptainStabs . Next time ping me as a reviewer, otherwise I don't seem to get PR notifications.


Song Audio Not playing (without source code)

Describe your bug here.
i replaced the song audio with the new one and it doesn't play the audio and it's still 0 seconds
what should i do?
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, i replaced the song audio with the new one, and it's still 0 seconds

is the song audio named "Inst" ?
the file also needs to be a .ogg file

make sure it's "ogg" file

Missing the file mods/songs/your-song-name-here/Inst.ogg
Don't forget, the song path must be all in lowercase, and Inst starts with an uppercase i.
The file format also MUST be .ogg

yup still aint workin. already did a issue so I wont explain


Fix #997

cc @phg1024

In my experience this does not fix #997 since the macro will be prefixed with math:: in https://github.com/caffe2/caffe2/blob/master/caffe2/utils/GpuBitonicSort.cuh#L42.
I fixed this in #878 by using std::integral_constant see https://github.com/willyd/caffe2/blob/f556dd4cc2c8f1b0f2508dde5fb2dd94bac898d5/caffe2/utils/GpuBitonicSort.cuh#L42

cc @Yangqing

Thanks! Will work on those PRs.


Refined Complete Plan and Uncomplete Plan message outputs

complete-plan 0 should not return "Invalid Command" as shown in the picture

should return "The plan index provided is invalid"

same for uncomplete-plan

This is to ensure consistency between delete- and edit- commands

UG


#501. Fixed build issues on MSYS on Windows.

This is a fix for build issues on windows.

Just FYI: This does fix it for me in Windows. +1

If this is fixed, how do I get my system upgraded with this fix? I'm still having problems after two weeks of trying.

you need to use the 64-bit version of msys2. Start the terminal with mingw64.exe.

you need to use the 64-bit version of msys2. Start the terminal with mingw64.exe.

thanks, I'll give it a try


Add an allocator test for preinit task object

Add a specific test case to test allocation of a task which is already
in store and has no network attachments created before allocator is run.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

Confirmed that this test triggers the problem.
It will need a minor change to be backported to 1.12.x (watchTask takes one fewer argument on that branch).
LGTM

Current coverage is 57.12% (diff: 100%)

Merging #1661 into master will increase coverage by 0.18%

@@             master      #1661   diff @@
==========================================
  Files            90         90
  Lines         14588      14588
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           8307       8334    +27
+ Misses         5193       5180    -13
+ Partials       1088       1074    -14

Powered by Codecov. Last update 266ae94...6b7cb35


"An object could not be cloned" when promise is rejected with an error

It's considered a best practice to only reject promises with an Error (or derived object).  Unfortunately, this breaks operative as errors can't be cloned.  This results in an uncaught error within operative's returnResult in the context of the web worker, leaving the primary thread hanging waiting for a response that will never arrive.
I believe that operative should handle this case somehow.  If the error can't be cloned via postMessage then we need to do something to tell the main thread that the operation failed -- either transfer the error object using JSON (which can serialize errors, albeit without their functions/prototype) or some other kind of operative-specific error that wraps a structured-cloning-compatible version of the rejection error.
As it stands right now, operative's promise interop is all but useless since it is completely unable to proxy rejections back to the main thread.

Thanks for reporting this. I'm not sure which is the best route to take here. Please see #45 and let me know if this fixes your case / and if you think that's a generally fair approach.

I think that approach probably makes the most sense.  I'm wondering if it would be beneficial to also transfer the name and code attributes.  name is standard, and while it is supposed to indicate the class of the error (something we can't really do since we don't want to try finding the right prototype on the other side) I would argue that it's better to have that than not to have it.
code is used in a lot of places in Node to convey the exact condition of the error (in the AWS SDK it is used very heavily) and a lot of npm modules make use of this convention.  When they are used in a web application via bundling, it would be nice if this attribute could be proxied over as well.
Of course, we could wind up down a rabbit trail where we are building an ever-increasing list of things that we need to transfer.
An alternative approach would be to simply pass back a JSON-encoded version of the error object.  This will catch any attributes/structures that can be represented in JSON, which should be pretty much anything of value.  (Usually we don't try to intentionally pass functions on Error objects.)

Just released 0.4.6 which manually clones over any props on native Error objs. Hope that solves your use-case. See specs here: https://github.com/padolsey/operative/blob/b1353cb6961d8bc4f410149401e950d111e6e9b3/test/operative.spec.js#L110-L142
(Thanks for reporting this, once again!)


Newly created pod can't be fetched

This issue occurres when using Blossom in Fairdrive. After creating a pod, the pod list on the left side is automatically refreshed, but the new pod doesn't appear in the list.
To confirm that the error doesn't come from Fairdrive or Blossom, this line of code is relevant:
https://github.com/fairDataSociety/blossom/blob/a4f3e3087dee02b45916b0b70c48347cd7c3e366/src/services/fdp-storage/fdp-storage-access.ts#L138
Here the service worker script invokes appropriate methods from fdp-storage. If responses are logged out, there will be an entry for creating a pod and after it finishes another entry will appear which returns list of pods. But the list pod won't include the new pod there.

Just to add recent findings. I reproduced this issue in Fairdrive directly, without Blossom.
Steps to reproduce:

Compile browser version of fdp-storage from fix/bee-js-new-762 branch.
Replace the compiled index.browser.min.js in node_modules of Fairdrive
In src/context/FdpStorageContext.tsx file, disable caching by setting isUseCache: false
Run Fairdrive, log in and create a pod

Pod list will refresh but without new pod.

@tomicvladan @darkobas2
The error is also sometimes reproduced in Fairdrive with "@fairdatasociety/fdp-storage": "^0.11.0" and the cache is disabled (isUseCache: false).
After a manual test, it turned out that the problem is due to the fact that the bee-1 server responds with old data for the chunk (404 error instead of current data). After some time (seconds) the data becomes available.
Apparently, the problem may be in the caching of the chunk request OR in the correctness of the responses of the Bee node.
The chunk containing new data is requested before the data is written there, so this may be the reason for caching the Bee node's responses. Although the node can make chunk data available after some time if the Bee node has been updated with some new mechanisms.
It is required to test the server side:

Generate chunk and get its address
Request a chunk that has not yet been uploaded to the server (example url https://bee-1.fairdatasociety.org/chunks/daa4d8d97b49d22d694ff6969e3ae02b909bef7a3db76c8feeab14c8e7a079a6)
Upload chunk to this address
Try to download chunk
Analyze server responses to determine what exactly is causing the delay in data availability

If this behavior is on the side of the Bee node, then it is worth planning changes in the fdp protocol that could detect the moment when the data becomes available.

@darkobas2 this is probably connected with serverside caching, chunk is in cache and is not being updated. Can you disable caching on gateway so we can test this and eliminate potential issue ?

We tested this with caching disabled. Still exists.

I am attaching a har with all the site requests. har can be opened on this site https://toolbox.googleapps.com/apps/har_analyzer/.
Check the POST request to https://bee-1.fairdatasociety.org/soc/c61a782953dec13ec9614469a2801b029378ee48/cf29db53d5c44182b4c8b222b1e0036eb48bbedd3b6087ae80426e9e275774aa?sig=58d35bd3d67619ca18756c3e1487a521c7d7a8275baf5a3becd442b1aaeae8d3524cf784501dc43f27c77391c76e062d3db8f1ca7b3dc93daa2de49098c708c51b
It returns {"reference":"d70c30039aafcc857d18ddaf35c6339ca04a5357b9b7bf992a5be8b5b143a055"}
Then there is a GET to https://bee-1.fairdatasociety.org/chunks/d70c30039aafcc857d18ddaf35c6339ca04a5357b9b7bf992a5be8b5b143a055 which returns {"code":500,"message":"read chunk failed"}
After a few seconds the data becomes available
soc-error.har.zip


beautiful module

Hi I tried this module before but unfortunately it's not supposed any of global apps, but on EU custom rom the dark mode including all apps like social media ones and other more u can put it on dark mode I hope u bring the same EU rom feature or maybe it's work but not on my root I hope to upgrade it to become supporting kernelsu

Thank you for using my module! Unfortunately, I don't have a foreign version of my Xiaomi phone, so I can't fit it. If you have time, you can try to adapt, please understand the inconvenience.

Thank you for using my module! Unfortunately, I don't have a foreign version of my Xiaomi phone, so I can't fit it. If you have time, you can try to adapt, please understand the inconvenience.

thanks for answer me back


Document environment variables of MacOS images

Description
Improvement
the following environment variables that are mentioned in documentation:
All platforms:
ANDROID_HOME
ANDROID_SDK_ROOT
ANDROID_NDK_HOME
CHROMEWEBDRIVER
EDGEWEBDRIVER
GECKOWEBDRIVER
VCPKG_INSTALLATION_ROOT
CONDA
ANT_HOME
GRADLE_HOME
Related issue: https://github.com/actions/virtual-environments/issues/2452
Check list

[x] Related issue / work item is attached
[ ] Changes are tested and related VM images are successfully generated

Android variable section is empty

Android variable section is empty

Yay, thanks a lot!!


Mac GUI up and running but...

DLed the new GUI got it up and running, but my address is not listed on the driveshare list and it is building shards in the fold. When it crashes I have to build in a different folder and delete those shards and go back to my old folder to keep the build going.

dannydesert [03:30]
@tome is just crashed again
dannydesert [03:30]
here is the script from the end
dannydesert [03:30]03:30
Nov 11 18:28:55 Cameron.local dataserv-client[3514] : INFO dataserv_client.builder 131: Saving seed b92e0add76ff55d1526c799f656fcff35da7b14234d89b14dab0c1dd0e4a9c70 with SHA-256 hash efd268d73617f900a6a70294739fb8442912d6dc99fba8a5e6598ede2437326b.
Nov 11 18:28:56 Cameron.local dataserv-client[3514] : INFO dataserv_client.messaging 43: Query: http://status.driveshare.org/api/height/14xVnbyGPeyfKQkLdt8oV2rQyyR52NkJLP/2175
Nov 11 18:28:57 Cameron.local dataserv-client[3514] : INFO dataserv_client.api 190: Current height at 2175.
Nov 11 18:29:13 Cameron.local dataserv-client[3514] : ERROR dataserv_client.builder 75: Failed to write shard, will try once more! 'OSError(5, 'Input/output error')'
Nov 11 18:29:15 Cameron.local dataserv-client[3514] : 2015-11-11 18:29:15.313 dataserv-client[3514:63042] dataserv-client Error

Problem is usualy a bad hard drive connection. USB drives or network drives sometimes loose connection for a short moment. There is already a one time recovery "Failed to write shard, will try once more!"
The big questions for me is why you can not resume from the last height. Can you write that log as well?

I got it to start writing from the height, I was checking it wrong.  The biggest problem is that my building is not getting reported to the Drive Share website.
exports.child 6339 terminated
/Users/troymurray/Library/Application Support/DriveShare/dataserv-client.app/Contents/MacOS/dataserv-client --store_path=/Volumes/StorJ --max_size=9TB farm
Nov 12 11:55:45 Cameron.local dataserv-client[6353] : INFO dataserv_client.messaging 43: Query: http://status.driveshare.org/api/address
Nov 12 11:55:46 Cameron.local dataserv-client[6353] : INFO dataserv_client.messaging 43: Query: http://status.driveshare.org/api/register/14xVnbyGPeyfKQkLdt8oV2rQyyR52NkJLP/1KPVor6JAxfgS5CPURvtA4BuW2UyLHgRrF
Nov 12 11:55:48 Cameron.local dataserv-client[6353] : INFO dataserv_client.api 175: Starting build
Nov 12 11:55:48 Cameron.local dataserv-client[6353] : INFO dataserv_client.builder 108: Resuming from height 8297
Nov 12 11:55:52 Cameron.local dataserv-client[6353] : INFO dataserv_client.builder 131: Saving seed 317c4c24d76ca8940ebcc9a2dba0bb3e9153c4f8972bc175162010b482728486 with SHA-256 hash c34d5b5805ba698506c9aff2e7053f55d131ed80f379c206324465f49464f318.
exports.child 6353 terminated
I only get one QUERY and that's when it starts building

Looks like a bug in driveshare-gui. Workaround for now. Use dataserv-client without driveshare-gui until this bug is fixed.

Can you explain what the bug is? I'm a bit confused here.

Gamedevsam?  What don't you understand.  The GUI doesn't send my address to the driveshare page so the system doesn't think I'm running anything.

The GUI simply stores your address in a config file and passes it off to dataserv-client when you run the process. Could you click on "View Logs" and copy and paste what you see in that window after you click the Start button?

@DannyDesert This is an issue with driveshare-client, driveshare-client is the only thing that sends your address to the page. Please open up the issue here: https://github.com/storj/dataserv-client/issues


chore(package): update rimraf to version 2.6.0

https://greenkeeper.io/

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a4c0237). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage          ?   40.63%
=========================================
  Files             ?       19
  Lines             ?      475
  Branches          ?       81
=========================================
  Hits              ?      193
  Misses            ?      282
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c0237...ede1f18. Read the comment docs.


Fortran component build

Currently, from numpy.distutils.misc_util.Configuration is used to build Fortran components. This approach is currently deprecated. When running
python -m build
The following is reported:
`numpy.distutils` is deprecated since NumPy 1.23.0, as a result
  of the deprecation of `distutils` itself. It will be removed for
  Python >= 3.12. For older Python versions it will remain present.
  It is recommended to use `setuptools < 60.0` for those Python versions.
  For more details, see:
https://numpy.org/devdocs/reference/distutils_status_migration.html

TODO:

[ ] Find a solution that relies on setuptools.

Also, since it seems we are getting ~equivalent performance using numba maybe we should

only worry about fortran for development installation from the repo or
consider dropping fortran options to simplify pywatershed

I think we should adopt Fortran as develop only until we find some reason to motivate us or signal we should drop fortran.
The pathway from numba to fortran to compiled code is something I've enjoyed and maybe a reason Fortran sticks around,  but maybe it's not necessary.

with #188 fortran compiles are only for editable installs.

pip 25 is going to deprecated legacy-editable installs and will force the issue at that time.
The fortran is no longer being tested in CI but is still available. Deprecation seems likely, pending some more performance comparisons against numba.


Fix links to AVD docs

The links that point to AVD Docs "What is Azure Virtual Desktop" and "Prerequisites" do not match the context of the sentence

Learn Build status updates of commit 98cc89b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/terraform/configure-azure-virtual-desktop.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@TomArcherMsft,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


accept custom cluster config locations

Signed-off-by: Nianyu Shen<EMAIL_ADDRESS>

@mauromorales @Itxaka can we merge this pr if its good?


Bad credentials error when trying to post comment to GitHub

If you take a look at the CI output of this test PR you can see that while the ink-waterfall pipeline succeeded no comment actually got posted on GitHub due to a "Bad credentials" error.
There's probably an outdated access token somewhere that we need to update.

I think this GITHUB_TOKEN here stopped working: https://github.com/paritytech/ink-waterfall/blob/master/.gitlab-ci.yml#L35-L37.
@alvicsam You recently updated another token, could it be that this token needs to be updated as well?

I applied a temporary fix so it works now. But I need to make a few adjustments in the future


RUF001: exclude × by default

From https://github.com/astral-sh/ruff/issues/4859#issuecomment-1576776381, I see that you seem to consider VS Code as (one) reference to determine which characters should be reported in RUF001. VS Code does not flag ×, so maybe ruff should allow it by default, too.
Otherwise, I am fine with adding allowed-confusables = ["×"].

Yeah our behavior should match VS Code. Will take a look.

It looks like VS Code does flag it... But we may be enforcing this in places VS Code does not. Is there any other context you can provide on this one?

In fact,

https://github.com/microsoft/vscode/blob/main/src/vs/base/common/strings.ts#L1081C15524-L1081C15527 has  215, (only) in _default, es, fr, it, ja, ko, pl, pt-BR, qps-ploc, ru, tr, zh-hans, zh-hant, but not in de.
https://github.com/hediet/vscode-unicode-data/blob/main/out/ambiguous-formatted.json looks similar.

I have no idea on what basis these are filled, but that explains why I did not see the highlight. I think this can be closed.

Ahh okay, that's interesting... Thanks tons for following up! I'll close for now.


Releases performance

What?
Improve Releases page performance
Jira ticket: https://jira.fundingcircle.com/secure/RapidBoard.jspa?rapidView=22&projectKey=ENG&view=planning&selectedIssue=ENG-210
How?
By retrieving feature status from snapshots instead of processing events on the fly
Note on deployment
This changes the way snapshots are captured. This requires the clearing and reprocessing of all old snapshots. Run rake db:clear_snapshots following deployment.

Thanks for reviewing @iainbeeston. The comments I haven't replied to are welcome to be made.

I believe this branch is ready for merge, and, as agreed, by Chris (product owner), can be deployed to production.

Great. LGTM. Feel free to merge once ready to deploy. Pls remember to reset the snapshots ofter deploy.

Thanks everyone, going to deploy this now.


Ambiguity with GET and no included fields

The existing semantics were written with the POST JSON body format in mind, and have an ambiguity when using GET and query parameter fields.
Rules 3 & 4 state:
If only exclude is specified, the specified fields should not be included, but every other field available for the Item should be included.

If exclude is specified and include is null or an empty array, then the exclude fields should be excluded from the default set.

However, with GET, the non-existence of + or no prefixed fields could result in the semantics of starting with the full item or with the default fields.

I think the most reasonable thing here is to have GET with only excluded fields mean excluded from the default fields. In practice, clients should be explicitly stating the fields they want included and only excluding to ensure that possibly large default fields that arent' going to be included (e.g., geometry, assets)

I think the most reasonable thing here is to have GET with only excluded fields mean excluded from the default fields.

Makes sense to me.


DeepKE with Transformers >= 4.4.2

Hi,
I want to use LightNER for Transformers >= 4.4.2 since the pre-trained models are supported in the higher version of Transformers.
However, the modeling_bart.py in DeepKE is adapted on Transformers 3.4.0. I tried to adapt your customization for LightNER on the new modeling_bart.py from Transformers 4.4.2 but encountered some problems.
Do you have any advice on how I can implement new models with LightNER and Transformers 3.4.0?
Thank you in advance!

Hi,
Since modeling_bart.py are different in Transformers 3.4.0 and Transformers 4.4.2, you need to modify the modeling_bart.py to adapt the Pluggable Guidance Layer in LightNER. A reference example is UnifiedSKG, they adapt the prefix-tuning in more higher version than Transformers 3.4.0.

Thank you! I will take a look at your reference :)


"lag" / forced scrolling issues

https://atmosdb.novusphere.io/discussions/upload/image/1594232420616.gif

t ack didn't notice any lag

so I test it in three configurations
On iPhone XR - no lag
On MacBook Pro + Chrome - Jitters
On MacBook Pro + Safari - Stutters

adding video provided by @bluabaleno : https://www.youtube.com/watch?v=L0zextM-YDI
issue only seems to be with dialog, not with threads itself

closed for now... may be reopend later under refinement


remove linting error for private entity code on the consumer side (reference is also coming plus we should ot show private action in general)App for reference : https://release-ee.appsmith.com/app/untitled-application-1/page1-65c4ac9b64418d40ff353765/edit?environment=production

https://www.notion.so/remove-linting-error-for-private-entity-code-on-the-consumer-side-reference-is-also-coming-plus-we--f91bafb1d09f4578a428a396b8552b91

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed


The head of table sticks to top when scroll down

Describe the feature you'd like
Sometimes we have long forms, and when scrolling down the head of the table is long disappeared and people may not understand the nature of a particular cell. Maybe it is possible to have the head of the table stick to top of the page when scrolling down until the table itself is not visible anymore?
Describe the benefits this would bring to existing BookStack users
It would benefit to UX for pages have long tables, especially when cells containing only "yes" and "no" values or something like that.
Can the goal of this request already be achieved via other means?
Not sure.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months
Additional context
No response

Thanks for the suggestion @apsonandtesla.
This is probably not something I'd look to include by default, due to varied use of tables and opinion of sticky headers, but this can easily be added via some custom CSS styles in the "Custom HTML Head" content setting. Here are a couple of different examples, depending on desired usage:
<style>
    /* Specifically makes table headers sticky
       You can make a table row into a header via the table
       editor button > "Row" > "Row Properties"  > "Row Type" dropdown
       > Select "Header" option.
    */
    .page-content table thead {
        position: sticky;
        top: 0;
    }
</style>

<style>
    /* Makes the first row of any table sticky.
       More general than the above and will always apply, without marking
       a header row.
    */
    .page-content table tbody tr:first-child {
        position: sticky;
        top: 0;
    }
</style>

I'll therefore close this off but feel free to still comment if you need help with the above.


Mobile filter parity

Changes

In mobile, filters are now applied on selection (as opposed to after "apply" button click)
"Filter results" button becomes "View ## results" button, which sticks to bottom of screen/bottom of filter drawer
When filters are applied, "clear all filters" button lives underneath "view results" button in bottom button bar

Thoughts:

the changing count in button text is not super noticeable IMO; @admoorgit thoughts for how to make it pop more? Bigger font?
Should clicking "clear all filters" close filter drawer ?

Screenshots

Checklist

~[ ] if adds a new page, adds accessibility tests~
~[ ] if adds a new page or new interaction, adds e2e test~
[ ] if adds a new page or new interaction, sends google analytics events and updates GA doc <-- this should just work and match events from desktop interactions now (please confirm, @cathydeng !) EDIT: update GA doc to note "apply filter" event is deprecated
~[ ] if changes filter functionality, updates filters doc~

Fixes https://app.asana.com/0/1202690670605811/1203031893746133/f

@jlhogan getting closer! Here are some thoughts:

Now that I'm futzing with it, I think the "Close" button should actually be "Cancel" to suggest it won't apply the filters, since it doesn't
Please change "Filtered by" to "Filter by" to make it more actionable

We should also make this text smaller so it fits on one line — H2 mobile size, and make all the filter titles H3 sizes

Page still scrolls past the "View/Clear" buttons but is only the footer, which is progress! Possible to not see the footer on scroll?
Page should pop to the top if clicking View OR Cancel (so people don't get confused about where they are)

I think that's it! If you have any questions I'm around.

a.

@jlhogan this is great! Only change is to get "Filter by..." on 1 line. Otherwise approved!


Implement new Places Api Call and sessionToken

Status
My PR is READY
Description
What's new:

usePlacesApiNew(default false): Implement Places Api (new) #9
useSessionToken(default true): add the uuid package, generate a v4 uuid for the session that expires after firing the place details call (this helps getting multiple calls billed togheter) #9
minInputLength(no default): useful if you want to call the api only if the user typed a minimum characters.

Fix:

typo in getPlaceDetailsWithLatLng (BREAKING)
moved the check of empty text on top of getLocation to avoid useless api call

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[x] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[x] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Implemented with #23


What is the "diam" parameter in the datafiles?

I understand this is probably the model diameter for purposes of 6D pose estimation metric, but what are the units? Is it scaled somehow? Is it the diameter along a particular axis?

Here the diameter refers to the maximum distance among the distances between each vertex of the 3D object model. Its unit is given in meters.

Thank you! I'm assuming this is found with the modeling software you used to create the models?

@btekin thanks for your work. May I know why the diameter value is involved? Thank you.

We need the diameter value when evaluating the accuracy. When computing the accuracy of our approach on the LineMod dataset with the so called ADD metric, we take a pose estimate to be correct if the mean distance between the true coordinates of 3D mesh vertices and those estimated given the pose is less than 10% of the object’s diameter.


Dropbox Sync won't start

I can't start this app
My config:
{
"oauth_access_token": "xxxxxxxxx",
"output": "HassioBackup",
"keep_last": 3
}

20-01-08 02:29:18 INFO (SyncWorker_14) [hassio.docker.interface] Clean addon_7be23ff5_dropbox_sync application
20-01-08 02:29:36 ERROR (SyncWorker_14) [hassio.docker] Can't start addon_7be23ff5_dropbox_sync: 403 Client Error: Forbidden ("endpoint with name addon_7be23ff5_dropbox_sync already exists in network hassio")


Fix buttons view on mobiles

@yammesicka please assign to me
I fixed it

Currently this is only a partial fix - I would prefer using a @media query that hides the exercise id, the notebook id and the number of errors, leaving only the exercise name (maybe with a smaller font) and the button.

Fixed by @ron-huberfeld.


TransitionTable Polish

Use material tooltips to provide descriptive tooltips for the columns. When users hover over column titles, a tooltip should appear explaining what the transition share and SOC code means. You can use material tooltips to accomplish this: https://github.com/mbrn/material-table/issues/1263#issuecomment-567828595
render the job name in each row as an OnetLink that opens the O*net pages for the occupation using the transition’s soc code.
Increase the width of the job name column relative to other columns
Sort data in decreasing transition share by default

Material Table actually supports tooltips natively. Just add a tooltip field to column definitions


[CTIS QSF tools] Tool to reformat Qualtrics translation files to be more human readable

Description
Make new tool to convert QIDs in translation CSVs into item names, based off of codebook.
Changelog

replace_translation_qids.R
generate_codebook.R
qsf-utils.R

@krivard this is ready to merge.


rename react lifecycle methods to prefix "UNSAFE_"

hi @chenglou and @nkbt! what do you think of potentially shipping this quick rename? it comes from $ npx react-codemod rename-unsafe-lifecycles and would make the developer experience a little better for consumers that are on react v16.9, like we are at @Frameio
for anyone just catching up with this situation — please note that this rename fixes the console warnings introduced in<EMAIL_ADDRESS>such that code will run in react@17, but this rename doesn't address the underlying issue
edit: i pushed a config change just to get the build to pass, so please lmk if there's a different way that would work better here

technically fixes #569

@nkbt awesome! i don't have merge permission though, can you merge this?
yes, the eslint change was just to get the build to pass

I've tested this PR and also check if built version works ok in one of my projects and everything seems to work well without React warnings. Merging in.

Cannot publish until https://github.com/chenglou/react-motion/issues/577


Add guide to Studying Abroad

(@rohit-ganguly) Add your beautiful mind of information into the markdown file in here https://github.com/PittCSWiki/pittcswiki.github.io/tree/master/src/pages/guides


Tidy up the category labels so that they are uniform e.g. same size boxes and 2 columns of boxes 9 and 8.

Try to make the categories display 2 across. (flex grid )


HBASE-25836 RegionStates#getAssignmentsForBalancer should only care about OPEN or OPENING regions

RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING).
The current checks are not actually comprehensive. For example, splitting states are considered, but not merging.
Filter out regions not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations for the current iteration. Regions in all other states can be expected to not be of interest – either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) – until at least the next chore iteration.

Tested in an integration cluster test scenario (see https://github.com/apache/hbase/pull/3208) but let's see what the unit test results in the CR report looks like.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

Updated after feedback

Update the new comment in RegionStates to be more clear.

Whitespace fix.

Address @virajjasani 's comment

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.