Core Refactoring

PR
https://github.com/ethereum/grid/pull/524
Related Issues describing the vision
https://github.com/ethereum/grid/issues/315
https://github.com/ethereum/grid/issues/445
Changes

Architecture: https://github.com/ethereum/grid/issues/523
Workflows: https://github.com/ethereum/grid/issues/525
Changes to Plugin: Client and ClientManager #520
Changes to Plugin: Replace ClientManager plugin with workflow: https://github.com/ethereum/grid/issues/526
Changes to API and RPC server: https://github.com/ethereum/grid/issues/522
Grid-Core module: https://github.com/PhilippLgh/grid-core

All necessary JavaScript files are ported to Typescript in the process.
Progress
Electron App Manager

[ ] migrate all backend / repo logic to ethpkg (80%)
[ ] migrate all release management logic to ethpkg (50%)
[ ] migrate all app loading logic to app-package-server

Grid

[X] port Plugins to typescript
[X] migrate PluginHost into PluginSystem in grid-core
[X] port ControlledProcess to typescript
[ ] refactor Plugin to Client and ClientManager (80%)
[ ] replace PluginHost occurrences with grid-core (50%)
[ ] create simple RPC wrapper to replace injected API (20%)
[ ] create json-rpc http server (10%)
[ ] create websocket server for events (0%)
[ ] port AppManager logic to app-package-server (0%)

Application Flow
Starting Nano
Nano is the menubar UI. It is not packaged or updated independently at the moment. Refactoring nano to React and merging it into grid-ui is probably not part of v2
Nano should be able to start even without the API server (immediate user feedback) and implement a mechanism to connect to other servers without reload.

Please note that the API server could also be a list of connection which when clicked on display the state of a remote machine.
Plugin Init
grid-core starts by initializing plugins.
This is a 2 step process:

local plugins i.e. scanning the file system
remote plugins: parsing registries & fetching packages
Because this has the potential to take quite long we will use events to inform about the state.

API Server
Next, grid-core will start the the API server. The grid-electron app should check if the API is already available and if not can start the server is necessary.
The API server implements json-rpc and allows grid-electron but also other consumer such as remix-grid-plugin to query the state of existing and running binaries and make requests to interact.
API-READY
Once the plugins are initialized and the API is available, Nano will start with a query to:
getAllClientManagers()
The ClientManager instances are initialized based on plugin information and represent all Clients i.e. available and running binaries to interact with.
In UI-terms, a ClientManager will e.g. create an entry for Geth even if no local binary is available. Note that this entry will also have a start button in the UI. If multiple clients of the same type are run such as validators the UI should expand into something like a tree-view to show all Geth or CLIENT instances.
Nano will query each ClientManager for available and running clients with:
clientManager.getAllClients(). Each client has it's own state and lifecycle stat needs to be reflected in the UI. Moreover, each react-client-item should assign listeners and observe state changes of the Client that need to be reflected.
A common case is that a ClientManager instance only represents one Client. In this case, the tree-view listing all clients can be collapsed and the state info displayed inline on the header.

Nitpick: it's better to use <IP_ADDRESS> instead of localhost, because it's independent to the hosts config of each user.

Update: grid-core failed to achieve and implement all of the above ideas in a single module. This is largely due to the fact that it tried to solve multiple disconnected problems:

plugins and their security are a big challenge best handled by a separate module. However, we will close the public plugin API in Grid which will free a lot of resources for more important things. The community was not involved and the docs for plugins were lacking behind therefore never creating any value.
workflows simplify interaction with binary management for end users, but they don't take away the need to e.g. programmatically interact or manage binaries on a lower level
an API around binary management be it http or Electron IPC based is best implemented as a wrapper by the projects using binaries but introduces many dependencies, security problems and creates tight coupling

grid-core will be deprecated and the binary management will be handled by: https://github.com/PhilippLgh/ethereum-binaries
the http proxy concept might find its way into a new grid release


Create message similar to WithdrawDelegatorReward allowing specific delegator address

Problem
A smart contract cannot withdraw delegation rewards on behalf of another account. With the introduction of authz, it should be possible to achieve this.
Context
After chatting in the Telegram during HackWasm 2022, it seems that the WithdrawDelegatorReward Message would need to be modified, or a new message type added. Currently, the message looks like this:
https://github.com/CosmWasm/cosmwasm/blob/7e865a2b9168679b25d041946eca3feadb192450/packages/std/src/results/cosmos_msg.rs#L99-L112
Note the part about the delegator_address automatically using the contract address. It seems that this assumption might need to be changed.
I am not well-versed in what's below the smart contract stack, but searching through GitHub I did find this:
https://github.com/CosmWasm/wasmd/blob/1a87b28539c0b0c0278bd400252f2d01b1599e85/x/wasm/keeper/handler_plugin_encoders.go#L140-L144
I wonder if that's where the contract address gets added as the delegator_address, though I'm not positive why it would be under wasmd since I thought that was a daemon/chain.

After chatting with @webmaster128 about this offline, it might not be tenable to change this particular message as it'd be quite backwards incompatible. Perhaps an addition of a new message type makes sense if we're going to allow for the flexibility that authz offers.
Will change the issue name accordingly.

According to https://github.com/CosmWasm/wasmd/issues/1031#issuecomment-1268599435 this needs to be wrapped in a MsgExec anyways. So there is nothing we can do about the existing WithdrawDelegatorReward that would help.
Maybe we should offer MsgExec natively though. Then you only have to build the inner message yourself.

MsgExec from a contract would make sense. 👍
I don't have a concrete use case but I can imagine that support for authz.Grant can be nice, too where the contract is the granter.


[Enhancement] Improve issue template

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation

Existing bug-report template has no restriction on the provision of reproduction, which often leads to unclear bug-report.
The reimplementation report is not necessary, since it can be reported in bug reports or discussions.

Modification

Improve the bug-report template by adding the requirement for reproduction
remove the reimplementation report.
Add a default label for each template.
Add a prefix placeholder for the title of each issue template.

Whose help do you want? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:

[ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 I have updated the content of the bug-report. Would you please help review it again?


How can I deploy database in aws elastic beanstalk?

I have read your book 'mastering flask web development second edition'. It's great, thank you. I have deployed application in aws elastic beanstalk succesfully, The home page is ok. but there is not any command similar with "heroku local run" in elastic beanstalk. The database had not deployed.
So I add deploying sentences in front of  'run' command. I used Sqlite database.
def profile(length, profile_dir):
    """Start the application under the code profiler."""
    from werkzeug.contrib.profiler import ProfilerMiddleware
    application.wsgi_app = ProfilerMiddleware(application.wsgi_app, restrictions=[length],
                                      profile_dir=profile_dir)
    """Run deployment tasks."""
    # migrate database to latest revision
    upgrade()
    # create or update user roles
    Role.insert_roles()
    # ensure all users are following themselves
    User.add_self_follows()
    application.run()

It works in local environments.
But after I deployed the application with "eb deploy". I have deployed application in aws elastic beanstalk succesfully. There was 'interner server error' in home page. How can I   deploy database in aws elastic beanstalk?

Overall I think your idea is correct. You have to check the logs of your application to see the stack trace corresponding to the Internal Server Error. That's the only way to move forward.

Thank you for replying so quickly. I will check tomorrow.
---Original---
From: "Miguel<EMAIL_ADDRESS>Date: Wed, Sep 16, 2020 22:06 PM
To<EMAIL_ADDRESS>Cc: "Author"<author<EMAIL_ADDRESS>Subject: Re: [miguelgrinberg/flasky] How can I deploy database in aws elastic beanstalk? (#482)
Overall I think your idea is correct. You have to check the logs of your application to see the stack trace corresponding to the Internal Server Error. That's the only way to move forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This is eb logs.
I can not understand where is the errors. Please direct me. Thank you.

The error is (sqlite3.OperationalError) no such table: posts. You did not create/upgrade your database.

When I tryed to add upgrade command in application.py and deployed in EB.
with application.app_context():
    # Run deployment tasks.
    # migrate database to latest revision
    upgrade()

    # create or update user roles
    Role.insert_roles()

    # ensure all users are following themselves
    User.add_self_follows()

The home page was ok. The logs displayed starting gunicorn web server at first, then upgrading the database. There was not error in logs.
This is the logs.  See logs from 2020/09/18 03:36:20.
But there was not a post I posted before in home page. When I register , there was not  confirming email in my email inbox.
Maybe I should carry out 'upgrade' before 'start gunicorn'. How can I do? Thank you.

I'm not familiar with elastic beanstalk, so I cannot help you with specific questions about that service. The log shows that the upgrade was carried, but you are using a sqlite database, that seems like strange choice for a cloud deployment. How would that work when the service is scaled to multiple instances? Would they all be able to see the same database file?

Ok. I want to try to deploy in Docer. Thanks.
---Original---
From: "Miguel<EMAIL_ADDRESS>Date: Fri, Sep 18, 2020 16:31 PM
To<EMAIL_ADDRESS>Cc: "Author"<author<EMAIL_ADDRESS>Subject: Re: [miguelgrinberg/flasky] How can I deploy database in aws elastic beanstalk? (#482)
I'm not familiar with elastic beanstalk, so I cannot help you with specific questions about that service. The log shows that the upgrade was carried, but you are using a sqlite database, that seems like strange choice for a cloud deployment. How would that work when the service is scaled to multiple instances? Would they all be able to see the same database file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


[MB-3905] NTS & NTS-R informational modals

Description
Explain a little about the changes at a high level.
todo:

clarify responsive type styling in modal
add close button to modal
add info icon to open modal
test in IE11

Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-3905

  Generated by :no_entry_sign: dangerJS against 69da172849de05574701df2c7ce256b9628814c2


Some logs not being correctly categorized

It seems static pods are not being correctly assigned as controlplane:
{
  "_index": "logs-v0.5.4-000001",
  "_id": "f3e9e909-5b13-4514-bf0e-733bc40edcb8",
  "_version": 1,
  "_score": null,
  "_source": {
    "k8s.container.name": "etcd",
    "k8s.namespace.name": "kube-system",
    "container.image.tag": "v3.5.7-k3s1-build20230406",
    "log": "{\"level\":\"warn\",\"ts\":\"2023-05-17T20:29:00.593Z\",\"caller\":\"embed/config_logging.go:169\",\"msg\":\"rejected connection\",\"remote-addr\":\"<IP_ADDRESS>:51480\",\"server-name\":\"\",\"error\":\"tls: first record does not look like a TLS handshake\"}",
    "k8s.pod.uid": "",
    "Body.value": "2023-05-17T20:29:00.594024225Z stderr F {\"level\":\"warn\",\"ts\":\"2023-05-17T20:29:00.593Z\",\"caller\":\"embed/config_logging.go:169\",\"msg\":\"rejected connection\",\"remote-addr\":\"<IP_ADDRESS>:51480\",\"server-name\":\"\",\"error\":\"tls: first record does not look like a TLS handshake\"}",
    "logtag": "F",
    "namespace_name": "kube-system",
    "SeverityNumber": 0,
    "cluster_id": "4c7bb06f-c043-42c2-9e26-72f81f73b33f",
    "log_type": "workload",
    "container.image.name": "index.docker.io/rancher/hardened-etcd",
    "k8s.pod.name": "etcd-danb-demo-rke2-ds1-pool1-97254d35-n8b52",
    "stream": "stderr",
    "kubernetes_component": "",
    "k8s.pod.labels.tier": "control-plane",
    "deployment": "",
    "raw_ts": "raw time",
    "k8s.pod.confighash": "e18aa5e5b83a5a3c56d78e4054612394",
    "restart_count": "0",
    "template_matched": "",
    "k8s.pod.labels.component": "etcd",
    "log_source_field": "message",
    "container_image": "index.docker.io/rancher/hardened-etcd",
    "anomaly_level": "",
    "pod_name": "etcd-danb-demo-rke2-ds1-pool1-97254d35-n8b52",
    "TraceFlags": 0,
    "@timestamp": "2023-05-17T20:29:00.594024225Z",
    "k8s.node.name": "danb-demo-rke2-ds1-pool1-97254d35-n8b52",
    "ingest_at": "2023-05-17 20:29:14.295",
    "service": "",
    "time": "2023-05-17T20:29:00.594024225Z"
  },
  "fields": {
    "@timestamp": [
      "2023-05-17T20:29:00.594Z"
    ],
    "time": [
      "2023-05-17T20:29:00.594Z"
    ]
  },
  "sort": [
<PHONE_NUMBER>594
  ]
}

This is happening because the Opensearch FieldPath code is assuming that dot notation is referencing a map (https://github.com/opensearch-project/OpenSearch/blob/be0047e838ade4ecf7d8867298bbe8b4f0034834/server/src/main/java/org/opensearch/ingest/IngestDocument.java#L873)
There doesn't seem to be a way to turn off this behaviour, so the best course of action may be to prefill those fields using the otel preprocessor

https://github.com/tybalex/opni-ingest-plugin/blob/main/AIOps-OpniPreProcessor/src/main/java/org/opensearch/opnipreprocessing/plugin/OpniPreProcessor.java#L266
So in the ingest plugin, there is a check done right now for the kubernetes.labels.tiers being set to controlplane but it seems that the new field to check is "k8s.pods.labels.tiers". What if we made that switch instead?

The issue is that the new otel fields are not maps like the previous kubernetes fields; they're flat just with dots in the key.  Opensearch is assuming any field path with a dot is a path to a map.


Typing problems

Describe the bug
Problems with typings.
To Reproduce

Expected behavior
Works ok, no ts errors;

problem here https://github.com/TinkoffCreditSystems/stapp/blob/57338775d8f573ceb5f3d72083900907388aa015/packages/stapp/src/core/createEffect/createEffect.h.ts#L13

It's solution - https://github.com/TinkoffCreditSystems/stapp/issues/170


Bitnami Redis doesn't start up

The component default suggest the usage of the Bitnami Redis image instead of the official one, but this doesn't work anymore with the component version v3.0.0.
redis 13:13:51.94
redis 13:13:51.94 Welcome to the Bitnami redis container
redis 13:13:51.94 Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-redis
redis 13:13:51.95 Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-redis/issues
redis 13:13:51.95
redis 13:13:51.95 INFO  ==> ** Starting Redis setup **
redis 13:13:51.96 WARN  ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
redis 13:13:51.96 INFO  ==> Initializing Redis
*mkdir: cannot create directory '/opt/bitnami/redis/tmp': Permission denied*

We use internally the images:
  argocd:
    images:
      argocd:
        image: 'docker.io/argoproj/argocd'
      redis:
        image: 'docker.io/library/redis'
      kapitan:
        image: 'docker.io/projectsyn/kapitan'
      vault_agent:
        image: 'docker.io/library/vault'

Steps to Reproduce the Problem

Deploy ArgoCD using the component v3.0.0 with the original image paths from the component

Actual Behavior
Redis doesn't start, because the image doesn't match to the deployment configuration.
Expected Behavior
Either the Bitnami image support is going to be updated or the component defaults to the Docker Hub images.

I can't reproduce the bug with the bitnami image. It does work on my OpenShift 4 cluster.
Known good image SHA256s (tag 6.2.4):
quay.io/bitnami/redis@sha256:838bb34507c5d786ac2e5e57cdb37239dd11ab75e49a595029e9af77a6f74378
quay.io/bitnami/redis@sha256:2c32c7577c8032f774f9dd22867a35a5fc9155b511ae07d20a6ccca6f16123e4

Could you please try again with one of those image SHAs?

I can reproduce the bug on rancher k8s. The special treatment for OCP masked the error.


Get rid of submissionCreate from GET entities/:uuid/audits

From https://github.com/getodk/central-backend/pull/1028#discussion_r1372523633

... how the submissionCreate property of the audit log details feels like it could be improved. Currently, submissionCreate is needed if the submission is deleted, because in that case, no submission property is returned, so submissionCreate is the only way to get basic information about the submission (e.g., instanceId). As an alternative, we could always return a submission property. (In the deleted case, maybe we construct submission using the submission.create event.) That'd work similarly to the entity property, which is always returned and includes basic information (e.g., uuid) even if the entity is deleted.

@ktuite and I chatted about this issue. We'd like to make this change at some point, but we probably won't get to it for v2023.5. However, we'll be touching entity sources again in v2024.1 as we work on bulk upload. I'll go ahead and bump this issue.

Places to change code in backend

audits for entities
getWithConflicDetails (passes thru audit details)

Places to change code in frontend entity components:

activity (code adds another event to show submission created if needed)
basic details (shows the creating submission or nothing if created with api)
feed entry
version link

Ways submissionCreate is used

to tell if entity was created with a submission or api
get the instance id of the submission
absence of submission and presence of submissionCreate indicates that submission was deleted

Plan

move things from submissionCreate into submission property and always return submission

instance id
creator and creation date (as full actor object)
easy way to tell if submission is deleted or not (maybe presence of currentVersion?)


Print vDVS version in plugin and esx logs

We need to log the vDVS version on esx log. We have it (shown during vmdkops_admin status command). Let's also log it.
On the plugin side, we need to log the managed plugin version. Also we need to log the version of VIB installed on ESX host on which the VM resides (where plugin is installed). Probably this can be exchanged during first handshake between plugin and esx service.

Similar to #1662

Debugging the CI failure for PR #1893

helps while triaging issues from customer side.

Fixed. @pshahzeb  to add PR info.


:+1: Use Web Streams API instead of Deno.Reader/Deno.Writer to follow recent deno favor

Use ReadableStream<Uint8Array> and WritableStream<Uint8Array> internally. It does not change APIs of denops itself so it should be a non breaking change.
This change will reduce one-shot RPC performance, but appears to improve performance when accessed in batches.


Balanced accuracy for the binary case

🐛 Bug

I need to compute balanced accuracy for a binary classification (classes labels: 0 and 1), the same way as Scikit Learn does.
From the docs, it seems like the attribute for obtaining the metric is average='weighted', but this attribute is missing for the binary case (BinaryAccuracy or the functional binary_accuracy). The only way to specify that is in general Accuracy or functional accuracy, but then I also need to specify task='binary' or task='multitask' and num_classes=2 and under the hood it computes the binary accuracy ignoring the average='weighted'.
To Reproduce
See code sample below

import torch # 1.13.1
import torchmetrics # 0.11.4
from sklearn.metrics import balanced_accuracy_score

all_ones_but_first = torch.Tensor([0, 1, 1, 1])
all_zeros = torch.Tensor([0, 0, 0, 0])

# desired behavior from sklearn
balanced_accuracy_score(all_ones_but_first.numpy(), all_zeros.numpy()) # yields 0.5

# behavior from torchmetrics
torchmetrics.functional.classification.accuracy(all_ones_but_first, all_zeros, task='binary') # yields 0.25
torchmetrics.functional.classification.accuracy(all_ones_but_first, all_zeros, task='binary', average='weighted') # yields 0.25
torchmetrics.functional.classification.accuracy(all_ones_but_first, all_zeros, task='multiclass', num_classes=2, average='weighted') # yields 0.25

Expected behavior
Balanced accuracy should be returned.

Environment

TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source):  0.11.4 installed from pip
Python & PyTorch Version (e.g., 1.0): python 3.10.9 and pytorch 1.13.1 installed from pip
Any other relevant information such as OS (e.g., Linux): Linux

Additional context

Hi @nicobonne,
You can achieve the same in torchmetrics, but the order of arguments matter. In scikit learn the order is
metric(y_true, y_pred)

whereas in torchmetrics the order is switched
metric(preds, target)

(on a side note, the reason the order is switched is to be similar to loss functions in pytorch ).
Therefore if I take your last example and switch the order + using task="multiclass" and set average="macro" you get 0.5:
torchmetrics.functional.classification.accuracy(
    all_zeros, all_ones_but_first, task='multiclass', num_classes=2, average='macro'
)  # tensor(0.5000)

Thank you for the quick reply, silly me for not noticing the order of arguments.
So, macro was what I needed instead of weighted.
I wonder if it should be the case of adding this possibility to the BinaryAccuracy, as defining a multiclass with just 2 classes seems like a workaround for this use case.


fix(@angular-devkit/build-angular): mangle scripts when differential loading is enabled

Previously scripts.js were not being mangled
Closes #15489

Superseeded by https://github.com/angular/angular-cli/pull/15566


fix/client version mismatch

Fix PROMETHEUS_K8S_TOKEN to account for oc version mismatch
Fix to use correct variable name in test

Everything passed CI so I'm going to merge this down and cherry pick it back to stable-1.5. The missing tests are expected due to recent rename and will never trigger.


add "learn to touch-type" to things-to-think-about for keyboards

(thanks @matthewhague ! )

Closed by 1928e073e6dcef61d341eecdb3ca5ab18633e447: touch typing


Blocks don't show up?

for some reason, the blocks don't show up.
is this a bug?

Also, I've already tried turning off my resource pack. DOESN'T WORK.
also my rendering settings are all on default.

Try turning VBO's off.

What are vbos?

It is a feature within optifine. Check settings or remove optifine and see if that is the issue.

VBOs are actually a vanilla feature, but optifine's implementation causes some issues.

Oh ok, it works now.
Tnx!


ciscoasa: Skip policy if not ASA target

Thank you for the PR @btriller
@jtwb tests in this case are not a blocker. We should probably move this logic eventually into aclgenerator.py or elsewhere since it is pretty universal.


Is there a way to set context tags for multi-browser testing?

Hi Jan,
With the Java Serenity version, you can provide a context for each browser so that the report shows which browser the test has run on. I have found an old example on John Smart's blog and it still works with the latest version.
Is this something that can easily be done with Serenity/JS?
I am able to run the tests in multiple browsers but there is no distinction in the report to show which browser the test run on.

@robin-weller
Actually serenity JS report does show the browser information the nicest way possible. I was working on serenity 1.x version and able to get below information in the report:

Not only that, for multi-browser tests, all the browsers will be listed down here.
Most important thing is, before each test case, it shows the icon in which browser tests are executed.

Can you share your protractor.conf and the report you are getting. It will ravel a broader picture.

That is what I see using the Java version. I am using v2 though.
protractor.conf.js:
const
    { ConsoleReporter } = require('@serenity-js/console-reporter'),
    { ArtifactArchiver } = require('@serenity-js/core'),
    { SerenityBDDReporter } = require('@serenity-js/serenity-bdd'),
    { Photographer, TakePhotosOfInteractions } = require('@serenity-js/protractor');

exports.config = {
    chromeDriver: require('chromedriver/lib/chromedriver').path,
    geckoDriver: require('geckodriver/lib/geckodriver').path,
    SELENIUM_PROMISE_MANAGER: false,

    directConnect: true,

    allScriptsTimeout: 11000,

    specs: [ './features/*.feature', ],

    framework: 'custom',
    frameworkPath: require.resolve('@serenity-js/protractor/adapter'),

    onPrepare: () => {
        require('ts-node').register({
            project: './tsconfig.json'
        });
        browser.waitForAngularEnabled(false);
    },

    serenity: {
        crew: [
            ArtifactArchiver.storingArtifactsAt('./target/site/serenity'),
            Photographer.whoWill(TakePhotosOfInteractions),
            new SerenityBDDReporter(),
            ConsoleReporter.forDarkTerminals(),
        ],
        runner: 'cucumber'
    },

    cucumberOpts: {
        require: [
            'features/steps/**/*.ts',
            'features/support/setup.ts',
        ],
        'require-module': ['ts-node/register'],
    },

    multiCapabilities: [
        {
            browserName: "chrome",
            chromeOptions: {
                args: [
                    '--disable-infobars',
                    '--no-sandbox',
                    '--disable-gpu',
                    '--window-size=1024x768',
                    // '--headless',
                ],
            },
        },
        {
            browserName: "firefox",
        },
    ],
};

Report:

A Java version:

@jan-molak Is it related to old serenity CLI jar?

Hi @robin-weller, it's great to hear from you again!
@abhinaba1080 - your instincts are right, it is partially related to the old Serenity CLI jar. The upcoming 2.1.10 release of the jar will come with serenity-bdd/serenity-core#1860, which enables both browser and OS icons to be rendered for every test scenario.
I was waiting for that jar to be published to add both the browser/os tagging as well as the icons all in one go. But, having thought about it some more, I decided to implement the tagging first and the icons whenever the jar arrives.
Enjoy Serenity/JS v 2.1.0 with OS and browser tags

Support for icons is coming soon ;-)

You can now sponsor my work on Serenity/JS on Github :octocat:

Thanks @jan-molak - good to hear from you too!
I am seeing the OS and browser tags in the report, however, there is an issue generating the report from firefox runs. so it is only showing chrome.
I see the following error when it is generating reports from firefox runs:
[main] WARN  n.t.c.r.json.JSONTestOutcomeReporter - This file was not a valid JSON Serenity test report: scenario-user-can-log-in-ec36ba7706.json
I am seeing the chrome icon though!

Cool, so we're making progress :-) Would you mind posting the offending json file?

Of course:
{
   "name":"User can log in",
   "title":"User can log in",
   "id":"demo-journeys;user-can-log-in",
   "manual":false,
   "testSteps":[
      {
         "number":1,
         "description":"Given Arya is on the <Obfuscated Website> homepage",
         "startTime":1581086694376,
         "children":[
            {
               "number":2,
               "description":"Arya navigates to '<Obfuscated Website>'",
               "startTime":1581086694379,
               "children":[

               ],
               "reportData":[

               ],
               "screenshots":[
                  {
                     "screenshot":"photo-firefox-arya-navigates-to-<Obfuscated Website>-cf8036b9c1.png"
                  }
               ],
               "result":"SUCCESS",
               "duration":905
            },
            {
               "number":3,
               "description":"Arya ensures that the title of the current page does start with '<Obfuscated Website>'",
               "startTime":1581086695287,
               "children":[

               ],
               "reportData":[

               ],
               "screenshots":[
                  {
                     "screenshot":"photo-firefox-arya-ensures-that-the-title-of-the-current-page-does-start-with-<Obfuscated Website>-b2144a1f3b.png"
                  }
               ],
               "result":"SUCCESS",
               "duration":5
            }
         ],
         "reportData":[

         ],
         "screenshots":[

         ],
         "result":"SUCCESS",
         "duration":919
      },
      {
         "number":4,
         "description":"When she logs in",
         "startTime":1581086695296,
         "children":[
            {
               "number":5,
               "description":"Arya logs in to <Obfuscated Website>",
               "startTime":1581086695297,
               "children":[
                  {
                     "number":6,
                     "description":"Arya clicks on the the user icon",
                     "startTime":1581086695297,
                     "children":[

                     ],
                     "reportData":[

                     ],
                     "screenshots":[
                        {
                           "screenshot":"photo-firefox-arya-clicks-on-the-the-user-icon-dad1f72b8e.png"
                        }
                     ],
                     "result":"SUCCESS",
                     "duration":2581
                  },
                  {
                     "number":7,
                     "description":"Arya enters '<Obfuscated Email>' into the the email address field",
                     "startTime":1581086697879,
                     "children":[

                     ],
                     "reportData":[

                     ],
                     "screenshots":[
                        {
                           "screenshot":"photo-firefox-arya-enters-<Obfuscated Email>-into-the-the-email-address-field-1bd27fbedd.png"
                        }
                     ],
                     "result":"SUCCESS",
                     "duration":412
                  },
                  {
                     "number":8,
                     "description":"Arya enters '<Obfuscated Password>' into the the password field",
                     "startTime":1581086698292,
                     "children":[

                     ],
                     "reportData":[

                     ],
                     "screenshots":[
                        {
                           "screenshot":"photo-firefox-arya-enters-<Obfuscated Password>-into-the-the-password-field-3673e82b69.png"
                        }
                     ],
                     "result":"SUCCESS",
                     "duration":182
                  },
                  {
                     "number":9,
                     "description":"Arya clicks on the the sign in button",
                     "startTime":1581086698476,
                     "children":[

                     ],
                     "reportData":[

                     ],
                     "screenshots":[
                        {
                           "screenshot":"photo-firefox-arya-clicks-on-the-the-sign-in-button-68499d3cfd.png"
                        }
                     ],
                     "result":"SUCCESS",
                     "duration":513
                  }
               ],
               "reportData":[

               ],
               "screenshots":[

               ],
               "result":"SUCCESS",
               "duration":3693
            }
         ],
         "reportData":[

         ],
         "screenshots":[

         ],
         "result":"SUCCESS",
         "duration":3695
      },
      {
         "number":10,
         "description":"Then she should see that she is logged in",
         "startTime":1581086698991,
         "children":[

         ],
         "reportData":[

         ],
         "screenshots":[

         ],
         "result":"PENDING",
         "duration":1
      }
   ],
   "userStory":{
      "id":"demo-journeys",
      "storyName":"Demo Journeys",
      "path":"features/demo.feature",
      "type":"feature"
   },
   "startTime":1581086694369,
   "testSource":"Cucumber",
   "tags":[
      {
         "name":"Demo Journeys",
         "type":"feature"
      },
      {
         "name":"firefox ",
         "type":"browser",
         "browserName":"firefox"
      },
      {
         "type":"platform"
      }
   ],
   "featureTag":{
      "name":"Demo Journeys",
      "type":"feature"
   },
   "context":"firefox",
   "driver":"firefox",
   "duration":4811,
   "result":"PENDING"
}

The difference I am seeing between the Chome and Firefox JSON files is there is no recorded browserVersion for Firefox (which is probably fine?!) and there is no name defined with "type": "platform"?

Thanks, and what version of Firefox are you running?
Could you please also add the following section to your protractor.conf.js and let me know what it prints?
    onPrepare: () => {
        return require('protractor').protractor.browser.getCapabilities()
            .then(capabilities => {
                console.log('platform',    capabilities.get('platform'));
                console.log('browserName', capabilities.get('browserName'));
                console.log('version',     capabilities.get('version'));
            });
    },

Hey @robin-weller, can you check out the latest build, please? It should be able to correctly detect details of all the major browsers and platforms.
Scenario view:

Summary view:

As always, thoughts and feedback welcome!

seems like I created an issue about the same root cause in #456 I will test the latest version and see if the problem goes away

Thanks @ctaepper - yeah, my original solution was a tad bit optimistic. I then ran a test against 14 different browser/platform combinations and recorded my findings in this unit test.
If there's anything I missed, please feel free to extend it!

Thanks @jan-molak, 2.1.1 is looking good for browser tagging :)
Something I am seeing a difference in though is the platform tagging.
Chrome:
Browser: Chrome 80.0.3987.87
Platform: Mac OS X

Firefox:
Browser: Firefox 71.0
Platform: Mac 19.3.0

Currently running Mac OS X 10.15.3 so it looks as though the Firefox run is picking up the Darwin version instead of the OS X version?

Hey @robin-weller - Different browsers describe the platform they run on differently, and to a different degree of fidelity. If I was to make the reporting consistent, I'd have to go either with the lowest common denominator or introduce another, higher-level tag (PlatformType?)
Not sure which one is better. Thoughts?

I guess it's not going to be perfect either way. If you run one instance of Chrome on Catalina and one on Mohave, you won't see any difference. However, running Firefox would give you a bit more to go on, albeit a Darwin version number.
Having both Platform and Platform Type would provide the most useful information but could end up cluttering the report when different browsers report different information!

This functionality has been introduced in @serenity-js/serenity-bdd v2.3.0, which generates both the browser and platform tags based on the information provided by the browsers (and some provide more precise information than others...):

It also generates icons for the recognised browsers and platforms:

If Serenity/JS has made your life easier, please consider becoming a sponsor and buying us a coffee every once in a while :octocat:


fix: Product page v2 copy edits.

Several small text changes on the product pages to help content flow through each section.

Merged with other PR


Memory not getting released on page reload in Safari

I am not quite sure if this is an Safari or an Polymer issue, but it's worth finding out.
The issue can be reproduced by visiting https://polymer-project.org with some smaller numbers than in my case, but it's there.
Numbers from my application : On the first page load the memory footprint is OK (~130MB). But every time I refresh the page, the RAM usage gets increased by something between 40 and 100MB. I don't need the page to remember anything when the user leaves it, so I don't understand what is happening there. And it's not just like memory that gets released when needed, it leads to the point where my MacBook (8GB RAM) is starting to get really slow after developing for about 30 minutes... I do not have any plugins installed.
A more detailed description and some screenshots of the RAM usage are available at http://stackoverflow.com/questions/31891543/polymer-safari-huge-ram-usage-increase-on-each-page-reload .
P.S.: I read about general Safari RAM issues, but the posts about this are mostly 3 years old.

We haven't seen issues like this. Would you be able to provide a test case that we can investigate? Thanks.

Hm I think it's a problem with my system, sorry to have bothered you. I can see the same behavior for every page I visit, it was just the first that went overboard because I refreshed it so often...


Please provide the full example code from the gif

Hi!
Can you please provide the full code example which is showcased on the readme?
I can't figure out how to properly layout the widgets, so that the bottom radius is saved instead of being clipped:
https://github.com/Kavantix/sliver_tools/assets/54116985/df406152-7b74-4fbc-a5be-ca5c33154992

The link is documented here: https://github.com/Kavantix/sliver_tools/blob/master/example/example.md

But my guess would be that you have a background color on tour header that shouldn’t be there.

The link is documented here: https://github.com/Kavantix/sliver_tools/blob/master/example/example.md

Thanks for the example!
Now it works as I expected :)
https://github.com/Kavantix/sliver_tools/assets/54116985/6dfa6068-9438-4d2b-87ca-1be97b39919e
One more question though. Is it possible to keep the persistent header at top after it reaches its' min height and instead of moving it behind the appbar, fade it? Like in the ios weather app.


Some of the Enviroment Variables imported by import_github_env are not set

When I did set import_github_env to true I did noticed that particular env variable is not set from github workflow.
I am speaking of CI that my code depends on.
		if("$ENV{CI}" STREQUAL "true")
		/// more code

This part of code was never reached. I had to manually set in commands to make it work as expected
export CI=true
PS: I had tried setting env variable using the worklow itselt
env:
    CI: true

Could you please share your workfile?
There is a test for import_github_env.
Documentation is here: https://github.com/pguyot/arm-runner-action#import_github_env
Test is here: https://github.com/pguyot/arm-runner-action/blob/main/.github/workflows/test-import_github_env.yml

Oh, I misunderstood your request.

Fixed in v2.5.2, you don't need import_github_env which serves another purpose.


EarlyStopping mode-parameter "auto" is missleading

In the docs on EarlyStopping it says: "in 'auto' mode, the direction is automatically inferred from the name of the monitored quantity." suggesting there is some sort of "smart" way/ lookup table for different metrics. When you look at the  corresponding code however, you see that it is just a string-comparision wether the name of the monitored variable ends in acc, accuracy or auc.
if (
    self.monitor.endswith("acc")
    or self.monitor.endswith("accuracy")
    or self.monitor.endswith("auc")
):
    self.monitor_op = np.greater
else:
    self.monitor_op = np.less

I believe this is missleading and causes confusion.
You can see someone struggeling with it in this stackoverflow post who thinks that "TF has the direction of ndcg (Normalized Discounted Cumulative Gain) for ranking problems wrong." when in reality it does not have direction for anything.
I don't know the consequences of changing this, as someone might have choosen the right value by accident and changing the standard value could break their pipeline(s). I do not have a fix because I don't know how widespread this problem is. I just wanted to let you know that this could be an issue worth looking into.

This notation is used in this repo a couple of times, so I would suggest that.
def __init__(mode='min'):
    if mode not in ["min", "max"]:
        raise ValueError(
            '`mode` must be one of `"min"`, `"max"`. '
            f"Received: mode={mode}."
        )
    self.monitor_op = np.greater if mode="max" else np.less

@Lennart4711,
Could you please feel free to submit a PR for the requested change or share the link where requested change is to be made. Thank you!

So in this implementation are the changes iff you want to remove the "auto"-mode. This would give a warning to everyone that used "auto"-mode previously. It would break the code for those who used "auto"-mode in combination with a monitored-quanitiy with a name ending in "acc", "accuracy" or "auc".
An alternativ option is to just change the parameter-description to something, that resembles the actual functionality better without changing the code at all. Something like this is actually already in use here and I changed it here.
I would advise to choose the latter option because it is less invasive and helps those who have similar problems to the guy in the linked stackoverflow above. If you agree, I am going to submit the PR for the latter.

Same problem in one other class, ReduceLROnPlateu. Could be fixed/ changed the same as EarlyStopping.

Agreeing that taking 'auto' to automatically infer the direction is less clear than ideal, and being explicit in the argument's documentation without breaking the backward compatibility seems a better move. Happy to review a PR for the doc change.

Hello, Thank you for reporting an issue.
We're currently in the process of migrating the new Keras 3 code base from keras-team/keras-core to keras-team/keras.
Consequently, This issue may not be relevant to the Keras 3 code base. After the migration is successfully completed, feel free to reopen this issue at keras-team/keras if you believe it remains relevant to the Keras 3 code base.
If instead this issue is a bug or security issue in legacy tf.keras, you can instead report a new issue at keras-team/tf-keras, which hosts the TensorFlow-only, legacy version of Keras.
To know more about Keras 3, please take a look at https://keras.io/keras_core/announcement/. Thank you!


Fail to deploy latest version

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

[x] You're running the latest release version of Deployer.
[x] Ensure that you're running at least PHP 5.6.4, you can check this by running php -v
[x] You've ran composer install --no-dev from the root of your installation.
[x] You've ran npm install --production from the root of your installation.
[x] You've ran rm -rf bootstrap/cache/* from the root of your installation.
[x] You have restarted the queue listener and node socket server.

To help us better understand your issue, please answer the following.
Expected behaviour
The system should deploy latest available commit in the branch
Actual behaviour
The system re-deploys latest deployment, after second try it deploys new version.
Steps to reproduce
Deploy something, Commit something to repo, Wait some time, Deploy again, Deploy Again
Environment info
Operating System: 16.04
PHP Version: 7.0
Node Version: 4.7.3
Database System: MySQL
Database Version: 5.7
Logs (see storage/logs/) or other output that would be helpful
(If logs are large, please upload as attachment).

do you mean,
with webhooks its failing
but when you deploy manually, its working?

Webhook failing too, I dont mention that. The problem is when i do manually deploy, I must do it twice time, because when the first try, it does not deploy latest version.

Sounds like this is almost certainly the same issue as https://github.com/REBELinBLUE/deployer/issues/323 I am just finishing up a fix right now

Can you change out branch bug/323 and see if that works?

Moving discussing to #323


Golang work

Codecov Report

Merging #90 (893715f) into master (839e022) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   95.99%   96.01%   +0.02%
==========================================
  Files          12       12
  Lines         873      879       +6
==========================================
+ Hits          838      844       +6
  Misses         35       35

Impacted Files
Coverage Δ

f8a_utils/web_scraper.py
97.50% <ø> (ø)

f8a_utils/golang_utils.py
92.56% <100.00%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839e022...893715f. Read the comment docs.


RuntimeError: This event loop is already running

Hi all, really intrigued by this project, love the idea of democratising the use large models! I've been playing around and encountered a few bugs/unexpected behaviour, so will raise some issues. Happy to help and provide constructive feedback weher I can :)
When running the example provided at https://github.com/microsoft/deepspeed-mii#deploying-mii-public I receive the following error: RuntimeError: This event loop is already running. See this notebook for a minimal example to reproduce the error.
I found a workaround using nest_asyncio.apply(), see this notebook. Nevertheless this strikes me as a bug (or at least unintended behaviour).

Possibly related to #87 , although this example here is not using ZeRO
Tested on a vanilla g4dn EC2 instance, no processes running
1 T4, GPU memory 16GB
deepspeed-mii version 0.0.3
transformers version 4.24.0
Amazon Linux 2

Hi @marshmellow77 thanks for using MII and reporting this. I see you opened quite a few issues! We definitely appreciate the help with finding these bugs. In the next week, I'll try to reproduce each one and report back to you on findings / solutions.

I can confirm I'm seeing the same behavior when running inside a notebook. In its current state, MII wasn't designed with the intention of running it in a notebook, but I can see how this would be useful. We saw your suggestion in your blog post:

In the future I would love if we could choose within MII to use the optimisation with or without gRPC

We will soon be adding this feature and we'll be sure to test in a notebook :)

@mrwyattii I am having the same issue when trying to deploy MII with fast API.  The same fix works, but the GRPC server is crashing periodically.  I am not sure if that is related.


Firefox driver not found

When using Firefox, installed with brew cask, splinter can't find the executable:
OSError: [Errno 2] No such file or directory

@jbabuino firefox bin is on the $PATH?

No, it's not. brew cask install firefox does not put firefox in the $PATH.
export PATH=/opt/homebrew-cask/Caskroom/firefox/latest/Firefox.app/Contents/MacOS/:$PATH would do, but there's probably something cleaner.

Yes, that was the problem! Thanks :)


Update scala-collection-compat to 2.1.6

Updates org.scala-lang.modules:scala-collection-compat from 2.1.2 to 2.1.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" } ]

labels: library-update, semver-patch

Superseded by #33


Memory issue in Stage 1 emulator

Appears after #4
When running testHGCalL1T_stage1Truncation_V11_cfg.py
Memory footprint increases to tens of GB quickly after starting processing the first event.

Fixed in #58


Add then function

This PR resolves #130
PR Checklist
Please ensure that you have done the following:

[X] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.
[X] If you're not on the contributors list, add yourself to AUTHORS.rst.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[ ] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checkin
running the test suite
docs build

Code Changes
If you are adding code changes, please ensure the following:

[X] Ensure that you have added tests.
[X] Run all tests ($ pytest .) locally on your machine.

[X] Check to ensure that test coverage covers the lines of code that you have added.
[X] Ensure that all tests pass.

Documentation Changes
If you are adding documentation changes, please ensure the following:

[X] Build the docs locally.
[X] View the docs to check that it renders correctly.

PR Description
Please describe the changes proposed in the pull request:

This allows people to add arbitrary functions to the method chain.

Relevant Reviewers
Please tag maintainers to review.

@ericmjl
@zbarry

I know we want to start adding to the dev branch, but I couldn't find a dev branch yet. Feel free to close this if you'd rather have it going there.

@szuckerman @zbarry both of you should have full admin privileges on the repo. I'm trusting you guys with a ton here :smile:. You can be our pioneer, @szuckerman!

Ok, going to merge, @szuckerman!

Hohoho, I just used this function today, @szuckerman :smile:


Consider using Hyperscan for Regex

The library is much faster than PCRE (up to 10-13 times, according to Intel's bechmarks).
It can be found here

And probably does so by dropping features.

http://intel.github.io/hyperscan/dev-reference/compilation.html#unsupported-constructs


[docs] Fix small typo in Container

[x] I have followed (at least) the PR section of the contributing guide.

Closes #20585

@plug-n-play It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Avoid Offset object wrapping in QueryableIndexStorageAdapter

when query granularity / interval is coarser than data (i. e. segment) interval, that is typical for topN queries
how this is tested?
Druid tests are run and passed.

Sorry wrong PR destination, it needs internal testing first.


[Bug] Custom content type still not applied

This #722 PR fixed the AWS SSR, but StaticSite and both StaticSite and SSR on Cloudflare are still having issues
new sst.aws.StaticSite("myapp", {
      build: {
        command: "npm run build",
        output: "dist",
      },
      assets: {
        fileOptions: [
          {
            files: ["manifest.webmanifest"],
            contentType: "application/manifest+json",
          }
        ]
      }
    })

fixed by https://github.com/sst/ion/pull/1038


LOAD DATA LOCAL INFILE fails when row size exceeds 64K (65535 bytes) limit

Bug Description
When executing the following command:
mysql> LOAD DATA LOCAL INFILE 't_b.csv' INTO TABLE t_b FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' (id, real_sql);
ERROR 1105 (HY000): bufio.Scanner: token too long

An error occurs when the row length exceeds 64K (65535 bytes). The error appears to be related to the use of bufio.Scanner in the Go MySQL server implementation.

Steps to Reproduce

Create the table using the following schema:
CREATE DATABASE t_d;
USE t_d;
CREATE TABLE `t_b` (
  `id` bigint NOT NULL,
  `real_sql` text NOT NULL,
  PRIMARY KEY (`id`)
);

Prepare a CSV file (t_b.csv) with content similar to this:
1,AAAAAA (where the length of 'AAAAAA' exceeds 65535 characters)

Execute the LOAD DATA LOCAL INFILE statement:
LOAD DATA LOCAL INFILE 't_b.csv' INTO TABLE t_b FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' (id, real_sql);

Possible Cause
The issue appears to be caused by the use of bufio.Scanner, which imposes a token size limit of 64K, as seen in the Go MySQL server code, particularly in ddl_iters.go.

@jycor will look at this today.


[SPARK-20720][WEB-UI]'Executor Summary' should show the exact number, 'Removed Executors' should display the specific number, in the Application Page

What changes were proposed in this pull request?
When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui.
Although this is a small improvement, but it is indeed very valuable.
After fix:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

@srowen @ajbozarth
Help to review the code, thanks.

If this would be useful I don't see any harm in adding it, its a pretty small change

Hm, but do we do this consistently in the UI? show "Thing (count)"? it needs to be uniform if it's changed.

We spark ui have two styles.
The first style is to display statistics separately, as follows:

The second style is displayed in the table header, with parentheses, as follows:

I am modifying this issue by using the second style.

I see. I think the first style exists to provide links that jump to running apps because it may be well below the fold if there are many workers. I think that can stay, even though the design of this little header is not great and wastes a lot of white space at the right.
I think it'd be nice to add (count) to all the tables of things in the UI, as I assume that's pretty easy to do, isn't obtrusive, and would make it more consistent. I suppose that goes for stages, tasks, etc. What do you think?

Yes, I agree with you. I will work on it.

I like it, I think limiting this particular pr to updating the master ui is probably best for now, could you also update WorkerPage.scala as well since its part of the "Master UI"

@ajbozarth @srowen
At present I have this branch code ui count test results:
1.master page by i fix, as follows:

2.job page , as follows:

3.stage page , as follows:

4.task page, as follows:

5.work page, as follows:

Thanks for checking @guoxiaolongzte looks like with this fix every table will now have a (count)
LGTM

Merged to master


Wildcards not working as expected

I am attempting to use your wildcards, but they do not work at all like I would expect and there is no documentation. I am attempting to redirect a single page and all of its sub pages to the root of the site, but for some reason its always appending the sub pages to the root of the site after the redirect. For example:
Redirect "/dakota" works just fine when going directly to that page.
Redirect "/dakota/*" always appends the wildcard match part to the end of the target url.
This is not how I expected the wildcard checkbox to work. What am I missing?

Now I have an issue after adding and removing these redirects several times, I cant get any of them to work. I simply want to redirect "/dakota" to "/" and it does not work at all. Its the only redirect in there. I have restarted the app and cleared the cloudflare cache and no luck. Not sure what I am doing wrong.

How is this not working?

It still returns a 404 error. Even turned off caching in chrome dev tools and cleared cloudflare cache.

@JasonRodman

Regarding wildcard usage, this is a definition for using wildcards and will be shortly added to the documentation:
"If you want to redirect many addresses below a specific one to one new URL, set this to true. If we get a wild card match on
this URL, the new URL will be used in its raw format and the old URL will not be appended to the new one."
If your subpages get appended to root URL after checking the wildcard box the issue may be that your subpages still exist and they are not set to expire or you are using an old version of Episerver or old package version, pls upgrade package to the latest version and upgrade Episerver version and see if the issue reoccurs.

Regarding "/dakota" redirection stopped working issues, I tried to recreate the issue but couldn't get it to occur, as above try upgrade package to the latest version and upgrade Episerver version and see if the issue reoccurs.

Added documentation: https://github.com/Geta/404handler#wildcards


Partial AI Dialogue

I needed a partial AI dialogue, because the AI would modify the entire page of code, and if there was too much code, the AI would choose to omit parts, which was claude's habit.

Yup same here

We're tracking this internally. You can follow #124 to get notified when we've resolved this issue.


Make sure the cluster register happens before streaming process.

Make sure cluster register in start stage, rather than after server(grpc/jetty) started.
Add a warning log, rather than NPE, in case streaming calculation still happens caused by log cache file.

resolves #3402.

/run ci


Removing excess punctuation and unbalanced parentheses from affil strings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.20%. Comparing base (ddb0f24) to head (b6c2516).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   91.06%   91.20%   +0.13%
==========================================
  Files          25       25
  Lines        2810     2842      +32
==========================================
+ Hits         2559     2592      +33
+ Misses        251      250       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RE: putting the parentheses normalization in base.py :
I have the function (_remove_unbalanced_parentheses) currently in JatsAffils class so that the normalization can happen when the extraction of aff string is happening. if we really want this in base.py, I could call it here, but we would have to cycle through each affiliation for each author before storing the author info.
let me know if that is better in your opinion.


Extraction folder always deleted, CP re-downloaded and re-unzipped

Sometimes you need to run the ansible task a few times to get things right. At the moment the Component Pack is always deleted at the start, re-downloaded, and re-unzipped.
Could we please have a variable to disable these tasks in order for us to re-use the existing valid files that we already have?

Hi Andrew,
I think this is already solved.
Check this out: https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/10bc3447bf802622be471bf92fb87bd7a87d0968/environments/examples/cnx7/db2/group_vars/all.yml#L80-L81
Add setup_installation: false and it will skip downloading, unzipping, cleaning, etc. Add setup_images: false and it will skip trying to reupload images and wasting time on that.
All those variables: https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/10bc3447bf802622be471bf92fb87bd7a87d0968/environments/examples/cnx7/db2/group_vars/all.yml#L80-L101 are intended to give you exactly the chance to skip one or most of the steps and to execute just the one you need.
Is this what you need?
And yeah, they are not visible in quick start example, since quick start is just a bare minimum there. I can expose their defaults there too, but there were some opinions where people didn't want it as it was confusing them, but just a minute to add it if it would help others too.

Thanks for the reply. Yes, those variables should do the job.


Spectra baselines for DESI and SDSS

Here is some code for running a galaxy spectra -> redshift baseline for the DESI and SDSS spectra data.
I've implemented a 1D ResNet-18 trained via the Huber loss for this, as in GaSNet from Zhong+2023.
WIP: Still need to incorporate improvements from #76, and one-click training via Lightning.

Added ability to run this as a Lightning CLI, so now ready for review


Quick Outline/Goto Symbol does not work on the Default Keyboard Shortcuts

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:45:32.595Z)
OS Version: Windows_NT ia32 10.0.10586
Extensions: None

The first Q&A from Common Questions does not work.
Steps to Reproduce:

Open Keyboard Shortcuts (Ctrl+k Ctrl+S)
Click to focus on the Default Shortcuts, by default the focus is on the User Shortcuts panel
Open Quick Outline/Goto Symbol (Ctrl+Shift+O)
You see the results from the User Shortcuts and not the Default ones
If you hit ESC you can see the focus is on the User Shortcuts from the right panel

Same is true for the settings editor.

I think this is OK behaviour because we want to move away from the left hand side of preferences and keybindings to work like a normal editor but rather something that we control the searching and filtering on using more explicit widgets (like the big search box).
However, for keybindings we did not yet adopt any new UI to allow for searching, so it is a bit unfortunate that quick outline does not work there anymore.
I do not understand why we treat this as candidate though, imho this should move to January.

@bpasero when we made the changes we overlooked the Quick Outline style of navigating in keyboard shortcuts and settings. I.e. we broke established and efficient workflows without appropriate consideration. That makes this a regression.

Suggestion: go back to 2 editors for keybindings.

Agreed that disabling outline for Keybindings was not expected and was a side effect of moving to side by side editor. I will revert it to old behaviour of showing 2 editors for key bindings.
Disabling Quick outline/Go to Symbol/Go to line/Find was intentional in Default Settings. This was done in favour of new rich functionality in Default Settings.

Advanced Search and filtering
Rich Grouping


Remove ability to set UID of the user added to the generated image

Related with issue #223.

Comment with some motivation for this change https://github.com/jupyter/repo2docker/issues/223#issuecomment-393280799
Have you already experimented with removing options to see which ones in particular have to be removed and which ones can stay?

Hi betatim,
So, I think both --disabled-password and --gecos are needed to avoid the command to ask for prompt input. Even thought that docker will skip and pass the defaults for those inputs, and that if you don't pass --password it will be disabled by default.
I see that the problem is with --uid option only. So I made some changes to my PR to only remove --uid and keep the other options, as I saw some travis tests failed.

hey all - just a ping to see where we are on this PR - it seems from @betatim 's latest comment that there's some uncertainty as to whether this can be implemented without breaking other functionality?

Removing the ability to set the UID is definitely not something we can or should do. I'd close this PR and start a new one to tackle the problem that users whose accounts are centrally managed run into #223. It isn't clear to me why having your account centrally managed causes this problem. Setting the UID to something different from your users account seems to fix the problem, but doing so has other drawbacks (permissions when mounting directories from the host).


CVAT Version Update from v1.0.0 to v2.0.0 on AWS

Expected Behaviour
Successful loading of data after version upgrade
Current Behaviour
I was using CVAT v1.0.0 on Ubuntu 18.05 and followed steps on following link to create the backup,
Link: https://openvinotoolkit.github.io/cvat/v1.5.0/docs/administration/advanced/backup_guide/#how-to-backup-all-cvat-data
After running, ls backup, I got cvat_data.tar.bz2 and cvat_db.tar.bz2. (Note: I didn't get cvat_events.tar.bz2)
After that I cloned latest version of v2.0.0 and followed steps on following link to upgrade CVAT,
Link: https://openvinotoolkit.github.io/cvat/v1.5.0/docs/faq/

Using the backup files I generated earlier, I backup data again.
But as a result of upgrade, I was able to access login accounts which were generated on older version and names of tasks are also loading but without any data and status. For status, I got across this link,
Link: https://github.com/openvinotoolkit/cvat/issues/4470

Potentially, that could be the issue for status but data is not loading for any of the task/project
Context
Tried to upgrade version of CVAT from v1.0.0 to v2.0.0
Your Environment

Details of AWS
Instance type: t2.medium
Platform: Linux Ubuntu 18.05
Storage: Root device type is EBS volume having device name of /dev/sda1

There were difficult migration between 1.0 and 2.0. In our case it took a couple of days to finish. But it very depend on a number of data in CVAT. Could you provide docker logs cvat?

Here is the text files with output of docker logs cvat  [cvat-logs.txt](https://github.com/openvinotoolkit/cvat/files/8720612/cvat-logs.txt)

@bsekachev do you think i missed some step during upgrade process? well, i tried to review all necessary information before starting upgrade process.
During your upgrade process, what kind of issues did you face?

@azhavoro
Could you please take a look?

@mshaider-msh Hello
Seems you have wrong data structure of CVAT data inside the CVAT container for some reason.
Unfortunately the log you attached is not full and does not contain any migration logs. Could you please also attach the migration log file:docker cp cvat:/home/django/logs/migrations/0024_auto_20191023_1025.log .

Thanks @bsekachev @azhavoro
Output of that file is just,
Start schema migration...

Schema migration is finished...

Start data migration...

It seems like migration didn't happen for whole data. What do you think I missed during whole process?

@mshaider-msh  If the migration log is empty, then your data has not migrated... I suggest deploying your old version, restoring your data from the backup, and trying to upgrade again. Also note that migrating from v1 to v2 may take some time depending on your data. Please let me know if you need help on these steps.

Alright, so here is the update. I used original version again and made another clone of that EC2 instance. On the cloned EC2 instance, I tried to make an upgrade of version again. This time, I am having following error,
WARNING: The no_proxy variable is not set. Defaulting to a blank string.
Starting cvat_opa ...
Creating cvat_redis ... error
Starting traefik    ...
Creating cvat_db    ...

ERROR: for cvat_redis  Cannot create container for service cvat_redis: Conflict. The container name "/cvat_redis" is already in use by container "8705221087b43a724f32bc61cda7e35b1023dc8c0f60def8a5f241798Starting cvat_opa   ... done

Starting traefik    ... done
 You have to remove (or rename) that container to be able to reuse that name.

ERROR: for cvat_redis  Cannot create container for service cvat_redis: Conflict. The container name "/cvat_redis" is already in use by container "8705221087b43a724f32bc61cda7e35b1023dc8c0f60def8a5f241798f851fb7". You have to remove (or rename) that container to be able to reuse that name.

ERROR: for cvat_db  Cannot create container for service cvat_db: Conflict. The container name "/cvat_db" is already in use by container "742af25e38c4952afbb32ad73cdd5050eff3c50749a95581421fda7a640d04c9". You have to remove (or rename) that container to be able to reuse that name.
ERROR: Encountered errors while bringing up the project.

Before running upgrade process, I made sure that, all docker containers are stopped (using docker-compose stop). Also, I made sure that no container is running by using docker ps. Also, I cloned new version of CVAT in a different folder and running the upgrade process there.

I have two folders for CVAT repo. 'loren_cvat' (old version v1.0.0 of already running CVAT) and 'cvat' (new CVAT repository which I cloned from GitHIb). So, probably, above docker volumes are from them. My question is, according to error, if i remove or rename the volumes which it is showing in-use then wouldn't I losing all data? I don't want to loose data during upgrade process so what will be the best work way around?

Here I have attached the cvat logs file also. @azhavoro kindly let me know what should be the best way forwar
cvat-logs-file.txt
d

Hi, @mshaider-msh, Is this question still relevant for you?

Please read the guide. We can help you with the upgrade as commercal support.  I will close the issue. Don't hesitate to contact us with any other questions.
https://opencv.github.io/cvat/docs/administration/advanced/upgrade_guide/


[feature] Ability to click on types within tooltip hints to show further tooltip hints

I think it would be helpful if within a tooltip hint, one could click on parts of the code snippet in order to cause the tooltip hint to update to show the info for the thing that was clicked.
For example, consider this tooltip:

That tooltip currently shows the definition of to because I hovered on to.
Imagine we could click on the ToOptions identifier, and the tooltip hint would update to show the definition of ToOptions instead of the definition of to. We could further click on anything in the defintion of ToOptions to update the tooltip to that, and so on.
I think this would be helpful.
Otherwise, I have to instead close the tooltip, go back to the code, then use the Go to Definition on that piece of code. While Go to Definition itself is great, it may be nice to also offer the tooltip option so that the user has an alternate type-exploration workflow that is consistent with the action they already started (looking at types in a tooltip).
The tooltip will be updated on each click, which may often be good enough. But in cases when the tooltip is not good enough (f.e. too much information to show in the tooltip, etc) then the user can still use the Go to Definition feature in the actual code.

Duplicate of #64566 (which also included a discussion for normal hovers)


UIkit and Foundation templates for meteor status

UIkit and Foundation templates for meteor status

Thanks @hack1m, the new templates are included on the 1.5.0 release =)
Cheers.


Document release process expectations

When looking at the POUF for the reference implementation I realised that we should probably make an effort as part of the release process to ensure it's up to date.
Furthermore we should document the release process and a pre-release checklist of tasks that should be completed before tagging a release.
Possible items for a pre-release checklist:

Ensure the TUF version number written to metdata files is correct and up-to-date
Ensure that POUF 1 is up-to-date
Ensure the CHANGELOG lists major changes
Bump the version number

Possible items for the release process:

tag the release with a signed tag
generate a Python wheel and upload to PyPI
generate archives for inclusion in the GitHub release
Add release information to GitHub with generated archives

Documented in https://github.com/theupdateframework/tuf/pull/1094


Support drag and drop of images from Compose app to other applications

Some of the use cases for my apps require dragging from the Compose application out into other applications, i.e. the reverse of the onExternalDrag modifier.

Ability to select some text and drag that out to other text editors (already tracked as #322)
Ability to drag an image to an image editor (or Discord, etc.)
Ability to drag an image to a file explorer (or mail client, etc.)

Normal Java DnD would do this by putting the image into a Transferable which supports both image flavours and file list flavours. I guess the way the DragData interface has been modelled also allows this, by implementing multiple of its interfaces.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


[CleanShot X]  do not response

Extension
https://www.raycast.com/Aayush9029/cleanshotx
Description
i installed the cleanshot X extension. and when i open a command like capture window in the raycast, there is no response
Steps To Reproduce
null
Current Behaviour
i opened the api in cleanshot X, and also unistalled the extension and installed it again, even restart my computer, but it still doesn't work
Expected Behaviour
it will work

i try to close the screen recording in settings and open it again and it worked! Thank you guys for this good extension!


Automatic instrumentation

Many other APM services offer automatic instrumentation for PHP via an installable extension (a .so file).  For those of us running complicated frameworkless PHP applications, who don't want to add instrumentation to our code, this seems to be the way to go.
Does Sentry have any plans related to such an offering?

This is a good question that went unnoticed 😞 As an OSS contributor to this project I don't have the answer. @mitsuhiko maybe you have some details that you want/can share with us on this?

@smeubank

NewRelic: https://docs.newrelic.com/docs/apm/agents/php-agent/installation/php-agent-installation-overview/
DataDog: https://docs.datadoghq.com/integrations/php/#overview
It often requires an extension, so it's pretty specialized.

In addition,
AppDynamics: https://docs.appdynamics.com/20.x/en/application-monitoring/install-app-server-agents/php-agent/install-the-php-agent
SolarWinds: https://documentation.solarwinds.com/en/success_center/appoptics/content/kb/apm_tracing/php.htm
Elastic APM: https://www.elastic.co/guide/en/apm/agent/php/current/index.html
Atatus: https://docs.atatus.com/docs/application-monitoring/php-agent/overview.html

any news on this? having to start transactions and spans for every method call is far from ideal... was thinking of hacking something together with magic methods and monkey patching / class loading to do something like renaming all methods in a class to a __instrumented_ prefix type of convention and via __call magic methods take over the responsibility of the original method and delegate over to the renamed __instrumented_ prefixed counterpart. Is there no "open instrumentation" framework that does this? I once heard and started using something like that for a node.js that did automatic instrumentation in many languages (they have PHP but don't support automatic instrumentation yet: https://github.com/open-telemetry/opentelemetry-php) - that was also neat because you could use a single API to instrument and then pump the data out to whatever provider you'd like using their "plugin" model. Perhaps once they do support autoinstrumentation and since they support Newrelic, DataDog, Sentry amongst others, it would be an alternative if it doesn't get implemented by each provider individually on their SDKs.

So the guys from Sqreen (now part of DataDog) published a pretty in-depth analytics on how they built theirs https://blog.sqreen.com/dynamic-instrumentation-agent-php/
And similar to opentelemetry.io like I mentioned earlier, seems like opencensus.io does something similar by implementing a PECL extension to do some level of automatic instrumentation (https://opencensus.io/api/php/using-the-extension/), you still need to tell which classes/methods/functions you want to instrument but it's a path in the right direction.

Using an extension is definitely the way to go: monkey-patching code would make many users recoil and flee from such a tool, since it would mess with a lot of stuff.
OTOH, it requires a completely different skillset to be built, and it may interfere with other extensions doing the same.

You can try out Profiling for PHP https://docs.sentry.io/platforms/php/profiling/, which will give you lots of insights out of the box.
No further plans at this point.


[Add Dataset] Reddit Sentiment Analysis Dataset

Description
Dataset consists of 37K  Reddit User Comments along with their Sentimental Label
Screenshots
No response

Add it and make a PR, @Nupoor10 :))


Fix zip with empty files (#5702)

Tested that without this fix, the included IAF-Test scenario produces a ZIP file with only 0-byte files, like in the original issue. The scenario produces only <result></result> as output, manually checking the ZIP file shows 0 byte files.
With the fix the ZIP file contains the actual data it is supposed to.

The issues that Sonar sees are in files that are not part of this PR.


tech_review: Alternative index creation tools

PCA? Archetypal analysis? Any spatially specific ones or do these ones have issues with spatial data?

@Jihyeonbae : I would recommend that we hold off on this until we have the index creation all the way done. Then we can also explore alternatives.


Docs: In changelog, identify breaking changes

To make upgrading easier for people, identify breaking changes

sure thing! thanks!


YT Play error

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.05.16
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

DownloadError: ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the verbose flag and include its complete output.

I can't play vai YT


Invalid vulkan usage hardening: Renderdoc crashes when a draw call references a shader that uses a descriptor set but isn't bound/specified.

In vk_debug.cpp:
for (uint32_t i = 0; i < descSet; i++)
descSetLayouts[i] = GetResourceManager()->GetCurrentHandle( creationInfo.m_PipelineLayout[pipeInfo.layout].descSetLayouts[i]);
In creationInfo.m_PipelineLayout[pipeInfo.layout].descSetLayouts[i], "i" can be out of bounds of the array due to no descriptor set being bound, crashing RenderDoc.
Attached minimal repro case renderdoc:
EX-BASIC_2017.08.29_17.30.26_frame3006.zip

If I understand correctly then this probably isn't something I'll fix. Tolerating invalid API use is not a goal for RenderDoc on any API, and especially on explicit APIs like Vulkan it's going to cause things to blow up. However that's a problem for the validation layers to solve, handling and surviving invalid use like that will end up meaning I duplicate all the work that goes into the validation layers which is not worthwhile. If this isn't something the validation layers catch then you can file an issue there, they're usually good about adding reported missing checks quickly.
In some cases if it's trivial to add a check I don't mind, but in this case I think there would be a lot of knock-on problems so it's not something I can just silently ignore in one place with minimal impact.
If I've misunderstood and this is valid use but is crashing, let me know and I'll investigate.

Alright, fair enough - I've changed this locally so that it just puts a dummy object in there, which fixes the issue for me.. For this sample I'm still working on all the bindings and making it completely validation proof, but wanted to check if the rest of the state was already as expected using renderdoc. I'll just keep this change locally then, thanks!


fix(brush):fix the bug that the selection rect is not cleared

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

fix #1321
Description of change

brush拖动距离少于1px时，会被视为点击事件误触，但brush矩形不会被清除。修复该bug。

#1321中会出现刷选过程中，不触发mousedown，导致mouseup中startPoint为nu l l报错。修复方法是在mouseup中阻断这种情况。


Spike timeouts in riscv_pmp_full_random_test with experimental-maxperf-pmp-bmfull-icache config

I see spike timeouts in DV runs of the test riscv_pmp_full_random_test test. Below is one example, but I see them in multiple runs (not all of them):
2021-01-07T15:23:14.2445665Z Thu, 07 Jan 2021 15:23:14 INFO     Running spike sim: out/seed-23315/instr_gen/asm_tests/riscv_pmp_full_random_test_11.o
2021-01-07T15:23:24.2463257Z Thu, 07 Jan 2021 15:23:24 ERROR    Timeout[10s]: /nas/lowrisc/tools/spike-ibex/20201023-git-255bf1cacc599b1413438c269100f3ecd0eb3352/bin/spike --log-commits --isa=rv32imcb -l out/seed-23315/instr_gen/asm_tests/riscv_pmp_full_random_test_11.o &> out/seed-23315/instr_gen/spike_sim/riscv_pmp_full_random_test.11.log

From the spike log: The last "normal" instruction is the illegal instruction (is that intentional?). After that spike loops until the timeout through three instructions: j, addi, and sw.
core   0: 0xffffffff800018a8 (0x0000ffe2) c.fswsp fs8, 252(sp)
core   0: exception trap_illegal_instruction, epc 0xffffffff800018a8
core   0:           tval 0x0000000000000000
core   0: 0x0000000080001800 (0x0800006f) j       pc + 0x80
3 0x80001800 (0x0800006f)
core   0: 0xffffffff80001880 (0xf8498993) addi    s3, s3, -124
3 0x80001880 (0xf8498993) x19 0x7fffffec
core   0: 0xffffffff80001884 (0x0019a223) sw      ra, 4(s3)
core   0: exception trap_store_access_fault, epc 0xffffffff80001884
core   0:           tval 0x000000007ffffff0

Logs:

stdout log: log.txt
Full build artifacts: https://artproduks1.artifacts.visualstudio.com/Ace3fc167-bb91-4c33-a65a-ae648df7f974/4efdbdf8-a184-4518-9864-57d2a49c2aed/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2xvd3Jpc2MvcHJvamVjdElkLzRlZmRiZGY4LWExODQtNDUxOC05ODY0LTU3ZDJhNDljMmFlZC9idWlsZElkLzMwMzg0L2FydGlmYWN0TmFtZS9vdXQ1/content?format=file&subPath=%2Fout.tar.xz

Config:

Config: experimental-maxperf-pmp-bmfull-icache
Seed: 23315
Tool: VCS 2020.1

@udinator would you mind having a look?

Hmm, that is a bit strange...not sure why a floating point instruction is being created here.
I'll take a look at this.

Hmm, that is a bit strange...not sure why a floating point instruction is being created here.
I'll take a look at this.

@imphil, would you mind pasting the entire Spike failure log in a txt file?

@udinator The entire log file is around 60 MB and I cannot attach it to this issue due to its size. You can find it (together with all other log files) in the build artifacts linked in the initial comment at out/seed-23315/instr_gen/spike_sim/riscv_pmp_full_random_test.11.log in the archive. Can you access the build artifact link? Otherwise I can copy it over to a Google drive or so.

is the RTL simulation indicating a test success even though Spike times out?

I'm not quite sure how to interpret the stdout log file (also linked in the initial comment). It seems to ERROR and move on for all runs except for the last run 29, when it ends with "ERROR return code: True/255". Not sure if that's a sign of a different problem or just the "error summary" resulting from the previous problems.

@udinator The entire log file is around 60 MB and I cannot attach it to this issue due to its size. You can find it (together with all other log files) in the build artifacts linked in the initial comment at out/seed-23315/instr_gen/spike_sim/riscv_pmp_full_random_test.11.log in the archive. Can you access the build artifact link? Otherwise I can copy it over to a Google drive or so.

is the RTL simulation indicating a test success even though Spike times out?

I'm not quite sure how to interpret the stdout log file (also linked in the initial comment). It seems to ERROR and move on for all runs except for the last run 29, when it ends with "ERROR return code: True/255". Not sure if that's a sign of a different problem or just the "error summary" resulting from the previous problems.

Ahh yes I am able to access the build artifacts.
I've confirmed my suspicions as to what is causing the Spike timeouts, I'll work on fixing this.
Note that even though Spike will timeout, the RTL simulation should still be passing (unless CI blows up as soon as it sees an ISS simulation error, which might be the case since the stdout log doesn't show anything happening past the ISS stage).

Ahh yes I am able to access the build artifacts.
I've confirmed my suspicions as to what is causing the Spike timeouts, I'll work on fixing this.
Note that even though Spike will timeout, the RTL simulation should still be passing (unless CI blows up as soon as it sees an ISS simulation error, which might be the case since the stdout log doesn't show anything happening past the ISS stage).

This test is still timing out in current master (70c3702421feccc0774a9a948aebe94cfa289623).
Here's a more recent run:
make -C dv/uvm/core_ibex ISS=spike IBEX_CONFIG=experimental-maxperf-pmp-bmfull

2021-03-11T10:16:40.4119061Z Thu, 11 Mar 2021 10:16:40 INFO     Running spike sim: out/seed-15769/instr_gen/asm_test/riscv_pmp_full_random_test_13.o
2021-03-11T10:16:50.4136514Z Thu, 11 Mar 2021 10:16:50 ERROR    Timeout[10s]: /nas/lowrisc/tools/spike-ibex/20201023-git-255bf1cacc599b1413438c269100f3ecd0eb3352/bin/spike --log-commits --isa=rv32imcb -l out/seed-15769/instr_gen/asm_test/riscv_pmp_full_random_test_13.o &> out/seed-15769/instr_gen/spike_sim/riscv_pmp_full_random_test.13.log

Log files and artifacts:

stdout log
Full build artifacts

@udinator would you mind having a look (or disable the test if we cannot fix it in the near future)? This is blocking running the Ibex DV regression more regularly.

@imphil, I just created a PR to temporarily remove this from the regression list until I can get some time to fix the issues.


Getting light state

Thanks for this project, here's a (probably super-simple) question from a Javascript newbie ;-) I've got user.setLightState to work without issues so I can turn the lamp on or off, but how do I use getLight or getLights to check the status of the light? It just returns true (for sending the request) and not the actual status...

Each API request is made asynchronously, so you need to pass callback functions which will be called with returned data.
user.getLights(
    // callback with returned API data (which could be an API success or error)
    function(lights) { ... },
    // callback with error data (for XHR or JSON errors only)
    function(error) { ... }
);

Every method is like this, including setLightState, etc.


WIP DST-359: email verification error path

DST-359

[x] re-request verification code

Codecov Report
Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.37%. Comparing base (f10c44f) to head (59d9642).

Files
Patch %
Lines

django_app/report_a_suspected_breach/views.py
92.30%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   76.83%   77.37%   +0.54%
==========================================
  Files          52       52
  Lines        1489     1507      +18
==========================================
+ Hits         1144     1166      +22
+ Misses        345      341       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add verification for note script when decoding

What should be done?
Add validation to the NoteScript decoders, to ensure the MAST and the hash match.
How should it be done?

When is this task done?
When all conversions / serdes have the validation implemented, and testes are written.
Additional context
https://github.com/0xPolygonMiden/miden-base/pull/572#discussion_r1556348320

We should tackle this after we transition to using MAST as the serialized format for note/account code.


Add XML comment in ELM XML with version of CQL-to-ELM translator used

The ELM XML generated by the CQL-to-ELM translator should include the version of the CQL-to-ELM translator which was used to generate it.

Addressed in 1.4.9-SNAPSHOT

Addressed in 1.4.9 release


Labeling a root instance

What problem does this feature solve?
My app doesn't use vue as a base for the project, it is a backbone project, so I this backbone view create instances of vue views inside it and handles the lifecycle of the vue instance. But this means I have a lot of <root> instances which makes debugging a challenge. So what I want is a way to make new Vue({ label: 'root-foo', ... }) or something like that so I can identify them.
What does the proposed API look like?
new Vue({
   name: 'root-bar', //or label or instanceName etc...
   // (...)
})

This should be a feature request to the devtools, not core.

But the logs also show all user intatiated views as root, shouldn’t it just have a name just like any component?

Idk exactly when this got implemented but I just checked and it is working 🎉


market creation: words cut off

new dev task for learning the code base
scalar description words are cut off

should be
here is the figma design. You prob don't have access. we'll set you up.
https://www.figma.com/file/IpIAYVQPeQfuT5TTUboQpo4S/Market-creation?node-id=433%3A3

Properties fo text:

looks like the grid isn't allowing the text to show up

ask @phoebemirman if she has any ideas


Change Get-ADSiteDetail to allow specifying by name

Modify Get-ADSiteDetail to let the user specify a site by name. The default can still be all sites.

Updated in release 0.6.1 (aa47949)


Error when enabling Debug API (bug introduced in Flight 1.2.0?)

After upgrading to Flight 1.2.0, I get an error when trying to enable the Debug API with debug.enable(true).
The error is TypeError: Cannot assign to read only property... and it seems to be caused by this line.

Hey @zeno, thanks for the report. Are you still seeing this?


Correctly format a ControllerPak

Still requires formal testing from someone.
For note, the Original PR was: https://github.com/rasky/libdragon/pull/7 which includes lots of extra detail.

Doxygen issues seem unrelated.

@meeq and @bryc are you able to check that this works / looks correct?

The code itself seems fine to me. It correctly implements a full Controller Pak initialization.
But does this have a place in libdragon?
If libdragon were to get a robust C-Pak and repair function, this would largely become obsolete. An argument could also be made that it would be better for a general N64 library to only modify what is absolutely necessary instead of completely overwriting the entire system area.
IMHO this kind of function is more suited for initializing empty C-Pak data in emulators or flashcart C-Pak managers, not homebrew games and such.

The code itself seems fine to me. It correctly implements a full Controller Pak initialization.
But does this have a place in libdragon?
If libdragon were to get a robust C-Pak and repair function, this would largely become obsolete. An argument could also be made that it would be better for a general N64 library to only modify what is absolutely necessary instead of completely overwriting the entire system area.
IMHO this kind of function is more suited for initializing empty C-Pak data in emulators or flashcart C-Pak managers, not homebrew games and such.

My take is to fix what is broken, and then deprecate it (since we should be looking at a new API anyway).

Well flashcart cpak manager could be written with libdragon too. I agree that homebrew games shouldn't call this function and that we need to rewrite the whole module. At the same time if this PR works better than what its in now, I think merging it is a good idea anyway

This is certainly better than what currently sits at format_mempak.  It merely writes an array of bytes taken from old era Mupen64, under the assumption that the emulator is doing it right (it was not).
Anyway, I'd be happy to assist if and when someone wants to work on a proper complete C-Pak lib 😃. Much of the logic in MPKEdit could be adapted (though it's in JS, it should be possible to port). The only thing MPKEdit lacks currently is a 'smart' IndexTable repair routine, which wasn't a priority because the app doesn't interact with live hardware.


Usage of the integration is not clear

I have two sensors that measure the KWh used and the costs during peak and off-peak hours. It is not clear to me how to use this integration to calculate the energy score. Should I add to the integration only the sensor of the off-peak hours or vice versa the sensor of the peak hours?

From the readme: Smart Home Junkie has made a nice YouTube video on his channel about this integration. For questions and discussion, please see this thread on the Home Assistant Community Forum.


Aqara zigbee temperature humidity sensor

If you can take the .json file out this looks okay to merge.

OK. Deleted.


windows_ad_computer errors when restart not set

The examples show that the resource can be used without setting the restart attribute, but the attribute is defined as required.
Please update the examples to indicate so.
This commit broke the functionality: https://github.com/TAMUArch/cookbook.windows_ad/commit/73946fc6191a8d2f0d2fb7650fca02a68e88b6c3#diff-82457c8063b3841429fae3ae5f1f4e30

These changes have been merged, closing issue.


Using localstack and removing mock dependencies

Fixes #1

Thanks for the PR! 🎉
I had a quick look already. Could you add the following to .travis.yml:
services:
  - docker

This should make the travis happy and run the tests with docker now also in the pipeline.
I also had a quick look into the s3 mock tests. I noticed that, when the aws-sdk version is downgraded to 2.3.2 again the tests are working. I also noticed that with the newer version of the aws-sdk in the multipart tests binary/octet-stream is used as content-type. In the current master this does not happen. Maybe this causes the trouble for the s3 mocks 🤷♀ ?
I will investigate further.

done!