Fix regression that was causing video stuttering

Hello,
This PR fixes the regression described in this issue (https://github.com/raysan5/raylib/issues/2434), in which video stuttering or high amount of tearing was found when running Raylib programs compiled with SUPPORT_PARTIALBUSY_WAIT_LOOP.
The regression was introduced in commit 4e9afac2a55cd3d7b347d9e3706e0dd370386ff7 (https://github.com/raysan5/raylib/commit/4e9afac2a55cd3d7b347d9e3706e0dd370386ff7), and is caused by the way the the busy wait time limit is checked before returning. In the previous version, a target time was calculated by adding the desired time to wait to the current time, and, after sleeping, the remaining busy waiting was done by continously checking the current time until it passed the target time. The stated commit changed this behavior, making it calculate the desired duration of the busy wait, sleeping, and then making the busy wait continously check the difference between the current time and the time the busy wait started, until that difference was higher than the desired duration of the busy wait. I suppose that this second way of checking was less accurate because it does not account for possible imprecision of the actual time spent sleeping.
This PR restores the old partial busy waiting end checking behavior while keeping the busy wait time to 5% of the requested wait time. I've tested it using the method described in the issue linked above and got results similar to the ones I had for version 3.7, while keeping the CPU utilization similar to the one of the current 4.1-dev version.
Please let me know if you're OK with this small change or if you'd like me to change something.
I've also made some optimizations to WaitTime to avoid unnecessary type conversions and divisions but did not include them on this PR to keep the scope on resolving the regression. If you merge this PR I'd like to open a new one with these optimizations.
Thanks a lot, and as always thanks for Raylib.

@flashback-fx thank you very much for reviewing this issue and the fix! :D
Feel free to send a second PR with the optimizations for review and discussion.

Here is the second PR: https://github.com/raysan5/raylib/pull/2504


[1.16] No In-Game Manual

Industrial-foregoing-1.16.4-3.2.5-74675d6
titanium-1.16.4-3.2.2
Loaded just fine, seems to all be in order, but no manual.

Use patchouli

Use patchouli

Thank you :) :)


Update to new "senzing-rest-api-specification" URL

See https://github.com/Senzing/senzing-rest-api-specification/issues/47

Pull requests:

https://github.com/Senzing/ibm-openshift-guide/pull/22


Duplicate Facility Entries in Facility Group

Current behavior
The facility group displays duplicate entries for the facility that was added multiple times.
Expected behavior
The facility group should display each facility only once, regardless of how many times it was added in the OMS.
Steps to reproduce the issue
Open the OMS and navigate to the facilities page.
Add a facility group which is already linked with the facility.
In the App, go to facility group section and for the group(the same which was added in the OMS) view the linked facilities.
Observe the issue.
Environment details
App version : v1.9.3
App environment : UAT
Additional Information

If a facility was added to a group multiple times to users, why would we not want to display it multiple times? Adding facility to group multiple times has downstream impact, so user also needs to know if facility is added multiple times when debugging those scenarios


Make Masonry more agnostic

Fix the issue where the masonry adds a template-x-complete class to layout block.
Resolves: MWPW-143923
Test URLs:

Before: https://main--express--adobecom.hlx.page/in/express/feature/image/resize?martech=off
After: https://agnostic-masonry--express--adobecom.hlx.page/in/express/feature/image/resize?martech=off

Codecov Report
Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 35.14%. Comparing base (72742a7) to head (1210418).

Files
Patch %
Lines

express/blocks/shared/masonry.js
25.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #725      +/-   ##
==========================================
+ Coverage   34.84%   35.14%   +0.30%
==========================================
  Files         131      131
  Lines       25523    25523
==========================================
+ Hits         8893     8971      +78
+ Misses      16630    16552      -78

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Questions about clearing cached web outputs

Is there some delay before a controller action output cache is really invalidated after calling cache.Clear();
And is it possible to target clearing outputcaches more specifically. For example per outputCacheProfile, or even better in my case, per host (in a multi tenant set up).

The old asp.net outputcache stuff is pretty limited in regards what you can do. No, there is no way to do anything profile specific.
If you need more flexibility, I'd suggest to not use outputcache at all.
Or, you can also write your own output cache provider (you can use the code of this one as template...) and play with it/customize it

Ok thanks for the answer. I use mvcdonutcaching  to make it a bit more useful. The cachemanager is set as the cache provider. That way I can clear the output cache trough the cache.Clear() method. But I do see some delay before I see the output cache actually cleared.
Config to make it work together for the curious:
<caching>
  <outputCache defaultProvider="CacheManagerOutputCacheProvider">
    <providers>
      <add cacheName="websiteCache" name="CacheManagerOutputCacheProvider"
           type="CacheManager.Web.CacheManagerOutputCacheProvider, CacheManager.Web" />
    </providers>
  </outputCache>
  <outputCacheSettings>
    <outputCacheProfiles>
      <add name="Indexes" duration="1" varyByParam="*" varyByHeader="host" />
    </outputCacheProfiles>
  </outputCacheSettings>
</caching>


added dockerfile

build a docker container that ships the latest pip-installable version

The docker rapids-singlecell-deps and rapids-singlecell docker images work for me (you can get them from the docker hub and test if they work for you) They also work via singularity and all tests succeeded on our cluster. I also tried apptainer v1.2.3 but that did not work on our cluster (not sure if that is a problem of apptainer itself or specific to the installation on our cluster)
This is as far as I can get with the CI.
The github actions seem to do what they should, however they fail to push to the github container registry with a permission error (I guess because I am not allowed to push to this repository's container registry)
I guess the next steps would be:

[ ] merge this pull request and see if the CI works.
* if it does not work, I guess someone with developer or higher status in the repo should open a new pull request. I am happy to contribute there.
[ ] create a scverse account on docker hub and add pushing to docker hub to the CI workflow as documented here by github and here by docker

o.k. I got the docker pipeline to work for pull requests.
I changed the workflow so that the built images are not uploaded to the container registry for pull requests. I think this is sensible and it avoids permission problems.
For releases, the images should be uploaded to the github container registry (ghcr.io). This should not cause permission problems, since releases are triggered by someone with write permission to the repo. However, I have no way of testing this (but I will be happy to help with debugging in case of problems).
No Idea why the GPU-CI fails, but that should be unrelated to this PR.

Now we’re no longer testing if pushing works right?

Yes, you are right. This is as far as I can get with the permissions I have.
Pushing to the github container registry will work using the GITHUB_TOKEN, if the token permissions are set to permissive and if the action was not triggered by a public fork. Since this is a pull request from a public fork, we will not be able to test pushing to the github container registry from this pull request. This is the reason, why I don't think it makes a lot of sense to push to the container registry from pull requests. Testing pushing to the registry is only really necessary when you want to test/debug the github action (like we are at the moment).
I recommend the following approach in order to test pushing to the container registry:

merge this pull request
create a new branch test-container-push from within this repo, not from a public fork
temporarily activate pushing to the registry form pull requests by changing docker.yml as follows:

comment out all if: github.event_name == 'release' lines
replace all occurrences of push: ${{ github.event_name == 'release' }} with push: true

make sure that the GITHUB_TOKEN permissions are set to permissive
create a pull request from the test-container-push branch - since this is an internal branch, the GITHUB_TOKEN should have write access to the github container registry
pushing to the github container registry should work. If it doesn't, fix the problems within the pull request.
reverse the changes made in 3.
create a release which should trigger building and pushing a container to the github registry

An alternative would be to set up a token specifically for access to the container registry. But in that case, I would recommend to push to the docker registry instead, since the needed steps are very similar and then you have the image on docker hub, where more people will be able to find it.

I see now! Yeah, that makes sense, what do you think @Intron7?

I think this is a great idea. I can merge now if you are ok with it @flying-sheep


Can't comment after checking out pull request

I left comments as part of a review in a PR and then sent it from VS Code and it worked great.
Later, I wanted to make some changes to the PR myself so I clicked the 'checkout' button on the description page which appears to have created a new branch for me to edit the PR in.
I started to modify the PR  but in a few places I wanted to add new comments to get clarification from PR author.
When I click '+' button, the comment editor appears but typing in the text area does nothing. See a screenshot below of a new comment box which I can't type in (above previous comment which I already sent)

Extension version: 0.11.1
VS Code version: Code - Insiders 1.39.0-insider (b7a5b7cf39f569a570599530ffc855b454e37b06, 2019-09-12T08:47:28.947Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 4.4.0-18362-Microsoft

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.94GB (17.56GB free)

Process Argv
--remote=wsl+WLinux

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: WLinux

OS
Linux x64 4.4.0-18362-Microsoft

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4001)

Memory (System)
31.94GB (17.56GB free)

VM
0%

I have similar issue, but after before checkout I can comment just fine, but after checkout on the right hand side, I'm missing the white bar to add comments, but replying to comments seems to be ok

Btw, any pointers where to look up? Maybe something that I can dig into and get familiar with the code?

@yulrizka I think your issue sounds different, mind opening another issue for this?
The white bar is controlled by the "Commenting Range Provider" that the extension registers. There are different providers registered based on whether or not the pull request is currently checked out. For the checked out case, the code is here: https://github.com/microsoft/vscode-pull-request-github/blob/760ce513a88c300333a9f59d9027e5b8769d1f6f/src/view/reviewCommentController.ts#L400
The commenting controller there is responsible for comments on 3 different types of files. Files open in an editor have a url associated with them, which is usually file://path/to/file

Normal files in the workspace. If you open a file that was changed by the PR through the file explorer, it (normally) has the scheme "file"
Files from the "Changes in Pull Request" tree. When you click on one of these files and the diff editor opens, the left hand side is content provided from the extension, and the right hand side is the "file" scheme file. This left hand side has "review" scheme and has some query parameters to it
Files from the "GItHub Pull Request" tree for the checked out PR. For the diff editor opened from this tree, both sides are content provided from the extension, and have the "pr" scheme

From your screenshot, it looks like something is going wrong with the "file" scheme (currentWorkspace.uri.scheme) case

@melink14 Thanks for reporting this, it seems like something is going wrong with focus in the comment editor

I'm not able to repro this. If you're still seeing the issue, please comment!


fileSystemRoutingRoot breaks 404 behavior

Description
Error<EMAIL_ADDRESS>You stumbled upon a bug in Vike's source code. Go to https://github.com/vikejs/vike/issues/new and copy-paste this error; a maintainer will fix the bug (usually under 24 hours).
    at file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage/log404/index.js:81:9
    at Array.forEach (<anonymous>)
    at getPagesAndRoutesInfo (file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage/log404/index.js:73:18)
    at log404 (file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage/log404/index.js:18:13)
    at renderPageAlreadyPrepared (file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage.js:128:15)
    at renderPageAndPrepare (file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage.js:93:12)
    at file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/plugin/shared/getHttpRequestAsyncStore.js:68:35
    at renderPage (file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/runtime/renderPage.js:46:50)
    at file:///Users/dajinchu/Alignable/vite-plugin-ssr/vike/dist/esm/node/plugin/shared/addSsrMiddleware.js:18:27

When filesystemRoutingRoot is specified, 404s throw the above error instead of rendering the error page. This breaks bifrost as we rely on is404 to detect if no route matched and proxy to legacy backend.
Reproduction: https://github.com/dajinchu/vite-plugin-ssr/compare/main...dc%2Frepro-fsrouting-404?body=&expand=1

👍 Let me have a look.

I see what's going on, let me fix it.

Fix pre-released as 0.4.144-commit-6aef8a6.

bifrost

💯 I've added a link to it at https://vike.dev/ruby-on-rails. (But let me know if you'd rather keep it private.)

its not exactly using RoR as a "server" - we're still running on fastify, just proxying some routes to rails and handling turbolinks compatibility. Maybe it goes in "other"
Probably need to write a better README at some point 😅

I'm thinking RoR users may want to know about it and search for "Ruby on Rails" on Vike's docs 🤔. Maybe "backend" would be more fitting than "server".

Probably need to write a better README at some point 😅

It's probably fine for now :)


⚠ Bofrost.be has degraded performance

In 4696050, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2773 ms

Resolved: Bofrost.be performance has improved in a50f5f2.


[SPARK-34879][SQL][test-hive1.2] HiveInspector support DayTimeIntervalType and YearMonthIntervalType

What changes were proposed in this pull request?
Make HiveInspector support DayTimeIntervalType and YearMonthIntervalType.
Then we can use these two types in HiveUDF and HiveScriptTransformation
Why are the changes needed?
Support more data type when use hive serde
Does this PR introduce any user-facing change?
User can use  DayTimeIntervalType and YearMonthIntervalType in HiveUDF and  HiveScriptTransformation
How was this patch tested?
Added UT

Test build #136591 has started for PR 31979 at commit 8fa2dfe.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41175/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41175/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41175/

Test build #136591 has finished for PR 31979 at commit 8fa2dfe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136591/

@AngersZhuuuu Could you add [test-hive1.2] to PR's title like in https://github.com/apache/spark/pull/29803, and re-trigger tests.

retest this please

@AngersZhuuuu Could you add [test-hive1.2] to PR's title like in #29803, and re-trigger tests.

Yea

Test build #136603 has started for PR 31979 at commit a55344e.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41186/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41186/

Test build #136603 has finished for PR 31979 at commit a55344e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136603/

Test build #136606 has started for PR 31979 at commit 91b917f.

Test build #136607 has started for PR 31979 at commit 2199749.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41189/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41189/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41189/

Test build #136606 has finished for PR 31979 at commit 91b917f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #136607 has finished for PR 31979 at commit 2199749.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136607/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136606/

@MaxGekk . Apache Spark master branch doesn't have Hive 1.2. Is there a reason to trigger [test-hive1.2]?

@AngersZhuuuu Could you add [test-hive1.2] to PR's title like in #29803, and re-trigger tests.

@MaxGekk . Apache Spark master branch doesn't have Hive 1.2 (or hive-1.2 profile). Is there a reason to trigger [test-hive1.2]?

@AngersZhuuuu Could you add [test-hive1.2] to PR's title like in #29803, and re-trigger tests.

Hmm, right,  we have remove support for hive-1.2 since 3.1.1.

Test build #136621 has started for PR 31979 at commit 4e88bdf.

Test build #136622 has started for PR 31979 at commit 796f1f4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41203/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41204/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41203/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41204/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41203/

Test build #136624 has started for PR 31979 at commit b368584.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41207/

Test build #136621 has finished for PR 31979 at commit 4e88bdf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #136622 has finished for PR 31979 at commit 796f1f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Apache Spark master branch doesn't have Hive 1.2

@dongjoon-hyun Thank you for the information. @AngersZhuuuu Sorry, I wasn't aware of that it was removed.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136622/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136621/

+1, LGTM. Merging to master.
Thank you @AngersZhuuuu .

Test build #136624 has finished for PR 31979 at commit b368584.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136624/

Kubernetes integration test unable to build dist.
exiting with code: 141
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41207/


Update linked hashmap to 0.5.3

versions 0.5.1 & 0.5.2 are unsound for linked_hashmap. Bumping this will ensure that dependents are always on a sound version.
Advisory: https://github.com/RustSec/advisory-db/issues/298

Thank you for the PR. Just trying to figure out why neither appveyor nor travis wants to build it before I go ahead and merge.

Looks like it was just some weird behaviour from GitHubs side (sending PR events before creating the PR refs that the CI services use).


[Graph RBAC] Add top to users op

I am adding $top parameter to the get users operation per the specification here: https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/howto/azure-ad-graph-api-supported-queries-filters-and-paging-options#paging-support- to help fix this issue: https://github.com/Azure/azure-sdk-for-js/issues/13625.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@lmazuel if you're good with the change could you please merge?


About the official way of testing the model trained by openfold

Our team has tried and trained several settings to train openfold. Our inference code is modified based on run_pretrained_openfold.py by replacing import_jax_weights_ with torch.load.
However, no model can produce proper prediction and everything looks like random.
Is there a official code to inference based on openfold's model?

Do the metrics look reasonable during training? Do the predictions you get out just superimpose all of the amino acids onto a single point?

@shiyemin could you please share your version of the inference code for the reference purposes.

@gahdritz The training metric seems reasonable. Both with and without DeepSpeed are tested, and none of them work. The points did not superimpose.
@akiladonz Here is our inference code for you reference.
for ddp
def main(args):
    config = model_config(args.model_name)
    model = AlphaFold(config)
    model = model.eval()

    # import_jax_weights_(model, args.param_path, version=args.model_name)

    model_file = 'PATH/TO/checkpoints/epoch=3-step=9999.ckpt'
    sd = torch.load(model_file, map_location='cpu')
    sd = sd['state_dict']
    state_dict = {k[len("model."):]:v for k,v in sd.items()}
    model.load_state_dict(state_dict)

    model = model.to(args.model_device)

for deepspeed
def main(args):
    config = model_config(args.model_name)
    model = AlphaFold(config)
    model = model.eval()

    # import_jax_weights_(model, args.param_path, version=args.model_name)

    model_file = 'PATH/TO/checkpoints/epoch=7-step=2503.ckpt/global_step2504/mp_rank_00_model_states.pt'
    sd = torch.load(model_file, map_location='cpu')
    sd = sd['state_dict']
    state_dict = {k[len("model."):]:v for k,v in sd.items()}
    model.load_state_dict(state_dict)

    model = model.to(args.model_device)

For the DeepSpeed one first, try the following:
from pytorch_lightning.utilities.deepspeed import convert_zero_checkpoint_to_fp32_state_dict

# Load model, train, etc.
# ...

checkpoint_path = 'PATH/TO/checkpoints/epoch=7-step=2503.ckpt
out_path = "converted_checkpoint.pt"

convert_zero_checkpoint_to_fp32_state_dict(checkpoint_path, out_path)
loaded_checkpoint = torch.load(out_path)
model.load_state_dict(d["ema"]["params"])

I also had trouble loading weights before I found this approach, but this works for me.

@gahdritz Can you share your openfold model (even trained on small-scale dataset)?

Just fyi, I don't have any problems loading the parameters directly:
sd = torch.load('mp_rank_00_model_states.pt')
model.load_state_dict(sd['ema']['params'])
@shiyemin curious what performance you get in terms of lddt-CA on validation and for how long/ on how many samples you train.

@shiyemin was your issue resolved?


Unable to delete or detach unwanted local storage

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.22.0
Regression From
NA
Architecture
arm64
Storage Explorer Build Number
20211211.10
Platform
macOS
OS Version
macOS
Bug Description
I have a local storage account that needs to be removed but I do not see any option to remove it. I tried Detach but that throw the error. See the screencast for more details.
https://somup.com/cZf0nFCSaB
Steps to Reproduce
See video: https://somup.com/cZf0nFCSaB
Actual Experience
It is not blocking me but I just want to remove whatever does not exist anymoreremove
Expected Experience
I should be able to detach to remove the unwanted local storage
Additional Context
https://somup.com/cZf0nFCSaB

@khandelwalvikas 1.22.0 is old and we have stopped supporting that version. You should consider upgrading to the latest version if possible.
But before that, you can mitigate your local storage issue by manually deleting the reference of those attachments. StorageExplorer's local attachments are stored in this way. There is an array storing the records of the local attachments in the app's local storage. For each record, there is an entry in your OS credential manager (Credential Manager on Windows, KeyChain Access on Mac, libsecret on Linux). You can manually delete them as you wish. You just need to make sure that after your manual manipulation, the record array in local storage matches the data stored in the OS credential manager. You can refer to this doc on how to manage those data.

Closing due to lack of response. This issue will no longer be monitored. If you need further help, we recommend opening a support ticket via the Azure portal. Alternatively you can open a new issue here.


"Error connecting to<EMAIL_ADDRESS>with HTTP Basic Auth

I'm getting odd behavior trying to proxy my feed reader (liferea) for debugging. I have some HTTP Basic Auth RSS feeds from Livejournal which look like http://users.livejournal.com/davis-square/data/rss?auth=digest. Wireshark shows an unauthenticated request followed by a 401 response, then liferea re-requesting with Basic Auth and a 200 response. If I instead use mitmproxy, mitmproxy only shows a single request/response:
← 502: Error connecting to<EMAIL_ADDRESS>[Errno -5] No address associated with hostname

(Edit: Non-substantive change to make examples consistent with each other.)

@mhils I read the discussion on the issue, but it isn't exactly clear what needs to be done here. :/
Do we want to extract the username from the URL and set it as the Authorization Header?

I can't reproduce this issue with curl anymore, and I haven't seen it pop up somewhere else. I'm closing this for now, until there's more evidence that this is still an issue.


Minimum Unresizable Window Size[bug]

Describe the bug
I'm trying to make a floating bubble over all windows. This bubble should have 60x60 size and have not window decorations. When i start application like that it's ok. But if i set "resizable": false, i can't set window's size less than 200x200. I made this on both Ubuntu(KDE Neon) and Windows. On Windows it's working as expected but not on Ubuntu.
Reproduction
"windows": [
      {
        "fullscreen": false,
        "height": 100,
        "resizable": false,
        "title": "app",
        "width": 100,
        "minWidth": 1,
        "minHeight": 1
      }
    ]

Expected behavior
No response
Platform and versions
Environment
› OS: Linux 22.04 X64
› Node.js: 18.13.0
› npm: 8.19.3
› pnpm: Not installed!
› yarn: Not installed!
› rustup: 1.25.1
› rustc: 1.66.1
› cargo: 1.66.1
› Rust toolchain: stable-x86_64-unknown-linux-gnu
Packages
› @tauri-apps/cli [NPM]: 1.2.3
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.4,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› bundler: Vite
App directory structure
├─ src-tauri
├─ node_modules
├─ src
└─ .vscode
Stack trace
No response
Additional context
No response

Tracked in https://github.com/tauri-apps/tao/issues/561. Thanks for the report.


check to see if a value is not empty on profile page

Fixes for #26, the array sent to the view always has every key set so we just need to check if the values are empty. Updated for all cases on this page.

Great! Keep up the good work @talv86


Crash on EMPageViewController.scrollViewDidScroll(_:) line 631

Crashed: com.apple.main-thread
EXC_BREAKPOINT 0x000000010332c848
EMPageViewController.scrollViewDidScroll(_:)

EMPageViewController.swift - Line 631
EMPageViewController.scrollViewDidScroll(_:) + 631
My Scenario is that I am using PagingViewController() in a ViewController which is embedded in a UIContainerView. My ViewController is on fixed Landscape mode. First of all in the beginning only 1 out of two items shows up. Upon swiping right the second item shows up or the application crashes to the above mentioned lines.

Thanks for the report! I've been working on a new version that doesn't use EMPageViewController. Can you try targeting the 3.0 and see if the crash also happens there?

I will try to update the dependency in the coming release and let you know. For the time being any workaround ?

I haven't seen this crash before, so I don't have any workaround at the moment. Will need to look into it and get back to you on that

Cool.

Version 3.0 is now available as a pre-release: https://github.com/rechsteiner/Parchment/releases/tag/v3.0.0-beta. It should be stable enough to use, but please let me know if you find any issues.

I have tried this new version with iOS 14 and I get 2 errors ... any ideas? I think it would be solved by adding import UIKit..


Disable keep-padding option in shfmt

Has some serious bugs and not really needed

Description

Disable the -kp option in shfmt by disabling it in our editorconfig
Also fixed all files that need to be changed after this
Motivation and Context

This was needed as -kp is buggy (https://github.com/mvdan/sh/issues/652)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[ ] I have added tests to cover my changes, and all the new and existing tests pass.

@cornfeedhobo @nwinkler @davidpfarrell bump

@cornfeedhobo @nwinkler @davidpfarrell bump

Same. And it sounds like mvdan doesn't want to support this feature anymore anyways.

Same. And it sounds like mvdan doesn't want to support this feature anymore anyways.


--watch flag causes crash starting with Mocha 5.0.2

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description
Mocha 5.0.2 - 5.0.3 crashes when using --watch flag with the following error:

Version 5.0.1 works fine.
Steps to Reproduce
I created a minimal demo which reproduces: https://github.com/ip/mocha_bug_demo
Tried with both Yarn and NPM.
Expected behavior: It works
Actual behavior: It crashes
Reproduces how often: 100% of time
Versions

The output of mocha --version and node node_modules/.bin/mocha --version: 5.0.2 - 5.0.3
The output of node --version: v8.9.4
The version and architecture of your operating system: macOS High Sierra 10.13.3 (17D47)
Your shell (bash, zsh, PowerShell, cmd, etc.): zsh 5.3 (x86_64-apple-darwin17.0)
Your browser and version (if running browser tests):
Any other third party Mocha related modules (with versions):
The code transpiler being used:

closed via #3268


lnd: enforce using IP/localhost on peer-/rpc- and restport options

When you forget or omit IP or localhost in those options:

--listen
--rpclisten
--restlisten

You get really strange IP bindings, e.g. forgot localhost on --restlisten + --rpclisten:
lnd --listen=localhost:10111 --rpclisten=10001 --restlisten=8001 --bitcoin.active --bitcoin.simnet
listen tcp <IP_ADDRESS>:10009: bind: can't assign requested address

It wants to bind to IP <IP_ADDRESS> and also some random port 10009 (which was never given above)
Option 1:
Enforce/abort if there is no "localhost" or IP address given in the *listen options.
Option 2:
Default to localhost (but the wrong port needs to be fixed) so that this is possible without weird behaviour:
lnd --listen=10111 --rpclisten=10001 --restlisten=8001 --bitcoin.active --bitcoin.simnet

If you omit the listening interface, you're using the arguments incorrectly. We require the listening interface to be completely defined.

Ok, if it is incorrect, why not throw an error instead of defaulting to some wird 0.0.x.x IP address and cause confusion?
See Slack, some others ran into the same issue already. The previous parameters (peerport, rpcport, restport) where used without interface. Seems some like me just replaced them with the new parameters without adding interface to all but --listen parameter.

Agreed with @ndeet , this is why I used to use the (admittedly) dangerous  --rpclisten=<IP_ADDRESS>:10002 --listen=<IP_ADDRESS>:10012 --restlisten=<IP_ADDRESS>:8002 --no-macaroons in https://github.com/lightningnetwork/lnd/issues/672 because before the update we can just define the listening ports without IP/interface using --rpclisten=10002 --listen=10012 following http://dev.lightning.community/tutorial/01-lncli/index.html . Good thing that tutorial page has been updated to follow the new correct assignment command

The previous parameters (peerport, rpcport, restport) where used without interface.

They were used without an interface, as they all ended in port  ;)

why not throw an error instead of defaulting to some wired 0.0.x.x IP address and cause confusion

It does throw an error atm, as when you go to bind, you won't be able to actually start to listen on that interface.

Defaulting to localhost is a sane fallback though.

They were used without an interface, as they all ended in port ;)
Absolutely correct, nevertheless it was port only before and some people like me just replace the options and oversee that there is also the interface mandatory now :) (agree that this is only temporary problem for users before that change happened)

It does throw an error atm, as when you go to bind, you won't be able to actually start to listen on that interface.
I agree with you it already throws error. It is just a bit confusing imo. So it would be better UX if it would not fail with something confusing like this:
listen tcp <IP_ADDRESS>:10009: bind: can't assign requested address

maybe the error should be thrown before some strange public IP + port is assigned
or as you seem to agree fallback to localhost + issuing a warning maybe that

Fixed by #877.

I have the following issue:  I setup a docker-compose network. And I can only connect to LND via localhost.
This is how I start LND:
exec lnd \
    --debuglevel=trace \
    --noseedbackup \
    --logdir="/data" \
    "--bitcoin.active" \
    "--bitcoin.mainnet" \
    "--bitcoin.node"="btcd" \
    "--btcd.rpccert"="/rpc/rpc.cert" \
    "--btcd.rpchost"="blockchain" \
    "--btcd.rpcuser"="$RPCUSER" \
    "--btcd.rpcpass"="$RPCPASS" \
    "--rpclisten=<IP_ADDRESS>:10001" \
    "--restlisten=<IP_ADDRESS>:8089" \
    "--listen=<IP_ADDRESS>:10011" \

This is the docker compose:
version: '2'

services:

    # btc is an image of bitcoin node which used as base image for btcd and
    # btccli. The environment variables default values determined on stage of
    # container start within starting script.
    btc:
      image: btcd
      build:
        context: btcd/
      volumes:
            - shared:/rpc
            - bitcoin:/data
      environment:
        - RPCUSER
        - RPCPASS
        - NETWORK

    btcd:
        extends: btc
        container_name: btcd
        environment:
          - DEBUG
          - MINING_ADDRESS
        entrypoint: ["./start-btcd.sh"]

    btcctl:
        extends: btc
        container_name: btcctl
        links:
            - "btcd:rpcserver"
        entrypoint: ["./start-btcctl.sh"]

    #
    # lnd - lightening daemon
    #

    lnd:
        image: lnd
        container_name: lnd
        build:
          context: ../
          dockerfile: docker/lnd/Dockerfile
        environment:
          - RPCUSER
          - RPCPASS
          - NETWORK
          - CHAIN
          - DEBUG
        volumes:
            - shared:/rpc
            - lnd:/root/.lnd
        links:
          - "btcd:blockchain"
        ports:
          - "8089:8089"
          - "10001:10001"
          - "10011:10011"
        # expose is not visible from the host
        # expose:
        #  - "8089"
        #  - "10001"
        entrypoint: ["./start-lnd.sh"]

    nodeapp:
        image: nodeapp
        container_name: nodeapp
        build:
          context: nodeapp/
        environment:
          - RPCUSER
          - RPCPASS
          - NETWORK
          - CHAIN
          - DEBUG
        volumes:
            - shared:/rpc
            - lnd:/root/.lnd
        # HOST:CONTAINER
        ports:
           - "8088:8088"
        links:
          - "lnd:lnd"
        # expose only works in containers networks; not visible from host
        # expose:
        #  - "8088"

I am doing the <IP_ADDRESS>:PORT because I am unsure what IPs docker will give me on app start.
Should LND accept connections via <IP_ADDRESS> on all network interfaces?? Or should It NOT do so?


Conform to W3C spec for console.log, error, etc

As mentioned in the comments in #68, we do not conform to the full spec for console.log and the other methods on console. We should refactor it to be compliant. There are two paths:

write some more rust code to emulate how
expose the underlying IO functions and implement the console object in the js layer

For path number 2 you'd expose extism log functions as global js functions like this:
https://github.com/extism/js-pdk/blob/2d72d29c172a8cf597033cd6c975a7bbb35ec579/crates/core/src/prelude/src/index.js#L8
then you'd implement the console object and it's methods in javascript

Closed by #80


Grid view - Simple USER addition to GridView.

This is a simple addition to GridView that allows the user to provide arbitrary locations for the grid lines to draw. This came in handy trying to draw evenly spaced vertical lines that did not line up with major tics. I don't think this functionality was available anywhere else in a simple way, but please let me know if that's incorrect!
Here is the syntax for using this mode:
// set up plot and line locations
PlotPanel plot = ...
float[] hLines = ...
float[] vLines = ...

// add GridView with USER option
GridView gv = plot.addGrid();
gv.setHorizontal(Horizontal.USER);  // these are actually unneccessary
gv.setVertical(Vertical.USER);           // the setLineLocations methods set the mode to USER
gv.setVLineLocations(vLines);
gv.setHLineLocations(hLines);

The GridViewDemo class uses this mode to produce the following graph:

A few more views and modes will be added here, plus the notes from Chris about Apache license and Javadoc tags. Stay tuned...

Closing, will reopen when ready.


RelativeTime: Support custom format

Allow user to supply a strftime() format through the format
attribute, to be used when outside the relative time scope.

Any chance of this getting merged?

Can we expect action in the near future on this issue?

This was merged in via #177, thanks for working on this @nomego! I'll get a release out with a few other things this week!


theme.json allways reset when vscode update

Type: Bug
I modified theme.json to make the theme more suitable for me, but every time vscode updates, the theme.json reset to its origin version
VS Code version: Code 1.82.0 (8b617bd08fd9e3fc94d14adb8d358b56e3f72314, 2023-09-06T22:07:07.438Z)
OS version: Windows_NT x64 10.0.19045
Modes:

The supported way to customize a theme is documented at https://code.visualstudio.com/docs/getstarted/themes#_customizing-a-color-theme


Check behaviour of missing commands between SF SV and V

@ryantheleach

[ ] Check to see if no such command is working correctly, and on which platforms.
[ ] If working incorrectly (or correctly with bad UX), offer a fix.

04:38	<Kane_Hart>	idk if it's sponge or vanilla mc but there is no feedback when you do whitelist name
04:38	<Kane_Hart>	to tell them wrong command

This appears to be vanilla behavior.
whitelist on 1.12.2 results in the help text.
whitelist adsf results in no feedback, and no modification to whitelist.json.


Fixes #768

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring

:scroll: Description
Issue: #768 #769
DynamoDb Clients are now initialized Standalone
:bulb: Motivation and Context
We do not use Spring Data and just wanted simple DynamoDb Initialization
:green_heart: How did you test it?
Integration Tests
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated reference documentation to reflect the change
[x] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Reopening from #772 that for some reason was closed

Ping @maciejwalkowiak  @MatejNedic @tomazfernandes

Tnx on PR. Will try to look at it during the weekend.

Any updates?

Any updates here? We would appreciate this to facilitate upgrade to Spring Boot 3

Hey @driverpt , sorry for late response. I am finally done with all the things that I had waiting personally I will be having more time for open source. Expect review soon!

@maciejwalkowiak I think we can merge this one and release it in 3.0.3

+1 on this issue. I'm looking for the async version for a webflux project as well.

Is this going to be merged anytime soon?


Update LogFactory.cs to expose typed loggers

Preparation work towards supporting non-shared logger in the sipsorcery lib.
Ref https://github.com/sipsorcery-org/sipsorcery/issues/1023

Apologies for the delay in gettiing around to reviewing this.


Updating links in components to go to their specific github page

I found the links to nom's search not super helpful. Often I wanted to look at the source for more details.
An alternative option would be to link to the npm package but I can't imagine wanting to go there vs.Github, and if things are going to transition to bower then thats moot anyway.

I agree, looks good Jacob -- thanks for fixing these up!


enforce vault input index of 0

update trigger and cancel scripts to force vault input to be first. otherwise if the fee paying transaction is the first input the vault can be drained to fees. (resolves #2 )
if you would like to test this fix you can use my fee-drain branch which creates a new action for draining via a trigger transaction and draining via a cancel transaction. (there is also a drain via complete transaction but it doesn't work and I don't think it can work).

Thanks for taking a look!


Question about Quality Extractor

Hello, this open source is very valuable. I want to train based on my own data, and would like to ask about the details of p-mos. Can you open source the model weights of quality extractor?

Hi, the music-mos (i.e. quality extractor) is in this repo

@ivcylc Thank you for your reply.This repo has 4 ckpts. Which ckpt did you use?

Maybe you can begin your setup here
It will autoly help you download the required checkpoint.

https://huggingface.co/datasets/lichang0928/tmp/tree/main
zip of mp4 is here
this is a video i recorded for helping the training and finetuning pipeline

Thank you!


Internal query keyboard

I want to be able to pass the Custom Keyboard to the StatelessQuestio.replyWith...

This is not possible with the current state of the Telegram API. See #1 or this section in the README for more details.
But it would be nice! Sadly I have no idea how to get Telegram to implement that…


Default note name template cannot use time elements

The default name template cannot use time elements (hour, min, sec) even though the code appears to support (most of) the functionality.
I would like to name new journal notes with the time as well as the date. The code in index.ts appears to support it, except calls to createNoteByDate() are passed a parameter that is a Date without the time component.
I would like to ask that the Date parameter could include the time portion of the current date/time where possible. I realize that creating a new note based on the user's selection on the calendar dialog cannot provide the time.
Support for hours in 12 hour format and 24 hour format would also be nice. That option doesn't appear possible with the current implementation in makeNoteName().
Thank you for your consideration of this issue.
Dean

Thanks for the detailed description.
Actually the calendar dialog has the ability to select time, but I dissabled it. I'll enable it after fix this issue :-)

@DeanHutchings It was fixed by latest version: https://github.com/leenzhu/joplin-plugin-journal/releases/tag/v1.1.0


update

Fixes #
Changes proposed in this pull request:

@ashraysinha6069 update this or else it will be closed.


Atom index out of range error

Converting RXN blocks into reaction smiles via an rdkit reaction, the atom index is out of range. This seems to occur randomly, as multiple attempts on the same reaction block show that it may indeed be converted.
The getIdx() method seems to be retrieving atomic indexes way beyond those that should be in the created molecule.
https://github.com/rdkit/rdkit/blob/2190c991f03d44d0df1fd22b372ca85036074301/Code/GraphMol/ROMol.cpp#L158

We’ll need the rxn block to diagnose this one.

I've attached one such rxn block which causes the error
error.txt

Hi @A-Thakkar and @bp-kelley, was any progress made on this issue? I am able to reproduce it using the latest conda-forge python binaries and the v3kAmideBond.rxn file.
As @A-Thakkar reported, the issue seems somewhat random, and sometimes the code will run sucessfully.
Code to reproduce:
from rdkit.Chem import AllChem
from rdkit.Chem import MolToSmiles
_rxn = AllChem.ReactionFromRxnFile('v3k.AmideBond.rxn')
_reacts = [MolToSmiles(r) for r in _rxn.GetReactants()]
_prods = [MolToSmiles(p) for p in _rxn.GetProducts()]
_reacts, _prods

Traceback:
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-3-592d4f2a0a09> in <module>
      2 from rdkit.Chem import MolToSmiles
      3 _rxn = AllChem.ReactionFromRxnFile('v3k.AmideBond.rxn')
----> 4 _reacts = [MolToSmiles(r) for r in _rxn.GetReactants()]
      5 _prods = [MolToSmiles(p) for p in _rxn.GetProducts()]
      6 _reacts, _prods

<ipython-input-3-592d4f2a0a09> in <listcomp>(.0)
      2 from rdkit.Chem import MolToSmiles
      3 _rxn = AllChem.ReactionFromRxnFile('v3k.AmideBond.rxn')
----> 4 _reacts = [MolToSmiles(r) for r in _rxn.GetReactants()]
      5 _prods = [MolToSmiles(p) for p in _rxn.GetProducts()]
      6 _reacts, _prods

RuntimeError: Range Error
	idx
	Violation occurred on line 174 in file Code/GraphMol/ROMol.cpp
	Failed Expression: 22052 < 1
	RDKIT: 2019.03.2
	BOOST: 1_70

Apologies, this fell off my radar.  I’ll take a look on the next few days.

I can reliably get this code to fail, and it does appear to one a bit random:
for i in range(1000):
    print(i)
    _rxn = AllChem.ReactionFromRxnFile('v3kAmideBond.rxn')
    _reacts = [MolToSmiles(r) for r in _rxn.GetReactants()]
    _prods = [MolToSmiles(p) for p in _rxn.GetProducts()]
    print (_reacts, _prods)

I think this has been fixed recently, I've added test for the above bug and hopefully it has been squashed.

I just tried on my windows machine with the current status of master and I am able to reproduce the bug intermittently, so it's definitely not fixed.
Looks like this is a job for valgrind

Hi, is the problem solved? Im facing the same issue: molecule.
GetAtomWithIdx(12)
[08:19:18]

Range Error
idx
Violation occurred on line 206 in file /project/build/temp.linux-x86_64-cpython-39/rdkit/Code/GraphMol/ROMol.cpp
Failed Expression: 12 < 12

RuntimeError                              Traceback (most recent call last)
Input In [57], in <cell line: 1>()
----> 1 molecule.GetAtomWithIdx(12)
RuntimeError: Range Error
idx
Violation occurred on line 206 in file Code/GraphMol/ROMol.cpp
Failed Expression: 12 < 12
RDKIT: 2022.03.1
BOOST: 1_75


Increate salt command timeout

This PR increases the timeout to wait for replies from the Salt minions. This timeout (in seconds) specifies how long the command line client will wait to query the minions and check on running jobs.
The motivation for this PR was that, when deploying a 104 nodes cluster, the default value (5 seconds) was not enough, causing ceph-salt apply command to finish before minions complete (minion jobs were still running though).
Signed-off-by: Ricardo Marques<EMAIL_ADDRESS>

This is a known Salt issue, see https://github.com/saltstack/salt/issues/48470

This is a known Salt issue, see saltstack/salt#48470

And this issue is only seen when running via ceph-salt apply, not when running via state.apply?

This is a known Salt issue, see saltstack/salt#48470

And this issue is only seen when running via ceph-salt apply, not when running via state.apply?

It also happens when running salt -G 'ceph-salt:member' state.apply ceph-salt directly.

This issue was caused by a network overload when all nodes in the cluster were pulling a container image via podman pull.

Closing in favor of https://github.com/ceph/ceph-salt/pull/353


Add nuclei Docker image

Status
In Progress - Docker image seems to work, but supporting integration is still WIP.
Related Issues
None.
Description
What is nuclei - https://github.com/projectdiscovery/nuclei .

Nuclei is a fast tool for configurable targeted scanning based on templates offering massive extensibility and ease of use.
Nuclei is used to send requests across targets based on a template leading to zero false positives and providing effective scanning for known paths. Main use cases for nuclei are during initial reconnaissance phase to quickly check for low hanging fruits or CVEs across targets that are known and easily detectable. It uses retryablehttp-go library designed to handle various errors and retries in case of blocking by WAFs, this is also one of our core modules from custom-queries.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@rotemreiss thanks for your contribution. Is this still "In Progress"?

Hi @glicht , that automation is still in progress, but those are two separate things. I think that you can merge this one ;)

@rotemreiss what is the status with the integration?

@rotemreiss what is the status with the integration?

Hi @glicht,
As already mentioned, you can merge it since it is working just fine.
We may want to add some improvements in the future, but we will make sure to have backward compatibility as every other plugin.

Hi @glicht,
As already mentioned, you can merge it since it is working just fine.
We may want to add some improvements in the future, but we will make sure to have backward compatibility as every other plugin.

@rotemreiss any update on this?


Plans to have ES6 templates

Are there any plans to have templates on ES6 along with TypeScript ones?

Hi! This was already discussed in #118, #117.

As per @antmdvs's comment, we don't have plans for that in the short term. It's important for us to keep the range of things we're maintaining and supporting manageable. Of course, you can make and distribute your own ES6 templates if you wish!

@tugberkugurlu if you want to use ES6, please have a look on my repo (the quick ports for ES6) at https://github.com/thangchung/netcorelibs


Change Structure to utilize Solution function

There are two member variable in Geo_Proc class.
Mat Ball_templete;
Mat Ball_and_Sol_templete;
And There are three functions you can use.
Mat GetTemplate(void);
void SaveTemplate(Mat& templete);
"Ball_templete" has just 4 circles that will be drawn under the billiard balls.
(We can change this variable by calling the function "geo_proc.Draw_Obj_on_Template()".
But you don't care about it. it is just called ones at situation 1)
You need to pay a attention to "Ball_and_Sol_templete" variable.
If you call GetTemplate(void) function, you can get "Ball_templete" as a deep copy.
So,
Mat templete = geo_proc.GetTemplate();
You can draw your solution arrow on local variable "Mat templete"
And you have to call "SaveTemplate(Mat& templete);"  to save "Mat templete".
SaveTemplate(Mat& templete) can save "Mat templete" to "Mat Ball_and_Sol_templete"
Later, geo_proc.Draw_3D_Template_on_Img(img); will draw final our solution arrows!
To abstract,

Get template ( from     Mat Ball_templete;
draw your solution on template
Save template (to      Mat Ball_and_Sol_templete; )

LGTM :)


UID Type missing

class User extends Model {
  static entity = 'users'

  static fields () {
    return {
      id: this.uid(() => uuid())
    }
  }
}

Seems like there is no UidField decorator?

After reading the source I see other decorators are ultimately calling the Field(Model...... So tried that way.
  @Field(Model.uid(() => uuid()))

this works.
But obviously should have a @UidField decorator too.

Yup, fair call. I must have missed that one. Merged, thanks for the input!

@Scotley I think the auto-publish to npm action isn't working bcz the version number haven't been increased in package.json. Can you check that please?

Apologies, I have fixed the issue and npm is now on the correct version.


Copyright footer text size fix on about page

#944

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.
It fixes the size of copyright footer on about page and make it more inline with whole project
Summarize what this PR fixes:-
< Detail what your PR changes/fixes >
What ISSUE NUMBER does this fix?
Fixes #944
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

Someone else claimed this issue and already fixed it.


Rename to protoc-java-resource-names-plugin, bump version

Let's allow @ethanbao a chance to veto before merging.

LGTM


Web site icons don't render under Firefox

Under Firefox the main site at httpp://cryptofont.com renders with broken images in place of the icons.


Bugfix/unr 2607 SpatialDebugger crashfix

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Fix SpatialDebugger crash fetching virtual worker color with GDK-space load balancing disabled.
Release note
CHANGELOG.md updated.
Tests
Verified when using PIE with GDK-space load balancing disabled and SpatialDebugger enabled, it no longer crashes.
STRONGLY SUGGESTED: How can this be verified by QA?
As described under Tests above.
Documentation
release note
Primary reviewers
@alastairdglennie

my bad, thanks!


Add UpdateStrategy to VSHNPostgreSQL

Summary
Before reviewing look at: https://github.com/vshn/component-appcat/pull/137
Added stackgres types in: https://github.com/vshn/appcat-comp-functions/pull/33
This PR adds an updateStrategy to VSHNPostgreSQL.
If the updateStrategy is set to OnChange the function will restart the stackgres cluster whenever a restart is pending. It keeps the created SGDbOps for one month.
If the updateStrategy is set to OnDeletion the function will no do anything but keeping the created SGDbOps objects. Any pending changes will be applied once the instance is restarted through other means such as maintenance.
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

Can you please write a small summary what exactly this PR is doing? I had hard times following the logic. For instance how do you decide when the instance has to be deleted when the customer sets the value OnRestart? It's pretty clear though for Immediate.
Also I noticed you do not expose the restart time to the customer when he chooses OnRestart

I tried to improve the PR description, but what do you mean with delete the instance? What instance?

I tried to improve the PR description, but what do you mean with delete the instance? What instance?
How do you decide which runAt time to use for an SGDbOps when updateStrategy is set to OnDeletion?

I tried to improve the PR description, but what do you mean with delete the instance? What instance?
How do you decide which runAt time to use for an SGDbOps when updateStrategy is set to OnDeletion?

When the updateStrategy is OnDeletion (or OnRestart / OnMaitenance / whatever it will be) we don't create any SGDbOps. This is the current behavior. The changes will apply whenever the instance is restarted, most likely during maintenance. So we don't set any runAt time?


Using POST on related collection URLs

just to clarify, as this is not stated explicitly in the spec: is it ok to use POST on related collection URLs (e.g. /posts/1/comments) to create a new resource of the collection's type that is automatically linked to the related resource?

Absolutely.

A resource can be created by sending a POST request to a URL that represents a collection of resources.

A server may choose not to support resource creation at all, but if it does, I would certainly expect related collections to accept POST requests. AFAIK this is not a requirement, however.

thanks, that clarifies that!


Abdullah Kazi

Email
<EMAIL_ADDRESS>Bio
Abdullah is a technology enthusiast
His interest lies in theoretical and computational research especially in physics and Thermodynamics
His strength lies in dedication and passion to his work which is reflected in his experience
With a tech savvy mindset, he has the ability to be an asset to any organization
He has proven his mettle by showcasing his capability in various tasks and different situations
and in his leadership skills
He has been involved in different non-technical roles previously
which includes supply chain management
Abdullah was selected as an IBM Z Ambassador to facilitate mainframe education
Abdullah has also worked in open-source quantum computation
Apart from that he is interested in theoretical physics and quantum mechanics along with high energy physics
His research is focused on particle physics
multi physics, High energy physics & Thermodynamics
Abdullah is open for collaborative research on different projects and research opportunities
Projects within OMP you would want to be an ambassador for
Anomaly Detection Engine for Linux Logs (ADE)
Mentorship Program
Ambitus
List any other topics you would be able to speak about
Quantum computing
Mainframe enterprise systems
Why do you want to be an ambassador?
As an efficient Orator with a Business Acumen I have the skills and the attitude needed for this role and it's reflected in my work experience I have attended and hosted many Seminars and have organized many intercultural events in my Institute My experience with various Industries and sector is Vast as I was a working with a Ecommerce Transaction company for which I was a lead in the marketing campaign for a App in which my core responsibilities were brand promotions and outreach .I have also worked for a Non-Profit Organization during which my work was to deploy various marketing strategies related to Edtech ventures .I was solely responsible to conduct workshops for 50+student in IIT Madras research park in Artificial intelligence. As a Campus Ambassador for Dockship Dockship is a platform hosting various hiring Hackathons and challenges for AI My responsibilities were to conduct various workshops and brand promotions for various process .During my externship at AT&T Mobility I learned about various business models and How technology is used to create e-commerce business growth After which I was selected as an IBM Z ambassador a flagship event for IBM wherein I was responsible for Facilitating IBM Z Education was also an advocate for CRIO DO CRIO Is a platform for educating students about web development and hiring challenges as. an advocate my job was to teach. And facilitate the students with different technologies. I was also responsible for brand growth and marketing
Being an ambassador is a deeply rewarding opportunity both on a personal level and also in terms of your career prospects.
This Program will give me an opportunity to Develop my skills.
As an Ambassador I Will have the opportunity to get involved with many different types of work allowing me to develop skills in mainframe enterprise computing
As an aspiring Ambassadors I am typically confident, dynamic.
Some of my interpersonal skills
Public Speaking
Communication and interpersonal skills
Presentation skills
Teamwork
Networking
Influence
As an ambassador and as part of this role, I will relay information about the open mainframe project experience to the prospective students of tomorrow.
Attach a headshot

Application NOT accepted by the TAC


fix: ignored ApiKeyConfig for additional providers (#2741)

fix: ignored ApiKeyConfig for additional providers

fix bug with use of Array.concat()

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The circle ci error seems to be a timeout or something, should just be rerun.

@chadkouse good catch! LGTM.

Codecov Report

Merging #2744 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2744      +/-   ##
==========================================
+ Coverage   64.65%   64.94%   +0.29%
==========================================
  Files         201      200       -1
  Lines        9848     9805      -43
  Branches     2023     1888     -135
==========================================
+ Hits         6367     6368       +1
+ Misses       3205     3166      -39
+ Partials      276      271       -5

Impacted Files
Coverage Δ

...aphql-auth-transformer/src/ModelAuthTransformer.ts
91.47% <100%> (ø)
:arrow_up:

...lify-graphql-types-generator/src/compiler/index.ts
90.32% <0%> (ø)
:arrow_up:

...y-graphql-types-generator/src/compiler/legacyIR.ts
96.72% <0%> (ø)
:arrow_up:

...ges/amplify-graphql-types-generator/src/loading.ts
74.5% <0%> (ø)
:arrow_up:

...sync-simulator/src/schema/appsync-scalars/index.ts

...c-simulator/src/schema/directives/aws-subscribe.ts

...s/amplify-appsync-simulator/src/type-definition.ts

...-appsync-simulator/src/velocity/util/list-utils.ts

...simulator/src/data-loader/dynamo-db/utils/index.ts

...ackages/amplify-appsync-simulator/src/utils/log.ts

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0e979...2a54315. Read the comment docs.


Remove NameOriginal

I don't think it's needed. I'm not totally sure about that, but I need to have a look before people start using this new method.

It would be useful to obtain "Sunrise in Bryce Canyon.jpg" instead of "sunrise-in-bryce-canyon.jpg", where the file name is the meta data. An alternative (without additional front matter) is to do:
{{ path.Base .Key | something.QueryUnescape }}

I mainly created this issue to "think about this" before committing to this new API.

We scratched this particular user itch by running exiftool recursively before each build, stuffing the file name (less extension) in the ImageDescription EXIF tag.


Test VuePress v2

VuePress v2 is out. Try and migrate to see what breaks and what works. Push to a test site.

The migration appears to be more difficult than the instructions imply. Will most likely need to wait until version 0.1. is complete to revisit this.


ci: run docker build checks

Proposed changes
Run docker build checks as part of the test suite.
Ref https://docs.docker.com/reference/build-checks/
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks

[ ] I checked that all workflows return a success.
[x] I included all the needed documentation for this change.
[x] I provided the necessary tests.
[x] I squashed all the commits into a single commit.
[x] I followed the Conventional Commit v1.0.0 spec.
[x] I wrote the necessary upgrade instructions in the upgrade guide.
[x] If this pull request is about and existing issue,
I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

[x] Label as breaking if this change breaks compatibility with the previous released version.
[x] Label as either: automation, bug, documentation, enhancement, infrastructure.
[x] Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

/cc @harryzcy

#5862 should unblock this.


✨[Feature Request]: To add a testimonial/review section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add a review/testimonial section where users and their review along with their photo will be displayed.
There will be right and left arrow to view the cards
Use Case
It will help everyone to see the review of the website
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@varshith257 @Anishkagupta04 Please check, if you think this is required then kindly assign this task to me

We already had a recent PR merged for testimonials


Not working on my RPi

This doesn't seem to work on my RPi. The software keeps saying I need "sensors", whatever that is.

You need to have the ADXL345 accelerometer wired to your Raspberry Pi. If you don't have an ADXL345, there's no reason to try and use this program.

k


Adding a package generation script.

@gwyddion39 @egorpushkin PTAL. This script and the associated template will generate the package file needed for uploading to DGC.

Merging now to unblock my progress on the xamarin build server jobs. I'll integrate any comment you two have in future commits..


Mainly servers for fitbit

Mainly new added files for the server that receiving data from fitbit. I've merged Antoni's branch in here before so it might have some other changes as well.
Opening this PR for review and decide if I should just cherry pick fitbit-server to merge in. Thanks!

Don't merge first due to different env file setting (this branch has global env file). Need to cherry pick only fitbit-server directory and the start baseline and stop simulation button.

the env can be resolved after merging this PR.


Updated Layouts with new Formula field

New Field creation (Formula Picklist) based on date requirements. Updated Case/Error Layouts with new field, removing previous editable field.

Original field changed on layout to read-only. This new field is not required.


ARP/Update metadata: DupeGuru.DupeGuru 4.1.1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@msftbot Merge it now.


Asynchronous/Parallel  Domain Authentication?

It seems to be the case that the process to authenticate all the domains listed in ACME_DOMAIN is a synchronous process (although I'm not certain because I'm very new to the GO language).
When the scheduler runs from Heroku, it seems to authenticate the domains in a synchronous and serial manner which means the more domains I add, the longer it takes to get a new cert.
Is this correct? If so, is there a way to make it asynchronous and parallel so that the number of domains doesn't really affect the time it takes to get a cert?

I have no plans for improvements/refactorings on sabayon. It will be deprecated soon.


Actual North direction and what showing in app is different .

Compass is not showing correct North direction. Every time it points to the different north direction which is not correct.
I open my device in any direction it should show north in the right direction.
Can you help me on this, I want to show my compass to always in the north direction, on correct north direction.

What device have you tried? I suggest trying another device to see if it behaves the same. Also, the sensors can (though not always) really go creasy near certain objects and inside the buildings.
So, your problem looks like related to hardware, try to ensure it's not the matter. Then go further.

What device have you tried? I suggest trying another device to see if it behaves the same. Also, the sensors can (though not always) really go creasy near certain objects and inside the buildings.
So, your problem looks like related to hardware, try to ensure it's not the matter. Then go further.

I have tried in Pixel 2 XL device. But it's not working. In which device you have tested and it's working?

Different: Alcatel, Samsung, LG, etc. Just try some other devices. Also, ensure it works the same way outside. It easily may be something fusing in the place you launch the app.


Resizable text button Custom Component

Minimum button width - current button node size
Maximum button width - the text node width
After maximum width -> stretch height
Text margin in styles

Will be implemented with "container" component by user


Some questions about AIR

Hello, I would like to know if the purpose of the AIR (Adaptive Image Restoration) part is to achieve better restoration results. This part constrains the loss on the Translated Image and the Degraded Image, but I noticed that in the figure, the Guided Image is being updated. I would like to understand what exactly is being updated in this section.

Hi! Thanks for your attention.
The Guided image is updated towards a clean version of the Degraded Image through the back-propagated gradients. This is achieved through

an adapter that converts the Guided image to an Translated Image that contains the same contents as the Guided image, while the same degradations as the Degraded Image.
the gradients on the Guided image back-propagated through the loss on the Translated and Degraded Images. Since the Guided image is the clean version of the Translated image, the proximity between the Translated and Degraded Images correspond to the tendency of the Guided image to a clean version of the Degraded Image.

Hope this helps.


Changing domain for authentication does not work

The code tries to set the api endpoint but it does not reflect in the balena.cfg file generated at /tmp/.balena/balena.cfg.

came across this issue and fixed it in #56


[Feature Request]: Use ServiceContext whenever possible

Feature Description
There are instances where the code will resolve to trying to call OpenAI based services even if service context is set globally.
Reason
Passing explicitly the objects required can be tedious and error prone. However sometimes that may not even be possible viz. trying to do with "HyDE Query Transform"
Value of Feature
Make the code more modular and reduce coupling with OpenAI services, also prevent code breaking due to unexpected network calls to OpenAI.

Totally understandable. The service context will be deprecated in the next few weeks in favor of a global settings object, like fastapi.

Also auto resolutions like these:
https://github.com/run-llama/llama_index/blob/main/llama_index/embeddings/utils.py#L45-L61

The plan is to have a single source of truth for which settings to use, with room for local overrides per module

Can you link the corresponding PR/ Issue to this?

It's not up yet, but I will link ot when it's ready (it's a HUGE change lol)

This can be closed right?
Since pydantic settings is the standard now.

This can be closed right?
Since pydantic settings is the standard now.

+1. @logan-markewich , can you help us close this one? Thanks.

Yes! Thanks for catching this


Removed speakers list

Thanks @marvinhosea
I saw you only commented out the speakers component but the speaker tab on the navbar stil remain. Is that okay?

@Taiwrash I feel it still be needed here
Just commenting out will ne better


Sensor groups not working when state_class: total (not total_increasing)

Checklist:

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Release with the issue: v1.9.3
Last working release (if known): N/A
Browser and Operating System:

Edge on Windows 10
HA Companion App on iOS

Description of problem:
I created sensor groups for the various HVAC energy entities reported via Emporia Vue.
The screenshot below shows the entities which display properly (green highlight) and do not display at all (red highlight). Arrows indicate grouping.
The individual entities display (bottom 5 green boxes), but none of the energy sensor groups display. (red boxes)
If I create a template using the same entities and set its state_class to total_increasing, I am able to use that successfully. (top 3 green boxes)
Another sensor group (not pictured) that sums template entities which are set to total_increasing also with a state_class total_increasing of its own displays properly as well.
Javascript errors shown in the web inspector (if applicable): None
I have made a related post about sensor groups in HA Core as well.
Additional information:

I've come to understand this issue is more related to how stats handles mixed state_class entities than any one integration, so I'm closing this issue.


disambiguate header includes

[x] Add pkg to all include paths
[ ] Disambiguate header includes
Resolves #213

If I remember correctly, @mcevoypeter shared a better way of doing this (instead of using -Ipkg everywhere), but I can't find it now. @barter-simsum do you recall?

If I remember correctly, @mcevoypeter shared a better way of doing this (instead of using -Ipkg everywhere), but I can't find it now.

I think this is what you're referring to: https://github.com/urbit/vere/issues/213#issuecomment-1425968673.

no longer care about this. closing


Rename archived_on to archived_at for consistency

All other timestamps are _at (e.g. created_at), rename archived_on for
consistency.
Depends on: https://github.com/ManageIQ/inventory_refresh/pull/51

@gtanzillo dependent PR is merged can you take a look?


Multiple discoverDevices flows from the same client modify eachother

There's something just a bit off with this API. You can't monitor two different search requests concurrently in the same client, although the API would leave you to believe you could. I recommend either passing the SearchRequest in the builder instead of discoverDevices, or make the state local to the function discoverDevices.
Or change the API to something like:
interface LighthouseClient {
    val discoveredDevices: StateFlow<List<AbridgedMediaDevice>>

    fun startDiscovery(searchRequest: SearchRequest)
    fun stopDiscovery()
}

Yeah that's a good point (@ monitoring multiple requests), I'll most likely adjust the API. Thanks for the suggestion!


why the prior loss can be negative

Hello, thank you for this great work!
In stage3, I found the motion prior and init motion prior loss can be negative. As they are log-likelihood, is this Normal ?

I also find that humor rollout sequence may be oversmooth. But as it's trainned from mocap dataset, the high dynamic action  should be support?

Sorry, In the firt question, I have confuse with probability and probability density for continuous random variables. In the second question, as the optimizer just make a trade-off between different loss, when we estimate the high dynamic action, the loss of humor will be bigger than data term loss, which cause the over smooth. I have refine the 2D keypoint confidence estimate by openpose, in which, let confidence be 1.0 when it's bigger than 0.3.


feat: link tracker

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Adds support for multiple Link Tracking Regions:

Fix #267
Test URLs:

Before: https://main--bitdefender--hlxsites.hlx.page/solutions/
After: https://267-linktracker--bitdefender--hlxsites.hlx.page/solutions/

Looks good to me. Just a question though: do we have the option to test with real Analytics?

do we have the option to test with real Analytics?

@sergiucoman Yes, the changes are verified with AEP Debugger extension and will be verified this week in Analytics as well.


groupBy inside a polymorphic relationship results in a bad query.

Laravel Version: 5.3.9
PHP Version: 7.0.10
Database Driver & Version: MariaDB 10.1.17

Description:
When I add groupBy() to a morphedByMany() relationship the resulting query has an issue. When groupBy() is added, the resulting query fails to put the morphed model in quotes.
For example, this relationship created the following SQL:
return $this->morphedByMany('App\Models\Movie', 'listable', 'cnt_lists', 'list_id')->withPivot('id', 'order', 'updated_at')->where('movies.has_poster', true)->groupBy('cnt_lists.list_id')->orderBy('order', 'desc')->withTimestamps();

select `movies`.*, `cnt_lists`.`list_id` as `pivot_list_id`, `cnt_lists`.`listable_id` as `pivot_listable_id`, `cnt_lists`.`id` as `pivot_id`, `cnt_lists`.`order` as `pivot_order`, `cnt_lists`.`updated_at` as `pivot_updated_at`, `cnt_lists`.`created_at` as `pivot_created_at` from `movies` inner join `cnt_lists` on `movies`.`id` = `cnt_lists`.`listable_id` where `cnt_lists`.`list_id` = 3176 and `cnt_lists`.`listable_type` = App\Models\Movie and `movies`.`has_poster` = 1 group by `cnt_lists`.`list_id` order by `order` desc;

Notice that the listable_type model isn't contained in quotes. If you remove the groupBy() from the relationship, you receive an accurate query with the model wrapped in quotes. If I take the broken SQL above and wrap App\Models\Movie in quotes then run it directly in the MariaDB CLI, it works as expected.
Steps To Reproduce:
Just add groupBy() to any morphedByMany() relationship and see the QueryException occur.

I was able to fix it by disabling strict mode in the database config under mysql.
'strict' => false,


[WIP] Add purescript maker

Instead of #359 this is a simpler PureScript maker based on the Elm maker. This is pretty barebones at the moment but I'd love any and all feedback!

LGTM, should have some test though.
See tests/ft_rust.vader.

Noted, I will look into adapting an existing test.

@vaibhavsagar
ping

Hey, thanks for the ping! I got busy with life stuff but will look at this over the weekend 😄

Still a work in progress!

Pushed a fixup to fix the indent issue.
What do you plan to do additionally?

I also need to test the warnings.

I will look into the bufnr stuff. It seems to be the same as with https://github.com/neomake/neomake/pull/1218.

https://github.com/neomake/neomake/pull/1257 should address this.
btw: I think there is a conceptual error in using a file_mode maker, when in fact it should be a project-based one: file_mode makers use location lists, while otherwise a quickfix list is used.  I am not really sure about how to address this, and think the whole idea of file_mode needs to be revisited.

Thanks for looking into this! I agree that having this as a project-based maker would make more sense. I will look into it.

It is more a general, conceptual issue I think.
E.g. cargo was switched to a file_mode maker recently, but I am not sure what the reason was.

Pushed another commit to use the project root in cwd, since the output is relative to it.
Needs more fixed to https://github.com/neomake/neomake/pull/1257 though really.

You've put much more work into this than I have :smile:. I've added a test for warnings.

Merged master, which contains #1257.
Is this OK from your side?
Do you want to make it a project maker already?
My idea about that would be to allow for makers to live in ft/, but allow to specify if they are project makers (or rather if they want to use the quickfix or location list).

I'm happy with the file-based maker for now, I just wanted something simple to start off with and I'm happy for someone else (or future me) to change it to be project-based further down the line.

Thanks!

Please add it to the wiki's list of makers.

Done, thanks!


Remove timezone ('Z') from test data

Addresses change in date handling in Node.js version 8.
Fixes #475

@jmakeig, this PR is just an update to our tests and not the lib code, so it has no effect on apps. See #475.


Add @harudagondi's blog

Hi @harudagondi! Thanks for the PR! Tested your changes, and it works. You're now a member of this web ring. You can add the widget to your site now. Thank you!


Release inputs before closing the session.

Also fixed the test command.
Fixes https://github.com/google/iree/issues/2948

This only address the issue for real GPU, but not swiftshader.
Will hit another error when creating driver and device for vulkan even with #2800
I ../iree/tools/vm_util.cc:227] Creating driver and device for 'vulkan'...
E ../iree/hal/vulkan/debug_reporter.cc:40] libSPIRV-Tools-opt.so: cannot open shared object file: No such file or directory
E ../iree/hal/vulkan/debug_reporter.cc:40] libSPIRV-Tools-opt.so: cannot open shared object file: No such file or directory
[vk_mem_alloc.h : 15777] RAW: vmaCreateAllocator
I ../iree/hal/vulkan/vulkan_driver.cc:298] Created Vulkan Device: SwiftShader Device (LLVM 7.0.1)
[vk_mem_alloc.h : 16824] RAW: vmaCreateBuffer
[vk_mem_alloc.h : 14433] RAW:   AllocateMemory: MemoryTypeIndex=0, AllocationCount=1, Size=4
[vk_mem_alloc.h : 11744] RAW:     Created new block Size=8388608
[vk_mem_alloc.h : 16824] RAW: vmaCreateBuffer
[vk_mem_alloc.h : 14433] RAW:   AllocateMemory: MemoryTypeIndex=0, AllocationCount=1, Size=4
[vk_mem_alloc.h : 11648] RAW:     Returned from existing block #0
[vk_mem_alloc.h : 16934] RAW: vmaDestroyBuffer
[vk_mem_alloc.h : 11934] RAW:   Freed from MemoryTypeIndex=0
[vk_mem_alloc.h : 16824] RAW: vmaCreateBuffer
[vk_mem_alloc.h : 14433] RAW:   AllocateMemory: MemoryTypeIndex=0, AllocationCount=1, Size=4
[vk_mem_alloc.h : 11648] RAW:     Returned from existing block #0
[vk_mem_alloc.h : 16934] RAW: vmaDestroyBuffer
[vk_mem_alloc.h : 11934] RAW:   Freed from MemoryTypeIndex=0
[vk_mem_alloc.h : 16934] RAW: vmaDestroyBuffer
[vk_mem_alloc.h : 11934] RAW:   Freed from MemoryTypeIndex=0
[vk_mem_alloc.h : 15787] RAW: vmaDestroyAllocator
I ../iree/tools/vm_util.cc:227] Creating driver and device for 'vulkan'...
E ../iree/hal/vulkan/debug_reporter.cc:40] libSPIRV-Tools-opt.so: cannot open shared object file: No such file or directory
E ../iree/hal/vulkan/debug_reporter.cc:40] libSPIRV-Tools-opt.so: cannot open shared object file: No such file or directory
/usr/local/google/home/hanchung/test_github/iree/third_party/swiftshader/src/Vulkan/libVulkan.cpp:785 vkCreateDevice TRACE_ASSERT: pCreateInfo->pNext sType =<PHONE_NUMBER>

The error is different from kokoro, I think the reason is that I'm building with Debug and kokoro built IREE with FastBuild.

Filed another issue to track the bug in SwiftShader. I think we can disable the test for now, and unblock for benchmarking on real GPU.


Can’t delete “pattern” for Strings.

Strings always have pattern: "", should be optional.

Added the option to hide pattern in string options in the LHS menu.


Add grapi-explorer

Grapi-explorer is a Kopano fork of the Microsoft Graph Explorer so it can be used with a self hosted Kopano GRAPI.

There are currently changes pending in upstream grapi explorer to allow running it in a subpath.
this pr is halted until it is adapted to these changes.

changed merged in https://stash.kopano.io/projects/KC/repos/grapi-explorer/commits/5bfe8f247f6721866c0151ff6a12d2ca63ad12e5