Dev

fix #80 and fix #59  (not perfect at all, but still)
I wanted to fix the last  small things before going full treesitter mode

Codecov Report

Merging #82 (148bbbf) into master (c64f2c2) will decrease coverage by 2.07%.
The diff coverage is 23.62%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   63.58%   61.51%   -2.08%
==========================================
  Files          27       28       +1
  Lines        2614     2741     +127
==========================================
+ Hits         1662     1686      +24
- Misses        952     1055     +103

Impacted Files
Coverage Δ

src/interpreters/Julia_jupyter.rs
23.62% <23.62%> (ø)

src/display.rs
63.55% <0.00%> (-4.68%)
:arrow_down:

src/interpreter.rs
58.77% <0.00%> (-0.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64f2c2...148bbbf. Read the comment docs.


Value is Null After Casting With "as" Operator

dynamic dynamicObj = new ExpandoObject();
dynamicObj.Test = "TestText";

string var1 = dynamicObj.Test as string;
string var2 = (string)dynamicObj.Test;

dynamicObj = JsonConvert.DeserializeObject<dynamic>("{'Test' : 'TestText'}");

string var3 = dynamicObj.Test as string;
string var4 = (string)dynamicObj.Test;

Console.WriteLine(var1);
Console.WriteLine(var2);
Console.WriteLine(var3);
Console.WriteLine(var4);

Prints
TestText
TestText
(null)
TestText
I expected var3 to have a value of "TestText" but it is actually null.  Why does var1, var2, and var4 have the correct value of "TestText" but var3 is null?
Version: 11.0.2
C# Version: netcoreapp2.0

Any thoughts on this?  This seems like a bug to me because casting with "(string)" works but casting with "as string" doesn't work in the example above for var3 and var4.  If casting as "(string)" works, I would expect "as string" to work.

It is because the underlying type for dynamic is JToken, and JToken overrides the cast operator that is used here:
string var4 = (string)dynamicObj.Test;

Meanwhile as returns null because JToken isn't a string.


Promise from bootstrap is not returned since Beta.10

Short description of the problem:
Prior to this change it was possible to act on the Promise that is returned from the angular bootstrap function. Due to the removed return statements this cannot be done anymore.
What behavior are you expecting?
I would like to call enableDebugTools from @angular/platform-browser on my root component to debug change detection performance in my app.
ionicBootstrap(App, [SINGLETON_PROVIDERS).then(enableDebugTools);

Then it is possible to call ng.profiler.timeChangeDetection(); to get the speed of the change detection for the current application state.
Which Ionic Version?
2.0.0-beta.10

Also as a heads up, soon with offline template compiling the ionicBootstrap function will be replaced with Angular's @AppModule, since the bootstrap process is being refactored: https://docs.google.com/document/d/13-LUm1QvOff2631tHz6C4goIHuMzma2_1_PFiLryoIs/edit?ts=57682de6#heading=h.e07aj2l7pv3h

Great! Thanks for the quick response!


RbVmomi 2.1.0 breaks PBM

With rbvmomi-2.0.1:
>> require 'rbvmomi/pbm'
=> true
>> RbVmomi::PBM::PbmCapabilityProfile
=> RbVmomi::PBM::PbmCapabilityProfile

With rbvmomi-2.1.1
>> require 'rbvmomi/pbm'
=> true
>> RbVmomi::PBM::PbmCapabilityProfile
Traceback (most recent call last):
        3: from /usr/bin/irb:11:in `<main>'
        2: from (irb):4
        1: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:253:in `const_missing'
NameError (uninitialized constant RbVmomi::PBM::PbmCapabilityProfile)

Looks like dynamicProperty attributes of PropertyChange were dropped also:
>> RbVmomi::VIM.PropertyChange(:dynamicProperty => [])
=> #<RbVmomi::VIM::PropertyChange:0x0000559a279ec9a8 @props={:dynamicProperty=>[]}>

with 2.1.1
>> require 'rbvmomi/vim'
=> true
>> RbVmomi::VIM.PropertyChange(:dynamicProperty => [])
Traceback (most recent call last):
        7: from /usr/bin/irb:11:in `<main>'
        6: from (irb):2
        5: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:260:in `method_missing'
        4: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:260:in `new'
        3: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:106:in `initialize'
        2: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:106:in `each'
        1: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:107:in `block in initialize'
RuntimeError (unexpected property name dynamicProperty)

Thanks for reporting @agrare! This whole generation process is crazy. I need to spend some time revamping it. :weary:

@jrgarcia yeah I was thinking of trying to write a rake task to generate the vmodl.db automatically, or at least some spec tests to try to catch regressions.
Is it just generated from the publicly available wsdls or is anything else used?

Unfortunately, it's something internal. I'll see about creating a rake task to generate it from the public WSDL (like it should have been from the start!).

Thanks @jrgarcia !

@agrare v2.1.2 should be available from RubyGems. Sorry it took so long to get this out!


RSAA actions not returning promises.

From What I understood from the docs, [RSAA] actions should return promises,
But it doesn't seem to be the case since I updated to 2.3.0.
What am I missing?

Hi @NirBenya can you be more specific or share some sample code demonstrating the issue please?
https://github.com/agraboso/redux-api-middleware/releases/tag/v2.2.0 did change this middleware to prevent it from returning promises on non-RSAA actions

Hi @nason,
I have and action with the RSAA property, but this does not return a Promise.
this is my code:
 return (dispatch, getState) => {

        const state = getState();
        const token = _.get(state, 'user.csrfToken');

        return dispatch({
            [RSAA]: {
                ...options,
                endpoint: `${API_URL}/${options.endpoint}`,
                credentials: 'include',
                headers: {
                    'X-CSRFToken': token,
                    'Content-Type': 'application/json',
                    'Accept': 'application/json',
                    'X-Client': 'web'
                }
            }
        })
    }

[SOLVED]
The problem was in my middlewares:
I needed redux thunk to come first.
before:
const middlewares = [logicMiddleware, apiMiddleware, thunkMiddleware];
after:
const middlewares = [thunkMiddleware, apiMiddleware, logicMiddleware ];

Changing the order of middlewares did not help in my case:
export const loadProject = (id, {duplicate=false, setAuthHeader=true, pathname="projects"} = {}) => {
  return (dispatch) => {
    const headers = {
      "Content-Type": "application/json"
    };
    if (setAuthHeader) {
      const token = localStorage.getItem('token') || null;
      headers.Authorization = `JWT ${token}`;
    }
    dispatch({
      [CALL_API]: {
        endpoint: `/api/${pathname}/${id}/`,
        headers: headers,
        method: "GET",
        types: [
          "PROJECT_REQUEST",
          {
            type: "LOAD_PROJECT_SUCCESS",
            payload: (action, state, res) => {
              return getJSON(res).then((json) => {
                dispatch(setProp("hidemap", true));
                dispatch(resetContent());
                if (pathname === "published-projects") {
                  json.data.mapbox.modus = "content";
                  json.data.mapbox.isEditable = false;
                }
                if (pathname !== "published-projects" && setAuthHeader)
                  dispatch(fetchStyles());
                return {project: json, duplicate: duplicate};
              });
            }
          },
          "PROJECT_FAILURE"
        ]
      }
    }).then(() => dispatch(ActionCreators.clearHistory()));
  };
};

The 'clearHistory' action is dispatched with version 1.0.3.
However, when I upgrade to 2.3 and change the symbol to [RSAA], it stops working, so it seems no promise is returned?

@oliverbienert , but do you see any errors in the console? if the action doesnt return a promise, it should throw an error like: (...).then is not a function.

Sorry, it was too late when I posted this. I looked at the wrong place. I have a non RSAA action where I use the returned promise to dispatch another action:
export const initLayers = value => {
  return dispatch => {
    dispatch({
      type: INIT_LAYERS,
      value
    }).then(() => dispatch(ActionCreators.clearHistory()));
  };
};

After upgrading, an error is thrown, as expected:
Uncaught TypeError: dispatch(...).then is not a function

So I have to find another way to chain actions.

Simple solution: As dispatch is synchronous by default, I can simply write:
export const initLayers = value => {
  return dispatch => {
    dispatch({
      type: INIT_LAYERS,
      value
    });
    dispatch(ActionCreators.clearHistory());
  };
};

And when I need it with an asynchronous RSAA action, I can still use the returned promise.

What would be the typescript for Dispatch that supports Promises?

@KrzysztofMadejski Please elaborate more. It's not clear, what exactly you want to do. Maybe this can help https://github.com/agraboso/redux-api-middleware/issues/256


Move AssertionUtils to kyuubi-util-scala module

Why are the changes needed?

move AssertionUtils class to kyuubi-util-scala module's test source

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1e3eff6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4904   +/-   ##
========================================
  Coverage          ?   0.00%
========================================
  Files             ?     557
  Lines             ?   30695
  Branches          ?    3994
========================================
  Hits              ?       0
  Misses            ?   30695
  Partials          ?       0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master.


Load local files

This is hacked together as I'm no frontend dev, hopefully I didn't break anything.

Here it is in action: https://dgomezferro.github.io/tla-web

This doesn't seem to update the contents of the "Spec" tab, I still see the default TwoPhase spec in there after using the "load file" feature.

Ported and pushed these changes in 15229e7.
Note that copying spec/trace links won't really work if you load specs from a local file, since there is no global URL to load a spec from. Not a big issue, but just something to be aware of.

This doesn't seem to update the contents of the "Spec" tab, I still see the default TwoPhase spec in there after using the "load file" feature.

@ajdavis Not sure if it is what you encountered, but sometimes you need to place your cursor into the code editor box in order for text changes to appear after a re-load. I will eventually smooth out this UI quirk.

Ah, that's what I'm seeing, correct.

But additionally, bug A:

Load spec from file
Change the contents of the file
Without refreshing the page, load spec from file again

Expected: the contents of the spec in tla-web are updated with the new file contents.
Actual: the contents of the spec in tla-web are unchanged.
Bug B:

Load spec from file
Change the contents of the spec in tla-web
Without refreshing the page, load spec from file again

Expected: file contents overwrite changes I made in tla-web.
Actual: the contents of the spec in tla-web are unchanged.


Allow user to set/configure MSTestV2 as default test framework & configure default project.

How can I switch out the old default MStest Testframework in Visual Studio 2017 with the new MSTestV2 framework as default? question 1 in the picture
How to force IntelliTest to auto-gen all the test stubs for a class, i.e. not one by one.
How to default Intellitest to set/configure my MyTestProject as the target test project and not prompt me everytime? question 2 in the picture

Every time I create VS Intellitest it prompts/defaults to the old MsTest Framework. I would like for it to configure/switch out to the current MStestV2 that was recently released. I looked in settings and could not find it.

@weedkiller : Thank you for reaching out to us. Please find our responses below:

How can I switch out the old default MStest Testframework in Visual Studio 2017 with the new MSTestV2 framework as default? question 1 in the picture

This is currenly in our backlog and there is no way you can make MSTestv2 default as of now. We will try prioritizing this.

2 . How to force IntelliTest to auto-gen all the test stubs for a class, i.e. not one by one

IntelliTest already generates stubs for all methods in a class. You can change method name from drop down box located on top-left corner

How to default Intellitest to set/configure my MyTestProject as the target test project and not prompt me everytime? question 2 in the picture

You need to create project only once in the beginning. For further runs, don't do "Create Intellitest", just do "Run IntelliTest" and save the testcases. They will automatically be saved in the existing project.

hi, In my question 2), in the dialog box, during creation of tests, there is no option to create all function stubs at a class level!.
In your picture - you're showing how to run all tests - which is not the same as create stubs for all public/internal functions of a class

@weedkiller : Which test stubs to create is picked up from testcontext i.e. where you do right-click.
If you right-click and do "create IntelliTest" from inside a method, only test stub for that method will get created. And if you do a right click inside the class but outside any method, test stubs for all the methods in that class will get generated.

@weedkiller : This is a change to the current visual studio experience. Kindly log this request at https://developercommunity.visualstudio.com/spaces/8/index.html so that the team can track it to closure. The code for this settings experience doesn't reside in this repo and hence the ask.


proxy: connect redis with AWS IAM

Problem
Support of IAM Roles for Service Accounts for authentication.
Summary of changes

Obtain aws 15m-long credentials
Retrieve redis password from credentials
Update every 1h to keep connection for more than 12h
For now allow to have different endpoints for pubsub/stream redis.

TODOs:

PubSub doesn't support credentials refresh, consider using stream instead.
We need an AWS role for proxy to be able to connect to both: S3 and elasticache.

Credentials obtaining and connection refresh was tested on xenon preview.
https://github.com/neondatabase/cloud/issues/10365
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Code is rather complex but it seems ok. I don't see anything inherently wrong. How do we plan to roll this out safely?

Code is rather complex but it seems ok. I don't see anything inherently wrong. How do we plan to roll this out safely?

Right now we don't have regional redis anywhere except the preview (and even with the preview it's a bit tricky).
For now I suggest the following plan:

Merge
Add helm-values
Check with the preview in full proxy and cplane setup.


Subscribing to latest price

The component itself works great, good job !
Is there a way to subscribe to the prices displayed in the chart, most importantly the latest price ?
This is critical to allow users to work with the most up to date data and prevent two "sources of truth"

Unfortunately not a functionality the tradingview widgets provide. There is no way of interacting with the charts after initialization. For more customized charts, tradingview offers this -> https://www.tradingview.com/lightweight-charts/


ESLint Plugin Install

How does one go about installing ESLint plugins for brackets. I have tried to install one and could not figure out how to do it. Any help would be appreciated. To be more specific I am trying to install this plugin for ESlint so that brackets' eslint can use it.
https://github.com/adambrgmn/eslint-plugin-extendscript
Thanks

figured it out.
npm install this package inside brackets' "www/extensions/default/brackets-eslint"
put a file named ".eslintrc.js" with the definitions in your projects root directory.
if anyone wants extendscript globals here is how to install them in brackets
https://github.com/adambrgmn/eslint-plugin-extendscript/issues/18


Are cost included in upscaling from ET-Moses to ETM

I was wondering wether with upscaling from ET-Moses to ETM simulationresults for costs are empoyed  in ETM or not. It seems as nothing was changed in energyproduction and -consumption but the market model changed however that systemcost still unchanged.

Only the effects of updated slider-settings affect the scaled back ETM scenario.


Function to append/concat GDFs

If you currently want to append GDFs you can create an empty GDF and define each column by appending the columns of the dataframes.
Example:
import pandas as pd
from pygdf.dataframe import DataFrame

pdf1 = pd.DataFrame({"col1": [1,2,3], "col2": [11,12,13]})
pdf2 = pd.DataFrame({"col1": [4,5,6], "col2": [14,15,16]})
pdf3 = pd.DataFrame({"col1": [7,8,9], "col2": [17,18,19]})

gdf1 = DataFrame.from_pandas(pdf1)
gdf2 = DataFrame.from_pandas(pdf2)
gdf3 = DataFrame.from_pandas(pdf3)

append_gdfs = [gdf1, gdf2, gdf3]
newgdf = DataFrame()
for col in gdf1.columns:
    new_col = None
    for gdf in append_gdfs:
        if new_col is None:
            new_col = gdf[col]
        else:
            new_col = new_col.append(gdf[col])
    newgdf[col] = new_col

There should be append and concat functions similar to pandas.DataFrame.append and pandas.concat for appending dataframe(s).

There is already a concat function in https://github.com/gpuopenanalytics/pygdf/blob/master/pygdf/multi.py.
For append, there is a Series.append but we don't have a DataFrame.append yet.

Closing this and will create a new issues for Series.append.


Show source/target branches on PR's list

Add ability to show source/target branches for Pull Request's list. It can be useful to see which branches are used in each PR right in the list.
Implemented in this PR:

Ability to enable/disable branch info displaying on PR's list
Light and dark theme support
Long names truncation (for repo and branch names separately)
Optional repo displaying (only if repo different than PR's repo)

Examples:

I wonder if we could hide it for mobile/smal-screen view?

I can try. Can you give me any example from existing code (how to detect mobile device)?

And I think we can display them like what they displayed in the pull request view page.

we can display them like what they displayed in the pull request view page

I'm not sure - the interface will be too complex:

As reference I use GitHub representation

Do we really need option to disable this in settings? We have way too many options already and this makes it harder to maintain all their combinations :)

I don't know :) In my production these option is always enabled. I can remove it if we decide so.

I'm ok with it as is

I agree with @lafriks here - people can simply edit the template to avoid putting this in if they really don't want it.

Or hide with css. I would understand if that was some kind of per-user setting where he could show/hide this but as displaying or not does not affect server performance I don't see need for such options in app.ini

+1 for not introducing more setting options.

@lafriks @zeripath I removed the option from config

Thank you for your updating, it looks fine. I did some refactoring on it, major changes and reasons:

clarify getRepoIDs usage, now it also returns the repo IDs for PullRequest.HeadRepo
remove unnecessary ctx.Data["AppSubURL"], use repo.HTMLURL instead this is a must
use span inside a tag, instead of div (well, usually a div shouldn't appear inside the a tag)
escape the branch names in URL  this is a must
remove unnecessary CSS styles and variables
use character instead of SVG arrows (I think the character would save a little rendering resource, if you like SVG, it's also fine, I left the SVG code in comment)

@wxiaoguang looks great. Thanks for help

blocking until either one or other is left just no to leave commented out code in final merge

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0cbec3c). Click here to learn what that means.
The diff coverage is 100.00%.

:exclamation: Current head 0afa9db differs from pull request most recent head d0c27d7. Consider uploading reports for the commit d0c27d7 to get more accurate results

@@           Coverage Diff           @@
##             main   #19747   +/-   ##
=======================================
  Coverage        ?   47.30%
=======================================
  Files           ?      957
  Lines           ?   133343
  Branches        ?        0
=======================================
  Hits            ?    63072
  Misses          ?    62611
  Partials        ?     7660

Impacted Files
Coverage Δ

models/issue_list.go
69.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbec3c...d0c27d7. Read the comment docs.

:rocket:


Fixed a difference in placeholder color and the text color.

Hello, I have fixed the problem no difference in placeholder color and the text color.  Can you check my pull request? Please find the difference in attached image.

This is good addition, thanks!


User-attributes in authorisation and failing OData queries

Hi,
I've been trying to enable user authorisation by attributes and there are two scenarios that are failing where CDS is generating incorrect SQL.
This is an example of this issue, and when it works, it can be used as a working example of using user attributes in CAP.
These two scenarios are:

OData V4 Apply / Group by
Inline count with expand and filter

More details (and log output) can be found in the README in the issue folder
Creating this here so that others can replicate the issue.
Thanks,
Oli

Thanks @gregorwolf. I've updated the README, it was just a typo there, debug output is further down the README.

sorry for the mess, thought I could get it to merge and help out gregor here. turns out i can't :(


[AutoPR web/resource-manager] typo: Fix Microsoft.Web/CommonDefinitions.json

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4504

Build output:

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/2218


[DOCS] Training LLM Mistral SFT crashes

Solve the problem of execution that this tutorial has at the end of the workflow.

The problem in this tutorial is the Mistral model does not fit inside the RAM. I'm trying to provide an offload folder to allow it to temporary save on disk.

Feel free to skip, actually loading the model for this example.

Alternatively, test with GPT2 or something.

Did you try colab (pro)?

@davidberenstein1957 if I change to GPT2, it works. Should we close the issue?

Yes, then the issue can be closed. Thanks @davidberenstein1957


USB mouse written dirty

This is not real issue but a comment,
I took core from https://github.com/renaudhelias/CoreAmstrad
He made this also by scoping functional protocol between USB
joystick and PC and then writing the VHDL code..
and too bad it's written more likely as C than as VHDL.
From synthesis to synthesis it either works or doesn't
chances are about 20%. Just change anything unrelated
recompile and try again... Usual procedure is to experiment
with different values of bInterval and recompiling until it works.
(Of course not changing anything else during such attempts).
It's USB bus is now connected to scopeio so at least one
can have better insight in what is going on with signals
and timings

I see you are using scopeio_xxx.vhd , Do you still need scopeio.vhd ? if you don't, I'll move scopeio_xxx.vhd to scopeio.vhd

Everything works on scopeio_xxx.vhd, I recently
used it to watch USB traffic, the waveforms
look great.
You can make it default, old scopeio.vhd is no
longer needed
On 7/9/19, Miguel Angel<EMAIL_ADDRESS>wrote:

I see you are using scopeio_xxx.vhd , Do you still need scopeio.vhd ? if you
don't, I'll move scopeio_xxx.vhd to scopeio.vhd
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/hdl4fpga/hdl4fpga/issues/118#issuecomment-509677573

usbmouse won't be fixed, but I will keep on searching over the
internet if I can find a better core which supports usb mouse
more reliably


Adding Support for Check Constratint

Hi @xnuinside
I was wondering if you plan on adding support for check constraints. Below are some examples for the check.
CREATE TABLE employees (
id SERIAL PRIMARY KEY,
first_name VARCHAR (50),
last_name VARCHAR (50),
birth_date DATE CHECK (birth_date > '1900-01-01'),
joined_date DATE CHECK (joined_date > birth_date),
salary numeric CHECK(salary > 0)
);
CREATE TABLE Persons (
ID int NOT NULL,
LastName varchar(255) NOT NULL,
FirstName varchar(255),
Age int,
City varchar(255),
CONSTRAINT CHK_Person CHECK (Age>=18 AND City='Sandnes')
);
ALTER TABLE Persons
ADD CHECK (Age>=18);

I will add it to TODO list

@geob3d, I added full support to CHECK statement based on your example )) https://github.com/xnuinside/simple-ddl-parser/pull/6 pls review. I will tomorrow add docs, if you will have any suggestions or comments - add in PR. Full your example, you can find in test test_alter_check_combine_all_variants in file test_alter_statements.py

done in https://github.com/xnuinside/simple-ddl-parser/pull/6


feat: Make Workspace org importing not user specific.

I'd love to see all orgs searchable in this list.

Problem
I cannot demo worskpaces by importing an organization with someone. I can only watch them do it.
Solution
If there is a technical limitation I am unaware and happy to close as won't fix, but the import for orgs on repository insights allow me to type an org and import. I'd love to follow that strategy in workspaces.

Duplicate of: https://github.com/open-sauced/app/issues/2836
Nick wasn't sure that was possible via the GitHub API: worth investigating.

When I looked at this initially, there didn't appear to be a GH API endpoint to search for orgs. You could only get the orgs you belong to. It doesn't prevent us from importing repos from a non-user org, but as far as I know, we can search orgs on GH.

When I looked at this initially, there didn't appear to be a GH API endpoint to search for orgs. You could only get the orgs you belong to. It doesn't prevent us from importing repos from a non-user org, but as far as I know, we can search orgs on GH.

I caught up with Nick via Slack. We can prioritize amongst some other Workspace follow up issues.


Wiki:  Typographic nit in adj_opp_to_hyp()

The wiki reads:

Given the length of the adjacent and opposite sides of a right triangle, returns the length of thee hypotenuse.

Should be: "...length of the hypotenuse."
...unless of course,  you were going for old English, in which case it would be:  "...length of thine hypotneuse."

Fixed in PR.

Mayhaps thee dost ring most aright, but Eald Englisć be'est not in oure list of labors.

Priceless!   Well played!


Last read me corrections

:tada: This PR is included in version 3.1.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Double post protection (or ability to delete own message)

Greetings.
I've posted a text and it posted twice (same content was in the post, now edited).
I'm not sure what was the cause but I assume there's no protection against that now (haven't tested, since there's no way to delete own post).
https://ldjam.com/events/ludum-dare/40/dungeon-chat-bot (here's topic it happened)
Thank you.

Heh, there's an almost comical history of this bug. It has come up many times in the dev chat channel, yet always at times when we're all too busy to do anything about it. Anyway, I'm glad there's an actual report now. :wink:

Marking as duplicate of #1460.


OnNavigatedTO is called twice

This is a regression error from 1.1.12 to 1.1.13 Preview.
In a page I have the following:
var nav = WindowWrapper.Current().NavigationServices.FirstOrDefault();
nav.Navigate(typeof(FormsPage), parameter);
In the FormsPage OnNavigatedTo is called twice. The first time with the parameter. The second time with parameter=null. Obviously my action based one the parameter is cancelled.
I had no problems with 1.1.12

If this is happening for the first page on startup (usually MainPage.xaml, then use OnNavigatingFromAsync as shown below and your problem will be gone. This is as a result of how OnNavigatingFromAsync cancellation works BUT the special case of first page on startup is not accounted for (hence shows up as a bug resulting in MainPage navigating away from itself and coming back to MainPage (hence two hits). If nav started from another page, all is well. Here is the code for OnNavigatingFromAsync. If I have time, I can elaborate on this but @JerryNixon can tell a better story of what is going on here.
public override async Task OnNavigatingFromAsync(NavigatingEventArgs args)
{
    var selfNav = args.TargetPageType == typeof(Views.MainPage);
    if (selfNav)
    {

        args.Cancel = true;
    }
}

Sorry, but your suggestion made no difference.
OnNavigatingFromAsync is called twice. The first time at startup with selfNav true.
The second time at navigating to the FormsPage with selfNav false.
However I still get two calls to OnNavigated To in the FormsPage class
From: dg2k<EMAIL_ADDRESS>Sent: Thursday, December 22, 2016 4:04 PM
To: Windows-XAML/Template10<EMAIL_ADDRESS>Cc: hansenConsult<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Windows-XAML/Template10] OnNavigatedTO is called twice (#1358)
If this is happening for the first page on startup (usually MainPage.xaml, then use OnNavigatingFromAsync as shown below and your problem will be gone. This is as a result of how OnNavigatingFromAsync cancellation works BUT the special case of first page on startup is not accounted for (hence shows up as a bug resulting in MainPage navigating away from itself and coming back to MainPage (hence two hits). If nav started from another page, all is well. Here is the code for OnNavigatingFromAsync. If I have time, I can elaborate on this but @JerryNixon https://github.com/JerryNixon  can tell a better story of what is going on here.
public override async Task OnNavigatingFromAsync(NavigatingEventArgs args)
{
var selfNav = args.TargetPageType == typeof(Views.MainPage);
if (selfNav)
{
    args.Cancel = true;
}

}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Windows-XAML/Template10/issues/1358#issuecomment-268917627 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJWp4DMuEzB-GDJrmJI9XM82V9-M8PcWks5rKw_UgaJpZM4LUdjp .  https://github.com/notifications/beacon/AJWp4AROHO9C7BgzNqtSyU2LD1tNn21Nks5rKw_UgaJpZM4LUdjp.gif

My suggestion is to stop the unnecessary navigation from itself (which will happen only at startup), which otherwise will end up loading again. That is, the code in OnNavigatingFromAsync will stop the unnecessary navigation. Note that if your first page is Views.FormsPage, you must change the Views.MainPage to yours.

I will have to look into this after I get back from vacation. Even if @dg2k is correct, it sounds like the current implementation is wrong and an easy stumbling block to developers trying to use T10. I would rather make this as fool proof as possible - not saying you are a fool @hansenConsult, just making a point.

I can confirm this behaviour with 1.1.13-preview20161207. It looks like the HamburgerMenu fires two navigation calls. In the past, there was a comparision if the current page/parameter is already active, so the second navigation request was ignored.


rename dbs to teacher-training

Context
We're renaming the app to {find,publish}-teacher-training{,-api}.
Changes proposed in this pull request
Change the name of the db that's used in tests (and local dev) to teacher-training.
Guidance to review
Because we've started to change some of the CI build scripts we appear to need this change to unblock the pipeline.
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

This is going to force everyone to rename/reimport their local dev db. Better to make sure this is communicated before merging.

Another one here - https://github.com/DFE-Digital/teacher-training-api/blob/b9ef3cf1396fd69b5d212a1e3fc37d6f74ec78c7/spec/lib/mcb/commands/db_spec.rb#L9

Closing for now


Unifi Security Gateway Connector

Proposed Changes
Community connector for Unifi Security Gateways includes:
Data Connector
Workbooks
Logstash configurations

@morshabi - This is a data connector that depends on LogStash hence would be great if you review this.
Also @dicolanl - This might not be landing in the Azure Sentinel data connectors gallery since has LogStash dependency. Usually our patterns for landing data connectors should not have middleware dependencies (pure CEF. syslog, REST API based Azure Functions poll are supported for landing in gallery UX)

@preetikr understood.  we dont have a way to do the required parsing in any of our provided methods.

@preetikr can we approve this please?

@NoamLandress - Please review this PR from the CEF and LogStash connectivity perspective and let us know. Thanks.

@dicolanl - Apologize for the delay on this one. Please incorporate the changes. Have not thoroughly reviewed the Logstash section. Has the E2E flow of data been validated? Thanks.

@preetikr yes i validated data flow using a device i have and test workspace.


Add test for local rate limiting for specific routes using Envoy

Add test for local rate limiting for specific routes using Envoy
This also tries to fix https://github.com/istio/istio/issues/28285
Will run integ test a few times, to make sure the above issue is fixed

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

Have we found the reason why the test suddenly becomes very flaky?

I think it was because after applying the envoy filter patch we need to wait for some time for rate limit service to be available to talk to envoy. When I added the new test, I moved envoyfilter patch to the test from setup and not moved that sleep. Sleep is only needed for Global ratelimit service where we are setting up rate limit service and redis. I have fixed that in here....

/test release-notes_istio

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ratelimit test failure is likely because the race condition we recently found from CEL. need proxy update to fix taht..

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2e207e12177fe36fe2d3e8e5d29dfab631fef504
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
55988704a5684feff1ed7edff8ac2a9e035a9179
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Some how this request got closed in rebase from a different machine.. started new one at https://github.com/istio/istio/pull/28888


Support quoted/balanced list of speakers

The current list of speakers supports only a first in first out sorting. It would be nice, if there is a balanced sorting by numbers of contributions too. So people who talk little are favoured than talkative people.

Would be a nice feature, but needs some discussion: What should be the source of the balancing?

only the respective agenda item
all agenda items
configurable

For my opinion there are more possible sources:

only the current agenda subitem
the whole agenda item

For my needs it should be only the respective agenda item.
But I think a configurable source would be nice.

Is this still relevant? The list of speakers can be sorted via drag and drop.
I am not planning to add some automatic kind of sorting.

This is a "TODO" milestone issue - not for 3.0. Let us keep the idea open for future.

OpenSlides will, most likely, never support automatic quoting. This is something the administration has to handle manually.
By now, the list of speakers supports certain stuff not make quoting easier, including:

number how many times a speaker was speaking before
highlight the first contribution
show a speakers gender
show pro, contra and arbitrary marked speaker

everything necessary to resolve this issue has been done.


TS2322: Why symbol type is not allowed with enum type?

Instead of using constant variable declarations,
const directionUp: symbol = Symbol();
const directionDown: symbol = Symbol();
const directionLeft: symbol = Symbol();
const directionRight: symbol = Symbol();

it make more sense to use enum type(shown below):

enum Direction {
    Up = Symbol(),
    Down = Symbol(),
    Left = Symbol(),
    Right = Symbol(),
}

Why TypeScript does not allow using symbol type with enum type?

Looks like you want #18408.


Req8/retarget

This version has new code for the fork reset and testing for the fork reset, and every difficulty interval up until the 180 days reversion to 2016.

As discussed, further retarget test improvements deferred to additional PRs.


Repo sync for protected CLA branch

The pull request is created from main637871961572761856 to main to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Elements are not displayed correctly when Left Sidebar is dragged to an extent

Describe the bug

Elements on playlists are not displayed correctly if Left Sidebar is dragged completely to the left, would return to normal behavior if Left Sidebar is dragged rightward to an extent
To Reproduce
Steps to reproduce the behavior:

Apply theme
Open Spotify
Open a playlist
Drag Left Sidebar to the left completely
Elements are not displayed correctly

Screenshots

Left Sidebar dragged to the right to a certain extent, elements displaying normally

Left Sidebar dragged completely to the left, elements display abnormalities starts appearing, most notably album title, artist names, playlist title are affected

DevTools locating one of the elements (album title) affected

Logs

Info for Contributors
Versions
OS: Windows v10.0.22000
Spotify: v<IP_ADDRESS>6
Spicetify: v2.9.7
Dribbblish: v4.2.0-69f283c
Extensions

dribbblish-dynamic.js
extension.js

Settings
{
    "EXPORTED_WITH": "4.2.0",
    "showLoadingScreen": true,
    "openSettingsInfo": true,
    "showSearchBox": true,
    "rightBigCover": true,
    "roundSidebarIcons": true,
    "sidebarHoverAnimation": true,
    "sidebarGapLeft": 5,
    "sidebarGapRight": 32,
    "winTopBar": "none-padding",
    "playbarShadow": true,
    "playbarTransition": true,
    "playerControlsStyle": "dribbblish",
    "showAlbumInfoInPlaybar": true,
    "showGenreInfoInPlaybar": false,
    "fadeDuration": 0.5,
    "customCss": "",
    "colorSelectionAlgorithm": "colorthief",
    "colorOverride": "#1ed760",
    "colorSelectionMode": "default",
    "lightModeLuminance": 0.6,
    "darkModeLuminance": 0.2,
    "theme": "system",
    "darkModeOnTime": "18:00",
    "darkModeOffTime": "06:00",
    "bgTheme": "bw"
}

Theme is broken with latest Spotify update

Yeah I've taken that for granted every Spotify update now, but only decided to make this issue because it might be overlooked on the nearest patch.

I have that issue.

I have the same issue.

how do i make them circles like in the previews in the original post


Static files Configuration for Elastic Beanstalk

Adding configuration so that Elastic Beanstalk knows where to serve the static files from instead of relying on the Django app.

Not ready for review yet.  Going to look into the whitenoise package and see if it's still needed given our local dev process and our other hosting environments.

So this PR will work on Heroku, Docker, and AWS.

Docker users the command python manage.py runserver
Heroku now uses uwsgiwith a path mapping to the static files
AWS uses aws:elasticbeanstalk:environment:proxy:staticfiles: config to set nginx rules from /static

:+1:


Ability to Update a Subscription

There is no way to update a subscription using Cashier. I'd like to be able to use Cashier to do the following:

Use withCoupon() to apply a coupon to an existing subscription

It would also be nice to be able to do other things such as:
2. Change the billing date and use anchorBillingCycleOn() on an existing subscription
3. Possibly other things that Stripe allows in it's Update Subscription API
But even if we just get 1, that would be a start :)
Thanks for the work on Cashier, btw...definitely makes our lives easier.

Hey @connecteev. Think you missed this section:
https://laravel.com/docs/7.x/billing#stripe-sdk

@driesvints I tried it but it does not work
This works fine:
            Stripe::setApiKey(env('STRIPE_SECRET'));
            \Stripe\Subscription::update(
                $stripeSubscriptionId,
                ['coupon' => $couponCode]
            );

However, this throws an exception:
            $stripeSubscription = $currentSubscription->asStripeSubscription();
            $stripeSubscriptionId = $stripeSubscription->id;
            $stripeSubscription->update(
                json_encode(['coupon' => $couponCode])
            );

Exception error message:
{
    "error": "No API key provided.  (HINT: set your API key using \"Stripe::setApiKey(<API-KEY>)\".  You can generate API keys from the Stripe web interface.  See https://stripe.com/api for details, or email<EMAIL_ADDRESS>if you have any questions."
}

which is strange, because I have these defined in my .env file
STRIPE_KEY=your-stripe-key
STRIPE_SECRET=your-stripe-secret

Does it work for you? Can you apply a coupon this way?

@driesvints one more note:
If I manually call Stripe::setApiKey(env('STRIPE_SECRET')); I can get past the "No API key provided." error exception. Even though calling the Stripe library directly like that defeats the purpose, I am encountered with a different error.
{
    "error": "No such subscription: {\"coupon\":\"coupon_forever_plan\"}"
}

Note that this is a valid subscription and valid coupon code, and it works fine on doing this:
            Stripe::setApiKey(env('STRIPE_SECRET'));
            \Stripe\Subscription::update(
                $stripeSubscriptionId,
                ['coupon' => $couponCode]
            );

(just trying to convey that in all likelihood it's not user-error)

Hmm, odd. The example in the docs indeed appears to be wrong. I'll rectify it.
I've also send in a PR to add two convenience methods for updating the underlying stripe objects: https://github.com/laravel/cashier/pull/943

thanks @driesvints once this is merged in I will test my code again


About WikiAnn

Thanks for you excellent work. I am so interested in your work, and I have some questions about the WikiAnn dataset. I got the source dataset from this link. After data statistics, I found that the number of entities in Chinese does not match the number mentioned in your paper. Could you provide me with the dataset used in your paper? Thanks for your kindness!

Thanks. As for the WikiAnn dataset, actually we use the version of balanced splits mentioned in XTREME benchmark for fair comparison. You could refer to the article "Xtreme: A massively multilingual multi-task benchmark for evaluating cross-lingual generalisation" and the balanced Wikiann dataset from "Massively multilingual transfer for NER". Dataset and pre-processing code could be found in the link in the Xtreme paper.

Thanks for your reply. And I will check it again.


Macro commands can take an input file to setup datastore

Macro commands can take an input file that sets values initially in the datastore

Main goals

Deterministic behavior of macros:

babylon webapp deploy -f webapp_data.json

Won't depend on config values

Can give input needed when we skip some tests

How to implement:

Input file stores data in the datastore
Datastore always overrides values given in config


[dev]: update-vscode.sh should checkout package.json and update yarn.lock

I think I mentioned this before but I wonder if we should modify the VS Code PR script to checkout the package.json and yarn.lock, then remove the dependencies we don't want and regenerate the lock.

— @code-asher
Relevant code: https://github.com/cdr/code-server/blob/main/ci/dev/update-vscode.sh

We should also automatically move ripgrep to dependencies as part of this: https://github.com/cdr/code-server/pull/3383


Remove outdated tests - PR2

Hi @isorrentino it's not clear to me why they our outdated. If I'm not mistaken they are compiled and ran in the CI

Hi @isorrentino it's not clear to me why they our outdated. If I'm not mistaken they are compiled and ran in the CI

I do not know how they can run since one of the classes used by most of those tests does not exist anymore. For instance, https://github.com/ami-iit/bipedal-locomotion-framework/blob/935657dc6ab1c22853285c4ccaba49c8aafadbd4/src/Estimators/tests/RobotDynamicsEstimator/CMakeLists.txt#L14 is the test for the SubModelKinDynWrapper class which is no longer defined in the master branch (the latest PR removed it). Furthermore, many tests import the SubModelKinDynWrapper class and cannot run. It's not clear to me why the CI was not failing.


Uncaught TypeError when modifying shape right after drawing it.

Hi,
I'd like to modify a polygon after it has been drawn. For this I've created a listener for 'drawend' and another for 'addfeature' events. In the first handler the draw interaction is removed from the map and the feature is stored in a temporary list. With the help of this list I can determine when the feature drawn will be added to the layer's source. When it happens I add a modify interaction to the map.
However when I close the polygon with a single click it produces an error that comes from modify interaction.
jsFiddle: https://jsfiddle.net/tomi85/4qhpsz67/2/
Platform: Windows 8.1 / Chrome 49 (in FireFox it's ok)
How to reproduce the error:
Please draw an arbitrary shape, but when you are ready to close it to finish your polygon, move your mouse exactly right above to the closing point then click (single click) and don't move until you get an error: "Uncaught TypeError: Cannot read property 'length' of null". This error comes from ol.interaction.Modify.prototype.removeVertex_ function, where this.dragSegments_ value is null. This error or bug can be fixed by setting the line (row 191) from "this.dragSegments_ = null;" to "this.dragSegments_ = [];" in modifyinteraction.js. But you should further check this.
Many thanks,
Tomi

The change you suggest above makes sense. In addition, it would make sense to change line 544 to this.dragSegments_.length = 0;. Pull request accepted.


Sample Memcached added.

@laxmikantbpandhare what if we move the sample to the testdata like we do in the SDK? Then we can use it in tests we write in the future. Maybe put them in testdata/quarkus.

@laxmikantbpandhare what if we move the sample to the testdata like we do in the SDK? Then we can use it in tests we write in the future. Maybe put them in testdata/quarkus.

Yes, we can.


Jesse: Watch connectioncounselingny.com

Jesse requests the watch of the watch_keyword connectioncounselingny\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

connectioncounselingny\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


tools/build-webview: Work in terms of relative paths.

On Windows (at least in Git Bash, which is our recommended way to set up the dev environment on Windows), the absolute paths end up looking like /d/zulip-mobile/….  When one of those gets passed to rsync, it somehow decides to interpret it as a remote location, where the leading /d/ means to go to a remote host called d.  Naturally, that doesn't work out.
To solve the problem, use relative paths.
This is made slightly tricky by the fact that the two different arguments we pass to rsync come to us in the form of paths relative to two different locations: the sources we want to copy are at particular places relative to the source tree, while the destination directory comes from the command line and is therefore relative to the current directory the script was started with.  So we can't pass them both directly to rsync without doing some kind of normalization on them first: if we're not at the source tree's root, then a source path like src/webview/static won't be right, but if we cd to the root then the destination path from the command line won't be right.  That's the problem we'd previously cut right through by normalizing everything into absolute paths.
Happily, GNU's coreutils offers not only readlink but realpath, which includes a --relative-to option.  So we can use that to turn dest relative to the starting directory into a dest that's still relative, but now relative to the source root, just like the source paths are.
(We already require GNU coreutils; that's the ensure-coreutils.sh script invoked near the top of this one.)
Also add a cleaned-up, optional version of the verbose logging that was helpful in debugging this.
Fixes: #4297

Great, thanks! Issues with development on Windows aren't high-visibility for me (I've been using my Mac only), so I'm quite glad for your debugging and fixing this. 🙂
I don't have a Windows computer to test the fix, but I can confirm that

the changes don't add more problems that shellcheck flags
I can still build/run the app for iOS and Android on my Mac

So, merging!

Great, thanks! Issues with development on Windows aren't high-visibility for me (I've been using my Mac only), so I'm quite glad for your debugging and fixing this. 🙂
I don't have a Windows computer to test the fix, but I can confirm that

the changes don't add more problems that shellcheck flags
I can still build/run the app for iOS and Android on my Mac

So, merging!

Thanks for the review! And the testing on macOS -- I did think through that it should be fine (because we already require coreutils in this script), but had not actually tested that myself :slightly_smiling_face:

Thanks for the review! And the testing on macOS -- I did think through that it should be fine (because we already require coreutils in this script), but had not actually tested that myself :slightly_smiling_face:


loss from progress bar appears to be sum of loss across all GPUs in Lightning 1.0.3

🐛 Bug

The loss from progress bar during the training appears to be sum of loss across of all GPUs
Please reproduce using the BoringModel and post here

To Reproduce

One can pick any model and dataset and varies the number of GPUs for training. In my example, I have roughly 0.7 loss for 1 GPUs, 1.4 loss for 2 GPUs and 0.28 loss for 4 GPUs for the first few training batches, indicating loss is roughly the sum instead of mean of loss across all GPUs.
I used the standard from the doc:
def train_step(self, batch, batch_idx):
    loss = self.forward(batch)
   self.log('loss/train', loss, on_step=True, on_epoch=False, sync_dist=True, sync_dist_op='mean')

Note: the loss logged in tensorboard appears to be correct (mean of loss)
Expected behavior
The loss from progress bar during the training should be mean of loss across of all GPUs

Environment
Note: Bugs with code are solved faster ! Colab Notebook should be made public !

IDE: Please, use our python bug_report_model.py template.

Colab Notebook: Please copy and paste the output from our environment collection script (or fill out the checklist below manually).

You can get the script and run it with:
wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py

PyTorch Version (e.g., 1.0):  1.4
OS (e.g., Linux):  Linux
How you installed PyTorch (conda, pip, source):  pip
Build command you used (if compiling from source):
Python version:  3.7
CUDA/cuDNN version:  10.1
GPU models and configuration:
Any other relevant information:   PyTorch Lightning 1.0.3

Additional context

Note: if I don't specify anything, i.e.:
self.log('loss/train', loss)

then the loss from the progress bar appears to be correct.

Does this behavior happen if you explicitly set prog_bar=True?

@s-rog Thanks for your comment.
if I do
self.log('loss/train', loss, on_step=True, on_epoch=False, sync_dist=True, sync_dist_op='mean', progress_bar=True)

It looks like it is still doing sum of losses from all GPUs, instead of averaging them.
Also, it appears the documentation is not clear about "doing self.log('loss/train', loss) logs only the value from rank (gpu) 0":
Depending on where log is called from, Lightning auto-determines the correct logging mode for you. But of course you can override the default behavior by manually setting the log() parameters.
https://pytorch-lightning.readthedocs.io/en/stable/logging.html

https://pytorch-lightning.readthedocs.io/en/stable/lightning_module.html#log
From here you can see by default sync_dist=False but yes the docs from the logging section is not clear and a PR is in order.
The progress bar sum behavior is definitely not intended as well and would require a fix, I'll be taking a closer look when I get a chance.

@tchaton I saw that you were working on #4374 perhaps you have an idea of where the source of this bug is?
Upon preliminary inspection the syncing and reduction happens right after calling log() which should mean loggers and progress bar recieve the same value...

ok the issue is with the default loss logging, not the one you called with self.log
you can test it with the following which works correctly:
self.log('0_5', torch.tensor(0.5, device=self.device), on_step=True, on_epoch=False, prog_bar=True, sync_dist=True, sync_dist_op='mean')
# and also sync_dist_op=None for sum

The reduction behavior for the default loss is sum (sync_dist_op=None) and we need to change it to mean (sync_dist_op='mean')

Hey @s-rog,
Great catch ! Let me have a look at it today.
Best regards,
T.C

Hey @junwen-austin,
class ExtentedModel(BoringModel):

    logged = []

    def training_step(self, batch, batch_idx):
        output = self.layer(batch)
        loss = self.loss(batch, output)
        self.log("train_loss", torch.ones(1).to(self.device), on_step=True, on_epoch=True, sync_dist=True, sync_dist_op='mean', prog_bar=True)
        self.logged.append(1)
        return {"loss": loss}

model = ExtentedModel()
model.training_step_end = None
model.training_epoch_end = None

debug = False
if debug:
    distributed_backend = None
    gpus = 0
else:
    distributed_backend = "ddp"
    gpus = 2

trainer = Trainer(
    max_epochs=1,
    default_root_dir=os.getcwd(),
    limit_train_batches=10,
    limit_test_batches=2,
    limit_val_batches=2,
    distributed_backend=distributed_backend,
    gpus=gpus,
    precision=32,
    )
trainer.fit(model)

print(model.logged)

def sync_ddp_if_available(
    result: Union[torch.Tensor], group: Optional[Any] = None, reduce_op: Optional[Union[ReduceOp, str]] = None
) -> torch.Tensor:
    """
    Function to reduce the tensors from several ddp processes to one master process

    Args:
        result: the value to sync and reduce (typically tensor or number)
        group: the process group to gather results from. Defaults to all processes (world)
        reduce_op: the reduction operation. Defaults to sum.
            Can also be a string of 'avg', 'mean' to calculate the mean during reduction.

    Return:
        reduced value
    """

    if torch.distributed.is_available() and torch.distributed.is_initialized():
        divide_by_world_size = False

        if group is None:
            group = torch.distributed.group.WORLD

        if reduce_op is None:
            reduce_op = torch.distributed.ReduceOp.SUM
        elif isinstance(reduce_op, str) and reduce_op in ("avg", "mean"):
            reduce_op = torch.distributed.ReduceOp.SUM
            divide_by_world_size = True

        # sync all processes before reduction
        torch.distributed.barrier(group=group)
        torch.distributed.all_reduce(result, op=reduce_op, group=group, async_op=False)

        if divide_by_world_size:
            print("MEAN")
            result = result / torch.distributed.get_world_size(group)

    return result

Epoch 0:   0%|                                                                                | 0/12 [00:00<?, ?it/s]
MEAN
MEAN
Epoch 0:   8%|████████▍                                                                                | 1/12 [00:00<00:00, 114.52it/s, loss=1.177, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  17%|████████████████▊                                                                                | 2/12 [00:00<00:00, 173.18it/s, loss=1.657, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  25%|█████████████████████████▎                                                                           | 3/12 [00:00<00:00, 211.25it/s, loss=1.805, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  33%|█████████████████████████████████▋                                                                   | 4/12 [00:00<00:00, 236.69it/s, loss=1.735, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  42%|██████████████████████████████████████████                                                           | 5/12 [00:00<00:00, 255.45it/s, loss=1.696, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  50%|██████████████████████████████████████████████████▌                                                  | 6/12 [00:00<00:00, 270.00it/s, loss=1.500, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  58%|██████████████████████████████████████████████████████████▉                                          | 7/12 [00:00<00:00, 281.26it/s, loss=1.785, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  67%|███████████████████████████████████████████████████████████████████▎                                 | 8/12 [00:00<00:00, 289.95it/s, loss=1.589, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0:  75%|███████████████████████████████████████████████████████████████████████████▊                         | 9/12 [00:00<00:00, 297.11it/s, loss=1.463, v_num=11, train_loss_step=1]
MEAN
MEAN
Epoch 0: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:00<00:00, 284.59it/s, loss=1.379, v_num=11, train_loss_step=1]
[1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
[1, 1, 1, 1, 1, 1, 1, 1, 1, 1]

@tchaton I don't have access to my workstation right now but I believe the MEAN prints (2 for 2 gpus) are from the self.log() which are reduced correctly.
The incorrect behavior is from return {"loss": loss} (at least when I tested with return loss) where the value shown in the progress bar is the sum instead of mean across GPUs.

Hey @s-rog,
Thanks for the update. Let me check it out !
Best regards,
T.C

Hey @s-rog,
Could you modify the test above to reproduce the behaviour ? Not sure I fully grasped your answer.
Best regards,
T.C

    def training_step(self, batch, batch_idx):
        return torch.ones(1).to(self.device)

this should correspond to the loss key on the pbar (the train_loss key that you defined is reduced correctly)

class ExtentedModel(BoringModel):

    def training_step(self, batch, batch_idx):
        output = self.layer(batch)
        loss = self.loss(batch, output)
        loss /= loss.clone().detach()
        return loss

@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
def test_dpp_reduce_mean_pbar(tmpdir):

    os.environ["PL_DEV_DEBUG"] = '1'

    model = ExtentedModel()
    model.training_step_end = None
    model.training_epoch_end = None

    trainer = Trainer(
        max_epochs=1,
        default_root_dir=os.getcwd(),
        limit_train_batches=10,
        limit_test_batches=2,
        limit_val_batches=2,
        distributed_backend="ddp",
        gpus=2,
        precision=32,
        )

    trainer.fit(model)

tests/trainer/legacy_deprecate_flow_log_tests/test_trainer_steps_scalar_return.py::test_dpp_reduce_mean_pbar LOCAL_RANK: 1 - CUDA_VISIBLE_DEVICES: [0,1]
initializing ddp: GLOBAL_RANK: 1, MEMBER: 2/2
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/2

  | Name  | Type   | Params
---------------------------------
0 | layer | Linear | 66
Epoch 0: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:00<00:00, 367.26it/s, loss=1.000, v_num=22

I still get 1 :)
Best,
T.C

GPU available: True, used: True
TPU available: False, using: 0 TPU cores
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1]
LOCAL_RANK: 1 - CUDA_VISIBLE_DEVICES: [0,1]
initializing ddp: GLOBAL_RANK: 1, MEMBER: 2/2
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/2

  | Name  | Type   | Params
---------------------------------
0 | layer | Linear | 66
Epoch 0: 100%|█████████████████████████████| 12/12 [00:00<00:00, 68.94it/s, loss=2.000, v_num=7, self_log=1]

@tchaton This took me a while to figure out but it seems like the bug only shows up if you use self.log as well (like below).
class ExtentedModel(BoringModel):
    def training_step(self, batch, batch_idx):
        output = self.layer(batch)
        loss = self.loss(batch, output)
        loss /= loss.clone().detach()
        self.log('self_log', loss, prog_bar=True, sync_dist=True)
        return loss

also #4479 might be related?

This fix seems to be broken in the latest master (commit 0e19d16ca6f19e13bc7721f48d16ab6584fe1275) with the metrics summed across GPUs rather than averaged. Works correctly in 1.3.8.

I notice this too with the latest commit.
I'm logging losses with sync_dist=True. No matter if I use 'mean' or 'sum' as sync_dist_op, the sum will be logged during training.
If I log a loss, the sum will also be saved in the loss tensor. So if I first log the total loss and then return it, the sum will be returned and shown in the progress bar.
This doesn't happen if I set on_epoch=True and during validation when on_epoch is by default True.
Should we reopen this issue @junwen-austin @tchaton ?


Geoportal's cart implementation - some issues

We are trying to work further with geoportal's cart feature, but observed there are things that can be improved.

It appears that when a cart is processed, the document being presented to the XSLT is the concatenation of the input XML metadata documents. There should be a container for all of the input documents. I.e. the entire concatenation should have one more tag wrapped around it.

https://github.com/Esri/geoportal-server/blob/master/geoportal/src/com/esri/gpt/control/cart/KeysetProcessor.java
a. There's a path traversal vulnerability on the xslt parameter. Practical exploit is likely limited but not impossible in some scenarios. There should be a test to make sure the canonical path of the xslt is located within the metadata directory, and ideally an additional test, such as for the presence of a namespace declaration unique to the cart processor, so that not just any XSLT may be used for processing, but only one clearly intended for the purpose. With the need for a container element in the input document, that container element could use the same namespace.
b. The use of the processor parameter allows the cart processor to instantiate any Java class accessible to the geoportal code, under control of the unauthenticated user. A subsequent check ensures that the class in question must be an instance of KeysetProcessor, but by then, the damage could already be done. For example, one can call the REST interface to instantiate a whole Tomcat server, with many side effects. The class should be inspected to make sure it is a KeysetProcessor before an instance is created.
c. The ZipXmls class has a race condition; it uses a temporary file called "xmls.zip", with nothing to make the name unique. Multiple simultaneous calls to the same request will result in overwriting of the file. https://github.com/Esri/geoportal-server/blob/master/geoportal/src/com/esri/gpt/control/cart/ZipXmls.java
Thanks!

Another point
3. The MergeThenTransform approach doesn't work because that implementation doesn't allow designating an XSLT. Instead it uses the XSLT configured in the properties file under catalog.cart.processor.mergeThenTransform.xslt. It does have other useful features, but it's not quite there because it appears there can be only one use of MergeThenTransform for an entire geoportal.


Allow selecting SpinBox & LineEdit text when focus enters

Fixes #37011
This PR adds a select_all_on_focus property to LineEdit and SpinBox. The property defaults to false so it is backward compatible.

If the control gains focus via keyboard (e.g. TAB), its content is selected immedately.
If the control gains focus via mouse, its content will be selected when the mouse button is up.
For SpinBox, clicking the up and down arrows won't trigger select_all_on_focus related behavior.

LineEdits and SpinBoxes in the following dialogs are set to select all on focus:

Node3D editor plugin

Transform Change dialog
Snap Settings dialog
Viewport Settings dialog

CanvasItem editor plugin

Configure Snap dialog

ColorPicker

Looks like a nice feature. It fixes a minor caveat from #64529 that turned out to be quite jarring for me.
I wonder if it wouldn't make sense to enable the new property by default for SpinBox 🤔
Also not sure how much useful it is for plain LineEdit. Maybe it should be unexposed there?

Also not sure how much useful it is for plain LineEdit. Maybe it should be unexposed there?

Auto selecting LineEdit is used in the 3D transform dialog and snap settings dialog.

Updated SpinBoxes and LineEdit in ColorPicker to use set_select_all_on_focus().

Thanks!


LRN piece-wise linear approximation function coefficients

Hello,
I read your paper and also studied the code here [1] and here [2] but I am wondering how the values of h_inv, coef0 and coef1 are calculated. From the paper I can understand x_sample is derived from the 2^(-n) value with n = 2, but using only this subdivision I can at best get an maximum error of 8.432119111524738% as opposed to your value of a maximum error of 0.5%. Can you elaborate on how the values for h_inv, coef0 and coef1 are computed? Thank you.
[1] https://github.com/doonny/PipeCNN/blob/e63a9b7a7dc55e651193a85c474086f3e08f0835/project/device/conv_pipe.cl#L772
[2] https://github.com/doonny/PipeCNN/blob/e63a9b7a7dc55e651193a85c474086f3e08f0835/project/device/hw_param.cl#L80-L83

Hi, pls refer to the paper for more detailed informations.

Thank your for your fast reply. Unfortunately I cannot find this information in the paper. In section 2.B. part 4) "LRN Kernel" you describe

we divide the function evaluation range by using power of 2^-n, where n is an integer that controls the accuracy.

and

In AlexNet implementation, a maximum approximation error of 0.5% is achieved by setting n = 2.

Can you help me understand in which section the information is given? I could not find it in the paper. Thank you for your time and effort.


Satisfy react-dom by react.js in standalone config

Right now, the webpack standalone config unnessecarily includes react-dom, which bloats unminified size to 640K. With this change, react-dom is satisfied by window.React, which shrinks unminified size down to ~105K.

@bendlas Thanks for your PR. Sorry it took me so long to get back to you.
/dist/standalone/autosuggest.js is just 35.4 kB in version 2.2.5, and it doesn't get smaller if I add 'react-dom': 'React' in webpack.standalone.config.js. I believe this is what you wanted to achieve, but happy to reopen the issue if this is not the case.


chore: Update Lighthouse Version

Description

Update lighthouse to 12.2.2

Linked Issues
N/A
Additional context

Updating to the latest version of lighthouse will resolve an existing security vulnerability

Thanks :)


Is online AI models a possibility via OpenRouter ?

Your work is absolutely amazing, I love it. The problem is 8b models are too much limited. Would it be possible to include a possibility to connect with any online models with OpenRouter for example ? Llama 70B is very fast to answer and it's a lot better than the 8b model ...
Thanks for the great work, very appreciated.

You always can code it yourself.
As a workaround - you can use openRouter in SillyTavern + my wav2lip. It won't have speech to text, but it will be showing video replies:
You need to run both xtts_wav2lip.bat and my modified silly_extras to make it work with Silly tavern. Turn off streaming for openrouter and for XTTS in SillyTavern. Streaming is not yet supported in ST for wav2lip.

You always can code it yourself.
As a workaround - you can use openRouter in SillyTavern + my wav2lip. It won't have speech to text, but it will be showing video replies:
You need to run both xtts_wav2lip.bat and my modified silly_extras to make it work with Silly tavern. Turn off streaming for openrouter and for XTTS in SillyTavern. Streaming is not yet supported in ST for wav2lip.

Thank's for the answer, I've been trying to code it with the help of chat GPT-4 since a few days but I can't get the speed you've got to generate the TTS. I've been using the xtts-api-server and I've tried with your SillyTavern + wavelip you set up, but it's still slow. I just code with python, not with C. Also I've got trouble to interrupt the TTS when it's playing, I can't get it to stop immediately ...

You need to programmatically put 0 into temp/xtts_play_allowed.txt to stop it. And then 1 when it is ok to speak again.

You need to programmatically put 0 into temp/xtts_play_allowed.txt to stop it. And then 1 when it is ok to speak again.

Ok, thank you


add modfication to your answer

Your answer is not clear to reader. And I add some more details.

add another commit


Can't resize window's stats

the windows not have the lower right corner for resize
is my bad?
i miss something?

if you have the arcdps modification keybinds set you have to hold those down to move and resize
if this is checked in arcdps you have to hold down the modifier key to move and rezise

yes but i have to set also modifier 2 to make it works


Feedback for: docker-id/api-reference.md

File: docker-id/api-reference.md
Hello.
Is it possible in near future to include into the user's API a "favorites" feature?
This feature should give back all user's favorite repositories of a particular logged in user.

The docs for this API have been removed


 Does it do it automatically?

After saving it by calling store you can use the restore method to restore the given instance from the db and delete the entry from the db.
https://github.com/Crinsane/LaravelShoppingcart/blob/f460ab7312cce32cb428cf39a500a2d16600b1d6/src/Cart.php#L399

Thanks @bumbummen99.


Creating a retry policy using the service config causes

What version of gRPC and what language are you using?
1.34.0, python
(Though also tried grpcio 1.33.2 and 1.32.0)
What operating system (Linux, Windows,...) and version?
Tested on Ubuntu 20.04 (docker), buster (docker) and MacOS 11.1 results were the same in all cases
What runtime / compiler are you using (e.g. python version or version of gcc)
python 3.8
What did you do?
Created a server that when heavily loaded will return RESOURCE_EXHAUSTED to the client and have the client use a service config to retry.
Steps to reproduce:

Installed grpcio and grpcio-tools with version 1.34.0
Ran the server from the file attached
Ran the client from the file attached

Server:
from concurrent import futures
import logging

import grpc

protos, services = grpc.protos_and_services("test.proto")

class Handler(services.HandlerServicer):

    def Call(self, request, context):
        context.abort(code=grpc.StatusCode.RESOURCE_EXHAUSTED,
                          details="Server is busy, come back soon")

def serve():
    server = grpc.server(futures.ThreadPoolExecutor(max_workers=10))
    services.add_HandlerServicer_to_server(Handler(), server)
    server.add_insecure_port('[::]:50051')
    server.start()
    server.wait_for_termination()

if __name__ == '__main__':
    logging.basicConfig()
    serve()

Client:
import json

import grpc

protos, services = grpc.protos_and_services("test.proto")

SERVICE_CONFIG = json.dumps(
    {
        "methodConfig": [
            {
                "name": [
                    {"service": "test.Handler"},
                ],
                "retryPolicy": {
                    "maxAttempts": 5,
                    "initialBackoff": "0.3s",
                    "maxBackoff": "10s",
                    "backoffMultiplier": 3,
                    "retryableStatusCodes": ["UNAVAILABLE", "RESOURCE_EXHAUSTED"],
                },
            }
        ]
    }
)
options = [
    ("grpc.service_config", SERVICE_CONFIG),
]

channel = grpc.insecure_channel('localhost:50051', options=options)
stub = services.HandlerStub(channel)

for response in stub.Call(protos.Request()):
    pass

proto file:
syntax = "proto3";

package test;

service Handler {
  rpc Call  (Request) returns (stream Response) {}
}

message Request {
}

message Response {}

requirements.txt
grpcio==1.34
grpcio-tools==1.34

What did you expect to see?
Expected client to retry 4 times and then raise a RESOURCE_EXHAUSTED error
What did you see instead?
An error in an underlying library caused the call to crash and bring down client that the call was run from, not allowing python to handle the error.
With GRPC_VERBOSITY=debug, the following stack trace was generated:
D1215 18:44:02.599314007      24 ev_posix.cc:173]            Using polling engine: epollex
D1215 18:44:02.599417707      24 lb_policy_registry.cc:42]   registering LB policy factory for "grpclb"
D1215 18:44:02.599426554      24 lb_policy_registry.cc:42]   registering LB policy factory for "priority_experimental"
D1215 18:44:02.599434638      24 lb_policy_registry.cc:42]   registering LB policy factory for "weighted_target_experimental"
D1215 18:44:02.599438372      24 lb_policy_registry.cc:42]   registering LB policy factory for "pick_first"
D1215 18:44:02.599441453      24 lb_policy_registry.cc:42]   registering LB policy factory for "round_robin"
D1215 18:44:02.599445377      24 dns_resolver_ares.cc:507]   Using ares dns resolver
D1215 18:44:02.599460957      24 lb_policy_registry.cc:42]   registering LB policy factory for "cds_experimental"
D1215 18:44:02.599468822      24 lb_policy_registry.cc:42]   registering LB policy factory for "eds_experimental"
D1215 18:44:02.599503917      24 lb_policy_registry.cc:42]   registering LB policy factory for "eds_drop_experimental"
D1215 18:44:02.599507699      24 lb_policy_registry.cc:42]   registering LB policy factory for "xds_cluster_manager_experimental"
I1215 18:44:02.610086424      24 socket_utils_common_posix.cc:427] Disabling AF_INET6 sockets because ::1 is not available.
I1215 18:44:02.611445714      28 subchannel.cc:1126]         New connected subchannel at 0x7f2364002000 for subchannel 0x55812330b950
E1215 18:44:02.612751183      28 sync.cc:105]                assertion failed: prior > 0

Anything else we should know about your project / environment?

I am also seeing this error using the Ruby client. It seems like the only option is to avoid retry policies for streaming endpoints, because if you receive a retryable error like this before any messages have been received, your entire application process will be aborted.
Probably worth noting that if you receive an error AFTER the client has received any streaming messages, it correctly cancels the stream and throws the GRPC status error without retrying.

When setting the options, one also needs to add:
('grpc.enable_retries', True),

It's essentially this assert which is being hit, right? https://github.com/grpc/grpc/blob/master/src/core/lib/gpr/sync.cc#L105

@yashykt are you sure the Python label is correct? If the failure is also happening in other client bindings and happens because of an assert in core, isn't this more probably a core issue?


Hyundai CAN-FD: lower steering pressed threshold to rest of fleet

Requires #26914

I'm just worried the driver torque is just scaled differently on these cars, so not sure if it makes sense to use the same threshold


undocumented endpoint '/_apis/distributedtask/pools/{pool id}/jobrequests'

The endpoint '/_apis/distributedtask/pools/{pool id}/jobrequests' is not documented.  In our case we found it through github articles such as this.
We can use this endpoint to get all of the jobs performed for a given pool, however I'd like to know what other query string parameters this endpoint supports.
I verified this endpoint works and returns results as far back as API-version 6 (I didn't test lower than that)
Please update the documentation to detail this endpoint as well as what query parameters it supports

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e0d06445-c30c-0b53-a3a4-e411299340c3
Version Independent ID: b13fc247-f300-d26a-76d7-72592317ea0f
Content: Pools - REST API (Azure DevOps Task Agent)
Content Source: docs-ref-autogen/6.0/distributedTask/Pools.yml
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

Hello, this endpoint was meant to be for internal use only, that is why it is not publicly documented. We don't plan to make it public so there won't be documentation for this endpoint.

Hello, this endpoint was meant to be for internal use only, that is why it is not publicly documented. We don't plan to make it public so there won't be documentation for this endpoint.

I see, thanks for the reply.  Do you know where would be the best place to voice my opinion that this endpoint should be public?  We have a business need to see recent jobs so we can:

monitor how many jobs are currently queued for a pool.
monitor job run times for a pool.

Seems like others have similar needs given this endpoint making its rounds on SO and other tech forums.

There is the Developer Community portal for submitting feedback and feature requests.
I will ping the team which owns this endpoint with your feedback so they are aware.

Are there any plans to create a public endpoint to monitor this?

monitor how many jobs are currently queued for a pool.
monitor job run times for a pool.
monitor failed jobs

Many people use KEDA to run Azure Devops agents on Kubernetes,
and KEDA depends on this endpoint: https://keda.sh/docs/2.13/scalers/azure-pipelines/
Please reconsider making it public, for documentation, and also to ensure it stays stable so integrations like these don't break if there are backwards-incompatible changes


realign the hexgrid and the hex centers

before

after

I merged this but I think this is actually the wrong fix and the bug is in the src/transforms/hexbin.js? https://github.com/observablehq/plot/pull/801#discussion_r883958278 Anyway, I’m investigating, but please hold off on any further contributions to the reinitialize branch unless absolutely necessary as I am trying to review it and merge it.

Confirmed that this is the wrong fix and dropped from the parent branch. I’ll work on fixing the hbin implementation that was broken when it was inlined now.


.net Core 5 support

Hi,
I was just wandering if there is any plans to support .net core version 5 ?
Thanks in advance!

Hi @Mrgove10 yes, the library is already targeted to also support .NET 5: https://github.com/jchristn/SimpleTcp/blob/master/SimpleTcp/SimpleTcp.csproj


Add command (Recomended)

I have an idea that there is a /p setowner command for the operators so when stealing plots the operators return them
Being able to give plots as an operator does not matter if you do not own the plot

/p setowner already exists...


NTR: Observed work characteristics

For new term requests, please provide the following information:
Term Label [required]
Observed work characteristics
Synonyms [optional]
Definition [required except for organism name]
Category to capture variables broadly describing what type of work is being done at the health center and the frequency. Based on observation of birth attendants (healthcare workers) by trained study personnel
Suggested Parent Term [required]
Please look in the ontology hierarchy in a browser such as OLS or choose one from following list:

[ ] Material (independent of other entities and can be maintained through time, such as person, cell, sample)
[ ] Process (has temporal proper parts and for some time depends on some material entity, such as life cycle, cell division, heart beating, sleeping)
[ ] Information (generically dependent on some artifact and stands in relation of aboutness to some entity, such as data, identifier, document)
[ ] Characteristic/Quality (inheres in or is borne by other entities, such as height, color, disease)

Examples [optional]
Contributor [optional]
If you would like to be a contributor of the term or anyone you think that contributes to the term, such as label, definition, please provide the name and ORCID ID.
Requester [optional]
Sheena/ClinEpiDB

@johnwjudkins, in addition to frequency, this category will also include variables identifying which planned processes were observed

@SheenaTomko OK, I'll broaden the definition.
Definition: Information about a planned process, in which a birth attendant participates, that is observed by an investigation agent.

Thanks, looks good @johnwjudkins

Looks good to me.


SPG as a workflow runner

Is your feature request related to a problem? Please describe.
The current functions that protocols support are low level functions that do one thing at a time. However, for end users, that means sometimes it would require them to make multiple transactions to achieve one task. One example is IPA registration: In order to register an IP Asset as an artist, they have to mint a NFT first and then register it as an IP in a separate transaction. It gets even more complicated when the artist wants to attach a license term to the IPA. This can get up to 5 transactions for a simple IP registration use case.
Describe the solution you'd like
Story Protocol Gateway (SPG) as a periphery contract can serve as a layer on top of the core protocol to combine multiple actions together to a workflow. Some initial requirements are:

For "NFT mint," are we minting from an external contract or an NFT contract that we provide (another requirement)?
There's an issue with minting from an external contract: When we mint, we can't get the new tokenId because of how ERC721 is designed, so we either:

Break it into two transactions, mint token and then the rest of actions
Pass in expected tokenId from minting as a parameter (requires simulation)

Capture our offline discussion here:

We don't support letting users to pass in an external nft collection. Users will have to mint themselves, get the token id and then call SPG.
For web2 partners, SPG can create new nft collections for them and combine mint/register for them.

One more important workflow:
registerAndMakeDerivative

If users have a nft, they can pass in their nft to register and make derivative
If users don't have a nft, they either need to create a new collection with SPG, or pass in the collection id that they created through SPG, in order to continue the workflow


Issue/#61 Implement-Basic-Modal-Functionality

[ ] The pull request is complete according to the following criteria:

[x] Acceptance criteria have been met
[ ] The documentation is kept up-to-date
[x] Comprehensive tests (if applicable) have been generated and all pass.
[x] The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
[x] Commits have been squashed (or will be on merge).
[x] The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
[ ] The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
[x] The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
[x] At least two reviewers assigned. One of which must be the assigner of the issue.
[ ] If there are merge conflicts, run git rebase as opposed to git merge with master.

Resolves se701g2/Doto#61

Nit: This branch should be coming from your own fork not a branch on the upstream


Inconsistent English football club team names

Manchester United FC is used in 2000, 2001, 2002, 2003, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018
Manchester United is used in  2004, 2005, 2006, 2007, 2008, 2009, 2019, 2020
and there are many more like West Ham United FC - West Ham

Thanks for reporting the inconsistencies in the name. The update machinery has now full support for canonical names - you can find the official canonical name  in the /clubs repos, for england - see https://github.com/openfootball/clubs/blob/master/europe/england/eng.clubs.txt.
If you read the datasets into the database you "automagically" get the canonical name  - not sure if that answers your question or what you have in mind?


Create i18n/pt-br.toml and fix typo in i18n/es.toml

Create the internationalization file for the Brazilian Portuguese language and correct a grammatical error in the Spanish language file.
Thank's for this wonderful theme, bro!

Thanks!


Newrelic php 8.2 and 8.3

name: 🎉 New Feature
about: Add newrelic.so also for php8.2 and 8.3
labels: enhancement

Description
This PR adds newrelic for php 8.2 and php 8.3 like I added it for php 8.1 2 years ago at https://github.com/shivammathur/homebrew-extensions/pull/2433 :)

I will need to double check if the patches are still missing. I will remove the draft status afterwards.

:beers: @BrewTestBot has triggered a merge.


Dashboard Chart Views

Add time logic to dashboard endpoint so that different views can be seen on the chart dashboard.

Completed as of 96b8ecf64e979e640d32abf445526142113c263a.


#217 Fix parse errors on strings containing single quotes

As reported in #217, fkYAML had a bug in parsing strings containing single quotes.
So this PR has fixed the bug and modified test cases to ensure such strings can be parsed without an error.

coverage: 100.0%. remained the same
when pulling 13b991bdff2f5df87aa0c9db9e9f83d33d01371b on bugfix/217_fix_parse_single_quotes_in_strings
into 0c796afda680bdd59c2adf96af16a7de00a720d3 on develop.


Update sbt-dotenv to 2.1.219

Updates au.com.onegeek:sbt-dotenv from 2.1.206 to 2.1.219.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "au.com.onegeek", artifactId = "sbt-dotenv" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #63.


why my skywalking show trace so simple

when i use skywalking to trace my services，the UI like this picture ：

but i want the trace that i can know “checkUserInfo” do what ,like connect mysql.
why my trace depth is so simple? i use it error?

@xingzt the "Mysql/JDBI/PreparedStatement…" represents that your service connects to MySQL, the fact that it's red represents that there's error when executing SQL, you can click it to show the detail, such as error message and the SQL it tries to execute


Puppet Module Build Failing

Just wanted to open up an issue saying that this puppet module build is failing according to:
https://forge.puppetlabs.com/elasticsearch/elasticsearch

Hi, thank you for informing me. I am aware of that yeah. I still need to remove the travis-ci build badge since i don't use it any more.
We are using our own CI infrastructure at http://build-eu-00.elastic.co/view/Puppet/view/Elasticsearch New/


Replace sSMTP with msmtp

Hello,
This is just because sSMTP is now unmaintained. Also, it seems that msmtp supports more ciphers and protocols.
In addition to replacing sSMTP with msmtp, this pull request renames all SSMTP_* settings as SMTP_* and removes the SSMTP_HOSTNAME setting. It also creates two distinct SMTP_TLS and SMTP_STARTTLS settings.
I only tested this with no authentication (without SMTP_USER and SMTP_PASS), but it should work fine with authentication, too.

Hello,
could you please copy the README into individual netdata versioned folders, so we may keep some docs for previous versions (ie, just copy the old one into the last v1.10), link them in the main readme, and add a changelog section documenting this change. I'm all for merging this in, but since it changes behavior, there's some bookkeeping to do around this. And there's some reference for sSMTP left in the readme.
Thanks

Okay, I think I've done all of it -- tell me if I've forgotten anything. Thanks! :smiley:

Sorry, I've missed the merge window for some reason. Can you rebase please?

Sure, done

Thank you very much! If you have some other suggestions, feel free to open an issue, a PR, or if you can give a hand, you can tackle a multi stage dockerfile for alpine? ;)


Selenoid fails to resize browser(Chrome) window horizontally only

HI All, I am using Selenoid latest version, when I am running my automation script to resize the browser window only from horizontally then, it compresses from both ways horizontally and vertically and my script is failing.
And when I am running locally without using selenoid, it works fine. please guide on this.
Here is sample code:
//Change browser size in percentage
// E.g. If you want a 70 percentage browser height then put .7 in heightInPercentage parameter
public void changeBrowserSizeInPercentage(WebDriver driver, double heightInPercentage, double widthInPercentage){
Dimension initial_size = driver.manage().window().getSize();
int height = initial_size.getHeight();
int width = initial_size.getWidth();
int heightAfterPer =(int) (height*(heightInPercentage));
int widthAfterPer = (int) (width*(widthInPercentage));
//Resize current window to the set dimension
driver.manage().window().setSize(new Dimension(heightAfterPer,widthAfterPer));

@AmitKumar83i need Selenoid and browser versions.

@AmitKumar83i need Selenoid and browser versions.

/aerokube/selenoid:1.10.0 and Chrome Version 87.0.4280.88 (Official Build) (64-bit)

@AmitKumar83i is it possible to output actual window size and new window size being set? Currently seems to be code issue.

@vania-pooh
Values supplied: changeBrowserSizeInPercentage(getSettings().getDriverInstance(),1,    .65);
Here is without using Selenoid
Actual Size(1552, 840)
After changing dimension(842, 883)
Using Selenoid
Actual Size(1920, 1080)
After changing dimension(1080, 1248)

@AmitKumar83i you are setting values incorrectly:
driver.manage().window().setSize(new Dimension(heightAfterPer,widthAfterPer));

whereas should be:
driver.manage().window().setSize(new Dimension(widthAfterPer, heightAfterPer));

Thanks @vania-pooh , it is now resizing properly.


Add git-branch on trops.cfg

Right now, the default trops branch is trops_envname, but it should be an option that a user can set.

The git-branch should be set at the initial setup like this.
trops env init -b trops/install_modules


Pushing initial work for done in Query plan feature to main

This feature is hidden by a feature flag and is therefore hidden.

Where is this feature flag? I don't see a setting or anything for this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 145 (6.21%)  changed or added relevant lines in 6 files are covered.
521 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.1%) to 41.446%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/queryplan2/browser/actions/propertiesAction.ts
3
5
60.0%

src/sql/workbench/services/query/common/queryRunner.ts
2
4
50.0%

src/sql/workbench/services/query/common/queryModelService.ts
0
3
0.0%

src/sql/workbench/services/query/common/queryManagement.ts
0
4
0.0%

src/sql/workbench/contrib/query/browser/queryResultsView.ts
0
20
0.0%

src/sql/workbench/contrib/queryplan2/browser/queryPlan.ts
4
109
3.67%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/contrib/query/browser/queryResultsView.ts
1
0.23%

src/sql/workbench/services/notebook/browser/models/cellEdit.ts
10
68.33%

src/sql/workbench/api/common/sqlExtHostTypes.ts
32
92.4%

src/sql/workbench/api/common/vscodeExecuteProvider.ts
36
1.77%

src/sql/workbench/api/common/extHostNotebook.ts
51
39.32%

src/sql/workbench/api/common/adsNotebookController.ts
70
0.76%

src/sql/workbench/services/notebook/browser/models/cell.ts
91
70.1%

extensions/sql-database-projects/src/controllers/projectController.ts
95
48.38%

src/sql/workbench/services/notebook/browser/models/notebookModel.ts
135
51.39%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
27456

Relevant Lines:
60111

💛  - Coveralls

@aasimkhan30 @kburtram , I noticed the icons are not vector images, is there a reason not to do so?


Why DM'S appear like this?

Hi
Why DM'S appear like this?

@bitcoinuser it was related to nip7 integration. Fixed a few commits ago.

Working now


485507D4 - Fuzion Frenzy 2

Marketplace

Tested on https://github.com/xenia-canary/xenia-canary/commit/93a7e6ec8f9b0863a0cefbe4c5539a0af6e033d0 (new_dashboard_run)
Issues:
Immediate guest crash, game tries calling into the ELEA.dll next to default.xex, but all those calls fail as Xenia doesn't support import modules right now.
Something like https://github.com/xenia-project/xenia/pull/1354 would probably help get it working (and according to that issue page, actually did make it work at one point), but that PR needs a lot more work done on it though, maybe will look into it again soon.
Log:
xenia.zip
Labels:
kernel-unimplemented-feature
state-crash-guest

Tested on: https://github.com/xenia-project/xenia/commit/7003e54e510fa2169a9434cdb8d608bff7f7be1e
xenia.zip
No changes since last report. Doesn't crash anymore, but gets stuck on the same thing.