[Bug]:  No invitation mail is sent

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When adding a (new) user to a role or group, no invitation mail is sent.
Steps To Reproduce

Go to Access Control => USERS
Klick 'ADD USERS'
Invite user to Custom Role/Group

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Self Hosted – ee 1.9.12

@UMinky do you have email configured on your self hosted instance?

@Nikhil-Nandagopal @UMinky  - Notification emails are currently not supported for an invitation through custom roles. This is currently in development, the first invite to an instance through custom roles will receive an invitation email. Tracked here #19462

Moin Nikhil,
yes, we have. eMails are sent when inviting to a WorkSpace. We use SSL / TLS Protected Connection.
Es grüßt Sie
Udo Minkwitz, Data & Digital Transformation (H-HDI.IT-DD.H)
Von: Nikhil Nandagopal @.>
Gesendet: Mittwoch, 24. Mai 2023 12:15
An: appsmithorg/appsmith @.>
Cc: Minkwitz, Udo @.>; Mention @.>
Betreff: Newsletter_: Re: [appsmithorg/appsmith] [Bug]: No invitation mail is sent (Issue #23662)
@UMinkyhttps://github.com/UMinky do you have email configured on your self hosted instance?
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/23662#issuecomment-1560840614, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVADUKJ4MDZ35ZVFCME6F23XHXNRDANCNFSM6AAAAAAYMC3MSU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Moin Akhil,
Also, the first invitation to a Custom Rolla/Group does NOT trigger an invitation email.
thanks for feature #19462, I would have liked that too :-)
Es grüßt Sie
Udo Minkwitz, Data & Digital Transformation (H-HDI.IT-DD.H)
Von: Akhil Varma @.>
Gesendet: Mittwoch, 24. Mai 2023 14:47
An: appsmithorg/appsmith @.>
Cc: Minkwitz, Udo @.>; Mention @.>
Betreff: Newsletter_: Re: [appsmithorg/appsmith] [Bug]: No invitation mail is sent (Issue #23662)
@Nikhil-Nandagopalhttps://github.com/Nikhil-Nandagopal @UMinkyhttps://github.com/UMinky - Notification emails are currently not supported for an invitation through custom roles. This is currently in development, the first invite to an instance through custom roles will receive an invitation email. Tracked here #19462https://github.com/appsmithorg/appsmith/issues/19462
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/23662#issuecomment-1561078746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVADUKN66CJ5LRCAMYQIPNLXHX7MHANCNFSM6AAAAAAYMC3MSU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@UMinky  - Yes, It currently does NOT trigger. We're adding that email in the new feature.

Moin Akhil,
Also, the first invitation to a Custom Rolla/Group does NOT trigger an invitation email.
thanks for feature #19462, I would have liked that too :-)
Es grüßt Sie
Udo Minkwitz, Data & Digital Transformation (H-HDI.IT-DD.H)
Von: Akhil Varma<EMAIL_ADDRESS>Gesendet: Mittwoch, 24. Mai 2023 14:47
An: appsmithorg/appsmith<EMAIL_ADDRESS>Cc: Minkwitz, Udo<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Newsletter_: Re: [appsmithorg/appsmith] [Bug]: No invitation mail is sent (Issue #23662)
@Nikhil-Nandagopalhttps://github.com/Nikhil-Nandagopal @UMinkyhttps://github.com/UMinky - Notification emails are currently not supported for an invitation through custom roles. This is currently in development, the first invite to an instance through custom roles will receive an invitation email. Tracked here #19462https://github.com/appsmithorg/appsmith/issues/19462
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/23662#issuecomment-1561078746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVADUKN66CJ5LRCAMYQIPNLXHX7MHANCNFSM6AAAAAAYMC3MSU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Moin Nikhil,
Can you reopen the issue #23662.
Also, the first invitation to a Custom Rolla/Group does not trigger an invitation email.Es grüßt Sie
Udo Minkwitz, Data & Digital Transformation (H-HDI.IT-DD.H)
Von: Nikhil Nandagopal<EMAIL_ADDRESS>Gesendet: Mittwoch, 24. Mai 2023 15:11
An: appsmithorg/appsmith @.>
Cc: Minkwitz, Udo @.>; Mention @.***>
Betreff: Newsletter_: Re: [appsmithorg/appsmith] [Bug]: No invitation mail is sent (Issue #23662)
Closed #23662https://github.com/appsmithorg/appsmith/issues/23662 as completed.
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/23662#event-9327637868, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVADUKI5MGS2YGBDI4G6XK3XHYCG3ANCNFSM6AAAAAAYMC3MSU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Moin Akhil,
Ok, thanks for the info. Does it have a feature request for this that I can follow?
Es grüßt Sie
Udo Minkwitz, Data & Digital Transformation (H-HDI.IT-DD.H)
Von: Akhil Varma @.>
Gesendet: Donnerstag, 25. Mai 2023 11:35
An: appsmithorg/appsmith @.>
Cc: Minkwitz, Udo @.>; Mention @.>
Betreff: Newsletter_: Re: [appsmithorg/appsmith] [Bug]: No invitation mail is sent (Issue #23662)
@UMinkyhttps://github.com/UMinky - Yes, It currently does NOT trigger. We're adding that email in the new feature.
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/23662#issuecomment-1562592735, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVADUKIM3Y47I3KO5WKWJALXH4RUXANCNFSM6AAAAAAYMC3MSU.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

#19462 is the feature request


Biome colors

Add a viewing mode in which the color of a block is determined by the biome it is in. It is very similar to Amidst but it is capable of viewing worlds in which terrain was generated across several versions.

I would also be cool to just see the biome color


Fix: Revert opcode

Fix Revert

ptal @peroket

ptal @peroket

FYI you don't need to add a comment for that, just use github "request a review" feature :-)


Configure to shutdown buildkite-agent after x number of jobs

Hi,
Wondering is there a way to configure bk agent to shutdown after x number of jobs?
Or a clever hack that you can recommend?
Our org integration tests pipeline gets increasing flaky as more jobs gets ran by the agent. We suspect its due to some orphaned subprocess not being clean up properly but in the mean time we like to just shutdown bk agent after it ran a few jobs, coupled with agent shutdown hook to kill the ec2 instance, then have the auto scaling group replace it with a new one.

Wondering is there a way to configure bk agent to shutdown after x number of jobs?
Or a clever hack that you can recommend?

There’s no out the box configuration for this, but you might have success using an agent level pre-exit hook that stops the systemd service for the buildkite-agent.
I sounds like a good fit for a healthcheck hook that would be run between jobs to determine whether the instance is healthy enough to accept more jobs. Now that we have an agent level shutdown hook, the nascent pre-bootstrap hook still a work in progress, and a sketched out heartbeat hook, this might be feasible.


ACS-54: Identity Services Testing

Updates DBP chart with latest versions of modules for ACS, ADW, APS and Activiti.
Changed version of helm chart to alfresco-content-services-4.0.3.tgz which contains ACS 6.2.1 and ADW 2.3.0 (in alfresco-digital-workspace-2.3.0.tgz)
Didn't change anything else because it is already using:

alfresco-infrastructure-5.2.0.tgz which contains Identity Service 1.2 (in alfresco-identity-service-2.0.0.tgz)
alfresco-process-services-0.2.1.tar which contains  APW 1.3.4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@aymanthefirst You mention ACS 6.2.1 but that is not released yet.
Can you please be more specific - eg. is it ACS 6.2.1-RC1 or one of the Ax releases or ... ?
That way we're ready to update again, eg. for next RC &/or final.

I'm not familiar with the versioning for ADW, e.g. alfresco-digital-workspace-2.3.0? Is that the version in development or last released, or last tested?

I'm not familiar with the versioning for ADW, e.g. alfresco-digital-workspace-2.3.0? Is that the version in development or last released, or last tested?

It is the last released helm chart

@aymanthefirst Thanks for the update and helpful detailed description (to save having to navigate the chart bundled versions).
You mention ACS 6.2.1 but that is not released yet. Can you please be more specific - eg. is it ACS 6.2.1-RC1 (or one of the Ax releases ...) ?
That way we're also ready to update again, eg. for next RC &/or final.
It doesn't say any more than appVersion: 6.2.1. See the image below

@montgolfiere 4.0.3 chart contains ACS-6.2.1-RC3

@montgolfiere 4.0.3 chart contains ACS-6.2.1-RC3

ah yes. I see it now

Thanks 👍


Feature request: the ability to turn off the error altogether

Hi there @davidtheclark ! To start, I'd like to thank you for sharing this amazing library. It's been really useful for me today.
I'm writing because I'm wondering if it would be possible to completely disable the error that this library throws when there are no focusable elements?
I can see why one may want an error when there are no focusable elements, but other times, it may be OK.
To provide some more details, my specific use case is a dropdown without any items. The docs suggest providing a fallback element, and I can see how that could work in some situations. However, I'm using this with React, and I don't want to make any assumptions about the existence of a ref.
This is for a production app at work, and I'd feel much more confident in my code if I had the guarantee that the error was disabled altogether.
What do you think, @davidtheclark ? Is there any way for the error to be disabled? I'd be happy to open a PR if you think that it's technically possible, and also worth adding.
Thanks for reading, and thank you again for creating such a great library!
--
Update: My current solution is to use fallbackFocus: document.body everywhere. It works inasmuch as it prevents explosions, but it isn't particularly expressive, and breaks the trap (tabbing still works). I think it could still be worthwhile to update the API of the library to support this in a less "hacky" feeling way :v:

@jamesplease Glad this library is useful for you!
How about adding a try-catch around the initialization? That seems to me as good as setting an option.
One question about your use case: If the dropdown is empty, where do you want focus to go?

How about adding a try-catch around the initialization? That seems to me as good as setting an option.

I'm using the React bindings, so it's not clear to me where I would add that try-catch. Would it be best if I forked that library and added the try-catch myself?

One question about your use case: If the dropdown is empty, where do you want focus to go?

Good question! Because there are no elements that the user can activate, I am thinking that it follows that nothing be focused, and for tabbing to do nothing.
To close the dropdown, users can either hit Escape or Enter on their keyboard, or click outside of it. Then, after it is closed, I am manually returning the focus to the previously-focused item after the FocusTrap'd element is closed.
Maybe that's a little odd, though. Perhaps I'll propose a change to the UX where the dropdown is disabled when there are no items, and the  explanation for the disabled state is provided in a tooltip on hover. For now, that explanation for the empty list is provided when the dropdown opens up.

Because there are no elements that the user can activate, I am thinking that it follows that nothing be focused, and for tabbing to do nothing.

I'm not sure that nothing be focused is a good user experience to aim for. That leaves the keyboard user stranded in outer space, right? So I guess I'm still not convinced that it's a good idea to create a focus trap without a focusable element — still think that's probably an error that should be recognized as such.

I'm not sure that nothing be focused is a good user experience to aim for.

I agree that it's questionable 🙂

That leaves the keyboard user stranded in outer space, right?

In my specific case, it doesn't. From my earlier comment:
"To close the dropdown, users can either hit Escape or Enter on their keyboard"

still think that's probably an error that should be recognized as such.

Perhaps. My bar of throwing errors is pretty high, and even higher for React components, where the developer effectively loses all control over being able to try/catch it altogether.

Perhaps the UX to go with here

Yeah, I think that this error represents an accessibility problem to be addressed rather than avoided. Every time this request has come up so far that seems to have been the case.

Whats interesting to me is that native selects behave pretty similarly to the UX I first described in this issue.
To reproduce, create a native select without any options, and open it. Click Tab and observe that it is trapped, but it behaves as if nothing is selected (although it is likely the select itself that is focused).
Anyway, it is pretty clear to me that unmounting a React app (or a section of a React app) due to focus is never a good idea, so if you’re not open to any PRs to make adjustments I’ll go ahead and create a fork.
Thanks for the good discussion @davidtheclark !


certify custom domain doesn't take effect until update is called

Context

Not really a bug, just something that took a lot of time for me to figure out -- I set up the ACM certificate with my custom domain and updated the zappa-settings.json with the ARN, and called zappa certify with success, but the cloudfront URL (which the custom domain was CNAMEd to) didn't work until I updated the stage.
Expected Behavior

Would maybe be a good idea to have a little
Please call "zappa update" to see your custom URL take effect

prompt at the end of the zappa certify so people don't waste as much time as I did!
Actual Behavior

I waste a few hours trying to figure out what Cloudfront is and why the URL wasn't working :P
Possible Fix

(see expected behavior)
Your Environment

Zappa version used: 0.47.1
Operating System and Python version: OSX El Capitan, with Python 3.6

(PS, thanks for the work you guys do on this project, it's pretty amazing imo)

Cannot reproduce this one myself. I did an undeploy of an existing environment, a deploy and a certify and after an hour or so it was just fine.
I've been there though. The whole certify step is an exercise in frustration unless you deploy and let zappa do its thing and leave the settings alone.


Notice about stats config

The stats config does not have any effect in the Node.JS API
I added a warning on configuration/stats
And also mentioned it on the Node.JS API page

Hmm, it's not entirely correct that the stats options don't have any effect. It is correct that using e.g. stats: { chunks: false } in your webpack config has no effect, but the stats options are still relevant if you want to display stats, e.g. like this:
compiler.watch({...}, function(err, stats) {
    console.log(stats.toString({ chunks: false }));
});

Yeah true. What I actually meant is that if this options is supplied to the webpack constructor, it won't print anything and calling stats.to{String/Json} won't respect these.

Can you rebase against master? The development happens against it now (faster deployments).

Can you rebase against master? The development happens against it now (faster deployments).

Thanks.


feat: add verification functions

Signed-off-by: Asra Ali<EMAIL_ADDRESS>
Summary

Adds verification functions for inclusion proof, root hash, consistency, and full entry

Release Note

Documentation

Fixes https://github.com/sigstore/rekor/issues/891
Fixes https://github.com/sigstore/rekor/issues/789
Creating follow-up issue for the TUF usage. Contingent on https://github.com/sigstore/sigstore/pull/500/ which I'll go back to today.

Hey @asraa is this ready for review?

Will you be adding tests?

I do have some local tests that I haven't committed yet: the trillian/merkle libs don't expose an easy way to generate proofs, so I'd have to hard-code some examples.

@haydentherapper added tests, didn't test things that were trivial and already tested in other APIs. feel free to add more

@priyawadhwa @bobcallaway  sorry, could I get one more look on this?


Core v0.11

I ran the tests locally and I'm getting toilet overflow in the tee tests every time. This definitely needs to be resolved before we can merge


[error]... directory X is not watched

I don't know why this happens, but if you get something like this:
[error] unable to resolve root /Users/blah/project: directory /Users/blah/project is not watched

Running this should fix it:
watchman watch /Users/blah/project

I'll try finding an actual solution when I get the time.

First of all - Amazing work!
A better solution is adding this command to wml start:
watchman watch-del-all
This is caused by the react-native packager starting the watchman, but watchman is not being stopped even after closing the packager process, which causes a conflict between the old watched folder and the new wml-watched folder.
If you want I can make a PR
another option is to specifically remove the watched folder (instead of all). But I like the all better just in case.

OK apparently this only sometimes works -_-

watchman watch-del-all

Not work for me

I don't know why this happens, but if you get something like this:
[error] unable to resolve root /Users/blah/project: directory /Users/blah/project is not watched

Running this should fix it:
watchman watch /Users/blah/project

I'll try finding an actual solution when I get the time.

Not work for me
         var error = new Error(obj.error);
                      ^
Error: watchman::RootResolveError: failed to resolve root: unable to resolve roo


Update program state column length

Purpose

The purpose of this PR is to fix #253
Goals

Increase the program state column length size to 25 characters
Approach

Changed the program state column length size to 25 characters
Screenshots

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Piumal1999, please review the code and let me know if there are any changes to be done :)


[SP-1842][PDI-13734] added the 'changed' flag setting after 'Clusterings' dialog

picked from https://github.com/pentaho/pentaho-kettle/pull/1273
@mattyb149 @mattcasters please review and merge

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


Add Rule sets for Rune creation

The goal of this PR is to provide a system that makes it easy and secure to construct runes with certain restrictions. We provide rule sets for common restrictions and combinations of those.
Example from a user perspective:
A user wants to create and hand out a rune to a bookkeeping application (we all have to do taxes eventually):
The application should not be allowed to move funds, neither off-chain nor on-chain but shall be able to read information from the node. A coarse rule set that is easy to understand (or at least human readable) and fulfills the task would be a readonly set that can be used to construct a rune that restricts the owner to read methods.
Example from an application perspective (pairing-protocol)
A Podcast application uses greenlight without a distinct singer. The application wants to be authorized for a direct debit of max 1000 sat per week
During the pairing-process the application would request a rune that is restricted to pay max amt sat per delta_time via the rule rate(amt, delta_time) that the user can then confirm or reject.
Tasks:

[x] Add rune factory
[x] Add exemplary set of rules

[x] readonly
[x] pay
[x] disjunct set

[x] Check runes on signer
[ ] Bindings for the rules and the factory

Rules (incomplete, loose ideas):

[ ] only off-chain
[ ] only on-chain
[ ] rate limiting (amt, time, amt/time)
[ ] one-time-rune (n-times)
[ ] time-restricted (until date)

We do not have to implement every rule from the beginning but I am starting with a hand full of rule sets and recipes to ensure that our approach is modular enough.

Main tasks are done.
We still need to define an initial signer context that we check against a rune
From CLN: ("method", "rate" (needs to persist), "time", "pnum", "pnameX", "parrN", "pubkey")

Rebased on top of  for merging.

Rebased on top of main-0.2 for merging.

I like the idea but it's hard to see the changes introduced in this branch without a rebase

I think this is good to go, but it needs fixing of the tests.
@nepet please fix them up and then we'll merge this asap, it's been pending for a while now.


Add fast, persistent scratch space on a per user basis

There is often a need for a fast, persistent scratch space when working with and compiling large projects (such as Pytorch). At the moment, users can add an ephemeral scratch space per user by modifying one of the profiles in the profile section of the nebari-config.yaml (this might also require adding a fast custom storage space using the helm_extension):

Example of modified `profile`
  - display_name: Medium Instance
    description: Stable environment with 4 cpu / 16 GB ram
    kubespawner_override:
      cpu_limit: 4
      cpu_guarantee: 3
      mem_limit: 16G
      mem_guarantee: 10G
      extra_pod_config:
        volumes:
        - name: scratch-volume
          ephemeral:
            volumeClaimTemplate:
              spec:
                accessModes: [ "ReadWriteOnce" ]
                # defined in local helm chart: custom-premium-sc
                storageClassName: "premium-rwo-immediate"
                resources:
                  requests:
                    storage: 200Gi
      extra_container_config:
        - name: "scratch-volume"
          mountPath: "/scratch"

I am opening this issue to explore other possible options.

Implement the solution that is being discussed in nebari-dev/nebari#1549

This would mean realigning with Z2JH and giving each user who launches a JupyterLab server their own persistent storage volume (as detailed in this comment). The size and type of storage volume attached is something that we could allow Nebari administrators to set in their nebari-config.yaml.
Pros:

Aligns with Z2JH - folks coming from vanilla JupyterHub might be more familiar with this setup
Users don't have to worry about one user taking up all of the space in the single storage volume (which is currently a possibility).

Cons:

This would likely increase the cost of running a cluster as each user would have their own storage volume and if there are infrequent users, you would still be paying for their storage volume.

Create a special user group (with an associated server profile) that includes an scratch persistent volume.

This solution is a compromise between what we currently have and the solution proposed above (1.).
Pros:

Depending on the number of users in this new group and the size/type of storage attached, this might not be that much more of an additional cost. That said, as the number of users in this group increases and the size of storage volume increases, the potential cost savings would quickly evaporate.

Cons:

In order to limit which users can launch this specific type of server profile, we might also need to invest some development effort in making sure these profiles are visible to other users.

Set up a new server profile per user and attach whichever additional storage each of those users might need.

As far as I am aware, this solution does not require any additional development and only requires bespoke modification to the nebari-config.yaml (similar to the example of the attached ephemeral storage above).
Pros:

No Nebari development is required.

Cons:

This solution is only tenable for small groups of users (under 10). As the number of users increases, the harder it will be to manage the large list of server profiles.
Users will need to be sure to launch their own server profile otherwise they would be attached to their colleague's scratch space.

This is a good candidate for a FAQ.


Smooth Animation of sidebar

I want to add a smooth animation on sidebar i.e when we click on sidebar it should come smoothly rather than comming immediately and moreover as of now the sidebar while expanding shifts the page i will also fix that.
Please assign this issue to me under hacktober fest'23
https://github.com/gauravsinhaweb/EduSmart/assets/92094765/96d1a695-ddaa-4556-a3ce-5326b0bd0398

@Soulpurr assigned


Add error handling to oauth authorizer

If the OAuth authorizer fails for any reason (e.g. a token refresh call fails in a sovereign cloud), we have no way of diagnosing the issue.
This PR modifies the authorizer to record error messages so that we can debug this type of issue.

PR lgtm

@jake-billings did you run make generate ?

Done


Get ConsumerOptions from RabbitService Options

Removes the need for an unused Consumer in RabbitService (as ConsumerDataflow creates and manages its own). Also RabbitService has its own SerializationProvider (which is required) so may as well use it by default.

Please could you push a new version of the nuget package for this? :) Should be only RabbitMQ.Dataflows - no others needed.

Done with a small tweak and some additional method comments.

Good shout about allowing a null serialization provider, like you say a very niche case but fair enough as an option.


logging: configurable function name prefix

Added option to pick which severity levels gets function prefix. Options goes from least severe to the bottom (dbg only default, dbg+inf, dbg+inf+wrn, all, none).
@jukkar @jhedberg  I've also modified net and ble log wrappers. I assume they were needed for that missing funcitonality.

@nordic-krch : Commit message:

Exteneded logger configuration

Codecov Report

Merging #11208 into master will decrease coverage by 1.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11208      +/-   ##
==========================================
- Coverage   53.11%   52.06%   -1.06%
==========================================
  Files         218      206      -12
  Lines       26871    25094    -1777
  Branches     5952     5604     -348
==========================================
- Hits        14273    13064    -1209
+ Misses      10163     9748     -415
+ Partials     2435     2282     -153

Impacted Files
Coverage Δ

include/net/net_core.h
100% <ø> (ø)
:arrow_up:

include/logging/log_core.h
100% <ø> (ø)
:arrow_up:

subsys/bluetooth/common/log.h
100% <ø> (ø)
:arrow_up:

subsys/logging/log_output.c
44.66% <ø> (-27.67%)
:arrow_down:

subsys/net/lib/dns/dns_pack.h
0% <0%> (-90.48%)
:arrow_down:

subsys/net/lib/http/http_parser_url.c
1.71% <0%> (-70.86%)
:arrow_down:

subsys/net/lib/sockets/sockets.c
0% <0%> (-38.86%)
:arrow_down:

subsys/logging/log_core.c
42.07% <0%> (-29.86%)
:arrow_down:

subsys/net/lib/sockets/sockets_internal.h
0% <0%> (-28.58%)
:arrow_down:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148d515...89bc535. Read the comment docs.

I'd rather have "module prefix" optional.

Note that if one wants to process the output file using a grep or similar text processing tool, then it is very useful if the module is there. But of course the module name could be made optional with suitable options if one does not really need them.
Personally I am fine with current logging output, except that I am missing the thread id in debug messages but I had that added in NET_xxx() macros.

@jhedberg @dbkinder ping
Ping to anyone else that could review.

@nordic-krch: This now needs a rebase.
And ping to @dbkinder regarding doc changes.

@nordic-krch, So one of the issue with this PR is that you change the same lines in same file (the rst doc specifically) in 2 different commits of this PR. Ideally, this should be avoided and the final change should appear just once in one of the commits.

but I'd encourage to move all doc changes to the first commit, to avoid polluting git history with interim changes.

Doc changes where accidentally added to the last commit - fixed.

@carlescufi @nashif rebased and ready for merge.


TEI not working on gaudi GPU

the repo https://github.com/huggingface/tei-gaudi
does not work, I see the documents only show CPU support, but I would like a feature request to enable the GPU parts, so that I can integrate it into microsoft graphrag.

Which HW you're trying to use?   Gaudi is not a GPU, but AI accelerator...

Im using a Gaudi2 system with 8 accelerators (i reflexively used the term GPU)

can you try the code in this sample to see if it works for you? https://github.com/HabanaAI/Gaudi-tutorials/blob/main/PyTorch/RAG_Application/RAG-on-Intel-Gaudi.ipynb

yes, i have already done so, that has the faulty repository
!git clone https://github.com/huggingface/tei-gaudi
On Mon, Jul 8, 2024 at 4:21 PM Eduardo Alvarez @.***>
wrote:

can you try the code in this sample to see if it works for you?
https://github.com/HabanaAI/Gaudi-tutorials/blob/main/PyTorch/RAG_Application/RAG-on-Intel-Gaudi.ipynb
—
Reply to this email directly, view it on GitHub
https://github.com/opea-project/GenAIComps/issues/281#issuecomment-2215510072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZ7LERBPV6KYASDVKRAMWTZLMNGPAVCNFSM6AAAAABKQBPSECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJVGUYTAMBXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

the repo https://github.com/huggingface/tei-gaudi
does not work, I see the documents only show CPU support, but I would like a feature request to enable the GPU parts, so that I can integrate it into microsoft graphrag.

Could you explain more what doesn't work for you in  https://github.com/huggingface/tei-gaudi?
Once you launch the local tei-gaudi service, do you get correct output from your curl request?

I have seen that the repository has been updated since i posted this ticket, and it is now working and stable with the migration from v1.2.2 to v1.4.0 see e.g. https://github.com/huggingface/tei-gaudi/commit/3db17966712cd17ef48b0e09e1778523239106da


Changed the Comment Type

Please change the comment format using double slash, its give better perfomance

ok!


AssertionError: block_width must be between 2 and 16

Describe the bug
AssertionError: block_width must be between 2 and 16 when I run ns-train splatfacto
To Reproduce
Steps to reproduce the behavior:
# make sure you uninstall the previous gsplat and nerfstudio
pip uninstall gsplat nerfstudio

# install it from pip the LATEST commit as 27th of March 2024
pip install git+https://github.com/nerfstudio-project/gsplat.git@2d69aaf704cc7208b0d7a90794d286c49d758e70
pip install git+https://github.com/nerfstudio-project/nerfstudio.git@71de07163a9642016c9bde1d3705e3fb62babd69

ns-train splatfacto --logging.steps-per-log 200 --vis viewer+wandb --viewer.websocket-port 7007 \
    --pipeline.model.resolution-schedule 3000 \
    --pipeline.model.num-downscales 2 \
    nerfstudio-data \
    --data path/to/scene --downscale-factor 1

Expected behavior
It runs without problem in previous version (pip install nerfstudio==1.0.2 & pip install gsplat==0.1.8)
Screenshots

Additional context
Runpod Environment
Ubuntu 22.04 LTS
Torch 2.0.1+cu118
Python 3.10
RTX A6000

gsplat main branch are unstable as we are making a few API changes recently. Use the latest release version if you can. I believe @kerrj will follow up PR to adapt the API changes to nerfstudio.

This PR https://github.com/nerfstudio-project/nerfstudio/pull/3019 incorporates changes for 0.1.9

#3019 merged.


Splitting Host.Client

This PR splits Host.Client with minimal code change. Moving more pieces from windows specific to x-plat will require significant code change and should be done in the next pass.

Looks like just files moved, no logic changes?

Why RHost had to be moved to Windows?

This PR has no logic changes. Hence, there is still code such as RHost and Broker services still on windows side. I am moving stuff out to x-plat binary with code changes as we speak.

OK. 👍


Custom Elements: Using a list item in an event handler

Describe the bug
An error happens at run time when using the Mitosis's For to iterate through a list and using its items in an event handler. This occurs when generating a Custom Element/Web component.
To Reproduce
Steps to reproduce the behavior:

Use a For to iterate a list.
Add an event handler inside the For that uses the list items (e.g. onClick={(event) => onItemClick(event, item)})
Run it or check the compiled code to find the error (see screenshots). The event handler doesn't have the For context and it's items, so it produces an error.

If possible, a link to a https://mitosis.builder.io/ fiddle containing the bug:
https://mitosis.builder.io/?outputTab=webcomponents&code=import+{+useState%2C+For+}+from+"%40builder.io%2Fmitosis"%3B

export+default+function+MyComponent(props)+{
++const+state+%3D+useState({
++++list%3A+['a'%2C+'b'%2C+'c'%2C+'d']%2C

++++onItemClick(item)+{
++++++console.log(`%24{item}+was+clicked`)%3B
++++}
++})%3B

++return+(
++++<div>
++++++<For+each%3D{state.list}>
++++++++{(item)+%3D>
++++++++++<div+onClick%3D{()+%3D>+state.onItemClick(item)}>
++++++++++++{item}
++++++++++<%2Fdiv>
++++++++}
++++++<%2FFor>
++++<%2Fdiv>
++)%3B
}
Expected behavior
It should be possible to use a list item in an event handler when using a Mitosis For to iterate a list.
Screenshots
Mitosis code:

When its run and the event is fired, the custom Element produces an error like this:

The generated file has the following code to set up the event handler:

The issue is that the el object is not defined, so it's not possible to get the context and value of the item.

Thanks for raising this. I think one approach to fix it might be to change the event handlers' signatures so it's:
element => event => void

Here is the code responsible for generating all this code:
https://github.com/BuilderIO/mitosis/blob/46f609b8d6298c7cbeea73a5420f86311978c129/packages/core/src/generators/html.ts#L291-L312
Changing Lines 295-296 so they're more like:
               ? `this.${fnName} = el => (event) => {`
               : `function ${fnName} (el) { return fn(event) {`

And then changing lines 308-309:
             ;el.removeEventListener('${event}', ${fnIdentifier}(el));
             ;el.addEventListener('${event}', ${fnIdentifier}(el));

This would hopefully fix this bug 🤞🏽

this is fixed in https://github.com/BuilderIO/mitosis/commit/4671607b306e1a4403965a6feab2f84cd9f2f415


[Visual Studio Code - Project Manager] Can I always open in current window instead of just when it empty

Extension
https://www.raycast.com/MarkusLanger/vscode-project-manager
Description
when I use this command, it always opens in the current window if VSCode is already opened
Who will benefit from this feature?
people who use laptop, don't have much space to put all their projects
Anything else?
I guess there already has a way to do this, if so, just tell me
thankfully

@mefengl I don't see a parameter for the action to open the project in the current window.
https://developers.raycast.com/api-reference/user-interface/actions#action.open

maybe can achieve this by close the previous window first


Transport Implementations

There is not a clear delineation in transports and transport providers as to responsibilities (who sends the message to the peer - the transport or the provider?). Also, there are incompatibilities that make transports specific to the Router or the Client (take a look at onClose as an example).

Transport providers now use different interfaces for the client and router sides moving into 0.4.


request dependency vulnerability

The Request package through 2.88.1 for Node.js allows a bypass of SSRF mitigations via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP). NOTE: This vulnerability only affects products that are no longer supported by the maintainer.
https://nvd.nist.gov/vuln/detail/CVE-2023-28155

see: https://github.com/jsforce/jsforce/issues/1394#issuecomment-1919210853


query: Add methods to create and drop caches

This commit adds methods to:

Cache a given query
Drop the cache for a given query
Cache all supported queries
Drop all caches

D'oh, need to add yard docs. Gimme a few mins...

Also, we may be reaching a point where feature/integration specs will provide an intuitive testing interface that will provide coverage across the stack, similar to how feature tests could make most controller specs redundant.
I don't that'll cause any changes immediately, but it might be something for us to consider later on.

@helpotters Made a two big changes:

Added FactoryBot to DRY up fixture creation
Added some shared examples to DRY up the specs massively

Let me know what you think!

Thank you again for the incredible feedback and thorough review! 😄 🚀


Add GPTNeoX AutoTP support

Hi,
We found the GPTNeoX attention layer last module name is 'dense',  This module name can't be added to "gemm_list" when we open the AutoTP. So the attention layer can't be opened AutoTP correctly. Can we update the AutoTP policy for GPTNeoX model?
GPTNeoX  model: https://github.com/huggingface/transformers/blob/ad78d9597b224443e9fe65a94acc8c0bc48cd039/src/transformers/models/gpt_neox/modeling_gpt_neox.py#L114
Autotp "gemm_list" add policy:
https://github.com/microsoft/DeepSpeed/blob/1491e14e1dd5690eb7c7fd047e660348715c1e3a/deepspeed/module_inject/auto_tp.py#L101-L110

@Yejing-Lai  can you also add GPT-NeoX to supported model list in docs? https://github.com/microsoft/DeepSpeed/blob/master/docs/_tutorials/automatic-tensor-parallelism.md

@Yejing-Lai can you also add GPT-NeoX to supported model list in docs? https://github.com/microsoft/DeepSpeed/blob/master/docs/_tutorials/automatic-tensor-parallelism.md

The GPT-NeoX is already on the support list.

Got it, lets wait for @molly-smith back from holiday.   @molly-smith note GPT-NeoX was on AutoTP support list but needs this PR to work.

@Yejing-Lai can you also add GPT-NeoX to supported model list in docs? https://github.com/microsoft/DeepSpeed/blob/master/docs/_tutorials/automatic-tensor-parallelism.md

The GPT-NeoX is already on the support list.


Windows Tests via Docker

This PR includes two fixes for cmd/powershell on windows and requires https://github.com/nerdvegas/rez/pull/775 to succeed future Windows tests.
Currently relying on hub.docker.com as the github service is broken:
https://github.community/t5/GitHub-Actions/Docker-Push-to-Package-Registry-from-Windows/m-p/36393#M2560
Setup Before Merging
(as configured in the PR, feel free to change if needed)

Create a hub.docker.com account matching the github name: nerdvegas.
Create an empty repository called rez-test-win
In hub.docker.com go to Account/Security/New Access Token
Choose a name (like "Github Access Token") and copy the token
In github, repo settings create a secret DOCKERHUB_TOKEN and paste the TOKEN from docker

Once merged the Compose Windows Docker Image action should run.
The Windows Docker tests will fail at this point, but future pushes should succeed.
In future any required change to the docker image should be a separate PR as documented.
As such the regular actions will not run when only the docker image related files have been touched.
Similarly the image will not be rebuild when none of its files have been touched. Since the image is tagged with the latest revision on these files everything should always be in sync and use the correct images moving forward.
There is some ugliness in the duplication of code throughout the workflow files. GH Actions pros may find better ways to pass the environments instead of recalculating them.
Fingers crossed!

Quick note: I left cmake out of the docker image.
We could enable it for the future, it was just pretty slow to install during my countless tests.

Thanks for the feedback.
I will also enable the cmake install in the Docker image. We're not using it but it's good we have it once we work on the cmake support.

Please ignore the pushes for a while since I'm testing on this branch on my fork :-/ Sorry for the noise.

Another thing I should check: If the image building and usage is in the same workflow I could express the dependency and we would not need to separate the process into two commits. I'll check if this is possible with github actions. Essentially I would need the 'paths:' checks within a conditional of a step.

Not that this should be part of the same PR, but I can't help but think it'd be clean to go the 'multi python installed to docker image' route for the non-windows builds as well... including cmake install also. Thoughts?

History cleaned up. Verified it working. The PR is open again.


NameError: name 'video_mesh_data' is not defined

NameError: name 'video_mesh_data' is not defined
This error keeps popping up.
May I know why?

Please upgrade the plugin (the current version is 0.4.6) and try again.


🐞 Bug Report

🐞 Bug Report
Describe the bug
For this signature:
function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

this works:

however, adding a second key breaks the nested pick:

Reproduce the bug
// REPL or a link to your repository if applicable.
// A *self-contained* demonstration of the problem.

Is it possible to use TS Toolbelt in the typescript TS Playground? If so it's easy for me to replicate this.
Otherwise I can set up a branch on my package if you like.
Possible Solution
I'm not sure!
Originally posted by @mesqueeb in https://github.com/millsp/ts-toolbelt/discussions/216

It happens that I forgot to distribute O.P utilities. I took the day to rewrite all of them. Nous you can do:
import {F, O, S} from 'ts-toolbelt'

declare function pick<T extends Record<string, any>, K extends string>(
    obj: T,
    keys: F.AutoPath<T, K>[]
): O.P.Pick<T, S.Split<K, '.'>>

type O = {
    a: {
        b: O
        c: 1
    }
}
const a = pick({} as O, ['a', 'a.b', 'a.b.a.c'])


consider using sort(key=...) function

it looks quite difficult how the sorting is handled:
https://github.com/cmu-delphi/delphi-epidata/blob/d6dd046663d93e48792287a456cb7839547c4055/src/acquisition/covidcast/database.py#L330-L335
can't the key function as in .sort(key=lambda x: (x['data_source'], x['signal'], x['time_type'], x['geo_type'])) be used instead?

@melange396 does this have to do something with threads? It seems like all the thread work is done before this chunk?

yeah, this is done post-threading (because the threaded workers arent likely to retain the original ordering).  .sort(key=) would be a much less ugly way to do this.

Looking into this. Seems like something we could clear up during the v4 integration.

To top that off, this meta computations code is getting rewritten in #947, which will go into #646, which in turn should be merged in after v4. It'll look something like this when done.


YouTube embeds have issue loading.

https://forum.freecodecamp.org/t/tutorial-videos-on-fcc-dont-load/422178

I was having this issue on firefox - videos wouldn't load so I always switched to chrome if I had to see them. I disabled all my firefox security settings, reloaded the page and it works. I re-enabled all the same settings - and it still works - and when I go to any video now, it works.
Tried a few things to get them to break again, couldn't do it.


Update featured projects

Add trailofbits/osquery-extensions.
Remove airbnb/streamalert.
Update star counts and reorder.

This was discussed briefly in https://osquery.slack.com/archives/C0F29BBCL/p1621612149000900 with no objections.


All values are written back to memory even when they're unused

There's no way to mark a variable as being killed, i.e. that the value will never be read from again; this means the code generator always has to write them back to memory when the register gets flushed even if it's a waste.
The easy fix (of adding a KILL iop for doing this) is problematic because some iops flush all registers --- consider BEQ.
But annotating the iops themselves is hard because temporaries only get freed after the iop is emitted.

This is partially implemented; KILL iops are ignored for comparisons and branches. It's had a small effect on code size only, which was a bit disappointing.

I think BEQ and others can avoid full cache flush if comparison insn itself is non-destructive; I've  experimental code that uses low bit of label ID to mark label as 'safe' to branch to without flush.


Humber-contact-update

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Prison details update (e.g. slot updates)

Checklist:

[x] My commit message follows the GDS git style standards we have adopted.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the deployment repo accordingly.
[ ] I have added tests to cover my changes.

Humber prison wants their phone number updated because the social email addresses does not work.


Clean up registry.xml

It is supposed to be there. Comment added:
<!-- The following bundles are required to build the bundle in the browser,
   through the resource registry, or when using the pattern in development
   mode -->


Question

I've been playing around with your code, I was curious. You mention there is a way to control the head. Do you happen to have the command you send to do that?

Thank you that worked exactly!
-------- Original message --------From: Eric Epperson @.> Date: 8/31/22  1:12 PM  (GMT-06:00) To: EricDavidEpperson/SWGE_BB_Rpi_controller @.> Cc: grandles1212 @.>, Author @.> Subject: Re: [EricDavidEpperson/SWGE_BB_Rpi_controller] Question (Issue #1)
Hi!
If you're not a part of the Galaxy's Edge Discord server, I'd recommend joining. The following google sheets is available in the #makerspace pinned comments. It has a lot of information on various SWGE technical devices. The link should take you to the "Astromech Droid Controller" tab with lots of information including motor commands. Look under the heading "Motor Control" for examples and other information regarding controlling R (and I'd assume C) series droid heads.
https://docs.google.com/spreadsheets/d/13P_GE6tNYpGvoVUTEQvA3SQzMqpZ-SoiWaTNoJoTV9Q/edit#gid=941538687
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Making it possible to set the path and namespace for .findArray

@erkie just a temporary solution until builders are implemented, I guess!

:+1: :de:


[Feature] add auto purge on memory event

This will probably be more controversial (it shouldn't be though)  so i separated it from #1140
Inspired from
http://stackoverflow.com/a/19549090/775762
related to #538

I like this, but do we want to remove ALL objects? Is there a way to remote just everything but the most recently cached n objects?

@markrickert yeah that would be ideal, but from what i can tell NSCache is like angsty teenager and it's eviction policies are just suggestions. I'm still uncomfortable with this because SDWebImage should never be causing system memory events. I found this actually can be managed with #1140  At this point the implementer has clearly mismanaged his memory and it's already too late to be algorithmic about it.
For over a year I have been fighting a bug where a long session would run up the memory and crash/shutdown when a memory intensive action followed. I was always under the assumption that this was perfectly normal to run up this cache as the system would reclaim it when needed, i figured it was just some memory leak inside other libraries like GPUImage when in reality NSCache would drive up memory pressure and the device would send a memory warning, NSCache would ignore it, and the app would explode on a memory intensive alloc.
I hate this PR, but short of completely turning off NSCache as https://github.com/rs/SDWebImage/pull/1130 or rewriting a real LRU eviction policy, we are being terrible netizens at the moment.
A good start might be to leave a message in the README about carefully configuring SDWebImage on the context of the app and to carefully monitor memory so that maximum cost and count limit are set correctly

I agree, the right fix is to implement an LRU cache. I don't have the bandwidth to do that right know, but if someone want to send a PR, I have the feeling that a lot of people would be grateful.
In the meantime I'm gonna accept this PR as it is a good meantime tradeoff. Could you please remove the part of the PR that belongs to anothers?

closing for https://github.com/rs/SDWebImage/pull/1143


Auto update doesn't work for Ark survival ascended server.

Auto update doesn't work for Ark survival ascended server. The task in the task manager works, adds new time to check Alive, update and restart to INI file. Alive check and daily restart work, while automatic update does not function.

Why do you say it does not work ?
It did work in all my tests.

I installed the server according to the instructions, but auto-update does not work for me. That's why I say it doesn't work. The server is updated only during the daily restart. In the intervals between these restarts, updates are released, but the script does not update them. I checked - these updates have already been published.

Can you attach the logs ?

log.zip
Here are the logs between two daily restarts. Once I checked the server crash detection by closing it from the manager. Alive check worked, and in this log you can see an attempt to check the update (at that time there was no update available). In the remaining logs you can see the message “Too early for update” although 2 updates were available during this period.
This is actual shedule.ini
[Schedule]
NextAlive=11/01/2023 16:47:31
NextUpdate=11/01/2023 16:42:59
NextRestart=11/02/2023 05:00:00

I find odd that your alive check is later than your update check.
Did you modify the Global.psm1 ?

No. I edit only server profile.
global.psm1.txt
Should I try uninstalling and reinstalling the server again?

The update check should be every 15 minutes by default, yours is set to 5 like the alive and restart check.

Initially it was 15, I changed it to 5 minutes after I read your message.
After changing it to 5 minutes it became like this:
[Schedule]
NextAlive=11/01/2023 18:12:31
NextUpdate=11/01/2023 18:12:52
NextRestart=11/02/2023 05:00:00
but update still not working:
Importing Server Configuration...
Locking Process.
Running Tasks for ark_survival_ascended ...
Getting Tasks Schedule...
Checking Alive State
Server is Dead, Restarting...
Updating Tasks Schedule...
Too soon for Update check
Too soon for Restart
Verifying Server installation...
Verifying Server State...
Server is not running.
Verifying Backups...
Creating Backup.

I found a potential issue, I should be able to fix it soon, thanks for the heads up.

I was not able to reproduce the issue.
Can you go in your main.ps1 and comment out that line :

It will generate a LOT more logs.
but you'll be able to see if it at least tries to check for updates.

I commented out this line. Everything seems to be fine in the logs. Now we need to wait for the new update to check whether it will actually work or whether there will be any other errors. Or maybe it’s worth trying to manually correct the file version to an older one, where does the script check?
Verifying Dependencies...
Importing Server Configuration...
Locking Process.
Running Tasks for ark_survival_ascended ...
Getting Tasks Schedule...
Checking Alive State
Server is Alive
Updating Tasks Schedule...
Checking on steamCMD if updates are avaiable for ark_survival_ascended...
No updates are available for ark_survival_ascended
Updating Tasks Schedule...
Too soon for Restart
Unlocking Process.
No tasks ready, exiting.

I noticed another feature in the logs. If there is an IP6 connection, the script recognizes the IP6 address instead of the IP4 used for the server.
Tell me, is it normal to disable the execution of a task in the task manager in order to temporarily stop the server from starting, and then enable it again to return the server to work?

The update is definitely not working. Now there is an update, it is available - I checked it in steamcmd from another folder. These are the logs from yesterday. The script does not see the Steam update.
Where should I try to look for the error?
The server is still running since yesterday on version 25.55, although 25.61 is already available in steamcmd.
Verifying Dependencies... Importing Server Configuration... Locking Process. Running Tasks for ark_survival_ascended ... Getting Tasks Schedule... Checking Alive State Server is Alive Updating Tasks Schedule... Checking on steamCMD if updates are avaiable for ark_survival_ascended... No updates are available for ark_survival_ascended Updating Tasks Schedule... Too soon for Restart Unlocking Process. No tasks ready, exiting.

For a server I would disable IPV6 at the Network level or at least the interface level in the server.
As for the update, the log you're giving me shows that it's looking for an update.
It's just not finding one.
Looking for updates is tricky with steamcmds, I'll check that part.

Potential fix on https://github.com/patrix87/PowerShellGSM/releases/tag/3.2.2

I copied the new script files with replacement to the old folder.
Still No updates are available for ark_survival_ascended in log.
It seems to me that the version of the steamcmd client is being checked, not the server.
bootstrap_log.txt
These two files are created in the folder for a split second and then deleted.
SteamCMD_Update_ark_survival_ascended.txt
SteamCMD_Update_ark_survival_ascended_Return.txt
appinfo_log.txt

Fully Installed means that no updates are available on Steam.

In the file functions/server/Request-Update.psm1 you can make that change to keep the SteamCMD update script.

Fully Installed means that no updates are available on Steam.

But this is definitely not the case, I check the server files by launching it as a separate bat file and there are old files there. Perhaps the update downloads and checks only the manifest/version, but does not download the server update files themselves.

Fixed in https://github.com/patrix87/PowerShellGSM/releases/tag/3.2.3
It was a SteamCMD issue that was resolved in the most complicated way possible.
Thanks


Fixed potential NullPointerException in logException()

An Exception may have a null error message.

Codecov Report

Merging #844 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #844      +/-   ##
============================================
- Coverage     48.29%   48.27%   -0.02%
+ Complexity     2781     2780       -1
============================================
  Files           116      116
  Lines         27877    27877
  Branches       4651     4651
============================================
- Hits          13462    13458       -4
- Misses        12200    12203       +3
- Partials       2215     2216       +1

Flag
Coverage Δ
Complexity Δ

#JDBC42
47.78% <100%> (-0.03%)
2736 <0> (-4)

#JDBC43
48.2% <100%> (-0.03%)
2776 <0> (-3)

Impacted Files
Coverage Δ
Complexity Δ

...m/microsoft/sqlserver/jdbc/SQLServerException.java
77.44% <100%> (ø)
31 <0> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
43.95% <0%> (-3.3%)
15% <0%> (ø)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
60.99% <0%> (-0.44%)
89% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.46% <0%> (-0.31%)
253% <0%> (-3%)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
54.48% <0%> (-0.07%)
0% <0%> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
44.2% <0%> (ø)
107% <0%> (+1%)
:arrow_up:

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
52.46% <0%> (+0.12%)
262% <0%> (+1%)
:arrow_up:

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
62.28% <0%> (+0.29%)
0% <0%> (ø)
:arrow_down:

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
39% <0%> (+0.86%)
43% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5167636...bb1a159. Read the comment docs.


AIX - shell colour problem. Sometimes remaining red (should go back to the default colour)

Noticed this when we have problems with ./configure - not handling exit code correctly

all coloring was removed.


Update libary to work with angular 2.2

Update packages
Update libary to work with changes
Update tests

Thanks a lot! This is really big and great work!


TranslateModule.forRoot should not be put in SharedModule

I'm submitting a ...
[ ] bug report
[ ] support request
[ ] feature request
[x] documentation improvement

Current behavior
Create a SharedModule that loads the translations with TranslateModule.forRoot.
@NgModule({
    imports: [
        CommonModule,
        TranslateModule.forRoot({
            provide: TranslateLoader,
            useFactory: (http: Http) => new TranslateStaticLoader(http, 'app/i18n', '.json'),
            deps: [Http]
        })
    ],
    exports: [
        CommonModule,
        TranslateModule
    ]
})
export class SharedModule {

    static forRoot(): ModuleWithProviders {
        return {
            ngModule: SharedModule
        };
    }
}

Load this SharedModule inside a lazy loaded feature module and try to translate a value inside that feature module. You will notice that the keys are not being translated.
Now why is this the case? A lazy loaded feature module creates a child injector instance in which it bootstraps all the services again. We aren't at root-level anymore and shouldn't be calling TranslateModule.forRoot. This should only happen at the root (hence the name :)). More info in this topic could be found in the documentation.
From the docs:

Do not specify providers for modules that might be imported by a lazy loaded module.

Expected/desired behavior
The TranslatePipe should translate keys into values in lazy loaded feature modules.
Solution?
The SharedModule should not call TranslateModule.forRoot because this should happen at the AppModule level (at the root).
app.module.ts
@NgModule({
    imports: [
        BrowserModule,
        TranslateModule.forRoot({
            provide: TranslateLoader,
            useFactory: (http: Http) => new TranslateStaticLoader(http, 'app/common/i18n', '.json'),
            deps: [Http]
        }),
        SharedModule.forRoot()
    ],
    declarations: [
        AppComponent
    ],
    bootstrap: [AppComponent]
})
export class AppModule { }

shared.module.ts
@NgModule({
    imports: [
        CommonModule,
        TranslateModule
    ],
    exports: [
        CommonModule,
        TranslateModule
    ]
})
export class SharedModule {

    static forRoot(): ModuleWithProviders {
        return {
            ngModule: SharedModule
        };
    }
}

Please tell us about your environment:

ng2-translate version: 2.4.1
Angular version: 2.0.0-rc.5
Browser: all
Language: probably all

I think the simplest way to fix that would be to define translations as static, so that any translate service would have access to them. The problem is that it would prevent some use cases with specific translations just for one view, but is it really necessary now that you can merge translations instead of replacing all of them ?
What do you think ?

I think the best way (and the Angular 2 way) is to just change the ng2-translate documentation and make sure people initialize (TranslateModule.forRoot) the module in the AppModule. It doesn't really makes sense to call TranslateModule.forRoot in every feature module, which aren't root modules.
So making them static would (probably) work, but I believe that isn't the preferred way of working with modules.

True :)
I'll update the docs then

Any note when you'll update the docs? My app is running, but my tests are not due to "The pipe 'translate' could not be found"

Thanks for this! #helpful

I suspect this will be a common theme for module authors. Several have mentioned the "angular2 way" of doing things, but I don't see any complete suggestions of that and I just went through the this exercise with the ng2-bootstrap author(s). Initially their suggestion was to update their documentation to let everyone know they had to worry about knowing when to calll .forRoot() again but only on their lazy loaded modules since angular2 doesn't seem to give them the same singleton services, but that's poor design.
The right way to do this is to implement the .forChild method in the provided module and there determine if you have your service setup and instantiated and if not, reinitialize. Then app authors can do everything the angular2 way of calling .forRoot() in the app module and calling .forChild in the feature modules regardless of whether or not they are lazy loaded and it will "just work."

Since I didn't found any plunker working with ngx-translate librairy and I also add some difficulties to manage to make it work with LoadChildren,
I've setup a way that work pretty well for me:
I've created two SharedModules, (one for lazyLoading and one for the other part of my application)
SharedLazyModule for lazy loading content:
@NgModule({
  imports: [
    HttpModule,
    CommonModule,
    TranslateModule.**forChild**({}),
  ],
  exports: [
    CommonModule,
    TranslateModule
  ]
})
export class SharedLazyModule {}

SahredModule for App
// AoT requires an exported function for factories
export function HttpLoaderFactory(http: Http) {
   return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}

@NgModule({
    imports: [
      HttpModule,
      CommonModule,
      TranslateModule.**forRoot**({
           provide: TranslateLoader,
           useFactory: HttpLoaderFactory,
           deps: [Http],
         })
    ],
    exports: [
      CommonModule,
      TranslateModule
    ]
})
export class SharedModule {

     constructor(private translate: TranslateService) {

        translate.addLangs(["en", "fr"]);
        translate.setDefaultLang('en');

        let browserLang = translate.getBrowserLang();
        translate.use(browserLang.match(/en|fr/) ? browserLang : 'en');
    }
}

See Plunker:
https://plnkr.co/LVmIuI1Xw9vFn0IuC2jW

I was getting "Error: No provider for t" during AoT compilation and found out that was happening because I had
constructor(
   translate: TranslateService
  ) {

in my component, but in the same time pipes were working. I replaced direct injection of TranslateService with
constructor(
    protected injector: Injector
  ) {

and
ngOnInit() {
    this.injector.get(TranslateService).get(...

in ngOnInit. Now it's working. I hope that will help to somebody. Still not sure why AoT build not working properly when you injecting directly, I think related to when TranslateService created/provided.

Hi, here is my solution for shared translate module
`@NgModule({
imports: [
CommonModule,
MatMenuModule,
MatIconModule,
TranslateModule
],
declarations: [LanguageSwitcherComponent],
exports: [
LanguageSwitcherComponent,
TranslateModule
]
})
export class LanguagesModule {
static forRoot(): ModuleWithProviders {
return {
ngModule: LanguagesModule,
providers: [
TranslateModule.forRoot({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
]
};
};
static forChild(): ModuleWithProviders {
    return {
        ngModule: LanguagesModule,
        providers: [
            LanguagesService,
            TranslateModule.forChild({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
        ]
    };
}

}`

@NgModule({
imports: [
CommonModule,
MatMenuModule,
MatIconModule,
TranslateModule
],
declarations: [LanguageSwitcherComponent],
exports: [
LanguageSwitcherComponent,
TranslateModule
]
})
export class LanguagesModule {
static forRoot(): ModuleWithProviders {
return {
ngModule: LanguagesModule,
providers: [
TranslateModule.forRoot({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
]
};
};

static forChild(): ModuleWithProviders {
    return {
        ngModule: LanguagesModule,
        providers: [
            LanguagesService,
            TranslateModule.forChild({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
        ]
    };
}

}

Here is my solution
`@NgModule({
imports: [
CommonModule,
MatMenuModule,
MatIconModule,
TranslateModule
],
declarations: [LanguageSwitcherComponent],
exports: [
LanguageSwitcherComponent,
TranslateModule
]
})
export class LanguagesModule {
static forRoot(): ModuleWithProviders {
return {
ngModule: LanguagesModule,
providers: [
TranslateModule.forRoot({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
]
};
};
static forChild(): ModuleWithProviders {
    return {
        ngModule: LanguagesModule,
        providers: [
            LanguagesService,
            TranslateModule.forChild({ loader: { provide: TranslateLoader, useClass: LanguageLoader } }).providers
        ]
    };
}

}`

Hey,SamVerschueren
The example is good but here the translation are coming from .app/common/i18n but in my case I have mutliple translation files based on the modules such as  app/common/i18n/home and app/common/i18n/feature . In this case how this will help me  ?

I'm submitting a ...
[ ] bug report
[ ] support request
[ ] feature request
[x] documentation improvement

Current behavior
Create a SharedModule that loads the translations with TranslateModule.forRoot.
@NgModule({
    imports: [
        CommonModule,
        TranslateModule.forRoot({
            provide: TranslateLoader,
            useFactory: (http: Http) => new TranslateStaticLoader(http, 'app/i18n', '.json'),
            deps: [Http]
        })
    ],
    exports: [
        CommonModule,
        TranslateModule
    ]
})
export class SharedModule {

    static forRoot(): ModuleWithProviders {
        return {
            ngModule: SharedModule
        };
    }
}

Load this SharedModule inside a lazy loaded feature module and try to translate a value inside that feature module. You will notice that the keys are not being translated.
Now why is this the case? A lazy loaded feature module creates a child injector instance in which it bootstraps all the services again. We aren't at root-level anymore and shouldn't be calling TranslateModule.forRoot. This should only happen at the root (hence the name :)). More info in this topic could be found in the documentation.
From the docs:

Do not specify providers for modules that might be imported by a lazy loaded module.

Expected/desired behavior
The TranslatePipe should translate keys into values in lazy loaded feature modules.
Solution?
The SharedModule should not call TranslateModule.forRoot because this should happen at the AppModule level (at the root).
app.module.ts
@NgModule({
    imports: [
        BrowserModule,
        TranslateModule.forRoot({
            provide: TranslateLoader,
            useFactory: (http: Http) => new TranslateStaticLoader(http, 'app/common/i18n', '.json'),
            deps: [Http]
        }),
        SharedModule.forRoot()
    ],
    declarations: [
        AppComponent
    ],
    bootstrap: [AppComponent]
})
export class AppModule { }

shared.module.ts
@NgModule({
    imports: [
        CommonModule,
        TranslateModule
    ],
    exports: [
        CommonModule,
        TranslateModule
    ]
})
export class SharedModule {

    static forRoot(): ModuleWithProviders {
        return {
            ngModule: SharedModule
        };
    }
}

Please tell us about your environment:
* **ng2-translate version:** 2.4.1

* **Angular version:** 2.0.0-rc.5

* **Browser:** all

* **Language:** probably all

This solved such a big problem for me that had me banging my head against the wall for about 3 or 4 days.


Remove Secondary Emails

In gitlab by @CalumTowers on Aug 1, 2016, 17:45
Implement the ability to remove secondary emails that are no longer needed on an account.

In gitlab by @NFarrington on Aug 6, 2016, 13:55
Dupe of #365


Clarify 'number' validation context

The number validation context should probably have been named 'long' as it only accepts whole numbers per the TCK. But IMHO this is not worth changing at this point for backwards compatibility reasons. I suggest just adding some clarifying language to the specification.

I think the number context should automatically validate both long and double values. HTL should not be used a validator, it should just make sure that the provided values cannot escape a well defined context.


PDO: support PDO::FETCH_COLUMN in fetch()

refs https://github.com/staabm/phpstan-dba/issues/269
@xPaw could you double check the types are what to expect?
initially I had the feeling this would not be supported, as I was not able to find it in the php.net manual

Seems to be what I would expect

thanks for the fast feedbcak


Mine Menu Modded Keybindings not working?

Hey there,
I'm trying to add Passive Skill Tree or show Advancements Tracker to my mine menu but it doesn't work, nothing happens if I click on it.
{
"main": {
"3": {
"title": "Passive Skill Tree",
"icon": {
"stack": "{Count:1b,id:"minecraft:oak_sapling"}"
},
"action": {
"key": {
"key": "key.display_skill_tree",
"toggle": false
}
}
},
"4": {
"title": "Inventory",
"icon": {
"stack": "{Count:1b,id:"minecraft:stone"}"
},
"action": {
"key": {
"key": "key.inventory",
"toggle": false
}
}
}
},
"ewqewq": {}
}
Inventory works, Skill Tree not
Advancement Tracker is excluded

sorry duplicate
Would be glad if there are fixes available


Remove async_trait crate and use native method

From Rust1.75 onwards async support was added so we do not need async-trait crate anymore. Removed this crate in this PR and used native async support.
Resolves: #1972

Looks like at we moment we cannot get rid of async_trait. Let's postpone it for ~1 year ;)


Fix job grade ordering (4.0 branch)

Implementation of #2500 (Fix job grade ordering) for the 4.0 branch.
Changes

Job grades are displayed using a sorting function.

Testing

See #2500 for testing instructions.

Review

@cfpb/cfgov-backends

Checklist

[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[X] Passes all existing automated tests
[X] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

👍


Error loading file, not a diagram file

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
I used draw.io to draw some diagrams for my project, and I saved it in GitHub. This morning, everything worked properly, saving the files, drawing,... But when I opened the project just then, it didn't load up the file.
I checked the file in GitHub, the whole code is there but draw.io could load the file up.
To Reproduce
Steps to reproduce the behavior:

Go to draw.io

Open existing file

Direct to GitHub

And see this error:

Expected behavior
Well it should have popped up the project.
**draw.io version: **

draw.io version:  [v21.6.8]

Desktop (please complete the following information):

OS: Window 11
Browser chrome
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

If the repo is public, please include the URL of the file, else, please attach a copy of the file.

I have the same problem. Here is the repo. I can not open any file from here.
https://github.com/DarkDonnerGunther/rivercookery/tree/main/vegeterian Pizza
When I download the files I can open it from my device inside of draw.io-webpage and draw.io-app on Windows 10.

Thanks, this helped me a lot. But, now the other way works, too. So, maybe there was a bugfix.

Thanks, this helped me. But only for a diagram in the main root of the repository.
So, for this diagram it works:
https://github.com/DarkDonnerGunther/rivercookery/blob/main/legend_graphic.drawio
But for this, it does not work:
https://github.com/DarkDonnerGunther/rivercookery/blob/main/vegetarian_pizza/de_vegetarische_Pizza.drawio
When I save the diagram at the first time and let it open in draw.io, everything works fine. But if I want to open it again from GitHub it does not open.

Ok, this works for me, too. And I can save and export the diagram. Thanks. So, maybe there is a problem with the interaction between my github-account and draw.io. But is there a simple way to create the link, you sent me?

When providing the URL of a diagram you have to provide the raw URL of that file. Pointing the HTML page displaying a UI for the file isn't going to work.


NullReferenceException on Travis

This only happened once and it didn't happen in dev but it happened in the sockets branch when running the regular libuv tests
EDIT: It happened in dev
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnection.StopAsync()
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnection.StopAsync()   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.<>c__DisplayClass7_0.<WalkConnectionsCore>b__0(IntPtr ptr)
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnection.StopAsync()   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.<>c__DisplayClass7_0.<WalkConnectionsCore>b__0(IntPtr ptr)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.NativeMethods.uv_walk(UvLoopHandle loop, uv_walk_cb walk_cb, IntPtr arg)
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnection.StopAsync()   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.<>c__DisplayClass7_0.<WalkConnectionsCore>b__0(IntPtr ptr)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.NativeMethods.uv_walk(UvLoopHandle loop, uv_walk_cb walk_cb, IntPtr arg)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.WalkConnectionsCore(Func`2 action, TaskCompletionSource`1 tcs)
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnection.StopAsync()   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.<>c__DisplayClass7_0.<WalkConnectionsCore>b__0(IntPtr ptr)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.LibuvFunctions.NativeMethods.uv_walk(UvLoopHandle loop, uv_walk_cb walk_cb, IntPtr arg)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvConnectionManager.WalkConnectionsCore(Func`2 action, TaskCompletionSource`1 tcs)   at Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.LibuvThread.DoPostWork()
The active test run was aborted. Reason: Unable to communicate with test host process.

One theory: If StopAsync happens before _connectionContext is assigned it can null ref.

Assigning to @natemcmaster for investigation.

Closing. Can reopen if it happens again. Haven't seen this on CI in the last week and couldn't repro on my own with the latest dev branch. I think this may have been solved by the work @halter73 did to cleanup shutdown logic. #1707


Do not apply instab damage to targets with mech_no_stability

dragoonxx — 07/11/2021
something funky seems to be happening with (at least the hive PA), it got destabilized on a charge (i think?) round 5, moved and guarded on its move round 6- but it was still unstable
next turn, simple move and brace- still listed as unstable (with stability having been 0->0)
Harkonnen — Yesterday at 4:36 PM
@KMiSSioN @FrostRaptor seems like charge applies unstable to units with "mech_no_stability"

Fixed in 0.9.0


Would release the code in the simulated environment RLBench.

Thanks for this awesome work!
I noticed early work like KAT just opened the prompt demo in the jupyter style (confusing). :<
Does the author open the whole pipeline?
Looking forward to your reply and hope to gain more insight from this work.

Hi @feriorior,
Thanks for your interest in our work!

Sorry for the delay in code release. I am preoccupied with other things in the last few weeks. We will release full code to reproduce our results in RLBench earlier next week.
Yes. We do realize KAT provides jupyter notebook that shows how to identify keypoints in image pair. We use it to evaluate results for KAT.

Hi @feriorior,
Thanks for your interest in our work!

Sorry for the delay in code release. I am preoccupied with other things in the last few weeks. We will release full code to reproduce our results in RLBench earlier next week.
Yes. We do realize KAT provides jupyter notebook that shows how to identify keypoints in image pair. We use it to evaluate results for KAT.

Dear author,
Thanks for your great work! May I kindly inquire about the release progress of the amazing work?
Thanks for your attention to this matter.

Hi @feriorior,
Thanks for your interest in our work!

Sorry for the delay in code release. I am preoccupied with other things in the last few weeks. We will release full code to reproduce our results in RLBench earlier next week.
Yes. We do realize KAT provides jupyter notebook that shows how to identify keypoints in image pair. We use it to evaluate results for KAT.

Hi Author,
I was wondering if you could share any updates on the release progress.
Thank you for your time and consideration.

Hi @hoh12131 and @MarSaKi,
Sorry for the delay. It's up now.


Update Docker build & add quickstart to README

This change has two goals:

Enable Docker container to build using a recent version of Go, while pinning the version to help ensure it doesn't accidentally break in the future
Add a quick start section to help folks try this out with minimal effort using Docker

Also, thanks for the great project 🎉  Please let me know if you'd like to see any changes 🙂

@erguotou520 I just wanted to add a note that I was also having problems with docker build, and this PR has solved them for me.

Thank you guys.


Default id_rsa path on Windows 11 may have changed

Description

"/c/ProgramData/Multipass/data/ssh-keys/id_rsa" vs "/c/Windows/ProgramData/Multipass/data/ssh-keys/id_rsa"

System info

Operating system and version: Windows 11

Steps to reproduce:

Step
Next step

Suggestions

Windows 11 config file
{
	"host": "dev.multipass.local",
        "hostname": {
            "source": "multipass",
            "name": "dev"
        },
        "user": "ubuntu",
        "identity_file": "/c/ProgramData/Multipass/data/ssh-keys/id_rsa"
}

Windows 10 config file
{
	"host": "dev.multipass.local",
        "hostname": {
            "source": "multipass",
            "name": "dev"
        },
        "user": "ubuntu",
        "identity_file": "/c/Windows/ProgramData/Multipass/data/ssh-keys/id_rsa"
}

https://github.com/iancleary/local-ssh-config/blob/b92b15c5d57b723ee51b038ebae8e710ac479fe6/local_ssh_config/ssh/_constants.py#L9-L11
Related
Relates to organization/repo#number

[x] I have reviewed the Guidelines for Contributing and the Code of Conduct.

Can I just use %appdata% instead?

%PROGRAMDATA% is the correct variable from os.environ


What if you want to use the latest manifest schema, but only want to run your app in Teams and not in Office/Outlook?

What if you want to use the latest manifest schema, but only want to run your app in Teams and not in Office/Outlook?
I ask this question, because we are in the process of validating our app, but it's rejected, because we use manifest version 1.13 and in Office/Outlook our app only shows a message "The App can only be using inside Microsoft Teams.".
So I think an option to specify in which application (Teams/Office/Outlook) the app can run, would be a requirement.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f94a488-d636-92b3-21eb-c88744c8f272
Version Independent ID: 7b3413f4-9ade-accf-5cb2-83fead11a32a
Content: Manifest schema reference - Teams
Content Source: msteams-platform/resources/schema/manifest-schema.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@JohanKlijn - Thanks for reporting your issue.
We will investigation this issue and get back to you.

@JohanKlijn -The Microsoft Teams JavaScript client SDK can help you create hosted experiences in Teams, Office, and Outlook, where your app content is hosted in an iframe.
Starting with version 2.0.0, the existing Teams client SDK (@microsoft/teams-js, or simply TeamsJS) has been refactored to enable Teams apps to run in Outlook and Office, in addition to Microsoft Teams.
Use the latest TeamsJS (v.2.0 or later) whenever possible, in order to leverage from the latest improvements and new feature support including Teams-only apps. TeamsJS v.1.12 continue to be supported, however, no new features or improvements will be added. The 1.12 and 1.13 schemas are otherwise the same. From a functional perspective, the latest version of TeamsJS supports all existing (v.1.x.x) Teams app functionality while adding the optional ability to host Teams apps in Outlook and Office.
Reference Document-1.https://docs.microsoft.com/en-us/microsoftteams/platform/resources/schema/manifest-schema
2.https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/using-teams-client-sdk?tabs=javascript%2Cmanifest-teams-toolkit

@sayali-MSFT : I know that using the 2.0.0 MS Teams JavaScript client SDK can help me to host the app in Teams, Office and Outlook. So that’s not the issue.
In our case we don’t have any requirement to host the app in Office or Outlook. I know we can downgrade to use the 1.12 app manifest, but that probably in the future we need to update to the latest (because of some change in the app manifest which we require for Teams), and then again we need to support our app in Office and Outlook.
Supporting our app in Office and Outlook, means we also need to test this, which means effort and resources. But in our case it’s “a waste” because our app is really a Teams app, so users will never use it in Outlook or Office. For example upgrading to the latest version > 2..0.0 of the MS Teams JavaScript client SDK, causes already problems, see https://github.com/OfficeDev/TeamsFx/issues/6082.
If our app  only shows the message "The App can only be using inside Microsoft Teams.” In Office or Outlook, Microsoft will not approve the app.
So my issue is, that upgrading to the latest version of the app package manifest, suddenly requires more effort (for example upgrading the SDK, testing in Outlook and Office). So I think a backwards compatible option (to enable the app only in Teams), would make sense.

@sayali-MSFT : FYI, I created an issue on the forum, see https://feedbackportal.microsoft.com/feedback/idea/1f43389b-ca38-ed11-a81b-000d3a7dd504


Add dockercfg authentication to a registry

This adds support for authentication to a registry using the .dockercfg
file in user's home directory.

lgtm!

This will need a substantial rebase I think

Closing in favour of #41


chore: migrate docker script

关联的Issues (Related Issues)

involve https://github.com/filecoin-project/venus/issues/5489
改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[x] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[x] 具有清晰明确的commit message / All commits have a clear commit message.
[x] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[x] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #118 (e12e6b0) into master (64dad5f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   41.65%   41.65%
=======================================
  Files          32       32
  Lines        3063     3063
=======================================
  Hits         1276     1276
  Misses       1602     1602
  Partials      185      185

Flag
Coverage Δ

unittests
41.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


create a removeWhere(queryObject), a removeWhere(func)

Optimize removal of multiple records with the above methods.

Looking forward to this.

Ok this is checked in, if you want to try the latest source. removeWhere() takes either a query object (same syntax as find() ) or a filter function. As for removeAll(), there is already a clear() that does just that. I also added support for remove (id: number) which deletes by id rather than passing the entire object.

Nice, I'll take a look at this as soon as I get back.

This is done and reflected in the docs.


Bug: majority_vote_ function does not handle cases where pred[prediction_field] is a list of str instead of str

Link to the code snippet in question:
https://github.com/stanfordnlp/dsp/blob/12d7f1106f2f524be161d35865a81e0ea016e929/dsp/primitives/predict.py#L211
Expected behavior:
The function should work with pred[prediction_field] of type Union[List[str], str].
Current behavior:
The function raises an error when calling normalize_text on pred[prediction_field] when it is of type List[str].

Thanks a lot for catching this! Do you have an example of where that might happen?

Hmm, thanks! We do already do CoT+SC with dsp.majority in the intro notebook.
Here's a simplified version.
@dsp.transformation
def QA_predict(example: dsp.Example):
    example, completions = dsp.generate(qa_template_with_CoT, n=20, temperature=0.7)(example, stage='qa')
    completions = dsp.majority(completions)

    return example.copy(answer=completions.answer)

The only difference I see is that we extract the answer at the end. Is there anyother difference?

Maybe you're saying we have some regression. The same code from the intro notebook no longer works on the latest branch?

I think I know what the problem is. text-davinci-001 sometimes returns a List[str], whereas gpt-3.5-turbo or text-davinci-002 consistently returns str in my experiments. You could try running the intro notebook with text-davinci-001.
I guess either specifying that the code does not support certain GPT models, or adding codes to handle the different LM behaviors could work.
If you want to go down the second path, the evaluate would probably need to change as well.

If your PR fixes this, I'm happy to merge it. But I'm unclear on what you mean by text-davinci-001 returning a list. Don't all models return a list of strings (i.e., a list of completions)? Are you saying that text-davinci-001 returns a list of lists?

If your PR fixes this, I'm happy to merge it.
Please don't merge just yet. As I mentioned, the evaluate function has similar problems. If you want to fix it, it's better to fix both.
But I'm unclear on what you mean by text-davinci-001 returning a list. Don't all models return a list of strings (i.e., a list of completions)? Are you saying that text-davinci-001 returns a list of lists?
Since completions: list[dict[str, Any]] = generator(prompt, **kwargs) at here does not check for the type of the dict values, a completion in completions could have completion[prediction_field] being multiple types. Different LMs do fill that prediction_field with different types. And downstream functions such as majority does not take this into consideration.

I'm on a $5 budget for openai calls, so I'm afraid I won't be able to help you test more cases.

Thanks for reporting this and helping with it. We haven’t been able to reproduce it unfortunately. cc: @lawliet19189

Hi @okhat , I believe the problem may come from the extract function in template_v2.py (https://github.com/stanfordnlp/dsp/blob/12d7f1106f2f524be161d35865a81e0ea016e929/dsp/templates/template_v2.py#L131).
The function takes an example, and overwrites example.answer if an answer is found. However, in some case, the response from LM is malformed. For example, when we add rationale to our template, we expect the LM to follow Answer: {LM's answer} format. but we do not enforce it. In this case, here is one possible output generated from LM:
Context:
[1] «BTC-e | Gina Esparon and Evaline Sophie Joubert and two people with significant control: Alexander Buyanov and Andrii Shvets. The US Justice Dept attempted to close down BTC-e on the 26th of July 2017 when they charged Alexander Vinnik and BTC-e in a 21-count indictment for operating an alleged international money laundering scheme and allegedly laundering funds from the hack of Mt. Gox. The exchange plans to relaunch in September 2018. BTC-e started in July 2011, handling a few coin pairs, including Bitcoin/U. S. dollar and I0Coin to Bitcoin. By October 2011, they supported many different currency pairs, including Litecoin to dollars,»
[2] «Andy Harris (politician) | Furthermore, "Harris then asked if he could purchase insurance from the government to cover the gap," added an aide, who was struck by the similarity to Harris's request and the public option he denounced as a gateway to socialized medicine. On October 16, 2013, Harris voted against the motion to end the government shutdown and raise the debt ceiling. Harris has defended Hungarian leader Viktor Orbán, an ally of Vladimir Putin who has pledged to turn his country into an "illiberal democracy". Harris decried the State Departments' efforts to support free and independent media in the country. In 2014, Harris»
[3] «BuysUSA.com | a Mercedes and other luxury vehicles with his profits. The Federal Bureau of Investigation investigated the site and was ultimately responsible for shutting down the site permanently in October 2005. On Friday, August 25, 2006, Danny Ferrer appeared before U.S. District Court Judge T.T. Ellis III in Alexandria, Virginia. He was told, "You extended your hand into the pockets of these people," and that, "If severe penalties were not attached, people would line up from here to Los Angeles to do what you've done." Danny Ferrer claimed to the judge that he started selling the software to pay for a»
[4] «United States federal government shutdown of 1990 | the Smithsonian museums. Although none of the appropriations bills had been passed, not all government agencies actually shut down. Full shutdowns occurred in the Environmental Protection Agency, Department of Labor, Office of Personnel Management, and Department of Housing and Urban Development, and partial shutdowns occurred in the Library of Congress, Government Printing Office, and the Departments of Energy, Interior, and State. According to a study by the General Accounting Office, Interior (which includes the National Park Service) furloughed about 2,800 workers, the Library of Congress around 100, and the other agencies fewer than 10 each. In the morning of Tuesday,»
[5] «Jinkanpo Atsugi Incinerator | the poor air quality. In May 2001, the Japanese government purchased the plant for nearly 40 million dollars and shut it down following a United States Department of Justice lawsuit against the private incinerator owner. Dismantling was completed by the end of that year. Some former residents of Atsugi NAF still complain of health problems related to the incinerator's emissions and report that the USN has been reluctant to address their concerns. The incinerator contaminated the base, especially the housing area, with dioxin, heavy metals, and other deadly toxins. In June, 2007, the USN's Environmental Health Center announced that it»

Question: What government department did Buyantu shut down?

Rationale: Let's think step by step. There is no mention of Buyantu shutting down a government department in the provided context. Therefore, the answer is: N/A.

In this case, the template fails to extract N/A from the answer, and leaves example.answer as is.
In dataset like SQUAD, example.answer is usually a list, so that's the reason why completion.answer is a list.
My guess comes from the following observation. Here is a code snippet from my CS224U homework:
t0 = len(lm35.history)
test_case = dev_exs[56]
print("Question:", test_case.question)
print("Expected answer:", test_case.answer)
print(few_shot_openqa_custom(test_case, 3).answer)
t1 = len(lm35.history)
print(f"Number of LLM requests: {t1-t0}")

And this is the output:
Question: What government department did Buyantu shut down?
Expected answer: ['the Department of State Affairs', 'Department of State Affairs', 'the Department of State Affairs']
Generated answer: ['the Department of State Affairs', 'Department of State Affairs', 'the Department of State Affairs']

In any case, evaluation expects a string and will raise an exception, I believe, if you try feeding it a list.
A PR that unsets output fields that were left unpopulated by extract will be highly welcome! But in general, always make sure to pass only the questions (or example objects with only questions set) to your program. Passing the answer is a dangerous idea.

Thanks @tsunrise ! I strongly recommend not passing a populated .answer field to your program. Otherwise you risk unintended leakage one way or another. Luckily, your evaluation function seems to expect a string and will raise an exception, I believe, if you try feeding it a list, so hopefully this ensures no leakage in your specific case.
If you remove that field before calling generate, dsp.generate will invoke the LLM as many times as needed to make sure all output fields are produced.
A PR that unsets output fields that are not overwritten by extract will be highly welcome, although the correct semantics in this case seem ambiguous: what does the user expect when some of the output fields are already set?
In general, always make sure to pass only the questions (or example objects with only questions set) to your program. (Or, at least, unset the output values you expect dsp.generate to produce, when there are multiple output fields.)

Sounds good! I have created a PR for that

Thanks for opening this, this got fundamentally resolved in v2 (DSPy). Closing.


rtpmpeg2audio: improve decoder robustness

Codecov Report

Merging #262 (2fdbdab) into main (d56ae1f) will decrease coverage by 0.02%.
The diff coverage is 96.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   86.40%   86.38%   -0.02%
==========================================
  Files          88       88
  Lines        9194     9220      +26
==========================================
+ Hits         7944     7965      +21
- Misses        970      973       +3
- Partials      280      282       +2

Impacted Files
Coverage Δ

pkg/formats/rtpmpeg2audio/decoder.go
96.20% <85.00%> (+1.99%)
:arrow_up:

pkg/formats/rtph264/decoder.go
79.52% <100.00%> (+0.32%)
:arrow_up:

pkg/formats/rtph265/decoder.go
72.72% <100.00%> (+0.50%)
:arrow_up:

pkg/formats/rtpmjpeg/decoder.go
90.16% <100.00%> (+0.33%)
:arrow_up:

pkg/formats/rtpmpeg4audio/decoder.go
82.38% <100.00%> (+0.22%)
:arrow_up:

pkg/formats/rtpvp8/decoder.go
94.00% <100.00%> (+0.38%)
:arrow_up:

pkg/formats/rtpvp9/decoder.go
93.47% <100.00%> (+0.45%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


BUG: git_root will carry rgb coding sequences and fail to change to the path

The added path is like this:

I have created a pr to fix this: #104

The pr has been merged.