Title tag misplacement

Describe the bug

Open and close  tag can be observed misplaced

Possible solution

Making the required changes in the doc to setup the code properly

Screenshots

If applicable, add screenshots to help explain your problem.

Kindly assign this task to me @sairish2001

@SarthakKeshari I have already created the issue #563
Kindly close the issue

@sairish2001 I am closing this issue since its already been described by @khareyash05 .
Thankyou @khareyash05 for the information


Added github-merit-badger for OpenSearch

Description
Coming from the build repo. I liked the idea of having merit badges to pull requests that come in the repository.
Tested here: Sample Job
Will look like this:

Open to discussion about this workflow.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 @kotwanikunal are waiting on any feedback or can we merge the change?

Late to the party! We can merge this for sure. Right now this workflow counts bot also as user. I was waiting if @prudhvigodithi can provide some insight on that how to ignore the bots (but we can incorporate that later). Also, we don't need to create the label. The workflow takes care of it.

Yes @owaiskazi19 the labels are auto created, but at this point the App users cannot be excluded with this workflow, I will take a look to improve the workflow to exclude the app users as well.
Thank you

I like the sentiment but maybe there's a better way to go about it? Could we look into GitHub achievement badges instead? Maybe a First Time Contributor OpenSearch badge on the contributor's github profile? OpenSearch All Star Achievement for multiple contributions?

I like the sentiment as well, but share @nknize's concern about this introducing a hierarchical social class system. It feels a bit counter to our Principle's for Development, specifically:

Respectful, approachable, and friendly.
This will be a community where you will be heard, accepted, and valued, whether you are a new or experienced user or contributor.

 I second the vote to remove this pending further discussion.

@nknize @andrross thanks for the feedback. This PR was raised to get the discussion going for the merit badge and whether we like it or not for OpenSearch. Seems like we don't. The merit badge also helps to track the metrics for the repo, Mostly, to understand how many new contributors we have and the repeat contributors.
I'll go ahead and revert this PR.

Thinking about it, +1 to @andrross, @nknize feels like we are distinguishing contributors which doesn't look fair.
I like the idea of adding github badges which are added to each profile.

The merit badge also helps to track the metrics for the repo, Mostly, to understand how many new contributors we have and the repeat contributors.

Have you checked out the contributor tools in https://github.com/opensearch-project/project-tools?

...we do have a dashboard also now to track the contributions

Is that URL publicly accessible? Or will it be? Perhaps exposed on opensearch.org?
Tracking community health is something a lot of foundations do (or at least help with).
Another thing that could be really useful is a quarterly blog post on community health! Project-tools is a good place to start but it needs some work as it counts a lot of duplicates both at the PR (e.g., backports) and the user level (e.g., can't distinguish email duplicates). Perhaps we can work on fixing that and make that fully accessible to all maintainers.
Maybe we also think about rotating the community health blog among all maintainers? In the future we could think about establishing a PMC and making this a responsibility of the rotating PMC chair like it's done at The ASF.

/cc @elfisher ☝🏻

Is that URL publicly accessible? Or will it be? Perhaps exposed on opensearch.org?

It's internal as of now. @bbarani can share more insight on if we are planning to make it public in the future.


Bug(migrate, v2):  Cannot find module 'fs-extra'

Is there an existing issue for this?

[X] I have searched the existing issues

Which Transloco package(s) are the source of the bug?
Schematics
Is this a regression?
Unknown
Current behavior
I'm trying to run @ngneat/transloco:migrate on and Angular 7 project. It seems that if the project doesn't already include fs-extra, the migration will fail:
>npm run -- ng g @ngneat/transloco:migrate

> ng "g" "@ngneat/transloco:migrate"

? ✍ Which library did you use? Angular
? ✍ Which folder will contain the translation files? ./src/app
Cannot find module 'fs-extra'

Expected behavior
migration runs :)
Please provide a link to a minimal reproduction of the bug
N/A
Transloco Config
None yet :)

Please provide the environment you discovered this bug in
Transloco: 2.23.5
Angular: 7.2.16
Node<EMAIL_ADDRESS>Package Manager<EMAIL_ADDRESS>OS: Windows_NT 10.0.19044

Browser
N/A

Additional context
Fix seems to be npm install<EMAIL_ADDRESS>The current version isn't compatilbie with the node version required for Angular 7.
I found 8.1 from:
https://github.com/ngneat/transloco/blob/4d51bd9594da17ca6626352d8938b8a1be1126f4/schematics/package.json#L18
Not sure why it's not being picked up when installing transloco.
I would like to make a pull request for this bug
If I knew the fix I would.

@fowl2 we use fs-extra v9.1.0 which requires node v10+ so why do you need to install v8.1.0? 🤔
I'll take a look but anyway a fix won't be released for Transloco v2 since we are currently on v4.

I used the version of fs-extras from the package file I linked as it seemed likely this would be the correct version and the current version isn't supported by the version of node that's supported by the version of angular I'm using. I'm using V2 for the same reason.

@fowl2 Yes I understand that you are using V2 because of Angular 7.
What I'm saying it that<EMAIL_ADDRESS>supports node 10+ which is the version you have.
Anyways, I'm glad you managed to migrate, I'll add a fix for new users and Transloco v4.
BTW did the migration went as expected?


fix: Fixes from the ETF release day

Great changes! This improves and simplifies code at the same time. Thank you!!


chore: update node-fetch to 3.3.2

This is to reduce bundle size.
It no longer has a dependency on whatwg-url
so overall bundle size is reduced.
bundlephobia thinks the dependecies of node-fetch will go from 283kB minified to 65.3 kB minified.
This is dependencies only and therefore excludes the size of node-fetch only, excluding deps.
I have also opened a PR for inquirer #SBoudrias/Inquirer.js#1271 which will also reduce the lodash dependency size (when bundled). So we can get that updated once merged too.
So once these are merged and the deps updated the overall size of jsforce can be reduced quite a bit.
#SBoudrias/Inquirer.js#1271
#auth0/node-jsonwebtoken#916
@salesforce/core
There is another large dep on lodash in jsonwebtoken but it looks like there is a PR already to address that too #auth0/node-jsonwebtoken#916. This is used by #forcedotcom/sfdx-core but it seems they have since bumped jsonwebtoken to 9.0.3 https://github.com/forcedotcom/sfdx-core/commit/87428c20d27a90f888d3a2f0c0095c24f394afe1

Closing this since we decided to stay on node-fetch v2 for a bit longer until node's fetch is stable, see:
https://github.com/jsforce/jsforce/issues/1399#issuecomment-1967422881


Some queries with respect to the Fastify Book

Hi there, I've been really enjoying the Fastify book on O'Reilly! The complete guide for the todo app has been fantastic for managing code. I do have a couple of questions:

Usage of fastify.decorate in autoHooks:
In the autoHooks files, we're using fastify.decorate('usersDataSource', {}). Why was this approach chosen over creating individual files like user.service.js and importing service functions separately? Does extensively decorating the fastify instance impact performance?

onRequest hook in autoHooks for todos routes:
We're adding service functions to request.todoDataSource in the onRequest hook. For instance:

fastify.decorateRequest('todosDataSource', null)

fastify.addHook('onRequest', async function (request, reply) {
  request.todosDataSource = {
    async countTodos(filter = {}) {
      filter.userId = request.user.id
      const totalCount = await todos.countDocuments(filter)
      return totalCount
    },
    // ...other functions
  }
})

Does adding all service functions on each request affect performance? Is there a more efficient way to handle this?
Thanks for your insights!

Hi,
happy that the book was useful!
Let me answer your questions!

Why was this approach chosen over creating individual files like user.service.js and importing service functions separately?

There is nothing wrong with your alternative solution; choose the one that best fits your business logic and it is clearer to your team.
In this case, we demoed the autoload feature and put the accent on the loading order.
Creating the user.service.js works, but it is needed to take care of the loading order or you may hit some undefined issue during the start-up phase.

Does extensively decorating the fastify instance impact performance?

It does, but it is not an issue unless we add A LOT (1000?) of props.
Defining a decorator adds a property to the Fastify prototype, that is not a heavy operation.

Does adding all service functions on each request affect performance?

It may affect performance. We define the decorator to add to the request prototype the todosDataSource prop and then the hook assigns to the prop an object with some functions, so if we measure the performance drop here is:

running a function (the hook)
assigning an object to a property ( request.todosDataSource = { ... )

So any application's bottlenecks can't hide in these basic JS operation.

Is there a more efficient way to handle this?

Yes, of course. If we ask ourselves, what does this code do? It adds a utility to our request object.
Does my handler need these utilities? If the answer is not, the code we are running is useless and you may change the request decorator object to a set of functions:
fastify.decorateRequest('countTodos', (filter = {}) => {
        filter.userId = this.user.id // [4]
        const totalCount = await todos.countDocuments(filter)
        return totalCount
      })

// etc...

In this case, the request prototype will be bigger, but the utility functions are there and ready to use without the need for a hook function.
Here is the game: find the best suite for the application and the dev team, fastify will adapt 👍🏼


fix fix iceberg catalog rest access

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.08 seconds
load time: 498 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230202135323_clickbench_pr_89569.html


Restructure Parser type hierarchy to support ConstantParser access from all other Autosar Entity Parsers

This pull request restructures the Parser type hierarchy to allow access to the ConstantParser from all other Autosar Entity Parsers. This change ensures that the ConstantParser can be used by other parsers to parse and handle constant values in the code.
The hierarchy becomes:

BaseParser (handles any common entity fields and has basic parsing functionalities)
ElementPerser (targets a subset of ARXML elements)
(branches)
a. ConstantParser (target ARXML constants)
b. EntityPerser (target AUTOSAR entities) - exposes a self.constantParser to allow for parsing constants while parsing entities; -> all Entity-specific parsers, e.g., behavior, component, etc., inherits from here

 [autosar library] Access to undefined constant_parser


Update pg_cron to allow Sub-Minute Scheduling

Chore
Describe the chore
pg_cron as pulled by the Supabase CLI at the current version does not allow sub-minute scheduling.
The container attached to the Supabase CLI should be updated to a version that supports sub-minute scheduling, as in the link below.
Additional context
https://github.com/supabase/supabase/blob/f3f51cc506990fb191eb1bd6037cea6332736336/apps/www/_blog/2023-06-09-supabase-beta-update-may-2023.mdx#L67

https://github.com/supabase/postgres/pull/634
Supabase tried and had to back it out.

I assume here are multiple needs on this update:
https://github.com/orgs/supabase/discussions/7892#discussioncomment-7114939


Here's a new site I'd like you to consider blocking

Here's a new site I'd like you to consider blocking:
https://www.quora.com
(please include any other relevant details)

I'll need an example here, since afaik people ask questions on quora and every answer under it is a comment, pretty much. Which comments do you see that should be blocked?


config(tidb): update needs cherry pick labels

for versions label from needs-cherry-pick-to-{ .ver } to needs-cherry-pick-to-release-{ .ver }:

6.1
6.3
5.3
5.4

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:

lgtm

/merge


renovatebot(deps): update amazonsdk to v1.11.584

This PR contains the following updates:

Package
Update
Change

com.amazonaws:aws-java-sdk-clouddirectory
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-cloudwatch
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-cognitoidp
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-core
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-dynamodb
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-logs
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-s3
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-secretsmanager
patch
1.11.579 -> 1.11.584

com.amazonaws:aws-java-sdk-sns
patch
1.11.579 -> 1.11.584

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.null seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


How to select all folders?

Hi, when I choose the account and then choose backup folders, there is a list of almost 400 folders (yes, I know). Is it possible to select them all?

Hi @MatejKovacic
Sorry for not getting back to you sooner.
The default behaviour of imap-backup is to backup all folders, so you don't need to do anything to get your desired result.

Hello,
The default behaviour is to backup all folders, so you don't need to select
them all.
On Wed, 13 Jul 2022, 11:01 Matej Kovacic, @.***> wrote:

Hi, when I choose the account and then choose backup folders, there is a
list of almost 400 folders (yes, I know). Is it possible to select them all?
—
Reply to this email directly, view it on GitHub
https://github.com/joeyates/imap-backup/issues/125, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABBU3XDNNNCULPM3L2SM6TVT2AXHANCNFSM53N6ATPQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Unintuitive use_small_heuristics

The documentation states “Whether to use different formatting for items and expressions if they satisfy a heuristic notion of 'small'.”
So my definition of “small” here is obviously subjective.
Anyway, I'd have expected rustfmt 0.4.2-nightly (dd807e2 2018-04-18) to have put the following on a single line:
             (self.code.code() % 10) as u8 + b'0',
         ];
         w.write_all(code)?;
-        w.write_all(if self.is_last == IsLastLine::Yes { b" " } else { b"-" })?;
+        w.write_all(if self.is_last == IsLastLine::Yes {
+            b" "
+        } else {
+            b"-"
+        })?;
         w.write_all(self.line)?;
         w.write_all(b"\r\n")
     }

 impl<'a> fmt::Debug for EhloCommand<'a> {
     fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
-        write!(f, "EhloCommand {{ domain: {:?} }}", bytes_to_dbg(self.domain))
+        write!(
+            f,
+            "EhloCommand {{ domain: {:?} }}",
+            bytes_to_dbg(self.domain)
+        )
     }
 }

         } else {
-            Ok(Reply { code, is_last, line })
+            Ok(Reply {
+                code,
+                is_last,
+                line,
+            })
         }

Then maybe my definition of “small line” is not the same as the one of other people, so maybe an option for tweaking the “sensitivity” of the smallness heuristic could help here?

'small' is deliberately set to be very small because we believe that the readability benefit of using more vertical space usually outweighs any benefit of keeping things on one line. For example, for struct literals, the use case for small is something like Point { x, y }. It is possible we'll tweak these things a bit in the future, but we'll probably still err on the side of too small rather than too big.
Because the small heuristic affects quite a few variables, adding sensitivity options is complex. I do intend to do it, but not in the near future (at least not before a 1.0 release).

OK thanks! A 1.0 release is more important than this, indeed :)

I tried to figure out the status of this problem, and as far as I understood:

The Rust Style Guide says "We leave it to individual tools to decide on exactly what small means" following the discussion in https://github.com/rust-dev-tools/fmt-rfcs/issues/47, where there was an attempt to define "small" in general, that was eventually given up to "[allow] implementations to incrementally improve their design".
rustfmt currently has a number of number-of-characters constants in WidthHeuristics, e.g. "[struct_lit_width is the] Maximum width in the body of a struct lit before falling back to vertical formatting".

Initially configurable independently, they are now controlled by a single use_small_heuristics option (note https://github.com/rust-lang/rustfmt/issues/2437 about the problems with that).
When the heuristics are on, the number-of-columns options are set based on max_width (e.g. struct_lit_width = 18% * max_width), which may be unintuitive when something you deem "very simple" is split across multiple lines.

I didn't find any plans regarding improving the heuristics though, and I think that trying to incrementally define "simple" for the specific obvious cases (such as the StructLiteral {with, shorthands, only} - the last example in this issue) has the highest chance of improving the status quo. @nrc, what do you think?

One issue is that we have a backwards compatibility guarantee and changing the heuristics would break that. So either this would have to be opt-in and/or it would need a 2.0 release. That means the Rustfmt team should absolutely be sure that it is worth working on and plan out exactly when they want to do that.
I think we probably could do better than the existing heuristics, and it would be good to do so. So It think it is worth experimenting with better heuristics. However, I also think there are quite a few other things which ought to be higher priority.


Removed useless spec_helper imports #trivial

This change is also included in https://github.com/danger/danger/pull/76/, closing this for now


r-universe: confirm build error is fixed as part of next release

Right now on r-universe we show two packages:
https://opendp.r-universe.dev/builds:

2024-05-23	opendp-dev/opendp 0.9.2 Stefano Iacus
2024-02-08	opendp(build failure) 0.9.2 Stefano Iacus

Before the next release, can we make sure that https://opendp.r-universe.dev/opendp# reports a successful build?
It turns out that r-universe is using github under the hood: The build failure for 0.9.2 is here
  convert.c: In function ‘error_unknown_type’:
  convert.c:22:5: error: format not a string literal and no format arguments [-Werror=format-security]
     22 |     error(msg);
        |     ^~~~~
  convert.c: In function ‘extract_error’:
  convert.c:74:9: error: format not a string literal and no format arguments [-Werror=format-security]
     74 |         error(msg);
        |         ^~~~~
  convert.c:80:9: error: format not a string literal and no format arguments [-Werror=format-security]
     80 |         error(msg_backtrace);
        |         ^~~~~
  cc1: some warnings being treated as errors

(But the nightly build is successful, so hopefully this will just go away with the next release.)

> install.packages("opendp", repos = "https://opendp.r-universe.dev") trying URL 'https://opendp.r-universe.dev/src/contrib/opendp_0.9.2.tar.gz'
still errors. cannot build and use opendp in r:
`gcc -I"/usr/include/R/" -DNDEBUG   -I/usr/local/include    -fpic  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/r/src=/usr/src/debug/r -flto=auto -ffat-lto-objects  -c transformations.c -o transformations.o

extract opendp and vendor files
convert.c: In function ‘error_unknown_type’:
convert.c:22:5: error: format not a string literal and no format arguments [-Werror=format-security]
22 |     error(msg);
|     ^~~~~
convert.c: In function ‘extract_error’:
convert.c:74:9: error: format not a string literal and no format arguments [-Werror=format-security]
74 |         error(msg);
|         ^~~~~
convert.c:80:9: error: format not a string literal and no format arguments [-Werror=format-security]
80 |         error(msg_backtrace);
|         ^~~~~
cc1: some warnings being treated as errors
make: *** [/usr/lib64/R/etc/Makeconf:195: convert.o] Error 1`

This error came up in #1536, and will be fixed upon our next release (0.10), which we are preparing now.

https://opendp.r-universe.dev/builds looks good:

2024-06-20	opendp 0.10.0

haven't tried locally, but the original issue was just the build error in r-universe, so I think this is sufficient to close. File a new issue if there's a local problem.


[Sluggable][Tree] Fix MongoRegex to Regex for ODM 2.0 compat

Fixes
Error: Class 'MongoRegex' not found

Also removed the regex escape character '/' as new Regex() expects it not to include those.

Hi! I did this against the feature/mongodb-odm-2.0 branch instead of master thinking maybe work would continue in that branch. Feel free to move it to master or Close if the change has already been done in local.

Thank you.


Figure tag is missing and source tag does not allow necessary attributes

The source tag does not allow the needed attributes, but only the global ones.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#attributes
The figure tag is missing completely.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element#text_content
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure

This problem also occurs in 8.7.42 and also affects normal script tags in a Fluid template (not included via TypoScript rendering or with f:format.html). And over all our projects.

Is this an implicit or explicit parseFunc call (cause we are not explicitly using this anywhere).

So is there a recommended way to fix TYPO3 forms (added as form_formframework element in the BE) or custom content elements then? Those are the ones that break for us.

I've updated documentation a bit - maybe that helps already

https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.html#troubleshooting
https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.html#debugging-logging

In case it does not, the actual use-case would have to be analyzed (to be honest, I don't know what happens internally in ext:form for this particular scenario).

For us it really was <f:format.html> in a bunch of page templates where we didn't want any escaping, so we changed some of them to <f:format.raw>

For us it really was <f:format.html> in a bunch of page templates where we didn't want any escaping, so we changed some of them to <f:format.raw>

just as FYI: this won't convert e.g. links anymore

For us it really was <f:format.html> in a bunch of page templates where we didn't want any escaping, so we changed some of them to <f:format.raw>

just as FYI: this won't convert e.g. links anymore

Example: <a href="t3://..."> is not resolved to the actual page, resource, ... anymore when using f:format.raw, that substitution happened in parseFunc which was used by f:format.html.

page.10.stdWrap.parseFunc.htmlSanitize = 0
lib.parseFunc_RTE.htmlSanitize = 0
lib.parseFunc.htmlSanitize = 0
all not working - html elements for e.

are broken. Solution realy needed!

Which TYPO3 version are you referring to?

all not working - html elements for e.

Same problem here with 10.4.19
All  code from the normal image contentelement aren't working.. are html contentelements aren't working.. and the form plugin too.

We encountered the issue with the <f:format.html aswell. In our case it is with form elements.
Did some debugging (TYPO3 10) and it seems like the issue is in TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::parseFunc
Made a bug report for this too. Perhaps this helps in solving the issue: https://forge.typo3.org/issues/94810
The same also happend in a 7.6 ELTS version but have not debugged this. So not sure if its the same.

ℹ Notice
It's getting a little bit chaotic here - thus, I've compiled on overview for troubleshooting . Please have a look first before creating new issues. Thanks!

I think we're done here.
Find tracking at https://forge.typo3.org/issues/94787
Feel free to ask in TYPO3 Slack Channel for #typo3-cms for further support.

Is it possible to add "features" like this in future with working global options like:
config.enableHtmlSanitizer = 1
and not "eat or die, rework all parseFunc implementations... "?
+TYPO3 Version number, breaking change in FE rendering?
Have a scenario like this in mind:
Contract with customer... having always latest updates... on a large website (50K ++ sites)
calc workload for a change like this.

@m-kappenberg There is a feature flag security.frontend.htmlSanitizeParseFuncDefault in pending patch:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70404/8/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#3364
However, the focus still is to make TYPO3 secure per default - security.frontend.htmlSanitizeParseFuncDefault just defines the default values in case neither htmlSanitize = 0 or htmlSanitize = 1 was given.

@matin73 the new Typo3 9.5.30 update fixed all <f:format.html parseFuncTSPath=""> issues for me.
Thanx @ohader , keep up the good work!


[release-v1.16] Add Konflux configurations

Add Konflux components and pipelines

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-v1.16@2d75ff0). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.16     #956   +/-   ##
================================================
  Coverage                 ?   50.27%
================================================
  Files                    ?      129
  Lines                    ?    15565
  Branches                 ?        0
================================================
  Hits                     ?     7826
  Misses                   ?     7023
  Partials                 ?      716

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix failure in nested groupBy with multiple aggregators with same fie…

…ldName
Version 2 - Throws an exception if an outer query references an
aggregator that doesn't exist in the inner query, and then uses the
inner query aggregator names to form the columns for the intermediate
incremental index.
Also deleted all the getRequiredColumns() methods which are no longer
being used.
We do something wacky by adding an aggregator factory for the post
aggregators when building the intermediate incremental index, otherwise
queries on post aggregate results fail because the data isn't in the
incremental index.
Closes #1419

:+1:

:+1: looks good to me, would appreciate a second set of eyes

reverted in e3bb93e8c779a06b26b208c9e08915e87ca1e61a


Vim9: crash when assigning list resulting from map() using closure in block

Describe the bug
In Vim9 script, assigning a list resulting from a map() call which uses a closure inside a block makes Vim crash.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        var x = ['a', 'b', 'c']
        if 1
            var y = [1, 2, 3]
            map(x, {-> y})
        endif
        var z = x
    enddef
    Func()
EOF
)

Vim crashes.
Expected behavior
Vim doesn't crash.
Environment

Vim version: 8.2 Included patches: 1-1801
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(360)

Additional context

backtrace
valgrind log
asan log

Regression introduced in 8.2.0677.


Expose the MaterialApp debug hooks (and the timeDilation) in the gallery app

either as a drawer on the front page, or a popup menu there, or something

Is this issue different than https://github.com/flutter/flutter/issues/1202 ?

Oh, sorry, forgot about that one.


5.Should be Grid.Background

[Enter feedback here]
5.Set the Panel.Background property to the watermark.png image file, by adding the following XAML anywhere between the  and  tags:
=>Should be Grid.Background instead of Panel.Background
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3d7ba9b-4bc3-105a-bed6-fed320821bb5
Version Independent ID: cc43c332-3eb2-9473-b88a-128c6390cfec
Content: Create your first WPF app in Visual Studio 2019 - .NET Framework
Content Source: dotnet-desktop-guide/framework/wpf/getting-started/walkthrough-my-first-wpf-desktop-application.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hello. The property is actually provided by the Panel object, which is why the link is resolving that way. However, we could change the link text to make it clear it's still the grid that we're working with.

I'm following all the steps and keep blowing up at this

I'm following all the steps and keep blowing up at this

I'm following all the steps and keep blowing up at this

I believe it has something to do with the background image...
That's line 25

I'm following all the steps and keep blowing up at this

I believe it has something to do with the background image...
That's line 25

Please open a new issue with this link and add more information such as your XAML being used. Thanks!

Please open a new issue with this link and add more information such as your XAML being used. Thanks!


GCE: add 20.09 to url_map

This is taken from gsutil ls -l gs://nixos-images, which I found here.
Not entirely sure if these images are trustworthy, seeing as they belong to a different bucket.

nice. I think this could be automated as well if you want to give it a shot.


Removed EventReceiver

Types no longer need to inherit from EventReceiver to use Autowiring events functionality.
Deprecated deferred_ptr, which wasn't used anywhere
Renamed seq and gen_seq to index_tuple and gen_index_tuple

This one was such a fiasco.  I can't believe I thought an EventReceiver common base type was even a good idea.


Add Item shouldn't propose an item already present in the list

Testing #127176

Same when editing an item

Agreed. It shouldn't be possible to get to this state:

Shouldn't this just be three checkboxes, one for each option?

The order of the items matters for this setting. Something I plan on doing is adding up/down buttons to the side next to the edit button, which users can use to rearrange the items. Afterwards, I can change the proposals to not repeat.
Otherwise, rendering the items as a list of checkboxes works.

Closing in favour of #127424.


Kevinhaube/#1976 experity testkit lookup table

This PR contains the table to map test kits and specimen information.
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#1976

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

cwinters-usds
30
1h 46m
26

MauriceReeves-usds
28
6h 58m
11

jimduff-usds
21
1d 8h 36m
15

sean-usds
20
1h 12m
8

kevinhaube
19
6h 33m
11

carlosfelix2
17
4h 34m
40

RickHawesUSDS
16
4h 9m
6

whytheplatypus
10
17h 22m
20

TomNUSDS
9
2h 26m
12

clediggins-usds
9
2h 26m
17

jorg3lopez
5
6h 49m
0

jbiskie
5
1h 26m
1

brick-green-agile6
4
1h 5m
3

JosiahSiegel
1
4m
2

ahay-agile6
1
2d 16h 45m
0

oslynn
1
2h 42m
0

MikeC-A6
1
7h 7m
3

rhood23699
1
14h 10m
0

Removing this branch to clear up any confusion about why .schema file changes are checked in. Wasn't aware that wasn't supposed to happen for this work.


feat: Adding Semantic Text Splitter Component (Text Splitters)

Feat: Semantic Text Splitter with Advanced Threshold Controls
Overview
Introduces a new Semantic Text Splitter component that provides flexible text chunking with statistical threshold controls and regex support.
Features:

Multiple threshold control methods:

Percentile-based splitting
Standard deviation thresholds
Interquartile range

Configurable chunk size and count
Optional regex-based splitting

Thanks for your review @edwinjosechittilappilly I have added the langchain_experimental to the pyproject and everything seems to be working. I also added the beta flag on the Semantic Text Splitter component.

@joaoguilhermeS Great job.
https://github.com/langflow-ai/langflow/blob/jg/feat-semantic-text-splitter/src/backend/base/pyproject.toml
I already have langchain_experimental.
Can you test adding a different version of langchain_experimental in both?
I suggest updating the base pyproject so we won’t need to add it in other pyprojects outside of the base.

Hey @edwinjosechittilappilly, I tested the component with the current langchain-experimental dependency version and it is working just fine, so I think there is no need to update so we do not break other components. Thanks for the review.

@ogabrielluiz I believe you might need to approve for this to get merged.(Since changes requested). Can you take a look into it, Its been blocked from merging.


Implement Updated Transaction Tracking

Reference https://github.com/thorchain/asgardex-electron/issues/1342
Part fixed by https://github.com/asgardex/asgardex-desktop/issues/15
Look to add a transaction time returned form streaming swaps.

Happy with the way it is. Will not have 2 txs as the reference was for a Add LP.


Add pictures to the cards

We need to add some default animal pictures to the existing cards, and later on, pet owners who have already added their pets can choose to replace the default picture with a photo of their own furry friend. They will be all pinged once the change is made.

I Want to Work on this issue

@gabrysia694  Is this issue resolved I want to work on this issue

@gabrysia694 Is this issue resolved I want to work on this issue

This issue has just been solved but take a look at issue #1, we'd love to have your pet's info on our website :)


The spark_apply function uses R extension packages very slowly

Hello!
Everyone! I need some help, my problems are as follows:
I use this command:
time_jy_hr<-spark_apply(jydat_hr,function(e) lubridate::ymd_hms(e$data_time),packages = TRUE)
when there are about 600 rows,it takes 5 seconds;But, when I run this command with more than a dataset of 40 thousand rows,it takes more than 3 hours. It is very slowly. This is my first time to use spark_apply function with sparklyr ,maybe I don't  understand completely the usage of this function, please tell me how to use this function when I need to use other R packages.
Thank you very much!

before call spark_apply,  you might consider call the sdf_repartition function, which will help you rebalance your dataframe in each work.
Your job was running 3 hours, which seems only running on only one worker and skewed dataset.

@lucyhome2018 repartitioning as @harryprince mentions would help.
Additionally, we are working on making spark_apply() about 100X faster with arrow, if you feel adventurous to try a feature not yet released, you can find instructions on using arrow here: https://github.com/rstudio/sparklyr/pull/1611.


Bump pkg-dir.

Closes #1110.  I hope I interpreted that thumbs up correctly.

Coverage increased (+2.8%) to 97.266% when pulling d14102f6b151ec80d8c64d47603817473d4594ea on wtgtybhertgeghgtwtg:bump-pkg-dir into ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57 on benmosher:master.


How disable zoom out

How to disable zoom out?
I've tried the example app, and when I zoomed out I got a wrong cropped image.

@francodriansetti Is that the latest version of Fusuma?
I have tried but I got the correct cropped image.

@ytakzk I use the latest version.
In your case works properly because you don't do zoom out.
If you see my photo (in the first image) there're is space on the top and on the bottom.
Can you please test with zoom out?

@francodriansetti, I do face the same issue... could someone help in this?

@vsandeepraju-pcs did u found a solution?

I have same problem

i have same problem to, then i just set minimum scale to 1
FSImageCropView.swift
...
self.minimumZoomScale = 1
...


Keyboard doesn't seen for Sample.qml's example

Hello.Keyboard doesn't seen for "simple" example. Thanks for the project.
OS is Manjaro

I added Virtualkeyboard folder to 5.11/gcc/qml/ path. Other examples works great. Only I was unable to run simple example properly like this picture:

Thank you, it works great now :)


Add XkbCommonCompose struct for compose module

This commit adds a new struct that only includes libxkbcommon functions
from the compose and dead-keys support module and removes these
functions from XkbCommon. It is now possible to use an
XKBCOMMON_HANDLE with libxkbcommon 0.4.3 which does not include this
module. Availability of this module can be checked with
XKBCOMMON_COMPOSE_OPTION.
Resolves #1

This is a little bit inconsistent, because it is the only module with a separate handle (here is a list of modules: https://xkbcommon.org/doc/current/modules.html).

While I agree that this isn't super elegant, I think it's an appropriately simple solution to the problem. Thanks for the PR!
I've updated my winit branch to make use of these changes.


Non explossive flattening row generation limited by user query

With limit-less queries: No time/memory performance losses.
Hugely improved behavior for queries with LIMIT. The flattening process stops generating new rows when the limit has been reached thus avoiding the combinatorial explosion.

Nice work!

+1


PowerRename - have the window stays open

Hello,
It would be very helpful if the PowerRename window stays open once a rename action is completed.  On many occasion, I need to do many PowerRename action to have all the files renamed following the same pattern, but for each action, I need to re-open PowerRename.  A button would need to be added to close the window.

@SRichard2020
closing as duplicate of https://github.com/microsoft/PowerToys/issues/628
Thanks.


close source and remove duplicate call

FYI @ZhengTang1120 @MihaiSurdeanu @reynoldsm88

@ZhengTang1120 the change in line 81 is wrong, that should be calculated dynamically based on the proportion of sentences to keep.  if you revert that we should be in business

Filters were requested at the WG meeting today, will add them here then we should merge

There have been three filter requests which have been addressed here:

NERs
examples from the current ontology
bigrams (or ngrams) of examples from the current ontology.
This PR addresses this, added some tests

The lexiconNER for the "current examples" is a bit of a poor solution maybe, but not the worst I can think of :)
we should try to merge soon, and or @johnhungerford should grab a fresh pull

It's a little/lot late, but should this be merged?

Yes please!

It has been merged.  I intend to publish it so that it can be included on the list at https://github.com/WorldModelers/CorpusIngestionAndAssembly and also just to test the configuration so that it is ready when it's more urgent.


Manage history features

Is it possible to manage the history of solves?
For example:

Export from smartphone and import on PC (Desktop)
Set comment to solve
Remove solve from history
Click old solve and get detailed information like at live solving?

There are many more funcy features. It will be great if you can develop this features.

Click old solve and get detailed information like at live solving?

is available now:octocat:
The others seems nice too.

@hakatashi it looks awesome!

Some additional history enhancements (if I may):

add # turns and TPS to history overview
add graph view


[BUG]: Directed triangle doesn't render correctly

Prerequisites

[X] I am using pure Python (plus NetworkX, our one true dependency)

What happened?
To reproduce:
import networkx as nx
from phart import ASCIIRenderer

# Create a directed graph
G = nx.DiGraph()

# Add edges to form a triangle
G.add_edge(1, 2)
G.add_edge(2, 3)
G.add_edge(3, 1)

renderer = ASCIIRenderer(G)

Output:
  [1]
   ↑
  [2]
   │
  [3]

This is not a triangle :)
On the other hand, a networkx.Graph does work...
renderer = ASCIIRenderer(G.to_undirected())
print(renderer.render())

This produces correct output (I think):
     [1]
   ↓  │   ↓
  [2]────[3]

Your "I think" caused me to look harder and I realize that the line between [2] and [3] also appears if you remove the explicit adding of that connection. It's a side-effect of ambiguous layour/render code I will also work on. If I can get both with this fix, I will just resolve this issue and not open another bug. If not, I can fix yours and I guess warn that there are in some cases in appropriate apparent connections between disconnected nodes (though not apparent in this case.)
Thanks for the reports!

ok.. maybe I should have stayed with the generic layout philosophy, but in the end I added a special case for triangles because every fix made triangles uglier. :-)
problem was mainly here:
if self.graph.is_directed():
    roots = [n for n, d in subgraph.in_degree() if d == 0]
else:
    roots = [max(subgraph.nodes(), key=lambda n: subgraph.degree(n))]

if not roots:  # Handle cycles by picking arbitrary start
    roots = [next(iter(subgraph.nodes()))]

This approach did not work for cycles, as you reported.

Every node in the cycle has equal claim to being the "root"
The shortest path lengths don't capture the cyclic nature
forcing a hierarchical layout on a non-hierarchical structure
I think the current main branch has fixes for both of your issues, as in "works for me", but I'd like your feedback on the results bebfore I close your two issues out.

Thanks!

@scottvr thanks, man! Did you push a new release or should I build from Github. Feel more confident using this library in speaking with you, I was afraid of malware cause it's new.

See other issue comments. Nah, no malware, just a kinda-ludicrous idea. :-) (See the SVG branch for perhaps a totally ludicrous idea.) BTW, I thank you for the report. I confess I really only had passing knowledge of graphs at all from glossing over "Facebook Graph" way back when and seeing the occasional reference to "DAG"s here and there. It wasn't until I had a use case that lead to networkx, which lead to "oh this needs a text output", that I even tried to grok graphs. Your use and issue reports force me to learn more and will expose what is important, pushing phart development forward. I only implemented enough to do what I needed and then released it to the public. Your expertise and feedback is a big help.

    [1]
  ⟷  │
[2]─↕──[3]

hmm.. it's odd but, pretend it's aligned (I'll fix that) do the bidirectional arrows match your expectations?
That is:
     [1]
  ⟷  │
[2]───↕──[3]

If it looked more like that (but let's say, two horizontal arrows, one on each side of the vertical line?) would this be what you're looking for? If not, feel free to show me your desired output and I'll make it work like that.

I just pushed a commit to the repo. Here's my current output with your code.. (it's a windows machine and I get a horrible hybrid of ascii and unicode, but I'll get to that. Your terminal may look better - or worse)
    [1]
     ↕
[2]-⟷--[3]

If you went the pip install -e . route, you can jsut git pull in that directory and run your code again without uninstalling and re-installing. Else.. well
pip uninstall phart
pip install git+https://github.com/scottvr/phart

well, now it's pushed. :-) I didn't notice the linter was griping at me and i had to re-commit

@rjurney Hey Russell, if you have some time today, let's make sure these fixes meet your needs and heck, if you have a bunch of test cases, if you run them all and take the time to tell me which don't work and how phart's output should differ for any cases you find unhappiness, I'll get 'em all fixed this weekend.
I like your enthusiasm for the project a lot. Many times I have created something I needed (ok maybe "want" vs "need" is debatable), put it online cuz I figured it would help, amuse, etc someone other than me to be surprised to learn "it's just me." :-) So, your wanting to use it is satisfying and fortuitous since you have a much better idea of what a text version of your given graph should look like. You can see by the examples (expandable in the README, or runable from the repo) that I thought I was covering a good sample of graphs when testing, but my introduction to networkx and graphs and the creation of phart are nearly the same day just two weeks ago. I know what I wanted, but having a real user will get this tool in top shape quick.


Skip -race flag on Windows

Refs #388.

That's not the only place where we have -race

Added to all other places.


//go:embed <path to file in parent directory> doesn't work

What version of Go are you using (go version)?

go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3225948580=/tmp/go-build -gno-record-gcc-switches"

What did you do?
There is a following package:

main.go
README.md
assets:

assets.go

assets.go contains package assets loaded with //go:embed directive.
I'd like to add README.md file to assets.go, but //go:embed ../README.md doesn't work
What did you expect to see?
the program should compile and work fine.
What did you see instead?
assets/assets.go:59:12: pattern ../README.md: invalid pattern syntax

@seankhliao is it possible to make it a feature request?

It still can't cross module boundaries, and if it's in the same module you can just put the embed directive in a go file in the parent directory

yah, this solution is possible, but it would be a bit crazy.
I'd need to add go:embed directive in main.go and pass on embeded variable to my app? it doesn't seem right.

@seankhliao maybe go:embed in module area could be allowed?

This was an explicit design decision:

Because embed.Files implements fs.FS, it cannot provide access to files with names beginning with .., so files in parent directories are also disallowed entirely, even when the parent directory named by .. does happen to be in the same module.

ref: https://go.googlesource.com/proposal/+/master/design/draft-embed.md

It still can't cross module boundaries, and if it's in the same module you can just put the embed directive in a go file in the parent directory

@gucio321  There is no need to put embed files into child directories, * can be used to match everything int the current directory.
I found this in embed draft.
https://go.googlesource.com/proposal/+/master/design/draft-embed.md#go_embed-directives

There's a major bug with this:
I have the COPYING license file in my project root. But my CLI package which wants to display that text is in a subdir. And so I can't ../COPYING to embed it. I don't think you should be able to get out of the package root, but this blocks the obvious use case that we used go-bindata for :/

Wouldn't it be nice if embed couldn't support predefined variables like 'dirname' or 'projectname' to avoid some unexpected bug and thus avoid the '..' or '.'?

it sounds nice!
Maybe we should make a new issue @JuanigTorres ?

Sounds good to me!

it sounds nice! Maybe we should make a new issue @JuanigTorres ?

If it's still relevant I found good answer here.

maybe do this，Create a new assets.go in the directory that needs to be packaged
package assets

import "embed"

//go:embed *
var Assets embed.FS

Then use this variable in another package
a :=&assets.Assets

I want my webpack bundle to go in a different folder than the golang source code. I want to have a build folder that's .gitignored in the root of my repository so it's easy to keep track of transient files vs persistent ones.  Just let me specify a "target folder" in the virtual (embedded) filesystem instead of assuming I want to copy the file structure relative to my source file (which I almost never want to do as it is)

I think, we needs to "construct" a proposal issue to solve this problem.
Here is what I think:
I understend maintainers' point of view

Because embed.Files implements fs.FS, it cannot provide access to files with names beginning with .., so files in parent directories are also disallowed entirely, even when the parent directory named by .. does happen to be in the same module.

In my opinion its not a good justification - it sounds like saying "we can't add this, since it is not implemented"

It still can't cross module boundaries, and if it's in the same module you can just put the embed directive in a go file in the parent directory

First of all let me note that putting go:embed directive in a parent directory does not look good at all. Over that, it may cause "Import cyclomatic" (or anyhow it is called in go - cant remember exacltly).
I agree that crossing module boundries wouldn't be good.
However, in my opinion, "shouldn't cross module boundries" does not equal "could not reffer to parent directory" - thats the point here. I think that compiler should accept .. pattern and should compile successfully as long as go:embed doesn't reffer to file above go.mod's location.
Any toughts?

As mentioned before, not having .. isn't that it's just not implemented, it goes against the contract specified by io/fs.FS.

As mentioned before, not having .. isn't that it's just not implemented, it goes against the contract specified by io/fs.FS.

well, but go:embed does not need to use fs.FS in fact, does it? Maybe embed.FS should implement fs.FS, but in some extended form so that it could support .. pattern?

The best practice here is to create a package in parent level with go:embed var in there; then reference to this var in the child level packages.

 Why do you always want to teach us how to layout our projects?


[WFRP4e System] Critical Wounds disappearing

I received two criticals in a fight (Gut Wound + Broken Arm (Minor)). However, every time I sign out and log back in, the criticals are missing from my sheet. The bleed from Gut Wound also seems to impossible to remove with player permissions.From: CoG#9765foundry: 11.307wfrp4e: 6.6.1wfrp4e-core: 3.1.6wfrp4e-dotr: 3.0.6wfrp4e-eis: 3.1.7wfrp4e-middenheim: 3.0.3wfrp4e-pbtt: 3.0.3wfrp4e-rnhd: 3.0.8wfrp4e-starter-set: 3.1.7wfrp4e-up-in-arms: 3.0.7wfrp4e-wom: 3.0.7Active Modules: about-face, calendar-weather, colorsettings, custom-compendium-banners, dice-so-nice, drag-ruler, easy-target, foundry-combat-focus, foundryvtt-simple-calendar, fvtt-party-resources, lib-wrapper, lordudice, permission_viewer, popout, scaleGrid, settings-extender, socketlib, special-dice-roller, splatter, split-journal, torch, weather-control, wfrp4e-gm-toolkit, forge-vtt

Submitted with my old discord info. Can reach me at .cog if needed.

Impossible in what way, do you receive an error when you try?

Yes, I believe its related to the critical wound not "existing" on the serverside of things despite it showing on my sheet until I reload.
Would an error ID be useful?

Can you verify it's still a problem in WFRP 7.0.0?

Looks like the recent update resolved all the issues above! Thank you!

👍 great!


doc how to use the catalog.id pattern in navbar

suggested change to doc

Thank you for pointing this out @robes . I updated navbar-app.md as well to include this information (and links to it) since it isn't as clear where all of the explanations and examples for navbarMenu are.


hugo: 0.139.3 -> 0.140.1 and refacor

Diff: https://github.com/gohugoio/hugo/compare/v0.139.3...v0.140.1
To resolve https://github.com/NixOS/nixpkgs/pull/366419#issuecomment-2560384887

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Failed only in x86_64-darwin
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368072

x86_64-linux

:white_check_mark: 1 package built:

hugo

x86_64-darwin

:x: 1 package failed to build:

hugo

Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
go: downloading github.com/bep/helpers v0.5.0
--- FAIL: TestCommands (0.00s)
    --- FAIL: TestCommands/server__error_recovery_edit_config (6.81s)
        testscript.go:584: # Test the hugo server command when adding an error to a config file
            # and then fixing it. (6.796s)
            > hugo server &
            > waitServer
            > httpget ${HUGOTEST_BASEURL_0}p1/ 'Title: P1'
            > replace $WORK/hugo.toml 'title =' 'titlefoo'
            > httpget ${HUGOTEST_BASEURL_0}p1/ 'failed'
            FAIL: testscripts/commands/server__error_recovery_edit_config.txt:11: timeout waiting for "http://localhost:1313/p1/": response body "<script src=\"/livereload.js?mindelay=10&am
p;v=2&port=1313&path=livereload\" data-no-instant defer></script>Title: P1|BaseURL: http://localhost:1313/|\n" for URL "http://localhost:1313/p1/" does not match "failed"
            [background] hugo server: exit status 0
            [stdout]
            Watching for changes in $WORK/{content,layouts,static}
            Watching for config changes in $WORK/hugo.toml
            Start building sites …
            hugo v0.140.1+extended+withdeploy darwin/amd64 BuildDate=unknown VendorInfo=nixpkgs

                               | EN
            -------------------+-----
              Pages            |  4
              Paginator pages  |  0
              Non-page files   |  0
              Static files     |  1
              Processed images |  0
              Aliases          |  0
              Cleaned          |  0

            Built in 4 ms
            Environment: "development"
            Serving pages from disk
            Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
            Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
            Press Ctrl+C to stop

FAIL
FAIL    github.com/gohugoio/hugo    17.939s
FAIL

aarch64-darwin

:white_check_mark: 1 package built:

hugo

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368072

x86_64-linux

:white_check_mark: 1 package built:

hugo

x86_64-darwin

:white_check_mark: 1 package built:

hugo

aarch64-darwin

:white_check_mark: 1 package built:

hugo

Thank you!


Update Google MaterialIcons unmaintained library with another which is actively maintained

Is your feature request related to a problem? Please describe.
Google's MaterialIcons Github is long unmaintained and would be nice to update it with an actively maintained community git.
Describe the solution you'd like
There's this repo which is updated version of Google's
Main repository: https://github.com/material-icons/material-icons
Font repository: https://github.com/material-icons/material-icons-font

Up! The current MaterialIcons miss some icons that I tried to use, that exists on https://material.io/resources/icons/

was updated in Sept 2022


iOS / iPadOS version

You can't use it like the desktop version, the APIs don't exist to do that, but maybe you could display the timer fullscreen and disable sleep, for folks working on computers where they can't install software

Maybe I could do this with pythonista?

Pythonista has gone without an update since Python 3.5, so I think this is probably a non-starter.

What's up @freakboy3742

@glyph You rang? :-)
Displaying a timer full screen should be fairly straightforward. Toga doesn't have a cross-platform API to disable sleep, but you can access the native API layer without too much difficulty (and I wouldn't be opposed to adding a cross-platform API to expose that functionality).
Beyond that, I'd need to know more about the UI mockup to give advice - but I'm happy to give pointers.

@freakboy3742 This was more of a general ping, like "how should I go about this".  Is there something I could stick in a setup.py to get started quickly?  I don't mind slogging through API docs in order to achieve specific things, but getting an initial build to work (particularly "what the heck do I do for CI") is the part which is hard to get motivated to get through

@glyph If you run the beeware tutorial, you'll get a GUI going; from there (combined with poking around the API docs and examples - especially the handler example, I suspect) you should be able to get something going.
CI is a bit of a hairy story at present. We've got an open ticket to document our CI story (beeware/briefcase#400), but there's two big problems that really need to be resolved first:

Running tests for a GUI app
Signing/App Store submission

Testing GUI apps is A Hard Problem (tm) no matter the platform, and Toga doesn't have a great story for these at present (it's very much on our todo list). The theory is that you should be able to use the "dummy" Toga backend - a full implementation of the Toga internal API that doesn't have any actual GUI manifestation, but exposes APIs that can be manipulated in by a test. The idea is that the Dummy API is the "API ideal", and all the platform backends are tested to confirm that they do the same thing as at the Dummy API - so your end-user app should only need to do a high-level test to confirm that the platform backend is working.
App Store submission is something that isn't currently automated; I'm not even sure if it can be fully automated. Even getting app signing and notarization automated is problematic.
However, if you just want to get a build out of the CI, you can invoke briefcase build in CI - the Briefcase repo does this in its own CI to confirm that apps compile on all platforms and backends.

@glyph If you run the beeware tutorial, you'll get a GUI going; from there (combined with poking around the API docs and examples - especially the handler example, I suspect) you should be able to get something going.

OK, I'll have to run through that when I start getting around to iOS stuff.

CI is a bit of a hairy story at present. We've got an open ticket to document our CI story (beeware/briefcase#400), but there's two big problems that really need to be resolved first:

Running tests for a GUI app
Signing/App Store submission

Testing GUI apps is A Hard Problem (tm) no matter the platform, and Toga doesn't have a great story for these at present (it's very much on our todo list). The theory is that you should be able to use the "dummy" Toga backend - a full implementation of the Toga internal API that doesn't have any actual GUI manifestation, but exposes APIs that can be manipulated in by a test. The idea is that the Dummy API is the "API ideal", and all the platform backends are tested to confirm that they do the same thing as at the Dummy API - so your end-user app should only need to do a high-level test to confirm that the platform backend is working.

I appreciate what you're trying to do here, but I would probably want the ability to at least limp along in CI with a simulator, both to make sure the build infrastructure actually works all the way, and also to test things like interfacing with platform-native facilities which don't have a Toga equivalent (sensors, notifications, and so on).

App Store submission is something that isn't currently automated; I'm not even sure if it can be fully automated. Even getting app signing and notarization automated is problematic.

There are nominally some github actions for this that work "out of the box" on vanilla Xcode projects, but I've had to build my own shell script from scratch even for the Mac versions of this.

However, if you just want to get a build out of the CI, you can invoke briefcase build in CI - the Briefcase repo does this in its own CI to confirm that apps compile on all platforms and backends.

If I did get such a build out of CI (I'm assuming "an unsigned .ipa file"?), would you happen to know enough about the iOS dev workflow to know where I'd put it or what I'd do with it? Xcode seems to get very confused when you want to do stuff with something that isn't "an Xcode project in Swift getting pushed to a real live device", and while I know enough about the innards of what's going on on the Mac in order to get the various command line tools to Do A Thing, I don't know what the equivalent looks like on iOS.

At a high level, that's pretty much it - you get a .ipa file, which then needs to be signed, archived and sent to the App Store. The "vanilla" tools to do this through Xcode are all GUI based, though - I have no idea if there are command line equivalents. I suspect there are... but like all Apple stuff, the command-line equivalents are not well advertised.

There are definitely command-line equivalents, what you want to look at are the man pages for man codesign (invoked as "codesign") and man altool (invoked as "xcrun altool").  But of course they have a million fiddly options and no "test mode" (you're going live to some testflight or app store listing if you run them) so I am not really clear on how you use them because you need a full-fledged app to try.

While looking at the docs for this though I found https://docs.fastlane.tools which probably has some interesting ideas to at least crib from, if not to just use outright


Add cancel order command

Maybe next time have a fulfil order and a cancel order which both extends a removeorder
Add OrderBuilder and TypicalOrders for testing purposes

Set IDs in AddOrderCommand


How to disable a single entry (ideally only for a specific source) from being shown in the problem pane?

I guess that is a question of the linter itself (so VC for MF VC, GnuCOBOL for GC, ...) via -C CHANGE-MESSAGE or -Wno-,,, or - for the included linter (which is about code rules and unused paragraphs/sections) via a linter comment in the source [does this option exist currently?] - but I'm not sure.
It is at least confusing that vscode has an option "Add COBOL lint ignore comment" when it doesn't work,
See https://stackoverflow.com/questions/61821822/vscode-lint-ignore-for-task-output-languages-that-are-not-in-built-into-vscod for a bounty-question on that, which includes a screenshot.
If this extension would have a lint comment option, could we add options to ignore messages with a code (like COBCH1216) via comments in the source [for the complete file / a specific line)?
If not: is it possible to disable the context menu entry that ask for "add ignore comment"?
[ignoring the message on the compiler part or via adjusting the problemMatcher would be possible - but that's not the question here]

I guess that is a question of the linter itself (so VC for MF VC, GnuCOBOL for GC, ...) via -C CHANGE-MESSAGE or -Wno-,,, or - for the included linter (which is about code rules and unused paragraphs/sections) via a linter comment in the source [does this option exist currently?] - but I'm not sure.

To remove a compiler error message, you will as you say have to use a compiler directive, as you say for Micro Focus COBOL using CHANGE-MESSAGE or if you are using a very old compiler HIDE-MESSAGE.
For this extension,  you can turn the linter off via settings, global, workspace and perhaps folder (not checked) or disable each item by itself, you turn off the "unused paragraph linter" itself, you change the severity of the message (default is information_, so it does not appear in the "problems panel" as well but still appear near code that you are editing.
 "coboleditor.linter_mark_as_information": false

```json
"coboleditor.linter_unused_paragraphs_or_sections": false

or

Or include the comment marked in the code.

It is at least confusing that vscode has an option "Add COBOL lint ignore comment" when it doesn't work,
See https://stackoverflow.com/questions/61821822/vscode-lint-ignore-for-task-output-languages-that-are-not-in-built-into-vscod for a bounty-question on that, which includes a screenshot.

The issue the person observed was related to the linter being triggered for non-linter issues and this was resolved a months ago.
Have you tried to get the issue yourself?

Or include the comment marked in the code.

Can you add the options for this in the README please?
And yes: the issue here is solved now, the linter doesn't get triggered any more for error messages parsed from the compiler (so I guess "add linter comment" would work in those cases, now).

and also moving the message away from the problem panel with option below, is very useful if you have a very dirty source code.
 "coboleditor.linter_mark_as_information": false

If you turn the message to "information", it will appear in "error lens", for example, if you install;
https://marketplace.visualstudio.com/items?itemName=usernamehw.errorlens
You can see the message is placed at the side of the linter warning...

Thanks for the hint, that's quite useful - and the source for https://github.com/usernamehw/vscode-error-lens/issues/61. :-)


ChromeWorker fails to load

Hi,
recently the translation of an auto-updating BibLaTeX export began to fail with the error message Translation failed more and more often.
I've uploaded a debug report under the id SBGWDYNF-euc
Thank you so much in advance for looking into it!

Can you upgrade to the latest version and try turning background exports back on to see if matters have improved for you?

Thanks so much for taking care of this! I'm starting to get a sense of the problems you're facing with bugs like this, which makes me all the more grateful for you making such quick work of it.
I'll try during the day (I've been away the past few days so I couldn't try thoroughly) and will let you know!

That's all OK. I've seen the problem now once too but it's unfortunately not reproducable at will. Right now, it tries to get a worker 5 times each time with more time between, and will turn off background exports if that still fails. The kind of failure we're experiencing is not supposed to be possible, but unfortunately the body of expertise that knows why this could fail nonetheless is dwindling fast.

I've built in a retry system, which shouldn't be necessary, but I've not had the problem since. If you do, commenting here will re-open the issue automatically.


Blank Screen after Using Desktop Tweaks

Describe the bug
When applying desktop tweaks and the script is starting, the desktop turns black (sometimes white).
To Reproduce
Steps to reproduce the behavior:

Go to 'Desktop Tweaks'
Click on 'untick Numlock at Startup, tick Remove Microsoft Store Apps, tick Remove OneDrive, then run tweaks'
Scroll down to 'No scrolling needed'
See error

Expected behavior
All the desktop icons disappear including backround picture, taskbar etc.  But the script/winutil will still continue to run and end succesfully.
I can then close the utility and powershell and have to use a restart shortcut, in order to restart the PC.
Screenshots
I don't have screenshots.
Additional context
Some side notes:

Fresh Windows Home, Version 10.0.19045 Build 19045 installation.

Drivers and Updates up to date

Did a little tweak before running WinUtil. I disabled the visual effects in windows. How to disable visual effects: Type 'system properties' in search -> click 'advanced system settings' on the right -> under the advanced at 'performance', click 'settings' -> under 'visual effects' click 'adjust for best performance'. Finished!
Im not 100% sure if I used the tweak before or after using winutil, but usually when using winutil I do it before it. I think its still worth noting it, because maybe this caused the blank screen?

Latest 64x and 86x visual c++ redist installed

Thanks for your attention!

after this happens just press Ctrl+Shift+Esc and launch a new proccess called explorer

Thanks for your tipp,. So did you experience the same issue? I guess explorer might freak out when using winutil and thats why I see a blank screen...

yeah its because you are Microsoft and Onedrive, Onedrive utilizes Explorer

Allright, thats good to know. When speaking about Onedrive, lately it doesnt actually remove onedrive... I still see it under Apps. Have to uninstall it manually then.

Allright, thats good to know. When speaking about Onedrive, lately it doesnt actually remove onedrive... I still see it under Apps. Have to uninstall it manually then.

yep, microsoft is being microsoft and preventing us from touching certain registry keys, as well as not removing certain artifacts of the program after uninstall. a fix is being thought of but its becoming more and more clear that microsoft is roadblocking a lot of tweaks


DO NOT MERGE! Fast Forward stable to d0f891621a001256bb4673f5861aeb31cc29f82c.

This PR will be merged automatically once checks are successful.

This change is

Jenkins job mixer/postsubmit passed


pcli: add asset denom to error output when syncing asset registry

After merge of #283, penumbra is no longer a valid base denomination (in favor of upenumbra). This causes an error when syncing (discovered by @plaidfinch):
Error: invalid asset denomination: penumbra

This PR just adds debug output for the future to display which asset denom is invalid

Thanks, LGTM!


Added missing getattr dunder methods for mixed model

Hello, PEFT team!
I tried to use the new interface for MixedModel and discovered that the current implementation of PeftMixedModel and MixedModel lacks getattr dunder methods (so we cannot use corresponding underlying implementations for e.g. device).
This PR just adds these missing methods.

@younesbelkada @pacman100 your review is kindly requested!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Child with MinWidth, Flex and Wrap lays outside of parent boundary

Thanks for an amazing library, I have run into a small issue when using flex wrap and having a single item in a row that has its flex attribute set.  Just before the item wraps there's a point where it's layout is outside the layout container bounds.  I've narrowed it down to layout.computedFlexBasis being 0, and the following line doesn't break...but don't know the inner workings well enough...
if (sizeConsumedOnCurrentLine + outerFlexBasis > availableInnerMainDim && isNodeFlexWrap &&
        itemsOnLine > 0) {
      break;
    }

The assertion will happen when i (the width) is 119... In which case the item being laid out will have a left of 119 and a width of 20, putting it out of bounds... (It does get worse when the width is 110, the Right will be at 130.  This is because i've set a minimum width).
I hope my test code is enough to demonstrate the problem, and if i'm making some wrong assumption, please correct me!  (If there is no minimum width there isn't an issue, its the minimum width that's pushing it outside the bounds.)
        YGNodeRef container=YGNodeNew();
        YGNodeStyleSetFlexDirection(container,YGFlexDirectionRow);
        YGNodeStyleSetFlexWrap(container, YGWrapWrap);

        YGNodeRef itemA=YGNodeNew();
        YGNodeStyleSetWidth(itemA, 100.f);
        YGNodeStyleSetHeight(itemA,25.f);
        YGNodeInsertChild(container, itemA, 0);

        YGNodeRef itemB=YGNodeNew();
        YGNodeStyleSetWidth(itemB, 100.f);
        YGNodeStyleSetHeight(itemB,25.f);
        YGNodeStyleSetMinWidth(itemB, 20.f);
        YGNodeStyleSetFlex(itemB, 1.f);

        YGNodeInsertChild(container, itemB, 1);

        for (int i=200;--i>=50;)
        {
            YGNodeCalculateLayout(container, i, 200.f, YGDirectionLTR);
            printf("Width:%d - (Flex Item B Left:%f Top:%f Width:%f Height:%f)\n",i,YGNodeLayoutGetLeft(itemB),YGNodeLayoutGetTop(itemB),YGNodeLayoutGetWidth(itemB),YGNodeLayoutGetHeight(itemB));
            // will assert from 119-100
            assert(YGNodeLayoutGetLeft(itemB)+YGNodeLayoutGetWidth(itemB) <=i);
            // assert(YGNodeLayoutGetRight(itemB) <=i); // doesn't work GetRight == 0
        }

@Jaydee2190 Thanks for reporting this! Could you provide a test fixture (https://github.com/facebook/yoga/tree/master/gentest/fixtures) which demonstrates this bug? We prefer using test fixtures for these bugs as they validate the correct behavior using the browser.

Looks like #262

@woehrl01 yes, sorry, somehow I missed your issue when I browsed through.  It is the same problem. I'll close this issue.

I have  the same problem . how to solve this problem.  My code
<com.facebook.yoga.android.YogaLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
xmlns:yoga="http://schemas.android.com/apk/res-auto"
android:id="@+id/root"
android:layout_width="match_parent"
android:layout_height="wrap_content"
yoga:yg_flexDirection="column"
yoga:yg_alignContent="center"
yoga:yg_wrap = "wrap"
yoga:yg_paddingRight = "1dp"
yoga:yg_paddingLeft = "1dp"
yoga:yg_paddingTop = "1dp"
yoga:yg_paddingBottom = "1dp"
>


Add support for Alpine Linux based PHP & Nginx images

Add alpine images for php 5.6, 7.0 and 7.1. Reduces image size by ~100MB
Support dynamic dockerfile for PHP images. Makes adding new versions easier
Update tests to handle new images

Merged into Develop, thanks for your help @skwashd