Fix multi-arch Quay images

Description
This PR fixes how we process multi-arch Quay images for tools and adds multi-arch Quay support for workflows and GitHub app tools.
Background
There are two ways of creating multi-arch images (source):

Using docker manifest:

Individual images are built and pushed to the registry for each architecture. These images are then combined in a manifest list which references each architecture image's digest, and this resulting image is also pushed to the registry.
https://quay.io/repository/openshift-release-dev/ocp-release?tab=tags is a repo with multi-arch images built using this method. For each multi-arch image, there are individual images for each architecture.

4.12.0-0.nightly-multi-2022-08-22-190530 is the multi-arch image
4.12.0-0.nightly-multi-2022-08-22-190530-aarch64, 4.12.0-0.nightly-multi-2022-08-22-190530-s390x, 4.12.0-0.nightly-multi-2022-08-22-190530-ppc64le, 4.12.0-0.nightly-multi-2022-08-22-190530-x86_64 are the individual architecture images
If curious, copy the tag name of one of the multi-arch images, like 4.12.0-0.nightly-multi-2022-08-22-190530, and paste it into the search bar on the top right to filter the tags. You will see multiple images show up.

Using docker buildx

This is the simple way to create multi-arch images. Using one docker buildx command, the multi-arch image is built without needing to build and push individual images for each architecture.
https://quay.io/repository/skopeo/stable?tab=tags is a repo with multi-arch images built using this method. Notice how each multi-arch image does not have any images for each architecture.

To check, copy the tag name of one of the multi-arch images, like v1.9.2, and paste it into the search bar on the top right to filter the tags. Only one image should show up, which is the multi-arch image.

A previous PR https://github.com/dockstore/dockstore/pull/4753 added multi-arch Quay support for tools. The implementation only considered multi-arch images created using method 1 (docker manifest). This PR adds support for multi-arch images created using method 2 (docker buildx).
This PR also adds multi-arch Quay support for workflows (regular and GitHub apps) and GitHub app tools. I made several QuayImageRegistry methods public and refactored them a bit so that LanguageHandlerInterface can re-use them when processing images for workflows and GitHub app tools to reduce duplication.
Side tangent
Now that I think about it, we might not be handling multi-arch DockerHub images correctly for tools because those two methods of creating multi-arch images are not unique to Quay. The problematic case is the docker manifest multi-arch image. We might be creating a Tag for the multi-arch image and also a Tag for each individual architecture image. If that's the case, we will need to keep a cleanDockerHubTagList like we do for Quay. Will investigate and create a separate ticket if it's an issue.
Issue
SEAB-3928
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future

Will investigate and create a separate ticket if it's an issue.

:+1:
For the issue, we should also investigate if we can write a script to find out if we're running into cases of bioinformatics tools using one of these two methods to see how widespread the issue is. I think we ran into general software engineering repos in our tests on quay.io first that use these types of images.

Now that I think about it, we might not be handling multi-arch DockerHub images correctly for tools because those two methods of creating multi-arch images are not unique to Quay. The problematic case is the docker manifest multi-arch image. We might be creating a Tag for the multi-arch image and also a Tag for each individual architecture image. If that's the case, we will need to keep a cleanDockerHubTagList like we do for Quay. Will investigate and create a separate ticket if it's an issue.

I investigated and this is not a problem for DockerHub images used in tools because Docker Hub tools can only be registered in Manual build mode, thus users have to individually add each tag for the the registered tool.
If a user adds a tag in the UI for a multi-arch image, then this creates a Tag containing an Image for each architecture, as expected. It does not create a Tag for each individual architecture image. The user can choose to add a tag for an individual architecture image that was used as part of the docker manifest multi-arch image, but that's not something we can control.
We are handling multi-arch DockerHub images correctly for tools, so I'm not gonna create a separate issue.

Thanks for looking into the Docker Hub aspect, that sounds about right.
One part I wonder about, we don't talk to the Docker Hub api, but we do gather checksums from Docker Hub (and quay.io)
Is that functionality affected by the two types of multi-architecture images at all? https://docs.dockstore.org/en/stable/advanced-topics/checksum-support.html?highlight=checksums#docker-image-checksum-support

One part I wonder about, we don't talk to the Docker Hub api, but we do gather checksums from Docker Hub (and quay.io)

We actually do use the Docker Hub API (tools and workflows). We don't use the specific registry API for Amazon ECR and GitHub Container Registry because their specific APIs require authentication. For Amazon ECR and GHCR, we use the Docker Registry HTTP API which is implemented in DockerRegistryAPIHelper.

Is that functionality affected by the two types of multi-architecture images at all? https://docs.dockstore.org/en/stable/advanced-topics/checksum-support.html?highlight=checksums#docker-image-checksum-support

The functionality should not be affected by the two types of multi-arch images because we create the Image by first getting the image's Docker manifest here which is used to detemine if the image is a multi-arch image. If the manifest is a manifest list, then the image is multi-arch. Both types of multi-arch images will have a manifest list and each manifest within the list contains a digest that corresponds to the digest of an architecture image. For Quay, we also get the architecture image digest using the manifest list (except we use Quay's manifest API) and the logic is similar.
Docker Hub is neat because we don't need to check the manifest list for a multi-arch image. The Docker Hub response for a tag contains information about each architecture image.


Defaulting to bussines_unit_id and created_by_user_id doesn't work when creating new version

Tested on version 0.0.5.
This is how SDK tries to get it: https://github.com/FiniteStateInc/finite-state-sdk-python/blob/a046c31c04f31fa29a14cec790f7d427f474688c/finite_state_sdk/init.py#L295
And here's the returned object.
[
    {
        '_cursor': '{"id":"<id>"}',
        'id': '<id>',
        'name': 'test ',
        'createdAt':
        '2023-06-20T08:28:03Z',
        'ctx': {
            'asset': '<id>',
            'businessUnits': ['<id>'],
            'products': ['<id>']
        }
    }
]

Please fix getting business unit and add user_id.
P.S.
https://github.com/FiniteStateInc/finite-state-sdk-python/blob/a046c31c04f31fa29a14cec790f7d427f474688c/finite_state_sdk/__init__.py#L280
This assumes this will return only one asset. Please validate if there is in fact only one object returned.

Thank you for reporting this.
The method you referenced is create_new_asset_version_artifact_and_test_for_upload, which will just return a Test id. Did you mean to reference another location?
It seems like you might want one of the other SDK methods to return the User id?
RE: Line 280
This is correct - it it getting only a single asset for the create_new_asset_version_artifact_and_test_for_upload method. I do see that it should be checking that asset_id is specified before that, and it is a little unclear because it calls get_all_assets but that method will only return one object if the asset_id is specified. I'll try to make that more clear.

I opened a PR to work on this, here: https://github.com/FiniteStateInc/finite-state-sdk-python/pull/7
I took a guess that you might be referring to the get_all_assets is not returning the createdBy user, so I added that in a few of the queries, and also the __typename for some queries.

I see it, now. Sorry, adding the group to the query and fixing the code that references it.

Tested and it's working as expected now.
Thank you @nickvido for quick response!


[bug]When clicking on MetaMask to connect your wallet the Coinbase browser extension also pops up

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
^0.2.17
Current Behavior
When clicking on MetaMask to connect your wallet the Coinbase browser extension also pops up.
If you have the CoinBase wallet extension downloaded just like MetaMask it opens up when you click on MetaMask as your chosen provider for connection. However, when you click on CoinBase as your chosen wallet provider MetaMask doesn't open up as it should. So the problem is only when you click on MetaMask the CoinBase wallet extension pops up when it shouldn't because I clicked on MetaMask, not CoinBase.
I first noticed this within my app but then went back to docs to see if I was missing something but noticed it also happens within the docs in the connect wallet guide section (https://wagmi.sh/guides/connect-wallet).
Expected Behavior
The expected behavior should be when I click on MetaMask to connect my wallet only the MetaMask extension should popup and not any other wallet provider extension.
Steps To Reproduce
Download the CoinBase wallet extension got to the docs here : https://wagmi.sh/guides/connect-wallet
Click on MetaMask then watch both MetaMask and CoinBase wallet extension pop up
CoinBase Extension Download https://chrome.google.com/webstore/detail/coinbase-wallet-extension/hnfanknocfeofbddgcijnmhnfnkdnaad?hl=en
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://wagmi.sh/guides/connect-wallet
Anything else?
Browser: Google Chrome Version 99.0.4844.74 (Official Build) (x86_64)
MetaMask Version: 10.11.1
CoinBase Version: 2.10.3
WAGMI Version: ^0.2.17

This is a limitation of injected wallets. There's not way to differentiate which injected wallet you are making a request to.

This is a limitation of injected wallets. There's not way to differentiate which injected wallet you are making a request to.

Thanks for the feedback yea I figured this also as I see the problem with all dapp's.

@tmm @SonnyCastro There is actually a way to differentiate at least MetaMask and Coinbase Wallet.
If only MetaMask is installed, you normally use window.ethereum as a provider. If there's also Coinbase wallet installed same time, using the usual window.ethereum will open both as mentioned above. But in this case, there's also window.ethereum.providers which is an array of providers and you can find the correct one for MetaMask only by looping the array and checking which item has isMetaMask property.
So to prepare for having both wallet extensions installed, for Coinbase use all the usual methods but for MetaMask first check if the providers array exists and if yes, find the right one there.
I can look into making a PR for this, if you're keen to have an additional connector that guarantees that only MetaMask will be opened.

@adbario interesting! thanks dropping the knowledge.

No problem at all.
Here's a quick example that I've used before to make sure only MetaMask fires up, in case someone want's to play around with the idea.
function getProvider() {
  const { ethereum } = window as any;

  if (ethereum?.isMetaMask) {
    if (ethereum?.providers) {
      return ethereum.providers.find(
        (provider: InjectedProvider) => provider.isMetaMask
      );
    }

    return ethereum;
  }
}


feat(functions/helloworld_storage): initial commit

The tests for this depend on https://github.com/GoogleCloudPlatform/php-tools/pull/91.
Change Summary

Adds functions_helloworld_storage sample, canonical for CloudEvent functions.
Solves unit testing log output by defining the stream as a global and swapping it out with php://memory in the test.
There are four test classes:

SampleUnitTest: Self-contained implementation for functions_storage_unit_test
SampleIntegrationTest: Self-contained implementation for functions_storage_integration_test.
IntegrationTest: php-tools based implementation, cross-checks the system tests and provides canonical implementation for CloudEvent functions that do not host a sample test.
DeployTest: Canonical deployment test for CloudEvent functions.

Emergent Patterns

Suggests standardizing on $log variable for stream name where we use fwrite() to create logs.
DeployTest includes two helpers: triggerStorageUpload() and processFunctionLogs() that may be worth considering for inclusion in CloudFunctionDeploymentTrait.
Realized Functions Testing guide & samples use different test naming. To avoid confusion, we should follow-up with rename of SystemTest classes to IntegrationTest.

DeployTest includes two helpers: triggerStorageUpload() and processFunctionLogs() that may be worth considering for inclusion in CloudFunctionDeploymentTrait.
Realized Functions Testing guide & samples use different test naming. To avoid confusion, we should follow-up with rename of SystemTest classes to IntegrationTest.

Agreed on both. @grayside mind creating GitHub issues (or PRs) for these (for tracking purposes)?

I will file issue follow-ups once this gets a bit further through review by @ace-n and @bshaffer

Various minor fixes, and deletes the created Cloud Storage object at the end of the test.

This will not pass CI testing until the branch is updated after #1215 lands.


Looking for test network.

Can you implement the function named decode_output? I wanna see the the final result.

And the trained masks are all rectangles... I don't know. Maybe I get the wrong masks.

@mxmxlwlw  after training the model, how to test? could you please shed some light?

@Sharathnasa I've changed some code. But I don't know if I get these right. And the result of my testing is not good. So maybe my changing isn't right. It's better to wait the update.

From my experiments you have to first update your code with that PR #50. Hopefully @CharlesShang  will have time to review and merge it ASAP..
I've validated that the RPN component is working with that fix. I will start reviewing rest of the architecture in the next few days..

@amirbar Nice, looking forward to your work!

@amirbar can you please explain what have you commented out? Did you commented the whole pipeline from RPN component onwards.Thank you.

@amirbar Have you got it work now?


register sqlite driver

fixes #80

oh boy +3M lines :flushed:

I think we still need it though as this would be a regression to drop support for RPMDBs where it was working fine in 0.2.0 :persevere:


Autocomplete: Correct summary for Strict

Description
Correcting a small typo.
How Has This Been Tested?
No need
Types of changes
Edited summary of Autocomplete Strict property

Checklist:

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[X] I've added relevant tests.

This is my first PR ever, and I figured this small correction would be a nice way for me to see how it is done :)
Please do let me know if something is not according to the book.


Text in Spanish Needs Formatting

Some texts in Spanish need formatting, for example on the following page, it is bold, when it should be standard text:

corregido via PR por Rvergara13


Fix tests

Changelog / Overview

Fix some tests, and cleanup some.
Motivation
#1556 brought in parallelization of tests which in a way brings new problems with tests. This PR tries to fix those.
Testing Status
Local pass, windows.
Further Comments
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[ ] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

I will merge this now so that the tests are fixed; further polishing can take place in a follow-up PR. (Sorry if this feels rushed, @huguesdevimeux )


lib.types.functionTo type merging and docs

Description of changes
Support type merging and docs in functionTo.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I've polyfilled it where I need it, and 21.11 is almost eol. That makes the backport seem a bit unnecessary, so I'll skip it unless something changes.


Identify if hip-clang compiler is used while hipify

This PR identifies if the compiler is hip-clang before hipifying APEX. There are some hip-clang specific source conversions which can be enabled with this flag passed to hipify(...) call

I'm assuming hip_clang_launch is already a kwarg for hipify?

Shouldn't this be pushed down into hipify itself, rather than asking callers of hipify to add this check?

It is a kwarg in hipify call
Pushing it to hipify is a better solution. I think it was left as is to experiment when we had hcc and hip-clang. I can try that on pytorch side and that will eliminate the need for this PR

The fix to add parenthesis around kernel name has landed on upstream. Will close this PR here and we will get the part done correctly in pytorch itself


[NEW] Add multi language support to app

@RocketChat/android

Closes #747
Changes

@filipedelimabrito Since some of string.xml files are not updated so I have tried with 5 languages. I will make PRs to update them very soon

@filipedelimabrito PR is completed from my side. Pls review
Currently we are available in 5 languages. I will send PR to support other languages as soon as the string files got updated

Is anything missing? @filipedelimabrito  pls review

@filipedelimabrito  Sure, I will move the string.xml file updates to another PR and will do the requested changes here 👍

@GOVINDDIXIT Setup your IDE with the official Kotlin coding style.

@filipedelimabrito  Done! Thanks 😃

@filipedelimabrito pls review

@filipedelimabrito Pls review. Is anything more need to be done in this PR 😃

@filipedelimabrito Updated! Need help in fixing these tests, the app is working totally fine on local machine

@filipedelimabrito updated! Pls review.
Earlier, I forgot to push one file that is why builds were failing😅

@filipedelimabrito I have updated the PR. Pls review

@filipedelimabrito  The PR is complete from my side, Pls review

I've fixed it all the things to be done here.
It will be closed from https://github.com/RocketChat/Rocket.Chat.Android/pull/2262
Thanks!


System tests should use a function

Many system tests use a pattern like
… | tee /dev/stderr | (sponge ||:) | grep -q …

(or -qv in the last step).
This should be turned into a function to avoid all the repetition and to simplify changes such as #344.

This seems like a good idea, in particular if we're extending or changing the system tests, but I don't think we have any current plans to do so. We should remember this and revisit it if we change the system tests.


Fix broken pixel in ray tracing tests

The issue seem to be not reproducible on the latest drivers.

We will reopen the issue if the problem happens again.


ARROW-10: Fix mismatch of javadoc names and method parameters

@jacques-n Would mind taking a look please? Thanks.

Looks reasonable. Can you rebase and make sure that commit message is of format "ARROW-10: ..." like other commits?

Rebased and re-committed with message of format "ARROW-10: ..."; sorry for the inconvenience caused earlier. Would you take a another look please? Thanks.

@jacques-n @proflin Would this be better if org.apache.arrow.memory.BufferManager.java#L45 and org.apache.arrow.memory.AllocationManager.java#L330-L331 are filled up?
I don't want to make a PR for them if the documentation stuff can be dealt with here.

@HyukjinKwon comments addressed. Thanks!

Sorry for cross commenting, but can we add a getting started doc?

+1


Not installing on Linux Mint 17.3 (Ubuntu 14.04 LTS)

node version 6.2
npm version 3.9
Here is log.
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/ryan/local/black-screen/node_modules/.bin:/usr/bin:/home/ryan/PostgreSQL/9.5/bin:/home/ryan/pypy-5.1.1-linux64/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/home/ryan/anaconda3/bin:/home/ryan/cloned/pyscreen/copysc/:/home/ryan/local/bin
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/ryan/local/black-screen
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c',
11 silly lifecycle   'npm run compile && npm run watch-tsc | npm run watch-scss | npm run electron' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: `npm run compile && npm run watch-tsc | npm run watch-scss | npm run electron`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:245:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:24:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:850:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /home/ryan/local/black-screen
17 error Linux 3.19.0-32-generic
18 error argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
19 error node v6.2.0
20 error npm  v3.9.2
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: `npm run compile && npm run watch-tsc | npm run watch-scss | npm run electron`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'npm run compile && npm run watch-tsc | npm run watch-scss | npm run electron'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the black-screen package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     npm run compile && npm run watch-tsc | npm run watch-scss | npm run electron
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs black-screen
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls black-screen
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

@rv816 because, currently only OS X is supported, please read install section

@rv816 Try something like:
npm run compile
npm i -g electron-packager
electron-packager . "$npm_package_productName" --overwrite --platform=linux --arch=x64 --version=$npm_package_electronVersion --out='ReleaseLinux' --icon='./icon.png'
Work on Ubuntu 16.04.


Align network/private-dns-zone to AVM specs

https://github.com/Azure/bicep-registry-modules/pull/579 -Merged


fix(JSON RPC): Prevening processing of duplicate entries

:tada: This PR is included in version 1.8.13 :tada:
Your semantic-release bot :package::rocket:


Provide better explanation of SV caller results, especially for cnvkit and ensemble results

At the moment the two svcaller lumpy and delly export VCF files which are easily interpretable. However, this is less so for the post-processed cnvkit results and the SV ensemble results. I would therefore like to ask for a brief documentation of these result, even if the corresponding bcbio modules are not finalized yet.
In particular, for cnvkit, bcbio generates a bed file SAMPLENAME-cnvkit.bed of the row format:
chr start end sample_name comma_delimited_integers comma_delimited_gene_symbols

This file can be considered to be the primary output of cnvkit in this context since it is the only one with gene symbol annotation. However, of these fields, the comma-delimited integers are not easily interpretable - they may be absolute integer CNV calls, number of probes, or anything. A short documentation would be very helpful here.
Second, for the ensemble results, again the output of delly and lumpy are easily interpretable (deletions, inversions, duplications etc). However, the cnvkit results of the form cnv1_cnvkit are harder to interpret. Are these absolute integer CNV calls?
Last, the ensemble voting scheme and notation is not totally clear to me. For instance, for a file SAMPLENAME-sv-ensemble.bed:
11	47644328	47647227	DEL_delly,DEL_lumpy	MTCH2
12	6933235	6933351	DEL_delly,DEL_lumpy	GPR162
12	104379503	104380725	DEL_delly,DEL_lumpy	TDG
19	55450664	55494642	INV_lumpy	CTC-550B14.1,CTC-550B14.8,NLRP2,NLRP7
2	179315136	179315692	DEL_delly,DEL_lumpy	PRKRA
22	21562926	21983679	cnv1_cnvkit	BCRP6,FAM230C,GGT2,HIC2,KB-1183D5.14,KB-1183D5.16,KB-1183D5.9,PI4KAP2,POM121L8P,PPP1R26P5,RIMBP3B,RIMBP3C,RN7SKP221,RN7SKP63,SCARNA17,SCARNA18,TMEM191C,UBE2L3,YDJC,snoU13
5	140563540	140573621	DEL_lumpy	PCDHB10,PCDHB16,PCDHB9
5	178139360	178311022	INV_lumpy	AACSP1,RP11-21I4.2,ZNF354A,ZNF354B
6	31963925	32012367	cnv1_cnvkit	AL645922.1,C4A,C4A-AS1,C4B,C4B-AS1,CYP21A1P,CYP21A2,STK19P,TNXA,TNXB

I see some regions being a consensus of two callers while other regions only have one caller to speak for. Since the original results of the single callers seemed to include more regions, how is the selection shown here being made if not by voting (eg., 2 of 3)? And if by voting, how are integer CNV calls (if that is what they are) compared to structural events like deletions, inversions, duplications - are all duplications to expect to increase the integer ploidy call and all deletions expected to decrease that call, and regions are only reported if these calls are consistent across a majority of callers? If so, is the zygosity of SV events in the VCFs considered when doing these computations?

Sven-Eric -- sorry for any confusion with this. I added additional documentation about structural variant calling and details about the ensemble method:
https://bcbio-nextgen.readthedocs.org/en/latest/contents/pipelines.html#structural-variant-calling
To answer your specific questions:

The integers reported for CNVs are the predicted copy numbers. These also get passed through to the ensemble representation.
The ensemble caller is really simple and is meant as a flat representation that is easy to interpret. The algorithm is to pick calls with support from 2 or more callers for small (<2kb) events and keep larger events. This validated best in our methods without getting into anything more complicated. This does not consider genotyping from the SV events and treats CNVs < 2 as deletions and CNVs > 2 as insertions/duplications.

Hope this helps with understanding the implementation. Let us know if anything else needs additional clarification.

Great, that helps a lot! I really appreciate the effort. However, I still do not understand the list of comma-delimited integers in the cnvkit output SAMPLENAME-cnvkit.bed. The entries are of the form:
11	54778990	62299974	SAMPLENAME	3,9	CCDC86,CD5,CD6,CLP1,CNTF,CPSF7,CTD-2331C18.5,CTD-2531D15.4,CTD-2531D15.5,CTD-3051L14.13

Could you clarify this last bit (the 3,9) for me, Brad? Thanks.

Sven-Eric -- definitely, I added this to the docs as well. These are regions where there are multiple overlapping calls that get merged into one region. In this case you have amplifications of 3 and 9 predicted within the overall region. Typically these are more complex regions with a lot going on so it's hard to resolve clean breakpoints for events. Hope this helps.

Alright, in that case: bonus question! How come that I have 51 regions in SAMPLENAME-cnvkit.bed, each of which longer than 2kbp, and only 2 of them made it into SAMPLENAME-sv-ensemble.bed? Is thery any additional filtering going on? Sorry for being that nitpicky - I'm fine with it not being the perfect, gold-standard do-it-all SV ensemble tool, I just want to understand your reasoning.

Sven-Eric -- not at all, I really appreciate the feedback. Structural variant calling is a lot more difficult than small variant calling, so documenting and improving what we have is exactly the goal of making this available.
I added some additional documentation about the filtering done during ensemble calling. We also remove calls that fall into low complexity regions or high depth regions. The latter are a significant source of false positives for CNV calling, since coverage does look out of whack there but it it more likely due to mapping issues rather than a real event. Tumor/normal comparisons help filter some of these since both will have the spurious event, but if this is a single sample these might be what you see removing them. You can look in the structural/*/ensemble directories to get a sense of what filters remove your calls. If you notice anything confusing/worrying at all happy to dig into it more. Thanks again.

As a late request, it would be very useful if the zygosity of the SV calls as determined by the non-CNV callers could also be reported in SAMPLENAME-sv-ensemble.bed. For CNV-callers, this is implicitly done by the copy number value itself. For the other SV-callers such as lumpy and delly, these seem to report the GT of the SV in their respective VCF files (0/0: hom ref, 0/1: het, 1/1: hom alt) . While homozygous SVs are rare, it does happen, and it would be relevant if the SV callers agree not only on the type and position of the SV but also on the zygosity, IMO.

Sven-Eric;
We haven't started to explore genotype calling as part of the Ensemble/summarization work in bcbio. We could report this through but we don't have any benchmark sets to evaluate how good/bad we're doing. Additionally, given the current state of SV benchmarks, which I'd like to be more sensitive and specific, I'm not sure adding an extra layer of complexity on top is the best idea. The ensemble/summarization is more to identify regions of interest, then you can dig in and compare genotype calls for potential regions of interest. Hope this helps explains my current thinking on this after the validation work.

Thank you, that was very insightful. I fully agree that it only makes sense to include information if there is some measure of reliability of the data, so excluding ploidy seems to be the safest way for now.


imp: add 08-wasm to top level simapp

Description
This PR adds the 08-wasm module to the top level simapp. In a followup pr, I will remove the 08-wasm specific workflows, as the top level simapp should be reusable. In a pr after that, I will remove the binary logic in the 08-wasm module. The idea is that we should be able to build a single simapp for all our modules, even those with separate go.mod's, without introducing unnecessary dependencies into our individual go.mod releases
My only uncertainty with using a single binary, is building images for wasm tags. We need the workflow to take a branch, and build from there. Then updating the go version for a wasm release would mean bumping the simapp ibc-go version
ref: #7445

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

ah seems it won't be possible to split up this work, back to my original pr!


Enable users to customize BTP Operator secret and configMap

Description
We will allow to modify and keep user modifications in the btp-manager-secret.
Reason
Users wants to migrate btp-operator resources and configurations from one k8s cluster into new Kyma cluster.
AC:

[x] 1) support label on our btp manager secret sap-btp-manager to skip reconciliation. If secret deleted then reconciliation is back.

[x] 1.1) In the BTP manager plutono add dashboard about number of skipped, and be able to see a list of ShootName from those skipped ones

[ ] 2) if sap-btp-manager secret is changed, immediately reconcile btp-operator

[ ] 2.1) CM modification is not visible to the btp-operator-controller pod. Only restart of the pod will load it again
[ ] 2.2) Secret sap-btp-operator-clusterid is always created and INITIAL_CLUSTER_ID from it is always in use. When pod will restart from 2.1 then btp-operator-controller will fail to start because  CLUSTER_ID from CM != INITIAL_CLUSTER_ID from secret. panic: ClusterID changed, which is not supported. Please redeploy with --set cluster.id=test_cluster_id goroutine 1 [running]: main.main() /workspace/main.go:140 +0x1d65
[ ] 2.3) TODO in the BTP-Manager: if user changes CLUSTER_ID in the btp-manager-secret then BTP-Manager deletes a secret sap-btp-operator-clusterid, checks if CM: sap-btp-operator-config has new CLUSTER_ID set, restart sap-btp-operator-controller-manager-58fbb647ff-72ckx pods, checks if sap-btp-operator-clusterid is back with new INITIAL_CLUSTER_ID.

[x] 3) E2E integration test, ticket: https://github.com/kyma-project/btp-manager/issues/921
[ ] 4) docs
[ ] 5) RNs

Agreed label name:

kyma-project.io/skip-reconciliation: 'true'

NOTE!:

I changed manually CLUSTER ID in our secret, then config map was having it but still instances were created with previous previous CLUSTER ID, see code: https://github.com/SAP/sap-btp-service-operator/blob/9cebc45aded4d8b58396f913720168b0d1307f73/main.go#L208

AC:
...

[x]  3) E2E integration test, ticket: End-to-end (e2e) integration test for customizing BTP Manager input secret #921

PR with the e2e test: https://github.com/kyma-project/btp-manager/pull/935

@ukff see the following code to understand management_namespace config:
https://github.com/SAP/sap-btp-service-operator/blob/cca53330710b7c662001ac10e35f91016c27887d/internal/config/config.go#L19
https://github.com/SAP/sap-btp-service-operator/blob/cca53330710b7c662001ac10e35f91016c27887d/internal/utils/sm_utils.go#L19


Failed to build to android module of flutter_plugin_android_lifecycle

Steps to reproduce
description: "A new Flutter project."
publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1
 Using Android Studio Koala Feature Drop | 2024.1.2 Patch 1 built on September 12, 2024
 Windows 10 system
 Flutter version: 3.24.3 stable
environment:
  sdk: '>=3.5.3 <4.0.0'
dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^1.0.8
  platform: ^3.1.5

  flutter_bloc: ^8.1.6
  equatable: ^2.0.5
  rxdart: ^0.28.0
  #
  google_fonts: ^6.2.1
  font_awesome_flutter: ^10.7.0
  line_icons: ^2.0.3
  material_design_icons_flutter: ^7.0.7296
  #
  csv: ^6.0.0
  #
  flutter_localization: ^0.2.2
  #
  pin_code_fields: ^8.0.1
  sms_autofill: ^2.4.0
  #
  #  firebase_auth: ^5.1.4
  #  firebase_core: ^3.3.0
  #  google_sign_in: ^6.2.1
  #
  #  flutter_webview_plugin_ios_android: ^0.3.13+12
  #
  faker: ^2.2.0
  #
  platform_info: ^5.0.0
  package_info_plus: ^8.0.2
  device_info_plus: ^10.1.2
  #
  fluttertoast: ^8.2.8
#  another_flushbar: ^1.12.30
  #
  bubble_showcase: ^1.1.0
  cached_network_image: ^3.4.1
#  image_cropper:
  image_picker: ^1.1.2
  file_picker: ^8.1.2
  flutter_colorpicker: ^1.1.0
  duration_picker: ^1.2.0
  #
  animations: ^2.0.11
  animate_to: ^0.1.0
  animated_text_kit: ^4.2.2
  #
  permission_handler: ^11.3.1
  shared_preferences: ^2.3.2
  http: ^1.2.2
  internet_connection_checker_plus: ^2.5.2
  url_launcher: ^6.3.0
  #
  url_strategy: ^0.3.0
  timeago: ^3.7.0
  translator: ^1.0.0
  #
  intl: ^0.19.0
  uuid: ^4.5.0
  collection: ^1.18.0
  fast_immutable_collections: ^10.2.4
  #
  reorderable_grid_view: ^2.2.8
  scrollable_positioned_list: ^0.3.8
  #
  sqflite: ^2.3.3+1
  #  sqflite_common: ^2.5.4
  #  sqlite3: ^2.4.3
  #
  carousel_slider: ^5.0.0
  skeletonizer: ^1.4.2
  fancy_shimmer_image: ^2.0.3
  flutter_spinkit: ^5.2.1
  #
  path_provider: ^2.1.4
  path: ^1.9.0
  lottie: ^3.1.2
  geolocator: ^13.0.1
  geocoding: ^3.0.0
  #
  app_settings: ^5.1.1
  rate_my_app: ^2.2.0
  store_redirect: ^2.0.2
  feedback: ^3.1.0
  #  Range Slider
  syncfusion_flutter_core: ^27.1.50
  syncfusion_flutter_sliders: ^27.1.50
  syncfusion_flutter_charts: ^27.1.50
  syncfusion_flutter_xlsio: ^27.1.50
  #
  flutter_local_notifications: ^17.2.3
  flutter_timezone: ^3.0.1
  timezone: ^0.9.4
  flutter_slidable: ^3.1.1
  #
  flutter_background_service: ^5.0.10

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^4.0.0
flutter:
  uses-material-design: true
    id "com.android.application" version "8.1.0" apply false
    id "org.jetbrains.kotlin.android" version "1.8.22" apply false
    distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip

Expected results
unable to build andriod module
Actual results
Multiple build operations failed.
    Could not create task ':flutter_plugin_android_lifecycle:generateDebugUnitTestConfig'.
    Could not create task ':image_picker_android:generateDebugUnitTestConfig'.
    Could not create task ':path_provider_android:generateDebugUnitTestConfig'.
    Could not create task ':shared_preferences_android:generateDebugUnitTestConfig'.
    Could not create task ':url_launcher_android:generateDebugUnitTestConfig'.
Could not create task ':flutter_plugin_android_lifecycle:generateDebugUnitTestConfig'.
this and base files have different roots: F:\Andriod Projects\coozy_the_cafe\build\flutter_plugin_android_lifecycle and C:\Users\yazad\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_plugin_android_lifecycle-2.0.22\android.

Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // TRY THIS: Try running your application with "flutter run". You'll see
        // the application has a purple toolbar. Then, without quitting the app,
        // try changing the seedColor in the colorScheme below to Colors.green
        // and then invoke "hot reload" (save your changes or press the "hot
        // reload" button in a Flutter-supported IDE, or press "r" if you used
        // the command line to start the app).
        //
        // Notice that the counter didn't reset back to zero; the application
        // state is not lost during the reload. To reset the state, use hot
        // restart instead.
        //
        // This works for code too, not just values: Most code changes can be
        // tested with just a hot reload.
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
      appBar: AppBar(
        // TRY THIS: Try changing the color here to a specific color (to
        // Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
        // change color while the other colors stay the same.
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          //
          // TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
          // action in the IDE, or press "p" in the console), to see the
          // wireframe for each widget.
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
F:\flutter_sdk\flutter_latest\flutter\bin\flutter.bat doctor --verbose
[√] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.19045.4894], locale en-IN)
    • Flutter version 3.24.3 on channel stable at F:\flutter_sdk\flutter_latest\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (13 days ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at F:/Andriod_Sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = F:/Andriod_Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Enterprise 2022 17.11.3)
    • Visual Studio at F:\visual_studio_2022_enterprise
    • Visual Studio Enterprise 2022 version 17.11.35303.130
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)

[√] VS Code (version 1.93.0)
    • VS Code at C:\Users\yazad\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.19045.4894]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 129.0.6668.70
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 129.0.2792.52

[√] Network resources
    • All expected network resources are available.

• No issues found!
Process finished with exit code 0

Closing this as a duplicate of your existing issue at https://github.com/flutter/flutter/issues/136160. Please don't file multiple similar issue and try to narrow the project code to provide a minimal sample project for that, see https://github.com/flutter/flutter/issues/136160#issuecomment-1775688528.


Element dropdown bug - large first row

From @zlatko-minev
Informations

Qiskit Metal version: all
Python version: all
Operating system: Mac

What is the current behavior?
In the elements table on mac, the first row seems huge for some reason

Steps to reproduce the problem
Click the elements table on a mac
What is the expected behavior?
Normal sized first row
Suggested solutions
n/a

Fixed by @ismirlia.  This can be closed.


Lagspikes when typing something into TextFormField w/ custom mask TextEditingController

Steps to Reproduce

Code: https://gist.github.com/vlkigdm/add8034a72bbc529629586341ca75578
Typing something into TextFormField will generate huge lagspikes and logs:

W/IInputConnectionWrapper(  856): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(  856): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(  856): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(  856): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(  856): endBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(  856): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(  856): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(  856): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(  856): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(  856): endBatchEdit on inactive InputConnection

Affected versions: Flutter 1.12.13+hotfix.5 +
Works fine on: Flutter v1.10.10.

Logs

[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.17763.864], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Android Studio (version 3.5)
[!] IntelliJ IDEA Ultimate Edition (version 2019.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] Connected device (2 available)

[√] Flutter (Channel beta, v1.12.13+hotfix.6, on Microsoft Windows [Version 10.0.17763.864], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Chrome - develop for the web
[√] Android Studio (version 3.5)
[!] IntelliJ IDEA Ultimate Edition (version 2019.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] Connected device (4 available)

[√] Flutter (Channel unknown, v1.10.10, on Microsoft Windows [Version 10.0.17763.864], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Chrome - develop for the web
[√] Android Studio (version 3.5)
[!] IntelliJ IDEA Ultimate Edition (version 2019.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] Connected device (4 available)

Hi @vlkigdm
Testing on latest  dev channel, doesn't reproduce this issue
[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.18.0 at /Users/taha/Code/flutter_dev
    • Framework revision 14f3a36aba (3 days ago), 2020-04-03 17:06:01 -0700
    • Engine revision 09bc1fc45e
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 e736495eb7)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.0

[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome           • web-javascript • Google Chrome
      80.0.3987.149
    • Web Server • web-server       • web-javascript • Flutter Tools

• No issues found!

if you're still experiencing this problem with latest dev channel, please comment below,  i will reopen it
Thank you


Adds node selector to pods deployed by tests

Adds node selector to the spec of all pods deployed in e2e tests.
Also adds a new flag in the test cli to be able to configure the OS in preparation for
Windows testing.
Signed-off-by: Sotiris Nanopoulos<EMAIL_ADDRESS>

Lint does not work locally so I am going to iterate on the CI to ensure that everything looks ok

Codecov Report

Merging #3855 (5ff4492) into main (53e8bc3) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3855      +/-   ##
==========================================
- Coverage   67.83%   67.75%   -0.09%
==========================================
  Files         199      199
  Lines       11088    11088
==========================================
- Hits         7522     7513       -9
- Misses       3517     3526       +9
  Partials       49       49

Flag
Coverage Δ

unittests
67.75% <ø> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/crdconversion/crdconversion.go
59.78% <0.00%> (-9.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e8bc3...5ff4492. Read the comment docs.

@ksubrmnn @shashankram PTAL


Pod Stuck in "ContainerCreating" state when using Projected Volumes example

In Projected Volume Example https://kubernetes.io/docs/concepts/storage/projected-volumes/#example-configuration-secret-downwardapi-configmap when i simply copy and paste the code of yaml file  in master node and creating a pods it get created in node 2 where i had already  created the directory for secret and volumemount, configpath, downwardApi (here in example  /projected-volume, my-group/my-username, labels, cpu_limit, my-group/my-config) in /projected-volume folder  i created my-group, cpu_limit, labels and in my_group i created my-config and my username directory. Then also i am facing an issue called Containercreating state of the Pods.
Can anyone help me why this is happening. Your Suggestions are invited. What i am missing to get my pod in ready state.

/sig docs
/language en
/kind support

/retitle Pod Stuck in "ContainerCreating" state when using Projected Volumes example
YAML related to the issue: https://kubernetes.io/docs/concepts/storage/projected-volumes/#example-configuration-secret-downwardapi-configmap

@rishavkankane  I think you missed making secrets, Configmap, downwardAPI thats why the pod is not getting in ready state.

@niranjandarshann yes i hadnt created Secret, Configmap DownwardAPI .

I am bit confused about yaml file having
items:
key:
path:
what these meant and what is there importance? what is the use of Key and what the path is reffering.

https://kubernetes.io/docs/concepts/storage/projected-volumes/#example-configuration-secret-downwardapi-configmap is a manifest; however, that page (intentionally) does not give complete instructions on how to make that example work.
I don't think there's any documentation fix needed.

You could add a new tutorial page @rishavkankane, perhaps titled “Explore the downward API”.
The concept page doesn't need any fix.

If you want to edit https://raw.githubusercontent.com/kubernetes/website/main/content/en/examples/pods/storage/projected-secret-downwardapi-configmap.yaml to have inline comments, that works too.

@sftim Yes it is true the page does not have complete instruction on the working of the example. So the document fix is needed to showcase the step by step action. More description about the projected volume work will be helpful for reader to compile easily. @niranjandarshann @dipesh-rawat What do you thing about my suggestion.

@rishavkankane  Yes projected volume has lee description but we dont need any fix in concept as the concept of projected volume is clear in it but still if you want to add something that will be useful then you can go for it.

/remove-kind support
/priority awaiting-more-evidence

@rishavkankane  I am helping you to understand the yaml file step by step:

under  volumeMounts section for each container that needs the secret.
Specify a path to an unused directory where the secret will appear. ( here in yaml file /projected-volume)
Add a volumes block to list each projected volume source.(volume label)
Specify any name for the volume. (under volume label there is name labels so name of the volume)
 5.  Add a secret. Enter the name of the secret object. Each secret you want to use must be listed. (Here  you have to declare secret that you made and already exist here)
 6.  The secret having items or data in it so key here denotes the username which can be anything that you declared in the secret yaml.
 7.  Specify the path to the secrets file under the mountPath. Here, the secrets file is in /projected-volume/my-group/my-username.
  8.  Add a Downward API source.
  9.  Add a ConfigMap source.
  10. Set the mode for the specific projection

I thing the above steps description helped you in understanding the yaml file and the working of it.
In your case you hadn't made any volume (like as Secret, downwardapi, Configmap) thats why pod is getting in ContainerCreating state as it is not getting the  path of the volume you created in  it.

@rishavkankane I am helping you to understand the yaml file step by step:

under  volumeMounts section for each container that needs the secret.
Specify a path to an unused directory where the secret will appear. ( here in yaml file /projected-volume)
Add a volumes block to list each projected volume source.(volume label)
Specify any name for the volume. (under volume label there is name labels so name of the volume)
 5.  Add a secret. Enter the name of the secret object. Each secret you want to use must be listed. (Here  you have to declare secret that you made and already exist here)
 6.  The secret having items or data in it so key here denotes the username which can be anything that you declared in the secret yaml.
 7.  Specify the path to the secrets file under the mountPath. Here, the secrets file is in /projected-volume/my-group/my-username.
  8.  Add a Downward API source.
  9.  Add a ConfigMap source.
  10. Set the mode for the specific projection

Here point 6 denotes that username which can be the name of the field in the my-username file. So here the secret is getting used from the file.
Here point 7 means the file name from which we are using the secret field.
@niranjandarshann please correct me if i am wrong or am i getting it correct now?

Same we will follow for configmap and downwardapi?

I think these types of explaination should be  needed in documentation so that new reader directly on to the page can clearly understand it.
What is you point of view @sftim @dipesh-rawat @niranjandarshann

@rishavkankane I am helping you to understand the yaml file step by step:

under  volumeMounts section for each container that needs the secret.
Specify a path to an unused directory where the secret will appear. ( here in yaml file /projected-volume)
Add a volumes block to list each projected volume source.(volume label)
Specify any name for the volume. (under volume label there is name labels so name of the volume)
5.  Add a secret. Enter the name of the secret object. Each secret you want to use must be listed. (Here  you have to declare secret that you made and already exist here)
6.  The secret having items or data in it so key here denotes the username which can be anything that you declared in the secret yaml.
7.  Specify the path to the secrets file under the mountPath. Here, the secrets file is in /projected-volume/my-group/my-username.
8.  Add a Downward API source.
9.  Add a ConfigMap source.
10. Set the mode for the specific projection

Here point 6 denotes that username which can be the name of the field in the my-username file. So here the secret is getting used from the file. Here point 7 means the file name from which we are using the secret field. @niranjandarshann please correct me if i am wrong or am i getting it correct now?

@rishavkankane  yes point 6 and 7 denotes the same as you stated. in summary  we can say the file my-username in  /projected-volume/my-group/my-username having  username stored in it. I think these points helped you.

@niranjandarshann Same we will follow for configmap and downwardapi?

Yes same procedure  for Configmap but there yaml and path  must be different from secret .As both (ConfigMap and Secret)  are different

@rishavkankane I am helping you to understand the yaml file step by step:

under  volumeMounts section for each container that needs the secret.
Specify a path to an unused directory where the secret will appear. ( here in yaml file /projected-volume)
Add a volumes block to list each projected volume source.(volume label)
Specify any name for the volume. (under volume label there is name labels so name of the volume)
5.  Add a secret. Enter the name of the secret object. Each secret you want to use must be listed. (Here  you have to declare secret that you made and already exist here)
6.  The secret having items or data in it so key here denotes the username which can be anything that you declared in the secret yaml.
7.  Specify the path to the secrets file under the mountPath. Here, the secrets file is in /projected-volume/my-group/my-username.
8.  Add a Downward API source.
9.  Add a ConfigMap source.
10. Set the mode for the specific projection

Here point 6 denotes that username which can be the name of the field in the my-username file. So here the secret is getting used from the file. Here point 7 means the file name from which we are using the secret field. @niranjandarshann please correct me if i am wrong or am i getting it correct now?

@rishavkankane yes point 6 and 7 denotes the same as you stated. in summary we can say the file my-username in /projected-volume/my-group/my-username having username stored in it. I think these points helped you.

Clearly understood @niranjandarshann this is the explanation that i was looking for. Keep guiding. Understood.

I think issue is resolved so we can close this issue.

I think issue is resolved so we can close this issue.

@niranjandarshann  Sure, I will close the issue when i will complete the task as stated in above explanation About to make the separate file and merging in one.

Above approach work for me Thanks @niranjandarshann  and all for your support and time.
If all think its required to change the doc explanation in projected volume then definately it will be helpful for new reader if all these points must take some space in doc.

issue resolved but updation in document is needed.
Closing the issue
/close


Bump version to 8.0.0

PR automatically created by release.py

gist: https://gist.githubusercontent.com/azeey/41d68f500d0d653aa9eb60b395db5624/raw/4f61cde52c3c901e03d5ae3cd2124adb0968beee/gz-math-8.repos
BUILD args (appended to the default): --packages-above-and-dependencies gz_math_vendor
TEST args (appended to the default): --packages-above gz_math_vendor
ROS Distro: rolling
Job: ci_launcher https://ci.ros2.org/job/ci_launcher/14625/

Linux
Linux-aarch64
Linux-rhel
Windows

cc @clalancette


Show more than three days.

Feature request: the ability to preview weather for up to a week/ten days.
Proposed implementations:

f/b: scroll fordward and back in dates (re-render for next set of dates).
A simple table without the ASCII art.

The problem is not with the rendering, but with the data. It's hard to find reliable data for more than 3 days (or it is really expensive)

Ah, I see. Too bad!


Make date formats more flexible

This sets the default date format to ISO 8601  yyyy-MM-dd but allows users to set date-format in config.yml to other formats handled by https://deno.land/std/datetime/mod.ts.
Also updates README to show examples using ISO 8601. I think there is a good argument to use this, in part because US 'MM/dd/YY' is ambiguous.

Fixes #5

@paciorek Could you merge main into this branch so get the commits from the logging PR that was approved? Doesn't look like I'm able to resolve the conflict on your branch.

@andrewpbray done.

thanks!


Update requirements to use a compatible version of channels (1.x)

#46 This changes requirements.txt to use a compatible version of channels instead of 2.0 as requirements.txt currently installs. All tests pass in this commit.

The requirement.txt is actually correct as is. Typically when I develop this package I do it off channels master. I fixed the setup.py dependencies in this PR: #48


mongosh: 2.0.1 -> 2.1.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3044

Result of nixpkgs-review pr 271147 run on x86_64-linux 1

1 package built:

mongosh

runs fine, lgtm. Thanks!


[BUG] Configuration yaml now with Capital I in resourceId of backend definition

Release version
v6.0.1
Describe the bug
In the configuration yaml files, you now need to camelCase the resourceId of the backends.
Expected behavior
Configuration file used to look like this:
backends:

name: helloworldfromfuncapp
properties:
url: "https://helloworldfromprodfuncapp.azurewebsites.net/api"
resourceid: "https://management.azure.com/subscriptions/[subscription Guid goes here]/resourceGroups/rg-apim-lab-prod/providers/Microsoft.Web/sites/helloworldfromprodfuncapp"

Actual behavior
Configuration file now needs to look like this:
backends:

name: helloworldfromfuncapp
properties:
url: "https://helloworldfromprodfuncapp.azurewebsites.net/api"
resourceId: "https://management.azure.com/subscriptions/[subscription Guid goes here]/resourceGroups/rg-apim-lab-prod/providers/Microsoft.Web/sites/helloworldfromprodfuncapp"

Reproduction Steps

run extractor
run publisher with configuration yaml including backends with lowercase resourceid

@Buffelstoot - thanks for raising this. The overrides in the configuration JSON should be case-insensitive. We'll address this issue.


auto url decode path parm and query param

get "/fighter/{name:string}":
    let nameDecoded = decodeUrl(name) # happyx can help us do this ;-)

not check form-data, but I guess it should be

so now you can update to happyx@#head and play with it


devel: fix cmake for interfaces plugin after the change of utils path and include bridge yang files

As we test the changes introduced on devel branch to support bridges we found the following issue:
1- memory utilis path has been changed, hence the interfaces plugin couldn't compile as its referencing the old memory.h path.
2- bridge yang modules are outdate and missing some dependencies.
This is a PR against devel branch, as a start to help continue working on devel branch for full support bridges.

LGTM, please, which maintainer can review it ?


Demo not working

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Simple: local storage isn't being populated.
If the current behavior is a bug, please provide the steps to reproduce.

Opened demo as per repo
Checked console -> no 'vuex' key in local storage
Incremented values -> still no 'vuex' key in local storage

What is the expected behavior?
Demo works

Ugh! Sorry, I'm clearly on the wrong domain in my image. My mistake.


Documentation Update

[x] Review repo in its entirety
[x] Review docker folder
[x] Reivew Documentation Folder
[x] Review Validation Folder
[x] Review Analysis Folder
[x] Review Process Folder
[x] Assess how repo matches up with Documentation Folder
[x] Review documentation readme
[x] Make sure data is easily accessible
[x] Make sure that code-running instructions are clear and correct

@gboeing Okay! Everything has been updated and conflicts are resolved. Should be ready to merge in.


New smooth stone pillar doesn't fit in build menu when all pieces are unlocked

When all Mistlands etc. build pieces are unlocked, the smooth stone pillar doesn't fit in the hammer menu.
Possible workaround: add to less populated submenu, like Misc

You are correct. I am aware (ofc thank you for documenting nonetheless).
I will look for a systemic solution to this in combination with:
https://github.com/java-devil/OCDheim/issues/15
One possible solution involves a seperate "tab" for OCDheim.


Question about version of pytorch

Can I ask what is the version of pytorch? I tried to use pytorch 1.9.0-cu102 it didn't work.
Plus, why this code is citing DDIM? Is this a modified DDPM?
Thank you for your time~

Do you have a woring version of torch and cuda? Just use your default one. It should work.
DDIM is a modified DDPM. See DDIM paper for more details.

torch >= 2.0


CORE general Design class rules including objectives, endpoints, estimands (model area GDS)

Rules related to study version and study design attributes and relationships including study identifiers, tiles and masking.

Closed as it is included in pbi #378


bugfix: fix in high version springboot property not Standard

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
bugfix: fix in high version springboot property not Standard
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #4817 (7fc11ef) into develop (15add9a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4817   +/-   ##
==========================================
  Coverage      49.21%   49.21%
- Complexity      4091     4092    +1
==========================================
  Files            736      736
  Lines          25723    25723
  Branches        3177     3177
==========================================
  Hits           12659    12659
  Misses         11715    11715
  Partials        1349     1349

Impacted Files
Coverage Δ

...torage/file/store/FileTransactionStoreManager.java
56.27% <0.00%> (ø)

#4801

@liujunlin5168 Pls indicate the starting springboot version.


[BUG] Annoying Bar at the top of screen, cant enter fullscreen F11/Alt+Enter dont work

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
When I am in a game a bar shows as if its windowed and is annoying me Alt+enter, F11 dont seem to work. >:(

does it happen without bloxstrap?

When I dont use Bloxstrap fullscreen works completely fine

Can you show a screenshot of the FastFlag editor in the Bloxstrap Menu please?

Here, I watched a video that told me how to add a FastFlag to fix the issue. Sadly it didn't work.

What about the fullscreen option in the ingame escape menu? Can you try setting toggling it there?

I tried doing that it has no effect to the window whatsoever

Have you opted to disable fullscreen optimizations in the mods section of the menu?

Just tried that, did nothing.

Oh wait nvm it fixed it thanks


I would get last van ban list using Steam API (node js)

Hello Sir.
I am a beginner of steam api.
So Can you help me?
Please let me know best Steam API document.
Then How can I  get last vac ban list using Steam API in Node JS
Thanks

This is how you can get ban list - "https://developer.valvesoftware.com/wiki/Steam_Web_API#GetPlayerBans_.28v1.29"
And best documentation for steam API is "https://steamcommunity.com/dev"


Translations proposal

What is this?
This is my proposal to deal with internationalizations with Dialogic.

I'll probably edit this request to add more information

I'll use what Godot gives to us: the TranslationServer and its powerful translation importer (that just import translation files likes csv or po files to use them later as .translation resources).
I've worked with PO files, but for now, I'll focus test with CSV files (because it's faster than creating PO files just for test). You can see the progress of them in this Google spreadsheet
Why?
If you're going to make a game with dialogues, you'll probably need to translate those text later to get more people involved into your game, or at least, let your fandom translate them for you (without decompiling your game for that).

This is not my best argument, I'd have to admit

Translations doesn't work inside the editor
Since TranslationServer doesn't work in tool mode, I've worked on a workaround to solve it and see the translations inside the editor. The version on this PR is a modified version to work with dialogic without messing things up.
Problems
Now we have two main problems with this approach:

Timelines text (and every text that can be translated) probably will be broken with this approach (unless?).
Apparently, this approach is unmaintenable for larger projects. (I really don't know how)

What's the plan?

Make the plugin itself be a multilingual plugin (the first on its class, since i can't find another plugin with more languages on it).
This can be done easily with the translation tool and the translation files. The hard part is to automatically import those translations.

Modify the Dialogic timelines to let them be translatables without making them exploding in the process.
Yep, this is the hardest part.

I really wanted to this be included with the 1.0 version, but I guess it's too late for that, so I'll let this PR here, open to your opinions.
At the moment that I upload this draft there's a proof of concept included with the recent commits. You can try an empty dialogic node without any timeline and see the result when there's no translation, one translation or more of them. (They doesn't add automatically to the translations, you had to add them by hand)

I never used translations inside Godot so I can't comment on the code itself, but while looking at the commits I didn't find any reference to glossary definitions. Did you find a way to handle this a well?

I never used translations inside Godot so I can't comment on the code itself, but while looking at the commits I didn't find any reference to glossary definitions. Did you find a way to handle this a well?

@arnaudvergnet Yeah, i have a brief look to handle them using DialogicDefinitionsUtil.
I'll translate the plugin first before dealing with the .json timelines.
This is a draft, so i'll keep commiting this branch until I got a working prototype to make the PR

I have paused the development of this branch in favor of an implementation of the code in this branch.
The status of the current branch translates the plugin and the texts sent to the Dialogic node in the form of ID. More information here and here

Would it be a possibility to put a little checkbox with a label "translate" there and write only the translation-id inside the timelines text event?
test_01 and checked would be enough with a method that gets the correct string from the translation server/service?
It's not the nicest solution but perhaps a quick workarround for now

Would it be a possibility to put a little checkbox with a label "translate" there and write only the translation-id inside the timelines text event?
That was the first idea that i thinked, but making those text as ID would change totally the way that text is saved inside JSON and how the definitions are formatted, so i stopped there, at least, for now.

Could you use the same system that godot uses?, i.e. put for example [greeting] using square brackets in the text box and have it translated using the translation csv file?

Could you use the same system that godot uses?

@zarmath It uses Godot TranslationServer, the same server that translates text when you use the tr() function. The problem it's just the way that the text will be saved. For now, I don't know if it's going to be saved the text as key for the CSV/PO files or there'll be a translation_key property in the JSON file.


ruby: rubygems 2.6.6 -> 3.0.3

I think it makes more sense to vendor the patches than pull them from @zimbatm's GitHub.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hmm, on second look, this doesn’t actually seem to have worked…


Issue with Permissions

According to the Permissions.ini the Default group is a catch-all for anyone not assigned to a group. However in that group, no one (but myself, the owner) can adjust the volume, or pause a song. I have tried to adjust the permissions.ini file but no luck. What am I doing wrong, and what more information would you need?
Thanks!

Did you create any new group?  You're not being specific on what you tried to adjust.  Have you checked the wiki?
https://github.com/Just-Some-Bots/MusicBot/wiki/Permissions

I have not created a new group, when I don't assign someone to a group, it is my understanding that they are in the Default group (which has full permissions). If that is indeed the case then why can't someone in the default group use commands like summon, pause, and volume?

As you can see here:
[Default]
CommandWhitelist = play perms queue np skip search id help clean
; CommandBlacklist =
IgnoreNonVoice = play skip search

the default group can only use the commands in the list CommandWhitelist.  If you want to allow everyone to use more commands, you will have to add on to the CommandWhitelist.  I think you may be better off using CommandBlacklist if you are looking into giving everyone all permissions..

Thanks! That worked


Uncaught TypeError: Cannot read property 'error' of undefined

[Enter steps to reproduce below:]

Atom is installed as Portable
install omnisharp
restart atom
create file - test.cs
Menu -> Omnisharp -> Toggole

Atom Version: 0.198.0
System: Microsoft Windows 8.1
Thrown From: omnisharp-atom package, v0.4.24
Stack Trace
Uncaught TypeError: Cannot read property 'error' of undefined
At C:\Tools\atom\packages\omnisharp-atom\node_modules\omnisharp-node-client\lib\drivers\stdio.js:76

TypeError: Cannot read property 'error' of undefined
  at Socket.<anonymous> (C:\Tools\atom\packages\omnisharp-atom\node_modules\omnisharp-node-client\lib\drivers\stdio.js:76:70)
  at emitOne (events.js:82:20)
  at Socket.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at Socket.Readable.push (_stream_readable.js:109:10)
  at Pipe.onread (net.js:517:20)

Commands
  2x -0:36.9.0 omnisharp-atom:toggle (atom-text-editor.editor.is-focused)

Config
{
  "core": {}
}

Installed Packages
# User
.bin, vundefined
atom-typescript, v4.2.4
atom-yeoman, v0.2.0
autocomplete-plus, v2.14.1
autocomplete-plus-async, v0.22.0
language-asp, v1.0.0
language-aspx, v0.4.0
linter, v0.12.2
omnisharp-atom, v0.4.24

# Dev
No dev packages

Getting the same issue on a non-portable install of Atom (Windows), when using File > Add Project Folder, then opening an existing .cs file.

Thanks for the report. I'll have a look into this.
btw. you should uninstall autocomplete-plus-async

getting same error after latest install

Getting a similar error on Ubuntu 14.04

I'm getting a similar error on OS X (Yosemite) and Ubuntu 14.04.  This is possibly related to the issue I posted earlier (#276).  The error I receive is:
Uncaught TypeError: Cannot read property 'stdin' of null

And the stack trace on OS X:
TypeError: Cannot read property 'stdin' of null
  at StdioDriver.request (/Users/userfolder/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/drivers/stdio.js:130:22)
  at Client.OmnisharpClient.request (/Users/userfolder/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/omnisharp-client.js:108:35)
  at Client.OmnisharpClient.codecheck (/Users/userfolder/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/omnisharp-client.js:217:21)
  at Client.OmnisharpClient.codecheckPromise (/Users/userfolder/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/omnisharp-client.js:220:21)
  at LinterCSharp.lintFile (/Users/userfolder/.atom/packages/omnisharp-atom/lib/omnisharp-atom/linter.ts:41:21)
  at /Users/userfolder/.atom/packages/linter/lib/linter-view.coffee:163:18
  at Array.forEach (native)
  at /Users/userfolder/.atom/packages/linter/lib/linter-view.coffee:162:18
  at FSReqWrap.oncomplete (fs.js:77:15)

Using version 0.199.0 of Atom and 0.4.29 of omnisharp-atom (just updated this morning)

I think I know what is going on with this problem now, and have a
replication, so I'm working on it.

Try 0.4.33 and let us know if it's still an issue!

This appears to be fixed but see #301.


routeAfterAuthentication with Dynamic segments

Hi, I have a case in which I perform a login in a nested route with a dynamic segment (i.e. /libraries/:library_id/login) and I want to transit to another route under the same path after authenticating (i.e. libraries/:library_id/interface) but even if I set routeAfterAuthentication to a fixed route like /libraries/abc/interface it can't find it.
I assume that this is actually not supported and I've found a workaround in which I go to a static route and then transitioning from it to the one I want, but I don't know if there's a better way of doing it.

That's not actually not supported. You can just override the ApplicationRouteMixin's sessionAuthenticationSucceeded method though.


Is there plan to support GPTQ?

Feature request
GPTQ is not supported yet in current version. Is there any timeline on that?
Motivation
quantization
Your contribution
can help with code if needed

Yes, GPT-Q will be supported once pr #438 is merged.

Closing this issue since GPTQ is supported now.


[Refactor] Fix TnT compatibility and verbose warning.

Motivation
TnT does not support return tuple now. And the warning in extract_feat will show in every call.
Modification
As the title
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[x] CLA has been signed and all committers have signed the CLA in this PR.

Should add a period after default value in docstring.

Good, but maybe in another pull request.


change input to degrees

Purpose

Change to use latitude and longitude in degrees in the input.
To-do

Content

[ ] I have read and checked the items on the review checklist.

bors try

bors r+


Configure oom_score_adj for linux platforms

Basic functionality for oom_score for platforms with procfs at /proc (Hosted Ubuntu, mainly)
This change increases the oom_score_adj for invoked processes other than main Agent.* processes. In effect this will be node and by extension processes it invokes. In OOM scenarios on Linux, processes are killed in order of their oom score. This protects the agent from getting killed by marking its downstream processes as lower priorioty.
If the agent is oom killed the job dies anyways, so this enables future error reporting scenarios for when the Linux machine is OOM.
This can be used in conjunction with systemd or other services by starting the agent service with a low score, eg -999 or -1000. Because that score would be inherited, we must set it back to higher than the inherited score, but the exact score is arbitrary
Can be configured with VSTS_JOB_OOMSCOREADJ if absolutely necessary, but the defaults are intended to work for most/all cases.

Please add a L0 and verify you get the file generate correctly. :)

LGTM, i left few tiny comments.
Do you have a sample screenshot of a build that runs on the agent with OOM triggered?
Any timeline for the doc work?

Also, heres an example of a build where the memory usages rises to 99-100% and subsequently the agent either dies or can not longer even establish a connection with the server:

The biggest issue is when something like this happens on hosted it portrays a service infrastructure failure. Additionally, you cannot expand the steps that errored out, so there is no way to see what happened because the logs did not get uploaded

@bryanmacfarlane I believe you had interest in reviewing the docs associated with this.
I added docs/start/resourceconfig.md here with some information about cgroups/oom-killer

@dakale i am merging the PR so i can start agent release process. i think we can tweak the doc later.

Okay thanks. Meant to merge earlier but was waiting for the build check. I finished the main doc updates that I wanted
Get Outlook for Androidhttps://aka.ms/ghei36

From: Ting<EMAIL_ADDRESS>Sent: Monday, March 11, 2019 7:46:23 PM
To: Microsoft/azure-pipelines-agent
Cc: David Kale; Mention
Subject: Re: [Microsoft/azure-pipelines-agent] Configure oom_score_adj for linux platforms (#2131)
@dakalehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdakale&data=02|01|David.Kale%40microsoft.com|2eb4065fcc974340c58408d6a67bc5a0|72f988bf86f141af91ab2d7cd011db47|1|0|636879447864272704&sdata=q%2BnYaZbu0VURZ%2Bt45EWBi3ZeLmdoMLNlHUYw%2Fu9H4II%3D&reserved=0 i am merging the PR so i can start agent release process. i think we can tweak the doc later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-agent%2Fpull%2F2131%23issuecomment-471785922&data=02|01|David.Kale%40microsoft.com|2eb4065fcc974340c58408d6a67bc5a0|72f988bf86f141af91ab2d7cd011db47|1|0|636879447864282713&sdata=Eu41O58ozS9v%2FVpk4IlQFcgfMBfuMM2tKFcnWqaiPAo%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAgh2TLpqtPYOGkLFui9pw1c_2E59ryduks5vVurPgaJpZM4bZ6VL&data=02|01|David.Kale%40microsoft.com|2eb4065fcc974340c58408d6a67bc5a0|72f988bf86f141af91ab2d7cd011db47|1|0|636879447864282713&sdata=e8GwKBBd6gbas6GFFS58mmFj23eViWBNCwGBGOnjU%2Bw%3D&reserved=0.


Folding does not return all ranges in file with large chained method

From https://github.com/Microsoft/vscode/issues/53766

TypeScript Version:  3.1.0-dev.20180713

Search Terms:

Folding
Outliningspans

Code
open this file and request folding rabge
Bug:
Folding ranges are only returned after line 3800 or so

@uniqueiniquity can you take a look

I have the same issues with a huge gulpfile (699 lines). Some code cannot be unfold, closing/re-opening the file doesn't correct the problem, i have to restart VSCode.
missing the "+" action to unfold

@mjbvz, the original issue is explained by https://github.com/Microsoft/TypeScript/issues/25596#issuecomment-404577953; we stop looking for folding ranges at a certain AST depth due to perf reasons.
@Davilink, could you share your gulpfile or a similar repro? From the picture, it doesn't look like the same issue, since the original issue is caused by repeatedly chaining method calls.

Because the problem is solved when a restart VSCode, it's might be due to larger workspace + the larger gulpfile. I will open an separate issue to track that problem.

Closing due to addressing the original issue with https://github.com/Microsoft/TypeScript/issues/25596#issuecomment-404577953


feat: Add support for tool calling cohere

Fixes # (issue)

Thanks for this!
Could you try scoping the changes down a bit? Appears to be a lot of unrelated diffs.
Also, don't forget to run yarn format and yarn lint!

@jacoblee93 Hey, thanks so much for the review and comments! I've addressed them! Could you please help to take a look again if possible and then we can try to see if we can get this PR and the other one released by this week? Thanks so much! 💯

Yes will look today, thanks for the hard work!

Pushed some refactoring/lint/format stuff, will merge alongside the embedding PR and minor bump the package.

Thank you!


Automatic testing

I found three different frameworks for unittests in javascript, that might be useful here. All seem to need a browser, so will need to have a look on how to simulate one properly and/or how to get it's results.
https://github.com/jquery/qunit
https://github.com/jasmine/jasmine
https://github.com/mochajs/mocha/
Are either of those interesting for the unittests you did want to add, @w20k ?

I used all of them.
There is an option to add phantom browser, but I will take a look if we could do it without additional overkill - like installing npm.

anyway, what framework did you prefer? Never worked with either, so...

Latest jasmine is mostly preferable ;)

everything else is handled in #125


ipc_service: Separate priv data from main configuration

Is your enhancement proposal related to a problem? Please describe.
Currently the configuration of the endpoint stores pointer to its name, priority, callback pointers and pointer to priv data. It all adds to 24 B that has to be stored in RAM.
It real application it is very common to have all the pointers for specific endpoint type to be constant that may be placed in the ROM memory. In most cases also the priority and the pointer to the name may be stored here. But it is totally different case with priv pointer. If I create 3 instances of IPC endpoints and wish to communicate with 3 different cores - now I have to prepare totally different configurations for it and store it into RAM that is kept the whole time the Endpoint is in use.
And in such case all the data in configuration would be the same, only the priv pointer is used to differentiate the source of the callback.
It complicates configuration and wastes RAM.
Describe the solution you'd like
It would look much better if we change the ipc_service_register_endpoint into a form:
int ipc_service_register_endpoint(const struct device *instance,
				  struct ipc_ept *ept,
				  const struct ipc_ept_cfg *cfg,
				  void *priv);

Then we can place all the common configuration in one place of the module, and keep it in ROM. The ipc_service backends should store configuration structure and priv pointer separately. And in the moment of registering endpoint instead of copying all the configuration to just change the priv pointer we can alternate it in a nice an readable form.

@rakons moving the priv from ipc_ept_cfg to a function parameter seems a good idea. Can you push a PR for that?


break out modal logic into separate reusable hook

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2156

PR #2169

PR #2170

PR #2171

PR #2172   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: vtVBnYDD1aIW70DZJ1cT


Henryiii filterpandas

Continuation of PR #157 with Jim's bug-fixes.

However, given that the public API is currently broken, it gives us some leeway to change it. I don't think I'd recommend getting rid of it, since it's more discoverable than .array(outputtype=pandas.DataFrame), but having matching defaults might be better if this is the only one that's different. What defaults are different, besides the flatten?

At best, you can say that the public API is misguided. I thought about it, concluded that this way would be least confusing for users, implemented it, and used this used these defaults in code examples I gave in talks. I might have made a wrong choice, but "broken" should be reserved for unintentional mistakes, not intentional ones.
In doing so, I decided on a general rule that connectors TTree.nameoflib.func(...) (where nameoflib is a famous library that the user cares about) can have different defaults than raw array-fetching functions TTree.func(...). So far, flatten is the only one that yet takes advantage of that freedom.

Also, flatten=True in my case (300+ regular columns and a small handful of jagged columns) would probably waste much more memory than flatten=False, and I don't think most users expect multi-index DataFrames.

Your case has a much higher flat/jagged ratio than the cases I've considered so far. CMS NanoAOD only has more flat branches than jagged branches because each trigger is a separate branch of booleans. Excluding those, maybe 90% of what's left is jagged.
Currently, flatten=False means losing the Numpyness of the branch by iterating over it, turning the elements into Python lists. That's a performance issue in memory and load time. Then you have a DataFrame with a dtype=object column, which you can't do anything with except Python loops. Soon, though, I'll be adding Pandas extension types for jagged arrays that would make flatten=False a lot more performant and useful.
In those talks I referred to, I advocated for more use of Pandas MultiIndex, since it's the Pandas-native way of dealing with this sort of structure. Maybe most users aren't familiar with it now, but I hope that will change.


Problem while checking version of dotnet in terminal

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/hello-world-tutorial/install
Operating System: macos
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

what error do you get? and what version did you install? and which kind of Mac do you have?