Add info button

In development
Reply to: https://github.com/Dijji/XstReader/issues/18#issuecomment-563249377

Objective was to put an icon to the left of the open button. Thinking Visual Studio Image Library 2017  or maybe  but bold text works. Initial thought was a form, then inspired by app minimalist approach changed to a MsgBox. Issues:

Still not clear how to get the version variable which must come from compiler
Open is first button and haven't found where order is assigned
Possibly drop icon on button or maybe it should be a tool button
Wondering if whole status bar should be a toolbar at top of window, agree it's secondary content

Hmm ... A full-blown settings form is a different scope

I like the little button, but not particularly where it is. The problem with the way you show it is that it is right in the middle of the status text box. I already have to hide the search text box while email export is in progress, and the button where you have it would interfere with almost every status display.
Maybe better would be in the very bottom right. If we do add settings at some point, it should probably be another small button with a gear wheel next to it. By which time it is all looking more like a header bar than a footer bar. But status display says it should be a footer, and I do not want to give up room for both.
I could tell you how to deal with the technical questions, but I will instead tell you what I do. Google is the developers friend. For instance, for the version I would search on "C# assembly version", or for the tab order "WPF tab order". Heaven knows what we used to do.
Dijji

I had thought about bottom right too and agree it is a better location.
No worries, I learnt python earlier this year developing an app with Google. It was the fresh search terms I was after. Before Google was computer magazines and newsletters.

Okay, now we are down to the detail:

the handler for your button needs a descriptive name, e.g. btnOpen_Click
you should not be turning on the print headers switch, it is nothing to do with this change
you should be using StringBuilder to assemble your message text.
Time to put the actual version in!

This approach to opening the website for the repository will really not do. It is not something to do without positive user input, and it is not clear that clicking Yes will have that result. Better would be something more in line with typical expectation, like a clickable link. But if you want that, you would have to go to a pop-up panel. This should not be attempted in a box.
I will settle for a MessageBox if you remove opening the repository, and fix StringBuilder (stylistic, but building a string with + for so many terms is not pro-standard coding) and the version (the reason for the whole thing)

Looking good. The only problem I have is that Application.ProductVersion does not exist, so this does not compile. Did you extend the App class and not check it in? Anyway, the following works:
 Version version = System.Reflection.Assembly.GetExecutingAssembly().GetName().Version;

Yay! Thank you.


During training, the loss_cls_neg does not reduce, but the results appear good

Hi, i train dw in my dataset, but find the loss_cls_neg does not reduce, but increases. However, the test results seem good.
Is it normal for this situation?
How does this loss work?
I would like to try if removing this loss and check the results again.

Hi. The situation is normal. One possible reason is that the neg avg factor is dynamically calculated.  Removing this loss will obviously decrease the performance according to my experiments on COCO.

Hi. The situation is normal. One possible reason is that the neg avg factor is dynamically calculated. Removing this loss will obviously decrease the performance according to my experiments on COCO.

Thanks a lot.


rsync "some files vanished" should not fail migration

Describe the bug
If I run a direct volume migration on sock-shop without quiescing, an error about "files vanished" can cause migration failure.
I wonder if there is a way we could make DVM controller ignore this type of warning (or at least not fail the migration). For the staging use-case, it seems like files changing while the transfer is happening will be expected and should not fail a migration.
To Reproduce
Steps to reproduce the behavior:

Create sock-shop demo app using mig-demo-apps deploy.sh
Run direct migration without quiesce
Get error some files vanished before they could be transferred

Expected behavior
Perhaps migration should not fail due to this
          2021/01/25 22:49:33 [1] sent 314.89M bytes  received 10.37K bytes  12.85M bytes/sec
          sent 314.89M bytes  received 10.37K bytes  12.85M bytes/sec
          2021/01/25 22:49:33 [1] total size is 314.82M  speedup is 1.00
          total size is 314.82M  speedup is 1.00
          2021/01/25 22:49:33 [1] rsync warning: some files vanished before they could be transferred (code 24) at main.c(1189) [sender=3.1.3]
        reason: Error
        startedAt: "2021-01-25T22:49:09Z"

@alaypatel07 @dymurray @shawn-hurley just want to confirm, is this still an issue after the recent round of fixes to rsync transfer stuff? I saw it before you guys fixed the filesystem perms issue, not sure if it was a red herring.


Minor doc fix

instanceCount and concurrency are kinesis consumer properties and not kinesis producer properties.

@augustine98 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@augustine98 This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.


cf run-task failing for docker-based apps

Issue
A simple app built with Ruby on Rails and deployed to cloud.gov via docker image runs fine, but cf run-tasks and cf ssh do not work without workarounds.
Context
It appears that the PATH gets messed up for cf run-tasks and cf ssh while the actual running app is fine. On an example app:
cf run-tasks cf-test "bundle exec rake db:migrate" fails, but
cf run-task cf-test "export PATH=/usr/local/bundle/bin:/usr/local/bundle/gems/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin && cd /usr/src/app && bundle check --path vendor/bundle/ && bundle exec rake db:migrate"

works. The same PATH exporting and bundle check dance is required to run commands after using cf ssh APP_NAME
On further testing today, run-task might only require prepending the cd /usr/src/app (that path being the WORKDIR of the docker image) part to correctly run, though cf ssh requires the full setup before commands start being found.
Steps to Reproduce
A reproducing example app is at https://github.com/rahearn/cf-docker-test
The full docker build command used was:
docker build -t rcahearn/cf-test --build-arg RAILS_MASTER_KEY=809a1129e14e8e36f126c76dfce87e25 --build-arg BUILD_ENV=production --build-arg BUNDLE_WITHOUT="development test" .

Expected result
Tasks such as bundle exec rake db:migrate:status complete successfully.
Current result
Tasks such as bundle exec rake db:migrate:status fail with logs:
2019-06-14T09:09:24.14-0400 [APP/TASK/f180fd00/0] ERR Could not locate Gemfile or .bundle/ directory
2019-06-14T09:09:24.17-0400 [APP/TASK/f180fd00/0] OUT Exit status 10

Commands such as bundle exec rake db:migrate:status when run after sshing to app fail with:
root@f153f6fd-97a9-47ab-4a36-e9c8:/usr/src/app# bundle exec rake db:migrate:status
bash: bundle: command not found

There is some context in #1333 around why the cf ssh environment is different than the app running environment: https://github.com/cloudfoundry/cloud_controller_ng/issues/1333#issuecomment-486478224

workarounds:

get envs from /proc/<PID>/environ
start a "sidecar" server in the entrypoint as port ":9999" which responds with the environment it has and then when executing the task or ssh eval $(curl localhost:999)


Replace Google icon with SVG

Gawddamit Safari, why would you lie to me? I just asked if you @support(background: conic-gradient...

😔  I'm sorry you had to go through this king


[FEATURE] Improve permission granularity for tenants

Is your feature request related to a problem?
Read only users of a tenant cannot save searches. This makes impossible for such an user to create/download a report, even if it got the rights.
What solution would you like?
It would be desirable to improve the permission granularity when it comes to tenant rights.
For instance, I would like to specify what kind of tenant object is writeable: kibana:saved_objects/search/write.
What alternatives have you considered?
A simple solution is to force r/o users to work on their private tenant, but people are lazy and do not want to import objects into their own space (and take responsibility).

[Triage] Hi @uj-ff48, thank you for filing this issue. @davidlago could you follow-up on this? Thank you.

Thanks for the tag, @scrawfor99. Closing this one and linking to the new workspaces effort that is the reincarnation of tenants, where the way these are access controlled will be improved https://github.com/opensearch-project/OpenSearch-Dashboards/issues/4615.


Edit of resource policy set some fields as readonly without a business reason

Describe the bug
In the edit resource policy screen the resource policy type, Action and eperson/Group fields are set in readonly mode.
This was due to lack of support on the rest side but from an user perspective it makes no sense.
Moreover, if you want to edit an INHERITED policy it would be more correct to switch the policy to a TYPE_CUSTOM as this would be the result of the same operation if done at the submission time.
Changing the Action type should be a not very frequent/real scenario but again there is no real obstacle in supporting it.
The group/eperson fields are a bit more challenging as to switch from a resourcepolicy grant to a group to one target to an eperson two path operations would be required and the resourcepolicy will be in an inconsistent state in the middle (no eperson, no group associated). Nevertheless, changing the group associated to a group based resourcepolicy would be not controversial and it is likely to be the most frequent use case (to switch from restricted to administrator to open access - anonymous or similar).
Expected behavior
Resource policy type, Action and current eperson or group selection should be editable. A message should inform the user that the policy cannot be moved from a group to an eperson or vicevera and tell him to delete the policy and create a new one if this is the case.
A corresponding REST Ticket should be created to implement the relevant patch methods. For the eperson/group fields only the replace operation should be supported so that there is no way to support operations that could put the resourcepolicy in an inconsistent state.

hi @tdonohue two/three PRs are coming for this ticket.
An angular PR (we spent 12 hours on that) will deal with patching of policy type and action type and will pair with https://github.com/DSpace/DSpace/issues/7812 (we spent 6 hours on that)
A followup angular PR will be needed to deal with the update of an eperson/group as it requires https://github.com/DSpace/DSpace/issues/8277 (we estimate 10-12 hours on that)


Basic move definition and validation

known bugs:

conditional moves (castling, en passant, pawn attack, etc.) missing
hopping over pieces with non-hoppable pieces
capturing friendly pieces
pawns can only move downward regardless of color

should be able to make mostly valid moves with pieces

This is looking great, the comments help a lot with understanding what's going on. Hopefully those bugs won't be too difficult to iron out. Since it looks like you check each square incrementally in isValidMove, would we be able to just ensure each square is empty in the board in its while loop (where it's incrementing the multiplier)?

Yep, that's correct. Capturing friendly pieces can be done by ensuring the value at that index in the array has the same sign as the value at the selected index; those are the easy ones.
Conditional moves and non-hackily making the pawn moves unique will be much more difficult.

functionality is good enough for the moment, other things beckon


Change to Official Transformer Protocol

Change transducers implementation to support "Official Transformer Protocol" discussed in cognitect-labs/transducers-js#20 .  Both transducers.js and transducers-js have been updated to support it (my libraries to follow soon).
Summary of changes:
// anywhere you use a transformer
// (including transducer implementations)
var xf = {
   init: function()
   step: function(acc, item)
   result: function(acc)
}
// becomes
var xf = {
   '@@transducer/init': function()
   '@@transducer/step': function(acc, item)
   '@@transducer/result': function(acc)
}
// reduced wrapper object changes from
{
   value: acc,
   __transducers_reduced__: true
}
// to
{
   '@@transducer/value': acc,
   '@@transducer/reduced':true
}

Obviously, there is room to generalize this.  This may be a good opportunity to reduce the redundancy and consider other transducer implementation strategies (other than .prototype) as @CrossEye and @megawac brought up in the initial transducers PR

I do love interoperability!  :smile:


Custom Image, Confirm Dialog, ImportExport

Added an option to use a custom image from a file (not from URL) for the dials
Added the option to select which bookmark the action is applied to (keeping the current tab as default) #25
Added a confirm dialog to prevent from accidentally removing bookmarks #22
Added an option to import and export settings to an JSON file

@TiagoRascazzi Any chance you can split this up? I don't have much time and it's been a while since I looked at this. Would help to have smaller pieces.


Standard version

Add standard-version package to manage:

bumps the version in package.json/bower.json (based on your commit history)
uses conventional-changelog to update CHANGELOG.md
commits package.json (et al.) and CHANGELOG.md
tags a new release

Using it is as easy as:

To create the first release: npm run release -- --first-release
Next release use: npm run release -- --release-as [major|minor|patch|$VERSION], where $version is whatever you want, like 1.1.0.

Coverage remained the same at 100.0% when pulling 831e4108258b75e8777b9d8ba448f44a67e112fc on acanimal:standard-version into 7548fcbcf2cb02d7696ab64091eae5d54b1b947d on fridays:master.

Using release for this now, thanks anyway


Frame Grabber not Working?

I'm not sure how this is supposed to work but i have everything connected up and i get my bootup swirl and the App works fine but should all the LEDS come on straight away even when just the TV is playing? In other words as soon as i power up the Rpi will ambilight be on all the time?
When I play a movie through OpenELEC the ambilight works which is causing me to think it must be the frame grabber.
I've been playing around with my config file but it could all be useless unless i understand how the ambilight is supposed to work.

@Batmanan still need help or can be closeD?

Closed due to age. Please open a new one, if problems still exists.
Thank you


Does not encode '

Same as encodeURIComponent doesn't encode '

That's correct, because it is not necessary to encode that character 👍


Unclear definitions of DEPTH_MIN, DEPTH_MAX, DEPTH_NUM and DEPTH_INTERVAL

Hi, I'm trying to use preexisting depth maps for 7 scenes dataset. I've extrinsic and intrinsic parameters of the images but I don't understand how to get DEPTH_MIN, DEPTH_MAX, DEPTH_NUM and DEPTH_INTERVAL to add them to the cam files. Please help!
Thanks.

Hi @frozenscrypt , if you have the GT depth map, you can simply find the max and min depth value of the depth map and set it to DEPTH_MAX DEPTH_MIN. Then you can set D = 256 and DEPTH_INTERVAL = (DEPTH_MAX - DEPTH_MIN) / D.


Add a --enable-fips flag which will eliminate MD5 and MMH and uses SHA256 instead.

Add a --enable-fips flag which will eliminate MD5 and MMH and replace them with SHA256.  This will effectively clear the cache because existing documents will not be found.

[approve ci]

Hi @jplevyak
Why you are not a member?

request.zip
Perhaps someone can make me a member : http://people.apache.org/keys/committer/jplevyak
See attached request signed by my apache key

Hmmm you should be able to get permissions via the gitbox.apache.org. You also need to add your Github ID first to id.apache.org I think.

‘’’
CryptoHash.cc:31:10: fatal error: ts/SHA256.h: No such file or directory
#include "ts/SHA256.h"
‘’’

I need to think about this some more. Overall it looks good, I like the clean up on the CryptoHash stuff.

[approve ci]

How do a trigger Jenkins again?  The queue says it is idle but the results are waiting.

just type "[approve ci]"

[approve ci]

[approve ci]

[approve ci]

All checks passed.
When you have some time Alan...

Ping?  Anything I need to do for this one?

Ping?

Ping?

[approve ci] Running CI again just in case, since we have many changes on master after the last check.

[approve ci]

[approve ci]

US government regulations for agencies and contractors prohibit MD5 (among
other things).
On Tue, Dec 26, 2017 at 9:54 PM, scw00<EMAIL_ADDRESS>wrote:

@scw00 approved this pull request.
Looks good to me, but still need @SolidWallOfCode
https://github.com/solidwallofcode reviews.
By the way, why do we need to this change ? It seems like the 128 bit is
enough for our cache.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/trafficserver/pull/2798#pullrequestreview-85619101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARLoLPgHxPDaV0AAZ0L6EJizONdpXyTks5tEdungaJpZM4QaBw_
.


Add ability to disable shard level worker pool

What changed?
Add ability to disable shard level worker pool

Why?
Need the ability to use only host level pool based on staging2 bench testing

How did you test it?
Staging2 bench test

Potential risks

Coverage increased (+0.06%) to 67.198% when pulling e34724c75e9c29e9315a76ed34328aa0bd98b307 on yycptt:disable-shard-worker-pool into e984b002499160398d719c3aa1363538ca01eb9b on uber:master.


Updating with some of the content from network integration

@wamota : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@wamota: Can you resolve your the merge conflict? I think you can do it through the GitHub interface.

@GitHubber17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mattbriggs - The merge conflict is now resolved. Is this request approved for merge? Thanks

@GitHubber17 Yes please. #sign-off


Close button overlaps search

Description
The Close (x) button on test queue cards is overlapping the search bar and is too close to the timer button for ideal touchscreen spacing
Steps to reproduce

Go to localhost:3000
Reduce screen size to that of a mobile device
See overlap

Expected behavior
On mobile, move the timer button under the name, and move the Close (x) button within the card. This eliminates the issue of the button overlapping other things and also reduces the risk of users clicking the wrong button

Closed in #1629.


worker page

The work board page UI is basically the same as Apps UI.
For this reason, this PR will not be merged.
However, thanks for your interest in contributing. ✌🏼


fix: Alignment Issue of Cards In Community Page

This PR fixes the alignment issues in kubernetes.io/community and introduces the following behavior:

https://user-images.githubusercontent.com/56754747/132567182-70712749-246c-4ceb-89ff-15008b5c986e.mp4

Make each card of the same size

Minor refactor - Removed unnecessary CSS

However, there's still a lot to refactor in the community website in terms of CSS. For instance:

Having HTML & CSS separately i.e. avoiding the use of inline CSS
use of CSS Grids instead of 7-8 lines of CSS in the layout of items
remove repeated CSS

Closes #29155

/area web-development

@CIPHERTron I had a chance to review this, and it looks good to me!
Note for @sftim I'm in the process of trying to get REVIEWER status in #contribex-mentoring. Is there something I need to do officially to get this review to count towards my review count? The changes proposed in the PR seem solid to me, and pass checks. :) Is there anything else needed from me to help @CIPHERTron get this merged?
Thanks for any help you can provide!

@CIPHERTron, looks okay to me. Just to clarify, your remark, "refactor in the community website in terms of CSS" is an observation to address in a future PR?

@CIPHERTron, looks okay to me. Just to clarify, your remark, "refactor in the community website in terms of CSS" is an observation to address in a future PR?

Yes @chrismetz09, I plan to address it in a future PR. I've opened an issue regarding the same here.

Heyy @chrismetz09 can we wrap up this PR? Thank!

👀

@chrismetz09 can you please /lgtm this if the changes look okay to you 🙂

@CIPHERTron I found this change hard to review because there are lots of changes here.
It looks like you've combined a refactoring / tidying change with an actual fix? (I'm not sure).
If you can talk reviewers through what you've changed and why, that will help us get this reviewed and merged.

Page preview:
https://deploy-preview-29644--kubernetes-io-main-staging.netlify.app/community/

Hi @CIPHERTron . Thanks for contributing.
Yes, I would prefer a separation of layout changes from changes that tidy (remove extra lines or spaces, quotes) the source file.
Also, I am having trouble pinpointing the main change. What changes should I look for on the page?
When I resize my screen to tablet or phone size, some of the images go out of view and the text overflows in the top navigation. The "Community Values" section shows two images instead of three images?

@CIPHERTron thanks for the PR! I think it would be best to separate your changes into individual PRs (at the very least different commits) for ease of review. Given the age of the PR without action, I'm going to close, but feel free to reopen when ready to address feedback / conflicts. Thanks!
/close


Reduce allocations

I and @k3rni have profiled rspec-expectations' test suite for memory allocations using allocation_stats. The results are at http://danieljanus.pl/rspec-allocations.txt. Most are non-trivial to change, but we did find some (not much) low-hanging fruit. This is a PR for #766.
Specific changes are documented in individual commit messages.

Thanks for taking a stab at this!  Could you add your allocation benchmarks to a directory under benchmarks?  See, for example, in rspec-core:
https://github.com/rspec/rspec-core/tree/master/benchmarks/allocations
Having files like these would answer all sorts of questions I have, and answer them for posterity by having the answers under source control:

What code did you run the allocation tracking over?
What was the number of allocations before, and what was it after? (IOW, what are the numbers that specific changes reduced?)

You may want to use a helper like https://github.com/rspec/rspec-core/blob/master/benchmarks/allocations/helper.rb; feel free to copy it over here.

Thanks for kicking this off, I've just merged #941 which takes two of your ideas here, if you feel strongly that you can improve the diff allocations, please feel free to take another attempt at it, but I'd really like it to not change the current specs for the diffs.


WIP: Creates 400ng item pricing function [delivers #161268794]

Description
Creates a structure for pricing accessorials and adds pricers for many of the "simply" priced items. Still needs pricers for SIT and shuttle service, among a couple others. And more tests.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_migrate

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #dp3-engineering

[ ] There are no aXe warnings for UI.
[ ] This works in IE.
Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:

[ ] Communicated to @willowbl00
[ ] Added to the list of network dependencies

[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

This looks good to me, but I think we need to have someone from A-team review. Perhaps @reggieriser or @akostibas ?


Revisit memoization of bound event handlers

Without this we may have performance regressions from being unable to use the PureRenderMixin correctly

I thought about this some more, and I don't think there ever was a real problem because of those handlers. We're not setting state unless necessary, so you wouldn't get into render in the first place.
Let's close this and reconsider if we learn about use cases with bad perf.


Missing files

Excellent work! But I wonder where is the main function mentioned here:
https://github.com/hturki/suds/blob/9b472ad5e4fd4d810682af984ef65bfaf4d75188/suds/train.py#L22-L24
Unfortunately, I didn't see script.train anywhere.

I found it in nerfstudio, may be Line 24 should be from nerfstudio.scripts.train import main

I found it in nerfstudio, may be Line 24 should be from nerfstudio.scripts.train import main, maybe I'm wrong

I think you're wrong. I meet the same problem as you, and I modify the code follow you, and then I get another problem.
Maybe the correct way is that using the nerfstudio from https://github.com/hturki/nerfstudio/tree/ht/suds instead of the offical version.

@hturki So the codebase cannot work completely (means no other alterities) now until you finish the migration?


Update java version in .tool-versions

Update java version in .tool-versions

Sorry it took me so long, I hadn't noticed that you opened it :grimacing:


Need to test pyopencl context on non-nvidia hardware

We could use intel OpenCL at first

Done on demand


Pass ctx to transporter

Enables more verbose Transporter to log other ctx details. Fixes issues #77 and #82.
ctx is passed as the 3rd argument to transporter as to not disrupt any existing code. That said, it could easily be the first argument if desired.
app.use(logger((str, args, ctx) => {
  console.log(str, ctx.request.ip); // ctx.request.header['user-agent'], etc...
}))

When does it ship?


start with :lager instead of :logger

When application is started, it error on :logger. exometer and other dependency projects uses :lager.  Application starts with the built in logger instead.
Supervisor: {local,'Elixir.Logger.Supervisor'}
Context: child_terminated
Reason: normal
Offender: [{pid,<0.183.0>},{id,'Elixir.Logger.ErrorHandler'},{mfargs,{'Elixir.Logger.Watcher',watcher,[error_logger,'Elixir.Logger.ErrorHandler',{true,false,500},link]}},{restart_type,permanent},{shutdown,5000},{child_type,worker}]
https://github.com/pinterest/elixometer/pull/28#partial-pull-merging

ping

pang?

Sorry, I was out on vacation for a week.

I think this should be reopened.  I am experiencing this issue.  Workaround (per discussion in the comments here https://alexgaribay.com/2016/02/27/using-elixometer-with-phoenix/) is to move elixometer before phoenix in the applications block in mix.exs.
...
applications: [:elixometer, :phoenix, ...


Added docs

Matlab script example is in another branch (PoN QC)
closes #120

@davidbenjamin Can you please ignore the failing unit test (for obvious reasons)?

@LeeTL1220 I found one line slightly confusing.  Rewrite as you see fit and merge.


Test PR please ignore

Testing some things

@jwilander should not get this

@jwilander

@jwilander should not get this2

@jwilander should get this


Add, test, and document Coroutine.getException

Closes #32.
I figured that an Option was a better choice than a Try.

LGTM


Add iptables to wireguard dependencies

Added to apt command to install dependencies.
QA Steps: Checked that the package name is correct, checked rendered output. Ran linkcheck. No issues found.
This commit addresses FFTK-3454, "Documentation: Wireguard dependency"
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Adds missing dependency as reported by customer
Checklist

[x] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[x] Step through instructions (or ask someone to do so).
[x] Review for wordiness
[x] Match tone and style of page/section.
[x] Run make linkcheck.
[x] View HTML in a browser to check rendering.
[x] Use semantic newlines.
[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Docs for 1c3c5e86bd79c6054b66ad69c179c5e8a7c4b4b4 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2761/docs/artifacts/html/index.html


Add detection/prevention of secret leaks

Is your feature request related to a problem? Please describe.
It is easy to inadvertently commit a secret (server secret, auth secret, etc.) that is used for developer testing. We would like to be notified if this occurs, or better, we could prevent it from happening in the first place.
What priority is this?
This is relatively low priority: no civic entity has requested this, and it doesn't block any other work.
Done when:
What conditions need to be met before this issue can be closed?
Tool(s) added to our toolchain to detect, and optionally prevent, secrets being committed to our repos.

There are commercial solutions such as GitGuardian and GitHub Advanced Security.
However, there are also popular open-source solutions like Gitleaks (15.1k stars) and TruffleHog (13.7k stars) as well. Both of these support pre-commit hooks for prevention as well as integration with Github actions for detection.

Both gitleaks and pre-commit have support in codespaces. See #7176 for WIP.

@gwendolyngoetz discovered that GitHub Advanced Security supports secret scanning and push protection from both the web UI and the CLI.
If a push is blocked, the user can access a provided GitHub URL to override the protection. GitHub creates an alert in such cases.
The documentation states:

Some features of GitHub Advanced Security are also available for public repositories on GitHub.com. For more information, see "GitHub’s plans."

The same page shows a table that indicates that secret scanning is available for public repositories. We should test and see if push protection is included.

For testing, I created the secret-testing repo.
I tried pushing a commit containing the first entry (adafruit_io_key) on the list of supported secrets. The push was not blocked. I believe this is because this secret includes a validity check, and the secret I supplied was not valid.
I then created a Docker Personal Access Token (public read-only key) and committed the value. This push failed as expected/hoped:
$ git push
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 424 bytes | 424.00 KiB/s, done.
Total 4 (delta 1), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: error: GH013: Repository rule violations found for refs/heads/main.
remote:
remote: - GITHUB PUSH PROTECTION
remote:   —————————————————————————————————————————
remote:     Resolve the following violations before pushing again
remote:
remote:     - Push cannot contain secrets
remote:
remote:
remote:                 GITHUB PUSH PROTECTION
remote:     ——————————————————————————————————————————————————————
remote:      Resolve the following secrets before pushing again.
remote:
remote:      (?) Learn how to resolve a blocked push
remote:      https://docs.github.com/code-security/secret-scanning/pushing-a-branch-blocked-by-push-protection
remote:
remote:
remote:     —— Docker Personal Access Token ——————————————————————
remote:      locations:
remote:        - commit: eeb7f1c253e8031b39d4de174cbbfc8f2658909b
remote:          path: conf/application.conf:5
remote:
remote:      (?) To push, remove secret from commit(s) or follow this URL to allow the secret.
remote:      https://github.com/civiform/secret-testing/security/secret-scanning/unblock-secret/2fT177DAWLAnxVuKT3XOITSeL1z
remote:
remote:
remote:
To github.com:civiform/secret-testing.git
 ! [remote rejected] main -> main (push declined due to repository rule violations)
error: failed to push some refs to 'github.com:civiform/secret-testing.git'

Are you able to force it (in the case of false positives)? If you can what happens if it's in a PR when you merge to another branch?

Alert: https://github.com/civiform/secret-testing/security/secret-scanning/1

Are you able to force it (in the case of false positives)?

Yes. The error message includes a URL that can be used to override the protection.

If you can what happens if it's in a PR when you merge to another branch?

I created a branch and overrode the protection to push a new secret to the branch.
I then created a PR to merge the change to main. It merged without an error.

I was able to push a commit that contained a throwaway Auth0 client id and secret (they are not on the list). (I rotated the secret, so it is no longer valid.)

GitHub Advanced Security works great for supported secrets. Tying the override to GitHub alerts is really nice. It also doesn't require the developers to configure anything. (GitLeaks and Trufflehog require devs to install and configure pre-commit. We may be able to enable this automatically in our codespaces, as mentioned above.)
However, GitHub Advanced Security missed an Auth0 secret that GitLeaks caught. (GitLeaks caught it because the name of the variable matched the generic-api-key rule.
GitHub Advanced Security supports custom patterns, but apparently not for free, as the setting doesn't appear in the repo security settings:

Maybe use GHAS and layer on the thing the uses pre-commit so if you have both you're double protected and if you don't installed or forget the pre-commit

@nb1701 has enabled GHAS on our repos.
I am setting up gitleaks as a pre-commit for those who use a codespace. Anyone who creates a new codespace or rebuilds their codespace will pick up the pre-commit hook.
I will write documentation for those with existing codespaces (or don't use codespaces at all) to install the pre-commit hook.

@nb1701 are we able to close this?


So much info

Hello I have been strugling with documentcss for the past 6 hours and I barely managed to create a sample of the buttons style.
So I'm wondering, is there a .zip I can download (pre-compiled) that I can tinker and get the end-result?
Or is there some default folder structure that I can follow and it will guarantee create a result? (no the documentation folder structure is lacking serious consistency or info)
Also (because it is highly unclear) does documentcss support scss files as stylesheets?
And finally how can I create a custom .scss, .less, .css or whatever style to "change" the default styles in a way that it will get compiled inside static.css?
thanks...

Hey Michael,
I feel your pain. We are working up some specs to make this much easier.
In the meantime, trying forking from this repo: https://github.com/bitovi/bootdocs run npm install and then grunt to generate the docs. This project is nothing more than a series of less and md files with the Bootstrap documentation in it. It also has several different "themes" you can use, modify, etc... I'm hoping this will at least get you up and running with a default structure and config, then you can start customizing it for your project.
Let me know how it goes.
-Tom

Thanks I will try it out.

Hey Michael,
DocumentCSS will document scss files. You just have to tell it to look for them in your config file. Here's Bootdoc's documentjs.config file:
{
  "siteDefaults": {
      "templates": "themes/default/templates",
      "static": "themes/default/static"
    },
  "sites": {
    "styles": {
        "glob": "{less,docs}/**/*.{css,less,md}",
        "dest": "styleguide",
        "parent": "styles"
    }
  }
}

On line 8 where it says "glob" you can change it to say:
"glob": "{scss,docs}/**/*.{css,scss,md}",

And that will tell the system to look for your scss and output *.scss.html files instead of *.less.html files in your destination directory (in the example above it's in the styleguide folder).
Hope that helps a bit too.

That is for bootdoc, is there something similar for documentcss? (about scss files)
Because the above doesn't output any .scss.html files do I need any other dependency apart from the ones installed with "npm install -g documentjs" ?

@netgfx I'm not sure what you mean. Bootdocs is just a sample DocumentJS/CSS project. If you run npm install on Bootdocs it should install all the dependencies you need.
DocumentCSS will document any type of file. It simply looks for the comments that it recognizes. You tell DocumentCSS what file type to search for by using something like "glob": "{scss,docs}/**/*.{css,scss,md}" in your documentjs.json file which tells it to only look in the scss and docs folder, and to only look at files with .css, .scss, and .md extensions.
It's not a matter of DocumentCSS 'supporting' .scss - you just have to tell it what files to search. In theory, you could have it search all .xml or .txt files if you add those extensions to the glob pattern.

@netgfx This is an honest question, if you're not seeing any errors or any .scss.html files, have you used any tags in your actual scss files for documentcss to find? Something like the code below within your typography scss file:
/**
  * @stylesheet typography.scss Typography
  * @parent styles
  *
  * @description
  * Typography helps set the tone of the website. The specific details of the type system are demonstrated below.
  *
  **/

That should produce a typography.scss.html page when you run documentcss. The @stylesheet tag titles the page, the @parent tag tells it where in the navigation to put the page, while @description is of course, any text explanation of what's in the code.

Basically what I'm struggling with is that I have this:
/**
  * @stylesheet buttons.scss Buttons
  * @parent styles
  *
  * @description
  * All defined button styles and states belong here, including any "helper class" button style options, like `default`, `primary` etc.*
  * The same button styles have been applied to a button class, for use on other html elements emulating a button.
  *
  *
  * @demo demos/buttons.html
  *
  *
  **/

in a .scss file but the .scss.html is not produced, if I make this in a .less file the .less.html gets rendered normaly. And yes no errors.

@netgfx What does your documentjs.json look like?

+1 for a pre-built example to follow. Maybe even like a starter boilerplate. Better documentation of the document.json options would be super helpful too. Been struggling hard but I do believe this will help me finally make a pattern library that can be maintained!

Man... After so much wrestling I'm feeling so defeated.
The only way I could get a demo to work, after following the documentation step-by-step multiple times is to manually drag the demos folder into the generated styleguide folder, but it had none of the styles I set in the very stylesheet declaring the header and description in the view..
Couldn't get the bootdocs repo going either, all sorts of grunt errors claiming things like @media and @opacity aren't recognizable tags and stuff.
I'll have to manually maintain a jekyll site and lose out on all the awesome potential with this idea. I really hope you guys take it further, it could really rock the pattern library movement. Perhaps something totally separate from documentjs. I'll totally volunteer to make a hipster landing page for it if you guys do!

@brandonreid thanks for chiming in and sharing your experience. We think it's a really valuable tool and has great potential, but agree that the setup is difficult and frustrating. We use it every day in our client projects, so it is possible to make it work. Once you get past the set up, it's really rewarding to use.
If you guys don't mind, maybe I can screen share with you some time and see what it's doing for you. Would you be willing to do that? @netgfx ? I'd love to see if we can get it running for you.
As an aside, DocumentCSS does not do anything at all to the demos. The @demo is just a link/reference to the demo file, so you do have to manually move the demos where you want them. We usually overcome this by creating a grunt task that copies the demos. I would love that to be a feature.

@tomgreever I'd love to have a hangout sesh anytime and see if you might be able to help me out. Once I've got it running, I'll definitely make a ready-to-go boilerplate repo with said grunt/gulp task and what not.

@brandonreid email me<EMAIL_ADDRESS>and we'll set something up.
Bootdocs was meant to be that boilerplate, but maybe it has too much going on and we need something much simpler with just a couple of pages.

Hi,
I'm struggling with documentcss too. I tried to even create a simple css but had no success. Here is a clonable repo, what am I doing wrong there? https://github.com/gabrielhpugliese/documentcss-test
I've also tried to clone https://github.com/bitovi/bootdocs but the grunt task do not work raising the error:
[ml-site]gabrielpugliese@sapobook ~/Test/bootdocs(master) $node_modules/grunt-cli/bin/grunt documentjs
Running "documentjs-orig" task
Generating styles at styleguide
WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @media tag. did you mean @add ?

WARNING!!
There is no @opacity tag. did you mean @option ?

{ [Error: ENOENT, lstat '/Users/gabrielpugliese/Test/bootdocs/node_modules/documentjs/documentjs/node_modules/steal/steal.production.js']
  errno: 34,
  code: 'ENOENT',
  path: '/Users/gabrielpugliese/Test/bootdocs/node_modules/documentjs/documentjs/node_modules/steal/steal.production.js' }
Warning: ENOENT, lstat '/Users/gabrielpugliese/Test/bootdocs/node_modules/documentjs/documentjs/node_modules/steal/steal.production.js' Use --force to continue.

Aborted due to warnings.

@gabrielpugliese-luizalabs you can try https://github.com/brandonreid/documentcss_starter-kit from @brandonreid
I will look at that error you're getting and see if I can help.

@gabrielpugliese-luizalabs what version are you using?  Make sure to npm install<EMAIL_ADDRESS>

@justinbmeyer
"documentjs": "^0.4.1" in package.json
@tomgreever
Thx, gonna try it!

Well, tried the start-kit with node5 and npm3 but:
[new-node]gabrielpugliese@sapobook ~/Test/documentcss_starter-kit(master) $node_modules/gulp/bin/gulp.js dev
/Users/gabrielpugliese/Test/documentcss_starter-kit/node_modules/accord/lib/index.js:31
      throw new Error(name + " version " + version + " is not currently supported");
      ^

Error: less version 1.7.5 is not currently supported
    at Object.exports.load (/Users/gabrielpugliese/Test/documentcss_starter-kit/node_modules/accord/lib/index.js:31:13)
    at Object.<anonymous> (/Users/gabrielpugliese/Test/documentcss_starter-kit/node_modules/gulp-less/index.js:9:29)
    at Module._compile (module.js:425:26)
    at Object.Module._extensions..js (module.js:432:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:313:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/gabrielpugliese/Test/documentcss_starter-kit/gulpfile.js:3:12)
    at Module._compile (module.js:425:26)

@gabrielpugliese-luizalabs Try to remove gulp-less from package.json, then run npm install gulp-less, get a version of less that works for ya.

Thx @brandonreid, but didn't work. Tried to update everything without success too :( I'm taking a break right now, spent too much time with that.

I've been struggling with this for a little while now. The biggest problem I had was getting the index page to render correctly. It would default initially to a placeholder page. I was able to get the @stylesheet, @styles, @demos working and the @group working in some regards, but am thinking this will fall into place now with the @page straightened out.
I hope these notes are helpful.
I had the most problems with the @page tags.
I found reading what was generated in the style guide folder pretty helpful, particularly source and @group notes.
I found a couple small edits on the documentjs.json file helped immensely for building this styleguide.
It wouldn't recognize the parent value until I swapped the MD format to be first. Config documentation lists MD  format as last. Just a note to the maintainers.
JSON:
{
  'sites': {
    'styles': {
      'parent': 'styleguide',
      'glob': 'styles/*.{md, scss}',
      'dest': 'styleguide'
    }
  }
}

TEXT:
Parent: @page NAME TITLE - NAME from desired parent MD file.
Reference: http://documentcss.com/docs/lsg-quickstart-creating-page.html

@gabrielpugliese-luizalabs FYI, I found the problem you probably encountered. Pushed updates to the starter kit if you want to give it another shot.

Thanks @brandonreid !


RFP - ringcentralofficialclient

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL :https://www.ringcentral.com/
Direct download URL for the software / installer : https://app.ringcentral.com/download/RingCentral.exe
Software summary / short description:
meeting app by ringcentral

Just as a reminder, the package might be better being named ring-central-official-client


LibWeb: Use transform-box for resolving percentage transform values

This fixes issue https://github.com/LadybirdBrowser/ladybird/issues/1269
The content box was always being used to resolve transform length percentages, instead of the transform box. This PR factors out computing the transform box from PaintableBox::resolve_paint_properties. So that Transformation::to_matrix can use it, as its reference box.

Thanks for reviewing. I've added a ref test based on the original issue.


Added linux build steps

Refactored and added steps in readme for build steps in linux system.
Copied libbpf build script to scripts/

coverage: 83.337%. remained the same
when pulling 8c8fa9de5f7caba29a808a538b0ce421bc9f6a55 on the-m3chanic:main
into b0a1d98fa0a3368c5400ce2cb578fd3421ad100c on iovisor:main.


Support model_train's training_input_dir

Caikit supports an IBM proprietary training orchestrator. This orchestrator passes in a training_input_dir with training requests, which specifies where it has copied files to in the running container. If any file references exist in the training parameters as DataStreamSources, then caikit's handler should check if those files are in the training_input_dir and redirect the streams so the data can be loaded.

Closing in favor of #371


Reporting bug in modal

Hello, I work with bootstrap and I love it, so first I would like to thank you for the tool.
I'm working with modal and found a bug, where when I open a modal over another and close it, the scroll of the primary modal is broken, this is because the "modal-open" class of the body is removed.
I managed to solve it with the following command, but I would like to report it so I don't have to do it anymore.
Command:
$('#modal').on('hidden.bs.modal', function(e){
$("body").addClass("modal-open");
});
My version is: 4.6.1.

Thanks for reporting it @VitorErnandes.
Bootstrap v4 is EOL since the beginning of 2023 so no fix will be done for the v4.
Regarding the v5, it might correspond to https://github.com/twbs/bootstrap/issues/36463.


Auto change other nodes to Ignore when Match selected

When Match is selected for a node, set all other node options to Ignore automatically.

If a new match is selected while a different node is already matched, it will swap their states. This is useful, for example, if duplicate nodes were detected and it automatically selected one for deletion, but the other node actually makes more sense to use.
https://github.com/user-attachments/assets/7a262e84-1161-4bfd-8dfb-a0d752a4585e


Script not working

I am getting the following errors:
./pbs_stage1.py
Loading shows from web...
Traceback (most recent call last):
  File "./pbs_stage1.py", line 26, in <module>
    shows_result = json.loads(resp.text)
  File "/usr/lib/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Can you tell me what I am doing wrong?

I'm not sure, but I think that PBS has changed something on their end.  I've tried a few different scripts and none are working.


Tickmark for completed swagifacts

Currently, the course page looks like this:

With the checkmarks, a suggested design is like this:

This is implemented now, there is a test for it here:
http://content.tunapanda.org/courses/testing/how-are-you/
If you are logged in, complete that H5P and reload the page, there will be a tickmark.
On the way getting there, you will get some 500 internal server errors though... But that's a different issue...

I used the test link above but there is an error. Couldn't copy paste it but I took a screen shot.

aha...
in this case it is because the teacher user doesn't have a registered email... it only works if you are logged in and if you have a proper email address associated with the user...
but... it shoudn't give that error, it looks bad... will fix...

Awesome works now.

But how could it, I haven't changed anything... :)
I think we have a bug if the user doesn't have an email registered, let me fix that...

After some investigation...
Yes there will be an error if the user doesn't have an email address. But on 2nd though, this is ok, since not having an email is kind of an "error" to begin with.
So closing for now...


Not working for custom input images provided

The model doesn't generate the expected keyframes for the custom input image. While running it, it gives the output on the already provided image.
every time getting this image

Same Issue I faced today.

The model needs to be subject-specific finetuned (see instructions for "Finetune a Sample" in the README). The provided custom-chkpts are for the particular test image inside demo/sample from the UBC Fashion dataset.

So in the demo/sample/train folder we need to provide input image and its densepose by replacing it with it the already present files frames_50.png and frame_50_densepose.npy

Yes, then run the subject-specific finetuning for UNet and VAE.


Multiline placeholder input support

This pull request adds ability to use long multiline input placeholders. Related ExpandableTextView  now is able to change its size according to a size of a placeholder.

Codecov Report

Merging #638 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   61.22%   61.12%   -0.11%
==========================================
  Files          92       92
  Lines        4965     4967       +2
==========================================
- Hits         3040     3036       -4
- Misses       1925     1931       +6

Impacted Files
Coverage Δ

...ttoAdditions/Source/Input/ExpandableTextView.swift
68.99% <100%> (+0.48%)
:arrow_up:

...Chat Items/TextMessages/Views/TextBubbleView.swift
83.16% <0%> (-3.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be10289...0e11cc5. Read the comment docs.


Add a piped component that watches app configs

What this PR does / why we need it:
This PR adds a new Piped component that primarily watches two types of Applications that is:

already registered
unregistered

For the first one (already registered):

Piped sends only configs that have been changed since then
Contol-plane updates Applications stored in Datastore

For the second one (unregistered):

Piped sends all the latest configs every time whatever the repo is changed or not. The reason is the cache in control-plane is likely to be removed, and configs in Git is also likely to be removed
Control-plane caches them for suggesting when you attempt to add a new Application

Once this gets merged, I will drill into the detailed implementation.
Which issue(s) this PR fixes:
Fixes https://github.com/pipe-cd/pipe/issues/2755
Ref https://github.com/pipe-cd/pipe/issues/2750
Does this PR introduce a user-facing change?:

NONE

@nghialv I am very grateful for your careful confirmation. Based on your suggestion, I replaced the part that used to be the TODO comment with the implementation that actually updates it.
It's not exactly what you suggested, but I would say it's more readable than before. Please take a look at it when you have time.

It's not exactly what you suggested, but I would say it's more readable than before. Please take a look at it when you have time.

Sure. Let me check it.

Nice. It became more readable.
I have just left some nits but I am still reviewing this pull request.
And let me rewrite my suggestion this evening.

I have just left some comments. 👍
Please check out them and I will take another look at this PR later once they got resolved.

/hold

/hold cancel

@nghialv Thank you for your reviewing. I just applied your suggestions:

Separating the finding part and the reporting part to have some tests for finding logic.
Use env_name instead of env_id

I settled on using fs.FS so that we can test for the finding part using the file system in memory.

Okay, let me check it now.

@nghialv Applied everything you suggested! PTAL!

@nghialv I addressed the case you were worried about and revised some issues on file traversing. PTAL when you have time.
Again, a bit thank you goes out to you!

@nghialv Revised!

@nghialv Fixed

Looks good! Go ahead.
/lgtm

I just added a TODO comment

Way to go 🚀
/approve


Add verify functions

Fixes #8

getProof and getMultiProof automatically verify the proofs that they produced. IMO, this should be done using these new functions.
Otherwize looks good.

For getProof the change is quite simple:
     // check proof
-    const hash = this.tree[treeIndex]!;
-    const impliedRoot = processProof(hash, proof);
-    if (!equalsBytes(impliedRoot, this.tree[0]!)) {
+    if (!this.verify(leaf, proof.map(bytesToHex))) {
       throw new Error('Unable to prove value');
     }

But for getMultiProof its quite more complex because we need the leaves in T format
     // check proof
-    const impliedRoot = processMultiProof(proof);
-    if (!equalsBytes(impliedRoot, this.tree[0]!)) {
+    if (!this.verifyMultiProof({
+      leaves: indices.map(i => this.values.find(e => e.treeIndex == i)!.value),
+      proof: proof.proof.map(bytesToHex),
+      proofFlags: proof.proofFlags,
+    })) {
       throw new Error('Unable to prove values');
     }

I implemented that suggestion but I refactored the code a little to avoid converting back and forth between string and Bytes.

Do you mean that maybe they shouldn't be private? Let's keep them private for now because they work on Bytes values and not on strings like the rest of the StandardMerkleTree interface.
Eventually I would be interested in making standard and core both work generically on both Bytes and strings.

Do you mean that maybe they shouldn't be private?

I meant they should be private, which they are. My bad.

Eventually I would be interested in making standard and core both work generically on both Bytes and strings.

I know we don't like dependencies, but IMO there is already a de-facto standard for that:
https://github.com/ethers-io/ethers.js/blob/master/packages/bytes/src.ts/index.ts#L12

Can I directly call a similar method in JS and keep it consistent with solidity
solidity Provides such a method
function verify(bytes32[] memory proof, bytes32 root, bytes32 leaf) internal pure returns (bool) {
    return processProof(proof, leaf) == root;
}

https://github.com/merkletreejs/merkletreejs/blob/master/src/MerkleTree.ts
也实现了类似的方法：
verify (proof: any[], targetNode: Buffer | string, root: Buffer | string):boolean {

}

const tree = StandardMerkleTree.of();

Can Tree call verify directly?

tree. verify();


[Feature Request] Explicit Fields Only

Allow you to tell Parceler that it should only look for explicit fields only. Use case: I have ViewModels with a lot of dependencies on managers, final field callbacks, and other fields that I wish not to persist. If I do not mark them each as @Transient I end up with a class file like:
private static final CurrencyFormatter CURRENCY_FORMATTER = new CurrencyFormatter();

    private static final Comparator<Map.Entry<Long, ShoppingListProductViewModel>>
            AVAILABILITY_COMPARATOR = new ProductAvailabilityComparator();

    @Transient
    ObservableBoolean isRefreshing = new ObservableBoolean(false);

    long shoppingListId;

    boolean isPersonalShoppingEnabled;

    DropDownShoppingListViewModel allListsViewModel;

    @Transient
    private ShoppingListManager shoppingListManager;

    @Transient
    private CurrentStoreManager currentStoreManager;

    @Transient
    private ViewModelCommand<ShoppingListProductViewModel> productDetailsCommand;

    @Transient
    private AdobeTargetManager adobeTargetManager;

    @Transient
    @Inject
    AccountPreferencesManager accountPreferencesManager;

    @Transient
    private Responder responder;

    @Transient
    @Inject
    KeyboardController keyboardController;

I would love the inverse where only I can enable fields explicitly. This would be achieved via:
public enum FieldDetectionPolicy {
        /** Only parse and serialize fields annotated with @ParcelField */
        ANNOTATIONS_ONLY,

        /**
         * Parse and serialize all non-private fields that haven't been
         * annotated with @Transient.
         */
        NONPRIVATE_FIELDS,

        /**
         * Parse and serialize all non-private fields and accessors that
         * haven't been annotated with @Transient.
         */
        NONPRIVATE_FIELDS_AND_ACCESSORS
    }

This is very similar to how LoganSquare handles field detections, but then this would greatly improve the experience, especially when you only want to persist a small amount of data in an object. The new annotation would be: @ParcelField that we'd use for explicit field marking.
Also @ParcelField could be expanded to do more than just mark field explicitly, such as replace @ParcelPropertyConverter as the TypeRangeParcelConverter annotation too.

I understand the need.  This would be cleaner for situations where you have a class with fewer fields that you want serialized.
I'm very hesitant to add a new API to Parceler.  I wonder if the current API could be used to accomplish the same technique.  What about adding a new serialization strategy that requires explicit configuration?  We could then use the @ParcelProperty to be that explicit annotation:
@Parcel(Serizlization.EXPLICIT)
public class SomeView {
    private static final CurrencyFormatter CURRENCY_FORMATTER = new CurrencyFormatter();

    private static final Comparator<Map.Entry<Long, ShoppingListProductViewModel>>
            AVAILABILITY_COMPARATOR = new ProductAvailabilityComparator();

    @ParcelProperty("isRefreshing")
    ObservableBoolean isRefreshing = new ObservableBoolean(false);

    @ParcelProperty("shoppingListId")
    long shoppingListId;

    private ShoppingListManager shoppingListManager;  // <- transient
...
}

This does complicate the APIand goes against the configuration by exception methodology of Parceler and the mirrored java serialization.
I imagine you could also compose your view class with a contained data class that is Parcelable:
// Not Parcel
public class SomeView {
    private static final CurrencyFormatter CURRENCY_FORMATTER = new CurrencyFormatter();

    private static final Comparator<Map.Entry<Long, ShoppingListProductViewModel>>
            AVAILABILITY_COMPARATOR = new ProductAvailabilityComparator();

    SomeViewData data;

    private ShoppingListManager shoppingListManager;
...
}

@Parcel
public class SomeViewData {
    long shoppingListId;

    boolean isPersonalShoppingEnabled;

    DropDownShoppingListViewModel allListsViewModel;
}

Not sure if that plays well with your sub-elements (`DropDownShoppingListViewModel for instance).
Thoughts?

I think thats fine. A separate EXPLICIT serialization would be great with @ParcelProperty would work fine. The value() param should be optional and the annotation processor would just take the Element's simple name if not specified.

What do you think about the second composition technique?

It goes against the MVVM paradigm I feel like. The viewmodel is the usher between the view and the model. In this scenario, separating out those two things would lead to different architectural responsibility. Since the viewmodel responds to user interaction from the view, it makes sense to have the injected dependencies there. Also use @Parceler to save some of the viewmodel information such that when config changes or restore state happens, we can properly reconstruct the viewmodel correctly.

If you weren't using Parceler would you make your View-Model Parcelable?
In my architectures I typically only make Model classes serializable and use the ViewModel to marshal them.


Fix swagger example stubbing

I was getting a few errors when trying to stub requests against a swagger contract that had examples.
First off, the Swagger::ResponseClause did not have a to_hash method defined, so it was throwing an error here.
Secondly, the Webmock was complaining because the stubbed response body was being set to a Swagger::V2::Example object, instead of a string. I fixed this by calling parse on the example object before setting it in the response hash.

Changes Unknown when pulling 2bd52fbe72a37973ebecba3a1d67e9d0f13cd050 on fishermand46:fix_pacto_example_stubbing into ** on thoughtworks:master**.


Does not work with different nested monads

First and foremost, thanks for creating this project! I'm trying to find ways of making Scala easier for beginners to grasp and this definitely looks promising :)
Version: 0.0.13
Expected behavior
Can work with nested monads
import io.monadless.stdlib.MonadlessOption._, io.monadless.stdlib.MonadlessFuture._

val f1: Future[Option[Int]] = Future.successful(Some(1))
val f2: Future[Option[Int]] = Future.successful(Some(2))

// Doesn't work
val f3 = lift {
    val one = unlift(unlift(f1))
    val two = unlift(unlift(f2))
    one + two
  }

// Also doesn't work
val f3 = lift {
    val maybeOne = unlift(f1)
    val maybeTwo = unlift(f2)
    lift {
     unlift(maybeOne) + unlift(maybeTwo)
    }
  }

Actual behavior
Does not work]
 found   : scala.concurrent.Future[Option[Int]]
 required: io.monadless.stdlib.MonadlessOption.M[?]
    (which expands to)  Option[?]
  val maybeOne = unlift(f1)
                        ^
cmd22.sc:3: type mismatch;
 found   : scala.concurrent.Future[Option[Int]]
 required: io.monadless.stdlib.MonadlessOption.M[?]
    (which expands to)  Option[?]
  val maybeTwo = unlift(f2)

Workaround
Couldn't really find a workaround; I tried aliasing but obviously #4 means I that doesn't work.

Actually just found a workaround; use monadless with scala-async 🤣
Welcome to the Ammonite Repl 1.0.5
(Scala 2.12.4 Java 1.8.0_152)
If you like Ammonite, please support our development at www.patreon.com/lihaoyi
@ import $ivy.{`org.scala-lang.modules::scala-async:0.9.7`}
import $ivy.$

@ import $ivy.{`io.monadless::monadless-stdlib:0.0.13`}
import $ivy.$

@ import scala.concurrent.ExecutionContext.Implicits.global, scala.concurrent._
import scala.concurrent.ExecutionContext.Implicits.global, scala.concurrent._

@ import scala.async.Async.{async, await}
import scala.async.Async.{async, await}

@ import io.monadless.stdlib.MonadlessOption._
import io.monadless.stdlib.MonadlessOption._

@ val f1: Future[Option[Int]] = Future.successful(Some(1))
f1: Future[Option[Int]] = Future(Success(Some(1)))

@ val f2: Future[Option[Int]] = Future.successful(Some(2))
f2: Future[Option[Int]] = Future(Success(Some(2))

@ val f3 = async {
        val maybeOne = await(f1)
        val maybeTwo = await(f2)
        lift(unlift(maybeOne) + unlift(maybeTwo))
      }
f3: Future[Option[Int]] = Future(Success(Some(3)))


Update training operator  images to the latest

Training operator images are updated to the latest tag  in the release branch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.008%) to 35.423%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mpi/mpijob.go
1
91.06%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
4379

Relevant Lines:
12362

💛  - Coveralls


Question about license verification

Hello netlicensing team,
I have a question about license verification:
We use FLOATING licensing.  We adopted this for our solution.
Am I right in assuming that the Gateway returns a positive result if the Licensee has a valid license and the license count does not max out - meaning I just need to give the LicenseeNumber and the ProductNumber to my customers? The customer does not need an actual LicenseNumber?
Thanks in advance!

Usually, the following entities/numbers are being used as follows:
Product number / Product module number
=> are delivered (hardcoded) within the product (as these hardly change)
Licensee number
=> need to be communicated to the customer
(Floating model only) - SessionID
=> is determined in the product and can be, for instance, serial number, IMEI number or other hardware/machine fingerprint
License(-s)
=> don't need to be delivered at all, as this is logic of the NetLicensing and being executed at the validate request


Handle multiple adapters

There has been an attempt to add JSON API in this gem (#566 by @Dschee). It also seems that it has been previously discussed with @booleanbetrayal. But this PR introduces unrelated changes to JSON API such as translation, rubocop warning etc. This makes me think we eed to refactor this PR to get it properly reviewed and done. Put aside the unrelated changes, we still have a major work to get this working and doing a one-shot monstrous PR is out of the question for several obvious reasons :

The review will be hard achieve
The side-effect will hard the evaluate
A  major refactor will (possibly) bring breaking changes

We then have to go for it more iteratively.
First, I propose to introduce the base architecture to handle multiple request and response adapters.
Architecture
Here is the architecture I propose :
1. Determine the response format
We could have a controller concern ResponseFormat which will return a symbol of the format expected by the client. For now, it will only return :json. We expect it to also return :json_api in a future iteration.
The analysis will be based on the HTTP_ACCEPT content  or the default reponse format.
2. Determine the response adapter
We could have a concern ResponseAdapter deciding which adapter to use.
Here is the logic :
def response_adapter
  case response_format
  when :json then JsonAdapter
  when :json_api then JsonApiAdapter
  else NullAdapter
end

Then, response_adapter is called from the render_* methods living inside the controllers.
Example :
class PasswordsController
  def render_create_error_not_allowed_redirect_url
    response_adpater.create_error(...)
  end
end

Technical note : Each adapter will inherit from the NullAdapter. This adapter throw an exception warning about missing implementation.
Possible enhancement
We can push the concept forward by adding the support of other gems such as ActiveModel::Serializer (AMS) by adding a look-up in the adapters they tend to work with.
For example, we could have the JsonApiAdpater looking for AMS :
class JsonApiAdapter
  def call
    if defined?(ActiveModel::Serializer)
       JsonApiAdapter::AMS
    else
      JsonApiAdapter::Base
    end
  end
end

This way we can rely on the support of the most popular gem in the community instead of trying to re-implement the wheel. But this need to be discussed as it doesn't seem to be necessary neither.
Conclusion
This architecture tends to be designed with SRP (Single Responsibility Pattern) in mind and made to be easy to extend, not creating constraint.
With this changes in the architecture, we could easily implement the JSON API adapter and even allow custom adapter creation.
What do you think about that ?

@booleanbetrayal Can I have a feedback on that ? I am really willing to help you on this project. Plus I want to add the support  on EmberJS.
I would really appreciate something from you.

@ValentinTrinque I read your work above. I like this idea! I think it would allow us to gradually introduce JSON API and any other desired adaptors. Feel free to do some work if this is still relevant to you. Otherwise you can also feel free to close this issue.


Update index.html

In this project I have done the following:

Added two new section to the html file namely: Works and About
I arrange cards in the work section using css grid
I also arrange elements in the cards using css flexbox
I added categories in language categories in using ul and li tags


feat(chat): Disable various chat feature if not friend anymore

What this PR does 📖

Disables various chatting feature when one isn't a friend anymore:
Chatting will be grayed out with a text with a tooltip saying that you are not friends anymore
Buttons will be disabled (for e.g. attachment, sending msg, replies)
Note: Only applies to DM (participants of 2) and not group chats. One can always do things in group chats.
Maybe someone else has something to add here
Also fixed a thing in get_chatbar where extensions where assigned to the control field and not the extension field see https://github.com/Satellite-im/Uplink/blob/friend_chat_disable/ui/src/components/chat/compose.rs#L856

Which issue(s) this PR fixes 🔨

Resolve #421

Maybe @InfamousVague can help me test this more later this evening, -I had Windows and MacbookPro added as friends with a chat
-Removed MacbookPro from the Windows account
-MacbookPro_ side Windows was still a friend and able to message them
MacbbokPro
https://user-images.githubusercontent.com/93608357/224847015-abe91119-d30d-412e-9d72-f40216cc3ef3.mov
Windows
https://user-images.githubusercontent.com/93608357/224847040-d2b284b1-3ff7-4ec0-9cd1-56751413fa1d.mp4

if i have the app open and someone unfriends me it works. in fact during that it also removes the chat.
but if i am not online, someone unfriends me during that and i open the app again it still shows as friends.

Tested this with Hogan today, but couldn't get the chat to persist after removing each other. As soon as one of us did the chat would be removed from the sidebar so although thats the correct behavior we wanted originally its been making this a bit difficult to test. Going to try one more time this afternoon with @InfamousVague since he has this problem occur a lot

it is because in https://github.com/Satellite-im/Uplink/blob/dev/common/src/state/mod.rs#L874 it also removed the chat. what feature should be kept then? the removal or the disabling of chat?

Hi @Flemmli97 I was able to test with Matt and we could also not replicate the bug still but I asked Matt what he wanted to do and he suggested this,
If the other person in chat removes you, we should just grey out the call buttons and input box and not remove the chat for now. Matt made a mockup to reference

ok. the chat now doesnt get removed when someone unfriends you.
it should still get removed though if you unfriend them yourself (think that makes sense also).
the chat was getting disabled when the friend status is updated correctly. but the problem prior was that warp has some kind of delay updating things when you were offline and stuff happened.

review in progress

This is the real diff
changes.diff.txt

This is the real diff. GitHub was erroneously showing 62 files changed.
changes.diff.txt


Static Data Store versus sensu_remote_plugins

Hi and congratulations for this fantastic role and nice documentation.
There is one thing I don't understand though... I see that there is a sensu_remote_plugins variable that we can set in order to define which plugins we want to deploy. At the same time, in the static data store, we can also set some checks on a per group basis.
How these two methods interact? Do we need both?
Thanks in advance for enlightening me on this topic :)

Hi @vialcollet :wave:
Thanks for the kind words!
The sense_remote_plugins variable is completely independent from the plugins deployed via the data store. It's simply to expose the option to install plugins from Ruby Gems via the sensu-install command.
They can both be used at the same time, or on their own :+1:
Let me know if I can explain it any further, don't hesitate to ask any further questions.

Oh, ok ! So basically I can use the sensu_remote_plugin to deploy plugins from Ruby Gem and if I had my own checks I could use the Static Data Store.
Thanks I think I got the concept!
I'll let you know if I have any further questions.
And thanks a lot for the quick answer.

Yep, exactly :) No problem, thanks for using the role


fix typo in lib.rs

Just a little typo.

Coverage decreased (-10.5%) to 85.89% when pulling 0815c6715ca0cdf0ae5ff0b15f6f799942cf75a6 on benaryorg:benaryorg-patch-1 into a769e77497af0627242bd4bbf141eb23eb180ada on emoon:master.

Coverage decreased (-10.5%) to 85.89% when pulling 0815c67 on benaryorg:benaryorg-patch-1 into a769e77 on emoon:master.

That can't be right.

Thanks!

That can't be right.

It's not related to your changes but I'm not sure exactly why it happens.

It's not related to your changes but I'm not sure exactly why it happens.

I think it is because of the new Rust version. Maybe.

Yeah that might be it.


Removing state/city information from codeMap.csv because these fields…

… are unused

This commit was already part of pull request #84.  I don't think this pull is necessary.


Wrong there is one disconnected observation (no neighbors)

Hello,
I have this message "there is one disconnected observation (no neighbors) Island id:  [44]" with this code:
w = pysal.queen_from_shapefile("upz.shp", "NUMERO")
w.transform = 'b'

As you can see
w.neighbors[44]

gives me
[113, 45, 46, 47]

So even the code says the warning is wrong.
w.cardinalities.items()

dict_items([(1.0, 3), (2.0, 4), (3.0, 2), (9.0, 4), (10.0, 5), (11.0, 3), (12.0, 6), (13.0, 6), (14.0, 5), (15.0, 5), (16.0, 5), (17.0, 6), (18.0, 6), (19.0, 7), (20.0, 7), (21.0, 7), (22.0, 4), (23.0, 6), (24.0, 6), (25.0, 6), (26.0, 9), (27.0, 4), (28.0, 7), (29.0, 7), (30.0, 6), (31.0, 6), (32.0, 3), (33.0, 3), (34.0, 3), (35.0, 3), (37.0, 3), (38.0, 3), (42.0, 5), (44.0, 4), (45.0, 6), (46.0, 8), (47.0, 6), (48.0, 5), (49.0, 5), (50.0, 4), (51.0, 4), (52.0, 3), (56.0, 4), (57.0, 7), (58.0, 5), (59.0, 4), (60.0, 7), (61.0, 4), (62.0, 6), (63.0, 6), (64.0, 3), (65.0, 6), (66.0, 5), (67.0, 5), (68.0, 2), (69.0, 4), (70.0, 4), (71.0, 4), (72.0, 5), (73.0, 5), (74.0, 3), (75.0, 6), (76.0, 3), (77.0, 4), (78.0, 4), (79.0, 4), (80.0, 6), (81.0, 7), (82.0, 5), (83.0, 5), (84.0, 5), (85.0, 6), (86.0, 3), (87.0, 3), (88.0, 3), (89.0, 0), (90.0, 3), (97.0, 8), (98.0, 7), (99.0, 5), (100.0, 6), (101.0, 5), (102.0, 3), (103.0, 6), (104.0, 9), (105.0, 5), (106.0, 4), (107.0, 4), (109.0, 5), (110.0, 8), (112.0, 8), (113.0, 3), (114.0, 4), (115.0, 6), (116.0, 7), (117.0, 5)])

And the shapefile I have attached.
upz.zip
As you can see

Platform information:

posix.uname_result(sysname='Linux', release='3.13.0-32-generic', version='#57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014', machine='x86_64')

Python version:

3.4.0 (default, Jun 19 2015, 14:20:21)
[GCC 4.8.2]

SciPy version:

0.17.0

NumPy version:

1.10.4

Can you report pysal.version ?

'1.11.0'

The report is indicating that the shape at index 44 is an island. If you examine the screen shot, the shape at index 44 is the one highlighted, which is an island.
Once I know what version of pysal you have I can try to debug.

Shouldn't it report "89"?

Yes it should.  We can correct this behavior as the island check is being carried out before the check for an idVariable.
Can you report what you get from w[89]

w89
{}

The correct behavior should be:
In [3]: w = pysal.queen_from_shapefile('upz.shp', idVariable="NUMERO")
WARNING: there is one disconnected observation (no neighbors)
('Island id: ', [89])

In [4]: w.neighbors[89]
Out[4]: []

In [5]: w = pysal.queen_from_shapefile('upz.shp')
WARNING: there is one disconnected observation (no neighbors)
('Island id: ', [44])

In [6]: w.neighbors[44]
Out[6]: []

In [7]: w.neighbors[89]
Out[7]: [105, 42, 107, 86, 87, 88, 74]

I have a fix in for this in my branch b859


Add MultiAssignmentPatternOfConcat

It waits for https://github.com/chipsalliance/Surelog/issues/1917

It still doesn't work.


chore(test): add unit tests for 13 constants

Description

Wrote 4 unit tests to cover constants from URecoverySeedBox, USwitcher, UDropDownMenu, and UBottomSheet.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🗑 Chore

PS: Should I use chore(test) or feat(test) for test-related commit messages?

awesome, thanks @drepram 🎉
feat(test) should work fine btw


print human error message for ASPA pre-16

Hi,
I see the following output when encountering ASPA objects of the profile before the AS was removed,
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148807.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148804.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148801.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148802.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148810.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148809.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148803.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148806.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148800.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148808.asa: missing further values (at position 2).
[WARN] rsync://rpki.sub.apnic.net/repository/A914BC7A0000/0/AS148805.asa: missing further values (at position 2).

It might be nice to make this a human friendly message that says they likely are objects that follow a deprecated object format that is no longer accepted?

Agreed. There’s probably more places where this sort of thing happens.

Fixed in #917.


Hide dashboard item gear icon when not relevant

I'm not sure what it is that I'm no longer subscribed to here?
I'm not sure if this is happening because I can't unsubscribe to my own content, or because I can't unsubscribe to projects that I'm not a member of, but this tooltip is confusing.

This applies to updates about

[ ] project aggregation
[ ] taxon changes

Anything else you've noticed?

All I've noticed it on is project aggregation.


feat(tab-scroller): typescript

related #48

Codecov Report

Merging #536 into fix/coverage-typescript will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           fix/coverage-typescript     #536   +/-   ##
========================================================
  Coverage                    89.81%   89.81%
========================================================
  Files                           67       67
  Lines                         2495     2495
  Branches                        58       58
========================================================
  Hits                          2241     2241
  Misses                         247      247
  Partials                         7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2e2a7...3e3cb28. Read the comment docs.


error when windows anaconda run imagepy

I create an evn named imagepy and pip install all reqired package according to requirement.txt.
(imagepy) F:\github\imagepy>python -m imagepy
Traceback (most recent call last):
File "d:\Anaconda3\envs\imagepy\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "d:\Anaconda3\envs\imagepy\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "F:\github\imagepy\imagepy_main.py", line 3, in
from imagepy.core.app import loader, ImagePy
File "F:\github\imagepy\imagepy\core\app_init.py", line 1, in
from .imagepy import ImagePy
File "F:\github\imagepy\imagepy\core\app\imagepy.py", line 6, in
from sciwx.canvas import CanvasNoteBook
File "F:\github\imagepy\sciwx\canvas_init_.py", line 2, in
from .mcanvas import MCanvas, ICanvas, VCanvas
File "F:\github\imagepy\sciwx\canvas\mcanvas.py", line 4, in
from .canvas import Canvas
File "F:\github\imagepy\sciwx\canvas\canvas.py", line 5, in
from sciapp.object import Image, Shape, mark2shp, Layer, json2shp
File "F:\github\imagepy\sciapp\object_init_.py", line 1, in
from .shape import *
File "F:\github\imagepy\sciapp\object\shape.py", line 4, in
import shapely.geometry as geom
File "d:\Anaconda3\envs\imagepy\lib\site-packages\shapely\geometry_init_.py", line 4, in
from .base import CAP_STYLE, JOIN_STYLE
File "d:\Anaconda3\envs\imagepy\lib\site-packages\shapely\geometry\base.py", line 18, in
from shapely.coords import CoordinateSequence
File "d:\Anaconda3\envs\imagepy\lib\site-packages\shapely\coords.py", line 8, in
from shapely.geos import lgeos
File "d:\Anaconda3\envs\imagepy\lib\site-packages\shapely\geos.py", line 145, in
lgeos = CDLL(os.path.join(sys.prefix, 'Library', 'bin', 'geos_c.dll'))
File "d:\Anaconda3\envs\imagepy\lib\ctypes_init.py", line 348, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] 找不到指定的模块。

@yxdragon can you take a look?

it seems the geos package can't be installed. You may try to install this package independently and then return to condo to install imagepy.
My experience is that when I install imagepy with condo, it says that the pystackreg can't be installed and conda stoped to install imagery. I copy the pystackreg from the Pre-compiled package of imagpy (https://github.com/Image-Py/imagepy/releases) into the imagepy install direction. Then reinsitall imagepy again. Now the conda doesn't check pystackreg and successfully install imagery.

It is the matter of shapely, try the binary whl?

缺少geos_c.dll模块，在https://www.lfd.uci.edu/~gohlke/pythonlibs/#shapely，下载对应版本的Shapely的whl文件，重装即可。
Missing geos_ c. dll,  Download the corresponding version of shapely's whl file and reinstall it in https://www.lfd.uci.edu/~gohlke/pythonlibs/#shapely.


Host callback attempts to perform computation on GPU

Description
I am trying to run a computation including jax.numpy.linalg.eig on a GPU.
Since eig is not implemented with GPU backend, I am trying to use the experimental host_callback module to force the calculation to take place on the CPU. Unfortunately, it seems like an attempt is still made to run this on the GPU, which fails.
This code snippet reproduces the error, for example in colab with a GPU runtime.
def _eig_host(matrix: jnp.ndarray) -> Tuple[jnp.ndarray, jnp.ndarray]:
    """Performs an `eig` solve on the host (CPU)."""
    eigenvalues_shape = jax.ShapeDtypeStruct(matrix.shape[:-1], complex)
    eigenvectors_shape = jax.ShapeDtypeStruct(matrix.shape, complex)
    return hcb.call(
        jnp.linalg.eig,
        matrix.astype(complex),
        result_shape=(eigenvalues_shape, eigenvectors_shape),
    )

x = jax.random.normal(jax.random.PRNGKey(0), (3, 3))
_eig_host(x)  # This fails, because `eig` is not implemented for GPU.

What jax/jaxlib version are you using?
0.3.23
Which accelerator(s) are you using?
colab GPU
Additional system info
colab
NVIDIA GPU info
No response

the callback gives you CPU-bound numpy objects, so I think the ideal thing here would be to callback into np.linalg.eig.

Yes, this is what I originally intended, but for my version of jax and numpy, the jax implementation was much faster. So, I wanted to find a way to use the jax implementation.

Update:
jax.numpy.linalg.eig is now supported on GPUs with JAX version 0.4.36. See #24663 for more details.


[issue-687] Refactor/operator register api

Proposal

Change deprecated kubernetesClient.getVersion to KubernetesClient.getKubernetesVersion
Pass a non-null value as a parameter by creating defaultConfiguration in register(Reconciler reconciler)
Remove unnecessary null defense code

by #687

Just made a minor not, otherwise LGTM!! Thank you!

As #678 was merged into the base branch v2, there was a conflict with some codes of the PR. I'll fix this part and rebase it. :)

As #678 was merged into the base branch v2, there was a conflict with some codes of the PR. I'll fix this part and rebase it. :)

As #678 was merged into the base branch v2, there was a conflict with some codes of the PR. I'll fix this part and rebase it. :)

Conflict has been corrected and rebase has been completed with v2. :)

thank you @heesuk-ahn !


Youtube API grabs a video then takes its title, description and ID to populate YoutubePost data model

I still see the .gradle/ directory with files in it, could you remove it from this PR as we don't use gradle for the project?

I still see the .gradle/ directory with files in it, could you remove it from this PR as we don't use gradle for the project?

I searched it in my files but didn't find anything. Is there another way I can delete it?


Update to io-surface 0.6

This change is

CC servo/io-surface-rs#56

r? @nox (or anyone)

@bors-servo: r+

:pushpin: Commit a2a0b14 has been approved by jdm

:hourglass: Testing commit a2a0b14 with merge 530eb97...

:sunny: Test successful - status-travis
Approved by: jdm
Pushing 530eb97cafe0e3e1ed2aceba05601520df51ab43 to master...

Published to crates.io and filed servo/rust-azure#256


Continuous Workflow Monitoring Support

As discussed on calls - this is bringing in a few improvements/behavioural changes to the workflow-collector job and addressing some bugs. I've done some fairly thorough testing on my side but I can't account for all use cases. Let me know if there are any issues when you test and we can work to fix them!
Features

The workflow-collector job now runs in a loop, continuously assessing the health of all jobs in the Workflow. Any status change in jobs will now be sent to SumoLogic. Only once all Jobs are no longer in some form of running/in process state will the workflow-collector finish. This addresses the current issue with the workflow-collector where only the initial job status will be sent to Sumo, and often some are completely missed as they aren't running when the first API call is made to CircleCI.
Added timeout-seconds parameter (defaults to 600s/10mins) to end the workflow-collector early when required. This helps to account for any unforeseen edge cases which could cause the loop to never end... therefore consuming large amounts of CircleCI credits unintentionally.
Manually setting the Workflow status based on the overall health as the final step. This is a bit of a workaround to the workflow-collector job itself being a blocker to the workflow ever reaching its final state. We can make some best effort guesses at the end state based on it's current ( for example failing would become failed).

Bug Fixes

The workflow-collector job will now always send compact JSON payloads to SumoLogic.
The provided custom-data is now added to the job updates when sent to SumoLogic (this won't happen when job-collector command is being used as a step in the job as no data is sent to Sumo for these jobs by the workflow-collector).

Thanks @Jamian for raising this PR. Let me go through this and get back.

I am working on testing this feature update.

Hi @Jamian
Found this error while testing.
ShellCheck Errors Found
In ./src/scripts/workflow-collector.sh line 52:
NOW=date
^-^ SC2034 (warning): NOW appears unused. Verify use (or export if used externally).
^-^ SC2209 (warning): Use var=$(command) to assign output (or quote to assign string).
In ./src/scripts/workflow-collector.sh line 102:
if [[ ${JOB_STEP_NAMES[@]} =~ $JOB_COLLECTOR_NAME ]]
^------------------^ SC2199 (error): Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @).
For more information:
https://www.shellcheck.net/wiki/SC2199 -- Arrays implicitly concatenate in ...
https://www.shellcheck.net/wiki/SC2034 -- NOW appears unused. Verify use (o...
https://www.shellcheck.net/wiki/SC2209 -- Use var=$(command) to assign outp...
Exited with code exit status 1

Recommended Fixes for
Run Shellcheck
The error indicates that there are several issues in the script "workflow-collector.sh".
The variable "NOW" is assigned the value "date", but it is not used anywhere else in the script. It is recommended to either remove the assignment if it is not needed, or use the variable in the script if it serves a purpose. If the variable is used externally, it should be exported.
Example:
NOW=$(date)
Use the variable somewhere else in the script
echo "Current date and time: $NOW"
On line 102, the script is using an array comparison within the double square brackets [[ ]]. However, arrays implicitly concatenate within double square brackets, which can lead to unexpected behavior. It is recommended to use a loop or explicitly use the * symbol instead of @ to compare the array elements.
Example:
for name in "${JOB_STEP_NAMES[@]}"; do
if [[ $name == $JOB_COLLECTOR_NAME ]]; then
# Do something
fi
done
By addressing these fixes, the ShellCheck errors should be resolved.
Generated by CircleCI AI
@Jamian

Hey @JKashyap96! Thanks for the feedback, I've refactored as per the SpellCheck findings.

Hey @JKashyap96! Thanks for the feedback, I've refactored as per the SpellCheck findings.

But the errors are still present.

Hey @JKashyap96! Thanks for the feedback, I've refactored as per the SpellCheck findings.

But the errors are still present.

Yep, it'd help if I pushed the changes! 👌 They are there now.

Hi @Jamian ! The shellcheck/check test is still failing with the error message:
`./src/scripts/workflow-collector.sh
ShellCheck Errors Found
In ./src/scripts/workflow-collector.sh line 101:
if [[ " ${JOB_STEP_NAMES[*]} " =~ " ${JOB_COLLECTOR_NAME} " ]]; then
^-----------------------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.
For more information:
https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid...
Exited with code exit status 1`
Please check this and update. You could try to run the orb code in circleci to check for further errors and then update the PR as necessary.

@Jamian Please help me with my questions. Thanks.

Waiting on a set of data pushed to sumo for a workflow(example).
Everything else looks good to me.


Support for skipping OpenAI token limit validation during vLLM-Langchain integrations

vLLM offers an OpenAI-like inference server endpoint that allows it to be dropped into applications that currently use the OpenAI Protocol. This has been integrated into the python langchain package (https://python.langchain.com/docs/integrations/llms/vllm), but not the ruby gem. Hacking around it by using the base OpenAI constructor such as below leads to token length/limit validation errors
Langchain::LLM::OpenAI.new(
    api_key: "EMPTY",
    llm_options: {
        uri_base: "https://localhost:8000/v1/",
        extra_headers: {
             "Content-Type": "application/json",
         },
    default_options: {
         temperature: 0.2,
         chat_completion_model_name: "tiiuae/falcon-7b"
    }
)

Is there any plans to integrate this fully or has anyone been able to find a different solution to this?

Yup, I'm also having this issue when trying to implement the Perplexity API. @alexzfan did you already write a PR for this?

We got rid of the max_token validation a while back so I'm closing this ticket.


ffprobe ignores the rtsp_transport setting and fails to probe the camera

Hi,
I am setting up a camera surveillance system and I am trying out Viseron for the first time. So far I am not able to add my camera and after longer fiddling I think I found out what the issue may be.
Viseron uses ffprobe to get some info about the stream coming from the camera, this kept failing:
[2024-11-08 21:19:02] [ERROR   ] [viseron.components.ffmpeg.stream.camera_1] - Retrying None in 2.0 seconds as it raised FFprobeTimeout: FFprobe command timed out after 15s.

Since I was able to play the rtsp URL with vlc I figured I'd also try ffprobe on my notebook and it hangs when probing the stream. Turned out, that for some reason UDP does not seem to work for me, so ffprobe requires the -rtsp_transport tcp parameter, then it returns the stream information right away.
I checked Viseron documentation and there is a config option called rtsp_transport which according to the docs is anyway set to tcp by default, I still did set it just to be sure, but it seems that this setting is not being propagated to the ffprobe call:
[2024-11-08 21:18:47] [DEBUG   ] [viseron.components.ffmpeg.stream.camera_1] - FFprobe command: ffprobe -hide_banner -loglevel error -print_format json -show_error -show_entries stream=codec_type,codec_name,width,height,avg_frame_rate rtsp://*****:*****@xxx.xxx.xxx.xxx:554/stream=0

I still need to investigate why UDP is not working on my camera, but currently this is quite a blocker for me, because I can't tell Viseron to use tcp when probing and thus it just keeps spinning, trying to register the camera :(

Sorry you are having issues!
You are correct, ffprobe does not look at the RTSP transport.
Over the years i have had many users with the same issue, FFprobe timing out.
This might be the solution to that!
Made some quick changes, builds should be done in a few minutes.

You can follow the build progress here: https://dev.azure.com/jespernilsson93/Viseron Pipelines/_build?definitionId=8&_a=summary
When it is done you can try it out by pulling the dev Docker tag

@roflcoopter wow, that was fast, thank you! The dev build worked fine, I can confirm that your fix solved the issue for me.

Great! Yeah it was easy since you figured out the problem already so thanks for that


[PLUGIN-474] Fixed BigQuery Plugins Not Deleting Temporary Files

See PLUGIN-474 for more information.
Currently, when a user specifies a temporary bucket for BigQuery plugins, the Avro temporary files left behind are not cleaned up. This PR solves this problem by making the following changes:

Change from using the deprecated fs.gs.system.bucket to use fs.default.name so that we can specify the subdirectory of a GCS bucket as the base path
Create a new temporary subdirectory in the GCS bucket, whether the created temporary bucket or the user provided bucket, using the run ID as the name, and set the Hadoop base path using this temporary subdirectory
Delete the temporary subdirectory after all runs

/gcbrun