"a task is already running"... forever

For example:
$ pomo start 23
$ a task is already running
Then try,
$ pomo help complete
as well as,
$ pomo help remove
I have not been able to stop this task from running for days. originally, if I could figure out which task it was I could manually remove it and just engage future tasks as $ pomo start --progress which would conclude the task after 25 minutes.
Right now I am buried in a list of tasks and will probably be forced to remove them one at a time to test which one is still running. There should be a way to identify what task is "currently running" and remove or stop it if you aren't using --progress.
Thanks much.

I've the same problem. Do you use tmux?
I didn't had this problem until I enabled tmux.


[REJECTED] Support for Host schema, route options and http schemes

tl;dr; I don't think this is  a good idea, and we should implement an event dispatcher instead.
This PR is In reponse to the PR https://github.com/symfony-cmf/RoutingAuto/pull/21 which adds support for mapping arbitrary values to route methods, which aims to solve the issue https://github.com/symfony-cmf/RoutingAutoBundle/pull/139
This PR adds support for adding a host, schemes [ http, https ], and route options to the routing auto configuration:
foobar:
   uri_schema: bar/foo
   host_schema: sub.{domain}.com
   token_providers:
       domain: [ content_method, {method: 'getDomain'} ]
   allowed_schemes: [ https ]
   route_options:
       custom_option: one
       custom_option: two

All of the above options can be mapped directly to Symfonys Route object.
There are problems however with the host_schema:

We will need to refactor conflict resolution
We need to change the adapter interface
Token provides now have a dual role in providing tokens for URLs and Hosts -
which are two different things.

And, for all that I do not think it good practice to store the host name
in the route, neither in PHPCR or in an ORM. This is breaking the DRY rule.
The host name would be better placed (in PHPCR) as part of the path, and in
an ORM as an ID refering to some Host table.
Saying that, storing the host or anyother attribute in the Route document could
be easily facilitated if we implement an EventDispatcher.
So basically, I suggest that we forget about this for now and instead implement an Event Dispatcher and a cmf_routing_auto.post_auto_route event or some-such.
p.s. If we implement the Event Dispatcher then the conflcit resolver would still need to be aware of the host property of routes, which I think would be a harmless addition.

Closing

wtf


doesnt work on mac

the second you toggle it on it turns off and crashes

This is known, see #18

Closed by https://github.com/RS117/RLHD/pull/59

works now


[Accessibility]A11y_AzureDataStudio_MapDataSrcObjects_ScreenReader: After performing any action on checkbox under "Nullable " header, focus doesn't move to any other element.

Check out Keros! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
Environment Details:
Test Pass Name: A11y_AzureDataStudio
MAS: MAS3.2.2; MAS1.3.1
Application name: Azure Data Studio
Version: 1.9.0-insider (user setup)
Commit: 2ca39b5
Electron: 3.1.8
Node.js: 10.2.0
V8: 6.6.346.32
OS :Windows_NT x64 10.0.18362
JAWS Version: 2019.1906.10 ILM
Additional Details:
Tools Name: JAWS
MAS References: MAS3.2.2,MAS1.3.1
Steps to Reproduce:

Install the app Azure Data Studio.
Enable SQL server2019 preview->select table from the database->Create External Table screen should open->Next button->Create Database Master Key screen should open->click on next button->fill all the required details->click on next button.
Select any tree view item from left panel using arrow key and press enter.
Navigate till table using basic navigation
Navigate to checkbox using downward arrow and perform action using spacebar.
Observe that after performing any action on checkbox under "Nullable " header, screen reader focus doesn't move to any other element.

Actual:
While navigating table using downword arrow, after performing any action on checkbox under "Nullable " header, screen reader  focus doesn't move to any other element and gets trapped on that checkbox.
Expected:
After performing any action on checkbox under "Nullable " header, Screen reader focus should move to next column that is "Collations".
User Impact:
Screen reader only users find it difficult to navigate the table because if they are using basic navigation that is up/down arrow, then after performing any action they unable to move on next column .
Recommendation:
Please refer the following snippet link for fixes:
https://microsoft.sharepoint.com/teams/msenable/mas/Pages/browse-fixes.aspx
MAS Reference :
MAS3.2.2:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={24cbfff7-374e-42e6-b9ab-d87fcd53b3e8}
MAS1.3.1:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Attachment for Reference:
6168_[Accessibility]A11y_AzureDataStudio_MapDataSrcObjects_ScreenReader.pptx
Does this issue occur when all extensions are disabled?: Yes

Seems similar to this issue #6800
Should be fixed in this PR  https://github.com/microsoft/azuredatastudio/pull/6882

@AccessibilityTestingTeam-TCS I'm closing this since it seems to be working with tab navigation. The issue mentions using down arrow to navigate though - is that required in addition to tab navigation?


fix(forms-web-app): add further coverage to meet new jest minimums

Extract routes to separate file, add missing coverage to controllers
Ticket Number

NA - fixup previous PR order merging issue with jest minimums
Description of change
Extract routes to separate file, add missing coverage to controllers
Checklist

[ ] Requires infrastructure changes
[ ] I have updated the documentation accordingly
[x] I have merged commits to avoid fixing things in this PR
[ ] New features have tests
[ ] Breaking change (team conversation required)

Important
Please do not merge from master (please only rebase). This keeps the history linear and easier to debug.

ty


where can we find the roadmap ?

The next version of Ractive we have wait a long time,can we have a timeline ,thanks

I'm afraid we adhere to the John Carmack 'when it's done' philosophy of release cycles around here, much as we try to be a bit more disciplined. The good news is that the big chunk of work standing in the way of the next version (0.8) has been merged, so now it's a case of fixing any major bugs and tidying up the build a bit. Next couple of weeks hopefully, depending on how things go!


Not Retrieving Kyber SAI Sell price

I cloned and ran this application but it returned 0 for the value of the Kyber SAI Sell price.

@kennisnutz Kyber no longer supports SAI from my understanding

I confirm, SAI is not present in list of token in Kyberswap app.
See below :
https://www.kyberswap.com/swap/eth-knc
@mikedeshazer I think the issue can be closed.

thanks for the clarification


Pak working allyears

Hi @gronert-m Mario,
The PAK branch now is ready for merging to the main with country survey details done. Kindly review the branch and let me know if anything needs revision. I will take a look at it next Thursday when I am back. Thanks!

@Junying-T  Thanks for this. There where some conflicts that I quite not know how to sort so it was dealt with in #320
Please check it. If alright please close all Pakistan related pull request and delete branches we no longer need

@Junying-T please close the request as it was dealt with in #320, additionally, delete all PAK branches that are no longer needed, please.


Remove initializer and check for header & footer

Fixes #7
Overriding the default container.lookup to avoid errors when a consuming
app does not have a header or footer template seems drastic.
The method in this commit instead checks the container for the templates
and only returns the template path to the partial helpers if it is found.
However, in Ember 1.11.0, this.container.has is deprecated.
There may be another way to go about this altogether, but for now this
seems to work until a better solution is found.

Any thoughts on this,  @tzellman?

Thanks. I finally got around to updating everything to cli 0.2.3. This is essentially the same change except I decided to drop the header/footer lookup altogether. Apps can just provide their own.
The real reason I added the override was to not crash the app (especially during development) if a slide lookup fails (e.g. you referenced a slide you haven't created yet). This violates the fail-fast principle, which I usually abide by, so removing this is a good thing anyway. Now, apps will just fail if a slide isn't found, but oh well. :)
https://github.com/tzellman/ember-slide-show/commit/4bf20e7af82ad655a7c742ed61a8a622286b5f82


Audio Support?

Curious, is audio currently supported with Greenscreen?  I set up the nyan test channel and noticed the audio isn't coming through.

Unfortunately, audio isn't supported!
On Mon, Jan 5, 2015 at 2:32 PM, Joe Mainwaring<EMAIL_ADDRESS>wrote:

Curious, is audio currently supported with Greenscreen? I set up the nyan
test channel and noticed the audio isn't coming through.
—
Reply to this email directly or view it on GitHub
https://github.com/groupon/greenscreen/issues/25.

That is unfortunate!  Do you know if it's a technical limitation, or simply lack of support for the feature?

Audio is working fine on my end. Just use a  or even  tag. Audio comes out fine through the tv which is then routed to speakers

@doubleaa93, are you rendering a publicly available URL? If so, can you share so I can test?

@theaccordance , Here is a jsfiddle with a audio tag point one of your channels to it and test if sound comes out fine. https://jsfiddle.net/6uxc2cpa/embedded/result/
It just uses html5 audio tags


Add support for nginx 1.6.2 stable

I'm looking into the issue but it seems simple for someone that knows the nginx api.
The error message is from ngx_http_upstream_server_t not having a name field in 1.6.2
/root/nginx/nginx-upstream-dyanmic-servers/ngx_http_upstream_dynamic_servers.c:212:5: error: ‘ngx_http_upstream_server_t’ has no member named ‘name’
   us->name = u.url;
     ^
`

Very sorry for the super-long delay! I was only targeting nginx 1.7 when I first built this, but any pull requests are welcome for older versions.


Update Composer dependencies (2023-07-22-00-13)

Visual regression test passed!
View the visual regression test report


ICON width issue?

System   :  Ubuntu Kylin 15.04
Software :  Gvim 7.4
Bundle    :  Vundle
Fonts      :  DejaVu Sans Mono for Powerline Plus Nerd File Types Mono 10
and other font get same issue too~
after I update my Nerdtree plugin.
may I upload my .vimrc file ?
-- download the picture and rename to [ vimrc ] --

Thanks, saw your vimrc. I will check it out.
Whats with the gray highlighting or is that part of the issue?

@ryanoasis
there is  a space between ICON and FILENAME.
The color scheme name is [ hybrid ] .. other themes also make same issue.

@DemonCloud I still haven't looked at this yet but for now you could try adjusting this setting:
let g:WebDevIconsNerdTreeAfterGlyphPadding = ''

@DemonCloud can you see if this solution fixes your issue: https://github.com/ryanoasis/vim-webdevicons/issues/53#issuecomment-108127414

@ryanoasis  Yeah. I get it now

@DemonCloud This is pretty much done and fixed just want to do a bit more testing before releasing. If you would like to check this out on branch 0.4.3 I would be grateful

@ryanoasis
How I config the vimrc file . I was getting same issue with PluginUpdate
Please see this picture and how do I highlight the gray line

I fix the Problem with
autocmd FileType nerdtree syntax match hideBracketsInNerdTree "\]" contained conceal containedin=AL


vLLM seems to not properly be using CUDA_VISIBLE_DEVICES

Hi,
I am receiving this error:
03:49:34 [Model Analyzer] DEBUG: Triton Server started.
03:49:58 [Model Analyzer] Model llama_config_0 load failed: [400] load failed for model 'llama': version 1 is at UNAVAILABLE state: Internal: ValueError: invalid literal for int() with base 10: 'GPU-16d07083-ab1d-cd47-d8bb-9e7f83104985'

At:
  /usr/local/lib/python3.10/dist-packages/vllm/platforms/cuda.py(86): device_id_to_physical_device_id
  /usr/local/lib/python3.10/dist-packages/vllm/platforms/cuda.py(96): get_device_capability
  /usr/local/lib/python3.10/dist-packages/vllm/attention/selector.py(215): which_attn_to_use
  /usr/local/lib/python3.10/dist-packages/vllm/attention/selector.py(108): get_attn_backend
  /usr/local/lib/python3.10/dist-packages/vllm/worker/model_runner.py(842): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/worker/worker.py(99): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/worker/worker_base.py(444): init_worker
  /usr/local/lib/python3.10/dist-packages/vllm/executor/gpu_executor.py(23): create_worker
  /usr/local/lib/python3.10/dist-packages/vllm/executor/gpu_executor.py(104): _create_worker
  /usr/local/lib/python3.10/dist-packages/vllm/executor/gpu_executor.py(37): _init_executor
  /usr/local/lib/python3.10/dist-packages/vllm/executor/executor_base.py(46): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/engine/llm_engine.py(270): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py(272): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py(840): _init_engine
  /usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py(636): __init__
  /usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py(740): from_engine_args
  /opt/tritonserver/backends/vllm/model.py(161): init_engine
  /opt/tritonserver/backends/vllm/model.py(115): initialize
;

03:50:03 [Model Analyzer] DEBUG: Stopped Triton Server.
03:50:03 [Model Analyzer] No changes made to analyzer data, no checkpoint saved.

When running this model, I am explicitly setting the environment variable: CUDA_VISIBLE_DEVICES="0". For some reason, based on the error, it seems like it is not setting this value properly when running vLLM. It is a very similar error to this issue, but a little different since I am not using MIG. Any idea of how to fix this issue? This is how I am running the application via Kubernetes with the Dockerfile from y'all's repo:
model-analyzer -v profile \
               --model-repository /home/model_repo \
               --export-path /app/models/analyses/llama \
               --client-protocol http \
               --triton-http-endpoint <IP_ADDRESS>:8000 \
               --triton-launch-mode local \
               --profile-models

Model Analyzer does not support vLLM models and we have not tested these, so we cannot guarantee it would work. I would suggest using the GenAI-Perf tool to profile: https://github.com/triton-inference-server/perf_analyzer/tree/main/genai-perf and see if that resolves your issue.

Thank you for the quick reply! I'm unsure if genai-perf provides the kind of automated tuning that I am hoping for, but I can manually run through the configs using. I'll go ahead and close this if you have no plans for supporting vLLM with the model_analyzer. Y'all might put that information in your docs so that it is clearer for others.

I'd be interested in knowing what type of tuning you are interested in? We can see about adding this to GenAI-Perf in the future. Thank you.


269302

update "has" to "and" since the first "has" doesn't make sense

#sign-off

@adegeo please review


Changing DefaultGzipDecoder's charset to UTF-8

Problem Statement:

When tested with a UTF-8, DefaultGzipDecoder returned with garbage data because it is using latin-1 charsets.
The added test case in the PR proves such case.

Suggestion:

SpringEncoder.java uses UTF-8 by default  So it makes sense to use UTF-8 when decoding.

@ryanjbaxter any feedback? If you want, I can make it into another option and users can decide which charset they want to use

Thanks!  I dont see why we weren't using UTF-8 before.
@spencergibb @OlgaMaciaszek and ideas?
@jskim1991 I would submit this PR against the 2.1.x branch and we can merge it forward.

I don't know, but it was intentional. Maybe have it configurable if user wants previous default?

@ryanjbaxter This code was introduced in 2.2.x. So it is not possible to submit this against 2.1.x. I didn't consider much about charset when I first wrote this. However, now I see that default value should be matching with what you guys think default should be. My guess is it is UTF-8 based on code elsewhere such as SpringEncoder.

@ryanjbaxter @spencergibb In terms of charset, it would depend on the language and country. As you see in the added test case in this PR, languages using UTF8 will fail. So if we want to support globally, having an option provides more variety. In terms of how to write the test case, I couldn't think of any better case that uses a different language. If you don't like that or have any suggestions, please let me know.


[CWS] remove wrong json tag on EventSerializer on windows

What does this PR do?
This tag should not be here (and is not on linux) because it create a new json layer evt instead of embedding its fields.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@mftoure can you cws-go-generate this on windows ? This PR currently only has the "fix" to the tag but not what should be generated from it which will actually fix the issue. Thanks !


set up codeclimate properly

add a .codeclimate.yml or whatever the hell.
 is a little embarrassing, even if it doesn't mean much

It seems like enabling the project on codeclimate will be enough. I guess only Owners can do that.

@boneskull @dasilvacontin It looks like any member should be able to do this, unless the third-party restrictions are in place. https://docs.codeclimate.com/docs/open-source-free#administering-open-source-repositories

We use Coveralls now.


Add more details about retention to storage docs

Make compaction docs a little more clear, easy to find.
Expand compaction docs slightly.
Add notes about block cleanup to operational section.

Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

@brian-brazil Made some adjustments to the wording.


Serde For stream Producer.

I use these dependencies.
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-stream-binder-kafka-streams</artifactId>
		</dependency>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-stream-binder-kafka</artifactId>
		</dependency>

My producer & processor:
@Bean
public Supplier<Flux<Long>> interval(){
	return () -> Flux.interval(Duration.ofSeconds(1));
}

@Bean
public Function<KStream<String, Long>, KStream<String, Long>> processor(){
	return kstream -> kstream
						.peek((k, v) -> System.out.println("Processing : " + v));
}

My config:
spring.cloud.stream:
  function:
    definition: interval;processor
  bindings:
    interval-out-0:
      destination: interval
    processor-in-0:
      destination: interval

The producer writes into the kafka topic successfully. But it seems to be in byte[]. Because of that processor is unable to convert that to Long,. How to use Serde here. I have used various options. nothing seems to work.
This does not seem to help
spring.cloud.stream.kafka.streams.binder.configuration.default.key.serde=org.apache.kafka.common.serialization.Serdes$StringSerde
spring.cloud.stream.kafka.streams.binder.configuration.default.value.serde=org.apache.kafka.common.serialization.Serdes$LongSerde

@uselvvi I think the problem is the incompatibility of the deserializer on the Kafka Streams side with the serializer (JSON converter) used on the producer side. By default, Spring Cloud Stream uses application/json as the content type that uses a special converter to serialize using Jackson. This converter takes the JSON representation of your payload and writes the resulting byte[] on the wire. In your case, toString() is called on the Long type by the converter, and the byte[] representation of that, is written into the Kafka topic. If you would have written a normal consumer based on the regular Kafka binder that consumes this data, your payload will be converted back to the Long type using the same JSON converter. However, in your case, the consumer is a Kafka Streams binder based processor which by default, uses the native Serde mechanism as the deserialization strategy. Kafka Streams binder expected the data in the topic to be of Long, but finds String and hence your error. You can fix this by making the producer use native serialization, thus skipping the message conversion provided by Spring Cloud Stream on the producer side. In order to do this, please make the following configuration changes. It should let you deserialize to a proper Long type on the consumer side.
spring.cloud.stream.bindings.interval-out-0.producer.use-native-encoding=true
spring.cloud.stream.kafka.bindings.interval-out-0.producer.configuration.value.serializer=org.apache.kafka.common.serialization.LongSerializer

@sobychacko
Hi Soby,
You are awesome. It works great!
Thanks.


Support back button (restore) even if page loaded in frame does not contain matching HEAD

Purpose
Resolves #1241
Approach
Set the location on the session even if the PageView does not render because the trackedElementsAreIdentical is false.
Test
This test illustrates the issue, once you remove line 6 from three.html
npx playwright test -g "promoted frame navigations are cached"

Would a better option for testing this would be the src/tests/functional/frame_navigation_tests.js.
Something like: https://github.com/hotwired/turbo/compare/main...tleish:turbo:turbo-frame-back-navigation?expand=1

promoted frame navigations are cached

It looks like you added goBack testing to frame navigation with data-turbo-action whereas I removed the <script> tag from three.html and tested promoted frame navigations are cached.
I think I do like your testing approach a bit better. Will try to switch to it when I get a chance. The only piece I didn't quite understand is where you removed lines 114-117. Maybe you could help me understand that change?
Have you found a better way to resolve the issue?

The only piece I didn't quite understand is where you removed lines 114-117. Maybe you could help me understand that change?

Ignore those changes,I must’ve cut-paste instead of copy-paste.

Have you found a better way to resolve the issue?

The test is as far as I got.

Confirmed that your testing approach accurately reproduced the issue and was resolved by the proposed implementation. Pushed. Thanks @tleish
Looking forward to seeing any alternative implementation ideas. I'm not convinced this is the best possible way to resolve the issue.

I believe the fix is a bit simpler.  It appears with a turbo navigation that includes an action, turbo does the following:

Calls FrameController#loadFrameResponse where it loads and updates the frame on page
During this method, it calls await this.fetchResponseLoaded(fetchResponse); which is defined inside of FrameController#proposeVisitIfNavigatedWithAction
frame.delegate.fetchResponseLoaded defined within FrameController#proposeVisitIfNavigatedWithActionsimulates a "Turbo#visit" (last line) wherein the PageSnapshot is updated with the HTML from the mocked response object.  Instead of setting the HTML to be the frame html, we could set it to be the current/updated page HTML (which has the frame contents loaded at this point).  Doing this means that the PageSnapshot.headSnapshot.trackedElementSignature will always match when the logic compares the history for back navigation.

see: https://github.com/hotwired/turbo/compare/main...tleish:turbo:turbo-frame-back-navigation?expand=1

That's a direct revert of https://github.com/hotwired/turbo/commit/ed72ba16bc23dcccd88e0ab76ba72cfef82cd599
I guess I wonder why that change was made.

I'm happy to switch to that implementation in this PR if you think it's a better approach.

That's a revert of part of ed72ba1

Hah!  You mentioned this before on the issue thread.  I didn't look at it, but you are right.  It's a revert of this commit.

Looks like this was discussed here: https://github.com/hotwired/turbo/pull/887#discussion_r1376602627

This seems to continue to be a problem, what can we do to get this merged?


Loop Protection!! We have tried to solve 3 time(s) in a row.

Hi Sir, I'm getting error for the below code. Hope you can advise
ERROR:root:"https://hotlink.cc/login.html" returned an error. Could not collect tokens.
cloudscraper.exceptions.CloudflareLoopProtection: !!Loop Protection!! We have tried to solve 3 time(s) in a row.
import cloudscraper

cookie_value, user_agent = cloudscraper.get_cookie_string(
    'https://hotlink.cc/login.html',
    browser={
        'custom': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36'
    },
    recaptcha={ 'provider': '2captcha', 'api_key': 'xxxxxxxxxxxxxx' }
)

print('{}'.format(user_agent))
print('$$$')
print('{}'.format(cookie_value))

@Goldenpistol i actually put a fix for this today in the dev branch, feel free to test it out and let me know how it goes :)

I also noticed that this site isn't follow RFC for http
> HTTP/1.1 302 Found
> Date: Fri, 27 Mar 2020 06:43:13 GMT
> Transfer-Encoding: chunked
> Connection: keep-alive
> Set-Cookie: cf_clearance=b6df3589e73d3afca070824cbddc39acb874dec9-1585291393-0-150; path=/; expires=Sat, 28-Mar-20 07:43:13 GMT; domain=.hotlink.cc; HttpOnly; Secure; SameSite=None
> Set-Cookie: __cfduid=dc90c50e95fe93375a79f8394bd5a73551585291393; expires=Sun, 26-Apr-20 06:43:13 GMT; path=/; domain=.hotlink.cc; HttpOnly; SameSite=Lax
> Set-Cookie: lang=english; domain=.hotlink.cc; path=/
> Location: http://hotlink.cc/login.html
> CF-Cache-Status: DYNAMIC
> Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
> Server: cloudflare
> CF-RAY: 57a722c8ba85fb7c-AKL
>
Set-Cookie: lang=english; domain=hotlink.cc; path=/
Expires: Thu, 26 Mar 2020 06:43:13 GMT
Date: Fri, 27 Mar 2020 06:43:13 GMT
Content-Type: text/html ; charset=UTF-8

<html>
<head>

    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="description" content="hotlink.cc - Free file upload service">
    <meta name="keywords"    content="file upload,share files,free upload">
    <title>hotlink.cc - Easy way to share your files</title>

it gives a 302 redirect with a new location but also has a body payload 🤕

ahh... i see it 302'd to http from https

I would also honestly recommend you do the get cookies on https://hotlink.cc/ rather than https://hotlink.cc/login.html due to how that 302 is behaving...

Thanks. But...what do I need to do to test the dev branch :s


test: loosen match in Frontend/crash-in-user-code

The test checked for Stack dump: but on the VS2017 build, the output
is Current stack trace: which would prevent the match.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test

CC: @shahmishal

@swift-ci please smoke test


loyalty seo metadata & og:image (fixed)

sorry @nachoiacovino i broke prettier again :(
i'll learn how to stop doing this

@nachoiacovino does this work? https://github.com/thirdweb-dev/dashboard/pull/1479

Superseded by #1483 this branch was doing weird stuff


PACT documentation is not available

Multipe github pact documentation links seems to be broken (404 Page Not Found):
-https://github.com/DiUS/pact-jvm/blob/master/pact-jvm-provider-spring/README.md

https://github.com/DiUS/pact-jvm/tree/master/pact-jvm-provider-maven
https://github.com/DiUS/pact-jvm/tree/master/pact-jvm-provider-gradle

Steps to reproduce:

Search PACT jvm on google
Click on a link that contains github.com/DiUS/pact-jvm/
Check displayed page

Results:

404 page not found

It seems that the links somehow changed and Google is still indexing the old links.
Fix:
add /provider after /master
e.g: https://github.com/DiUS/pact-jvm/tree/master/provider/pact-jvm-provider-maven => this is how it works

Looks like the last time Google indexed the site was 29 May 2019 19:20:20 GMT.


No Arrow Heads in Ember Apps

Due to 'marker-end' using a url reference to put the arrow head on the pointers, I was only seeing the arc, but not the end of the arrow in my Ember App.  I soon discovered it was because of the way Ember manages its routing.
Managed to fix it by getting the URL when making the SVG, then adding it to the properties in the renderArrow function:
var currentURL = window.location.href
... 'marker-end': "url(" + currentURL + "#arrowMarker)" ...
Not sure if its worth fixing for the limited cases, but thought I'd leave this here in case any one had a similar issue

+1 Also happening in angular apps.

Here is the fix for the angular app. This fix don't need source level changes,
		var steps = [
				{
					selector: '#selector',
					event: 'next',
					description: 'anything',
					onBeforeStart: addMarkerEnd,
					showNext: true
				}
                    ];

      // call back function to execute before the enjoy hint steps
			function addMarkerEnd() {
				var marker = '#enjoyhint_arrpw_line';
				// remove previous element
				angular.element(marker).remove();

				var path = $location.path();
				var url = 'url(' + path + '#arrowMarker)';

				var interval = $interval(function () {

					if (angular.element(marker).length > 0) {

						angular.element(marker).attr('marker-end', url);

						// cancel the interval
						$interval.cancel(interval);

					}

				}, 200);

			}

var currentURL = window.location.href
'marker-end': "url(" + currentURL + "#arrowMarker)"
It works perfectly in safari using Ionic 4 Angular 6.
Thanks


[BUG] Scratchpads do not appear in expected locations

Pyprland version
2.0.9-1-g310b15f
Describe the bug
Scratchpads spawn in unexpected positions, depending on the animation set. With fromRight and fromLeft, scratchpad spawns in same spot. No animation set is centered properly.
To Reproduce
Steps to reproduce the behavior:

Use provided pyprland.toml and bind a key to the volume scratchpad
Use any valid parameter from the wiki for the scratchpads.volume.animation field.
Activate bind.
See misaligned window. Screenshots provided at bottom of issue.

Expected behavior
Window is centered and "hugs" the specified wall of the monitor for each animation set. null produces a perfectly centered window.
Configuration (provide following files/samples when relevant):

pyprland.toml

[pyprland]
plugins = ["scratchpads"]

[scratchpads.volume]
animation = "fromRight"
command = "pavucontrol"
class = "pavucontrol"
size = "40% 80%"
unfocus = "hide"
lazy = true

hyprland.conf

#
# Please note not all available settings / options are set here.
# For a full list, see the wiki
#

#autogenerated = 1 # remove this line to remove the warning

# See https://wiki.hyprland.org/Configuring/Monitors/
monitor= eDP-1<EMAIL_ADDRESS>0x0, 1.00

# See https://wiki.hyprland.org/Configuring/Keywords/ for more

# Execute your favorite apps at launch
# exec-once = waybar & hyprpaper & firefox

# Add networkmanager applet to tray in waybar
exec-once = nm-applet --indicator

# Set keyboard layout
exec-once = .local/bin/garuda-locale.sh

# Set monitor values. For own values, please comment with #
exec-once = .local/bin/mon.sh

# Source a file (multi-file configs)
# source = ~/.config/hypr/myColors.conf

# For all categories, see https://wiki.hyprland.org/Configuring/Variables/
input {
kb_layout = us
    kb_variant =
    kb_model =
    kb_options = compose:ralt
    kb_rules =
    numlock_by_default= true
    follow_mouse = 1

touchpad {
    natural_scroll = true
    tap-to-click = true
    disable_while_typing = true
}

    sensitivity = 0 # -1.0 - 1.0, 0 means no modification.
}

general {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    gaps_in = 5
    gaps_out = 10
    border_size = 2
    col.active_border = rgba(de7dc4ee) rgba(8f00ffee) 45deg
    col.inactive_border = rgba(595959aa)

    layout = dwindle
}

decoration {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    rounding = 10
    blur {
       enabled = true
       size = 5
       passes = 1
    }

    drop_shadow = true
    shadow_range = 4
    shadow_render_power = 3
    col.shadow = rgba(1a1a1aee)
}

animations {
    enabled = true

    # Some default animations, see https://wiki.hyprland.org/Configuring/Animations/ for more

    bezier = myBezier, 0.05, 0.9, 0.1, 1.05

    animation = windows, 1, 7, myBezier
    animation = windowsOut, 1, 7, default, popin 80%
    animation = border, 1, 10, default
    animation = fade, 1, 7, default
    animation = workspaces, 1, 6, default
}

dwindle {
    # See https://wiki.hyprland.org/Configuring/Dwindle-Layout/ for more
    pseudotile = true # master switch for pseudotiling. Enabling is bound to mainMod + P in the keybinds section below
    preserve_split = true # you probably want this
}

master {
    # See https://wiki.hyprland.org/Configuring/Master-Layout/ for more
    new_is_master = true
}

gestures {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more
    workspace_swipe = on
}
misc {
	disable_hyprland_logo = true
}
# Example per-device config
# See https://wiki.hyprland.org/Configuring/Keywords/#executing for more
device {
	name = epic-mouse-v1
    sensitivity = -0.5
}

# Example windowrule v1
# windowrule = float, ^(kitty)$
# Example windowrule v2
# windowrulev2 = float,class:^(kitty)$,title:^(kitty)$
# See https://wiki.hyprland.org/Configuring/Window-Rules/ for more

# See https://wiki.hyprland.org/Configuring/Keywords/ for more
$mainMod = SUPER

# Example binds, see https://wiki.hyprland.org/Configuring/Binds/ for more
bind = $mainMod SHIFT, R, exec, hyprctl reload
bind = $mainMod, 36, exec, footclient
bind = $mainMod, T, exec, footclient
bind = $mainMod, Q, killactive,
bind = $mainMod SHIFT, E, exec, nwgbar
bind = $mainMod, N, exec, thunar
bind = $mainMod SHIFT, 65, togglefloating,
bind = $mainMod, D, exec, wofi --show drun --allow-images
bind = $mainMod SHIFT, D, exec, nwg-drawer
bind = $mainMod, P, pseudo, # dwindle
bind = $mainMod, J, togglesplit, # dwindle

# Mainmod + Function keys
bind = $mainMod, F1, exec, firedragon
bind = $mainMod, F2, exec, claws-mail
bind = $mainMod, F3, exec, thunar
bind = $mainMod, F4, exec, geany
bind = $mainMod, F5, exec, github-desktop
bind = $mainMod, F6, exec, gparted
bind = $mainMod, F7, exec, inkscape
bind = $mainMod, F8, exec, blender
bind = $mainMod, F9, exec, meld
bind = $mainMod, F10, exec, joplin-desktop
bind = $mainMod, F11, exec, snapper-tools
bind = $mainMod, F12, exec, galculator

# Move focus with mainMod + arrow keys
bind = $mainMod, left, movefocus, l
bind = $mainMod, right, movefocus, r
bind = $mainMod, up, movefocus, u
bind = $mainMod, down, movefocus, d

# Switch workspaces with mainMod + [0-9]
bind = $mainMod, 1, workspace, 1
bind = $mainMod, 2, workspace, 2
bind = $mainMod, 3, workspace, 3
bind = $mainMod, 4, workspace, 4
bind = $mainMod, 5, workspace, 5
bind = $mainMod, 6, workspace, 6
bind = $mainMod, 7, workspace, 7
bind = $mainMod, 8, workspace, 8
bind = $mainMod, 9, workspace, 9
bind = $mainMod, 0, workspace, 10

# Move to workspace with focused container with ALT + SHIFT + [0-9]
bind = ALT SHIFT, 1, movetoworkspace, 1
bind = ALT SHIFT, 2, movetoworkspace, 2
bind = ALT SHIFT, 3, movetoworkspace, 3
bind = ALT SHIFT, 4, movetoworkspace, 4
bind = ALT SHIFT, 5, movetoworkspace, 5
bind = ALT SHIFT, 6, movetoworkspace, 6
bind = ALT SHIFT, 7, movetoworkspace, 7
bind = ALT SHIFT, 8, movetoworkspace, 8
bind = ALT SHIFT, 9, movetoworkspace, 9
bind = ALT SHIFT, 0, movetoworkspace, 10

# Move active window to a workspace with mainMod + SHIFT + [0-9]
bind = $mainMod SHIFT, 1, movetoworkspacesilent, 1
bind = $mainMod SHIFT, 2, movetoworkspacesilent, 2
bind = $mainMod SHIFT, 3, movetoworkspacesilent, 3
bind = $mainMod SHIFT, 4, movetoworkspacesilent, 4
bind = $mainMod SHIFT, 5, movetoworkspacesilent, 5
bind = $mainMod SHIFT, 6, movetoworkspacesilent, 6
bind = $mainMod SHIFT, 7, movetoworkspacesilent, 7
bind = $mainMod SHIFT, 8, movetoworkspacesilent, 8
bind = $mainMod SHIFT, 9, movetoworkspacesilent, 9
bind = $mainMod SHIFT, 0, movetoworkspacesilent, 10

# Scroll through existing workspaces with mainMod + scroll
bind = $mainMod, mouse_down, workspace, e+1
bind = $mainMod, mouse_up, workspace, e-1

# Move/resize windows with mainMod + LMB/RMB and dragging
bindm = $mainMod, mouse:272, movewindow
bindm = $mainMod, mouse:273, resizewindow

#background
exec-once = wpaperd

#status bar
exec-once = waybar
layerrule = blur , waybar
layerrule = ignorezero , waybar

# set volume (laptops only and may or may not work on PCs)
bind = ,122, exec, pactl set-sink-volume @DEFAULT_SINK@ -5%
bind = ,123, exec, pactl set-sink-volume @DEFAULT_SINK@ +5%
bind = ,121, exec, pactl set-sink-volume @DEFAULT_SINK@ 0%
# other bindings
bind = $mainMod, O, exec, firedragon
bind = $mainMod, F, fullscreen
bind = $mainMod SHIFT, F, fakefullscreen
bind = ,232,exec,brightnessctl -c backlight set 5%-
bind = ,233,exec,brightnessctl -c backlight set +5%
bind = $mainMod SHIFT,C, exec, killall -9 wpaperd && wpaperd

# Screenshots:

# https://github.com/hyprwm/contrib/blob/main/grimblast/grimblast.1.scd
# Print: All outputs
# SHIFT+Print: Select area
# $mainMod+Print: Current window
# $mainMod+Shfit+Print: Current output

bind = ,Print, exec, grimblast save screen && notify-send Screenshot captured
bind = SHIFT, Print, exec, grimblast save area && notify-send Selected\ area captured
bind = $mainMod, Print, exec, grimblast save active && notify-send Active\ window captured
bind = $mainMod SHIFT, Print, exec, grimblast output active && notify-send Output captured

# for resizing window
# will switch to a submap called resize
bind=$mainMod,R,submap,resize

# will start a submap called "resize"
submap=resize

# sets repeatable binds for resizing the active window
binde=,right,resizeactive,10 0
binde=,left,resizeactive,-10 0
binde=,up,resizeactive,0 -10
binde=,down,resizeactive,0 10

# use reset to go back to the global submap
bind=,escape,submap,reset

# will reset the submap, meaning end the current one and return to the global one
submap=reset

# to move window
bind = $mainMod SHIFT,up, movewindow, u
bind = $mainMod SHIFT,down, movewindow, d
bind = $mainMod SHIFT,left, movewindow, l
bind = $mainMod SHIFT,right, movewindow, r

# other blurings
blurls = wofi
blurls = thunar
blurls = gedit
blurls = gtk-layer-shell # for nwg-drawer
blurls = catfish
# window rules
windowrule = opacity 0.85 override 0.85 override,^(thunar)$
windowrule = opacity 0.85 override 0.85 override,^(gedit)$
windowrule = opacity 0.85 override 0.85 override,^(catfish)$
#window rules with evaluation
windowrulev2 = opacity 0.85 0.85,floating:1

exec-once = mako
exec-once =/usr/lib/polkit-gnome/polkit-gnome-authentication-agent-1
exec-once = foot --server
# experimental(might work might won't)

#pre executions (under development)
exec-once=exec xrdb -load ~/.Xresources
exec-once=copyq
exec-once=wl-paste -t text --watch clipman store
exec-once=wl-clipboard-history -t

#video play paues bindings
bind=,172,exec,playerctl play-pause
bind=,171,exec,playerctl next
bind=,173,exec,playerctl previous

# Use gtk-settings
exec-once = apply-gsettings

# Let systemd have hyprland's instance sig
exec-once = dbus-update-activation-environment --systemd HYPRLAND_INSTANCE_SIGNATURE

# Start screen shading.
exec = hyprshade auto

# Pyprland time.
exec-once = pypr

bind = $mainMod,V,exec,pypr toggle volume

Additional context
Secondary monitor is plugged in for the following screenshots, but behavior still occurs while monitor is unplugged.
fromRight behavior:

fromLeft behavior:

edit: Posted wrong screenshot initially, correct screenshot is now present.
fromTop behavior:

fromBottom behavior:

null behavior:

Hm, this is unexpected, I use this type of configuration daily...

which Hyprland version are you using (eg hyprctl version) ?
can you provide the pypr logs to understand why the computation isn't correct ?

It looks a bit like the computations are done on a "tiny" monitor instead of the correct size... but I don't see a possible root cause yet.

Unfortunately this run isn't valid.
You had a "stale" pavucontrol started.
Check the errors about pavucontrol failing to start at the beginning... didn't it show in the notifications ?
Can you dump the logs again after ensuring you don't have any issue in the runtime (ideal would be a fresh start).
Tip: you can use pypr exit to cleanly exit and usually exit the scratchpad commands cleanly.

 Seems to be something only affecting the X coordinates computation.
Nothing obvious pops to me, I'll review the code checking for some mistakes regarding the position.
About that, if you use the "position" attribute, is it working as expected ? or is it also affected ?

Thanks @fdev31, seems "position" works as expected. Curiously enough, when I removed the "position" attribute after testing the scratchpad started working correctly with its default position.

If it doesn't happen again without complex operations (eg: reloading the config, restarting pypr without ensuring everything has been closed, etc...) you may chose to close this bug.
In case you see some anomaly that can be explained keep it open to provide more details on the same ticket.
Note: I screwed up a bit the pypr version command & associated git tags, it's still usable but doesn't display a nice version on releases... hope it doesn't confuse things.
Thank you.

Yeah, I'm not seeing anything new. I'll post an update here if I find anything new, but for now it seems the issue stopped as mysteriously as it started.


chore(main): release 5.0.1

:robot: I have created a release beep boop
5.0.1 (2024-08-04)
Bug Fixes

not being in insert mode when opening a dir from the command line (#321) (c44ad14)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v5.0.1
:sunflower:


[documents] clickable links in documents

related to #4368

https://github.com/dxos/dxos/pull/4890


Update dependencies

ampersand-state and ampersand-sync that use lodash.includes (vs. lodash.contains)

:shipit:

shipped as v7.2.2

+1

released as v5.0.2


potential bug in loading pipeline

there is a unnecessary comma in
        self.with_area = with_area,
which might cause the flag being always True.

Thank you for identifying this issue! I have fixed it.


Subtract with Overflow

Problem
icicle-emu/sleigh/sleigh-runtime/src/lib.rs:479:30: attempt to subtract with overflow
varnode_offset = parent_reg.size - varnode_offset - size;
Code:
/// Maps a SLEIGH register to an internal VarNode ID and offset.
    pub fn map_sleigh_reg(&self, offset: u32, size: u8) -> Option<(pcode::VarId, u8)> {
        let &(id, mut varnode_offset) = self.register_mapping.get(&offset)?;
        let parent_reg = &self.registers[id as usize];
        if self.big_endian {
            varnode_offset = parent_reg.size - varnode_offset - size;
        }
        Some((id, varnode_offset))
    }

Variables:
{name:(5497, 5500), size:4, offset:2060, ...}
offset: 2063
size: 4
varnode_offset: 3
id: 105
parent_reg.size: 4
The parent reg is sr3
Trace
rust_panic (@rust_panic:4) std::panicking::rust_panic_with_hook (@std::panicking::rust_panic_with_hook:147) std::panicking::begin_panic_handler::{{closure}} (@std::panicking::begin_panic_handler::{{closure}}:32) std::sys_common::backtrace::__rust_end_short_backtrace (@std::sys_common::backtrace::__rust_end_short_backtrace:5) rust_begin_unwind (@rust_begin_unwind:18) core::panicking::panic_fmt (@core::panicking::panic_fmt:13) core::panicking::panic (@core::panicking::panic:16) sleigh_runtime::SleighData::map_sleigh_reg (<omitted>/icicle-emu/sleigh/sleigh-runtime/src/lib.rs:479) icicle_cpu::cpu::Cpu::var_for_offset (<omitted>/icicle-emu/icicle-cpu/src/cpu.rs:351) <icicle_cpu::cpu::UncheckedExecutor as icicle_cpu::exec::interpreter::PcodeExecutor>::load_mem (<omitted>/icicle-emu/icicle-cpu/src/cpu.rs:585) icicle_cpu::exec::interpreter::load (<omitted>/icicle-emu/icicle-cpu/src/exec/interpreter.rs:629) icicle_cpu::exec::interpreter::interpret (<omitted>/icicle-emu/icicle-cpu/src/exec/interpreter.rs:500) icicle_cpu::cpu::Cpu::interpret_unchecked (<omitted>/icicle-emu/icicle-cpu/src/cpu.rs:454) icicle_jit::runtime::run_interpreter (<omitted>/icicle-emu/icicle-jit/src/runtime.rs:145) 555556D3808D (@555556d3808d..555556d3810d:3) icicle_vm::Vm::run_block_jit (<omitted>/icicle-emu/icicle-vm/src/lib.rs:497) icicle_vm::Vm::run (<omitted>/icicle-emu/icicle-vm/src/lib.rs:198)

This is caused by a register offset that crosses a register boundary.
e.g., The SLEIGH specification defines the registers something like:
0x800: +0  +1  +2  +3  +4  +5  +6  +7  ...
       [ sr0         ] [ sr1         ] ...

When we execute: [7c 60 25 26] "mfsrin r3,r4" with r4 = 0x20000000 we get: r3 = register[0x800 + 2] it results in the following access:
0x800: +0  +1  +2  +3  +4  +5  +6  +7  ...
       [ sr0         ] [ sr1         ] ...
               [0x800 + 2    ]

Which causes issues in Icicle because the execution model isolates all the accesses.
I think this is actually a partially a SLEIGH bug, since indexing into a partial register offset seems incorrect to me (since the PowerPC manual defines mfsrin rD,rB to be: rD <- SLB(rB[32-35])). The line here:
https://github.com/icicle-emu/ghidra/blob/50230050fa58bd40d5a96cab9c167fc55bc92a76/Ghidra/Processors/PowerPC/data/languages/ppc_instructions.sinc#L3039
Should probably be changed to:
	D = *[register]:4 ($(SEG_REGISTER_BASE)+(tmp*4));

(And in a couple of other places that do the same thing).
That said Icicle should avoid crashing in this scenario. While I could add support for reads that cross multiple register boundaries, I'm tempted to just make return an emulator exception in these cases instead.

I appreciate the diagnosis.  This is as much a learning experience about SLEIGH as it is about the emulator itself.
I agree, I don't know of a scenario where crossing a register boundary would be ok.  Throwing an exception makes sense.
I made the change to the slaspec to test and it worked out.
Much appreciated!


HTML export doesn't follow the user's chain of prompts

I've noticed that with an HTML export, it doesn't seem to follow the user's chain of prompts.
For example, I have exported a chat via HTML that says this is the very last message.
Image link: https://github.com/pionxzh/chatgpt-exporter/assets/5897898/a99aa5e8-8065-44b1-bb0e-b26230c653d5
Notice how it says "unease grew".
In ChatGPT itself, this was the 3rd regenerated output from ChatGPT, and there is no follow up to it.
Image link: https://github.com/pionxzh/chatgpt-exporter/assets/5897898/10363dba-29ff-40e1-bfe3-11d11c8e7de8
However, I ended up selecting output 1 and continued with the prompts from there. This is correctly captured in the JSON export, but not in the HTML one.
Image link: https://github.com/pionxzh/chatgpt-exporter/assets/5897898/2dd6accc-9a19-4e71-b8fc-09539f308fa0

What model and plugin were you using in the chat?
Can you try exporting text and markdown and see if they also show the wrong message chain (they actually share the same logic)

From the exported JSON, "model_slug": "text-davinci-002-render-sha", / ChatGPT 3.5
Using a markdown export, it does seem to follow the correct chain. I also retested exporting a chat as HTML and it does seem to follow the correct chain now, so the issue can be marked as closed.

Ok, thanks. Let me know if you see the issue again.


Lagging scroll value (Linux / X11)

On Linux, I noticed that the win->event.scroll value "lags" by 1 event. It seems that this is due to scroll direction being calculated based on win->event.button before it is actually assigned the new value (when I tried to move the win->event.button = E.xbutton.button; line before the switch(win->event.button) { case RGFW_mouseScrollUp: ... block, the odd behavior disappeared).

@dairin0d Thanks for filing this issue. It looks like I checked the value of win->event.button before it was checked rather than after. Thank you for pointing out the typo! This commit (https://github.com/ColleagueRiley/RGFW/commit/0e7985c1a7621fa14d2f7e45393c34cd00103d40) should fix it.

Yup, the fix works. Thanks!


oil: 0.7.pre3 -> 0.7.pre5

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Dup #70415. Thanks though!


Publish button text overlaps with icon in right-to-left

Bug Description
The Publish text in the button overlaps with the 'info' icon
Expected Behaviour
Icon in Publish button should be spaced away from the text
Steps to Reproduce

Open editor
Switch to RTL
Look at Publish button.

Screenshots

Additional Context

Plugin Version: 1.5.0
WordPress Version: 5.7
Operating System: macOSX Big Sur 11.2.2
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Hello @samwhale I wanna work on this issue.

Hello @samwhale I wanna work on this issue.

hi @Ayushsunny thanks so much for your interest in the project! This bug is actually getting taken care of already and isn't a great first issue (we mislabeled it). If you're interested in contributing, there are better first issues if you want to look further at our backlog.

Hello @samwhale I wanna work on this issue.

hi @Ayushsunny thanks so much for your interest in the project! This bug is actually getting taken care of already and isn't a great first issue (we mislabeled it). If you're interested in contributing, there are better first issues if you want to look further at our backlog.

okay Sir, Thanks

Fixed this while cleaning up PPC

Verified in QA


SDL2 wayland support appears broken

Issue description
SDL2 fails to build, complaining of a missing wayland header.  This in turn, breaks ffmpeg3, which breaks a whole host of other stuff.  @gnidorah, I'm guessing that your b0d193f596d is the culprit, just because it added the wayland flag to SDL2; that may not be correct, but I'm hoping you're at least in a good position to fix the issue.
Steps to reproduce
https://hydra.nixos.org/build/64495513/nixlog/1

Should be temporary fixed by https://github.com/NixOS/nixpkgs/commit/3772338be5b9ffbbc6b1b93bbd6ea052533a6180
Will see if it could be fixed in a bettery way. The error means that header is not yet generated from xml file at the stage it got requested.

The under-specified makefile dependency could be reported upstream.

Indeed. Reported upstream https://bugzilla.libsdl.org/show_bug.cgi?id=3977


Anatman and similar "channels" aren't being detected properly

I think there might be a way to check with the buff, working on a fix.

Resolved as of 66332ea, check MNK.lua updateLastCast() to see how it works, it's quite simple.


tell the user to press enter after parsing xpub in setup

prompt is blank so it felt like it crashed

Fixed, thank you for testing and the report.


Add directory for benchmarks

As I experiment with wall, I want to continue adding more benchmarks without cluttering the examples page, so I've built a small collection of benchmarks and a benchmark runner

Many Graphs
This is just the many-graphs benchmark that I added to example.ml, but extracted to be a standalone example, and with some modifications to fill the whole screen when the application is resized.
https://github.com/let-def/wall/assets/573215/f89146c0-5822-4bfb-9b44-762039422735
Lots of Text
This is a port of a text-rendering benchmark that I built for a hobby project https://lux.graphics/ (use the scroll-wheel to zoom in and out)
https://github.com/let-def/wall/assets/573215/c3befa40-3661-482b-b4a8-0cd1c1a87e09
Source Code
This demo uses walls own source-code to demonstrate how the ~placement parameter works
https://github.com/let-def/wall/assets/573215/9f4392a3-667f-4756-9fd5-9e669dc6696a

Thank you very much. And sorry that I didn't look at it earlier, this will be very helpful.
From a performance perspective for text rendering, glyphs are cached but not the layout yet. This would be a natural extension of the current "item caching" branch.

When I profiled one of these (many-graphs I think), I found that the program spent ~20% of CPU time converting between 64-bit floats to 32-bit floats to store in the bigarray.  This has me excited for Unboxed Types, and I think I'll be able to test Wall with a prototype compiler that supports unboxed 32-bit floats within the next month or two!


Update for changes to Arrow linkage in libcudf

With https://github.com/rapidsai/cudf/pull/16640, the libcudf library no longer links to arrow. While that dependency has been removed, the Java native code has not been updated to avoid arrow and still needs it for interop with arrow buffers (cudf now uses nanoarrow). While that may be removed in the future, for now the spark-rapids-jni needs to have its build updated to support the new location of arrow libraries and headers since they are now within the libcudfjni build instead of the libcudf build.
This PR depends on https://github.com/rapidsai/cudf/pull/16640, but will be required for spark-rapids-jni to build once that cudf PR is merged.

Build

Build

Thanks for confirming Jason. I've updated the branch and attempted to trigger a build although I suspect I won't have the power to do so.

build


Add test fakes

Things like context.trace should be easier to deal with in tests.

Closing this out in favor of #443


Optimize daily report to make less database calls

It currently checks the reply count for the day and finds the earliest reply per post, which is sub-optimal when we can instead do this.

This does currently include a reply object for each post, so it might lose on memory, but I'm not positive how to fix that and tell post_or_reply_link whether it's looking for a post or reply


Option"s" object - small typo

Hi, there is a small typo in the createChart method causing the options object not getting passed correctly.
I fixed it here:
https://github.com/s-oehding/vue-chart-js/commit/f2f121a4732b3d5c6ed8eb2a47ea6c36cbc4c5a2

Hi @s-oehding ,
Thanks for the PR, merged!


Catch Exceptions in Jobs

We cannot catch exceptions in jobs:

That's an IDE thing, if an exception was thrown from within GetUserByIdentifierJob, LoginUserOperation would still catch it, but the IDE doesn't know about it.
There is a plan to introduce an IntelliJ (PHPStorm) plugin that would solve these issues, it would also get the return type of the called unit (i.e. $user will be what the job will return and you'd be able to use autocomplete properly in your IDE).
Sorry for the inconvenience.
If you happen to know anything about writing IDE plugins, any help would be appreciated!


optarg cannot get properly

clang version 8.0.0 (tags/RELEASE_800/final) Target: aarch64-unknown-linux-android
ipgw -u1234
return error input.

in.c:21:53: warning:       result of comparison of constant -1 with       expression of type 'char' is always true       [-Wtautological-constant-out-of-range-compare]   ...(option = getopt(argc, argv, "hu:p:ov")) != -1) {      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
compile warning.

It's a c11 standard usage. The behavior of old compiler is undefined.


Segfault during execution

Whilst calling from PySR a segmentation fault is thrown.

The stack trace points to this line:
https://github.com/MilesCranmer/SymbolicRegression.jl/blob/c686d58175ecbc193c79a1d7a60f5aac3ece5931/src/SymbolicRegression.jl#L247
which is conspicuously marked @inbounds. So I'm suspecting, but cannot prove, that this is a bug in SymbolicRegression.jl. (Although in principle it could be a bug in Julia itself.)
I don't have a lot more to offer than that, I'm afraid. Obviously this occurs nondeterministically, and it's only happened once so far, so I don't know if I can reproduce it.

Julia 1.6.0-rc1
Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-65-generic x86_64)
PySR installed from GitHub master branch today.
pysr.pysr called with alpha=0.2, procs=16, populations=100, niterations=100, loss="L1DistLoss()", binary_operators=["plus", "mult", "sub"], unary_operators=["cos", "exp", "sin"]

Thanks, will try to think about this. I actually don't need the @inbounds there at all, since that loop is quite slow. Let me delete that and maybe if it gives the bug again it will be more helpful.

Sounds good. If I'm running this from PySR, how should I install the updated SymbolicRegression.jl? I've not dug into how PySR manages its Julia dependencies.

You can use a local copy of SymbolicRegression.jl with the PySR argument: julia_project="../SymbolicRegression.jl" to point to the root of the SymbolicRegression.jl repo. This lets you use the master branch copy! It's good for working on the backend but testing with the Python frontend.

Okay, looks like this is indeed a bounds error. A few of the arrays have (maxsize,) shape, so if an equation has too large a size, it will get a bounds error. The mutation functions are supposed to check whether or not the equation is too big, but it seems like the simplification (?) part is simplifying to a larger equation sometimes... Anyways I fixed this now! Will be in 0.5.3.
Also - I should add that the julia_project can point to any environment, rather than just the SymbolicRegression.jl repo. As long as the Manifest.toml file points to the right SymbolicRegression.jl version, it should be good to go with a local copy.

Closing this, let me know if this comes up again!


[HUDI-7144] Infer partition logically and use index to prune

Change Logs
Supports logical partitioning.

When using spark.write.partitionBy(partitionCol).format("hudi").options(...).save(basePath), write as a non-partitioned table.
Use index to prune the partitions.
Introduced a new table config and data source write options for the behavior change. It is false by default. We should turn it on by default in a future release.

Impact
Usability and storage.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Closing in favor of #10352


Updated the documentation to take care of few isseues I faced

using CMake as build tool has some quirks which are not documented
I have updated the documentation to reflect some of the issues I have encountered

hi @cerkiewny ,
Thx!


Support tx parameter overrides

This PR adds support for setting parameters to contract calls and deployments. These parameters are byte price, gas limit, and gas price for now.
It's done through a new method with_params() that's chained to the generated ABI method:
let result = contract_instance
        .initialize_counter(42) // Build the ABI call
        .with_params(Parameters::new(None, Some(1_000_000), None)) // <--- this here.
        .call() // Perform the network call
        .await
        .unwrap();

This doesn't break the way contract calls were made previously. i.e. initialize_counter(42).call(); (without .with_params()) works just like before and, also just like before, it will use default values for these parameters. If the user wants to override the default values, then they can chain with_params() to the method call.
However, this does break previous contract deployments, as the deployment method now requires these params to be set:
 let contract_id =
        Contract::deploy(&compiled, &provider, &wallet, Parameters::default())
            .await
            .unwrap();

Closes https://github.com/FuelLabs/fuels-rs/issues/138.

I'm not the biggest fan of the name with_params and Parameters. My initial reaction to .call().with_params() is that those are parameters for the call, not the transaction. Maybe .tx_params() and TxParameters?

Yeah, I wasn't attached to the with_params/params naming. Will update it soon.


backport run_exports

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Thanks Billy! 🙏
The re-rendering issues are the same ones we discussed recently ( https://github.com/conda-forge/conda-smithy/issues/2011 ). Michael started an upstream fix PR ( https://github.com/conda/conda-build/pull/5458 )
For now, would just do this locally using conda-build version 24.5 (any patch release should be fine)
Also in terms of CUDA 12.0, it looks like we updated to CUDA 12.1 in PR ( https://github.com/conda-forge/cuda-cupti-feedstock/pull/4 ). The commit right before that appears to be commit ( https://github.com/conda-forge/cuda-cupti-feedstock/commit/d1f990e47483b84e558efabbbdb02fc3f81b89b3 ). Would it be alright if we use that as the starting point for the v12.0 branch?

Also in terms of CUDA 12.0, it looks like we updated to CUDA 12.1 in PR ( https://github.com/conda-forge/cuda-cupti-feedstock/pull/4 ). The commit right before that appears to be commit ( https://github.com/conda-forge/cuda-cupti-feedstock/commit/d1f990e47483b84e558efabbbdb02fc3f81b89b3 ). Would it be alright if we use that as the starting point for the v12.0 branch?

Went ahead and made this change. Took the following steps:

Renamed the conda-forge branch v12.0 to v12.0-previous
GitHub automatically reflected that in this PR
Created a new v12.0 branch at commit: https://github.com/conda-forge/cuda-cupti-feedstock/commit/d1f990e47483b84e558efabbbdb02fc3f81b89b3
Retargeted this PR to the new v12.0 branch
Deleted the v12.0-previous branch

As the new v12.0 branch is merely a few commits ahead of the old one, it should be possible to fast-forward merge local v12.0 branches
This PR had a few commits that are now considered included in v12.0 ( namely those from the long since merged PR: https://github.com/conda-forge/cuda-cupti-feedstock/pull/4 ). After the change above this PR only shows the new changes that are not in v12.0. So after these changes this PR needs no updates
So this comment is merely informative. No action needed

It looks like Travis CI is failing on linux_ppc64le. Unfortunately this is a known issue that extends beyond this feedstock or conda-forge. For more context, please see issue: https://github.com/conda-forge/status/issues/185
As to resolving this, we had done some work in PR ( https://github.com/conda-forge/cuda-cupti-feedstock/pull/12 ) to switch to cross-compilation-based builds. Think we should backport that as well to fix CI
The {{ stdlib("c") }} issue mentioned by the linter above ( https://github.com/conda-forge/cuda-cupti-feedstock/pull/20#issuecomment-2289831494 ) was fixed in PR: https://github.com/conda-forge/cuda-cupti-feedstock/pull/13
So in short, think we should be backporting these 3 PRs here:

https://github.com/conda-forge/cuda-cupti-feedstock/pull/10
https://github.com/conda-forge/cuda-cupti-feedstock/pull/12
https://github.com/conda-forge/cuda-cupti-feedstock/pull/13

This should fix the CI issues and apply run_exports

@jakirkham thanks a million for all your help!

Happy to help Billy! Also thank you for working on this 🙏
Let's see what Alex thinks 🙂

Thanks Billy and Alex! 🙏


digital signature dual verification is not robust

There might be small chance that the digital signature is same before and after swap.
For example: digital signature is 0xABCDDCBA.
Then we cannot distinguish little endian or big endian.
We need to skip endianness assignment in this case.

Similar issue https://github.com/DMTF/libspdm/issues/2393


Dark-mode-profile

[FEATURE] Implement darkmode functionality in /profile route #52
has been added.
Little bit of code cleaning

[FEATURE] Implement darkmode functionality in /profile route [FEATURE] Implement darkmode functionality in /profile route #52
has been added.
Little bit of code cleaning

hey there are many conflicts we cannot merge the pr i am closing this update your code take a pull then create a new pr, do not do code clean up we will do it just make the required changes, also make the card bg also dark make it suitable

sure


Apply Checkbox style property to internal .check

This will allow you to override the styles of the visible check element
instead of the hidden input element.
This fixes #791.

Thank you!


[MINOR][SS]Remove duplicate 'add' in comment of StructuredSessionization.

What changes were proposed in this pull request?
StructuredSessionization comment contains duplicate 'add', I think it should be changed.
How was this patch tested?
Exists UT.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10616/
Test PASSed.

Test build #105347 has started for PR 24589 at commit f742f82.

Test build #105347 has finished for PR 24589 at commit f742f82.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105347/
Test PASSed.

It's fine. but mind taking another look and see if there are some more typos to fix? I am sure there are more.

It's fine. but mind taking another look and see if there are some more typos to fix? I am sure there are more.

Thank you. I found another two typos, but I'm not sure.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10636/
Test PASSed.

Test build #105371 has started for PR 24589 at commit 2d1c9f6.

Test build #105371 has finished for PR 24589 at commit 2d1c9f6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105371/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10641/
Test PASSed.

Test build #105378 has started for PR 24589 at commit c6f3aab.

Test build #105378 has finished for PR 24589 at commit c6f3aab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105378/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10666/
Test PASSed.

Test build #105403 has started for PR 24589 at commit e1f5039.

Test build #105403 has finished for PR 24589 at commit e1f5039.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105403/
Test PASSed.

Merged to master, branch-2.4 and branch-2.3

@HyukjinKwon @srowen Thanks all your help! @gaborgsomogyi @HeartSaVioR Thanks all your review.


Coerce dictionaries for arithmetic

Which issue does this PR close?

Closes #.
Rationale for this change

The support for arithmetic on dictionaries is inconsistent, results in a huge amount of code gen, and doesn't yield significant performance savings. There is an upstream PR proposing removing this functionality - https://github.com/apache/arrow-rs/pull/4407
In particular as far as I can tell the current logic has the following behaviour:

Dictionary + Dictionary => Non-Dictionary (or error if feature not enabled)
Dictionary + Scalar Dictionary => Dictionary
Dictionary + Non-Dictionary => Dictionary
Non-Dictionary + Dictionary => Non-Dictionary

By coercing the dictionaries we can avoid all this complexity, and provide a more consistent user experience
As an aside it is unclear why you would ever use a primitive dictionary, they will almost always be slower to process and especially once you factor in dictionary sparsity, may be significantly larger
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

The support for arithmetic on dictionaries is inconsistent, results in a huge amount of code gen, and doesn't yield significant performance savings. There is an upstream PR proposing removing this functionality - https://github.com/apache/arrow-rs/pull/4407

Do we have any numbers that illustrate this claim?

As an aside it is unclear why you would ever use a primitive dictionary, they will almost always be slower to process and especially once you factor in dictionary sparsity, may be significantly larger

I think @viirya added this feature so perhaps he could answer

Do we have any numbers that illustrate this claim?

They are on the linked ticket - https://github.com/apache/arrow-rs/pull/4407

As an aside it is unclear why you would ever use a primitive dictionary, they will almost always be slower to process and especially once you factor in dictionary sparsity, may be significantly larger
I think @viirya added this feature so perhaps he has more context

Hmm, I don't get the question. For the dictionary behavior, it follows original behavior. It basically follows kernel behavior too.  Previously I cleaned up the decimal type part, but for dictionary behavior, I think it is unchanged.
I think for dictionary, it still has storage advantage in memory and disk (e.g. shuffle), otherwise it has no reason to have it. It might be true that dictionary is slower to process in computation kernel, but for overall cost I'm not sure it is always a win to get rid of dictionary. Except we have something that can automatically detect dictionary sparsity and convert to dictionary before outputting to storage.

I think this change makes sense, but I defer to @viirya  -- if he is ok with it in principle I will review the PR carefully

I think I agree with this can largely reduce code complexity. My little concern might be if this is a clear win? Or it is probably a win for some cases but not for all? Dictionary process might be slower for some cases, but for some I think it might be faster, e.g., dictionary + scalar which I remember is directly computing on dictionary values. Not to mention there is extra coercion (casting) operation.
Also I'm not sure about selection kernels, do we have them in DataFusion?
I guess I'm okay with this (+0?), but we might need to look at performance impact if any.

but we might need to look at performance impact if any.

The benchmarks on https://github.com/apache/arrow-rs/pull/4407 show that for the wrapping addition used by DataFusion casting first is faster than the logic for operating on the dictionary. It should be noted this is in part because of the inefficiency of the current way this is implemented in arrow-rs, with the checked kernel variant performing better, however, as DataFusion does not use this, the change in this PR should result in a performance improvement for DF.
However, consistency is imo the biggest justification for this change, aside from the issues with arithmetic on dictionaries not supporting the full set of types (e.g. temporal), the coercion behaviour is rather inconsistent. In particular if the left argument is a dictionary and the right argument is not both will be coerced to a dictionary and a dictionary kernel used, in all other cases both arguments will be coerced to primitives. This makes me think it unlikely this code is actually being used in practice.
❯ create table foo as select (arrow_cast('1', 'Dictionary(Int32, Int32)')) as foo;
0 rows in set. Query took 0.003 seconds.
❯ select arrow_typeof(foo) from foo;
+--------------------------+
| arrow_typeof(foo.foo)    |
+--------------------------+
| Dictionary(Int32, Int32) |
+--------------------------+
1 row in set. Query took 0.002 seconds.
❯ explain select foo / 23 from foo;
+---------------+-------------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+-------------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: CAST(foo.foo AS Dictionary(Int32, Int64)) / Dictionary(Int32, Int64(23)) AS foo.foo / Int64(23) |
|               |   TableScan: foo projection=[foo]                                                                           |
| physical_plan | ProjectionExec: expr=[CAST(foo@0 AS Dictionary(Int32, Int64)) / 23 as foo.foo / Int64(23)]                  |
|               |   MemoryExec: partitions=1, partition_sizes=[1]                                                             |
|               |                                                                                |
+---------------+-------------------------------------------------------------------------------------------------------------+
2 rows in set. Query took 0.004 seconds.
❯ explain select foo / foo from foo;
+---------------+-------------------------------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+-------------------------------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: CAST(foo.foo AS Int32) AS foo.foo AS foo.foo AS foo.foo / CAST(foo.foo AS Int32) AS foo.foo AS foo.foo AS foo.foo |
|               |   TableScan: foo projection=[foo]                                                                                |
| physical_plan | ProjectionExec: expr=[CAST(foo@0 AS Int32) / CAST(foo@0 AS Int32) as foo.foo / foo.foo]                                       |
|               |   MemoryExec: partitions=1, partition_sizes=[1]                                                                               |
|               |                                                                                |
+---------------+-------------------------------------------------------------------------------------------------------------------------------+
2 rows in set. Query took 0.006 seconds.

Therefore since this PR still supports the calculation (via casting to primitive and calling the primitive kernels) I think it doesn't undo any of that work

Yea, it just casts to primitive before arithmetic operations so dictionary arrays are still going through them. From end-to-end perspective, it might be not noticeable if you don't look at the output array type.

The benchmarks on https://github.com/apache/arrow-rs/pull/4407 show that for the wrapping addition used by DataFusion casting first is faster than the logic for operating on the dictionary ..., the change in this PR should result in a performance improvement for DF.

For performance, I'd talk more about end-to-end query benchmark instead of kernel benchmark only. Arithmetic operations are only small pieces in the query execution time (ms/s v.s. minute/hour), I think. We will also do benchmark on new DataFusion release when we are going to upgrade internal integration.

but also possible impact to other operations in the query engine

To clarify this PR does not alter the return type of the evaluation, the output will still always be primitive. I therefore don't foresee this having downstream implications.
This PR only changes the way that DF evaluates dictionary op primitive. Now instead of coercing the arguments to dictionaries it coerces them to primitives. This is now consistent with the existing behaviour for all other combinations of dictionaries and primitives,  dictionary op dictionary, primitive op dictionary and primitive op primitive, which coerce to primitives on main.


Linter Rule Wishlist

This issue is intended to track the various linter rules, based on API conventions and API reviewer experience, that we wish to implement within KAL

[x] commentstart - Godoc for fields within structs should start with the serialised JSON tag name
[x] jsontags - Each field should have a json tag, and the field name should be camelCase
[x] optionalorrequired - Each field should have either an optional, or a required marker
[ ] [#2] statussubresource - (CRD - not default) If a struct is marked as // +kubebuilder:object:root=true and contains a status field, it should also have // +kubebuilder:subresource:status
[ ] (@JoelSpeed) conditions

Should be the first item in the struct (general idiom - configuration to disable)
Should have +listType=map, +listMapKey=type, +patchStrategy=merge, +patchMergeKey=type and +optional
Tag should match json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"

This is true for built-ins, but not for CRDs, should be configurable to allow skipping patchStrategy and protobuf

[ ] [#5] nophase - phase fields are deprecated and conditions should be preferred, avoid phase like enum fields
[ ] nomaps - No maps of subobjects should be allowed, allow map[string]string] as this is used for labels, prefer lists of subobjects with names/ids
[ ] enums - Enumerated fields should use type aliases with +enum

TODO: Uncertain about how this plays into CRDs, need to understand this first
TODO: Check origin of this, what is the alternative
Enum values should be PascalCase
Allow exceptions for command-line executable where the proper name is consistent - configurable allowlist

[ ] numericbounds - All numeric fields should be bounds checked, both for too-small or negative, and for too-large

TODO: How is this checked in a built-in type? Is there a marker?
int64 must be -(2^53) < x < (2^53) or should be represented as a string (javascript float overflows otherwise)

[ ] integers

No int, use int32 or int64, prefer int32 unless explicitly needed (check bounds and suggest int32)
No unsigned integers, validate non-negative integer

[ ] nofloats - Floating point values should be avoided as much as possible, never in spec, cannot be reliably round-tripped.
[ ] nobools - (Strong opinion - not on by default) - They don't age well, should be enum instead.
[ ] (@JoelSpeed) discriminatedunions - Identify structs marked with +union

Should have 1 required field with +uniondiscriminator
Other fields should be optional and marked with +unionMember or +unionMember,optional
For CRDs, should have a CEL validation rule has(self.<discriminator> && self.<discriminator> == "<member>" ? has(self.member) : !has(self.member) or equivalent if the member is optional
Should not have non-member fields present (strong opinion, so, configurable)

[ ] optionalfields - @JoelSpeed disagrees with some of the conventions in upstream here, will need to discuss with upstream, below are what I think we should have. Pattern that lead to exceptions around optional fields seems discouraged now.

Should have omitempty (will need to toggle this, or somehow allow exceptions)
If field is a struct, and has omitempty, field must a pointer (json can't omit refs to structs)
Should not use pointer for maps and slices (difference between 0 length and omitted is likely an anti-pattern?)
For strings, if not a pointer, must have a minLength (0 length would be omitted on a round trip)
Require all optional fields be points (would like to toggle this, we don't enforce in OpenShift)

[x] [#3] requiredfields

Do not have omitempty
Are not pointers

[ ] defaults

Should not use +kubebuilder:default and prefer upstream marker
Allow preferred marker, per optionalorrequired

[ ] Marker typos - Check for common typos (eg some markers seem to require = and some require := (more research required
[ ] nodurations - Durations should be avoided and should instead use fooSeconds, avoids having to implement go duration parsing
[ ] references - Fields should use Ref/Refs and not Reference/References

For OpenShift, should not include Ref/Refs - a configuration option

[ ] timestamps - Do not use stamp in field names, eg fooTimestamp, use fooTime instead
[ ] nameformats - (CRD - not default) Common fields like name and namespace should be validated with CEL to match DNS1123 subdomain and label respectively

Thinking also about the idea of presets (golangci-lint has these) where you could select a preset config for Kubernetes, CRD, OpenShift or others in the future if they have variations. The presets would configure different defaults for the configuration, e.g. setting which linters are on by default, and where there are variations in individual rule config, setting those defaults as well

@JoelSpeed Just a note that you can spin all the checklist items into individual issues pretty easily with a little icon to the right of each entry. Might be easier to co-ordinate by assigning individual issues that map to each desired linter?


az monitor autoscale rule create bugs and missing config fields

Overview
3 Issues Discovered.

Autoscale direction when using 'to'

https://github.com/Azure/azure-cli/blob/1fec5c4e721d2313e91c15a5ba542025759131d6/src/azure-cli/azure/cli/command_modules/monitor/util.py#L53
When you use --scale to X in az monitor autoscale rule create it sets the direction to None. This breaks the autoscale rule.
FYI - when creating the same 'to X' rule in the portal this populates the direction correctly with either an 'Increase' or 'Decrease' depending on the other rules in the profile.

dividePerInstance option and parameter is missing
Additionally, the dividePerInstance field is missing from the autoscale rule cli template as seen here and is a critical missing component (it just seems to get defaulted to true at the moment which breaks my scaling rule needs!). This is populated and available when creating a rule in the portal:

https://github.com/Azure/azure-cli/blob/1fec5c4e721d2313e91c15a5ba542025759131d6/src/azure-cli/azure/cli/command_modules/monitor/operations/autoscale-parameters-template.json#L15
These are both broken/missing features.
[Referencing this previous issue:]
#https://github.com/Azure/azure-cli/issues/16027#issue-749669485
EDIT Found another issue
3. 'az monitor autoscale create' is not idempotent and will wipe all the existing profiles and rules if run again. This kind of makes it a bit useless to be honest as it would wipe profiles and other rules for the autoscale setting in other deployments each time. A check for if it already exists needs to be implemented to make it more in line with the other az commands and patterns.

monitor

Hi,@DanoThom  ,in az monitor autoscale rule create it sets the direction to None, it is just a temporary setting, and it will be processed later. You can refer to the following code to see if the subsequent operation meets your expectations
https://github.com/Azure/azure-cli/blob/58ff25ffb12db1067c4d23437af5b7f32d038e1e/src/azure-cli/azure/cli/command_modules/monitor/actions.py#L292-L318
https://github.com/Azure/azure-cli/blob/58ff25ffb12db1067c4d23437af5b7f32d038e1e/src/azure-cli/azure/cli/command_modules/monitor/operations/autoscale_settings.py#L304-L356


npm run build-minified fails

No idea why it's doing this, any help would be highly appreciated.

 Seem to be unable to find the dependency webpack.

Yep, ran that and everything seemed to be working.

Fixed it. One of the files was missing, no idea how I managed that.


x/tools/gopls: ignore vendor directories when running diagnostics

See the end of https://github.com/microsoft/vscode-go/issues/3110 for some discussion. Vendor directories populated after running go mod vendor overwhelm gopls when they create a large number of packages that we consider "part of the workspace".
We need to watch the vendor directory for file changes, but we shouldn't consider packages in vendor directories to be workspace packages, and therefore, we shouldn't offer any diagnostics for them. To me, this seems as simple as ignoring any packages whose directories are prefixed with vendor, but I imagine it's not that simple. @heschik: What do you think / does this approach sound reasonable?

In module mode, it's guaranteed to be module root + /vendor. In GOPATH mode they could be anywhere, and also the user might want to edit them, so it's not obvious to me that they shouldn't be workspace packages. But certainly we can start with module mode.
I think we've also discussed debouncing file change events, which would probably be relevant to the go mod vendor case?

In module mode, it's guaranteed to be module root + /vendor. In GOPATH mode they could be anywhere, and also the user might want to edit them, so it's not obvious to me that they shouldn't be workspace packages. But certainly we can start with module mode.

Sounds reasonable. I'll work on this fix soon.

I think we've also discussed debouncing file change events, which would probably be relevant to the go mod vendor case?

In this case, I noticed that VS Code sends one batched didChangeWatchedFiles with all of the changes, so it's actually not a big deal for gopls to handle. The slow part really seemed to be all of the go list calls we start making to diagnose the workspace packages.


Spiegel.tv Could not connect to RTMP server

When trying to download any video from spiegel.tv, it is not working anymore.
I can take any video, but as an example: http://www.spiegel.tv/filme/dbate-videotagebuch-kiffen-mein-rausch/
[Spiegeltv] dbate-videotagebuch-kiffen-mein-rausch: Downloading webpage
[Spiegeltv] dbate-videotagebuch-kiffen-mein-rausch: Downloading version information
[Spiegeltv] dbate-videotagebuch-kiffen-mein-rausch: Downloading object information
[Spiegeltv] dbate-videotagebuch-kiffen-mein-rausch: Downloading media information
[Spiegeltv] dbate-videotagebuch-kiffen-mein-rausch: Downloading server information
[download] Destination: Mein Rausch-dbate-videotagebuch-kiffen-mein-rausch.m4v
ERROR: [rtmpdump] Could not connect to RTMP server.

A few days ago it was still working.
I tried it on two machines, both archlinux. Same result.

Same here with youtube-dl http://www.spiegel.tv/filme/alleskino-metalhead

Thanks to @brickleroux (see https://github.com/rg3/youtube-dl/issues/5843#issuecomment-106963621), this problem will be fixed in the next version.

Thanks


Support HAR dumping example script in standalone binaries

Steps to reproduce the problem:

Try to run har_dump.py example with standalone mitmdump binary:

mitmdump -s "examples/complex/har_dump.py /tmp/out.har"
Loading script: examples/complex/har_dump.py /tmp/out.har
Script error: Traceback (most recent call last):
File "examples/complex/har_dump.py", line 12, in <module>
import pytz
ImportError: No module named 'pytz'

Proxy server listening at http://<IP_ADDRESS>:8080

Any other comments? What have you tried so far?
I realize that har_dump.py is currently only an example script. However, it would be nice if it worked with the standalone binaries until/if you integrate it into the core of mitmproxy.
I have been able to resolve this by rebuilding locally with a couple of small edits:
> sudo apt-get install python3-pip python3-dev libffi-dev libssl-dev libtiff5-dev libjpeg8-dev zlib1g-dev libwebp-dev
> git clone https://github.com/mitmproxy/mitmproxy.git
> cd mitmproxy
> git checkout tags/v1.0.2
(edit two files)
> git diff
diff --git a/release/specs/mitmdump b/release/specs/mitmdump
index 0aeac3c8..fd103525 100644
--- a/release/specs/mitmdump
+++ b/release/specs/mitmdump
@@ -1,3 +1,4 @@
#!/usr/bin/env python
from mitmproxy.tools.main import mitmdump
+import pytz
mitmdump()
diff --git a/setup.py b/setup.py
index fa20e7cf..caf703f9 100644
--- a/setup.py
+++ b/setup.py
@@ -52,7 +52,7 @@ setup(
entry_points={
'console_scripts': [
"mitmproxy = mitmproxy.tools.main:mitmproxy",
- "mitmdump = mitmproxy.tools.main:mitmdump",
+ "mitmdump = mitmproxy.tools.main:mitmdump [examples]",
"mitmweb = mitmproxy.tools.main:mitmweb",
"pathod = pathod.pathod_cmdline:go_pathod",
"pathoc = pathod.pathoc_cmdline:go_pathoc"
> ./dev.sh
> . venv3.5/bin/activate
> tox -e rtool -- bdist
> deactivate
> ls -lh release/build/binaries/linux/

I don't think this is the correct fix. Ideally I would like to be able to tell pyinstaller about all of the "examples" dependencies for mitmdump specified in the root setup.py.
Do you have any suggestions about how this could be achieved? That would be one small step towards making HAR dumping better supported by the next release of mitmproxy (see: https://github.com/mitmproxy/mitmproxy/issues/1477 ).
System information
I'm on Ubuntu 16.04 using mitmdump 1.0.2:
> mitmdump --version
mitmdump 1.0.2

Thanks for the report. That's a reasonable but generally tricky request. For example, we just ditched Pillow in mitmproxy (it's now in examples only) which reduces our binary size by 20%. I'd be opposed to adding this again just to have the example work. Then again, har_dumper might just be important enough to warrant a special case. Ideally we could just replace pytz with something that's builtin (I haven't checked how feasible that'd be).

pytz is only needed for the following line of code:
def format_datetime(dt):
    return dt.replace(tzinfo=pytz.timezone("UTC")).isoformat()

Yes, I guess there are ways to replace this with something from stdlib.

I think the following trivial change will allow the removal of the pytz dependency. Before:
def format_datetime(dt):
    return dt.replace(tzinfo=pytz.timezone("UTC")).isoformat()

After:
def format_datetime(dt):
    return dt.replace(tzinfo=timezone.utc).isoformat()

@mchr3k: Thanks. Would you like to submit a PR for this? :smiley:

@mchr3k Do you want to submit a PR? Otherwise I have the fix ready
Also, we can get rid of the function completely by doing
datetime.fromtimestamp(timestamp, timezone.utc).isoformat()

I'm happy for you to push the fix if you have it ready 😊

On 23 Feb 2017, at 13:44, Ujjwal Verma<EMAIL_ADDRESS>wrote:
@mchr3k Do you want to submit a PR? Otherwise I have the fix ready
Also, we can get rid of the function completely by doing
datetime.fromtimestamp(timestamp, timezone.utc).isoformat()
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


fix: remaining budget display

Link this PR to an issue
Fixes #ISSUE-NUMBER
@bumi from our pairing. I can't seem to find the PR number/
Type of change (Remove other not matching type)

Bug fix (non-breaking change which fixes an issue)

Describe the changes you have made in this PR -
Fix displaying and calculating remaining budget for Allowances
Screenshots of the changes (If any) -
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

Should wait for https://github.com/getAlby/lightning-browser-extension/pull/1046

This is now:

improving tests
improving UX by using a form for the modal (send "on enter" works)
improving type


Value of QNAN

A quiet NAN is denoted by setting all the exponent bits, i.e. bits 53-63, and the highest mantissa bit, i.e. bit 52. Then shouldn't it look like 0 111 1111 1111 1000 [rest], i.e. 0x7ff8000000000000?
In wren_value.h it is set to 0x7ffc000000000000 i.e. 0 111 1111 1111 1100 [rest]. Can someone explain why?

This is because the math functions return quiet NAN when applicable, and without the extra set bit, actual QNAN and our masked type would be indistinguishable by the comparsion ((value & QNAN) != QNAN). Hence a QNAN returned by the math functions would be treated as a masked type, and bad things will start to happen.


Contact page

i will also make a js file for this, do you have an email where the messages should will be sent to?

Hey! So I already have a contact page from my old website that I am going to be porting to here, so I will update you when I do that.

kk


Python 2.x permits comparison between Money and string

In Python 2.x you can compare numeric and non-numeric types. This means you can do:
>>> Money('3', 'GBP') > '50'
False

which can lead to confusing situations (e.g., accidentally forgotten to deserialise the '50' to a numeric value). It seems to me that this situation should be rejected in Python 2.x. In Python 3.x the above leads to a TypeError:
>>> Money('3', 'GBP') > '50'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/svisser/.virtualenvs/test3/lib/python3.4/site-packages/money/money.py", line 75, in __gt__
    return self.amount > other
TypeError: unorderable types: decimal.Decimal() > str()

Thanks for reporting this Simeon. After some pondering I'm actually deprecating the direct comparison between Money and non-Money objects in favor of an equally simple and more explicit m.amount > 50, with its "natural" Python quirks. 075c65817d339d9364724f124a2fc4b05d11e14c
Check out the note on the README: https://github.com/carlospalol/money#differences-between-python-versions


test: pkg/processor

Signed-off-by: Shubham Gupta<EMAIL_ADDRESS>Explanation

Related issue
https://github.com/kyverno/chainsaw/issues/556

Proposed Changes

Checklist

[x] I have read the contributing guidelines.
[x] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
[x] This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

@eddycharly ptal


Not Effect After Sign

I set config  below and passed well.
const sign = require('electron-osx-sign');
sign({
      app: path.join(cwd, './release/xxx.app'),
      entitlements: path.join(__dirname, './parent.plist'),
      'entitlements-inherit': path.join(__dirname, './child.plist'),
      'identity': 'Mac Developer: Xiaofeng Mao (52D7B5F3L7)',
      'platform': 'darwin',
      'version': config.version,
    }, (error) => {
      if (!error) {
        console.log('signed success');
    }
});

print signed success until i checked my app by spctl -a -v xxx.app
result is xxx.app: rejected
tried many times and exhausted. please give me some tips~

exec security find-identity
print
 5) 4EE8B3B97DD276EFDC400EA8C10A588ECEBA72D6 "Mac Developer: Xiaofeng Mao (52D7B5F3L7)"
     5 identities found

Hi @carlos121493 thanks for filing this issue!
Would you like to try signing again with a Developer ID Application certificate (generated from Apple Developer), which is not found in your list of available identities, as it should pass Gatekeeper better?

@sethlu Thanks a lot, I got a low level certificate. changed To Developer ID Application certificate, Everythings done well!

Glad to know! Let us know as well if you have any additional questions on code signing.

hello i just do what @carlos121493  does, but i always receive this error... (im using Developer ID Application Certificate)
electron-osx-sign "eRadioEdicion.app" --platform=darwin --type=development --identity="electron-osx-sign "eRadioEdicion.app" --platform=darwin --type=development --identity="xxxx"
Sign failed:
Command failed: codesign --sign 501C82D8E32AEE50A17471357C9329BCDD345011 --force eRadioEdicion.app/Contents/Resources/app/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework
eRadioEdicion.app/Contents/Resources/app/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework: bundle format is ambiguous (could be app or framework)"

Hi @cinder92, I would recommend checking out https://github.com/electron-userland/electron-osx-sign/issues/138#issuecomment-308217860.


Update Yoga import

I've proposed a change in the name of Yoga podspec to prevent a naming conflict when using YogaKit.
React Native PR: https://github.com/facebook/react-native/pull/20758
If, or, when that is merged, this documentation change is necessary

Closing as stated in https://github.com/facebook/react-native/pull/20758#issuecomment-480004432.