Debug Failure. Did not expect PropertyDeclaration to have an Identifier in its trivia

We can see via telemetry this happens a fair amount. The invalid parse tree indicated by this assertion may be the root cause of a VS crash @uniqueiniquity was investigating, but we haven’t been able to reproduce. Posting this issue in the hopes that someone will search for this and provide us with more clues.
(Note: I’m specifically interested in PropertyDeclaration errors—this happens more often with JSX-related nodes.)
Debug Failure. Did not expect PropertyDeclaration to have an Identifier in its trivia
        at addSyntheticNodes (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:117479:30)
        at processNode (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:117452:13)
        at Object.forEach (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:207:30)
        at createChildren (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:117462:12)
        at NodeObject.getChildren (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:117412:56)
        at getTokenAtPositionWorker (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:93879:43)
        at Object.getTokenAtPosition (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:93871:16)
        at Object.getCodeActions (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:113197:32)
        at C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:109567:121
        at Object.flatMap (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:488:25)
        at Object.getFixes (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:109567:23)
        at C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:118771:35
        at Object.flatMap (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:488:25)
        at Object.getCodeFixesAtPosition (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:118769:23)
        at IOSession.Session.getCodeFixes (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:126922:64)
        at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:125730:61)
        at C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:127091:88
        at IOSession.Session.executeWithRequestId (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:127082:28)
        at IOSession.Session.executeCommand (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:127091:33)
        at IOSession.Session.onMessage (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:127113:35)
        at Interface.<anonymous> (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.3\tsserver.js:128374:27)
        at Interface.emit (events.js:182:13)
        at Interface._onLine (readline.js:290:10)
        at Interface._normalWrite (readline.js:433:12)
        at Socket.ondata (readline.js:149:10)
        at Socket.emit (events.js:182:13)
        at addChunk (_stream_readable.js:283:12)
        at readableAddChunk (_stream_readable.js:264:11)
        at Socket.Readable.push (_stream_readable.js:219:10)
        at Pipe.onread (net.js:638:20)

FWIW there's https://github.com/microsoft/TypeScript/issues/44154 if that gives you any clues.

I don’t think anything JSX-related helps with this one.


Add "quick diff" support with hash digest comparisons

Likely not necessary in light of Just van Rossum's fbdiff tool.  Closing


svg path color override

Problem: On mobile the gradient color was present and not on desktop
Certain svg paths contain gradients this will ensure that there will be an override and it will be solid orange for the fill color

After:

Before:

I can't approve these changes, but tested it locally and looks good to me.


Adds CMT31 (Boreal Bog) parameterization

This does not include any of the methane-related fluxes that were originally calculated at the same time.

I was hoping to use the csv conversion to avoid the tedium of updating all of the lines by hand, but I will go ahead and do that later.

I think that the csv conversion will require that the names have semi colons after them, but none of the other fields need to exist. I will experiment here and see...

Yes after some testing, I confirmed that some of the param_util.py functions choke on the missing ':' after the variable names. Also the fire file needs to have the variable:name for all the parameters; copy the formatting from one of the other parameter sets, I think I changed the names slightly
For ref, the test command lines that failed were:
for f in $(ls parameters/); do echo $f; ./scripts/param_util.py --reformat-block parameters/$f 31; echo ""; done

And
./scripts/param_util.py --fwt2csv-v1 parameters/ 31 calibration/calibration_targets.py

Both fails on:

cmt_dimvegetation.txt
cmt_firepar.txt


Add 1.20.5 changelog

I thought I would see https://github.com/go-gitea/gitea/pull/27104 mentioned in the 1.20.5 changelog, but looks like it has not been backported yet.

I thought I would see #27104 mentioned in the 1.20.5 changelog, but looks like it has not been backported yet.

#27406


⚠ Samsung has degraded performance

In f5c7475, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2566 ms

Resolved: Samsung performance has improved in b7a9fde.


[1pt] Create app and install basic dependencies - Setup (group task)

Create React App.
Install React Redux, Redux Logger and React Router.

Hi
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request
You have submitted a project, that has no following info in the issue description:

link to your GitHub project
information about the number of people in their group

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


parse.typed(...) or some kind of typed parse method

It'd be nice to have zod help the developer max out their chances of parsing a valid object, when it's manually constructed. Example:
const User = z.object({
  name: z.string().regex(/^\w+ \w+$/),
  age: z.number(),
})

User.parse({
  name: 'Bob',
  birthdate: new Date('1970-01-01'),
})

The above code compiles, but we have enough information to know that it'll throw a ZodError at runtime. It'd be nice if there was a method like
User.parse.typed({
  name: 'Bob',
  birthdate: new Date('1970-01-01'),
})

Where the expected input type was Input (from the ZodType<Output, Def, Input>) rather than unknown. So the above code would error because the developer used birthdate instead of age.
This would be especially useful for types with a custom .refine or .regex method or similar where it could be misleading to use just a type declaration:
const user: z.infer<typeof User> = {
  name: "Robert'; -- DROP TABLE Students; --"
  age: 40,
}

The above will compile, and implies that the const user is a validated User instance, but it isn't because name doesn't match the regex. The current options are to do the above, which is safe-looking at compile time, but unsafe at runtime, or to use .parse(...) which is unsafe at compile time and safe-ish at runtime (but will throw errors).

Is this what you are looking for?
const userSchema = z.object( {
    name: z.string().regex( /^\w+ \w+$/ ),
    age: z.number(),
} )
type User = z.infer<typeof userSchema>

userSchema.parse( {
    name: 'Bob',
    birthdate: new Date( '1970-01-01' ),
} ) // runtime error, but no compile time error

userSchema.parse( {
    name: 'Bob',
    birthdate: new Date( '1970-01-01' ),
} as User ) // runtime and compile time error

Not exactly, because 1) as-casting isn't really safe, since it allows for missing properties and 2) it involves having a type reference for the schema, or creating one manually via z.infer<...>.
Re 1) this would compile fine:
userSchema.parse({
  name: 'Bob',
  // no age!
} as User)

But maybe on latest typescript versions satisfies would do the trick:
userSchema.parse({
  name: 'Bob',
  // no age!
} satisfies User) // compile time error

For 2) though, it's quite cumbersome when you don't already happen to have a type reference for the schema, e.g.:
getAPISchema().lookupProcedure('user/create').getInputSchema().parse({
  name: 'Bob',
} satisfies z.infer<???>)

The above code would need to be refactored to extract the schema into a variable, import {z} from 'zod', and then use z.infer<...>. Those are all barriers on top of the temptation to just use .parse(...) which accepts unknown so will compile just fine - much less discoverable and much less likely to be used.

Would typedParse() work for you?
const typedParse = <Schema extends z.ZodSchema> (
    schema: Schema, data: z.infer<Schema>
): z.infer<Schema> => schema.parse( data )

const userSchema = z.object( {
    name: z.string().regex( /^\w+ \w+$/ ),
    age: z.number(),
} )

console.log(
    typedParse( userSchema, {
        name: 'Bob',
        birthdate: new Date( '1970-01-01' ),
    } ) // runtime and compile time error
)

typedParse(
    loadAPISchemaInfo().lookupProcedure( 'user/create' ).getInputSchema(),
    {
        name: 'Bob',
    }
)

I don't think that this will ever be added to Zod, because it's my understanding that parse is meant to take something that is unknown and turn it into something that is known at compile time. So when you are trying to parse an object that is statically in the code base, that's something that is already known at compile time. In example code we do this all the time for learning/teaching purposes, but I don't know that I have ever done that in a real app. In real apps I use Zod for checking user input or a response from an api, which are things that can't be known at compile time. I hope this makes sense. Please let me know if you have questions or if I am misunderstanding what you are talking about.

Yes it's a slightly different use case than validating API inputs, and I usually want this when using refinement types, or regex strings, or similar, which perform runtime validation which is not reflected at compile time. And yes that helper function does the trick for most cases - what I'm asking is whether it could become part of zod. There are some edge cases like .transform types with a different input typearg which it'd be sensible to solve in one official place.

Just posted https://github.com/colinhacks/zod/issues/1892 that looks finally really the same than what @mmkal is looking for.
I totally agree with him on implementing it inside Zod. Since Typescript no longer exist at runtime, helping people in writing safer code at compilation helps.
In my case I write fixtures and Storybook stories with mocked data and it's sad Zod cannot tell me my object is wrong when it's missing 90% of the expected props. For sure it's not a magic silver bullet since Typescript wouldn't help with custom validation (min/max/regex...) but at least it helps on having the right properties, and the almost expected property types.

Another way you can solve this problem:
type TypedParseSchema<Schema extends z.ZodSchema> = Omit<Schema, 'parse'> & {
    parse ( data: z.infer<Schema> ): z.infer<Schema>
}
const useTypedParse = <Schema extends z.ZodSchema>
    ( schema: Schema ): TypedParseSchema<Schema> => schema

const schemaWithTypedParse = useTypedParse( z.object( {
    email: z.string(),
} ) )

schemaWithTypedParse.parse( 'hello' )
//                          ^^^^^^^
// Argument of type 'string' is not assignable to parameter of type '{ email: string; }'.

@mmkal and @sneko
Would this work for you?

Yes it would. It's a bit sad to have to make "parser helpers" for each schema. Do you still think this should be kept outside the zod library?

It's a bit sad to have to make "parser helpers" for each schema

What do you mean "for each schema"? The way I wrote it above can be reused on any schema. So you only need 1 useTypedParse.

Do you still think this should be kept outside the zod library?

I don't know if it should be added in or not. I feel like this is up to @colinhacks.

I made a package that has a few utilities for zod and typed parse is one of them. Let me know if it helps.
https://github.com/JacobWeisenburger/zod_utilz#usetypedparsers

What do you mean "for each schema"? The way I wrote it above can be reused on any schema. So you only need 1 useTypedParse.

By making "helpers" I mean if I have UserSchema, CarSchema... for each one I need to do:
const schemaWithXxxTypedParse = useTypedParse(XxxSchema)

(but I agree that's a decent workaround for now, even if I need to write it everywhere I have a schema.

I'm inclined to agree - absolutely, that helper works, but if the use case is valid enough for it to exist in a util library, then I'd argue it'd make sense to exist in zod too. It doesn't really add any meaningful maintenance burden, I don't think, since the implementation is just the same as the untyped parse. A util library is less discoverable, requires separate installation and importing, might break with new versions etc. etc.

I totally agree. But I don't feel like I have the authority to add a feature like this to someone else's library. I am totally fine with maintaining it on my util library because I have the authority to do so.

https://github.com/JacobWeisenburger/zod_utilz#usetypedparsers should be part of zod. Very helpful!  @colinhacks

I just wanted to voice my support for this. In addition to validating user inputs to my API, I'm using Zod to format responses from my API and I have tripped over this a few times where the type that I'm passing in obviously won't parse, like a Promise if I mistakenly forgot to await something, or passing in a T | null or T | undefined where I should have first checked if the value was there. While this isn't the main use-case for Zod, this feels like a really low-cost method to implement that would be useful for cases where you have semi-trusted input you want to parse.

@colinhacks now that zod is seeing more activity recently, what do you think?


[Gssoc'21] Dark Mode with Toggle Button.

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I thought dark-mode will be a cool feature

@utkarsh0702 @HimanchalChandra  please assign it to me as I am a GSSoC'21 participant

@arpit456jain Ok

@utkarsh0702 please review my PR


How to get the top-down visualizations in navigation tasks?

Hey,
I'm trying to find the function that gives me the output below.
I'm working remotely and using a headless docker container, which doesn't allow me to set the vis parameter to True in spatial and object-goal navigation tasks.
So, I'm trying to locate the function for the visualization to save the image to the disc. I got some map visualizations, i.e. plan_to_pos_v2 produced the path, but wasn't able to visualize the path and the robot orientation like the output below since I couldn't find the appropriate function.
Can you indicate which function(s) you used to generate the output below?
Thanks in advance.

I managed to generate a top-down map visualization using insights from issue #27 and this discussion in the Habitat Lab repository.
The required functions are located in this script in the Habitat Lab repository. These functions enable plotting the agent's position, trajectory, and rotation on the map:

def draw_agent()
def to_grid()
def _outline_border()
def get_topdown_map()
def get_topdown_map_from_sim()
def draw_path()

To display the agent on the map, its position values (retrievable via agent.get_state()) need to be converted to grid world indices using the to_grid() function. Additionally, draw_agent() requires the agent's heading value as its rotation argument.
Since habitat-sim does not natively support a heading sensor (unlike habitat-lab, which does), I used the following function to calculate the heading value:
def quaternion_to_yaw(rotation) -> float:
    """
    Converts a quaternion to the yaw angle (rotation around the Y-axis).
    """
    heading_vector = quaternion_rotate_vector(
        rotation.inverse(), np.array([0, 0, -1])
    )

    phi = cartesian_to_polar(-heading_vector[2], heading_vector[0])[1]
    yaw = phi - np.pi / 2

    return yaw - 1.5708

The helper functions quaternion_rotate_vector() and cartesian_to_polar() can be found here.


Redraw charts on div resize

Hi,
I have a few graphs, contained in divs that could change size (there is an expand button on them that makes the divs bigger). My charts do not have a width and height attribute, as from my understanding, that makes them take up 100% of the space, which is what I want.
The issue is that on div resize, the graphs do not respond. If I resize the window, their update function gets called and everything starts working fine.
What I've tried:
1)
nv.graphs correctly returns a list of my graphs
typeof nv.graphs[index].update correctly returns function
but calling nv.graphs[index].update() simply returns undefined

I also tried force-trigerring a window resize event, but that didn't work either.

You can check #146, hope this may help you.


The Wizard could sign your policy

@lulMeow
I have created a wiki post, only using official Microsoft guide and methods, to create a supported certificate and use it to sign WDAC policy files.
https://github.com/HotCakeX/Harden-Windows-Security/wiki/How-to-Create-and-Deploy-a-Signed-WDAC-Policy-(Windows-Defender-Application-Control)


pullDownToRefresh not working when hasMore is false

when all the documents are fetched, the state is updated to hasMore false
But when new documents are added and the user tries to refresh. the pullDownToRefresh not working since hasMore is false.
Refresh content should not depend on hasMore isn't?
hope you guys see this

Up. Still bugged.

I have got the same issue, why that topic has been closed?

Property actionTriggered becomes false in line 91
But if server responses empty array [] then dataLength won't be changed.
Line 86 doesn't allow set to false property actionTriggered.
I think  dataLength should not block refresh function.

I depend on DataLength to know if I should call the API again, it doesn't block render, new props passed in will automatically show up, like children

I got the same issue


fix(remove attribution config again): not releasing so reverting to o…

…lder state to not break.

:tada: This PR is included in version 4.214.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Catch get_realm calls with invalid realm in zerver/views/auth.py

There are a number of calls in zerver/views/auth.py to get_realm -- and most, but not all, catch the potential Realm.DoesNotExist exception that that raises.  The ones that don't currently should catch the Realm.DoesNotExist and raise a JsonableError, to prevent 500's like this:
$ curl -sSX POST https://invalid.zulipchat.com/api/v1/fetch_api_key -d<EMAIL_ADDRESS>-d 'password=wrong'
{"result":"error","msg":"Internal server error"}

@zulipbot claim

Would you like to collaborate?

@JonnyMnemonic123 Sure, we can do that!

@zulipbot claim

Partially addressed by 4f47f35cb4612ac7006060d272ed3471fde45741.

claim

claim

@zulipbot claim

@zulipbot claim

can i work on this issue?

@timabbott  can you review.

@sushant52  are you working on it?

@sushant52  are you working on it?


Persist relative paths for avatar's image and post's featured image

Storing relative paths in database will be beneficial in case app/blog gets migrated or storage disk is changed and the assets are moved.

True, but it still saves an absolute path in the database table like so http://laravel57.test/storage/public/wink/images/OgLzIMmmpzdNWNk0H12Mp2u964hBtuqO75XyiiUE.jpeg
If I were to get a nice domain like my-blog.com instead of laravel57.test and migrate my blog, I would have an error, because the link in will still point to laravel57.test.

@alexrusin no with the new PR the relative path is stored not the absolute one.

@themsaid I am so sorry to bother you again, but I get this when I save avatar.

The same goes for post's featured image:

Is it supposed to be like that?

@alexrusin I don't know why it's doing this for you but it's storing relative path for every one else that I know using Wink.
What disk do you use to store the files? The local one shipped with laravel? It uses relative path; check FilesystemAdapter::getLocalUrl

@themsaid   I am not using local, because sym links don't work well on windows.  I am using the following:
'public_dev' => [
            'driver' => 'local',
            'root' => public_path('storage'),
            'url' => env('APP_URL').'/storage',
            'visibility' => 'public',
        ],

I think local disk stores relatives urls in the database because url is simply not defined on local disk:
'local' => [
            'driver' => 'local',
            'root' => storage_path('app'),
        ],

Actually, I was thinking that no matter what disk you use (local, public, s3, etc.) you should store relative urls in the database and then display the correct ones on the front end by using Storage::url().  Is my assumption wrong?


How to create a readable stream, that automatically emits EOF after the initial contents?

When using this library to test some stream-reading functionality, it appears that the ReadableStream keeps the stream open, and it's not documented how to tell it when to end the stream.
What I would like to write would be something like this
const input = new streams.ReadableStream("contents", { allowAppending: false });
await processStream(input); // resolves when the input stream has been completely processed.

By inspecting the code, I figured that I could call ReadableStream.append(null) to simulate EOF. However, if I call this too early, it doesn't work (my stream processing need to attach event handlers first). So I need to wait with calling this until after I created the promise:
const input = new streams.ReadableStream("contents");
const processPromise = await processStream(input);
input.append(null);
await processPromise;

And since it's not documented, I don't even know if I was ever meant to call it like this.

Same problem, especially evident when using the pump library, and will be same with streams.pipeline now added to node core in v10 (which is literally the pump library).

Same problem here.  The following fix worked for me (just change this._data= ''  into this._data = null)
// Ugggglyyy fix for end of stream
memory_streams.ReadableStream.prototype._read = function(n) {
this.push(this._data);
this._data = null;
};

Please feel free to create a pull request and I’m more than happy to review and include in the project.


fix:  Pass product name to query list item UI

Summary of Changes
This PR addressed https://github.com/lyft/amundsen/issues/546 by passing the product name to the QueryListItem from its parents, in order to show the appropriate product display name in the UI. The product property is passed from DashboardPage -> QueryList -> QueryListItem.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes, including screenshots of any UI changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes all tests documented in the developer guide

Codecov Report

Merging #510 into master will decrease coverage by 8.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   83.59%   75.52%   -8.08%
==========================================
  Files         184       42     -142
  Lines        3859     1814    -2045
  Branches      501      174     -327
==========================================
- Hits         3226     1370    -1856
+ Misses        615      394     -221
- Partials       18       50      +32

Impacted Files
Coverage Δ

...undsen_application/static/js/ducks/search/types.ts

...ication/static/js/components/TableDetail/index.tsx

...on/static/js/components/AnnouncementPage/index.tsx

...plication/static/js/ducks/popularTables/reducer.ts

...application/static/js/ducks/popularTables/types.ts

...ndsen_application/static/js/interfaces/Feedback.ts

...lication/static/js/ducks/search/filters/reducer.ts

...dsen_application/static/js/fixtures/globalState.ts

...pplication/static/js/ducks/tableMetadata/api/v0.ts

...ication/static/js/components/Feedback/constants.ts

... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d4cb8...bd1276f. Read the comment docs.

Thank you, Tamika!


Update content on booking form page for when no associated referrals exist

Context
This commit changes the content of the page shown when attempting to
make a booking for which a corresponding referral doesn't exist for the
person.
We received a support ticket for the page as the user thought they
had encountered an error.
This new content should help give the user better guidance on what to do
next.
Screenshots of UI changes
Before

After

Release checklist
Release process documentation.
Pre-merge checklist

[ ] Are any changes required to dependent services for this change to work?
(eg. CAS API)
[ ] Have they been released to production already?

Post-merge checklist

[ ] Manually approve
release to test
[ ] Manually approve
release to preprod
[ ] Manually approve
release to prod

 Update content on booking form page for 'no referrals'


Add files via upload

SMK IT GLOBAL MADANI
official website  : https://smkitglobalmadani.sch.id

@globalmadanismkit Hi,
Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

Thank you.

@globalmadanismkit You might miss the previous comment. Please react.

@globalmadanismkit Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Influxdb component new branch

I guess you need to rebase here too to align with the current codebase

I'll wait for the Karaf feature and then we can merge. Can you close the other PR?

Thanks obviously :-)


refactor(c/driver/postgresql): No naked new in copy writer

Would like to do this in the reader file as well, although on a first pass converting those all to unique_ptr does not work. Needs a bit more investigation


pylint challenge!

Modify gpkit/tests/pylint.cfg to only create warnings and errors for things you care about. You can test with the command:
pylint --rcfile=gpkit/test/pylint.cfg $(find .  -name "*.py" -print) gpkit/
Alternatively you can rename gpkit/test/pylint.cfg to gpkit/../pylint or gpkit/../.pylintrc and
remove the need for the --rcfile flag.

This was also a test to make sure jenkins did not build from a user that is not white listed. It worked as expected.

Can one of the admins verify this patch?

That last question was actually posted by jenkins (its using my user name a the moment and I need to fix that)

Heh! This is great. Should we set it up to ignore the ctypesgen-generated files (which are a pylint disaster) and so on before merging?

You should setup the config file so it tests what you think is appropriate to be tested. This most likely only means files that you are directly authoring. The file I committed is just the default pylint configuration file, I didn't make any changes to it.

Sounds good.

Guys, let's definitely talk together about what warnings/errors to keep vs. disable, before we make any changes.

Continuing this in #216, so that we have access to make changes before merging.


How to use the PhpAmqpLib with Thruway

Hi,
like in #96 I want to use a message queue as data provider. But we have to use RabbitMQ with PhpAmqpLib (videlalvaro/php-amqplib).  But with the following code the loop and the $channel->wait(); will block the Thruway server.
<?php

require_once 'vendor/autoload.php';

use Thruway\Peer\Router;
use Thruway\Transport\RatchetTransportProvider;
use PhpAmqpLib\Connection\AMQPStreamConnection;

$realm = 'realm1';

$router = new Router();

$client = new \Thruway\Peer\Client($realm, $router->getLoop());

$client->on('open', function () {
    $connection = new AMQPStreamConnection('localhost', 5672, 'guest', 'guest');
    $channel = $connection->channel();

    $channel->queue_declare('hello', false, false, false, false, true);

    echo ' * Waiting for messages. To exit press CTRL+C', "\n";

    $callback = function ($msg) {
        echo " * Message received", "\n";
        var_dump($msg->body);
        // TODO send msg->body to WS clients
    };

    $channel->basic_consume('hello', '', false, false, false, false, $callback);

    while (count($channel->callbacks)) {
        $channel->wait(null, true);
    }
});

$router->addInternalClient($client);

$transporter = new RatchetTransportProvider("localhost", 8080);
$router->addTransportProvider($transporter);
$router->start();

(gist version: https://gist.github.com/nepda/1d95e9b81ba86eca982b)
Do you have a hint, how to get this work?
Thank you!

Also with pure PhpAmqpLib you can't do that, see this lines in your example
Also you can't use libs with network/file access without event loops! For your intention see please https://github.com/JCook21/ReactAMQP

Thank you for your fast response. Unfortunately the library you mention (https://github.com/JCook21/ReactAMQP) is deprecated. "This library is no longer maintained and should be considered deprecated.".
Any other ideas?

Haven't had a chance to look into it, but if you can use the STOMP protocol with RabbitMQ, you might be able to use:  https://github.com/reactphp/stomp

there is another lib for amqp in react bunny/bunny

One issue you'll probably run into with either videlalvaro/php-amqplib or the PECL AMQP library is their I/O is internalized and most likely unable to hook into an EventLoop so your I/O will be blocking.

Okay impossible :-). So we changed our architecture. W're now using WampPost and pushing messages directly to the WebSocket server. No Queue service needed anymore.
Thanks!


72 [BE] Implement blog content management APIs

You have a few migrations that are empty so you can probably remove them.

Files deleted


本地调试 Docker 部署该模板代码，运行报错：(node:31) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

<EMAIL_ADDRESS>start /app
node index.js

(node:31) UnhandledPromiseRejectionWarning: SequelizeConnectionRefusedError: connect ECONNREFUSED <IP_ADDRESS>:3306
at ConnectionManager.connect (/app/node_modules/sequelize/lib/dialects/mysql/connection-manager.js:92:17)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async ConnectionManager._connect (/app/node_modules/sequelize/lib/dialects/abstract/connection-manager.js:220:24)
at async /app/node_modules/sequelize/lib/dialects/abstract/connection-manager.js:174:32
at async ConnectionManager.getConnection (/app/node_modules/sequelize/lib/dialects/abstract/connection-manager.js:197:7)
at async /app/node_modules/sequelize/lib/sequelize.js:301:26
at async MySQLQueryInterface.tableExists (/app/node_modules/sequelize/lib/dialects/abstract/query-interface.js:102:17)
at async Function.sync (/app/node_modules/sequelize/lib/model.js:939:21)
at async init (/app/db.js:25:3)
at async bootstrap (/app/index.js:55:3)
(Use node --trace-warnings ... to show where the warning was created)
(node:31) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:31) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

solved！


Update issue using Shiro.is

Describe the bug
Updating an anime using 'shiro' provider gives this error
'AnimeInfo' object has no attribute 'token'

To reproduce
1) anime watch -n --provider=shiro
2) code geass
3) anime watch -u

screenshot

same thing here, I'll take a look

it seems like it's an issue with shiro.is, imma ping @ArjixGamer as he was the one who made the provider

I want to help in this project as well, but don't know where to begin. It would be really helpful if someone could make a tutorial explaining this project in brief and/or how a new site is added.

ill take a look into it

oh, i get it

will fix


Fix stories intermittently not displaying; clean up story loading

This should fix the blank-story issue — that's been bugging me for weeks, but seeing complaints about it on Get Satisfaction tonight got me sufficiently motivated to fix it.
There's a lot of stuff in here I cleaned up that I don't completely understand (and its commit history is not terribly helpful). Maybe some of it is for old iOS versions? Please review and/or test!

Nice work! I'm going to merge this and we'll see if it causes issues. I'm heading to Burning Man tomorrow so I won't be able to confirm this, but I'm loading this version up on my phone so I'll have it ready. Of course then my phone will be turned off for a week and a half.

I have discovered at least one regression, which is that the hover bubble suppression is not working properly (some injected JavaScript). I should be able to work on this in the next day or so.

OK, now I can't reproduce this.  What was going on was that when tapping and holding on an image, the magnification bubble (callout) was appearing briefly before the expected popup.  I did change where and how often this JavaScript gets injected so there could be a race here, so let me know if you see it and I'll try harder to reproduce it!

Ok, I'm including this commit as part of 6.1.0, which I'll submit tomorrow.


Risk Bubble

I figured I'd do this in pieces -  I made the bubble for the profile header. I'll implement flex box next, and get "Risk Level" to display.

@BWieber Nice!  A few pieces of feedback for you here.
This has the commit from https://github.com/studentinsights/studentinsights/pull/101 in it, which is cool, but you pushed an additional commit to that branch that this branch doesn't include.  This is a pretty normal workflow and to be expected, but we'll have to resolve that before merging this pull request, otherwise that additional commit from the other branch will be undone.  This is a tricky one, since git thinks it can resolve things automatically at the moment, but the automatic resolution would undo part of the commit on the other branch.  You can see this looking at the diff in this pull request - the nice UTF8 bullets are gone.
To fix this, you can checkout to risk_box and then git merge origin/master to merge master in, since it now has your commits from that other branch.  When you do that, you'll see there are merge conflicts.  That's because git detects a conflict between the additional commit https://github.com/BWieber/studentinsights/commit/a3379db6ad5dfa78f276357b73572580371c397e and the risk bubble commit https://github.com/BWieber/studentinsights/commit/8d67e810173d438b229c263fb3b81b01a03b398e, and can't resolve it automatically.
These are the relevant lines:

This should be straightforward to resolve, and if you need more info on merge conflicts GitHub's a good source.  Then you can push up the branch again, and the conflict should be resolved!

Also, this pull request always uses 3 for the risk level, but it needs to show the actual data :)  It looks like this data isn't actually being sent down to the UI at the moment, so I added that in https://github.com/studentinsights/studentinsights/pull/118.  After merging master in (above), you should be able to use this.  The shape of the data looks like this, and level is the field you want:

And finally, checking this out locally, it looks like the risk level bubble looks bigger than the screenshot here.  This is what I see:

I think the key things is that this needs to be display: inline-block in order for sizing rules to have the effect you want.  And then you can tone down the different size params a bit.
I'll let you take a look at this, and am happy to help finish this off later this week too if that's helpful.  I should have allocated more time last night to look at this with you too, so my bad and we can make sure to do that next time. :)

@BWieber Cool, if you can make it tomorrow, let's work together to finish these off and get them merged.  If you can't make it tomorrow that's cool too just let me know and I can help out.

Hi Kevin!
I can definitely make it tomorrow - I have the controller work done too. I
might need a little git help to ensure that I don't keep posting conflicts

I think I may not be pulling from the right repo!

On Mon, Feb 29, 2016 at 12:20 PM, Kevin Robinson<EMAIL_ADDRESS>wrote:

@BWieber https://github.com/BWieber Cool, if you can make it tomorrow,
let's work together to finish these off and get them merged. If you can't
make it tomorrow that's cool too just let me know and I can help out.
—
Reply to this email directly or view it on GitHub
https://github.com/studentinsights/studentinsights/pull/108#issuecomment-190297725
.

@BWieber Yeah no worries!  I can help resolve it, but let's try doing it together then so we can talk it out.  Thanks again for your help!

Merged with the upstream to clear up previous conflicts!

Merged format_student_grade to ease the branching.

For my own memory, the next steps we talked about at Code for Boston were to factor out RiskLevel to its own React component, and then update the color logic.  Then we can :ship: it!

Hi Kevin!
The risk bubble is now a part of it's own component, and is currently being successfully rendered. The coloring is also in full effect, 1 (Green), 2 (Yellow), 3 (Red). I believe all of the students currently have a 2 value, but I tested it in development and it ran successfully.
Here is the current image:

As you can see, the current Risk Level and bubble are a bit offset. I discovered what was causing the problem, but I went through a few iterations without success.
The code in question is this:
    render: function() {
      return dom.div({},
        dom.span({
          style: merge(styles.riskBubble, { backgroundColor: this.bubbleColor() })
        }, this.props.riskLevel),
        dom.span({
          style: styles.riskItem
        }, "Risk Level")
      );

    },

    bubbleColor: function() {
      if (this.props.riskLevel === 1) return 'green';
      if (this.props.riskLevel === 2) return '#ffc41d';
      if (this.props.riskLevel === 3) return 'red';
    }
  })

This renders the above image. The reason the element is offset is because of the dom.div call. I have tried to remove it and it works... except the bubbleColor function no longer renders, this no bubble. I tried a various set of attempts, but to no avail - I kept getting the following error:
Uncaught Error: Invariant Violation: RiskBubble.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.
Using a console.log test, RiskBubble was indeed being called - but I couldn't discover what was throwing this error.
I'll take a further look soon. Let me know if you know the answer!
Brandon

@BWieber nice debugging, and awesome write-up!  :smile:
You're spot on that it's that div that's causing the problem - div is a "block" element, which means by default it starts a new line and takes up the entire width of the container.  The other elements, like a and span are "inline" elements, which means they flow like text would, left to right.  This article looks like it has a decent explanation.
Here, you can change that div to a span and that should help move in the right direction.

Hi Kevin,
Thanks for the resource and the suggestion - the risk bubble is no being properly rendered with the right color and style! Take a look:

Risk Bubble will properly respond to the integers 0, 1, 2, and 3. Does the risk level go any higher than that? I also changed the coloring options to match the Homeroom page - the bubbles have consistent coloration across the app.  Otherwise, I think this PR will get this closed. Let me know if it needs anything else !
Brandon

@BWieber Awesome!  :smile:  I will take a look at this tomorrow if I'm able, and if not let's definitely get this fully shipped this week.  Have a great weekend, and thanks again for all your help!

@BWieber This looks good!  One minor piece of style feedback, and then a stray migration got checked in here, but if you can take care of those let's ship this! :+1:
Also, @johnrobbjr had some design suggestions in https://github.com/studentinsights/studentinsights/issues/151#issuecomment-195026223, but let's merge this first and address that separately.

I believe this should have removed the stray migration change. I pulled from master and pushed it back.

@BWieber This looks like something drifted from the screenshot here, looking at the demo site on this page.

I haven't deployed this to production yet, so am going to revert this and then we can investigate without having to do a hot fix.
@BWieber I am a little backed up this week, but let me know if you aren't able to reproduce this locally.


I am trying to use gogoanime but it doesn't work

Source information
Gogoanime 13.78 (English)
Source language
English
Steps to reproduce
When i try to open a series

Expected behavior
It should been easy to watch on gogoanime

Actual behavior
But every time i play a episode this happens

Aniyomi version
App version: <IP_ADDRESS>
Android version
Android version: 13
Other details
Here i are my device details please help ASAP ( Android version: 13 (SDK 33)
Android build ID: TP1A.220624.014.M127GXXS6DWK1
Device brand: samsung
Device manufacturer: samsung
Device name: m12
Device model: SM-M127G
Device product name: m12dd )
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

gogoanime has moved to new domain anitaku.io

apparently anitaku.io is Unofficial domain but anitaku.to is working now and the extension is working fine

Closing as this issue has most likely been solved in the new app update. If the issue persists, please create a new issue.


Plague report

Create the plague report.

A basic Plague report exists, will close this issue but some work might still be needed later


Click to move the marker instead of draging

Hello.
Is it possible to move the marker by a click in the map instead of dragging the marker?
Thanks.

Great, thanks a lot it works perfectly.


hope to enhance the optimization for e-ink display devices

Describe your suggested feature
I hope to increase optimization of ink screen equipment, such as:

There is a switch that can cancel all animations in the software;
The bookshelf/Manga list can support pagination sliding without animation effects;
Thank you all.

Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

E ink options already exist for the reader.
The e-ink androids I've seen are able to swipe through the library without issue. But instead of creating a setting in the app, you can always just disable animations in developer settings.

Note: there will still be a slight animation if you swipe between categories. But it should be skipped if you use the icons at the top to switch.
And I'm sorry subdividing categories into pages seems like the stupidest ideas. Just create more categories 🤣

好的，已收到，稍后我会进行查看，感谢来信


Tdd more tests

Adds test cases for optional people & code to handle those cases
Note: I know this looks like a lot of changes/is difficult to tell what is different from the previous one, I have been waiting for my previous PR to be merged before opening this one so the new changes in this one are easier to read, however I also don't want to submit this too late in the week. Unfortunately, none of the new changes in this PR would make any sense if they were not submitted alongside the changes in my previous PR that also haven't been merged yet

Resolved merge conflicts between master & TDDMoreTests


NB2 does not show results

Hello, I need your help with NB2. When I I execute the function[ aez.simulateCropCycle(start_doy=1, end_doy=366, step_doy=1, leap_year=False)].  It'll be completed quickly. However, the run did not yield any results, as shown below.

Hi @hzaulw,
From the information, it is difficult to determine the error. Could you please provide the following information?

Python packages versions
Error message (if you encounter)
All your input data and results

Regards,
Swun Wunna Htet


order by id

I want to do a GET request /api/resources?order[id]=DESC to sort results by id
My configurations:
services:
    api.filter.order:
        parent: CleverAge\EAVApiPlatformBundle\Filter\OrderFilter
        tags:
            - { name: api_platform.filter, id: api.filter.order }

resources:
    App\Entity\Resource:
        attributes:
            filters:
                - api.filter.order

But I got 500 error with message: No attribute with code : Unknown attribute id in family Resource.

The id is a standard Doctrine attribute, you juste have to follow the API Platform documentation on this one:
https://api-platform.com/docs/core/filters/

ok, I got it working now with api_platform.doctrine.orm.order_filter, thank you very much @VincentChalnot

Sorry, but I have another problem:
Let's say my Resource now has an attribute title, and I want to offer order filter for both id and title, my api resource config:
resources:
    App\Entity\Resource:
        attributes:
            filters:
                - api.filter.order # this is to sort by `title`
                - api.filter.api-platform.order # this is to sort by `id`

Not sure if this is the correct config? If I sort by id, api.filter.order will process first and thow an error Unknown attribute id

You're right! There is a bug indeed, there is no check against the property of the order by in the OrderFilter logic.
Do you think you can provide a PR to fix this ?
The idea is to use the already existing logic inside the AbstractEAVFilter to update the OrderFilter so that it only applies for declared properties like other filters.

I have just tried it again and could not reproduce yesterday's problem, I must have done something wrong yesterday.
I check AbstractEAVFilter and it's working with this line being called before OrderFilter::filterAttribute
for reference, it's working with this config:
resources:
    App\EavEntity\Resource:
        attributes:
            filters:
                - api.filter.order
                - api.filter.api-platform.order

services:
    api.filter.order:
        parent: CleverAge\EAVApiPlatformBundle\Filter\OrderFilter
        arguments:
              - {title: ~}
        tags:
            - { name: api_platform.filter, id: api.filter.order }

    api.filter.api-platform.order:
        parent: api_platform.doctrine.orm.order_filter
        arguments:
            - {id: ~}
        tags:
            - { name: api_platform.filter, id: api.filter.api-platform.order }


HTML tags are not rendered

instead they are escaped. But Github Flavoured markdown permits direct use of HTML.
Simple example is classic  tag.

Oh good spot. This'll have change when I switched from marked to markdown-it as the renderer, because markdown-it's default is to escape all HTML.

There we go, should work properly now

wow, that was quick. thx now it's perfect,


[OIDC] User docs

This is a (mostly) unedited copy of the private beta docs; needs cleaning up.

There's both a docs/user/OIDC-publishing/index.md and docs/user/oidc-publishing/index.md here, causing duplication: https://docspypiorg--13285.org.readthedocs.build/

https://github.com/pypi/warehouse/pull/13285/commits/73aaf16ac89e2c8c49220d1029acfcb65a6f4fe4 was a cp not a mv?

73aaf16 was a cp not a mv?

Blegh, this is a macOS case thing -- I only have one of these directories locally. I'll fix it.

Let me know if you'd like me to update the screenshots as well: a few of them reference my account or pip-audit as well; I can make them generic instead.

At a high level: I think I want to avoid using the "OIDC" acronym as much as possible, and instead rebrand this as "trusted publishing" or "trusted publishers". The few exceptions are when we explain in detail how this works in the background, and security model.

Makes sense! I've removed a few other refs to "OIDC", but preserved all of the ones under the security model and low level use section.


UI not aligned

I believe this is because my UI scale is 200%. Since I use a 4k screen to play the game, the default value for UI scaling is 200%, so it happens.

I'm also playing at 200%/4K. But this misalignment is a necessary sacrifice because I wanted the window to be draggable- you can use the drag handle on the left to position it where you want. This means I can't position it perfectly correctly to start.
In short, known tradeoff, just drag it where you want it.


Use Veekun's Pokedex data instead of building our own

The data currently used in PokeAPI v1 builds out it's own data set, which isn't very efficient when we want to update it or add new content.
Let's reformat the v2 resources to use a mirror or as close to the original dataset as possible.

Using a mirror of veekun data.


Creating the consensus folder a few pr from bitcoin are in this pr.

This pr backports multple PR from bitcoin
bitcoin#5696
bitcoin#5812
bitcoin#5669

This is also not done yet


minifront footer plugin generates bad git commit URL

https://github.com/penumbra-zone/web/blob/9db3989190f22b72545644a4b92a2c2286657ea0/apps/minifront/src/utils/commit-info-vite-plugin.ts#L9-L12
this may create a url like https://localhost:5173/git@github.com:penumbra-zone/web/commits/ceafe995e08db5f9f6fdaaa84c484706ea188251

We haven't encountered this I suppose because actions/checkout@v4 does not use ssh to pull down. Regardless, we can improve this plugin to guard against that possible case.

closing since we haven't encountered this


Increase precision for input_number and climate-controller

So I tried to cleanly apply the changes I made back then to the main branch. Haven't tested this. For some reason I can't add it as custom repo in HACS anymore, because it complains about a non-compliant structure.
I also was not sure back then if this only worked for Celsius. Maybe someone using Imperial units should test it as well.
Let me know if this works and/or needs proper formatting. Would see if I can install a formatter for Typescript. I am really not web guy and just poorly hacked something together back then that worked for me.

Sure, I use to for input_number entities that I use as a heating setpoint for my thermostats. That is pretty much the only use I had for it.

Thanks - can you share the card config (yaml) so I can do my own testing as well?

Sorry for the late reply.


"Cannot access a disposed object", Object name : 'LogEntryList'

Summary
After entering SandBox mode, the log view spams continuously this error : http://pastebin.com/ZfiFy9L3
How to reproduce
I think it happened after Duality crashed because of a newly added buggy component, which was removed after restarting Duality. I haven't been able to reproduce it.
Workaround
Restarting Duality removed the problem.

It looks like an editor-internal error, but I'm not sure how this specific one could happen. If you manage to reproduce this later, please add more details in a comment. Otherwise, I'll likely have to do a blind fix, i.e. we won't know for sure whether it's actually gone or just hasn't happened again yet.

Managed to reproduce and fix it. When closing a LogView and opening a new one, the old LogView was still subscribed to log events.
Release in progress. Closing this.


test(benchmarks): improve bechmarks to have complete performance data

Description
Added the missing Sparse Merkle tree, the missing operations:

Added Sparse Merkle Tree to the benchmark suites to complete the available merkle tree implementations in zk-kit.

Added operation to the benchmark suites (proof generation, proof verification, update, delete

Changed the "imt.ts" name to "benchmark-merkle-trees.ts"

Added README.md documentation about the benchmark suite

Added log managment with winston library to handle any error produced during the benchmark withtout break the benchmark execution

Related Issue(s)
Closes #311
Other information
The results folder is present in gitignore then the results are not included in the pull request, but you can use the README.md instructions to generate it.
Checklist
It would be helpful to write a comparison of of all them, answering questions like

[ ] "when not to use"/"when to use"
[ ]  "used by?": protocol xyz, app xyz...
[x] include benchmarks: maybe one merkle tree is faster at generating a proof, but slower to update?

Dear @sripwoud, I have made the changes and run the recommended yarn commands before commit, but I have received the error:
"YN0028: The lockfile would have been modified by this install, which is explicitly forbidden."
Please give me some clues about how to solve it, I used node 20.17.0 and yarn 4.1.0, when I run yarn to install the dependencies the yarn.lock has been changed but I didn't include it to the commit because I thought that is not convenient.

Hello, I have already fixed the problems in validation of the PR.

I have already took action in all the requested changes, please @sripwoud  let me know how it looks

@prodasl

YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

is this solved, or do you still need help with this?

@prodasl

YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

is this solved, or do you still need help with this?

@prodasl

YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

is this solved, or do you still need help with this?

Hi, @sripwoud, thanks for the support.
I have some doubts about it yet, it is related to my try to send the changes on yarn.lock, because the first time I did the PR, I haven't sent the changes of yarn.lock, but this time I have a lot of change reported in the yarn lock related to packages versions, the only real change was the winston lib added, then my questions are:
Should I include the changes of yarn.lock or definitely it should not be part of the PR? (when I not included I got the mentioned problem YN0028)
If I include the yarn.lock, should I include the package version changes or just the new line for winston lib?

Finally, I tried sharing the yarn.lock as it is in my local environment, sorry for all the trouble but I have not worked with those files before, all the checks in Github looks like are passed and all the change requests covered.
Please let me know if it is ready. (thanks again)

@prodasl

YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

is this solved, or do you still need help with this?

Hi, @sripwoud, thanks for the support.
I have some doubts about it yet, it is related to my try to send the changes on yarn.lock, because the first time I did the PR, I haven't sent the changes of yarn.lock, but this time I have a lot of change reported in the yarn lock related to packages versions, the only real change was the winston lib added, then my questions are:
Should I include the changes of yarn.lock or definitely it should not be part of the PR? (when I not included I got the mentioned problem YN0028)
If I include the yarn.lock, should I include the package version changes or just the new line for winston lib?

TLDR: you should commit any changes to yarn.lock every time you change deps in package.json
If there are more changes in yarn.lock than strictly related to your PR it is okay and normal: it is due to yarn bumping deps automatically according to semantic versioning rules.
In practice devs exceptionally review changes in yarn.lock because there are always so huge. Reviewing package.json changes is enough.
But avoid modifying yarn.lock yourself. Stick to the yarn add/remove commands.
If it happens that there a mismatch between the committed yarn.lock and package.json then you get the error:
YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.


api.delete can return a status object

We had assumed that delete could be modelled as:
pub fn delete(&self, name: &str, dp: &DeleteParams) -> Result<Object<P, U>>;

but turns out kube sends:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Success","details":{"name":"baz","group":"clux.dev","kind":"foos","uid":"XXX"}}

on a successful delete.
See #28 for more details. Fix client.request to fix this.
Edit: same is true for delete_collection (when it's not backgrounded).

Tempted to use the either crate to make the return types:
pub fn delete(&self, name: &str, dp: &DeleteParams) -> Result<Either<Object<P, U>, Status>>;
pub fn delete_collection(&self, lp: &ListParams) -> Result<Either<ObjectList<Object<P, U>, Status>>;

Hey @clux , I was looking at the api of delete, and I wonder why does it actually return either a resource or a status? Based on the API docs of kubernetes (https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#delete-cronjob-v1beta1-batch) it looks like it should only return a status and never the resource itself?

Yeah, kubernetes isn't that great at documenting this. See https://github.com/kubernetes/kubernetes/issues/59501
At any rate, this resource itself does appear out of the api, and it's consistent across all resources. k8s-openapi even has a uniform DeleteResponse type that codifies this behaviour.

Thanks! Do you know if it is the case that whenever a status is returned rather than the deleted object, there was an error?

No, that should not be true.  Kube returns 4xx/5xx errors as Error so errors should not bubble up through Status in an Ok(Either::Right) but should come in as an Err(kube::Error::Api(ae)).
Generally, Ok(Left) (the object return) is "about to be deleted", and then you can poke o.status and often see stuff like:
reason: Some("InstanceDeletionPending"), status: "True", type_: "Terminating"
(that's from crd_api example).
If you get an Ok(Right), it's usually gone-gone. Don't think I've seen other types of responses :thinking:
In the examples we have slept a bit to wait for k8s to catch up, but it's possible to call a watch on object explicitly if you need to wait for a delete to have occurred.
This stuff probably needs better documentation.


Initial GA work for digital twins

Regenerating the protocol layer and adding the generated options classes to our convenience layer APIs
Also removing the local copy of the swagger that we had, now that the digital twins GA swagger is in the rest specs repo

Do you mean to merge this to master or feature/adt/ga?


upgrade libgit2 to v1.3.0

upgrade alpine to alpine:3.15
upgrade git2go to v33 to support libgit2 v1.3.0 link

Please check the latest commit


Update the script used by travis.yml to properly generate kabanero-operators.yaml

The kabanero-operators.yaml generated by the release build is not quite correct.
Update travis.yml to use the script located here: contrib/gen_operator_deployment.sh.
This script accepts as input the IMAGE to be used as the kabanero operator deployment's image.
The image value could be set through a travis-ci env variable.

This is part one of this fix: #70


An error "Frame not in module" pops up when launch template with legacy debug while install VS2019  and VS 2022 at the same time.

Environment

Prepare environment

Install VS2019
a. Make sure to install Python 3.7.* when installing the Python workload
Install VS2022
a. Make sure to install Python 3.9.7 when installing the Python workload

Steps to Reproduce

Open cookiecutter explorer
Load the following template: https://github.com/brettcannon/python-azure-web-app-cookiecutter
Keep default values and click Create and Open Folder
You should see the generated files in Solution Explorer – Folder View
Open webapp.py and put a breakpoint on first line in do_GET method
Go to Tools -> Options -> Python -> Debugging -> Enable legacy debug
Press F5
Observes

Expected behavior
After press F5, it should start a console. Open a web browser to http://<IP_ADDRESS>:5555, It should hit the breakpoint.
Additional context and screenshots
An error message pops up.

@linette-zyy Does this repro when "Use Legacy Debugger" is NOT selected?

@AdamYoblick
When "Use Legacy Debugger" is not selected, this issue is not repro.

This issue is already fixed in the latest debugger (debugpy), we're not going to fix it in the old one.


Integrated iterm2-colors

Added iterm2-colors as an npm dependency. With this package, you get all iterm2 color schemes for free: (https://github.com/mbadolato/iTerm2-Color-Schemes).
To fully leverage this, there should be some preference pane where you can toggle what CSS gets loaded. For now, you can easily toggle it in source.
E.g. Duotone Dark theme:

E.g. Darkside theme:

E.g. Solarized Dark theme:

It does not work with all themes perfectly, since black-screen does not use all the same variable names. Maybe a good thing to do is to align to the iTerm2 color schemes (since it matches so close already)?

Hi, @kevin-smets. I didn't realize it would be so easy to add themes support. I totally agree that we should align the color names. However, I can't accept this feature in such a state. We need those two things you mentioned to merge it:

Match the colors
Have the ability to change a theme without modifying the code.

About the second one, we could add a top-level class like solarize-theme, and then depending on it would change the actual colors. For now the theme could depend on a global variable, for example.
I will do that eventually, but if you'd like it to be shipped faster, you're welcome to finish the work. :)

As this issue suggests, we could have a dotfile for configuration.

Hi, @kevin-smets. I've made a decision that Black Screen won't support themes. Because I'm afraid people will make a white one. Just kidding. Seriously speaking, I'm afraid they won't be of good quality.

No problemo, it's your project :D. Sorry that I left this PR open.
If quality is a concern, you could certainly limit to only the quality themes, or a personal selection. But this collection is an existing one which serves a lot of iterm2 users. I do see it as a missed opportunity to easily integrate a load of already existing and battle tested themes.
Is this out of scope forever? Or maybe I could convince you with a more integrated solution?

It's sad to see that such a nice project is missing an opportunity to be more customisable. I think that if the quality of the themes is a real concern, then shipping only a selected set of themes would be a solution. But just closing a pull-request (it's already done and @kevin-smets is open for improvements!) seems to me a strange decision.. "(

Albeit just a user, I figure I'll drop my 2 cents here. While it is @shockone's project and whatever he says should be law, it would be NICE to see the customisability already worked on to be implemented here. Especially with this much support already available (referring to the iTerm2 color repo). I honestly have to say that I agree with @laughedelic with his thoughts on this. I think that a user should have freedom to make his/her set up as hideous as possible - assuming that's what they want to do. Freedom, my good sir, freedom. ;)

It is possible indeed, @crutchcorn. All you need is to change the colors in the source code and rebuild the project.
If we have many requests for themes, I might implement it, but for now it sounds unimportant comparing to other things at hand.

Still though, while I don´t particularly mind doing work with the source and rebuilding - it would be less work to just have it as an option.
Ooooh, I COMPLETLEY understand that!!! I thought you were just opposed to the idea as a whole and will never implement it. I would rather have a release for the project than just having some silly config stuff working without the functionality or stability/usability there.


Manually start a trace

I have a in-house built DB scheduler and I would like to get Sleuth working with it, so when a job starts, trade-ids are logged. Currently the application is working with Sleuth for http requests and logging correctly for those.
Is it possible to manually start a trace?
I can only find documentation around starting spans and copying traces over to new threads.

I don't understand the problem. Are you saying that there already is a trace but you would like to start a new one? If you really need to do it like this you can call Sleuth's tracer.withSpan(null) that should clear anything currently there in scope. Then when you start a new span tracer.nextSpan(...) you will start a new trace.


chore(ci): bump aws-actions/configure-aws-credentials action

Description of your changes

As mentioned in the title and linked issue, the aws-actions/configure-aws-credentials action has received a major update. This PR bumps and pins the version to the latest available and introduces a setting to continue masking the AWS Account id of the role being assumed.
Related issues, RFCs

Issue number: #1662
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[ ] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my change is effective and works
[x] The PR title follows the conventional commit semantics

Breaking change checklist
Is it a breaking change?: NO

[ ] I have documented the migration process
[ ] I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Example of the action working successfully: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/6015640113


Remove unnecessary blackfriday dependency

The version of blackfriday is causing that we cannot build go-md2man any
more within CRI-O. This commit removes the dependency since is not
needed at all.

bot, add author to whitelist

LGTM, very odd that this is still mentioned in go.mod :thinking:

Restarted the flaked test. I think that go mod tidy isn't yet where it should be as it should take care of that... (FYI @edsantiago)

Go 1.13 seems to have fixes related to such cases.

@rhatdan @mheon @edsantiago @baude  PTAL

LGTM

/lgtm

LGTM


Fails to install with "not enough arguments in call"

Expected Behavior
go get -u github.com/Azure/azure-event-hubs-go/...
successful installation
Actual Behavior
$ go get -u github.com/Azure/azure-event-hubs-go/...
go: finding golang.org/x/crypto latest
go: finding golang.org/x/net latest
go: finding golang.org/x/sys latest
go: finding gopkg.in/yaml.v3 latest
go: finding github.com/golang/groupcache latest
# github.com/Azure/azure-event-hubs-go/storage
../../go/pkg/mod/github.com/!azure/azure-event-hubs-go@v1.3.1/storage/storage.go:568:42: not enough arguments in call to blobURL.ToBlockBlobURL().Upload
        have (context.Context, *bytes.Reader, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions)
        want (context.Context, io.ReadSeeker, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions, azblob.AccessTierType, azblob.BlobTagsMap)
../../go/pkg/mod/github.com/!azure/azure-event-hubs-go@v1.3.1/storage/storage.go:592:45: not enough arguments in call to blobURL.ToBlockBlobURL().Upload
        have (context.Context, *bytes.Reader, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions)
        want (context.Context, io.ReadSeeker, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions, azblob.AccessTierType, azblob.BlobTagsMap)

Environment

OS: Windows (WSL2 Ubuntu 20)
Go version: go version go1.13.8 linux/amd64
Version of Library: Any

I've been following the guide here: https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-go-get-started-send to the letter  - got to here: https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-go-get-started-send#go-packages
running exactly what's typed in the official guide delivered the message - what's wrong here? Can't find anyone else encountering this error

The key indication here is that latest of each dependency is being pulled down, rather than the version of the dependency required in the go.mod and go.sum files for github.com/Azure/azure-event-hubs-go.
Seems like you might be running this in your GOPATH with GO111MODULE=auto (the default). You have 2 options.

You can run go get -u github.com/Azure/azure-event-hubs-go/... outside of your GOPATH, which will cause it to use Go modules by default, rather than fetching latest for each module.
You can run GO111MODULE=on github.com/Azure/azure-event-hubs-go/....

This is great feedback and the docs should be updated to help folks from running into this problem.
Learning about how Go fetches dependencies and how Go modules work is super helpful. Happy to answer questions you may have about modules vs fetching latest and stuff like that.
Hope this helps.

Thank you for the quick reply
I should have mentioned it in my question, but I actually have GO111MODULE=on and I'm running it from ~/workspace/go-playground/event-hubs (so not the GOPATH), and I encounter the issue nonetheless.
Any ideas what else can I do?
(I might be missing something in my understanding of how go modules work)

I've deleted my ~/go contents and ran go mod init <something> in my code directory - got a different result this time, but ends with the same error:
...
go: finding github.com/google/uuid v1.1.2
go: finding go.opencensus.io v0.22.5
go: finding github.com/Azure/go-autorest v14.2.0+incompatible
go: finding github.com/Azure/azure-sdk-for-go v49.0.0+incompatible
go: finding golang.org/x/sys latest
go: finding github.com/Azure/go-autorest/tracing v0.6.0
go: finding github.com/mitchellh/mapstructure v1.4.0
go: finding github.com/mattn/go-ieproxy v0.0.1
go: finding github.com/Azure/go-autorest/autorest v0.11.12
go: finding github.com/Azure/go-autorest/autorest/date v0.3.0
go: finding github.com/davecgh/go-spew v1.1.1
go: finding golang.org/x/crypto latest
go: finding golang.org/x/net latest
go: finding gopkg.in/yaml.v3 latest
go: finding github.com/jpillora/backoff v1.0.0
go: finding github.com/Azure/go-autorest/autorest/adal v0.9.5
go: finding github.com/sirupsen/logrus v1.7.0
go: finding github.com/Azure/go-autorest/autorest/validation v0.3.0
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/pmezard/go-difflib v1.0.0
# github.com/Azure/azure-event-hubs-go/storage
../../../go/pkg/mod/github.com/!azure/azure-event-hubs-go@v1.3.1/storage/storage.go:568:42: not enough arguments in call to blobURL.ToBlockBlobURL().Upload
        have (context.Context, *bytes.Reader, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions)
        want (context.Context, io.ReadSeeker, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions, azblob.AccessTierType, azblob.BlobTagsMap)
../../../go/pkg/mod/github.com/!azure/azure-event-hubs-go@v1.3.1/storage/storage.go:592:45: not enough arguments in call to blobURL.ToBlockBlobURL().Upload
        have (context.Context, *bytes.Reader, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions)
        want (context.Context, io.ReadSeeker, azblob.BlobHTTPHeaders, azblob.Metadata, azblob.BlobAccessConditions, azblob.AccessTierType, azblob.BlobTagsMap)

Ok... Here's what's going on and why the documentation should be changed (@catalinaperalta & @jhendrixMSFT).
When you run go get -u Go is going to try to update the dependencies with the latest version it can based on the module dependencies. In this case, that means go: github.com/Azure/azure-storage-blob-go upgrade => v0.11.0 from github.com/Azure/azure-storage-blob-go v0.6.0 specified here. The problem with this is that the storage library made a breaking change between v0.6.0 and v0.11.0, which is why you see the not enough arguments error.

Yes. Looks like that did the trick. Thank you!


bug(python): Fail to delete rows due to OSError: LanceError(IO)

LanceDB version
v0.10.1
What happened?
Row deletion on the attached table
test_table.lance.zip
fails with this error:
OSError: LanceError(IO): Execution error: External error: Execution error: LanceError(IO): Did not find any data files for schema: Field(id=-1, name=_rowaddr, type=uint64)
Are there known steps to reproduce?
No response

I've tracked this down to a bug involving scalar indexed scans, delete, and the new stable row ids.  This commit includes a small unit test reproducing the issue: https://github.com/lancedb/lance/commit/5421ea593ebac35116b95d11de1e44488ba1db03
If we call delete then we perform a filtered scan to get the row addresses to delete.
If the delete filter is on an indexed column then that filtered scan becomes an indexed scan
Indexed scans currently return the row id (and not the row address)
I think the fix is:

If there are no row id sequences then the scalar indexed scan should assume the row ids are the row addresses and simply rename the output column (or duplicate it if the caller wants both row id and row address)
If there are row id sequences then an indexed scan will first need to materialized then index to get the row ids and then do a lookup in the row id sequences to convert the row ids into row addresses

I think we can add that first path today and leave that second path as a todo item for stable row ids?
CC @wjones127 for confirmation / second opinion

I have already created a fix for this for when using new stable row ids. But I didn't think this would affect users not trying out that experimental feature. Here is the fix for stable row ids: https://github.com/lancedb/lance/pull/2609
I can add a similar test for address style addresses.

Confirmed that fix upstream will address this. We will be making a release soon with that fix.


Verify email is in gov domain

This is branched off #17, so won't be merged until after it.
This PR implements basic whitelisting on sign up emails - .gov.uk and subdomains are allowed, everyone else isn't.
This was the quickest implementation, there are patterns that beat the very simple string test - not sure how much time it's worth spending on a bulletproof regex (should we lift the one we have from PHP? seems horrible.)

Notably this is ugly right now:

Scanning the designs I can't see this case, but I can make it a bit better than this at least!

Talking to @tommotaylor irl, decided to leave the "style the error messages in a GDS way" functionality out of this.
It's something we'll need to do for both this and #17, so let's get both merged and then worry about it as a separate task.


Making generic pages to look consistent

Fixed colors and paddings across generic pages (Cluster Settings, Add Clusters, Extensions).
Regrouped sections and added navigation inside Cluster Settings

https://user-images.githubusercontent.com/9607060/112145799-e164ff00-8beb-11eb-9837-7c6fc285a2ce.mp4

Resolved #2371

Closing this in favor of https://github.com/lensapp/lens/pull/2446 and similar upcoming PRs.


Inconsistent rounding for toStringAsFixed

The following set of assertions passes:
expect((0.55).toStringAsFixed(1), '0.6');
expect((1.55).toStringAsFixed(1), '1.6');
expect((2.55).toStringAsFixed(1), '2.5');
expect((3.55).toStringAsFixed(1), '3.5');
expect((4.55).toStringAsFixed(1), '4.5');
expect((5.55).toStringAsFixed(1), '5.5');
expect((6.55).toStringAsFixed(1), '6.5');
expect((7.55).toStringAsFixed(1), '7.5');
expect((8.55).toStringAsFixed(1), '8.6');
expect((9.55).toStringAsFixed(1), '9.6');
expect((10.55).toStringAsFixed(1), '10.6');
expect((11.55).toStringAsFixed(1), '11.6');
Values between 2.55 to 7.55 round down while the other numbers round up.
I'd expect it to follow similar rules to the round method:
Rounds away from zero when there is no closest integer: (3.5).round() == 4 and (-3.5).round() == -4.

@floitschG

This is working as intended. It's a consequence of how floating-point numbers work...
When Dart reads a fractional number, it is converted into an IEEE double-precision number. Since doubles only use 64 bits, the number might not be represented exactly. In fact, for your given numbers, the internal representations are "rounded" (roughly) as follows:
0.55 -> 0.550000000000000044409
1.55 -> 1.55000000000000004441
2.55 -> 2.54999999999999982236
3.55 -> 3.54999999999999982236
4.55 -> 4.54999999999999982236
5.55 -> 5.54999999999999982236
6.55 -> 6.54999999999999982236
7.55 -> 7.54999999999999982236
8.55 -> 8.55000000000000071054
9.55 -> 9.55000000000000071054
10.55 -> 10.5500000000000007105
11.55 -> 11.5500000000000007105

The toFixed function uses the internal representation to decide how to round the numbers, which explains the results you see.
There is unfortunately not much we can do. You happened to write "6.55" as number literal, but if you had written "6.54999999999999982236" the literal would have been read in the same way: 6.54999999999999982236 == 6.55 is true.
The only (reasonable) way to avoid these rounding issues, would be to use a different internal representation, but all CPUs are heavily optimized for doubles, and switching to a different representation would have huge performance implications. It would also make interfacing with other languages much much harder.
Finally, for your amusement, here is a similar problem:
print(0.1 + 0.2);
print(0.1 + 0.2 == 0.3);


Any reference papers or  documents for piecewise_jerk_path_optimizer and piecewise_jerk_speed_optimizer?

Any reference papers or  documents for piecewise_jerk_path_optimizer and piecewise_jerk_speed_optimizer?

@ jmtao @yifeijiang @natashadsouza

@lucianzhong I searched and unable to find anything on internet.  There's a technical post from us:
https://mp.weixin.qq.com/s/ao5hC_3A7fn8_L_PFw399A
You can find how we piecewise jerk algorithm there.
thanks for supporting Apollo!

@jmtao  Thanks a lot. 非常感谢


Custom armor durability

Description
Describe as well as you can about the feature you're requesting
I believe this is the custom max armor durability feature listed below but I wanted to add onto it a bit. Basically it's just to add a config that changes the durability of the armor item given. This fixes the problem of leather armor being basically always used but having very low durability. I had this feature added to an older version of AM but that version is now too old so I figure it would be good to have added to the main version. I've attached the source code of the version with the feature working and somewhat bug tested below(older AM version though).
ArmorMechanics.zip
Configuration
Item-Durability: 500

Not sure where to put it but I am willing to pay for this feature. Although ideally please hit me up on discord @Zunker because I almost never check github and might forget to check this, although I will try to remember.


Package memcache to use flag for pages with the new design.

I've opted for the non-optional bool parameter, in order to make sure we get all of the uses both this time and when we are merging them back again.

Couldn't we just have a backend.uiPackageCacheV2 which has the final bool version2; property instead of every caller passing in a boolean?


Direction menu not showing

I am trying to get this to work and it draws the menu outline but puts nothing on it. Here is the link: https://map.drakefletcher2.repl.co/
here is the code:
https://replit.com/@DrakeFletcher2/Map
Am I doing anything wrong?

it looks like you aren't following the instructions in the README.
L.Routing.esri({
  liveTraffic: true,
  profile: 'Driving',
  // you need either a 'url' or 'token' here
})

https://github.com/jgravois/lrm-esri#authentication

Ohh, that makes sense. Thanks!


Merge core time roles to one

Chrony roles are nearly the same between server and client. Merging them like for slurm would simplify the list.

Done in commit https://github.com/oxedions/bluebanquise/commit/14cb9fef2bfca52ed7cbdab6dca701a56793a30e


Display table faster

Speed up time before table is displayed
Current method:

Wait for document to load
Wait 2 seconds
Extract + display

New method:

Wait for one earnings row to appear in DOM
Wait 250ms
Extract + display

Even more advanced would be to keep counting the earnings rows and wait until no more are arriving into the DOM. Could be considered if the 250ms wait turns out to be unreliable.

Great improvement! There are some symbols like recent IPOs (e.g. OSCR) which have no earnings history so there will be an infinite loop here. Need to timeout after 2-3 seconds if no content arrives.

Let me try and fix that.

Like so?

LGTM
Only encountered discrepancy once but it happened before as well. Fixed by reload.


Ionic Beta 7 Bug - Argument of type 'Http' is not assignable to parameter of type 'Http'

With the recent Ionic update to Beta 7, I am getting this error in Terminal on ionic serve:
TypeScript error: app/app.ts(27,79): Error TS2345: Argument of type 'Http' is not assignable to parameter of type 'Http'.
  Property '_backend' is protected but type 'Http' is not a class derived from 'Http'.

useFactory          :   (http: Http) => new TranslateStaticLoader(http, 'assets/i18n', '.json'),

In above line, error is thrown at the first http parameter passed to TranslateStaticLoader

Ionic is now at 2.0.0-beta.25, could be a good time to get up to date.

Beta 7 is the latest release of the Ionic framework (released just a few days ago). It's the Ionic CLI that is currently at 2.0.0-beta.25.

@trentclowater Apologies, you a correct :) too many versions to keep track of, and this weeks upgrade has too often been referred to by Angular's RC1 milestone.

The same problem here for  2.0.0-beta.6

The same problem here for beta7.

Same problem here for beta 7.

Upgrading to<EMAIL_ADDRESS>fixed this issue :-)
Ref: https://forum.ionicframework.com/t/ocombe-ng2-translate-bug-in-ionic-beta-7-argument-of-type-http-is-not-assignable-to-parameter-of-type-http-132/53023

I have same trouble with last version of ngx-translate ^7.0.0 and Angular 4.3.6
Failed to compile.

/data/main/src/app/app.module.ts (116,33): Argument of type 'HttpClient' is not assignable to parameter of type 'Http'.
  Property '_backend' is missing in type 'HttpClient'.

My code:
export function createTranslateLoader(http: HttpClient) {
	return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}

@NgModule({
	...
  	imports: [
		...
		FormsModule,
		TranslateModule.forRoot({
			loader: {
				provide: TranslateLoader,
				useFactory: (createTranslateLoader),
				deps: [HttpClient],
			}
		}),
	],

To: Dok11
I have the same trouble as you have.
I fixed that.
Change package.json :
from
"@ngx-translate/core": "^9.0.1",

to
"@ngx-translate/core": "^8.0.0",

After, deleted node_modules directory and executed npm install


Improving _tool_jira_accounts table filtering

⚠ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[ ] I have read through the Contributing Documentation.
[ ] I have added relevant tests.
[ ] I have added relevant documentation.
[ ] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary
This refactor aims to enhance the efficiency of collecting data from the Jira board by excluding irrelevant accounts from collect process. More info can be found in the #7020
Does this close any open issues?
#7020
Other Information
How to test:

Create a Devlake project connected to a large Jira board.
Run the import process.
For me this project discovered over 350 accounts and saved them in the _tool_jira_accounts table.
Create another Devlake project linked to a smaller Jira board, with a time range set to let's say last week.
Run the import process.
Notice that the smaller Jira board has called the /rest/api/2/userendpoint for accounts only relevant to this smaller board (that can be confirmed using the logs or by checking the updated_at in _tool_jira_accounts table).

Thanks for your contribution.
@narrowizard  Would you like to take a look?

@narrowizard thanks!
This is my first time contributing here.
What's the next step? Will you merge this PR? I don't see the merge option

@sstojak1 I just merged the PR, and it will be available on v1.0.0,  maybe in a month.

Hi @sstojak1 ,
Thank you for your contribution! I'm Joshua Poddoku, a committer at Apache DevLake. We'd love for you to join our Slack community or DM me incase you've joined already: https://join.slack.com/t/devlake-io/shared_invite/zt-18uayb6ut-cHOjiYcBwERQ8VVPZ9cQQw. Could you please share your full name there? We want to recognize your efforts with a certificate of contribution.
Best,
Joshua Poddoku


Temperature Form: Auto complete, copy tweaks etc

Invalid form submissions now re-display properly. Previously if you had entered a temperature but not a location, only the temperature field would be shown after you've submitted the form.
Auto complete now works for places, once you've submitted one set of temperatures, auto complete now works for the places - https://leaverou.github.io/awesomplete/
Aim copy removed
Observation spec changed to use build

👍 fine with it code-wise. Still not sure about the messages overlapping the previous inputs.

I've added a card to Trello so that we can review this and won't forget about it...


Fixed archiveVersion requiring .get() to get the version number.

Since archiveVersion is a Property<String> and not a String it requires a .get() call to get the actual version number. Else it'll use the .toString() function which results in unexpected filenames.
For example: 'lwjgl3\build\libs\GdxJpackage-task ':lwjgl3:jar' property 'archiveVersion'.jar'.

Dang, that's confusing. I was going by the limited docs in the Gradle source, will pull now.


Verify Docker images in runtime folder

There were many recent improvements in runtime deployments.
Would be good to verify Docker images in the runtime folder are up to date.
For example is this remains correct
    FROM python:3.6-slim-jessie,

etc.

@JosepSampe can you please see it? thanks

@gilv Yep, images are correct and aligned with the official one, which was not modified since 8 Oct 2018. Also requirements.txt is updated.


Add Prompt Processing Environment and Prompt Proto Service Application

Add in environment for prompt processing, prompt proto service applications, and associated documentation.  A shared chart application for prompt processing is a subchart for HSC, LATISS, LSSTComCam, LSSTCam.

Thanks!  I had looked at application sets, but didn't want to deviate too much from established patterns for this.


Update CronExpression.php

It seams to consider always "minutes" instead of crontab expression if no time is set when increment or decrement

As mentioned in #170 , this repo is no longer maintained. Please check against the new repo and, if needed, submit a new issue (and PR if needed/can).
https://github.com/dragonmantank/cron-expression

Hi Chris,
ticket reopened in the correct repo.
Bye
--
Luca Tacconi
Cell.: +39<PHONE_NUMBER>
Skype: luca-tacconi
Mail to<EMAIL_ADDRESS>Il giorno gio 5 set 2019 alle ore 21:26 dragonmantank <
<EMAIL_ADDRESS>ha scritto:

As mentioned in #170
https://github.com/mtdowling/cron-expression/issues/170 , this repo is
no longer maintained. Please check against the new repo and, if needed,
submit a new issue (and PR if needed/can).
https://github.com/dragonmantank/cron-expression
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mtdowling/cron-expression/pull/171?email_source=notifications&email_token=ACLWKYVR7JWDAGKZMEL2TZ3QIFMQBA5CNFSM4IUAKW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AOWCQ#issuecomment-528542474,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLWKYVAMAABLD342F2C6WDQIFMQBANCNFSM4IUAKW3Q
.


Inline sourcemaps not appended to file in node.js environment

Source maps appears to be working in the browser but not in node.  It looks to me like the transformation simply ignores the sourceMaps: 'inline' option, as the result does seem to have a sourcemaps object, but it was never appended to the output file.

I was able to get it to work with a dirty hack
This: https://github.com/systemjs/plugin-babel/blob/master/plugin-babel.js#L215
To this:
return output.code + '\n//# sourceMappingURL=data:application/json;base64,' + new Buffer(JSON.stringify(output.map)).toString('base64');
I assume to get a real non-hack solution to this problem that someone with deeper understanding of this project would need to figure out why the built systemjs-babel-node.js is not tacking on the sourcemap on its own despite sourceMaps: 'inline'.

If someone is kind enough to figure this out, I have provided the example code I used during my investigation:
https://github.com/mavericken/jspm-node-typescript-vscode

Alright, I think I got it actually.  I wrote a pull request for it, but Babel has tons of pull requests, so we may be in for a long wait to get the correct solution.

Nope... I didn't have it.  I personally am ready to settle for the dirty hack I mentioned above, as trying to figure out the right solution is just taking too much time for me.

Thanks for tracking it down - let's follow this feature at the SystemJS issue https://github.com/systemjs/systemjs/issues/1359.


For free/VS MCT subscriptions vcore quota limit of 6 in eastus causes endpoint deployment failure

Describe the bug or the issue that you are facing
Please can we also consider changing the VM type for compute, and I see for a Trial/Free Subscription/Visual Studio MCT Subscriptions, in the region selected 'éastus' a quota limit of 6 vcore applies. As a result all subsequent provisioning for say compute for batch interencing will fail for all using trial subscription. Perhaps would be nice to put a note before deploying endpoints exercise, that there is need to adjust either region, or vm type to suceed.

Code: InferencingClientCreateDeploymentFailed
Message: InferencingClient HttpRequest error, error detail: {"errors":{"VmSize":["Not enough quota available for Standard_DS3_v2 in SubscriptionId fe0c79f9-9d6e-43fc-8d3f-d9e79d40ea49. Current usage/limit: 0/6. Additional needed: 8 Please see troubleshooting guide, available here: [https://aka.ms/oe-tsg#error-outofquota"]}

Thanks a lot!
Steps/Code to Reproduce
For free subscriptions, limit of 6 vcores for the given vm type in eastus region fails due to not enough vcore available to further provision compute for endpoint deployment.
Expected Output
We can perhaps add a note for users to either change region, and vm type upfront at the beginning as per their available quota in the ADO pipelines. I believe up to 20 vcore for many other regions and vm type would suffice.
Versions
ADO
Which platform are you using for deploying your infrastrucutre?
Azure DevOps (ADO)
If you mentioned Others, please mention which platformm are you using?
No response
What are you using for deploying your infrastrucutre?
Bicep
Are you using Azure ML CLI v2 or Azure ML Python SDK v2
Azure ML CLI v2
Describe the example that you are trying to run?
Tabular/Classic

Disussing in #123

Added a note in the documentation and merged the PR https://github.com/Azure/mlops-v2/pull/125


aws-staging-1: enable buildsh tracing

What is the problem that this PR is trying to fix?
Enable tracing on ec2 staging in addition to gce staging.
What approach did you choose and why?
The same as in #524
How can you test this?
Run a job on staging with tracing enabled.
What feedback would you like, if any?
refs https://github.com/travis-ci/reliability/issues/165

Used this to debug the user-data for the ASG:
➜  aws-staging-1 git:(master) aws autoscaling describe-auto-scaling-groups --auto-scaling-group-names=staging-1-workers-org | jq '.AutoScalingGroups[].LaunchConfigurationName'
"staging-1-workers-org-20180903122522398100000003"

➜  aws-staging-1 git:(master) aws autoscaling describe-launch-configurations --launch-configuration-names=staging-1-workers-org-20180903122522398100000003 | jq -r '.LaunchConfigurations[].UserData' | base64 -D | gunzip | less

➜  aws-staging-1 git:(master) echo <base 64 of /etc/default/travis-worker-cloud-init> | base64 -D


README.md references INSTALL.md file that is missing

Hi there! In your README.md under 'Usage' under 1. Install mmdetection, you reference an INSTALL.md file when I click it, it redirects to a 404. Thank you!

I believe the link is meant to go here: https://github.com/open-mmlab/mmdetection/blob/master/docs/install.md


"Gnoll Bounty" (TWoW Quest 60042) Has Been Updated

Issue
Quest 60042 of the Turtle WoW quest database is no longer "Gnoll Bounty" but instead "Culling the Riverpaw".
Its quest text has also been changed.
Reproducing the issue
Prerequisites

The latest version of pfQuest for Vanilla
The latest version of pfQuest-Turtle

Steps to reproduce the issue

Log into Turtle WoW.  Bring a Level 6 character to Eastvale Logging Camp in Elwynn Forest.
There should be a gold exclamation mark for the NPC Terry Palin with one quest.
Talk to the NPC and accept his quest.

Expected results
The quest should be named "Culling the Riverpaw" and the exclamation mark should turn into a gray question mark.
Actual results
Since the database is using the quest's old name, "Gnoll Bounty", and old information, it does not count as accepted nor completed when finished.

I can confirm that this has been fixed as of the most recent DB update.


Run playbooks during kickstart

Feature Request or Enhancement

Feature []
Enhancement [Ability to run all playbooks during kickstart process]

Summary of Request
Would like to be able to run all playbooks during the kickstart process.  This would require kickstarts to detect when they are running in a kickstart process and not attempt to stop/start any services.  Services will still be stop/started during normal operation, just not during kickstart.
Describe Alternatives You've Considered
We don't run most of the playbooks during kickstart.  This is a shame, as systems boot up half-configured and requiring the playbooks to be run ASAP on boot.
Suggested Code
Not sure how to detect when running in kickstart, but once an adequate detection can be made, parts of playbooks which cause trouble during kickstart would have a "when {{ not-kickstart }}" or similar added to their definition block.  This would allow the playbooks to be fully run during kickstart, resulting in a fully configured and locked-down system before firstboot.  All services will be enabled/disabled and configured during kickstart, but no attempt will be made to stop/start the services.

hi @duncaninnes
Thank you for the issue, This is a great question, i know we have community members already incorporating these into kickstart. But as with all things in IT there are many ways to do things.
there are a couple of quick approaches we could investigate but they all have pros and cons.
e.g.
End the play if kickstart before running handlers
This could miss out important handler like updating grub, creating aidedb etc
- name: End the play hosts if kickstart
  ansible.builtin.meta: end_host
  when:
  - kickstart_used

or we could look to adding conditionals to handlers but as mentioned some will want somethings to run others wont.
It maybe a good idea to ask the discord community to see how others are getting around this, we could then get a standard approach for all documented based on the feedback.
discord link - https://lockdownenterprise.com/discord
I hope that helps, please let us know as we are keep to improve and enhance these roles.
many thanks
uk-bolly