Routing broken after reboot because of fixed subnet-mask?

The Subnet-Mask gets set statically to /32, which somehow does not work with re0 interfaces.
https://github.com/depenguin-me/depenguin-builder/blob/383400bae4dbdfe16babec53cfea84ff25f54e0d/customfiles/14_0_INSTALLERCONFIG.sample#L32
I have no explanation why this does not work, but would it be possible to set the correct subnet-mask in the config-file as a work-around?
I attached a screen recording of the first and second boot, in case that helps. Note the add net default: gateway <IP_ADDRESS> fib 0: Invalid argument after the second boot. That looks like a failure to apply the default route set in /etc/rc.conf.
https://github.com/depenguin-me/depenguin-builder/assets/741249/6b9f4fd9-145a-4de0-85cf-6281083bbc70

To be clear: IPv6 works just fine after reboot. Just IPv4 has routing problems until I "fix" the subnetmask

And I just confirmed: The same problem does NOT appear with Intel Drivers (igb/em). Somehow only re-Devices are affected?

Thanks for the diagnosis @Subito , it looks like re devices don't like the static route setup and would require special handling to avoid it. Pondering.

In case it helps, here is the output of service netif restart && service routing restart on the working and broken box:
broken:
# service netif restart && service routing restart
Stopping Network: lo0 untrusted.
lo0: flags=8048<LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
	options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
	groups: lo
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
untrusted: flags=1008802<BROADCAST,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
	options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
	ether a8:a1:59:ed:f2:10
	media: Ethernet autoselect (1000baseT <full-duplex>)
	status: active
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
Starting Network: lo0 untrusted.
lo0: flags=1008049<UP,LOOPBACK,RUNNING,MULTICAST,LOWER_UP> metric 0 mtu 16384
	options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
	inet <IP_ADDRESS> netmask 0xff000000
	inet6 ::1 prefixlen 128
	inet6 fe80::1%lo0 prefixlen 64 scopeid 0x2
	groups: lo
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
untrusted: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
	ether a8:a1:59:ed:f2:10
	inet <IP_ADDRESS> netmask 0xffffffff broadcast <IP_ADDRESS>
	inet6 fe80::aaa1:59ff:feed:f210%untrusted prefixlen 64 scopeid 0x1
	inet6 2a01:4f8:161:53a9::2 prefixlen 64
	media: Ethernet autoselect (none)
	status: no carrier
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
delete host <IP_ADDRESS>: gateway lo0 fib 0: gateway uses the same route
delete host <IP_ADDRESS>: gateway untrusted fib 0: not in table
delete net default: gateway <IP_ADDRESS> fib 0: not in table
delete host ::1: gateway lo0 fib 0: gateway uses the same route
delete net fe80::: gateway ::1
delete net ff02::: gateway ::1
delete net ::ffff:<IP_ADDRESS>: gateway ::1
delete net ::<IP_ADDRESS>: gateway ::1
delete net default: gateway fe80::1%untrusted
add host <IP_ADDRESS>: gateway lo0 fib 0: route already in table
add host <IP_ADDRESS>: gateway untrusted
add net default: gateway <IP_ADDRESS> fib 0: Invalid argument
add host ::1: gateway lo0 fib 0: route already in table
add net fe80::: gateway ::1
add net ff02::: gateway ::1
add net ::ffff:<IP_ADDRESS>: gateway ::1
add net ::<IP_ADDRESS>: gateway ::1
add net default: gateway fe80::1%untrusted

note the add net default: gateway <IP_ADDRESS> fib 0: Invalid argument
working:
# service netif restart && service routing restart
Stopping Network: lo0 untrusted.
lo0: flags=8048<LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
	options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
	groups: lo
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
untrusted: flags=1008c02<BROADCAST,DRV_OACTIVE,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500
	options=4e527bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_MAGIC,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6,HWSTATS,MEXTPG>
	ether 7c:10:c9:1f:a0:fe
	media: Ethernet autoselect (1000baseT <full-duplex>)
	status: active
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
Starting Network: lo0 untrusted.
lo0: flags=1008049<UP,LOOPBACK,RUNNING,MULTICAST,LOWER_UP> metric 0 mtu 16384
	options=680003<RXCSUM,TXCSUM,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>
	inet <IP_ADDRESS> netmask 0xff000000
	inet6 ::1 prefixlen 128
	inet6 fe80::1%lo0 prefixlen 64 scopeid 0x2
	groups: lo
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
untrusted: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=4e527bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_MAGIC,VLAN_HWFILTER,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6,HWSTATS,MEXTPG>
	ether 7c:10:c9:1f:a0:fe
	inet <IP_ADDRESS> netmask 0xffffffff broadcast <IP_ADDRESS>
	inet6 fe80::7e10:c9ff:fe1f:a0fe%untrusted prefixlen 64 scopeid 0x1
	inet6 2a01:4f8:222:20a3::2 prefixlen 64
	media: Ethernet autoselect
	status: no carrier
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
delete host <IP_ADDRESS>: gateway lo0 fib 0: gateway uses the same route
delete host <IP_ADDRESS>: gateway untrusted fib 0: not in table
delete net default: gateway <IP_ADDRESS> fib 0: not in table
delete host ::1: gateway lo0 fib 0: gateway uses the same route
delete net fe80::: gateway ::1
delete net ff02::: gateway ::1
delete net ::ffff:<IP_ADDRESS>: gateway ::1
delete net ::<IP_ADDRESS>: gateway ::1
delete net default: gateway fe80::1%untrusted
add host <IP_ADDRESS>: gateway lo0 fib 0: route already in table
add host <IP_ADDRESS>: gateway untrusted
add net default: gateway <IP_ADDRESS>
add host ::1: gateway lo0 fib 0: route already in table
add net fe80::: gateway ::1
add net ff02::: gateway ::1
add net ::ffff:<IP_ADDRESS>: gateway ::1
add net ::<IP_ADDRESS>: gateway ::1
add net default: gateway fe80::1%untrusted

Interestingly I don't have any problems adding the missing default-route by hand. route add default just works as usual.

@Subito I had much better results when using the realtek driver from ports (re0 actually refers to a long list of devices), see https://github.com/depenguin-me/depenguin-run/issues/79

Interesting. Maybe we should add this to customfiles/14_0_INSTALLERCONFIG.sample in the firstboot-script surrounded by a bit of hardware-detection? I'm using the depenguin_bsdinstall.sh so I can't intervene in the process itself.
For now its good enough for me to SSH into the v6-IP (which works just fine) and fix the subnet-mask, so v4 works. Usually if I get one of these Realtek-Cards I order an additional Intel-card from hetzner because we had a lot of problems with re in the past. So for me its just a slight inconvenience on provisioning the boxes.

Sorry @Subito , I goofed in haste. Should have tagged @grembo , or checked the recent issues, before going ahead with the update.
Happy to test a PR with re autodetection and driver install.

wonder if this would do the trick before the firstboot setup?
realtek_detect=$(pciconf -lv | grep -B3 'vendor=0x10ec')

if [ -n "$realtek_detect" ]; then
    pkg install -y realtek-re-kmod198
    sysrc -f /boot/loader.conf if_re_load="YES"
    sysrc -f /boot/loader.conf if_re_name="/boot/modules/if_re.ko"
    sysrc -f /boot/loader.conf hw.re.max_rx_mbuf_sz="2048"
fi

@bretton why -B3?
AFAIK not all realtek devices are better off using realtek-re-kmod198, so we have to be a bit more specific (I use an older realtek device with the standard kernel driver just fine - but I think it might be ok to ignore those). Also, not all realtek devices are actually network cards.
What about:
if_re_count=$(pciconf -l | grep class=0x020000 | grep vendor=0x10ec | wc -l | xargs)
if [ "$if_re_count" -gt 0 ]; then
  ...
fi

@bretton why -B3?

blind copy-paste of command, should be -A3 to be useful.
Agree it should be more specific, thanks.

Great work, thanks! Can you confirm that the routing works as expected with the driver from ports? „Unfortunately“ all the boxes I deployed in the past week had igb-adapters, so I was unable to test myself.

@Subito I can confirm networking is working on a newly installed ex44 with realtek card:
bretton@depenguin:~ $ ping -4 google.com
PING google.com (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=60 time=7.644 ms
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=60 time=7.580 ms
^C
--- google.com ping statistics ---
2 packets transmitted, 2 packets received, 0.0% packet loss
round-trip min/avg/max/stddev = 7.580/7.612/7.644/0.032 ms


STAGING - Biometrics doesn't work when you only have face recognition.

Used to be that I could either use face recognition or fingerprint.
On my phone I have face recognition unlock but no fingerprint.
Under settings I can enable fingerprint to log in, but it doesn't do anything as my phone doesn't have fingerprint.
Used to be that it'd dynamically detect what your phone does or doesn't have, and provide that option.

Flutter regression error due new and old plugins requiring difference flutter dependencies. (aka: dependency hell)
Updated everything as far as I could without breaking other features.
Fixed.


Add from_save kwarg to update() from save() in mongoengine to mongoproxy

Because of how mongo does updates with no operator (replaces the document completely) and dataman doesn't support that yet, we'll need to special case the update() in save() to say it's from save, to allow this kind of update.

Does that only apply to the json fields?
I can't seem to get that to work for non-json fields. Say I have a record {'username' : 'asdf', 'firstname' : 'fdsa', 'lastname' : 'llll'}. A mongo update like  filter={'username' : 'asdf'}, record={'firstname' : 'asdf'} would set the record to {'username' : 'asdf','firstname' : 'asdf'} (updating the firstname field, getting rid of the lastname field)


Retiring support for Windows Server Service Bus

With WSSB been deprovisioned, SBE doesn't have to support it anymore.
Current code has to cater for both, on premises SB 1.1 and ASB. This makes code unnecessary complex.
Suggest the following:

Create a support branch to ensure bugs related to SB 1.12 are addressed
master to support ASB only and tag it as a new major (@paolosalvatori I know you want to keep the major version aligned with the WindowsAzure.ServiceBus client, but it doesn't have to be. This client will be replace by another one and versioning of this tool should be independent).

Any suggestions/ideas are welcomed.

@SeanFeldman, let's have a call in a few weeks, so we can make a plan. The next few weeks I'll be onm customer site

Good question. What is it? 😃
I've outlined the proposal in the issue description. Perhaps we should do it in async mode as it's almost impossible to get on a call.

I've created support branch support-2.1 so that SBE 2.1 can live independently and be updated if needed.
Quoting from the issue description:

master to support ASB only and tag it as a new major

@SeanFeldman I read the original post, but I don't get it. Which client library would you like to use?

@paolosalvatori what client library to use is not a question here. For now we'll continue with the same client used for the last X year. I was mentioning your desire to keep the tool version in sync with the client version. The argument for that is probably becoming even weaker, considering that there's no planned v5 of the ASB client ( WindowsAzure.ServiceBus) since it will be in maintenance mode only.
As for the original post, the focus is on removing support for anything that is not the core functionality of the tool and releasing that as v5.

What do you mean with "anything is not the core functionality of the tool"? Notification Hubs? IoT Hubs? I have users that ping me offline as they use the tool with minor, not mainstream features like relays and notification hubs... I don't see the need the remove this support. I'd prefer to add rather than remove features :)

Personally, I'd carve those out into dedicated tool. But that's not the point.
Let's focus on what this issue is for - removing suport for WSSB in the next major (5.0).

Agreed, let's focus on removing support for WSSB in the next major release. :)
P.S. Microsoft Azure Storage Explorer tool also supports Cosmos Db, even if the latter is a separate service with respect to Azure Storage Services :)

I think this is not related to Service Bus for Windows Server as Azure Stack is in parity with Azure in general so we do not need to do anything there from what I know.

I'm also under the same impression that Azure Stack services are the same cloud serivces just provisioned locally. Therefore there should be no difference between ASB and ASB on Azure Stack in terms of invoking ASB client.

Yes, Service Bus in Azure Stack has nothing to do with Service Bus for Windows Server but it will share the same architecture of Service Bus on Azure.

@paolosalvatori do you know if this one is OK to be closed under 5.0.0?

@SeanFeldman I think we can close this issue. @SeanFeldman @ErikMogensen feel free to close it.

5.0.0 milestone applied, closing

Service Bus on Windows Server is still supported together with SharePoint 2013, 2016, 2019 until their end of lifecycle as they use Workflow Manager which uses Service Bus on Windows Server. Using Service Bus Explorer is great tool for troubleshooting as well so would be great if multi-support can still be maintained or at least if there is already compiled older version to download at least that works quickly. Right now what I could find, there is older VS 2012 SBE solution that has no compiled version. If there is a need to quickly troubleshoot having to find and install VS 2012 and the dependencies, compile etc it takes a lot of time.

@NiklasEMS no worries, there's a dedicated version of SBE for Service Bus on Windows Server. There should be a link on the main page for it. The main codebase stopped supporting Service Bus on Windows Server due to some breaking changes introduced by SDK client library.


Enable automated builds in LaTeX renderer

Currently, there are no GitHub Actions defined for this repository. Since we have Unit tests, this would be beneficial to the code quality.

Also consider solving #2


add Microsoft Clarity Analytics

Clarity is a free tool that captures how people use your site.

Thanks for the contribution, LGTM! Could you also create and push a minor changeset for this new feature?


[#2983] add package/class based matcher.

#2983

Codecov Report

Merging #3009 into master will increase coverage by 0.23%.
The diff coverage is 50.33%.

@@            Coverage Diff             @@
##           master    #3009      +/-   ##
==========================================
+ Coverage   37.94%   38.17%   +0.23%
==========================================
  Files        1894     1917      +23
  Lines       63800    64657     +857
  Branches     8880     9037     +157
==========================================
+ Hits        24211    24686     +475
- Misses      37111    37436     +325
- Partials     2478     2535      +57

Impacted Files
Coverage Δ

...ercorp/pinpoint/profiler/util/JavaAssistUtils.java
71.51% <ø> (ø)
:arrow_up:

...va/com/navercorp/pinpoint/common/util/Asserts.java
0% <ø> (ø)
:arrow_up:

...rofiler/DefaultClassFileTransformerDispatcher.java
0% <0%> (-59.33%)
:arrow_down:

...m/navercorp/pinpoint/plugin/vertx/VertxPlugin.java
0% <0%> (ø)
:arrow_up:

...inpoint/bootstrap/instrument/matcher/Matchers.java
9.52% <0%> (-8.66%)
:arrow_down:

...p/pinpoint/profiler/plugin/DefaultPluginSetup.java
10.81% <0%> (-1.69%)
:arrow_down:

...orp/pinpoint/profiler/UnmodifiableClassFilter.java
62.5% <0%> (-20.84%)
:arrow_down:

...rument/transformer/MatchableTransformTemplate.java
0% <0%> (ø)

...nt/profiler/instrument/GuardInstrumentContext.java
0% <0%> (ø)
:arrow_up:

...strument/transformer/DebugTransformerRegistry.java
58.62% <100%> (+3.06%)
:arrow_up:

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f146fc...991cdbf. Read the comment docs.


Remove #[inline(always)]

Since I absolutely love clippy, I also wanted to run it on my embedded experiments but essentially failed to do so because I ran into tons of:
error: you have declared `#[inline(always)]` on `bit`. This is usually a bad idea

warnings and so I decided to look into whether that provides any benefit to the generated code at all and surprise it does not provide any benefit at all:
When compiling in release mode (with lto on) the only difference is that main is not inlined into reset_handler which is actually a positive since it makes debugging a whole lot easier if you have a trivially named main function you can put your breakpoint on.
In debug mode it has a slightly larger impact of around 20% but that seems to be mostly coming other skipped inlining opportunities rather any of the functions marked als always inline not being inline anymore which can probably offset by adjusting the inlining target, if necessary.
But most importantly to me, this allows me to run clippy just fine:
warning: equality checks against true are unnecessary
  --> examples/flash_systick_hsi48.rs:30:16
   |
30 |             if rcc.cr2.read().hsi48rdy().bit() == true {
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `rcc.cr2.read().hsi48rdy().bit()`
   |
   = note: #[warn(bool_comparison)] on by default
   = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#bool_comparison

Woohoo!

I'd rather have a guarantee that compiler will always optimize bit access. Maybe there is some way to disable this diagnostic in clippy?

Well, I was looking for a way but it seems that can only be done by config gating in the source (== Meh) or when integrating clippy into the crate itself (== Double Meh); part of the beauty of clippy is that one can simply run "[c|x]argo clippy" and receive some interesting insight into the code, sometimes even with nice optimisation suggestions, without any non-trivial setup...
The guarantee that you're mentioning does not exist anyways, it's just a compiler hint so the compiler might decide to ignore it anyway. And as you might know: premature optimisation is the root of all evil...

@therealprof

essentially failed to do so because I ran into tons of:

Is that from running clippy on the device crate or on a crate that depends on the device crate? If the later, why is clippy analyzing a dependency? That seems odd.

main is not inlined into reset_handler which is actually a positive since it makes debugging a whole lot easier if you have a trivially named main function you can put your breakpoint on.

Just want to point out that the unmangled "main" symbol is not your program main but a rustc generated stub with no source code information. That stub will eventually call your program main (I think it may go through the start lang item first) but you still have to step through some assembly before you get there.

In debug mode it has a slightly larger impact of around 20%

Which way is that? Removing #[inline(always)] makes the program smaller by 20%? Or does it make it larger?
@pftbest

I'd rather have a guarantee that compiler will always optimize bit access

Having a Cargo feature for optimizing dependencies even when compiling with just cargo build (cf. https://github.com/rust-lang/rust-roadmap/issues/1#issuecomment-313872359) would help with that ... a bit. Even with this feature generic functions (device crates have a bunch of these because the API uses closures) won't get properly optimized because of how the compiler works: generic functions in libraries are converted into metadata so they don't get optimized until the last moment, i.e. when compiling the "top" crate, so they are directly affected by the compilation profile (dev vs release)

I don't recall if #[inline(always)] made this worse but compiling device crates without optimization sometimes generates so much code that the program no longer fits in the device Flash memory, i.e. sometimes your program .text+.rodata is larger than 64KB. When that happens I change the dev profile optimization level to 1; that fixes the binary size problem but makes the program undebuggable: you can't print stack variables because they have been "optimized away" (I don't recall the exact phrasing the debugger uses).
Just pointing out that unoptimized register access when using cargo build is a real problem that bloats binary size and affects the debugging experience. A proper fix may require some sort of optimization hinting in rustc. I think some of the ideas in #115 may help here as well. And if removing #[inline(always)] helps with the binary size problem then I'd be happy to remove it.

Is that from running clippy on the device crate or on a crate that depends on the device crate? If the later, why is clippy analyzing a dependency? That seems odd.

I'm compiling examples in the device crate.

Which way is that? Removing #[inline(always)] makes the program smaller by 20%? Or does it make it larger?

It makes the debugging info larger by about 20%, mostly due to more included detail. I didn't note any changes to the executed code at all.

And if removing #[inline(always)] helps with the binary size problem then I'd be happy to remove it.

No, unfortunately it does not, but it also doesn't make it worse. However the amount of debug info created by rustc is absolutely horrific. I've had cases where applications even failed to compile in dev mode because:
... relocation truncated to fit: R_ARM_THM_JUMP11 against `DEFAULT_HANDLER'

There're only two options to tackle this in my opinion:

Improve the rust compiler to stop this nonsense
Ensure that generated rust files (like the ones produces by svd2rust) are as lean as possible

So I was just revisiting this again and did a more thorough test of the 3 different options:

[#inline(always)]
[#inline]
without explicit inline, as suggested before

I was specifically looking at generated code size and size of auxiliary files, and here are the results in order for debug:
35540	target.inline_always/thumbv6m-none-eabi/debug/deps
17452	target.inline_always/thumbv6m-none-eabi/debug/examples
34908	target.inline/thumbv6m-none-eabi/debug/deps
16384	target.inline/thumbv6m-none-eabi/debug/examples
43492	target/thumbv6m-none-eabi/debug/deps
54548	target/thumbv6m-none-eabi/debug/examples

32656	target.inline_always/thumbv6m-none-eabi/release/deps
1848	target.inline_always/thumbv6m-none-eabi/release/examples
31988	target.inline/thumbv6m-none-eabi/release/deps
1848	target.inline/thumbv6m-none-eabi/release/examples
41968	target/thumbv6m-none-eabi/release/deps
1856	target/thumbv6m-none-eabi/release/examples

So in a nutshell, [#inline] creates identical release binaries to [#inline(always)] and slightly better than without while still retaining the ability to run clippy without stunts.
For debug [#inline] creates the smallest binaries and the least metadata (it also compiles way faster than without inlining.

Funny, someone else(tm) had the same idea for std recently: https://github.com/rust-lang/rust/pull/43367 ;)

Done in #141


[Bug Report] Checkbox can't be disabled in the table.

Element UI version
1.3.3
OS/Browsers version
google
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/v9L9f3ks/
Steps to reproduce
Is there any way to make a part of checkbox to be disabled in table?
What is Expected?
Make some of checkbox to be disabled in table.
What is actually happening?
Checkbox can't be disabled in the table.

Solved this problem. There is a selectable attribute in table component.

Solved this problem. There is a selectable attribute in table component.

Hi, @DoryDuan
Did you find any example of how it can be implemented?


Fix errors introduced in 96ad601

https://deploy.blue.production.govuk.digital/job/run-rake-task/65917/console
https://deploy.blue.production.govuk.digital/job/run-rake-task/65916/console

I introduced a new linting error 😱


test: Lighthouse Check custom action

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@78a9b0a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   35.47%
=========================================
  Files             ?       18
  Lines             ?      327
  Branches          ?       93
=========================================
  Hits              ?      116
  Misses            ?      149
  Partials          ?       62

Impacted Files
Coverage Δ

src/helpers/getLighthouseAuditTitlesByKey.js
100.00% <0.00%> (ø)

src/triggerLighthouse.js
96.36% <0.00%> (ø)

src/lighthouseConfig.js
100.00% <0.00%> (ø)

src/helpers/getLighthouseScoreColor.js
0.00% <0.00%> (ø)

src/fetch.js
50.00% <0.00%> (ø)

src/slackNotify.js
0.00% <0.00%> (ø)

src/localLighthouse.js
8.33% <0.00%> (ø)

src/fetchLighthouseAudits.js
0.00% <0.00%> (ø)

src/fetchAndWaitForLighthouseAudits.js
0.00% <0.00%> (ø)

src/LighthouseCheckError.js
100.00% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a9b0a...8645f3c. Read the comment docs.


Add support for Teradata

Hello guys!
First of all, let me thank you for this incredible package you've achieved. I find myself with this recurrent problem of trying to compare two "mirror tables" or tables that are being migrated.
I was going to ask you if you've considered including Teradata to the supported engines.
Do you need help with it? I'm not a professional coder, but it would be great to contribute in this project.
Greetings from Argentina!

Thank you @glebmezh for your tough work.
I would love to make my first contribution to an open source project, so I'll fork the main branch to build a Teradata adapter!

Hi @aribosa did you advance in the topic? We would also be interested in using it, or build it ourselves.


Minimum step

There should be an additional "Minimum step" field that sets a lower bound for the auto interval/step.
Depending on timestamp precision, it can be necessary to specify a minimum step - there's no point in doing per-second aggregates when the precision of the underlying data is a multiple of that.

Hi @leoluk
It sounds reasonable for performance. But situations when user browsing so short periods so that interval becomes too low (seconds) are pretty rare. And even if these situations are happening - it would be easy for CH to process so short periods. Or I missed something?

HI some news about this?

Closed due to lack of activity

Let's say my interval is 15s,  it cannot specify a minimum step, there will be lots of null values. Could you support the feature?

I think we need an options same as this https://github.com/grafana/grafana/pull/8073

@hagen1778, any updates on this?


Add reference documentation for webhooks

Signed-off-by: Andy Doan<EMAIL_ADDRESS>

@munoz0raul - not sure I did the shell script stuff the right way. I think there's a new/improved way you came up with?

Docs for 5c16c7d4ed1d0e6e810adc48b2b3b9287d9e5316 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/996/docs/artifacts/html/index.html

squash push

Docs for bafedd47cc2ea662c1c7c15725d36ef99401a421 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/997/docs/artifacts/html/index.html


Fixed #33871 -- Fix bug value cannot be detected after form validation fails

Fixed Ticket #33871

Changes

After form validation check fails, set form's data as initial data
Added set_initial_data function in BaseForm
Added unit test for set_intial_data

Description
It is better to initialize entered data(input) than not to be able to detect and save the changes after invalidation of form.
But it seems to hurt ux a little.

@na86421 You need to be patient, we will review it the coming days (weeks at worst).

Thank you for reply.
I'm new to django contributions, but I haven't read the documentation thoroughly.
Thanks to I have a good understanding of the culture and background :)

Closing in favor of #16229.


Add [TennyHole] #wallet GBDSFC…GOTECR

Address: GBDSFCOGYXHHMZOUOWFVW4BXWVPUS5TKGLF24C422XU5NNLF4CGOTECR
Tags: wallet
Title: TennyHole
Requested by @koly4ij

Hello @koly4ij,
I not sure what you are reporting or requesting. It sounds like you are asking for a personal wallet to be labelled on our stellar.expert database but with over 7 million wallets on the Stellar blockchain we are not actually able to do that. I am sure you understand.
Looking Towards The Future With You,
Rob TheCryptoHobbyist

Hello @koly4ij,
If you have any updated information or need to reopen this issue for any reason please feel free to do so.
Looking Towards The Future With You,
Rob TheCryptoHobbyist


MRG, DOC: revise tutorial: overview of Epoching

@neurolaunch do you have time to review this pull request?  @larsoner suggested that it might be a good way to get your feet wet in the MNE-Python review process. You can ping me on email/slack for guidance or to set up an in-person time to discuss.

Hi Dan,
I’ll definitely take a look at the request but will need to do a proper
"developer" clone of the repo first. (I don’t have an on-site computer set
up yet (or even a desk), but for now I'll use my Mac notebook.)  I think
it’s probably best to meet in person whenever you’re available.
I'm not setup on the Slack channel yet but will ask Erica.
Best,
Steve
On Wed, Nov 13, 2019 at 2:36 PM Daniel McCloy<EMAIL_ADDRESS>wrote:

@NeuroLaunch https://github.com/NeuroLaunch do you have time to review
this pull request? @larsoner https://github.com/larsoner suggested that
it might be a good way to get your feet wet in the MNE-Python review
process. You can ping me on email/slack for guidance or to set up an
in-person time to discuss.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/7011?email_source=notifications&email_token=AJWJWA2TM2WI6V4Q7REHTKDQTR6P5A5CNFSM4JIB2NL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED75F4Y#issuecomment-553636595,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJWJWA2IRMA6OQDYCCZYZO3QTR6P5ANCNFSM4JIB2NLQ
.

@larsoner @agramfort I've addressed @NeuroLaunch's feedback; ready for review/merge.

here's the rendering: https://16928-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/epochs/plot_10_epochs_overview.html

Thanks @drammock

This is causing a failure in master, probably because of this:

I'll see if I can cut it down

hah, you beat me to it. it was next on my list.

this is nice!
the only suggestion I have would be to include a link on how to work with metadata. the output mentions there is none, but there is no explanation on what it is, or how to use it.

@SophieHerbst good point. There is another tutorial that covers epochs metadata, which will be revised soon; I'll circle back at that point and add a brief explanation and a cross-reference to that other tutorial.

sounds good!


TSCBasic: alter environment handling for Windows

Rather than using the unicode environment, which should be preferred,
use the ANSI environment operations.  This is important to do here as
the reading of the environment relies on Foundation, which in turn
relies on CoreFoundation for _CFEnviron which returns the ANSI
environment.  As a result, we need to ensure that we use the ANSI
environment variables through out as the C runtime will maintain the two
environments in parallel and may go out of sync.
This will enable additional tests in Swift Package Manager to pass on
Windows, but should really be addressed by changing Foundation to use
the Unicode environment variables and then using that once more here.

@swift-ci please test

the C runtime will maintain the two environments in parallel and may go out of sync.

😱

@compnerd is there a unit test we can add here?

Likely; however, it would be of little value - t-s-c tests don't run on windows yet.  This actually was something that was caught through the SPM test suite.


Automated Package Upgrade

:tada: This PR is included in version 28.5.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ubuntu PPA version of podman has broken dependencies

/kind bug
Description
Installing podman from PPA, now leads to this dependency chain:
The following additional packages will be installed:
  containers-common cri-o-1.12 cri-o-runc skopeo-containers
The following NEW packages will be installed:
  containers-common cri-o-1.12 cri-o-runc podman skopeo-containers
0 upgraded, 5 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/15.8 MB of archives.
After this operation, 71.4 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Selecting previously unselected package containers-common.
(Reading database ... 538617 files and directories currently installed.)
Preparing to unpack .../containers-common_0.1.36-1~dev~ubuntu16.04.2~ppa1_amd64.deb ...
Unpacking containers-common (0.1.36-1~dev~ubuntu16.04.2~ppa1) ...
Selecting previously unselected package cri-o-runc.
Preparing to unpack .../cri-o-runc_1.0.0-rc5-1~ubuntu16.04.2~ppa69_amd64.deb ...
Unpacking cri-o-runc (1.0.0-rc5-1~ubuntu16.04.2~ppa69) ...
Preparing to unpack .../skopeo-containers_0.1.35-1~dev~ubuntu16.04.2~ppa2_amd64.deb ...
Unpacking skopeo-containers (0.1.35-1~dev~ubuntu16.04.2~ppa2) ...
dpkg: error processing archive /var/cache/apt/archives/skopeo-containers_0.1.35-1~dev~ubuntu16.04.2~ppa2_amd64.deb (--unpack):
 trying to overwrite '/etc/containers/registries.d/default.yaml', which is also in package containers-common 0.1.36-1~dev~ubuntu16.04.2~ppa1
Selecting previously unselected package cri-o-1.12.
Preparing to unpack .../cri-o-1.12_1.12.9-1~dev~ubuntu16.04.2~ppa1_amd64.deb ...
Unpacking cri-o-1.12 (1.12.9-1~dev~ubuntu16.04.2~ppa1) ...
Selecting previously unselected package podman.
Preparing to unpack .../podman_1.0.1-1~ubuntu16.04.2~ppa14_amd64.deb ...
Unpacking podman (1.0.1-1~ubuntu16.04.2~ppa14) ...
Processing triggers for man-db (2.7.5-1) ...
Errors were encountered while processing:
 /var/cache/apt/archives/skopeo-containers_0.1.35-1~dev~ubuntu16.04.2~ppa2_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

https://launchpad.net/~projectatomic/+archive/ubuntu/ppa

It still has the side-effect of downgrading kubernetes, due to the cri-o dependency.
i.e. podman requires crio-o 1.12 which in turn requires kubernetes 1.12 (see matrix)
The best solution to this would be to make podman independent of crio (and runc?)
i..e make podman-specific packaging of those, rather than piggy-backing on CRI-O

@LSM5 PTAL

ubuntu issues tracked at https://github.com/containers/libpod/issues/2116


First day missing with non-english locale

I've run into a problem while implementing your calendar control in a project that must support custom calendar locales. If the first day of the month is a saturday it doesn't show up on the horizontal calendar when using a custom locale (like "pt_PT") instead of the default english one ("en_US_POSIX"). The two screenshots that follow were taken from your example project:
If the english locale is used, it all works as expected:
[[_calendarManager.dateHelper calendar] setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]];

However, if we switch it to the Portuguese locale:
[[_calendarManager.dateHelper calendar] setLocale:[NSLocale localeWithLocaleIdentifier:@"pt_PT"]];

Duplicate with #172 and fixed.


feat: support signing action with a Safe (without tx)

@ChaituVR this has been added already right? Closing for now, feel free to reopen if this is still needed


Look into Flatcar updates + CAPI

CAPI is built around immutable infrastructure concepts. The native Flatcar updates may not play well with the default CAPI behavior (because for example a CAPI may flag a rebooting Flatcar node as unhealthy and replace the underlying VM unnecessarily).
We may want to see if there is a way to leverage the advantages of native Flatcar updates in the context of CAPI.

+1 from my side, if Flatcar can be fully integrated w/ Cluster API, the management cluster should be able to detect if the node is running flatcar, and potentially do in place upgrades in some ways, including for kubeadm

Relevant discussion: https://kubernetes.slack.com/archives/C03GQ8B5XNJ/p1684243738471749

Given that the Flatcar+CAPI story is currently blocked by https://github.com/kubernetes-sigs/cluster-api/issues/5294, I wonder if we should move this to backlog for now.

The technical work isn't really blocked - I see most work in the update operators and that does not depend on CAPI changes:

We can create a new update operator for systemd-sysupdate for controlling updates of the K8s binaries. It should not live reload but leave this to the reboot. Settings could be CRDs to enable/disable auto-updating. Since we don't want two reboot coordinators it would leave the draining/reboot to either kured (touch flag file) or FLUO (D-Bus call?). Optionally one should be able to force a specific version (systemd-sysupdate update VERSION but that's currently a bit broken upstream).
We can extend FLUO where needed - currently one has to deploy FLUO manually and make sure the right update settings are set on the node (https://github.com/flatcar/flatcar-linux-update-operator/#requirements). Then auto-updates are on with reboot coordination. To pause reboots a node label can be set but the update will still be staged. It would be nicer if FLUO could be "preinstalled" by CAPI. FLUO should change the node settings to expect what it needs (mask and unmask of units, no SERVER=disabled in the update conf etc.). Instead of only controlling the reboot, one should be able to also disable/enable auto-updates for a node. Ideally, a CRD scheme would be supported instead of node labels. Optionally one should be able to force a specific version (flatcar-update -V VERSION).

Starting from a new operator makes sense to me, we can always upstream changes to the kubeadm provider later (like we did in the past).


Respect paddings and border in shadow input view

Summary
Fixes #28012
After adding some symbols to the input view with paddings, UI renders these symbols on the new line, but returned contentSize from onContentSizeChange callback gives a box a bit wider but with the same height. Only after adding some more symbols returned height would be changed.
Now it respects set paddings and border width.

Changelog

[iOS] [Fixed] - Fix for height calculation for input view
Test Plan

This is how control works before made changes:

And this is after:

This is a sample code that could help reproduce the issue. It would just print contentSize without any changes to height of the input view.
const onContentSizeChange = (e) => {
    const { contentSize } = e.nativeEvent;
    console.log("contentSize: ", contentSize);
};
const onChangeText = (text) => {
    setText(text);
};
const renderInput = (props) => (
        <TextInput
            value={text}
            placeholder="Your text"
            multiline={true}
            onContentSizeChange={onContentSizeChange}
            onChangeText={onChangeText}
            style={[
                {
                    minHeight: 44,
                    maxHeight: 84,
                    flex: 1,
                    borderRadius: 22,
                    borderColor: 'gray',
                    borderWidth: 1,
                    paddingTop: 12,
                    paddingLeft: 16,
                    paddingRight: 16,
                    paddingBottom: 12,
                    lineHeight: 20,
                    fontSize: 16,
                    marginRight: 16,
                    marginLeft: 16,
                    marginTop: 16,
                    marginBottom: 16,
                    backgroundColor: 'white',
                }
            ]}
        />
);

Hi @Gray-Wind, can you confirm this fixes the issue addressed in this comment? https://github.com/facebook/react-native/issues/28012#issuecomment-831804194


Get-VSTeamWorkItem not working but Show-VSTeamWorkItem works for particular ID's.

Steps to reproduce
Get-VSTeamWorkItem -ProjectName myProject -Id 7
Expected behavior
I expected it to return a work item (Work item with Id #7)
Actual behavior
Page not found. However, calling Show-VSTeamWorkItem -ProjectName myProject -Id 7 works
and correctly displays the item in the web browser
Environment data

> Get-VSTeamAPIVersion
Name                           Value
----                           -----
ServiceFabricEndpoint
Build                          3.0
ExtensionsManagement           3.0-preview
Release                        3.0-preview
Version                        TFS2017
MemberEntitlementManagement
Packaging
Tfvc                           3.0
Git                            3.0
Core                           3.0
DistributedTask                3.0-preview

We are running TFS 2017 Update 3

> $PSVersionTable
PSVersion                      5.1.17134.407
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.407
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Added screenshot of running the command with -Verbose

Looking into it now.

I was able to duplicate and I see how to get it to work. I am testing fix against 2018 and Azure DevOps (AzD)

      Donovan, I was able to figure it out this morning, thank you. I had a quick question, using the VSTeam module, is it possible to get each git repository in TFS, and then verify that the master branch for those repositories have the branch protection policy option/setting ‘Cannot delete master’ set?

We wanted to iterate through all of our git repos in TFS and make sure this option is set. (There are many of them, so doing this manually would take up a lot of time)

You can get all the repos. You would then have to use Invoke-VSTeamRequest to call the API to check for the policy because as of now it is not wrapped.

Fixed in PR #124


Preview position of mouse

I love the way voxelshop is designed, pretty standard. But i think you should add a preview of the 3d postion of the mouse while in working grid, cause it only shows when drawing with selection.

I'm actually not sure what you mean. There is a preview when you are hovering the mouse?

If it is the 3D voxel position, the feature is in the develop branch. So will be released next time.

Oh! Yes, please try the java installer. That is also the recommended way for using VoxelShop!

What did you mean by java installer i downloaded it from the website

Please use the Java installer or wait until we update the native installer.
This has been implemented here: https://github.com/simlu/voxelshop/issues/28

Ohhhh you mean the jar installer?

At the bottom here it says "For All OS", that's the one!
https://blackflux.com/node/11


Update to Zivid SDK 2.2.0

PR to update samples to Zivid 2.2.0.
Before this can be merged to master:

[x] Update setup.sh scripts in continuous-integration folder.

Updated all setup scripts, ready to be merged Monday morning!


dcos_installer: fix logs download

High Level Description
Fix a bug where logs would be unavailable to download from installer UI.
Related Issues

DCOS-14750

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

manually tested the installer 👍

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee


Elmish example

It would be lovely to have a elmish example of this.

What do you mean by Elmish?
This is a static website generator not something to write a SPA application.

maybe I wrongly believed that any react app even static-served could use the elmish pattern?

Well what you described is called in general Server Side Rendering.
You can read more about it here, so yes this is doable.
But this is outside of the scope of this project for me.


write your first app error in docs

This page here
https://codelabs.developers.google.com/codelabs/first-flutter-app-pt1/#3
Fails to mention that you also need to delete the const keyword in the body section.  Otherwise it will not build.
body: Center(                                // delete const on this line should be noted.
          //child: Text('Hello World'),   // Replace this text...
          child: Text(wordPair.asPascalCase),  // With this text.

I ran into this issue as well. It would also help if the commented out 'Hello World' line had the const  left in it for consistency and to make it clearer that Text(wordPair.asPascalCase) should not have const in front of it.
i.e.
        body: Center(   // Remove const
          //child: const Text('Hello World'),   // Replace this text...
          child: Text(wordPair.asPascalCase),  // With this text.
        ),

duplicate of  https://github.com/flutter/flutter/issues/53375


[BUG] - getMenuTriggerProps in use-dropdown.ts returns originalProps as Object

NextUI Version
2.1.17
Describe the bug
In line 130 of use-dropdown.ts it seems the curly brackets include the originalProps Object, causing it to appear in HTML as originalProps=[Object Object]. Did you mean:
...mergeProps(otherMenuTriggerProps, {isDisabled: props.isDisabled}, originalProps),
or
...mergeProps(otherMenuTriggerProps, {isDisabled: props.isDisabled, ...originalProps}),
or is that correct behaviour?
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Use the nextUI Dropdown in version 2.1.17.
Expected behavior
No property originalprops="[object Object]" in HTML
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

Hey @jrgarciadev! I had a request from @wingkwong for the review of this PR, since my last change was affecting this matter.
In this PR, we fixed the issue that the Dropdown component's isDisabled prop does not take into consideration, so we intentionally used props.isDisabled.
Yeah, you are right @fighter3005, it should be ...mergeProps(otherMenuTriggerProps, {isDisabled: props.isDisabled}, originalProps) to take originalProps' isDisabled and the Dropdown's isDisabled prop in effect.
I will update the code accordingly due to the request! Thank you, @jrgarciadev! ✌


SW-4616 Remove extra margin during scroll in batch details view

contentRef was being set on the tabs container, most likely a mistake since the contentRef was also being set correctly on the content container of tabs and info cards correctly
removed the extra contentRef (which adds a marginTop 200px during scroll up which triggers a static page header)

@nickgraz when you get a chance, a quick/simple change


Bundling redactor distributions breaks license

While I admire the work you're putting in, including the redactor distributions themselves is breaking Imperavi's licensing.
http://imperavi.com/redactor/faq/#q3

However, keep in mind that Redactor is not an open-source product. It is proprietary commercial copyrighted software and we do not allow it's distribution under any open- source licenses. Think about Redactor as if it was a paid proprietary extension for
your project.

http://imperavi.com/redactor/license/
Essentially, you are allowed to do whatever you want with redactor in your own product, but you aren't allowed to become a distributor of the library itself, as you are doing here.
I don't work for Imperavi, I'm actually just a customer of theirs, and I think they do great work.  But Imperavi isn't a big company, its only a few people, and paying them for an appropriate license (its a small one-time purchase) so you can use their software, and they can keep working on it, is an excellent deal.
You can't just MIT license a project, which is bundling and distributing someone elses commercial work.  It doesn't work like that.

@wyaeld  I have written directly to Imperavi about that. It wasn't our goal to break their license, it was just our oversight. Thanks for heads up!

I got an answer from Imperavi - probably redactor Code will be removed completely from whole git repository.

@wilgoszpl you're welcome.  Sorry it resulted in the overall removal.
I've seen other projects successfully ship with a different editor, but explain that redactor is preferred, and give the install instructions.
For our purposes, we just buy a license for unlimited use.  Hard to find another organisation out there that offers lifetime updates off a single license, and then ships new versions every month.  I want these guys to stay around for a long time.

So if redactor is being removed completely from git, will we simply be required to integrate redactor ourselves and use the gem for the Carrierwave support and general customisation?
Kind regards,  --
 Jaymie Jones
@pixelstackcom
http://pixelstack.com
http://jaymiejonesphoto.com
On Tue, Feb 24, 2015 at 7:58 PM, Brad Murray<EMAIL_ADDRESS>wrote:

@wilgoszpl you're welcome.  Sorry it resulted in the overall removal.
I've seen other projects successfully ship with a different editor, but explain that redactor is preferred, and give the install instructions.
For our purposes, we just buy a license for unlimited use.  Hard to find another organisation out there that offers lifetime updates off a single license, and then ships new versions every month.  I want these guys to stay around for a long time.
Reply to this email directly or view it on GitHub:
https://github.com/SammyLin/redactor-rails/issues/98#issuecomment-75720348

@wyaeld , buying OEM license will not work in this project - the application needs to be something more than simple rails integration to include redactor as open source.

@jaymiejones86 , we decided to downgrade redactor files to latest free-to-use version (8.2.2) . Those files will be included in redactor-rails, but every newest update needs to be removed.
Yes, we will be required to integrate redactor files ourselves (copying files should be enough)  - I'll add a note about that to README soon.


Firefox Step navigation failing

In Firefox 52 and 57, the px-steps-tapped event does not appear to be firing, or visible in the event list.
I can see and navigate it in Chrome, and I see the demo at https://www.predix-ui.com/#/elements/px-steps even in Firefox.
Example code:
`<px-card header-text="Configuration Process">
    <px-steps
      id="stepper"
      items="{{workflowSteps}}"
      current-step="{{workflowStep}}"
      completed="{{workflowComplete}}">
    </px-steps>
  </px-card>

  <script>
    var app = document.getElementsByTagName('px-app-controller')[0];
    var stepper = document.getElementById('stepper');
    stepper.addEventListener('px-steps-tapped', function(e){
      app.set('workflowStep', e.detail.id - 1);
      console.log('step ',e.detail.id  );
    });
  </script>`

Hi! Thanks for your issue.
Workin' fine here:
https://codepen.io/mdwragg/pen/QOaqve?editors=1011
FF 58 on Mac OS High Sierra, for reference.
Can you close the issue if it works for you? Thanks.

The codepen works for me in firefox, but my application, at https://mapping-ui-poc.run.aws-usw02-pr.ice.predix.io/ does not (mailed you credentials separately, has simulated data only). I've tried forcing polymer 1.9.1, with no change...I'm not sure what else might account for the FF-specific variation.

Can you send me the link to the repo? Thanks.
And tell me where you're listening for the event.
      <script>
        var app = document.getElementsByTagName('px-app-controller')[0];
        //var stepper = document.getElementById('stepper');
        window.addEventListener('px-steps-tapped',  e => {
          app.set('workflowStep', e.detail.id - 1);
          console.log('step ',e.detail.id  );
        });
      </script>

^^ This isn't working at all in side the

Thanks!
https://github.build.ge.com/connect/mapping-ui-poc
listener is at
https://github.build.ge.com/connect/mapping-ui-poc/blob/master/src/px-tag-mapper.html line 240, in a script block in the outer template of the module, and it's definitely working in Chrome....but does not appear to trigger at all in firefox.
I've tried moving the listeners under ready(), and everything works in Chrome but still no triggers in Firefox or Edge.

My guess is that this is a timing thing, the event handlers are attaching prior to the component being created in px-tag-mapper - try adding the event handler in the 'ready' function of your component in https://github.build.ge.com/connect/mapping-ui-poc/blob/master/src/px-tag-mapper.es6.js

Gah... I missed your last sentence!

When you tried it in the ready() function did you attach the event to this or window? Experiment with both... Or even the px-steps component itself in the template (where ever that lives)

Thanks! listening to window, inside ready(), makes it work in firefox.

Excellent! Glad to hear it :-)


Mention that utilities like vcgencmd don't work in the container

vcgencmd get_config int won't return the correct config.txt settings because it reads the fake on in /boot/config.txt
 Front conversations

Good point!
I'm guess, ing we have to do a bit of research, as it's more like "some features don't work as expected", rather than it should just not be used.  E.g. I've used vcgencmd measure_temp for getting the core temperature, and that's just fine.

@imrehg yeah it definitely warrants a little bit of research and play.

related to #387, need to have clear explanation of /boot in the container


[Question] Modifying view on select

What is the best practice to modify an iitem view when it is selected/deselected?
The checkbox example makes use of the click event to animate the checkbox automatically.
My current method is to have an onClickListener, and to change the view based on if the item is selected. This is on the basis that the selection toggle happens before it, but it also means that I don't get activities for items that are deselected without user input.
For my implementation, I have a grid of images, and selecting an item will blur it. Deselecting it will unblur it. Another thing I've noticed is that selecting an item will automatically unblur another. This might be because there is a selection limit, and that the other item is redrawn.

The solution works fine now with multi select available. However if there are better options that the onClickListener I'd like to hear it.

@AllanWang well you can also enable that the FastAdapter updates automatically and calls onBind again
https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L249
But your solution is as good


[BUG] Playwright and Azure Function Deployment Issues

There is an issue with .net 6.0 playwright version 1.22.0 that is currently not allowing for deployment to Azure Functions. We have tried multiple solutions including manually setting up the browser EXE's as well as installing them locally. We created a test app shown below that outputs the error below that.
namespace PlaywrightTesterLibrary
{
    using Microsoft.Extensions.Logging;
    using Microsoft.Playwright;
    public class PlaywrightTester : IPlaywrightTester
    {
        private readonly ILogger _logger;

        public PlaywrightTester(ILogger<PlaywrightTester> logger)
        {
            _logger = logger;
        }

        public void Run()
        {
            PlaywrightExecution().Wait();

        }
        private async Task PlaywrightExecution()
        {
            try
            {
                Microsoft.Playwright.Program.Main(new[] { "install", "chromium" });
                _logger.LogDebug("Playwright Installed");

                using var playwright = await Playwright.CreateAsync();
                _logger.LogDebug("Created Playwright Asynchroniously");
                await using var browser = await playwright.Chromium.LaunchAsync(
                    new BrowserTypeLaunchOptions
                    {
                        Headless = false,
                        ExecutablePath = Environment.GetEnvironmentVariable("HOME_EXPANDED"),
                    });
                _logger.LogDebug("Creating Browser");
                var page = await browser.NewPageAsync();
                _logger.LogDebug("Opening Page");
                await page.GotoAsync("https://playwright.dev/dotnet");
                _logger.LogDebug("Going to Playwright Page");
                await page.ScreenshotAsync(new PageScreenshotOptions { Path = "screenshot.png" });
                _logger.LogDebug("Taking Screenshot");
            }
            catch (Exception ex)
            {
                _logger.LogError(ex.Message + ex);
            }
            finally
            {
                _logger.LogDebug("Success");
            }

        }

    }
}

This function runs locally, successfully (without the home expanded environment variable)
Error in Playwright:
Failed to launch: Error: spawn D:\DWASFiles\Sites\test-inc-robot\VirtualDirectory0 ENOENT =========================== logs ===========================  D:\DWASFiles\Sites\test-inc-robot\VirtualDirectory0 --disable-field-trial-config --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --no-sandbox --user-data-dir=C:\local\Temp\playwright_chromiumdev_profile-2czlmr --remote-debugging-pipe --no-startup-window [pid=N/A] starting temporary directories cleanup [pid=N/A] finished temporary directories cleanup ============================================================Microsoft.Playwright.PlaywrightException: Failed to launch: Error: spawn D:\DWASFiles\Sites\test-inc-robot\VirtualDirectory0 ENOENT =========================== logs ===========================  D:\DWASFiles\Sites\test-inc-robot\VirtualDirectory0 --disable-field-trial-config --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --no-sandbox --user-data-dir=C:\local\Temp\playwright_chromiumdev_profile-2czlmr --remote-debugging-pipe --no-startup-window [pid=N/A] starting temporary directories cleanup [pid=N/A] finished temporary directories cleanup ============================================================ at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in //src/Playwright/Transport/Connection.cs:line 164 at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in //src/Playwright/Transport/Connection.cs:line 475 at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61 at PlaywrightTesterLibrary.PlaywrightTester.PlaywrightExecution() in /home/vsts/work/1/application/Projects/PlaywrightTester/PlaywrightTester.cs:line 28
Once deployed this error is thrown.

The ExexutablePath you set is a directory ("D:\DWASFiles\Sites\test-inc-robot\VirtualDirectory0") while it is expected to be a path to the .exe file of the browser. You should be able to install the bundled browser by running
# Install required browsers - replace netX with actual output folder name, f.ex. net6.0.
pwsh bin\Debug\netX\playwright.ps1 install

or programmatically from the you app and omit custom ExecutablePath, see this doc.

So I have tried a variety of those fixes without success. With the programmatic fix, We get Exception:Microsoft.Playwright.PlaywrightException: Executable doesn't exist at D:\DWASFiles\Sites#1brokerage-automation-inc-robot\VirtualDirectory0\PlaywrightBrowserPath\chromium-1000\chrome-win\chrome.exe╔═════════════════════════════════════════════════════════════════════════╗║ Looks like Playwright Test or Playwright was just installed or updated. ║║ Please run the following command to download new browsers: ║║ ║║ pwsh bin\Debug\netX\playwright.ps1 install ║║ ║║ <3 Playwright Team ║╚═════════════════════════════════════════════════════════════════════════╝at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in //src/Playwright/Transport/Connection.cs:line 164at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in //src/Playwright/Core/BrowserType.cs:line 61at ToolBox.PlaywrightBrowser.InitializeHeadlessAsync() in C:\Users\lpacheco\source\repos\ASecondChance\IncRobotAllProjects\IncRobotFunctions\ToolBox\PlaywrightBrowser.cs:line 26at IncRobotFuncs.Triggers.PlaywrightTest.Run(HttpRequest req, ILogger log) in
We are unable to run pwsh bin\Debug\net6.0\playwright.ps1 install on the cloud since the environment does not have pwsh as a valid command and we do not have access to add it. When omitting the executable path, we get the same error. The file structure for chrome fully exists at that path and we are able to access the directory and file. Confused as to why we are getting a does not exist error, when it clearly exists.

To add on, when we try to directly path it inside of the actual application, we get an EONET error:
Failed to launch: Error: spawn C:\home\site\wwwroot.playwright\package.local-browsers\chromium-1005\chrome-win ENOENT =========================== logs ===========================  C:\home\site\wwwroot.playwright\package.local-browsers\chromium-1005\chrome-win --disable-field-trial-config --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --user-data-dir=C:\local\Temp\playwright_chromiumdev_profile-oktNuR --remote-debugging-pipe --no-startup-window [pid=N/A] starting temporary directories cleanup [pid=N/A] finished temporary directories cleanup ============================================================Microsoft.Playwright.PlaywrightException: Failed to launch: Error: spawn C:\home\site\wwwroot.playwright\package.local-browsers\chromium-1005\chrome-win ENOENT =========================== logs ===========================  C:\home\site\wwwroot.playwright\package.local-browsers\chromium-1005\chrome-win --disable-field-trial-config --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --user-data-dir=C:\local\Temp\playwright_chromiumdev_profile-oktNuR --remote-debugging-pipe --no-startup-window [pid=N/A] starting temporary directories cleanup [pid=N/A] finished temporary directories cleanup ============================================================ at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in //src/Playwright/Transport/Connection.cs:line 164 at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in //src/Playwright/Transport/Connection.cs:line 475 at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61 at PlaywrightTesterLibrary.PlaywrightTester.PlaywrightExecution() in /home/vsts/work/1/application/Projects/PlaywrightTester/PlaywrightTester.cs:line 27
Is it even possible to deploy playwright directly into an azure function?

Now we are at a point where we have installed the correct path chrome exe, and are now stuck at the error
spawn UNKNOWN =========================== logs =========================== <launching> C:\home\playwright-browsers\chromium-1005\chrome-win\chrome.exe --disable-field-trial-config --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --user-data-dir=C:\local\Temp\playwright_chromiumdev_profile-ReEYPG --remote-debugging-pipe --no-startup-window

Completely lost at this point as there has not been any other indication that this error should be happening

Playwright requires a lot of dependencies to function properly, this includes the driver (shipped with nuget), the browsers (installed with the pwsh command), OS dependencies (they need to be installed manually or pwsh playwright install --with-deps).
Thats why we usually recommend using our official Docker image, which does all of this out of the box: https://playwright.dev/dotnet/docs/docker
Would that work for you? The newly launched Azure Container Apps might be a good fit for that.

Ok! Well we decided to pivot to a javascript verison of playwright which is functioning as intended in Azure! Thank you for the help.


Propagate instances set for upgrade to metadata.

Revert the metadata fix https://github.com/rancher/cattle/pull/1791 to solve the 503 issue with start-before-stop service upgrade
https://github.com/rancher/rancher/issues/8684
The same PR has been tested with 1.6 setup as well, and can be cherry-picked to 1.6 as-is.
@cjellick @ibuildthecloud please review.

LGTM, just going to run it by @ibuildthecloud

LGTM


[Bug]: setting nextmarker in AFSFileClientImpl.codeunit results in an error if nothing is found

Describe the issue
if NodeList is empty no temprecords are beiing inserted and an error will occur because of the modify on an not inserted temprecord
Expected behavior
Nextmarker is always blank if nothing is found, so setting this is not needed
Steps to reproduce
Make AFS return no result. For examply by setting Prefix to ABCDEFG a non existing file name.
Additional context
No response
I will provide a fix for a bug

[X] I will provide a fix for a bug

created a fix rather there is no "Next Marker" or the table AFSDirectoryContent is empty.

@Pieterheinevdm / @SlavaGeorgiev, so which solution should I pick? Any preference?

@Pieterheinevdm / @SlavaGeorgiev, so which solution should I pick? Any preference?

Good question @JesperSchulz
@Pieterheinevdm - his PR fixes the issue in case the EntryNo isn't equal to zero.
My PR avoids a modify if there is no NextMarker and the directory is empty.
In case this helps.

both will do the job, my change is cleaner, but I won't mind which one you choose.


Moving Maps app from dev to master

Adding Maps Sample App for TV into master branch

@randeepsingh01 Could you review & merge this PR?


vp9dec: create surface and context with ivf width and height.

Signed-off-by: Zhong Cong<EMAIL_ADDRESS>

updated.

+1

merged as a4cb390bec76d260e5af24b3ff6a5feeaf022938


:seedling: Set providerID in phase ensure-provisioned

What this PR does / why we need it:
Currently, we set the providerID of a baremetal server only after we confirmed that cloud init has successfully completed. However, CAPI also reacts on the result of cloud init, so there might be a temporary state when CAPI already reconciles the node object, CSRs are created, etc., but we have not yet set the providerID.
This leads for example to errors in the csr-controller, where we rely on the providerID to be set.
This PR sets the providerID already in ensure-provisioned state, so that these temporary errors should not occur anymore.
TODOs:

[x] squash commits
[ ] include documentation
[ ] add unit tests

Just for the records, we cherry-picked this PR, and then the bm machines failed to join the cluster.

This was merged instead: https://github.com/syself/cluster-api-provider-hetzner/pull/1357


Add SHT20 using si7021 driver

Adds SHT20

@tyeth This should be fine. Have you tested it on hardware yet?

Yes just this second seen another bug though, #410, it seems to not send a Device Init message when you add a Dev component, but it works with a reboot (the component is added to the list but the device gets no component Init message).
This can now be nicely tested with the Si7021 and the SHT20 (both use same driver but one is Dev state). I believe the HU21D is also driver compatible if you have one of those and no Si7021/SHT20.
An example of the console output for deleting the Si7021 and adding it as the SHT20 instead. It de-inits the si7021, does a scan when adding the SHT20 to verify address, then never does an Init. The same is not the case with non-dev components.
17:45:19.343 -> PING!
17:45:24.084 -> PING!
17:45:28.767 -> PING!
17:45:30.201 -> * NEW MESSAGE [Topic: Signal-I2C]:
17:45:30.201 -> 4 bytes.
17:45:30.201 -> cbDecodeSignalRequestI2C
17:45:30.201 -> NEW COMMAND: I2C Device Deinit
17:45:30.201 -> Publishing Message: I2CResponse...Published!
17:45:33.492 -> PING!
17:45:38.205 -> PING!
17:45:42.908 -> PING!
17:45:45.788 -> * NEW MESSAGE [Topic: Signal-I2C]:
17:45:45.788 -> 12 bytes.
17:45:45.788 -> cbDecodeSignalRequestI2C
17:45:45.788 -> I2C Scan Request
17:45:45.788 -> EXEC: I2C Scan
17:45:45.788 -> Found I2C Device at 0x11
17:45:45.788 -> Found I2C Device at 0x64
17:45:45.788 -> I2C Devices Found: 2
17:45:45.788 -> Publishing Message: I2CResponse...Published!
17:45:47.626 -> PING!
17:45:52.319 -> PING!
17:45:57.020 -> PING!
17:46:01.762 -> PING!
17:46:06.488 -> PING!
17:46:11.169 -> PING!
17:46:15.884 -> PING!
17:46:20.610 -> PING!
17:46:25.041 -> STATUS LED BLINK KAT
17:46:25.312 -> PING!
17:46:30.019 -> PING!

@tyeth Thank you for finding the bug. I assigned @lorennorman to take a look at it.
In the meantime, I am going to review this PR and merge it in. I'll also set the component to published. Likely a new WS release today, too, as I'm adding https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/411

@brentru Thanks for the rapid work. Did you spot the packet size decode error returned? #408

I didn't, added to my assignments.


Current solution to DateTime defaults for PostgreSQL?

Hi, I'm wondering what the current solution is to this error for an existing postgres db:
Invalid value 'CURRENT_DATE' for type DateTime.

The name of this field is "date_created" and is used in all of my tables.

Are there plans to support CURRENT_DATE and similar defaults in the near future?

And until then what do we do in the meantime?

Additional Questions:

Does this occurr for other default functions?
Would it be ok to remove defaults from a datamodel.graphql that doesn't support migrations (i.e. an existing database), as there isn't any need for graphql to know?

Many Thanks.

@james-ff If your use case is just having a field for the date a record was created, prisma automatically adds this to all your schema as "createdAt", even if it isn't in your type declarations. Adding this to your type declarations will expose it and let you use it.
That said, to my knowledge there is no way to specify a dynamic default like CURRENT_DATE in prisma right now. The work around for now would be to enforce this in a layer over top of prisma, such as a graphql-yoga server.

@goulderb I maybe should have made the following clearer, my bad:
My use case is with migrations turned off for an existing database. In this case Prisma does not modify my database schema at all. The date fields I have are set up like this in my database schema and have been introspected into the Prisma type declarations (datamodel.graphql) along with their defaults.
Postgres schema datetime definition:
date_created DATE NOT NULL DEFAULT CURRENT_DATE

Example of Prisma datetime field generated from introspection.
date_effective: DateTime! @default(value: "CURRENT_DATE")

This issue concerns the existence of default functions / expressions in the Prisma type declarations for a non-migration setup of Prisma.
With this setup, is it ok to remove the default decorators in Prisma, and are there any considerations around doing so? And should they be introspected by prisma in the first place.
I guess this issue is for the team at Prisma that is developing the existing postgres use case for Prisma.


Fix imports to remove warning per Flask recommendation.

Flask no longer recommend using the "flask.ext." import style; this change eliminates the warning currently generated by flask when using this extension.
http://flask.pocoo.org/docs/0.12/extensiondev/#extension-import-transition
(The 0.12 docs are somewhat contradictory on this, but the confusing text seems to have been removed in the latest dev docs.)

Coverage remained the same at 95.489% when pulling b8e87113ac8129189bbbb7c581bf8641c3784ee1 on alphagov:fix_imports into bf32d07c8ce72adc009619ef04e666c51736f80c on trustrachel:master.


Default data provider of Overview View is hard-coded

The default data provider ID of the Overview View is hard-coded to the histogram XY chart of the Trace Compass trace server. The default data provider ID should not be hard-coded, but should be configurable using a preference.
Note: The end-user has now way to know what the IDs of the available XY views are. So, the ID is probably not the best thing to have a preference for.

Hi @bhufmann, I am picking up this issue. I have a few questions that need clarification before I can make a proposal.

By preference, do you mean having the default view as an option in the Preference settings below:

Would the name of an XY view be a good preference?

If we say yes to both of the above, then:

If I remember correctly, all traces would have a Histogram view. Can you confirm this? If this is the case, Histogram is a great default value.
Also, this would mean that the view name will be hard-coded in the trace-server-preference.ts file. Would this be OK?
If the user enter some view name that is not valid for a certain trace, would we default to the default Histogram view with some error message?
Personally, I am thinking of using either a list of available views that can be set as the default view or letting the users enter the name of the default view by themselves. I prefer the latter one. What do you think?

Thanks for picking this one up.

Hi @bhufmann, I am picking up this issue. I have a few questions that need clarification before I can make a proposal.
1. By preference, do you mean having the default view as an option in the Preference settings below:
   ![image](https://user-images.githubusercontent.com/92533264/194405381-5a45b3f0-a802-491f-baad-bbe28ee4f6b9.png)

Yes, it would be a new trace viewer preference

2. Would the name of an XY view be a good preference?

XY would not be a good name. The name should be related to the Overview view, maybe Overview: Default

If we say yes to both of the above, then:
3. If I remember correctly, all traces would have a Histogram view. Can you confirm this? If this is the case, `Histogram` is a great default value.

With Trace Compass based servers, there will be always a Histogram view. But for other server implementations not. Not exactly sure how preferences work in Theia. However, there could be a default one provided from the source code. But it is possible to changing the default one using the package.json of an Theia build. This should be possible for this preference. The Trace Server: path preference is created that way, so you can take it as example.

4. Also, this would mean that the view name will be hard-coded in the `trace-server-preference.ts` file. Would this be OK?

Implement it similarly to the Trace Server: path

5. If the user enter some view name that is not valid for a certain trace, would we default to the default `Histogram` view with some error message?

Not sure if we need that level of complexity. You would have to do a back-end call to check if the name exists and if it is an xy chart. Maybe for initial version we, don't do that validation. If we get feedback, then we can implement it.

6. Personally, I am thinking of using either a list of available views that can be set as the default view or letting the users enter the name of the default view by themselves. I prefer the latter one. What do you think?

Let's use the latter one. I think it's easier to implement. This is useful for traces that don't have a histogram view. The histogram view can be the fallback one.

2. Would the name of an XY view be a good preference?

XY would not be a good name. The name should be related to the Overview view, maybe Overview: Default

What I meant to ask was the value of the Overview: Default preference. I would like to know if the value can be the name of any XY view. (e.g. the value would be something like Histogram, or Disk IO View.

Implement it similarly to the Trace Server: path

You mean as in the photo below right?

2. Would the name of an XY view be a good preference?

XY would not be a good name. The name should be related to the Overview view, maybe Overview: Default

What I meant to ask was the value of the Overview: Default preference. I would like to know if the value can be the name of any XY view. (e.g. the value would be something like Histogram, or Disk IO View.

I think we can only use the name of the view. The data provider ID is internal to the tool and it's not exposed to the end user even if the ID would be a more reliable choice.

Implement it similarly to the Trace Server: path

You mean as in the photo below right?

Yes


Terminal is not work properly in Linux version

Version: 1.52.1 as well as 1.51
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:32:10.090Z (1 wk ago)
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 4.15.0-128-generic
When I launch VS Code through Icon or terminal command, the VS Code is shown with empty content in Terminal tab. I can not even run my code, as I am using it for Python design.
Occassionaly, I want to check what's going wrong with 'code --verbose'. It happend that the Terminal tab work properly. I can run python script through this method.
Moreover, when I launch 'code --verbose', it promted in Terminal tab in VS Code that "bash: export: `:/usr/lcal/cuda-11.0/lib64': not a valid identifier". Not sure whether it is related to the issue. I check that /usr/lcal/cuda-11.0/lib64 in my system is valid and links to targets/x86_64-linux/lib/

i fixed it by enabling this option:
File -> Preferences -> Setting -> Features -> Terminal -> Inherit Env

Thank you. I tried and it works for me.


Make Pandas dependency optional

Pandas is currently used to record cluster results. This is a rather small usecase for the big dependency. Affects:

recorded decorator
cnn.CNN.record tuple + recordtypes
TypedDataFrame

Pandas module is now optional. Dependency is checked when the cnn.py is loaded:
try:
    # Optional dependency
    import pandas as pd
    _PANDAS_FOUND = True
except ModuleNotFoundError:
    print("Did not load pandas")
    _PANDAS_FOUND = False

Closing issue for now. Maybe we need another import mechanism later (see imp module).


Question: when do you plan to publish Release v0.4.1 on npm?

I can't find the latest release...

Yep, i just realize on npm it stil on 0.3.1

Released! Sorry for late response.
I really need to automate this.... really sorry.

@aca Would you like any help with automation?


FizzBuzz-for.cpp

Thank you for your PR!
Unfortunately your solution has already been submitted in some form :/
Don't worry, your PR will still count :)


Consider laxing max-len

Currently, I can't have a multiline template string that contains a paragraph that has more than 140chars:
        str += `
It's a bad practice having files being output with hashes during development. Your output folder will become filled with a lot of different files after a few rebuilds.

Additionally, this is know to cause ${chalk.bold('memory leaks')} with ${chalk.bold('webpack-dev-middleware\'s')} in-memory filesystem.
Either ${chalk.bold('avoid having hashes')} in development or disable in-memory filesystem through the \`memoryFs\` option.

If you feel this was a false positive, please ignore this warning.

`;

We should consider laxing this rules in a few cases, see https://eslint.org/docs/rules/max-len

@satazor I can have a look at this as soon as we're done with https://github.com/moxystudio/eslint-config/issues/31 🙂


Search User Widget - Generic

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#482
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Send user search widget. This is a search widget that can be dropped anywhere inside a view. Its not specific to Send or Anything else. Its generic enough.
👯♀ Paired with
Solo

@gguij004  Make sure to review this PR, Is a good clean example how to work with Bloc

No screenshots for UI?


Python type inference broken for list.remove_at

Describe the bug
Charred Earth tank game has compile errors when converting to Python
Minimal repro: https://makecode.com/_Dj1K2a1xCYLx
Works in blocks -> convert to Python, see error

Probably we should take fix for this. Can you take a quick look? If this needs to go to someone else let me know.

sure, investigating! semi-related, "pop" in python optionally takes an index (same behavior as "removeAt") so we have a bug there as well:

better minimal repro:
test = ["test", "two", "four"]
test.remove_at(2).is_empty()

i tried a few things but couldn't find a targeted/small fix for this. the correct fix would be to implement support for generics in python

Fixed!


Update local election content: Lincoln county

Spreadsheet: https://docs.google.com/spreadsheets/d/1dk58MD0qBAM37BDOZwKIz10hp5AARAIX8u_qvuDnYaI/edit#gid=0
Instructions: https://github.com/OpenMaine/maineballot/wiki/Updating-Maine-Ballot-for-an-upcoming-election

All towns updated on Spreadsheet for June 2022


BUG: Responsive Toggle not working!

I have copied the responsive toggle code here:
http://foundation.zurb.com/sites/docs/responsive-navigation.html#responsive-toggle
and included the full CSS and JS, but it doesn't function the way it supposed to. It justs a div that doesn't do any thing (i.e. no toggling and doesn't hide for larger screens).
Here's the code:
http://jsfiddle.net/anik786/aeodhuLp/2/
Resize the browser to see that nothing happens!

That's an issue we had with mangling the .min file. Fixed yesterday with v6.0.1

Thanks, I forgot to copy over the new .min.js file

Side note, it appears for now that if you use a copy of .min from the customizer, it still won't work. We're working on it.

I'm unsure if there's still a bug here, or if I'm doing something wrong?
I've been trying to get a simple copy and paste of the demo menu from the docs to work in my own simple project over the last couple of days, but I can't get it to work no matter what I do.  I've tried the min and non-min files for 6.0.1 and 6.0.3.  And I've just copy and pasted the demo menu from http://foundation.zurb.com/sites/docs/responsive-navigation.html into a page.  Does it need anything apart from jQuery 2.1.4, foundation.css and foundation.js?  I've also tried removing all my other css and js files.
The docs don't tell us which files are required for it to work, and it would at least be easier to figure out if I was doing something wrong if the online docs just used the standard foundation files themselves instead of some different customized files like docs.js
I made an offline copy http://foundation.zurb.com/sites/docs/responsive-navigation.html - and without any changes, it works locally.  But it breaks as soon as I remove the custom ./page_files/docs.js javascript file.  So it's hard for me to figure out where the problem is in my own project.


Cosmic Crate

Crate-Type-Settings:
Total-Prize-Amount: 1
Mystery-Crate:
Item: 'CHEST'
Name: '&f&l???'
Lore:
- '&7You may choose 1 crates.'
Picked-Crate:
Item: 'GLASS_PANE'
Name: '&f&l???'
Lore:
- '&7You have chosen #%slot%.'
this feature wont work, i did it to total prize amount 1. but it still as defaullt 4

Currently in development and not fully finished.


petalinux dp

背景：我需要配置petalinux系统来运行vitis ai
您好，我用的是贵公司的axu2cgb开发板，我在编译、运行petalinux2022.2系统时，所配置的matchbox桌面不能使用，我想问下如果要通过dp外接显示器，显示桌面的话，是否需要配置dp的设备树呢？？麻烦您了

Ruiii,
I don't think I can answer your question about running Vitis AI.  My goal here was to test the Alinx board for general purpose industrial applications and it works very well for that.  I think there is a different flow for doing Vitis AI but you should ask someone who knows.
Also, I did not test the Display Port interface. I would guess that you only need to enable it in the ZynqMP in IP Integrator and Petalinux will make the right device tree.  When it boots it will load the right driver for DP.
Good luck

您的意思是我需要在vivado中使用DP，然后进行petalinux系统制作吗？？

I think that is right.  I am not in front of my work computer so I cannot check if DP is enabled in the Vivado design.  If you can open the FPGA design in Vivado you can open the IPI block diagram and open the ZynqMP block. I think DP is under high-speed IO.  It is probably enabled.  I will check it when I get back to my workstation.

好的好的，十分感谢，麻烦您了！！！


How to use SuperLU solver with a BlockOperator

Hi, I Have a BlockOperator and want to pass it to the SuperLUSolver. The problem is that it only accepts Operators.
How can I split the BlockOperator into Operators or convert it to  HypreParMatrix to pass it to the Solver?

@cdelv ,
Does your Blockoperator contain blocks of HypreParMatrix ? If yes you can use
HypreParMatrix * HypreParMatrixFromBlocks(Array2D<HypreParMatrix*> &blocks,
                                          Array2D<double> *blockCoeff=NULL);

I hope this helps.
Best,
Socratis

@psocratis Actually it is
    A = new BlockOperator(block_true_offsets);
    A->SetBlock(0, 0, M);
    A->SetBlock(0, 1, C);
    A->SetBlock(1, 0, Ct);
    A->SetBlock(1, 1, D);

M, C, Ct, D are HypreParMatrix.
The question is now, how do I do that array? How do I create the new matrix?
I have another question out of pure curiosity, I found a way to convert the BlockOperator into a PetscParMatrix with PetscParMatrix::PetscParMatrix(MPI_Comm comm, const Operator *op, Operator::Type tid), Is there a way to convert a PetscParMatrix into a HypreParMatrix

Hi @cdelv ,
You can create a Array2D<HypreParMatrix*> of size (2,2) and assign accordingly the pointers to your HypreParMatrices. You might want to take a look at ./tests/unit/linalg/test_matrix_rectangular.cpp for a simple demonstration on how to use this method.
Regarding your second question, I am not sure if such a conversion is readily available in MFEM (I don't think so). @jandrej do you know more about this?
Thanks,
Socratis

Thanks, That's It, It worked.


Better training set rebalancing

See LabelBalancer
cc: @jason-fries
Fixes #533

@henryre I thought there was a TF class for doing this?  Did you check out?

That's batch normalization. Will do this for deepier models. This is much more basic.

K will review in a bit


[TIMOB-19020] Migrate project to Ti.SDK

JIRA: https://jira.appcelerator.org/browse/TIMOB-19020

CR done. Looks good. Please address comments.

APPROVED


Fix Flicker Theme issue on Tangle Dapp

Summary of changes
Provide a detailed description of proposed changes.

Fix Flicker Theme issue on Tangle Dapp

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes #2007

Screen Recording
If possible provide a screen recording of proposed change.
https://github.com/webb-tools/webb-dapp/assets/69841784/48696f65-b07b-47be-b45c-c75226510885

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

I tested it on my end, and the fix works for me.


Jsc/cleanup admin

Addresses Issue #171, though not the cancel links.

@cydoval Do you want to work on the styles in this? Or merge and work on separate branch?

i will work and merge on a diff branch @jcubbage


search functionality is implemented

Description
User can search products by name.
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] There are no merge conflicts

 Feature: search


Outputs get evaluated for all rules -- not just the activated ones

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The outputs field in the API response contains outputs from all the rules in the policy.
Expected Behavior
The output expression of a policy should only be included in the response iff the rule is activated.
Steps To Reproduce
No response
Environment
No response
Anything else?
No response

I commented on the PR because I found it first, copying to here for visibility:
This makes sense 👍 . I opted for global evaluation because it gave the potential for more explicit visibility into rule activation, e.g.
- action: "reject"
  effect: EFFECT_ALLOW
  name: reject-rule
  condition:
    match:
      exr: P.attr.foo == "bar"
  output:
    expr: |-
      "eval_result:%s".format([P.attr.foo == "bar"])

Due in part to includeMeta giving policy:scope granularity, which (IIUC) in the case of duplicate action definitions, might still leave some guess-work WRT which rule was triggered. But I didn't really consider the impact on performance or the general misdirection and noise in the response.


Support of virtual sites for creating an Interchange from_openmm

Description
I'm trying to create an Interchange object from an OpenMM system that contains TIP4P water and got this Error: UnsupportedImportError: A particle is a virtual site, which is not yet supported.
Are there any plans to support virtual sites in the from_openmm call or would you recommend a different procedure in a case like this?

No plans right now (but also not planning on never doing this!). I've added it to the board to see how others in the org wish to assign its its priority.
At a technical level I think it's doable, and something narrowly-scoped to 4-site water models is certainly easier than general support. I think it's doable. Compared to a three-site water model, it's just an extra key in the ElectrostaticsCollection and constructing a VirtualSiteCollection from scratch, but only needing to support one style.

Awesome, thank you for letting me know!


matrix is being deprecated from numpy

This causes an error everywhere that np.asmatrix() is called.
See this so post for details.

Done

Turns out matrix.dot() does matrix multiplication whereas array.dot() does element wise multiplication, which is a problem, hence can't just replace asmatrix() to float64() and get the right answer...


Update aws-sam-cli, aws-sam-translator, and fix awscli2

Description of changes

Relaxes python dependency bounds in awscli2 to allow for current packages in nixpkgs (cryptography changelog)
Updates aws-sam-translator to 1.46.0 (changelog)
Updates aws-sam-cli to 1.52.0 (changelog); this depends on the updated version of aws-sam-translator.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

If you can, upgrade awscli2 to 2.7.9, so a future PR from won’t clash with yours.

Good suggestion, done.

Note that you may need to target staging instead of master because of number of rebuilds.

I don't understand why this change incurs so many rebuilds, but I rebased anyway.