Rework logic in common.sh and add kubeac to gitignore

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

.gitignore, line 2 at r1 (raw file):

vendor
kubeac

Missing eol. Minor thing.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable


unable to connect to c4dt.org

When trying to get https://www.c4dt.org, it fails with
send request: tor connect

Caused by:
    0: tor: operation timed out at exit: exit timed out
    1: exit timed out

Same for admin.ch, perdu.com

So with #93, admin.ch and others seem to work. c4dt.org and perdu.com still timeout, but in my experience they also do that under regular Arti.

Just for the record: I tried c4dt.org and epfl.ch with the tor browser, and both are very flaky. But usually after a couple of changes in the circuit, they do connect.
I sent a request to support-icit and ask them whether there is something we con do to improve this, as other sites seem to work without issues.


View Application - Post-submission

User Story
As a user, after my responses have been completed & sent and I log back in I want to see a page with all of my responses so that I can review them.
AC
Given that a user logs in after they have submitted their responses ...
Design

blocked by #49


cli: an option to update a lock file when committing each change

Probably like
molt deps.ts --commit --lock

Note that we can do this with the current version by --pre-commit lock where lock is a task defined in deno.json to run deno cache --lock-write.


Errors when running 0.3.0

I've just tried running 0.3.0 and I get various errors. I haven't successfully got meteor-desktop working yet so i'm not sure what ive done wrong..
So, as per the instructions on the github readme I ran the following in one tab
meteor --mobile-server=<IP_ADDRESS>:3000
Then in a second tab I ran:
npm run desktop -- --scaffold
The first warning i get is:
!expecting a meteor project running on port 3000!
Another warning:
warn: [main] will use desktop.asar from initial version because last downloaded version is using it: /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/desktop.asar
Then I get some errors:
error: [main] autoUpdater reported an error: Error: Could not get code signature for running application
    at Error (native)
    at Function.setUpAutoUpdater (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/squirrel.js:158:25)
    at App.onReady (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/app.js:385:18)
    at emitTwo (events.js:111:20)
    at App.emit (events.js:191:7)

error: [main]  Error: ENOTDIR: not a directory, open '/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar/app/desktop.asar'
    at Error (native)
    at Object.fs.openSync (original-fs.js:640:18)
    at Object.fs.readFileSync (original-fs.js:508:33)
    at assetBundle.getOwnAssets.some (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:414:53)
    at Array.some (native)
    at AssetBundleManager.handleDesktopBundle (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:410:44)
    at AssetBundleManager.didFinishDownloadingAssetBundle (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:381:14)
    at getDesktopVersion.e (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:200:26)
    at Request.httpClient.e [as _callback] (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:131:17)
    at Request.self.callback (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/node_modules/request/request.js:186:22)
2017-01-10 21:45:45.357 Electron Helper[15931:1046717] Couldn't set selectedTextBackgroundColor from default ()

And when electron opens I get the following error:
The selector "app" did not match any elements
Even though it is declared and it works fine when I run the app normally in localhost.
Any ideas what i've done wrong?

!expecting a meteor project running on port 3000!

That is just a reminder. Actually yeah, with those exclamation marks it looks like a warning or sth - will change it.

warn: [main] will use desktop.asar from initial version because last downloaded version is using it: /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/desktop.asar

This should a be a info not warn - will be fixed.

[main] autoUpdater reported an error: Error: Could not get code signature for running application

https://github.com/electron/electron/issues/7476 - unsigned apps (development app is unsigned) can not be auto updated. I will think of disabling this in development build on Mac. In the meantime you can use "autoUpdateCheckOnStart": false to get rid of this error.

error: [main]  Error: ENOTDIR: not a directory, open '/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar/app/desktop.asar'

Please post full log from the app start to this error's occurrence.

The selector "app" did not match any elements

Was this working before in 0.2.6? Do you see any errors in the console? In the Network tab of devtools are there any files that failed to load?

I've never actually got meteor desktop working, I was getting different errors in 0.2.6 so I was waiting for 0.3.0.
Here's my full console output:
`> meteor-desktop "--scaffold"
METEOR-DESKTOP v0.3.0
!expecting a meteor project running on port 3000!
INFO  index:  initializing
INFO  electronApp:  scaffolding
VERBOSE  desktop:  checking .desktop existence
VERBOSE  meteorApp:  updating .meteor/.gitignore
VERBOSE  meteorApp:  desktopHCP is enabled, checking for required packages
VERBOSE  electronAppScaffold:  clearing desktop-build
VERBOSE  electronAppScaffold:  creating /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app
VERBOSE  electronAppScaffold:  copying skeleton app
VERBOSE  electronAppScaffold:  writing package.json
VERBOSE  electronApp:  updating package.json fields
DEBUG  electronApp:  writing updated package.json
INFO  electronApp:  updating list of package.json's dependencies
DEBUG  electronApp:  merging settings.json[dependencies]
DEBUG  electronApp:  merging settings.json[plugins]
DEBUG  electronApp:  merging dependencies from modules
DEBUG  electronApp:  writing updated package.json
VERBOSE  electronApp:  calculating compatibility version
DEBUG  electronApp:  meteor-desktop compatibility version is  0.3
DEBUG  electronApp:  .desktop compatibility version is  0
INFO  electronApp:  installing dependencies
DEBUG  electronApp:  running npm prune to wipe unneeded dependencies
VERBOSE  electronApp:  executing npm prune
VERBOSE  electronApp:  executing npm install
WARN  electronApp:  native modules rebuild is turned off, be sure to turn it on if you added any native node modules
VERBOSE  electronApp:  copying .desktop to temporary location
DEBUG  electronApp:  updating settings.json fields
INFO  desktop:  calculating hash version from .desktop contents
INFO  electronApp:  excluding files from packing
INFO  electronApp:  transpiling and uglifying
INFO  electronApp:  packing .desktop to asar
VERBOSE  electronApp:  clearing temporary .desktop
INFO  meteorApp:  checking for any mobile platform
INFO  meteorApp:  building meteor app
DEBUG  meteorApp:  clearing build dir
INFO  meteorApp:  acquiring index.html
INFO  meteorApp:  successfully downloaded index.html from running meteor app
VERBOSE  meteorApp:  copying mobile build
INFO  meteorApp:  acquiring manifest.json
INFO  meteorApp:  successfully downloaded manifest.json from running meteor app
INFO  meteorApp:  mobile build copied to electron app
DEBUG  meteorApp:  copy cordova.js to meteor build
INFO  meteorApp:  injecting isDesktop
INFO  meteorApp:  injected successfully
INFO  meteorApp:  packing meteor app to asar archive
VERBOSE  meteorApp:  clearing meteor app after packing
INFO  meteorApp:  meteor build finished
INFO  electronApp:  running
info: [main] app data dir is: /Users/michaelbattcock/Library/Application Support/MyMeteorApp
info: [main] initial desktop version is  959df317df051905860c0990f1a4fb8019ee453d
warn: [main] will use desktop.asar from initial version because last downloaded version is using it: /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/desktop.asar
debug: [main] skeleton version 0.3.0
info: [main] ready fired
info: [main] seting autoupdate feed to url: http://<IP_ADDRESS>/update/darwin_x64/0.0.1
error: [main] autoUpdater reported an error: Error: Could not get code signature for running application
at Error (native)
at Function.setUpAutoUpdater (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/squirrel.js:158:25)
at App.onReady (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/app.js:385:18)
at emitTwo (events.js:111:20)
at App.emit (events.js:191:7)
debug: [main] loading plugin: meteor-desktop-splash-screen
debug: [main] loading plugin: meteor-desktop-localstorage
info: [meteor-desktop-splash-screen] [html] preparing splash screen.
info: [meteor-desktop-splash-screen] [html] splash screen prepared.
info: [meteor-desktop-splash-screen] [splashWindow] displaying splash screen from file:///Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/splash.html
debug: [main] loading internal module: autoupdate
debug: [main] loading internal module: dummy
debug: [main] loading internal module: localServer
debug: [main] loading module: example => example
verbose: [autoupdate] initializing autoupdate module
verbose: [autoupdate] trying to read initial bundle version
verbose: [autoupdate] [AssetBundle] making bundle object for /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar
verbose: [autoupdate] [AssetBundle] loading manifest from /Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar
debug: [autoupdate] [AssetManifest] 263 entries. (Version: 75daca45c80cf2488e7a2246eab1fdaaec008a19)
verbose: [autoupdate] [AssetBundle] trying to read desktop version for 75daca45c80cf2488e7a2246eab1fdaaec008a19
verbose: [autoupdate] [AssetBundle] the desktop version is 959df317df051905860c0990f1a4fb8019ee453d
verbose: [autoupdate] [AssetBundle] making bundle object for /Users/michaelbattcock/Library/Application Support/MyMeteorApp/versions/6a86eab4e8f527b3c56510ba9f3597e61a0030ee
verbose: [autoupdate] [AssetBundle] loading manifest from /Users/michaelbattcock/Library/Application Support/MyMeteorApp/versions/6a86eab4e8f527b3c56510ba9f3597e61a0030ee
debug: [autoupdate] [AssetManifest] 263 entries. (Version: 6a86eab4e8f527b3c56510ba9f3597e61a0030ee)
verbose: [autoupdate] [AssetBundle] trying to read desktop version for 6a86eab4e8f527b3c56510ba9f3597e61a0030ee
verbose: [autoupdate] [AssetBundle] the desktop version is 959df317df051905860c0990f1a4fb8019ee453d
info: [autoupdate] [AssetBundleManager] got version: 6a86eab4e8f527b3c56510ba9f3597e61a0030ee in 6a86eab4e8f527b3c56510ba9f3597e61a0030ee
verbose: [autoupdate] will use last downloaded version (6a86eab4e8f527b3c56510ba9f3597e61a0030ee)
debug: [main] desktop loaded
info: [localServer] will serve from:  /Users/michaelbattcock/Library/Application Support/MyMeteorApp/versions/6a86eab4e8f527b3c56510ba9f3597e61a0030ee
info: [localServer] assigned port 8052
verbose: [autoupdate] started startup timer
debug: [autoupdate] timer set to 60000
info: [meteor-desktop-localstorage] loaded storage file /Users/michaelbattcock/Library/Application Support/MyMeteorApp/localstorage.json
info: [meteor-desktop-localstorage] have 0 keys
verbose: [meteor-desktop-localstorage] getAll received
verbose: [meteor-desktop-localstorage] sent storage to renderer
verbose: [autoupdate] startup did complete, stopping startup timer (startup took 5087ms)
info: [autoupdate] [AssetBundleManager] trying to query http://<IP_ADDRESS>:3000/__cordova/manifest.json
debug: [main] received did-stop-loading, assuming meteor webapp has loaded
debug: [main] showing main window
debug: [autoupdate] [AssetManifest] 263 entries. (Version: 75daca45c80cf2488e7a2246eab1fdaaec008a19)
debug: [autoupdate] [AssetBundleManager] downloaded asset manifest for version: 75daca45c80cf2488e7a2246eab1fdaaec008a19
debug: [autoupdate] got desktop version information: 959df317df051905860c0990f1a4fb8019ee453d (compatibility: dd228a785b9080ec22e49e220f4d3aed)
debug: [autoupdate] [AssetBundleManager] No redownload of initial version.
debug: [autoupdate] [AssetBundleManager] skipping writing desktop version into initial version
error: [main]  Error: ENOTDIR: not a directory, open '/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar/app/desktop.asar'
at Error (native)
at Object.fs.openSync (original-fs.js:640:18)
at Object.fs.readFileSync (original-fs.js:508:33)
at assetBundle.getOwnAssets.some (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:414:53)
at Array.some (native)
at AssetBundleManager.handleDesktopBundle (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:410:44)
at AssetBundleManager.didFinishDownloadingAssetBundle (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:381:14)
at getDesktopVersion.e (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:200:26)
at Request.httpClient.e [as _callback] (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/app/modules/autoupdate/assetBundleManager.js:131:17)
at Request.self.callback (/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/node_modules/request/request.js:186:22)
`
The I get the following in the electron console:
The selector "app" did not match any elements
And I get the following in a pop-up window with the options to 'shutdown' or 'restart'
ENOTDIR: not a directory, open '/Users/michaelbattcock/Documents/dev/apps/pipe/.meteor/desktop-build/meteor.asar/app/desktop.asar'

I can't access the network tab in the dev tools as its greyed out (maybe because of the pop-up window)

Please try out 0.4.0. That version should at least get you to the point where you will be able to debug the situation in the devtools.

I've just tried 0.4.0 and I no longer get any errors in the terminal but I do get the following in electron's console:
No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.
But I do have href set as such:
<head>
  <base href="/">
</head>

I also tried this but I get the same errors:
<head>
  <base href="./">
</head>

I've added the following to my app.module.ts
import { APP_BASE_HREF } from '@angular/common';

....
  providers: [
    { provide: APP_BASE_HREF, useValue: '/' }
  ]
....

So that gets rid of the href error but now i'm getting:
The selector "app" did not match any elements (my main component has 'app' as its selector)....

That is rather unrelated to meteor-desktop
Basically angular tried to start the app before it has fully loaded. On cordova it also did not work.
I have submitted a fix here:
https://github.com/michaelb-01/pipe/pull/3

Hi, I tried your fix but now the app never loads.. My index.html loads fine with no errors but my router-outlet is empty...

but my router-outlet is empty...

I do not know angular so I am not sure what that means. I have exactly the same result in both Firefox and Desktop app.
What should I do with your app to experience the same problem?

 Maybe I can close this, and you will report new issues if any occur?


Mobile view is not as intended

Something is off when viewed on a portrait-mode mobile device; figure it out and fix it.

The "Church Staff" and "Music" pages also need specific changes:

For "Church Staff", implement a style similar to the Small Groups page
For "Music", make the header image attach from the right


[ADAP-727] [Bug] Redshift adapter does not retry on connection timeouts

Is this a new bug in dbt-redshift?

[X] I believe this is a new bug in dbt-redshift
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When running a large number of concurrent queries through the dbt-redshift adapter (e.g., by running the MetricFlow test suite using a dbt-redshift client), we observe intermittent failures with this message in the logs:
E           redshift_connector.error.InterfaceError: ('communication error', TimeoutError(60, 'Operation timed out'))

We tried changing the retry count to a larger number, and this made no apparent difference.

        The calls to connect will be retried up to retry_limit times to deal with transient
        connection errors. By default, one retry will be attempted if retryable_exceptions is set.

        :param Connection connection: An instance of a Connection that needs a handle to be set,
            usually when attempting to open it.
        :param connect: A callable that returns the appropiate connection handle for a
            given adapter. This callable will be retried retry_limit times if a subclass of any
            Exception in retryable_exceptions is raised by connect.
        :type connect: Callable[[], AdapterHandle]
        :param AdapterLogger logger: A logger to emit messages on retry attempts or errors. When
            handling expected errors, we call debug, and call warning on unexpected errors or when
            all retry attempts have been exhausted.
        :param retryable_exceptions: An iterable of exception classes that if raised by
            connect should trigger a retry.
        :type retryable_exceptions: Iterable[Type[Exception]]
        :param int retry_limit: How many times to retry the call to connect. If this limit
            is exceeded before a successful call, a FailedToConnectError will be raised.
            Must be non-negative.
        :param retry_timeout: Time to wait between attempts to connect. Can also take a
            Callable that takes the number of attempts so far, beginning at 0, and returns an int
            or float to be passed to time.sleep.
        :type retry_timeout: Union[Callable[[int], SleepTime], SleepTime] = 1
        :param int _attempts: Parameter used to keep track of the number of attempts in calling the
            connect function across recursive calls. Passed as an argument to retry_timeout if it
            is a Callable. This parameter should not be set by the initial caller.
        :raises dbt.exceptions.FailedToConnectError: Upon exhausting all retry attempts without
            successfully acquiring a handle.
        :return: The given connection with its appropriate state and handle attributes set
            depending on whether we successfully acquired a handle or not.
        """
        timeout = retry_timeout(_attempts) if callable(retry_timeout) else retry_timeout
        if timeout < 0:
            raise dbt.exceptions.FailedToConnectError(
                "retry_timeout cannot be negative or return a negative time."
            )

        if retry_limit < 0 or retry_limit > sys.getrecursionlimit():
            # This guard is not perfect others may add to the recursion limit (e.g. built-ins).
            connection.handle = None
            connection.state = ConnectionState.FAIL
            raise dbt.exceptions.FailedToConnectError("retry_limit cannot be negative")

        try:
            connection.handle = connect()
            connection.state = ConnectionState.OPEN
            return connection

        except tuple(retryable_exceptions) as e:
            if retry_limit <= 0:
                connection.handle = None
                connection.state = ConnectionState.FAIL
                raise dbt.exceptions.FailedToConnectError(str(e))

            logger.debug(
                f"Got a retryable error when attempting to open a {cls.TYPE} connection.\n"
                f"{retry_limit} attempts remaining. Retrying in {timeout} seconds.\n"
                f"Error:\n{e}"
            )

            sleep(timeout)
            return cls.retry_connection(
                connection=connection,
                connect=connect,
                logger=logger,
                retry_limit=retry_limit - 1,
                retry_timeout=retry_timeout,
                retryable_exceptions=retryable_exceptions,
                _attempts=_attempts + 1,
            )

        except Exception as e:
            connection.handle = None
            connection.state = ConnectionState.FAIL
>           raise dbt.exceptions.FailedToConnectError(str(e))
E           dbt.exceptions.FailedToConnectError: Database Error
E             ('communication error', TimeoutError(60, 'Operation timed out'))

../../.venvs/metricflow/zJM50P7N/redshift-env/lib/python3.9/site-packages/dbt/adapters/base/connections.py:271: FailedToConnectError

We can see at the end that the error is thrown out of the broader except block, rather than the retry handling.
Expected Behavior
I expected these errors to be retried, but I understand why that isn't happening.
I would also expect redshift_connector to not hide this inside of an InterfaceException, that's just odd, but it is what it is.
Steps To Reproduce
I think the only way to do this is to run lots of concurrent queries on an undersized cluster until you can trigger intermittent failures of this type. I've got a PR up that might trigger this in the MetricFlow CI as well, I'll see if it happens there. If it's just on my local machine maybe I need to do whatever that weird Redshift override thing is.
Relevant log output
No response
Environment
- OS: Mac OS X Ventura 13.4.1 (c)
- Python: 3.9.latest
- dbt-core: 1.6.0rc1
- dbt-redshift: 1.6.0rc1

Additional Context
I am not using dbt proper, just the adapter. See https://github.com/dbt-labs/metricflow/pull/678

Update - I have not yet been able to repro this in GitHub's CI runners, so it's possible this error is due to some local machine configuration. Hopefully somebody better versed in the Redshift connector error state reporting can figure this out, because I'm stumped.
Also worth noting, this does not happen if I use the sqlalchemy-redshift library with redshift_connector specified.

Hey @tlento,
I don't know how I feel about the premise, it feels like an edge case. You are doing high concurrency work on an adapter that's not designed for that. I'm saying that because I won't quality this issue as a bug, but rather an enhancement.
Now to unlock you:

We could add InterfaceError in the list of retry-able error types. But I'm not sure what could be the side effects here. Do you know what other error types we would start retrying? That sounds like too blunt an option to me at this point.
I'm going to tag in our AWS friends here, they may have some answers from the library standpoint. Hopefully we will hear from them soon.

Thanks @Fleid, I tagged it as a bug in case this was happening for all timeouts but if it's just this scenario I agree it's not really an adapter bug that needs fixing but more of a nice to have support enhancement around retry behavior.
I didn't bother putting up a PR to add InterfaceError because I don't have any idea what that opens up to retries.
We are not currently blocked - our CI test suite seems to be fine and that's at the edge of what we might expect an end user doing metrics development to dispatch - so this more of a developer nuisance than anything else. Hopefully the AWS folks have some insights to share!

Since the PR on the redshift_connector side is merged, shall we go ahead and close out this issue? @Fleid

hey @jiezhen-chen has the change been released to PyPI? If so, that's awesome! The next step is to open a PR to increment the version defined in setup.py
https://github.com/dbt-labs/dbt-redshift/blob/e95685fc78f3af5f6c27c672ead473d90f2a3a29/setup.py#L88-L90

facing the same error when using dbt debug for redshift connect via github actions


Feature: default nginx config

hello,
if you want, you may use this default nginx config:
server {
    listen 80;
    server_name _;

    location / {
        return 301 https://$host$request_uri;
    }
    location ~ ^/\.well-known/acme-challenge/([-_a-zA-Z0-9]+)$ {
        default_type text/plain;
        return 200 "$1.ACCOUNT_THUMBPRINT";
        break;
    }
}

or just add location wherever you want.

Please be aware of sslstrip.
http://www.thoughtcrime.org/software/sslstrip/
This config might be convinient, but may lead to a false sense of security.

@mrPsycho While a https is possible when you already have a certificate you are going to renew, how is it supposed to work when you are requesting your initial certificate?

@stephankn letsencrypt does the verification over http not httpS.

Clever, but not recommended. Wouldn't this be open to attacks where the attacker has your account private key but not access to your server?


Fix upstream URL in CONTRIBUTING, add virtualenvwrapper instructions.

Fixes upstream URL.
Adds help to ignore created virtualenv.
Adds usage for virtualenvwrapper.

If you guys have something against virtualenvwrapper LMK and I can take that out.

Hmmm, so it looks like it's linting all the dependent libraries now?

I'm not sure what was going on in the travis builds. Lint was thinking that a ton of stuff changed. I'm wondering if it's because I renamed the branch before I pushed it maybe?


how can i upload a binary key.

Is there an option to upload a binary key?
https://pgp.help/#/import

As things stand you can only import ASCII encoded keys, i.e. they should have BEGIN PGP KEY in the text etc.
However this is pretty standard - I've not seen any PGP app that doesn't export keys this way!!


Dashboard: Display truncated book's titles and description on hover

On the gitbook-editor (6.4.0) , we need a list view for the available books. Many of our books start with a formula repo name that is company_project_books_subproject  .. We end up having "..." truncating docs making it nearly impossible to select the correct gitbook. A hover to full name would help as well over the book name, to untruncate.
Category
FR: List view when selecting book
What is the current behavior?
The name of the book is truncated with "..."
What is the desired behavior?
Create a sortable column based list view of available gitbooks
A hover over the "..." to switch/hint full name would help
Additional information
Windows & Linux
Gitbook Editor 6.4.0

We are thinking of the best way to display books on the Dashboard. We are aware of the current issues of usability with the card-style dashboard. Your suggestion for hover is an easy improvement we can make before anything else.


Today is not holiday in region CT, Spain.

Hi, the library is returning holiday today 12th of September for Catalonia (CT), Spain. That's wrong. Today is working day.
I think the issue is the holiday from yesterday (Sep. 11th)  is traslated to today because yesterday was Sunday as I have seen in the code. But here we do not move the holyday to the next day if it's sunday... Usually they assign another local holiday and that's it... Can you exclude the +1 day rule when it's sunday?

Hi @mrbluebrett,
I googled a bit and it seems that there are only 2 holidays that can be moved to Monday (and that is decided by each Autonomous Community) - Christmas Day and Labor Day. Everything else is usually celebrated on the day of the holiday.
Is this logic correct? Thanks!

Not exactly. All national holidays that happen in sunday can be moved to another day, but each autonomous community decides the new day. Some of the choose the next Monday, but others a completely different day. And also this can change every year so a community that choses to move one holiday to monday one year, the next year can choose to move to a completely different day.
I have also seen in the code that you have put JUN 6 as a holiday in CT, but that was only true this year. When this holiday happens is 7 weeks (or 49 days) after easter monday. And also this only happens if 1 of the 4 autonomous holidays for catalonia (easter monday, JUN 24, SEP 11 and DEC 26) happen in sunday.
Feel free to ask if you need more clarification.

If there's no definitive logic in how sunday holidays are moved it might be hard to program it.

When this holiday happens is 7 weeks (or 49 days) after easter monday. And also this only happens if 1 of the 4 autonomous holidays for catalonia (easter monday, JUN 24, SEP 11 and DEC 26) happen in sunday.

And about this one... So, as I understand it at this moment: if any of those 4 holidays fall on Sunday, you kind of have one "unused" holiday and in this case you have this Pentecost Monday (Jun 6 this year) somewhere in May-June. But if none of those 4 were on Sunday - you don't get a day off, is that correct?

When this holiday happens is 7 weeks (or 49 days) after easter monday. And also this only happens if 1 of the 4 autonomous holidays for catalonia (easter monday, JUN 24, SEP 11 and DEC 26) happen in sunday.

And about this one... So, as I understand it at this moment: if any of those 4 holidays fall on Sunday, you kind of have one "unused" holiday and in this case you have this Pentecost Monday (Jun 6 this year) somewhere in May-June. But if none of those 4 were on Sunday - you don't get a day off, is that correct?
Yes, that’s correct for Catalonia. It’s the first substitute holiday for the other four.

Apparently it's no longer an issue after multiple Spain holidays fixes and refactorings.
>>> "2022-09-12" in holidays.ES(years=2022, subdiv="CT")
False

Closing this.


Add tctl next deprecation message

What was changed

Added a tctl next deprecation warning
Why?

tctl next has been moved to https://github.com/temporalio/cli
Checklist

Closes

How was this tested:

Any docs updates needed?

It might be a bit too soon to deprecate this entirely, let’s come up with a checklist in the new year and do it

It might be a bit too soon to deprecate this entirely, let’s come up with a checklist in the new year and do it

should we deprecate + remove tctl-next first and then add message for tctl v1 deprecation? I want to remove the code of tctl-next from here and remove the dependency on tctl-kit which has breaking changes

Maybe replace tctl next behaviour with printing a message saying to install Temporal CLI, with relevant brew and install.sh suggestions.


Issue with colors

Selected area of the image has a magenta tint after outpainting.

Can this color issue be reproduced with patch_match init_mode?

Yes, it is:

It goes crazy with colors when you covering the same area couple of times

I see. How about install scikit-image and then uncomment these two line in the run_outpaint
            mask=skimage.measure.block_reduce(mask,(8,8),np.max)
            mask=mask.repeat(8, axis=0).repeat(8, axis=1)

that's a known problem every repo had. I think they are fixed the red and then hey got the cyan bad... I don't know where they are know repos like hlky or automatic but they did face this problem too. Sorry for bothering I don't know code I just know what I say.

I see. How about install scikit-image and import it import skimage; then uncomment these two line in the run_outpaint
            mask=skimage.measure.block_reduce(mask,(8,8),np.max)
            mask=mask.repeat(8, axis=0).repeat(8, axis=1)

Nope, that's not working :(

that's a known problem every repo had. I think they are fixed the red and then hey got the cyan bad... I don't know where they are now known repos like hlky or automatic but they did face this problem too. Sorry for bothering I don't know code I just know what I say.

@agustincaniglia
Thanks for your information. It seems that's a bug of the current version stable diffusion.
@DenkingOfficial
If that's a bug of stable diffusion, I think I might be unable to fix it.
However, I just came up with a possible workaround: photometric correction via Poisson image editing. I will try it later.

I am having this same issue with the edge pad

Say more, each next generation enhances the contrast of each frame contour. Every new generation, periodically, the result in the whole picture becomes worse.

@DenkingOfficial
Some updates:
I just added photometric correction to suppress this color issue. Not sure if it work or not.
The current implementation only works on Linux/MacOS.

I just added photometric correction to suppress this color issue. Not sure if it work or not. The current implementation only works on Linux/MacOS.

That's amazing!
I'm gonna try it on WSL tomorrow
Thank you for your work!

Using Photometric correction replys something like:
PIE: Iter 5000, abs error [11.975403 21.68322 7.70292 ]
Ubuntu 20.04, fresh setup as discribed in your linux documentation.

Using Photometric correction replys something like: PIE: Iter 5000, abs error [11.975403 21.68322 7.70292 ]
Ubuntu 20.04, fresh setup as discribed in your linux documentation.

It's not an error. Just some metrics reported by fpie.


Issue when using super_context_menu with flutter_markdown as a child

I am using flutter_markdown (which is an official package) on a widget that also uses super_context_menu, it happens that using super_context_menu brakes the tappable links defined by flutter_markdown and
It looks like a bug.
Sample code combining the two pacakges:
ContextMenu(
  items: getContextMenuItems(),
  childElement: MarkdownBody(
    data: 'content',
    onTapLink: (text, href, title) {
      // It's never called
    },
  );
);

Which platform does this happen on?

iOS

@knopp this issue is preventing me from using the package, if you can please take a look

This is a bug in FlutterMarkdown. For some reason they destroy the gesture recognizer inside didChangeDependencies, but that method is also called during reparent when the state is preserved. Simple example to reproduce:
class _BaseContextMenuState extends State<_BaseContextMenu> {
  bool pointerDown = false;
  final key = GlobalKey();

  @override
  Widget build(BuildContext context) {
    final child = MarkdownBody(
      key: key,
      data: 'What is this [content](https://example.com)',
      onTapLink: (text, _, __) {
        print('Clicked on $text');
      },
    );
    return Listener(
      onPointerDown: (event) {
        setState(() {
          pointerDown = true;
        });
      },
      onPointerUp: (event) {
        setState(() {
          pointerDown = false;
        });
      },
      child: pointerDown
          ? ColoredBox(
              color: Colors.green,
              child: child,
            )
          : child,
    );
  }
}

Reported the issue here: https://github.com/flutter/flutter/issues/150558

If somebody gets to this issue i changed flutter_markdown for markdown_widget and everything works fine


Stop reporting 404s as errors

Does this mean don't log 404 errors so they aren't emailed to support? If so, should just have to check e.code in view_functions/log_application_errors() and only log if it's not 404.

That sounds great. Per @migurski's suggestion, I suspect all 400-class errors can be ignored, but it's the 404s that are making me error-blind now.

Yeah, only things in the 5XX range should generate email.
5XX = We Fucked Up / 4XX = You Fucked Up.


Avoid more timeseries warnings

LGTM. It's interesting that these warnings weren't raised for me - are you on the new pandas release?

Yeah, I'm on master for some recent groupby performance improvements for shuffles


User data never refreshes after oauth access is revoked once.

In the current system, user data refreshing completely breaks if users use the "revoke access" button. Ideally, the revoke access button should just temporarily remove that user's sign in sessions. User objects & data as is, cannot be removed due to foreign key contraints (if that's a major problem it's something I can look into.)
But yea, I just need to fix the current problem which is actually refreshing data if the user revokes, and signs back in.

I've thought a lot about this, and here's the idea I think would be best moving forward:
Move refresh_token, access_token, expires_at, and token_type from DiscordAccount and User into their own tables, DiscordOauth and OsuOauth respectively, (I am aware that this is how it used to be, after working with tokens more, it is much better to keep it seperate.)
This way, when a user removes access on the osu! dashboard, they are signed out from the website whenever their token was going to expire (or whenever can't use the access token anymore), and we just remove the oauth object from the table. Currently, a refresh/access token can't be blank, so when a token is invalid, we have to keep storing it, which leads to confusion


Fast update option - inactivate services before switching off for an SDcard update

The downtime of routing nodes should be minimized.
When changing the SDcard with many services active (especially the lengthy compilation of Electrs, RTL, JM) the node is down unnecessarily.
There could be an option in the UPDATE menu to deactivate services before switching off for the update (edit most services to off in the raspiblitz.conf).
This would prevent the the long compilation time before starting the lightning node and services can be installed again while running. (Preferably without further restarts as discussed in: https://github.com/rootzoll/raspiblitz/issues/2249)
The simplest solution is to just leave it to the advanced user to install the services manually after using the "fast update" option or could delay the provision script also (adding more complexity).

I think thats easier done by keeping that in mind with the re-factor of the non-interactive setup/update process - see #1126 I wil make a note there - that if possible the the bitcoin & lnd should start before the additional apps get installed.
I think that will slow down the recover/update process in general ... but I see the importance of keeping lightning down-time as small possible.

Ah OK .. you already did that ;)

Because its now mentioned in the #1126  .. can we close this issue?

Sure


FX_IO_ERROR

Hello,
I am trying to install FileX + LevelX in an stm32h7 microcontroller using a nor custom driver. I do have in my hardware an AT45DB641 NOR memory.
I am working it as an stand alone and also with fault tolerant enable.
My flash chip does have 4096 blocks of 2048 bytes each. i can write and read on pages of 256 bytes each.
Right now i am being able to format and open the media after doing a full reset of my chip, as i understand, putting everything to 1 (0xFF).
I can run the example that stm32 provide about creating a file etc...
My issue happens the second time i do run the code, but this time without erasing the chip.
I am getting following error from levelx: LX_SYSTEM_INVALID_BLOCK
and from filex: FX_IO_ERROR.
My code is as follows:
nor_custom_driver
#ifndef LX_DIRECT_READ
#ifndef NOR_SECTOR_BUFFER_SIZE
#define NOR_SECTOR_BUFFER_SIZE 512
#endif
static ULONG nor_sector_memory[NOR_SECTOR_BUFFER_SIZE];
#endif
UINT  lx_stm32_nor_custom_driver_initialize(LX_NOR_FLASH *nor_flash)
{
UINT ret = LX_SUCCESS;
ULONG total_blocks = 0;
ULONG words_per_block = 0;
/* USER CODE BEGIN Init_Section_0 */
total_blocks = _45DBXX_ACTUALBLOCKS;
words_per_block = _45DBXX_BLOCKBYTES / sizeof(ULONG);
nor_flash->lx_nor_flash_base_address = _45DBXX_STARTADD;
/* USER CODE END Init_Section_0 */
nor_flash->lx_nor_flash_total_blocks    = total_blocks;
nor_flash->lx_nor_flash_words_per_block = words_per_block;
/* USER CODE BEGIN Init_Section_1 */
/* USER CODE END Init_Section_1 */
nor_flash->lx_nor_flash_driver_read = lx_nor_driver_read;
nor_flash->lx_nor_flash_driver_write = lx_nor_driver_write;
nor_flash->lx_nor_flash_driver_block_erase = lx_nor_driver_block_erase;
nor_flash->lx_nor_flash_driver_block_erased_verify = lx_nor_driver_block_erased_verify;
#ifndef LX_DIRECT_READ
nor_flash->lx_nor_flash_sector_buffer = nor_sector_memory;
#endif
/* USER CODE BEGIN Init_Section_2 */
/* USER CODE END Init_Section_2 */
return ret;

}
static UINT lx_nor_driver_write(ULONG *flash_address, ULONG *source, ULONG words)
{
UINT ret = LX_SUCCESS;
/* USER CODE BEGIN NOR_DRIVER_WRITE */

uint16_t size = words * sizeof(ULONG);			//	TRANSFORMAMOS LAS WORDS A BYTES
uint8_t writeBuffer[_45DBXX_BLOCKBYTES];
for (int i = 0; i < size; ++i)
{
	writeBuffer[i] = ((uint8_t *)source)[i];
}
uint16_t arrayElement = 0 ;
ULONG *localFlashAddress = flash_address;

while (size > 0)
{
    uint32_t chunk_size = (size > _45DBXX_PAGEBYTES) ? _45DBXX_PAGEBYTES : size; // Determine the size of the next chunk
    AT45dbxx_WritePage2(&writeBuffer[arrayElement], (uint16_t)chunk_size, (uint32_t)localFlashAddress);

    // Update the buffer and address for the next chunk
    arrayElement += (chunk_size);
    localFlashAddress += chunk_size ;
    size -= chunk_size;
}

/* USER CODE END  NOR_DRIVER_WRITE */

return ret;

}
static UINT lx_nor_driver_block_erase(ULONG block, ULONG erase_count)
{
UINT ret = LX_SUCCESS;

/* USER CODE BEGIN NOR_DRIVER_BLOCK  */

uint32_t at45Block = (block * _45DBXX_BLOCKBYTES) + _45DBXX_STARTADD ;
AT45dbxx_EraseBlock(at45Block);

/* USER CODE END  NOR_DRIVER_BLOCK  */

return ret;

}
static UINT lx_nor_driver_block_erased_verify(ULONG block)
{
UINT ret = LX_SUCCESS;
/* USER CODE BEGIN NOR_DRIVER_VERIFY  */

// Buffer to store the read data
uint8_t readBuffer[_45DBXX_PAGEBYTES];

// Calculate the starting address in bytes
ULONG start_address = block * _45DBXX_BLOCKBYTES + _45DBXX_STARTADD;

// Read and verify the block in chunks
for (ULONG offset = 0; offset < _45DBXX_BLOCKBYTES; offset += _45DBXX_PAGEBYTES)
{
    // Calculate the current address within the block
    ULONG current_address = start_address + offset;

    // Read a chunk of data
    AT45dbxx_ReadPage2(readBuffer, _45DBXX_PAGEBYTES, current_address);

    // Verify that all bytes in the chunk are 0xFF
    for (ULONG i = 0; i < _45DBXX_PAGEBYTES; ++i)
    {
        if (readBuffer[i] != 0xFF)
        {
            ret = LX_ERROR; // Block is not fully erased
            break;
        }
    }

    // Break out of the loop if an error is detected
    if (ret != LX_SUCCESS)
    {
        break;
    }
}

/* USER CODE END  NOR_DRIVER_VERIFY  */

return ret;

}

UCHAR             media_memory[512];
UCHAR             media_buffer[512];
ULONG             detected_errors;
UCHAR             sratch_memory[4096];
/* Define FileX global data structures.  */
FX_MEDIA        nor_flash_disk;
FX_FILE         fx_file;
ULONG fault_tolerant_memory[3072 / sizeof(ULONG)];
and my filex code is:
UINT MX_FileX_Init(VOID)
{
UINT ret = FX_SUCCESS;
/* USER CODE BEGIN MX_FileX_Init */
/* USER CODE END MX_FileX_Init */
/* Initialize FileX.  */
fx_system_initialize();
/* USER CODE BEGIN MX_FileX_Init 1*/
/* USER CODE END MX_FileX_Init 1*/
return ret;
}
void MX_FileX_Process()
{
/* USER CODE BEGIN fx_app_thread_entry 0 */
UINT status;
ULONG available_space_pre;
ULONG available_space_post;
ULONG bytes_read;
CHAR read_buffer[32];
CHAR data[] = "This is FileX working on STM32";
uint8_t err = 0 ;
err = 0x80;

 do{
	err = AT45dbxxx_Dataflash_ReadStatus(&_45DBXX_SPI);
 }while(err == 0x80);

  AT45dbxx_EraseChip();

status =  fx_media_format(&nor_flash_disk,
						fx_stm32_levelx_nor_driver,   // Driver entry
						(VOID*)CUSTOM_DRIVER_ID, // Device info pointer
						(UCHAR*)media_memory,                 // Media buffer pointer
						sizeof(media_memory),         // Media buffer size
						"NOR_FLASH_DISK",             // Volume Name
						1,                            // Number of FATs
						32,                           // Directory Entries
						0,                            // Hidden sectors
						_45DBXX_ACTUALBLOCKS,      		  // Total sectors
						512,           // Sector size
						1,                            // Sectors per cluster
						1,                            // Heads
						1);                           // Sectors per track

 status =  fx_media_open(&nor_flash_disk, "FX_LX_NOR_DISK", fx_stm32_levelx_nor_driver,(VOID*)CUSTOM_DRIVER_ID , media_buffer, sizeof(media_buffer));

 status = fx_media_check(&nor_flash_disk, sratch_memory, 4096,
		FX_FAT_CHAIN_ERROR |
		FX_DIRECTORY_ERROR |
		FX_LOST_CLUSTER_ERROR, &detected_errors);

  status = fx_fault_tolerant_enable(&nor_flash_disk, fault_tolerant_memory, sizeof(fault_tolerant_memory));

  if (status != FX_SUCCESS)
  {
    Error_Handler();
  }

  status =  fx_media_space_available(&nor_flash_disk, &available_space_pre);

  /* Check the get available state request status.  */
  if (status != FX_SUCCESS)
  {
    Error_Handler();
  }

  status =  fx_file_create(&nor_flash_disk, "STM32.TXT");

  /* Check the create status.  */
  if (status != FX_SUCCESS)
  {
    /* Check for an already created status. This is expected on the
    second pass of this loop!  */
    if (status != FX_ALREADY_CREATED)
    {
      /* Create error, call error handler.  */
      Error_Handler();
    }
  }
  status =  fx_file_open(&nor_flash_disk, &fx_file, "STM32.TXT", FX_OPEN_FOR_WRITE);

  status =  fx_file_seek(&fx_file, 0);

  status =  fx_file_write(&fx_file, data, sizeof(data));

  status =  fx_file_close(&fx_file);

  status = fx_media_flush(&nor_flash_disk);

  status =  fx_file_open(&nor_flash_disk, &fx_file, "STM32.TXT", FX_OPEN_FOR_READ);

  status =  fx_file_seek(&fx_file, 0);

  status =  fx_file_read(&fx_file, read_buffer, sizeof(data), &bytes_read);

  status =  fx_file_close(&fx_file);

  status =  fx_media_space_available(&nor_flash_disk, &available_space_post);

  status =  fx_media_close(&nor_flash_disk);

  if (status != FX_SUCCESS)
  {
    /* Error closing the media, call error handler.  */
    Error_Handler();
  }

  while(1)
  {

//	    BSP_LED_Toggle(LED_GREEN);
//	    tx_thread_sleep(40);
}
}
I really dont understand what is happening, i am even doing a direct read with my memory functions and i am seeing that the text and file name is present in the memory... is this something someone can help me with?

Hello,
This sounds similar to the problem I have. Though I am not using FileX + LevelX in standalone, but with ThreadX. To describe it shortly: I can use the media (NOR Flash over SPI) without any problems if I have written files or have it formatted in the same session. But when I restart the microcontroller (STMH5), it can read the file names of previously created files, but fails in reading their properties. The file handle then either has 0 or max value for each variable. This means that I can "open" files, but cannot read them if they have been created before a shutdown.
Similarly, at the beginning the same kind of problem appeared with opening the media, though that kind of disappeared after formatting it 10 or so times.
Not sure if this is the same problem, but have you checked what your file or media handles look like when/after your opening them?

Hello,
This sounds similar to the problem I have. Though I am not using FileX + LevelX in standalone, but with ThreadX. To describe it shortly: I can use the media (NOR Flash over SPI) without any problems if I have written files or have it formatted in the same session. But when I restart the microcontroller (STMH5), it can read the file names of previously created files, but fails in reading their properties. The file handle then either has 0 or max value for each variable. This means that I can "open" files, but cannot read them if they have been created before a shutdown. Similarly, at the beginning the same kind of problem appeared with opening the media, though that kind of disappeared after formatting it 10 or so times.
Not sure if this is the same problem, but have you checked what your file or media handles look like when/after your opening them?

Hello @m1ndbr34ker
I have been discussing this topic in the following:
https://github.com/STMicroelectronics/x-cube-azrtos-h7/issues/35
still not figured what is going on that prevent me to have this done in the SPI flash. If you can add your thoughs there, maybe we can reach a solution :)
Greetings


Chat - Unable to paste content via CMD+V while context menu is open

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to any chat
Right click on any message
Click Copy to clipboard
Right click on any message to open context menu
Paste the content via CMD+V while the context menu is open

Expected Result:
User should be able to paste the content in the composer while context menu is still open (production behavior)
Actual Result:
User is not able to paste the content in the composer while context menu is still open
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a2377a2b-550b-4bf1-8aec-a8a27cbe8d2f
View all open jobs on GitHub

@carlosmiceli  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

I think this is the PR that we need to fix/revert: https://github.com/Expensify/App/pull/39520/files cc @jnowakow @adamgrzybowski @fedirjh @roryabraham anyone knows what the issue may be and can fix it? There's a lot of code in that PR so ideally someone with more context can take this.

It's not letting me copy to the clipboard at all, and CMD+V is pasting something else/previous:
https://github.com/Expensify/App/assets/1166066/2fbddc15-0904-43b2-b5b4-c6234796fd4f

Ok, will jump in.

Haven't been able to figure this one out yet (very unfamiliar with these components and logic) and I have to leave. @jnowakow @adamgrzybowski @fedirjh @roryabraham please jump in if you see this and it's still blocking, thank you! 🙏

@lanitochka17 it seems that this PR partially solves the problem. There's a problem that the cursor doesn't move to the end of the copied text.
https://github.com/Expensify/App/assets/56261019/f122f4a7-baba-476c-962d-2897fb5d2dc4
https://github.com/Expensify/App/assets/56261019/f7ec89a4-0325-4202-963b-c3dc0951f142
I don't know if this is a big problem. I checked all messengers that I had access to and none of them is allowing to paste text while context menu is open. Here is example from slack:
https://github.com/Expensify/App/assets/56261019/bb73bae7-9b7b-4dbe-ae67-ca859e195b97

@jnowakow Thank you! The thing is that in production it is possible to paste while context menu is open, so there should be something else that must be changed... Did you test it in main prior to your PR?

@mountiny @ishpaul777 @jnowakow Removing deploy blocker because it's such an edge case, but will keep it as a daily bug until it's solved. Sounds good?

@ishpaul777 when you open context menu and doesn't click anything in it you can paste:
https://github.com/Expensify/App/assets/56261019/0220750b-3da6-46f0-9b65-08d85257ba76
But the cursor isn't moved to the end of the line so it doesn't look good.

I believe the cursor positioning could be related to the same root cause as this one: https://github.com/Expensify/App/issues/42216

@ishpaul777 Gotcha, is it ok to go ahead and close it then or is there something else that should be done in terms of contributor compensation?


Add makefile targets to run serials and parallel e2e tests

The e2e test framework keeps track of tests that are safe to run
concurrently and which must be run serially.
For example, tests that focus on scanning and don't interfere with each
other are safe to run in parallel. Tests that apply remediations to the
cluster impact other tests that assert specific checks or outcomes from
a scan.
We typically lump all these tests into a single run using make e2e and
ensure the concurrent tests are run first, followed by the serial tests.
By adding separate makefile targets, we're making it easier for
contributors to run a group of tests, instead of the whole suite,
shortening the feedback loop. We can also use this in CI and create
separate jobs, running parallel tests and serial tests on different
clusters, speeding up CI reporting time. It's also easier to see, at a
glance, if a particular set of tests is failing consistently.
This change also adds a layer of abstraction between contributors and
the internal details of the tests, giving us more flexibility to evolve
the tests and reorganize them as we see fit without as much disruption
to contributors.

Proposing this in CI here - https://github.com/openshift/release/pull/36941

added the labels that prow wants


Provide ConvDR runs for comparison

Dear authors,
thank you for this really interesting work and publishing your code.
I would like to ask whether it is possible to provide the ranking files (output) for ConvDR published in the Sigir paper. I am working on the same domain, but I am having problems creating the ANCE index in the machine Im using.
Specifically, it would be helpful for me to have the runs for CAsT 19,20 (and 21, if available) datasets, for (a) both the original ConvDR model, as well as (b) the "zero-shot" variant introduced.
PS: Also, one clarification question: to my understanding, the zero-shot variant is simply original query + ANCE, right?
Thank you (and happy Chinese new year!)

Oh, I just found the google drive link in the readme.md
Is it possible however, to update with Y3 results (CAsT'21)?
I assume raw_ance is the zero-shot model then right?


Add indicator if the track has not been reviewed

The tracks which are not reviewed are now displayed with (customizable) icon and color.
Closes #190

Windows manual test ✔

Linux manual test ✔

macOS manual test ✔


ScriptUtils parsing failed when using single line comment within table DDL

Hello,
the the handling of comments within table ddl is broken.
Using single line comment like below breaks the parsing logic:
create table businessobject (
  businessobject_id integer not null
    constraint pki_businessobject primary key
  ,
  datatype_id           integer not null
   -- constraint fk_businessobject_datatype references catalog
  ,
  creation_date         timestamp with time zone default now() not null
);

Parsed SQL to flush:
create table businessobject ( businessobject_id integer not null constraint pki_businessobject primary key , datatype_id integer not null

Using multine comment in one row works:
create table businessobject (
  businessobject_id integer not null
    constraint pki_businessobject primary key
  ,
  datatype_id           integer not null
   /* constraint fk_businessobject_datatype references catalog */
  ,
  creation_date         timestamp with time zone default now() not null
);

Parsed SQL to flush
create table businessobject ( businessobject_id integer not null constraint pki_businessobject primary key , datatype_id integer not null , creation_date timestamp with time zone default now() not null)

The affected code is part of method public static void splitSqlScript

Hi! Could you give more context about how you find this issue? It seems like you forget to provide "end of line" symbol in the given query.
Trying to reproduce your case I found that this java code works fine:
        String script = "create table businessobject ( " +
            "businessobject_id integer not null " +
            "constraint pki_businessobject primary key " +
            ", " +
            "datatype_id           integer not null" +
            "-- constraint fk_businessobject_datatype references catalog \n" +
            ", " +
            "creation_date         timestamp with time zone default now() not null);";

         // split and check is ok


Remove unused deps

Removes unused dependencies from tedge_utils and mqtt_channel.
Followup for #1313

Sure! :laughing: I'm very fast, especially with such no-brainers like this!


Increase test timeout

The following test takes 5.5 min (in my environment) and times out, when CUPY_TEST_FULL_COMBINATION=1 is set.
FAILED cupy_tests/math_tests/test_arithmetic.py::TestUfunc::test_casting_out_unsafe

https://ci.preferred.jp/cupy.linux.cuda114/76501/

Jenkins, test this please.

Jenkins CI test (for commit 8f918b686a6e3b5832d06c968a2ca48ad6626cc3, target branch master) succeeded!


SIL: fix problems in findJointPostDominatingSet and some refactoring

dead-end blocks (= blocks which eventually end up in an unreachable):

We cannot just ignore all dead-end blocks. This causes crashes for some corner cases (see the "infinite_loop_and_unreachable" test case). Instead just handle the common case of a simple single dead-end block - like we do in DestroyHoisting.
For other (more complex) dead-end control flows, the analysis is not incorrect. In worst case we end up inserting a not-needed destroy instruction.

sortUnique

I restructured the code a bit so that sortUnique is not needed anymore. sortUnique on pointer arrays can result in non-deterministic behavior.

lower_bound

Also, using lower_bound on a vector is not good in this function, because it can result in quadratic behavior. Though, in practice, there are only very few elements in the vector. So it's more a theoretical thing.
The restructuring made the code a bit simpler, e.g. beside the worklist, no other vectors are needed anymore.
Also in this PR: remove the JointPostDominanceSetComputer helper struct.
Instead make findJointPostDominatingSet a stand-alone function.
There is no need to keep the temporary SmallVector alive across multiple calls of findJointPostDominatingSet for the purpose of re-using malloc'ed memory. The worklist usually contains way less elements than its small size.

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 409c82a7aa3b559b73c2b06b9b21cf30d61661d9

@swift-ci test

@swift-ci test windows platform

ErikE and I were talking about some other changes here. Around transitive dead end blocks. The implementation change here will be more conservative. I wouldn't be surprised by using the dead end blocks utility we can get a more aggressive result but given that this is fixing a real issue. I want to merge it/iterate later.

@swift-ci test windows platform

Some sort of problem in the windows build that isn't from this (has something to do with parsing or the system itself). Merging!


refactor: remove some deprecated APIs

ComponentFactoryResolver 需要等 https://github.com/angular/components/pull/27427


PureScript on Docker guide

Hi, I'm in the process of cleaning up the purescript wiki a bit, and I think you wrote a page titled "PureScript on Docker" originally. I don't think it quite fits with what we're aiming to turn the wiki into, so I've preserved it in a gist in case you ever wanted to do anything with it. If not, feel free to close and ignore this. Cheers!
https://gist.github.com/hdgarrood/65bef79ccdc8dcc9941d00de369372f1

Cheers. That content looks really out of date anyway. I forked it into my account for posterity.


optimize fzf_default_completion binding

I spent the past few hours doing a bit of yak shaving on speeding up my zsh startup time and discovered that one of the biggest bottlenecks was this chunk of code in shell/completion.zsh! 😮
The slowdown is a result of launching the grep and awk programs to set the fzf_default_completion environment variable. I rewrote the code to use only zsh built-ins and got a reasonable speedup! Here are the results:
All times in microseconds (us), 100 samples each
=====
Control       -- Mean: 9035.12, Stddev: 326.39
Experiment    -- Mean: 5979.47, Stddev: 372.748

Here is a gist of the script I used to profile the control (i.e. junegunn master) vs the experiment (i.e. this PR).
FYI: here are the 25 slowest lines evaluated via source ~/.fzf.zsh on junegunn master in descending order. Times are in milliseconds here, not microseconds.
04.17709351: /Users/Aleks/.fzf/shell/completion.zsh:185> fzf_default_completion=expand-or-complete-with-indicator
00.76699257: /Users/Aleks/.fzf/shell/completion.zsh:23> declare -f _fzf_compgen_dir
00.33903122: /Users/Aleks/.fzf.zsh:19> source /Users/Aleks/.fzf/shell/key-bindings.zsh
00.22387505: /Users/Aleks/.fzf.zsh:15> source /Users/Aleks/.fzf/shell/completion.zsh
00.18501282: /Users/Aleks/.zshrc:311> source /Users/Aleks/.fzf.zsh
00.12683868: /Users/Aleks/.fzf.zsh:3> [[ ! /Users/Aleks/.rbenv/shims:/Users/Aleks/.pyenv/shims:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/git/bin:/usr/local/go/bin:/usr/texbin:/usr/local/opt/go/libexec/bin:/Users/Aleks/dotfiles/bin:/Users/Aleks/dotfiles/bin/darwin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin:/Users/Aleks/.fzf/bin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin:/Users/Aleks/go/bin:/usr/local/berkeley_upc/bin == */Users/Aleks/.fzf/bin* ]]
00.09393692: /Users/Aleks/.fzf/shell/completion.zsh:188> bindkey '^I' fzf-completion
00.08702278: /Users/Aleks/.fzf/shell/completion.zsh:14> declare -f _fzf_compgen_path
00.07915497: /Users/Aleks/.zshrc:310> FZF_START_TIME=1465686345.8801810741
00.05602837: /Users/Aleks/.fzf/shell/key-bindings.zsh:52> bindkey '^R' fzf-history-widget
00.04696846: /Users/Aleks/.fzf.zsh:9> [[ ! :/Users/Aleks/.fzf/man == */Users/Aleks/.fzf/man* ]]
00.04601479: /Users/Aleks/.fzf/shell/completion.zsh:187> zle -N fzf-completion
00.04315376: /Users/Aleks/.fzf.zsh:15> [[ 059CDEJNQRTWXZghimx == *i* ]]
00.03910065: /Users/Aleks/.fzf/shell/key-bindings.zsh:3> [[ 059CDEJNQRTWXZghimx == *i* ]]
00.02384186: /Users/Aleks/.fzf/shell/key-bindings.zsh:36> bindkey '\ec' fzf-cd-widget
00.02193451: /Users/Aleks/.fzf/shell/completion.zsh:184> [ -z '' ']'
00.02193451: /Users/Aleks/.fzf/shell/key-bindings.zsh:26> bindkey '^T' fzf-file-widget
00.02098083: /Users/Aleks/.fzf/shell/key-bindings.zsh:25> zle -N fzf-file-widget
00.01907349: /Users/Aleks/.fzf/shell/key-bindings.zsh:35> zle -N fzf-cd-widget
00.01811981: /Users/Aleks/.fzf/shell/key-bindings.zsh:51> zle -N fzf-history-widget

This PR speeds up the slowest line by about 4x, knocking it down to just under 1ms on average on my machine.

👍


CharacteristicBase class should override Equals and Hashcode

The CharacteristicBase class does not override the Equals and Hashcode method. Realized that when I was using a HashSet to keep track of Characteristics.
I guess using the internal Guid as the basis for the Equals and Hashcode implementation should work.

Ok thanks, but we should do it for all objects :)

I can take a crack at doing this
Get Outlook for Android
On Thu, Aug 18, 2016 at 12:43 AM -0700, "Sven-Michael Stübe"<EMAIL_ADDRESS>wrote:
Ok thanks, but we should do it for all objects :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Wouldn't using the Guid make all characteristics from similar devices be equal? i.e. if I have multiple sport trackers that have the same service and characteristic profile, each of the "write" characteristics would be seen as equal, even though their behavior would be very different (data would be written to different physical devices).
I think that what would uniquely identify a characteristic (for equality purposes) would be the set of:

Guid of Characteristic
Guid of its Service (this one is least needed, actually. See below)
Guid of Device

Usual convention could probably get rid of the Service, since most services have characteristics with unique IDs in them. When using a short characteristic ID, the ID gets plugged into the long service ID, making it unique. However, as far as I know, it's not illegal to use a custom long characteristic ID, and to use that same custom long characteristic ID in different services, though I have not seen this ever happen.
I think that the breakdown of IEquatable is similar to:

Device -> Guid of device (I remember writing this one up either late last year or early this year, so it might already exist in the code.
Service -> Guid of device + Guid of Service
Characteristic -> as paragraph above

@adolgov : You are right. The hierarchy needs to be taken into account.


error message

I receive an error message

Please tell me what I have to do to make this work.

I have updated the firmware for Nano S and the wallet for Komodo, yet I still get this message.


Support the new 8.0 validation attributes

https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8#data-validation
https://devblogs.microsoft.com/dotnet/announcing-dotnet-8-preview-2/#system-componentmodel-dataannotations-extensions

See https://github.com/dotnet/efcore/issues/30754, which should result in a min length constraint.

New attributes:

AllowedValues
Base64String
DeniedValues
Length

New properties on Range:

MaximumIsExclusive
MinimumIsExclusive

New properties on Required:

DisallowAllDefaultValues

Implemented these, with the exception of [Base64String] which is complex (and probably not very useful for databases), opened #138 to track.


Update user quick-start readme and fix scripts for OpenAI

Motivation and Context

Why is this change required?  To make onboarding smoother.
What problem does it solve?  The quick-start local deployment steps were difficult to follow.
What scenario does it contribute to? Beginners trying out Chat Copilot locally.
If it fixes an open issue, please link to the issue here. Unknown.

Description
Main Chat Copilot Readme is updated to present a quick-start beginner use case.  This is the local deployment of Chat Copilot, not an Azure deployment.  It removes the redirect for the scripts, and formats instructions to improve readability.
Bash and PowerShell scripts are also fixed to use environment variable ASPNETCORE_ENVIRONMENT, which is necessary for appsettings.json override (by appsettings.Development.json) when running the backend for OpenAI.
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

PowerShell for OpenAI tested.

@momuno @alliscode Closing since this is no longer the target repo for this change!


Better to update the record of the 'Release Notes -> Sub-Directory Prefix Search in File Shares' part since the string 'Search by prefix' has been updated

Storage Explorer Version: 1.28.0
Build Number: 20230202.3
Branch: rel/1.28.0
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.2 (MacBook Air Intel)
Architecture: ia32/x64
How Found: From running test case
Regression From: Not a regression
Steps to Reproduce

Open storage explorer -> Click 'Help -> Release Notes'.
Go to the 'Sub-Directory Prefix Search in File Shares' part.
Observe the search string in the record.
Check whether the string is 'Filter by prefix'.

Expected Experience
The string is 'Filter by prefix'.
Actual Experience
The string is 'Search by prefix'.

I'm impressed y'all noticed this.

Verified this issue on the rel build 20230203.7. Fixed. So, we are going to close it.


Italian traslation

Hello.
How to find translation instruction? I would translate the site in italian languages
King regards

Ciao @Fabryprog the current website will be soon replaced with the new one. Join the channel #monero-it on monero's slack, there we organize and post updates

ok


we should use parentheses here

Motivation:
we should use parentheses here
Modification:
Modify comments
Result:
Looks more comfortable

@luozongle thanks

@luozongle thanks

You're welcome. I've been excited about submitting code for Netty for several days, although it's just a comment


Download file in headless mode

Hi, thanks a lot for your package.
When trying to download a file in headless mode, nothing happens. According to this issue it is possible to set download behavior, for example:
 def enable_download_in_headless_chrome(self, browser, download_dir):
        #add missing support for chrome "send_command"  to selenium webdriver
        browser.command_executor._commands["send_command"] = ("POST", '/session/$sessionId/chromium/send_command')

        params = {'cmd': 'Page.setDownloadBehavior', 'params': {'behavior': 'allow', 'downloadPath': download_dir}}
        browser.execute("send_command", params)

How to enable this feature using chromedp?

My fault that I can't read goDoc
For getting files in headless mode, execute the function:
func allowHeadlessDownload() chromedp.Tasks {
	return chromedp.Tasks{
		chromedp.ActionFunc(func(ctxt context.Context, h cdp.Executor) error {
			err := page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath(".").Do(ctxt, h)
			if err != nil {
				return err
			}
			return nil
		}),
	}
}

Issue could be closed

Please note that you could just do this:
return chromedp.Tasks {
    page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath("."),
}

The Action interface (which is what Tasks satisfies) is satisfied by the return value of WithDownloadPath.

@kenshaw  Is it possible to track, that downloading was finished?

the download progress is trackable by adding Listener to chromedp.
done := make(chan bool)

chromedp.ListenTarget(clone, func(ev interface{}) {
	if evt, ok := ev.(*page.EventDownloadProgress); ok {
		fmt.Printf("current download state is %s\n", evt.State.String())
		if evt.State == page.DownloadProgressStateCompleted {
			done <- true
		}
	}
})
chromedp.Run(clone, chromedp.Tasks{
	page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath("."),
	chromedp.Navigate(downloadURL),
})
<-done
fmt.Println("download finished")

the download progress is trackable by adding Listener to chromedp.
done := make(chan bool)

chromedp.ListenTarget(clone, func(ev interface{}) {
	if evt, ok := ev.(*page.EventDownloadProgress); ok {
		fmt.Printf("current download state is %s\n", evt.State.String())
		if evt.State == page.DownloadProgressStateCompleted {
			done <- true
		}
	}
})
chromedp.Run(clone, chromedp.Tasks{
	page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath("."),
	chromedp.Navigate(downloadURL),
})
<-done
fmt.Println("download finished")


Traits and mock data for algod/kmd/indexer?

Someone asked a while ago for something to be able to mock data to do frontend work. Should we create traits for these services and maybe create a new package (could be here or in a separate repo) that delivers mock data?

Sounds interesting, could you post a snippet of how these mocks would look like? Maybe it is something for a separate repo, but we can reference or even use it here.

Hmm just "fake" accounts, transactions etc. I think that we should only add the traits.

Actually, this is a bad idea. These traits should be added by users, if they want to create an abstraction layer over Algonaut.


added 'target' parameter to mzPrecursors filter...

...for telling it to filter on 'selected ion m/z' (the default) or 'isolation window target m/z'

Looks good. Thanks, Matt.


Connecting to persisted rooms won't recognize new rooms

Currently there is an issue in lita where it won't add a new room to persisted rooms because it doesn't know about that room yet. Basically what happens is we call robot.join(room) and this happens:
    def join(room)
      room_object = find_room(room)

      if room_object
        Lita.redis.sadd("persisted_rooms", room_object.id)
        adapter.join(room_object.id)
      else
        adapter.join(room)
      end
    end

This calls find_room which ends up calling 'Room.fuzzy_find(room_or_identifier)' which calls these two methods:
      def find_by_id(id)
        metadata = redis.hgetall("id:#{id}")
        new(id, metadata) if metadata.key?("name")
      end

      def find_by_name(name)
        id = redis.get("name:#{name}")
        find_by_id(id) if id
      end

The problem is that if the room you are trying to join is not in redis then this will say that the room object can't be found and therefore find_room will return nil and therefore Lita will not put that room into persisted rooms. This breaks the new persisted rooms functionality as far as I can tell*.
To fix this I think we may need to add a slight modification to room.find_by_name or room.find_by_id, alternatively we could blindly add those strings into redis and then have the adapter rescue on a failed join. But I wanted to open this up for discussion so we could get it fixed.
(*Note, I am testing all of this with lita-hipchat)

I'd say this is a lita-hipchat issue. Room objects should be created as soon as the adapter learns about them (when it first connects, looking at the roster, etc.)


⚠ Panoramas has degraded performance

In 36336bd, Panoramas ($SITE_URL_PANORAMAS) experienced degraded performance:

HTTP code: 200
Response time: 4278 ms

Resolved: Panoramas performance has improved in 7ddf194 after 6 minutes.


Selected Bar misplacement when changing the tabs

I'm having an issue, when I select any tab, the selected bar goes back and then gets changes as shown in video, kindly provide me some solution to it.
Also when I select my tabs, the selected strip does not move to new one.
Kindly provide me solutions.
Link:
https://youtu.be/ioXFIiRI888

@nayzak any help.

@santiagofm Hey can you please help me out as I'm stuck with this

Same issue here

Any solution found?


Target Sum Triplets in Golang

Have you read the Contributing Guidelines on Pull Requests?
Yes, I have read the Contributing Guidelines on Pull Requests.
Description

Added implementation of the program for Target Sum Triplets in Golang

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
issue #585  for Go language

Looks good to me, just remove unnecessary line breaks.

Hey @atarax665
I have made the changes.
could you please review this :)


Implemented libgdx native bullet wrapper

Contains
This implements libgdx's native bullet wrapper and removed Terra bullet along with all references to javax math and instead I've replaced these instances with libgdx's math library. For the most part of lot of the logic is unchanged and I've just rewritten the internal features of each function. A lot of the function endpoints for bullet have been slightly changed, but I'm still not sure how this will behave for the scope of the entire project.
In a separate pull request I should provide the modified libgdx library. An Artifactory build of this will need to be made along with updating gradle. I've statically listed this out in gradle which is not ideal but should be usable for the time being.
How to Test
You will have to include the modified libgdx library into lib and install the maven libraries from there (mvn install). Memory usage will have to be watched since I'm not sure that I've cleaned up all the resources.

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Uh oh, something went wrong with the build. Need to check on that

Just merged #3199 and this isn't even conflicting with it, woo! :-)
I hope to poke around with the related build system stuff in the near future, although it isn't quite next on my list yet. With #3199 in we might actually be able to treat the different approaches like separate physics implementations, for easy comparisons and benchmarking? Could try both LibGDX physics as well as ode4j

#3432 is just an improvement on this work. we can close this and just make a ref back to this.


[Question/Feedback]: Action group notification to custom RBAC role instead of limiting to 5 built-in RBAC roles

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
It would be great to have AMBA notification using action group notification to custom RBAC role instead of 5 built-in RBAC roles
(Owner, Contributor, Reader, Monitoring Owner, Monitoring Reader)
Using Azure Bicep able to associate custom RBAC role for the action group but notifications are not received for this custom role currently.
As subscriptions will have existing role assignments with these built in roles so wanted to have a control on only specific custom role can be used for the notification in a controller & selective manner.

Hello @NavidKhan8 ,
Thanks for your feedback. I am investigating this issue and found out that you could specify custom roles in the parameter file (and they will be part of the action group). This means that AMBA-ALZ is already capable of adding custom roles to an Action Group. The problem could be with the custom role membership not being resolved to the corresponding email address.
We will investigate more and let you know.
Thanks,
Bruno.

[heart]         Navid Ulla (External) reacted to your message:

From: Bruno Gabrielli @.>
Sent: Thursday, September 26, 2024 11:11:13 AM
To: Azure/azure-monitor-baseline-alerts @.>
Cc: Navid Ulla (External) @.>; Mention @.>
Subject: Re: [Azure/azure-monitor-baseline-alerts] [Question/Feedback]: Action group notification to custom RBAC role instead of limiting to 5 built-in RBAC roles (Issue #349)
Hello @NavidKhan8https://github.com/NavidKhan8 ,
Thanks for your feedback. I am investigating this issue and found out that you could specify custom roles in the parameter file (and they will be part of the action group). This means that AMBA-ALZ is already capable of adding custom roles to an Action Group. The problem could be with the custom role membership not being resolved to the corresponding email address.
We will investigate more and let you know.
Thanks,
Bruno.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-monitor-baseline-alerts/issues/349#issuecomment-2376645472, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3GIUE3YYTITJI5MMEUL7Q3ZYPTVDAVCNFSM6AAAAABO23QW3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWGY2DKNBXGI.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @NavidKhan8 ,
we have reached out to Product Group owner to understand if this is the default/intended behavior or a bug.
We will keep you posted.
Thanks,
Bruno.

[like]  Navid Ulla (External) reacted to your message:

From: Bruno Gabrielli @.>
Sent: Friday, October 11, 2024 3:09:08 PM
To: Azure/azure-monitor-baseline-alerts @.>
Cc: Navid Ulla (External) @.>; Mention @.>
Subject: Re: [Azure/azure-monitor-baseline-alerts] [Question/Feedback]: Action group notification to custom RBAC role instead of limiting to 5 built-in RBAC roles (Issue #349)
Hello @NavidKhan8https://github.com/NavidKhan8 ,
we have reached out to Product Group owner to understand if this is the default/intended behavior or a bug.
We will keep you posted.
Thanks,
Bruno.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-monitor-baseline-alerts/issues/349#issuecomment-2407614214, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3GIUEZSLPUIAHUKU7RXDNDZ27SZJAVCNFSM6AAAAABO23QW3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGYYTIMRRGQ.
You are receiving this because you were mentioned.Message ID: @.***>

@NavidKhan8 we've had a response from the PG and they have shared the following documentation https://learn.microsoft.com/en-us/azure/azure-monitor/alerts/action-groups#email-azure-resource-manager where it states the 5 roles supported (therefore custom ones are not).
I'm sorry this isnt the answer you were looking for and would advise that you post a feature suggestion on https://feedback.azure.com/d365community for future consideration or alternatively work with your Microsoft account teams if you have these available to you.
@Brunoga-MS can we add a note into the documentation to make sure this limitation is clearly defined to make customers aware.
Thanks
Paul

Thank you for checking and for the confirmation. This feature will be helpful in enabling notifications in a controlled manner as there will be pre-existing RBAC assignments for the 5 default roles and they will also get notification.

@NavidKhan8 feel free to post back your feedback link for others to track and vote.


Around 2 percent of the corpus have missing publisher information

In the current corpus, 356 out of 13099 manifestations do not have any KBR/BnF/KB publisher. These are mainly manifestations from KBR, but also a few from KB.
Looking up a few samples in the KBR catalogue revealed that the samples should have publisher information, there seems to be something wrong in our processing pipeline.

It seems that (for KBR data) the named graph of the translations partially contains declarations of original manifestations. The samples I've found do have publisher information, but in the named graph of the originals.
In case a KBR translation has a link to its source, we often also have the title and ISBN numbers. Apparently, we have a RML mapping which creates source records based on this limited information, but in the named graph of the translations.
Similarly, we create dummy source records in case we find only a title, such that we can properly link to something via schema:translationOfWork.
For KB we do the same (they also have it like this), but we should actually store this information in a separate named graph, otherwise we also query sources of translations.
This may also partially explain #131
The issue should be fixed when we strictly split information about translations and originals into different named graphs.

There are 20 manifestations from KB who do not have a publisher even in the source data.


Allow import custom EVM collectible

PR for #149

🚀 Deployed on https://pr-150--papaya-melba-f5c160.netlify.app


Create adding-replacing-drives guide

i do not believe this is necessary, we do not really offer replacing drives. unless, of course, it's a VIP which is also rare...

done.


Add Elixir

Name: Elixir
Link: Elixir Org
Description: Elixir is a functional, concurrent, general-purpose programming language that runs on the BEAM virtual machine which is also used to implement the Erlang programming language. Elixir builds on top of Erlang and shares the same abstractions for building distributed, fault-tolerant applications.
Link to logos: Elixir's org repo

I need a vector.

here's the vector:
https://www.vectorlogo.zone/logos/elixir-lang/index.html

@Tiesco789
Unfortunately, the vectorized version is quite different from the original.

Even with a white background...


Support passing scoped package names to --scripts-version arg

create-react-app myApp --scripts-version=@myscope/react-scripts fails since getPackageName currently assumes a match of "@" at any index denotes version and strips it from the str.
Minor change to fix.

Can you squash and rebase this? The commit log is getting confusing. You don't need to keep this up to date—I'll make sure to rebase/cherry-pick before merging.

Sorry about that. Branch and commit log should be back to the original.

Thanks!


Update for 24J

For 24J, need to add allowed, ruff and algoesup to requirements, possibly other packages.

Consider also JupyterLab extensions needed. Tony lists several here.

[ ] Separate installation for macOS, Linux and Windows so that no one misses steps.
[ ] Remove allowed instructions.

Once 24J version is on repo, 23J installation instructions and script are 'lost', have to be retrieved via releases.

[ ] update custom.css and put it in right place for JupyterLab

Decided to stick with Jupyter 6, but JupyterLab 4.2.4 included in software.


Documentation: sap.m.upload.UploadSet Sample Directory Mode

OpenUI5 version:
1.113 / API Docu
Browser/version (+device/version):
Chrome
Any other tested browsers/devices(OK/FAIL):
Firefox (Fail)
URL (minimal example if possible):
https://sapui5.hana.ondemand.com/#/entity/sap.m.upload.UploadSet/sample/sap.m.sample.UploadSetDirectoryUploads
Steps to reproduce the problem:

Click on the "Toggle Buttons" File mode / Directory mode

What is the expected result?
Behaviour of UploadSet changes, toggle between direcotry true/false
What happens instead?
Behaviour of UploadSet doesn't change
Any other information? (attach screenshot if possible)
Different Names in View and Controller --> not functional
Sry if there is an other repo for the API examples

Hello @lhendrik ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Petar

Hello Team,
The changes have been made and will be available in SAP UI5 Version - 1.115.0.
Regards
Bhumika


2.1.0 is not present in CocoaPods

https://cocoapods.org/pods/ReactorKit
Still 2.0.1 😅

Hi, thanks for the inconvenience. I uploaded to the CocoaPods repo. Please feel free to re-open this issue when the issue still happens.


fix: add overContainer property to DragOutEvent

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR implements or fixes... (explain your changes)
Add overContainer property to dragOutEvent.
This PR closes the following issues... (if applicable)
#448
Does this PR require the Docs to be updated?
No
Does this PR require new tests?
Yes
This branch been tested on... (click all that apply / add new items)
Browsers:

[x] Chrome version
[x] Firefox version
[ ] Safari version
[ ] IE / Edge version
[ ] iOS Browser version
[ ] Android Browser version

Hi @zjffun , should I update the changelog file of  PR #443 to include the fix of this PR, and then tell Tsov that he should merge this PR before releasing the new version?

@bahung1221 I think we should do as you say.

Hi @tsov , this PR can be merged. When you have free time, please help us to merge it before #443 , and then we can release beta12 by merging PR #443 .
Thank you so much 🎉


Mark solution as open when we receive a new project

Fixes https://github.com/dotnet/aspnetcore/issues/36697
A few things:

I did see OnAfterCloseSolution not firing, but anecdotally it seemed like implementing IVsSolutionEvents3 made this go away. I can provide no evidence for this though :)
Yes the CPS stuff fires before OnAfterOpenSolution but that is expected. On my machine, under the debugger, however the actual dataflow event happened afterwards so I didn't see any issues, but I can totally see how I would have, if I didn't get lucky
Ultimately CPS is our "source of truth" here, since it initializes the project manager, which initializes the triggers, which is when we first get to hook up to the solution events so whilst this workaround seems a little dodgy, it's not beyond reason IMO.

Happy to discuss further though if anyone has any better ideas.

Out of curiosity why's it expected?

Maybe expected is the wrong word. Observed? You can correct me if I'm wrong, but it seemed like the CPS project host was the thing that triggered the creation of the project manager initially, so I figured that is the "entry point" as it were.

You can correct me if I'm wrong, but it seemed like the CPS project host was the thing that triggered the creation of the project manager initially, so I figured that is the "entry point" as it were.

Oh definitely right on the money there. I think I was more curious if it's expected that the CPS events would fire before the IVsSolutionEvents3 events. Smells like a project system bug to me because it'd mean anyone else in VS would have similar issues; however, I could be wrong 😄


meta(engine): Refine meta  adjust user meta isolation(part 3)

What problem does this PR solve?

Issue Number: close #6218
What is changed and how it works?

Extract 'Connection' from the client for connection pool reuse
Move  'KVExt' and other  unneccesary definition  to inner implement
Offer 'NewKVClient' and 'NewKVClientWithNamespace' for usage
Using 'ClientBuilder' to generate different kvclient
Using 'Registra' to register different kind of client build

Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/area engine

/cc @gozssky

/unhold
/status ptal

Codecov Report

Merging #6202 (a7b1045) into master (ef587e6) will decrease coverage by 0.4727%.
The diff coverage is 64.1090%.

Flag
Coverage Δ

cdc
63.7739% <67.9577%> (-0.9108%)
:arrow_down:

dm
51.9251% <49.6350%> (+0.0359%)
:arrow_up:

engine
62.0353% <56.2500%> (-0.4987%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6202        +/-   ##
================================================
- Coverage   58.4193%   57.9466%   -0.4728%
================================================
  Files           711        717         +6
  Lines         84205      83482       -723
================================================
- Hits          49192      48375       -817
- Misses        30540      30757       +217
+ Partials       4473       4350       -123

/run-all-tests

/run-verify
/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

/run-all-tests

/run-all-tests

/can-merge

@amyangfei  Give me a /can-merge if you are free. Thanks~

/can-merge

/run-leak-test


Fix for discovering the HostState

20aa3e09fb866c1b99c1d3d702f2a2f1908558af commit moved the
setHostFirmwarecondition() function call prior to the code
that connects to the mctp socket.

That led us to fail in sending the message with ENOTCONN Errno,
as demonstrated by the below strace log.

------
23:16:50.596833 connect(3, {sa_family=AF_UNIX, sun_path=@"mctp-mux"}, 11) = 0

Change-Id: Icd3a20e4bb0218517d44d14a57c0407c7b7702e2
---
23:16:50.593800 sendmsg(3, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\t\1",
 iov_len=2}, {iov_base="\200\0\3\0\0\0\0\1\0", iov_len=9}], msg_iovlen=2, msg_controllen=0,
 msg_flags=0}, 0) = -1 ENOTCONN
-----

Without this change , we would get ENOTCONN(107 errono) for the
getPLDMVersion command that pldm sends at the beginning to discover the
host state.

tested by:

when the host is off :
Response not received for the request, instance ID expired. EID = 9 INSTANCE_ID = 0 TYPE = 0 COMMAND = 3
Failed to receive a response for getPLDMVersion command, Host seems to be off

when host is Running :
Sending Msg
80 00 03 00 00 00 00 01 00
Received Msg
09 01 00 00 03 00 00 00 00 00 05 f1 f1 f0 00
Getting the response. PLDM RC = 0

Signed-off-by: Manojkiran Eda<EMAIL_ADDRESS>Change-Id: I5c7c3bc92c8654016db90855de49b7c30f161275

upstream commit : https://gerrit.openbmc-project.xyz/c/openbmc/pldm/+/46668


add anchors of subtitle in ko/docs/concepts/policy/pod-security-policy

Closes #20368

/assign @seokho-son

@seokho-son 완료했습니다. 😄

Thank you !
/lgtm
/approve


Preview is not getting close

Once I enable let g:racer_experimental_completer = 1 and spawn completion a tiny preview buffer appears on the top of the screen. When I hit enter on a item from completion menu the preview is still visible even if it's not relevant anymore.

This is Vim's feature.
If you want to close automatically:
autocmd CompleteDone * silent! pclose!

Cool. Maybe it's worth to mention it in readme right next to g:racer_experimental_completer.


error when the game starts

When i start the game the injector doesnt inject itself into the game and it gives me an error saying "Object reference not set to an instance of an object" What do I do?

Same

I have the same problem. Help please!


contrib/ansible: Fix systemd TimeoutStartSec in contrib/ansible

This fixes the issue #360 that was fixed in #365 but not inside the ansible playbook.
Signed-off-by: Julien DOCHE<EMAIL_ADDRESS>

@erikwilson Could you take a look please ? :)

Thanks for the PR @St0rmingBr4in!
Change looks good, is just updating to what is the currently the root of the repo.
Sorry for the ansible PRs piling up, I am working on getting the ansible stuff moved to another repo, would you be interested in helping to review & merge PRs?

Yeah sure I would be interested 😊

Awesome, have created a repo and copied the commits to https://github.com/rancher/k3s-ansible, do you mind closing these PRs and re-creating them there?
Have also added access for @itwars as the original creator of the ansible contrib stuff. If you two are able to help get things moving there is would be greatly appreciated, many thanks!

Excellent @erikwilson !

Yep, I'll move and close those PR 😛 Thank you


Include file, line and mfa in basic formatter metadata

Include file, line and mfa in the basic formatter metadata.
Fixes #137

Would love to see this merged in - anything I can do to help move it along?


Update the dependencies

It is mainly needed for the failure dep, I will send another patch later to update rand since it requires code changes.
Currently criterion tests pass on stable but do not build on nightly even before this update.

I've updated the dependencies. Thanks for the pull request anyway, though!


'show.bind' and 'if.bind' cannot work together with 'repeat.for'.

$parent is required to access variable in VM.
Only
 <section show.bind="!$parent.node.collapsed" repeat.for="child of node.children" >

can work.
I investigated the reason. repeat is a lifting instruction.When compiler gets such instruction, the element will be moved under a template element. So the execution context of this element is changed.  Only leverage $parent can access the variables. You can see it from https://github.com/aurelia/templating/blob/master/src/template-controller.js#L50
I tried a whole day to fix it, but failed. Seems many parts of code should be changed. So I give up.
I suggest put a warning message at https://github.com/aurelia/templating/blob/master/src/view-compiler.js#L217. It say 'repeat' is a 'lifting instrustion'. Please don't use it with other behaviors.

Yes, we will certainly add a warning about that. Apologies for the frustration you experienced. If you think of our if and repeat the same way as if and for in JavaScript, it will make sense why these can't be on the same element. They each need to be declared with their own blocks. So, the same is true with our templating engine. We hope to get rid of the need for $parent after some revisions to the binding system, so that should improve. We can add the error message as you suggest as well. Part of the reason we aren't yet RTM is because we do want to put these kinds of meaningful error messages into the system to help people along. Thanks for your patience!

I think we'll be able to fix this by removing the need for $parent eventually. That should be coming as part of a set of improvements to the binding engine. We are tracking that in another issue. Thanks!


hide icon from tray

it would be cool if you could hide the application icon from the tray.

Duplicate #9526


added responsive UI elements using tailwindcss

Added several layers of responsive design elements for scaling with smaller devices

great work , super!


Domain does not have an SPF record

when i query my domain i am told that a SPF record does not exist when it does.

Hi @Murray-Harris,
Thanks for your question. Are you in a split DNS environment? If so, please use the -Server parameter with an external DNS Server to check the SPF-record.

No response, issue closed.


Add Button: "Close all sessions beside current"?

So you can close all session beside the current with one click. Sometimes you have many sessions which are no longer used.
btw I like your projects :)

Added in 57273e09. Will land in the next version.


Error post cocapods installtion

Hey,
I have been trying to use QorumLogs for a project of mine and I installed using cocoapods(0.39.0).
After install when I try to build the project I get following errors.

Following are the content of my cocoapods file
target 'MyApp' do
  source 'https://github.com/CocoaPods/Specs.git'
  platform :ios, '8.0'
  use_frameworks!
  pod 'Alamofire', '~> 3.1.3'
  pod 'SwiftyJSON', :git => 'https://github.com/SwiftyJSON/SwiftyJSON.git'
  pod 'QorumLogs'
end

I am really sorry if its a basic issue I am new to iOS development

You may have added a random comma in the code somewhere?
Are the other pods working?

Sorry my bad. I was supposed to upgrade to El Captain and latest xcode.


Nuget Package Manager tool for VS Code users

Is your feature request related to a problem? Please describe.
Yes since the Visual Studio for Mac does not support .NET 8 I had to use VS code with C# Devkit which is pretty great. The only feature gap that I feel is when trying to manage a nuget package from the VS Code editor. There are extensions but they are not good and could end up with a corrupted .csproj file.
Also, the current alternative is to use dotnet CLI to add and remove nuget packages on Mac and it's very time-consuming and has minimal capabilities compared to the features we have in Visual Studio Package Manager.
Describe the solution you would like
Would like a nuget package manager proper extension from Microsoft or better alternatives to the dotnet CLI to make this a bit easier
Applicable Scenarios
When managing nuget packages from VS Code, adding, removing, upgrading
Describe alternatives you've considered
All the extensions that I tried are not good and not reliable
dotnet CLI has very limited capabilities
Additional context
NA

Looks like there's already an issue for this on the devkit side here - https://github.com/microsoft/vscode-dotnettools/issues/62
Closing this as a duplicate.


"Arieșu de Câmp" and "Colțirea" are listed in the drop-down menu

Description:
"Arieșu de Câmp" and "Colțirea" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Arieșu de Câmp" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Arieșu de Câmp, MARAMUREȘ (Ardusat)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Colțirea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Colțirea, MARAMUREȘ (Ardusat)".