Feature/add domain check before sending init message to parent #52

add domain check before sending init message to parent #52

@bluepnume Hey, this change should prevent child from sending any msg to parent. Its currently not very graceful experience since child was already rendered.  But that's what I understood from #52 anyway, that we need to prevent sending init to parent. I hope my understanding was correct.

Actually I'm doing a small change here. If the item in the array is a string, its better to do a full string match instead of excpecting the string to be a RegEx string...this will give people a simpler string interface while RegEx still supported by passing Regex items.

@bluepnume Hey mate,
Do you know when you plan to push this in? I'm happy to change anything here :)

Hey @harouny, just out of the country on vacation right now. Back on the weekend -- I'll give this a proper review then. Thanks so much for the contribution!

@bluepnume
Sorry, didn't know that since you are already contributing to discussions.
Enjoy your vacation and don't check your email :)

Added a few comments. Could you also add a test or two for this case?

@bluepnume I want to add couple of happy path tests, do you know what will getParentDomain() return in test?

You can set window.mockDomain to mock://something and xcomponent/post-robot will all pick it up

Hey @bluepnume
Looks like window.mockDomain is not enough in my case. I was getting this error:
ERROR LOG: 'xc_test_component_parent_domains_string_match_unexpected_listener_init', Object{origin: 'http://localhost:9876', domain: 'mock://foo.com', timestamp:<PHONE_NUMBER>115, windowID: '7d58e48fae', pageID: '5407a6bcce'}

I think the problem in origin check?
I ended up for now relying my test on running on http://localhost:9876  based on karma config. Will be better to avoid that.

Also just had another thought -- we should probably also run this check during render() on the parent page, so we fail as early as possible.

I agree. Already mentioned this in my first comment in this PR :)

I'm currently working on validating that in parent render function too.

Looks good to me! Ready for merge?

I think so...fingers crossed :)

Awesome! Thanks again for taking this one up!

No worries mate...thanks for your help.


Ability to select folders only

+1

I tried with intent.setType(DocumentsContract.Document.MIME_TYPE_DIR); into createGetContentIntent() from FileUtils. No luck.

@dentex: in the end I used a different library for folder selection

Link?
Il 12/ott/2015 18:09, "Nicola Beghin"<EMAIL_ADDRESS>ha scritto:

@dentex https://github.com/dentex: in the end I used a different
library for folder selection
—
Reply to this email directly or view it on GitHub
https://github.com/iPaulPro/aFileChooser/issues/36#issuecomment-147448264
.


Validate if provider

fix some hooks to not fire if the request is internal

For queryWithUserId, it would probably be better to remove the else and error throwing, which would remove the need for a provider check, I think.  That way, if a hook.params.user is in place, it will automatically add it.  Then it isn't duplicating functionality from the requireAuth hook, but works with it.  Here's an example that uses some of the new hooks in the upcoming OAuth release:
messageService.before({
  find: [
    authHooks.verifyToken({secret: 'feathers-rocks'}),
    authHooks.populateUser(),
    authHooks.requireAuth(),
    authHooks.queryWithUserId()
  ]
});

I think the same could be said for restrictToSelf and setUserId.  Thanks for your help!

thanks for your feedback, @marshallswain! i adapted the PR accordingly.

@marshallswain Good to go? We can merge it. There may be some conflicts with the decoupling branch by @ekryski but I don't think the hooks changed too much.
@mastertinner Thank you for contributing!

:+1: Ya we can merge this stuff. I did make a couple changes to hooks but I'll sort out the conflicts.
Mad props to @mastertinner for his help! :boom:

Thanks for taking care of this, y'all.  I'm a little spread thin right now.  :)
Thanks @mastertinner for your help.

thanks for the support, guys!


Certificates not shown when issued by cert-manager

Rancher versions:
rancher/server or rancher/rancher: 2.0.2
rancher/agent or rancher/rancher-agent: 2.0.2
Infrastructure Stack versions:
kubernetes (if applicable): 1.8
Docker version: (docker version,docker info preferred)
Containers: 77
Running: 41
Paused: 0
Stopped: 36
Images: 34
Server Version: 1.13.1
Storage Driver: aufs
Root Dir: /home/docker/aufs
Backing Filesystem: extfs
Dirs: 368
Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: N/A (expected: 949e6facb77383876aeff8a6944dde66b3089574)
Security Options:
apparmor
seccomp
Profile: default
Kernel Version: 4.13.0-43-generic
Operating System: Ubuntu 17.10
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 62.88 GiB
Name: ns3116625
ID: 6JUF:ZNHI:6AAA:IO3T:EZKE:MY35:BWRA:57K5:C5NY:W7XN:QGL4:JTCN
Docker Root Dir: /home/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
4.13.0-43-generic
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Bare metal
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:
Create a cluster ;
Add a node
Install gitlab-ce image
create an ingress to serve gitlab on 80 for subdomain
Enable Helm
Install cert-manager
In console, change the .kube/config with the cluster configuration
** Create issuer : **
apiVersion: certmanager.k8s.io/v1alpha1
kind: Issuer
metadata:
name: letsencrypt-issuer-prod
spec:
acme:
server: https://acme-v02.api.letsencrypt.org/directory
email:
privateKeySecretRef:
name: letsencrypt-issuer-prod
http01: {}
** Result of the issuer : **
Status:
Acme:
Uri:  https://acme-v02.api.letsencrypt.org/acme/acct/
Conditions:
Last Transition Time:  ...
Message:               The ACME account was registered with the ACME server
Reason:                ACMEAccountRegistered
Status:                True
Type:                  Ready
Events:
Create certificate :
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
name: xxx
spec:
secretName: xxx-tls
dnsNames:

dom1
dom2
dom3
issuerRef:
name: letsencrypt-prod
kind: ClusterIssuer
acme:
config:

http01:
ingressClass: nginx
domains:

dom1
dom2
dom3

** Result of the certificate : **
Events:
Type    Reason          Age   From          Message

Normal  CreateOrder     22m   cert-manager  Created new ACME order, attempting validation...
Normal  DomainVerified  20m   cert-manager  Domain "dom" verified with "http-01" validation
Normal  IssueCert       20m   cert-manager  Issuing certificate...
Normal  CertObtained    20m   cert-manager  Obtained certificate from ACME server
Normal  CertIssued      20m   cert-manager  Certificate issued successfully
Results:
The certificate page is still empty.

I'm seeing the certificates showing in 2.0.6, but they aren't displayed correctly and deleting them doesn't seem to delete them from kubernetes either.  I've also found that cert-manager doesn't work out of the box on rancher without some manual editing of ingress spec settings. See https://github.com/rancher/rancher/issues/14924

@msalles-winn not sure if you ever got this working... but for anyone that finds this:
I had a brand new cluster on which rancher UI was not showing certificates issued by cert-manager even though I had that cluster configured "exactly" like one that was. I eventually discovered that the only difference was cert-manager was installed into the default namespace on the working clusters I went to recreate it in the default workspace at which point I noticed that the default workspace wasn't an option. At some point (I have no idea how) the default namespace was removed from the default project. Added it back and now I have all my cert-manager issued certs showing up and available for ingress assignment.
fwiw I'm using a clusterissuer and wildcard domains -- setup similar to this post https://www.idealcoders.com/posts/rancher/2018/06/rancher-2-x-and-lets-encrypt-with-cert-manager-and-nginx-ingress/

Thanks for the report.
Please try https://github.com/rancher/rancher/issues/14423#issuecomment-426129872
Please let us know in a comment if you can still reproduce the issue, and we'll reopen it


Fix generating the spatial structure

Calling the functions getChunks two times overwrite the treeChunks variable.
Fixed using concat.

Thank you!


0.6 API Updates - Remove unused platform APIs

There are duplicate APIs available for metadata batch writes. We recently added writeBatch() in the metadata API (TracMetadataApi and TrustedMetadataApi). Before this we had several separate batch methods - createObjectBatch(), updateObjectBatch() etc. This ticket is to remove the old APIs, so we will only have one writeBatch() method which can handle all types of write operation.
The change is needed in both TracMetadataApi and TrustedMetadataApi. The service .proto files need to be modified, the the uneeded implementations and service methods can be removed.

In addition to changes included in the PR #307 it is necessary to remove implementation elements related to the removed platform APIs, which were used in other contexts and as such have not been removed yet.
The initial code elements for cleansing:

metadata.proto - removal of MetadataWriteBatchRequest and MetadataWriteBatchResponse.
metadata_trusted.proto,  MetadataApiImpl.java, MetadataApiValidator.java, TrustedMetadataApi.java and MetadataTrustedApiValidator.java- change of message types in the definition of  methods (like preallocateIdBatch) - replacing removed MetadataWriteBatchRequest and MetadataWriteBatchResponse with UniversalMetadataWriteBatchRequest and UniversalMetadataWriteBatchResponse respectively.
MetadataApiImpl.java - reimplementation of updateTag, createPreallocatedObject and preallocateIdBatch methods.
Cleansing of elements, which became unused in: MetadataWriteService.java, MetadataApiValidator.java and MetadataApiImpl.java.
MetadataWriteApiTest.java - removal of universalizeCreateObjectBatchRequest and universalizeCreateObjectBatchRequest methods and verification of places, where they were used.
JobLifecycle.java - correction of allocateResultIds method, so that it does not use  MetadataWriteBatchRequest class.
...and possibly other elements, which need to be identified.

This is resolved by #377


Move xorg packages to own files

Will retarget to staging once done
Closes https://github.com/NixOS/nixpkgs/issues/207978
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Once the generated files seem OK I'll either manually move the buildInputs and such or script it somehow

I really like this PR. Like @Ericson2314 noted in a CR comment, I just got value out of it seeing that pkgconfig provides meta information.

If the issue is no one wants to deal with Perl ...I think ChatGPT can rewrite this thing in python or something easily lol. Then we can change it to do separate packages, and then we can solve the update vs regen issues that @sdht0 points out.

@Ericson2314 after some more thought, I think the updater script can be made to work with the current big as is, by ignoring "DO NOT EDIT" ;) and updating the url and hash in default.nix directly for any single package. Then the perl script is only used for updating the nix expression in general (as you did to great benefit) and the updater script can be used for just updating the versions.
I personally still don't prefer the current split between default.nix and overrides.nix and would like to see them merged. However, there seems to be sufficient benefit from having the generation script to manage 200 or so packages, so maybe we can let it be. Plus with the impending release of Plasma 6, I hope it will finally be the beginning of the end of x11 for majority of the users.

@Artturin, what do you think is necessary to make this not a draft? I'd love to see this land.

I added an update script for the xorg packages at #293704 based on https://github.com/NixOS/nixpkgs/issues/207978#issuecomment-1782205219. It updates all the tarballs, runs the perl script once to regenerate the nix expressions, and then commits the changes.
When there are multiple package updates, the nix file is changed all at once. So unless we do a interactive commit hunk by hunk (manual labor), all the updates will be present in a single commit. But as @trofi pointed out, this might not be ideal wrt bisecting and reverting a single package if things break.
Can we go ahead with this PR or equivalent?
Maybe the perl script could still be used to automatically generate the expressions (for instance still useful for discovering new dependencies as in my PR), but to different files instead of a single one? This would enable regenerating each package individually when there is an update. Currently, a fresh run of the perl script downloads >200 tarballs, even if most are the same.


Dialog not closing on selection in iOS

I have added the dialog picker in iOS. but when i choose large video it isn't closing the picker. The done button is doing nothing.
Also for small video size, getting following error:
TypeError: undefined is not an object (evaluating 'uri.toString')

I am not sure why, but i just debugged it and this line of code when i hide the if condition then it works fine.
- (void)finishPickingAssets:(id)sender
{
//    if ([self.delegate respondsToSelector:@selector(assetsPickerController:didFinishPickingAssets:)]) {
        [self.delegate assetsPickerController:self didFinishPickingAssets:self.selectedAssets];
//    }
}

@dotnetdreamer I can't find the file with code lines you mentioned. What is exact location of the file? Thanks in advance

@bachras he had mentioned this line: https://github.com/TechSmith/GMImagePicker/blob/03aba04098806af4f6da93ccc0353c9447d9deb2/GMImagePicker/GMImagePickerController.m#L220
Actually that library has few problem & I don't have enough idea to solve it now. You can try to adjust main library.

@jibon57 thank you for prompt response. I haven't changed main library before. How do I approach that? Do I have to download this plugin with library and amend the files and try to install plugin from local machine? Could you walk me through?  Thanks in advance.

hi @bachras  with alittle bit of reasearch, i guess the issue isn't this library. When you open the filterpicker sometimes its closing and sometimes itsn't. I had same issue before with openning UIPIckerView in iOS for PDF files. So what i did is i checked the existing plugins, and it turns out that the instance of delegate isn't retained.
Take a look at this line in your code. This instance is destroyed. So what you need to do is to try it like this. So simply the retain the instance of delegate at the top of class in private variable so that Objective-C runtime doesn't destroy it.  I found same things in other TNS plugins too.

@bachras @jibon57  check this topic on forum. It resolved my issue.

@dotnetdreamer thanks for it. I will be happy if you give any pull request.

@dotnetdreamer I have tested the way you have explained. Unfortunately I haven't get any success. But I have seen that if I disabled multiple selection then it worked as expected. So, if you have anything work around then you can share with me here.

Try new version


Added Device Code as Auth method

Device Code is added as an auth method. Documentation updated for all authentication.

Je test gaat nog verkeerd door gebruik van Write-Host


NoNonceVerification triggered when nonce verification is inside a switch statement

Given the following piece of code, the WordPress.CSRF.NonceVerification.NoNonceVerification warning will be triggered, even though a nonce check is present. The culprit appears to be the switch statement.
function my_function() {
	if ( ! isset( $_REQUEST['action'] ) ) {
		return;
	}

	switch ( $_REQUEST['action'] ) {
		case 'foo':
			check_admin_referer( 'foo' );
			foo();
			break;
		case 'bar':
			check_admin_referer( 'bar' );
			bar();
			break;
	}

}

Note that the warning would also be given for a similar if condition:
	if ( 'foo' === $_REQUEST['action'] ) {
		check_admin_referer( 'foo' );
		foo();
	}

Perhaps we should treat comparisons the same way that we do isset() checks, and only give a warning for them if they aren't followed by an nonce check.


Lack of UTF-8 chars in preview

Instead of letters I have weird spaces and tildes

@mateossh can you share the exact text?

@in0rdr I made pr #27
I've tested with the following text:
Text ð ñ ò ó ô õ ö ÷
Before it only displayed
Text
Image cause it's pretty.
http://i.imgur.com/lLQ5YQ9.png


[LinalgExt] Masked Attention Implementation

Enables float/boolean mask as parameters and created linalg generic ops to apply masking.
Updated version of https://github.com/iree-org/iree/pull/18461 that includes scale affine map.
Test directory for numerical verification: https://github.com/rohan-tan-bhowmik/iree-masked-attention-test

Can you split out the scale map indexing map addition in a separate pr please?

Yeah Rob and I commented on this as well. But let's see how quickly we can resolve through the rest of the comments and how much time we have left. I'd like to land this PR soon-ish as Rohan's last day is coming up quite soon and don't want this be PR to be in a limbo land either.

I want to point out that we're having less test coverage because of the change. E.g., there are several lit tests that not have the new cases (e.g., fusion, tile_attention, decompose_attention, etc). It is a red flag to me, and nothing is documented in the PR description. No action required because I don't have good suggestion.

For "tiling" and "decomposition", I think Rohan for most part added it in "tiling.mlir" and "decompose_online_attention.mlir", the "tile_attention.mlir and "decompose_attention.mlir" is used for the old path which we don't use and should deprecate soon that's why we didn't add it there.
@hanhanW good catch on adding fusion test cases when the optional mask exists. Also, I think we may be missing test case of tiling linalg_ext.attention (non online version) with optional mask as well in tiling.mlir.
Aside from these additional LIT tests that I mention above, do you have any other concerns/suggestions? :)

I want to point out that we're having less test coverage because of the change. E.g., there are several lit tests that not have the new cases (e.g., fusion, tile_attention, decompose_attention, etc). It is a red flag to me, and nothing is documented in the PR description. No action required because I don't have good suggestion.

For "tiling" and "decomposition", I think Rohan for most part added it in "tiling.mlir" and "decompose_online_attention.mlir", the "tile_attention.mlir and "decompose_attention.mlir" is used for the old path which we don't use and should deprecate soon that's why we didn't add it there.

What you said makes sense, and I think we can put them to PR description. :) This saves a lot of time for reviewers and future contributors to understand why the tests are not added and what's missing.

@hanhanW good catch on adding fusion test cases when the optional mask exists. Also, I think we may be missing test case of tiling linalg_ext.attention (non online version) with optional mask as well in tiling.mlir.
Aside from these additional LIT tests that I mention above, do you have any other concerns/suggestions? :)

I did not go through all the lit test files, so it'd be good to write down what's missing in the PR description. And others can pick them up later.

Sounds good, will implement as fit. Thanks everyone for the detailed and helpful feedback!


feat(cdkDragDrop): Update the displaced area by a placeholder when it's size is dynamically changed during drag

Feature Description
Currently when using cdkplaceholder, the height of it can be changed dynamically changed during drag:

The problem is that when the placeholder is drawn into a droplist it will use it's initial height when offsetting items in the list. It somehow needs to be updated to use the new height. The visual size of the placeholder is correct, but a large empty area appears below it and other elements from the list are pushed downward and rendered over other elements.
Is there a way to update this placeholder offset during a drag?
If not, is there a way to end the current drag and programmatically start a new one (with the updated placeholder)?
Use Case
I have a board with several lanes. Each lane contains cards. The cards can be moved amongst themselves or onto other lanes. Each card contains line items. The items can be moved amongst themselves or onto other cards and also in the lanes themselves. When a line item is dropped into a lane, a new card is created with that item. I would like to have a placeholder for the line item that has the height of a line item when dragging it onto a card and the height of a card when dragged over a lane.

Thank you!

I believe this is the same problem as https://github.com/angular/components/issues/14703. We try to limit the number of measurements we're making of the DOM since it can impact performance and there's no good way of knowing when the size of an element has changed.


Darkuś zyebałeś x2

Running: nasm -felf32 src/boot.asm -o build/boot.o
Running: gcc -m32 -c src/Modules/vga.c -o build/vga.o -std=gnu99 -O2 -Wall -Wextra -fno-builtin -nostdlib
In file included from src/Modules/vga.c:1:0:
src/Modules/vga.h:9:12: error: unknown type name ‘uint16_t’
void color(uint16_t color);
^~~~~~~~
src/Modules/vga.c:32:12: error: unknown type name ‘uint16_t’
void color(uint16_t color) {
^~~~~~~~
Running: gcc -m32 -c src/kernel.c -o build/kernel.o -std=gnu99 -O2 -Wall -Wextra -fno-builtin -nostdlib
In file included from src/kernel.c:1:0:
src/Modules/vga.h:9:12: error: unknown type name ‘uint16_t’
void color(uint16_t color);
^~~~~~~~
src/kernel.c: In function ‘kmain’:
src/kernel.c:9:2: warning: implicit declaration of function ‘color’ [-Wimplicit-function-declaration]
color(0x37);
^~~~~
Running: gcc -m32 -c src/Modules/lib.c -o build/lib.o -std=gnu99 -O2 -Wall -Wextra -fno-builtin -nostdlib
src/Modules/lib.c: In function ‘findBit’:
src/Modules/lib.c:19:20: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
if(!mall_memory._1) counter = 1;
^
->
src/Modules/lib.c:19:25: error: ‘counter’ undeclared (first use in this function)
if(!mall_memory._1) counter = 1;
^~~~~~~
src/Modules/lib.c:19:25: note: each undeclared identifier is reported only once for each function it appears in
src/Modules/lib.c:20:25: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._2) counter = 2;
^
->
src/Modules/lib.c:21:25: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._3) counter = 3;
^
->
src/Modules/lib.c:22:25: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._4) counter = 4;
^
->
src/Modules/lib.c:23:25: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._5) counter = 5;
^
->
src/Modules/lib.c:24:25: error: ‘(struct byte *)&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._6) counter = 6;
^
->
src/Modules/lib.c:25:25: error: ‘(struct byte )&mall_memory’ is a pointer; did you mean to use ‘->’?
else if(!mall_memory._7) counter = 7;
^
->
src/Modules/lib.c:26:14: error: ‘mall_mempty’ undeclared (first use in this function)
else if(!mall_mempty._8) counter = 8;
^~~~~~~~~~~
src/Modules/lib.c:18:32: warning: unused parameter ‘pos’ [-Wunused-parameter]
inline uint32_t findBit(size_t pos) {
^~~
src/Modules/lib.c: In function ‘malloc’:
src/Modules/lib.c:32:22: warning: unused variable ‘counter’ [-Wunused-variable]
uint32_t counter = findBit(i);
^~~~~~~
src/Modules/lib.c: In function ‘memcmp’:
src/Modules/lib.c:43:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 0; i<size; i++) {
^
src/Modules/lib.c: In function ‘memcpy’:
src/Modules/lib.c:55:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 0; i<block_size; i++) {
^
src/Modules/lib.c: In function ‘findBit’:
src/Modules/lib.c:27:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Running: gcc -m32 -c src/Modules/keyboard.c -o build/keyboard.o -std=gnu99 -O2 -Wall -Wextra -fno-builtin -nostdlib
src/Modules/keyboard.c: In function ‘getStringn’:
src/Modules/keyboard.c:50:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 1; i<=size+1; i++) {
^~
src/Modules/keyboard.c:54:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(i<size+1) string[i-1] = getchar();
^
src/Modules/keyboard.c: In function ‘getStringc’:
src/Modules/keyboard.c:69:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int j = 0; j<size; j++) string[j] = temp[j];
^
src/Modules/keyboard.c: In function ‘getStringnp’:
src/Modules/keyboard.c:84:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 0; i<ptr_size-1; i++) {
^
src/Modules/keyboard.c: In function ‘getStringcp’:
src/Modules/keyboard.c:94:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 0; i<ptr_size-1; i++) {
^
src/Modules/keyboard.c: In function ‘strcmp’:
src/Modules/keyboard.c:122:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for(int i = 0; i<size_a; i++) {
^
In file included from src/Modules/keyboard.c:3:0:
src/Modules/keyboard.c: At top level:
src/Modules/lib.h:14:17: warning: inline function ‘findBit’ declared but never defined
inline uint32_t findBit(size_t pos);
^~~~~~~
src/Modules/keyboard.c: In function ‘getStringn’:
src/Modules/keyboard.c:49:15: warning: ‘string’ may be used uninitialized in this function [-Wmaybe-uninitialized]
char string;
^~~~~~
Running: ld -m elf_i386 build/boot.o build/kernel.o build/vga.o build/keyboard.o build/io.o build/lib.o -T linker.ld -o kernel -O2 -nostdlib
build/kernel.o: In function kmain': kernel.c:(.text+0x2d): undefined reference to getch'
build/keyboard.o: In function getStringn': keyboard.c:(.text+0xa6): undefined reference to malloc'
keyboard.c:(.text+0x102): undefined reference to free' keyboard.c:(.text+0x114): undefined reference to malloc'
build/keyboard.o: In function getStringc': keyboard.c:(.text+0x1ab): undefined reference to malloc'
keyboard.c:(.text+0x207): undefined reference to `free'

o luj
co jest z color?

w ogóle, ten github psuje trochę errory, wyglądają dziwnie


On GitHub Actions, finish fails with coveralls.exception.CoverallsException: Parallel finish failed: Invalid github token

I'm trying to start using coveralls on a project.  I have parallel builds on GitHub Actions so I am using the parallel feature.
The finish job fails though:
The GitHub Actions configuration is:
  # Tell Coveralls that we're done reporting coverage data.  Since we're using
  # the "parallel" mode where more than one coverage data file is merged into
  # a single report, we have to tell Coveralls when we've uploaded all of the
  # data files.  This does it.  We make sure it runs last by making it depend
  # on *all* of the coverage-collecting jobs.
  finish-coverage-report:
    # There happens to just be one coverage-collecting job at the moment.  If
    # the coverage reports are broken and someone added more
    # coverage-collecting jobs to this workflow but didn't update this, that's
    # why.
    needs:
      - "coverage"
    runs-on: "ubuntu-latest"
    # Get a Python 3 environment because only the Python 3 release of
    # coveralls-python has the `--finish` flag...
    container: "python:3-slim"
    steps:
      - name: "Finish Coveralls Reporting"
        run: |
          # Also install wheel otherwise `docopt` may fail to build
          pip install wheel coveralls
          python -m coveralls --finish
        env:
          # Some magic value required for some magic reason.
          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
          # Help coveralls identify our project.
          COVERALLS_REPO_TOKEN: "..."

also visible at
https://github.com/tahoe-lafs/tahoe-lafs/blob/9a8a61b74042a8870e83e4700a177627e02a528a/.github/workflows/ci.yml#L82-L108
The failure looks like this:
Finishing parallel jobs...
Parallel finish failed: Invalid github token
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/coveralls/cli.py", line 80, in main
    coverallz.parallel_finish()
  File "/usr/local/lib/python3.9/site-packages/coveralls/api.py", line 268, in parallel_finish
    raise CoverallsException('Parallel finish failed: {}'.format(e))
coveralls.exception.CoverallsException: Parallel finish failed: Invalid github token
Error: Process completed with exit code 1.

and is also (presently) visible at https://github.com/tahoe-lafs/tahoe-lafs/runs/1653828599?check_suite_focus=true
I tried to collect output from coverage debug --finish but it looks like it's evidence of some unrelated problem:
Missing .coveralls.yml file. Using only env variables.
Testing coveralls-python...
Failed collecting git data.  Is git installed?
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/coveralls/git.py", line 79, in git_info
    'id': gitlog('%H'),
  File "/usr/local/lib/python3.9/site-packages/coveralls/git.py", line 25, in gitlog
    glog = run_command('git', '--no-pager', 'log', '-1',
  File "/usr/local/lib/python3.9/site-packages/coveralls/git.py", line 12, in run_command
    cmd = subprocess.Popen(list(args), stdout=subprocess.PIPE,
  File "/usr/local/lib/python3.9/subprocess.py", line 947, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/local/lib/python3.9/subprocess.py", line 1819, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'git'
{"source_files": [], "config_file": ".coveragerc", "repo_token": "[secure]", "service_name": "github-actions", "service_number": "464933209", "service_pull_request": "956"}

this is also (presently) visible at https://github.com/tahoe-lafs/tahoe-lafs/runs/1653903051?check_suite_focus=true

@exarkun the first issue you've listed there seems to be related to some Github Actions issues I've just fixed -- see #240 and #247 for more info. Updating to version 3.0.0 should do the trick!
You can also remove the COVERALLS_REPO_TOKEN value in your config (the GITHUB_TOKEN is enough). It should be ignored since you've set the GITHUB_TOKEN, but removing it would help make sure.
Your second issue is more straightforward -- it looks like you're running commands in an environment which does not have git installed? We require the ability to run git log commands against your code in order for coveralls to know how to match coverage reports to your repo. Ensuring you usage a base image with git and have access to your code from the GH Actions job should do the trick!

@exarkun the first issue you've listed there seems to be related to some Github Actions issues I've just fixed -- see #240 and #247 for more info. Updating to version 3.0.0 should do the trick!
You can also remove the COVERALLS_REPO_TOKEN value in your config (the GITHUB_TOKEN is enough). It should be ignored since you've set the GITHUB_TOKEN, but removing it would help make sure.
Your second issue is more straightforward -- it looks like you're running commands in an environment which does not have git installed? We require the ability to run git log commands against your code in order for coveralls to know how to match coverage reports to your repo. Ensuring you usage a base image with git and have access to your code from the GH Actions job should do the trick!

Hi @TheKevJames thanks for your response.
Regarding git being missing, I modeled my configuration on https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support which also uses the python:3-slim Docker image.  So if that image is unsuitable, it would probably be helpful to have that documentation updated to suggest a different image.
Also, if git is missing, maybe coveralls-python could fail by saying Git is missing instead of failing by saying "Invalid github token".  This might help more people diagnose the problem on their own.

Hi @TheKevJames thanks for your response.
Regarding git being missing, I modeled my configuration on https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support which also uses the python:3-slim Docker image.  So if that image is unsuitable, it would probably be helpful to have that documentation updated to suggest a different image.
Also, if git is missing, maybe coveralls-python could fail by saying Git is missing instead of failing by saying "Invalid github token".  This might help more people diagnose the problem on their own.

@exarkun yes, sorry about that, I was indeed referring to the second error, eg. the one which outputs Failed collecting git data.  Is git installed?.
Hopefully, v3.0.0 has solved your normal usage (rather than debug mode) issue?

@exarkun yes, sorry about that, I was indeed referring to the second error, eg. the one which outputs Failed collecting git data.  Is git installed?.
Hopefully, v3.0.0 has solved your normal usage (rather than debug mode) issue?

This issue happens on a self-hosted/Enterprise instance of Coveralls as well. It seems like for the Parallel Finish step it is expecting the COVERALLS_REPO_TOKEN. In general, it looks like everything "works" (having an issue with coverage being reported, but everything succeeds) with the COVERALLS_REPO_TOKEN.


Gradle build fails with Android Studio Flamingo update

Summary
Gradle build fails after updating to the latest Android Studio stable release (Flamingo)
Why does it fail?
Android studio Flamingo comes bundled with JDK 17. The minimum Gradle version to support JDK 17 is Gradle 7.3. But the project currently uses Gradle 6.9.

After upgrading Gradle from 6.9 to 7.3, the build still fails with the following error.

This is caused due to error in the build.gradle file of the data-client ie: wikimedia-android-data-client library, rather than the build.gradle of the commons app.
Steps to reproduce

Upgrade Android Studio to Flamingo
Open apps-android-commons project
The build fails with the said error

Expected behaviour
The build error is expected as the Gradle version is incompatible with the JDK version.
Actual behaviour
NA
Device name
Realme 3 pro
Android version
Android 11
Commons app version
4.0.3-debug
Device logs
No response
Screen-shots
No response
Would you like to work on the issue?
Yes

Thanks! The best thing to do would be to send a pull request (or equivalent) to the library's source repository, and use that fork until the pull request gets merged.

@nicolas-raoul The library is not included as a dependency in the commons app project gradle files, rather the entire codebase of the library has been copied into the data-client folder & the folder is included as a project in the commons app build.gradle file.
implementation project(':wikimedia-data-client')

And the path for the project is specified in settings.gradle file of commons app project
project(':wikimedia-data-client').projectDir = new File('data-client')

So it'd be of no use even if a pull request to the library repository fixes the said error unless the library is included as a dependency in build.gradle file of the commons app project, rather than having the entire codebase copied into it.
The library repository seems to have got some updates compared to the code present in the commons app project but has not received any updates after November 2019.
Actually, this error should have been reported in the wikimedia-android-data-client GitHub repository as it is concerned with publishing of the library and has nothing to do with the commons app itself.
The best thing we could do to fix this quickly is to fix it ourselves within this project. I will try, but I suggest this issue be assigned to someone with good knowledge of gradle & publishing libraries.
I'm leaving links to resources I found that'd be helpful in solving this issue:

Stack Overflow Discussion
Medium Article

After contacting the author of the library, it is clear that it does not have active development. The author has just archived the library. He told that the library is outdated and suggested commons app gradually move to its own solution with modern tools and practices. I'm working on a temporary solution to just make it work for now.

Thanks Siva! Even though the long-term solution is probably migration (per #5165), a short-time fix seems needed too, if I understand correctly.

You're right Nicolas. People are going to update their Android Studio as usual & the build will fail, affecting further development. I'm working on a temporary solution now.

I've successfully upgraded AGP and Gradle to the latest version (AGP 8.0.0, Gradle 8.0) but the error still persists.

This comment in a similar issue suggests a potential fix.

@nicolas-raoul Can you review my pull request?

Is this fixed?
Are there any temporary workarounds?

Is this fixed?
Are there any temporary workarounds?

Merging this pull request should solve the issue.


Why doesn't stablehlo.rng take an initial_state?

Quesiton I received from @loganchien recently that I wanted to forward to the spec workstream.

Should stablehlo.rng take an initial_state and return an update_state like stablehlo.rng_bit_generator?

Is there any reason the op interfaces are different?

IIUC, stablehlo.rng is taking uniform random bits from some unspecified random bit generator source and transform the random bits into uniform-distributed random integers or normal-distributed random floating points.  However, we can't specify the random generator state with the current API.  It looks like it is assuming some stateful global variables in the run-time.
With initial_state and update_state, we can use the same uniform random bit stream between stablehlo.rng and stablehlo.rng_bit_generator.  For example (illustration purpose):
func.func @main(%initial_state : tensor<?xui32>) {
  %cst1 = constant dense<1> : tensor<i64>
  %cst6 = constant dense<6> : tensor<i64>
  %cst_mean = constant dense<0.0> : tensor<f32>
  %cst_var = constant dense<6.0> : tensor<f32>
  %shape = constant dense<[3, 3]> : tensor<2xi64>
  %update_state1, %xs = "stablehlo.rng"(%cst1, %cst6, %shape, %initial_state) {
          rng_distribution = "UNIFORM",
          rng_algorithm = #stablehlo<rng_algorithm THREE_FRY>
      } : (tensor<i64>, tensor<i64>, tensor<2xi64>, tensor<?xui32>) -> (tensor<?xui32>, tensor<3x3xi64>)
  %update_state2, %ys = "stablehlo.rng"(%cst_mean, %cst_var, %shape, %update_state1) {
          rng_distribution = "NORMAL",
          rng_algorithm = #stablehlo<rng_algorithm THREE_FRY>
      } : (tensor<f32>, tensor<f32>, tensor<2xi64>, tensor<?xui32>) -> (tensor<?xui32>, tensor<3x3xf32>)
  %update_state3, %zs = "stablehlo.rng_bit_generator"(%update_state2) {
          rng_algorithm = #stablehlo<rng_algorithm THREE_FRY>
      } : (tensor<2xui64>) -> (tensor<2xui64>, tensor<2x2xui64>)
  return %xs, %ys, %zs : tensor<3x3xi64>, tensor<3x3xf32>, tensor<2x2xui64>
}

Is there any reason the op interfaces are different?

StableHLO being bootstrapped from HLO/MHLO inherits these operations.
Thanks Logan for the example! I agree that this could be useful new feature to have and need further exploration. As with the current priorities, we might not be able to address this right away in this quarter. As mentioned in the above link ((P1) New features),   I am planning to look into this sometime in  H2'2023.
Please let us know if you think we should address this sooner.


Stop Charge Now - Clearer/cleaner way to cancel a schedule override

Is your feature request related to a problem? Please describe.
I want to be able to cancel any schedule override that might be set on my Pod Point, which I might have started using the Charge Now button on the Pod Point app or the Charge Now service in the HA integration.
Describe the solution you'd like
I'd like an extra service, "Stop Charge Now" named like the Pod Point app button; or allow 0 seconds in the Charge Now service call.
Or mention in the documentation what the recommended way to cancel a schedule override is.
Describe alternatives you've considered
Configuring a 5 second override to overwite anything that might be running.
`
if:

condition: state
entity_id: sensor.psl_166021_charge_override_end_time
state: unknown
then: []
else:
service: pod_point.charge_now
data:
seconds: 5
`

Additional context

Hi, thanks so much for raising this, I will look to release this in the next update to the plugin.
This should be sometime in the next week or so.
First I will update the podpointclient to support this
Then I'll implement it in the home assistant plugin

Hi, thanks so much for raising this, I will look to release this in the next update to the plugin.

Thanks for this really helpful integration :)


Create gh action for adding new issues to project

Not all new issues are automatically added to the project which results in sometimes being missed by the team.
This is due to limitations on workflows in the project due to current pricing plan.
We can however solve this by using gh actions.
https://github.com/Altinn/app-lib-dotnet/blob/main/.github/workflows/add-to-project.yml

Action has been added, but needs a new github-token that has permissions to move issues to the project

This works now that the PAT was approved. Tested and working on issue #2394


Sequence getter for genomes is working

Coverage increased (+0.3%) to 100.0% when pulling b818b274e6a0e238264dff1f6cf82cb8e85d8e6e on AliTV-AliTV into 02276954b0d6a40cbcbcf6822015621efabbe0b8 on develop.


Bugfix/UI bug double borders around photo grid

Fixed UI bugs around the grids showing double borders. Added Animation to the booth footer
Description
Refactored the booth display to use a table. This allows for the use of border-collapse to prevent double border of images. Fixed extra borders that were appearing on the Artboard.
Related Issue
Issue 43
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information
Booth Display

Artboard Drawing Grid

Animation
https://user-images.githubusercontent.com/22626267/193887031-f8bbba09-bf3d-4b74-b58b-9fae22a62830.mov

@0xRowdy
There are some conflicts. Maybe you should pull some changes from dev.

@0xRowdy
There are some conflicts. Maybe you should pull some changes from dev.

No problem. I'm always getting conflicts around the sw.js.map. Is that something that should be ignored or should I include it in every commit?

@0xRowdy
There are some conflicts. Maybe you should pull some changes from dev.

No problem. I'm always getting conflicts around the sw.js.map. Is that something that should be ignored or should I include it in every commit?

I searched for it and it looks like a file generated by next-pwa, which shouldn't be ignored :/

Ahh gosh sorry. I've added appropriate files to the gitignore.

Ahh gosh sorry. I've added appropriate files to the gitignore.

Well, I'm not sure but I feel like they shouldn't be ignored


Remove setTheme from StringEditBox, add getExpanse

After #277 is finished, this issue (#204) can be closed

After #277 is finished, this issue (#204) can be closed


EscalateDirective causes a nil pointer deference when applied to root actor

If the supervision strategy for a root-level actor returns EscalateDirective, the program would crash. Instead, the actor should be stopped without bringing down the other actors in the program.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks @bryanpkc!
We need a signed CLA before merging.


Fixes fixed-size uint8 arrays differential treatment

Problem
JSON conversion of fixed size uint8 arrays fails because fixed size uint8 arrays are incorrectly considered "not binary type", hence not base64 encoded. This is a known issue, labeled as #5
Troubleshooting
This was traced back to the field_type in ros_binary_types check which doesn't succeed for fixed sized arrays, cascading the if-else ladder to  _convert_from_ros_array() call, mislabeled as primitive type "array of uint8".
Solution

Added tests to prove the unintended behavior
Fixed issue with a regex matching

Thanks @OverkillGuy. The fix and tests look good. Merging. I'll create a 0.4.1 release, but realistically, it'll be in a week.


The deploy works, but the website doesn't.

Hello @yzwijsen
By default, uptime kuma listens to port 3001, but azure web app only listens and forwards ports 80 and 443.
I don't see any reference to http ports in the bicep file
I miss something ?
Right after deploying the bicep file, the url of the azure website does not work.

@victorperez2911 are you able to figure out this problem? I am facing same error.. deployed fine but could not access it.

@victorperez2911 are you able to figure out this problem? I am facing same error.. deployed fine but could not access it.

Nope

I made it work when I enabled web sockets to true and Always ON to true

I made it work when I enabled web sockets to true and Always ON to true at app service configuration settings.

Bicep file create a "linux based" Web App, and this doesn't have the "Web Socket" option.
Researching, I discovered that Web Socket is active by default in Linux-based Web Apps.
However, it worked when activating "Always On".


eos account has no authorities

Currently, the chain is initializing the eos account with no authorities. This violates the invariant that all accounts have at least an owner and active authority.
What should eos's authorities be?
This replaces #209, which is the error thrown when lookup_minimum_permission attempts to load eos's active authority.

The above commit, which sets eos' auths to unsatisfiable, fixes the error in #209

This looks like a reasonable approach

@nathanhourt Looks like this was never merged.

Yeah, I'd wondered what happened here. I remember fixing this, and I thought it got merged in, but it appears to have been lost somewhere along the way... One more try, then? https://github.com/EOSIO/eos/pull/471

Merged. Closing.


DISCUSSIONS

Since Github allows pinning only 3 issues, here's some important discussions:
Active

https://github.com/yt-dlp/yt-dlp/issues/10087

https://github.com/yt-dlp/yt-dlp/issues/10086

https://github.com/yt-dlp/yt-dlp/issues/4846
https://github.com/yt-dlp/yt-dlp/issues/4827
https://github.com/yt-dlp/yt-dlp/issues/1918
https://github.com/yt-dlp/yt-dlp/issues/1354
https://github.com/yt-dlp/yt-dlp/discussions/803#discussioncomment-2021803
https://github.com/yt-dlp/yt-dlp/pull/8638

(We may take a different approach to linux armv7/aarch64 builds instead of this)

Closed

https://github.com/yt-dlp/yt-dlp/issues/7803
https://github.com/yt-dlp/yt-dlp/issues/8370
https://github.com/yt-dlp/yt-dlp/issues/3764
https://github.com/yt-dlp/yt-dlp/issues/267
https://github.com/yt-dlp/yt-dlp/issues/390
https://github.com/yt-dlp/yt-dlp/issues/389
https://github.com/yt-dlp/yt-dlp/issues/1839
https://github.com/yt-dlp/yt-dlp/issues/2345

Ping for anyone who's watching: https://github.com/yt-dlp/yt-dlp/issues/4827, https://github.com/yt-dlp/yt-dlp/issues/4846 has been added

Ping for anyone subscribed: #10086 and #10087 have been added

For subscribers: #11255 has been added


Fix Codacy

The Codacy CI plugin seems to be broken, the CI build takes forever, and then Codacy times out after two minutes saying it can't find coverage data because it's still building. The Codacy UI is all sorts of messed up and I can't even get it to retry successfully after the build is done, so I just removed this for the time being until we can fix it.
            -   name: Generate coverage reports
                run: ./gradlew jacocoTestReport

            -   name: codacy-coverage-reporter
                uses<EMAIL_ADDRESS>                with:
                    project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}

I also disabled Codacy in the organization control panel to prevent it from failing all of our PR's (because for some reason GitHub is ignoring the required fields), so re-enable that once you start debugging this.

I'm going to re-evaluate our CI/CD situation since this package is getting older and there may be better linters out there.


ServiceFabricUpdateManifestV2 add option to filter on branch name for…

Enables getting the Latest, Succeeded Build from a the given Branch name, when using 'Update only if changed' option in the task.
I've added a third option called 'Last Successful Build from a specific Branch' .

Task name:  ServiceFabricUpdateManifestV2
Description:  Updating manifest is done by comparing build outputs. I've added a build filter LatestFromBranch to be able to select the Latest, Succeeded Build from a Branch.
Documentation changes required: (Y/N) Unsure
Added unit tests:  No,  I've found no tests in this area, as it just leverages the Azure DevOps API.
Attached related issue: No, I did not make an issue, I wanted to check functionality and noticed this is a minor change.
Checklist:

[x] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected (note: I need help with this)

@microsoft-github-policy-service agree

I've been able to create a workaround; get the buildnumber via Rest API and then input in the UpdateManifestTask

$url = "$($env:SYSTEM_TEAMFOUNDATIONCOLLECTIONURI)$env:SYSTEM_TEAMPROJECTID/_apis/build/builds/?definitions=$($env:SYSTEM_DEFINITIONID)&buildNumber=$(buildNumberFilter)&resultFilter=succeeded&`$top=1&api-version=7.0"


testrail updater doesn't work in <IP_ADDRESS> core

no valuable stack trace, just error message:
2017-10-27 20:32:08 DefaultTestRailUpdater [TestNG] [INFO]Updater Thread: 17
2017-10-27 20:32:08 TestNamingUtil [TestNG] [WARN]Unable to find registered test name for threadId: 17. stack is null!
2017-10-27 20:32:08 DefaultTestRailUpdater [TestNG] [ERROR]Unable to identify test name by threadId: 17

fix should be available in <IP_ADDRESS>+ core build


i want to add arabic and amazighen = berber langegue of algerie if i can i don't now how install it

XD LOL

If you still need help, feel free to respond on this issue.   Closing for now.


Provide vignettes?

This would very helpful for pkgdown, since I could link to the same place for documentation and vignettes that aren't in the current package.

That is a great suggestion @hadley. We will work this in as we overhaul RDocumentation.


Polynomial functions

Reported by kdavies4 on 31 Jan 2013 01:45 UTC
This ticket is to add a Polynomials package to Modelica.Math.  Unfortunately, after coding the package for another library, I realized that Modelica.Media.Incompressible.TableBased.Polynomials_Temp seems to have the same functions and probably more.  Maybe the two packages can be combined.  One advantage of the new Polynomial package is that it generates polynomial expressions in a nested form (((... a2)*x + a1)*x) which should be more computationally efficient.  Also, the tests (added to ModelicaTest.Math) may be more thorough; they are based on the der() operator as recommended in the Dymola 7.4 User's Manual Volume 2.
Regardless, it may be best to move Polynomials_Temp to the Math package so that users can find it more easily.

Migrated-From: https://trac.modelica.org/Modelica/ticket/977

Comment by kdavies4 on 31 Jan 2013 02:03 UTC
This ticket can be closed or deleted.  Ticket #978 is a duplicate.  I'm sorry I didn't realize that this one went through.

Modified by sjoelund.se on 31 Jan 2013 07:39 UTC

Modified by dietmarw on 15 Mar 2013 10:59 UTC

Modified by beutlich on 20 Dec 2016 18:28 UTC


Foliage normals are flipped for normal_ext materials.

Custom materials include the code needed to properly align a normal for double sided surfaces. Unfortunately as it turns out this cause foliage to have flipped normal (the winding order for vertices is likely different for foliage and cloth), as can be seen below.

There isn't a "backwards" compatible solution to this so I think I'll solve it by introducing normal_ext.foliage and normal_ext.foliage.specular rendertypes in the next feature release to let mappers solve it.

Resolved in latest release, see DynamicNormalSign.


Test coverage for the main program

There is no test coverage for the visualisers, game and board control logic

made a start when i started refactoring


Add onPluginTypeChange to PanelCtrl

This is useful when you want to migrate from one plugin to another.

For reference: https://github.com/grafana/grafana/blob/298ff3ea012f1e3a0e999aed5186920d3ed0dd8e/public/app/features/panel/panel_ctrl.ts#L113

@oscarkilhed thanks for contributing!


Use the xcode-select path for FASTLANE_EXPLICIT_OPEN_SIMULATOR

Experimental solution for https://github.com/fastlane/fastlane/issues/5128
Extend the FASTLANE_EXPLICIT_OPEN_SIMULATOR feature switch to possibly use the path returned by xcode-select -p to locate the Simulator.app to be launched.
My theory is that people are having trouble with this work-around when the Simulator.app resolved by open Simulator is different than the one in the developer tools path set by xcode-select.
This change adds a kind of second level to the FASTLANE_EXPLICIT_OPEN_SIMULATOR feature switch, by checking to see if its value is "2". If so, we'll try this variation.

This may also help with https://github.com/fastlane/fastlane/issues/5375

Note for myself: scan and snapshot are currently defining this behavior similarly and separately. This should be pulled together, probably into fastlane_core.

@asfalcone approves (over-the-shoulder)


Fix iOS drawRect method signature.

Fixes the iOS method signature for _drawRect to match how params are passed in.

Oops!
Thank! 👍


Multiple collaterals

Allow collateral UTxO to be eq to configured value
Allow multiple collateral inputs

The maximal collateral input count is a protocol param, is the max count checked against it anywhere? Or we allow it to fail on submission?


Democracy.fast_track not allowed with zero voting period

Fixes #8896 (other possible solutions are discussed in the issue comments).
According to the issue fast track with zero voting period create referenda which never ends.
In this PR we do not allow to fast track with zero voting period, returning an error.

Need to actually look into this one, but you are saying that if you create a fast_track with voting period of 1 block then there isn't some issue?

Need to actually look into this one, but you are saying that if you create a fast_track with voting period of 1 block then there isn't some issue? In this case is having 0 blocks vs 1 blocks different?

I will check this, and share what I found.
I am assuming when a referendum expires, something is triggered, and referendum doesn't stuck in unfinished state like in issue #8896. And when voting_period 0, its already expired.
Meanwhile can you check my comment in the issue #8896.
There is another possible solution, but I need a bigger context for it. Question 2.
https://github.com/paritytech/substrate/issues/8896#issuecomment-1154991734

There are two unverified commits at the beginning.
I had to regenerate the keys.

Can you please add a test that someone adds a fast track with 1 block voting period, that it fails after one block, and is cleaned up correctly.

Can you please add a test that someone adds a fast track with 1 block voting period, that it fails after one block, and is cleaned up correctly.

@shawntabrizi done!

bot merge


cpplint 1.6.0

Upgrade cpplint 1.5.5 -> 1.6.0

Coverage remained the same at 100.0% when pulling d4fc1d0e22fbe3417b175d54a1a573da97640400 on cpplint_1.6.0 into 1a90c9463aa5691b4a1fd5b746fedfbecebe57ff on develop.


Remove peerDependencies for web

react-native-web shouldn't be a peerDep, and I'm not sure why react-art is there. I think we could also remove react and react-native and just put them as '*' and specify more clear version requirements in the README / installation instructions, because it all just gets lots in the peerDependencies warning mess that react-native is in.

Can you advise @jaulz ?
Also shouldn't we update yarn.lock here too?

@brentvatne is of course right... I don't think that we need to update the peer dependencies since we are changing the peerDependencies only.


Failed integration tests for various Echopro functions and methods

https://github.com/uw-echospace/EchoPro/blob/f79b6d5bba66ed731b8c414cba01b89230c116e5/EchoPro/tests/test_data_loader.py#L22
The CI test fails due to load_configuration being converted from a class method to a standalone function (as discussed in PR #176). This is an expected failure since load_configuration should be called via load_configuration(...) rather than Survey.load_configuration(...). This is currently limited to the test for this specific function, but this issue will be used to denote other failed integration tests as testing functions are incorporated into Echopro. The list below will serve as a tracking list that will be periodically updated as additional failed tests are discovered as well as errors that are fixed below.
Current failed tests

[ ] load_configuration

I believe this issue is resolved.


XHR

Type: Bug
Everytime I download an extension I'm receiving "XHR failed" error.
VS Code version: Code 1.74.0 (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:38:16.075Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

It seems there are network issues connecting to the Marketplace. Please open developer tools console and let us know what are the error you see while downloading extensions. You can open developer tools console using following command F1 > Toggle Developer Tools

This is same as #533 which was created on the same day. This turned out to be a temporary issue. The users who original reported it are no longer seeing it. I will close this one. @amittima1234, if you are still facing this issue, please follow the steps as I mentioned in https://github.com/microsoft/vsmarketplace/issues/540#issuecomment-1411490797 and we will reconsider. It would also be helpful if you can add a comment below stating whether the issue is fixed or still persists.


Performance Improvements: Discopop Explorer

This PR is becoming quite large. I suggest we merge it and continue our work in separate PRs.


Update version: OpenWhisperSystems.Signal version 6.38.0

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Unattended-Failed

Automatic Validation ended with:


Invisible doesn't work

On android, onError is called and error is null. Not using invisible works.

Hi @Rc85, could you provide an example of your problem?

Hi @Rc85, could you provide an example of your problem?

I'm encountering the same issue.

When using "invisible" type you need to create Google Recaptcha key in Invisible mode.

There's nothing we can do beyond that.

Hi there I am having the exact same issue on Android? I have made sure that I have reCaptcha v2 with the invisible option ticket.
I trigger the captcha and the modal opens but shows no captcha just the badge in the bottom right, it does work when I set size="normal", and it does work on iOS just not Android?
I also have the following recptacha:
     <Recaptcha
            headerComponent={
              <SafeAreaView style={styles.captchaTitleContainer}>
                <NavigationModalCloseButton onPress={this.onCaptchaClose} />
                <Text style={styles.captchaTitle}>{st.recaptcha.title()}</Text>
                <View style={styles.spacer} />
              </SafeAreaView>
            }
            style={{ backgroundColor: colors.gray4 }}
            modalProps={{ presentationStyle: 'pageSheet', animationType: 'slide', transparent: false }}
            ref={this.captchaRef}
            siteKey={V2_INVISIBLE_KEY}
            baseUrl={RE_CAPTCHA_BASE_URL}
            onVerify={this.onCaptchaVerify}
            onClose={this.onCaptchaClose}
            onError={this.onCaptchaError}
            loadingComponent={
              <View>
                <Text style={styles.loadingText}>{st.recaptcha.loading()}</Text>
              </View>
            }
            size='invisible'
          />

Please create a new issue with a demo.


"Download source" button don't has an actual feedback

The user may tap it without knowing what's happening. It's not an evidence that the button says "it will put a notification after some time and it will download the whole project", so the user don't realise what's happening when he taps it.
Easy way to solve it:

A toast with "The download will start in few times"
Disabling the button when the user just tap it (it's common to download a .zip only once)
Adding visual feedback to the button (right now, the user isn't sure about if he tapped the button or not)

Thanks!
In fact i just see the user don't have feedback in any of three FAB buttons on Repo detail screen. I will fix that in the next release, and add some feedback for download, as well as branch selector to download.

Great!

FAB button feedback added on fd06c429bf0a750983c5aa260370062f1086ddf1


How to get the pose boundary?

Hello! I am confused about how to get the pose boundary. The paper said that the auxiliary attribute prediction model predicts the 5-point facial landmarks. I find the label about the facial landmarks is coordinate in the CelebFace Dataset. The paper said that turning right is the corresponding positive direction. How did you turn the coordinate into binary code that represents the direction?

I think there should be many feasible ways. For example, you can compute the midpoint of two eyes, and see where it locates in the image. Taking the middle vertical line as a reference, you can get a binary label :). Also, you can also try to estimate the yaw pose based on the five landmarks with some basic geometry and use angle 0 for separation. Or, you can try something else. Good luck!


When enabling ghci coloured error message, everything is always "All good"

Colours apparently make ghcid so happy that no matter whether there is are errors/warnings or not, it always just shows "All good" :) Of course, I have to go out of my way to get these colours in the first place
ghcid --command='cabal new-repl --ghc-option=-fdiagnostics-color=always'

so it's easy to workaround but the colours are helpful, would be nice to keep them.

It doesn't work with my GHC 8.0.1, so is this a GHC 8.2 only feature? Or a Linux only feature? ghcid already rewrites all the output, and I guess it does so in a way that doesn't preserve color? So I guess it needs to preserve it, parse through it, and redisplay it. All imminently doable, if I can reproduce. I also worry whatever I do will be different on Windows, and thus I won't be able to benefit from colored output (Idris has spoilt me).

Ah, yes, sorry, I should have mentioned that. This is a new feature in 8.2.

Interestingly on Windows, colours are making my code very sad. Things I notice fairly quickly:

If there is an error and you have forced colors then the filename gets mangled. If that happens it keeps reloading.
Sometimes you get | on a single line, which isn't a lot of information. Should strip that if it occurs.
Should probably parse the escape codes, and put them back in later, so they work even on Windows.

I now disable the coloured diagnostics if at all possible, which fixes the problems. As part of #87 I'll work to keep them.


nuxt build makes it impossible to configure logging

Environment

Operating System: Linux
Node Version:     v16.17.1
Nuxt Version:     3.0.0-rc.11
Nitro Version:    0.5.4
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
JSONReporter works when ran with nuxt dev but doesn't with nuxt build.
Stackblitz
Describe the bug
The code in the reproduction successfully outputs logs in json format when run with nuxt dev. However, an app built with nuxt build outputs all logs in standard format - not even one produced by a different consola reporter but the same as making a console call. Even logs created by the logger instance have the same format.
I tried to use logger.wrapConsole and a custom reporter, but the result is the same. It's like consola is not processing the logs when the app is built.
Additional context
The middleware file might be a poor place to change the logger config, but that's th location I found that applies the JSONReporter to all log calls
Logs
nuxt dev log format:
{"date":"2022-10-17T17:35:08.376Z","args":["Incoming request to /"],"type":"info","level":3,"query":{},"tag":""}
{"date":"2022-10-17T17:35:08.376Z","args":["Incoming request to /","(repeated 2 times)"],"type":"info","level":3,"query":{},"tag":""}

nuxt build log format:
{ message: 'Incoming request to /', query: {} }
{ message: 'Incoming request to /', query: {} }

I've updated your reproduction slightly for the recent consola major upgrade - this should be possible: https://stackblitz.com/edit/github-rhycbx-5erah3.


Avoid error in case of missing config key

This patch avoids an error raised in case the config key aLanguageParams is not available and uses original code found in oxid esales.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-8381.
Please use this issue to track the state of your pull request.

hey @bjo3rnf
Sorry for the late answer!
The corresponding ticket was closed. If this change is still relevant for you, please feel free to create a new PR.


Support armhf

Currently, the addons are compiled and published with the package, however arch is completely ignored when naming and loading the addons.
Somehow, running on arm seems to work right now, but I Imagine we shouldn't be using the same binary for x86 and arm.

So, looks like it tries to rebuild anytime it's installed, was going off of the README:
"Prebuilt native modules are provided for most modern platforms. If the prebuilt module fails to load, gcc > 4.8.0 (or compatible) and make are required to build the native module from source."
So, no matter what it always tries to build on install, falling back to the prebuilt addon if it can't build. Think it would still be worthwhile to add arch into the naming of the prebuilt files so that armhf environments won't try to fallback to x86 binaries.

Yep. I didn't even know this compiled on ARM.

Well, now you know! :) We actually cross-compile all of our addons in Jenkins, both work.

@gigafied thanks, I just update https://github.com/uWebSockets/uWebSockets#nodejs-developers to be more accurate on what's actually happening when installing/loading.

Oh, and I also run this on a Rasperry Pi 3 (armv7l), and I value lightweight modules greatly on such limited hardware ;)


Python client: Change passing token from parameter into HTTP header

After the API server implements this feature https://github.com/apify/apify-core/issues/2082.
It needs to change how we are passing API token into the HTTP header instead of the query parameter. It will improve the security of API token.

Done with #39.


Make flutter create generate a manifest that is similar to SkyShell.apk, fixes #1587

lgtm

fixes #1587
fixes #1674


Erroneous values in config causes issues

Colours not being written in some cases. 0 columns written too.

Need handling for errors introduced by manually fiddling with the files.


updated link to openshift docs

Updated link to always point to the latest version of the openshift docs.

@0kashi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@joharder
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


feat:support time slice and add test #74

Signed-off-by: MrSumeng<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Support time slice. Users can set time slices to allow rollout to be executed , if the step not in slices , it will be run at near time when it allowed.
Ⅱ. Does this pull request fix one issue?

fixes #74
Ⅲ. Special notes for reviews
User can customize the time zone. The local time zone will be used , if it is not set .

Codecov Report

Merging #81 (5bced26) into master (e1ba1b0) will increase coverage by 0.86%.
The diff coverage is 62.12%.

:exclamation: Current head 5bced26 differs from pull request most recent head cc7a5c1. Consider uploading reports for the commit cc7a5c1 to get more accurate results

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   16.11%   16.97%   +0.86%
==========================================
  Files          30       31       +1
  Lines        3482     3547      +65
==========================================
+ Hits          561      602      +41
- Misses       2821     2841      +20
- Partials      100      104       +4

Flag
Coverage Δ

unittests
16.97% <62.12%> (+0.86%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/controller/rollout/canary.go
0.00% <0.00%> (ø)

pkg/controller/rollout/context.go
0.00% <0.00%> (ø)

pkg/util/time_utils.go
72.22% <72.22%> (ø)

...ollout/validating/rollout_create_update_handler.go
62.59% <93.75%> (+4.33%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


iOS hack async binaryType setter

I'm using iOS hack with paho.mqtt.javascript, which does the following:
if (this.connectOptions.mqttVersion < 4) {
	this.socket = new WebSocket(wsurl, ["mqttv3.1"]);
} else {
	this.socket = new WebSocket(wsurl, ["mqtt"]);
}
this.socket.binaryType = 'arraybuffer';

Because binaryType is synchronous and this.ws isn't available right after constructor call, the binaryType setter would fail:
binaryType: {
	// ...
	set: function (type) {
		this.ws.binaryType = type;
	}
}

Is it safe to wrap the setter with setTimeout?
set: function (type) {
	setTimeout((function () {
		this.ws.binaryType = type;
	}).bind(this));
}

Done. Will be avaiable when 3.0.2 is out.


Add Google Material Symbols

We should do this soon after an initial release, but it definitely shouldn't block a pipe cleaner release.


Rule engine republish messaging with default retain flags

The rule engine re-publish action sends a message without retain flags, this would cause webhook crashes due to function_clause.

Fixes will be included in 3.2.5 and develop. https://github.com/emqx/emqx-rule-engine/commit/c54b8d835b995d6c02bb84f453570aa82d3a0391


Asks for username and password

When I follow your instructions, it asks for username and password.
Even if I add the -e PASSWORD=something option and use my Linux username, it still says "Error: Incorrect or invalid username/password."

solved by using "rstudio" as the username, and the password entered in the -e PASSWORD=something option when using docker run


Reverting 22c00c5a4bbb09d1a5cbd32063fd3123a44e307f

Problems reported in production, h/t @ravenblackx @jpsim
Risk Level: low: revert
Testing: n/a
Docs Changes: n.a
Release Notes: n/a
Fixes commit: 22c00c5a4bbb09d1a5cbd32063fd3123a44e307f

not sure why clang tidy is unhappy with a rollback so I'm going to force merge to get the fix in as I believe clang is diff based anyway

Curious, what was the issue?

https://groups.google.com/g/envoy-announce/c/b9tQzVpJ5Ro


Feature: Button to use current location

Feature:
Add a button to use the user's current location as location of search.

please attach the screenshot as well so we can have a look at it

Landing Page:

Once the "use my current location" button is clicked.
A prompt to ask user for permission to use their current location:

Result:

All good, merging the pr


Feature Request: Include Document Tags

First,  I love the concept of this plugin. I think treating Readwise as the authoritative source is the right answer to keep everything sanely managed.
I do have a feature request: to add document tags to the generated files. Particularly if I can't/shouldn't add tags to the generated files, then pulling in the tags from Readwise seems like the next best thing. I know at least for my use case, there's no need to drill into individual highlight tags, but the book ones could be useful inside the About section.

Hey @FTWynn , thanks and glad you're loving the plugin.
Tag support is a great idea. And what a coincidence, this GitHub issue is timely - I just spoke to one of their developers this morning over e-mail, and they told me:

In the next couple days we’re gonna ship support for highlight and book tags in the public API, just fyi ;)

So after this change is finalized in their public API, I'll work on integrating this feature 👍

Hi @FTWynn , tag support has just been added in release version 1.1.0: https://github.com/jsonMartin/readwise-mirror/releases/tag/1.1.0
It should be available to update now within Obsidian. Hope this helps, and let me know if you run into any issues with tags


aws scout2 deduplication issue

Issue Type

[ X ] Bug

Description
When a new scan of the same product is imported into defect dojo it crashes
Operating System
Debian 9
Install

[ X ] setup.bash

DefectDojo Version
DEV
Steps to Reproduce
Import a scout2 scan dated from several days ago and tried to import in the same engagement a new scan of the same account with deduplication enabled caused defect dojo to crash
Sample Scan File (if applicable)
Screenshots (optional)
Console Logs (optional)
Console:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/product/views.py", line 380, in import_scan_results_prod
    return import_scan_results(request, pid=pid)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/engagement/views.py", line 473, in import_scan_results
    engagement.save()
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 808, in save
    force_update=force_update, update_fields=update_fields)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 838, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 924, in _save_table
    result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 963, in _do_insert
    using=using, raw=raw)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 1076, in _insert
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/compiler.py", line 1112, in execute_sql
    cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 79, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return Database.Cursor.execute(self, query, params)
OperationalError: table dojo_engagement has no column named deduplication_on_engagement
Internal Server Error: /product/4/import_scan_results
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/product/views.py", line 380, in import_scan_results_prod
    return import_scan_results(request, pid=pid)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/engagement/views.py", line 473, in import_scan_results
    engagement.save()
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 808, in save
    force_update=force_update, update_fields=update_fields)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 838, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 924, in _save_table
    result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py", line 963, in _do_insert
    using=using, raw=raw)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 1076, in _insert
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/compiler.py", line 1112, in execute_sql
    cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 79, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python2.7/dist-packages/django/db/backends/sqlite3/base.py", line 328, in execute
    return Database.Cursor.execute(self, query, params)
OperationalError: table dojo_engagement has no column named deduplication_on_engagement```

Browser:

Request Method: | POST
-- | --
http://localhost:8000/product/4/import_scan_results
1.11.11
OperationalError
table dojo_engagement has no column named deduplication_on_engagement
/usr/local/lib/python2.7/dist-packages/django/db/backends/sqlite3/base.py in execute, line 328
/usr/bin/python
2.7.13
['/FILES/django-DefectDojo',  '/usr/lib/python2.7',  '/usr/lib/python2.7/plat-x86_64-linux-gnu',  '/usr/lib/python2.7/lib-tk',  '/usr/lib/python2.7/lib-old',  '/usr/lib/python2.7/lib-dynload',  '/usr/local/lib/python2.7/dist-packages',  '/usr/lib/python2.7/dist-packages',  '/FILES/django-DefectDojo']
Mon, 19 Nov 2018 21:06:57 +0000

Environment:

Request Method: POST
Request URL: http://localhost:8000/product/4/import_scan_results

Django Version: 1.11.11
Python Version: 2.7.13
Installed Applications:
('django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'polymorphic',
 'overextends',
 'django.contrib.admin',
 'django.contrib.humanize',
 'gunicorn',
 'tastypie',
 'auditlog',
 'dojo',
 'tastypie_swagger',
 'watson',
 'tagging',
 'custom_field',
 'imagekit',
 'multiselectfield',
 'rest_framework',
 'rest_framework.authtoken',
 'rest_framework_swagger',
 'dbbackup')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'dojo.middleware.LoginRequiredMiddleware',
 'dojo.middleware.TimezoneMiddleware')

```Traceback:

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py" in _wrapped_view
  23.                 return view_func(request, *args, **kwargs)

File "/FILES/django-DefectDojo/dojo/product/views.py" in import_scan_results_prod
  380.     return import_scan_results(request, pid=pid)

File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py" in _wrapped_view
  23.                 return view_func(request, *args, **kwargs)

File "/FILES/django-DefectDojo/dojo/engagement/views.py" in import_scan_results
  473.                 engagement.save()

File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py" in save
  808.                        force_update=force_update, update_fields=update_fields)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py" in save_base
  838.             updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py" in _save_table
  924.             result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py" in _do_insert
  963.                                using=using, raw=raw)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py" in manager_method
  85.                 return getattr(self.get_queryset(), name)(*args, **kwargs)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py" in _insert
  1076.         return query.get_compiler(using=using).execute_sql(return_id)

File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/compiler.py" in execute_sql
  1112.                 cursor.execute(sql, params)

File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py" in execute
  79.             return super(CursorDebugWrapper, self).execute(sql, params)

File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py" in execute
  64.                 return self.cursor.execute(sql, params)

File "/usr/local/lib/python2.7/dist-packages/django/db/utils.py" in __exit__
  94.                 six.reraise(dj_exc_type, dj_exc_value, traceback)

File "/usr/local/lib/python2.7/dist-packages/django/db/backends/utils.py" in execute
  64.                 return self.cursor.execute(sql, params)

File "/usr/local/lib/python2.7/dist-packages/django/db/backends/sqlite3/base.py" in execute
  328.         return Database.Cursor.execute(self, query, params)

Exception Type: OperationalError at /product/4/import_scan_results
Exception Value: table dojo_engagement has no column named deduplication_on_engagement```

A new commit was added yesterday, try on the command line python manage.py makemirgrations, then python manage.py migrate

Ok, it's the latest PR that did that not Scout. I'll take a look.

Hi @aaronweaver,
I made another test with another fresh download and it fails to import the scans and send this error to the console:
Network ACLs allow all egress traffic...
Internal Server Error: /product/2/import_scan_results
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/product/views.py", line 380, in import_scan_results_prod
    return import_scan_results(request, pid=pid)
  File "/usr/local/lib/python2.7/dist-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/FILES/django-DefectDojo/dojo/engagement/views.py", line 540, in import_scan_results
    item.save(dedupe_option=False)
  File "/FILES/django-DefectDojo/dojo/models.py", line 1220, in save
    self.hash_code = self.compute_hash_code()
  File "/FILES/django-DefectDojo/dojo/models.py", line 1084, in compute_hash_code
    for e in self.endpoints.all():
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/fields/related_descriptors.py", line 513, in __get__
    return self.related_manager_cls(instance)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/fields/related_descriptors.py", line 830, in __init__
    (instance, self.pk_field_names[self.source_field_name]))
ValueError: "<Finding: Network ACLs allow all egress traffic...>" needs to have a value for field "id" before this many-to-many relationship can be used.```

Ah ok, I know about this error, it's actually related to de-dupe.


--math flag broken?

My intention was to shift the particles by 49 pixels to recenter some drifting class averages.  I've tried a few variants of the --math flag without success.  Any ideas?  Thanks for sharing your script and for any advice.
python /location/_git/StarTool/startool.py job217_particles.star --math _rlnCoordinateX=_rlnCoordinateX+49 --write_selection job217_particles_add49x.star
usage: startool [-h] [--info [INFO]] [--show [SHOW]] [--use USE]
[--select SELECT] [--select_regex SELECT_REGEX]
[--select_star SELECT_STAR] [--select_fancy SELECT_FANCY]
[--release [RELEASE]] [--deselect [DESELECT]] [--sort SORT]
[--tros TROS] [--subset SUBSET] [--add_col ADD_COL]
[--delete_col DELETE_COL] [--rename_col RENAME_COL]
[--delete_table DELETE_TABLE] [--rename_table RENAME_TABLE]
[--replace REPLACE] [--replace_regex REPLACE_REGEX]
[--replace_star REPLACE_STAR] [--delete [DELETE]]
[--merge MERGE] [--query QUERY]
[--write_selection WRITE_SELECTION] [--write WRITE]
i
startool: error: unrecognized arguments: --math _rlnCoordinateX=_rlnCoordinateX+49
python /location/_git/StarTool/startool.py job217_particles.star --math _rlnCoordinateX=_rlnCoordinateX + 49 --write_selection job217_particles_add49x.star
usage: startool [-h] [--info [INFO]] [--show [SHOW]] [--use USE]
[--select SELECT] [--select_regex SELECT_REGEX]
[--select_star SELECT_STAR] [--select_fancy SELECT_FANCY]
[--release [RELEASE]] [--deselect [DESELECT]] [--sort SORT]
[--tros TROS] [--subset SUBSET] [--add_col ADD_COL]
[--delete_col DELETE_COL] [--rename_col RENAME_COL]
[--delete_table DELETE_TABLE] [--rename_table RENAME_TABLE]
[--replace REPLACE] [--replace_regex REPLACE_REGEX]
[--replace_star REPLACE_STAR] [--delete [DELETE]]
[--merge MERGE] [--query QUERY]
[--write_selection WRITE_SELECTION] [--write WRITE]
i
startool: error: unrecognized arguments: --math _rlnCoordinateX=_rlnCoordinateX + 49
Here I was just curious if the --math flag was working.
python /location/_git/StarTool/startool.py job217_particles.star --math _rlnCoordinateX=_rlnCoordinateX --write_selection job217_particles_add49x.star
usage: startool [-h] [--info [INFO]] [--show [SHOW]] [--use USE]
[--select SELECT] [--select_regex SELECT_REGEX]
[--select_star SELECT_STAR] [--select_fancy SELECT_FANCY]
[--release [RELEASE]] [--deselect [DESELECT]] [--sort SORT]
[--tros TROS] [--subset SUBSET] [--add_col ADD_COL]
[--delete_col DELETE_COL] [--rename_col RENAME_COL]
[--delete_table DELETE_TABLE] [--rename_table RENAME_TABLE]
[--replace REPLACE] [--replace_regex REPLACE_REGEX]
[--replace_star REPLACE_STAR] [--delete [DELETE]]
[--merge MERGE] [--query QUERY]
[--write_selection WRITE_SELECTION] [--write WRITE]
i
startool: error: unrecognized arguments: --math _rlnCoordinateX=_rlnCoordinateX
python /location/_git/StarTool/startool.py job217_particles.star --math _rlnCoordinateX=_rlnCoordinateY --write_selection job217_particles_add49x.star
usage: startool [-h] [--info [INFO]] [--show [SHOW]] [--use USE]
[--select SELECT] [--select_regex SELECT_REGEX]
[--select_star SELECT_STAR] [--select_fancy SELECT_FANCY]
[--release [RELEASE]] [--deselect [DESELECT]] [--sort SORT]
[--tros TROS] [--subset SUBSET] [--add_col ADD_COL]
[--delete_col DELETE_COL] [--rename_col RENAME_COL]
[--delete_table DELETE_TABLE] [--rename_table RENAME_TABLE]
[--replace REPLACE] [--replace_regex REPLACE_REGEX]
[--replace_star REPLACE_STAR] [--delete [DELETE]]
[--merge MERGE] [--query QUERY]
[--write_selection WRITE_SELECTION] [--write WRITE]
i
startool: error: unrecognized arguments: --math _rlnCoordinateX=_rlnCoordinateY

Current version works (for me). Can you try to pull the latest version? Should be 1.3.


NSHM point source object

Port of nshmp-lib PointSourceFinite object as PointSourceNshm. As far as I can tell there is only one significant difference between this and PointSource13b. Constructor for PointSourceNshm doesn not need depths[] array.

@pmpowers-usgs can you summarize what that significant difference was between this and PointSource13b? Also, I assume that NSHM18 used this version, but did NSHM14 use this version or PointSource13b? I want to make sure to label things correctly in the code, and probably keep PointSource13b as an option in BackgroundRupType if it's what was used in NSHM14.

Yes, the same point source model was used for 2014 and 2018 (our UCERF3 implementation didn't change). The new NshmPointSource has some refactoring in it that will make it a little more flexible if you want to use it for CEUS point sources down the road. Right now it (and PointSource13b) are essentially hard coded with the WUS depth distribution model. The only significant difference between the two is the removal of the minimum 0.5 rJB distance from PointSource13b. In NshmPointSource, if the site is coincident with the point source location, rJB = 0.0.


Cannot Do Unit Test

I am getting following error when i do the test.
ReferenceError: HTMLElement is not defined
at scrollParent (node_modules/react-lazy-load/lib/utils/parentScroll.js:12:28)
at LazyLoad.getEventNode (node_modules/react-lazy-load/lib/LazyLoad.js:91:14)
at LazyLoad.componentDidMount (node_modules/react-lazy-load/lib/LazyLoad.js:56:28)
at [object Object].invokeComponentDidMountWithTimer (node_modules/react/lib/ReactCompositeComponent.js:60:18)
as soon as i remove lazy-load component test run green

Solution is the attached Patch
From 0cfcf92b0a4929562ea0ad308603e0c7cd6954b3 Mon Sep 17 00:00:00 2001
From: "Alias Adil, Rehmatullah"<EMAIL_ADDRESS>Date: Thu, 8 Sep 2016 15:46:03 +0200
Subject: [PATCH] Fixes issue with HTMLElement

src/utils/parentScroll.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/utils/parentScroll.js b/src/utils/parentScroll.js
index e497941..4cfc154 100644
--- a/src/utils/parentScroll.js
+++ b/src/utils/parentScroll.js
@@ -3,6 +3,8 @@ const style = (element, prop) =>
? getComputedStyle(element, null).getPropertyValue(prop)
: element.style[prop];
+var HTMLElement = typeof HTMLElement === 'undefined' ? function(){} : HTMLElement;
+
const overflow = (element) =>
style(element, 'overflow') + style(element, 'overflow-y') + style(element, 'overflow-x');
--
2.8.1

Hey I want to flag this issue again. I am working with version 3.0.12. I am using mocha and enzyme testing framework. I cannot execute my unit tests for the same reason reported here. The patch suggested by @raliasadil does not work.

hello,
I'm having this same Issue I think, this is the complete log while trying to run test with jest.
"react": "^16.2.0",
"react-lazy-load": "^3.0.13",
`ReferenceError: HTMLElement is not defined
  at scrollParent (node_modules/react-lazy-load/lib/utils/parentScroll.js:15:28)
  at LazyLoad.getEventNode (node_modules/react-lazy-load/lib/LazyLoad.js:107:41)
  at LazyLoad.componentDidMount (node_modules/react-lazy-load/lib/LazyLoad.js:71:28)
  at commitLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4553:24)
  at commitAllLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5729:9)
  at Object.invokeGuardedCallback$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1559:10)
  at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1506:29)
  at commitRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:5833:9)
  at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6800:42)
  at performWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6750:7)

`
Any progress on the matter ? thank you!!

I had similar problem with jest. A simple mock helped:
jest.mock('react-lazy-load', () => (props) => props.children)

However, I have no idea how this applies to other testing suites.

@m8ms solution worked for me! Thanks!
https://jestjs.io/docs/en/mock-functions#mocking-modules