[ALLUXIO-1899] Avoid generate multiple BlockRemover threads for deleting locked blocks

https://alluxio.atlassian.net/browse/ALLUXIO-1899

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9470/
Test PASSed.

Merged build finished. Test PASSed.

@saltylin thanks for the fix! the PR looks pretty much good to me. Left a few minor comments.

@apc999 Thank you for your review. I have addressed your comments.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9473/
Test PASSed.

Merged build finished. Test PASSed.

@saltylin Thanks for the fix! I left a few questions.

@gpang Using a set will cause concurrent problems. Suppose this situation: 1) the worker receives a heartbeat command from the master, which tell the worker to free a block, but there is already a BlockRemover for this block running now. 2) this existing BlockRemover finishes, and deletes the blockId from the set. 3) then handleMasterCommand is called, and since the blockId cannot be found in the set, a new BlockRemover will be created for this block which has been already removed.

@saltylin O ok. I see it now.
If the block does get successfully removed, how it is possible that a subsequent handleMasterCommand has the same blockId? Wouldn't the heartbeat say the blockId was removed, so the response handleMasterCommand would not ask to remove the same blockId?

@gpang As you see, this special case happens with only a small possibility. So you mean we should allow this possibility of error (eventually results in an exception log) for simplicity and better performance?

@saltylin I don't think performance will be a major issue. I just want to understand under which conditions would handleMasterCommand see a blockId that has a true value in mRemovingBlockIdToFinished. Thanks!

@gpang Suppose the worker has launched a BlockRemover to remove a specific block, and since it hasn't finished, the worker won't tell the master it has removed this block by heartbeat. Then the master will response the worker's heartbeat, telling the worker to remove this block again. Next, before calling handleMasterCommand the BlockRemover successes, and flips the corresponding boolean value in mRemovingBlockIdToFinished to true. Next handleMasterCommand starts, and will find the block's value is true now.

@saltylin Got it. Thanks for the explanation!

LGTM

+1 LGTM


Exiting noclip causes character to get stuck

So.
as I stated in title, exiting noclip causes my char to get stuck. as in no movement in any direction is possible. (with btw happened to me when using precursor ball, a FU thing, but in other circumstances) . the only way I can exit this gliched state is:

get hit by a attack that has knockback
if on BYOS ship, destroy a block behind me and enter Zero-G (out of noclip. entering Zero-G still puts me in this state)
reset the game (kinda obvious this would work)
use teleporter (while out of noclip)

but I managed to find a potential explanation what's happening, so I guess I will skip you a step. I noticed on the window that appears when /debug is on, the "player_vel" when not moving in noclip is not 0, 0 , but -nan(ind), -nan(ind). when moving it's set to two zeros. but when you stop nocliping the -nan(ind) velocity stands, with in turn causes this glitchy state. and it also explains why above things cause this state to stop. they simply cause a update to velocity in some way. the simplest fix would be to add a velocity changer to 0, 0 at the point where person disables noclip, preferably right after. the game would handle it from there applying potential gravity or letting character move slowly in space.

I can't reproduce this. What is your noclip bind and speed in the WEdit settings? Also, is there any chance you have some other mod that's controller your player's movement (state)?

whatever it is by default. and... no idea. I am using this modpack at the moment. and I don't really see anything that could be the culprit.

I mean hey. even if it is one of the mods fault, you can still add a thing like I mentioned as a safeguard, so if other mods not present there cause the same problem, it won't really matter, as it will simply kick in.

ok I went through all the mods I have and there is only one that edits anything movement related directly https://steamcommunity.com/sharedfiles/filedetails/?id=734173371

Could you give this version a go: https://github.com/Silverfeelin/Starbound-WEdit/archive/issue-45.zip
Make sure you don't launch from Steam.

ay. roger that cap

well. it works. the glitch no longer happens. you still get stuck if you tp with noclip on but a double tap of the nc button fixes it anyway. so... it is done. fixed


RVTEST_CODE_END use of RVTEST_SAVE_GPRS in env/arch_test.c doesn't work

Assembler messages:
Error: unrecognized opcode `rvtest_save_gprs x1 gpr_save'
The line with the error is
RVTEST_CODE_END
looking at the definition:
.macro RVTEST_CODE_END          // test is ended, but in no particular mode
.option push
.option norvc
.global rvtest_code_end       // define the label and make it available
.global cleanup_epilogs       // ALERT: tests must populate x1 with a point to the end of regular sig area
/ MPRV must be clear here !!! ****/
rvtest_code_end:                // RVMODEL_HALT should get here
#ifdef rvtest_gpr_save        // gpr_save area is instantiated at end of signature
RVTEST_SAVE_GPRS  x1        gpr_save
#endif
RVTEST_GOTO_MMODE           // if only Mmode used by tests, this has no effect
cleanup_epilogs:                // jump here to quit, will restore state for each mode
RVTEST_SAVE_GPRS used to be a macro:
.macro RVTEST_SAVE_GPRS BASEREG REG_SV_ADDR     // optionally save GPRs
But now it's been replaced with a define which doesn't match the call
#define RVTEST_SAVE_GPRSM(_BR, _LBL, ...)               ;\

Looks like an extra character got introduced in the macro name.
Try deleting the "M"  in  "#define RVTEST_SAVE_GPRSM"
(line 633 I think) and see if that fixes it.
On Wed, Apr 3, 2024 at 12:30 PM ssecatch-w @.***> wrote:

Assembler messages:
Error: unrecognized opcode `rvtest_save_gprs x1 gpr_save'
The line with the error is
RVTEST_CODE_END
looking at the definition:
.macro RVTEST_CODE_END // test is ended, but in no particular mode
.option push
.option norvc
.global rvtest_code_end // define the label and make it available
.global cleanup_epilogs //
ALERT: tests must populate x1 with a point to the end of regular sig area
/ MPRV must be clear here !!! ****/
rvtest_code_end: // RVMODEL_HALT should get here
#ifdef rvtest_gpr_save // gpr_save area is instantiated at end of signature
RVTEST_SAVE_GPRS x1 gpr_save
#endif
RVTEST_GOTO_MMODE // if only Mmode used by tests, this has no effect
cleanup_epilogs: // jump here to quit, will restore state for each mode
RVTEST_SAVE_GPRS used to be a macro:
.macro RVTEST_SAVE_GPRS BASEREG REG_SV_ADDR // optionally save GPRs
But now it's been replaced with a define which doesn't match the call
#define RVTEST_SAVE_GPRSM(_BR, _LBL, ...) ;\
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/450, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJREYNWUNFDUZYEOARTY3RKGJAVCNFSM6AAAAABFV55DO2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDGNZUGY3TCMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Same error. I suspect the problem is that that macro definition expects at least two parameters (if not more).
Out of curiosity, I fixed the "call":
RVTEST_SAVE_GPRS(x1, gpr_save)
And that does compile, though I haven't tested to see if it works yet functionally

That's what I thought, but ... where is arch_test.c??
There are no .c files in the arch_test repo that come to mind
On Wed, Apr 3, 2024 at 3:45 PM ssecatch-w @.***> wrote:

Same error. I suspect the problem is that that macro definition expects at
least two parameters (if not more).
Out of curiosity, I fixed the "call":
RVTEST_SAVE_GPRS(x1, gpr_save)
And that does compile, though I haven't tested to see if it works yet
functionally
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/450#issuecomment-2035733221,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJQCTTH3VCXG4GMVL73Y3SBB3AVCNFSM6AAAAABFV55DO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVG4ZTGMRSGE
.
You are receiving this because you commented.Message ID:
@.***>

My apologies! arch_test.h
https://github.com/riscv-non-isa/riscv-arch-test/blob/main/riscv-test-suite/env/arch_test.h


Can no longer reuse an ES installation between runs

In embedded-elasticsearch 2.4.4, a change was made (see below) to delete the ES installation directory before installing.  This means that it is no longer possible to re-use the ES installation between runs.  I have been using embedded-elasticsearch for development so that I can easily have a cleanable ES install on my laptop without needing to manage a full ES cluster.  That doesn't mean that I want it wiped every time though.  It was very convenient to be able to keep the data in there during development, but wipe and reinstall when necessary.
This (I thought) was the point of the cleanInstallationDirectoryOnStop option, but that is basically useless now.  It doesn't clean the directory when stopping, but it does it the next run regardless.
I think that this behavior should be made optional, either with the cleanInstallationDirectoryOnStop option, or a new cleanInstallationDirectoryOnStart option.
commit 9fd888bf0eefa9497321f6abb98da6b871dd60c1 (tag: embedded-elasticsearch-2.4.4)
Author: Grzegorz Kaczmarczyk<EMAIL_ADDRESS>Date:   Mon Feb 19 23:51:25 2018 +0100

    delete installation directory before installation

Ok, this looks like a bug. I will investigate why that change happened, and if there is no reason for it revert that commit

Is there an estimated time until this could be fixed? This is a real blocker to how we intend to use embedded-elasticsearch.

10 min for me to decompress elastic6.6 (> 100Mo !) it's too long
please


Authorization error for PR opened from a fork

Hello! We are using this action to put the preview link in the PR, but it seems to fail when the PR was opened from a fork, see for example https://github.com/lab-cosmo/equistore/actions/runs/4325090692/jobs/7550783309.
It works fine when the PR branch is on the same repository, and we have permissions: pull-requests: write in our YAML file.
Is there anything we can do on our side?

The full error is
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:6803:21
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  status: 403,
  response: {
    url: 'https://api.github.com/repos/lab-cosmo/equistore/pulls/161',
    status: 403,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      connection: 'close',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Fri, 03 Mar 2023 16:02:30 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'GitHub.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-api-version-selected': '2022-11-28',
      'x-github-media-type': 'github.v3',
      'x-github-request-id': 'A041:5D7B:15B9E58:2CC4E11:64021A16',
      'x-ratelimit-limit': '1000',
      'x-ratelimit-remaining': '989',
      'x-ratelimit-reset': '1677860013',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '11',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Resource not accessible by integration',
      documentation_url: 'https://docs.github.com/rest/reference/pulls/#update-a-pull-request'
    }
  },
  request: {
    method: 'PATCH',
    url: 'https://api.github.com/repos/lab-cosmo/equistore/pulls/161',
    headers: {
      accept: 'application/vnd.github.-preview+json',
      'user-agent': 'actions/github-script octokit-core.js/3.6.0 Node.js/16.16.0 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"body":"Fix #98 \\r\\n\\r\\n<!-- readthedocs-preview equistore start -->\\r\\n----\\n:books: Documentation preview :books:: https://equistore--161.org.readthedocs.build/en/161/\\n\\r\\n<!-- readthedocs-preview equistore end -->"}',
    request: { agent: [Agent], hook: [Function: bound bound register] }
  }
}

Ping @PicoCentauri

We moved this action to a separate worflow (we where previously using the same one that is building the docs on CI), and it works fine now. For anyone having the same issue, try using a separate worflow, triggered by
on:
  pull_request_target:
    types:
      - opened

What if the PR has been already opened, but new commits are added or a push is forced? What should be the type?
I have tried a number of possibilities and none has worked in https://github.com/SlicerDMRI/whitematteranalysis/pull/155.
Thanks.


v2-invis not working

This looks like a really well done project. Thank you!
Everything works perfectly with "v2".
When using "v2-invis" with the test project or my own project (with v2-invis keys), the submit button does not display.  Actually, noting below
@Html.Recaptcha(RecaptchaSettings?.Value)
is rendered.
I see this on the console.
Uncaught Error: reCAPTCHA placeholder element must be an element or id
at Object.Fd [as render] (recaptcha__en.js:517)
at _8092d0ab_3436_48f8_802d_0d776994c3d1 (Contact:71)
at $p (recaptcha__en.js:507)
at iG (recaptcha__en.js:508)
at recaptcha__en.js:521
at recaptcha__en.js:540
Thanks! Maybe I am missing something.....

Hi, yes v2-invis in this library was actually concept created by me. It was not a feature yet in v2 and only really existed at the time in the beta version of v3. It looks like v2 invis is now fully supported by Google in v2. I will have to update the library to support there version over mine. Hopefully this can be done in the next week or two. Thank you for the report!

This issue should be addressed here and in the 2.2.1 release.
Note: v2-invis by Googles design now requires the "id" of the button of your form. By default i assign this value to "recaptcha". So if you set id="recaptcha" on your button then no other changes should be needed. If you required control of your buttons id you can override this by supplying the id to the Recaptcha helper function (see intellisense for more information).


FP8 Memory Usage

How much more GPU memory will the TE layers consume vs a standard Pytorch layer? I'm seeing close to double the consumption for the opt-1.3b model when compared to standard opt-1.3b in fp16.

How are you configuring fp16? I had the same thing happen to me because I was using torch.set_default_dtype(torch.float16) to enable fp16 and that was being ignored with the TE layers because of #270

Maybe ignore my above comment, I'm actually seeing the same problem.
It seems to be exacerbated by the number of TE layers used. On an LLM, when I replace only the linears, my batch size needs to be reduced from 4 to 3. When I replace all layers as possible, batch size needs to be reduced from 3 to 1.

Are you using FP8 training? @jomayeri

Are you using FP8 training? @jomayeri
Any update to deal with the more memory usage with FP8？

@ksivaman are there updates for this?
I see increased memory consumption for fp8 AMP vs fp16 AMP


Update DrupalInstaller.php

Remove strange items.
Place contrib projects to contrib folders.

These changes violate backward compatibility. Try setting new paths differently. For example, as in Bitrix Installer.

I think, deleting composer/installers dependency - better way, then setting new paths as in Bitrix.


Add DateTime Build variables

Added a new class that hold the build year/month/day variables, see ticket #2

Nobody likes this idea?

I like it!

Please create an MSBuilder extension just like the ThisAssembly.Project instead. The date and time of the build are unrelated to Git, but surely useful for ThisAssembly.
Thanks!


Merge JW Sign Language playlists?

Hello my brother! Thank you so much for an amazing tool!
Would it be possible to do the same merge function for the playlists in the JW Sign Language app (JWSL)?
They are still .jwlibrary files but instead of Notes, Bookmarks, Underlining, and Tags the JWSL app only has playlists containing media entries with start/stop times and a end of file functionality (continue, stop, freeze, repeat). I've attached an example of an exported file containing 2 such playlists.

JWSL_UserdataBackup_2021-03-25.jwlibrary.txt
I tried importing JWSL into JWLmerge but it threw an error as I'm sure there are some significant differences in the content of the exported files. Just an idea that would probably benefit plenty of those involved in sign language groups and congregations.
Thank you!

@aslcouple Thanks for your suggestion. See also #36

I looked for some utility to merge JW Sign Language files and couldn't find any. So I decided to create my own utility. I published it today. There is still much room for improvement, but it's working.
https://github.com/pliniobrunelli/JWLSLMerge/releases/tag/1.0


doc: categorize demo files [gpu]

This commit is part of a series changes to categorize demo files by the plugin types. Specifically, this commit moves the files used by the GPU plugin demo to a dedicated folder.
Signed-off-by: Tonny Tzeng<EMAIL_ADDRESS>

Let's take #956 first


Fix fast refresh for features backed by useLoading

Not tested with anything except with useFont() on my own project.
Need your assessment whether this is a good idea.
Bug flow:

Call useFont() with any font
Loader gets executed because font has changed from undefined -> font
Component gets fast refreshed
Effect triggers again, but since prevSourceRef.current === source, it gets set to null even though font is still there

Bugfix is to only set it to null if there is no source anymore
Fixes #677

CLA signed!

@chrfalch should remove this pattern altogether? I lost track of what kind of input source could have a different identity but shouldn't trigger a new resource load. Or should we just remove the conditional branch that does setData(null)?

Not sure if we should remove the pattern, without it we won't be able to load resources correctly?

We can also add tests for this.

Yes - absolutely.

@chrfalch I lost track of what this does. Can you describe the flow and we could add tests for it.

@chrfalch I lost track of what this does. Can you describe the flow and we could add tests for it.

Same here :) Will look at it when I'm back :)

@chrfalch I would love to add tests for the prevSourceRef logic, but I'm struggling to make sense of it. Please send me some flow descriptions which I could transcribe as tests, or maybe we should remove them?


Create dependabot.yml

Added Dependabot configuration to automatically check for updates on packages on a weekly basis. It will also create a PR whenever there is an update.

Fixes: Issue - 311

@The-Reverse-Flash Can you check why the formatter is failing and fix it?
Thank you!

I will close it for now.


Enhancing Liquidity for Existing NFTs: Implementing Lock-up Mechanism to Return DN404 Tokens with Matching Token IDs

Hello DN404 community and developers,
I'm reaching out to propose an enhancement aimed at increasing the liquidity of already minted NFTs through the DN404 protocol. Specifically, I believe there is a significant opportunity to extend the utility and accessibility of our existing NFT assets by implementing a mechanism that allows for the locking up of an NFT in exchange for DN404 tokens that carry the identical token ID as the original NFT.
The current scope of DN404, which primarily focuses on tokens minted after 2024, seems to target a rather narrow market and community. By broadening this approach to encompass existing NFTs, we could significantly expand our reach and impact within the broader NFT ecosystem.
However, as I attempt to draft a contract to realize this functionality, I've encountered challenges in devising a robust logic that accurately matches the token IDs of the locked-up ERC721 tokens with the DN404 tokens returned to the user. This issue is crucial for ensuring that users can reclaim their original NFTs upon returning the DN404 tokens, thereby maintaining a seamless and secure exchange process.
I'm opening this issue to solicit feedback, suggestions, and potential collaborations from the DN404 community and developers. Our goal is to refine this concept further and explore viable implementations that could bring this idea to fruition. I believe that by working together, we can overcome the technical hurdles and create a more fluid and dynamic NFT market that benefits all stakeholders involved.
I don't know if this idea has already been addressed or if it's impossible, but I'll raise an issue. Thanks.

Rough idea: fill in all 10k bits in the exists bitmap.
Then whenever a token is wrapped, we will directly mint on the exact ID.
When it's burned in DN404, unset the bit in the exists bitmap.

Thanks, I've written a contract based on your idea and will start testing it soon, I'll update and come here again.
https://github.com/abitofdots/convertERC721toDN404

@abitofdots You gotta prefill all 10k bits in exists bitmap too.
Also, for _isTokenLocked, use Solady's LibBitmap, or the built-in bitmap in DN404.

Thnks you really ! Following what you said, I prefilled the existing bitmap with all 10,000 bits and replaced the existing bitmap with solady's LibBitmap.
Could you check the revised contract one more? Even if it's rough, It'd be very helpful for me.
https://github.com/abitofdots/convertERC721toDN404/blob/main/contracts/convertERC721toDN404.sol

@abitofdots Can you write some tests to ensure that only the original of the token can unwrap the token?

Sure. I'll have the tests ready and share it with you soon. Thanks for your fast feedback always.


portal: Add ability to modify/remove by index

This feature is handy for key managers that edit entries

Still have to test the delete function with Key Rack

Could use a rebase

Could use a rebase

I mean yeah, it's based on the mentioned PR and rebases just fine on main now


Create 2022-04-26-audit-log-release-note.md

Description & motivation
Adding release notes for Audit log.
To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

[ ] I've added versioning components, as described in "Versioning Docs"
[ ] I've added a note to the prerelease version's Migration Guide

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

should release notes have featured: false in the frontmatter ?


MySQL 5.6 turns on parallel replication

MySQL 5.6 turns on parallel replication and encounters the following error
set global slave_parallel_workers = 4
ERROR Mismatching entries, aborting: table_id: ### ERROR Unexpected: 0 events processed while iterating logs. Something went wrong; aborting. nextBinlogCoordinatesToMatch: <nil>
When I turn off parallel replication, I am doing a graceful switch.

Sorry, can you please explain again exactly what the status is, what you're trying to do, what happens? Please accompany with as much data as possible. I'm afraid I do not understand the question.

MySQL 5.6 Database-level replication causes the following error ERROR Mismatching entries, aborting:

I really want to help you out, but there's just not enough detail here. Please, be more verbose.
Taking a hunch: are you using Pseudo-GTID? Pseudo-GTID is not supported in MySQL 5.6 paralell (aka per-schema) replication.


[#117131037] Fixing the build: Double tags in stage

#117131037 Fixing the build: Double tags in stage
What
It seems that CI run twice and created a double tag of stage. Then staging tag-release failed because the script does not handle well two tags.
Scope
In this PR we add code so that

Not fail if there are two tags poiting to HEAD
Do not allow double tagging

Additionally, to help testing:

optionally disable git push
not fail if git remote is already configured

How to test
As we lack of a proper unit testing for this script, you can use this
minimum Dockerfile.
cat <<EOF > Dockerfile
FROM governmentpaas/git-ssh

WORKDIR /tmp
RUN mkdir -p /tmp/paas-cf
RUN cd /tmp/paas-cf && \
    git init && \
    git commit --allow-empty -m "First commit" && \
    git tag previous-0.0.1 && \
    git tag previous-0.0.2

RUN mkdir -p /tmp/git-keys && cd  /tmp/git-keys  && \
    ssh-keygen -f git-key -N '' && \
    tar -cvzf git-keys.tar.gz git-key git-key.pub

ENV GIT_PUSH=false

ADD ./concourse/scripts/tag-release.sh /tmp/

RUN cd /tmp && /tmp/tag-release.sh next- testaccount testenv 'previous-*' && \
    cd /tmp/paas-cf && git tag && \
    cd /tmp && /tmp/tag-release.sh next- testaccount testenv 'previous-*' && \
    cd /tmp/paas-cf && git tag

EOF

Run it as: docker build --force-rm=true --no-cache=true . in the repo directory
Who?
Anyone but @keymon

I've created #117133525 to test this in the future.
shellcheck failed the build: https://travis-ci.org/alphagov/paas-cf/builds/121388960#L657

It seems that CI run twice and created a double tag of stage

Do you know how this happened?

Fixed the shellcheck. BTW, annoying in my local shellcheck it did not fail.
It happened because there were two runs of the same commit in CI:

https://deployer.master.ci.cloudpipeline.digital/pipelines/create-bosh-cloudfoundry/jobs/pipeline-lock/builds/17
https://deployer.master.ci.cloudpipeline.digital/pipelines/create-bosh-cloudfoundry/jobs/pipeline-lock/builds/18

But I don't know how it was triggered twice. Concourse does not say.

But I don't know how it was triggered twice. Concourse does not say.

It's possible this was related to rolling out the pipeline locking. There was some odd triggering happening while the pipelines were being updated.

I think in GoCD  it was recorded why the job/pipeline was triggered, which was nice.

LGTM, and I appreciate the test instructions :+1:


Allow dependabot to update GH Actions + Docker

Description
Allow dependabot to update GH Actions + Docker Images
FHIR Team Checklist

[ ] Update the title of the PR to be succinct and less than 50 characters
[ ] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[ ] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[ ] Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
[ ] Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Skip

What type of PRs will this allow dependabot to make? The only docker image I know of in our code is the dotnet image for compiling our images.

/azp run

/azp run


Add SVG Mime type mapping

Add mapping from Mime type image/svg+xml -> .svg

This mapping already exists. Any mapping that we have ext -> mime will get automatically mapped from mime -> ext as well. The only time we need to explicitly specify a mime -> ext mapping is when there are multiple possibilities.


[5.3][IDE][SourceKit] Support escaped identifiers for the syntactic rename and related idents requests.

Cherry-pick of https://github.com/apple/swift/pull/31431

Explanation:
Sourcekitd's SyntacticRename and RelatedIdents requests would previously not account for the extra two backtick characters in escaped identifiers, e.g. giving a range covering [`fo]o`  rather than [`foo`].
This updates their ranges to include the backticks, and for syntactic rename, to account for them when comparing base names and argument labels with expected values. It also updates Swift -> ObjC name translation (used for cross-language rename) to account for them too.

Scope of issue: The rename refactoring would fail if any occurrence of the symbol being renamed was escaped. The RelatedIdents request returning the incorrect ranges caused editor features based on it (like Xcode's edit-all-in-scope) to behave incorrectly.

Origination: This has been an issue since the SyntacticRename and RelatedIdents requests were fist introduced.

Risk: Low. This only affects the rename refactoring, and RelatedIdents requests. It has no impact on the compiler.

Testing: Added regression tests covering escaped identifiers and all existing tests passed. Also checked Xcode behaves correctly with these changes when renaming in cross-language projects.

Reviewer: Ben Langmuir (@benlangmuir) on the master branch PR.

Resolves rdar://problem/46409010

@swift-ci please test

@swift-ci please nominate


fonts won't apply on FontMod v3

Tested on 64Gram. I noticed that when I use my yaml config with FontMod v3.0.1 the fonts don't replaced. But if I use FontMod v2.1 fonts replacement working great.
my FontMod config.zip
Here is comparison video: https://user-images.githubusercontent.com/2260980/176996103-cd0265c5-2c14-41a3-a85a-fa1b2f6300e1.mp4

same as in https://github.com/ysc3839/FontMod/issues/79

Are you using Windows 11 22H1? I found out that FontMod v3.0.1 doesn't work after I upgrade Windows from 21H2 to 22H1.

hi! Nope, I am using two PCs with Windows 10 Pro 20H2 and 21H2.

Are you using Windows 11 22H1? I found out that FontMod v3.0.1 doesn't work after I upgrade Windows from 21H2 to 22H1.

Same after upgrade to 22H2😓

I realize that I wrote the version number wrong. It should be "from 22H1 to 22H2." Edited now. 😅


Add derived impl of squaring for MontBackend

Description

Implements unrolled squaring algorithm for prime fields via the MontConfig macro. Incorporates the fix from #526.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

Where does the unroll actually happen? Is this only due to the attribute macro on the trait definition? If that's the case then already the default impl should be getting unrolled no?
What's the advantage of having two implementations, where the default trait impl and the one derived from macro are the same, as far as I can see? I think I might have missed some optimization step.


dependancy and ERROR thrown during installation and vue serve

Version
3.0.5
Reproduction link
https://github.com/ctfrancia/shop
Node and OS info
npm 5.6.0
Steps to reproduce
vue serve
What is expected?
to show the application after running the command
What is actually happening?
This dependency was not found:

@/components/HelloWorld.vue in ../node_modules/babel-loader/lib??ref--12-0!../node_modules/cache-loader/dist/cjs.js??ref--0-0!../node_modules/vue-loader/lib??vue-loader-options!./views/Home.vue?vue&type=script&lang=js&

To install it, you can run: npm install --save @/components/HelloWorld.vue

I have uninstalled and reinstalled both vue and @vue/cli. updated npm and reinstalled. During installation errors are thrown:
ERROR  Error: No files matching 'tests' were found.
Error: No files matching 'tests' were found.
at resolvedPathsByGlobPattern.reduce (/Users/christian/Desktop/personal_projects/shop/shop/node_modules/eslint/lib/util/glob-utils.js:244:19)

at Array.reduce (<anonymous>)

at Object.listFilesToProcess (/Users/christian/Desktop/personal_projects/shop/shop/node_modules/eslint/lib/util/glob-utils.js:242:59)

at CLIEngine.executeOnFiles (/Users/christian/Desktop/personal_projects/shop/shop/node_modules/eslint/lib/cli-engine.js:513:36)

at lint (/Users/christian/Desktop/personal_projects/shop/shop/node_modules/@vue/cli-plugin-eslint/lint.js:47:25)

at api.onCreateComplete (/Users/christian/Desktop/personal_projects/shop/shop/node_modules/@vue/cli-plugin-eslint/generator/index.js:106:25)

at Creator.create (/usr/local/lib/node_modules/@vue/cli/lib/Creator.js:176:13)

at <anonymous>

at process._tickCallback (internal/process/next_tick.js:188:7)

-------- ALSO --------
<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.11.3 || ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.11.3 || ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

This is a new bug and has never happened previously while starting a new project/running an old project.

why is it closed?

Quick fix:
Changed Home.vue:
import HelloWorld from<EMAIL_ADDRESS>to
import HelloWorld from '../components/HelloWorld.vue'
But there must be a better way.

I'm having the same problem

If using webpack-bundle-tracker, you can add this line to your chainWebpack configuration:
config.resolve.alias.set('@', path.resolve(__dirname + '/src'));

I am having the same problem but only within a multi-stage docker build and only when ran from a gitlab-runner. I have components under src/components/layout/{component} and I am importing them with import x from '@/components/layout/x' and the crazy thing that I can't pin down is that the build works on my machine and the build works on my machine using docker, but somehow the build does not work from the gitlab-runner doing the docker build. I cannot figure that one out but I'll put my config here for reference.
Dockerfile
# build stage
FROM node:12-alpine as build-stage
WORKDIR /app
COPY package*.json ./
RUN npm install
COPY . .
RUN npm run build

# production stage
FROM nginx:stable-alpine as production-stage
COPY --from=build-stage /app/dist /usr/share/nginx/html
EXPOSE 80
CMD ["nginx", "-g", "daemon off;"]

babel.config.js
module.exports = {
  presets: [
    '@vue/cli-plugin-babel/preset',
  ],
  plugins: [
    '@babel/plugin-syntax-dynamic-import',
  ],
};

vue.config.js
module.exports = {
  css: {
    loaderOptions: {
      scss: {
        prependData: '@import "~@/styles/variables.scss";',
      },
    },
  },
};

.eslintrc.js
module.exports = {
  root: true,
  env: {
    node: true,
    browser: true,
    es2020: true,
  },
  extends: [
    // add more generic rulesets here, such as:
    // 'eslint:recommended',
    'plugin:vue/essential',
    '@vue/airbnb',
  ],
  parserOptions: {
    parser: 'babel-eslint',
  },
  rules: {
    // override/add rules settings here, such as:
    // 'vue/no-unused-vars': 'error'
    'import/extensions': ['error', 'always', {
      js: 'never',
      vue: 'never',
    }],
  },
  settings: {
    'import/resolver': {
      alias: {
        map: [
          ['@', './src'],
        ],
        extensions: ['.js', '.vue'],
      },
    },
  },
  overrides: [
    {
      files: [
        '**/__tests__/*.{j,t}s?(x)',
        '**/tests/unit/**/*.spec.{j,t}s?(x)',
      ],
      env: {
        mocha: true,
      },
    },
  ],
};

@Matthew-Benson facing exactly the same problem like you! Local build (on windows machine) runs perfect. Build on GitLab CI Runner (inside kubernetes) fails, because of missing dependency. Changing from<EMAIL_ADDRESS>to '../components/....' doesn't solve the problem.
Versions:
Node: lts-alpine (14.15.4)
@vue-cli-service: 4.5.10
Any hints or version downgrades which might solve this?

@Matthew-Benson facing exactly the same problem like you! Local build (on windows machine) runs perfect. Build on GitLab CI Runner (inside kubernetes) fails, because of missing dependency. Changing from<EMAIL_ADDRESS>to '../components/....' doesn't solve the problem.
Versions:
Node: lts-alpine (14.15.4)
@vue-cli-service: 4.5.10
Any hints or version downgrades which might solve this?

@stefanhettich I'm so sorry! I did the classic bad-developer thing of solving my problem and not coming back to update what my solution was.
My issue was that I am using a case-insensitive file-system on MacOS - I named the folder in question @/components/Layout and then some commits later I realized the naming was weird and renamed the folder to @/components/layout and went about my merry day. A few days later when I was working on CI I ran into our crazy build issue. After hours of debugging I realized the folder in the kube runner was capital L Layout and not layout and because the directory layout could not be found it the build failed!
I opened the repo in the gitlab editor and renamed the folder there to layout but you could also just do that in any case-sensitive system and commit it.
Changing the folder casing on my Mac never got committed and pushed up because the file system sees no difference.
Hope that helps!

@stefanhettich I'm so sorry! I did the classic bad-developer thing of solving my problem and not coming back to update what my solution was.
My issue was that I am using a case-insensitive file-system on MacOS - I named the folder in question @/components/Layout and then some commits later I realized the naming was weird and renamed the folder to @/components/layout and went about my merry day. A few days later when I was working on CI I ran into our crazy build issue. After hours of debugging I realized the folder in the kube runner was capital L Layout and not layout and because the directory layout could not be found it the build failed!
I opened the repo in the gitlab editor and renamed the folder there to layout but you could also just do that in any case-sensitive system and commit it.
Changing the folder casing on my Mac never got committed and pushed up because the file system sees no difference.
Hope that helps!

@Matthew-Benson Thank you so much for your response!
It was exactly the same thing in my case. I had several mixins like EnvService.ts and renamed them locally to envService.ts and git did not handle that, because Windows doesn't seem to be case-sensitive.
Nevertheless, the issue is fixed, you saved my day! Thanks a lot!

@Matthew-Benson Thank you so much for your response!
It was exactly the same thing in my case. I had several mixins like EnvService.ts and renamed them locally to envService.ts and git did not handle that, because Windows doesn't seem to be case-sensitive.
Nevertheless, the issue is fixed, you saved my day! Thanks a lot!


[doc improvment] inconsistent usage of img_key and img_res_key in code base

I encountered a problem today using sq.pl.spatial_scatter, I have to use lowres image in my object, so I see the docstring said - Use ``img_key`` to display the image in the background.
https://github.com/scverse/squidpy/blob/e6b5b0ccd2739aa50b55c7628e685a6750249d8f/src/squidpy/pl/_spatial.py#L392
but when I specified img_key in sq.pl.spatial_scatter, I encountered error saying that it is not a valid parameter.
So I looked into the source code, and found sq.pl.spatial_scatter calls _spatial_plot
https://github.com/scverse/squidpy/blob/e6b5b0ccd2739aa50b55c7628e685a6750249d8f/src/squidpy/pl/_spatial.py#L47
in which the real parameter is named img_res_key
https://github.com/scverse/squidpy/blob/e6b5b0ccd2739aa50b55c7628e685a6750249d8f/src/squidpy/pl/_spatial.py#L57
but the docstring of _spatial_plot says img_key as well
https://github.com/scverse/squidpy/blob/e6b5b0ccd2739aa50b55c7628e685a6750249d8f/src/squidpy/pl/_spatial.py#L143
I wanted to submit a pr because this seems a simple fix, just fix the docstring would be good, but when I grep the code base I found

There seem to be a major name inconsistency, and I don't know what is the intended name in opinion of your team, so I gave up and file an issue.

hi @TTTPOB , thank you for pointing it out. Feel free to submit a PR for fixing the docstrings. Thank you!


Roll engine 42bb7c9eea9a..dc0187f21777 (15 commits)

https://github.com/flutter/engine/compare/42bb7c9eea9a...dc0187f21777
git log 42bb7c9eea9a..dc0187f21777 --first-parent --oneline
2019-12-24<EMAIL_ADDRESS>Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679)
2019-12-24<EMAIL_ADDRESS>Run and collect benchmarks (flutter/engine#14556)
2019-12-23<EMAIL_ADDRESS>Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678)
2019-12-23<EMAIL_ADDRESS>Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677)
2019-12-23<EMAIL_ADDRESS>fix selection issue (flutter/engine#14604)
2019-12-23<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670)
2019-12-23<EMAIL_ADDRESS>Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671)
2019-12-23<EMAIL_ADDRESS>Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672)
2019-12-23<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675)
2019-12-21<EMAIL_ADDRESS>Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667)
2019-12-21<EMAIL_ADDRESS>Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665)
2019-12-21<EMAIL_ADDRESS>Roll src/third_party/dart c260e4e8dac6..1db1a837f8c9 (8 commits) (flutter/engine#14606)
2019-12-21<EMAIL_ADDRESS>Roll src/third_party/skia 28b0c5d4b3bb..2723af6a6d43 (4 commits) (flutter/engine#14605)
2019-12-20<EMAIL_ADDRESS>View ref pair (flutter/engine#14602)
2019-12-20<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from VC7eE... to IZ278... (flutter/engine#14603)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/364161625

Commit queue failed; closing this roll.


Component stop() may fail dependent on goodby message

I'm using autobahn as client on a golang nexus router. I use the component API with asyncio. When I call Component.stop() it should quit the connection and not reconnect. That does work with crossbar router, however, not with nexus.  For nexus it results in an error and tries to reconnect.
The reason for that is, that nexus replies to goodby with "wamp.close.goodbye_and_out".  However, autobahn explicitly wants to see "wamp.close.normal" here. If I change this code to also accept goodbye_and_out everthing works fine.
I looked into the WAMP specification, and there is an example given explicitly using "goodbye_and_out" for session closing, hence I think this is a autobahn bug. (Why is the URI relevant anyway, isn't it just the message type that is important?)

Any update on this issue? Seems to be a clear violation of specification and hence should be fixed.

Any update on this issue? Seems to be a clear violation of specification and hence should be fixed.

Thanks, this works very well now!


mill can't run when project path contains ":"

reproduce bug
mkdir "bug : dir"
cd "bug : dir"
git clone --depth=1 https://github.com/com-lihaoyi/mill.git
cd mill/example/example-1
mill foo.run

It produces
Error: Could not find or load main class foo.Example
Caused by: java.lang.ClassNotFoundException: foo.Example
1 targets failed
foo.run subprocess failed

Which operating system? Can you post your mill --version?

mill --version
Mill Build Tool version 0.9.8
Java version: 11, vendor: Oracle Corporation, runtime: /gnu/store/q7cgz76gd930nij982j6yybhzrvr1jna-openjdk-11.28-jdk
Default locale: en_US, platform encoding: UTF-8
OS name: "Linux", version: 5.9.3-gnu, arch: amd64

I think we don't properly mask the : symbol, which is also the separator for the classpath parameter of java.exe.

I can't find any reference in the Java Documentation, how we are supposed to "properly" escape the colon. :-(

The issue is from which line of which file? Maybe I can have a idea

To run your main class, we need to launch a Java process with the correct classpath. As your project path contains a colon, also some elements of than classpath contain a colon. When we construct the cli parameters for the Java process we concat each path separated by a colon (or semicolon on Windows) but Java then deconstructs that classpath by splitting at the colon. As that results in incorrect paths it can't find your main and the ClassNotFoundException is thrown.
https://github.com/com-lihaoyi/mill/blob/93b78e52691cb1528243b047937d15fafebc3ec3/main/src/mill/modules/Jvm.scala#L108

I'm closing this as adding jar which itself contain a colon (:) in their file or directory name are not supported by Java. You you find a workaround, please comment and we can reopen an fix it.


Adds an Aura Consensus algorithm to Runtime

Now start the development network using the BABE algorithm.If there is only a single node, the network will not function properly after being shut down for a period of time, which is not conducive to internal testing.
So it makes more sense to change the BABE algorithm to the AURA algorithm.
The error message:
ClientImport("Unexpected epoch change")

Modify the design to use Aura directly.


TypeScript Declaration File Linking Causing Build Failure

TypeScript Declaration File Linking Causing Build Failure
When attempting to build the project, there is a critical error caused by the linkage between the  TypeScript declaration file (*.d.ts) index.d.ts and import from the src directory inside the js-moi-signer. This linkage issue is impeding the successful compilation of the project.
Additional Information:
Package Version: 0.1.2

closed in #23


Awards columns

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #65
Test URLs:

Before: https://main--bitdefender--hlxsites.hlx.page/drafts/scoman/image-list
After: https://feat-awards--bitdefender--hlxsites.hlx.page/drafts/scoman/image-list

The proposed authoring is

An alternative would be:

Are there more than 3 awards displayed ? The first is closer to how cards are authored, while the second is closer to how columns are authored.
The spacing looks wrong, as text should be close to the image.

The breakpoint from columns to row is 768 on the site.
Also, the images are usually not aligned on desktop - maybe the second type of authoring (images on one row, text in next row) - to allow better alignment.


[SPARK-18345][STRUCTURED STREAMING] Structured Streaming quick examples fails with default configuration

What changes were proposed in this pull request?
This PR fixes failure of a quick example of structured streaming with default configuration, because of failure of HDFS connection.

Fix to use local filesystem as checkpointLocation by default.
Fix a wrong branch condition of recoverFromCheckpointLocation in StreamingQueryManager.

How was this patch tested?
I test this with manual test: running a quick example of structured streaming with default configuration. With this fix, it works well without configuring HDFS.

cc @brkyvz

Hi @oza, thank you for this patch, however I'm not sure if this patch fixes anything. What was your problem, what didn't work for you?

@brkyvz Thanks for taking a look. The problem I faced is: without HDFS configuration, the quick example results in failure with connection error to try to connect to HDFS(full stack trace is attached on jira). How to reproduce is:

Download spark 2.0.1 or build trunk code.
Run the quick example: results in fail

The documentation is described as quick start, so I think we should avoid any configuration.

Now I understanding the behaviour. Based on this, I would like to suggest to add an option to disable checkpoint for the testing or quick start example.  What do you think?

I think the change you should make should be for:
https://github.com/apache/spark/pull/15806/files#diff-7dc261474784c6402f7020ffe7f61038R212
where you always append file:/// otherwise, it will use the default FS, which may be hdfs, or whatever
cc @marmbrus is there a reason we can't just create the temp checkpoint directory to be local? I understand that if someone's running the test in a distributed environment, then all machines will create checkpoint directories, but since it's temporary, and is not meant for recovery, isn't that okay?

@brkyvz thanks for explanation, I will fix the line to work it on local mode without any breakage.

@brkyvz @srowen could you check the latest PR? I added prefix "file:///" before the result of Utils.createTempDir, since Utils.createTempDir only creates local directory via java.io.File.

Updating patch based on kiszk's comment:
https://github.com/apache/spark/pull/15806#discussion_r87393524

I'm sorry, but I had a hadoop configuration on my local: I noticed it on PR about SPARK-18345. I will check whether it happens after clearing configuration.

This was my mistake of configuration. After clearing the configuration about Hadoop, it works well. Closing this as not a problem. Thanks all for helping me, reviewing patch!


Comprehensive ablation study of all tokeniser parameters

Description
A lot of features have been baked in TokenGeeX without any actual benchmarking or comparison against baselines or previous implementations of TokenGeeX.
For every added heuristic, feature or rule benchmark it!!!
Measure compression and the frequency distribution of tokens on a held-out dataset.

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
littlefish0331, @ilwwmmh, @Wushiyii, @dem0nix, @HugoZou, @R-Niagra, @kukuma210, @coderaky, @epogrebnyak, @codewithmitesh, @cisan86, @ronnin, @IngeniousArtist, @yashbhuva, @isahitya, @amankumaar, @progmatic-99, @jamzynoo, @shiyijun0, @cmxss, @zengzhen1994, @HeinKhantZaw, @CGodl, @ttllmm, @henrylao, @wind3, @nonameb3, @niskhakov, @thomcosta, @sobitd, @trungle15, @michaelchiche, @sinornis, @chi-bes, @JayamaniJai, @poppinlr, @Guillecaba, @AndyJoo, @kinalmehta, @saumilvachheta, @alvaroserrrano, @Prathamesh-V-Kirad, @nixdonut, @senabi, @wenhongming, @aniforverizon, @shrshk, @fernando-gap, @huzilonghu, @Orob0rus


pkg/listwatch: fix listwatch wrapping regression

Whenever a multi-listwatch contains only one listwatch, it
would simply use the underlying listwatch without any wrapper. This
improves performance and eliminates unnecessary go routines. This commit
fixes a regression [0] where a denylist-listwatch would wrap underlying
listwatches even if the denylist was empty.
[0] https://github.com/coreos/prometheus-operator/pull/2710/files#diff-b33bee110e95fb2f22d9da56b1630d89R68-R74
cc @s-urbaniak @brancz @LiliC @metalmatze

lgtm :+1:

good catch, thanks :+1:


Release 0.3.0

Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

(and after broken CI checks are fixed)


Add support for error handling in PowerShell deploy scripts

Hello,
I would love to contribute, where should error handling be applied? I assume this would be in research-hub/deploy.ps1.

Indeed, and what's practically the same script for the research-spoke.


Visual Studio Code (The windows has crashed)

The window has crashed
We are sorry for the inconvenience! You can reopen the window to continue where you left off. This showing pop window. I don't know how to open visual studio code?

Please provide additional details. From your description, it is difficult to understand the issue. Also please see this page for instructions on how to report crashes. https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues

Two days before I have clicked Visual Studio Code icon It has showing error (The window has crashed)
I am using windows 10 Single Lang.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I have already download and installed VS Code insider. But this vs code not running...

I have solved this.
https://stackoverflow.com/questions/31270774/visual-studio-code-always-reopens-previous-file-or-folder


TSConfckParseError relating to docusaurus in website when building UI package

Describe the bug
I get non-fatal errors when trying to npm run build inside the UI package
To Reproduce
cd packages/ui
npm run build

Expected behavior
shouldn't be errors relating to a website directory inside a UI package build.
Your Environment
- pdfme package: @pdfme/ui
- pdfme version: latest 3
- Operating system: Mac OSX
- Node.js version: 18.17.0

Your Error Log
[tsconfig-paths] An error occurred while parsing "/Users/pete/Projects/pennyblack/pdfme-upstream/website/tsconfig.json". See below for details. To disable this message, set the `ignoreConfigErrors` option to true.
_TSConfckParseError: failed to resolve<EMAIL_ADDRESS>in /Users/pete/Projects/pennyblack/pdfme-upstream/website/tsconfig.json
    at resolveExtends (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/tsconfck/dist/index.js:496:9)
    at parseExtends (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/tsconfck/dist/index.js:450:28)
    ... 5 lines matching cause stack trace ...
    at async build (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/vite/dist/node/chunks/dep-ErEj4WmL.js:64922:20)
    at async CAC.<anonymous> (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/vite/dist/node/cli.js:845:9) {
  code: 'EXTENDS_RESOLVE',
  cause: Error: Cannot find module<EMAIL_ADDRESS>  Require stack:
  - /Users/pete/Projects/pennyblack/pdfme-upstream/website/tsconfig.json
      at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
      at Function.resolve (node:internal/modules/cjs/helpers:116:19)
      at resolveExtends (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/tsconfck/dist/index.js:491:34)
      at parseExtends (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/tsconfck/dist/index.js:450:28)
      at Module.parse (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/tsconfck/dist/index.js:388:24)
      at async Promise.all (index 0)
      at async configResolved (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/vite-tsconfig-paths/dist/index.mjs:99:10)
      at async Promise.all (index 1)
      at async resolveConfig (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/vite/dist/node/chunks/dep-ErEj4WmL.js:66032:5)
      at async build (file:///Users/pete/Projects/pennyblack/pdfme-upstream/node_modules/vite/dist/node/chunks/dep-ErEj4WmL.js:64922:20) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
      '/Users/pete/Projects/pennyblack/pdfme-upstream/website/tsconfig.json'
    ]
  },
  tsconfigFile: '/Users/pete/Projects/pennyblack/pdfme-upstream/website/tsconfig.json'
}

### Additional context

_No response_

This error does not appear once the website code has been built once in your local copy.


[4076] Type argument rended as "?" when type is a using alias of a ge…

…neric.
Fixes #4076

This PR fixes #4072 also.


Biolink 2.1.0 distinction between biolink:Drug and biolink:SmallMolecule

Approach: SmallMolecule → drug conflation in NN, with Vlado providing the mappings

Awaiting data from Vlado. Needs review.

@cbizon to review data that Vlado has now sent.

@cbizon What's the latest on this task?

We have information from Vlado, which is fine.  But based on my poking around, I feel like we could pretty easily generate some mappings using rxnorm.
@jdr0887 is working on generalizing the conflation infrastructure within the nodenorm tool.  Once he has that, we should be able to implement this conflation pretty easily...


[GCP] Need to set authorized domains on consent screen

As part of setting up OAuth for IAP users need to setup authorized domains.
With a Cloud endpoints domain the authorized domains should include
<PROJECT>.cloud.goog

Fixed by #87

/assign @richardsliu


Add johnyob to allowlist

@johnyob you should be all setup to use ocaml-ci. Please try adding a repository and it should show up on https://ci.ocamllabs.io


Audio output

Hi, currently the app can receive audio input and text input (in json format), right ?
I just wanted to know, if it is also possible to have the conversations, including audio output from the realtime api ?
Or maybe if I am doing something wrong, or if it is not included in this POC ?
Like th eproject though extremely and its cool to integrate it in streamlit !

Yep--the streaming audio should be playing.  Do you not hear it?


fix timeline appearance in browser on smartphone

If you view the timeline with the language setting set to Japanese in your smartphone browser, user posts with long handles and names look like this (probably all languages where the browser automatically does the wrapping without recognizing the space between words will be like this)

If the name and handle are short, it will look normal like this

If the language display is set to English, even if the name is in Japanese, it will be displayed correctly like this

If you look at the timeline in Japanese, you will see posts from users with long handles and names like this (probably true for all languages where the browser automatically does the folding without recognizing the space between words)

Does this need the web-only condition?

Does this need the web-only condition?

Sorry, I don't know.
However, I limited it to web only because native apps don't need to modify it and react native doesn't have whitespace property.

See also #5322 by @quiple which I think is trying to fix the same issue

Oh!
I had missed that.
Sorry to hear that but I hope his 5322 works out.
Should I close this PR?

Oh!
I had missed that.
Sorry to hear that but I hope his 5322 works out.
Should I close this PR?

I don't know what the etiquette is for situations like this, and to be clear I wasn't meaning any criticism, I just thought it would be helpful to mention the other PR as they both seem to be tackling the same issue.
I would suggest leaving this open and let the Bluesky team decide what to do :)

I don't know what the etiquette is for situations like this, and to be clear I wasn't meaning any criticism, I just thought it would be helpful to mention the other PR as they both seem to be tackling the same issue.
Sorry for the misunderstanding. I don't feel criticized at all and I appreciate you telling me.

I would suggest leaving this open and let the Bluesky team decide what to do :)
Okay, I will do that :)


[material-ui]TextField] label doesn't take its place after clearing value via inputRef (uncontrolled state)

Search keywords
mui textfield clear ref uncontrolled
Latest version

[x] I have tested the latest version

Steps to reproduce
Link to live example: https://codesandbox.io/p/sandbox/cranky-moon-lcxtdf?file=%2Fsrc%2FControlledInput.tsx%3A5%2C52
Steps:

see default textfield ui - label inside input, placeholder is not shown
focus input - see that label shrink off, placeholder is shown
type something to input
click button which clears input via ref
see unexpected behaviour - label didn't back to its place, it is at top of input, placeholder is shown

Current behavior
After clearing value of input, label didn't back to its place, it is at top of input, placeholder is shown
Expected behavior
After clearing value of input, label back to its place(inside of input), placeholder hides
Context
I use uncontrolled state control of text field: i pass defaultValue prop and inputRef.
I use Google Chrome lates version
Your environment

npx @mui/envinfo
 System:
    OS: macOS 14.5
  Binaries:
    Node: 20.14.0 - ~/.nvm/versions/node/v20.14.0/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.14.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 126.0.6478.127
    Edge: Not Found
    Safari: 17.5
  npmPackages:
    @emotion/react: ^11.11.4 => 11.11.4
    @emotion/styled: ^11.11.5 => 11.11.5
    @mui/base:  5.0.0-beta.40
    @mui/core-downloads-tracker:  5.15.21
    @mui/material: ^5.15.18 => 5.15.21
    @mui/private-theming:  5.15.20
    @mui/styled-engine:  5.15.14
    @mui/system:  5.15.20
    @mui/types:  7.2.14
    @mui/utils:  5.15.20
    @types/react: ^18.2.66 => 18.3.3
    react: ^18.2.0 => 18.3.1
    react-dom: ^18.2.0 => 18.3.1
    typescript: 5.5.2 => 5.5.2

@evgeniyworkbel The CodeSandbox link you provided is private. Can you make it public?

@ZeeshanTamboli I had made

@evgeniyworkbel It is because the TextField component isn't re-rendering when the value is cleared through ref because direct manipulation via ref doesn't trigger a re-render in React. You can manually control the shrink state instead: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. However, it would be better to convert your component to a controlled TextField component to handle value clearing more effectively.

@evgeniyworkbel It is because the TextField component isn't re-rendering when the value is cleared through ref because direct manipulation via ref doesn't trigger a re-render in React. You can manually control the shrink state instead: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. However, it would be better to convert your component to a controlled TextField component to handle value clearing more effectively.

The CodeSandbox link you provided is private. Can you make it public?

@evgeniyworkbel It is because the TextField component isn't re-rendering when the value is cleared through ref because direct manipulation via ref doesn't trigger a re-render in React. You can manually control the shrink state instead: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. However, it would be better to convert your component to a controlled TextField component to handle value clearing more effectively.

The CodeSandbox link you provided is private. Can you make it public?

Made it public now.

The behaviour in example is weird

The behaviour in example is weird

What is weird?

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component.

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

And you can't do that with a controlled component? Can you show an example? Does the updated CodeSandbox work for you?

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

And you can't do that with a controlled component? Can you show an example? Does the updated CodeSandbox work for you?

https://codesandbox.io/p/sandbox/cranky-moon-forked-s55hpw?file=%2Fsrc%2FApp.tsx%3A17%2C36

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

And you can't do that with a controlled component? Can you show an example? Does the updated CodeSandbox work for you?

https://codesandbox.io/p/sandbox/cranky-moon-forked-s55hpw?file=%2Fsrc%2FApp.tsx%3A17%2C36

You are debouncing the function wrong. debounce from @mui/material returns a callback. See the updated CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-fn2x9x?file=%2Fsrc%2FControlledInput.tsx%3A18%2C17.

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

And you can't do that with a controlled component? Can you show an example? Does the updated CodeSandbox work for you?

https://codesandbox.io/p/sandbox/cranky-moon-forked-s55hpw?file=%2Fsrc%2FApp.tsx%3A17%2C36

You are debouncing the function wrong. debounce from @mui/material returns a callback. See the updated CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-fn2x9x?file=%2Fsrc%2FControlledInput.tsx%3A18%2C17. Also make sure to clear the callback after unmounting with debouncedOnChange.clear().

it makes sense but the problem remains: controlled input is debounced badly - user wants to type fast and controlled input don't allow this

The behaviour in example is weird

What is weird?

Label is not shrinked when is typing

I updated the CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-8wkr3q. As asked before, why don't you convert your component to controlled component to handle such cases seamlessly.

Because I need to debounce value inside to update search params

And you can't do that with a controlled component? Can you show an example? Does the updated CodeSandbox work for you?

https://codesandbox.io/p/sandbox/cranky-moon-forked-s55hpw?file=%2Fsrc%2FApp.tsx%3A17%2C36

You are debouncing the function wrong. debounce from @mui/material returns a callback. See the updated CodeSandbox: https://codesandbox.io/p/sandbox/cranky-moon-forked-fn2x9x?file=%2Fsrc%2FControlledInput.tsx%3A18%2C17. Also make sure to clear the callback after unmounting with debouncedOnChange.clear().

it makes sense but the problem remains: controlled input is debounced badly - user wants to type fast and controlled input don't allow this

You can sync the value with local state: https://codesandbox.io/p/sandbox/cranky-moon-forked-fn2x9x?file=%2Fsrc%2FControlledInput.tsx%3A15%2C31. I suggest asking such questions on StackOverflow.


Make storage.js a little more robust

Coverage decreased (-0.1%) to 81.259% when pulling fdf95a06e684645587adc187a610d9594ad5c5fe on eatonphil:more-robust-storage into 61d27f77bb03a9dd35c13d408879e7e002f51376 on linode:master.

thank you!


Change the type of the args list to String

Hi there, I was reviewing the convertArgs function and I realized that if the type of the args  list is changed to String instead of Object the method can be simplified. New values can still be parsed to string since args is a class field.
Thank you for reviewing this pull request, please let me know if you have any feedback related to my pull request.

Coverage decreased (-0.08%) to 67.488% when pulling fc285aca1e9bac4d7bc137daaa9bbd5ef5d5f6e6 on frankweb:simplify-convert-args-method into a9d4b41d3fa09375cccdca5f33c95f5e6bcb9b92 on satyan:master.

thanks


Spelling Error in error on Load Balancer page.

v0.27.0-rc4
Steps to Reproduce:

Add Load balancer
Add 1 target with no service/ports.
Click Create

Result:

Typo: "requried" should be "required"

Verified Fixed in v0.29.0-rc2


corrected some minor typos

Nothing much, just fixes two typos.

Hi @jsiegmund, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@jsiegmund : Thanks for your contribution to the Azure documentation! The author, @asmalser, has been notified to review your proposed change.

Thanks for the fixes !


Issue About After Take a Picture

After taking pictures will be stuck for a while, this problem can be improved?But the system camera after taking pictures, will not be stuck for a while
Please help me out this problem。thankyou

Hi! Can you please give more concrete details? What stuck means? And also what phone/api versions did you experience it with?

you can see gif file，phone version is android 5.0.2

Sorry for slow reply.
I looked into the issue and it seems that the root cause is that we are using Camera1 API by default since it is generally faster, less complicated and more reliable. You can switch to Camera2 API, which will fix that particular problem.
Here is how you can do it. When you prepare your Fotoapparat instance, just provide cameraProvider parameter like that.
.cameraProvider(v2(context))


Conditionally use Homebrew location for Spin plugins and templates

The current experience for installing spin is to either use the install script or build from source. Users should be able to install Spin using their favorite package manager, such as Homebrew. https://github.com/fermyon/spin/issues/641
I am working on creating a fermyon-spin Homebrew formula. Homebrew is sandboxed such that you can only install into a subdirectory of $HOMEBREW_PREFIX (/opt/homebrew on ARM macOs and /usr/local on Intel macOs ). The formula installs default plugins and templates to the $HOMEBREW_PREFIX/var/spin directory.
The plugin and templates systems look at $XDG_DATA_HOME or more specifically $HOME/Library/Application Support for macOS. This updates them to look for the existence of a brew installation of Spin and if exists, use the $HOMEBREW_PREFIX/var/spin directory for plugins and templates.
This is draft as to decide whether this is an approach we want to take. We also will need to add some way of detecting if plugins and templates also exist at the default location and warn users of a dual installation of Spin.

I don't know much about homebrew but this doesn't seem right to me. If I install e.g. iTerm from homebrew and spin from source, will spin see HOMEBREW_PREFIX?

Ohhh so the formula creates those dirs? I have no opinion then 😅

Yes exactly. In the formula install step, those directories are created:
  def spin_datadir
      var/"spin"
  end

  def install
    system "#{Formula["rustup-init"].bin}/rustup-init", "-qy", "--no-modify-path"
    ENV.prepend_path "PATH", HOMEBREW_CACHE/"cargo_cache/bin"
    system "rustup", "target", "add", "wasm32-wasi", "wasm32-unknown-unknown"
    system "cargo", "install", *std_cargo_args

    (spin_datadir/"templates").mkpath
    (spin_datadir/"plugins").mkpath

    system "#{bin}/spin", "templates", "install", "--git", "https://github.com/fermyon/spin", "--upgrade"
    system "#{bin}/spin", "templates", "install", "--git", "https://github.com/fermyon/spin-python-sdk", "--upgrade"
    system "#{bin}/spin", "templates", "install", "--git", "https://github.com/fermyon/spin-js-sdk", "--upgrade"
    system "#{bin}/spin", "plugins", "update"
    system "#{bin}/spin", "plugins", "install", "js2wasm", "--yes"
    system "#{bin}/spin", "plugins", "install", "py2wasm", "--yes"
  end


removed default bounding box per issue #87

change default bounding box from global to "no" bounding box in subscriber/downloader to support non-horizontalspatialdomain granule types.

our regression test is starting to annoy me...


Cannot get-schema when No project defined

my .graphqlconfig file
{
  "schemaPath": "schema.graphql",
  "extensions": {
    "endpoints": {
      "production": {
        "url": "https://api.github.com/graphql",
        "headers": {
          "Authorization": "Bearer ${env:API_TOKEN}"
        }
      }
    }
  }
}

current workaround is running this command
API_TOKEN=abc graphql get-schema --project github
expected behavior
the following command should run
API_TOKEN=abc graphql get-schema

I ran into the same issue. The project can be specified like this:
{
  "projects": {
    "Project Name": {
      "schemaPath": "schema.graphql",
      "extensions": {
        "endpoints": {
          "dev":  {
            "url": "http://localhost:3000/graphql",
            "headers": {
              "Authorization": "Bearer ${env:AUTH_TOKEN_ENV}"
            }
          }
        }
      }
    }
  }
}

graphql init
graphql get-schema -e dev

This commands works for me, note if you put -e dev, in the end, it will work

Still the same, this is a bug and should be fixed.
Does anybody know where the bug is in the code?

Currently we have new structure for GraphQL CLI and in the new alpha version 4.0.0-alpha.0 we suggest to use GraphQL Code Generator plugin of GraphQL CLI with Codegen's schema-ast plugin. Checkout new instructions and we will be happy to hear your feedback. Feel free to contact us using our Discord channel;
https://discord.gg/xud7bH

I've posted the wrong Discord link, this is the correct one: https://discord.gg/xud7bH9


Brainstorming WebP capable libraries

Gmagick (+), but has to be compiled
Optimus.io (+), PHP example available
Cairo (?), seems not

Gmagick:
It uses the WebP library from Google. So it does the same as cwebp. Same is true with Imagick and Gd, btw. I have googled a little, and found that Gmagick is also available as an extension [https://duntuk.com/how-install-graphicsmagick-gmagick-php-extension]. So it will be available on some systems. So adding gmagick to webp-convert will make conversion possible on more systems. Therefore, it will be a bonus to support gmagick. I'm however not sure how widespread gmagick is.
Optimus:
I know of optimus.io. I also considered that, back when I implemented ewww. It should be easy to implement.. And it would be nice to provide a converter for it, because it may have many users already. Only thing is that we should find out if we are allowed to do it.
Cairo:
I cannot find anything on webp on their site, so I guess its not supported

For Optimus.io, see here - since there's no dismissive license and people have to pay for licenses anyway, I guess nobody cares.

It seems that new converters are to be the theme of the 1.1.0 release...

I think the next converter in production line will be calling the imagick binary directly.

How about Glide ?


🥅 add REST response error handling

a possible fix to https://github.com/caikit/caikit/issues/346

Given the description of #346, I'm not sure this actually solves the problem of filling in "nullable" values. It looks like this would cause the example in the issue to return a 500 rather than a 200 with an empty value filled in for producer_id

In #346, I explained that a 500 makes sense in terms of pydantic because we're not providing all mandatory return type fields. So either we make fields optional, in which case, we get a 200 back, or, we provide a better error message (but the error still remains 500).
This PR is trying to address giving a better error message, and not filling in "nullable" values.


fix: fix errors in swap screen

Fixes #1711.
I did notice while doing this work the following:

Every time we update the margin or quantity, the channel details are fetched again - how often do we actually want this to happen?
There are some prices for which the minimum margin given by the validation is 1 sat less than what's actually needed to get a quantity of 1. This is hard to reproduce. Maybe worth opening a ticket for?

Every time we update the margin or quantity, the channel details are fetched again - how often do we actually want this to happen?

The channel details are fetched from the native backend on the app. That should be cheap I guess?  I don't think caching it (thus preventing a native call to the sled db) will have a huge impact. But give it a go if you think it will improve things.

There are some prices for which the minimum margin given by the validation is 1 sat less than what's actually needed to get a quantity of 1. This is hard to reproduce. Maybe worth opening a ticket for?

Hmm.. how is the minimum margin calculated?

The channel details are fetched from the native backend on the app. That should be cheap I guess? I don't think caching it (thus preventing a native call to the sled db) will have a huge impact. But give it a go if you think it will improve things.

To be honest, I'm not sure that it matters. The future seems to resolve immediately. If it took longer, we'd see a loading spinner while it resolves on each keystroke, which is theoretically bad. So it's more a matter of principle. Maybe it is worth caching it through in case of slower devices. How often would we want to refresh?

Hmm.. how is the minimum margin calculated?

// TODO: probably should be done in backend/cached?
final price = Amount.fromBtc(1.0 / tradeValues.price!).sats;

if (margin < price) {
  return "Min: $price";
}

  // TODO: this is bad for precision
  Amount.fromBtc(double btc) {
    _sats = Decimal.fromInt((btc * (100000000.0)).round());
  }

I stand by this being bad for precision without further investigation/vetting. Despite the fact that I copied and translated it from the Rust native backend, it may be using a different rounding strategy to the Rust side.


API: activity for creating event

{
  "ExistingConstituentId": "host's ID",
  "ActivityType": "Event Hosted",
  "ActivityDate": "[Date of event]",
  "Campaign": "[Category]",
  "Notes": "cat: Event URL, event location, ticket limit, price, location, event long description",
  "Code1": "event url",
  "Code2": "event location",
  "Code3": " event short description",
  "Number1": "ticket limit",
  "Number2": "price1",
  "Number3": "price2",
  "Date1": "[date event created]",
  "Date2": "[date event expected to happen]"
}

I guess we need to update this when the event changes?

All good


Update EntityLocalInterface for UseCase handling

Add API to remove multiple usecases in a single step
Remove API to only remove a single usecase
Update UseCase API calls, to use a new model.UseCaseFilter struct, which is used to invoke the action on all usecases matching the filter

Reasoning: Every individal usecase removal will trigger a SPINE message, and if multiple are remove, this triggers multiple messages which is not a desired outcome even though it would be valid. So the intention is to get only a single SPINE notify message with all removals already being part of.

coverage: 93.72% (+0.005%) from 93.715%
when pulling 36f6883f8f97845d3103f0d4376dd5de24b61c3c on feature/usecase-improvements
into 96e3b588e3361d86a1516b2982766861775db5ef on dev.


Add page about Ecto/Telemetry configuration

Although still a bit of a stub, this page explains how the Ecto/Telemetry configuration works, and how each of the parameters passed to it work.

Moved most of the Ecto docs to the Ecto page, and am now linking from the Phoenix guide to the Ecto one for more information.


IsBuyboxWinner missing from Offers.Listings

https://webservices.amazon.com/paapi5/documentation/offers.html#listings
https://github.com/nager/Nager.AmazonProductAdvertising/pull/151

@edmacdonald please add an example c# code

@tinohager Done.

I have publish a new version, thanks


Index developers.hero and developers.bio for search performance

Context: https://github.com/joemasilotti/railsdevs.com/pull/341#discussion_r833542319

I'll take it and will add more details regarding the approach of the implementation.

All yours! Thanks.

Hey @themudassarhassan, I'd love to get this working before we go live with the search box for everyone. Do you have any updates on this?

Hey @joemasilotti, unfortunately, I don't have an update right now as I have been occupied with other things lately 😞 But I'm planning to start working on this very soon, probably this week.

Sounds great - thank you! If something changes and you no longer have the appetite let me know and I can pass it off to someone else.

Hey @joemasilotti I have created the PR. Please review whenever possible. Thanks.

Closed via #379.


[FEATURE REQUEST] Combine Accounts in Balance Over Time Report

Is your feature request related to a problem? Please describe.
Balance over time shows individual accounts and gets pretty mess. You cannot see the day-by-day funds available and debts.
Describe the solution you'd like
I would like to be able to combine/group accounts in the Balance Over Time Report (e.g., group all Checking/Savings, group all Credit Card accounts).
Describe alternatives you've considered
This is basically the Net Worth Report but shown in daily increments rather than monthly, so maybe have options in the Net Worth to be able to also view by daily, weekly, bi-weekly increments?
Additional context

We use Trello to track Feature Requests so that users can vote on what they'd like to see next. This is crucial for us since there are so many requests and so little time amongst those of us who work on the Toolkit.
Your feature request has been added here and will need to be manually sorted.
This issue can now be closed.


convert 'proxmox' node from proxmox to truenas

Currently the host proxmox acts as both a NSF as well as a proxmox node (with an associated k3s VM).
It is not ideal to have the NAS act as double-duty as another purpose, especially in this environment with about 8 other physical nodes.
Therefore, the purpose of this issue to is facilitate the conversion of this host from a proxmox node to a standalone NAS, using the TrueNAS solution.

Workloads that will need to be addressed:

[ ] NFS clients (see /etc/exports)
[ ] borgbackup 'server' and associated configuration (see /etc/borgmatic/config.yaml, /etc/systemd/system/borgmatic.service, /etc/systemd/system/borgmatic.timer)
[ ] rcone backup and associated configuration (see /etc/systemd/system/rclone-sync.service & /etc/systemd/system/rclone-sync.timer)
[ ] UPS monitor and associated configuration (see /etc/nut directory)
[ ] manual backup scripts (see /root/backup directory)
[ ] prometheus-upsc-exporter (see /etc/systemd/system/prometheus-pve-exporter.service

Rough migration plan:

'handle' workloads above (probably backup configs for later reference in TrueNAS solution)
Stop nvr VM (uses NFS)
Scale-down the following k8s workloads that use NFS: flood, jackett, lazylibrarian, nzbget, plex, radarr, sonarr, tesla-dashcam, thanos, loki, minio`
export tank zpool: zpool export tank
shutdown proxmox node
boot TrueNAS USB/ISO
Install TrueNAS to SSD Samsung_SSD_850_EVO_250GB_S21NNXBG304131Y (use same host IP of <IP_ADDRESS>)
Import tank zpool and properly configure
Configure TrueNAS for NFS clients as before
Verify proxmox NFS client connectivity
Verify NFS client connectivity
Scale-up and verify k8s workloads NFS client connectivity
Go/No-Go decision on moving forward with TrueNAS
Remove proxmox node from proxmox cluster pvecm delnode proxmox from one of the other proxmox nodes

During step 4, proxmox would not cleanly export the tank zpool and I had to just forcefully shut it down.  The subsequent step #8 still worked properly however
Step 9 had a snag in that TrueNAS mounts the zpool inside /mnt (e.g. /mnt/tank) while proxmox had them mounted at root.  I did not want to mess with forcing trueNAS to mount it to a non-standard mountpoint and instead modified the proxmox and other NFS client configurations to mount them at the new mount-point.
Step 10 required fixing of permissions in /mnt/tank/proxmox/images to work properly
Step 12 required deleting and re-creating the nfs PVs and PVCs because the NFS 'path' is immutable

UPS configuration required manual setup outside of what the GUI can provide.  If the GUI configuration is attempted again, it will reset the configuration.  This is not ideal.

It is not possible to install the starship prompt because there are no FreeBSD binaries readily available that work in TueNAS

rclone backup solution implemented using built-in 'cloud sync' features to back-up /mnt/tank/backups/borg/ and /mnt/tank/data/minio/velero/restic/ directories.

borgbackup solution implemented by creating a 'jail' with configuration and settings persisted in /mnt/tank/iocage/jails/borg.  This jail is mounting /mnt/tank/backups/borg/ to /mnt/borg inside it's 'container'.
Added the necessary ssh keys and installed borg to the jail, and updated the client configurations (home, proxmox-b, proxmox-c).


Add to Play Store

Adding it to the Play Store would offer users a convenient and secure way to access the app.

This app was until a few months ago in the Google Play Store. But I removed it because the guidelines are getting stricter. e.g. Android Auto and much more.
Unfortunately, this app will never appear again for the Google Play Store.
If I would publish this app there again, is to be expected with large restrictions.
This project is a hobby and I do it on the side, so I don't care if it is in the Play Store or not.


add output=minimal to get_nodes_status

ensure that no shard calls are made when long-polling during dynamic batching

Closing since server default is output="minimal"


docs: Fix --args example for the application plugin

At least on the Windows 10 command prompt, both
gradle run --args 'foo --bar'

and
gradle run --args='foo --bar'

result in an "unbalanced quotes" error. Just using double quotes like
gradle run --args "foo --bar"

results in the error
No argument was provided for command-line option '--args'.

The only variant that works is by using double quotes and an equal sign
like
gradle run --args="foo --bar"

Verified to also work on Git Bash for Windows and Ubuntu Linux.
Context

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks @sschuberth! Merged with 779013d098b91311973fd1a1bbb3a50941000446

Does this option still work (as still in the 7.3 docs)? When I try it I get,
$ gradle run --args="foo --bar" -S

FAILURE: Build failed with an exception.

* What went wrong:
Problem configuring task :simulator:run from command line.
> Unknown command-line option '--bar'.

* Exception is:
...
Caused by: org.gradle.cli.CommandLineArgumentException: Unknown command-line option '--bar'.
        at org.gradle.cli.CommandLineParser$BeforeFirstSubCommand.onStartOption(CommandLineParser.java:319)
        at org.gradle.cli.CommandLineParser.parse(CommandLineParser.java:88)
        at org.gradle.execution.commandline.CommandLineTaskConfigurer.configureTasksNow(CommandLineTaskConfigurer.java:61)
        ... 135 more

@ben-manes, works fine here (i.e. in the ORT project) using ./gradlew :cli:run --args="analyze --help" with Gradle 7.3.1.

Thanks! I’ll check out your build to figure out what I misunderstood. Not figuring it out I went with the newer cli features for first class support (https://github.com/ben-manes/caffeine/commit/9818919d90a7066d37082049565ee588c33d18e4)

The problem was actually the old find-gradle script, which searches the directory hierarchy for gradlew and passes in the original arguments. It used $@, which splits quoted arguments, instead of "$@" to preserve them. That was actually bug fixed but only on the fallback path. That's what I get for keeping the habits of 2012 era best practices. 🙂


Allow flashlights on belts

About the PR

I went to add this when I realized you couldn't attach lanterns to your belt. I saw that Nairodian had been working on this in #12175, so I went ahead and started with their PR changes. It looks like it was just missing the equippedPrefix field. I also added some missing 'off' sprites for the lantern.
Why / Balance

I believe they are intended to be allowed on the belt due to the existing sprites. Either way, it makes sense that they could clip on to your belt.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Nairodian, Themias

tweak: Flashlights, seclites, and lanterns can be equipped on the belt.

Makes more sense than having it poke out of your pocket like a smartphone light


New plugin - virtualenvwrapper

A new plugin for virtualenvwrapper.

I'd consider this if the paths were hardcoded to a specific environment. Think this is best tossed in custom/ for now.


Only do daemon reloads on Puppet 5

Puppet 6.1 contains PUP-3483 which means daemon reloads are not needed.
This is useful because the systemd daemon reloads can easily trigger dependency cycles. For example, managing service x and y where y depends on x.

I know this PR isn't a very high quality now. I think right now I'm looking for some feedback on whether this is desired at all.

The new feature is cool, but I find that the current logic with Puppet >= 6.1 makes this code pretty complex… Could we maybe add a generic $manage_daemon_reload parameter and set it to default to false on Puppet >= 6.1 instead?

I was considering the same thing, but thought about a fact. That was IMHO ugly. A variable on the main class is IMHO a good way to reduce the duplication.

Updated.

I'm wondering if we get any benefit from exposing the internal variable as parameter? What about people that want to use the puppet-builtin but also use 3rd party modules that depend on the exec resource from this module?

@bastelfreak People really should not be triggering off of non-exposed API endpoints. If that functionality is needed, it should be wrapped in its own class as a specific trigger endpoint.

I agree. But that approach was once documented in the README.md: https://github.com/camptocamp/puppet-systemd/tree/0.4.0#unit-files
So I'm pretty sure many modules out there still rely on it. question is if we want to be nice to them allow them to workaround this or force them to update code.

@bastelfreak the daemon_reload class is still there and functions as it did before. It's just that right now the module will not trigger it itself anymore unless it's needed. Users are still free to include it and chain it themselves.
I also considered keeping the class and making it noop in 6.1+ but that still keeps the dependency cycles.
I think now this is a breaking change since users can no longer rely on the class being present though. They have to include it themselves.

ah, just wanted to approve it and add a label, but I don't have merge permissions anymore :(

Oh?

@ekohl could you rebase this please?

Rebased and applied a fix that I think should also work on Puppet 5. I had some troubles getting that env to even run on my dev setup so I'm waiting on Travis to confirm it really works.

I haven't had time to look into this. Now that Puppet 5 is EOL, any thoughts about dropping Puppet 5 support?

I haven't had time to look into this. Now that Puppet 5 is EOL, any thoughts about dropping Puppet 5 support?


Terminal cursor does not display correctly when cursor type is underline, verticalBar

As of the latest version of xterm.dart 3.4.1, the cursor does not seem to display correctly in the terminal if the cursorType is TerminalCursorType.verticalBar or TerminalCursorType.underline rather than block.
TerminalView(
    Terminal(
        maxLines: 10000,
        onResize: (width, height, pixelWidth, pixelHeight) {
            // ...
        },
        onOutput: (data) {
          / ...
        }),
      focusNode: _focusNode,
      padding: const EdgeInsets.fromLTRB(10, 10, 10, 0),
      cursorType: TerminalCursorType.verticalBar,
      textStyle: TerminalStyle(fontFamily: 'monospace', fontSize: 14),
);

However, if you set the font size to large(e.g. fontSize: 30), you may notice that the cursor appears in the wrong place in the terminal (at the top, as shown in the photo below).

This problem does not occur if the terminal cursor is of type block.

i have the same problem, also when typing with mobile keyboard and hint the enter button text replicate also auto correction problem
android device

@xtyxtyx

Big guy, look at this problem, I used to use it so well, but not today


Suggest bug report when process has unhandled exception

What feature would you like to see added to TallyArbiter?
process.on('uncaughtException', function (err) {
      //the cool stuff here
});

Use the uncaught exception function to send a socketio alert to the UI, suggesting they submit a bug report. We could either store the uncaught exceptions in an array and periodically send a socketio to the UI, in case the error happened when no one had the UI open. It would just be a nice way to catch errors we don't know about or help the user report bugs to us.
Would be helpful for users not running the electron version, which already has something like this.

I'm working on it.

Done in #157


Update reactivity.md

Change the compatibility priority of nextTick
https://github.com/vuejs/vuejs.org/issues/2132

@Mayness thank you for this contribution! :+1:


Added Instagram image generation

Flickr has a set maximum on providing 20 images through is public feed, so I decided to make something similar using Instagram which can provide more!
Pros:

Higher image limit, so more variety when generating content larger than 20 selections
Good for imitating social feeds
Cons:
Since it is more of a social feed, pictures won't be as HQ as flickr on average
Can't search multiple tags, only a single tag (fixable with doing multiple searches and adding the results)

Thats a cool idea! Thanks!


Series: Frontend 💜 OpenAPI

Todo

[x] Refine article Real live example of OpenAPI in a front-end project: How to best refer to a project structure. Screenshots? Meh. IDK.
[ ] Check SEO
[ ] Review

@lucienimmink  Publication dates need to be checked

@sanderdejong88 or @DaveBitter how are we going to publish this? I believe it doesn't make a lot of sense to release inclemently in the future, as I would be too excited to read everything at once. What do you say of a good old-skool Netflix release? Put the last article on todays date, and have each predecessor be a week earlier? This way it's a nice mix in the Articles list.

@sanderdejong88 @DaveBitter Updated the publication dates.


Add the methods in RTK query for Post and PUT and use them since they will invalidate the cache for us

Hey team! Please add your planning poker estimate with Zenhub @djnunez-aot @Ian-UX-AOT @jadmsaadaot @saravanpa-aot @VineetBala-AOT