Laptop touchpads are seen as gamepads

Godot version
4.0-alpha4
System information
Linux - Manjaro 21.2.5
Issue description
In Godot 4.0-alpha4, my laptop's touchpads are seen as gamepads. When no actual controllers are attached to my laptop, functions and signals such as Input.get_connected_joypads() and Input.joy_connection_changed.connect see two existing devices. When I add real controllers, they are assigned device ids from 2 and up. In contrast, this is not the case in Godot 3.4.3.
Godot 3 output at start
[blank]
Godot 3 output when I connect a Xbox 360
0 Xbox 360 Controller
Godot 4 output at start
0 SYNA8008:00 06CB:CE58 Touchpad
1 ELAN901C:00 04F3:2C29
Godot 4 output when I connect a Xbox 360
2 Xbox 360 Controller
Note that if the Xbox controller is connected when I launch the "game", it is seen with device id = 0.
A tool such as gamepad-tool yields the same results as Godot 3 (no additional devices detected).
Steps to reproduce
Create an empty project with a single Node2D and the following script attached
extends Node2D

func _ready():
	Input.joy_connection_changed.connect(self._on_joy_connection_changed)
	for device in Input.get_connected_joypads():
		print(device, " ", Input.get_joy_name(device))

func _on_joy_connection_changed(device, connected):
	print(device, " ", Input.get_joy_name(device))

Minimal reproduction project
No response

For completeness, I also tested on v3.4.4-rc2  and v3.5-beta2 and both behave as expected.

I didn't bisect, but I have a hunch that #57612 might be the culprit. It hasn't been cherry-picked for 3.x and 3.4 yet.
CC @maiself @madmiraal

I've created PR #59412 to increase the restriction on devices that are detected as gamepads that should fix this issue.

Solved by #59412. Thank you for your help.
Should I close the issue or wait for the PR to be merged?

Solved by #59412. Thank you for your help. Should I close the issue or wait for the PR to be merged?

The issue won't be fixed in master until the PR is merged. Therefore, we need to wait for the PR to be merged to close the issue.

For anyone else running into this issue, you can work around the issue by including this in any _ready() function:
if Input.get_connected_joypads().is_empty():
    for action in InputMap.get_actions():
        for event in InputMap.action_get_events(action):
            if event is InputEventJoypadMotion:
                InputMap.action_erase_event(action, event)

This obviously shouldn't be in production code. And it's also not cognizant of the fact that you might have both a joypad and a touchpad connected.

Looking forward to the merge! I see the suggested workaround above, and I don't quite understand it. I am in the process of figuring out how to get local multiplayer to work, and am adding a player instance to the scene for each connected gamepad. So my current workaround looks something like this:
var input_devices = Input.get_connected_joypads()

func _ready() -> void:
  for device in input_devices:
          if not Input.get_joy_name(device).contains("Touchpad"):
	    var new_player = player_scene.instantiate().setup(device)
	    add_child(new_player)

At least that's the relevant bit. Hope this helps someone, or that someone comments on why not to do this. Though ultimately, I don't intend to leave the number of players to be determined by how many devices are connected.

This can be seen in Input Map in project settings in beta14
(godot4-bin beta14-1 AUR package installed on Manjaro 22.0.0)
Since "Listening for input" is focused when adding new key to an action, it will immediately detect moving the mouse as Joypad Axis 0,1 or 2

I can confirm this on 4.0.beta16 while I was working on https://github.com/godotengine/godot-demo-projects/pull/830, but with a different kind of device. This is not limited to laptop touchpads; here, it was occurring with a motherboard LED controller:

https://github.com/godotengine/godot/pull/59412 is one of the proposed fixes and has been waiting nearly a year

As making the touchpad not usable as a input device is difficult and would make using certain gamepads impossible, can we not have a simple workaround: a way to stop the input system from registering a certain device name?

As making the touchpad not usable as a input device is difficult and would make using certain controllers impossible, can we not simply have a way to stop the input system from registering a certain device?

We could have a project setting with a list of device IDs that shouldn't be registered as controllers (plus an environment variable to append to this list), but this will require manual maintenance.

Yeah,  and have the list changeable.

I'm running into this problem with Godot 4.1.1 and none of the existing solutions worked to filtering out the joystick events being generated by the trackpad on my Framework laptop with Ubuntu 22.04.
However, I've noticed that Input.is_joy_known() returns false for these trackpads and not real joysticks, and so a workaround in my _input event handler that seems to be working for me is this:
func _input(event):
    if not Input.is_joy_known(event.get_device()):
        # Skip trackpad and only support real USB joysticks
        return
    # print("ID=" + str(event.get_device()) + " NAME=" + Input.get_joy_name(event.get_device()) + " KNOWN=" + str(Input.is_joy_known(event.get_device())))
    # Handle the rest of your InputEventJoypadMotion events here

Have you tried using my builds? Ive patched a fix into them.

This is a major issue for any usage of the engine on my laptop. Why is this waiting for so long?

This is a major issue for any usage of the engine on my laptop. Why is this waiting for so long?

See https://github.com/godotengine/godot/pull/59412#issuecomment-1759087924. The PR needs to be revised significantly (or even remade from scratch) before it can be merged.

You can use this script I made before the PR is ready.
I believe it's the best workaround to fix this issue according to the proposed solution:

For the time being, we'd suggest addressing the root issue in a simpler, yet more focused, way: blacklist devices that contain "touchpad" in their name (case-insentive, just in case).

It works on my "SynPS/2 Synaptics TouchPad" device. Tested on Godot v4.1.2.stable.mono only.
Not sure if you should use this in production. But it can at least help you for now, if you use a laptop for development. It's very simple and self-explanatory. Free to tweak the regex if needed. You can also remove the logging line.
Just add this script as an auto-load in your project settings. The node will just run the code at startup, then self-delete.
TouchpadIsNotJoypad.gd
# Public domain, as per The Unlicense. NO WARRANTY. See https://unlicense.org

extends Node
## Solves a [url=https://github.com/godotengine/godot/issues/59250]bug[/url] where touchpad devices
## can be detected as a joypad.
##
## This script should be autoloaded in the project settings.
## This is merely a workaround, not for use in production code.

func _ready() -> void:
	var pattern := RegEx.create_from_string('(?i)\\b(?:touch|track|click)pad\\b')
	for device_id in Input.get_connected_joypads():
		var device_name := Input.get_joy_name(device_id)
		if not pattern.search(device_name):
			continue
		# Device name contains "touchpad", "trackpad" or "clickpad" word, ignoring case.
		var guid := Input.get_joy_guid(device_id)
		var mapping := guid + ',' + device_name.replace(',', '') # not mapping any axes or buttons
		prints('Ignoring joypad device:', mapping) # you can comment out or remove this line
		# Replace with empty mapping on this guid. Should ignore all joypad input from this device.
		Input.add_joy_mapping(mapping, true)
	queue_free()

I've updated the code above to fix an issue.
Please update it if you're using it, and tell me if you get any issues.
The change is because even the touchpad device may take a few frames to appear (e.g. on Flatpak version of Godot), so now the check will run for every device connection instead of assuming the list of devices is ready at startup. Also, devices like drawing tablets can be connected at any time.
I've also updated the regex to match "mouse" and "pen" words as well. Note that this isn't exhaustive. I don't know if words like "pencil", "tablet", "stylus", etc. should be included. Tweak as needed.

I've updated the code in the gist again to fix another issue.
I'm now sending input events once to reset all of the device's SDL axes and buttons to zero upon disabling it.
This ensures it won't be stuck in motion, in case you were moving the touchpad during startup.
Please update if you're using the code (it's for v4.2 now, but should be trivial to port back by removing for type hints).

Any updates on this?

See the linked PR, but otherwise please don't bump things without information, if someone has an update they would have added it here :)

Any updates on this? Been holding off using godot because of this bug which makes working on a laptop a headache.

you can use my patches of godot which have this fixed.

I'm using pacman to install godot, is there an easy-ish way to use that patch without having to build from source? I'd want to keep getting updates for godot.
Or even better, are there plans to fix this on the actual godot project?

@Chris-Frendo Use my script from the gist above: https://github.com/godotengine/godot/issues/59250#issuecomment-1786196830

Yeah that helps for the project itself, but godot itself registers the touchpad as a joystick input when mapping something in the input map. Unfortunately I haven't found a way around that issue yet.

@Chris-Frendo I can't remember if merely making it a tool script (just adding @tool annotation on top of the code) would be enough to solve that, but maybe you can try it and see how it goes?

I'm quite a noob with godot so I can't saay for certain, but the annotation didn't really seem to fix the problem, however it did end up crashing godot when opening the project settings window, so something must be happened with the annotation.

I'm using pacman to install godot, is there an easy-ish way to use that patch without having to build from source? I'd want to keep getting updates for godot.

Unfortunately i only have an AUR package for the 2d version.

Has anyone still been having this happen with specific models of Synaptics touchpads? I notice several of these devices omit all of the current filtered words/patterns (e.g. 'touchpad', 'trackpad') from their device names, just being called "Synaptics." As a result, they will still make the inputs go crazy, whenever I playtest on some common ThinkPad laptops (P50, T480).
Reusing this previous workaround and adding 'synaptics' to the list of banned words/names completely alleviates the problem. Would denylisting 'synaptics' upstream interfere with any known joypads?

@TheBoctor Are you using Linux? A recent (kernel?) update changed the name on the touchpad device in my laptop. I know because I had to update settings and a script I was using to remap buttons with xinput.
For me, the device name was SynPS/2 Synaptics TouchPad, but became Synaptics TM2768-001.
So this issue should be reopened @Calinou, as the current solution will not work anymore.
I suppose the ideal would be to see if Synaptics has any sort of pattern regarding model names, and use that. For example, suppose all touchpad model numbers start with "TM" or with "T", then we could reasonably use this heuristic I think?
Unless there's a better way to use underlying low-level system calls to see if the device is being interpreted as a pointer, of course.

For me, the device name was SynPS/2 Synaptics TouchPad, but became Synaptics TM2768-001.
Yes, that's exactly the same format as the names my T480/P50 touchpads now show, with the "TM" initials and four digits. It must have either been a libinput or a kernel change. Either way, I would never have noticed the names changing between releases, good catch.


add "press space buttton to preview"feature

What's the Problem?
Hi Developer!
I'm Chinese user, i have installed Files <IP_ADDRESS>.

I'm macOS + WIndows user and very like a feature “press space button to preview” by macOS.
i have saw QuickLook GPL via “About” page, but i don't know how to enable this function
maybe i can use this function in future?
你好，开发者！
我是中国用户，我目前已经安装了 Files <IP_ADDRESS>。
我是 macOS + WIndows 用户，非常喜欢 macOS 的“按空格键来预览”功能。
我通过关于页面看到了 QuickLook GPL，但我不知道如何启用此功能
也许我将来可以使用这个功能？
Solution/Idea
add "press space buttton to preview"feature
增加按空格来预览的功能
Alternatives
add "press space buttton to preview"feature
增加按空格来预览的功能
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 1000.22000.493.0
Comments
No response

Hi thanks for you interest in Files. You need to install the QuickLook program (e.g from the windows store), launch it and then restart Files. You should be able to trigger preview with Space.


Update Wasmtime to 2.0.0

Should just be a routine update, nothing fancy going on here.

cd cli/tests/trap-test && cargo --locked test fatal_error_traps -- --nocapture
    Updating crates.io index
error: the lock file /home/runner/work/Viceroy/Viceroy/cli/tests/trap-test/Cargo.lock needs to be updated but --locked was passed to prevent this

@alexcrichton would you mind running make generate-lockfile? one of the test suite's fixtures has a lockfile that fell through the cracks

Indeed, can do!


[SPARK-46306][PS] Fix LocIndexer to work properly when the key is missing

What changes were proposed in this pull request?
This PR proposes to fix LocIndexer to work properly when the key is missing.
Why are the changes needed?
To match the behavior with Pandas.
Does this PR introduce any user-facing change?
For given DataFrame:
>>> psdf = ps.DataFrame(
...     {"a": [1, 2, 3, 4, 5, 6, 7, 8, 9], "b": [4, 5, 6, 3, 2, 1, 0, 0, 0]},
...     index=[0, 1, 3, 5, 6, 8, 9, 9, 9],
... )
>>> psdf
   a  b
0  1  4
1  2  5
3  3  6
5  4  3
6  5  2
8  6  1
9  7  0
9  8  0
9  9  0

Before
>>> psdf.loc[[3, 4, 1, 8]]
   a  b
1  2  5
3  3  6
8  6  1

After
>>> psdf.loc[[3, 4, 1, 8]]
...
KeyError: '4 not in index'

How was this patch tested?
Added unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.

Using tolist is not making enough sense on second thought. Let me close for now until figuring our better solution.


Removing blue border

Currently, there's a blue border around the sketch page which needs to be improved. Entire page should have the canvas

Hi , I am interested to do this.
Could you please assign this to me ?

Assigned for 1 day. Try to give a pr within 36 hours.


Start of upgrade

/retest

/retest

/retest

/retest

/retest

/retest

/retest

This was merged in another branch


Delay in last_update update

Describe the bug
Last friday it became obvious, that alexa has performance issues.
I had to increase the delay from 1 second to 5 in oder to have the sensor.last_called_alexa updated
All media_players need up to 5 Minutes to update their states and attributes when for example playing music.
Yesterday the media player entities update needed 15! Minutes before showing the right state
I had a strange error in my logs this night, which I've never seen before
To Reproduce
I'm using 'alexa_media.update_last_called' in tons of scripts which all had problems. I had to increase the delay
Expected behavior
At least a sensor refresh time of less then 3 seconds
Screenshots
If applicable, add screenshots to help explain your problem.
System details

Home-assistant (version): 2021.1.4    - update to 1.5 failed last week
Hassio (Yes/No): yes
RaspB3+. (Cpu between 3 and 8%, Memory 58%, SD Card utilization: 11%, DB 165MB)
alexa_media  (version from const.py or HA startup): 3.6.3
alexapy (version from pip show alexapy or HA startup):
Amazon 2FA is enabled (y/n). We will not debug login issues if unanswered: 2FA is activated

Logs
Logger: homeassistant.components.alexa.state_report
Source: components/alexa/state_report.py:126
Integration: Amazon Alexa (documentation, issues)
First occurred: 0:18:49 (5 occurrences)
Last logged: 5:19:53

Error when sending ChangeReport to Alexa: INVALID_ACCESS_TOKEN_EXCEPTION: Access token is not valid.

Additional context
My sensor:
last_called_alexa:
      value_template: >
        {{ expand(states.media_player.receiver, states.media_player.wohnzimmer, states.media_player.schlafzimmer, states.media_player.kuche, states.media_player.gastezimmer, states.media_player.office, states.media_player.fitnessraum,  states.media_player.bad_yvonne) | selectattr('attributes.last_called','eq',True) | map(attribute='entity_id') | first }}

Please do not exaggerate the issue. You identified a single issue related to last_called update. Also, please do not report logs from the built in integration to me. They're totally unrelated.

Please test the PR. This issue will go away with HA 2021.2.x anyway.

Please do not exaggerate the issue. You identified a single issue related to last_called update. Also, please do not report logs from the built in integration to me. They're totally unrelated.

Hi Alantse, sorry, I wasn't shure if this error was related to alexa_media or the built in integration.
Thanks for your support.
I will test that out asap.

Tested it. The issue is solved. Thanks a lot!


Proposal: Allow changing TextBox line spacing

Proposal: Allow changing TextBox line spcaing

Summary
Allow changing the line spacing in TextBoxes.

Rationale

This would be a useful option to have for multi-line TextBoxes as developers may want to change this
The line spacing is currently fixed in TextBoxes and cannot be changed easily

Scope

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Important Notes

Open Questions

I can work on a PR for that but, I don't think it's WinUI that handles it (I don't found any code related to TextBox on that repo)


BUG: Buy now button not visible on hover

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
on hovering over the buy now button the text inside the button is not visible

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned @root-0101


Support custom scopes and redirectUrl for U2M OAuth flow

Changes
Added following utility methods to DatabricksConfig
a. setRedirectUrl: This will be passed to OAuthClient and will be used in U2M OAuth flow if client wants to provide a custom redirect Url as per OAuth configuration of their application.
b. setScopes: Clients can set custom scopes for U2M OAuth flow. If offline_access is not present, it will be added to the scopes for refresh token support.
Tests
Tested manually using JDBC driver as a client. Also, added test case for custom values of redirectUrl and scopes.

Overall seems good, but I am not sure why we would want all apps to request offline_access scope, it seems like it should be opt-in like with the /token API itself.

Removed that. Now it is opt-in for clients.


⚠ Grafana1 has degraded performance

In 1e2826d, Grafana1 (https://grafana1.jenshamann.solutions) experienced degraded performance:

HTTP code: 200
Response time: 1935 ms

Resolved: Grafana1 performance has improved in 7a6ee48 after 7 minutes.


Deactivate anndata2ri after preprocessing

Best practice is probably to use local converters instead.
https://github.com/theislab/anndata2ri/issues/50

Thx for the contribution. To be honest... we don't even need anndata2ri here, but the other numpy conversion should be enough. For another time...


Filament v3 upgrade

Are you planning to upgrade to filament v3?
I could be of some help. I already have ideas of how we could implement new Panels (Project, Project Settings, Administration...)

Hey,
It's a good idea, if you have time make a PR and I'll try to help you.

Why not Nova over Filament?

This is an open source project, and with nova you need to have a license. It's much faster to develop it in nova but it will not server the same purpose.

@mihaisolomon are you the lead developer?

No, I'm just maintaining it, on my spare time.

Hello,
I created a PR: https://github.com/devaslanphp/project-management/pull/116 with the upgrade to Filament V3 . There are issues that needs to be solved.

Hi @mihaisolomon   (I am Solomun) :D
It would be great if it could be upgraded to v3.x.


Any plan for adding RPC/IPC support?

First of all,  great project, thank you so much for open sourcing it.
At the same time I have a suggestion:  why not provide some support for RPC/IPC interface?  With this approach,  users from different backtesting systems can take kungfu as an execution system/server, which is supposed to be the superior advantage of kungfu system, right?  This can detour the limit and open the door to attract much more users (potentially using different backtesting systems,  different languages other than python 2.7 and c++,  different oses othan than centos ) to join the community.

We surely will add such interfaces.

cool, thanks for confirming


[#3094] Add thread-pool settings

Codecov Report

Merging #5291 into master will increase coverage by 0.06%.
The diff coverage is 77.66%.

@@            Coverage Diff             @@
##           master    #5291      +/-   ##
==========================================
+ Coverage   40.08%   40.14%   +0.06%
==========================================
  Files        2697     2699       +2
  Lines       81574    81656      +82
  Branches    10924    10926       +2
==========================================
+ Hits        32700    32782      +82
+ Misses      45950    45947       -3
- Partials     2924     2927       +3

Impacted Files
Coverage Δ

.../pinpoint/profiler/sender/grpc/GrpcDataSender.java
0% <0%> (ø)
:arrow_up:

.../navercorp/pinpoint/grpc/server/ServerFactory.java
100% <100%> (ø)
:arrow_up:

...ava/com/navercorp/pinpoint/grpc/ExecutorUtils.java
53.84% <53.84%> (ø)

...grpc/internal/PinpointDnsNameResolverProvider.java
65.21% <65.21%> (ø)

...navercorp/pinpoint/grpc/client/ChannelFactory.java
94.36% <97.14%> (+1.18%)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.81% <0%> (-1.05%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e5142...790df89. Read the comment docs.


[feature suggestion] Add a quick control switch in Windows Action Center for PowerToy AWAKE

Description of the new feature / enhancement
It's a little bit annoying to find the icon in system tray , each time I want to toggle on/off the keep screen awake
Wondering is it possible to add a action center switch for PowerToy awake?
Scenario when this would be used?
Add a control switch in windows 10/11 action center.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/6751

/dup #6751

Thanks for pointing out!!


Added Dark Mode Toggle

solved the issue #4

please resolve the conflicts by syncing the latest fork.


cleanup: replace banned.h with semgrep

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine
/area CI

What this PR does / why we need it:
We used to have a banned.h header file that prevents you from using specific functions. The problem with it is that we have to manually add it to any .cpp file that we ever write. This does not happen in practice unless there is a specific header that always needs to be included (falco_common.h seems to be it but really is not). In libs we have decided to use semgrep in CI instead.
The advantage of using Semgrep is that we don't have to modify the code or remember to include any extra header. The disadvantage is that you won't get compile time errors but only CI time errors. Let's do the same in Falco and in libs.
In addition, a file was using strncat. Replace it with strlcat.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.37.0

LGTM label has been added.  Git tree hash: 59b9a0000ded79a003f216371a159fa2e21cc81e

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Slower than HF transformers?

The https://qdrant.github.io/fastembed/examples/FastEmbed_vs_HF_Comparison/#results show

do I interpret it correctly that the fastembed is slower than HF transformers?

Looks like an artefact of a specific run where Torch was on GPU while FastEmbed was on CPU. Let me run both on CPU and confirm if this is indeed true.

Thanks. So, is this now both on CPU?

Thanks. So, is this now both on CPU?

Yes, both on identical M2 Max without Metal optimisations as far as I can tell

So the results show that FastEmbed performance better but that much than HF Embed on CPU, right?
A (maybe) related question is: how to make FastEmbed run on M1 Pro with Metal? Following readme it seems just utilize CPU.
Thanks.

how to make FastEmbed run on M1 Pro with Metal?
It uses the M1 CPU for now

You can fork/clone the repo and add Silicon as a runtime. We don't have a way to test that reliably and hence we don't support it right now.

Good to know. Thanks for the reply.


Text tokenization

Hi all
I am non-German speaker  and I am trying to train a Tacotron 2 model on your dataset which by the way is a great job and contribution.
Any comments on how to do a character level tokenization on the dataset? or any tools you might point put?
Thank you

Hi and Thank you very much for these two repos they seem very useful


Fix nix-shell and nix-build

Alters the nix configuration so as to actually make use of the
separate hackage.nix pin.
Update the hackage.nix and haskell.nix versions sufficiently for the
new index-state. We bump haskell.nix only to the same version as
cardano-node, to take advantage of the cache.

@nc6 Since you updating nix config can you also update GHC to 8.10.7 in this PR?
https://github.com/input-output-hk/cardano-ledger/blob/7155301bcddc9cc2efe9cd98ad9c2521e9a0d085/nix/haskell.nix#L11

I can, though this is ultimately something we should coordinate across the various components.


[T3A5][W14-A4]TanJunAn

Ready for review

@yamidark
Some comments added. Please ack & close the PR after reading comments.


#476 fixed tooltips for "Rerun"

Description
Tooltips for "Rerun buttons" can now be seen.
Motivation and Context
There was a problem with async check for current suite version. I have now used ng-show instead of ng-if for these buttons (allows tooltips to be initialised).
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

Please also add this fix to changelog

CHANGELOG updated

Tested and accepted
Version: 3.3.1.SNAPSHOT


this attribute is removed when used in svelte:element

What version of prettier-plugin-tailwindcss are you using?
v0.1.10
What version of Tailwind CSS are you using?
v3.0.24
What version of Node.js are you using?
v16.13.0
What package manager are you using?
npm
What operating system are you using?
macOS, Windows
Describe your issue
Please take a look at this code:
Component.svelte (Before saving)
<script>
  export let href = ''
</script>

<svelte:element this="{href ? 'a' : 'button'}" href="{href}"></svelte:element>

Component.svelte (After saving)
<script>
export let href = ''
</script>

<svelte:element href="{href}"></svelte:element>

Problem:
When this file is saved/formatted by svelte.svelte-vscode, the this attribute gets removed and eslint shows the error <svelte:element> must have a 'this' attribute
Expected behavior:
this attribute should not be removed.
.prettierrc config:
{
  "tabWidth": 2,
  "printWidth": 80,
  "singleQuote": true,
  "trailingComma": "all",
  "semi": false,
  "arrowParens": "always",
  "htmlWhitespaceSensitivity": "ignore",
  "quoteProps": "consistent",
  "endOfLine": "auto",
  "bracketSameLine": true,
  "svelteStrictMode": true,
  "svelteIndentScriptAndStyle": false,
  "svelteAllowShorthand": true,
  "plugins": [
    "./node_modules/prettier-plugin-tailwindcss"
  ],
  "tailwindConfig": "./tailwind.config.cjs",
  "overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }]
}

Hey! I think you meant to open this on the Svelte Prettier plugin repo probably? We don’t do anything to Svelte syntax in this plugin, unless I’m misunderstanding.


feat: add provider_payment_methods to billing configurations

Add provider_payment_methods field to the CustomerBillingConfiguration model
Pull Request template
Please, go through these steps before you submit a PR.

Make sure that your PR is not a duplicate.

If not, then make sure that:
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.
b. You have a descriptive commit message with a short title (first line).
c. You have only one commit (if not, squash them into one commit).
d. python3 -m pytest tests doesn't throw any error.

After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
b. Describe your changes.
c. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
d. Add the corresponding labels to your pull request (ex: feature, improvement, bug...)

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

Thanks @willymwai for this PR 👍
Looks good to me, just minor comments related to tests:

Can you add it into the customer.json fixture?
Can you support it into the test customer client?

@rsempe Thanks the comment, worked on it.

@willymwai It's available on the latest version 🚀

Awesome 🎉


Fix setting RPC Path for chaos tests.

(and refactor resource name into rpcPath)

Codecov Report

Merging #45 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage    86.4%   86.69%   +0.29%
==========================================
  Files           2        2
  Lines         206      203       -3
==========================================
- Hits          178      176       -2
+ Misses         21       20       -1
  Partials        7        7

Impacted Files
Coverage Δ

drwmutex.go
85.4% <0%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f7da7...cf082c9. Read the comment docs.


RFC: Modules containing native functions

In its current state, this PR is a request for comments.
The context of this PR:

Use the wagon interpreter as a library in a bigger project and use it as a WASM interpreter;
The client code wants to make some of its internal functions available to the client.

The approach that is undertaken in this PR is to add a NativeFunctions section to Module, that lists the "native" functions to be called by the interpreter. It also adds a Native flag to theFunction struct, which is false by default.
When the interpreter encounters a call opcode, the Native flag is checked. If it is true, then a function is called.
This approach has issues I'm already aware of:

NativeFunctions is not specified in the standard
it makes module version management more difficult

In its current state, the PR has shortcomings that can be fixed:

native code might panic
it doesn't support calling functions with parameters
call_indirect is not currently supported

I'm looking forward to hearing your thoughts on the matter.

This change is

Good points, going a bit deeper in the spec I found that indeed goFunctions should just be a type of compiledFunctions. I understand from the spec:

Let hostfunc be the host function to allocate and functype its function type.
Let a be the first free function address in S.
Let funcinst be the function instance {type functype,hostcode hostfunc}
Append funcinst to the funcs of S
Return a

that the host(native) functions should always be at the end of the function index space.
As a result, I will also rename Native into Host.

Reviewed 5 of 5 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

exec/call.go, line 55 at r3 (raw file):

		vm.funcs[index].call(vm, int64(index))
	} else {
		vm.doCall(vm.funcs[index].(compiledFunction), int64(index))

could it call a call function on a compiled function instead?

exec/call.go, line 89 at r3 (raw file):

	}

	vm.doCall(vm.funcs[elemIndex].(compiledFunction), int64(elemIndex))

same here

exec/vm.go, line 262 at r3 (raw file):

		return nil, ErrInvalidArgumentCount
	}
	compiled := vm.funcs[fnIndex].(compiledFunction)

So it cannot run native Go functions here?

wasm/module.go, line 81 at r3 (raw file):

}

// ResoclveFunc is a function that takes a module name and

typo

Comments from Reviewable

Reviewed 4 of 4 files at r6.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

exec/call_test.go, line 21 at r4 (raw file):
Previously, sbinet (Sebastien Binet) wrote…
s/testNativeModule/m/

we are in the TestHostCall function.
I still feel it's a bit redundant here to call the module testHostModule instead of just m or module.
what do you think?

exec/call_test.go, line 92 at r6 (raw file):

}

var ModuleCallHost = []byte{

actually, perhaps unexport it?
(I know we are in a _test.go file, but...)

exec/call_test.go, line 107 at r6 (raw file):

func importer(name string) (*wasm.Module, error) {
	testHostModule := wasm.NewModule()

ditto.
I still feel it's a bit redundant here to call the module testHostModule instead of just m or module.
what do you think?

exec/vm.go, line 262 at r3 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
So it cannot run native Go functions here?

perhaps do a comma-ok type assertion and panic with some informative message?

exec/vm.go, line 334 at r6 (raw file):

			index := vm.fetchInt64()
			label := vm.popInt32()
			table := vm.funcs[vm.ctx.curFunc].(compiledFunction).branchTables[index]

here as well? (comma-ok + panic)

Comments from Reviewable

ah... @gballet, there's a conflict now with the just-merged PR #57.
could you fix it?
thanks.

resolved + squashed

merged as d4bc452.
thanks!


ci(workflow): add cache to workflows using actions/setup-node

Description
Add cache to workflows using actions/setup-node
Context
setup-node GitHub Action just released a new option to add cache to steps using it.
You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
Fix #44898

🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@weswigham I reviewed this and didn't see anything suspicious. Please merge if you like it.

First - it'd be super nice if you could split the formatting differences into a separate PR - I can't tell if the whitespace changes are good or bad.
Second - the GH actions build is currently a bit simpler than the DevOps one because it lacked caching - while caching most dependencies is fine, tslint (probably eslint and ts-related plugins nowadays) and typescript in the tree need to be cache-busted explicitly, so we always get the latest nightly of them. The DevOps build (which has caching) accomplishes this by explicitly uninstalling and reinstalling those dependencies after the initial (cached) install. I'm not sure if the node setup action's caching strategy is amenable to this, but we'd want it to do the same if it caches (since if we stop building against nightly tslint/eslint/typescript, we're liable to break the combination of them and not know when).

First - it'd be super nice if you could split the formatting differences into a separate PR - I can't tell if the whitespace changes are good or bad.
Second - the GH actions build is currently a bit simpler than the DevOps one because it lacked caching - while caching most dependencies is fine, tslint (probably eslint and ts-related plugins nowadays) and typescript in the tree need to be cache-busted explicitly, so we always get the latest nightly of them. The DevOps build (which has caching) accomplishes this by explicitly uninstalling and reinstalling those dependencies after the initial (cached) install. I'm not sure if the node setup action's caching strategy is amenable to this, but we'd want it to do the same if it caches (since if we stop building against nightly tslint/eslint/typescript, we're liable to break the combination of them and not know when).

If I'm understanding correctly:

ci.yml and ``

GitHub was messing up the indentation differences and I had to create a new PR from scratch... Sorry for the mess but I hope is not a problem 🙏🏽 🙏🏽 🙏🏽 🙏🏽 . This is the new PR: https://github.com/microsoft/TypeScript/pull/44924


.rules[].skip should also accept expressions, not only booleans

Tbh, I still can't come up with good use cases, but I kinda feel we will need this feature at some point.

We need to define clear semantics on how skip, condition and transform interact each other. Here's my brain dump:
skip: some_expression must behave identical to:
transform: |
  if (some_expression)
    return;
  <original_transform_script>

Rule should be considered invalid when:

skip: true (constant true) && transform: <script (not null)> because obviously the transform script is never executed.
(skip: null/undefined || skip: false) && transform: null/undefined because the exporter doesn't know what to do.
skip: <script (not null)> && transform: null/undefined because the exporter doesn't know what to do in case the script evaluates to false.

Unlike condition, skip is not involved in deciding which rule to use for the attribute. Fwiw, this is the exhaustive list of bahaviors.

condition evaluates to
skip evaluates to
behavior

true (default)
true
the attribute is skipped (i.e. no metrics for the attribute are exposed)

true (default)
false (default)
the transform script is executed

false
true
continue to the subsequent rule evaluation

false
false (default)
continue to the subsequent rule evaluation


Remove version specific requirement for mysql-connection-python and MarkupSafe

This change permitted a build in RHEL7, if prefixed with a pip install of wheel and a pip upgrade to 21.2.1.
C.f. #5

@JoyDajunSpaceCraft , can you review this PR, and merge if appropriate?


[Loggable]: Added support for doctrine attribute override in yaml

Added support for Attribute Override in Yaml
https://github.com/Atlantic18/DoctrineExtensions/pull/1366
http://doctrine-orm.readthedocs.org/projects/doctrine-orm/en/latest/tutorials/override-field-association-mappings-in-subclasses.html

thanks ;)


Inverse wave weighting for sampling in RDS

I realized that we already have weights implemented when drawing from the pool of eligible nodes in RDS. The weighting is currently done according to the inverse of the wave (i.e. those who were sampled from network closer to initial seed are more likely to be drawn):
new <- dplyr::slice_sample(eligible, n = 1, replace = FALSE, weight_by = 1/wave)

Do we want to change this?

Are there unconditional weights? E.g. before a seed is drawn could we
assess the probability some one enters the sample (surely yes via
simulation at least )
On Thu, 19 Nov 2020, 01:38 Georgiy (Gosha) Syunyaev, <
<EMAIL_ADDRESS>wrote:

I realized that we already have weights implemented when drawing from the
pool of eligible nodes in RDS. The weighting is currently done according to
the inverse of the wave (i.e. those who were sampled from network closer to
initial seed are more likely to be drawn):
new <- dplyr::slice_sample(eligible, n = 1, replace = FALSE, weight_by = 1/wave)
Do we want to change this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gerasy1987/hiddenmeta/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBE57P47HMEF5EXHOHR6NDSQRSHZANCNFSM4T2W2BEA
.

@macartan, yes, since everyone is drawn as a seed with equal probability and since probability of establishing a link within hidden population is also given we can definitely get the probability of someone entering the sample upfront.


[mono][test] Fix Exec timeout test

It is working around a difference in behavior in .netcore/HighSierra,
but isn't required for Mono.

@rainersigwald did you file a corefx bug for the change? the change is indeed unexpected.


update to 4.0.9

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


console.warn on loss of type safety in Config.getEnvCoerce()

Fixed by removing non-typesafe assertions


Put URL in repo description?

I mean at the top near "Leading to the dataviz you need "

Hi Maëlle, thanks for that, I will do once the site will be announced (in 2 weeks)

👍 note that the URL is in the README (I refrained from starring the repo 👼 )

Read me is now done. Links added. Thx Maëlle.


Abstract more code from your literate code document

Hey team,
please finish this task as we discussed:
Data import and wrangling -  @WeilinHan8
Input - all separate raw data.csv
Output - save_the_earth_processed_data.csv (further data type clean up included)
EDA -  @Jing-19
Input save_the_earth_processed_data.csv
Output - train_df.csv and test_df.csv
Model -  @tonyshumlh
Input: train_df.csv
Output: trained_model/pipeline, scaled_train_data, model_selection result, hyperparameter result
Model -  @Aishwarya120111
Input : Train data, test data, model result
Output : score tables, plots

Hi @WeilinHan8
please find my part in the PR https://github.com/UBC-MDS/DSCI_522_Group-11_Save-The-Earth/pull/32
thank you

@tonyshumlh @Jing-19 @WeilinHan8
I have created script for evaluation script. I am saving my tables and figures under result folder. Kindly review the PR #35

Hi team, I have finished the EDA part, please find the PR #34 !

Hi team, I have finished my part, please find the PR https://github.com/UBC-MDS/DSCI_522_Group-11_Save-The-Earth/pull/47


setButtonDisabled not working

Good afternoon, yesterday everything worked fine, the code did not change, but the error pops up. here is part of the code:
var optionsControl = {
        position: 'topleft', // toolbar position, options are 'topleft', 'topright', 'bottomleft', 'bottomright'
        drawMarker: true,  // adds button to draw markers
        drawPolygon: false,  // adds button to draw a polygon
        drawPolyline: false,  // adds button to draw a polyline
        drawCircle: false,  // adds button to draw a cricle
        editPolygon: false,  // adds button to toggle global edit mode
        deleteLayer: true,   // adds a button to delete layers
		cutPolygon: false,
		rotateMode: false,
		drawRectangle: false,
		drawCircleMarker: false,
    };

map.pm.Toolbar.setButtonDisabled('drawMarker', true);

If you remove the line map.pm.Toolbar.setButtonDisabled('drawMarker', true);, then there is no error, but this function is necessary. The error is like this:
Uncaught TypeError: Cannot read properties of undefined (reading 'children')                                              leaflet-geoman.min.js:1
at i._updateDisabled (leaflet-geoman.min.js:1:67669)
at i.disable (leaflet-geoman.min.js:1:64799)
at i.setButtonDisabled (leaflet-geoman.min.js:1:79813)
at (индекс):2717:16

We released yesterday version 2.12 you should revert back to 2.11.4.
In the demo it is working fine, can you please change it so that the error happens:
https://jsfiddle.net/4fw25e0b/

looked at your jsfiddle and there was a line map.pm.addControls(optionsControl); which I did not have, and before the update the code worked without it. After adding this line everything worked, thanks!

Bug description:
If map.pm.addControls() is not called but setButtonDisabled, then the container is not existing and then an error is thrown. https://jsfiddle.net/n6vk8eto/

If map.pm.addControls() is not called but setButtonDisabled, then the container is not existing and then an error is thrown. https://jsfiddle.net/n6vk8eto/

@vvlladd28 do you want to fix this?

Hi @Falke-Design,
I will fix this problem


Support serialization to stdout

Current coverage is 67.60% (diff: 0.00%)

Merging #19 into master will decrease coverage by 0.34%

@@             master        #19   diff @@
==========================================
  Files             1          1
  Lines           390        392     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            265        265
- Misses          125        127     +2
  Partials          0          0

Powered by Codecov. Last update 31780f1...4975be0

Thanks for spotting the unused out_format!


Support retrying or changing to card payment method

Closed in favor of https://github.com/CommerceWeavers/SyliusTpayPlugin/pull/83


Update FateWatcher for CN 5.2 release

Untested but from the looks of things it should match the intl version.

Oops, thanks for catching this.


[WIP] Fix imagick method names to lowercase as they are defined in code and PHP reflection

I have found out that there is disparity in method name case in:

code - uses readimageblob
PHP reflection - readimageblob
PHP documentation - readImageBlob - https://www.php.net/manual/en/imagick.readimageblob.php
these stubs - readImageBlob

I am using just this one method for now to avoid changing everything in case it is decided against it. I can change all the methods if we agree on this.
So as can be seen above these stubs are probably based on documentation, but according to the the authors of the extension https://bugs.php.net/bug.php?id=73766, the all-lowercase variant is actually correct (at least for now).
There aim is apparently to change this for Imagick extension v4: https://github.com/Imagick/imagick/issues/211 but I think it cannot be said definitely if that is the case and if so, then when this change will occur.
So the main question is whether these stubs are trying to match the actual code or the documentation. Ideally there should be no such question, but there is :) And since the php.net bug mentioned above is currently listed as documentation bug I think it should be changed to lowercase here as well to reflect reality (and eventually change it in the future if/when it changes).

Context: PHPStan started using these stubs for analysis of methods from extensions (when the extension is not loaded). In the strict rules you can enable checking for that method calls have correct name case - you can see that for example here it says https://phpstan.org/r/fbc488cb-1af6-4bd9-9b5f-47877cc65f89 is correct (because it uses information from this repository). But when you have the extension actually installed it would report it as incorrect (and vice versa https://phpstan.org/r/3dd45dcd-3ffc-469b-b9c3-8f6c51504989)

Since camelCase is prefered and there is no way methods will be case sensitive in the future, I'd leave that as it is. camelCase is more readable and really there is no reason to use "real" naming scheme.


Add interface for updated signal submission logic

Adding interfaces to support updated signal submission logic (submit_signals_v2), which allows clients to pass additional properties, a target client id for their signals, and multiple signals at once.

When and how do you want this change released? Protocol-defs 2.0.0 has been released, so this change should bump the version to either 2.1 or 3.0. We could release 2.1.0 with this change if needed. Otherwise the change will just sit here in the repo. We don't regularly release and integrate the common packages like this one.

When and how do you want this change released? Protocol-defs 2.0.0 has been released, so this change should bump the version to either 2.1 or 3.0. We could release 2.1.0 with this change if needed. Otherwise the change will just sit here in the repo. We don't regularly release and integrate the common packages like this one.

@tylerbutler Thanks for bringing this up. It would be great if it could be included sooner rather than later. Is a 2.1.0 currently scheduled for release?
The outcome of this work is to improve signals, in order to support sessions that contain a large number of clients. I will update client & server packages to use leverage these interfaces once it's available.

@GaryWilber Thanks for the info. We can release 2.1 with this change. Two more changes needed in this PR:

Update the version in package.json to be 2.1.0. I don't think it's needed, but run pnpm i to make sure the version change doesn't change the lockfile. Actually, I'm 99% sure it doesn't, so you can probably skip this and wait for a CI failure if I'm wrong.
Add a 2.1 heading to the CHANGELOG along with a summary of the change.


Abyssaline Lamp doesn't actually glow in 1.16.5

I commented on the mod page but I'll leave this comment here too just so it's more likely to get seen, sorry for spam. I really love the mod, but I noticed between this mod and XK's deco there's no blue lamps except the Abyssaline one, but it doesn't glow despite being called a lamp. Not sure if it's a name inaccuracy, a bug, or a removed feature, but it looks really nice so I wanna use it. Really hope this version isn't unsupported though.

probably you have not powered it with the chiseled abyssaline (check jei info)


Dependencies missing in .pom files

DBFlow Version: 4.1.0, 4.1.1, 4.1.2
Issue Kind (Bug, Question, Feature): Bug
Description:
Your dependencies are missing in the provided .pom files on jitpack, since you changed to the new gradle 3.0.0 api / implementation dependency syntax with 4.1.0.
Can you please check it and provide those information?
Invalid:
https://www.jitpack.io/com/github/Raizlabs/DBFlow/dbflow/4.1.2/dbflow-4.1.2.pom
Correct:
https://www.jitpack.io/com/github/Raizlabs/DBFlow/dbflow/4.0.5/dbflow-4.0.5.pom
Thank you in advance.
Best regards
Marco

use lowercase naming: https://www.jitpack.io/com/github/raizlabs/dbflow/dbflow/4.0.5/dbflow-4.0.5.pom
this comes out just fine. Must have been a jitpack.io bug.

@agrosner: It makes no difference, if I use the lowercase, for all version since 4.1.0, the dependencies are missing in the .pom files:
https://www.jitpack.io/com/github/raizlabs/dbflow/dbflow/4.1.0/dbflow-4.1.0.pom
https://www.jitpack.io/com/github/raizlabs/dbflow/dbflow/4.1.1/dbflow-4.1.1.pom
https://www.jitpack.io/com/github/raizlabs/dbflow/dbflow/4.1.2/dbflow-4.1.2.pom
You posted the .pom of 4.0.5 and that one is an example, where the dependencies where there.

looking at this: https://github.com/dcendents/android-maven-gradle-plugin/issues/61
just need to update plugin to 2.0+ which im doing for 4.2.3 :)


Crash with stacks on stacks

not sure who's end this is on, but i figured id leave this here either way.
http://pastebin.com/jPrLjtut

This is very unlikely to be Psychedelicraft's fault. It simply proxies the main render pass in this case, handling it like vanilla, and causing it to be part of the call hierarchy.


Search - Expense preview with multiline description shows two spacings between each line

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Submit an expense to a user with no unsettled expense, and include a multiline description in the expense
Note the expense preview in LHN shows one spacing between each line
Click on the search icon
Note that expense preview in search list

Expected Result:
The expense preview in search list will also show one spacing between each line
Actual Result:
The expense preview in search list alsos two spacings between each line
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/01f4bd19-4390-4b95-a4f0-ad19993ef37e
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

@dannymcclain , do you happen to know if this is expected behaviour?

@mallenexpensify I don't think it's expected—I would imagine the LHN and search rows would look the same. At the same time, I would say this is extremely minor.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The multi-line description of an expense request shows extra spacing between lines on the search page, but not in LHN.
What is the root cause of that problem?
This issue happens after my PR here. In the PR, we are fixing an issue where the LHN subtitle is shown as multiline when we set the expense description to multiline by replacing all new line characters with a whitespace.
https://github.com/Expensify/App/blob/2f5173c9c0f041967acfbdf9581ce52327623fa6/src/libs/ReportUtils.ts#L1630
The LINE_BREAK regex is then updated to consider a case where the new line character is \r\n as found here.
https://github.com/Expensify/App/blob/2f5173c9c0f041967acfbdf9581ce52327623fa6/src/CONST.ts#L1879
But the new regex (\r|\n) matches each \r and \n and replaces it with whitespace, so if we have \r\n, we will end up with 2 whitespaces. This isn't noticeable in LHN because the text style set the white-space to nowrap which collapses the whitespace into a single whitespace.

What changes do you think we should make in order to solve the problem?

Update the LINE_BREAK regex replace both \r\n into a single whitespace.
// stricter, if \n\r is given, then we will have 2 whitespaces, which I believe is expected
LINE_BREAK: /\r\n|\r|\n/g,

OR

// shorter, but will match \n\r too
LINE_BREAK: /[\r\n]+/g,

@dannymcclain If we updated it so that
Hello Hello
Didn't show as Hello Hello in LHN, it'd just show Hello.  In another example.  If someone sent.
Hi,  What's the ETA on the project' If we _fixed_ this to recognize the line break, we'd only show Hi,` in LHN.  I don't think that's better than showing ``Hi, What's the ETA on the project'
OOOOOOOF... check this weirdness
https://github.com/Expensify/App/assets/22508304/f11f9f3e-e86d-45e8-b780-d0db06312fa1

Whoaaaa, that is weird haha. I totally agree that "fixing" it to just show Hi, is not better than Hi,  What's the ETA on the project
In the video posted on the issue description, the LHN looks fine to me.
The expense description is
Hello
Hello

And the LHN displays Hello Hello.
But the search row displays Hello  Hello with an extra space between the lines.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Bumping to weekly and adding Needs Reproduction because this isn't a top priority and I want to suss things out next week once the site's doing better, then add it to a project.   We should def align on what we think is best for how we should multi-line posts in LHN from comments on reports as well as expenses, tasks, ???

We should def align on what we think is best for how we should multi-line posts in LHN from comments on reports as well as expenses, tasks, ???

cc @Expensify/design in case y'all have any strong feelings about this. (My feelings are all pretty mild right now.)

Yeah agree, but very mild here too. I think showing it the preview on 1 line is desirable, but without double spaces. That being said it's an extremely minor issue

I think showing it the preview on 1 line is desirable, but without double spaces. That being said it's an extremely minor issue

Totally agree.

Yup, similar feelings here as well.
Interesting that we even allow multi-line descriptions though and render them that way on the preview card... just flagging @trjExpensify for vis

Interesting that we even allow multi-line descriptions though and render them that way on the preview card... just flagging @trjExpensify for vis

I think for this one we have a cap at something like 40 characters or something like that, I can't recall exactly what it is but I remember it from before.

As for the bug in the OP, I agree it's really minor. @bernhardoj has identified his PR that caused it though, so can't we fix it as a follow-up to remove the second white space in Search? @parasharrajat for the C+ review as well to keep both on it.

@trjExpensify @mallenexpensify @shawnborton sorry to be a bit confused here, but what would be the course of action for me at this point? I see that there's a proposal that's widely approved by everyone here, so how do I help this move forward?

@carlosmiceli , this one is a lil tricky.  I assigned to @parasharrajat and @bernhardoj cuz of the below.

@bernhardoj has identified his PR that caused it though, so can't we fix it as a follow-up to remove the second white space in Search? @parasharrajat for the C+ review as well to keep both on it.

I guess we want to make sure the preview in the LHN only shows one space between the two lines.
But for me... I am wondering, do we want to accept multi-line descriptions in the preview card as well? Or should we force the line breaks to just become spaces?
Basically we don't allow for line breaks when you set a merchant, but we do when you set a description. And it creates an inconsistency when the preview card has a merchant vs when it has a description with a line break.
I don't feel too strongly here though, just noting that it's different. I think I would prefer to remove the line breaks and just use one line of text and stay consistent with truncating everything after two lines, both for merchants and descriptions
Also note, this is what it looks like when your description has three lines 🤦 we should fix this as well to remove the trailing ellipsis:

I think I would prefer to remove the line breaks and just use one line of text and stay consistent with truncating everything after two lines, both for merchants and descriptions
Also note, this is what it looks like when your description has three lines 🤦 we should fix this as well to remove the trailing ellipsis:

I'm on board for that update Shawn, and agree we should do our best to fix that little ellipsis dangler.

I think I would prefer to remove the line breaks and just use one line of text and stay consistent with truncating everything after two lines, both for merchants and descriptions

This makes sense to me too. 1 line work better especially when it's a preview and the full info is a tap away anyway.

@parasharrajat Just added the external label because I noticed it was missing, is that what you meant?

What's the status of this? @dannymcclain @mallenexpensify

I think we need a payment here?
cc: @parasharrajat

@carlosmiceli , when contributors are assigned to the issue (or, in the rare instance where they're not but they reviewed the associated/linked PR) we want to keep the issue open for payment. The BZ will manage the payment as well as ensuring a TestRail case is created, when needed.

@bernhardoj can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01aab5a64c2284bdc2
TR GH created, thanks @parasharrajat
https://github.com/Expensify/Expensify/issues/402725

@mallenexpensify accepted!

Contributor: @bernhardoj  paid $250 via Upwork
Contributor+: @parasharrajat owed $250 via NewDot
Thanks!

$250 approved for @parasharrajat


[WIP] Revert requirement on helm-tiller image.

We will add this later.
Signed-off-by: Jordi Massaguer Pla<EMAIL_ADDRESS>

Adding WIP tag until a decision is final on if helm-tiller goes in now or later.


Broken by use of "Log In as Another User" feature

Hi,
When I use the "Log In as Another User" then log out to return to my administrator account, so force-navigator doesn't work anymore - search bar doesn't find any salesforce page.
Regards,
Armagnak

Hi Armagnak, have you tried refreshing the metadata by typing "Refresh metadata"?


Add expose layer interpolation from CRTM interface to do some exploration.

I'm trying dig down into differences between IASI using standard atmospheres taken from RTTOV's interface. Trying to narrow down interpolation as a possible reason.

fixed with merge #46


NodeId as String not as numeric for Properties

In opendaq only objects had a nodeID as string. With this PR also Properties / Variables have a numeric node id.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] Pull request title reflects its content
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Description:

@JakaMohorkoDS : I assume this is not a breaking change because openDAQ do not care if this a string nodeIds or numeric. With having string node ids, a device ensures that it a specific node has always the same id. This is nice feature and was requested by HBK. The nodeId reflect the path. With this change objects and properties have also the same logic. The id reflects the hierarchical path.
What I find a pity is that properties don't have a globalId. Because of this I need to implement it like this, and I could not do it as it is done for Objects.

@JakaMohorkoDS : I assume this is not a breaking change because openDAQ do not care if this a string nodeIds or numeric. With having string node ids, a device ensures that it a specific node has always the same id. This is nice feature and was requested by HBK. The nodeId reflect the path. With this change objects and properties have also the same logic. The id reflects the hierarchical path. What I find a pity is that properties don't have a globalId. Because of this I need to implement it like this, and I could not do it as it is done for Objects.

Technically, we could have something similar to global IDs for properties and it's already available in the core.
The path to a property is denoted as follows: "Component1/Component2.Prop1.Prop2" Where you can have levels of nesting properties, if their parent is a property object, not a component. We'd need  to expose the path variable via an internal interface, but that's not an issue.


Ensure load_tissues skips/updates existing records, creates new records, errors on inconsistent records

FEATURE REQUEST
Inspiration

We have decided that going forward, adding new compounds or tissues should be done prior to and separately from loading new study data. This means that we will maintain a single "master" list of compounds and tissues for the Rabinowitz lab. This will mean that we want to run load_tissues repeatedly on an a continually updating master list of tissues. We would like it to run without error if there are no changes or only additions and throw an error if existing records must be changed to conform to the new list. For now, we'll manage those errors individually and manually.
Description

Enable load_tissues to be rerun on a given tissues.csv file.

[ ] Unchanged records should be noted (with a count in the summary, details if --verbose is specified)
[ ] Updated records should be updated and noted (count in summary, details in --verbose)
[ ] New records inserted and noted (counts in summary, details in --verbose)
[ ] Changed/inconsistent records should cause an error (non-zero exit code) (details for these always)

Alternatives

None
Dependencies
Comment

ISSUE OWNER SECTION
Assumptions

List of assumptions that the code will not explicitly address/check
E.g. We will assume input is correct (explaining why there is no validation)

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

DESIGN
Interface Change description

None provided
Code Change Description

None provided
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

Already implemented.


Char literal with single backslash inside macro def breaks the parser

macro borked # Error: unterminated macro
  '\\'
end

Very similar to #10745.
Causes https://github.com/Papierkorb/toka/issues/3.
This is a regression, the same code works on Crystal 1.0.0.

Yeah, this looks like a regression introduced by #10799. Before that, it was already broken for string literals, though.


failed to parse json

keeps on having trouble when building atom
yaourt -S atom-editor
npm ERR! Linux 4.4.1-2-ARCH
npm ERR! argv "/tmp/yaourt-tmp-denis/aur-atom-editor/src/atom-1.4.3/apm/node_modules/atom-package-manager/bin/node" "/tmp/yaourt-tmp-denis/aur-atom-editor/src/atom-1.4.3/apm/node_modules/atom-package-manager/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/denis/.atom/.apm/.apmrc" "--userconfig" "/home/denis/.atom/.apmrc" "install" "--target=0.34.5" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! file /home/denis/.atom/.node-gyp/.atom/.npm/center-align/0.1.3/package/package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! No data, empty input at 1:1
npm ERR!
npm ERR! ^
npm ERR! File: /home/denis/.atom/.node-gyp/.atom/.npm/center-align/0.1.3/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse
npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/yaourt-tmp-denis/aur-atom-editor/src/atom-1.4.3/npm-debug.log
== ERROR: A failure occurred in build().
Aborting...
== ERROR: Makepkg was unable to build atom-editor.
atom-editor 1.5.0-1  (2016-02-09 22:00)

I have this problem too
`
Installing modules ✗

<EMAIL_ADDRESS>preinstall /tmp/yaourt-tmp-amir/aur-atom-editor-git/src/atom
node -e 'process.exit(0)'

npm ERR! Linux 4.4.1-2-ARCH
npm ERR! argv "/tmp/yaourt-tmp-amir/aur-atom-editor-git/src/atom/apm/node_modules/atom-package-manager/bin/node" "/tmp/yaourt-tmp-amir/aur-atom-editor-git/src/atom/apm/node_modules/atom-package-manager/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/amir/.atom/.apm/.apmrc" "--userconfig" "/home/amir/.atom/.apmrc" "install" "--target=0.36.8" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! file /home/amir/.atom/.node-gyp/.atom/.npm/git-utils/4.1.2/package/package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! No data, empty input at 1:1
npm ERR!
npm ERR! ^
npm ERR! File: /home/amir/.atom/.node-gyp/.atom/.npm/git-utils/4.1.2/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse
npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/yaourt-tmp-amir/aur-atom-editor-git/src/atom/npm-debug.log
==> ERROR: A failure occurred in build().
Aborting...
==> ERROR: Makepkg was unable to build atom-editor-git.
==> Restart building atom-editor-git ? [y/N]
==> ----------------------------------------
==>
`

This happened to me, although I am not exactly sure what caused it. I assume a previous upgrade gone wrong, or apm messing something up. As a workaround, you can just mv ~/.atom/ ~/.atom.backup/. However, you will need to reinstall non-core packages. To do that, just run (should be a cross-shell friendly version):
$ \ls -1 ~/.atom.backup/packages/ | xargs apm install

If you want to restore previous configuration, the only relevant configuration files I could find in my case were ~/.atom.backup/{config,keymap}.cson. This included some APM package configuration as well, so maybe they're all there, but check in each directory to make sure:
$ cp ~/.atom.backup/{config,keymap}.cson .atom/

If you want to restore old editor sessions/tabs, those are now located in ~/.atom.backup/storage.

Sorry that I wasn't able to get to this Issue before now. If you're having problems building or installing the atom-editor Arch Linux package, you should follow up with the author of that package. The Atom team doesn't maintain it.
I'm sorry that I can't be more help.

You don't need to delete the entire .atom/ directory. For me, it was enough to remove the file:
\.atom\.apm\is-utf8\0.2.1\package\package.json
For me, it was just full of "NUL" control characters. After I deleted that that file and re-ran Linter install, it installed successfully.


Math correction, 20,000 instead of 2,000

@salramirez : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@salramirez Thanks approved. Wow. That bad math typo has been there awhile.  Thanks for correcting it!

#sign-off


[docs site] Fail fast when transforming files from Vite & disable gzip reporting

Hopefully this provides a slight CI speedup

Looks like it cuts about 20 seconds ish off make build? Not huge, but probably worth it

Feel free to merge in whenever you're ready, @penalosa.


[BUG] Move CI Setup to GitHub Actions

The new pricing of Travis CI makes it unusable to use for building new Yana versions. CI should be moved to GitHub Actions. This will probably block other issues and new releases until this is resolved.

Fixed in v1.0.6


Biomes manual

Created manual page to hopefully explain how --temps, --humids, -go, and -gv work.
I tried to be clear and concise while supplying full details, tasks which are often at odds with one another. Please let me know if things are unclear, redundant, overly verbose, etc.

Great stuff, like always! At a first read it seems as clear as this stuff can be. I think it would also help promoting how deep and detailed is WorldEngine. It is great what we are building together.
I could take another read tomorrow with more calm before merge it (put if @psi29a arrives before me please feel free to go ahead!)

I don't know rst-syntax, so I can't claim to have checked it. Aside from that this is an impressive piece of work and a great (and very much appreciated) read. :) Since I was the one complaining about lacking documentation regarding your newly introduced commandline parameters, I sure want to thank you for taking the time to write all of this down as clearly as you did.
I have nothing else to add, this seems flawless. :)

I noticed a minor flaw in the output so I corrected it.
I didn't think about the fact that people might not be able to see the output.
http://worldengine-ecs.readthedocs.org/en/latest/index.html

Looks good to me but I will wait to merge this because there are a couple of comments from @tcld

My comments are addressed and I am very much satisfied now.^^

Merging then :)


Bump minimum supported PHP version to 7.4 on v2 releases

Fixes #30 for the v2 series by bumping to a PHP version that does interface inheritance correctly.

I think we need to think twice before merging this.
It is possible to implement v1 and v2 at the same time. The only thing that changes is the added return type. It the implementation is adding a return type but is still targetting v1, this is not going to cause issues.
See https://3v4l.org/MlNRT
Let's take the example of Symfony. By introducing a return type in their container, they are indeed introducing a breaking change in their own library. So Symfony can only upgrade to psr/container in a new major release (Symfony 6)
But Symfony 6 could target "psr/container ^1|^2" rather than only targetting "psr/container ^1". This makes a lot of sense (a lot of third party libraries are targetting "psr/container ^1" only and you don't want to make Symfony 6 incompatible with those libraries)
But if we merge this PR and tag a v2.0.1, any user using PHP 7.2 or PHP 7.3 could install Symfony 6 using "composer update". This would automatically install "psr/container 2.0.0" which has the issue described in #30.
Maybe we could instead:

Remove the "Throwable" interface
Tag a 2.0.1
Upgrade to PHP 7.4 and add back the "Throwable" interface
Tag a 2.0.2

What do you think?

Let's take the example of Symfony. By introducing a return type in their container, they are indeed introducing a breaking change in their own library. So Symfony can only upgrade to psr/container in a new major release (Symfony 6)

Correct, it won't happen in 5.x.

But if we merge this PR and tag a v2.0.1, any user using PHP 7.2 or PHP 7.3 could install Symfony 6 using "composer update". This would automatically install "psr/container 2.0.0" which has the issue described in #30.

Only if you assume that Symfony 6 maintains compatibility with PHP 7.2/7.3. If Symfony 6 requires PHP 7.4 at least, we're good. And I think it's very likely that Symfony 6 will do that PHP bump (My personal prediction, no official announcement).
Then again, Symfony is not the only container implementation out there, so your plan sounds reasonable.

But Symfony 6 could target "psr/container ^1|^2" rather than only targetting "psr/container ^1". This makes a lot of sense (a lot of third party libraries are targetting "psr/container ^1" only and you don't want to make Symfony 6 incompatible with those libraries)

Not only they could, it's suggested by our bylaw. But they (or anyone else) can target only ^1.1|^2, plain 1.0 can't coexist with 2.0.
Or maybe even better ^1.1.1|2.0.1, skipping the bugged releases for 7.2-7.3.

I've inadvertently pushed onto master this change: https://github.com/php-fig/container/commit/19764b1677626ba3db35c033c329f9d603e87f26
Sorry for the mistake; it does follow @moufmouf suggestion, so if we tag it as 2.0.1 we can then revert it and require PHP 7.4, tagging it as 2.1.0. Do you agree?

Sure!

@Jean85 I've re-instated the extends Throwable declaration in the ContainerExceptionInterface. Should I also bump the PHP version constraint? Or leave as-is?


Add Jennifer Dennis to Contributors list

Hi  @jldennis, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey Thank you for this quick and easy intro.  I had to go through it twice because I was a little confused on the step to open the contributors.md file as a text file.  It didn't take me long to realize that I needed to open it from the cmd by simply typing in contributors.md

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Malformed Characters Not Visible

English
Version 1.24.0-insider
Commit 5d12f53178b72e88431347f8e248c49335a7fefc
Date 2018-05-14T05:16:26.538Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
I've noted that somehow a malformed character was created in a PS script I was working on.  However, it was not visible in Code.  I could only see it in native PS and PS IVE.
Bad character in PS IVE:

Same code opened from same file as above in Code with BP enabled:

This is most likely a file encoding issue.

@tmknight
VS Code supports a wide range of file encodings. You can see the full list when you click on the lower right status bar where the encoding is shown and then choose to either reopen the file with a specific encoding or save the file with a specific encoding:

There are two options how to configure the encoding for files
Configure the encoding as a setting for all files or files of specific type
We provide a files.encoding setting that you can use to set an encoding for all files. You can also configure this encoding for specific file types, e.g. like this:
"[markdown]": {
    "files.encoding": "utf8"
}

Configure VS Code to automatically detect the encoding when opening files
We provide a files.autoGuessEncoding setting that you can enable to let VS Code detect the encoding of every file automatically. Note that this approach is known to not be accurate in all cases. This guessing of encoding is rather a heuristic that can produce wrong results (that is also why this setting is not enabled by default).
Please also check out issues that are already reported with the files-encoding label: https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afile-encoding

I'm not saying that VSC caused the malformed character.  I'm reporting that VSC doesn't recognize it as malformed.  VSC shows it as it is 'meant' to be, however the character truly is malformed and in the eyes of PowerShell.exe is treated as such.  Which is the correct and expected behavior in VSC.


calculator suggestion update

Would be a very nice update if the calculator had a ironman checkbox which would calculate molten glass xp into the xp gained for something. why? this would let the calculator tell someone exactly how much molten glass they need to get without having to do the math of adding 20 xp to the base amount of xp given for making the item then dividing it by the total xp needed from current xp to the targeted xp level
Additional context
https://i.imgur.com/GjbgObC.png
https://i.imgur.com/FppvJXr.png

Holding shift allows you to select multiple items, which is what you're looking for.

Holding shift allows you to select multiple items, which is what you're looking for.

D: thanks


Unable to update the Middle Name in a user profile

I created a new user and when I tried to update the middle name in the profile it caused an error "Profile information could not be updated in LDAP user store for user: "
I mapped the middle name to region in the wso2 claims. Then the user profile was successfully updated.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Create a Deprecation Policy

Create a markdown file which outlines our API deprecation policy, starting with the Core libraries and potentially expanded from there.

@ki1729 I'm going to assign this to you since you've been doing research in this area

The latest update is that our current deprecation guidelines hold. https://github.com/Azure/azure-sdk-for-java/wiki/Deprecation


[SRVKS-452] Bump webhook memory limit to 1G.

The linked JIRA has all the context. Unfortunately our webhook currently scales fairly linearly with namespaces so this would in theory allow ~1000 namespaces which sounds sufficient to me for the time being.

I don't approve of this "fix". The right way to address this is in the CR itself, set by our knative-openshift operator, using this mechanism: https://github.com/knative/serving-operator/pull/362

@jcrossley3 I agree, when the fix was done this hasn't been merged yet. The resources override is also not in the 0.13 version. Please feel free to backport that into 0.13 and make the necessary changes in the serverless-operator.


Add additional descriptors to avalanche obs

avalanche problem type (persistent slab, wet loose, etc),
D size (or corresponding terms like small, large, very large), and
trigger (human, natural, explosive) with the avalanche observations.

MOre on obs here: https://docs.google.com/document/d/1LqVNs0C0sU1H14L280MpmbT8_-MSugjXB6d0SaY2gMg/edit?usp=sharing


Please use Docker instead of downloading manually the files

Expected Behavior
Have CI examples using docker instead of using complicated downloads on this folder https://github.com/Checkmarx/kics/tree/master/examples
Actual Behavior
Examples presented using wget, not docker
Specifications

Version: latest
Platform: docker
Subsystem: Linux

@miguelfreitas93 I was about to file the same FR but is it necessary to run docker pull & docker run?  I believe this would work instead:
image:
name: checkmarx/kics:${KICS_VERSION}

Yeah, that might work @jbrotsos

@miguelfreitas93 @jbrotsos your feedback is greatly appreciated. We'll take a look at those improvements. But then again, you're also welcome to contribute.
We want to promote community engagement! ✌🏻

It's good to provide the option for our users to use docker in their CI/CD pipelines.
We already have integration examples using docker for:

Jenkins.
CircleCI
Github Actions

Currently, those are WIP:

Gitlab
Azure DevOps

TBD in the near future:

Bitbucket

cc: @StanislavPolovnyi @elit-cx @nunoocx @markmishaevcx

@rogeriopeixotocx  are you still accepting community contribution for an updated template for Gitlab CI using the docker images?

Hi @roock, yes we are :)

This has already been implemented and can be closed

Thank you @roock !


Query LAW tables with PowerShell

Is it possible to query a specific Log Analytics data table through PowerShell using Microsoft's database querying PowerShell cmdlet like below?
Read-SqlTableData -ServerInstance "MyServer\MyInstance" -DatabaseName "MyDatabase" -SchemaName "dbo" -TableName "MyTable" -TopN 3
https://docs.microsoft.com/en-us/powershell/module/sqlserver/read-sqltabledata?view=sqlserver-ps#examples

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c84c297e-d371-a8fe-416e-147b152d48d4
Version Independent ID: 1a46ae57-0d71-ba2c-fe71-f8bb2024e1ce
Content: Get started with log queries in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/log-query/get-started-queries.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@Ayanmullick Thank you for your query, our team will look into it and get back to you at the earliest.

@Ayanmullick  Thank you for reaching out, to my understanding this not currently possible. However i have reached out to our internal teams to confirm the same. Will keep you updated.

One should be able to point Read-SqlTableData to a Log Analytics Workspace table using the workspace id and the workspace key?
https://azure.microsoft.com/en-us/updates/introducing-the-new-azure-logs-table-pane-schema/


chore: add highest-level logs to sends_ecash_out_of_band

IMO we should be doing it in every test, so I'm going to show it around.
When you are debugging a tricky problem by analyzing thousands of logs lines of a failing test, having some reference points telling you where the highest level points of test execution happened is very, very useful.
Prefixing them with ###, it makes jumping around and finding them easier.

I like this idea. It can be hard to tell what failed in CI runs. This should help.


Upgrade nexmo/laravel

Nexmo Notification Channel Version: 2.5.1
Laravel Version: 8.82.0
PHP Version: 8.1

Description:
Please, upgrade nexmo/laravel to version 3.0.0
For PHP 8.1:
Return type of Vonage\Client\Credentials\AbstractCredentials::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/vonage/client-core/src/Client/Credentials/AbstractCredentials.php on line 31

We're currently preparing a new major version with v3 support of the core Vonage client here: https://github.com/laravel/nexmo-notification-channel/pull/53. I'm afraid that patching the current package to v3 of nexmo/laravel isn't an option, sorry.

Hey @martio. Thanks to @SecondeJK there's now an update that adds the fixes for that: https://github.com/Vonage/vonage-php-sdk-core/releases/tag/2.10.1


Adding a GPU model to the compatibility database in tflite

Issue type
Support
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
tf2.15
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I have a question in the "acceleration/compatibility" part in tflite.
As far as I know, Samsung mobile model "samsung_xclipse_920" (S22) information was recently added to the compatibility database to check and support the GPU delegation.
https://github.com/tensorflow/tensorflow/commit/1f3d148aba6a364fb1a271410de4e2f74e32e136
I would like to add "samsung_xclipse_940", a S24 model that was recently released officially on the market,
Are there any ways to do it? Is there anything already in progress? Or, can I upload some PRs (gpu_compatibility.bin ...) related to this manually?
Standalone code to reproduce the issue
flatc -t --raw-binary --strict-json database.fbs -- gpu_compatibility.bin
flatc -b database.fbs gpu_compatibility.json

Relevant log output
No response

This issue originally reported by @hooneecho has been moved to this dedicated repository for LiteRT to enhance issue tracking and prioritization. To ensure continuity, we have created this new issue on your behalf.
We appreciate your understanding and look forward to your continued involvement.


Any thoughts of adding a theme to make it Windows 11 friendly?

Exactly what the title says.

Hmm, can you elaborate on this?

Hmm, can you elaborate on this?

It's been 17 days, I completely forgot my train of thought.
Sry


Handover Documentation 1.0: DigitalFile should be a File-SubmodelElement

Right now, the DigitalFile is modelled as a SubmodelElementCollection with two string Properties, which is unfortunate because no client knows what to do with it.

The SubmodelElement "File" should be used.

Are there any updates on this ticket? Will it be resolved soon?

@sstadt2024 Yes we will forward it to the respective working group.


New modifier style with set_variable does not consider other modifiers(?)

For example, I map caps_lock+J to left_arrow.
caps_lock sets a var=1, and var is a condition for J.
Now I've tried for three hours to make
shift+caps_lock+J => shift+left_arrow
, but it seems there is no way.
I could do explicit mappings for all modifier combos (caps+J, shift+caps+J, shift+control+caps+J etc etc), but that would be a huge config.
It works when I map caps_lock to fn - but if I understand correctly, this is old school.
If it helps you read it, here is part of my config.
Can I somehow apply the optional modifiers of caps_lock (shift, control, alt) to the resulting to: keycode of 'J' ?
                    "manipulators": [
                        {
                            "from": {
                                "key_code": "caps_lock"
                            },
                            "to": [
                                {
                                    "set_variable": {
                                        "name": "cl_down",
                                        "value": 1
                                    }
                                }
                            ],
                            "to_after_key_up": [
                                {
                                    "set_variable": {
                                        "name": "cl_down",
                                        "value": 0
                                    }
                                }
                            ],
                            "type": "basic"
                        },
                        {
                            "conditions": [
                                {
                                    "name": "cl_down",
                                    "type": "variable_if",
                                    "value": 1
                                }
                            ],
                            "description": "cursor left",
                            "from": {
                                "key_code": "j"
                            },
                            "to": [
                                {
                                    "key_code": "left_arrow"
                                }
                            ],
                            "type": "basic"
                        }

Try this:
"manipulators": [         {             "from": {                 "key_code": "caps_lock",                 "modifiers": {                 	"optional": [                 		"left_shift","right_shift"                 	]                 }             },             "to": [                 {                     "set_variable": {                         "name": "cl_down",                         "value": 1                     }                 }             ],             "to_after_key_up": [                 {                     "set_variable": {                         "name": "cl_down",                         "value": 0                     }                 }             ],             "type": "basic"         },         {             "conditions": [                 {                     "name": "cl_down",                     "type": "variable_if",                     "value": 1                 }             ],             "description": "cursor left",             "from": {                 "key_code": "j",                 "modifiers": {                 	"optional": [                 		"left_shift","right_shift"                 	]                 }             },             "to": [                 {                     "key_code": "left_arrow"                 }             ],             "type": "basic"         }

Woohoo it works!! Thanks!
I was sure I've tried this variant before, but obviously not correctly.
Note: it also works with the 'any' modifier, which is exactly what I wanted.
YES! I have not used my MBA since Sierra came out, because my special layout is hardwired into my fingers. Editing JSON with broken cursor control was like... typing with your nose.
I'm 10x faster now that Karabiner is back.
And thank you Tekezo-San, you rock!

Just for the record: this is how you map
CapsLock + J (+ any modifier) to
CursorLeft (+any modifier that is currently pressed) :
                    "manipulators": [
                        {
                            "from": {
                                "key_code": "caps_lock",
                                "modifiers": {
                                    "optional": [
                                        "any"
                                    ]
                                }
                            },
                            "to": [
                                {
                                    "set_variable": {
                                        "name": "cl_down",
                                        "value": 1
                                    }
                                }
                            ],
                            "to_after_key_up": [
                                {
                                    "set_variable": {
                                        "name": "cl_down",
                                        "value": 0
                                    }
                                }
                            ],
                            "type": "basic"
                        },

                        {
                            "conditions": [
                                {
                                    "name": "cl_down",
                                    "type": "variable_if",
                                    "value": 1
                                }
                            ],
                            "description": "CURSOR_LEFT",
                            "from": {
                                "key_code": "j",
                                "modifiers": {
                                    "optional": [
                                        "any"
                                    ]
                                }
                            },
                            "to": [
                                {
                                    "key_code": "left_arrow"
                                }
                            ],
                            "type": "basic"
                        }


Change Parse to ParseNamed to remove extra import

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Current coverage is 55.41% (diff: 100%)

Merging #1509 into master will increase coverage by 0.13%

@@             master      #1509   diff @@
==========================================
  Files            82         82
  Lines         12917      12917
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           7140       7158    +18
+ Misses         4782       4772    -10
+ Partials        995        987     -8

Powered by Codecov. Last update 90be98a...f5515d5

I think the github.com/docker/engine-api/types/reference package can be removed from vendoring. Were you planning to do that in a followup PR?

@aaronlehmann i'll remove it in this PR

@aaronlehmann its still used/referenced by another vendored dep at the moment so it has to say in godeps.

LGTM

LGTM


URLLIB has no attribute urlopen

URL Lib won't access the proxies through getproxies and urlopen also does not work. Would appreciate a hand. Python 3.5.1

@jdodich use change both getproxies and urlopen to "urllib.request.getproxies" and "(urllib.request.urlopen(url)"

Thank you, @machbio!


With multiple components, when a button in one component is clicked, how to let another component to re-render?

With multiple components, when a button in one component is clicked, how to let another component to re-render?

Hi, friends,
In a component, when we change some data, we just use app.render(thiscomponent) to re-render itself. but sometime, we also want to re-render another components (parent component or brother component).
So,

Is there any simple method to get another component's compo to use app.render() to do so.
Can we pass a callback function from parent component to the component, we can call it, later in the component to re-render.

Thanks in advance!

you also have a full example of this here: https://github.com/murlokswarm/app/tree/master/examples/action-event.
Let me know if it solve your problem.

Closing this, please reopen if it did not solved your problem.

Thank you, it works!