Could not retrieve embed information.

Description
I've installed Embedded Assets and didn't check any plugin-settings. But for all services (vimeo, youtube, google maps, etc.) I receive a "Could not retrieve embed information." error.
I saw, there are several tickets with problems on Digital Ocean servers. But this is not hosted on DO. It's hosted at german hoster "All-Inkl".
I've created a /tmp in the project-folder and added to absolute path to .env TMPDIR-variable. Didn't help either.
Unfortunately in logs I don't see any errors.
Steps to reproduce

Install plugin
Try to embed any link
Error: "Could not retrieve embed information."

Other information

Embedded Assets version: 2.4.4
Craft CMS version: Craft Solo 3.5.16
--

@lukasreusch I have the same issue. Have you found a solution?

I have the same issue.

Same here

This sounds a lot like oscarotero/Embed#411.  I'll echo the advice at https://github.com/oscarotero/Embed/issues/411#issuecomment-741972059 and recommend setting up an Embed demo page on your production server (preferably version 3, since that's what Embedded Assets currently uses, but if it's an external issue then it shouldn't matter).  Unfortunately, if servers are being blocked by providers, there's nothing Embedded Assets or Embed can do about that.

Thanks for the advice @ttempleton. Today I finally managed to try Embed 3.4.15 locally and on the same server as the website. I had no problems in either environment. Embed works, Embedded Assets unfortunately only works locally. 😔  Maybe it will work again with Embed 4.

Hmm, that does sound more like a plugin issue, then.  Are there any JavaScript errors or any errors returned by your server when it happens?

Thanks for reopening this issue.
In fact, an error appears in the console as soon as I try to embed a YouTube video:
main.js:formatted:542 Uncaught DOMException: Blocked a frame with origin "https://www.DOMAIN.com" from accessing a cross-origin frame.
    at t.value (https://www.DOMAIN.com/cpresources/284be641/main.js:1:10036)
    at t.value (https://www.DOMAIN.com/cpresources/284be641/main.js:1:10095)
    at t (https://www.DOMAIN.com/cpresources/284be641/main.js:1:12059)

@ttempleton Were my screenshots with the JS errors helpful? Were you able to look at them or do you need more info?

Thanks @klick!


Testnet Consensus Break

2024-07-10T13:52:09.799+02:00 - [    INFO] - Block 315996 - Parsing complete. L: ea4beaa, TX: ea4beaa, M: ea4beaa (0.00s)
2024-07-10T13:52:09.800+02:00 - [    INFO] - Block 315997
2024-07-10T13:52:09.800+02:00 - [    INFO] - Block 315997 - Parsing complete. L: 7f0ba94, TX: 7f0ba94, M: 7f0ba94 (0.00s)
2024-07-10T13:52:09.801+02:00 - [    INFO] - Block 315998
2024-07-10T13:52:09.801+02:00 - [    INFO] - Block 315998 - Parsing complete. L: 793aa4b, TX: 793aa4b, M: 793aa4b (0.00s)
2024-07-10T13:52:09.802+02:00 - [    INFO] - Block 315999
2024-07-10T13:52:09.802+02:00 - [    INFO] - Block 315999 - Parsing complete. L: 8a35d99, TX: 8a35d99, M: 8a35d99 (0.00s)
2024-07-10T13:52:09.802+02:00 - [ WARNING] - Prefetch queue is empty.
2024-07-10T13:52:09.908+02:00 - [    INFO] - Block 316000
2024-07-10T13:52:09.908+02:00 - [   ERROR] - Exception caught!
Traceback (most recent call last):
  File "/Users/adam/Documents/work/Counterparty/CounterpartyXCP/counterparty-core/counterparty-core/counterpartycore/server.py", line 730, in start_all
    blocks.catch_up(db)
  File "/Users/adam/Documents/work/Counterparty/CounterpartyXCP/counterparty-core/counterparty-core/counterpartycore/lib/blocks.py", line 1237, in catch_up
    tx_index = parse_new_block(db, decoded_block, tx_index=tx_index)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/adam/Documents/work/Counterparty/CounterpartyXCP/counterparty-core/counterparty-core/counterpartycore/lib/blocks.py", line 1153, in parse_new_block
    new_ledger_hash, new_txlist_hash, new_messages_hash = parse_block(
                                                          ^^^^^^^^^^^^
  File "/Users/adam/Documents/work/Counterparty/CounterpartyXCP/counterparty-core/counterparty-core/counterpartycore/lib/blocks.py", line 324, in parse_block
    new_txlist_hash, found_txlist_hash = check.consensus_hash(
                                         ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/adam/Documents/work/Counterparty/CounterpartyXCP/counterparty-core/counterparty-core/counterpartycore/lib/check.py", line 890, in consensus_hash
    raise ConsensusError(error_message)
counterpartycore.lib.check.ConsensusError: Incorrect txlist_hash hash for block 316000.  Calculated d956a0869b4bb0f1f694dadbcf47fa5a401fafca8f79bb4ef300d1451a87a59c but expected 3e29bcbf3873326097024cc26e9296f0164f552dd79c2ee7cfc344e6d64fa87d
2024-07-10T13:52:09.910+02:00 - [    INFO] - Stopping API Server...
2024-07-10T13:52:10.019+02:00 - [    INFO] - Stopping API Watcher...
2024-07-10T13:52:11.418+02:00 - [    INFO] - Stopping telemetry daemon...
2024-07-10T13:52:11.767+02:00 - [    INFO] - Stopping API Status Poller...
2024-07-10T13:52:12.057+02:00 - [    INFO] - Stopping API Server v1...
2024-07-10T13:52:12.098+02:00 - [    INFO] - Closing database connections...
2024-07-10T13:52:12.112+02:00 - [    INFO] - Stopping AddrIndexRs thread...
2024-07-10T13:52:12.112+02:00 - [    INFO] - Shutting down logging...
2024-07-10T13:52:12.114+02:00 - [    INFO] - Stopping prefetcher...
2024-07-10T13:52:12.185+02:00 - [    INFO] - Shutdown complete.

fixed here https://github.com/CounterpartyXCP/counterparty-core/pull/2057


Add Circe's predict size support

See details in the Circe's PR: https://github.com/circe/circe/pull/739
Our ToService benchmark looks pretty great yet I'm unable to reproduce the numbers in the wrk. Let's consider this an experimental until we know more about the performance improvements.
PREDICT SIZE DISABLED:

[info] Benchmark                                               Mode  Cnt       Score       Error   Units
[info] ToServiceBenchmark.foos                                thrpt   10   13876.850 ±  9207.359   ops/s
[info] ToServiceBenchmark.foos:·gc.alloc.rate.norm            thrpt   10  111100.167 ±  2415.956    B/op
[info] ToServiceBenchmark.ints                                thrpt   10   76738.704 ±  4821.128   ops/s
[info] ToServiceBenchmark.ints:·gc.alloc.rate.norm            thrpt   10   23449.304 ±    56.644    B/op

PREDICT SIZE ENABLED:

[info] Benchmark                                               Mode  Cnt       Score       Error   Units
[info] ToServiceBenchmark.foos                                thrpt   10   22147.146 ±  1240.016   ops/s
[info] ToServiceBenchmark.foos:·gc.alloc.rate.norm            thrpt   10  111040.073 ±  2435.077    B/op
[info] ToServiceBenchmark.ints                                thrpt   10   80175.133 ±  2721.351   ops/s
[info] ToServiceBenchmark.ints:·gc.alloc.rate.norm            thrpt   10   20821.181 ±  2428.086    B/op

Codecov Report

Merging #868 into master will increase coverage by 0.72%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #868      +/-   ##
=========================================
+ Coverage   81.47%   82.2%   +0.72%
=========================================
  Files          51      51
  Lines         734     736       +2
  Branches       33      33
=========================================
+ Hits          598     605       +7
+ Misses        136     131       -5

Impacted Files
Coverage Δ

circe/src/main/scala/io/finch/circe/package.scala
100% <100%> (ø)
:arrow_up:

core/src/main/scala/io/finch/Input.scala
100% <0%> (+12.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3805622...9d1c81e. Read the comment docs.


Change the input method for name and address fields

Currently, only the characters before space are taken into the consideration.
For example, only the first name is saved for the name field

hey @ShreyaPanale, can I work on this?

hey @ShreyaPanale, can I work on this?

@Prajwal2204 , Both of you can work on it

!bounty 10


Change image when switching to the dark mode

We should use media queries to change icon on the dark theme instead of the current method. We could add an optional key 'dark-img' in the YAML.
Look at : https://dev.to/dailydevtips1/light-and-dark-mode-image-in-html-lji

Finally, we could just change img and svg key in the YAML config file to one icon key and add an optional bolean invert-on-dark which applies the invert-dark class on the icon.


chore: improve workflow stdout comments

see this PR comment (this PR superseeds to avoid confusion)
nice lil workflow improvement for better visibility and debugging

learning about workflows from you man <3

right backatcha brother on everything else much cooler than workflows 🔥 😂


Cosmos DB resource RunAsEmulator(): "The evaluation period has expired"

I ran into this when running our Aspire tests locally:

This results in the test hanging for 10 minutes, presumably waiting for the container to start (it will never start). This issue occurs because machine already has an older version of the Cosmos DB container image and we are specifying the tag "latest" and not periodically forcing a re-pull.
Perhaps we should check image age and re-pull images older than a certain period.
Either way, assuming Cosmos DB does not change its behavior, this will result in broken dev inner-loops and CI pipelines down the line.

@karolz-ms - where did we ever land with DCP deciding to pull a new version for a tag, even if it is cached locally? See https://github.com/dotnet/aspire/issues/1997#issuecomment-1918263447:

As for stale image checks, we have prior art for that in our VS/VS Code container extensions. We could have the AppHost or DCP could do a similar staleness check in the background and emit warnings during the application run if stale images are detected.

@karolz-ms - where did we ever land with DCP deciding to pull a new version for a tag, even if it is cached locally? See #1997 (comment):

As for stale image checks, we have prior art for that in our VS/VS Code container extensions. We could have the AppHost or DCP could do a similar staleness check in the background and emit warnings during the application run if stale images are detected.

@eerhardt AFAIK the comment above was just a feature idea. We don't even have a backlog item to think about it yet. The improvement we DO have in plans (for shortly-post-GA release) is to expose container startup logs in the dashboard. So for the problem like above, it would hopefully make it clearer what went wrong.

Is there a workaround for this that anyone knows about?

Delete the container image from docker and it'll re-pull the latest image.


RPC integration tests failing on CI

The RPC integration tests are currently failing on CI.
Affected PRs are:

#302 (job)
#284 (job)

Here's an excerpt from the build logs for #302:

Click to show log
running 11 tests

test rpc::abci_info ... ok
test rpc::abci_query ... ok
test rpc::block ... FAILED
test rpc::block_results ... ok
test rpc::commit ... FAILED
test rpc::blockchain ... FAILED
test rpc::genesis ... ok
test rpc::health ... ok
test rpc::net_info ... ok
test rpc::status_integration ... ok
test rpc::event_subscription ... FAILED

failures:

---- rpc::block stdout ----
thread 'rpc::block' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("invalid type: integer `1`, expected a string at line 8 column 19") }', tendermint/tests/integration.rs:73:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- rpc::commit stdout ----
thread 'rpc::commit' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("invalid type: integer `0`, expected a string at line 17 column 23") }', tendermint/tests/integration.rs:111:27

---- rpc::blockchain stdout ----
thread 'rpc::blockchain' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: ParseError, message: "Parse error. Invalid JSON", data: Some("invalid type: integer `1`, expected a string at line 11 column 23") }', tendermint/tests/integration.rs:95:31

---- rpc::event_subscription stdout ----
[tendermint/src/rpc/event_listener.rs:95] "We did not receive a valid JSONRPC wrapped ResultEvent!" = "We did not receive a valid JSONRPC wrapped ResultEvent!"
thread 'rpc::event_subscription' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: Other(-1), message: "Error (code: 0)", data: Some("received neither event nor generic string message") }', tendermint/tests/integration.rs:164:34

failures:
    rpc::block
    rpc::blockchain
    rpc::commit
    rpc::event_subscription

test result: FAILED. 7 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out

Related comment: https://github.com/informalsystems/tendermint-rs/issues/120#issuecomment-634541018
I'll have a look.

This is actually also related: https://github.com/informalsystems/tendermint-rs/issues/305
We first need to decide if we want to migrate and be on par with 0.34 as soon as it is releases and basically keep up to date with the changes in go-tendermint's master (because the docker images we are testing against are build from master).
cc @ebuchman

Yes we should target v0.34 but we need some lead time so our tests shouldn't fail just because we're behind the latest breaking release. We should make sure the tests run against something stable ...

They are still failing now (prob. due to other reasons): https://github.com/informalsystems/tendermint-rs/runs/772419078#step:5:271
re-opening


remove fixed code url

Fixed #135

@sman591 do you know what's going on with Travis? My changes should not have caused any sort of errors

Rip, the bug is back. Idk what's going on here but code looks good to me, feel free to merge

Closed #137

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add partial support for indexed TGA files

Add support for TGA files with 24-bit palettes.

Extra context: Although the indexed TGA format seems archaic, Substance Painter exports all grayscale TGAs as indexed.

Thanks for the contribution! Can you attach some example TGA files so I can include them in the test suite?

Sure, I've created indexed version of two of the test files from the test repo.
Thanks.
indexed_tga_files.zip

Thanks for the test images. I'll have to sit on the PR a bit... I need to see how I go about getting the updated reader fuzz tested...

Ok, thanks.

Cleaned up and committed to main https://github.com/microsoft/DirectXTex/commit/99518756031394c8cc4b3d5c308b2795dc8e8e9a


Added my folder and negative number shuffling cpp solution

I have added your PR but make sure you fix it by making a folder of your GitHub username and then upload it


dotenvx status breaks if you have intentionally decrypted .env.X files not part of .env.vault

Hi first of all great lib
I ran into the following issue, in our repo we implemented dotenvx and have couple .env.X files that are now fully part of env.vault
However there are 2 .env files we intend to keep unencrypted as they do not hold anything secret by design.
This does not play nice with dotenvx status
Example:
|
|- .env
|- .env.silly_raw
|- .env.vault
|- .env.keys

So .env.vault here has 1 record of the encrypted .env as designed and does not have a row for .env.silly_raw
$ dotenvx status
> Cannot read properties of undefined (reading 'split')

While debugging I narrowed it down to https://github.com/dotenvx/dotenvx/blob/fc283ef2035830366767ed252d940361777c6cf7/src/lib/services/status.js#L66
because for the old data passed down to diff it has undefined.
I can put up a PR with following local fix;

add option to dotenvx status command --ignoredFiles <fileName...>'
add check here to skip if file name is in the ignoreList https://github.com/dotenvx/dotenvx/blob/fc283ef2035830366767ed252d940361777c6cf7/src/lib/services/status.js#L47

thank you for catching this. looking into your PR, but I might modify the solution to be more convenient for users - so that it only compares to what is in the .env.vault file (and warns on the others). i'll keep you posted.

fixed in v0.37.1 - releasing shortly.


Interpreting Position codes

ws.get_positions() returns security id's that are of the format "sec-c-XXX" where XXX is a 32 digit hex number. How are these meant to be interpreted? Are they wealthsimple specific or is there a database somewhere to associate them with their respective tickers?
Thank you

I believe these are Internal Wealthsimple IDs. As of right now, I do not know a way of converting these into an associated ticker. If you find the relationships please let me know!

So idk if this is new but wealthsimple has half-decent documentation for the API. In it theres reference to a "GET Security":
https://developers.wealthsimple.com/#operation/Get Security.
so if you adapt your get_security function to be:
response = self.TradeAPI.makeRequest("GET", f"securities/{security_id}")
instead of
response = self.TradeAPI.makeRequest("GET", f"securities?query={security_id}")
then wealthsimple will return a dictionary that contains all of the info listed at the link above (including the ticker)

That documentation is actually for the Wealthsimple service not the Wealthsimple Trade service. So unfortunately the majority of those endpoints don't work, but it looks like you got lucky and found one that does :)
I will add this into change into the get_security() function. Users will have the choice of either providing a ticker symbol or the security ID.


ci: Make pre-commit hooks run on PR in core packages

Make pre-commit hooks run in "core" packages on PR, for example, in autora-synthetic. Use the example in https://github.com/AutoResearch/autora-core to do this.

this is going to be an effort that involves everyone since i just don't have the familiarity with individual modules to fix all errors after running the hooks... i have spent a decent amount of time spinning my wheels here without progress. perhaps the author of each module can add and run the hooks, and then resolve the resulting errors for their own modules?

[ ] remove mypy from core packages except ones where it already passes
[ ] for each package where mypy was remove, add an issue to add it back

[ ] https://github.com/AutoResearch/autora-experimentalist-novelty
[ ] https://github.com/AutoResearch/autora-theorist-darts
[ ] https://github.com/AutoResearch/autora-theorist-bsr
[ ] https://github.com/AutoResearch/autora-theorist-bms
[ ] https://github.com/AutoResearch/autora-experimentalist-model-disagreement
[ ] https://github.com/AutoResearch/autora-experimentalist-uncertainty
[ ] https://github.com/AutoResearch/autora-experimentalist-nearest-value
[ ] https://github.com/AutoResearch/autora-experimentalist-leverage
[ ] https://github.com/AutoResearch/autora-experimentalist-inequality
[ ] https://github.com/AutoResearch/autora-experimentalist-assumption
[ ] https://github.com/AutoResearch/autora-experimentalist-falsification
[ ] https://github.com/AutoResearch/autora-synthetic-psychology-ssm
[ ] https://github.com/AutoResearch/autora-synthetic-abstract-equation


Add default methods to dropwizard-lifecycle's Managed interface

Not everything needs both a start and stop method. Provide default no-op implementations.

According to https://wiki.eclipse.org/Evolving_Java-based_APIs_2 this change should be binary compatible, so we could bring this to 2.1.0.

@rhowe Thanks for your contribution! The changes look good, but I think the documentation could be improved a bit. Our docs sound more like one has to implement both methods, which then wouldn't be the case any more.

@rhowe Thanks for your contribution! The changes look good, but I think the documentation could be improved a bit. Our docs sound more like one has to implement both methods, which then wouldn't be the case any more.

Good shout. I'll add some doc updates to this PR and let you review

I changed the and to and/or in the docs. I was going to write a bit extra, but less is more?

It's hard to answer stylistic questions, but I think that would be enough. I just wanted to avoid confusion, if users just want to implement one of the two methods.

@rhowe I've just seen, that the JavaDoc for Managed has a similar formulation to the docs. Maybe you provide an update for that as well. The change to and/or should be enough, but the JavaDoc for Managed will probably get confusing then.

@zUniQueX good catch. I've updated the javadoc - see what you make of it.

Thanks, that looks good


[Enhancement] Support the conversion from json to struct.

Why I'm doing:
In Trino, a json could be translate into row and array(row). Following sql could be executed:
TRY(CAST(json_parse("json") AS array(ROW(col1 timestamp(3), col2 array(varchar), col3 double, col4 varchar, col5 varchar))))
What I'm doing:
Supporting casting json to struct or array. After this patch, the sql above could be executed under trino dialect.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@murphyatwork @Seaven Hello, I'm sorry that the codes are conflict with the main branch and I resolved it. Could you please review this again?

ignore backport check:3.3.8


FieldNameConstants documentation doesn't match code

https://projectlombok.org/features/experimental/FieldNameConstants
Shows @FieldNameConstants being used on a field (which makes sense) but the code restricts the annotation to Target(ElementType.TYPE)
    @FieldNameConstants
    public class FieldNameConstantsExample {
        private final String iAmAField;
        @FieldNameConstants(level = AccessLevel.PACKAGE)
        private final int andSoAmI;
    }

Good point. Modified it to show off the @FieldNameConstants.Exclude way of doing this; this is a holdover from how @FNC used to work. Good eye :)


Bash window title

Hi there,
It's really low priority, as it's cosmetic and highly dependent on configuration, but just wanted to mention:
I'm using "Konsole", and by default, the bash window title is "folder : software_running"
When launching any application installed via binenv, I get: "folder : software_version"
=> is there a way to change binenv so it would reflect the software running ?

Ok I get it.
We probably can get away by unsafe-changing argv[0], something like:
    argv0str := (*reflect.StringHeader)(unsafe.Pointer(&os.Args[0]))
    argv0 := (*[1 << 30]byte)(unsafe.Pointer(argv0str.Data))[:argv0str.Len]

    n := copy(argv0, name)
    if n < len(argv0) {
            argv0[n] = 0
    }

    return nil
}```

Will check this.

There is an ANSI escape code for changing the terminal emulators window title:
package ansititle

import (
	"bytes"
	"errors"
	"os"

    "golang.org/x/crypto/ssh/terminal"
)

func Write(title []byte) error {
	fd := os.Stdout.Fd()
	if !terminal.IsTerminal(int(fd)) {
		return errors.New("not a TTY")
	}

	_, err := os.Stdout.Write(formatTitle(title))
	return err
}

func formatTitle(title []byte) []byte {
	if len(title) == 0 {
		return nil
	}
	title = sanatise(title)
	ansi := make([]byte, len(title)+5)

	copy(ansi[0:4], []byte{27, ']', '0', ';'})
	copy(ansi[4:len(title)+4], title)
	ansi[len(ansi)-1] = 7

	return ansi
}

func sanatise(b []byte) []byte {
	b = bytes.ReplaceAll(b, []byte{'\r'}, nil)
	// replace all control characters with space
	for i := range b {
		if b[i] < 32 || b[i] == 127 {
			b[i] = 32
		}
	}

	return b
}

(adapted from: https://github.com/lmorg/murex/tree/master/utils/ansititle)
The issue is while some terminal emulators seems to honour this, Konsole by default does not. That's up to the user to change in their tab settings (I've not found a way to force change that myself).

However you can query what the tab title format is with this command:
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION org.kde.konsole.Session.tabTitleFormat $KONSOLE_DBUS_WINDOW

@jgournet thanks fo the report but, as you can see, I have very little time for the project right now. Since this is not critical, I'd rather set it aside for now if that's ok.
If someone wants to handle this, I'd be glad to review PRs.


problem at training

Hello, i encountered the following error when using train_nasnet_mobile.py. I actually encountered the same error when using all the other training models. Evaluate models worked very well.
Total params: 4,280,286
Trainable params: 10,570
Non-trainable params: 4,269,716

Epoch 1/20
Traceback (most recent call last):
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 510, in _apply_op_helper
preferred_dtype=default_dtype)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1104, in internal_convert_to_tensor
ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 947, in _TensorTensorConversionFunction
(dtype.name, t.dtype.name, str(t)))
ValueError: Tensor conversion requested dtype string for Tensor with dtype float64: 'Tensor("arg0:0", shape=(), dtype=float64)'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "train_nasnet_mobile.py", line 93, in
validation_steps=(5000. // batchsize))
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/keras/engine/training.py", line 1426, in fit_generator
initial_epoch=initial_epoch)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/keras/engine/training_generator.py", line 155, in fit_generator
generator_output = next(output_generator)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/keras/utils/data_utils.py", line 793, in get
six.reraise(value.class, value, value.traceback)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/keras/utils/data_utils.py", line 658, in _data_generator_task
generator_output = next(self._generator)
File "/Users/jiazhengyuan/Documents/workspace/neural-image-assessment/utils/data_loader.py", line 101, in train_generator
train_dataset = train_dataset.map(parse_data, num_parallel_calls=2)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 853, in map
return ParallelMapDataset(self, map_func, num_parallel_calls)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 1870, in init
super(ParallelMapDataset, self).init(input_dataset, map_func)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 1839, in init
self._map_func.add_to_graph(ops.get_default_graph())
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/function.py", line 484, in add_to_graph
self._create_definition_if_needed()
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/function.py", line 319, in _create_definition_if_needed
self._create_definition_if_needed_impl()
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/function.py", line 336, in _create_definition_if_needed_impl
outputs = self._func(*inputs)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 1802, in tf_map_func
ret = map_func(*nested_args)
File "/Users/jiazhengyuan/Documents/workspace/neural-image-assessment/utils/data_loader.py", line 61, in parse_data
image = tf.read_file(filename)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/ops/gen_io_ops.py", line 528, in read_file
"ReadFile", filename=filename, name=name)
File "/Users/jiazhengyuan/venv3.62/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 533, in _apply_op_helper
(prefix, dtypes.as_dtype(input_arg.type).name))
TypeError: Input 'filename' of 'ReadFile' Op has type float64 that does not match expected type of string.

In the list of filenames you are passing to the reader, it is getting a floating point value for some reason instead of a list of strings. Check by printing out the contents of the files list and see if some floating point values are somehow there.


fix issue with updating PR when the stack is reordered (#395)

This PR addresses issue #395
Fixing Steps

Handle the error returned when updating a PR before the local branch is pushed to GitHub by marking the reRunPRUpdate in GitHubPushModel as true and continue to the next iteration.
After runGitPush(), check reRunPRUpdate value. If true, then re-run updatePRs again to fix the PR base branch

Before
Previously, when the branches were reordered and we ran av stack sync it would return There are no new commits between base branch 'base' and head branch 'head', and the process is stopped
After
The previous issue did not happen and the PR order is now in sync with the local machine's re-ordered stack.

It seems there is a bug.
set -ex

git checkout main
av stack branch branch-1
git commit --allow-empty -m "Commit on branch-1"
av pr create --title "PR on branch-1" --body "PR on branch-1"

git checkout main
av stack branch branch-2
git merge --ff-only branch-1
av pr create --title "PR on branch-2" --body "PR on branch-2"

git checkout branch-2
av stack reparent --parent branch-1

av stack sync --all --push yes

With this change, the last av stack sync exits with 0 saying it's "pushed", but it's actually failing since there's no new commit in branch-2. As a result, av stack sync becomes no-op and repeatedly running it will just trying to push, and it says it's "pushed", but it didn't. Prior to this change, it correctly errors out with there's no new commit.

Thank you for checking @draftcode , i'll try to reproduce the issue on my end and fix it

Hi @draftcode, i tried to reproduce the issue on my end, and here's what I've got:

my understanding of the issue #395 is, we have this error There are no new commits between base branch 'base' and head branch 'head' which prevents us from updating the PR when the stack is re-ordered. So my steps to fix this issue are:

catch the above error into a conditional statement (if)
inside the if block, remark this session to re-run pr update after git push
continue to the next iteration of pr checks

but from the example above, seems you're expecting the error to appear and stop the process. So what is the condition that is required to differentiate between this case and the case from #395? because both have the same there's no new commit error but we want the process to be continued in #395 but stopped in this case. Please kindly suggest.

https://github.com/aviator-co/av/pull/436#issuecomment-2432946568 truely do not have any new commit between the parent and its child, so it should be errored out. https://github.com/aviator-co/av/issues/395 is that depending on the order of the operations, it appears as there's no new commit between the parent and its child, but it's just a transient case.
Locally, it should be able to tell if there is no new commit or not. Traversing or doing something like https://github.com/aviator-co/av/issues/395#issuecomment-2289724898.


libodbc not found on mac (intel)

I encountered the following issue when trying to connect to an odbc source (filemaker) on a Mac:
'pypyodbc.OdbcNoLibrary: 'ODBC Library is not found. Is LD_LIBRARY_PATH set?'
Macos 13.3 (ventura), libiodbc installed with homebrew (brew install libiodbc).

I have resolved the connection issue for my purposes by adding the path /usr/local/opt/libiodbc/lib/libiodbc.dylib to lib_paths in pypyodbc.py


pageViewsByCity

How can i get page views by city not country and period available start and end dates or all over data in DB?

@usama-kabel you have data in DB now, So you can use it as you want.

@usama-kabel, unfortunately we cannot help much on issues related to specifics of your app, but if you look at the docs, you'll see that the app has a lot of methods you can use to start a query, search or count. For visits we have Sessions:
https://github.com/antonioribeiro/tracker#sessions-visits
It should return a collection which you can filter wherever you need to.


travis: stop install tools cover and vet

There is no need to install them separately because they have been
downloaded in the default go root directory.

LGTM


Promote schema version from one target to another target

Right now you need to run schema:publish <pointer-to-graphql-schema>, for every target.
As an alternative we are thinking about just having the option of promoting the schema version from one target to the schema version of another target.
e.g. hive schema:promote <id>.
This would have the benefit of not requiring access to the graphql schema when mirroring a stage in a multi-environment deployment. E.g. when progressing a docker image from one one stage to another and the flow is not 1:1 backed by a version control system such as Git.
We need to figure out whether the <id> is something a Hive users pass along as a hive schema:publish parameter that needs to be unique across all publishes within a project, or whether this is something we provide as an output when running schema:publish, that the Hive user needs to store to later on pass it as a parameter for hive schema:promote <id>.
Example:

Git Branch
Hive Target

main
development

staging
staging

production
production

New features are developed on a branch that targets the main branch. The hive schema:check
command is run against the development target. conditional breaking changes are configured on
staging and production targets.
When the feature is ready for QA, the branch is merged into main. The hive schema:publish
command is triggered by CD workflow, and the schema is published to the development target.
When the feature is ready for staging, the main branch is merged into staging. The
hive schema:promote command is triggered by the CD workflow, and the schema version is published to the
staging target.
When the feature is ready for production, the staging branch is merged into production. The
hive schema:promote command is triggered by the CD workflow, and the schema published to the
production target.

Hi, in lack of this functionality, is there any other way to copy over a schema from target to target? For example, when bootstrapping a new or temp environment it would be super useful to be able to clone a schema


"Unresolved imports" reported for package.json

I have this in my package.json
"scripts": {
    "android:install": "adb install -r android/app/build/outputs/apk/dev/debug/app-dev-debug.apk",

if the path above EXISTS, knip throws an error. If NOT, the rule passes.
Unresolved imports (1)
[some path that's omitted]/android/app/build/outputs/apk/dev/debug/app-dev-debug.apk  package.json
error Command failed with exit code 1.

Expected:

Unresolved imports don't get reported for package.json, or maybe we should add a way to skip a specific path.
Knip probably should throw errors if the path doesn't exist? I guess I can't say for sure as I'm not sure what it means by "resolve"

Knip has to make an exception here, because the default behavior of many Node.js programs is to reserve --require (or -r) for local or external "includes". Your example would resolve to the android package name if that file is not there.
Starting from Knip v2.38.4, you may still get back the bin:adb binary, but you can ignore that using ignoreBinaries: ['adb'].


Web Socket Setup and Data Streaming

Description :

Added setup for web socket for data transmission
tps_data and block_details data streaming
Added React Hook to listen to any event from the web socket server

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: raghukapur9:x: shivam-25:x: simplysabirYou have signed the CLA already but the status is still pending? Let us recheck it.


High differences between run for GC Diagnoser

Trying to play with the GCDiagnoser and I'm getting weird results on consecutive run, like the Gen0/Gen1/Gen2/Bytes Allocated/Op are varying a lot (30-40%), making it quite useless to compare... while I would not expect figures to change that much (afaik, I'm not aware about this indeterministic GC behaviour)
Have you been noticing this issue or Am I doing something wrong there?

I have been running our integration tests plenty of times, they contain simple test for GC Diagnoser and the results were always the same.
.NET GC is selftunning (changing Gen sizes etc) but we always start new process so the results should be almost the same as long as OS has similar resources available.
Could you give some sample benchmark with config that you use?

Can you post the logs from 2 runs with different # of GC collections? It'll be easier to see what's going on
On 1 Apr 2016, at 02:48, "Alexandre Mutel"<EMAIL_ADDRESS>wrote:

Trying to play with the GCDiagnoser and I'm getting weird results on consecutive run, like the Gen0/Gen1/Gen2/Bytes Allocated/Op are varying a lot (30-40%), making it quite useless to compare... while I would not expect figures to change that much (afaik, I'm not aware about this indeterministic GC behaviour)
Have you been noticing this issue or Am I doing something wrong there?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

The output I'm getting while running multiple times is like this:
               Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------------- |---------- |---------- |------- |------ |------ |------------------- |
    TestCommonMarkNet | 4.8020 ms | 0.0326 ms | 208.54 | 14.34 | 89.28 |       1,117,194.48 |
 TestCommonMarkNetNew | 5.7072 ms | 0.0541 ms | 169.87 | 84.31 | 72.44 |       1,124,892.65 |
          TestMarkdig | 6.4552 ms | 0.0454 ms | 115.00 | 75.00 | 55.00 |         851,150.77 |
     TestMarkdownDeep | 8.4201 ms | 0.5206 ms | 176.43 | 76.75 | 56.46 |       1,039,481.68 |

               Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------------- |---------- |---------- |------- |------ |------ |------------------- |
    TestCommonMarkNet | 4.7802 ms | 0.0365 ms | 117.28 |  8.10 | 50.15 |         738,831.91 |
 TestCommonMarkNetNew | 5.7256 ms | 0.0317 ms | 176.00 | 87.42 | 75.26 |       1,371,935.85 |
          TestMarkdig | 6.2702 ms | 0.0673 ms |  91.59 | 59.74 | 43.81 |         797,976.80 |
     TestMarkdownDeep | 7.9212 ms | 0.0405 ms | 164.00 | 71.00 | 52.00 |       1,134,079.22 |

               Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------------- |---------- |---------- |------- |------ |------ |------------------- |
    TestCommonMarkNet | 4.8237 ms | 0.0504 ms | 152.82 | 10.51 | 65.42 |       1,117,194.48 |
 TestCommonMarkNetNew | 5.6900 ms | 0.0490 ms | 138.97 | 68.97 | 59.27 |       1,255,915.01 |
          TestMarkdig | 6.3441 ms | 0.0963 ms |  70.75 | 46.02 | 33.66 |         713,802.94 |
     TestMarkdownDeep | 7.8991 ms | 0.0547 ms | 164.00 | 71.00 | 52.00 |       1,314,925.80 |

               Method |    Median |    StdDev |  Gen 0 |  Gen 1 |  Gen 2 | Bytes Allocated/Op |
--------------------- |---------- |---------- |------- |------- |------- |------------------- |
    TestCommonMarkNet | 4.7855 ms | 0.0920 ms | 194.88 |  13.53 |  83.23 |         963,242.75 |
 TestCommonMarkNetNew | 5.7061 ms | 0.0456 ms | 249.01 | 123.83 | 106.91 |       1,522,547.54 |
          TestMarkdig | 6.3259 ms | 0.1434 ms | 115.00 |  75.00 |  55.00 |         785,682.84 |
     TestMarkdownDeep | 7.9409 ms | 0.0626 ms | 173.00 |  75.00 |  55.00 |         938,949.44 |

               Method |    Median |    StdDev |  Gen 0 |  Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------------- |---------- |---------- |------- |------- |------ |------------------- |
    TestCommonMarkNet | 4.7873 ms | 0.0881 ms | 188.43 |  13.16 | 80.36 |         992,620.58 |
 TestCommonMarkNetNew | 5.7098 ms | 0.0235 ms | 212.03 | 105.35 | 90.77 |       1,381,368.58 |
          TestMarkdig | 6.4275 ms | 0.0694 ms | 113.54 |  74.13 | 54.42 |         827,121.71 |
     TestMarkdownDeep | 7.9162 ms | 0.0472 ms | 173.00 |  75.00 | 55.00 |       1,000,627.30 |

As you can see, sometimes figures are jolting for the Gem0/Gen1/Gen2 (worse for Bytes Allocated/Op), changing even the ranking between runs.
When I'm running for example a simple benchmark (without using BenchmarkDotNet) and outputing GC.CollectionCount(0)/GC.CollectionCount(1)/GC.CollectionCount(2)) and testing one solution (like TestcommontMarkNet), the GC counts are fixed and not changing between runs.

Looking at the code, one thing I'm not sure is that I would expect the GCDiagnoser to only process GC events for the IterationMode.MainTarget period: Typically there are other periods that seem to be non deterministic (like the IdleTarget, not sure what it does, but it looks like it is adapting to the process) and we don't want them as part of the measurement. Also, not sure that it is good to have variable #operation count for different method when measuring GC events...

Ok, so after trying to tweak the usage of BenchmarkDotNet and using Mode.SingleRun which disable the Pilot phase, numbers are completely stable (and much more equivalent between the methods).
Though, not sure I did use correctly the API, but I had to patch the MethodInvoker.Invoke method to hardcode invokeCount = 64, because if I tried to setup the attribute on each method [Benchmark(OperationsPerInvoke = 64)], the methods are actually not executed and gives completely invalid results... so difficult to understand what's going on with this...
I used the following config:
var config = ManualConfig.Create(DefaultConfig.Instance);
var gcDiagnoser = new GCDiagnoser();
config.Add(new Job { Mode = Mode.SingleRun, LaunchCount = 2, WarmupCount = 2, TargetCount = 10 });
config.Add(gcDiagnoser);

As you can see, sometimes figures are jolting for the Gem0/Gen1/Gen2
(worse for Bytes Allocated/Op), changing even the ranking between runs

The Gen 0/1/2 values are scaled/normalised based on the min value across
the benchmarks (see
https://github.com/PerfDotNet/BenchmarkDotNet/blob/master/BenchmarkDotNet.Diagnostics/GCDiagnoser.cs#L174
), so it's not surprising they vary as the # of runs/Ops changes. However
the # Bytes is per Op, so should be more stable
On Saturday, 2 April 2016, Alexandre Mutel<EMAIL_ADDRESS>wrote:

The output I'm getting while running multiple times is like this:
           Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |

--------------------- |---------- |---------- |------- |------ |------ |------------------- |
TestCommonMarkNet | 4.8020 ms | 0.0326 ms | 208.54 | 14.34 | 89.28 |       1,117,194.48 |
TestCommonMarkNetNew | 5.7072 ms | 0.0541 ms | 169.87 | 84.31 | 72.44 |       1,124,892.65 |
TestMarkdig | 6.4552 ms | 0.0454 ms | 115.00 | 75.00 | 55.00 |         851,150.77 |
TestMarkdownDeep | 8.4201 ms | 0.5206 ms | 176.43 | 76.75 | 56.46 |       1,039,481.68 |
           Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |

--------------------- |---------- |---------- |------- |------ |------ |------------------- |
TestCommonMarkNet | 4.7802 ms | 0.0365 ms | 117.28 |  8.10 | 50.15 |         738,831.91 |
TestCommonMarkNetNew | 5.7256 ms | 0.0317 ms | 176.00 | 87.42 | 75.26 |       1,371,935.85 |
TestMarkdig | 6.2702 ms | 0.0673 ms |  91.59 | 59.74 | 43.81 |         797,976.80 |
TestMarkdownDeep | 7.9212 ms | 0.0405 ms | 164.00 | 71.00 | 52.00 |       1,134,079.22 |
           Method |    Median |    StdDev |  Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |

--------------------- |---------- |---------- |------- |------ |------ |------------------- |
TestCommonMarkNet | 4.8237 ms | 0.0504 ms | 152.82 | 10.51 | 65.42 |       1,117,194.48 |
TestCommonMarkNetNew | 5.6900 ms | 0.0490 ms | 138.97 | 68.97 | 59.27 |       1,255,915.01 |
TestMarkdig | 6.3441 ms | 0.0963 ms |  70.75 | 46.02 | 33.66 |         713,802.94 |
TestMarkdownDeep | 7.8991 ms | 0.0547 ms | 164.00 | 71.00 | 52.00 |       1,314,925.80 |
           Method |    Median |    StdDev |  Gen 0 |  Gen 1 |  Gen 2 | Bytes Allocated/Op |

--------------------- |---------- |---------- |------- |------- |------- |------------------- |
TestCommonMarkNet | 4.7855 ms | 0.0920 ms | 194.88 |  13.53 |  83.23 |         963,242.75 |
TestCommonMarkNetNew | 5.7061 ms | 0.0456 ms | 249.01 | 123.83 | 106.91 |       1,522,547.54 |
TestMarkdig | 6.3259 ms | 0.1434 ms | 115.00 |  75.00 |  55.00 |         785,682.84 |
TestMarkdownDeep | 7.9409 ms | 0.0626 ms | 173.00 |  75.00 |  55.00 |         938,949.44 |
           Method |    Median |    StdDev |  Gen 0 |  Gen 1 | Gen 2 | Bytes Allocated/Op |

--------------------- |---------- |---------- |------- |------- |------ |------------------- |
TestCommonMarkNet | 4.7873 ms | 0.0881 ms | 188.43 |  13.16 | 80.36 |         992,620.58 |
TestCommonMarkNetNew | 5.7098 ms | 0.0235 ms | 212.03 | 105.35 | 90.77 |       1,381,368.58 |
TestMarkdig | 6.4275 ms | 0.0694 ms | 113.54 |  74.13 | 54.42 |         827,121.71 |
TestMarkdownDeep | 7.9162 ms | 0.0472 ms | 173.00 |  75.00 | 55.00 |       1,000,627.30 |
As you can see, sometimes figures are jolting for the Gem0/Gen1/Gen2
(worse for Bytes Allocated/Op), changing even the ranking between runs.
When I'm running for example a simple benchmark (without using
BenchmarkDotNet) and outputing
GC.CollectionCount(0)/GC.CollectionCount(1)/GC.CollectionCount(2)) and
testing one solution (like TestcommontMarkNet), the GC counts are fixed and
not changing between runs.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/PerfDotNet/BenchmarkDotNet/issues/133#issuecomment-204603073

Yeah 'OperationsPerInvoke' isn't going to help, that's for something else.
However you should be able to use 'IterationCount' on the Job, see
https://github.com/PerfDotNet/BenchmarkDotNet/blob/master/BenchmarkDotNet/Jobs/Job.cs#L28

Looking at the code, one thing I'm not sure is that I would expect the
GCDiagnoser to only process GC events for the IterationMode.MainTarget
period: Typically there are other periods that seem to be non deterministic
(like the IdleTarget, not sure what it does, but it looks like it is
adapting to the process) and we don't want them as part of the measurement.
Also, not sure that it is good to have variable #operation count for
different method when measuring GC event

Good point, I need to have a think about how to best handle this.
On Saturday, 2 April 2016, Alexandre Mutel<EMAIL_ADDRESS>wrote:

Ok, so after trying to tweak the usage of BenchmarkDotNet and using
Mode.SingleRun which disable the Pilot phase, numbers are completely
stable (and much more equivalent between the methods).
Though, not sure I did use correctly the API, but I had to patch the
MethodInvoker.Invoke method to hardcode invokeCount = 64, because if I
tried to setup the attribute on each method [Benchmark(OperationsPerInvoke
= 64)], the methods are actually not executed and gives completely
invalid results... so difficult to understand what's going on with this...
I used the following config:
var config = ManualConfig.Create(DefaultConfig.Instance);var gcDiagnoser = new GCDiagnoser();
config.Add(new Job { Mode = Mode.SingleRun, LaunchCount = 2, WarmupCount = 2, TargetCount = 10 });
config.Add(gcDiagnoser);
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/PerfDotNet/BenchmarkDotNet/issues/133#issuecomment-204654313

Setting IterationTime doesn't work for me:
var config = ManualConfig.Create(DefaultConfig.Instance);
var gcDiagnoser = new GCDiagnoser();
config.Add(new Job { Mode = Mode.SingleRun, LaunchCount = 2, WarmupCount = 2, IterationTime = 64, TargetCount = 10 });
config.Add(gcDiagnoser);

It results in only 1 op:
MainTarget 1: 1 op, 4785568.28 ns, 4.7856 ms/op
MainTarget 2: 1 op, 4660543.99 ns, 4.6605 ms/op

Looking at MethodInvoker.cs:92 , IterationTime is only used for the Throughpu mode and not the SingleRun`

Also on a side note, I had to compile BenchmarkDotNet.Diagnostics on my side as it is not published to nuget. Is it a oversight?

Hm, ok, maybe Diagnostics cannot be released because xproj+project.json doesn't support yet embedding native files... arg... It seems we will have to wait for dotnet/cli :(

Hm, ok, maybe Diagnostics cannot be released because xproj+project.json doesn't support yet embedding native files... arg... It seems we will have to wait for dotnet/cli :(

Hmm, didn't realise that @adamsitnik or @AndreyAkinshin does this block us from releasing a BenchmarkDotNet.Diagnostics nuget package?

@xoofx are you happy with the workaround you have, i.e. using a custom Config?
Or would you want BenchmarkDotNet to be more stable/consistent across runs?

Hmm, didn't realise that @adamsitnik or @AndreyAkinshin does this block us from releasing a BenchmarkDotNet.Diagnostics nuget package?

Actually, I was able to ship native DLLs packInclude in project.json, along with a msbuild .targets file for net20-net4x+ platforms, so that is finally possible at least.

Or would you want BenchmarkDotNet to be more stable/consistent across runs?

Hm, actually, no as I said above, IterationTime  is not working, so I still had to patch the BenchmarkDotNet.
At least, when using GCDiagnoser, it is only useful to run it in a stable mode, otherwise figures are completely useless.
I'm wondering if it is really good to have this adaptive Iteration count done for each method... I would expect that the first run returns its adaptive results and other methods measured would use the exact same iteration. But I understand that in scenarios where figures are changing a lot between the methods, that would be not ideal (if a very fast method is used as a baseline for the count, and then a much slower method is used, it would take more time to run it...)... so yeah, not sure how to deal with this

Hm, actually, no as I said above, IterationTime is not working, so I still had to patch the BenchmarkDotNet.

IterationTime is in milliseconds, so you might need to increase it (depending on how long your benchmark lasts.

ah, ok :sweat_smile:, but how does it translate to a fixed count then? Not sure to understand the meaning of this parameter...

Back on the subject, so any way to run for all benchmarks the same count of loop (I guess SingleRun mode, with no setup/pilot phase) to have a predictible test with MemoryDiagnoser?
I tried
                var config = ManualConfig.Create(DefaultConfig.Instance);
                var gcDiagnoser = new MemoryDiagnoser();
                config.Add(new Job { Mode = Mode.SingleRun, LaunchCount = 2, WarmupCount = 2, IterationTime = 1024, TargetCount = 10 });
                config.Add(gcDiagnoser);

But doesn't not work...
Very annoying, as so far, I can't have reliable test with GC. If you have a workaround without modifying the code, that would help, thanks!

For reference, the patch I used to get stable results

@AndreyAkinshin, what are your thoughts on this, what's a safe way to make the # of Ops more consistent across runs? I don't want to break the core timings to make diagnostics work!
As a test I added the following line of code:
logger.WriteLineError($"// Run, Diagnostic - {allRuns.Sum(r => r.Operations):N0} Ops in total, across {allRuns.Count:N0} Runs");

And across 3 runs I got the following:
// Run, Diagnostic - 2,949,116 Ops in total, across 58 Runs
         Method | ArraySize |    Median |    StdDev |    Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------- |---------- |---------- |---------- |--------- |------ |------ |------------------- |
      GetSquare |      5000 | 3.5959 us | 0.0267 us | 7,085.00 |     - |     - |           8,872.17 |
 GetSquareStack |      5000 | 3.5182 us | 0.0235 us |        - |     - |     - |               0.44 |

// Run, Diagnostic - 2,818,044 Ops in total, across 56 Runs
         Method | ArraySize |    Median |    StdDev |    Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------- |---------- |---------- |---------- |--------- |------ |------ |------------------- |
      GetSquare |      5000 | 3.5873 us | 0.0274 us | 7,567.04 |     - |     - |           9,254.91 |
 GetSquareStack |      5000 | 3.5191 us | 0.0253 us |        - |     - |     - |               0.46 |

// Run, Diagnostic - 3,538,940 Ops in total, across 67 Runs
         Method | ArraySize |    Median |    StdDev |    Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |
--------------- |---------- |---------- |---------- |--------- |------ |------ |------------------- |
      GetSquare |      5000 | 4.0673 us | 0.3156 us | 9,702.31 |     - |     - |           9,448.04 |
 GetSquareStack |      5000 | 3.4928 us | 0.0117 us |        - |     - |     - |               0.39 |

This is the problem, the total number of Ops/Runs changes, which in turn means the Bytes Allocated/Op also varies.
Currently @xoofx uses the config below, plus this patch
var config = ManualConfig.Create(DefaultConfig.Instance);
var gcDiagnoser = new MemoryDiagnoser();
config.Add(new Job { Mode = Mode.SingleRun, LaunchCount = 2, WarmupCount = 2, TargetCount = 10 });
config.Add(gcDiagnoser);

What's the best way to get this behaviour into BenchmarkDotNet in a reliable way? What about if we explicitly set long invokeCount = 64, but only for Diagnostic runs? We already discard the timings from these runs anyway.

What you can do there is normalize everything. The Bytes Allocated/Op will be similar (no reason it should change over multiple runs) so normalization can give you a single value that is the average of all them.

I'm not sure that just normalising them will help here, because unless I'm mistaken what you're proposing, we already do that?
In MemoryDiagnoser.cs we have this code:
return (result.AllocatedBytes / (double)result.TotalOperations).ToString("N2");


Release Testing: Resilience in practice: worker1 fails to restart

Ref #2422
Running step 9.:

Restart worker1 with the same command we used above, but save its log output to a new file

Instead of a recovered worker, I get:
Recovering from recovery files!
Attempting to recover...
||| Resilience directory: /tmp/res-dir/wc|||
No latest checkpoint id in recovery file.
This should never happen: failure in /home/vagrant/wallaroo-tutorial/wallaroo-release-0.5.3/lib/wallaroo/ent/checkpoint/checkpoint_initiator.pony at line 422
vagrant@vagrant:~/wallaroo-tutorial/wallaroo-release-0.5.3/examples/python/word_count_with_dynamic_keys$ BoundaryNotify: attempting to connect...

Testing on ubuntu trusty.

Could it be that my machida is compiled without resilience? Testing on a wallaroo-upped system.

Related to (possibly duplicate of) https://github.com/WallarooLabs/wallaroo/issues/2444.
This is due to the unclear instructions pointed out at the bottom of https://github.com/WallarooLabs/wallaroo/issues/2437.

The same thing happens on wallaroo-from-source on trusty.

Same thing happens on Debian Stretch as well.

Not surprisingly, the same thing happens on Xenial


[BEAM-1130, BEAM-1133] Allow users to define max records per batch, update tests accordingly.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @jbonofre pending tests of course..

E2E failure is Apex so unrelated to this PR.

Confirmed test results indicate this fixes Spark tests. LGTM & merging.


Add metadata to the Object Store

Add metadata to the Object Store bucket and object itself, as described in the design doc update:
https://github.com/nats-io/nats-architecture-and-design/pull/224
Clients and Tools

[ ] CLI @ripienaar
[ ] Go @piotrpio
[ ] Java @scottf
[ ] JavaScript @aricart
[ ] .Net @scottf
[ ] C @levb
[ ] Python @wallyqs
[ ] Ruby @wallyqs
[ ] Rust @Jarema @caspervonb

Other Tasks

[ ] docs.nats.io updated @bruth
[ ] Update ADR to Implemented
[ ] Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

@Jarema possibly need the same option for the KV bucket?


Add a global block list and include Leviathan specific sounds

This is getting abused by players to help them with knowing what prayer to use on the awakened boss
https://clips.twitch.tv/FlirtyBadSnoodCharlietheUnicorn-_FJfrxyvjM-FMS3h
The sound ids are 7040, 7041, 7030.
Happy to make the code changes

Hi @gord5500,
I've only just caught up on the news that visual-sounds got taken down. Apologies, I wasn't notified at all about the plugin takedown so I didn't realise this issue was such a high priority.
Reopening this now until the issue is resolved

Done in https://github.com/runelite/plugin-hub/pull/4755


Refactor and consolidate the dotnet images

This change has two main parts:

It combines dotnet-{runtime,sdk} directories into one dotnet directory that produces both images,
It refactors dotnet to follow the style we have been using based on #1172 to consolidate configs and remove version tagging logic.

waiting on: https://github.com/wolfi-dev/os/actions/workflows/build.yaml

This should be RFAL


Profile DEFAULT , issuer Over 18 with ID360 fails, change issuer

To be discussed
Use now teh oidc4vc protocol
call is https://talao.co/id360/oidc4vc?type=over18&format=ldp_vc

sur carte identité


Wallet Connect Session Issue

At first, I connected the metamask, and after a successful metamask connection, I signed out.
And I have connected the trust wallet. but the connected wallet address is the metamask wallet address.
The second trust wallet connection should return the trust wallet address.

In the demo app address in the UI doesn't refresh immediately, but underlying session should be correct (i.e. sign request will go to the latest connected wallet).


Update system-requirements.md

Updated minimum RAM amount to have a good running experience

@mauritselzinga-mx Do you have any additional updates for this PR? If not, it can be merged at any time.

No, this is everything.


[Feature Request] Can we have a spam filter?

Hello, I am happy user of utterance in my blog, got my first spam comment today - so can we have a spam filter for utterances on top of same principles?

It seems more useful to me if GitHub had spam filtering.  Then everyone that uses GitHub would benefit from that feature instead of just users of utterances.

@bender2k14 that's a fair point. But I think it's more relevant for a comments section than issues on Github.  Alternatively this doesn't need to be part of utterances, another bot could read all the replies and filter them.

Ah, and back at you. A spam filter bot sounds like a good idea to me.

Couldn't someone just view the GitHub issue and comment there instead?

You can you Github API to check all comment, i have implement a BOT to remove all comment contain keywords:
https://github.com/luyencode/comment_bot


support pipe operation

Now you can do the following
Gtau = Gw |> imfreq_to_dlr |> dlr_to_imtime
close #62

Codecov Report

:exclamation: No coverage uploaded for pull request base (triq_dev@c94bea9). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             triq_dev      #64   +/-   ##
===========================================
  Coverage            ?   53.56%
===========================================
  Files               ?       15
  Lines               ?      631
  Branches            ?        0
===========================================
  Hits                ?      338
  Misses              ?      293
  Partials            ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


made most dependencies optional with Requires.jl

Putting all packages for importing different file formats as direct dependencies is quite convenient for the user, but has serious drawbacks:

The time for importing TableIO is very long (ca. 30s)
The installation of TableIO is very heavy-weight and includes many packages the user probably does not need
There may be issues due to incompatible dependences

Here, I am making all dependencies except CSV.jl and DataFrames.jl optional using Revise.jl. This makes the installation more light-weight and importing much faster (4s after precompilation for me).
ToDo: document how to use the optional dependencies

Codecov Report

Merging #9 into master will increase coverage by 0.34%.
The diff coverage is 94.93%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   95.40%   95.74%   +0.34%
==========================================
  Files           3        8       +5
  Lines          87       94       +7
==========================================
+ Hits           83       90       +7
  Misses          4        4

Impacted Files
Coverage Δ

src/parquet.jl
71.42% <71.42%> (ø)

src/TableIO.jl
100.00% <100.00%> (ø)

src/jdf.jl
100.00% <100.00%> (ø)

src/postgresql.jl
100.00% <100.00%> (ø)

src/sqlite.jl
100.00% <100.00%> (ø)

src/stat_files.jl
100.00% <100.00%> (ø)

src/xlsx.jl
100.00% <100.00%> (ø)

src/zipped_csv.jl
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dc606...e1b35aa. Read the comment docs.


Merge report

This Should work without problems later
@savitha97 @sriamazingram review this

Done.

@savitha97  make sure you run requirements.txt to run the apis

Alright.


Update collections to 0.4.2

https://phabricator.endlessm.com/T34961

Unfortunately, the build is broken now that we moved EOS master to python 3.11.

I did the simple thing and just changed the base image to EOS 5.1 so we get the previous python setup. If that passes, I'll merge the PR.


Update MongoDB with all RocketLab Launches

Resources:
https://www.flickr.com/photos/rocketlab/with/50595573132/
https://en.wikipedia.org/wiki/List_of_Electron_launches
https://www.reddit.com/r/RocketLab/

MongoDB updated to Launch 8

MongoDB updated to Launch 8

Done!

Done!


reuse receiver

we should be able to reuse in receiver to maximumly utilize the prefetched data

Looks like this is a duplicate of #54


"Parameter" is not exported from module "torch.nn"

Environment data

macOS: 11.6
VSCode: 1.68.1
Pylance: v2022.6.20

I am working on this repository. So, my environment can be reproduced as follows:
# you can use conda instead of micromamba, the result is the same
micromamba create -n rtdl python=3.7
micromamba activate rtdl
pip install numpy=1.18.5 torch=1.7.1 scikit-learn=1.0.2
pip install -r requirements_dev.txt

Code Snippet
Create a file rtdl/a.py with the following content:
import torch.nn as nn

nn.Parameter

Expected behavior
I expect no warnings and no red underlines regarding nn.Parameter. mypy agrees with me and does not complain about this file.
Actual behavior
The nn.Parameter is underlined in red. Interestingly, when I hover over it, I see the correctly inferred docstring, but in the end at also contains the following error message: "Parameter" is not exported from module "torch.nn" Pylance (reportPrivateImportUsage)"
Logs
The logs are going beyond the GitHub limits :( If they are needed, what are the relevant parts that I should provide?

I have just checked that the issue can be reproduced with the latest torch 1.11.0 as well (1.11.0).

torch==1.11.0 worked for me on windows.
i'll try linux

Just in case, here is the illustration:

I get the same error as well.
I'm on nixos
Python 3.9.12 (main, Mar 23 2022, 21:36:19)
[GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> torch.__version__
'1.11.0+cu113'

couldn't repro on linux. any luck on your side?

nope, and in fact I have been experiencing this issue for a long time

Torch is a "py.typed" library which means it contains inlined type information.
When a library is marked "py.typed", pyright (the type checker that underlies pylance) applies certain rules to determine whether specific symbols are intended to be visible from a module. These rules are documented here.
The module torch/nn/__init__.py imports the Parameter symbol, but it does not indicate that this symbol should be re-exported — and therefore made visible externally. To do so, it would need to use a redundant form of import: from .parameter import Parameter as Parameter. If you manually make that change in the torch/nn/__init__.py file, you'll see that nn.Parameter no longer generates an error.
If you believe that Parameter is meant to be visible from the torch.nn module, then this is a bug in the torch library, and you should report it to the torch maintainers.
As a workaround, you can access the Parameter symbol through the module that defines it: nn.parameter.Parameter.
You can also configure pylance to disable the reportPrivateImportUsage diagnostic rule, effectively silencing this error.

Thank you for the detailed answer! I created the issue in the PyTorch repository.
P.S. Is the approach from .parameter import Parameter as Parameter expected to declare public interface  by convention in Python or is it just a Pylance-specific workaround? To me it looks like the "portable" solution would be to explicitly create the __all__ variable.

This approach was standardized in PEP 484 for type stubs. It hasn't been officially adopted in a PEP for "py.typed" libraries, but there is general consensus among type checker authors that it makes sense to use the pattern established by PEP 484. This guidance has been posted on the python/typing site.
The __all__ variable designates "symbols that should be imported by a wildcard import", so it often overlaps with the notion of "symbols that are meant to be publicly visible from a module", but there are cases where the former is a subset of the latter.


480p when should be 1080p

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request

General infomration
I'm getting 480p streams when they should be 1080p, everything is set correctly yet this addons keeps only showing me 480p
Prerequisites
Happens on LibreELEC and windows 10, some shows are 1080p while other than should also be 1080p are only shown in 480p

[ ] Are you running the latest version?
YES

There was a bug in inpustream.adaptive where if you selected 720p, you would get a lower quality stream. And if you selected 1080p you would get the 720p stream. It is fixed in peak3d/inputstream.adaptive#259


ffjson generated code fails to build in my project

test/test.go
package test

type Color struct {
    Red   uint8 `json:"red"`
    Green uint8 `json:"green"`
    Blue  uint8 `json:"blue"`
    Alpha uint8 `json:"alpha"`
}

type Colors struct {
    Font       Color `json:"font"`
    Background Color `json:"background"`
}

type KVMap map[string]map[string]Colors

type KVResp struct {
  KVM KVMap `json:"kvs"`
}

main.go
package main

import (
  "fmt"
  "demo/test"
)

func main() {
    t := test.KVResp{}
    fmt.Printf("%#v\n", t)
}

Builds and runs correctly
>$ go build -v
demo/test
demo
>$ ./demo
test.KVResp{KVM:(*test.KVMap)(nil)}

But fails to build with ffjson:
>$ ffjson test/test.go
test/test_ffjson.go
$ go build -v
demo/test
# demo/test
test/test_ffjson.go:773: undefined: test in test.Colors
test/test_ffjson.go:781: undefined: test in test.Colors

Seems like one of the issues is map of maps usage, if I replace it with one level map:
type KVMap map[string]Colors

it works. Is this a known limitation? I only see map mentioned under performance pitfalls, so I would expect this to work. Thanks

has same problem when using map


Improved field usage tracking and mapping

When we move to JSONC (#333), we will be able to track field usage better, as we can process JSON as an AST rather than as a single blob of text. As such, we should process the AST when we save and correctly flag field usage with a better method and take this opportunity to resolve fields using internal query names rather than display names for consistency across create/map/export dialogs.

This has been delivered to the alpha channel in its initial form. Given the size of the PR, we will create and track anything to do as new issues (or reopen this if absolutely necessary).


Block gaslimit member.

The block member should be block.gaslimit, and not block.gasLimit as it is now.

Changed, thanks for reporting it


[question] Considering ROS

Hi,
have you considered Robot Operating System as base for this amazing project?

Yes. Unfortunately they are not quite suitable for a consumer friendly project.

There is no deploy pipeline for developers.

This means there is no simple way of creating a lean stable image to be flashed to an SD card, and doing so becomes a manual task for the developer

It is developed in python.

Python is a scripting language, and I've found not very stable or suitable for production systems. This is mostly personal preference.

I actually agree on both points :-)
Regarding the pipeline, there is some project if I am not wrong regarding its purpose:
https://github.com/mikepurvis/ros-bundling
Regarding Python, well, I have have seen lots of production grade systems on Python, but I do not prefer this language as well. I am experimenting for some while with OpenHAB (openhab.org), which is Java framework for house automation as this is related I had in mind pure Java based on ROSJava.
But I would understand that Java is not your language of choice...

That bundler you linked is close to what is needed, but not the entire package.
I prefer to do all my work on the host machine, then deploy to the target.
So I can build, test and debug locally on my 8 core, 64 gigs of RAM machine. The when its ready I can easily do something that will:
Cross compile a Linux environment, cross compile all of my libraries, cross compile my project, then finally bundle to one single file to be distributed to the target device. (in this case the raspberry pi).
I've only seen one framework that does this entire thing cross platform and that is nerves. There is other options. You suggested Java. Java actually can be deployed super easily because it is a virtual machine. But java misses some things also
From the farmbot os runtime, we require networking configuration utilities. As far as I know, there aren't any Java libs for configuration of network. (besides maybe Android?) Plus I just don't really like java. C/Cpp projects have a similar argument but again you have to build the entire development pipeline yourself, and I prefer a higher level than c/Cpp when it is applicable.
Also our "robot" code is actually wrote in Cpp and executed on an Arduino. It communicates to farmbos os via uart, so any ROS would be a little bit overkill.

it is possible to to implement ros on linux for flash image and use it to production device. if you provide documentation of farmbot os development than we can do it. implement whole elixir package on ros. and than bind it with linux ready to use as plug and play


unlinkable_block_exception: Unlinkable block

unlinkable_block_exception: Unlinkable block,then eos crush.
why?

The only known cause of unlinkable blocks in the current release is bnet_plugin.  Use net_plugin instead.

you mean in config.ini,use net_plugin instead of bnet_plugin?

Yes, in your config.ini, use
p2p-peer-address =

instead of
bnet-connect =

to connect to your peer. Make sure you input the net_plugin endpoint of your peer instead of bnet_plugin endpoint of your peer when you fill the config.ini.
net_plugin should be enabled by default in nodeos, so you don't need to explicitly state it in the config.ini

yes,I have already done this before unlink show.

@csquan are there any log messages before the unlinkable_block_exception in the log.  Peers on the p2p network will still send you blocks even if you fail to validate one of them.  Failing creates a gap which makes all the newly learned blocks "unlinkable"
There may be a root cause of the unlinkable blocks before them in the logs

Closed as no further reply. If you still have the same problem please ask https://eosio.stackexchange.com/ .


Update variables.tf

PR o'clock
Description
Please explain the changes you made here and link to any relevant issues.
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

I don't get the purpose of your changed / PR. What you want to do ?

Sorry it was a mistake - please disregard.
On Thu, May 20, 2021 at 7:03 PM Thierno IB. BARRY @.***>
wrote:

I don't get the purpose of your changed / PR. What you want to do ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1381#issuecomment-845537604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACTLCF4C7R52K6P3NRXV44DTOWIN3ANCNFSM45H5GEIA
.

--
Dan Peacockhe/him
Sr. Solutions Engineer
e @.***
m +1<PHONE_NUMBER> <+16093542306>
https://www.hashicorp.com/


Support tensorflow 1.14.0 ?

I haven't done much testing, but I was able to build CPU-only 1.14.0 with this.


Remove stack if configuration is not applied

What does this PR do?
Remove the stack if the configuration is not applied to avoid leaving the stack in a bad state.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


feat: progress bar for iroh add command

This introduces a progress bar for the iroh add command. It touches the following layers:

the various add_dir, add_file functions in iroh::resolver::unixfs_builder now return a stream of AddEvents

these are exposed in the iroh-api where they are mockable. The iroh-api also provides a higher level method to resolve a AddEvent stream to a CID

iroh::size introduces a way to calculate total size of each file on the filesystem

The iroh add command in the iroh crate then calculates the total size with a spinner, and then uses this to show a progress bar.

Note that indicatif, the progress bar library, allows a lot of tweaking of what we see, both color, characters and text. I made a selection to get started. Suggestions for tweaks of what the bar looks like are welcome.
I will create a follow-up PR where I add a "current file" indicator in the progress bar, but I think this is already major progress so didn't want to hold back merging. Update Getting current file information requires quite a lot of changes inside unixfs_builder with some open questions, so I am going defer the creation of this follow-up PR until later and focus on earlier wins.

I've experimented using try_flatten_stream() to simplify the result of the add_file, add_dir, etc methods in the API. But as discussed with @rklaehn this does hide a real difference between not being able to initiate the stream versus having an error on the stream so I think I'll stay away from that for now.

Note to self: I need to check whether I really caught all call sites of add_file, I think I may have missed one in the gateway. Need to provide a consuming version for that place and benchmark code.

Trying this out right now. The first thing I noticed is that adding is pretty slow. But I guess that is not this PR's fault...

At least on the mac, things start getting weird if you resize the terminal window to a smaller size than the width of the text.

If your terminal is already less wide than the text on startup, the delete does not work and you get one line per update:

Not sure if you can do anything about that, just wanted to mention it...

Trying this out right now. The first thing I noticed is that adding is pretty slow. But I guess that is not this PR's fault...

Yeah, I noticed widely varying performance too. You should try it on iroh/iroh. It takes a surprisingly long time for a few kb, much longer than for other crates which are much bigger, probably because it has a bunch of small trycmd test files.

So as far as the API changes are concerned:
* I have to say that the async_trait output looks horrible in docs

* I am not sure about returning LocalBoxFuture / LocalBoxStream in the api. That is going to make things quite annoying to use from tokio etc. What's the actual reason for that?

Why does it make it more annoying to use? What could I return instead?

Why does it make it more annoying to use?

As soon as you are in async land, basically the default case is that your streams and futures can be polled from any thread (aka are Send). Now, this is sometimes not necessary, e.g. if you have a single threaded executor. But this is not captured in the type system. I am suffering from this all week because some parts of the rocksdb binding are not Send, so it is a pain to use in async.
E.g.
fn main() {
  // a local future
  let f = async { "whatever" }.boxed_local();
  //
  tokio::task::spawn(|| async move {
    let x = f.await; // does not work because f is not Send
  });
}

Now take a look at our codebase and you will see that spawning a task is a very frequent thing in typical async code...

Whether that is a good thing or not I won't comment on, it's just how it is.
So an API that only has local futures and streams will be an api that people hate...

What could I return instead?

I did a quick check. The non send requirement kinda bubbles up from the bottom, but it is just a few places where you would have to require Send.
Here is a commit that adds Send and friends in a few places to allow the API to be Send: https://github.com/rklaehn/iroh/commit/59bc0b5ff7e1c668c21515ed8ac79c76cd32e75f
Now if we should do that I have no idea, I guess we would have to have a longer discussion. But this is what we would have to do.
Ping @dignifiedquire


[SPARK-42611][SQL] Insert char/varchar length checks for inner fields during resolution

What changes were proposed in this pull request?

This PR adds  char/varchar length checks for inner fields during resolution when struct fields are reordered.
Why are the changes needed?

These checks are needed to handle nested char/varchar columns correctly. Prior to this change, we would lose the raw type information when constructing nested attributes. As a result, we will not insert proper char/varchar length checks.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

This PR comes with tests that would previously fail.

cc @huaxingao @cloud-fan @dongjoon-hyun @sunchao @viirya

@dongjoon-hyun, I overlooked. I corrected the JIRA description and added 3.3.3 as well but feel free to adjust the list of versions as needed.

Thank you!

Could you rebase to the master branch?

This is a good catch! I think the fix can be simpler: we encode the raw type information in the root StructField, so we don't need to decode it recursively. We can restore the raw type at the very beginning:
def resolveOutputColumns(
    ...,
    expected: Seq[Attribute],
    ...) {
    val actualExpectedCols = expected.map { attr =>
        attr.withDataType(restore(attr.metadata))
    }
}

@cloud-fan, are thinking of passing raw types all the way? I actually considered that but my worry was we will have to modify checkField casting logic as it seems we can't use the raw type there.
  private def checkField(
      tableAttr: Attribute,
      queryExpr: NamedExpression,
      byName: Boolean,
      conf: SQLConf,
      addError: String => Unit,
      colPath: Seq[String]): Option[NamedExpression] = {

    val storeAssignmentPolicy = conf.storeAssignmentPolicy
    lazy val outputField = if (tableAttr.dataType.sameType(queryExpr.dataType) &&
      tableAttr.name == queryExpr.name &&
      tableAttr.metadata == queryExpr.metadata) {
      Some(queryExpr)
    } else {
      val casted = storeAssignmentPolicy match {
        case StoreAssignmentPolicy.ANSI =>
          val cast = Cast(queryExpr, tableAttr.dataType, Option(conf.sessionLocalTimeZone),
            ansiEnabled = true)
          cast.setTagValue(Cast.BY_TABLE_INSERTION, ())
          checkCastOverflowInTableInsert(cast, colPath.quoted)
        case StoreAssignmentPolicy.LEGACY =>
          Cast(queryExpr, tableAttr.dataType, Option(conf.sessionLocalTimeZone),
            ansiEnabled = false)
        case _ =>
          Cast(queryExpr, tableAttr.dataType, Option(conf.sessionLocalTimeZone))
      }
      val exprWithStrLenCheck = if (conf.charVarcharAsString) {
        casted
      } else {
        CharVarcharUtils.stringLengthCheck(casted, tableAttr)
      }
      // Renaming is needed for handling the following cases like
      // 1) Column names/types do not match, e.g., INSERT INTO TABLE tab1 SELECT 1, 2
      // 2) Target tables have column metadata
      Some(Alias(exprWithStrLenCheck, tableAttr.name)(explicitMetadata = Some(tableAttr.metadata)))
    }

    storeAssignmentPolicy match {
      case StoreAssignmentPolicy.LEGACY =>
        outputField

      case StoreAssignmentPolicy.STRICT | StoreAssignmentPolicy.ANSI =>
        // run the type check first to ensure type errors are present
        val canWrite = DataType.canWrite(
          queryExpr.dataType, tableAttr.dataType, byName, conf.resolver, colPath.quoted,
          storeAssignmentPolicy, addError)
        if (queryExpr.nullable && !tableAttr.nullable) {
          addError(s"Cannot write nullable values to non-null column '${colPath.quoted}'")
          None

        } else if (!canWrite) {
          None

        } else {
          outputField
        }
    }
  }

@cloud-fan, I think passing raw types from the start would be simper and more efficient but we will have to modify checkField to work with raw types. Let me know if I got you correctly.

Yea, we will have to modify checkField. We can replace char/varchar type with string type in checkField so that most code can be unchanged, and only use the original type for length check related logic.

Sounds good, I'll make the change today.

Thank you, @aokolnychyi , @cloud-fan , @huaxingao , @viirya !


Fix the status method in kubernetes provider

This PR modifies the _status method in kubernetes provider.
It also changes the site test test_site.py a bit because in Kubernetes provider, there cant be more than nodes on one block, so instead there are two blocks, each with one node. The second block takes some time to launch, causing the later assertion assert len(pinfo) == 2, "Expected two nodes, instead got {}".format(pinfo) in the test to fail.

@BenGalewsky You might want to take a quick look at this. This impacts funcX.

ZZ, this PR looks good to go. It's unclear whether the changes to test_site.py necessary for this PR. Can you clarify why this was added?

The test config for general providers is a block with 2 nodes, while the config for k8s has 2 blocks and each has only 1 node (one cannot request 2 nodes in 1 block for k8s). This is to ensure there will be two workers before real testing (adding a small sleep to ensure even if the scale_out is too slow).

Okay, that makes sense.


Searched addresses displaying in all lowercase

@jen-tolentino
State users are pointing out that the searched "Registered Address" is displaying in lowercase for the street and city, regardless of how it was entered by the user.

If it's possible to proper case those parts of the address, that would be helpful.

In case this is useful,this used to be the way the tool displayed the searched address.  If we can undo this change, that would be great.

This appears to be a change in how the API normalizes the entered address.
I'll add a capitalizing function to the tool.
Alex Konrad
On Fri, May 22, 2015 at 12:52 PM, MariaDemocracyWorks <
<EMAIL_ADDRESS>wrote:

[image: image]
https://cloud.githubusercontent.com/assets/7061871/7775446/3a1a3bc6-0081-11e5-8420-0a9faea06f52.png
In case this is useful,this used to be the way the tool displayed the
searched address. If we can undo this change, that would be great.
—
Reply to this email directly or view it on GitHub
https://github.com/votinginfoproject/vip-embeddable-tool/issues/124#issuecomment-104711957
.

Alex, thanks for looking into this. Since its a function of the API, let's put this on hold until we can confirm with Google that this isn't a bug.

Closing this because we've established it's the API and opened up a related enhancement (#125).


Switch speed perturbation to use SOX

Librosa's implementation seems to cause issues despite being faster.

Potentially look into something like audiotsm (https://audiotsm.readthedocs.io/en/latest/) and benchmark.


Deployment

#Deployment
##User story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
##Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

SITE IS LIVE


[SPARK-35639][SQL][FOLLOWUP] Make hasCoalescedPartition return true if something was actually coalesced

What changes were proposed in this pull request?

Add CoalescedPartitionSpec(0, 0, _) check if a CoalescedPartitionSpec is coalesced.
Why are the changes needed?

Fix corner case.
Does this PR introduce any user-facing change?

yes, UI may be changed
How was this patch tested?

Add test

Test build #141012 has started for PR 33342 at commit 464b3d3.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45526/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45526/

Test build #141012 has finished for PR 33342 at commit 464b3d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

thanks, merging to master/3.2!

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141012/


Unify Expr::WindowFunction and Expr::WindowUDF

Is your feature request related to a problem or challenge?
Part of  https://github.com/apache/arrow-datafusion/issues/8045 we are working
to consolidate the function implementation in DataFusion to make it easier to
manage DataFusion's built in list of functions as well as ensure user defined
and built in functions have the same feature sets.
I think it is also important to keep the Expr representation consistent for
Aggregate and Window functions to make DataFusion easier to work with, as well
as to permit eventually applying the same unification of built in and user
defined functions to aggregates and window functions.
Describe the solution you'd like
I would like to unify Expr::WindowFunction and Expr::WindowUDF following the pattern in https://github.com/apache/arrow-datafusion/pull/8258 @2010YOUY01:

Remove  Expr::WindowUDF
Add an WindowFunctionDefinition that mirrors ScalarFunctionDefinition
Update Expr::WindowFunction so that it is used for both built in and user defined functions
Update the code to use these new APIs

Describe alternatives you've considered
No response
Additional context
I think this is a pretty good first issue because we have an existing pattern in https://github.com/apache/arrow-datafusion/pull/8258

it seems like we already unified WindowFunction in
https://github.com/apache/arrow-datafusion/blob/4c914ea1e5d3dc61f3552adcffb8356c90d73bac/datafusion/expr/src/expr.rs#L515-L526
and
https://github.com/apache/arrow-datafusion/blob/4c914ea1e5d3dc61f3552adcffb8356c90d73bac/datafusion/expr/src/window_function.rs#L35-L44

it seems like we already unified WindowFunction in

That is an excellent point. Thank you for the research @haohuaijin
Maybe we could rename https://github.com/apache/arrow-datafusion/blob/4c914ea1e5d3dc61f3552adcffb8356c90d73bac/datafusion/expr/src/window_function.rs#L35-L44 to WindowFunctionDefinition so we didn't have so many things named WindowFunction and to mirror the structure of ScalarFunctions

@haohuaijin are you already working on it or can I pick it up?

@edmondop I haven't started working yet, feel free to pick it up.

@alamb I am probably losing some pre-requisite, the Expr doesn't contain a WindowUDF variant but only a WindowFunction variant https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr.rs#L156 there is an AggregateUDF though...

You are right that the ticket description was incorrect, as @haohuaijin  noted in https://github.com/apache/arrow-datafusion/issues/8347#issuecomment-1832226281
I have updated it to say "rename WindowFunctiontoWindowFunctionDefinition`" -- sorry for the confusion
I think AggregateUDF is covered by https://github.com/apache/arrow-datafusion/issues/8346


Save settings

This fixes: https://app.asana.com/0/158602294500137/165137057233590

I looked into that, unqlite requires cython and I wasn't sure if it was worth adding the extra dependency and complexity in the build process.
But - seeing as using 0.5.3 makes the windows build easier, I've added https://app.asana.com/0/136290697597644/168474034092992


Link to Java examples is incorrect

What needs to be changed?
The link to the Java examples is incorrect.  It currently points to https://github.com/open-telemetry/opentelemetry-java/tree/main/examples but should be https://github.com/open-telemetry/opentelemetry-java-docs
What is the name + path of the page that needs changed?
On https://opentelemetry.io/docs/instrumentation/java/, i.e docs/instrumentation/java in the API reference and examples section

Closed by #1161


Why showing HUD hides keyboard?

I use code below to show progress :
hud=KProgressHUD.create(context)
                .setStyle(KProgressHUD.Style.SPIN_INDETERMINATE)
                .setAnimationSpeed(2)
                .setDimAmount(Constants.HUD_DIM_AMOUNT)
                .setMaxProgress(100);
hud.show();

Why this hides device keyboard? I want keyboard to be visible.
Thanks

The hud is basically a customized Dialog, so that's the default behaviour.
Looking into configuring dialog soft input mode might be some help but I don't know for sure though.


SVO playback - Not enough memory

Hi,
I'm trying to convert a recorded SVO to depth using opencv and the zed api to read the files.
But when I try to initialize a camera object from an SVO file, it sometimes gives me an error:
"NOT ENOUGH GPU MEMORY". At other times it just gets stuck loading the SVO.
I also tried using the svo playback from the zed-examples github, same results.
System:
Ubuntu 16.04
ZED SDK 2.7
CUDA 9
Hope anyone can help me!
Thanks.

Fixed the issue by upgrade to 2.7.1 - perhaps a bug in 2.7.0.


use webdriver for setup a basic view with websocket ?

Hi,
not sure if you considered that idea...
webdriver is supported by all browsers but being HTTP, it brings latency. If performance is a concern for exchanging between node and the webview content, the webview could connect to a websocket server set up by node.

Sorry I don't follow. What problem could WebDriver solve?

To avoid having to compile a c++ nodejs addon !


Proposal deposit returns

Description
TODO add deposit to ConwayGovernance when a new govaction is proposed. requires #3498
resolves #3494
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[ ] Self-reviewed the diff

Waiting on #3498