net/url: inconsistent Parse error with missing port

go version devel +467a2cb Sun Aug 16 00:29:39 2015 +0000 linux/amd64
http://play.golang.org/p/FkTC5G-xhb
With Go 1.4, this runs without any error.
With the above go version, only the last form ([IPv6]:) fails to parse with the error:
invalid port ":" after host
I would expect either parsing not to fail at all, or to fail for all the URLs without a port after the colon, for consistency.
Is this the desired behaviour ?

CC @mikioh

I'm not sure whether there's a good way to support both RFC 3986 and non-RFC 3986 compliant stuff such as database source names and connection strings. See #12023.

Is this the desired behaviour?

That's a good question, but I have no answer to it for now. Sorry.

Just to be clear, my point is not that "http://example.com:/" should be supported, even though it was supported so far in Go 1.4 , and even though section 6.2.3. seems to imply it is a compliant case.
My point is: if it is decided that the "http://example.com:/" form is supported for parsing, then all three of:
https://<IP_ADDRESS>:/foo
https://2b01:e34:ef40:7730:8e70:5aff:fefe:edac:/foo
https://[2b01:e34:ef40:7730:8e70:5aff:fefe:edac]:/foo
should probably be supported (as it was the case so far), and not just the two first forms.
Or are you saying that the brackets around the host is exactly what makes that form non-RFC 3986 compliant?

Or are you saying that the brackets around the host ...

I think of simply accepting https://2b01:e34:ef40:7730:8e70:5aff:fefe:edac:/foo might make people unhappy because the net package and its APIs don't support the host subcomponent of the URL,  2b01:e34:ef40:7730:8e70:5aff:fefe:edac: or <IP_ADDRESS>:, and http.Get(https://2b01:e34:ef40:7730:8e70:5aff:fefe:edac:/foo) returns an error. But I may be wrong.

I made this as well see https://play.golang.org/p/qm_YKwrvf3 and https://github.com/docker/docker/pull/15703

For the record, https://2b01:e34:ef40:7730:8e70:5aff:fefe:edac:/foo is NOT a well-formed IPv6 URL. The [ ] around the IPv6 address are not optional. If browsers accept that, consider yourself lucky.
For the most part, net/url makes no attempt to parse the host in the URL. The exception is IPv6 literals, although I am not sure why we bother to check them so carefully. Maybe because they are just one giant exception to all the rules.
In any event, the grammar in https://tools.ietf.org/html/rfc3986#page-22 seems to suggest that port can be an empty string even when a colon is present, so I'll make that change in the IPv6 literal parsing.

well, it's good to know that url.Parse can't be relied upon for checking the host part, thanks. I would think that specific bit should be mentioned somewhere in net/url, but I suppose there's a good reason for it not to be there. Maybe you don't want to commit to that kind of implementation "detail" ?


Can I run it without an argument?

I am trying to run a binary with options like this: the first one does not have an argument but only a value.
 someDirectory -saveData true
Is it possible? If so, how to set in the code?
Thanks.

You can use positional arguments for that. You can assign a single value variable to the first positional argument.

Hi Jarro，
Thank you for your reply. I am pretty new to the options and also cpp, so just not quite sure of how to implement it.  Could you provide an example?
Thanks.

On May 1, 2020, at 22:43, jarro2783<EMAIL_ADDRESS>wrote:

You can use positional arguments for that. You can assign a single value variable to the first positional argument.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sure. You would add an argument that takes a string:
options.add_options()
  ("f,file", "File name", cxxopts::value<std::string>())

then call
options.parse_positional({"file"});

Then when you call options.parse, the first argument without an option name will be parsed into file.

Thanks for the example. It works. But the positional argument is still not quite clear to me.
In readme:

options.parse_positional({"first", "second", "last"})
where "last" should be the name of an option with a container type, and the others should have a single value.

For example: options.parse_positional({"a", "b", "c", "d", "d"}), do you mean the last one of 'a' 'b', 'c', 'd', ie 'd', should be a container type? Could you elaborate it or provide some examples?
Thanks.

You would do something like this:
("f,file", "File name", cxxopts::value<std::vector<std::string>>())

where the argument type is a vector.
Yes only the last of those should be a container, because the first container type will gobble up the rest of the arguments.


Remove the on-hover shadow in theatre mode

Is your feature request related to a problem? Please describe.
By default, on hover the YT player puts a screen-width black shadow along the bottom while in theatre mode.
Describe the solution you'd like
Add an option to disable this shadow

Do you have a screenshot of this shadow? I'm wondering if we are seeing the same shadow.

Just above the title

On bright videos it becomes very hard to scrub the timeline and use the controls when you remove the shadow. So, I won't be making this an option, to prevent confusion.

However, you can hide the shadow yourself via this css rule in the Stylus extension:
.ytp-gradient-bottom {
  display: none !important;
}

Ah, I didn't consider that. But thank you for the CSS at least!


♻(demo) Move the demo site to its own application

Purpose
The command that creates the demo site is inside the core app. This was creating circular dependency issues and is a bad design because the dependency tree should be in order:
core <- courses <- demo
Proposal

[x] Move all the code related to the demo site to a separate demo app,
[x] Refactor tests and factories so that:

tests can use only factory boy dummy images,
the demo site command can use real images with a random picker.

@jmaupetit well spotted. I moved back the whole static folder to the core app as the logo is also used in our templates...


MAT-7427 Error while running Test cases after changing the Measurement Period

MADiE PR
Jira Ticket: MAT-7427
(Optional) Related Tickets:
Summary
All Submissions

[x] This PR has the JIRA linked.
[ ] Required tests are included
[x] No extemporaneous files are included (i.e Complied files or testing results)
[x] This PR is into the correct branch.
[ ] All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
[ ] Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

[ ] This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
[ ] All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers
By Approving this PR you are attesting to the following:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
The tests appropriately test the new code, including edge cases
If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

incorrect fix..closing. new fix- https://github.com/MeasureAuthoringTool/madie-measure/pull/606


GHA: Event data

Let's see what's inside and how we can use it.

test

Hi there, this is a comment made by changes from this action in PR #3!

Hi there, this is a comment made by changes from this action in PR #3!

Hi there, this is a comment made by changes from this action in PR #3!

Hi there, this is a comment made by changes from this action in PR #3!

Hi there, this is a comment made by changes from this action in PR #3!

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Yet another test comment ...

Some test comment from a rusty GH action.

Some test comment from a rusty GH action.

Some test comment from a rusty GH action.

Some test comment from a rusty GH action.

Some test comment from a rusty GH action.

Some test comment from a rusty GH action.


Update the specs interface

This makes it easier to consume the initial specs if that is all that is desired.

👍


lockbot: don't comment when locking issues

https://github.com/apps/lock
Closes: https://github.com/prometheus/prometheus/issues/5399

Fixes https://github.com/prometheus/prometheus/issues/5399

Perfect!


Callback on LayoutAnimation never been called.

Version: 0.17
Platform: Android
After tracing the code, I have found that success and failure callbacks never been passed from here to here.
Is there any reason for this? Or Just because of experimental feature, it never been implemented?

@facebook-github-bot bugfix

I can confirm this on Android: https://rnplay.org/apps/7tV7Tg
Callbacks work on iOS.

any news?

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/callback-on-layoutanimation-never-been-called
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

Has resolved?
Version: 0.38.1
Platform: iOS
onAnimationDidEnd never be called.

This still seems to be an issue. Would be awesome to get a resolution to it.

Still an issue, but the docs now state that onAnimationDidEnd is only supported on iOS. Why? This is an essential hook if you want to avoid calling a layout animation while another is currently running.


feat(chain): add elastos networks

Add support for the Elastos  mainnet.

I have just submitted a pull request.


Why not use FAPE loss?

Hi, I am wondering why you don't use fape loss to supervise the training. it is a more natural choice. It optimizes the rotation and translation predictions jointly.

@luost26 Hi, shitong, I experiment the fape loss and observe that the loss and gradient go nan after one step of gradient descent. You may find out the similar issue and thus give up using fape in your model right?
Would you like to talk about a bit of your experiences about this?
I will keep this issue once I find out the solution or the reason.

We have many internal versions, including FAPE loss-based. All of them are trained successfully and we did not encounter NaN issues. Please double check.

Thanks for the information. I use OpenFold's implementation of FAPE. The problem maybe be it.  If fape works, why your paper version does not use it? Because the performance is lower than other versions?


Open database - error on get keys

When the user has the app installed with old keys, the database service can't find the keys with the old address.
The user should be logged out before.
#384 related

#476 solved this.


Feature/mobbl 1380

The following has been removed:

No more support for Tab/Tabbar
No more support for Search
No more ActionBarBuilder
No more MBHeader
No more tool definition
Search handling has been removed
Actionbar has been removed and now mobbl is supporting Toolbar
Removed unsupported styles

Renamed:

Constants to MBConstants
ScreenConstants to MBScreenConstants
ImageCache to MBImageCache
ImageCacheObject to MBImageCacheObject
ImageUtil to MBImageUtil
LoadedImageCallback to MBLoadedImageCallback

New/Different

MBDefaultShutdownHandler only does a finish.
MBMessagedShutdownHandler shows a message before asking if you really want to shutdown
MBBasicViewController now has buildToolbar and setToolbarTitle
Within MBRESTServiceDataHandler you can now overwrite how a body is build up by getHTTPRequestBody

Dude, the code-formatting; pay attention to it.. :') Seems fine otherwise, though :)


India User , Scrpit not working for me

I am noob to all of this ,
Here is my problem: I am from India, and the messages I send on Instagram appear on the right side. However, I think the script is trying to unsend messages from the left side. It works great for reels, though. Also, I think the script is trying to find three dots near messages (more options), but in my case, that option appears on both sides (the messages I sent and the messages I received). Not with the reels, though. I think that's the reason reels work great for this script. So, are there any settings I can use to fix it? I am a noob, as I said earlier, so tell me in detail what to do.

The dots are supposed to be on both side, so don't worry about that.
Could you tell me then where it fails to work by performing the steps to reproduce the issue and then includes your full console logs here ?
Finally, if you could include a screenshot of the messages it fails to unsend if there's any?

A new version (v0.5.19) has been released.
Please open a new issue following the provided template if your problem persists.


chore: import repository https://github.com/qiang123/node-http.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository qiang123/jx3-minikube for ref
failed to switch to ref
failed to fetch repository qiang123/jx3-minikube
error pulling
exit status 1 error
unable to create temporary file
No space left on device
fatal
failed to write object
fatal
unpack-objects failed

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository qiang123/jx3-minikube for ref
failed to switch to ref
failed to fetch repository qiang123/jx3-minikube
error pulling
exit status 1 error
unable to create temporary file
No space left on device
fatal
failed to write object
fatal
unpack-objects failed

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository qiang123/jx3-minikube for ref
failed to switch to ref
failed to fetch repository qiang123/jx3-minikube
error fetching
exit status 128 error
unable to create temporary file
No space left on device
fatal
failed to write object
fatal
unpack-objects failed


1.6: term.color() fails as a function if terminal doesn't do styling

When in non styling mode one can use
term.color(i) + "string" + term.normal
but not
term.color(i)("string")
Thanks!
Guido

This does appear to work in blessings, are you sure?
In [10]: t=blessings.Terminal(force_styling=None)
In [11]: t.color(1)("hi")
Out[11]: 'hi'


Revamp UI for Enhanced User Experience

We aim to update the current UI design of the JobSewa website to make it more user-friendly, modern, and visually appealing. The updated design will offer a seamless experience for users and improve overall usability and navigation.
Proposed Enhancements:
Homepage Design:
Redesign the homepage for a cleaner, more modern look.
Improve typography for clarity and emphasis.
Enhance the search bar and tag suggestions for better visibility.
Navbar:
Add a sleek design to the navbar to make it more intuitive and accessible.
Update button styles (e.g., for "Login" and "Register") for a more professional appearance.
Job Posting Section:
Improve the layout for the job posting and job browsing pages, ensuring a better-organized job listing experience.
Implement cleaner, user-friendly buttons and input fields.
User Dashboard:
Optimize the dashboard interface for easier access to posted jobs, applications, and bookmarks.
Revamp the UI components like cards, lists, and buttons for consistency and better aesthetics.
Additional Suggestions:
Increase spacing and padding for better readability.
Implement animations/transitions for smoother interactions.
Expected Outcome:
A cleaner, more user-centric interface that enhances usability.
Improved navigation and layout, making it easier for users to find jobs or post job listings.
A more modern and professional look that improves user engagement and retention.
Let’s aim to make the JobSewa platform more visually appealing and intuitive for all users.

Hello, can I give it a try for this?

Hi @AqilJaafree
Go for it! Looking forward to seeing your contribution!

hey @Devmangrani I did some changes in the into page along with improving navbar and added some animations on that. As I saw this issue was open for quite long, so decided to contribute. Below is the recording of redesigned changes.
recording.webm
The lag might be of my device performance else it should work fine, what are your comments regarding this let me know and will open a PR if everything is good to go

Hey @Sushil010  I just watched your video—fantastic work and smooth animations! The updates look great, but I noticed the image on the home page was removed. This image is key in conveying the website's primary purpose, so could you adjust it back into the design? Let me know when you’re ready to open the PR. Thanks for your contributions!

@Devmangrani Thank you for your suggestion, I will work on that.

Hey @Sushil010  I went ahead and merged your PR because the updates look fantastic! However, there's a small issue—when we perform a search on the homepage, the page title is overlapping with the navbar, as you can see in the attached screenshot. This is causing a bit of an alignment issue with the navbar. Could you take a look and resolve this? Thanks again for your great work and attention to detail!

@Devmangrani sorry for that. Actually I forgot to test those components. Thanks for your suggestion will make sure to do necessary changes. Keep on suggesting and will be happy to hear any other preferences regarding the design


improve MouseButton events

Hi @ben-clayton .
This PR will resolve issue #106 .
It's a little bit different from what you answered at the issue,
but It'd be nice if you could review my code.
Best regards,
yofu

I signed it!
2015年4月21日(火) 14:37 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).
[image: :memo:] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
Reply to this email directly or view it on GitHub
https://github.com/google/gxui/pull/107#issuecomment-94644704.

Thanks a lot for sparing time for reviewing!
I fixed as below:

restore all the things associated with MouseButton
add MouseState instead

I'm not sure whether I fixed well as you mentioned...
I think InputEventHandler.isMouseDown can be gxui.MouseState like:
func (m *InputEventHandler) MouseDown(ev gxui.MouseEvent) {
	m.isMouseDown = ev.State
	m.getOnMouseDown().Fire(ev)
}
...

func (m *InputEventHandler) IsMouseDown(button gxui.MouseButton) bool {
	return m.isMouseDown.IsDown(button)
}

Could you take a look when you have time?
Regards,
yofu

Thank you for advice, and I've fixed!

LGTM. Thanks!


add create2 deploy to non-zero balance address test

\b run testool

{keccak_}code_hash_previous is free cell, unconstrained.   Not sound?  Can be fixed later.

common_gadget.rs The comment above are outdated. After line 369.

we can refactor coinbase creation too https://github.com/scroll-tech/zkevm-circuits/pull/588  i have another refactor idea:
struct TransferMayWithGasFeeGadgetInner<F> {
    sender_sub_value: UpdateBalanceGadget<F, 2, false>,
    receiver: UpdateBalanceGadget<F, 2, true>,
    receiver_exists: Expression<F>,
    must_create: Expression<F>,

move "sender_sub_value" out of this gadget, and rename it to 'TransferTo' gadget.
And create a:
 struct TransferFromGadget<const WITH_FEE: bool> {
sender_sub_fee: UpdateBalanceGadget<F, 2, false>, // if WITH_FEE == false, do nothing in construct/assign method of this gadget?
sender_sub_value: UpdateBalanceGadget<F, 2, false>,

then we can use only the new TransferTo for coinbase refund

btw i think the assignment codes for TransferXXXGadget in different opcodes is very similar too. Error prone.  It will be good if we can rewrite it like fn TransferXXXGadget::assign_from_rws(block: &Block<Fr>, step: &Step, rw_offset: &mut usize).

we can refactor coinbase creation too #588 i have another refactor idea:
struct TransferMayWithGasFeeGadgetInner<F> {
    sender_sub_value: UpdateBalanceGadget<F, 2, false>,
    receiver: UpdateBalanceGadget<F, 2, true>,
    receiver_exists: Expression<F>,
    must_create: Expression<F>,

move "sender_sub_value" out of this gadget, and rename it to 'TransferTo' gadget. And create a:
struct TransferFromGadget<const WITH_FEE: bool> {
    sender_sub_fee: UpdateBalanceGadget<F, 2, false>, // if WITH_FEE == false, do nothing in construct/assign method of this gadget?
    sender_sub_value: UpdateBalanceGadget<F, 2, false>,

then we can use only the new TransferTo for coinbase refund

what do you mean by "do nothing in construct/assign method of this gadget", the gadget is still required for construct this struct. or you want using generic like current approach replace it with an ZST?


E2E improvements

First commit removes unused e2e.upgrade-tests-enabled flag and second separates the scenarios into two groups with a new e2e.run-all-tests flag.  If it is false, only the CreateCluster scenario is run (e.g. presubmit).  If it is true, all scenarios are run (e.g. periodic).
@csrwng @ironcladlou @enxebre

I’m pretty sure we’ll find ways to break autoscaling and autorepair pretty easy without breaking createCluster. Though if we can still trigger those tests manually on demand this change seems reasonable to me.
Tangentially if we made a Make command of this https://github.com/openshift/release/blob/27ed89293fc69b7a3e6539ebbcc3d72525ab4f80/ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml#L81-L89 we can enable/disable tests to run without modifying the release repo.

/test e2e-aws

/lgtm
/hold

Wait for https://github.com/openshift/hypershift/pull/498/files

/close
Will opened new PR for flag removal


Handle dongle firmware upgrade from the library

Needs to implement the X-modem protocol inside the lib.
The whole context switching between application/bootloader should also be handled by the library, including recovery from any state, also interacting with the bootloader prompt to enter firmware upgrade or exit from bootloader.

Once the dongle is switched to firmware upgrade mode, you can use the following Linux command to upload the firmware image (on a 115200 baud EZSP dongle):
DEV=/dev/ttyUSB0
stty -F $DEV 115200
sz ~/xncp-firmware-image.gbl > $DEV < $DEV

Merged in branch master at https://github.com/Legrandgroup/libezsp/commit/7b8275e0f545aa3f67c4257d936a33d7efe60e05


V2 - Company Not Found - UI hangs at Configuring CLA Manager Settings

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group
Generate template

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Click on building icon
Click on Organization not listed? + Click Here
Enter company name and website that does not exist
Click Next
Click Proceed
Click Yes
Click Proceed
Login to SSO
UI hangs at Configuring CLA Manager Settings
NOTE: Observed the issue when user is already logged into SSO and then tried to add company

Verified that the issue is fixed


Improve Relaton dependency pinning

Description
#333 introduced Relaton dependency pinning for Relaton GHAs.
As discussed in https://github.com/ietf-tools/relaton-data-3gpp/issues/17 dependency pinning can be improved by pinning to major versions of Ruby gems, allowing minor updates and patches to be installed.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

All relaton-data-* repositories need to be updated to only override Gemfile, thus removing Gemfile.lock

https://github.com/ietf-tools/relaton-data-rfcs GHA is failing right now because of missing Gemfile.lock.

I will update the relaton-data repositories by the end of the day @kesara

All affected relaton-data-* repositories have now a PR pending approval and merge.


ansible automation breaks on multi-node chef based deployment

As a part of [#102]: Order is important with ansible/chef.  Unfortunately, terraform doesn't wait till the nodes have finished provisioning before it runs the provisioning code, so nodes are provisioned out of order.

[x] Update current "Default" config playbook to break task into two stages
[x] Create inventory from terraform state after initial terraform deployment completes
[x] Launch ansible against newly created inventory, and all hosts active

Pushed draft to rhs-fix-chef-deploy branch

Need to merge into master with new resource hierarchy.


Not constant BPM, Sensor just works when my finger press and then lift

Hello, I have a project whose aim is to measure the heart rate of a person while he is doing physical activity, but first i would like to have my sensor working with the highest precision as posible. I really need to know why my BPM is not constant. Also it seems to work when it receives a higher force like the one i mention on the title of the current issue, but that´s not the aim of my project, i really need that the user just press the sensor and receives the values of his bpm on a display, without having to be concerned of the sufficient force that is necessary for the sensor to take correct values. I´m not using the led output by the way.
Sorry for my bad english, and i hope that someone could help and have some consideration because i´m new to this :).
Here is the code:
`#include <LiquidCrystal.h>
LiquidCrystal lcd(18, 19, 5, 4, 3, 2);   // inicializa la interfaz I2C del LCD 16x2
int pulsePin = 0;                   // Sensor de Pulso conectado al puerto A0
// Estas variables son volatiles porque son usadas durante la rutina de interrupcion en la segunda Pestaña
volatile int BPM;                   // Pulsaciones por minuto
volatile int Signal;                // Entrada de datos del sensor de pulsos
volatile int IBI = 600;             // tiempo entre pulsaciones
volatile boolean Pulse = false;     // Verdadero cuando la onda de pulsos es alta, falso cuando es Baja
volatile boolean QS = false;        // Verdadero cuando el Arduino Busca un pulso del Corazon
void setup(){
Serial.begin(9600);
lcd.begin(16, 2);
Serial.begin(9600);                // Puerto serial configurado a 9600 Baudios
interruptSetup();                  // Configura la interrucion para leer el sensor de pulsos cada 2mS
}
void loop(){
int pulso = analogRead(A0);           //Lee el valor del pulsometro conectado al puerto Analogo A0
lcd.setCursor(1,0);                   //Muestra en el LCD el valor de BPM
lcd.print("BPM= ");
lcd.print(BPM);
lcd.print("   ");
//Serial.print("BPM = ");  Serial.println(BPM); //Habilitar estas linea para ver BPM en el monitor serial pero deshabilitar la siguiente
Serial.println(pulso);                          // envia el valor del pulso por el puerto serie  (desabilitarla si habilita la anterior linea)
if (QS == true){                       // Bandera del Quantified Self es verdadera cuando el Arduino busca un pulso del corazon
QS = false;                          // Reset a la bandera del Quantified Self
}
}
Here is the code for interrupt:
volatile int rate[10];                    // array to hold last ten IBI values
volatile unsigned long sampleCounter = 0;          // used to determine pulse timing
volatile unsigned long lastBeatTime = 0;           // used to find IBI
volatile int P =512;                      // used to find peak in pulse wave, seeded
volatile int T = 512;                     // used to find trough in pulse wave, seeded
volatile int thresh = 512;                // used to find instant moment of heart beat, seeded
volatile int amp = 100;                   // used to hold amplitude of pulse waveform, seeded
volatile boolean firstBeat = true;        // used to seed rate array so we startup with reasonable BPM
volatile boolean secondBeat = false;      // used to seed rate array so we startup with reasonable BPM
void interruptSetup(){
// Initializes Timer2 to throw an interrupt every 2mS.

// Timer 2 makes sure that we take a reading every 2 miliseconds
ISR(TIMER2_COMPA_vect){                         // triggered when Timer2 counts to 124
cli();                                      // disable interrupts while we do this
Signal = analogRead(pulsePin);              // read the Pulse Sensor
sampleCounter += 2;                         // keep track of the time in mS with this variable
int N = sampleCounter - lastBeatTime;       // monitor the time since the last beat to avoid noise
//  find the peak and trough of the pulse wave

if(Signal < thresh && N > (IBI/5)*3){       // avoid dichrotic noise by waiting 3/5 of last IBI
if (Signal < T){                        // T is the trough
T = Signal;                         // keep track of lowest point in pulse wave
}

}
if(Signal > thresh && Signal > P){          // thresh condition helps avoid noise
P = Signal;                             // P is the peak
}                                        // keep track of highest point in pulse wave
//  NOW IT'S TIME TO LOOK FOR THE HEART BEAT
// signal surges up in value every time there is a pulse
if (N > 250){                                   // avoid high frequency noise
if ( (Signal > thresh) && (Pulse == false) && (N > (IBI/5)*3) ){
Pulse = true;                               // set the Pulse flag when we think there is a pulse
    IBI = sampleCounter - lastBeatTime;         // measure time between beats in mS
  lastBeatTime = sampleCounter;               // keep track of time for next pulse

  if(secondBeat){                        // if this is the second beat, if secondBeat == TRUE
    secondBeat = false;                  // clear secondBeat flag
    for(int i=0; i<=9; i++){             // seed the running total to get a realisitic BPM at startup
      rate[i] = IBI;
    }
  }

  if(firstBeat){                         // if it's the first time we found a beat, if firstBeat == TRUE
    firstBeat = false;                   // clear firstBeat flag
    secondBeat = true;                   // set the second beat flag
    sei();                               // enable interrupts again
    return;                              // IBI value is unreliable so discard it
  }

  // keep a running total of the last 10 IBI values
  word runningTotal = 0;                  // clear the runningTotal variable

  for(int i=0; i<=8; i++){                // shift data in the rate array
    rate[i] = rate[i+1];                  // and drop the oldest IBI value
    runningTotal += rate[i];              // add up the 9 oldest IBI values
  }

  rate[9] = IBI;                          // add the latest IBI to the rate array
  runningTotal += rate[9];                // add the latest IBI to runningTotal
  runningTotal /= 10;                     // average the last 10 IBI values
  BPM = 60000/runningTotal;               // how many beats can fit into a minute? that's BPM!
  QS = true;                              // set Quantified Self flag
  // QS FLAG IS NOT CLEARED INSIDE THIS ISR
}

}
if (Signal < thresh && Pulse == true){   // when the values are going down, the beat is over
Pulse = false;                         // reset the Pulse flag so we can do it again
amp = P - T;                           // get amplitude of the pulse wave
thresh = amp/2 + T;                    // set thresh at 50% of the amplitude
P = thresh;                            // reset these for next time
T = thresh;

}
if (N > 2500){                           // if 2.5 seconds go by without a beat
thresh = 512;                          // set thresh default
P = 512;                               // set P default
T = 512;                               // set T default
lastBeatTime = sampleCounter;          // bring the lastBeatTime up to date
firstBeat = true;                      // set these to avoid noise
secondBeat = false;                    // when we get the heartbeat back
}
sei();                                   // enable interrupts when youre done!
}// end isr`

P.D: Values are around 200 BPM normally.

@EduardoPL This code repository is actually superseded by our PulseSensor Playground Library.
https://github.com/WorldFamousElectronics/PulseSensorPlayground
Please try to use that instead.
Also, please send a picture of the Pulse Sensor you are using and also the setup that you have.

i will modify it a little just for not having any leds, because im only interested in my bpm.
Would that affect in some way?

What happens now is that when i try your code from PulseSensor_Amped_Arduino, some errors appear, including: serialOutput() ; was not declared in this scope, and when i try to modify it for my purposes, appears instead: Interrupt.setup was not declared. So... I sent here the first code because that worked with my project, the unique thing is the precision of the pulse sensor. I hope that it wont be any annoyance, but could you please check the first one? And, if you could not help me i will appreciate the attention i received.

This code is not really supported any more. You need to use the Pulse Sensor Playground library.
I also can't help you with your code unless I can see it. Please post it or send a link to it.
 May people purchase clones, and It could be part of your problem.


Trivial typo in a source comment

Accidentally spotted a missing "e" in "sequence" (I made the same typo in a search ;-)
If I could only be as sure that "ExprSequnceContext" in the compiler source is a typo as well... ;-)

This needs to go to swift-4.2-branch, not stable. (It will be automatically merged to stable from there.)

Nevermind that. The typo is upstream in LLVM and needs to be fixed there. Can you submit the patch there?

Yeah.  Submit a revision to LLVM and cherry-pick it back here.


gen-payload: remove old tags from multi imagestream for non-stream as…

…sembly
We only need to keep 5 old imagestreamtags for stream assembly. Non-stream assemblies should contain one single tag.
For more info, see https://coreos.slack.com/archives/GDBRP5YJH/p1661329456656149

/lgtm

I was working on this same change per our discussion; but in my case I was also recording the tags that got removed, thinking we could prune them from the imagestream status (not just the spec) and maybe from the quay release repo too. But that could just be a follow-on to this.

Status is usually managed by the controller, so I don't think we can directly prune it. But I guess it may have a GC mechanism?
For quay repo tags, we are missing the permission to prune them. Maybe we can use deterministic quay tags so that a later gen-payload run will always override the former one?
The direct reason for having this PR is that promote-assembly job expects only one single tag in the imagestream, otherwise it doesn't know which tag to promote (or maybe we can introduce another mechanism to determine which tag is the latest one, but that adds unnecessary complex and is not future-proof).

/lgtm


Carousel of images with different sizes

I am trying to use the carousel of images with different image sizes. With such images, the carousel does not look good.
I am not sure how this can be achieved.
Below is the fiddle I created for a basic demo.
http://jsfiddle.net/Purus/tsvpu9cs/

I also need help with different size images

If you don't mind to fix the size of the carousel you can use:
.bgimage {
text-align:right;
color:white;
background-size:auto;
background-repeat:no-repeat;
height: 100%;
background-position: center center;
}
Its good enough for me.

O used:

css:
ul[rn-carousel] > li {
    position: relative;
    margin-left: -100%;
}
ul[rn-carousel] > li > .image-aspect-ratio {
    display: block;
    width: 100%;
    position: relative;
    height: 0;
    padding: 75% 0 0 0;
    overflow: hidden;
}

ul[rn-carousel] > li > .image-aspect-ratio img {
    position: absolute;
    display: block;
    max-width: 100%;
    max-height: 100%;
    left: 0;
    right: 0;
    top: 0;
    bottom: 0;
    margin: auto;
}
ul[rn-carousel] > li:first-child {
    margin-left: 0;
}


multiple fortran compilers with pfunit

This is ready to merge
When multiple version of the Fortran compiler exist on a system, pfunit defaults to the newest.  So if an older compiler is wanted (for running regression test baselines etc), OpenFAST and pfunit will be compiled with different versions of the Fortran compiler and will be incompatible.
To reproduce on MacOSX:

Install gfortran@7 and gfortran@9 with homebrew
in clean build directory export CC=`which gcc-7`; export CXX=`which g++-7`; export FC=`which gfortron-7`;
 cmake -DBUILD_TESTING=ON -DCTEST_PLOT_ERRORS=ON -DCMAKE_Fortran_COMPILER=`which gfortran-7` ..
 make -j6

Despite setting the environment variable and setting the CMAKE_Fortran_COMPILER directly, it fails.  Solution is to pass the compiler to pfunit with the ExternalProjectCMakeArgs argument list.

Note: I have only verified this on OSX 10.14.6


RESTful Apis Get accessToken from user object

When I perform the social login from my app, in the rest controller I create the user instance (if not exist), then i have to return the access token. In this case i don't have the password, i must create the token from the user object.
How can i do that?

I find this
public function createAccessToken($clientId, $userId, $scope = null, $includeRefreshToken = true)
   {
       $accessToken = $this->getAccessTokenResponseType();
       return $accessToken->createAccessToken($clientId, $userId, $scope, $includeRefreshToken);
   }

in Server.php.
But how to use it?

have you read instructions in readme? If yes what's your problem?

Read and read again.
I solved my problem in that way:


libcjson.so: cannot open shared object file: No such file or directory

Need generate libcjson.so manually after luarocks install?
/usr/local/share/lua/5.1/resty/libcjson.lua:55: libcjson.so: cannot open shared object file: No such file or directory

Yes, this library doesn't build the dependency, even from LuaRocks.


Add CentOS Stream 8 Ceph Nautilus and OpsTools repos

Currently we only have the CentOS Linux 8 Ceph Nautilus and OpsTools repos, which
stopped providing updates in January.

Any thoughts?


Redesign the layout of the Privacy Page to match the new design of about and contact page

https://waterthetrees.com/privacy
Redesign the privacy page to match the new design of the about and contact us page. Make the design responsive for mobile.
See issue #270

It looks like the no scrolling issue exists on this page as well. I can fix the issue and redesign this page

I really apologize, I got extremely busy and cannot tackle this.

Hi, i'd like to give this a shot. Should I post screenshots and questions about progress in this thread?

@cisnejo can you still work on this?

Hey there! Is this still open? I would love to work on it. Also, I am new to GitHub Issues - where may I locate the Figma link?

@keshao728 looks like @Domingo-creator is assigned. @Domingo-creator how is progress on this issue? If you want you could hand it off to @keshao728
@keshao728 figma links are generally attached to tickets, but if not they are linked on Slack in the channel description.

I started this but I ran into the issue of not having some of the images and fonts.  I did not see a figma file.

Hello Randy,
Thank you for this guide! I was able to locate the sections in Figma, but I
am unsure where to download the images and assets. Would you kindly direct
me to the appropriate location?
I look forward to hearing from you!
Best,
Kelly Shao
On Wed, Feb 1, 2023 at 12:24 PM Randy Rios @.***> wrote:

@Domingo-creator https://github.com/Domingo-creator there isn't any
images for this page. @vernfongchao https://github.com/vernfongchao i
believe setup the correct font style for other pages.
The figma link is attached to this ticket. see image below.
to find the figma design go to "Desktop (Current)" on the top left column.
Then you will see a number of designs. Its closer to the middle of the
designs. Attaching image below.
[image: link to figma]
https://user-images.githubusercontent.com/98299952/216155339-dcace486-ff23-452f-aa77-33e39033648c.PNG
[image: figma]
https://user-images.githubusercontent.com/98299952/216155341-e25c8bc5-8559-4716-879e-721aa03e4d77.PNG
—
Reply to this email directly, view it on GitHub
https://github.com/waterthetrees/wtt_front/issues/317#issuecomment-1412677196,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX6P7KR3AJSS3QX47OEMSNDWVLBBVANCNFSM6AAAAAARGRIFKA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@keshao728 someone is assigned to this ticket, so you would have to pick something else unless its given up.
But regarding your question, for the assests and images, that maybe a onboarding issue. Ask the slack channel your specific question since I am not familiar with local setup if thats the issue.

Got it haha my bad! Thank you for clarifying, I did have the question for
assets for some other tickets as well so that's perfect. I'll reach out
when I begin working. Thanks again!
On Wed, Feb 1, 2023 at 8:28 PM Randy Rios @.***> wrote:

@keshao728 https://github.com/keshao728 someone is assigned to this
ticket, so you would have to pick something else unless its given up.
But regarding your question, for the assests and images, that maybe a
onboarding issue. Ask the slack channel your specific question since I am
not familiar with local setup if thats the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/waterthetrees/wtt_front/issues/317#issuecomment-1413135830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX6P7KWYGIFLDQFR4EWGBU3WVMZV5ANCNFSM6AAAAAARGRIFKA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Domingo-creator did you find the design on figma?

updated the layout of the privacy page to have the new nav bar and footer.
To find the design, go to figma, go to static pages section on the top left corner and scroll down till you see the privacy page section.


Remove CompilerGeneratedAttribute from generated .NET Standard assembly

This is an implementation detail that we don't need to leak into the .NET Standard assembly

Is there a reason this was closed without merging?


versioning cache/last compiled

Hi, I've upgraded to 5.4 and getting used to webpack/mix. I'm enjoying but there's one feature that i miss on elixir. When versioning, elixir kept on the manifest the last 3/4 files compiled and now it wipes everything and so i'm not able to compile just one file.
it's a big project and i don't like to compile all files every time i make a small change.
Thanks

If the file hasn't changed, it won't create a new entry in the manifest file.
But, yeah, the manifest will reflect the current state of the last time you ran Webpack. It doesn't retain anything before that.

That doesn't happen to CSS files, they are generating new entry every time.
I'm sorry that i don't understand much about the webpack configuration but there's a Webpack Manifest Plugin that has this option:
cache: In multi-compiler mode webpack will overwrite the manifest on each compilation. Passing a shared {} as the cache option into each compilation's ManifestPlugin will combine the manifest between compilations.
Isn't this possible to implement?


Thumbs up songs not found by get_all_songs() if they aren't in music library

I looked at the methods for getting thumbs up playlist songs suggested in #200 and #99 but both rely on finding songs with get_all_songs - which only finds songs in the music library.
Obviously the mobile client can compute which songs have a thumbs up somehow - even if the songs aren't in the music library - is there a way to replicate this functionality with the api?

Yup, that's correct.

oh well - guess it can't be helped then

Thanks - this is quite helpful for working through my authentication issues


Liberation of Skyrim - Two Simultaneous Objectives

So I currently have active objectives to liberate both The Reach and Falkreath Hold. I did two small quests for the Reach camp, so the Markarth siege is ready to go. The objective to liberate Falkreath points me to the Stormcloak camp there, but they don't give me any quests. I feel like it should only be giving me one hold at a time.

Is markarth liberated?

then this is part of the concurrent regain holds bug

Sometimes when certain objectives are hit you’ll get the next regain or liberate mission

Not sure if it is still open or not

Alright, we can just leave this then. I got the little battle at Soljund's Sinkhole and then Compelling Tribute for Markarth. Was probably one of those.

Definitely one of them if I had to guess it was compelling tribute however it could also have been triggered by skirmish as that has happened to me with stonehills in morthal I’d get a regain mission afterwards

#18

Issue still persists, I get them from time to time as well

So I currently have active objectives to liberate both The Reach and Falkreath Hold. I did two small quests for the Reach camp, so the Markarth siege is ready to go. The objective to liberate Falkreath points me to the Stormcloak camp there, but they don't give me any quests. I feel like it should only be giving me one hold at a time.

Can you potentially give a sequence of events? kmyquest.CWs.CompleteCWObj(Alias_Hold.GetLocation()) is supposed to be called for both major and minor capital cities. So the Falkreath objective should have been completed.
Can I see a screenshot of your Liberation of Skyrim quest?

https://github.com/schofida/CWORR/issues/18 related to this bug

Not quite. The objectives getting bunched up is not related to this. (I think you also showed me another example of Fort Sieges getting bunched up. I will take a look at that) For this, it sounds like the 'Liberate Falkreath' was not marked as complete.

I don't recall precisely what triggered it, but everything that was supposed to be marked as completed did get marked as completed. It just started a second region before the first was finished. Screenshot would just show the two regions next to each other. Nothing failed or repeated.


Syntax highlighting of Safe-DS code in documentation

Is your feature request related to a problem? Please describe
Safe-DS code is not highlighted in the documentation.
Desired solution
Create a Pygments lexer.

:tada: This issue has been resolved in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Negative padding for functional_tensor symmetric

Along with #2744 this will make negative padding
uniform between PIL and Tensor #2381
The natural test would be not excluding "symmetric" here but that relies on the changes in #2744 so I haven't included it here yet.

@jamt9000 thanks for the PR. I merged your previous PR, can you please update this one and add missing tests and fix currently failing one. Thanks !

Thanks a lot @jamt9000 for the PRs and @vfdev-5 for the reviews!


chore: update angular2 to 2.0.0-beta.16

I had to remove modal bits as due to changes in DCL we need a new thinking / design; this will take few days and we might need to wait for a new DCL (next release?)

This update also revealed bugs in the core that we can work-arround but should track and remove work-arrounds at some point:

https://github.com/angular/angular/issues/8242


ci/cd: add codeowners file to set up auto assignment for frontend PR …

Added a CODEOWNERS file to assign the frontend team in the IO repo to be the owner of the frontend repository. This should allow the auto assignment for PR to work.
Reference docs:
https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-code-review-settings
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Summary by CodeRabbit

Chores

Implemented a system for automatically assigning the front end team as the repository owners on GitHub for better management and workflow efficiency.

Just a minor comment, in conventional commits I don't see a ci/cd tag but there is a ci one


Bad actors can not send a handshake event to cause errors on the server

When calling Remote.SendToAllPlayers on an EncryptedNet remote, it doesn't check if players have indexes in PlayerData before calling SendToPlayer. This can cause errors if a player isnt initialized (or if a bad actor prevents the Handshake event from sending to cause an error). If one player fails, it wont send to any other players in the loop. An if statement should be added to check if they're initialized, and if not, retry the event in a second.

The flaw is in SendToPlayer itself, but it's a bigger issue in SendToAllPlayers since it effects the rest of the players. Bad actors can prevent data from getting to anyone by just joining the server first and not sending the handshake remote

This is fixed in v1.0.4, thanks for reporting it!


fix(projects): update option text on how often page

:tada: This PR is included in version 2.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SSLConnectFailed

-------------------------------------------------------------------------------------------------------------------------------------------------------------------
|   timestamp   |                                                                     message                                                                     |
|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------|
|<PHONE_NUMBER>770 | 2020-12-27 05:25:02,770 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc052 2 ...                           |
|<PHONE_NUMBER>770 | 2020-12-27 05:25:02,770 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>800 | 2020-12-27 05:25:02,799 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>806 | 2020-12-27 05:25:02,806 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>806 | 2020-12-27 05:25:02,806 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>808 | 2020-12-27 05:25:02,808 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>808 | 2020-12-27 05:25:02,808 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>008 | 2020-12-27 05:25:03,008 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc052 3 ...                           |
|<PHONE_NUMBER>009 | 2020-12-27 05:25:03,008 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>080 | 2020-12-27 05:25:03,080 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>089 | 2020-12-27 05:25:03,089 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>089 | 2020-12-27 05:25:03,089 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>091 | 2020-12-27 05:25:03,091 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>091 | 2020-12-27 05:25:03,091 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Finished arc052                                      |
|<PHONE_NUMBER>091 | 2020-12-27 05:25:03,091 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Starting arc059 ...                                  |
|<PHONE_NUMBER>091 | 2020-12-27 05:25:03,091 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc059 1 ...                           |
|<PHONE_NUMBER>091 | 2020-12-27 05:25:03,091 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>165 | 2020-12-27 05:25:03,162 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>187 | 2020-12-27 05:25:03,187 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>187 | 2020-12-27 05:25:03,187 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>189 | 2020-12-27 05:25:03,189 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>189 | 2020-12-27 05:25:03,189 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>389 | 2020-12-27 05:25:03,389 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc059 2 ...                           |
|<PHONE_NUMBER>396 | 2020-12-27 05:25:03,395 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>571 | 2020-12-27 05:25:03,570 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>608 | 2020-12-27 05:25:03,608 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>608 | 2020-12-27 05:25:03,608 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>611 | 2020-12-27 05:25:03,611 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>611 | 2020-12-27 05:25:03,611 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>811 | 2020-12-27 05:25:03,811 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc059 3 ...                           |
|<PHONE_NUMBER>814 | 2020-12-27 05:25:03,814 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>883 | 2020-12-27 05:25:03,881 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>896 | 2020-12-27 05:25:03,896 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>896 | 2020-12-27 05:25:03,896 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>898 | 2020-12-27 05:25:03,898 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>898 | 2020-12-27 05:25:03,898 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Finished arc059                                      |
|<PHONE_NUMBER>898 | 2020-12-27 05:25:03,898 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Starting arc060 ...                                  |
|<PHONE_NUMBER>899 | 2020-12-27 05:25:03,898 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc060 1 ...                           |
|<PHONE_NUMBER>903 | 2020-12-27 05:25:03,903 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>023 | 2020-12-27 05:25:04,021 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>037 | 2020-12-27 05:25:04,037 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>037 | 2020-12-27 05:25:04,037 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>038 | 2020-12-27 05:25:04,038 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>038 | 2020-12-27 05:25:04,038 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>239 | 2020-12-27 05:25:04,238 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc060 2 ...                           |
|<PHONE_NUMBER>243 | 2020-12-27 05:25:04,241 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>280 | 2020-12-27 05:25:04,279 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>290 | 2020-12-27 05:25:04,290 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>290 | 2020-12-27 05:25:04,290 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>292 | 2020-12-27 05:25:04,292 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>292 | 2020-12-27 05:25:04,292 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>495 | 2020-12-27 05:25:04,492 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc060 3 ...                           |
|<PHONE_NUMBER>495 | 2020-12-27 05:25:04,492 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>536 | 2020-12-27 05:25:04,536 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>564 | 2020-12-27 05:25:04,564 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>564 | 2020-12-27 05:25:04,564 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>566 | 2020-12-27 05:25:04,566 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>566 | 2020-12-27 05:25:04,566 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Finished arc060                                      |
|<PHONE_NUMBER>566 | 2020-12-27 05:25:04,566 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Starting arc062 ...                                  |
|<PHONE_NUMBER>566 | 2020-12-27 05:25:04,566 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc062 1 ...                           |
|<PHONE_NUMBER>566 | 2020-12-27 05:25:04,566 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>596 | 2020-12-27 05:25:04,595 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>666 | 2020-12-27 05:25:04,665 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>666 | 2020-12-27 05:25:04,665 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>667 | 2020-12-27 05:25:04,667 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>667 | 2020-12-27 05:25:04,667 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>867 | 2020-12-27 05:25:04,867 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc062 2 ...                           |
|<PHONE_NUMBER>879 | 2020-12-27 05:25:04,879 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>985 | 2020-12-27 05:25:04,985 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>006 | 2020-12-27 05:25:05,005 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>006 | 2020-12-27 05:25:05,005 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>007 | 2020-12-27 05:25:05,007 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>007 | 2020-12-27 05:25:05,007 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>215 | 2020-12-27 05:25:05,209 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc062 3 ...                           |
|<PHONE_NUMBER>238 | 2020-12-27 05:25:05,237 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>404 | 2020-12-27 05:25:05,379 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>834 | 2020-12-27 05:25:39,675 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>083 | 2020-12-27 05:25:39,787 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>623 | 2020-12-27 05:32:27,079 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>183 | 2020-12-27 05:32:27,369 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>004 | 2020-12-27 05:32:28,621 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>175 | 2020-12-27 05:32:28,842 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>648 | 2020-12-27 05:32:29,325 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc067 2 ...                           |
|<PHONE_NUMBER>327 | 2020-12-27 05:32:30,396 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>697 | 2020-12-27 05:37:28,647 WARN  [isahc::handler] request completed with error [id=AtomicCell { value: 0 }]: SSLConnectFailed(None): unknown error |
|<PHONE_NUMBER>521 | 2020-12-27 05:37:52,863 ERROR [atcoder_problems_backend::crawler] Error when fetching arc067 2: Http(SSLConnectFailed(None))                    |
|<PHONE_NUMBER>617 | 2020-12-27 05:37:57,484 INFO  [atcoder_problems_backend::crawler] Sleeping 1sec before retry ...                                                |
|<PHONE_NUMBER>887 | 2020-12-27 05:40:15,672 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>590 | 2020-12-27 05:41:57,377 WARN  [isahc::handler] request completed with error [id=AtomicCell { value: 0 }]: SSLConnectFailed(None): unknown error |
|<PHONE_NUMBER>149 | 2020-12-27 05:42:06,039 ERROR [atcoder_problems_backend::crawler] Error when fetching arc067 2: Http(SSLConnectFailed(None))                    |
|<PHONE_NUMBER>364 | 2020-12-27 05:42:06,448 INFO  [atcoder_problems_backend::crawler] Sleeping 1sec before retry ...                                                |
|<PHONE_NUMBER>804 | 2020-12-27 05:42:08,737 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>329 | 2020-12-27 05:42:31,843 INFO  [surf::middleware::logger::native] request completed                                                              |
|<PHONE_NUMBER>201 | 2020-12-27 05:42:38,044 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] 20 submissions are already stored.                   |
|<PHONE_NUMBER>322 | 2020-12-27 05:42:38,113 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updating submissions ...                             |
|<PHONE_NUMBER>786 | 2020-12-27 05:42:38,533 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Updated                                              |
|<PHONE_NUMBER>840 | 2020-12-27 05:42:38,681 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Sleeping for 200ms                                   |
|<PHONE_NUMBER>183 | 2020-12-27 05:42:39,019 INFO  [atcoder_problems_backend::crawler::virtual_contest_crawler] Fetching from arc067 3 ...                           |
|<PHONE_NUMBER>688 | 2020-12-27 05:42:39,438 INFO  [surf::middleware::logger::native] sending request                                                                |
|<PHONE_NUMBER>686 | 2020-12-27 05:42:49,439 INFO  [surf::middleware::logger::native] request completed                                                              |
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

最近見ないな


Added vars and defaults to directories to check

Test setup
testRole/tasks/main.yml
---

- name: Print variable
  debug: var=myVar

...

testRole/vars/main.yml
---

# Below line has some trailing whitespaces
myVar: myString

...

Current Behaviour
ansible-lint testRole

Returns OK
Behaviour after change
ansible-lint testRole
[ANSIBLE0002] Trailing whitespace
/home/msuringa/test/vars/main.yml:3
myVar: myString

This is likely to cause too many false positives.
ansible-review does a much better job of applying specific rules to specific types of files.


Top offers component

We would need component which would show NFTs with most offers.
Table columns should be sortable and be like

Collection, Item, Total number of offers, Total amount of offers, Date of newest/last offer
By default, sorted by the total amount of offers

For example this NFT,
https://beta.kodadot.xyz/bsx/gallery/1380208565-1
the single row would look like

| Spodee | Spoodee | 3 | 345 567 BSX | 1 day |
It can look like current offers at https://beta.kodadot.xyz/bsx/stats

route could be /topoffers
put links to /topoffers into dropdown from Stats in navbar

So I think this issue needs to add a resolver in repo kodadot/snek right?

I would like to use this query to filter nfts which has no offer:
query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

How do you think?

I would like to use this query to filter nfts which has no offer:
query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

How do you think?

This query will be greedy without limit

I would like to use this query to filter nfts which has no offer:
query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

How do you think?

This query will be greedy without limit

So it is need to write a resolver right?

Any progress on this @zhengow 👀

This query will be greedy without limit

yup I would close this without limit :) kodadot/rubick#109

kodadot/snek#45
Waiting for review.


Update Moya and ObjectMapper dependencies to latest versions (11.0 and 3.1)

Please have this updated

@dimacheverda Update ObjectMapper dependency version to 3.2.0, it has the Swift 4.1 Float bug fixed


Remove manosim.gitify 4.6.1 to Gitify.Gitify 4.6.1

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/gitify-app/gitify/releases/download/v4.6.1/Gitify-Setup-4.6.1.exe
OK
(Automated message - build 907)

https://github.com/microsoft/winget-pkgs/pull/157091#issue-comment-box


 commands not working?

Hi! I love this plugin!
I just can't seem to get my  commands to work... For example:
f = {'<Plug>(esearch)', 'Search in project'}

Am I putting them in wrong?

Right, I remember vaguely that I ignored those mappings 🤔
Will check!

It does work, but you need noremap=false for this one. So, it should be:
f = {'<Plug>(esearch)', 'Search in project', noremap = false}

🤔 That seems to error out...
Error detected while processing VimEnter Autocommands for "*":
E5108: Error executing lua .../pack/packer/start/which-key.nvim/lua/which-key/keys.lua:152: Invalid key mapping: { "<Plug>(esearch)<cr>", "Search in project", {
    noremap = false
  } }

normap = false should not be between {}
Either way, I just pushed a change where <plug> mappings always get noremap=false automatically.
So the update should make your code just work

🤦 The error broke my save alias so I didn't save it 😅
Thank you so much!!


Develop no longer works

Developing with local engine no longer results in model-viewer rebuild when engine changes.
Presumably broken in #298.

Actually package.json is just unexpectedly forcing debug build. I'll remove that in a future PR.


#160 fixed missing SharedEventManager with zend-eventmanager 3

Fix for #160.
We inject the EventManager in Hal factory, before the EventManagerAwareInitializer.
In this way, the EventManagerAwareInitializer will not override the event manager and will be possibile to attach listeners in delegator factories.

Thanks, @thomasvargiu!


Add --retries to playwright flow-tests

playwright has been setup with 3 retries, do you think we should bring that down to 2?
https://github.com/KittyCAD/modeling-app/blob/main/playwright.config.ts#L19

@Irev-Dev oh shoot, I thought it had zero as default 🤦 However it feels like I'm beating the odds here, no?

@Irev-Dev shoot, this one just failed https://github.com/KittyCAD/modeling-app/pull/1476/commits/b193c7318894eff7106c50ac78fed82a9f54ccec 🤦 🤦

However it feels like I'm beating the odds here, no?

🤷 I find playwright to be pretty reliable these days. One of the biggest culprits was this auto complete test that I've been able to make more robust, since then I've been happy.

@Irev-Dev Alright thanks for the input. Closing!


Update issues.md

Adding some data to the table as an example.
Issue #10

lgtm 👍🏻

please ping me if you have any more issues to work on in the future, i'd love to collaborate! :)

lgtm 👍🏻

please ping me if you have any more issues to work on in the future, i'd love to collaborate! :)

Likewise, drop your twitter! Let's connect


[5.5] Bail when array is provided as key in Session::flash

When someone (accidentally) provides an array as key using Session::flash(), the app breaks for users visiting the page until they have cleared their browser cache. It can be hard to identify the problem when there's no exception thrown.
This is my first PR and I don't know if it qualifies, but I thought I'd give it a shot. Feedback is much appreciated.

Hey. It will be nice if next time you spot a bug you create an issue first so that people can test it out and confirm whether it is a bug or not. It is fine for this one :+1:

Of course, makes sense.

Changed it to just use a string type hint.


Adapt to embedded-hal-1.0.0-alpha.7

For the iterator methods I just collected the results. I have not looked into really using an iterating interface but merging this would be a first step and if there is interest we can look into that later on.
Fixes #76

r? @posborne
(rust-highfive has picked a reviewer for you, use r? to override)

bors r+


Add a provider for hyperclick

This adds a provider for hyperclick similar to the find-definition method.
Excludes some words based on the editors scope choice (e.g. let language-rust
do the hard work).
To use this, install hyperclick (apm install hyperclick) and hold ctrl while hovering over a function. It should get an underline and a left click will go to the definition

This seems like a great feature.  Any chance of some discussion?


prevent user from asking another question before the full answer is delivered

If I switch authors I am able to submit a question before the answer from a previous question is complete. Even if the submit button is disabled (which it isn't), we have the default questions on the homepage that can be used to trigger simultaneous answers.

closed by #33


HexagonLayer hexagons' z-indexes are wrong / reversed after swapping out React for Inferno

I wouldn't normally expect a library to 'just work' after replacing something as fundamental as React, but the bug I hit actually seems orthogonal to the virtual DOM tool chosen.
Repro Steps

Install all required packages for deck.gl with react-mapbox-gl
Add inferno and its respective dependencies, and alias them to use inferno-compat via webpack
Render!

Observed

Expected

Here's the code that creates the layer:
new HexagonLayer({
                id: 'data-layer',
                data,
                radius: 200,
                extruded: true,
                elevationRange: [0, 1000],
                opacity: 0.8,
                elevationScale: 4,
                coverage: 1,
            })

I did notice something odd, which was that extruded had to be explicitly set despite the docs claiming it defaults to true for this layer type. I wonder if there's a difference in how default props are assessed?

@TedDriggs - another thing that has failed is enabling of depth testing (z buffer). Either you might not have copied that code from the original example, or Inferno fails to call onWebGLInitialized.
Hard to say for sure, but does indeed appear like React property values fail to be set. Most of deck.gl's React integration is in the linked source file so putting some breakpoints in there should help narrow it down.
If you are willing to open a PR with your example (maybe in examples/integrations/inferno we might be able to take a quick look as well.

@ibgreen Throwing a breakpoint in there, I'm seeing that props.onWebGLInitialized exists and has its default value of noop. Looking at the example, I can't find anywhere that's passing any function to that, but it's definitely possible I'm missing something.

@TedDriggs Most of our examples will have some code like this:
  _initialize(gl) {
    gl.enable(gl.DEPTH_TEST);
    gl.depthFunc(gl.LEQUAL);
  }

  render() {
    return <DeckGL {...viewport} layers={layers} onWebGLInitialized={this._initialize} />;
  }

I'm experiencing a similar problem, almost like the rendering uses elevation to decide which hexes to draw on top instead of distance from viewer:

@TedDriggs @colinsheppard Please check the following two lines
https://github.com/uber/deck.gl/blob/4.1-release/examples/3d-heatmap/deckgl-overlay.js#L100
https://github.com/uber/deck.gl/blob/4.1-release/examples/3d-heatmap/deckgl-overlay.js#L131

That's it, thanks @ibgreen!


new basiconic sensilla  (ab11 and ab12)and associated ORNs (ab11a-c and ab12a-c) ? [sf#22]

Reported by gm119 on 2013-11-19 17:22 UTC
FBrf0211878 == Kwon et al., 2010, Curr. Biol. 20(18): 1672--1678
"Drosophila TRPA1 Channel Is Required to Avoid the Naturally Occurring Insect Repellent Citronellal."
may have new olfactory sensilla and associated ORNs to add to the anatomy ontology.
They talk about two 'previously uncharacterized basiconic sensilla, ab11 and ab12' in the antenna and also the neurons 'ab11a-c and ab12a-c' which innervate them.
I have made two edit records - gm34762.edit and gm34763.edit which contain the specific terms I'd like to add to my curation of the paper and its supplement, respectively.
The terms in those records are:
adult olfactory receptor neuron ab11??new term??
adult olfactory receptor neuron ab11a??new term??
antennal basiconic sensillum ab12??new term??

Commented by mmc46 on 2013-11-22 18:00 UTC
Hi Gillian,
I've added
antennal basiconic sensillum ab11
antennal basiconic sensillum ab12
and the olfactory neurons (3 in each sensillum)
adult olfactory receptor neuron ab11a
adult olfactory receptor neuron ab11b
adult olfactory receptor neuron ab11c
adult olfactory receptor neuron ab12a
adult olfactory receptor neuron ab12b
adult olfactory receptor neuron ab12c

Updated by mmc46 on 2013-11-22 18:12 UTC

status: open --> closed
assigned_to: Marta Costa


Configuring hound + rubocop and addressing initial violations

40 files inspected, 359 offenses detected

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Reduce lock concontion in ManifestCache

High Level Overview of Change
This commit combines the apply_mutex and read_mutex into a single mutex_ var. This new mutex_ var is a shared_mutex, and most operations only need to lock it with a shared_lock. The only exception is applyMutex, which may need a unique_lock.
One consequence of removing the apply_mutex is more than one applyMutex function can run at the same time. To help reduce lock contention that a unique_lock would cause, checks that only require reading data are run a shared_lock (call these the "prewriteChecks"), then the lock is released, then a unique_lock is acquired. Since a currently running applyManifest may write data between the time a shared_lock is released and the write_lock is acquired, the "prewriteChecks" need to be rerun. Duplicating this work isn't ideal, but the "prewirteChecks" are relatively inexpensive.
A couple of other designs were considered. We could restrict more than one applyMutex function from running concurrently - either with a applyMutex or my setting the max number of manifest jobs on the job queue to one. The biggest issue with this is if any other function ever adds a write lock for any reason, applyManifest would not be broken - data could be written between the release of the shared_lock and the acquisition of the unique_lock. Note: it is tempting to solve this problem by not releasing the shared_mutex and simply upgrading the lock. In the presence of concurrently running applyManifest functions, this will deadlock (both function need to wait for the other to release their read locks before they can acquire a write lock).
Context of Change
The read_mutex_ in the manifest cache was identified as a major source of lock contention. This commit attempts to reduce that lock contention.
Type of Change
Optimization

As a side note, Facebook's folly library has a mutex that has a solution for the deadlock problem for upgradable mutexes (ref: https://github.com/facebook/folly/blob/main/folly/docs/Synchronized.md search for "upgrade mutex"). Notice that unlike boost's upgrade mutex (ref: https://www.boost.org/doc/libs/1_77_0/doc/html/thread/synchronization.html#thread.synchronization.mutex_concepts.upgrade_lockable) In particular:
An upgrade lock may be held concurrently with any number of shared locks on the same mutex. An upgrade lock is exclusive with other upgrade locks and unique locks on the same mutex - only one upgrade lock or unique lock may be held at a time.

This would be similar to using a boost's upgrade mutex with a apply_mutex that limits running just one applyMutex at a time. But it isn't as fragile to future code changes that would cause deadlocks.

Fwiw, I tried for years to get upgrade_mutex standardized:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2406.html#upgrade_mutex_rationale
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3427.html
The committee just wasn't having it.

This was merged into 1.9.0


Fixed subscribe text blocking close button

This PR fixes #630.
Tested on latest 3.1.0 Ghost Release with Casper 3.0.4.
Fix: Use z-index to vertically place close button on top of text.

Hey @casperbh96,
Thank you for your fix. Quite a few changes happened to Casper since you've opened the PR so I added the solution to this commit which solves multiple overlay issues:  https://github.com/TryGhost/Casper/commit/9e29e145fccb0dbd859d0fb1a6a1e1be9f7977ac
Cheers,
Zimo


[EUWE] Brakeman showtype fixes

Brakeman started to complain about these. This should make the CI green again.
This is already fixed on master as part of refactoring work.
@mzazrivec, @h-kataria, @himdel : please, review, test.
ping @simaishi

LGTM

@dajohnso let me know if you'd need a BZ.  This was to fix Travis failure, but it did modify the production code.


Update slack badge

Fixes #292

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger


Why upgrades-core doesn't include Proxy contracts source code?

https://github.com/OpenZeppelin/openzeppelin-upgrades/blob/master/packages/core/package.json#L7
Now, I can't do something like:
npm i @openzeppelin/upgrades-core --save

import<EMAIL_ADDRESS>

Hi @rstormsf ,
Proxy contracts have been moved to OpenZeppelin Contracts since v3.2
https://forum.openzeppelin.com/t/openzeppelin-contracts-3-2-release-candidate/3718

got it. thx!

Closing this issue as resolved.

Yes, this package will probably soon be changed to use the contracts directly from OpenZeppelin Contracts too.
@rstormsf I would love to know what kind of setup you have and in what way you plan to use the proxy contracts. Are you planning to use the Buidler or Truffle plugins too?


autocomplete feature [enhancement]

Js version of Inquirer had autocompletion type, it would be awesome if we had it on PyInquirer too

Cool

PyInquirer passes arguments to prompt-toolkit so you can already to this.
For example with an input type the following code
questions = [     {         'type': 'input',         'name': 'things',         'message': 'Enter a thing',         'completer': MyCompleter()     } ] answers = PyInquirer.prompt(questions)
will give you autocomplete for that field. See the documentation here for creating a custom completer which suits your needs. prompt-toolkit is one of the PyInquirer dependencies so you will already have it.

thanks!

Would you please be so kind and show me a working example for type = list? I can't make it.
I'd love to have classic PyInquirer list with UP/DOWN moving caret. When I start typing, some of the options pops out.


Add warnings to duplicate export annotation.

Closes #2870

🤔 This is odd. JSExportTest.noExportImplicitApply fail on Scala 2.10 & 2.11, but pass on 2.12 & 2.13.
https://scala-webapps.epfl.ch/sjsjenkins/blue/organizations/jenkins/scalajs-main/detail/PR-3633/1/pipeline#step-178-log-162
https://scala-webapps.epfl.ch/sjsjenkins/blue/organizations/jenkins/scalajs-main/detail/PR-3633/1/pipeline#step-362-log-110

This often happens with compiler tests. Error messages can be quite fickle. Have you tested it locally with 2.10 or 2.11, in the hello world, to see the reported warnings?

This often happens with compiler tests. Error messages can be quite fickle. Have you tested it locally with 2.10 or 2.11, in the hello world, to see the reported warnings?

Yes, I can see the reported warnings like this
[warn] /home/vagrant/IdeaProjects/scala-js/examples/helloworld/HelloWorld.scala:73: Found useless @JSExport, since owner already has @JSExportTopLevel. Consider @JSExport with explicit name
[warn]   def a = 1
[warn]       ^
[warn] /home/vagrant/IdeaProjects/scala-js/examples/helloworld/HelloWorld.scala:78: Found duplicate @JSExport
[warn]   def b = 1
[warn]       ^

after adding some warning classes to HelloWorld.scala and running command on sbt like below
set scalaVersion := "2.10.7"
helloworld/fastOptJS
set scalaVersion := "2.11.12"
helloworld/fastOptJS

set scalaVersion := "2.10.7" doesn't do anything. It only changes the Scala version of the root project, which is unused.
You need to use ++2.10.7 instead.

You need to use ++2.10.7 instead.

The warnings are reported both on ++2.10.7 and ++2.11.12.

CI is green and ready to review


winget upgrade fails to list correct version and reinstalls even if latest version is installed

Brief description of your issue
Incorrect version of the product is reported on winget upgrade CLI and winget upgrade --id Amazon.WorkspacesClient reinstalls the latest version.
I see the right version in Apps:

Example:
Amazon WorkSpaces                                                  Amazon.WorkspacesClient                  > 3.1.10         <IP_ADDRESS>17       winget
Steps to reproduce

Install older version from https://d2td7dqidlhjx7.cloudfront.net/prod/global/windows/Amazon+WorkSpaces.msi
Run winget upgrade to lilst the packages, it'll show the incorrect version
Run winget upgrade --id Amazon.WorkspacesClient

Expected behavior
It should not reinstall version 5.6.2.
Actual behavior
It reinstalls the latest version.
Environment
winget --info
Windows Package Manager v1.3.2691
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.1455
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2691.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Users are not facing this issue anymore, thank you for the quick response, I really appreciate it.

Still happening to me

What is displayed in Windows Apps & Features?

This is again the same case where the newer version is missing ARP Entries. I've opened a PR to resolve this issue.

It's working now, let's hope it doesn't break in the next update.


Convert 'Serialization of anonymous classes' wiki page to jenkins.io

Migrate Serialization of anonymous classes
Links

https://github.com/jenkins-infra/jenkins.io/issues/3214
jenkins-infra/jenkins.io#3378
jenkins-infra/jenkins-infra#1495

Screenshots
See the above-mentioned PRs.

Thanks for your contribution! Let's keep reviewing it in the pull requests


fix: #684 - writing in white when in dark mode for score card

My assumption is that in dark mode we cannot really play with subtleties around colors, and writing in white on dark backgrounds should be at least the first choice, if not the only one.
Impacted file:

score_card.dart

Night mode (did change):

Day mode (did not change):

LGTM.
Comment: Google is trying to do that Flutter-wide with Material You, but it's not a priority on our side for the first version.
Dark/Light, 3 foreground colors, 3 background colors, 2^3^3 possibilities
cc @greentoff @jasmeet0817


Resolves 'Build failed - Dependencies #17'

 Issue by IceNerd
Wednesday Jul 04, 2018 at 19:56 GMT
Originally opened as https://github.com/googlesamples/android-WatchFace/pull/18

Didn't review the contributing guidlines, I just fixed the thing. Pull the project and build. I was unable to track a file to add to the repo that would persist the Android Studio setting so here is another note about it!
To deploy the Application or Wearable, update the run configurations -> General -> Launch Options -> Launch: Nothing

IceNerd included the following code: https://github.com/googlesamples/android-WatchFace/pull/18/commits

 Comment by googlebot
Wednesday Jul 04, 2018 at 19:56 GMT

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

 Comment by IceNerd
Wednesday Jul 04, 2018 at 19:59 GMT

I signed it!

 Comment by googlebot
Wednesday Jul 04, 2018 at 19:59 GMT

CLAs look good, thanks!

Hi IceNerd, it looks like that PR isn't valid now, but that's a good suggestion.
I added the edits to the README in this PR. Thanks!


docs: add missing links to loaders

What is a change?
Currently, loaders are discoverable by hyperlinks on the loaders page, but there are some loaders which do not have a hyperlinks.
This PR adds hyperlinks for rest of the loaders.
Guidance is needed for the followings:

[x] traceur-loader - I found 2 packages. traceur-loader and webpack-traceur-loader

@montogeek can you review this?

I would choose https://github.com/jupl/traceur-loader over https://github.com/ndhoule/webpack-traceur-loader because of its name, but it is fine to link both.
cc @EugeneHlushko

Thanks!


[Supernova Solrock] Z plane fighting on the model

Describe the bug
There's some z plane fighting that occurs with the new Solrock/Lunatone models that really detracts from the look of it.
To Reproduce
Steps to reproduce the behavior:

Observe the z plane fighting in-game on a Supernova Solrock/Tidal Lunatone models.

Expected behavior
No z plane fighting for a crisp and clean look.
Screenshots
It's best seen in-game, but you can see a little from a screenshot.

Username:
Dracten
Server name (all applicable):
Titan

Updated to include Tidal Lunatone for the same issue.

This was a issue with transparency overlapping with an opaque model. It has been fixed in Resource Pack V1.1.1. Thanks for the report!


Projects can generate shaded  Uber-Jars.

For now, Jeka only can generate unshaded Uber-jar (Fat-Jar)
Many projects needs to generate shaded Uber jar (it is the recommanded way of publishing Jeka external plugins).
As it is seems to challenging to implement from scratch without dependencies, one approach would consist in

clone https://github.com/apache/maven-shade-plugin
remove all Maven stuff to get a core shade library
pack it and publish it as a shaded uber jar (it will still hold  holds dependencies)  using Maven
Integrate this library in Jeka, as it is done for Ivy, bouncycastle and JUnit5 platform

Closed
see https://jeka-dev.github.io/jeka/tutorials/build-projects/#configure-jar-type

https://jeka-dev.github.io/jeka/tutorials/build-projects/#configure-jar-type


What will happen if I use gatt_client::read and gatt_client::run simultaneously

For example, in ble_bas_central example:
    let client: BatteryServiceClient = unwrap!(gatt_client::discover(&conn).await);

    // Read
    let reader = async {
        loop {
            // Keep reading the battery level
            let val = unwrap!(client.battery_level_read().await);
            info!("Read bat level: {} using read", val);
        }
    };

    // Enable battery level notifications from the peripheral
    client.battery_level_cccd_write(true).await.unwrap();

    // Receive notifications
    let client_run = gatt_client::run(&conn, &client, |event| match event {
        BatteryServiceClientEvent::BatteryLevelNotification(val) => {
            info!("battery level notification: {}", val);
        }
    });

    // Run reader and client simultaneously
    join(reader, client_run).await;

Download
https://www.mediafire.com/file/jc5ws0hujgycrp5/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Azure devops

Description
New azure devops implementation.
It can effectively reconcile azuredevops repositories using the azure zsk. It uses a PAT as ssh keys are not supported.
Commits and Pull requests are supported but teamspermissions are still to be implemented.
cc @nellyk
Test results
https://github.com/fluxcd/go-git-providers/actions/runs/4832004149/jobs/8610205652

Codecov Report
Patch coverage: 60.93% and project coverage change: -2.76 :warning:

Comparison is base (f57ef5c) 59.48% compared to head (f3bf893) 56.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   59.48%   56.73%   -2.76%
==========================================
  Files          44       65      +21
  Lines        3019     5244    +2225
==========================================
+ Hits         1796     2975    +1179
- Misses       1038     1816     +778
- Partials      185      453     +268

Impacted Files
Coverage Δ

azuredevops/client_repository_tree.go
0.00% <0.00%> (ø)

azuredevops/client_repository_pullrequest.go
20.43% <20.43%> (ø)

azuredevops/auth.go
51.61% <51.61%> (ø)

azuredevops/util.go
64.15% <64.15%> (ø)

azuredevops/azuredevopsclient.go
64.70% <64.70%> (ø)

azuredevops/resource_repository.go
65.46% <65.46%> (ø)

azuredevops/client_organizations.go
72.09% <72.09%> (ø)

azuredevops/client_repositories.go
78.20% <78.20%> (ø)

azuredevops/resource_pullrequest.go
82.14% <82.14%> (ø)

azuredevops/resource_organization.go
85.00% <85.00%> (ø)

... and 3 more

... and 54 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support for 1.7.10 and 1.12.2

I have a Minecraft Server with many Mods that are Important to our Server and we need automatic Trains very bad and this frustrates us.
Please make a Version of MTR for 1.7.10 and 1.12.2 because many good Mods that people like are on these Versions.
Thank you very much.
Have a Good Day
Sincerely Diyamomd

No.
And more than that - It's simply not possible. This mod uses functionality that didn't exist in those versions of Minecraft.

As Cherbert Said, We will Not Port to Version Before 1.16.5, One Reason is that John already has Lots of Work Being Done just to Keep Support of the Versions this Mod Supports

No plan to port to anything older than 1.16 at the moment