[BUG] No way to get tx_amount metric

OS and Environment
MacOS ventura 13.3, DockerHub
GIT commit hash
128df48
Minimum working example / Steps to reproduce
The description of the tx_amount metric is missing from the documentation https://github.com/hyperledger/iroha/blob/iroha2-dev/docs/source/references/api_spec.md
It is also not possible to get the metric curl -X GET http://<IP_ADDRESS>:8180/metrics
The metric is not uploaded to prometheus
Actual result
It is possible to get the metrics via curl -X GET http://<IP_ADDRESS>:8180/metrics
The metric is uploaded to prometheus
Expected result
There is no way to get the metrics via curl -X GET http://<IP_ADDRESS>:8180/metrics
The metric is not uploaded to prometheus
Logs in JSON format

Log contents
  ```bash
 docker-compose: ✗ curl -X GET http://<IP_ADDRESS>:8180/metrics
# HELP accounts User accounts registered at this time
# TYPE accounts gauge
accounts{domain="garden_of_live_flowers"} 1
accounts{domain="genesis"} 1
accounts{domain="looking_glass_3026bda2-4b53-4b2f-b1bd-8c34939cb600_209dbebf-764e-4b10-acd0-48ca391bc69b"} 0
accounts{domain="looking_glass_bc883052-4ce6-462e-91f9-bd7a2528b0d6_8c584d01-ec2b-4188-a188-68b2a46990c8"} 0
accounts{domain="wonderland"} 2
# HELP block_height Current block height
# TYPE block_height counter
block_height 3
# HELP connected_peers Total number of currently connected peers
# TYPE connected_peers gauge
connected_peers 3
# HELP domains Total number of domains
# TYPE domains gauge
domains 5
# HELP dropped_messages Sumeragi dropped messages
# TYPE dropped_messages counter
dropped_messages 0
# HELP queue_size Number of the transactions in the queue
# TYPE queue_size gauge
queue_size 0
# HELP tx_amount average amount involved in a transaction on this peer
# TYPE tx_amount histogram
tx_amount_bucket{le="0.005"} 0
tx_amount_bucket{le="0.01"} 0
tx_amount_bucket{le="0.025"} 0
tx_amount_bucket{le="0.05"} 0
tx_amount_bucket{le="0.1"} 0
tx_amount_bucket{le="0.25"} 0
tx_amount_bucket{le="0.5"} 0
tx_amount_bucket{le="1"} 0
tx_amount_bucket{le="2.5"} 0
tx_amount_bucket{le="5"} 0
tx_amount_bucket{le="10"} 0
tx_amount_bucket{le="+Inf"} 0
tx_amount_sum 0
tx_amount_count 0
# HELP txs Transactions committed
# TYPE txs counter
txs{type="accepted"} 4
txs{type="rejected"} 0
txs{type="total"} 4
# HELP uptime_since_genesis_ms Network up-time, from creation of the genesis block
# TYPE uptime_since_genesis_ms gauge
uptime_since_genesis_ms 66288356
# HELP view_changes Number of view changes in the current round
# TYPE view_changes gauge
view_changes 1

</details>

### Who can help to reproduce?

@timofeevmd

### Notes

_No response_

problem is not solve
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli domain register --id="looking_glass"
"99698DC566BA84623356FD3A5E42B451E2EE463F4760685EE3B46F58D9E52609"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli account register
--id="mad_hatter@looking_glass"
--key="ed01204595da8957c5598d4de20fe5f3eb4c14820678e1a1957a535db1fd4b3d1607c5"
"C6E66DD9BCC02898BEE127FF6BE2D7D18372BD865CFB64FE26A94C8D406AF169"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli account register
--id="white_rabbit@looking_glass"
--key="ed0120a4c4dadd9f18b0f63d6a420151fe0748d785475dec63034a15fcf999ceda1e65"
"9D425DB32C3A1316A7DDB86F3540DA63735A62EF746DAF9C60B7D2CFB0887D09"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset register
--id="tea#looking_glass"
--value-type=Quantity
"FECA904FFEB3BB9B655D661DC3996AB5BA54E4CB99A9533951D1CB596D16A9BD"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset mint
--account="mad_hatter@looking_glass"
--asset="tea#looking_glass"
--quantity="100"
"3D93A8DC7344F744425ABA2E2D133700B78D778D5170214E549871B53350643B"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset transfer --from mad_hatter@looking_glass --to white_rabbit@looking_glass --asset-id tea#looking_glass --quantity 5
"BE5B2AE52400E8C68CAD9571BB4039F2338FC707F41A984D71BB45AF8D3F285B"
➜  test_docker git:(iroha2-dev) ✗ curl -X GET http://<IP_ADDRESS>:8180/metrics
HELP accounts User accounts registered at this time
TYPE accounts gauge
accounts{domain="garden_of_live_flowers"} 1
accounts{domain="genesis"} 1
accounts{domain="looking_glass"} 2
accounts{domain="wonderland"} 2
HELP block_height Current block height
TYPE block_height counter
block_height 7
HELP connected_peers Total number of currently connected peers
TYPE connected_peers gauge
connected_peers 3
HELP domains Total number of domains
TYPE domains gauge
domains 4
HELP dropped_messages Sumeragi dropped messages
TYPE dropped_messages counter
dropped_messages 0
HELP queue_size Number of the transactions in the queue
TYPE queue_size gauge
queue_size 0
HELP tx_amount average amount involved in a transaction on this peer
TYPE tx_amount histogram
tx_amount_bucket{le="0.005"} 0
tx_amount_bucket{le="0.01"} 0
tx_amount_bucket{le="0.025"} 0
tx_amount_bucket{le="0.05"} 0
tx_amount_bucket{le="0.1"} 0
tx_amount_bucket{le="0.25"} 0
tx_amount_bucket{le="0.5"} 0
tx_amount_bucket{le="1"} 0
tx_amount_bucket{le="2.5"} 0
tx_amount_bucket{le="5"} 1
tx_amount_bucket{le="10"} 1
tx_amount_bucket{le="+Inf"} 4
tx_amount_sum 162
tx_amount_count 4
HELP txs Transactions committed
TYPE txs counter
txs{type="accepted"} 8
txs{type="rejected"} 0
txs{type="total"} 8
HELP uptime_since_genesis_ms Network up-time, from creation of the genesis block
TYPE uptime_since_genesis_ms gauge
uptime_since_genesis_ms 614620
HELP view_changes Number of view changes in the current round
TYPE view_changes gauge
view_changes 1

problem is not solve
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli domain register --id="looking_glass"
"99698DC566BA84623356FD3A5E42B451E2EE463F4760685EE3B46F58D9E52609"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli account register
--id="mad_hatter@looking_glass"
--key="ed01204595da8957c5598d4de20fe5f3eb4c14820678e1a1957a535db1fd4b3d1607c5"
"C6E66DD9BCC02898BEE127FF6BE2D7D18372BD865CFB64FE26A94C8D406AF169"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli account register
--id="white_rabbit@looking_glass"
--key="ed0120a4c4dadd9f18b0f63d6a420151fe0748d785475dec63034a15fcf999ceda1e65"
"9D425DB32C3A1316A7DDB86F3540DA63735A62EF746DAF9C60B7D2CFB0887D09"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset register
--id="tea#looking_glass"
--value-type=Quantity
"FECA904FFEB3BB9B655D661DC3996AB5BA54E4CB99A9533951D1CB596D16A9BD"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset mint
--account="mad_hatter@looking_glass"
--asset="tea#looking_glass"
--quantity="100"
"3D93A8DC7344F744425ABA2E2D133700B78D778D5170214E549871B53350643B"
➜  test_docker git:(iroha2-dev) ✗ ./iroha_client_cli asset transfer --from mad_hatter@looking_glass --to white_rabbit@looking_glass --asset-id tea#looking_glass --quantity 5
"BE5B2AE52400E8C68CAD9571BB4039F2338FC707F41A984D71BB45AF8D3F285B"
➜  test_docker git:(iroha2-dev) ✗ curl -X GET http://<IP_ADDRESS>:8180/metrics
HELP accounts User accounts registered at this time
TYPE accounts gauge
accounts{domain="garden_of_live_flowers"} 1
accounts{domain="genesis"} 1
accounts{domain="looking_glass"} 2
accounts{domain="wonderland"} 2
HELP block_height Current block height
TYPE block_height counter
block_height 7
HELP connected_peers Total number of currently connected peers
TYPE connected_peers gauge
connected_peers 3
HELP domains Total number of domains
TYPE domains gauge
domains 4
HELP dropped_messages Sumeragi dropped messages
TYPE dropped_messages counter
dropped_messages 0
HELP queue_size Number of the transactions in the queue
TYPE queue_size gauge
queue_size 0
HELP tx_amount average amount involved in a transaction on this peer
TYPE tx_amount histogram
tx_amount_bucket{le="0.005"} 0
tx_amount_bucket{le="0.01"} 0
tx_amount_bucket{le="0.025"} 0
tx_amount_bucket{le="0.05"} 0
tx_amount_bucket{le="0.1"} 0
tx_amount_bucket{le="0.25"} 0
tx_amount_bucket{le="0.5"} 0
tx_amount_bucket{le="1"} 0
tx_amount_bucket{le="2.5"} 0
tx_amount_bucket{le="5"} 1
tx_amount_bucket{le="10"} 1
tx_amount_bucket{le="+Inf"} 4
tx_amount_sum 162
tx_amount_count 4
HELP txs Transactions committed
TYPE txs counter
txs{type="accepted"} 8
txs{type="rejected"} 0
txs{type="total"} 8
HELP uptime_since_genesis_ms Network up-time, from creation of the genesis block
TYPE uptime_since_genesis_ms gauge
uptime_since_genesis_ms 614620
HELP view_changes Number of view changes in the current round
TYPE view_changes gauge
view_changes 1

The tx_amount_bucket, tx_amount_sum and tx_amount_count is the tx_amount histogram. It is solved.


addedmitretechnique

Added Cloud Service Discovery T1526 to all the kubernetes scan and pod scan detections

brought the branch up to date because it was failing CI: https://app.circleci.com/pipelines/github/splunk/security-content/2403/workflows/b505d900-06c5-4cd5-9a8a-7758b68cf6b5/jobs/6731/steps. This seemed to have fixed the issue.


Update Privacy Policy

Added contact email (to be created as an alias!), moderation purposes, account deletion info, children <13 section

Looks good to me, as soon as others approve the content I'm happy for this to be merged.

Might need to double-check if IP is actually public. Run a replay from the server's PoV and see if there are any "incoming connection from <IP_ADDRESS>; adding player XYZ" messages in the infolog afterwards.

No, it looks like it only shows usernames in infolog.txt:
[t=00:01:01.266110][f=-000001] Connection attempt from Teifion
[t=00:01:01.266110][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Linux 64-bit (native)]
[t=00:01:03.098004][f=-000001] Speed set to 20.0 [server]
[t=00:01:03.377941][f=-000001]  -> Connection established (given id 0)
[t=00:01:03.377941][f=-000001] Connection attempt from [DE]peacefighter1996
[t=00:01:03.377941][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.382927][f=-000001]  -> Connection established (given id 2)
[t=00:01:03.393409][f=-000001] Connection attempt from Rasoul
[t=00:01:03.393409][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.407008][f=-000001]  -> Connection established (given id 12)
[t=00:01:03.407008][f=-000001] Connection attempt from Born2Crawl
[t=00:01:03.407008][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.422995][f=-000001]  -> Connection established (given id 8)
[t=00:01:03.422995][f=-000001] Connection attempt from [IRL]rikerss
[t=00:01:03.422995][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.438628][f=-000001]  -> Connection established (given id 4)
[t=00:01:03.438628][f=-000001] Connection attempt from Fire[Z]torm_
[t=00:01:03.438628][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.460570][f=-000001]  -> Connection established (given id 5)
[t=00:01:03.460570][f=-000001] Connection attempt from raphael972
[t=00:01:03.460570][f=-000001]  -> Version: 104.0.1-1956-g0092498 BAR [Windows 64-bit (native)]
[t=00:01:03.477525][f=-000001]  -> Connection established (given id 13)


feat!: support hamming distance & binary vector

Codecov Report
Attention: Patch coverage is 65.84699% with 125 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (6e84834) to head (b52af6d).

Files with missing lines
Patch %
Lines

rust/lance-index/src/vector/flat/storage.rs
47.82%
58 Missing and 2 partials :warning:

rust/lance-index/src/vector/flat/index.rs
53.19%
21 Missing and 1 partial :warning:

rust/lance-linalg/src/distance/hamming.rs
36.00%
16 Missing :warning:

rust/lance-linalg/src/kmeans.rs
82.66%
13 Missing :warning:

rust/lance-index/src/vector/quantizer.rs
0.00%
5 Missing :warning:

rust/lance/src/dataset/scanner.rs
86.66%
1 Missing and 1 partial :warning:

rust/lance/src/index/vector/ivf.rs
80.00%
2 Missing :warning:

rust/lance/src/index/vector/utils.rs
0.00%
0 Missing and 2 partials :warning:

rust/lance-index/src/vector/hnsw/builder.rs
50.00%
1 Missing :warning:

rust/lance/src/index.rs
87.50%
0 Missing and 1 partial :warning:

... and 1 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3198      +/-   ##
==========================================
- Coverage   78.62%   78.56%   -0.06%
==========================================
  Files         243      243
  Lines       82889    83177     +288
  Branches    82889    83177     +288
==========================================
+ Hits        65170    65350     +180
- Misses      14933    15038     +105
- Partials     2786     2789       +3

Flag
Coverage Δ

unittests
78.56% <65.84%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Might still be good for @chebbyChefNEQ or @eddyxu to look at the indexing code but the rest looks ok to me.
Looks like we needed to duplicate a few structs to have a "Bin" version and a "Float" version?

Quantization determines the VectorStore, VectorStore determines the DistCalculator. For best performance we are storing the vectors ref / query as reference to slice of primitive type (f32/u8), so yes now we have to dup the structs to make the type system happy.


hana::less does not work for adapted structs

Consider this code godbolt
The codebase is c++17 - so I cannot just default compare operators...
For any adapted struct (in hana (actually boost::hana) way) I have this strange situation when hana::equal just works for implementing operator== while hana::less cannot be used for implementing operator<. For me documentation is unclear - should it work?
I dig a little into this problem - and it seems that when I call directly hana::less from operator< then less calls operator< so infinite recursion - so segfault.
While when it is called directly (not via operator<) then it does not compile with a set of static-assert, starting from complaining about adapted struct being not ordered - well...
When I compared sources for equal and less - indeed - support for adapted structs is missing in less.
The code:
#include <boost/hana/adapt_struct.hpp>
#include <boost/hana/equal.hpp>
#include <boost/hana/less.hpp>

namespace demo
{
struct Some
{
    int a;
    int b;
};
}

BOOST_HANA_ADAPT_STRUCT(demo::Some,
    a, b);

namespace demo
{
bool operator==(const Some& lhs, const Some& rhs)
{
    return boost::hana::equal(lhs, rhs);
}

bool less(const Some& lhs, const Some& rhs)
{
    return boost::hana::less(lhs, rhs);
}

bool operator<(const Some& lhs, const Some& rhs)
{
    // uncommenting boost::hana::less makes this segfault - because operator< calls itself
    //return boost::hana::less(lhs, rhs);
    return less(lhs, rhs);
}
}

int main() {
    return demo::Some{1, 1} < demo::Some{1, 2};
}

The output:
In file included from <source>:3:
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp: In instantiation of 'constexpr auto boost::hana::less_t::operator()(X&&, Y&&) const [with X = const demo::Some&; Y = const demo::Some&]':
<source>:29:29:   required from here
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:51:43: error: static assertion failed: hana::less(x, y) requires 'x' to be Orderable
   51 |         static_assert(hana::Orderable<T>::value,
      |                                           ^~~~~
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:51:43: note: 'std::integral_constant<bool, false>::value' evaluates to false
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:54:43: error: static assertion failed: hana::less(x, y) requires 'y' to be Orderable
   54 |         static_assert(hana::Orderable<U>::value,
      |                                           ^~~~~
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:54:43: note: 'std::integral_constant<bool, false>::value' evaluates to false
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:57:53: error: static assertion failed: hana::less(x, y) requires 'x' and 'y' to be embeddable in a common Orderable
   57 |         static_assert(!is_default<less_impl<T, U>>::value,
      |                                                     ^~~~~
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:57:53: note: '!(bool)std::integral_constant<bool, true>::value' evaluates to false
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/less.hpp:62:27: error: use of deleted function 'static constexpr auto boost::hana::deleted_implementation::apply(T&& ...) [with T = {const demo::Some&, const demo::Some&}]'
   62 |         return Less::apply(static_cast<X&&>(x), static_cast<Y&&>(y));
      |                ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/core/dispatch.hpp:14,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/value.hpp:18,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/concept/constant.hpp:19,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/core/to.hpp:15,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/bool.hpp:17,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/string.hpp:15,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/detail/struct_macros.hpp:28,
                 from /opt/compiler-explorer/libs/boost_1_84_0/boost/hana/adapt_struct.hpp:15,
                 from <source>:1:
/opt/compiler-explorer/libs/boost_1_84_0/boost/hana/detail/dispatch_if.hpp:21:31: note: declared here
   21 |         static constexpr auto apply(T&& ...) = delete;
      |                               ^~~~~
Compiler returned: 1

P.S.
I tried also to use hana::lexicographical_compare- but I did not manage to use it for adapted structs - any help would be welcome. I ended up with usinghana::all_of`...

The compiler error is that your type Some does not satisfy the concept hana::Orderable which requires an implementation of hana::less for your type. So, I am not seeing how your commented call to boost::hana::less would segfault if it would not compile.
In any case, you would need to implement hana::less. Unfortunately a struct cannot implement hana::Iterable to get the lexicographical_compare function to make this easy, but here is a example that skirts around that by converting Some to a tuple in the implementation.
https://godbolt.org/z/f5YK4j3ov

SEGFAULT explanation:

The segfault is when calling hana::less from operator< -- then, as I wrote, hana::less calls operator< which calls hana::less - so infinite recursion:
#include <boost/hana/adapt_struct.hpp>
#include <boost/hana/equal.hpp>
#include <boost/hana/less.hpp>

namespace demo
{
struct Some
{
    int a;
    int b;
};
}

BOOST_HANA_ADAPT_STRUCT(demo::Some,
    a, b);

namespace demo
{
bool operator==(const Some& lhs, const Some& rhs)
{
    return boost::hana::equal(lhs, rhs);
}

bool operator<(const Some& lhs, const Some& rhs)
{
    // uncommenting boost::hana::less makes this segfault - because operator< calls itself
    return boost::hana::less(lhs, rhs);
}
}

int main() {
    return demo::Some{1, 1} < demo::Some{1, 2};
}

Well...

So, in general, I need to implement hana::less_impl to use hana::less for every struct (hundreds of them I have) in my project, to use hana::less to implement operator< for my structs. Well, instead I can just implement my operator< with std::tie, can't I - and just forget about hana library?
My goal is to use BOOST_HANA_ADAPT_STRUCT(demo::Some,  a, b, ... tens of fields here...); when implementing operator<. I did not want to repeat these fields agains in operator< -- because then - these ADAPT_STRUCT is useless.
The other thing is that I do not want to copy all fields into the hana tuple -- I know, I can use std::reference_wrapper - or just use std::tie.
Just for information - I did this to have implementation of operator< and still use ADAPT_STRUCT:
template <typename T> // assuming T has hana::accessors
int compare(const Some& lhs, const Some& rhs)
{
//    return boost::hana::less(lhs, rhs);
    int result{};
    static_cast<void>(boost::hana::all_of(boost::hana::accessors<T>(),
        [&](const auto& field)
        {
            if (result != 0) return false;
            auto get = boost::hana::second(field);
            auto&& lhs_field = get(lhs);
            auto&& rhs_field = get(rhs);
            if (lhs_field < rhs_field) { result = -1; return false; }
            if (rhs_field < lhs_field) { result = 1; return false; }
            return true;
        }));
    return result;
}

bool operator<(const Some& lhs, const Some& rhs)
{
    return compare(lhs, rhs) < 0;
}

For me, it is hard to believe that adding support for adapted structs in hana::less is so hard, it was done for hana::equal and it just works. But ok, for C++20 it is not needed...

So, in general, I need to implement hana::less_impl to use hana::less for every struct (hundreds of them I have) in my project, to use hana::less to implement operator< for my structs. Well, instead I can just implement my operator< with std::tie, can't I - and just forget about hana library?

The only benefits to implementing hana::less that I see immediately are that you get hana::greater, hana::min, and hana::max for free and your data type is then hana::Orderable. Beyond that I am not sure there is any other benefit.
In general, adapted structs are not considered ordered because it is the user who should opt in and define how that ordering should work. I made a more general solution that uses hana::accessors to fix the issue with copying and allows us to use the hana::lexicographical_compare function with a predicate. To opt in, I made a "concept" to indicate the struct is to be ordered lexicographically. (I did not test this thoroughly.)
namespace boost::hana {
  template <typename T>
  struct less_impl<T, T,
            hana::when<demo::concept::LexicographicallyOrderedStruct<T>::value>> {
    static constexpr auto apply(demo::Some const& x,
                                demo::Some const& y) {
      constexpr auto accessors = hana::transform(hana::accessors<T>(),
                                                 hana::second);
      return hana::lexicographical_compare(accessors, accessors,
        [&](auto accessor, auto) {
          return hana::less(accessor(x), accessor(y));
        });
    }
  };
}

https://godbolt.org/z/sbrPzMf3a


ageusia/hypogeusia/dysgeusia terms

Consider adding the following new terms:
ageusia (a child abnormal taste sensitivity MP:0001986)
DEF: complete absence or loss of the sense of taste, that is the inability to detect sweetness, sourness, bitterness, saltiness, and umami (pleasant/savory taste)
SOURCE: https://www.slideshare.net/RizgarSaeed1/disturbances-of-taste-dysgeusia-hypogeusia-and-ageusia
hypogeusia ( a child abnormal taste sensitivity MP:0001986)
DEF: partial loss of taste or reduced ability to detect sweetness, sourness, bitterness, saltiness and/or umami (pleasant/savory taste); may be general to all tastants, partial to some tastants, or specific to one or more tastants
SYN: partial loss of taste
SYN: decreased taste sensitivity
SYN: reduced taste sensitivity
SYN: amblygeustia
SYN: hypogeusesthesia
SOURCE: https://medical-dictionary.thefreedictionary.com/hypogeusia
dysgeusia (a child of abnormal gustatory system physiology MP:0001985)
DEF: a distortion or an alteration in the perception of a tastant; an unpleasant perception may occur when a normally pleasant taste is present, or the perception may occur when no tastant is present
SYN: parageusia
SYN: altered taste sensation
SYN: distorted taste sensation
SOURCE: https://medical-dictionary.thefreedictionary.com/dysgeusia
abnormal taste sensitivity
AMEND DEF: changes in the ability to perceive a  particular flavor(s) or suggestion of something imparting a flavor by the  chemoreceptors of the gustatory system

@sbello
Is abnormal taste sensitivity MP:0001986 a more appropriate parent term for all above terms or should we go with the higher level term abnormal gustatory system physiology MP:0001985?

Amended definition for abnormal taste sensitivity.
Added new terms:
ageusia MP:0031090
hypogeusia MP:0031091
dysgeusia MP:0031092


State names missing after HA 2023.04 update

After updating to 2023.04 the states are no longer translated but the plain numbers are shown.

Could this be related to
https://github.com/home-assistant/core/commit/8968ed1c47314db4b9ee7eeb302c92c4e71915a3
?
based on NON_NUMERIC_DEVICE_CLASSES
https://github.com/home-assistant/core/blob/6c7f2167ff0bea90a26cbb08035a8e16a2478acc/homeassistant/components/sensor/const.py#L406
not sure how uptodate the documentation is but according to
https://developers.home-assistant.io/docs/core/entity/sensor
based on that I would expect that
    SensorEntityDescription(
        key="vampair_state",
        icon="mdi:heat-pump",
        device_class="solarfocus__hpstate",
    ),

must be somehow changed to something like
    SensorEntityDescription(
        key="vampair_state",
        icon="mdi:heat-pump",
        device_class=SensorDeviceClass.ENUM,
       state_class=StateClass.MEASUREMENT,
        options={
             "0": "Bereitschaft",
      "1": "Heizbetrieb",
...
        },
    ),

Not sure if this should be a dict or a list (base on the doc), and if its opitions or state
I wanted to update today, but I think I will now postpone :-)

Looks like it. Somehow missed that change 😇 try to fix this asap


SVGs rendered incorrectly, placements, scaling, and markers

Description
Hi! I have done a quick search among the issues, and have not been able to identify if this or a similar issue is already opened. In that case, please feel free to close this issue.
I am trying to render a svg in typst v.0.11.1. It is included here. One can probably simplify the svg to isolate the issues.
Here is the SVG, as rendered by your browser:

Here is the SVG, as rendered in chromium:

And here is how the svg is rendered in typst.

Here are somethings that I take note of:

The (subtle) red gradient, close to the "underwater infrastructure", is misplaced an miscaled.
There are no arrows on some strokes, indicating the "hydrophone arrays".
Some scaling issues. Note the top left corner, where the text "hydrophone array" ends up outside the "water".

Code
image("setup.svg")
Output:
new_svg.pdf
Seemingly, there is very little typst code in the mix here. If you guys use some svg-rendering backend, this issue should likely be opened there instead.
(I have included a reproduction url. Interestingly, even though the typst version is the same, the rendered output is slightly different. In this case, the first issue with the red gradient is solved, and the last issue relating to the scaling. So, seemingly the version in the app and on my local machine produce different output? In this case, only the "arrow heads" are missing)
Reproduction URL
https://typst.app/project/rKZXclPEO_opIodLHLP_jY
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

Cannot reproduce on main.

Yes, I can reproduce this in the webapp. there has been a major update to SVG handling since 0.11 and it seems that all three points are addressed when rendering with the newest development build, so it should be fixed by the next release. Thanks for the report, still!


[stable/rabbitmq] Make metrics probes configurable

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
The default probe configuration for rabbitmq metrics side car are not suitable for
all deployments. In particular, i needed to bump the readiness timeout to 15s for
a rabbitmq cluster with > 500 queues.
Just like the confirable rabbitmq probes, the metrics probes should also be
configurable so that they can be tuned appropriately.
Which issue this PR fixes
Special notes for your reviewer:
I kept the original timeouts from statefulset.yaml and moved them into values.yaml.
If these defaults were too low for my deployment, perhaps the default values should
also be bumped up in values.yaml?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @javsalgar

/ok-to-test

Thank you very much for your Pull Request, @swarkentin. This looks good so far, I just mentioned a couple of things for completion purposes.
Regarding the defauls, I think for now the defaults are enough, specially after your PR adding customization support. We can always increase them in the future.
Thanks again!

Thank you for taking the time to review @alemorcuq! dfcf104200844279ec03f7c4ee199419cb102297 should have resolved remaining concerns

Thank you for taking the time to review @alemorcuq! I believe remaining concerns have been resolved in my most recent commits.

Thank you, @swarkentin !
@juan131, @carrodher, feel free to add the /lgtm and /ok-to-test labels.

/ok-to-test
/lgtm


yml as input plus project name

Does not seem to work...
perl -I lib bin/alitv.pl data/chloroset/input.yml

***********************************************************************
*                                                                     *
*  AliTV perl interface                                               *
*                                                                     *
***********************************************************************

You are using version v0.1.12.
INFO - Created temporary folder at '/tmp/_Q2WDyftc2'
INFO - Starting alignment generation... (36 alignments required)
[...]

json/log/map files have the name autogen_XXXXX.*
But if proving a project name I am receiving a warning message:
perl -I lib bin/alitv.pl --project new_run data/chloroset/input.yml
YML file specified, therefore the project name was overwritten by 'input'!

***********************************************************************
*                                                                     *
*  AliTV perl interface                                               *
*                                                                     *
***********************************************************************

You are using version v0.1.12.
INFO - Created temporary folder at '/tmp/wDTDHkuKA3'
INFO - Starting alignment generation... (36 alignments required)

But json/log/map are now named as expected input.*

In alitv.pl lines 49ff there is:
if ($project)
{
	$project = fileparse($yml, qr/\Q.yml\E/i);
	warn "YML file specified, therefore the project name was overwritten by '$project'!\n";
}

So project is only overwritten with the basename of the .yml file if it has been explicitly set. This leads to the strange behaviour that if --project is not used together with a .yml file the output is named autogen... but if you set a project name it is ignored and the name of the .yml file is used.
In my opinion the desired behaviour is to always use the project name if it has been explicitly set using --project and use the basename of the .yml file only if none is provided. The autogen names would then only be necessary for usage with .fasta files and no --project

Okay, so we have the following scenarios:

Project set via --project option, no influence by YAML or sequence files
No project set, but YAML file as single parameter
No Project set, no YAML file provided  and therefore assuming that the user provided a set of sequence files

Output for different scenarios:

We are using the provided project name
The basename of the YAML file is used as project name
The project name will be autogenerated and the YAML file is based on that autogenerated project name

Would that match your expectations @iimog ?

Perfect summary of my expectations :smiley:


Consult the author

Hello, I would like to ask you which file should be run to generate the image

Hi, This code does not generate any image. The gif that I provided is the running algorithm over iterations, which I recorded using Camtasia software for performance presentation purposes.

Ok, I got it. Thank you for your reply


PR edit

I've tidied up PR #54 a bit and made a new PR against main.
Sorry, I should have made a proper PR against the fork really, but I only realised that halfway through.
See what you think

@Lextuga007 please review and squash merge to remove the unwanted files

We appreciate your time on this ☺

I love this PR! Excellent work on both sides :clap: :clap: :clap:


Reformattinhg code

Codecov Report

Merging #814 into node_sync will decrease coverage by <.01%.
The diff coverage is 99.71%.

@@               Coverage Diff               @@
##             node_sync     #814      +/-   ##
===============================================
- Coverage        99.52%   99.52%   -0.01%
  Complexity        1953     1953
===============================================
  Files              294      294
  Lines             5742     5709      -33
  Branches           286      286
===============================================
- Hits              5715     5682      -33
  Misses               5        5
  Partials            22       22

Impacted Files
Coverage Δ
Complexity Δ

...va/com/quorum/tessera/admin/PublicKeyResponse.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...om/quorum/tessera/enclave/rest/EnclavePayload.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

...sera/partyinfo/AutoDiscoveryDisabledException.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...m/quorum/tessera/enclave/EnclaveClientFactory.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...um/tessera/partyinfo/PartyInfoParserException.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...om/quorum/tessera/enclave/rest/ClientCallback.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...quorum/tessera/enclave/rest/EnclaveRawPayload.java
100% <ø> (ø)
11 <0> (ø)
:arrow_down:

...va/com/quorum/tessera/partyinfo/ResendRequest.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

.../tessera/enclave/rest/EnclaveUnencryptPayload.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...com/quorum/tessera/partyinfo/P2pClientFactory.java
100% <100%> (ø)
3 <2> (ø)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a53176...8566ec1. Read the comment docs.


Fix error in example

Fix an example, changing single quotes to double quotes (fixes #263).

Hi @andrewdbate,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.lightbend.com/contribute/cla

Thanks!


chore: bump zio, zio-test, zio-test-sbt from 2.0.0-RC2 to 2.0.0

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.0-RC2 to 2.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #226.


Failure in buildah bud from podman container.

Description
@ipbabble was trying to run this command with the Dockerfile:
sudo podman --log-level debug run --network host  -v /home/whenry/lib/containers:/var/lib/containers:Z -v /home/whenry/dfs:/tmp:Z buildah --storage-driver vfs bud -f /tmp/Dockerfile

FROM fedora:latest
MAINTAINER http://fedoraproject.org/wiki/Cloud
RUN dnf -y update && dnf clean all
RUN dnf -y install nginx && dnf clean all
RUN echo "daemon off;" >> /etc/nginx/nginx.conf
RUN echo "nginx on Fedora" > /usr/share/nginx/html/index.html
EXPOSE 80
CMD [ "/usr/sbin/nginx" ]

Steps to reproduce the issue:

Issue the above command

Describe the results you received:
Getting image source signatures
Copying blob sha256:2176639d844bbe1386912e1d9952cebdb8249923a16691025cf693963f8aec53
77.54 MiB / 77.54 MiB [=================================================] 5m22s
Copying config sha256:9110ae7f579f35ee0c3938696f23fe0f5fbe641738ea52eb83c2df7e9995fa17
2.29 KiB / 2.29 KiB [======================================================] 0s
Writing manifest to image destination
Storing signatures
error building: error creating build container: no such image "fedora:latest" in registry: image not known
DEBU[0326] unmounted container "5221f7741d8d8a4c2470def3cb624eeee322fe1d3ed949af7c1066b89bbadff7"

It appears the image is being pulled, but not written locally.  The error message is also a bit misleading, it might be best in this situation to say "error writing {image} to repository:".  This error appears to be used for errors for both the pull and then the initial write.
Describe the results you expected:
Happy container.
This was on a newly installed Fedora 27 machine on 3/23/2018.

I believe this is fixed in the current code.


Restore the BONTextConstraint

[ ] Restore the Objective-C BONTextConstraint.
[ ] Restore the constraint tests.
[ ] Restore example app
[ ] Optionally re-write it in swift.

Merged!


Update create pin screen UX

### Background
People are experiencing confusion over the PIN screen. People view this screen and believe they need to input a PIN they received rather than input their own PIN that will be used to secure their wallet. This confusion is in part due to a bug that removed the header of the PIN screen that would give people more context. However a review of the current design is necessary to uncover potential improvements.
DoD

User flow
Wireframes
Acceptance criteria

Quebec shared their flow with me and I'm going through past research to see if there are any findings on this that will help

I don't see anything in the Quebec designs on the PIN screen (flow or wireframes). I've don't a lot of digging and maybe part of the confusion is because the app doesn't require a login/account name? such as phone number and password as an example. I've started to created alt designs in XD.

I created a few new screens based on testing. I would like us to try using a single box approach for PIN creation and login screens. XD link.

Reviewed with Kim, creating a dev ticket to complete the work.


getting started docs

Hi! I was giving this a spin didn't see any mention of pipenv in the docs, so I wanted to just add a couple notes for future travelers.

Thanks!


Replace the unmaintained pty.js with node-pty

Note that this uses the npm version instead of a prebuilt tar. Which means users will have to build it, but it also means we will get semver compatible updates.
Potentially ~fixes~ #422 and others.
This is a rather blind replacement, hopefully there is no API break...

Need to do the same: fork and include pre-built node.bin files for different OS. Only 5% users have a compiler installed on a host machine.

@ivankravets I'm not really sure how to do this... Google does reveal prebuild which supposedly has support for electron. But I'm not sure if it will work with apm...
If you think this PR is good, and have the time, you can create the prebuilt package the way you want it, and I can update the package.json to point to it.

Testing this PR mode, It this seems to have only reduced the occurrence of #422. I wonder if the issue is in WinPTY, node-pty, or somewhere in platformio-ide-terminal... For now platformio-ide-terminall is unusable for me on Windows 😢
It's still a good idea to move to a maintained version of a node.js pty module though. So I'm keeping this open.

node-pty has a critical bug on Windows https://github.com/Microsoft/vscode/issues/40199
See https://github.com/platformio/platformio-vscode-ide/issues/61

@ivankravets This looks exactly like #422. But here it is both with pty.js (winpty 0.2) and also with node-pty from this PR (winpty 0.4.3). Sigh...
Considering that it happens in two different implementations of a terminal and two different/similar wrappers for winpty, and that winpty uses hooks, and it's a WriteFile/write/fwrite that fails with errno 0 (Should never happen). It's most likely a winpty bug. We might want to open an upstream bug on winpty, linking all this three issues.

@Tyriar has already pinged @rprichard. Let's wait for the news...

@segevfiner could you file an issue here https://github.com/rprichard/winpty/issues ?

@ivankravets Opened https://github.com/rprichard/winpty/issues/134

If Python is critical it's probably best to wait until https://github.com/Microsoft/console/issues/40 starts rolling out to Windows users.
Once that happens be sure to update to latest node-pty, The latest 0.7.4 has a workaround that prevented terminals on the macOS beta from exiting https://github.com/Tyriar/node-pty/releases

We still need to pre-built modules for Win/Mac/Linux.


Download the RAM and MobileSAM weights directly from Hugging Face.

There is no official MobileSAM model on HF. Doing only RAM


how to not create multiple rAF callbacks?

So I'm trying to integrate TweenJS into a team project.  My PR is getting rejected because TweenJS creates multiple rAF callbacks per frame, as opposed to one single rAF callback per frame.  I was wondering if that use case is supported?  I think the useTicks options and tick method would do it, but it doesn't seem to animate correctly?  I couldn't find any examples of how I might support that use case (but would be happy to send a PR with a new example once I figure it out).  Is it possible for me to disable the Ticker class from creating multiple rAF calls, and instead be able to pass the time delta from my single rAF callback into a tween instance?

I suppose I could just use Ease, and stretch the range from [0, 1], but I suppose this would be duplicating work Tween already does.

Ticker should only create a single RAF call. Are you hoping to remove that and replace it with an existing one? If so, to what end?

I see the issue as, per frame, there's then 2 rAF callbacks:
rAF(fnFromMyApplication)
rAF(TweenJSTickerCB)
vs
rAF(fnFromMyApplicationThatCallsTweenJSTickerUpdateFn)

Why is that a concern, specifically? If its performance, you may be worrying about nothing. Its good to avoid lots of RAF subscribers (ex. subscribing every sprite in a particle engine), but the impact of 2 subscribers vs 1 is probably not measurable.
Also, is there a reason your application can't simply use Ticker directly? It is design to act as the heartbeat for interactive experiences:
createjs.Ticker.on("tick", myApplication.tick, myApplication);
You can even use the once param to mimic an RAF-type subscription model:
createjs.Ticker.on("tick", myApp.tick, myApp, true); // only listen once

myApp.tick = function(evt) {
   // do some stuff.
   if (needsRAF) {
      createjs.Ticker.on("tick", this.tick, this, true);
   }
}

If its performance, you may be worrying about nothing. Its good to avoid lots of RAF subscribers (ex. subscribing every sprite in a particle engine), but the impact of 2 subscribers vs 1 is probably not measurable.

I agree, but my team mates won't let me check in code that that is using multiple rAF callbacks per frame.  I was simply trying to see if TweenJS supported such a use case.

No offense to your team mates, but they should focus on pragmatic vs ideological development. Its easy to get distracted by absolutes ("no more than one RAF callback"), and lose sight of realities ("we need to ship this").
Ignoring philosophy, one other option, which may be easier in your case is to drive Tween without using Ticker. Either leave Ticker out of your JS (Tween will only use it if it is available), or unsubscribe Tween from it. You can then tick Tween manually.
createjs.Ticker.removeEventListener("tick", createjs.Tween);
createjs.Ticker.reset(); // prevents RAF subscription
// ...
function appRAFHandler() {
   // do stuff.
   createjs.Tween.tick(delta, paused);
}

See the docs for Tween.tick for more info.

That's sage advice; thanks for your thoughts on the matter, and the code example!


[misc]: unable to fetch

I understand that this issue may be closed if it should be filed in another category

[X] I understand

My issue

Well  i can upload doc normal
But at time of fetch 403 Error
Also there was no problem fetching 2 days ago all works fine

Error msg =
<Error>
AccessDenied
<Message>Access Denied</Message>
<RequestId>GEQBVABNESRZWR9Q</RequestId>
<HostId>Nah431u6mXXvTKAIX/sQMa/d2wM4qR9RlivmxWTzKlaXqhpIVzBH+2jh3GBQYMcBlwtkW8nt+Xxzgl9XShFqNw==</HostId>
</Error>

Well I know its Auth error but why suddenly not before

Are you seeing this with all files, or just specific ones? Can you share the file key of a file that is having this issue?

Request URL:
https://uploadthing-prod.s3.us-west-2.amazonaws.com/a62396f0-838e-4a30-bce9-daab368a4992-1uy2qb.pdf

  const response = await fetch(
      `https://uploadthing-prod.s3.us-west-2.amazonaws.com/${file.key}`
    )

File Type = PDF
File is Accessible for Website (Link = https://utfs.io/f/a62396f0-838e-4a30-bce9-daab368a4992-1uy2qb.pdf)

I think i need to add  some header or token to get request during fetch Probably

https://uploadthing-prod.s3.us-west-2.amazonaws.com/${file.key}

This is not a valid url.
Use `https:/utfs.io/${file.key}`

Thank you for your time and efforts brother


feat(dl_manager): add support for ftp downloads

I am working on a new dataset (#302) and encounter a problem downloading it.
# This is the official download link from https://www-i6.informatik.rwth-aachen.de/~koller/RWTH-PHOENIX-2014-T/
_URL = "ftp://wasserstoff.informatik.rwth-aachen.de/pub/rwth-phoenix/2016/phoenix-2014-T.v3.tar.gz"

dl_manager.download_and_extract(_URL)

I get an error:

ValueError: unable to parse ftp://wasserstoff.informatik.rwth-aachen.de/pub/rwth-phoenix/2016/phoenix-2014-T.v3.tar.gz as a URL or as a local path

I checked, and indeed you don't consider ftp as a remote file.
https://github.com/huggingface/datasets/blob/4c2af707a6955cf4b45f83ac67990395327c5725/src/datasets/utils/file_utils.py#L188
Adding ftp to that list does not immediately solve the issue, so there probably needs to be some extra work.

We only support http by default for downloading.
If you really need to use ftp, then feel free to use a library that allows to download through ftp in your dataset script (I see that you've started working on #722 , that's awesome !). The users will get a message to install the extra library when they load the dataset.
To make the download_manager work with a custom downloader, you can call download_manager.download_custom instead of download_manager.download_and_extract. The expected arguments are the following:
url_or_urls: url or `list`/`dict` of urls to download and extract. Each
        url is a `str`.
custom_download: Callable with signature (src_url: str, dst_path: str) -> Any
        as for example `tf.io.gfile.copy`, that lets you download from google storage

Also maybe it coud be interesting to have a direct support of ftp inside the datasets library. Do you know any good libraries that we might consider adding as a (optional ?) dependency ?

Downloading an ftp file is as simple as:
import urllib
urllib.urlretrieve('ftp://server/path/to/file', 'file')

I believe this should be supported by the library, as its not using any dependency and is trivial amount of code.

I know its unorthodox, but I added ftp download support to file_utils in the same PR https://github.com/huggingface/datasets/pull/722
So its possible to understand the interaction of the download component with the ftp download ability

Awesome ! I'll take a look :)

@AmitMY Can you now download the Phoenix2014 Dataset?

@hoanganhpham1006 yes.
See pull request https://github.com/huggingface/datasets/pull/722 , it has a loader for this dataset, mostly ready.
There's one issue that delays it being merged - https://github.com/huggingface/datasets/issues/741 - regarding memory consumption.

The problem which I have now is that this dataset seems does not allow to download? Can you share it with me pls

The dataset loader is not yet ready, because of that issue.
If you want to just download the dataset the old-fashioned way, just go to: https://www-i6.informatik.rwth-aachen.de/ftp/pub/rwth-phoenix/2016/phoenix-2014-T.v3.tar.gz (the ftp link is now broken, and its available over https)

Got it, thank you so much!

FTP downloads are supported.


[MINOR] Fix sphinx build warnings for python documentation

Corrected two docstrings to prevent several warnings reported when using Sphinx to generate python documentation.

Here are examples of the warnings messages:
systemml/src/main/python/systemml/defmatrix.py:docstring of systemml.defmatrix.matrix:65: WARNING: Enumerated list ends without a blank line; unexpected unindent.
src/main/python/systemml/mlcontext.py:docstring of systemml.mlcontext.getDatasetMean:2: (SEVERE/4) Unexpected section title.
systemml/src/main/python/systemml/init.py:docstring of systemml.matrix:65: WARNING: Enumerated list ends without a blank line; unexpected unindent.
src/main/python/systemml/init.py:docstring of systemml.getDatasetMean:2: (SEVERE/4) Unexpected section title.

LGTM. Thank you @gweidner

Thank you Deron for reviewing - I will merge after PR 639 closed.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2002/


Vulkan Memory Allocator usage in VulkanStagePool class

Hello, I'm the author of Vulkan Memory Allocator library. Thanks for using the library in your project.
I would like to suggest that in file VulkanStagePool.cpp, in function VulkanStagePool::acquireStage, memory usage should be VMA_MEMORY_USAGE_CPU_ONLY rather than VMA_MEMORY_USAGE_CPU_TO_GPU because that's the flag recommended for buffers that are used only as a source of transfer and not directly accessed by GPU while rendering.
By the way, I would also suggest to use version of the library from "development" branch, not from "master", as this release is quite old. You can find there functions to flush and invalidate memory (vmaFlushAllocation, vmaInvalidateAllocation), which you should do before/after mapping for memory types that are not coherent. This is important on mobile platforms, and I couldn't find any such calls (like vkFlushMappedMemoryRanges/vkInvalidateMappedMemoryRanges) in your current code.

Thanks Adam! The Vulkan backend is still a work in progress, but this is very valuable information. And thanks for the library, it saved us a ton of time.

Ah, thanks for the note Adam, we'll definitely fix this stuff up and update the library!
Another issue is that we're not calling the defrag function anywhere...

There is no need to call defrag function. Currently defragmentation works only with HOST_VISIBLE (CPU) memory anyway. Allocation algorithm should do a good job at finding optimal place for new allocations.


KDE desktop sharing security

krfb is a VNC server that is included in Kinoite by default. It looks like they want to deprecate it in favor of an RDP server based on PipeWire called krdp.
krdp is provided by default, although it doesn't seem to work very well. But krfb is also still there by default, even in Plasma 6.2
When I launched it initially, I believe it gave a warning about unencrypted connections. Perhaps this package should be removed, or hardened to only allow encrypted connections.
https://quantumproductions.info/articles/2023-08/remote-desktop-using-rdp-protocol-plasma-wayland

I believe it should be removed, I cannot find any "hardening" settings available, except not announcing the service over the whole network.

I believe it should be removed, I cannot find any "hardening" settings available, except not announcing the service over the whole network.

I was likewise unable to find any documentation about hardening or restricting unencrypted connections.
krdp, by contrast, required me to set SSH keys and wouldn't launch without that. (also wouldn't launch with them, but that is another issue)

A PR fixing the issue has been merged, so this should likely be closed.


peg parser is public, can emit structured err types

makes peg parser error type public
renames parseError -> PegParseError (to differentiate from our internal ParseError)
adds structured error public method and public type to be able to access structured error data externally

I'd like to move off our fork if possible. Can we move these types to a sibling file in pkg/flow/pkg it should still work because files in the same module have access to private types


Respecting pyproject.toml

The plugin is awesome but it doesn't respect pyproject.toml and it's [tool.black] section. There is no way to set up for example line-length per project.

+1

@im-n1 Thanks for the report, this is mentioned in TODO.md.

@averms can't see such file but I trust you :)


reintroduce application detail info

The versions before version 1.0, it was possible to show an application info panel by clicking on an application in the list.
We agreed to drop this info panel for version 1.0, but also agreed it should be added back in the future. So let's put it back.

Old situation.


Remove invalid comma in ASA code sample

Fix extra comma in code sample (INNER JOIN, impressions -> INNER JOIN impressions)

@tomasr : Thanks for your contribution to the Azure documentation! The author, @JSeb225, has been notified to review your proposed change.

@JennieHubbard: I'm sorry - only the author of this article, @JSeb225, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@tomasr good catch, actually can we change this query to the following otherwise it doesn't compile
SELECT clicks.id
FROM clicks
INNER JOIN impressions ON impressions.id = clicks.id AND DATEDIFF(hour, impressions, clicks) between 0 AND 10

@tomasr : Thanks for your contribution! The author, @JSeb225, has been notified to review your proposed change.

Implemented the change suggested by @JSeb225, and also fixed the next sample query which had issues as well.

Thanks!
#sign-off


allow concurrent synchronization of different shards per database

Scope & Purpose
Enable concurrent synchronization of shards in the same database.

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as replication tests, cluster tests, resilience tests.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11369/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11380/


Error 700

0.5.4
The explanation should also say that the NEM needs to have been aged 24 hours (or the time that it takes 1440 blocks).  Lots of newbies get their NEM and then 5 minutes later click harvest and it doesn't work.  I have had to explain this a few times.
This error comes up when a person clicks "harvest".

yea, the entire error handling is not optimal. We have to improve a lot on that.


Do not return original tree when not linting.

The lintTree hook is expected to only return a value when it is emitting contents that are different than the input tree (e.g. it emits lint tests). Returning the original input tree results in extra wasted processing (double modules transpilation, extra build work to merge, etc).
FWIW, returning the original raw tree is causing errors in<EMAIL_ADDRESS>(should be fixed in 2.13.1) see https://github.com/ember-cli/ember-cli/pull/7036.

Thanks - this looks good.
Do you know of a quick way to test against a regression for this?

@sir-dunxalot can I pester you for a merge and new release?

@lukemelia your wish is my command 😄


[FEA] distributed gnn primitives

Modulus Pull Request
Description

note: hold back until #105 is merged, this PR builds upon these changes
based on distributed primitives in #105, this PR adds distributed GNN primitives using these generic routines
add a naive graph partitioning scheme
modifies GraphCastNet and MeshGraphNet to (more or less) allow straightforward tensor-parallel distribution of these models
adds tests for distributed runs for these two models testing underlying GNN primitives implicitly

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci

@stadlmax the coverage test is failing because it falls below 80%. Could you please use # no pragma in your code until we stand up the multi-GPU CI and coverage? Example: https://github.com/NVIDIA/modulus/blob/main/modulus/models/sfno/sfnonet.py#L104

/blossom-ci

/blossom-ci

@stadlmax could you please black format your code? I recommend using pre-commit

@stadlmax could you please black format your code? I recommend using pre-commit

I usually do so, apparently I forgot it this time. Will do :)

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci


how does FConvLanguageModel mask future information?

FConvLanguageModel   is a language model base on CNN.  At training time, we will feed the whole sentence to the model, the target is the same sentence shift 1 position to right, it will cause model  use future information, so for language model, we need mask future information. But I can't find any code do that in this model.  Can someone help me out?

The convolutions are padded so they do not see future information. It’s an
argument you can pass to the convolutional layer.
On Tue, Apr 23, 2019 at 23:33 scott huang(黄<EMAIL_ADDRESS>wrote:

FConvLanguageModel is a language model base on CNN. At training time,
we will feed the whole sentence to the model, the target is the same
sentence shift 1 position to right, it will cause model use future
information, so for language model, we need mask future information. But I
can't find any code do that in this model. Can someone help me out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pytorch/fairseq/issues/658, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYBG7KMTOCWDU2KWULYJE3PR75KHANCNFSM4HIAYKFQ
.

here is the demo image for the language model part, from the paper Convolutional Sequence to Sequence Learning
https://arxiv.org/pdf/1705.03122.pdf

@huihuifan @frankang. thanks I am confused by the paper. in this paper it said the padding size is k/2 (k is the cnn kernel size), but the  padding size should be k -1.


ADMStack and ADMResBlock changes

Stack from ghstack (oldest at bottom):

#490
-> #489
#488

Differential Revision: D50288363

@ebsmothers has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (13ff74d) 74.04% compared to head (be428bd) 74.10%.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           gh/ebsmothers/20/base     #489      +/-   ##
=========================================================
+ Coverage                  74.04%   74.10%   +0.06%
=========================================================
  Files                        207      207
  Lines                      14221    14255      +34
=========================================================
+ Hits                       10530    10564      +34
  Misses                      3691     3691

Files
Coverage Δ

tests/diffusion_labs/test_adm.py
100.00% <100.00%> (ø)

...chmultimodal/diffusion_labs/models/adm_unet/adm.py
98.36% <100.00%> (+0.36%)
:arrow_up:

...imodal/diffusion_labs/models/adm_unet/res_block.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@ebsmothers has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

@ebsmothers has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

@ebsmothers has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.


Use apperrors in Compass Provisioner

Description
Changes proposed in this pull request:
Categorize errors and extend graphql response with error codes.
Related issue(s)
#1438

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/retest

/test pre-control-plane-components-provisioner


Firefox+Evernote: blank lines

Blank lines are appearing in rendered Markdown in the Evernote web interface. Possibly newline type detection is failing?
This totally breaks tables and puts blank lines in code blocks.
Here's an example:
https://www.evernote.com/shard/s1/sh/a0ce4e44-07b4-4258-9744-92b0855677ef/c4cdb1e0cb7323649c5187194472b456
And here's an example of it working fine in Chrome:
https://www.evernote.com/shard/s1/sh/fabafc55-d6c3-4c97-8b35-457fb41cbd3f/707f592a55370514bcd5390c86c159e4
Possibly what is being reported here: http://discussion.evernote.com/topic/44574-try-markdown-here-with-evernote-web-for-markdown-support/#entry249618

This is now fixed. There have been significant newline improvements between then and now.
New, working Example:
https://www.evernote.com/shard/s1/sh/5cc51897-73cf-4797-addd-9fe6039281fe/4130fa7227c6c2c0bb10511ae8b397fb


[Task]: DSL call slower than other API calls.

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
In load testing it was found that the DSL call is slower than other API calls, when it just have to get a single record from the DB.
Identify the reason for the slowness and fix it.

List down what the API does, for a layman it should just get a record by ID.
Is the response augmented by details of response from other queries? Is it required? Is it parallel or sequential?
What extra processing does it do on the data, is it required? Is it slowing the API? Can we optimize it? By how much? How does it compare to overall API time.
Check the query plan.

We should do proper performance testing before pushing the changes.

Getting started on this today. @somangshu @SatishGandham @ginilpg

Here are the results for functional analysis of the API. We have found out that the maximum time taken in this API is by the findById function in our backend code, which does a database query to fetch the page by Id in the database.
We found out that the time taken to query records is somewhat proportional to the size of the record from the mongodb (have verified this using a python script as well).
If we want to optimise this API further, we need to optimise the internal mongo query or we update the benchmarking nos for this API.
In this regard, we have started an email thread with Archit from MongoDB, with Somangshu and Shri in CC.
We are waiting on their reply. From a java code POV, there's not much more to what we have already done here.
CC: @somangshu

Closing this with ref to the above explanation.

leaving this issue open as we still need work to be done here.
cc @shubham7saxena7 @rajatagrawal


iOS Build Error - maybe due to some plugin updates

Today I received some errors trying to create a new build for one of my apps on iOS. I've the latest Solar2D build (3710) and Xcode 16.0.
Due to a message indicating to build for iOS 13 I increased the MinimumOSVersion to 13.0 in build.settings, but despite of this the errors persist. I think that the cause of the errors are the update of the plugins plugin.admob and plugin.notifications.v2.firebase, because my app uses both.
The result in console:
ld: warning: -ld_classic is deprecated and will be removed in a future release
ld: warning: Could not find or use auto-linked framework ‘CoreAudioTypes’
ld: warning: Could not find or use auto-linked framework ‘GoogleDataTransport’
Undefined symbols for architecture arm64:
“OBJC_CLASS$_GDTCORProductData”, referenced from:
objc-class-ref in FirebaseMessaging(FIRMessagingExtensionHelper.o)
“OBJC_CLASS$_GDTCORTransport”, referenced from:
objc-class-ref in FirebaseMessaging(FIRMessagingExtensionHelper.o)
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Oct 10 17:06:27.698 ERROR: Builder failed: ld: warning: -ld_classic is deprecated and will be removed in a future release
Oct 10 17:06:27.698 ld: warning: Could not find or use auto-linked framework ‘CoreAudioTypes’
ld: warning: Could not find or use auto-linked framework ‘GoogleDataTransport’
Undefined symbols for architecture arm64:
“OBJC_CLASS$_GDTCORProductData”, referenced from:
objc-class-ref in FirebaseMessaging(FIRMessagingExtensionHelper.o)
“OBJC_CLASS$_GDTCORTransport”, referenced from:
objc-class-ref in FirebaseMessaging(FIRMessagingExtensionHelper.o)
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Oct 10 17:06:27.701 BUILD ERROR: There was a problem linking the app.
            Check the console for more information.

Oct 10 17:06:27.701
Oct 10 17:06:27.818 iOS build failed (2) after 7 seconds
Oct 10 17:06:28.131 ERROR: Build Failed: There was a problem linking the app.
            Check the console for more information.

Oct 10 17:06:28.131

This issue was recently solved due to an update to the plugin "plugin.notifications.v2.firebase".


Extremely slow start-up

I'm not sure if this is happening all the time but as I'm debugging slow-startup of Atom I'm going through each pakage.
Color picker adds 414ms for me: https://www.dropbox.com/s/e6x2u530gdt7r2h/Screenshot 2015-12-03 12.39.03.png?dl=0
Anyone else getting this?

OS and specs?

Ahah, this time it was 63ms. OSX - MBP 13". I think the startup time varies quite drastically, maybe they're affected by other packages? Apologies for not double checking.

I have the same thing


Screen quickly flickers black when start recording from front camera

When I try to record using the front camera the screen quickly flickers before the recording begins.
I am going to assume this is caused by the camera doing sort of configuration right before the filming starts.
If anyone could help me out on this I'd really appreciate it!

I have commented out the metadata capture code in the  startRecordingVideo()  and it worked for me!
open func startRecordingVideo() {
if cameraOutputMode != .stillImage {
let videoOutput = _getMovieOutput()
// setup video mirroring
        for connection in videoOutput.connections {
            for port in connection.inputPorts {

                if port.mediaType == AVMediaType.video && cameraDevice == CameraDevice.front  {
                    let videoConnection = connection as AVCaptureConnection
                    if videoConnection.isVideoMirroringSupported {
                        videoConnection.isVideoMirrored = (cameraDevice == CameraDevice.front && shouldFlipFrontCameraImage)
                    }

                    if videoConnection.isVideoStabilizationSupported {
                        videoConnection.preferredVideoStabilizationMode = self.videoStabilisationMode
                    }
                }
            }
        }
      /*
        let specs = [kCMMetadataFormatDescriptionMetadataSpecificationKey_Identifier as String: AVMetadataIdentifier.quickTimeMetadataLocationISO6709,
                     kCMMetadataFormatDescriptionMetadataSpecificationKey_DataType as String: kCMMetadataDataType_QuickTimeMetadataLocation_ISO6709 as String] as [String : Any]

        var locationMetadataDesc: CMFormatDescription?
        CMMetadataFormatDescriptionCreateWithMetadataSpecifications(kCFAllocatorDefault, kCMMetadataFormatType_Boxed, [specs] as CFArray, &locationMetadataDesc)

        // Create the metadata input and add it to the session.
        guard let captureSession = captureSession, let locationMetadata = locationMetadataDesc else {
                return
        }

        let newLocationMetadataInput = AVCaptureMetadataInput(formatDescription: locationMetadata, clock: CMClockGetHostTimeClock())
        captureSession.addInputWithNoConnections(newLocationMetadataInput)

        // Connect the location metadata input to the movie file output.
        let inputPort = newLocationMetadataInput.ports[0]
        captureSession.add(AVCaptureConnection(inputPorts: [inputPort], output: videoOutput))
        */
        _updateIlluminationMode(flashMode)

        videoOutput.startRecording(to: _tempFilePath(), recordingDelegate: self)
    } else {
        _show(NSLocalizedString("Capture session output still image", comment:""), message: NSLocalizedString("I can only take pictures", comment:""))
    }
}

THANK YOU! This worked for me too.  I really appreciate it!

@kselvin do you have a piece of code that reproduces this? Thanks.


[Thrust] Increase static workspace size

This PR increases the thrust workspace size, since in practice we found that the current workspace size can still be insufficient. Thrust sort may require larger workspace when the number of elements being sorted is large (e.g., in Llama3 that is 128k).

@tvm-bot rerun


[[CHORE]] Update to latest version of Lodash

Version 3 of the Lodash module contains a security vulnerability. That
vulnerability was patched in the 4.17.5 release.
Note that version 4 of Lodash removes support for Internet Explorer 6,
7, and 8. The JSHint project does not formally document compatibility
with web browsers, but the source is currently dependent on Array
prototype methods introduced in ES5. This means that updating Lodash
does not effect the set of browsers supported by this project.
[1] https://hackerone.com/reports/310443
[2] https://github.com/lodash/lodash/wiki/Changelog#v400
Signed-off-by: Mike Pennisi<EMAIL_ADDRESS>

Coverage remained the same at 98.752% when pulling 93e8c84dc83c432b2edc786c56a597d5a711a39a on jugglinmike:update-lodash-2 into<PHONE_NUMBER>b398c97e025bcab6f00580b11128c0 on jshint:master.

Coverage remained the same at 98.752% when pulling 93e8c84dc83c432b2edc786c56a597d5a711a39a on jugglinmike:update-lodash-2 into<PHONE_NUMBER>b398c97e025bcab6f00580b11128c0 on jshint:master.

Coverage remained the same at 98.752% when pulling 93e8c84dc83c432b2edc786c56a597d5a711a39a on jugglinmike:update-lodash-2 into<PHONE_NUMBER>b398c97e025bcab6f00580b11128c0 on jshint:master.

👍

Hi! Any ETA for getting a release out with this change?
Thanks 🙏

@jugglinmike https://github.com/jshint/jshint/blob/master/package.json#L56

Is my face red! We'll be sure to actually update the dependency prior to the next patch release. Thanks for the heads up, @jackschmidt and @vladikoff.


Is it possible to support https://github.com/GoogleContainerTools/distroless?

Dear ap-loader expert,
As we know, https://github.com/GoogleContainerTools/distroless doesn't contains shells, our ap-loader is a wrapper of async profiler which will execute the async profiler shell scripts (https://github.com/jvm-profiling-tools/ap-loader/blob/main/src/main/java/one/profiler/AsyncProfilerLoader.java#L598).
Is it possible to use jattach directly to support https://github.com/GoogleContainerTools/distroless?
Thanks,
Roy

java -jar ap-loader.jar jattach doesn't require a shell to run.

Got it, thanks so much @parttimenerd !  Actually in most of cases, I need to use java -jar ap-loader.jar profiler , I will evaluate async profiler 2.10 as well.


Support dynamic GCS location for newly collected dataset

Current behavior

97_Prepare_Test_Images Nootebook collects and uploads new image data to fixed GCS location (i.e. gs://batch-prediction-collection-3)
Batch Prediction Pipeline's FileListGen only looks up the fixed GCS location to generate a FileList.
This is problematic because FileListGen always use the cached result when enable_cache=True (the same input of the GCS location let the pipeline assume to use cached result).

To be updated behavior

Collected image data from 97_Prepare_Test_Images Nootebook should be stored in a unique GCS location such as gs://batch-prediction-collection-3/YYYY-MM (if we want to store monthly dataset).
Batch Prediction Pipeline's FileListGen should take an GCS location as an input which is a type of RuntimeParameter.
Cloud Function from 04_Cloud_Scheduler_Trigger notebook should calculate the latest GCS location by date, then pass the GCS location to the Batch Prediction Pipeline as an RuntimeParameter.

@sayakpaul
maybe you can work on to modify FileListGen's fixed input to RuntimeParameter.

@deep-diver I think adding a single line of change to the FileListGen might do it:
@component
def FileListGen(
    outpath: OutputArtifact[String],
    project: Parameter[str],
    gcs_source_bucket: Parameter[str],
    gcs_source_prefix: Parameter[str] = data_types.RuntimeParameter(ptype=str),
    output_filename: Parameter[str] = "test-images.txt",
):
    logging.info("FileListGen started")

    client = storage.Client(project=project)
    bucket = client.get_bucket(gcs_source_bucket)
    blobs = bucket.list_blobs(prefix=gcs_source_prefix)
    logging.info("Successfully retrieve the file(jpg) list from GCS path")

    f = open(output_filename, "w")
    for blob in blobs:
        if blob.name.split(".")[-1] == "jpg":
            prefix = ""
            if gcs_source_prefix != "":
                prefix = f"/{gcs_source_prefix}"
            line = f"gs://{gcs_source_bucket}{prefix}/{blob.name}\n"
            f.write(line)
    f.close()
    logging.info(
        f"Successfully created the file list file({output_filename}) in local storage"
    )

    prefix = ""
    if gcs_source_prefix != "":
        prefix = f"{gcs_source_prefix}/"
    blob = bucket.blob(f"{prefix}{output_filename}")
    blob.upload_from_filename(output_filename)
    logging.info(f"Successfully uploaded the file list ({prefix}{output_filename})")

    outpath.value = gcs_source_bucket + "/" + prefix + output_filename

And accordingly the data_gcs_prefix argument of _create_pipeline() method would need to be changed to data_types.RuntimeParameter.
But while reading the code to understand some of the components, I realized we will need to incorporate changes to the following components to support this feature:

SpanPreparator (in particular, this line: image_paths = tf.io.gfile.glob(f"gs://{gcs_source_bucket}/*.jpg"))
PerformanceEvaluator (in particular, how latest_directory is being crafted)

And then we just need to publish the GCS location as a topic to Pub/Sub. I guess this part is yet to be implemented in the notebook or we need to modify this bit:
!gcloud scheduler jobs create pubsub $SCHEDULER_JOB_NAME --schedule "*/3 * * * *" --topic $PUBSUB_TOPIC --attributes name=scheduler #every hour

Let me know if you would like to run something by me or want me to review anything in this regard.

Seems like the current implementation should already take care of that but I wanted to double-check.


Pin an issue that are like guidelines or something (Isn't base engine request) (also leave in the fact that you need to update haxe)

What feature do you want to get added on the base engine?
In the Kade Github In Issues he had pinned his own issue but it was guidelines and crap, I think that would be excellent for this or pin one about PEOPLE HAVING TO UPDATE THEIR HAXE LIKE THERE ARE MORE DUPLICITES ABOUT THAT THEN MY SUS METER
anyways I think this would be great
(I suck at typing sometimes tell me if this makes sense)

like in the title this isn't a base engine request, I dunno how to add a label without a template im dumb

Definitely would be nice

sus meter.

People wouldn't read anyway.


Allow packets to/from ::/0 for SGs which allow packets to/from <IP_ADDRESS>/0

Description
This PR intends to add rules in Security Groups so that communications over IPv6 are allowed for the VMs initiated by Terraform.
Impact
Without this change, installation of CircleCI Server could fail (or at least would not complete within reasonable time) if the targeted VPC has IPv6 enabled.
This is because i) apt-get update here will use IPv6 if the VPC is IPv6-ready and the VM receives an IPv6 address, ii) the apt-get update will not proceed until it times out because the egress packets IPv6 are silently dropped, and iii) the apt-get update could eventually fail, that should cause installation failure in total.
There is no workaround for this issue, as long as IPv6 is enabled for the targeted VPC.
Fixed Issues
No issue ticket is filed yet for this issue. I'm creating this PR as soon as I found the issue.
Contribution checklist
☑ I have read the Contributing Guidelines
☑ Commits have been made with meaningful commit messages
☑ All automated tests have passed successfully

I'm not sure how well our app works with IPv6 since it's not enabled in our SaaS product. Without extensive testing I wouldn't be able to merge this.
We're moving to 3.x versions of server and we may be able to revisit this request in the future.

@ryanwohara Good point.
Just FYI: I'm using CircleCI Server over IPv6 in daily basis for some 6 months, and I have seen no issue with it. (And it should as IPv6 stuff is handled by kernel, i.e. outside of CircleCI containers.)


Search not working

not working at all

Thank you for letting me know! It was a bug from the server, I have fixed it :D


add uuid to action rule inserts

Once https://github.com/ONSdigital/rm-action-service/pull/38 is merged in tests will fail becuase of a table change.
This PR fixes it.

 TBL123: Scheduling Collection Exercise event dates and Action Service actionplan/job trigger redesign (XXL)


plugins/lsp: add htmx lsp

Add support for htmx-lsp.
Fixes #933

Should be noted that this means that nixvim now depends on using nixpkgs unstable. htmx-lsp doesn't exist in release-23.11

Should be noted that this means that nixvim now depends on using nixpkgs unstable. htmx-lsp doesn't exist in release-23.11

Not really, it means that users of the nixos-23.11 branch will not have the option to enable the htmx-lsp  language server.
We do not backport new plugins/options to stable releases.

Should be noted that this means that nixvim now depends on using nixpkgs unstable. htmx-lsp doesn't exist in release-23.11

Not really, it means that users of the nixos-23.11 branch will not have the option to enable the htmx-lsp language server. We do not backport new plugins/options to stable releases.

When I tried to build using release-23.11 it wouldn't even build the derivation because pkgs.htmx-lsp didn't exist

When I tried to build using release-23.11 it wouldn't even build the derivation because pkgs.htmx-lsp didn't exist

Are you sure to have both nixpkgs and nixvim following their respective nixos-23.11 branch ?
This problem sounds like you are following the main branch of nixvim while following the nixos-23.11 nixpkgs channel.

When I tried to build using release-23.11 it wouldn't even build the derivation because pkgs.htmx-lsp didn't exist

Are you sure to have both nixpkgs and nixvim following their respective nixos-23.11 branch ? This problem sounds like you are following the main branch of nixvim while following the nixos-23.11 nixpkgs channel.

Ah, that's probably it! Sorry about that :D

When I tried to build using release-23.11 it wouldn't even build the derivation because pkgs.htmx-lsp didn't exist

Are you sure to have both nixpkgs and nixvim following their respective nixos-23.11 branch ? This problem sounds like you are following the main branch of nixvim while following the nixos-23.11 nixpkgs channel.

Ah, that's probably it! Sorry about that :D

No problem !


add support for .gulprc

Thanks @stefanr, but this change needs to happen in Liftoff. See tkellen/js-liftoff#8 for a proposal on how to make it happen. I'd LOVE a PR for that functionality. I just haven't had time to address it.

I really don't think gulp will support this, so please make it optional @tkellen

It definitely would be. The more general case for this is just allowing liftoff to locate more than one configuration file. What you do with it is your business.


Wrong color for haskell

The haskell community has obviously settled with purple (check out https://haskell.org, https://haskell-lang.org, https://reddit.com/r/haskell, ...). rgb(94,80,134) to be precise.
At the moment GitHub, however, uses green. This should be changed.

We like green. Go away.
Kidding. No, you're right, this should certainly be updated. Though HaskellWiki says DarkBlue, but from the looks of things, I'd say that's outdated.

All done! See #3728. If you're very lucky, this might even be included in the about-to-be-shipped release of Linguist (meaning it'll take effect on GitHub very shortly after approval).

Nice! I was preparing for a day long argument 😂, but cool to see that decisions can actually be made quickly.
There just one thing to clarify: I just realized that it's actually a gradient between rgb(79, 67, 113) and rgb(110, 93, 157) and not a solid color.
So I'm not sure which color should actually be used...
I guess the brighter one?

Hold on, is this based on an official styleguide? You said "rgb(94,80,134) to be precise", which lead me to believe this was being drawn from concrete branding guidelines...
Do you have a link to the official palette perchance?

Sorry, I was maybe a little exuberant with my language. I was looking for a style guide, but there is none. The most official it gets ist the official logo used on haskell.org: https://github.com/haskell-infra/hl/blob/master/design/logo.svg
I just erroneously used a color picker instead of checking the source, which didn't work as expected as it had a gradient. 🙈

When looking for colour choices, I always start with the logo's palette. =)
It's clear that the colour needs to be changed... heck, even Haskell's boring old logo used purple!

From the colours used in the Haskell site's SVG logo, I'd say #5e5086 (sampled from the centre lambda) is probably the best pick. Which is the same shade as the one you've chosen, so... no change necessary.
... there's also no gradient. :o

there's also no gradient

Now I'm really confused. The link I send you is supposed to be the source code for the haskell.org website. So it should be the same file as the link you posted, but obviously it's not 😳
... oh, I see. They have 2 logos in their source code:

https://github.com/haskell-infra/hl/tree/master/static/img
https://github.com/haskell-infra/hl/blob/master/design/logo.svg

and they are slightly different 😭 ... what a fail. I'll open a pull request.
Long story short let's stick with #5e5086 👍

I'm colourblind anyway, so everything that's been mentioned so far looks the same shade of purple to, lel.

Unification of logos issue: https://github.com/haskell-infra/hl/issues/215

They won't do anything about it.
Haskell is lazy, remember?

Cool! The theme was my theme, but based on Haskell's much older purple logo anyway.


Sound can't go to 0 (muted) on iOS and Android

Describe the bug
When changing volume on a device, the volume can't go to 0 (tested on iOS and Android). It feels like a "minimum volume" is set somewhere.
To Reproduce

Use the VideoView component:

<VideoView
  style={{
    flex: 1,
    backgroundColor: Colors.black,
  }}
  objectFit="cover"
  videoTrack={streamerParticipant.getTrackPublication(Track.Source.Camera)?.videoTrack}
/>

Try to reduce the volume to the minimum on iOS or Android, the sound is never muted (volume to 0) as it should be.

Expected behavior
The volume should go to 0 and we shouldn't hear the remote participant.
Device Info:

Device: iPhone 15 Pro (but other iPhones too)
OS: ios 17.4.1

Dependencies Info (please reference your package-lock.json or yarn.lock file):

@livekit/react-native: 2.0.1
livekit-client: 2.0.5
@livekit/react-native-webrtc: 114.0.0

Solved by configuring: https://github.com/livekit/client-sdk-react-native?tab=readme-ov-file#kotlin
Using Expo, this is forcing me to keep an android folder and not having it in the .gitignore then Expo take in into account for builds.

Thanks for the update @Spharian, it's on our roadmap to make Expo integration a lot easier! @davidliu