Add cron recipe to allow per-app scheduled tasks.

Note: WIP.
This adds a recipe that schedules tasks for apps. It simply adds entries to the root crontab
with commands that will be ran within the context of the app.
Mostly a simple wrapper around the cron resource; so we can define per-app scheduled tasks.

They will be ran by deploy user.
The command will be changed to become cd {path_to_app}/current && ( PATH=/opt/rbenv/shims:$PATH RAILS_ENV={your_env} bundle exec {your_command} )
All other attributes from http://docs.chef.io/resource_cron.html will be passed along to the cron resource.

This is a  WIP, so please shoot:

Is this feature needed? (I need it, because I want to schedule some tasks and prefer not to use whenever gem for that).
Do we need a cleaner or more predictable outcome for the command?
Other comments?

@berkes Maybe interesting to look at https://github.com/intercity/chef-repo/blob/master/vendor/cookbooks/backups/recipes/default.rb#L83 since I already implemented a cron cookbook for the backup feature.

For your concerns:
Is this feature needed?
I believe this would make a great addition!
Do we need a cleaner or more predictable outcome for the command?
Can you explain in a bit more detail what you mean with cleaner?
Other comments?
Awesome work :D :cake:

since I already implemented a cron cookbook for the backup feature.

I was aware of that and my recipe uses the same underlying cron LWRP.
The two cron-tasks are a bit different, though.
These new custom tasks are "just any command" and ran by the deploy user (i.e. they are added to the crontab for the deploy user)
Your crontab runs as root and is a fixed command.

Can you explain in a bit more detail what you mean with cleaner?

When you add "command": "rake app:cleanup_old_orders" under "intercity_example" app, my cron recipe will add an entry to the deploy user with the command `+ command = "cd /u/apps/intercity_example && ( PATH=/opt/rbenv/shims:$PATH RAILS_ENV=production bundle exec rake app:cleanup )"
In other words: it adds a lot of extra commands and cruft to the command a user entered. This might cause weird behaviour when the user adds complex commands himself.
For now, I'd say a warning in documentation is in place, but we might want to add a user-settable flag to avoid adding our own commands around the users' command in future.

@jvanbaarsen @michiels how do you think this should best be integrated?
How to include it:

as a recipe under the 'rails' cookbook?
as a separate cookbook (as proposed in this PR, but moving to the 'rails' cookbook is easy)

Where or when to run it:

as a role?
as an includable recipe?
default included in the rails::setup recipe?
default included in the base role? (ugh, ugly)
default included in both the rails and rails_passenger roles?

IMO this should simply always be ran, therefore I don't really like the options where people have to include these as roles or recipes themselves.


Major EXO Workload Refactoring

Pull Request (PR) description
Changed logic to handle the minimum number of EXO sessions;
This Pull Request (PR) fixes the following issues
#72

Codecov Report

Merging #73 into Dev will increase coverage by 1.49%.
The diff coverage is 89.3%.

@@            Coverage Diff             @@
##              Dev      #73      +/-   ##
==========================================
+ Coverage   88.08%   89.57%   +1.49%
==========================================
  Files          36       36
  Lines        3038     2677     -361
  Branches        1        1
==========================================
- Hits         2676     2398     -278
+ Misses        361      278      -83
  Partials        1        1

Impacted Files
Coverage Δ

...FT_EXOAntiPhishPolicy/MSFT_EXOAntiPhishPolicy.psm1
84.31% <100%> (+6.98%)
:arrow_up:

...FT_EXOMailboxSettings/MSFT_EXOMailboxSettings.psm1
100% <100%> (ø)
:arrow_up:

...SC/DSCResources/MSFT_TeamsTeam/MSFT_TeamsTeam.psm1
94.44% <100%> (ø)
:arrow_up:

...SCResources/MSFT_EXOMailTips/MSFT_EXOMailTips.psm1
93.1% <100%> (-0.45%)
:arrow_down:

...Policy/MSFT_EXOHostedOutboundSpamFilterPolicy.psm1
89.47% <100%> (-0.27%)
:arrow_down:

..._EXOClientAccessRule/MSFT_EXOClientAccessRule.psm1
87.3% <100%> (+3.21%)
:arrow_up:

...FT_EXOSafeLinksPolicy/MSFT_EXOSafeLinksPolicy.psm1
85.71% <100%> (+2.58%)
:arrow_up:

...s/MSFT_EXOSharedMailbox/MSFT_EXOSharedMailbox.psm1
93.33% <100%> (-0.18%)
:arrow_down:

...XODkimSigningConfig/MSFT_EXODkimSigningConfig.psm1
86.15% <100%> (+2.06%)
:arrow_up:

...AttachmentPolicy/MSFT_EXOSafeAttachmentPolicy.psm1
85.96% <100%> (+3.46%)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350e85e...fe4d2d0. Read the comment docs.


[Test/Meson] common dependency

Use predefined dependencies in meson script.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #304. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Use Madoko INCLUDE directive for grammar excerpts within the spec

Note: This PR intentionally only uses the Madoko INCLUDE directive for 4 or 5 of the grammar excerpts in the specification.  Many more could be similarly done like this, but this PR was created quickly merely as an example of what could be done throughout the specification, so that spec maintainers can see what the resulting Madoko file would look like.

Is there a strong reason not to show the full production, in some cases?  Is it primarily for focusing on a few of the production rules being presented in that section of the spec?

That's right

After 3 commits on this PR, I have replaced all occurrences of grammar rule definitions in the file P4-16-spec.mdk with Madoko INCLUDE directives, but ONLY for the ones where the definition in the file grammar.mdk was functionally identical to the one that resulted from replacing it with the INCLUDE statement.  Usually this was also textually identical, but in a few cases the order of some of the alternatives was different, but I left them in the order they were in the grammar.mdk file, because with recent changes made there, those orders match the order of corresponding grammar rules in p4c, for easier text-based comparison between p4c and grammar.mdk.
There are only about 10 or so grammar rules left as they were in P4-16-spec.mdk.  Those are either the ones that were partial rules, or were in some other way not functionally identical with the ones in grammar.mdk.  Those we could consider whether they should become identical between them, but not in this PR.

I reviewed one more time the grammar rules in P4-16-spec.mdk that had NOT yet been replaced with Madoko INCLUDE directives, and found 3 more that were equivalent between the two, and thus also replaced them with INCLUDE directives.
There remain only 3 non-terminal definitions in P4-16-spec.mdk that are not identical to the corresponding definition in grammar.mdk, and also do not appear to be excerpts.  I will file a separate issue on the spec to record those, in case someone wants to think about how to address them.
In the mean time, since this PR makes no functional changes to the spec, only in how the Madoko source looks in producing it, I will go ahead and merge this in with Mihai's one approval.


[mars branch] Remove old reflex platform

See commits for details

https://ci.obsidian.systems/push/b60eeac359af9a4b759cdf14b4b2751fe1f28cd5 CI was already broken on this branch, FYI.


command not found: nvm

Operating system and version:
Arch
nvm debug output:

nvm ls output:

How did you install nvm?

What steps did you perform?
What happened?
What did you expect to happen?
Is there anything in any of your profile files that modifies the PATH?

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

Please fill out the issue template in full; it's there for a reason. Happy to reopen once that's done.


fix(menu): Correctly renderToPortal for menu

Collaboration between @develra and @EmiBemi.
@EmiBemi raised a valid point that on initial render, the menu is still in the wrong position if the menu starts as open. It would be good to find a better solution to this issue long term.

Fixes https://github.com/rmwc/rmwc/issues/800
Reverts https://github.com/rmwc/rmwc/pull/741 as it proves to have introduced a new bug

Codecov Report
Base: 80.67% // Head: 80.50% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (4199669) compared to base (12b4c44).
Patch coverage: 95.65% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   80.67%   80.50%   -0.17%
==========================================
  Files         107      107
  Lines        3337     3340       +3
  Branches      767      770       +3
==========================================
- Hits         2692     2689       -3
- Misses        640      646       +6
  Partials        5        5

Impacted Files
Coverage Δ

src/base/portal.tsx
80.76% <90.90%> (+15.55%)
:arrow_up:

src/menu/menu-surface/foundation.tsx
73.85% <100.00%> (+0.47%)
:arrow_up:

src/menu/menu-surface/index.tsx
100.00% <100.00%> (ø)

src/select/select/foundation.tsx
77.11% <100.00%> (ø)

src/list/foundation.tsx
65.83% <0.00%> (-8.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


relayer: make relayer notify ticker configurable

Proposal Details
background:

in present, relay_tick_in_seconds is fixed (1 second)
1 second maybe too short for Relayer.sync job (l1bock/l1_tx_list), the msg queue may be filled with meaningless sync requests
actor system we used is coerce which use tokio's unbounded_channel, may run out of memory

approach:

make it into config (relayer config)
try to find a more reasonable interval, or split l1block/l1_tx_list sync logic

after minutes review, coerce is using oneshot channel as Timer's msg queue. No issue with OOM


[ADP-2377] QueryStore for TxWalletsHistory

Overview
This pull request implements a QueryStore for the TxWalletsHistory by storing the TxSet in the database on disk.
Comments

By storing the TxSet on disk, we should get back some RAM.
We could reduce RAM usage further by keeping MetasAndSubmissionsHistory on disk.

Issue Number
ADP-2377

Note: We postpone merging this until ADP-2660 has been implemented (and can be merged immediately afterwards) due to performance issues with GarbageCollectTxWalletsHistory.

bors try

Change of plans: Fixing the issue with GarbageCollectTxWalletsHistory requires more extensive changes.
I'm going to apply our battle-tested tactic of "add first, swap later", where we add the QueryStore and its tests, but perform the switch in the implementation of the DBLayer in a later pull request.
The full outline can be found here: https://github.com/input-output-hk/cardano-wallet/pull/3739 . I'll cherry-pick it.

Obsoleted by #3757 .


[move-to-yul] Refactor dispatcher to support solidity signature

Motivation
To support interoperability between Move contracts and contracts written in other languages such as Solidity, external signatures need be defined. We cannot direct use the function signatures in Move because types are not compatible. Moreover, parameters in a solidity interface with array, struct and mapping types must be specified with a data location. Moreover, function selectors and ABI-related code in the Yul program should be generated based on this signature.
In this PR, we allow users to specify a solidity signature for callable Move functions. The signature is specified as an ascii string in the callable attribute. For instance, the signature of the function safeTransferFrom in ERC721 can be specified as #[callable(sig=b”safeTransferFrom(address,address,uint256,bytes memory)”)] in the Move program. The function getApproved can be specified as  #[callable(sig=b”getApproved(uint) returns (address)”)].
The compiler would also check whether the user defined signature is compatible with the Move signature. For instance, the range of a solidity uint type must not exceed its Move correspondence.
If a solidity signature is not explicitly specified, the compiler will translate the signature of the Move compiler into a compatible solidity signature.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Baseline tests are added to the test-dispatcher/signature-parsing-test for testing parsing the signature and checking the type compatibility. Semantic tests for dispatcher will be added in a separated PR.

/land


Fix: fix the cpu-model issue for s390x.

mpx(Memory protection Extension) feature is not supported on s390x. it is making the qemu-kvm to fail when creating a vms with cpumodel with below error qemu-kvm: can't apply global z14-base-s390x-cpu.mpx=off: Property 'z14-base-s390x-cpu.mpx' not found'
so skipping the mpx cpu feature validation for s390x.

What this PR does
Before this PR:
the cpu-model tests are failing for s390x due to mpx flag
After this PR:
the cpu-model tests are passing for s390x.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

     fix the cpu model issue for s390x.

/cc @xpivarc

/cc @Barakmor1

I have changed the vmi from Cirros to Alpine for the default cpu model tests because Cirros is not supported on s390x.

/lgtm

Can you move the test related changes into a separate commit with explanation for their need please?

Hi @0xFelix I have split the test related changes into a separate commit with the explanation.

/lgtm
Thank you @vamsikrishna-siddu for adding the unit-test.

lgtm, however. I would expect libvirt's domcapabilities to have some indication about what flags are supported.
I'm sure that we will discover more unsupported flags. Adding these one by one won't be feasible.


[sw/dif] Remove LFSR mode from entropy_src

Remove LFSR mode in preparation for hardware changes. Update entropy
smoketest as well.
Software changes related to lowrisc/opentitan#7349
Signed-off-by: Miguel Osorio<EMAIL_ADDRESS>

Hi @tjaychen, does the AST block provide entropy by default in Verilator and FPGA environments, or is there a register write required to enable it?


broken " long-polling HTTP requests " link

https://github.com/Open-EO/openeo.org/blob/17e41f6bdee0248712a67eb13776d9273248d9c3/documentation/1.0/glossary.md?plain=1#L71
broken link https://www.pubnub.com/blog/2014-12-01-http-long-polling/

I would just drop the whole for long-polling HTTP requests thing, it's not that vital. I'm not sure "polling" is even the right terminology in this context

New URL is https://www.pubnub.com/blog/http-long-polling/

So you would prefer to keep this link to this pubnub (which I don't know FYI)?
As mentioned above I would just drop the mention of long-polling as a whole.

No strong preference, but an explanation would be good.
Could also just be: "... should be executed using this approach as timeouts are to be expected for HTTP requests that are kept open for more than a couple of seconds."


Write a test

Any kind of test. Just to get testing rolling.

In the future, testing could use for example Selenium. Some smoke test that

Opens browser
Clicks the component
Uploads a file to a temporary folder
Checks that the file was uploaded

would help a lot!

I checked out a little bit about how this could be done.
There was previously package called pytest-dash which is now deprecated in favor of dash.testing, which is a toolbag for testing dash applications and components.
I also did some scouting of popular dash component packages to see how others have solved this.

dash-bootstrap-components. Using nox and pytest with a --headless flag (noxfile.py). They seem to use the dash_duo pytest fixture (tests/test_navlink.py)
dash-html-components  has this kind of test_integration.py again using dash_duo fixture.
dash-core-components has separate folder for unit tests which are tests in JS world, and then folder for integration tests which seem to be written in python.  One interesting note is that they seem to take "printscreens" with percy tests/integration/upload/test_children_accept_any_component.py. That might be an overkill for this component at least this stage, though.

I guess the first step would be to just have simple test using the dash_duo fixture.

Closed via https://github.com/np-8/dash-uploader/commit/b1cf75683c27205013add9338798fb646ebe1957


Telemetry opt-out should be set in the user profile

Describe the bug
Instead of allowing users to opt-out in the welcome message we should allow them to opt-out via a setting in their profile. This is in line with other industry tools we've analyzed and balances the desire for telemetry with the user's ability to opt-out.

Option to opt-out of user-anonymized data sharing should be removed from the pop-up modal which comes when one logs into Automate.


Ant: Parameterize Schematron XSLT file path

This pull request derives from #407. So needs to be handled after that.

This pull request implements an Ant feature analogous to the command line SCHEMATRON_XSLT_INCLUDE, SCHEMATRON_XSLT_EXPAND and SCHEMATRON_XSLT_COMPILE.
The usage is demonstrated in the test.

Although this pull request contains a lot of commits for historical reasons, all that needs to be reviewed in the end is a single commit (6844acd51621d6a09c38f37761fc93dfa589b68a).

@cirulls
Merged this enhancement.
I'll probably document the added Ant properties after merging #411.

I'll probably document the added Ant properties after merging #411.

Filed as #555.


About the Camera Embedding

Great Work!
I want to fine-tune this model with my own dataset. Could you please provide some information about the camera embeddings? Thanks for your time again!

Lines 22-23 was aimed to convert cameras from OpenGL to OpenCV coodinates. Blender render objs in OpenGL coordinates. Again the camera matrix here is world2camera transformation. You could use np.linalg.inv(camera_matrix) to convert it to camera2world matrix.
A standard process of using your own dataset will be using the rendering script from Objaverse Dataset to render you 3D models and directly load the save json files of it using the read_camera_matrix_single function.
To summary, differences in camera lies in CV&&GL coordinates and c2w&&w2c transformation. Try to figure out what you camera matrix is and apply corresponding transformation is enough.


Suggestion: Custom footer string

Search Terms
custom, footer, string, hide, generator
Problem
By using the --hideGenerator option, the message "created by TypeDoc" is removed, but the footer is still there. It might be nice to include an option to customize what is written in the footer instead.
Suggested Solution
--footer "should support html"

Sure, seems like an easy customization to allow

Hello @Gerrit0. I would like to work on this issue.

Go for it!

There's already a plugin for this: https://typedoc-extra-footer.8hob.io/

There's already a plugin for this: https://typedoc-extra-footer.8hob.io/

Please don't avoid adding any features because there is a plugin. Plugins don't work with all versions of Typedoc

I don't oppose adding this feature to typedoc, (although architecture-wise I think typedoc should leave these kinds of specialized theme customization options to plugins, even as builtin ones.)
However, as the author, I think the behavior defined in the plugin above is better designed. Specifically,

If the custom footer and --hideGenerator are both specified, don't hide the custom footer. Instead, add the custom footer after the generator text.
Add a default style if the customer footer is plain text. This permits users with not much HTML and CSS knowledge to use without struggling making the footer look reasonable.

What do you think?

I am more interested in adding markdown pages to the documentation.
As of now, I just employed a quick hack - https://react18-tools.github.io/react18-global-store/
But, I believe that this is a very important part of documentation and should be supported by the library.

In general, I agree with @xuhdev, the more specialized functionality I can push to plugins, the easier to maintain TypeDoc itself stays, which makes it easier to maintain. I also mostly agree with the builtin plugin approach, though unfortunately it is messier than I'd like due to other constraints (options are all declared in one place for TypeDoc so that http://typedoc.org/schema.json can be easily generated, in 0.26 option descriptions are translated, and I'd really like to not spread the translatable strings all over the place to make it easier for translators)
That said, having worked places where getting plugins for approved software was a nightmare, I think it's important that it be easy to customize TypeDoc without requiring a plugin for everything. This is why the --customCss option exists, despite being easily implemented with a plugin.
I don't love making one option's behavior dependent on another option, as is done in typedoc-plugin-extra-footer, but can't argue with the improved user experience regarding adding the
 wrapper...

@mayank1513 see #2567

Included in TypeDoc 0.26, which is releasing 2024/06/21

Can you also explain how to use this feature.

Exactly as proposed in your original post, with the option name customFooterHtml


themable debug icons

For https://github.com/microsoft/vscode/issues/92791

no more codicon references in code
define debug specific icon name for reused icons

@isidorn You might want to look at the names and descriptions given in https://github.com/microsoft/vscode/pull/111183/files#diff-66eeaa212162fdffb80b665f45fa68fd3f66c27504635227161fb9efa41edf27
I double/trippled checked that I didn't introduce any regressions, but from experience there are always one or two...

@aeschli thanks a lot for cleaning this up, really appreciate it.
I did a review of your changes and they look great - I left some minor comments in the PR.
I would like that we merge this as soon as possible so we catch breakages in Insiders -> thus approved


Added basic filter support for JsonPathParser

Added basic filter support for JsonPathParser.
Plus a few tests to support it

fixes #125

@Punctuality Can you please run:
sbt "scalafmtAll;scalafixAll"

So that we fix the formatting issue, thanks :)


chore: format package.json files with prettier

Runs prettier on all package json files. This will make reviewing https://github.com/elizaOS/eliza/pull/1365 easier.

@twilwa why was this basically reverted in the most recent release?

Hi @ryanleecode it was not reverted. The script that handles the version changes in the package.json files reformats the files.

Hi @ryanleecode it was not reverted. The script that handles the version changes in the package.json files reformats the files.

If the script formats using prettier, then it should be 4 spaces, since that was the point of this pr in the first place.

#1573


fundingmanager: change funding messages to use server.sendToPeer

Previously, during the channel funding process, peers sent wire
messages using peer.queueMsg. By switching to server.sendToPeer, the
fundingManager is more resilient to network connection issues or system
restarts during the funding process. With server.sendToPeer, if a peer
gets disconnected, the daemon can attempt to reconnect and continue the
process using the peer’s public key ID.

We'll also track down that issue with the mismatching protobufs later, as the issue isn't enough to block the merging of this PR.


QuickadminMenuController.php line 343: Undefined index: parent_id

hello there,
i try to edit menu that have no parent, or this menu as parent it return
QuickadminMenuController.php line 343: Undefined index: parent_id
i think a little bug here
i change
 if ($requestArray['parent_id'] === "null") {             $requestArray['parent_id'] = null;         }
into
`if (!isset($requestArray['parent_id'])) {
        $requestArray['parent_id'] = null;
    }`

couse
dd($requestArray);
there is no key [parent_id];
so i change to isset instead of === 'null'
thanks

Hello,
Thanks for contacting us, we will look into this bug a bit later today. In the mean time, you can feel free to contribute and submit your solution as a contributor!

Reopening issue because it was not solved from our side

This issue should be solved


Can't login to omnidb server

Hi all, I've just installed omnidb on my Win 10 pro box and tried to login using admin / admin but it fails with invalid token - any ideas ?

Hello @pkfox ,
The windows installer automatically creates two executables for you:

omnidb-app.exe - for a single user as a desktop application
omnidb-server.exe - allows multiple users and requires a login, to be accessed from the browser

Since you are trying to login, I assume that you are willing to use the server solution that allows multiple users, and so you are trying to access OmniDB from the browser. In this case, could it be that you are starting it from the app executable instead of the server?
If this is the case, you should start it using the omnidb-server.exe, and then you should have success. The app executable will immediately launch the dashboard.
Please let us know if this solves your problem or if you have any questions.
We will further improve this and the documentation.
Best regards

Hello I installed OmniDB and when I open the app, it is said "INVALID APP TOKEN" and the app wont open.
Do you know how can I fix this issue?

Hi guys, please post screenshots so we can have a look at what you're doing exactly and the errors.

Greattttttttt!!!!!! Thank you so much. You solved my issue.
I am now able to use OmniDB app again.
Thanks.


code is unreadable

the code is unreadable, its very suspicous and makes it hard for other people to read it.

its obfuscated

@rxzyx please make your code open so people can confirm the authenticity of this code. Duolingo will patch it either way, and obfuscated code destroys trust.


[Doc-issue][Update meeting-app-extensibility]

adding a screenshot

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4a8050f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md

Line 84, Column 11: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c8a405e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/enable-and-configure-your-app-for-teams-meetings.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/apps-in-meetings/in-meeting-dialogbox.png
:white_check_mark:Succeeded

msteams-platform/apps-in-teams-meetings/enable-and-configure-your-app-for-teams-meetings.md

Line 139, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/apps-in-meetings/in-meeting-dialogbox.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d9cf4f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 50779f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b3aac0f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:warning:Warning
View
Details

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md

Line 58, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'Tabs during a meeting' is duplicated. Within an article, alt text must be unique.
Line 84, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/apps-in-meetings/desktop-in-meeitng-view.png'.
Line 84, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'Tabs during a meeting' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d5dc0c9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:warning:Warning
View
Details

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md

Line 84, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/apps-in-meetings/desktop-in-meeitng-view.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e9aa2f9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:warning:Warning
View
Details

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md

Line 84, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/apps-in-meetings/desktop-in-meeting-view.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
97
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e41d95c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/meeting-app-extensibility.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/apps-in-meetings/desktop-in-meeting-dialog-view.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Support @BeforeEach and test cases referring to same cluster

Type of change

Enhancement / new feature

Description
Users can now refer to the same cluster from an @BeforeEach annotated method and the subsequent test method.
For example:
@BeforeEach
public void setup(@Name("clusterA") KafkaCluster cluster) {
    .. do setup work ..
}

@Test
public void test(@Name("clusterA") KafkaCluster cluster) {
    .. do test work ..
}

As a consequence it's now legal to have multiple references to the same cluster as long as later declarations only supply an @Name annotation and no constraint annotations (because re-declaring constraints for a cluster that already exists can't be done).
legal example
public void test(@BrokerCluster(numBrokers = 2) @Name("clusterA") KafkaCluster cluster, @Name("clusterA") KafkaCluster clusterRef) {
    .. do test work ..
}

illegal examples
public void test(@BrokerCluster(numBrokers = 2) @Name("clusterA") KafkaCluster cluster, @BrokerCluster(numBrokers = 1) @Name("clusterA") KafkaCluster clusterRef) {
    .. do test work ..
}

// we disallow any constraints even if they're identical
public void test(@BrokerCluster(numBrokers = 2) @Name("clusterA") KafkaCluster cluster, @BrokerCluster(numBrokers = 2) @Name("clusterA") KafkaCluster clusterRef) {
    .. do test work ..
}

Additional Context
Why:
We might want to extract some common setup to an @BeforeEach annotated method and have it refer to the same cluster as is used later in the test. For example to create some topics or assert some pre-conditions like cluster size for all cases.
Note this changes an existing behaviour where it was not allowed to have multiple KafkaClusters injected using the same name. This makes sense because a KafkaCluster declaration also implies the constraints required and the multiple declarations could have different constraints. So with the new change a parameter is allowed to refer to a cluster instantiated earlier, but not supply any constraints.
Checklist

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Planning to create a second PR which makes the @BeforeEach plus KafkaCluster combination not supported as I can see it could be seen as invalid to have multiple KafkaCluster declarations with this special meaning for a second declaration with no constraints (the empty set of constraints is still a constraint set).
Other ugly alternatives, have a flag or something on the Name annotation like reuse=true or add a new annotation like @Reference to capture the distinction.

Note this changes an existing behaviour where it was not allowed to have multiple KafkaClusters injected using the same name. This makes sense because a KafkaCluster declaration also implies the constraints required and the multiple declarations could have different constraints. So with the new change a parameter is allowed to refer to a cluster instantiated earlier, but not supply any constraints.

I think this is legitimate, injecting a cluster with the same name but different configuration seems like a bug to me, even if done intentionally it would make the tests very hard to reason about. So I'm fine with relaxing the restriction so that @Name can be a pointer as well as a restriction.

Oh and a note, it doesn't work with anonymous, un-named KafkaCluster. Every anonymous cluster declared is still unique. So you have to name your cluster for this @BeforeEach to refer to an existing cluster.


Rename getip to get-ip

More in line with create-firewall and delete-firewall. Prefer verbosity over saving a character.

+1


GPSPRINGSECURITYCORE-213: Add support for BASIC auth logout

Original Reporter: burtbeckwith
Environment: Not Specified
Version: Not Specified
Migrated From: http://jira.grails.org/browse/GPSPRINGSECURITYCORE-213

See http://stackoverflow.com/questions/233507/how-to-log-out-user-from-web-site-using-basic-authentication


Expose more of the HttpClientRequest to Interceptors

We can easily modify an intercepted request, but not see into it that well. We should ideally be able to retrieve:

HTTP Verb
URI
BodyContent (this should only be available if not streaming I guess)
The Headers as a map
Query Parameters as a map

I think we might be good with this


Fix Distribution#new,#create,#edit,#index to only show active items

Resolves #3988
Description
Previously we were showing inactive items in the item dropdown for distributions in some situations. When we render the page, inactive items were shown, but after the ajax call to fetch inventory quantities (like when a storage location is selected) the inactive items were removed.
After this change, inactive items are never shown.
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Added new request specs and tested manually.
An easy way to test this manually is to disable Javascript in the browser (I used ublock origin for ad blocking and it provides an easy way to toggle javascript on and off).
Otherwise if you try to edit a distribution currently, the ajax call to update the item dropdown might occur too fast for you to see the inactive items.
If testing manually, the /distributions, /distributions/new (both before clicking save and after clicking save with validation errors), and /distributions/edit pages all had this issue.

@coalest -- I haven't dug in as yet -- does this cover off the "gotcha" mentioned in the comments -- i.e. that there could be inactive items in distributions that are being edited?    (I expect its in the rare-but-could-happen category).

@cielf  Whoops, I missed that comment about inactive items wanted to appear when editing distributions.
What about the /distributions page? Should users be able to see inactive items in the filter?

Yeah -- I remembered that after I'd walked away from my machine.   (It's a realtively recent change.)

Ok, so then the only issue to fix is for new distributions?

Right.   Stopping people from editting old distributions with inactive items rendered the gotcha moot.

I guess the current flow for a user wants to add inactive items to an old distribution:
Make inactive item now active
edit the distribution to include it
make the item inactive again.

So I will inactive items visible in the item dropdown filter on the distributions index page, because the issue didn't say anything about changing that?

Technically  more than that.   That's the workflow if you want to edit a distribution that happens to have inactive items (for some other reason).     All inactive items by rule have zero inventory,  so if you actually  needed to add inactive items to a distribution,  you'd have to add the inventory.   But if you're doing that,  the item really isn't inactive, anyway...

I think they should be able to see inactive items in the filter, because they might be looking to export the information about them.

In that case, this PR is now ready for review. (I force pushed and reverted the change I had made to the index page)


Move redirectUri and its verifier into common core

Proposed changes
Move MSALRedirectUri, MSALRedirectUriVerifier(iOS and Mac) and unit tests into common
Type of change

[ ] Feature work
[ ] Bug fix
[ ] Documentation
[x] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Just for clarification: later will you refactor code in MSAL to using the RedirectUriVerifier of MSID instead the current in MSAL?

Yes, I will do :)


Feat/359 add tokens to mm

Closes #359
Adds env after the asset you are adding (unless on mainnet):

Prompts after claim:

Prompts on vesting page:

@dexturr Whats the status on this can we rebase and get it merged?

LGTM 👍


TypeError: goober.keyframes is not a function

react-hot-toast version 1.0.1
I am getting this error when I try to run a test on a file that uses react-hot-toast
TypeError: goober.keyframes is not a function

Hi! did you have any advance with this?

Not a great solution - but a solution none the less:
jest.mock("react-hot-toast", () => ({
  Toaster: () => <>test</>,
}));

I'm having the same issue

Also experiencing this in a webpack bundle. Using yarn, I added to my package.json resolutions field as a workaround:
  "resolutions": {
    "goober": "2.1.9",
    "react-hot-toast": "2.2.0"
  }

Is there any visibility on this? Not being able to test any pages/components with toasts on prod apps seems like a pretty big deal

Downgrading to "react-hot-toast": "^2.2.0", from v2.4.1 (current latest) worked for me


fix(iconbutton): handle activation click

fixes https://github.com/material-components/material-web/issues/5532

@asyncLiz I followed the same idea as <md-text-button>, however to be totally honest I don't know if that's good or not. Requesting your review.

The form label activation is used to make <label> work with some wrapped elements like <input>. I think it's fixing the issue as a side effect by forwarding clicks.
Can we try overriding the click method instead? I think it makes more sense to forward the initial click to the delegated element, rather than trigger a host click which re-triggers a button click.
override click() {
  this.buttonElement?.click();
}

If it's more complicated then I'm open to the current approach, but I want to add some documentation to explain what's going on.


Using this code with own data

Hi! And thanks for making this code available.
I have a data set that consists of:
A set of 3d points (xyz values);
A set of 2d points (xy pixel values)
A camera matrix (fx,fy,cx,cy, 5 distortion params)
Is it possible to run your code with this data?
Also, related question:
Where can I pass in my own data?
Thanks!

Hi! Yes, the network is designed for pure geometric inputs (3D and 2D points, without visual features or RGB values), so your data should be well suited.
Your 2D points should be K-normalised dehomog( K^{-1} homog(p) ), where homog converts to homogeneous coordinates and dehomog reverses that.
And you'll need to write your own Dataset class (see utilities/dataset_utilities.py), where getitem returns a tuple of the form:
2d_pointcloud, 3d_pointcloud, true_rotation_matrix, true_translation, true_correspondences, num_points_2d, num_points_3d

Hi Dylan, thank you for getting back to me.
Can you please explain this for me?
Your 2D points should be K-normalised dehomog( K^{-1} homog(p) ), where homog converts to homogeneous coordinates and dehomog reverses that.
What does that look like in code?  Thanks again

It just means that you append a 1 to your 2D coordinates, pre-multiply by inverse K (camera matrix), and then remove the final coordinate (which will be a 1).
Something like
p = torch.matmul(torch.inverse(K),  torch.nn.functional.pad(p, (0, 1), "constant", 1.0))
p = p[:, :2]


Adds optionable support for obeying robots.txt

Usage:
# To have this work add "gem 'robots', '~> 0.1'" to Gemfile
Spidr.site(
  'http://matasano.com/',
  :robots => true
)

Closes #11

Eh, I prefer to ignore robots.txt and spider everything. I do like the idea of providing the option though. Instead of adding it to allowed_links, I think it should be added to Spidr::Agent#visit?.

Something like e2c2883? Its not finished yet, I haven't added any tests yet. Just wanted to get your feedback first :)

Yeah, but get rid of the NoRobots null object. Just do a @robots && @robots.allow?(uri). Note that Robots#allowed? accepts URIs. Also, should robots be all or nothing, or configurable per host?

I removed the null object, and did @robots ? @robots.allowed?(uri) : true to have it return true if options[:robots] is falsy.
My guess is that in most cases you would either respect it for all hosts or just ignore robots.txt completely. What do you think?


Enable editing of controls inside viewports in editor

Fixes #79289
I've tested:

Selection
Box Selection
Anchors
Moving
Rotating
Scaling
Pivot
Temporary pivot
Smart Snapping
Grid Snapping
Helpers
Focus

Bugsquad edit:
Fixes #20619
Fixes #60088

Some nodes have an incorrect gizmo position when in a Viewport not at the origin, like position indicators for Node2Ds or handles for Line2D, CollisionShape2D, etc.

Selecting works and using the handles works, they're just offset and not rotated or scaled.
Also, If the viewport gets rotated or scaled, using the move or scale tools aren't correct, though the resize gizmos are fine.

On GUI in 3D, I can see the editing controls and interact with them, but nothing appears in the 2D editor viewport:

They also do not appear in 4.3 and in master. This is intentional since SubViewport do not draw anything by themselves. In that scene, the SubViewport is rendered to a MeshInstance3D, so it will only show in the 3D Editor.
So instead, the nodes in a SubViewport without a SubViewportContainer should not be selectable or editable in the canvas editor.

Thanks!

Unintended consequence is that you can move nodes outside current scene, which is probably what the original check wanted to prevent:
https://github.com/user-attachments/assets/d5451ebe-df40-49cb-a763-dfe3a539200b
Granted, you need a custom EditorPlugin to select such nodes. We could use in_part_of_edited_scene() to prevent this, but it's not really a problem I think 🤔


Fix linspace interface

This should fix the issue of sometime missed end point while preserving the rounding properties and handling of stop not fitting the step. Actually I added some test for that. I am still concerned with floating point rounding issues so if anybody has some ideas about how to test for more of those I am taking.

Current coverage is 98.29% (diff: 100%)

Merging #79 into master will increase coverage by <.01%

@@             master        #79   diff @@
==========================================
  Files           155        155
  Lines         12310      12313     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          12100      12103     +3
  Misses          210        210
  Partials          0          0

Powered by Codecov. Last update 9cde9bd...8a72b78

I just realized that the code was going to misbehave in one case (start with more digit than step) and fixed it (and added the matching test). I would still like a review @Ecpy/owners

I would say that you should put 'digit' and not 'stop_digit' at line 92, otherwise, in case of a step with more digit than the stop, it will ends with a step which can be different from the specified one by the operator. don't you think ? But maybe I didn't understood the goal in case of a stop not fitting the step. For me it is the stop that has to change and never the step...

Good catch @tcubaynes indeed if the stop is wrong, we need to be sure that the new stop won't cause any issue which could be the case if it rounded improperly. One test case would be start: 0.5, stop: 1.0, step: 0.2 which needs to yield 0.9 as new stop and not 1.0. Actually we need also to be careful with start number of digit (0.501, 1.0, 0.2 -> 0.901) so using the max of all three would probably be better.
I will try to address it tonight.
BTW you can comment inline by clicking the small blue + button which appear when your mouse is over the line number.


Add data bag JSON validation rule

Resolve #269

I like it. Could you rebase on master, bump the rule number and provide some tests? Also, this could be expanded to all json, not only databags.

I'm going to close this one since we haven't heard back from the author in over 2 years. @john-karp If you're still interested this would be a great rule with a test


Fix badge for appveyor build status

Hey, just a small suggestion:
The appveyor badge on readme is showing the build status for all branches while it should display only the master branch.
You can go to the appveyor settings/badges and copy/paste the markdown code to display the build status only for the master branch (the URL is using some sort of GUID private to your project, so I can't figure it out)

Thanks, it's now fixed!


Fix OrgScore2_1_1 to pass if Bluetooth is off but there are paired devices

Machine has Bluetooth off and two paired devices:

Before:
2.1.1 Turn off Bluetooth, if no paired devices exist (Automated) | 1 |   | Failed |   | Script | No Paired Devices
-- | -- | -- | -- | -- | -- | --

Scored as a failure and erroneously reports No Paired Devices
After:
2.1.1 Turn off Bluetooth, if no paired devices exist (Automated) | 1 |   | Passed |   | Script | Paired Devices: 2
-- | -- | -- | -- | -- | -- | --

Passes and correctly identifies two paired devices.

Thnx, for the logic fix if Bluetooth is off!


Hide comments added previously by actions-planpreview

What this PR does / why we need it:
Hide the previous comment added by actions-planpreview.
With this change, only hide one comment at a time.

Which issue(s) this PR fixes:
#3030
Fixes #
Does this PR introduce a user-facing change?:

Plan-preview GitHub action automatically hides previously added comments before adding a new one

/cla sign

Wow. Love this. ❤

Could you update to use the latest version of pipectl?
https://github.com/pipe-cd/pipecd/blob/master/dockers/actions-plan-preview/Dockerfile#L5

And please update this to 0.13.0. It will be the new release version.
https://github.com/pipe-cd/pipecd/blob/master/dockers/actions-plan-preview/DOCKER_BUILD#L1

currently, the version in https://github.com/pipe-cd/pipecd/blob/master/dockers/actions-plan-preview/DOCKER_BUILD#L1
is 1.2.0. Update to 0.13.0 is correct? (maybe 1.3.0?)

currently, the version in https://github.com/pipe-cd/pipecd/blob/master/dockers/actions-plan-preview/DOCKER_BUILD#L1 is 1.2.0. Update to 0.13.0 is correct? (maybe 1.3.0?)

Yes, you are right. It should be 1.3.0. 👍

Thank you for reviewing!
I fixed it

Thank you for reviewing!
I fixed it :)

I fixed :)

Great work! Thank you.
/lgtm

go bold:)
/approve


Restructure: Create pipenv-install buildpack

Background
See RFC 0001 that outlines the proposed restructure of python family of buildpacks. In order to conform to the RFC, a new pipenv-install buildpack should be created that bears the responsibility of installing packages using the pipenv tool.
Proposal

Create a new repository named pipenv-install at github.com/paketo-community/pipenv-install
Transfer this issue to pipenv-install.
Create a buildpack using packit that runs the logic of installing packages using the pipenv tool.
Buildpack API should be as follows:

provides: site-packages
requires: cpython and pipenv during build

Record in an RFC the behavior of this buildpack.

Extra notes:
Please update the README and GoDoc to match the style in the Pip buildpack
Please use buildpack API 0.4 in the buildpack.toml


ROS 2 support?

Does this support ROS 2?

Right now it's Noetic only (possibly Melodic if compiled with python3, though untested) @b1n-ch1kn is taking a crack at a ROS 2 port: https://github.com/b1n-ch1kn/vizanti though it's not completely working yet.

Ok so it might be useful to continue the discussion here, from https://github.com/MoffKalast/vizanti/pull/15, since the build is partially working now, on branch ros2.
The list of things tested and fixed, and those left either untested or still requiring work:

[x] Global Settings
[x] Grid
[x] TF
[x] Robot Model
[ ] Dynamic Reconfigure (needs partial rework, disabled)
[ ] Bag Recorder (won't report correct recording status at times, disabled)
[x] Node Manager (a bit iffy in terms of finding executables and killing nodes)
[x] Add new visualizer/widget (though seems to have higher latency in finding new and discarding old topics)

[x] Teleop Joystick (tested with turtlesim)
[ ] 2D Pose Estimate
[ ] 2D Nav Goal
[ ] Waypoint Mission
[ ] Area Mission
[x] Button (tested Empty with vrx ball launcher)

[x] Map (tested with dummy_robot_bringup)
[x] Satellite Tiles (tested with vrx)
[ ] Battery
[ ] Compressed Image
[ ] Marker Array
[ ] Path
[ ] Range
[x] LaserScan (tested with dummy_robot_bringup)
[ ] PoseWithCovarianceStamped
[ ] Pose Array
[ ] Temperature

@swarajpeppermint if you've got a robot that has any of the unchecked topics above to visualize it would be a great help to try and confirm what works and what doesn't. I'm still struggling to find good ROS 2 demos in gazebo or rosbags that would test the bulk of it.

Ok got the nav2 demo working to some extent, the Header seq param no longer exists, so that was throwing errors. That should fix initialpose and simple goals.
https://github.com/MoffKalast/vizanti/assets/9977799/d9cc6fb3-d447-433c-8651-4905c02d6d73

@MoffKalast sure. It looks like an interesting project that we can check/use in our organization internally (and probably even contribute to).
I've shown this issue to another Robotics Engineer in the team. If we decide to explore this, we'll definitely get back to you.

Alright this seems more or less done now, with #27 merged.

What are the setup steps to use vizanti with ros 2? I am somewhat new to the ecosystem so I am stumbling on the inconsistencies between versions in the installation guide for vizanti. It seems to depend on catkin, for instance

Oh, I see. I managed to find the fork:
https://github.com/MoffKalast/vizanti/tree/ros2
My appologies if I missed any mention of that in the main readme. If there aren't any, I might add one if I do any other PRs!

Yep, you have to look at the ROS2 readme for installation instructions: https://github.com/MoffKalast/vizanti/blob/ros2/ReadMe.md
It's a fairly standard ROS thing to have separate branches with different documentation pertaining to that specific version, but I see it would be wise to add a note about it on the wiki for newcomers. I hadn't really anticipated that this repo would ever be looked at by people completely new to ROS itself :sweat_smile:
ROS 1 Noetic is still the main branch since it's the most stable, ROS 2 Humble works mostly reliably with rosbridge as the backend but it is slower, that's why the RWS option is there which is very fast but still has a handful of bugs that need to be looked at. AS for ROS 2 Jazzy, the last I checked (a few months ago) the package builds fine but neither of the backends worked yet, so I'm not sure how well it runs yet.

Thank you very much for the information! That is certainly on me for trying to learn ROS and Vizanti simultaneously, my appologies. I didn't realize it was a normal convention.
Thank you for the compatibility hints as well. My platform is a pi 5, and I believe that forces me onto Iron at the minimum. I may just have to containerize humble, always an option.

@factoidforrest Ah yeah that is a problem on the Pi 5, they never really released anything older than 23.10 for it, aside from some Armbian builds I think, not sure if they work and they wouldn't be tier 1 supported by ROS anyway.
Anyhow I've got a similar setup planned for an AGV I'm refitting, Pi 5 + 24.04 with Jazzy so I should be able to test out any bugs you find.
I've re-tested the state today and while rosbridge from apt doesn't work yet, if you git clone https://github.com/RobotWebTools/rosbridge_suite into colcon_ws/src and build it along with the rest of the packages it does seem to work at first glance. I've tested what I've got set up as tests in the demos package:

It's really laggy though, and rosbridge pins one core to 100%. I'll see if I can help RWS get up to speed sometime soon as well.

RWS is now also patched for Jazzy, I'll update the wiki.


Simplify beacon UI when beacon overload is active.

Space Exploration (and some other other mods that offer the same feature in isolation) rebalances beacons, by only allowing machines to be covered by at most one beacon at a time (machines under the influence of two or more beacons are disabled instead).
In this context, the "amount" field in the beacon selection UI is not necessary, as the only legal value for it is 1. This change cleans up the UI and forces the beacon amount to be always 1.
(This change keeps the "total" field, as that is still relevant for power consumption calculations.)

Should have just changed visibility and prepopulated the amount with 1, then no changes to logic would have been necessary.

I didn't realize ui_util allowed for that — does setting textfield_amount.visible = false (and equivalently for the label) and textfield_amount.text = "1" do the trick? I can make that change on an additional commit.

Haven't tested it, personally, but I see no reason why it won't work.
And this has nothing to do with ui_util. This is just basic GUI API and common sense. The aim is to hide the beacon count. So just hide it and let the dialog logic be reused instead of unnecessarily complicating it.

Implemented in 0d1b352; I'll close the PR but keep the branch around (maybe better to copy the mod list, and the global-ish variable for the detection result?).

Thank you, will move over the mod list.


Consider moving common model tables into another schema (outside of api) to make it easier to migrate/isolate in the future

We might want to isolate data plane from control plane to avoid noisy neighbors, privacy settings, scalability, etc.

Linear SUP1-222


New python script for creating frozen requirements.txt file

https://trello.com/c/nAbDKL43/228-pip-is-case-insensitive-and-our-requirements-freeze-job-is-not
New python based freeze-requirements that fails when pip detects anything in the new requirements file that wasn't installed in the virtualenv, including packages with the wrong case specified in their name (eg rEqUeStS)
This is an MVP and direct rip off of our makefile freeze-requirements command but written in python.
https://github.com/alphagov/notifications-api/blob/master/Makefile#L96-L105
https://github.com/alphagov/digitalmarketplace-api/blob/master/Makefile#L31-L40
Creates an identical requirements.txt to the one we already have in supplier-frontend and briefs.
Is ran like:
python -m dmutils.repoutils.freeze-requirements requirements-app.txt

@lfdebrux Updated to use run


Extend ACCF relative humidity

Fixes

Allow the ACCF model to accept relative humidity as a percentage or as a proportion.
Include ecmwf.RelativeHumidity in ACCF.met_variables so that ERA5(..., variables=ACCF.met_variables) no longer raises an error.

Tests

[x] QC test passes locally (make test)
[x] CI tests pass

Reviewer
@jsmretschnig let me know if this fixes the issue you identified in #264

Seems like the ValueError is gone now, thanks! So the request is actually being sent to the CDS where it is processed.

Seems to work! Found another bug though, will open a new issue/PR. Will reach out to you for best-practices in general.


When parsing JSON in FormData, creates an exception

{autor:asd,dataLimite:2023-02-21,dataOcorrencia:2023-02-21,descricao:asdas,infoAdicional:sadads,origem:asd,titulo:asdsa}
 ^

SyntaxError: Unexpected token a in JSON at position 1
    at JSON.parse (<anonymous>)
    at createOcorrencia (D:\Repos\PAP\backendv2\controllers\ocorrencias\controller.js:57:19)
    at Layer.handle [as handle_request] (D:\Repos\PAP\backendv2\node_modules\.pnpm\express@4.18.2\node_modules\express\lib\router\layer.js:95:5)
    at next (D:\Repos\PAP\backendv2\node_modules\.pnpm\express@4.18.2\node_modules\express\lib\router\route.js:144:13)
    at verifyPermission (D:\Repos\PAP\backendv2\middleware\verifyPermissions.js:47:5)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

If I remove the middleware it starts working.

Hi you have a syntax error inside of your code,
you need to use it as middleware like following code:
const sanitizer = require("perfect-express-sanitizer");

 app.use(sanitizer.clean({
     xss: true,
     noSql: true,
     sql: true
 }));

I have it just like that.

This is how my FormData is composed. First part json and then all the files to be sent.
 let formData = new FormData();
    const json = JSON.stringify({
      autor: data.autor,
      dataLimite: data.dataLimite.toISOString().slice(0, 10),
      dataOcorrencia: data.dataOcorrencia.toISOString().slice(0, 10),
      descricao: data.descricao,
      infoAdicional: data.infoAdicional,
      origem: data.origem,
      titulo: data.titulo,
    });

    formData.append("document", json);

    if (acceptedFiles.length > 0) {
      acceptedFiles.forEach((f) => {
        formData.append("files[]", f, f.name);
      });
    }

This is how I get the JSON information in the server
  const {
    autor,
    dataLimite,
    dataOcorrencia,
    descricao,
    infoAdicional,
    origem,
    titulo,
  } = JSON.parse(req.body.document);

hey any solution to this. ??

on further investigation i have found out that if you keep sql:false then it transmits multipart form data how ever when u keep sql as true then in that case it does transmit .. so the bug has got something to do with the sql module

It seems to have to do also with having it on verification of headers normally formdata content type looks like this
multipart/form-data; boundary=---------------------------35408058081073067362132698594
Having the


MockPA2 understanding reduce()

Summary
The correct way of understanding what does reduce(this, (x,y) -> x.succ()) really means
Description
I want to understand this statement, as it is quite unusual when it doesnt comprise of any y in the action expression. If lets say it is according to MockPA2, where we use iterate() to create a stream from Num.zero() to the desired Num, and then use reduce(this, (x,y) -> x.succ()), this is my understanding:

x takes in each element, and according to the expression, it will increment by 1. So meaning in the first iteration of reduce(), it will increment Num.zero() by one, which effectively becomes Num.one()
y tries to mimic the change, but it doesnt call succ(). So somehow, it will also get incremented by 1

In the end, this is how it is similar to creating a for loop (using iterate()) and then having an expression where the value increments by 1 with each increment in loop (using reduce()). But in all, I still need help in making it clearer, especially for 2)

since the 'reduce' function requires a binary operator, the lambda function has to take in 2 parameters even if one is not used in the computation

In the lambda expression (x, y) -> x.succ(), x represents the current accumulated result, while y represents the next element.  So it effectively increments each element by one in each iteration, similar to a loop, disregarding the value of y.

okay i understand already, and also after looking at the code for the reduce(T identity, BinaryOperator accumulator) i got it. Thxxx @pinkhydroflask @craezydodo


Add Windows Studio Effect DDI doc and code sample features to cover profiles and MediaType

This change

adds documentation for Windows Studio Effects DDIs specification and detailing various details of WSE and adding win32 code snippets
it also changes the code sample to allow changing MediaType and experiment with changing Camera profiles, so see for example how the custom "passthrough" profile exposed by WSE allows the use of higher resolutions but disables support for effects
fixes some issues with the destructor of the control monitor wrapper class

using System.Collections.Generic;

Copyright

Refers to: Samples/WindowsStudio/WindowsStudioSample_WinUI/MainWindow.xaml.cs:2 in eea8132. [](commit_id = eea813204a417994b726b4e0c84ca9cbc0b9fcab, deletion_comment = False)


rootless-install.sh: update to docker 20.10.11

not released yet (build pipeline is running)

@AkihiroSuda @StefanScherer ptal

I lost merge access on this repo, so will need to wait for @justincormack to restore those 🙈


build.rs: use default system compiler

IsoAlloc builds fine with GCC too afaict, however with the specific clang clause the build is going to fail on a system without clang installed with:
warning<EMAIL_ADDRESS>Compiler family detection failed due to
error: ToolNotFound: Failed to find tool. Is `clang` installed?

error: failed to run custom build command for `libisoalloc-sys v0.2.8`

Dropping the clause gives the user the freedom to pick their choice of C compiler.

Wow so someone is using my crate :) yes initially I was trying to mimick a bit the C Makefile but it s just a default setting anyway. Will merge it later today. Thanks


State management breaks on quick opening/closing of the popup

Describe the Bug:
When interacting with the LNPopupUI in my SwiftUI application, specifically when the audio is playing and I either drag down the popup or click the close button on the popup, the tab view and popup view turn black. The audio continues to play as expected, but the visual elements of the popup and tab view do not render correctly.
To Reproduce:
Steps to reproduce the behavior:

Start audio playback in the app using LNPopupUI.
Interact with the popup by either dragging it down or clicking the close button.
Observe that the tab view and popup view turn black while the audio continues to play.

Expected Behavior:
The popup and tab view should maintain their proper visual appearance when interacted with, without turning black, while allowing the audio to continue playing.
Screenshots:
https://github.com/LeoNatan/LNPopupUI/assets/38012177/ae5ab829-4a38-4b9b-b96a-10d91f5fdec1
Additional Context:

The issue occurs in a SwiftUI application.
Using LNPopupUI for popup management.
The problem seems related to view rendering and state management in conjunction with LNPopupUI.
The issue is consistently reproducible under the described conditions.

Environment:

SwiftUI version: 5
LNPopupUI version: 1.7.0
iOS version: 17.1.2
Xcode version: 15.0.1 (15A507)
Device/Emulator type and iOS version: iPhone 11

Hello,
This looks like a user state management bug. Please try to reproduce the issue on a clean example project (or the included one with this repo) and attach here.
Thanks

Ping.
Thanks

Yes, I will follow your instructions by replicating the issue on a clean sample project and will attach it.

Hey @LeoNatan,
Attached is an example project LNPopupNetworkExample.zip
demonstrating the issue where dragging down the popup while playing on network audio stream causes it to vanish unexpectedly.
Thank you for looking into this.

Hello @vamsii777
I took a short look at the demo project. It's not a small one. While I haven't investigated the ins and outs of it, and I am afraid I won't be able to, I do find that my instinct was correct; it is a state management issue. For example, removing the isPopupOpen: $audioPlaybackViewModel.isPopupOpen portion in ContentView.swift is enough to remove the issue (but might break your logic). I did notice, in your code you set isPopupOpen in multiple places. What I suspect that might be happening is that the underlying framework, LNPopupController, is not dealing with multiple changes in state as gracefully as it should, and something breaks. However, this is not a priority for the framework, and debugging these issues are very difficult, especially with a complex project as your example one. Before SwiftUI support was introduced with LNPopupUI, the LNPopupFramework framework considered state changes while transitioning to be user error. This was no longer possible in SwiftUI due to the nature of the beast, and I tried making everything as cancellable and reversible as possible, but it's not an easy task, and there seem to be some issues left.
I suggest leaving the popup open/close to the user, and at most, closing the popup when your playback ends. But it seems to me, at least from a cursory look, that you set it to closed and then open multiple times in very short times, creating the issue. If you must, use the onOpen and onClose to track the state of popup, and queue your state changes according to those, but, again, I do not suggest doing that (especially not in something like SwiftUI+LNPopupUI).
I will keep this issue open, but not sure if/when I will be able to improve it.

So, I've been looking at how SwiftUI solves UIKit transitions, because it seems UIKit has the same issues as LNPopupController. For example, attempting to present and dismiss a view controller right away causes a crash. Yet, in SwiftUI, the system finishes the presentation and then dismisses.
So that gave me an idea to implement a similar queueing system in LNPopupController (and thus in LNPopupUI).
For example, the following code:
- (void)_start
{
	__weak __typeof(self) weakSelf = self;

	[self _firstContentController];
	[self _presentBar];
	[self _dismissBar];
	[self _presentBar];
	[self _dismissBar];
	[self _presentBar];
	[self _openPopup];
	[self _secondContentController];
	[self _presentBar];
	[self _dismissBar];
	[self _presentBarAndOpen];
	[self _closePopup];
	[self _openPopup];
	[self _dismissBarCompletionHandler:^{
		[weakSelf _afterSecond:^{
			[weakSelf _start];
		}];
	}];
}

creates the following behavior:
https://github.com/LeoNatan/LNPopupUI/assets/2270433/8f8d20b5-8853-4880-9bab-72a48bbf32e8
That's not to say that this solves your issue, because if your code remains as it is, your users will see a lot of transitions they shouldn't, but I am happy with this result as a stop gap between nothing (current implementation) and a complete interruptibility (which I also tried, but so far haven't had a satisfactory result).

Acknowledged the recent developments and insights on the state management issue with LNPopupController. The proposed queueing system, inspired by SwiftUI's handling of UIKit transitions, seems like a strategic solution to address the rapid state changes and their impact on rendering. This approach could provide a more stable and consistent user experience, effectively resolving the visual anomalies observed during popup interactions. Eager to see how this implementation enhances the framework's robustness in upcoming releases.

I hope to release a new version soon. Want to test locally to try and catch any regressions that might have been introduced. Nothing so far.

Hello,
I released LNPopupController 2.18.0 yesterday, which includes what we discussed before. Please update your dependencies, and try it out.
Thanks

Hello, when investigating #31 (which was a similar issue to this), I added an improvement on top of the previous release, which now makes things much better. Please try it out.


The program crashes when assemblies are missing

I tried to extract assets from a game that uses il2cpp, so the assemblies aren't visible and when it tries to load them it crashes for like 20 or 30 seconds and then closes itself. But i've tried for more than one hour and i can say that this happend only when it tries to read FacebookSettings or something after that file.
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read MonoBehaviour, because some  assemblies are missing
Import: Unable to read FacebookSettings, because some  assemblies are missing
After that it crashes and close itself.
Those are the files with which I get this error: http://www.mediafire.com/file/r7trclvfpksdwsh/Color_Balls_3D.rar/file

fixed in 58d1d16742d12075d6518d88fe35dfcd2e61990f


Add PDF fishmap to POI panel

IF has link in fish_map column in poi_desc table, display in the "More Information" section of POI panel just after map_link, map_link_spanish and picnic_link.
Fishing Lake Map (PDF)

Available on staging for review.
https://github.com/smartchicago/trailsy/commit/7b785dbd2f71cc920cfd80b71a87a54169ae628d

Good to go.

In production https://github.com/smartchicago/trailsy/commit/d92a30fdd57eb6d2e507f6b05593d196eb20fcb0


Pallet Onboarding design

Motivation
Pallet nft has been completed, and will be used by:

Pallet_onboarding during the first phase of proposal submission
Pallet_vote (burn_nft after unfavorable vote for example)
In M3 during finalization of owners selection

The natural next step is pallet_onboarding design
Onboarding
Needed calls for pallet_onboarding:
Actions By Seller

[x] create House_Asset struct (Seller):

minted nft
index
status

[x] set_price (Seller)

Actions By FS pallet

[x] submit_Asset (for Review to the Council)
[ ] destroy_asset

Actions By Investors

[ ] make_offer (price offer)

The list above is not final : suggestions are strongly encouraged...

Additional/needed function:

Monitor vote results of voting pallet

by using a hook, we will look for relevant events emitted by the voting pallet on block finalization

Update Asset status based on vote result in onboarding pallet

If a vote is not favorable the collective pallet will only remove the corresponding proposal from the storage. depending on the kind of vote (rejected for editing price or totally rejected) we will have different status and different actions like burning the corresponding NFT, and removing the corresponding asset from storage (Asset removal from storage shall be discussed, as we might want to keep it as an archive)


Support multiple webhooks on a single flask app

When endpoint argument is not passed to app.add_url_rule, flask uses view_func.__name__ to uniquely identify callbacks. This results in all callbacks having the same "unique" idenfitier: _postreceive.
An easy fix is to explicitly pass in an endpoint name, which can be identical to rule name.
Signed-Off-By: Frederic Spieler<EMAIL_ADDRESS>

Released in 1.0.2


Katacoda course completion

Hi. I'm waiting for this katacoda course to be completed from v0.8.1 release (about 3 months ago). specifically for Introducing caching to Thanos lesson. Can you please consider it's completion in your future works?
Thanks

We are still looking for a volunteer!
On Fri, 28 Feb 2020 at 09:10, stale[bot]<EMAIL_ADDRESS>wrote:

This issue/PR has been automatically marked as stale because it has not
had recent activity. Please comment on status otherwise the issue will be
closed in a week. Thank you for your contributions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2041?email_source=notifications&email_token=ABVA3O2J6AG7VLDCNK7OCELRFDIHHA5CNFSM4KLP3SX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENHZ6PI#issuecomment-592420669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3OZ7PXKBO3ZZ2TEOEYLRFDIHHANCNFSM4KLP3SXQ
.

Still looking for help! (:

@bwplotka Can we start a google doc on listing the missing parts of Thanos that needs to be added to the course?
I can start documenting. And we can define the scope and priority based on the missing parts. WDYT?

This project is meant for Community Bridge, but definitely we can start some work - it's kind of unlimited bucket of work.
Do we need any doc for this? We can use this issue for this.
Also we already have missing bits. If you look into tutorial dir there are placeholders. And the order of tutorials states the priority (:

@bwplotka
Here are the Github pages to add projects for the upcoming cycle specific to community bridge & summer of docs
Community Bridge:
https://github.com/cncf/mentoring/blob/master/communitybridge/2020/q2/project_ideas.md
Summer of Docs:
https://github.com/cncf/mentoring/tree/master/seasonofdocs

As a heads-up on the katacoda course. I see the following scenario's as requirements for the course completion
Existing Scenario:

Intro: Global View and seamless HA for Prometheus

TODO Scenarios:

Intro: Downsampling and unlimited metric retention for Prometheus
Intro: Global and meta alerts with Thanos
Advanced: Connecting remote Prometheuses to Thanos using simple Envoy setup.
Advanced: Using Prometheus remote write to stream metrics to Thanos
Advanced: Query low tail latency with low cost: Introducing caching to Thanos

Sorry for late notice, but @VineethReddy02 we added this project as part of Community Bridge https://github.com/cncf/mentoring/pull/230 (:

Hey @bwplotka ! I am willing to get mentored for this issue for the Community Bridge program. Can you please help me in getting started with it?
Thanks

@bwplotka I am interested in this project for community bridge as a mentee, please provide further instructions to get started and I have submitted the CV and a resume is there anything else do we need to do?

Hey @bwplotka I am interested in this project for Season of Docs 2020, Please provide me further instructions to get started and to whom I should contact?

I would like to work on this in GSoD this year. Please tell me how to proceed & what work needs to be done.

@bwplotka I will go ahead and remove Thanos from the GSoD page.

@soniasingla is on it!

https://github.com/thanos-io/thanos/pull/2840 here is the PR link 😄


Add metrics for hostedCluster deletion SLIs

What this PR does / why we need it:
Adds two new metrics
hypershift_cluster_deletion_duration_seconds
hypershift_cluster_guest_cloud_resources_deletion_duration_seconds
As a consequence CloudResourcesDestroyed is bubble up from HCP into HC.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Ref https://issues.redhat.com/browse/HOSTEDCP-635
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/test e2e-aws

/test e2e-aws

/lgtm

{"level":"info","ts":"2022-12-19T19:11:27Z","msg":"hostedcluster is still deleting","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","hostedCluster":{"name":"example-64mp9","namespace":"e2e-clusters-r6t5f"},"namespace":"e2e-clusters-r6t5f","name":"example-64mp9","reconcileID":"bdaca3a0-fa42-4bf8-b03f-f682219476c0","name":{"namespace":"e2e-clusters-r6t5f","name":"example-64mp9"}}
panic: assignment to entry in nil map
goroutine 611 [running]:
main.(*hypershiftMetrics).observeHostedClusters(0xc000787e80, 0xc004c5c9a0)
/hypershift/hypershift-operator/metrics.go:220 +0x7d1

FIxed and pushed.

/test e2e-aws

/test e2e-aws

/lgtm


ms-settings:display-* links incorrect

> Advanced display settings 	ms-settings:display-advanced (only available on devices that support advanced display options)
This uri actually points to "Advanced scaling settings", not to "Advanced display settings".
Also I would like to know the actual uri to the "Advanced display settings" screen.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 987ec16c-9456-93a4-177a-dbd563be7eb7
Version Independent ID: f41f0344-f7f6-f092-a6bf-fc4184a9b460
Content: Launch the Windows Settings app - Windows UWP applications
Content Source: windows-apps-src/launch-resume/launch-settings-app.md
Product: uwp
Technology: processes-and-threading
GitHub Login: @knicholasa
Microsoft Alias: nichola

Hi - I believe this setting only works on devices that have the advanced display settings. in other words, if you have a system which doesn't have an advanced display settings option, it won't work.


Refresh dispute window stats when someone has purchased participation tokens

I noticed that when other person bought participation tokens my Participation section on Dispute page didn't update.

tested and working. closing


can we get a readme ffs?

proper Readme and docs site will come in due time. I'm still developing and testing it, this is not ready for general use yet.


More test

Add test for args during init (testing regex and allowed charset) according to #219
Ticket: when you do --follow in CLI, it doesn't shows the job name

merge it for now so i can push my fix


Implement dot product and try adding test

Implements dot product. Merge after #4.

@Seggan I made PR 2 before #4, so it hasn't caught up yet. I'll fix that stuff once #4 is merged.

Look at #5 instead


Statsd Adapter

We introduce an adapter implementing the metrics aspect which exports metrics to statsd.
Lots of open questions in this PR around the error handling and config validation, these are recorded as TODOs inline.

This change is

Updated, PTAL.

Updated, PTAL. Totally forgot to move client creation down with the rest, it's done in NewMetricsAspect now.

Also, open question about the implementation of Record: as written it bails on the first error when attempting to record a value. Would it be better to attempt to record all values, aggregating any errors we get, rather than stopping at the first error?

Codecov Report

Merging #239 into master will increase coverage by 0.51%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   77.05%   77.56%   +0.51%
==========================================
  Files          46       47       +1
  Lines        2000     2073      +73
==========================================
+ Hits         1541     1608      +67
- Misses        436      439       +3
- Partials       23       26       +3

Impacted Files
Coverage Δ

pkg/adapter/metrics.go
0% <ø> (ø)
:white_check_mark:

adapter/statsd/statsd.go
94.52% <94.52%> (ø)

pkg/config/manager.go
97.18% <ø> (-2.82%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be136ec...d2efe91. Read the comment docs.

In the last few days, I've pushed coverage to 100% in a few different
modules. On every occasion, I've found actual problems in the last chunk of
uncovered code :-)
I'd say remove the panic and just leave _ = t.Execute() and maybe a comment
that validation ensures correct operation.
On Wed, Feb 8, 2017 at 12:49 PM, Zack<EMAIL_ADDRESS>wrote:

@ZackButcher commented on this pull request.
In adapter/statsd/statsd.go https://github.com/istio/mixer/pull/239:

+func (a *aspect) Record(values []adapter.Value) error {

var result *multierror.Error
for _, v := range values {

if err := a.record(v); err != nil {

	result = multierror.Append(result, err)

}

}
return result.ErrorOrNil()
+}

+func (a *aspect) record(value adapter.Value) error {

name := value.Name
if t, found := a.templates[value.Name]; found {

buf := new(bytes.Buffer)

if err := t.Execute(buf, value.Labels); err != nil {

	panic(fmt.Errorf("failed to create metric name with template '%s' and labels '%v'; got err: %s", t.Name(), value.Labels, err))

Turns out my understanding of the template code was a bit wrong: Execute
only throws due to invalid templates (which we check for in
ValidateConfig), not due to not being able to satisfy the template with the
input.
So for the example of the template {{.apiMethod}}-{{.responseCode}},
trying to Execute it with a value that has no labels results in the
string -. I'm pretty convinced that this panic is
unreachable given validated config. Should we keep it around, just ignore
that error, or change it to a log statement and default to the metric's
original name?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/mixer/pull/239, or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHcH16-JUhKGUgGx3DUe50hMloAutks5raiphgaJpZM4L22k3
.

Removed the panic at execute and added a comment.

With switch to gogoslick, the proto config bits should be updated. denyChecker is a good source of a similar switch.


Configurable field instead of USERNAME_FIELD.

I'm having some difficulties with the username field as an unique identifier. I'm using email as username field in my project and superusers have the ability to change this value. When this happens the users token gets invalidated and will be logged out once he tries to refresh his token.
Other reason why it could by a good idea to pick another field is that this could lead to some security issues which are discussed in this issue.

Hi @svengt ,
there's a related PR https://github.com/flavors/django-graphql-jwt/pull/17, I could include the JWT_PAYLOAD_GET_USERNAME_HANDLER  setting soon.

@svengt added JWT_PAYLOAD_GET_USERNAME_HANDLER setting variable.

@mongkok Thx for the update!


Post April 2023 ACLs no longer allowed by default so wait for changes

what

Wait a little while after configuring bucket ownership controls on a new S3 bucket before configuring the bucket ACL

why

Post April 2023, ACLs are disabled by default for all new S3 buckets which can cause a race condition when trying to apply a canned ACL to a new S3 bucket - https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/
If you try to use the resourceaws_s3_bucket_acl too quickly after the resource aws_s3_bucket_ownership_controls then ACLs may still be disabled on your new S3 bucket and your terraform apply will fail. If you re-run your apply then it works just fine the second time around as the propagation of the change in bucket ownership has finished.

references

None

mentioning duplicate issue #174 to assist finding

I'm going to close this PR then since there's another that uses depends_on to correct the issue.


feat: add ability to set declination of phase center

Adds the ability to set the declination of the phase center of the observation, and adjust the apparent UVWs accordingly.

Thanks @steven-murray, this looks like a great addition.
Summarizing to check I understand the changes:

The UVWs are computed using the uvutils.phasing.calc_uvw function from pyuvdata. This of course already has support for non-zenith phase centers.
The main change is in _utils.py, to add a phase_center_dec argument to phase_past_zenith allow off-zenith phasing.
The phase_past_zenith() is called by Observatory.projected_baselines(), so this needs a phase_center_dec argument added too.
Similarly phase_center_dec is  added to Observation
When UVW coordinates are calculated, they will be calculated using the RA/DEC of the phase center, which no longer needs to be zenith.

The new code does indeed change UV bins:

(thinking more about it: I didn't change the beam, and SEFD will increase for off-zenith pointings with an aperture array. I guess those effects are not accounted for in my simple example?)

@telegraphic thanks for the review!
So, yes your outline is correct. I have not touched the beam/SEFD in this PR -- though perhaps it's necessary to obtain reasonable results. Currently we don't have the infrastructure to be able to have a beam whose projected area changes over the course of an observation, however we could at least change the area to be consistent with the projected area when the phase center is as close to the zenith as possible?
I

Yeah, we've kind of always neglected the primary beam response when considering tracked observations.  The argument was always that you've either got a steerable dish (and hence the SEFD can stay constant as you follow the field) or you've got an aperture array where you're beamforming (in which case there is an increase of the SEFD off-zenith, but it's small since it's set by the primary beam of a single dipole, not the station/tile, and those are very wide).  Realistically you would want to account for it, but I think it's a pretty big change to the inner workings of 21cmSense to make it work.

@telegraphic are you happy for this PR to be merged? We could attempt to implement a changing beam area as a function of pointing, but I'm not sure how much it will affect results in realistic cases (where you're not pointing at the horizon...), and it would be a reasonably involved bit of work.

Hi @steven-murray, yes happy for this to be merged. As @jpober mentioned, for a steerable dish the SEFD would not change, so it seems reasonable to leave to the user to implement any change in beam characteristics by subclassing PrimaryBeam.
FYI, I have used this branch for the SKA-Low EoR sensitivity calculator prototype @ https://github.com/ska-sci-ops/ska-ost-eor-senscalc


fix(shim-deno/std): Fix std not to use FsFile

If node's "process" module is imported, accessing stdin by fs.read throws EAGAIN error: resource temporarily unavailable.
So I re-implemented std interface using process.stdin, process.stdout, process.stderr.
resolves #97

Thanks for the kind review, @dsherret!
I noticed that there are a few errors in multiple call cases, So I changed to delay stream logic to fix wrong behavior.
748e399 (#98)