Use the correct dimension to know if we have to add an EOL in vertical mode

/botio test

As mentioned in PR #14418 this unfortunately causes a (pretty clear) regression, w.r.t. the positioning of some of the textLayer spans, on page 3 of the TaroUTR50SortedList112.pdf document. Hence, on its own, I don't think that this patch is correct/enough to address this unfortunately.
Also, in the commit message you probably want to replace the word had with add instead?

The goal of the patch is just to fix an inconsistency.
For horizontal mode we've:
https://github.com/mozilla/pdf.js/blob/290cbc523281cb86fdf0117cf8f2cae521518fb9/src/core/evaluator.js#L2519-L2528
(we use advanceY and height)
when for vertical mode we've:
https://github.com/mozilla/pdf.js/blob/290cbc523281cb86fdf0117cf8f2cae521518fb9/src/core/evaluator.js#L2468-L2479
(we use advanceX, width and height)
Anyway, right now if you copy/paste the last column you'll get an extra EOL between the whitespace and 縦 which is wrong,
and the patch fixes this problem.
In order to fix the position of the text chunk we would need to split the chunk in 2 chunks (one with the whitespace and one with the visible chars) and then we'll get a span for the whitespace and an other one for the visible glyphes (which will be correctly positioned).

The goal of the patch is just to fix an inconsistency.

I get that, but as mentioned (and evident by the test results) the patch causes a regression. Given that there's no other documents, that we know of, which are fixed by this patch I really don't think that it's OK to "purposely" introduce a regression here.

Anyway, right now if you copy/paste the last column you'll get an extra EOL between the whitespace and 縦 which is wrong,
and the patch fixes this problem.

Sure, but the regression is worse than that (comparatively) small problem as far as I'm concerned. As-is the textLayer no longer agrees with the rendered text, which would make it more difficult for users to actually select the intended text.

Agreed and the user selects the text generally to copy/paste it and so the EOL bug... and the circle is closed !
The whitespace on top of the last column is an ideographic space (https://www.compart.com/en/unicode/U+3000).
In the pdf we've two text runs for the last column: 1 for the ideographic space and one for the visible chars.
We ignore latin whitespace when they're in first position of a text run:
https://github.com/mozilla/pdf.js/blob/290cbc523281cb86fdf0117cf8f2cae521518fb9/src/core/evaluator.js#L2589
I suppose we should do the same for any kind of whitespace.
In Chrome, this space is stripped out but it's present in Acrobat.
An other possibility is to detect that the space and the rest aren't really on the same column (not the same X) and in this case push the chunk with space to have a new one for the rest. It'd make sense in horizontal mode too: create a new chunk each time we don't have the same Y.
@Snuffleupagus, what do you think ?

We ignore latin whitespace when they're in first position of a text run:
[...]
I suppose we should do the same for any kind of whitespace.

I'd guess that'd require changing all of the existing ... = " " checks, in this code, into something like WhitespaceRegexp.test(...) instead?
If so my only concern with that approach would be regarding the possible performance impact, since regular expression matching is probably slower than string comparisons. Other than that, this sounds like a fairly simple solution.

An other possibility is to detect that the space and the rest aren't really on the same column (not the same X) and in this case push the chunk with space to have a new one for the rest. It'd make sense in horizontal mode too: create a new chunk each time we don't have the same Y.

It sounds like that approach could potentially help improve other cases as well, although I suppose it could also lead to more textLayer elements being created (for some documents) since we'd break up existing text-runs more than we currently do.

We ignore latin whitespace when they're in first position of a text run:
[...]
I suppose we should do the same for any kind of whitespace.

I'd guess that'd require changing all of the existing ... = " " checks, in this code, into something like WhitespaceRegexp.test(...) instead? If so my only concern with that approach would be regarding the possible performance impact, since regular expression matching is probably slower than string comparisons. Other than that, this sounds like a fairly simple solution.

According to https://jsbench.me/b1ku0bggvi/1 (found in stackoverflow), the fastest solution is the direct comparison.
In order to avoid to make the check again and again (the i-1,  i+1 thing in the code you mentioned), we could just create and array containing isWhitespace(glyph.unicode) for each glyph.
The main advantage of this solution is that we would treat all the whitespaces in the same way which is consistent. So I'd be in favor of this solution.

An other possibility is to detect that the space and the rest aren't really on the same column (not the same X) and in this case push the chunk with space to have a new one for the rest. It'd make sense in horizontal mode too: create a new chunk each time we don't have the same Y.

It sounds like that approach could potentially help improve other cases as well, although I suppose it could also lead to more textLayer elements being created (for some documents) since we'd break up existing text-runs more than we currently do.

I suppose that most of the times all glyphs are on the same line... but who knows.

/botio test

Based on a quick look, at least issue7878 seem to regress a bit with the latest version of the PR.

The space between Z and a is a non-breakable space (0xA0) so before the patch it was considered as a "normal" char.
And since the chars in the string are slightly tightened we've a span by char:
https://github.com/mozilla/pdf.js/blob/290cbc523281cb86fdf0117cf8f2cae521518fb9/src/core/evaluator.js#L2524
https://github.com/mozilla/pdf.js/blob/290cbc523281cb86fdf0117cf8f2cae521518fb9/src/core/evaluator.js#L2210
With the patch, the 0xA0 is removed (it's the only one char in its text run) and when we add the a we compare its position with the Z and there is enough space for a white. Consequently it results in a chunk with Z a which is not consistent with the drawn glyphes... I'm sad...
I can cheat in removing the 0xA0 from the whitespace list...
I think this regression is acceptable compared to the "improvements" we have in some other cases: it's always this problem to find a good trade-off between number of chunks and chars positions in the text layer.
For your information, I've a wip locally to replace the html-based text layer by a svg-based one: it'll greatly improve the char positions, but I've few regressions I need to figure out.

/botio test

/botio makeref


Asking a question

Question
About meaningless things. Some body text, lorem ipsum and the like.

Some body text, lorem ipsum and the like.

...but have you heard of Hipster Ipsum?


:recycle:refactor(storage): table names

Implements https://github.com/paradigmxyz/reth/issues/3625.
This is the correct PR, last one is on https://github.com/paradigmxyz/reth/pull/4525
Need labels: S-breaking, A-db, C-debt

I am having troubles with clippy somehow, could someone run it to fix CI/CD please?

thanks!
clippy looks unrelated to your changes

Alexey's branch was merged, not needed anymore


Unify RSpec requirements in helpers Gemfiles to match dependabot-common

I run into a similar issue as #4838, because bundle install had installed RSpec versions compatible with Dependabot-common dependencies (RSpec 3.11), but these didn't match the specification in these Gemfiles (RSpec 3.10.2).
This PR proposes the same solution as in #4838. Now all development dependencies are consistent.


Fixing Desync for Non-Integer Frame rates

Over the past few weeks, I've been getting credible reports of the program failing to properly create new media files when using an input that is more than an hour long.
Sometimes the visual part and the audio part do no align and that can be noticeable around the 30 minute mark depending on the settings. I've tried to solve these issues before but the issue always seemed to come back sooner or later, so I decided to try something different.
Over the following month, I'll try to complete all of these tasks.

[x] Make a new "desync" issue template to get users affected to post useful info to help debug.
[x] Create a helper script that can generate long videos/audio to test for desync or overflows.
[x] Figure out the root of these desyncing/overflow problems and try to fix them.

If you're a user affected by this problem, I recommend you export your video to Premiere Pro or Resolve, since it's impossible for the video/audio to misalign. It's also faster than rendering a new video too.
Also, I'm not too concerned about changing the video speed causing misalignment down the road. Most video players have the ability to change playback speed, and that option is more for demo purposes anyway.

I changed how timebase works so I believe it fixed all known issues. I tested a 6 hour video and found no signs of desync so it should be good enough for now.


Add new category Profession

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d390b5c). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main       #59   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?        70
  Lines           ?       641
  Branches        ?         0
========================================
  Hits            ?       641
  Misses          ?         0
  Partials        ?         0

Impacted Files
Coverage Δ

qual_id/categories/profession.py
100.00% <100.00%> (ø)

qual_id/pattern.py
100.00% <100.00%> (ø)

test/categories/test_profession.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d390b5c...bc115cd. Read the comment docs.

Thanks @jaqsparow ! Great contribution 🙂

👍🏻


HDDS-5751. Use Mini Cluster Provider to speed up TestHDDSUpgrade

What changes were proposed in this pull request?
TestHDDSUpgrade is one of the longest running test suits as it creates many mini-clusters:
[INFO] Running org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade
Warning:  Tests run: 13, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 694.753 s - in org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade

It is not possible to reuse the same clusters across multiple tests here, so we can use the MiniClusterProvider to create the clusters in the background and speed things up.
On my laptop the test runtime went from 9min 14s to 5min 12s.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5751
How was this patch tested?
Existing tests

Update code ran in:
[INFO] Running org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade
Warning:  Tests run: 13, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 417.387 s - in org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade

Saving 277 seconds.


Incorrectly passing task when the major requirement not met

>

>
Hello World!

Code passes the test, including the last item "Your h1 element should be orange." That element is obviously still blue, yet that item is incorrectly checked and the challenge is marked as passed.
A check that there is only one h1 declaration, or that the id and class declarations are in the same tag, or (and I don't know if this is possible) checking the actual color displayed could fix this issue.
I believe that indicating to the student that the id and class attributes are in the same tag might be useful information.
Screenshot

Challenge Name
https://www.freecodecamp.com/challenges/override-class-declarations-by-styling-id-attributes
Issue Description

Browser Information

Browser Name, Version: Windows Edge
Operating System: Windows 10
Mobile, Desktop, or Tablet:  Mobile

Your Code

Hello World!

There does exist a test that checks for orange, but interestingly, it doesn't seem to working here.
 "assert($(\"h1\").css(\"color\") === \"rgb(255, 165, 0)\", 'message: Your h1 element should be orange.');"

This seems to be because of the incomplete h1 element -

This is rendered in the browser as an h1 element with no text, but including the orange-text ID, which is why the tests pass -

Maybe the tests could be amended to assert for presence of a single h1 element?

Not closing the h1 tag was a copy/paste error on my part. The issue however is the same.
Thank you for looking at this; I think the solution of looking for a single h1 element would work.
I believe several other bug reports here have been for the same error, but it is sometimes hard to tell.

@raisedadead I'd like to work on this, if that's okay..

@Manish-Giri sure go ahead! 😉

@raisedadead I added a new test that checks for the presence of a single h1 element. Now with the same code as OP, the challenge does not pass.

This code fails against the test I added -

Do not create a new h1 element

Is this all right for submitting the PR?

This is my first post to anything related to FCC, so please inform me if I miss something. My code just passed incorrectly (passed but text is not orange)

Hello World!
![image](https://cloud.githubusercontent.com/assets/25202267/22202556/a5d7519a-e136-11e6-99ae-26fd189523d5.png)
 (I can't figure out how to paste the image here, but the text is blue).

I didn't mean for the code to run together like that. :(


Resolve syncing conflicts from live-sync-work to live

Pull request opened by OPS to resolve syncing conflicts from live-sync-work to live.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-cli-python, working directory: W:\vf5v-s, target branch: live, target branch commit: 88e076bddc94f9dd6c3b4e1a7092a5719ff9138f, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-cli-python, working directory: W:\eryo-s, target branch: live, target branch commit: 88e076bddc94f9dd6c3b4e1a7092a5719ff9138f, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-cli-python, working directory: W:\3dvh-s, target branch: live, target branch commit: 88e076bddc94f9dd6c3b4e1a7092a5719ff9138f, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-cli-python, working directory: W:\kzmq-s, target branch: live, target branch commit: 88e076bddc94f9dd6c3b4e1a7092a5719ff9138f, source branch: live-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Validation: Fixed Absolute and Preserve View Links

This PR fixes 39 issues across 19 files and is part of ongoing Validation cleanup efforts. No other content has been edited or added.

Docs Build status updates of commit ea93041:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/Office.SensitivityLabelInitInfo.UserId.md
:warning:Warning
View
Details

api/Office.IConverterPreferences.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrInputBox.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrMessageBox.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrReportProgress.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.md
:white_check_mark:Succeeded
View

api/Office.IRibbonUI.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Application.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.CreatePickerResults.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Creator.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.DataHandlerId.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Properties.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Resolve.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Show.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Title.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabel.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabelPolicy.md
:white_check_mark:Succeeded
View

api/Office.SmartDocument.PickSolution.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabelInitInfo.UserId.md

Line 14, Column 66: [Warning: file-not-found - See documentation] Invalid file link: 'azure/active-directory/hybrid/plan-connect-userprincipalname'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8364641:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Office.IConverterPreferences.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrInputBox.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrMessageBox.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.HrReportProgress.md
:white_check_mark:Succeeded
View

api/Office.IConverterUICallback.md
:white_check_mark:Succeeded
View

api/Office.IRibbonUI.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Application.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.CreatePickerResults.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Creator.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.DataHandlerId.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Properties.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Resolve.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Show.md
:white_check_mark:Succeeded
View

api/Office.PickerDialog.Title.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabel.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabelInitInfo.UserId.md
:white_check_mark:Succeeded
View

api/Office.SensitivityLabelPolicy.md
:white_check_mark:Succeeded
View

api/Office.SmartDocument.PickSolution.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Random crashing on AMD GPU

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit v0.35.0  ().
Date: 2024-02-05
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: desktop
Release: 6.1.77
Version: #1-NixOS SMP PREEMPT_DYNAMIC Mon Feb  5 20:13:03 UTC 2024

GPU information:
08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M] [1002:73ff] (rev c7) (prog-if 00 [VGA controller])

os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240216.5863c27"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

plugins:

Bug or Regression?
Bug
Description
Hyprland randomly crashes after working for ~30min, freezes for a couple of seconds and then puts me back to TTY.
This doesn't happen on my laptop, with the same nixos configuration and Intel GPU.
How to reproduce
Launch Hyprland
Wait
Crash reports, logs, images, videos
hyprlandCrashReport1638.txt

gpu driver died

Is there anywhere I should direct this?

amdgpu probably


different style for a disabled button

currently, when you disable a button, it only disables clicking on it. it'd be pretty cool to also change the styling based on the disabled attribute

This is possible with v1 since it uses styled-components (and CSS)

Yes, but how would you do it? There is any example?
Thanks in advance.

@carlorizzante for now I'm doing this:
export const Button = styled(Rebass.Button)`
  cursor: pointer;

  &:disabled {
    cursor: not-allowed;
    opacity: 0.4;
  }
`

Opacity is not the best way to style a disabled button, but it works for now and I can swap it out if I want to. Big benefit of the opacity approach is that it is color-independent.


Remove "All rights reserved" from all the headers.

Fixes: #1707

This change is

lgtm

All files were update running for file in $(./hack/verify-boilerplate.sh | cut -d":" -f2); do sed -i "s/ All rights reserved\././" $file; done. The boilerplates templates by running sed -i "s/ All rights reserved\././" * from within hack/boilerplate.


RuntimeError: Unknown model (beit3_large_patch16_224)

Describe
Model I am using BEITV3:
I meet this issue：
RuntimeError: Unknown model (beit3_large_patch16_224)
timm has no this model,  and i didnt find it.

how should i solve it

Same, looked thru branches and couldn't find anything

I, too, have installed the specified version timm==0.4.12 as required

I, too, have installed the specified version timm==0.4.12 as required

The situation is the same as yours, the model cannot be found

The latest version of timm also doesn't have beit3 model..

The latest version of timm also doesn't have beit3 model..

Do you have any good methods

#1048 run finetune successfully, but i didnt know how

Hi @464hee and @lc222, you can first download the pretrained or fine-tuned model to your local folder and then perform fine-tuning. Will share more updated about timm later.

about

I have download the fine-tuned model "beit3_large_indomain_patch16_224.pth", and run this command:
python3.8  -m torch.distributed.launch --nproc_per_node=4 run_beit3_finetuning.py --model beit3_large_patch16_224 --input_size 224 --task vqav2 --batch_size 4 --layer_decay 1.0 --lr 3e-5 --update_freq 1 --epochs 10 --warmup_epochs 1 --drop_path 0.1 --sentencepiece_model ./beit3.spm --finetune ./beit3_large_indomain_patch16_224.pth --data_path ./data --output_dir ./model --log_dir ./log --weight_decay 0.01 --seed 42 --save_ckpt_freq 5 --task_head_lr_weight 20 --opt_betas 0.9 0.98 --randaug
but i meet this issue:

timm has no beitv3 model so that create_model error.

Hi @lc222, we do not add the 224x224 resolution model in modeling_finetune.py for vqav2 task, you can add the 224x224 model in the code or use the 384x384 resolution model.

I find register_model in modeling_finetune.py just now, I will try to use this. thanks~

about

I have download the fine-tuned model "beit3_large_indomain_patch16_224.pth", and run this command: python3.8 -m torch.distributed.launch --nproc_per_node=4 run_beit3_finetuning.py --model beit3_large_patch16_224 --input_size 224 --task vqav2 --batch_size 4 --layer_decay 1.0 --lr 3e-5 --update_freq 1 --epochs 10 --warmup_epochs 1 --drop_path 0.1 --sentencepiece_model ./beit3.spm --finetune ./beit3_large_indomain_patch16_224.pth --data_path ./data --output_dir ./model --log_dir ./log --weight_decay 0.01 --seed 42 --save_ckpt_freq 5 --task_head_lr_weight 20 --opt_betas 0.9 0.98 --randaug
but i meet this issue:
timm has no beitv3 model so that create_model error.

How did you download the pretrained model? I got PublicAccessNotPermitted error when trying to download from https://conversationhub.blob.core.windows.net/beit-share-public/beit3/vqa/beit3_base_patch16_480_vqa.pth

PublicAccessNotPermitted
Public access is not permitted on this storage account. RequestId:95c4ba00-c01e-0054-2ad1-99b75a000000 Time:2023-06-08T06:22:14.6694035Z

Hi @464hee and @lc222, you can first download the pretrained or fine-tuned model to your local folder and then perform fine-tuning. Will share more updates about timm later.

How to download the pretrained model? I got PublicAccessNotPermitted error when trying to download from https://conversationhub.blob.core.windows.net/beit-share-public/beit3/vqa/beit3_base_patch16_480_vqa.pth


update all deps, fix standard linting

Uses most recent everything & adds the encoding-down module to wrap the returned client.

Depends on https://github.com/Level/codec/pull/51

Closing in favor of #15.


Panic in polkadot relay

In staging environment.
Logs:
time="2021-09-02T09:36:47Z" level=info msg="4: Updating item 11 status from 'InitialVerificationTxConfirmed' to 'ReadyToComplete'"
time="2021-09-02T09:36:48Z" level=info msg="Complete Signature Commitment transaction submitted" txHash=0xd9082ee29a356b971df4d40549c3df1832b174419543ce056fe4457ee7897103
time="2021-09-02T09:36:48Z" level=info msg="5: Updating item status from 'ReadyToComplete' to 'CompleteVerificationTxSent'"
time="2021-09-02T09:36:48Z" level=info msg="Updating item in database..."
time="2021-09-02T09:36:48Z" level=error msg="Failed to get random validator bitfield" error="abi: attempting to unmarshall an empty string while arguments are expected"
time="2021-09-02T09:36:48Z" level=error msg="Failed to write complete signature commitment" error="abi: attempting to unmarshall an empty string while arguments are expected"
time="2021-09-02T09:36:48Z" level=info msg="Shutting down ethereum writer" reason="abi: attempting to unmarshall an empty string while arguments are expected"
time="2021-09-02T09:36:48Z" level=error msg="Failure fetching inclusion block" error="websocket: close 1011 (internal server error): Internal response error"
time="2021-09-02T09:36:48Z" level=info msg="4: Updating item 12 status from 'InitialVerificationTxConfirmed' to 'ReadyToComplete'"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5ecfaa]

goroutine 99 [running]:
github.com/ethereum/go-ethereum/core/types.(*Block).Hash(0x0, 0x0, 0x0, 0x0, 0x0)
        /home/vincent/go/pkg/mod/github.com/ethereum/go-ethereum@v1.10.6/core/types/block.go:377 +0x4a
github.com/snowfork/snowbridge/relayer/relays/beefy.(*BeefyEthereumListener).forwardReadyToCompleteItems(0xc000422780, 0xfbf178, 0xc000422800, 0xa726b2, 0x3, 0x0, 0x0)
        /home/vincent/code/snowbridge/relayer/relays/beefy/beefy-ethereum-listener.go:503 +0x2b0
github.com/snowfork/snowbridge/relayer/relays/beefy.(*BeefyEthereumListener).pollEventsAndHeaders(0xc000422780, 0xfbf178, 0xc000422800, 0x3, 0x0, 0x0)
        /home/vincent/code/snowbridge/relayer/relays/beefy/beefy-ethereum-listener.go:175 +0x45d
github.com/snowfork/snowbridge/relayer/relays/beefy.(*BeefyEthereumListener).Start.func1(0x0, 0x0)
        /home/vincent/code/snowbridge/relayer/relays/beefy/beefy-ethereum-listener.go:92 +0x7e
golang.org/x/sync/errgroup.(*Group).Go.func1(0xc0000b7860, 0xc0000bfa40)
        /home/vincent/go/pkg/mod/golang.org/x/sync@v0.0.0-20210220032951-036812b2e83c/errgroup/errgroup.go:57 +0x59
created by golang.org/x/sync/errgroup.(*Group).Go
        /home/vincent/go/pkg/mod/golang.org/x/sync@v0.0.0-20210220032951-036812b2e83c/errgroup/errgroup.go:54 +0x66

@vgeddes you mean beefy relay? and did it restart and resume nicely or panic and stall indefinitely?

Yeah the beefy relay. This is non-critical error. The relay just restarts and continues happily.

Moved to Linear: SNO-149


Update ChocolateyInstall.ps1

I've been getting "failures" even though this package has installed correctly. The return code is 5100, which most of the web agrees means that the system needs a restart, the difference between this and 3010 appears to be that 5100 means it was in a "requires reboot" state BEFORE the current package was installed, where 3010 means that "I triggered the reboot requirement".

According to the official docs, 5100 means "The user's computer does not meet system requirements." A blog post expands on this, citing several possible causes of this exit code (most of them are failure conditions).
I'll need much more info to diagnose this matter further:

what operating system are you installing it on?
if Windows 8.1/Server 2012 R2, is KB2919355 already installed on the system, or is it being installed by Chocolatey as a dependency?
are there any other packages installed prior to this one in the same session? Other applications?
did .NET 4.6.2 actually install successfully? What is the value of registry key HKEY_LOCAL_MACHINE\Software\Microsoft\NET Framework Setup\NDP\v4\Full value name Release? Did the value change once you rebooted after the package returned code 5100?
please provide the following log files, for example as gists:

$Env:ChocolateyInstall\Logs\chocolatey.log
$Env:TEMP\chocolatey\dotnet4.6.2.log

(please make sure to remove any sensitive information)

@jberezanski I was testing using the "Chocolatey Testing VM" iirc. Basically a pretty vanilla Win2012R2 Server install without any updates out of the box. When installing .NET 4.6.2 I think it has to install a special pre-req for Win8.1/Server 2012 and that requires a reboot, which ends up blocking this install since Chocolatey currently doesn't have a way to force a reboot. Maybe that KB package needs a better "requires a reboot message" but it could also be caught from the 5100 message here to suggest a reboot and attempt to install again.

Yes, it makes sense. KB2919355 requires a reboot and until it is done, the KB will not be seen as installed. Since .NET 4.6.2 requires this KB, it throws a 5100 "Requirements not met" when it does not see it.
Providing a more helpful message certainly seems reasonable. However:

Chocolatey already signals that a reboot is required, which should be a strong hint to the user to retry the installation after the reboot.
Chocolatey does not currently provide a way to obtain the installer exit code if it is treated as success (nonstandard exit codes are overwritten with 0), and if the code is treated as failure, the script becomes messy, because a specific exception needs to be caught and recognized by its message, the exit code needs to be parsed out of a string and internal Chocolatey state needs to be manipulated to transform the failure into a success, while also working around bugs in helpers.
Even after solving 2), the package would need to recognize this specific condition: KB2919355 (or another prerequisite) installed and requiring reboot. Probably solvable, but again, more complexity in the script.
8.1/2012 R2 systems without KB2919355 should be very rare, as that update is a prerequisite for a lot of later updates and software. The Chocolatey test environment does not reflect the real world in this regard, as I had argued before.

All in all, in my opinion the costs far outweight the benefits here.

Chocolatey recently gained the ability to stop installation once a package requests a reboot, which solves this issue completely.


Browser demo SSL certificates expired

Website demo isn't working. The SSL certificate needs to be updated.

Certs have been updated. Thanks for letting us know.


Importing only certain command and not all of the cmdlets

Hi all , when I am performing
$Session = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri http://<ServerFQDN>/PowerShell/ -Authentication Kerberos -Credential $UserCredential

I am getting all 713 cmdlets of the exchange mgmt server.
What should I to if i want to import only 1 or 2 cmdlets?

@tomgold182 from the documentation for the Import-PSSession command, you can apparently specify the cmdlets you want using a variety of methods. So you run:
$Session = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri http://<ServerFQDN>/PowerShell/ -Authentication Kerberos -Credential $UserCredential

and then in the next command, you specify the cmdlets you want:
Import-PSSession $Session -DisableNameChecking -Commands "Cmdlet1","Cmdlet2"...

The $Session command just connects you to the server; the Import-PSSession command is what gives you the cmdlets.


[ISSUE #1700] Create the LICENSE, NOTICE, DISCLAIMER files for bootstrap binaries

For #1700

Codecov Report

Merging #1758 (8636af5) into master (bb1f356) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1758      +/-   ##
============================================
- Coverage     62.43%   62.01%   -0.42%
+ Complexity     2387     2379       -8
============================================
  Files           482      482
  Lines         10320    10318       -2
  Branches       1043     1043
============================================
- Hits           6443     6399      -44
- Misses         3354     3406      +52
+ Partials        523      513      -10

Impacted Files
Coverage Δ

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
66.66% <0.00%> (-27.78%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
49.47% <0.00%> (-13.69%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-11.66%)
:arrow_down:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
25.67% <0.00%> (-10.82%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.51% <0.00%> (-4.26%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
:arrow_down:

...t/zookeeper/ZookeeperClientRegisterRepository.java
70.90% <0.00%> (-1.82%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

.../plugin/grpc/loadbalance/AbstractLoadBalancer.java
68.47% <0.00%> (-1.09%)
:arrow_down:

...u/plugin/modify/response/ModifyResponsePlugin.java
17.80% <0.00%> (+0.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1f356...8636af5. Read the comment docs.


check on start if OpenPype is running already

there is quite a common issue with nontechnical users, that they are trying to run OP and not noticing it has started successfully because of the hidden tray icon on windows.
I saw several cases with 30 instances of OP running at once.
It would be good to check if OP is running and notify the user it is running already on each attempt to start OP
[cuID:OP-2600]

I tend to have multiple OpenPype instances open personally - even of just tray. A developer one, and a live production one. Would love to make sure I won't get many blocking messages like pop-ups or it not starting at all.
Maybe the better logic would be for tray to directly pop-up with something after start so that the user actually KNOWS it started aside of just the splash screen.
Would it just be a tray pop-up message bottom right saying something like:

You currently have two running OpenPype Tray processes.

Does this problem only happen to Windows users due to "Show all icons in Taskbar" being disabled and them having not explicitly set OpenPype to show in taskbar by default?

Yes, it is caused by windows not showing all icons in the tray by default.
I can understand the need to run different versions at once. It is completely fine and we can just check if there is another OP of the same version running for example. Or is there any valid reason to run more OPs of the same version at once?
I do not want to make it more complicated, just want to help users to understand the situation better and prevent unexpected behavior with dozens of OPs running at once. . .


docs(sample): update WriteToDefaultStream sample to match best practices

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

Please follow format docs(sample): update/add... for sample changes in the future. Thanks!

@yirutang please take a look also


'pg_seq2seq'

您好，我尝试了一下 pg_seq2seq，然后我这边报了两个错误。

在 super(PGSeq2SeqSolver, self).init('pg_cnn', controller, recorder, counter, **kwargs) 这里多接收了 'pg_cnn'
在 seq2seq 中的 SubEnv 少了在调用 super 时少了三个变量 controller, recorder, counter

您这边有什么建议吗？或者怎样修改。

Hello, I'm facing the same problem with @Rorsachach ,and pg_seq2seq has not act method? Could you please give me some suggestions？

Thanks for your feedback. I think the unavailability of pg_seq2seq results from the last refactorization, and I will attempt to address this problem in my power as soon as possible.

@xuxi2569471573 I did make some simple modifications, but I don't know whether it is what the author intended.

change super(PGSeq2SeqSolver, self).init('pg_cnn', controller, recorder, counter, **kwargs) to super(PGSeq2SeqSolver, self).__init__(controller, recorder, counter, **kwargs)
change sub_env = SubEnv(p_net, v_net) to sub_env = self.SubEnv(p_net, v_net, self. Controller, self. Recorder, self. Counter). And modify the constructor of SubEnv:

def __init__(self, p_net, v_net, **kwargs):
        super(SubEnv, self).__init__(p_net, v_net, **kwargs)

===>
def __init__(self, p_net, v_net, controller, recorder, counter, **kwargs):
        super(SubEnv, self).__init__(p_net, v_net, controller, recorder, counter, **kwargs)

Thanks so much! I have made some similar changes, but the important thing is that there is no act method in pg_seq2seq`s net , I stop here. Can you run with these modifications?

@xuxi2569471573 Sorry, I don't know how to write this act either.

Thanks for your feedback and discussion. This bug has been fixed in the latest version (v0.4.0).

Thinks so much!


[edn/rtl] added fatal alert signal

Same as CSRNG, with less status bits.
Signed-off-by: Mark Branstad<EMAIL_ADDRESS>

thanks! LGTM!


Temporarily disable the Style/FormatStringToken cop

This currently raises a false positive on date format strings. Re-enable this once https://github.com/bbatsov/rubocop/pull/5230 is merged.

@nickcampbell18 ❤


Migrate primary branch from master to main

See https://github.com/Senzing/stream-loader/issues/283

Pull requests:

https://github.com/Senzing/docker-sshd/pull/65


Update constants.php

trigger alert patch for the lulz

It's very dangerous. Need more research.

The user needs to install https://github.com/zenovich/runkit for this to even have a chance at working but even then it won't work I think. They have a block on the true false booleans.


draft changes to bluetooth mesh for k_work API

This PR supports #33104 in updating the use of k_work delayable timers in the Bluetooth mesh implementation.  The API has been updated, and appears to work on one sample with limited testing.
It is in draft format, and all commits tagged DNM, because this needs significant review and rework from domain experts to address the following concerns.    At least one unrelated probable bug has been highlighted (in cfg_srv).  Overall:
On the whole this code does not appear to be correct in the presence of preemptive threads or SMP systems.  The use of atomic flags without an enclosing lock for operations that are not read-modify-write is not robust in those contexts.
There were many uses of k_delayed_work_cancel(), none of which took into account the possibility that cancellation can fail, and several of which would likely cause faults if the work item continued to be after the post-cancellation state updates were made.
It is generally not clear whether schedule or reschedule operations are appropriate.
My preferred path forward is for a mesh maintainer to take these commits and rework them as necessary.
(NB: This is currently based on and incorporates #33614 to support the sample.)

Mistakenly taken out of draft, as this is not intended to be merged as-is.  It's intended to be adapted by the maintainers of bluetooth who should verify and address the documented concerns.

@pabigot I have extracted the patches that needed non-trivial refactoring to separate PRs:

#34312
#34310
#34318
#34337
The rest I have amended to address all your inline comments and pushed to this PR. I believe this PR is ready to be taken out of draft.

@WilliamGFish Note that this PR has already been merged; if your comments are still relevant you need to an open an issue for them.

@WilliamGFish Note that this PR has already been merged; if your comments are still relevant you need to an open an issue for them.

Shall do when I get a chance...


File inside directory has broken path, file can't be found.

I'm not a programmer so am not sure what's going on but I have created an example so you can see what's happening: http://danielmee.com/dl/
If you click on /test directory and then on test2.mp3 you get a 404: "The requested URL /dl/test/test2.mp3 was not found on this server."
I note though that the URL says: /dl/test%2Ftest2.mp3 and not /test/test2.mp3.
Also reported in this google group post.

I believe this was resolved.  Please comment if you notice the issue again with the latest version of DL.


[WIP] add method to capture NSError

This PR introduces a method to capture NSErrors. It's a WIP and I'd appreciate any feedback. It also doesn't include any tests yet.
Message content
raven-swift and raven-objc have similar methods. This implementation, unlike theirs, does not send the errors description as message, as I find that to have bad readability and it may exceed the limit of 1000 characters for the message.
Instead, it sends messages similar to this:
NSURLErrorDomain.-1004 in SomeFile.swift:99 someFunc(_:params:)

I'd like to send a more readable error name, but the only thing available at runtime is localizedDescription, which can be in any number of languages.
A possibility to do this would be to ship a dictionary that maps error domains and codes to their respective names, but generating such a dictionary automatically is not trivial and maintaining it manually seems unfeasible (there are at least 57 error domains in the iOS 9.3 SDK).
userInfo
In addition, the userInfo dictionary is cleaned to be convertible to JSON and sent in extra["user_info"].
I'm not a fan of how I implemented this and I'd love suggestions on how it could be done better. I've tried to integrate this into the EventSerializable protocol, but couldn't make it work due to the infamous Protocol 'EventSerializable' can only be used as a generic constraint because it has Self or associated type requirements. .
Source location
I added #file, #line and #function parameters to the capture function. We might want to extend this to other functions and also send a single-frame stacktrace (this is what the other frameworks do), as the culprit doesn't seem to be displayed anywhere.
I have also not yet tested how (if at all) this is usable from Objective-C.

@ahti I will definitely try to take a look at this later this afternoon is possibly otherwise tomorrow morning. (I just moved over the weekend as I mentioned in another PR so trying to catch up to all the things I missed 😉  ).
Thanks for submitting what you have so far! I really appreciate the contribution and I will get back to you by tomorrow with any thoughts 👌

I rebased onto master and added tests etc. I also factored out the SourceLocation into an internal class that can be used in other capture...-messages as well (I can adapt captureMessage in a separate PR after this is merged).
I'm still not a friend of cleanValue and friends, but can't find a better solution either.
In the future, I'd love to find a solution to sending more than the numeric error code, but for now I think this is good enough (and better than what the other iOS clients do).

I think it may be best to leave it up to the developer to do this since it allows the developer to format the NSError or their own ErrorType as they wish. (i.e.)
switch type {
case .Error(let error):
    message = "\(error.domain)\n\(error.localizedDescription)"
case .AppError(let error):
    message = "\(error.domain).\(error.identifier)"
}
...
let event = Sentry.Event.build(message) {
    $0.level = .Error
    $0.culprit = "\(function) in \((file as NSString).lastPathComponent)"
    $0.releaseVersion = Device.currentDevice.appVersion
}
client?.captureEvent(event)

Given the Sentry seperates events based on the message, this should allow you to get unique entries for every error. It would be great if we somehow had control over setting the description line as well (or if it could take it from the second line of our message). It would also be nice if we could set the culprit to show on the event though :( https://github.com/getsentry/sentry/issues/3308 because then we don't really need to add one line of stack trace.
Given also that we have breadcrumbs it should give enough information that led up to the error. With all those things it probably wouldn't be necessary to have this added.

Sentry does not separate based on message/name - events are grouped by stacktrace but can be overridden by fingerprints.
That being said, I still feel like what this PR is adding will bring some value to this client. One change that might be nice is to change the message that is being sent.
Instead of..
NSURLErrorDomain.-1004 in SomeFile.swift:99 someFunc(_:params:)

... the message could be...
NSURLErrorDomain (1004) - Could not connect to the server.

...and then use the sentry.interfaces.stacktrace.Stacktrace interface (https://docs.getsentry.com/hosted/clientdev/interfaces/) which will show the stacktrace nicely in the UI (and group by that stacktrace)?
Let me know your thoughts when you get a chance!  Just woke up and didn't have enough ☕  yet so let me know if that doesn't make sense 😇

About how to label them.. after messing around with and filing this issue: https://github.com/getsentry/sentry/pull/3323. I finally was able to produce this result using the exceptions interface:

I'm now adding the interface to the SDK so then maybe we could use that for this :) I'm setting the title as error.domain and the description as error.localizedDescription

Using the exceptions interface seems like a smart idea!
The problem with using the localizedDescription is that it's localized. If a user is using an iPhone set to e.g. german language, an error might look something like this (NSURLErrorDomain.-1005): "Die Netzwerkverbindung wurde unterbrochen." So a single error might come in under multiple names, and most of those names would not be readable for the dev.

Hey, you're in Germany too! I'm in Berlin :)
That's actually a great point, I just tested it and indeed it separates the events. Maybe it's best to set the title as NSError and the description as error.domain (error.code) and setting the userInfo in the extras. The issues will be separated as they should and you'll be able to gather more details from the culprit and extras.
I've added basic exceptions support here (without stacktrace), so hopefully we'll see that in soon.

I played around with different options:

vs

I think the second options looks better and makes it easier for devs to find things quickly

The second one looks great, I think!
So if you folks agree I guess we can put this PR on ice until your exception-implementation is mergerd and then I'll rebase and adapt it to use that interface?

@ahti the PR adding the Exception interface has been merged in c59210eece9d301f5b419e5ad184e4fc91e35de9. You can go ahead and incorporate that into the error reporting 👍

This is what I do in my project maybe it can lead some direction :) where errorValue is "\(error.domain) (\(error.code))"

Sorry for taking so long with this.
I added the exception interface, rebased onto master and fixed some small things after the rebase.
While I'm still not 100% satisfied with sending error codes, I have not yet found a way to get better messages. So I think until we find one, this will be good enough.
Do you need any more changes before this can be merged?

@joshdholtz do you need any more changes before this can be merged?

@ahti It looks like there is a merge conflict still. Can you resolve that? 😊

@joshdholtz I rebased onto current master, tests are running fine for me, so this should be good to merge now

Thanks @ahti! Good work on this 👍


need to resolve this security issue and make sure things are good, finished comments too

You poop.
I fart.
We are not the same.


Adding capability to deconvolve using channel-by-channel templates

This PR is a breaking change and the deconvolution module will not be compatible with previous workflows without appropriate modifications to the respective fhicl files.
The modifications concern the deconvolution using any filter (default Wiener + Gauss post-filter).
Deconvolution module now takes a list of SPE template files in its configuration. Also, a map from channel to the particular template file needs to be provided.
The same mechanism is used to read in noise templates for the Wiener filter. Before the change, noise was assumed to be white noise, the same for all channels. This change enables data-driven noise filter.
Additional options were added, like a list of channels to be ignored and specification of the polarity of the input signals.
Associations between the raw waveforms (raw::OpDetWaveform) and the deconvolved waveforms (recob::OpWaveform) are now created, since there does not need to be a one-to-one correspondence anymore (some channels can be ignored).
The DeconAnalysis module has undergone major changes too. The analyser now outputs the deconvolved and the raw waveforms. They are stored in direectory structure based on the run and event number and by channel.
Due to unknown reasons (limitations in ROOT?) I needed to limit the number of output waveforms to 400 (*2 to account for raw and deco).

I'm currently trying to update the opdetdigitizer, in order to have more realistic simulated waveforms. I think we would profit of having a service for the templates, so it can be called by the simulation, the deconvolution or even reconstruction modules. We don't need to have the same templates in detsim vs deco, but the code is certainly the same. What do you think @vpec0 @lpaulucc ?

I'm currently trying to update the opdetdigitizer, in order to have more realistic simulated waveforms. I think we would profit of having a service for the templates, so it can be called by the simulation, the deconvolution or even reconstruction modules. We don't need to have the same templates in detsim vs deco, but the code is certainly the same. What do you think @vpec0 @lpaulucc ?

Maybe not a service, just a shared library. @mantheys may have done that already.,

Can we merge this already? @lpaulucc @absolution1?

@vpec0 this pull request is breaking the FD reconstruction CI test.  Deconvolution_module.cc seg faults on line 563 when running ci_test_reco_dunefd.fcl because TemplateMapChannels is empty by default.  Can we make this work with the FD today so I can make a software release on time?  My other option is to back out this pull request for now.

@aolivier23 I was afraid this could happen... Viktor is on vacation and will not be able to answer today. Maybe it would be better to hold this PR until next week?

Will do, thanks.  I made the mistake of merging it without running CI.  I think I can "revert" the merge and get back this PR.  I'll message you all if the location of this conversation ends up changing when I do that.

@vpec0 this pull request is breaking the FD reconstruction CI test. Deconvolution_module.cc seg faults on line 563 when running ci_test_reco_dunefd.fcl because TemplateMapChannels is empty by default. Can we make this work with the FD today so I can make a software release on time? My other option is to back out this pull request for now.

Do you have a link to the CI test? I want to check the fhicl file used in the test.
I have changed the default configuration slightly. Deconvolution.fcl now has a table specific for FD (no distinction between HD and VD yet). Fhicls that use dune_deconvolution table should now use a more specific table, either FD or PDHD.

@aolivier23
So, this PR cannot be reopened. The reversal in #66 makes it difficult to merge this branch into develop again...
I think we will need a new PR and possibly a new branch which would be branched of develop, have the reversal reversed and then the latest commits included.
Does anyone have a thought on this? Does anyone know how to do that?


Error when run tenancy:create

Description
Hello guys. I have production enviroment I export the system database and import it into my local environment but i got this error
In Connection.php line 664:
SQLSTATE[HY000]: General error: 1007 Can't create database 'f258e4a8871a4fa4951c4fbd
7346fad5'; database exists (SQL: CREATE DATABASE f258e4a8871a4fa4951c4fbd7346fad5)

Information

hyn/multi-tenant version: 5.0.17
laravel version: 5.5
database driver and version: mysql
webserver software and version: Laravel Valet 2.0.12
php version: 7.2.4

tenancy.php config
<?php

/*
 * This file is part of the hyn/multi-tenant package.
 *
 * (c) Daniël Klabbers<EMAIL_ADDRESS> *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see https://laravel-tenancy.com
 * @see https://github.com/hyn/multi-tenant
 */

use Hyn\Tenancy\Database\Connection;

return [
    'models' => [
        /**
         * Specify different models to be used for the global, system database
         * connection. These are also used in their relationships. Models
         * used have to implement their respective contracts and
         * either extend the SystemModel or use the trait
         * UsesSystemConnection.
         */

        // Must implement \Hyn\Tenancy\Contracts\Customer
        'customer' => \Hyn\Tenancy\Models\Customer::class,

        // Must implement \Hyn\Tenancy\Contracts\Hostname
        'hostname' => \Hyn\Tenancy\Models\Hostname::class,

        // Must implement \Hyn\Tenancy\Contracts\Website
        'website' => \Hyn\Tenancy\Models\Website::class
    ],
    'website' => [
        /**
         * Each website has a short random hash that identifies this entity
         * to the application. By default this id is randomized and fully
         * auto-generated. In case you want to force your own logic for
         * when you need to have a better overview of the complete
         * tenant folder structure, disable this and implement
         * your own id generation logic.
         */
        'disable-random-id' => false,

        /**
         * The random Id generator is responsible for creating the hash as mentioned
         * above. You can override what generator to use by modifying this value
         * in the configuration.
         *
         * @warn This won't work if disable-random-id is true.
         */
        'random-id-generator' => Hyn\Tenancy\Generators\Uuid\ShaGenerator::class,

        /**
         * Enable this flag in case you're using a driver that does not support
         * database username or database name with a length of more than 32 characters.
         *
         * This should be enabled for MySQL, but not for MariaDB and PostgreSQL.
         */
        'uuid-limit-length-to-32' => env('LIMIT_UUID_LENGTH_32', true),

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant specific files, including media, packages, routes and other
         * files for this particular website.
         *
         * @info If not set, will revert to the default filesystem.
         */
        'disk' => null,

        /**
         * Automatically generate a tenant directory based on the random id of the
         * website. Uses the above disk to store files to override system-wide
         * files.
         *
         * @info set to false to disable.
         */
        'auto-create-tenant-directory' => true,

        /**
         * Automatically rename the tenant directory when the random id of the
         * website changes. This should not be too common, but in case it happens
         * we automatically want to move files accordingly.
         *
         * @info set to false to disable.
         */
        'auto-rename-tenant-directory' => true,

        /**
         * Automatically deletes the tenant specific directory and all files
         * contained within.
         *
         * @see
         * @info set to true to enable.
         */
        'auto-delete-tenant-directory' => false,

        /**
         * Time to cache websites in minutes. Set to false to disable.
         */
        'cache' => 10,
    ],
    'hostname' => [
        /**
         * If you want the multi tenant application to fall back to a default
         * hostname/website in case the requested hostname was not found
         * in the database, complete in detail the default hostname.
         *
         * @warn this must be a FQDN, these have no protocol or path!
         */
        'default' => env('TENANCY_DEFAULT_HOSTNAME'),

        /**
         * Port.
         */
        'port' => env('TENANCY_DEFAULT_PORT', ''),

        /**
         * The package is able to identify the requested hostname by itself,
         * disable to get full control (and responsibility) over hostname
         * identification. The hostname identification is needed to
         * set a specific website as currently active.
         *
         * @see src/Jobs/HostnameIdentification.php
         */
        'auto-identification' => env('TENANCY_AUTO_HOSTNAME_IDENTIFICATION', true),

        /**
         * In case you want to have the tenancy environment set up early,
         * enable this flag. This will run the tenant identification
         * inside a middleware. This will eager load tenancy.
         *
         * A good use case is when you have set "tenant" as the default
         * database connection.
         */
        'early-identification' => env('TENANCY_EARLY_IDENTIFICATION', false),

        /**
         * Abort application execution in case no hostname was identified. This will throw a
         * 404 not found in case the tenant hostname was not resolved.
         */
        'abort-without-identified-hostname' => true,

        /**
         * Time to cache hostnames in minutes. Set to false to disable.
         */
        'cache' => 10,
    ],
    'db' => [
        /**
         * The default connection to use; this overrules the Laravel database.default
         * configuration setting. In Laravel this is normally configured to 'mysql'.
         * You can set a environment variable to override the default database
         * connection to - for instance - the tenant connection 'tenant'.
         */
        'default' => env('TENANCY_DEFAULT_CONNECTION'),
        /**
         * Used to give names to the system and tenant database connections. By
         * default we configure 'system' and 'tenant'. The tenant connection
         * is set up automatically by this package.
         *
         * @see src/Database/Connection.php
         * @var system-connection-name The database connection name to use for the global/system database.
         * @var tenant-connection-name The database connection name to use for the tenant database.
         */
        'system-connection-name' => env('TENANCY_SYSTEM_CONNECTION_NAME', Connection::DEFAULT_SYSTEM_NAME),
        'tenant-connection-name' => env('TENANCY_TENANT_CONNECTION_NAME', Connection::DEFAULT_TENANT_NAME),

        /**
         * The tenant division mode specifies to what database websites will be
         * connecting. The default setup is to use a new database per tenant.
         * In case you prefer to use the same database with a table prefix,
         * set the mode to 'prefix'.
         *
         * @see src/Database/Connection.php
         */
        'tenant-division-mode' => env('TENANCY_DATABASE_DIVISION_MODE', 'database'),

        /**
         * The database password generator takes care of creating a valid hashed
         * string used for tenants to connect to the specific database. Do
         * note that this will only work in 'division modes' that set up
         * a connection to a separate database.
         */
        'password-generator' => Hyn\Tenancy\Generators\Database\DefaultPasswordGenerator::class,

        /**
         * The tenant migrations to be run during creation of a tenant. Specify a directory
         * to run the migrations from. If specified these migrations will be executed
         * whenever a new tenant is created.
         *
         * @info set to false to disable auto migrating.
         *
         * @warn this has to be an absolute path, feel free to use helper methods like
         * base_path() or database_path() to set this up.
         */
        'tenant-migrations-path' => database_path('migrations/tenant'),

        /**
         * Seeds the newly created tenant database based on this Seeder.
         *
         * @info requires tenant-migrations-path to be in use.
         *
         * @warn specify a valid fully qualified class name.
         * @example App\Seeders\AdminSeeder::class
         */
        'tenant-seed-class' => DatabaseSeeder::class,

        /**
         * Automatically generate a tenant database based on the random id of the
         * website.
         *
         * @info set to false to disable.
         */
        'auto-create-tenant-database' => true,

        /**
         * Automatically rename the tenant database when the random id of the
         * website changes. This should not be too common, but in case it happens
         * we automatically want to move databases accordingly.
         *
         * @info set to false to disable.
         */
        'auto-rename-tenant-database' => true,

        /**
         * Automatically deletes the tenant specific database and all data
         * contained within.
         *
         * @info set to true to enable.
         */
        'auto-delete-tenant-database' => false,
    ],
    'folders' => [
        'config' => [
            /**
             * Merge configuration files from the config directory
             * inside the tenant directory with the global configuration files.
             */
            'enabled' => true,

            /**
             * List of configuration files to ignore, preventing override of crucial
             * application configurations.
             */
            'blacklist' => ['database', 'tenancy', 'webserver'],
        ],
        'routes' => [
            /**
             * Allows adding and overriding URL routes inside the tenant directory.
             */
            'enabled' => true,

            /**
             * Prefix all tenant routes.
             */
            'prefix' => null,
        ],
        'trans' => [
            /**
             * Allows reading translation files from a trans directory inside
             * the tenant directory.
             */
            'enabled' => true,

            /**
             * Will override the global translations with the tenant translations.
             * This is done by overriding the laravel default translator with the new path.
             */
            'override-global' => true,

            /**
             * In case you disabled global override, specify a namespace here to load the
             * tenant translation files with.
             */
            'namespace' => 'tenant',
        ],
        'vendor' => [
            /**
             * Allows using a custom vendor (composer driven) folder inside
             * the tenant directory.
             */
            'enabled' => true,
        ],
        'media' => [
            /**
             * Mounts the assets directory with (static) files for public use.
             */
            'enabled' => true,
        ]
    ]
];

webserver.php config
<?php

/*
 * This file is part of the hyn/multi-tenant package.
 *
 * (c) Daniël Klabbers<EMAIL_ADDRESS> *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see https://laravel-tenancy.com
 * @see https://github.com/hyn/multi-tenant
 */

return [

    /**
     * Apache2 is one of the most widely adopted webserver packages available.
     *
     * @see http://httpd.apache.org/docs/
     * @see https://www.digitalocean.com/community/tutorials/how-to-install-linux-apache-mysql-php-lamp-stack-on-ubuntu
     */
    'apache2' => [
        /**
         * Whether the integration with Apache2 is currently active.
         */
        'enabled' => false,

        /**
         * Define the ports of your Apache service.
         */
        'ports' => [
            /**
             * HTTP, non-SSL port.
             *
             * @default 80
             */
            'http' => 80,
            /**
             * HTTPS, SSL port.
             *
             * @default 443
             */
            'https' => 443
        ],

        /**
         * The generator taking care of hooking into the Apache services and files.
         */
        'generator' => \Hyn\Tenancy\Generators\Webserver\Vhost\ApacheGenerator::class,

        /**
         * The view that holds the vhost configuration template.
         */
        'view' => 'tenancy.generators::webserver.apache.vhost',

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant vhost configuration files.
         *
         * @info If not set, will revert to the default filesystem.
         */
        'disk' => null,

        'paths' => [

            /**
             * Location where vhost configuration files can be found.
             */
            'vhost-files' => [
                '/etc/apache2/sites-enabled/'
            ],

            /**
             * Actions to run to work with the Apache2 service.
             */
            'actions' => [
                /**
                 * Action that asserts Apache2 is installed.
                 */
                'exists' => '/etc/init.d/apache2',
                /**
                 * Action to run to test the apache configuration.
                 */
                'test-config' => 'apache2ctl -t',
                /**
                 * Action to run to reload the apache service.
                 */
                'reload' => 'apache2ctl graceful'
            ]
        ]
    ],

    /**
     * Nginx webserver support.
     *
     * @see http://nginx.org
     */
    'nginx' => [
        /**
         * Whether the integration with nginx is currently active.
         */
        'enabled' => false,

        /**
         * The php sock to be used.
         */
        'php-sock' => 'unix:/var/run/php/php7.0-fpm.sock',

        /**
         * Define the ports of your nginx service.
         */
        'ports' => [
            /**
             * HTTP, non-SSL port.
             *
             * @default 80
             */
            'http' => 80,
            /**
             * HTTPS, SSL port.
             *
             * @default 443
             */
            'https' => 443
        ],

        /**
         * The generator taking care of hooking into the nginx services and files.
         */
        'generator' => \Hyn\Tenancy\Generators\Webserver\Vhost\NginxGenerator::class,

        /**
         * The view that holds the vhost configuration template.
         */
        'view' => 'tenancy.generators::webserver.nginx.vhost',

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant vhost configuration files.
         *
         * @info If not set, will revert to the default filesystem.
         */
        'disk' => null,

        'paths' => [

            /**
             * Location where vhost configuration files can be found.
             */
            'vhost-files' => [
                '/etc/nginx/sites-enabled/'
            ],

            /**
             * Actions to run to work with the Nginx service.
             */
            'actions' => [
                /**
                 * Action that asserts nginx is installed.
                 */
                'exists' => '/etc/init.d/nginx',
                /**
                 * Action to run to test the nginx configuration.
                 */
                'test-config' => '/etc/init.d/nginx configtest',
                /**
                 * Action to run to reload the nginx service.
                 */
                'reload' => 'systemctl restart nginx'
            ]
        ]
    ]
];

I export the production environment databases to my local environment, and when I run the command tenancy: recreate I got the error. I deleted  tenant's databases, i run the command again and I got this error:
SQLSTATE[42000]: Syntax error or access violation: 1133 Can't find any matching row   in the user table (SQL: GRANT ALL ON f258e4a8871a4fa4951c4fbd7346fad5.* TO f258e4<EMAIL_ADDRESS>IDENTIFIED BY '3af925c8111f11f1979c13c1dd41e   2c8')
I could not replicate my production environment in my local environment

The process should be like the following;

export system database from production
import system database into (clean) local environment
run tenancy:recreate
export and import the tenant database from production into local development

Unless I'm missing something obvious.

I has followed your instructions and get this error on step 3, any suggestion?

Seems like your system user has insufficient permissions. Is that system user set up with the GRANT option? Have you tried configuring system with a root user temporarily to see whether that resolves the issue?

As you requested I'm following up on this issue @luceos
I think this is the same issue, so I will post my comments here.
It fails at the Set Command in the tenantDatabaseExists in the TenantRecreate Command:
$this->connection->set($website);
Because either the db user oder database is not known
Instead I need to figure out how to perform this checks with the system connection
Ok, I got it running for my specific case with some major changes but I want to give some hints for the package:
When you are setting the connection for the check, you expect that there is a working connection for this tenant
If this fails the method returns false without knowing what exactly failed
Then the Created Event is emitted as if there was a new Website created
There are two problems so far:

The config which is needed for the created event is not generated because there was an error beforehand in the set method of Database\Connection.php.
In MariaDB (didn't look at the others) the create database command needs to be "CREATE DATABASE IF NOT EXISTS " instead of  just "CREATE DATABASE " because you don't know if the reason for the error was because of the database, the user or the Grant permission.

The following test would reproduce the errors:

Create Tenant
Delete Tenant Database and Database User or one of them
Run Tenancy recreate
If this suceeds the method is working as expected.
Currently the method only works if the database is deleted but the user remains.

@f0reclone thanks for your due diligence, this helped a lot!

Have this same issue for 2 days now, can't figure out where the " CREATE DATABASE " line is
Kindly help @f0reclone

@C-Spydo You can find the fix from @luceos here:
https://github.com/hyn/multi-tenant/commit/59fcda0fc69b13746d767cfc6f12adc0ef303ac8


call to_s on direct tokenization params

confirmed in docs that they expect a string for all of the tokenization params


Clean up jump box script in Helix Machines and related docs.

Doesn't really work and causes problems.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[x] Internal Infrastructure Improvements

Release Note Description
No release notes needed.

Second PR: https://dnceng.visualstudio.com/internal/_git/dotnet-helix-machines/pullrequest/45003

Everything is merged. Closing!


How to use ACF 'File' Field

Hello,
I have a ACF 'File' Field on my site but it is not outputting properly on my archive page.
I've tried with the setting to output 'File URL' and using the following code:
$context['file_url'] = get_field( 'file_url' );
And {% for post in posts %}{{ post.file_url }}{% endfor %} to display it.
I've also tried using an array:
$file = get_field( 'file' );
$context['file_url'] = $file['url'];

And {% for post in posts %}{{ post.file_url }}{% endfor %} to display it.
But none of the above work, I've even tried outputting the ID and using $file = wp_get_attachment_url( $file ) but that doesn't work either.
How can I display my file field information on my archive template within the for each post?
Thanks in advance

@elliottmangham from the code it looks like it's just an issue with how you're sending data, if you have...
$file = get_field( 'file' );
$context['file_url'] = $file['url'];

It will be available in Twig as...
Download my file: {{ file_url }}

... as opposed to making it a child of the post object

@jarednova I have tried that and while it does appear to post the file url, it is displaying the same one for all posts on the page. It is displaying the latest post on all of them as opposed to the relevant one. Any ideas?
Kind regards

@jarednova I am having to do the following to find the guid, is there not a better Timber-based solution?
foreach($context['posts'] as $post) { 	if($post->file) { 		$post->file = get_post($post->file)->guid; 	} }
This is in an 'archive-{custom-post-type}.php' file. I'm just trying to find the data for the 'ACF File Field' in each post.
Thanks in advance.

Hey @elliottmangham this should also work if you want to skip the PHP...
{% for post in posts %}
    Download
{% endfor %}

... give that a shot and let me know how it goes

Hey @elliottmangham
If you have the file ID, you can convert it to a TimberImage (you can think of a TimberImage as an attachment, you can also use it on non-images). Then you can access all the information you need.
PHP
foreach ( $context['posts'] as &$post ) {
    // Convert attachment id to TimberImage object
    $post->file = new \Timber\Image( $post->file );
}

When you now look $post->file, the only field that has the URL in it is guid. But the purpose of guid is not to access the URL of a file. Instead, use the src method of your TimberImage object to get the URL.
PHP
$url = $post->file->src();

Twig
{% for post in posts %}
    {# Access the URL of the file through file.src #}
    Download {{ post.file.title }}
{% endfor %}

Twig only
{% for post in posts %}
    {% set file = TimberImage(post.file) %}
    Download {{ file.title }}
{% endfor %}

@gchtr perfect, thanks! Worked straight off the bat.

Hi @gchtr,
Unusually - while this does work... It converts the file (PDF) into a jpeg. So when the user clicks on the entry, I want it to open the PDF file that was uploaded. But by using your technique, it opens the PDF prepended with .jpeg. I.e. 'file_name.pdf.jpeg'.
Please help!
Kindest regards,

@elliottmangham I think this is an error that was fixed in https://github.com/timber/timber/pull/1365.
Can you install the latest release 1.3.0-beta (https://github.com/timber/timber/releases/tag/1.3.0-beta) and check if that still happens?

@elliottmangham Is this still something you're actively working on or need addressed? Please respond in two weeks or we'll close this thread


ability to export more than 2000 resources

This is working in DLVR. Will go over how it works. Currently the emails are not being sent because it doesn't appear that the SMTP (email) server is accessible from the application servers. Opened a ticket to infrastructure here: https://apps.nrs.gov.bc.ca/int/jira/browse/BCFMS-74


Update README.md

updated availability

Hi sir,I am Naveen from edyoda MERN stack interview preparation batch.Here
I got some project Ideas enclosed in a docx file.
Thank You.
On Wed, 20 Sept 2023 at 20:31, Patel Neel Mahesh @.***>
wrote:

@.**** requested changes on this pull request.
Send your Project Name, will create a Repo for you and do the PR there.
—
Reply to this email directly, view it on GitHub
https://github.com/codinggita/TCS/pull/2#pullrequestreview-1635867115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5AGFDK3K7MUVAS3CQO3MQ3X3MAMNANCNFSM6AAAAAA5ACEGWI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Gamera car accessories (GCA)
Features:
1)Door to Door pickup and drop service
2)buying options
3)dispatch and delivery live tracking
4)userguide
frontend:
1)Home
2)blog
3)accessories details
(
Performance Parts and Tuning:
Exterior Accessories:
Car Audio and Electronics:
Car Care and Detailing Products:
Off-Road and 4x4 Accessories:
Roof Racks and Cargo Carriers:
Tire and Wheel Accessories:
Car Security and Safety Products:
Customized License Plates and Frames:
Vintage and Classic Car Accessories:
Smart Car Accessories:
Interior LED Lighting Kits:
Car Organization and Storage Solutions:
Custom Decals and Graphics:
Car Subscription Box:
Electric Vehicle (EV) Accessories:)
4)Discounts
Admin Roles:
1)add new items.
2)update some offers.
3)adding some retail shop products.
Backend:
1)user Data(credential)
2)payments
3)live tracking

Hey Naveen, you need to send an email to<EMAIL_ADDRESS>regarding the above project.


after installing or upgrading extension(s) open explorer viewlet on restart

Most (all?) of the time when I restart VS Code after installing or updating an extension, I don't want the extension viewlet open on restart.
My mental model is that I've discovered and installed all of the extensions I'm interested in and upon restart I want to start using them. I want to start opening files (e.g. a Dockerfile after installing DockerSupport) and rarely do I want to search for new extensions or mange the existing ones.
I suggest that upon restart after installing/updating an extension that we go back to the Explorer view.

@chrisdias please see https://github.com/Microsoft/vscode/issues/8269


Config issue about MatrixVT

Hi,
When I train or eval matrixvt, I got an error:
TypeError: init() missing 2 required positional arguments: 'backbone_conf' and 'head_conf'

hi，this is due to model initialization. change this line into "super(BaseBEVDepth, self).init()" will help. We'll fix this bug soon, thanks for reporting

Thanks for your quick reply!


Indeterminate order generates unneccessary diffs in Pipfile.lock when upgrading.

My Pipfile.lock contains many lines of the following form:
"markers": "python_version != '3.2.*' and python_version != '3.0.*' and python_version != '3.1.*' and python_version >= '2.7' and python_version != '3.3.*'",

and after an unrelated change, this line is changed into
"markers": "python_version != '3.0.*' and python_version != '3.2.*' and python_version != '3.3.*' and python_version != '3.1.*' and python_version >= '2.7'",

i.e. the same content but different order. It would be great to keep the order deterministic in order to keep the diffs small when updating.

This is essentially #2760. Closing in favour of that since it came first, and has a more descriptive title.


[Front] Footer

With following links:

Legal Mentions
Personal Data
FAQ
Credits / team / backers (daily.co, ovh, twilio)
Blog (promis un post aux founders de daily)
Contact

Footer created & Legal Mentions, Personal Data, Credits, Blog and Contact links done. FAQ still missing

it's done no?

FAQ is still missing but we can open an issue specifically for this


How are the SINet.onnx and SINet_Softmax.onnx files created?

I am working on model conversion for different platforms using your repository. This exact SINet.onnx version works (and SINet_Softmax.onnx also works!). The SINet_ONNX.ipynb script exports onnx which I am not able to convert.
How exactly did you create SINet.onnx and SINet_Softmax.onnx?

What is the error?
I hope you read the note section in the ipynb

Note: The original SINet class file was modified at line 116, i.e x.size() to [int(s) for s in x.size()] . This makes the size value static and prevents error during onnx conversion. Also, some layers like ReduceMax may not be fully supported in opencv onnx runtime, so replace this operation with appropriate reshape and maxpool layers.

What is the error?
I hope you read the note section in the ipynb

Note: The original SINet class file was modified at line 116, i.e x.size() to [int(s) for s in x.size()] . This makes the size value static and prevents error during onnx conversion. Also, some layers like ReduceMax may not be fully supported in opencv onnx runtime, so replace this operation with appropriate reshape and maxpool layers.

There was a simple problem of ONNX compatibility with pytorch model.

There was a simple problem of ONNX compatibility with pytorch model.


use absolute path from setup.py path to read requirements file

Description
using absolute path for reading the requirements.txt
Motivation and Context
file can not be found when importing qiskit by adding its path to the system paths, like
sys.path.insert(1,'../../qiskit-sdk-py')
from qiskit import QuantumProgram
because open expects the file in the current working directory, which might be the directory of a jupyter notebook
How Has This Been Tested?
tested under Linux and Windows
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks, @alfrisch ! It seems we might encounter more similar issues due to reading requirements.txt from setup.py (for example, sphinx might also suffer from a similar problem) - I'll investigate a bit the issue but it seems that the right fix will probably be reverting the and going back to having the dependencies explicitly declared on setup.py.

Upon further investigation, the solution for avoiding duplicating the dependency list based on reading requirements.txt from setup.py seems still not solid enough for this release - so it has been reverted at bdf1fa215be08a3b815942c529a6ea096bf3af80.
I'm closing this PR as a result, but please comment back if you encounter any other similar issues, and thanks for the proposed fix and for raising it!


Bump up the k8s version to v1.25.10 to fix the existing Kubelet bug

What do these changes do?
As titled. Refer the info https://github.com/advisories/GHSA-xc8m-28vv-4pjc

It's hard to revert the k8s to an old version as the minimal k8s version of dependencies is v1.25.0, so it's better to backward compatible.


Make build.gradle consistent with gradle.properties

The gradle.properties file assumes JDK9, this means all the JavaFX version checking in build.gradle can be removed since JavaFX comes as standard with JDK9.
However GroovyFX does not build with the current JDK9 :-(

Coverage remained the same at 16.439% when pulling 7f559cb235db6e3bd30e51a428b446524836e0b2 on russel:master into c9b2a742e237198c99a2e215adccb3f034c13470 on groovyfx-project:master.

Coverage remained the same at 16.439% when pulling 0ad7f3700a1034533c31e973c4997b85aa2915a5 on russel:master into c9b2a742e237198c99a2e215adccb3f034c13470 on groovyfx-project:master.


settings: Move set_settings_header to settings_panel_menu

(29, 8) → (28, 7).

Sure, this seems like a convenient fix.


Revert "[UI] Send toaster informational notification upon save of design"

Reverts meshery/meshery#8486
This PR does build, @Chadha93, and failed the stable release. 😞

Reverts #8486
This PR does build, @Chadha93, and failed the stable release. 😞

@leecalcote I'm looking where was the issue, I rebuilt the branch and tested it, and everything worked fine, and in the CI, the build was passing. :thinking:

CI - https://github.com/meshery/meshery/actions/runs/5878822469/job/15941663301.

Video -

https://github.com/meshery/meshery/assets/65453826/adb0928d-b66f-4dd0-92b8-7ab99c1f70f4


chore: relocate owl bot post processor

chore: relocate owl bot post processor

I filed a bug about 404 error at #371
Temporarily removing ci/docs and merging


Generic Host - Is there any way to handle stopping service beside writing log?

Hi all, I am currently implement a Windows Service by Generic Host of .net core 2.1. I implement a timer run periodically in there, but still don't know the official way to manage the service or the timer (Like Hangfire dashboard).
Do you have any best practice, can share for me? Thank you so much

Hello @huyjack178 ... The only information we have at this time on using the Generic Host as a Windows Service is the comment on the prototype posted here :point_right: https://github.com/aspnet/Hosting/pull/1492#issuecomment-405298223. If you need further information on the prototype, I recommend asking on that issue.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


[New game]: Rock, Paper, Scissor, Spock and Lizard

🎮 Game Request
Rock, paper and scissor was a fun game to play. But rock, paper, scissor, spock and lizard is a more advanced variation of the game and much more fun to play.
The game logic is as follows

Point down the features
Game played between two players, and here the other player will be the computer. The game will ask the user to input a character(based on the thing he wants to choose) and computer will randomly choose one of the options. Based on logic implemented in the code, winner will be declared. One can play as much as one wants to. The points of the user will be noted down in the top left.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @prrockzed !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @prrockzed 👋!
@kunjgit here,
We have this annoucement to make 📢!!
During the time of PR don't alter main index file ! 🙂
In main Readme file just use * as a game number during the time we are merging we will add number !! 👀
Make sure you join our Discord🕹 if you haven't 😇
Thank you 💗!

Hello @prrockzed, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @prrockzed ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Getting 403 forbidden when trying to use the bot in teams but works in bot framework emulator

Hi,
I have created a Bot using the BotBuilder SDK.
I am getting a 403 forbidden error shown in ngrok when trying to use the bot in teams.
I have ngrok running and have tested using the Bot Framework Emulator connected to the ngrok endpoint and it behaves as it should
Is there a reason why it would be returning a 403.. its as if the bot does not have permission ?

I forgot to add my AppId and Password to .bot file. works now :facedesk:


Change Travis build scripts

Tested that TravisCI and Codecov integration worked in npm-test branch. Everything seems to go smoothly.
Now npm test also gives code coverage stats from nyc, and any successful TravisCI builds will push code coverage data from nyc to Codecov.

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          30     30
=====================================
  Hits           30     30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4112d8...de817c8. Read the comment docs.


Mobile View: Navigation menu

Bugs to Fix

Font should be white.
Menu should be in upper right hand corner.
Top-level navigation items should not have a hyperlink (should not reload the page).

Screenshots

Here , I think only the last part of the bug is left out, as the first first bug was fixed in my previous PR itself. Correct @leecalcote ?

Yes, I think the only residual issue here is that the hamburger (mobile) menu is left aligned, not positioned in the upper, right hand corner.

Yes, I think the only residual issue here is that the hamburger (mobile) menu is left aligned, not positioned in the upper, right hand corner.

I meant the last issues of page reload on top-level navigation items. The hamburger has been right aligned in the changes made in the #237 PR. You can confirm it from the meshery.io site.


test: http2-enable watcher and iso format logs in soak test

Description
Configures soaked watch controller to use http2 watch mode.
Enables "ISO"-style logging to make comparison of cluster logs & watcher logs simpler.
Related Issue
Relates to #1276
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Other (security config, docs update, etc)

Checklist before merging

[x] Unit, Journey, E2E Tests, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

All tests have passed, this is not being reported to the GitHub UI and we need this for our nightly soak test.


JSON Generator

[ ] Write a generator to produce a merged JSON output of post URLs, titles and their description.

added a ParseJsonMerged method to parser.go in adhesh's branch. It creates a json file with merged data at static/scripts/merged.json with the following content:
{
    "docs.md": {
        "CompleteURL": "docs.html",
        "FilenameWithoutExtension": "docs",
        "Frontmatter": {
            "Title": "Anna Documentation",
            "Date": "",
            "Draft": false,
            "JSFiles": null,
            "Type": "",
            "Description": "",
            "PreviewImage": "",
            "Tags": null
        },
        "Tags": null
    }

@anirudhsudhir review anna_engine_test.go and engine tests file structure for the unit tests related to this function.
There should be no merge conflicts in my opinion. Keep this issue open, as of now its just a pure js implementation, and needs to be fully integrated with Adhesh's wasm version

@anirudhsudhir theres a small issue with the json generation. We copy static directory contents before we create the the index.json file. This becomes an issue while working with personal sites. There is a creation of index.json but it isn't part of the rendered directory

snippet from anna.go
helper.CopyDirectoryContents(helpers.SiteDataPath+"static/", helpers.SiteDataPath+"rendered/static/")
e.GenerateJSONIndex(helpers.SiteDataPath


Remove AudioBusEmpty.svg, use ProgressBar tint instead

A buffed version of #76950. Allows for removing a rather heavy 6 kB svg texture, making Godot 0.005% lighter!

I plan to go through with making our svg files nicer and more optimized in the future, but I don't think anything else can be removed so neatly. There are other cases of SVGs that share the shape but not the color (you know 'em, stuff like Camera2D and Camera3D). It's just that this one only appears in one context where ProgressBar tint makes a lot more sense to use.
We should have a dedicated discussion about this and I plan to do some further work, but for starters, here are some things I noticed in SVGs:

We have a lot of copied icons with switched colors, as I said above. This usually happens with nodes (as every node seems to just search for its name in the folder) and GUI elements. I don't think any of these cases can be changed.
We have a lot of copied icons with different orientations or rotations, like GuiTreeArrowDown and GuiTreeArrowLeft. I don't think any of these cases can be changed either.
We have a few identical icons used in different contexts (e.g. ImportError, MissingNode, MissingResource). I dunno about these, the latter two I think need to stay, but ImportError isn't a class.
We have some super similar icons, some of which might be pointless, they can probably be investigated on a case by case basis.

Aside from this, editor/icons svg's have some quirks that are probably unintentional increasing their size. The main two I see are weird transforms, and using paths instead of simple shapes :) (circles, ellipses, and rounded rectangles are always more optimal than paths). Ones that are outside of editor/icons (e.g. CSGCylinder3D) are uglier, which makes me think they have been missed in some optimization long ago.

Thanks!


WASM Package

I think the binary file will be okay because that will not change, but the update.yaml will change frequently just by the nature of using go-vcr. I think this could easily inflate the git history, which over time will significantly slow down git operations.

I've added recordIgnoreBody which adds a filter to set the body to "" in the recording. This seems to do the trick for the fixtures.

I think the binary file will be okay because that will not change, but the update.yaml will change frequently just by the nature of using go-vcr. I think this could easily inflate the git history, which over time will significantly slow down git operations. This is a major concern because this is a library that a lot of users use and will frequently go get.

I've added recordIgnoreBody which adds a filter to the recorder which sets the body to "". This reduces down the fixture size to a normal size whilst still returning an appropriate response.


Add logging to HttpsPolicy middleware

Logging:

When Hsts header is added or blocked
HttpsRedirection, url redirect to.
Any major error cases (misconfigured https port, etc.)

There is some logging now in HttpsRedirectionMiddleware, but not in HstsMiddleware. It would definitely be useful when trying to figure out why the header is or isn't being returned. I'll work up a PR.


How can I set the ipt_args option, thank you

I want to use this function to set the port of the proxy. I tried a lot of writing methods and it is not successful. Please tell me how to set it in luci, thank you.

There is no ipt_args function in LuCI.

This is the setting file content in shadowsocks, which has option ipt_args
vi /etc/config/shadowsocks-libev
config ss_rules 'ss_rules'
option redir_tcp 'hi'
option src_default 'checkdst'
option dst_ips_bypass_file '/etc/chinadns_chnroute.txt'
option dst_default 'forward'
option local_default 'checkdst'
option redir_udp 'hi'
list src_ips_bypass '<IP_ADDRESS>'
list src_ips_bypass '<IP_ADDRESS>'
list ifnames 'br-lan'
option ipt_args '--dport 21:1024'

This is a screenshot of the luci settings interface
https://1drv.ms/u/s!AiC3DiZkYVCHhNAxalebwY-UPfYAUg