Consider having the k8sattributesprocessor in the default configuration for Collector Getting Started with K8s

This was discussed in https://github.com/open-telemetry/opentelemetry.io/issues/370
Today, we point at a manifest that doesn't have the k8sattributesprocessor. It's a very valuable processor that people are likely to use when in the context of k8s.
Currently, the file we recommend pulling in lives in the upstream collector repo. So if that file were to change, it'd have to include the processor. Otherwise, we'd have to consider a different command to get started with.

You mean https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector/main/examples/k8s/otel-config.yaml ?
That issue should then be raised with the collector repo?

The reason it isn't included by default in that example, and why it isn't included by default in the collector helm chart, is that it requires extra permissions.  Requiring elevated permissions in a default scenario gets kinda tricky.

Sure, the processor's documentation has a good RBAC section to help users.  Should be able to link to that.


add_resource does not preserve api function docstring

I'm trying to auto generate API help using this piece of code:
@app.route('/api/help', methods=['GET'])
def api_help():
    """Returns all registered APIs available in this application."""
    func_list = {}
    for rule in app.url_map.iter_rules():
        if rule.endpoint != 'static':
            func_list[rule.rule] = app.view_functions[rule.endpoint].__doc__
    return jsonify(func_list)

It relies on __doc__ of a function and works fine for APIs defined with a route decorator:
@app.route('/someapi'...
However, when a route is registered with add_resource the docstring is lost.
The help api returns data in this format:
{
  "/api/help": "Returns all registered APIs available in this application.",
  "someapi": null
}

tried on latest versions:

Name: Werkzeug
Version: 0.11.11
Name: Flask
Version: 0.11.1
python --version
Python 3.5.1 :: Anaconda 4.0.0 (64-bit)

The documentation is preserved, just not quite how you were expecting. With resources, the class is the view function, so you can't document get/post/etc separately.


Compute multi-spec repositories automatically

The list of multi-spec repositories was hardcoded and slightly outdated. The update now computes that list automatically from the data present in the results of the crawl (which comes from browser-specs). Compared to the previous list, the new logic misses w3c/woff because it voluntarily skips repositories that contain multiple versions of the same spec to avoid false positives. It adds:
https://github.com/httpwg/http-extensions
https://github.com/immersive-web/real-world-geometry https://github.com/w3c/aria
https://github.com/w3c/encrypted-media
https://github.com/w3c/gamepad
https://github.com/w3c/reporting
https://github.com/w3c/webcodecs
https://github.com/WebAssembly/threads
https://github.com/WebBluetoothCG/web-bluetooth
https://github.com/WICG/nav-speculation
https://github.com/WICG/shape-detection-api
https://github.com/WICG/WebApiDevice
Some of them contain one "main" spec and side specs that we will probably ignore for some time, but then it does not hurt to prefix issues with the spec's shortname in such cases, even if the targeted spec is somewhat obvious.

Taking the liberty to merge as I'm working on a rewrite that needs this.


mgmt-hub: agbot-tmpl.json contains an invalid JSON document

The agbot configuration template appears to have an error message in the first line, making it an invalid JSON document after being templated with envsubst. This breaks the agbot container when the management hub is installed, and could break the agbot container when a deployment is updated or otherwise changed by the all-in-one script.
Steps to reproduce:

Install the management hub on a system using the all-in-one installer script.
Observe that the management hub fails to install due to not being able to reach the exchange.
Observe that, in the output of docker logs agbot, the service is panicking and restarting due to invalid characters in its configuration file.

@naphelps it looks like you committed this file: https://github.com/open-horizon/devops/blob/548a1dbe6cf864ee461569eebe04a12bb4071dd2/mgmt-hub/agbot-tmpl.json

Fixed in master and new-mongodb.


V3 templating upgrade

What is the context of this PR?
Updated runner to use the new design system macros to render templates. I had to create quite a lot of (poorly written) jinja filters to format the configs for some of the macros / add extra attributes for functional/intergration tests to use so I don't know if it would be a separate task to refactor these and make them not so terrible.
How to review

clone: https://github.com/ONSdigital/design-system
change to update-npm-package-for-flask branch
run yarn to install dependencies
run yarn start to boot dev server
symlink design-system/src/styles/page-template to eq-survey-runner/app/templates/layouts2
symlink design-system/src/components to eq-survey-runner/app/templates/components
boot local runner

Skipped tests
I have skipped some of the functional tests for now as I'm unsure how to fix them:

save_sign_out.spec.js: I'm not sure if this is a schema error, but the save and sign out button doesn't seem to be appearing when it should. This also seems to be the issue in the v3 branch.
static-feedback.spec.js and test_feedback.py: I'm not sure if we're actually going to be using the standalone feedback page rather than the footer one yet so didn't dig into why this was failing too much.

Failing tests

test_app_create.py => test_enforces_secure_headers: This is because i've added localhost:3030 to the security headers temporarily so I could pull the design system css/js from a local branch.
test_render_percentage_widget.py => test_percentage_widget_has_icon couldn't figure out how to update the regex on this one... is there a better way of selecting DOM element's contents using BeautifulSoup?
test_questionnaire_language.py => test_load_non_existant_lang_fallback: Doesn't seem to be putting language_code back to 'en' when a non existent language_code parameter is added, causing the language switcher macro to fail.

Checklist

[ ] Check templates are rendering correctly (there may be some minor spacing issues to address so if you spot anything funky looking let me know)
[ ] Check performance isn't adversely affected.

Still to do

[ ] Deploy built CSS/JS/Images/fonts etc to CDN
[ ] Figure out a way to import macros to the project as a dependency

Good effort Ben, looks like a hefty piece of work and can't have been easy. This is definitely a step in the right direction. Removing more presentational concerns from EQ will decrease coupling of this problem from the application and promote code reuse across the service, potentially further.
This is a first visit of integrating externalised templates into EQ, but catching problems early on will save a lot of time and money, some observations;

A lot of conditional config mappings in templates/base-templates to meet macro preconditions, this will be unavoidable to a certain extent but could we organise/arrange this better? _base.html has a bit too much logic in one file. It’ll probably be the case that the application would have to adjust to supply the correct view-model mappings for the templates.

There’s a lot of great reuse with low level components but it would be great to see more structural level components used where you can inject arbitrary content inside a structural node. Good examples of these would be: header, body, footer (for example, this is currently used with the onsPanel component using caller()).

Not too sure about using the parameters “classes” and “attributes” for some of the macros and probably should be a last resort. It means the calling context knows too much about the inner workings of exact markup/styles/behaviours that are imported from the design system for each component causing tight coupling. You wouldn’t be able to change the name of classes/attributes in the design system without changing all applications that integrate with it.

Would be good to see less hard-coded HTML removed to completely abstract presentation markup in future, kind of a given.

Good effort Ben, looks like a hefty piece of work and can't have been easy. This is definitely a step in the right direction. Removing more presentational concerns from EQ will decrease coupling of this problem from the application and promote code reuse across the service, potentially further.
This is a first visit of integrating externalised templates into EQ, but catching problems early on will save a lot of time and money, some observations;

A lot of conditional config mappings in templates/base-templates to meet macro preconditions, this will be unavoidable to a certain extent but could we organise/arrange this better? _base.html has a bit too much logic in one file. It’ll probably be the case that the application would have to adjust to supply the correct view-model mappings for the templates.
There’s a lot of great reuse with low level components but it would be great to see more structural level components used where you can inject arbitrary content inside a structural node. Good examples of these would be: header, body, footer (the onsPanel component using caller()).
Not too sure about using the parameters “classes” and “attributes” for some of the macros and probably should be a last resort. It means the calling context knows too much about the inner workings of exact markup/styles/behaviours that are imported from the design system for each component causing tight coupling. You wouldn’t be able to change the name of classes/attributes in the design system without changing all applications that integrate with it.
Would be good to see less hard-coded HTML removed to completely abstract presentation markup in future, kind of a given.

I think you've raised valid points, definitely worth us discussing in a tech session or design meeting.

I agree about the conditional mappings, I think the amount of mapping in templates should be minimal, and most of the mapping be done in python to create a view model for the templates. There are a lot of jinja filters I created to map things for components, but these should be run before the view is hit, rather that from the view. This is quite a big thing to fix and will likely need to be a separate piece of work.

Structural components are something we're quite weak on in the design system, as really we've only really been working with components as units, and not actually any page structure (the anatomy of a question for example), so I think we can definitely improve this by creating more macros that are purely for structure. It's something we should discuss in a design meeting.

You're right about classes and attribute only being a last resort. I think a lot of components rely on you manually applying a class such as btn--secondary to change it's presentation rather than that being abstracted to some other parameter that sets the correct classes to change the presentation of that component. Those parameters should only be used to add stuff like data-ga attributes etc, and utility classes. If you spot examples of those attributes being misused though, if you could let me know or place a comment against the relevant component in the design system forum we can get on top of those issues.

I think we can reduce the amount of HTML hand coded in templates by creating more macros dedicated to structure, but considering a lot of content in runner is hard coded rather than populated from a CMS WYSIWYG, there will always be a small amount knocking around.

I'm hitting a few errors when running the integration tests:
jinja2.exceptions.TemplateNotFound: _themes/default/sectionsummary.html
Looks like there's still some setup code referencing themes. Do we need to remove all of this?

I'm hitting a few errors when running the integration tests:
jinja2.exceptions.TemplateNotFound: _themes/default/sectionsummary.html
Looks like there's still some setup code referencing themes. Do we need to remove all of this?

I think so, removing all theming for now.

When clicking the Contact Us link while viewing in Welsh, I'm running into a 500, looks like it's related to the brackets around ru_ref?

{{ _("Please quote the reference %(ru_ref)s when contacting ONS about this survey.", ru_ref=session.ru_ref) }}

  File "/Users/forter/virtualenvs/eq-survey-runner-mBP_POI1/lib/python3.7/site-packages/jinja2/ext.py", line 134, in _gettext_alias
    return __context.call(__context.resolve('gettext'), *args, **kwargs)
  File "/Users/forter/virtualenvs/eq-survey-runner-mBP_POI1/lib/python3.7/site-packages/jinja2/ext.py", line 143, in gettext
    return rv % variables
ValueError: unsupported format character '(' (0x28) at index 27```

The padding around guidance doesn't look quite right to me.

Another padding issue.

The main text on the twisty here isn't showing up:

I'm not sure about this, but the thank you page looks a little more condensed than it used to.

On test_final_confirmation.json, the submit button is showing inline:

Not sure how to explain it but every time you load the definitions, you can see/notice the transition (flicker) from non-js to js version when the js scripts are loaded. Give me a shout if it doesn't make sense and ill explain in person.

For the summary and pages after summary ie, submission etc, the page content width has been increased, is that intentional?

Answer option description alignment issue?
Before:

After:

@will-madebymoon asked for this to be changed here: https://github.com/ONSdigital/design-system/issues/56#issuecomment-456444482

The summary seems very padded. Also the Change link is missing as well as the Previous link?
Before:

After:

I've fixed the missing change links, but I'm not sure what the padding on that summary should be... will have to ask @will-madebymoon

The print button not looking so good today :P

This will be fixed once this pr is merged and released: https://github.com/ONSdigital/design-system/pull/362

eady rendered in. Give me a shout if it doesn't make sense and I'll explain in person. Doesn't happen with the current version of v3.

Will need to take a look when we're both in, it shouldn't be slow enough to see the flicker... we can raise a bug against that component in the design system.

For the summary and pages after summary ie, submission etc, the page content width has been increased, is that intentional?

All pages should be using 8 columns now rather than 7

On test_final_confirmation.json, the submit button is showing inline:

I'll fix this

🎉 👏


test

!cherry-pick v1.0

!verified

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0

!cherry-pick v1.0


tf.experimental.numpy.floor_divide is inconsistent with numpy version when divide by zero

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Y
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.7.0
Python version: 3.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
print(np.floor_divide(0,0)) # Outputs 0
print(tf.experimental.numpy.floor_divide(0,0 )) # InvalidArgumentError: Integer division by zero [Op:FloorDiv]

Describe the current behavior
tf.experimental.numpy.floor_divide  is TF's version of numpy.floor_div, and users would expect them to have the same behavior. In the special case of divide by zero, numpy.floor_div would throw RuntimeWarning but still give 0 as output, but tf.experimental.numpy.floor_divide would throw an error.
Describe the expected behavior
Expect  tf.experimental.numpy.floor_divide  to output 0, consistent with numpy.floor_divide

Hi @chunduriv ! Could you please look at this issue? It is replicating in 2.7, 2.8 and nightly(2.9.0dev).

I am not able to reproduce the same if i run as below
import tensorflow as tf
print(tf.__version__)
import numpy as np
print(tf.experimental.numpy.floor_divide(0,0 )) # InvalidArgumentError: Integer division by zero [Op:FloorDiv]

can you please check

Hi @rthadur , if I run the code in your comment, I can reproduce the issue (it throws InvalidArgumentError). Could you please provide which version of TF are you using, and what is the output you get?

@ArrowIntoTheSky,
This is an intended behavior and the same can also be seen in all cases mentioned below
Using math module
import math
math.floor(0/0)

output:
---------------------------------------------------------------------------
ZeroDivisionError                         Traceback (most recent call last)
[<ipython-input-1-054651c01b6b>](https://localhost:8080/#) in <module>()
      1 import math
      2
----> 3 math.floor(0/0)

ZeroDivisionError: division by zero

Using Python
print('Floor value for 0/0:',0//0)
Output:
---------------------------------------------------------------------------
ZeroDivisionError                         Traceback (most recent call last)
[<ipython-input-4-9fb0c9205c59>](https://localhost:8080/#) in <module>()
----> 1 print('Floor value for 0/0:',0//0)

ZeroDivisionError: integer division or modulo by zero

Using tf.math.floordiv
x=0
y=0
tf.math.floordiv( x, y, name=None)

Output:
---------------------------------------------------------------------------
InvalidArgumentError                      Traceback (most recent call last)
<ipython-input-12-e18cb5fc9e77> in <module>()
      3 y=0
      4 tf.math.floordiv(
----> 5     x, y, name=None
      6 )

1 frames
/usr/local/lib/python3.7/dist-packages/tensorflow/python/framework/ops.py in raise_from_not_ok_status(e, name)
   7184 def raise_from_not_ok_status(e, name):
   7185   e.message += (" name: " + name if name is not None else "")
-> 7186   raise core._status_to_exception(e) from None  # pylint: disable=protected-access
   7187
   7188

InvalidArgumentError: Integer division by zero [Op:FloorDiv]


[scss] Hover tooltip should show media queries

Currently, the SCSS hover tooltip does not show media queries. For example:

In a long CSS file, I rely on the tooltip to understand which selector I am looking at. Showing the media query in the tooltip would be very helpful in cases where the media query was declared several lines before. This will avoid having to scroll up to understand if there are any applicable media queries.

@aeschli  I would like to work on this

@hb20007, please confirm whether your feature works on the Atom editor because it relies on https://github.com/atom/language-sass/blob/master/grammars/scss.cson.

@balaji-sivasakthi I am not familiar with Atom. I tried to download it and I don't see any hover tooltip at all. I also tried searching for any CSS or PostCSS packages but there were no results.
Also, please note that there is at least one other issue related to the SCSS tooltip: https://github.com/microsoft/vscode/issues/72608

@hb20007 It would be a better option to wrap up with a @media  signature when hovering over a specific selector, thus it will ensure that the CSS selector is in the media body.

Also, please note that there is at least one other issue related to the SCSS tooltip: https://github.com/microsoft/vscode/issues/72608

Thanks for sharing, I hope it will help a lot.

@hb20007 Is this ok?

@balaji-sivasakthi, how will it look in the following scenarios?

If the media query is nested between other selectors? For example,  @media .class
If the media query has minimum width and height? (I believe that those need to be shown on the tooltip, including "only screen")

@media only screen {
    .foo {
        &-bar {

        }
    }
}

@balaji-sivasakthi, it looks great, but what about if the media query is nested between .foo and &-bar? I hope that in that case it will also be shown correctly on the tooltip.

@hb20007 there are some problems with that case, I couldn't place the media query label in-between the two selectors. Actually I just appended the media declaration, before the markdown string once I find @media. Thus it returns the top of the tooltip.

but what about if the media query is nested between .foo and &-bar? I hope that in that case it will also be shown correctly on the tooltip.

-@balaji-sivasakthi Ah okay, so it will be shown on top instead of in the same order. It looks fine to me, as the important thing is to know that the media query is applicable to the selector which you are editing, and not where exactly it is in the hierarchy. Even like this, it would be great to have this feature in VS Code.

It's worth noting that the sticky scroll feature (editor.stickyScroll.enabled) already pins media queries to the top along with class names, so this change will align the tooltip behavior with the existing sticky scroll behavior.


Support PowerBI Service Connection through Service Principal

@maikvandergaag PowerBI Service Connection is currently below parameters for ServicePrincipal Authentication
TenantID
ClientID
Client Secret
Is it possible to support "Certificate" instead of "Client Secret"?

Yes I think so will add it to the feature requests

Thank you, looking forward for this feature

Added the new option to the service connection in a beta version of the extension. If you share your organization name I'm able to share the beta version with you.

we will not be able to use beta version in our organization. But can sure test it in our sandbox org

Thanks for sharing your sandbox environment, you can test the extension by installing it via this link: https://marketplace.visualstudio.com/items?itemName=Development-vanderGaag.maikvandergaag-power-bi-actionsDev

@maikvandergaag  I am getting  below error
 Done processing Power BI Actions
2021-05-05T13:31:17.4233720Z ##[debug]Caught exception from task script.
2021-05-05T13:31:17.4303571Z ##[debug]Error record:
2021-05-05T13:31:17.5981355Z ##[debug]New-PowerBIReport : Operation returned an invalid status code 'BadRequest'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-05-05T13:31:17.6088146Z ##[debug]    + CategoryInfo          : WriteError: (Microsoft.Power...ewPowerBIReport:NewPowerBIReport) [New-PowerBIReport], Ht    tpOperationException
2021-05-05T13:31:17.6124724Z ##[debug]    + FullyQualifiedErrorId : Operation returned an invalid status code 'BadRequest',Microsoft.PowerBI.Commands.Report    s.NewPowerBIReport

Hi! The ID of dataset or workspace changed someway? Because i had trouble with this same return some time, and i could fix that verifiyng the DatasetId and WorkspaceId parameter on the PowerBI Service.

@maikvandergaag I am getting below error
This is happening when a new PowerBI report is published to the workspace through the PowerBI Actions task.
If i publish a new version of already existing PowerBI file in the workspace, the task is successful.
Any idea how to fix this issue?
 Done processing Power BI Actions
2021-05-05T13:31:17.4233720Z ##[debug]Caught exception from task script.
2021-05-05T13:31:17.4303571Z ##[debug]Error record:
2021-05-05T13:31:17.5981355Z ##[debug]New-PowerBIReport : Operation returned an invalid status code 'BadRequest'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-05-05T13:31:17.6088146Z ##[debug]    + CategoryInfo          : WriteError: (Microsoft.Power...ewPowerBIReport:NewPowerBIReport) [New-PowerBIReport], Ht    tpOperationException
2021-05-05T13:31:17.6124724Z ##[debug]    + FullyQualifiedErrorId : Operation returned an invalid status code 'BadRequest',Microsoft.PowerBI.Commands.Report    s.NewPowerBIReport

Hi! The ID of dataset or workspace changed someway? Because i had trouble with this same return some time, and i could fix that verifiyng the DatasetId and WorkspaceId parameter on the PowerBI Service.

is supported in the newest version. If there are problems please create a new issue and attach the full logs.


Have one error on a simple metronome

Hi,
What I'm I doing wrong?
Thanks in advance.
import Foundation
import AudioKit
var startMetronome: Bool = false

var generator: AKOperationGenerator?

var currentFrequency: Int = Int(120) {
    didSet {
        metronomeRateLabel.text = "\(currentFrequency)"
        metronomeRateSlider.value = Float(Int (currentFrequency))
    }
}
@IBOutlet weak var onOffButton: UIButton!
@IBOutlet weak var decreaseMetronomeRate: UIButton!
@IBOutlet weak var increaseMetronomeRate: UIButton!
@IBOutlet weak var metronomeRateLabel: UILabel!
@IBOutlet weak var metronomeRateSlider: UISlider!

override func viewWillAppear(_ animated: Bool) {
    super.viewWillAppear(animated)

    webView.isHidden = true
    webViewOpen = 0
    pickerBackground.layer.cornerRadius = pickerBackground.frame.width / 2.0
    pickerBackground.clipsToBounds = true
    let thumb = UIImage(named: "glassballThumb.png")
    metronomeRateSlider.setThumbImage(thumb, for: .normal)
    metronomeRateSlider.setThumbImage(thumb, for: .highlighted)
    self.onOffButton.setBackgroundImage(UIImage(named: "AlarmGreen.png"), for: .normal)
    self.onOffButton.setTitle("Play", for: [])

    generatorSettings()
}
func generatorSettings ()  {
    var currentFrequency = 1.0
    let beep = AKOperation.sineWave(frequency: 480)

//  HERE I get a "missing argument label" Error.
let trig = AKOperation.metronome(AKOperation.parameters(0))
    let beeps = beep.triggeredWithEnvelope(
        trig,
        attack: 0.01, hold: 0, release: 0.05)
    let generator = AKOperationGenerator(operation: beeps)
    AKOperationGenerator(operation: beeps)
    generator!.parameters[0] = Double(currentFrequency)
    AudioKit.output = generator
    AudioKit.start()
}
@IBAction func metronomeRateSliderChanged(_ sender: UISlider) {
        let currentValue = sender.value
        metronomeRateSlider.minimumValue = 40
        metronomeRateSlider.maximumValue = 240
        currentFrequency = Int(currentValue.value())
        generator!.parameters[0] = Double(currentFrequency)
}
@IBAction func increaseMetroFrequency(_ sender: UIButton) {
    currentFrequency += 1
}
@IBAction func decreaseMetroFrequency(_ sender: UIButton) {
    currentFrequency -= 1
}
@IBAction func startStopMetronome(_ sender: UIButton) {
    if startMetronome == false {
        self.onOffButton.setTitle("Pause", for: [])
        startMetronome = true
        generator!.restart()
        UIView.animate(withDuration: 1,
                       animations: {
self.onOffButton.setBackgroundImage(UIImage(named: "AlarmRed.png"), for: .normal)
        }, completion: nil)
    } else {
        self.onOffButton.setTitle("Play", for: [])
        startMetronome = false
        generator!.stop()
        UIView.animate(withDuration: 1,
                       animations: {
self.onOffButton.setBackgroundImage(UIImage(named: "AlarmGreen.png"), for: .normal)
        }, completion: nil)
    }
}

I don't know, try making the generator an instance variable on the class instead of a locally defined variable.  What exactly is happening when you try to run this.  That would be the first thing I'd need to know.  In any event, this is much more of a discussion group thing than an "issue" since its not a bug in AudioKit.  Try posting more info here: https://groups.google.com/forum/#!forum/audiokit

I know you’re busy, but although it’s no longer crashing, we are not getting audio out.  Can you glance at this real quick and give me a clue?
Thanks!
Dorian

On Apr 28, 2017, at 4:53 PM, Aurelius Prochazka<EMAIL_ADDRESS>wrote:
Closed #869 https://github.com/audiokit/AudioKit/issues/869.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/audiokit/AudioKit/issues/869#event-1062957322, or mute the thread https://github.com/notifications/unsubscribe-auth/AFc2kPaUHRyZOHQid146fowHZazBP1Lmks5r0nvlgaJpZM4NMCvr.


Integrate the fix for cover

Based on the work done here: https://github.com/jdeneef/ha_gpiod
With fixes based on the changes we made to align with this codebase.

Investigated it further and went down the rabbit hole of cached_property. Any day you learn something new.
So the def is_on(self) is needed in cover as I wrote above. CoverEntity which is the base of GPIODCover doesnt have the is_on property and this is really interfere with the Cover code.
The only issue was missing @cached_property on the is_on so it returned function pointer instead of the value which made it think it is on. I fixed it with my last commit.
@jdeneef FYI. You have the same bug.
As far as I can tell the RP5 code is ready. Let me know what's next.


[WFCORE-5064] Incorrect use of KeyManagerFactory.getDefaultAlgorithm instead of TrustManagerFactory

Issue: https://issues.redhat.com/browse/WFCORE-5064
Just changing to use the correct default trust-manager algorithm defined at JDK level (right now it's using the KeyManagerFactory default, the default value SunX509 also exists for TrustManagerFactory and it's valid). I'm not adding any tests because the final https availability for the realm is tested for example in HTTPSManagementInterfaceTestCase. We can add a test similar to the steps I added to reproduce it in the JIRA if you really think it is needed.

@rmartinc thanks


how to process batch

I hope there are two results，exp： "hello" ，"你好”，but one result ,     I do not know how to process batch .

the preprocess only encode the first element is input text
https://github.com/triton-inference-server/tensorrtllm_backend/blob/release/0.5.0/all_models/inflight_batcher_llm/preprocessing/1/model.py
so u need to modify the serving code

the preprocess only encode the first element is input text preprocess.py
so u need to modify the serving code

How to modify it? Can you give me a demo? Thank you very much

the preprocess only encode the first element in input text preprocess.py
so u need to modify the serving code

Hello, I tried to make changes to the file you mentioned, but found that the changes weren't correct. Could you provide me with some editing tips? I would greatly appreciate it.

the preprocess only encode the first element in input text preprocess.py
so u need to modify the serving code

Hello, I tried to make changes to the file you mentioned, but found that the changes weren't correct. Could you provide me with some editing tips? I would greatly appreciate it.

Have you solved this question？


Right click on items is often cut off

The logic deciding whether right-click context menus should appear above or below the mouse goes above too often, causing some context menus to be cut off underneath other parts of the character sheet.

This is caused by me doing development on a screen smaller than Foundry supports - no need to change or fix


Ignore whitespace in diffs automatically

How about adding ?w=1 to any diff URLs automatically as optional? Personally speaking it's pretty useful, as I hardly ever care about any changes only in whitespace.

Thanks for pointing out such an useful trick :clap: , I'm sure it will help a lot of people.
In order not to confuse people who has got used to the current diff content, maybe we can add a button to enable this magic like this:

if you got a getter idea, glad to change.

A diff which may confuse people with this trick
https://github.com/angular/angular.js/pull/10539/files?w=1

Well done! 👍 Blazing fast!
Yes, indeed. In specific cases it would be very confusing.
I just came up with an alternative approach worth considering.

A checkbox in option page setting up whether ?w=1 will be added to any diff links automatically. The checkbox is unchecked as default, as users should be clear about the function before it being enabled.
Turn on the function manually. (In my opinion,) it would be without any problems in most cases.
With this trick, very rarely and unfortunately, the situation that no changes couldn't be shown is possible. And there is not a hint, which causes confusion. Okay. How about appending a hint into the page, leading user to the normal diff page?
Even more advanced (and radically), user could be redirected to the page without ?w=1 automatically, then we can show a  hint that why whitespace hiding is disabled.
However, automatical redirecting is VERY RISKY. Please avoid of using it as far as possible.

May be a bit opinionated... or just all my fantasy :D
Thx for your patience!

Is there any consideration for this still? Having an option to default PR's to not showing whitespace diffs would be extremely useful, especially for those of us writing clojure and aligning maps values, as an example. We get diffs that are often 50% or more just whitespace and have been having to manually append the ?w=1 to our PR URLS.

Prepare to add this but does not have time, PR is welcomed.

Finally this feature comes out. Will toggle between Show Spaces and Ignore Spaces like

Seems it's not applied to commit details page? I didn't see a "Ignore Spaces" button there.

release v0.16.3 to fix this

I am not able to see this feature

Is this ever going to be available in Pull Requests?

@ArtS @amit133 fixed in v0.16.5

Is it possible to see that button in pull requests too?

The w=1 trick is nice for viewing diffs, unfortunately you can't add comments for the Pull Request which is where this would be most useful.
Really annoying to not be able to see your actual change in a file that accidentally (or intentionally) got formatted as part of a commit, since changing the whitespace doesn't matter in most languages.

Are team would get alot of use from the menu/button option for selecting "no spaces" in diff when doing PRs.  One common use-case for us is Jenkins often changes spaces/tabs to files automatically... which then leads to lots of file diff segments that are not "real" diffs.  This button suggestion above would be great in the PR Files Changed tab/section.

Any time estimate for when this will finally make it?
Hopefully ignoring spaces will not ignore leading white spaces in python?

Better to turn 'Hide Space' off in python code

@camsong : we are moving a rather old project to using autopep8 and many spaces are removed (old style was with spaces after and before parentheses, around "=" etc...) and it is quite painful to see "real changes" if any, so hiding spaces is nice, but of course leading spaces are a problem...

@phicharp It's hard to support that. Right now, "hide space" is a feature supported by github, can not be modified.

OK, I understand this is not easy to implement, but AFAIS it is not exposed in the web interface, is it? I manage by adding "by hand" ?w=1 to the URL but this is not really nice

Just wanted to leave another vote to add a button to PR pages to do this.  I learned of the trick using w=1, but wish there was a way to make that the default.  I agree there are times when it should be flipped off, so having the button at the top of the page would be ideal.
Any chance of getting this promoted to a user pref setting that is applied automatically as the default state, then having the button to flip from there?
Thanks

@ericarnold-granular  Will consider about this

Agree, this should be default. Or at least a toggle option. Please make it happen 👍

I love the checkbox that's been added for Hide Whitespace Changes. Can we add an option to make it the default parameter?

@nadim I search and I didn't find the checkbox on a page with code changes, I have to add w=1 by hand ...
Where can I find it please ?

@nadim oops, I haven't seen that the report was for a Chrome extension :-Z
I have installed it now 👍
Thx !

What chrome extension?
I'm pretty sure this is default github behaviour. No extension required.

On this kind of page, there is no button by default :
https://github.com/nicolas-albert/c8o_yaml_projects/commit/bb851e57ae0a242b46bedb5bb25cb95ba3c173db?w=1
I have installed Octo Mate to have the Ignore / Show Spaces button.

@nadim do you know if that checkbox selection can be persisted? I find myself selecting it and then the page is reloaded, the selection is gone.

+1 for a persistent toggle - thank you!

Is it supported to persist the setting across PRs?

+1 for persistency

+1 for persistent

+1 for persistence.  We where used to this in bitbucket and surprised github does not have this.


I don't know how to switch from insert mode back to normal mode.

I use ; after opening the terminal, I press the i key to enter the insert mode, but I want to return to the normal mode, press the ESC key, and cannot switch back, what should I do?

You can use ctrl + \ ctrl + n to go to normal mode. Of course you can add a easier keymap

You can use ctrl + \ ctrl + n to go to normal mode. Of course you can add a easier keymap

Hi s1n7ax,I have tried using ctrl + \ and ctrl + n, but still cannot change the insert mode to normal mode.

You can use ctrl + \ ctrl + n to go to normal mode. Of course you can add a easier keymap
I look in the help documentation of neovim, find a statement, add it to my .vimrc file, and then I can switch between different modes normally, thank you for your help.


Create support for Danish language

I propose to add support for danish language bu adding a file in i18n\da.yaml
albumCount:
  one: 1 album
  other: "{{ . }} albummer"
albums: albummer
in: i
home: Hjem
pageNotFound: Siden blev ikke fundet
photoCount:
  one: 1 billede
  other: "{{ . }} billeder"
toHomepage: Til forsiden

Nice, thank you!

Since the menu has changed from displaying only albums to a real menu, I renamed it from "Albums" to "Menu" in the translation. Is "Menu" the right term in danish for the menu icon?

Yes Menu would be the correct Danish translation :)


Using prefix for link on log page

resolve this issue #24

@lilian-benoit
I released new version.

https://github.com/yoshinorin/gitbucket-application-logs-plugin/releases/tag/v3.1.0

Thank you very much :)


[BUG] Close index leads to temporary red cluster until shard has started

Describe the bug
As of today, when an index is closed, it makes the cluster red temporarily until the shard has started. I am able to see this issue in both conventional document replication cluster as well as remote store enabled clusters.
Logs on a remote store enabled cluster
opensearch-master1  | [2024-09-20T08:55:03,100][INFO ][o.o.p.PluginsService     ] [opensearch-master1] PluginService:onIndexModule index:[index1/h71N_-WHQcWNEjqbFctFJQ]
opensearch-master1  | [2024-09-20T08:55:03,138][INFO ][o.o.c.m.MetadataCreateIndexService] [opensearch-master1] [index1] creating index, cause [api], templates [], shards [1]/[0]
opensearch-master1  | [2024-09-20T08:55:03,141][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T08:55:03,148][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-node1    | [2024-09-20T08:55:03,219][INFO ][o.o.p.PluginsService     ] [opensearch-node1] PluginService:onIndexModule index:[index1/h71N_-WHQcWNEjqbFctFJQ]
opensearch-node1    | [2024-09-20T08:55:03,357][INFO ][o.o.i.t.RemoteFsTranslog ] [opensearch-node1] [index1][0] Downloaded data from remote translog till maxSeqNo = -1
opensearch-node1    | [2024-09-20T08:55:03,381][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=RECOVERING engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-node1    | [2024-09-20T08:55:03,381][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=RECOVERING engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-node1    | [2024-09-20T08:55:03,382][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=RECOVERING engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-node1    | [2024-09-20T08:55:03,382][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=RECOVERING engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-master1  | [2024-09-20T08:55:03,385][INFO ][o.o.c.r.a.AllocationService] [opensearch-master1] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[index1][0]]]).
opensearch-master1  | [2024-09-20T08:55:03,388][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-node1    | [2024-09-20T08:55:03,457][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=STARTED engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-node1    | [2024-09-20T08:55:03,457][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Skipped syncing segments with primaryMode=false indexShardState=STARTED engineType=InternalEngine recoverySourceType=EMPTY_STORE primary=true
opensearch-node1    | [2024-09-20T08:55:03,458][INFO ][o.o.i.s.RemoteStoreRefreshListener] [opensearch-node1] [index1][0] Scheduled retry with didRefresh=true
opensearch-master1  | [2024-09-20T08:55:03,482][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T08:55:08,198][INFO ][o.o.p.PluginsService     ] [opensearch-master1] PluginService:onIndexModule index:[index1/h71N_-WHQcWNEjqbFctFJQ]
opensearch-master1  | [2024-09-20T08:55:08,229][INFO ][o.o.c.m.MetadataMappingService] [opensearch-master1] [index1/h71N_-WHQcWNEjqbFctFJQ] create_mapping
opensearch-master1  | [2024-09-20T08:55:08,230][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-master1  | [2024-09-20T08:55:22,939][INFO ][o.o.c.m.MetadataIndexStateService] [opensearch-master1] closing indices [index1/h71N_-WHQcWNEjqbFctFJQ]
opensearch-master1  | [2024-09-20T08:55:22,940][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-master1  | [2024-09-20T08:55:23,006][INFO ][o.o.c.m.MetadataIndexStateService] [opensearch-master1] completed closing of indices [index1]
opensearch-master1  | [2024-09-20T08:55:23,007][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T08:55:23,010][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-master1  | [2024-09-20T08:55:23,073][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T08:55:23,075][INFO ][o.o.g.G.RemotePersistedState] [opensearch-master1] codec version is 4
opensearch-node1    | [2024-09-20T08:55:23,140][INFO ][o.o.p.PluginsService     ] [opensearch-node1] PluginService:onIndexModule index:[index1/h71N_-WHQcWNEjqbFctFJQ]
opensearch-node1    | [2024-09-20T08:55:23,183][INFO ][o.o.i.s.IndexShard       ] [opensearch-node1] [index1][0] Downloaded translog and checkpoint files from=8 to=10
opensearch-node1    | [2024-09-20T08:55:23,207][INFO ][o.o.i.t.RemoteFsTranslog ] [opensearch-node1] [index1][0] Downloaded translog and checkpoint files from=8 to=10
opensearch-node1    | [2024-09-20T08:55:23,209][INFO ][o.o.i.t.RemoteFsTranslog ] [opensearch-node1] [index1][0] Downloaded data from remote translog till maxSeqNo = -1
opensearch-master1  | [2024-09-20T08:55:23,231][INFO ][o.o.c.r.a.AllocationService] [opensearch-master1] Cluster health status changed from [RED] to [GREEN] (reason: [shards started [[index1][0]]]).

Logs on doc rep clusters
opensearch-master1  | [2024-09-20T09:00:23,777][INFO ][o.o.p.PluginsService     ] [opensearch-master1] PluginService:onIndexModule index:[index1/G9Qow6fDROaCVD65DX-n0w]
opensearch-master1  | [2024-09-20T09:00:23,821][INFO ][o.o.c.m.MetadataCreateIndexService] [opensearch-master1] [index1] creating index, cause [api], templates [], shards [1]/[0]
opensearch-master1  | [2024-09-20T09:00:23,825][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-node1    | [2024-09-20T09:00:23,882][INFO ][o.o.p.PluginsService     ] [opensearch-node1] PluginService:onIndexModule index:[index1/G9Qow6fDROaCVD65DX-n0w]
opensearch-master1  | [2024-09-20T09:00:24,033][INFO ][o.o.c.r.a.AllocationService] [opensearch-master1] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[index1][0]]]).
opensearch-master1  | [2024-09-20T09:00:24,096][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T09:00:26,347][INFO ][o.o.p.PluginsService     ] [opensearch-master1] PluginService:onIndexModule index:[index1/G9Qow6fDROaCVD65DX-n0w]
opensearch-master1  | [2024-09-20T09:00:26,378][INFO ][o.o.c.m.MetadataMappingService] [opensearch-master1] [index1/G9Qow6fDROaCVD65DX-n0w] create_mapping
opensearch-master1  | [2024-09-20T09:00:42,889][INFO ][o.o.c.m.MetadataIndexStateService] [opensearch-master1] closing indices [index1/G9Qow6fDROaCVD65DX-n0w]
opensearch-master1  | [2024-09-20T09:00:42,949][INFO ][o.o.c.m.MetadataIndexStateService] [opensearch-master1] completed closing of indices [index1]
opensearch-master1  | [2024-09-20T09:00:42,949][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-master1  | [2024-09-20T09:00:43,008][WARN ][o.o.c.r.a.AllocationService] [opensearch-master1] Falling back to single shard assignment since batch mode disable or multiple custom allocators set
opensearch-node1    | [2024-09-20T09:00:43,061][INFO ][o.o.p.PluginsService     ] [opensearch-node1] PluginService:onIndexModule index:[index1/G9Qow6fDROaCVD65DX-n0w]
opensearch-master1  | [2024-09-20T09:00:43,097][INFO ][o.o.c.r.a.AllocationService] [opensearch-master1] Cluster health status changed from [RED] to [GREEN] (reason: [shards started [[index1][0]]]).

This problem may be aggravated in remote store enabled cluster due to existing behaviour where the translog is downloaded from remote store. This, however, is being fixed now.
Related component
Cluster Manager
To Reproduce

Create an index
Ingest some docs
Close the index

Expected behavior
I am not very sure if the cluster should really turn red here or not. This gives a false sense of underlying issue that may be causing red cluster. IMHO the cluster should remain green during the close index is happening.
Additional Details
NA

opensearch-master1  | [2024-09-20T09:00:43,097][INFO ][o.o.c.r.a.AllocationService] [opensearch-master1] Cluster health status changed from [RED] to [GREEN] (reason: [shards started [[index1][0]]]).

Curious why the shard was started after closed index. May be some race in shard allocation.

[Triage - attendees 1 2 3]
Thanks @ashking94 for filing the issue.
Do we have the logs corresponding to the health status change from GREEN/YELLOW to RED to help us understand the duration of RED status ?  Is it possible that the close & re-open operation was performed by two consecutive reroute calls.

Hi @rajiv-kv, I have already shared the logs in the issue description. Let me know what else do you need.

[Catch All Triage - 1, 2, 3, 4]


.Class Location

Could you help me with finding the location of where you change what the bot is "playing" I tried to look for the .class file that had the information but failed terribly.

Given that this bot is written in Java, to modify things like that, you'll need to download the source code and all the dependencies, change things, and recompile it.
The actual lines that changes this is https://github.com/jagrosh/JDA-Utilities/blob/master/src/main/java/me/jagrosh/jdautilities/commandclient/impl/CommandClientImpl.java#L145-L148, although you'd actually just want to add a setgame line to the end of here: https://github.com/jagrosh/MusicBot/blob/master/src/main/java/me/jagrosh/jmusicbot/JMusicBot.java#L57.
Alternatively, you can wait for the next release which will have a setgame command for the bot owner.

;P ty for adding it and letting me know where the location was.


[SPARK-23626][CORE] DAGScheduler blocked due to JobSubmitted event

What changes were proposed in this pull request?
DAGScheduler becomes a bottleneck in cluster when multiple JobSubmitted events has to be processed as DAGSchedulerEventProcessLoop is single threaded and it will block other tasks in queue like TaskCompletion.
The JobSubmitted event is time consuming depending on the nature of the job (Example: calculating parent stage dependencies, shuffle dependencies, partitions) and thus it blocks all the events to be processed.
Similarly in my cluster some jobs partition calculation is time consuming (Similar to stack at SPARK-2647) hence it slows down the spark DAGSchedulerEventProcessLoop which results in user jobs to slowdown, even if its tasks are finished within seconds, as TaskCompletion Events are processed at a slower rate due to blockage.
Move the ResultStage creation to call site thread, which will avoid blocking of DAGScheduler thread for other events
Refer: http://apache-spark-developers-list.1001551.n3.nabble.com/Spark-Scheduler-Spark-DAGScheduler-scheduling-performance-hindered-on-JobSubmitted-Event-td23562.html
How was this patch tested?

Added UT
Manual test to verify blockage before and after applying patch.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@squito @srowen @shivaram @markhamstra @HyukjinKwon
After getting comments from https://github.com/apache/spark/pull/20770 have checked for a narrower fix. Please review

Can one of the admins verify this patch?

Thanks @srowen  I did some testing and these seems to solve the problem but i was skeptic of the change so kept it configurable so that user(admin) can change back if this introduces unwanted behavior. I did not intend to make this configuration public. DAGScheduler is still a grey area for me, would like to know any feedback for this change. If it checks all the boxes, i am too +1 for not making this configurable.

@squito thanks for the feedback and pointers.

Will remove the configuration, even @srowen had similar opinion about having new configuration
Will check for synchronized _partitions handling.

@squito i have handled the review comments and updated the PR. Please review.
I have one question about org.apache.spark.rdd.RDD#partitions where the internal data-structure is  returned, should this be changed to return a copy instead.?

@squito @srowen had some rebase due to upstream conflicts, please review

Can one of the admins verify this patch?


python3Packages.pytest-rerunfailures: 8.0 -> 9.0

fixes #89508

bump pytest-rerunfailures to 9.0
drop Python 2.7 support for pytest-rerunfailures, because upstream did
drop Python ≤3.4 support for pytest-rerunfailures, because upstream did (in 8.0 already)
add myself (@das-g) as maintainer

Motivation for this change

#89508
upstream release 9.0

release notes

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)

(there are none)

[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

(meta.description is not capitalized. Should it really?)

Result of nixpkgs-review 1

3 packages built:
- python37Packages.pytest-rerunfailures
- python38Packages.pytest-rerunfailures
- xonsh

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/184

I cherry-picked these to https://github.com/NixOS/nixpkgs/pull/89723

https://github.com/NixOS/nixpkgs/pull/89723/commits/35a6dc658dd7d852073ca8cde5982fc7aee4e3ae https://github.com/NixOS/nixpkgs/pull/89723/commits/f0cf89278e8494c96e72c7756573bec9dc36549b

@jonringer
Is there any reason to not also merge this to master?

I wanted to reduce the number of merge conflicts @FRidh  had to encounter on staging

@jonringer I doubt this change will cause merge conflicts, so please consider merging it to master. If it later turns out that it does in fact cause merge conflicts, I'm willing to help resolve them.

35a6dc6 & f0cf892 have now been merged to master. Closing.


feat(chart): add extraVolumes + extraVolumeMounts

Pull Request

What? (description)
Adds extraVolumes / extraVolumeMounts parameters to the Helm chart.
Why? (reasoning)
Allows to, for example, mount a custom CA to /etc/ssl/certs/ca-certificates.crt, to avoid having to use insecure: true.
Fixes #65.
Acceptance
Please use the following checklist:

[ ] you linked an issue (if applicable)
[ ] you included tests (if applicable)
[ ] you linted your code (make lint)
[ ] you linted your code (make unit)

See make help for a description of the available targets.

Thank you!

@tamcore , @sergelogvinov , maybe you guys can help with some adivce?
Trying to inject custom CA with helm:
extraVolumes:
  - name: ca
    secret:
      secretName: secret

extraVolumeMounts:
  - mountPath: /etc/ssl/certs/ca-certificates.crt
    name: ca
    subPath: ca.crt

got 1 pod (controller) failed:
 Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/var/lib/kubelet/pods/9638f0cf-2012-4f64-a880-33 │
│ 5a785c7ad5/volume-subpaths/ca/proxmox-csi-plugin-controller/2" to rootfs at "/etc/ssl/certs/ca-certificates.crt": mount /var/lib/kubelet/pods/9638f0cf-2012-4f64-a880-335a785c7ad5/volume-subpaths/ca/proxmox-csi-plugin-controller/2:/etc/ssl/certs/ca-certificates.crt (via /proc/self/fd/6), flags: 0x5001: not a directory: unknown

without custom CA everything starts, but I'm getting the error while trying to allocate even with insecure: true:
capacity.go:551] CSI GetCapacity for {segment:0xc000312288 storageClassName:proxmox-data-xfs}: rpc error: code = Internal desc = Get "https://proxmox.example.com:443/api2/json/nodes/xxx/storage/data/status": tls: failed to verify certificate: x509: certificate signed by unknown authority

my config:
config:
  clusters:
    - url: https://proxmox.example.com:443/api2/json
      insecure: false
      token_id: "id"
      token_secret: "secret"
      region: main

storageClass:
  - name: proxmox-data-xfs
    storage: data
    reclaimPolicy: Delete
    fstype: xfs


Tadpoles do not grow into frogs

Spark link
n/a
Expected behavior
After the 24000 game ticks it takes to grow, tadpoles will turn into normal frogs.
Observed/Actual behavior
They don't grow no matter how much time has passed
Steps/models to reproduce
Start barebones test server with no plugins, set randomTickspeed to 1000 and wait. They won't grow.
Purpur version
[08:10:45 INFO]: Current: git-Purpur-1682 (MC: 1.19)*
Previous: git-Purpur-1631 (MC: 1.18.2)

You are 3 version(s) behind

Have not tested latest 2 builds, but I see no other mention of this issue in other Github issues or changelogs.
Agreements

[X] I am running the latest version of Purpur available from https://purpurmc.org/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
No response

Completely ignoring that you didn't follow instructions; Are you able to reproduce on one of our upstreams, either on a Paper or Pufferfish server?

Spark link n/a

spark link is not optional

Start barebones test server with no plugins, set randomTickspeed to 1000 and wait. They won't grow.

Random tick speed doesn't affect animal growth speed afaik

You are 3 version(s) behind

Just wanted to report what I had found, feel free to close it and do nothing if what I provided wasn't adequate.

Unable to reproduce. Tadpoles take 20 minutes (24000 ticks) to grow up. The random tick speed gamerule does not speed this up at all because this isn't a random tick feature.
Is slimeballs to speed it up if you want.


Improvement: Lack minimum system requirement

Documentation presented in the main repository (https://github.com/langgenius/dify) is only partially presented here in this repository.
For example:
Before installing Dify, make sure your machine meets the following minimum system requirements:
CPU >= 2 Core
RAM >= 4GB
Above is not present here in this repo.

Updated: https://docs.dify.ai/getting-started/install-self-hosted/docker-compose


[Mobile] auto focus after insert

My issue is about [Mobile]
same at example
i don't want auto focus after inserted(e.g. image), how can i prevent this behavior， thank you very much.

sam like me

Hi, can you explain in more detail with pictures?? how is that image inserted?? is it inserted using the controller or toolbar button??

My issue is about [Mobile]
same at example
i don't want auto focus after inserted(e.g. image), how can i prevent this behavior， thank you very much.

if you still facing this issue or any others, please tell us

@singerdmx Consider adding Github action that will close the issue if it hasn't been updated, changed or any reaction for a while

Not sure how to do that.
Here I added this https://github.com/singerdmx/flutter-quill/blob/master/.github/workflows/publish.yml to automatically publish package

If you have any other questions feel free to ask us on GitHub
We are working on improving the library in general to fit your needs and the others needs


Setting temporary claims for user from the adaptive script feature is not working for implicit grant

Describe the issue:
Updating the user claims temporary(user. claims[“<claim_uri>”]) from the adaptive script[1] is not working properly for the Implicit grant. For the Authorization Code grant, it is working as expected[2].
In the Implicit grant, the values are getting directly from the user stores and not assigning the dynamic runtime claim values[3].
[1]https://github.com/wso2/product-is/issues/9293
[2]https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/17410a57cce99b6a9899db3d84acfa7f45e13033/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/openidconnect/DefaultOIDCClaimsCallbackHandler.java#L142
[3]https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/17410a57cce99b6a9899db3d84acfa7f45e13033/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/openidconnect/DefaultOIDCClaimsCallbackHandler.java#L344
How to reproduce:

Create a service provider with OAuth/OpenID Connect Protocol.
Select the "JWT" as the Token Issuer.
Add some claims(http://wso2.org/claims/fullname,http://wso2.org/claims/nickname) as the requested claims of the Service provider and set them Mandatory.
Add the above claims to the user profile by selecting "supported by default" and set some values from the user profile.
Add the above claims to the OIDC scope if they are already not added.
Add "basic" as the first step authenticator and update the Adaptive script to set a claim value temporarily.

var onLoginRequest = function(context) {
    executeStep(1, {
        onSuccess: function (context) {

                    user.claims["http://wso2.org/claims/fullname"] = "test full name";
                    user.claims["http://wso2.org/claims/nickname"] = "test nick name";

        }
    });
};

Initiate the Implicit grant flow and add the correct scopes which include the above claims.

https://localhost:9443/oauth2/authorize?response_type=token&client_id=<client_id>&redirect_uri=<redirect_uri>&scope=openid+<scope>

Authenticate with the user and retrieve the access_token from the network trace location response header.

Location: https://localhost:5000#access_token=**eyJ4NXQiOiJOVGRtWmpNNFpEazNOalkwWXpjNU1tWm1PRGd3TVRFM01XWXdOREU1TVdSbFpEZzROemM0WkEiLCJraWQiOiJNell4TW1Ga09HWXdNV0kwWldObU5EY3hOR1l3WW1NNFpUQTNNV0kyTkRBelpHUXpOR00wWkdSbE5qSmtPREZrWkRSaU9URmtNV0ZoTXpVMlpHVmxOZ19SUzI1NiIsImFsZyI6IlJTMjU2In0.eyJzdWIiOiJhZG1pbiIsImF1dCI6IkFQUExJQ0FUSU9OX1VTRVIiLCJhdWQiOiI0MUN0TjQ1UHVDZ0V6MmpPWWxCMjJLaFROOHNhIiwibmJmIjoxNjYxOTQ2NTkwLCJhenAiOiI0MUN0TjQ1UHVDZ0V6MmpPWWxCMjJLaFROOHNhIiwic2NvcGUiOiJhZGRyZXNzIG9wZW5pZCBwcm9maWxlIiwiaXNzIjoiaHR0cHM6XC9cL2xvY2FsaG9zdDo5NDQzXC9vYXV0aDJcL3Rva2VuIiwibmFtZSI6ImFkbWluIGFkbWluIiwibmlja25hbWUiOiJmZGFmYXNkZmFzIiwiZXhwIjoxNjYxOTUwMTkwLCJpYXQiOjE2NjE5NDY1OTAsImp0aSI6Ijg0NmY5NWUyLTdjZjQtNGNiNC1iNzhkLWQ1NTI4NjEwNmRlMCJ9.BSjtAxDvIuOR7nGYVMygYxOUaI156WL-6qgcdE1yEDb07YQN_Qrsy205BYBAs6p8a3eJDtcSgosvUDyNRiJ_X7TAgau40xhfinMIIXjkXYcivvnWFAXbwEGK-CXhFzuzCAkzqkQeGGEg1pK_DdiIBPhixLKX4glqD8Kp6ot5it_QATcqIuwqcLjCHCRQenIm-3hBwjEMBHRrR9cJgfdk30mZl_O8E60uHeAjRrnMSeU9cY6gXTXiJlqTBKD80jprYZrnHbDNQ9EPK9lF7RQ_5V23e4GX82a_O04kuoZoHOJ8xNUx8tH9cE97pJh52GKvzHVTAD2TnovsJ-9R_KzzXA**&token_type=Bearer&expires_in=3599&session_state=9b4426b10cebb9f33ad6e170949c304949fc76f1728878f03d18048a4ac97f27.92Zgj62K0rJz8Ndx9TYIBQ

decode the token(jwt.io) and observe the original value for the claims. The claim values are not updated.  If you check the ID token via the Authorization Code grant, you can see the values are updated.

Expected behavior:
The values that are assigned from the adaptive script should be available as the Access Token claim values.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: 5.11.0

var onLoginRequest = function(context) {
executeStep(1, {
onSuccess: function (context) {
var user = context.steps[1].subject;
//user.claims.full_name = "test full name";
//user.claims.nick_name = "test nick name";
user.claims["http://wso2.org/claims/fullname"] = "test full name";
user.claims["http://wso2.org/claims/nickname"] = "test nick name";
}
});
};

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Unable to queue builds via API using YAML definitions

Agent version and platform
Version of your agent?
2.124.0
OS of the machine running the agent?
Linux
VSTS type and version
VisualStudio.com
If VisualStudio.com, what is your account name?
https://origin-energy.visualstudio.com
What's not working?
When I try to trigger a build using https://origin-energy.visualstudio.com/DefaultCollection/CloudServices/_apis/build/builds?api-version=2.0, I get the following response:
{     "ClassName": "Microsoft.TeamFoundation.Build.WebApi.BuildRequestValidationFailedException",     "Message": "Could not queue the build because there were validation errors or warnings.",     "Data": null,     "InnerException": null,     "HelpURL": null,     "StackTraceString": null,     "RemoteStackTraceString": null,     "RemoteStackIndex": 0,     "ExceptionMethod": null,     "HResult": -2146232832,     "Source": null,     "WatsonBuckets": null,     "m_logException": false,     "m_reportException": false,     "m_errorCode": 0,     "m_logLevel": "warning",     "m_eventId": 3000,     "ValidationResults": [         {             "result": "error",             "message": "An error occurred while loading the YAML build definition. An object ID must be 40 characters long and only have hex digits. Passed in object ID: ."         }     ] }
This only happens when queueing using the API. Manual triggers from the web UI and git triggers work fine.

@cameronattard did you queue the build against a branch, tag, or commit? My guess is you queued against a commit, but did not use the full 40 char sha (queue against short hash not impl yet)

Just managed to get it working by explicitly specifying sourceBranch: "/refs/heads/master". Previously I was omitting that field as the documentation states: "The branch to build. This is optional. If not specified, the default branch for the definition will be used."
Is there any way to specify the default branch in the YAML build definition?

Also, you might want to use a later api version ?? not sure if needed.  Anyways, I would recommend you try it in the browser and then use browser dev tools or fiddler to see what our app does (we use the public api)
closing since I think you figured it out


Fix command line argument

Coverage decreased (-0.8%) to 73.471% when pulling 0932d16e3e5769b18ea037a9163fdc3eb7de4aed on humitos:patch-2 into c54c9ad6c07a679c3897d3810ba3fad9bebc5356 on DenisCarriere:master.


ShapeId static methods not consistent in their use of caching

This isn't an issue per se (at least I don't think it is), but it has bitten us due to us accidentally relying on reference equality (== instead of equals):
ShapeId.from("foo.bar#Baz") == ShapeId.from("foo.bar#Baz") //true
ShapeId.from("foo.bar#Baz") == ShapeId.fromParts("foo.bar", "Baz") //false

The first line returns true because the cache kicks in and the instance is reused. However, in the latter, it appears that fromParts doesn't utilize the cache, and the comparison returns false.
Should this be fixed somehow, by having fromParts and friends also go through the cache?

No, sorry. We don’t guarantee reference equality for ShapeIds.


Cherrypick 2023 01 01

The Popup occlusion temp fix has been included. If no bugs crop up related to that, we should be good to start removing the manual occlusion checks.

Should make a note to give our headsets default channels. I can open an issue if you don't feel like doing it this PR

replace supply with binary to fix that yaml linter failure

Good catch. I caught all the changes related to default channels on the headsets that already exist, but I forgot about the custom headsets we have (despite just yesterday doing a PR related to that.)

Easy enough to fix here.


Cannot use Aeron:ipc as transport

Wanted to test pic (shared mem) on local machine on OS X

This seems not to work, wehre is the error ?
./Throughput -L 4096 -m 1000000 -p /Volumes/DevShm/aeron -c "aeron:ipc"
Subscribing to channel aeron:ipc on Stream ID 1001
Streaming 1000000 messages of payload length 4096 bytes to aeron:ipc on stream ID 1001
Subscription: aeron:ipc 42:1001
Publication: aeron:ipc 43:1001:1369783632
Available image correlationId=43 sessionId=1369783632 at position=0 from aeron:ipc
libc++abi.dylib: terminating
zsh: abort      ./Throughput -L 4096 -m 1000000 -p /Volumes/DevShm/aeron -c "aeron:ipc"

Have you started the media driver?

Yes
It works without the "-c aeron:ipc" option
This is how I start the c media driver

% cat md
#!/usr/bin/env bash
AERON_BUILD_DIR=..
export AERON_DIR="/Volumes/DevShm/aeron"
export AERON_TERM_BUFFER_SPARSE_FILE="0"
export AERON_SOCKET_SO_SNDBUF="9216"
export AERON_MTU_LENGTH="8k"
export AERON_THREADING_MODE="SHARED"
export AERON_SHARED_IDLE_STRATEGY="spin"
${AERON_BUILD_DIR}/binaries/aeronmd

Using udp it gives me this..

% ./Throughput -L 4096 -m 1000000 -p /Volumes/DevShm/aeron
Subscribing to channel aeron:udp?endpoint=localhost:20121 on Stream ID 1001
Streaming 1000000 messages of payload length 4096 bytes to aeron:udp?endpoint=localhost:20121 on stream ID 1001
Subscription: aeron:udp?endpoint=localhost:20121 5:1001 it
Publication: aeron:udp?endpoint=localhost:20121 6:1001:-388967803
Available image correlationId=7 sessionId=-388967803 at position=0 from <IP_ADDRESS>:49914
1.204e+05 msgs/sec, 4.933e+08 bytes/sec, totals 997958 messages 3898 MB payloads
Done streaming. Back pressure ratio 123.523

using ipc

% ./Throughput -L 4096 -m 1000000 -p /Volumes/DevShm/aeron -c "aeron:ipc?"
Subscribing to channel aeron:ipc? on Stream ID 1001
Streaming 1000000 messages of payload length 4096 bytes to aeron:ipc? on stream ID 1001
Subscription: aeron:ipc? 2:1001
Publication: aeron:ipc? 3:1001:-388967804
Available image correlationId=3 sessionId=-388967804 at position=0 from aeron:ipc
libc++abi.dylib: terminating
zsh: abort      ./Throughput -L 4096 -m 1000000 -p /Volumes/DevShm/aeron -c "aeron:ipc?"

What is in the distinct error log? You can find out by running error stat.

Nothing....
% ./ErrorStat
0 distinct errors observed.
For me this seems to be kind of a crash.
I tried to debug that down but according to lldb the build within /Debug/binaries seems to contain no debug info. If I try to build a simple hello world on my machine using my clang toolchain it puts out an additional filename.dSYM with the symbols. Here debugging works....

Update:
Aeron:ipc works up to a message size of 1376bytes
./Throughput -L 1376 -m 100000000 -p /Volumes/DevShm/aeron -c "aeron:ipc"
Subscribing to channel aeron:ipc on Stream ID 1001
Streaming 100000000 messages of payload length 1376 bytes to aeron:ipc on stream ID 1001
Subscription: aeron:ipc 2:1001
Publication: aeron:ipc 3:1001:-1550552481
Available image correlationId=3 sessionId=-1550552481 at position=0 from aeron:ipc
1.64e+07 msgs/sec, 2.257e+10 bytes/sec, totals 99980584 messages 131200 MB payloads
Done streaming. Back pressure ratio 0.360949

media driver is started like this:
+++++
#!/usr/bin/env bash
set +e
killall aeronmd
AERON_BUILD_DIR=..
export AERON_DIR="/Volumes/DevShm/aeron"
export AERON_TERM_BUFFER_SPARSE_FILE="0"
export AERON_SOCKET_SO_SNDBUF="9216"
export AERON_MTU_LENGTH="8k"
export AERON_THREADING_MODE="SHARED"
export AERON_SHARED_IDLE_STRATEGY="spin"
echo "Start media driver"
${AERON_BUILD_DIR}/binaries/aeronmd &
Seems to be a strange limit btw...

You will need to use AERON_IPC_MTU_LENGTH.

Thanks. ok I see.
Which itself is limited by MAX_UDP_PAYLOAD_LENGTH which seems so be somewhat strange to me.....


creator info in machine allocation response

Related to https://github.com/metal-stack/metal-api/pull/197#issuecomment-864785548

Codecov Report

Merging #64 (7877f01) into master (3743dd0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #64   +/-   ##
======================================
  Coverage    4.46%   4.46%
======================================
  Files          14      14
  Lines        1075    1075
======================================
  Hits           48      48
  Misses       1021    1021
  Partials        6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3743dd0...7877f01. Read the comment docs.


alluxio-fuse:latest Docker image does not exist

According to https://hub.docker.com/r/alluxio/alluxio-fuse/tags the newest tag is 2.0.0-SNAPSHOT but the "latest" tag is missing https://github.com/Alluxio/alluxio/blob/master/integration/kubernetes/alluxio-fuse.yaml.template#L28

Docker builds are now published regularly with the latest tag


Add new colors from Tailind v3

Hmm, actually it seems just rebranding of old gray colors 🤔

Yes,
warmGray -> stone
gray -> natural
etc. So probably this PR makes no sense...

Still a good addition to the alignment. Thanks!

Codecov Report

Merging #616 (eb6fc94) into main (16ad9be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   88.20%   88.20%
=======================================
  Files          57       57
  Lines        4860     4860
  Branches     1034     1034
=======================================
  Hits         4287     4287
  Misses        310      310
  Partials      263      263

Impacted Files
Coverage Δ

src/config/colors.ts
50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ad9be...eb6fc94. Read the comment docs.


How can we set default 'searchText' value for TableSearch

With textFilters() there is a defaultValue option that can be set, but I don't see a valid prop for the TableSearch toolkit.
I see that there is searchText being used but passing that in as a prop doesn't auto-fill the Search input field with that value.
Why am I doing this?
I have a table that I'm refreshing the data for every 15 seconds (or at the user's desired interval) and there's the possibility that data could change for certain cells and to avoid having the table jump back to page 1, with default sort order, default pageSize, etc, I store the state of all those options to maintain a consistent UX. So, using onSearch prop, I run the default onSearch func and then store the value from the Search component to state. I just can't seem to get a default input field value...
<SearchBar
  {...toolkitProps.searchProps}
  searchText={searchText}
  onSearch={(val) => this.updateSearch(val, toolkitProps)}
  delay={50}
/>

@slgriffiths I will enhance it ASAP, thank you :)

@slgriffiths . sorry for lately fixing: https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/09/30/version-bump.html
please upgrade to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>search.defaultSearch  will help you in this case. If it's not work, please reopen this issue and tag me, thank you

@AllenFang Awesome. Great news and thanks for putting in the fix so quick!

👍


Add an open-source license

Hi!
Long story short, I really like crayon so far, especially the fact that it does not require SDL to work and would like to contribute to it in the future (as well as use it in my own projects).
Since crayon has been so kindly put on GitHub, I assume there's a chance it is meant to be an opensource project. If it is so, could an opensource license be put in the repository?

Sorry for this late reply, I was stuck in my daily works for last few months. The development will be continued, and Apache-2.0 will be added as an open-source license asap.
BTW, i don't think crayon is stable enough to be used in any real-world development.

Thank you!
I surely plan to contribute to the project.
Yes, I do acknowledge the fact that crayon is not production-ready yet. The fun is in making it production-ready :D


Support BigInts for 64-bit numbers above 2 ** 53

Numbers >= 2 ** 53 aren't accurate integers in JS. This is why we have BigInts to handle values larger than this. But this library doesn't utilize them at all

I made a pull request for this (#115) a couple of years ago.

@mourner
Do you have a plan to support for BigInt(Numbers >= 2 ** 53) ?


refactor: add GenPodGroupName method to extract podGroupName in diffe…

…rent place

This change is

Coverage remained the same at 76.744% when pulling cb95e1629a47039c9ede83d96b904bc3cf17516d on zlcnju:master into d746bde980e7fbf480a8978cd90856d18b0240f1 on kubeflow:master.

Coverage remained the same at 76.744% when pulling cb95e1629a47039c9ede83d96b904bc3cf17516d on zlcnju:master into d746bde980e7fbf480a8978cd90856d18b0240f1 on kubeflow:master.

/assign @johnugeorge

@zlcnju Why is this needed now?

@zlcnju Why is this needed now?

in kube-batch, the podgroup work when the annotation podgroupname is set。 So, the two places will be equal always. Now, they are equal by the principle both equals tfjob name. This is implicit, extracting one method will make it clear that how the annotation used in podgroup.

/ok-to-test


Extended API Support

support REST APIs with path and query parameters
support multiple APIs with auth configuration
support local functions with
added examples and made them all use publicly accessible APIs (moving DataSQRL specific examples to separate repo)
fixes #19
fixes #16

Looks good, but it is based on main before the Google support, which extends the Message Schema saved to the Backend. Shouldn't the Google Vertex support PR have been merged first?

Yes, we'll rebase before the merge. Both of these PRs require that we update the examples. In this PR, all examples are using publicly available APIs. The DataSQRL examples are moved to datasqrl-examples and there is a separate PR for updating those. All of these need to be merged together.


Adding Profanity Checker

Aim

To make a program that can check for NSFW / Abusive words from audio.

Details

The profanity checker program will have a script that can take MIC or Audio file input and use NLP and APIs to process the audio.
It will give a text format output of what is present in the audio.
It will then check the presence of any abusive or NSFW words.
It will have an accuracy of more than 95% with tried and tested datasets to train on.
This will enable the user to integrate this script in their websites or even platforms like Youtube to make the platforms cleaner for the audience.

GO AHEAD @okaditya84


add workaround for StarCoder

This adds a workaround to avoid the stop word issues with StarCoder 2 (and possibly other models).
Very ugly workaround unfortunately, that touches a few different files. Not super confident about this, it will need some more testing.
Usage example:
python run_intermediate_expansion.py --base_model bigcode/starcoder2-15b --stop_token_workaround True

@davidbrandfonbrener, can you review this?


[Design] Sync with the full-node

The sync can be done keeping track of the latest block B that the service has seen. So, when the service restarts, it searches for that block and sync with all blocks after it. We still need to handle some special cases.
When initializing the sync, the first block can be either executed or voided.
(i) If B is executed, we just need to go from that block to the head of the best blockchain in the full node.
(ii) If B is voided, we need go to back until we reach the best blockchain again. Let's say it is block X. Then, we move forward from X to the head of the best blockchain. All transactions between B and X must be checked because they may have been voided.
After the blocks have been synced, we may need to go through all unverified transactions.
We may sync all voided blocks. I'm not sure if it should be optional. If we don't do it, users won't see their voided blocks in their wallets. If we want to do it, we can keep track of the head of all non-best blockchains, but it may grow over time.
If we decide that we must have all blocks and transactions, including the voided ones, we can really sync all blocks and transactions. But I'm not sure it is the best strategy for the wallet.
@obiyankenobi @jansegre @pedroferreira1 What do you think?

I think it's a good strategy for the blocks, but the most complex part are the transactions.
Do we already have some easy way to get all transactions "after" a given block? By "after", I mean that are not confirmed (directly or indirectly) by the block, not considering the timestamp.

Do we already have some easy way to get all transactions "after" a given block? By "after", I mean that are not confirmed (directly or indirectly) by the block, not considering the timestamp.

For blocks in the best blockchain, we do. We can use the first_block metadata to easily identify all transactions which were firstly verified by a given block. We basically run a BFS that stops adding to the queue when first_block != block.

It seems like a good strategy. There are other things I'd like to improve on the sync protocol. Should we make an RFC to discuss a new "sync v2" protocol? The wallet service would be the pilot test for the sync v2, and when we're happy with it we can start rolling it out for the networks P2P.

I think it's a good strategy, seems to work for what we want.

Should we sync voided blocks and transactions?

I think wallets should be able to show voided blocks, we can discuss UI later but if a user sees a block in his wallet and then it disappears, he should be able to see that this block was actually voided.


Added client code for connection

Added client code for connection.
Closed#1

@damn1kk You are awesome
Thanks a lot!!


kubeadm: recommend installing calico 3.8

This change is required since the 3.8 manifest moves to using
apps/v1 instead of extensions/v1beta1 for types like DaemonSet
and Deployment.
See PR 70672 of k/k.
/kind feature
/priority important-longterm
/sig cluster-lifecycle

@neolit123 Calico v3.8.0 isn't released yet, please hold off on merging this until it is :)

@caseydavenport what is the ETA on the release?
does this mean that the images that the manifest references are not out yet?

@neolit123 the images in the manifests exist, but are not stable.
The release itself has been pushed out a bit due to some issues found during QA. I can't give an exact ETA given we're still working through them.

Attached the "hold" label in case it gets merged by mistake.

/hold cancel
calico 3.8 is out:
https://github.com/projectcalico/cni-plugin/releases/tag/v3.8.0

/assign @tengqm

/lgtm
/approve


clash-meta: 1.18.8 -> 1.18.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/MetaCubeX/mihomo/releases.
meta.description for clash-meta is: Rule-based tunnel in Go
meta.homepage for clash-meta is: https://github.com/MetaCubeX/mihomo/tree/Alpha
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.18.9 with grep in /nix/store/88yv5hzn2l3zy4ywqhfqpy772r12niqa-clash-meta-1.18.9
found 1.18.9 in filename of file in /nix/store/88yv5hzn2l3zy4ywqhfqpy772r12niqa-clash-meta-1.18.9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

clash-meta
clash-verge-rev
mihomo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/88yv5hzn2l3zy4ywqhfqpy772r12niqa-clash-meta-1.18.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clash-meta https://github.com/r-ryantm/nixpkgs/archive/e5d385da5fc17637224515c0ee161b651abcee02.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e5d385da5fc17637224515c0ee161b651abcee02#clash-meta

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/88yv5hzn2l3zy4ywqhfqpy772r12niqa-clash-meta-1.18.9
ls -la /nix/store/88yv5hzn2l3zy4ywqhfqpy772r12niqa-clash-meta-1.18.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

clash-meta
clash-verge-rev
mihomo

Maintainer pings
cc @oluceps for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Close since this package is an alias for mihomo.


Add an after_connect callback in Ecto.Repo

The callback is run right after a new connection has been opened passing
in the pid of the connection.

Seems like some tests are failing, we also need a test that makes sure that after_connect is called.

The callback should probably run inside a connection and the pdict needs to be setup so that Repo functions uses the correct connection. See https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/sql.ex#L512-L513.

I've tried to add a test on the callback, but I failed. The fact that the repo has to be passed to the worker it's spawning, makes it tricky to setup a test. Maybe this is a smell, maybe this is just me... Any pointer would be appreciated to put a test on it.
After the irc discussion, and the various points made, I assume we're still trying to make a simple version of after_connect which only allows running driver specific functions inside the same process initiating the connection (which imply after_connect should returns quickly, at least faster than the pooling timeout for new connection).

Just adding my 0.02 EUR here:
Our usecase for this feature is that we want to get the Postgres backend OS pid and associate it with the Erlang pids of the a) Postgrex connection and b) Ecto worker, so that we can add that info to the Logger metadata and keep it around to make debugging issues easier.
(Being able to associate the log messages / information views from Postgres with what's going on in Elixir/Ecto helps obviously. Using the backend pid as the identifier makes that easy.)

@MSch, have you looked at master's https://github.com/elixir-lang/ecto/blob/master/lib/ecto/log_entry.ex? Do you think it should have more fields?

Folks, we are ready to look at this again as we have hopefully settled the adapter API. Ecto.Adapters.Connection and its implementations are a good place to look for this. We should no longer change the worker because they are pool specific.
@JonathanTron I am closing this because it is outdated. Let's continue the discussion in #599, thank you!


Fatal error when upgrading to 2.0.4

BC Break Report
When executing cache:clear after composer update there is PHP fatal error.
PHP Fatal error:  Declaration of Doctrine\ORM\MappingClassMetadataFactory::wakeupReflection(Doctrine\Common\Persistence\Mapping\ClassMetadata $class, Doctrine\Common\Persistence\Mapping\ReflectionService $reflService) must be compatible with Doctrine\Persistence\MappingAbstractClassMetadataFactory::wakeupReflection(Doctrine\Persistence\Mapping\ClassMetadata $class, Doctrine\Persistence\Mapping\ReflectionService $reflService) in /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php on line 797

PHP Stack trace:
1. {main}() /var/www/html/bin/console:0
2. Symfony\Bundle\FrameworkBundle\Console\Application->run() /var/www/html/bin/console:44
3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/html/vendor/symfony/console/Application.php:148
4. Symfony\Bundle\FrameworkBundle\Console\Application->registerCommands() /var/www/html/vendor/symfony/framework-bundle/Console/Application.php:65
5. App\Kernel->boot() /var/www/html/vendor/symfony/framework-bundle/Console/Application.php:159
6. App\Kernel->initializeContainer() /var/www/html/vendor/symfony/http-kernel/Kernel.php:136
7. Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() /var/www/html/vendor/symfony/http-kernel/Kernel.php:658
8. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->{closure:/var/www/html/var/cache/dev/ContainerEPFlGxJ/getCacheWarmerService.php:12-25}() /var/www/html/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:89
9. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->load() /var/www/html/var/cache/dev/ContainerEPFlGxJ/getCacheWarmerService.php:17
10. require() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:785
11. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->getValidator_BuilderService() /var/www/html/var/cache/dev/ContainerEPFlGxJ/getValidator_Mapping_CacheWarmerService.php:13
12. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->getDoctrine_Orm_DefaultEntityManagerService() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:3127
13. Doctrine\ORM\EntityManager::create() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:1111
14. Doctrine\ORM\EntityManager->__construct() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:873
15. spl_autoload_call() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:159
16. Symfony\Component\Debug\DebugClassLoader->loadClass() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:159

In ClassMetadataFactory.php line 797:
Compile Error: Declaration of Doctrine\ORM\Mapping\ClassMetadataFactory::wakeupReflection(Doctrine\Common\Persistence\Mapping\ClassMetadata $class, Doctrine\Common\Persistence\Mapping\ReflectionService $reflService) must be compatible with Doctrine\Persistence\Mapping\AbstractClassMetadataFactory::wakeupReflection(Doctrine\Persistence\Mapping\ClassMetadata $class, Doctrine\Persistence\Mapping\ReflectionService $reflService)

Q
A

BC Break
yes

Version
2.0.4

Package mongodb-odm is provided through doctrine/mongodb-odm-bundle (^4.0).
Adding fixed "doctrine/mongodb-odm": "2.0.3" to composer as a temporary fix does the trick.

@greg0ire could this be related to https://github.com/doctrine/mongodb-odm/pull/2150?

Uh yes, definitely, let me check

Doctrine\ORM\MappingClassMetadataFactory
Wait what?

Yea, I know. But mongodb-odm update triggers this. Not sure what is going on here but I'm happy to provide all the info you need.

@bizley are you using ODM and ORM at the same time?

Yes.

Can you check which version of Doctrine persistence you use? I fear it misses yet another autoload call

1.3.4.

I believe we need to revisit the compat layer and namespace move entirely

@alcaeus not so fast, I think I found a mistake here: https://github.com/doctrine/persistence/blob/1.3.x/lib/Doctrine/Persistence/Mapping/ReflectionService.php#L74

Yup, changing line 74 to
interface_exists(\Doctrine\Common\Persistence\Mapping\ReflectionService::class);

fixed it. Or at least clearing the cache

I will make a PR tonight with that change, unless you beat me to it. I will also check other files in the project, and then make a release of doctrine/persistence. That should fix it. Sorry for this.


Maintainers wanted!

Please comment if you are interested in helping to maintain this module :) Thanks!

I was thinking this one would live into http4s-jetty.  Assuming client and server are on the same release cycle, and they remain part of the same Jetty distribution, it makes sense to me.

Yes, this just dawned on me as well, sorry. I guess the trick I should have used is git merge with unrelated histories?

If you can get a branch up with those things done, I'm happy to fix up the build and CI stuff. Sorry for my mistake here!

No worries, it's easy, and I have Emacs.


Filter is not working .

i have a problem  the filter jsGrid not working after implement the jsGrid any idea?

Flying Dutchman switched off filtering.

i tried also to implement the jqGrid in a simple template html and  filtering doesn't work also i dont know what i'm missing.

just show jsGrid configuration

Please, checkout the following issue https://github.com/tabalinas/jsgrid/issues/32


add date parsing

This PR adds support for parsing whois dates as a time.Time. I added new fields to the struct to keep the package backwards compatible. I also added some test dates I stumbled across when querying multiple whois servers during testing.

Hello @firefart
Thanks for your PR, very great job!
Just one thing, the XXXDateParsed is not so clearly, because other fields, include XXXDate are also parsed.
Do you think change it to XXXDateInTime will be more clearly?
For example:
CreatedDate date in string format
CreatedDateInTime date in time format
Or, do you have a more sitable word?

Sure no problem, changed it. I'm bad at namind variables so I took your suggestion :)


deprecate raw input in tests

We have been using and recommending encoded instead. We should deprecate raw input in tests and remove all the logic we have for that in go-ftw.

We've already deprecated it: https://github.com/coreruleset/ftw-tests-schema/blob/7bee5e866b34465b2f9f226c9f3be34581cadd2a/types/types.go#L294. You mean, we should remove it for good now?

I think we should. There is code that we have for handling it that we can remove...


readme.txt

concern

add some text about the mod smh

pr it

concern

idk what the mod does

if i did, i'd pr obv


lint: Prevent importing from zerver in migrations.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @rishig!


Let OrderedClientCollection track the summarizer client separately

That allows us to postpone electing a new client while the existing summarizer is still doing work, e.g., doing a last summary.

I'd love to see UT cases added clearly covering this area, including conditions this PR addresses. I.e., have tests that fail before this PR and succeed with it, and clearly demonstrating benefits (and also reducing risks)

I'd love to see UT cases added clearly covering this area, including conditions this PR addresses. I.e., have tests that fail before this PR and succeed with it, and clearly demonstrating benefits (and also reducing risks)

Agreed. I wanted to have eyes on the fix itself first.

I'll be adding tests, though I'm not sure how to test the original scenario in which a new summarizer is elected after the delay while the original summarizer is still doing last summary. Also, is it possible to remove the opsToBypassInitialDelay part of delayBeforeCreatingSummarizer with this change?

Converting to draft, since I've found a couple of problems with this version of the change.

FYI, this is ready for review. I can provide an explanation for the separate tracking of electedClient and electedParent if that would be helpful. (Thanks.)

Any chance you can update description with a bit more info on what is changed, what is new design, etc.

Any chance you can update description with a bit more info on what is changed, what is new design, etc.

Sure. I've added a long comment to the OrderedClientElection class definition that explains how the scheme in this change works. Basically, it tracks the summarizer client and parent client separately so it can handle the case where the parent client changes (e.g., too many ops without summary, so we elect a new parent) but a new summarizer shouldn't be spawned until the old summarizer client leaves the quorum.


Missing a prop to pass a "name" to the underlying input.

When using within an HTML <form> I need an id and name attribute for the underlying input.
Right now, I'm having to wrap the component and use an effect to accomplish this:
const {name, id} = props
const inputRef = useRef<HTMLInputElement>(null)

useEffect(() => {
  const el = inputRef.current
  if (!el) return
  if (id) el.id = id
  if (name) el.name = name
}, [])

return (
  <OTPInput
    ref={inputRef}
    // ...

It'll be nice to have id and name props that can be directly passed to OTPInput.

Hi! Could not reproduce the issue locally.
Which version are you using?
Works in 0.3.31-beta
return (
  <OTPInput
    id="my-custom-input-id"
    name="my-custom-input-name"

https://github.com/guilhermerodz/input-otp/assets/10366880/4c38948c-279b-4b4b-aecc-be95c4ef2928

Hey, yep it worked with the latest. Thank you. Great work!


AttributeError: module 'google.protobuf.descriptor' has no attribute '_internal_create_key'

TL;DR
Unpin or remove the following libraries from requirements.txt, and do a redeployment.
protobuf
grpcio
grpcio-tools

Background
Recently, we upgraded the function host version to 3.0.15065 for v3. We also upgraded the Python worker from 1.1.6 to 1.1.8, and the change has been deployed to production on November 16, 2020.
In Python worker release 1.1.7, we now have a higher dependencies on the grpcio libraries (version: 1.33.1). This introduces a potential issue to function apps pinning protobuf, grpcio, grpcio-tools to old versions.
Root Cause
Since we prioritize customer's libraries before loading the Python workers dependency, an old version of protobuf has an issue parsing the new descriptor.
How to Mitigate
Please confirm if your function app does require grpcio, grpcio-tools, or the protobuf libraries.

If it does, please unpin these libraries by replacing the "==" sign to ">=" in youre requirements.txt
If it doesn't, please remove the lines defining grpcio, grpcio-tools and protobuf in your requirements.txt
After that, do a redeployment to Azure Functions and the issue should be resolved.

Sorry for the inconvenience, if you have more questions related to this issue, please let me know and comment below.

@Hazhzeng  Is there a way to have my deployed azure function use the pre-release version that includes the fix for this issue? Or do I have to wait until this is deployed to production in a future date (if so, what is this date?)?

The mitigation steps are confusing.

Please confirm if your function app does require grpcio, grpcio-tools, or the protobuf libraries.
If it does, please unpin these libraries by replacing the "==" sign to ">=" in youre requirements.txt
If it doesn't, please remove the lines defining grpcio, grpcio-tools and protobuf in your requirements.txt
After that, do a redeployment to Azure Functions and the issue should be resolved.

If I have the libraries, substitute "==" for ">=".  If you don't have the libraries, remove them?
Also, does this mitigation require you to install via requirements.txt up on the function itself, or can we install via requirements.txt in an Azure DevOps pipeline?  So far, I've been unable to mitigate this issue


[Feature] doe support array

Proposed changes
Issue Number: close #xxx
Problem Summary:
doe support array
Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[x] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Please use [feature](array)..... pass the ci check.


some question about multi_scale

i want to know how to implement multi_scale?Thank you very much

@FENGShuanglang  Im not sure if your question is related to the repo, or is it more of a general question on how to implement multi scale ?