SLDump: print the current vprop

This PR implements a suggestion by @R1kM : provide a SteelGhost function, sldump, to print the current vprop at type-checking time.
For instance, the code below (available in this PR at tests/micro-benchmarks/SteelSLDump.fst) will behave as follows when type-checking:
assume val p (idx: string) ([@@@smt_fallback] _ : int) : vprop
assume val inc (#n: int) (idx: string) : SteelT unit (p idx n) (fun _ -> p idx (n + 1))
let test () : SteelT unit (p "foo" 0 `star` p "bar" 18) (fun _ -> p "foo" 3 `star` p "bar" 19) =
  inc "foo";
  sldump "test 1" (); // this prints out:  test 1: p "bar" 19 `star` p "foo" 1
  inc "foo";
  inc "bar";
  sldump "test 2" (); // this prints out:  test 2: p "foo" 2 `star` p "bar" 20
  inc "foo";
  return ()

As Aymeric noted, this PR gathers the whole vprop available at its call site by virtue of being specified in the SteelGhostF effect.
The critical takeaway of this PR is that it implements sldump without any change to the Steel tactic. The secret sauce: follow the same pattern as gen_elim (#2553).
Here is the signature of sldump:
val sldump
  (#opened: _)
  (#[@@@framing_implicit] p: vprop)
  (#[@@@framing_implicit] q: vprop)
  (text: string)
  (#[@@@framing_implicit] sq: squash (sldump_prop text p q))
  (_: unit)
: SteelGhostF unit opened p (fun _ -> guard_vprop q) (fun _ -> True) (fun h _ h' -> h' p == h p)

The post-resource is guarded by guard_vprop: if any vprop uvar ?r appears in the same goal as guard_vprop q (or transitively "depends" on such a vprop uvar), then q must be solved before ?r. Thus, sldump is the only place where guard_vprop q can be solved.
In practice, q is solved by solving the logical goal sldump_prop text p q introduced when calling sldump.
To solve this logical goal, we register a tactic, solve_sldump_prop, separate from the Steel tactic, by including it as an entry into the dictionary passed when instantiating the Steel framing tactic:
[@@ resolve_implicits; framing_implicit; plugin;
    override_resolve_implicits_handler framing_implicit [`%Steel.Effect.Common.init_resolve_tac]]
let init_resolve_tac () = init_resolve_tac'
  [(`sldump_prop), solve_sldump_prop]

(This step wouldn't be necessary if unquote were supported by native tactics; if so, then an attribute on solve_sldump_prop would be enough.)
Then, I implemented solve_sldump_prop in such a way that it makes progress only once p is fully resolved (i.e. has no remaining vprop uvars.)
And, most importantly, that tactic is in charge of printing p...

In all cases, so far sldump will print p as soon as its vprop uvars are solved, but there might be some data uvars left. What about those?

Regarding the data uvars, I think that's fine, and actually useful this way. This will provide better information about what has been solved in the current state, and which implicits might need to be explicited.
Regarding guard_vprop, one additional question is how it interacts with scheduling. My understanding is that goals containing guard_vprops are solved last. But do they require all other SL goals to have been solved first? If so, can it be the case that a goal requires guard_vprop goals to be solved first, leading to failures? Additionally, what happens once you reach guard_vprop goals? Do you just remove all guard_vprop annotations? What guarantees do we now have about scheduling?

Thank you @R1kM for your detailed review. I can answer most of your questions based on #2553:

The framing tactic used to separate between separation logic goals, and logical goals, and solved the latter once all the former had been solved. How does this work now that you can have arbitrary propositions annotated with framing_implicit?

I am not enabling arbitrary propositions in requires clauses, but I am enabling framing_implicit arguments of squash type. While those were already classified as "separation logic goals" in filter_goals, even before I merged #2553:
https://github.com/FStarLang/FStar/blob/4d0b805396425bc30c3143a69f84a6665a09bc34/ulib/experimental/Steel.Effect.Common.fsti#L1326
I enabled their resolution by adding a case in solve_or_delay (after all cases for can_be_split, can_be_split_forall, etc.):
https://github.com/FStarLang/FStar/blob/eddc84f32b05af131d355ac587c1a7f1e59cb5aa/ulib/experimental/Steel.Effect.Common.fsti#L2746-L2758
This code snippet, which I added, is responsible for choosing, from the dictionary provided as argument to init_resolve_tac', the user tactic that will solve that squash implicit argument, based on the head symbol of the formula.
(Also note that, in the case where the user tactic fails but the goal has no uvars, it is passed to SMT.)
See also my detailed explanation in #2553, section "Generic elimination of exists_ and pure", Step 3.

How does the use of guard_vprop interact with the unitriangular invariant we formalized in the ICFP 21 paper, which ensured that scheduling would not get stuck?
[...]
Regarding guard_vprop, one additional question is how it interacts with scheduling. My understanding is that goals containing guard_vprops are solved last. But do they require all other SL goals to have been solved first? If so, can it be the case that a goal requires guard_vprop goals to be solved first, leading to failures? Additionally, what happens once you reach guard_vprop goals? Do you just remove all guard_vprop annotations? What guarantees do we now have about scheduling? Generally speaking, it would be good to add this information through comments in the Steel tactic

The key parts are that:

I added a topological sort to reorder goals based on the transitive closure of the following dependency order: if goal K contains both guard_vprop ?q and ?r, and if goal L contains ?r, then K must be solved before L (and thus, guard_vprop ?q must be solved before ?r.) More precisely, I computed the set of all vprop uvars that must be solved after guard_vprop ?q following this dependency order (see compute_guarded_uvars), and I modified pick_next so that it delays any goal containing any such vprop uvars from that computed set.

I unfold guard_vprop ?q only if ?q is solved (see unfold_guard)

Now, based on these changes of mine, the unitriangular invariant is preserved if all the following conditions hold:

no Steel function signature explicitly has a guard_vprop in its pre-resources
for any Steel function signature that explicitly has a guard_vprop in its post-resource, it is the only one occurrence of guard_vprop in the function signature, and it is of the form guard_vprop ?q where ?q does not appear elsewhere than:

at that occurrence in the post-resource, and
in a squash predicate of the form phi preresources ?q that is solved by a user tactic that makes progress only if all vprop uvars in the preresources are solved. The latter condition on the user tactic is critical for unitriangularity, and ensures that ?q is unambiguously solved only there, and only after all the pre-resources are solved.

Which is the case both for gen_elim and for this PR's proposal for sldump.


Remove "version" related code from test generator.

As of: https://github.com/exercism/ruby/issues/836 the BookKeeping section is no longer used in the exercise test cases.
The test generator contains code to update the BookKeeping version number in the test cases and example solutions.
This code is no longer required and can be removed.
TODO:
Remove version related things from the test case generator.
This includes:

Command line option.
Generator unit tests.
Generator source code.
All the exercise/*/.meta/.version files.
Anything else you can find that I've forgotten.

Hi @Insti 👋 , would love to help out with this one!

Super! Let me know if you have any questions.


Incorrect path to misc.hh

In src/aladdin/gem5/HybridDatapath.cpp, line 11:
#include "base/misc.hh"  -->   #include "arch/x86/regs/misc.hh"

You seem to be an older version of Aladdin. See this commit: https://github.com/ysshao/ALADDIN/commit/422713be97ad0aab90bc807306702196d2c6b1c8

Thanks, I did not have the update code by running "git recursive"


Fix revalidation configuration for ISR

Revalidation had been accidentally declared within the props.
This meant that pages would never be re-built.
This would result in build time data always being used.

Codecov Report

Merging #23 (bd046d9) into main (a371d6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   65.23%   65.23%
=======================================
  Files          39       39
  Lines         279      279
  Branches       60       60
=======================================
  Hits          182      182
  Misses         97       97

Impacted Files
Coverage Δ

src/pages/index.tsx
66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a371d6e...bd046d9. Read the comment docs.


Update "Microsoft.CodeAnalysis.CSharp" to latest release

This PR updates Microsoft.CodeAnalysis.CSharp to the latest release otherwise new keywords introduced with C# 9 like record don't appear highlighted/coloured.

Merged! Thank you for your contribution. Much appreciated! 👍


Clean up OldVolumeStatus etc

Removing old volume config/status, storage config/status and certs
config/status
Signed-off-by: zed-rishabh<EMAIL_ADDRESS>

CertObjConfig/Status is completely tied with storage config and status. And if we are moving away from the downloading of the certs then we will need a whole new implementation for signing cert management. In my opinion, we can get rid of this for now.
(I can revert my changes related to certs if we think we need to keep it)


Artifacts in editor background on macOS

VSCode Version: 1.35.0 (It started in 1.31.0)
OS Version: macOS 10.14.4

Steps to Reproduce:

Change the current theme's editor.background to #212337
Notice artifacts in the background

See right side of the editor background in this screenshot (not sidebar, to the left of the sidebar the colors are darker compared to the background color behind the code).

I mentioned this already here https://github.com/microsoft/vscode/issues/68001#issuecomment-461318004
But I stayed on 1.30.2 and forgot about it. Now I've updated to the latest version and it's still not fixed. However, I'm pretty sure the Electron 4.x upgrade next month fixes this from what I tested. It's just really weird how only colors right around the HSL values of this specific background color causes the artifacts...

Okay so weirdly enough, only colors right around the editor.background color I chose for this theme causes the artifact problem. If you change any theme's background color to this theme's exact background color, the problem occurs.

For now, you can change editor.background to a different color. e.g. Palenight's "editor.background": "#292D3E"

If I try to just move the color picker a few pixels from this theme's current background color, it's not enough to fix it. It's like a whole vicinity of colors around it that is buggy.

Does this issue occur when all extensions are disabled?: Yes

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Yes it's fixed, I'm guessing it has something to do with the color profile.
Is that release version out stable in early July? My color theme has this artifact problem and it can't be fixed for the current versions :s

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/


Remove native methods provided in jsonnet 0 10 0

We can't take commits unless you sign your commits. Please review https://github.com/ksonnet/ksonnet/blob/master/CONTRIBUTING.md.


Add 'Copy Script UID' option to Script Editor

Addresses the third item from https://github.com/godotengine/godot/issues/87418

Script UIDs are back, but built-in scripts don't have them. The option should be disabled in that case, otherwise you end up with uid://<invalid>.


Names with Spaces

[Enter feedback here]
Name with spaces are allowed to be entered but cause issues in deployment scripts.
spaces in triggers and pipelines when using parameters will cause issues if the spaces aren’t accounted for in deployment scripts.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65f81ce0-8915-2390-2c8e-53eb8a93180b
Version Independent ID: 49fb5956-019b-0f5a-ebff-1ae19fe87c80
Content: Rules for naming Azure Data Factory entities - Azure Data Factory
Content Source: articles/data-factory/naming-rules.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

@samirvora-MS Thanks for reaching out. We will investigate and update the thread.

That seems to be consistent with the rules. Should it be added as a !important recommendation?

Hey there,
Thank you for bringing this to our attention. Due to ARM Template and Powershell script constraints, we do not recommend having spaces in your resource names. I have added this information to the documentation under Best practices and it should be live tomorrow.
Thanks,
Daniel
#please-close


feat: textview component

Implementation of a TextView component, reference issue #13

@farfromrefug I hope you had a good new year! I think this is ready for review now. Both the ios and android versions of TextView are now working.

@Logikgate awesome will try to find time to test this this week!
Thanks!

@Logikgate i pushed your PR in https://github.com/Akylas/nativescript-material-components/pull/100
I could not commit and push to your PR. Had to create another one ...
Thanks a lot!


fixed parsing of files where there are commas embedded in ""

for Rick's new data file

fixed

fixed


No response when using ollama behind an nginx proxy

I am running ollama on my Google compute instance behind an nginx proxy. I can navigate to the endpoint and confirm /api/tags returns a response as well as other endpoints such as /api/version.
Unfortunately when I add my endpoint via enchanted's settings, I can send a chat, but I never receive a response. I also confirmed that the request is received by ollama via the logs on the server.

Hi @rwatts3 if you could post a minimum set of instructions to reproduce your environment I'd be happy to go and debug the issue.

hi, were you all able to get the app working? I have exposed ollama web ui to the internet via nginx at gpt.domain.com but when i enter that as ollama URL, the app doesn't do anything. No error either

I'm able to confirm that I'm also seeing issues with running nginx.
Here's part of my nginx config,
upstream chat-llm {
    server <IP_ADDRESS>:11434;
  }

  server {
    server_name chat.domain.com;
    location / {
      proxy_pass http://<IP_ADDRESS>:3123; #OpenwebUI
     }
     location /llm/ {
     proxy_pass http://chat-llm/;
     proxy_connect_timeout	300;
     proxy_send_timeout          300;
     proxy_read_timeout          300;
     send_timeout                300;
}

I'm able to confirm that ollama API is being serverd correctly, and is actually working just fine with other tools like OpenWeb-UI
You can see in the screenshot that OpenWeb-UI can answer the same prompt in full, where as Enchanted simply gets cut off

I've been able to recreate this with multiple different instances of Ollama being run on various IPs and different proxy configs.


Update 'How to Contribute', to start from and target to dev-xx when localizing

It would be great to update 'How to Contribute', to start from and target to dev-xx branch when doing l10n tasks.

#777 is relevant with this issue.


Wildcard in node-adodb query returns blank results, but runs OK in MS Access

Everything is working fine for normal SELECT queries, and for SELECT queries with a static WHERE clause (eg: ...WHERE Customer id=1 " works fine! )
HOWEVER, When I use a wildcard * in my WHERE clause as above, I receive an empty dataset:
[]
...Even though the exact same query runs perfectly in MS Access GUI
EG: DB_QUERY("SELECT * FROM Customers WHERE ContactFirstName LIKE '*Howard*' ", req, res, next);  returns: [] when running in code, but, the SQL statement run in MS Access returns many records:
Screenshot
Here is my code:
//example of wildcard query

'use strict';
module.exports = (req, res, next) => {
    return DB_QUERY("SELECT * FROM Customers WHERE ContactFirstName LIKE '*Howard*' ", req, res, next);
};

//index.js file

const adodb = require('node-adodb');
const restify = require('restify');
require('restify').plugins;

server.use(restify.plugins.queryParser({ mapParams: true }));
server.use(restify.plugins.bodyParser({ mapParams: true }));
server.use(restify.plugins.acceptParser(server.acceptable));

var DB_PATH = 'C:\\data\\data.mdb';
var ADODB = adodb.open('Provider=Microsoft.Jet.OLEDB.4.0;Data Source=' + DB_PATH);
var DB_QUERY = function(dbQuery, req, res, next, pics){
    var isWin = /^win/.test(process.platform);
    if(!isWin){
      res.send('This should be run on a Windows Machine only to connect to Access DB File at: ' + DB_PATH);
    } else {
        try {
            if (fs.existsSync(DB_PATH)) {
            ADODB.query(dbQuery, true)
            .on('done', function(data) {
                console.log(dbQuery.cyan);
                // console.log('data',data); // why is this empty when i run a wildcard search query???
                res.send(data);
            })
            .on('fail', function(error) {
                console.log('Failed');
                console.log(error);
                res.send(error);
            });
            } else {
            console.log('Failed: file does not exist at:' + this.DB_PATH);
            res.send('Database could not connect - Please contact admin');
            }
        }
        catch (error) {
            console.log('error:'.error);
            res.send(error);
        } finally {
            console.log('Complete');
        }
    }
}

Please advise, thanks, am I doing this wrong?

I was able to solve this by replacing the single quotes with double ones, and replacing the asterisk wildcard symbol used in MS Access with the % sign, instead.
This article pointed me to the solution:
https://social.msdn.microsoft.com/Forums/en-US/5d176ff7-1493-4f11-b322-afb1f0be0063/trouble-getting-sql-query-to-work-using-like-clause-with-astersik-as-wildcard-in-adonet?forum=sqlexpress

Hi @EarthmanWeb
I am trying to execute below query of ms access database using node.js . I am passing the id from get operation . It does not filter the result with the ID rather returning the whole data.
connection
.query('SELECT * FROM Employee where ID = [id]', id)


Resolve Glyph Error

When parsing page 728 of the Salt Lake City District Court .pdf file, the script is encountering an error Unknown glyph width for 127 Courier:
/usr/local/var/rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/pdf-reader-1.3.3/lib/pdf/reader/width_calculator/built_in.rb:93:in `glyph_width': Unknown glyph width for 127 Courier (ArgumentError)

the gem author says this issue has been resolved on the master branch, but using the gem from github source does not resolve the issue.
# Gemfile
gem 'pdf-reader', :git => 'git://github.com/yob/pdf-reader.git'

see screenshot below.
the offending character is ØN§ûø•
also, it appears some events do spill onto multiple pages. this logic will need to be accounted-for during ETL.

KEITH KELLY
THIRD FLOOR - S35
             February 26, 2016
                        Friday
MUR 151907528 State Felony
  ATTY: GILL, SIMARJIT S
        OLER, STEPHEN A
  ATTY: SHREVE, CHARITY
01:30 PM VS.
     SCHEDULING CONF 2
STATE OF UTAH
LUCIANO, AUTUM S
   OTN:
DOB: 06/17/1994
3RD DISTRICT COURT - SALT LAKE
F3 - POSSESSION OR USE OF A CONTROLLED
     SUBSTANCE
MB - USE OR POSSESSION OF DRUG PARAPHERNALIA
- 06/16/15
- 06/16/15
SHERIFF #: 371539     LEA #: 15C010690
PROSECUTING AGENCY NUMBER: 15015184
                         >      NO OTN NUMBER      <
                             >    CASE EFILED   <
------------------------------------------------------------------------------
VS.

SHERIFF #: 160734     LEA #: 15SL05860
PROSECUTING AGENCY NUMBER: 15026002
ATTY:
F3 - PURCH, TRANS, POSSESS, USE OF A FIREARM BY
     RESTRICTED PERSON
MB - USE OR POSSESSION OF DRUG PARAPHERNALIA
- 09/01/15
- 09/01/15
                           >    CASE EFILED   <
------------------------------------------------------------------------------
Page 727 of 1372
VS.
SHERIFF #: 176055     LEA #: 15-156396
PROSECUTING AGENCY NUMBER: 15023287
MESTAS, ROBERT JOHN
   OTN: 48969216
DOB: 12/17/1972
3RD DISTRICT COURT - SALT LAKE
KEITH KELLY
THIRD FLOOR - S35
              SUBSTANCE
         MB - USE OR POSSESSION OF DRUG PARAPHERNALIA
         MB - CRIMINAL TRESPASS KNOWING ENTRY UNLAWFUL
    February 26, 2016
               Friday
- ØN§ûø•
- 01/05/16
- 01/05/16
CITATION #:             SHERIFF #: 160734     LEA #: SL16-2426
PROSECUTING AGENCY NUMBER: 16000169
                             >    CASE EFILED   <
  ------------------------------------------------------------------------------
     SCHEDULING CONF 1/JAIL
STATE OF UTAH
S18 151911178 State Felony
  ATTY: GILL, SIMARJIT S
        VO-DUC, GEORGE F
ATTY:
F2 - THEFT
MA - THEFT BY RECEIVING STOLEN PROPERTY
- 09/12/15
- 09/14/15
                           >    CASE EFILED   <
------------------------------------------------------------------------------
              INITIAL APP/SC/BAIL HEARING
         STATE OF UTAH
         MILLANO, JOSE (Jail)
           AKA MILLANO, JOSE GREGORIO
           AKA MILLANO, JOSE C
            OTN: 49107709    DOB: 12/05/1967
         F1 - AGGRAVATED SEXUAL ABUSE OF A CHILD
         F1 - AGGRAVATED SEXUAL ABUSE OF A CHILD
SHERIFF #: 391420     LEA #: 2016-23252
PROSECUTING AGENCY NUMBER: 16003118
VS.
SLC 161901545 State Felony
  ATTY: GILL, SIMARJIT S
        ZIMMERMAN, KRISTIN L
  ATTY: KEMP, KEVIN M
         - 01/01/10
         - 01/01/10
                           >    CASE EFILED   <
------------------------------------------------------------------------------
              SCHEDULING CONF 1/JAIL
         STATE OF UTAH
         MOLL, NICOLE RACHEL
           AKA JOHNSON, NICOLE
            OTN: 49055254    DOB: 06/20/1981
         F3 - POSS W/ INTENT TO DIST C/SUBSTANCE
SHERIFF #: 330030     LEA #: 15-235320
PROSECUTING AGENCY NUMBER: 15030112
VS.
SLC 161900522 State Felony
  ATTY: GILL, SIMARJIT S
        VO-DUC, GEORGE F
ATTY:
                           >    CASE EFILED   <
------------------------------------------------------------------------------
- 12/11/15
Page 728 of 1372


All podcasts stopped updating on Sep 26th 2023

All the NPR podcast feeds stopped updating on Sep 26th, 2023.

Thanks for reporting this, it looks like the NPR web page has changed which is causing error in the generation. Unfortunately, I won't be able to look into this until late next week.

Thanks for taking a look. Seems that "All Things Considered" does work, though it appears rather late most days.

On Sep 27, 2023, at 6:50 AM, Matthew Gyurgyik @.***> wrote:
Thanks for reporting this, it looks like the NPR web page has changed which is causing error in the generation. Unfortunately, I won't be able to look into this until late next week.
—
Reply to this email directly, view it on GitHub https://github.com/pyther/podfeed/issues/9#issuecomment-1737442272, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC3OJXZREIZ523BP6C7BHUDX4QVJTANCNFSM6AAAAAA5JMP6TM.
You are receiving this because you authored the thread.

This morning, the Morning Edition feed pulled in 100 episodes dating back to September 29.
Weekend Edition Saturday and Sunday did not pull in any episodes. I’m not sure about the Fresh Air feed, as I don’t subscribe to that through this service.

I've refreshed a few times and don't see anything other than ATC yet (using
Podcasts), but looking forward to having it back up and running.
On Fri, Oct 6, 2023, 6:30 AM Tim Weston @.***> wrote:

This morning, the Morning Edition feed pulled in 100 episodes dating back
to September 29.
Weekend Edition Saturday and Sunday did not pull in any episodes. I’m not
sure about the Fresh Air feed, as I don’t subscribe to that through this
service.
—
Reply to this email directly, view it on GitHub
https://github.com/pyther/podfeed/issues/9#issuecomment-1750373288, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO3J2FJI5VNPGRMGIFRPXLX57MUZAVCNFSM6AAAAAA5JMP6TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGM3TGMRYHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm getting this error message on RSS validators for the Morning Edition feed (https://pca.st/podcast/b1483460-5db0-0137-f266-1d245fc5f9cf)

Morning Edition is updating once more, but Weekend Edition Saturday and Weekend Edition Sunday feeds still appear to be broken. Fresh Air and All Things Considered are fine.

Just received episodes of Weekend Edition Saturday from September 30 and October 7 in my podcast app (Overcast for iOS).
Nothing (yet) for Weekend Edition Sunday.

Matthew, or whoever fixed the tool,
Thanks, the main feeds work for me now, the weekend edition feeds don't appear though.
Matt

On Sep 27, 2023, at 6:50 AM, Matthew Gyurgyik @.***> wrote:
Thanks for reporting this, it looks like the NPR web page has changed which is causing error in the generation. Unfortunately, I won't be able to look into this until late next week.
—
Reply to this email directly, view it on GitHub https://github.com/pyther/podfeed/issues/9#issuecomment-1737442272, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC3OJXZREIZ523BP6C7BHUDX4QVJTANCNFSM6AAAAAA5JMP6TM.
You are receiving this because you authored the thread.

Sorry for the delay, I was on travel and didn't have the cycles to dig into this. This should be fixed with https://github.com/pyther/podfeed/commit/a832a174ad943de1040c6e10a5bd24879c857e9a. Podfeed was failing to find the publication date from the media_url. The media_url was changed for some stories and the new url did not contain a publication date. The new code will now fallback to parsing the story_url.


Example doesnt work

AttributeError: module 'spotify' has no attribute 'Client'
in searching example file

Could you send a traceback of the error and which example file this occurs in?

Traceback (most recent call last):
File "C:/***/spot/spotify.py", line 2, in <module>     import spotify   File "C:\***\spot\spotify.py", line 4, in <module>     client = spotify.Client('f5fa8cb****4dc2a31e81844720a1f9', '3b********3f441489c18395cb77892f') AttributeError: module 'spotify' has no attribute 'Client'
in this example
https://github.com/mental32/spotify.py/blob/master/examples/searching.py

Thanks!
What version of the library are you running? print(spotify.__version__) or pip3 show spotify should be able to show you this.
also did you install it from pypi using pip or clone it from Github?

i try both
but terminal said Version: 0.3.0

You wouldn't happen to have a python file in the same directory named spotify.py would you? If you do then remove it, as the file is preferred when importing rather than the actual lib.
I have tested pypi and Github, and have not been able to reproduce this issue, which makes me think its something specific to your environment.

It works after renaming file . thank you


[connectivity_plus] website docs + example app

Part of #113.
This PR includes:

Adding the website docs for Connectivity Plus.
Small changes to example app.
Removing old README docs.

Need to add grammarly to VS code
Thank you! Will fix and merge


Bad tooltip for the search box

STR:

Open the devtools in this page
Switch to the inspector panel (also reproducible with other panels in which the search box is visible)
Give the focus to the search box

Expected result:
Some relevant tooltip or none.
Actual result:
We get the tooltip we have when focusing the native filter box of the Debugger panel

Florent

It looks like it has been fixed with 595c940b7c02b74f2a7ecd5e6ab247534e34b330 :smiley:
Florent


fix(debounce): Cancel debounce on component unmount

Fixes #14

Cancelling debounce on Component will unmount.

@nutboltu This looks great. Thanks for the PR. 🎉

Changes released with v2.0.0. Thank you!


Ticks callback have unexpected behavior

As I mentioned here https://github.com/nnnick/Chart.js/pull/1021#issuecomment-165442173.
I think the ticks callback have som unexpected behavior.
Let's say I want to show every X label, with something like:
function (label, index) {
    return index % 10 === 0 ? label : '';
}

On some screen sizes it does what expected and in some not.
I guess the algorithm that automatically skips some labels interfere with the callback.
If I'm not mistaken that algorithm counts against the whole ticks array and not the actual showed one?
I have a graph with over 300 data points and want to show 3-5 labels and it really isn't possible with the callback.
Example.
I can live with this many labels

but on a small screen it only showing one:

Even more clear when it shows only one here:

but a little smaller screen and it shows four:

Not a big problem for me since I already have my own custom scale and can implement the afterBuildTicks hook and simply filter the ticks array, but it probably should be fixed.
JsFiddle for the example:
https://jsfiddle.net/olyckne/7ycm5bjg/10/

There is an auto skipper. Shouldn't be too difficult to disable in this case.

Yeah. If you have implemented a callback you probably don't want the auto skipper so it could probably be disabled in that case. Another option is an autoSkipper true/false.

Oh, just noticed the afterBuildTicks "workaround" doesn't work at all.
Maybe it isn't supposed to be used as I did it though.
I simply filtered this.ticks to only contain 4 items, but that means the labels is showing on completely wrong places, and the first four tooltips gets their title from those four items.
afterBuildTicks: function() {
    var everyX = (Math.ceil((this.ticks.length/2)/10)*10);
    this.ticks = _.filter(this.ticks, function (tick, index) {
        if (index === 1 || index === this.ticks.length - 1 ) {
            return true;
        }
        return index % everyX === 0;
    }.bind(this));
}

Closing since #1810 was merged


Created license, contributing files and updated readme

create license, contributing files and update readme

Both the contributing and license files look good to me.


productionalized url clsassifier

@josh-chamberlain Let me know if you have any issues with this new branch


Extra space added after pasting JSDoc comment

VS Code Version: 1.55.1 (but also 1.55.0 and at least the last one or two minor versions of v1.54)
OS Version: Windows 10

Code formatting in at least es6 is broken since last 2 or 3 minor versions of Vs Code. It happens a lot since that code aligns completely wrong and out of place while there is nothing wrong with the code. It's pretty frustrating. This was working fine and without issues before. This is not an issue with some extension as it's also the case when running without extensions.
The reason for this 'confused formatter' seems to be that after copying code with jsdoc, the alignment of the method name is wrong in the pasted fragment and that confuses the formatter for the rest of the code and every time it tries to format it after that paste. BTW in the example below the error-offset is only one space, but it also happens that the alignment skips 'tabs' (spaces here) and that makes the code even more misaligned and so unreadable and messed up.
See gif:

Steps to Reproduce:

Copy code with jsdoc
Paste code with jsdoc
See that the method name isn't alligned as supposed to, but now is aligned to the jsDoc. See that the formatter is confused and keeps messing up.

Does this issue occur when all extensions are disabled?: Yes (see demo)

Your original title was too generic. The new one better describes the issue

Well, it's obvious I see that differently; it wasn't too generic, these issues are obviously related and now you narrowed the issue to something that it's not.

Please open separate issues for any other formatting bugs you see

I'd rather not need to open any issues like this one at all. These are issues that could have been prevented by just simple tests IMO, and weren't there before so I don't get why they are here now in the first place. No offense, you guys create a great tool and you obviously work very hard. But as a daily user for years now it would be nice to see some issues getting fixed again as important issues we bump our heads to are piling up for some months now. Unfortunately lately more and more issues were introduced in VS Code and I don't see them getting fixed for a long time now unfortunately. Some of them are making working with VS Code more and more frustrating, while this was such a great and flawless experience before. Which is a shame as it's such a great tool with such a great base and I love. Just hoping for an update without new features, but making stuff reliable again! Keep up the great work

I do think this is a duplicate of #119225.  I have PR #136579 open that should fix this.  @mjbvz, should I tag my PR as fixing this issue too?  I haven't been able to get anyone to review it yet, though.

Thanks @ssigwart . This issue is pretty annoying. So let's hope your PR gets this fixed and gets merged soon!

@ssigwart the issue is still there. Just tried the latest Insiders build (1.67.0-insider), but also there it isn't fixed yet.
This issue is around and annoying for over a YEAR!!!! now. When will this ever be fixed?  I also don't get why this wasn't fixed directly after it occured after breaking a working version of VS Code. Wouldn't that have been easier than to fix this a year later (if ever)?!

@bencresty, I'm just a contributor with limited repo permissions.  I have the same feelings.  I have several unreviewed pull requests that I can't get any traction on.  At this point, I've stopped contributing because I was just wasting my time.  When someone starts responding to my PRs, I'll start contributing again.

Is there a way we can bring this to the attention of the Microsoft team? Is it stuck in review because they're not aware of its existence or does this simply have a low priority?

When I first started contributing, I did get a few fixes for other things through, so I think the process is to submit PRs and then someone from Microsoft will prioritize it.  I feel like if people who are affected start adding reactions and comments to the relevant issues (this, #127589, #119225, #140895), maybe it could raise the priority.

@bencresty, I'm just a contributor with limited repo permissions. I have the same feelings.

Ok, sorry that I didn't look more closely into who you are. Thanks for letting me know.

I feel like if people who are affected start adding reactions and comments to the relevant issues (this, #127589, #119225, #140895), maybe it could raise the priority.

Might be, but that's not the way it should work IMO. People at Microsoft building this are developers too so they know programming is not only picking the fun parts by making all kinds of cool stuff and sugar 99% of the people will never use and first make sure that what's actually important works and gets fixed if it's not working.
Last updates there are introduced a lot of annoying bugs that took forever (meaning at least a year) to fix or are still not fixed.
People at Microsoft surely know what priorities of its users are, but they have other priorities. It's the world upside down if we should do all kinds of tricks to get attention to bugs they introduce and are still not fixed after a year. That's just crazy to me.

Yes, it's annoying. This bug is not the worst one that I have an open PR for in my opinion. However, Microsoft built a really good editor that they open sourced and offered for free. I don't think it's fair to make assumptions about what Microsoft's intentions are. Also, the individual developers likely are annoyed by similar bugs, but have other work responsibilities, so they can't choose to spend time on whatever bug they please. They do mention in https://github.com/microsoft/vscode/wiki/Issues-Triaging#up-voting-a-feature-request that up-voting features is part of their triaging, so I think the most constructive thing to do would be to have anyone that's affected by this and other bugs to up-vote them.

@ssigwart

Yes, it's annoying. This bug is not the worst one that I have an open PR for in my opinion. However, Microsoft built a really good editor that they open sourced and offered for free.

I agree. This is a great editor and I'm working in it with a lot of pleasure every day. That doens't mean everything is perfect tho and if an issue is standing for over a year, while introduced in a before fine working program, we might expect action would be taken a little sooner instead of introducing all kinds of new features that I consider sugar.
Of course that's completely up to Microsoft and they have all rights to do so and I also get that's it's far more enjoyable to introduce new features than to fix issues. And I also understand they're fixing a lot (!!) of issues anyway and they have a massive user base. So I completely acknowledge how difficult that must be and think they do a great job at it still. Eventhough I don't agree on how they handled this particular issue.

I don't think it's fair to make assumptions about what Microsoft's intentions are. Also, the individual developers likely are annoyed by similar bugs, but have other work responsibilities, so they can't choose to spend time on whatever bug they please.

It looks like my point didn't come across as intended. I'm not at all mad ad Microsoft nor on its developers. Why would I? I'm only thinking in perspectives and imagine that Microsoft has a different perspective on things than its users have in deciding what to fix and/or when and what the priorities are. When a commercial company like Microsoft is investing lots of time and money into a project like VS Code you might expect something beneficial to be the reason in the end. That's just common sense to me, nothing offensive.

They do mention in https://github.com/microsoft/vscode/wiki/Issues-Triaging#up-voting-a-feature-request that up-voting features is part of their triaging, so I think the most constructive thing to do would be to have anyone that's affected by this and other bugs to up-vote them.

So lets' upvote ;)
Have a nice day!

I appreciate the attention this bug has already received.
This has apparently been open for a year and a half -- since at least April of 2021 (I write this at the end of October 2022).
A new bug report that I opened has been closed as a duplicate of this. That's fine -- but does anybody at Microsoft care?
The impact of this bug is to break every Javascript file that includes a standard JSDoc header. The only workaround I've found is to edit the JSDoc block comment header (by hand, since there seems to be no way to specify or change the behavior of the "feature" that adds block comments) -- and thereby make each JSDoc header non-compliant with the widely accepted JSDoc specification.
This is is FAR more important to me than the pretty much every entry I've seen in the VSC changelog since April of 2021.
Who decides which of these open issues to address in any one release?
Is it REALLY that hard to make VSC handle this correctly?
My intent in adding this comment is help raise the awareness of this issue within the MS development team. I appreciate any attention that team can give to solving this issue. If nothing else, perhaps the team could provide guidance about a timeline for resolution.

Is it REALLY that hard to make VSC handle this correctly?

It's even worse: this was working perfectly fine before they messed this up and IMO they could've and should've just look in the changelog at the time to find out what would've caused this to fail when it was reported, because it was still freshly damaged at the time and wouldn't probably be too difficult to trace back than. But instead they added lots of new features... and introduced lots of new features instead.
Rule no 1 for developers IMO; when something is destroyed by a mistake, stop adding new features and fix the bug first. Especially a bug that has so much impact and is directly touching the core of the product: editing code.

@bencresty: I've been on the developer's side of a big project like this, and I'm therefore sympathetic.
I mostly hope that the visibility of this bug can be raised enough to get it onto the list of things to fix -- perhaps even in the November update cycle.

#136579 was merged yesterday, so I think this should be resolved by that when the next version comes out.


doesn't work for me - no changes in cpp json

just tried to use, VSCode 1.12.
for sure, select delete and reconfgiure for cmaketools, but no changes in c_cpp_properties.json
in other hand , this (by default ) doesn't contain the path to standard libraries and vscode/cpptools can't recognize standard headers location

Thanks for reporting the issue.
Could you please try with the latest version of  **VS Code Insiders and the latest version of the extension?
As for the standard libs' includes... you're right! I couldn't find how to extract them from CMake Tools :/ If you have ideas, feel free to submit them. I will do my best to implement them.

initially I didn't understand  whats happened, and even raised the request for cpptools developers.
don't know how but problem with standard headers was resolved.
but damaged c_cpp_properties.json file is a real problem.
okay I'll try insiders version and let you know

Ok. Sorry for that. But please note that this behavior is mentioned in the extension's README:

Mirroring the Information in cpptools
Each time CMake Tools Helper is notified, the following happens:
1.CMake Tools Helper

Gets the current configuration and target name from CMake Tools
Overrides the content of c_cpp_properties.json using the information from step 1

@amigo421 I was going over CMake Tools' code when I remembered that the current implementation of  CMake Tools Helper relies on  the cmake.experimental.useCMakeServer option to be true.
Please make sure that this option is enabled.

Hi @amigo421
Do you still face the issue after enabling CMake Server?

sorry for delay, insiders build didn't solve the problem,
the same issue, cmake server is enabled in CMakeTools by default.
do you need dev console from vscode hel[p menu?

Thanks for the feedback.
That's odd.. I did a few tests but couldn't find out why you would get such a problem.
If you have:

cmake.useCMakeServer set to true (restarting VSCode is necessary to apply this change)
Reconfigured the project (by erasing the cache then regenerating the project)
Selected a target (other than "all", "zero_check", etc.)

then, this extension should write a valid configuration to the cpptools' json file.
Sure, the dev console log might help, please consider sending it.
Also, if you're familiar with VSCode extension development, you could:

Clone this repo
Open it in VSCode
Press F5 to debug
If an exception is raised, VSCode should pinpoint its exact location with some info on why it happened

okay, I'll try to debug and let you know about the results

Same thing happened to me literally 5 minutes ago.
Fixed it by changing build target from "all" (which was set by default for some reason) to "ALL_BUILD" (which was suggested in the dropdown).
Setting target to the one created with add_executable also works.

@exploser Great! Thanks for the feedback.
I'd suggest selecting the targets created by add_executable or add_library. This way, this extension will set the proper includes and defines in cpptools' c_cpp_properties.json ;)

I get this, same problem with missing  includes
[Extension Host] rejected promise not handled within 1 second
h.logExtensionHostMessage @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29 Invalid backend promise: Error: Invalid backend promise
at new CMakeToolsWrapper (/Users/gheorghem/.vscode/extensions/vector-of-bool.cmake-tools-0.10.1/out/src/wrapper.js:46:40)
at /Users/gheorghem/.vscode/extensions/vector-of-bool.cmake-tools-0.10.1/out/src/extension.js:17:23
at Generator.next ()
at /Users/gheorghem/.vscode/extensions/vector-of-bool.cmake-tools-0.10.1/out/src/extension.js:7:65
at __awaiter (/Users/gheorghem/.vscode/extensions/vector-of-bool.cmake-tools-0.10.1/out/src/extension.js:3:12)
at activate (/Users/gheorghem/.vscode/extensions/vector-of-bool.cmake-tools-0.10.1/out/src/extension.js:15:12)
at Function.t._callActivateOptional (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:23:417918)
at Function.t._callActivate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:23:417703)
at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:23:417478
at Object.m [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:23:41973)
Using latest official vscode  &&  pluggins. Points to s
cmake-tools though

I'm seeing the same symptoms but slightly different backtrace in the developer console:
[Extension Host] rejected promise not handled within 1 second
h.logExtensionHostMessage @ extensionHost.ts:320
shell.ts:443 Cannot read property 'forEach' of undefined: TypeError: Cannot read property 'forEach' of undefined
at target (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:29:34)
at configuration.parse (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:37:11)
at new configuration (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:22:14)
at prj.targets.forEach.tgt (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:75:54)
at Array.forEach (native)
at cfg.projects.forEach.prj (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:73:33)
at Array.forEach (native)
at configs.forEach.cfg (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:72:30)
at Array.forEach (native)
at c_cpp_properties.parse (/Users/matgra01/.vscode/extensions/maddouri.cmake-tools-helper-0.1.1/out/src/c_cpp_properties.js:71:21)
e.onUnexpectedError @ shell.ts:443

I have the same error as above: "TypeError: Cannot read property 'forEach' of undefined"

Looks like just need to check if target has filegroups at line 29 of c_cpp_properties.
Will test out if I get a chance.

Having the same issue: TypeError: Cannot read property 'forEach' of undefined
Here's what my c_cpp_properties looks like:

c_cpp_properties.json

{
    "configurations": [
        {
            "name": "Mac",
            "includePath": [
                "/usr/include",
                "/usr/local/include",
                "${workspaceRoot}"
            ],
            "defines": [],
            "intelliSenseMode": "clang-x64",
            "browse": {
                "path": [
                    "/usr/include",
                    "/usr/local/include",
                    "${workspaceRoot}"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            },
            "macFrameworkPath": [
                "/System/Library/Frameworks",
                "/Library/Frameworks"
            ]
        },
        {
            "name": "Linux",
            "includePath": [
                "/usr/include/c++/5",
                "/usr/include/x86_64-linux-gnu/c++/5",
                "/usr/local/include",
                "/usr/include",
                "/usr/include/x86_64-linux-gnu",
                "${workspaceRoot}"
            ],
            "defines": [],
            "intelliSenseMode": "clang-x64",
            "browse": {
                "path": [
                    "/usr/include/c++/5",
                    "/usr/include/x86_64-linux-gnu/c++/5",
                    "/usr/local/include",
                    "/usr/include",
                    "/usr/include/x86_64-linux-gnu",
                    "${workspaceRoot}"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            }
        },
        {
            "name": "Win32",
            "includePath": [
                "C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/include",
                "${workspaceRoot}"
            ],
            "defines": [
                "_DEBUG",
                "UNICODE"
            ],
            "intelliSenseMode": "msvc-x64",
            "browse": {
                "path": [
                    "C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/include/*",
                    "${workspaceRoot}"
                ],
                "limitSymbolsToIncludedHeaders": true,
                "databaseFilename": ""
            }
        }
    ],
    "version": 3
}

Yeah, looks like some targets just don't have the fileGroups property.   Can confirm that PR #7 fixes the issue.

PR #7 fixes the issues for me as well.

v0.2.0 includes #7
Is this issue still present?

Works well now!


convert report type from int

Report type could not be converted from number to Enum directly.

@EvgeniiSkrebtcov @hilmarf: I have changed the approach after talking with @EugenM-SAP. Spring can convert the enum name from a String, which makes the solution a lot cleaner.


Test environment as a map not an array

processEnv.includes('NO_NPM_UPDATE_NOTIFIER') is wrong, it should use hasOwnProperty()

Fixed in 1.1.0.


Add changelog to releases

It would be very helpful if the release would contain a change log. This would make updating the action way easier and avoid unexpected changes from being applied and breaking pipelines.

This GitHub action just follows the releases for the Buf CLI, so the relevant changelog is here:
https://github.com/bufbuild/buf/blob/main/CHANGELOG.md
We did release some big improvements to the Buf CLI recently, but we took many steps to ensure backward compatibility. If you are having compatibility issues, please report them in https://github.com/bufbuild/buf and we can investigate.
Going to close this issue since we don't plan on having a separate CHANGELOG for this action.

Good to know. My suggestion is then to copy the changelog of buf cli into the buf action release


Follow reverse dependency order while uninstalling

Closes #752

@zhilyaev I would need some help in this MR, I am coding for the first time in go.
I need to clarify one doubt, how should the case be handled when there is an error while uninstalling, lets say we have:
1 -> 2 -> 3
if while installing 1->2 came up, but we interrupted the operation before 3 could be installed.
Then while reversing, although 2 depends on 3 to be uninstalled but since it doesn't exist 2 & 1 will also not be uninstalled.
While installing it might be okay to have a partial graph built, because we can replay it and move it to forward state. But while bringing things down, we can't expect 3 to come or be present magically now.

I think that is awesome feature! I will be waiting your @r3nic1e approve.

@anuragagarwal561994 That's a cool contribution, thank you. I have just a few tiny comments left
@zhilyaev I think we need to switch workflows from pull_request to pull_request_target so that it would access secrets (like gitleaks token)

@r3nic1e I have commited the suggestion

Hello, my friends @r3nic1e @anuragagarwal561994 any updates? I gonna move this pull request to v0.35.0.

@zhilyaev actually this change is only stuck on one small thing which is discussed above.
https://github.com/helmwave/helmwave/pull/757#discussion_r1378499815
The thing is ideally what @r3nic1e has commented is absolutely correct and it should be done in that way, but when I am doing it this way the code is getting stuck somewhere and I am very very new to this project and even go as a language so I am not being able to give time to find out what is the issue.
I did try to look into it for 1-2 days though, but I think I will need some help, there is something basic that either of us is missing.

Thanks @r3nic1e for finally merging this, I wanted this change to get merged but was not able to work on it :)
But I am super glad that it got merged now


Add dvrip discovery

The first ever thing I do in Go so I'm expecting to have to make some changes after your feedback.
I reverse engineered the discovery protocol with Wireshark and my 3 cameras, hence the magic hex stream  broadcasted and the discarded first 20 bytes of the responses.

Tested on 3 ICSee cameras.

I confirmed that the single broadcasted "magic hex code" is enough. I did that by analysing network traffic from two mobile apps (ICSee and XMEye Pro) and one desktop app (VMS), they all send only that message when they try to find cams in the network.

Alright I'll retest it tonight

I just tested it and can confirm it does still work after your refactoring work. Thanks for taking this in!

If at some point you want to reduce the code further, I just realised that one could forego the hexToDecimalBytes function and just take the IP from the inbound UDP connection.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.6.0


wasm: fix root_context_id that was incorrectly cached across threads. (#15016)

Fixes proxy-wasm/proxy-wasm-cpp-host#125.
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

Was this PR replaced by https://github.com/envoyproxy/envoy/pull/15016#event-4343028059 and therefore doesn't require deps approval?

Was this PR replaced by #15016 (comment) and therefore doesn't require deps approval?

No, this is a backport of #15016 to release/v1.17 branch, and it looks that it needs an approval from @envoyproxy/dependency-shepherds.

/lgtm deps


Removes not used constants

These appear to be used? See for example __CFDataBytesInline, which uses __CFRuntimeGetFlag/__CFRuntimeGetValue.

I don't see removed constants to be used.
CFData.c has similar declarations and uses them.
Swift don't.
If C and Swift versions should have all constants in sync, even not used, Swift then should have     __kCFNeedsZero = 6 which C has.
Another difference. In Swift we have:
private let __kCFMutable: CFOptionFlags = 0x01
private let __kCFGrowable: CFOptionFlags = 0x02

When in C we have following, which is not semantically the same.
    __kCFMutable = 0,
    __kCFGrowable = 1,

But we have in C these as well:
enum {
    __kCFMutableMask = 0x01,
    __kCFGrowableMask = 0x02,
};

Which could mean constants in Swift named wrongly, naming convention doesn't match one in C code.

In general, due to the way we process the code to make it available, I would rather extraneous declarations be kept.


Add uri and host credentials

It can be useful for auto-configuration in app to have the full bucket s3 uri in credentials.
Actually, it assumes that users will only use s3 bucket from aws but users could also want to move to another s3 compatible broker like p-riakcs.
This PR intends to uniform all s3 bucket to make auto-configuration easier.
This current broker is not eligible to the s3 spring boot connectors because there is no uri or/and no host set in credentials.
I think it's a good thing to always have an uri credential when it's possible in service broker mainly to uniform auto-configuration.

Good idea.

I don't think there is an active maintainer for this project. Going to merge.

@drnic yep, thank you


Fix repository url

What was a problem
The repository path is incorrect due to the effect of migrating the repository to the ts-graphviz organization.
How this PR fixes the problem
Corrected to the correct path.
Check lists (check x in [ ] of list items)

[x] Test passed
[x] Coding style (indentation, etc)

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


Wrong Roll for Iniciative

The iniciative macro is rolling a Dex+AlertD6, the correct roll should be a 1d6+Dex+Alert.

If you roll directly from the sheet it occurs, but if roll adding the pokemon on the encounter table and rolling from there works fine.

Reopening this since I feel like this should be changed to the same formula on the sheet as well to make it less confusing


add validator to update kubeconfig

Summary
Update kubeconfig before all kube commands, crd and helm install

Labels

Test Plan

Checklist

[ ] If required, I have updated the Plural documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have added a meaningful title and summary to convey the impact of this PR to a user.
[ ] I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino PTAL


Create .dockerignore file for all languages

From @trisberg on February 18, 2018 2:59
Currently we generate one for node, and the samples have one
Copied from original issue: projectriff/riff-cli#42

stale


caches: tweak the Windows toolchain build

Update the toolchain configuration to disable the python home embedding.
This should allow us to be more freestanding of the python location and
give us better control of the python library being used.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @JDevlieghere

@swift-ci please test


abi: cannot use []hexutil.Bytes as type [0]array as argument

I want to execute contract function that requires bytes32[]
I have this array in json:
"proof":["0xdac2beda9cd88c89679f4c41539e8196b29fd38407219841f936f0b6b7e8ff1a","0x22eb93710252e79914d1d4ec15716071ed5fe64b0b0c7e7e1badbce95b386442","0x7d463be3ff9f50f990b008c19834d74bf916fa71b4db3855bd54491b8b07bea7","0xb6577628cd0917349f8d6d059a5f33e8a6b2e2e8e9e95cd005ed7e0981a4a713","0x2b7733395a061fcf4c05a866e05142035f370a4a088969bb560c3761620e57e8","0x5a467b8b8aad5b144e01c349a0a3380ca8ce0829863afa03d99cff8a9b613273","0xe024adad50aa103636a4c42c0fb428c82e154bff3501d84dc5695f70cf32639d","0xc8c9fed8ed870eb1e8462d19a6e107d55c8df05528e81fa9e90af548bf985f30","0x9841222888c5a80644cf54b7d877b85efcd5789e2c2ae8388475f7871f6a1bf7","0x9a046dc08506268e16603452a33ea179b4932eeae59338dd3fee75685cc490f1","0xacba6c0ed0c90792bb6f9f696ad1417efe0032bb0e86b6927234ce419628e24c","0x0d577b40b8956166e4d21cba88b58b32dec0a00b2864e8ed4ac5d7be6683f5f2","0x97aaf35d6ca208a954554f4ab14a1ca973daf13e7c1dad49db82611f4dadf2a3","0xc32355753f5e11ba88adc0d27f10ad32ad4904bfd782c15693c6795b047124fc","0xcd0f927a7dda89206be7ad613644d02a622c3f30f5de40d052b4c3e10ef02a18","0x107e7a23a7abca2aacc0bf854e247569f822013a86927b10f772b7b13fbc8732"]

I unmarshal it into []hexutil.Bytes and when i'm passing this slice into function i get this error:
abi: cannot use []hexutil.Bytes as type [0]array as argument

You should use common.Hash for bytes32. This could use some better documentation and error messages.


[Bug] [Doc] Website dead link checker will failed when add new picture's link

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
When we add a new picture and add a link for it, our dead link checker would fail. see https://github.com/apache/dolphinscheduler-website/pull/594#issuecomment-1001370441 for more detail. I think we should fix this edge case.
What you expected to happen
Should not fail when I add new pic and link
How to reproduce
Add new pic and link
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

remove stale

hey @zhongjiajie i would like to work on this project

Hi @rinkydevi , thanks for your feedback, but we have already fixed this in https://github.com/apache/dolphinscheduler-website/pull/676. you could still find task in #5689 for your first PR to Dolphinscheduler


Autogenerate DITA Docs

This PR adds a GitHub Action to generate the DITA Bootstrap Documentation on push.
Sample runs can be seen here. The result of the current run can be seen here

We should probably use the same bright blue Bootstrap default color scheme in CI as generated by the plug-in's default output, so people know what they'll get out of the box.

Fix cc6a788 .Custom CSS annotated and removed. Result can be seen [here](https://jason-fox.github.io/dita-bootstrap/

🚀 Results deployed to https://infotexture.github.io/dita-bootstrap/.


Allow bitfields to be described in the DDL

Add a way of easily declaring bitfields in the DDL. For example:

https://docs.microsoft.com/en-us/typography/opentype/spec/kern

Not sure how this overlaps with some sort of Erlang-style bit pattern syntax.

Bit pattern implementation in Enigma (an implementation of an Erlang VM in Rust): https://github.com/archseer/enigma/blob/b69c4a361dda1779ebed9280fb0919776abc3e9b/enigma/src/bitstring.rs


bug: Duplicate notifications sent

Describe the bug
Argus keep re-notifying Slack about new releases. Happens multiple time per day without a clear pattern.
Seems to have started when we upgraded from 0.11.1 to 0.15.0.
To Reproduce
It seems relevant only when we are 2 releases behind the Github repo.
Steps to reproduce the behavior:

Monitor a Github repository with 2 releases more than what is currently deployed.
Observe duplicate notifications sent multiple times per day

Expected behavior
Expected behaviour would be to get one notification and only when new release is created on Github.
Screenshots

Additional context
Relevant logs:

Hmm, I'd guess that this is related to your 10s interval between queries.
I think something like this happened

Latest release - 1.25.0 (already notified)
Something changes in the release such that the API returns 1.24.0 as the latest version (maybe it was set to pre release for <20 seconds?), so it notifies as that's a different version
1.25.0 set as latest on GitHub, so Argus finds that change and notifies on it

It's probably unlikely that both those repos had the latest version toggled to prerelease for <20 seconds. Could it be a problem with GitHub's API if you are querying the same repos so frequently?
I'll set one of these repos up 2+ versions behind and see if I can reproduce

I doubt the pre-release theory as this happens to numerous repos with 2+ releases but increasing the query interval to 1 hour makes much sense to me.
Looking forward to see what you discover @JosephKav

Changed the check interval to 1 hour yesterday - so far no more double notifications.
Actually no more notifications at all since there have been no new releases.
Let's keep this one open a bit more - just until we get at least one new release (shouldn't take long) to confirm the issue is solved.

Jan 17 12:59:33 ansible Argus[22091]: VERBOSE: NethermindETH/Nethermind, Potentially found new releases (new ETag "12e9e940718b55548634b62f62c6dc5a3aeb3a3b19ce941f73a2e28b876df018")
^ Query that returns 1.25.1

Jan 17 13:00:05 ansible Argus[22091]: VERBOSE: NethermindETH/Nethermind, Potentially found new releases (new ETag "ce1c299b3d00590474883cfa8e76d94b8f56cc52ec85b1a6af85d17be2a0193e")
^ New ETag
Jan 17 13:00:06 ansible Argus[22091]: VERBOSE: NethermindETH/Nethermind, Possibly found a new version (From "1.25.1" to "1.25.0"). Checking again
^ That ETag had a different version as latest (was missing 1.25.1)

Jan 17 13:00:07 ansible Argus[22091]: VERBOSE: NethermindETH/Nethermind, Potentially found new releases (new ETag "12e9e940718b55548634b62f62c6dc5a3aeb3a3b19ce941f73a2e28b876df018")
^ Recheck gets that original ETag
Jan 17 13:00:07 ansible Argus[22091]: VERBOSE: NethermindETH/Nethermind, Staying on "1.25.1", second check
^ Which has 1.25.1 as latest

This looks like an issue with GitHub's API. I'll just PR this double check when it notices a version change to prevent these duplicate notifications


bootstrap added

a simple change to the UI. added bootstrap.

Thanks for the PR! But the objective of this website is to be able to stick to vanilla web technologies (no external dependencies) as much as possible to advance our knowledge. So, I am afraid we can not agree to merge this PR.
cc @rameshsyn @anarchyrucks

Thanks @jenish1231  bro,  As @abs-zero  said, our objective is to challenge ourself by leveraging vanilla techs to solve problems.
To keep thing simple and consistent we will use vanilla techs at least for this project. If you have any project idea, you can share at our discord server. :)

I agree with @rameshsyn and @abs-zero


Figure 9 Experiments code

Is there any code for the experiment on figure 9 of the paper?
I want to compare three models in Figure 9.

Hello,
For figure 9 we use to odeint function implemented in tochdiffeq:
https://github.com/rtqichen/torchdiffeq
You can reproduce the experiment by modifying the ODE so that it is a second order one.


Repo sync for protected CLA branch

The pull request is created from master637463334886563749 to master to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fix issues in Messaging GHA yml file

Fix build breakage. I'm not sure how/why this worked in #5358
#no-changelog

I think messaging build wasn't triggered in #5358, which is why this error isn't shown.


Upgrade JupyterHub to 5.0.0b2

Reference Issues or PRs

follow-up to https://github.com/nebari-dev/nebari-docker-images/pull/140
https://github.com/nebari-dev/nebari/issues/2330
sibling to https://github.com/nebari-dev/nebari/pull/2468

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Looks good, there are some conflicts though.


Use ref instead of className to pinpoint the DOM element

Refs is the correct way to have a React component access a child DOM element. https://reactjs.org/docs/refs-and-the-dom.html
The current code uses a classname, which results in every call to the Plyr library, initialises the every video on the page. That causes issues when having multiple videos on the page.
The attached pull request fixes this issue, by using the official way to access the DOM element and feeding the actual DOM element to Plyr instead of a CSS selector.

good point @rolfvandekrol,
thanks for teh PR,

sorry for the delay @rolfvandekrol, I have been busy now is merged, I would like to release the new version with some fixes also


[zh] Tweak admission controller page

This PR updates the line wrapping of the admission-controllers page and fixes some nits found in the existing translation.

/lgtm

Thanks for all the hard work and fixing our nitpicks.
I think @TinySong and I are both satisfied with all changes!
/lgtm
BTW, @TinySong maybe you can take a look at applying for the membership. 🙃

Thanks for all the hard work and fixing our nitpicks. I think @TinySong and I are both satisfied with all changes! /lgtm
BTW, @TinySong maybe you can take a look at applying for the membership. 🙃

yeah, I am willing to be a Kubernetes member,  @tengqm @Sea-n are you willing to be my sponsors? 😄

/approve
/lgtm


Update MicroProfile IO website

Looks like the MicroProfile website is not up to date.
https://microprofile.io/project/eclipse/microprofile-health
It still mentions for instance @Health which is now deprecated.

the readme also mentions @health.


feat: pin input mask option

I'm only wondering if default values are set than the mask is immediately shown. Then again I don't think it's logical to use default values and mask together?
Fixes #493

With regards to your two suggestions:

using a string vs boolean
the disconnect with the input field in the hidden input fields for form submission

What I did now what set the input to type password when masked === true, which will result in the browser default behavior for masking. I fixed the disconnect between the input and hiddenInput. I've been thinking on how to use a string instead for the mask like you suggested, but I don't know how that should be implemented, probably it will add some complexity and don't know if it's really worth it. What do you think? Overriding the password symbol used by the browser doesn't seem possible.

@0xHati Hmm. In that case, I'd say the mask prop is not necessary. We can narrow the type prop's type to be 'text' | 'password', instead of string, and document this password behaviour. Wdyt?

Updated to your suggestion, I think removing the prop is ok. It's a choice between being more explicit or not, but with the docs it should be clear how to achieve a masked pin input.


D3Net Music Source Separation pretrained model not downloadable

The link to the pretrained weights seems to be dead: https://nnabla.org/pretrained-models/ai-research-code/d3net/mss/d3net-mss.zip

The URL should be https://nnabla.org/pretrained-models/ai-research-code/d3net/mss/d3net-mss.h5.

Let me close due to already resolved.


typed

how can I set my value instead of default value in typed. js .
it show these are default. i have to change mine. _

👋 Hi there -- we don't provide support here for using libraries. These issues should be used for issues within tutorials that cdnjs has. You will need to use support channels that exist for a specific library if you have an issue with that library.


BIGTOP-1888. Upgrade Flume to 1.6.0

Looks like there are some kite changes in here? Maybe accidental?

Jay, Kite in the Bigtop stack!
https://issues.apache.org/jira/browse/BIGTOP-1149

Ah ok so flume is reading a kite version.  That makes sense. +1

Thanks Jay for reviewing the patch! I'll commit it shortly.


fix: change TTL=0 for Fingerprint integration cache policy

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

v1.2.0
GitHub release

Your semantic-release bot :package::rocket:


Trident Installer not working on macOS

Hi,
I am unable to deploy Trident to my Kubernetes cluster
Specs:

macOS 10.12.5
Kubernetes v1.6.4
trident-installer-17.07.1

I see the following issues with the install command:

namespace argument is ignored
sed not working correctly
errors don't get handled
no pod gets deployed
grep not working correctly (uninstall)

install output:
./install_trident.sh -n kube-system
Installer assumes you have deployed Kubernetes. If this is an OpenShift deployment, make sure 'oc' is in the $PATH.
You are running in namespace default.
Trident will be deployed in namespace default.
For maximum security, we recommend running Trident in its own namespace: ./install_trident.sh -n trident
serviceaccount "trident" created
serviceaccount "trident-launcher" created
clusterrole "trident" created
clusterrole "trident-launcher" created
clusterrolebinding "trident" created
clusterrolebinding "trident-launcher" created
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: 1: "/Users/andi/1_repositor ...": command a expects \ followed by text
configmap "trident-launcher-config" created
pod "trident-launcher" created
Trident deployment definition is available in /Users/andi/1_repository/psp/trident-installer/setup/trident-deployment.yaml.
Started launcher in namespace "default".

uninstall output:
./uninstall_trident.sh
Installer assumes you have deployed Kubernetes. If this is an OpenShift deployment, make sure 'oc' is in the $PATH.
You are running in namespace default.
Cleanup will take place in namespace default.
usage: grep [-abcDEFGHhIiJLlmnOoqRSsUVvwxZ] [-A num] [-B num] [-C[num]]
	[-e pattern] [-f file] [--binary-files=value] [--color=when]
	[--context[=num]] [--directories=action] [--label] [--line-buffered]
	[--null] [pattern] [file ...]
pod "trident-launcher" deleted
clusterrolebinding "trident" deleted
clusterrolebinding "trident-launcher" deleted
clusterrole "trident" deleted
clusterrole "trident-launcher" deleted
serviceaccount "trident" deleted
serviceaccount "trident-launcher" deleted
configmap "trident-launcher-config" deleted
This script didn't delete namespace "default" and PVC and PV "trident" in case they're going to be reused. Please use the -a option if you need PVC and PV "trident" deleted.
Successfully deleted Trident deployment, service accounts, and cluster roles and role bindings.
Successfully deleted Trident launcher pod and configuration.

I believe the user utilities in MacOS are BSD based while the ones in Linux are GNU based.  Likely the utilities called by the installer use options that only exist in the GNU ones.  I run (gasp!) Windows 10 on my desktop and use kubectl from it for some tasks, but to run the Trident installer I jump on a k8s cluster node that has kubectl installed.
Since Trident users must have a linux box (k8s requirement) I'd suggest a doc update to specify the installer must be run from linux.  If MacOS (or windows) support for the installer is needed then it needs some updates.  If you're up for it I know the team welcomes PRs :-)

@dutchiechris I agree with you. A simple entry in the requirements could be a quick fix. At least for me because I prefer a custom deployment without the installer.
On the other hand, not every admin/engineer has a dedicated linux box with kubectl installed or wants to change the state of a production server while pulling some scripts on it.

Hello
i get error unable to recognize . i have K8S 1.7 release and trident 17.07.1 "/Users/i811144/rushi/devops/kubernetes/sapinternalprojects/saplama-lvm/virtual-colo-cluster/storageclass/trident-installer/trident-clusterrolebindings-openshift.yaml": no matches for /, Kind=ClusterRoleBinding
here is my install step.
./install_trident.sh -n trident
Installer assumes you have deployed OpenShift.
You are running in namespace default.
Trident will be deployed in namespace default.
For maximum security, we recommend running Trident in its own namespace: ./install_trident.sh -n trident
unable to recognize "/Users/i811144/rushi/devops/kubernetes/sapinternalprojects/saplama-lvm/virtual-colo-cluster/storageclass/trident-installer/trident-clusterrolebindings-openshift.yaml": no matches for /, Kind=ClusterRoleBinding


fix: update bot naming rules

Description
do not allow using dot in bot's dialog and trigger name.
Task Item
Closes #3185
Screenshots

LGTM, but I agree this could use some simple unit tests.

test cases added

@liweitian  please address conflicts

Coverage increased (+0.7%) to 42.715% when pulling 80204a88dd2c47bd5e0ebc91666db9b86d238d14 on liweitian:validateBotName into 7ade7ca369bc719cbfe3456c436bfa07eddb2989 on microsoft:master.


bug: UI Diagnostics causes error in C# file when re-enabled.

Did you check docs and existing issues?

[x] I have read all the LazyVim docs
[x] I have searched the existing issues of LazyVim
[ ] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.1
Operating system/version
macOS 13.4 M1
Describe the bug
After enabling "Toggle Diagnostics" back using the following key shortcuts:

space + u + d

I get the following error:
E5108: Error executing lua: ...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1031: Invalid 'line': out of range stack traceback: 	[C]: in function 'nvim_buf_set_extmark' 	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1031: in function 'show' 	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1223: in function 'show' 	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1179: in function 'show' 	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1173: in function 'show' 	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1595: in function 'enable' 	....local/share/nvim/lazy/LazyVim/lua/lazyvim/util/init.lua:207: in function <....local/share/nvim/lazy/LazyVim/lua/lazyvim/util/init.lua:204>
This is a fresh clone of nvim from Installation page:
https://www.lazyvim.org/installation
Steps To Reproduce

Clone the starter template from instructions here
Open a C# file with nvim
Disable UI Diagnostics (space + u + d)
Enable UI Diagnostics back (space + u + d)
Notice the error

E5108: Error executing lua: ...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1031: Invalid 'line': out of range
stack traceback:
	[C]: in function 'nvim_buf_set_extmark'
	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1031: in function 'show'
	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1223: in function 'show'
	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1179: in function 'show'
	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1173: in function 'show'
	...r/neovim/0.9.1/share/nvim/runtime/lua/vim/diagnostic.lua:1595: in function 'enable'
	....local/share/nvim/lazy/LazyVim/lua/lazyvim/util/init.lua:207: in function <....local/share/nvim/lazy/LazyVim/lua/lazyvim/util/init.lua:204>

Expected Behavior
To toggle UI Diagnostic back and forth without seeing errors.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Hello @ramfattah,
I don't think this is a bug in LazyVim.
The toggle only calls vim.diagnostic.enable() or vim.diagnostic.disable()
I cannot reproduce the issue using the provided steps. There are no diagnostics...)
Which tools need to be installed?
The error happens in neovim's diagnostic.lua:
You could search the issues of neovim's repository for Invalid 'line': out of range
Best regards!

I also couldn't reproduce this on a fresh starter template. Like @abeldekat mentioned, maybe it would be better to make an issue at Neovim's repo.
@ramfattah What happens if instead of the keybinding you use vim.diagnostic.disable() and then vim.diagnostic.enable() (I expect you get the same error)? The keybinding only executes these 2 functions, which have nothing to do with Lazyvim, but rather Neovim itself.

Thanks for the suggestions Team!!
@dpetka2001, surprisingly the UI Diagnostics is working now, not sure what was the issue there intially.


Deployment Fail

I tried to deploy this services on IONOS kubernete. I deployed scripts in overlays/production using kustomize like your guide in Readme.md. All scripts are executed flawlessly and done. When look into the dashboard, some components are failed to run so they are not available. Kibana is also not available.
My server specification is :

xeon 8 cores
20 GB Ram
600 GB hdd
600 GB ssd

Can you provide more details about what is working and what not?

Sorry, I already abandon the project, and I didn't make a documentation so I will close this issue. Thank you for the script.


Remove duplicates

Removed additional "in the" form "In the in the Windows Creators Update"

@TylerMSFT : PR passed acceptance checklist. Please approve/merge if appropriate. Thanks!


Bump scrapy-poet

Fixes #91
Not sure if we should make a new release just with this.

There is another thing we need to change here though: https://scrapy-zyte-api.readthedocs.io/en/latest/usage/scrapy-poet.html#default-parameters says "Note that the built-in scrapy_poet.page_input_providers.ItemProvider has a priority of 2000, so when you have page objects producing zyte_common_items.Product items you should use higher values for ZyteApiProvider if you want these items to come from these page objects, and lower values if you want them to come from Zyte API."
Now I think the items will always come from the page objects and if you want to get them directly you need to change the rules?

There is another thing we need to change here though: https://scrapy-zyte-api.readthedocs.io/en/latest/usage/scrapy-poet.html#default-parameters says "Note that the built-in scrapy_poet.page_input_providers.ItemProvider has a priority of 2000, so when you have page objects producing zyte_common_items.Product items you should use higher values for ZyteApiProvider if you want these items to come from these page objects, and lower values if you want them to come from Zyte API."
Now I think the items will always come from the page objects and if you want to get them directly you need to change the rules?

I think to get them directly you should disable the corresponding rule altogether. But honestly, I think the “right” behavior is for items to come from a page object when one exists, so I think we can simply remove that paragraph altogether and not document what to do for the other behavior, at least until we find a real use case for it that we want to support (which might require code changes).


Add RISC V support

This pr add RISC V compilation support for Microsoft TPM2 Simulator.
Tested on Arch Linux : Sophgo Mango : rv64imafdc

/gcbrun


pyatv not found in modules

Hi there,
I have been working on this for awhile now. I am not sure if I will ever even need this to work again after today. However now I am determined to get it working. No matter what way I have tried to look at it or make a needed change the remote will not download the pyatv module when opnened. There is only 2 things logged from right when I downloaded the files and nothing since.
@bsharper I know there was someone else running into this issue. Did you ever find a solution?

@amburns22 What OS are you on?


Update shim dependencies

This PR updates shim dependencies (updates ttrpc to latest versions).
Since TTRPC is now using latest protobuf 3.1, there is some migration work.
Close https://github.com/containerd/rust-extensions/pull/93 https://github.com/containerd/rust-extensions/pull/92 https://github.com/containerd/rust-extensions/pull/91 https://github.com/containerd/rust-extensions/pull/82

So I just found generate_accessors toggle that generated accessors. So I've reverted some code and got rid of these extra Enum imports. Unfortunately this does not make the diff a lot less, because accessors were renamed from get_xyz() to xyz()

ping @Burning1020

Lgtm


Handle containerd upgrade taking a long time

The logic in upgradeconverter can take a long time; one observed case
did not finish in 7 minutes with 10,000 files and 1.5Gbyte to copy from
/persist/containerd to /persist/vault/containerd. That resulted in the
vault not being unlocked in time for the EVE-OS update to succeed. Here
we tell the vault is unlocked before we run the upgrade converter. Other
microservices which will use the vault continue to check for it having
completed.
Plus a separate commit to add logging to be able to see the upgradeconverter progress when moving the files.

Changes look straight forward to me. But for my knowledge why we move files from /persist/containerd to /persist/vault/containerd ?

This was done a while back to ensure that the user's content is always kept encrypted in /persist. As part of that PR the system use (linuxkit uses containerd as well) was moved to a separate instance of containerd which is using /persist/containerd-system-root/
Thus this movement only happens once on an upgrade of EVE-OS.

Ok got it thanks.


axios should not throw on valid HTTP responses

Why does axios throw on status < 200 || status >= 300 ? see defaults.js#L84
An HTTP error 500 means we reached the server and even got a valid response using the http protocol.
From an application point of view an HTTP error 500 might be considered an exception, but this is at a different abstraction level and entirely unrelated to the HTTP abstraction.
In order to be forward compatible with the upcoming fetch specification, I think it is important axios would not throw in case of valid HTTP responses.
The fetch specification specifies a response.ok property, so that the application developer can easily identify the result of the HTTP operation, I believe a similar approach could be useful for axios.
Please see here for more details on the fetch spec:
https://fetch.spec.whatwg.org/#dom-response-ok
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

I think you can use validateStatus config option to always resolve when there is a server response. from the docs:
// `validateStatus` defines whether to resolve or reject the promise for a given
// HTTP response status code. If `validateStatus` returns `true` (or is set to `null`
// or `undefined`), the promise will be resolved; otherwise, the promise will be
// rejected.
validateStatus: function (status) {
  return status >= 200 && status < 300; // default
}

Correct, but my point is that this shouldn't be the default. In fact this shouldn't even be configurable.

We understand your concern but Axios doesn't mean to replace fetch nor mimic its behaviour. We don't even use it as an adapter to make the calls (we stick to XHR for the moment).
Axios tries to be as configurable as possible providing the defaults that most people with use. In this case people tend to verify the status code right after a response from the server. E.g.:
fetch(url).then(verifyStatus).then(...);

We want to avoid that structure that repeats a lot. If you want to resolve whenever you receive a valid response from the server you can always set validateStatus: false.


protobuf:x86-windows

I am trying to install protobuf for windows,
I had set my HTTP_PROXY, and HTTPS_PROXY but still have error:
vcpkg install protobuf protobuf:x64-windows
The following packages will be built and installed:
protobuf[core]:x86-windows
protobuf[core]:x64-windows
Starting package 1/2: protobuf:x86-windows
Building package protobuf[core]:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/Users/a257885/tmp/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/Users/a257885/tmp/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/Users/a257885/tmp/vcpkg/packages/protobuf_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/Users/a257885/tmp/vcpkg/buildtrees/protobuf
-- CURRENT_PORT_DIR=C:/Users/a257885/tmp/vcpkg/ports/protobuf/.
-- Downloading https://github.com/google/protobuf/releases/download/v3.5.1/proto
buf-cpp-3.5.1.tar.gz...
-- Downloading https://github.com/google/protobuf/releases/download/v3.5.1/proto
buf-cpp-3.5.1.tar.gz... Failed. Status: 4;"A requested feature, protocol or opti
on was not found built-in in this libcurl due to a build-time decision."
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:155 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/is

sues
Call Stack (most recent call first):
ports/protobuf/portfile.cmake:6 (vcpkg_download_distfile)
scripts/ports.cmake:72 (include)

C:\Users\a257885\tmp\vcpkg>set HTTP_PROXY
HTTP_PROXY=http://myuser:mypass...@ourproxyserver:8080/
HTTPS_PROXY=https://myuser:mypass...@ourproxyserver:8080/
C:\Users\a257885\tmp\vcpkg>vcpkg update
Using local portfile versions. To update the local portfiles, use git pull.
No packages need updating.
C:\Users\a257885\tmp\vcpkg>git pull
fatal: UriFormatException encountered.
actualUrl
Already up to date.

Hi @bidekani , thanks for reporting this issue!
Please open a new issue if this is still a problem for you.
Thx.

Hello,
Where do we add the HTTP_PROXY and  HTTPS_PROXY variables to which files?

@dkford6704 Just set them in  you console.

Hello @JackBoosY,
Where is the console?

@dkford6704 you can use command to set it. Example:
set http_proxy=http://localhost:1080
set http_proxy_user=user
set http_proxy_pass=pwd

Nope, could not get it working still

@dkford6704 Please download the source package manually and put it into VCPKG_PATH/downloads and rebuild protobuf.
Thanks.


Make it a python package

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Added editor dialog for easily creating shaders.

Added a dialog similar to GDScript but for the shaders instead.

Language options is to select between Shader and VisualShader.
Mode options are Spatial,CanvasItem,Particles and Sky.
Template options may be Default (which adds some code for functions) and Empty (shader_mode is defined only).

Demo GIF

This will helps new users to better engage with the shaders + it speeds up the creation of shaders by allowing adding some template code afterward.
Bugsquad edit: Closes #20152

There should be an option for built-in shaders.

In the long run, we may want to rename the Shader resource to TextShader to distinguish it from visual shaders. Right now, it's not obvious from the name alone that Shader is for text-based shaders.

@KoBeWi Done

This warning seems to be permanently in the dialog:

It's irrelevant to shaders.

This warning seems to be permanently in the dialog:
It's irrelevant to shaders.

I've removed it in the last commit. Check again.

Removed almost all comments outside the constructor. ^^

Looks great now!
The last thing to fix is the file path in the dialog:
	if (path == "") {
		String root_path = editor_data->get_edited_scene_root()->get_filename();
		if (root_path == "") {
			path = String("res://").plus_file(selected_shader_material->get_name());
		} else {
			path = root_path.get_base_dir().plus_file(selected_shader_material->get_name());
		}
	}

Using selected_shader_material->get_name() exclusively is not a good idea, because the material is unnamed in most cases. If the name doesn't exist, it should fallback to scene name.
Also editor_data->get_edited_scene_root() might return null if the resource was created in the inspector and no scene is open. It's rare, but leads to editor crash, so you should check first if a scene exists before getting filename.

@KoBeWi Well, I think I'm done with it, check again.

Ok, let this be, hope users would like it as I did :smiley:


(PDB-3300) Add admin delete node command

This command allows for the immediate deletion of all data associated with the
certname in the command payload.

In the scf/storage.clj file (not part of this PR), we may want to extend delete-certname! to delete the appropriate reports and resource-events also. Right now, that's going to depend on cascades, but that's not as efficient as something like (note this is written off the top of my head, may not be correct as far as column names):
DELETE FROM resource_events WHERE report_id IN (SELECT id FROM reports WHERE certname = 'foo');
DELETE FROM FROM reports WHERE certname = 'foo';

👍 makes sense @robdaemon, I'll take a look

CLA signed by all contributors.


Issue apply regex warning on sync

About this change - What it does
This change applies a warning when the TopicNames are not adhering correctly to the standards set out in the environment that it is being synchronized to.
Why this way
This follows a pattern of allowing the admin to ultimately override the configured Env but also warning them of that in the process.

Example User exp

Warning on Save

Bulk Messages


fix: tools workflow file changed

Description
This PR describes the change of node version being used for updating the tools.json. With the present version of Node being used in the GitHub workflows (i.e. v12), it is not possible to run the jobs of tools because of some deprecated dependencies being used there. I have changed the node version of this workflow to v16 so that we don't face any dependencies issue in the workflow run.

@derberg I have tested the workflow file for around 30-40 times and I found that it is working much better and has accurate results in Node v16 than in v12. So, I proposed these changes to reduce the compilation of the wrong results during the workflow run. Right now, as I suspected, the workflow is not running as per the mark. I don't get the reason behind it but it is slightly unusual.

/rtm


Error restoring binary attribute

I have a table with a binary attribute with base64 encoded strings. When I backup with base64binary : true and then restore, I get a different value in the restored table.
If I backup with base64binary : false, the restore fails with an error:
{ InvalidParameterType: Expected params.RequestItems['dev-rental-events'][24].PutRequest.Item['body'].B to be a string, Buffer, Stream, Blob, or typed array object
The json in the backup (without base64binary) looks like:
{"createdAt":{"S":"2017-05-02T09:50:52.322Z"},"stream":{"S":"rental"},"id":{"S":"2017-05-02T09:50:52.317Z0"},"name":{"S":"register"},"body":{"B":{"type":"Buffer","data":[101,121,74,112,90,67,73,54,73,106,73,53,73,105,119,105,90,109,108,121,99,51,82,102,98,109,70]}}}
While the json with base64binary looks like:
{"createdAt":{"S":"2017-05-02T09:51:19.258Z"},"stream":{"S":"rental"},"id":{"S":"2017-05-02T09:51:19.257Z2"},"name":{"S":"lock-applicant"},"body":{"B":"ZXlKaGNIQnNhV05oYm5RaU9pSXlPU0lzSW1KeWIydGxjaUk2SWtGa1lXMGlMQ0owYVcxbGMzUmhiWEFpT2lJeU1ERTNMVEExTFRBeVZEQTVPalV4T2pFNUxqSTFOMW9pZlE9PQ=="}}
Note that the string value of the body above is the exact same string I see in the dynamodb ui.

worth noting, my app base64 encodes some stringified json and stores the result with a binary attribute. Probably really bad design but nonetheless, taking a backup and then restoring should result in identical tables


Regex rewrite redirect

Add regex rewrites for redirects.
I had to do something sort of odd with the lifecycle of the returned rewrite string but it works for now.

Sorry, did not mean to open this upstream just yet.


Force gzip to overwrite existing archives in docker.save target

Please provide a description of this PR:
INCLUDE_UNTAGGED_DEFAULT is not implemented for a docker.save and hence default needs to be added at  DOCKER_BUILD_VARIANTS but in this case duplicate ISTIO_DOCKER_TAR are created and gzip needs to force overwrite tars.

/cherrypick release-1.12

@sergii-ssh: new pull request created: #36071

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Admin console tab for Connection Pool monitoring

Requires hoist-core >= v17.2 (https://github.com/xh/hoist-core/pull/307)

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Main goal with this is to get something lightweight out there so we can see what data collected looks like in practice and if it's helpful.  I recognize that the periodic snapshots might not be especially helpful in terms of tracking active connections, assuming that it will be catching pool activity at a pretty random point and it might be difficult to draw any overall conclusions around usage or capacity tuning.  But for an app where there is any reason to focus on connection pool behavior, the snap frequency could be ratcheted way up and hopefully more accurate/useful data would result.
I build snaps of both projects and am deploying a client project to dev with those now to see what I find.  My hope is that it's useful and we then flow any learnings back into these stats to better describe them, drop uninteresting ones, add others to the chart in a way that makes them useful, etc. - once we know what they actually look like.


remove clipboard as a dependency

we no longer need the "add to clipboard" functionality so we might as well nuke it.

Did they requested to drop that functionality?
@marnovo could you confirm it?

According to the design document it's a link with a mailto, not a button with a copy to clipboard anymore.

Done @Serabe. Can we remove either yarn.lock or package-lock.json?  I, for example, don't have npm5 installed and maintaining the package-lock.json by hand is tedious.


Remove MessageDetails::Bypass

From what I can see it is only created in redis/sink_cluster.rs and I cant see any reason we would want to bypass something here.
Would appreciate a thorough review to make sure i'm not missing anything here.

@benbromhead What was the intention of ByPass?

a few weeks ago on slack he said:

I dont see any remains of that previous functionality.