12.nlp-with-luis will not start

Error:
BotBuilder-Samples\samples\javascript_nodejs\12.nlp-with-luis\index.js:51
endpoint: luisConfig.getEndpoint()                         ^
TypeError: luisConfig.getEndpoint is not a function
Solution:
const { BotConfiguration } = require('botframework-config');
...
const luisConfig = botConfig.findServiceByNameOrId(LUIS_CONFIGURATION);
// luisConfig must be cast to LuisService)
should be:
const { BotConfiguration, LuisService } = require('botframework-config');
...
const luisConfig = new LuisService(botConfig.findServiceByNameOrId(LUIS_CONFIGURATION));
Github issues for C# /JS / Java/ Python should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Sample information

Sample type: [\samples\ or \solutions]
Sample language: [dotnetcore or webapi or es6 or nodejs or typescript]
Sample name:

Describe the bug
Give a clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Give a clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
[bug]

@robert4os Using sample 12.nlp-with-luis in the Node.js samples, I was able to get the bot running just fine with index.js looking like the following:
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

const path = require('path');
const restify = require('restify');
const { BotFrameworkAdapter } = require('botbuilder');
const { BotConfiguration } = require('botframework-config');
const { LuisBot } = require('./bot');

// Read botFilePath and botFileSecret from .env file.
// Note: Ensure you have a .env file and include botFilePath and botFileSecret.
const ENV_FILE = path.join(__dirname, '.env');
require('dotenv').config({ path: ENV_FILE });

// .bot file path.
const BOT_FILE = path.join(__dirname, (process.env.botFilePath || ''));
let botConfig;
try {
    // Read configuration from .bot file.
    botConfig = BotConfiguration.loadSync(BOT_FILE, process.env.botFileSecret);
} catch (err) {
    console.error(`\nError reading bot file. Please ensure you have valid botFilePath and botFileSecret set for your environment.`);
    console.error(`\n - The botFileSecret is available under appsettings for your Azure Bot Service bot.`);
    console.error(`\n - If you are running this bot locally, consider adding a .env file with botFilePath and botFileSecret.\n\n`);
    process.exit();
}

// For local development configuration as defined in .bot file.
const DEV_ENVIRONMENT = 'development';

// Bot name as defined in .bot file or from runtime.
// See https://aka.ms/about-bot-file to learn more about .bot files.
const BOT_CONFIGURATION = (process.env.NODE_ENV || DEV_ENVIRONMENT);

// Language Understanding (LUIS) service name as defined in the .bot file.
const LUIS_CONFIGURATION = 'Reminders';

if (!LUIS_CONFIGURATION) {
    console.error('Make sure to update the index.js file with a LUIS_CONFIGURATION name that matches your .bot file.');
    process.exit();
}

// Get endpoint and LUIS configurations by service name.
const endpointConfig = botConfig.findServiceByNameOrId(BOT_CONFIGURATION);
const luisConfig = botConfig.findServiceByNameOrId(LUIS_CONFIGURATION);

// Map the contents to the required format for `LuisRecognizer`.
const luisApplication = {
    applicationId: luisConfig.appId,
    endpointKey: luisConfig.subscriptionKey || luisConfig.authoringKey,
    endpoint: luisConfig.getEndpoint()
};

// Create configuration for LuisRecognizer's runtime behavior.
const luisPredictionOptions = {
    includeAllIntents: true,
    log: true,
    staging: false
};

// Create adapter. See https://aka.ms/about-bot-adapter to learn more about adapters.
const adapter = new BotFrameworkAdapter({
    appId: endpointConfig.appId || process.env.MicrosoftAppId,
    appPassword: endpointConfig.appPassword || process.env.MicrosoftAppPassword
});

// Catch-all for errors.
adapter.onTurnError = async (turnContext, error) => {
    console.error(`\n [onTurnError]: ${ error }`);
    await turnContext.sendActivity(`Oops. Something went wrong!`);
};

// Create the LuisBot.
let bot;
try {
    bot = new LuisBot(luisApplication, luisPredictionOptions);
} catch (err) {
    console.error(`[botInitializationError]: ${ err }`);
    process.exit();
}

// Create HTTP server.
let server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function() {
    console.log(`\n${ server.name } listening to ${ server.url }.`);
    console.log(`\nGet Bot Framework Emulator: https://aka.ms/botframework-emulator.`);
    console.log(`\nTo talk to your bot, open nlp-with-luis.bot file in the emulator.`);
});

// Listen for incoming requests.
server.post('/api/messages', (req, res) => {
    adapter.processActivity(req, res, async (turnContext) => {
        await bot.onTurn(turnContext);
    });
});

Note that the code is largely unedited from that given in the template.

Things to remember to run samples:

be sure to remember to create a .bot file (you can use various methods including cloning, using msbot init and then msbot connect luis... commands, or creating the .bot file manually)

Structure of .bot file
{
    "name": "nlp-with-luis",
    "description": "",
    "services": [
        {
            "type": "endpoint",
            "name": "development",
            "endpoint": "http://localhost:3978/api/messages",
            "appId": "",
            "appPassword": "",
            "id": "24"
        },
        {
            "type": "luis",
            "name": "Reminders",
            "appId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
            "version": "0.1",
            "authoringKey": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
            "region": "westus",
            "id": "134"
        }
    ],
    "padlock": "",
    "version": "2.0"
}

make sure to change LUIS_CONFIGURATION's value to be the name of your LUIS app in index.js file. I changed it to 'Reminders', matching the luis service in my .bot file.

be sure that the name of your .bot file matches the botFilePath in .env

Thanks, you are right. It must have been an incomplete/invalid bot file:
the service name was correct but not the service type.
Am Mo., 5. Nov. 2018, 21:01 hat Ashley Ho<EMAIL_ADDRESS>geschrieben:

@robert4os https://github.com/robert4os Using sample 12.nlp-with-luis
in the Node.js samples, I was able to get the bot running just fine with
index.js looking like the following:
// Copyright (c) Microsoft Corporation. All rights reserved.// Licensed under the MIT License.
const path = require('path');const restify = require('restify');const { BotFrameworkAdapter } = require('botbuilder');const { BotConfiguration } = require('botframework-config');const { LuisBot } = require('./bot');
// Read botFilePath and botFileSecret from .env file.// Note: Ensure you have a .env file and include botFilePath and botFileSecret.const ENV_FILE = path.join(__dirname, '.env');require('dotenv').config({ path: ENV_FILE });
// .bot file path.const BOT_FILE = path.join(__dirname, (process.env.botFilePath || ''));let botConfig;try {
// Read configuration from .bot file.
botConfig = BotConfiguration.loadSync(BOT_FILE, process.env.botFileSecret);
} catch (err) {
console.error(\nError reading bot file. Please ensure you have valid botFilePath and botFileSecret set for your environment.);
console.error(\n - The botFileSecret is available under appsettings for your Azure Bot Service bot.);
console.error(\n - If you are running this bot locally, consider adding a .env file with botFilePath and botFileSecret.\n\n);
process.exit();
}
// For local development configuration as defined in .bot file.const DEV_ENVIRONMENT = 'development';
// Bot name as defined in .bot file or from runtime.// See https://aka.ms/about-bot-file to learn more about .bot files.const BOT_CONFIGURATION = (process.env.NODE_ENV || DEV_ENVIRONMENT);
// Language Understanding (LUIS) service name as defined in the .bot file.const LUIS_CONFIGURATION = 'Reminders';
if (!LUIS_CONFIGURATION) {
console.error('Make sure to update the index.js file with a LUIS_CONFIGURATION name that matches your .bot file.');
process.exit();
}
// Get endpoint and LUIS configurations by service name.const endpointConfig = botConfig.findServiceByNameOrId(BOT_CONFIGURATION);const luisConfig = botConfig.findServiceByNameOrId(LUIS_CONFIGURATION);
// Map the contents to the required format for LuisRecognizer.const luisApplication = {
applicationId: luisConfig.appId,
endpointKey: luisConfig.subscriptionKey || luisConfig.authoringKey,
endpoint: luisConfig.getEndpoint()
};
// Create configuration for LuisRecognizer's runtime behavior.const luisPredictionOptions = {
includeAllIntents: true,
log: true,
staging: false
};
// Create adapter. See https://aka.ms/about-bot-adapter to learn more about adapters.const adapter = new BotFrameworkAdapter({
appId: endpointConfig.appId || process.env.MicrosoftAppId,
appPassword: endpointConfig.appPassword || process.env.MicrosoftAppPassword
});
// Catch-all for errors.adapter.onTurnError = async (turnContext, error) => {
console.error(\n [onTurnError]: ${ error });
await turnContext.sendActivity(Oops. Something went wrong!);
};
// Create the LuisBot.let bot;try {
bot = new LuisBot(luisApplication, luisPredictionOptions);
} catch (err) {
console.error([botInitializationError]: ${ err });
process.exit();
}
// Create HTTP server.let server = restify.createServer();server.listen(process.env.port || process.env.PORT || 3978, function() {
console.log(\n${ server.name } listening to ${ server.url }.);
console.log(\nGet Bot Framework Emulator: https://aka.ms/botframework-emulator.);
console.log(\nTo talk to your bot, open nlp-with-luis.bot file in the emulator.);
});
// Listen for incoming requests.server.post('/api/messages', (req, res) => {
adapter.processActivity(req, res, async (turnContext) => {
await bot.onTurn(turnContext);
});
});
Note that the code is largely unedited from that given in the template.
Things to remember to run samples:

be sure to remember to create a .bot file (you can use various
methods including cloning, using msbot init and then msbot connect
luis... commands, or creating the .bot file manually)

Structure of .bot file
{
"name": "nlp-with-luis",
"description": "",
"services": [
{
"type": "endpoint",
"name": "development",
"endpoint": "http://localhost:3978/api/messages",
"appId": "",
"appPassword": "",
"id": "24"
},
{
"type": "luis",
"name": "Reminders",
"appId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
"version": "0.1",
"authoringKey": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
"region": "westus",
"id": "134"
}
],
"padlock": "",
"version": "2.0"
}

make sure to change LUIS_CONFIGURATION's value to be the name of your
LUIS app in index.js file. I changed it to 'Reminders', matching the
luis service in my .bot file.
be sure that the name of your .bot file matches the botFilePath in .env
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder-Samples/issues/848#issuecomment-436015031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABl0ymFpj_yoeGA6z0zDHOJWNToaRhqyks5usJj7gaJpZM4YMv_n
.


add more auto backup hours

add 1h, 3h auto-backup options
closes #36

Could you rebase and try again? I need to fix the PR build check for it to work.

Could you rebase and try again? I need to fix the PR build check for it to work.

Sorry... Wdym by rebase? How do I do that exactly?

Could you rebase and try again? I need to fix the PR build check for it to work.

should I rebase it to the default branch or create another one?


Autocompletion is not happening in this special select case

As u can see from the below two pics, the autocompletion is not functioning in that special select case block for the variable res := results{} ONLY (i tested some builtin modules, and some my own modules all works well, so ONLY for that res := results{} variable autocompletion is NOT functioning...)
And actually the select case block is the ONLY place where the variable res := results{} autocompletion is NOT working....
And my code is working well...

There are a few weird cases like this. I'll see if I can get some time to investigate this weekend.

This should be fixed in the next branch. I'll push a new release in a few days.


feat: Added Telefork API key for CLI telemetry

… today

What this PR does / why we need it
We are going to use Telefork for getting CLI telemetry. For that we need the API key we now store in vault. The API key is public, included in our other clients already.

Jira ID
DTSS-1629

Notes for your reviewers

How are people who can't sign into our vault (anyone who isn't an outreach engineer) going to get the token?

How are people who can't sign into our vault (anyone who isn't an outreach engineer) going to get the token?

How do they get the honeycomb key now?

And we're taking a prerequisite on running devconfig before building CLIs now? Is that already a thing? I assume the idea is to compile them in actually - so my first comment doesn't matter as much but still kind of matters

And we're taking a prerequisite on running devconfig before building CLIs now? Is that already a thing? I assume the idea is to compile them in actually - so my first comment doesn't matter as much but still kind of matters

It's exactly the same thing we do with honeycomb now.


Compile source code running Error

Is the current program a current version ?  master branch?
I'm running Prompt error "NotImplementedException"
The model cannot be imported
Then view the source code, found that this is a temporary code
Excuse me, this is the exe version of the source code?

Can anybody help me?


Warning: nr: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

This error occurs when using nextjs 14.0.4:
Warning: nr: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
  at nr (webpack-internal:///(ssr)/./node_modules/react-datepicker/dist/es/index.js:2931:58)
  at a (webpack-internal:///(ssr)/./node_modules/react-datepicker/dist/es/index.js:2959:16)
  at DateRangeInput (webpack-internal:///(ssr)/./src/components/atoms/DateRangeInput.tsx:16:78)
  ...

/duplicate https://github.com/Hacker0x01/react-datepicker/issues/4477

Duplicate of https://github.com/Hacker0x01/react-datepicker/issues/4477


Add public constructors for objects that take IntPtr

This allows integration of WaylandSharp with SDL or GLFW, as they just pass an nint/IntPtr
Closes #3

Does this work for you as intended? I'm not really that acquainted with how graphics/ui work with wayland. (Only written a source generator-based libwayland binding for another project that only needs wayland for inquiring things about the monitors)

Does this work for you as intended? I'm not really that acquainted with how graphics/ui work with wayland. (Only written a source generator-based libwayland binding for another project that only needs wayland for inquiring things about the monitors)

yup, i'm able to construct the objects from an nint passed by GLFW, call functions on them, etc. was able to use it to get another registry and from there aquire objects and listen to events not exposed by glfw, unless there's more nuance i don't know about, this seems to work

Neat! Will merge then, I'm in process of doing some code cleanup and will update the unit tests by then.


SpatiaLite error could suggest --load-extension=spatialite

https://github.com/simonw/datasette/blob/242bc89fdf2e775e340d69a4e851b3a9accb31c6/datasette/cli.py#L533-L548
This could use the find_spatialite() function and, if it finds something, suggest the user use --load-extension=spatialite
https://github.com/simonw/datasette/blob/242bc89fdf2e775e340d69a4e851b3a9accb31c6/datasette/utils/__init__.py#L1015-L1019

$ datasette ../shapefile-to-sqlite/nps-spatialite.db
Usage: datasette serve [OPTIONS] [FILES]...

Error: It looks like you're trying to load a SpatiaLite database without first loading the SpatiaLite module.

Try adding the --load-extension=spatialite option.

Read more: https://docs.datasette.io/en/stable/spatialite.html


Gifs wont downlad as gifs

Hello been trying to save some gifs from a couple gallery's in the app an noticed that they where not saving as gifs but as .jpg images I've even gone into (settings<download<chose original image by defult) didn't seem to change anything

Please provide related gallery url for me to test it.

I've even gone into (settings<download<chose original image by defult) didn't seem to change anything

It's only help you to check the ratio button by default in download dialog, if you don't want to download original image, you count uncheck it in download dialog.

Please provide related gallery url for me to test it.

I've even gone into (settings<download<chose original image by defult) didn't seem to change anything

It's only help you to check the ratio button by default in download dialog, if you don't want to download original image, you could uncheck the ratio button.

Try this https://exhentai.org/g/2377593/2f71e3c3e8/
Alternatively u can just use the (other:"animated$")
tag also what ratio button

Oops closed it by accident

Do you mean Save to Pictures rather than download? I have reproduced it, and it'll be fixed in next version.

Do you mean Save to Pictures rather than download? I have reproduced the problem, and it'll be fixed in next version.

Yes that's what I meant sorry


Cache worker tests

Depends on https://github.com/CraneStation/wasmtime/pull/337.

TODO:

[ ] the tests sometimes fail - fix it

One thing is they are not deterministic and depend on system clock (mtime when writing to the disk), so that's one possible reason - it could be the reason if setting mtime by the system is nondeterministic because of some optimizations.


Updating low res icons with vector icons

Recreated the icons on main page with Inkscape because the icons on main page are low resolution. I didn't update any HTML files.

this adds the files, but is inadequate by itself right?  I meant actually update the images in the html to use the svg, along with some protections like described in https://css-tricks.com/using-svg/

I'll make a PR with updated HTML files ASAP.


Bucketed per-month PRs

New script to calculate pull requests opened and their current status by month.
Returns the raw # of PRs opened, and their resultant state in a table:
Month | #opened | #merged | #rejected | #unresolved |
Note that this means the stats will change over time until all PRs are resolved.
This data can be used to make cool graphs:

@nedbat do you even want to look at this? let me know


Allow required options to come from config file

The code currently checks for required arguments when parsing arguments but before processing the config file, so it is not possible to simply specify the channel, platform or target directory in the config file.

I was wrong about this. I must have just made a mistake with my config file.


Support for jsonld format

Are you planning to support jsonld format?

proper place to to raise this issue would be at

json-refs
swagger2openapi

as thats what we use internally to parse the spec

closing this one as it do not belong here


fix: fix the build dir missing from releases

This was caused by the fact that install (and hence compile)
was not called prior to publishing.  As a result, the build
directory was never created.

PTAL


Edelweiss Shapella Tracker

This issue is to track issues and PRs to prepare for and successfully complete the next Ethereum interop.
Build and run lodestar from source

Node.js v18 recommended and yarn need to be installed, see e.g. npm docs
Clone the lodestar monorepo with git clone https://github.com/chainsafe/lodestar.git
Run yarn && yarn build from the root folder to install dependencies and build
Now the client can be run from from ./lodestar
Run ./lodestar --help for help on the CLI parameters

Interop is over


[bug]401 Unauthorized when installing the Toxic Language validator

Describe the bug
The Toxic Language validator cannot be downloaded without specifying an API key even if we're intending to running it locally only. However, other validators (Secrets Present and Web Sanitization) can be installed correctly. Please find below logs detailing the failure.
#15 [guardrails 10/10] RUN /usr/local/bin/install_validators.sh
#15 0.703 [nltk_data] Downloading package punkt to /root/nltk_data...
#15 1.869 [nltk_data]   Unzipping tokenizers/punkt.zip.
#15 2.700 Installing hub://guardrails/toxic_language...
#15 3.059 ERROR:guardrails-cli:401
#15 3.059 ERROR:guardrails-cli:Unauthorized
#15 3.059 ERROR:guardrails-cli:Your token is invalid. Please run `guardrails configure`to update your token.
#15 3.059 You can find a new token at https://hub.guardrailsai.com/keys
#15 3.060 ERROR:guardrails-cli:
#15 4.164 Installing hub://guardrails/secrets_present...
#15 4.208 Installing hub://guardrails/web_sanitization...
#15 4.660   Running command git clone --filter=blob:none --quiet https://github.com/guardrails-ai/web_sanitization.git /tmp/pip-req-build-4e5mzu8m
#15 4.788   Running command git clone --filter=blob:none --quiet https://github.com/guardrails-ai/secrets_present.git /tmp/pip-req-build-9xd07l8o
#15 7.056 WARNING: typer 0.12.5 does not provide the extra 'all'
#15 7.096 WARNING: typer 0.12.5 does not provide the extra 'all'
#15 7.695 ✅Successfully installed guardrails/secrets_present!
#15 7.695
#15 7.695
#15 7.696 Import validator:
#15 7.696 from guardrails.hub import SecretsPresent
#15 7.696
#15 7.696 Get more info:
#15 7.696 https://hub.guardrailsai.com/validator/guardrails/secrets_present
#15 7.696
#15 7.811 ✅Successfully installed guardrails/web_sanitization!
#15 7.811
#15 7.811
#15 7.811 Import validator:
#15 7.811 from guardrails.hub import WebSanitization
#15 7.811
#15 7.811 Get more info:
#15 7.811 https://hub.guardrailsai.com/validator/guardrails/web_sanitization
#15 7.811
#15 7.960 All guardrails have been successfully installed.

Here's what we're running within a docker step
#!/bin/bash

# Run commands in parallel and capture their PIDs
guardrails hub install hub://guardrails/toxic_language --install-local-models
guardrails hub install hub://guardrails/secrets_present &
pids[0]=$!
guardrails hub install hub://guardrails/web_sanitization &
pids[1]=$!

# Wait for all background processes to complete
for pid in ${pids[*]}; do
    if ! wait $pid; then
        echo "One or more guardrail installations failed."
        exit 1
    fi
done

echo "All guardrails have been successfully installed."

To Reproduce
Run guardrails hub install hub://guardrails/toxic_language or guardrails hub install hub://guardrails/toxic_language --install-local-models without an API key set.
Expected behavior
We should be able to run guardrails hub install hub://guardrails/toxic_language without running into a 401 Unauthorized error. Instead, the error should show up if and only if we attempt to do remote inference without an API key.
Library version:
Tested on:

0.5.1
0.5.10

I'm also receiving the same error for the Restrict to Topic validator on 0.5.10. I thought it was an issue with docker at first, but it's happening if I just run it locally as well.

There's a message on the Discord bulletin board.  I didn't see it on the site, but I feel like it should be copied or moved there.  https://discord.com/channels/1085077079697150023/1263201695228493875/1285686929442213899

Zayd — 09/17/2024 12:40 PM
✏ Update 📄
To provide better user experience and support, we’re rolling out mandatory authentication for installing validators from the guardrails hub.
This has already been rolled out to the ProfanityFree validator, and will be rolled out to the rest by the end of the month.
What you need to change:
Authenticating into guardrails is done by getting a free key from https://guardrailsai.com/keys.
If you’ve logged in to the guardrails hub via your terminal, you’re good to go! If you have not logged in before, run
guardrails configure
For CI/CD workflows, please use a headless login on the same command after getting a key from https://hub.guardrailsai.com/keys.
guardrails configure token [YOUR_TOKEN]
Why is auth now required?
With our new inference endpoints, some of our most popular validators run more quickly and reliably. These inference endpoints require authentication and we think it is a better user experience to require off initially so that these work by default.
We want to better understand our users and how validators are being used together. Requiring validators, and failure/success rates. We still do not collect or log payloads, and there is a way to turn off client-side telemetry through the same configure command. We only collect non-anonymized data regarding validation installations and requests to inference endpoints.
We’ve also had feature requests for private validators and team-scoped guards, and bringing auth in helps prepare for those features.
If you have any questions, please let us know!

I'm also receiving the same error for the Restrict to Topic validator on 0.5.10. I thought it was an issue with docker at first, but it's happening if I just run it locally as well.

hello I have the same erreur how are you resove this please

Hello I am getting same error . I am using the same set of code which is given https://github.com/guardrails-ai/guardrails
Its a virtual environment, Python 3.12.0


License mismatch (LICENSE vs README)

Thanks for the repo! Novel datasets are always hard to find.
The LICENSE file is "MIT" and the README.md says "GPL-3". I'm also not sure if datasets fall under a software license, but rather a creative commons one instead.
But depending on the source, the license will be different. Not sure if it makes sense to have one license for all the datasets.

Fixed!

Thanks for the heads-up :)


omni_base_robot: 2.0.19-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository omni_base_robot to 2.0.19-1:

upstream repository: https://github.com/pal-robotics/omni_base_robot.git
release repository: https://github.com/pal-gbp/omni_base_robot-release.git
distro file: humble/distribution.yaml
bloom version: 0.12.0
previous version for package: 2.0.18-1

omni_base_bringup
* Add warning for pal_module_cmake not found
* Contributors: Noel Jimenez

omni_base_controller_configuration
* Add warning for pal_module_cmake not found
* Contributors: Noel Jimenez

omni_base_description
* Add warning for pal_module_cmake not found
* Contributors: Noel Jimenez

omni_base_robot

No changes

Holding for Humble sync


proposal: refactor and enhance the write batch extractor

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
Currently, the write batch extractor plays a key role in cluster migration and sync tool, and we would also like to introduce it to our change stream mechanism.
But it now might have those (potential)issues:

missing enough test cases to
unable to extend due to it bindings to the RESP format
hard to maintenance due to implement all data types inside one function

This was also mentioned in issue #2583. To improve this situation, I would like to propose a new design for the write batch extractor.
Solution
Introduce an intermediate representation format for the parsed format like ChangeStreamEvent and it will contain the following fields:
struct ChangeStreamEvent {
	// required, event happens in this change operation
	int16_t event;
  // required, should be one of [STRING|HASH|SET|ZSET|LIST|STREAM|BITMAP|JSON]
	int16_t data_type;
	// required, the key which was affected
	std::string key;
	// optional, the subkey which was affected
	std::string subkey;
	// optional, it will be set to modified value if it's an added or modified operation
	std::string value;
}

For example, it will emit an event after receiving the command HSET my_hash f0 v0} :
{
	.event = "{SET}"
	.data_type = "{HASH}"
	.key = "my_hash"
	.subkey = "f0"
	.value = "v0"
}

Then, the cluster migration/sync tool/poll updates can generate their own format based on the change stream event.
TODOs

Add support of WriteBatchExtractor to allow to transform into ChangeStreamEvent
Add support RESP as the default output format  for ChangeStreamEvent
Replace the WriteBatchExtractor output with the ChangeStreamEvent
Add test cases for all data types.

What do you think? please don’t hesitate to leave comments if you have any thoughts or suggestions.
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

It seems related to the logical logging cc @mapleFU .
Could you elabrate the detailed design of the "event" field?
How to define a new event? e.g. for HASH data type, could you list all event, for every write commands here?

IMHO we should have a quite clear mind about the layered (or, leveled) semantics of execution of Kvrocks:

High level: Redis commands
Middle level: An orthogonal, but structured operations.
Low level: RocksDB key-value read/writes

Today we talk about the middle level operations.
This middle layer needs to have a clear design to meet three goals:

Orthogonal: Redis commands are obviously not orthogonal, but the middle layer must be orthogonal and can be "lower" from each Redis command to the middle layer.
Structured: The middle layer operators must have clear semantics, retaining high-level data structure information, rather than fragmenting into rocksdb reads and writes.
Integrated: The middle layer must have complete context information to avoid irreproducibility due to execution order.

By the way, would it better to making rdb have the same structure? Or they're totally different?

By the way, would it better to making rdb have the same structure? Or they're totally different?

rdb is for serialization of data, not for serialization of execution. so I think it's not suitable.

How to define a new event? e.g. for ZSET data type, could you list all event, for every write commands here?

It generally contains: ADD|DELETE|SET. For example, the ZPOP command should generate a DELETE event.

If we store "subkey" here, it's too "low level" to be a recorder for structured semantics. Also could you list all "subkey"s for all ZSET commands?

What I mean by subkey here depends on the data type. For the Hash type, which we can see in the example, its subkey is the field f0. And for the ZSet type, its subkey should be its member.
I don't quite understand the meaning of low level here. Could you elaborate a bit about what you think?

Structured: The middle layer operators must have clear semantics, retaining high-level data structure information, rather than fragmenting into rocksdb reads and writes.

For the change stream event is now mapping to what's command changed instead of rocksdb read/writes. So that's why we have key and subkey.

As you can see, this is a complex task. I hope we can have a clearer design: for example, for each redis data type, what is the detailed design of its middle-layer operator?

Yes, I agree we should take care of the design before starting the implementation. We can reach a consensus about the high level proposal, then go into the detail if all of us feel good about the proposal.

It generally contains: ADD|DELETE|SET. For example, the ZPOP command should generate a DELETE event.

How about commands like ZINTERSTORE, ZMPOP, ZPOPMIN? I'm still not sure if the current design is general enough. From my view it can easily become hard to model some complex scenarios.

@PragmaTwice I have changed to value to the payload which is a union type.

My current point is, if we cannot use it to model all operations, e.g. ZREMRANGE..., we'd better to keep the current (redis commands) form to make the impl unified and let user easily to understand.

Got your point. I agree that using the commands would make it easy to have a unified way to implement the change logs. My concern is that need to rewrite many commands like HINCR/HINCRY to  HSET to simplify the downstream implementation.

I am not very familiar with the internal structure of kvrocks, nor am I very familiar with C++. However, I personally think that it is only necessary to connect to rocksdb itself. As for the need for RESP or which data structure in https://kvrocks.apache.org/community/data-structure-on-rocksdb needs to be connected may be related to the user's needs (simply put, when considering performance, one will be more inclined to directly connect to the data-structure-on-rocksdb or kv of rocksdb). Only the parsing method of business-class data structures needs to be provided for users to use. In addition, maybe kvrocks will have its own business protocol and data structures that redis does not have in the future. Directly connecting to the structure on rocksdb can avoid this risk. And even if one only wants to use it as redis, if this structure is fully compatible with redis, it can be freely converted through the RESP parser.


Doesn't work on RHEL 9

I cannot use this script because it needs python 3.10 but I can only have Python 3.9. I have tried compiling Python 3.10 from source and command python3.10 work but pip3.10 doesn't at this point I don't know what to do

Are there any python repositories available for RHEL that provide the latest packages? If yes, add them any try again.

Hey @mrtajniak,
i am sorry but I can't help you with your problem. ☹
In the worst case you can try to use a different distribution in which you can install Python 3.10.4


Please add the ability to add a lock device to the HomeKit.

Please add the ability to add a lock device to the HomeKit. It'll be the same as Switch (it controls relay), but exposed to HomeKit as lock. I'm pretty sure its wouldn't be that hard to implement.

I'm pretty sure its wouldn't be that hard to implement.

Not sure why you would think that?  In HomeKit a lock has separate vs current lock states.  I'm not sure how to map that to a single GPIO pin.

Actually if thats a case you could make it require two GPIOs: one for lock itself (output), and second one for some kind of contact sensor that would tell if the doors are closed or open (input). If the input variable won't be specified meaning there is no contact sensor it could just indefinitely assume that the doors are closed (it shouldn't matter because close to every rpi gpio lock is some kind of electric strike or electromagnet). I've seen that implemented on other hb plugin, and it kinda worked but the plugin itself was really bad and buggy, just an opposite of yours - haven't had a single bug yet. If you could implement that tho I'd be really happy. Please think about it if you can.

Did you try the workaround from #63?

Yes! And overall it does the job, but there are some problems:

When I set it up, like a day after I did, my friend came over. I showed him what I created and it was good until he got an idea and kinda "broke in" by shouting out to Siri asking to turn on the door and HomePods reacted doing it. If that was exposed as LockMechanism it wouldn't be possible since apple doesn't allow to control locks and security alarms through HomePods.
I'm a nerd, and I would ready like to see it in HomeKit as it should be - with lock icon and overall treated as a lock, not a light or a outlet (Switch).

You closed the case you mentioned staying that you can't actually test it yourself - Why not? The simplest it'd be is just to connect an led to one of GPIOs. When you unlock the LockMechanism device, it'd just turn specified GPIO pin to HIGH and locking it would turn it to LOW (or inverted). The CurrentLockState should just follow the TargetLockState and that wouldn't create any problem, it'd just simulate a mechanical lock working really quickly.

Could you try beta v1.3.14-1?  See Wiki for details.

Thank you so much! It works as expected. My only concern is that the 'pulse' doesn't seem to work. It is necessary when the lock is actual door strike, since you don't want it to stay powered all the time, but for example for 2 seconds or so. I hope that when it comes to official release, that functionality will be there. Other than that I have no complains. Again thank you for your amazing job!

Ah, I missed the pulse part.  So, by default, when the GPIO is low, the lock should be locked.  To buzz it open, you want to set the GPIO high for like 2s, and then revert it to low.  I suppose you still need to use a relay to map the GPIO 3.3V DC signal to the typical 12 to 24V AC used by the strike?

In beta v1.3.14-2.

I suppose you still need to use a relay to map the GPIO 3.3V DC signal to the typical 12 to 24V AC used by the strike?

Yes, I do need a relay. The strike is connected to 12V DC Adaptor and one of the wires is controlled by relay. So yes I do need to set it to HIGH just for 2s and then "lock" it again.
Overall good job, thanks one again!

In beta v1.3.14-2.

In this version everything seems to be ok. Not a single problem.

Released v1.3.14.

Really thank you for that integration.
I immediately changed from my cmd-based solution to yours and it works like a charme. I am very happy that my request #63 now is implemented.


ARTEMIS-2075 - allow Extra backups to try to replicate more than once

https://issues.apache.org/jira/browse/ARTEMIS-2075

this will need cherry picking into 2.6.x as well

please retest this

retest this please

@andytaylor I have added a few questions to the JIRA, as the question is about the JIRA and not the PR itself.


Update netty-tcnative

Motivation:
We released a new netty-tcnative version as a memory leak was fixed.
Modifications:
Update netty-tcnative.
Result:
Fixes [#6249].

@Scottmitch @rkapsi FYI

Cherry-picked into 4.1 (4e04b63746d66aa1c1ef38d1505a9f0cdd62c26b) and 4.0 (c64a4d8)


Ignore licenses in hidden directories

When searching for licenses, files in hidden directories (like .eggs/LICENSE) were excluded but not the directories under (.eggs/foo/)..
Don't just hope over hidden directories but remove them from the list of directories to search.
Fix #398

Codecov Report

Merging #399 (3282ee6) into main (9c3242e) will increase coverage by 0.69%.
The diff coverage is 92.82%.

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   91.30%   92.00%   +0.69%
==========================================
  Files          17       16       -1
  Lines        1576     1701     +125
==========================================
+ Hits         1439     1565     +126
+ Misses        137      136       -1

Flag
Coverage Δ

unittests
92.00% <92.82%> (+0.69%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

setup.py
0.00% <0.00%> (ø)

grayskull/base/github.py
72.83% <72.83%> (ø)

grayskull/license/discovery.py
94.81% <78.12%> (-2.33%)
:arrow_down:

grayskull/strategy/abstract_strategy.py
83.33% <83.33%> (ø)

grayskull/__main__.py
95.60% <93.18%> (-2.55%)
:arrow_down:

grayskull/base/factory.py
91.17% <93.33%> (+1.17%)
:arrow_up:

grayskull/strategy/py_base.py
95.00% <95.00%> (ø)

grayskull/config.py
96.96% <96.96%> (ø)

grayskull/utils.py
98.12% <97.58%> (-1.88%)
:arrow_down:

grayskull/strategy/pypi.py
97.68% <97.68%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Samsa shows interpolated instance 500 at 499.99

Problem is when there is substitution at 500, then it is not displayed.
Test Case
In this test, letter G is supposed to be a circle in Medium SemiExpanded instance.

That is curious. The substitution happens at the very next possible value for the axis (when you use the arrow buttons to increase by a tiny amount).

glyph
wght (dec)
wght (normhex)
Samsa
Webfont

G
499.9755859375
0x1554
rectangle
rectangle

G
499.993896484375
0x1555
circle
rectangle

G
500.01220703125
0x1556
circle
circle

Are you able to test on another platform, Windows or Android, to verify this is a bug in Samsa rather than the Apple renderer?
Could you also write down what the subsitutions are supposed to be doing, since there are multiple overlapping substitutions?


Missing Info and a link to non-https site

Missing Info
What are the available volume drivers?
What are the options they take? Is this information available elsewhere - a Google search doesn't seem to bring anything up.
Options aren't supported on Windows Local driver, fine - but what about the others?
mount Man page link
The link to the man page uses an http url - there are plenty of sources of man pages that make use of SSL.
Other Comments
I understand that the example command using timey=wimey is just there to show the form of the command but imagine yourself in the place of someone who's getting frustrated in trying to solve their problem, faced with what appears to be a bunch of missing info (as listed above), I'm sure you can imaging how provocative such a whimsical example is.
File: engine/reference/commandline/volume_create.md

Thanks for sharing this issue. This particular content is maintained in an upstream repo. Since this issue is dated, I'm not sure if it is still applicable. If the issue is still applicable, please help create an issue or PR in the source repo at https://github.com/docker/cli/tree/master/docs/reference/commandline
Closing this as unable to fix in this repo.


Add lints for S/MIME BR <IP_ADDRESS>.2n country name

This PR adds lints for S/MIME BR <IP_ADDRESS>.2n country name.

@christopher-henderson Thanks for the review. I added a description. This is ready to be merged (from my perspective).


Tests Dir rename to CI

Cleanup to keep things consistent across repos.
Need to rename the tests/ dir to ci/

ansible-galaxy init prefers tests dir over ci. In 0.5.0 refactored to tests directory.


extend logging in http response when error occured

[ ] jena parsing warnings/errors
[ ] if sparql query fails, maybe print sparql query (if no security problem)

both done should work... tests worked...


disabled_services should be stopped too

Describe the bug
Disabling a service does not guarantee that the service will be stopped.
In the case of systemd it even leads to inconsistencies that need to be addressed in the service provider, see: https://github.com/puppetlabs/puppet/blob/5.5.x/lib/puppet/provider/service/systemd.rb#L37-L48

# This helper ensures that the enable state cache is always reset
# after a systemctl enable operation. A particular service state is not guaranteed
# after such an operation, so the cache must be emptied to prevent inconsistencies
# in the provider's believed state of the service and the actual state.

Expected behavior
I would expect this module to stop disabled services.
Actual behavior
Services are left running until a reboot of the machine.

fixed with #226


Replace javascript authservice with a java one

This removes some special handling of none-authservice in the makefiles,
and allowing us to build the whole project only with maven and go. The
implementation is supposed to be a drop-in replacement of the existing.

@enmasse-ci run tests testcase=standard.auth.AuthenticationTest

@enmasse-ci run tests testcase=standard.auth.AuthenticationTest

@enmasse-ci run tests testcase=standard.auth.AuthenticationTest


Update tutorial-join.md

Incorrect example

Thank you for bringing this up!
The intention is to show a query that is as simple as possible. Therefore, I think it's better to adjust the example result rather than the query. Will be fixed by https://github.com/arangodb/docs/pull/989/commits/faa97f3663872da0c97e1f3e3a967a5d2c4c4033


"Detected unicode characters, removed" when importing issues

When trying to import issues assigned to users that contains \ in the username, the terminal reports: "Detected unicode characters, removed"
The result is that everything after the \ is removed in the username.
user.txt:
JIRAUSER12600=CORP\u084699
issue.json:
{
"ReferenceName": "System.AssignedTo",
"Value": "CORP\u084699"
}
Result on Azure:
Assigned ´To: CORP
Tool version

Version of the jira-azuredevops-migrator tool 3.0.186

Attachments
wi-import.log.txt
config.txt

If you are able to build the project yourself, you can comment out the following lines to disable the unicode character removal, but this might cause other data to render weirdly: https://github.com/solidify/jira-azuredevops-migrator/blob/e023e826fd44f3613e329b7645cd2a4ce318b49b/src/WorkItemMigrator/Migration.WIContract/WiItemProvider.cs#L31C1-L35
Will have to think of a solution to this edge case.


new checker 'suite-subtest-run'

Closes https://github.com/Antonboom/testifylint/issues/35

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

43 of 47 (91.49%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 93.702%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/checkers/suite_subtest_run.go
25
29
86.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
2053

Relevant Lines:
2191

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

43 of 47 (91.49%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 93.702%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/checkers/suite_subtest_run.go
25
29
86.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
2053

Relevant Lines:
2191

💛  - Coveralls


[Feature] add conversion data to the hubspot__source table properties

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
Hi there!
I find useful to have the Conversion Information of a contact in a the hubspot__contact table (from dbt_hubspot package), these are the informations mentioned here (section Conversion Information):

First conversion date
First conversion
etc

I did not find any of this data in the tables created by the hubspot transform package, so for now I'm using directly the table contact_form_submission imported by Fivetran. (with an aggregation data is good)
Maybe I did not search enough and this is already somewhere 🤔
Thx and Have a great day!
Describe alternatives you've considered
Continue using directly the table contact_form_submission
Are you interested in contributing this feature?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?
I just set up this dbt hubspot source package and it's really well explained, liked it ! :)

Hey, just some infos :)
I may be able to work on this but I don't know when, I've done some specific workaround for my use case for now, but I still think it would be better here so I'd love to come back on this when some time will free up.

Hi @moreaupascal56 that sounds great! We will keep this feature open and feel free to come back when you have time available.
We really appreciate your continue contributions to this code base 😄. Let me know if you have any questions or need any support.


load_dataset fails for JSON in windows

Describe the bug
Steps:

Created a dataset in a Linux VM and created a small sample using dataset.to_json() method.
Downloaded the JSON file to my local Windows machine for working and saved in say - r"C:\Users\name\file.json"
I am reading the file in my local PyCharm - the location of python file is different than the location of the JSON.
When I read using load_dataset("json",args.input_json), it throws and error from builder.py.
raise InvalidConfigName(
f"Bad characters from black list '{invalid_windows_characters}' found in '{self.name}'. "
f"They could create issues when creating a directory for this config on Windows filesystem."
When I bring the data to the current directory, it works fine.

Steps to reproduce the bug
Steps:

Created a dataset in a Linux VM and created a small sample using dataset.to_json() method.
Downloaded the JSON file to my local Windows machine for working and saved in say - r"C:\Users\name\file.json"
I am reading the file in my local PyCharm - the location of python file is different than the location of the JSON.
When I read using load_dataset("json",args.input_json), it throws and error from builder.py.
raise InvalidConfigName(
f"Bad characters from black list '{invalid_windows_characters}' found in '{self.name}'. "
f"They could create issues when creating a directory for this config on Windows filesystem."
When I bring the data to the current directory, it works fine.

Expected behavior
Should be able to read from a path different than current directory in Windows machine.
Environment info
datasets version: 2.3.1
python version: 3.8
Windows OS

Hi!
You need to pass an input json file explicitly as data_files to load_dataset to avoid this error:
 ds = load_dataset("json", data_files=args.input_json)

Thanks it worked!


Extraneous files included in working set automatically, even when explicitly removed prior to executing a prompt

Type: Bug
While doing feature development, it's normal to have files open in split view which are not immediately involved in the current Copilot context, because they are unrelated to the prompt I am attempting to iterate a solution on.
Copilot automatically adds any file open in split view to the Working Set on starting a prompt from cmd +  shift + i. I then explicitly remove it from the Working Set. However, Copilot automatically adds it back in during execution, and then attempts to change said unrelated file first if that file is to the left of the one I am attempting to focus the prompt on. This UX is incredibly frustrating as it seems the only way to avoid it is to exit my split view context entirely and lose markers about where I am in building a large feature.
Extension version: 0.23.2024102903
VS Code version: Code 1.96.0 (Universal) (138f619c86f1199955d53b4166bef66ef252935c, 2024-12-11T02:29:09.626Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
5, 5, 5

Memory (System)
16.00GB (0.07GB free)

Process Argv
--crash-reporter-id 347ab492-ea6d-4d00-8d4f-c149bbb7267b

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt551:31179978
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624

However, Copilot automatically adds it back in during execution, and then attempts to change said unrelated file first if that file is to the left of the one I am attempting to focus the prompt on.

This is not expected, but I can't reproduce this behavior. Can you please share a screen recording so I can try to repro?


Add Functionality to Copy Entire Path from HTTP Endpoint Activity #133

This PR introduces a "copy full path" feature for the httpendpoint activity in Elsa #133 , utilizing the MudExtension component to enable start and end adornments. This feature has been integrated into the SingleLineComponent, allowing it to be toggled on or off through a flag in elsa-core. Currently, the Blazor text field has a limitation where both start and end adornments cannot be added to the same component, an issue acknowledged in the MudBlazor repository (Issue #8945).
Key Points of this PR:

Leverages MudExtension to support both start and end adornments.
Adds a copy icon as an end adornment, with the flexibility to support more adornments in the future.
Integrates the feature into the SingleLineComponent with a toggle flag in elsa-core.

Please note a side effect: the placeholder text appears at the top of the textbox rather than centered, due to both adornment slots being added by default.

I believe this enhancement adds valuable functionality, but I would appreciate your feedback on whether this approach aligns with the project’s goals and standards. As this is my first PR for this library, look forward to future contributions. I welcome any suggestions or modifications to improve this implementation.

@dotnet-policy-service agree


Validate Multiple YAML Types through Configuration

I have started defining Cue types for all the YAML resources I have on a GatsbyJS project. Lets assume my content looks like:
content/
  - articles/*.yaml
  - podcasts/*.yaml
  - team-members/*.yaml
  - videos/*.yaml

I have a Cue package that defines each of those types, articles, podcasts, team-members, and videos.
I can validate this YAML with many commands:
# Repeat for each type
cue vet articles/*.yaml schema/videos.cue -e Video

I'd like the ability to validate this entire YAML tree with a single command.
Approach 1:
Modify the YAML file with a line-1 comment:
# type:Video
YAML

Approach 2:
Cue configuration
# .cue.toml
[Video]
  yaml-dir = "./videos"

[Article]
  yaml-dir = "./articles"

Approach 3:
@mpvl mentioned in Slack that a custom task could potentially get to the point it could do this

@rawkode Do you have any examples of instances of the respective types (Article, Video, etc.). I'm specifically interested in whether these values have "discriminators", fields from which one can tell what the type is. (e.g. like Kubernetes' kind field.)
Although this would not enforce that a single directory only has one type, it would allow to automatically assign the type based on the kind. Yet another way to do this, is to check each instance against Video | Article | ... .
I can think of a few additional approaches:

As an alternative to approach 1, use YAML tags to annotate types (e.g. !<tag:example.org,2002:video>). This seems more consistent with spirit of YAML than using unstructured comments.
In addition to/ instead of option 2, allow a parallel directory structure in, say, cue.mod/checks, with CUE files that contain definitions for imported content.

For approach 2, I would probably prefer the variant of having a  cue.mod/import.cue with content of the following format:
package import

globs: "videos/*.yaml": type: Video
globs: "articles/*.yaml": type: Article

and/or allow any number of *_import.cue files of the same format. The package of such validation files would assign such files to validators.
This format can be extended to allow things like:
import "example.com/mymodule/schema"

globs: "videos/*.yaml": {
  // The CUE schema of the top-level objects of this file.
  type: schema.Video

  // Where to include this configuration hierarchy (the `-l` option of import).
  path: [type.kind, type.name]

  // how should this be interpreted? E.g. is a JSON file really an OpenAPI file?
  // media, qualifier, etc.
}

In the usual spirit of CUE, if a file matches multiple globs, all constraints will apply.

@mpvl my schema is available
https://github.com/devreltools/schema
I'm not against the discriminator field approach, but I do like your other suggestions a little more 😀

They are not necessarily mutually exclusive. :)

This issue has been migrated to https://github.com/cue-lang/cue/issues/255.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


test: try to debug failing integrations

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

Hi @chingor13, I was diving into #8 and found your PR.
IIUC, the issue here is that the service account used to execute tests has Project Owner role granted.
I was able to pass tests locally when my service account is only granted Project Editor role. The reason is that Project Owner has serviceusage.services.use. This lets requests succeed without having the user set a user_project as expected.
An alternative solution to this is to create a new service account for this project that only has Project Editor role.
This was encountered here as well: https://github.com/googleapis/google-cloud-java/issues/3448
Totally open to discussing this more. I don't know where the service account is stored but I can help update it with a new service account credentials file to unblock this failure.


Fixed import statement, for d.ts files

I've realized that TypeScript compiler generates wrong import paths for some of the types: rules and variables. This happens because we use implicit import for static properties and compiler inlines import statements.
To avoid this, we have to explicitly specify the type of the rules and/or variables or remove typing for such properties, if it is more appropriate.

Given most of the changes here are not applicable after #16 lands, and the remaining changes are also implemented there, I propose we close this PR for now and wait until we're done integrating #16's changes.

Agree, let me close this PR and wait for #16 to be merged.


Fix documentation for #8

Fix documentation for pie diagram

Thank for updating the readme - this is helpful.
Before I can accept this and merge it in, I need you to sign our Contributor License Agreement (CLA). This will take care of us for this PR and any future ones you may want to submit.

Done

Wonderful. Thank you. One more thing. Since the Example Data section of the readme is basically a straight copy/paste from the example/data.js file - could you update that file as well for consistency? At some point, that section in the readme should maybe just be a link to the example data directly rather than embedded as it is now.

Done


NameError: uninitialized constant GData

Im including gem "gdata_19", :git=>'git://github.com/tokumine/GData.git'
in my ruby 1.9 rails3 project via Gem file.
After bundle install
Loading development environment (Rails 3.1.3)
1.9.2-p290 :001 > yt = GData::Client::YouTube.new
NameError: uninitialized constant GData
from (irb):1
from /usr/local/rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/commands/console.rb:45:in start' 	from /usr/local/rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/commands/console.rb:8:in start'
from /usr/local/rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/commands.rb:40:in <top (required)>' 	from script/rails:6:in require'
from script/rails:6:in `'
Is there something Im missing before using gdata_19?

a require 'gdata' on my app controller fixed it


Remove of chain deep-inspection config option

There is a change in the Tekton operator switching the supported value of Chains' enable-deep-inspection from bool to string ("true"/"false replace true/false). The update of OSP got blocked on some of the clusters because the TektonCOnfig value happened faster than the Catalog update and the actual upgrade. The upgrade was blocked because the old version of the operator does not support the new value in the tektonconfig. As a workaround, we remove that value, let the upgrade finish and in a following PR we switch to the new value.

We need that workaround only for one of the staging clusters which I'm told is going to be decommisioned in the next few days, thus the change is not required and I'm closing it.


Update zio, zio-test, zio-test-junit, ... to 2.1.8

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-junit
dev.zio:zio-test-magnolia
dev.zio:zio-test-sbt

from 2.0.22 to 2.1.8
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #176.


How do we set sender actions?

Hello, this is my first bot and I would like to provide a typing indicator to allow users to see whether the message they sent is being processed or not.
I took a look at the Facebook Send API reference and wrote the following code:
botly.send({recipient: {id: senderId}, sender_action: "typing_on"}, function(err, data) { 		console.log(data); 	});
I am getting the following console output:
{ error:     { message: '(#100) Must send either message or state',      type: 'OAuthException',      code: 100,      error_subcode: 2018015,      fbtrace_id: 'H1BxIEyCbKk' } }
Any help with this will be immensely appreciated. Thank you!

`botly.sendAction({
id: senderId,
action: Botly.CONST.ACTION_TYPES.TYPING_ON
});
 botly.sendText({
   id: senderId,
   text: 'Hi !'
 }`

It will send the typing_on action until your bot send the text. :) At least it's what it does for me !
For this exemple you will not see very much but with a carousel it work well.


v8.0.0

What does this PR do?

chore: update project
fix: improve Babel settings for polyfills
style: refactor the methods that had high complexity
chore: update Node version to 10.13
Set v8.0.0

How should it be tested manually?
yarn test
# or
npm test

Pull Request Test Coverage Report for Build 358

117 of 117 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 340:
0.0%

Covered Lines:
2275

Relevant Lines:
2275

💛  - Coveralls


MockFileSystem sets current directory to actual FS

It appears that the MockFileSystem constructor calls real filesystem API when the currentDirectory parameter is left empty.
The current directory is then set as C:\Users\...\AppData\Local\Temp
I suspect the following code
    public MockFileSystem(IDictionary<string, MockFileData> files, string currentDirectory = "")
    {
        if (string.IsNullOrEmpty(currentDirectory))
        {
            currentDirectory = IO.Path.GetTempPath();
        }
        ...

in https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/4b8ff76fb410e15d26ab2cab807117323de08299/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs#L22

Thanks for reporting this! I see a few options here:

Not setting the current directory unless explicitly specified. Unsure what would be the effect of this though.
Setting it to some hardcoded path, e.g. c:\temp. Should be safe and is predictable.
Leaving it as is. I don't see too big a problem with the current approach as getting the temp path is non-invasive.

Thoughts?

Setting it to some hardcoded path, e.g. c:\temp. Should be safe and is predictable.

That's a very Windows-centric point of view :)

After a quick glance, I think that not setting it at all would cause issues in the MockDirectory.EnsureAbsolutePath() method (used by MockDirectory.GetFiles() and MockDirectory.EnumerateDirectories()).
The only question I'd have with leaving it as is, is whether there'd ever be a case where you wouldn't have the real IO.Path available.

I feel having a safe default is desired. Why can't we use the "root" concept for this; "C:" and "/" respectively?
I'd like the current behavior be changed, since. Reason why this issue exists is because I spent an hour figuring out the unexpected behavior.

Fair enough. What was expected behavior, in your case?

The struggle boiled down to something along the lines...
var fs = new MockFileSystem();
var dirInfo = fs.DirectoryInfo.FromDirectoryName("."); // System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\Users\....\AppData\Local\Temp

In such case I'd like fs to have an empty filesystem present, with only the root directory. Having CD pointing here as well makes perfect sense to me.


Refactor the pipelines (batch and incremental) to have fixed workflows

Description of what I changed

Fixes #824
Refactored the code such that multiple pipelines (one for each FHIR resource type) are created for each batch/incremental run.
The multiple pipeline will be executed sequentially one after the other.
Parallelism can be defined where in each parallel stream pipelines will be executed sequentially one at time.
These changes will make sure that the memory required for Flink cluster is a constant factor and does not depend on the number of resource types.
Regressions like Progress bar feature, pipeline metrics are addressed.

E2E test
Tested batch and incremental runs for multiple FHIR resource types keeping the Flink memory parameter taskmanager.memory.network.max constant and checked there is no impact on the number of resource types.
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.

[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.

[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[ ] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

Thanks @chandrashekar-s for this change; before I start the review, can you please take a look at the e2e test failure? It seems that at the batch step (with search API) it has completed the pipeline quickly but for some reasons was stuck (logs here). I started a retry but I doubt it will fix it.

Thanks @bashir2 for pointing it out, I have fixed the issue and the build is successful now. Also currently the refactoring of pipelines is done to the JdbcHapi mode only and the rest of the modes are yet to be optimised.

Thanks @bashir2 for the review. I have addressed the review comments, please have a look. Also, I checked if the refactoring is needed for the FHIR Search mode, it turns out that this mode has no reshuffling's and hence the number of network buffers used is very low. However, when the activePeriod flag is set then for this function Sum.integersPerKey() over here it allocates N^2 number of  network buffers (N=No of Cores). So I feel no refactoring is required for FHIR Search mode as we have already allocated enough buffers to handle 9 * N^2 buffers (needed for merge pipeline).

@bashir2 thanks for the review. I have addressed most of the comments in the latest commit. Please have a look.


Submit individual object import

At line 35 (adding Type as required field - shouldn't this also include Image/Computer Image? I thought we were conceptually moving these to "objects" in the data model.

Ignore this - if I'm understanding our domain/data model conversation notes correctly and following the thread down:

what were previously referred to as Images/Computer Images (complete, bootable system images from an external hard drive or pre-existing VM imported into EaaSI) should no longer be treated as a user-facing type of resource, but as (I presume) "Disk"-type Software or Content objects

e.g. the BitCurator virtual machine image would be a Software-type "Disk" object
Salman Rushdie's personal desktop would be a Content-type "Disk" object

"Images" refer only to qcow images/layers created by EaaS as an underlying component of Environments
Users could create an EaaSI environment booting directly from a bootable Software or Content-type "disk" object using the advanced Emulation Project workflow. (They could inspect - but not boot from - a bootable Software or Content-type "disk" object in a legacy computer environment using the basic Emulation Project workflow, which enforces the selection of a pre-existing Environment that already has and boots from an EaaSI-created Image)

what were previously referred to as Images/Computer Images (complete, bootable system images from an external hard drive or pre-existing VM imported into EaaSI) should no longer be treated as an independent, user-facing type of resource, but as either (I presume) "Disk"-type Software or Content objects

This is correct


Automatically clean up sockets if they are not contactable

Dead sockets should be removed to prevent the /tmp folder from filling up with clutter

Thanks @Gooygeek
Closing


Windows Commands/Command Extensions: extra notes

Description:
As requested in issue ticket #4305 (Really?), Command Extensions needs to be described better, at least enough to get a fair understanding of the concept and its usage.
Thanks to @RocketCityElectromagnetics for initiating the issue ticket.
Based on feedback from @KalleOlaviNiemitalo (Kalle Olavi Niemitalo), this PR contains his suggested changes from the same ticket.

Changes proposed:

Set 06/13/2020 as the new (tentative) metadata date for the files
Add a note about Command Extensions in the setlocal page
Add link to "The command interpreter cmd.exe" in Additional References
Add a note about setlocal and endlocal after the list in the cmd page
Add the commands 'date' and 'time' to the list of affected commands
Add a note in 'assoc', 'color' and 'ftype' about cmd not recognizing the command if Command Extensions are disabled
Add a note in the 'color' page about PowerShell alternatives

Whitespace and codestyle adjustments:

Remove redundant end-of-line blanks (if present in the file)
Add blank space to insides of table cell dividers in 'setlocal'
Add readability comma in the Note text in the 'color' page
Add HTML line breaks in the Note blobs with added text
Join /t: arguments and pipe divider inside the same MD back ticks
Normalize bullet point spacing to 1 space (4 lines)
Normalize number of contiguous blank lines to 2 (setlocal, 1 line)
Add blank line before list of affected commands (cmd page)
Add missing NewLine (line break) at end-of-file (setlocal page)

Ticket closure or reference:
Closes #4305

@RocketCityElectromagnetics and @KalleOlaviNiemitalo : Feel free to comment, suggest and approve the changes made in this PR. Improvement suggestions are especially welcome.

#sign-off

Closing this PR because the file conflict is just a little bit too messy for me to resolve right now, at least in my Git tools.
Will try to open a new PR for these changes when I can sort out the current state of these documents.


Yihgu/refactor api

Add framework for Feathr API layer.

Add link to design document :
https://microsoft.sharepoint.com/:w:/t/AICustomerEngineeringTeam/ESCFZIcBrpxBmkITXDwT-7EB9dB_V9F-eStOqcFPh1ZfOg

Please merge with latest.
This PR is pretty big. Let's follow https://github.com/linkedin/feathr/blob/main/docs/dev_guide/pull_request_guideline.md so we can refer to the documents in the future.

Add link to design document : https://microsoft.sharepoint.com/:w:/t/AICustomerEngineeringTeam/ESCFZIcBrpxBmkITXDwT-7EB9dB_V9F-eStOqcFPh1ZfOg

Could you put this into your description section.

Since this PR has some conflicts with main, let me know when you merged so I can start review.
Please ping me once you are ready.


how could I run inference on single image

Hi,
Thanks for providing this great implementation, I am trying to use your code to run inference on one single jpg image. I notice that the inference code requires the images stored in some folder ahead of launching the inference code. How could I run inference on single jpeg image from memory as an input variable?

fix the variable


Fido/Yubi Key Setup with  ujust fido2

This addition creates a ujust script that allows easy config of a fido/yubi key on to an encrypted disk.
it provides options to:

enrol a new key
manually assign device and luks volume if you have multiple encrypted disks
set the key has the default method.   This allows the key to be the only auth method needed and password as fallback.  Great for steamdeck use if fido key doesnt need a passphrase as it doesnt yet have a onscreen keyboard for this
rebuilds initramfs with fido module - its an option incase you want to do thjis for multiple volumes, it doesnt need rebuilding again.
and it updates /etc/crypttab with fido option for selected volume if needed

some problems here

We use Semantic PR so commit messages should follow: https://www.conventionalcommits.org/en/v1.0.0/
Recipe should be named configure-fido2 following the current naming convention used throughout ujust
Your current implementation uses rpm-ostree initramfs and you will wipe out any initramfs arguments that has previously been set on the system (be it nvidia modules or other hwe related initramfs stuff), you should really consider putting it into a dracut.conf file inside /etc/dracut.conf.d

Since this has been written, Bazzite and Bluefin/Aurora have started shipping an initramfs built as part of the build pipeline.
This reduces the need for the initramfs components, but is still needed on our main images.

This can be rebased and use the new tips that were merged in #266.

set the key has the default method.   This allows the key to be the only auth method needed and password as fallback.

Does this means that even if I set a PIN in my FIDO key, it will bypass it and unlock LUKS without the need to insert the PIN? (dangerous 😱)

set the key has the default method.   This allows the key to be the only auth method needed and password as fallback.

Does this means that even if I set a PIN in my FIDO key, it will bypass it and unlock LUKS without the need to insert the PIN? (dangerous 😱)

this means that the password for LUKS doesnt need to be used.
as you can set the priortiy or even disable it.
this isnt anything to do with the pin for the fido.
i dont use a pin on my fido, the reason being that i only use this on a steam deck and that currently doesnt have a good way to input text,  it would need an onscreen keyboard added, so if it asked me for a pin id need to plug in a keyboard, which isnt practical.


Fix TO Go DS to allow null protocols

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1757/
Test PASSed.


Bundle of remote schema fails when schema includes relative reference

I have discovered an issue when a remote schema (ex. http://schema.com/user) contains another reference to a relative schema on that site (ref: "/address");
Using the resolver, i get a $refs object which contains following keys:

My original file
http://schema.com/user
http://schema.com/address
This is what I expect.

However, when trying to bundle(), I get the message that: "all pointers must begin with #".
I have made a workaround in my code using .resolve() and then swapping out the relative path by checking all the keys in the $refs object, but I expect bundle() to just work out of the box.
fyi, this relative path thing works fine on the official Swagger Editor website.

Without seeing your actual schema, I can't say for sure what's causing the error.  But it sounds like you have an invalid JSON Pointer in there somewhere.
The resolve() method only parses JSON References, not JSON Pointers, which is why you don't get an error when calling resolve().  But the bundle() method does parse JSON Pointers  so it can resolve their values, and it throws this error when it encounters an invalid pointer.

Hi, so we found the issue.
There was a schema/fizz#buzz listed in the schema instead of schema/fizz#/buzz, meaning that spec wize, it is indeed incorrect.
However, I would like to note that the same Swagger file was handled without error by the official Swagger Editor, which we ask our teams to use for editing. We use your library to create a custom view (forcing us to parse the Swagger). It is very weird to have the standard Editor allow something which is not correct in your library.  I see two ways to look at this (both valid btw)

The online Swagger Editor is more resilient to errors, and we can help users by making this library just as resilient for this kind of mistakes. (Action: Adjust this library to be resilient)

This error is only valid because you do something which is not in the Specification. It is not because the Swagger Editor supports this mistake that this library should. (Action: Do nothing)

I will be watching this issue to see what you decided, but I hope you at least consider both of the options above.

Swagger Parser actually uses json-schema-ref-parser under the hood, which is a spec-compliant implementation of JSON Reference and JSON Pointer.  I don't want to introduce non-spec-compliant behavior into that library (which is used for more than just Swagger-related stuff) just for the sake of conformity with a Swagger tool.
I suggest opening an issue on the Swagger Editor repo asking them to at least show a warning message for non-spec-compliant references.
All that said... I do think that I should improve the error message that is thrown in this case.  Since it's an easy mistake to make, and a hard one to notice, it would be beneficial for me to point it out more clearly.


run tests in ppe

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - Azure.Communication.Identity - tests

/azp run net - Azure.Communication.Identity - tests

/azp run net - Azure.Communication.Identity - tests


Dbhydra does not process json columns correctly

Current version (v1.1.0) can not handle json values in MySQL.
MySQL column types include JSON type, which dbhydra currently does not support and just simply converts such values to string / tries to insert pure Python dict while inserting from DF. Escaping quotes and replacing single quotes with double quotes does not help. The solution might be (but doesn't have to) to use prepare statements (requires bigger refactor of core insert functions) or to add an additional explicit check for column value dtype.
Please add support for JSON dtype for MySQL and other DBMS (e.g. Postgres)

Yes, on todo


Added a new mentor: Vinit Shahdeo

Learn more about me here.

LinkedIn
Twitter

hey @vinitshahdeo ,
You haven't mentioned your tech-stacks so that students can know you better, I have added some based on your LinkedIn profile please have a look and let me know if any changes are required.
P.S. Please accept my request on LinkedIn 😅


Cold account surcharge not being taken into account

See https://github.com/foundry-rs/foundry/issues/7047

This should be fixed


Template to share custom rules

This is a follow up of #3829
There, @cortinico and @JavierSegoviaCordoba proposed to create a custom-rule template and encorage the usage of jitpack to make it easier for the users to share their custom rules.
I created that repository and I want feedback: https://github.com/BraisGabin/detekt-custom-rule-template (right now the repo is under my username but as soon as we agree that it's ready I would move it under the detekt organization)
I found one problem: The users should not use the example package name. That could create collisions in the future. For that reason I created a script to make it easy to decide your own packagename.

found one problem: The users should not use the example package name. That could create collisions in the future. For that reason I created a script to make it easy to decide your own packagename.

On this side: we could add a Github Action that prepares the repository after you create a new one from the template.
@martinbonnin helped me do something similar with the kotlin-android-template here:
https://github.com/cortinico/kotlin-android-template/blob/master/.github/workflows/cleanup.yaml
Basically once you use the template, a Github Action gets triggered only once that will cleanup the project and create a unique package name from the repository name.

Good job! I like it. 🎉

As for the template: it's great 👍
I just have one note:
https://github.com/BraisGabin/detekt-custom-rule-template/blob/da93b57d5e19694e570dd906f4e246c2e6d58dfd/src/test/kotlin/org/example/detekt/MyRuleTest.kt#L5-L7
I would not use Spek for the sample test. Ideally I would create a plain JUnit test. I'm fine with us using it internally, but I'd try to simplify the template as much as possible to reduce frictions on the template/tool adoption.

Workflow created (really nice trick!) and moved from Spek to JUnit. I agree that JUnit suits better for a template. I'll keep this issue open for some days to get more feedback (or even PRs :P) and then I'll move the repository to the detekt organization and create some documentation in the web pointing to it.

Maybe the cleanup workflow can be a workflow dispatch where you can put the package name and every needed input (package, data for publishing and so on).

Maybe we should also put a tag custom-rules on this repo in order to find it via GitHub search.

Maybe we should also put a tag custom-rules on this repo in order to find it via GitHub search.

Done

Maybe the cleanup workflow can be a workflow dispatch where you can put the package name and every needed input (package, data for publishing and so on).

The problem I see is that I don't want anyone to use package org.example. And if I transform the workflow to a workflow dispatch I'm worried that the users will not use it and just use the org.example package. But I agree that a workflow dispatch would be nicer and will allow a bit more customization. Any idea about how to get both?

I really like the template repository idea. Should its Readme.md maybe contain some basic information on how to integrate the rules into a project once they are released?

That sound reasonable any suggestion about how to document that?
The README of the template is a bit "strange" because you want it to be a readme for the template AND to be a template for a readme for the real project that will be generated on top of it. So it is in between two worlds that I'm not sure how to handle properly.

However, the readme could contain a link to detekt's website, which shows how to integrate custom rules into a project.
https://detekt.github.io/detekt/extensions.html#custom-rulesets

I don't want anyone to use package org.example

I believe we can update the default package to: io.github.detekt.community
or something along those lines.
We already have software under that package:
https://repo1.maven.org/maven2/io/github/detekt/
Users won't be able to publish them to Maven Central, yet they would be easy to browse/recognize and easier to use via Jitpack.

What do you think about using @AutoService in the template project? I think that it makes the code less error prone. Any change in the package or class name will not break the installation of the plugin.

What do you think about using @AutoService in the template project?

I'm unsure to be honest. I would stick to have it as vanilla as possible so I would opt for not having it, but maybe we can add a note to the README or somewhere in the documentation?

However, the readme could contain a link to detekt's website, which shows how to integrate custom rules into a project.
https://detekt.github.io/detekt/extensions.html#custom-rulesets

It does :)

I believe we can update the default package to: io.github.detekt.community
or something along those lines.
We already have software under that package:
https://repo1.maven.org/maven2/io/github/detekt/
Users won't be able to publish them to Maven Central, yet they would be easy to browse/recognize and easier to use via Jitpack.

They can't use our cordinates but they could use that package with other coordinates. I think that I prefer to keep org.example to make it "more clear" that the package is just and example and should be changed.

Ok, I moved the repo to the organization. New link: https://github.com/detekt/detekt-custom-rule-template


Add toString to IvyPaths for debugging purpose

/review @Duhemm, @dwijnand

LGTM

Forward ported in https://github.com/sbt/librarymanagement/pull/46


add JMH benchmarks for accept and count

What does this PR do?
This adds a JMH module and benchmarks for the getCount and accept operations.
Motivation
Understanding performance (and sensitivity to patterns in data thereof) of basic sketch operations; help exploratory performance analysis of the data structure.
Additional Notes
This PR demonstrates a (perhaps obvious) sensitivity of DDSketch.getCount performance to the distribution and granularity of inputs, but verifies that accept can be expected to take a handful of nanoseconds.

Perhaps we can port those over to use JMH in the future. Thanks for pointing them out to me.


Inconsistent result codes in onIabPurchaseFinished

Hi,
Return values in onIabPurchaseFinished is quite inconsistent between stores and make it hard to know what to handle how.
Half stores will answers with IabHelper.BILLING_RESPONSE_RESULT type codes.
And other half will answer with IabHelper.IABHELPER_ type codes.
All store should answer with the same code for the same result. (Typically the user cancelled event)
Regards,
Tolriq

for the next version of the library


Update smithy4s-aws-http4s, ... to 0.18.5

About this PR
📦 Updates

com.disneystreaming.smithy4s:smithy4s-aws-http4s
com.disneystreaming.smithy4s:smithy4s-sbt-codegen

from 0.17.19 to 0.18.5
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming.smithy4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.disneystreaming.smithy4s" }
}]

labels: library-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #105.


Quick fix to better select window names via a partial text search

Coverage remained the same at 100.0% when pulling e7469a49220cfab99731a089a70c0d7cb37e8ffd on partial_window_search_fix into 5af4652a49d65325fae782901ca48b2df3095d10 on master.

Coverage remained the same at 100.0% when pulling e7469a49220cfab99731a089a70c0d7cb37e8ffd on partial_window_search_fix into 5af4652a49d65325fae782901ca48b2df3095d10 on master.


CalendarCarousel test failed in snapshot

Describe the bug
yarn testing fails in  packages/tests/CalendarCarousel.test.tsx
To Reproduce

$yarn jest packages/__tests__/CalendarCarousel.test.tsx

Then I get following error message.

$ tsc
 FAIL  packages/__tests__/CalendarCarousel.test.tsx
  ● [Calendar] › should render without crashing

    expect(received).toMatchSnapshot()

    Snapshot name: `[Calendar] should render without crashing 1`

    - Snapshot  - 24
    + Received  + 24

    @@ -62,11 +62,11 @@
                      "textAlign": "center",
                      "width": 300,
                    }
                  }
                >
    -             July
    +             7월
                </Text>
                <Text
                  style={
                    Object {
                      "fontSize": 12,
    @@ -114,11 +114,11 @@
                      "fontSize": 20,
                      "textAlign": "center",
                    }
                  }
                >
    -             S
    +             일
                </Text>
              </View>
              <View
                style={
                  Object {

...

      16 |   it('should render without crashing', () => {
      17 |     const rendered = renderer.create(component());
    > 18 |     expect(rendered).toMatchSnapshot();
         |                      ^
      19 |     expect(rendered).toBeTruthy();
      20 |   });
      21 | });

      at Object.<anonymous> (packages/__tests__/CalendarCarousel.test.tsx:18:22)

 › 1 snapshot failed.
Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `yarn run jest -u` to update them.

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   1 failed, 1 total
Time:        2.181 s, estimated 4 s
Ran all test suites matching /packages\/__tests__\/CalendarCarousel.test.tsx/i.
error Command failed with exit code 1.

Expected behavior
This test failure seems to be happening only in my terminal.
Screenshots
X
Desktop (please complete the following information):

OS: [mac OS]

Smartphone (please complete the following information):
X
Additional context
X

I think this issue is related to localization.

Oh yes! We should fix test env to English. This would be a good contribution.

#338 is related issue. How about to write test codes without comparison snapshot.

Here's a way to compare snapshots of specific parts only.
https://jestjs.io/docs/en/snapshot-testing#property-matchers


URGENT: Sub title on argosdb.org page must be removed.

This was an urgent issue in Dec 2022, and I see that the Production site has still not been updated. Please removed 'The Regulatory-Grade Database for Infectious Disease Detection' subtitle from the Home page ASAP. Thank you

@steph-sing Hello Stephanie. Robel mistakenly pushed the previous code that had issues. I have pushed the updated code again (in which the subtitle has already been removed). It's in the process of being pushed to production.

This has still not been completed. Who is this task with now, and can you point me to the ticket?


fix(rust): use runtime handles

Hopefully fixes #2996.

I was able to reproduce the error in #2996 with my very crude test:
for i in {1..9}; do RUST_BACKTRACE=1 cargo run --bin ockam node create "n$i"; done
for i in {1..100}; do RUST_BACKTRACE=1 cargo run --quiet --bin ockam node list; done

hey, @mrinalwadhwa! so you somehow still got the panics?

Trying a few runs again, with a cargo clean... just to be sure. Let's see.

can i get the backtrace if you the error again?

@twittner quite elegant (potential) solution btw! runtimes being dropped in async contexts => use static runtimes and leak them. such simplicity! :chefs_kiss:

» for j in {1..50}; do for i in {1..50}; do RUST_BACKTRACE=1 cargo run --quiet --bin ockam node list 1>/dev/null; echo -n "."; done; echo ""; done
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..................................................
..............................

@mrinalwadhwa so no panics?

yes so far none.

that's good, hooray!
question: should not the Handle::spawn method call's returned JoinHandle block forever causing problems?

@mrinalwadhwa you seem to be using --quiet flag which caused us problems before, perhaps you want to remove it?

Just finished running 2500 runs of cargo run --bin ockam node list with no failures 🎉

@pro465: [...] static runtimes and leak them

I do not think the runtime is leaked. It is owned by ockam_node::Executor and dropped when the executor goes out of scope (which should usually happen in sync code, hence the panic no longer occurs).

@pro465: question: should not the Handle::spawn method call's returned JoinHandle block forever causing problems? [...] and Runtime::spawn too?

I think so. This part is for no_std environments and I only added the Handle-part to be API compatible. Changes to the JoinHandle are out of scope for this PR I would say.

@twittner: I do not think the runtime is leaked.

i meant the runtime in no_std environments.

sorry to bother you but i have another question: how is Handle different from Arc<Runtime>?
the docs say:

The handle is internally reference-counted and can be freely cloned. A handle can be obtained using the Runtime::handle method.

so how does just using Handle fix the problem?

@pro465: how is Handle different from Arc<Runtime>?

The Runtime contains a BlockingPool which it shuts down when dropped which is itself a blocking operation that panics if used in an async context. Dropping the Handle OTOH does not cause this shutdown.

@twittner oh so that's why, i wondered why would they behave differently, so thank you for clearing it up!

@pro465 Thank you so much for all the research you put into this over the last couple of weeks!!
@twittner Thank you for the fix!! and also thank you for adding attribution to @pro465 in the commit https://github.com/build-trust/ockam/pull/3084/commits/8bd0f21ad4248e8ccab3208b35b1b500bebef63d

@mrinalwadhwa thank you so much for the encouraging and kind messages!
also @twittner congrats for fixing another issue 🎉 ! Thank you for the effort and also for the attribution!
(which, well i don't know if i deserve that, because idk if it helped you in fixing this...)


Shopping Experience: Translations Lost When Block Moved To Other Layout Section

Description
When a CMS element is moved from one layout section to another, all translations are lost.
Tested and reproduced in Shopware <IP_ADDRESS> and <IP_ADDRESS>
Additional context
This is how to reproduce:

create a new shopping experience.
add two CMS blocks (e.g. Text) and make translations in other languages.
add a new layout section and add a CMS block.
Save your work.
Use the 'Navigator' and move one of the translated blocks from one section layout to another.
Save your work.
Switch the language and be shocked that all translations are gone.

A database analysis shows that cms_slot_translation really looses data. If there were two entries (english, german) for a given slot, there is only one entry left (english) after moving the block to a different layout.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Fixed theme + migrated to newer Hugo features

Hi there,
first: Thanks for the cool theme!
I just applied the needed changes for #69 and got this theme working again.
Additionally, I did the following improvements :sparkles::

Implement native cache busting via the newer Hugo Pipes:

Use fingerprinting for the resource filenames
No additional setup needed anymore
Move to the newer assets directory:

Use the SCSS (sass) sources and convert them to CSS using resources.ToCSS
Use resources.Minify
Remove minified files where possible and only keep the sources

Remove Hugo linter warnings:

Use .Site.RegularPages instead of .Data.Pages where needed
Use .File.UniqueID instead of .UniqueID
Use {{ with .OutputFormats.Get "RSS" }} ...
Remove deprecated Hugo generator meta tag (will be injected automatically, anyways)

Pin version to Hugo 0.5 (maybe 0.43 would do the job, too)

:warning: Please test this PR thoroughly before merging into master.
I just rapidly wanted to share my changes and help out a bit, but didn't have the time to test everything.

Just a note: As already commented in the yet closed #69 I forked this theme but still wanted to fix the above bug in the original merge request regarding the contact form functionality.
This was the only bug I encountered.

Thanks for the updates @kdevo! I've just tested on my own site and merged into master.


Allow showing suppressed deletions'

#30

@kulttuuri hi, would you be able to review please? :)

@paladox @JohnFLewis Thank you! Apologies for the delay. Seems to be working well, merging! Will create a small readme mention of this parameter, too.


Update chart reloader to 1.0.69

This PR contains the following updates:

Package
Update
Change

reloader
patch
1.0.67 -> 1.0.69

Release Notes

stakater/Reloader (reloader)
v1.0.68
Compare Source
Changelog

2cfd29d Merge pull request #616 from stakater/renovate/stakater-vale-package-0.x
3630836 [skip-ci] Update artifacts
f9bd452 chore(deps): update dependency stakater/vale-package to v0.0.8

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.