Pin pyjulia version

I don't think this is the problem, the last release of pyjulia was on october 27 and the CI breaks start on November 27.
I would bet more on the julia package from conda-forge that was updated on November 23.

My bad, I misread the month.
I'm trying with 1.6.3 on the CI now. But it fails locally :(
benchopt install . -e --recreate -s julia-pgd:
done
#
# To activate this environment, use
#
#     $ conda activate benchopt_lasso
#
# To deactivate an active environment, use
#
#     $ conda deactivate

# Install
Collecting packages:
- 'Simulated' already available in 'benchopt_lasso'
... done
Installing required packages for:
- Julia-PGD
- finance
- leukemia
- libsvm
...Traceback (most recent call last):
  File "/home/mathurin/anaconda3/bin/benchopt", line 33, in <module>
    sys.exit(load_entry_point('benchopt', 'console_scripts', 'benchopt')())
  File "/home/mathurin/anaconda3/lib/python3.9/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/home/mathurin/anaconda3/lib/python3.9/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/home/mathurin/anaconda3/lib/python3.9/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/mathurin/anaconda3/lib/python3.9/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/mathurin/anaconda3/lib/python3.9/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/home/mathurin/workspace/benchopt/benchopt/cli/main.py", line 277, in install
    benchmark.install_all_requirements(
  File "/home/mathurin/workspace/benchopt/benchopt/benchmark.py", line 233, in install_all_requirements
    install_in_conda_env(
  File "/home/mathurin/workspace/benchopt/benchopt/utils/conda_env_cmd.py", line 195, in install_in_conda_env
    _run_shell_in_conda_env(
  File "/home/mathurin/workspace/benchopt/benchopt/utils/shell_cmd.py", line 130, in _run_shell_in_conda_env
    return _run_shell(
  File "/home/mathurin/workspace/benchopt/benchopt/utils/shell_cmd.py", line 68, in _run_shell
    raise RuntimeError(raise_on_error.format(output=output))
RuntimeError: Failed to conda install packages ('julia=1.6.3', 'pip:julia', 'pip:libsvmdata', 'scikit-learn')
Error:Collecting package metadata (current_repodata.json): ...working... done
Solving environment: ...working... failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: /home/mathurin/anaconda3/envs/benchopt_lasso

  added / updated specs:
    - julia=1.6.3
    - scikit-learn

The following NEW packages will be INSTALLED:

  arpack             conda-forge/linux-64::arpack-3.7.0-hdefa2d7_2
  bzip2              conda-forge/linux-64::bzip2-1.0.8-h7f98852_4
  c-ares             conda-forge/linux-64::c-ares-1.18.1-h7f98852_0
  curl               conda-forge/linux-64::curl-7.80.0-h494985f_0
  expat              conda-forge/linux-64::expat-2.4.1-h9c3ff4c_0
  gettext            conda-forge/linux-64::gettext-<IP_ADDRESS>-h73d1719_1008
  git                conda-forge/linux-64::git-2.34.1-pl5321hf874766_0
  gmp                conda-forge/linux-64::gmp-6.2.1-h58526e2_0
  joblib             conda-forge/noarch::joblib-1.1.0-pyhd8ed1ab_0
  julia              conda-forge/linux-64::julia-1.6.3-h2a39549_1
  krb5               conda-forge/linux-64::krb5-1.19.2-h48eae69_3
  libcurl            conda-forge/linux-64::libcurl-7.80.0-h494985f_0
  libedit            conda-forge/linux-64::libedit-3.1.20191231-he28a2e2_2
  libev              conda-forge/linux-64::libev-4.33-h516909a_1
  libgit2            conda-forge/linux-64::libgit2-1.3.0-haabb1ae_1
  libiconv           conda-forge/linux-64::libiconv-1.16-h516909a_0
  libnghttp2         conda-forge/linux-64::libnghttp2-1.43.0-ha19adfc_1
  libopenblas-ilp64  conda-forge/linux-64::libopenblas-ilp64-0.3.18-pthreads_h0aa5bea_0
  libssh2            conda-forge/linux-64::libssh2-1.10.0-ha35d2d1_2
  libunwind          conda-forge/linux-64::libunwind-1.6.0-h9c3ff4c_1
  libutf8proc        conda-forge/linux-64::libutf8proc-2.6.1-h7f98852_0
  mbedtls            conda-forge/linux-64::mbedtls-3.0.0-h9c3ff4c_0
  metis              conda-forge/linux-64::metis-5.1.0-h58526e2_1006
  mpfr               conda-forge/linux-64::mpfr-4.1.0-h9202a9a_1
  openblas-ilp64     conda-forge/linux-64::openblas-ilp64-0.3.18-pthreads_h3d04fff_0
  openlibm           conda-forge/linux-64::openlibm-0.7.0-h516909a_0
  p7zip              conda-forge/linux-64::p7zip-16.02-he1b5a44_1000
  pcre2              conda-forge/linux-64::pcre2-10.37-h032f7d1_0
  perl               conda-forge/linux-64::perl-5.32.1-1_h7f98852_perl5
  scikit-learn       conda-forge/linux-64::scikit-learn-1.0.1-py38h1561384_2
  scipy              conda-forge/linux-64::scipy-1.7.3-py38h56a6a73_0
  suitesparse        conda-forge/linux-64::suitesparse-5.10.1-h9e50725_1
  tbb                conda-forge/linux-64::tbb-2021.4.0-h4bd325d_1
  threadpoolctl      conda-forge/noarch::threadpoolctl-3.0.0-pyh8a188c0_0

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working...
done
ERROR conda.core.link:_execute(699): An error occurred while installing package 'conda-forge::julia-1.6.3-h2a39549_1'.
Rolling back transaction: ...working... done

LinkError: post-link script failed for package conda-forge::julia-1.6.3-h2a39549_1
location of failed script: /home/mathurin/anaconda3/envs/benchopt_lasso/bin/.julia-post-link.sh
==> script messages <==
<None>
==> script output <==
stdout:
stderr: /home/mathurin/anaconda3/envs/benchopt_lasso/bin/.julia-post-link.sh: line 1: 107000 Segmentation fault      (core dumped) "${PREFIX}/bin/julia" -e 'using Pkg; Pkg.instantiate()' >> "${PREFIX}/.messages.txt" 2>&1*
return code: 139

()

Yes and there is this update in the test log when installing R...

Technically it broke the day libunwind updated their version, but this library is also used in a lot of other packages without problem and pyjulia tests can still be run successfully.

Indeed here they suggest to install libunwind 1.5:
https://github.com/conda-forge/julia-feedstock/issues/132

Why is it still installing libunwind=1.6 despite being told to use 1.5? https://github.com/benchopt/benchOpt/runs/4394990768?check_suite_focus=true#step:6:321
The install command seems to work fine, but then when testing for the solver installation it says no module named julia, I can't understand why.

You also need to fix this one in the R solver:

Pinning version for conda is tricky, in particular with our --update-all that I had to add due to some weird behavior earlier.

This does not seem to solve the issue either: https://github.com/benchopt/benchOpt/runs/4395558762?check_suite_focus=true
And libunwind does not exist on OSX...

It does not solve it because scikit learn updates it back to 1.6.0 ? (We can't really pin it everywhere...)

Codecov Report

Merging #252 (58ebc43) into master (b4d7b14) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   63.46%   62.89%   -0.58%
==========================================
  Files          41       41
  Lines        2083     2083
  Branches      350      367      +17
==========================================
- Hits         1322     1310      -12
- Misses        664      677      +13
+ Partials       97       96       -1


Is Masked-array arithmetic getting masks wrong ?

Arithmetic operations between a dask array and a numpy array have the effect of ignoring any mask on the latter.
Like this :
>>> lazy = da.asarray([5, 6])
>>> mask = np.ma.masked_array([2, 3], mask=[0, 1])
>>> (lazy + mask).compute()
array([7, 9])
>>>
>>> # But expected ...
... lazy.compute() + mask
masked_array(data=[7, --],
             mask=[False,  True],
       fill_value=999999)
>>>

However, if we explicitly wrap the masked array as a dask array, all is well ...
>>> (lazy + da.asanyarray(mask)).compute()
masked_array(data=[1, --],
             mask=[False,  True],
       fill_value=999999)
>>>

(BUT: only using da.asanyarray : da.asarray does not work)

Just reviewing this again...

I'd advise explicitly converting numpy arrays into dask arrays before mixing them

I get the point, but shouldn't at least da.asarray then do the right thing with a masked array ?
The same applies to da.from_array : in both cases, you must  explicitly specify asarray=False to avoid it stripping the mask, and again I think this is due to an np.asarray which really ought to be a np.asanyarray.
If there's any appetite, I'll create a PR suggesting a fix.

@jcrist do you have a recommendation here?  It looks like @pp-mo is willing to do some work here, but needs the go-ahead from you.

Apologies @pp-mo, in the process of trying to recommend a fix, I ended up fixing and submitting a PR (#4506). We now call da.asanyarray on args of array types instead of da.asarray.

I get the point, but shouldn't at least da.asarray then do the right thing with a masked array ?
The same applies to da.from_array

da.asarray does the right thing in that it mirrors numpy. Calling np.asarray on a masked array also results in a numpy array. da.asanyarray is what we wanted here.
da.from_array is our own interface, and has its casting conventions due to legacy reasons. I'm reluctant to change this, but it could happen with a long deprecation period.


rename: hosted_zone_preprocessor.rs to route53_resource_id_preprocess…

Motivation and Context

aws-sdk-rust#554
Description

rename: hosted_zone_preprocessor.rs to route53_resource_id_preprocessor.rs
update: trim_hosted_zone to work for more kinds of resource ids
add: new Route53 protocol test for GetChange resource id trimming
update: InlineDependency.forRustFile to accept filenames with a ".rs" extension
Testing

I added a new protocol test
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
[x] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I had originally added the resource prefix because boto had it but I can't see anywhere in the model where that would be used so I've removed it. I also added a test for delegationset so now all 3 supported prefixes are supported


LZ infra HA active/standby: As an Org Admin I need to modify the Landing Zone shared infrastructure via promotion of the staging side of a dual prod/stg - in eviction scenarios

use case: landing zone shared infrastructure needs an upgrade that meets the threashold of workload eviction - we need an HA configuration that uses a staging or standby perimeter/management/
Note: most changes may be non-global atomic like changing firewall rules
Note: migrating workload projects under subfolders is also a separate work item depending on whether the test environment can be used for staging
Collaboration: https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/issues/165

Clarifying question, are we talking about running two LZs (dev/prod) in parallel in the same organization to be able to catch any changes that could cause a delete and replace event (ie destroy and recreate a VPC) or just different environments via project/folder structure?

Agree leveraging namespaces for this would be ideal. Shaun already put together a solution for this here which is based off the following docs for running multi-tenancy with project scoped namespaces https://cloud.google.com/anthos-config-management/docs/tutorials/project-namespace-blueprint .


Mistake in a placeholder in settings modal

Preflight Checklist

[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Describe the bug
For the email, the placeholder asks : "enter your full name" ?!

To Reproduce
Steps to reproduce the behavior:

Go to 'mumble.dev'
Click on 'settings'
go to 'edit'
Delete the fake email there
see error

Expected behavior
I expected to have : "Enter your email address"

Screenshots

#376


Incorrect window dimensions/rendering after screen resolution change

Issue Type: Bug
When launched VS Code renders correctly on either display, but after a screen resolution change the dimensions appear to be off by 4px on all sides. VS Code is maximized.

Scenario 1: Launch with single screen, 3000x2000 200% scaling, then switch to 1920x1080 100% scaling. This results in Image 1, the window renders slightly off-screen on all sides.
Scenario 2: Launch with single screen, 1920x1080 100%, then switch to 3000x2000 200%. This results in Image 2, the window renders 4px in from all sides.
Scenario 3: Launch with both displays attached and extended desktop. In this case it doesn't matter which screen VS Code initially on when launched and it renders correctly on the 3000x2000 screen, but on the 1920x1080 screen it always renders as in Image 1.

When not maximized rendering seems to be correct. Un-maximizing and maximizing the window doesn't fix it. Opening another window in the same VS Code instance has the same issue as the initial window.
This issue is new in VS Code since Electron 7 (#90412), but Electron Fiddle doesn't have this issue.
VS Code version: Code - Insiders 1.43.0-insider (1fbacccbc900bb59ba8a8f26a4128d48a1c97842, 2020-02-13T06:41:13.411Z)
OS version: Windows_NT x64 10.0.18363
Image 1

Image 2

I have a similar problem.
Display1: 38402160 (250% scaling)
Display2: 25601440 (125% scaling)
VS Code displays correctly on the Display1, but incorrectly on the Display2.(As shown in Image1 above).
VS Code version: 1.47.2  (2020-07-15T18:22:06.216Z)
OS version: Windows_NT x64 10.0.18363

Duplicate of https://github.com/microsoft/vscode/issues/85592

/duplicate https://github.com/microsoft/vscode/issues/85592


Added new Data Structures and String algorithms

Description of Change

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

Code is not up to the repository standards.
Please read them carefully and follow them.
It is recommended to make one PR per file.
This will make the review process much more faster.

My code running well on every machine but your automated compiler is not compiling my codes.
Which compiler are you using?

Code is not up to the repository standards.
Please read them carefully and follow them.
It is recommended to make one PR per file.
This will make the review process much more faster.

My code running well on every machine but your automated compiler is not compiling my codes.
Which compiler are you using?

Have you read our README and the CONTRIBUTING files that provide very detailed, itemized explanations and details along with how to execute and test the codes? they are also provided for your convenience in the checklist when creating a pull-request.
Thank you


MinGW GCC on Window

The awesome tutorial! :)
I'm using VSCode and MSYS2 MinGW.
This use MSVC for window. but, I prefer using GCC. So, I wanna get it to work.
First step in the right direction is:
Change this order of linking: SDL2 SDL2main
Into: mingw32 SDL2main SDL2
Then replace the bin and libs binary files with MinGW64 version.
It was looking for yaml_cppd but the generated from source gave me libyaml_cpp.dll
I made it look for yaml_cpp instead. Now it compile successfully.
I run the program. Nothing happened. Is this normal?
Edit:
I got it to run the game!
I looked at the bin folder, it had the game.exe and engine. Then I noticed the rest of the binaries dlls were in Debug folder.
Separate from the Game.exe. I need explanation for how this is supposed to work. Still reading the book.
Thanks! :)

Am not sure because the only time I used MinGW was with Codeblock so I can't really help there! but if nothing is happening, then it's becuse it can't find the DLL. The way you can be sure about it is by trying to execute the .exe file by double clicking on it, which will triggere a runtime assertion telling you which .dll file is missing!

Thank you, that's what fixed it.
But, when I build the program it place the game in bin folder and all Binaries and Resources inside the bin/Debug.
Then I do F5 and it tries to run the game from the Debug folder. But, it don't exist unless I move it there.
Is it supposed to run from Bin? I want to know how it was supposed to work.
I could fix it by doing this
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/Debug)
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/Debug)
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/Debug)
instead of bin.
But, is it supposed to run from bin? If it does, I want to know the purpose of it. And try to make it work.
I don't usually work with Debug mode. So, this is new to me.
Any help is appreciated!

Thanks! I already solved it. Not sure I understand the $<0:> use.
I just have question about the purpose of a Debug folder that has everything when there is a bin that don't.
The Master code is left this way.
Basically, I don't see the use of a folder Debug when I can put everything in Bin.
How it's meant to be used I'd like to know. :)
I gotta say, I've been learning C++ by myself for about 5 years on and off and really struggled with the build more than anything.
When I tried your book. I learned of a much better way to do it now. Thank you very much Sir! :)
This helped me to get into more coding and less configuring! :)

great!! am glad to hear that!


Add an option to simply ignore unknown arguments

I need an option to silently ignore unknown arguments. Simply conditionally rethrowing the exceptions from the args parser functions is probably only suitable as far as those only throw due to an unhandled argument (which is currently the case), so I'm not sure if there is a better way to achieve this...

Thanks, merged.


[MVP] Tail and streams logs from kinesis

This doesn't handle yet:

filtering by process type
killing the kinesumer goroutine when request is close

This is looking really awesome. I think it would be good to follow up with updating the demo cloudformation stack to use the empire ami and add logspout with kinesis enabled on that. But, probably not necessary for now.
Might be good to roll this branch out on staging for a bit to play around with it, but otherwise. :+1:
(could use some docs about how to use kinesis log streaming).

@ejholmes I'd love some docs on that!


fix: Attach kube-aws controller policy to pre-existing IAM role

Fix for custom kiam role feature
Why
When I worked on the custom kiam role PR I overlooked the fact that kube-aws autogenerates the controller policy:

By default, kube-aws will create an IAMManagedPolicy for the controller, after it creates an IAMControllerRole and attaches the ManagedPolicy to it.
If you use a pre-existing role (through the useStrict feature implemented in the custom kiam role PR), the IAMManagedPolicy gets generated, but it does not get attached to any role. It would be up to the developer to manually attach it in the console or through the aws cli. Moreoever, since the controller policy will always have a randomly generated name it complicates things.

In my personal opinion this is a bug. When using a pre-existing IAM role everything should work just as before.
What
To fix this, I added an if condition in the stack-template. When creating the ManagedPolicy:

If we are using a pre-existing role, and if that role name is in our cluster.yaml, then we attach the policy to our role, on creation.
If we are using the kube-aws generated role, then the behaviour is the same as before.

I'm open to suggestions if there is anything else that should be added in or changed. I personally regard this as a bugfix, apologies for overlooking this detail in the first place when I implemented the custom role feature.

Codecov Report

Merging #1448 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   38.26%   38.26%
=======================================
  Files          74       74
  Lines        4565     4565
=======================================
  Hits         1747     1747
  Misses       2576     2576
  Partials      242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57fef49...98f8a2d. Read the comment docs.

@Matei207 Does this mean that, now, all you need to do before running kube-aws is, just manually creating an IAM role with no policy attached? Is the IAM policy managed by kube-aws automatically attached to the existing IAM role?

@mumoshu in short, yes!
We use a cluster provisioning tool that wraps around kube-aws. The main use case is to initialise our cluster.yaml file, in addition, it also creates our IAM roles (such as external-dns, S3 bucket access etc), so our roles are on the aws account before the cluster rolls out.
This is what I have in my cluster.yaml and what I used to test this fix:
controller:
  iam:
    role:
      name: us-west-2-md-KiamTrust
      useStrict: true

When I rolled out my cluster with the above configuration, the controller policy created by kube-aws was attached to my (existing) us-west-2-md-KiamTrust role. The role also got attached to the EC2 instance through the InstanceProfile arn.
So, all that I had to do was create a role, pass that role in my cluster.yaml and let kube-aws generate the policy and attach it to the EC2 control-plane instance 👍

@Matei207 Thanks a lot for the explanation and contribution! Good to know that cfn is able to attach iam policies to existing roles. This is AWESOME!

@Fsero After seeing how this works, I wonder if we could rename today's iam.role.name to iam.role.namePrefix, and instead use iam.role.name for the behavior of useStrict: true. WDYT?


Version 2 Release

Version 2 of the code will be released prior to starting development on version 3. The following needs to be finished:

[x] Merge all open pull requests
[x] Create version 2 branch @rombur
[x] Create a new website @rombur @dalg24
[x] Publish version 2 documentation and development version on the new website @rombur
[x] Make clear in documentation and on front page README that the version 2 branch is a stable release and the master branch is for development and is subject to changing interfaces and data structures. @rombur @sslattery
[x] Update the front page README to link to the stable version and add link to the tarball @Rombur ur
[x] Add version 2 to CI build system for any changes to branch and pull requests/bug fixes @dalg24
[x] Create announce mailing list
[x] Announcement of version 2 release

What are the current blockers for this?

I have some pull requests with some bug fixes I need to get in. I think we decided to wait on the build issues for now.

It would be nice to document what needs to be done so that we can track the progress.

@sslattery anything blocking the announcement of version 2?

yeah too many meetings haha. will do today

Maybe update with Github DTK wiki?

should we just get rid of the wiki?

What was its original purpose?

Not sure but it looks like it overlaps with our read the docs so we may want to delete it to avoid confusion and duplicated effort. Looks like it hasn't been updated since April. Any thoughts @dalg24 ?

@dalg24 is on vacation in France for two weeks.

I wouldn't bother with the wiki for now.  I agree with Stuart.


merge the jetty6 upgrade branch to trunk

Thank for the review by Manik, especially "use ExecutorThreadPool instead of QueuedThreadPool" for better performance in the Jetty 9.2.6

fixed the ant build

Thanks for fixing the things that @maniksurtani pointed out.  I agree with all his comments.
The pull request also needs to be done from a feature branch, not from your forked master, because otherwise it's susceptible to getting polluted by unintended later changes (e.g. your removal of openjdk6 from the Travis config which might have been intended to be a purely local change).  Each feature branch/pull request should include a single coherent set of changes without any unrelated changes.
We won't be updating any dependencies until after the 2.6 release, but that should happen very soon.  At that point I'll be doing a major dependency update and probably another relatively quick release, so these code changes will come in handy then.

Agree. The feature branch make perfect sense.
On Sun, Jan 25, 2015, 12:19 PM Tom Morris<EMAIL_ADDRESS>wrote:

Thanks for fixing the things that @maniksurtani
https://github.com/maniksurtani pointed out. I agree with all his
comments.
The pull request also needs to be done from a feature branch, not from
your forked master, because otherwise it's susceptible to getting polluted
by unintended later changes (e.g. your removal of openjdk6 from the Travis
config which might have been intended to be a purely local change). Each
feature branch/pull request should include a single coherent set of changes
without any unrelated changes.
We won't be updating any dependencies until after the 2.6 release, but
that should happen very soon. At that point I'll be doing a major
dependency update and probably another relatively quick release, so these
code changes will come in handy then.
—
Reply to this email directly or view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/934#issuecomment-71381878.

@jackyq2015 what is the status of this PR?

Close it for now due to the file confliction. Separated PR needed to do the library upgrade.


Make rpc::Client and SubscriptionClient traits usable in wasm

Description
Currently it's impossible to implement those traits in wasm as by default async_trait imposes the Send bound. This, however, makes it unusable in wasm. Therefore I propose introducing conditional compilation based on target:
#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
pub trait Client { ... }

Definition of "done"

Thanks for the issue and associated PR, looks good!
For my own knowledge, would mind going into a bit more detail as to why Send bounds on result types of desugared async fns prevents implemented them when targeting WASM? I am asking because that's the first time I hear about that and I am genuinely interested in understanding why.

Hi, I'm extremely glad you asked because turns out there was a bit of misunderstanding on my end. It's actually not a wasm32 target-wide issue, but is related to the futures created by wasm-bindgen that are then run in the browser: https://github.com/rustwasm/wasm-bindgen/issues/2833 I've been dealing with those for so long that I forgot other targets exists 😅 So I assume that, for example, under wasm32-wasi this isn't a problem at all. So perhaps, rather than making the trait boundary be target locked, a feature-lock solution would be more appropriate. What do you reckon?

AFIT is shipping in Rust 1.75, FWIW. That's a couple weeks away and will obsolete async-trait.

Let's merge this as-is and we can revisit once Rust 1.75 is out and we decide to bump the MSRV.


EveXML: SkillTraining StartTime and EndTime always MinDate

I think the reason is that the attributes:
[XmlElement("StartTime")]
[XmlElement("EndTime")]

Should look like:
[XmlElement("trainingStartTime")]
[XmlElement("trainingEndTime")]

Documentation: Eve Online Developer Documentation

Thanks, I'll have a look tonight.


Music Player Service

This will be 100% JavaScript if this package lets me down https://github.com/KristofferStrube/Blazor.WebAudio

lol already implemented by accident


feat: Enable dependabot third party package scanning

References:

https://docs.github.com/en/github/administering-a-repository/about-dependabot-version-updates
https://docs.github.com/en/github/visualizing-repository-data-with-graphs/about-the-dependency-graph#supported-package-ecosystems

LGTM. Do we have any submodules though?

Yes, added. Thank you!


Number of classes

Hello, thank you for your work!
I have a small datsaset containing only one class of instances (trees). I looked in the code and it seems like the number of classes in the VIsionTransformer is always zero (num_classes=0). Is this normal? I am not sure I understand the difference between the num_classes and num_labels used in the eval script.
Thank you

I think the number of classes you have to try is 1 greater then that of orignal number of label like for you it will be 2 (number of classes ) dn_labblebook or so parameter must be = or > number of classes


Commit are too much verbose since the latest update

Hey 👋
I think commit message should stay concice and short cf https://cbea.ms/git-commit/
Change in my code
const joinClanButton = new ActionRowBuilder<ButtonBuilder>()
    .addComponents(
        new ButtonBuilder()
+            .setLabel(`Rejoindre ${clan.name}`)
-            .setLabel(`Rejoindre clan name`)
            .setStyle(ButtonStyle.Link),
     );

Here mutliple result I feel to much

The only change in this code is the label of the joinClanButton. Instead of a fixed label "Rejoindre le Clan", it now uses a dynamic label that includes the name of the clan: Rejoindre ${clan.name}. This makes the button more informative for the user and helps to differentiate between multiple clans. No other changes were made in this file.

344 CHARACTERS

The change in this diff is a simple update to a label in a Discord embed message. The label for a button that allows users to join a Clash of Clans clan is updated to include the name of the clan. This change makes it clearer to users which clan they are joining when they click the button.

290 CHARACTERS

The change in this commit modifies the label of the "Join Clan" button in the embed message sent by the BrulerieBot. Instead of just displaying "Rejoindre le Clan," it now displays "Rejoindre" followed by the name of the clan. This change makes it clearer to the user which clan they are joining when they click the button. No other changes were made in this commit.

366 CHARACTERS
All of theses commits message would not fit a git history, github commit page, or anything that list commits
Would you like to make some changes on this? 🙏
Is there a way to downgrade to 0.4 on the build 231 ? 🤔

I completely agree with you about how the commits should look like. Really interesting that you noticed this change after the latest update, since I haven't changed any of the logic around commit message creation (or at least I think so). The only explanation would be, that the OpenAI model has changed somehow.
I will add an option for setting your own prompt for OpenAI so you can experiment and change it to your needs.
If you would like to try to downgrade to previous version of the plugin, you can do so by following the steps in the readme: https://github.com/Blarc/ai-commits-intellij-plugin#installation-from-zip.
Thanks.

@Blarc Are you sure that OpenAI changed something?
I'm still using aicommit where I found your project here https://github.com/Nutlope/aicommits/issues/73
With their latest version that still look fine

If you have a new build to try I have a ton's of untracked files I could add to my repo and give you feedback 👍

@Blarc I tried your exact promt with one line change and the result is what I expect,
I may think getPrompt is not called correctly?

You used git diff to compute the diff based on which the commit message was generated, correct? Because plugin uses Intellij's implementation for computing the diff. Maybe that's the problem?

Yes I used git diff
Can you log what Intellij's implementation for computing the diff gave you comparing to git diff ?
You added this to v0.5 ?

@Blarc Can you log the full promt ? with your prefix in getPrompt
Note that the latest builds of Jetbrains IDE have changes in Git
https://www.jetbrains.com/phpstorm/whatsnew/#version-2023-1-vcs--git--github
Could the two first lines breaks the formattings somehow to a regular git diff from the CLI ?
- Index: src/games/mine/Mine.py
- ===================================================================

Ok, I found the bug. It's embarrassing: https://github.com/Blarc/ai-commits-intellij-plugin/blame/d200ef840b685cff10f9ccbd62d249a052d61d46/src/main/kotlin/com/github/blarc/ai/commits/intellij/plugin/AICommitAction.kt#L58
It should be prompt instead of diff here.
Will release bugfix asap. Sorry for the inconvenience and thanks for the help.

Fixed in: https://github.com/Blarc/ai-commits-intellij-plugin/commit/a759819a19afbcca6ec6f368caa52d0e15caebb8.


Docs/code formatting

Update Android Readme intro (see visual rendering here):

Move build badges to top of readme
Display the upgrade note in italics
Add contributing guidelines, referencing formatting configuration

@clement-leprovost: does this LGTY?

Closed as this should now be done on the docs repository.


feat(jvm): Add functionality to InstructionList.

Add exit_point to return the last instruction in the list.
Add prev_pc_of to return the program counter of the previous instruction before the given one.

Fixed DCO issue - had it set up incorrectly, so future PRs should not fail this from now on.

Thanks for your contribution. I have some concerns regarding these two new functions. Please check my comment below.

My sign off keeps breaking, I'll try and fix that later. 😓
How about changing the exit_point function to last_instruction, to make it more explicit.

Alternatively, I am thinking if we should implement Deref<Target = BTreeMap<ProgramCounter, I> for InstructionList<I> instead.

Alternatively, I am thinking if we should implement Deref<Target = BTreeMap<ProgramCounter, I> for InstructionList<I> instead.

I think that would be usefull, although I've never implemented the Deref trait before so that might be down to a later commit. 😅

Alternatively, I am thinking if we should implement Deref<Target = BTreeMap<ProgramCounter, I> for InstructionList<I> instead.

I think that would be useful, although I've never implemented the Deref trait before so that might be down to a later commit. 😅

Let's do it in the future

The current functions look good. Could you add test cases for these two functions? You may add the test cases at the bottom of this file. There are already a few test cases there.


Builds failing since the last image push

I'm getting Unable to find image 'eawsy/aws-lambda-go-shim:latest' locally latest: Pulling from eawsy/aws-lambda-go-shim Status: Downloaded newer image for eawsy/aws-lambda-go-shim:latest lambda.go:17:2: cannot find package "github.com/eawsy/aws-lambda-go-core/service/lambda/runtime" in any of: 	/usr/local/go/src/github.com/eawsy/aws-lambda-go-core/service/lambda/runtime (from $GOROOT) 	/root/go/src/github.com/eawsy/aws-lambda-go-core/service/lambda/runtime (from $GOPATH)
using the latest image.  No problems before that.

Seems like the last success we had was 9 days ago.  Sha was the last successful build that worked. 37dda5fddfd77f0c5eb977b0faddf033e3b016ec

Have you also updated your makefile to the latest version?

I missed that, thanks for the help


Muscle-driven steerer

This is currently not behaving correctly. I've turned the muscles off (set so their F_max is 0.0) and turned the steering torque off (set cA and kA to 0.0). With g=0.0 the model is stationary during simulation (as expected). With g=9.81 the arm extends from an initial stationary position, even though this magically adds both kinetic and gravitational potential energy to the system.


Collection attribute picks wrong 'td'.

I am trying to parse a table.
collection :opportunities, 'table tbody tr' do
  attr :title, 'td:eq(0)'
  attr :buyer, 'td:eq(1)'
  attr :expression_start, 'td:eq(2)'
  attr :expression_end, 'td:eq(3)'
  attr :estimated_value, 'td:eq(4)'
end

here 'td:eq(0)' being the first 'td' in the table row. Raspar is left shifting the tds. ie. title is being assigned the value of buyer. "$('table tbody tr:first td:eq(1)')". Is this an intended behaviour or a bug?

Nokogiri supports parsing index from 1. There is no zero index for elements. It works same as CSS selectors.

Ok. So the issue might be from nokogiri and not raspar.

This is a known issue in nokogiri. It has been reported here.


error?  transPoseFwd

Error using transPoseFwd (line 14)
length(T) must be the same as size(oldPose,1)!
what's wrong?

Not reproduced

Never reproduced

First, at my side I never observe such error and hence I cannot give explicit explanation to the problem.
Since I have received more than two bug reports on the same issue in function getTransViaMerge, I believe there might be something wrong in it. Currently I did some modification to the function and I believe the problem might be solved.

Thank you to answer my question , I solve the problem with matlabpool;
Thanks

Yes! That is precisely the cause! Thank you very much for the discovery.
The problem is due to our very old version of codes (without using parpool) that output row vector of transform objects rather than a column vector, a standard form we apply in our subsequent implementations. Hence, other functions would prompt error if they find the size of the first dim of transformation objects is not equal to the number of samples.
Since we always use matlabpool enabled environment all later, we didn't find the problem until now.
So, to force all Ts in getTransViaMerge to be column vector seems to be the fastest way of solving the problem.
Sincerely thanks to your discovery!

You're welcome.  BTW ,Thanks to your open source code. Great job!

Thanks for you appreciation! :)
We are so glad to find that our codes can provide help to this area.


added graph countries API

Added a new graph countries API

[ x] Your submissions are formatted according to the guidelines in the contributing guide
[ x] Your additions are ordered alphabetically
[ x] Your submission has a useful description
[ x] The description does not end with punctuation
[ x] Each table column should be padded with one space on either side
[ x] You have searched the repository for any relevant issues or pull requests
[ x] Any category you are creating has the minimum requirement of 3 items
[ x] All changes have been [squashed][squash-link] into a single commit

Just a friendly reminder that you can edit PRs and force push them so that you don't need to open 3 PRs.

Hey Sandro, sorry for that!


use Minitest instead of MiniTest

the rename happened in 5.0, but 5.19.0 started to only define the old alias when ENV["MT_COMPAT"] is defined, which usually is not the case

@ordinaryzelig here's a failing pipeline for you to double check against: https://github.com/simonneutert/papierkram_api_client/actions/runs/5859933192/job/15886957088?pr=56

I did some cleanup first, and then applied your changes in https://github.com/ordinaryzelig/minispec-metadata/commit/f3863bd7b1d324e3ab1b592f53348a82687c87dd. Released v3.4.0.
Thanks.


python311Packages.sunweg: 1.0.0 -> 2.0.0

Diff: https://github.com/rokam/sunweg/compare/refs/tags/1.0.0...2.0.0
Changelog: https://github.com/rokam/sunweg/releases/tag/2.0.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 242023 run on x86_64-linux 1

4 packages built:

python310Packages.sunweg
python310Packages.sunweg.dist
python311Packages.sunweg
python311Packages.sunweg.dist


Add basic logging abstraction

Describe what this PR does / why we need it
For MVP, I think we could wrap the SDK log and provide the standard log interface. In future, we can upgrade with minimal cost.
Does this pull request fix one issue?
Fixes #10
Describe how you did it
Describe how to verify it
Special notes for reviews

Thanks!


docs(guide/component): add replace attribute to comparison

Add replace attribute to comparison between Directive definition and Component definition.

Thanks for the contribution @Puigcerber
Replace is deprecated. We wish it wasn't there. We don't want to advertise it in the documentation.
So I'm afraid that we not going to merge this PR.

No problem! I thought that might be the reason but still it was weird not to see it in the comparison. Cheers.


Volume and quality change controls are not visible in mobile

I am using videogular for my website. I have integrated vg-quality to switch between different resolution videos. Everything is working fine in standard browsers (desktop and laptops). But quality change and volume controls hides in mobile browsers (iOs and Android). I have added vg-native-fullscreen="false" in
videogular tag, but it's still not showing controls.
Please guide me to show them in mobile as well.
Thanks
Harpreet Gill

It's not possible to change volume through JavaScript on mobile devices so we hide volume controls by default on mobile devices.
Quality change is not developed by us so maybe you should consider to open this issue on that repository.

Thanks for reply.
I managed to show quality controls on mobile by directly changing code in vg-quality plugin.


Broken Link

The link to GetDeviceSelector is broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb227cd6-7c71-1e7e-8ea3-14f188ac8bb3
Version Independent ID: fcfc983b-22e2-174a-1457-18ab3885f1c5
Content: DeviceInformation.FindAllAsync Method (Windows.Devices.Enumeration) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.devices.enumeration.deviceinformation.yml&version=GBlive&_a=contents
Product: windows
Git Login: wdg-dev-content
Microsoft Alias: wdg-dev-content

Thanks for letting us know. Should be fixed now.


feat: Add state persistence for the identity tab

It's deployed successfully on cloudflare pages preview, I just checked in cloudflare pages dashboard. Maybe some bug in CF Integation. We should be good to merge this one in @askolesov

@jay-dee7 Cool, tanks! Am I right that main is deployed to production? If so, maybe let's accumulate changes in a dev branch? Just wanted to double-check. What are your thoughts?


Change New execution in instructions to Start execution

While going through the workshop, I noticed that the New execution button is now Start execution.

Thanks for this, seems accurate to me and so merging.


build: Add bazel option for enabling Universal Header Validator

Additional Description:
This config setting enables Universal Header Validator and disables HTTP header compliance checks in codecs.
This setting is temporary to transition header validation into UHV without impacting production builds of Envoy.
This setting is enabled for the bazel.compile_time_options CI target.
Risk Level: Low, build options for compile_time_options CI target
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #20261
Signed-off-by: Yan Avlasov<EMAIL_ADDRESS>

lgtm -- probably wait till post release to merge since this doesn't seem to have any effect yet?

@zuercher when is the release? There are a couple of PRs blocked by this.

Happening now.

Merging since release was completed, for Monday work.


net: samples: zperf: Refactor to use socket API

Refactor zperf sample to use socket API instead of net_context directly. Additionally, submit 2 fixes that help to retain performance when socket API is used:

Add k_yield() in the RX thread to allow other threads to run when bulk of packets is queued for processing.
Avoid unnecessary packet cloning on the TCP RX path

I can split the fixes into individual PRs if requested.

@erwango I've noticed that with eth_stm32_hal.c driver I can get even better download results if I enable HW checksum calculation (ETH_CHECKSUM_BY_HARDWARE) and add RX checksum computation to the capabilities (ETHERNET_HW_RX_CHKSUM_OFFLOAD) - up to 85 MBit/sec for TCP download - I really doubt we could get any better numbers for 100Mbit Ethernet.
I'm not familiar enough with the driver to tell if those changes are enough, or if there are any other consequences that I don't see - do you think it's ok to make such changes in the upstream driver?

That's a good result indeed.
I think this configuration is default since the driver was first upstreamed. I'm not sure about the drawback to convert to these settings. What can be done would be to add this as a configuration option, defaulting to this news values. People seeing adverse effects will be able to report and switch back to the previous settings.


change the sign in button on the front page

there should be proper spacing between sign in text on the button on the front page
Screenshot (9)

please assign me this issue

@abhisar-yadav some failed checks have been do go through that once...and confirm me ..


feat(docs): add accessibility section for pagination component

Closes #1569
Description

[HELP]
I'm sorry, I'm not sure how to adapt the changed content to the document. As a result, I haven't been able to provide a screenshot, and I haven't confirmed how the changes are displayed myself.
Also, I'm not certain if I’ve included everything I needed in the document. Please let me know if there’s anything missing or if there’s too much.
Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

Additional Information

English version:

Japanese version:

@mei28
Check this out too.

I think table content is something wrong.
refarence: https://yamada-ui.com/ja/components/data-display/stat/accessibility

Do I only need to document the section below in this case?
https://github.com/yamada-ui/yamada-ui/blob/74c0ae30a7cd171e01dd52582c8108dbe45c6a3b/packages/components/pagination/src/pagination.tsx#L128-L130

@mei28
I think format of the table contents is wrong.

@hirotomoyamada
Do I need to include the content from the link regarding keyboard accessibility, like in the following example: https://mui.com/material-ui/react-pagination/#accessibility?

@mei28
Hi, either is fine. It is cooler if it is stated.

I added a style for em inside code as follows:
<Text
  as="code"
  apply="mdx.code"
  dangerouslySetInnerHTML={{ __html: props.children }}
/>

I'm not sure if this is the correct approach, so if there’s a better way, please let me know.


⚠ SceneTime has degraded performance

In 2b2ffcd, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1503 ms

Resolved: SceneTime performance has improved in 616458d after 9 minutes.


Pull chart image

Description:
We are trying to pull the stable version of  Helm Stable doing an helm repo add stable https://charts.helm.sh/stable but we are getting this error:

Error: looks like "https://charts.helm.sh/stable" is not a valid chart repository or cannot be reached: context deadline exceeded (Client.Timeout or context cancellation while reading body)

Output of helm version:
version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.21.9"}
Output of kubectl version:
Client Version: v1.30.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.):  N/A

First, I am unable to reproduce the problem. I am able to add the repository.
Second, that Helm repository has not been maintained in years. The software in there is out of date. You can find newer versions over at https://artifacthub.io


bcrypt 0.8.4 not working on Ubuntu

Hi,
I'm running bcrypt 0.8.4 (also tried 0.8.3) with Node 0.10.40 and NPM 1.4.28 on Ubuntu 14.04.1 LTS, and I'm having issues getting bcrypt.compare to work.
The callback parameter compareResult (below) is just returning false, even though I know that the password is definitely correct, and err is coming back as null. No errors are thrown at all, not even on install.
Weirdly, is does work locally on OSX 10.10, running the same versions.
The issue is resolved, however, by reverting bcrypt back to 0.7.8.
bcrypt.compare(password, user.password, function (err, compareResult) {
    if (!compareResult || err) {
        res.json(result);
        return;
    }
    /* .... */
});

Probably something else in your code. Without a failing example unfortunately not much can be done.

Ok, I'll take another look at my code.
As I mentioned, it's strange that the latest version (0.8.4) works when I run it on my Mac, but not on the Ubuntu server. The Ubuntu server seems to only work correctly with bcrypt 0.7.8.


Cocoapods compiler issue

Hi, I'm using cocoapods for my library but when I try to do pod lib lint I get compiler error from a promise kit class, here is the log
** BUILD FAILED **

The following build commands failed:
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
CompileSwift normal x86_64 /var/folders/mr/msg44lgs0gqg_2y508cl685w0000gn/T/CocoaPods/Lint/Pods/PromiseKit/Categories/Foundation/NSNotificationCenter+Promise.swift

her is my podspec
Pod::Spec.new do |s|
  s.name             = "ExpSwift"
  s.version          = "1.0.2"
  s.summary          = "Exp IOS SDK library. Native IOS library for EXP platform."

  s.description      = "Exp IOS SDK library. Native IOS library for EXP platform will allow you to   communicate directly to EXP platform."

  s.homepage         = "https://github.com/ScalaInc/exp-ios-sdk"
  # s.screenshots     = "www.example.com/screenshots_1", "www.example.com/screenshots_2"
  s.license          = 'MIT'
  s.author           = { "Cesar Oyarzun" =><EMAIL_ADDRESS>}
  s.source           = { :git => "https://github.com/ScalaInc/exp-ios-sdk.git", :tag => 'v1.0.2' }
  # s.social_media_url = 'https://twitter.com/<TWITTER_USERNAME>'

  s.platform     = :ios, '8.0'
  s.requires_arc = true

  s.source_files = 'Pod/Classes/**/*'

  # s.public_header_files = 'Pod/Classes/**/*.h'
  # s.frameworks = 'UIKit', 'MapKit'
   s.dependency 'PromiseKit','3.0.0'
   s.dependency 'Alamofire','3.1.5'
   s.dependency 'Socket.IO-Client-Swift','4.1.2'
   s.dependency 'JSONWebToken','1.4.1'
 end

Dupes #415


Delete old pages that are serving as dummy data

For https://github.com/Starcounter/CompanyTrack/issues/316
There are now several pages in the dynamic directory that act as dummy data. Delete these pages and create one page to act as an example page.

Fixed with 	5d539dd


Direct access to model's UPDATED_AT

This PR is to direct access to Model::UPDATED_AT
Some project may not use Laravel's default column name as "updated_at" and it is troublesome for the user to replace custom "updated_at" on each search created.
From
$results = Search::add(Product::class, 'CHEMICAL', 'UPDATEDDATE')->get('resist');

To
$results = Search::add(Product::class, 'CHEMICAL')->get('resist');

Model
class Product extends Model
{
    const UPDATED_AT = 'UPDATEDDATE';
}

Cheers.

Hi,
How can I fix it? It's working on my local though.

Hi,
How can I fix it? It's working on my local though.

This is fixed in v2 (check the upgrade notes).

This is fixed in v2 (check the upgrade notes).


[GH-15906][MM-22844] Add channel_icon for email notification redesign.

Summary
Add channel_icon. It is required to display channel icon in emails.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/15906
cc: @nickmisasi @ogi-m

LGTM! Thanks @jp0707!


Update keywords for iNS split forms

There are some inconsistencies in the code regarding the split forms for the incompressible Navier-Stokes equations. With this PR, the split forms called skew-symmetric-1split and skew-symmetric-2split are now skew-symmetric 1 and skew-symmetric 2 everywhere.

This is more complex than we expected. The tests are also failing for other reasons not related to the names of the averaging functions. Some of the control files seem to be wrong, and their names do not always match the ones in the workflow.

I am aware of the naming problem of the control file in the workflow, I'll fix that. What about the other things? All fixed then?

Everything seems to be fine with the last fix that you pushed. The control files were fine, just a silly mistake from my side... Now there is an issue with the VTKHDF module of horses2plt, but I will work on that on a different PR.

@Andres-MG, the error we are getting is weird and doesn't seem to have anything to do with what you changed right?

I think so. It seems that this test has not been run for some time, so I assume this issue is not new. The difference between the expected and the actual values is small, maybe it is not an error...

I would bet it works with ifort and not with gfortran

BTW, it runs in flexo with ifort + mkl

I think that this works with both, maybe the problem is that intel+MKL and gfortran use different libraries and the numerical errors are different.


API-access to the play queue?

Is there a way to remove tracks from the play queue using the API?
I see that I can add a track with the play_at_index function, but an api-call to remove a track from the queue seems to be missing.
I can replace the entire queue, but that interrupts the currently playing song.

After some experimenting, it seems like the play queue is not manipulable at all, except replacing it completely. Would nice with a way to add/remove entries in the queue using the API, just like you can do in the local client.


feat: 🎸 added commit to package.json

Now you can use npm run commit to add commit messages if you are
unfamiliar with commit rules

please let me know if there are some more issues that i can work on


Update Pi-hole to 2021.09

The tag format has changed, see these release notes:
https://github.com/pi-hole/docker-pi-hole/releases/tag/2021.09
Resolves: https://github.com/klutchell/balena-pihole/issues/90
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

dude do you update PADD to Version 3.6.2 too?

dude do you update PADD to Version 3.6.2 too?

@clipse2004 Planning another PR for that, one thing at a time. Though maybe it wouldn't hurt to include it here...

Been testing it since you opened it - No problems here!
(LTGM [I had to Google this])

@eiddor Could you try soaking this release as well?
I've seen no issues so far but I'm also keeping an eye on the official docker-pihole-repo.

Dear Kyle could you please squash your commits ;-)

Haha, no, I want these ones separate for tracking history.

I'll have to remember that "reason."  haha

I would argue that they are each unique changes that were almost worthy of separate PRs!
Also, because I said so.


[DOC] New system property: opensearch.xcontent.fast_double_writer.enabled

What do you want to do?

[ ] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request.
Provide the documentation for recently introduced new system property opensearch.xcontent.fast_double_writer.enabled that allows to configure using fast double serialization features which provides better performance for serialization of floating point numbers.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
Covered in issue: https://github.com/opensearch-project/OpenSearch/issues/7822

Hi @mgodwan - Is this being introduced in version 2.9?

Yes, The changes have been merged already: https://github.com/opensearch-project/OpenSearch/pull/8467#event-9746205752

@mgodwan Where would the new documentation be published on the doc site? Also, will you link me to the feature brief and dev docs?

First, the issue description is incorrect: the system setting is opensearch.xcontent.fast_double_writer (no .enabled suffix). code link

Also, will you link me to the feature brief and dev docs?

@vagimeli There is no feature brief to my knowledge. This is a pretty low-level performance improvement and a system setting was added to alleviate concerns around potential incompatibilities.
I think it is logical to group it with the existing opensearch.xcontent setting documentation. I would document this something like the following:

opensearch.xcontent.fast_double_writer=[true|false]

By default, OpenSearch uses the floating point parsing capability built in to the Java Runtime Environment. Set this value to true to configure OpenSearch to use the FastDoubleParser library to parse floating point numbers, which has shown to be faster in many cases.

@mgodwan A couple questions for you:

This property defaults to false. Is that correct? The original issue talked about adding a property to enable users to opt out on 2.x versions, but it was implemented as an opt in. Please confirm that this is correct.
Can you give some guidance as to when a user should or should not enable this setting? I think the testing has shown it to be faster, so why would a user not want to set this?

Thanks @andrross for pointing to the correct name of the property.
I've updated the issue title/description.

Where would the new documentation be published on the doc site? Should it be added to https://opensearch.org/docs/latest/install-and-configure/install-opensearch/index/#important-system-properties?

@vagimeli Yes, this seems to the correct place since we are already adding other system properties related to xcontent in the same place.

This property defaults to false. Is that correct? The original issue talked about adding a property to enable users to opt out on 2.x versions, but it was implemented as an opt in. Please confirm that this is correct.

@andrross Yes, we decided to make it an opt-in property to reduce the blast radius. This property only deals with floating point serialization (and not parsing which is always enabled as we didn't observe differences in the parsing of floating point numbers compare to java code)

Can you give some guidance as to when a user should or should not enable this setting? I think the testing has shown it to be faster, so why would a user not want to set this?

Possible description we can add for this can be:
The property can be set  to determine whether to use standard Java code to write floats/doubles (default) or use the Schubfach algorithm which is faster. The latter approach may lead to small differences in the precision of the float/double that is written to the JSON output.


fix(esl-animate): fix handling of esl-animate-mixin attribute changes

:tada: This PR is included in version 5.0.0-beta.15 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


C# WASM support

Describe the feature
C# can pretty easily build to WASM, and StereoKit's native side can currently build to WASM as well (simulator only for now). Building StereoKit projects with C# WASM at this point should just be a matter of shipping Emscripten built WASM binaries and linking them up properly with MSBuild!
Docs have been somewhat lacking in the department, as native library support is somewhat new. It may be time for another look at this to see if the docs are any better. Here's the official docs for this particular topic.

Prebuilt dependencies typically must be built using the same version of Emscripten used to build the .NET WebAssembly runtime.

This may have been the main roadblock from last time I attempted this.

Hi Nick, bumping this issue since I think working with Blazor would be a super nice feature of SK and we’ve already received many requests for a mobile app which could be accessed via WebXR!
What are your latest updates on generating different C# DLLs / the binding system in general?
Would love to help push this feature. I was wondering if there’s some intermediary C# binding that we can create, that can be a bit manual, but it’d give a workaround C# DLL that could be used for adding in the all of the webxr backend in the meantime?

So I put together a small project that lays out the current problem: https://github.com/maluoi/SimpleCSharpNativeWASM
In particular, passing a C# lambda into a native callback, like so: https://github.com/maluoi/SimpleCSharpNativeWASM/blob/main/Program.cs#L15
It kinda seems like this may be an outstanding issue for .NET 7, with potential fixes inbound in 8? There's a solution mentioned here, but it looks kinda rough. I still need to muck with this a bit more, but a nice packaged solution for doing this, while remaining compatible with other platforms needs to be settled on.

Hi @maluoi, just jumping in on the conversation. The issue you have there looks similar to something I encountered when wrapping BabylonJS for Blazor. I got it working in the end with events/callbacks and with lamdas.
Did you have a direction to keeping compatibility with other platforms?
If there is a direction then I can contribute some time to building out support for Blazor as a platform.

My primary worry for compatibility here is UWP, which can be a bit of a tricky one. This basically requires netstandard2.0 or older, and unfortunately cuts off a lot of newer C# features that I'd really like to use! I'm uncertain how big of an obstacle this might be to WASM, but I've kinda suspected it could be an issue.
Do you know, how separable is Blazor from C# WASM? I thought I was able to do C# WASM without Blazor at all, since Blazor is more of a framework, right? Or are you just using Blazor as a shorthand for web support here?
SK's WebGL support may be a bit spotty at the moment as well, I haven't really tested it a whole lot lately!

Hey @maluoi. I had a look over the weekend and started with updating the branch feature/cs_wasm2 with the latest from develop in order to get the StereoKitTest_Web project working. After adapting the cmake process I have had it build and launch into a browser. However, have been stalled with a runtime error: null function or function signature mismatch when calling the native matrix_trs method, except when using RunAOTCompilation & RunAOTCompilationAfterBuild (see below). While I haven't got as far as you had with the simulator running, I have learned a fair bit about Blazor/WASM, the highlights are:

I understand Blazor as meaning C# WASM. It seems to encompass:

the dotnet build tools/targets that uses emscripten to compile the runtime (Mono) and native libs (like StereoKitC) into WASM
adding a javascript to bootstrap and download the runtime and C# libs.
tooling for debugging remotely in the browser

Emscripten doesn't appear to be forward compatible. I reckon if this gets to the point of distributing then a highest Emscripten version to build with needs to align with the lowest target .NET Blazor workload. NET7 uses 3.1.12 and NET8 uses 3.1.34. However, VisualStudio bundled cmake gets stuck running the preset when targeting .NET 8.

For the purpose of developing the StereoKitTest_Web project I have modified the csproj to pre-build the native lib using the dotnet  Emscripten workload packs, just so it is a 100% match with the version used for Blazor. Also added the stuff that gets browser remote debugging working.

Debugging is a bit of a chore as the native function names get mangled. There appears to be ways to get this working by setting the RunAOTCompilation, RunAOTCompilationAfterBuild, WasmNativeStrip, WasmEmitSymbolMap etc in the csporj, but this makes build times take many minutes (45mins on a pretty grunty machine). Also, the .NET 7 Blazor won't start up if the emcc assertions are used because the blazor wasm startup calls into malloc before the wasm stuff has fully initialised, works when targeting .NET8 (with the native lib built by the .NET7 tools).

I have not got a solution for the delegate/callback problem that will work with .netstandard 2.0. The suggested use of UnmanagedCallersOnly would need to target at least .NET 5.

Next steps for me will be to work through the null function or function signature mismatch issue to ideally end up with the simulator running again and without really slow build times due to AOT. If that works alright, then will have a crack getting the delegate/callback sorted.
What's the challenges for StereoKit to target .NET 5 or higher?

@maluoi, I have made some progress in that StereoKit is rendering in the browser. And with callbacks that shouldn't need to change from .NET Standard 2.0. However, only with static methods (but not using the UnmanagedCallersOnly attribute).
I'll keep playing to see what can be done to get delegates working. The main barrier is that method Marshal.GetFunctionPointerForDelegate ends up with the error:
    at strlen (wasm://wasm/0533c28e:wasm-function[15576]:0x51e0c6)
    at get_native_to_interp (wasm://wasm/0533c28e:wasm-function[16866]:0x540231)
    at mono_wasm_get_native_to_interp_trampoline (wasm://wasm/0533c28e:wasm-function[8168]:0x3ddf88)
    at interp_create_method_pointer (wasm://wasm/0533c28e:wasm-function[3415]:0x2c9915)
    at jit_compile_method_with_opt_cb (wasm://wasm/0533c28e:wasm-function[7922]:0x3c9ff4)
    at mono_llvm_cpp_catch_exception (wasm://wasm/0533c28e:wasm-function[3699]:0x2eb82b)
    at jit_compile_method_with_opt (wasm://wasm/0533c28e:wasm-function[7921]:0x3c9ed7)
    at mono_jit_compile_method (wasm://wasm/0533c28e:wasm-function[7919]:0x3c9d29)
    at mono_compile_method_checked (wasm://wasm/0533c28e:wasm-function[6828]:0x394cb5)
    at mono_delegate_to_ftnptr_impl (wasm://wasm/0533c28e:wasm-function[6348]:0x379ccc) {stack: 'RuntimeError: memory access out of bounds
   …//wasm/0533c28e:wasm-function[6348]:0x379ccc)', message: 'memory access out of bounds'}```

   Maybe there's a way to have the delegate JIT/Compiled with the address fixed?

I've had some success working through the Blazor->wasm issues. And after talking it through with Nick, PR #980 has been put together as a way forward. This has the native/net examples working and includes blazor-wasm targets into the nuget package.
There's been a few things noted during the development to share.
StereoKit & native wasm
Using pure emscripten works very well, there are very few changes needed in the native space to compile the wasm static library, which should work well enough for wrapping in other languages (like Rust).
Emscripten even allows Assets (models/shaders etc) to get complied into a mock filesystem. The example projects use this so that the Assets get loaded using the native file load functions. However, if building a web application then the web approach would be to HTTP fetch assets from a server/cdn via HTTP and use the SK load from memory functions.
StereoKit & .NET Blazor
The challenges encountered from earlier attempts for using Blazor and SK are due to how the .NET WebAssembly tools generate the wasm PInvoke signatures. It's only now at .NET9 that this has improved to a point that most of the native callbacks can be made to work. There's still a limitation with arbitrary length function parameters, like String or varargs, and so the SK Log callbacks do not work. For this reason the dotnet implementation must target at least .NET 9 preview 2.
StereoKit & OpenGL/Web XR limits
For WebXR it is a rather simple limitation in that none of the backend has been implemented. However, it doesn't look like there are any technical things that would put a stop to this.
For OpenGL there's more effort needed to support different depth modes (currently only Stencil works) and most (or all) of the example shaders are not loading.


Avoid rerunning iids that are in the old catalog

It might be nice to have a list of iids in the old catalog to avoid rerunning these as we scale up.

Possibly the old catalog could be copied into the new BQ table (perhaps with an additional field, old=True)?

Closed via #9


HARP-8296: Fix terrain decoder data transfer

Codecov Report

Merging #1165 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   47.37%   47.37%   +<.01%
==========================================
  Files         256      256
  Lines       22755    22754       -1
  Branches     5065     5065
==========================================
  Hits        10780    10780
+ Misses      11975    11974       -1

Impacted Files
Coverage Δ

...e/harp-mapview/lib/geometry/TileGeometryCreator.ts
11.24% <0%> (+0.01%)
:arrow_up:

@here/harp-datasource-protocol/lib/DecodedTile.ts
26.98% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9de7e...be695f2. Read the comment docs.