Refactor ReadToolsOutputFormat as ReadToolsIOFormat

ReadToolsOutputFormat may also contain some utility classes for handle
also the possible input formats, generating less complexity in our code.

Rename ReadToolsOutputFormat to ReadToolsIOFormat and package in utils
Move IOUtils static methods from ReadTools to the correct classes
where they are needed (ReadToolsIOFormat and ReadWriterFactory)
New class for custom ReadTools exception.

Codecov Report

Merging #132 into master will not impact coverage by -0.35%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
- Coverage     86.051%   85.701%   -0.35%
+ Complexity       730       727       -3
==============================================
  Files             71        71
  Lines           2079      2098      +19
  Branches         255       252       -3
==============================================
+ Hits            1789      1798       +9
- Misses           221       235      +14
+ Partials          69        65       -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
28.571% <28.571%> (ø)
0 <ø> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.35%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
- Coverage     86.051%   85.701%   -0.35%
+ Complexity       730       727       -3
==============================================
  Files             71        71
  Lines           2079      2098      +19
  Branches         255       252       -3
==============================================
+ Hits            1789      1798       +9
- Misses           221       235      +14
+ Partials          69        65       -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
28.571% <28.571%> (ø)
0 <ø> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...3137a65. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...39b02fd. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9dbaf75. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9dbaf75. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.459%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
- Coverage     86.051%   85.592%   -0.459%
+ Complexity       730       728        -2
===============================================
  Files             71        71
  Lines           2079      2103       +24
  Branches         255       252        -3
===============================================
+ Hits            1789      1800       +11
- Misses           221       238       +17
+ Partials          69        65        -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
30.769% <30.769%> (ø)
1 <1> (?)

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9dbaf75. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.05%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
- Coverage     86.051%   86.001%   -0.05%
+ Complexity       730       728       -2
==============================================
  Files             71        71
  Lines           2079      2093      +14
  Branches         255       252       -3
==============================================
+ Hits            1789      1800      +11
- Misses           221       228       +7
+ Partials          69        65       -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
50% <50%> (ø)
1 <1> (?)

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9dbaf75. Read the comment docs.

Codecov Report

Merging #132 into master will not impact coverage by -0.05%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
- Coverage     86.051%   86.001%   -0.05%
+ Complexity       730       728       -2
==============================================
  Files             71        71
  Lines           2079      2093      +14
  Branches         255       252       -3
==============================================
+ Hits            1789      1800      +11
- Misses           221       228       +7
+ Partials          69        65       -4

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
81.818% <50%> (ø)
5 <2> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
50% <50%> (ø)
1 <1> (?)

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...f5a46b3. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.21%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
+ Coverage     86.051%   86.261%   +0.21%
+ Complexity       730       729       -1
==============================================
  Files             71        71
  Lines           2079      2089      +10
  Branches         255       252       -3
==============================================
+ Hits            1789      1802      +13
- Misses           221       223       +2
+ Partials          69        64       -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...f5a46b3. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.21%.

@@              Coverage Diff               @@
##              master      #132      +/-   ##
==============================================
+ Coverage     86.051%   86.261%   +0.21%
+ Complexity       730       729       -1
==============================================
  Files             71        71
  Lines           2079      2089      +10
  Branches         255       252       -3
==============================================
+ Hits            1789      1802      +13
- Misses           221       223       +2
+ Partials          69        64       -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

...gicdgs/readtools/utils/read/ReadToolsIOFormat.java
87.097% <87.097%> (ø)
5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...5254169. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.395%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.446%   +0.395%
  Complexity       730       730
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1805       +16
+ Misses           221       219        -2
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...5254169. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.395%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.446%   +0.395%
  Complexity       730       730
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1805       +16
+ Misses           221       219        -2
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...5254169. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.395%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.446%   +0.395%
  Complexity       730       730
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1805       +16
+ Misses           221       219        -2
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...5254169. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.395%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.446%   +0.395%
  Complexity       730       730
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1805       +16
+ Misses           221       219        -2
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...gicdgs/readtools/utils/read/ReadWriterFactory.java
69.643% <57.143%> (+3.605%)
20 <6> (+1)
:white_check_mark:

...agicdgs/readtools/exceptions/RTUserExceptions.java
66.667% <66.667%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.

Codecov Report

Merging #132 into master will increase coverage by 0.635%.

@@               Coverage Diff               @@
##              master      #132       +/-   ##
===============================================
+ Coverage     86.051%   86.686%   +0.635%
- Complexity       730       731        +1
===============================================
  Files             71        71
  Lines           2079      2088        +9
  Branches         255       252        -3
===============================================
+ Hits            1789      1810       +21
+ Misses           221       214        -7
+ Partials          69        64        -5

Impacted Files
Coverage Δ
Complexity Δ

...s/readtools/utils/read/writer/SplitGATKWriter.java
97.059% <ø> (ø)
15 <ø> (ø)
:x:

...ntcollections/RTOutputFastqArgumentCollection.java
100% <100%> (ø)
11 <ø> (ø)
:x:

...tools/engine/sourcehandler/ReadsSourceHandler.java
100% <100%> (+18.182%)
6 <3> (+1)
:white_check_mark:

...readtools/utils/read/writer/ReadToolsIOFormat.java
100% <100%> (ø)
6 <6> (?)

...ollections/RTOutputBamSplitArgumentCollection.java
100% <100%> (ø)
9 <ø> (ø)
:x:

...agicdgs/readtools/exceptions/RTUserExceptions.java
100% <100%> (ø)
1 <1> (?)

...mentcollections/RTOutputBamArgumentCollection.java
100% <100%> (ø)
7 <2> (ø)
:x:

...gicdgs/readtools/utils/read/ReadWriterFactory.java
71.429% <64.286%> (+5.391%)
21 <7> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f697105...9f98c22. Read the comment docs.


Feature request: support for an 'exclude' option on redirection (a.k.a negated regex)

I would like to redirect http to https based on a regex, and exclude one domain.
Something like:
[entryPoints.http.redirect]
    regex = "^http://(?!to.exclude.com).*$"

Unfortunately, (?!) is not supported in Go according to https://github.com/google/re2/wiki/Syntax.
Instead of waiting for this support, a feature like exclude could be added into the the traefik.toml config, that would negate regex

@ebreton so your proposal is to add something like, right?
[entryPoints.http.redirect]
    regex = "^http://.*$"
    exclude = "^http://to.exclude.com.*$"

yes :)

@ebreton I think it's a good idea :)
We would love to see a PR from you on this ;)

Good. What is the best place to start with ? I am a pythoner, with some curiosity and a good reason to try go now. I guess starting with go is straighforward.
Do you have a cheatsheet to get up to speed with Traefik ?
For this particular feature, would you have a few recommendations for me ?

@ebreton I guess the best advice is to learn by reading the code, especially the section you intend to share.
If you have questions, don't hesitate to hop on to Slack. The #dev channel is to place to be to ask development-related questions.

Any other workarounds or options to exclude single urls from redirection?

I can not believe this feature is not implemented.

I'm struggling with this too. I'm doing http => https scheme redirection but this breaks the letsencrypt http challenge, thus I want to exclude ".well-known/acme-challenge/.*" from the redirection but can't seem to construct a regex to do this... Anyone got any workarounds?

I'm struggling with this too. I'm doing http => https scheme redirection but this breaks the letsencrypt http challenge, thus I want to exclude .well-known/acme-challenge/.* from the redirection but can't seem to construct a regex to do this... Anyone got any workarounds?

did you find any solution for this? I also struggling with same


显示图片很慢

当点击图片时显示很慢，偶尔会快一点点~~
但是一旦设置transition:false时，那是一瞬间打开！性能希望能调一下~~

多个图片的时候，一开始比如点击第二个关掉，然后点开第一个，还是会显示之前的第二个。。
还有一个是有多个图片，然后页面上删除其中一个，再点开其中一张图，原来删除的还会余留在下方的相册中

The speed mostly depends on the net speed (transition only has 0.3s delay).
The error of multiple images viewimg had fixed at #2.
Update dynamically not support now, may be added later, you can restart the viewer manually after delete an image at present.

As of v0.4.0, I had added a new "update" method for update the images in the viewer dynamically.

As of v0.4.0, I had added a new "update" method for update the images in the viewer dynamically.


Remove persistent instances

let user decide what instance they want (e.g. citext)
perhaps move these text-derived instanced to its own little package

Actually we could offer a selection of instances to our users via tiny subpackages

Yeah, I think shipping a few extra modules with instances is a good idea. I think it's also worth writing about these instances in the setup instructions in the README.


Training code

The results look great in the HF demo! Really looking forward to play around with it once the code is available.
Are you planning to release the training code too?

Hi! Thank you for your interest in our project!
Yes, we will release our training code along with the data, which includes a filtered list, text captions, and the preparation code.
Although we are committed to cleaning and annotating the code, the training and data preparation components might not be ready in the initial release. Please stay tuned!

Great news! Thanks for the prompt response!

This is awesome! Thanks for open-sourcing everything. It's a breath of fresh air compared to the famous work ■■■■ that promised the world but then closed their issues. You rock!
Just one thing: Any idea when the full release of training is coming? A timeline would save me from the daily ritual of checking the repo first thing in the morning.

@JeffreyXiang This is awesome! Thanks for open-sourcing everything. It's a breath of fresh air compared to the famous work ■■■■ that promised the world but then closed their issues. You rock! Just one thing: Any idea when the full release of training is coming? A timeline would save me from the daily ritual of checking the repo first thing in the morning.

https://github.com/microsoft/TRELLIS/issues/44


stuck XML_GLOBAL_ERROR_STACK

the error doesn't reset unless restart Julia session?
https://termbin.com/l5raq

You can reset the errorstack yourself:
empty!(EzXML.XML_GLOBAL_ERROR_STACK)


Bump context and namespace URI to v1

What's missing?
Following the discussion about release https://github.com/eclipse-dataspace-dcp/decentralized-claims-protocol/discussions/128 the following changes are required in order to support
context uri: https://w3id.org/dspace-dcp/v1.0/dcp.jsonld
namespace uri: https://w3id.org/dspace-dcp/v1.0/

[ ] changes in artifacts
[ ] changes in perma-id dspace-dcp

Why should it be in the spec?
Relase preparation
Where should this be added?
No response
More context
No response

Closed by #131


Fix errors when attempting to run on rocketlogger hardware

All of the development has been done on our personal machines, and now we need to fix all the bugs related to running on the Rocketloggers themselves. This issue should only be closed once the first working version is completed.
The first issue seen is in logger.sh where the RL command should contain the output directory for the csv file
rocketlogger sample 1000 -r 1 -format csv -f /tmp/test_rl.csv -ch 0,1,2,3,4,5 -d 0 -w 0

Now getting the following
./scripts/logger.sh: line 21: csvsocket: command not found
./scripts/logger.sh: line 19: TIMESTAMP: command not found
./scripts/logger.sh: line 20: RL_FILENAME: command not found
Error: use -[option] [value]

Usage:
  rocketlogger mode -[option value]

  Modes:
    sample number      Acquires number of samples.
    cont               Continuously acquires samples.
    meter              Starts RocketLogger Meter.
    status             Get status of RocketLogger.
    stop               Stops RocketLogger.
    set                Set default configuration of RocketLogger (use normal options).
                         Use 'set 0' to reset the default configuration.
    conf               Print default configuration of RocketLogger.

  Options:
    -r rate            Acquisition rate selection. Supported rates:
                         1, 10, 100, 1k, 2k, 4k, 8k, 16k, 32k, 64k
    -u update_rate     Data update rate selection. Supported rates:
                         1, 2, 5, 10 (in Hz)
    -ch ch1,ch2,...    Channel selection.
                       Possible channels ('-ch all' to enable all):
                         0: I1H		4: I2H
                         1: I1L		5: I2L
                         2: V1 		6: V3
                         3: V2 		7: V4
    -fhr ch1,ch2       Force high-range.
                         0: no channel, 1: I1, 2: I2
    -c                 Use calibration, if existing.
                         '-c 0' to ignore calibration.
    -f file            Stores data to specified file.
                         '-f 0' will disable file storing.
    -d                 Log digital inputs.
                         '-d 0' to disable digital input logging.
    -a                 Log ambient sensors, if available.
                         '-a 0' to disable ambient sensor logging.
    -g                 Data aggregation mode for low sample rates.
                         Existing modes: 'average', 'downsample'.
                         '-g 0' to disable aggregation/low sample rates.
    -format format     Select file format: csv, bin.
    -size   file_size  Select max file size (k, m, g can be used).
    -C comment         Comment stored in file header. Comment is ignored
                         if file saving is disabled.
    -w                 Enable webserver plotting.
                         Use '-w 0' to disable webserver plotting.
    -s                 Set configuration as default (all except comment).

  Help/Info:
    help, --help       Display this help message.
    version, --version Display the RocketLogger software version.

./scripts/logger.sh: line 21: csvsocket: command not found

rocketlogger@rocket1-jlab:~/Rocketlogger-Firmware$ scripts/logger.sh
No such file or directory

Program compiled on Aug 16 2022 at 14:51:57

sh: 1: config-pin: not found
sh: 1: config-pin: not found

RocketLogger Configuration:
  Sampling rate:    1Sps
  Data aggregation: downsampleaverage
  Update rate:      1Hz
  Webserver:        disabled
  Digital inputs:   disabled
  File format:      csv
  File name:        /tmp/rl_data/2022-08-16_17:15:17_rl.csv
  Channels:         0,1,2,3,4,5,
  Sample limit:     10

Start sampling ...
stty: /dev/ttyS2: Input/output error
ERROR: int rc_uart_init while opening file descriptor: No such file or directory
device tree probably isn't loaded
Error in UART2 initialization.
ERROR: in rc_uart_flush, uart2 must be initialized first
Beaglebone not connected to E5 module.
ERROR: in rc_uart_flush, uart2 must be initialized first
Error setting ADR function.
ERROR: in rc_uart_flush, uart2 must be initialized first
Stored 10 samples to file.
pipstream, compiled on Aug 16 2022 16:48:53
csvstream: Missing socket file

RocketLogger Configuration:
  Sampling rate:    1Sps
  Data aggregation: downsampleaverage
  Update rate:      1Hz
  Webserver:        disabled
  Digital inputs:   disabled
  File format:      csv
  File name:        /tmp/rl_data/2022-08-16_17:15:27_rl.csv
  Channels:         0,1,2,3,4,5,
  Sample limit:     10

Start sampling ...
Stored 10 samples to file.
pipstream, compiled on Aug 16 2022 16:48:53
csvstream: Missing socket file

RocketLogger Configuration:
  Sampling rate:    1Sps
  Data aggregation: downsampleaverage
  Update rate:      1Hz
  Webserver:        disabled
  Digital inputs:   disabled
  File format:      csv
  File name:        /tmp/rl_data/2022-08-16_17:15:37_rl.csv
  Channels:         0,1,2,3,4,5,
  Sample limit:     10

Start sampling ...

Receiving bus error:
lora compiled on Aug 17 2022 at 23:52:12

RocketLogger Configuration:
  Sampling rate:    1Sps
  Data aggregation: downsampleaverage
  Update rate:      1Hz
  Webserver:        disabled
  Digital inputs:   disabled
  File format:      csv
  File name:        /tmp/rl_data/2022-08-17_23:53:57_rl.csv
  Channels:         0,1,2,3,4,5,
  Sample limit:     10

Start sampling ...
./logger.sh: line 27:  1845 Bus error               rocketlogger sample $NUM_SAMPLES -r 1 -format csv -f $RL_FILENAME -ch 0,1,2,3,4,5 -d 0 -w 0
pipstream, compiled on Aug 17 2022 23:52:13

RocketLogger Configuration:
  Sampling rate:    1Sps
  Data aggregation: downsampleaverage
  Update rate:      1Hz
  Webserver:        disabled
  Digital inputs:   disabled
  File format:      csv
  File name:        /tmp/rl_data/2022-08-17_23:53:57_rl.csv
  Channels:         0,1,2,3,4,5,
  Sample limit:     10

Start sampling ...
./logger.sh: line 27:  1849 Bus error               rocketlogger sample $NUM_SAMPLES -r 1 -format csv -f $RL_FILENAME -ch 0,1,2,3,4,5 -d 0 -w 0
pipstream, compiled on Aug 17 2022 23:52:13

@ahzired Is this done? Can it be closed?


Rebuild with the latest libabseil

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Thanks @JanuszL!

Thanks @JanuszL!

Don't thank me yet :)
I'm still learning conda ecosystem and I just notices that .ci_support/migrations/libabseil20240116_libgrpc161_libprotobuf4252.yaml needs to be created (based on https://github.com/conda-forge/protobuf-feedstock/commit/a76793de45942dd643711917cd5b5cbe447b2bb5).

@conda-forge-admin, please rerender

Ah, hmm, so did you manually rerender all that?
If so, that stuff is supposed to be automatic, and it'll be clobbered by the next rerender. It's better to figure out how to leverage conda-forge to make it do that stuff for you. Probably best to ask on Element

I'm really confused. You increased the build number and rerendered. That's straightforward enough.
But then you rebased, changing the rendering, but then this rendering agrees with the rerender bot. So where did this come from?

I'm really confused. You increased the build number and rerendered. That's straightforward enough.
But then you rebased, changing the rendering, but then this rendering agrees with the rerender bot. So where did this come from?

Sorry for the confusion. The initial change missed libabseil20240116_libgrpc161_libprotobuf4252.yaml file, so the rerender bot didn't update the libabseil in the constraints. I added this file, rerendered it locally, and pushed it. Then just to be sure I asked the bot to rerender to double check.

Ah, I see! I'm not actually familiar myself with libabseil.
To make it clear what's going on, would you mind rebasing so that your first commit contains meta.yaml to bump the version and also libabseil20240116_libgrpc161_libprotobuf4252.yaml? Then you can have the bot rerender.
So that I have context and so I can learn about what's going on, where did you get the libabseil migration? Usually migrations are handled by conda-forge bots, so it seems unusual to do it by hand.
Thanks for your patience!!!

@conda-forge-admin, please rerender

So that I have context and so I can learn about what's going on, where did you get the libabseil migration? Usually migrations are handled by conda-forge bots, so it seems unusual to do it by hand.

I used https://github.com/conda-forge/protobuf-feedstock/commit/a76793de45942dd643711917cd5b5cbe447b2bb5 as a reference (from protobuf feedstock). To my dispointment, conda-forge bots don't handle that. My understanding of the conda-forge is not that thorough, I did my best to use the mentioned project as a reference and I hope someone more knowledgeable can shed some light on that.

I'm still learning conda ecosystem and I just notices that .ci_support/migrations/libabseil20240116_libgrpc161_libprotobuf4252.yaml needs to be created (based on conda-forge/protobuf-feedstock@a76793d).

Generally the bot takes care of this. However protobuf is a test dependency of one of the main libraries that this migration aims at - libgrc. I'll start the migration as soon as the grpc build turns green, in the meantime I'd suggest not to merge this.

Thanks a lot @JanuszL for your eagerness to push this forward! Some of the conda-forge infrastructure is fairly elaborate, so thanks for bearing with us.

Not a problem. I appreciate that I have learned something new.

I'll start the migration as soon as the grpc build turns green

I will close the PR as soon as the bot kicks in.

Can you tell me how is the migration progressing?

It hasn't started yet. There's a problem somewhere between abseil & grpc, and while I have a possible work-around, I'm waiting for feedback from abseil/grpc maintainers - either would be fine, but neither has responded so far.

The migration has started now, so if you want to get in before the bot opens a PR, feel free to merge this after you've deleted the use_local: True.

@h-vetinari - thank you for letting me know. I think I can wait and I will close the PR once the bot does it job.


ExplicitNetworkGenerator missing unconnected nodes

Describe the bug
The method ExplicitNetworkGenerator.generate_network_from_names(components, names) only includes nodes (components) that are connected by edges. i.e., no unconnected/floating nodes are included. This is in contrast to the current openfe network generating behavior.
I noticed this when unit tests for this openfe PR failed, because ligand_network_planning.generate_network_from_names() is being switched to use konnektor's ExplicitNetworkGenerator implementation.
To Reproduce
This Konnektor unit test demonstrates this.
Expected behavior
@IAlibay I believe we should change the Konnektor implementation to match the current openfe behavior. However, I'd like to know if this was intentionally done by @RiesBen  as part of Konnektor's design.

@atravitz
hi, jap I wanted that behavior, as I wanted konnektor to not return disconnected networks by defautl. But maybe simply throwing an error would have been wiser?

I think this needs discussion, but disconnected networks is something we will likely want under certain circumstances. I remember the original behaviour was somewhat of an intentional design decision (although I had asked that it threw at least an error to let folks know the network was disconnected).


[Bug] requiring "json" feature for "sol!" macro is a breaking change

Component
sol! macro
What version of Alloy are you on?
0.7.3
Operating System
Linux
Describe the bug
When rebuilding a project that depends on the sol macro, or using cargo update, the code unexpectedly failed to compile. This is because between version 0.7.2 and 0.7.3, the macro now requires the json feature to be enabled (#626). This is not too big of an issue as we can just enable the json feature as well, but it should count as a breaking change so dependents don't break unexpectedly.

Sorry about that, releasing a patch.


Fix bug in execute_data_retention_policy

Previously we had a bug in the SQL because the remaining_metrics
array was being concat with a record which resulted in
"ERROR:  operator does not exist: metric[] || record"
this only happened when a locked metric was found in the
first loop and so it wasn't caught by tests. We added a test
specific to this case.

bors r+


fix: change cmd in entrypoint in dockerfile

Codecov Report

Merging #25 (1c45f89) into main (8ad2949) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   97.91%   97.91%
=======================================
  Files           4        4
  Lines          48       48
=======================================
  Hits           47       47
  Misses          1        1

Flag
Coverage Δ

unittests
97.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad2949...1c45f89. Read the comment docs.

:tada: This PR is included in version 0.1.7 :tada:
The release is available on:

v0.1.7
GitHub release

Your semantic-release bot :package::rocket:


Can somebody help me with the installation process?

I unzipped the 'panel' folder, and installed php to execute the php files. However, I need help with the steps in between.
Could someone make a video on how to install it, or write detailed steps for the installation please?


[CORE] The descriptionof jobHistory config should be spark.history.fs.logDirectory

The config option  is spark.history.fs.logDirectory, not spark.fs.history.logDirectory. So the descriptionof  should be changed. Thanks.

Can one of the admins verify this patch?

LGTM as a minor fix since I can't find any occurrences of the existing property, but the corrected one is indeed used throughout the code.

ok to test

Test build #29608 has started for   PR 5332 at commit 5ffbfb5.

Test build #29608 has finished for   PR 5332 at commit 5ffbfb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29608/
Test PASSed.

Oops my mistake! LGTM I'm merging this into master and 1.2


[AzureMonitorExporter] Fix and reenable Request Telemetry test

Fix #24362.
Root cause is Activity End callback is not executed until after response was returned.
Flushing the processor doesn't help here.
See also: OpenTelemetry.Instrumentation.AspNetCore.Tests
Changes

Renamed "OpenTelemetryTests" to "RequestTelemetryTests"
fix issue with SpinWait.
Added additional logging to test.

API change check
API changes are not detected in this pull request.


added scipy as a requirement for installation

scipy needed to be install as well

LGTM. Thanks for your contribution!

have updated to v0.1.4: https://pypi.org/project/angle-emb/0.1.4/


feat: strutured queries

Queries are no longer opaque strings, but rather structured, to avoid RCE possibilities
Closes #40

@jasonkuhrt Let's chat about this on a call


Update godoc

Public functions/methods are not documented, at all, and they should.

Closed by c1889d21584048183e751769208f9419a4f666b0


Find and replace bar

Pls make the border of the "Find" bar turn red, when no results are found, so that it can provide a quick visual info. to the user

@badri-n18 Do you mean like this:

First the find-and-replace package would need to provide a class. Something like has-result and has-no-result.  Then themes could use to style it in different ways. Might be nice to add it. 👍

yes, exactly
On Fri, Jul 15, 2016 at 4:45 PM, simurai<EMAIL_ADDRESS>wrote:

@badri-n18 https://github.com/badri-n18 Do you mean like this:
[image: find]
https://cloud.githubusercontent.com/assets/378023/16872521/3a3ddce2-4ac8-11e6-880e-3704026aed3c.gif
First the find-and-replace package would need to provide a class.
Something like has-result and has-no-result. Then themes could use to
style it in different ways. Might be nice to add it. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/one-dark-ui/issues/150#issuecomment-232925741,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATBYpSfeNZXPoigg9ExpDtzxNmrmOgUXks5qV2vHgaJpZM4JDolr
.

Ok, so far this is blocked by https://github.com/atom/find-and-replace/issues/761

There is now a PR to unblock this: https://github.com/atom/find-and-replace/pull/798

Ok, this is a bit tricky if the syntax theme uses either a green-ish or red-ish background. Because this theme uses that as accent color. So in the example below it looks like there is a match (green):

Starting with Atom 1.13 Beta, here something to test in your styles.less file:
@import "ui-variables";

// Colorize find-and-replace based on results
.find-and-replace {
  &.has-no-results .find-container atom-text-editor[mini].is-focused {
    border-color: @text-color-error;
    box-shadow: 0 0 0 1px @text-color-error;
    background-color: mix(@text-color-error, @input-background-color, 10%);
    .selection .region {
      background-color: mix(@text-color-error, @input-background-color, 50%);
    }
    .cursor {
      border-color: @text-color-error;
    }
  }

  &.has-results .find-container atom-text-editor[mini].is-focused {
    border-color: @text-color-success;
    box-shadow: 0 0 0 1px @text-color-success;
    background-color: mix(@text-color-success, @input-background-color, 10%);
    .selection .region {
      background-color: mix(@text-color-success, @input-background-color, 50%);
    }
    .cursor {
      border-color: @text-color-success;
    }
  }

  &.has-results    .find-container .result-counter { color: @text-color-success; }
  &.has-no-results .find-container .result-counter { color: @text-color-error; }
}


Do not autosave context data in build tasks

CLOUDBLD-10570
Build tasks run in parallel, which means there can be races between one
task reading the data and another one writing it.
Even without races, saving data could cause inconsistencies; the changes
made by one task could be overwritten by another one.
Luckily, the build task does not update anything in the context data and
so does not need to save it.
Signed-off-by: Adam Cmiel<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Python type annotations added to new code
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

@o-lesko feel free to review our PRs as well, all feedback is welcome :slightly_smiling_face:

code looks good, coverall is broken

code looks good, coverall is broken

Coveralls is alive again :tada:


YARN-11368. [Federation] Improve Yarn Router's Federation Page style.

JIRA: YARN-11368. [Federation] Improve Yarn Router's Federation Page style.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jshint
0m  1s

jshint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  6s

trunk passed

+1 :green_heart:
compile
10m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
8m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
2m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
2m 23s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 42s

trunk passed

+1 :green_heart:
shadedclient
22m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
9m 25s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
9m 25s

the patch passed

+1 :green_heart:
compile
8m 58s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
8m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 58s

the patch passed

+1 :green_heart:
mvnsite
2m 11s

the patch passed

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  5s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
21m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 14s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
5m 54s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
1m 23s

The patch does not generate ASF License warnings.

166m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets jshint spotbugs checkstyle

uname
Linux db23a5130df6 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8c28bfb64d8f79b765e59ef3264753421d1dc2fa

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/1/testReport/

Max. process+thread count
859 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jshint
0m  1s

jshint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 27s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 48s

trunk passed

+1 :green_heart:
compile
10m  0s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
8m 53s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
2m  3s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
21m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
9m 16s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
9m 16s

the patch passed

+1 :green_heart:
compile
8m 42s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
8m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 51s

the patch passed

+1 :green_heart:
mvnsite
2m  4s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 53s

the patch passed

+1 :green_heart:
shadedclient
21m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 29s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
5m 51s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
1m 24s

The patch does not generate ASF License warnings.

164m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets jshint spotbugs checkstyle

uname
Linux 66d15c978bec 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7f3007e6eb8427593b2ed3789e7ae854a9c3d849

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/2/testReport/

Max. process+thread count
805 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jshint
0m  1s

jshint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 24s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 20s

trunk passed

+1 :green_heart:
compile
10m 16s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
9m  1s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 59s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
21m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
9m 21s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
9m 21s

the patch passed

+1 :green_heart:
compile
8m 44s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
8m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 48s

the patch passed

+1 :green_heart:
mvnsite
1m 58s

the patch passed

+1 :green_heart:
javadoc
1m 50s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  0s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 39s

the patch passed

+1 :green_heart:
shadedclient
23m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 16s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
6m 16s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
1m  9s

The patch does not generate ASF License warnings.

168m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5105

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets jshint spotbugs checkstyle

uname
Linux 27750a4c56bf 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eecc5edd5f1382dea49504c0784a1318c6257ec3

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/3/testReport/

Max. process+thread count
758 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5105/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Fix conflicting data.path in config and datadir option

In some cases people would define a data.path setting in the config and use the datadir option.
We should detect this and force the datadir option to be leading.
Fixes #186

I got tripped up by this.  I defined config['path']['data'] but not datadir.  It was quietly using the default datadir which I find unintuitive.  I recommend failing, or maybe just a warning, with a msg to define datadir here.
Probably not worth addressing unless others have a similar experience.  Just a heads up & recommendation in case pops up again.


The value of the returned edge is not the real value

complete_graph.nodes[n]['id'] = n ? why?
sampled_graph.add_node(chosen_node)
sampled_graph.add_edge(curr_node, chosen_node)
The 'chosen_node' and 'curr_node' are both 'id' and not real values.
Cause the RW to walk according to the id of the node, not the true value of the node.

@kirtiJain25

@DeathSentence You can change the code according to your understanding


(Help wanted!) More and more tests!

CK is a simple tool; yet, people's code are complicated!! Although our test suite has been growing, there are always exceptional cases that might lead the tool to bring strange results.
If you are looking for a way to start contributing to this project, I suggest you to write tests!! Our test suite is full of examples! In practice, all you need to do is:

Create a "fake" class with the property you want to assert, e.g., does CK calculate WMC well when we have a ternary if in the code? This code goes to the /fixture folder
Feel free to either add your test to an existing one (e.g., if you are adding one more test for the WMC metric, this method should be in the WMCTest class) or add a new file (e.g., you are testing a more holistic behaviour, and this behaviour does not depend on a single metric)
Write a test that executes CK in the folder that contains your fixture.
Write good assertions! Try to assert as much as possible. Good assertions are key! A good one to remember is to assert the value of that metric at class and method level (we have found bugs where the metric at method-level was correct, but at class-level, there was a bug)!

Submit your tests as a PR!
If you found a bug,** THANK YOU**! Feel free to fix it yourself! If you can't, no worries. Just open an issue, and I'll work on that!

The RFC metric is one that deserves a lot more tests!

I have a question,
should be method reference counted in RFC metric?
Map<Character, List<Integer>> byAlphabet =
        aList.stream()
            .collect(
                Collectors.groupingBy(
                    e -> new Character(e.getName().charAt(0)),
                    Collectors.mapping(Avatar::getId, Collectors.toList())));

For example, that's stream above, there is a method reference, but currently RFC does not include it.
So, the result of RFC metric above is 7, what should be the result 7 or 8?

We are probably not counting the Avatar::getId, but maybe we should! Would you mind fixing it and opening a PR?

Sure!
I opened up a pull request


Ephemeral chain instructions

Looks good. Did we add the following to build/config/config.ini or must that be done manually by the user setting up the test environment?
http-server-address = <IP_ADDRESS>:8888
state-history-endpoint = <IP_ADDRESS>:8080

It's already added!


[feature request] blacklist for WiFi names

recently i stumbled across this app and it seems pretty cool! kudos!
thank you very much for making this FOSS... :+1: perhaps i can finally replace another proprietary piece of software at my phone.
the only feature which is IMHO lacking beside the several whitelist options is also a blacklist (e.g. to don't suck a friends limited data plan, if you are using his hotspot; to don't use your companies WiFi for whatever reason; etc.).
if this feature can be implemented, this app would be perfect! :clap:

btw: is there a reason why only the "Access point list" option is grayed out and not select-able?

Hi,
In order to comply with Google Play's privacy policy, we no longer use WiFi SSID names to control the WiFi SSIDs.
"Access Point List" is not available to select as it is just for compatibility purposes.
Best regards.

we no longer use WiFi SSID names to control the WiFi SSIDs. "Access Point List" is not available to select as it is just for compatibility purposes.
Sorry, I do not understand this sentence. Does it mean that Google does not allow apps (on Play Store) to do "only when connected to SSID MyWifi" actions? (If so, this maybe outdated according to https://github.com/Sentaroh/SMBSync2/issues/239#issuecomment-972616294 ?) -- I am trying to figure out if I am just to stupid to find the SSID whitelist in the app or whether it was removed.

Thank you.
btw as you probably know there are alternatives like F-Droid :)


LiveShare deserve better name

Just like Atom's Teletype. VS Code Live Share also deserve a better name.

@mittalyashu Thanks for the suggestion :) As you know, naming is pretty hard, and no name is ever perfect. At this point, we’ve got enough usage in-the-wild, that changing the name could cause confusion (e.g. someone reads an article about “Live Share”, but when they try to search for it later, they find something else), which would be counter-productive to increasing awareness/adoption.
Our goal is to enable developers to efficiently collaborate together in real-time, which is quite literally described by the name “Live Share”. As always, we’ll keep listening to feedback, and act accordingly. However, I think we’ll stick with “Visual Studio Live Share” for now 👍

I'm going to close this issue for now, since I don't think it's immediately actionable. Though we're always open to hear more feedback 😄Thanks!


fix: do not install hugo-extended in CI

package.json declares which version of hugo is needed to build and run the project.
Signed-off-by: Matthew Fisher<EMAIL_ADDRESS>

Looks like this now depends on #190 which will fix the ambiguous page references noted in newer versions of hugo.


chore: Found Yoda Conditions

Description
Fixed Found Yoda conditions JS-0104
Fixes # (issue)
https://deepsource.io/gh/appsmithorg/appsmith/issue/JS-0104/occurrences
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@sbalaji1192 can you please add "hactoberfest" or "hactoberfest-accepted" label to this issue?

??


No SIMD support for arm64 Float64x2.clamp

This tracker is for issues related to:

Dart VM

It appears that Dart isn't generating SIMD code for Float64x2.clamp despite it being supported by neon.
See the lack of Float64x2 in https://github.com/dart-lang/sdk/blob/main/runtime/vm/compiler/backend/il_arm64.cc

@a-siva @rmacnak-google

Duplicate of #40427

Sorry, I should have looked these up first.  I could have found them.


Remove browser sniff in urlUtils.js

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
Neither. Potential bug.
What is the current behavior?
Depends on browser and configuration. May "work" by coincidence in currently supported browsers, but could break in future.
This would be trivially easy to feature test and then would work in any browser that demonstrates the defect. Furthermore, will stop doing the extra work if the bug is ever fixed in IE.
Also note that not all MSHTML-based environments are IE.
// Support: IE 9-11 only
  if (msie) {
    // Normalize before parse.  Refer Implementation Notes on why this is
    // done in two steps on IE.
    urlParsingNode.setAttribute('href', href);
    href = urlParsingNode.href;
  }

The steps to test it are spelled out in the implementation notes.

Set the attribute on the dummy link to a value lacking a protocol, host, etc.
Check to see if protocol, host, etc. properties are empty strings.

urlParsingNode.setAttribute('href', 'foo');
var problemSettingHrefAttribute = urlParsingNode.host === '';

Do that once during initialization and then make a direct inference based on the result:
  if (problemSettingHrefAttribute) {
    // Normalize before parse.  Refer Implementation Notes on why this is
    // done in two steps.
    urlParsingNode.setAttribute('href', href);
    href = urlParsingNode.href;
  }

I don't think makes much of a difference (and things don't get fixed on IE any more), but if it can be reliably detected, it wouldn't hurt (and the performance overhead is negligible). So, feel free to submit a pull request.

Okay, will do. Will also help if the quirk ever shows up in other browsers.


Add validate kwarg to RGlyph._loadFromGLIF

I needed to be able to use this, it's part of the underlying readGlyphFromString API.
I also would not oppose letting _loadFromGLIF take **kwargs which it can pass down to readGlyphFromString at maintainer's (@benkiel's?) option, but I do need something like this please. :pleading_face:

Looks good. For right now let's just do the validate, need to think through **kwargs


feat(uptest): make uptest usable for repo

Description of your changes
make uptest usable for repo

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

/test-examples="examples/auth/authbackend.yaml"

/test-examples="examples/auth/authbackend.yaml"

/test-examples="examples/auth/authbackend.yaml"

/test-examples="examples/genericsecret/genericsecret.yaml,examples/githubauthbackend/githubauthbackend.yaml,examples/githubteam/githubteam.yaml"

/test-examples="examples/genericsecret/genericsecret.yaml,examples/githubauthbackend/githubauthbackend.yaml,examples/githubteam/githubteam.yaml"

/test-examples="examples/auth/authbackend.yaml"

/test-examples="examples/kvsecret/kvsecret.yaml,examples/kvsecretv2/kvsecretv2.yaml,examples/token/token.yaml,examples/tokenauthbackendrole/tokenauthbackendrole.yaml"

/test-examples="examples/mount/mount-generic-secrets.yaml,examples/mount/mount-kv-v1.yaml,examples/mount/mount-kv-v2.yaml"

@humoflife thanks for your comments

It would be preferable if uptest can support Go 1.20 or better 1.21, and if we can move versions up versus backwards. golangci-lint would probably stay also at 1.53.3 with go1.20.5 if possible.

I didn't know that the PR-triggered comment workflow defaulted to Go version 1.19 for uptest. So, I've submitted a follow-up PR to switch it back to Go version 1.20 -> https://github.com/upbound/provider-vault/pull/16
https://github.com/upbound/uptest/blob/main/.github/workflows/pr-comment-trigger.yml#L13

The UPTEST_EXAMPLE_LIST drives the e2e tests. Why should they be removed?

We're examining PR comments to create the test example list. When working locally, you can set the ENV variable UPTEST_EXAMPLE_LIST, and we won't have a fixed UPTEST_EXAMPLE_LIST as it'll be rechecked across all the other official providers.
UPTEST_EXAMPLE_LIST=examples/kvsecret/kvsecret.yaml,examples/kvsecretv2/kvsecretv2.yaml,examples/token/token.yaml,examples/tokenauthbackendrole/tokenauthbackendrole.yaml make e2e
https://github.com/upbound/provider-aws/blob/main/Makefile#L190
https://github.com/upbound/provider-gcp/blob/main/Makefile#L185
https://github.com/upbound/provider-azure/blob/main/Makefile#L181

Is the hint that the local-dev cluster will remain after tests not useful?

In all other providers or configuration repositories, we don't include such a comment when using uptest. From my perspective, it's typical to use the upbound/build module for setting up local development clusters. In our CI process, we delete the cluster after the CI run.

Where should experimental tests reside? Are they not useful for users to experiment with as a foundation for their use cases?

I believe we have examples generated from the upjet, which people can review to explore experimental versions.
https://github.com/upbound/provider-vault/tree/main/examples-generated


Support default value for optional parameters

Like jsdoc: http://usejsdoc.org/tags-param.html
/**
 * @param {string} [somebody=John Doe] - Somebody's name.
 */

Is it possible ?

https://esdoc.org/tags.html#optional-and-default
Is this what you're talking about?

Oh sorry.
My problem was space:
@param {number} [index = -1]
I think it worked fine with jsdoc, though

@blindman Thanks for reply!


Would this work in a RecyclerView?

Would this method work efficiently in a RecyclerView? So that each list-item would contain one DocumentView and the holder will use the span methods to set the justification?

Ideally it should. I have not tried it with a RecyclerView so I can't be for sure. If you can provide some test results, it would be great!

It works but it has an issue: Once you scroll back and forth the entire textview pops up, if the recyclerview item appears on screen, instead of getting smoothly presenting when scrolling in. So the rest of the screen is suddenly shifted to make space for the textview field.

@Nedeos   I meet the same problem, have you deal with this?

I use a very simple test case.
    <com.bluejamesbond.text.DocumentView xmlns:ext="http://schemas.android.com/apk/res-auto"
        android:layout_marginBottom="24dp"
        android:id="@+id/body_text_view"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        ext:documentView_antialias="true"
        ext:documentView_cacheConfig="auto_quality"
        ext:documentView_hyphen="-"
        ext:documentView_lineHeightMultiplier="1.2"
        ext:documentView_reverse="false"
        android:text="@string/upgrade_live_account_body"
        ext:documentView_textAlignment="justified"
        ext:documentView_textColor="?attr/primaryTextColor"
        ext:documentView_textFormat="plain"
        ext:documentView_textSize="16sp"
        ext:documentView_textSubPixel="true"
        ext:documentView_textTypefacePath="fonts/Roboto-Light.ttf" />

It don't really work well with RecyclerView. When I call notifyDataSetChanged, there will be flickering effect. If I replace com.bluejamesbond.text.DocumentView back to normal TextView, flickering effect gone.


[bug]: Using OMZP:: shorthand seems to break svn ice

Environment
OSTYPE=linux-gnu, CPUTYPE=x86_64 / MACHINE_TYPE=x86_64 ZSH_VERSION=5.6
Expected behavior
Using zi ice svn with the OMZP:: should pull the whole folder
Current behavior
It fails to load with a Snippet not loaded but it seems to have loaded something
Steps to reproduce
Try to load like this :
zi ice svn
zi snippet OMZP::history-substring-search # Tested only with HSS

Code snippet
zi ice svn
#zi snippet OMZ::/plugins/history-substring-search # This form works
zi snippet OMZP::history-substring-search

Aditional information
zi status --all without OMZP::
Status for plugins/history-substring-search
              6455     6205 marc.cornell. history-substring-search.plugin.zsh
?                                        history-substring-search.plugin.zsh.zwc
              6455     5342 marc.cornell. update-from-upstream.zsh
              6455     6130 marc.cornell. history-substring-search.zsh
?                                        history-substring-search.zsh.zwc
              6455     5885 marc.cornell. README.md
?                                        ._zi
              6455     6205 marc.cornell. .
Status against revision:   6455

ls $HOME/.zi/snippets/OMZP::history-substring-search with OMZP:: (after zi delete --clean)
drwxr-xr-x 3 signed users 4.0K May 28 10:01 history-substring-search.zsh
-rw-r--r-- 1 signed users  638 May 28 10:01 OMZP::history-substring-search
-r--r--r-- 1 signed users 1.4K May 28 10:01 OMZP::history-substring-search.zwc
drwxr-xr-x 2 signed users 4.0K May 28 10:01 ._zi

(no sign of svn with OMZP)
Self-service

[ ] I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines.

Are you familiar with Contributor Covenant Code of Conduct?

[X] I have read the Contributor Covenant Code of Conduct.

Contact Details
<EMAIL_ADDRESS>

Maybe I am missing out, but it seems you pick a specific file instead of grabbing dir?
zi ice svn
zi snippet OMZ::plugins

Maybe I am missing out, but it seems you pick a specific file instead of grabbing dir?
zi ice svn
zi snippet OMZ::plugins

In which one?
With OMZP:: it seems to do exactly that.
With OMZ:: no, I am selecting the history-substring-search folder in its entierety

Can't repro anymore on one of the two impacted machine.
Closing until testing is complete on the other machine

Can reproduce on the second machine :
echo "OSTYPE=${OSTYPE} CPUTYPE=$(uname -m) / MACHINE_TYPE=$MACHTYPE ZSH_VERSION=${ZSH_VERSION}"
Output of zi dtrace while trying to load the module :
Report for[0m [1;4m[38;5;207m_dtrace[0m/[1;4m[38;5;39m_dtrace[0m plugin
[38;5;82m---------------------------------[0m

[ [38;5;82m✔[0m[0m ] [0m[38;5;81mFunctions created:[0m[0m
alias autoload
bindkey zle
zstyle
[0m[0m

[ [38;5;82m✔[0m[0m ] [0m[38;5;81mVariables added or redefined:[0m[0m
filename [38;5;82m[ "" -> scalar ][0m
fsh__chroma__zi__delete__NO_MATCH__H_opt [38;5;82m[ "" -> association ][0m
fsh__chroma__zi__delete__DELETE_0_opt [38;5;82m[ "" -> association ][0m
__sp [38;5;82m[ "" -> array ][0m
id_as [38;5;82m[ "" -> scalar ][0m
[0m[0m

According to this, it didn't even try to load the snippet

I might understand the issue you are having here. I am guessing that: :see_no_evil:
You might not fully understand how snippets are downloaded/sourced, and probably after reading about ice/#-src-pick-multisrc you would use multisrc'' which should solve your issue.
Let me know :octocat:

@signed-log I think the issue is on ohmyzsh side, I will investigate it, to be sure.