Nearby notable things from OpenStreetMap

Wikidata only has 2000 embassies, while OpenStreetMap has 8000.
All embassies are notable enough to have their picture in Commons.
OSM has gotten quite good at linking to Wikidata, so an OSM item without a Wikidata link probably is not in Wikidata yet.
So, let's display them in Nearby, as soon as technically possible.
An advantage of OSM is that the items are all current (all buildings still exist in the present day, if you go there you will have something to take a picture of).
When the user uploads a picture,

Create a Wikidata item with the correct type, such as embassy, name/description, image, lat/long from EXIF if available (not from OSM for license reasons)
Link to it from the OSM item. This task is probably better left to a bot, and the Commons app would only send data to that bot (in order to avoid authentication issues and to be able to modify the code that talks to OSM without having to force all app users to update).

I believe OSM items with these tags are notable (every instance is worth having its picture in Commons):

https://wiki.openstreetmap.org/wiki/Tag:amenity=embassy
https://wiki.openstreetmap.org/wiki/Tag:diplomatic=consulate
https://wiki.openstreetmap.org/wiki/Tag:diplomatic=embassy
https://wiki.openstreetmap.org/wiki/Tag:amenity=hospital
https://wiki.openstreetmap.org/wiki/Tag:building=hospital
https://wiki.openstreetmap.org/wiki/Tag:man_made=bridge
https://wiki.openstreetmap.org/wiki/Tag:building=bridge
https://wiki.openstreetmap.org/wiki/Key:place
https://wiki.openstreetmap.org/wiki/Tag:railway=station
https://wiki.openstreetmap.org/wiki/Tag:tourism=zoo
(please add more)

Does the scope of this issue entail:
1-Fetching a list of nearby places from OSM based on the current coordinates of the user which will be then shown on the map?
2-Creating a WikiData item every time an image is uploaded(based on whether we have an existing WikiData item) and linking it to an OSM item based on the coordinates of that item?
3-Both of the above

@Bluesir9 (3) Both of the above. Linking from OSM is important so that at the next Nearby search this point is not shown anymore.

Woohoo! An interesting idea @nicolas-raoul . My worry is that we lose the cool connection to real items in Wikidata which we have just embraced using Nearby maps and lists. Images uploaded this way would have to be somehow properly tagged - but OSM identifiers are notoriously unstable, so it would be really complicated. Most OSM objects aren't still connected to existing Wikidata items, at least in our country (try this tool to see for yourself how many are still not connected).
My thought is that all these types of places belong to Wikidata and will actually be imported sooner or later. Within a few years there will probably be no need to read these kinds of objects from OSM because we'll have them in Wikidata. Also it might make the Nearby query take even longer than it does now which wouldn't be very user-friendly.
I've given several reasons why we shouldn't do this but there are of course many pros as well - obviously our dataset would be much richer than it is now.

This feature would be a really good addition to our app. I am in favor of having this task for 2019's PG application. Having worked with Wikidata APIs for P18 edits, we will have a better clarity of how Wikidata works and we should be able to manage this task well. :)

@VojtechDostal Many OSM objects are not connected to WIkidata objects because OSM has way more geographical objects than Wikidata. Looking at an OSM maps around me right now, I see dozens of notable places, and almost none of them has a Wikidata item. Even though I am in a country with a strong Wikipedia community writing many local articles. I am sure that Wikidata coverage is very low in countries with a weaker Wikipedia community, for instance the PRC of Guinea.
Conakry on OSM and Wikishootme:

I wrote this Overpass API query:
(
  node(43.08,131.84,43.13,131.93)[amenity=hospital];
  node(43.08,131.84,43.13,131.93)[building=hospital];
  node(43.08,131.84,43.13,131.93)[amenity=embassy];
  node(43.08,131.84,43.13,131.93)[diplomatic=embassy];
  node(43.08,131.84,43.13,131.93)[diplomatic=consulate];
  node(43.08,131.84,43.13,131.93)[man_made=bridge];
  node(43.08,131.84,43.13,131.93)[building=bridge];
  node(43.08,131.84,43.13,131.93)[Key=place];
  node(43.08,131.84,43.13,131.93)[railway=station];
  node(43.08,131.84,43.13,131.93)[tourism=zoo];
);
out;

Paste it into https://overpass-turbo.eu , press Run and Zoom to data to see the results on the map, then press Export to download as GeoJSON/GPX/KML.
It already provides results, but it could be improved further by catching:

not only nodes but also ways (see  https://stackoverflow.com/a/41395312/226958)
filtering out items that have a k="wikidata", since the Wikidata query is already showing them (and not showing those that have a picture, which is good).

The API can be called directly like this:
https://overpass-api.de/api/interpreter?data=%28%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bamenity%3Dhospital%5D%3B%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bbuilding%3Dhospital%5D%3B%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bamenity%3Dembassy%5D%3B%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bdiplomatic%3Dembassy%5D%3B%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bdiplomatic%3Dconsulate%5D%3B%0A%20%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bman_made%3Dbridge%5D%3B%0A%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Bbuilding%3Dbridge%5D%3B%0A%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5BKey%3Dplace%5D%3B%0A%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Brailway%3Dstation%5D%3B%0A%20node%2843.08%2C131.84%2C43.13%2C131.93%29%5Btourism%3Dzoo%5D%3B%0A%29%3B%0Aout%3B%0A

Which returns:
<?xml version="1.0" encoding="UTF-8"?>
<osm version="0.6" generator="Overpass API <IP_ADDRESS> 3079d8ea">
<note>The data included in this document is from www.openstreetmap.org. The data is made available under ODbL.</note>
<meta osm_base="2018-10-12T13:00:02Z"/>

  <node id="292656979" lat="43.1046142" lon="131.9031830">
    <tag k="esr:user" v="980802"/>
    <tag k="name" v="Мыс Чуркин"/>
    <tag k="name:en" v="Mys Churkin"/>
    <tag k="name:ru" v="Мыс Чуркин"/>
    <tag k="railway" v="station"/>
    <tag k="wikidata" v="Q4309444"/>
    <tag k="wikipedia" v="ru:Мыс-Чуркин"/>
  </node>
  <node id="653094788" lat="43.1154793" lon="131.9071069">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Женская консультация"/>
    <tag k="name:en" v="Female consultation"/>
    <tag k="name:ru" v="Женская консультация"/>
    <tag k="operator" v="МУЗ "Городской родильный дом""/>
    <tag k="source" v="photograph"/>
  </node>
  <node id="748478673" lat="43.1269020" lon="131.9137695">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Детская поликлиника №7"/>
  </node>
  <node id="748642606" lat="43.1280520" lon="131.9052518">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Поликлиника №7"/>
  </node>
  <node id="1010183669" lat="43.1133205" lon="131.9149436">
    <tag k="alt_name" v="Городской центр медицинской профилактики."/>
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Клинико-диагностический центр г. Владивостока."/>
  </node>
  <node id="1017861711" lat="43.1111356" lon="131.9259545">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Отделение микробиологической лаборатории"/>
    <tag k="source" v="image"/>
  </node>
  <node id="1143948753" lat="43.1215174" lon="131.9072099">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Краевой психоневрологический диспансер"/>
    <tag k="opening_hours" v="Mo-Fr 08:00-20:00; Sa 09:00-15:30"/>
  </node>
  <node id="1894124126" lat="43.0923586" lon="131.9169089">
    <tag k="amenity" v="hospital"/>
  </node>
  <node id="3224648070" lat="43.1148451" lon="131.8946463">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Приморское краевое бюро судебно-медицинской экспертизы, ГБУЗ"/>
  </node>
  <node id="3965162817" lat="43.1112094" lon="131.8819268">
    <tag k="name" v="Владивосток"/>
    <tag k="name:de" v="Wladiwostok"/>
    <tag k="name:en" v="Vladivostok"/>
    <tag k="name:ja" v="ウラジオストク"/>
    <tag k="name:ko" v="블라디보스토크"/>
    <tag k="name:ru" v="Владивосток"/>
    <tag k="name:zh" v="海参崴站"/>
    <tag k="railway" v="station"/>
    <tag k="uic_name" v="Vladivostok"/>
    <tag k="uic_ref" v="2000199"/>
    <tag k="wikidata" v="Q567308"/>
    <tag k="wikipedia" v="ru:Железнодорожный вокзал Владивостока"/>
  </node>
  <node id="4917891862" lat="43.1161852" lon="131.9078650">
    <tag k="amenity" v="hospital"/>
    <tag k="description" v="Отделение восстановительного лечения"/>
    <tag k="name" v="Владивостокская поликлинника №2"/>
  </node>
  <node id="5049861926" lat="43.1226438" lon="131.8808284">
    <tag k="amenity" v="embassy"/>
    <tag k="country" v="KR"/>
    <tag k="name" v="Генеральное Консульство Республики Корея"/>
  </node>
  <node id="5063330121" lat="43.1011919" lon="131.9153792">
    <tag k="amenity" v="hospital"/>
    <tag k="name" v="Краевая клиническая больница №2"/>
  </node>

</osm>

Wow, nice! :+1:

The next steps could be:
Phase 1

In Nearby's ... menu, add a "Show OpenStreetMap notable nodes"
When enabled, run the over-pass query above in parallel, and show the nodes on the map in a different color.
When uploading from an OSM node, add to the picture's description the URL to the FSM node.

Phase 2

Modify the over-pass query to get whether the OSM node has a picture or not.
Show/hide the OSM node pin according to Nearby's "Needs photo" checkbox.
Modify the query to get whether the OSM node's Wikidata QID, if any.
Filter out OSM nodes that have a Wikidata QID, as they presumably are shown already. Or if easy, hide the pins with the same Wikidata QID as another pin already present on the map.

Phase 3
Edit OpenStreetMap to link from the OpenStreetMap node to the URL of the uploaded Commons picture.


GH-40680: [Java] Test JDK 22 in CI

Rationale for this change
JDK 22 is released. Let's ensure Arrow java CI tests this version successfully.
What changes are included in this PR?

Add JDK 22 to CI

Are these changes tested?
Tested by CI jobs
Are there any user-facing changes?
No

GitHub Issue: #40680

@github-actions crossbow submit -g java

@github-actions crossbow submit verify-rc-source-java-macos-amd64

According to crossbow, verify-rc-source-java-macos-amd64 is failing on main (not related to this PR).


⚠ Bofrost.es has degraded performance

In 776c651, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1334 ms

Resolved: Bofrost.es performance has improved in 772849a after 26 minutes.


How to remove cell's border line

JTAppleCalendar (8.0.4)
I tried to remove cell border line from the SampleJITAppleCalender, however I could not find any codes to create cell border line.
So I create my own code to initialize JTAppleCalendar by copying CellView.xib as follows.
override func viewDidLoad() {
super.viewDidLoad()
print("viewDidLoad CalenderVC")
tableView.delegate = self
tableView.dataSource = self as UITableViewDataSource
    let nibName = UINib(nibName: "CellView", bundle:Bundle.main)
    calendarView.register(nibName, forCellWithReuseIdentifier: "CellView")
    calendarView.scrollToDate(Date())
    calendarView.calendarDataSource  = self
    calendarView.calendarDelegate  = self
    self.calendarView.visibleDates {[unowned self] (visibleDates: DateSegmentInfo) in
        self.setupViewsOfCalendar(from: visibleDates)
    }
    calendarView.allowsMultipleSelection = false
    calendarView.minimumLineSpacing = 0
    calendarView.minimumInteritemSpacing = 0
    calendarView.scrollingMode = allScrollModes[6]

    selectDate = Date()
    readEventsForThisMonth()
}

[JTAPPLECalendar ScreenShot]
(https://user-images.githubusercontent.com/25836706/198818808-15dddf08-d258-4a52-b1dd-ea2bb785ae83.png)
Please advise me how to remove the border line from the cells.
Thank you.

If you want to build a calendar a better bet would be to follow the tutorials here ->
https://patchthecode.com/jtapplecalendar-home/
Click on the Build a calendar from scratch tutorial.
At the bottom of each tutorial, there is sample code given there.
BUT
keep in mind that the tutorials are in Version 7.0
So use them as a guide to build your 8.0 calendar.
Dont just copy the code and try to modify it.

I created from scratch.  The only thing I copied from the sample code was CellView.xib.
There is no code to draw border line in my code and there is no proof to remove border line when I made own.xib.
My development environment is Xcode 14.01 and IOS16.0.
I think that the SampleJTAppleCalender intentionally draw border line.
So please advice me your hidden method to draw border line.
Best regards.

Problem with that border is because it specified in xib file (CellView.xib), which is not common approach.
If you copy-past that xib you will face that border.
To remove it just search for 'layer.borderWidth' in Project to find and the delete that border.

@ARGAMX is correct.
@ymatt345 sorry i could respond sooner. I'm really tied up between projects and gave you the solution which was to create the project from scratch (no copy and paste 😉 as i wont have the time to go through this many times with everyone.)


[0.9.3 nightly] comparison operators on epoch timestamps always return true if no units supplied

There's something badly broken with comparison operators in the latest 0.9.3 nightly.
Insert two points with small epoch timestamps (in seconds):
root@sean-test:~# curl -i -XPOST 'http://localhost:8086/write?db=foo&precision=s' --data-binary 'thing value=50 900'
HTTP/1.1 204 No Content
root@sean-test:~# curl -i -XPOST 'http://localhost:8086/write?db=foo&precision=s' --data-binary 'thing value=60 910'
HTTP/1.1 204 No Content

Select the points in the CLI:
> select * from thing
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

Now it gets weird. This returns nothing, although it should at least return the first point
> select * from thing where time <= 900s

Now without the units, and it returns both points. Timestamp should be nanoseconds by default, but it doesn't matter what I use in the comparison, it always returns both points:
> select * from thing where time <= 900
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

> select * from thing where time <= 9
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

> select * from thing where time = 9
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

> select * from thing where time =<PHONE_NUMBER>999000990
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

Using explicit seconds for the time behaves as expected:
> select * from thing where time =900s
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50

> select * from thing where time = 910s
name: thing
-----------
time			value
1970-01-01T00:15:10Z	60

> select * from thing where time = 911s
> select * from thing where time >= 911s
> select * from thing where time >= 900s
name: thing
-----------
time			value
1970-01-01T00:15:00Z	50
1970-01-01T00:15:10Z	60

@DanielMorsing has agreed to take a look at this.


Is this compatible with symfony 6?

Just little question. :)
Is this compatible with symfony 6?

Showing deprecations in symfony 5.4 & symfony 6.*
Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Tetranz\Select2EntityBundle\DependencyInjection\Configuration"


how can I use the minify option for hugo building

I assume I need to change the automatic generated workflow file. But I don't see how to edit it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 878bad36-454a-063c-4100-c73f9e90aea3
Version Independent ID: b0c548c8-f830-311f-07e1-84f0ba644943
Content: Tutorial: Publish a Hugo site to Azure Static Web Apps
Content Source: articles/static-web-apps/publish-hugo.md
Service: static-web-apps
GitHub Login: @aaronpowell
Microsoft Alias: aapowell

@juhang62 Thanks for the feedback! We will review and update accordingly.

@aaronpowell, Requesting your comments on this ask.

Apologies for the delay! Based on your requirement, you just run "hugo'.
We will close this out, but if you feel you need more information please just let us know.


Fix SamePath() and make it into a receiver function

Add HasPath(paths []string) bool to Snapshot for testing if the
snapshot has at least the paths given to the function.
Reimplemented SamePath(paths []string) so it does what the name implies,
compare if all given paths are in the snapshot.
Closes #856

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is 7.14%.

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   53.46%   53.46%
=======================================
  Files          92       92
  Lines        7622     7622
=======================================
  Hits         4075     4075
  Misses       2932     2932
  Partials      615      615

Impacted Files
Coverage Δ

src/restic/snapshot.go
34.65% <0%> (ø)
:white_check_mark:

src/cmds/restic/cmd_tag.go
55.81% <0%> (ø)
:white_check_mark:

src/cmds/restic/cmd_snapshots.go
40.9% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50dc9f...ab8732c. Read the comment docs.

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is 7.14%.

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   53.46%   53.46%
=======================================
  Files          92       92
  Lines        7622     7622
=======================================
  Hits         4075     4075
  Misses       2932     2932
  Partials      615      615

Impacted Files
Coverage Δ

src/restic/snapshot.go
34.65% <0%> (ø)
:white_check_mark:

src/cmds/restic/cmd_tag.go
55.81% <0%> (ø)
:white_check_mark:

src/cmds/restic/cmd_snapshots.go
40.9% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50dc9f...ab8732c. Read the comment docs.


Artemis 1902

@mtaylor I know I have in the past asked to separate test and fix.. but I went back on that.. as it's easier to cherry-pick.. and the gitreport would make a better correlation.
You ok if we squash fix and test together on a single commit?

@clebertsuconic Feel free to squash the commits once I've updated with @michaelandrepearce feedback.  I don't really care.  However, cherry-picking should be straight forward, since both commits have the JIRA, and this PR with the commits is also posted in the JIRA.

The git release report makes it easier to correlate code added versus test added.


Default value not working.

For some reason the default option defined in following code fragment is not appearing in the interpolated object/array. I'm not familiar with ruby and not really sure how the interpolated works. Could you point me in the right direction, please? Fixed a typo along the way.
https://github.com/huginn/huginn/blob/a61924f90333b8305365273c1746bb9ea75ede57/app/models/agents/webhook_agent.rb#L47-L54

bump


ListUserPoolClientsResponseTypeDef : NextToken should be not required

Describe the bug
This is the actual definition for ListUserPoolClientsResponseTypeDef. Also I remark writing this issue that HostId is also missing in ResponseMetadata but he is required inside the actual typing.
ListUserPoolClientsResponseTypeDef = TypedDict(
    "ListUserPoolClientsResponseTypeDef",
    {
        "UserPoolClients": List[UserPoolClientDescriptionTypeDef],
        "NextToken": str,
        "ResponseMetadata": ResponseMetadataTypeDef,
    },
)

But Boto3 doesn't return NextToken if it's the last page. I suggest to change the type from str to
To Reproduce
Steps to reproduce the behavior:
bsm = BotoSesManager()
cognito_idp_client = bsm.cognitoidentityprovider_client
response = cognito_idp_client.list_user_pool_clients(UserPoolId=user_pool_id)
logger.info(response)

Actual output
Log give this output :
{
        "UserPoolClients": [],
        "ResponseMetadata": {
            "RequestId": "ec73c8d5-ab56-46aa-a6fb-43d18e10b1c0",
            "HTTPStatusCode": 200,
            "HTTPHeaders": {
                "date": "Tue, 26 Dec 2023 17:37:07 GMT",
                "content-type": "application/x-amz-json-1.1",
                "content-length": "22",
                "connection": "keep-alive",
                "x-amzn-requestid": "ec73c8d5-ab56-46aa-a6fb-43d18e10b1c0"
            },
            "RetryAttempts": 0
        }
    }

Expected output
...

Additional context
Your OS, boto3-stubs installation method, boto3 version, etc.

Thank you for the report. WIll be fixed shortly.

Similar situation with DescribeInstancesResultTypeDef:
DescribeInstancesResultTypeDef = TypedDict(
    "DescribeInstancesResultTypeDef",
    {
        "Reservations": List[ReservationTypeDef],
        "NextToken": str,
        "ResponseMetadata": ResponseMetadataTypeDef,
    },
)

Roughly half of the definitions in types_aiobotocore_ec2.type_defs which have NextToken declare it as optional, but I'm guessing it should be optional for all.

The issue has finally been fixed in mypy_boto3_builder 7.24.0 release. I have also released mypy-boto3-cognito-idp 1.34.91 with the fix included. Please update and let me know if it works as expected.


Add a CLI tool to extract data from event logs

The new tool, in examples/parse_event_log, allows dumping a CSV of all
the evaluations that were performed during a run, as well as a graphviz
(.dot) graph recapitulating the run.
telamon-utils/

src/tfrecord.rs:  Add .records() iterator method.

telamon/

Cargo.toml:  Add crates for graphviz and csv writing.
examples/print_event_log.rs:  Upgrade to the .records() API
examples/parse_event_log.rs:  Added.

bors try

Forgot to add Hash implementations for actions; should be good now.

bors try

bors r=ulysseB


Add missing link to npm-package in async docs

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe:

Adds a link to npm package flush-promises to link to additional documentation
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch.
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue-test-utils/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

great, thanks! That lib has a total of 5 lines of code. maybe we should include it in Vue Test Utils...


i got this error while compiling this, how do i fix it?

Describe your problem here.
How do i fix this? i'm using SScript-19,0,618.zip

Are you modding a build from source or with Lua?
Source
What is your build target?
Mac
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Rename Tea to TeaCall


setup.py: remove setuptools from install_requires

since the check in line 23-24 already made sure that is fulfilled. Having setuptools in install_requires seems to cause me problem in conda env.

Coverage remained the same at 100.0% when pulling ced6bd7a41bf12670696fa4e957207598199afc2 on setuptools into 64a7d30a63d991e7f385c4326be9f1a87e045d08 on master.


Upload Plugin: Image Size

Informations
Browser version: Chrome Version 62.0.3202.94 (Official Build) (64-bit)
OS: ubuntu 16.04 LTS
Screen resolution: 1920 x 1080
How to reproduce the bug?
Not a bug.
After uploading an image in Trumbowyg via the Upload plugin, is it possible to control the size of the image uploaded?

What did you mean by "size"? If it's width, user can set a width.
If you want put some width/height, you should use some CSS on img tag.

Hello @Alex-D, I am interested in showing thumbnails of the image in Trumbowyg, as opposed to the entire image uploaded. Thank you for your reply.

You just had to send the URL of the resized thumbnail image, Trumbowyg do not care about the original image size :)


PEP8 fixes.

Hello there! I'm a python beginner-programmer who'd like to collaborate in software development. I've made some adjustments to your code so it corresponds more to PEP8 convention. My I also change level of indentation to 4 spaces instead of 2 as I find it a little bit difficult to see the structure with such a small indentation? Thanks.

Cool, thanks for the changes!
Yeah I think it should be 4 spaces because that's what PEP8 specifies.  Maybe a separate pull request for that?  I'll look this over soon and merge it in


CameCase issue

Hi,
I've encountered an issue with camel casing in ScalaPB, when digit follow an undescore. Illustration of the issue below:
myemnum {
IAB1_1 = 1;
IAB11 = 181;
}
Those two entry with conflict when translated in scala class to: isIab11.
I've made a first fix [0], that work until java stuff are implied, by this I mean that scala classes are generated but e2e.sh fails because some java generated elsewhere, I could not find where. Any clues ?
Thanks
(0) : https://github.com/tabmo/ScalaPB/commit/1d4aa594079e5c7ad78516bbb8b8fbdef6bd4d45
Olivier

I pushed a commit that does something similar to what Java protoc is doing (adding _1, _2, until an available name is found). The issue is beyond underscore between digits, before this change: A_B_C and A__B__C would end up generating "def isABC". This scheme doesn't generate the optimal names for the enums in OpenRTB though.


Installation

Hi,
I'm trying to install the package as HA extension but I'm facing some issue generating the key.
I've configured the VIN, the BLE mac, etc.
However I think the keys genetation fails for some reason, see the attached log.
Any idea?
Thanks a lot !
Listening to BLE S*******************C presence detected Connecting to MQTT server; subscribe topics tesla_ble/+ and homeassistant/status Received MQTT message: tesla_ble/config generate_keys Configuration generate_keys requested Generating the private key cat: can't open 'private.pem': No such file or directory Generating the public key read EC key writing EC key cat: can't open 'public.pem': No such file or directory KEYS GENERATED. Next: 1/ Remove any previously deployed BLE keys from vehicle before deploying this one 2/ Wake the car up with your Tesla App 3/ Push the button Deploy Key

Which version do you have? 0.0.7 might fix this as I was facing the same issue.

Sorry for the confusion, 0.0.7 was Released minutes after you open this issue.
Not sure if you are familiar, but you can force a “check updates” in the add-on menu within Home Assistant. Once you’ve done that within ~15s the update should be available.

Yes please do so. 0.0.7 fixed a bug with Key deployment (although not mentioned in the changelog)

OK I'll try that update, thanks for the quick answer. I'll keep you updated.

It's working for me, I have been able to generate the key, thanks a lot 👍
It took me several attempts to have the key being sent successfully to the car, despite having the Pi relatively close to the car, but it eventually worked and commands are now sent to the car as expected.

Tomorrow I'll try to update my solar production excess automation script to rely on the BLE commands rather than the regular ones. Let's see what happens !

Thanks for the feedback
In addition, this way of setting the charge amps also allows to go below 5 amps. I could not do it through the API...

I was able to set the charge amps to a value lesser than 5 on my side...
BTW, do you think there is a way to request some data (current charging amps for instance) using the BLE API, or is it only aimed at sending actions ?

Tesla's BLE API doesn't provide this functionality

I was able to set the charge amps to a value lesser than 5 on my side... BTW, do you think there is a way to request some data (current charging amps for instance) using the BLE API, or is it only aimed at sending actions ?

See https://github.com/tesla-local-control/tesla_ble_mqtt_core/issues/25


Start Page Image missing and image color

Just like on the previous version the image on the start page should be white. So, it works with a darker background.
Currently the left image is partly blue and the image on the right-hand side does not work.

I want to fix this


Update fingerprints.py

What is your dongle ID? For what model year?

dongle id: aeba7953fb011c0e
https://useradmin.comma.ai/?onebox=aeba7953fb011c0e
2024-07-20, št, 00:18 Shane Smiskol @.***> rašė:

What is your dongle ID? For what model year?
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/pull/33027#issuecomment-2240602960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJ7J3J7SC7VPOBV32YUGYG3ZNGNETAVCNFSM6AAAAABLFKXJHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBQGYYDEOJWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Dongle, platform, VIN
Name from VIN 🆚 CarDocs
Segments
Bad seg tags
Good seg tags

aeba7953fb011c0eKIA_OPTIMA_G4KNAGW815G........
KIA  1987 🆚Kia Optima 2017
22 routes,119 segments(2.0 hours)

- valid torque params: 114- all lat active: 4- no input all lat active: 2


Load strategy defined in OneToMany decorator is ignored

Describe the bug
Load strategy joined defined in OneToMany decorator is ignored.
To Reproduce
Steps to reproduce the behavior:

Create entities

@Entity()
export class Book {

  @PrimaryKey()
  id: number;

  @Property()
  name: string;

  @OneToMany({
    entity: () => Tag,
    mappedBy: t => t.book,
    strategy: LoadStrategy.JOINED,
  })
  tags = new Collection<Tag>(this);
}

@Entity()
export class Tag {

  @PrimaryKey()
  id: number;

  @Property()
  tag: string;

  @ManyToOne()
  book: Book
}

Run query

this.bookRepo.find({}, { populate: ['tags'] })

Here is repo to reproduce this bug.
Current behavior
Debugger shows query with select in approach
Expected behavior
Used joined strategy
Versions

Dependency
Version

node
16.13.1

typescript
4.5.5

mikro-orm
5.0.3

Thanks, I can confirm this behaviour, will look into it later today.
Failing test case:
import { Collection, Entity, LoadStrategy, ManyToOne, MikroORM, OneToMany, PrimaryKey, Property } from '@mikro-orm/core';
import type { SqliteDriver } from '@mikro-orm/sqlite';
import { mockLogger } from '../helpers';

@Entity()
export class Book {

  @PrimaryKey()
  id!: number;

  @Property()
  name?: string;

  @OneToMany({
    // eslint-disable-next-line @typescript-eslint/no-use-before-define
    entity: () => Tag,
    mappedBy: t => t.book,
    strategy: LoadStrategy.JOINED,
  })
  tags = new Collection<Tag>(this);

}

@Entity()
export class Tag {

  @PrimaryKey()
  id!: number;

  @ManyToOne(() => Book)
  book!: Book;

}

describe('GH issue 2803', () => {

  let orm: MikroORM<SqliteDriver>;

  beforeAll(async () => {
    orm = await MikroORM.init({
      type: 'sqlite',
      dbName: ':memory:',
      entities: [Book, Tag],
    });
    await orm.getSchemaGenerator().createSchema();
  });

  afterAll(async () => {
    await orm.close(true);
  });

  test(`load strategy defined on property level is respected`, async () => {
    const b = orm.em.create(Book, {
      name: 'b',
      tags: [{}, {}, {}],
    });
    await orm.em.fork().persist(b).flush();

    const mock = mockLogger(orm, ['query']);
    const ret = await orm.em.find(Book, {}, { populate: ['tags'] });
    expect(ret[0].tags).toHaveLength(3);
    expect(mock).toBeCalledTimes(1);
  });

});


pop can't call lock method well

I do navigator.push() and execute lockToLANDSCAPE in componentDidMount method and I get LANDSCAPE orientation.
then I want to navigator.pop() and expect back to PORTRAIT orientation, so I call lockToPortrait after pop, it works.
.. but I find that device orientation can't change to PORTRAIT if I already put my device in PORTRAIT orientation (lockToLANDSCAPE now) when I prepare to pop.
how should I fix it?
thanks for your time.

any idea now :)

er..  does this smart project continually maintained?

@L-Jovi this package just got a couple more collaborators so we're working through the issues. Is this still happening to your application? I believe the package has advanced quite a bit since then, could you test it with the updated version? Please refer to README for detailed instructions to install.


if the first sentence is identical, the sacreBleu score is<PHONE_NUMBER>?

I got this wierd Bleu value from python API. Anyone know why? How to fix it? Thanks.
"BLEU = 100.00 100.0/100.0/100.0/100.0 (BP = 1.000 ratio = 1.000 hyp_len = 6 ref_len = 6)
100.00000000000004
nrefs:3|case:mixed|eff:no|tok:13a|smooth:exp|version:2.4.3"
I formatted my reference as : [['The dog bit the man.'], ['It was not unexpected.'], ['The man bit him first.']]
The exact comparison of reference and hypothesis are not 100% same:

Reference: The dog bit the man.
Hypothesis: The dog bit the man.

Reference: It was not unexpected.
Hypothesis: It wasn't surprising.

Reference: The man bit him first.
Hypothesis: The man had just bitten him.

I formatted my reference as : [['The dog bit the man.'], ['It was not unexpected.'], ['The man bit him first.']]

I guess you followed https://github.com/mjpost/sacrebleu#using-sacrebleu-from-python and just substituted the refs = statement with
refs = [['The dog bit the man.'], ['It was not unexpected.'], ['The man bit him first.']]

However, this means there are three alternative sets of references (len(refs)==3) and each set contains translation of the first sentence only.
The first reference set has identical translation of this first sentence as the system, so all the n-grams are matching. No reference set provides a translation for the second and third sentence, so these are ignored.
Thus the result (BLEU = 100) is correct.
You probably wanted to specify a single reference set with three sentences. That would be
refs = [['The dog bit the man.', 'It was not unexpected.', 'The man bit him first.']]

which would result in BLEU = 45.07.
I think, originally, SacreBLEU had sanity checks that the length of each reference (number of sentences) is the same as the length of the system, but then we introduced the option of some sentences missing in some of the references (and variable number of references, see #132 and #161) and we perhaps removed the sanity checks.
I admit misunderstanding the structure of the refs is a very common problem (@Sijia324 is not the first one to be confused), despite we've added comments such as "# First set of references" to the example API usage.
I am closing this issue, but if there is a volunteer willing to read these issues, study the source codes and come up with a way that would allow all the legal use cases, but prevent this kind of misunderstanding, a PR will be welcome.

Thanks, I did not know BLEU will ignore if the reference is empty. And yes, I was super confused with the format of reference. Thanks for correcting it!!!


[Tabular] Online inference optimization

Issue #, if available:
Description of changes:

2.5x+ speedup of online-inference latency in feature generation.
7.8x+ speedup when text features are present.
~30%+ speedup for FastAI NN inference when many features are present.
Slight speedup for LightGBM when text features are present.

TODO:

[ ] Benchmark

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1136-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1136/3/index.html

Job PR-1136-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1136/4/index.html

Benchmark results are good, overall accuracy improvement, likely due to improved handling of rare categories (which also speeds up online-inference). Inference speedup isn't visible in the benchmark since it is batch inference. 0 errors.
AutoGluon_bestquality_1h_2021_04_24_reorder VS all
                                     framework  > AutoGluon_bestquality_1h_2021_04_24_reorder  < AutoGluon_bestquality_1h_2021_04_24_reorder  = AutoGluon_bestquality_1h_2021_04_24_reorder  % Less Avg. Errors Than AutoGluon_bestquality_1h_2021_04_24_reorder  time_train_s  metric_error  time_infer_s  loss_rescaled  time_train_s_rescaled  time_infer_s_rescaled      rank  rank=1_count  rank=2_count  rank=3_count  rank>3_count  error_count
0   AutoGluon_bestquality_1h_2021_05_31_infopt                                            482                                            423                                             72                                            0.97036                     3350.043091  71991.170791     34.644831       0.444217               1.016989               1.264567  1.469806           482           495             0             0            0
1  AutoGluon_bestquality_1h_2021_04_24_reorder                                              0                                              0                                            977                                            0.00000                     3389.406448  72121.458546     33.485568       0.507677               1.027032               1.222007  1.530194           423           554             0             0            0

AutoGluon_bestquality_1h_2021_04_24_reorder is equivalent to mainline.
AutoGluon_bestquality_1h_2021_05_31_infopt is this PR's branch.


Drop pinkie-promise.

Closes #487.

Waiting on #489.
gulp-mocha is not recognizing Promise.

I think env in .eslintrc needs to have es6 set to true for Promise to be defined.  I can do that, but I do not think that that falls under the scope of this PR.

@wtgtybhertgeghgtwtg I think it does, we'll only merge green build :)

I will update the .eslintrc, but it will still not be green, since the node 0.12 version is failing due to an issue in gulp-exclude-gitignore.  Same reason #489 failed.

@wtgtybhertgeghgtwtg You can merge yeoman:master to get rid of node 0.10 since #489 has landed.

@yeoman what about dropping Support for node 0.12 😂
Since the doctors says:
✔ Global configuration file is valid
✔ NODE_PATH matches the npm root
✖ Node.js version
Your Node.js version is outdated.
Upgrade to the latest version: https://nodejs.org

Everything is passing except for coverage, which has decreased.

Thanks :octocat:
Your PR did it to the master branch and will be included in the next release.

Thank you for your time.
If you were serious about dropping support for 0.12, I would love to help.

If you were serious about dropping support for 0.12

Nah, not yet :see_no_evil:


Add new GMOS DRAGONS data reduction NB

@jacquesalice could you please review this PR? I made only minimal changes to this latest version by Susan and Vini (e.g., update datestring, fixed a few typos, added "This will take 2 minutes" comments to two long-running cells, and cleared the outputs (b/c otherwise the NB swells to 7.5 MB instead of 200 KB or so without the outputs). Also added rendered HTML version.

Oh, sorry, I left the outputs in. I'll remove them and upload a new version

Done

@jacquesalice Good catch; the cleanup cell doesn't work for me either. The reasons seems to be that the working directory is the root dir of the user, not the dir where the NB is. (but I'm somewhat surprised that the wget cell that fetches the data seems to be working fine. And it doesn't look like a permissions issue because in the terminal the files are owned by the user, and I can delete them there.
I'll email Vini and Susan, and Mike (maybe it's something with the DRAGONS kernel). Let's hold off on merging for the moment.


ENH: Allow creation of TrajectoryGroup from iterable of specific filenames

Previously, TrajectoryGroup classes required a wildcard path and gobbled up all files matching that pattern.
In some case one might wants to analyze a specific subgroup of files identified by some other means. This patch allows TrajectoryGroup generation from a specific set of file names, with backwards compatibility.

This looks good!  Thanks!


[187] Add hidden label

Description
Adds hidden label in Inputs #187
Checklist:
Please delete options that are not relevant.

[*] Is this a new feature
[*] Have you submitted new feature or bugfix issue? Unless it's a small bugix, we generally prefer to track PRs against an issue which starts a dialogue to give us context.
[*] Tests passing
[*] Have you added to the framework's /examples apps? e.g. agnosticui-react/examples? These are kitchen sink sanity checks which help to verify a component is working and derive documentation snippets.

@apiotrowski312 thanks for taking the time to get this in! I think we might as well have a Storybook story in the Svelte implementation too (esp. since you've added for Vue and React already). What do you think? It's not a big deal if you've ran out of time to allocate to this (I/we can add this on subsequent iterations too) LMK what you think and thanks again!


the DubugToolbar was needed in Middleware classes

This middelware line was needed to get past an error in the instructions given in the read the docs.

Thanks @wroscoe ! I have added a few more requisite changes and merged them to master in my latest commit 3a17284f63b07ce91a0313ff69c3b966738c70d1


Gelu activation

This PR adds Gelu Activation Function. closes #165

Thanks for the contribution! Where did you take the test data for Gelu?

Hey @zaleslaw I hope you are doing well, I took the test cases from tf.addons

Ha-ha, @therealansh "I hope you are doing well" In this context looks like "hey, buddy, open your eyes, I hope you are able to read a code today":)

Haha, no no I meant to ask about your well being only. And as for the PR i'll add some comments and docs about it.

@therealansh please merge your branch with master; you will be the following in the merge queue (after that, I'll run the TC)


Add antimicrobial resistance annotations

With this PR we add a pipeline to extract AMR annotations using the AMRFinderPlus software and add them to the database. I also added the annotations to the locus and orthogroup views.
Also note that:

currently only docker is supported, will add conda support later.
I had to fix a few f-strings that got broken by autopep8. It seems that pycodestyle does not correctly support f-strings.

Screenshot of the annotations on a locus tag view

Nice work!
I would remove the scope and add the gene symbol to the table (with a link to the NCBI entry of the HMM, e.g https://www.ncbi.nlm.nih.gov/genome/annotation_prok/evidence/NF033374/)

Ok I've added the gene with a link to the HMM profile, but I left the "scope" column, as this is pretty important (if unclear). I've added a tooltip to the table to send users to the AMRFinderPlus documentation for more information on the fields.


Add mouse tween, ease and curve functionality to mouse movement.

Feature request.
Expected Behavior
Somewhat human-like/natural mouse movement. PyAutoGUI and others have this functionality (see doco).
Actual Behavior
Mouse simply disappears from one place and appears in another.
Steps to Reproduce the Problem
Any code  to move the mouse.
Short Example of Code to Demonstrate the Problem
import pywinauto, time
pywinauto.mouse.move(coords=(1,1))
time.sleep(2)
pywinauto.mouse.move(coords=(500,500))

Hi pywinauto team,
Here is a proposition for drag_mouse_input() in base_wrapper.py,
the end of the code can be replaced by something like:
        self.press_mouse_input(button, press_coords, pressed, absolute=absolute)
        time.sleep(Timings.before_drag_wait)
        vec_x, vec_y = release_coords[0]-press_coords[0], release_coords[1]-press_coords[1]
        steps = 5
        vec_x, vec_y = vec_x / float(steps), vec_y / float(steps)
        for i in range(1, steps):
            self.move_mouse_input(
                (int(press_coords[0] + i*vec_x + .5),
                 int(press_coords[1] + i*vec_y + .5)),
                 pressed=pressed, absolute=absolute)
            time.sleep(Timings.drag_n_drop_move_mouse_wait)
        self.move_mouse_input(release_coords, pressed=pressed, absolute=absolute)
        time.sleep(Timings.before_drop_wait)
        self.release_mouse_input(button, release_coords, pressed, absolute=absolute)
        time.sleep(Timings.after_drag_n_drop_wait)
        return self

In the original code, the steps were hardcoded to 5, I kept like this. But it could be exposed as a parameter of the drag_mouse_input() method. In any case, by playing with the different Timings, any end user can simulate a human drag-&-drop


Deal with ties

Currently, villagers win when all players are dead (hunter dies second to last).
Should probably be a tie instead.

Implemented together with lover win on cupid branch


Taking up too much of memory ram

Hello,
I have a problem while training. Every after epoch, it is taking up a bit of the memory ram.
Is there any way to solve this?
Thanks,

In my case, this source code does not consume much RAM and GPU resources.
I refer you to check another process is running together.
If not you can adjust the source code on your desktop for minimizing RAM consumption as your need.


Swift 2.3 support

Hi,
Thank you for amazing work!
We are upgrading our project to be compatible with XCode 8.
For now, we decided to use swift 2.3 before we migrate to swift 3. During this process, we found few problems in version 1.1.0.
AnimatedMenuButton.swift:70:69: Value of optional type 'CGPath?' not unwrapped; did you mean to use '!' or '?'?

AnimatedMenuButton.swift:72:53: Value of optional type 'CGPath?' not unwrapped; did you mean to use '!' or '?'?

DrawerController.swift:711:91: Value of optional type 'CGPath?' not unwrapped; did you mean to use '!' or '?'?

seems like they are just some simple syntax issues, do you have a plan to create a patch for it?
And version 1.1.1 looks like swift 3 version, and we are not quite ready for that.
Do you want us to make a quick PR for this fix and maybe release it as <IP_ADDRESS>?
Thanks.

+1, I have exactly the same problem.

This would be great

I have the same problem but with swift 3

I've made a folk for this fix.
Just not sure if it is needed.

I've made a fork. It's not a big deal, but it can save some time until we make projects compatible with Swift 3.

I've released DrawerController 2.0.0 with Swift 2.3 support and DrawerController 3.0.0 with Swift 3.0 support.


compactor: adds downsample duration histogram

Signed-off-by: Anugrah Vijay<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Registers and implements downsampleDuration histogram.
New var for downsample duration to avoid recomputing time.Since across logs/metric.

Verification

TBD

Based on @yeya24 's feedback on the previous PR I will be:

Adding the downsample resolution as label to the histogram.
Increasing the starting bucket size

With respect to the histogram buckets, we could get rid of the initial few buckets and make it 64, 128, 256, 512, 1024, 2048, 4096, 8192 or we could define more user friendly intervals such as 1m, 5m, 15m, 30m, 1h, 2h, 4h. WDYT?

Anything you still want to update? @vanugrah If not please mark this pr ready for review. 😄

Bucket ranges?  Currently it mimics the compactors geometric  series: 64, 128, 256, 512, 1024, 2048, 4096, 8192.
But changing that to recognizable intervals may be more user friendly: 1m, 5m, 15m, 30m, 60m, 120m, 240m.

Bucket ranges? Currently it mimics the compactors geometric series: 64, 128, 256, 512, 1024, 2048, 4096, 8192.
But changing that to recognizable intervals may be more user friendly: 1m, 5m, 15m, 30m, 60m, 120m, 240m.

Latter sounds better.

😄 Thanks for the speedy feedback!

So for flakey e2e tests do we just rerun?

So for flakey e2e tests do we just rerun?

I restarted it and it is passing now

Wooot 🎉  Thanks for your help @yeya24 . More PR's soon to come.

@GiedriusS Any thoughts?

@yeya24  Your review was marked stale because I had to resolve a merge conflict on the Changelog. Care to re-review?


Show top free places

Chtěl jsem udělat jednodušší use-case "jaké si mám vybrat očkovací místo".

Thanks, I will test it today, I have one remark. Unfortunately the process is not so simple and you cannot say that the place with most free slots is the best one. We don't like to confuse people so it is necessary to offer a proper wording and maybe to add more criterias to find the best place.
My idea: add number of vaccinated peoples in last 7 days, free vaccines (new calculation will be done today, the current one is a little bit delayed) and number of people in the queue.

My aim was to make it as easy as possible to tell in which place I will be probably vaccinated first.
If I understand you correctly "free spots" include spots which might not be accessible because there is someone else "in queue" (someone else has PIN2 to this place or is waiting to get one). Number of these people is known (at least approximately; it's shown on the place page).
Based on this I would propose calculating a metric as people waiting / free spots ("Poměr počtu čekajících lidí na volná místa") and sorting places by it. The number might not be precise or fully understandable for people, but it would be good quick indication which place to show. Nonetheless it would be good to explain how it's calculated.

Yes, they might not be accessible for you, because someone else has higher priority or the center doesn't have enough vaccines. E.g. center creates 200 slots per day, but they don't have enough vaccines, so they allow only 100 people to choose a time slot.
It's not the same for all centers, good examle could be: https://ockovani.opendatalab.cz/misto/9cf6f860-3089-4f8b-abf9-86109580dd7e (probably new center, almost no vaccines / vaccinated people / people in queue, but lot of free slots).
Now we want to add another column with count of people in queue and ratio of successful reservations (registered in last 7 days and were able to choose a slot).
Another good metric could be average waiting time - but it requires additional computation and historization of fetched data (#90)

As it was discussed above - free slots are confusing so we've switched to vaccination speed / queues. Sorry for that, but we are still open to any collaboration.


Add arm64 OSX build

Hi
I want to make a device tree support extension for a zed editor based on your language server.
As Zed introduced Linux support, I want to make it more suitable for embedded Linux development. Still, a considerable part of the community uses Zed on Apple silicone-based Macs, even though it may not be for a device tree extension.
This small commit adds an aarch64 build and release to the CI.
An extension can fetch it from GitHub releases and use LSP.

Thanks! I'll try to publish a new version on weekends, current master has diagnostics enabled, which are not yet stable enough for release.


Can't click links near to the top of readmes

The padding of .plugin-page .install .content-column plus the height: 100%; is such that is overhangs its parent and overlaps the very top of the readme text. This renders links near the top unclickable.

Good find! The README should actually be beneath the "install from" box, but over the years apparently there's been a regression, although the CSS or HTML has not changed (but browsers have!).
It should actually look like this:

That's done with a clear: both.

Ah, good to know. Should be fixable.
--
Jordan Eldredge
Please excuse any typos or terseness; this email was sent from a mobile device.

On Feb 9, 2016, at 8:03 PM, David Hu<EMAIL_ADDRESS>wrote:
Good find! The README should actually be beneath the "install from" box, but over the years apparently there's been a regression, although the CSS or HTML has not changed (but browsers have!).
It should actually look like this:
That's done with a clear: both.
—
Reply to this email directly or view it on GitHub.


Dynamic update of graph

Is it possible to update the data dynamically without re-rendering the whole graph from scratch?

Have to add my +1 - pretty keen for this

any idea on how to do this? how to update a datapoint after chart has been created

I will take a look at some solution for this when i have time. If anyone else has some ideas on how to solve this, feel free to put together a PR, or some examples.

This is pretty crucial. Destroying the chart and re-creating almost seems more expensive than updating data points under the hood, especially in a UI where interaction and graphs are very frequent.

Another +1 from me. It feels very odd not to have this feature as it kind of goes against the angular-mentality.

Closing, as opened new issue for implementing this #43 can move any further discussion to that issue.


Code of Conduct

I added a requirement that the Contribute section should link to the Code of Conduct. Normally, this is in a separate document or in the Contribute.md, as far as I've seen before.
Should we provide suggestions?
Also, what code of conduct should we use? I know there are some standards, like the Contribute covenant http://contributor-covenant.org/version/1/3/0/.

It shouldn't be requirement, imo.

@tunnckoCore I think it should be - it influences how people view, use, and contribute to your project. A lot of people need to know there is a safe space before they're going to use your code.
This might be helpful! http://www.ashedryden.com/blog/codes-of-conduct-101-faq

Thinking about the modularity aspect -- a CoC may be more important for pan-organization things, maybe not for individual modules which need a README. @noffle what do you think?

not for individual modules

Exactly. I think contributing file is enough for most cases.

Agreed.
On Jun 3, 2016 3:05 AM, "Richard Littauer"<EMAIL_ADDRESS>wrote:

Thinking about the modularity aspect -- a CoC may be more important for
pan-organization things, maybe not for individual modules which need a
README. @noffle https://github.com/noffle what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RichardLitt/standard-readme/issues/17#issuecomment-223541099,
or mute the thread
https://github.com/notifications/unsubscribe/AAd3ku-tgGIbTQZz7YuhDjwveawcHHtRks5qH_xegaJpZM4IsXz7
.

Made optional.


Order of packages in requirements.txt -- pip-compile vs. pip freeze

The issue regards packages with names containing - character or a digit. This may cause an unexpected order of packages in the output file, different than with pip freeze. It seems that the output file is sorted by the whole lines, together with == and version name, instead of just by the package names.
Environment Versions

Windows 10
Python version: 3.7.6
pip version: 21.1.2
pip-tools version: 6.1.0

Steps to replicate
pip-compile with requirements.in file:
django
django-redis
django-sendfile
django-sendfile2
djangorestframework

Expected result
(without comments and additional libraries, for clarity)
django==3.2.4
django-redis==5.0.0
django-sendfile==0.3.11
django-sendfile2==0.6.0
djangorestframework==3.12.4

Actual result
django-redis==5.0.0
django-sendfile2==0.6.0
django-sendfile==0.3.11
django==3.2.4
djangorestframework==3.12.4

I am not sure we really need a fix for this, it would add extra complexity for a very minor benefit.

It's certainly not a big issue, but it causes some inconveniences:

When migrating from pip freeze, the shuffle of the packages creates a bigger diff than necessary, and thus makes it harder to review the changes introduced by pip-compile.
When reading the generated list of packages, it's harder to find the one we're looking for, since we know how lexicographic order should work.

It's a bit surprising to read that fixing this would add extra complexity. I've looked at the code and it seems like the issue is here:
https://github.com/jazzband/pip-tools/blob/f953ceb8840b5b653ef94d7b9bc172192413e0a8/piptools/writer.py#L91-L92
I've tried changing locally str(ireq.req).lower() to ireq.req.name.lower() and it works like expected.

Yeah, this would make sense to sync packages ordering with pip freeze, which is a case-insensitive sorted order.

I've tried changing locally str(ireq.req).lower() to ireq.req.name.lower() and it works like expected.

Try also key_from_ireq(ireq)).
@adamsol feel free to open a PR 👍🏻


Enable setting widget styling props from theme

For all props defined under styles, I expect to be able to set them from the theme.
Priority:

Button
Text
Divider
Switch
Dropdown
Progress
TabBar
All remaining widgets

@amin-nas this is done with @snehmehta 's theme changes right?

@kmahmood74 negative


C. elegans references use WormBase mapping to INSDC protein ids

Description
Changes affecting vertebrates run of the pipeline

Bits of RefSeqGPFFParser. The rest of the new behaviour was added by subclassing and inheritance. *

All changes

rewrite WormbaseDirectParser
WormbaseDirectParser populates protein_ids
new xref: wormbase_cds
superclass method to make dependent protein_ids as parent
tap into UniProtParser

also skip EMBL scaffold ids (we can't reliably assign them)

tap into RefSeqGPFFParser

extract two methods so that I can subclass them
fix a loose "next" instead of "return"

tests for new stuff

Use case
C. elegans can have better xrefs in WormBase ParaSite.
Benefits
For Ensembl:
The changes in RefSeqGPFFParser are a very minor change for the better. Test coverage for UniProtParser and RefSeqGPFFParser.
Organisational:
Easier to maintain if WormBase specific behaviour is inside the code base as long as we're responsible. Ensembl can refactor without breaking our code (and a test will fail if it breaks).
Benefits - RefSeqGPFFParser:
This change fixes this spurious mapping of paralogs.
Benefits - UniProtParser:
Not the above: UniProt entries are not tied to coordinates so all
paralogs map to the same entry. We can handle versioning and updates
a bit better: if WormBase updates an entry and a protein id changes but
UniProt doesn't reflect this yet, with the change we will still pick up
the UniProt entry although we can't sequence match any more.
Possible Drawbacks
The repo will take a bit longer to download. The test suite will run a bit longer.
Testing
I unit tested relevant old code and new code. I did ~ 7 all-pipeline runs of this code in various stages of completion.

The newest DBD::mysql is broken. I've raised the issue in https://github.com/perl5-dbi/DBD-mysql/issues/263. My changes to the cpanfile fix this build, but maybe you had a reason to require rather than test_require DBD::mysql?

DBD::mysql should be a requirement, our whole API depends on it
We are looking into it, so you can ignore this error for the moment.
Your tests fail with the latest Perl 5.26 though

Coverage increased (+0.2%) to 81.323% when pulling d4b187a6ba40e5de62d1e39ef0aa8b7c42fa0039 on wbazant:master into 196f451313cf103a3f4a3a191b5de7948f90b8ec on Ensembl:master.

Overall, the changes look fine to me, it is also nice to get more tests.
I would like to do a test run on a handful of vertebrate species to ensure we have not missed any dependencies, this will not happen before the 1st week of October.
Are you OK with keeping the PR opened until then or should we restart the conversation once I'm back?

@magaliruffier I have adjusted the commit, changing the names of the files. Can you review again?
The files that say "Wormbase" at the front are meant to be specific to the WormBase run of the pipeline. Reviewing it to search for bugs and giving @khowe and me tips on good software engineering techniques is appreciated, but perhaps above and beyond necessary: a reviewer might satisfy themselves with searching for the string "Wormbase" in the Ensembl codebase to verify that the files are not referred to by the vertebrate run of the pipeline.
I have also changed a test: there's no CI at the moment so I can only assert that the tests pass at least on the Ensembl's installation of Perl in the EBI.
The only change in this PR that doesn't say "Wormbase" at the front or is a test file is in RefSeqGPFFParser. It is of relatively simple nature - it extracts a method and changes block indentation - and perhaps a reviewer could just read it. I am happy to justify it more or engage into a discussion about what it might affect or be done better.
I am not sure which bit of this PR you are unsure about, that completing a run on a handful of vertebrate species could help clear out. It is highly unfortunate if this were necessary, could only be done by you (can I do this run? what should I pay attention to that might be made different by this change? ) and could only happen in a month.

@magaliruffier I've reused the PR for some more work on this. I've done minor changes to RefSeqGPFFParser that don't intend to change behaviour.
For C. elegans in our run:

UniProtParser: entries linking to multiple EMBL proteins create multiple xrefs
new cross-reference to wormbase_cds
our subclassed RefSeqGPFFParser can do both protein and transcript entries
use wormbase_cds to link mRNA and ncRNA RefSeq entries

Can you have a look? The CI fails but I think it's unrelated.

Overall, the changes look fine to me. I should have some time this week to do a test run, then it should all be good to go.
Travis fails because of some discrepancy between the release versions, if you rebase against the latest master, that should fix it.

I only needed to rebase to fix the build. Now 1 successful check has passed. @magaliruffier would you also be able to arrange at least 1 approving review by reviewers with write access?

I was doing a test run to compare with an existing run on the same data but without the code change.
Unfortunately, it is still running when it should have finished by now. My pipeline is stuck in the parsing stage, parsing RefSeq GPFF files. According to eHive, the average takes over 1h when it took 4 minute in the previous run.
It could still be that there is a problem with the database load or the file system that is independent of the code changes, so I will try again and let you know.
 It's intentional  - I didn't think it will be very wasteful and I wanted to change fewer things - but it's the culprit, it's easy to fix.

I'm running the parser under a profiler now, I will see what shows up.

prof-after.txt
prof-before.txt
I'm not sure why the if statement block shows up as taking a lot of time before, and is gone after. Thank you for catching that! My pipeline runs also took ages, but I didn't really reflect on it :)

OK, let me try that again ;-)

Run times are comparable now, average 5 min per job. Still a bit more than the previous run, but that's more in the line of just general variability due to resource contention
I'll let the pipeline run to completion to compare the overall result and will let you know how it goes

I finally managed to get two comparable runs of the pipeline, once with and once without your changes.
I can confirm that the results are mostly the same. There are some small differences which I believe are due to consecutive runs rather than code changes.
I'll let someone else from Core have a look at the code but otherwise I think it is good to be merged in

@tgrego thank you for the review! See if I addressed everything. If you apply this PR, refactor RefSeqGPFFParser on top of that, and the unit tests still pass, WormBase stuff will fairly likely still be good but I'll follow the developments!


Is it possible to use a multiline body for POSTs?

I would like to make the following request with a multiline body:
POST /myapi
{
    "a": true
}

Is this possible with http-prompt?

@wsw70 ,
if you mean defining request data (query/body) across multiple lines in the http-prompt console, it's not currently possible.
if you want to send json data object, you can use --json httpie option..:
locahost/myapi> post a=true --json

This feature should be a subset of #75.


⚠ Bofrost.de has degraded performance

In d671fe7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1083 ms

Resolved: Bofrost.de performance has improved in 2400c08 after 1 hour, 2 minutes.


"process did not execute because the precondition is false" Download,Extract,Symbolize

10.7.1 ArcGIS, trying to run Download,Extract Symbolize. Tool fully runs but I am getting empty an empty feature dataset. The only errors I'm seeing in the geoprocessing tool is "the process did not execute because the precondition is false".

Could you please post the full set of geoprocessing messages the tool is producing? It will provide us with some clues about what might be going on.


Update README.md

Summary

Related issue :

We already have another PR on which we are collaboratively discussing this: https://github.com/interTwin-eu/itwinai/pull/238/
So please close this to avoid unnecessary duplication


Fontawesome 5 Pro removed again in version 2.13.12

I have check nativebase version in 2.13.12 Fontawesome 5 Pro was removed again, but on this link look like already merged https://github.com/GeekyAnts/NativeBase/issues/2691

Looks like it was removed ~10days after addition: https://github.com/GeekyAnts/NativeBase/pull/2793
No comments, issues, explanation on that PR -- perhaps @PlabanJr can clarify?
I'm guessing it broke things for non-FA5Pro users, but more information would be nice to work toward a proper solution


WRKLDS-1309: Use grade A image to cover warnings

Previous image's grade is C and Konflux fails in releasing process by throwing an error. This PR uses grade A image.

/lgtm


Rust error format updates and IDE support

I'm not sure if this will impact you, but I wanted to mention that we're currently talking about updating the Rust error format.  For plugins using a regex style parse of the errors, this will likely have some impact.
If this PR is accepted, it will only initially impact the nightly builds.  There are some weeks between the PR going it and a stable release including the new format.  We'd like to use that time to make the transition as easy as possible.
As part of the PR, we're also enabling a supported JSON mode which IDE plugins can optionally use.  It has the same information as the error text, but in a more structured way.
Please feel free to jump in on the PR thread and let us know if this impacts your plugin.

This does indeed impact VisualRust, also compare #113. I might be able to work on porting the error recognition to use the JSON mode, once the PR has landed. In order to support previous rustc versions (and current stable), we probably need to switch modes based on the rustc version.

I have already written some code for json error in https://github.com/Vbif/VisualRust/tree/json_error_format

@Vbif: This looks quite good, thanks! I think that using JSON errors shouldn't be a build option, though. Instead, VisualRust should transparently choose which error format is best, based on the version of rustc. It should never use -Z unstable-options now that this is becoming stable. Could you change this and open a PR?
@vosen: What do you think?

@Boddlnagg remove unstable is easy. How can i determine rustc version? First run rustc with --version every build?

@Vbif That is a very good question, and I don't have a good idea yet. Maybe it's possible to run rustc -V in the beginning of each "session", i.e. whenever a project is opened? I don't know a lot about the project system though, and this might not work at all, because the error parser is only part of the MSBuild plugin for Rust, and there probably is no "session".
Probably running rustc -V on every build as you proposed is the easiest way to make this work in the short term, and we can still change/optimize it later. I think that some kind toolchain version detection is also useful for other parts.

https://github.com/PistonDevelopers/VisualRust/pull/230

Great to see some progress here!
Friendly reminder - I'm going to each plugin and letting them know we're 17 days away from Rust 1.12 being released.  This is the first release that uses the new error format (and removes support for the old format).  It also has the standardized JSON errors.

@jonathandturner Thanks for the reminder! We're going to be able to push this PR through the finish line until the release of 1.12, but I can't do a VisualRust release. I think only @vosen (this project's official maintainer) can do that, and he hasn't responded in the last weeks.

#230 has been merged.


🐛 Possible homebrew issues

Hello.
I have made sure all my files are update that being both your CLI and the 5etools mirror. I think it its just the Homebrew files that are coming back with errors.
This is the current errors i get when running my full config and CLI
≡ƒ¢æ Could not find title for OptionalFeatureType: EM from Kobold Press; Deep Magic 14 Elemental Magic.json
≡ƒ¢æ Could not find title for OptionalFeatureType: OF from Kobold Press; Deep Magic Backgrounds, Feats, & Subclasses.json
≡ƒ¢æ Could not find title for OptionalFeatureType: HRG from Kobold Press; Deep Magic Backgrounds, Feats, & Subclasses.json
≡ƒÆí Writing files to E:\CLI\5eTools\bin\dm
≡ƒ¢æ Can not find OptionalFeatureType for optional feature progression Blood Curse: {"name":"Blood Curse","featureType":["Blood Curse"],"progression":[0,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,6]}
≡ƒ¢æ What alignment is this? CECN (from sources[monster|kappa|ccodex])

As you can tell I'm converting almost all the Kobold Press material and just Matthew mercer's BloodHunter Class.
I have added copies of my Config and the CLI code I'm currently using.
Config
https://github.com/NoMansbacon/ObsidianVault/blob/main/dm-sources.json
CLI Code
ttrpg-convert.exe --index -o dm -c dm-sources.json 5etools-mirror-1.github.io\data "homebrew/creature/Kobold Press; Tome of Beasts.json" "homebrew/creature/Kobold Press; Tome of Beasts 3.json" "homebrew/creature/Kobold Press; Tome of Beasts 2.json" "homebrew/creature/Kobold Press; Creature Codex.json" "homebrew/creature/Kobold Press; Gem Dragons of Faerun.json" "homebrew\class\Matthew Mercer; Blood Hunter.json" "homebrew\collection\Kobold Press; Tome of Heroes.json" "homebrew\collection\Kobold Press; Deep Magic Backgrounds, Feats, & Subclasses.json" "homebrew\collection\Kobold Press; Deep Magic 01 Clockwork Magic.json" "homebrew\collection\Kobold Press; Deep Magic 03 Void Magic.json" "homebrew\collection\Kobold Press; Deep Magic 04 Illumination Magic.json" "homebrew\collection\Kobold Press; Deep Magic 08 Battle Magic.json" "homebrew\collection\Kobold Press; Deep Magic 13 Dragon Magic.json" "homebrew\collection\Kobold Press; Deep Magic 14 Elemental Magic.json" "homebrew\collection\Kobold Press; Deep Magic 16 Time Magic.json" "homebrew\collection\Kobold Press; Deep Magic 17 Mythos Magic.json"

Have a fix for "What alignment is this? CECN (from sources[monster|kappa|ccodex])"

These are from missing data in the homebrew (I've opened issues for these):

Could not find title for OptionalFeatureType: EM from Kobold Press; Deep Magic 14 Elemental Magic.json
Could not find title for OptionalFeatureType: OF from Kobold Press; Deep Magic Backgrounds, Feats, & Subclasses.json
Could not find title for OptionalFeatureType: HRG from Kobold Press; Deep Magic Backgrounds, Feats, & Subclasses.json

I've downgraded the message to a warning, and will use the abbreviation for the title if the title is missing.

This is a similar issue, I've downgraded to a warning, and will use the name if I can't find anything else (which works out fine)

Can not find OptionalFeatureType for optional feature progression Blood Curse: {"name":"Blood Curse","featureType":["Blood Curse"],"progression":[0,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,6]}


Spawn Notebook With Arguments: fail if the retry count is exhausted

Without this patch, the keyword would try ${retries} times and
return happily, even if none of the tries succeeded.

updated with the IF after the test, and retries_delay of 0 seconds by default

@lugi0 no I don't think I can trigger the test on Jenkins, if you can please kick it (and let me know how to follow the progress)

@kpouget you should be able to follow the job here: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/1105/console
Let me know if you can access that page, we might need to give you some additional permissions

@kpouget Good catch, sorry for not noticing before :( I'll send another run today

test job: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/1113/console

Run finished with 8 failures, all seem expected failures with the exception of one, which however seems an automation bug on our end.
Verify Pytorch And Tensorflow Can Be Spawned failed because it tried to select an image with name Default (instead of pytorch). @jgarciao if I remember correctly you added this test, can you take a look?
Other than this, I think this is verified and good to go.

thanks, I tested it on my end and I'm happy with the PR as well.

7 failures, same as this morning and all expected. Merging the PR.


V3 changes

added 'q' query functionality
function optimization for v3 API

Hi Sarah, thanks for turning this around so quickly! Overall it looks great. I made a couple of comments requesting small changes, and I also found some bugs with the new API while testing this which Everaldo is working on. After that I think we can merge


ENH: Remove arrays gaps, epochs and times in cython

They are not used anymore and could make the code slower

#72


update rocksdbjni to v6.29.4 for compatibility with arm64 CPU architecture

Signed-off-by: Pedro Novais<EMAIL_ADDRESS>

PR description
Updates rocksdbjni dependency to v6.29.4 for compatibility with arm64 CPU architecture.
It was tested on Apple M1 Pro 2021, OSx 12.3
Related Issue(s)

#3540

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

[ ] I thought about the changelog and included a changelog update if required.

@garyschulte I pulled your commit and merged main as well. Thanks for looking into this.

@garyschulte I pulled your commit and merged main as well. Thanks for looking into this.

It looks like we need to run spotless on that commit for some indentation diffs.

:tada:


Allow publishing to crates with a publish = ["custom-registry"] set

Fixes #18
Draft because this requires some testing, and figuring out how cargo publish behaves in various combinations, and how smart-release should follow:

[ ] When publish = ["one", "two"] contains multiple registries?
[x] When --registry foo combines with publish = ["bar"], that crate is skipped;
[x] When --registry foo combines with unset publish, the crate is published to foo;
[x] When publish = ["foo"] is set without --registry CLI argument, the crate is automatically published to foo (or crates-io is publish is unset).

EDIT: Sorry for this really quick&dirty change, don't want it to be forgotten about but it's on a tangent of a tangent for me :)

First test and this is already breaking, because smart-release doesn't see that the some crates have already been published to a custom registry. I assume only the --registry CLI argument currently tells it which registry to check.

Thanks for contributing.

First test and this is already breaking, because smart-release doesn't see that the some crates have already been published to a custom registry. I assume only the --registry CLI argument currently tells it which registry to check.

It uses crates-index-rs with the default Git index to figure out the latest published index. This is probably a dealbreaker for most private registries.

Somehow it seems to figure it out. As edited above, I think it's because of making changes to crates that cause it to republish.

The problem is that it won't be able to assure that the proposed crate version is more recent than the latest published one, and thus fail publishing.

The problem is that it won't be able to assure that the proposed crate version is more recent than the latest published one, and thus fail publishing.

It doesn't fail, as pointed out above it seems to be looking at the git tags to understand whether the crate has already been published. This seems much less consistent/ideal than:

Check the registry;
Extract the git hash from .cargo-vcs-info.json;
Diff locally if the crate has changed since that hash?

The problem is more obvious in a different way though. fn wait_for_release() loops for 60 seconds trying to find the updated crate, and if it didn't, it continues without error/warning :(

Digging further with actually reading from my custom registry, it looks like rust-crates-index isn't up to this task at all :(. Created a tracking issue with my initial observations: https://github.com/frewsxcv/rust-crates-index/issues/168


feat: Cookbook Onboard (AI Assistant) integration

Description
Cookbook's Ask Cookbook AI assistant and co-pilot is trained on all existing Sui resources (source code, docs website, etc.) and is available as a standalone modal, embeddable as a button on any page (recommended for technical docs). It answers developer questions about building on Sui, acting as an enhanced and streamlined technical documentation search tool as well as Solidity and Move coding co-pilot.
Ask Cookbook AI can also access context from thousands of data sources indexed by Cookbook.dev in addition to Sui-specific data sources, providing the best blockchain developer-focused answers of any chatbot on the market. Cookbook will assist in the tuning and calibration of the AI assistant to ensure the highest answer quality.

Changes

Added the Ask Cookbook plugin to embed the Cookbook Onboard AI Assistant into the Sui docs, and included it in docusaurus.config.js.

Preview
Preview link: https://sui-docs-cookbook.vercel.app/

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Requesting review @ronny-mysten


Add libxlsxwriter topic to the GitHub project metadata

Hi,
Could you add libxlsxwriter as a "topic" metadata to your project so that users can find wrappers in different languages.
Topic/Metadata are shown at the top of the project: https://github.com/jmcnamara/libxlsxwriter
Other examples: https://github.com/search?q=topic%3Alibxlsxwriter&type=Repositories
I'll probably add a section on language wrappings to the libxlsxwriter documentation.
Thanks,
John

Hi @jmcnamara ,
Thanks for your suggestion, topic has been added.
Very support for adding language wrappers to libxlsxwriter documentation.
I will continue to update the project and improve it.
Thanks,
Viest

Thank you!

@jmcnamara  Thanks to libxlsxwriter, it's great!


Improve TLS documentation.

What does this PR do?
Adds examples for TLS options with k8s.
Adds note about router and certificates resolver.
Motivation
Have a better documentation.
More

[ ] Added/updated tests
[x] Added/updated documentation

Thanks for saving time to other people and explaining the TLS thing to me also :) (#5447)
Although the phrase

All supported cipher suites are safe.

sounds scary, like "Orwell Nineteen Eighty-Four" scary


find_value is not in __init__.py, so example on Pypi doesn't work

The example on pypi shows importing find_value along with the other methods directly from jsonparse. However, it looks like find_value was not added to __init__.py, so it can't be imported from here. It has to be imported from jsonparse.functions.

Thank you for the bug report!
I have released a v0.14.1 that fixes this issue. 0.14.1 is on PyPi now as well.
Cheers.


Calling WASI _start causes some modules to exit

There are two patterns of WASI Wasm modules: commands and reactors.

Commands typically have a main function that is run after which the module exists (calls wasi_snapshot_preview1.proc_exit()). This main function is triggered by the modules exported _start() function.
Reactors are longer-lived modules. If the module requires setup e.g. memory initialization, it should be done once after module instantiation and is triggered by the modules exported _initialize() function.

This is all well and good in theory but seems to be abused by many compilers targeting WebAssembly. It seems prudent to either:

Not call either _start() or _initialize() and leave this entirely up to the user of Godot Wasm.
Expose aa initialize setting on the Wasm class that allows a user to define the startup function to be immediately on module initialization.
Call _initialize(). This supports the reactor pattern as it will be interacted with by the user of Godot Wasm later via function(), global(), etc. To support the command pattern, the user has to simply call my_module.function("_start", []).

One thing is certain: Godot Wasm should not blindly call _start immediately on instantiation as it currently does.

Solved in https://github.com/ashtonmeuser/godot-wasm/commit/58f8002f54a3f4dfab5066d74817a740fd43d7f9 using option 3 outline above.


Joining my server gives a warning and then crashes the server

Hello, I just installing LuckPerms for the first time, about 30 minutes ago, and about 10 minutes ago, an issue started crashing my server everytime I joined it. This is a warning when I join the server, and then after about 10 seconds it times me out and prints about 5 million lines of error and then stops.
It's really annoying and I just can't figure the problem out.

Please

follow the error report outline
provide the full log


I want to test if combining emphasis and block quote syntax is consistent between commonmark and GFM

Tested Successfully


Use final when possible.

https://github.com/dart-lang/json_serializable/blob/master/example/lib/example.g.dart#L22

We're kind of riffing of https://github.com/dart-lang/pedantic with our code generation here.


Kit DisplayName

Is your feature request related to a problem?
At the moment you can not have a kit with a spaced name, here is an example of how MMC displays the name of No Debuff kit.
https://gyazo.com/f6a8ba7031dc09c74491a12ecbc49e87
Describe the solution you'd like.
Command /kit displayName
This command will allow you to change color to specific Kits, add spaces, etc. without modifying the actual name of the Kit (f.e. Kit Name: NoDebuff, Kit DisplayName: "&e&lNEW &eNo Debuff"
Describe alternatives you've considered.
N/A
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I have ensured the feature I'm requesting isn't already in the latest Frost.

Other
No response

Feature added, it will be publicly available on Frost v10.0.
Customers that have bought source-code can pull the new commits.


plugin(nexus-repository-manager): initial migration of plugin

Migrates the nexus-repository-manager to this community-plugins repo. The migration was done by following the steps outlined in this documentation.
Note: references of janus-idp in workspaces/nexus-repository-manager/plugins/nexus-repository-manager/src/__fixtures__ were untouched.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

@JessicaJHee could you add a changeset?

@vinzscam I've made the request here, thanks!

Hi @vinzscam! Do you mind taking a look at/reviewing this PR again to see if it's all good to go? Thanks in advance :)

Hi @vinzscam! Do you mind taking a look at/reviewing this PR again to see if it's all good to go? Thanks in advance :)

all good @JessicaJHee, but we are still missing @schultzp2020 as org member. This is important as we want to make sure to have everything in place.


[CLI]: Offline wandb sync failed

Describe the bug

我用pytorch_lightning训练我的模型，每次一但开启offline模式，或者在online实时同步过程中断网以后，等脚本运行结束再进行wandb sync，就会出现下面的错误

def main(args):
    f = open(f"{args.config}")
    opts = EasyDict(yaml.safe_load(f))

    now = datetime.datetime.now().strftime("_%Y-%m-%d_%H:%M:%S")
    run_name = opts.model_name + now
    tags = [opts.model_name, "training"]
    log_path = os.path.join(os.getcwd(), "logs", run_name)

    if trainer.local_rank == 0:
        maybe_mkdir_p(log_path)

    wandb.require("core")
    wandb.login()

    trainer = pl.Trainer(
        accelerator=opts.accelerator,
        strategy=opts.strategy,
        devices=opts.devices,
        max_epochs=opts.train_epochs,
        check_val_every_n_epoch=opts.val_gap,
        callbacks=callbacks,
        precision=opts.precision,
        accumulate_grad_batches=opts.accumulate_grad_batches,
        fast_dev_run=opts.fast_dev_run,
        logger=WandbLogger(
            project=opts.project_name,
            name=run_name,
            save_dir=log_path,
            tags=tags,
            offline=opts.offline,
            config=opts,
            group='DDP' if len(opts.devices) > 1 else None
        ),
        log_every_n_steps=opts.log_gap,
    )

    trainer.fit(
        model, train_dataloader, val_dataloader, ckpt_path=opts.ckpt_resume_path
    )

    if trainer.local_rank == 0:
        wandb.finish()

Find logs at: /tmp/debug-cli.myuser.log
Syncing: https://wandb.ai/mygroup/myproject/runs/it2aw0fk ... Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sync/sync.py", line 289, in run
    data = self._robust_scan(ds)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sync/sync.py", line 237, in _robust_scan
    return ds.scan_data()
           ^^^^^^^^^^^^^^
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sdk/internal/datastore.py", line 156, in scan_data
    record = self.scan_record()
             ^^^^^^^^^^^^^^^^^^
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sdk/internal/datastore.py", line 137, in scan_record
    checksum_computed = zlib.crc32(data, self._crc[dtype]) & 0xFFFFFFFF
                                         ~~~~~~~~~^^^^^^^
IndexError: list index out of range

另一个类似的错误也经常出现，也是offline模式结束脚本以后wandb sync，或者online下断网以后wandb sync
Find logs at: /home2/myuser/projects/brain_anomaly_detection/wandb/debug-cli.ykm2023.log
Syncing: https://wandb.ai/mygroup/myproject/runs/ttngp283 ... Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sync/sync.py", line 289, in run
    data = self._robust_scan(ds)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sync/sync.py", line 245, in _robust_scan
    raise e
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sync/sync.py", line 237, in _robust_scan
    return ds.scan_data()
           ^^^^^^^^^^^^^^
  File "/home2/myuser/applications/miniconda3/envs/dl/lib/python3.12/site-packages/wandb/sdk/internal/datastore.py", line 153, in scan_data
    assert pad == pad_check, "invalid padding"
           ^^^^^^^^^^^^^^^^
AssertionError: invalid padding

Additional Files
No response
Environment
WandB version: 0.17.2
OS: Ubuntu 22.04.4 LTS (GNU/Linux 5.15.0-105-generic x86_64)
Python version: 3.12.3
Versions of relevant libraries: pytorch_lightning 2.3.0
Additional Context
No response

Jason Davenport commented: Hi there! To clarify the issue you are having is with syncing your wandb runs? If this is the case may I please ask a bit more about how you are running things? Are you running in offline mode and then waiting to sync until later or are you running into syncing issues during normal runs?
The stack traces you provided had several errors; however, none of them were related to syncing data so I just want to make sure I have things straight.
Thanks!
Best, Jason

Hi! These errors occured when I called "wandb sync " by shell, after my script finished.
At first I run thing in online mode and at that moment everything is fine. Because I develop in a remote enviroment and the network is not stable, I want to run in offline mode then errors occured if I "wandb sync " after the script is over.
I also tried sync during the script running (I mean calling "wandb sync" while script is running in offline mode), it works, nothing is wrong. But once script finished, I have a high probability of encountering this problem. This is strange because sometimes it is fine, but there is a high probability of errors.
By the way, I use ddp strategy (pytorch_lighting implemented) for training, may this be the reason??

@yykmeng thanks for reporting the issue, we are actively taking a look into it, will report here with our findings.
if you feel comfortable sharing your run folder with support it will be very helpful to further debug it.

I have the same error when calling wandb sync wandb/latest-run on some offline run with 0.17.3.
Did not happen with 0.16.5.

Hello,
I have sent an email to<EMAIL_ADDRESS>with a log folder causing that error and referencing that issue.

@yykmeng thanks for reporting the issue, we are actively taking a look into it, will report here with our findings.
if you feel comfortable sharing your run folder with support it will be very helpful to further debug it. To contact support you could use the following email<EMAIL_ADDRESS>

Jason Davenport commented: Hi there, I wanted to follow up on this request. Please let us know if we can be of further assistance or if your issue has been resolved.

Hi! I had to move forward with my project instead of waiting for the bug to be fixed, so now I'm using wandb online mode and the bug hasn't continued to appear. But others seem to be experiencing this same problem @WarmongeringBeaver

@yykmeng thanks for reporting the issue, we are actively taking a look into it, will report here with our findings.
if you feel comfortable sharing your run folder with support it will be very helpful to further debug it. To contact support you could use the following email<EMAIL_ADDRESS>

@yykmeng thanks for reporting the issue, we are actively taking a look into it, will report here with our findings.
if you feel comfortable sharing your run folder with support it will be very helpful to further debug it. To contact support you could use the following email<EMAIL_ADDRESS>Hi,

I'm moving forward with my project and I can't wait for the bugs to be fixed, sorry for the log files being deleted at the time.
I'm now using wandb online mode and the bug hasn't reappeared yet, if the next time the bug occurs I'll upload the log file.

This has been fixed in 0.17.6 which was released today.
There was an issue in the internal format of the transaction log which was not fully compatible with the existing "wandb sync" command.
Please reach out if you have critical files that need to be recovered as this should be possible.

Hi @yykmeng and @WarmongeringBeaver - wanted to follow up here and see if the latest release resolved the issues you were running into?

Hello,
I don't have access to the logs that were causing trouble anymore, but I will come back here if I encounter a similar error.
Thank you for the quick fix btw ☺

Hi @yykmeng and @WarmongeringBeaver - wanted to follow up here and see if the latest release resolved the issues you were running into?

Hi Noa,
I encounter this error when trying to sync, using version 0.17.8:
$ wandb sync --include-synced --include-offline --sync-all wandb/offline-run-20240905_174550-euufawam/
Find logs at: /jmain02/home/J2AD016/jjw03/myuser/scratch/wandb/debug-cli.myuser.log
Syncing: https://wandb.ai/myuser/myproject/runs/7a3x3zdi ... Exception in thread Thread-1:
Traceback (most recent call last):
  File "/jmain02/home/J2AD016/jjw03/myuser/.conda/envs/dlp/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/jmain02/home/J2AD016/jjw03/myuser/.conda/envs/dlp/lib/python3.10/site-packages/wandb/sync/sync.py", line 289, in run
    data = self._robust_scan(ds)
  File "/jmain02/home/J2AD016/jjw03/myuser/.conda/envs/dlp/lib/python3.10/site-packages/wandb/sync/sync.py", line 245, in _robust_scan
    raise e
  File "/jmain02/home/J2AD016/jjw03/myuser/.conda/envs/dlp/lib/python3.10/site-packages/wandb/sync/sync.py", line 237, in _robust_scan
    return ds.scan_data()
  File "/jmain02/home/J2AD016/jjw03/myuser/.conda/envs/dlp/lib/python3.10/site-packages/wandb/sdk/internal/datastore.py", line 153, in scan_data
    assert pad == pad_check, "invalid padding"
AssertionError: invalid padding

Hi @HRezaei I just wanted to let you know I am actively working to repro this on my end. I will update you here as we make progress. Out of curiosity, does this happen every time you use sync or only with this specific run?

Hi, @JasonArkens17 @noaleetz. I'm using wandb 0.17.8 now and everytime I try wandb sync my_path it just be like
Find logs at: somewhere/wandb/debug-cli.my_user.log
Skipping directory: my_path

No errors occur but always skip the run I want to sync...


acme-client: init at 0.1.6

Motivation for this change
Add acme-client package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build acme-client

Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
moving /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16/man to /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16
shrinking /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16/bin/acme-client
gzipping man pages under /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16/bin
patching script interpreter paths in /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16
checking for references to /tmp/nix-build-acme-client-0.1.16.drv-0 in /nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16...
/nix/store/nrvlkp096sj11m272h82v2q61nnsr600-acme-client-0.1.16

Success on x86_64-darwin (full log)
Partial log (click to expand)
mkdir -p /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/bin
install -m 0755 acme-client /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/bin
install -m 0644 acme-client.1 /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/man/man1
post-installation fixup
moving /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/man to /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/share/man
gzipping man pages under /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/share/man/
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16/bin
patching script interpreter paths in /nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16
/nix/store/ixwyiggdwjvmy288njmk5k0sw5fdpd96-acme-client-0.1.16

Success on aarch64-linux (full log)
Partial log (click to expand)
post-installation fixup
moving /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16/man to /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16
shrinking /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16/bin/acme-client
gzipping man pages under /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16/bin
patching script interpreter paths in /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16
checking for references to /build in /nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16...
/nix/store/35lg80sfbhkqvfqyyfnz9pwvdwbbvgp4-acme-client-0.1.16