docker run -t causes stderr messages to be sent to stdout.

Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1121689
Description of problem:
The handling of stdout/stderr stream is not correct in tty mode (works fine in non-tty mode). You can see it on the example bellow. (ls non_existing_file prints into stderr stream)
Version-Release number of selected component (if applicable):
docker-1.1.1-1.el7.x86_64
How reproducible:
Always
Steps to Reproduce:
TTY:
[root@localhost ~]# docker run -t -a stderr fedora ls non_existing_file
[root@localhost ~]# docker run -t -a stdout fedora ls non_existing_file
ls: cannot access non_existing_file: No such file or directory
NON-TTY:
[root@localhost ~]# docker run -a stderr fedora ls non_existing_file
ls: cannot access non_existing_file: No such file or directory
[root@localhost ~]# docker run -a stdout fedora ls non_existing_file
Actual results:
In tty mode the output is visible only when STDOUT is attached, in non-tty mode it's visible in STDERR
Expected results:
In booth modes the output should be in STDERR stream.
Additional info:
When I use ls / it prints the info correctly into STDOUT in booth modes.

Today i ran into this case, in my usecase, docker 1.4.1,  we directly use  below command:
docker run  fedora ls non_existing_file, then it will bind to stdout and stderr.

since this by design because of blockers w pty I think this can be fixed when someone updates docs and possibly adds warning

#dibs

Hi @devopsko,
Please remember to add the keyword tags closes or fixes once you PR to help make tracking the fixes easier. Thanks!


Java lsp example

Hey,
I tried to get the Java lsp to work (eclipse jdt).
This command seems to start the server (seen here for example)
java -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044 -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -noverify -Xmx1G -jar /opt/jdt-language-server/plugins/org.eclipse.equinox.launcher.jar -configuration /opt/jdt-language-server/config_linux -data /path/to/my_project/ --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED

However, adding the following doesn't do anything (confirmed with :lsp-capabilities inside a .java file)
[language.java]
filetypes = ["java"]
roots = [".git"]
command = "java"
args = ["-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044 -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -noverify -Xmx1G -jar /opt/jdt-language-server-0.69.0-202102120513/plugins/org.eclipse.equinox.launcher_1.6.0.v20200915-1508.jar -configuration /opt/jdt-language-server-0.69.0-202102120513/config_linux -data /mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework/ --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED"]

I probably don't have enough understanding to get it to work, but @topisani mentioned in #126 this server as an example for the usage of [language.java.initialization_options], but I have no idea how to set it up...
I'm aware this is probably not the right channel, but would anyone care to share the trick? (@topisani ?)
Maybe it can be put in the docs afterwards...

I'm right there with you!  I followed the directions from the eclipse.jdt.ls github page, but am struggling to figure out how to configure it.  If you add the following command to your kakrc, you'll be able to see debug information:
set global lsp_cmd "kak-lsp -s %val{session} -vvv --log /tmp/kak-lsp.log"
I've set it up basically the same as you have, and I can confirm that the server seems to run from the command line, but I get the following error messages from kak-lsp every time I run it.
client    = "client0"
buffile   = <redacted>
filetype  = "java"
version   = 1
method    = "textDocument/hover"
[params.position]
line      = 1
column    = 1
, module: kak_lsp::editor_transport:125
Feb 22 21:12:35.993 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_JAVA, module: kak_lsp::project_root:41
Feb 22 21:12:35.994 DEBG Routing editor request to Route { session: "27379", language: "java", root: <redacted>" }, module: kak_lsp::session:95
Feb 22 21:12:35.994 DEBG Language server is not initialized, parking request, module: kak_lsp::controller:73
Feb 22 21:12:36.046 ERRO Language server error: Error: Could not find or load main class  -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -noverify -Xmx1G -jar .home.pjacobs.build.eclipse.jdt.ls.org.ec
Caused by: java.lang.ClassNotFoundException:  -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -noverify -Xmx1G -jar .home.pjacobs.build.eclipse.jdt.ls.org.eclipse.jdt.ls.product.target.repository.plugi, module: kak_lsp::language_server_transport:52
Feb 22 21:12:36.046 DEBG Language server closed pipe, stopping reading, module: kak_lsp::language_server_transport:127
Feb 22 21:12:36.047 INFO Waiting for Messages to language server to finish..., module: kak_lsp::thread_worker:18
Feb 22 21:12:36.047 DEBG Received signal to stop language server, closing pipe, module: kak_lsp::language_server_transport:186
Feb 22 21:12:36.047 DEBG Waiting for language server process end, module: kak_lsp::language_server_transport:81```

args = ["-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044 -Declipse.application=org.eclipse.jdt.ls.core.id1

This means that you are invoking java with a single argument, as if you ran java "-Dfoo -Dbar MyClass" in the shell.
You can split words explicitly, like
args = [
    "-Dfoo",
    "-Dbar",
    "MyClass",
]

Or write a wrapper script, so you don't have to add complicated things to kak-lsp.toml.
If you're lazy, you can also invoke a shell to do word splitting:
command = "sh"
args = ["java -Dfoo -Dbar MyClass"]

Language server error: Error: Could not find or load main class ...

Yep, looks like Java interprets the single argument as class name, which obviously doesn't exist.

I enabled the debugging like in your first comment.
Small difference: I enabled it in my kakrc eval %sh{kak-lsp --kakoune -s $kak_session --config /home/user/.config/kak/kak-lsp/kak-lsp.toml -vvv --log /tmp/kak-lsp.log}
It seems strange, however, because at first sight, the argument splitting doesn't matter...
The error I do get is a transport error:

Feb 23 10:11:03.993 ERRO Language server error: ERROR: transport error 103: invalid port number specified
ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports initialized [src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c:735]
, module: kak_lsp::language_server_transport:52

kak-lsp.log
Feb 23 10:11:02.588 DEBG From editor:
session  = "10352"
client   = ""
buffile  = ""
filetype = ""
version  = 0
method   = "stop"
[params]
, module: kak_lsp::editor_transport:125
Feb 23 10:11:02.589 INFO Shutting down language servers and exiting, module: kak_lsp::session:180
Feb 23 10:11:02.589 ERRO Failed to send stop message to language server, module: kak_lsp::session:183
Feb 23 10:11:02.589 INFO Exit java in project /mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework, module: kak_lsp::session:185
Feb 23 10:11:02.589 INFO Waiting for Controller to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:02.589 INFO ... Controller terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:02.589 INFO Waiting for Messages to editor to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:02.589 INFO ... Messages to editor terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:02.595 INFO Starting main event loop, module: kak_lsp::session:29
Feb 23 10:11:02.596 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_JAVA, module: kak_lsp::project_root:41
Feb 23 10:11:02.597 DEBG Routing editor request to Route { session: "10352", language: "java", root: "/mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework" }, module: kak_lsp::session:95
Feb 23 10:11:03.872 INFO Starting main event loop, module: kak_lsp::session:29
Feb 23 10:11:03.873 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_JAVA, module: kak_lsp::project_root:41
Feb 23 10:11:03.874 DEBG Routing editor request to Route { session: "11308", language: "java", root: "/mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework" }, module: kak_lsp::session:95
Feb 23 10:11:03.874 DEBG Spawning a new controller for Route { session: "11308", language: "java", root: "/mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework" }, module: kak_lsp::session:117
Feb 23 10:11:03.875 INFO Starting Language server `java -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044 -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -noverify -Xmx1G -jar /opt/jdt-language-server-0.69.0-202102120513/plugins/org.eclipse.equinox.launcher_1.6.0.v20200915-1508.jar -configuration /opt/jdt-language-server-0.69.0-202102120513/config_linux -data /mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework/ --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED`, module: kak_lsp::language_server_transport:21
Feb 23 10:11:03.878 DEBG To editor `11308`: lsp-get-server-initialization-options '/tmp/kak-lsp/thijs/69b50e3a9430cad0', module: kak_lsp::editor_transport:85
Feb 23 10:11:03.992 DEBG lsp_server_initialization_options:
, module: kak_lsp::general:192
Feb 23 10:11:03.992 DEBG To server: {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"colorProvider":null,"completion":{"completionItem":{"documentationFormat":["plaintext"],"snippetSupport":true}},"semanticHighlightingCapabilities":{"semanticHighlighting":true}},"workspace":{"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","delete","rename"]}}},"initializationOptions":{},"processId":11380,"rootUri":"file:///mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework","trace":"off"},"id":0}, module: kak_lsp::language_server_transport:175
Feb 23 10:11:03.993 ERRO Language server error: ERROR: transport error 103: invalid port number specified
ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports initialized [src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c:735]
, module: kak_lsp::language_server_transport:52
Feb 23 10:11:03.993 DEBG Language server closed pipe, stopping reading, module: kak_lsp::language_server_transport:127
Feb 23 10:11:03.994 INFO Waiting for Messages to language server to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:03.994 DEBG Received signal to stop language server, closing pipe, module: kak_lsp::language_server_transport:186
Feb 23 10:11:03.994 DEBG Waiting for language server process end, module: kak_lsp::language_server_transport:81
Feb 23 10:11:04.994 INFO ... Messages to language server terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:04.994 INFO Waiting for Messages from language server to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:04.994 INFO ... Messages from language server terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:04.994 INFO Waiting for Language server errors to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:04.994 INFO ... Language server errors terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:06.438 DEBG From editor:
session  = "11308"
client   = ""
buffile  = ""
filetype = ""
version  = 0
method   = "stop"
[params]
, module: kak_lsp::editor_transport:125
Feb 23 10:11:06.438 INFO Shutting down language servers and exiting, module: kak_lsp::session:180
Feb 23 10:11:06.438 ERRO Failed to send stop message to language server, module: kak_lsp::session:183
Feb 23 10:11:06.438 INFO Exit java in project /mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework, module: kak_lsp::session:185
Feb 23 10:11:06.438 INFO Waiting for Controller to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:06.438 INFO ... Controller terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:06.438 INFO Waiting for Messages to editor to finish..., module: kak_lsp::thread_worker:18
Feb 23 10:11:06.439 INFO ... Messages to editor terminated with ok, module: kak_lsp::thread_worker:20
Feb 23 10:11:06.444 INFO Starting main event loop, module: kak_lsp::session:29
Feb 23 10:11:06.446 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_JAVA, module: kak_lsp::project_root:41
Feb 23 10:11:06.447 DEBG Routing editor request to Route { session: "11308", language: "java", root: "/mnt/data/UGent/2020-2021/semester2/HOP/FPGA-CAD-Framework" }, module: kak_lsp::session:95

(I have not yet tested with correct argument splitting, will do now)

I applied the argument splitting, and now when doing :lsp-capabilities, this gets reported :partying_face:

Most of them seem to work (formatting), but not outside their files...
What I mean:
When using gd (or :lsp-definition), I can jump to the definition within the same file, but not when it's defined in another file in the same project.
The same for :lsp-hover: It seems capable of providing information from standard libraries (System.out.println) and within the same file, but not for separate files.
I only changed argument splitting, so if you need more info about my setup to help you...
Hopefully I can see in the error messages more info about getting information out of the separate files in my projectfolder.

Ok, not sure anymore, maybe the LSP was lagging behind, because I just jumped between files... I'll report back if I anyone is interested and/or I know more and/or have to know more from you all :smiley:
Will close this for now, but certainly ping me if you have more info/need more info.

I'm also trying to get eclipse lsp to work.
I used @dzamo 's commit to set it up:
# Commented out by default because you still need to set the paths in the JDT
# Language Server arguments below before this can become a valid configuration.
[language.java]
filetypes = ["java"]
roots = [".git", "mvnw", "gradlew"]
command = "java"
args = [
    "-Declipse.application=org.eclipse.jdt.ls.core.id1",
    "-Dosgi.bundles.defaultStartLevel=4",
    "-Declipse.product=org.eclipse.jdt.ls.core.product",
    "-Dlog.level=ALL",
    "-Dfile.encoding=utf-8",
    "--add-modules=ALL-SYSTEM",
    "--add-opens",
    "java.base/java.util=ALL-UNNAMED",
    "--add-opens",
    "java.base/java.lang=ALL-UNNAMED",
    "-noverify",
    "-Xmx1G",
    "-jar",
    "/Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/plugins/org.eclipse.equinox.launcher_1.6.200.v20210416-2027.jar",
    "-configuration",
    "/Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/config_mac",
    "-data",
    "/Users/bastian/.eclipse.jdt.ls.workspace"
]

however, nothing happens.
No capabilities are reported.
I have logging enabled, it stays empty.
If I run the command from shell, it seems to work:
$ java -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -Dfile.encoding=utf-8 --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED -noverify -Xmx1G -jar /Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/plugins/org.eclipse.equinox.launcher_1.6.200.v20210416-2027.jar -configuration /Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/config_mac -data ~/.eclipse.jdt.ls.workspace/

OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
WARNING: Using incubator modules: jdk.incubator.jpackage, jdk.incubator.foreign
Content-Length: 122

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"5 Aug 2021, 11:13:17 Main thread is waiting"}}

Does anyone have an idea?
Thanks!

It does look like you can start the language server. Is there anything in Kakoune's debug buffer?

thanks for answering so quickly.
No, empty as well.
*** This is the debug buffer, where debug info will be written ***
Config-change detected:
Enabling LSP for filtetype
Config-change detected:
Config-change detected:
Config-change detected:

Doesn't look like it's launching the language server at all. Perhaps try giving kak-lsp an absolute path the java executable? I ended up wrapping the long command line to launch the LS in a shell script.

neither setting "/usr/bin/java" nor
# Commented out by default because you still need to set the paths in the JDT
# Language Server arguments below before this can become a valid configuration.
[language.java]
filetypes = ["java"]
roots = [".git", "mvnw", "gradlew"]
# command = "java"
# args = [
#     "-Declipse.application=org.eclipse.jdt.ls.core.id1",
#     "-Dosgi.bundles.defaultStartLevel=4",
#     "-Declipse.product=org.eclipse.jdt.ls.core.product",
#     "-Dlog.level=ALL",
#     "-Dfile.encoding=utf-8",
#     "--add-modules=ALL-SYSTEM",
#     "--add-opens",
#     "java.base/java.util=ALL-UNNAMED",
#     "--add-opens",
#     "java.base/java.lang=ALL-UNNAMED",
#     "-noverify",
#     "-Xmx1G",
#     "-jar",
#     "/Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/plugins/org.eclipse.equinox.launcher_1.6.200.v20210416-2027.jar",
#     "-configuration",
#     "/Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/config_mac",
#     "-data",
#     "/Users/bastian/.eclipse.jdt.ls.workspace"
# ]
command = "sh"
args =["-c", "java -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.level=ALL -Dfile.encoding=utf-8 --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED -noverify-Xmx1G -jar /Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/plugins/org.eclipse.equinox.launcher_1.6.200.v20210416-2027.jar -configuration /Users/bastian/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/repository/config_mac -data ~/.eclipse.jdt.ls.workspace/"]

made any change

Rats. You are opening a Java source file, right? And Kakoune is setting the filetype to java?

yes.
I used java-language-server before, which worked

Well, all I can of think of now is to post what's working for me (on Linux).
kak-lsp.toml
[language.java]
filetypes = ["java"]
roots = [".git", "mvnw", "gradlew"]
command = "/home/dzamo/.local/bin/jdt-ls.sh"

jdt-ls.sh
#!/bin/sh

JDT_LS_HOME=/opt/eclipse.jdt.ls
GRADLE_HOME=$HOME/.gradle
DEFAULT_ECLIPSE_WS=$HOME/Development/eclipse

java \
  -Declipse.application=org.eclipse.jdt.ls.core.id1 \
  -Dosgi.bundles.defaultStartLevel=4 \
  -Declipse.product=org.eclipse.jdt.ls.core.product \
  -Dlog.protocol=true \
  -Dlog.level=ALL \
  -Xms100M \
  -Xmx1G \
  -jar "$JDT_LS_HOME/repository/plugins/org.eclipse.equinox.launcher_1.6.200.v20210416-2027.jar" \
  -configuration "$JDT_LS_HOME/repository/config_linux" \
  -data "${1:-$DEFAULT_ECLIPSE_WS}" \
  --add-modules=ALL-SYSTEM \
  --add-opens java.base/java.util=ALL-UNNAMED \
  --add-opens java.base/java.lang=ALL-UNNAMED

Debug buffer output
LSP: 05 Aug 2021, 14:14:37 Main thread is waiting
LSP: 05 Aug 2021, 14:14:37 >> initialize
LSP: 05 Aug 2021, 14:14:37 Initializing Java Language Server <IP_ADDRESS>108031204
LSP: 05 Aug 2021, 14:14:37 Static Commands: []
LSP: 05 Aug 2021, 14:14:37 Non-Static Commands: [java.edit.organizeImports, java.project.refreshDiagnostics, java.project.import, java.navigate.openTypeHierarchy, java.project.removeFromSourcePath, java.project.listSourcePaths, java.project.provideSemanticTokens, java.project.resolveStackTraceLocation, java.project.getAll, java.project.isTestFile, java.project.getClasspaths, java.navigate.resolveTypeHierarchy, java.project.getSemanticTokensLegend, java.edit.stringFormatting, java.project.getSettings, java.project.updateSourceAttachment, java.project.resolveSourceAttachment, java.project.addToSourcePath]
LSP: 05 Aug 2021, 14:14:38 >> initialized
LSP: 05 Aug 2021, 14:14:38 Importing Maven project(s)
LSP: 05 Aug 2021, 14:14:41 Workspace initialized in 3802ms
LSP: 05 Aug 2021, 14:14:41 >> initialization job finished
LSP: 05 Aug 2021, 14:14:41 >> document/didOpen
LSP: 05 Aug 2021, 14:14:42 >> workspace/didChangeConfiguration
LSP: 05 Aug 2021, 14:14:42 >> New configuration: {}
LSP: 05 Aug 2021, 14:14:42 Reconciled 1. Took 1 ms
LSP: 05 Aug 2021, 14:14:44 begin problem for /TestNearestDateFunctions.java
LSP: 05 Aug 2021, 14:14:44 0 problems reported for /TestNearestDateFunctions.java
LSP: 05 Aug 2021, 14:14:44 Validated 1. Took 1383 ms

sorry for not coming back to this for so long!
I got it running – seems like it was an error in my kak-lsp.toml where I used syntax that was newer than the release version I was using supported.
I now got it running.
The only issue I'm still facing is that for files without a "project", I don't get any flags or diagnostics

Nice! Have you got any workspace/executeCommand actions? E.g. Where you can put the cursor on an unresolved type and select "Add import of foo.bar.Type"? I get a menu of choices but choosing one fails.

Nice! Have you got any workspace/executeCommand actions? E.g. Where you can put the cursor on an unresolved type and select "Add import of foo.bar.Type"? I get a menu of choices but choosing one fails.

Where would I get these commands?
I found that I get my errors reported in my debug console but not properly in my file… 🤔

Where would I get these commands?

In kak-lsp listed under "a: show code actions for the current position".

Where would I get these commands?

In kak-lsp listed under "a: show code actions for the current position".

ah!
yeah I get the same error…
I select Organize imports and get  kak-lsp: java language server doesn't support method workspace/executeCommand.
I found out that for some reason I had to put my try %sh{kak-lsp --kakoune --session "$kak_session"} further down in my kakrc.
Now I get the list of errors but still no highlighting in the gutter…

opened a new issue: https://github.com/kak-lsp/kak-lsp/issues/559


Update how-to-update-over-the-air.md

Split out the download link into two links.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/azure-docs
Private repo URL: https://github.com/MicrosoftDocs/azure-docs-pr
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)


Revert "Bump helm for a new vault version 1.7.2"

This reverts commit 469ef0da2789051411792f51d76b205fb1ea0991.

Fixed manually. Reverted helm repo as well.


Docs: Update all documentation

Pull Request Test Coverage Report for Build 122

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 99:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Interface Index

Would it be possible to add the interface index to the struct too?
I know libc has several function calls to get that information: https://man7.org/linux/man-pages/man3/if_nametoindex.3.html
Mainly this would be helpful when dealing with ipv6 multicast membership because the join_multicast_v6() on Rust's UdpSocket requires an interface number to bind to:
https://doc.rust-lang.org/stable/std/net/struct.UdpSocket.html#method.join_multicast_v6

Hi @tr3ysmith! Thanks so much for this feature request.
If you feel like working on this, please don't hesitate on opening a PR, I'm glad to help.
As you have been suggesting relevant feature requests, I was thinking on tweaking a bit the crate architecture to be able to provide as much support as I'm able to do without delaying releases. Here's a discussion #12 where your input would be appreciated.
Thanks in advance! Keep up the feature requests!

Closing given that is added on #25!


test: force restarting of Cilium pods

Fixes race between cilium being restarted and connectivity test.

test-focus K8sFQDNTest.*

test-gke K8sFQDNTest.*

test-focus K8sFQDNTest.*

test-gke K8sFQDNTest.*

Coverage increased (+0.03%) to 37.037% when pulling 706b6e6ed89947d5f96ba6ddfd805b8ef30aff64 on pr/fqdn-delete-cilium into 859e1789fd1b5ee7ba2c613f360a86d40e0b7603 on master.

test-focus K8sFQDNTest.*

test-focus K8sFQDNTest.*

test-me-please

test-me-please

test-focus K8sFQDNTest.*

test-focus K8sFQDNTest.*

test-me-please

retest-runtime

retest-4.19

test-me-please

test-gke

test-me-please

@nebril could you elaborate on why exactly connectivity check is interfering here, just trying to understand the context better.

@errordeveloper the connectivity check was not interfering, but the point of the test is to run the test while Cilium is recovering to validate that dns cache works during restarting Cilium pods.

@nebril that sounds like it would add even more racy behaviour, it sound to me that it would be more reliable to delete the the daemonset instead, or taint and drain the nodes.

@errordeveloper AFAIU if we delete the daemonset, Cilium pods will uninstall cleanly, deleting bpf maps. If we drain the nodes, the same applies, and also how will we test the workload running on a drained node?

if we delete the daemonset, Cilium pods will uninstall cleanly, deleting bpf maps

I thought the opposite was actually the case.

how will we test the workload running on a drained node?

You just need to have the right toleration set. It may the case that it's not a full drain that is needed, but a taint that Cilium doesn't tolerate followed by deletion of the Cilium pod(s).

@errordeveloper without the Cilium pod scheduled on a node, we end up with a node that doesn't handle networking via our cni plugin, which is not what we want to test afaiu.

@nebril I believe missing pod will have the same effect as restarting pod in this case, and just to be clear, my view is that ad-hoc commands is exactly what we should stop doing in the tests. If this is a hack that fixes another hack, I get that :)


Improve documentation on how to use environments

Is your feature request related to a problem? Please describe.
Immediately after opening Postwoman and adding Environments, it is not clear how I should reference them in my requests.
Can I use {{ variable_name }}?
Describe the solution you'd like
Postman has great documentation about it.
I think the Wiki needs to have a section about Environments and the app should have some tooltips or indications as to how one should use environments.

Sorry for the incomplete Wiki. We're working on it.
By the way, here's the Wiki regarding Pre-request scripts and environments: https://github.com/liyasthomas/postwoman/wiki/Pre-Request-Scripts
This link is visible on pre-request script section.
Feel free to contribute to Wiki if you find any issues.


experimental: Add minimal rust backend.

First pass at adding a simple rust backend that use nalgebra for its matrix library.

Thanks for testing / reviewing @avsaase. Took another quick pass at improving it.

There might be some issues with our CI right now; I'm letting it run, but generally I need to fix up some things so there might be some failures that aren't related to this PR

@aaron-skydio Thanks for the review! I did my best to address them and left them open for you to resolve. I think if we are happy with where this landed could you help me kick off CI so that I can get it all passing?


test

Signed-off-by: Artem Glazychev<EMAIL_ADDRESS>

I've used this commit for release/v1.7.0.
https://github.com/networkservicemesh/integration-interdomain-k8s/tree/release/v1.7.0 => https://github.com/networkservicemesh/integration-interdomain-k8s/actions/runs/3751298798
Looks good.


projection layer

if i use projection layer for ddp it will cause:
RuntimeError: Expected to mark a variable ready only once. This error is caused by one of the following reasons: 1) Use of a module parameter outside the forward function. Please make sure model parameters are not shared across multiple concurrent forward-backward passes. or try to use _set_static_graph() as a workaround if this module graph does not change during training loop.2) Reused parameters in multiple reentrant backward passes. For example, if you use multiple checkpoint functions to wrap the same part of your model, it would result in the same set of parameters been used by different reentrant backward passes multiple times, and hence marking a variable ready multiple times. DDP does not support such use cases in default. You can try to use _set_static_graph() as a workaround if your module graph does not change over iterations.

You can probably fix this by deactivating activation/gradient checkpointing

if i use projection layer for ddp it will cause: RuntimeError: Expected to mark a variable ready only once. This error is caused by one of the following reasons: 1) Use of a module parameter outside the forward function. Please make sure model parameters are not shared across multiple concurrent forward-backward passes. or try to use _set_static_graph() as a workaround if this module graph does not change during training loop.2) Reused parameters in multiple reentrant backward passes. For example, if you use multiple checkpoint functions to wrap the same part of your model, it would result in the same set of parameters been used by different reentrant backward passes multiple times, and hence marking a variable ready multiple times. DDP does not support such use cases in default. You can try to use _set_static_graph() as a workaround if your module graph does not change over iterations.

您好，我想微调一下现有的模型，但是原始模型的hidden state维度太大了，我想用projection来降维，但是训练了之后并没有保存projection的权重参数，请问您这边儿有碰到这个情况吗


chore: decouple widget-config.json from main chunk

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11379366821
Commit: 6501304fa541c853f7575ff55591c2932cab5e4b
Workflow: PR Automation test suite
Tags: @tag.All
Spec: ``
Thu, 17 Oct 2024 06:12:57 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

/build-deploy-preview skip-tests=true

@jsartisan can you review the dom test cases, i had to add wait for the canvas dom element to load since we are lazily loading the config json script.

It looks weird from the look of it, but if it works then fine.


Package update and maintenance

Landed in https://github.com/metarhia/lowscript/commit/8f57fe928429c5d3879dce1113c854471e8d1e0a, https://github.com/metarhia/lowscript/commit/7a5b3fa8a2d57006a306eb0a406f6455eed000e7, and https://github.com/metarhia/lowscript/commit/94cbd1b56f6c3765d193298b7f5d13be9af97f4b


update FinanceDeposit and FinanceWithdraw components with new useErc20Balance instead of wagmi's useBalance

useErc20Balance was created in commit widget

how to test this: both finance deposit and finance withdraw modals should show the current balance (again)

duplicate of: https://github.com/bosonprotocol/core-components/issues/610


Fix typos in c directory

Splitting #43857 by top-level directories per @mihaimaruseac comments.

As far as I can tell, failing macOS check has nothing to do with changes here as it was failing for the last few days on other PRs as well.


TypeScript language service died 5 times

Issue Type: Bug
The TypeScript language service died 5 times right after it got started. The service will not be restarted.
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:07:18.473Z)
OS version: Darwin x64 23.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
7, 8, 10

Memory (System)
16.00GB (1.44GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

ng-template
Ang
0.1100.4

vscode-eslint
dba
2.1.8

githistory
don
0.6.16

es7-react-js-snippets
dsz
2.8.0

gitlens
eam
10.2.3

prettier-vscode
esb
5.5.0

icon-fonts
idl
2.5.4

vscode-peacock
joh
3.8.0

vscode-docker
ms-
1.6.0

vscode-typescript-next
ms-
5.4.20240104

vscode-groovy-lint
Nic
1.4.0

tsimporter
pmn
2.0.1

typescript-hero
rbb
3.0.0

LiveServer
rit
5.6.1

vscode-scss-formatter
sib
2.0.1

vscode-icons
vsc
12.6.0

(3 theme extensions excluded)

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Closing as this is a very old VS Code version. Please try updating as this problem was likely already fixed


add empry state card variation

Fixes PXBLUE-2392.

Changes proposed in this Pull Request:

Add within a card variation

Screenshots:
feature/add-empty-state-card

To Test:

http://localhost:6006/?path=/story/components-empty-state--within-a-card

Code example looks good to me but can you fix this background issue?

@huayunh , can we remove this line? https://github.com/pxblue/react-component-library/blob/5ae4896667617408c3c4df158becb65223ae8b24/demos/storybook/stories/empty-state/_module.stories.tsx#L12 ? Is there any reason to add white bg for Empty state example ?


Swagger do not working correctly without slash in the end of URL.

Looks like this is a bug. Very confusing.
Good URL: "https://localhost:54225/swagger/".
Bad URL: "https://localhost:54225/swagger".
Good URL: "https://localhost:54225/swaggerredoc/".
Good URL: "https://localhost:54225/swaggerredoc".
I am using:
.NET CORE 2.1.0.
NSwag.ApiNetCore 11.18.7
Swashbuckle.AspNetCore 3.0.0
Using part ===================================
using NSwag;
using NSwag.AspNetCore;
using NSwag.SwaggerGeneration.Processors.Security;
using Swashbuckle.AspNetCore.Swagger;
ConfigureServices part ===========================
services.AddSwaggerGen(c =>
{
c.SwaggerDoc("v1", new Info { Title = "Text", Description = "Text" });
});
Configure part ================================
app.UseSwaggerUi3WithApiExplorer(s =>
{
s.SwaggerRoute = "/swagger_new_ui3/v1/swagger.json";
s.SwaggerUiRoute = "/swagger";
            s.GeneratorSettings.DocumentProcessors.Add(new SecurityDefinitionAppender("TEST_HEADER", new SwaggerSecurityScheme
            {
                Type = SwaggerSecuritySchemeType.ApiKey,
                Name = "TEST_HEADER",
                In = SwaggerSecurityApiKeyLocation.Header,
                Description = "TEST_HEADER"
            }));
        });

        app.UseSwaggerReDocWithApiExplorer(s =>
        {
            s.SwaggerRoute = "/swagger_new_redoc/v1/swagger.json";
            s.SwaggerUiRoute =  "/swaggerredoc";
        });

You dont need swashbuckle, just call AddSwagger() in configure services

I suspect this is a regression of this pr: https://github.com/RSuter/NSwag/pull/1540

Just tried with
            {
                s.SwaggerRoute = "/swagger_new_ui3/v1/swagger.json";
                s.SwaggerUiRoute = "/swagger";

                s.GeneratorSettings.DocumentProcessors.Add(new SecurityDefinitionAppender("TEST_HEADER", new SwaggerSecurityScheme
                {
                    Type = SwaggerSecuritySchemeType.ApiKey,
                    Name = "TEST_HEADER",
                    In = SwaggerSecurityApiKeyLocation.Header,
                    Description = "TEST_HEADER"
                }));
            });

and accessing "http://.../swagger" works for me...

In the .NET Core 2.1 sample it also works with https:

Can you provide a sample project to reproduce this?

Looks like it was my mistake. I must give certificate for browser.


[C++][Parquet] column_reader.HasNext() throws an exception "Access violation executing location"

I'm trying to use C++ API to read a parquet file generated by a C# application based on PraquetSharp. As the title said, I encountered a problem of loading the UUID column. The schema, column description and sample code are shown below respectively.

Is the method I called incorrect?
P.S I can successfully load the FixedLenByteArray Column from the file generated by C++ API with "logical_type=NONE".
Component(s)
C++

@emkornfield

On the surface the reading code looks correct to me (at least the part not blocked by the exception):

Could you share the file that is generating this error?
What are the details on the exception being thrown?
You mention a file written by C++ code without the logical type, is the same true for the C# code?

Also what versions of the libraries are you using?

Thanks for your kindly reply. Here are my answers.

Sure. You can download it from Google Drive and One Drive.
Sorry, I don't know what you mean. The details of access violation? All I can get is "Exception thrown at 0x00000167FD250550 in TestCppParquet.exe: 0xC0000005: Access violation executing location 0x00000167FD250550" in Visual Studio.

No. I cannot read the file without logical type in C#.

My develop env list.

Visual Studio 2022
C++17
ParquetSharp v8.0.0
arrow v10.0.0

Sorry, I don't know what you mean. The details of access violation?

The exception shown in the first screen shot are different then the second screenshot.  The first one shows ParquetStatusException which I would expect to have more details, the second one is an access violation.
Could you upload the full code snippet (parts are hidden and I assume it is being called correctly but would like to verify) and also try on my box.  Using a precompiled version  pyarrow (6.0.1) to open the sample file seems to work fine for me, we should also try with later versions as there might have been a regression.

Yeah, the exception type varies per run. Sometimes Access Violation and Parquet Status Exception the other. I'm also confused about that.
int main() {
    auto reader = parquet::ParquetFileReader::OpenFile("D:\\sample.parquet", false);
    std::cout << reader->metadata()->schema()->ToString() << std::endl;
    auto rg_reader = reader->RowGroup(0);
    for (int i = 0; i < rg_reader->metadata()->num_columns(); i++) {
        std::cout << "Column " << i << std::endl << rg_reader->Column(i)->descr()->ToString() << std::endl << std::endl;
    }
    auto column_reader = static_cast<parquet::FixedLenByteArrayReader*>(rg_reader->Column(10).get());
    int64_t bytes_read = 0;
    int16_t def_levels, rep_levels;
    while (column_reader->HasNext()) {
        parquet::FixedLenByteArray fl_byte_array;
        column_reader->ReadBatch(1, &def_levels, &rep_levels, &fl_byte_array, &bytes_read);
        break;
    }
    return 0;
}

And my compile parameter is
cmake .. -G "Visual Studio 17 2022" -A x64 -DARROW_PARQUET=ON -DPARQUET_REQUIRE_ENCRYPTION=ON -DARROW_WITH_BZ2=ON -DARROW_WITH_LZ4=ON -DARROW_WITH_SNAPPY=ON -DARROW_WITH_ZLIB=ON -DARROW_WITH_ZSTD=ON -DCMAKE_BUILD_TYPE=Release
cmake --build . --config Release

Hope this can help.

So looking into it it appears the problem is likely:
static_cast<parquet::FixedLenByteArrayReader*>(rg_reader->Column(10).get());

The docs on Column() appear to be incorrect it looks like a fresh reader is returned each time.
If you assign the column reader to a variable first and then do the cast does it fix your issue?  If it does, would you like to contribute a PR updating the docs?

In fact, I think we might want to review most ownership comments in the file, I think all of these might be saying, that when the shared_ptr is returned from one of the objects, the Object must outlive the shared pointer as there is shared referenced state.

Aha, it works! Thanks for your help. It'll be my pleasure to contribute a PR to this repo. So, we need to update all the doc or comments mentioned "ownership" of a returned shared_ptr?

And another question, how to assign "UUID" to the logical type of a column? When I setup the schema followed by the example code, there is no choice of "UUID" like value in parquet::ConvertedType.
fields.push_back(
    PrimitiveNode::Make(
        "ActivityId",
        Repetition::REQUIRED,
        Type::FIXED_LEN_BYTE_ARRAY,
        ConvertedType::NONE,              // Is there any other way to assign "UUID" to the logical type?
        GUID_LEN
    )
);

Apologies for the late reply.

So, we need to update all the doc or comments mentioned "ownership" of a returned shared_ptr, right?

Yes, I believe so.  Would need to double check all of the methods

And another question, how to assign "UUID" to the logical type of a column? When I setup the schema followed by the example code, there is no choice of "UUID" like value in parquet::ConvertedType.

You need to use the variant that takes a logical type and construct it with the static factory

That's alright. I'll check the comments as soon as I can. Thanks for your kind reply again.


feat/430/handle custom schemas

Description
DBT lets you use custom schemas. This add the ability for dbt-sugar to parse those custom schemas and find the correct tables & columns during tasks.
How was the change tested
I tested it against our analytics db at Withings but their are multiple ways to use custom schemas so I probably should add some functional tests based on maintainers feedbacks.
Issue Information
Closes #430
Checklist

[x] I formatted my PR name according to CONTRIBUTING.md
[ ] I added a news fragment to help populating the changelog as encouraged in CONTRIBUTING.md
[x] I added "Closes #<issue_number>" in the "Issue Information" section (if no issue, feel free to tick thick the box anyway).

Thanks for opening this PR @PaulMatthieu I'll have a look in the coming days and see what we can do to get this merged as soon as possible.

I realized while testing this that this change ignore whatever is written in the {{ config() }} bloc in a dbt model
So for instance if your target schema is foo and you write {{ config(schema='bar') }} dbt-sugar will still look into the foo schema instead of the foo_bar schema, custom schemas will have to be defined in the dbt_project.yml file

Thanks a lot for this @PaulMatthieu
I think this is totally a welcome change!

I realized while testing this that this change ignore whatever is written in the {{ config() }} bloc in a dbt model
So for instance if your target schema is foo and you write {{ config(schema='bar') }} dbt-sugar will still look into the foo schema instead of the foo_bar schema, custom schemas will have to be defined in the dbt_project.yml file

That's indeed a problem because we re-implemented everything back in the day when the dbt API wasn't really stable.
I think the best way to really tackle this would be to leverage the dbt API more now that it's stable. But that's quite a bigger thing.
My guess, here, would be that we have to temporarily document that limitation. Do I get that right?

Btw, I'm not sure if you say but a bunch of unit tests are failing on this PR, do you need help with it?


[Menu] Unknown-props  React

Spotted errors
Warning: Unknown props `desktop`, `focusState` on <a> tag. Remove these props from the element.
  in a (created by Link)
  in Link (created by Menu)
  in div (created by List)
  in List (created by Menu)
  in div (created by Menu)
  in ClickAwayListener (created by Menu)
  in Menu (created by IconMenu)
  in div (created by PopoverDefaultAnimation)
  in div (created by PopoverDefaultAnimation)
  in div (created by Paper)
  in Paper (created by PopoverDefaultAnimation)
  in PopoverDefaultAnimationwarning

Warning: Unknown prop `onKeyboardFocus` on <div> tag. Remove this prop from the element.
  in div (created by MyComponent)
  in div (created by ListItem)
  in div (created by TouchRipple)
  in TouchRipple (created by EnhancedButton)
  in span (created by EnhancedButton)
  in EnhancedButton (created by ListItem)
  in div (created by ListItem)
  ...

Steps to reproduce
import React, { Component, PropTypes } from 'react'
import { Link } from 'react-router'

...

<AppBar
    iconElementRight={
        <IconMenu
            iconButtonElement={<IconButton><MenuIcon color={white} /></IconButton>}
            targetOrigin={{horizontal: 'right', vertical: 'top'}}
            anchorOrigin={{horizontal: 'right', vertical: 'top'}}
        >
            <Link to='/route1'>
                <MenuItem leftIcon={<Person />} primaryText='Item 1' />
            </Link>
            <Link to='/route2'>
                <MenuItem leftIcon={<SupervisorAccounts />} primaryText='Item 2' />
            </Link>
            <Link to='/route3'>
                <MenuItem leftIcon={<ViewList />} primaryText='Item 3' />
            </Link>
            <Divider />
            <Link to='/route4'>
                <MenuItem leftIcon={<PowerSettingNew />} primaryText='Item 4' />
            </Link>
        </IconMenu>
    }
/>

Versions

Material-UI: 0.15.3
React: 15.3.0
React-router: 2.6.1
Browser: Chrome

Description
Despite lot of warnings were removed with MUI 15.3, the 2 above still remains.
The first warning triggers after clicking on the menu icon.
The 2nd one is from loading another page

The <IconMenu /> is expecting his children to be some <MenuItem />.
Some accessibility feature of the <Menu /> are not going to work when used like this.
I'm closing this issue. Feel free to open another one regarding how to take advantage of
import { Link } from 'react-router',

Thanks for your fast answer.
The problem is it works great if i wrap the expected  INSIDE  but then it produces this warning
On other hand, if i implement this like in the IconMenu example in official site, with  , the link is reduced to a pixel hence not clickable at all, but yeah no more warning ....
So how a linkable menu item should be implemented with  from react-router ?

So how a linkable menu item should be implemented with from react-router?

Good question! That's why I think that you could open a new issue.
Right now, the best way to solve the navigation issue is to use the onTouchTap callback.

ok i'll do this way
Keep up with this great framework ! :)

found a better solution from mbrook : https://github.com/callemall/material-ui/issues/4691
just add prop
containerElement={<Link to='/path/to/page' />}

How would you go around adding multiple MenuItems conditionally ?
Ex:
{isAdmin ?
  <MenuItem primaryText="Admin Home" href="/admin" />
  <MenuItem primaryText="Admin Tools" href="/admin/tools" />
}

These would need to be wrapped in an outside element, or should I have one of these ternaries for each MenuItem? I used a span, and obviously got the error mentioned here.

Try replacing ? with &&
Also i'm not sure multiple component can be accepted without wrapping in an array. So if this raises an exception, just write line by line :
{isAdmin && <MenuItem primaryText="Admin Home" href="/admin" />}
{isAdmin && <MenuItem primaryText="Admin Tools" href="/admin/tools" />}

This is somewhat annoying since  on occasions I would like simply to render a Link (from react-router-dom) on one parameter, or button on the other. This issue makes it ugly to match non mui elements, and should have the options to suppress this.


[ci] Add retries to upload to S3

Uploading artifacts sometimes fails, we should retry it up to 3 times with a short backoff. Example failure: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/3840/pipeline/378
cc @Mousius @areusch

cc @hpanda-naut

@gigiblender want to take a look at this one?


Create regression test result file with no numbers to allow comparison of test suite runs

The regression test results text report contains a test number.  This causes problems because any change in the sequence results in line differences when comparing the report.  A report file without line numbers is needed to allow comparison.

I updated the tests.  Close the issue.


How to disable ipykernel / configure it?

I'd like to configure a jupyter environment and I'd like it to present only a single python Notebook in the launcher. Currently, if I use:
devShell = (jupyterlabWith {
  kernels = [];
}).env

I still see ipykernel in the launcher:

And if I use:
devShell = (jupyterlabWith {
  kernels = [
    (kernels.iPythonWith {
      name = "python";
      packages = p: [p.pint];
    })
  ];
}).env

I get another python launcher:

And I noticed that the python module pint is not available in the ipykernel notebook, but it is available in the right launcher.
How do I disable the ipykernel launcher?

please try:
jupyter lab --KernelSpecManager.ensure_native_kernel=False

The first time I tried removing this kernel, I failed, but this is something I would like for some time.
@GTrunSec Is this a new flag? If this works, we could add it by default.

Is this a new flag? If this works, we could add it by default.
Sure, It works. you can find all of the settings in the config file of jupyter. which means you can do either flag or put it in the config file(~/.jupyter/jupyter_notebook_config.py   )

The first time I tried removing this kernel, I failed, but this is something I would like for some time. Like 1/3 of the issue reports are about Python packages not working because people clicked on the wrong kernel.

I think this is a Nixpkgs issue. I also failed to trace the source of this kernel there but perhaps that's possible with some effort. @FRidh since you maintain some of jupyter's related packages in Nixpkgs perhaps you could help here please?


Fix OS X -> macOS in docs

okay to test

test this please

nvm, I guess I don't have the right privileges woops


Adds support for private_key_jwt

A recent merge added support for tls_client_auth scheme by providing an auth scheme value that would only add the client_id to the request body. The Private Key JWT scheme includes the client_id in the client_assertion and so is not needed in the main request body.
This PR simply returns unaltered params when private_key_jwt is specified as the auth_scheme

Based on OAuth JWT assertion specification (RFC 7523)


Search sources are shown twice in the component at the preview and runtime

Test App: https://sg-em-qaext.mapsqa.arcgis.com/apps/instant/notification/index.html?appid=94a0f5cd859d496585b55449a407d78e

Can't repro this anymore, Yay

Seeing this again in multiple apps in devext and QA.
it looks like it shows the default search source list twice, the one I configured shows as expected (only once.

I am not seeing this in QA this morning but another issue, after I add a search source the app preview got blank and showing a console error
Test app: https://sg-em-qaext.mapsqa.arcgis.com/apps/configure-template/index.html?appid=c68e7014f43a4e4b97caadb8ec251759

@aparveen I believe they have a patch for this coming in from the IA side. We should test again tomorrow.

This is fixed


Move kubelet systemd unit to keto-k8

Simplify the userdata to remove all kubernetes dependencies managed by keto-k8
See https://github.com/UKHomeOffice/keto-k8/issues/10.

Fixed by #68


Select keeps expanding the number of rows

Another small regression:
When stepping through the list of options and hitting the bottom or the top, the number of options keeps increasing with new lines printed for existing options. This is probably just a small oversight somewhere in tracking the cursor position.
On a side note: the keyboard shortcuts for selecting items are a bit confusing without reading the documentation. Maybe a default hint would be good?

Hey, I do not seem to be able to replicate the described behaviour, maybe provide a code snippet reproducing it?
As for the side note, some hints would be cool indeed! Can't expect every end user reading the documentation 😉

The issue seems to happen when the number of options > limit. What is the expected behaviour in this case? Scrolling or extending the list?
In either case, the list extended with the already displayed options instead of the new ones. And keeps extending the further you go...

Sorry, that wasn't quite correct: The list is extended with the new choices first. Then it keeps expanding further.

Ah yes, I see what's wrong with it, working on a fix, good catch!

Wow, quick work :) Also, while we are at wish lists -- some kind of "has more" indicator would be nice if not all options are displayed.

I'm at a loss on how to implement this without over-cluttering with additional lines over or bellow the tool. Something like this would also need to be implementable with the multiline editor tool, as it also offers the same scrolling effect.
I think that context could suffice in this case, as simply pressing "up" brings the user to the end of the list, immediately indicating whether there are more option. If conveying the amount of rows is a must, a hint could also help out.

Fair point. I do like the very clean interface.


Deployments not working with version": "16.1.403000

When trying to run a DO deployment with a version": "16.1.403000 my f5s will not pull a license from my bigiq. This used to work without any change.

@cmgksims Can you share the entire output of the runtime init logs, as well as the runtime init config YAML you used. If you are using a template, please share the template name, version, and input parameters (all sanitized).
thanks

f5init.log
custom.tmpl.log
INIT_URL  = "https://cdn.f5.com/product/cloudsolutions/f5-bigip-runtime-init/v2.0.3/dist/f5-bigip-runtime-init-2.0.3-1.gz.run"
DO_URL   = "https://github.com/F5Networks/f5-declarative-onboarding/releases/download/v1.44.0/f5-declarative-onboarding-1.44.0-5.noarch.rpm"
AS3_URL  = "https://github.com/F5Networks/f5-appsvcs-extension/releases/download/v3.51.0/f5-appsvcs-3.51.0-5.noarch.rpm"
TS_URL    = "https://github.com/F5Networks/f5-telemetry-streaming/releases/download/v1.35.0/f5-telemetry-1.35.0-1.noarch.rpm"

The version I ran this same config on and it worked was on version 16.1.303000

Your error log shows an unsupported value for the Provision class:
2024-07-11T18:10:27.818Z [8886]: error: {"id":"b8a1d136-a78e-42ca-8150-2912427eb954","selfLink":"https://localhost/mgmt/shared/declarative-onboarding/task/b8a1d136-a78e-42ca-8150-2912427eb954","code":400,"status":"ERROR","message":"bad declaration","errors":[{"keyword":"enum","dataPath":".declaration.Common['myProvisioning']","schemaPath":"#/allOf/3/then/propertyNames/enum","params":{"allowedValues":["class","afm","am","apm","asm","avr","cgnat","dos","fps","gtm","ilx","lc","ltm","pem","swg","urldb","sslo"]},"message":"should be equal to one of the allowed values","propertyName":"iruleslx"},{"keyword":"propertyNames","dataPath":".declaration.Common['myProvisioning']","schemaPath":"#/allOf/3/then/propertyNames","params":{"propertyName":"iruleslx"},"message":"property name 'iruleslx' is invalid"},{"keyword":"if","dataPath":"","schemaPath":"#/allOf/1/if","params":{"failingKeyword":"then"},"message":"should match \"then\" schema"}],"result":{"class":"Result","code":400,"status":"ERROR","message":"bad declaration","errors":[{"keyword":"enum","dataPath":".declaration.Common['myProvisioning']","schemaPath":"#/allOf/3/then/propertyNames/enum","params":{"allowedValues":["class","afm","am","apm","asm","avr","cgnat","dos","fps","gtm","ilx","lc","ltm","pem","swg","urldb","sslo"]},"message":"should be equal to one of the allowed values","propertyName":"iruleslx"},{"keyword":"propertyNames","dataPath":".declaration.Common['myProvisioning']","schemaPath":"#/allOf/3/then/propertyNames","params":{"propertyName":"iruleslx"},"message":"property name 'iruleslx' is invalid"},{"keyword":"if","dataPath":"","schemaPath":"#/allOf/1/if","params":{"failingKeyword":"then"},"message":"should match \"then\" schema"}]},"declaration":{"schemaVersion":"1.44.0","class":"Device","async":true,"label":"Onboard BIG-IP into Standalone Configuration","Common":{sanitized}}}}
Here's the schema for DO 1.44.0: https://github.com/F5Networks/f5-declarative-onboarding/blob/574f8bef34f6599bdd64a468dd4aa32ca1da54eb/src/schema/1.44.0/system.schema.json#L93
I recommend opening an issue in the DO project if you think this is incorrect: https://github.com/F5Networks/f5-declarative-onboarding/issues

yea i had actually fixed that.  It was still failing before i had changed that as well. So i fixed that and changed it. The previous version i was using is https://cdn.f5.com/product/cloudsolutions/f5-bigip-runtime-init/v1.5.1/dist/f5-bigip-runtime-init-1.5.1-1.gz.run but that did not work once i updated to the new bigip version 16.1.4

bigIpRuntimeInit.log

Latest deployment with everything using latest versions.
f5init.log

Here it looks like you are failing to install Telemetry Streaming:
2024-07-12T05:10:26.418Z [10075]: silly: Request response: 200 {"packageFilePath":"/var/config/rest/downloads/f5-telemetry-1.33.0-1.noarch.rpm","operation":"INSTALL","id":"07f5c7de-fa6a-41e1-b209-8458b9d2a408","status":"STARTED","startTime":"2024-07-11T22:10:02.767-0700","userReference":{"link":"https://localhost/mgmt/shared/authz/users/admin"},"identityReferences":[{"link":"https://localhost/mgmt/shared/authz/users/admin"}],"ownerMachineId":"adcc7ffa-1d57-47e9-b61e-bfaae9c5dbb9","generation":2,"lastUpdateMicros":1720761002767295,"kind":"shared:iapp:package-management-tasks:iapppackagemanagementtaskstate","selfLink":"https://localhost/mgmt/shared/iapp/package-management-tasks/07f5c7de-fa6a-41e1-b209-8458b9d2a408"}
2024-07-12T05:10:27.970Z [10075]: error: Max count exceeded, last response: undefined

That is most likely due to the required iControl LX sys db variables not being set, and also possibly using an instance size that is too small. Check our our templates for the current example that sets the db variables: https://github.com/F5Networks/f5-azure-arm-templates-v2/blob/64802083a592ba10e1f0854b5155cef74568f65a/examples/modules/bigip-standalone/bigip.json#L254
I believe these variables did change between 16.1.3 and 16.1.4. For maximum chance of success, I recommend you use our templates to deploy...you can still provide custom Runtime Init configuration using the template input parameters.

I had removed the ilx from provisioning even tried removing telemetry streaming from being downloaded and still no avail.  Here is my template file sanitized. I'm also using the Standard_F32s_v2 azure vm.
custom copy.tmpl.log

The updated sys db variables are in the wrong place in your script, they need to be right after this line:
Run Immediately Before MCPD
Adding them to the DO config has no effect since they need to be set before MCPD starts.
Also, we have not tested Runtime Init with that instance type or size.

that fixed it moving those values out of the script


The loading indicator is still existing even the ping response is returned .

The loading indicator is still existing even the ping response is returned .

Is there a reason there is a scroll bar that appears? can we make sure it doesn't appear?

@lweitzman
Seems it's not caused by our code, might come from the framework themselves, possibly Angular. The framework fails to refresh the view when the data status is changed. Sometimes, if you click the view, then everything become normal again. So, a weird issue. Keep eyes on it.

move to SP12

defer to sprint 13.

As it's fixed, close this issue.


Sema: Open type cleanup

Splitting up https://github.com/apple/swift/pull/3033 into smaller pieces for testing and review.
This is all part of the nested generics work. Getting close now...

@swift-ci Please test

This looks fantastic!

@swift-ci Please test and merge

I'm merging this manually. The tests passed, but Jenkins threw an IOException.


Trinity stalls on state sync resume

What is wrong?
Upon stopping and resuming state sync, my sync has stalled.  There appears to be a sincle trie node in the request queue that none of my peers have and it cannot move beyond it.
How can it be fixed
Haven't dug in yet.

need to detect this state.  Probably some additional tracking on the missing trie nodes to ensure we don't just re-request the same node to the same peers endlessly.
when we detect this. Probably need to sync more of the header chain and then try incrementally newer state roots to do the state sync from.

Assuming this is the desired strategy, this is another case for concurrent state and chain data syncing.

@carver I removed this from the Margaret Hamilton milestone as I think it's a more significant refactor to the FullSyncer service than we can reasonably do for this release.  Can you add it to the next milestone when you create it?

Latest thoughts on how we can deal with this.

Change FastChainSyncer to first download the header chain (no block bodies or receipts)
Run both the FastChainSyncer and the StateDownloader concurrently once the header chain has been synced.
Anytime the state root that the StateDownloader is using is more than X blocks behind the current head of the chain, update to a newer state root.

We may need to build a mechanism for smooth transition from one state root to another in the state downloader.  Simply re-starting the state download with the new state root will potentially incur significant overhead.  Ideally we can preserve whatever data from the existing state downloader and populate the new one, filtering out any SyncRequest that is for a node-key which is not present under the new state root.


Treesitter offset directive has no effect

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.ai
Description
offset directives in a Treesitter query have no effect when defined as a textobject with mini.ai.
The same query defined as a textobject with nvim-treesitter-textobject applies the offset as expected.
Neovim version
0.10.3
Steps to reproduce
after/queries/lua/textobjects.scm:
; extends
((table_constructor) @table.outer @table.inner (#offset! @table.inner 0 1 0 -1))

mini.ai setup:
require'mini.ai'.setup {
  custom_textobjects = {
    ['x'] = require'mini.ai'.gen_spec.treesitter({ a =<EMAIL_ADDRESS>i =<EMAIL_ADDRESS>}),
  },
}

Test file:
{a}

Expected behavior
dix should delete a and leave {}.
Actual behavior
dix deletes {a}.

Thanks for the suggestion!
I can reproduce, but I'd not call it a "bug" per se since this was more or less experimental at the time 'mini.ai' was created. And I feel still is. But maybe there is a better tooling now to handle this. I'll take a look.

There's a number of queries in nvim-treesitter-textobject that useoffset, and in general it's very useful to define the "inner" variant of a textobject, I think this might be good reason to support it.
Do you know what work is required for this? Happy to help you're open to it.

Do you know what work is required for this? Happy to help if you're open to it.

Probably some way of properly getting this offset information (in a backwards compatible down through Neovim 0.8 way; maybe have this only starting from some more recent version if the API is difficult) and apply it here. I think this should be it, but can't vouch for that.
If you want to and have (lots of) free time, sure go ahead. But if not - no worries; I'll probably look at it this week.

Ah I understand now why the offset is ignored. The directive stores the adjusted range in the capture metadata, whereas mini.ai only looks at the captured node.
See the relevant code in nvim-treesitter-textobject.

Ah I understand now why the offset is ignored. The directive stores the adjusted range in the capture metadata, whereas mini.ai only looks at the captured node.

I see. That metadata behaving that exact way may be too recent. Needs an actual testing with earlier Neovim versions if that still works.


nixos/x11/display-managers: don't touch graphical-session.target in xsession-wrapper

This is not correct and will in fact break things because they try to run before the target is reached.
WMs users may need some sort of a manual workaround for this...
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Looks like this should fix #225605.

Yes, it should.

Pinging everyone who touched all the other DE/WM modules recently for testing:
@FedericoSchonborn for Budgie
@bobby285271 for Cinnamon
@wineee for Deepin
@romildo for a bunch of stuff
@jtojnar for GNOME
@edwtjo for Kodi
@worldofpeace for MATE
@tomfitzhenry for Phosh
@j0hax for RetroArch
@etu for Surf
@sternenseemann for 2bwm and xmonad
@AndersonTorres for a bunch of stuff
@necauqua and @teto for Awesome
@3JlOy-PYCCKUi for dk
@bobvanderlinden for dwm
@reedrw and @Ma27 for i3
@marcusramberg for nimdow
@arjan-s for qtile
@Uthar for StumpWM
If anyone else knows anyone who's actively using the more obscure sessions, please ping them so they can test too.

DDE (deepin) works fine

test by:

# nix run -v -L
{
  inputs.nixpkgs.url = "github:K900/nixpkgs/dont-touch-graphical-session-target";
  #inputs.nixpkgs.url = "path:/home/rewine/nur/nixpkgs";

  outputs = inputs@{ self, nixpkgs }: let
    system = "x86_64-linux";
    pkgs = import nixpkgs { inherit system; };
  in {
    nixosConfigurations.vm = nixpkgs.lib.nixosSystem {
      inherit system;
      modules = [
        {
        imports = [ "${nixpkgs}/nixos/modules/virtualisation/qemu-vm.nix" ];
        services.xserver = {
          enable = true;
          displayManager = {
            lightdm.enable = true;
            autoLogin = {
              enable = false;
              user = "test";
            };
          };
          desktopManager.deepin.enable = true;
        };

        users.users.test = {
          isNormalUser = true;
          uid = 1000;
          extraGroups = [ "wheel" "networkmanager" ];
          password = "test";
          createHome = true;
        };
        virtualisation = {
          qemu.options = [ "-device intel-hda -device hda-duplex" ];
          cores = 8;
          memorySize = 8192;
          diskSize = 16384;
          resolution = { x = 1024; y = 768; };
        };
        system.stateVersion = "23.05";
      }];
    };
    packages.${system}.default = self.nixosConfigurations.vm.config.system.build.vm;
    apps.${system}.default = {
      type = "app";
      program = "${self.packages.${system}.default}/bin/run-nixos-vm";
    };
  };
}

I'm not maintaining/using dwm. @viric and @neonfuz are :+1:

FWIW I can personally vouch for this working fine on Plasma, but Plasma is the odd one out here, as it actually uses systemd correctly.

You can test whether this modification affects lomiri

Lomiri seems to still work fine after this.

The purpose of this PR is to stop breaking things that actually rely on a graphical session being fully started. Right now every autostart application is basically racing the session setup to determine whether it gets the right environment set up.

We will figure the correct workaround in the future.

I'd rather just not merge this until a workaround is in place.

The tests do pass, but this may have unexpected side effects that are not caught by the test.

Updated with a hack to retain the old behavior for non-compliant WMs. Thanks to @hrnz on Matrix for coming up with the XDG_CURRENT_DESKTOP idea.

Tested locally with Plasma and i3 and things work mostly as expected.

Also added a magic value X-NIXOS-SYSTEMD-AWARE to allow custom sessions to opt into this behavior.

@3JlOy-PYCCKUi can you retest if the current workaround works for your setup?

So I just went through and checked the session configs for the most common WMs, and I'm pretty sure we're fine here.

Looks like for GNOME-based DEs, gnome-session.target has BindsTo=graphical-session.target.
Tested GNOME Shell and the graphical-session.target is properly started there:
$ systemctl status --user graphical-session.target
● graphical-session.target - Current graphical user session
     Loaded: loaded (/etc/systemd/user/graphical-session.target; static)
     Active: active since Sat 2023-07-08 14:25:58 UTC; 25s ago
       Docs: man:systemd.special(7)

Jul 08 14:25:58 nixos systemd[1340]: Reached target Current graphical user session.

However, in GNOME Flashback (XDG_CURRENT_DESKTOP=GNOME-Flashback:GNOME), it does not appear to be the case:
$ systemctl status --user graphical-session.target
○ graphical-session.target - Current graphical user session
     Loaded: loaded (/etc/systemd/user/graphical-session.target; static)
     Active: inactive (dead)
       Docs: man:systemd.special(7)

VM configuration
{ pkgs, lib, config, ... }:
{
  environment.systemPackages = with pkgs; [
    gdb
  ];

  environment.enableDebugInfo = true;

  services.xserver = {
    enable = true;

    displayManager.defaultSession = "gnome-flashback-metacity";
    displayManager.gdm = {
      enable = true;
    };
    desktopManager.gnome = {
      flashback.enableMetacity = true;
    };
  };

  services.openssh.enable = true;

  systemd.coredump.extraConfig = ''
    Storage=external
  '';

  users.extraUsers.jtojnar = {
    isNormalUser = true;
    uid = 1000;
    extraGroups = [ "wheel" "networkmanager" ];
    password = "";
    openssh.authorizedKeys.keys = [ "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDYbOlZydfRRCGCT08wdtPcpfSrgxMc6weDx3NcWrnMpVgxnMs3HozzkaS/hbcZUocn7XbCOyaxEd1O8Fuaw4JXpUBcMetpPXkQC+bZHQ3YsZZyzVgCXFPRF88QQj0nR7YVE1AeAifjk3TCODstTxit868V1639/TVIi5y5fC0/VbYG2Lt4AadNH67bRv8YiO3iTsHQoZPKD1nxA7yANHCuw38bGTHRhsxeVD+72ThbsYSZeA9dBrzACpEdnwyXclaoyIOnKdN224tu4+4ytgH/vH/uoUfL8SmzzIDvwZ4Ba2yHhZHs5iwsVjTvLe7jjE6I1u8qY7X8ofnanfNcsmz/ jtojnar@kaiser" ];
  };

  imports = [ <nixpkgs/nixos/modules/virtualisation/qemu-vm.nix> ];
  virtualisation.memorySize = 3 * 2048;
  virtualisation.diskSize = 28048;
  virtualisation.qemu.options = [ "-device intel-hda" "-device hda-duplex" ];
  virtualisation.forwardPorts = [
    # forward local port 2222 -> 22, to ssh into the VM
    { from = "host"; host.port = 2222; guest.port = 22; }
  ];

  systemd.user.services.test-g-s-t = {
    description = "test-g-s-t";
    wantedBy = [ "graphical-session.target" ];
    partOf = [ "graphical-session.target" ];
    serviceConfig.ExecStart = "${pkgs.bash}/bin/sh -c 'while true; do echo running in graphical-session; sleep 5; done'";
  };
}

I would also expect it to work in Pantheon if I add it to the list but it does not appear to.
--- a/nixos/modules/services/x11/display-managers/default.nix
+++ b/nixos/modules/services/x11/display-managers/default.nix
@@ -40,7 +40,7 @@ let
         IFS=:
         for i in $XDG_CURRENT_DESKTOP; do
           case $i in
-            KDE|GNOME|X-NIXOS-SYSTEMD-AWARE) echo "1"; exit; ;;
+            KDE|GNOME|Pantheon|X-NIXOS-SYSTEMD-AWARE) echo "1"; exit; ;;
             *) ;;
           esac
         done

I thought Pantheon used gnome-session?

Oh, we do not actually use systemd code path for Budgie, Pantheon and GNOME Flashback yet, only for GNOME Shell: https://github.com/NixOS/nixpkgs/issues/228946

However, in GNOME Flashback (XDG_CURRENT_DESKTOP=GNOME-Flashback:GNOME), it does not appear to be the case:

It looks like nixosTests.gnome-flashback is now failing :eyes:

I think this might be https://github.com/NixOS/nixpkgs/issues/228946 ?

Ah yeah, I was confused why the Pantheon test passed while not systemd managed but later found it does not have GNOME in XDG_CURRENT_DESKTOP :woman_shrugging:

I'm not sure if still needed, but I tested stumpwm like this:
In one terminal:
Xephyr :3

In another terminal:
DISPLAY=:3 /nix/store/...-stumpwm-22.11/bin/stumpwm

And it started.

Cute :3


update readme to list new default imports

Problem:

default imports are wrong on package site (and readme)

Solution

update default imports based on this from the compiler

I already updated it, but I wasn't able to get it to show up on the package website yet.

Oops, did not see this earlier! I updated it eventually then.


Create generic_monster_dr.py

Converted to Draft because my condition does not have the query all monster DR's have, e.g. https://github.com/GrognardsFromHell/DllDocumentation/wiki/Conditions-(List)-page-2-M-Z#monster-dr-holy
If I understand it correctly, It just checks if data1(which would be arg2 in my condition) has a valid (>0) value and if not it prints a debug msg
Should I add it to the generic_monster_dr.py or not? Can't see a real benefit.

Not sure what exactly it's for but let's be conservative with it and keep it.

Not sure what exactly it's for but let's be conservative with it and keep it.
I do see these errors sometimes btw.

I just tested target.d20_query(S_Verify_Obj_Conditions) in game with a plain Vrock.  Wanted to see the return before I start to implement the hook into the generic_monster_dr.
The game crashes :(

Oh, I hadn't even noticed it was query rather than signal. Heh. It should be a signal I suppose.
But I guess since it's buggy in itself, just leave it out.


Scrub change log

I think that now we've renamed the project and removed the previous tags, we should begin with a clean change log.

Isn't it usually the case that you leave credits, licenses and changelogs from the original project in place and just "append" your new changes? I think that'd make it a bit clearer to everyone what's going on.
Also the line in the README is wrong:
Amazing Print is a fork of AmazingPrint

Good catch on the README. I just fixed that.
I didn't want to leave the change log since we decided to start the version over and scrubbed the previous tags. That means there would be no reasonable way to check out those previous versions in this project.
I'm no license expert, just wanted to make sure there was no confusion. I added back the original copyright line to the gem spec. Any other specific recommendations?

Fair enough, I'd just make sure proper credit to the original project is given and there's a link back to the original project so people can look up older issues / the old changelog file or other discussions. Not a license expert either, just something I observed on other projects.
Thanks for merging these changes already and getting rid of the warnings, much appreciated :)


Updated link load balancer getting started page

It looks like the document has moved to a new url

Hi @ilivewithian, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@ilivewithian Thanks for the contribution!  I've forwarded this change onto the author.


BUG: Properly validate FASTA files

closes #187

Hey @Oddant1, can you take a look at this forum post: https://forum.qiime2.org/t/training-feature-classifier-2019-10-error/13025/
It looks like some of the new validation you implemented in this PR is being hit by these users, although it looks like maybe they don't have quite enough information in the error message to fix anything. Also, it looks like maybe the validation isn't quite working as expected? I'm not sure, I would need to take a closer look at this code to fully understand, but wanted to ping you first to see if you have any ideas. Thanks!

@thermokarst, apologies for the late reply, I have a theory I will be posting on the forum. I'm not 100% sure it's correct as I was strangely unable to exactly replicate the errors either user experienced, but I got something similar. Also yes I think it's a good idea to make it so the error also prints what character is erroneous and ideally also where said character is within the line.

Apologies for forgetting to update this asap. Based on the responses of the forum users in the forum thread, I believe my theory was correct, and they had trailing whitespace causing validation errors. The user then ran into what (I think) was a largely unrelated issue that @nbokulich helped them with.


Add policies attr to core doctype

As we want content to be tagged to Policies, this commit adds the policies attribute to the core doctype.

@tommyp This field needs to be added to the schema for the government index in config/schema/elasticsearch_schema.yml too.  That index hasn't been migrated over to the json-format schema files yet.


"Authenticated Users": Vagueness Surrounding Term

Defect: Vague term, "Authenticated User", being used. I, as a reader, am currently unaware of what makes someone authenticated and how and if they will be displayed differently: elaborating on this issue will help differentiate Feature 2 and Feature 5.
Location:  Feature 5 Description
Recommended Fix: Elaborate on the importance and definition of an Authenticated user. List some possible solutions on how they would be distinguished between "regular" users.
Criticality: Moderate

There is vagueness around this requirement. Therefore, this vagueness is reflected in the user stories. At this point, everyone is a "regular" user, and "authenticated" users are "regular" users. This would be a question for stakeholders or requirements. Based on the current iteration of the design this requirement has not been addressed. It may be necessary to get clarification from stakeholders. This is a requirements team issue, not a usability team issue. The requirement to "display posts from authenticated users" was taken directly from the requirements provided by stakeholders and in my understanding has yet to be addressed. I have no solutions at this time but will make sure to address it with my team.


[WIP] fix no user found with USER configured

Containers with USER configured (for example) failed to run on EVE with no user found. I noticed, that code inside containerd expects files to be loaded from real rootfs (not from created by default). So, we should set Root.Path properly before doing other things.
cc @deitch
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

This finally makes sense, and some nice sleuthing work @petr-zededa . You are saying that the problem was, when we started a container with a USER setting, it looked for that user in /etc/passwd inside the container's root. If it couldn't find it, it gave the error. It might not find it for 3 reasons:

there is no /etc/passwd - this is a malformed container, and so we can ignore the issue
the user is not in /etc/passwd - this is a malformed container, and so we can ignore the issue
the root is incorrect - this is because we have not yet passed it the correctly configured root

This PR aims to fix the last one.
I think this is good, but it does bother me how necessary it is. I get the sense we are doing stuff that is too complicated with our interaction with containerd, and need to simplify it. Not in this PR, though.

Well, I think I will do additional testing of it and then remove WIP.
I think it's worth dealing with the running container-in-VM (which actually runs under root now anyway).

Hey @giggsoff -- there's one bit I still don't quite follow -- so would be useful to follow up on slack before this gets merged.
And now for a bigger question of how to productize our containers-in-VMs implementation:
There -- I agree with @deitch -- we should probably take the path of least resistance and make it look like container that is being setup is a straight up OCI container (so that containerd just does the usual it would do for any other container).
You maybe asking, but Roman -- why is it not the case right now. The answer to that are Task Loaders https://github.com/lf-edge/eve/blob/master/docs/TASKS.md#eve-task-loaders
When I first implemented them I basically made the container filesystem looks like this to containerd:
/everything-from-loader-filesystem
  /mnt/rootfs
           /actual container filesystem

This layout allows loaders to start, do whatever setup is necessary and then start serving /mnt/rootfs/ as the actual root filesystem (e.g. via 9P when loader is a hypervisor).
However, what @giggsoff findings indicate is that containerd obviously expects something in /etc/passwd from the container itself (and that is of course available under /mnt/rootfs/etc/passwd).
So... one option here (which I actually briefly considered when implementing this -- since runq does it that way) is to flip the relationship and do:
/actual container filesystem
  /?
    /everything-from-loader-filesystem

This is not that much more complicated than what we currently have AND it will make containerd much happier since from containerd perspective the /actual container filesystem will look exactly like what it expects.
I need to consider this a bit more -- but that's roughly where I would go with this

Oh that is pretty interesting @rvs ; you want to put the loader stuff inside the container, rather than the other way around. Would it create any issues when the init process in the VM starts looking for its root filesystem? Or is it that the root for the VM and the root for the container are the same?
They also could be side-by-side, I think, as long as the VM could find that filesystem (9P or similar)

Actually @rvs, I think it is not good idea to modify rootfs of container, it can lead to unpredictable conflicts in directory naming. The option to create a wrapper around rootfs (as it is done now) seems reasonable.
There are no problems in difference between container-in-VM and no-hyper variants in aspect of rootfs location. As @deitch mentioned, /mnt/rootfs is 9p-mounted directory, and on the side of pillar/containerd (I mean in the preparation steps) files are located in ...volume/rootfs in both cases.
The problem that I was trying to solve and what I wrote about earlier is related to launching the application directly in the init of container-in-VM. And I open another PR #1910 for this.


Command to list all movies/series

Telegram user @JuanraNunez requested a command to list all movies/series in sonarr/radarr. Would need to determine if it should list only missing, downloaded, or all. Will be more complex for series to list missing, maybe # of episodes missing per season or overall.

The stated use case is not very strong for a command that lists ALL series/movies. Instead, I suggest using the /movie or /series commands to check if an individual movie/series is already in radarr/sonarr.
A sub-suggestion was made to add a command that lists the N most recently-added movies/series or movies/series added in the last N days. That could be interesting.


Bump rules_python to 0.13.0

What this PR does and why we need it:
This is needed in order to flip the disallow empty globs flag.
Version 0.11.0 makes it possible.
0.13.0 is the latest available at the time of this bump.
New changes / Issues that this PR fixes:
The idea is to fix the issues of Bazel Bench tests when being run with incompatible_disallow_empty_glob
https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1301#0183e377-9bfb-43fe-b329-fd314fb22b06
Special notes for reviewer:
None
Does this require a change in the script's interface or the BigQuery's table structure?
I don't think so but I don't know

CI fails with
(21:55:22) ERROR: /workdir/utils/BUILD:40:11: no such package '@third_party_googleapis_common_protos//': The repository '@third_party_googleapis_common_protos' could not be resolved: Repository '@third_party_googleapis_common_protos' is not defined and referenced by '//utils:google-common'
--
  | (21:55:22) ERROR: Analysis of target '//utils:google-common' failed; build aborted: Analysis failed

Can you please have a look there?

Yes, it seems that rules_python might have added an additional dependency.

@meisterT I changed it to bump only to 0.11. This is the minimum needed for incompatible_disallow_empty_glob and it does not require any code adaptions.


chore(e2e): add css back to e2e tests where it was missing

Discussed with Brandy

Too slow, merging directly after discussing with team


Add some AmazingFeature

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Krishna seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Eliminate bind(), emit stats right after data

The data and stats events are the exact same event. Instead of binding an event to an event, just emit both one after the other.
This also solves an event emitter leak we're seeing.
cc/ @rf @raynos

This is a great solution. :+1:


Mixed content - requests are blocked

I've installed the plugin but it seems it doesn't work under https:
Mixed Content: The page at 'https://redmine.org/issues/12284' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://redmine.org/issues/12284?issue_count=22&issue_position=1&next_issue_id=12245'. This request has been blocked; the content must be served over HTTPS.
issue_dynamic_edit.js:345  -------- Error while updating the issue attribute dynamically --------
issue_dynamic_edit.js:346  xhr data:
issue_dynamic_edit.js:347 {readyState: 0, getResponseHeader: ƒ, getAllResponseHeaders: ƒ, setRequestHeader: ƒ, overrideMimeType: ƒ, …}
issue_dynamic_edit.js:348  msg data:
issue_dynamic_edit.js:349 error
issue_dynamic_edit.js:350  error data:
issue_dynamic_edit.js:351
issue_dynamic_edit.js:352  ----------------------------------------------------------

LOCATION_HREF

"https://redmine.org/issues/12284"

I get the same issue.

Hi !
As @Bodge-IT mentionned (thank you for your message), the plugin uses the current URL of the webpage to perform specific AJAX calls. You must be sure that your server configuration is correct and forces user to be redirected to your https version of your Redmine instance.
I've also updated the plugin and added a new configuration file where you can force https request. I'm not sure it will resolve your problem because it looks like a server configuration issue but it's the max I can do.
If you find the plugin helpful, please take a minute to star it on Github and rate it 5 stars on http://www.redmine.org/plugins/redmine_issue_dynamic_edit 👍


[cgal] build failure

I want to build cgal (for use with openMVS) with x64-windows flag. Build of cgal failed due to a fail of building yasm-tool
I have tried three different approaches (described below), all three failed
Host Environment

OS: Win 10, Pro Education N, Version 20H2
Compiler: VisualStudio 2019, 16.9.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg install cgal[core]
Failure logs
-Cut and past the appropriate build messages from the console output.
-Please attach any additional failure logs mentioned in the console output.
C:\xxx>.\vcpkg\vcpkg install cgal[core]  --triplet=x64-windows
Computing installation plan...
The following packages will be built and installed:
cgal[core]:x64-windows -> 5.2#3

gmp[core]:x64-windows -> 6.2.1#5
mpfr[core]:x64-windows -> 4.1.0
yasm-tool[core]:x64-windows -> 2020-10-12
yasm-tool-helper[core]:x64-windows -> 2020-10-12
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...

CMake Error at scripts/cmake/vcpkg_fail_port_install.cmake:97 (message):
The yasm-tool port is only intended to be built for x86 Windows

Architecture 'x64' not supported by yasm-tool!
Call Stack (most recent call first):
ports/yasm-tool/portfile.cmake:1 (vcpkg_fail_port_install)
scripts/ports.cmake:142 (include)
Error: Building package yasm-tool:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: yasm-tool:x64-windows
Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

Actually, I need cgal as X64 libs. Nevertheless, I have tried to build it as X86 libs with >.\vcpkg\vcpkg install cgal[core]  --triplet=x86-windows, but this doesn't work, too, since the build process try to build everything with x86-windows flag, but not yasm-tool. It is still tried to build it with x64-windows option.
C:\xxxx>.\vcpkg\vcpkg install cgal[core]  --triplet=x86-windows
Computing installation plan...
The following packages will be built and installed:
cgal[core]:x86-windows -> 5.2#3

gmp[core]:x86-windows -> 6.2.1#5
mpfr[core]:x86-windows -> 4.1.0
yasm-tool[core]:x64-windows -> 2020-10-12
yasm-tool-helper[core]:x64-windows -> 2020-10-12
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Detecting compiler hash for triplet x86-windows...

CMake Error at scripts/cmake/vcpkg_fail_port_install.cmake:97 (message):
The yasm-tool port is only intended to be built for x86 Windows

Architecture 'x64' not supported by yasm-tool!
Call Stack (most recent call first):
ports/yasm-tool/portfile.cmake:1 (vcpkg_fail_port_install)
scripts/ports.cmake:142 (include)
Error: Building package yasm-tool:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: yasm-tool:x64-windows
Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

It is possible to build yasm-tool directly with x86-windows flag. But even, if this was done successfully. A new call of vcpkg install cgal[core] fails with the same error as described above.
....
Installing package yasm-tool[core]:x86-windows... done
Elapsed time for package yasm-tool:x86-windows: 82.4 ms
Total elapsed time: 3.597 s
C:\xxxx>.\vcpkg\vcpkg install cgal[core]  --triplet=x86-windows
Computing installation plan...
The following packages will be built and installed:
cgal[core]:x86-windows -> 5.2#3

gmp[core]:x86-windows -> 6.2.1#5
mpfr[core]:x86-windows -> 4.1.0
yasm-tool[core]:x64-windows -> 2020-10-12
yasm-tool-helper[core]:x64-windows -> 2020-10-12
Additional packages (*) will be modified to complete this operation.
....
Building package yasm-tool[core]:x64-windows...
CMake Error at scripts/cmake/vcpkg_fail_port_install.cmake:97 (message):
The yasm-tool port is only intended to be built for x86 Windows

Architecture 'x64' not supported by yasm-tool!
.....

Same issue with colmap

I've also been looking at this issue for the past day too.   One thing you can do is to remove the dependencies listed in ports/gmp/vcpkg.json and then just install these packages first: yasm-tool:x86-windows, vs-yasm:x64-windows, yasm-tool-helper:x64-windows (all of these arch. specifically!).  In my build I use a custom port folder for gmp with this change.
It seems like the dependency list doesn't support cross-arch. dependency which is currently required due to yasm issues.
I'm still working on mpfr issues on both windows and linux however...

IIUC the yasm-tool issue is tracked in  #17627, and there is a draft PR in #16478.

Thank you mike-crabat. Your proposal has solved my current problem.
Since I'm not familiar with vcpkg details (actually my first usage):
What is the official update mechanism, e.g. dg0yt: "there is a draft PR in #16478"
in "#16478" there are "proofed changes". When will the changes (dealing with "#16478" and with "17667") officially be available?

Duplicated to #17627,


[FocusNotifications] Build error

Actual behaviour
When the FocusNotifications component is used like below
<FocusNotifications />

It raised errors.
But when  it is used like this :
<FocusNotifications.default />

It works.
Expected behaviour
<FocusNotifications />

Versions
0.1.0-rc1

This will be fixed by the webpack-focus upgrade


fix: ValueError target column of train dataframe has NaN or Inf.

@AkiraUra
Added code to remove rows of nan or inf values if they exist in the target column of the training data.
This PR is a part of the following PRs.

sapientml: fix/target_column_has_nan_or_inf
core: fix/target_column_has_nan_or_inf

Please take a review on it.

This PR is no longer required due to the following PR:

https://github.com/sapientml/core/pull/55

This fix is included here.

https://github.com/sapientml/core/pull/67

The above closes this PR.


Crash when last candle die vs bots

Both release & debug.
Playing vs 4 bots.
Placing candle and kill it yourself 3 times crashes

It only crashes if the bots have interacted with the candle it seems

Fixed with #232


Investigate duplicate data

Found in:

87c6bd423f537231d36ffa8ae8c26f91247f3b9f

The following record appears to have a lot of duplicate data, please investigate.
https://orgbook-dev.pathfinder.gov.bc.ca/en/organization/demo.verified_person.registries.ca/VPCLUTCHLULANI

Individual shows duplicated director relationships to:
                'BC0036103',
                'BC0014947',
                'BC0020288',
                'BC0163588',
                'BC0187871',

Relationships are showing multiple times because the individual has multiple relationships with the organization.
For example a separate relationship is displayed when the user is both a DIRECTOR and OFFICER of the corporation.
The information displayed matches the information in the BC Reg database (corp_party table)

Now that you've mentioned that, in conjunction with the info provided in this ticket, https://github.com/bcgov/aries-vcr/issues/489, I can see that.  Without that context it's very confusing.
So it's fairly clear in this section of the page:

But it's not clear at all in this section of the page:

@jljordan42, @swcurran -- FYI - a UX issue that is going onto the backlog.


Document HTTP API usage

I plan to implement file uploading without Fine Uploader.  I will be implementing the upload using ember-cli/jQuery.   I will probably end up reverse-engineering the API by reading the tests and code, but it would be nice to eventually have documentation.

drf-to-s3 implements two separate APIs, one intended for Fine Uploader, and another intended for API clients.
The Fine Uploader interface is pretty well documented, however I'd suggest that you work with the API-client interface instead.
One guy used the API-client version and wrote his own uploader that ran in the browser, so I know that is possible. This test that hits the API-client endpoint is the most succinct. There is also a complete xhr example. The first call gets the signed URI, the second call puts the file onto s3, and the third call tells the server the file has been uploaded.
Agreed that some better documentation explaining the sequence of calls would be useful! Certainly would welcome PRs.


No framerate/FPS limits.

Hi,
is there a way to limit the FPS with a hard limit or using v-sync ?

Hi,
can you elaborate what exactly is the issue?

 High fps is not an issue in itself. Is it just about the scrolling?

It is to me, reasons are not relevant.


profile

Todo: Move to ViewModel, fragment for search. Please check for the rest.

squashing and merging

actually @Kii-26 the primary color was changed to black and white, when resolving the commit you needed to conform to master's colors instead of the outdated ones.

Thanks!! And could you delete #FFFFFF because I just saw there is a duplicate one below.

for name="colorWhite"

for sure. I added it back because I saw that your fragment was using the resource, deleting it will break the xml. That was my mistake, but don't worry about it, we can do that in another PR when cleaning up later.


Add link to original article in ArticleCard

It should already do this

I mean the "Show Original Article" button

Yeah that button works in master and opens the original article in a new tab (I did that last night)


added a guide to optimize queries

this may need to be updated to the new routing paths before merging