Controls are switched on Oculus 2

Hello,
I was just using your basic demo to check how this amazing project is working. I was able to somewhat get around, but for me the controls are switch (left hadn is right, right left). I am currently using an Oculus Quest 2, would be great if you could help out if there is any kind of profile for the different VR sets which I could help out with.

I am observing the exact same problem with Quest 2.

VRNetzer was developed on vive (which has symetrical controllers) we will implement configurations for other headsets in the future. for now, there is a variable in
\VR_Module\Content\data\config.txt
called 'lefthanded' that you can set to true to switch the UI to the other hand.
hope this helps!


Dynamic values for dropdown option?

Is it possible to have dynamic values for a dropdown based on current_user or similar?
i.e.
option :group, :dropdown, -> (user) { user.groups.pluck(:name) } if the options can receive a user as an argument
or
option :group, :dropdown, -> { current_user.groups.pluck(:name) } if the options can be evaluated in the context of a request?

You certainly can, you just need to pass in a lambda to the choices key:
option :group, :dropdown, choices: -> * { current_user.groups.pluck(:name) }

Perfect, thanks!


[NTR] Lamp5 Lhx6 neuron

New term label:
Lamp5 Lhx6 neuron
Parent term:
lamp5 GABAergic cortical interneuron
Definition:
A transcriptomically distinct lamp5 GABAergic cortical interneuron located in the cerebral cortex that expresses Lamp5 and Lhx6. The standard transcriptomic reference data for this cell type can be found on the CellxGene census under the collection: "Transcriptomic cytoarchitecture reveals principles of human neocortex organization", dataset: "Supercluster: CGE-derived interneurons", Author Categories: "CrossArea_cluster", Lamp5 Lhx6.
database_cross_reference:
PMID:34004146
PMID:37824655
PMID:37824669
PMID:36007006
Anatomical location:
neocortex
Synonym (has exact synonym)
Ivy cells
PMID: 36007006
Synonym (has exact synonym)
Lamp5-Lhx6 type
PMID:30382198
@aleixpuigb @dosumis
let me know if it is okay, I will turn it into a PR.
(p.s. in light of the discussion on this ticket, we decided to include the CellxGene collection title, as described in the text definition)

Looks good.  In the absence of a more formal structure for referencing the data, I think it would also be good to add a link to the CellxGene dataset.
We could also potentially add (perhaps at a later date)

NS Forest markers @scheuerm - do we have an ETA for this for CrossArea Subclass terms in Jorstad?
formal link to cluster (defined by taxonomy).  Some more work needed to generate resolvable individuals for these.)

Should we add the CellxGene dataset link in the cell definition itself or in the comments ?


Windows Server 2025 and /gfx results in freeze

When connecting to Windows Server 2025 machines using /gfx the connection intermittently freezes at the login screen.
When this happens, it appears that no more screen updates are sent by the server.
MSTSC and the "Windows App" for macOS both connect fine every time.
The behaviour can be observed using FreeRDP 3.9.0 and current master.

@akallabeth Any news on this? This issue is affecting more and more users each day.

How we can fix this?

@lemonmojo not yet, no indication of what is going on.
@JavierRodger well, analyze the differences on protocol level, maybe freerdp-proxy can help there
but won´t have access the next few weeks.

I started filling out the bug report template and when I ran xfreerdp /u:[USERNAME] /v:[SERVER FQDN] using FreeRDP 2.11.7 everything worked fine with Server 2025.
For those reporting this issue, are you using Remote Desktop Manager? Normally I do and it uses FreeRDP to connect to Windows Servers when you run it from Linux. RDM's connections are freezing for me on Server 2025 with a GUI. If I connect to Server 2025 Core RDM works fine.
If you are using RDM and having this issue, I think we need to submit a bug report to Devolutions about it (the company that makes RDM) and not the FreeRDP folks.
If you're not using RDM, ignore me :)

@TheFiZi interesting point.
maybe some of the newer GFX versions do require something, experimenting with /gfx:mask:0xZZZ might help checking that. (the mask is  a bitmask to only allow versions (from oldest being bit 1 to newest being the highest bit, need to check how many versions there are now)


Remove Java dependency

From the downloads page:

Mac OS X users
The main download of Charles now includes Java 8, so you no longer need to use the alternative download for better SSL support. The alternative download is now strictly for oldies.

Thank you for the contribution. It was merged directly as a99cce37afb6edc8f18bb761d33daefdfd5730c2 to keep commit history cleaner. Your contribution is still credited to you.


Obey pristine success option

Description
This fixes the issue whereby the pristine success option was being ignored
Fixes Related issues
Fixes #680
Checklist

[x] I have read and understand the CONTRIBUTIONS.md file
[x] I have searched for and linked related issues
[ ] I have created test cases to ensure quick resolution of the PR is easier
[x] I am NOT targeting main branch
[x] I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

Thanks @edclements I had the time to copy the change into @dorin-niscu 's plunker and it works so I've merged and added it to the new webpack branch.


Idea: SusStaIn constraint with longitudinal measures

SusStaIn is a cool idea for extracting models from cross-sectional data, but one idea I have is, if my data is longitudinal, I could constrain the possible progression models that are possible?
Can such a feature go into SuStaIn? Does it conceptually make sense?
We have lots of animal longitudinal developmental and interventional data which could be used to test this.

Hi @gdevenyi — This is certainly conceptually possible, but not necessarily straightforward to implement in pySuStaIn.
We have some work (in progress) along these lines, but nothing that's ready yet.
Happy to discuss/collaborate — perhaps you could kickoff the discussion by giving us (POND group) an overview of the kinds of data you have.
If you fancy a(nother!) virtual meeting, we'd be happy to have you give a talk.

perhaps you could kickoff the discussion by giving us (POND group) an overview of the kinds of data you have.

We (CobraLab, PI Mallar Chakravarty) have a number of different datasets either in-progress or complete (numbers are fuzzy for me right now, but they're <200 for humans, and ~50 for mice)
Human
Healthy aging with, T1, T2(0.67mm iso), T1maps, T2star
Alzhimer's Biomarkers, T1, T2(0.67mm iso), T1maps, T2star
High Risk for Psychosis, T1, T2(0.67mm iso), T1maps, 4 longitudinal timepoints over 18 months
Human measures of subcortical, hippocampal volumes, cortical thickness, longitudinal DBM, and quantitative measures therein
Mice (all measures voxel-wise DBM, and whole-brain regional volumes)
Triple-Transgenic Alzheimer Mice, longitudinal evaluation, with WT controls
Triple-Transgenic Alzheimer Mice, longitudinal with diet and exercise interventions, WT controls
Mice with maternal immune activation, longitudinal, WT controls
Mice with THC maternal exposure,  longitudinal, WT controls
Mice model of parkinsons, longitudinal, alpha-syn injection, human alpha-syn gene knock in, WT controls
We've also curated a lot of public human data both longitudinal and cross sectional. We're always thinking about how we might better understand longitudinal data in particular.

Hi @gdevenyi thanks for the interest. We're developing a time-dependent version of the Event-Based Model, called the Temporal Event-Based Model (TEBM), that is designed to use longitudinal data. We have a journal paper about the TEBM in review and will be releasing the accompanying code shortly. If this is of interest in its own right then let us know - we could look at just running a TEBM analysis on your data first. But if you're only interested in subtyping with longitudinal data you'll have a to wait a bit longer for a "Temporal SuStaIn" - we're working on this now. As @noxtoby says, perhaps worth setting up a meeting with our team to discuss in more detail?

Lets sort out a meeting to discuss potential data/collaboration<EMAIL_ADDRESS>&<EMAIL_ADDRESS>please!

Apologies that this seems to have gotten away from us. @gdevenyi — if you fancy meeting, send me and @pawij an email.

Hi @gdevenyi thanks for the interest. We're developing a time-dependent version of the Event-Based Model, called the Temporal Event-Based Model (TEBM), that is designed to use longitudinal data. We have a journal paper about the TEBM in review and will be releasing the accompanying code shortly. If this is of interest in its own right then let us know - we could look at just running a TEBM analysis on your data first. But if you're only interested in subtyping with longitudinal data you'll have a to wait a bit longer for a "Temporal SuStaIn" - we're working on this now. As @noxtoby says, perhaps worth setting up a meeting with our team to discuss in more detail?

Hi, my data is longitudinal. I have read the conference paper of Subtype and stage inference with timescales, and I wonder whether Temporal SuStaIn is public avaliable now?


Add alternative way to open jar file in UG quick start

[ ] Need example picture of opening command terminal for Mac

Replaced images with external links to guide on opening a command terminal.

Could you merge the updated update-ug-for-v1.4 into this branch?

Not sure why so much other commits are being included in this PR.
Could you merge the updated update-ug-for-v1.4 branch into your branch?

merged!


handle JSON.parse errors

Description of the PR
JSON.parse here can fail, you can never trust what users can send, i have an error logger that sends error to a discord channel and everyday I'm flooded with JSON SyntaxErrors coming from this middleware this PR handles it and if parsing fails keep it an empty object to prevent undefined errors.
I would also like to note the gzip part can even fail too if they send invalid gzip but I'm not sure how i should handle that one properly since I'm not experienced with streams.
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

adds try/catch to the JSON.parse call

Semver Classification

[ ] This PR only includes documentation or non-code changes.
[x] This PR fixes a bug and does not change the (intended) framework interface.
[ ] This PR adds methods or properties to the framework interface.
[ ] This PR removes or renames methods or properties in the framework interface.

Errors are already handled, else how are you even logging the error to your discord channel. If bad data is passed, the presses should stop, and the error emitted... Just as the lib currently functions. We should make no assumptions that bad data is no data.
Likewise, I run a copy of this 24/7 with no such errors. The key is this is designed for dashboards, so you should be the one making the api calls through Vue/React/Angular like frontends.
However, this is a transferable piece, you are free to transfer it and edit it for your own needs. But the core middleware is correct as is.


Complete restructure - mother of all PRs

Complete restructure and refactor. this is a monster PR

The command structure now implements the proposal in in the wiki. This means that action verbs are top level commands
the ci, cd, landingzone and launchpad commands are gone
Custom commands now replace ci and ci_tasks directory is replaced with custom_actions
Custom actions can be any external executable, and they are dynamically loaded and extend the rover CLI a bit like plugins, e.g.  See the custom_actions folder for two examples rover linter and rover finder
The operational mode is determined by the presence of either the --config-dir or the --config-file flags, which changes between adhoc or single level mode (without a symphony YAML) and multi-level mode (with a symphony YAML)
All actions are now implemented as via an interface Action with TerraformAction and CustomAction being implemenatons, and each of the terraform actions are separate implementations e.g. PlanAction and ApplyAction.
Actions must implement the Execute(o *Options) which is how they are run.

Can we further isolate config and execute? Something like this:
pkg/landingzone/cobra.go:
func RunFromCLI(cmd *cobra.Command, action Action) *[]Options { ...    return []Options{opt} }
pkg/symphony/cobra.go
func RunFromConfig(cmd *cobra.Command, action landingzone.Action) *[]Options { ... 	if levelName == "" { 		return conf.runAll(action, dryRun)  <-- returns array of Options 	} ... 	return conf.RunLevel(*level, action, dryRun)  <-- returns array of Options
root.go
`var options []Options
if configFile != "" {
options = symphony.RunFromConfig(cmd)
} else {
options = landingzone.RunFromCLI(cmd)
}
for _, optionSet := range options {
_ = action.Execute(optionSet)
}
console.Success("Rover has finished")
os.Exit(0)
`
Then, a test can do the initial bit to build the options array and assert on its contents without running execute. An integration test can go on to run Execute and check the actual resources.


Set Konnect docs to default to no_version: true

Summary
Add no_version: true to all docs under app/konnect/ by default.
This means that you don't need to manually add no_version: true to every single Konnect topic.
Updated Konnect topic metadata

Removed the no_version: true metadata entry from every Konnect topic.
Fixed content-type to be content_type

Reason
To eliminate redundancy and make Konnect doc writing a tiny bit more efficient. If the entire Konnect doc set is unversioned, there should be no reason to have to set this metadata every since time.
Testing
Netlify.
Check that the Konnect docs have no version dropdown and no "old version" banners anywhere.

Remaining broken links are false positives (links to Okta).


Fix apt_key tempfile race condition

The Ruby Tempfile class has a finalizer that removes the file when the
GC runs.  It's not predictible when the GC will run, so you have to
ensure that the instance of the class stays in scope for as long as you
need it.
Unfortunately the tempfile method is returning just the filename of the
temporary file, which means it goes out of scope when that method
returns.  This allows the GC to reap it at any time after return.
In both CI and production environments we've seen this race fail,
causing apt-key add to fail a small (2-3%) amount of the time.
This changes the tempfile and source_to_file methods to return the
underlying Tempfile object, pushing it up into the caller's scope.  Both
of the callers immediately use the object to get its filename and then
open the file, eliminating the race.

This improves the situation, but is still missing something, don't merge.

Ok, this should be good now. Tested by forcing GC right before running the apt-key command and cannot reproduce now.

Could you squash this down into one commit please?

Done

We have a triage tonight, I'll raise it there.

closing this as it is a duplicate of #571

This isn't a duplicate, it's on a different branch.

both are be merged into master though. or is that incorrect ?

No, one is against master, the other is against the 1.8.x branch.

Generally we would apply into master first, then all the changes would be merged into the release branch, prior to the new release going out.

The other PR is against 1.8, the old release of APT. It's unlikely we'll ever release that.

@tphoney Can someone at PL run the integration tests for this and come back to us with the result?

@daenney i will get this into our sprint

@daenney @HelenCampbell @tphoney Here is the acceptance test result from PCCI.
https://ci.voxpupuli.org/buildlogs/puppetlabs+puppetlabs-apt+572+1449817308+PASS

Alright, so everything appears to work. Someone care to merge?

Ran a recheck just in case...
https://ci.voxpupuli.org/buildlogs/puppetlabs+puppetlabs-apt+572+1452115700+PASS


To Do list: interactive list

This pull request introduces the following features:

Methods related to updates
Add event listener to the checkbox (change).
Update items object's value for completed key upon user actions.
Implement a function for the "Clear all completed" button (use filter() method).
Store the updated array of items in local storage,

Please consider my review as I fix the issue about the local storage as instructed by the previous reviewer

Hello reviewer please consider my approval for the project, please help include the local storage error on the display of the clear completed tasks I will implement it but please help me achieve my deadline for project submission


trigger-control: unstable-2023-06-18 -> 1.5.1

Description of changes
Update to latest release.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Not needed anymore, as https://github.com/NixOS/nixpkgs/pull/271340 was merged instead.


Update PlayFramework version in play-acl to 2.6

Because PlayFramework 2.6 was released in June 23 it would be nice to update the version in the play-acl project.
At the same time it is possible to add the same scala versions to the play-acl project as in the scala-acl because PlayFramework 2.6 is also compiled agaings scala 2.12
Here is the corresponsing Pull-Request: #2

@Kitefusion Thank you for contributing and updating the play component to 2.6. I already merged the PR and triggered the release process. It should be available soon.


Angular 4 not working with Shape of Semantic Ui

Hello,
I have a problem with the compatibility with Angular 4 and Semantic ui. I use the module Shape and it works but the design of the transition is different.
I use mdbootstrap too, but even if I remove it it's the same.
Do you know how to make compatible semantic ui with angular 4 ?
Thank you

Hi @fjoalland,
Thank you for posting, but although it’s a valid usage question, we’ve limited GitHub Issues to bug reports and feature requests, keeping the board more manageable for maintainers; see the contributing guidelines for more information on what kind of posts should find themselves into the GitHub Issues board.
To get answers or feedback that might allow you to repost or reopen this issue, please use one of our other support resources:

Gitter chatroom
Official forums
StackOverflow

Although, I think it’d be best to ask around Angular communities first.


 It should only be on access no?

From the docs on the front page:
Notes

The dynamic nodes will of course automatically update whenever at least one of the watched paths is updated.

So I'm pretty sure this is expected.

"By access" is very bad way, because you can have many ui sources that use monkey fields.
But every mutation recalculation is also bad, i think it's can be recalculated on end of transactions (nextTick), or on sync read, if it's not cached.

@markuplab I'm pretty sure there is a system in place that prevents it from needlessly recalculating.

Okay, so let me explain what is the expected behavior of the monkeys:

They should not compute before anything gets them.
If they are gotten a second time, they won't recompute because they cached the computed value the first time.
If a watched path is updated, they will be marked "dirty" and recompute next time they are gotten.

If this is not what you observe, and @tonypee's example seems to pinpoint this exactly, then there is a bug I must fix.

@Yomguithereal it seems that your last point...

If a watched path is updated, they will be marked "dirty" and recompute next time they are gotten.

...is not the case in @tonypee's example. It seems to be recalculated every time a push to the watched path is done.
@tonypee can you provide a repro repo?

If the test case presented by @tonypee is full, no need for a repo. If this is all there is to such example then nothing should be logged to the console. So there indeed seems to be a bug.

Ok. I've pinpointed the source of the bug I think. Patch incoming.

perfect - thanks!

Will need to fix some other things but a 2.2.0 is definitely coming soon.

Closing this then.


[Grid] should have an option to remove padding

I had to use a custom CSS grid for the basic task to create this UI because semantic ui assumes that I need padding and margins in the grid. I'm not sure if it's possible, but I think the grid system should either include a nopadding class/option or not assume that it should add padding. If no option to disable this is present I think the padding should be created by containers/segments, but not the grid itself.
TLDR: Grid shouldn't assume padding, but segments and containers should. Otherwise a class would be nice.

I'm running into the same issue. I have a lot of data with a lot of fields that I want to show, so I thought I'd use Semantic's Grid system to nicely lay it out in a 2-3 row, 4-5 column layout per entry, but the inherent padding/gutter sucks up way too much space. Ideally, I want a row right below the previous row, but instead, it's something like 20-30px further down. I've also tried using segments, but the results weren't much better, and I couldn't figure out how to get rid of borders ("basic" seems to only work with a single "segment" and not "segments").
As it is, I've fallen back to using PureCSS's grid system, which doesn't assume padding.

Same issue here. The grid system assumes static & fixed row paddings for example. If you want to use the grid but provide top & bottom paddings by inner-items instead.
Wouldn't it be nice if you could add .compact to .row and so top & bottom paddings are removed?

+1 .compact for rows
a column equivalent would be nice, too.

For having no margin, you can define @gutterWidth: 0 on collections/grid.variables.
In your case, wouldn't celled grid be the better choice?
With that variation you can define @celledPadding: 0 in the same file.

I needed this as well, and changing a global variable didn't seem like the right solution because I only needed this on certain elements.  So, I made a CSS class to do this.  Here's the outcome: https://pasteboard.co/cAxQiHn5C.png
The first set of columns is the default Semantic UI grid layout.  Below that is my customized row layout.  The goal was to collapse the column padding so each column in the row touched each others edges. (no padding left or right).
To do this, a set of columns must be inside a row.  I added a class called .collapsed to the row, which removes padding from the columns inside it.  Then it adds left/right margin to the row so it sits inline with the rest of the default grid.
Here is my markup:

				<button class="ui button">Follow</button>

@hmaesta and what if you use semantic-ui-react and include semantic-ui-css which is precompiled? There is also a separate concern in semantic-ui-css too regarding the ability to configure via yet additional scripts you have to write or hacking in vendor files. Or as @markcy said: what if you want it only in certain places?

@akomm I agree with you, I had not see from that perspective.

any progress on this?

This is what I use:
config/collections/grid.variables:
@compactGutterWidth: 1rem;
@veryCompactGutterWidth: .5rem;
@compactRowSpacing: 1rem;
@veryCompactRowSpacing: .5rem;

config/collections/grid.overrides:
/*----------------------
    Compact Grid
-----------------------*/

.ui.compact.grid  {
  margin-left: -(@compactGutterWidth / 2);
  margin-right: -(@compactGutterWidth / 2);
  margin-top: -(@compactRowSpacing / 2);
  margin-bottom: -(@compactRowSpacing / 2);
}

.ui.compact.grid > .column:not(.row),
.ui.compact.grid > .row > .column,
.ui.grid > .compact.row > .column {
  padding-left: (@compactGutterWidth / 2);
  padding-right: (@compactGutterWidth / 2);
}

.ui.compact.grid .row + .ui.divider,
.ui.grid .compact.row + .ui.divider {
  margin-left: (@compactGutterWidth / 2);
  margin-right: (@compactGutterWidth / 2);
  margin: (@compactRowSpacing / 2) (@gutterWidth / 2);
}

.ui.compact[class*="vertically divided"].grid > .row:before {
  margin-left: (@compactGutterWidth / 2);
  margin-right: (@compactGutterWidth / 2);
  width: ~"calc(100% - "@compactGutterWidth~")";
}

.ui.compact.grid > .row {
  padding-top: (@compactRowSpacing / 2);
  padding-bottom: (@compactRowSpacing / 2);
}

.ui.compact.grid > .column:not(.row) {
  padding-top: (@compactRowSpacing / 2);
  padding-bottom: (@compactRowSpacing / 2);
}

.ui.compact.grid .column + .ui.vertical.divider {
  height: ~"calc(50% - "(@compactRowSpacing/2)~")";
}

.ui[class*="vertically divided"].grid > .column:not(.row),
.ui[class*="vertically divided"].grid > .row > .column {
  margin-top: (@compactRowSpacing / 2);
  margin-bottom: (@compactRowSpacing / 2);
}

.ui.compact.grid > .row > .red.column,
.ui.compact.grid > .row > .orange.column,
.ui.compact.grid > .row > .yellow.column,
.ui.compact.grid > .row > .olive.column,
.ui.compact.grid > .row > .green.column,
.ui.compact.grid > .row > .teal.column,
.ui.compact.grid > .row > .blue.column,
.ui.compact.grid > .row > .violet.column,
.ui.compact.grid > .row > .purple.column,
.ui.compact.grid > .row > .pink.column,
.ui.compact.grid > .row > .brown.column,
.ui.compact.grid > .row > .grey.column,
.ui.compact.grid > .row > .black.column {
  margin-top: -(@compactRowSpacing / 2);
  margin-bottom: -(@compactRowSpacing / 2);
  padding-top: (@compactRowSpacing / 2);
  padding-bottom: (@compactRowSpacing / 2);
}

/* Tablet Only */
@media only screen and (min-width: @tabletBreakpoint) and (max-width: @largestTabletScreen) {
 .ui.compact.grid > .doubling.row > .column,
  .ui.doubling.grid > .row > .column {
    padding-top: (@compactRowSpacing / 2) !important;
    padding-bottom: (@compactRowSpacing / 2) !important;
  }
}

/* Mobile Only */
@media only screen and (max-width: @largestMobileScreen) {
.ui.compact.grid > .doubling.row > .column,
  .ui.doubling.grid > .row > .column {
    padding-top: (@compactRowSpacing / 2) !important;
    padding-bottom: (@compactRowSpacing / 2) !important;
  }
}

/*----------------------
  Very Compact Grid
-----------------------*/

.ui.very.compact.grid  {
  margin-left: -(@veryCompactGutterWidth / 2);
  margin-right: -(@veryCompactGutterWidth / 2);
  margin-top: -(@veryCompactRowSpacing / 2);
  margin-bottom: -(@veryCompactRowSpacing / 2);
}

.ui.very.compact.grid > .column:not(.row),
.ui.very.compact.grid > .row > .column,
.ui.grid > .very.compact.row > .column {
  padding-left: (@veryCompactGutterWidth / 2);
  padding-right: (@veryCompactGutterWidth / 2);
}

.ui.very.compact.grid .row + .ui.divider,
.ui.grid .very.compact.row + .ui.divider {
  margin-left: (@veryCompactGutterWidth / 2);
  margin-right: (@veryCompactGutterWidth / 2);
  margin: (@veryCompactRowSpacing / 2) (@gutterWidth / 2);
}

.ui.very.compact[class*="vertically divided"].grid > .row:before {
  margin-left: (@veryCompactGutterWidth / 2);
  margin-right: (@veryCompactGutterWidth / 2);
  width: ~"calc(100% - "@veryCompactGutterWidth~")";
}

.ui.very.compact.grid > .row {
  padding-top: (@veryCompactRowSpacing / 2);
  padding-bottom: (@veryCompactRowSpacing / 2);
}

.ui.very.compact.grid > .column:not(.row) {
  padding-top: (@veryCompactRowSpacing / 2);
  padding-bottom: (@veryCompactRowSpacing / 2);
}

.ui.very.compact.grid .column + .ui.vertical.divider {
  height: ~"calc(50% - "(@veryCompactRowSpacing/2)~")";
}

.ui[class*="vertically divided"].grid > .column:not(.row),
.ui[class*="vertically divided"].grid > .row > .column {
  margin-top: (@veryCompactRowSpacing / 2);
  margin-bottom: (@veryCompactRowSpacing / 2);
}

.ui.very.compact.grid > .row > .red.column,
.ui.very.compact.grid > .row > .orange.column,
.ui.very.compact.grid > .row > .yellow.column,
.ui.very.compact.grid > .row > .olive.column,
.ui.very.compact.grid > .row > .green.column,
.ui.very.compact.grid > .row > .teal.column,
.ui.very.compact.grid > .row > .blue.column,
.ui.very.compact.grid > .row > .violet.column,
.ui.very.compact.grid > .row > .purple.column,
.ui.very.compact.grid > .row > .pink.column,
.ui.very.compact.grid > .row > .brown.column,
.ui.very.compact.grid > .row > .grey.column,
.ui.very.compact.grid > .row > .black.column {
  margin-top: -(@veryCompactRowSpacing / 2);
  margin-bottom: -(@veryCompactRowSpacing / 2);
  padding-top: (@veryCompactRowSpacing / 2);
  padding-bottom: (@veryCompactRowSpacing / 2);
}

/* Tablet Only */
@media only screen and (min-width: @tabletBreakpoint) and (max-width: @largestTabletScreen) {
 .ui.very.compact.grid > .doubling.row > .column,
  .ui.doubling.grid > .row > .column {
    padding-top: (@veryCompactRowSpacing / 2) !important;
    padding-bottom: (@veryCompactRowSpacing / 2) !important;
  }
}

/* Mobile Only */
@media only screen and (max-width: @largestMobileScreen) {
.ui.very.compact.grid > .doubling.row > .column,
  .ui.doubling.grid > .row > .column {
    padding-top: (@veryCompactRowSpacing / 2) !important;
    padding-bottom: (@veryCompactRowSpacing / 2) !important;
  }
}

Any new way to make padding = 0?

+1

Any interest in adding compact to Grid?

@petixiuxx my solution was to simply use grid & flex directly. Most flexible and not that hard. Easy to make component that you need. Not like reinventing the wheel ;)

+1, also need this for my project!

@hammy2899 Do you know if we could get this reopened? It seems like a very nice feature, I was surprised it didn't exist already.

@GammaGames I will add it to 2.x milestone, I do have this as a issue for fomantic.

Implemented in https://github.com/fomantic/Fomantic-UI 2.5.0

Is there any update on this? The code @stevenspiel posted works beautifully and can easily be integrated in the source. I'm happy to make it a PR if that helps?

Is there any update on this? The code @stevenspiel posted works beautifully and can easily be integrated in the source. I'm happy to make it a PR if that helps?

I'd like to get this to work as well but haven't figured out how to use theming. I made a config/collections/ folder path and created grid.variables and grid.overrides then added "compact" prop to a <Grid/> element and wasn't able to see a change in the UI and devtools says Warning: Received true for a non-boolean attribute compact.
I know this part is unrelated to this issue but once I have it working I can confirm it would be useful for me to have compact as well.

+1

Is there any update on this? The code @stevenspiel posted works beautifully and can easily be integrated in the source. I'm happy to make it a PR if that helps?

Maybe create the PR to prompt action on this and see what happens?


Fixed/improved e2e tests

Ok, pretty much what we discussed today. Let me know what you think!

I reorganized the temporary directories, now everything gets built into .tmp, i hope thats ok. I want to create a dist or build directory and compile the library automatically when releasing a new version.

Another important change, I am seeing this very often. I introduced this convention:

unit tests are now called as spec - it's an executable specification/documentation of our module
integration tests are now called e2e - we are testing the browser integration of the components

this webdriver error on travis is nasty

Yup, I took a look at it... probably some weird config issue...

Ok seems like chromium is stuck in version 37 on travis https://github.com/travis-ci/travis-ci/issues/3475. Now I installed the latest chrome version and it works fine!

Alright, I rebased. Let me know if you agree on all the changes.

Ok one more thing, the watch and build tasks are not running the integration tests - it is only included in the travis task. However, it can be executed via gulp test:e2e separately. The reason for this, is that I want to have fast linting and automative unit test (maybe we could even use to phantomJS) while developing + an extensive integration test suite.

I also added linting for the test files

:poultry_leg:


Asset Library downloader is less usable with hidden checkboxes

Tested versions

Reproducible in 4.2 or later
Not reproducible in 4.1 or earlier.

System information
Godot v4.3.dev (2efbc6bfb) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; <IP_ADDRESS>13) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
Issue description
Since 4.2 or later, the checkboxes in the asset library import dialog were removed by default.
There is a non-obvious arrow button which opens a second panel with the same files having checkboxes.

This creates a lot of visual noise and makes it more difficult to figure out which files to add.
Here is how it used to look in 4.1.x and earlier:

The UI here is short and to the point. it is easy to see which assets are included.
An aside, but it's unclear to me why the scary red text was added: since the reference project always has files like "project.godot", it seems like a common and normal occurrence and not a reason to make a fuss.
Steps to reproduce

Pick any asset in the store, such as "vrm"
Click Download
The picker window will show up as described, with no obvious way to pick which assets to use.

Minimal reproduction project (MRP)
Editor feature: happens in all projects.

This was added in #81620
The right side previews the installation, which can be moved to another directory, while the left side is the structure of the downloaded addon.


Select filter with more than 10 options returns wrong rows

Hi
If you have a select filter with more than 10 options, the wrong rows are returned. I have created a fiddle that shows this:
https://jsfiddle.net/elmoro666/69z2wepo/66338/
If you select quality1 from the list, all rows with quality1, quality10 and quality 11 are returned. It seems it only checks the leftmost digit for some reason

@elmoro666, sorry for lately reply. actually, the search and filter is all use the String.indexOf to find the match data, so I think this is not a bug, but I can support the eq or like in configuration for user to choose the mode they wanted.
I'll spend some time to implement this feature because there're some people have the same issue or question. Currently, you can custom a select filter for a workaround before I support this feature.
Thanks, let me know if you still have any question :)

@AllenFang Thanks for looking into this. I will try a custom filter in the meantime.

Do you want me to close this one?

let it open, I'll try to support this feature and give you response here.

@AllenFang Would you mind pointing me to an example/docs for implementing custom select-filter logic? This is the closest thing I can find:
https://github.com/AllenFang/react-bootstrap-table/blob/master/examples/js/column-filter/select-filter-programmatically.js

check this, I'll support this feature as soon as possible.

@elmoro666, fixed on v2.8.3, check this and let me know if you still have question. Thanks

Sweet! It works perfectly. Thanks a bunch. I personally think condition = "eq" should be the default. It makes more sense to me than "like". I'm happy anyway

I personally think condition = "eq" should be the default

It's hard to do that, because I always use String.indexOf in the past version, it will be incompatible if I do it.


Test handle python errors

This PR introduces a new test case to verify the behavior of the application when a Python execution error occurs. The test simulates entering faulty code and checks if the appropriate error message is displayed in the output area.

I'm glad to see that you've added tests to your code. The typical approach when adding on to a PR such as your previous one (#85) would be to push your changes to the branch that PR is based on. Since you've instead created a new PR here with both you original change and your test, I'm closing your original PR.

Got it, thank you! I’ll make sure to push changes to the same branch next
time.
On Wed, Nov 6, 2024 at 9:33 AM Jon Craton @.***> wrote:

I'm glad to see that you've added tests to your code. The typical approach
when adding on to a PR such as your previous one (#85
https://github.com/jncraton/ice/pull/85) would be to push your changes
to the branch that PR is based on. Since you've instead created a new PR
here with both you original change and your test, I'm closing your original
PR.
—
Reply to this email directly, view it on GitHub
https://github.com/jncraton/ice/pull/89#issuecomment-2459914245, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BC2CE3P5G5AHCQSXGAWWEY3Z7ISDVAVCNFSM6AAAAABRH6DNWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZHEYTIMRUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


ISPN-11397 Align common dependencies with EAP

Added property for Hibernate 5.1.x and 5.3.x
Removed hardcoded version

https://issues.redhat.com/browse/ISPN-11397

I fixed /etc/hosts to include the hostname since a few tests were failing because of it


[W06H02] Add basic unit tests

Added basic unit test, that check the desired behavior for simple examples. Tests for edge cases will be added later.

Looks good to me ʕ•́ᴥ•̀ʔっ♡


Typo in webcam-head-tracker.cpp

In function eulerToQuaternion(const double* euler, double* q), I'm pretty sure the last line should be q[3] = ...

Yes you are right, thank you very much for spotting and reporting this! It is now fixed.


MudOverlay: Fix two way binding with AutoClose=true

Description
Fixes: https://github.com/MudBlazor/MudBlazor/issues/8501
Before:

After

How Has This Been Tested?
Added new bUnit test.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Any chance that this fix will be released to the v6 version?

It is backported to v6 https://github.com/MudBlazor/MudBlazor/commit/14faf34fe273bd5f000ae1bf693ebfcc700cef2d
but @henon needs to make a release, idk if CI/CD supports that as for now.

It is backported to v6 14faf34 but @henon needs to make a release, idk if CI/CD supports that as for now.

Yes the current actions support releasing v6 or preview v7

v6.20.0 is released

v6.20.0 is released

That was fast, thank you. Tested the fix in my app, and it works!


captureElements() and ignoreElements() should capture/ignore all matching elements

For now it captures / ignores the first one only.

I don't think it should capture/ignore all elements with current API. My proposal is to add some new way to specify that every element matching the selector should be taken into account. For example:
suite.captureElements({every: '.we-need'})
       .ignoreElements({every: '.we-dont-need'})
       .ignoreElements('.we-dont-need-the-first')

@SevInf Ok

/cc @varya

M.b. this should be another thread, but the example above (the chaining) would not work, because every ignoreElements overwrites the previous in the suite.

+1
It is strange that method with name ignoreElements really ignore only one element.

+1

:+1:

+1

+1

Current state of this issue:

[x] ignoreElements
[ ] setCaptureElements


Add XDR types for BeginSponsoringFutureReservesResult, EndSponsoringFutureReservesResult and RevokeSponsorshipResult

This is part of #78

@luishurtado here is it #90


[Bug] Code Analyzer check rule AL0253 cannot recognize key in virtual table

I've created a new page License Permission based on the virtual table License Permission with the following sorting order:
The SourceTableView = SORTING ("Object Type", "Object Number") WHERE ("Object Type" = FILTER (<> TableData));
The Code Analyzer shows me an error that sorting fields should be part of the table keys:

As far as I see, "Object Type","Object Number" is a primary key in the License Permission table:

In my opinion, there should not be such warning in this case.
Additional Info:
AL Langauge: 2.1.69331
Visual Studio Code: 1.30.1
Target Database: D365BC CU 02 26413 (on premises)
The following rules were used:
    "al.codeAnalyzers": [
        "${CodeCop}",
        "${PerTenantExtensionCop}",
        "${AppSourceCop}"

I have just checked on the following version and it seems to be that it still works in the same way:

AL Langauge: 2.1.91153
Visual Studio Code: 1.31.1
Target Database: D365BC SandBox (on cloud)

Hi @OSHK, I just tried using the latest extension from the marketplace and from our master branch and it seems that this issue has been fixed. Please feel free to open a new issue if it still reproduces on the latest versions.


Ignore pyenv python-version file

This file is helpful for local development but does not make much sense to share on a library.

Thanks @allcaps


Scaling shapes/vectors inside smart objects

Right now (2014.2.1), if I scale a smart object with generator, it seems to be taking it as a bitmap and scaling it instead of scaling the underlying shapes or vectors contained within the smart object.
Similar issues: https://github.com/adobe-photoshop/generator-assets/issues/322 and https://github.com/adobe-photoshop/generator-assets/issues/48

internal bug 3909740

@pineapplespatula please review in conjunction with other SO scaling research

Is the Smart Object a PSD? I cannot reproduce this one. @chadrolfs  can you give it a shot

Tried with several different smart objects, seems to be scaling correctly.  Closing.  @hisnameisjimmy please re-open if this is still happening for you with the current version of Photoshop CC.


feat: bump the go module to v3

Fixes: https://github.com/budimanjojo/talhelper/issues/494
The only reason why v3 is created is to somehow fix the mistake I made
when bumping the project to v2. Apparently, having a go project
updated to v2 beyond will need some manual interventions that I didn't
know about.
The consequence is that the go module of this project after v2.0.0 tag
can't be imported from outside of this project because go require v2 to
be a separate module from v0 and v1 (https://go.dev/blog/v2-go-modules).
This commit will just bump the project to v3 because I've made too many
releases in v2 and fixing it will require a lot of headache.

Afaik it actually needs to be in a v3 folder doesn't it?
For the "v3/pkg/" thing to work?

@Ornias1993 This should work too according to @Xe and it did work in my test here locally. This make v3 a completely different module so it should work fine. I'll do more complete check tomorrow before merging. I think the ldflag for the go build might need some changing too.

@Ornias1993 This should work too according to @Xe and it did work in my test here locally. This make v3 a completely different module so it should work fine. I'll do more complete check tomorrow before merging. I think the ldflag for the go build might need some changing too.

But are you also sure that the, now silently failing, uploaded packages are now accepted?
Because that was the actual issue currently...

Checked it, I don't think just adding /v3 to the pkg references will do anything for users trying to import this outside of this module.
Did some testing and it seems to really want to see a v3 module path in that case.


Create .../common/README.md

Create a nice google/cloud/common/README.md that explains library-specific information.

How is this different from #3908?

It's not. I must not have noticed that this issue already existed. The other one has more info, so let's close this one.


[FEATURE] Add ml-commons-dashboards to ml playground

Is your feature request related to a problem?
We are going to release the ml-commons-dashboards plugin in 2.6. It's a OpenSearch Dashboard plugin and provide a machine learning model health dashboard to view the machine learning model responding status in different nodes. We would like to enable this feature in ml playground.
What solution would you like?
Since our plugin is experimental now. We need to add enable flag in the opensearch_dashboards.yml which means add below lines in the config file.
ml_commons_dashboards.enabled: true

Then user should be able to experiment ml-commons-dashboards on playground.
What alternatives have you considered?
N/A
Do you have any additional context?
N/A

This is enabled in the ml.playground.


chore(actions) move build and push image step to be after tests

What this PR does / why we need it:
move the build and push image step in nightly and release actions to be after tests, since the building step on linux/arm64 costs too long.

Which issue this PR fixes:

fixes #2744
Special notes for your reviewer:

affects to current actions: if the integration tests fails, the images for nightly build/release may not be pushed.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

build-push-images runs before tests because the tests in question use that image--the point of these tests is that you have, for example, a manifest that says "use controller image with tag v1.2.3" and that manifest does successfully deploy because tag v1.2.3 does exist and deploys successfully.
You can maybe run the ARM builds after since we're not testing them, but I'm not sure that will work with the multi-arch image system on Docker's side--they may require that you push all of those at once. I'd want to see that building and pushing ARM after does work on a fork/test Docker repo first before merging it here.
That all said, I'd say probably just leave them as-is--the intent of the workflow is that it just starts and probably completes successfully, or it doesn't and alerts you to a failure you need to investigate sometime after. You shouldn't need to wait around for tests to complete as there is no manual step required after them if they succeed, and you have to manually investigate failures regardless no matter how long the process takes.

But currently the test script https://github.com/Kong/kubernetes-ingress-controller/blob/main/hack/e2e/run-tests.sh runs tests in test/integration but not test/e2e. Maybe I missed some points, but the tests in test/integration runs a controller from codebase locally, but not in k8s from a manifest saying "use controller image with tag v1.2.3".
The code for running KIC in integration tests is here: https://github.com/Kong/kubernetes-ingress-controller/blob/24ebeeabf52e138c1b380ca09e1ab4cd904b7976/internal/util/test/controller_manager.go#L79
	// run the controller in the background
	go func() {
		defer os.Remove(kubeconfig.Name())
		fmt.Fprintf(os.Stderr, "INFO: Starting Controller Manager for Cluster %s with Configuration: %+v\n", cluster.Name(), config)
		if err := rootcmd.Run(&config); err != nil {
			panic(err)
		}
	}()

We can see we do not depend on the KIC manifests or images in integration tests.
While in recent nightly builds, the build binary step costs 15~20 minutes, which occupied 30%~40% of the total time of the whole action: https://github.com/Kong/kubernetes-ingress-controller/runs/7553013394?check_suite_focus=true
The longest inner step of the build binary stage is building binary on linux/arm64 platform:
#22 [linux/arm64 builder 9/9] RUN CGO_ENABLED=0 GOOS=linux GOARCH="arm64" GO111MODULE=on go build -a -o manager -ldflags "-s -w -X github.com/kong/kubernetes-ingress-controller/v2/internal/manager/metadata.Release=nightly -X github.com/kong/kubernetes-ingress-controller/v2/internal/manager/metadata.Commit=da51014acde6402b3e3dadd99d466d23d68e6f90 -X github.com/kong/kubernetes-ingress-controller/v2/internal/manager/metadata.Repo=https://github.com/Kong/kubernetes-ingress-controller.git" ./internal/cmd/main.go
#22 DONE 825.6s

We cost 825.6s for building binary on arm64 platform, but 144.1s on amd64. So, we could save 10~15 mins on each release of nightly build if we move building binaries and images on arm64 platform to be parallel.

Hmm, yeah, that is running integration tests. It probably shouldn't as there's not much point (they'll already be run on every merge to main, including the one that happens during releases). It looks like we intended to start using the E2E tests at some point and never did: https://github.com/Kong/kubernetes-ingress-controller/blob/a26c2b3be128b2f21343a2cd8c961f9ea7dd5c0c/hack/e2e/run-tests.sh#L3-L7
We should correct that https://github.com/Kong/kubernetes-ingress-controller/issues/2751 (so yes to the first question)

Is it worth to move the building of images on linux/arm64 to be parallel to save the 10~15 mins in release/nightly build?

IMO it's of limited value for jobs that largely run in the background. Nobody is actively watching the nightly job results; we only care if we get a notification that it failed after completion. Release it informs you if there's a failure earlier, but ideally there just isn't one and you don't care exactly when the tests complete and the job finishes the release.
Since we do want to switch over to E2E tests run against images, that change would need to handle the x86_64 and ARM builds in separate workflow steps, so we can only do that if you can push the architectures of a multi-arch image separately.


[C++][Parquet] Use the same BOOST_ROOT and Boost_NAMESPACE for Thrift

When building Thrift using the ExternalProject facility, we do not pass on the variables for a custom Boost variant. Thus if the user uses a differently flavoured/located Boost, Thrift does not pick it up. As a cause of this, we explicitly build Thrift during the Arrow OS X Wheel build.
Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
Related issues:

[C++] Pass BOOST_ROOT and Boost_NAMESPACE on to Thrift EP (Blocked)

PRs and other links:

GitHub Pull Request #460

Note: This issue was originally created as PARQUET-1262. Please see the migration documentation for further details.

Deepak Majeti / @majetideepak:
Issue resolved by pull request 460
https://github.com/apache/parquet-cpp/pull/460


Adding S3 endpoint for Paris region

Description of changes:
Added one-liner for EU (Paris) S3 endpoint
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for the contribution, the fix has been added to internal codebase and will be part of future revisions!

resolved with latest update.


Debug flags

This PR adds --enable-debug and --enable-sanitizer to configure.ac to make many checks on the library for the github actions.
It depends on PR #168
There are still some issues to fix before it can be merged, but I created the draft so that you know that I am working on it.

All good now! Agressive compiler checks don't give any warning, and we can now easily use the sanitizer to detect many issues at runtime.

@scemama there is a bug at the compilation step:
src/trexio.c: In function ‘trexio_string_of_error_f’:
src/trexio.c:184:16: error: ‘MAX_STRING_LENGTH’ undeclared (first use in this function)
  184 |   if (sizeCp > MAX_STRING_LENGTH) sizeCp = MAX_STRING_LENGTH;
      |                ^~~~~~~~~~~~~~~~~
src/trexio.c:184:16: note: each undeclared identifier is reported only once for each function it appears in

Sorry... it compiles now :-)

@scemama thanks! I ran a few tests through valgrind. The C tests look fine though there is one pthread-related error reported when they are compiled with all debug and sanitizer flags on. No error reported in conventional ./configure build.
However, on the Fortran test I get the following error:
(my valgrind-libtool command is this: libtool --mode=execute valgrind - it's the recommended way to run valgrind for memory leaks)
I guess it's an artifact of the Fortran test modifications from PR #168
~/trexio $ valgrind-libtool ./tests/test_f
==27762== Memcheck, a memory error detector
==27762== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==27762== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==27762== Command: /home/q-posev/trexio/tests/.libs/test_f
==27762==
============================================
         TREXIO VERSION STRING : 2.5.1
         TREXIO MAJOR VERSION  :   2
         TREXIO MINOR VERSION  :   5
============================================
TREXIO_PACKAGE_VERSION : 2.5.1
TREXIO_GIT_HASH        : cd369bd1875a46e7da73457a24a8fad09d915a1e
HAVE_HDF5              : true
HDF5 library version: 1.10.7
 call test_write
 SUCCESS HAS NOT 1
 SUCCESS HAS NOT 2
 SUCCESS HAS NOT 2.1
 SUCCESS HAS NOT 2.2
 SUCCESS HAS NOT 3
 SUCCESS HAS NOT 4
 SUCCESS HAS NOT 5
 SUCCESS HAS NOT 6
 SUCCESS WRITE NUM
 SUCCESS WRITE CHARGE
 SUCCESS WRITE COORD
 SUCCESS WRITE LABEL
 SUCCESS WRITE POINT GROUP
 SUCCESS WRITE BASIS NUM
 SUCCESS WRITE INDEX
 SUCCESS WRITE INDEX TYPE
 SUCCESS WRITE AO NUM
 SUCCESS WRITE MO NUM
 SUCCESS WRITE ENERGY
 SUCCESS WRITE SPIN
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS HAS 1
 SUCCESS HAS 2
 SUCCESS HAS 3
 SUCCESS HAS 4
 SUCCESS HAS 5
 SUCCESS HAS 6
 SUCCESS CLOSE
 call test_read
 SUCCESS READ NUM
 SUCCESS READ CHARGE
 SUCCESS READ COORD
 SUCCESS READ LABEL
 SUCCESS READ INDEX
 SUCCESS READ INDEX TYPE
 SUCCESS READ POINT GROUP
 SUCCESS READ SPARSE DATA
 SUCCESS READ SPARSE DATA EOF
 SUCCESS READ SPARSE SIZE
 SUCCESS GET INT64_NUM
 SUCCESS READ DET LIST
 SUCCESS READ DET NUM
 SUCCESS CONVERT DET LIST
 SUCCESS CONVERT ORB LIST
 call test_read_void
==27762== Conditional jump or move depends on uninitialised value(s)
==27762==    at 0x4C4A981: _gfortran_string_len_trim (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x10D1CE: test_read_void_ (test_f.f90:675)
==27762==    by 0x10FE4B: MAIN__ (test_f.f90:51)
==27762==    by 0x10B72E: main (test_f.f90:2)
==27762==
==27762== Conditional jump or move depends on uninitialised value(s)
==27762==    at 0x4C4A8FD: _gfortran_string_len_trim (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x10D1CE: test_read_void_ (test_f.f90:675)
==27762==    by 0x10FE4B: MAIN__ (test_f.f90:51)
==27762==    by 0x10B72E: main (test_f.f90:2)
==27762==
==27762== Syscall param write(buf) points to uninitialised byte(s)
==27762==    at 0x4DAD887: write (write.c:26)
==27762==    by 0x4C3BED8: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C445B1: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C36E14: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C39E41: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C3A323: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x10D1EA: test_read_void_ (test_f.f90:675)
==27762==    by 0x10FE4B: MAIN__ (test_f.f90:51)
==27762==    by 0x10B72E: main (test_f.f90:2)
==27762==  Address 0x639c798 is 40 bytes inside a block of size 512 alloc'd
==27762==    at 0x4848899: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==27762==    by 0x49E0D88: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C44465: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x4C3B2A1: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x49DF3D1: ??? (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x400647D: call_init.part.0 (dl-init.c:70)
==27762==    by 0x4006567: call_init (dl-init.c:33)
==27762==    by 0x4006567: _dl_init (dl-init.c:117)
==27762==    by 0x40202C9: ??? (in /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2)
==27762==
 Test error message: Error opening file�������G���������
 call test_write('test_write_f.h5', TREXIO_HDF5)
 SUCCESS HAS NOT 1
 SUCCESS HAS NOT 2
 SUCCESS HAS NOT 2.1
 SUCCESS HAS NOT 2.2
 SUCCESS HAS NOT 3
 SUCCESS HAS NOT 4
 SUCCESS HAS NOT 5
 SUCCESS HAS NOT 6
 SUCCESS WRITE NUM
 SUCCESS WRITE CHARGE
 SUCCESS WRITE COORD
 SUCCESS WRITE LABEL
 SUCCESS WRITE POINT GROUP
 SUCCESS WRITE BASIS NUM
 SUCCESS WRITE INDEX
 SUCCESS WRITE INDEX TYPE
 SUCCESS WRITE AO NUM
 SUCCESS WRITE MO NUM
 SUCCESS WRITE ENERGY
 SUCCESS WRITE SPIN
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE SPARSE
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS WRITE DET LIST
 SUCCESS HAS 1
 SUCCESS HAS 2
 SUCCESS HAS 3
 SUCCESS HAS 4
 SUCCESS HAS 5
 SUCCESS HAS 6
 SUCCESS CLOSE
 call test_read('test_write_f2.h5', TREXIO_HDF5)
 SUCCESS READ NUM
 SUCCESS READ CHARGE
 SUCCESS READ COORD
 SUCCESS READ LABEL
 SUCCESS READ INDEX
 SUCCESS READ INDEX TYPE
 SUCCESS READ POINT GROUP
 SUCCESS READ SPARSE DATA
 SUCCESS READ SPARSE DATA EOF
 SUCCESS READ SPARSE SIZE
 SUCCESS GET INT64_NUM
 SUCCESS READ DET LIST
 SUCCESS READ DET NUM
 SUCCESS CONVERT DET LIST
 SUCCESS CONVERT ORB LIST
==27762== Conditional jump or move depends on uninitialised value(s)
==27762==    at 0x4C4A981: _gfortran_string_len_trim (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x10D1CE: test_read_void_ (test_f.f90:675)
==27762==    by 0x10B72E: main (test_f.f90:2)
==27762==
==27762== Conditional jump or move depends on uninitialised value(s)
==27762==    at 0x4C4A8FD: _gfortran_string_len_trim (in /usr/lib/x86_64-linux-gnu/libgfortran.so.5.0.0)
==27762==    by 0x10D1CE: test_read_void_ (test_f.f90:675)
==27762==    by 0x10B72E: main (test_f.f90:2)
==27762==
 Test error message: Error opening file             test_write_f2.dir                                               ��>
==27762==
==27762== HEAP SUMMARY:
==27762==     in use at exit: 1,864 bytes in 3 blocks
==27762==   total heap usage: 7,383 allocs, 7,380 frees, 5,647,684 bytes allocated
==27762==
==27762== LEAK SUMMARY:
==27762==    definitely lost: 0 bytes in 0 blocks
==27762==    indirectly lost: 0 bytes in 0 blocks
==27762==      possibly lost: 0 bytes in 0 blocks
==27762==    still reachable: 1,864 bytes in 3 blocks
==27762==         suppressed: 0 bytes in 0 blocks
==27762== Rerun with --leak-check=full to see details of leaked memory
==27762==
==27762== Use --track-origins=yes to see where uninitialised values come from
==27762== For lists of detected and suppressed errors, rerun with: -s
==27762== ERROR SUMMARY: 6 errors from 5 contexts (suppressed: 0 from 0)

In this statement:
  call trexio_string_of_error(rc, str)
  print *, 'Test error message: ', trim(str)

the string returned by trexio_string_of_error was shorter than the max size of str. The trim function scans it completely, so as str was not initialized (such as str = '') trim looked at uninitialized values.
I fixed it in the tests by initializing str to ''.
But now I am fixing it in the library to avoid expecting initialized string. Wait a minute before merging.

Fixed! You can merge now :-)

Thank you @scemama ! It's interesting that I haven't seen this bug before, I used to run valgrind on the Fortran test too and it was clean. Perhaps I need to add valgrind calls to the CI.

If that's OK with you, I prefer to fix the Python determinant tests first in PR #168 and then merge this PR. Nothing to do on your side, I will update this branch when it's done.
I hope to get some time over Christmas to fix the Python tests.

Perfect!

While I was improving the rust binding, the tests I made for determinants were not working with the text backend on the master branch. This was due to the too small representation of integers in the files, which is fixed in this PR. I think that this fix is an important one, but it breaks backward-compatibility of the text backend. When we merge, we may need to set the version to 3.0.0.

Are you talking about the fix from the PR #168? If yes, then it does not require an update of the major version as the TREXIO API remains unchanged. It is an important bug fix of the determinant IO in the text backend, which can be reflected in the minor version bump, but i am not convinced that the API compatibility is violated.

No, I am talking about the current PR. This particular commit: https://github.com/TREX-CoE/trexio/pull/169/commits/08674345a877d0b4e93bc056edaccd0bc6621e8a
where we have things like this:
-  uint64_t line_length = dims[1]*11UL + 1UL; // 10 digits per int64_t bitfield + 1 space = 11 spots + 1 newline char
+  uint64_t line_length = dims[1]*21UL + 1UL; // 20 digits per int64_t bitfield + 1 space = 11 spots + 1 newline char

You are right that the API is unchanged, maybe we should not change the major version.
But the old text files will not be readable anymore. TREXIO will produce an error, but the produced files are very likely to be wrong anyway....
I think it is a bit urgent to fix this particular bug in the master branch. Maybe we can create another PR with only this commit to merge it quickly. What do you think?
I think that the current PR is also important: when I tried to run the rust interface with the TREXIO of this particular branch, I had many errors detected at runtime that were silent before (some safe functions were not really safe...). It helped me fix some silent bugs in the rust interface! :-)


HVOX is bundled with Karabo

https://github.com/matthieumeo/hvox should be integrated.

hvox has the following dependencies:

numpy
astropy
matplotlib
rascil (prob 1.0.0)
ska-sdp-datamodels
ska-sdp-func-python
healpy
------deps until here are already covered by Karabo------
ducc0 (conda-build)
pycsou (github-repo)

As far as I've seen, pycsou has the following dependencies:

numpy
scipy
dask
matplotlib
pandas
joblib
scikit-image
numba
------deps until here are already covered by Karabo------
pylops (conda build)

The missing conda builds are provided in the [Karabo feedstock] (https://github.com/i4Ds/Karabo-Feedstock/tree/main/.github/workflows).

I don't think we can integrate hvox into Karabo soon. Accidentally I've looked at the main-branch of pycsou (even though I've just described in the post above that they use the last commit of the v2-dev branch). There are a lot of changes there. They've a lot of dependencies in their setup.cfg including gpu-dependencies.  So we have to update the Karabo dependencies. E.g. they also have numpy>1.23 but we have restricted it to 1.22 (Not sure why, @fschramka should know more).
They have gpu-dependencies. To me it seems like they're using cuda-toolkit 12.* but karabo has referencens to cuda-toolkit 11.*. I think this is an issue, but I don't have experience in this field. In addition, I can't find their corresponding conda-build. If I look e.g. at the cupy conda-build, they've their versioning matching with the cuda-toolkit (see here). So just installing the corresponding cupy might solve this, but I'm not sure.
They've torch as dependency. We had a talk about tensorflow which is a transversal dependency of Karabo from tools21cm. Is it a good idea to include it? If yes, which configuration? Not sure about that.

So to conclude, there are a lot of issues to solve and test before we can add hvox to Karabo.

Thanks for the helpful overview. To address at leadt some questions:

It's ok and expected to update our dependencies to newer versions (e.g. numpy)
It's also expected that we'll bundle Tensorflow, Torch, JAX, Keras and others eventually.
GPU dependencies are more dicey. Perhaps we can start with CPU-backends and figure out how to do GPU-accelerated processing later?

I just remember something that update to numpy > 1.22 is a problem, not sure why anymore. As mentioned I think @fschramka knows more.
I can have a look at how we can support GPU-accelerated processing through Karabo. Not yet sure how to approach this but I think I'll figure it out somehow.

Delayed until further notice. Reasons:

#424 has a higher priority
Have to deal with other dependencies first because of reasons described above.


Add web extension support

It would be great if this extension could be installed and used in a browser context. The motivation is to be able to share notebooks with people by simply sharing a URL (assuming that the notebook is publicly available on Github or somewhere else that's accessible from vscode.dev). Additionally, in Zen Mode, VS Code notebooks look pretty approachable:

Currently, the Observable JS extension can't be installed from vscode.dev:

According to the docs: https://code.visualstudio.com/api/extension-guides/web-extensions#web-extension-enablement

VS Code automatically treats an extension as a web extension if:

The extension manifest (package.json) has browser entry point.
The extension manifest has no main entry point and none of the following contribution points: localizations, debuggers, terminal, typescriptServerPlugins.

If an extension wants to provide a debugger or terminal that also work in the web extension host, a browser entry point needs to be defined.

Some VS Code APIs are not available in a browser context so it may require a bit of refactoring, or not!

FYI GitHub Blocks will allow this (in early access):

@GordonSmith Wait, you're blowing my mind right now! I signed up for the beta a while ago and still waiting for access. So it looks like you created some custom blocks, one for Observable notebooks and Data File Preview which renders specific file types (like CSV and Parquet) and uses the Observable runtime to provide table preview, data wrangler, etc., is that correct? This is a game-changer for Github! It seems like Blocks is not intended for editing though, so if you wanted to share a notebook with someone and allow them to edit, they would need to download and install VS Code. If this extension worked in the browser (web extension), then notebooks could be easily edited in the browser.

@gnestor - correct, FWIW the blocks API does support editing, but recreating a functional notebook UI is a bit of work...  Mind you supporting an editable OMD document wouldn't be hard...


Cil visitor

This is a first pass at a port of the CIL visitor used by asli, it is especially good for modifying immutable expressions, with the main advantage being it does not require faking multiple-dispatch or re-defining the recursion tree for every implementation.

Merging as this doesn't impact any existing functionality


Add support for ELK 8.x

Is your feature request related to a problem? Please describe.
Support for ELK version 8.x.
Describe the solution you'd like
Currently, TS (from 1.24) only supports ELK up to version 7.x.
https://clouddocs.f5.com/products/extensions/f5-telemetry-streaming/latest/setting-up-consumer.html#elasticsearch-ref
Describe alternatives you've considered
None.
Additional context
N/A

Did you encounter any specific issues with ELK version 8.x?

We have enabled v8.x in our testing and have not seen any problems so far.


Introduce sha256 security review fixes

Signed-off-by: Andrzej Kurek<EMAIL_ADDRESS>

This PR adds 36 bytes of codesize.


SSH and Git Support

Loving the application. I periodically try to use my iPad as an on the go development machine. I try different IDE's trying to find on that fit and a lot leave much to be desired. I believe you have a winner here. The options, layout and current language support is on par with what I need.
Only thing I would need for my work flow to be complete is ssh and git/scm support. The creator of working copy also has a ssh application now. Might be worth it to reach out and see what kinda of integration options he's be interested in. I know he supports xcallback, and does a at least one text editor linked to under his app integration page. If he's willing, that'll knock out these two feature's. As I have yet to find an application that works better then working copy for git on the phone and I'm already using his ssh app, and am liking it so far.
With apples recent changes for multitasking for iPadOS. I can see a lot more people considering an iPad as a on the go development machine. So having these two features in place, or on the roadmap would help with the success of the application.

This issue seems related to Runestone (the app) rather than the framework of the same name, which this repository contains. There I’ll close the issue.
However, I appreciate the feedback and would love to understand it better. You mention that you’re using both Secure ShellFish and Working Copy but that you need some kind of integration between those apps and Runestone, which other text editors have.
Can I get you to send me an e-mail on Runestone’s support mail and elaborate on the specific integrations and features you’d like to see in Runestone?


Missing Antarctica and Western Sahara flags

There are two missing flags:

Antarctica: Wikipedia
Western Sahara: Wikipedia

Same for these other 3 countries:

AC: Ascension Islands
BQ: Caribbean Netherlands
TA: Tristan da Cunha

Any proposed date for these additions ?


Update FindCommand Message Usage

Describe your changes

Separated long message usage into parts for readability and standardisation

Issue ticket number and link
builds on #115
Checklist before requesting a review

[X] I have performed a self-review of my code.
[X] If it is a core feature, I have added thorough tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines
Coverage Δ
Complexity Δ

...java/seedu/address/logic/commands/FindCommand.java
100.00% <ø> (ø)
8.00 <0.00> (ø)

... and 6 files with indirect coverage changes


[ACR] [Before GA] Update cloud configuration API

Once the service team has added data plane scopes, we will update our authentication_scope kwarg as follows:

Remove authentication_scope kwarg
Add audience (or similarly named) kwarg
audience is an extensible enum, containing the audience strings for known clouds; the user can override with a string if needed
If audience is set, client library will append /.default to audience value to specify the default scope
audience will default to data-plane scope root, which should be common across clouds

In Python, we will also

Initially not support credential_scopes kwarg
If we do evenually support the credential_scopes kwarg, raise an error if this is different from the scope determined from audience

Please see https://github.com/azure/azure-sdk-for-net/issues/21603 for further details.

Duplicate of https://github.com/Azure/azure-sdk-for-python/issues/19610


Feature Request: Sensor Data from Both Chips to Publish at the Same Time.

Firstly, thanks for this implemetation, which I've now been using for a couple of months.
However, I have one remaining issue, which is proving a real pain to resolve.
I have a sensor which is calculated by subtracting one clamp from another.
Unfortunately the clamps in question are on different chips of the board, which don't update at the same time.
This means that it's possible for the calculated sensor to be a negative value. Hopefully the below screen grab from Grafana will clearly show the issue.

Total (CT1) = Incoming cable from the grid
Ground & 1st Floors (CT6) = Cable into primary fuse board
2nd Floor (calculated) = Should be what my separate fuse board, for the 2nd floor, is consuming. Total - Ground & 1st Floors.
I don't have a spare channel (using all 6) to actually clamp on to the cable into the secondary fuse board, which services the second floor.
Is there any way to ensure sensors on both channels/chips publish at the same time please?
Many thanks.

That would be a feature/bug report on the ESPHome software github.

That would be a feature/bug report on the ESPHome software github.

Apologies.
Have now raised this on the ESPHome site.
Here's a link for anyone wanting to track this.
https://github.com/esphome/feature-requests/issues/1087

Apologies.
Have now raised this on the ESPHome site.
Here's a link for anyone wanting to track this.
https://github.com/esphome/feature-requests/issues/1087


Fix detection of sockaddr_conn.sconn_len when srcdir != objdir.

To reproduce -- configure outside your srcdir on a BSD-based platform (including macOS).
E.g.
./bootstrap mkdir obj cd obj ../configure make
This idiom is common in situations where you want to build for more than one architecture (e.g. x86_64 and arm64 on macOS).


Can't import node core modules( fs, os, child_process, etc.) in Angular projects.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

I use node core modules (os, fs, path, child_process,  dgram, etc.)  in my Angular4 project.
I create a new angular4 project:

ng new ngs
cd ngs
ng serve --open
...
webpack: Compiled successfully.

Then I try to import 'os' module in app.component.ts file

import { Component } from '@angular/core';

// to import node core modules
import { CpuInfo } from 'os'

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  title = 'app';

  constructor(cpu:CpuInfo){

  }
}

and then

ng serve --open

Some errors are reported:

ERROR in src/app/app.component.ts(4,25): error TS2307: Cannot find module 'os'.
webpack: Failed to compile.

All the node core modules, such as fs, os, child_process, dgram etc., will give the same error

Cannot find module 'core-module-name'.

Yet, much extenral node modules work well at the same time.
Expected behavior

How to use node core modules( fs, os, child_process, etc.)  in Angular projects?
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular CLI: 1.7.2
Node: 8.9.4
OS: darwin x64
Angular: 5.2.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.7.2
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.1
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.5.3
webpack: 3.11.0

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 8.9.4
- Platform:  Mac

Others:

For example,  import a node core module 'os' and a normal module 'q' at the same time in app.component.ts:

import { Component } from '@angular/core';

// to import node core modules
import { CpuInfo } from 'os'

// to import common node modules
import { when } from 'q';
@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  title = 'app';

  constructor(cpu:CpuInfo){
    when(); // from 'q' module
  }
}

Then

 ng serve --open
...
ERROR in src/app/app.component.ts(4,25): error TS2307: Cannot find module 'os'.
webpack: Failed to compile.

ONLY 'os' reports error: Cannot find module 'os'.
'q' module works well.

Angular applications are web applications and run in a browser environment not a nodejs environment.  As a result, nodejs builtins do not exist in that context.


Matrix4 setScale bugfix

:facepalm:
I made a mistake in https://github.com/CesiumGS/cesium/pull/10124 and the unit test was not good enough to catch it. Fortunately this bug never made it into a release.

Thanks for the pull request @IanLilleyT!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


[Enhancement] Simplify the use of classpath of JNI

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

libhdfs will read environment CLASSPATH, resolve the wild card and set the java.class.path, so we can directly use the feature to avoid hardcoding of java package path
details in jni_helper.c
/**
 * Gets the classpath. Wild card entries are resolved only if the entry ends
 * with "/\*" (backslash to escape commenting) to match against .jar and .JAR.
 * All other wild card entries (eg /path/to/dir/\*foo*) are not resolved,
 * following JAVA default behavior, see:
 * https://docs.oracle.com/javase/8/docs/technotes/tools/unix/classpath.html
 */
static char* getClassPath()
{
    //...
    classpath = getenv("CLASSPATH");
    //...
}

run starrocks_admit_test

run starrocks_admit_test


Close other VSCode editors when opening a new project

Description

Implements this: https://twitter.com/adamwathan/status/1648729947651948545?s=12&t=Y2_GO1BphPAwq8gZKvrVAQ
Screencast

https://user-images.githubusercontent.com/36263538/233831670-29b1a2ef-f919-4e89-bdc8-86abae34381d.mp4
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
For me, it only works every second time I use it, does it maybe require another key combination?

Fixed! I had to change a bit the order but now it works :)


Correct license for Open Data but not available in the list of possible licenses

In my STAC Catalog I've got various Open Data that have a license not belonging to the SPDX License identifier list. Most of them simply have a specific Provider's license (such as the Copernicus ones) which though permits free reuse and download.
At the moment the only option for the STAC license would be "proprietary" which though is a little misleading as concept if we're talking about data which is Open but just doesn't have one of the standard Open licenses listed.
Couldn't there be another word to be used either than various or proprietary? Something like "free" or "opendata" or  "open" or similar.
That would help in particular in web catalogues where the user would right away think that a collection is proprietary and so probably not reusable, which though is not forcedly implied.

We've discussed this in the past, but couldn't come up with a good alternative yet as there's no better registry of licenses. Right now there's no alternative and your best bet is probably various, which is not too bad as that should then be explained with a link with rel type 'license' anyway. Software such as STAC Browser usually don't show the "proprietary" or "various" anyway if a link with rel type license and a title is given. It then shows the title which you can put anything you like.

Could you link to some examples of licenses you are using?
If the licenses are actually commonly used and it is missing from SPDX, I'd propose to try to add it:
https://github.com/spdx/license-list-XML/pulls
If the license is a custom one although it is making the data open, it really is a proprietary license. Proprietary doesn't necessarily mean closed source/data or so, it just means that someone wrote a proprietary/custom license. So STAC is correct here, although it might have been a wiser move to call it "custom" or so.

This is the exactly the case. It is a custom license (which many times isn't even defined anywhere) just saying that data is open. As you mentioned though the word "proprietary" is misleading. In our case we in effect used "proprietary" for these cases, but it just seems strange for the users who see this.
Maybe I could propose to add to the https://github.com/spdx/license-list-XML/pulls list a "generic open data" license so that all that is open data with no specific license could fall there. I know it is a best practice to have a license defined but in many cases projects just produce it and don't care about this step.

In STAC the license currently allows:

various
proprietary
SPDX license key (which is not enforced in the validation)

In OGC API - Records they are using:

other
SPDX license key (which is not enforced in the validation)

In the past we've learned that various and proprietary are not quite what implementors like. Is what Records proposes in https://github.com/opengeospatial/ogcapi-records/pull/236 better? Should we add "other" in STAC 1.1 and deprecae various and proprietary (i.e. to be removed in 2.0)?

This will be resolved by changes proposed in the issue #1232


Is spring cloud alibaba is the second generation of spring cloud?

Some people say that spring cloud abliaba is the second generation of spring cloud, I want to know if this statement is correct?

No, it is spring boot auto configuration for Alibaba specific libraries and services


New package: ReparametrizableDistributions v0.1.0

Registering package: ReparametrizableDistributions
Repository: https://github.com/nsiccha/ReparametrizableDistributions.jl
Created by: @nsiccha
Version: v0.1.0
Commit: c9e96acad54900528225ac9c2752d1e5fdb93367
Reviewed by: @nsiccha
Reference: https://github.com/nsiccha/ReparametrizableDistributions.jl/commit/c9e96acad54900528225ac9c2752d1e5fdb93367#commitcomment-132119055

Please make sure to add some documentation before registering. Currently, the README is empty, and the "Example" in the online documentation shows no code and lacks context.
I would recommend a paragraph in the README to explain the purpose of the package, as well as a minimal but complete usage example. Since registration is intended to make the package available to the wider community, providing information about what the package does and how to use it is essential for it to be useful to others.

"Interesting", that the "you" in "If you want to prevent this pull request from being auto-merged, simply leave a comment." apparently means anyone (contributor?).
In any case, @goerz: I'm not sure which "Example" in the online documentation you refer to that lacks code?
(I've done some changes to the README as requested and added a few words to the example in the meantime).

I'm sorry, somehow this slipped through (I should have unblocked this on Nov 13). In any case, the documentation seems fine now. So please feel free to try re-registering. It should auto-merge this time.

"Interesting", that the "you" in "If you want to prevent this pull request from being auto-merged, simply leave a comment."

Yes, that is by design. The General registry is a community resource. Some issues with new registrations can be flagged by bots, but others (like incomplete documentation) cannot, so anyone can flag these submissions.
Usually, after issues are fixed, the registration should be unblocked for automatic merging. Again, I'm sorry that didn't happen in this case.

@goerz No worries! :)


Note(s)

https://travis-ci.org/ may be used

I have signed in with travis and will also give jetpack a look too.

@phillbarber - Thanks for adding travis! I have added a build status badge on the readme. I think this issue can now be closed. Please comment/re-open if something I have missed something.


Biasfield-corrected image input of the segstats.py

Question/Support Request
Thanks for the implementation of the auto segmentation model! I use it for a mix of healthy subjects and patients with degenerative disease and it works pretty well!  I have some question regarding the input images to the segstats.py in FastSurferCNN.

According to the help function, a " Biasfield-corrected image in the same image space as segmentation" is required to calculate the summary statistics. Is this the same image as the conform_image of the output of run_prediction.py? I assume it it not. Because I did not see any biased correction step in the run_prediction script. If not, what is the best way to get that biased corrected image?
If I understand the output aseg.stats correctly, all the columns with prefix "norm"(like normMean, etc) are derived from the biasfield-corrected images while the Nvoxels  is directly derived from the segmentation results. That means, if I only need the Nvoxels, I don't have to use the Biasfield-corrected images, right?

Hi, if you use our most recent release even if you run only the segmentation module, the orig_nu.mgzand stats should be created for you automatically. In earlier versions this only happened in the surface module.

the conform step alone, does not bias correct. We recommend you use the newest release version (see above).
principally you are right, but we also have a column with partial volume corrected values, this is not purely the voxel count, as some voxels are not fully inside or outside a structure. The partial volume correction needs the bias corrected image to compute the values. They will be more accurate than the simple voxel count.

Just to add to this answer.
Since FastSurfer 2.2, the run_fastsurfer.sh script includes a bias-field correction step in the segmentation pipeline (previously it was part of the surface pipeline). As Martin has said, this is the mri/orig_nu.mgz file. If you want to generate this file yourself, you could use the recon_surf/N4_bias_correct.py script, but generally, we would recommend, you just use the run_fastsurfer.sh script. There, is also a call to segstats.py in run_fastsurfer.sh in the segmentation pipeline, which generates this stats file stats/aseg+DKT.stats.

Hi, if you use our most recent release even if you run only the segmentation module, the orig_nu.mgzand stats should be created for you automatically. In earlier versions this only happened in the surface module.

the conform step alone, does not bias correct. We recommend you use the newest release version (see above).
principally you are right, but we also have a column with partial volume corrected values, this is not purely the voxel count, as some voxels are not fully inside or outside a structure. The partial volume correction needs the bias corrected image to compute the values. They will be more accurate than the simple voxel count.

Thanks! That answers my question!


Service workers

Is it possible to use it at service workers? There are no 'addEventListener' and window object

Hey @GarageInc -- thank you for the inquiry! Service workers are not currently possible, as this library makes use of window to load a user's third-party scripts ("device mode"), and, in some limited places, such as to get query string data or store queued method calls (if you're a snippet user). We will be evaluating the possibility of supporting service worker in the future for a limited feature set in the coming year.


URL is set to "localhost"

In my acceptance.suite.yml I have the following config:
class_name: AcceptanceTester
modules:
    enabled: [PhpBrowser, AcceptanceHelper, Laravel5]
    config:
        PhpBrowser:
            url: 'http://mysite.dev'

If I don't use the Laravel5 module the URL is correctly set to http://mysite.dev and tests work. However once I enable the Laravel5 module all requests seem to be from localhost, which means my tests fail on redirect because I am using subdomains (Maximum function nesting level of '200' reached, aborting!). My url in app/config.php is set correctly.
Just to clarify my debug output looks like:
[Response] 200
[Page] http://localhost/login
[Cookies] []
[Headers] {...}

When it should look like:
[Response] 200
[Page] http://test.mysite.dev/login
[Cookies] []
[Headers] {...}

Any ideas why it would be overriding the PhpBrowser config?

The PhpBrowser module interacts with your application with curl while the Laravel 5 module uses Codeception's InnerBrowser. You should choose which approach you want to use for your tests, but you should not use both.

Ah ok. I've never heard of InnerBrowser. Is there some documentation for it?

You can find the class at https://github.com/Codeception/Codeception/blob/2.0/src/Codeception/Lib/InnerBrowser.php. It uses Symfony's DomCrawler and BrowserKit for interacting with an application.


Test request: Hetzner AX51

ada0 and ada1
2 x 8 TB SATA Enterprise HDD
https://www.hetzner.com/dedicated-rootserver/ax51

Closing this, no longer available as a product


Appstudio update test-component-pac-mrxc

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-mrxc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
20 seconds
init

✅ Succeeded
32 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
34 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
16 seconds
show-sbom

✅ Succeeded
17 seconds
show-summary

Pipelines as Code CI/test-component-pac-mrxc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
33 seconds
build-container

✅ Succeeded
26 seconds
deprecated-base-image-check

✅ Succeeded
28 seconds
inspect-image

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary


feat: support proxying close method to all clients

The close method of the grpc.Client does not correctly get proxied to each individual gRPC client that we are creating in the composite client. This PR updates the interface/proxy logic to correctly proxy the close method to a function that will close all known clients.

@samkim got another one for you 😄 pretty minor though!

Will publish a patch release


add a test that must fail

Any updates?

No, it's just a PR that intend to understand our unittest. Close it now.


missing pytest.mark.skipif on TestSSLConnectionURLParsing

Version: 5.1.0b7
Platform: Python 3.12 / MacOS Sonoma in M1 Arm Device
Description:
There is an inconsistent skip on testing if SSL isn't installed between the connection pool in the sync and async tests.
These tests are otherwise identical (pointing to my suggested issue #25)
sync:
https://github.com/valkey-io/valkey-py/blob/d116aa6efa03877a0c37598139a556554ad47c13/tests/test_connection_pool.py#L456C1-L494C1
async:
https://github.com/valkey-io/valkey-py/blob/d116aa6efa03877a0c37598139a556554ad47c13/tests/test_asyncio/test_connection_pool.py#L543-L572
Unless there is a reason the async client should not skip the tests (or a particular reason the synchronous one should) is it not better to make the tests test the same thing the same way (or implement #25 and condense that logic into a module that both versions use which would eliminate the need for testing in both areas.

Yes, the skipif should be added to the async test as well, but I'd keep the 2 tests separate. The tests should not know/care if valkey and valkey.asyncio share some implementation detail or not.


Datadog: restore "resource.name" tag

These changes restore the Dataodog tracer's ability to set the Datadog notion of span "resource name" by setting a special tag named "resource.name".
This was previously possible with the OpenTracing-based implementation of Datadog tracing, but I removed the capability when I moved Envoy's Datadog extension away from OpenTracing.
It turns out that customers were using this feature. This pull request restores it.
Please consider backporting this revision as a bug fix once it is merged.
Testing
I modified some existing unit tests.
Also, by applying the patch below, I used the Datadog "demo" with a local build of Envoy to verify that a request_header-based custom tag for the tag "resource.name" really does result in a change to the resource name:
diff --git a/source/extensions/tracers/datadog/demo/envoy.yaml b/source/extensions/tracers/datadog/demo/envoy.yaml
index 839ba18aac..305c76059f 100644
--- a/source/extensions/tracers/datadog/demo/envoy.yaml
+++ b/source/extensions/tracers/datadog/demo/envoy.yaml
@@ -18,6 +18,13 @@ static_resources:
                 "@type": type.googleapis.com/envoy.config.trace.v3.DatadogConfig
                 collector_cluster: datadog_agent
                 service_name: envoy-demo
+            custom_tags:
+            - tag: "header.thing"
+              request_header:
+                name: "x-thing"
+            - tag: "resource.name"
+              request_header:
+                name: "x-datadog-resource"
           access_log:
           - name: envoy.access_loggers.file
             typed_config:

Commit Message: restore ability to set resource name by tag in Datadog tracer
Additional Description:
Risk Level: low
Testing: See modified unit tests. Also performed manual integration testing with the Datadog "demo."
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Thanks @mattklein123!

Please consider backporting this revision as a bug fix once it is merged.

Can we get this tagged for review?

Hi @mattklein123 and @dgoffredo. Thanks for picking this PR up. We observed that it was not part of the recent 1.28 release. Is there a plan to backport this fix into previous Envoy versions?

I would like for this PR to be reviewed for backporting as a bug fix onto v1.27 and v1.28.  @mattklein123, how do I start that process?


support subtraction of interior "lakes"

can you add support for the subtraction of interior "lakes" or "no-go zones"

what is your desired output? can you draw it into the image?

I recreated your example but added the black rectangle (see the last post). I would want the largest possible inscribed rectangle that is not overlapping any interior polygons (like the black rectangle in the example). Is the image in the last post visible to you?

So the red lir in your image is the desired result? In my opinion this should also be the output of lir.lir()

so lir.lir() accepts multiple polygon np arrays to create the mask? can you show me how?

ahh now I've got it you are working with contours, are you? Are you dependent on the performance boost? If you only have the binary grid as input the result should be the red lir as in your image.

yes, I am. I'm working in millimeter precision on room scale, so that would be a grid of like 5000x8000mm. and I'm doing 10 rooms at once. so a binary grid is probably not an option

so green should be the input contour and purple the "splitter"

I can't tell right away how the contour can be split in a suitable way. Feel free to work on it and I'm open to discuss changes based on an appropriate workflow/algorithm you found

maybe use cv.fillPoly on each individual lake but with a zeroes mask of the bbox of the outer/main polygon, add all arrays of the lakes together, and then subtract the resulting array from the main mask array making all 255 cells that overlap with a lake zero again. does that make sense?

I guess this won't work for the contours approach, only for a "simple" binary grid

correct me if I'm wrong but create_mask_from_polygon() converts the polygon contours to a binary grid in the background right?

yes it does

so why wouldn't it work for a contours approach?

ah okay did not know that, would you be able to implement this and raise an exception if this occurs?
there might be a bit of pseudo-code in there, but do you think this would work?
def create_mask_from_polygon(polygon, lakes=None):
    assert polygon.shape[0] == 1
    assert polygon.shape[1] > 2
    assert polygon.shape[2] == 2
    check_for_opencv()
    bbox = cv.boundingRect(polygon)
    mask = np.zeros([bbox[3], bbox[2]], dtype=np.uint8)
    zero_centered_x = polygon[:, :, 0] - bbox[0]
    zero_centered_y = polygon[:, :, 1] - bbox[1]
    polygon = np.dstack((zero_centered_x, zero_centered_y))
    main_mask = cv.fillPoly(mask, polygon, 255)

    if lakes:
        submasks = []
        for i in lakes:
            sub_mask = cv.fillPoly(mask, i, 255)
            submasks.append(sub_mask)

        for i in submasks:
            np.subtract(main_mask, i)
    else:

    origin = bbox[0:2]
    return origin, main_mask

ah okay did not know that, would you be able to implement this and raise an exception if this occurs?

There is no way to detect if the wrong lir is detected. I will just get the biggest lir touching the contour and considering the lakes (yellow):

I suggest that you prepare the mask as you showed in your pseudo code. Then look if you get the desired results and what the timings are. If it works we might consider adding the lake functionality using a PR :)

another challenge is that you want to iterate over the same mask to get 3 lirs. In your case n lakes + 1

not per definition lakes+1 but yea i want to divide the rooms in large rectangles. for example, an L-shaped room would have 2 rectangles but no lakes. I want the algorithm to stop once the area of the new rectangles are below a certain percentage of the area of the biggest rectangle or if they are below 1m2 or something. but yea that is for later


[PORT] Update design-tokens package to new package (post brand-evolution)

Update design-tokens package to new package (post brand-evolution)

Closing as not planned this quarter


Add custom glob to structure dir

Description
Allows specifying a custom glob for StructureDirFactory
Developers certificate of origin

[X] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

@mariacm12 can you review here?

Looks good! This would be to use StructureDirFactory instead of MetaStructureFactory?

This just might be useful if you want to pull structures of a certain type out of the StructureDir eg only minimized_blah.pdb. But I realise now that as you are only minimizing there will only ever be the PDB files you want. Regardless I think this could be useful.