Automatic exporting seems to have broken since last Zotero release

Zotero version:
5.0.97-beta.43+c5d89f6d0
BBT version:
Aug. 31
Support log ID:
Exporter used:
Better BibTex
Expected behavior:
After checking exportOptions.keepUpdated any changes to my file will automatically be reexported.
Actual behavior:
I am finding that I have to manually reexport every time. This used to work, before the Aug. 31 Zotero update.

If you don't submit a support log, I can't possibly help you. Please turn on debug logging, reproduce the problem by changing an item that you expected to trigger an auto-update, and submit a log, as per the instructions under point 2.
I'm trying to phrase the request in the template as politely as I can, and the reminder by the bot is as polite as I can make it, but the support log really isn't optional. Auto-export obviously isn't broken for everyone, as it works for me, and it's tested at least once a day by the automated tests. Without a support log, I would have to resort to guessing, and that's really not a great use of either of our time.

If you don't submit a support log, I have no choice but to close this issue. Without the support log I cannot do anything. It's just a few clicks.

We’ll, you’re assuming I know how to do that in the context of this ticket.
I think I figure it out: 5JVB6SBF-euc.
BTW, the problem seems to have resolved itself when I enabled debugging. Does bebugging have to be on for the out export to work. Once I turned it on the option string change to Keep updated. It wasn’t that before. What are the implications of have the debugging on?
Michael J. Becker
CEO
Identity Praxis, Inc.
@.***
M: +1-408-242-5733
https://www.linkedin.com/in/privacyshaman/
Check my availability & schedule meeting with me: 30 MIN or 60 MIN
On Sep 9, 2021, 11:01 AM -0700, Emiliano Heyns @.' via Pocket Geek ID @.>, wrote:

If you don't submit a support log, I have no choice but to close this issue. Without the support log I cannot do anything. It's just a few clicks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I don't dismiss the possibility that the instructions are unclear or incomplete - suggestions on how to improve them very much welcome. Given how familiar I'm with BBT, it's hard for me to know what others don't understand about it.
Debugging on or off should have zero influence on this problem - does the problem return of debugging is off? That would be annoying, but even with logging off, a support log might still have captured the error. With debugging off, zotero doesn't log nothing, just substantially less.
I'll look at the log when I'm back at my computer, maybe there's still something there, but of the problem doesn't occur before you submit a log, it's not very likely.

thanks. :) seems to be ok now. I’ll let you know if it returns. Can’t tell if debugging is off or on right now, as there is no clear “disable” state.
Thanks. You can close ticket for now.
Michael J. Becker
CEO
Identity Praxis, Inc.
@.***
M: +1-408-242-5733
https://www.linkedin.com/in/privacyshaman/
Check my availability & schedule meeting with me: 30 MIN or 60 MIN
On Sep 9, 2021, 12:14 PM -0700, Emiliano Heyns @.' via Pocket Geek ID @.>, wrote:

I don't dismiss the possibility that the instructions are unclear or incomplete - suggestions on how to improve them very much welcome. Given how familiar I'm with BBT, it's hard for me to know what others don't understand about it.
Debugging on or off should have zero influence on this problem - does the problem return of debugging is off? That would be annoying, but even with logging off, a support log might still have captured the error. With debugging off, zotero doesn't log nothing, just substantially less.
I'll look at the log when I'm back at my computer, maybe there's still something there, but of the problem doesn't occur before you submit a log, it's not very likely.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Zotero automatically turns off logging at start unless you have enabled "Start with debug logging", and with the next start after that, it's off again.


Cannot access request within mutation

I am creating a new model within a mutation. I would like to set the model's created_by field to point to the current user (using request.user). However, AFAIK the request object is not available within a mutation's mutate_and_get_payload() method.
Note: It is entirely possible that I'm going about this the wrong way, I'm still new to GraphQL.

One way to do this is to subclass GraphQLView and override get_root_value to return request.user.  Which would put it into info.root_value in your resolver.
I plan on making the entire request object available in info though. Should land later today.

class CurrentUserRootValueGraphQLView(GraphQLView):
    def get_root_value(self, request):
        return request.user

graphql_view = csrf_exempt(CurrentUserRootValueGraphQLView.as_view(
    schema=schema
))

That is brilliant, thanks very much!


Korean translation error in parameter description of setMag()

Language
Korean
What improvement are you suggesting?
Number: The new length for this vector
숫자: 벡터의 새로운 크리 -> 숫자: 벡터의 새로운 크기
("크리" is thought to be a typo.)
Would you like to work on the issue?
yes, i would like to work on this issue.

@SungWonStuDio You can go ahead with a fix. The file and line you need to fix is here. Let me know if you need any help. Thanks!


Merge build infrastructure changes from rel/2.0.3

This merges all of the runtime store and metapackage refactoring from rel/2.0.3 back to dev.
Changes:

Add external dependency analysis and checks
Add modules/Templating
Add targets to build

runtime store
debian/rpm installers
LZMA package archive
the .All metapackage

cc @ryanbrandenburg

Hmm, this fails on EF because the benchmarks project builds against RTM packages.
  Repos are inconsistent. The following projects have PackageReferences that should be updated
    - EFCore.sln
        - EFCore.Benchmarks.csproj
           + Microsoft.Extensions.Configuration.Json/{2.0.0 => 2.1.0-preview1-t0055f1abe}
           + Microsoft.Extensions.Configuration.EnvironmentVariables/{2.0.0 => 2.1.0-preview1-t0055f1abe}
           + Microsoft.Extensions.Configuration.Json/{1.1.2 => 2.1.0-preview1-t0055f1abe}
           + Microsoft.Extensions.Configuration.EnvironmentVariables/{1.1.2 => 2.1.0-preview1-t0055f1abe}
           + Microsoft.Extensions.Configuration.Json/{2.0.0 => 2.1.0-preview1-t0055f1abe}
           + Microsoft.Extensions.Configuration.EnvironmentVariables/{2.0.0 => 2.1.0-preview1-t0055f1abe}

@smitpatel - how important is that EF Core builds EFCore.Benchmarks as a part of the regular universe build? EF Core already has the EFCore.Benchmarks.sln

EFCore.Benchmarks are not supposed to be part of Universe.
https://github.com/aspnet/EntityFrameworkCore/blob/c81d716cc27013d6ff5ca3eb5fa60cdbaa782bd3/build/repo.props#L13
According to line above it is excluded from build.cmd. I am not sure why it is being built in universe.

EFCore.Benchmarks.sln is ignored. The problem is that EFCore.sln includes EFCore.Benchmarks.csproj

Ah, got the point. Can this be exclusion?

Re: EF. I think the best approach for now is to disable that consistency check. I plan to alter it anyways to account for the growing complexity of PCP, package versions, auto updates, etc.


Docs: update logo link to homepage and add redirect to intro page

This PR proposes the removal of an intermediate page (/docs) from the documentation.

@burnash This is almost good to go, except /docs errors when it should probably redirect to docs/intro for now. We could add netlify redirect for this, but I think there should be a way to do it with docusarus (so running it locally provides the same experience). Maybe @rudolfix has an idea?

@TyDunn Thanks for bringing this up. I'm getting the same error too.
I was thinking that this PR would be a temporary fix. If that's the case, adding a redirect as you suggested would be the easiest solution. We could also explore a client-side redirect if needed.

@burnash Good point. The netlify redirect is good enough for now. Thanks for pulling this PR together!


client-side throttling, not priority and fainess

Describe what you are trying to do

every command in k8s gets this annoying message any suggestions on how to eliminate it.

Please provide more information for this issue, such as:

which version of Antrea are you using?
what makes you think this issue is related to Antrea?
what are the exact log messages you are seeing and which component is logging them?
do you observe these logs at specific times (e.g. just after deploying Antrea to the cluster) or always?


set papersize special for lualatex/xelatex

https://tex.stackexchange.com/a/338887

@MartinScharrer is there anything else this small patch needs?


[Design] Script Tag Helper

This is the implementation suggestion for ScriptTagHelper/Fallback.
I did yet go and clean it up 100%, but it does include functional and unit tests.
I'm also testing the logging, and it was useful to flush out issues with the code. If you guys want I can make the private Logger class a Logger that can be reused with other tag helpers.
Didn't yet try it in a browser, but wanted to get it out for a quick review earlier rather than later.
Resolves #1576
CC @DamianEdwards @NTaylorMullen

:watch: will look more at tests/smaller pieces when ready/out of design. Aside from comments design looks pretty good though.

updated

:watch:

Looks good 2 me :shipit:

Merged https://github.com/aspnet/Mvc/commit/e94cec51fa122048aaf4fe0f510db7b1aba01be0


unified ServicePrincipalProfile interface between vlab and versioned API

unified ServicePrincipalProfile interface between vlab and versioned API

This change is

@dmitsh  I still see references to "ServiceClientID" in some of the examples like in the "scale up" folder.  Also, I see it in a few template files (example: \acs-engine\parts\kubernetesagentresourcesvmas.t )
Do those need to be updated as well?


Refactor Dashboard Activity

I have added following things

Refactor Dashboard Activity and  move to ui package
Navigation menu selected only for fragments not for dialog
move all drawer menu title string to string.xml
change actionbar title on click navigation menu item
On logout app was finishing but now it is moving to login activity.

@therajanmaurya @ianwdunlop  Please review it.

@sagar15795 Make the above changes.


Prevent duplicate IPT registrations

Publishers often register an IPT, take it offline, and then register a brand new IPT. Therefore there are a lot of duplicate or dead IPT registrations in the GBIF Registry.
Only in rare cases does an organisation need to host more than one IPT. Therefore to prevent duplicate IPT registrations, the IPT should add the following safeguards:

Check if the hosting organisation has already registered an IPT

If multiple IPTs per organisation are NOT allowed, the administrator can choose to update their existing registration (using the organisation and IPT passwords for example).
If multiple IPTs per organisation ARE allowed, a check should ensure it has a different URL from its other IPTs

Note: to add these safeguards requires use of the new GBIF web services (see issue #1021).

Having this may cause confusion and possible mix-ups, and cases are quite rare so it's easier just to remove dead/duplicate installation. Closing after internal discussion.


Commit docs to branch on developer site build

@sdesai CC @ktrott
Context: for the new Falcor site, the docs for each site version will be pulled in from the corresponding branch in this repo (e.g. once 1.x is master, site version 1.x will get docs from master and version 0.x from this repo's 0.x branch).
I left the jsdocs output the same because the new site can consume it as-is, and the part that commits to gh-pages directly doesn't need to be removed until the new site is launched.
This looked to me like the best place to commit the docs for the branch on a travis build, but please let me know if there's somewhere better and I'm happy to help make the changes.
Thanks!

Hey @nicolasartman merged this in. Will you be letting us know when it's ready to integrate with the gh-pages deployment?


keyword arguments with special names

If you make the following function:
# __pragma__('kwargs')
def build_element(tag, **attributes):
    element = document.createElement(tag)

    for key, value in attributes.items():
        setattr(element, key, value)

    return element
# __pragma__('nokwargs')

It mostly works as expected, except if any of the kwargs you pass are handled in a special way by transcrypt. For example, if you then do the following:
pwinput = build_element('input', type='password')

This code fails to set any "type" attribute on the element. The current fix in my code is to instead do the following:
pwinput = build_element('input', js_type='password')

This then gets converted to simply "type" in the converted code, and works as I need.

The 'js_type' default alias was meant to be able to generate 'type' without clashing with the name of the builtin Python 'type' metaclass. So the way you're using it is entirely appropriate.
I've thought about this limitation for quite some time, and this solution was the best I could come up with, without necessitating a level of program semantics understanding by Transcrypt that I considered out of reach.
This is by far not the only case where the alias mechanism is a life saver, as you can see by the list of default aliases. For readers of this issue that (as opposed to @Levtastic) have not yet located it in compiler.py or in the docs:
http://www.transcrypt.org/docs/html/special_facilities.html#pragma-alias.
By the way, if anyone runs into other name clashes, you can define aliases your self.


CTRL+D keyboard shortcut not working on Windows

Does this issue occur when all extensions are disabled?: YES
Version: 1.85.1 (system setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Real Issue:

CTRL + D records as "ctrl" in Keyboard Shortcuts
CTRL + F records as "ctrl+f" in Keyboard Shortcuts

Steps to Reproduce:

In Windows, open a new file in VSCode with the text 1 1 1 1
Highlight one of the '1'"s and press CTRL and D key at the same time
Nothing happens

Extra:
No issues with Linux version of VSCode

Oh wow, CTRL + D doesn't even record properly in Keyboard Shortcuts
it records as "ctrl"
CTRL + F records as "ctrl+f"

Very strange...issue doesn't happen in a Windows Sandbox with VSCode installed in it

Looks like some software intercept this shortcut before VS Code editor can handle it. e.g. Video driver soft stole Ctrl +Alt+arrows IIRC
Try to check other tools running in background

@IllusionMH not saying it's related at all, but I didn't remember this issue happening before I installed the new Microsoft Teams (work or school) app

Mine got hijacked by Webex client. Check your system tray for running applications that might be using the same shortcut

Mine got hijacked by Webex client. Check your system tray for running applications that might be using the same shortcut

That's most likely it, then :(

Why are the apps suddenly intercepting the shortcuts?
I have a similar but more generic shortcut problem, they randomly don't work and I suspect it could be due to 1.85.1, see https://github.com/coder/code-server/discussions/6601

the command line intercept too
a lot of request make it happened like server 500 error vscode-gith-chromium ext

I hate WebEx
"Decline Call"     - CTRL+D             - Global yes
Removing the shortcut and saving fixed this for me

Related on Stack Overflow: Editor doesn't detect ctrl+d


How can I tell this to remove obsolete text that has been removed?

Sometimes our translators ask for context, so we add it, but this generates a new string and leaves the old one around.   How do I tell it to remove obsolete?

It was removing them but it looks like I was using the same text in multiple places so it was sticking around, I added context to all of the strings now


Add android development resource.

Description
I want to add android development resource.
Screenshots
No response
Additional information
No response

@siddhant-khisty can u please assign me this issue

Please mention what resource would you like to add

Please mention what resource would you like to add

I would love to add Kotlin resource by freecodecamp.

Please open a PR and link this issue there as well


Warning message when bundling (4.2 branch)

prototype-rails at /Users/murphy/.rvm/gems/ruby-2.1.5@schatten/bundler/gems/prototype-rails-d7c004222485 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["README"] are not files
Using prototype-rails 4.0.0 from git://github.com/rails/prototype-rails.git (at 4.2)

I guess README is now named README.md?

+1 on this one, there is a PR for it https://github.com/rails/prototype-rails/pull/35

Thanks! :)


Some weird error about navigation.

@Kureev @alinz

@piyushchauhan2011 We need a little bit more info, like a sample code. I've seen this error showing up when one animation layout try to interrupt and execute while another is in progress.

I just updated my version to react-native 0.8.0 release and this error no longer exist, everything works perfectly :+1: @Kureev @alinz


DateDifference::operator== doesn't compare datetime::day values

Describe the bug
DateDifference::operator== fails to compare datetime::day values
bool operator==(const DateDifference^ dd) const
{
    return year == dd->year && month == dd->month && week == dd->week && day == day;
}

Requested Assignment
If possible, I would like to fix this.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Add deeplinking to Swagger UI

This will update the Swagger UI URL when clicking on an endpoint so the URL can more easily be shared.

Great! Thank you! :tada: :cake:

this should be merged again, I dont know why but it got skipped, probably once I refactored get_swagger_ui_html

Thanks @euri10 . Fixed here: https://github.com/tiangolo/fastapi/pull/350


refactor(parser): rename vars

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4565  👈
#4564
#4563
#4562
#4561
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Feature: Add possibility to configure wait timeout between flyway.connectRetries

Which version and edition of Flyway are you using?
6.4.4
If this is not the latest version, can you reproduce the issue with the latest one as well?
Yes.
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

Java API via Spring Boot Integration

Which database are you using (type & version)?

Postgres 12.3

Which operating system are you using?

Podman based adoptopenjdk14 image

We are running a micro services stack based on Spring Boot apps and postgres databases. From time to time, the Flyway migrations integrated into the apps via Spring Boot fail due to a non finished startup of the postgres database. Of course there are solutions out there that try to address these issues deployment wise, still none of them is really straight forward, overcomplicating deployment.
Flyway overs a native solution to that. We managed to overcome the issue by using flyway.connectRetries=10. This is working for us, but configuring a higher number of retries will flood the logs on startup with errors.
In general this is a small problem, but being able to configure a flyway.connectRetryWaitPeriodMs=5000 would be a cool thing instead of having to use the default hardcoded 1s period.

Related to https://github.com/flyway/flyway/issues/2847

Flyway V7 allows you to set JDBC Properties. One such property for PostgreSQL is connectionTimeout. Would this allow you to achieve the same result?

I suspect not; this isn't about how long you wait before giving up on trying to get a connection and try again, it's how long you wait after a failure before you have another go. If the database is known to be very slow to spin up, Flyway could get quite spammy.

This is correct. If the database needs 10s to spin up with 10 retries configured, you´ll have 10 full stacktrace in the log.
If you know your DB takes some time, youll rather have 2 or 3 retries with a 10s timeout in between.

This is still not completed. Although it is marked as completed. The commit currently linked to this issue is for the backoff strategy of the connection failure. Connection failure doesn't mean there is no lock on the database and migration failed due to lock.


hide minimum nodes alert (bsc#1046626)

Signed-off-by: Maximilian Meister<EMAIL_ADDRESS>

I was not sure about the UI, maybe fadeOut/fadeIn would be better than hide/show here?

I was not sure about the UI, maybe fadeOut/fadeIn would be better than hide/show here?

KKK. I reviewed without reading this one. Yeah, i guess it's better.

ping @eotchi, to make sure she's fine with this change.

Yep, fine by me.


Could you share some details about running inference on RK3588 NPU?

Hi guys,
I have RK3588 board, that you have used in paper as edge device to run on.
I have trained my weights using edgeyolo_tiny_lrelu , converted to ONNX , than to RKNN using rknn-toolkit 1.4
Command for export to onnx used was
python export.py --onnx-only --weights /workspaces/rocm-ml/edgeyolo/output/train/edgeyolo_lp_2/best.pth --opset 12
However currently i am unable to use QUANTIZE_ON during onnx->rknn conversion, i have used same dataset as for validation during training , different range from 10 to 50 images, without success --> resulting rknn model always outputs bogus.
You are mentioned QUANTIZATION enabled in your paper, could you share same details about how you managed to make it work?
I am running it on RK3588 (from radxa , rock5b) my inference speed is around 11fps~
You are mentioned 32fps in your paper.

I am curious if you implemented multi-threaded inference on RK3588 using all 3 NPU cores by yourself? , which would be 3x11fps ?
Also, have you used edgeyolo_tiny_lrelu.yaml as model_cfg?

Could you please share some more details about running edge-yolo on rk3588, paper nor code here is showing some insights about running it on that edge device.
Thank you in advance~

@hlacikd, hello
I also tried to experiment with converting of EdgeYOLO from ONNX to RKNN for inference on RK3588s board by Firefly (It was on loan to me)
I converted trained on own data EdgeYOLO-Tiny 320x320 (without LReLU) to ONNX with opset 11 and converted it to RKNN in two modes: with quantize and without quantize
Then I tried to inference on images on RK3588s board using RKNNLite2 and I got wrong detections, that went out of frame
Also I tried to convert own  EdgeYOLO-Tiny 320x320 to RKNN on the fly using RKNN Toolkit 2, installed on host PC, and tried to inference on images using simulator. And I got true detections in this case
In both cases, I used the same pre- and post-processing methods
So it would be nice to see recommendations here for converting EdgeYOLO to RKNN format and inferencing on Rockchip boards, given that EdgeYOLO is aimed at use in edge devices

I'm not sure if EdgeYOLO with Leaky ReLU can be correctly converted from ONNX to RKNN, since the LeakyReLU node in ONNX is available with opset 16, when RKNN Toolkit 2 requires the source model in ONNX to have an opset no higher than 12:  https://github.com/onnx/onnx/blob/main/docs/Operators.md#LeakyRelu

I'm not sure if EdgeYOLO with Leaky ReLU can be correctly converted from ONNX to RKNN, since the LeakyReLU node in ONNX is available with opset 16, when RKNN Toolkit 2 requires the source model in ONNX to have an opset no higher than 12: https://github.com/onnx/onnx/blob/main/docs/Operators.md#LeakyRelu

hey @susanin1970 , I am using edgeyolo_tiny_lrelu on rk3588 sucessfully (without rknn quantization, it predicts bogus when quantize=on).
What happens to me tho, that once after around 1000frames i get several false detections, which is something i am fighting with rn and have no solution for that yet.

@hlacikd, can you please tell me why rknn toolkit2 1.5.0 is totally broken
Because I was just using rknn toolkit2 version 1.5.0 in my experiments 😄

it throws this error after each inference run
https://github.com/rockchip-linux/rknn-toolkit2/issues/168

@hlacikd @susanin1970
hi guys, thanks for all of your works on rk3588(rk3588s), actually it needs some adjustment while exporting onnx if you want to convert to rknn model, I've released the newest code and models for rk3588, and it reaches 55fps for edgeyolo_tiny_lrelu, if you are still interested, please click here and see

btw, I didn't say any words about RK3588 in my paper, the edge device I use in my paper is Jetson AGX Xavier.

Hi guys,
I have RK3588 board, that you have used in paper as edge device to run on.
I have trained my weights using edgeyolo_tiny_lrelu , converted to ONNX , than to RKNN using rknn-toolkit 1.4
Command for export to onnx used was
python export.py --onnx-only --weights /workspaces/rocm-ml/edgeyolo/output/train/edgeyolo_lp_2/best.pth --opset 12
However currently i am unable to use QUANTIZE_ON during onnx->rknn conversion, i have used same dataset as for validation during training , different range from 10 to 50 images, without success --> resulting rknn model always outputs bogus. You are mentioned QUANTIZATION enabled in your paper, could you share same details about how you managed to make it work?
I am running it on RK3588 (from radxa , rock5b) my inference speed is around 11fps~
You are mentioned 32fps in your paper.
* I am curious if you implemented multi-threaded inference on RK3588 using all 3 NPU cores by yourself? , which would be 3x11fps ?

* Also, have you used _edgeyolo_tiny_lrelu.yaml_ as model_cfg?

Could you please share some more details about running edge-yolo on rk3588, paper nor code here is showing some insights about running it on that edge device.
Thank you in advance~


s4cmd 2.0.1 leaks memory for large uploads

Hi there:
We are using s4cmd to push, in parallel, about 70k files into an S3 bucket.  The files vary in size from very small (10s of bytes) to somewhat large (11GB).  On a recent run, s4cmd consumed nearly 80GB of memory before being caught by the Linux OOM killer.
To test, I created a smaller pool of 2,500 and 1,000 files and modified s4cmd to sleep before exiting so we could get an accurate RSS measurement.
The 2,500 file pool was 6.9GB on disk.  The 1,000 file pool was 2.5GB on disk.
After successfully uploading both pools, RSS for the s4cmd process was roughly equal to the total size of files uploaded:
The 2.5GB pool ended up with an RSS of 2.7GB.
The 6.1GB pool ended up with an RSS of 7.3GB.
The size of the files being uploaded, not the total number of files, is the driving factor.  Uploading 5,000 2 byte files only drives the RSS to .16GB (~167MB).
Specifying a very small max-singlepart-upload-size (for example, 1048576 bytes) does not change the memory usage.
After bisecting the upload() method in s4cmd.py, it appears the leak or cycle is happening inside of the boto3 put_object() call.  Commenting out the put_object() keeps memory usage stable.
Importing and periodically calling gc.collect() also keeps memory usage in check.
I have not put together a test case just using boto3 to see if the leak occurs there.  But I can't be the only person who would like to use s4cmd to upload several hundreds of GB of files.
Is there already a known workaround for this problem?
The environment is:
python 2.7.12
s4cmd 2.0.1
boto3 1.4.4
botocore 1.5.24

We built two test scripts to try and narrow down the leak and to determine whether the problem was in boto3 or a result of how boto3 was being called by s4cmd.
The first script calls boto3's put_object() directly.  The second imports BotoClient from s4cmd.
In both cases, we ran the scripts against the same 1,000 and 2,500 file corpuses that were causing leak with s4cmd.  Neither script leaked, so it appears to be a cycle that's being created within s4cmd somehow, not an outright bug in boto3.
Two scripts follow:
#!/bin/env python
native boto3 calls
import boto3
import botocore
import os
testdir = '/tmp/testdir'
client = boto3.client('s3')
files = os.listdir(testdir)
for file in files:
client.put_object(ACL='private', Body=open('%s/%s' % (testdir, file), 'rb'), Bucket="wawd-s4cmd-test-bucket", Key="%s/%s" % ("testdir", file))

#!/bin/env python
s4cmd BotoClient calls
from s4cmd import BotoClient
import os
testdir = '/tmp/testdir'
client = BotoClient({})
files = os.listdir(testdir)
for file in files:
client.put_object(ACL='private', Body=open('%s/%s' % (testdir, file), 'rb'), Bucket="wawd-s4cmd-test-bucket", Key="%s/%s" % ("testdir", file))

I'm experiencing the same issue when trying to sync a 270GB directory to a bucket.
It will run a dry run without any issue but won't actually sync more than a few GB.

The problem is still happening. is there any fix ?

For me reducing the thread count (-c 2 ) seemed to stop it. YMMV etc. This was on a small VM with under 2GB of RAM.

For me -c 2 didn't helped
s4cmd not able to upload 2.2GB archive with about 500MB of RAM.
But helped this two option(actually only second one, but I wanted to be sure about what size of piуce will be used)
--multipart-split-size=100000000 --max-s inglepart-upload-size=100000000


syncback: make sure the krsync entrypoint does not need escaping

Hello @nicksieger,
Please review the following commits I made in branch nicks/syncback:
bd46d60bf70723e4c08a4390078bf45a4d733214 (2022-02-23 10:34:02 -0500)
syncback: make sure the krsync entrypoint does not need escaping
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

i think there might be an underlying rsync bug here. Anything passed to rsync --rsh did not properly escape its arguments. but we're already using it in kind of a bizarre way.


Add Docusaurus website

Type of PR: enhancement
PR checklist:

[x] Documentation update. Oh yes.

Overview of change:
This PR adds a documentation website built with Docusaurus.
See https://edew.github.io/lightweight-charts/ for a demo.
There's a lot that we can improve. Interactive examples, more tutorials, etc. but this is a good start.
Is there anything you'd like reviewers to focus on?
Once we are happy with this and it is merged the noIndex option can be disabled - I have left it on for now so (hopefully) the version of the site hosted on my personal GitHub Pages branch isn't indexed.

Additionally, is it possible to generate favicon from svg on the fly?

I'm sure it's possible. We would have to write something custom. Do you think it's something we should do?


[$250] Contact method - Secondary contact method can not select Set as default

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Login with new gmail account
Go to Account settings> Profile> Contact method> New contact method> Add new email> Add
Click on newly added secondary contact method> Complete the verification process
Click on the verified secondary contact method> Set as default

Expected Result:
There should be no error message. Since the secondary contact method becomes primary contact method - Set as default option should not be present
Actual Result:
"This is already your primary contact" error message appears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/01543e66-f0ce-494e-a88d-2bad396845dc
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012a16b21d55b907d8
Upwork Job ID:<PHONE_NUMBER>557629626
Last Price Increase: 2024-08-07
Automatic offers:

ikevin127 | Reviewer | 103456590

Issue OwnerCurrent Issue Owner: @ikevin127

We think that this bug might be related to #vip-vsp

@greg-schroeder  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't select secondary method as default on a new non-validated account.
What is the root cause of that problem?
When we have a non-validated account, add a secondary login, and then verify the secondary login, the BE actually sets the secondary login as the primary login. It can be verified from an email received after verifying, telling that the primary login has been changed to the secondary login. So, when we try to set the secondary login as the primary login, the BE responds with a message that the secondary login is already the primary login.
What changes do you think we should make in order to solve the problem?

If the BE behavior is expected, then we can fix this on the FE. What we want to do is, when validating a secondary login, if the primary login isn't validated yet, set the secondary login as the primary login on success verifying.
The loginList will be passed from the function params.
https://github.com/Expensify/App/blob/9901ca3a554f4c2991b56862dfb8e43d2e1aba80/src/libs/actions/User.ts#L368
if (!loginList[currentEmail].validatedDate) {
    successData.push(...[
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.ACCOUNT,
            value: {
                primaryLogin: contactMethod,
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.ACCOUNT,
            value: {
                primaryLogin: contactMethod,
            },
        },
        ...,
    ]);
}

The data that requires update can be seen from the setContactMethodAsDefault optimistic data. (except the login list)

⚠ @bernhardoj I was not able to successfully verify if your solution fixes the issue, this is what I did (see diff below) to test the solution and the issue is still present. Please let me know if I missed something!

Diff
diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts
index 3019e3dfbb6..ea9fa1e6a60 100644
--- a/src/libs/actions/User.ts
+++ b/src/libs/actions/User.ts
@@ -365,7 +365,7 @@ function validateLogin(accountID: number, validateCode: string) {
 /**
  * Validates a secondary login / contact method
  */
-function validateSecondaryLogin(contactMethod: string, validateCode: string) {
+function validateSecondaryLogin(contactMethod: string, validateCode: string, loginList: Record<string, Login>) {
     const optimisticData: OnyxUpdate[] = [
         {
             onyxMethod: Onyx.METHOD.MERGE,
@@ -444,6 +444,20 @@ function validateSecondaryLogin(contactMethod: string, validateCode: string) {
         },
     ];

+    if (!loginList[currentEmail].validatedDate) {
+        successData.push(
+            ...[
+                {
+                    onyxMethod: Onyx.METHOD.MERGE,
+                    key: ONYXKEYS.ACCOUNT,
+                    value: {
+                        primaryLogin: contactMethod,
+                    },
+                },
+            ],
+        );
+    }
+
     const parameters: ValidateSecondaryLoginParams = {partnerUserID: contactMethod, validateCode};

     API.write(WRITE_COMMANDS.VALIDATE_SECONDARY_LOGIN, parameters, {optimisticData, successData, failureData});
diff --git a/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx b/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx
index 352260c275f..0ed81cddcfb 100644
--- a/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx
+++ b/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx
@@ -178,8 +178,8 @@ function BaseValidateCodeForm({account = {}, contactMethod, hasMagicCodeBeenSent
         }

         setFormError({});
-        User.validateSecondaryLogin(contactMethod, validateCode);
-    }, [validateCode, contactMethod]);
+        User.validateSecondaryLogin(contactMethod, validateCode, loginList);
+    }, [validateCode, contactMethod, loginList]);

     return (
         <>

Oh my bad, the ONYXKEYS.ACCOUNT is duplicated, it should be
{
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.SESSION,
    value: {
        email: newDefaultContactMethod,
    },
},

This will make sure the secondary login will be the default contact method.
I have updated my proposal to fix that.

Thanks for clarifying!
@bernhardoj's updated proposal looks good to me. The RCA is on point and the updated solution fixes the issue in accordance with the Expected result.
🎀👀🎀 C+ reviewed

We're currently awaiting Rory's input on the reviewed / selected proposal.

Yes we do!
cc @roryabraham for assignment based on https://github.com/Expensify/App/issues/46350#issuecomment-2264186568.

PR is ready
cc: @ikevin127

ℹ Will review on Saturday (PST) when I'll return to office.

PR merged. Awaiting deploy to staging -> prod

⚠ Production deploy automation failed here -> this should be on [HOLD for Payment 2024-08-20] according to yesterday’s production deploy confirmed in https://github.com/Expensify/App/pull/47132#issuecomment-2289865815 and deploy checklist.
cc @greg-schroeder

Sure, adjusted

cc @greg-schroeder

Payment summary:
Contributor: @bernhardoj - $250 - You can make a manual request via ND
C+: @ikevin127 - $250 - Paid via Upwork

Requested in ND.

@greg-schroeder Thanks for the payment 💯

[x]  [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/15751
[x]  [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15751/files#r1723731216
[x]  [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:N/A.
[x]  [@ikevin127] Determine if we should create a regression test for this bug.
[x]  [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Login as a new user with a new email address.
Add a secondary contact method and validate it.
Verify the secondary contact method is assigned as the default contact method.
Open the contact method page again and now verify the other contact method.
Set the other contact method as default.
Verify the other contact method is set as default.
Repeat step 5 and 6.
Verify that the contact method selected at step (5.) is set as default.

Do we agree 👍 or 👎.

$250 approved for @bernhardoj

Filed regression, payments done. closing


When we expand a form, scroll to ensure it's visible in the sidebar

This is a small tweak that makes navigation/editing easier. If someone picks an intervention, they probably want to actually see the entire form.
Before:
https://user-images.githubusercontent.com/1664407/228212695-c4638fc0-3b63-486a-b7ee-b6450bfce2c4.mp4
After:
https://user-images.githubusercontent.com/1664407/228212718-85059976-8b7d-42b2-9232-24884957f3e4.mp4

UX win: focusses helpfully on the fields the user is most likely to want to edit, reduces risk of people forgetting to add description etc.


Add message for a Storage Queue Encoding is backward

Storage Explorer Version: 1.15.1
Build Number: 20200902.9
Platform/OS: Windows 10
Architecture: x64
Regression From:  don't know
Bug Description
The encoding for sending a message on the queue is backward.
When you pick Base64, it sends as UTF8. When you pick UTF8 it sends as base64.

Now this will sound weird. But my staging queue, that box works correctly. However, that local queue, that box does not work correctly.
I consume the queue with an Azure Function v3.
        [FunctionName("SendEmailWithInvoice")]
        public async Task SendEmailWithInvoice(
            [QueueTrigger("tr-sendinvoice")] string myQueueItem,
            ILogger logger
        )

Both local and staging uses the same code.
I do not know why it would work one way in local and another in staging. I'm open to try things if necessary to make you understand better why this is happening.


Window support

Hi, I just want to know that is window support possible?

It is possible, but we didn't invest in that. We are happy to merge pull requests that would add Windows support.


feat: add originalWidth / originalHeight accessors to ESLImage

Add originalWidth / originalHeight accessors to ESLImage
Note:  CHANGELOG removed

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix bug in Task.getattr

Hi,
Thanks for sharing this module! I started using it yesterday and fixed a small bug. Feel free to accept or reject this.
Changelist:

Task.__getattr__ now raises AttributeError instead of returning it.
TestFormats.test_convenient_attr_parsing now contains a test for this condition.

Cheers,
Sander

Blimey, thanks a lot for the fix and the input!

Blimey, thanks a lot for the fix and the input!


New project errrors

I'm getting some errors when trying to run my project using the following command
./vendor/bin/jigsaw build production

The first is a composer error it looks like
PHP Fatal error:  Interface 'Illuminate\View\Engines\EngineInterface' not found

I was able to solve this my changing the path in MarkdownEnding.php to the following
use Illuminate\Contracts\Engines\EngineInterface;

I then had to run composer dump-autoload inside of Jigsaw src.
I then had another error...
PHP Fatal error:  Uncaught Error: Class 'Illuminate\Container\Container' not found

I don't understand ... why are there so many issues with a fresh install?

Ok, the change was as followed. I changed
use Illuminate\View\Engines\EngineInterface

to the following:
use Illuminate\Contracts\View\Engine as EngineInterface;

Now markdown files work. Should open a PR for this for the tightenco source.

This was caused by the recent update of some key Laravel dependencies to version 5.5. A new Jigsaw release has been tagged (v1.0.7) which fixed this issue, so if you run composer update from your project directory, you should be good to go.


Created Mobile Hamburger Menu Using JavaScript

My partner and I have done the following changes and I want to implement these changes:

Added HTML, CSS and JS Linters
Setup the effects for the hamburger menu
Updated index.html
Created javascript.js
Updated Mobile Menu and the contact section

Hi @Team
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have the javascript linters also setup, for this project both the JavaScript and HTML&CSS linters should be configured
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


feature request: callback for image capture without file write

I am currently developing an app which where the goal is to periodically take a photo and process it (but only save a final photo after some time).
Currently I use enable_analyze_pixels for this, however the resolution of the image I obtain from this is not as high as the image which is output via the photo capture which writes to a file.  I have tried setting it, but on my android (pixel 6 Pro, android 13) it seems to be limited to 2236x1258 instead of the desired 4080x4072 (or 16:19 equivalent)
I would like to avoid excessively writing and deleting files, so it would be nice to have a callback which simply gets the photo's bytes without them being written directly to a file. I believe android OS supports such a callback: OnImageCapturedCallback used by ImageCapture.takePicture()

Yes, the analyze api is not going to be optimal for this use case. Top of my head I don't know where the size constraint you see is coming from, but I expect it is cameraX - it does stuff like that you may not get desired size, I don't know if that will be different with ImageCapturedCallback  (currently uses ImageSavedCallback).
Thus some c4k option would command return memory ref, Do you envision the c4k callback returning a memory reference in place of a string? Android would return an ImageProxy (presumably bgr or yuv420, if in buffers this may only be visible from Java - have to test), should the returned reference be something Python friendly or is ImageProxy better?
Food for thought at the moment, I got other things....

that will I think be the best resolution CameraX will provide.
Forget that, that is only from the analyze use case, photo use case may be different.

Note to self: Also the image will have to be rotated depending on the device hardware, or also return rotation angle.

What is the issue with saving a jpeg to private storage, then reading and deleting from the c4k image saved callback?

What is the issue with saving a jpeg to private storage, then reading and deleting from the c4k image saved callback?

I'm hesitant to use flash in this way as it has a finite lifetime, so I'd prefer to avoid unnecessary read/write operations like this

Well to me the idea is interesting, and probably could be implemented in a platform independent way.
Its not clear to be that it should be implemented.
The positives seem to be elegance, and storage lifetime.
The negatives seem to be (mostly) no new behavior, no other requests, and prioritizing against other tasks.
The memory lifetime argument is an interesting one, but not something I feel the need to be responsible for.
I'll keep the idea around, but for now no action.
If it is important to you I suggest you fork c4k and camerax_provider.


Integrate CLI services describe function into Landing page

Feature description
Integrate CLI services describe function into Landing page (currently working in CLI service in 0.9.0)
Feature design or visual mockup
The describe function provides more detailed metadata on a given stack for informational and debug purposes
Additional context
endpoint:  https://{{myurl}}/v1/describe/stacks/nodejs-express/versions/0.2.10
JSON returned:
{
    “image”: “docker.io/kabanerobeta/nodejs-express”,
    “name”: “nodejs-express”,
    “project”: “kabanero”,
    “digest check”: “matched”,
    “version”: “0.2.10",
    “git repo url”: “https://raw.githubusercontent.com/kabanero-io/kabanero-command-line-services/master/index.yaml”,
    “image digest”: “17fd40a884f44345fa05b395c10c5cf48be7e92a3e21800c5d61b7b87724002e”,
    “kabanero digest”: “17fd40a884f44345fa05b395c10c5cf48be7e92a3e21800c5d61b7b87724002e”,
    “status”: “active”,
    "applications":"[my_appsody_app, joes_appsody_app]"
}

could the landing page business logic gen the the kAppNav link to see more detailed data on the appsody app, so that Champ could just click on a link to see more app metadata

yes we do that today if kAppNav is installed

nice

A lot of the metadata for the application is returned in the map, so it's possible I could just pass back a jsonobject that contains whatever we need and you can bypass having to use kAppNav

deploymentMap.log

e.g.
"applications": "[{"name":"nodejs","namespace":"kabanero","architecture":"x86_64"}]"

yeah that sounds good, you can just return the whole thing (if it isn't excessively large).

take a look at deploymentMap.log above, the map is sort of big

ok, got the map into the json response:
"applications": "[{\"name\":\"nodejs\",\"namespace\":\"kabanero\",\"map\":{\"metadata\":.....

applications1.log

json response from new GO Kababenero REST service:
{
"apps": [
{
"app.kubernetes.io/instance": "nodejs",
"app.kubernetes.io/managed-by": "appsody-operator",
"app.kubernetes.io/name": "nodejs",
"app.kubernetes.io/part-of": "nodejs",
"app.kubernetes.io/version": "1.0.0"
},
{
"app.kubernetes.io/instance": "nodejs",
"app.kubernetes.io/managed-by": "appsody-operator",
"app.kubernetes.io/name": "nodejs",
"app.kubernetes.io/part-of": "nodejs",
"app.kubernetes.io/version": "1.0.0"
}
],
"digest check": "matched",
"image digest": "f13c6c3022544b6ffc4f0f111b36c0f4d0066accb3d9e9a7f7d1218a7411c159",
"image name": "docker.io/kabanero/nodejs",
"kabanero digest": "f13c6c3022544b6ffc4f0f111b36c0f4d0066accb3d9e9a7f7d1218a7411c159",
"name": "nodejs",
"project": "kabanero",
"status": "active",
"version": "0.3.6"
}

Old CLI service does not provide list of apps in describe response
New GO service does


Minor Version for Release. Don't need to update apm_bundle


Ensuring transform and log files are generated

this bugfix PR also introduces a functional wrapper for resampling

@sarthakpati I introduced a separate test, testing the transform function now.

/format

/format

@sarthakpati okay...the single tests pass but the combined test fails

hmm on this ubuntu machine, it still creates two log files where two are empty? @MarcelRosier will have another look tmrw.

Weird. https://github.com/BrainLesion/eReg/pull/62/commits/91fb002efe0b145a33aabdd3504ccdd5fea8a2d4 should check for any empty log files and throw an exception.

Rechecked and it works fine for me. Perhaps you had an older version installed that is being sued instead of the local repo that includes the changes?

rewrote the usage of the logging module and tests.
Please have a look and lmk what you think @neuronflow @sarthakpati

I am fine with the changes.
However, who should review/merge the PR now that @MarcelRosier you have contributed to the code?

just checked, seems to work fine. Thanks @MarcelRosier :)
..Only small issue is if the trans files already exist ereg does not really warn..this might lead to unexpected behavior..we might open a feature request for this.
I will merge this now as both @sarthakpati and me approve the changes.


update Makefile for test

@wenhuizhang why do we need this? #73 is taking care of client testing. The executable you're running aren't even compiled anywhere. Closing for now.

Oh, in my humble opinion, #73 is taking care of tests for client, yet not
for server, if I did not make it wrong, please correct me if I did.
On Wed, Apr 29, 2015 at 5:51 PM, Phil Lopreiato<EMAIL_ADDRESS>wrote:

@wenhuizhang https://github.com/wenhuizhang why do we need this? #73
https://github.com/gwAdvNet2015/gw-kv-store/pull/73 is taking care of
client testing. The executable you're running aren't even compiled
anywhere. Closing for now.
—
Reply to this email directly or view it on GitHub
https://github.com/gwAdvNet2015/gw-kv-store/pull/74#issuecomment-97622742
.

--
V/R,
Wenhui Zhang
Email<EMAIL_ADDRESS>Telephone: 1-(703) 424 3193

I think the tests for the server code are in a pretty good state right now, so I don't think any more are necessary.
Plus, there isn't even any C code referenced by your makefile - read the test output to see where.
Unless @atryrus disagrees, I think this one should stay closed.

I agree with @phil-lopreiato about keeping this closed. Phil and I will talk tomorrow and figure out what needs to be refactored. We will create an issue tomorrow instructing exactly what needs to be done.

Just updated and changed dir for include headers in server-kv-test and client-kv-test, and it works for me now, created a new push, pls let me know if you have any questions @zhangwei1984  @phil-lopreiato @atryus


Test commit

@rajeshgangoni Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@rajeshgangoni please use your own fork to test Github's PR features. This is spamming everyone watching this repository.


Feature topic bugs from berkman

#803, #804, #807

ok updated code as suggested

just a note: the query for media types is tags_id_media whereas some of the other focal sets queries are tags_id_stories...

update to mediatype.py pushed


[ENH] Add a reset_index boolean kwarg to shuffle(), fixes #540

PR Description
Please describe the changes proposed in the pull request:

Add a reset_index parameter to shuffle()

This PR resolves #540

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.

[x] Add a line to CHANGELOG.rst under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[ ] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checking
running the test suite
docs build

Once done, please check off the check-box above.
If make check does not work for you, you can execute the commands listed in the Makefile individually.
Code Changes

If you are adding code changes, please ensure the following:

[x] Ensure that you have added tests.
[x] Run all tests ($ pytest .) locally on your machine.

[x] Check to ensure that test coverage covers the lines of code that you have added.
[x] Ensure that all tests pass.

Documentation Changes

If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

@ericmjl would love CR

@eyaltrabelsi this is great! Thanks for doing this :smile:.
Btw, I've noticed you've been force-pushing to dev quite often in your PRs. Perhaps as a matter of practice in the future, could you do the following?

Create a new branch in your fork of the repo
After making changes, PR from branch into ericmjl/dev
Once changes are made, you can pull in latest dev to your fork.

These will help reduce the number of force-pushes you end up doing (don't want this to become your habit, as I don't think many others do this regularly during PRs).


Automatic Indexes

Does the repo automatically create indexes to Elasticsearch? I had to manually add the index to Elasticsearch (it's not well documented yet I think)

Hi @i6media, it doesn't create indexes automatically. Check this part of the documentation, I think this is what you are looking for.


Error on fetch for angular2-jwt.js

Hi.
I am having trouble including angular2-jwt in my production build.
Why would it be looking for  angular2-jwt.js in the root node_modules directory?
Dev build works fine. Any ideas?
[14:51:29] 'build.bundles.app' errored after 1.08 s
[14:51:29] Error on fetch for angular2-jwt.js at file:///C:/dev/Backups/angular2-seed/node_modules/angular2-jwt.js
Loading dist/tmp/app/main.js
Error: ENOENT: no such file or directory, open 'C:\dev\Backups\angular2-seed\node_modules\angular2-jwt.js'
at Error (native)

The SystemJS mapping that you have (or haven't) provided is incorrect.
For support requests you can use gitter or take a look at project's the wiki page in order to get more complete idea on how the seed works.

Thanks.


SSHNP Backwards Compatibility Test Coverage

Is your feature request related to a problem? Please describe.
More test coverage on: pull_request (automated)

[x] release3.3.0-local
[x] local-release3.3.0
[x] release3.2.0-local
[x] local-release3.2.0
[x] local-release3.1.2
[x] release3.1.2-local

from #250
Describe the solution you'd like
:)
Describe alternatives you've considered
No response
Additional context
No response

Closed as of #250


How to compile android  ios and macos?

Are there any relevant compilation instructions? I didn't find the relevant profiles file?
Thanks！

Hi!
checkout the create packages and upload them section. It's simply a conan create .
Some example profiles are available under the folder profiles.
You can find more information about profiles at the official documentation

Thanks！


OPTICK_THREAD vs OPTICK_FRAME

Hi,
the wiki page makes no mention of OPTICK_FRAME, which is rather unfortunate since this is the one required macro to make the profiler work.
Also what is the difference between OPTICK_THREAD  and OPTICK_FRAME?
I have multiple threads each dedicated to a specific task. (I know that this does not scale, but lets leave that aside for now.) One thread is rendering as fast as possible. One thread updates sound buffers at a fixed rate and one thread updates game logic and passes the state to be used by other threads. How should I use the two aforementioned macros in such situation? How do I control which of the frame sequences will be shown in the upper timeline?
When I use just one OPTICK_FRAME, I cannot see details from other threads.
When I use one OPTICK_FRAME in each of the threads, I cannot control which of the threads should be in the upper timeline.
Thanks

After a bit of experimentation, I have discovered that both OPTICK_THREAD and OPTCIK-FRAME create a scope, much the same as OPTICK_EVENT. While this behavior is intuitive for OPTICK_EVENT, I consider it not intuitive for the other two macros. This should be mentioned in the wiki page too :D
I also suggest adding thread_local storage specifier to the OPTICK_THREAD's scope guard variable. This will make it possible to use the macro inside a callback without spamming the gui view with hundreds independent threads.
There is OPTICK_START_THREAD and OPTICK_STOP_THREAD which solves several issues, but there is no corresponding start/stop alternative for OPTICK_FRAME.
Moreover, I still did not found a way to configure which frames sequence should be shown in the top timeline view.
Sidenote: ThreadScope(const wchar_t* name) leaves keepAlive uninitialized.
Anyway, Optick has already helped me with few improvements :D thanks for this awesome library

Hi, I am planning to do an improvement pass over documentation within a week or two.
Here is a quick description of the differences between these two macros:

OPTICK_FRAME - macro for MAIN thread only, it should be used only once in your code. Scope of this macro defines a single frame. So in your case I'd suggest to mark a loop on your Render thread with OPTICK_FRAME macro. OPTICK_FRAME macro already includes OPTICK_THREAD macro, so you don't need to add it manually for your render thread.
OPTICK_THREAD - macro is for HELPER threads (in your case - audio, logic, etc.). You need to mark the scope of your whole thread:

void LogicTask()
{
   OPTICK_EVENT();
   // Do some stuff here
}

void LogicThread()
{
   OPTICK_THREAD("LogicThread");
   while (g_logicThreadIsAlive)
   {
      WaitForNextLogicTask();
      LogicTask();
   }
}

void AudioThread()
{
   OPTICK_THREAD("AudioThread");
   while (g_audioThreadIsAlive)
   {
      Sleep(10); // Fixed update frame - putting sleep outside Optick's macro for better visibility on the timeline
      OPTICK_EVENT("UpdateAudio");
      // Update sound buffers
   }
}

void RenderThread()
{
   while (g_renderThreadIsAlive)
   {
        OPTICK_FRAME ("RenderThread"); // Scoped macro for a single frame
        // Render stuff
   }
}

int main()
{
  std::thread logicThread(LogicThread);     // spawn new thread that calls LogicThread()
  std::thread audioThread(AudioThread);     // spawn new thread that calls AudioThread()
  std::thread renderThread(RenderThread);     // spawn new thread that calls RenderThread()
  // ...
  return 0;
}

So to answer your quesiton - you don't need thread_local for OPTICK_THREAD as it should wrap the whole scope of the thread and not individual tasks.
OPTICK_FRAME already has a thread_local inside and should be used to wrap a scope of one frame.

Thanks for this write-up. It confirms my understanding. :D
Adding thread_local to OPTICK_THREAD would simplify situations where the thread is created in a 3rd party app/lib and my tasks are run in a callback, or so I think. In the end, I could use the start/stop macros, or add my own macro.
As for the OPTICK_FRAME, I ended up with this pattern:
std::atomic<int> confOptickFrameScope = 0;

void renderThreadEntry()
{
	OPTICK_THREAD("render");
	while (!stopping)
	{
		if (confOptickFrameScope == 0)
		{
			OPTICK_FRAME("render");
			renderThreadStep();
		}
		else
		{
			OPTICK_EVENT("render");
			renderThreadStep();
		}
	}
}

void soundThreadEntry()
{
	OPTICK_THREAD("sound");
	while (!stopping)
	{
		if (confOptickFrameScope == 1)
		{
			OPTICK_FRAME("sound");
			soundThreadStep();
		}
		else
		{
			OPTICK_EVENT("sound");
			soundThreadStep();
		}
	}
}

void logicThreadEntry()
{
	OPTICK_THREAD("logic");
	while (!stopping)
	{
		if (confOptickFrameScope == 2)
		{
			OPTICK_FRAME("logic");
			logicThreadStep();
		}
		else
		{
			OPTICK_EVENT("logic");
			logicThreadStep();
		}
	}
}

This works and allows me to choose what framing to focus on at runtime.
Trying to imagine the many wrong ways I took before this may, perhaps, explain why I took so long to understand it :D

I have few more suggestions, if I may:
add thread_local to OPTICK_THREAD
#define OPTICK_FRAME(NAME) OPTICK_THREAD(NAME); OPTICK_FLIP_FRAME(NAME); OPTICK_FLUSH();
#define OPTICK_FLIP_FRAME(NAME) // name defines the framing sequence, it would be nice to allow switching different sequences in the gui app.
#define OPTICK_FLUSH() // sends the collected data to the gui app. at least I think that is part of the current OPTICK_FRAME

The point here is to separate different responsibilities so that advanced users can benefit more. It would make it possible to send data without any frames. It would allow to have multiple frame sequences. It would allow to mark frame boundaries without the need to wrap the entire frame in a single scope.
And it should be API backwards compatible :D
What do you think?

That's a good idea. I was planning to separate update logic from frame boundaries quite soon anyway.
I'll keep your suggestion in mind and will make sure that Optick supports multiple "frame" boundaries allowing you to toggle between them from GUI.


Add .remarkrc.js config support

Hi, now it can support .remarkrc.js now!

Hey @mrmlnc any chance of getting this in?

Thanks :tada:


Add 'section' property to ConsoleLinkSpec

Adding Section field to the ConsoleLinkSpec so the  link is rendered in appropriate section in the picked ConsoleLinkLocation. Also adding the Application Luncher menu into the ConsoleLinkLocation enum.
Sub-Story of Story
@jeff-phillips-18 @serenamarie125 PTAL
/assign @spadgett

cc @bparees

@spadgett @jeff-phillips-18 PR updated based on your comments. PTAL

Comments addressed. PTAL
@spadgett wasn't really sure what should be the max size of the image so I've added just the ratio.
@bparees @jeff-phillips-18 fyi

@spadgett thanks for the wording. Updated. PTAL

@spadgett sorry for that, I though I've updated it. Anyway it's done.
@bparees PTAL

@bparees comment addressed. PTAL

@spadgett comment addressed.
@bparees PTAL

/approve

/lgtm


Adds testing for service_agreements.

Closes #292.

Added https://github.com/oceanprotocol/ocean.py/issues/306 as a possible follow-up.


move the pod spec to a deployment manifest

When the node on which the pod, is rotated or taken out of the cluster. The pod would get lost along with. Moving it to a deployment manifest is a possible solution of how it can be fixed.

You can use helm chart


Add hdparm support in discovery overlay

Need hdparm tool for sata's disk identifer data
@RackHD/corecommitters @RackHD/rackhd_dev

+1

👍

:+1:


Clipped not actually clips the Image

Clipping the image only seems visually fine in the UI. Unfortunately elements below become unresponsive.
It was also reported here on StackOverflow: https://stackoverflow.com/questions/63300411/clipped-not-actually-clips-the-image-in-swiftui/63301282
That's my code to reproduce:
    var body: some View {
        VStack(alignment: .leading, spacing: 0) {
            WebImage(url: URL(string: "https://i.imgur.com/s3ptEuh.png")!)
                .resizable()
                .aspectRatio(contentMode: .fill)
                .frame(maxHeight: 400)
                .clipShape(RoundedRectangle(cornerRadius: 10, style: .continuous))
                .shadow(color: Color.black.opacity(0.2), radius: 20, x: 0, y: 20)
            HStack() {
                VStack(alignment: .leading) {
                    Text("Name")
                        .font(.headline)
                    Text("Date")
                }
                Spacer()
                Button(action: { print("Test") }) {
                    Image(systemName: "bookmark"))
                        .foregroundColor(.white)
                        .font(.system(size: 16, weight: .medium))
                        .frame(width: 36, height: 36)
                        .background(Color(.systemBlue))
                        .clipShape(Circle())
                }
            }
            .padding(.horizontal, 12.0)
            .padding(.vertical, 8.0)
        }
        .background(Color(.systemGray5))
        .clipShape(RoundedRectangle(cornerRadius: 10, style: .continuous))
    }

Any fixes or workarounds yet?

@AnnieNinaJoyceV After some research, I found that I didn't need the library since loading web images is possible with standard SwiftUI. I created a gist to share the basic concept: https://gist.github.com/linusmimietz/2537046ca31940c871d92e633dc33923

I think this issue already been fixed ? The reproduce code seems works as expected:

Here's the fix:
Use the . contentShape modifier after the .clipShape modifier.
Ex:
WebImage(url: URL(string: "https://i.imgur.com/s3ptEuh.png")!)
                .resizable()
                .aspectRatio(contentMode: .fill)
                .frame(maxHeight: 400)
                .clipShape(RoundedRectangle(cornerRadius: 10))
                .contentShape(RoundedRectangle(cornerRadius: 10)) // <-- here

Here's the fix:
Use the .contentShape modifier after the .clipShape modifier.
Ex:
WebImage(url: URL(string: "https://i.imgur.com/s3ptEuh.png")!)
                .resizable()
                .aspectRatio(contentMode: .fill)
                .frame(maxHeight: 400)
                .clipShape(RoundedRectangle(cornerRadius: 10))
                .contentShape(RoundedRectangle(cornerRadius: 10)) // <-- here


fix: improve outlook mail search

for gptscript-ai/desktop#199

Converting to draft. There are more improvements I need to make.


Fix typo

Github -> GitHub

Learn Build status updates of commit f9d5f4f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/static-web-apps/nextjs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off