[QUERY] Azure.Storage.Blobs - How are md5 hash's handled?

Query/Question
How are md5 hash's handled withing the library? I see that when I upload to the blob it computes a hash because I see it when I download the blob from storage. Does the library handle comparing the hash to verify the payload or is that something the caller needs to do themselves by md5 hashing the payload after downloading and comparing with the ContentHash received from the download result? I didn't see much or any documentation on this. In the tests files for the SDK itself it looks like it is manually done.
Environment:

Azure.Storage.Blobs latestStable

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Just to be clear, is your question, does the SDK calculate it's own MD5 hash and compare it to the Content-MD5 hash that the storage service returns back in the response headers when you go to download the blob?
Then no, the SDK does not calculate it's own md5 hash and compares it against the one the service returns back. You as the caller will have to calculate the md5 hash and compare it.

Please re-open if you have further questions.


support array properties where order does not matter

right now we only support array properties where order does matter
we could easily support case where order does not matter by just sorting the inputs each time deterministically (that way regardless of what order the input is, it will result in "no change" in the database)

hmmm..... actually, the user can just sort the inputs themselves before calling the upsert fn. thats simpler -> less options to keep track of?
or would it be better to make the user explicitly think about that?


More explanation about middleware and handling meteor reactive data to store

Hi,
This is the best tutorial I found for using redux with meteor, great thanks!
However, I notice that you changed a lot of code since this blog post,
and I can't quite understand how those middleware work...
I've been struggling for days to get meteor to work with redux properly, but still no luck.
Could you explain more on how you handle meteor data pub/sub and store them into redux store with those middleware?
Great Thanks!!
Dax

+1 for example... in meals, on line 11, where do the values for userId and Date come from? Also the comments in the subscription middleware show a slightly different signature to call the middleware then what the actual calls in the app use. Better docs or comments would really help those of us new to gluing all these pieces together (outside looking in).

Sorry guys, I don't have much time these days for this project. I'm waiting for meteor 1.3 anyway and will rewrite a lot of it when it's out. Please be patients :)

Same here... I am under the gun for a client project though and was really hoping to use this middleware because out of everything out there this seems like the right way to go with Meteor as the 'backend'. They won't like it, but I'll have to put them off a bit longer. Thanks for spending some of you valuable spare time trying to help make things better for us all!


login field lacks cursor on first run (even after clicking) on android

Summary
on the first run application asked to login , but the login field wasn't visually in focus (lacked cursor)
Environment Information

Device Name: android
OS Version:
Mattermost App Version: 1.52
Mattermost Server Version: 6.3.3

Expected behavior
login field should be in focus and display cursor on first login or at least when clicked on it
Observed behavior (that appears unintentional)
i tried clicking on "login/email" field many times, changing focus to password and back and it never showed any visual signs of getting focus . however when i realized that the keyboard is present , i started entering login credentials and it worked fine so the issue is just about being visually confusing rather than non-functional

@caryoscelus

What Android version are you on?
Can you (optionally) share a screenshot or a short video of what you're seeing?

10
i can try , but entering a password on the screen is so painful so i'd rather keep myself logged in for a bit

I don't have Android to test this. @enahum @saturninoabril Are you able to help test this on Android?

@jgilliam17 Would you be open to help test this one as well?

@amyblais I've tested on v1.52 (398) on Galaxy A52, Android 12
I've removed the app and started the flow from the beginning download/install, add server and use email and password to login.
Observed: The user name field is not focused, but tapping on the field focuses it and adds a visible cursor.

@caryoscelus Do you see this issue on our community server https://community.mattermost.com/ (it is on the latest server version)?

Closing some older issues. Please re-open this if the issue still reproduces on the latest version (v2.10),


puppet: Increase maximum file descriptors.

The current threshold of 40k descriptors was set in 2016, chosen to be
"at least 40x our current scale."  At present, that only provides a
50% safety margin.  Increase to 1 million to provide the same 40x
buffer as previously.
The 1 million limit is likely far above what the system can handle for
other reasons (memory, cpu, etc).  While this removes a potential
safeguard on overload due to too many connections, due to the longpoll
architecture we would generally prefer to service more connections at
lower quality (due to CPU limitations) rather than randomly reject
additional connections.
Relevant prior commits:

836f313e69e667162e68bd9a8c05bac46729e449
f2f97dd33551dd0556043555047a7e079f7b44ea
ec2399653843382fae1aca3b96420fa622c8c9ca
8806ec698a750aa014a81057b75ade644cce38c2
e4fce10f46022b4776158b476f57eb2b4e0118aa

This will probably necessitate a docker-zulip change similar to zulip/docker-zulip#172.

This will probably necessitate a docker-zulip change similar to zulip/docker-zulip#172.

Thanks!  Pushed that as zulip/docker-zulip#267.

The production suite failures are likely important.

The production suite failures are likely important.

For sure.  Interestingly, they're different between CircleCI and Github Actions.

Welp, this is going to be a bit of a mess.
Bionic and Focal in CircleCI fail to start supervisor, with:

Error: The minimum number of file descriptors required to run this process is 1000000 as per the "minfds" command-line argument or config file setting. The current environment will only allow you to open 1000000 file descriptors.  Either raise the number of usable file descriptors in your environment (see README.rst) or lower the minfds setting in the config file to allow the process to start.

Hm, soooo:
 minimum [...] is 1000000
[...] allow [...] 1000000

Smells like it's hitting some lower kernel-level or virtualization limit?  Github's actions does not hit this limitation.  Some googling points to it perhaps being caused by systemd not respecting limits.conf -- see this debacle of a bug report.  The host of the CircleCI docker instance is potentially being affected by something like this docker-zulip issue, by way of this docker bug.
Even if we're not going to keep using CircleCI, we may need to address this for other Docker usages.  I'll try writing out a /etc/systemd/system.conf.d/limits.conf per this and we'll see if that fixes.
Focal also hits:
Jul 28 02:20:31 Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install postgresql-client' returned 100: Reading package lists...
Jul 28 02:20:31 E: Write error - write (12: Cannot allocate memory)
Jul 28 02:20:31 E: Write error - write (12: Cannot allocate memory)

Which is potentially worrisome, but not worth looking into until the above is fixed, which may also resolve this.

On Github, it gets past both of those points without difficulty.  The failure is that the host seems to not come up cleanly after the PostgreSQL upgrade on Bionic, with supervisor processes complaining:
Jul 29 00:24:37 supervisor: couldn't chdir to /home/zulip/deployments/current/: ENOENT
Jul 29 00:24:37 supervisor: child process was not spawned

...despite /home/zulip/deployments/current/scripts/lib/queue_workers.py having been run moments before.  So the supervisor process is ending up with not enough FDs to chdir or somesuch?  But it has enough to do everything else?  I don't have great ideas about where to start on debugging this.

I've not written a complete commit message for the systemd change; if tests pass, please hold off on merging until I can rework that with more details.

I'd forgotten about this PR (I think I'd imagined we'd already merged it).

It looks like we did update docker-zulip with this: https://github.com/zulip/docker-zulip/commit/5b2ec718b0b4d35e3dc8c77717973f51b65fe753

Tests are now passing, now that we no longer have to fight CircleCI.

I think the main work remaining for this is that we need to make sure it doesn't break docker-zulip; @andersk can you take care of that?

OK, merged, thanks @alexmv!


Email Generation Service

This replaces the email generation worker with an email generation service which will be run regularly using a rake task rather than a scheduled sidekiq job.
The service works by obtaining a Postgres advisory lock, querying on all the subscription contents and building emails and triggering delivery request workers for each of them and then releasing the lock.

@gpeng I've made a few more optimisations since you approved, would you be able to have another look.

Since adding the last few optimisations, I'm able to get the rake task to run just under 5 minutes for 83,333 records! 🎉


Automatically reduce DataFrames

Proposal
When passing a DataFrame into a DataSet where the DataFrame forms a superset of the columns mandated in the DataSet it would be nice to be able to automatically drop the columns for the new object.
Example:
import pandas as pd
from strictly_typed_pandas import DataSet

class Subset(DataSet):
    id: int
    name: str

df = pd.DataFrame({
    "id": [1, 2],
    "name": ["Hans", "Peter"],
    "age": [10, 10]
})

ds = DataSet[Subset](df)

Risk
One might still want to know if a passed DataFrame contained more than the expected columns.

Thanks for the suggestion! I agree with the risk, I probably wouldn't want to make this default behavior...
I do realize it's a pretty common pattern though: you do a bunch of transformations, and then you want to subset to the columns of a schema and cast the type to DataSet[Schema].
In my other package (typedspark: typing for pyspark), we've addressed this with a transform_to_schema(df, schema) function, which does exactly that.
It also can take a third optional argument, which is a dictionary of transformations (i.e. assign() transformations, which we found we needed to do pretty often as well).
This is the documentation
https://typedspark.readthedocs.io/en/1.0.19/transforming_datasets.html
Do you think something like this be interesting to include in strictly_typed_pandas as well? Does this address your question?

Sorry for leaving this dormant for so long. Has this been picked up in the meantime?
I'd think your proposal is the right way to go about this and would like to contribute the PR.


⚠ Bofrost.be has degraded performance

In 8f45779, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2770 ms

Resolved: Bofrost.be performance has improved in 82d5daf.


Validate return statement in functions with named returns

This capability is to be provided by semantic analyzer. So marked as postponed.


Masonary has NaNpx height & margin.

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Masonary doesn't respect the columns refer to the attached image.
The problem seems to be with the height & margin of MuiMasonry-root class.
The height & margin properties have NaNpx value refer to the attached image.
I have changed the spacing to rem like shown in the docs that's the reason for NaN refer to the attached image.
What do you suggest to fix this?

Expected behavior 🤔
It should work like a normal Masonary.
Steps to reproduce 🕹
Steps:

Just copy the masonary from MUI example.
Change the spacing to rem like shown in the attached image

Context 🔦
No response
Your environment 🌎
Using chrome browser

`npx @mui/envinfo`
   System:
    OS: Windows 10 10.0.19044
  Binaries:
    Node: 16.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.18 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1266.0), Chromium (102.0.1245.39)
  npmPackages:
    @emotion/react: ^11.7.0 => 11.9.0
    @emotion/styled: ^11.6.0 => 11.8.1
    @mui/base:  5.0.0-alpha.82
    @mui/lab: ^5.0.0-alpha.80 => 5.0.0-alpha.83
    @mui/material: ^5.6.4 => 5.8.1
    @mui/private-theming:  5.8.0
    @mui/styled-engine:  5.8.0
    @mui/system:  5.8.1
    @mui/types:  7.1.3
    @mui/utils:  5.8.0
    @mui/x-data-grid: 5.10.0 => 5.10.0
    @mui/x-date-pickers:  5.0.0-alpha.1
    @types/react: ^18.0.8 => 18.0.9
    react: ^18.1.0 => 18.1.0
    react-dom: ^18.1.0 => 18.1.0
    typescript: ^4.6.4 => 4.7.2

+1

+1

Any update?


TaffyPager how to sort workspace by Xinerama screen solution

Hello,
I recently discover Xmonad and taffybar, which I both find awesome. However I wonder, how I can have my TaffyPager display the workspace in the order they are displayed on my three screen.
In Xmonad with Xmobar, I use the following config to do that (the magic is done by getSortByXineramaRule):
{-# LANGUAGE FlexibleContexts #-}

import XMonad
import XMonad.Config.Desktop
import XMonad.Hooks.DynamicLog
import XMonad.Config.Azerty
import qualified Data.Map as M
import qualified XMonad.StackSet as W
import XMonad.Layout.LayoutModifier
import XMonad.Hooks.ManageDocks
import XMonad.Util.WorkspaceCompare
import XMonad.Actions.CycleWS

myKeys conf@(XConfig {XMonad.modMask = modm}) = M.fromList $

    [((modm, xK_r),               spawn "rofi -show run"),
     ((modm .|. shiftMask, xK_e), spawn "emacs"),
     ((modm, xK_f),               spawn "firefox"),
     ((modm, xK_g),               moveTo Next EmptyWS),
     ((modm .|. shiftMask, xK_Tab),             moveTo Prev HiddenWS),
     ((modm, xK_Tab),             moveTo Next HiddenNonEmptyWS)]

    ++
    -- mod-{a,z,e} %! Switch to physical/Xinerama screens 1, 2, or 3
    -- mod-shift-{a,z,e} %! Move client to screen 1, 2, or 3
    [((m .|. modm, key), screenWorkspace sc >>= flip whenJust (windows . f))
        | (key, sc) <- zip [xK_a, xK_z, xK_e] [0..]
        , (f, m) <- [(W.view, 0), (W.shift, shiftMask)]]

toggleStrutsKey :: XConfig t -> (KeyMask, KeySym)
toggleStrutsKey XConfig{modMask = modm} = (modm, xK_b )

myPP = defaultPP
  {
    ppCurrent = xmobarColor color "". ("*"++),
    ppVisible = xmobarColor color "",
    ppSort = getSortByXineramaRule
  }
  where
    color = "green"

myXmobar :: LayoutClass l Window
       => XConfig l -> IO (XConfig (ModifiedLayout AvoidStruts l))
myXmobar conf = statusBar "xmobar" myPP toggleStrutsKey conf

main = xmonad =<< myXmobar desktopConfig
    {
        terminal    = "urxvtc",
        logHook     = dynamicLogXinerama,
        modMask     = mod4Mask,
        keys = \c -> azertyKeys c `M.union` myKeys c `M.union` keys desktopConfig c,
        borderWidth = 3
    }

I took a look a bit at the code and I have the impression that sadly in order to do that, the PageHinter hooks would need to be modified.

This would require a complete rewrite (pretty much). I think that it wouldn't be that hard to do with the new WorkspaceHUD module. You would definitely still need to modify the code somewhat.

Closing in favor of #96


usage issue with multiprocessing pool.map

Describe the bug
rdMolDescriptors.CalcNumAtomStereoCenters doesn't seem to work in multiprocessing pool
To Reproduce
import pandas as pd
from rdkit import Chem
from rdkit.Chem import rdMolDescriptors
import multiprocessing as mp
smiles_list=['CCCC','CC@HCC']
mols=[Chem.MolFromSmiles(m) for m in smiles_list]
df=pd.DataFrame(mols,columns=['mol'])
def mol_props(mol):
NumStereocenters=rdMolDescriptors.CalcNumAtomStereoCenters(mol)
return NumStereocenters
def mol_to_smiles(mol):
smiles=Chem.MolToSmiles(mol)
return smiles
for idx, compound in df.iterrows():
print(mol_props(compound['mol']))
print(mol_to_smiles(compound['mol']))
with mp.Pool(mp.cpu_count()-1) as pool:
smiles_list = pool.map(mol_to_smiles, df.mol.tolist())
with mp.Pool(mp.cpu_count()-1) as pool:
props = pool.map(mol_props, df.mol.tolist())
Expected behavior
The code above should return a list of props, in this case the number of stereocenters in each molcule
Screenshots

Configuration (please complete the following information):

RDKit version: 2023.03.1
OS: WSL2 Ubuntu 22.04
Python version (if relevant): 3.11.3
Are you using conda? yes
If you are using conda, which channel did you install the rdkit from? -conda-forge
If you are not using conda: how did you install the RDKit?

Additional context
From the code above, passing mol objects to mol_props using a multiprocessing pool fails.  Doing the same thing to return the smiles works fine, to include returning the stereochemistry on the second molecule.  Calling each function in the for loop works fine.

This is because pickling Mol objects (which occurs when you use multiprocessing) does not preserve atom properties by default. You can either call: Chem.SetDefaultPickleProperties(Chem.PropertyPickleOptions.AllProps) before you use pool.map or in your mol_props function you can call: Chem.AssignStereochemistry(mol, flagPossibleStereoCenters=True).

@pwging13 this is working as expected, as @bwhall61 explained. You can also use PropertyMol objects instead of Mol, without setting this globally. PropertyMol objects always serialize their properties. You can convert regular Mol by using PropertyMol(mol).
Can this be closed then?


Code generation build task

Hi,
I would like if is possible to create a build task (that can be added to project with a nuget package) to add some code generation like your project "Attribute Code Generation" does, so javascript C# objects can be written correctly, according to Jurassic coding philosophy.
Thanks.

Yes it's possible.  I haven't fully figured out how I want this to work yet.  I know I don't like the existing run-time method using reflection.  I'm still some way away from completing ES6 support, so we'll see how it pans out.


Avoid duplicating memory for tied weights in dispatch_model

@Giuseppe5 noticed that dispatch_model does not preserve tied weights during its call, although retie_parameters as the end so the end model dispatched model preserves tied weights.
This results in possible large memory spike during dispatch_model in case many weights are tied. The core issue in init_hook and set_module_tensor_to_device is:
import torch
import torch.nn as nn
from collections import OrderedDict

model = nn.Sequential(
    OrderedDict(
        [
            ("linear0", nn.Linear(4, 4)),
            ("linear1", nn.Linear(6, 6)),
            ("linear2", nn.Linear(4, 4)),
            ("linear3", nn.Linear(6, 6)),
        ]
    )
)
model.linear2.weight = model.linear0.weight
model.linear2.bias = model.linear0.bias

old_value0 = getattr(model.linear0, "weight")
old_value2 = getattr(model.linear2, "weight")
print("on cpu linear0:", old_value0.data_ptr())
print("on cpu linear2:", old_value2.data_ptr())

model[0]._parameters["weight"] = old_value0.to("cuda")
model[2]._parameters["weight"] = old_value2.to("cuda")

print("on cuda linear0:", model.linear0.weight.data_ptr())
print("on cuda linear2:", model.linear2.weight.data_ptr())

# Printing
# on cpu linear0:<PHONE_NUMBER>1568
# on cpu linear2:<PHONE_NUMBER>1568
# on cuda linear0:<PHONE_NUMBER>32672
# on cuda linear2:<PHONE_NUMBER>33184

This PR proposes to keep track of a dictionary tied_params_map that maps the model's data pointers to tied parameters to a dictionary that maps devices to dispatched data.
When a tied weight has already been dispatched, we can reuse the dispatched data for the other tied weights instead of allocating memory (as currently).
@muellerzr @SunMarc What do you think? Do you see a more elegant solution?
@SunMarc suggested
model.linear0.weight.data = model.linear0.weight.to("cuda")
model.linear2.weight.data = model.linear2.weight.to("cuda")

but I did not manage to have this work, the new_value here always points to a different data pointer, despite the old_value being shared, see:
device_map OrderedDict([('linear0', 0), ('linear2', 0), ('linear1', 1), ('linear3', 1)])
---- call attach_align_device_hook_on_blocks linear0
old_value dataptr 115696640
new_value dataptr<PHONE_NUMBER>98080  <----------------- here
new_value dataptr after param_cls<PHONE_NUMBER>98080
module weight data_ptr after add hook<PHONE_NUMBER>98080
---- call attach_align_device_hook_on_blocks linear1
old_value dataptr 118073344
new_value dataptr<PHONE_NUMBER>27168
new_value dataptr after param_cls<PHONE_NUMBER>27168
module weight data_ptr after add hook<PHONE_NUMBER>27168
---- call attach_align_device_hook_on_blocks linear2
old_value dataptr 115696640
new_value dataptr<PHONE_NUMBER>98592  <----------------- here
new_value dataptr after param_cls<PHONE_NUMBER>98592
module weight data_ptr after add hook<PHONE_NUMBER>98592
---- call attach_align_device_hook_on_blocks linear3
old_value dataptr 114558400
new_value dataptr<PHONE_NUMBER>27680
new_value dataptr after param_cls<PHONE_NUMBER>27680
module weight data_ptr after add hook<PHONE_NUMBER>27680

It's not clear to me why this is not the same pointer, I could not reproduce locally. Maybe some PyTorch issue.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc It appears that disk offloading with tied weights uses more memory than needed as well: the new_value data_ptr here is not the same as for the other tied weights.

An other (better) option could be not to offload at all tied weights which have an other shared weight already on device

This should already be the case no when we infer automatically the device_map no ?

@Giuseppe5 @SunMarc The cpu offloading case is now working well. See below for the motivation of the changes in set_module_tensor_to_device, and the comments for the changes in pre_forward, post_forward.

@SunMarc The disk offloading case is a bit more tricky, as we have no reliable way to know the cpu pointer to tied weights. This is fixed in https://github.com/huggingface/accelerate/pull/2330/commits/30631a65be7bd7c35952a327693ff88fc1e76887, see comments there.

Looks like this is causing a test to fail @fxmarty (cc @SunMarc):
FAILED tests/test_big_modeling.py::BigModelingTester::test_dispatch_model_tied_weights_memory_with_nested_offload_disk

It fails on the single-GPU runner

@muellerzr thanks will fix


Create 221022-retweet-shibcmemes-meme.tweet

Sorry for any mess I might have made with this - I am but a simple shib, still learning how to do serious things :)

https://github.com/ethereumclassic/tweets-etc_network/issues/90#issue-1406968465
"presumably with less restrictions and more memes and/or project promotion."
I am glad you think it's funny - I didn't mean to be rude (we're clean and tidy and do respect the "lawn").
It's both intended as a light hearted meme and some promotion for both the eco and SHIBC.
I fail to see how "ETC is a gift from God" is any better, divisive, really.

When submitting tweets from #ETCtweets, please copy the content of the tweet rather than retweeting.

I think this would be OK if it was specific to ETC rather than Shiba Classic.

It tells the world why we're here. on ETC, and why that's important
Code is Law isn't a slogan or a meme, it's a righteous statement and commitment - it's serious.
I don't consider it a gift, but a responsibility.
That's the juxtaposition - the serious meme, and SHIBC intends to "bark" this at everyone.
No disrespect was intended with this, just some meme flavour, ie: coleslaw, code is lawn, etc.

It tells the world why we're here on ETC, and why that's important

This twitter account is about Ethereum Classic itself, and we are avoiding promoting third party projects unless linked to via the ethereumclassic.org website, as it contains disclaimers.
It would be fine if it wasn't promoting Shiba Classic.

This twitter account is about Ethereum Classic itself, and we are avoiding promoting third party projects unless linked to via the ethereumclassic.org website, as it contains disclaimers.

So it's a centralised thing to go through another centralised thing to hit Twitter, which is more decentralised than both 1) applying for the website (which we'll do, sure) and 2) using this repo, something you put on Twitter to encourage engagement with - which I have!
Today I've uploaded all of the great SHIBC memes and ETC resources to GitHub so other people can do the same for whatever they are working on, and continue to grow and promote the ecosystem - hopefully this can benefit the eco in itself.
But where does promoting God fall into this? Which God? Religious baiting is some of the most known troll activity on the internet (even asking this, I feel like I'm trolling). That's the optics of that Tweet.
It completely undermines the effort and dedication to maintaining "Code is Law" - it wasn't a gift, it was responsibility forced when a centralised group decided to roll back what was meant to be immutable, few people stood up and more continue to join - that's more righteous than any religious/God based crusade I've ever learned of.
You could interact with projects on your ecosystem instead you're gatekeeping even retweeting a meme.

IMO it would be fine if it wasn't promoting Shiba Classic.

It promotes ETC and SHIBC, and ETC is first - it's not my fault this dawgy can poop gems, again, we tidy up after it, we bring our bags.
I close this out with this, at this point, I don't even care for the meme. It's not even funny.


Shapehelper reorg: add ShapeHelper for Einsum, OneHotEncoder, isNan, RandomLike, Reductions

Added shape inference ShapeHelper framework for the ops listed above. They used to compute shape inference without the framework.
In addition, removed the #define for Pooling ops, using template instead

Jenkins Linux amd64 Build #9005 [push] Shapehelper reorg: add S... started at 01:18

Jenkins Linux ppc64le Build #8071 [push] Shapehelper reorg: add S... started at 02:22

Jenkins Linux s390x Build #9021 [push] Shapehelper reorg: add S... started at 02:18

Jenkins Linux amd64 Build #9005 [push] Shapehelper reorg: add S... passed after 1 hr 30 min

Jenkins Linux ppc64le Build #8071 [push] Shapehelper reorg: add S... passed after 1 hr 55 min

Jenkins Linux s390x Build #9021 [push] Shapehelper reorg: add S... passed after 2 hr 22 min


update the development.md docs to use the Makefile

the makefile in the repo should drive the development flow

I suggest we remove this makefile since the template project (that we cloned) https://github.com/subsquid-labs/squid-substrate-template#squid-template-project also is not using it anymore. I hardly see makefiles being used in js/ts projects.


Fix type definition to allow use unknown, stopEarly, --

See https://github.com/microsoft/TypeScript/issues/17867 for more info.

Thanks!

https://github.com/vadimdemedes/minimist-options/releases/tag/v4.0.2


GCS artifact loading fails if key is a directory

BUG REPORT
What happened:
After switching from minio to GCS, workflows which tried to load "directory" from GCS as a artifact started to fail with message failed to load artifacts: The specified key does not exist..
What you expected to happen:
To be working the same way as minio does.
How to reproduce it (as minimally and precisely as possible):
Try to run this step on minio and then on GCS. Notice that the key is pointing to the "directory", not a specific file.
Possible cause:
I believe this is caused by the fact that minio returns empty object when you try to access directory object.
GCS returns 404 => The specified key does not exist.
- name: example
    inputs:
    artifacts:
        - name: directory
        path: /directory/
        s3:
            endpoint: storage.googleapis.com
            bucket: bucketname
            key: directory
            accessKeySecret:
            name: gcs-secrets
            key: accessKey
            secretKeySecret:
            name: gcs-secrets
            key: secretKey

Anything else we need to know?:
Environment:
argo: v2.2.1
  BuildDate: 2018-10-11T16:25:59Z
  GitCommit: 3b52b26190163d1f72f3aef1a39f9f291378dafb
  GitTreeState: clean
  GitTag: v2.2.1
  GoVersion: go1.10.3
  Compiler: gc
  Platform: darwin/amd64

Kubernetes version :

$ kubectl version -o yaml
clientVersion:
  buildDate: 2018-08-20T10:09:03Z
  compiler: gc
  gitCommit: 0c38c362511b20a098d7cd855f1314dad92c2780
  gitTreeState: clean
  gitVersion: v1.10.7
  goVersion: go1.9.3
  major: "1"
  minor: "10"
  platform: darwin/amd64
serverVersion:
  buildDate: 2019-04-04T03:12:09Z
  compiler: gc
  gitCommit: b80664a77d3bce5b4701bc881d972b1a702290bf
  gitTreeState: clean
  gitVersion: v1.12.7-gke.7
  goVersion: go1.10.8b4
  major: "1"
  minor: 12+
  platform: linux/amd64

BTW, are there any files in that directory? What happens if you remove the training slash from the path?

I also had this bug.
Here's a reproduction example:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: arguments-artifacts-
spec:
  entrypoint: kubectl-input-artifact
  arguments:
    artifacts:
    - name: kubectl
      s3:
        endpoint: storage.googleapis.com
        bucket: gcp-public-data-landsat
        key: LC08/01/044/034/LC08_L1GT_044034_20130330_20170310_01_T2
        accessKeySecret:
          name: argo-cred
          key: accesskey
        secretKeySecret:
          name: argo-cred
          key: secretkey

  templates:
  - name: kubectl-input-artifact
    inputs:
      artifacts:
      - name: kubectl
        path: /usr/local/bin/kubectl
    container:
      image: debian:9.4
      command: [sh, -c]
      args: ["ls -l {{inputs.artifacts.kubectl.path}}"]

I get a different error:
Failed to test if gcp-public-data-landsat is a directory: A header or query you provided requested a function that is not implemented.
And I'm using argo 2.3.0

This error is from s3.IsDirectory in it's call to minioClient.ListObjectsV2
https://github.com/argoproj/pkg/blob/38dba6e98495680ff1f8225642b63db10a96bb06/s3/s3.go#L167
ListObjectsV2 is not supported by GCS interop API
Here's a short Go program to reproduce that error:
https://gist.github.com/bakennedy/7dc26af9e1c76d8940221786e1c3c7a9
minioClient.ListObjects is supported by GCS, and it returns the same type.  Would this work as a replacement in pkg/s3.IsDirectory?

@bakennedy - it seems like it's expecting some kind of continuation token -- https://github.com/minio/minio/commit/3ec4738955bb60c60832abceabf84d4ec22986da

Meantime workaround - grab all the artifacts from the workflow and decompress them into a temporary folder, then repackage it back out as a single artifact:
  - name: reduce
    activeDeadlineSeconds: 60
    retryStrategy:
      limit: 2
    outputs:
      artifacts:
      - name: reduce
        path: /tmp/reduce
    script:
      volumeMounts:
      - name: gcs-key
        mountPath: /var/secrets/google
      image: google/cloud-sdk:alpine
      command: ["/bin/bash"]
      source: |
        mkdir -p /tmp/reduce
        mkdir -p "/tmp/{{workflow.name}}"
        gsutil -q -m -o Credentials:gs_service_key_file=/var/secrets/google/key.json \
             -o GSUtil:parallel_thread_count=8 \
             cp -r "gs://{{workflow.parameters.bucket-name}}/{{workflow.name}}" "/tmp/{{workflow.name}}"
        find "/tmp/{{workflow.name}}" -name '*.tgz' -exec tar -C /tmp/reduce -zxf '{}' \;

  - name: echo
    inputs:
      artifacts:
      - name: reduce
        path: /tmp/reduce
    script:
      image: alpine:3.7
      command: [find, /tmp]

Closed inadvertently via merge of https://github.com/argoproj/pkg/pull/6. This needs to remain open until dependencies are updated

@downchuck thank you for the work around suggestion, and @jessesuen thanks for an expeditious merge! We're doing genre sequencer research, and using a lot of huge files. This will really help us out.


Structural adjustments

Here's your first PR :+1:. let me know if you'd like anything adjusted.

aww. second rather.

Thanks!LGTM
Would you add your favorite repository(s) to repository.json?
So that the repository will get stars, if you want.

totally!

Thanks!


Usability Check Bitcoin Tribe

CTA should be bottom-aligned (S&R)
Font
Toast message
Alignment of Small device VS Large

Can I work on this ?

To be done on Live @Deveshshankar

Completed


Making bookmarks public seems to fail

It looks like bookmarks can't be newly marked as public if you've explicitly setup your account to disable public bookmarks. Right now this failure seems to be silent, so it's important to see if it's possible to surface this error to users to at least help them understand what's going on.

This seems to be a limitation of the Pinboard API.


RSS and/or «Pocket» sync.

Please, could you implement a function to update reading list automatically? I've found this addon just right now and I was surprised that someone use this technique (it even has its own name). However, personally I really don't like to copypaste anything, wasting too much time. Is there a possibility to make it synchronize with RSS… For your reference:
— https://github.com/luminousspice/anki-addons (see «FeedToAnki»)
…or «Pocket» service? If you're not familiar with it, it's pretty mainstream tool to save articles you like to read them later. It's built into firefox by default and has a chrome addon.
— https://getpocket.com/
I hope it's possible. The pocket saves all the articles to its own domain, so all of them are unified to read/crawl by some beautifulSoup library or something like that.

Hi,
I started working on an RSS importer a while ago, and it's certainly something I'd like to share once it's ready. However, it's going to be another couple of months before I have a chance to finish it off - I'm bogged down with study at the moment.
I'll leave this issue open for now, and I'll post back here when I have an update.
Thanks for letting me know there's demand for this.

hey, any news here? :3

Hi,
Sorry for the late reply. Exams took over my life for a while.
I plan to resume working on this sometime next week. I'll post here again when there's something to try.

Although RSS would be fine, please, take a look at «pocket» service too. If the plug-in could parse it, it would be really-really awesome. Wish I could help, but I'm just a python newbie yet.

I agree with your argument. The only reason I plan to implement RSS first is because I've already written most of the code for it. I imagine there'd be a lot of overlap between the two anyway, so solving one problem should half-solve the other.

hi there. I know, we all have some private things to do, but how is the progress on it? with rss and pocket your plugin would be a truefire.

Hi again. Thanks for your interest.
It took longer than expected to make the add-on compatible with Anki 2.1, and that was the first priority.
Once that was done, I added basic support for importing a webpage, since that code will be required for RSS import. The code for RSS has been (mostly) written, it just hasn't been incorporated into the add-on yet. I'm planning to have it done in the next couple of weeks.
Importing from Pocket will take a bit longer, since I need to write some UI code for that. Apart from that, it should share a lot of the code that's already been written.

Support for importing RSS has been added to the Anki 2.1 version. It's a little rough around the edges, but there aren't any major issues. As long as the URL starts with http:// and the website doesn't reject a Python user agent, it seems to basically work. I tried 10 different feeds, and only 1 of them didn't work.

Awesome, thanks. Can't wait for «pocket» support :3

checking this thread with great expectations

This is 99% done. I will have something for you to test tomorrow, most likely.
This took such a long time because (a) Anki 2.1 hasn't completely stabilised, so I've been struggling just to keep the existing features working, (b) the Pocket API was a bit of a hurdle to figure out, and (c) I've been fairly busy with other things. But thanks for your continued interest.

This is implemented now. Please let me know how it goes.
At the moment, it can only be used to import the 10 newest articles in your reading list. I will need to put some options in menu, or allow the user to select which articles to import - but until then, can you just let me know if it basically works?

I'm going to close this for now. I plan to move all the options into the menu at some stage, but it may not be for another month or so.
If you run into any bugs or have any feedback, feel free to open another issue.

Just noticed your answer here. I'm going to test it this evening, and it's exiting to know that you've done with this feature. Thanks a lot.


[feat] possibility to set Processing, please wait ... in config

the configuration loading_text can help you?

Yes, it works!


Unexpected SELECT * with Join

Steps to reproduce the behavior
SELECT * FROM (SELECT 1 AS id, 2 AS value) ANY INNER JOIN (SELECT 1 AS id, 2 AS values) USING id;
Expected Result
1    2    2
Actual Result
1    2

Yes, this is weird, but this behaviour is documented and works according to documentation:

All columns that are not needed for the JOIN are deleted from the subquery.

subquery here is right part of join. Currently you have to specify all required columns.

I am currently trying to fix this problem, but it is not compatible with the version.

It is same problem


update geo-types

geo_types now require that Coordinates hold a CoordNum (or it's extension CoordFloat), which is also Debug.
also: num_traits is now only exposed in tests, so moved it to a devDependency.

bors r+

bors r+


🐛 [Bug] Tuple input not supported

Bug Description
tuple inputs not supported? version release v0.3.0
To Reproduce
I use tuple and dict as inputs in submodule but not the main module. I also tried the torch_fallback feature, which did no help.
error trace as below:
~/.local/lib/python3.6/site-packages/trtorch/_compiler.py in compile(module, compile_spec)
     71             "torch.jit.ScriptFunction currently is not directly supported, wrap the function in a module to compile")
     72
---> 73     compiled_cpp_mod = trtorch._C.compile_graph(module._c, _parse_compile_spec(compile_spec))
     74     compiled_module = torch.jit._recursive.wrap_cpp_module(compiled_cpp_mod)
     75     return compiled_module

RuntimeError: tuple appears in op that does not forward tuples, unsupported kind: prim::ListConstruct

Can you provide the source graph or a example that replicates the issue? Seems like the error is coming from somewhere within PyTorch

import torch
import torch.nn as nn
from typing import Tuple, Dict, List
from torch import Tensor

class Model1(nn.Module):
    def __init__(self):
        super(Model1, self).__init__()
    def forward(self, inputs: Tuple[Tuple[Tensor], List[Tuple[Tensor, Tensor]]]):
        x, y = inputs
        return x, y

class ExportModel(nn.Module):
    def __init__(self, model):
        super(ExportModel, self).__init__()
        self.model = model
    def forward(self, x1, x2, x3):
        tuple_: Tuple[Tuple[Tensor], List[Tuple[Tensor, Tensor]]] = ((x1,), [(x2, x3)], )
        outputs = self.model(tuple_)
        return outputs[1]

export_model = ExportModel(Model1())
torch_script_module = torch.jit.script(export_model)

input_list = [torch.tensor([[1,2,3]]), torch.tensor([[1,2,3]]), torch.tensor([[1,2,3]])]

result = torch_script_module(*input_list)

input_shape = []
for input in input_list:
    input_shape.append(input.shape)

compile_settings = {
    "input_shapes": input_shape,
    "op_precision": torch.float32, # Run with FP16,
    "torch_fallback" : {
      "enabled" : True,
      "min_block_size" : 1
    }
}
trt_ts_module = trtorch.compile(torch_script_module, compile_settings)
result = trt_ts_module(*input_list)
torch.jit.save(trt_ts_module, "trt_torchscript_module.ts")

The code above will cause this error

Noticed a couple things with this issue. The root cause of the error you observed is because we run this lowering pass on the graph: https://github.com/pytorch/pytorch/blob/4cb534f92ef6f5b2ec99109b0329f93a859ae831/torch/csrc/jit/passes/lower_tuples.h#L15
It doesn't support graphs whose inputs contain tuples.
If we switch to a less restrictive version of this pass we will get the same kind of issue as the other issue (#475) because the graph lowered graph is trivial:
graph(%x1.1 : Tensor,
      %x2.1 : Tensor):
  %3 : (Tensor) = prim::TupleConstruct(%x2.1)
  %4 : (Tensor)[] = prim::ListConstruct(%3)
  return (%4)
(CompileGraph)

TRTorch wont do anything here, theres no operators for TensorRT to run. Again it would be good to have a less contrived example is its easier to see if the workflow you are looking for has some significant roadblock. As for tuple inputs they will be implemented with #428

So lets merge #475 here.

I make a simple example to reproduce my error, this is a simplified version. The original version would have an input like Tuple[Tuple[Dict[str, Tensor], Dict[str, Dict[str, Tensor]]], Tensor, Tensor, Tensor, Tensor, List[Tuple[Tensor, Tensor]]]. I cannot modify this complicated input.
I can run this model with torchscript smoothly but not trtorch. This makes me confused as I just think trtorch is a stronger torchscript compiler for nvidia gpu.
So can we cover these cases?

TRTorch is a torchscript compiler but its subject to the limitations of TensorRT. So anything function run in TensorRT needs to take the form func([Tensor]) -> [Tensor]. We are working on allowing the compiler to reduce various groupings of Tensors to reduce to this form in #428. But the overarching limitation of TensorRT will still mean all inputs and outputs are Tensors. Things like Dicts are probably not going to be supported by TensorRT components. Partial compilation would be the method to potentially solve this but its still pretty unstable.


Localied urls

Hello, thank you for the great starter.
Is it possible somehow to localize slugs for pages when using src/pages/[lang]/contact.astro  so I can open the page with /en/contact and /de/kontakt somehow and both would use the same .astro file ?
Thanks

I think it's possible. By using getStaticPaths() within src/pages/[lang]/contact.astro, you can generate HTML for the contact page in each language from a single file.
You may want to refer to src/pages/[lang]/index.astro or src/pages/[lang]/404.astro as examples.
Here is a sample:
---
import { localeParams, useTranslations, type Lang } from "@/i18n";
import Layout from<EMAIL_ADDRESS>const t = useTranslations(Astro.currentLocale as Lang);

const title = t({
  ja: "お問い合わせ",
  en: "Contact",
  "zh-cn": "联系我们",
  ar: "اتصل",
});

export const getStaticPaths = () => localeParams;
---

<Layout {title}>

      {title}

      {
        t({
          ja: "お問い合わせはこちらから",
          en: "Contact us here",
          "zh-cn": "请通过此处联系我们",
          ar: "اتصل بنا هنا",
        })
      }

    <form>...</form>
</Layout>


Add solutions and explanation of various questions asked in competitive programming platforms like Codeforces, Codechef etc.

The question and explanation can be found in the .md file, and the solution will be available in .cpp file.

The problems must be of medium/hard level. Try to implement on your own.
Note :

Separate Folder must be created for each platform and the question link/text must be there in the comments/md file.
Try not to copy solutions.

@Vishal1003 do i create pull request for every problem i solve ?


Do we have oak wilt in the plot?

From C. Dow:
Phil Marshall, the forest health specialist in Indiana who helped me a ton with the chestnut oak decline, agreed that the pictures I sent are all consistent with oak wilt. Virginia DOF officially maintains that there is no oak wilt in VA, but the range map for oak wilt stops at the VA state line, so not sure. Shenandoah NP has seen similar symptoms but assumed it was leaf scorch - say they will try to get some testing done.

I think Rachel mentioned that she'd found a few oaks which were labeled as healthy last census but were suddenly doing very poorly this year. I think she said she just assumed they were mislabeled last year. If i'm remembering that right, those would be the first trees i'd check up on!

I just wrote Lori Chamberlin and Katlin Mooneyham at VA DOF to see what they know about this.

Some useful information for identifying Oak Wilt:
https://extapps.dec.ny.gov/docs/lands_forests_pdf/oakwiltusda.pdf
https://ohioline.osu.edu/factsheet/plpath-tree-02


Minor bugfixes in the support to different encodings

Please cherry pick this pull request and ignore the changes in the compiler.py. The other changes are all related to minor bugfixes in the support to different encodings.
The main change is to always use the encoding defined in the settings (default: utf-8). Before this fix we had some problems writing unicode strings with special characters to the database and also in the introspection when the fields contains special characters.

Closing since there are open conflicts with master that would need to get resolved before merging.


Merge Channel Name feature to main

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-eventgrid

/azp run python - eventgrid - tests

/azp run python - eventgrid - tests


App icon change

update

Please remove the references to Autotune and basal profile etc which you copied from
AutotuneConfig, those are not needed. Please revert the changes you made to iPhone deployment version. Please add a screenshot here for the new app icon config. I would like to see how it looks.

APP_DISPLAY_NAME = FAX AppIcon
This is name of the app in iOS.

Needs some cleaning and refactoring. What does the Test 2.png:s do? Shouldn't it be deleted? Could you please post some screenshots of how the config icon UI Looks like? You have translated the new source string to "AppIcon Wechseln" for every language. You need to create a new config for Icon change instead of using the autotuneConfig. You changed the HomeRootView Icons for Carbs and Settings.

Hi @Jon-b-m, thanks for the remarks. Testimages have been removed. The view has been implemented and reference to autotuneconfig has been removed. HomeRootView icons have been reverted to default.
I've doubts regarding the translation? What is your recommendation to translate the view into the existing languages?
Regards,
becksen.

APP_DISPLAY_NAME = FAX AppIcon This is name of the app in iOS.

Displayname has been reverted to FAX default delivery.

Please remove the references to Autotune and basal profile etc which you copied from AutotuneConfig, those are not needed. Please revert the changes you made to iPhone deployment version. Please add a screenshot here for the new app icon config. I would like to see how it looks. I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?

References have been removed.
Not 100% what you mean by
"I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?"
BR
becksen

Not 100% what you mean by "I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?"
BR becksen

You hard coded the default App Icons to "AppIcon". Before it was a variable you could change in Config and ConfigOverride. Remove this change, please.

Still a lot of test icons. I don't understand the need for those?
I've removed all testicons. Just a number of different icons have been created as alternative. Being able to change the default purple icon, which is also available in xcassets, the other icons have to be available as well in xcassets. Else you wouldn't have alternative to change to. Hope this is clear now.

The grey test Icons "named Test..." are still there. I have the BW and the purple images already, so you shouldn't have to convert and reduce the resolution? And the other icons are not clean and crisp now. Pixels (noise) in wrong colours and blurry.

The grey test Icons "named Test..." are still there. I have the BW and the purple images already, so you shouldn't have to convert and reduce the resolution? And the other icons are not clean and crisp now. Pixels (noise) in wrong colours and blurry.

This is a wrong assumption. Purple and Black is already there, but I haven't touched them. This is from original repo. I assume it is not sufficiently assigned. Means there is just one icon for iOS the others are all mapped to MacOS. My new icons have been properly sized and assigned. Hence

they look better when scaled in SwifUI. I can change it for the default icons Purple and Black/White when accepted.

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

Are the Watch Icons changed also with this setting?

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

I've cleaned it up. All Icons contain Test or Test2 have been deleted. I don't see it anymore in the fork.

Are the Watch Icons changed also with this setting?

No didn't find any way to do it for watchOS. Only the app icon on iPhone is changed.

Are the Watch Icons changed also with this setting?

No didn't find any way to do it for watchOS. Only the app icon on iPhone is changed, affected

You change the Watch Icons in Xcode here:

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

I've cleaned it up. All Icons contain Test or Test2 have been deleted. I don't see it anymore in the fork.


Multiplayer Projectile Weapons using Projectile.NewProjectile() not syncing until dropped on the ground.

Description

When using any king of projectile weapons that spawn in new projectiles using Projectile.NewProjectile() method the projectiles are not being synced in the world, this causes the world / server not to recognize the shots fired, dropping the weapon and picking it up again however seems resolve the issue until reforging and/or leaving and rejoining the server.
Steps to Reproduce

Join a multiplayer server.
Get a weapon that spawns a new projectile  utilizing the Projectile.NewProjectile() in the shoot function of a weapon.
Shoot any spawned enemy it will not hit them at all.
Drop the weapon.
Shoot any spawned enemy it should now hit them correctly.

Expected behavior
The projectile spawned by Projectile.NewProjectile()  should damage any enemy without requiring it to be dropped at first hand.
Actual behavior
The projectile spawned by Projectile.NewProjectile() ignores the enemy.
Reproduction frequency
This issue seems to be at hand with various mod, ranging from spirit mod, to cheeze's content pack.
Versions
This issue has been apparent ever since I started using tModloader arround 0.8 and now at version <IP_ADDRESS> it's still apparent.
Mods
It happens with a variety of mods, even when my own mod (cheeze's content pack) is the only one loaded.
Additional Information
It has to be in multiplayer.

I'm guessing the way you set owner in NewProjectile is wrong.  Use Main.myPlayer. if that is not the issue, seek help in the Terraia community forum or the tmodloader discord, this is not the place for getting help with programming. This is for actual tmodloader bugs.


Add Provider<Collection> getElements() to DomainObjectCollection to lazy map/transform its elements

Expected Behavior
val myDomains = objects.domainObjectSet(String::class)
val outputProvider = objects.listProperty(String::class)

// actual, there is no method, but you could accidentally use the `map` method of Kotlin, which is wrong
outputProvider.set(myDomains.map { "$it$it" })// this `map` is part of Kotlin stdlib Collection.map which maps the realized elements, and it is not a provider

// expected
outputProvider.set(myDomains.elements.map { it.map { "$it$it" }}) // lazily transform the elements

myDomains.add("foo")
println(outputProvider.get()) // expected "[foofoo]"

// works with
inline val <reified T : Any> DomainObjectCollection<T>.elements: Provider<out Collection<T>> get() = project.provider {
    toList()
}

Current Behavior (optional)
No lazy method to transform a DomainObjectCollection without realizing it. You can write an getElemets function by yourself easily, but I expect a built-in solution.
There is also already a FileCollection.getElements() to support the same use-case, lazily mapping its content.
Context
I want to pass a DomainObjectCollection of an extension to a Java SourceSet. The domain of the collection contains a task provider as member, so I need to map the collection to its member.
The SourceSet supports Provider<Iterable<TaskProvider> as input, but there is no lazy option to map the collection. If you accidental use map of the Kotlin stdlib, you are realizing the collection early, resulting into a empty list, because the domains of the collection are added lazily later (using register).
So you need to get the elements of the collection lazily as Provider.

Thank you for your interest in Gradle!
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

Thank you, we think it is a valid feature request. The issue is in the backlog of the relevant team, but the existence of a workaround makes it non-critical, so it might take a while before a fix is made.


Dashboard not always accessible with Safari

Bug description
Sometime I have issues with Safari and opening the dashboard. It always switches between online and offline. And if it is shown as online most parameters are missing.
I use Hornet version 1.0.1.
MacOS Big Sure 11.3 (20E232)
Tell me if I can provide further information.

Are there any errors logged on the dev tools?

Sorry for my late reply. I'm not familiar with the Safari dev tools. Where should I look?

Still got the same problem. Can we provide any data for you obany? You just have to tell me where to look in the dev tools. Not experienced in this. Thx! Chrome on MacOS is working perfect btw. Only a Safari issue.

We need to check if this is still the case with 2.0.0-rc.1.

Seems to be fine. I never haven't had any problems in months 🤔


ci: update error reference docs

This PR is auto-generated by a nightly GitHub action to update the error reference docs from source code in withastro/astro.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
reference/error-reference.mdx
Source changed, localizations will be marked as outdated.

en
reference/errors/get-entry-deprecation-error.mdx
Source added, will be tracked.

en
reference/errors/unknown-filesystem-error.mdx
Source added, will be tracked.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Renamed EventKind to PinEvent

EventKind seems reasonable, but there could be other future event types for things like SPI, I2C, UART, etc. that is mentioned in planning.  This PR renames pin event related code to more specifics.
cc: @edgardozoppi, @ianhays

Thanks. This seems reasonable


Your Password does not Satisfy the Current Policy Requirements

System information:

Windows 10 19043.1165 21H1
<IP_ADDRESS>108310918

Describe the problem you're observing:
When you try to create user with validating password plugin (validate password as example) you get error from title.
It appears because of generated code to create user.
Steps to reproduce, if exist:
I think it will work at any setup with this type of plugins but in my case i use this setup:
docker container with percona/percona-server with installed validate password (as plugin or as component)
Try to create new user with password that satisfy policy, as example 'P@ssw0rd'.
In generated code first line will be create user but without password <- this cause of error.

@efimov90 what database do you use?

percona/percona-server docker image
version 8.0.25-15
version comment Percona Server (GPL), Release 15, Revision a558ec2

what driver do you use?
could you provide the generated script?

Driver in connection: 'MySQL'
Generated script is:
CREATE USER 'test'@'%';
ALTER USER 'test'@'%' IDENTIFIED BY 'P@ssw0rd';

But must be:
CREATE USER 'test'@'%' IDENTIFIED BY 'P@ssw0rd';

thanks for the report.
duplicates #11850 .
Will be fixed in 21.2.1


Add 'Self' type to the context when inferring object type annotations

This is out of date.  Escalier now infers classes and I decided I don't want the language to support object literals with methods.  If people need a singleton they can create a class and new up a single instance of it.


[BUG]: [QA | "Proof of Debt/ Liability" field is not accepting the png format]

Describe the bug
When we file a case through litigent/ advocate then, on Debt/Liability Details Screen the "Proof of Debt/ Liability" field is not accepting the .png format.
To Reproduce
Steps to reproduce the behavior:

Go to advocate/litigent user
Click on file a new case
FIll the mandatory details
Go to the Debt/ Liability Details Screen.
See Error

Expected behavior
When we file a case through advocate/ litigent then, on Debt/Liability Details Screen the "Proof of Debt/ Liability" should accept the .png format.
Screenshots
PNG.webm
Desktop :

Browser [chrome]

Hi @shambhavigoel1002  Not able to reproduce this issue so closing it.
https://jam.dev/c/45040db7-55d5-4e06-b0ef-423a30a07d55
cc : @Ramu-kandimalla @rajeshcherukumalli


PhantomJS loses hash on direction

Reproduction:
Server: http://example.com/3 redirects to http://example.com/3/Three
Phantom:
GoTo: "http://example.com/3#Third"
Redirection takes to "http://example.com/3/Three" and not "http://example.com/3/Three#Third"
Is there a place in the source where I could look  to patch this issue?

Some more:
http://stackoverflow.com/questions/17982594/how-do-i-preserve-uri-fragment-in-safari-upon-redirect
http://stackoverflow.com/questions/2286402/url-fragment-and-302-redirects
https://bugs.webkit.org/show_bug.cgi?id=24175

Duplicate of https://github.com/ariya/phantomjs/issues/12192


Update support-matrix-defender-for-containers.md

@dcurwin

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


fix: secondary button now differentiable issue #2988

What
Fixed as requirements

Actually in the issue one of the project maintainers advised that in row it will look better, no worries I will fix it as required..

I know @Akashsri3bi it was actually me 😆
https://github.com/openfoodfacts/smooth-app/issues/2988#issuecomment-1278618038
Didn't knew that we have these as parameters for our SmoothAlertDialog I thought we used a own widget for it instead 😅

Okay , No worries😁 I will fix it

@M123-dev I think now it's fine with recent changes !

Codecov Report

Merging #3171 (b8e0619) into develop (adb7716) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #3171      +/-   ##
==========================================
- Coverage     6.19%   6.17%   -0.02%
==========================================
  Files          248     252       +4
  Lines        12439   12495      +56
==========================================
+ Hits           771     772       +1
- Misses       11668   11723      +55

Impacted Files
Coverage Δ

...pages/preferences/user_preferences_contribute.dart
4.60% <0.00%> (-0.26%)
:arrow_down:

...ges/smooth_app/lib/pages/product/summary_card.dart
0.00% <0.00%> (ø)

...mooth_app/lib/helpers/robotoff_insight_helper.dart
0.00% <0.00%> (ø)

...th_app/lib/cards/data_cards/image_upload_card.dart
0.00% <0.00%> (ø)

...ib/cards/product_cards/product_image_carousel.dart
0.00% <0.00%> (ø)

...b/pages/preferences/user_preferences_dev_mode.dart
0.00% <0.00%> (ø)

packages/smooth_app/lib/pages/question_page.dart

...smooth_app/lib/query/robotoff_questions_query.dart

...es/smooth_app/lib/pages/hunger_games/congrats.dart
0.00% <0.00%> (ø)

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AshAman999 @M123-dev secondary action button now looks appropriate


Records page

Should also contain infamous records like:

most double faults
most retired matches, walkovers, defaultings

Mostly completed, what is lacking:

Winning streaks
Title streaks
Finals streaks
Ranking records
Best player who never... (win grand slam, was no N, ...).

Add supports for comments for Record rules (like minimum 3 matches for Rivalry to be counted, minimum N items for percentage records, etc...)


Fix typo in log message for strict mode disabled

@allcontributors please add @ealap for code.

Fixes #1490
Thank you for the contribution.


Pre-check standard conditions for new offers

Context
Standard conditions are compulsory for a trainee to start a course and are usually included
in an offer. Providers can choose to omit these conditions but they should be included by default.

Changes proposed in this pull request
Standard conditions are pre-checked when a provider makes a new offer. The provide can omit them by unchecking the condition(s).

Before

After

Guidance to review
I considered moving the repetition of checkbox values (they are pretty wordy) to a translation file. The use and guidance of translation files is under discussion though, would be happy to hear reviewer's thoughts on this. It would be DRYer to use translations but given these are form checkbox values I wonder if it's the correct use of i18n?

Link to Trello card

https://trello.com/c/MpKzZ1HO/1698-make-default-conditions-not-optional-when-making-an-offer-in-the-provider-ui
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

@mnacos @stevehook thanks for the reviews, I think I've addressed all points now.
I wonder if reusing MakeAnOffer::STANDARD_CONDITIONS to populate the values of the checkboxes might make the value definitions less brittle.

@mnacos @stevehook thanks for the reviews, I think I've addressed all points now.
See b329c48#diff-541dbd1e1d2e8eee85a7dd9c76c6b235R20
and
b329c48#diff-002f3970d414b723cc19c694b0d9c902R62
I wonder if reusing MakeAnOffer::STANDARD_CONDITIONS to populate the values of the checkboxes might make the value definitions less brittle.
eg
<% MakeAnOffer::STANDARD_CONDITIONS.each do |condition| %>
  <%= f.govuk_check_box :standard_conditions, condition, label: { text: condition } %>
<% end %>

That's a good idea and consistent with having the service itself be the source of truth for the default standard conditions. I'd probably use @application_offer.standard_conditions instead of the constant, but not too bothered.
Please add :)

@mnacos I forced pushed since your approval, this was to make the test for the check box data less brittle https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/1480/files#diff-935dc2f0c5c19b13b4a65dc6608f24b0R19-R25


Add DayPickerSingleDatePicker component

Fix for https://github.com/airbnb/react-dates/issues/524
I've created a DayPickerSingleDateController to match the DayPickerRangeController component. I've also added stories for it as well.
The related PR for ranges is https://github.com/airbnb/react-dates/pull/167. The basic gist of this work is that all calendar related code has been moved into an abstraction layer in between the DayPicker and the SingleDatePicker called the DayPickerSingleDateController. Specifically this includes the day interaction callbacks (onDayMouseEnter, onDayMouseLeave, and onDayClick) and all code relating to the modifiers.
The following graphic should help explain the new structure somewhat (DayPickerWithRangeControllers maps to the DayPickerSingleDateController).

In a future PR, I will separate out the code related strictly to the input from the SingleDatePicker. After that the SingleDatePicker will strictly contain code that coordinates focus and visibility between the input and the calendar dropdown.
to: @tagoro9 @pokonski @airbnb/webinfra

Fantastic news! I'll check it out very soon, thanks Maja 👏

This is awesome! Thanks so much!

Coverage decreased (-0.3%) to 86.162% when pulling 100d80ca1228b8a9330f78378be07210db8450bf on maja-add-daypickersingledatecontroller into 0c14a9d83bf27af73813f0c31a3d03cb552d1eb3 on master.

@ljharb I've added a lot more content to the description to provide context for the changes if you would like to take a look! It does largely just entail moving around a functions that already existed and I do have confidence in the tests catching things. :D

I just switched to this version in our library and replaced the uses of our custom implementation of DayPickerSingleDateController with the one in here and everything is working great and test are passing. This is awesome! Thank you very much!
I just have one question. DayPickerSingleDateController is not exported in the index.js file. Are you planning on exporting it?

Coverage decreased (-0.2%) to 86.162% when pulling<PHONE_NUMBER>dcaed58d374197f25765ea7958f081 on maja-add-daypickersingledatecontroller into 61f505cb07753a29e2c767dce15b46d1d2176498 on master.

Coverage decreased (-0.2%) to 86.162% when pulling 7d173c16eea2e0d8d08053db961825e42d16c018 on maja-add-daypickersingledatecontroller into 61f505cb07753a29e2c767dce15b46d1d2176498 on master.

Coverage decreased (-0.2%) to 86.173% when pulling 730acf801b0a45691b12bdde0d719434aba4667d on maja-add-daypickersingledatecontroller into 61f505cb07753a29e2c767dce15b46d1d2176498 on master.

Coverage decreased (-0.2%) to 86.204% when pulling 48dfbd1b12bfd4a3658bf639630ea74ff073fe25 on maja-add-daypickersingledatecontroller into 24bd840bb9fc73edd872ae576e0b277707ac0aad on master.


What about multi-paragraph texts

Hi,
What would you recommend for longer texts, like for example a privacy policy text with multiple paragraphs and number lists.
Thanks :)

Hi, it depends, you could get them directly from your backend as a web page, by passing the language as parameter or composing a different static url based on the language...

Okay, that makes sense. Because it's not possible to pass html code like ,  and  from a JSON file through something like strings.privacy?


Added Climacell public API

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[X] Your submissions are formatted according to the guidelines in the contributing guide
[X] Your additions are ordered alphabetically
[X] Your submission has a useful description
[X] The description does not end with punctuation
[X] Each table column should be padded with one space on either side
[X] You have searched the repository for any relevant issues or pull requests
[X] Any category you are creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

Hello @roughley thanks for the PR! Please address all CI issues before this will be reviewed.

Hi @roughley , I restarted the build and HTTPS passes now. However, I cannot find any description of pricing on the website, only references to a "free trial" of some kind. Can you please comment with a link to pricing documentation? Thanks.

The link I provided (https://developer.climacell.co) provides information on the 2 options available.  They are (1) free (for 1000 calls/day), and (2) enterprise, the enterprise version has a free 30 day trial and per-customer pricing.
Do you think this messaging is too confusing?

Looks good, thanks!

Thanks!
On Sun, Jun 10, 2018 at 8:34 AM, Dave Machado<EMAIL_ADDRESS>wrote:

Merged #669 https://github.com/toddmotto/public-apis/pull/669.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toddmotto/public-apis/pull/669#event-1672609767, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAA0HZftnoLa3pUlE6Ww1q9GHWam93sMks5t7RJJgaJpZM4T_7ta
.


Azure: Unable to see all subscriptions

I have 32 subscription for my azure AD login , however, streampipe is showing only 1
Could you please help with this

@ashitabh To expand on what @misraved has mentioned, in the Azure plugin, each connection represents a single subscription, as specified in the Radius section of Azure Credentials.
Here's a sample connection config with multiple Azure connections, one per subscription:
connection "azure_all" {
  type        = "aggregator"
  plugin      = "azure"
  connections = ["azure_*"]
}

connection "azure_sub_1" {
  plugin          = "azure"
  subscription_id = "azure_01"
}

connection "azure_sub_1" {
  plugin          = "azure"
  subscription_id = "azure_02"
}

connection "azure_sub_1" {
  plugin          = "azure"
  subscription_id = "azure_03"
}

If you then run select * id, subscription_id from azure_subscription, you should see results from all 3 subscriptions, as the azure_all connection will be used as determine by the search path, but this can be changed by setting the search path. You can view your current search path by typing .search_path.
To query specific connections, you can also run queries like select * id, subscription_id from azure_sub_1.azure_subscription or select * id, subscription_id from azure_sub_2.azure_subscription. You can also use set the search path or search path prefix.
Hope that helps, if you have any other questions please let us know!

thanks @cbruno10
its working for multiple subscription


Thread use question in Windows

I had seen the issue #547
And I tried to use wasm_runtime_init_thread_env() and wasm_runtime_destroy_thread_env().
My code is like this:
1- call wasm_runtime_init_thread_env()
2- call wasm_runtime_call_wasm() and in wasm app create thread.
3- call wasm_runtime_destroy_thread_env() after wasm_runtime_call_wasm()
It works the first time. And wasm_runtime_init_thread_env returns true.
But the follows all went to crash. And wasm_runtime_init_thread_env return false. (I use the same thread as first time)
Then I just call wasm_runtime_init_thread_env one time in this thread. And I do not call wasm_runtime_destroy_thread_env any more.
Then it works well.
So I have some questions:

Is there any bug in wasm_runtime_destroy_thread_env?
Can I only call wasm_runtime_init_thread_env one time and never call wasm_runtime_destroy_thread_env in one thread?
Can wasm_runtime_init_thread_env be used in other platform such as Android?
Which thread don't need to call wasm_runtime_init_thread_env, the thread called wasm_runtime_init,  the thread called wasm_runtime_create_exec_env or other?

I had seen the issue #547 And I tried to use wasm_runtime_init_thread_env() and wasm_runtime_destroy_thread_env(). My code is like this: 1- call wasm_runtime_init_thread_env() 2- call wasm_runtime_call_wasm() and in wasm app create thread. 3- call wasm_runtime_destroy_thread_env() after wasm_runtime_call_wasm() It works the first time. And wasm_runtime_init_thread_env returns true. But the follows all went to crash. And wasm_runtime_init_thread_env return false. (I use the same thread as first time)
Then I just call wasm_runtime_init_thread_env one time in this thread. And I do not call wasm_runtime_destroy_thread_env any more. Then it works well.

Hi, do you call wasm_runtime_init_thread_env()/destroy_thread_env() in the thread that is created from the wasm app? Or, wasm app invokes pthread_create like API, and in the native, you call wasm_runtime_init_thread_env()? If yes, don't call them, these APIs are only required to call when the thread isn't created by runtime (runtime creating thread normally includes (1) wasm app invokes pthread_create(), (2) developer calls wasm_runtime_spawn_thread(), (3) developer calls os_thread_create()), for example, if developer creates thread by himself with native pthread_create() function, then in the thread callback, he normally should:
void *thread_callback(..)
{
    ret = wasm_runtime_init_thread_env();
    /* check return value */

   create exec env, and call wasm func

   wasm_runtime_destroy_thread_env();
   return NULL;
}

So I have some questions:

Is there any bug in wasm_runtime_destroy_thread_env?
Can I only call wasm_runtime_init_thread_env one time and never call wasm_runtime_destroy_thread_env in one thread?
Can wasm_runtime_init_thread_env be used in other platform such as Android?

Yes, you can have a try.

Which thread don't need to call wasm_runtime_init_thread_env, the thread called wasm_runtime_init,  the thread called wasm_runtime_create_exec_env or other?

@wenyongh
Thanks for your reply.
Did you mean that the thead my wasm app run in and call pthread_create must be one kind of these threads:

The thread that managed or created by the wamr runtime. Such as threads created by wasm_runtime_spawn_thread and the threads created in wasm app.
The thread created by native derectly using os thread maker (like pthread_create) and I called wasm_runtime_init_thread_env in the new thread before run wasm function.
And did you mean that wasm_runtime_init_thread_env and wasm_runtime_destroy_thread_env should never be called in the first satuation. Or else the thread will be broken and can't create thread in wasm app any more?

But I still don't know how to do...
My situation is that the native rumtime maneger is not the maneger of the process. It is part of the whole application and will be called passively. So some time I don't know which thread now it is. Is there any method like "wasm_runtime_need_init_thread_env" to help me to know whether call or not call wasm_runtime_init_thread_env?
And I have more tests today. And from them I think wasm_runtime_init_thread_env will always go wrong in a thread when called more than one time. No matter whether it is a native created thread or not.
My test step are:
condition1:
1- thread 19964 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env
2- thread 18144 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env.
3- thread 19964 call wasm_runtime_init_thread_env and get false. Call wasm_app2 to do things but not create thread and it works ok. Call wasm_runtime_destroy_thread_env.
4- thread 18144 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.
condition2:
1- thread 3584 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env
2- thread 3584 call wasm_runtime_init_thread_env and get false. Call wasm_app2 to do things but not create thread and it works ok. Call wasm_runtime_destroy_thread_env.
3- thread 23040 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env.
4- thread 22100 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env.
5- thread 22100 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.
condition3:
1- thread 23356 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env
2- thread 23356 call wasm_app2 to do things but not create thread and it works ok. (This time not call wasm_runtime_init_thread_env and wasm_runtime_destroy_thread_env)
3- thread 26204 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env.
4- thread 26204 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.

@wenyongh Thanks for your reply. Did you mean that the thead my wasm app run in and call pthread_create must be one kind of these threads:

The thread that managed or created by the wamr runtime. Such as threads created by wasm_runtime_spawn_thread and the threads created in wasm app.
The thread created by native derectly using os thread maker (like pthread_create) and I called wasm_runtime_init_thread_env in the new thread before run wasm function.
And did you mean that wasm_runtime_init_thread_env and wasm_runtime_destroy_thread_env should never be called in the first satuation. Or else the thread will be broken and can't create thread in wasm app any more?

Hi, only when the thread isn't managed by runtime, developer needs to call wasm_runtime_init_thread_env/wasm_runtime_destroy_thread_env. Normally in these situations the thread is managed by runtime:

the main thread that calls wasm_runtime_init() or wasm_runtime_full_init()
the thread created by wasm app, in which wasm app invokes imported pthread_create() to create thread
the thread created by wasm_runtime_spawn_thread()
the thread created by os_thread_create()

And if the thread is created by developer, e.g. using the host pthread_create or _beginthreadex API, and wasm_runtime_init()/full_init() isn't called, then wasm_runtime_init_thread_env/wasm_runtime_destroy_thread_env should be called, and developer had better call them at the beginning and the end of the thread callback func, e.g. in Windows:
unsigned __stdcall thread_wrapper(void *arg) {
    wasm_runtime_init_thread_env();
    create exec env and call wasm func;
    wasm_runtime_destroy_thread_env();
    return 0;
}

_beginthreadex(NULL, 32768, thread_wrapper, arg, 0, NULL);

But I still don't know how to do... My situation is that the native rumtime maneger is not the maneger of the process. It is part of the whole application and will be called passively. So some time I don't know which thread now it is. Is there any method like "wasm_runtime_need_init_thread_env" to help me to know whether call or not call wasm_runtime_init_thread_env?

It is not easy to implement the wasm_runtime_need_init_thread_env like API, can you use thread local variable to check whether thread_env is initied? e.g.
static __declspec(thread) bool thread_env_inited = false;

And set it to true when wasm_runtime_need_init_thread_env is called, and false when wasm_runtime_need_destroy_thread_env is called?

And I have more tests today. And from them I think wasm_runtime_init_thread_env will always go wrong in a thread when called more than one time. No matter whether it is a native created thread or not.
My test step are:
condition1: 1- thread 19964 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env 2- thread 18144 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env. 3- thread 19964 call wasm_runtime_init_thread_env and get false. Call wasm_app2 to do things but not create thread and it works ok. Call wasm_runtime_destroy_thread_env. 4- thread 18144 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.

thread 19964 should not call wasm_runtime_init_thread_env as it is inited by wasm_runtime_init.

condition2: 1- thread 3584 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env 2- thread 3584 call wasm_runtime_init_thread_env and get false. Call wasm_app2 to do things but not create thread and it works ok. Call wasm_runtime_destroy_thread_env. 3- thread 23040 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env. 4- thread 22100 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env. 5- thread 22100 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.

Same as above, thread 3584 should not call wasm_runtime_init_thread_env.

condition3: 1- thread 23356 call wasm_runtime_init wasm_runtime_load wasm_runtime_instantiate wasm_runtime_create_exec_env 2- thread 23356 call wasm_app2 to do things but not create thread and it works ok. (This time not call wasm_runtime_init_thread_env and wasm_runtime_destroy_thread_env) 3- thread 26204 call wasm_runtime_init_thread_env and get true. Call wasm_app1 to create thread and it works ok. Call wasm_runtime_destroy_thread_env. 4- thread 26204 call wasm_runtime_init_thread_env again and get false. Call wasm_app1 to create thread and get crash.

The usage seems to be good, normally we only tested that wasm_runtime_init_thread_env and wasm_runtime_destroy_thread_env are called only one time.  I fixed an issue for "thread 26204 call wasm_runtime_init_thread_env again and get false" with patch #923, see win_thread.c, could you please try again? Thanks.

@wenyongh
I read the source code and I think my crash is caused by enable aot in wamr.
bool
wasm_runtime_init_thread_env()
{
#ifdef BH_PLATFORM_WINDOWS
if (os_thread_env_init() != 0)
return false;
#endif
#if WASM_ENABLE_AOT != 0
#ifdef OS_ENABLE_HW_BOUND_CHECK
if (!aot_signal_init()) {
#ifdef BH_PLATFORM_WINDOWS
os_thread_env_destroy();
#endif
return false;
}
#endif
#endif
return true;
}
Then I disabled aot and my application never crash any more. No matter I called wasm_runtime_init_thread_env in wasm_runtime_init thread or not. No matter I called wasm_runtime_destroy_thread_env or not....
And without aot,  I think the win_thread code does enough protect to the two method:

wasm_runtime_init_thread_env will do nothing when an old data exists.
wasm_runtime_destroy_thread_env will do nothing when the thread data is supervisor_thread_data
So I think they can be called freely.

I think you can check the aot code to find whether there are any mistakes...

@xingkaiyu Have you applied the patch #923? When aot is enabled, wasm_runtime_init_thread_env() calls aot_signal_init() also, and aot_signal_init does two things:

os_thread_signal_init, which calls SetThreadStackGuarantee with 16KB for stack overflow check, meaning that when these pages are accessed, the stack overflow will happen and the registered exception handler will be triggered to handle it.
AddVectoredExceptionHandler, which is to register the exception handler, here it might be not necessary for the sub thread as the main thread has registered it. But I have a test, it also works to register it again.

Could you please check whether the wasm_runtime_init_thread_env()/wasm_runtime_destroy_thread_env() can be called repeatedly in the sub thread? e.g. in the condition 3 above you mentioned. And wondering how you generating the AOT file, did you compile wamrc on windows, and use it to generate the AOT file? Does the AOT file work in single thread mode?
And note that by default the boundary check with exception handler is enabled, so when the wasm app runs into exception (or crash), like "out of bounds memory access" and "native stack overflow", the exception handler will be triggered, we should wait until the exception handling ends. Could you check whether the exception handler works correctly, and if not, debug which exception was thrown? Or is there a simple case to reproduce the issue? Thanks.

@wenyongh
I am using the WAMR-08-10-2021 and now I just test thread in wasm mode not aot mode. I enable aot in wamr just for convenient. Maybe I will test aot in the future.
And for patch #923. I think the related modification is the on in win_thread.c. And I change the return value from true to 0. Then it is ok now even though I enabled aot mode in wamr.
And I think the wasm_runtime_init_thread_env can still be called freely in any thread. Because either in win_thread.c or in posix_thread.c os_thread_signal_init only do init when thread is not inited and I think AddVectoredExceptionHandler called repeatly is ok. And I think os_thread_env_init and aot_signal_init is harmless except some ram and time waste for the thread not need to use sub-thread in wasm app.
But for wasm_runtime_destroy_thread_env I am not sure. For example, if I do the code like this:

create a thread in wasm app. It will use os_thread_wrapper to do os_thread_signal_init
call native function in sub thread
native call another wasm function and init thread env before calling(I think will do nothing) and desdroy thread env after calling. It will call os_thread_signal_destroy (do nothing in windows but something in posix)
native return result to the first wasm function in sub-thread
I don't know if the wasm function will be ok for the following step. Because I destroyed the thread_signal early than os_thread_wrapper.
Maybe I should never call destroy in native.
I will do some more tests...


[Circularity KIT]: Add "Core" to Glossary

Description
 Add definition for "Core" in context of remanufacturing.
Impact
 Glossary will get another Row.
Additional information

[x ] I'm willing to contribute to this feature

Committer: Committer @danielmiehle , @maximilianong

Presented in the DRAFT Feature Freeze -> Committer needed

I have the definition ready, but probably would need help to add it to the Glossary Table via PR


#884 Persist and use for type enforcement type information for disk …

…persistent caches

Test this please


invoke-azurermresourceaction Missing example

GitHub Feedback system is not yet integrated into following, hence creating issue like this
https://docs.microsoft.com/en-us/powershell/module/azurerm.resources/invoke-azurermresourceaction?view=azurermps-6.1.0
Example section is empty.. this is very powerful command and can be used predominantly with good examples.

@mganeshphani , thanks for the feedback. I have shared this with the content owner to provide an update and fix eta for the missing examples.

Created issue in product repo: please close this one. 😄

Closing on behalf of
https://github.com/Azure/azure-powershell/issues/6335


Docker stack deploy multiple node container resolving

In #80 there was the following observation:

Not related to your question but as you are using docker stack deploy then you are using docker swarm, you must be aware DPS will solve just containers started at the current machine, it will not solve containers from others cluster nodes.

I think it would be cool to add support for multiple nodes. Configurable like traefik, with labels in the following way:
    deploy:
      labels:
        - "dps.network=web"
        - "dps.enable=true"
        - "dps.hostname=Host:subdomain.domain.com"
        - "dps.port=8080"
        - "dps.tags=public"

Thanks in advance!

Me too, the question is: I think docker wouldn't have such API to DPS use it, never did a deep search about it anyway

Thanks for your answer!
I think it would be helpful to take a look on traefik  and how container registration is realized there.


WIP angular.component implementation [ci skip]

Needs tests and experimentation, it would be nice to make this work well
with TypeScript decorators for ease of use.
The whole "controller instantiated after templateUrl is loaded" thing seems
not-ideal, it would be cool if a templateUrl function could be a method of
the component controller.

By having the controller by some sort of configuration object, we are restricting the use of a string in certain cases (which might not be a good practice).
I would probably prefer an optional config object as a 4th parameter.

Would it be possible to get docs on what usage of this API is going to look like? It's hard to visualize just looking at the code...

I envision it as using some kind of decorator library (we used to have a.js but that seems to have vanished somewhere), something like:
// TypeScript decorators:
@Component({
  templateUrl: 'meow.html',
  controllerAs: 'MEOWCTRL'
})
class MeowComponent {
  constructor() {
    // Do important controller-initialization-stuff!
  }
}

// ES5 JS with some kind of a.js-like library
Decorate(function MeowComponent() {
  // Do important controller-initialization stuff!
}). No docs yet, I'll have to put more work into this before it gets that far

Closing in favor of #12933


fix: set option nowrap on context window

Closes #138
Explicitly set the nowrap option on the context window.

Anything preventing this from being merged?

@jrwrigh just to confirm, this PR solves #138?

Yep!

Alright, let's merge then. I'll leave the nvim_win_set_option as it's locally consistent with nvim_win_set_var.


[T5A2][W15-B3]Zuo Zhuolin

@ZuoZhuolin
Some comments added. Please ack & close the PR after reading comments.


feat: fetch chain configs from config service

Resolves #595
What this PR changes

Loads chainConfig from config service
Uses the static list as a fallback in case the service is not reachable
Refactors balance fetching using useSwr

Todos

[ ] Fix tests
[ ] Write new test

Everything looks really great! This is a really cool change. I added just a couple questions/comments inline. I'm a bit confused by these slices and reducers...


Release/41

I've reviewed the release environment and it looks good. We'll be using this document for reinitializing ES.

Fixes #74. Fixes #60. Fixes #41. Fixes #21. Fixes #10.


Compiler: better error for return type mismatch

Fixes #8169

hell yes

Seems a safe change to be merged for 0.31.0 IMO.

Seems a safe change to be merged for 0.31.0 IMO.

Let's do it!


Switch metadata script URL in repo description to 13 branch

Current URL is https://github.com/GrapheneOS/script/blob/12.1/generate_metadata.py which is GrapheneOS 12.1
Should be updated to https://github.com/GrapheneOS/script/blob/13/generate_metadata.py

Done, thanks.


chore: bump iOS and Android dependencies to get latest bug fixes

Bumping iOS to 5.10.0 and Android 9.3.0
Notes:

Needed to bump the minSDKVersion to 24 to resolve dexing errors when building. Its possible there were other dependency conflicts which weren't obvious, so perhaps this change isn't necessary.

Woot, thanks for sorting this out! Does this also need an OOB test/example for folks that want to figure how to use it?

I haven't added any code in this commit to expose OOB to the React layer. Looks like @zplata had a start to it here for iOS.

Hi, is a new release with these changes coming soon? Thanks!

Thank you very much 🙏


Change Controller Name

VERSION:
6.3.1
STEPS TO REPRODUCE:
Create a Blazor WASM App in VS 2019 with Minimal API and .NET Framework 6.0.
EXPECTED RESULT:
Name a Controller with e.g. an Attribute
ACTUAL RESULT:
The Controller's Name is the Name of the Project.

app.MapGet("/EDI/Customer/", [SwaggerOperation(Tags = new[] { "XXXXXXXXXXXX" })] (CancellationToken cancellationToken)
Does the trick!


ModuleLoadError: [MODULE_NOT_FOUND] require failed to load

I got following error on Linux machine:

ModuleLoadError: [MODULE_NOT_FOUND] require failed to load

swanky.webm
tomek@rhei-box:~/workspaces/ink$ node --version
v14.17.6
tomek@rhei-box:~/workspaces/ink$ npm --version
8.19.2

On Windows machine works, although many developers use another OS than Windows.

Hi @TomaszWaszczyk , thanks for reporting!
I don't think it's an OS issue, but node version.
You use v14, and it doesn't support native module import syntax (node:path).
Since you're using nvm, it should be trivial to add the latest node version and use it.

Thanks, right, I confirm that on NodeJS v18.10.0 version all works like a charm!


Moving datamigration (2),dataprotection (3) to v1beta1 version

Description of your changes
Moving 2 resources in the datamigration group:

[x] azurerm_database_migration_project
[x] azurerm_database_migration_service

Moving 3 resources in the dataprotection group:

[x] azurerm_data_protection_backup_instance_blob_storage
[x] azurerm_data_protection_backup_instance_disk
[x] azurerm_data_protection_backup_policy_disk

Fixes #223
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manually, as ResourcePolicyAssignment depends on existing resources id
azurerm_data_protection_backup_instance_blob_storage

azurerm_data_protection_backup_instance_disk

Manually and Uptest
TODO

/test-examples="examples/datamigration/databasemigrationproject.yaml"

/test-examples="examples/datamigration/databasemigrationservice.yaml"

/test-examples="examples/dataprotection/backuppolicydisk.yaml"


[BUG] cannot obtain current URL in client code

Every method that I've tried to obtain the current URL of the browser (in client-side code) seems to break. This includes useLocation from react-router, window.location.href, wrapping window.location.href in a useEffect hook, etc.
Is there a suggested/recommended method of getting the current URL that I'm missing?
To Reproduce
I've tried some approaches like below to ensure the code runs client side. This runs just fine in development mode, but breaks when building a production distribution:
  const [url, setCurrentUrl] = useState('');
  useEffect(() => {
    if (typeof window !== 'undefined') {
      setCurrentUrl(window.location.href);
    }
  }, []);

With code like above, I don't get any server-side errors, but I get the following error in the browser:

Other approaches yield more typical "window is not defined" errors.
local env:

hydrogen 1.6.7
node 19.7.0

@diemonster There is the useUrl hook you can use: https://shopify.github.io/hydrogen-v1/hooks/global/useurl

@diemonster There is the useUrl hook you can use: https://shopify.github.io/hydrogen-v1/hooks/global/useurl

@diemonster There is the useUrl hook you can use: https://shopify.github.io/hydrogen-v1/hooks/global/useurl

Closing as this ended up being an issue unrelated to useUrl


Windows ECR authentication doesn't work with docker-compose: no basic auth credentials

Hi, I'm trying out the new Windows support and impressively everything works except for this.
The "Authenticating with AWS ECR" group shows up in the step logs, and says it succeeded and wrote the config.json to what I gather is a temporary DOCKER_CONFIG:
Authenticating with AWS ECR in ap-southeast-2 for <account_id> :ecr:
WARNING! Your password will be stored unencrypted in C:\Users\BUILDK~1\AppData\Local\Temp\tmp.FOA15JhpCr\config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded

However, the docker-compose plugin's docker pull and docker push steps both fail:
Pulling cache image for <step>
$ docker pull <account_id>.dkr.ecr.ap-southeast-2.amazonaws.com/<...>
Error response from daemon: Get https://<account_id>.dkr.ecr.ap-southeast-2.amazonaws.com/v2/<...>/manifests/<...>: no basic auth credentials
Exited with 1
!!! :docker: Pull failed. <account_id>.dkr.ecr.ap-southeast-2.amazonaws.com/<...> will not be used as a cache for <step>

If I RDP into the instance and run aws ecr get-login-password and docker login then docker pull commands manually it all works fine, so there is nothing wrong with the IAM role or ECR plugin etc. My best guess is it's something to do with DOCKER_CONFIG not being applied to the docker-compose hooks properly?
This is with both v5.2.0 and v5.3.1. I tried with an explicit ECR plugin invocation, but same result. I also quickly tried v5.2.0 with Linux which obviously worked as expected.
The closest issue I could find is https://github.com/buildkite/elastic-ci-stack-for-aws/issues/449 but I don't think it's related because this happens consistently, despite the same error message.

Thanks for reporting this! It does seem like a problem with our Windows DOCKER_CONFIG handling. We'll have a look into this and try to solve it, but if you notice anything else in your journeys do let us know.

Thanks, I managed to confirm that the docker-compose pull/push works after commenting out the DOCKER_CONFIG stuff in the global environment hook, but then the run part just hanged, which is probably just some issue with the AMI I built. :facepalm:
FWIW I've seen it suggested that DOCKER_CONFIG just doesn't work with docker-compose at all on Windows, e.g.:

https://github.com/docker/compose/issues/2517#issuecomment-171618377
https://github.com/docker/compose/issues/1590#issuecomment-589657547


discourse: 2.9.0.beta9 -> 2.9.0.beta10

Description of changes

new version of Discourse
updated one broken patch

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

https://nvd.nist.gov/vuln/detail/CVE-2022-36066
https://nvd.nist.gov/vuln/detail/CVE-2022-36068
https://nvd.nist.gov/vuln/detail/CVE-2022-39226
https://nvd.nist.gov/vuln/detail/CVE-2022-39232

Interestingly nixosTests.discourse WFM, but discourse.tests gives me:
error: The option `machine' is used but not defined.

I see the slightly funny way the passthru.tests are defined - is this an attempt to make sure the actual package in question is the one being tested by the nixos test? If so, perhaps the way the recently added varnish tests use the finalAttrs.finalPackage mechanism to achieve this would prove more robust?

Yeah, I had the same problem with the tests. It used to work.


Array difference

Should not the difference be verified on both sides?
// difference([1,2,3], [1,2]) -> [3]
// or
// difference([1,2], [1,2, 3]) -> [3]

i have an update for the symmetric difference. in set theory, difference is more link 'not in'

We should really call that one more Set Difference than array difference. In fact it might be a good idea to convert the Arrays to Sets and use their difference mechanisms for a more defined idea

@skatcat31 that's a good idea. @prodigic I have suggested that we split into different snippets in #155. Get on that if you can, so I can merge it.