Include Additional Rust-based Features/Functionalities

Should this package include features/functionalities that may not be directly related to Polars Extensions? Feel free to leave a comment.
E.g. functions that take in a Polars DataFrame, and spits out the SVD decomposition or data related to PCA.  Functions that return eigenvalues, etc.
The main issue is that I have two polars-based packages for data science: polars-ds (alpha) and dsds (pre-alpha). DSDS provides data screening, data problem detection, feature selection, and transformers. On the other hand polars-ds right now only provides Polars extensions. Right now both dsds and polars-ds have Rust modules. This leads to problems like code duplication and makes Rust code harder to share between the two packages.
Pro:

Keep more foundational algorithms at one place. Smaller binary than having rust modules in two packages.
To reach escape velocity in the data science world, we probably need lots of features bundled together and the features/functionality may or may not be related.
The other package, dsds, then do not really need a rust backend any more. Just import from polars-ds. DSDS can purely focus on data front-end. DSDS then will only include things achievable by doing simple Polars queries, non-time-critical functions, and all Rust code will be in polars-ds and exported to DSDS. Polars-ds will focus more on performance and DSDS will focus more on UX. A better separation of priority.
Easier to access Rust functions, because then Rust functions will all come from the same module. Let's say we have an expression that does nearest neighbor search:

pl.col("id").num_ext.knn(pl.col("x1"), pl.col("x2"), k=3, metric="euclidean")
# Search for 3 nearest neighbors for each id, based on Euclidean distance using x1 and x2, and return the ids as a list.

Such an algorithm will involve a kdtree. But the same kdtree algorithm can be used for other tasks as well, which may not be DataFrame based.  If we keep two Rust modules for polars-ds and dsds, then we will have to repeat the kd-tree implementations for all the use cases.
Cons:

Longer building time for this package.
This package then will no longer have a single focus.
A lot of refactor effort (Help will definitely be appreciated..)

I couldnt find the repo for dsds (pre-alpha). Although, I think most people will be focus on the data front-end (on the level of sklearn etc) more instead of the foundational algorithm, so ...
+1 for merging.
I could try to help a bit in refactoring too, although I have been much on the side of python-polars only.

DSDS is one of my older repos. I do not plan to maintain it any longer. Its functionalities will be merged to polars-ds bit by bit. My plan is to start doing it after v.4.0. I think I know how to write almost all traditional ML transformers in pure polars, and I have the infrastructure ready to support Polars-native dependency detection, data cleaning, data drifting, and other EDA tasks..


Estimated base_score unavailable as attribute (Python)

If the base score isn't specified at model creation time, then it is estimated.  However, the estimated value isn't available after training:
import numpy as np
import pandas as pd

n_trees = 10
n_samples = 1000
n_float_features = 4

X = 100 * np.random.rand(n_samples, n_float_features)
y = np.random.rand(len(X))

from xgboost import XGBRegressor
model = XGBRegressor(n_estimators=n_trees, max_depth=8, learning_rate=1)
model.fit(X, y)
preds = model.predict(X)
booster = model.get_booster()

assert model.base_score is None

The assertion above passes.
However, when summing the predictions of individual trees and comparing to the results of model.predict(), it is clear that the base_value is non-zero (and hence of importance):
from xgboost import DMatrix
X_dmatrix = DMatrix(X)
individual_preds = [tree.predict(X_dmatrix) for tree in booster]

(sum(individual_preds) - model.predict(X))

Outputs:
array([4.5      , 4.5      , 4.5      , 4.5      , 4.5      , 4.5      ,
       4.5000005, 4.5      , 4.5      , 4.5000005, 4.5      , 4.5      ,
       4.5      , 4.5      , 4.5000005, 4.5000005, 4.4999995, 4.4999995,
       4.5      , 4.4999995, 4.5      , 4.5000005, 4.5      , 4.5000005,
       4.5      , 4.5000005, 4.5000005, 4.5      , 4.5      , 4.5      ,
...

There is a discussion on this topic.
Thanks for your help or clarification!

Hi, the feature was recently added and is not yet available for release branches. In addition, the model.base_score will continue to be None as discussed in https://github.com/dmlc/xgboost/pull/8634. In summary, the Python attribute base_score is a user parameter according to the sklearn interface and should not be changed by the library itself. To see the configured base score, you either have to use the save_config like what's shown in the discussion or save the model as JSON and find the value.


enhancement: update code in NativeAppBar

Describe the bug
In NativeAppBar position is fixed which is hard coded, which is a bad practice, which can be passed using prop.
To Reproduce
Steps to reproduce the behavior:

Go to 'NativeAppBar.js'

Expected behavior
Position should be passed using props.
Stack Trace
Screenshots
Desktop (please complete the following information):

OS: [Windows]
Browser [Chrome]
Version [Version 126.0.6478.183 (Official Build) (64-bit)]

Additional context

Closing as done.

Closing as done.

Closing as done.


Add a with_config decorator to comply with typing spec

May fix https://github.com/pydantic/pydantic/issues/8514, as suggested in a comment.
If accepted, better documentation will follow
Selected Reviewer: @dmontagu

It'd be great if this could also be used with dataclasses.

By dataclass, do you mean the Pydantic one or stdlib? If it is Pydantic dataclasses, I think it would add confusion as:

using @dataclass(config=ConfigDict(...)) already works, and I don't see any benefit of using @with_config instead (but I might be missing something?)
Users would have to be careful about the order between @dataclass and @with_config:

from pydantic import with_config
from pydantic.dataclasses import dataclass

@with_config(ConfigDict(...))  # Will not work, config is already configured by the `@dataclass` decorator below
@dataclass
class Foo:
    ...

Please review

@Viicos,
I've moved the attached issue into the 2.7.0 milestone :).

@Viicos,
Amazing work 🚀. Merging this now to be included in 2.7.0!


Implement backtoToS3() Appwrite Function ⚡

Introduction
Appwrite Functions allow you to extend and customize your Appwrite server functionality by executing your custom code 🤩 You can learn more at our official Appwrite Functions docs.
Your task is to implement backtoToS3 function. You can look at the existing Appwrite Functions demo in the coding language you prefer to see how it works.
This function should export all data from all collections, generate an in-memory CSV file and save it to Amazon S3.

Please make sure to store all configurable parameters as environment variables, so others can start using your script without having to edit it. If some data is different for each execution, make sure to use APPWRITE_FUNCTION_EVENT_DATA or APPWRITE_FUNCTION_DATA environment variable.

Tasks summary:

[ ] Fork & clone this repository
[ ] Create feat-implement-backup-to-s3-X branch where X is programming language you used
[ ] Write code for the function
[ ] Test the function using Appwrite
[ ] Write a README.md explaining what function does, how to use and customize it. Here is an example.
[ ] Submit pull request

If you need any help, reach out to us on our Discord server.
Are you ready to work on this issue? 🤔 Let us know, and we will assign it to you 😊 There are 9 languages in which you can implement this function. When requesting to be assigned, please mention which language would you like to use.
Assignees table
✅ = Done - This language has already been finished
⚒ = In progress - Someone is already working on this language
❌ = Unassigned yet - This language can be assigned to you

Function / Language
Deno
NodeJS
PHP
Python
Ruby
Dart
.NET
Java
Kotlin

backtoToS3
❌
❌
❌
❌
❌
❌
❌
❌
❌

Happy Appwriting!

@Meldiron I want to work on this issue as I know Nodejs and PHP language

Hi, can you please assign this to me, I want to write in Nodejs.
Thank you

@bipinparajuli @HarshitPandey251 Assigned it to you! All the best 🚀
@HarshitPandey251 I gave you PHP, so @bipinparajuli can work on NodeJS.


Don't run CLA workflow twice

Details
This PR fixes a side effect of https://github.com/Expensify/Expensify.cash/pull/1802#issuecomment-800657505 where the CLA workflow runs on master twice. Since we already have this workflow running on pull_request_target, we should be able to exclude it from running on master for pull_request actions
Tests
Created this PR, confirmed the CLA workflow only ran once on pull_request_target

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

Just testing GH Actions, no need to wait for iOS E2E tests to finish.


supabase-js 2.0.0-rc.10 - Custom headers not being passed to supabase requests.

Bug report
Custom headers are not being passed to supabase queries in this RC.
Describe the bug
When using custom headers, the supabase client no longer adds them to query requests. This is working in 1.35.2.
To Reproduce

   supabase = createClient(supabaseUrl, supabaseAnonKey, {
      headers: {
        my_custom_header: 'abracadabra',
      },
    });

  const { data: meetingData, error } = await supabase
    .from("my_table")
    .select("*")
    .eq("id", id)
    .single();

Expected behavior
Among request headers in the supabase GET request:
my_custom_header: 'abracadabra'
System information

OS: Mac
Browser (if applies) Version 15.6.1 (156<IP_ADDRESS>.16, 15613)
Version of supabase-js: 2.0.0-rc.10

Additional context
I'm using a custom header with RLS rules to provide access to particular rows for anon users. This is a workaround for not being able use an auth header with realtime websockets subscriber however now with the broadcast/presence method I may be able to achieve the same result.

The config is updated, now headers is under global option.
const supabase = createClient(supabaseUrl, supabaseAnonKey, {
  global: {
    headers: {
      my_custom_header: 'abracadabra',
    },
  }
});

@hammercodegh thank you!

Closing this - @jonascript feel free to comment if it doesn't work so we can reopen :)


MVC DiagnosticListener changes break Intellitrace

Our recent change to the casing of some properties in our DiagnosticListener events breaks Intellitrace. This will cause things like unit test failures tried to debug tests.

I think we should just add the older properties as lower case to the new types and obsolete them.

Yeah my plan is to review their code and then do that.

https://github.com/aspnet/AspNetCore/pull/12323


anagram: Use collect

Instead of creating a String manually, pushing into it in a loop, and
then returning it, we can just collect on an iterator to turn the
vector into a String.

great.


HERE geocoder.reverse returning null as street number

Hello, I have a problem with function geocoder.reverse with HERE provider.
Everything is OK, but Street number is always null.
Is there any way how can I fix it?

Also, Here provide is removing the APP_ID and APP_CODE, they are recommending to use API KEY or OAuth2.0 (JSON Web Token)
Are you planning to update the authentication here? it would be great if you can do it.
https://developer.here.com/documentation/authentication/dev_guide/topics/app-credentials.html
@bpotocnak96 are you using app_id and app_code right?

it would be nice if you show backend code so we can see better :)


Refactor amplify-app tests

Issue #, if available:
Description of changes:
Simplify tests using validation helpers, move to e2e folder
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3397 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #3397    +/-   ##
========================================
  Coverage   60.16%   60.16%
========================================
  Files         254      254
  Lines       12459    12459
  Branches     2580     2441   -139
========================================
  Hits         7496     7496
- Misses       4626     4641    +15
+ Partials      337      322    -15

Impacted Files
Coverage Δ

packages/graphql-mapping-template/src/print.ts
35.71% <0.00%> (ø)
:arrow_up:

packages/amplify-appsync-simulator/src/index.ts
73.68% <0.00%> (ø)
:arrow_up:

...ages/amplify-appsync-simulator/src/server/index.ts
64.28% <0.00%> (ø)
:arrow_up:

...ges/graphql-transformer-core/src/util/fileUtils.ts
11.76% <0.00%> (ø)
:arrow_up:

...es/graphql-dynamodb-transformer/src/definitions.ts
84.84% <0.00%> (ø)
:arrow_up:

...es/graphql-transformer-core/src/stripDirectives.ts
35.29% <0.00%> (ø)
:arrow_up:

...amplify-appsync-simulator/src/server/operations.ts
28.45% <0.00%> (ø)
:arrow_up:

...graphql-transformer-core/src/TransformerContext.ts
26.20% <0.00%> (ø)
:arrow_up:

...mplify-appsync-simulator/src/resolvers/function.ts
9.67% <0.00%> (ø)
:arrow_up:

...plify-appsync-simulator/src/server/subscription.ts
26.81% <0.00%> (ø)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9462bb5...2f48104. Read the comment docs.

I don't see the updates in package.json, we should remove the test dependencies from there.

Removed

Codecov Report

Merging #3397 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3397   +/-   ##
=======================================
  Coverage   60.16%   60.16%
=======================================
  Files         254      254
  Lines       12459    12459
  Branches     2580     2580
=======================================
  Hits         7496     7496
  Misses       4626     4626
  Partials      337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9462bb5...4331a49. Read the comment docs.


Python script: Rigid docking with AD4 Scoring Function

Hello,
I was trying to rigid dock with ad4 scoring function on python script.
The tutorial seems like that by changing scoring function's name, it is possible to use ad4 with rigid docking
However, it gave the error
from vina import Vina
v = Vina(sf_name="ad4")
v.set_receptor("./protein.pdbqt")
v.set_ligand_from_file("./ligand.pdbqt")
v.compute_vina_maps(center=[10.4, 6.9, 27.3], box_size=[20, 20, 20])
energy = v.score()
print(energy[0])
ERROR: Only flexible residues allowed with the AD4 scoring function. No (rigid) receptor.
It works well on other sf such as vina or vinardo.
Is it impossible to use sf ad4 on rigid docking?
Thanks

Hello,
The error message that Vina is printing is incorrect. It is possible to dock against a rigid receptor with the AD4 scoring function. However, when using the AD4 scoring function, vina expects pre-calculated grid maps instead of a PDBQT file for the receptor. Here's the relevant part of the documentation and the autogrid code and binaries. To load grid maps in python use v.load_maps(map_prefix). If the maps are named protein_rigid.C.map and so on, then map_prefix="protein_rigid".
We'll change the error message to something like:
"ERROR: with AD4 scoring, autogrid maps must be provided instead of receptor PDBQT".
Thanks for reporting.

Thank you for your kind reply!
I have another question about hydrated docking.
I want to perform hydrated docking with PDB_3pb7, and it seems that the W atom, made from meeko, occupied very nearest location with Zn atom of receptor.
so it gave me very large score value, 623994.331
To solve this, I just remove line of W atom that occupied Zn atom loaction from pdbqt file.
And it gives me error PDBQT parsing error: Unknown or inappropriate tag found in flex residue or ligand.
So is there any appropriate method to solve this issue?
Thank you

If my own scoring function use a numpy array to represent the grids of molecules and proteins (the python function to turn them into grid has been completed) , and I need to use my own CNN scoring function model to instruct vina.dock(), I think there is no need to transfer the numpy array into ".c.map" format, right?


Question: Master Detail document

Hi
Is it possible to create a master-detail document meaning for the "master" data (comprising of few fields) there can exist "many" records in the "detail" data i.e. a document that supports 1-N?
If not, how can I achieve this? Any hints please.
With Regards
Raman

One more question.. I am looking forward to create a small ERP like solution. In such an application, Quotation for example, has a master-detail relationship.
Is it possible to develop it using Prime? If yes, could anybody guide me how to proceed?

Prime supports 1-to-1, 1-to-many and many-to-many relationships.
You can create two schemas that reference one or multiple instances of each other as a field.
Example:
type Book {
  authors: [Author];
}

type Author {
  books: [Book];
}


Sharepoint ingest missing some files under subfolder

Bug Details
In the config file, I have defined "SharepointSites": [ { "url": "https://microsoft.sharepoint.com/teams/ExampleTeam", "folder": "/Shared Documents/General/InformationAssistantTestData"} ]
And after I run the logic app, only 1 subfolder's files are uploaded, missing 2 subfolders' files.
the pdf file under ClimateChange and DominicanRepublic were not uploaded.

See the container files.

Is this by design? or only 1 subfolder are supported?

Hey DevPaulLiu!
We appreciate you bringing this to our attention. It seems in tweaking our logic app, some variables may have gotten mixed up. Sorry about that!
A PR has been created to address these issues in our next update, which I have attached to this issue.
Please let me know if you need anymore assistance

Thanks for quick turn around!


ARROW-5357: [Rust] Change Buffer::len to represent total bytes instead of used bytes

After discussing with @paddyhoran on the JIRA, I'm now inclined to keep both len and capacity in Buffer, which allows us to still maintain most of the existing functionalities. To fix the flatbuffer conversion issue, we'll need ARROW-5358 which allows us to compare ArrayData properly.
@nevi-me let me know if this sounds good to you.

I saw the conversation, would we be able to use capacity when writing to IPC from the current Buffer?

Yes, both reading and writing to IPC buffer will use capacity instead of len.

Apologies for not responding sooner @sunchao
It's only mutable buffer that has capacity, and when we freeze it to create a buffer, we 'lose' the capacity.
#[derive(PartialEq, Debug)]
pub struct Buffer {
    /// Reference-counted pointer to the internal byte buffer.
    data: Arc<BufferData>,

    /// The offset into the buffer.
    offset: usize,
}

struct BufferData {
    ptr: *const u8,
    len: usize,
    // no capacity
}

@nevi-me yes that's right. As I mentioned above, I think it's better to keep both len and capacity in Buffer (same as MutableBuffer).
I'm currently working on https://issues.apache.org/jira/browse/ARROW-5358 which hopefully will allow us to compare Array and ArrayData. It should be able to help resolve the issue you are seeing. I plan to come back to this after that is done.

Okay, great! I'll keep #4167 open, and continue #4330 without ArrayData comparisons for now

Codecov Report

Merging #4331 into master will decrease coverage by 4.92%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           master    #4331       +/-   ##
===========================================
- Coverage    87.5%   82.57%    -4.93%
===========================================
  Files         998       86      -912
  Lines      141784    24935   -116849
  Branches     1418        0     -1418
===========================================
- Hits       124065    20591   -103474
+ Misses      17357     4344    -13013
+ Partials      362        0      -362

Impacted Files
Coverage Δ

rust/arrow/src/memory.rs
100% <100%> (ø)
:arrow_up:

rust/arrow/src/array/array.rs
92.57% <100%> (ø)
:arrow_up:

rust/arrow/src/tensor.rs
92.3% <80%> (-0.48%)
:arrow_down:

rust/arrow/src/buffer.rs
91.3% <88.88%> (+1.52%)
:arrow_up:

python/pyarrow/ipc.pxi

cpp/src/arrow/csv/chunker-test.cc

cpp/src/parquet/column_page.h

cpp/src/parquet/bloom_filter-test.cc

cpp/src/arrow/array/builder_decimal.cc

r/src/symbols.cpp

... and 907 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b0176...7eac173. Read the comment docs.

@nevi-me @sunchao I know there was some related discussion here but are we ok to move forward with this PR (i.e. adding capacity to Buffer).  Is this ready for review?

I think it is ready for review. It'd be great if you can take a look.

Yep, sounds good.  I'll take a look when I get a chance.

I initially thought this would be a blocker for IPC, but I've managed to implement the reader and writer without this. I'd vote for closing this PR @sunchao.

I'd vote for closing this PR @sunchao.

I would actually like to see this PR merged (maybe after further review).  Length and capacity are two distinct concepts in Arrow and having capacity be explicit is easier to understand especially for newcomers.
I also think it will be useful when converting from other libraries to Arrow.  In these cases, we will have to check the alignment and padding (capacity) of the data that is passed to us.

Yes I think it is still useful to have size and capacity as two separate properties of buffer. @andygrove could you take another look on this? I think your concern has been addressed via the comments.

@andygrove want to take look?

@sunchao can you rebase this if you get a chance (or let me know if you are stuck for time and I will)?  It turns out that this PR fixes UB as pointed out by @jturner314 on #6397.
I'll re-review early next week and hopefully we can get this merged.

Sure @paddyhoran . Updated.

Apologies for missing the earlier mentions. I really need to figure out a better way of managing all the emails I get so that these mentions stand out.


Allow programmatic send of options to reporter.

Hi, a few questions.

Why? What reporters take options? We already pass through environment variables if you need configuration in a custom reporter.
So you put a reporterOptions object on a global. I don't see any usages of it in mocha.js.
No Tests
No Documentation

Hi,

Maybe is not what is needed. Also, xunit report and few others takes options.
https://github.com/mochajs/mocha/blob/1.20.1/mocha.js#L1725
1'. I've tried to access process.env vars but no chance. I'll try again. I would prefer that.
Mocha 2 have a reporterOptions but I couldn't make it work with current state. There is any other way to send options?
You're right, just wanted to know if you're interested on that.
Same as previous.

Any plan for Mocha 2?
Thanks,
Paul

I've tried to access process.env vars but no chance.

Because you're running in phantomjs, not node. They are very different execution contexts.

Any plan for Mocha 2 or 3?

For the next version of mocha-phantomjs, we're splitting out the core phantomjs part from the node cli part. The core is at nathanboktae/mocha-phantomjs-core , and I already have tests passing for phantomjs 1.x with mocha 2.24
Due to that, I'm not interested in taking the pull request here as mocha-phantomjs.coffee will be deleted soon.

Thanks, I understood. No problem.


add figure code

Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the Code of Conduct
[ ] I have updated the documentation accordingly.
[ ] All commits are GPG signed

Hello @2lambda123! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file generate_figure.py:

Line 79:80: E501 line too long (83 > 79 characters)
Line 79:84: W291 trailing whitespace
Line 80:80: E501 line too long (94 > 79 characters)
Line 81:80: E501 line too long (119 > 79 characters)
Line 89:80: E501 line too long (81 > 79 characters)
Line 104:11: W292 no newline at end of file


How do I force a cert renewal after adding new entries to dnsNames?

I added a new entry in Certificate dnsNames list
but after applying the new yaml, the status is still stuck in Certificate scheduled for renewal in x hours
Is there anyway I can force a renewal of current certificate?

@williamchong007 as desirable feature for cert-manager would be to reconcile Secrets with Certificates and update the Secret if required, kube-cert-managaer has such a reconciliation pass that handles this, and a trigger for update of Certificates, cert-manager could use something similar.
Right now the work-around is probably to delete the Secret and wait for cert-manager to recreate it.
@munnerz will a missing Secret get recreated this way or does @williamchong007 need to update the Certificate, after deleting the Secret to trigger it?

cert-manager should already do this 🤔 if it doesn't, it's a regression.

Specifically this line is where we check this case: https://github.com/jetstack/cert-manager/blob/master/pkg/controller/certificates/sync.go#L129
I'll add some tests to this part of the codebase to verify the behaviour is as expected, as it's strange you're seeing this.
/kind bug

I'm going to write a test case for this that'll modify a certificate after it has been issued to add a new dnsName. Hopefully that will show definitely whether this does work.. 😄

Same problem. Is there any workaround?

same issue.
I tried deleting the secret, but cert-manager says
I0220 20:38:24.127155       1 sync.go:107] Error checking existing TLS certificate: secret "tls-secret" not found

When I re-add the deleted secret, I get the same as @cyberaleks
I0220 20:53:26.250255       1 sync.go:200] Certificate scheduled for renewal in 1430 hours

I tried using cert-manager command to refresh the cert, but I get:
I0220 20:45:28.060107      43 leaderelection.go:199] successfully renewed lease kube-system/cert-manager-controller
I0220 20:45:29.967466      43 http.go:410] ACME HTTP01 self check failed for domain "secret.com", waiting 5s: wrong status code '403'

I did have this working before I added subdomains, so i am pretty sure the new subdomains is what broke it.
@munnerz is there a possible workaround to exec a cert-manager command to force a cert reissue inside the cert-mangaer pod before this fix is fully ready?
Thanks.

I had the same issue has anyone figured this out yet ?

Error checking existing TLS certificate: secret "tls-secret" not found

That's not an actual error, that message occurs during normal operation. Per the 'I' in the leftmost column, it is an info message, not warning or error.

I had the same issue has anyone figured this out yet ?

Adding an entry to my certificate works fine for me and it immediately renews.
In the detail fold below are the steps I followed to test this. If someone can give similar steps showing it not working, I think that would be helpful for figuring out what's going wrong.
Regardless, I think more information is necessary since naively trying to do this works fine for me, so there must be something different.

$  kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.7", GitCommit:"b30876a5539f09684ff9fde266fda10b37738c9c", GitTreeState:"clean", BuildDate:"2018-01-16T21:59:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:23:29Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

$ kubectl -n kube-system describe deployment cert-manager | grep Image
    Image:  quay.io/jetstack/cert-manager-controller:v0.2.3

$ cat test.euank-cert.yaml
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: test-88-euank-crt
spec:
  secretName: test-88-euank-com
  commonName: test-88.euank.com
  acme:
    config:
    - dns01:
        provider: route53-provider
      domains:
      - test-88.euank.com
  issuerRef:
    name: letsencrypt
    kind: Issuer

$ kubectl apply -f test.euank-cert.yaml
certificate "test-88-euank-crt" created
# wait for it to issue a cert
$ kubectl describe certificate test-88-euank-crt
... (omitted for brevity)
  Common Name:  test-88.euank.com
  Dns Names:    <nil>
... (omitted for brevity)
Events:
  Type    Reason               Age              From                     Message
  ----    ------               ----             ----                     -------
  Normal  PrepareCertificate   2m               cert-manager-controller  Preparing certificate with issuer
  Normal  PresentChallenge     2m               cert-manager-controller  Presenting dns-01 challenge for domain test-88.euank.com
  Normal  SelfCheck            1m               cert-manager-controller  Performing self-check for domain test-88.euank.com
  Normal  ObtainAuthorization  53s              cert-manager-controller  Obtained authorization for domain test-88.euank.com
  Normal  IssueCertificate     3s               cert-manager-controller  Issuing certificate...
  Normal  CeritifcateIssued    3s               cert-manager-controller  Certificated issued successfully
  Normal  RenewalScheduled     3s (x2 over 3s)  cert-manager-controller  Certificate scheduled for renewal in 1438 hours

$ kubectl get secret test-88-euank-com -o json | jq '.data["tls.crt"]' -r | base64 -d | openssl x509 -noout -text | grep "euank.com"
        Subject: CN = test-88.euank.com
                DNS:test-88.euank.com

$ cat test-more-domains.euank-cert.yaml
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: test-88-euank-crt
spec:
  secretName: test-88-euank-com
  commonName: test-88.euank.com
  dnsNames:
  - test-89.euank.com
  - test-90.euank.com
  acme:
    config:
    - dns01:
        provider: r53-ek
      domains:
      - test-88.euank.com
      - test-89.euank.com
      - test-90.euank.com
  issuerRef:
    name: letsencrypt
    kind: Issuer

$ kubectl apply -f test-more-domains.euank-cert.yaml
certificate "test-88-euank-crt" configured
# wait for it to issue

$ kubectl describe certificate test-88-euank-crt
...
  Common Name:  test-88.euank.com
  Dns Names:
    test-89.euank.com
    test-90.euank.com
...
Events:
  Type    Reason               Age               From                     Message
  ----    ------               ----              ----                     -------
  Normal  PresentChallenge     8m                cert-manager-controller  Presenting dns-01 challenge for domain test-88.euank.com
  Normal  SelfCheck            8m                cert-manager-controller  Performing self-check for domain test-88.euank.com
  Normal  ObtainAuthorization  7m                cert-manager-controller  Obtained authorization for domain test-88.euank.com
  Normal  PrepareCertificate   2m (x2 over 8m)   cert-manager-controller  Preparing certificate with issuer
  Normal  PresentChallenge     2m                cert-manager-controller  Presenting dns-01 challenge for domain test-89.euank.com
  Normal  PresentChallenge     2m                cert-manager-controller  Presenting dns-01 challenge for domain test-90.euank.com
  Normal  SelfCheck            2m                cert-manager-controller  Performing self-check for domain test-90.euank.com
  Normal  SelfCheck            2m                cert-manager-controller  Performing self-check for domain test-89.euank.com
  Normal  ObtainAuthorization  1m                cert-manager-controller  Obtained authorization for domain test-90.euank.com
  Normal  ObtainAuthorization  1m                cert-manager-controller  Obtained authorization for domain test-89.euank.com
  Normal  IssueCertificate     10s (x2 over 6m)  cert-manager-controller  Issuing certificate...
  Normal  CeritifcateIssued    9s (x2 over 6m)   cert-manager-controller  Certificated issued successfully
  Normal  RenewalScheduled     9s (x4 over 6m)   cert-manager-controller  Certificate scheduled for renewal in 1438 hours

$ kubectl get secret test-88-euank-com -o json | jq '.data["tls.crt"]' -r | base64 -d | openssl x509 -noout -text | grep "euank.com"
        Subject: CN = test-88.euank.com
                DNS:test-88.euank.com, DNS:test-89.euank.com, DNS:test-90.euank.com

euank, thanks for pointing out the "I" character.
I ended up creating new resources under a different name and it worked.
I will see if I can recreate the issue next time I have access to that system.

I had the same problem. When I changed a domain name in the certificate, nothing happened. But when I added a new one, it worked. So maybe this helps in finding the bug.

I face probably the same issue. Wanted to change the issuer, and did following:

Updated Ingress to have certmanager.k8s.io/cluster-issuer: "letsencrypt-prod"
Nothing happened
Deleted the certificate
cert-manager created new one
expected it to update the secret, but did not :(

Deleting the secret is quite bad because then your service goes down for a moment. Overwriting the secret would be preferable.

This is now coming up to 2 months old, I see the tests haven't gone in and the PR looks stale (https://github.com/jetstack/cert-manager/pull/338): What's the situation with this now?

@Rambatino I've not had a chance to rebase and follow up that PR, no.
I will try and find some time over the next few days/week to take a look, but it is blocked on #110 (as we don't currently read the dnsNames/CN on the produced Certificate resource). That's what has made #338 more complex to implement 😄

/assign

/unassign
/assign @kragniz

This should not be closed, it still occurs.

Same, I just encountered this bug today.

Same bug today any workaround ?

I had the same issue. My Problem was that i work with GKE and have a couple of loadbanacer rules and domains. Cert manager wants to create one backend service for each domain. But by default there is a limit of backend services, so cert manager wasn't able to create back end services for http self check.

Still not solved :
I1105 17:40:48.676501       1 controller.go:68] Starting issuers controller
I1105 17:40:48.676603       1 controller.go:68] Starting certificates controller
I1105 17:40:48.676695       1 controller.go:68] Starting clusterissuers controller
I1105 17:40:48.679510       1 controller.go:68] Starting ingress-shim controller
I1105 17:40:48.776882       1 controller.go:140] clusterissuers controller: syncing item 'letsencrypt-prod'
I1105 17:40:48.777071       1 logger.go:88] Calling GetAccount
I1105 17:40:48.779684       1 controller.go:168] ingress-shim controller: syncing item 'production/service2'
I1105 17:40:48.779713       1 controller.go:168] ingress-shim controller: syncing item 'production/service1'
I1105 17:40:48.779835       1 sync.go:140] Certificate "star.mydomain" for ingress "service2" already exists
I1105 17:40:48.779764       1 sync.go:140] Certificate "star.mydomain" for ingress "service1" already exists
I1105 17:40:48.780340       1 sync.go:143] Certificate "star.mydomain" for ingress "service1" is up to date

But when I describe the certificate star.mydomain, I don't see the domain name of my ingress service2 :
Spec:
  Acme:
    Config:
      Domains:
        service1
      Http 01:
        Ingress:
        Ingress Class:  nginx
  Dns Names:
    service1
  Issuer Ref:
    Kind:       ClusterIssuer
    Name:       letsencrypt-prod
  Secret Name:  star.mydomain

Why doesn't it pick up the new domain and add it to the certificate instead of just thinking because the certificate exists, it does not have anything to do ?

Please re-open!

Are the certificate (secret) of non-existing app should be automatically deleted? Currently it doesn't delete the certs. It is like the sync never happen
I1108 19:41:24.188008       1 controller.go:168] ingress-shim controller: syncing item 'demo/helloworld'
E1108 19:41:24.188348       1 controller.go:198] ingress 'demo/helloworld' in work queue no longer exists
I1108 19:41:24.191391       1 controller.go:182] ingress-shim controller: Finished processing work item "demo/helloworld"
I1108 19:41:26.213131       1 controller.go:171] certificates controller: syncing item 'demo/helloworld-cert'
E1108 19:41:26.215593       1 controller.go:202] certificate 'demo/helloworld-cert' in work queue no longer exists
I1108 19:41:26.215635       1 controller.go:185] certificates controller: Finished processing work item "demo/helloworld-cert"

The cert is still there a good 30 minutes after deleting the app:
demo          helloworld-cert                                  kubernetes.io/tls                     2      52m

Workaround: creating a fake certificate valid in the past (with openssl by changing your computer date to the past) do force the update of the secrets

Nice hack but won't do. That is not a solution. Either we do something wrong or it diserves a fix.

As per @munnerz answer on November 14th in the cert-manager channel on Kubernete's slack:
replace the TLS secret with one that contains a keypair that is expiring within 30d, and also remove the `certificate.status.acme.order.url` field from the generated Certificate resource that should trigger a renew and ensure it performs a full renewal flow. I'm trying this solution in order to trigger the certification renewal process...

@munnerz I have same issue using v0.6.x helm on GKE. I update Ingress and add subdomain host, and no new cert requested. Apps still work and traffic routes but browser only shows old cert and warns site is insecure. Since I'm just prototoyping, I'll just rename the secrets and re-apply the ingress, but before converting from kube-lego this and multi-domain support in single Ingress worked.
Also, cloud versions of k8s still on 1.12.x so the v0.7.x helm requiring 1.13.x k8s unfortunately prevents me from trying the latest versions and I don't want to run manifests manually and add the flag. Hope this helps and looking forward to moving to latest version once cloud k8s providers can support.

I worked around this by simply changing the secret name in the ingress spec, like so:
spec:
  tls:
    - hosts:
        - redacted.com
      secretName: old-secret-name

to:
spec:
  tls:
    - hosts:
        - redacted.com
      secretName: new-secret-name

@derekrprice it doesn't work :(

@jocarren , try deleting the order
kubectl delete order <my-order>

Hello guys!
More info about that ?
Thanks :)

Please re-open!

I have found that deleting the order and then the secret works for me.

I have found that deleting the order and then the secret works for me.

Won't this still incur downtime?

still not working on GKE,
I have a CRD that handles which dns should be added into the certificate, the domain is well added to the certificate object but it did not issue a new certificate at all

still not working on GKE,
I have a CRD that handles which dns should be added into the certificate, the domain is well added to the certificate object but it did not issue a new certificate at all

@kragniz @munnerz There are quite a few people here claiming that this issue was not fixed by https://github.com/jetstack/cert-manager/pull/744 which was the reason @jetstack-bot auto closed this issue. Any thoughts?

Having the same issue, I cannot update dnsNames properly. I keep getting the secret, etc. with the old state. I am gonna try now to change the secret name everywhere and see what it happens. By the way, what creates the secret? Because I deleted the clusterissuer and certificate (my only two yml files) and the secret was still created again after deletion.
Thanks in advance.


optimized initialization and gc for the chassis

What type of this PR
Examples of user facing changes:

Bug fixes

In some environments, the ovs hostname parameter is changed to be different from the node name, which triggers an undesired chassis deletion. And the external chassis should not be removed by kube-ovn. So do the following optimization:

Add labels to the chassis managed by kube-ovn to avoid the impact on external chassis.
The gc code for redundant chassis is executed in the initialization phase.
Chassis 'name' is used instead of 'node name' as the unique index.
Optimize the delete command according to the OVN version, compatible with versions earlier than 20.09 .

@fanriming can you resolve the conflict in master? We did some refactor work to replace ovn-nbctl with libovsdb and may lead conflicts

@fanriming can you resolve the conflict in master? We did some refactor work to replace ovn-nbctl with libovsdb and may lead conflicts

resolved


problem when input files end with clean

tuple val(name), val('clean'), path('*clean.fasta.gz', **includeInputs: true**), emit: cleaned_contigs
should solve it

or just don't allow it


fix issues:#2840

add hive valid checker;
fix when no query Validation was not,get connection not check connection can execute sql;

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

如果数据库没有特殊要求，只需要配置druid.validationQuery="SELECT 1"使用默认的checker应该就足够了，数据库类型这么多，没必都添加一个checker。


fix unwanted CRLF conversion on windows

python 2.x does CRLF conversion on windows by default, causing my READs to be damaged.
Took my fix from http://stackoverflow.com/questions/2374427/python-2-x-write-binary-output-to-stdout

@erik-smit Thanks for your PR! Does this also work with Python 3? Can you try the suggestion from @ehem?

I don't really have time to further this, sorry.


Fix compilation error with simd feature

Which issue does this PR close?
Fixes a compilation error introduced in the last commit of PR #1161
That commit was supposed to only add some comments, but I also removed one unneeded Result return type and did not try to compile with the simd feature afterwards.
cc @alamb

FWIW I think a new version of rust (1.58) was released which is likely breaking some of the CI tests on master

Ah, I see there was also multiply_scalar introduced at nearly the same time, so it was the combination that failed.

Looks like the test failures on master are due to an intentional change in rust: https://github.com/rust-lang/rust/commit/8731d4dfb479914a91f650f4f124528e332e8128#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5
I don't know why we assert that exact formatting though. Also seems intentional because there is a range check in fmt::Display for parquet::record::api.


Cannot create twill users

When trying to create a user with the roles and permissions feature, it seems a role input is missing

That seems to be the source of the issue
 private function seedDefaultRoles()
    {
        // Default roles and their permissions
        $roles = [
            'Owner' => Permission::available(Permission::SCOPE_GLOBAL),
            'Administrator' => array_diff(Permission::available(Permission::SCOPE_GLOBAL), ["edit-user-roles", "manage-modules"]),
            'Team' => [],
            'Guest' => [],
        ];

I'm logged in as an Administrator, which doesn't have "edit-user-roles", that's not a sensible default I think
Also in this case the whole creation should be disabled

or we should show the list of roles with a position higher or equal to that of the current user's role

That's already the case in the logic if I just remove the @can, so I think we should just remove it

The all option is definitely a regression and should not end up there, that's for sure. The fact that you're logged in as administrator seems strange to me, you're supposed to be logged in as superadmin locally by default, which bypasses all checks, with or without permissions enabled. Were you logged in as a non superadmin before enabling advanced permissions?

you're supposed to be logged in as superadmin locally by default

Yes, but then you can create another user, give it the administrator role and login with it and that's when it happens, we can't just give superadmin permissions to everyone ;)

Of course not, I wasn't suggesting you need to use superadmin users, I wanted to understand why you were logged in as an administrator. Now I understand the non-sensible default you're talking about. I'm not sure if I agree though. In the defaults we provide (which are totally opinionated and not mandatory to use), admins are administrators of the content, not the larger system, which is owner's responsibility. Don't you agree that the ability to create new user roles needs to be gated more than creating/editing content?

Don't you agree that the ability to create new user roles needs to be gated more than creating/editing content?

The ability to create/edit roles yes, but the ability to create users no, which I think is the source of confusion, this permission is used to assert two very distinct things
One is to edit the roles

And to check to see if we can assign a role to a user
The second usage of the permission is the one we need to remove or change to a different permission


ARUTILS Missing

Most of the sample files are trying to Import <ARUtils/ARUtils.h>, but this is not included in the SDK, just the similar <libARUtils/libARUtils.h> which does not work in its place.
This makes the examples broken and unusable!!

See this issue for more informations.


New Case Dedup Search Dropdown Does not work

Go to /work or /phone.
Create a new case.
As you type the name, possible duplicates should appear. Click on one of the duplicates.
Expected Behavior: Clicking on the existing case should edit the case. Bug: Nothing happens.
Do the same thing for Address. Same error may occur.
FF and Chrome

This is almost fixed. The case now successfully loads and jump to the location on /work. However, it does NOT zoom into the correct location for /phone.


Add initial, basic da (Danish) translation

Commit made via Stringlate

We can wait until the translation is complete, thanks!


[DRAFT] Accessibility of anchors and sample improvements

Fix #1681
Partial fix for #1444
[NOTE]: I'm still proofreading these files; not ready for critique yet. :P

Coverage remained the same at 53.715% when pulling 11e6d7b31024bb073bedaae9794de371a34765db on corinagum:corinagum/1444-b into da986023a0b2804f77faefe9d2793008b2f0555c on Microsoft:master.

Restarting build due to timeout error.

Rebased, waiting for build.


problem multi/launcher to bat

Empire Version
last
OS Information (Linux flavor, Python version)
kali 2017.2
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
if I copy and paste the command directly into the terminal, empire works, but if I want to copy it in an arhivo bat this is not executed and I tried to understand the code because I was accommodating so the powershell process is executed but only by an instant and is closed, however if I copy one by one each line of code in the terminal this if it connects

Screenshot of error, embedded text output, or Pastebin link to the error
also the windows / launcher bat if this is obfuscated, does not connect!

@gearcapitan please see #682


Handle package name collisions

Updates imports to add aliases (autogenerated using a numeral suffix) for package name collisions. This should address #68.

Hey @mterring, I have been rather busy and haven't been able to properly review this. I'll try to take a look in the next week.

@mterring Could you rebase this against the master branch?

This problem might be fixed now?

Yes, closed via #141.

Thanks to @mterring for the contribution.


HUD-Related Missing Externs?

Hello, I'm porting the FPS HUD to Haxe, and have run into a few issues:

The AHUD class seems to be missing the DrawHUD() function.
UCanvas is missing DrawItem()
FCanvasTileItem class is missing

Should I be approaching HUD rendering another way?

These functions were not autogenerated because they are not UFUNCTIONs on C++. You can still use them - but you have to manually write extra externs. You can read about the _Extra.hx externs at https://github.com/proletariatgames/unreal.hx/wiki/Extern-definitions , and you can have a look at some of the externs we've already got at Haxe/Externs/Common . Feel free to submit them as a PR once you've got them right.

I'm closing this - but feel free to reopen if you think there's an issue


Autorestic and auto-restic

Hi there,
Recently I found your compose-scheduler and really liked it so now I'm bringing into my homelab. Of course, I checked the author's profile looking for more interesting stuff and found this repo. The repo drew my attention because there was an autorestic I was using already. This one: https://github.com/cupcakearmy/autorestic.
If you didn't know about it before, than I'd suggest you checking this out, because I think I can already have solved some of yours auto-restic problems

Thanks! Will take a look.


Add arrows to edges for directed network graphs

I see an example of a network graph at http://holoviews.org/gallery/demos/bokeh/network_graph.html but the edges between the nodes are missing arrowheads.  Is it possible (and preferably easy!) to display the edges as arrows in HoloViews?
I really want to be able to draw directed graphs like the D3 examples at https://bl.ocks.org/cjrd/6863459 and http://bl.ocks.org/rkirsling/5001347. But I'm struggling to find a Python visualization library that will allow me to do this.

Graphs now support a directed plot option which adds arrows indicating the directionality.

Thanks very much!


8080 port stopped working on my Sonnen Battery

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots & Logfiles
If applicable, add screenshots and logfiles to help explain your problem.
Versions:

Adapter version:
JS-Controller version:
Node version:
Operating system:
Battery model:

Additional context
Add any other context about the problem here.
Sonnen might have discontinued the 8080 port on the Sonnen http api.  Port 80 is used now.

#152


SmartRefUnbinder: Exception when connecting UnbindOnDestroy

Hi again.
Using master, I'm getting the same error as with the unity package described in issue #13.
Firstly, if Auto Listening is enabled in the inspector, I'm getting a NullPointerException, because SmartRefUnbinder is trying to call GetField on a field that does not exist:
FieldInfo ownerGoId = typeof(SmartData.Abstract.SmartRefBase).GetField("_ownerGoId", BindingFlags.NonPublic | BindingFlags.Instance);

In SmartRefBase, the field is called ownerId, not ownerGoId. Changing the string fixes that bug.
Secondly, regarding the addition of multiple SmartRefUnbinder monobehaviour instances:
The code in UnbindOnDestroy is just adding components, and is never checking if there already is a SmartRefUnbinder component existing on the related game object. Only adding the component if there is none fixes that error as well.
I can create a PR for this if you want. That would target master if that's fine. Honestly, I don't want to switch to dev if I don't have to. Speaking of that, there are no differences related to the changes I spoke about so the patch could be applied as-is on both branches.

Hi - I've now fixed this on master and dev, along with a bunch of other things. I'm planning to do a new release .unitypackage shortly as well.


Reference y2 axis with json input

Hi,
I did my research but did not manage to find any way to perform the following.
The backend is providing me with the json array shown below.
What I want to achieve is to have 2 y axis. Lead & Conversion will reference the y axis while Rate will reference the y2 axis.
    [
       {"name": "google search", "Lead": 250, "Conversion": 59, "Rate": 50},
       {"name": "facebook advertisement", "Lead": 104, "Conversion": 20, "Rate": 60},
       {"name": "ST Ads", "Lead": 200, "Conversion": 123, "Rate": 70}
    ]

In the example provided (http://c3js.org/samples/axes_y2.htmlhttp://c3js.org/samples/axes_y2.html), this could be achieved by doing the following.
    columns: [
            ['data1', 30, 200, 100, 400, 150, 250],
            ['data2', 50, 20, 10, 40, 15, 25]
        ],
        axes: {
            data1: 'y',
            data2: 'y2'
        }

I thought my scenario would be a pretty common use case, yet I didn't find anything regarding it. Am I missing out something? I hope to get some advice, thanks!

Hi limjunyangleon
I was looking for the same case and I've found the way to do it. For instance take Rate from your json data definition as the y2 you must place as below:
var chart = c3.generate({
bindto:'#chart',
data: {
json: [
{"name": "google search", "Lead": 250, "Conversion": 59, "Rate": 50},
{"name": "facebook advertisement", "Lead": 104, "Conversion": 20, "Rate": 60},
{"name": "ST Ads", "Lead": 200, "Conversion": 123, "Rate": 70}
],
keys: {
x:'name',
value: ['Lead', 'Conversion', 'Rate'],
},
axes: {
'Rate':'y2'
},
type: 'bar',
types: {
'Rate': 'line'
}
},
axis: {
x: {
type: 'category'
},
y2:{
show:true
}
}
});

That helps! Tested and it works. Many thanks @josejcardenas


Add documentation for use of dateTimestamp variable in yamls

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
Detail information: https://harness.atlassian.net/browse/CDS-91198
What Type of PR is This?

[ ] Issue
[X] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

@rohitk-h Please review my minor changes. Upon approval, I'll merge the PR. Thanks.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65cbd4b173b81220f4824db5--harness-developer.netlify.app


wait for node UI to get assigned before finishing rendering it

this isn't the right fix here. aborting


Backport PR #1800

Backport PR #1800 from upstream , which fixes a bug in destructing functions with optional arguments.

I can confirm that this PR is a correct backport of the patch from upstream merlin. So that's good.
But I think there is a better way to do this: just fix Untypeast. The fix as written is fragile, in that it will do the wrong thing in the presence of ghost locations from ppxes.
I would think a better solution would be to record, in typedtree, whether an optional argument was actually passed or not. Maybe by editing arg_label, or maybe by using Omitted somehow.
That said, it's probably best just to merge this patch for now. I predict, though, that we'll get reports of new odd behavior soon.

Do you know if there's a reason why the code doesn't also look for whether the argument is None? That would keep benign any unforeseen interaction with a ppx, I think.

@goldfirere For what it's worth, Merlin destruct already does the wrong thing in the presence of ppxes. For example, destructing let%map x = y in z will produce match Let_syntax.map y ~f:(fun x -> x) with .... This preserves semantics, unlike the potential bad interaction you're talking about, but I would argue it is just as bad because users will still go back and modify the code produced by Merlin.
I do agree though that modifying the typedtree would be a nicer solution. An even nicer solution in my opinion would be recovering the original text typed by the user and using it instead, which would circumvent any ppx issues.
I think @ncik-roberts solution of checking whether the argument is None is a reasonable improvement on this backport. I'll do that.

I'm going to hold off merging this until Nick's suggestion has filtered into upstream and then replace my changes in this PR with that. That way, we keep in sync with upstream.

https://github.com/ocaml/merlin/pull/1807 appears to have been merged into ocaml/merlin.

ocaml/merlin#1807 appears to have been merged into ocaml/merlin.

I've brought in that change now.

Looks good to merge


Use the ember-data initializer as a target instead of the soon to b…

…e deprecated store initializer
Hello, The store initializer target currently is a empty initializer in Ember Data. I have an RFC and a PR to deprecate it a future Ember Data release. I did a search and found your addon is using the store initializer  target and I have opened this pr for you to use the 'ember-data' initializer instead which will continue to be supported after the empty initializers are deprecated.

@bmac thanks for the heads up.
This addon is no longer under development as stated in the README.md file. All users of this addon should move to https://github.com/clintjhill/ember-parse-adapter/.


refreshing the page go to the error page

Hi Thanks of creating this awesome boilerplate i know yii2 is the latest version but our website is built on Yii and the main app is inside a different folder and we wanted to bring it to the root folder. Your boiler plate did the fantastic job there but have one issue that when i refresh the page it redirect to the error page instead of the actual route. Is there a work around or fix for this ?

I think you need to create a "catchall" route to serve the index.

Thanks wlepinski, that worked like a charm.

you are awesome sir, Thanks a ton for this boilerplate.


[$500]  IOU - Message doesn't contain description when Copy to clipboard on money request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: https://github.com/Expensify/App/pull/36993
Issue reported by: Applause - Internal eam
Action Performed:

Create a workspace and invite some users
As employee, create a money request with description in the workspace chat
As admin, paid this request
As employee hover or long press on money request preview > Copy to clipboard
Paste the message to composer

Expected Result:
Pasted message should contains the description
Actual Result:
Pasted message doesn't contain description when Copy to clipboard on money request preview
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/31e3d675-b340-4d52-9ee8-c1ba87c7b086
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011e3619582ba70c09
Upwork Job ID:<PHONE_NUMBER>212392448
Last Price Increase: 2024-02-27

We think that this bug might be related to #vip-vsb
CC @quinthar

@dukenv0307 @DylanDylann @srikarparsi - Is this a regression from https://github.com/Expensify/App/pull/36993?

I will check today

@AndrewGable I don't think this is regression from https://github.com/Expensify/App/pull/36993
cc @dukenv0307

IMO, this is not a bug. Let's see this case:
https://github.com/Expensify/App/assets/141406735/b984ad0b-4e03-4e3e-8bd6-e5a38feaa2ca
We have 2 requests with different descriptions. Then admin pays both requests. If we want to display a description in the paid message, which description should be displayed

@isabelastisser - Can you confirm this is not a bug as proposed by @DylanDylann? I agree with them


Detect email change event

Feature request
Is your feature request related to a problem? Please describe.
We should automatically detect an email_change_token in the web address and then handle the email update
Describe the solution you'd like
Updating the email field will cause a "Confirm Email Change" email to be sent to the new address.
When the user clicks the Confirm link in the Confirm Change email they will be forwarded to:
<SITE_URL>?email_change_token=x&type=email_change&redirect_to=y
Your app must detect the email_change_token in the search params.  You should then use the email_change_token in the url to update the user's email as follows:
const { error, data } = await supabase.auth.update({
  email_change_token: emailChangeToken,
});

Additional context
https://github.com/supabase/supabase/pull/2380

I don't see any changes in the GoTrue JS client w.r.t. handling email_change_token but it seems like we no longer need to update the email with the email_change_token. As users of the Supabase JS isomorphic client, do we still need to handle email_change_token on our own client code?

I'm not sure this is true? The email_change_token I believe is being consumed by GoTrue and confirming the email, after which point a redirect is made to your app. There shouldn't be any involvement of the JS library.
Is this still an issue? @kiwicopple @liaujianjie


Test 'gets a gene set with ranks' is failing

Describe the bug
The test is failing on the main branch:
1) Gene Set Queries
[40](https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:41)
       gets a gene set with ranks:
[41](https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:42)
     TypeError: Datastore.getGeneSetWithRanks is not a function
[42](https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:43)
      at Context.<anonymous> (file:///__w/enrichment-map-webapp/enrichment-map-webapp/test/test_datastore.js:45:37)
[43](https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:44)
      at processImmediate (node:internal/timers:466:21)
[44](https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:45)

To Reproduce
Run the tests or look at the CI log: https://github.com/cytoscape/enrichment-map-webapp/actions/runs/3128521477/jobs/5076464427#step:6:42
Expected behavior
Passing tests / green CI results
Additional context
Maybe this test isn't necessary / up-to-date right now?  It could be set to be skipped for now.  @mikekucera, what do you think?

I need to update the test.

Fixed properly now.


fix 'no-loop-func' warnings

Comments
I have extracted the functions outside for loop, let me know if you have any different thought on naming the functions.
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the following...

Impact:
Migration path for existing applications:
Github Issue(s) this is regarding:

Other information:

Thanks


fix: close circuit-relay streams on connection failure

If a dial to a relayed address fails, e.g. with status NO_RESERVATION, the newly created /libp2p/circuit/relay/0.2.0/hop stream is never closed. This can be particularly bad if the connection manager keeps auto-dialing the address, since the streams just accumulate until they hit the max per-protocol stream limit (64). I believe this is the ultimate issue behind #1695.
I don't know whether closing or aborting the stream is more correct, or if it's important to catch potential exceptions in await relayConnection.newStream call, so this may need a little revision from someone with more context.
Also, I know that you typically want PRs to include tests covering the fix - I gave it a couple tries but couldn't figure out how to set one up for this scenario. Sorry!

Good catch!


Feat store security keys

Connects to OSGP/Platform#299

SonarQube analysis reported 6 issues:

 3 minor
 3 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Complete the task associated to this TODO comment.
 Complete the task associated to this TODO comment.
 Complete the task associated to this TODO comment.
 Rename this field "HLS3Active" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
 Rename this field "HLS4Active" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

All is well.


cleaning up logs a bit

Will do it at other places as well once the refactor PRs are merged.

Codecov Report

Merging #202 (25d38f2) into master (2bdcb1d) will decrease coverage by 3.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   35.98%   32.63%   -3.35%
==========================================
  Files          93       93
  Lines        3910     3925      +15
==========================================
- Hits         1407     1281     -126
- Misses       2388     2546     +158
+ Partials      115       98      -17

Flag
Coverage Δ

integration
?

unittests
32.63% <0.00%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/subscriber/subscriber.go
0.00% <0.00%> (ø)

pkg/messagebroker/factory.go
33.33% <0.00%> (-33.34%)
:arrow_down:

pkg/messagebroker/kafka.go
10.18% <0.00%> (-31.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bdcb1d...25d38f2. Read the comment docs.


discord.gg/rem no longer works.

I mean its kind of obvious but the invite link for the bot no longer works. By not working, i mean it says that the invite has expired.

Yup we changed the url to end with /wolke


Docker 17.06.2 available on Amazon Linux 2017.09

Cookbook version
v2.16.4
Chef-client version
12.21.26
Platform Details
Amazon Linux 2017.09
Scenario:
docker-17.06.2ce-1.93.amzn1 is available on Amazon Linux from the amzn-updates repository but the cookbook is still defaulting to docker-17.03.2ce-1.59.amzn1.
Any chance we can get a default docker version bump in helpers_installation_package.rb?

Since MR #939 is merged, this issue can be closed.
Thanks!!!


[USERSNAP] Hi, I see Gov Tools reporting that I have delegated 26,000 to myself as a Drep. However, I have not delegated that amount. I have delegated only around 1400 ADA to myself.

Taken at: https://gov.tools/connected/drep_directory/drep14l69ewnmc5h6uftda9ghs3mw49hdu7w93e9alhzxckp0v5pczql
Fields:

Add a comment: Hi, I see Gov Tools reporting that I have delegated 26,000 to myself as a Drep. However, I have not delegated that amount. I have delegated only around 1400 ADA to myself.

Browser: Chrome 129 (Windows 10)
Screen size: 1921x965
Open #137 in Usersnap
Powered by Usersnap.

@Ryun1 This seems interesting, Im thinking you might know something about it, feels familiar.

Fixed with #2000.


Liking socials in contact us page

Is your feature request related to a problem? Please describe.
Currently in contact us page there are social icons are given like github linkedin but it does not redirect to anywhere.

Additional context
please aasign this issue to me under GssoC

Minor Problem ...I request to look into major problem consisting of level 3


(PEAR-1467): Changing display of days to years and days in case summary

Description

Changing display of "days" to "years and days" in case summary

Checklist

[x] Added proper unit tests
[x] Left proper TODO messages for any remaining tasks
[x] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

only took a glance, but looked ok. go ahead and merge if code looks ok, @ebusygina can do the UAT when it's deployed to QA. 👍


Event: TODO item, TODO due date

@gperu requested a "TODO next", "TODO due date" fields for an event.
They would indicate what's next to do for that event ("contact organizer", "send pre assessment forms", etc.), so that admins don't have hard time remembering what they needed to do.

Would a checklist per event serve the same purpose?  Maneesha suggested
that a while back...

Checklist is not flexible enough (and both Giacomo and Maneesha voted for a flexible solution). This solution can be like a drop-down with option to type in own TODO text.
When admin needs some standard TODO item, they just select it. When they need something extraordinary, they just type it in. Like a combo-box widget.

Following up on our meeting earlier today, just to be clear... the tasks
involved in workshop organization are not always ordered, serial tasks but
are often unordered and parallel.  It is never the case where there is one
finite pending task, and then when that's complete the next one will be up,
and so on.  So this will be a one-to-many relation, where we can continue
adding to-do tasks to each event. Correct?

—
Reply to this email directly or view it on GitHub
https://github.com/swcarpentry/amy/issues/483#issuecomment-136729477.

Hello, @maneesha.
I think the original idea was some sort of "soonest TODO item" and "soonest TODO item's due date".
Do you think you'd use the 1-to-many relation for any TODO items?
Ie. @gperu and @maneesha, do you think you would keep more than one TODO item for a workshop?
Cheers,
Piotr

Yes -  I definitely want more than one TODO for any workshop.  Steps
involved in workshop organization are typically unordered (or just roughly
ordered)  and parallel, not ordered and serial, so having just one next
TODO wouldn't make a lot of sense.
On Thu, Sep 3, 2015 at 5:24 AM, Piotr Banaszkiewicz <
<EMAIL_ADDRESS>wrote:

Hello, @maneesha https://github.com/maneesha.
I think the original idea was some sort of "soonest TODO item" and
"soonest TODO item's due date".
Do you think you'd use the 1-to-many relation for any TODO items?
Ie. @gperu https://github.com/gperu and @maneesha
https://github.com/maneesha, do you think you would keep more than one
TODO item for a workshop?
Cheers,
Piotr
—
Reply to this email directly or view it on GitHub
https://github.com/swcarpentry/amy/issues/483#issuecomment-137389679.

Agree with @maneesha that multiple TODOs are needed. Maybe a checklist that's split up by general time frame? e.g.
Start:
-[ ] Set up workshop website
-[ ] Find instructor 1
-[ ] Find instructor 2
-[ ] Set date with host
Middle:
-[ ] Follow up that instructors have booked travel
-[ ] Set up pre-workshop survey
Just before workshop:
-[ ] Make sure instructors are set with materials
After workshop:
-[ ] Submit invoice
-[ ] Make sure instructors are getting reimbursed
I'm not sure if AMY is the system for this or if it would just be better to use Trello or Insight.ly or another to do system.

I'm happy with whatever is decided and I'm sure it'll be good.
From my point of vew, I would have liked to have a simple free text box, to appear in my dashboard, reminding me what I have to do, e.g. tomorrow, for a workshop. Like a post-it. Very easy and flexible.


Tests

We need to support CI. We will probably use Travis.
Some challenges include:

Testing against a large database hosted elsewhere
Testing commands that will have different results since it works with realtime data
Testing the initialization of the database

Tests are not the highest priority right now, but should be supported before 1.0.0

Yes. I 100% agree with this one. A few other tests might include if we connect to external systems for license and vulnerability issues.

For unit testing, unittest (also known as pyUnit) could be a good choice.  It is included in Python standard libraries.
Documentation:
https://docs.python.org/2/library/unittest.html
unittest is also used in Django for testing:
https://docs.djangoproject.com/en/1.10/topics/testing/
It's a good idea to create unit tests early on, as it will be much easier to implement them at the same time as the code than to go back later and try to add unit tests to code that was not set up to accommodate them.  It will also help to determine whether anything has broken due to a change, and serve as extra documentation for how things are expected to work (assuming the tests are kept up-to-date with the code)

I just added some basic unit tests for the library functions using pytest to the repo. Are those good for the baseline library functions? I'm also working on a travis.yml to add as well

Thanks for the tests!  Could you please comment and indicate what the tests are doing and how they demonstrate that things are working?
For example, you have this test:
def test_commits(gh):
assert gh.commits('8').isin(["2013-01-07"]).any
My best guess is that you are asserting that repo id 8 made at least 1 commit on 2013-01-07 (which you likely pre-checked in msr14 database to find a repo with commits for that day), and you are doing this test in order to demonstrate that the commits function is returning an expected result for this query.  Is that the case?

Yep, that's right! I'll get the comments in later today. Also, our Travis build is successful with 3.6, but not 2.7. I'll look into that as well

Ok thanks

I added some comments in test_ghdata.py to give the general format for my tests. Let me know if I need to go into more detail. Also the 3.6 build is passing. There are issues with pytest and 2.7, but travis is messed up because of the AWS outage, so I'll get it fixed as soon as I can.


Release 0.19.0

https://babelfish.arc.nasa.gov/confluence/display/FFFSW/IRG-FFTEST302+-+2024-06-10+-++0.19.0+-+Astrobee+Release+Testing
There is a commit changing the control file. This was done on the 0.18.0 release but I must have forgotten to push before merging it, so the 0.18.0 debians use the fix.

@rsoussan do you want to add the "A. Optional Log Playback Testing" to the release test? (https://babelfish.arc.nasa.gov/confluence/display/FFFSW/IRG-FFTEST302+-+2024-06-10+-++0.19.0+-+Astrobee+Release+Testing)
I repeated the mobility stress testing with the same results we got previously


Ensure valid filename for cover art

Apostrophes in title cause a problem (Ain't that a kick in the head)

closed by pull request #17


Suggestion: README.md: Instructions

After...
yarn init
yarn add blendid
...Add an instruction to add "blendid" to the "scripts" section of the project's "package.json", followed by the existing...
yarn run blendid -- init
yarn run blendid

you don't need to with yarn. It automatically looks for scripts in node_modules/.bin, where the blendid script lives


Updated index.json

Pull Request Title
Added Project in index.json
Description
Added project sample-js-job-scaper in index.json file.

[ ] This change requires a documentation update
[ ] I have made corresponding changes to the documentation

Related Issue(s)
This PR addresses issue #X
Screenshots
If relevant, please add screenshots.
Notes
Please add any relevant notes if necessary.

@PRASUN-SITAULA please resolve the conflict

@PRASUN-SITAULA please resolve the conflict again


Make viewer's loading time faster by skipping loading all images

Hello!
First of all, thanks for the v1.0.0 update! Looks amazing and promising very much.
I have a question / request: is it somehow possible to make model's loading time in the viewer faster?
It seems that the viewer loads all training images before rendering, as well as the checkpoint itself.
I assume that a certain part of the viewer's code requires the number of training images (maybe the appearance embedding?), which can be exhaustive and time-consuming when the dataset is very large.
If my assumption is true, can't we store the number of images as an attribute after loading them for training?
If not, what is the reason for loading the images and how can i manually override this?
Thank you very much in advance!

I think this is kind of tricky. The whole pipeline is instantiated when you run viser, and all the images is cached when the datamanager is instantiated with the pipeline. In more detail, the dataparser pass the path to the images to the datamanager then datamanager caches them. I used a super hacky way to bypass these, but I don't think it worth a try. (actually the viser can still show images without caching them...) So there is no elegent method I think and preventing the datamanager from initializing just breaks everything...


bump to  4.0.1

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thank you.


[FEATURE]

Description
In order to asign users created from LDAP login in CH a specific role, <user_directories> in config.xml needs to be created from a list, not a dict.
Additional Information
[Any additional information, configuration or data.]
https://clickhouse.com/docs/en/operations/external-authenticators/ldap

I'm using this issue to generalize not only the role mapping but also the definition of ldap servers, enabling several ldap servers in same CH server


Slow Tab perfomance on Webview

I'm trying to implement these React components in my webapp, that renders on Android with a Webview.
I'm not having issues on a mid-budget Android Phone, but on an older phone like the Huawaei G Play Mini, the tabs are very resource-heavy, and make the whole experience sluggish so much it takes even 2 seconds before registering an input. I've even tried to update the Webview package, with no luck.
Is there anything I should consider before scrapping these components?

@riccardo-lomazzi could you please share a codesandbox of your working code? It would help to see the code you're working with.
In the meantime I will try to reproduce on my end.

@riccardo-lomazzi I tested to see if extra renders were trigger from a tab click. This triggered 2 render cycles. One change from props.activeIndex changing, and one from the anonymous function handleActiveIndexUpdate. I made handleActiveIndexUpdate a component method, which reduced this one render cycle. Documented in this PR.
The only other thing I can think of is that MDC Web's foundation is sluggish. During click it does have a call to computeIndicatorClientRect(). Could this be causing your issue?

Closing this since its gone stale.


Support reading compressed .augfastq files

Already supported for khmer consume_ functions, but not yet for augmented Fastq files.

Added in #65.


Custom video object detection not picking up the GPU.

Hi,
I'm using custom video object detection with YOLOv3. Provided below is my detection script:
frames_li = []
path = os.getcwd()

latest_file = "Model_PATH"
print(latest_file)
video_detector = CustomObjectDetection()
video_detector.setModelTypeAsYOLOv3()
video_detector.setModelPath(latest_file)
video_detector.setJsonPath(os.path.join(path, "json/detection_config.json"))
video_detector.loadModel()
video_detector.__detector = []
cap = cv2.VideoCapture("VIDEO")

app = Flask(__name__, static_folder="static")
def detection():

    output_frames_dict = {}
    output_frames_count_dict = {}

    frames_per_second = str(cap.get(cv2.CAP_PROP_FPS))

    counting = 0

    detection_timeout = None
    log_progress = True

    frame_detection_interval = 1

    prev_count = 0

    minimum_percentage_probability = 45
    display_percentage_probability = True
    display_object_name = True
    flag=""
    status = ""

    detection_timeout_count = 0
    video_frames_count = 0

    while True:
        ret, frame = cap.read()

        if (ret == True):

            detected_frame = frame.copy()

            video_frames_count += 1
            if (detection_timeout != None):
                if ((video_frames_count % frames_per_second) == 0):
                    detection_timeout_count += 1

                if (detection_timeout_count >= detection_timeout):
                    break

            output_objects_array = []

            counting += 1

            if (log_progress == True):
                print("Processing Frame : ", str(counting))

            check_frame_interval = counting % frame_detection_interval

            if (counting == 1 or check_frame_interval == 0):
                try:
                    detected_frame, output_objects_array, flag = video_detector.detectObjectsFromImage(
                        input_image=frame, input_type="array", output_type="array",
                        minimum_percentage_probability=minimum_percentage_probability,
                        display_percentage_probability=display_percentage_probability,
                        display_object_name=display_object_name, count=counting,
                        status=status)
                except:
                    None

            if flag and status == "":
                status = "Jam Detected"
                prev_count = counting + 150
            if not flag and "Jam" in status and prev_count <= counting:
                status = ""

            output_frames_dict[counting] = output_objects_array

            output_objects_count = {}
            for eachItem in output_objects_array:
                eachItemName = eachItem["name"]
                try:
                    output_objects_count[eachItemName] = output_objects_count[eachItemName] + 1
                except:
                    output_objects_count[eachItemName] = 1

            output_frames_count_dict[counting] = output_objects_count

            ret, jpeg = cv2.imencode('.jpg', detected_frame)
            frame = jpeg.tobytes()
            yield (b'--frame\r\n'
                   b'Content-Type: image/jpeg\r\n\r\n' + frame + b'\r\n\r\n')

The detectObjectsFromImage is defined here.
I'd trained the model on a custom class and the script is not using GPU to make predictions.

I'm having the same situation, GPU works fine when I use detection but it took almost 100% CPU when I'm using prediction and custom training object model.

I've met the same situation, but not only when I used the custom video object detection.
Almost all kinds of methods I used, didn't pick up the GPU.
If any progress, please remind me

Similar issue here. Although I was running it in a kaggle kernel. It took forever and the GPU usage bar stayed at 0%.
I did install
!pip install tensorflow==1.15.0
!pip install tensorflow-gpu==1.15.0

So this could not have solved the issue...

@cis-apoorv @Crema1127 @philippwulff  Which GPU card did you use? I would like to do the same for an alarm system, and i would like help my CPU (i7 7th generation 8 core) with a GPU.

@cagnulein I was using GTX 1080 Ti and I tried it over RTX 2060 as well. Didn't work on both. Are you trying to use the Yolo model for your task?

@cis-apoorv yes, i'm using Yolo-tiny on my system (it's running behind proxmox without a GPU). I would like to help the CPU with a GPU.
Did you try to check if your installation is ok?
For example with this little script

import tensorflow as tf
if tf.test.gpu_device_name():
   print('Default GPU Device:{}'.format(tf.test.gpu_device_name()))
else:
   print("Please install GPU version of TF")

@cagnulein I checked for the installation as well but wasn't able to get it running. So, as I was short on time, I used https://github.com/zzh8829/yolov3-tf2.
I would suggest you try this one if you are short on time because it worked for me.

@cis-apoorv tested, and you were right, was very easy! Here you can find my benchmark https://robertoviola.cloud/2020/08/12/video-detection-gpu-vs-cpu-for-your-home-alarm-system/


Minaw.wu

Get leaderboard use case with basic visuals and test

Also for future PRs, please give your branches more descriptive names that relate to the feature that's being implemented. An appropriate name for the branch for this PR would be implement-leaderboard-usecase


Fix or eliminate ChallengeGenerator

The ChallengeGenerator in 0.0.3 version allows the API user to replace the function which generates the challenge bytes. At present, this structure cannot be extended as no public initializer exists. To fix, just add a public initializer.
Alternatively, the structure can be eliminated entirely by allowing the API user to optionally pass in challenge bytes to the WebAuthnManager beginRegistration and beginAuthentication functions. If a byte array of the correct length is passed in, these are used; otherwise, the code just calls [UInt8].random(count: 32) as provided in the default implementation of ChallengeGenerator.
Fixing ChallengeGenerator is the easy fix, but eliminating it feels like a cleaner API since this is the only place where random numbers appear to be generated.

[Apologies, somehow accidentally submitted before writing the description.]
The ChallengeGenerator in 0.0.3 version allows the API user to replace the function which generates the challenge bytes.  At present, this structure cannot be extended as no public initializer exists.  To fix, just add a public initializer.
Alternatively, the structure can be eliminated entirely by allowing the API user to optionally pass in challenge bytes to the WebAuthnManager beginRegistration and beginAuthentication functions.  If a byte array of the correct length is passed in, these are used; otherwise, the code just calls [UInt8].random(count: 32) as provided in the default implementation of ChallengeGenerator.
Fixing ChallengeGenerator is the easy fix, but eliminating it feels like a cleaner API since this is the only place were random numbers appear to be generated.

This was probably exposed to allow for testing, but we can use the new package visibility stuff instead to fix this and remove it from the API


Add normalise_url parameter to Crawly.Middlewares.UniqueRequest

This parameter allows to customize the normalization behavior using a unary normalization function.

Sorry, I don't understand the idea behind this change. Could you please explain?

It allows you to use a different normalization function without having to replace the whole UniqueRequest middleware. For instance, while some search engines consider URLs with and without a trailing slash as identical, others do not. Some go even further and treat /index.html the same way. Some transform the host part of the URL to lowercase and some even sort the query string parameters alphanumerically or resolve relative paths. For example I use this normalization function:
  def normalize_url(url) do
    parsed = URI.parse(url)

    if parsed.scheme in ["http", "https"] and parsed.host do
      %URI{
        scheme: parsed.scheme,
        host: String.downcase(parsed.host),
        path: parsed.path,
        query: parsed.query
      }
      |> URI.to_string()
    else
      nil
    end
  end

Section 6 of RFC 3986 goes a bit deeper into the topic of URL normalization.

I found out that Erlang comes with a RFC 3986-compliant URL normalization function: :uri_string.normalize/1
I believe it's still a good idea to allow people to provide their own implementation, because some might want to extend the behavior of the RFC, like for example Cloudflare or Kaspersky do.


Bigdclock v0.07

Better battery graphic - now has green, yellow and red sections
battery status reflected in the bar across the middle of the screen
better handling of locale

re that last one - not everyone has a locale set up, and when you set a locale up, it seems the date_utils.js disappears or becomes unavailable???
(I've incorporated https://github.com/espruino/BangleApps/commit/5b1b3553c5a028c595845434762147b28de317a6 as best I can).

re that last one - not everyone has a locale set up, and when you set a locale up, it seems the date_utils.js disappears or becomes unavailable???

That shouldn't happen as date_utils gets included in the JS file as it is uploaded. It's just not possible for locale to remove it.
I imagine it just happened because you uploaded your app through the IDE without having the path set in the IDE settings? Info at https://github.com/espruino/BangleApps/blob/master/modules/README.md

not everyone has a locale set up

Absolutely everyone has locale set up. It's included in the firmware, so if you don't have one installed you get the default english locale.
Please could you take out those locale changes? The original var dows = require("date_utils").dows(0,1); will work fine - this gets included all the time by the app loader, and uses locale so will be internationalized. There's really no reason for the try - I think it just stems from you uploading from the IDE without having the Bangle.js libraries in your search path

Yes you were right. Changed implemented. Also I now only check the battery state of charge every 15 minutes instead of every minute, giving me noticeably extra time between having to charge!

Great - thanks! Just merging...


Slight SSAO Tweak

Introduction
As things stand, with the SSAO setting enabled, items have a black "halo" around them, caused due to a huge difference in depths of adjecent pixels. The traditional way to handle this is by using a "rangeCheck" function, that ignores pixels with a huge difference in depth. This was already implemented in Terasology, but the halo still persisted.
What this PR contains
Slightly tweaks the parameters of rangeCheck, to better handle the difference check.
The SSAO effect in general should remain unchanged, and should still apply to hand-held items.
Screenies
Because who doesn't like images? :D
Before | After

Hooray Jenkins reported success with all tests good!

Whoo!  This always bugged me!  :-D

I want to come clear and state that the "maxDepthDifference" parameter is a pretty subjective value.
In fact, I would highly appreciate other people testing it and letting me know what value works best for them!
Procedure to change the parameter real-time: Run the game with this PR (and with SSAO enabled), and once you are in a world, navigate to \engine\build\classes\assets\shaders\ssao_frag.glsl, change the maxDepthDifference parameter to whatever you want and run recompileShaders in the game console. This should allow you to view the changes in real-time.
[ I've currently selected a value that does not change the look of the game, and still eliminates the halo around objects (while still retaining the shadow-ey effect when you look at the ground). ]

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

I played a bit with the maxDepthDifference parameter. I think the value you have chosen, 1, works better than 2. 2 seems to produce subtle but noticeable artifacts. Sure, the AO effect could be darker, but it's not a big problem I think, I like subtle effects, and we can re-evaluate it when we descend into ShaderLand to refactor all shaders.

By the way, you didn't rename all instances of ssaoRad.

Hooray Jenkins reported success with all tests good!

@Cervator: good to merge for me! @vampcat: thank you!!!

Cool! I had wondered what that was :-)
I tried it out real quick and saw the effect sort of creep back in when you get very close. But it seems to have been a thing before too, so - tweak indeed :D
Before:

After:


Implement Array.observe

Based on the spec.
Basically, it's a matter to implement the detection of the splice event inside the dirty checking loop. Array.unobserve should behave just like Object.unobserve.

:+1: Do you have any plan for this?

In fact, I do.
It's not a problem of detecting "splice" changes - a distance function (such as Levenshtein's) should do the trick - but a matter of implementation strategy. Detecting splices is a computationally hefty operation that should be done only for Array-like objects that are observed for splice changes. All of these tasks and checks have their computational cost.
I'd like to prioritize adding benchmarks (#11) before this one, and hopefully something should move as soon as I go on a break and have a little time for my projects.

In the meanwhile, I created a separate polyfill for Array.observe.


How to convert while to enable?

This is a child issue of #52 .
Any idea on how to represent while in structure, so we can replace it with enable? We cannot simply substitute while with a signature in structure, because there can be sequence inside while body, and we do want the while body be executed step by step, following seq control.
One way I can think about is ban while and only allow for control. So we convert for n step s to seq (enable ...) (enable ...) ..., repeating enable n/s times. This will not result in increase overheap in RTL backend since we don't duplicate structure.
However, abandoning while loop means we we cannot represent a lot of interesting functions.
If we want to keep while, we need to come up with some way of representing sequential execution in structure.

It's a good point. A while is inherently variable-latency—that's the reason we'd want it to exist independently of for. So in that sense, it will need to somehow interact with #50 and the alternatives therein for dealing with asynchronous invocation, etc., as well as #53, where we're figuring out how to describe the latency of submodules.
One way to think about it is that, for any while loop, we'd want to instantiate a special while_structure subcomponent that includes the loop state and invokes the body repeatedly. This subcomponent will need to be invoked asynchronously from the supercomponent in a variable-latency way—however we decide to do that—so it gets to run continuously and just signal to the outside world when the iteration is finished.

How about applying a new semantics/signature that allows one structure to take in another component (that has control semantics)?
For example
(define/component main()()
..
   ( (new-std while0 (std_while 32 substruct_A))
     (-> (@ i0 out) (@ while0 left))
     (-> (@ const3 out) (@ lt0 right))
   .. )
  (seq
      (enable X Y)
      (enable while0)
 ..))
(define/component substruct_A()()     //while body
.. //structure
( seq
   (enable M N)
   (enable K)))
.. )

Then

For each component, the control can be made of sequence of enables only.
It can be easily translate to dynamic&static scheduling hybrids, since structure naturally fall into static scheduling as far as the structure does not take in another component, and the only thing once appear changes upper components to dynamic scheduling is while structure.

It's a good point. A while is inherently variable-latency—that's the reason we'd want it to exist independently of for. So in that sense, it will need to somehow interact with #50 and the alternatives therein for dealing with asynchronous invocation, etc., as well as #53, where we're figuring out how to describe the latency of submodules.
One way to think about it is that, for any while loop, we'd want to instantiate a special while_structure subcomponent that includes the loop state and invokes the body repeatedly. This subcomponent will need to be invoked asynchronously from the supercomponent in a variable-latency way—however we decide to do that—so it gets to run continuously and just signal to the outside world when the iteration is finished.

I was just typing when you reply and it seems we have a similar thought.

Indeed! A while back, @sgpthomas and I were chatting about a similar feature idea where components could take other components as “arguments” and gain access to them. At that point, the idea was about letting two different components read & write the same memory, for example. But this would be another use case.
Maybe we should make a separate issue about that idea specifically?

Linking issue #48. This is where I describe this loan idea.

Futil has been redesigned to use go/done holes and groups in #139.