Enable Clippy nesting limit

Objective
Some areas of the codebase are excessively nested. I think we should at least put a limit to it to prevent exacerbating the already critical situation.
Solution
Update clippy.toml to set the excessive-nesting-threshold option to 9, which is the highest level of nesting so far.
Tested by doing cargo +stable clippy --all-features --all-targets

Yes, the idea is to progressively bring it down to an acceptable level. It's common practice in C to not exceed 3 levels, most notably in the Linux kernel.
In the case of Bevy, that goal is much more difficult to attain, since Rust code tends to nest more than C, with mod and impl blocks, and with closures (that can be factored out into functions anyway). Using let-else statements tends to flatten the code by a considerable amount by keeping the happy path of the function to the first level, and bail out on error. I think we can achieve a nesting limit of 5 (even 4 as a stretch goal) in a relatively short amount of time without recurring to excessively controversial techniques.
In my personal Bevy project I've been able to reach level 3, even with UI code. Also, I've started doing some experiments refactoring the most nested functions in the Bevy codebase to see how low we can push the limit.

I think we should still move forward. The fact that we've reached level 9 proves that we shouldn't rely on manual code review.
Yes, this may make a bugfix PR more complex, but the benefits greatly outweigh the drawbacks. If a bug can be lazily fixed by adding just one more indentation level, we worsen an already critical situation, accumulating technical debt over time, making further changes progressively more and more difficult, paradoxically.
As I mentioned before, Linus Torvalds highly encourages a strict 3 nesting levels policy on the Linux kernel codebase, but that doesn't prevent it from having arguably the most active open source community in the world. If a project with 30M lines of code thrives with 3 levels of indentation, I doubt we'll encounter problems by enforcing 9.

The Linux project failing to enforce their style guide in CI doesn't seem like a reason for us to make the same mistake.

Heres an example of nesting for up to 10 levels (4 spaces):
// 0
fn example() {
    // 1
    { // 2
        { // 3
            { // 4
                { // 5
                    { // 6
                        { // 7
                            { // 8
                                { // 9
                                    // 10
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}

In my opinion you shouldn't ever go beyond 7 idents.

Closing; I don't think there's appetite for this currently.


1 byte binary representation vs. protocol codes > 255

The spec states that in the binary representation every protocol has a 1 byte code. However, there are quite some protocols defined with a number that is not representable with 1 byte.

It should say varint
On Mon, Nov 16, 2015 at 14:15 keks<EMAIL_ADDRESS>wrote:

The spec states that in the binary representation every protocol has a 1
byte code. However, there are quite some protocols defined with a number
that is not representable with 1 byte.
—
Reply to this email directly or view it on GitHub
https://github.com/jbenet/multiaddr/issues/8.

Which Varint format is being used? Is it protobuf's Base 128 Varints or something like UTF-8?

Why not use 2 bytes, mapping IANA ports? This would reusing an existing map instead of creating a new one.

Because that's not infinitely scalable. Need a varint.
And IANA doesn't cover all things we want to cover. I think We try to use
IANA numbers where able.
On Sun, Sep 18, 2016 at 7:02 PM Valentin Lorentz<EMAIL_ADDRESS>wrote:

Why not use 2 bytes, mapping IANA ports? This would reusing an existing
map instead of creating a new one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/multiformats/multiaddr/issues/8#issuecomment-247841221,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIcoS-7sEZBxWmhVRSa1sno0olFKMeeks5qrRoggaJpZM4GjYNP
.


AnimatedMorphCube.gltf is not displayed in WebGL environment

Describe the bug
I tried to display AnimatedMorphCube.gltf with the WebGL version of Filament.
However, the warning was output to the browser console and the model was not displayed.
To Reproduce
AnimatedMorphCube.gltf + Filament result:
GL_INVALID_OPERATION: Vertex shader input type does not match the type of the bound vertex attribute.

Expected behavior

Desktop (please complete the following information):

OS: Windows 10 + Chrome 77
GPU: Intel HD Graphics 520
Backend: WebGL/ANGLE (Intel(R) HD Graphics 520 Direct3D11 vs_5_0 ps_5_0)

Interesting, thanks.  I'm surprised this wasn't fixed by 2a8ecd2b59e6bdf20425f5f5e85aa504bd70ffe5.

When I tried it with Firefox, the content of the warning was the following message.
Error: WebGL warning: drawElements: Vertex attrib 5 requires data of type UINT, but is being supplied with type FLOAT.

Yes this issue is basically a dup of #1726, which should have been fixed.  Can you confirm that you have the fix noted in my previous comment?

#1726 has also not been fixed, as I'm still getting the same errors as well for all glTFs with morph targets.

Fixed for reals with 3c6f3e7787bd2f89d4d41cb0988af84c4a13baa2.

I tried the latest version of filament and it seems that there is a build error.

https://source.cloud.google.com/results/invocations/39851f01-7dfd-401b-b01e-2dafef41ac8c/log

I have confirmed that this model can be displayed with the latest version of Filament.
AnimatedMorphCube.gltf + Filament result:

I updated the status of gltf-test. I think that almost all models that do not use the extension feature can be displayed.
https://github.com/cx20/gltf-test#simple-models-for-testing-individual-features


Needs clarification about azure cosmos db firewall support

Hi, there are some points not clear for firewall support of Cosmos DB,
https://docs.microsoft.com/en-us/azure/cosmos-db/firewall-support
There are two options when I specified the IP Addresses and CIDRs need access to cosmos DB while excluding public access as follows

Allow access from Azure portal means using IP firewall, it is recommended to allow Azure portal to access your account. Access is required to allow use of data explorer as well as to retrieve metrics for your account that show up on the Azure portal.

Looks like there is nothing to explain ' Accept connections from within public Azure datacenters' ? Could you please let us know what does it mean exactly ?  Myself is assuming we should check this to make it working, but need to know more about the risk in case we check it. Thanks.
Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@cloudmelon
Thanks for your feedback! We will investigate and update as appropriate.

@cloudmelon
Accept connections from within public Azure datacenters: If your Azure Cosmos DB account is used by other Azure services like Azure Search, or is accessed from Stream analytics or Power BI, you allow access by selecting Accept connections from within public Azure datacenters.
This doc has more details about both the options: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-configure-vnet-service-endpoint#configure-a-service-endpoint-for-a-new-azure-virtual-network-and-subnet

Hi,
So I am assuming if this cosmos DB used by Azure function should also check this case right ? Thanks.

On 2 Apr 2019, at 00:24, Sneha Gunda<EMAIL_ADDRESS>wrote:
@cloudmelon
Accept connections from within public Azure datacenters: If your Azure Cosmos DB account is used by other Azure services like Azure Search, or is accessed from Stream analytics or Power BI, you allow access by selecting Accept connections from within public Azure datacenters.
This doc has more details about both the options: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-configure-vnet-service-endpoint#configure-a-service-endpoint-for-a-new-azure-virtual-network-and-subnet
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cloudmelon Yes your understanding is correct. I hope your concern has been resolved.
So, we will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

Thanks :)


Fix this. reference in selection-buttons.js

Moving this commit over from the govuk_prototype_kit repo.
This commit was made by @tvararu:
https://github.com/alphagov/govuk_prototype_kit/pull/223/commits/5caea24
efa4302572636a91288d58da0b566376f
This fixes #267.

Closing while I check the tests...

The tests fail when this change is made:
When GOVUK.SelectionButtons is called with a selector and then the page content is replaced
     When that selector matches radio inputs
       If one of those radios is clicked
         X Should mark that radio with the selected class
           Expected false to be true. (1)
         ✓ Should remove the selected class from all other radios
       If one of those radios is focused
         X Should add the focused class to the radio
           Expected false to be true. (1)
         X Should add a custom focused class to the radio if sent in as an option
           Expected false to be true. (1)
         X Should remove the focused class from a radio when it loses focus
           Expected false to be true. (1)
     When that selector matches checkbox inputs
       If one of those checkboxes is clicked
         X Should add the selected class to the checkbox
           Expected false to be true. (1)
       If one of those checkboxes is focused
         X Should add the focused class to the checkbox
           Expected false to be true. (1)
         - Should add a custom focused class to the checkbox if sent in as an option.         X Should add a custom focused class to the checkbox if sent in as an option
           Expected false to be true. (1)
         X Should remove the focused class from the checkbox when it loses focus
           Expected false to be true. (1)
   GOVUK.SelectionButtons.prototype.destroy
     - Should remove the events bound to the jQuery-wrapped elements sent into GOVUK.     ✓ Should remove the events bound to the jQuery-wrapped elements sent into GOVUK.SelectionButtons
     - Should remove the events bound to the document for the selector was sent into      X Should remove the events bound to the document for the selector was sent into GOVUK.SelectionButtons
       Expected false not to be false. (1)
       Expected false not to be false. (2)
       Expected Function to equal false. (3)
       Expected Function to equal false. (4)


feat: add support for keyword mappers in custom mode JSON

When the value for the token key of a rule is an object, this will now get converted to a keyword
mapper. The token object should contain the keys
map, defaultToken, ignoreCase, and splitChar

@pepijnve thanks for the input. Just out of curiousity, do you think that it could be worth, if I update Ace to the latest version as well. The Ace Vaadin Webcomponent hasn’t received the love it used to get.
If so, I would work on in that weekend and merge on monday. Or would you need the changes faster, that I fully test out your changes, and create a seperate PR for upgrading Ace and switching to a Vite build ?

If it's not too much work that would be nice.
There's no need to rush the mode changes.


fix: first sentence in step 32 JS course.

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #48787

rewrote the first sentence in step 32 of the new JS course build an rpg, to improve the Arabic translation

We are officially on Node.js 18 now. We have changed the merge requirements accordingly.
You will need to rebase this PR against the main branch OR Click the "Update branch" button to get the new checks going.
Thanks for your contribution.

We are officially on Node.js 18 now. We have changed the merge requirements accordingly.
You will need to rebase this PR against the main branch OR Click the "Update branch" button to get the new checks going.
Thanks for your contribution.

Thanks for the help,  I have rebased it

I added a comment in the issue that I think should be considered before reviewing this PR

The PR have been updated according to the new suggestion


Fix formatter instability for lines only consisting of zero-width characters

Summary
Fixes https://github.com/astral-sh/ruff/issues/11724#issuecomment-2148183543
Code from the linked issue that produces instable formatting:

'''

'''

This turned out to be something entirely different than I expected.
I initially thought that it was an issue with the docstring rendering, which uses trim instead of PythonWhitespace::trim.
But I learned the better when I compared the generated IR for the above snippet and the same snippet but with \u{15} (the non visible character in the snippet above) with a.
Both snippets generate the same IR! That means this is a bug in the Printer and not in the Python formatter.
It turns out that the fix is relatively simple.
The Printer omits hard_line_break IR elements or only renders a single \n for a empty_line IR elements when the
current line is all empty. The problem is that the Printer uses the line width to determine if the line is empty.
However, using the line width here isn't correct because a line can be non-empty but has a zero width if it only consists of zero-width characters, which is exactly what we have in the reported instability.
I considered removing this behavior but we rely heavily on it in suite.rs and I'm not going to touch this to fix this bug!
So what I did instead is to change the Printer to keep track of the start of the current line and test if the current formatted line is empty.
I don't suspect that this changes performance much because it only adds a single write after a newline character. Testing whether the line gets a bit more expensive
because it now needs to dereference into the buffer, but I think in total, this is just noise.
And I was wrong lol. THis has a huge perf impact. Let's see if I can do better
Backwards compatibility
It's hard to be a 100% sure, but I'm confident that it doesn't have widespread impact because zero-width characters are rare, even more so zero-width lines only consisting of zero-width characters.
The only zero-width character that Python allows outside strings and comments is the form-feed character. Ruff does not preserve line-feed characters except in suppressed ranges. The existing implementation used a work-around to avoid this very specific printer behavior. This PR allows to remove the work around and the tests keep passing.
For strings, we write the entire string content as a single text, preserving line breaks as is.
For comments: That's the issue discovered here. Existing code would already have the trailing line stripped and reformatting the same code wouldn't insert the trailing line after the zero-width characters line.
So we should be good
Test Plan
Added test. All existing tests keep passing.
Thanks
Thanks to @jasikpark for finding the instability and helping me to reproduce the issue.

Nice write-up.


feat: postgis extension

Fix: https://github.com/serverpod/serverpod/issues/2439

[ ] Base query set to accommodate common scenarios (method name in implementation might be different):

[ ] Points ordered by distance to input. (This, together with limit should give us k-nearest points)
[ ] Points strictly within a certain distance.
[ ] Points that intersect geometry.

[ ] Index creation —To ensure fast querying, a smart indexing strategy, possibly involving spatial indexes, might be required.
[ ] Migration support to add and remove columns.
[ ] Serialization/Deserialization of data types to support database integration and communication with the client.
[ ] Compatability with unsafe queries to support all unsupported scenarios.
[ ] Complete documentation of the feature.
[ ] Tests for all additions associated with the feature.

Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[ ] I added new tests to check the change I am making.
[ ] All existing and new tests are passing.
[ ] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.

@SandPod I just add all the code for the column, I'm a bit stuck on the YAML support integration.
When you said "implement the validation" inside this file:
https://github.com/serverpod/serverpod/blob/main/tools/serverpod_cli/lib/src/analyzer/models/yaml_definitions/class_yaml_definition.dart
What do I need to add? Because I saw the "value" of the field is handled here:
https://github.com/serverpod/serverpod/blob/9f9f04fad5c628b148f4d02ad289ed079f3fc886/tools/serverpod_cli/lib/src/analyzer/models/validation/restrictions.dart#L1156
But then:
https://github.com/serverpod/serverpod/blob/9f9f04fad5c628b148f4d02ad289ed079f3fc886/tools/serverpod_cli/lib/src/analyzer/models/validation/restrictions.dart#L1178
is null. So I got an error message.
The parsedModels contain GeographyPoint not geographyPoint so I suppose I need to add somewhere the geographyPoint to pass the restriction? (I'm stuck here).
Should I need to create a new:
ValidateNode(
   Keyword.geographyPoint,
),

Inside the nested keyword fields?

@Kiruel Maybe it helps if I expand a bit on how our analyzer works.
Basically, three methods are used in the model_analyzer.dart file. First we run a best effort parsing of the file by calling the extractModelDefinition(...) method, this tries to create a SerializableModelDefinition out of the passed in yaml file.
After that we try and resolve any dependencies that might exist between models. For example, you have two models, one of which contains a field and the other a model. This is done in the resolveModelDependencies(...) method.
After that, we run our validation, which is done by calling the validateYamlDefinition(...) method.
These method needs to be run in this specific order and that is orchestrated in the stateful_analyzer.dart file. An example of this can be seen by inspecting the validateAll(...) method in that file.
So, in order for the type validation to work, you first need to make sure that the model parser can parse the new field and that the type is recognized and differentiated from any possible user-defined class.
The place that you liked for _isValidType uses a whitelist for the dart types that we support that is defined here: https://github.com/serverpod/serverpod/blob/9f9f04fad5c628b148f4d02ad289ed079f3fc886/tools/serverpod_cli/lib/src/analyzer/models/validation/restrictions.dart#L1135
I'm guessing you are getting stuck on the validation because the new type is not part of the whitelist.
Also, we have fantastic unit test coverage for this part of the code. If you check the tests we have created it should be possible TDD your way through the validation code.

Some progress, I have passed the validation problem, thanks to the white list, and then I successfully created the GeographyPoint in the protocol.dart but now I'm a bit blocked on the dartType of GeographyPoint. Like you can see the dart file generated:
_i2.ColumnDefinition(
          name: 'point',
          columnType: _i2.ColumnType.json,
          isNullable: false,
          dartType: 'protocol:GeographyPoint',
        ),

But should be _i2.ColumnType.geographyPoint ? Right? I don't see where I need to make the change in the code. If you can tell me where I can find the tests concern this part it would help.
More context:
The code generated:
factory Channel({
    int? id,
    required String name,
    required String channel,
    required _i2.GeographyPoint point,
  }) = _ChannelImpl;

  factory Channel.fromJson(Map<String, dynamic> jsonSerialization) {
    return Channel(
      id: jsonSerialization['id'] as int?,
      name: jsonSerialization['name'] as String,
      channel: jsonSerialization['channel'] as String,
      point: _i2.GeographyPoint.fromJson(
          (jsonSerialization['point'] as Map<String, dynamic>)),
    );
  }

The errors:
 │     Undefined class 'GeographyPoint'. dart (undefined_class) [29, 14]
 │      Try changing the name to the name of an existing class, or creating a class with the name 'GeographyPoint'.

 │     The name 'GeographyPoint' is being referenced through the prefix '_i2', but it isn't defined in any of the libraries imported using that prefix. dart (undefined_prefixed_name) [37, 18]
 │      Try correcting the prefix or importing the library that defines 'GeographyPoint'.

Happy to hear the progress!
There are three issues here that are connected to GeographyPoint being defined as a Serverpod model. Having it as a Serverpod model might have some benefits (especially when it comes to serialization) but there is unfortunately no way to get around all the problems.
I would recommend defining the GeographyPoint as a concrete class that can be imported directly to both the Server and the Client by default. Such as the Uuid or bytedata that are exported from the Serverpod serialization package: packages/serverpod_serialization/lib/serverpod_serialization.dart.
But for the sake of sharing knowledge, I will explain how to get around 2 of the three issues.
An unrelated issue I noticed is that that if you look closely on the ColumnDefinition you can see that the columnType is a json while it should be your newly defined geographyPoint. This is something you that will have to be fixed.
Getting around 2 out of 3 issues
First, you need to change the definition in the channel.spy.yaml so that we reference the GeographyPoint defined in the Serverpod package:
### Represents a chat channel.
class: Channel
table: channel
fields:
  ### The name of the channel.
  name: String

  ### The id of the channel.
  channel: String

  point: serverpod:GeographyPoint

Next we need to export this model in the server package, we are very restrictive with what we export here, but you will need to add export 'package:serverpod/src/generated/database/geography_point.dart'; to the packages/serverpod/lib/serverpod.dart file.
This solves it on the Server side. But now we run into a real problem.
The generated client for the Serverpod package is actually the Serverpod service client package. And these are not connected with the import that is generated.
If you only allow the point as a server side field all should be green now, but you won't be able to send the points to the client.


[releases] PCA Transform Bug Fix

A bug which was a reason of PCA Transform degradation with SOA tables has been fixed

make test


Placeholder

merging @fujisoup's Placeholder changes onto a GPflow branch, so that

the CI can all run smoothly
we have a place to discuss on github/GPflow

creating a new branch 'Placeholder' from the changes suggested by @fujiisoup


d:quota-available-bytes in dprop of PROPFIND give  wrong response value

Describe the bug
The WebDaV protocol seems to suggest that d:prop d:quota-available-bytes should show the available storage rather than the total spaces.

The DAV:quota-available-bytes property value is the value in octets representing the amount of additional disk space beyond the current allocation that can be allocated to this resource before further allocations will be refused. It is understood that this space may be consumed by allocations to other resources

However, a simple PROPFIND request using d:quota-available-bytes shows the total space allocated for the user and the value doesn't change even if some file is uploaded. The documentation gives different explanation for this:

Clients should expect that as the DAV:quota-available-bytes on a resource approaches 0, further allocations to that resource may be refused. A value of 0 indicates that users will probably not be able to perform operations that write additional information (e.g., a PUT inside a collection), but may be able to replace through overwrite an existing resource of equal size.

Steps to reproduce

Allocation of quota
Quota allocation for Einstein

 curl -k -X PATCH 'https://host.docker.internal:9200/graph/v1.0/drives/28dc07c9-6b98-4a60-a860-03fa5b898ffc%244c510ada-c86b-4815-8820-42cdf82c3d51' -u admin:admin  --data '{ "quota":{"total":1000000000}}'

Upload any dummy file.
Send a PROPFIND request to get d:prop d:quota-available-bytes

 curl -k -X PROPFIND 'https://host.docker.internal:9200/remote.php/dav/spaces/28dc07c9-6b98-4a60-a860-03fa5b898ffc%244c510ada-c86b-4815-8820-42cdf82c3d51' -u einstein:relativity --data '<d:propfind
xmlns:d="DAV:"
xmlns:oc="http://owncloud.org/ns"
xmlns:ocs="http://open-collaboration-services.org/ns"
>
    <d:prop>
    <d:quota-available-bytes/>
    </d:prop>
</d:propfind>'

Expected behavior
The response should show available spaces
Actual behavior
<d:multistatus xmlns:s="http://sabredav.org/ns" xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/dav/spaces/28dc07c9-6b98-4a60-a860-03fa5b898ffc$4c510ada-c86b-4815-8820-42cdf82c3d51/</d:href>
    <d:propstat>
      <d:prop>
        <d:quota-available-bytes>1000000000</d:quota-available-bytes>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>

Is this supposed to show total spaces or the total spaces allocated by admin to that user?

Interesting feature. Just why we should get info about available quota in the PROPFIND response?  we use for that GET
https://localhost:9200/graph/v1.0/drives/spaceUUID request
I guest it's something old and unnecessary. @micbar do we need to fix it and do we need tests for that?


Exception "got Future  attached to a different loop"

In the celery_task.py file you have this ...
@celery.task(name="tasks.print_hero")
def print_hero(hero_id: UUID) -> None:
    hero = runnify(get_hero)(hero_id=hero_id)
    return hero.id

I found an issue in implementing a version of the above code in my project. After a task is run once, I was getting a cryptic exception  "got Future  attached to a different loop".  After a lot of head scratching, the following resolved the problem.
    asyncio.get_event_loop().run_until_complete(get_hero(hero_id=hero_id))

Sorry, I have not taken the time to confirm that your project has the same problem.  I'm posting just in case someone else runs into the problem.
Thank you for your excellent project. It has helped a lot.

Hello @jcam5826 I am sorry for the late reply and thanks for your positive feedback. Sure I am going to check this bug you had in your custom project and replicate it.

Hello @jcam5826 I was able to replicate the bug and I have updated the code as you suggest hee
https://github.com/jonra1993/fastapi-alembic-sqlmodel-async/commit/0378bdbe20bfdcc7cf3066e72775d13af452a933


[isocpp-lib] CH 3, p0032r2 -- let's not have too clever tags

See issue at optional.

This syntax is both clever and simple to me:
any(in_place<T or I>(), args...)

See in_place  at cppreference and p0032.


Tune PsScrpitAnalyzer to avoid useless errors

As a developer
I want GHAS to provide useful errors
so that I trust GHAS Alerts
In thsi case PsScriptAnalyzer is reproting formating best practices and not Security errors like tailing white spaces.

Reference
https://github.com/microsoft/psscriptanalyzer-action
https://github.com/marketplace/actions/run-psscriptanalyzer
Severity Settings
https://github.com/microsoft/psscriptanalyzer-action#severity


sap.ui.export.Spreadsheet: support server-side flattening by only counting hierarchical level

The progress and next $skip value is determined on the total amount of records and the records returned by each data received event. Basically sap.ui.export.Spreadsheet currently only supports what you see is what you get; the count you provide needs to count the total records and not just level 0. But that is a problem: it means you need to know the total count of an m:n relationship upfront. In our implementation, this is really not achievable. I only know the count of level '0', but my data source will return multiple levels.
I have currently solved this by extending sap.ui.export.Spreadsheet, sap.ui.export.SpreadsheetExport and sap.ui.export.DataProviderBase to only count elements that have level === '0'.
It would be nice to make this configurable in the standard via a property dataSource.countLimitedToLevel.
The implementation of DataProviderBase.prototype.fnOnDataReceive can check for workbook.hierarchyLevel and in that case only count those that match dataSource.countLimitedToLevel:
iFetchedRows = this.mSettings.dataSource && this.mSettings.dataSource && this.mSettings.dataSource.countLimitedToLevel && this.mSettings.workbook && this.mSettings.workbook.hierarchyLevel ? aData.filter((o) => o[this.mSettings.workbook.hierarchyLevel] === this.mSettings.dataSource.countLimitedToLevel).length : aData.length

Hello @piejanssens ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Patric

Hello piejanssens,
I am the responsible developer for the UI5 client export functionality. I managed to evaluate the technical dependencies of this requirement and could not find any blocking issues that would make this feature impossible for general use. I will forward the requirement to the corresponding product owner.
Please keep in mind that we cannot give any commitment when or if this feature will be available. We will keep you posted.
Regards Sebastian

Hello @piejanssens,
I discussed this with Sebastian recently and there are some points which I think I have not fully understood.
Your problem is that you can not provide an overall count of all items with the tree, right? Do you know that you can also omit providing a count in the export settings?
If I missunderstood it, can you please explain inmore detail what you like to achieve with the setting countLimitedToLevel?
Thanks and Best Regards
Jens

Hi @simlin,
Yes, I know it is possible to omit providing a count, but that would change UX as there is no longer a progress that can be correctly calculated and visualised.
Best regards,
Pieter

Hello Pieter,
ok, I understand, you ask for an improved (at least approx.) progress indication in cases when a concrete count is not available.
This would definitively make sense. I'll transfer the created internal incident into a feature request accordingly.
Thanks and Best Regards
Jens

This issue will be covered by backlog item CPOUIFTEAMB-1922.


"Invalid syntax" at plugin install

A user reported an "invalid syntax" error message at plugin installation. That may be the following issue: https://hub.qgis.org/issues/3145 (repo name, and therefore zip file submitted to the repository indeed contains a dash).

Had the same issue. Clicked reinstall plugin and it worked.

If the issue was indeed what was mentioned earlier, it is fixed in 0.1.1.
However, the plugin has been re-uploaded to the repository, so you should completely uninstall/reinstall it (plugin update won't work).

The initial reporter indeed informed me that 0.1.1 solve the issue.


A stored XSS has been found  in PageKit CMS affecting versions  1.0.18.

Problem
A user can upload SVG files in the file upload portion of the CMS. These SVG files can contain malicious scripts. This file will be uploaded to the system and it will not be stripped or filtered. The user can create a link on the website pointing to "/storage/exp.svg" that will point to http://localhost/pagekit/storage/exp.svg. When a user comes along to click that link, it will trigger a XSS attack.
EXP
exp.svg

<?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg version="1.1" baseProfile="full" xmlns="http://www.w3.org/2000/svg">
<polygon id="triangle" points="0,0 0,50 50,0" fill="#009900" stroke="#004400"/>
<script type="text/javascript">
alert(/xss/);
</script>
</svg>

Technical Details

Pagekit version: 1.0.18.
Webserver:   nginx1.15.11
Database: MySQL5.7.26
PHP Version:  7.3.4

Hi,
Pagekit's development is almost dead and there are several discussions whether known XSS attack vectors being a problem or not. I doubt that there's a secure way to run Pagekit with any possibility for the user to add content (text or uploading files).

Hi,
This issue was assigned with CVE-2021-32245 -
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-32245
Was it ever addressed/ fixed?
If so, in what commit?
Thanks in advance!


Pixel width

The ability to find the pixel-width of a single character, or the content of an entire component (and children).
public interface PixelWidthSource {
  int width(final @NonNull Component component);

  int width(final char character);
}

My project has an implementation for pixel width you or anyone are free to use, modify, or redistribute:
https://github.com/Electroid/PGM/blob/389839a654c267df55113a32377e1d06a73c4b8e/util-bukkit/src/main/java/tc/oc/util/bukkit/component/ComponentUtils.java#L17 (or anything else in the linked class)

Based on discussions in #262, we've decided this makes more sense to be released as an external library, unless Mojang changes what they offer us.


fix: Fix add_missing_match_arm panicking on failed upmapping

Closes https://github.com/rust-analyzer/rust-analyzer/issues/10580#issuecomment-946170475

bors r+


JEA role capabilities cannot reference cmdlets in versioned modules

Note: Ported from bug 11787772

JEA role capability and session configuration files do not support adding cmdlets or functions from versioned modules to VisibleCmdlets or VisibleFunctions. This specifically applies to modules where each version is in a subfolder, e.g. C:\Program Files\WindowsPowerShell\Modules\MyModuleName\1.0.0\MyModuleName.psd1
Such modules are supported by the PowerShell module importing system, but JEA will not find those modules and, therefore, not make those cmdlets or functions visible in a JEA session.
The current workaround is to move those modules out of versioned folders into top level module folders.

Partially mitigated with #3067 (see related issue #3522) and the introduction of RoleCapabilityFiles keyword. This provides an alternate way to reference PSRCs inside versioned modules.

Security working group: Please provide a complete repro using the issue template.  It's not clear what the issue is.


Implement test suite

Story
As an engineer, I want a test suite to run on my application so that I can protect myself from myself
Design Considerations
TBD. I just want something that checks line coverage and runs before deployment
To be done at the same time as #49
Technical Scope
TBD

Test every file. However, no need to test top-level files, as I will be the one calling the API
Convert it to DRY/SRP
Decide which functions need to be public facing
Write a jest file for the public facing methods
If methods are low-logic or high-library, write a bare-bones test and a comment explaining your decision
Test/save/commit

Due to the absolutely massive scope of this issue, I've decided that, while a test file will be created for every non-top-level file, only bare bones tests will be added. This will lay a foundation for adding tests on a per-bug basis. Of course, engineers may add test cases at any time. The new plan:

Test every file. However, no need to test top-level files, as I will be the one calling the API
Convert it to DRY/SRP
Decide which functions need to be public facing
Write a 1-test Jest file (unless the module calls for a full test suite, such as order placement, etc)
Test/save/commit


feat: add option to define the shell.nix location

use --shell-file or -s option to declare the nix file to use when
running command info, watch, direnv
refs #116
:warning:  first time I contribute to a rust project.
thank you for this great project, it saves me a lot of time
thank you for marking this as good first issue

At first read, this looks really good. I made a couple small suggestion, does that seem okay to you? Since nobody will type it (except for once per project) I think it is nicer to spell it out fully.

hello, is there something missing ?

Was on vacation, LGTM


[v1.15] docs: add deprecation notice for enable-remote-node-identity for v1.15

The enable-remote-node-identity agent flag was marked as deprecated for 1.15 in commit cf472ef90f61 ("daemon: Deprecate EnableRemoteNodeIdentity"). Add an upgrade note about the flag and the corresponding remoteNodeIdentity helm value being deprecated.

/test

/test-backport-1.15

Thanks @tklauser :pray: !


Supporting complex data types

When do we plan to support complex data type for this connector. When I use tables including some of those, I get a string as output.

Supported in v1.2.0.


run-onboarding-managed-tokens should not use same vaultStorerTimeout as token-push

The proposal right now is to use a 60-second timeout, with that configurable with a flag.  Something like
run-onboarding-managed-tokens --timeout 500s my_service

This is pretty much good to go.


Error looking for upload port in Lesson 4 for Wio Terminal

I am working on Lesson 4, Control your nightlight over the Internet - Wio Terminal.  I am on step 7 of  the Task - connect to WiFi  section where I am asked to upload the code to the Wio terminal.
When I run PlatformIO: Upload, I get the following error message:
...
Looking for upload port...
Error: Please specify `upload_port` for environment or use global `--upload-port` option.
For some development platforms it can be a USB flash drive (i.e. /media/<user>/<device name>)
*** [upload] Explicit exit, status 1
================ [FAILED] Took 4.26 seconds ================
The terminal process "platformio 'run', '--target', 'upload', '--environment', 'seeed_wio_terminal'" terminated with exit code: 1.
...

Prior to modifying the code for this lesson, I verified that the Wio Terminal still functioned properly with the prior lesson's nightlight code.
Has anyone else come across this behavior, or have some clues about how to work around this?
Note: I am pretty sure that I uploaded the Wio Terminal firmware earlier in order to enable the WiFi settings, but perhaps there are more steps needed ?
Thank you.

I've seen this a few times - the Wio Terminal just refuses to go into upload mode. Sometimes it's caused by having another process accessing it (such as a second VS Code instance), other times there seems to be no pattern to it. Usually unplugging it for a while can fix it.

Thank @jimbobbennett .  I've been racking my brain on this one!  In my troubleshooting attempts, I even figured out how to use the PlatformIO CLI to replicate the problem.  Near as I can tell, the connection between the Mac and the Wio Terminal just drops, and will not reconnect.  Then, out of nowhere today, it seemed to establish itself.  Things were fine for about 20 minutes, and now I lost the connectivity again.

Has anyone else experienced this with the Wio Terminal?  I am using Visual Studio Code on a mac running Big Sur.
Does @jimbobbennett or anyone else have any more suggestions on how to fix this issue, and fix the root cause to keep it from reappearing?

It's frustrating that this is occurring so early in the game before I can even get the MQTT sample stuff working :-(

@marty-optum I'm running into the same issue with Big Sur, VS Code, and Wio at the same point in the tutorial.

Just following up on this. I have been having a few connectivity issues with it - on a live stream which was fun. I'm also using Big Sur.

In PlatformIO, in the devices tab, do you see it? It will be /dev/cu.usbmodemxxxxxx

What other devices do you have connected? For example, I lose connectivity when my USB audio interface is active

If you pull the power button down quickly twice, does it mount a drive called Arduino?

Were you able to update the firmware by following the instructions from Seeed:
https://wiki.seeedstudio.com/Wio-Terminal-Network-Overview/

@jimbobbennett Thanks for following up! I've found that I sometimes but not always can bring back the device and mount it when I restart my computer. I am able to consistently connect from a Windows computer so I think this is could be a Mac issue.
Here's what seems to happen.

The device mounts after restarting my computer.
Via VS Code, I upload with PlatformIO.
My device ejects automatically.
When I try to upload a second time with Platform IO via VS Code, I see the upload_port error. I understand now that it's a symptom of not having my device mount.

To answer your other questions:

I do see /dev/cu.usbmodemxxxxxx when my device mounts.
I don't have any other USB devices connected but I do have an HDMI cable connected through the same USB/HDMI hub. I don't have a USB on my laptop.
Pulling down the power button doesn't consistent mount the device as Arduino, although it did work once.
I was able to update the firmware.

@jimbobbennett  and @juliakm, what I see is slightly different.
Environment

macOS Big Sur 11.6
VS Code 1.60.1
PlatformIO IDE 2.3.3 VS Code Extension
Hardwired thunderbolt/USB-C port on Mac to USB-C port on the WioTerminal.  No adapters or hubs (although I have tried different configurations, such as switching USB ports and using hubs).

[Jim]

In PlatformIO, in the devices tab, do you see it? It will be /dev/cu.usbmodemxxxxxx

This is inconsistent.  After a successful PlatformIO Upload command in VS Code , I see it.

After an unsuccessful PlatformIO Upload, I still see it, but after hitting refresh in the PlatformIO GUI a few times, it goes away.

By the way, if anyone else is playing along at home, you may not know how to start the Platform IO shown in these screenshots.  I did not see a way to launch this from within the VS Code extension menus.  After a little research, I learned I had to invoke it from the Platform IO Command Line Interface (CLI).  I found a couple different ways to do this, but they each seem to do the same thing.  Here's how:

In VS Code, open the Command Palette by selecting the View | Command Palette... menu option.
In the dialog box, type PlatformIO: New Terminal
On the terminal command line, type pio home.  This will open the PlatformIO GUI in a web browser at http://<IP_ADDRESS>:8008/

Select the Devices option from the left Nav bar.

[Jim]

What other devices do you have connected? For example, I lose connectivity when my USB audio interface is active

/dev/cu.Bluetooth-Incoming-Port - I think this is my Bluetooth Personal Area Network (PAN).  Currently no Bluetooth devices are connected, however.
/dev/cu.SRS-XB10-CSRGAIA - I think this is a Bluetooth speaker.  It's disconnected and powered off.
[Jim]

If you pull the power button down quickly twice, does it mount a drive called Arduino?

I do not see any visual indication in Finder (or anywhere else that I can tell) that a drive called Arduino is mounted.

I do, however, get notifications when I do PlatformIO operations that the "Arduino" disk was not ejected properly.

Pulling down the power switch quickly twice on the WioTerminal allows me to reset it.  I can then perform a PlatformIO: Upload operation once or twice before it fails again.
[Jim]

Were you able to update the firmware by following the instructions from Seeed

Yes.  I followed the instructions to Update the Wireless Core Firmware.  I did not, however, perform the directions for Update Seeed SAMD ArduinoCore or the Libraries Installation.  I assume these are not needed.  Is that a correct assumption?
Hopefully this extra detail help troubleshoot and fix the issue that we are seeing, and can save other users the same aggravation! :-)

Thanks both.
To get the devices tab, you can also just click the PlatformIO icon in the side too bar (the bug button), then select Quick Access -> PIO Home -> Open. That will bring up the same thing:

After an unsuccessful PlatformIO Upload, I still see it, but after hitting refresh in the PlatformIO GUI a few times, it goes away.

I get this happening a few times. It usually goes away when I do the double pull on the power button, and I can then upload.
Can I just double check with both of you, before trying an upload can you:

Pull the power button down twice quickly
Verify that the blue upload light is pulsing

https://user-images.githubusercontent.com/1710385/135308106-58abceaf-6ac3-4955-86c9-75029298d6e4.mp4
It can be tricky getting the timing right. If you do it right, you should see the disk not ejected notification:

You do need to do this every time you upload.

Thank you!! That video was very helpful! I wasn't pressing down fast enough. I didn't realize how often my device was leaving upload mode and how to get it back. I don't think that I was ever successfully returning to upload mode unless I restarted my computer. The difference between the blinking and solid light is subtle but very useful. In other words, solid = bad for uploading, blinking = good.
Thanks again for all of your help!

@juliakm - glad you got it working. It's a failing on our part that we weren't clear enough with how to set the device into upload mode. I'll raise a PR with more detailed instructions.

Right - I've updated the lesson 1 Wio lab with this. @marty-optum, does this fix your issues?

@jimbobbennett, I was successful 3 attempts out of 3 when trying the double-pull-down before each upload attempt.
I think for me, I did not realize that this was a requirement every time you upload to the Wio Terminal, especially since it seemed to work fine with earlier course modules without having to do this.
I did see these instructions in the Wio Terminal User manual that came with my device, but Seeed refers to this sequence as entering bootloader.
From Getting Started With Wio Terminal | FAQ

P.S. I don't exactly know how to tell when the blue LED is "breathing", but I assume that means it's a good thing :-)
Thank you @jimbobbennett and @juliakm for your assistance troubleshooting this! If there are no objections, I think we can close this issue.

Thanks for the update @marty-optum! Will close this.

Thanks both.
To get the devices tab, you can also just click the PlatformIO icon in the side too bar (the bug button), then select Quick Access -> PIO Home -> Open. That will bring up the same thing:

After an unsuccessful PlatformIO Upload, I still see it, but after hitting refresh in the PlatformIO GUI a few times, it goes away.

I get this happening a few times. It usually goes away when I do the double pull on the power button, and I can then upload.
Can I just double check with both of you, before trying an upload can you:

Pull the power button down twice quickly
Verify that the blue upload light is pulsing

IMG_5653.mp4
It can be tricky getting the timing right. If you do it right, you should see the disk not ejected notification:

You do need to do this every time you upload.

This solution (post) seems old, but it has saved my day! Thank you


[Tiered Caching] Delete all stale keys from the non heap tier

Is your feature request related to a problem? Please describe.
Delete the stale keys from the disk tier efficiently.
Describe the solution you'd like
Delete the stale keys from the disk tier. Need to be mindful of memory implications of bringing in all stale keys into the heap and affecting the performance of opensearch.

I have notes on the options we have considered, I'll add them here by end of this week.


[API] [POST/email controller/change Place Status] Response status is 200 instead 400 when an invalid parameter was entered in the placestatus.

**Environment:**Windows 10, Postman
Reproducible: always
Build found: 21.10.2023
Preconditions
The user is logged in, and the token is gotten.
Steps to reproduce

Go to the https://greencity-user.greencity.social/swagger-ui.html#/email-controller/changePlaceStatusUsingPOST
Send the request POST https://greencity-user.greencity.social/email/changePlaceStatus. In the body of the request fill in"placeStatus": "ggggggg". All other parameters are valid.
Pay attention to the status code.

Actual result
The status code is 200.

Expected result
The status code is 400 (Bad request). The user shall receive email notifications when the proposed place(s) is approved or declined.
User story and test case links
E.g.: "User story #176
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), "API" (for back-end bugs).

It's still reproducible and I got an email from GreenCity about changing of Place Status as well:
'Dear Oksana,Your place was ggggggg
Your proposed place "Bar" has been ggggggg. | Sincerely yours, GreenCity's team'


Thank you for this repo!

Finding information on how to set up a lerna / react-native monorepo proved to be very difficult. This repo is a godsend. Thank you @Fried-Chicken!
10/10 - Would let emoji dictate my life again.

Hey @Slapbox,
Glad you like the repo. I agree, unfortunately there isn't much information out there which is a shame because this is the perfect use case for a monorepo. Hoping to help others our by shedding some light on this.
😈 "Ahh, so we meet again @Slapbox" ~ emoji


THRIFT-4941 thrift compiler will not auto update gen-cpp directory

hi, @Jens-G
when we generate code in compiler\cpp\src\thrift\generate\t_generate.cc, thrift compiler will not auto update gen-cpp directory existed and nothing happend on terminal.
i test it on windows 7 so i only change the windows macro.
it will shows link this:
thrift --gen cpp faceDector.thrift [FAILURE:generation:1] Error: ./gen-cpp/:  File exists
i give some suggestion to solved this problem completely on JIRA,  if we want to show the guy what happend. hope you can think about it,
thanks.
zhouhu.

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[ ] Did you squash your changes to a single commit?  (not required, but preferred)
[ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

No further feedback, so closing. Feel free to reopen if more info becomes available..


[Bug][Bamboo] Change the splicing of cicd_scopes.name and cicd_pipelines.name

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Now cicd_scopes.name is spliced in the way of project + "space ” +“ -” + "space ”+ plan.

What do you expect to happen
cicd_scopes.name needs to be changed to project + "/" + plan, this kind of splicing logic.
Take the above screenshot as an example
The value of xm-1 - p1 needs to be changed to xm-1/p1.
The name in the table cicd_pipelines also needs to be changed to this splicing logic.
How to reproduce
See above
Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @mintsweet
cicd_scopes.name comes from _tool_bamboo_plans.name, and _tool_bamboo_plans.name is set when uses choose bamboo plans inConfig UI via API HTTP PUT /connections/:connectionId/scopes, so I need your help to fix cicd_scopes.name.
cc @xiaomingzhang12
cicd_pipelines.name should be fixed in backend. @d4x1

@Startrekzky @xiaomingzhang12
I found that plan's name form  hlw-h3 - h2 is returned from bamboo's API, for example:
{
    "shortName": "h2",
    "shortKey": "H2",
    "type": "chain",
    "enabled": true,
    "link":
    {
        "href": "http://<IP_ADDRESS>:8085/rest/api/latest/plan/HLWH3-H2",
        "rel": "self"
    },
    "key": "HLWH3-H2",
    "name": "hlw-h3 - h2",
    "planKey":
    {
        "key": "HLWH3-H2"
    }
}

"name": "hlw-h3 - h2" is the plan's official name.
Shall we update it with our custom splicing logic?

@Startrekzky @xiaomingzhang12 I found that plan's name form hlw-h3 - h2 is returned from bamboo's API, for example:
{
    "shortName": "h2",
    "shortKey": "H2",
    "type": "chain",
    "enabled": true,
    "link":
    {
        "href": "http://<IP_ADDRESS>:8085/rest/api/latest/plan/HLWH3-H2",
        "rel": "self"
    },
    "key": "HLWH3-H2",
    "name": "hlw-h3 - h2",
    "planKey":
    {
        "key": "HLWH3-H2"
    }
}

"name": "hlw-h3 - h2" is the plan's official name.
Shall we update it with our custom splicing logic?

In that case, I think it's better to use the format returned by the bamboo api itself.


Jooq record unmapper

https://www.jooq.org/javadoc/3.10.x/org/jooq/class-use/RecordUnmapper.html

still in the plan, I'll prob have a look next with another issue.
you might want to like at model mapper I think  it does that already
DiscriminatorConstantSourceMapperBuilder will be useful to map from record to different object class - like in hibernate discriminator field.

any clue for model mapper? I couldn't find anything looks like model mapper..

http://modelmapper.org/
I'll have a look on the unmapper prob in the next few weeks

http://modelmapper.org/

I've tried ModelMapper, maybe I am wrong but its type system is much more complicated ant not that clever, that I have to register every single type even if the source and target types are exact the same. So eventually I turn to sfm, which type conversion is much more lint and simple:)

I'll have a look on the unmapper prob in the next few weeks

Well, thanks very much in advance! I will keep watching on this:)

@hank-cp so I had a  look at RecordUnmapper, and the design seem not very friendly for external integration.
because it relies on the unmapper to create an instance of the record wich require a dsl that is not pass through.
so in what way were you planning to use it?

@hank-cp nevermind I can see a way forward with it, but I don't really know how useful it can be, maybe for inlined object?

@arnaudroger yes I am planning to use it as the replacement of the DefaultRecordUnampper, which doesn't support nested object mapping and custom type conversion. Now I use sfm to do record -> object conversion and I wish the same mapping rule could be applied from object -> record, so I could shared the exact same business model.

@hank-cp available in 8.2.0
cfg.set(JooqMapperFactory.newInstance().newRecordUnmapperProvider(cfg));

@arnaudroger AWESOME~~
I have checked it out but got a little problem. I am using Spring Boot to provide singleton Jooq DSLContext, which will fetch RecordUnmapperProvider as singleton bean as well to build the org.jooq.Configuration.
Although cfg.set(JooqMapperFactory.newInstance().newRecordUnmapperProvider(cfg)); works, but it will required to overwrite lots of Spring Boot code. So I made a PR #694 to decouple
RecordUnmapperProvider and org.jooq.Configuration, it could also allow to shared singleton DSLContext bean rather than DSL.using(cfg) every time for sake of performance. Please kindly review it.

Will do, thanks it is an issue that kind of raised to my mind. Also not in the spring boot context

Have you tried passing a null config in there? The cfg is only used to instantiate a generic Record object

Have you tried passing a null config in there? The cfg is only used to instantiate a generic Record object

Tried. NullPointerException raised when trying to new Record object.


Nwidart\Modules\Exceptions\ModuleNotFoundException     Module [] does not exist!

I tried php artisan module:make-model Language this command and getting
Nwidart\Modules\Exceptions\ModuleNotFoundException     Module [] does not exist! error

problem solved

@mprince2k18 how did you solved this issue?

It is possible to make some misunderstandings from the documentation.
Instead of the correct structure
php artisan module:make-model <model_name> <module_name>
Maybe some people only pass 1 first parameter, because they think this is a command to create multiple models at the same time


Scala for Java Importing Error

I want to use some Jar file which is using Scala for Java packages, for instance scala.collection
But in progress of making _JavaClass, JPype1 raises below error.
TypeError: Cannot create a consistent method resolution
order (MRO) for bases scala.collection.GenTraversableLike$$Static, scala.collection.generic.HasNewBuilder$$Static
Maybe, I think it is conflict in inheritance definition. I try to avoid that case to modify a JPype1, but I couldn't. Anyone who can avoid this situation?
These are used Scala for Java packages.
import scala.collection.Iterator;
import scala.collection.JavaConversions;
import scala.collection.Seq;

I had the same problem; I think the issue seems to be the following:
JPype translates all Java types, both classes and interfaces, to Python types. That means that in complex subtyping hierarchies for interfaces, which may include diamonds and (importantly) the same parent interfaces several times in different orders for a given type, Python may not be able to find a consistent MRO. I think this is a general issue and has nothing to do with Scala, except that Scala has such complex hierarchies in commonly used types.
One solution I could think of is this: When computing the bases and meta bases for a new type, the base interfaces, whose order does not matter because they don't contain any actual method implementations, could be sorted (e.g. by name). This should not affect execution at all, but solves the problem of potentially having the same interfaces in different orders in a type's inheritance hierarchy.
I changed _jclass.py to include this code:
    # Prepare the meta-metaclass
    meta_bases = []
    def getMetaClass(base):
        if base is object:
            return cls
        else:
            return base.__metaclass__
    for i in bases:
        meta_bases.append(getMetaClass(i))

    minterfaces = []
    mclasses = []
    for mb in meta_bases:
        if hasattr(mb, '__isinterface__') and mb.__isinterface__:
            minterfaces.append(mb)
        else:
            mclasses.append(mb)
    def getName(metaclass):
        return metaclass.__name__
    minterfaces = sorted(minterfaces, key=getName)

    meta_bases = mclasses + minterfaces

    interfaces = []
    classes = []
    for b in bases:
        mb = getMetaClass(b)
        if hasattr(mb, 'isinterface') and mb.__isinterface__:
            interfaces.append(b)
        else:
            classes.append(b)
    def getBaseName(base):
        return getName(getMetaClass(base))

    interfaces = sorted(interfaces, key=getBaseName)

    bases = classes + interfaces
    static_fields["isinterface"] = jc.isInterface()

This solves the immediate problem for me, but as you can see, it is
a) not coded very nicely (I am not a Python programmer at all and I just needed to get things to work, don't judge)
b) probably not going to work with Java 8 interfaces that contain default implementations.
If someone has a nicer and/or general solution, or knows a case where this one doesn't work except for default implementations in interfaces, I'd be glad to hear about it.

Unfortunately, it didn't work on my environment. In fact, my JPype environment built on Java 8 interfaces, but I couldn't certainly identify that the reason of not working is cause of Java 8 interface.
I replace a JPype code from meta_bases to before metaclass definition. But Jpype executed same error in my case. Maybe I need to change my Java interfaces.

Thank you for your contribution and I checked this issue has solved. If there is no more issues, I will close this issue. Once more, thank you!


feat(GDK-19): extended tooltip

This PR updates the tooltip for the pumps. It

adds a DataTable component that can be used for the new tooltip contents (and other things)
uses react-map-gls own Popup for handling user interaction and edge cases such as a tooltip close to the screen edge
inserts the pump data into the DataTable into the Popup

Note: This PR does not handle tooltips for mobile. They are currently already disabled explicitly. The reason for this should be figured out separately.
Note 2: TypeScript here was hard to handle. I had to use an any because I couldn't trace back where a type mismatch on the onHover originated. Pointers welcome!

Tested on latest macOS and Windows in latest Chrome, Firefox, Edge, Safari (only macOS).
Closes #239

@dnsos I took a shot at the types for onHover. Since the picked object is a generic we have to provide it. See https://deck.gl/docs/developer-guide/interactivity#the-picking-info-object

@dnsos I took a shot at the types for onHover. Since the picked object is a generic we have to provide it. See https://deck.gl/docs/developer-guide/interactivity#the-picking-info-object

@ff6347, amazing! I had fiddled with a similar approach, but obviously missed something. Thanks for fixing it 🙏


SCP-2289: Try making a special "for evaluation" term type

Another one of Ed's suggestions. I got rid of annotations and replaced
names with Uniques directly, which we can even unpack into the term.
This seems to have better Core: indeed, it gets rid of some wrapping and
unwrapping when looking up or inserting variable mappings.
But the result is overall much worse.
Again, I am baffled. We do a traversal before, and potentially a traversal at the end or when we make errors, but all of that should be lazy. So I don't understand how we can be causing such massive slowdowns. Ideas welcome, again!
crowdfunding/1                           733.6 μs        1.094 ms       +49.1%
crowdfunding/2                           733.7 μs        1.093 ms       +49.0%
crowdfunding/3                           733.2 μs        1.092 ms       +48.9%
crowdfunding/4                           299.0 μs        491.4 μs       +64.3%
crowdfunding/5                           298.9 μs        491.2 μs       +64.3%
future/1                                 355.0 μs        501.0 μs       +41.1%
future/2                                 876.1 μs        1.236 ms       +41.1%
future/3                                 875.2 μs        1.236 ms       +41.2%
future/4                                 1.111 ms        1.892 ms       +70.3%
future/5                                 1.384 ms        2.133 ms       +54.1%
future/6                                 1.121 ms        1.902 ms       +69.7%
future/7                                 1.385 ms        2.133 ms       +54.0%
multisigSM/1                             737.7 μs        1.433 ms       +94.3%
multisigSM/2                             734.7 μs        1.435 ms       +95.3%
multisigSM/3                             753.4 μs        1.472 ms       +95.4%
multisigSM/4                             769.4 μs        1.476 ms       +91.8%
multisigSM/5                             937.7 μs        1.671 ms       +78.2%
multisigSM/6                             735.8 μs        1.443 ms       +96.1%
multisigSM/7                             730.4 μs        1.443 ms       +97.6%
multisigSM/8                             754.6 μs        1.466 ms       +94.3%
multisigSM/9                             773.3 μs        1.475 ms       +90.7%
multisigSM/10                            942.9 μs        1.667 ms       +76.8%
vesting/1                                715.6 μs        1.087 ms       +51.9%
vesting/2                                591.0 μs        947.8 μs       +60.4%
vesting/3                                714.7 μs        1.083 ms       +51.5%
marlowe/trustfund/1                      2.137 ms        4.004 ms       +87.4%
marlowe/trustfund/2                      1.539 ms        3.484 ms       +126.4%
marlowe/zerocoupon/1                     2.223 ms        4.124 ms       +85.5%
marlowe/zerocoupon/2                     1.333 ms        3.284 ms       +146.4%

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

Or maybe I just can't get my head around the idea that a simple recursive traversal of the term could take 136% of the time to evaluate it. Surely not???

I guess I can try pulling it out of the benchmarked part and see...

BTW, your stats look too shaky, are you sure there's no crazy variance in there?

Doesn't look lazy to me. Everything is spine-strict, so forcing to WHNF is forcing to NF.

Yeah, but we always return them in a lazy Just or similar. Also I checked by replacing etermToTerm with const Error () and it made no difference.

Previously, we'd only once pattern match on every AST node of a Term and the rest of the time deal with CekValues.

That's not quite true. CekValue contains terms, and we'll compute them multiple times. If we apply a lambda to 4 different arguments we will compute the term inside the CekValue 4 times.

Maybe Edward meant that we should change the on-chain representation? Then it would take us less time to construct the original Term with all the junk in it and we wouldn't need one more traversal.

If it's truly the case that it's the initial traversal that causes this then yeah, we'd have to do something like that.

BTW, your stats look too shaky, are you sure there's no crazy variance in there?

I ran it both yesterday and today on the benchmarking machine and got the same results. They're just quite weird!

So overall what I thought we might get is:

Pattern matches are smaller: no pointless annotations
Working with Uniques monomorphically means GHC can just pass them directly, can unpack them etc.

I thought this might be a small improvement at best, I'm just baffled that it's instead much slower!

I tried the Marlowe benchmarks on my laptop and got this:
marlowe/trustfund/1       4.033 ms	 7.354 ms       +82.3%
marlowe/trustfund/2       2.933 ms	 6.381 ms       +117.6%
marlowe/zerocoupon/1      4.361 ms	 7.483 ms       +71.6%
marlowe/zerocoupon/2      2.566 ms	 6.055 ms       +136.0%

and then I removed the exclamation marks from the ETerm constructors apart from EConst and I got this
marlowe/trustfund/1       4.033 ms	 5.465 ms       +35.5%
marlowe/trustfund/2       2.933 ms	 4.075 ms       +38.9%
marlowe/zerocoupon/1      4.361 ms	 5.606 ms       +28.5%
marlowe/zerocoupon/2      2.566 ms	 3.656 ms       +42.5%

(master on the left in both cases), so making it strict seems harmful (I tried that with the existing Term type a while ago and also got bad results).  I suppose the conversion isn't just traversing the term, but also allocating memory, which will slow things down too.  I suggest moving the ETerm type into a separate file and doing the conversion before the benchmarking, and seeing what happens then (although you'll have to make sure the conversion really does get done before Criterion gets hold of the AST, and I'm never totally confident that I'm doing that kind of thing correctly).

/benchmark

/benchmark

:astonished:

Whoooooops, really sorry about retriggering the benchmarks!

Maybe only trigger the benchmarks if that command is the only thing appearing in the comment?

Haha, amazing.   The original benchmarks for this PR showed that it made things much worse, but now it's an improvement and there have been no other commits in the interim.

Also some in the game state machine. Quite odd.

So what's going on here? The original benchmarks for this PR showed that it made things much worse, but now it's an improvement and there have been no other commits in the interim.

No, I squashed some stuff in. In particular I pulled the conversion to ETerm out of the part that gets benchmarked. I think that's fair because in a "proper" version of this we could e.g. push that right into deserialization. We can't quite do that now because of the intervening conversion from de Bruijn indices, but once we're not doing that, I even included an instance for Flat (ETerm uni fun) such that you can basically deserialize something you serialized as a Term. So that should really be cheap.

I pulled the conversion to ETerm out of the part that gets benchmarked.

Oh, right.  I should have re-read the other comments!

Also some in the game state machine. Quite odd.

Those are exactly the same scripts that were anomalous in your frames PR last week.  I'd like to know what's going on there.  I spent about 3 hours talking to @bezirg about the similar thing with stablecoin_1-6 yesterday and we couldn't come to any sensible conclusion (partly because we spent a lot of time talking past each other: it eventually appeared to be the case that we'd done two completely different things that both caused slowdowns in the same script).  The only possibility that we were able to come up with was that the contents of TxInfo had been re-ordered and it was taking longer to look something up.  The slowdown was something like 17% though, so it would be surprising if looking stuff up was causing that (although other scripts had largish speedups that we didn't examine which could be due to the same thing).  Maybe built-in Data will help.

Random guess: the ones that regress are ones that are quite fast already.   This one's been open since June 2021and it says "This branch has conflicts that must be resolved".   Yes, I bet it does.
Oh, it also says "Some checks haven’t completed yet"!


Bug 151

Which Issue was this PR made for?

Closes #151

What is within the scope with this PR

Stopping microphone usage after leaving
Added leave button

What is NOT in the scope with this PR
Related Issue
Other sidenotes that reviewer should be aware of

LGTM


How does the in-context velocity report determine items "Completed Late"?

The velocity widget has an option to define the "Days past end date of iteration after which work is late" but the docs don't make it clear how this is determined for the in-context velocity report. Could we make this clearer please?
Thank you for your feedback!
The issues in this repo are for documentation feedback.
If you are submitting your documentation feedback issue directly through GitHub, please provide the URL of the article so we can route the feedback to the correct author.
Please report Azure DevOps or TFS software bugs, feedback, or questions in the Azure DevOps Developer Community.

@K5i4 -- Simon, thank you for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please let us know which topic you’re referencing.  Meanwhile, you may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

Topic is https://docs.microsoft.com/en-us/azure/devops/report/dashboards/team-velocity?view=azure-devops#view-the-velocity-in-context-report.

@K5i4 - Thank you for your inquiry. I'm updating the article to state explicity what each color within the velocity color bars mean.
With the following assignments made to the color bars. All work items counted are assigned to the sprint or iteration.

Planned: Number of work items defined at the start of the sprint
Completed: Number of work items completed within the sprint start and end dates
Completed Late: Number of work items completed after the end of the sprint date
Incomplete: Number of work items which as yet aren't  completed.

Let me know if further clarification is needed.


SPARKC-242: Added ability to build against unreleased Spark versions

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure


METABOIGNITER: Migrate all docs to JSON parameter schema

Hi!
this is not necessarily an issue with the pipeline, but in order to streamline the documentation group next week for the hackathon, I'm opening issues in all repositories / pipeline repos that might need this update to switch from parameter docs to auto-generated documentation based on the JSON schema.
This will then supersede any further parameter documentation, thus making things a bit easier :-)
If this doesn't apply (anymore), please close the issue. Otherwise, I'm hoping to have some helping hands on this next week in the documentation team on Slack https://nfcore.slack.com/archives/C01QPMKBYNR

https://github.com/nf-core/metaboigniter/pull/10

This has been fixed. Thanks


Add milestones

Now I just added the 0.1 milestones. @Kazero0 we need to put missing packages to a isule-community repo.

It is done.


FileSystemException: Cannot open file, path = '/storage/emulated/0/Data.csv' (OS Error: Permission denied, errno = 13)

I can able to read & write files in my other mobiles but in Samsung Galaxy m20 (Android 10). I Can't able to read & write the file. it shows os Error permission denied. please help me with this.
I/flutter (12946): FileSystemException: Cannot open file, path = '/storage/emulated/0/Data.csv' (OS Error: Permission denied, errno = 13)
Even though i allow storage permission in mobile.

Hi @anandsubbu007
could you provide your flutter doctor -v, a minimal complete reproducible code sample and used permissions in AndroidManifest.xml?

I can able to read csv that is in download folder in Samsung m20 device & can able to read & write in any folder in other devices.
but can able to read folder in other folders & write in any other directory in Samsung m20

FileSystemException: Creation failed, path = 'Directory: '' (OS Error: Read-only file system, errno = 30)

Add android:requestLegacyExternalStorage="true" in Androidmanifest.xml
Snippet:
<application
        android:label="appName"
        android:icon="@mipmap/ic_launcher"
        android:requestLegacyExternalStorage="true"
    >


[Feature] Add support to ingest PDF files

Search before asking

[X] I searched the issues and found no similar issues.

Component
Tools/ingest2parquet
Feature
We would like to add ability to read PDF files and convert them to parquet files, which can go through other processing modules like dedup, filtering etc. Today we have support for .zip files via ingest2parquet module
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

@Bytes-Explorer Should we work with Peter Staar on getting his module for pdf processing?


Animation on resize?

Is there any way to animate the layout changes in this control?
Great control, BTW. Just can't figure out how to make the growth of the textview a smooth transition.

remove the line
self.heightConstraint.constant = intrinsicSize.height;
from

(void)handleLayoutWithAutoLayouts{};

and replace with the following code
[self layoutIfNeeded];
self.heightConstraint.constant = intrinsicSize.height;
[UIView animateWithDuration:0.2 animations:^{
    [self layoutIfNeeded];
}];


BUG: jtm script with publish_stats='draft' leads to automatic submission to publication and publishing when 'pub_name' is included

jtm script with publish_stats='draft' leads to automatic submission to publication and publishing when 'pub_name' is included.
I've seen this happen a few times. I would assume the publish_status="draft" would stop the article from being published, but it does not appear to.
pub_name="Towards Data Science",
title=None,
publish_status="draft",

Hi,
I appreciate I'm responding to this months after it was raised but I'm cleaning up all old issues and wanted to look into it. I've had a look at what the behaviour of the Medium API is and I can't see how this would be happening. This is from the Medium API docs here:

So the only way it's possible is if you are an Editor for TDS. And then even if this is so, publish_status='draft' is set here:

in the package code so you would need to explicitly set publish_status='public'.
All that said if this is still posing a problem then pls let me know and I will re-open the issue and investigate.


WIP: fast script loading from snapshots

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.47%. Comparing base (4353cdd) to head (115991e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   80.34%   80.47%   +0.12%
==========================================
  Files          97       97
  Lines       23774    23847      +73
==========================================
+ Hits        19102    19191      +89
+ Misses       4672     4656      -16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Templating Badges dynamically based on c-token content

I'd like to create a custom badge without touching anything about the menu template. For example, if a user selects "India" from the menu, then a badge should display "India" with the Indian flag to the left of the text in the badge.
I know that you can implement a custom template for the dropdown menu using c-item, but that doesn't seem to help with templating badges (which is what I'm really interested in doing). Also, adding a general class to c-token in the settings is not enough, because I have to dynamically create the class name (e.g. " class='flag-india' ") for each badge in order to get the correct country's flag in each badge.
Is it already possible to template the badges? Thanks!

Hi, please wait for the upcoming release in a week.

done !! new template tag  to have custom html in the badge selected item. available in v2.5.0

Thank you!


[CONFERENCE] Pycon APAC

Conference Name
PyCon APAC
URL
https://tw.pycon.org/2022/en-us
Conference Dates
3-4 September 2022
Conference Type
online
Conference Location
No response
CFP URL
No response
CFP Dates
No response
Conference Description
PyCon APAC is a volunteer-run, not-for-profit annual conference centered around the Python Programming language. The goal of the conference is to provide a venue where the Python programming language and surrounding technologies can be explored, discussed and exercised. PyCon APAC is the regional counterpart of PyCon in Asia-Pacific. It is hosted in one of the following countries every year: Singapore, Taiwan, Malaysia, Indonesia, Philippines, Thailand, South Korea, Hong Kong, Vietnam, Japan, India and Bangladesh. Learn something new, teach something new, find opportunities, build cool things, make friends, geek out! Come celebrate and enjoy this event with us!

Thank you for adding this event! \n We'll happily consider it for the next episode. \n\n The Issue autocloses but we'll be reviewing it at https://github.com/users/kjaymiller/projects/4/views/3


Inc documentation improvements

These are small fixes. Bigger changes that merge with my notes on inc are coming.

Oh, I missed we have an index of pages. Fixing it now.

Fixed.

Merged


Release version 0.1

When the first release version can be ready @godjealous

please help intergrated into athene-team/athena


[Documentation]: PropertyGraph Missing image and bad link

Documentation Issue Description
Missing image here
https://docs.llamaindex.ai/en/stable/examples/property_graph/property_graph_advanced/

Link takes you to
https://docs.llamaindex.ai/en/stable/examples/module_guides/indexing/lpg_index_guide.md#construction
which looks like this

Documentation Link
https://docs.llamaindex.ai/en/stable/examples/property_graph/property_graph_advanced/

Embedding images into notebooks, and then converting that to html, is always tricky. Not 100% I can fix the image thing (the actual notebook is here), especially since this conversion is happening automatically with another library


cafile vs certfile in .npmrc

In the npm documentation, it is stated that the certfile option can be used to specify the path to a certificate file. Interestingly, I kept encountering the following error:
WARN  GET <private_registry> error (UNABLE_TO_VERIFY_LEAF_SIGNATURE). Will retry in 10 seconds. 2 retries left.
After spending some time troubleshooting, I tried using cafile instead (just out of curiosity), and it worked 😮
My user .npmrc now looks like this:
@some-scope:registry=<private_registry>
//<private_registry>/:cafile=${HOME}/.certificates/mycert.pem

So, is the documentation incorrect, or could this be a bug?
Versions i used:
> npm -v
10.8.3
> node -v
v20.15.0

Edit: Issue id #1337 time to party 🥳🥳

Yeah that should be cafile.  It's in some config definition warnings too.
Fix: https://github.com/npm/cli/pull/7947


Add maven-wrapper so local maven binary is not required

Add maven wrapper script so local maven binary is not required when working with code base locally

Thanks for bringing this up!
Do you want to contribute and submit a PR for this?

@fx19880617 - I have a PR here https://github.com/apache/incubator-pinot/pull/6702


Possible Memory Leak?

Hi there! I've been using this as a small clock in my table table toolbar in my SPA app. However, when I navigate away from the page that this lib is mounted on, I receive the following warning:

I'd be happy to provide any other information or even a small repro, just let me know.

Can confirm - also experiencing this same behavior.

Good morning,
This problem should be resolved in version 5.0.0-beta1
Please take a look and let me know by the end of the week.

Closing due to inactivity.


[ZEPPELIN-619] Shared Resource pool across interpreter processes

What is this PR for?
This is sub task of https://issues.apache.org/jira/browse/ZEPPELIN-533.
It provides shared resource pool to exchange data across interpreter processes.
What type of PR is it?
Feature
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-619
How should this be tested?
create two different spark interpreter settings.
create two different notebooks each bind different spark interpreter setting.
put an object from one notebook.
read the object from the other notebook. (from the other interpreter process)
See screenshot
Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? javadoc included.

A question @Leemoonsoo, it resource sharing only available through the ZeppelinContext object of the Spark interpreter or is it also available to other interpreters ?

@doanduyhai
ZeppelinContext expose convenient API for ResourcePool for scala repl.
ResourcePool is available through InterpreterContext.getResourcePool() and InterpreterContext is injected into every Interpreter.interpret() call.
So it is available to all other interpreters.

Great news! We have finally a way to share variables between interpreters!

Another question, now that we have a resource pull to share data between interpreters, should we deprecate AngularObjectRegistry and use resource pool instead ?
I have the feeling that resource pool is more general purpose. Furthermore with AngularObject we have the notion of scope (paragraph or note) which we don't have with resource pool. It helps segregate data properly
Anyway it is just a question, it's not blocking for this PR

@doanduyhai Thanks for review and i think i addressed all your comment. Please take a look.
Regarding ResourcePool and AngularObjectRegistry, here's differences

ResourcePool is not propagating object from/to front-end, but AngularObjectRegistry do.
ResourcePool is not persisted into note.json but AngularObjectRegistry does.
AngularObjectRegistry has scope (paragraph/notebook) but ResourcePool does not.

I agree, if we improve ResourcePool more and replace AngularObjectRegistry, that would be simpler and better.

@Leemoonsoo  Thanks for the detailed explanation of differences between AngularObjectRegistry and ResourcePool. I guess that the AngularObjectRegistry is still very relevant since it has a scope system and is saved with notebooks in json.
Otherwise, the code looks good to me so +1 for merge

Thanks @doanduyhai for the review.
Merge if there're no more discussions.


Crashes on resolution >2000px

When trying to generate images with more than 2000px width it just crashes with the message "Segmentation fault (core dumped)". When it doesn't have enough memory it usually says something "Get more RAM" - but this time it doesn't.
I'm using a configuration with 244GB RAM so I hope it's quite enough. I also tried source/style images 800px, 1000px, 1500px and 3000px - it doesn't make a difference, the same crash.
I was able to generate images with less than 2000px with on the same config.

This bug really belonged to Torch/nn and must have been fixed with my recent pull request
https://github.com/torch/nn/pull/443
Hope it finally works on big images! It must work now if compiling Torch from source


Log into file and add path to GET request

And @vezzi our editors do not like each other... :-P

@guillermo-carrasco change editor

Atom rocks!!


Update dem_postprocessing temporal.ma_linreg args

Set default temporal fit values: minimum DEM count of 5 and minimum time separation between first and last DEM of 5 years
Modified @friedrichknuth's split implementation for the count, but I didn't see filter for time separation

Great !


Documentation: explain how existing built-in types work

We already have 2PSet, GCounter, GSet, LWWElementSet, and PNCounter implemented under packages/crdt. Document how they work and their usage in separate READMEs.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I'm a software developer with 2+ years of experience with Java, C#, Dart and others technologies and I'm member of Dojo Coding community here in CR. I would like to contribute to this project.
How I plan on tackling this issue
I would improve the current documentation by providing a clear explanation of each built-in CRDT type, including its core functionality and typical use cases. Additionally, I would ensure the structure is accessible for both newcomers and experienced developers, focusing on simplicity while covering essential details.

Hi @coxmars this issue is not available. Thank you so much for reaching out! Feel free to pick up on other issues

Hi @coxmars this issue is not available. Thank you so much for reaching out! Feel free to pick up on other issues

Thank you for letting me know, I will apply to other issues, thank you 🫡


WRQ-18856: PageViews: Hide indicator when there is only one page

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[x] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
When PageViews component has only one page, the indicator is visible now.
Page indicator is unnecessary for one page, so we decided to hide indicator for one page.
Resolution
Add condition of showing page indicator(steps): total page number should be more than one.
Add unit tests to test visibility of indicator according to page number.
Additional Considerations
Links
WRQ-18856
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim<EMAIL_ADDRESS>

Please resolve the conflict.

According to the UX scenario, when the dot indicator is hidden, the layout should not be changed. However, the layout has changed. Could you please fix it?


refactor(rest): use aurelia-path instead of qs

This change is

a) easier with typescript
b) aurelia-path is usually bundled already, hence reducing size

Ok. 👍