mysql default instance

It seems like most of the time, you only need the default "instance" of mysql, and when that's the case, it would be convenient to utilize the standard paths for everything.
i.e. /var/run/mysql , /etc/mysql , /etc/init/mysql.conf , etc
The final results of a chef cookbook are not only for DevOps chefs.    They are for the developers and the end-users too.   Is it necessary to explain to everybody, they must connect with mysql -S /var/run/mysql-default/mysqld.sock instead of the normal way, and figure out all the new paths, because chef has decided to implement "instances" ,which are not commonly required (are they?).   things should be as simple as possible, when they can be.

There must have been a reason that the mysql cookbook 6.x was written in this way, which unfortunately breaks compatibility with a standard mysql installation, and the previous cookbook.
Perhaps certain puzzles or difficulties presented themselves, and that was the easiest way to solve them at the moment.  What if we can list all those problems and then figure them out.
Here is one such problem:  what if you have a mysql instance "foo"?  should the default package instance then be deleted, or continue to run as a second mysql instance?
There are three cases to consider:
Case 1:  only the default instance is running.
Case 2:  the default instance is defined, and a second instance "foo" is also defined.
Case 3:  the default instance is not defined.  A second instance "foo" is defined, or possibly also a third instance "bar", etc,
For Case 3, it's a mystery, because the default instance may or may not conflict with the "foo" instance.   So what should happen?
Most likely, the solution for Case 3 ought to be an error.   Chef will stop running, and print this error message:
"Please specify what you would like to have happen with default operating system mysql instance, by defining it at least in a minimal way, as follows:
mysql_service 'default' do
action [:delete]
end
OR
mysql_service 'default' do
action [:create]
... and possibly more information, such as port, data_dir, etc would go here ...
end
"
Then, implement the 'default' instance with all the operating system defaults as with the mysql cookbook 5.0
What this solution is offers, is 90% of chef customers and chef developers will get a default, standard mysql installation and not have to do anything usual.  Case 3 won't apply to them.   They won't see that error message.
And then maybe only 10% of chef developers have to jump through a small hoop, as the expression goes.  But that trade-off makes sense, rather than the other way around where everyone is affected.

@sdarwin I'm also very curious as to the rationale behind this implementation. When there's a section in the FAQ titled 'The mysql command line doesn't work' -- that seems like a red flag.
While I've been able make the necessary updates to use this version of the community cookbook, I was surprised that what appears to be a very non-standard way of deploying MySQL is defined as the default way.
Cookbook authors, don't read this as a complaint -- it's really just a request for clarification on why this implementation was chosen. Your hard work and maintenance of this project is appreciated.

I agree with the sentiment expressed here.  While I am aware of this intricacy and the (new) need to specify the socket on the command line, the developers and testers will not be aware of this.  I know DevOps is about bringing everyone up to speed and communication, but it won't always be possible.
I too would appreciate if a default installation were to work exactly as the default package install works so that no additional command line options were needed:
mysql -u root -p

This should work out of the box but it does if not using this cookbook.
While this isn't the end of the world, it would be nice if this behaviour could be maintained.

+1 on the request and sentiments expressed here
Multiple MySQL instances is an edge case. I'm afraid offering the -S option is a poor 'get out' as it fails to consider that other applications and libraries must now be reconfigured where default behavior was just fine before. In some of these cases, connecting via unix socket has not be exposed (the 'localhost' switcheroo is relied upon) and we must now deal with a real network connection.
Please supplement the good work of the .deb/.rpm packages (rather than replace it) as the default option, and support multiple MySQL instances only if explicitly needed.
Thanks!

Hi.
There's actually a quite a bit to cover here, and I'll do my best to
get to it all...
TLDR - "Just connect over the TCP socket."
5.x implemented a "singleton" resource, which did not behave like a
normal Chef resource. Normally, when you declare multiple instances of
a thing in a recipe, you get multiple instances of the thing.
For example, the user resource:
user 'alice'
user 'bob'
user 'carol'

Or, the directory resource:
directory '/foo'
directory '/bar'
directory '/biz'

In 5.x, a recipe with multiple mysql_service resources would only
yield the single service, creating confusion, and departing from the
normal behavior that a user would expect from a recipe.
mysql_service 'foo'
mysql_service 'bar'
mysql_service 'biz'

In 6.x, this works as expected.
Running multiple instances of a service on a machine isn't as big of
an edge case as you might think. It's actually fairly common. Cramming
multiple instances onto a machine with lots of cores lets you
consolidate resources for dev and testing environments. Sharding into
multiple instances lets you overcome the single threaded replication
limitation in older versions. (pre 5.6)
During development, I initially attempted to make
mysql_service[default] special, in an attempt to use native paths.
This method: http://bit.ly/1dEPc59
... originally had the line:
return 'mysql' if new_resource.instance == 'default'
I was of the mind that adhering to the platform native idioms was the
best thing to do. It would certainly fix the mysql client socket path
issue. I quickly discovered that this was not the case.
Popular Linux distributions' native idioms and "helpful" features are
designed aide a manual administration model. In many cases, they're
actively hostile to automated CM.
The Oracle distributed RPMs drop of a directory structure (var, etc),
then the post scripts initialize the database and set a random
password for the root user. The password is stashed in a file on disk.
During the "first boot", you're supposed to start the service, read
the password from the file, connect to database, and  change it some a
known value. If you want to use a different datadir, you're supposed
to reconfigure the service and move the datadir contents over.
When configuring a NEW machine that utilizes point to a pre-existing
database, (mounting a network share or block device into data_dir),
there is no way to know if we should perform "first run" procedures.
The Debian packaging is even worse. Like the Enterprise Linux
packages, Debian postinst initializes the database, and sets a
password. It goes the extra mile and starts the service, giving no
chance to reconfigure datadir.
Don't even get me started on debian-sys-maint.
Package upgrades often contain unpredictable post installation
scripts, override changes to init scripts, and place extra files in
configuration directories.
It turns out what we want is full, manual control over every step of
the configuration process. Of all the platforms this cookbook
supports, OmniOS turned out to be the easiest to deal with. The
"platform native idioms" embodied in the packaging can be summed up as
"dump a pre-compiled binary to disk, and then let the user sort it
out." There was no package post scripts, no service manager
registration, no opinionated pathing, nothing. Beautiful.
One last thought on platform idioms... there is no reason for the "one
instance of a service per machine" outside of it being complicated to
enable using shell-script driven service management schemes.
This cookbook ships a resource that behaves the same using 5 MySQL
versions times 12 OS/version combinations. It turns out, that's hard.
I can't remember the exact details, but somewhere along the line,
there was an edge case where MySQL would use /etc/my.cnf, if present,
ignoring the --defaults-file entirely.
So please. Pretty please, with sugar on top. Just the TCP socket.

PS, you can use the "socket" property in the mysql_service resource to specify /var/lib/mysql/mysql.sock if you want, making the mysql client work without extra args.

another workaround here is to symlink the default socket to the specific one
directory '/var/run/mysqld' do
  owner 'mysql'
  group 'mysql'
  mode '0755'
  action :create
end

link '/var/run/mysqld/mysqld.sock' do
  to '/var/run/mysql-foo/mysqld.sock'
end


Add stories for section transitions

Make cross browser testing easier. Since CSS of a section depends on
entering and exiting transition, add one story for each combination of
enter/exit transitions.
Exclude from Percy build since visual diff is not meaningful.
REDMINE-17369

Coverage remained the same at 99.204% when pulling a5d454fc8a6c8b79aea84769a5bd30a2a380a050 on tf:transition-stories into 973e275a632aca425650fe05889ceb3c937ffb0c on codevise:master.


Removes problematic indirect dependencies<EMAIL_ADDRESS>

Instead pulls in the more recent github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1

does this work with repeated go mod tidy calls?

checked, looks good!


Support for custom ids

I'd be great if we could do graph + ("event", T.id -> "123", foo -> "bar").

mmh, I'm not so sure. IMO opinion the DB should set the ID, and some DBs actually enforce that - if you supply one, it just ignores it.
This feature wouldn't harm though, if you wanna provide a PR I'm happy to take it on board.

I agree with you, but TinkerPop supports user-supplied ids.


Make implicitly global parameter declarations local

These parameters were not explictly marked as local, which causes zsh to
make them global by default. This is presumably unintended, and pollutes
the environment, so they have been explicitly made local in the manner
already present in the file.
These parameters were found using the zsh option WARN_CREATE_GLOBAL.
There may be other implicit global parameters present, as it only
displays a warning when the relevant code is evaluated.

I'm working on the assumption that all implicit global variables are unintentional, such that simply making them local fixes the issue. If any of them are meant to be global, they should be explicitly global: while I very much doubt any of these fall into that category, I recommend briefly skimming the changes before merging.
I will continue to force-push additional fixes along the same lines if I encounter any until it is merged.


Proposal: Drop streamProps helper function

Background

We have an observe higher-order component that is shipped from frint-react
The HoC allows us to return an Observable of props, that can change over time
To make things easier, we included a helper function called streamProps
The helper function can generate a stream of props without needing advanced RxJS knowledge

Introducing frint-props
We also developed frint-props and frint-props-react recently, which is done in a separate repository here: https://github.com/frintjs/frint-props
The features that they provide makes existing streamProps redundant.
We can of course have a safe migration path for this.
Examples
Same result, one with streamProps, the other with frint-props.
With streamProps
import React from 'react';
import { observe, streamProps } from 'frint-react';

import { incrementCounter, decrementCounter } from '../actions/counter';

function MyComponent(props) {
  // `props.counter` (`Integer`)
  // `props.increment` (`Function`)
  // `props.decrement` (`Function`)
  // `props.foo` (`String`)
  return

;
}

export default observe(function (app) {
  const defaultProps = { counter: 0 };
  const store = app.get('store');

  return streamProps(defaultProps)
    .set({ foo: 'foo value' })
    .set(
      store.getState$(),
      state => ({ counter: state.counter.value })
    ),
    .setDispatch({
      increment: incrementCounter,
      decrement: decrementCounter,
    }, store)
    .get$();
})(MyComponent);

With frint-props
import React from 'react';
import { withDefaults, withStore } from 'frint-props';
import { compose } from 'frint-props-react';

import { incrementCounter, decrementCounter } from '../actions/counter';

function MyComponent(props) {
  return

;
}

export default compose(
  withDefaults({
    foo: 'foo value',
    counter: 0,
  }),
  withStore(
    state => ({ counter: state.counter.value }),
    {
      increment: incrementCounter,
      decrement: decrementCounter,
    },
  )
)(MyComponent);

Further reading

https://frint.js.org/guides/higher-order-components/
https://frint.js.org/docs/packages/frint-react/#helper-function-for-streaming-props
https://github.com/frintjs/frint-props
https://github.com/frintjs/frint-props/tree/master/packages/frint-props

@fahad19 That's very helpful. Thank you!


chore: Implemented electron playwright test to swap between a small cube and large lego

closes https://github.com/KittyCAD/modeling-app/issues/3470
Implemented an electron test to create and load small and large files.
Steps

make main.kcl a small cube
create lego.kcl and load it with the test lego.kcl file
swap between these within the project files pane

Background
The PR https://github.com/KittyCAD/modeling-app/pull/3703 has been merged which allows file swapping.  I swap between them and look at the debug panel to see the execution done on the small cube. I do not want to wait for the lego to finish since we want to cancel that execution.

I ran it twice and the macos failure happened twice so seems real


fix not adding to tagstack when jump-return-jump case

Problem sequence
:Cscope find g main
normal <C-T>
:Cscope find g main
normal <C-T>

The second 'find g' does not add a return point to the tagstack, So the second  returns to the wrong point.
Fix
Should check which item is currently active, instead of the total length of the tagstack.

Added two more commits for compatibility issues. Apologies for merging the fixes into one pull request, I'm not familiar with this.

hi @ikjoon-son
thanks for fixing tagstack issue.
please check review comments.
one more thing, i never tested this plugin on windows, does everything else work other that rooter?

The changes to your comments have been committed. Feel free to provide more feedback.
And yes, it works very well on Windows. If anyone is interested, check it out with an old binary that's been sleeping in the Google Archive for over a decade :)
https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/cscope-win32/cscope-15.8a-win32rev1-static.zip

Thanks!!!


Can't get the example to work.

Hi
I am trying out this model for generating paraphrases.
I am following the guideline in readme to test the model, but I am getting an error
on running the code which I don't know how to resolve:
Exception: Tokenizer needs to be initialized with a model name before use!
Please help me out with this. Thanks.
test1_error.txt

I created a new environment with python==3.7.9
and then proceeded with the prescribed installation process in readme,
and then reduced the protobuf version to 3.20.0, after that I changed the
use_cuda parameter for ParaphraseAgent to False and then the example worked for me.


[bug]: Recovery from backup failing

Backing up and then restoring to an external HD results in the error below.

Is this reproducible. It is certainly possible that this is downstream of the drive powering issue.

ok so what this primarily tells me is that we need to change how we do error handling for individual package restore failures during a full embassy restore.
the error message here does not look like a disk i/o issue. this is probably a duplicity specific issue that needs to be resolved.

Reproducing this error is still in progress. Upon further testing, I think this issue may have arose from clicking the wrong button in the recover flow. I definitely clicked "Use drive" in the first iteration of this test. I have subsequently clicked "Cancel" as correctly indicated for the recover from backup flow that is intended to be tested. This resulted in other errors that blocked completion yesterday; testing with these fixes will resume today.

Ok, so this is a specific service failing to recover... It begs the question whether we should fail the entire recovery over a single service failure.

In general, we should not fail the entire thing, at least not unconditionally. However, I think we should also try to fix as many failures as we can. Do we know why it is failing?

blocks #1160

Update: The environment to test this still needs to be recreated, which will be accomplished when this is in progress.


(Some?) KDE apps not usable outside of full kde install

Some e.g. okular, gwenview cannot open files from cmd args but not in-app (error dialog: "Could not open /p/t/foobar"). gwenview loses browsing and thumbnailing capabilities.
All (e.g. above + okteta) are missing (oxygen) icons.

This doesn't occur if services.xserver.desktopManager.kde4.enable = true (same for kde5).
A quick search found kdewrapper but it doesn't seem to be applied to core(?) KDE packages.
Pinging maintainer @ttuegel (I believe).
Example output from gwenview:
Could not find drkonqi at /nix/store/0cv53qzh2vjpvflapa8ay48za4m4i6hp-kcrash-5.10.0/lib/libexec/drkonqi
Icon theme "oxygen" not found.
kf5.kiconthemes: Couldn't find current icon theme, falling back to default.
Icon theme "oxygen" not found.
Error: standard icon theme "oxygen" not found!
Invalid pixmap specified.
QTimeLine::setDuration: cannot set duration <= 0
"URL cannot be listed
trash:/"
Couldn't start kglobalaccel from org.kde.kglobalaccel.service: QDBusError("org.freedesktop.DBus.Error.ServiceUnknown", "The name org.kde.kglobalaccel was not provided by any .service files")
Invalid pixmap specified.
QTimeLine::setDuration: cannot set duration <= 0
Invalid pixmap specified.
QTimeLine::setDuration: cannot set duration <= 0
Invalid pixmap specified.
QTimeLine::setDuration: cannot set duration <= 0
"URL cannot be listed
trash:/"
Couldn't start kded5 from org.kde.kded5.service: QDBusError("org.freedesktop.DBus.Error.ServiceUnknown", "The name org.kde.kded5 was not provided by any .service files") , falling back to running kbuildsycoca5
kf5.kservice.sycoca: Trying to open ksycoca from "/home/e/.cache/ksycoca5"
Invalid pixmap specified.
QTimeLine::setDuration: cannot set duration <= 0
ui/ui_standards.rc not found in ("/home/e/.config", "/home/e/.nix-profile/etc/xdg", "/nix/var/nix/profiles/default/etc/xdg", "/run/current-system/sw/etc/xdg")
"URL cannot be listed
trash:/"
"URL cannot be listed
trash:/"
Could not generate thumbnail for file "file:///home/e/"
Could not generate thumbnail for file "file:///"
mCurrentMainPageId == 'StartMainPageId'

Output from okular:
okular(27918)/kdeui (KIconLoader): Error: standard icon theme "oxygen" not found!

okular(27918)/kdeui (KIconLoader): Error: standard icon theme "oxygen" not found!

okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "okular/Generator"  not found
okular(27918)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
okular(27918)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
okular(27918)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
okular(27918)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
okular(27918)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
okular(27918) KMimeTypePrivate::ensureXmlDataLoaded: Missing <comment> field in "text/plain.xml"
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918) KSambaSharePrivate::isSambaInstalled: Samba is not installed!
okular(27918) KSambaSharePrivate::isSambaInstalled: Samba is not installed!
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "ThumbCreator"  not found
okular(27918)/kdecore (trader): KMimeTypeTrader: couldn't find service type "okular/Generator"
Please ensure that the .desktop file for it is installed; then run kbuildsycoca4.
okular(27918)/okular (app) Okular::Document::openDocument: No plugin for mimetype '"text/plain"'.
okular(27918)/kdecore (trader): KMimeTypeTrader: couldn't find service type "okular/Generator"
Please ensure that the .desktop file for it is installed; then run kbuildsycoca4.
okular(27918)/okular (app) Okular::Document::openDocument: No plugin for mimetype '"text/plain"'.
okular(27918): Couldn't start knotify from knotify4.desktop:  "Could not find service 'knotify4.desktop'."

okular(27918)/kdeui (KNotification) KNotification::slotReceivedIdError: Error while contacting notify daemon "The name org.kde.knotify was not provided by any .service files"
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded
okular(27918) KPixmapSequence::Private::loadSequence: Invalid pixmap specified.
okular(27918) KPixmapSequence::frameSize: No frame loaded

This is a known bug, which has always been there. KDE behaves really nix-unfriendly in this respect, searching for its daemons on $PATH, etc. I heard from @ttuegel he's got some WIP to improve this.

The biggest problem is the sycoca database, which is used by each KDE component to find its runtime dependencies: it is assumed to be per-user and mutable. Essentially, KDE applications live in this mutable-state database (very anti-Nix). My Qt 5.5 branch attempts to solve this by providing an immutable sycoca database for every application. The main annoyance (and the reason this update is so long delayed) is that I have to track down all the runtime dependencies by hand. At least it only needs to be done once! However, I don't expect to backport these improvements to KDE 4.

@vcunat Yeah, I've run into it before but it didn't bother me enough to formally open an issue until now.
@ttuegel Interesting. Do you have a starting point for me to read up on how this works by any chance? // Regarding the immutable sycoca db, how does it work with optional dependencies like kparts, kipi plugins, etc? Also, I looked at your branch---wow, you're doing awesome work!
Should we perhaps mark kde apps as conditionally broken e.g. meta.broken = !config.services.xserver.desktopManager.kde4.enable (probably invalid but I hope the idea gets across)?

Do you have a starting point for me to read up on how this works by any chance?

Not yet, everything is still very much in flux. It's a process of continually tweaking the infrastructure to fix programs that break.

Regarding the immutable sycoca db, how does it work with optional dependencies like kparts, kipi plugins, etc?

It doesn't. Runtime (optional) dependencies are against the Nix Way because they prevent reproducible program behavior. All those runtime dependencies will now be built-in.

@ttuegel: I'm curious about your plan for applications that need the presence of the klauncher
daemon (or any other daemon lauched by kdeinit*)? I'm currently blocked on this issue for fixing the kde4 digikam package.

@jraygauthier My plan is the same as everything else: make it a built time dependency. If it's built into the Sycoca database, it should be launchable on-demand. Of course, this won't help KDE 4 at all.

@eduarrrd : I managed to package digikam so that it work in any DE. I used some of the strategies
@ttuegel used in his branch for the KDE 5 packages (immutable sycoca + wrapper). You can see
the details in #10219. I am certain same techniques can be used to fix both okular and genview (I had
the same oxygen issue with digikam). For gwenview to use the kipiplugins, we will however have to
create a separate kipiplugins package built from digikam sources (this is what is done on debian / ubuntu).

This is no longer an issue; the latest KDE Frameworks have been updated to propagate dependencies correctly.

For gwenview to use the kipiplugins, we will however have to
create a separate kipiplugins package built from digikam sources (this is what is done on debian / ubuntu).

I assume this still hasn't been done? There are no plugins in gwenview and no online exports available in spectacle. I couldn't find existing issues on this, so I wasn't sure if the problem is on my end or there's just too few of us KDE5 NixOS users for it to have been reported yet.

@solson: see https://github.com/NixOS/nixpkgs/issues/17448#issuecomment-246200371 for more recent discussion. KDE packaging still isn't designed to handle installation by nix-env (although it does work partially).

@vcunat Ah, well I'm only referring to the specific sentence I quoted, not this issue as a whole. I'm not using nix-env at all.
Gwenview and and Spectacle still have no plugins, even when you install KDE5 through the NixOS module and whatnot.

I see. I don't know. We do have kde4.kipi_plugins at least.

There are no plugins in gwenview and no online exports available in spectacle.

I'm preparing a PR to add the KIPI plugins to gwenview, but all of Spectacle's optional dependencies are already included, and none of them has anything to do with online exports. Can you tell me what package provides this plugin?

@ttuegel Thanks for working on this. It was my understanding that Spectacle used some of the same plugins as gwenview, but I may have misunderstood. I will investigate more in depth soon.

It seems like (at least most of) the missing plugins come from Digikam. This should be fixed in 0q4j7iv20cxgfsr14qwzx05wbp2zkgc7cg2pi7ibcnwba70ky96g.

@ttuegel I figured out the true cause of Spectacle not being able to find the KIPI plugins today. This PR fixes it for me: https://github.com/NixOS/nixpkgs/pull/21918

Nice catch, thank you!


The pagination should work properly if the admin is trying to view all the notifications.

Bagisto Version: Master
Steps To reproduce--
1. Log in as an admin.
2. Click on the notification icon in the header.
3. Click on the view all notifications link
4. Click on 2 page of pagination.
Expected result: The pagination should work properly if the admin is trying to view all the notifications.
Actual result: The pagination is not working properly if the admin is trying to view all the notifications. Please find the screenshot Here

@Sanjaybhattwebkul It`s working fine as you can see in the reference video - https://www.awesomescreenshot.com/video/10120075?key=873f6922ab0fe9f7cb9714067c773623

@akathuria289
Please check with different-different order status

@Sanjaybhattwebkul
We have tested and tried it with different-2 order status still not facing this issue if any case your are still facing it please mention test case.
https://www.awesomescreenshot.com/video/10244834?key=e1ec61cc8ab82902ad224e3e7f2b9cb5

This is working fine, please mentioned all steps when you reopen this.
Closing this issue for now.


Missing from .NET Core 2.1 documentation

System.IO.Ports should be in .NET Core 2.1 if it is in 2.0, but documentation is missing when one selects 2.1 as their version.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa765d00-19f8-74e4-4be1-1d7f1e7dc6ce
Version Independent ID: 260749e3-69c6-a370-89b0-4f90d944fac7
Content: SerialPort Class (System.IO.Ports)
Content Source: xml/System.IO.Ports/SerialPort.xml
Product: .net
GitHub Login: @mairaw
Microsoft Alias: mairaw

Thanks, @burnchar, for letting us know! We'll investigate and get it corrected.

Didn't mean to close.

Thanks @burnchar. We're working on fixing this issue. The fix however will be to remove the .NET Core 2.0 from the list. When we got the reference assemblies for 2.0, it also included some of the extensions assemblies. We're also working on enabling docs for the extensions too but we still need more time to implement it correctly. In the meantime, we're discussing with the engineering team on possible interim solutions until the new feature is ready.
You can see on apisof.net, the expected info: https://apisof.net/catalog/System.IO.Ports.SerialPort
The .NET Core + Platform extensions entry means is not part of .NET Core itself, but shared as a NuGet package.


Unknown database type binary requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.

Hey there,
I'm using this alongside Laravel Dusk with SQLite for testing purposes, problem is when I try and run the db migrations I get this error:
Doctrine\DBAL\DBALException: Unknown database type binary requested, Doctrine\DBAL\Platforms\SqlitePlatform may not support it.
I've not really used Dusk or SQLite before and after some digging SQLite doesn't have the "binary" datatype but instead uses "blob".
I checked the SQLiteGrammar file and it specifies binary(16) for the typeUuid - changing this to blob(256) fixes the issue.
Just wondering if it's something I'm doing wrong or should the Grammar file specify the blob data type?
thanks

Yeah, that's probably a bug. Feel free to submit a PR!

It's merged! #58


Add Statistics Component

[ x] feature request

Expected behavior
It would be great to have a 'statistics' component similar to Semantic UI. This is a common component in modern web-app design.
Alternatively, what would be the 'clarity' way to display information like this?

I started looking into this as a part of HawaiiFresh when referring to screens that exist in current products. The image below shows a vSphere Client Summary page with the existing set of 3 label/value statistics components and a sketch of how I'd realize this design need in HawaiiFresh. This example uses Clarity icons in place of the (colored) vSphere icons and does not yet include the variations required.
Note that camel case is required for all typography moving forward as all caps presents several a11y issues and should be avoided except in cases where it would be awkward or incorrect otherwise e.g. CPU

also: This has a dependency on HawaiiFresh re: type classes / sizes and will be postponed until that work is complete. Unless there is a case for interaction or editability this should be grouped with label / value pairs. In the above example the information may be incomplete because it displays only the amount but not in reference to the total available.
e.g.
Storage usage
61.3 of 120 GB
Another possible case would be toggling between the data above and a percentage:
Storage usage
51.8%

Circular Progress is part of a statistics component: https://github.com/vmware/clarity/issues/2245

Circular Progress is part of a statistics component: https://github.com/vmware/clarity/issues/2245

The feature request here has been captured into our list and we’re going to take it into consideration as we develop Clarity Core capabilities. In an effort to clean up our backlog and focus our attention, I’m going to close this as captured in our feature requests. Please follow our development and releases to see when we release relevant components to make this possible. Future feature requests can be made in our GitHub Discussions.


Use Uint8Array instead of Buffer

Hey @pabigot, thanks for this library! We have been using it extensively for manual deserialization of blockchain data at Solana. I would like to propose that this library transition to be more browser friendly by using the Uint8Array type over the Node.js specific Buffer type. Currently we rely on browser polyfills but the latest bundler tools are dropping support for those so it'd be great to remove the need for polyfills entirely.
Are you open to this change being made to the next major release of buffer-layout? I'd be happy to own the transition since if we don't upstream this change, I'll be forking this package instead.

Yes, given how many people are using this in non-Node.js environments decoupling it makes sense.  I'm migrating away from Node for the sorts of applications where I needed this library, so I'm open to you providing the changes necessary for the transition, and transitioning ownership of the resulting v2.0.0 to you.  Probably best to start with a PR.

Alright sounds good, will have a PR up soon


Can't download OpenJDK 11

Website Issues:
It seems that Amazon AWS is down or not reachable in the moment. If you

go on https://adoptopenjdk.net/
select OpenJDK 11 (LTS)
select HotSpot
select new publications
select Windows x64
select Install JDK/Download JDK

then the URL
https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.4+11/OpenJDK11U-jdk_x64_windows_hotspot_11.0.4_11.msi
is called, which redirects to
https://github-production-release-asset-2e65be.s3.amazonaws.com/140419044/4457ba80-a962-11e9-8da4-a831c8c1bab6?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20190910%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20190910T135730Z&X-Amz-Expires=300&X-Amz-Signature=a21334b4262a66719dd91a59be6370b2c574032db969933b1f79016c511c0850&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B filename%3DOpenJDK11U-jdk_x64_windows_hotspot_11.0.4_11.msi&response-content-type=application%2Foctet-stream
where I get a timeout.

Seems a problem with the firewall / web-filter on my side. Please delete if possible.


[Bug]: Automation is broken

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

It's live now!


RBAC must not assign the "owner" role to an MSI

find all resources that do role assignments (type will be direct type or an extension resource) - we might be able to search for the property instead but it might not be unambiguous
make sure the roleId property does not contain the guid for the owner role (8e3af657-a8ff-443c-a75c-2fe8c4bcb635)
check that the principal is an MSI (Managed Service Identity)

@bmoore-msft

find all resources that do role assignments (type will be direct type or an extension resource) - we might be able to search for the property instead but it might not be unambiguous

Which resources?

make sure the roleId property does not contain the guid for the owner role (8e3af657-a8ff-443c-a75c-2fe8c4bcb635)
👍

check that the principal is an MSI (Managed Service Identity)
Refresh me on how we make this mapping.  We also may want to consider if we can make some of the relationship mapping part of a function.

Covered by BPA


Support for PMD 7.0

Expected Behavior
Use the new major version for static analysis. The current release version works great (6.55.0).
Current Behavior

The analysis fails due to a missing class because the ant task used by PmdInvoker belongs to a separate dependency.
The rules are no longer bundled, so they also have to be added explicitly.

I am able to run the analysis after making these dependency additions for a Java project.
pmd 'net.sourceforge.pmd:pmd-ant:7.0.0-rc1'
pmd 'net.sourceforge.pmd:pmd-java:7.0.0-rc1'

This results then in rule failures which seem reasonable,

Removed rules not matching the excludes pattern
New or updated rules detecting problems, which need to be addressed or suppressed.

Context
Hopefully it is not a choice of either 6.x or 7.x so supporting a release candidate is acceptable. The default tool version shouldn't change until after the final release, of course.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team but this area of Gradle is currently not a focus one so it might take a while before it gets implemented.

If you are interested in contributing to Gradle, this issue is actionable and ready for contribution but might be challenging for first-time contributors.
See CONTRIBUTING.md for more information.

#25122 resolves the dependency issue noted in the original post.
In order to resolve this issue fully and for Gradle to officially support PMD 7.0, org.gradle.quality.integtest.fixtures.PmdCoverage would need to be updated to add an entry for 7.0.0-rc2 (or the most recent version) and verify all tests succeed.

Is this issue resolved, with gradle 8.5 and toolVersion 7.0.0-rc1 and I am still getting ClassNotFoundException: net.sourceforge.pmd.ant.PMDTask

Is this issue resolved, with gradle 8.5 and toolVersion 7.0.0-rc4 and I am still getting ClassNotFoundException: net.sourceforge.pmd.ant.PMDTask

You may identify the currently used PMD version here:
https://github.com/gradle/gradle/blob/master/platforms/jvm/code-quality/src/main/groovy/org/gradle/api/plugins/quality/PmdPlugin.java
It's defined in a constant DEFAULT_PMD_VERSION

Still an issue ...
pmd {
  toolVersion = "7.0.0"
}

./gradlew pmdMain
> Task :pmdMain FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pmdMain'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.PmdAction
   > java.lang.ClassNotFoundException: net.sourceforge.pmd.ant.PMDTask
$ ./gradlew --version

------------------------------------------------------------
Gradle 8.7
------------------------------------------------------------

Build time:   2024-03-22 15:52:46 UTC
Revision:     650af14d7653aa949fce5e886e685efc9cf97c10

Kotlin:       1.9.22
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          17.0.10 (Eclipse Adoptium 17.0.10+7)
OS:           Mac OS X 12.7.4 x86_64

The workaround mentioned in https://github.com/gradle/gradle/issues/24502#issue-1640617625 still works:
dependencies {
  pmd("net.sourceforge.pmd:pmd-ant:7.0.0")
  pmd("net.sourceforge.pmd:pmd-java:7.0.0")
}

With the simple test project at https://github.com/pmd/pmd-examples/tree/main/gradle/simple-project I cannot reproduce the problem.
For me, it generally works since gradle 8.6. I also confirmed, that it is still working with gradle 8.7. Of course, only for my little example project.
I played around a bit with --configuration-cache and --build-cache, but I still couldn't reproduce the problem: changing "toolVersion" in build.gradle, changes the file "build.gradle" which invalidates the configuration cache. This causes that the correct classpath to run PMD is used.
The relevant lines are here:
https://github.com/gradle/gradle/blob/4437480ed2e6b4d449c0356c2ed65e7127a455e2/platforms/jvm/code-quality/src/main/groovy/org/gradle/api/plugins/quality/PmdPlugin.java#L192-L207

I tried reproducing it with your project and:
$ mkdir /tmp/gradle-pmd-toolversion-7 && cd "$_"
$ mkdir -p src/main/java
$ printf 'rootProject.name = "gradle-pmd-toolversion-7"' > settings.gradle.kts
$ printf 'plugins {
  `java-library`
  pmd
}

repositories {
  mavenCentral()
}

pmd {
  toolVersion = "7.0.0"
}' > build.gradle.kts
$ printf 'class Example {}' > src/main/java/Example.java
$ gradle wrapper --gradle-version=8.7
$ ./gradlew pmdMain
$ ./gradlew --no-daemon --no-build-cache --no-configuration-cache --no-configure-on-demand --rerun-tasks clean pmdMain

In both cases I could not reproduce it anymore—in other words: the combination of PMD 7 and Gradle 8.7 works.
Guess it was a file lock or cache problem yesterday 🤷

This works for me as well when removing my workaround. I'd recommend stopping the daemon and retrying @sdavids. I've had a few cases where leaks across builds cause confusion due to the persistent java compiler, which is a relatively recent improvement to reduce build times. However, sometimes there are class leaks from canceled builds, so maybe in the classpath too. Use ./gradlew --stop and retry.

oops, missed the race. looks like I can closing. Thanks for supporting v7!


Bug: Crash on php 8.4 on TimeTrait::createFromTimestamp() usage

PHP Version
8.4
CodeIgniter4 Version
4.5.6
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
No response
What happened?
I just tried latest CodeIgniter 4.5.6 in my module, and in php 8.4, it cause error:
 Runtime:       PHP 8.4.2 with Xdebug 3.5.0-dev
Configuration: /home/runner/work/ci4-album/ci4-album/phpunit.xml.dist

PHP Fatal error:  Declaration of CodeIgniter\I18n\TimeTrait::createFromTimestamp(int $timestamp, $timezone = null, ?string $locale = null) must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/I18n/TimeTrait.php on line 268
PHP Fatal error:  Uncaught Error: Class "CodeIgniter\I18n\Time" not found in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php:398
Stack trace:
#0 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php(376): CodeIgniter\HTTP\Response->sendHeaders()
#1 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/Debug/ExceptionHandler.php(83): CodeIgniter\HTTP\Response->send()
#2 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/Debug/Exceptions.php(162): CodeIgniter\Debug\ExceptionHandler->handle()
#3 [internal function]: CodeIgniter\Debug\Exceptions->exceptionHandler()
#4 {main}
  thrown in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php on line 398
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
Fatal error: Declaration of CodeIgniter\I18n\TimeTrait::createFromTimestamp(int $timestamp, $timezone = null, ?string $locale = null) must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/I18n/TimeTrait.php on line 268

Fatal error: Uncaught Error: Class "CodeIgniter\I18n\Time" not found in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php:398
Stack trace:
#0 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php(376): CodeIgniter\HTTP\Response->sendHeaders()
#1 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/Debug/ExceptionHandler.php(83): CodeIgniter\HTTP\Response->send()
#2 /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/Debug/Exceptions.php(162): CodeIgniter\Debug\ExceptionHandler->handle()
#3 [internal function]: CodeIgniter\Debug\Exceptions->exceptionHandler()
#4 {main}
  thrown in /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/framework/system/HTTP/ResponseTrait.php on line 398

https://github.com/samsonasik/ci4-album/actions/runs/12532301581/job/34950890792?pr=19
see PR: https://github.com/samsonasik/ci4-album/pull/19
Steps to Reproduce
at github action above.
Expected Output
should not crash.
Anything else?
No response

see https://3v4l.org/5rcSN , return type seems also needed to be changed to static, see without return type https://3v4l.org/INmps and with full param and return type changed https://3v4l.org/JOMF1

PHP 8.4 requires CodeIgniter 4.6.0 or later. See #9116

Ok, closing then ;)


Fixed typo

Fixes #25146

@Potapy4 : Thanks for your contribution! The author, @mayurigupta13, has been notified to review your proposed change.

@Potapy4 Thanks for the fixes! I'm merging now.


Allow for correct positioning inside scrollable containers

I am experiencing a positioning issue when displaying the datepicker inside a container that is scrollable. The problem occurs because the offset().top changes when the container scroll position changes. In order to offset this change in offeset().top the scrollTop of the container needs to be added to the top position`.
Here is a fiddle where the problem is shown. The datepicker on the left uses the body as a container and everything works as expected. The datepicker on the right is in a scrollable container and doesn't display in the correct position.
http://jsfiddle.net/thetimbanks/L24bnfpv/
Here is a fiddle using my proposed change. The change checks the container and adds scrollTop if the container !== 'body'. I don't know for sure if I like that comparison, but it does seem to work. The proposed change is on line 696 of the javascript portion.
http://jsfiddle.net/thetimbanks/L24bnfpv/1/
I have also submitted a PR for this change and am happy to update it in any way.

Fixed in #1617


Introduce hard-coded list of EBBs?

Now that the OBFT hard fork has taken place, we can be sure that there will be no more EBBs forged, ever. This means that in principle we could hardcode a list of all known EBBs
knownEBBs :: Set ByronHash
knownEBBs = Set.fromList [ .. 175 or so hashes .. ]

(potentially with an global IORef and an unsafePerformIO if we wanted to override this list for the benefit of testing). Such a constant would allow us to statically determine if a particular hash corresponds to an EBB or not.
My gut feeling is that this will enable us to simplify the code in quite a few places, and avoid many of the EBB related bugs that have been plaguing ouroboros-consensus. So often we were unable to do the right thing because we did not know if a particular block was an EBB or not. However, I've so far failed spectacularly to convince @mrBliss of this, so I need to think this through.

One example where we needed this kind of context: we introduced annotated tips precisely so that we could pass through information on whether or not something is an EBB.

Done in #2339.


WIP: Replace nodes with render_features and new jobs framework.

WIP: Not finished with documentation. The code has mostly stabilized. Single-threaded performance should meet or exceed 0.0.12.
If you are looking for an example of the new entry points, look at the Mesh feature in the demo.
RenderFeaturePlugin: https://github.com/DavidVonDerau/rafx/blob/dvd/jobs/demo/src/features/mesh/plugin.rs
RenderFeatureExtractJob: https://github.com/DavidVonDerau/rafx/blob/dvd/jobs/demo/src/features/mesh/jobs/extract.rs
RenderFeaturePrepareJob: https://github.com/DavidVonDerau/rafx/blob/dvd/jobs/demo/src/features/mesh/jobs/prepare.rs
RenderFeatureWriteJob: https://github.com/DavidVonDerau/rafx/blob/dvd/jobs/demo/src/features/mesh/jobs/write.rs
FramePacket, SubmitPacket: https://github.com/DavidVonDerau/rafx/blob/dvd/jobs/demo/src/features/mesh/internal/frame_packet.rs
Replace nodes with render_features and new jobs framework.
401a3e5
This is an alternative approach to handling the FramePacket, ViewPacket, and SubmitNode construction. I have tried to closely match the design of the Destiny slides[1]. Each feature now defines custom data for allocation in the frame packet, view packet, and submit packets explicitly. In order to avoid a proliferation of generics, there are type-erased traits (indicated by a RenderFeature prefix) that hide the use of the generic types behind a dyn trait.
This work had two primary goals:

Features should not need to know about threads or tasks in order to be parallelized.
Writing a new feature should be as ergonomic as possible while maintaining the 1st requirement.

Extract, Prepare, and Write jobs now support the same entry points as those defined by Destiny, with the exception of the per game object entry points mentioned as perf & memory optimization. Each feature defines their data format in a FramePacket and SubmitPacket.
The FramePacket is the data extracted from the world. The SubmitPacket is the data prepared for the Write job. Both the FramePacket and SubmitPacket are allocated up-front to minimize allocations and both are accessible to the Write job.
Each FramePacket contains a ViewPacket for each RenderView and each SubmitPacket contains a ViewSubmitPacket for each RenderView. The FramePacket has a RenderObjectInstance for each entity and RenderObject in the current frame and the ViewPacket has a RenderObjectInstancePerView for each RenderObjectInstance in that particular RenderView's visibility. The same layout follow the SubmitPacket and ViewSubmitPacket, but the ViewSubmitPacket also a pre-allocated list of SubmitNodeBlocks for each RenderPhase supported by that RenderFeature.
All of the submit nodes from all features are unioned into ViewPhaseSubmitNodeBlocks according to a shared RenderView and RenderPhase and then sorted by the RenderPhase's defined SubmitNodeSortFunction.

A feature's RenderObjects may be stored in a RenderObjectRegistry -- this replaces the NodeSet previously used by the demo's TileLayer, Sprite, and Mesh render features.
The Extract entry points are defined by ExtractJobEntryPoints and the Prepare entry points are defined by PrepareJobEntryPoints. Each entry point receives a Context argument (e.g. ExtractPerFrameContext) to minimize the loss of performance for unneeded data by that render feature. References to the World or other game resources can be cached while creating the Extract, Prepare, or Write jobs. Each job type is tied to an explicit lifetime (e.g. 'extract) representing that stage of the renderer pipeline.
[1] https://advances.realtimerendering.com/destiny/gdc_2015/Tatarchuk_GDC_2015__Destiny_Renderer_web.pdf
Add new collections to rafx-base.
ca335df

An OwnedPool<T> is a lightweight pool that moves a Pooled<T> to the user. Pooled<T> implements Deref and DerefMut for T. When the Pooled<T> is dropped, the T is moved back to the OwnedPool<T> via a channel.
Added a new key called RawDropSlabKey for the drop slab. The RawDropSlabKey is a type-erased variant of DropSlabKey so that it can be stored as a handle in a type or collection without requiring a generic T.

There are 3 variants of a generic thread-safe storage that don't require default initialization.

AtomicOnceCell is a thread-safe variant of OnceCell.
AtomicOnceCellArray is an indexed variant representing a contiguous fixed-size array of the cells using an atomic bitvector to track accesses.
AtomicOnceCellStack is built on top of AtomicOnceCellArray and provides push / reserve / set semantics using an atomic to track the top of the stack.

All of the Atomic storages will panic if used incorrectly, e.g. by trying to set the same cell simultaneously from multiple threads, or by attempting to read a cell that has not yet been initialized via a call to set or push. AtomicOnceCell and AtomicOnceCellArray contain tests but AtomicOnceCellStack does not because the safety invariants of the AtomicOnceCellStack rely on the underlying AtomicOnceCellArray.
Update Renderer to use new render_features code.
cfeae1a

The RenderFeaturePlugin has been expanded with additional functions for calculating and allocating frame or submit packets, creating each job type, and determining if a given RenderView and RenderViewVisibilityQuery is relevant to that feature.
Added RendererThreadPool to allow the application to control the parallelization of different stages of the renderer pipeline. RendererThreadPoolNone is provided as a single-threaded default if the application does not provide their own implementation.
Seperated RendererAssetPlugin from what was previously just a RendererPlugin containing both feature code (now moved to RenderFeaturePlugin) and asset code.
Added many helper functions to Renderer and RenderFrameJob to make the implementation of the RendererThreadPool easier.

Replace nodes_api_design with renderer_triangle example.
9d11f1f
This example builds on the asset_triangle example to show how to use rafx-renderer and a RenderFeaturePlugin to drive rendering.
Update the demo to use the new render_features code.
320909a

Every feature has been rewritten to use the new extract and prepare entry points and to define their custom FramePacket or SubmitPacket data.
The demo includes an example implementation of RendererThreadPool using bevy-tasks.

Great work! I think we should pick just a few of the "most important suggestions" now (like the addition of the rusts-hash crate as a dependency) and follow up on most of the feedback after merging. Almost all of it is very minor/optional suggestion or questions, and I want to make sure we merge this before any other changes so that we avoid merge conflicts on such a huge change.

Went through anything that was changed, I trust your judgement on what should be addressed now, and what can be done later. If there's anything you think we should do later but you don't want to do right away (or don't want to do yourself), we can just add an issue for it. It's not a bad thing to have a few issues that are first-contributor-friendly, and some of the minor suggestions (like changing the hashing algorithm) would be good candidates for that.


element-{web,desktop}: 1.11.23 -> 1.11.24

Description of changes
ChangeLog web: https://github.com/vector-im/element-web/releases/tag/v1.11.24
ChangeLog desktop: https://github.com/vector-im/element-desktop/releases/tag/v1.11.24

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/219081 was also created for this

Should also bump electron to 23.x

Upstream still uses electron 22 and it seems to be maintained until July.

Upstream still uses electron 22

It uses 23:
https://github.com/vector-im/element-desktop/blob/v1.11.24/package.json#L75

Meh, only looked at the changelog where they usually document that :facepalm:
Sorry, will file a follow-up in a minute!

Also regarding duplicates: just opened #219821 which hopefully fixes ofborg pings so matrix maintainers actually get notified when somebody touches element.


Trace-Command tests for code coverage

Added tests for Trace-Command that increase code coverage to 80%~85% per class.
Fix #4151

@anmenaga take a look at https://github.com/PowerShell/PowerShell/pull/4201 on how to get coverage for Getters/Dispose using api

@SteveL-MSFT @adityapatwardhan This PR is ready for further review

@SteveL-MSFT Do you have any additional concerns? If not, please approve


"with" field for IBA has disappeared

We've lost lots of with/froms because they are separated by pipes:
https://curation.pombase.org/dumps/builds/pombase-build-2022-03-14/logs/log.2022-03-14-21-06-10.gaf-load-output
Previously we were treating the pipes as commas because I didn't know better.  But I presume we don't want to make separate annotations for each of with/from values in that case?
I've reverted the change for now so it doesn't reject the pipes and tonight's load will be back to normal.
I'm going to revert pombase.org too an older version too, probably Friday's so the IBA withs come back.

OK we can chat about this next week. It got a bit complicated!

OK we can chat about this next week. It got a bit complicated!

Yep!  :-)
For now I've allowed the pipes again so the IBAs have a with field.

Action:
i) ban the pipe "|" separator for the "from" field with evidence code "IC" (should always be comma separator)
ii) If there is a "|" in the "with" field (e.g. for PAINT annotation) do not treat as independent annotations,  retain as a single annotation (this is slightly different from norma, c.f annotation extensions, where the meaning is Really critical)

I checked the GOA GAF before the load started and there are no IC annotations with a pipe in the from field.  So I think we won't see any warnings once I change the code (unless there other GAF files with a problem).

I've changed the code to warn about pipes in IC from fields.


Unknow String been prompted

In this example, the bot should only answer "That's correct! The meaning of life is 42" if the user says '42', and it should say "Sorry you couldn't figure it out. Everyone knows that the meaning of life is 42." if the result is something else.
However, if the user tells the bot the answer is "12", the response of the bot is "I didn't understand. What's the meaning of life". Why would the bot say "I didn't understand."? This string isn't in the code, and why he wouldn't print the 'else' message  "Sorry you couldn't figure it out. Everyone knows that the meaning of life is 42."?

So the "I didn't understand." part is coming from the validatedPrompt(). The answer of "12" didn't pass the validation so it triggered the default response. You can tweak this message by passing in a retryPrompt when you call the validatedPrompt().

Hello @Stevenic, so if my validate function returns false it will trigger the default response? It sounds a bit odd that Bot Framework would give any response at all, in my opinion it should only throw errors and in this specific case, I don't think it shouldn't do anything because I want to treat the response. But this is just a suggestion.
Anyway, would you mind to give me an example on how to pass retryPrompt on validatedPrompt()? Because on my understanding, I should only give as parameters the validate function and the promptType (which is text).

If you want to process the response and generate your own reply, don't use the validatedPrompt(). Just call Prompts.text() and then implement your own logic to validate the users response.  The validatedPrompt() is intended to take a fairly boiler plate set of 20 - 30 lines of code and reduce it down to about 3 lines of code. All of the dialog actions are meant to be helpers. You don't have to use them.

Thanks for clarifying things. Now it makes sense.

NP... I'm actually planning to replace validatedPrompt()  with a new Custom Prompts system. This new system will let you create prompts that behave more like the built-in ones and give you more control over how re-prompts work & such.


Convert commands to Kotlin

Convert commands from Ruby to Kotlin with 1:1 functionality.
TODO:

[x] Command registering
[x] Commands:

[x]  animate
[x]  bank
[x]  item
[x]  lookup
[x]  messaging
[x]  npc
[x]  punishment
[x]  skill
[x]  teleport

⚠ incomplete! ⚠

@Major- all but ::lookup converted, ready for merge when there is no more improvements to make


Remove deadcode

The "deadcode" linter is deprecated (no longer maintained) and is now replaced with "unused".
Running this new linter revealed some deadcode throughout the code base, which is being removed by this PR.
I tried to make sure that in each instance, the code was actually supposed to be removed, as opposed to indicative of a bug (e.g., function that should be called for correctness but that is not actually called).
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

/test-all

/test-conformance
/test-networkpolicy

/test-conformance
/test-networkpolicy


fix: ISO hours are range [0..23]

Time should follow ISO standards and hours are in range between 0-23 i.e. 00:32:10 not 24:32:10.
More about this:
https://en.wikipedia.org/wiki/ISO_8601

Nice.  Thanks.


[Bug Fix]: Unsorted Projects When Selecting Tech Stacks #370

Related Issue
It is a fix for the [Bug]: #370
Description
Bug Fix Description:
The issue causing the projects to remain unsorted when selecting tech stacks has been resolved by me.
Here is a preview of the fix:
https://github.com/priyankarpal/ProjectsHut/assets/91745441/d845e962-b2aa-4c59-9600-ca52e481de00
Proposed Solution
To address the bug, the following steps were taken:

Captured the index of the selected tech stack.
Iterated over all the projects, implementing a string matching algorithm using regular expressions (regex).
Sorted the projects based on the matching results.
Updated the user interface to display the sorted projects correctly.

Request for Review and Assistance:
I have successfully resolved this bug and would like to contribute the fix by submitting a pull request (PR).
Thank you for your attention to this matter. I am excited to contribute further to the project's improvement and look forward to your guidance.
Please let me know if there is anything else I can assist you with.

I would like to contribute to this issue as a part of @GSSOC'23
Please assign it to me. Thank you.


Update learning-resources.md

Getting started with fp-ts: Reader post on dev.to is really helpful, hence this should be updated!

Thanks @morishjs


pods: 1.2.0 -> 1.2.1

Diff: https://github.com/marhkb/pods/compare/v1.2.0...v1.2.1
Changelog: https://github.com/marhkb/pods/releases/tag/v1.2.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 234302 run on aarch64-linux 1

1 package built:

pods


Add pod stats

Add a way to display the number of contributions between fellows. Make a little leaderboard or similar to motivate people to add new issues!

@khattakdev @esh04 and I would love to contribute to this issue.


Http error 500 on new install

Tried everything, The whole /html/ folder has read, write, execute permissions.
 It isn't a copy/paste solution.

How I know? Easy - from your error log server name "*domain*" is invalid in /etc/nginx/sites-enabled/default:46
That line, specifically "*domain*" is from https://github.com/robinp7720/Blue-Stats-Minecraft/blob/master/nginx-sample.conf#L7

@lukeeexd https://github.com/robinp7720/Blue-Stats-Minecraft/wiki/Configure-URLs#nginx

A sample nginx config

The config is a sample only ie you need to edit/change to suit to your setup. It isn't a copy/paste solution.
How I know? Easy - from your error log server name "*domain*" is invalid in /etc/nginx/sites-enabled/default:46
That line, specifically "*domain*" is from https://github.com/robinp7720/Blue-Stats-Minecraft/blob/master/nginx-sample.conf#L7

Tried everything, The whole /html/ folder has read, write, execute permissions.

Never chmod 777 the root html directory - EVER!

The domain error is old, I changed it to the ip of the box.
What permissions should it have?

BlueStats doesn't require any write permissions short of the cache directory. Hence, I'd recommend making everything readonly expect for the cache directory.
chmod -R 444 ./
chmod -R 644 cache/

Are you still having troubles with the missing base plugin?

BlueStats doesn't require any write permissions short of the cache directory. Hence, I'd recommend making everything readonly expect for the cache directory:
chmod -R 444 ./
chmod -R 644 cache/

Are you still having troubles with the missing base plugin?

When i chmod 444 I cant see any of the files.
Baseplugin issue still happens but I can set base plugin in admincp

Seems like I need read write execute for user and group. I still have 500 error though

Any ideas?

Sorry, I've had stuff happening during the last few days. For me to figure out why you're experiencing these errors I'd need your webserver and/or php fpm error log.

Where are they located?

Error logs are usually located in /var/logs. Your nginx error logs might be located in /var/logs/nginx/error.log

Yeah theres nothing really there about it

These are not errors related it the BlueStats stats interface. Visit the BlueStats homepage then report the error log

They are. Thats where the files are. /stats/

Wait, I just tried installed something completely different, went to the address and the stats 404 page opened up, I could see the sections at the side (players, home, highscores) I clicked players and the page loaded but nobody showed up. So something weird is going on, cause it should have showed the 404 page from stats

@spannerman79 Uh I do. I have nginx, PHP and MySQL all setup. I had namelessmc running fine before which uses PHP and MySQL

Then you should know how to verify that your PHP install is in fact working correctly

@spannerman79 I have, it is working correctly. I literally just had NamelessMC installed

/etc/php/7.2

@robinp7720 I don't have the time at the moment to test but is Bluestats PHP 7.2 ready?
PHP 5.6 & 7.0 reached EOL 4 months ago, and PHP 7.1 will reach EOL in 6 months time ( source )
If not I suggest you look at the changes needed to make it PHP7.2 ready at least or PHP7.3 as 7.3 EOL isn't until 6 Dec 2021

@lukeeexd I know for a fact that Bluestats works with PHP5.6, so until @robinp7720 replies or if you got time to burn I suggest using PHP5.6 just to test.  If even PHP5.6 fails then it is in fact an incorrect LEMP setup on your end. Stating that "it works with x" doesn't apply.

@spannerman79 On the spigot page it says "Tested with PHP 5.6.3 and PHP 7" does that include PHP7.2?
I'll try with PHP 5.6.3

@lukeeexd @spannerman79
While I haven't done extensive testing of BlueStats on versions above 7.0, BlueStats does work on all recent versions of php including 7.3.x
Enabled debug mode in index.php should reveal any errors

http://<IP_ADDRESS>/ Debug is on just about to start work so can’t look at any of it.

Just had a look. Seems to me that none of the options during install are updating in the files?

The installer sets default values. If you need to update values, you must use the admin panel

I didn’t enter the wrong credentials.  I’ve updated the details in adminCp multiple times

BlueStats is trying to connect to the database without a user name.
All the entries in the admin panel must be submitted individually.

https://imgur.com/gallery/6mTKwbN Is everything I can change. Upon installing I entered correct database credentials, it even connected to everything in the next step

https://www.spigotmc.org/resources/stats.3638/ is this the "lolmewn" plugin in the install? Looking through plugin.php its trying to use "statz"

Warning: mysqli::__construct(): (HY000/1045): Access denied for user ''@'localhost' (using password: NO)
null user doesn't work when communicating with MySQL/MariaDB
http://bfy.tw/NtxQ

Yes, however when installing I add the name and password, and it accepts then and connects but then it shows that error. The details are correct
, I can login to the dB use the dB and view tables. So there’s something with bluestats not saving my MySQL details on install. I can’t change them on adminCp either

Yea ok, this is happening because chrome sends different data for checxboxes then firefox and the installer checks are probably fairly inconsistent. I haven't worked on BlueStats in a long while.
Firefox should fix the problems. If not, I'll see what I can do.

I’ve tried Firefox, chrome and edge. I’ll try again when I’m home and try some other browsers too


Mouse controls

Let me start by saying that I am LOVING PowerToys.
I have a Logitech MX Keys mouse which has additional buttons. It would be great if PowerToys would allow to remap mouse buttons as well.
Especially: the Logitech programme allows to remap for example thumb button one. But it would be great if PowerToys could allow left shift + thumb button one for a different combination.

To the best of my knowledge, this is hardware dependent.  We may be able to override some like middle button but not much past that i believe.

with that said, i'm going to close this against https://github.com/microsoft/PowerToys/issues/11578 which would include this work item.


TextView

Hi, please i want to know how to display the current value at the center of the circle. Do i have to add a textview to my layout? And if yes, how to make it to appear at the center of the circle. Thank you

Yes, you need to add a TextView to your layout. You can then add listeners to update the value.
Take a look at the layout in FauxFit for an example. This example uses a RelativeLayout containing the DecoView and a TextView centered in the RelativeLayout.


Transition between different views

Transition between inactive and active views should use a cross-fade animation.
https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-behavior
Currently, its a lateral motion between the views.

Issue Resolved


Make all icons .svgs.

Including the sharing/getting icons and the stats enabled icon.

Closing as this is not a priority right now


Deck legality doesn't check card types of commanders

The check was removed to allow backgrounds, but it needs to enforce that it's a creature or a background.

Fixed in next deployment.


Convert df to pyspark DataFrame if it is koalas before writing

resolves #320
Description
If the DataFrame to materialize as a table has type databricks.koalas.frame.DataFrame, then convert it to a pyspark.sql.dataframe.DataFrame.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Did only manual testing for this. It worked.
Only tested on Spark 3.2.2. Ideally, this would be tested on Spark 3.1 also.
Here was the dbt Python model used for testing:
import databricks.koalas as ks

def model(dbt, session):
    dbt.config(
        materialized="table",
    )

    df = ks.DataFrame(
        {'City': ['Buenos Aires', 'Brasilia', 'Santiago', 'Bogota', 'Caracas'],
        'Country': ['Argentina', 'Brazil', 'Chile', 'Colombia', 'Venezuela'],
        'Latitude': [-34.58, -15.78, -33.45, 4.60, 10.48],
        'Longitude': [-58.66, -47.91, -70.66, -74.08, -66.86]}
        )

    return df

Used the following code to report the version of Spark (which came from somewhere on the internet):
import pyspark
from pyspark.sql import SparkSession

# Create SparkSession
spark = SparkSession.builder.master("local[1]") \
                    .appName('SparkByExamples.com') \
                    .getOrCreate()

# PySpark Version 3.2.2 and 3.2.2
msg = f"PySpark Version {spark.version} and {spark.sparkContext.version}"
raise Exception(msg)


This is my issue with spotdl

System OS
MacOS
Python Version
3.9 (CPython)
Install Source
pip / PyPi
Install version / commit hash
pip show spotdl
Expected Behavior vs Actual Behavior
Hey Guys and Girls,
Sorry to bother you but I have somewhat of a pressing issue I've followed all of the instructions for download and this is the result. Can you please help me?
Steps to reproduce
MacBook-Jules:~ julesbm$ spotdl https://open.spotify.com/track/6TXafNk9vB640Ta8e0KSlJ?si=38b8ea71d1124d44
Fetching Song...
Found YouTube URL for "10LEC6 - Quakerz" :
https://www.youtube.com/watch?v=CekrE2hcImE
Unable to get audio stream for "Quakerz" by "10LEC6" from video
"https://www.youtube.com/watch?v=CekrE2hcImE"
10LEC6 - Quakerz         Download Started   ━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--
Traceback
MacBook-Jules:~ julesbm$ spotdl https://open.spotify.com/track/6TXafNk9vB640Ta8e0KSlJ?si=38b8ea71d1124d44
Fetching Song...
Found YouTube URL for "10LEC6 - Quakerz" :
https://www.youtube.com/watch?v=CekrE2hcImE

Unable to get audio stream for "Quakerz" by "10LEC6" from video
"https://www.youtube.com/watch?v=CekrE2hcImE"
10LEC6 - Quakerz         Download Started   ━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--

Other details
No response

You need to install SSL certificates
Navigate to Applications/Python 3.9, and double click Install Certificates.command
(Change 3.9 to relevant version number)


[Bug]: No visual indication of multiple files  selected with shift or cmd in file manager

Bug Description
on file selection is visible, but when selecting  multiple files, there is no visual indication which files are picked (wither with shift or cmd), this  is confusing
Relevant Screenshot
No screenshot, as the selected files look the same way as unselected
To Reproduce
TRy to select files with shift or cmd, files are selected but no visual indication which are selected
Sample Text
No response
Obsidian Version
1.4.1
Installer Version
1.3.6
In which mode(s) does the problem occur? (if applicable)

[ ] Source (Edit)
[ ] Reading (Preview)
[ ] Live Preview

Which operating system?

[X] macOS
[ ] Linux
[ ] Windows
[ ] iOS
[ ] Android

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] If your installer version is much lower your app version, you should update it by re-downloading Obsidian from the Obsidian website. The installer version can be seen in the Obsidian settings (About → App → Installer Version).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] My issue concerns Obsidian version 1.0+ and I am not using the Legacy Editor (CM5). (Older Obsidian versions and the Legacy Editor are not supported by this theme anymore.)
[X] This issue concerns the theme in general and is not related to a specific plugin, for which there is the plugin-support form.

@danieltomasz ,I encounter it as well , has you resolved?

has been fixed in the latest release

has been fixed in the latest release

Thks! I've updated.


this._layer.getLatLngs(...).flat is not a function URL

Hello, I am using Geoman (my first time), adding the plugin was not a problem, so I added controls such that at one instance one can only use a single drawing feature such as drawCircle, drawMarker, etc., but when it came to drawPolygon and drawPolyline, encountered this issue. How can go about this? Is there any on map click events that could be the cause?

Thanks, I found out that on extracting coordinates, latlngs have to be an array of points https://leafletjs.com/reference.html#polygon


Results are not accurate when using MMdet 2.x version

Hi everyone! There is a problem with performance when using MMdet 2.x version. I used cascade_mask_rcnn_hrnetv2p_w32_20e_v2.py config file. Also I updated checkpoint file epoch_36.pth with upgrade_model_version.py script. But anyways I am getting not accurate results. Table box is kind of shifted from its actual position.
Steps to reproduce:
!pip install -U openmim
!mim install mmcv-full
!pip install mmdet
!pip uninstall opencv-python-headless==<IP_ADDRESS>
!pip install opencv-python-headless==<IP_ADDRESS>
import cv2 as cv
import numpy as np

from mmdet.apis import init_detector, inference_detector, show_result_pyplot
import mmcv
# Load model
config_file = '/content/drive/MyDrive/CascadeTabNet/cascade_mask_rcnn_hrnetv2p_w32_20e_v2.py'
checkpoint_file = '/content/drive/MyDrive/CascadeTabNet/epoch_36_updated.pth'
model = init_detector(config_file, checkpoint_file, device='cuda:0')

# Test a single image
img = "/content/drive/MyDrive/table_detection/data/handwritten/handwritten_image_9.png"

# Run Inference
result = inference_detector(model, img)

# Visualization results
show_result_pyplot(model, img, result, score_thr=0.50)

Hi,

same issue here

Is there any resolution to this issue. I am also facing the same issue with MMdet 2.1 version

Same issue here

I also run the image in Example/ using mmdet 2.26, the output xml is different from the example xml. There are also no cells, only table coord points

This guide helps dealing with this issue: https://github.com/open-mmlab/mmdetection/tree/master/configs/legacy_1.x


feat: Add tenancy option dedicated on LaunchTemplate

Fixes #4633
Description
Support tenancy: dedicated options for mitigate compliance issues for some reason.
How was this change tested?
I confirmed that the dedicated instance was launched fine in my own eks cluster.
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

What we need to consider is whether to set the tenancy setting as a requirement (for example, karpenter.k8s.aws/instance-category) from the crd of karpenter NodeClass.

It would be good to consider before releasing the CRD of karpenter v1.0. @jonathan-innis

Good work @DingGGu. This is such an important PR to us, as launching dedicated instances is in fact necessary for compliance and we'd love to get it merged as soon as it's deemed ready.

Please Re-Open and consider this as part of a future release. This feature is vitally important for anyone in a highly compliant field e.g. Government, Credit Card processing.

Since AWSNodeTemplate references have been removed from current releases we are going to have to re-think our autoscaling solution if this cannot be resolved otherwise we will lose compliance being unable to reference dedicated instances in any capacity

@engedaam


Same thing as @KaladinDMP

@KaladinDMP stated the issue better than I can atm. Using Tampermonkey w/ Thorium/Edge.
2nd issue.
When trying to use search on main CSrin page. After typing search subject, then clicking search nothing happens. If more info is needed or Screenshot's / Vid Clip.

#63

Sorry, it's still strange but we can't get the bug either. So it's very difficult to fix it without knowing where it comes from.


[terra-demographics-banner] Fix improper HTML, console warnings, and add missing translations

Summary

This is a defect fix involving improper HTML, console warnings, and missing translations for code that was added as part of an accessibility change with #3796.
What was changed:

Fixed issue where more than one div element was between a dl and its child dt/dd pairs. There is now only one div layer between these elements.
Fixed console warnings around the recently added ageTitle and genderTitle internal props.
Added missing translations for non-English locales. Also deleted Arabic and Finnish locales, as those are not currently supported by Terra.

Why it was changed:

The introduction of nested divs with the parent having role="presentation" was was found to functionally work as expected with both JAWS and Voiceover, but created test failures when running Webdriver.io tests and checking for accessibility violations via the axe library. This change should fix any violations, as we are now following proper HTML standards.
Console warnings were causing test/build failures in consuming apps.
We must include translations for all supported locales.

Testing

This change was tested using:

[x] WDIO
[x] Jest
[ ] Visual testing (please attach a screenshot or recording)
[x] Other (please describe below)
[ ] No tests are needed

Tested with both JAWS and VoiceOver.
Reviews
In addition to engineering reviews, this PR needs:

[x] UX review
[x] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9199
UXPLATFORM-9160

Thank you for contributing to Terra.
@cerner/terra

Great work, Steven! JAWS announces the elements of the demographic banner very nicely. I used the Down Arrow to navigate from the Patient Name, which is announced as an H2, to the list of identifying data items. JAWS announced the label and value for each as I used the Down Arrow to go down the list. The other data items in the banner were grouped in a separate list for the full banner examples. For the compact banner, the demographic items and the other items were grouped  and announced as 1 list.

Great work, Steven! JAWS announces the elements of the demographic banner very nicely. I used the Down Arrow to navigate from the Patient Name, which is announced as an H2, to the list of identifying data items. JAWS announced the label and value for each as I used the Down Arrow to go down the list. The other data items in the banner were grouped in a separate list for the full banner examples. For the compact banner, the demographic items and the other items were grouped and announced as 1 list.

Thanks for confirming! What you describe is the expected behavior. The large banner now will group the list items based on the visual presentation, as two separate lists. The small view displays the identifiers as a single list, and they are announced as one list. Although the original goal with this fix was to make both large and small banners read as one list or as two, I was unable to technically achieve this without creating visual changes. Therefore, we are maintaining this subtle inconsistency, while also following the WCAG standards.


fix(tooltip): 12087 fix crash after tooltip animation fix

Codecov Report

Merging #381 (9460529) into main (646b26e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   11.72%   11.71%   -0.01%
==========================================
  Files         544      544
  Lines       38882    38891       +9
  Branches     1167     1167
==========================================
  Hits         4557     4557
- Misses      33880    33889       +9
  Partials      445      445

Impacted Files
Coverage Δ

...ents/CssTransitionWrapper/CssTransitionWrapper.tsx
0.00% <0.00%> (ø)

...s/tooltip/components/PopupTooltip/PopupTooltip.tsx
0.00% <0.00%> (ø)


Performance hit with da.delayed processing in dask 2022080 vs 2022070

What happened:
We're using dask.delayed to process Zarr files, see here for details: https://dask.discourse.group/t/using-da-delayed-for-zarr-processing-memory-overhead-how-to-do-it-better/1007
The actual processing may not be optimal and we're looking to make it more memory efficient (separate discussion in the forum post). While doing that, I tested the new 2022080 release. It is about 25x slower for our approach of using a dask.delayed function to process the Zarr array in dask release 2022080 than in dask 2022070 (or than in 2022011). The full line is 2022080, the dotted line is 2022070

What you expected to happen:
I would expect the performance to be the same/similar.
Minimal Complete Verifiable Example:
# Generate some synthetic Zarr file of varying size:
import numpy as np
import dask.array as da

shapes = [
    (2, 2, 16000, 16000),
    (2, 4, 16000, 16000),
    (2, 8, 16000, 16000),
    (2, 16, 16000, 16000),
]

for shape in shapes:
    shape_id = f"{shape}".replace(",", "").replace(" ", "_")[1:-1]
    x = da.random.randint(0, 2 ** 16 - 1,
                          shape,
                          chunks=(1, 1, 2000, 2000),
                          dtype=np.uint16)
    x.to_zarr(f"data_{shape_id}.zarr")

# Our processing functions
SIZE = 2000
# Function which increases value of each index in
# a SIZExSIZE image by one (=> pseudo-processing)
def shift_img(img):
    return img.copy() + 1

delayed_shift_img = dask.delayed(shift_img)

def process_zarr(input_zarr):
    out_zarr = f"out_{input_zarr}"
    data_old = da.from_zarr(input_zarr)
    data_new = da.empty(data_old.shape,
                        chunks=data_old.chunks,
                        dtype=data_old.dtype)

    n_c, n_z, n_y, n_x = data_old.shape[:]

    print(f"Input file: {input_zarr}")
    print(f"Output file: {out_zarr}")
    print("Array shape:", data_old.shape)
    print("Array chunks:", data_old.chunks)
    print(f"Image size: ({SIZE},{SIZE})")

    for i_c in range(n_c):
        for i_z in range(n_z):
            for i_y in range(0, n_y - 1, SIZE):
                for i_x in range(0, n_x - 1, SIZE):
                    # Need to do this in 2 steps to avoid a
                    # TypeError: Delayed objects of unspecified length have no len()
                    new_img = delayed_shift_img(data_old[i_c, i_z, i_y:i_y+SIZE, i_x:i_x+SIZE])
                    data_new[i_c, i_z, i_y:i_y+SIZE, i_x:i_x+SIZE] = da.from_delayed(new_img,
                                                                                shape=(SIZE, SIZE),
                                                                                dtype=data_old.dtype)

    # Write data_new to disk (triggers execution)
    data_new.to_zarr(out_zarr)

    # Clean up output folder
    shutil.rmtree(out_zarr)

# Code to run the analysis
input_zarrs = ['data_2_2_16000_16000.zarr', 'data_2_4_16000_16000.zarr', 'data_2_8_16000_16000.zarr', 'data_2_16_16000_16000.zarr']
for input_zarr in input_zarrs:
    interval = 0.1
    mem = memory_usage((process_zarr, (input_zarr,)), interval=interval)
    time = np.arange(len(mem)) * interval
    mem_file = "log_memory_" + input_zarr.split(".zarr")[0] + "_.dat"
    print(mem_file)
    np.savetxt(mem_file, np.array((time, mem)).T)

Anything else we need to know?:
Environment:

Dask version: 2022070 vs. 2022080
Python version: 3.9.12
Operating System: macOS 12.5
Install method (conda, pip, source): pip

Thanks for reporting @jluethi. Looking at the git log between the 2022.07.0 and 2022.08.0 releases nothing seems like an obvious culprit. Are you able to run git bisect to determine which PR lead to a change in behavior?
Also, just to double check, are you using a local scheduler or a distributed cluster? From the example, it looks like a local cluster, but just wanted to confirm

Thanks @jrbourbeau , will try to narrow it down with git bisect. As the only differentiating factor I could find is runtime, it may take a bit. Will report back when I manage to narrow it down.
And yes, just using the local scheduler both for this example as well as in general.
(We're currently using parsl for orchestration on our cluster to handle some further complexities and use dask within each larger job to parallelise further within each node that we run a job on.)

@jrbourbeau Ok, ran git bisect, thanks a lot for pointing me there, that's a really useful tool!
Using that, I found the issue first at ac74939697c328bd6456aa9fad7d9520328db6e5
Given that this involves some changes to dask graph handling, this could make sense.
Also, again, we may not be using dask optimally here (see discussion about the memory inefficiencies in the forum post linked at the top). But ac74939697c328bd6456aa9fad7d9520328db6e5 makes the code above run significantly slower:

For the (2, 4, 16000, 16000) test, about 27s instead of 7s
For the (2, 16, 16000, 16000) test, about 1800s (~30min) instead of ~80s

Not sure though what other workflows would be affected. At least in that case, performance scaled way worse with larger graphs.
Tagging @rjzamora : would you have an idea why ac74939697c328bd6456aa9fad7d9520328db6e5 would lead to such a performance hit?

Tagging @rjzamora : would you have an idea why https://github.com/dask/dask/commit/ac74939697c328bd6456aa9fad7d9520328db6e5 would lead to such a performance hit?

Thanks for the ping, and for writing this up!  I will try to figure out if that "fix" caused other graph-related problems.

Ok, ran git bisect, thanks a lot for pointing me there, that's a really useful tool!

Totally agree : )

I will try to figure out if that "fix" caused other graph-related problems.

Thanks for taking a look @rjzamora!

Update: I'm expecting https://github.com/dask/dask/pull/9413 to resolve this issue


Game Crash when placing a block from AE2 Stuff

The Game keeps crashing when placing a block. After restarting Minecraft the Block is placed and works fine. It just crashes when placing it. Doesnt matter if Crystal Growth Chamber or Advanced Inscriber and whatever.

Dupe of #164


Fix the exception in server instance when Helix starts a new ZK session

ServerInstance.start() is called when Helix starts a new ZK session, and
can be called multiple times. We only need to start the server instance
once, and simply ignore the following invocations.

Codecov Report

Merging #4976 into master will increase coverage by 15.47%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #4976       +/-   ##
=============================================
+ Coverage     36.35%   51.82%   +15.47%
- Complexity        0       12       +12
=============================================
  Files          1174     1174
  Lines         62244    62246        +2
  Branches       9148     9148
=============================================
+ Hits          22627    32258     +9631
+ Misses        37596    27518    -10078
- Partials       2021     2470      +449

Impacted Files
Coverage Δ
Complexity Δ

...rg/apache/pinot/server/starter/ServerInstance.java
1.49% <0%> (-86.2%)
0 <0> (ø)

...starter/helix/DefaultHelixStarterServerConfig.java
0% <0%> (-96.16%)
0% <0%> (ø)

...converter/stats/RealtimeSegmentStatsContainer.java
0% <0%> (-94.45%)
0% <0%> (ø)

...rg/apache/pinot/tools/utils/KafkaStarterUtils.java
0% <0%> (-93.19%)
0% <0%> (ø)

.../starter/helix/HelixInstanceDataManagerConfig.java
0% <0%> (-92.31%)
0% <0%> (ø)

...ot/tools/query/comparison/SegmentInfoProvider.java
0% <0%> (-88.68%)
0% <0%> (ø)

.../transform/function/MapValueTransformFunction.java
0% <0%> (-85.3%)
0% <0%> (ø)

...pache/pinot/server/starter/helix/SegmentLocks.java
0% <0%> (-83.34%)
0% <0%> (ø)

...tools/query/comparison/StarTreeQueryGenerator.java
0% <0%> (-82.84%)
0% <0%> (ø)

...server/starter/helix/HelixInstanceDataManager.java
0% <0%> (-82.82%)
0% <0%> (ø)

... and 678 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81e530...32d476b. Read the comment docs.


OLTII

from the bible:
Ng diak a ngeral sebechel el rullii el mo oltii a klengar er ngii.
what is OLTII here? it looks like we don't have in the dictionary yet.

Hmm... Oltii?
What verse is this? Want to look it up.
Thanks.
On Fri, Mar 18, 2022, 2:59 PM smith-371 @.***> wrote:

from the bible:
Ng diak a ngeral sebechel el rullii el mo oltii a klengar er ngii.
what is OLTII here? it looks like we don't have in the dictionary yet.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXYSPXS4IOB2VUQYOEGWNPTVATVEFANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

MATEUS [16:26]: Ng diak a ngeral sebechel el rullii el mo oltii a klengar er ngii.
MARKUS [12:3]: Ma re chad er a sers a mildechemii ngii el mesiungel, e cholebedii, e oltii el di chim.

Replace return/ oluut main word.
On Fri, Mar 18, 2022 at 3:07 PM smith-371 @.***> wrote:

MATEUS [16:26]: Ng diak a ngeral sebechel el rullii el mo oltii a klengar
er ngii.
MARKUS [12:3]: Ma re chad er a sers a mildechemii ngii el mesiungel, e
cholebedii, e oltii el di chim.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10#issuecomment-1072850446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJDDAPWYCQGCKFIYNMTVAT5D3ANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

When I've heard that word used in this context it's been "olutii", but then, again, it might be a localized dialect difference.
Like people from Keiukl who I have heard say MISkebesang and we say MESkebesang. Or it could be an individual person's speech pattern.

I have heard both:
Oluut; olutii; oltii
Uluut; ulutii; ultii.
Could be like Souang said: could be Keiukl and Desbedall or Eouldaob and
Babeldaob lingo.
On Fri, Mar 18, 2022 at 4:16 PM s-o-u-a-n-g @.***>
wrote:

When I've heard that word used in this context it's been "olutii", but
then, again, it might be a localized dialect difference.
Like people from Keiukl who I have heard say MISkebesang and we say
MESkebesang. Or it could be an individual person's speech pattern.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10#issuecomment-1072881644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJFKQKRELGFK4FCDYALVAUFDZANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Good points, Ulang.
And ulluut and olluut. I'm not good at what part of speech this is. The first one is past tense and the second is active in the present tense.

For the same word as well, some enunciate it with double l and some don’t.
On Fri, Mar 18, 2022 at 7:04 PM s-o-u-a-n-g @.***>
wrote:

Good points, Ulang.
And ulluut and olluut. I'm not good at what part of speech this is. The
first one is past tense and the second is active in the present tense.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10#issuecomment-1072918492,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJA37BIGRHHI2RI3BOTVAUY3DANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Or "old Palauan" maybe? I do agree with the regional explanation. Just like
"metengel" and "tmengel" "metei" etc.
I asked an Aunt who was part of the original Bible translation and she
confirmed it is the same as "olutii."
I, myself, have not heard this variation before. It is in the recent bible
translation so I guess it is more common than I thought.
On Fri, Mar 18, 2022 at 8:24 PM Gnalu @.***> wrote:

For the same word as well, some enunciate it with double l and some don’t.
On Fri, Mar 18, 2022 at 7:04 PM s-o-u-a-n-g @.***>
wrote:

Good points, Ulang.
And ulluut and olluut. I'm not good at what part of speech this is. The
first one is past tense and the second is active in the present tense.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10#issuecomment-1072918492,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AF2DJJA37BIGRHHI2RI3BOTVAUY3DANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/10#issuecomment-1072921504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXYSPXWYSNXWKDCSRH4BP63VAU3FFANCNFSM5RC4TPKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


Preserve Symbolic Links in the build process

For a parallel testing scenario, in MacOS, if we use symbolic link of the main project in the tests, in the build process, these folders are considered as a separate module.
Adding --preserveSymlinks to the rollup process solves the problem.
Do you consider this a good solution or advise something different?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Fernando, thanks for your contribution! This looks like an interesting addition. Would you be able to provide a simple test project that we can use to verify and validate the issue and solution?
@sandeep-vedam can you take a look at this PR please?

Let me see how can I do that, because this is to be used in the build process. Maybe a bash shell script? I'm going to check in Linux, MacOS and Windows.

Hi @fernando-j-afonso-alb,
we have checked the PR and haven't found any issues. So we're merging it in and it will be available in our next release.
Thanks