[stable/jenkins] Added backup service account annotations and pod securitycontext

Ive checked this on my local project and it works fine, adds annotation to the service account Jenkins-backup and sets proper securitycontext to the backup pod.
What this PR does / why we need it: Adds annotations to the jenkins-backup service account and securitycontext runAsUser and fsGroup to the pod generated by backup Cronjob
Which issue this PR fixes

fixes 22670

Special notes for your reviewer:
This is my first PR so dunno if ive done everything right, please guide me if there is something wrong.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@KrzesloSzatan please also look into the DCO check. That needs to be fixed before it can be merged.

@KrzesloSzatan any update here?

@KrzesloSzatan please also look into the DCO check. That needs to be fixed before it can be merged.

I dont know what is wrong, ive done what is written in the guide like 15 times already and its always the same. Could you please tell me what im doing wrong ?
Ive done
git commit --amend --signoff
then
git push --force-with-lease origin master
But there is still a problem i dont know how to resolve :/

@KrzesloSzatan your PR has three commits. One of them (85d941ee0eb7ce66984f1d2cce884ad0e24ce23a) is not signed.
You could rebase your changes on master interactively (git rebase -i master) and squash those commits into one and sign it.

@KrzesloSzatan your PR has three commits. One of them (85d941e) is not signed.
You could rebase your changes on master interactively (git rebase -i master) and squash those commits into one and sign it.

 But dunno if i havent done more mess than it was before.

@KrzesloSzatan DCO check passes, but we have quite some conflicts...

@KrzesloSzatan DCO check passes, but we have quite some conflicts...

Maybe i should just clone repo once again and do my changes, then just push it again and create another PR ?

That's also ok. Looking forward to your PR.

/hold This chart will be moved to https://github.com/jenkinsci/helm-charts see for details #23562
Would be great if you could create the PR in the new location.

👍


stability issue of the bot

as of some of you know, you may have noticed that the bot is missing some fixes, well my knowledge is not good at some point including on how to use $onlyIf function for advanced fixes, i am currently trying my best to fix everything and make this bot stable, hopefully someday it will be better than before, i am currently messed up since the last launch of discord.js v13 making me being forced to finish development of this bot without focusing on bug fixes, sure bugs can ruin the demo of the features which is shown in the bot but nothing is impossible to fix, stay tuned for ❤ updates, if you would like to help me, then you're more than welcome here, you can also submit a pull request to fix my codes, if appreciated 😊

additionally, the finalizes of finishing this bot will be submitted to a branch which attempts to show the final full version of the bot hoping for it to be better and bug-free

not too much, just djs and javascript beginner

therefore, i am now getting better in aoi recently

exactly, since you are using leaf-utils you know who leaf is so start using his handler and his moderation bot, it will help you a lot

well, good idea, thanks your suggestion

no problem dude, what's your discord tag so I can contact you on discord

no problem dude, what's your discord tag so I can contact you on discord

dodoGames#7509 this project is mostly maintained only by me, since i don't have a team and so i can't sometimes find new bugs in my bot code

UPDATE: from now on a lot of bugs will be fixed starting with v1.7, this will be also aims to be the full version of the bot and fix a lot of bugs it had since it's early development as well as finally fixing an proper support for mod commands instead of leaving it being broken, gl, everything should be started being updated in the beta branch from now on, good luck if you're gonna try it anyways, ty

This is no longer happening in v2. Closing this now and thanks for everyone for trying to help me, i really appreciate it so much!
As usual, have a nice day! See you later in the full v2 release.


Add the ability to change focus automatically when process finishes

I just noticed that @nat-chan created a very useful feature in his fork. This new feature automatically switches focus to the finished window. I think this would be good. I, however, think it should not be the default as it is currently in @nat-chan's branch.
Proposal
My Idea is to pull the changes of @nat-chan into my fork and modify them slightly such that user has two ways to monitor a pane:

prefix + m: The regular pane monitor option.
prefix + alt + m: Now the pane is monitored, and the focus is returned to the pane when it finishes.

Alternatively, we can of course also use a tmux-option to change this behaviour, but I think the above method would allow users to decide on a pane basis whether the want to return the focus. @ChanderG and @bruno- what do you think about this new feature?

Sounds good - per pane selection like you mention seems better.

@ChanderG great I will start working on it after we resolved #7.

This feature is added in #17


Persistence: IRepository Refactor, RedisDB and RocksDB

Refactored IRepository
Refactored and Extended RedisDbRepository and Helper Classes
Added project and stubs for NeoSharp.Persistence.RocksDB implementation
Added RocksDbNative and RocksDbSharp NuGet Packages to the solution to provide RocksDB and Managed Wrappers to the NeoSharp.Persistence.RocksDB library
-Commit initial stubs and rough / basic code for RocksDB repository implementation

Wrong branch...


Expand programming guides with async/await style code/idioms

We totally should propagate the new style of doing asynchronous stuff in Python: async and await.

What about the examples? On the plus side, "new" asyncio programmers won't be confused. On the downside, they won't interop with trollius or python <= 3.3 (but > 2.7).
Personally, I suspect that anyone who is currently doing asyncio but stuck on older python (3, or 2.7) will know what to do when they see "async def" or "await" so we should switch the examples, too. Anyone who doesn't know better probably wants to see the latest and greatest (async/await).

https://github.com/crossbario/autobahn-python/pull/732 at least updates the examples. The programming guide is already split Twisted/asyncio -- did you just mean to upgrade any current asyncio listings to use await and async def instead of yield / Futures?

latest twisted support async/await too
https://twistedmatrix.com/documents/current/core/howto/defer-intro.html#coroutines-with-async-await


chore(deps): update common-dev-assets digest to 10ac9e5

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
c990c99 -> 10ac9e5

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 3.8.0 :tada:
The release is available on:

GitHub release
v3.8.0

Your semantic-release bot :package::rocket:


Portfolio and Portfolio items missing as_json method

The as_json method allows us to convert ids to string objects,
we need to add a as_json method to these models and also fix the specs which are currently expecting an integer for ids.
Something like this
https://github.com/ManageIQ/service_portal-api/blob/f1cc68c34e0110eb1f1aa4e7131622b4a639051b/app/models/order.rb#L22

The as_json method has been implemented at a lower level in https://github.com/ManageIQ/catalog-api/pull/152/files.
It requires a follow-up PR to use openapi.json to validate what attributes are actually returned in the payload.  As referenced in https://github.com/ManageIQ/catalog-api/pull/158#pullrequestreview-215759611


Respect overrideItemProps in ComponentStructureWrapper

Description

Related Issue(s)

closes #{issue number}

Verification/QA

Manual functionality testing

[ ] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[ ] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[ ] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[ ] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[ ] This change/feature does not require any changes to Altinn Studio

Sprint board

[ ] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[ ] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

Looks good! 🙌 Although I do think that these massive changes to introduce prop-drilling everywhere is a good reason to use the existing stuff we have, like FormComponentContextProvider. But that might just be my style, and not something everyone else agrees with.

Yeah I am not super happy with the prop drilling for sure, this was quick and dirty, but its easy enough to refactor later

@olemartinorg It was quick to move it to FormComponentContext which was much cleaner indeed 🙌


shelf_router_generator under Dart 2.9.1 is failing to parse uri.dart

Shelf router generator is failing on uri.dart under Dart 2.9.1:
[SEVERE] shelf_router_generator:shelf_router on bin/server_cloud_run.dart:

Bad state: Unexpected diagnostics:
/Users/brettmorgan/homebrew/Cellar/dart/2.9.1/libexec/lib/core/uri.dart:3259:39 - Expected an identifier.

This worked under Dart 2.9.0. This error message is from attempting to build dart-lang/dart-services.

Actually, I'm not sure that shelf_router_generator is the proximate cause


Wrap around for previous/next review comment buttons

Fixes #16317
Wrap around from last to first comment when clicking "Next" on last comment.
Wrap around from first to last comment when clicking "Previous" on first comment.

Codecov Report

Merging #16319 (13fa3b4) into main (ce286f9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16319      +/-   ##
==========================================
- Coverage   45.41%   45.41%   -0.01%
==========================================
  Files         709      709
  Lines       83611    83611
==========================================
- Hits        37974    37973       -1
+ Misses      39549    39547       -2
- Partials     6088     6091       +3

Impacted Files
Coverage Δ

services/pull/temp_repo.go
26.59% <0.00%> (-3.20%)
:arrow_down:

services/pull/check.go
25.51% <0.00%> (-2.76%)
:arrow_down:

models/unit.go
41.09% <0.00%> (-2.74%)
:arrow_down:

services/pull/patch.go
54.23% <0.00%> (-1.70%)
:arrow_down:

services/pull/pull.go
42.42% <0.00%> (+0.43%)
:arrow_up:

models/repo_list.go
77.82% <0.00%> (+0.77%)
:arrow_up:

modules/queue/workerpool.go
54.19% <0.00%> (+1.14%)
:arrow_up:

modules/notification/mail/mail.go
38.23% <0.00%> (+1.96%)
:arrow_up:

services/mailer/mail_comment.go
85.18% <0.00%> (+7.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce286f9...13fa3b4. Read the comment docs.


NotSupportedException in Offline Sync Mode v. 3.0.3

Hi,
I have a curious issue. In the official Xamarin.Froms TodoItems sample from the Azure site I have even in Offline enabled mode a query on the table like that:
               var items = await todoTable                     .Where(todoItem => !todoItem.Done)                     .ToEnumerableAsync();
No problem it works. That sample has Verison 2.1.1 of Client/SQLiteStore.
In my current project I am on Version 3.0.3 of Client / SQLLiteStore and a query like that throws a NotSupportedException:
              IEnumerable<TruckFahrer> items =                      await OfflineSyncStoreManager.Instance.TruckFahrerTable                     .Where(fahrerinfo => fahrerinfo.Imei.Equals(imei)) //TODO: Why does that throw an exception???                     .ToEnumerableAsync();
I posted a more detailed description on: SO
What am I doing wrong?
thanks,
Eric

@ericbrunner You just use .Where(fahrerinfo => fahrerinfo.Imei == imei).ToEnumerableAsync() instead of .Equals(), right?

@dhei I use .Where(fahrerinfo => fahrerinfo.Imei.Equals(imei)) Why does that throw an exception???

@dhei I have one query where it is working. The only difference is that the imei is of type string and the selectedAuftragTruckAppId is of type int:
 IEnumerable<TruckAuftragLauf> items = await OfflineSyncStoreManager.Instance.TruckAuftragLaufTable                     .Where(auftraglauf => auftraglauf.TruckAppId == selectedAuftragTruckAppId)                     .OrderBy(auftraglauf => auftraglauf.Sortierzahl)                     .ToEnumerableAsync()                     .ConfigureAwait(false);
That query works fine.

@ericbrunner Did you try @dhei comment to use == instead?  The where clauses are parsed, and not all functions are available, so that may just make the difference.

@adrianhall yes, works

Ok.  I can see why it doesn't work.  We parse the Where clauses and there is only a subset of functions.  Because we support ==, we don't support .Equals().


Port remains bound

Problem:
A port remains bound after a type which binds to a port is dropped. For example, in the following modified echo server code, the second server start fails:
    let mut server = Server::builder()
        .with_tls((CERT_PEM, KEY_PEM))?
        .with_io("<IP_ADDRESS>:4433")?
        .start()?;

    drop(server);

    let mut server = Server::builder()
        .with_tls((CERT_PEM, KEY_PEM))?
        .with_io("<IP_ADDRESS>:4433")?
        .start()?;

This is mostly wanted to be able to benchmark different server configurations.
Solution:
Not sure what the solution is other than perhaps a Drop impl for some inner type responsible for binding to the port.
Requirements / Acceptance Criteria:
Must be able to rebind to the same port after dropping a Server or Client type.

I'm assuming the issue here is the socket drop is an asynchronous action and the new server races to rebind to the same socket. The actual socket is sent to its own task and is notified that the endpoint is shutting down and that kicks in its own shutdown logic.
To confirm this: does the issue go away if you put a short sleep after the drop(server)?


Describe property hibernate.vertx.pool.class in the documentation

We should add it to the 1.5.1. Tuning the Vert.x pool section for advance cases

Nevermind, it's already described in a different paragraph of the documentation


DRAFT: [Code health] Use maps to represent Firestore data

...in place of relying on Firestore to read/write fields from POJOs. Key benefits:

Removes duplicate representation of field names needed when building Maps for partial data updates and merges (i.e., mutations).
Allows more control over failure behaviors, e.g., when database types don't correspond to expected ones.

In the process, we also introduce more carefully separated concerns regarding converters, data contains, and database schema definition.
Based on #327, contributes to #144 and sets us up for non-breaking db migration #142.
Depends on #335.

@scolsen @shobhitagarwal1612 I've only just begun migrating existing classes to this model and I can see there's a lot of boilerplate and additional conversion logic needed; considering that we'll only be mutating specific fields in the db (and therefore don't need parity with read+write of all objects), and since Firestore does a lot of the type conversions for us, wondering if I should abandon this approach. Anything thoughts before I switch tacks?

Here's an example of the alternative: https://github.com/google/ground-android/pull/350/files

Abandoned in favor of recent refactors.


Fix #564 Add "links" element to work item link / type / category

Adds "links" element to:

work item link categories
work item link types
work item links

Current coverage is 68.85% (diff: 66.66%)

Merging #587 into master will increase coverage by 0.02%

@@             master       #587   diff @@
==========================================
  Files            71         71
  Lines          4011       4046    +35
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2761       2786    +25
- Misses          981        987     +6
- Partials        269        273     +4

Powered by Codecov. Last update 01e7c7d...8bcf799


patch: Clarify variant for increasing size of persistent logs store

A user reached out to us informing that logs size increase does work in production: https://github.com/balena-io/docs/pull/2263#issuecomment-1470809925
In this PR, I removed the variant clarification and added a gentle warning for folks changing their configurations.
Signed-off-by: Vipul Gupta (@vipulgupta2048) <EMAIL_ADDRESS>

Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

@balena-ci I self-certify!


Allow for the creation of dummy TpuDevices in a CPU environment

In a TPU environment, Jax currently provides a lot of useful information for distributed computing via the TpuDevice class; e.g.
TpuDevice(id=0, host=0, coords=(0,0,0), core_on_chip=0)
All of these fields are useful information. Unfortunately it is difficult to develop code which uses them, since they are not available in a non-TPU environment set up by setting e.g.   os.environ["XLA_FLAGS"] = "--xla_force_host_platform_device_count=8" .
Would it be possible to create a means to assign the relevant information to such a spoofed environment?

It wouldn't make sense to do this in jax, since those fields lack meaning in non-TPU context, even with that XLA flag. Meanwhile, making a Python object with fields of your choosing seems like it ought to be straightforward to set up in your own code.
Please reopen if I've misunderstood the request!


Support for AZURE_CLIENT_ID/AZURE_CLIENT_SECRET with "az storage copy"

Is it possible to have az storage copy run as a service principal (i.e. with AZURE_TENANT_ID/AZURE_CLIENT_ID/AZURE_CLIENT_SECRET)?
We disallow "shared key authorization" as per Microsoft security recommendations.
We get the following error:
$ az login --service-principal --tenant=$AZURE_TENANT_ID --username=$AZURE_CLIENT_ID --password=$AZURE_CLIENT_SECRET
$ az storage copy --source-account-name=$ACCOUNT1 --source-container=$CON1 --account-name=$ACCOUNT2 --destination-container=$CON2 --recursive

...
There are no credentials provided in your command and environment, we will query for account key for your storage account.
It is recommended to provide --connection-string, --account-key or --sas-token in your command as credentials.

In addition, setting the corresponding environment variables can avoid inputting credentials in your command. Please use --help to get more information about environment variable usage.
...
Azcopy command: ['....azcopy', 'copy', 'https://....', '--recursive']
INFO: Scanning...
INFO: Failed to create one or more destination container(s). Your transfers may still succeed if the container already exists.
INFO: Any empty folders will not be processed, because source and/or destination doesn't have full folder support

failed to perform copy command due to error: cannot start job due to error: cannot list files due to reason -> github.com/Azure/azure-storage-blob-go/azblob.newStorageError, /home/vsts/go/pkg/mod/github.com/!azure/azure-storage-blob-go@v0.13.1-0.20210823171415-e7932f52ad61/azblob/zc_storage_error.go:42
===== RESPONSE ERROR (ServiceCode=KeyBasedAuthenticationNotPermitted) =====
Description=Key based authentication is not permitted on this storage account.
...

As per the az storage copy docs, only the following auth methods are supported: --account-key, --connection-string and --sas-token.
But connection strings are effectively based on account keys. And Service/Account SAS tokens can't be used in our scenario, since signing them with the shared access key is disallowed.

storage


switch to only supporting node versions greater than 12, update deps

Description
I couldn't update a lot of the deps because the newest versions only support ESM:

ex: https://github.com/TooTallNate/node-data-uri-to-buffer/releases/tag/4.0.0

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

would this technically be a breaking release? wdyt? @tmathern @pheenomenon

As we would cause breakage for anyone on node 10,  I would go with a breaking change.


RAF aligned effects

Resolves https://github.com/preactjs/signals/issues/315

Hah odd, React in production has different values than dev...

We could also apply the same notification delay to the prop updater and the text updater to limit their DOM mutation frequency to screen refresh.

@developit I'll follow up the changes to props/text separately


Wine Appellation

Definition: A set of rules from a governmental agency or wine trade association to designate a defined and commercially protected geographic area and any applicable rules such as allowed varieties of grapes, maximum grape yields, alcohol level, presence of bubbles, vintage rules, etc., that are required to be compliant with the appellation and use the appellation name on a wine bottle label or published information.
Data/Object properties (to be refined and defined):
Appellation name
Governing Organization
Appellation Code (AOC, AVA, DOC, etc)    ,  Appellation Code Name (Appellation of Controlled Origin, American Viticultural Area, Denominazione di Origine Controllata,  etc...)
Geographic Area --  Village, City, Sub-Country (state/province), River, Valley, Country
Facility  --   Facility owned by Company, Facility at Geographic Area, Facility subclasses (Chateau, Estate, Vineyard, Winery, Cellar, etc.)
Allowed varieties of grapes
minimum level of alcohol
maximum level of yields
vineyard planting density
minimum percent of grapes from the specified geographic area
age of vines
vintage rules
bubble size
wine style
vinification techniques
harvest techniques
harvest fruit maturity
wine classified status (Grand Cru, Premier Cru, Village, Petit, etc)

So the wine hackathon starts tomorrow - sadly in CET timezone for north americans.  I will report out on who is there in terms of focus - whether the hackathon focuses on characterizing organoleptic qualities of wine; or whether we also end up developing the upstream agricultural and vinification variables that drive organoleptic variety.

Very interested in learning what the “hackers” come up with!
Hope it is a good experience for all.
Diane

On Nov 7, 2021, at 5:45 PM, Damion Dooley @.***> wrote:

So the wine hackathon starts tomorrow - sadly in CET timezone for north americans. I will report out on who is there in terms of focus - whether the hackathon focuses on characterizing organoleptic qualities of wine; or whether we also end up developing the upstream agricultural and vinification variables that drive organoleptic variety.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

...and how's the hacking going?
On Mon, Nov 8, 2021 at 5:56 AM Diane Alexander @.***>
wrote:

Very interested in learning what the “hackers” come up with!
Hope it is a good experience for all.
Diane

On Nov 7, 2021, at 5:45 PM, Damion Dooley @.***> wrote:

So the wine hackathon starts tomorrow - sadly in CET timezone for north
americans. I will report out on who is there in terms of focus - whether
the hackathon focuses on characterizing organoleptic qualities of wine; or
whether we also end up developing the upstream agricultural and
vinification variables that drive organoleptic variety.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FoodOntology/foodon/issues/162#issuecomment-963173137,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMZGI4W6TF3GEXTRZP746TUK7JKJANCNFSM5GHHFHXQ
.

Hey, its fun and a bit arduous at the same time since we don't have an integrated editor for ontologies that covers things like robot files and ontofox import files.  So a bit of shuffling around.  Main diagram work is happening at: https://drive.google.com/file/d/1-jHjnJ5njPggPh0MlhnrF51RZ9OFpYK2/view
I'm translating everything that has new ID's into FoodOn by way of robot process table, or by Wine ontology table.  The fermentation, and appellation section and "wine characteristics" phenotype sections (tabs in draw.io diagram above) are coming last because frankly they are the most complex, so slow pickings for progress, and require the most consultation which will have to extend well past end of this Hackathon tomorrow morning.  I'm thinking that FoodOn will have to take on all the wine composition tasting phenotypes rather than PATO but I will check in with them about that.  As well the main question is how far down into descriptive vocabulary words or phrases should we carry that section?  Here are a number of diagrams:

And FoodOn has been updated with many new wine-related terms!

🤓  😍  👏  🙌
On Thu, Nov 11, 2021 at 5:02 PM Damion Dooley @.***>
wrote:

And FoodOn has been updated with many new wine-related terms!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FoodOntology/foodon/issues/162#issuecomment-966735036,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMZGI5WBOKY7OPNQY6TVVDULRRTPANCNFSM5GHHFHXQ
.

New thoughts on the picture in [ddooley] commented [on Oct 18, 2021]:
Reverse the direction of the arrow from Wine Style to Wine Appellation
Wine Style(s) is optionally prescribed by Wine Appellation
Objects related to Wine Appellation that are changed to optional Data Properties of Wine Appellation
---  minimum percent alcohol
---  minimum age of vines
---  maximum level of grape berry yield
---  bubble size (pertains to sparklers only)  --?-investigate if a range for two data properties, minimum only?
---  maximum vineyard planting density
---  minimum percent of grapes from the specified geographic region
---  maximum percent of wine that can come from a year that is not the listed vintage year
Object properties to Wine Appellation
--  harvest technique
--  harvest fruit maturity
--  vinification technique

A few notes:

I didn't include cardinality in any of the relations but that is always an option.  One can say for any diagrammed ----> relation that it is 0 or more, with the default semantic being 1 or more. One can even say 3 or more, or max 3, etc. but reasoners often can't handle testing truth with those attributes.

About "Wine Style to Wine Appellation" I think I see your point - that for a wine style there isn't always an appellation, but for an appellation there is always a wine style? In which case the relation should be reversed.

A core tenet of OBO Foundry ontology design is to minimize and generalize object relations - basically to the Relations Ontology set + additions as needed.  And the second thrust is to have almost no data properties at all except for generic ones like "has quantity" and "has unit".  James Overton is currently working on a finalized OBI/COB/OBO sanctioned treatment of data which is almost ready for testing.  But basically instead of a particular data property relation we take the predicate and turn it into a type of datum, so "minimum age of vine at harvest" is a datum, a subclass of age datum, which is about some wine vintage.  As a pattern this enables process modelling in a way that data properties do not.  But I understand out in the RDF graph world people find it convenient to simply use equivalent data properties.  So I would steer FoodOn to stick with the minimal object properties and almost no data properties approach, but I see it is important for us to show the equivalency, i.e. to show a mapping to the kinds of properties you mention for those who want the simplification.  I can diagram a few examples if people want?

I see that the grey bubbles are for Information, that might be the equivalent to Data Properties, I think.
An Appellation does not always specify a particular Wine Style, but can have one or more Wine Style required in the Appellation Rule


There's a bug in Lib_MerkleTrie.sol

Did I introduce it? Or was it always there, and the write back had issues always.
It's the current cause of the CI failure.

Pulled the latest
https://github.com/geohot/cannon/commit/503544248cc29b2aaf3c42e86e1d48c37484e425
It's fixed...ish


Deployment error

Describe the bug
When I run deploy on my Windows 10 machine I get the following error:

I have removed my username and organisation tenant ID's
To Reproduce
Steps to reproduce the behavior:

Open PowerShell
Run .\Deploy

Expected behavior
Installation of the solution
Desktop (please complete the following information):

Windows 10 with latest update
Edge
Latest repo

Use the following command:
close all PS session Navigate to C:\Users\<User Name>\ .Azure delete "AzureRmContext.json" open PS session type Connect-AzAccount -UseDeviceAuthentication open a browser with the URL https://microsoft.com/devicelogin Enter the code displayed on screen
But having now this error:

Solved the issue;

created a new onmicrosoft.com account in the AAD with admin rights

Not using my MSDN subscription ID (that is also part of my AAD)


Make bens image name the same as release tag

I suggest to rename blockscout-ens directory to be bens instead of passing docker-context-path and dockerfile-path explicitly. In my opinion, this kind of flexibility is unnecessary as almost all services except blockscout-ens and multichain-search follows the same structure with service names being the same as directories. multichain-search is deprecated overall, so renaming blockscout-ens to bens will result in all services being the same

will rename blockscout-ens in next pr, for now merge it


PHP 8.1: Resolve deprecation notices in several classes

This PR
This is a follow-up to #205, in which I apparently missed a LOT of deprecations. The command I used to list them doesn't seem to work properly on my local system, using a fresh php8.1 docker imaged worked (thanks @alexgit2k)
This should resolve all compile-time deprecation errors up to php 8.1, without breaking compatibility with php7.1+. This time actually closing #189
Resolved issues
Added missing return types

Using Rector, added return types for: (collapsed)
FilterIterator::accept
RecursiveIterator::getChildren
RecursiveIterator::hasChildren
ReflectionClass::getInterfaces
ReflectionClass::getMethod
ReflectionClass::getMethods
ReflectionClass::getParentClass
ReflectionClass::getProperties
ReflectionClass::getProperty
ReflectionClass::getStartLine
ReflectionExtension::getClasses
ReflectionExtension::getFunctions
ReflectionFunctionAbstract::getParameters
ReflectionFunctionAbstract::getStartLine
ReflectionMethod::getDeclaringClass
ReflectionParameter::getClass
ReflectionParameter::getDeclaringClass
ReflectionParameter::getDeclaringFunction
ReflectionParameter::getType
ReflectionProperty::getDeclaringClass
ReflectionProperty::getDocComment
RecursiveFilterIterator::getChildren

Add __serialize and __unserialize to Serializable classes
Adds __serialize and __unserialize implementations (identical to existing)
for any classes implementing Serializable
Remove default values followed by mandatory arguments
See https://www.php.net/manual/en/functions.arguments.php:

As of PHP 8.0 declaring mandatory arguments after optional arguments is
deprecated. [...]

Make Command::helpCommand variadic
Made helpCommand() variadic in order to be compatible with the
call_user_func_array on line 191
this resolves:
Error: Unknown named parameter $argv
replace : void with ReturnTypeWillChange on SplPriorityQueue::next
Required because \Zend_EventManager_Filter_FilterIterator::next extends
SplPriorityQueue but returns a value

Fixes #189
CC @Shardj @alexgit2k @Hikariii

Great stuff

Can confirm that there is no single deprecation notice now! Thank you very much🥇
@Shardj Are there any plans for the next release?

Here you go @alexgit2k https://github.com/Shardj/zf1-future/releases/tag/release-1.21.0


failed to read file. invalid Json Token. line: 1 ch: 1

PLEASE HELP ME REEEEEEEEEEEEE

Where exactly do you get that? Screenshot if possible

ok i will send

well when i press "play" it appaears the error

Everything that happens after pressing that button is the matter of game process, not launcher


Context pass on in chain

Issue Description
Type: feature request
Describe what feature you want
In current hybridnet, context is not being passed on in chain, so usually a controller-runtime client is using a context.TODO() or context.Background() instead. This is non-standard. We should keep context awareness everywhere.
After that, if manager is shutting down, all client-related goroutines will get a context signal and quit immediately.
Additional context

This will break some code changes on

controller utilities
IPAMStore interface
...


Thrift is unreachable

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a GitHub issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 3: Describe the problem
https://git.apache.org/thrift.git/ is currently down, If your project is not building see https://github.com/census-instrumentation/opencensus-go/issues/1158
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Use https://github.com/jenkins-x/jx/pull/3321/files for a workaround.
@hiranya911 should I make a PR to replace this dependency location?
Relevant Code:
[0mgo<EMAIL_ADDRESS>unknown revision v0.12.0
go<EMAIL_ADDRESS>git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /go/pkg/mod/cache/vcs/83dba939f95a790e497d565fc4418400145a1a514f955fa052f662d56e920c3e: exit status 128:
	fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Operation timed out
go: error loading module requirements

I don't think this can be fixed in this repo. We don't have a direct dependency on OpenCensus or Thrift. But if you know of a fix, feel free to provide a PR.

From the dependency map it appears, it's firestore that depends on this. I will reach out to them.
firebase.google.com/go -> cloud.google.com/go/firestore-> cloud.google.com/go/firestore.test-> cloud.google.com/go/internal/testutil-> go.opencensus.io/trace-> go.opencensus.io/internal-> go.opencensus.io


Carousel variables

This changes the values to rems.
/CC @mdo @ysds

There is no problem changing px to rem.
But if we focus on the controllable by variable, I would do like this:
.carousel-caption {
  position: absolute;
  top: $carousel-caption-top;
  right: $carousel-caption-right;
  bottom: $carousel-caption-bottom;
  left: $carousel-caption-left;
  color: $carousel-caption-color;
  text-align: $carousel-caption-text-align;
}

$carousel-caption-top:               null !default;
$carousel-caption-right:             15% !default;
$carousel-caption-bottom:            2.5rem !default;
$carousel-caption-left:              15% !default;
$carousel-caption-color:             $white !default;
$carousel-caption-text-align:        center !default;

The top and bottom padding are no longer needed.

I've merged this for now and opened https://github.com/twbs/bootstrap/issues/29519 to further improve the indicator styles


Slider change value on scroll only when mouse hover

This prevent from scrolling with the mouse and changing slider when the mouse is not hovering the slider.
For example: If we have multiple slider in a tab if we changed value of a slider by clicking with the mouse and the hover another slider an scroll, the two would change values.
Here is an example with some before/after GIFs:

Hi @Leandro4002 sorry for the huge delay, but merged now :)
Thanks!


add required fields to request collection data

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix - in the past 24 hours, I noticed I Was receiving 400 "Invalid Input" from Notion during a background process which calls collection.getRows(). The only way I can get it to work now is by including some values for these fields. The 5000 is arbitrary, and not sure what the impact of passing an empty string for userTimeZone might be. Another option might be "UTC".

Thank you for the PR. I'll take it from here.


ISSUE-690: Allow users to disble server side caching

Fixes #690

@akatona84: Addressed your review comments.

I had to dig around a bit to understand what exactly you are disabling. I am slightly confused with the changes.

The code to invalidate the cache in DefaultSchemaRegistry is already commented out. I dont see any calls inflow into HAServerNotificationManager.notify*. It looks the caching is already disabled.

What's the purpose of this change? Is it only avoid to db calls to fetch other instances info?

@guruchai : Caching was not disabled in MASTER. We raised a PR to disable it in CSP-3.0.0, with this change server side cache disabling is configuration from yaml.

lgtm..


institution_id registration of FIO-SOA

Edit information of FIO
institution_id = FIO-SOA
institution = First Institute of Oceanography, State Oceanic Administration, Qingdao 266061, China

@zhenyasong please review the update at CMIP6_institution_id.html and provide any additional tweaks if required


FancyZones does not have "apply" button

When selecting a new FancyZones layout I do not see the apply button anymore. I cannot change zones anymore. I can create and select new zones, but applying them is now impossible.

ℹ Computer information

PowerToys version: 0.31.2
PowerToy Utility: FancyZones
Running PowerToys as Admin: Yes
Windows build number: [run "winver"] Latest

Selecting a layout is actually applying it. In your example, the custom "3 Zones" layout is applied,

Hey Niels,
Thanks for the quick response. This morning somehow this didn't work for me.. after restart of windows it did. Unfortunately I cannot reproduce the issue.
But selecting an layout, and then having to press ESC or close the window, is not as intuitive as a "apply"  or "close" button. But that could be personal preference.
I love the software by the way... Keep up the good work!

@joe-vrolijk
we have an issue to allow double click to apply the layout and close the editor https://github.com/microsoft/PowerToys/issues/6098
The reason why we removed the apply button is because 30% of the users have multi monitors and the apply button is just a bad experience for that scenario.
For single monitor users, it's similar to the Windows Settings app, where there is no apply button and the selected option is immediately applied.

This is an issue. The same happened to me.
Powertoys version: 0.37.0

version 0.37.2
this happens to me as well. exiting power toy and restarting it seems to fix the issue. major annoyance.


Focus indication in breadcrumb is too weak and sticks around

Testing #54935

press cmd+shift+.
observe the weak focus indication
click in the editor
observe the weak focus indication persists until the breadcrumb is repainted

/duplicate of #54745


[Bug] IDX10501: Signature validation failed. Unable to match key:  kid: 'kWbkaa6qs8wsTnBwiiNYOhHbnAw'.  Number of keys in TokenValidationParameters: '10'.  Number of keys in Configuration: '0'.

Which version of Microsoft.IdentityModel are you using?
Service1 6.24 - 401 with IDX10501
Service2 6.32 - 401 with no error message
Where is the issue?

[ ] S.IM.Tokens.Jwt

Is this a new or an existing app?
The app is in production and I haven't upgraded Microsoft.IdentityModel.*, but started seeing this issue.
Repro
The configuration on our side is made based on https://learn.microsoft.com/en-us/aspnet/core/security/authorization/limitingidentitybyscheme?view=aspnetcore-6.0#use-multiple-authentication-schemes
services
    .AddAuthentication()
    .AddJwtBearer(AzureAdAuthenticationSchemes.JwtBearer, options =>
    {
        options.Authority = $"{settings.Instance}/{settings.TenantId}";
        options.TokenValidationParameters = new TokenValidationParameters
        {
            ValidateIssuer = true,
            ValidateAudience = true,
            ValidAudiences = settings.ValidAudiences,
            ValidateLifetime = true,
            ValidateIssuerSigningKey = true
        };
    });

The token is fetched via managed identity following https://learn.microsoft.com/en-us/entra/identity/managed-identities-azure-resources/how-to-use-vm-token#get-a-token-using-the-microsoftazureservicesappauthentication-library-for-net
Expected behavior
Signature validation keys are successfully obtained and token validated.
Actual behavior
After around 2 years of running with no issues, we recently (occurred on 31st of January, 2024) got an error:
401 on both of our services with an exception message on one of them (6.24):
IDX10501: Signature validation failed. Unable to match key:
kid: 'kWbkaa6qs8wsTnBwiiNYOhHbnAw'.
Number of keys in TokenValidationParameters: '10'.
Number of keys in Configuration: '0'.
Additional context / logs / screenshots / links to code
Checking at this moment there is this specific key (kWbkaa6qs8wsTnBwiiNYOhHbnAw) in https://login.microsoftonline.com/common/discovery/keys as well as in https://login.microsoftonline.com/{our-tenant}/discovery/v2.0/keys
So there are 2 assumptions from me, both of them based on new signature signing keys rollover:

Some code issue with refreshing the keys (is it possible?)
Surfing through the source code I didn't notice any caching stuff, but when we restart our services - the issue disappears.
The keys were regenerated, and when the token was signed the new key was used, but at the moment of validating the open-id discovery/keys were not yet updated with new keys. Is it possible?

** Stack trace **
Microsoft.IdentityModel.Tokens.SecurityTokenSignatureKeyNotFoundException:
at Microsoft.IdentityModel.Tokens.InternalValidators.ValidateLifetimeAndIssuerAfterSignatureNotValidatedJwt (Microsoft.IdentityModel.Tokens, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateSignature (System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateSignatureAndIssuerSecurityKey (System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateJWS (System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateToken (System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
at Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler+d__6.MoveNext (Microsoft.AspNetCore.Authentication.JwtBearer, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60)

@danyltsiv closing as it looks like an asp.net issue.
Did you set Options.RefreshOnIssuerKeyNotFound to true?


Input text in tooltip seems to be disabled

I tried to create a tooltip with an input text :
$('#click').tooltipster({
		content  : $('\
			<div class="eventTooltip">\
				<input type="text" />\
			</div>\
		'),
		contentAsHTML : true,
		animation     : 'slide',
		position      : 'bottom',
		autoClose : false
	});

When i try to click on the input it doesn't work.
Thanks for your help.

Read the documentation please => interactive option.

It works, thank you !!

It works, thank you !


refactor(bindings/zig): add errors handler and module test

cc: @tisonkun @Xuanwo

Add Zig Error Handler
Split tests - BDD test with opendal module (sample use)

Merging...
As an under development binding I'd prefer unblock our contributors. Thank you @kassane!


Is it possible to add an executableTarget to the project so Mint can run it?

Neat project. Thanks for creating it!
Are you interested in adding an executableTarget product to this project besides just the plugin target? I ask because if there is an executableTarget added to the Package.swift of this project, then it can be executed via mint. Similar to how other popular Swift CLI tools such as soucery, swiftlint, swiftformat can be executed. I think that sounds handy to have.
Are you interested in this target being added to this project? Do you personally know how to add this? I am happy to help add it. I am not as experienced with executableTargets so I wanted to see if you had any tips to provide to kick-start the effort.
Thanks for the time.

Hi @levibostian 👋
Thanks for the feedback and suggestion! Adding an executableTarget for mint sounds like a great idea. I'm open to it and would appreciate your help to get this implemented. While I am familiar with creating an executableTarget, the implementation challenge is finding a suitable replacement for the PackagePlugin.PluginContext since it's only available via .plugin(). Without a replacement for PackagePlugin.PluginContext, I don't know how we would invoke the lefthook binary and pass it parameters from an executableTarget.
Let me know what ideas you might have for solving this 🙂

Thanks for the reply and for interest in the feature!
As far as creating an executable target, I recall seeing some simple examples online for calling a binary and passing arguments.
How a plugin type makes this more complex, I'm not sure yet.
I'm working on this in my free time so I'll look into this when I get a chance ☺

Well, I got it to work, but it might not have been the "correct" way to do it 🤣.
 You should see "1.6.10" get printed.
mint run levibostian/lefthook-plugin@exec-target install. You should see lefthook install git hooks and generate a config file in the current directory.
If you see the code I wrote in the branch, the executable target created runs the command swift package plugin lefthook, essentially just running the plugin target.
Originally, I tried to create an executable target that could call the lefthook binaries directly but I was not able to get that to work. If I knew more about artifact bundles, maybe I could have gotten it to work.
What do you think about this solution? If you don't mind it, I am happy to clean the code up a little bit and make a PR from my work.

It's a good start and the kind of workaround I was hoping for! 👏  I think there is one scenario to be addressed before creating a PR.
The solution works well when a developer has already added the lefthook-plugin package to their manifest file, but if they don't explicitly take that step, they'll get this error:
mint run levibostian/lefthook-plugin@exec-target version
error: Unknown subcommand or plugin name ‘lefthook’
Usage: swift package <options> <subcommand>
  See 'package -help' for more information.

I am hoping to use your implementation for a private project because it uses mint heavily behind the scenes. Unfortunately, the project is restricted from adopting plugins (at least in the near future).
Let me know what your thoughts are 😁

Originally, I tried to create an executable target that could call the lefthook binaries directly but I was not able to get that to work. If I knew more about artifact bundles, maybe I could have gotten it to work.

No worries about the artifact bundles, this repository was my first attempt at using them and I spent a lot of time re-reading the artifact bundle proposal to wrap my head around the concept.
I originally tried bringing lefthook to Swift using a XCFramework but abandoned the approach because my solution had too much overhead to build the XCFramework (which was created from underlying GO code) on every upstream release.

The solution works well when a developer has already added the lefthook-plugin package to their manifest file, but if they don't explicitly take that step, they'll get this error:

Ah, great catch. I was running the mint commands from my fork so that's why I was not getting the errors. When I run them from a different project, indeed, I get that error. I agree, this needs to be addressed.
I think we have 2 options.

From the proposal you linked to (great resource, thank you), SPM processes the artifactbundle.zip file and provides the super handy context.tool() API to get the binary path for the platform they are running on. But, this is only available for plugins... I wonder if by browsing the API docs for Plugins, maybe there is a class or function that can be called from an executable target to get access to these great functions?

I suppose, doing what SPM does manually is also an option. Manually unzipping an artifact bundle, parsing the manifest file to determine what binary target you need, and then manually running the binary target could work. It just seems like we're manually doing the work that SPM does for you.

Side note, Thinking about this solution idea, if it was implemented, it could be worth pitching the solution to Mint to add support to run binaryTargets directly 🤔.

I have built similar tools like this in the past where the solution I took was to download the binary directly from github releases at runtime and then execute the downloaded binary. However, because of apple code signing, you need to manually allow running the downloaded unsigned binary before it's run. It seems that if you package an artifactbundle, this is not the case. So, I like these 2 solutions more to skip this code signing hurdle.
If you have other ideas, would love to hear them!

I wonder if by browsing the API docs for Plugins, maybe there is a class or function that can be called from an executable target to get access to these great functions?

I keep coming back to this option but each time end up empty handed. Ideally, this would be the preferable approach.

I suppose, doing what SPM does manually is also an option. Manually unzipping an artifact bundle, parsing the manifest file to determine what binary target you need, and then manually running the binary target could work. It just seems like we're manually doing the work that SPM does for you.

I am leaning towards this solution because it could re-using the existing SPM code that implements artifact bundle handling. There might even be a way to utilize the artifacts folder (e.g. .build/artifacts/lefthook-plugin/lefthook/) that SPM uses to execute the binaries currently reserved for plugins.

I read the SPM source code and duplicated the logic to create a quick solution (Code isn't cleaned up and ready for a PR, just good enough for testing it).
If I run swift run lefthook-executable version from my lefthook-plugin directory, it works as expected.
If I run mint run --verbose levibostian/lefthook-plugin@734d3ffc3785f60d40f77f450c9c6c01e78b45bd version, it doesn't work as expected. I think it's because if you look closely at the verbose mint output, you will notice towards the end that mint copies the compiled binary into your ~/.mint directory. If I browse to that directory on my machine, there is no .build/.... directory anymore next to the binary.
We need to find another way to get an artifact bundle to parse. I have a few ideas:

If the executable target can have the binary target as a dependency, Swift gives our executable target access to the artifact bundle somehow? Maybe via Bundle? This is my preferred solution but not sure how to do this.
The executable target downloads the artifact.zip from github release at runtime.
The executable target has the artifact.zip file packaged as a local reference and committed to git. I have gotten this to work already for testing purposes, but it's not ideal that we need to commit a .zip file with each github release.

Mint says it still supports the Package.resources file (this repository uses a Package.resources for mint). This might a reasonable solution for mint even though defining resources directly in spm would be more ideal because I agree would shouldn't be committing a zip to the repository for each release.
The only other solution I can think of (without resorting to network download) is adding a new pre-build plugin target that only has one dependency (the existing binaryTarget). The pre-build plugin just makes sure spm triggers .build/artifacts/lefthook-plugin/lefthook/ so we can define a valid .copy(path:".build/artifacts/lefthook-plugin/lefthook/") on the executableTarget but the time mint run swift build.
This isn't a complete test but spm didn't raise an error when I referenced a resource that did not exist yet:
        .executableTarget(
            name: "test",
            resources: [
                .copy("../../.build/artifacts/lefthook-plugin/lefthook/")
            ]
        ),

Ah, I didn't consider those ideas. Thanks for sharing.
I am not sure either of those solutions will be reliable? When I run the command: mint run --verbose levibostian/lefthook-plugin@734d3ffc3785f60d40f77f450c9c6c01e78b45bd version and view the output, it doesn't look like SPM is compiling the lefthook-plugin target.  Have you found a reliable way to make sure this directory is always made?
Although I'm not yet sure that the .build/artifacts/ directory is always made, looking at the output though, binary artifacts are always downloaded:
🌱 Cloning lefthook-plugin 734d3ffc3785f60d40f77f450c9c6c01e78b45bd
Cloning into 'github.com_levibostian_lefthook-plugin'...
remote: Enumerating objects: 111, done.
remote: Counting objects: 100% (94/94), done.
remote: Compressing objects: 100% (64/64), done.
remote: Total 111 (delta 50), reused 63 (delta 25), pack-reused 17
Receiving objects: 100% (111/111), 20.43 KiB | 1.36 MiB/s, done.
Resolving deltas: 100% (53/53), done.
Note: switching to '734d3ffc3785f60d40f77f450c9c6c01e78b45bd'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 734d3ff Create target by directly calling artifact bundle binaries
🌱 Resolving package
Fetching binary artifact https://github.com/csjones/lefthook-plugin/releases/download/1.6.10/lefthook.artifactbundle.zip from cache
Fetched https://github.com/csjones/lefthook-plugin/releases/download/1.6.10/lefthook.artifactbundle.zip from cache (0.73s)
🌱 Building product lefthook-executable
Building for production...
[5/5] Linking lefthook-executable
Build complete! (5.44s)
Copying /var/folders/1w/h6spj5_s3zv661x7jtk3kzvc0000gn/T/mint/github.com_levibostian_lefthook-plugin/.build/release/lefthook-executable to /Users/levibostian/.mint/packages/github.com_levibostian_lefthook-plugin/build/734d3ffc3785f60d40f77f450c9c6c01e78b45bd/lefthook-executable
🌱 Installed lefthook-plugin 734d3ffc3785f60d40f77f450c9c6c01e78b45bd
🌱 Running lefthook-executable 734d3ffc3785f60d40f77f450c9c6c01e78b45bd...
Illegal instruction: 4

So I wondered if we could take advantage of the fact that SPM will always download the binaryTarget for us to the local file system. See if we can read that downloaded artifact bundle.
Looking at the source for this artifacts cache, it looks like ~/.swiftpm is a reliable way to find downloaded artifacts.
We could have logic at runtime for the executable that does these steps:

Iterate all files in directory ~/.swiftpm/cache/artifacts/.
Calculate the sha256sum of each file in this directory. When you find a checksum that matches the checksum of the binaryTarget, you found the downloaded artifact.
unzip the downloaded artifact somewhere (/tmp/? ~/Application support/?).
Luckily, when you look at the unzipped contents (see screenshot), it's identical to what's in .build/artifacts/lefthook-plugin/. So we can re-use the logic in this commit to find the correct binary file and execute it.

If we are not able to make sure that .build/artifacts/lefthook-plugin/ gets created when you run mint run..., the steps above seem like a nice workaround.

The ~/.swiftpm/cache/artifacts/ seems like a pretty good approach and might be the one we should use. If you think this implementation will make more sense, I'd encourage you to pursue it.
I started testing a pre-build plugin and could reliably generate the .build/artifacts/lefthook-plugin/lefthook/ directory before the executable is built using the swift build command. Unfortunately, don't have the same success using mint (seems like mint clears the artifacts directory which undoes the pre-build plugin work...) therefore this approach still needs additional solutions to things but would reduce the amount of bin handling code for running lefthook.

Could you share how your testing with mint and your pre-build plugin was not successful? I just ran a test and it is working for me.

Oh, my mistake. I can confirm it works with mint too 🎉 When I was browsing from terminal I thought the lefthook directory under github.com_csjones_lefthook-plugin was a binary without actually checking because I was expecting to just see lefthook-plugin. Thank you for double checking! 😄
I will open a PR with the PreBuildPlugin branch and add a github action. Do you think the github action should be similar to the existing ones or maybe instead use the mint action?

Thanks for making a PR! I'm happy to build off your branch by adding the code I wrote to execute the binary. Combine our two efforts and I think we have this thing built! It's been great working on this with you. Thanks a lot for the collaboration.
The setup-mint action you mention is great. I think we only need to use part of its features but we would still benefit from it installing the mint binary.
To test mint compatibility on ci, I was imagining something simple. A workflow containing these steps:

don't run actions/checkout to avoid false positive test results.
setup-mint, disable bootstrap. Just install the mint binary.
run mint run ${{ github.repo_slug}}@${{ github.ref}} --help. To have mint try to run this specific commit pushed to the ci.

Check the output from the mint command to assert it contains a certain string from lefthook help. To test it actually ran a real lefthook command.
That's about it. If you have a better idea, go for it.

Typing this on my phone. Hope this makes sense.

Thank you 😊 I appreciated the your work and feedback with this feature. Your collaboration helped a lot and I think we are arriving at great solution given the constraints.
I've opened the PR and incorporated the action based on your suggestions https://github.com/csjones/lefthook-plugin/pull/3

PR opened 🎉 https://github.com/csjones/lefthook-plugin/pull/4


add mixpanel tracking code

What is this PR trying to achieve?
We were talking, and I do wonder about Google Analytics.
Looking at Google Optimize too, it is a marketing platform.
I have used Mixpanel before, and it's great as it's very user focussed, and given our audience and also traffic, this could be more valuable.
More over they offer A/B testing, but in a more programmatic fashion, where is Optimize is a pointy, clicky, make magic solution.
We can test it, if we don't like, we can remove it. No hassle, no fuss.
https://mixpanel.com

Who A/B tests the A/B tests?
Don't answer that.


External image support

Congrats on launching jampack! It's an absolute game-changer in automating a lot of tedious performance optimizations. I'm a big fan.
The one issue preventing me from using this more is support for external images.
Currently, jampack will add decoding="async" loading="lazy" to an externally referenced image which is an excellent start. I'd love a CLI option to process external images further.
At a minimum, I'm looking to add missing width/height attributes without touching the src. Even better (or as an option) is downloading the external image, processing it, and changing the src to serve it locally.
Would you happen to have any thoughts about this?

Hi!
Thank for the kind words :)

add missing width/height attributes without touching the src.
I think I can do that and it exist libs to do that without downloading the entire images... I'm adding that to my bucket list 👍

downloading the external image, processing it, and changing the src to serve it locally.
Out of curiosity, why would you do that? Is that because images are served from a CMS and can't be responsive?

Great stuff!
Downloading the image and serving it locally isn't a huge blocker honestly, it would be nice to have the option though. The use case is we try to keep assets out of our repositories so they're lean. It leads us to storing assets on something like Cloudinary or S3. When the site builds, I'm ok with them pulling in at that point, especially if I know I can improve the performance with jampack, just as long as they're not in the repo.
Hope that makes sense.

Great work on Jampack indeed!
For me too adding width and heights to external images would be very useful too. This would prevent cumulative layout shift (CLS).
And I would also love the feature of > downloading external image > save locally > create sizes with srcset. This would allow me to have responsive external images.

Understood loud and clear and I'm excited to implement it soon 💪

In the meantime I created a little script to save external images locally.
Why I did this: I want the script to also update the original image url (which lives in a .md file in my Astro content collection, in my case), so that it is permanent and the local file is used for each subsequent build.
I assumed Jampack would probably never do this, since it runs AFTER the build and only on the dist folder.
Anyway, here is my script:
// --------------------------
// A little script to save all external images locally and update the markdown files
// --------------------------

import { promises as fsPromises } from 'fs'
import fs from 'fs'
import glob from 'glob'
import crypto from 'crypto'

const MARKDOWN_FILES = glob.sync('./src/content/**/*.md')
const FILE_EXTENSIONS = ['jpg', 'jpeg', 'png', 'webp', 'avif', 'svg']
const PUBLIC_OUTPUT_DIR = 'remote-image-cache'

// Get markdown content as string
function getMarkdownContent(filePath) {
  return fs.readFileSync(filePath, 'utf-8')
}

// Check if url has a file extension sepcified in FILE_EXTENSIONS
function hasFileExtension(url) {
  return FILE_EXTENSIONS.some((extension) =>
    url.toLowerCase().includes(`.${extension.toLowerCase()}`)
  )
}

// Get file extension from url
function getFileExtension(url) {
  return FILE_EXTENSIONS.find((extension) =>
    url.toLowerCase().includes(`.${extension.toLowerCase()}`)
  )
}

// Extract all external urls from markdown content
function extractImageUrls(contentString) {
  const regex = /(https?:\/\/[^\s]+)/g
  const matches = contentString.matchAll(regex)
  const urls = [...matches].map((match) => match[1])
  const imageUrls = urls.filter((url) => hasFileExtension(url))
  return imageUrls
}

// Download image from url and save to local filesystem
async function downloadImage(url) {
  const extension = getFileExtension(url)
  const randomString = crypto.randomBytes(16).toString('hex')
  const filename = `${randomString}.${extension}`
  const outputPath = `./public/${PUBLIC_OUTPUT_DIR}/${filename}`

  const response = await fetch(url)
  const blob = await response.blob()
  const arrayBuffer = await blob.arrayBuffer()
  const buffer = Buffer.from(arrayBuffer)

  await fsPromises.writeFile(outputPath, buffer)
  return `/${PUBLIC_OUTPUT_DIR}/${filename}`
}

// Get markdown content, extract image urls, download images and update markdown content
async function runAll(filePath) {
  const content = getMarkdownContent(filePath)
  const urls = extractImageUrls(content)
  let newContent = content
  for (const url of urls) {
    const newUrl = await downloadImage(url)
    newContent = newContent.replace(url, newUrl)
  }
  fs.writeFileSync(filePath, newContent)
}

// Run script for all markdown files
MARKDOWN_FILES.forEach((filePath) => {
  runAll(filePath)
})

Any tips on how to improve would be more than welcome, I might publish it as an Astro integration later.

@silveltman @mneumegen A first version of the external image support has been release : v0.12.0
It's off by default but you can active it with a config file.
You can read more about it here: https://jampack.divriots.com/devlog/external-images/
I made the extra mile in implementing an HTTP cache so images are not downloaded all the time.
For the moment, the cache is reset with every new version of jampack but I will improve that later.
There is problably some bugs. I would love to have your feedback if you can run it on your websites 🙏
Enjoy!

@mneumegen I looked at your website (very nice by the way) and you seem to use imgix as image CDN.
I thought I could implement a process option that would use the resizing capabilities of imgix instead downloading and resizing locally.
jampack would fill image dimensions and generate srcset with imgix urls.
It would tremendously reduce the processing time of jampack and you would get 99% of the benefits.
Let me know your thoughts.

@georges-gomes awesome work getting support for external image optimization added! I'm working on POC'ing a rewrite of one of my sites in Astro and I was having issues getting the astro-imagetools to parse external images in my Markdown.
I installed jampack and ran my build locally and it looks like it found, downloaded, and optimized the remote image! Unfortunately, because my Markdown file is nested under a posts directory, it looks like the relative path resolution isn't working quite right:
My jampack.config.mjs:
export default {
    image: {
        compress: true,
        external: {
            process: 'download'
        }
    },
};

The original, remote Markdown image located at src > pages > posts > this-is-a-test.md:
![A remote image](https://assets.bpwalters.com/images/bens_car_blog/wrx_replacement/model3.jpg)

The optimized result from jampack from dist > posts > this-is-a-test > index.html:

The jampack output throws  erro  Can't find img on disk src="/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg" since the _jampack image folder gets placed one level up at the root of dist.

Hi @bendrick92
Thanks for reporting. I also had this issue when the site is not served as root.
I will release a version with local _jampack folders until I find a clever way to do this in a single folder.

@bendrick92 please try version 0.12.2 - it creates multiple _jampack folders next to the .html pages.
It's not ideal but at least it's working.

@bendrick92

The jampack output throws  erro  Can't find img on disk src="/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg" since the _jampack image folder gets placed one level up at the root of dist.

This is maybe another bug actually.
In which folder to you run jampack?
If you run jampack ./dist the dist/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg should exist and be found.
There must be a bug somewhere.
If you can share more details on your setup, that would help.
Thanks 🙏

@bendrick92

The jampack output throws  erro  Can't find img on disk src="/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg" since the _jampack image folder gets placed one level up at the root of dist.

This is maybe another bug actually.
In which folder to you run jampack? If you run jampack ./dist the dist/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg should exist and be found. There must be a bug somewhere.
If you can share more details on your setup, that would help.
Thanks 🙏

For sure! I'm running a fork off of the astro-netlify-cms-starter repo.
I updated my package.json build command from "build": "astro build", to "build": "astro build && jampack ./dist",.
I can confirm the dist/_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg is generated, but because my posts collection gets compiled to a subdirectory, it looks like jampack is assuming the relative reference is one directory deep:

I was able to get the image to render if I changed the relative path to "../../_jampack/e0a3fe918067c2a86fa60222a7bf400b.jpg"
Hopefully I'm not missing something in the configuration?

@mneumegen I looked at your website (very nice by the way) and you seem to use imgix as image CDN.
I thought I could implement a process option that would use the resizing capabilities of imgix instead downloading and resizing locally.
jampack would fill image dimensions and generate srcset with imgix urls.
It would tremendously reduce the processing time of jampack and you would get 99% of the benefits.
Let me know your thoughts.

I would really like this feature for Cloudinary, since it is first-class supported by the CMS I use (which, believe it or not, is actually @mneumegen 's Cloudcannon haha. Amazon product and company!)
Also, I'll give the new feature a try this week and report any problems I might encounter

@bendrick92 Thanks for the details!
If you try version 0.12.2, it's fixed 👍

@bendrick92 Thanks for the details!
If you try version 0.12.2, it's fixed 👍

Fantastic! Thank you for the quick fix, you rock! I’ll try it out and report back if I have any issues.

@mneumegen I looked at your website (very nice by the way) and you seem to use imgix as image CDN.
I thought I could implement a process option that would use the resizing capabilities of imgix instead downloading and resizing locally.
jampack would fill image dimensions and generate srcset with imgix urls.
It would tremendously reduce the processing time of jampack and you would get 99% of the benefits.
Let me know your thoughts.

I would really like this feature for Cloudinary, since it is first-class supported by the CMS I use (which, believe it or not, is actually @mneumegen 's Cloudcannon haha (amazing product and company!))
Also, I'll give the new feature a try this week and report any problems I might encounter

Yes, I will try to make it work with for a number of CDN images. First 2 will be Cloudinary and Imgix 👍

@muryoh has added support for image CDNs.
Currently very little documentation.
You can enable it:
image: {
    cdn: {
      process:
        | 'off' //default
        | 'optimize';
      src_include: RegExp;
      src_exclude: RegExp | null;
    };

This will detect urls that uses an image CDN. Currently supporting:
Adobe Dynamic Media (Scene7)
Builder.io
Bunny.net
Cloudflare
Contentful
Cloudinary
Directus
Imgix, including Unsplash, DatoCMS, Sanity and Prismic
Kontent.ai
Shopify
Storyblok
Vercel / Next.js
WordPress.com and Jetpack Site Accelerator
(thanks to unpic js library)
A few limitations for the moment:

width and height values need to be in  tag
you can't have a custom domain to your images because it uses the url to detect the CDN provider

I don't know if these limitations are showstopper for you @mneumegen @silveltman
Let me know, you can improve it.
Cheers

This seems to be supported in the most part. We will open more issues if needed


Default initial values for settings

Hi, How can I specify default initial values for settings so that when a user looks at them before they have been set manually, they see the default values?

Simply write a migration which insert records into the settings table

Hi! Yes, @mstaack is correct. If you truly want default values, you should insert them to your settings table. There's no good optimized way to do that otherwise. If I wanted to make ->default() work that way, the settings package would have query the settings from the database on each startup and then insert them if they're missing. That's a lot of useless queries. It's easier to just migrate them into the database and it'll be done.


Building docs with mdz fails due to broken import of base64 in spork/init.janet

Attempting to run mdz build in the project root produces this error:
error: could not find module ./base64:
    spork/base64.jimage
    spork/base64.janet
    spork/base64/init.janet
    spork/base64.so
  in require-1 [boot.janet] on line 3017, column 20
  in import* [boot.janet] on line 3061, column 15
  in thunk [spork/init.janet] (tail call) on line 4, column 1
  in dofile [boot.janet] (tail call) on line 2992, column 7
  in source-loader [boot.janet] on line 3004, column 15
  in require-1 [boot.janet] (tail call) on line 3028, column 18
  in api-index [/usr/local/lib/janet/mendoza/markup-env.janet] on line 189, column 33
  in thunk [eval] (tail call) on line -1, column -1
  in do-contents [/usr/local/lib/janet/mendoza/markup.janet] on line 165, column 26
  in markup [/usr/local/lib/janet/mendoza/markup.janet] on line 172, column 3
  in with-dyns [/usr/local/lib/janet/mendoza/markup.janet] on line 183, column 51
  in <anonymous> [/usr/local/lib/janet/mendoza/markup.janet] on line 182, column 41
  in require-1 [boot.janet] (tail call) on line 3028, column 18
  in read-pages [/usr/local/lib/janet/mendoza/init.janet] on line 127, column 25
  in read-pages [/usr/local/lib/janet/mendoza/init.janet] on line 124, column 20
  in build [/usr/local/lib/janet/mendoza/init.janet] (tail call) on line 132, column 3

This seems to be fixed by removing the relative import of the base64 module in spork/init.janet and replacing it with a native import:
diff --git a/spork/init.janet b/spork/init.janet
index d07b4e9..7db4b64 100644
--- a/spork/init.janet
+++ b/spork/init.janet
@@ -1,7 +1,6 @@
 # make (use spork) useful

 (import ./argparse :export true)
-(import ./base64 :export true)
 (import ./cron :export true)
 (import ./ev-utils :export true)
 (import ./fmt :export true)
@@ -33,3 +32,4 @@
 (import spork/tarray :export true)
 (import spork/utf8 :export true)
 (import spork/zip :export true)
+(import spork/base64 :export true)

Related discussion in #185 and #188 . This seems trivially fixable to me—is there a reason we haven't done so yet?

Don't have an answer to your question, but I tried changes similar to what you mentioned, and they seem to work here.

Fixed with #195


Add Lounge Gaming

This team is now under Kinguin, thought it was important to add them as they had some big appearances at events

before.

Not sure about this.
I think I'll keep it open but won't include it for now. If they re-surface
then I'll be sure to add them.
On Thu, Nov 24, 2016 at 10:48 PM wyizzle<EMAIL_ADDRESS>wrote:

This team is now under Kinguin, thought it was important to add them as
they had some big appearances at events
[image: lounge gaming]
https://cloud.githubusercontent.com/assets/18340066/20610322/addbbbe2-b24c-11e6-87e4-c4e2e6c7053a.png
before.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kokarn/csgo-data/issues/183, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABT29Deqma3ZclAAmm08Vxb7_kcfQ9GOks5rBgYzgaJpZM4K7-jl
.

Okay, I felt it was important to add them because of their history.


dynamically defined accessors don't mix well with rspec

Most/all of the models dynamically define accessors through Marathon::Base and the ACCESSORS constant. I think this is a bit of an anti-pattern; it doesn't save a lot of lines of code (in fact I think it adds some) I see now it's because the accessor is overloaded to reach into the info hash, didn't notice that before.
Dynamic definitions don't play nicely with rspec, though. Say I have the following in a spec:
instance_double(Marathon::DeploymentInfo, deploymentId: 'deployment-id')

Running that test yields:
Marathon::DeploymentInfo class does not implement the instance method: deploymentId

Would you be open to a PR that replaces dynamic definitions of attr_accessors with static ones, assuming there's a way to still have those attributes use the info hash?

Sure, I'm open to these kind of changes. I don't like the indirection very much my self anymore. ;)


check that db initialization was done properly

fix #10

Closing this one, see #10.

I understand why you wouldn't like this change, but it was necessary to work around the upstream issue for our CI environment. I'm fine with keeping our local hack in place until it's fixed upstream. Thanks for the help.


Use inline template to avoid bug "file not found ./overlay.component.…

Use inline template to have it in umd files.

Hi
Since this commit on JUN 20 all templates are inlined by the build process.
This is from the umd bundle:

I guess you probably rebased or something and it wasn't complete.

@troyanskiy I really don't understand why you insist.
This is a plunker for ngx-modialog version 3.0.3 (after JUN 20): http://embed.plnkr.co/2ppVYl517GI1Byv8vVbG/
As you can see it is working fine (and it's using the UMD bundles)
The image you pasted here shows UMD bundle from the file ngx-modialog.webpack.umd.js which is is not the UMD bundle being used, the actual UMD used is ngx-modialog.rollup.umd.js and this is set in the package.json file.
The webpack UMD bundle is there due to old setup but it's incorrect has a wrong setup and along with not inlining resources it also bundles external packages such as rxjs (due to improper setup).

Even with proper setup the rollup UMD is better in performance and size.


Feature/upload documentation

Closes #938
Proposed changes

add meteor-uploads packages
documentation tab for uploading Swagger documentation file

@apinf/developers please review

We should consider merging this after the 1.3 upgrade branch, since it depends on changes introduced in that branch.

Yep, and I am still working on this, just uploading to filesystem works currently. WIP

When running the code, I get the following error:
While selecting package versions:
   error: unknown package in top-level dependencies: npm-container

Add confirmation on success (e.g. s-alert)
Confirm with user before deleting file
Change button label/visibility when no file exists

Delete confirmation message: "Are you sure you want to delete the file "?
If no file name, simply keep the image beside the message.
another version: "You are about to delete a file. Are you sure?"
Keep focus on cancel button

S-alert message: Upload successful. Please check the Swagger UI to get the file URL.

Common pattern for progress bar: https://github.com/zhouzhuojie/meteor-nprogress

Combined to PR #967. Closing this PR


Installation is terribly hard on OSX, is it supported?

Just as an example:
conda install pytorch torchvision torchaudio cudatoolkit=11.0 -c pytorch -c conda-forge

Results in:
Collecting package metadata (current_repodata.json): done
Solving environment: unsuccessful initial attempt using frozen solve. Retrying with flexible solve.
Collecting package metadata (repodata.json): done
Solving environment: unsuccessful initial attempt using frozen solve. Retrying with flexible solve.

PackagesNotFoundError: The following packages are not available from current channels:

  - cudatoolkit=11.0

Current channels:

  - https://conda.anaconda.org/pytorch/osx-64
  - https://conda.anaconda.org/pytorch/noarch
  - https://conda.anaconda.org/conda-forge/osx-64
  - https://conda.anaconda.org/conda-forge/noarch
  - https://repo.anaconda.com/pkgs/main/osx-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/osx-64
  - https://repo.anaconda.com/pkgs/r/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.

Any easy workaround that could be stated within the readme?

Just as an example:
conda install pytorch torchvision torchaudio cudatoolkit=11.0 -c pytorch -c conda-forge

Results in:
Collecting package metadata (current_repodata.json): done
Solving environment: unsuccessful initial attempt using frozen solve. Retrying with flexible solve.
Collecting package metadata (repodata.json): done
Solving environment: unsuccessful initial attempt using frozen solve. Retrying with flexible solve.

PackagesNotFoundError: The following packages are not available from current channels:

  - cudatoolkit=11.0

Current channels:

  - https://conda.anaconda.org/pytorch/osx-64
  - https://conda.anaconda.org/pytorch/noarch
  - https://conda.anaconda.org/conda-forge/osx-64
  - https://conda.anaconda.org/conda-forge/noarch
  - https://repo.anaconda.com/pkgs/main/osx-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/osx-64
  - https://repo.anaconda.com/pkgs/r/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.

Any easy workaround that could be stated within the readme?

Thank you for your interest in this work. Instead of installing cudatoolkit=11.0, you can install it directly from the pytorch website (https://pytorch.org/get-started/locally).


Feat/add create update document data

Hey @sniner,
I've added some more file cabinet features to the library:

Get file cabinet fields as list
Get all documents and get each documents data fields
Create data entry in file cabinet
Update data fields of document
Delete document specific document
Added delete functionality to conn.py

If you have any suggestions or improvements let me know!
Best,
Patrick

Hi @patrick-cichon-gcx
These are great additions, thank you for your contribution to the project! Have you already tested them extensively?

Hey @sniner,
yes I just added some more code and return values for the functions to clarify how to use them. I also added some more documentation in the code and the README. In my tests everything worked well.
If you have any more suggestions let me know!

My problem with this PR is that the new functionality is not really pythonic. That is, it is not organized the way you would expect a Python library to be. For example: Why is get_file_cabinet_document_and_data() a method of Organization? It should be a method of FileCabinet and named get_document(), or even a simple FileCabinet.get() or [] implemented by __getitem__() might be a good solution. This would then look like this, for example (and this is only an example to clarify this, it would not be an accepted solution, because there is already existing code to retrieve a document):
class FileCabinet:
    ...

    def get_document(self, query:list=[]):
        dlg = self.search_dialog()

        document_object = {}
        for document in dlg.search(query):
            field_list = []

            for field in document.fields:
                document_fields = {}

                document_fields["field_id"] = field.id
                document_fields["content_type"] = field.content_type
                document_fields["name"] = field.name
                document_fields["value"] = field.value

                dt_fields = ["Stored on", "Modified on", "Last accessed on"]
                if any(field.name in dt_fields for item in dt_fields):
                    document_fields["value"] = datetime.strftime(field.value, '%Y-%m-%d %H:%M')
                else:
                    document_fields["value"] = field.value

                field_list.append(document_fields)

                document_object[document.document.id] = field_list

        return document_object

    def delete_document(self, query:list=[]):
        fc_id = self.id

        dlg = self.search_dialog()
        fc_search = dlg.search(query)
        if fc_search.count == 1:
            for result in fc_search:
                document_id = result.document.id
        elif fc_search.count < 1:
            log.warning('Delete search query returned no results, delete request will not be executed.')
            return False
        else:
            log.error('Delete search query returned more than 1 result, delete request can only be executed for one document. Please specify your search query.')
            return False

        headers = {
            "Content-Type": "application/json",
            "Accept": "application/json"
        }
        try:
            result = self.organization.conn.delete(f"{self.endpoints['filecabinets']}/{fc_id}/Documents/{document_id}", headers=headers)
        except Exception as e:
            log.error('Error creating document data in file cabinet: %s', e)
            return False
        return result

And then, please, please, please remove the print() calls and replace them with log.warning(), log.error(), or whatever corresponds to the appropriate level.
import logging

log = logging.getLogger(__name__)
...

My next question: in get_document() you search for documents matching a query: for document in dlg.search(query): and create a dict document_object. What happens if multiple documents match that query?
And the final question: What does Organization.get_file_cabinet_document_and_data() different than SearchResultItem.document()? And why does is not return a Document object but a dict? And btw: delete_document_from_file_cabinet() belongs to Document, not Organization, and should be named delete(). That would make the warning "Delete search query returned more than 1 result..." go away completely, because you method is conceptually at the wrong position (Organization instead of Document).
Sorry, I think this PR needs a major refactoring.

Hey @sniner,
thanks for the feedback. And of course, sorry I'll adjust the code according to your suggestions. I was kind of unsure regarding the placement of the functions. I'll rework the code and let you know when I'm finished.

Hey @sniner,
I did some refactoring. You can review the code and let me know what you think.
Changes made:

removed get_file_cabinet_document_and_data() function because functionality already existing
moved delete_document() to class document
cleaned up print statements
moved create_data_entry() to class FileCabinet
moved update_data_entry to class FileCabinet
Updated REDAME refs

Hey @sniner,
did you have a chance to review the changes to the PR yet?


Ramp up Concurrency

Is your feature request related to a problem? Please describe.
It would be nice to ramp up concurrency over a ramp up period that specified by the user.
Describe the solution you'd like
I want to be able to specify a ramp up period for concurrency that is evenly distributed over the specified ramp up period.  For example, if I want 500 concurrent requests ramping up over 500 seconds, ghz would start with 1 concurrent requests and would add 1 concurrent request every second until 500 concurrent requests are reached.
I would imagine this scenario would be used only with the duration option.  For example, the parameters of a test might be:
500 concurrent requests, ramped up over 250 seconds (+2/second), for a duration of 30min.
Describe alternatives you've considered
I don't think an alternative exists for this scenario in ghz (at least none that I could find).

Hello, thanks for creating this issue. Features similar to this has been requested in other issues as well. Recently created PR #235 contains work to allow for such functionality. Please see the notes in the PR for additional documentation and a link to download a pre-release binary. If you can, please test this out and provide feedback in the PR comments. Thanks!

@bojand I've been using the new beta and it's been working great for me.  thanks for putting that together.

Hello, 0.70.0 has been released.


Fixes automatic multipart header addition

Is there a reason why this is not merged?

Maybe a test would help?


Remove dynamic mac entry from fdb on endpoint deletion

Fixes #1768
Noticed this issue when debugging few test case failures in e2e test suite. This is likely to be the root cause for docker #33076 and the service access issue during container bring up reported in docker #30321
This PR implements a different approach to fix this issue. #1783 has an alternative approach, which could have a performance impact.
libnetwork IPAM recycles the IP address when a  task goes down on a node and brought up in another node. For remote tasks overlay network namespace has one static fdb entry programmed by the driver and one dynamic entry learned by the bridge from the data path when a packet is received from the remote container. The dynamic entry ages out after 300 seconds. If a task on a remote node goes down and gets scheduled on a node the dynamic fdb entry still remains. Unless the container generates some data traffic it won't be updated. This can lead to unpredictability in accessing the container; sometimes it will work pretty quickly if there is some traffic from the container and the mac entry gets updated. If the container is completely silent it can lead to upto 300 seconds of traffic loss.
Fix is to delete the dynamic fdb entry as well. But this doesn't work in some kernel versions because untagged fdb entries are assumed to be in default vlan 1. To address this, the default vlan for the bridge has to be set using the sysctl variable.
Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

Thanks @sanimej


Upgrade

I was able to upgrade module successfully with below command
Update-Module SharePointPnPPowerShell*
But after the upgrade now I see two versions of the module. Is that expected behavior?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b3240d3-6a7d-fc4b-62fd-d3a5375d8a4a
Version Independent ID: 561212df-4dab-92b7-b634-57d53d313c6f
Content: PnP PowerShell Overview
Content Source: sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
GitHub Login: @Techwriter40
Microsoft Alias: kirks

Same problem and I get this error.
PS C:\Windows\System32> get-help Set-PnPListItem -online
Name                              Category  Module                    Synopsis

Set-PnPListItem                   Cmdlet    SharePointPnPPowerShellO… Updates a list item
Set-PnPListItem                   Cmdlet    SharePointPnPPowerShellO… Updates a list item
Get-Help: Multiple Help topics were found. Use only one Help topic with the -Online option.

@officedocsbot assign @yogkumgit

I have the same question as ravick4u

Hello everyone
I need to kindly redirect you to open PnP cmdlets issues here a member of the PnP community will handle your request there.
Thank you!

@get-itips  Thank you very much for the contribution and sharing this explanation. @ravick4u
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Fix Tutorial Typos in Limit and Offset

s/Comamnd/Command/g

Thanks for the interest! These changes were included in https://github.com/tiangolo/sqlmodel/pull/22, so I'll close this one. But thanks for the interest! :cake:


Procedures created and accessed in different schemas

In a clean database, when ToroDb starts, creates procedures in torodb schema,

but when intances a FirstFreeDocId class the schema used is PUBLIC
	public FirstFreeDocId() {
		super("first_free_doc_id", com.torodb.torod.db.postgresql.meta.PublicSchema.PUBLIC, org.jooq.impl.SQLDataType.INTEGER);

		setReturnParameter(RETURN_VALUE);
		addInParameter(COL_SCHEMA);
	}

The log error is:
Caused by: java.lang.RuntimeException: org.jooq.exception.DataAccessException: SQL [{ ? = call "public"."reserve_doc_ids"(?, ?) }]; ERROR: no existe la función public.reserve_doc_ids(character varying, integer)
  Hint: Ninguna función coincide en el nombre y tipos de argumentos. Puede ser necesario agregar conversión explícita de tipos.

Are you sure you didn't modify your torodb sources? We want to create the procedures on torodb schema, but right now they are created on public schema. In fact, all SQL structures (procedures, types, casts) are created executing SQL scripts stored on torod/db-wrappers/postgresql/src/main/resources/sql. As you can see there, in both devel and master branch, no schema is used.

No, I didn't change any source. I just cloned the master branch, executed mvn package and started toroDb with the command:
java -jar torodb-0.22.1-jar-with-dependencies.jar -d mongodb -p 5433 -u torodb --ask-for-password

This issue has been fixed on 7182f1e


How to delete existed tensorflow variable?

Hello, I am using windows GPU tensorflow 1.0.
I use ipython notebook to build training model because I can reuse script easily. Sometimes I just want to modify one tensorflow variable, such as W1(shape=[3,3],name="W1") from a existed model. So I just modify the variable and run the model building script again. However, tensorflow add W1(shape=[5,5],name="W1_1")  variable to replace old variable W1. It makes some bugs when I continue the next work with W1. Could you tell me how to delete old variable "W1" and add new different variable named "W1"?

This questions is suited for StackOverflow which is monitored as well under TensorFlow tag.

as @Carmezim mentioned, these questions are better suited to stackoverflow, to make sure answers get better exposure for other people looking for the same, and to keep this list focused on things that need action of core developers


Sync the creator DID for NFTs

When syncing an NFT's puzzle, we should somehow lookup the creator DID on-chain.

Added in https://github.com/xch-dev/sage/pull/64


Move zuul to its own module.

fixes gh-2298

Codecov Report

Merging #2332 into 2.0.x will decrease coverage by 1.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            2.0.x    #2332      +/-   ##
==========================================
- Coverage   65.85%   64.71%   -1.14%
==========================================
  Files         201      201
  Lines        7400     7397       -3
  Branches      919      918       -1
==========================================
- Hits         4873     4787      -86
- Misses       2175     2259      +84
+ Partials      352      351       -1

Impacted Files
Coverage Δ

...ud/netflix/zuul/filters/CompositeRouteLocator.java
100% <ø> (ø)

...etflix/zuul/RibbonCommandFactoryConfiguration.java
78.26% <ø> (ø)

...cloud/netflix/zuul/filters/ProxyRequestHelper.java
90.47% <ø> (ø)

...tflix/zuul/filters/pre/ServletDetectionFilter.java
92.3% <ø> (ø)

...flix/zuul/filters/pre/Servlet30RequestWrapper.java
100% <ø> (ø)

.../filters/route/RestClientRibbonCommandFactory.java
60% <ø> (ø)

...ix/zuul/filters/route/SimpleHostRoutingFilter.java
89.54% <ø> (ø)

...loud/netflix/zuul/ZuulServerAutoConfiguration.java
89.47% <ø> (ø)

...l/filters/discovery/PatternServiceRouteMapper.java
92.85% <ø> (ø)

...tflix/zuul/filters/post/LocationRewriteFilter.java
89.09% <ø> (ø)

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91808bb...201b366. Read the comment docs.

@ryanjbaxter, can you give this a post merge review? Since it's 2.0.x we have time to make changes.

@spencergibb could moving RibbonCommandContext to a different package be considered a breaking change?  Looks like Sleuth uses that class.
Other than that this looks fine to me.

It is a breaking change. RibbonCommandContext has zuul specific references. If we can think of an idea to move it back, I'm ok with it.


flexzy

Hello mathscodes, I would like to fix the contribute button in the hero.jsx  and also the github repo because when you click on them, They are not responsive. thank you

https://github.com/mathcodes/contentfordevelopers/pull/162/commits/e6f479cd0d268df2962185ba3268d658733629f2

Great! Much appreciated. Please complete the first-time contributions found here as well!