error on installing, mac OS

Cannot install on MacOS due to that problem:
ImportError: dlopen(/Users/XXXXX/opt/anaconda3/lib/python3.9/site-packages/taglib.cpython-39-darwin.so, 0x0002): symbol not found in flat namespace (__ZN6TagLib10StringList6appendERKNS_6StringE)
Any idea on how to fix it? Thanks for your support!
mac os 12.6.5
M1

Sadly I myself have no way to check your issue, i do not own any device with mac os..
Searching your error, it is something related to taglib library. Can you check if the TagLib was installed properly and what version is it?

thanks for getting back!
i cloned the repo, torch was already installed, then used pip install -e .
seems like an error caused by taglib. I installed taglib v 1.13.1 using brew, and it suceeded. Using python 3.9.
Error is not resolved.
Someone sucessfully installed on Mac OS 12.6 M1?

If it'll help I can make a sort of mitigation for Mac os by disabling taglib and everything that depends on it. However this will break the functionality of storing metadata in your generations

this sounds like a great quick fix! Appreciate your support! For the first run, this downside would be ok. I will continue investigate on the taglib issue on mac on my side and post if I find a solution. Thank you!

I have uploaded a new version temporarily under the branch of mac-os-fix, check if it works for you and I will merge it into the main branch

Thank you!
tested, unfortunately the same issue:
Successfully installed audiocraft-0.0.2a2
(base) XXXXX audiocraft_plus-mac-os-fix % python app.py
Traceback (most recent call last):
File "/Users/XXXXXX/Documents/audiocraft_plus-mac-os-fix/app.py", line 29, in
import taglib
ImportError: dlopen(/Users/XXXXXXXX/opt/anaconda3/lib/python3.9/site-packages/taglib.cpython-39-darwin.so, 0x0002): symbol not found in flat namespace (__ZN6TagLib10StringList6appendERKNS_6StringE)
in the app.py file, there is also the 'import taglib' still implemented in line 29.
just tried the original audiocraft version, this runs, but what the gradio interface offers is way to limited, eg. no .wav export :)

is this a suitable version?
v2.0.0
https://github.com/supermihi/pytaglib
there is one breaking change announced for that version:
"breaking change: File.path is now a Path object"
see: https://pypi.org/project/pytaglib/

is this a suitable version?
v2.0.0 https://github.com/supermihi/pytaglib
there is one breaking change announced for that version: "breaking change: File.path is now a Path object" see: https://pypi.org/project/pytaglib/

Does that version work for you?

yes, it is working fine in general. but with this version installed, the audiocraft_pluss app is giving that error mentioned above. Sorry, I am not an expert in that field. If you can give me hints, what exactly I could test for you, please let me know.
btw.: studying your py script "app.py" helped me a lot of understanding general topics in that field. appreciate your work and effort!

I have updated the mac-os-fix branch, tell me if this time it works. I changed the version to be 2.0.0 for taglib

cmd refers to the mac terminal.
I built taglib / pytaglib from scratch for my system, works.
But still, the error is not resolved. I also tried a dedicated virtual env but also not succeeding.

cmd refers to the mac terminal.
I built taglib / pytaglib from scratch for my system, works. But still, the error is not resolved. I also tried a dedicated virtual env but also not succeeding.

did you run the terminal inside the audiocraft_plus folder?

yes...

In that case ill just make a separate branch supporting only mac. I updated the mac-os-fix branch once again, this time removing entirely taglib and all it's dependencies, check if it works for you

Great! Works perfectly well. Thank you!
I just had to out comment/delete lines 405 and 406 of your code:
#torch.cuda.empty_cache()
#torch.cuda.ipc_collect()

as the mac runs the process on CPU and trying to call the functions above crashes the process at that moment.

Great! Works perfectly well. Thank you!
I just had to out comment/delete lines 405 and 406 of your code:
#torch.cuda.empty_cache()
#torch.cuda.ipc_collect()

as the mac runs the process on CPU and trying to call the functions above crashes the process at that moment.

ill update the branch so that the future updates will not enable them again 👍

Great! Thank you for your work!!!


Model Save&Load&Test

How can I model save, model load and model test for one image?
PATH = '/home/agteks/Desktop/ind_knn_ad/model.pt'
model = PatchCore(f_coreset= .01, backbone_name= "efficientnet_b0", coreset_eps= .95)
model.load_state_dict(torch.load('/home/agteks/Desktop/ind_knn_ad/model.pt'))
model.eval()
model = model.to('cuda')
#sample, *_ = test_dataset[st.session_state.test_idx]
pil_img = Image.open("/home/agteks/Desktop/ind_knn_ad/datasets/fabric_4/test/broken_large/Cropped_2_276_46_768.png")
pil_img = pil_img.resize((224, 224))
pil_to_tensor = transforms.ToTensor()(pil_img).unsqueeze_(0)
img_lvl_anom_score, pxl_lvl_anom_score = model.predict(pil_to_tensor)
score_range = pxl_lvl_anom_score.min(), pxl_lvl_anom_score.max()
show_pred(pil_to_tensor, img_lvl_anom_score, pxl_lvl_anom_score)
-- This code not working. Please help me :(

How can I model save, model load and model test for one image?
PATH = '/home/agteks/Desktop/ind_knn_ad/model.pt' model = PatchCore(f_coreset= .01, backbone_name= "efficientnet_b0", coreset_eps= .95)
model.load_state_dict(torch.load('/home/agteks/Desktop/ind_knn_ad/model.pt')) model.eval() model = model.to('cuda')
#sample, *_ = test_dataset[st.session_state.test_idx] pil_img = Image.open("/home/agteks/Desktop/ind_knn_ad/datasets/fabric_4/test/broken_large/Cropped_2_276_46_768.png") pil_img = pil_img.resize((224, 224)) pil_to_tensor = transforms.ToTensor()(pil_img).unsqueeze_(0) img_lvl_anom_score, pxl_lvl_anom_score = model.predict(pil_to_tensor) score_range = pxl_lvl_anom_score.min(), pxl_lvl_anom_score.max() show_pred(pil_to_tensor, img_lvl_anom_score, pxl_lvl_anom_score)
-- This code not working. Please help me :(

You need to return some of the variables of the model.fit() function inside the method objects (child objects inside the model.py) and save them by like torch.save. You can find out which variable are required to be saved within the predict function of that method and see which of them are called from the fit function of method.
for example for padim inside the model.py, you should do sth like this:
class PaDiM(KNNExtractor):
....
def fit(self, train_dl):
..
return self.resize, self.r_indices, self.means_reduced, self.E_inv, self.image_size
def predict(self, sample, resize, r_indices, means_reduced, E_inv, image_size):
self.resize = resize
self.r_indices = r_indices
self.means_reduced = means_reduced
self.E_inv = E_inv
self.image_size = image_size
And then within the run.py you should do
tobesaved = model.fit(train_ds)
torch.save(tobesaved, 'path')
torch.save(model.state_dict(), 'path')
And during inference:
model.load_state_dict(torch.load('path')
var1, var2, var3, var4, var5 = torch.load('saved_models/tobesaved'+method+''+expname+''+cls+'.tar')
output= model.predict(test_img_tensor, var1, var2, var3, var4, var5)
If you wanna do model.evaluate like the repo, you should make the parent class KNNExtractor(torch.nn.Module) receives these variables for its evaluate function and the model.predict() inside of it

Thanks for the comment, Mshz2. Closing this for now.


Windows 10

The application appears to be fairly up to date, but no mention is made of Windows 10 support.
Is that an oversight?

Yeah - looks like it. The readme hasn't been updated for a while.

Closed by 0e1f1181c0445335f16d2e1b2828f6be3a4855f5.


Fix performance tests

Description
Converted app name magic strings to constants in perf tests and added their identifiers to actor state store configurations so that the performance tests utilizing actors can run.
Signed-off-by: John Ewart<EMAIL_ADDRESS>/cc @skyao

@yaron2 why the statue of this PR is still open, not merged.

@yaron2 why the statue of this PR is still open, not merged.

It shows as merged.

OK, it seems a bug of github. I refreshed the pages for times and it was open all the time.
And now it is merged.

@johnewart  @yaron2  the perf test is not recovered after this PR merged.  We need to follow it: the perf test is NOT work for more than one week now.


I am making a Phineas

Hi, @viraldevpb are you still working on this issue? If not, I'll close it.


Add proposed 'window/progress' notification

Closes #43.
Sorry, I'm too itchy to not open it - the original proposed PR has been opened 1.5 years ago so it's about time :grinning:
This adds proposed feature which enables proposed LSP extensions.
RLS PR that's working and which only reexports the types - https://github.com/Xanewok/rls/commit/68da7677c6774ffb758a1a609a133ac5711a24e6

What is left after https://github.com/Microsoft/vscode-languageserver-node/pull/261 to make it properly part of the spec?

Done, addressed the feedback. While modifying .travis.yml it made sense to test also stable since this doesn't require any nightly features - should I remove it from the matrix?

What is left after Microsoft/vscode-languageserver-node#261 to make it properly part of the spec?

That's... actually a good question. So the PR is proposed and a reference implementation is provided as per their recommendation. I imagine the proposed features will make it in next LSP version (3.15?) so that the users can start using it.

The checks are all green now. I also added stable support (since we're not using any nightly features) - is that okay?

Released as 0.57.

Thanks! :tada:

For better or worse, this was further split into 4 different message literals - https://github.com/Microsoft/language-server-protocol/issues/70#issuecomment-483252666

Whelp, I guess this still works until it gets properly stabilized though?

Yeah, it does; this was a proposed extension by Facebook et al. and couple of servers adopted this window/progress version, so it's useful on its own. When the current version is stabilized we should update the types here.


[DO NOT REVIEW] test/failingLargeMpu

testing for issue https://github.com/scality/Integration/issues/449

end-to-end: http://ci.ironmann.io/gh/scality/Integration/9377

test we are concerned about passed, trying again to capture failure:
http://ci.ironmann.io/gh/scality/Integration/9381

Last test resulted in failure, this was the message that was printed:
===========================
Cannot have more parts in complete message than were put
partLength (10000 > storedPartsAsObjects.length (4752)
===========================

Oddly though I also printed the entire storedPartsAsObjects length and it looks like it has the 10,000 different parts. Perplexing.
Here is the artifact: http://ci.ironmann.io/gh/scality/Integration/9381/artifacts/0/tmp/circle-artifacts.DRa1poS/docker-logs/scality-s3-node1.amazonaws.com/logs/s3-0.log

So far:
first completeMpu request:
{“name":"S3","clientIP":"::ffff:<IP_ADDRESS>","clientPort":37030,"httpMethod":"POST","httpURL":"/bigmpu-test-bucket-1486497345481/mpuKey?uploadId=eee72e77c5bf451fbb42d21a6204217a","time":1486497681824,"req_id":"c3147cb276279110d561","level":"info","message":"received request","hostname":"box5","pid":122}

first object/part in completeMpu storedPartsAsObjects:
    {
        "key": "eee72e77c5bf451fbb42d21a6204217a..|..00001",
        "ETag": "\"900150983cd24fb0d6963f7d28e17f72\"",
        "size": 3,
        "locations": [
            {
                "key": "F6ED360FCBEDCBFCC286B16B87A3115957F99220",
                "dataStoreName": "sproxyd"
            }
        ]
    },

There are 10,000 parts, which is what we expect.
After storedPartsAsObjects is printed, we get maybe 10,000 of these:
{“name":"S3","bucketName":"bigmpu-test-bucket-1486497345481","objectKey":"mpuKey","bytesReceived":868993,"bodyLength":868993,"setting":"yes","time":1486497683116,"req_id":"c3147cb276279110d561","level":"info","message":"MPU_TESTING env variable setting","hostname":"box5","pid":122}

(same request)
However, no further logs with request id c3147cb276279110d561 following that, to show response.
last one:
{“name":"S3","bucketName":"bigmpu-test-bucket-1486497345481","objectKey":"mpuKey","bytesReceived":868993,"bodyLength":868993,"setting":"yes","time":1486497683362,"req_id":"c3147cb276279110d561","level":"info","message":"MPU_TESTING env variable setting","hostname":"box5","pid":122}

Instead new request shows up:
{“name":"S3","clientIP":"::ffff:<IP_ADDRESS>","clientPort":60373,"httpMethod":"POST","httpURL":"/bigmpu-test-bucket-1486497345481/mpuKey?uploadId=eee72e77c5bf451fbb42d21a6204217a","time":1486497801878,"req_id":"62d6341c27397ed481e2","level":"info","message":"received request","hostname":"box5","pid":128}

storedPartsAsObjects starts with:
[
    {
        "key": "eee72e77c5bf451fbb42d21a6204217a..|..05249",
        "ETag": "\"900150983cd24fb0d6963f7d28e17f72\"",
        "size": 3,
        "locations": [
            {
                "key": "EC15B39EF1FC06A5C286B16B87A31159563D7320",
                "dataStoreName": "sproxyd"
            }
        ]
    },

This is the one that fails. Ends with:
    {
        "key": "eee72e77c5bf451fbb42d21a6204217a..|..10000",
        "ETag": "\"900150983cd24fb0d6963f7d28e17f72\"",
        "size": 3,
        "locations": [
            {
                "key": "C01F7937EC7E33A7C286B16B87A3115988E3DC20",
                "dataStoreName": "sproxyd"
            }
        ]
    }
]
===========================
Cannot have more parts in complete message than were put
partLength (10000 > storedPartsAsObjects.length (4752)
===========================
{"name":"S3","bucketName":"bigmpu-test-bucket-1486497345481","objectKey":"mpuKey","bytesReceived":868993,"bodyLength":868993,"bytesSent":327,"clientIP":"::ffff:<IP_ADDRESS>","clientPort":60373,"httpMethod":"POST","httpURL":"/bigmpu-test-bucket-1486497345481/mpuKey?uploadId=eee72e77c5bf451fbb42d21a6204217a","httpCode":400,"time":1486497803067,"req_id":"62d6341c27397ed481e2","elapsed_ms":1188.636684,"level":"info","message":"responded with error XML","hostname":"box5","pid":128}`

Then, the delete requests:
{“name":"S3","clientIP":"::ffff:<IP_ADDRESS>","clientPort":32957,"httpMethod":"DELETE","httpURL":"/bigmpu-test-bucket-1486497345481/mpuKey","time":1486497803094,"req_id":"9ccad72a1b2e7cf6fd2e","level":"info","message":"received request","hostname":"box5","pid":116}

Discussed with Lauren, a possible interpretation is the sdk is sending the complete mpu request twice because the first one takes so long to send a response (a retry). In the meantime, the second request starts after some of the uploaded parts have been deleted, causing it to fail.
Along this hypothesis, I am running end-to-ends again with the sdk configured to wait longer to retry.
end-to-end: http://ci.ironmann.io/gh/scality/Integration/9387

Increased to retry delay base to 10 seconds, another end-to-end: http://ci.ironmann.io/gh/scality/Integration/9390

Previous end-to-end succeeded.
Adding a time elapsed statement to calculate how long it takes to complete mpu:
http://ci.ironmann.io/gh/scality/Integration/9393

latest attempt, with a retry delay base of 10000 ms:
completempu time elapsed: 121379 ms

    1) should intiate, put parts and complete mpu with 10,000 parts

    2) "after all" hook for "should intiate, put parts and complete mpu with 10,000 parts"

  0 passing (8m)

  2 failing

Another end-to-end...
http://ci.ironmann.io/gh/scality/Integration/9402
However, it doesn't look likely altering the retry delay base is the solution, since I changed it to 50 ms (instead of default 100 ms) in https://github.com/scality/S3/pull/599 and that branch passed one of the end-to-ends. It's unlikely the time it takes to complete a mpu varies that much that it would be less than 50 ms in one try and more than 10 s in another. I'm revisiting the logs trying to see if I can spot anything else, in the meantime, this end to end is running.

another end to end with retries disabled all-together: http://ci.ironmann.io/gh/scality/Integration/9403

success with retry delay base of 600000 ms for 9402:
completempu time elapsed: 31770 ms

    ✓ should intiate, put parts and complete mpu with 10,000 parts (372960ms)

  1 passing (6m)

end-to-end for disabled retries keep failing due to seemingly irrelevant build / circle ci issues, here is a fresh one:
http://ci.ironmann.io/gh/scality/Integration/9411

note that the test passed in an end-to-end for another branch where I disabled retries:
http://ci.ironmann.io/gh/scality/Integration/9409

result from last end-to-end, with disabled retries:
  0 passing (8m)

  2 failing

  1) large mpu should intiate, put parts and complete mpu with 10,000 parts:

     NetworkingError: socket hang up

      at createHangUpError (_http_client.js:213:15)

      at TLSSocket.socketOnEnd (_http_client.js:305:23)

      at endReadableNT (_stream_readable.js:921:12)

  2) large mpu "after all" hook for "should intiate, put parts and complete mpu with 10,000 parts":

     MPUinProgress: The bucket you tried to delete has an ongoing multipart upload.

      at Request.extractError (/home/scality/S3/node_modules/aws-sdk/lib/services/s3.js:323:35)

      at Request.callListeners (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:105:20)

      at Request.emit (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:77:10)

      at Request.emit (/home/scality/S3/node_modules/aws-sdk/lib/request.js:595:14)

      at Request.transition (/home/scality/S3/node_modules/aws-sdk/lib/request.js:21:10)

      at AcceptorStateMachine.runTo (/home/scality/S3/node_modules/aws-sdk/lib/state_machine.js:14:12)

      at /home/scality/S3/node_modules/aws-sdk/lib/state_machine.js:26:10

      at Request.<anonymous> (/home/scality/S3/node_modules/aws-sdk/lib/request.js:37:9)

      at Request.<anonymous> (/home/scality/S3/node_modules/aws-sdk/lib/request.js:597:12)

      at Request.callListeners (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:115:18)

      at Request.emit (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:77:10)

      at Request.emit (/home/scality/S3/node_modules/aws-sdk/lib/request.js:595:14)

      at Request.transition (/home/scality/S3/node_modules/aws-sdk/lib/request.js:21:10)

      at AcceptorStateMachine.runTo (/home/scality/S3/node_modules/aws-sdk/lib/state_machine.js:14:12)

      at /home/scality/S3/node_modules/aws-sdk/lib/state_machine.js:26:10

      at Request.<anonymous> (/home/scality/S3/node_modules/aws-sdk/lib/request.js:37:9)

      at Request.<anonymous> (/home/scality/S3/node_modules/aws-sdk/lib/request.js:597:12)

      at Request.callListeners (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:115:18)

      at callNextListener (/home/scality/S3/node_modules/aws-sdk/lib/sequential_executor.js:95:12)

      at IncomingMessage.onEnd (/home/scality/S3/node_modules/aws-sdk/lib/event_listeners.js:208:11)

      at endReadableNT (_stream_readable.js:921:12)

    2) "after all" hook for "should intiate, put parts and complete mpu with 10,000 parts"

  0 passing (8m)

  2 failing

So it does look like the retry caused the InvalidPart error, but we still have an issue with completeMpus not always returning a response in a timely manner...

First log from above end-to-end with completempu requestId has timestamp of<PHONE_NUMBER>570.
{"name":"S3","clientIP":"::ffff:<IP_ADDRESS>","clientPort":52949,"httpMethod":"POST","httpURL":"/bigmpu-test-bucket-1486519265912/mpuKey?uploadId=40faddd25d8d44d1a5c11d5812d72298","time":1486519601570,"req_id":"dd1a48c6a5e8cdb50f6a","level":"info","message":"received request","hostname":"box7","pid":127}

Last log has timestamp of<PHONE_NUMBER>876.
{"name":"S3","bucketName":"bigmpu-test-bucket-1486519265912","objectKey":"mpuKey","bytesReceived":868993,"bodyLength":868993,"setting":"yes","time":1486519602876,"req_id":"dd1a48c6a5e8cdb50f6a","level":"info","message":"MPU_TESTING env variable setting","hostname":"box7","pid":127}

Difference is 1306 ms.
Need to figure out where request is being dropped or getting tied up after that point.

end-to-end with lots of console logs to try and figure out where request gets tied up:
http://ci.ironmann.io/gh/scality/Integration/9413

testing to see if recent build failures are related to last commit by rolling back one: http://ci.ironmann.io/gh/scality/Integration/9418

build passed: http://ci.ironmann.io/gh/scality/Integration/9432
Retrying to see if we can capture failure:
http://ci.ironmann.io/gh/scality/Integration/9435

Closing PR for now as past five builds have passed the failing test, keeping branch & can re-open to test further if test still encounters problems in builds.

word came of a build in another branch failing this test with the socket hang-up error
rebased onto master and running an end-to-end:
http://ci.ironmann.io/gh/scality/Integration/9460

new day:
http://ci.ironmann.io/gh/scality/Integration/9489

UTAPI failure from yesterday was probably because Integration forward port rel/6.4 to master: scality/Integration#446 was not merged yet :)
Should work today :)

new end-to-end, more console.logs
http://ci.ironmann.io/gh/scality/Integration/9494

end-to-end with more console.logs, node timeout set to 600000 ms:
http://ci.ironmann.io/gh/scality/Integration/9505


Invoices - Not here page opens when opening invoice room from the deleted workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.76-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5343700
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests
Action Performed:

Go to staging.new.expensify.com
Create a new workspace and enable Invoices in More features page.
Go to FAB > Send invoice.
Send an invoice to anyone.
Create a second workspace and enable Invoices in More features page.
Go to FAB > Send invoice.
Send an invoice to the same person in Step 4, but from the second workpsace created in Step 5.
Delete the second workspace in Step 5.
Go back to Inbox.
Open the invoice room created in Step 7.

Expected Result:
The invoice room from the deleted workspace will open without issue.
Actual Result:
Not here page opens when opening invoice room from the deleted workspace
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/312747ee-201e-4344-8e47-e88f8885251f
View all open jobs on GitHub

I believe this needs to be handled internally.
The openReport request responds with a errorFields.notFound error.

This seems edge case, given that it's exclusive to deleted workspaces. I am gonna close this but will add the 'Not a Priority` label in case we want to address it later.


Fix converting Pbs to Unlit material conversion

Thermal camera uses unlit material for background objects. When visualizing thermal camera output in a more complex environment, I noticed that the textures are not correct copied over from Pbs to Unlit datablock. The changes here make sure we set the correct texture file to the unlit material.
Signed-off-by: Ian Chen<EMAIL_ADDRESS>

We'll need to make an ign-rendering patch release for this to be used in SubT (4.3.1, right?).

yeah 4.3.1


SDFGI no longer works with baked light.

Tested versions
Reproducible in 4.2.1 stable.
I can't remember the exact version in which this worked as intender, but it was around last year.
System information
Fedora workstation
Issue description
SDFGI was designed to be able to work with a LightmapGI node. In this case, the light map provides diffuse light while SDFGI provides reflections, specially for metallic objects. This worked extremely well so we built our workflow with it in mind.
Now that i started to test this method later on development again, i noticed that SDFGI no longer works as a reflection source for metallic objects while using baked light. Which results in pitch blacks metallic objects if they have low roughness. This is a hard blocker for us right now.
SDFGI:

light map with SDFGI (No reflections at all):

Steps to reproduce
I sadly can not provide reproduction projects, light maps are heavy and my pc is slow. The illustrated image is a cube with an emissive material on the top. The ball is on the center. Is metallic and has 0 roughness. All objects are static.
Bake the light map and then activate SDFGI. instead of providing the lacking reflection from the lightmap, it remains pitch black.
Minimal reproduction project (MRP)
My PC is too slow. If really necessary i will make multiple scenes and bake their light maps along the day.

Duplicate of?

https://github.com/godotengine/godot/issues/87600

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/87600 and https://github.com/godotengine/godot-proposals/issues/3012.


useTexture issue

Hi,
is it possible anyhow to load textures inside of the worker?
The normal texture loader doesn't work since it tries to access the dom:
document.createElementNS is not a function

Best

like all you're doing is useLoader(texture)? document.createElementNS doesn't exist in workers, but all these things can possibly be shimmed or faked, especially if they're not critical.

should be fixed.


Update with instance template that uses the common disk 'qa-e2e-ci-runner-x86-64-image-v1'

Please test if runner is getting added to the repo for running test after merging these changes


Emotion dataset cannot be downloaded

Describe the bug
The emotion dataset gives a FileNotFoundError. The full error is: FileNotFoundError: Couldn't find file at https://www.dropbox.com/s/1pzkadrvffbqw6o/train.txt?dl=1.
It was working yesterday (December 7, 2022), but stopped working today (December 8, 2022).
Steps to reproduce the bug
from datasets import load_dataset
dataset = load_dataset("emotion")

Expected behavior
The dataset should load properly.
Environment info

datasets version: 2.7.1
Platform: Windows-10-10.0.19045-SP0
Python version: 3.9.13
PyArrow version: 10.0.1
Pandas version: 1.5.1

Hi @cbarond there's already an open issue at https://github.com/dair-ai/emotion_dataset/issues/5, as the data seems to be missing now, so check that issue instead 👍🏻

Thanks @cbarond for reporting and @alvarobartt for pointing to the issue we opened in the author's repo.
Indeed, this issue was first raised in the "emotion" dataset Community tab: https://huggingface.co/datasets/emotion/discussions/3
I'm closing this issue and leave the issue above for the subsequent updates.
Duplicate of: https://huggingface.co/datasets/emotion/discussions/3

try using "SetFit/emotion" instead

try using "SetFit/emotion" instead

I' replaced "emotion" with "SetFit/Emotion", but the code is getting stuck at
emotions = load_dataset("SetFit/emotion")
I pause execution using the debugger, and it takes me to filelock.py:226
with self._thread_lock:
Do you know a way to get past this issue?

thanks @honeyimholm - worked for me

The dataset loading script has been fixed: https://huggingface.co/datasets/emotion/discussions/4

Collecting the datasets with the statements:
from datasets import list_datasets
all_datasets = list_datasets()
from the notebook fails to find an emotion dataset. Running the statement:
[item for item in all_datasets if 'emotion' in item][:5]
here are the first items of the list I obtain:
['dair-ai/emotion',  'go_emotions',  'Mansooreh/sharif-emotional-speech-dataset',  'Pyjay/emotion_nl',  'SetFit/emotion']
and no emotion.


expect protocol to be included in 'server' param

(otherwise browser blocks for mixed content)
Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

Good catch!
Looks like some tests are failing. Could you take a look?

@nicolodavis tests window.location.protocol is set to about: which socket.io can't make sense of.
change the PR to require full origin in the server param. This will also enable setting https server in an http website.

Coverage remained the same at 100.0% when pulling 88e17d28817d18f54687a360f88c0c1cc5bf2532 on amitport:allow-https into<PHONE_NUMBER>cc613950f9b783dc8b7d83428b32a2 on google:master.

@nicolodavis any comments? made the change though IMO passing the server url as is is preferable (boardgame.io shouldn't add its own prefix '//' or other)

I just want the ability to also just specify hostname:port and have it do something reasonable. How about we:

Prepend // when the input is just hostname:port.
Do nothing if the input already contains the protocol.

Let's close this in favor of #247.


Initial Archiver Service Implementation

Description
This PR creates the archiver service. It consists of two components the archiver and the api.

archiver continuously polls the beacon chain and writes any blobs it finds to the configured data store.
api uses this datastore and the beacon client to resolve get blob sidecar requests

This image shows a visualization of how the key components interact.

Overall LGTM modulo my mostly cosmetic comments, thank you for doing this!


Implementation of Kaiser window function

The documentation in the code for the kaiser function in windows.c states that parameter _N is the window length. The source for that function includes
    float t = (float)_n - (float)(_N-1)/2 + _mu;
    float r = 2.0f*t/(float)(_N);
    float a = liquid_besseli0f(_beta*sqrtf(1-r*r));
    float b = liquid_besseli0f(_beta);
    return a / b;

Parameter _N is used in a denominator above, but I believe the customary definition is to use _N - 1 such as in MATLAB and SciPy. So, shouldn't the second line in the code above be as follows?
    float r = 2.0f*t/(float)(_N-1);

You are correct in that it should be _N-1; however I'm getting some errors with the autotest checks so I'll need to track those down before I can commit the fix. Thanks!

fixed in dead3b5a5abf3c6244ce9718c81b026f77748f48


Skip dumping package properties for eng directories

Fixes #18276

/azp run go - generator

FYI @tadelesh

@tadelesh if it looks good, can you approve when you get the chance? Thanks!

@benbp Sorry for that I did not recognize the auto-merge label and it seems this PR auto merged.

@tadelesh that's my bad. I had it on auto-merge when the change was simpler, and forgot to remove it. @weshaggard let me know if you want me to revert anything :)


Delete Changes

504abb5 is a refactor to clean up the ChangePage component.
cbfea25 adds the deletion functionality.
c045d15 adds the sequelize-cli migration for the required deletedAt field.
./node_modules/.bin/sequelize db:migrate runs the migration. May need to edit config/config.json.

Ready for re-review! See f073bf9 for the new migration config.
If this checks out, feel free to merge.

Fixed!


rebar eunit doesn't compile .yrl files

Hi,
Either I'm missing something, or the eunit command fails to compile .yrl files when running the test suite.
When running rebar eunit on a clean project (i.e. no previously built beam files around), it fails due to a missing beam file that should've come from compiling a .yrl file (https://travis-ci.org/erlydtl/erlydtl/jobs/20463110).

Hi, this issue was closed in an attempt to do quick basic filtering. All tickets prior to March 2017 were closed and will be reopened on a per-request basis, please give rebar3 a try and feel free to reopen if it's a pressing issue that is still unresolved.


WIP:  Component switch w/ webpack

New PR based on @schuyler1d's feedback in #261
WIP to fix #256
You can set an env variable THEME as giraffe or legacy (default) for npm dev or build.
If THEME=giraffe, the alias will be rewritten like this:
import Billboard from 'Theme/billboard' -> import Billboard from 'src/components/theme-giraffe/billboard'

For consistency, I added LegacyTheme as an alias as well, so if you want a component to always be legacy (because it hasn't been built for giraffe yet), you can do:
import Billboard from 'LegacyTheme/billboard'

@schuyler1d I tried implementing resolution fallback with https://github.com/kije/webpack-fallback-directory-resolver-plugin. It worked, but the only issue was it was required to specify the .js extension. I could probably fork and fix that, but it seems like that would be introducing a lot of brittleness and confusion.

Didn't realize before that we were already doing code splitting here https://github.com/MoveOnOrg/mop-frontend/blob/master/src/loaders/petition.js. I've updated it so the chunks are distinct per theme too.
I've also tested building now, and everything seems to work.


Actions/feature-readme-to-slack-updates

Minor edit to the existing action to filter based on robot file updates (to avoid firing if only readmes are updated)
Added action to send a slack message to the public channel #codebundle-updates when codebundle readme files are updated
Fixed twitter typo


Translate May 15 covid report into Bengali, Czech, Filipino, Hindi, Swahili, Urdu, & Vietnamese.

Hi @VengaLing,
Hope this finds you well! The May 15 situation report is ready to be translated. See below for branches and file names. Feel free to just grab the file from one branch and rename it; they are all the same.
When the translations are completed, please merge them back into the appropriate branch. This will allow me to preview it to confirm the formatting is a-ok before pushing it to the master branch.
Thanks so much; it's been a pleasure working with you on these.
Cassia
Bengali
branch: sit-rep_bn
file: https://github.com/nextstrain/translations/blob/sit-rep_bn/narratives/translations_ncov_sit-rep_bn_2020-05-15.md
Czech
branch: sit-rep_cs
file: https://github.com/nextstrain/translations/blob/sit-rep_cs/narratives/translations_ncov_sit-rep_cs_2020-05-15.md
Filipino
branch: sit-rep_tl
file: https://github.com/nextstrain/translations/blob/sit-rep_tl/narratives/translations_ncov_sit-rep_tl_2020-05-15.md
Hindi
branch: sit-rep_hi
file: https://github.com/nextstrain/translations/blob/sit-rep_hi/narratives/translations_ncov_sit-rep_hi_2020-05-15.md
Swahili
branch: sit-rep_sw
file: https://github.com/nextstrain/translations/blob/sit-rep_sw/narratives/translations_ncov_sit-rep_sw_2020-05-15.md
Urdu
branch: sit-rep_ur
file: https://github.com/nextstrain/translations/blob/sit-rep_ur/narratives/translations_ncov_sit-rep_ur_2020-05-15.md
Vietnamese
branch: sit-rep_vi
file: https://github.com/nextstrain/translations/blob/sit-rep_vi/narratives/translations_ncov_sit-rep_vi_2020-05-15.md

Published Bengali, Czech, and Swahili. Thanks for the translations!


[BUG] LightGBM installs extra folders on PPC and s390x

LightGBM package is installing extra folders on PPC and s390x
build/
build-1.2.1.dist-info/
packaging/
packaging-24.1.dist-info/
pyproject_hooks/
pyproject_hooks-1.1.0.dist-info/

https://github.com/open-ce/LightGBM-feedstock/pull/42

https://github.com/open-ce/LightGBM-feedstock/pull/43

CI builds reported extra tomli folder in the py310 build, so raised a PR to delete it - https://github.com/open-ce/LightGBM-feedstock/pull/44


New data visualization: Economic recovery against confirmed cases, confirmed recovery

It's clear that at some point, different countries will start to have economic recovery as their societies begin to recover. Of course, every country (and sub region) is going to recover economically at different times and rates.
It would be really interesting to introduce a new visualization that pairs economic recovery to confirmed cases and/or confirmed recovered cases. GDP and employment are two dimensions that quickly come to mind that could be used.

@mmorper - This is an awesome idea - thanks!  We'll put this in the post prediction priorities list and figure out how soon we can / should get to it.  That'll give us time to find good data sources for it.  Thank you and stay safe!

Not forgotten - we needed to implement support for this.


ISPN-4038 CustomFailurePolicyTxTest.testPrepareFailure random failures

https://issues.jboss.org/browse/ISPN-4038

Good stuff. merged.

Merged


Should not remove newlines from inside XML tag

We have some XML whose values contain newlines. The auto-format feature is removing those newlines when saving. This causes us to lose important formatting. Please do not replace newlines inside of XML values.

This should be fixed as of v2.0.0-preview.2.


New feature: manipulate with className as a set, instead of a string

The class attribute is somewhat similar to style attribute: it's a string representation of a more sophisticated data structure. In the case of style it's a CSSStyleDeclaration, which is a map. In the case class, it's a proxy for the classList: DOMTokenList, which is basically a set.
I think it'd be pretty natural to treat class similar to style and would also reduce conflicts with web components, where a web component could set its own "internal" classes.
This is what it could look like:

  ...

It would work as following:

The array is expected to have a set of strings. False-y values (empty strings, false, null, etc) will be removed from the array before processing.
The new array state will be diffed against the new state and only the changed classes will be added/removed.
The element.classList will be used to add/remove classes.

Here's a little demo: https://codesandbox.io/s/9lx87xkqvo. It shows that updating the class via Preact currently overwrites classes the classes set by an emulated web component.

One gotcha I found yesterday while writing some vanilla JS is that IE11 doesn't take multiple classes as an argument to classList.add().

this is interesting, though i'd vote for using object instead of a class, like
...

rationale: easier to compose classes from different sources, if you use a list there's no way to clear a class, and with object it's just a matter of a spread operator

I tend to agree, there's classnames package but it adds so much pointless boilerplate into each component but.. this probably wouldn't align with the goals of Preact.

classnames gzip is 371b (YUGE), Im sure it could be code-golfed to smaller size but still
it would be very different from React API and while I don't care, it's one of the selling points

https://github.com/lukeed/clsx does a lot of what is being suggested in an opt-in fashion for anyone landing here

Thanks @kidqueb 🙇 That project evolved from obj-str, which is exactly what Preact 7.1 and below used to do. It was removed because it could be shimmed – see here
You could use that code snippet still & attach obj-str for old Preact behavior, or attach clsx/classnames/whatever you want.
As for the classList point, I made classico because classList is not very well supported (eg, it doesnt go as far back as Preact can go) and IE doesn't behave like any other browser.

We need a better place to gather up-to-date Preact stuff, awesome packages @lukeed. :+1:

Thank you~ The Preact website is getting a lot of TLC for the next release, including docs!

This is a neat idea and something that can be easily implemented via the suggestions by @lukeed above, or as a runtime hook:
import { options } from "preact";

options.vnode = (vnode) => {
  let props = vnode.props;
  props.class = doSomething(props.class);
  return vnode;
}

Because it is so easy to shim this feature and users usually bring their own variant of classnames, clsx, etc it is very unlikely that something like that would be added back to core.

I do realize that it's easy enough to manipulate a string. But I'd still stress: classes is a set data structure. Manipulating it as a string is very counterintuitive and rife with bugs. I think this should be the default (and maybe the only) way to manipulate classes.

@dvoytenko I see where you're coming from and we had something like that in core as luke mentioned. We stripped it because it wasn't used that often and instead users used their own set-like implementation on top of ours. This is especially true for users coming from react.
Another aspect to consider is performance. Right now class/className is a simple assignment because that maps 1:1 to the DOM. We just need to call setAttribtute and are done. With an a array we'd always need to iterate over it and either serialize it to a string or use the classList api which would add quite a few bytes.
With the rise of CSS-in-JS, CSS-Modules, etc this feature would be redundant. All these solutions mostly set a single class on an element. For that a simple string suffices.
The cool thing about preact is that you can make it work for you exactly like you want to. By creating a custom options.vnode hook you can support any custom properties and modify them in any way before they are passed to the reconciler :+1: We use the options.* hooks quite a lot ourselves when experimenting with new features and even built the upcoming hooks addon for Preact X with it. You could even publish it on npm and make that approach more popular :100:


Privacy-related: Consider enabling these two Chromium flags by default.

Please consider enabling chrome://flags/#reduced-referrer-granularity and chrome://flags/#prefetch-privacy-changes by default. The former is purely privacy-related, I don't know if you are already doing something similar. The latter prevents data leakage as described here:
https://terjanq.github.io/Bug-Bounty/Google/cache-attack-06jd2d2mz2r0/index.html
Here is the "Intent to implement" in Chromium:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bSMOY-evrV4
I have raised the same issue in the Brave browser repo, with the result that the flags got enabled by default:
https://github.com/brave/brave-browser/issues/8319
I have also raised this in the Vanadium repo, still under review:
https://github.com/GrapheneOS/Vanadium/issues/71
Thank you for your attention.

you might also want to make an issue on the android version too :) https://git.droidware.info/wchen342/ungoogled-chromium-android

Changes applied here will automatically be applied to Android version, so no need for a separate issue.

Why must we enable these two flags ourselves? If they're that impactful, why hasn't the Chromium team enabled them by default already?
I understand the privacy motivation for enabling these flags, but I'm having troubles seeing the impact on stability and retaining the default Chromium experience (however granular the experience can get). Any clarifications will be appreciated.

OK, so this is what the Chromium team has to say regarding chrome://flags/#prefetch-privacy-changes:
"The compatibility risk is mostly low, but not completely clear. Changing the credentials mode for prefetch requests may cause more cache-misses and therefore double-downloads, however could also introduce a correctness problem if prefetch responses do not have the Vary: Cookie header attached when their content actually relies on credentials. In this case, it is possible that a user can navigate (with credentials) to a resource, and the user will be served the uncredentialed response from the HTTP cache. We don’t expect the changes to service-workers mode, referrer policy, and redirect mode to break existing content. It is likely they will cause more cache-misses and double-downloads though."
source: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bSMOY-evrV4
As I have mentioned in the issue I've opened in the Brave repo, I have used the following websites with no compatibility issues:

Google
Facebook
Twitter
Instagram
Amazon
eBay
YouTube

I realize that this is no scientific test or something, but it goes to show that there really is not a problem with enabling this flag by default. Brave did, and so did Bromite recently, and there are no reports of related issues yet.
As for chrome://flags/#reduced-referrer-granularity, its effect is documented here:
https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)#modified-features-and-functionality
Seems to be a sane referrer header policy to me. The Chromium team is currently testing these changes, evaluating whether or not they can be enabled by default. But as said, I have had no issues with both of these flags set to "Enabled".
I understand that you want to maintain the default Chromium behavior, but may I remind you that Ungoogled Chromium differs from it on the several occasions already? Furthermore, I think we should strive to enable all built-in privacy protections by default, especially if the web compatibility risk is as low as it is in this case.

The Chromium team is currently testing these changes, evaluating whether or not they can be enabled by default. But as said, I have had no issues with both of these flags set to "Enabled".

Seems like it'll start being enabled in 85 and onward: https://developers.google.com/web/updates/2020/07/referrer-policy-new-chrome-default
Thanks for explaining. I agree that the impact is low for these flags, so I'll enable them.


JS: Fix flow for nested destructurings

Evaluation pending...

Evaluation was completely uneventful.

Should be ready to land


Fix typo in ActivateView

Fixed an typo in ActivateView.js on the setup screen.

I did a search on 'channek_id', this is the only file were this is mentioned. I have not been able to test this change (yet).


google-common [Feature]: Support File API as media/metadata store

Privileged issue

[X] I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content
Works on AI Studio only.
See https://ai.google.dev/api/rest/v1beta/files and https://ai.google.dev/api/rest/v1beta/media/upload
See https://github.com/google-gemini/cookbook/blob/main/quickstarts/Video.ipynb
See https://github.com/langchain-ai/langchain-google/issues/147
This is an odd kind of store

You store the media file, and get back metadata including the URL.
Then you can use this URL for fileData messages to include the media.
It manages the file (it will delete it after 2 days).
There is no way to download the media, however, just the metadata.

I'd like to have this used in a couple of ways:

As a stand-alone component so devs can save the media and manage the URL themselves (initial priority)
As something used by the Chat module so if a file_url or media type is provided, it will save it to the File store and use the URL instead (future implementation)

What is the best interface to represent this with? In the past, @jacoblee93 has suggested subclassing BaseStore where the key is... a filename? And the value when set is just the file (in what form) and when retrieved is a Record<string,string>? I'm honestly not sure.
(I would also like a companion version, with the same interface, that words with Google Cloud Storage for use with Vertex. See #5076 )

Being done as part of #5835


rhc: remove

Motivation for this change
This application is deprecated since 2016 and won't build on current Ruby versions: https://github.com/openshift/rhc
That's why I think it's safe to remove, since it's been marked as broken in February 2018.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @szczyp

With NIXPKGS_ALLOW_BROKEN=1 it still builds for me (I get a lot of deprecations warnings with Ruby 2.5 though), so I suggest that we keep the attribute in all-packages.nix for now:
{
  # ...
  rhc = throw ''
    `rhc` has been removed as it's marked as broken since 2018-02 and
    officially abandoned by upstream.
  '';
}

With NIXPKGS_ALLOW_BROKEN=1 it still builds for me (I get a lot of deprecations warnings with Ruby 2.5 though), so I suggest that we keep the attribute in all-packages.nix for now:
{
  # ...
  rhc = throw ''
    `rhc` has been removed as it's marked as broken since 2018-02 and
    officially abandoned by upstream.
  '';
}

Yeah, having a message would be helpful. Though I think that should be in aliases.nix.

I added the alias, tried to keep it as short as the other ones. Does this look OK for you?

@manveru thanks!


update Longhorn engine base image and some dependencies

Update Dockerfile.dapper base image to Ubuntu 20.04 and update dependencies

docker-cli to 20.10
minio server to 2021-07-27T02-40-15Z
grpcio & grpcio-tools to v1.39.0
protobuf to 3.17.3
cattle to 0.5.4

Update Longhorn engine Dockerfile base image to Ubuntu 20.04
bump github.com/gorilla/websocket version to v1.4.2

Signed-off-by: Mohamed Eldafrawi<EMAIL_ADDRESS>

This PR should be merged after https://github.com/longhorn/longhorn-engine/pull/631

Ref: integration tests coretest results > https://ci.longhorn.io/job/private/job/longhorn-tests-regression/372/

Ref: integration tests coretest results > https://ci.longhorn.io/job/private/job/longhorn-tests-regression/372/

Let's see the result before the merge.

Some tests fail, in the PR check, but always pass with run them locally.
 It's more like a test stability issue instead of a specific test case.

This was caused by some uncertain compatibility between the latest version 1.39.) of python gRPC client/tools with engine/instance manager gRPC implementation (based on 1.21.).
For testing purposes, we can just use Python gRPC 1.25.* instead of the latest version, and it's Python 3 compatible.
Closing this, and use #649 instead.


Post-arm fixes into prod

Some secret generation misconfigured. Now done in another way, making secret rotation easier.
Also bump AZCLI versions to latest and fix AKS updater script.

Good stuff.
README should be updated with a link on HOWTO create all the secrets.

Role assignments removed due to issues with assigning for MI.
Now assigned like this:
New-AzRoleAssignment -ObjectId xxxx -Scope yyyy


console: remove ibm-console container from odf-console deployement

https://bugzilla.redhat.com/show_bug.cgi?id=2004824
/assign @jarrpa @iamniting

/cherrypick release-4.9

/hold

/hold cancel

@bipuladh Can you pls send this PR to the release-4.9 branch as well?

Backported PR is https://github.com/red-hat-storage/odf-operator/pull/98


General PomBase stats page: GO stats

Evidence code changes (all types)
Evidence code changes (manual vs electronic) All vs . IEA

Legacy data:

how many gene products are extended, with how many extensions
currently  582 gene products with  >1556 extensions (some compound)
How many genes have at least one MF/BP/CC annotation?
(I usually do a 3-way venn for this)

jan 20017
253 EXP
1691 IC
13581 IDA
4180 IEA
53 IEP
1 IGC
842 IGI
1 IKR
5792 IMP
1872 IPI
857 ISM
6632 ISO
1781 ISS
926 NAS
2580 ND
4 RCA
374 TAS
All evidence codes moving in the right direction......(compare to above)

253 EXP
1692 IC
13564 IDA
4092 IEA
52 IEP
1 IGC
838 IGI
1 IKR
5793 IMP
1877 IPI
848 ISM
6601 ISO
1778 ISS
913 NAS
2579 ND
4 RCA
380 TAS
IEAs will soon be back under 4000....

Is there anything I need to do here?

nope not yet. Sorry I don't know why I feel the need to post the updates in this ticket. I think it's just that this is where I go to look at older data. Ignore....

I know this doesn't really belong in this ticket, but I just noticed that IEAs are back under 4000 for the first time in years....  Woo Hoo...
(and everything else is going in the right direction too)
497 EXP
1717 IC
13710 IDA
3992 IEA
32 IEP
1 IGC
840 IGI
1 IKR
5782 IMP
1940 IPI
930 ISM
6864 ISO
1908 ISS
818 NAS
2377 ND
4 RCA
367 TAS

IEA almost another 100 down this month
499 EXP
1728 IC
13818 IDA
3916 IEA
32 IEP
1 IGC
840 IGI
1 IKR
5860 IMP
1954 IPI
947 ISM
6854 ISO
1921 ISS
795 NAS
2338 ND
4 RCA
360 TAS
NAS, ND, TAS also down :)
I don't think we will eradicate IEA in this grant cycle  (we will probably  have membrane and  binding terms for ever), but I think we could eradicate for BP completely.
I looked a while ago and I think that for "chromosome segregation" and "DNA metabolism" there were only 3 or 4.....

499 EXP
1746 IC
13883 IDA
3876 IEA
32 IEP
1 IGC
848 IGI
1 IKR
5911 IMP
1979 IPI
951 ISM
6840 ISO
1925 ISS
786 NAS
2342 ND
4 RCA
357 TAS
IEA down
TAS down
NAS down
ND +4

527 EXP
1731 IC
13932 IDA
3860 IEA
33 IEP
1 IGC
838 IGI
1 IKR
5941 IMP
1991 IPI
943 ISM
6613 ISO
1869 ISS
768 NAS
2335 ND
4 RCA
352 TAS
going in the right direction. I remove loads of IEA...I have no idea why it hasn't gone down more....

hmmph 3935 IEA back up.....
this could be lots of new mappings...or some parentage in the ontology removed...

brilliant
573 EXP
6938 HDA
1535 HMP
1669 IC
7063 IDA
3316 IEA
29 IEP
837 IGI
1 IKR
4553 IMP
2511 IPI
1555 ISM
5319 ISO
1483 ISS
668 NAS
2267 ND
408 TAS
I did get IEA nearly this low once before back in 2011, but I think we are on the home stretch now. I can't imagine that we will ever get lots of new IEA mappings.
Nice drop in NAS too (although I just added 67 new ones)
PAINT annotation will push down further butI don't want to include without some validation.

895 EXP
6886 HDA
1535 HMP
86 IBA
1814 IC
7797 IDA
3333 IEA
25 IEP
802 IGI
1 IKR
4631 IMP
2667 IPI
1536 ISM
5145 ISO
1453 ISS
737 NAS
2194 ND
404 TAS

experimental
929 EXP
4650 IMP
2904 IPI
7839 IDA
793 IGI
25 IEP
exp- htp
6884 HDA
1535 HMP
author/curator statements
1788 IC
391 TAS
663 NAS
inferred from other species
4138 IBA
3167 IEA
1 IKR
1468 ISM
4882 ISO
1421 ISS
no data
2020 ND
IEAs still dropping nicely.
In 6 months or so once all the PANTHER/PAINT odd bods are weeded out we might change the ordering so
EXP> IBA> the rest
but I would like to keep the evidence  filtering precedence as it is for now  so we have a smaller number to look at (There are still some high level classes I might just check if I am bored).

evidence | date|

| - |
EXP |895|

895 EXP
6886 HDA
1535 HMP
86 IBA
1814 IC
7797 IDA
3333 IEA
25 IEP
802 IGI
1 IKR
4631 IMP
2667 IPI
1536 ISM
5145 ISO
1453 ISS
737 NAS
2194 ND
404 TAS

I would love to see evidence codes graphed.

I put a medium priority, but if you feel motivated, you can do it sooner.

We might have another ticket about this. We discussed when talking about Tree grafter and IEA replacement (definitely discussed it this year and the last comment on here is NO v 23)

Is this what you were thinking of?:

pombase/website#2153

On 09/04/2024 10:42, Kim Rutherford wrote:

Is this what you were thinking of?:

pombase/website#2153
https://github.com/pombase/website/issues/2153

—
Reply to this email directly, view it on GitHub
https://github.com/pombase/pombase-chado/issues/567#issuecomment-2044584167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYEWKCHMI4AQRAEMZZLDTTY4OZWXAVCNFSM4CLYCYP2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGQ2TQNBRGY3Q.
You are receiving this because you were assigned.Message ID:
@.***>

That's it!
--------------fu3IfcYmIgJmxKUvIdcl81WN
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 09/04/2024 10:42, Kim Rutherford
      wrote:

Is this what you were thinking of?:

<a class="issue-link js-issue-link" data-error-text="Failed
        to load title" data-id="2166793059" data-permission-text="Title is private" data-url="https://github.com/pombase/website/issues/2153" data-hovercard-type="issue" data-hovercard-url="/pombase/website/issues/2153/hovercard" href="https://github.com/pombase/website/issues/2153" originalsrc="https://github.com/pombase/website/issues/2153" shash="yO0cSsYGeLRWI8BqadurFOLRPDih4n/KRghvRUMPyShvxK2Z0QhtJDuS+6IAAs3TmdIhdEqtrG+QituQWBU59GFIXYXCshZ05F1jH2CmFWQlk0ftYdN9uYx5AJhpSP1FxCDHF6DwUKCYJjuG4bWY0pUpJwIHyb7KSxMyXAKJGDQ=" moz-do-not-send="true">pombase/website#2153

—

    Reply to this email directly, view it on GitHub, or <a href="https://github.com/notifications/unsubscribe-auth/ABYEWKCHMI4AQRAEMZZLDTTY4OZWXAVCNFSM4CLYCYP2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGQ2TQNBRGY3Q" originalsrc="https://github.com/notifications/unsubscribe-auth/ABYEWKCHMI4AQRAEMZZLDTTY4OZWXAVCNFSM4CLYCYP2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGQ2TQNBRGY3Q" shash="Xfv0eylDn5/IzEqD4ucqb6YP5B5FNAm8ivevmOOkuYY5CH9Chd/waibZoum+j4yO7HWikHkw+6ULbPkKh+62MmQYcWT5Sb4eNrehbEKlOQQsn70xj+y0ofHXQcIyZnK/9lfHeKxyEJnW7H9Awjhwj6GPnLGWqtFX47d7EtO6IVM=" moz-do-not-send="true">unsubscribe.

    You are receiving this because you were assigned.Message
      ID: <pombase/pombase-chado/issues/567/2044584167@github.com>


Improved Resource Icons Are Always Transparent On Game Load

Expected Behavior:
Improved resource icons' opacity is set according to corresponding option on game load.
Current Behavior:
Improved resource icons are always transparent on game load.
Steps To Reproduce:

In CQUI options choose to display improved resource icons as solid.
Improve some luxury/strategic/bonus resources.
Save the game.
Load the game.
Note that option is actually saved properly but the icons are transparent until it's reapplied.

Indeed, there was a missing event in the worldviewiconmanager.lua. I fixed it. It should be ok in the next version on steam or next time I'll push on GitHub.


feat(IAM Policy Management): re-gen service after fix the template state parameter

PR summary

issue: https://github.ibm.com/IAM/AM-issues/issues/1949
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Examples:


[cnats] Update to 3.5.0 and remove system dependency to sodium

On Linux CNats would find the system libsodium instead of using the vcpkg one. This forces to use the vcpkg one and it upgrades to 3.5.0

I did the requested changes save for one that will not work


Fix several small issues with rviz gui

See commit messages for details

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.16%. Comparing base (c174715) to head (e8eb9c1).
Report is 20 commits behind head on master.

Files
Patch %
Lines

...it_ros/robot_interaction/src/robot_interaction.cpp
0.00%
3 Missing :warning:

...plugin/src/motion_planning_frame_joints_widget.cpp
0.00%
2 Missing :warning:

...rviz_plugin/src/motion_planning_frame_planning.cpp
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
+ Coverage   47.15%   47.16%   +0.02%
==========================================
  Files         603      603
  Lines       58999    59196     +197
  Branches     6969     7024      +55
==========================================
+ Hits        27814    27915     +101
- Misses      30773    30863      +90
- Partials      412      418       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add analyser

Add analyser:

handle split test/train
repeats the training/testing process
compute and aggregates fig of merits (MAE)

Analyser creation should be done using factory pattern and returning the correct one based on arguments

On second thought, I'm not convinced the factory brings a lot.
Currently implemented without factory/IoD, directly in class Evaluator. See PR #31


Linkify selected text when pasting a URL

In Zulip web, if you have some text selected in the compose box and you paste a URL, the selected text becomes the text of a link (with that URL) instead of getting replaced.
That's a useful feature, and we should do the same in mobile.

We had a user request for this the other day:
https://chat.zulip.org/#narrow/channel/48-mobile/topic/iOS.20feedback.20for.20Julia.20community.20member/near/1961857
https://chat.zulip.org/#narrow/channel/48-mobile/topic/iOS.20feedback.20for.20Julia.20community.20member/near/1963804

Could you please assign this issue to me? I would love to work on implementing this feature!

Hello @nitin-787, welcome. See our guide to picking an issue to work on:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on


Switch from Wildcard Permissions given to ProvisionAccount Role

Typically, we prefer to specify all of the permissions that are needed, rather than wildcard it.  This makes it explicit which permissions have been granted and also forces us to document when new permissions are added/removed.
Originally posted by @dav3r in https://github.com/cisagov/cool-images-assessment-images/pull/1#discussion_r626074199

I am looking at iamlive as a way to determine required permissions to work with Terraform AWS configurations. This would make it more straightforward to insist on specific permissions instead of wildcarding for convenience.


[dartdev/analyzer/linter] Consider adding a command to add a linter rule

I've seen this mentioned a few times before but I couldn't find a dedicated issue for it here. As we work to improve the linter rule documentation in the future (related https://github.com/dart-lang/site-www/issues/4498), it would be nice if we could just give users a command they can copy with a button and run to add or remove a linter rule. dart pub add has been an extremely useful command in documentation with a similar goal.
The command could be part of a new dart linter or dart analyzer tool, or just added as a subcommand to dart analyze. It would probably be fine as a hidden command from --help unless other functionality is added, as I imagine most use cases will be from documentation and blog posts.

Check if the lint exists, error if it doesn't
Check if the lint is already applied (within the same file, not included ones), if it is, tell the user that
Check if the lint is incompatible with any applied ones, error if it is and inform the user of the incompatibility
Add the lint to the list (preferably sorted)

/fyi @jacob314

I'm beginning to think a solution like https://github.com/dart-lang/pub/issues/4052 might be more sustainable as it would be easier to evolve outside the normal guarantees of the SDK.


MS Edge: Time line is hovered by side panel

Actual result
Part of the time line is hovered by side panel.
Look at attached snapshot.
Other information
Reported by: Valeriy Trots

Test configuration: Edge, Win10, PC
Test case number: TC74
Test run: https://valorsoftware.testlodge.com/projects/15827/runs/196382?tab=2&run_section_id=176406&executed_case_id=9463591#executed_case_9463591

Can't reproduce anymore.


✨(render) add overload of rendering components of verna

Purpose
add props to overload render for

section
dropzone
fieldTemplate
submit button

I had to change many imports in the end but should be good :)


pull upstream changes into islandora_defaults

See https://github.com/jhu-idc/idc-isle-dc/issues/71
Given the forked nature of islandora_defaults any pull from upstream would need to be vetted to ensure there would be no stomping over customizations. The nature of the update is somewhat large but the main pieces would be ensuring that callbacks for fields are not utilizing deprecated functions as well the submodules have their info.ymls updated accordingly.

Essential stuff pulled in as of https://github.com/jhu-idc/islandora_defaults/commit/fb1aac2963687dab260440110b1192427ba4ba92
It hasn't been fully brought in line with upstream, though.  But it works for D9


Memory and linalg refactoring

Refactoring of memory management and linear algebra
The primary goal of this modifications is to introduce a new interface
to the linear algebra routines, i.e. be able to call BLAS routines
like this:
  auto la = linalg_t::blas;
  linalg2(la).zgemm('N', 'N', m, n, k, a.at(memory_t::host), a.ld()...)

The following changes were implemented

memory_pool class was finalized and benchmarked; the last thing to implement in memory_pool is a proper memory alignment, i.e. return pointers that are compliant with alignof(T) length
mdarray class is in the transition state:

new method .at(memory_t, i, j..) is introduced; templated version .at<CPU>(i, j...) is going to be removed in the future
new method .copy_to(memory_t..) is introduced; old templated version .copy<memory_t from, memory_t to>() will be removed in the future
in general, the usage of templates will be removed where it is not justified
memory_pool and mdarray classes are now located in the same file memory.hpp as they both are used to manage the memory
mdarray can now allocate from the memory pool

new linalg2 interface: now cublasxt with CPU pointers can be called
reduction of GPU memory usage in Local_operator::apply_h()
minor text formatting in Hubbard-U descriptor class
remove template parameter N in beta_projector_base class; same reasoning: template parameter is not justified
new inner(), transform() and ortho() version that accept memory type and linear algebra type instead of processing device; old version will be removed in the future

Seems to be fine after going through the changes. We will need to restore the set_device thingy when this is merged. There is nothing wrong with the commit a64bf3af45092d416ee9239a7a82b8fb9b95f317. I think we can merge it and do more testing.
By the way, I think it would be good to remove commented dead code when relevant afterwards.

@toxa81 The python code does not compile anymore. I'll make the required changes.


Problem in Android 4

Hi ! Nice library and easy to implement in app. Its working fine in other version than Kitkat. I am getting application crashed in Android 4.2 as well android 4.4. I have attached logcat for same. Please check and let me know if you have solved or not.
Thanks
log1.txt

Seems like you are using a Gradle version that doesn't support PNG generation from vector drawables. Check the documentation and update your Gradle version and settings accordingly: https://developer.android.com/studio/write/vector-asset-studio.html

Than why you not keep your library minimum 23.2 ? it says that we need minimum 4.4

The build tools version has nothing to do with the minimum SDK.
You should always use the latest build tools version in your projects independent from wether you use material-intro or not. The latest build tools version ensures maximum compatibility and offers the latest Android build features such as instant run.
The minimum SDK however is only a indicator on which devices the application can run. This library uses min SDK 15 aka ICS MR1 which is the official recommended min SDK nowadays.
To make it more the build tools version is a build time property that won't be visible in the generated APK.
Please take some time and read the docs about the Gradle build system to understand this better.


Cannot change strategy of configuration ':apt' after it has been resolved

Cross-posting this issue here, since I'm not sure if it's a Gretty issue or an issue with your APT plugin:
When using the Gretty plugin in combination with the APT plugin, I receive the following error:

Cannot change strategy of configuration ':apt' after it has been resolved

in Gradle < 3.0 this was just a warning and I was able to proceed anyway, but in Gradle 3.0 this is an error that prevents me from building the project.
I am using Gretty 1.4.0 and Gradle-APT-Plugin 0.8 (both latest versions). Simple build.gradle that you can use to reproduce this:
apply plugin: 'java'
apply plugin: 'net.ltgt.apt'
apply plugin: 'org.akhikhl.gretty'

buildscript {
    repositories {
        maven { url "https://plugins.gradle.org/m2/" }
    }
    dependencies {
        classpath "net.ltgt.gradle:gradle-apt-plugin:0.8"
        classpath 'org.akhikhl.gretty:gretty:1.4.0'
    }
}

Note: if you apply the net.ltgt.apt plugin after the org.akhikhl.gretty plugin, it'll work.
This is due to the order the afterEvaluate hooks are called, the one from the net.ltgt.apt plugin triggering a resolve of the apt configurations. I'll see if I can change the plugin to defer this, maybe, to a first action on the compile tasks.
In the meantime, at least, you have now have a workaround.

That works, thanks!

Should be fixed by 6c137f71f069b621ed7834314e59327bde289495

Just released v0.9 with the fix btw


accept kwargs for cuda kernels. cache kernel configurations

This PR:

Supports kwargs for cuda-jitted kernel invocations by using inspect.signature.bind, which converts any **kwargs to *args before calling Dispatcher.call().  As a result of this change, the call signature of _LaunchConfiguration and Dispatcher.call have been changed to include **kwargs.
Use lru_cache for Dispatcher.configure to avoid creating new _LaunchConfiguration instances at every __getitem__call.
For a simple kernel like

@cuda.jit
def func_cuda(a, b=0.):
    for i in range(cuda.grid(1), a.shape[0], cuda.gridsize(1)):
        a[i]+= b

The invocation of func_cuda[4,256](a_g, b=1.) changes from 70 us to 40 us per loop with the lru_cache.
EDIT
lru_cache change is removed from the PR.
Closes #7870

Thanks for the PR - can you split this into two PRs please (e.g. by removing the caching from this PR and making another one that just does the caching)? It's much easier for the review process to consider each improvement separately.

Thanks for the PR - can you split this into two PRs please (e.g. by removing the caching from this PR and making another one that just does the caching)? It's much easier for the review process to consider each improvement separately.

Hey @gmarkall, just did and waiting for the checks. Not sure if this is what I should do or not but I basically just rolled back the change for caching. Will open another one for the caching.

Hey @gmarkall, just did and waiting for the checks. Not sure if this is what I should do or not but I basically just rolled back the change for caching. Will open another one for the caching.

That's great, many thanks!

Now that the CUDA target shares a lot of the infrastructure with the core / CPU implementations, I'm not sure it's necessary to have special handling for default arguments in CUDA - my present hypothesis is that we ought to just be able to enable argument folding and then pass args and kwargs through the dispatcher machinery. I have a quick experiment with this idea here: https://github.com/gmarkall/numba/commit/1db1c44be1a541e73269ba12131762891d8410f5 (branch is https://github.com/numba/numba/compare/main...gmarkall:cuda-kwargs)
In general I'd prefer the approach of reusing the core/CPU machinery for this - are there test cases for which the implementation in the commit above fails, whereas the implementation in this PR succeeds?
Note that my understanding of argument folding is as follows:

If you are compiling a function where not all the kwargs are specified, the dispatcher compiles a variant where the argument list consists only of positional args and specified kwargs. So for example:

You have an njitted function def f(a, b, c=1, d=2, e=3)
You call f(1, 2, d=13)
A version f(a, b, d) is compiled with c=1 and e=3 baked in
The call executes f(1, 2, 13)

Can @sklam or @stuartarchibald comment on this description and the idea above?

Now that the CUDA target shares a lot of the infrastructure with the core / CPU implementations, I'm not sure it's necessary to have special handling for default arguments in CUDA - my present hypothesis is that we ought to just be able to enable argument folding and then pass args and kwargs through the dispatcher machinery. I have a quick experiment with this idea here: gmarkall@1db1c44 (branch is main...gmarkall:cuda-kwargs)
In general I'd prefer the approach of reusing the core/CPU machinery for this - are there test cases for which the implementation in the commit above fails, whereas the implementation in this PR succeeds?
Note that my understanding of argument folding is as follows:

If you are compiling a function where not all the kwargs are specified, the dispatcher compiles a variant where the argument list consists only of positional args and specified kwargs. So for example:

You have an njitted function def f(a, b, c=1, d=2, e=3)
You call f(1, 2, d=13)
A version f(a, b, d) is compiled with c=1 and e=3 baked in
The call executes f(1, 2, 13)

Can @sklam or @stuartarchibald comment on this description and the idea above?

I'm not familiar with how the dispatchers are setup, if there's a more native way to do this that'd be great!
I just gave your approach a quick try and a test case with kwargs added in the wrong order will fail because of argtypes mismatch with arguments:

def add_multi(x, y, z):
    return x + y + z

def add_kernel_with_multiple_default(r, x, y=789., z=1):
    r[0] = x + y + z

...

def test_kernel_with_defaults(self):
        c_add = cuda.jit(add_kernel)
        c_add_w_default = cuda.jit(add_kernel_with_default)
        c_add_w_multi_default = cuda.jit(add_kernel_with_multiple_default)

        # Using a complex128 allows us to represent any result produced by the
        # test
        r = np.zeros(1, dtype=np.complex128)

        for x,y,z in zip([123, 12.3, 12.3,<PHONE_NUMBER>0], [456, 45.6, 45.6j, 456], [1, 2, 3, 4]):
            c_add[1, 1](r, x, y)
            self.assertEqual(r[0], add(x, y))

            # invocation with keyword
            c_add_w_default[1, 1](r, x, y=y)
            self.assertEqual(r[0], add(x, y))

            # invocation as position
            c_add_w_default[1, 1](r, x, y)
            self.assertEqual(r[0], add(x, y))

            # invocation using default, y=789
            c_add_w_default[1, 1](r, x)
            self.assertEqual(r[0], add(x, 789))

            # multi defaults
            c_add_w_multi_default[1, 1](r, x, y, z)
            self.assertEqual(r[0], add_multi(x, y, z))

            c_add_w_multi_default[1, 1](r, x, y, z=z)
            self.assertEqual(r[0], add_multi(x, y, z))

            c_add_w_multi_default[1, 1](r, x, y=y, z=z)
            self.assertEqual(r[0], add_multi(x, y, z))

            c_add_w_multi_default[1, 1](r, x=x, y=y, z=z)
            self.assertEqual(r[0], add_multi(x, y, z))

            c_add_w_multi_default[1, 1](r, y=y, z=z, x=x)     #  <------ this fails
            self.assertEqual(r[0], add_multi(x, y, z))

I suspect the lines here is the issue.

Just adding a quick note, will respond to your earlier comments later - I noticed we'll also need to do something for float16 and kwargs as mentioned in https://github.com/numba/numba/pull/7972#pullrequestreview-938324170

@gmarkall RE: https://github.com/numba/numba/pull/7871#issuecomment-1093074823 I think the description regarding argument folding is about right, the compiled function will have the missing args baked in and the function signature appropriately reduced. RE: the reuse of core machinery, I can't think of anything special about CUDA in this case that would warrant a custom code path for handling kwargs. Therefore, if possible, I think the application/use of existing the functionality from the CPU target is the best thing in terms of maintenance and consistency.

if possible, I think the application/use of existing the functionality from the CPU target is the best thing in terms of maintenance and consistency.

I didn't yet finish understanding how the CPU target does this, but it seems that it uses the ArgPacker in the data model, as part of the generated function. I was going to try and understand this to suggest that @TK-21st duplicate the logic in the CUDA target for now, with a view to it using the same code generation as the CPU when call sides are jitted.

I think the CPU logic begins here: https://github.com/numba/numba/blob/main/numba/core/callconv.py#L547, but there's a few layers of abstraction to go through to understand what's happening - the builder API, the argpacker, and whatever it does to create the list of realargs.

@TK-21st Since the kernel caching part of this went in a separate PR, and I don't think we can accept the support for kwargs in this form (that works a different way to the CPU target), could we close this PR? Many thanks for your efforts so far and thankyou for contributing to Numba.

Sure! Thank you Graham for following up. On Mar 15, 2023, at 12:47 AM, Graham Markall @.***> wrote:
@TK-21st Since the kernel caching part of this went in a separate PR, and I don't think we can accept the support for kwargs in this form (that works a different way to the CPU target), could we close this PR? Many thanks for your efforts so far and thankyou for contributing to Numba.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


updated package-lock

updated package-lock by running npm i --package-lock-only after deleting original package-lock
Description of Change

Related Issue
Motivation and Context
Checklist

[ ] Ran npm run lint and updated code style accordingly
[ ] npm run test passes
[ ] PR has a description and all contributors/stakeholder are noted/cc'ed
[ ] tests are updated and/or added to cover new code
[ ] relevant documentation is changed and/or added

sorry, please disregard I was trying to push it to my own repo


Please mention about systemd dependencies when chrony uses ptp

When some distribution uses ptp for chrony source, chrony fails to start when reboot.
the message is like following;
Feb 25 06:36:42 m0001dmngdsm01 chronyd[2708]: Could not open PHC

If using systemd, to avoid above, we should write dependency in /etc/systemd/system/chronyd.service
like following;
After=ntpdate.service sntp.service ntpd.service network-pre.target

Could you please add above known issue and solution to Chrony + PTP section? thanks,
https://docs.microsoft.com/en-us/azure/virtual-machines/linux/time-sync#chrony

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f5e6687-3b97-7f25-5e7b-91265764c816
Version Independent ID: d3f3b17a-a25b-656b-314f-25002c5d5f9f
Content: Time sync for Linux VMs in Azure
Content Source: articles/virtual-machines/linux/time-sync.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! We are currently investigating and will update you shortly.

@nmikuni  I have assigned the issue to the content author to investigate further and update the document as appropriate.

@cynthn Please take care of this issue

@jakaruna-MSFT and @nmikuni thanks for the feedback! Can you give me some more details about this issue?
You say "some distributions" hit this issue - do you know which ones and what versions? Why is the dependency required? What affects will this have on chronyd service?
The article is meant as an overview of time sync in Azure, so if this issue is specific to a small number of distributions or versions of specific distributions, it probably doesn't belong in this doc.

I only saw one case in CentOS 7.5 and kernel version is 3.10.0-327.el7.x86_64. It happened several times. After add dependency, it goes well.

Little script for ubuntu(/Debian?) derived distros:
# Hyper-V clock synchronization
if grep -q "hyperv" "/sys/class/ptp/ptp0/clock_name"; then
    sudo apt -y install chrony
    echo "refclock PHC /dev/ptp0 poll 3 dpoll -2 offset 0" | sudo tee -a /etc/chrony/chrony.conf
    sudo service chrony restart
fi

@mimckitt Can we get someone to help test and verify this?

I would see if @danielsollondon could assist or someone from the Linux team. I am more familiar with the time sync for Windows but not so much linux.

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


broken with new update

Hi. thanks for new control via UI. but it's broken atm.

When two instances added, it shows all entities on all of them.
Automations don't react on state changes anymore -> rendering all automation useless atm.

Please fix them as they're making this plugin useless in its current version.

DFJ

Feedback appreciated! I do need help testing it.
Hope you saw it was beta pre-release (with new HACS I see that it shows up a "new release" in HA settings, in previous HACS you needed to check the box "show pre-releases" for it to show up)
Your comment no1 I have seen from time to time but can't figure out why, I believe I set unique device identifiers for the entities but apparently not...
Can you elaborate on no2, you mean the integration do not react on changes in configuration, or on new hour (when new price range shall be updated)?
Otherwise "Automations" I interpret as those you have made that listens to the binary state "low cost". Does the state change for you but your automation do not react? Is so I would think it's not the integration...

Feedback appreciated! I do need help testing it. Hope you saw it was beta pre-release (with new HACS I see that it shows up a "new release" in HA settings, in previous HACS you needed to check the box "show pre-releases" for it to show up)
Your comment no1 I have seen from time to time but can't figure out why, I believe I set unique device identifiers for the entities but apparently not...
Can you elaborate on no2, you mean the integration do not react on changes in configuration, or on new hour (when new price range shall be updated)? Otherwise "Automations" I interpret as those you have made that listens to the binary state "low cost". Does the state change for you but your automation do not react? Is so I would think it's not the integration...

No2: I have an automation that listens when low cost state changes, it triggers my automation. It doesnt get triggered at all with new update. I have two instances.

That's weird.
But you see the state of the binary sensor change?
If you do, I can't see how it's the integration that causes it. Then it's more likely something in HA, have you made sure you use the correct entity-id in automation?


added python 3.6 support

fix for issue #94 to support python 3.6 as well

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   81.23%   81.23%
=======================================
  Files          12       12
  Lines         325      325
  Branches       60       60
=======================================
  Hits          264      264
  Misses         51       51
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c3971...68156d1. Read the comment docs.

Thanks!


improvement serialize streaming agg data in the vectorized way

Proposed changes
Issue Number: close #xxx
Problem Summary
This PR will reduce the calling times of the virtual function and memory io.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

#11801 another pr contains this change


Change the orientation of the axes in the results

Greetings, I wanted to know if it is possible to change the orientation of the axes. For example to rotate the plotted result with respect to the z-axis, as the sample I study is flat, it is convenient for me that one of the axes is perpendicular to the surface for better representation of the results.
This is how the results are given

And if it were possible to orient the surface on the x- or y-axis.

Thank you in advance for your response and assistance.

There is currently no built-in way to rotate the coordinate system in the software.
However, if it is important for you that the axes are in certain orientations, you can make sure that your calibration target (which defines the coordinate system) is oriented this way when the calibration images are taken.


Replicate webhook pods for resiliency

Currently we run one replica of the webhook deployment, which makes it a single point of failure in the event of a node outage. The job doesn't do anything that requires running as a single replica, so we should investigate running multiple replicas.
We can crib from Knative Serving, which configures:

a HorizontalPodAutoscaler (HPA) to run 1-5 replicas based on CPU usage
a PodDisruptionBudget to ensure that at least 80% of replicas are available
pod anti-affinity to avoid having one node run all replicas

/kind feature

Thanks for this.
I think the pod anti-affinity will also mean that we will have one pod in case of a single-node cluster, which would be perfect as I'd like to preserve the smallest possible footprint for dev / test scenarios.

Awesome idea! This is not only true for a node outage but also heavy load scenarios for the event listeners. In one of our production environments we faced situations, where the event listener got unresponsive because no auto scaling was in place and too many requests were send to it.


[Source compatibility suite] RxReactiveObjC fails to build on main with error: 'TARGET_OS_IOS' is not defined

Description
/Users/ec2-user/jenkins/workspace/swift-main-source-compat-suite/swift-source-compat-suite/project_cache/RxReactiveObjC/.build/checkouts/ReactiveObjC.swiftpm/Sources/ReactiveObjC/MKAnnotationView+RACSignalSupport.m:1:6: error: 'TARGET_OS_IOS' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
    1 | #if (TARGET_OS_IOS)
      |      ^
1 error generated.

Reproduction

Expected behavior
Expect the project to build.
Environment
Swift main branch.
Additional information
https://ci.swift.org/job/swift-main-source-compat-suite/704/artifact/swift-source-compat-suite/FAIL_RxReactiveObjC_4.2_BuildSwiftPackage.log
https://ci.swift.org/job/swift-main-source-compat-suite/704/artifact/swift-source-compat-suite/FAIL_RxReactiveObjC_5.0_BuildSwiftPackage.log

Hi @igor-makarov !
I believe this is an actual project issue in https://github.com/SwiftPM-Packages/ReactiveObjC.swiftpm.
This error means that at the point of the check #if (TARGET_OS_IOS), the target conditional macro TARGET_OS_IOS is not defined. Before we introduced this diagnostic (-Wundef-prefix=TARGET_OS_), the compiler would silently evaluate the macro to zero, meaning the checks are not doing what you expect them to do.
To make sure that your code is built properly with the target conditional macro guards, please make sure to add #import <TargetConditionals.h> before any reference to the TARGET_OS_* macros.
(Same as https://github.com/apple/swift/issues/57554)

Duplicate of #57554


Improve code quality

Abstracted out model stub to reduce code duplication
Abstracted out CsvConverter stub to reduce code duplication
Abstracted out CsvFile stub to reduce code duplication
Added more logs

Pull Request Test Coverage Report for Build 411

9 of 16 (56.25%)  changed or added relevant lines in 5 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 59.527%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/ExportCommand.java
5
7
71.43%

src/main/java/seedu/address/ui/ImportReportWindow.java
0
2
0.0%

src/main/java/seedu/address/ui/PersonDisplay.java
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/ui/ImportReportWindow.java
1
0.0%

src/main/java/seedu/address/ui/PersonDisplay.java
2
0.0%

src/main/java/seedu/address/logic/commands/ExportCommand.java
3
84.78%

Totals

Change from base Build 408:
-0.03%

Covered Lines:
1862

Relevant Lines:
3128

💛  - Coveralls


FloatingActionButton does not hides while anchored to  AppBarLayout

Same here.

could you please tell how you anchor the fab to coordinateLayout in first place?

@tuhin10 how did you anchor it?


Zoom increase/decrease buttons on either sides of the slider

Recently, I had to incorporate a crop tool in one of our apps, looked through a few and chose cropit. It has been working fantastic since. Thank you!
BTW our UX was of the opinion that I should add a '-' and '+' buttons on either side of the slider (Like you have on home page) or else it may not be intuitive to the user. I did that outside of the plugin, but now that I think about it, it is possible to incorporate it back to the plugin. I could work on a PR and get it out fairly easily. Do you think you would be interested?

Hey @anoopelias, great to hear that cropit is working well for you, and thanks for the proposal! That definitely sounds like a good idea, but one of the principles I have for cropit is that I wanted to keep it minimal, in particular not to have CSS in it, so the user of it can style it from scratch instead of overriding the existing ones. However in my opinion, different people would most likely want to style - and + in different ways, and give them different behaviors (e.g. different zoom steps). Therefore I've exposed simple APIs to get/set zoom, which I suppose you are using, to achieve such functionality, and while it will definitely be useful to some, I would like not to have extraneous options and complex design in cropit. Hope you understand!

@scottcheng While adding - and + I saw there are a few issues to be taken care of, apart from css. Like this for example. However I understand that you don't want to increase complexity in terms of zoom step configuration etc. I also suspected it might be overkill.
Off topic: My cropit based implementation went through QA on mobile devices (Android Chrome/Firefox) yesterday and it worked like a charm. :). Absolutely no change needed.

Good point about the subtleties :+1:
Great to hear that it's working well for you! It works on mobile thanks to the kind folks on github :)


The GroupJoin generate LEFT-JOIN and don't return all result !

Steps to reproduce (SQL Server Database)
CREATE TABLE Table_1
(
ID1 int NOT NULL PRIMARY KEY,
ID2 int NULL
);
GO
CREATE TABLE Table_2
(
ID2 int NOT NULL PRIMARY KEY,
MyData int NOT NULL,
MyOtherDate nvarchar(50) NULL
/* I have multi column... */
);
GO
INSERT Table_1 (ID1, ID2) VALUES (11, 21);
INSERT Table_1 (ID1, ID2) VALUES (12, 21);
INSERT Table_1 (ID1, ID2) VALUES (13, 22);
INSERT Table_2 (ID2, MyData, MyOtherDate) VALUES (21, 11111, NULL);
INSERT Table_2 (ID2, MyData, MyOtherDate) VALUES (22, 22222, NULL);
GO
Steps to reproduce (C# Code1)
[Table("Table_1")]
public class Table_1
{
[Key] public int ID1 { get; set; }
public int? ID2 { get; set; }
}
[Table("Table_2")]
public class Table_2
{
[Key] public int ID2 { get; set; }
public int? MyData { get; set; }
public string MyOtherDate { get; set; }
}
//EFCore1-Return only two rows(?!!!)
//SELECT b.[ID2], b.[MyData], b.[MyOtherDate], a.[ID1]
//FROM [Table_1] AS a LEFT JOIN [Table_2] AS b ON a.[ID2] = b.[ID2] ORDER BY a.[ID2]
var x = db.Table_1
.GroupJoin(db.Table_2,
a => a.ID2,
b => b.ID2, (a, b) => new
{
a.ID1,
MyData = b.Select(c => c.MyData).FirstOrDefault()
})
.ToList();
Steps to reproduce (Alternative Code2)
//EFCore1-ERROR
//System.Data.SqlClient.SqlException
//The column prefix 't20' does not match with a table name or alias name used in the query.
//No column name was specified for column 1 of 't3'.
//Invalid column name 'ID2'.
//Invalid column name 'MyData'.
var y = db.Table_1
.Join(db.Table_2.DefaultIfEmpty(),
a => a.ID2,
b => b.ID2, (a, b) => new
{
a.ID1,
b.MyData
})
.ToList();
Steps to reproduce (Detect another Error)
//EFCore1-ERROR
//System.InvalidOperationException
//Operation is not valid due to the current state of the object.
var z = db.Table_1
.Join(db.Table_2.Select(r => new { r.ID2, r.MyData }),
a => a.ID2,
b => b.ID2, (a, b) => new
{
a.ID1,
b.MyData
})
.ToList();
The issue
GroupJoin in Code1 don't return all rows
Row[0]=11,1111
Row[1]=13,2222
Row[2]=12,1111 (don't return)
auto TSQL generate by EFCore1 (return three row):

Join+DefaultIfEmpty in Code2 throw an exception.
Exception type: System.Data.SqlClient.SqlException
Exception message:
The column prefix 't20' does not match with a table name or alias name used in the query.
No column name was specified for column 1 of 't3'.
Invalid column name 'ID2'.
Invalid column name 'MyData'.
Further technical details
"Microsoft.EntityFrameworkCore": "1.0.0"
Sorry for my bad English.
Thanks.

Same root cause as #6318
The projection includes columns from second join table before first hence the logic of outer key changed failed.

Issue here is:
For the case of streaming group join, we query data sorted by outer key selector. If outer element has projection from something other than outer key selector then we check for change in outer element while inner key remains the same. For the rest of cases, we assume that change in outer element will be recorded by change in outer key selector. Though that optimization fails for following query:
var query = context.Orders
    .GroupJoin(context.Customers,
        o => o.CustomerID,
        c => c.CustomerID,
        (o, cs) => new
        {
            o.OrderID,
            Name = cs.Select(c => c.ContactName).FirstOrDefault()
        }).ToList();

In above query, customer has one-to-many fk to orders so multiple orders can have same customer. While doing group join with orders being outer, change in outer element (different orders) can have same key which due to our optimization we assume to be same element. Therefore number of groups generated are not same as number of unique outer elements, rather it is equal to number of unique keys.
Therefore in this issue, we see 2 groups instead of 3.
In #6318 & #6232 , it causes to return same outer element multiple times, even though the element is changed.

Approved for 1.0.1.

fixed via #6387


Support optional fields in resource object

Per JSON API spec, attributes, relationships and links are optional. However, in Saule they are always provided. This could cause unexpected behaviors for JSON API clients such as Ember Data. And although link is a neat feature, it takes up additional space. I'm wondering if the community here is willing to make those fields optional like included?

I'm very much in favor of leaving out optional keys when they are empty. Sounds like a good feature to me.