[sync_release] check for the existing pull requests in distgit

Related to packit/packit-service#785
TODO:

[x]  regenerate requre tests

I added the check for the same description since if we do not check the same description (which contains commit hash), no change will be pushed and PR will not be updated at all.

I mean that in an oposite way..;) I wanted the orginal solution. What about others?

OK, my question was a bit different -- is it ok for us that we do push before this check? (This will update existing PR from this branch.)

We don't do push before this check. We check for existing PRs and after that we possibly push and create PR.

We don't do push before this check. We check for existing PRs and after that we possibly push and create PR.

OK, my bad...  Sorry.

I've just added a one-line change, because I noticed that the description for our new PR has newline in the end:
'Upstream tag: 0.5.0\nUpstream commit: e815c39f\n'
but the existing PRs have it stripped:
'Upstream tag: 0.5.0\nUpstream commit: e815c39f'
Therefore, the new PR would be always created, since the descriptions are not the same.

recheck


Version checking before installation

If a label contains the variable "appNewVersion", then this version will compare this version to the installed version, and only demand an installation if there is no match.

I cannot take credit for adobereaderdc, I only found the version number.


help improve ui

the ui is not very good, and i think we need to improve the ui
if you have an idea and want to improve, PR to this issue

made whole emoji-card clickable, both as closed and open, fixed padding  #64

Hi @2pai i created an new PR about this issue: https://github.com/2pai-dev/animoji/pull/115
Please let me know what do you think about it :)


remove openstack

The openstack Python packages are broken, outdated and unmaintained.
This commit removes the packages.
To do:

[ ] remove modules
[ ] remove tests

Original PR is https://github.com/NixOS/nixpkgs/pull/10399.

oslo* packages are required by tempest-lib -> sqlalchemy_migrate -> buildbot
Removing would mean a chain-reaction of removals of packages. At least buildbot received an update within the last weeks

and here we are once again, 4 months later :)
unfortunately the PR now has a lot of conflicts, i will retry what you have done 👍

Closing because #32637 is merged.


SHA512 and SHA384 HMAC SAW Tests fail on Ubuntu 14.04 LTS (Trusty)

See: https://github.com/awslabs/s2n/pull/460

@jldodds or @atomb Did you have any insight on why this might be happening? I haven't dug into the issue yet, just curious if this is a known issue that one of you might have seen before.
It seems strange that only the SHA512 and SHA384 tests would fail instead of all or none of them.

It's certainly a timeout. The only dependency that could be the cause is a clang version change, since the script uses the default OS version.
A quick fix is to shorten the list on this line (dropping a larger number) so fewer tests will run

Looks like shortening the list still results in the SAW test timing out.  https://travis-ci.org/awslabs/s2n/builds/216126922

Is it possible that its related to updating the SAW download link? https://github.com/awslabs/s2n/pull/450

It's possible that the changed SAW version made a difference. I'll look into changes in that time period and see if anything jumps out as a potential culprit.
As an alternative possibility, do you know if the version of Z3 is the same before and after the change to Trusty? Is it using an OS package, or an independent download? I looked over the log, and it looks as though it's getting stuck while running Z3. I could imagine two reasons for this: either 1) it's a different version of Z3 (particularly if it's an older one), or 2) the formula SAW is sending to Z3 has changed in some significant way.
We know that verification of the function that's failing was infeasible in some older versions of Z3.

Maybe we should add z3 --version and saw --version to the script so that we can easily see in the logs which builds we used?

that would help @danielsn. If z3 is the culprit it's because of path order problem, the scripts to download and install z3 are still being run correctly.
If it's using the build of z3 that occurs in trusty, that would certainly cause the problem we are seeing.

Using Z3 4.5.0 would be good, since it's out now. However, I can confirm that, in my own test setup, running the proofs on the latest awslabs HEAD takes longer than running the commit from when we last updated the proofs. And this is using the same versions of SAW and Z3 for both proofs. So something in the code is making the proof slower.
I took at look at the changes since then, and the only change likely to affect the difficulty of the proof is the addition of several guard functions at the beginning of s2n_hmac_init. Those changes add some extra conditions to the constructed proof terms which should be straightforward. However, performance of SMT solvers can be somewhat unpredictable.
I'm going to try running the proofs with those guards commented out to see if they are indeed the culprit.

It turns out that the faster performance I was seeing in a very old revision was misleading. That version was so old it wasn't doing any proofs of that function. ;-)
In my own Debian VM, and Z3 4.5.0, checking SHA384 takes 37m48s. That's getting closer to the limit than I'd like, but it's also more similar to what the other hash algorithms are taking. I updated the version of z3 on saw.galois.com to 4.5.0. Let's see if that fixes it.

You might also need to clear the Travis cache to see the new build
On Tue, Apr 4, 2017 at 7:04 PM Aaron Tomb<EMAIL_ADDRESS>wrote:

It turns out that the faster performance I was seeing in a very old
revision was misleading. That version was so old it wasn't doing any proofs
of that function. ;-)
In my own Debian VM, and Z3 4.5.0, checking SHA384 takes 37m48s. That's
getting closer to the limit than I'd like, but it's also more similar to
what the other hash algorithms are taking. I updated the version of z3 on
saw.galois.com to 4.5.0. Let's see if that fixes it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/s2n/issues/467#issuecomment-291666310, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEL6jrAVi3r69WP6-ne5N8nfVRSe8qcdks5rssyBgaJpZM4MsGGh
.

It looks as though all of the SAW runs are faster now, and none time out (although SHA512 is getting close to the limit). Unless I'm missing anything, this issue should be resolved.

Cleared Caches and restarting https://travis-ci.org/awslabs/s2n/builds/217408360

Looks like the SHA512 SAW test still times out (https://travis-ci.org/awslabs/s2n/jobs/217408373#L500).
Also, saw that the install_ubuntu_dependencies.sh script takes ~7 minutes to install GCC 6 and printed this line: Fetched 200 MB in 5min 44s (582 kB/s). Looks like downloading GCC 6 by itself takes over 5 minutes by itself, which is disappointingly slow.
I had a couple of ideas on how to speed things up:

Is GCC6 required for the SAW tests, or are there any workarounds to use a lower version of GCC that is already installed on the host?
I see from the Travis Docs that they say Do not run apt-get upgrade as it downloads up to 500MB of packages and significantly extends your build time., but from the script output it says 15 upgraded, 71 newly installed, 0 to remove and 170 not upgraded..  We may be able to get a few extra minutes if we don't upgrade existing dependencies that are already present on the host. I believe if those dependencies are in the .travis.yml file it might only install new dependencies and not upgrade existing dependencies, but I may be wrong. Can we try moving GCC 6 dependencies back to the .travis.yml file to see if it speeds things up?
The list of numbers in the SHA512 Test is [1,10]. Is running the SAW Tests with 10 prove a superset of running it with 1? If so, can we remove 1 and leave 10?

I am running a test now to see what happens if we have no gcc6 installed ...

It should work without GCC6. SAW works on the LLVM bitcode generated by Clang.

It got so close to finishing the SHA512 proof this time, but not quite.
Unfortunately, the 1 and 10 proofs don't really overlap in what they test. We already reduced the list from a somewhat longer one, which was somewhat unfortunate.
It's possible that point 2 from your list above could be enough to get it to go through (at least usually?).

Should I push a PR to remove gcc6 from the SAW tests, or wait until you've
tested the other options?
On Wed, Apr 5, 2017 at 5:43 PM, Aaron Tomb<EMAIL_ADDRESS>wrote:

It got so close to finishing the SHA512 proof this time, but not quite.
Unfortunately, the 1 and 10 proofs don't really overlap in what they
test. We already reduced the list from a somewhat longer one, which was
somewhat unfortunate.
It's possible that point 2 from your list above could be enough to get it
to go through (at least usually?).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/s2n/issues/467#issuecomment-292006257, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEL6jgVssyUYiZVrX43wigbHslhRmzeRks5rtAr_gaJpZM4MsGGh
.

I think it makes sense to remove gcc6 from the SAW builds regardless. It's not needed, so no reason to include it.
Something running in debug mode seems unlikely. The version change in SAW could potentially have an impact. It's a little hard to say. I've looked at the revision history a bit, and nothing jumps out as something that would dramatically change performance.
One very slightly change is that we just moved saw.galois.com to a different location within the network, meaning that it's on a gigabit connection now. So fetching SAW and our cached Z3 build should be quick(er?).

I don't think our issue here is related to fetching Saw/Z3. Looking at a slow build shows most the 50 minutes are spent running the verification: https://travis-ci.org/awslabs/s2n/jobs/219927862#L400 .
We know this behavior was introduced when we moved all builds to trusty. A path forward could be to use trusty only on builds that require it(ctverif) and use precise for everything else.

Gave it a shot https://github.com/raycoll/s2n/commit/d5cb39afec37a3f125b677008d10d58296850973 . https://travis-ci.org/raycoll/s2n/builds/220160526 . SAW builds back down to previous execution time.

If sticking with precise for SAW for now solves the problem, I'd say we go with it for now. I'm soon going to make some major changes to the HMAC verification (see #478), and I'm hoping it'll speed things up as a side effect.


Targeted User for internal StreamPipes notification sink

Body
The InternalStreamPipesNotificationSink contained that following inline TODO which is replaced by this issue.

// TODO add targeted user to notification object

StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

Hi @bossenti , I see that targetedAt is already set to correspondingUser on the notification object. Could you add some background information about this issue and what changes are expected to be made?

TBH, I haven't checked if this already implemented. I just wanted to replace the TODO comment with this issue. If the the TODO is already implemented, we can close this issue 🙂


/say show Console instead of your name

Is intended. Use /g to talk in the global chat showing the sender name.

ok, i can use /bc for importat message.


Bug: Scheduler thinks there are pending jobs, but none exist

Environment:

AWS ParallelCluster 2.5.0

Bug description and how to reproduce:
We have apparently had a parallelcluster instance spinning up nodes endlessly for the past two months, with logs like this:
2020-05-04 11:47:18,858 INFO [slurm:get_required_nodes] Found the following pending jobs:
[]
2020-05-04 11:47:18,858 INFO [jobwatcher:_poll_scheduler_status] There are no pending jobs or the requirements on pending jobs cannot be satisfied. Noop.
2020-05-04 11:48:18,805 INFO [utils:get_asg_settings] ASG min/desired/max: 0/4/10
I'm happy to provide any additional data; I'm posting this now to get the chance to do that before shutting things down.  Instead, I've set the autoscaling group to do a max of 0 nodes, since this has run up costs around $3K/month when we weren't actually using nodes.
Previously this environment has worked without issues - has anyone seen 'ghost' launches of nodes like this before?  Is there any idea what the culprit might be?  We're currently using Slurm, with customized AMIs.
I'm happy to attach fuller logs.
Thanks!

Brian

Hi,
Please double check that you are not setting maintain_initial_size = true.
To help us diagnose the problem, please attach the following config/logs:

config file used to launch the cluster
/var/log/jobwatcher log from master node
/var/log/sqswatcher log from master node
/var/log/nodewatcher log from one of the compute nodes that did not terminate

Thank you.

Hi Brian,
I have noticed this in our setup. We do have  maintain_initial_size=true in the configuration file.
thank you,

Hi,
maintain_initial_size=true is used to keep the initial size of compute nodes alive and available.
For example, if you have initial_queue_size=4 and maintain_initial_size=true, the cluster will keep 4 compute nodes up at all time.
Please remove maintain_initial_size=true from your configuration if you want all compute nodes to scale down when they are idle.
You can also use scaledown_idletime to control how long the compute nodes should wait before scaling down after they are idle.
I will go ahead and close this issue now. Please let us know if you have any open question.
Thank you!


SQL Lab: widen left panel, limit type width

I used the feature to create issue from comment on GitHub, bypassed the template
@yousoph the bug is fixed, but the left panel still seems too crowded. I think the sql editor doesn't need that much of the space, but your call!

Originally posted by @junlincc in https://github.com/apache/incubator-superset/issues/11715#issuecomment-728641732

Some ideas:

increase the left panel width by ~33%?
map long type names like TIMESTAMP WITHOUT TIME ZONE to something like TIMESTAMP... with details on hover?

@mihir14 what's the width are you setting? for the left panel in Explore(Data type fields + control)?
i suggest to keep the left panel spaces in Explore and SQL lab the same!
@mistercrunch

For explore it's a responsive grid. For SQL Lab it's fixed I think

We should make both resizable just like the SQL editor + result pane. Was actually working on that over the past weekend.

can we coordinate to make that change?

It was just an idea I've been wanting to do for a while but never committed to doing it. Feel free to create another github issue or roadmap item if you feel it's necessary.

im trying to figure out a good timing to discuss major changes on those panels. @rusackas and I wont be able to dive deep  into until mid December, i also want to do a more throughout product discovery before our discussion. +1 on resizable though!

Agreed that resizing would be a good first step!
For the SQL Lab panel, I think it's worth revisiting how the column types are displayed (max character limit for column types, font styles, etc)


ignore fields containing LookupId while creating list items

New field came up while testing: AppAuthorLookupId
Ignores fields containing LookupId while creating list items.
Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :bug: Bugfix

Issue(s)
#4754
Test Plan

[x] :muscle: Manual
[x] :zap: Unit test
[x] :green_heart: E2E

closing, this change was made part of #4923


The command "sort" already exists. error

On newer Poetry versions, I'm getting The command "sort" already exists. error upon installing this plugin, and Poetry stops working at all. On older Poetry versions, it worked correctly.
I confirmed this for 1.7 and 1.8, with multiple reinstalls, on both Linux Ubuntu 22.04 and Windows 10.

I can confirm it causes Poetry to go into an unusable state where any poetry command cannot be run, somebody else mentioned it here: https://github.com/python-poetry/poetry/issues/6456


Update sbt-scoverage to 1.6.0

Updates org.scoverage:sbt-scoverage from 1.5.1 to 1.6.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.scoverage", artifactId = "sbt-scoverage" }]

labels: semver-minor

Codecov Report

Merging #41 into master will decrease coverage by 10.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #41       +/-   ##
==========================================
- Coverage   99.16%   88.3%   -10.87%
==========================================
  Files          11      17        +6
  Lines         120     265      +145
  Branches        9       6        -3
==========================================
+ Hits          119     234      +115
- Misses          1      31       +30

Impacted Files
Coverage Δ

...la/io/circe/tests/examples/CardinalDirection.scala
0% <0%> (ø)

tests/src/main/scala/io/circe/magnolia/tags.scala
100% <0%> (ø)

...cala/io/circe/magnolia/CodecEquivalenceTests.scala
100% <0%> (ø)

...o/circe/tests/examples/WrappedOptionalString.scala
0% <0%> (ø)

...c/main/scala/io/circe/tests/examples/package.scala
93.25% <0%> (ø)

...sts/src/main/scala/io/circe/tests/CirceSuite.scala
85.71% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b98e0...6edf540. Read the comment docs.


Refine DDD mapping into Clojure

Hi!
My goal was to investigate how DDD ideas are projected into Clojure programming language and i found your codebase.
During investigation i've made changes which imho clarify the exact mapping of DDD into Clojure:

slightly decrease number of used concepts preserving original approach of distinguishing between events and their application
core logic assembled in domain services, domain model was distilled to pure specs checking structure and invariants defined upon it
if keyword intersects module boundary then use only namespace qualified keywords in that case

Pull request is rather large, i decided that there is no sense to make smaller steps without having coherent picture of the final result.

Cool, I'll have a look at it when I have time. It might take me a week to get to it though.


Activity commands

Adds the ability to send commands based on the activity. For example direction-up will usually exist in many activities but will be mapped to different devices. This means sending POST /hubs/:hub_slug/current_activity/direction-up will send direction-up (if it exists in the activity) to whichever device is most appropriate for that activity.

Excellent PR, just what I was looking for. Checked out the PR locally and it works perfectly.


Embed mountebank source so we can own code scanning and updates

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I tested this with the fluent bit mountebank example that @matthewfala has and the mock still works.


Increasing max length of MI instructions to 4000

@divman25,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


🐈 Yarn task

It seems there is no Yarn task. Please add and option argument to npm task to choose npm client or separate task.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c00d3b8-64c1-9f1b-83f8-62d8cf07817b
Version Independent ID: 5fcdebed-cfb8-c5a6-d807-1315b2db5e57
Content: npm task - Azure Pipelines
Content Source: docs/pipelines/tasks/package/npm.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vijayma
Microsoft Alias: vijayma

Thanks for the suggestion! The product teams aren’t always watching this repository, so to make sure it gets in front of them for triage, please submit your idea here.


Any support to linux/s390x?

Any support to linux/s390x? Thanks

You need to try rebuild images and check for yourself, because I don't have or use s390x.


Notebooks 2.0 // Frontend // Setup Basic Spawner App

For this issue I will be adding a PR to get the basic app setup and correct directory structure with a proper package.json. I will also include a follow up PR to add cypress to the project for our UI testing.

Thanks Griffin! Looking forward to it!

We can close this now with https://github.com/kubeflow/notebooks/pull/73


How to disable swap?

Using 4.4.126-rockchip-ayufan-239 Bionic minimal.  I am able to turn swap off using swapoff -a but every time the node gets rebooted the swap seems to come back.  Is there a good way to permanently disable swap?

Think I found my answer,  sudo systemctl disable zram-config.


Templates fail installing

MacOS Big Sur 11.6
Running the first line of the example script dotnet new -i TryPhotino.VSCode.Project.Templates does not work and failes with a
$ dotnet new --install TryPhotino.VSCode.Project.Templates::2.0.1
The following template packages will be installed:
   TryPhotino.VSCode.Project.Templates::2.0.1

Warning: Failed to download TryPhotino.VSCode.Project.Templates::2.0.1 from NuGet feed https://api.nuget.org/v3/index.json.
TryPhotino.VSCode.Project.Templates::2.0.1 could not be installed, download failed.

Also the template repository seems to have been removed from github?

@mika76 The template repo is still on GitHub. It hasn't been modified or removed. As far as the error you're seeing, perhaps it's a transitory issue with NuGet.org? Try navigating your browser to  and see if it opens the file. It does for me.

If you go to https://www.nuget.org/packages/TryPhotino.VSCode.Project.Templates/ and click on the Project repository it tried to go to https://github.com/tryphotino/PhotinoSamples.VSCodeTemplates which gives a 404 also...

@mika76 Interesting... it works for me. Where are you located?

@mika76 Apparently, it's set up as a private repo. I will look into that.

Serbia, but I've never experienced location being an is die. Maybe some permission is set?

@mika76 Apparently, it's set up as a private repo. I will look into that.

Ah good stuff 😊

@mika76 Yes, that project and the VS Extension project are set up as private. There really isn't any source code in there as they're just packaged versions of the sample apps. We meet on Thursdays, so I'll bring this up Thursday and see if there is a reason to not make these public. Were you able to get the NuGet package? That's the most important thing and unrelated to this issue.

I'll try it again in a bit and let you know...

Interesting, works on my Windows VM but not on the Mac. Probably some setting on my side...

FYI: https://github.com/dotnet/templating/issues/4176 - managed to get a verbose output using an environment variable (wish I knew about this before) - seems it's my .templateengine directory permissions which are making it fail for all template installs. So nothing on your side.
Thanks for you help @MikeYeager


ESLint and dependency issues

I've encountered two issues with the starter-app, out of the box:

There seems to be some problem with ESlint extending next/core-web-vitals

Updating ESLint to 8.23 comes with other problems.
I haven't been able to find a way around it.

Running npm i throws Conflicting peer dependency..

I was able to solve this by running npm i --legacy-peer-deps .
Might still be worth looking into it, since the --legacy-peer-deps flag is always required going forward (when installing other packages etc)
===
PhpStorm 2022.2.1
Build #PS-222.3739.61, built on August 18, 2022

For the ESLint error, I've create https://github.com/contentstack/contentstack-nextjs-starter-app/pull/46 PR.
The project still has warnings that should eventually be fixed.

Hi @Cry0nicS, thanks for pointing out the fixes needed for our nextjs starter. We added you PR changes to this latest release. So I am closing this issue for now


[ISSUE #4667] Fix some connectors have not been included in the package

Fixes #4667
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Fix Some connectors have not been included in the package

Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Dependencies check failed. Please add known dependencies.


[17.03.x] Correct CPU usage calculation in presence of offline CPUs and newer Linux #31579

LGTM

@tiborvass PTAL

exp unrelated.


find in is grouping results

index.find with in should return grouped results?
If there are multiple rows for searching value, it's returning only first one for each provided value.
for example
cat_id post_id
1         2
1         3
1         4
Searching via cat_id index with cat_id 1 will return only first row with post_id:2.
It's a bug or a feature?
It's not functioning like mysql WHERE IN(cat_id,cat_id,cat_id) etc?

Guess project is dead.


Parsing error on jsx.

Hi folks,
I have a parsing issue with some jsx:

My script tag has lang="jsx", my eslint config is the following:
module.exports = {
  root: true,
  env: {
    browser: true,
    node: true,
  },
  extends: [
    '@nuxtjs/eslint-config-typescript',
    'plugin:nuxt/recommended',
  ],
}

Do you have any idea of what could be the problem?
Thanks!

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Does the cpp2sky support cross compile？

Does the cpp2sky support cross compile？I want to build for arm64 linux platform with linaro gcc，if supported，where can I find the guide or cross-configure files？
thanks！

@Mingyiz I'm not sure about linaro gcc (but this works on GNU gcc) and not checked about arm64-linux. (also I don't have arm64 environment....) We are welcome to your contribution of documents and also some addition to support arm64!


Expose async queue method

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Exposes the async queue so that in unit tests I can drain it to make sure all items in the queue are processed
Verification

Maybe we could drain the queue in the Stop method? This way we don't need to expose a method for the sake of testing.

@fpetkovski My usecase is to make sure the items in the queue are consumed, not just drained... I feel like it is something that is outside of the Stop method.

I am also wondering why the async queue is never closed even when we stop the queue. https://github.com/thanos-io/thanos/pull/6946/files#diff-c31aaadfff8004fc92e97126b0bb221b72cf66e1bb5036cdd25c75614979e03fR42
Can I close the async queue in Stop method?

@yeya24 do you still want this merged?


Almost the last part of a modern WordPress development

Hi!
Here is Matthew from Germany. Believe me, in many years I have gained a lot of experience regarding modern development in the ecosystem of WordPress. It is always difficult for developers to maintain multiple plugins. I have an Open-Source solution for all developers out there: WP React Starter. WP React Starter is built on top of all modern web development tools ported to the WordPress economy.
Why do I open this issue?
I just ran into the problem that there can be different dependency versions between plugins (in relation to Composer). I have found your solution and think:
Lets marriage imposter with wp-react-starter
Are you open to work together to make this work? Due to the fact that WP React Starter is working a lot with traits I need to get this work before I implement it into my open source project. Reference: https://github.com/TypistTech/imposter/issues/111
Please let me know what you think!

wp-react-starter looks awesome.
I presume you want to add imposter to the plugins (https://devowlio.gitbook.io/wp-react-starter/advanced/create-package). Am I correct?
Considerations:

Adding imposter introduces complexity
If you control all the plugins, making all plugins use the same package version is a better choice (i.e: let the root composer.json determine which version to install)
Imposter is far from perfect, we might need to invesgate a real PHP praser, see: https://github.com/TypistTech/imposter/issues/101

Anyways, let a comment here if you encounter difficulties integrating imposter with wp-react-starter

Hi again!
Thanks for your words. The last few days I intensively worked on scoping WordPress plugins and found an ultimative way of doing this. I introduced PHP-Scoper to my boilerplate as imposter did not work for me (one reason was #151).
If you or someone else is interested, the boilerplate documentation can be found here.
@TangRufus Behind the scenes, the most important part of scoping are stubs: https://devowlio.gitbook.io/wp-react-starter/php-development/add-classes-hooks-libraries#stubs
Regards,
Matthew 🙂


Feature/refresh token frontend

Overview
Add basic unstyled token page for token creation and viewing
Notes
There isn't a prototype for this part of the application, so I've left the functionality / styling as minimal as possible.
Testing Instructions

Go to the settings view
Go to the Tokens view
create a token
refresh the page to verify that state is persistent
delete a token
refresh the page to verify that state is persistent

Depends on #568 (only second commit is relevant for this PR, it will be merged after #568)
Discovered #573

Clicking "Cancel" in the "Delete Token" popup does not close the dialog

retrieving a token is treated by auth0 as a form of login (it uses the same endpoint), and that requires either a username/password in the request, or a redirect to a login page. I haven't been able to figure out a way around it.

Got it. I just wanted to confirm. I think it looks good (as in, secure) if we ask for the user to authenticate themselves before getting a refresh token.
Taking another look at the modal and the spinner.

just rebased onto develop and squashed commits - no changes as far as testing

When I cancel out of the delete token modal, I see the following message in the console:
error deleting refresh token undefined

Otherwise this looks good. +1

fixed the debug message - forgot the second callback is when the cancel button is clicked, not when there's a failure.


Improve for none English

Thanks for the nice app. It works perfectly with whisper-large-v2. However, when I try to talk to it by Japanese, it automatically translate to English. I wonder you can keep the text as original language other than translate it?

Hi @cicerolms, thank you for using the app and for the feedback!
I've now pushed a new version of the program that explicitly assigns a transcription for the speech, and from my tests, it seems to work now.
I also want to add an option that lets you pick to translate your speech if ever need be.
Let me know if this issue still stands with you.


Slight change in documentation's example

Hi Mika and thanks for the great software,
It's not an issue per se, but if you'd like, update the documentation for the custom Authenticator, so that the __invoke method is declared with a return type.
class RandomAuthenticator implements AuthenticatorInterface {
    public function __invoke(array $arguments) : bool {
        return (bool)rand(0,1);
    }
}

Cheers!

Good catch, thanks!


Review all.sh for tests that use gcc or -O0 where they don't need to

Probably many tests still use gcc (as opposed to clang) or -O0 (or nothing specified, as opposed to -O2), where there is not a particular reason to do so. Review for tests where we can improve this. Tests where we actually run output built with -O0 will have the most impact.

-O0

We only test with -O0 once per compiler (and not for all compilers).

nothing specified, as opposed to -O2

For make, the default is -Os. For CMake, the default is -O0, but it's -O2 with CMAKE_BUILD_TYPE=Release, -O3 with CMAKE_BUILD_TYPE=Asan and -Os with CMAKE_BUILD_TYPE=Check. We almost always pass a build type to CMake in all.sh but there are a few exceptions and it's Check in a couple of places.
For build-only components, we should use -O1. (-O0 is faster, but misses some static analysis that GCC or Clang can perform.)
Arguably -Os should not be the default. It's what a lot of our users want (in the microcontroller space), but those users typically pass -Os explicitly anyway, because they know they want to optimize for size. Linux distributions and such are more likely to use default settings and would be better served by -O2 or -O3. But that's a separate debate.


VoyageAI vectorizer and reranker

@fzowl there are tests failing in our test matrix, can you address them before the branch goes stale?

@bsbodden The failed tests seem to be related to GCP credentials, not during the code tests but during the Authenticate to GCP step, which is in your control, I believe. Can you please help me out with what the issue could be here?

Will take a look and see if we can get this wrapped up, thanks team!

@tylerhutcherson Thank you!

@tylerhutcherson Any progress on this? Is there anything i can help?

FYI @fzowl im working on fixing tests over here: https://github.com/redis/redis-vl-python/pull/223
will merge when I have it all working. Needed to address the lockfile, formatting/linting, and one other thing.

@tylerhutcherson Thank you very much! I was struggling a bit with the lockfile, i tried to update it but it was hanging every time for me. Thank you very much for your help!

@tylerhutcherson Thank you very much! I was struggling a bit with the lockfile, i tried to update it but it was hanging every time for me. Thank you very much for your help!

No problem! We're happy to support more integrations, and sorry this took so long. We just had a slew of customer requests we needed to focus on first. @fzowl I will close this PR in favor of the other, and plan to release soon. Will VoyageAI do any kind of announcement about the new integration or maybe host an example in your docs? That would be rad.

@tylerhutcherson Yes, i will add RedisVL to our integrations in our site.
I have one more question, is the API documentation automatically generated or shall i extend with VoyageAI? (https://www.redisvl.com/api/vectorizer.html)


Build docs warnings

I just followed the instructions here on my Ubuntu 16.04 PC, and when I run make doc I get a whole load of scary-looking warnings displayed in my terminal (in red), along the lines of:
Running Sphinx v1.8.4
making output directory...
loading intersphinx inventory from https://docs.python.org/3.5/objects.inv...
loading intersphinx inventory from https://picamera.readthedocs.io/en/stable/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
WARNING: intersphinx inventory 'https://picamera.readthedocs.io/en/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: ('intersphinx inventory %r not fetchable due to %s: %s', 'https://picamera.readthedocs.io/en/stable/objects.inv', <class 'requests.exceptions.HTTPError'>, HTTPError(...))
loading intersphinx inventory from https://colorzero.readthedocs.io/en/stable/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
WARNING: intersphinx inventory 'https://colorzero.readthedocs.io/en/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: ('intersphinx inventory %r not fetchable due to %s: %s', 'https://colorzero.readthedocs.io/en/stable/objects.inv', <class 'requests.exceptions.HTTPError'>, HTTPError(...))

Am I missing some dependency, or are these harmless warnings that can be ignored?

@waveform80 has done considerable work in the docs-tidy-up branch recently. I think most/all such warnings  will have gone away now.

Yup, switching to the docs-tidy-up branch gets rid of the intersphinx warnings :+1: Sorry I didn't try that earlier!
But there's now a red warning that copying static files... WARNING: html_static_path entry '/home/qpc/python-gpiozero/docs/_static' does not exist ?

Does this being closed imply that the warning is indeed harmless? :)

I believe so

It is harmless, but I fixed it anyway in a commit just before release (just added a placeholder file as git won't track empty dirs).


[Bug]: Device disappears, auto-removed after 1 missed ping

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Zwavejs2Mqtt version
5.4.2
ZwaveJS version
8.0.5
Describe the bug
A qubino shutter device just disappered from the list of tracked devices.
Looking through the logs, about half a day before I noticed, the device didn't respond to a ping and was pronounced dead. The device still worked properly when directing it from a button, so it wasn't offline or anything.
Exactly 10 minutes after presuming the device dead, zwavejs clean up all the entries related to it and removed the device altogether. I can't imagine why it would do that just because of 1 failed ping.
Here are the logs:
[In the beginning it works as usual]
2022-05-04 05:16:33.135 INFO ZWAVE: Node 55: value updated: 38-1-currentValue 0 => 89
2022-05-04 05:17:25.226 INFO ZWAVE: Node 55: value updated: 38-2-currentValue 99 => 0
2022-05-04 05:17:33.971 INFO ZWAVE: Node 55: value updated: 38-2-currentValue 0 => 0

[Here we miss one ping and the device is marked dead]
2022-05-04T05:17:55.358Z CNTRLR   [Node 055] Node 55 did not respond after 1 attempts, it is presumed dead
2022-05-04 05:17:55.361 INFO ZWAVE: Node 55 is now dead
2022-05-04T05:17:55.379Z CNTRLR   [Node 055] ping failed: Node 55 did not respond after 1 attempts, it is presum

[Here at exactly 10 minutes later (down to 150ms, so must be automated task) all the device entities are removed and the device itself it also removed]
2022-05-04 05:18:05.550 INFO ZWAVE: Node 55: value removed: 114-0-manufacturerId
2022-05-04 05:18:05.552 INFO ZWAVE: Node 55: value removed: 114-0-productType
[... lots of removed entities ...]
2022-05-04 05:18:05.810 INFO ZWAVE: Node 55: removed

If you're curious, here are the entire lifetime logs for this entity.
Seems to match the issue reported in https://github.com/zwave-js/zwavejs2mqtt/issues/1293, though I think there the user didn't have any logs to back up the issue with.
To Reproduce
No idea
Expected behavior
If a node goes dead for whatever reason, it should most definitely not be removed. Now I've no idea even what to do, I have to somehow unpair and repair them? Get new device IDs, redo all the itegrations, it's a horribly place to be at. Zwavejs should never ever ever just auto-delete stuff.
Additional context
No response

FWIW, the removal happens 10 seconds after the node is dead.
Z-Wave JS definitely doesn't remove devices on its own, except when the device itself sent a Device Reset Locally Notification, which means the device has been factory reset by physical interaction and is de facto no longer a part of the network.
Unfortunately, this is impossible to diagnose without driver logs, since the application logs don't include any Z-Wave traffic.

Well, this was at 5AM in the morning, so pretty much nothing happened then, nobody touched it, nor did any autmations run that could have triggered it. Is there a way to enable/collect driver logs so maybe we can have it available next time?

zwavejs2mqtt lets you write driver logfiles which are rotated every 7 days by default.

Alright, I'm going to close here then. When you have something new, feel free to reopen.

I still think there's a fault somewhere which caused an error to be escalated into exclusion, since everything was idle. But yeah, not much more information to say.


Incorrect Color Tag parsing of \c

When a Color Tag with prefix \c is passed into Tag.parse(), it turns into a \1c tag instead.
How to reproduce
import pyass

text = r"\c&H000000&"
tag = pyass.Tag.parse(r"\c&H000000&")
test = str(tag)
print(f"Original Tag: {text}\nPost-parse Tag: {test}")

Output:
Original Tag: \c&H000000&
Post-parse Tag: \1c&H000000&

I'm aware that \1c and \c are the same tag internally, so maybe this is a non-issue.

Fixed in v0.1.4, please update to the latest version


App Author and User published but in Author cannot send message, select groups nothing

We have published both apps, but when we are trying to test them, the Author app cannot send message, select any groups, cant do nothing.
Is there any documentation that explains how can we use the apps?

Hi @binruis ,
Thanks for raising the query. Could you please confirm on the below points.

There are multiple possibilities for this 4th sending issue,  please cross-verify the set-up authentication steps done for graph app correctly or not. Especially check for supported account type should be- My Organization  for graph app.
Author app- Multiple Organization
User app- Multiple Organization

Is there any documentation that explains how can we use the apps?
You can find the detailed information on the features available in Company Communicator app in this section .

hello @gsv022
About the first point, we cannot select any group in any option, and about the second point, we checked the manifest and looks good

@binruis ,Could you please share the screenshot of graph app registration overview section.

yes here is the overview

Hi @binruis ,
Mostly the issue is coming due to incorrect configuration only. Please share the author app-home page screenshot.

by home page u mean sharing you the overview of author registration?

Hello @gsv022  any advacements about the issue?

Hi @binruis ,

You have published the app on teams right! please share the screenshot of landing page of CC- author app.
Could you please share the deployment status of app service. Here is the reference.

Hello @gsv022  here are the screenshots

Hi @binruis ,
After adding the author app to the team, please share the screenshot like below


create counter app and fetch user list from dummyapi

Hi Sir,
There is a default third-party library included in Create React App
specifically reportWebVitals. I have not removed it.
Thank you
On Mon, Sep 25, 2023 at 6:48 PM Chan D @.***> wrote:

@.**** commented on this pull request.
In counter-app/src/reportWebVitals.js
https://github.com/Zenith-Legion-Interactive/react-developer-test/pull/3#discussion_r1335716938
:

+const reportWebVitals = onPerfEntry => {

if (onPerfEntry && onPerfEntry instanceof Function) {
import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {

 getCLS(onPerfEntry);

 getFID(onPerfEntry);

 getFCP(onPerfEntry);

 getLCP(onPerfEntry);

 getTTFB(onPerfEntry);

});
}
+};

+export default reportWebVitals;
@nixvigilia https://github.com/nixvigilia May I know why is this added?
—
Reply to this email directly, view it on GitHub
https://github.com/Zenith-Legion-Interactive/react-developer-test/pull/3#pullrequestreview-1641860655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIG7EYNIYEF6CDZ4NPIP3YDX4FOQTANCNFSM6AAAAAA5AJEWBM
.
You are receiving this because you were mentioned.Message ID:
<Zenith-Legion-Interactive/react-developer-test/pull/3/review/1641860655@
github.com>

@nixvigilia I have another task for you to complement this assessment.
Kindly check the other PRs on this repo, see if you can improve yours better than what they submitted.
Good luck.

Hi Sir,
Got it, will check.
Thank you!
Regards,
Nix
On Tue, Sep 26, 2023 at 11:56 AM Chan D @.***> wrote:

@nixvigilia https://github.com/nixvigilia I have another task for you
to complement this assessment.
Kindly check the other PRs on this repo, see if you can improve yours
better than what they submitted.
Good luck.
—
Reply to this email directly, view it on GitHub
https://github.com/Zenith-Legion-Interactive/react-developer-test/pull/3#issuecomment-1734785312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIG7EYIEM7X5DI4BRACUWJDX4JG6ZANCNFSM6AAAAAA5AJEWBM
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Hi @ProteanDev,
As requested, please see the pull request #10 for your review. Thank you!

hi @ProteanDev, kindly disregard my previous message above. This branch has been updated for your review and approval, please. Thank you!


[Bug Report] Show password event move cursor to start of input

Element UI version
2.15.1
OS/Browsers version
Linux/Google chrome Version 89.0.4389.82
Vue version
2.6.12
Reproduction Link
https://jsfiddle.net/wanwas/topz1nhb/
Steps to reproduce

enter something in the field
click on show password icon

What is Expected?
After the click, it appears at the beginning of the input.
What is actually happening?
After the click, the cursor must remain in place (after the last character entered)

you kan see this issues
https://github.com/ElemeFE/element/issues/18573


Move devDependendies to dependencies for xstate-wallet

The xstate-wallet is used by apps for e2e-tests. It is consumed as a dependency and then run by starting a webpack dev server. So, it actually uses webpack dev server related dependencies for its purpose as a distributed package right now.

@statechannels/xstate-wallet: $ yarn build
@statechannels/xstate-wallet: $ node scripts/build.js
@statechannels/xstate-wallet: Creating an optimized production build...
@statechannels/xstate-wallet: Treating warnings as errors because process.env.CI = true.
@statechannels/xstate-wallet: Most CI servers set it automatically.
@statechannels/xstate-wallet: Failed to compile.
@statechannels/xstate-wallet: /static/js/2.66a136e7.chunk.js is 6.88 MB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
@statechannels/xstate-wallet: error Command failed with exit code 1.

on CircleCI, don't know why.


Close #LGVISIUM-94: Renaming of the output from create png api path

As the API is returning the key within the S3 bucket where the created PNG file is stored, it felt necessary to adapt the naming in the API response as well to avoid any type of confusion regarding what is returned.

@flenny  do you think you can adapt the borehole application to cope with this future change?

@stijnvermeeren-swisstopo, thank you for your feedback. I made the required changes and re-ran the tests to see if everything was alright.


build: drop unused files (PROOF-642)

Remove files from legacy build we don't use anymore.

:tada: This PR is included in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Small markups on API usage

Hi, feel free to use/edit/ignore in any combination which pleases you!

Hi,

I don't think this kind of language specific definition should be present in this generic documentation

I'm an old standards guy--the generic goal resonates, but the world has really focused down to a few languages which are basically the modern latin. If you talk Python and JS, all the C/Rust/C#/Lisp/etc. people know exactly what you mean. I included JS because it's the 1,000 pound gorilla, and their coders tend to be some of the weakest. But don't quote me.
OTOH, you could ignore me and spend the time fleshing out some Python and JS examples, and that might be the clearest way to document it. At a minimum, I suggest making it clear it's an integer value of seconds (the Python people will for sure be lobbing float's at you).
Thanks,
Andy
September 10, 2020 5:22 PM, "David Norman"<EMAIL_ADDRESS>(mailto:notifications@github.com?to=%22David%20Norman%22%20notifications@github.com)> wrote:
@normand1 commented on this pull request.
In README.md (https://github.com/Podcastindex-org/docs-api/pull/7#discussion_r486703305):

> @@ -6,11 +6,11 @@ These are the required headers for each request: * "**User-Agent**" - Please identify the system/product you are using to make this request. -* "**X-Auth-Date**" - The current unix epoch time as a string. 5 minute window. +* "**X-Auth-Date**" - The current unix epoch time as a string. 5 minute window. If accessing from Python, use only the integer portion of the time value. Note that JavaScript's time value from a Date's getTime() is compatible, but needs to be scaled down by 1,000 before also being converted to an integer.

This is true, but I don't think this kind of language specific definition should be present in this generic documentation at the top-level. Maybe there's a way to phrase this that would be more generic?

"The current unix epoch time (seconds since the Epoch) as a string"

That would hopefully signal to users they should use the rounded to the nearest second representation of epoch time which would solve the issue for both JS and Python users.

—

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/Podcastindex-org/docs-api/pull/7#pullrequestreview-486394775), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAM22KJ5DB2G54SHJYHX5GDSFFUS7ANCNFSM4RF4PRKQ).

#1 OK! :)
#2 thanks
#3 it wasn't a hassle I had here, but it is a hassle I've had in past lives
Thanks again,
Andy
September 10, 2020 5:29 PM, "David Norman"<EMAIL_ADDRESS>(mailto:notifications@github.com?to=%22David%20Norman%22%20notifications@github.com)> wrote:
@normand1 commented on this pull request.
In README.md (https://github.com/Podcastindex-org/docs-api/pull/7#discussion_r486705080):

> * "**X-Auth-Key**" - Your API key string. -* "**Authorization**" - A SHA-1 hash of the X-Auth-Key, the corresponding key secret and the X-Auth-Date value concatenated as a string. The resulting hash should be encoded as hexadecimal value. +* "**Authorization**" - An SHA-1 hash of the X-Auth-Key, the corresponding key, secret and the X-Auth-Date value concatenated as a string. The resulting hash should be encoded as a hexadecimal value, two digits per byte, using lower case letters for the hex digits "a" through "f".
* If you pronounce SHA-1 like the Iranian Monarch (as I tend to) then the original grammar here is correct I believe.
* Adding the a is a good idea.
* I'm not sure that the final addition is necessary, I haven't run into a problem with using SHA-1 yet, is that an issue you had?
—

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/Podcastindex-org/docs-api/pull/7#pullrequestreview-486396814), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAM22KNOBP2C6Q5U4PLLZ2TSFFVNRANCNFSM4RF4PRKQ).

@vandys

At a minimum, I suggest making it clear it's an integer value of seconds (the Python people will for sure be lobbing float's at you).

I absolutely agree with this, I ran into the same issue.
If you wanted to make those couple tweaks to the Pull Request I'd be happy to give this a thumbs up!

Ok, let me be sure which couple of tweaks.  int-ness of time, got it.  Case of hex?  And "as [a] hex...".


Supporting async when filtering.

    recv(
        filter fil,
        std::set<control_packet_type> types,
        CompletionToken&& token
    ) {

I am trying to filter received packages by their type and was wondering why the function with package filtering doesn't support async as the normal recv function without filtering does support async.
    recv(
        CompletionToken&& token
    ) {

duplicated #42


Make sure tagged rclone has correct version

Currently if you checkout the v1.35 tag and build rclone using the go tools, you get an internal version number of v1.35-DEV
change the release process so the tagged version gets exactly that version v1.35 and the new version number is v1.36-Beta
This will mean that people who are building packages from rclone tags will get the correct version numbers.

Also make sure we update the snapcraft version number

Release instructions updated in 118e26f8e226485f0457f684dede58ed940dbb59


rule: Add metric exposing the amount of rules loaded

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Add gauge metric that exposes the amount of rules loaded by the rule manager. I went with the gaugefunc strategy and actual rules as opposed to rule files as in theory there could be an empty rule file (or just empty rule group) and the alert would falsely fire in that case.
If people prefer I'm also happy to point this at the 0.12 release, but I'm also fine with waiting for 0.13.
Related to https://github.com/thanos-io/thanos/issues/2391. With this metric we could make the alert more stable as described in the issue.
Verification
curled the metrics endpoint and the metric was there :)
@thanos-io/thanos-maintainers
cc @lilic

What's wrong with existing thanos_rule_loaded_rules?

Nevermind, I didn't see that one :)
Closing.


text.compare implemented on eo

https://github.com/objectionary/eo-strings/issues/41

@includealex @OlesiaSub please review

@EugeneDar sure

@yegor256 please have a look

@rultor merge

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)


Added remove_isolated_nodes (#327)

Incorporated remove_isolated_nodes into the code for the track condensation networks.
Fixes #327

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (85888b9) 74.07% compared to head (b3ef87a) 74.11%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   74.07%   74.11%   +0.03%
==========================================
  Files          49       49
  Lines        2781     2785       +4
==========================================
+ Hits         2060     2064       +4
  Misses        721      721

Impacted Files
Coverage Δ

...gnn_tracking/models/track_condensation_networks.py
74.40% <100.00%> (+0.84%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pre-commit.ci autofix

Edit was made to the first commit because edge features do not need to be updated since there are no loops (not affected by labeling).

pre-commit.ci autofix

pre-commit.ci autofix

pre-commit.ci autofix

@all-contributors please add @jnpark3 for code


Enable equation plugin in math_lounge

Resolves #730.

I’m suspicious of how you tested this. And how you are testing it between changes

I slacked on testing everything before these last 2 commits, but I'm fairly certain everything works now. I tried plugins using one of each possible combination of pluginChannelName, pluginChannelNames, and pluginCategoryName, both in channels the plugin was allowed in and blocked in. After the second-to-last commit, the channel/category checking worked exactly as before, as far as I could tell.
If you'd like, I can draft up a comprehensive test plan for these changes.

in the initial post of this PR, please describe how you tested this and which cases you covered

This really should be 2 PRs
The majority of the work here is enabling more than one designated channel name for a plugin
And the other is just implementing that on one plugin.
If you just want to accomplish your goal of Enable equation plugin in math_lounge there's not really a reason to convert the pluginChannelName to an array. Just put math_lounge and you might have to change one line in the command handler to check if the category oor the channel is valid

deyeet?


Added note

I added a note where you can find the BLANKER (blank.bin) file.
Maybe this helps someone!

Thanks

Not convinced about this blanker file - surely as 3c, 3e and 3f are used the blanker should cover from 3c000 to 3fffff ?? and given that you have a checksum system why is it needed at all?


Add additional arguments to pass in vars to test proper execution

This is an issue I saw where it is removing double quotes from the command-line options, which affects being able to properly pass in variables like maps and arrays.
Documentation

@charleszipp any ideas on this? This PR is to get started the issue from my marketplace comment.

@Izzmo the issue is with the azure-pipelines-task-lib library that is used to run tools on the build agents. This expects options added in a line to be formatted a very specific way. See the function that controls this (here)[https://github.com/microsoft/azure-pipelines-task-lib/blob/ae939a5f51e1c2caa5aaf3f24c67394fa7d3ec85/node/toolrunner.ts#L82].
I have committed the way that it expects the string to be formatted. This is how you would input these vars in the terraform task command options field as well.
const commandOptions = `-input=true -lock=false -no-color -auto-approve "-var=\\"test_var=test\\"" -var='test_map="{name=\\"test\\",code=\\"abc\\"}"'`

The function expects anything with double quotes to be first surrounded by outer double quotes.  Then, the quotes you want to keep within have to be escaped by double backslash.

@charleszipp yuck! But I guess it is what it is. Knowing this, can we can get some documentation around this?
I feel like this is a pretty common use case when using Terraform and people probably just do what I did and revert to an annoying secrets file which is a pain to update.

@Izzmo i agree this is less than ideal for sure. I think I would prefer to see if its possible to update the task form so that vars have their own section. This is done in other tasks with environment variables. Then i can update the task to format them appropriately so the user doesnt need to know. They just supply the name value pairs.
If there isnt an issue for this already, i will open one to make it easier for users to supply vars.

@charleszipp sounds good. So can we go ahead and push through this PR and then start another round of edits to modify the task itself -- or would you rather do it all within this?

Lets do a separate PR tied to #83. I will merge this PR through tomorrow

@charleszipp okay, sounds good. Thanks!

@charleszipp Also, that did not seem to work in the current pipeline I have. Here is the output:
2019-08-23T16:43:02.8626548Z [command]C:\agent1\_work\_tool\terraform\0.12.6\x64\terraform.exe apply -auto-approve -lock-timeout=5m -var=\\resource_group_name=RG\\ -var='region={name=\\northcentralus\\,code=\\A1\\}' -var='environment={name=\\pc\\,code=\\PC\\}'
2019-08-23T16:43:03.6317227Z
2019-08-23T16:43:03.6318164Z Error: Value for undeclared variable
2019-08-23T16:43:03.6318806Z
2019-08-23T16:43:03.6319380Z A variable named "\\\\resource_group_name" was assigned on the command line,
2019-08-23T16:43:03.6319904Z but the root module does not declare a variable of that name. To use this
2019-08-23T16:43:03.6320386Z value, add a "variable" block to the configuration.

@Izzmo Can you post the exact value you put into the command option field minus any secret values?

@charleszipp it was this:
-auto-approve -lock-timeout=5m "-var=\\"resource_group_name=$(resourceGroupName)\\"" -var="'region={name=\\"$(regionName)\\",code=\\"$(regionCode)\\"}'" -var="'environment={name=\\"$(envName)\\",code=\\"$(envCode)\\"}'"

I'm having same issue as Izzmo still
commandOptions: -lock=false -input=false -var="\"management_group_id\"=${{ parameters.mgmtgroup }}"
is becoming the following
/azp/agent/_work/_tool/terraform/0.13.0/x64/terraform plan -lock=false -input=false -var=\\management_group_id\\=iDevOps_MGMT_Testing

since this PR is over a year old and the code has significantly changed since it was opened, closing. feel free to resubmit in new pr with latest.


Fix bug making DwC occurrence importer prefer misspelled protonyms

Incorrectly conjugated original names would be picked by the DwC Occurrence importer in cases where the validly conjugated name now matches the misspelling.
Original misspelling: Stigmatomma elongata
Correct original spelling: Stigmatomma elongatus
Taxon was moved to Fulakora, so name is Fulakora elongata

Misspelled name is now Fulakora elongata [sic], which get_protonym will select because it searches the name field before checking conjugated names.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d31ba54) 80.58% compared to head (9f2120c) 72.26%.

:exclamation: Current head 9f2120c differs from pull request most recent head 0a72ed2. Consider uploading reports for the commit 0a72ed2 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3707      +/-   ##
===============================================
- Coverage        80.58%   72.26%   -8.33%
===============================================
  Files             1889     1655     -234
  Lines            68024    56341   -11683
===============================================
- Hits             54820    40717   -14103
- Misses           13204    15624    +2420

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for RoomTemperature controls

Right now there is a partial support for Room Temperature that only controls heating. This PR adds support for all Room Temperature operations:

RoomTemperatureHeating
RoomTemperatureCooling
RoomTemperatureAuto

@tadasdanielius can't add you as an reviewer. Will appreciate if you can check this PR.

This PR is breaking the integration and functionality of the device in my case. https://github.com/tadasdanielius/daikin_altherma/issues/97


Add compat entries to standard libraries

https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958

I believe that the nightly test failure are due to a regression: https://github.com/JuliaLang/julia/issues/53381


Could not find method android.widget.ImageView.

I got this error and a blank screen when trying to display an image.Android version here being used is 4.1.2.
It works fine on higher versions of android.

No idea what this means

Any solution ? Same problem here ..


feature question

i like to have a windows made up of lots of other windows that combines code editing with bash / ssh terminal.
does Micro or a plugin support this ?
Its because i need to write lots of distributed things and so i make a code change and then want ot se the effect on say 10 servers at once and so need to see 10 ssh sessions.
how i explained my use case ??

check out tmux or screen. Both allow you to split a terminal into multiple smaller ones:https://tmux.github.io/ss-tmux2.png

Micro does not support running terminals inside of splits from within micro. You should use a terminal multiplexer like tmux or screen to do that. Personally, I use iTerm2 splits, but if you are using ssh tmux or screen is probably better.
It is unlikely that in the future micro will support this because it is not a text editor's job to do terminal multiplexing, so I'm going to close this issue..

thansk all.
is there a golang based terminal multi-splitter by any chance ?
i need to do lots of cross OS testing (Windows, linux, OSX, Rasp pi). and
from there connect to many golang routine doing distributed data crunching
On Fri, 24 Feb 2017 at 22:28 Zachary Yedidia<EMAIL_ADDRESS>wrote:

Micro does not support running terminals inside of splits from within
micro. You should use a terminal multiplexer like tmux or screen to do
that. Personally, I use iTerm2 splits, but if you are using ssh tmux or
screen is probably better.
It is unlikely that in the future micro will support this because it is
not a text editor's job to do terminal multiplexing, so I'm going to close
this issue..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zyedidia/micro/issues/560#issuecomment-282409169, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATuCwlsUvPKY0KT0dEmBmfrReA-gP4V4ks5rf0tugaJpZM4MLV9E
.


#709 - Fixed macros no longer working when more than one macro exists

Most of the line changes are code formatting. The main change is on line 167, so that the reset function is called also in a different scenario.
Tested on my Haute42 and seems to be working

Unfortunately there is something deeper in macros causing an issue. I'll take a look and get it fixed up with our pin system.


Trim suffix

Otherwise I think it tries to reach out to http://pod-ip:8585/ which fails, since we've de-registered the / and /v2 endpoints.

Fixes ci, and it's straightforward, so serlf-merging.


tests: check pytest version and skip if < 3.4

Some tests use the caplog fixture, which is available in pytest since
version 3.4.

Pull Request Test Coverage Report for Build 147

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.466%

Totals

Change from base Build 142:
0.0%

Covered Lines:
729

Relevant Lines:
729

💛  - Coveralls

Pull Request Test Coverage Report for Build 147

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.466%

Totals

Change from base Build 142:
0.0%

Covered Lines:
729

Relevant Lines:
729

💛  - Coveralls

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   97.53%   97.53%
=======================================
  Files           4        4
  Lines         729      729
  Branches      187      187
=======================================
  Hits          711      711
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861185b...ae957be. Read the comment docs.


change /bin for /scripts

https://github.com/sct-pipeline/dcm_metric_normalization/tree/main/bin

Renamed in https://github.com/sct-pipeline/dcm-metric-normalization/commit/c9b37a6e0a303a873c5502fb263ae9623bfe78f8


Nancy 1.x Token Validation Issue (401) every 7 days on Load Balanced Servers

I have 2 servers in LB, every 7 days one of the them will encounter a validation issue (401) for hours until the IIS recycle .
BTW: I store the keys in Redis.

If its exactly 7 days, sounds like something is being cached for that length


[BUG] Global Role Template doesn't allow to list namespaces

Rancher Server Setup

Rancher version: 2.7.9 and earlier (was already in 2.7.4)
Installation option: Helm Chart

If Helm Chart, Kubernetes Cluster and version: k3s v1.24.13 +k3s1

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: RKE2 v1.24.4 +rke2r1
Cluster Type: Downstream

If downstream, what type of cluster: Custom

User Information

What is the role of the user logged in: Custom

If custom, define the set of permissions: User Base + custom Role

Describe the bug

If role which enables get/list/watch verbs on * in management.cattle.io and get/list/watch on namespaces in core API groups assigned to a user, the user can't list namespaces.
The user may list Cluster and Projects using v1 and v3 APIs but can't list namespaces. It happens both in WebUI and when the API calls are executed separately.
The following call returns a full list of Projects in all Clusters: https://rancher.hostname/v3/projects
The following call returns no namespaces, despite Cluster c-m-qrg48sdz exists and showed in the previous call: https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces
There is no error message, the call goes through, just the list of namespaces is empty. In WebUI the user sees the Projects but for each projects it's said that there are no namespaces defined.
To Reproduce

Create a user which has the following roles assigned:

User Base
api-ro Role with the following permissions:

   rules:
  - apiGroups:
      - management.cattle.io
    resources:
      - '*'
    verbs:
      - get
      - list
      - watch
  - apiGroups:
      - ''
    resources:
      - namespaces
    verbs:
      - get
      - list
      - watch

Try the following API calls:

/v3/projects
/v3/cluster//namespaces
Result
/v3/projects: a list of all projects in all clusters is returned
/v3/cluster//namespaces: an empty list of namespaces is returned.

Expected Result

/v3/projects: a list of all projects in all clusters is returned
/v3/cluster//namespaces: a list of all namespaces in the cluster is returned.
Screenshots

Here is an example of empty namespaces list:
    "type": "collection",
    "links": {
        "self": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces"
    },
    "createTypes": {
        "namespace": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces"
    },
    "actions": {},
    "pagination": {
        "limit": 1000,
        "total": 0
    },
    "sort": {
        "order": "asc",
        "reverse": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?order=desc",
        "links": {
            "description": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?sort=description",
            "state": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?sort=state",
            "transitioning": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?sort=transitioning",
            "transitioningMessage": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?sort=transitioningMessage",
            "uuid": "https://rancher.hostname/v3/cluster/c-m-qrg48sdz/namespaces?sort=uuid"
        }
    },
    "filters": {
        "created": null,
        "creatorId": null,
        "description": null,
        "name": null,
        "projectId": null,
        "removed": null,
        "state": null,
        "transitioning": null,
        "transitioningMessage": null,
        "uuid": null
    },
    "resourceType": "namespace",
    "data": []
}

Additional context

What is really weird, if I assign the Restricted Administrator role to the user, it starts seeing the namespaces.
But if I create a clone of the Restricted Administrator role and assign it to the user, then the namespaces' list is empty again. It looks like there are some ClusterRoleBindings in the downstream clusters which allow access to namespaces in core API group connected to some roles, and other roles which have the same rules defined in custom Roles doesn't get the bindings in the downstream clusters.
If I change the role to allow * verbs on * in * API group, it doesn't work anyway.
If I assign a custom role "View All Projects" to the same user on the cluster-level, then it works fine as well.

Hey @gutttlt . This is a known issue of Global Roles in the 2.7.x line. We introduced a new field in 2.8.0 - inheritedClusterRoles which allows you to give permissions on all downstream clusters through the use of GlobalRoles. There is documentation and a blog post which can help you understand how to use the new feature.
The reason that you were seeing the desired behavior with the Restricted Administrator role was due to that role being one of two roles (the other being Administrator) which gave permissions on downstream clusters. This was inflexible, so we introduced the new field I referred to above. Please let me know if you have any additional questions/concerns - I'll leave this issue open for a short time, but will plan on closing it since we have already addressed this in the 2.8 line.


save/load context

Could this be a good first issue? I'm still reading the codebase but would love to try it out!

@galer7 sure, that would be great. The files included by the user are stored in mentat/code_context.py as include_files. I think adding save and load commands that accept an optional file name (otherwise maybe save to ~/.mentat/last_context.json. You can see how commands are handled in mentat/commands. Feel free to ask questions here or on the discord

Thanks! I think I got a first naive solution done, will fix tests and formatting tomorrow


Detail Panel does not auto close when a new Detail Panel is open despite setting detailPanelType to single

Hi, thanks for your work on this project!
Describe the bug
An open detail panel does not always auto close when opening a new detail panel even though the detailPanelType is set to single.
I hacked the code locally to fix it but I'm not so sure it's in the best spot or even the right approach.  Here in data-manager.js I've modified a few lines in setData starting with const newRow that fixes the issue for me...
this.data = data.map((row, index) => {
      const prevTableData = prevDataObject[row.id] || {};
      const tableData = {
        id: row.id || index,
        // `uuid` acts as our 'key' and is generated when new data
        // is passed into material-table externally.
        uuid: row.uuid || uuid.v4(),
        ...prevTableData,
        ...row.tableData
      };
      if (tableData.checked) {
        this.selectedCount++;
      }
      const newRow = {
        ...row,
        tableData
      }
      if (this.lastDetailPanelRow && this.lastDetailPanelRow.tableData && this.lastDetailPanelRow.tableData.id === tableData.id) {
        this.lastDetailPanelRow = newRow
      }
      return newRow;
});

I believe the problem is that this.lastDetailPanelRow can hold on to a copy of tableData that is equivalent to, but not the same object in memory, as held by this.sortedData[n].  So when this.lastDetailPanelRow.tableData.showDetailPanel = undefined is executed to close the last detail panel in the changeDetailPanelVisibility function, it doesn't actually undefine this.sortedTable[n].tableData.showDetailPanel  (BTW  I'm guessing this same problem exists with this.lastEditingRow too)
To Reproduce
Auto close works fine until my open detail panel gets remounted (maybe re-render too?).  I moved to this fork because the original code would always close my detail panel during redux update.  This fork fixed that which is great, the user is now unaware of a remount (I've tried to prevent remounts but no luck).

Open a detail panel component which contains an embedded MaterialTable for editing.  The detail panel component is passed an onEdit function and the row data via props.
User edits some data and saves it
detail panel component calls the passed in onEdit function that hits a saga which submits data to server
Redux is updated with server response.
Since the state is passed from parent container to detail panel component, the detail panel component gets the new data and the embedded table is updated with the users changes
Click on a different row.  Its detail panel opens fine but the previous detail panel remains open.

Expected behavior
Any open detail panel should close when another one opens if detailPanelType is set to single
Desktop (please complete the following information):

OS: MacOS Big Sur
Browser: chrome
Version: 92.0.4515.159

This bug is related to https://github.com/material-table-core/core/issues/334 as it's caused by remounts.  But even if remount is fixed I think it should still be addressed as refs to rows should be updated in all locations holding it.
Here's a code sandbox showing this issue forked from 334's sandbox...
https://codesandbox.io/s/material-table-starter-template-forked-fo8nj?file=/src/index.js

Click a row, the detail panel is displayed
Click a different row, a new detail panel is displayed and the old one closes as expected
Now edit the table in detail panel
Click a different row, now 2 detail panels are open

That's weird. I cannot reproduce this in the sandbox. Can you maybe create a gif for me to see it?

Sure. Take a look at the gif, to create I...

clicked on row 1 (id 77 in gif)
clicked on row 2 and watched row 1 close it's detail panel automatically
clicked on row 2's detail panel action button then changed the name from Rock to Rock2 and then saved it
clicked on row 1... row 2's detail panel remains open

Thanks
Screen Shot 2021-09-22 at 10.21.35 AM

So I still cannot reproduce it unfortunately. Can you make a video? Or maybe try a different browser, e.g. chrome to narrow down the problem?


Completed lint of client package

[ ] CHANGELOG.md updated
[ ] Rebased/mergable
[ ] Tests pass
[ ] Sign CLA (if not already signed)

I noticed that the consistency constants are never used. Are these for future use or deprecated? I did find similar constants in points_writer.

Thanks @skanjo, +1 from me
@jwilder ?

CLA has been signed.

Those constants may be used by users of the client package. They are part of the client API.

OK @jwilder -- I thought it was something like that -- thanks.

If used by clients then they most likely should be exported. Correct?

Yes, since they are made available for client software they should remain exported.

I will change it.

Since this it client code, it's probably best to leave everything as is, since we don't know if others are relying on the code here. Make sense?
Thanks for the work though @skanjo.

Yes


Enable Java10 testing in Jenkins

As there is a Java10 build available to test, we should enable the openjdk_regression and systemtest suites at minimum.

We will need to update the openjdk_regression/playlist file for a few tests that require additional commandline option to point to location of native tests for Java10 testing (see below, and https://download.java.net/openjdk/testresults/10/docs/howtoruntests.html for details).
-nativepath:{location of the jdk test native library}: This has to be generated at build time of the test jdk by invoking "make test-image". These libraries are located in the build directory under "images/test/jdk/jtreg/native/"

Will the OpenjdkBuild build test-image or test build do it?

I presume it makes sense to have the native test libs be built alongside the JVM (as they have been done for Java8 and Java9), so if they are not currently being built as part of the Java10 builds, we should open an issue on the openjdk-build repo.

I have double check no test image is built in Java10 builds. Will open an issue in build repo.

Open an issue https://github.com/AdoptOpenJDK/openjdk-build/issues/248

Closing as now listed in summary issue #346


[Nitpick] Constant "application not responding" message on Ubuntu

This bugs me for a long time after updating to latest version. Well, at least in my Ubuntu 20.04.
I think something is wrong with the game, but I don't know why. Everytime I run the application, this shows up. (Seriously, aren't they never stop bugging me?)

If the game runs well regardless, this shouldn't be an issue, right?
Anyways, here's log of the application when I run it via terminal, before I killed the process. Bonus to PC specs where I run the game.
libusb-compat debug: usb_init:
libusb-compat debug: usb_find_busses:
libusb-compat debug: usb_find_busses: bus 2 added
libusb-compat debug: usb_find_busses: bus 3 added
libusb-compat debug: usb_find_busses: bus 1 added
libusb-compat debug: usb_find_devices:
libusb-compat debug: usb_find_devices: device 1.1 added
libusb-compat debug: usb_find_devices: device 1.2 added
libusb-compat debug: usb_find_devices: device 1.3 added
libusb-compat debug: usb_find_devices: device 1.4 added
libusb-compat debug: usb_find_devices: device 3.1 added
libusb-compat debug: usb_find_devices: device 3.2 added
libusb-compat debug: usb_find_devices: device 2.1 added
libusb-compat debug: usb_find_devices: device 2.2 added
StepMania5.3-git-7bd2118e8c
Compiled 20210223 @ 21:17:13 (build 7bd2118e8c)
Log starting 2021-03-05 19:43:07
Loading window: sdl
OS: Linux ver 050800
Crash backtrace component: x86 custom backtrace
Crash lookup component: backtrace_symbols
Runtime library: glibc 2.31
Threads library: NPTL 2.31
/Appearance/Toasties/Confuzled
/Appearance/Toasties/Jousway
/Appearance/Toasties/None
/Appearance/Toasties/Confuzled
/Appearance/Toasties/Jousway
/Appearance/Toasties/None
ALSA: Advanced Linux Sound Architecture Driver Version k5.8.0-44-generic.
 It's the kernel mode message polling rate 'thinking' OutFox is not responding, but it is actually. A fix should hopefully be available for the next release.

As per now the bug still persists. I'll keep you informed if the bug miraculously gone with a certain kernel update.
System: Ubuntu 21.04
Kernel: 5.11.0-31-lowlatency

Have you tried increasing the mutter timeout? to see if it goes away?
gsettings set org.gnome.mutter check-alive-timeout 60000

Tested, and it works as a workaround. Guess the game didn't respond within 5 seconds (default time)?
I personally observed using stopwatch and see if the game stops responding for 5 seconds. The result is, well, the message shows up before 5 seconds timeout stated by the system.
Race issue? I'll retest on normal kernel, and not low latency and try to compare it.

@Scraticus should we close this as we have a workaround? or there anything else you wanted to try/test before that?

We can close it. There will be a new non blocking loader which will stop that in alpha V.


should have a Table class that provides services for working with a data source

use frictionlessdata\tableschema\Table

$datapackage_descriptor = json_decode(file_get_contents("https://raw.githubusercontent.com/frictionlessdata/testsuite-extended/master/datasets/country-codes/datapackage.json"));
$schema_descriptor = $datapackage_descriptor->schema;
$table = new Table("https://raw.github.com/datasets/country-codes/master/data/country-codes.csv", $schema_descriptor);
foreach ($table->read() as $row) {
  print($row["name"]);
};

done in v0.1.3 (with slightly different syntax, see README)


Shift anonymization responsibility to analytics module callers, part 1

Description
First part of the ongoing effort to shift the anonymization responsibility from the shared analytics module to the callers of said module. The purpose of this refactor is to move the logic of anonymization and the logic that maintains the analytics payload compatible with the old analytics schema (i.e. deprecated stuff) closer to where said payload is generated.
The first commit of the PR splits the models.py orchest-api module into sub files because it was getting too big, so don't get scared by the count of LOC changes :p.

I guess for the @staticmethod functions current_layer_notification_data(event) we need to make sure that they never return a reference to the event or modify it because that could lead to to_notification_payload(self) and to_telemetry_payload(self) to change the same object (self is passed as event). Possibly leading to notification data slipping into telemetry data (if to_telemetry_payload is called before to_notification_payload and then the telemetry_payload being send_event).

To check whether my understanding of the changes is correct. Let's say the user creates a new job, then:

The orchest-api creates a new job and events.register_job_created
Whenever an event is registered it is checked what subscribers are subscribed to this event
For all of these subscribers the correct payload is constructed. This is done based on the type of the subscriber, e.g. AnalyticsSubscriber, and the type of the event, e.g. CronJobEvent.
The payload is added to the DB under models.Delivery
The delivery of the payload is then handled by the celery-worker

So to send a notification (may it be a webhook one or an analytics one), all you have to do is call the right events.register_... function in the right place?
On one hand feels like a very nice abstraction, whereas on the other hand whenever you want to add a new type of event (which is the common case imo since e.g. job creation will not suddenly be added to another place) you have to create a lot of functions in the right places. Definitely a huge improvement on the previous "analytics system" though, handing of the different responsibilities (e.g. creating the payload, delivering the payload) instead of having to do everything in one place.
:muscle:

To check whether my understanding of the changes is correct. Let's say the user creates a new job, then:
So to send a notification (may it be a webhook one or an analytics one), all you have to do is call the right events.register_... function in the right place?

Yes pretty much. Of course you will have to create the model and/or add the required event_type if we are talking about new events

On one hand feels like a very nice abstraction, whereas on the other hand whenever you want to add a new type of event (which is the common case imo since e.g. job creation will not suddenly be added to another place) you have to create a lot of functions in the right places.

Yes that's true. Not sure if I would define it as a lot but the asynchronous delivery and the overall abstraction comes indeed at a price. About having to place events.register_... calls, I had thought about using hooks but DB level ones imo are a no go given that we will find ourselves mixing the codebase between python and SQL, sqalchemy hooks had some gotchas that I was afraid were going to leak the abstraction when it comes to how a user is saving events, so I opted for this more naive approach (I also didn't want to add more and more to the PR ahah :p)

Given the logic and the fields of the Events models I am not sure this is a big risk, where most risk is at (imo) is that often current_layer_telemetry_data calls current_layer_notification_data to be DRY, so there is the chance of letting things slip through here and is part of the reason to move the creation of the payload and its anonymization closer ( i.e. the "Shift anonymization responsibility" PRs)

Makes sense. Just wanted to have a short discussion about it. All good!

LGTM! I will leave it up to you to decide whether you want to start using pydantic here (and we can then on an ongoing basis start using it elsewhere as well).

Might be preferable to merge the PR, so that the "base" PR (https://github.com/orchest/orchest/pull/964) can be prepared (e.g. fleshing out the description, merging dev back in, taking care of merge conflicts). Will probably wait for https://github.com/orchest/orchest/pull/1008 to be merged to dev since expanding the orchest-api analytics scope has introduced a lot of changes and I would like to do some more end to end QA. I might add a small PR on top of this to introduce pydantic depending on our schedule with other tasks, if not, I'll make sure to introduce pydantic the next time we find ourselves in such a spot; of course, open to discussion.


Dzliang100 patch 1

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@81383c6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   94.8%
========================================
  Files             ?       2
  Lines             ?     250
  Branches          ?       0
========================================
  Hits              ?     237
  Misses            ?      13
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81383c6...5bacc20. Read the comment docs.


Fix the mix-up of command line options -L and -I (Fix #1413)

@hiroyuki-sato Trying to fix #1413. Could you have a quick look?

@dmikurube Thanks! LGTM 👍
I checked those options behavior using embulk-parser-jsonpath.
git checkout -b topic/fix-mixup-of-cli-options-L-I upstream/fix-mixup-of-cli-options-L-I
./gradlew executableJar
./gradlew embulk-ruby:gemContents

cd path/to/embulk-parser-jsonpath
./gradlew gems

cd /path/to/embulk-parser-jsonpath

-L: option test.
/path/to/embulk/build/executable/embulk-0.10.30-SNAPSHOT.jar \
  -X embulk_home=/path/to/.embulk-dev \
  run  \
  -L build/gemContents \ # not contains lib
  -I path/to/embulk/embulk-ruby/build/gemContents/lib \
  example/conf.yml

-I: option test.
/path/to/embulk/build/executable/embulk-0.10.30-SNAPSHOT.jar \
  -X embulk_home=/path/to/.embulk-dev \
  run  \
  -I build/gemContents/lib \ # contains lib
  -I path/to/embulk/embulk-ruby/build/gemContents/lib \
  example/conf.yml

2021-04-07 20:24:39.469 +0900 [INFO] (main): embulk_home is set from command-line: /Users/user/.embulk-dev
2021-04-07 20:24:39.953 +0900 [INFO] (main): Started Embulk v0.10.30-SNAPSHOT
2021-04-07 20:24:42.654 +0900 [INFO] (0001:transaction): Gem's home and path are set by system configs "gem_home": "/Users/user/.embulk-dev/lib/gems", "gem_path": ""
2021-04-07 20:24:43.353 +0900 [INFO] (0001:transaction): Loaded plugin embulk/parser/jsonpath from a load path
2021-04-07 20:24:43.402 +0900 [INFO] (0001:transaction): Listing local files at directory 'example' filtering filename by prefix 'input'
2021-04-07 20:24:43.402 +0900 [INFO] (0001:transaction): "follow_symlinks" is set false. Note that symbolic links to directories are skipped.
2021-04-07 20:24:43.405 +0900 [INFO] (0001:transaction): Loading files [example/input.json, example/input3.json, example/input2.json]
2021-04-07 20:24:43.453 +0900 [INFO] (0001:transaction): Using local thread executor with max_threads=8 / output tasks 6 = input tasks 3 * 2
2021-04-07 20:24:43.464 +0900 [INFO] (0001:transaction): {done:  0 / 3, running: 0}
2021-04-07 20:24:43.536 +0900 [INFO] (0012:task-0000): JSONPath = $.results
2021-04-07 20:24:43.536 +0900 [INFO] (0014:task-0002): JSONPath = $.results
2021-04-07 20:24:43.537 +0900 [INFO] (0013:task-0001): JSONPath = $.results
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  2 / 3, running: 1}
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  3 / 3, running: 0}
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  3 / 3, running: 0}
2021-04-07 20:24:43.684 +0900 [INFO] (main): Committed.
2021-04-07 20:24:43.684 +0900 [INFO] (main): Next config diff: {"in":{"last_path":"example/input3.json"},"out":{}}

Thanks, all, for having a look! I'm going to release v0.10.30 with it soon.


Please invite me to the GitHub Community Organization

Name
Soumya Kushwaha
Discord Username (if applicable)
Soumya#3939
Additional Context
.

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉#
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/jaidevstudio/people
Like this

Tips for practising:
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Please check your email or organisation page 🙏


Colors.DarkGray returns wrong value

Description
The constant Microsoft.Maui.Graphics.Colors.DarkGray returns wrong value.
Compared to other colors, DarkGray is lighter then Gray.
This probably affects all platforms.
Like other colors such as DarkBlue, DarkGreen, DarkRed, etc should "Dark" designate a color that is darker than the average.

Version: Microsoft Visual Studio 17.3.0 Preview 1.1
Steps to Reproduce
Compare the luminance of DarkGray and Gray
Demo project comparing colors
Version with bug
Unknown/Other (please specify)
Last version that worked well
Unknown/Other
Affected platforms
Android, Windows, I was not able test on other platforms
Affected platform versions
Windows 10 19044.1706
Did you find any workaround?
No response
Relevant log output
No response

Never mind, it seems most don't care, for whatever reason.
But it remains

DarkGray is not
darker then gray
use DarkerGray

I will print a T-shirt with it ;-)
One last wish to make the things better:
Please consider to add a new constant DarkerGray, this will not break anything and sets a sign that one knows about this anomaly. The value 2B2B2B has the opposide luminosity of LightGrray and would be a value I would use for it.
Thanks and greetings to the team and all contributors.

EDIT: V2 😁


Latch inferred for x signal

Version
Yosys 0.38 (git sha1 543faed9c8c, gcc 13.2.0-13 -fPIC -Os)
On which OS did this happen?
Linux
Reproduction Steps
E.G.
yosys -p "read_verilog -sv ../../icebreaker2_nosv.v; synth_ice40 -top icebreaker -json icebreaker2_synth.json"
(but I get the same error also with -noflatten, or with the gatemate synthesis target).
icebreaker2_nosv.v.gz
test.vmem.gz
Expected Behavior
Signal result8 is implemented without latches
Actual Behavior
ERROR: Latch inferred for signal \cpu.\sv2v_autoblock_2.sv2v_autoblock_3.result8' from always_comb process \cpu.$proc$../../icebreaker2_nosv.v:0$1774'.

Can you run the following experiment?
Take logic [7:0] result8; result8 = 1'sbx; from line 778 of icebreaker2_nosv.v, and put it at the top process scope somewhere above line 705. Also rename the other result8 signals on lines 911 and 1100 so there's no name conflict. I expect the error will go away. Please confirm.
We have an issue but this will help confirm what it is.

Yes, moving the signal to line 705 is a workaround (I renamed this signal instead of the other one), which makes yosys proceed a few lines further:
No latch inferred for signal `\cpu.\sv2v_autoblock_2.result8A' from process `\cpu.$proc$../../icebreaker2_nosv.v:0$1774'.
…
ERROR: Latch inferred for signal `\cpu.\sv2v_autoblock_2.sv2v_autoblock_3.sv2v_autoblock_4.addsub_result' from always_comb process `\cpu.$proc$../../icebreaker2_nosv.v:0$1774'.

I.e. into this part of the source:
if (opcode_is_sub(opcode) || opcode_is_cp(opcode)) begin : sv2v_autoblock_4
					logic [20:0] addsub_result;
					if (!swapop)
						addsub_result = addsub({8'h00, acc8}, {8'h00, ~op8}, 1, 0);
					else
						addsub_result = addsub({8'h00, ~acc8}, {8'h00, op8}, 1, 0);
					next_f = {3'b000, addsub_result[4], addsub_result[3], addsub_result[2], addsub_result[1], addsub_result[0]};
					result8A = addsub_result[12:5];
				end

Not sure if this is a bug or a feature request, it's a SystemVerilog extension but the README claims we do support always_comb and other synthesis tools accept this.


[Bug][Windows] TypeError: unsupported operand type(s) for *: 'DotMap' and 'float'

Description
Multiplication is being performed between DotMap and float data type, for image level 2,3.
Steps to reproduce
Steps to reproduce the behavior:

Open OMRChecker\src\defaults\config.json
Line 24: Set show image level to either 2 or 3 say "show_image_level": 2,
From the command line run: python3 main.py -i samples/sample1

Expected behaviour
window size gets increased by 1.6 times for image level 2,3.
Error log
  File "C:\OMRChecker\main.py", line 79, in <module>
    entry_point(
  File "C:\OMRChecker\src\core.py", line 50, in entry_point
    return process_dir(root_dir, curr_dir, args)
  File "C:\OMRChecker\src\core.py", line 120, in process_dir
    process_dir(root_dir, d, args, template)
  File "C:\OMRChecker\src\core.py", line 109, in process_dir
    process_files(omr_files, template, args_local, out)
  File "C:\OMRChecker\src\core.py", line 283, in process_files
    in_omr = pre_processor.apply_filter(in_omr, args)
  File "C:\OMRChecker\src\processors\CropOnMarkers.py", line 218, in apply_filter
    h_stack, int(config.display_width * 1.6)),
TypeError: unsupported operand type(s) for *: 'DotMap' and 'float

Environment
Windows OS
Python 3.10.7
OpenCV 4.6.0

I am interested to solve this issue myself. @Udayraj123 Please assign this issue to me.


Default Values with backslashes, spaces, line breaks etc are not documented RF compatible

Assuming you have a keyword that has the following default values:
def funnystrings(emp='a\t\tHello', regex=r"^(?!\\s*\\.\\.\\.)", mulspec='Log   This has two ${space}', mulmulspec='c:\\windows\\system32', onlynormal="te  st\nHe'll'o    "):
     pass

This is currently written in libdoc.xml like this:
<arguments>
    <arg>emp=a		<b>Hello</b></arg>
    <arg>regex=^(?!\\s*\\.\\.\\.)</arg>
    <arg>mulspec=Log   This has two ${space}</arg>
    <arg>mulmulspec=c:\windows\system32</arg>
    <arg>onlynormal=te  st
He'll'o    </arg>
</arguments>

Which would be fine in general. But this leads to the situation that these strings are correct, but not Robot Framework compatible.
If these strings are used in an Editor they are resulting in different functionality then originally expected. Specially the line break...
This is specially an issue because these string are not shown properly in Libdoc html as well. in that case all non printable characters like \n, multiple spaces and \t are not shown at all.

Proposal
i would propose to fix that by documenting robot compatible strings.
Otherwise all editors, users, and documentation platforms have to fix that separately.

This is fixed now for python Libraries. Was right for Resource files.

This is only done with library keywords. User keywords can have e.g. variables in default values and they need to be shown as-is.


Switching httpRuntime to 4.7.2

Addresses https://github.com/NuGet/Engineering/issues/4071

I verified this fix on DEV with the package in question and it uploaded just fine. So looks like this fix is good.