OCPBUGS-3259: add credentials API field to enable environments w/o CCO

What's inside:

New AWSLoadBalancerController API field: .spec.credentials. Aims at providing a way to specify AWS credentials secret without the help of CloudCredentialsOperator (CCO)
New e2e testcase to check .spec.credetials field
Updated iamctl utility can now generate CredentialsRequest with the controller's iam policy
Updated tutorial.md and install.md docs with the new field and the way to generate controller's secret from the newly generated CredentialsRequest accordingly

Bonus:

CredentialsRequest comparison was not taking into account the secret reference and service accounts: fixed that with the unit test update
While ensuring CredentialsRequest we used to do double GET API call in case the object already exists and didn't change
e2e utils were updated with ALBC CR builder
e2e was updated with the cleanup of the test workload to make the test idempotent

/jira refresh

/assign @Miciah
/assign @rfredette

install.md was updated with a new chapter to use the generated controller's CredentialsRequest.

/retest

I updated the severity on the bug.
/jira refresh

Cluster provisioning failed:
InsufficientInstanceCapacity: We currently do not have sufficient m6i.xlarge capacity in the Availability Zone you requested (us-east-1d)

/retest

/retest

Thanks!
/approve
/lgtm

/label qe-approved


SRS Review #17

@karolserkis
In your goal statement you have two of them as shown below:

Generate a trajectory plot of the movement of the pendula from user input starting
state to equilibrium state of rest and show logged statistics over time to the user.

Generate a poincare map plot of the movement of the pendula from user input starting
state to equilibrium state of rest.

Do you generate the plot from statistics over time? If so that would be your primary goal statement. Assuming the answer to the question would be yes, I am proposing my idea.
Can you split GS1 into "show logged statistics over time" and combine the two plots together into another requirement like - "Generate trajectory plot and poincare map plot from data from GS1"? Just a thought.

@Malavika-Srinivasan @smiths
Thanks! Fixed.


AVM: Slice gadget (hande variable length memory reads + writes)

Many gadget operations, e.g hash permutation function, operates on a slice of information as inputs and/or output.
These slices are likely to be more than our number of current registers (4). Instead of adding more registers, we should be able to dynamically read and write these slices from memory into the gadgets (where the gadget specifies the logic)
### Tasks
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/7211
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/7381
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/7385
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/7416

Is there still work to do on the slice gadget @jeanmon ?

Some remaining sub-tasks are still open @dbanks12


Mini-FederatedML Task TestCase

We need to develop a Mini-FederatedML Task, which seen as a test case for Federated Learning Task after FATE deployed.
Through this test case, users can know fate deployed successfully and they can run any other Federated Learning Task.

Finish this in #133


VirtualEnv in Python doesn't trigger postactivate

I've a file with post activate logic located at ~/.virtualenvs/env_name/bin/postactivate that can contain something like this:
export ENV_NAME=local
cd ./src

It works file if I use workon env_name command from Virtual Env Wrapper.
But when I create a new terminal inside VSCode it activate the env like this:
source /Users/anton/.virtualenvs/env_name/bin/activate
And problem here that postactivate script isn't run.
It will be good to use viarualenvwrapper inside VS Code or alternatively add extra commands that will be executed after activation of the python virtual env.
If it's already a way how to execute additional script after activation of the virtual env - please let me know. I didn't find such property in VS Code settings file.
Thank you

We don't support workon. At this point this is a feature request.

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

Maybe you know how to make it possible to execute some script that sets env variables in the new terminal every time when I open a new terminal inside VS Code? Currently it only activates the virtual env, but I want to run an additional shell script that will run some additional logic.
As a way to do this - you can add a post_activate_script option to the settings. Maybe you already have something like this available via settings?
I’ve found that it’s a trigger for “.env” file that is in the project root directory. But it just sets variables. I need also to change a working for to something like “src” inside the root dir. This way every time when I will open a new terminal window it will set all necessary env variables and will switch directory to “src”, as well it will activate the virtual env inside the terminal.
Need your help in solving such situation with the currently available options. And will be good to make a generic approach to simplify this thing for future.

Thanks for the suggestion! We talked about it with the team and we have unfortunately decided we will not be moving forward with this idea. We think there isn't an enough widespread need for this to warrant the maintenance cost for the feature.
As for a workaround, we unfortunately don't have one :( perhaps you could turn off automatic activation of environments and do that process manually?!
FWIW https://github.com/microsoft/vscode-python/issues/8870 could provide a workaround for this if we implement it.


Ray asking restart every day even without an Update

Describe the bug
Ray asking restart every day even without an Update
Versions
Ray version (1.5.1):
PHP version:7.4
Laravel version 7:

@keshansandeepa Could you recreate the issue using the template please, that'll give us all the information to reproduce the issue and will make it a lot easier on us to find the cause and fix it.

@keshansandeepa Could you recreate the issue using the template please, that'll give us all the information to reproduce the issue and will make it a lot easier on us to find the cause and fix it.


Enable service contracts

These contracts are required to put the monitoring and path finding services to work. Merge https://github.com/raiden-network/raiden-contracts/pull/360 first, to avoid compilation errors.
Does this change make sense as it is? It does make some MS tests run, but it's hard for me to tell if this is the proper way to enable the contracts.
Can something like this be merged to master, or do we need a separate branch for the foreseeable future?

I will include this in https://github.com/raiden-network/raiden-contracts/pull/360, so that the tests actually pass.


Add new midstream branches

Discover new branches using openshift-knative/hack.

https://github.com/openshift-knative/hack/pull/195


LIMIT NO SUPPORT?

when use limit return syntax error..please help me

Share your code bro.

Closed for not having code examples. better-sqlite3 certainly supports LIMIT.


Avoid splitting parquet files to row groups as aggressively

This makes it less likely that we'll split up parquet files.  It does so in two changes:

Change the default blocksize from 128 MIB to 256 MiB

Only trigger this check if we double the optimal blocksize (512 MiB)
(but then presumably we'll target 256)

Additionally, for follow-up work it would be excellent to make this sensitive to only reading certain columns.  Right now I think we do this even if we read only a single column.
There's plenty more that can be done here, but hopefully this is easy to agree on as a first step.

Are we good to merge here?
Changes look good to me

I'm good.  There are test failures, and it makes me nervous to merge without green CI, but I think that this is due to the fastparquet issue that Martin and James are working out.

Yeah this happens on other PRs as well

thx @mrocklin


Use different encryption scheme than RSA from openssl

using the whole openssl library seems overkill for just using RSA.
Additionally the openssl c lib is needed on the client and server, although there exist a rust package variant that bundles the openssl library.
possible crypto libraries can be found here: https://cryptography.rs/

After extensive research, there does not seem to be any crypto library that's as easy to use as the RSA module provided by openssl create.
Will use openssl = { version = "0.10.64", features = ["vendored"] } instead to not be dependent on openssl implementation of the  host


This reverts commit eec34d5f052688f5fa2a4c9a6dc7485600cb5784.
This reverts commit 40b280032c804cc0fcb0463a9e7023f73e194b8d.
The standard github tooling for reverting did not work since the full changes were split across two PRs.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

Should we add a changenote saying we reverted? I think the original PR had one.

Going to remove the changelog entry since the feature isn't documented anywhere else. This will cause merge conflicts in the release process, but I can handle them manually.


High GPU Usage

I have noticed that when I run the addon, my 3070 gets pinned to max and throttles other applications using the GPU.
Is this addon supposed to be hardware accelerated? If so, can I configure it to be CPU bound to free up my GPU?
I am using FireFox

Oh wow. Is this only with the add-on on? Or also with base cookie clicker?
I have no idea why this would be the case. I have no idea how to start hardware acceleration from javascript (or any language for that matter). Perhaps others have an idea about why this might be happening?

This is with both running, through I dont see the spike until loading the addon.
I tried turning off FireFox hardware acceleration and that helped (though minorly)
I didnt think that browsers would have access to GPUs, and I cant imagine that the render requirement is that high.
Perhaps its related to that Javascript 'Game' object referenced in the helper bookmark?

The Game object is created by cookie clicker itself. It basically contains all code of the game.
Do you know how to do profiler snapshot? Perhaps that shows a function taking considerable time on your system.
Another (recurring) problem is the memory usage of CM, but I don't know if that would affect GPU acceleration?

Im not familiar with profiler snapshot. Can you point me to it? Is part of the developer tooling?

Yes! Open the developer tooling within Chrome (or any Chromium based browser), click on Performance, click on Record (the red button), click some things within the site, click stop recording and click save recording.
See also here


Allow users to call readRowGroup

Hello,
First of all, thank you for implementing this package. Would you be able to export the readRowGroup function? This is useful for when we're implementing predicate pushdown to read specific row groups, without needing to calculate rowStart and rowEnd (which sometimes has issues when we need to pass in BigInts greater than MAX_SAFE_INTEGER).
Thank you

I also noticed that you were working on parsing page-level statistics. Does this mean that we might eventually be able to fetch/decode individual data pages without reading the entire RowGroup?

Hey @park-brian I just published a new version v0.9.9 which exports the readRowGroup function. I didn't export it from the package, because right now it feels like a bit more of an internal api. But you should now be able to use it with an import like:
import { readRowGroup } from 'hyparquet/src/read.js'

I also just added an optional rowLimit argument to the readRowGroup which will stop the page parsing early if further rows aren't requested. This is especially nice for rendering the first rows of a file quickly.
Longer term, yes I would like to use all the data available in parquet to make querying for data as fast as possible, including using the ColumnIndex and OffsetIndex. Suggestions and contributions are welcome!

Thank you, that's great! Is it okay to use your parse-indices branch as a reference for parsing the ColumnIndex and OffsetIndex sections? I think this would be all that users need to determine the location of each page (which would let them read the page headers and then call readDataPageV2)

Yes please feel free to use it. The intention is to eventually use the indices to do exactly what you are suggesting. If you have any success please let me know!
FYI I just rebased the parse-indices branch on top of master.

Thank you, will do! I'll report my findings here.

@platypii I managed to get page-level predicate pushdown working for numeric columns. It's a bit verbose, but it works
https://github.com/park-brian/hyparquet/blob/parse-indices/test/readIndices.test.js

Just a quick note in case others run into this: if we're reading pages that use a dictionary, we need to concatenate the dictionary page + data page before passing the data to readColumn

I can work on adding filters that implement page-level predicate pushdown. It might look a bit like the mongodb query syntax. Eg:
// retrieve a record with an id of 10
{ id: 10 }

// retrieve records with ids in 3, 5, 7, 11
{ id: { $in: [3, 5, 7, 11] } }

// retrieve all records with a value between 20 and 40 (inclusive)
{ value: { $bt: [20, 40] } }

// other operators like $gt, $gte, $lt, $lte, etc can be implemented
{ value: { $gt: 10 } }

// we can even add support for nesting logical operators
{ $and: [ { firstName: 'John' }, { lastName: 'Doe' } ] }

Of course, a simpler approach is probably to let the user provide a callback function
(rowGroupStatistics, pageStatistics) => {/* Some filter logic */}

That's very cool work @park-brian !
I am interested in adding a parquetQuery or similar function. I was starting to think about what the API might look like. I'm not familiar with the mongo syntax but that is super interesting. I'm happy to accept PRs but I do want to be thoughtful about what the API looks like.

Absolutely, good API design saves everyone time and effort.
It seems that the readColumnIndex and readOffsetIndex functions work well. Would you accept a PR with tests for these functions? I noticed that the metadata test reads all the test parquet files and compares them with the metadata json files, so I'm assuming this might be the approach you want for testing column/offset indices.

I've found that one way to improve http I/O performance is by specifying multiple ranges in the http range header. Some initial benchmarks show that this decreases response time by 1-2 orders of magnitude (versus making parallel range requests for pages). I guess this should seem obvious in hindsight, but I was not expecting such a massive improvement.
Most web servers are configured to limit headers to around 8k, so it's probably safe to parallelize these multirange requests over 4-6kb chunks.

That is a nice find about the performance improvement with multiple ranges.
I already do a trick inside readRowGroup where I read the entire RowGroup in one read if it's less than 32mb, otherwise I make one fetch request per-row-group-per-column. I could imagine an aggregation one level higher in parquetRead where it determines if it should read multiple consecutive RowGroups all at once. It could do this either as one aggregate single range, or as multiple ranges in one request.
Note that I would want to have multi-ranges as an option that can be disabled, because CORS requests only allows a single range for cross-origin requests:

The Range header is a CORS-safelisted request header when the value is a single byte range. This means that it can be used in cross-origin requests without triggering a preflight request.

Interesting! I guess preflight requests would hurt users with high latency.
There are only a few situations where users would benefit more from multi-range requests rather making requests in parallel (both approaches can be combined, of course).

when they're making lots of small range requests (> 100, can happen when fetching individual data pages)
when they're on a high-latency connection (ironically)

It seems that the readColumnIndex and readOffsetIndex functions work well. Would you accept a PR with tests for these functions? I noticed that the metadata test reads all the test parquet files and compares them with the metadata json files, so I'm assuming this might be the approach you want for testing column/offset indices.

Yes I would be thrilled to have a PR with the index readers, with tests. I like the idea of testing similarly to the other tests where it reads a snapshot json file with the expected output. Only a small % of the total test files actually contain column and offset indicies, so we probably only need to make new snapshot files for a few of the tests. Do you want to take a look at doing that?

I would be happy to write some tests. Would you be able to rebase parse-indices so it's up to date with master?

Rebased parse-indicies

Thanks @platypii !
Testing has revealed an interesting edge case in the metadata.js/convertMetadata function when we're passing in a Uint8Array of 0 length alongside a defined schema (this happened when getting column indices for the adam_genotypes.parquet file).
In this case, is it better to return the original value or undefined? I think that in this context, 0-length arrays are null values.
export function convertMetadata(value, schema) {
  const { type, converted_type, logical_type } = schema
  if (value === undefined || !value.length) return value
  // ...
}

or
export function convertMetadata(value, schema) {
  const { type, converted_type, logical_type } = schema
  if (value === undefined || !value.length) return undefined // parsed as null
  // ...
}

Here's what I'm using to read the column indices
const arrayBuffer = await readFileToArrayBuffer(`test/files/${file}`)
const metadata = parquetMetadata(arrayBuffer)

const columnIndices = metadata.row_groups.map((rowGroup) => rowGroup.columns.map((column) => {
  if (column.column_index_offset === undefined || column.column_index_length === undefined) return null
  const columnIndexOffset = Number(column.column_index_offset)
  const columnIndexLength = Number(column.column_index_length)
  const columnIndexArrayBuffer = arrayBuffer.slice(columnIndexOffset, columnIndexOffset + columnIndexLength)
  const columnIndexReader = { view: new DataView(columnIndexArrayBuffer), offset: 0 }
  const schemaPath = getSchemaPath(metadata.schema, column.meta_data?.path_in_schema ?? [])
  return readColumnIndex(columnIndexReader, schemaPath.at(-1)?.element || { name: '' })
}))

Resolved with PR #14

@platypii
By the way, when do you think parse-indices will be merged to master? Just curious if you're planning to do more with this branch.

@park-brian I just released version 1.0.0 of hyparquet last night! I wanted to release 1.0.0 before considering the parse-indicies branch, since I was worried it might take some time and effort to stabilize and develop APIs for structured queries.
My plan is to make a V2 branch where we can merge in the parse-indicies branch and continue work on query api. I could release alpha packages to npm with the index parsers if it would be helpful. Open to suggestions though!
Have you thought more about how to implement a query engine?

@platypii Makes sense, it's a good time for a release. Congratulations on the 1.0 release and the HuggingFace grant!
Let me open a new issue so that we can get the discussion started (we could even try using GitHub Projects). For now, we have a couple of options. What I've been doing locally is passing in a user-defined predicate function which evaluates column/page statistics. However, this is not a great DX so a query API would be much better.
Internally, we would still be applying a predicate to get row groups/column chunks, then pages, and finally rows to retrieve filtered records (as well as fetching adjacent columns the user requests). I like the MongoDB query syntax, since it's concise yet expressive. There are also other query DSLs such as JSONPath or SQL. We could retain the option of letting power users manually specify predicate functions (in fact, this could be implemented first). This would be helpful for users who want complete control over predicate logic (eg: running calculations or querying external data).
There's also the issue of page alignment within columns. Usually, parquet writers will try to make sure that each column chunk in a row group has the same number of pages. If they don't, it makes it a bit harder to fetch adjacent pages in other columns.


gradio web demo

easy to use web demo on gradio hub

@xuebinqin please take a look and let me know if you have any questions thanks

Hi, AK, thanks for your interesting work.  I tried some images here:
https://gradio.app/hub/AK391/U-2-Net. But it couldn't work and there always
show "ERROR" on the top right corner of the mask canvas.
Could you please double check?
[image: image.png]
Thanks,
Xuebin
On Thu, May 6, 2021 at 7:37 AM AK391 @.***> wrote:

@xuebinqin https://github.com/xuebinqin please take a look and let me
know if you have any questions thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xuebinqin/U-2-Net/pull/199#issuecomment-833200109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORN5T72R6G7367JHLZTTMIFG7ANCNFSM44FMOZNA
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

@xuebinqin Hi, sorry about that, the hub instance went down, was restarting and should work now, please try again and share if you want :)

Great, It works now. I just added one of the screenshot
https://github.com/xuebinqin/U-2-Net for showing the results.
On Thu, May 6, 2021 at 6:00 PM AK391 @.***> wrote:

@xuebinqin https://github.com/xuebinqin Hi, sorry about that, the hub
instance went down, was restarted and should work now, please try again and
share if you want :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xuebinqin/U-2-Net/pull/199#issuecomment-833547016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGOROHXRTY7TET4Z62WKDTMKOILANCNFSM44FMOZNA
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

@xuebinqin Hi, sorry about that, the hub instance went down, was restarted and should work now, please try again and share if you want :) thanks

Hi, it couldn't work and there always
show "ERROR" on the top right corner of the mask canvas again.
Could you please double check?
Thanks

@AK391 Hi, your work is cool: https://gradio.app/hub/AK391/U-2-Net. It couldn't work  again and there always
show "ERROR" on the top right corner of the mask canvas.
Could you please double check?
Thanks


Return value when no partitions are chosen for compaction

moved over to https://issues.apache.org/jira/browse/HUDI-8


Google Auth provider - No refresh_token returned

Environment

Operating System: Darwin
Node Version:     v16.13.0
Nuxt Version:     3.3.1
Nitro Version:    2.3.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      app, ssr, runtimeConfig, components, routeRules, css, modules, auth, plugins, i18n
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
No response
Describe the bug
Hello there,
I encounter an issue by using sidebase/nuxt-auth over the GoogleAuth provider. I set-up the NuxtAuthHandler like this :
const config = useRuntimeConfig()

GoogleProvider.default({
            clientId: config.oauthClientId,
            clientSecret: config.oauthClientSecret,
            authorization: { params: { scope: "openid email profile https://www.googleapis.com/auth/cloud-platform" } },
})]

And I customize the jwt and session storage like this, to get the google auth accessToken to verify it on a remote API:
async jwt({ token, account }) {
    const isSignin = account ? true : false
    if (isSignin) {
        token.accessToken = account?.access_token
        token.idToken = account?.id_token
        token.accessTokenExpires = account?.expires_at! * 1000
        token.refreshToken = account?.refresh_token
    }

    if (Date.now() < token.accessTokenExpires) {
        return Promise.resolve(token)
    }

    return Promise.resolve(token)
},
async session({ session, token, user }) {
    ; (session.user as any).accessToken = (token as any).accessToken
        ; (session.user as any).idToken = (token as any).idToken
        ; (session.user as any).refreshToken = (token as any).refreshToken
    return Promise.resolve(session)
}

In the jwt function, I wanted to recover the refresh_token from the google auth workflow. But it remains still undefined (even during the first login)... I got the other credentials such as the id_token or the access_token.
But I need it to refresh google auth credentials on my server.
Could you help me if I missed something in the documentation to get this refresh_token ?
Thank you in advance !
Additional context
No response
Logs
No response

For anyone encountering the same issue:
https://developers.google.com/identity/openid-connect/openid-connect#refresh-tokens
Seems like you need to ask for it explicitly, by setting the access_type

Thank you for your help. OK I figured it out by add the access_type parameters into the Google OAuth Provider, like the following implementation:
GoogleProvider.default({
    clientId: config.oauthClientId,
    clientSecret: config.oauthClientSecret,
    authorization: { params: { scope: "openid email profile https://www.googleapis.com/auth/cloud-platform", access_type: "offline" } },
    authorizationUrl: 'https://accounts.google.com/o/oauth2/auth?prompt=consent&response_type=code',
    accessTokenUrl: 'https://oauth2.googleapis.com/token'
})


Add maker taker fees API

Adds API for fetching volume-based maker taker fees and updates many exchanges' metadata for worst case fees in the meantime. The only implementation of the make-taker fee API is in Bitfinex, but I'll add many more soon if the API is okay.

please sync up with current develop branch

How about using this endpoint: https://docs.gdax.com/#user-account

I have some partially complete code that uses the linked endpoint as an initial step. Once we get the 30 day trailing volume, we need to compute the equivalent in USD at the current market rate. I think it is the case that for each currency pair, the base exists in at least one product that relates it to USD directly, so no extended conversion-rate calculations should be required. Is it okay if the caller to this function provides the most recent order book? We could overload this API with one version accepting an order book and the other with no parameters. The exchange implementations could provide a definition for the one they require (hopefully no order book), and the unimplemented one would throw an exception as expected. This would let developers automate the process of determining when to pass an order book into the API.

please fix the conflicts, and I'll merge this. Thanks!

Bummer, looks like some exchanges like Kraken have fee tiers per currency pair. I will update the changes to reflect this, since the current version associates a fee tier with an exchange.


Integrate User Service with Dashboard

Pull Request
Description

Update User API Wrappers (done by @tryyang2001)
Remove hardcoded values from frontend components
Implemented an Auth Provider so that components can easily access current User

Related Issue(s)

Closes #45
Changes Made

Currently, AuthProvider uses a fixed id, but all other user profile details are retrieved from backend (I will integrate this with @weidak 's Login component + Auth provider (once it is completed))
This is how to use the AuthContext. You can place this block of code on top of any components that require user details. The context will re-retrieve user details from backend every time the page reloads.

 //modify specific attributes according to what the component requires
const { user: { image, name }, } = useAuthContext();

Screenshots (if applicable)

Checklist

[x] I have checked that the changes included in the PR are intended to merge to master or any destination branch.
[x] I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
[x] I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

@c0j0s I have updated the matching card to retrieve the user preferences from the context as that current wrapper is outdated, you might wanna merge this first, sorry for the inconvenience!!

I will suggest we pause merging this PR first before we merge this PR, since I believe @weidak has started working on refactoring the user_api_wrapper, so he should have the latest version.


NodePath property is inaccessible in Lua

Plugin Version: r1
Godot Version: v3.3.3
I'm trying to use a NodePath property and access it from Lua.
The code appears to register the property with Godot as it shows up and works in the inspector but is inaccessible via self in Lua.

Properties are working for other primitive types I've used so far but not when the type is NodePath. When I inspect self inside of _ready with the following code, I get the subsequent outcome.
local inspect = require("inspect")

local function ready(self)
  print(inspect.inspect(self))
  print(self.player_path)
end

return {
	_ready = ready,
	player_path = property({type = NodePath})
}

{
  __owner = [Node2D:1622],
  __script = {
    __getter = {},
    __path = "res://enemy.lua",
    __setter = {},
    _ready = <function 1>
  },
  <metatable> = {
    __concat = <function 2>,
    __index = <function 3>,
    __tostring = <function 4>
  }
}
nil

As you can see, the property is not on self and printing the field directly shows that it doesn't exist, as it's nil.

I've been loving this project by the way. It's great! Thank you for working on it.

More Digging
Digging some more, I found that the property is in the property list that is returned by self:get_property_list().
print(self:get_property_list()[#self:get_property_list() - 1])

--> {class_name:, hint:0, hint_string:, name:player_path, type:15, usage:7}

Attempting to use self:get("player_path") directly instead of through the __index metamethod doesn't appear to work either, as it also returns nil.

Discovering a Solution
While looking through the code dealing with properties I noticed some mentions of the default value being kept for indexing purposes. The way I had the code did not have a default value. This lead to me wonder what would happen if I assigned the property player_path a new instance of NodePath directly instead of calling property with just a type specified. Doing so fixed my issue.
Code
local function ready(self)
	print(self.player_path)
	print(self:get_node(self:get("player_path")))
end

return {
	_extends = "Node2D",
	_ready = ready,
	player_path = NodePath()
}

Output
../Player
[Node2D:1604]

Conclusion
Maybe we should set default_value to a new instance of type, or always require a default value when calling property to avoid someone else getting stuck like me? I'll keep this issue open if you feel that's actionable, or we can create a new more focused issue. Feel free to close this otherwise.
Thanks again for the great project!

Hi there! I see you already found out how properties are working currently. Yeah, the property is registered in ClassDB, but without an initial value, getting it would return null on GDScript.
But you're right, there is a bug when the default value is nil, in a way that the "get property" callback thinks that the property doesn't exist!
I think the way to go is really adding a fallback default value for properties, when absent, thanks for pointing it out! Requiring a default value is reasonable too, but having fallback empty/zero/identity values seems nicer to me.
Tracking known properties in a separate __properties table is probably a good idea too.
Also, now that I'm thinking better about this, just falling back to __indexing the script will be very error-prone for Arrays, Pool Arrays, Dictionaries and Object values =X
When instancing the script, we can iterate over known properties and call a constructor function for each one. I'll make this happen =]
Either way, we can always stuff initializers in the _init method, although it is much nicer to just define initial values to be created.

Not related but more out of curiosity, what OS are you using? Also, did you use the prebuilt release .zip file?
Thanks again for the help, I'm really glad you like it ^^

Just FYI, now that I'm remembering more stuff, the idea was that default value was sort of required, but I though that having null as default was not necessarily bad, as it might just be what people want, so just let it roll.
Now I see that a default default value is better and is probably what most people would want, and getter methods may be used for defaulting to null.
But the "get property" bug still applies, so in the end it was a bad choice =P

Thank you for the detailed explanation. I like your solution and I'm glad I could help.

Not related but more out of curiosity, what OS are you using? Also, did you use the prebuilt release .zip file?

I'm using Arch Linux and I did use the r1 release zip. It was plug-and-play. Very easy to get started.

I'm using Arch Linux and I did use the r1 release zip.

I asked because I use mainly a Manjaro Linux, so was curious about how this plugin would behave on other systems.
I did test on Wine and on an OSX a couple of times, though, and it also worked on my attempts. But who knows, right?

It was plug-and-play.

Awesome!


Set buildpack version as header on dcl upload

better traceability which versions are used.

Originally I wanted to use build flags, which however is not possible with the buildpack packager.
I thought about adding it to the Uploader struct aswell. I didn't like it either, because you would need to pass it also to all other structs if required somewhere else. Adding the whole manifest to the uploader seems even worse, because the uploader should not even need to know that it is running in the context of a buildpack.
Since the project is rather small and we do not have HTTP calls anywhere else outside of the uploader, I'll add it to the Uploader struct for now.


On transition: "Send to Ikari", clip the video and upload it

Also transition after download has finished (failed/succeeded)
Either use the built-in webhook system, which is easier to set up, or a groovy script, which removes to need to update the custom field names every migration.

Transffered to [IKARI-1]


Frontend won't work

When I run the command npm install in the frontend/app folder it returns a lot of errors about react-dom, react-screen-loading, and react-router-dom. It says there is an upstream  conflict and that the packages are either incorrect or potentially broken.

The same thing happened. Npm install occures error.
npm ERR! gyp ERR! cwd /Users/kadiryaren/Downloads/react-real-time-chat-app/Frontend/app/node_modules/node-sass
npm ERR! gyp ERR! node -v v18.3.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
npm ERR! Build failed with error code: 1
npm ERR!      /Users/kadiryaren/.npm/_logs/2022-08-05T19_04_18_739Z-debug-0.log

The same things happened. Npm install gives a lot of errors.


refactor saving of the lab record during deployment.

Fix is to save only one record of the lab while saving, and retrieving.


Hello,
I was trying to build the latest Mozc version and I found that while building directly against the latest master is fine, trying to build against the latest commit 490cffc7fb08023d07758104bdad1f23e6da2dff was problematic due to some missing files/folders:

src/data/hentaigana/
src/rewriter/a11y_description_rewriter{.cc,.h,_test.cc}
src/rewriter/gen_single_hentaigana_rewriter_data.py

After looking some more into it, it turns out that the issue apparently goes deeper:

The single change committed with 490cffc7fb08023d07758104bdad1f23e6da2dff ["Update BUILD_OSS to 4830"] (August 27th) is also present in the history of previous commits, going as far back as 8705e47261826cef691006ec9fb127619880d252 (August 22nd).
490cffc7fb08023d07758104bdad1f23e6da2dff is missing not only the previously mentioned files but (as far as I checked) all changes from previous commits, up to and including 8705e47261826cef691006ec9fb127619880d252.
The latest master reports bf5e3ce232f3afd6c807d9c3d75d41fea08befc5 (August 26th) as the latest commit, which is second-to-last in the commit history, instead of the actual latest 490cffc7fb08023d07758104bdad1f23e6da2dff.

It's almost as if 490cffc7fb08023d07758104bdad1f23e6da2dff kind-of-rebased itself against 72f91f31936afa9b8f0bece819bb767915a7f14d (August 18th) and then applied itself to all subsequent commits, but was not recorded as a distinct commit to the latest master (which is based off bf5e3ce232f3afd6c807d9c3d75d41fea08befc5, and that's why it builds fine). So either I'm hallucinating and/or I'm more clueless about how git works than I ever thought I could be, or there's something seriously weird going on.

Hi, we haven't had similar issues on our environments or GitHub Actions.
Would you try the latest commit?
It might not be a GIt issue, but a cache issue on the build system.
So error logs would be helpful.
Thanks,

Closing this issue.
Please feel free to reopen it if the problem still remains.


typo

The pull request from @jaller94 improves this typo and much more https://github.com/toger5/TheBoard/pull/1


Dark mode is not applied to the whole viewport

Thanks for the feedback @peterangelov
Does reload help with the issue as was fixing similar one yesterday so maybe you do not have the recent version.
If it persist please let me know the browser and version. Recent Chrome for OSX?

Reload did not help. Tried also Firefox and Safari.
Browser: Version 98.0.4758.80 (Official Build) (x86_64)
MacOs: 11.6 (20G165)

@peterangelov Issue should be fixed now. Please try again if it works for you.

It works! 🎉
Thank you


File-based task inputs and outputs should behave like annotation counterparts

Original issue: https://issues.gradle.org/browse/GRADLE-2638
Expected Behavior
Task inputs and outputs declared through the API should validate the assigned values and create necessary, non-existent directories. Properly document the behavior in the user guide and Javadocs.
Current Behavior
Task inputs and outputs declared through the API do not validate the assigned values, nor and create necessary, non-existent directories.
Context
The runtime behavior for task inputs/outputs should be consistent across the ways they can be declared. There's absolutely no compelling reason for not doing so and leads to confusion for end users.
Steps to Reproduce (for bugs)
Usage of annotations:
// Fails the build by saying that input file does not exist
task validatesInput(type: MyTask) {
    inputFile = file('does-not-exist.txt')
}

// Automatically creates directory "some/dir"
task createsOutputDir(type: MyTask) {
    inputFile = file('does-exist.txt')
    outputFile = file('some/dir/output.txt')
}

class MyTask extends DefaultTask {
    @InputFile
    File inputFile

    @OutputFile
    File outputFile

    @TaskAction
    void doSomething { ... }
}

Usage of API:
// No validation
task noValidationInput {
    inputs.file('inputFile',  file('does-not-exist.txt'))
}

// No automatic creation of output directory "some/dir"
task noCreationOutputDir {
    inputs.file('inputFile',  file('does-exist.txt'))
    outputs.file('outputFile', file('some/dir/output.txt'))
}

We highly encourage development of custom tasks for performance and safety.
It doesn't seem like we have a great need for this right now, so I'm putting this in the Icebox until we have some.


feat: Support for IBM Cloud Kubernetes Service

@othomann

/ok-to-test
/test this

/test this
/ok-to-test

/approve


Fix Enchanter Extractor making tools indestructible.

Resolves #1491
This PR is meant to fix few different issues as well, but those fixes are in Titanium, so the PR with rest of the fixes is on there 😄
Titanium PR will resolve #1487 #1475 (Possibly #1473 😅)
Titanium PR https://github.com/InnovativeOnlineIndustries/Titanium/pull/131

I have honestly no idea why github still thinks commits above are missing :P


mention specific version of node-duration in readme

Hi there. I got briefly confused by conflicting versions of node-duration when following through the health-check example: I just went ahead and installed the latest node-duration but ran into the change in API. So I figured the readme could mention some use of this.

Hi @helgridly, thanks for raising the PR. Just for my understanding is the problem that you have an explicit dependency on node-duration, perhaps a 2.x.x version, which isn't working well with testcontainer's reliance on 1.x.x?

No, I don't have a dependency on node-duration at all, outside the use of testcontainers. My npm i -D testcontainers did not provide node-duration, so I had to manually install it myself. So I went ahead and ran npm i -D node-duration and got the 2.x.x version.

Hmm, I don't see how that can happen considering node-duration is a dependency: https://github.com/testcontainers/testcontainers-node/blob/master/package.json#L41
I just tried npm install -D testcontainers and I can see node-duration is there in the node_modules, do you think there could be something else going on?

On my install it's in node_modules/testcontainers/node_modules. It works fine if I import { Duration, TemporalUnit } from "testcontainers/node_modules/node-duration";, but that seems off to me. I am new to nodejs though so if this is normal, I'm happy to just do that.

@helgridly Could you pls share a repro and let me know what version of node/testcontainers you're using?

package-lock says "testcontainers": "^4.7.0". I'll try to whip something up for you now.

A reinstall of testcontainers fixed it for me. Weird. Thanks!

@cristianrgreco I am also running into this issue. I did "yarn add --dev node-duration", and the version that was installed was version 2.0.0, which seems to be incompatible with the version of node duration being used in testcontainers. Is there a way for testcontainers to re-export the node-duration module?
Maybe this library needs to mark a peer dependency on node duration version < 2?

Hi @vedantroy, I've decided to remove the dependency on node-duration: https://github.com/testcontainers/testcontainers-node/pull/157

This has been released in v5.0.0


[API] enable paggination for ListRepoTags

close #10453

please "update branch"

Codecov Report

Merging #10454 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10454      +/-   ##
==========================================
+ Coverage   43.68%    43.7%   +0.02%
==========================================
  Files         586      586
  Lines       81411    81411
==========================================
+ Hits        35561    35582      +21
+ Misses      41446    41428      -18
+ Partials     4404     4401       -3

Impacted Files
Coverage Δ

modules/git/command.go
86.95% <0%> (-2.61%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0%> (-1.93%)
:arrow_down:

models/gpg_key.go
55.37% <0%> (+0.55%)
:arrow_up:

services/pull/check.go
53.65% <0%> (+0.6%)
:arrow_up:

services/pull/pull.go
36.07% <0%> (+0.87%)
:arrow_up:

models/notification.go
65.18% <0%> (+1.05%)
:arrow_up:

modules/log/file.go
77.62% <0%> (+2.09%)
:arrow_up:

models/unit.go
39.5% <0%> (+2.46%)
:arrow_up:

services/pull/patch.go
62.89% <0%> (+2.51%)
:arrow_up:

services/pull/temp_repo.go
31.62% <0%> (+2.56%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4a982...25e5837. Read the comment docs.

@techknowlogick done ;)


Saving CMORized files with monthly precision when input data has incomplete years.

In order not to lose any data, I suggest modifying the function utilities.py/_save_variable to also take months as input.

This needs to be the "first step" actually.
To treat obs reasonable or apply different obs aggregations to compare them to model data, it should be possible to keep the original resolution and range. ( => similar issue on 1hr step width, etc.)

I will change this in a short bit today;
Note that for the specific problem of missing data in time: for the actual running of esmvaltool if you have, say three datasets all with end_year: YYYY in the recipe, but one of them is missing a few months from the end, you should be able to run OK but bear in mind for any multimodel operation that that dataset will be shorter in time; the tool does not auto-complete that dataset with missing values, and that should be done by you at diag level. Also if you are running with datasets that have end_year: YYYY + N for the datasets that have more data and keep end_year: YYYY for that dataset that is shorter in time, all works fine again up to multimodel operations where you have to align the data somehow for consistent data shapes

so in light of my comment above and https://github.com/ESMValGroup/ESMValTool/pull/942#issuecomment-476675715 I don't think we need months in the saver function unless it's daily data (but we need to address that case on a totally different level anyway)

fixed in https://github.com/ESMValGroup/ESMValTool/pull/942 so closing this one :beer:


Load MLIntentMatcher models that are not in classpath

Hi! I love this library--I've had good success creating chatbots with Microsoft LUIS for intent matching & entity extraction, and Ink for state/sequencing, so I think it's a great idea.
What do you think about adding the ability to load intent models that aren't in the classpath/aren't resources?  Maybe add an MLIntentMatcher constructor that takes a URL for the model, so it can load from anywhere?

Should be doable.

Have pushed com.rabidgremlin:mutters:1.1.0-SNAPSHOT to sonatype repo. Give it a whirl and let me know if the change works for you.

Change now in new release.

Looks good, thanks!


feedback from March 2nd workshop

[x] Re-organize the repo directory structure to remove the "Day x" folders. These seem to not be useful. Jupyter Notebooks should be available under the same directory so they are easy to find and use.
[x] Add dedicated 'Git Walkthrough' video to the YouTube channel. Emphasize a step-by-step example using GitHub Desktop and the Command Line (in Windows).
[x] Add dedicated 'Introduction to Git using Terminal' video to the YouTube channel. Emphasize a step-by-step example using the Terminal.
[x] Create a "quick introduction" Jupyter Notebook to hit on the highlights of the Python programming language for people who want a quick look. This will be complement to the 'full' fundamentals Jupyter Notebook. The "quick" Jupyter Notebook will be the one discussed during the workshop. The "full" Jupyter Notebook will be distributed to registrants two-weeks before the event.
[x] Create individual domain-specific Jupyter Notebooks for Machine Learning, Data Analytics, Robotics, Computational Geometry and IIoT so people interested in a certain topic can just zip to those.
[x] Develop at least two (2) do-it-yourself projects for per workshop day. Participants will either have the opportunity to work on the projects and/or listen to an overview of the "full" Jupyter Notebook. So there will be multiple paths available for people to learn Python depending on their personal preferences.

Also see issue #14


[Bug] Fix coroutine bug

Description

Fixes #601
The problem is this line initialResult.getOrElse(Response.error()). Since in the error case, the initialResult will be null then, it always return the empty version of Response.
The correct implementation is
it.fold({ (response, _) -> response }, { error -> error.response })

where we get the error.response in the error case as well.

Type of change
Check all that apply

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
We have test that is always emitting an error in the previous version.
assertThat(data, notNullValue())
assertThat(error, notNullValue())
assertThat(error.statusCode, equalTo(404))
assertThat(error.isSuccessful, equalTo(false))
assertThat(error.headers["foo"], equalTo(listOf("bar") as Collection<String>))

Request from @SleeplessByte

[x] tests that second is a response with the correct error code
[x] tests that third is a result with an error with a response with the correct error code
[x] test that BOTH link to the same "bodyStream" (as in you can use both as error)

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, if necessary
[x] My changes generate no new compiler warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Inspect the bytecode viewer, including reasoning why

@SleeplessByte I have addressed your concern here 0de4ef6 !! 🙏


HADOOP-18437. Fix type in StartEndTimeBase

Description of PR
HADOOP-18437
How was this patch tested?
Typo fix in the code
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 25s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 23s

trunk passed

+1 :green_heart:
shadedclient
20m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 52s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

103m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4894

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6a7bc77f0a0c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 40011ba1f5928f43e226ab1cc3e84b488273581d

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/testReport/

Max. process+thread count
740 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4894/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

please review this small change

This looks like a good typo fix to me. I don't see any instance of slowTaskRelativeTresholds elsewhere in the Hadoop code base.

Let me move to MapReduce project and change the title

Thank you @Samrat002 for your contribution and thank you @cbaenziger for your review.


Implement the "Register Dataset" services

Receiving a 403 Access Denied error while POST ajax call /com.sap.aa.c4pa.services/api/analytics/dataset/sync

Looked at trouble shooting tips


Add support for Thrift-generated PHP code.

Thrift-generated PHP files start with;
 <?php
 namespace Foo\Bar\Thrift;
 /**
  * Autogenerated by Thrift Compiler (0.9.3)

New tests are passing. How do I sign the CLA?

@askreet I think you can sign it here: https://cla.github.com.

New tests are passing. How do I sign the CLA?

With a pen. Careful not to scratch your screen, and don't scroll while signing the form.
Alternatively, just follow the link @pchaigno gave and click Sign in in the top-right corner (if you're not already logged in). You should see a link pointing to an agreement somewhere. I'm only saying "you should see" because I've totally forgotten what the agreement looked like back when I first accepted it:

EDIT: Wait, the link to accept the CLA is showing in the build results. Did you miss that, or wasn't it showing earlier?

It wasn't showing at least as recently as yesterday afternoon. I see it now, signing.

With a pen. Careful not to scratch your screen, and don't scroll while signing the form.

I've got one of those glass screens so I had to use a sharpie. How do I clear it after I sign? cmd+Z isn't doing anything!

How do I clear it after I sign? cmd+Z isn't doing anything!

Crap, I knew I should've recommended a pencil.

It wasn't showing at least as recently as yesterday afternoon. I see it now, signing.

Ah, that would explain it then. Thanks!
@brandonblack This is the second PR in the last few days where the build failure's neglected to show users the CLA link. Do you know if there's something going on with CI?

Anything else needed from me on this PR? Just want to be sure I'm not blocking this.


Authenticators list

Hello, I noticed that the list of authenticators is from another RP. Am I allowed to embed it?

Sure. It's not like it's anything confidential. Please note that it's updated from time to time.


Discord Notifications

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Add an Admin checkbox for pirep filed notifications
Describe alternatives you've considered
Only solution is to delete webhook and not get wanted award and rank notifications
Additional context

If you go to settings there is a checkbox for it already, that can stop those pirep filed notifications without having to remove the webhook. Go to settings>notifications and you can see all the settings for it. And if you use dispo basic go to the admin part and uncheck the pirep filed notification there too.

It is unchecked, but still sending the pirep filed notification. With it unchecked it is not sensed the phase of flight notifications.

Is your feature request related to a problem? Please describe.
In notifications Settings Admin panel, there is a pirep filed faulty option, if you set webhook public url, automatically a discord notification is send when a Pirep is filed.
Can't set others options without this option because there isn't check box to activate/deactivate Pirep filed Discord notifications.
Describe the solution you'd like

Describe alternatives you've considered
Additional context


GH-38372: [C++] replace memo table with a swiss table like implementation

Rationale for this change
replace memo table with swiss table to improve  set lookup functions, vector hash functions, the count_distinct aggregate function, dictionary unification .. perfomance.
related discuss: #38372
What changes are included in this PR?

add some bit utils
add SwissHashTable which implements MemoTable required interface and easy to integrate with the rest of the code

Are these changes tested?
Yes

Are there any user-facing changes?
No

GitHub Issue: #38372

this pr is work in progress now,  i will add some benchmarks and test this week

You can mark it as "draft" first


I need help!

Hi! I want to know if there is any solution for this kind of bug on the top of the window, cause it seems a little bit short than usual. And I want to know if there is any way to remove the Spotify premium sing on the top left.
Sorry for my English, it is not my first language.

Please follow the bug template and give relevant details on your setup, otherwise there is nothing we can do

Describe the bug
I want to know if there is any solution for this kind of bug on the top of the window, cause it seems a little bit short than usual. And I want to know if there is any way to remove the Spotify premium sing on the top left.
To Reproduce
Steps to reproduce the behavior:
Screenshots

Desktop (please complete the following information):

OS:  Windows
Version: 10

Logs

Is that the way to describe a bug? sorry if I miss understood the way to do it

Thanks, not sure if there's a universal way to describe a bug, but when you need help, you better share some details and context if you want others to understand what's going on.
So back to your issue, it's really weird. I'm wondering if that comes from Spicetify being mis-installed.
Can you go back to the Console screen showing the logs, clear it

and press F5 to refresh Spotify. Do you still get the red error message?

I uninstall spotify and spicetify and it works. Thank you so much!


The setting: karmaProcessCommand

Describe the Bug
I've tried running a few commands eg:
npm run something node_modules/.bin/gulp start node test.js and I've always received a message: 'Extension host terminated unexpectedly.'
[exthost] [info] ExtensionService#_doActivateExtension hbenl.vscode-test-explorer, startup: false, activationEvent: 'onLanguage:javascript', root cause: lucono.karma-test-explorer
Error in the developer tools
%c[Error: Attempt to end execution before starting it%c at rf.end (\.vscode\extensions\lucono.karma-test-explorer-0.5.0\dist\main.js:5122:28)%c	at Server.<anonymous> (\.vscode\extensions\lucono.karma-test-explorer-0.5.0\dist\main.js:31164:174)%c at Server.emit (events.js:327:22)%c at emitCloseNT (net.js:1659:8)%c at processTicksAndRejections (internal/process/task_queues.js:79:21)]

Steps to Reproduce the Behavior

Add e.g. "karmaTestExplorer.karmaProcessCommand":"node test.js" to the VSC settings in the project
Start plugin.

Describe the Expected Behavior
First run the commend form the setting, then start Karma.
Screenshot

System info

OS: Windows 10
Node Version: 16.13.0
VSCode Version: 1.64.2
Karma Version: 6.3.11

I have a few questions regarding the issue, basically those in the bug template if you can provide those here. Don't worry about logs and screenshots, but please provide all the other info, including OS and environment info to help better understand the issue.

@lucono ok, done :)

@chudzikm The karmaTestExplorer.karmaProcessCommand setting is for using a different or custom Karma executable, script, or command for launching Karma - rather than the Karma binary installed in your node_modules folder or environment.
It should be the name of a single command, or path to a single script/executable - without any arguments. For a script/executable path, it could either be an absolute path to the script, or a path relative to the project root. Karma Test Explorer will then call that script/command/executable instead - as if it were the Karma binary installed in your project (ie. in node_modules).
For instance, if you had karmaTestExplorer.karmaProcessCommand set to ./my-custom-script.sh, then Karma Test Explorer would run the following command when trying to launch the karma server:
# Normal command with no karmaProcessCommand setting:
npx karma start karma.conf --no-single-run

# Command instead with karmaProcessCommand setting:
./my-custom-script.sh start karma.conf --no-single-run

In your case, if you are trying to execute a command prior to launching Karma for your tests, what you could do is write a custom script (or windows batch file if you're on windows) that runs the command you need, before subsequently invoking Karma with all of the same arguments that were passed to the script. Then set karmaTestExplorer.karmaProcessCommand to your custom script.

@lucono thanks for your explanation.
I asked about it because I use Gulp for starting the tests. Maybe you could add a possibility to launch node.js scripts as well. It would be a more flexible solution because then you don't need to write binary scripts for all systems. What do you think?

@chudzikm Support for node scripts makes sense. Launching Karma is handled by the KarmaCommandLineTestServerExecutor. If you'd like to submit a PR, I'd be willing to review and release it.

@lucono ok :)

@chudzikm Please re-open or open a new issue when ready to contribute the feature.


📐  Add to C# Interface

🚨 Please review the guidelines for contributing to this repository.
Issue
Link your PR to an issue
Fixes #160
Description
Add chaum pedersen proofs to the c# interface
Testing

make test
make test-netstandard

Also as a note if you want to make a new release, it will start on a Milestone which will need a release version.


Add section on behavior when accessing Archived entries

Resolves #463

Preview is available here:http://developers-pr878.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr878.previews.kube001.services.stellar-ops.com


Heading block can support 3 levels (H2, H3, H4)

Or it could easily support H1 - H6 with a different configuration.

That's a much better idea than what I've done for sure. If you have the time, please go ahead. Otherwise I'll come around to it later today.


Updating packets for the new packet autocoder

Fix for F Prime PR https://github.com/nasa/fprime/pull/3035.

Merging to branch instead


What sort of hardware token?

I wonder if it's possible to give more detailed information than is currently shown by a tick under the "hardware token" column. In particular:

Can use a token that I already own? Or will the organisation issue me with a new token for use with my account? (The latter is typical with banks)
If I can use my own token, which type(s) of device does the service support? (e.g. Yubikey standard, U2F, Gemalto, ...)
Is it a hardware token that I plug in, or one which displays a code that I have to type in?
Does it require a PIN entry to unlock?
Do I need to install any additional software or browser plugins to work with it? (e.g. U2F)

This is all helpful in making decisions as to whether I want to use the service or not.
Suppose I want to use three services which have ticks next to them. Currently I might need to carry between 1 and 3 tokens, and I might need to buy between 0 and 3 of them, and I don't know without researching each of the service providers individually. Of course I can do this by following the Doc link, but I think this reduces the usefulness of this site.

It would be nice to provide more information without having to click into the docs links, but we have not found a way to do so. PRs are welcome.
A naive solution is to create five new columns to answer your five questions. Unfortunately, that doesn't scale and we'd still be missing something that someone would find useful--plus, we'd need to give the same treatment to the other columns (SMS, software, etc) resulting in an incomprehensible sea of checkmarks. I'd rather the site be sparse and usable than complete and unusable.

These are all legitimate questions that would be nice to address, however with the current structure of the site we would end with constantly-growing-mile-long-list of check boxes.
@candlerb If you have any suggestions on how we can represent all this info considering our current fully-static hosting limitations, feel free to share.
We intentionally decided to condense the site's layout to provide just the most critical info and put the onus of figuring out specific implementation on users.
Again, if you have specific ideas on how to represent it, please share.

Can't we add different kinds of ticks, like different colours or an intermittent tick (I'll add some images just now)?

Haven't we talked about this a few times already?

@Carlgo11 we have but this issue still comes up and we still haven't found a reasonable solution.
@Walkman100 what would they show?
Perhaps we could keep primary layout as is, but then have an expanding button that would show more technical details...And perhaps those could be fetched on-demand from category specific json files?

So you choose what categories/columns you want to see?

@mxxcon:
I propose replacing the tick with different icons representing a Yubikey Standard (black), a U2F key, a Gemalto key, a dedicated bank key etc. I'm sure key vendors would be happy to allow use of their icons. If a site supports more than one, then show multiple icons in the column. That answers my questions 1-2.
Each icon can be a link to the vendor's page giving more information on the product - or a local page with summary info, which in turn links to vendor page. In some cases like U2F, that could link to the FIDO page and/or multiple vendors. That is sufficient for my questions 3-5.
In the case of dedicated keys supplied by a bank, there could be an icon saying "custom" or "dedicated". Or maybe there could be a few generic icons showing the token type, e.g. token with display, token with display + PIN entry, USB-attached token.
Alternative proposal: retain the tick, but you can hover over it for more details (this is a simple tooltip, fine with a static site).
Personally I'd like to see at a glance how many sites are supporting each different token type.
@smholloway: I fully agree, the same is required for soft tokens too. I would certainly like to know which sites I can access using Google Authenticator app, for example.

@candlerb But then we are going to list every single 2FA provider that is compatible with Google Authenticator's system for every single site that supports it? Look how many we already have https://twofactorauth.org/providers/ and this is not the complete list.

Custom icons require a legend and a custom tooltip and ... Ugh. Scope creep. It's additional work that will lead to more additional work and it will displease as many people as it pleases. Worse usability and harder to maintain? :-1:
We'd also like the site to remain easy to contribute to. I think that adding a lot of custom data hurts the usability for contributors (on the backend) and users (on the frontend).

@mxxcon

Then we are going to list every single 2FA provider that is compatible with Google Authenticator's system for every single site that supports it? Look how many we already have https://twofactorauth.org/providers/ and this is not the complete list.

If there are a bunch of implementations of the same protocol (e.g. Google Authenticator) then I think they should be grouped under "Google Authenticator". Otherwise, it's unclear if the provider list represents a baffling profusion of different and incompatible OTP systems, or whether it's just a large number of vendors implementing a smaller set of standards.
As an end user, my main concern is: which sort of OTP system should I buy into? i.e. which one is implemented by the web sites that I care about? In fact, the reason I came to this site was after having obtained a U2F token to experiment with, I wanted to find out what sites other than Gmail I could use it with, and hence whether U2F is getting any traction (or will go the way of Google Wave).
Maybe I'm not your target audience, in which case, please excuse the noise.

We already show details about specific sites with the "exceptions" tag. Would it be possible to do something similar with the check mark in the Hardware column?
If not, or if that's too much work, then I believe that end-users are better off going through the doc links themselves. If you're interested enough in TFA to be using the site, you are obviously not too perverse to the idea of doing some research yourself.

We already show details about specific sites with the "exceptions" tag. Would it be possible to do something similar with the check mark in the Hardware column?

I also would think this is the best solution. :+1: Just a kind of tooltip/popup, which is shown on mouseover with all useful information in a short way.
The same of course also applies to "software implementation" - there are many kinds how 2FA can be implemented. For example:
TOTP: yes/no
HOTP: yes/no
own app: yes/no
And like this list it could be showed in the tooltip. As for yes/no you can of course also use the tick/cross image.
(This would also address https://github.com/jdavis/twofactorauth/issues/993)
I think this way we can keep the actual look as it is and users can still simply get more information if they are interested by just hovering the mouse over the feature.

If anyone would like to implement anything mentioned in this thread, feel free to submit a PR. Closing this for house keeping.


UI refreshes to workspace 'overview' constantly

Feedback
When using the UI, if I'm in the Workspace view looking at a particular workspace, if I go to any other tab than 'workspace', after about 5 to 10 seconds, the UI refreshes and reverts back to the 'overview' tab. I've tried this in a couple different browsers (Brave, Opera), and it does the same thing.

This is a bug maybe @jcanizalez could check when he has some free time


Stage to Main 10/21

Releasing:

https://github.com/adobecom/express/pull/1096
https://github.com/adobecom/express/pull/1200
https://github.com/adobecom/express/pull/1211
https://github.com/adobecom/express/pull/1214
https://github.com/adobecom/express/pull/1201

Pages to check for regression and performance:

https://stage--express--adobecom.hlx.live/express/?martech=off
https://stage--express--adobecom.hlx.live/express/pricing?martech=off

Codecov Report
Attention: Patch coverage is 56.38298% with 41 lines in your changes missing coverage. Please review.

Project coverage is 41.97%. Comparing base (86f2615) to head (994e05b).
Report is 592 commits behind head on main.

Files with missing lines
Patch %
Lines

express/scripts/utils.js
64.70%
18 Missing :warning:

...cks/how-to-steps-carousel/how-to-steps-carousel.js
28.57%
15 Missing :warning:

express/blocks/pricing-cards/pricing-cards.js
66.66%
3 Missing :warning:

express/scripts/template-search-api-v3.js
0.00%
2 Missing :warning:

express/blocks/marquee/marquee.js
85.71%
1 Missing :warning:

express/blocks/search-marquee/search-marquee.js
0.00%
1 Missing :warning:

express/scripts/instrument.js
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   36.42%   41.97%   +5.54%
==========================================
  Files         132       96      -36
  Lines       25932    22665    -3267
==========================================
+ Hits         9447     9514      +67
+ Misses      16485    13151    -3334

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


BUG 2222600: csi: update csi holder daemonset template

Currently the holder daemonset is never updated which will leaves the images the daemonset also not updated. we should update the daemonset template but not restart the csi holder pods which causes the CSI volume access problem, set the updateStrategy to OnDelete (already set in yaml files) which allow us to update the holder daemonset but not restart/update the pods, when a pod is deleted or node is rebooted the new changes will take effect.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>(cherry picked from commit 1ba3aa4d1972c6ecbc9ab3c9ae7ce1a5fbe0e8dc)

Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
[ ] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/bugzilla refresh

/bugzilla refresh

@subhamkrai This should fix it https://github.com/openshift/release/pull/42649

/bugzilla refresh


Increase specificity for hybrid ui

DO NOT PR TO STYLED-COMPONENTS
This branch currently has the code we are using to increase specificity of classes for the hybrid UI. It also includes the ability to push this to our private repo.

I was planning on leaving this in a branch for now. Unless we can identify a way to make it generic and submit it to styled components.

that sounds fine, another thing we need to figure out for cleanup post release and rollout


Custom UAA Server with PKCE: offline_access is added despite provided scopes

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.33.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.5.3
Public or Confidential Client?
Public
Description
I do use a custom UAA, not AAD. This server doesn't support the "offline_access" scope which is always added for clients with authorization code grant (see RequestParameterBuilder.addScopes).
When I try to make a login request the error offline_access is invalid. Please use a valid scope name in the request is thrown.
How can I prevent the default scopes to be added? My custom scopes are provided, I don't need additional default ones.
Error Message
offline_access is invalid. Please use a valid scope name in the request
Msal Logs
No response
MSAL Configuration
{
  auth: {
    protocolMode: ProtocolMode.OIDC,
    authorityMetadata: JSON.stringify({
      authorization_endpoint: baseUrl + '/oauth/authorize',
      token_endpoint: baseUrl + '/oauth/token',
      jwks_uri: baseUrl + '/token_keys',
    }),
    redirectUri: 'http://localhost:3000',
    clientId: config.auth.clientId,
  },
}

Relevant Code Snippets
const login = () => {
    msalInstance.loginRedirect({
      scopes: [
        'phone',
        'openid',
        'roles',
        'profile',
        'user_attributes',
        'email',
      ],
    });
  };

Reproduction Steps
I fear I can't give you a full repro because the UAA is internal.
Expected Behavior
I'd expect to only have the scopes  phone, openid, roles, profile, user_attributes and email in the login request, without offline_access.
Identity Provider
Other
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge, Safari
Regression
No response
Source
External (Customer)

@sandrooco We add offline_access as a default scope as it is expected be present for the issuance of refresh token as per the OIDC Spec.
Let me revert if we can make it optional for use cases like yours, we decided to keep it after some analysis in the past.

Thanks for the quick feedback! Then I will consult with the UAA server's provider.

Thanks. At this point I am inclined not to change on our end for a special case. Closing.

Just want to link this issue which is mine as well as this issue.
If one wants to control the session time of in a B2C tenant (according to the multiple sources as seen in the first linked issue) the offline_access scope has to be omitted.
Just closing the issue won't solve the problem folks.


Include only built-in compression algorithms as enum variants

This enables compile-time errors when a compression algorithm is requested which is not actually enabled for the current Cargo project. The cost is that indexes using other compression algorithms cannot even be loaded (even though they are not fully accessible in any case).
As a drive-by, this also fixes --no-default-features on cfg(unix).
Closes #2119

Just an idea I would to propose for discussion: I think having one really fast compression algorithm (LZ4) and one really flexible one (Zstd) might actually be enough and neither Brotli nor Snappy add anything substantially different.

Codecov Report

Merging #2121 (8b8449d) into main (ad76e32) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2121   +/-   ##
=======================================
  Coverage   94.38%   94.38%
=======================================
  Files         321      321
  Lines       60809    60810    +1
=======================================
+ Hits        57393    57394    +1
  Misses       3416     3416

Impacted Files
Coverage Δ

src/core/index_meta.rs
96.14% <ø> (ø)

src/lib.rs
99.05% <ø> (ø)

src/store/compressors.rs
97.18% <100.00%> (+4.98%)
:arrow_up:

src/store/decompressors.rs
98.21% <100.00%> (ø)

... and 2 files with indirect coverage changes

I am ok with hiding the enums. Can we however have an explicit error message about what feature is missing when opening an index with a compression format not compiled in the binary?

might actually be enough and neither Brotli nor Snappy add anything substantially different.

I agree.
+1 for ditching Brotli and Snappy.

might actually be enough and neither Brotli nor Snappy add anything substantially different.

I agree. +1 for ditching Brotli and Snappy.

I will propose this as a separate PR then so please see the PR title and can comment further on this.


[feat]: annotations as values

Definition of Ready

Annotations as values, required when using ArgoCD to inject their lifecycle hooks (https://argo-cd.readthedocs.io/en/stable/user-guide/resource_hooks/)
Bump chart 0.4.4

Thanks for the PR, will look into it in the current sprint.

Thank you a lot for the contribution, @oliverbaehler :tada: looks good to me.
If you would like us to show our appreciation by sending you some swag, send us a mail to<EMAIL_ADDRESS>We will then send you a form with some questions about the shirt size and other details.


pty: Add forkpty

Note: forkpty re-added to linux in rust-lang/libc#1313

Err... failed CI for OSX but it passed all the tests?

It hung on OSX.  Probably a bug in test_forkpty.  It also appears to be hanging on FreeBSD.  I'll terminate it.

@asomers yeah... i think i relied on linux kernel for how it handles a read after write. will fix in a bit.

@asomers Got CI passing. Take a look

@asomers Made the suggested changes.

@asomers Thanks for the comments. Since the initial code was based largely off of openpty a lot of the review comments could be applied to that function; I am happy to make another PR to refactor that.

@asomers anything left to fix for this?

@asomers done


EXC_BAD_ACCESS When Clicking

I am trying to imitate your code here, as the documentation for a Swift version of this (per your initial README) is non-existent. I am able to create the models and apply my data to them in a hierarchy that makes sense from a programmatic perspective, but the app keeps crashing when I click on the first-level items to expand them. It crashes with no better explanation than "EXC_BAD_ACCESS".
I've added some code here so you can see what I'm doing to some degree. As my code is proprietary, I cannot show you all of it.
If you can make any sense of the below, would you be able to give me insight as to why the app is crashing upon "click" of the top-level TaskWeek item?
Model Classes
import Foundation

class TaskWeek:NSObject {
  let number:NSNumber
  var day:[TaskDay] = []

  init(number:NSNumber) {
    self.number = number
  }
}

class TaskDay:NSObject {

  let number:NSNumber
  var task:[Task] = []

  init(number:NSNumber, task:Task) {
    self.number = number
    self.task.append(task)
  }

}

TaskListController
import Cocoa

class TaskListController: NSViewController {

  @IBOutlet var outlineView: NSOutlineView!

  var weeks:NSArray = []

  override func viewDidLoad() {

    super.viewDidLoad()
    outlineView.backgroundColor = NSColor.clearColor()

  }

}

// MARK: - NSOutlineViewDataSource
extension TaskListController: NSOutlineViewDataSource {

  override var representedObject: AnyObject? {
    didSet {
      // Update the view, if already loaded.
      println("updating view")
    }
  }

  func outlineView(outlineView: NSOutlineView, child index: Int, ofItem item: AnyObject?) -> AnyObject {

    println("child:ofItem")

    if let it: AnyObject = item {
      println("found an item")
      switch it {
      case let w as TaskWeek:
        println("requesting day in week, index is \(index) and count is \(w.day.count)")
        return w.day[index]
      case let d as TaskDay:
        println("requesting task in day, index is \(index) and count is \(d.task.count)")
        return d.task[index]
      default:
        assert(false, "outlineView:index:item: gave a dud item")
        return self
      }
    } else {
      println("about to return first weeks array item")
      return weeks[index]
    }

  }

  func outlineView(outlineView: NSOutlineView, isItemExpandable item: AnyObject) -> Bool {

    println("isItemExpandable")

    switch item {
    case let w as TaskWeek:
      println("is week expandable, day count: \(w.day.count)")
      return (w.day.count > 0) ? true : false
    case let d as TaskDay:
      println("is day expandable, task count: \(d.task.count)")
      return (d.task.count > 0) ? true : false
    default:
      println("whatever it is, we can expand it")
      return true
    }
  }

  func outlineView(outlineView: NSOutlineView, numberOfChildrenOfItem item: AnyObject?) -> Int {

    println("numberOfChildrenOfItem")

    if let it: AnyObject = item {

      switch it {
      case let w as TaskWeek:
        println("requesting days in week: \(w.day.count)")
        return w.day.count
      case let d as TaskDay:
        println("requesting tasks in day: \(d.task.count)")
        return d.task.count
      default:
        return 0

      }

    } else {

      println("requesting weeks available: \(weeks.count)")
      return weeks.count

    }

  }

}

// MARK: - NSOutlineViewDelegate
extension TaskListController: NSOutlineViewDelegate {

  func outlineView(outlineView: NSOutlineView, viewForTableColumn: NSTableColumn?, item: AnyObject) -> NSView? {

    println("viewForTableColumn")

    switch item {
    case let w as TaskWeek:
      let view = outlineView.makeViewWithIdentifier("DataCell", owner: self) as! NSTableCellView
      if let textField = view.textField {
        textField.stringValue = "Week \(w.number)"
        println("Week: \(w.number)")
      }
      return view
    case let d as TaskDay:
      let view = outlineView.makeViewWithIdentifier("DataCell", owner: self) as! NSTableCellView
      if let textField = view.textField {
        textField.stringValue = "Day \(d.number)"
        println("Day: \(d.number)")
      }
      return view
    case let t as Task:
      let view = outlineView.makeViewWithIdentifier("DataCell", owner: self) as! NSTableCellView
      if let textField = view.textField {
        textField.stringValue = t.name
        println("Task: \(t.name)")
      }
      return view
    default:
      return nil
    }

  }

}

Function that sets up the models and initializes the controller
    let mainStoryboard: NSStoryboard = NSStoryboard(name: "Main", bundle: nil)!
    let taskListController = mainStoryboard.instantiateControllerWithIdentifier("viewTaskList") as! TaskListController

    var weeks:Array<TaskWeek> = []

    var myTasks:[Task] = tasks.sorted({ $0.week.integerValue < $1.week.integerValue })

    var weekFound:Bool = false
    var dayFound:Bool = false
    var d:TaskDay
    var w:TaskWeek

    // set up weeks
    for task in myTasks {
      weekFound = false
      for week in weeks {
        dayFound = false
        if week.number == task.week {
          weekFound = true
          for day in week.day {
            if day.number == task.day {
              dayFound = true
              println("Day found. Adding task to existing day with name: \(task.name)")
              day.task.append( task )
              break
            }
          }
          if !dayFound {
            println("Day not found. Adding day for task with day of \(task.day) and name of \(task.name)")
            d = TaskDay(number: task.day, task: task)
            week.day.append( d )
          }
          break
        }
      }
      if !weekFound {
        println("Week not found. Adding week for task with week of \(task.week)")
        w = TaskWeek(number: task.week)
        weeks.append( w )
      }
    }

    dispatch_async(dispatch_get_main_queue(), {
      taskListController.weeks = weeks
      taskListController.view.frame = NSRect(x: 20, y: 100, width: tileButton.frame.width, height: tileButton.frame.height - 100.0)

      tileButton.wantsLayer = true
      tileButton.addSubview(taskListController.view)
    })

I solved my own problem. Turns out that because I was adding the "view" of the TaskListController, but never adding the TaskListController, OSX was disposing of the TaskListController after the view lingered for a few seconds. Thus, all of the scope wherein the hierarchy was created was thrown in the garbage, and further interaction failed.
I solved this by adding my TaskListController to the calling controller as a ChildController:
self.insertChildViewController(taskListController, atIndex: 0)

Glad you figured this out Frank.
All the best.
Daniel.


can't fetch proxy contract admin by calling admin()

upgrades version 2.5.3
/**

@return The address of the proxy admin.
*/
function admin() external ifAdmin returns (address) {
return _admin();
}
this call didn't return admin address on Remix, but the gas was deducted

Hi @chenqping!
Thanks for your question. I have posted it in the Community Forum, where it can get a faster response by the community and the team. I will close this issue so we can continue the discussion there!
https://forum.openzeppelin.com/t/cant-fetch-proxy-contract-admin-by-calling-admin/2443

Hi @chenqping,
This question has been answered in the Community Forum:
https://forum.openzeppelin.com/t/cant-fetch-proxy-contract-admin-by-calling-admin/2443


feat: Expose hover handler to be used as a handler

Hey @glepnir , I'd like to be able to do this:
vim.lsp.handlers["textDocument/hover"] = require('lspsaga.hover').handler

to be able to to make lspsaga just integrate into the rest of my builtin LSP stuff.
In general, I think it'd be cool to expose the handlers to be consumed a bit more independently if you don't mind.
Anyway, thanks, just checking out the plugin today :)

Love you

<3


Fix: add default icon color

Fixes Issue
Closes #860
Changes proposed
If icon does not exist in the icons list it is using globe icon as default ,
So, changed the mouse over color to use globe color as well.
Check List

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

I don't think it will cause any problem for other hover states.
As we are filtering links two times:
1.links which have valid icon i.e. icons which are present in the colors list
2.links which have invalid icon i.e. icons which are not present in the colors list
if icon is not in colors list we are already defaulting to globe icon.
So I'm defaulting the color to the globe color as well.
How it will cause problem?

Hey there! This is not how it should work, I think 😅 You have to do similar steps that are done in this PR #857 but for the globe icon. Let us know if you need any help! 😃

I looked into the solution of suggested PR but I think that was a different case, as the Icon was totally not there so he added the icon and also added the color for the icon .
but in this case the icon and the color is already there. (globe)
this PR is not to only fix the website icon issue but also to fix any icons hover effect which are not in the get icon component as well in colors list.
please let me know , if I miss something 😅

Ah yes, I looked at it properly and understand what you did now! LGTM!

great , thanks for the review . I should have titled the PR properly then it would be better to understand and will make sense what I did.


Okex dealer bot

Extracting ccxt functionality into generic exchange object to be used for any exchanges

this is not a good engineer practice:

the build is failing also. need to fix the Check code build stage


Regression in 1.5.0

If you sign a piece of data with @noble/ed25519 and make a copy of the signature using TypedArray.set, verification sometimes fails.
Repro:
const ed = require('@noble/ed25519')
const crypto = require('crypto')

async function main () {
  const privateKey = ed.utils.randomPrivateKey()
  const publicKey = await ed.getPublicKey(privateKey)

  while (true) {
    const payload = crypto.randomBytes(100)
    const signature = await ed.sign(payload, privateKey)

    if (!(await ed.verify(signature, payload, publicKey))) {
      throw new Error('Signature verification failed')
    }

    const signatureCopy = Buffer.alloc(signature.byteLength)
    signatureCopy.set(signature, 0) // <-- breaks

    if (!(await ed.verify(signatureCopy, payload, publicKey))) {
      throw new Error('Copied signature verification failed')
    }

    console.info('all ok')
  }
}

main().catch(err => {
  console.error(err)
  process.exit(1)
})

The above code with 1.4.0:
$ node index.js
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
all ok
...forever (probably)

With 1.5.0:
$ node index.js
all ok
all ok  <-- sometimes once or twice, sometimes never
Error: Copied signature verification failed
    at main (/Users/alex/test/ed/index.js:26:13)

Env:
$ node --version
v16.13.0

These both also occasionally break in the same way:
const signatureCopy = Buffer.from(signature.buffer, signature.byteOffset, signature.byteLength)

const signatureCopy = Buffer.from(signature)

This is a problem because if you're doing things like writing sigs into protobufs as libp2p does, sometimes verification will then fail after you read the sig back out of the protobuf.

Strange. Not sure how could this happen.

Uint8Array.set() seems to work correctly — only Buffer.alloc changes 31st byte.

 Besides them leaking private info [do a = Buffer.from(privateKey, 'hex') and then allocate a new buffer, and access its property — you'll see privateKey inside: b = Buffer.from('something'); console.log(hex(buffer.buffer).contains(hex(a))], buffers seem to not care about .slice().
Somehow it gets through our checks because buffer instanceof Uint8Array is true.
> a=Buffer.from([1,2,3])
<Buffer 01 02 03>
> b=a.slice()
<Buffer 01 02 03>
> b[1] = 34
34
> b
<Buffer 01 22 03>
> a
<Buffer 01 22 03>

For the record: Uint8Array.slice() creates a copy, not a subarray. You cannot reason about anything if it's subarray.

@achingbrain 1.5.1 will fix this, I still suggest to drop Buffers, they are dangerous and are not supported in browsers anyway. u8as are supported everywhere.

Unfortunately I don't think it's that simple.  Buffer.allocUnsafe(n) is faster than new Uint8Array(n) which makes a significant difference in hot code paths in node.js (with the obvious caveat about memory initialisation).
Uint8Arrays also seem to use more memory to represent the same data so they're not perfect, or even a drop-in replacement thanks to the .slice issue you point out.
Anyway thanks for fixing the issue.

Buffer.allocUnsafe(n) is faster than new Uint8Array(n)

Do you have any benchmarks?
Also if you're cool with using temporary shared buffers (= what Buffer.from / allocUnsafe), there's always an approach used in noble-hashes:
https://github.com/paulmillr/noble-hashes/blob/17ad99d82bf9f7b7f1397421da119c5ae0c4d73a/src/sha256.ts#L29
You can create shared uint8arrays and be fast.

Do you have any benchmarks?

const REPEAT = 100000
const size = 1024

let start = Date.now()

for (let i = 0; i < REPEAT; i++) {
  new Uint8Array(size)
}

console.info(`new Uint8Array(${size})`, Date.now() - start, 'ms')

start = Date.now()

for (let i = 0; i < REPEAT; i++) {
  Buffer.alloc(size)
}

console.info(`Buffer.alloc(${size})`, Date.now() - start, 'ms')

start = Date.now()

for (let i = 0; i < REPEAT; i++) {
  Buffer.allocUnsafe(size)
}

console.info(`Buffer.allocUnsafe(${size})`, Date.now() - start, 'ms')

start = Date.now()

for (let i = 0; i < REPEAT; i++) {
  Buffer.allocUnsafe(size).fill(0)
}

console.info(`Buffer.allocUnsafe(${size}).fill(0)`, Date.now() - start, 'ms')

$ node index.js
new Uint8Array(1024) 86 ms
Buffer.alloc(1024) 83 ms
Buffer.allocUnsafe(1024) 36 ms
Buffer.allocUnsafe(1024).fill(0) 46 ms


Swift Argument Parser for the CLI

Summary
Uses the new official Swift Argument Parser for the CLI. Allows for a simpler, more maintainable CLI.
Review Checklist

[x] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[x] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

I renamed them 👍

Thanks!

Thanks for a great review process!

Yay!  Thanks @liamrosenfeld


Remove genesis distrubtion notifcation

Feature
Remove the genesis distribution notification
Description
This notification still shows up for users in a fresh browser (closing it is saved in localstorage). The distribution was quite a while a go so the notification and the data CSV can be removed from the dashboard.\
If possible we can keep the notification skeleton for future use.

Fixed by https://github.com/effectai/effect-dashboard/pull/84


OAuth 2.0 error.

Hello, my problem is that I cannot access my gmail account. The program opens a window in my browser to give access to google, but when I enter my account and password it shows me an authentication error, I have tried in other browsers and the same error always appears.

yup! same issue here!

Hello, i'm getting the same issue here. Downloaded the latest build today and could not setup the Google apps.

same here

Seems like the developer, just forgot to add in their application client_id used for google SSO when using google's SSO API.

same here

Same here

Same here

Also having the same issue, hopefully there is a fix soon

Fixed in 2.1.0


Add a Razor class library project template

This would be the equivalent of the existing "Class library" template (here) but be pre-configured to support authoring Razor files. It would need the following:

It should target .NET Standard 2: <TargetFramework>netstandard2.0</TargetFramework>
The project's SDK should be set to the Razor SDK: <Project Sdk="Microsoft.NET.Sdk.Razor">
It should include a reference to MVC: <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="[version]" />
It should include a sample Razor Page and page model class in a "Pages" folder, named "Page.cshtml"
It should be available in the CLI via dotnet new and in Visual Studio in the "One ASP.NET Core" dialog

@jbagga, can you please handle this? Thanks!

@kichalla, assigning to you, as it seems @jbagga is overloaded.

Moving this out to the RC milestone

@DamianEdwards - was this the one you wanted in Preview2 as opposed to RC1?

It was another that was required, but this is still desired.

@jbagga, how long will this take? Should we change the cost of this?

@DamianEdwards should the class lib put things inside an Area by default rather than under /Pages.  Same concerns as https://github.com/aspnet/Mvc/issues/7608