Diplomacy Deals: Mutual resource highlighting isn't consistent

I have the problem, that ressources are colored which the other Civ doesn't have itself.
There are no deals between them and me.
First I suspected that the other Civs have deals among each other and this is an hidden information.
Update: More infos to the pictures:
Spain:

Isn't a Suzerain and have no coloring matter in his area...
Greece:

Suzerain, with the following bonus ressources:
1x cotton, 1x salpeter, 1x crabs, 1x fish, 1x  coloring matter
Cotton is highlighted
But why aluminium, horse and salpeter arn't highlighted?
Japan:

Suzerain, with the following bonus ressources:
1x cotton, 1x salpeter, 3x fish, 1x copper, 1x tabac
Cotton is highlighted
England:
Horse isn't highlighted

Very interesting... could you provide an affected save file?

@JHCD : strange, it has been very consistent so far in my tests/games, and I don't see anything that could explain this behavior in the code. Some options:

Provide a save so we can try it and see if it happens also on our end.
Try the new addition (IDS mod) once Chris commits it. It should show exactly what is happening.
Are you sure the resources are not coming from City States that the civs are Suzerains of?

Oh, I have forgottem the Suzerains... There is cotton and coloring matter available for Greek for second and third screen...
The first one isn't a Suzerains, so he have to have a deal with somebody.

I have updated the starting post...
@chaorace I sent you a savegame per eMail

Here's a link in case anyone else wants to check it out as well

@JHCD : the code is in place only to check for duplicates regarding luxuries. I am not sure if it makes sense to also check for strats. In any case, we should first test/try the customized IDS mod and see if that fits our goals better, or if we need to modify it further.

Tested the save file with both the present diplodealview and the new IDS mod:
OK, so Spain was the first claim... Spain has Dyes coming from "another civ" (I modified the code so that it only shows from where it comes if it is the player)
Pericles has Cotton and Dyes as suzerain of Kandy and Yerevan
Japan has cotton as suzerain of Mohenjo something
So all Highlights are working as expected, both in the present diplodealview and in the IDS mod.

As there was no further feedback on the issue, and we have tested the alleged save file to demonstrate the feature is working as intended, I am closing this item.

That was not as intended, I don't want to see highlighted ressources from deals between other civs.
I will check this after the new implementation.

Hmmm... I see your point. The thing is, a good player (notice I am not even saying master player) will be able to know exactly that (that the other civ is receiving a resource from a third unknown civ) by just asking "What will you give me for this?" and analyzing the AI valuation of the item. If the valuation is low when it is expected, given the relations between trading parties, that is should be higher, the good player already knows. Therefore, it can be strongly argued that the information is really there, but in an indirect manner.

@JHCD : definition of software bug:

A software bug is a problem causing a program to crash or produce invalid output. The problem is caused by insufficient or erroneous logic. A bug can be an error, mistake, defect or fault, which may cause failure or deviation from expected results. Source: https://www.techopedia.com/definition/24864/software-bug-
A problem that causes a program to produce invalid output or to crash (lock up). The problem is either insufficient logic or erroneous logic. For example, a program can crash if there are not enough validity checks performed on the input or on the calculations themselves, and the computer attempts to divide by zero. Bad instruction logic misdirects the computer to a place in the program where an instruction does not exist, and it crashes. Source: http://www.pcmag.com/encyclopedia/term/51664/software-bug

This is not a bug. The code is doing exactly what it is supposed to, and is not showing inconsistent results. The fact that you don't want the result is not a bug, but a feature issue. We can debate if we should or should not show some info, but that does not make a bug.
I will not enter a childish bug-notabug contest with you. Let the owner decide.
@chaorace : please resolve this at your discretion.
(this is what happens when you go from Dictatorship to Democracy in one sudden step) ;)

Yes, I was rather enjoying the enlightened autocrat thing, alas, you two bring too much to the table to pass up!
Right, so it's not bug. The goal of the highlighting is to alert you when the player already has a resource you could be trading him. The goal isn't for it to just be a visual shorthand for what's visible on the other side of the deal tray. That being said, there is still an issue here, as clearly demonstrated by the appearance of what feels like a bug.
Okay, so summing it up: it's not a bug in the software, it's a bug in the users. We need to accommodate for the incorrect assumption users are going to make by preemptively and transparently informing them what that highlighting is supposed to mean. I feel the best way to achieve this is by having a highlighted item's tooltip say "TRADE PARTNER ALREADY HAS A COPY OF THIS X". We don't divulge how, or why, because that is potentially very unfair information, but we do at least divulge how what we're telling them already works

That being said, I'm re-christening this issue as an enhancement in light of it's non-bug nature, instead suggesting that we need to be more clear about exactly what this highlighting means.

Agreed. OTOH, I will not touch this until we test, and then decide, about IDS addon. You know my bet where my bet already is; we can modify that addon a piacere, when/after we decide what we want from it, but the overall design and presentation is excellent and we should use that.
Any chance you commit that one so everyone interested can also test it? I am using it full time now, no regrets.

Something I could know isn't the same as directly shown without thinking.
It isn't allowed to take a opening book to a chess tournament.
They are all well known, but have it in mind or lose it.

Same cheating issue with the new mod.
You haven't access to this information normally...

@JHCD : not directly, no. It's relatively easy to filter out, same with the city info. I was about to do this before integrating the mod, but decided to leave them in to hear more feedback.
For the resources that the other civ already posseses, and that come from another civ, should we:

Leave as is (assumes the indirect way of "knowing", low trading valuation, is not cheating)
Adopt chao's solution: mark them as "already possesed by this civ" (almost no difference with 1)
Take them out and leave only the ones that come from "suzerained" CS (direct info available)

For city info of trading partner, should we:

Leave as is
Take out all yield info
Take out some yield info

I prefer only to show known and not to declose hidden informations.
So I would select 3 and 2 :)

My goal with BUG Mod for Civ4 was to give the player all the information they can find in the vanilla UI, but quicker. If you can trivially deduce that an AI is receiving a resource from another player—even if it's not explicitly shown in the UI—I'd show it. It's a bit of a gray area I agree, but I think much less murky than the chess metaphor.
I'd liken it to watching a chess match where you aren't told who is playing white, and your job is to guess. But you get to see the list of moves the players took during the game, Bob moved first, and you know that white always moves first. Well duh, Bob is playing white. That's not a fun game to play, so just tell the player. :)

I decided to remove the "Trade with other civ" imported resources. Vanilla civ 6 does not give any indirect way to know if a resource is being imported by a given civ from a third party civ. Gossip items, at best, only say "Civ A is trading with Civ B", but that is not enough to deduce that some specific resources is being traded, even if the map is known. Valuation of items by the AI has also proven to NOT be trustworthy as a way to deduce that the civ already has some resource (this is not Vox Populi's AI, it's Firaxis AI).
Thus, non-cheat policy in this case means no showing of imported resources when the local player is neither the importer nor the exporter.

There is an issue with this ressources:
IDS Terry before trade:

Trade:

IDS after this trade:

Report-Screen:

All screenshots are from the same game round.
I have no other merchandise trade.
There are some things cracy...

Duplicate or not?
Where is my Whale and Salt?
I'm not sure Terry has Oil.
...

Jens, I never saw what you report in my games, I just finished a long game and the diplo deal screen was always accurate... I don't know what happened in yours, but if we cannot replicate or test, we cannot leave this open.

Here is my savegame to the pictures above:
MONTEZUMA 1 - IDS dr.zip

You are right, something is effed up in that game with IDS... I will have to investigate more, I don't see the wrong in the code yet, but there are definitively discrepancies between IDS and vanilla diplo deal view in your save in terms of results. Vanilla shows Terry having Oil, although I couldn't find it either... perhaps hiding underneath some district or wonder... this game is so badly coded in terms of UI, geez...
I will try and dig into this later.

Oh, one idea for the oil could be the Great Person...

ah, exactly! still, there is something wonky with IDS here and I cannot find the problem yet...

aorite, I think I got it. Very silly bug from original IDS. Try the file with your saves and let me know if it works fine now. It is working fine in my setup with your file, but you know that game better and will find any discrepancy faster, if any.
https://drive.google.com/open?id=0B_TA2f5G0Z78cWN5bUdZUnQwUk0

Let's start the next iteration ;)
The Bonus ressources from "Sansibar" aren't shown in the IDS screen:

The other ressources seems to be correct.
Here is the savegame:
FRIEDRICH BARBAROSSA 2 - IDS dr.zip

@JHCD @chaorace : the last one is NOT a bug. Sanzibar is a special case of 2 lux bonus resources that they "have" in their coffers for their suzerain, and not as part of the map. Those 2 resources are truly UNIQUE and unrepeatable, therefore will NEVER be trade-able. Thus, by definition, they do NOT belong in the diplo deal view. Remember that in vanilla only trade-able items are shown, regardless of replication, but non-tradeable are never shown.
The function of IDS is to show trade-able resources, and the ones that are duplicate to help the player NOT to repeat trades. The function of IDS is NOT to show ALL available resources.
NOT a bug.
I will not close this issue (although I should), and will let Chris decide if to close it or not.

If it's not accessible in the API, it's okay for me.


Tweak build to extract common versions to project root

I am a little concerned about bumping Gradle to beta version and in turning on Java 8 (in most commercial projects is is not turned on) but I think this we can do it. It is more readable this way.


Merge branch dev into main (fix #13)

Now a template for testing through GitHub Actions is ready to be used.
fix #13

Yo @mgpai22 check that out.
You should be able to see the automated tests under the `All checks have passed! If you have any questions do not hesitate to open a discussion and I will explain them to you 🔥
Please merge this PR  once you have checked everything.

@mgpai22 Let's get this to main ooooohhhhh


Command line options to preheat and home

This PR provides new command line options to pre-heat the tools (both extruder 1 & 2), the bed, and home everything.
It's very much targeted for 3D printing where preheating is relevant.
IMPORTANT - this only implements the SACP protocol - I have an Artisan, and that's all I can test against, but I think it'll work against other printers that use the SACP protocol.
PS: This is my first go project, so hopefully the code is not too nasty.
Thanks!

Thanks, the code is great, but I'm sorry I didn't understand why we need to execute the preheat in the command line.
Can you describe use cases?
And to me, it is very dangerous for the machine to exec HOME out of sight, such as knocking over the filament in front of the bed.

Thanks! For me I have my printer downstairs, and my computer is upstairs. So when I'm nearly finished designing something I turn on the printer (it is plugged into a WiFi smart switch), and start everything preheating. That way when I get downstairs it's ready for me to load the filament and start printing right away. I also find preheating the entire enclosure helps with bed adhesion, so can take 10-15 minutes, and having this means I don't need to go up and down (or what I was doing is opening Luban, which homes, and then getting it to start preheating by setting the tool and bed temperature).
I always leave my printer in a known state (ie: filament unloaded, and enclosure closed), but I totally understand if you feel it's too risky for others, I can keep this in my fork and we can close this PR.
Cheers.

You have good habits👍, but I have some bad memories (breaking my printer :(

I think i can accept this PR and leave the choice to users.

Thanks! :)


missing quotes on image-based-upgrade.md

Background / Context
Missing double quote on upgrade md.
Issue / Requirement / Reason for change
Missing double quote on upgrade md.

/lgtm

/ok-to-test

/cherrypick release-4.16 release-4.15 release-4.14


DaemonSetJob: implement jobTemplate update

Issue: #71

Add JobSpec md5 hash in Job annotation.
Add more unittests for daemonsetjobcontroller.Sync method

Codecov Report

Merging #78 into master will increase coverage by 4.49%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   29.79%   34.29%   +4.49%
==========================================
  Files          17       17
  Lines        1638     1671      +33
==========================================
+ Hits          488      573      +85
+ Misses       1114     1052      -62
- Partials       36       46      +10

Impacted Files
Coverage Δ

pkg/controller/common.go
35% <100%> (+35%)
:arrow_up:

pkg/controller/daemonsetjob.go
48.25% <41.17%> (+14.92%)
:arrow_up:

pkg/controller/job_control.go
11.47% <45.45%> (+11.47%)
:arrow_up:

pkg/controller/controller_util.go
45.83% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457cc08...9c0470b. Read the comment docs.

@sdminonne let me know if you have others remarks after my changes

thanks!


Feature helm Ci

Problem
Fixes this issue https://github.com/ContainerSolutions/trow/issues/171
Also added CI to test the Helm Chart

I think we should run on every branch so PRs get checked.


Enhancement implementation of #141

Hi @justinyoo
i implemented enhancement mentioned in this issue,  i hope you will like it
Resolves #141

Thanks @emrekara37 for the PR! I've left a few comments for you to review.

i updated what you want

Thanks @emrekara37 for the PR! I've left a few comments for you to review.

i updated

Thanks for the update. It LGTM, except...
Can you also please add test cases of your changes - GetStylesheetAsync(...) and GetJavaScriptAsync(...) to this test class by creating a FakeUriCustomUIOptions class that has references to external URL for CSS and JS?

Added test cases

Thanks @emrekara37 for your contribution!


Add ability to change image filename

Adds the ability to change how files are named in advanced options

If the template string is removed, it uses the default.
Allows more details to be added to the filename optionally and however the user wants

Closes #132
Closes #44

Might make a separate template for animated images or just hide this when using animations.
Haven't tested this yet, just made the code changes. Going to review myself before taking it out of draft.

Sweet - I will try to check this out tonight, if possible. Let me know when it's ready for me to look at.

@benrugg It is ready for review, I've tested locally and am happy on my side.
I imagine you already see this, but my commits are terrible so probably squashing them would be best

@LeonardMeagher2 thanks for implementing this! (And the other PR, too). I will review them both as soon as possible - hopefully today.

I just submitted an update to your fork: https://github.com/LeonardMeagher2/AI-Render/pull/2
I have a few more thoughts on what we should do to make it a little more foolproof for others. Would you be ok working on this a bit more?

[ ] Strip any non-available template keywords before attempting the format in get_image_filename()

[ ] Replace invalid filename characters in prompt and negative_prompt (currently this just fails silently)

[ ] Make sure filename isn't too long (ideally, limit the size of prompt and negative_prompt to fill the available space after all other keywords have been used)

[ ] Should we offer a hyphenated version of prompt/negative_prompt as a keyword option?

[ ] Should we make {suffix} part of the template that is controllable? (would probably need to add suffix automatically if it wasn't specified??)

Feel free to push back on anything or start a conversation about any of it!

I like the ideas, I'll try and see what I can do!

Nice, thank you again for working on it!

@benrugg I've added filename sanitization, do you want to try it out again and see if that's enough?
I might be able to remove the suffix stuff all together, since we can replace data blocks for the images.

@LeonardMeagher2 I will check this out as soon as I can. It will probably be tomorrow, unfortunately. For the suffix part, I don't think we can remove it altogether, because then the files would overwrite each other (on the disk, not necessarily in Blender).

About to release this. Thank you again for all this work! I made a couple small changes: sanitizing the template of any vars that aren't allowed, and allowing a bit more punctuation and spaces again. (I figure it would be nice to be able to copy and paste the prompt back from the filename).


Feedback from user

Hi, I am writing regarding PerfTool. I have attempted to install and use this tool together with Rails 5 application. Following the instructions provided, installation was successful. However, it was not possible to use the tool, as routing problem occurred saying it "No route matches [GET] /perf-tool". Would it be possible to rails specific instructions to make this tool work? Best regards, Juozas Beniusis

In my opinion, this could be resolved, just user needs to add route, that will allow to navigate in directory.

I've have attempted to solve the problem as advised, but problem keeps occurring.
Steps taken:

Create controller "perftool" with action "index" in it
Created route
get '/perftool', to: 'perftool#index'
Added line of code to "index" action in controller
render "#{Rails.root}/node_mdules/devbridge-perf-tool/index.html"

Error occurring:

Missing template home/zeus/ruby_workspace/juozasben/node_mdules/devbridge-perf-tool/index.html with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :jbuilder]}. Searched in: * "/home/zeus/ruby_workspace/juozasben/app/v

Any advice on how this should be handled would be appreciated.

@beniusij - can you describe, why third step is added? After launching gulp task, do you have perf-tool directory created in same level as node_modules are?

Third step was added to link route to the directory of perf-tool. Therefore, I thought best solution would be to render index.html file in the directory. After launching gulp task, devbridge-perf-tool folder was created in node_modules directory. Breadcrumbs would be: MyProject > node_modules > devbridge-perf-tool.

really, in node_modules directory? because it should be created in root project, where package.json is located, not inside node_modules.

Please, see a screenshot of my working directory. As instructed, gulp task was executed in root of project.

@beniusij - how you are installing it and why you don't have gulpfile inside project (and there is no package.json file too)?

Using command line:
$ cd ruby_workspace/juozasben  $ npm install devbridge-perf-tool --save-dev
After that, I add block of code (see below) to the top of gulpfile.js.
require('gulp').task('perf-tool', function () {     var options = {         siteURL:'http://www.google.com',         sitePages: ['/', '/voice']     };     return require('devbridge-perf-tool').performance(options); });
Finally, I go to http://localhost:3000/peftool
There were no requirements stating that gulpfile or package.json are required, nor instructions on obtaining those two prior tool's installation.

Using command line:
$ cd ruby_workspace/juozasben
$ npm install devbridge-perf-tool --save-dev
After that, I add block of code (see below) to the top of gulpfile.js.
require('gulp').task('perf-tool', function () {
var options = {
siteURL:'http://www.google.com',
sitePages: ['/', '/voice']
};
return require('devbridge-perf-tool').performance(options);
});
Finally, I go to http://localhost:3000/peftool
There were no requirements stating that gulpfile or package.json are required, nor instructions on obtaining those two prior tool's installation.

@beniusij this is self explanatory, no one is running modules and editing files in node_modules (as I understand, you tried to run it from node_modules directory?)

This creates package.json in your project directory

Here, you should add YOUR gulpfile, instead of editing existing one in node_modules.


RadListView return object

I have a problem with radlistview, everything works fine if it contains a simple array.
But if the array contains an object, the resulting output is an object.
<radListView items="{items}">
                <Template let:item>
                    <label text="{item.id}"/>
                </Template>
</radListView>

<script>
import { Template } from 'svelte-native/components';
let items = [{'id':1, 'myitem':'item 1'}];
</script>

What is the output of this?

Object, object

I have fixed some listview logic in the lastest svelte-native, and svelte-native-nativescript-ui (which are the NS7.0 supported versions) that might resolve this issue.

@halfnelson what are the fixes you made? Don't see them (and would love to add those to my comp if needed)

It was the case sensitivity fix for attributes. Not 100% sure it fixed it,
but it helped resolve a similar issue with listview
On Sat, 12 Sep 2020, 5:34 pm Martin Guillon<EMAIL_ADDRESS>wrote:

@halfnelson https://github.com/halfnelson what are the fixes you made?
Don't see them (and would love to add those to my comp if needed)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/halfnelson/svelte-native/issues/156#issuecomment-691435252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGS5HHHVMHS3FCZZM5RKTSFMP7NANCNFSM4OB2AAZQ
.

OK then i get it toi ;)


Rename Parameter to Parameters

Our class currently called Parameter is actually a parameter list, and should be renamed accordingly: Parameter.kt
This is a small but breaking change. Preferably, it would still go into 2.0.0 - but could otherwise wait for the next major release. I can prepare a PR quickly.

Good point. Let's do this in the 2.0.0 release. Then it's out of our way 👍

Please see my comment in the PR.

Closed with https://github.com/andregasser/bigbone/pull/106


fix(web-components): ic-tooltip no longer interferes with previousSibling

Ic Tooltip would, when the previous element is conditionally rendered in react lifecycle, replace the contents of it. Now we store ariaDescribedBy in a variable so we don't search for that previousElementSibling

Summary of the changes
Changed how updateLabel() functions, instead of getting the previous element sibling on every call, it refers to an ariaDescribedBy variable created on load.
However, i've been unable to add a test - because the issue occurs during react apps with conditional rendering. We only have web-component unit tests. I will enquire with the developer team :)
Related issue
#986
Checklist

[x] I have added relevant unit and visual regression tests.

Would it be possible to add that code snippet in your comment as a react story?

Would it be possible to add that code snippet in your comment as a react story?

I spoke to the tech lead about that, and we decided that since it was demonstrating a bugfix, rather than a feature of the component, it shouldn't remain as a story.


limitRows per sheet bug

Prerequisites

[X] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[X] Checked that your issue isn't already filed.
[X] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 5.6.33
Laravel version: 5.4
Package version: 2.1.0

Description
Import - limitRows function not working as expected.
The limit should be per-worksheet, not per-workbook.
Steps to Reproduce
If the first and the second worksheet has 20 rows and the row limit is 10, then the first 10 rows are imported from first worksheet, but none of the rows are imported from second worksheet.
Expected behavior:
Import the set amount of rows from every worksheet.
Actual behavior:
Only imports the set amount of rows form first worksheet.
Additional Information
ExcelParser.php
line 374

// Limit the results when needed
if ( $this->hasReachedLimitRows() ) {
break;

$this->currentRow should be reset here.

Thanks for submitting the ticket. We will pick it up as soon as we have resources available (as stated in our support guidelines (https://laravel-excel.maatwebsite.nl/docs/3.0/getting-started/support)).

@hodasza can you confirm if resetting $this->currentRow fixes the problem for you. In case it does, please open a pull request. Thanks in advance.

Closing due to inactivity.


Timezone not working correctly on a specific time.

There was a change to update moment from a deprecated function that I believe broke this.
https://github.com/ncb000gt/node-cron/commit/8292201f8c23fea34cf622af1677ff494f607e89#diff-3cd84c85d62ad8c039570bad30d09ca8R16

Agreed, this broke timezone functionality for me.

This is now fixed in 1.0.9. Sorry.


Allow for simple aliases on the database level [feature]

This is somewhat related to #1243 (renaming/copying of databases) but maybe easier to implement:
Allow to assign aliases to databases, and to use these when connecting to a database. That way one could update e.g. a graph without reconfiguring clients (renaming would allow this kind of behaviour, too).
Edge cases, like what should happen with active connections when an aliases is reset to a new database, can be handled by convention (connections are untouched) or configurable (stay connected, silently move to the new database after finishing all transactions, terminate the connection, ...)

Any plans/progress on this one? This is a feature that would really help in our use-case of arangodb w/ foxx

Hi, it will eventually become possible to implement this with the rocksdb storage engine. However its currently not hot on the roadmap.

Hi, it will eventually become possible to implement this with the rocksdb storage engine. However its currently not hot on the roadmap.


The navbar of Blogs page is active towards about

Reproduction steps
In Blogs page the about icon is active in navbar.

Expected behavior
The blogs icon should be active in navbar

.
Actual Behavior

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

I am a  GSSoC participant please assign me this issue

@DeveloperAshish8  Go for it.


To modularize

Can this function,
https://github.com/metatexx/go-app-todo/blob/fa31d5c2b4dafb0cbf116ee03e9cb8a03415ef58/frontend/todos.go#L84-L86
somehow be modularized as a member function like the following please?
https://github.com/metatexx/go-app-todo/blob/fa31d5c2b4dafb0cbf116ee03e9cb8a03415ef58/frontend/todos.go#L61
I want to modularize all functions in UI definitions, but don't know how to deal with extra variables like i in above case. Thanks.

I do not understand what you mean with "modularise" the function? You could expose the handler as "c.OnChangeHandler(int)" and call that instead using the same closure to capture the i.
 OnChange(func(ctx app.Context, e app.Event) {
 	c.OnChangeHandler(i)
 }),

You could also give some other parameter to the handler, like the todo entry itself.

Ha, sure, I was thinking to replace func (ctx... altogether with a single function, but that works as well. Thanks!

To replace the full function, you would use a function factory that gets the i and creates an app.EventHandler that includes the i in a closure. We do this quite a lot because then you have a nicer layout of the code.

We do this quite a lot because then you have a nicer layout of the code.

Yeah, that's what I was hoping to achieve. Would it be too much trouble to show us how you are able to do it please?


A security vulnerability submission

Hello, I found a vulnerability. I want to know how to submit vulnerability details and vulnerability reward rules. You can contact me via TG(@RedTeamPing).


WIP: Make subchannel refcounted

Not ready for review.
Based on #17988

This is something that we still want to do when we have time, but it's been so long since we've looked at this that I don't know whether it's worth keeping what's currently in this PR or starting over.

We need to start over because there are too many conflicts and it's based on a PR that needs to be done in a different way.


chore: typo

[ ] I wrote tests for the feature
[ ] I documented the feature if needed

If the feature is a refactor, please explain why your way is better

Thanks @spacydujun


dp.show event does not work when datetimepicker shows as inline element

Hello,
I'm implementing the datetimekeeper as an inline element, so I'm trying to store the initial date value on a hidden input, but the dp.show event does not work. It's never been called. I guess its because the datetimepicker element is shown inline (the dp.change works great). Any ideas on how to solve this issue?

The show event shouldn't fire for an inline picker since it is already open.


New HTML5 Player design broke resizing

Hey,
I just got hit with a new HTML5 Player Design which broke resizing. Using Build 497 on Chromium  41.0.2272.118

In fullscreen, the changes are more evident

Haven't yet received the transparent player. Can you open your console, enter this:
ytplayer.config.assets.js

And share with me the link it shows? I want to try forcing the script on my side to see if I can get it to cooperate.

Can confirm this is also occurring on Safari on the latest dev version. Feels like I've had this bug for over a year now. I just want videos to fill the actual player size...

@Vashetti Are you also getting the transparent player like the original poster? If so can you do what I asked in my reply above so that we can study the code and try to find a solution?

Happening on FF dev build.

@CrisBRM Can you do what I asked in my replies above? Otherwise it will be impossible to find a solution if we do not have access to the same player that you guys are receiving.

"//s.ytimg.com/yts/jsbin/html5player-en_GB-vflii3He3/html5player.js"
This video: https://www.youtube.com/watch?v=I2qBBBvYQOA

@Yonezpt I don't have the transparent player, no.

@Vashetti Then your issue is different than this one, you should create a new issue because this one is specific to the new YouTube transparent player.

@Yonezpt My issue has had several threads on it in the past. Safari videos rarely fill the screen, people say download the dev version, but it never seems to fix the specific Safari issues, despite people saying the video size filling issue is fixed on Chrome, Firefox, etc.

@Vashetti Then it's a matter of waiting until the addon author has the time to address the issue. It has been reposted recently in #1606

Alright, after fiddling around with the script shared by @CrisBRM I can conclude that the resizing fix that I created is still working correctly. I replaced the YouTube player script I am receiving with the one shared by Cris and the video resizes as normal, so the issue lies somewhere else.
@CrisBRM Does your YouTube player also have transparent controls like the one shown in the screenshots posted by pezam?

@Yonezpt No, it's the normal YT player.

@CrisBRM Then your problem is also not the same issue as the one reported by the OP, but most likely the same as @Vashetti

Hey, sorry, my cookies get deleted every time my browser exits, so I don't have that player anymore. Hopefully someone else can get you that info, I'm sure they'll roll it out further soon.

@pezam So am I correct in assuming that the issue is no longer present now that you have the normal player?

Because of this problem did not use HTML5 long time. On FLASH all works well
Use Opera 29.0.1795.30

@Uoipka Unless your player also has transparent controls like the one displayed in the OP's screenshot, then your problem is not related to this one and has already been reported. Also make sure that you are using the latest dev version 497 which can be downloaded from here: https://github.com/YePpHa/YouTubeCenter/wiki/Developer-Version

@Yonezpt You're right, it works now.
Thanks!

@Yonezpt, well dev version fix problem "broke resizing" but i can watch only 360/720p quality now seems like new problem

@Uoipka Are you sure it's still forcing Flash? Can you try with both player types?

@CrisBRM flash have all 360,480 etc... HTML5 have only 360,720HD

@Uoipka Check that you don't have DASH disabled in YTC options. I don't know Opera's HTML5 capabilities, but if they are like firefox 36 and below then you will only get 240p/480p and 720p when using the HTML5 player. See  #1197 and #1080

@Yonezpt oh, it's problem from opera. i try same and waiting for opera developers... he have MSE & H.264 support at opera://flags/ but it buggy.

@Yonezpt Yes, I suppose for the time being it can be closed.


cairo: Use AsRef for custom subclassing types

Instead of requiring the user to go through the Deref implementation
Fixes #189

Instead of requiring the user to go through the Deref implementation

The user would just do bla(&surface) currently or not? Autoderef would figure out the correct type. The same would of course also still work now :)
Also good that you kept the Deref impls: otherwise you'd need to add a lot of extension traits which would be unnecessarily verbose in the single-inheritance case. Do you implement Deref also in gsk/gtk or only AsRef?

The user would just do bla(&surface) currently or not? Autoderef would figure out the correct type. The same would of course also still work now :)

Yes, and it is clearer in terms of API from the type system directly.

Do you implement Deref also in gsk/gtk or only AsRef?

I think so yes

Yes, and it is clearer in terms of API from the type system directly.

Also documentation-wise. It's clearer that you can pass any kind of surface, not just Surface.


Bug: iframe usage causes MathJax config to be ignored

Issue Summary
When I use MathJax in an iframe, my tex2jax config is ignored (both in parent window and in the iframe, even when it is loaded and configured in each one). Configuring tex2jax in a window without an iframe seems to work fine. So it seems like just including an iframe in the DOM breaks custom configs.
Steps to Reproduce
See this fiddle for a broken example with an iframe.
https://jsfiddle.net/a0abhk1j/1/
Just a simple iframe pointing to google:
https://jsfiddle.net/a0abhk1j/2/
This fiddle has the exact same non-iframe code, and works as expected:
https://jsfiddle.net/1dxpp9nm/

MathJax Version: 2.5.3 (https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML)
Client OS: Mac OSX 10.9.5
Browser: Chrome 44 / FF 39

The configuration script in your iframe is incorrect.  It should be type="text/x-mathjax-config", not type="x-mathjax-config" (it needs to look like a MIME type).  If you change that, the configuration is processed as expected.

Ah, thanks!


Md-datepicker broken selection indicator

Bug
When used in Chrome under Os-x, then date picker's selection indicator changes form to elliptical.
What is the expected behavior?
Date picker's selection indicator is in form of circle.
What is the current behavior?
When used in Chrome under Os-x, then date picker's selection indicator changes form to elliptical.
What are the steps to reproduce?
No special precondition, example code copied to blank project from Material website:
<md-input-container>
<input mdInput [mdDatepicker]="myDatepicker" placeholder="Starting">
<button mdSuffix [mdDatepickerToggle]="myDatepicker"></button>
</md-input-container>
<md-datepicker #myDatepicker></md-datepicker>

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4.1.1
Material 2.0.0-beta.5
TypeScript 2.2.2
Os-x Sierra 10.12.1
Chrome  58.0.3029.110 64bit
Example

I can't reproduce it @taokakao. Perhaps there are some global styles on your page that also end up leaking into the datepicker (e.g. a CSS reset)?

Yes, on new project I can't reproduce it as well. Sorry :-)

Can inspect the styling to see what may be causing it? It could still be valuable to set some default on the datepicker so it's not affected by it in the future.

I inspected. Totally my fault, no defaults needed, I guess. There were paddings for th:first-child, th:nth-child(n+2):nth-last-child(n+2) and th:last-child set.

Ah thanks, not much we can do about those, apart from sprinkling !important all over the place. My initial thought was that it could be something with box-sizing: border-box.


Improve the discovery of the doc comment for symbol (or may be a symbol for a doc comment)

Search terms
Doc comment
Description
I'm using the excludeNotDocumented option to prevent symbols w/o documentation to appear in the docs.
Sometimes I need to document in the inline object type, for example for function arguments:
        elementPointIsReachable (
            target : ActionTarget,
            options : { offset : ActionTargetOffset, allowChildren : boolean } | ActionTargetOffset,
            description? : string
        )

The type of options argument appears as {} in the docs (this is expected, because of the excludeNotDocumented):

Now, to include them in the docs, I'm trying to provide a documentation for the properties:
        elementPointIsReachable (
            target : ActionTarget, options : { /** include */ offset : ActionTargetOffset, /** include */allowChildren : boolean } | ActionTargetOffset, description? : string
        )

The result, however, is the same:

To make it work, the doc comment needs to reside on the separate line, above the symbol:
        elementPointIsReachable (
            target : ActionTarget, options : {
                /** include */
                offset : ActionTargetOffset,
                /** include */
                allowChildren : boolean
            } | ActionTargetOffset, description? : string
        )

This produces:

Expected
I'd expect, that the exact location of the doc comment should be not significant. The doc comment should just precede the symbol it documents, whether on the same line, or on the next line.
Environment

Typedoc version: 0.22.6
TypeScript version: 4.4.0
Node.js version: 12.22
OS: Ubuntu 18.04

Side note. In my custom fork, based on TypeDoc 0.17, i was using different heuristic for the excludeNotDocumented option - all properties of object literal types should be included (similar to enums). This is exactly to support the case of documenting the inline object types. Perhaps it should be applied in the current version. If you approve it, I can make a PR for it.
function shouldBeIgnoredAsNotDocumented (node: ts.Declaration, kind: ReflectionKind): boolean {
    // never ignore modules, global, and enum members
    if (kind === ReflectionKind.Module || kind === ReflectionKind.Global || kind === ReflectionKind.EnumMember) {
        return false;
    }

    // do not ignore properties of the object types, that has comment themselves, for example
    //
    // /**
    //  * has docs
    //  */
    //  export SomeType = { prop1 : string }
    //
    // same applies to the inline types for function arguments:
    //
    // function someFunc(arg1 : { prop1 : string, prop2 : number }) {...}
    //
    // The `prop1` from above should be included in the docs, even that it has no documentation
    // Note, that this does not seem to apply to classes and interfaces - for those, even the class/interface
    // has docs, we still want to exclude the undocumented properties
    // Thankfully for object literals the kind of properties seems to be set to ReflectionKind.Variable
    if (kind === ReflectionKind.Variable && hasCommentOnParentAxis(node)) {
        return false;
    }

    const hasComment: boolean = Boolean(getRawComment(node));

    return !hasComment;
}

function hasCommentOnParentAxis (node: ts.Node): boolean {
    let currentNode: ts.Node = node;

    while (currentNode) {
        if (Boolean(getRawComment(currentNode))) { return true; }

        currentNode = currentNode.parent;
    }

    return false;
}


@angular/cdk/drag-drop not working in lazy-loaded Module.

Bug, feature request, or proposal:
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Can you post any error that you might be getting?

Not getting any error

It's hard to tell what's going on without looking at code. Most likely you have to import the DragDropModule into your lazy-loaded module.


Add PR Template

i will take this one :-)

Great! you take this. Your wish where you place it or what you put in it (should be according to the repostitory). I think root directory is perfect.


Issue #746 and #748 - sum type for prev HeaderHash

In the formal spec, the block header contains the hash of the previous block header. It is assumed that the type is the same so that the first Shelley block can point to the last Byron block.
In the exec spec the type of the previous block header is a newtype wrapper of a Hash with a phantom type for the type of the block header.
I think it makes sense for the formal spec to have just one type for hash of the header, and for the exec spec to use an Either for the two cases. But I'm open to suggestions! @ruhatch do you have an opinion?
I've also kept the Byron hash very simple so as not to import the real types from cardano-ledger. It is just the hash of a natural number.
closes #746
closes #748

You can actually leave it as only a single hash and ignore the fact that there is a different byron hash type. The consensus layer will do the work of making sure that the hash gets translated across the fork, so that each ledger implementation can act without knowledge of its location in a chain of hard forks :)

Ok, thanks @ruhatch ! So when writing examples that involve creating a first shelley block, perhaps I can just artificially start with some previous shelley header hash? I suppose if we leave comments explaining that we would actually use the hard fork combinator in a real implementation then there should not be any confusion. yea?


Release: Is Chrome 43 in 0.27.0 or 0.27.2?

I am a bit puzzled what Chrome version is in 0.27.0. It says 43 in the release notes but then 0.27.2 has an entry "Fix wrong chrome version". Does this mean 0.27.0 ships with Chrome 42 although the release notes state otherwise?

43; https://github.com/atom/electron/issues/1808

@bpasero The "Fix wrong chrome version" patch is just changing the reporting of the version, not the actual contents afaik. You definitely want to use 0.27.2 though, because 0.27.[0/1] had a lot of pretty bad problems

What is confusing to us is if we trace through the commits for 0.27.1:
·         Electron Shell Version: 0.27.1
o    https://github.com/atom/electron/tree/v0.27.1
·         Electron Shell consumes Brightray @8fba2a
o    Look in /vendor and then click on the brightray commit
o    https://github.com/atom/brightray/tree/8fba2a883552ad939a63250b552f467fa4f9bedb
·         BrightRay consumes libchromiumcontent @d5c126e
o    Look in /vendor and click on libchromium content commit
o    https://github.com/atom/libchromiumcontent/tree/d5c126e2d8fd181a94720c64b18196505b937041
·         Libchromiumcontent version file says chrome 42.0.2311.107
o    https://github.com/atom/libchromiumcontent/blob/d5c126e2d8fd181a94720c64b18196505b937041/VERSION
·         Therefore, Electron 0.27.1 consumes Chromium version: 42.0.2311.107
o    https://gsdview.appspot.com/chromium-browser-official/chromium-42.0.2311.107.tar.xz
We need to understand the exact version for our licensing files and to post to http://3rdpartysource.microsoft.com/.
Thanks,
Chris
From: Paul Betts<EMAIL_ADDRESS>Sent: Thursday, June 11, 2015 9:59 AM
To: atom/electron
Cc: Chris Dias
Subject: Re: [electron] Release: Is Chrome 43 in 0.27.0 or 0.27.2? (#1938)
@bpaserohttps://github.com/bpasero The "Fix wrong chrome version" patch is just changing the reporting of the version, not the actual contents afaik. You definitely want to use 0.27.2 though, because 0.27.[0/1] had a lot of pretty bad problems
—
Reply to this email directly or view it on GitHubhttps://github.com/atom/electron/issues/1938#issuecomment-111206707.

@paulcbetts we are currently on 0.27.1 and planned to ship our next update with that. I am curious about the actual issues you are talking about. Should we go for 0.27.3 even?

@bpasero If your app works you can go with it, as I recall 0.27.0 was just completely busted (devtools segfaulted the app), and 0.27.1 had a broken WebView

@paulcbetts got it. the devtools issue was the reason for us to update to 0.27.1. I noticed the webview changes but we are not using the web view at all in VS Code.

v0.27.1 actually ships Chrome43 but there was a bug that the version was not changed.

Ok thanks!


HTTP-01 Cannot read challenge, EOF

Bugs should be filed for issues encountered whilst operating cert-manager.
You should firsmpt to resolve your issues throhe cugh tommunity support
channels, e.g. Slack, in t atteorder to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
Waiting for http-01 challenge propagation: failed to perform self check GET request 'http:///.well-known/acme-challenge/│
│CzA': Get "http:///.well-known/acme-challenge/": EOF
Expected behaviour:
A concise description of what you expected to happen.
Certificate should be created
Steps to reproduce the bug:
Steps to reproduce the bug should be clear and easily reproducible to help people
gain an understanding of the problem.

Create an ingress using nginx-ingress-controller

Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): v1.16.6
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): DigtialOcean
cert-manager version (e.g. v0.4.0):  v0.4.1
Install method (e.g. helm or static manifests): helm

/kind bug

The same thing is happening to me in DigitalOcean, using Kubernetes 1.16.2 and cert-manager 0.14.1. In my case, the install method was via static manifests.

Would it be possible to get more information about the configuration of both cert-manager, the requested certificate and the ingress? I am not able to reproduce this.

I guess I have exactly the same problem with Digital Ocean.
I debug it a bit and it seems that I can't access the challenge url from any of my pods, but it is accessible from anywhere else.

The solution can be found in #2744

I'm going to close this in favour of #2744 - thanks @shenek 😄

I'm facing the issue in the OP as well, with EOF, not with timeout as the proposed solution is solving. Strange thing is that a different DigitalOcean clustler worked fine this week. Can the cause be with lets encrypt rate limits?

+1 same issue on a brand new DigitalOcean cluster. The challenge url is accessible via curl and on the browser but I see the EOF error in the challenge. The fix indicated in https://github.com/jetstack/cert-manager/issues/2744 doesn't fix the problem for me. Any other suggestions as to why this is happening?
Reason:      Waiting for http-01 challenge propagation: failed to perform self check GET request 'http://redacted.com/.well-known/acme-challenge/rnJzHpnY-ImRckpQ-.........': Get "http://redacted.com/.well-known/acme-challenge/rnJzHpnY-ImRckpQ-.........": EOF
  State:       pending

I recommend trying to reach that URL from inside the cluster using the shell in a test pod, that will allow further checking why it is failing.

@meyskens HellO! I have the same issue. When I am trying to reach that URL from inside the cluster using the sell in a ingress-nginx-controller pod (or any other pods) I get this error
bash-5.1$ curl http://my.domain.com/.well-known/acme-challenge/jaZAy4B89dsW5bCvjexyn4X9m0CR0HnsiKEB_seu-ug
curl: (52) Empty reply from server

With the higher level of verbosity I get this
bash-5.1$ curl -vvv http://my.domain.com/.well-known/acme-challenge/jaZAy4B89dsW5bCvjexyn4X9m0CR0HnsiKEB_seu-ug
*   Trying ...
* Connected to my.domain.com (...) port 80 (#0)
> GET /.well-known/acme-challenge/jaZAy4B89dsW5bCvjexyn4X9m0CR0HnsiKEB_seu-ug HTTP/1.1
> Host: my.domain.com
> User-Agent: curl/7.83.1
> Accept: */*
>
* Empty reply from server
* Closing connection 0
curl: (52) Empty reply from server

Could you please help me to resolve this issue? Thanks!

+1 Having the same issue.
Getting a valid response from outside the cluster pods.
Within the cluster pods getting EOF, not timed-out errors.

Had the same issue, followed step 5 in this tutorial: https://www.digitalocean.com/community/tutorials/how-to-set-up-an-nginx-ingress-with-cert-manager-on-digitalocean-kubernetes#step-5-enabling-pod-communication-through-the-load-balancer-optional
Resolved the issue for me.

Hello ,
you should check in the ingress controller logs , in my case i was using gke cluster with an external network passthrough load balancer , and i was mistakenly using use-proxy-protocol: `true in the helmrelease configuration , and the load balancer is not of type proxy, i received broken header error , after setting it to false everything works as expected


Replace isomorphic-fetch with node-fetch

Given problems as describe in #14 it probably makes sense to replace isomorphic-fetch with node-fetch.
Let's keep this up for discussion for a while to collect feedback/hear objections.

@schickling, I don't recommend using node-fetch. Although it works with some browsers, it doesn't on those who doesn't support window.fetch natively such as IE11-. One possible candidate would be whatwg-fetch but it's not suitable for node environments.
isomorphic-fetch found a way to get the best of both worlds but it came with a flaw: a bug that stops it from working on React-Native enviroments, issue 125 also mentioned on #14. The problem is that repo is not maintained anymore. So we're orphans here.
Probably a lesser known project like (fetch-everywhere)[https://github.com/lucasfeliciano/fetch-everywhere] would do the trick or you can roll out your own!

Thanks a lot. This is great input!

First off, thank you for this package. It has helped me out tremendously. As for this discussion, I have been having success using fetch-everywhere.

We have issues with a lot of fetch alternatives. For instance, isomorphic-fetch has this bug, is no longer maintained and is outdated. fetch-everywhere is in the same situation but with the bug fixed. Both of them polyfill is mandatory. This can be an issue sometimes.
That's why I created cross-fetch. We have this project for a huge e-commerce company here that the same javascript codebase needed to run on several platforms (react-native included). No lib felt right for this job. But now we use cross-fetch: it's fixed, updated and cross-platform.

Thanks a lot for your comment @lquixada. I'm excited to see your project and hope it stays well-maintained and up-to-date (I know how hard this can be!)
Would you (or someone else) mind creating a PR using cross-fetch?

Thanks for accepting my PR! I'm so excited! I'll finally be able to move my graphql migration foward! 🎉


Support multiple APIs

Web GCS should support multiple APIs, both switchable in views like HUD and Config, and simultaneous in views such as VR and Planner.

Cannot work out how to track status/location/etc simultaneously from multiple clients:
https://github.com/Akryum/vue-apollo/issues/216

https://medium.com/open-graphql/apollo-multiple-clients-with-react-b34b571210a5
https://www.apollographql.com/docs/graphql-tools/schema-stitching.html
https://blog.hasura.io/client-side-graphql-schema-resolving-and-schema-stitching-f4d8bccc42d2


Clarification of Middlewares section in README.md

There was some inaccuracies in Expanding stack of Middlewares section. I talk about retry middleware.
First of all there is no more VK::ApiException and VK::BadResponseException. We will use VK::APIError and VK::BadResponse instead. I also add Faraday::ConnectionFailed to exceptions because it happens sometimes.
Second thing is retry_if: lambda { |env, exception| true }. Since default HTTP method is POST for this library we should add retry_if block that returns true because POST is not idempotent method and should define retry_if block or add :post to methods like this:
methods: [:delete, :get, :head, :options, :put, :post]

Otherwise retry middlewire just will not work (if you still have verb: :post in config).
I spent few hours to realize what is going on. And hope someone will find this helpful.
P. S. My editor remove all trailing spaces here. Sorry for that.

@toydestroyer :+1:


400 Bad Request Unknown client_id

with the '-vv' flag, the following output is captured:
"Storage> 1
Amazon Application Client Id - leave blank normally.
client_id>
Amazon Application Client Secret - leave blank normally.
client_secret>
Remote config
Use auto config?

Say Y if not sure
Say N if you are working on a remote or headless machine
y) Yes
n) No
y/n> y
2017/05/19 00:43:47 DEBUG : Starting auth server on <IP_ADDRESS>:53682
If your browser doesn't open automatically go to the following link: http://<IP_ADDRESS>:53682/auth
Log in and authorize rclone for access"

The following is captured thereafter from browser window:
We're sorry!
An error occurred when we tried to process your request. Rest assured, we're already working on the problem and expect to resolve it shortly.
Hide Details
Error Summary
400 Bad Request
Unknown client_id
Request Details
client_id=amzn1.application-oa2-client.6bf18d2d1f5b485c94c8988bb03ad0e7
redirect_uri=http%3A%2F%2F<IP_ADDRESS>%3A53682%2F
response_type=code
scope=clouddrive%3Aread_all+clouddrive%3Awrite
state=d03097e18a138894b25c1a27e2d0edf0

Please refer to issue 1409
rclone's tokens might have been banned temporarily.  Nothing concrete yet though.

I put a post in the forum which I'll update as and when I hear more info.

I have noticed the same issue.   I hope rclone is not band.

Same issue here.

@ncw sorry for posting here but I don't have a forum user.
You updated that amazon have banned since the secret are kept in code
Does that mean the fail to implement the oAuth2 protocol regarding native app shared secret ?
https://tools.ietf.org/html/draft-ietf-oauth-native-apps-07#section-8.9a
We had this discussion regarding g drive in #309 before .
Having an external server might cause more issues than it actually solves and the only situation where it might make sense is if Amazon has security flaws in the way the implement oAuth2.0

Hi there, thanks for the wonderful tool.  I encountered bad 400 error also.
THIS FROM MY POWERSHELL:
PS C:\rclone> c:\rclone.exe copy --retries 999 --low-level-retries 10 c:\source remote:target
2017/05/24 12:44:49 Failed to create file system for "remote:target": failed to get endpoints: Get https://drive.amazonaws.com/drive/v1/account/endpoint: oauth2: cannot fetch token: 401 Unauthorized
Response: {"error_description":"Client authentication failed","error":"invalid_client"}
PS C:\rclone>
THIS IS FROM CHROME:
We're sorry!
An error occurred when we tried to process your request. Rest assured, we're already working on the problem and expect to resolve it shortly.
Hide Details
Error Summary
400 Bad Request
Unknown client_id
Request Details
client_id=amzn1.application-oa2-client.6bf18d2d1f5b485c94c8988bb03ad0e7
redirect_uri=http%3A%2F%2F<IP_ADDRESS>%3A53682%2F
response_type=code
scope=clouddrive%3Aread_all+clouddrive%3Awrite
state=a4c18c7e455cf7e1c3730354d9527db3

@yonjah wrote

You updated that amazon have banned since the secret are kept in code
Does that mean the fail to implement the oAuth2 protocol regarding native app shared secret ?
https://tools.ietf.org/html/draft-ietf-oauth-native-apps-07#section-8.9

I've not seen that before, but it hits the nail on the head - thanks for pointing that out.
Yes, amazon are treating the client ID/ client secret as confidential even for native apps.

We had this discussion regarding g drive in #309 before . Having an external server might cause more issues than it actually solves and the only situation where it might make sense is if Amazon has security flaws in the way the implement oAuth2.0

I don't really want to run an auth server and personally think it is the wrong approach.  However if it gets rclone back online then I'll go with it.
I've yet to hear back from Amazon though.

As a workaround, it is also not an option for people to get them selves their own Security Profile from Amazon, and use their personal Client ID 	/ Client Secret values? I thought that this odd to work but having tried that just now (rclone authorize), even that appears to be a no-go:
Error Summary
400 Bad Request
An unknown scope was requested
Request Details
client_id=
redirect_uri=http%3A%2F%2F<IP_ADDRESS>%3A53682%2F
response_type=code
scope=clouddrive%3Aread_all+clouddrive%3Awrite
state=5d0c7c86489f4ee4803c89744ea69ded

What I don't understand, is what just keeps another client from pointing to
the same authorization server?   I can't really see how an authorization
server adds security...  If anything it reduces security, because it adds
one more layer that can be hijacked to steal login credentials.
On 24 May 2017 at 02:31, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

@yonjah https://github.com/yonjah wrote
You updated that amazon have banned since the secret are kept in code
Does that mean the fail to implement the oAuth2 protocol regarding native
app shared secret ?
https://tools.ietf.org/html/draft-ietf-oauth-native-apps-07#section-8.9
I've not seen that before, but it hits the nail on the head - thanks for
pointing that out.
Yes, amazon are treating the client ID/ client secret as confidential even
for native apps.
We had this discussion regarding g drive in #309
https://github.com/ncw/rclone/issues/309 before . Having an external
server might cause more issues than it actually solves and the only
situation where it might make sense is if Amazon has security flaws in the
way the implement oAuth2.0
I don't really want to run an auth server and personally think it is the
wrong approach. However if it gets rclone back online then I'll go with it.
I've yet to hear back from Amazon though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ncw/rclone/issues/1420#issuecomment-303630566, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADBcWMVcecSoOlkemmFEJgqfgcQ_eWjZks5r887NgaJpZM4NgExj
.

hmm, acd_cli solved this issue, is there any progress with rclone?

How about go through the normal web approach using Python?  That way no matter how Amazon changes its protocol we can always get through.

I have the same problem (400 Bad Request Unknown client_id) when trying to configure a new remote for amazon drive.
Before that, I encountered the following problem

2017/05/27 08:47:53 Failed to create file system for "amazon:/KQA/20170520/": failed to get endpoints: Get https://drive.amazonaws.com/drive/v1/account/endpoint: oauth2: cannot fetch token: 401 Unauthorized
Response: {"error_description":"Client authentication failed","error":"invalid_client"}
(I am in Taiwan time GMT+8)

This is response to a similar copy command I have been using for months.
After a short search, I decided to remove the remote 'amazon' and reconfigure it again.  Then I ran into the problem above.
Looks like rclone is having a problem with Amazon.
So, I just have to wait for the rclone guys to sort it out with Amazon people and help us with a workaround?

Same issue here about unknown client_id with latest rclone download on Ubuntu

same issue on my side: 400: "unknown client_id"

@carlyuanliu, @LoopControl and @jtHunter.
Please read this forum post
https://forum.rclone.org/t/rclone-has-been-banned-from-amazon-drive/2314

I'm going to close this issue now - for the resolution see https://forum.rclone.org/t/rclone-has-been-banned-from-amazon-drive/

Had same problem with yandex disk. In the last beta version at 02/13/2020 all works fine.
links https://beta.rclone.org/

@ilkarataev This is entirely unrelated and the situation regarding Amazon Cloud Drive hasn't changed. This type of issue almost never translate from one backend to another and should always be discussed in a separate issue.


Multiple tasks in the same page

First of all - I found this project to be the best tool out there when it comes to open source, thank you for that!
I am trying to customize it to my needs, but I think it is worth having this idea out there. The task I have at hand actually involves simultaneous labeling of text (named entity type), text sentiment analysis (annotator to give a quality metric of the provided text) and image polygon annotation (given information in text provide polygons on the image). These 3 elements should be displayed on the same screen for annotator's convenience.
I think I am no the only one who is dealing with multi-labeling this way. I am not asking this to be a core feature of this project, but it might be worth having in mind that this possible design can be useful.

Hi @fakyras, thanks for the kind words. More is coming before the end of the year!
To your use-case, I think that can be supported out of the box right away? Something like that:
<View>
  <Header value="Label the text" />
  <Labels name="labels" toName="txt">
    <Label value="Label 1" />
    <Label value="Label 2" />
  </Labels>
  <Text name="txt" value="$text" />
  <Header value="Qualify the text above" />
  <Choices name="sentiment" toName="txt">
    <Choice value="Choice 1" />
    <Choice value="Choice 2" />
  </Choices>
  <Header value="Provide the Polygons" />
  <Polygon name="poly" toName="img" pointSize="small" pointStyle="circle"></Polygon>
  <Image name="img" value="$image" />
</View>

You can try it out here https://labelstud.io/playground/
Please let me know if that's what you were thinking about.

@deppp Wow. this just solved all my issues! Really really thank you!
With such easy customization, in my eyes it is already a production ready annotation tool.

@fakyras Glad to hear that!
Well, the open-source version is still a bit edgy in terms of setup, we've open-sourced it not that long ago from our commercial solution. But I expect it to be more polished in the next couple of months! Also, if you have more questions, feel free to join a slack channel.
Best, Michael


fix folder + button group

fix #169
buttonGroup with empty key overwrites folder structure. I change empty key to __LEVA_EMPTY_LABEL_ for buttonGroup and hide this label in component.
I hope you like fix and let me know if you find better solution for this issue.

Hi @jeetiss — sorry for taking so long to get back to you. Thanks a lot for opening a PR that's much appreciated.
I think that this problem is not circumscribed to the button group, but rather to whole idea of having empty keys. After discussing a bit, I think we should just flag empty keys with a warning and not add them to the panel.
Do you think you could try to implement this? We have a warn / error system function inside a log.ts file that should help.

Hello @dbismut,
I revert my previous commits and implement empty key warning.
Yes, this is a better way to fix this problem, thanks for suggestion

@jeetiss perfect thanks for spotting the issue and the quick help ;)


issue 1252, GRPC exception status code to HTTP status code could be i…

…mproved
fix: #1252

Awesome. You signed the ICLA already, right?

Yes, signed before😁

Updated 😉

@trustin @hyangtack @minwoox  Thanks for your comments!
Rebased to latest master branch and change to use EventLoopRule along with other refactoring.
Only one small concern left: https://github.com/line/armeria/pull/1305#discussion_r205329712

Thanks a lot, @demongaorui!


trouble with gpio

Hi
hope someone can help me, as I'm trying to solve this issue since hours, but no success :-((
if I include the command:
const Gpio = require('onoff').Gpio;
in my node_helper
I get this error during start of MM:
/home/pi/MagicMirror/node_modules/electron/dist/electron js/electron.js: symbol lookup error: /home/pi/MagicMirror/node_modules/epoll/build/Release/epoll.node: undefined symbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR<EMAIL_ADDRESS>start: ./run-start.sh
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2020-06-10T10_31_46_539Z-debug.log
working on raspi4
raspian is up to date
gpio -v  brings 2.5
sudo usermod -a -G gpio pi  -> no error
sudo npm install onoff brings: -> no error
I really hope soemeone can help. I only want to switch a relais on/off within MagicMirror.
Switching the relais outside MM, with separate js file works fine.
Gürkan

Please refer to http://forum.magicmirror.builders for support and troubleshooting.
I'm closing this issue for now. If you feel this issue should remain open, please let me know.


[WIP] refactor: base32 encoded CID v1 by default

BREAKING CHANGE: CIDs created by this module will default to v1 and will be base32 encoded by default.

[x] depends on https://github.com/ipfs/js-ipfs-unixfs-importer/pull/21

Still pursuing this?


Update Emissions API Validation

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[x] Does this have a dev link been provided in the design?
[x] Is this traceable to a feature, epic, or PI?

User Story
As an Emissions API user I want the system to validate if a required parameter is empty so that I can successfully build a query
Acceptance Criteria
Given that a user has made a GET request to an Emissions endpoint (see context for list of endpoints)
When the system detects that a required parameter is empty or null
Then the system returns the following error message: <  insert property  > should not be null, undefined, or empty FV-106
Development Notes
Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
We just need to add extra validations for required parameters. Basically, right now the validation only cares if it's a variable defined in the query, and it passes even if it's empty. Stuff like this was passing validation but crashing the api
/mats/attributes/applicable?beginDate=&endDate=
I fixed it for MATS hourly and MATS filter logic, but we'd need to fix it for all endpoints with required params
Example 1 : https://api.epa.gov/easey/dev/emissions-mgmt/apportioned/hourly?api_key=T8r7OW4f12XtWKLY7CPgKmKu1WoP3TVG0x4eqmlB&beginDate=-&endDate=&page=&perPage=
Example 2: https://api.epa.gov/easey/dev/emissions-mgmt/apportioned/hourly?api_key=T8r7OW4f12XtWKLY7CPgKmKu1WoP3TVG0x4eqmlB
Example: https://api.epa.gov/easey/dev/emissions-mgmt/apportioned/hourly?api_key=T8r7OW4f12XtWKLY7CPgKmKu1WoP3TVG0x4eqmlB
This is applicable to the following endpoints:
Emissions API

/hourly
/hourly/stream
/daily
/daily/stream
/monthly
/monthly/stream
/quarterly
/quarterly/stream
/annual
/annual/stream
/ozone
/ozone/stream
/mats/hourly
/mats/hourly/stream
/mats/attributes/applicable

Testing
Test Case: TC644
Tester: @JanellC
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[x] Is the user story ready to be deployed to the test/staging environments?

TC644 passed @tlageman-epa


RuntimeError during clustering step

Hi,
Thanks for the awesome tool. I ran the training model step successfully. But I encountered an issue during the "Clustering stage".
RuntimeError: "normal_kernel_cpu" not implemented for 'Long'
Please check the screenshot.

Please let me know how can I fix it the error.

Could you let me know the version of PyTorch that you are using?

I checked the message you posted. It seems the error comes from the line 69 in scDeepCluster.py that uses "torch.randn_like" function. "torch.randn_like" function will sample random values from the Gaussian distribution, so it should be float values. But in your case, your input data x seems like to be a Long data type. Input x should be float32 or float64 values. Could you check your input data?


Usability: Hard to figure out why "Intent recognized" trigger is not available

The "Intent recognized" trigger type is only available if the dialog has a non-None recognizer type.
It took me a long time to figure it out. Options:

Make RegEx the default recognizer type for new bots
Show "Intent recognized" in the list and if the user picks that, set the dialog recognizer during that process.

Thanks Artur, @mareekuh & @sangwoohaan be aware of this

I think this is a good suggestion!

I do too - I'd rather not have Regex by default, but when the user picks intent we should do the right thing.  (I thought this was already the case- I think this has come up before)

I like the second option. Great suggestions!

More triggers will be introduced which may attach to different recognizer type as well.
eg. QnA Recognizer for  OnQnAMatch , RecognizerSet(LUIS+QnA) for OnChooseIntent.
So we may need more discussion for the consistent UX experience.

Addressed and solved in Composer 1.1.1


Increase precision

Hi,
How can the precision be increased? It seems like 1 cm which is not enough for us.

It can't be increased, you'll have to use a different solution.
On Tue, Sep 29, 2020 at 11:24 AM toncho11<EMAIL_ADDRESS>wrote:

Hi,
How can the precision be increased? It seems like 1 cm which is not enough
for us.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/74, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZKHP4E35RJWDBUCGAIMDSIH32PANCNFSM4R56IYDA
.

But you say:
"3d position accuracy: currently ~10mm; less than 2mm possible with additional work."
What is this additional work?

Increase the number of photo detectors, some additional sensors and then use
https://github.com/cntools/libsurvive for pose estimation.

Yep you'll need multiple sensors, certainly not DIY (TS3633-CM1
https://www.triadsemi.com/product/ts3633-cm1/ work much better), and then
you'll need to do additional research on how to fuse their data.
On Wed, Sep 30, 2020 at 1:02 PM LeeCookGHA<EMAIL_ADDRESS>wrote:

Increase the number of photo detectors, some additional sensors and then
use
https://github.com/cntools/libsurvive for pose estimation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/74#issuecomment-701519273,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZKHL3R72IJXWLPZGMDZ3SINQAXANCNFSM4R56IYDA
.

Can't buy TS3633-CM1 devices anymore


feat(lang): add 'pl' locale

Translations for Polish language, making a new 'pl' locale available for Netlify CMS.

I fixed the formatting here https://github.com/netlify/netlify-cms/pull/2949.
Also it is recommended to open a PR from a feature branch in the fork instead of master branch

Hi Erez. Thank you for your help and apologies for the formatting problem - I worked with node js on serverless projects only so far, haven't incorporated formatting / linting in those projects.. I'll make note regarding the branch next time I have something to share / improve. Regards

No problem @ideas-into-software! Thank you for the translation 🚀


Consolidate Name Inputs on Onboarding Form

Context
In the "additional-details" step of the onboarding form (slide one), users are currently asked to provide their "First name" and "Surname" using two separate input fields. We want to simplify this by replacing both inputs with a single "Fullname" field.

Remove the "First name" and "Surname" input fields from the form.
Replace them with a single "Fullname" input.
Follow the current pattern and use the Catalyst input component.
The "First name" and "Surname" fields should also be removed from the user table.
The fullname field already exists in the user table (populated via GitHub login), and it should be used to set the initial value of the new input field.
Remove any associated code and validation (including the Zod schema) related to the deleted inputs.
Add Zod validation for the new "Fullname" input field.

Screenshots

Additional info
Note: The catalyst components can be found at :
components> ui-components
The onboarding form is found at
app>(app)>alpha>additional-details
Any questions feel free to ask.

@sahilpatel2712
I assigned you. Thanks.
PS Do you have linkedin?

yes


Enable/document code coverage for extension testing

The way to use a code coverage framework such as istabuljs with extension tests should be explained on https://code.visualstudio.com/docs/extensions/testing-extensions

This issue was moved to Microsoft/vscode-docs#1096


Custom sounds for bluetooth and startup

I am new to this whole things so if I mess or messed up anything,sorry ..
The basic idea is to add user given sounds to startup, bt device connection or disconnection.
This code isn't a full pledged or fully featured one but it gives an idea.
Simply put three files under given directory and boom your device sounds however you want.
This may be for advanced users but hey, its for those advanced ones that doesnt know coding but knows basic ssh and linux commands.
If you want to implement it just let me now. We can make a better fully functional one.
Thx
Sincerely Ahmet Tümiş

In this project I tried to find reasonable defaults for the installation scripts that follow the standards (Debian, freedesktop.org, etc.) as close as possible. That's why I use the default freedesktop.org folder names (/usr/local/share/sound).
In my opinion, people who might want to change these defaults can just modify the scripts and drop in their own settings and sound files, I don't think there should be too much options in the installer scripts.
However I'm considering

disabling the startup sound completely, as it only adds more complexity and may conflict with another service using the sound device (in environments with exclusive ALSA usage), and
using a more generic destination name (like __custom instead of WoodenBeaver/stereo, as only two sounds are provided, not a complete Sound Theme). So, replacing sounds would just be a matter of throwing your own versions into the "files" folder and run the installation scripts.

Would that be a solution that is suitable for your needs?


Removing python 3.5 support

modified upgrade test to output more output for errors in the future

@timmc-edx can you review again


Replace config setters/getters with something generic

Probably a set command line in Vim.
Also, replacing the current bimrc format with a script containing commands would be a good way to unify things.

These are the current setters/getters:

colorgutter, global, boolean
indent/noindent, buffer, boolean
theme, global, colorscheme name
splitpercent, global, integer
syntax, buffer, syntax highlighter name
tabs/spaces, buffer, boolean
tabstop, buffer, integer (>0, <32)
padding, global, integer
smartcase, global, boolean
hlparen, global, boolean
hlcurrent, global, boolean
crnl, buffer, boolean
numbers, global, boolean
relativenumber, global, boolean


Solaris config targets failing with GNU ld

Ref: https://mta.openssl.org/pipermail/openssl-users/2019-March/010147.html
It seems that we're unprepared for GNU ld being used on Solaris.  All our solaris config targets derive most of their ld flags from the solaris-common template:
        shared_ldflag    => "-Wl,-Bsymbolic",
        shared_defflag   => "-Wl,-M,",
        shared_sonameflag=> "-Wl,-h,",

With Solaris ld, -M does what we think it does:

-M mapfile
Reads mapfile as a text file of directives to ld.

With GNU ld, it has a different meaning:

-M
--print-map
Print a link map to the standard output. A link map provides information about the link, including the following:
...

The shared attributes in our solaris config targets should be moved to Configurations/shared_info.pl and be made to use the mechanism that detects if the linker that's used is GNU ld or not.

Is this mix and matching toolchain?  Like Solaris CC with GNU ld?  I don't think the project should support that.  If you want to support Solaris or GCC toolchains, that seems more reasonable.

It's about allowing builds with GNU cc to use GNU ld. Our current config targets assume Sun ld at all times, which is absolutely fine with a GNU cc that's been built to use that. However, if GNU binutils is installed when GNU cc is being built, it will use GNU ld, if I understand correctly. So we fail on Solaris when it's done with a full GNU toolchain. That's what this PR tries to fix.


Evaluate reingestion testing

#3659 could had probably been avoided through testing.
We should evaluate Horizon's testing of reingestion.

From duplicated https://github.com/stellar/go/issues/3695: we should add integration tests for reingestion: both single and parallel workers.

Anddd ... we managed to break reingestion in the exact same way at https://github.com/stellar/go/issues/4110 🤕

How I think we should test this is by creating an intergation test that:

Submits all the possible Stellar operations to Core
Makes sure those operations are ingested
Reingest the operations without resetting the DB (see TestReingestDB() as a reference)
Fails if a new operation is introduced (to make sure it's future proof). See https://github.com/stellar/go/pull/3560 as a reference


Kerala State 14 days confirmed patient graph overlap with number of patients

Describe the bug
A clear and concise description of what the bug is.
Graph of confirmed patient and number of Patient overlap and number is not visible
To Reproduce
Steps to reproduce the behavior:

Go to  covid 19 website
Scroll Down to Spread Trends
Click on cumulative Graph
Select a Kerala State option from List box.
Click on two week button.
Drag the finger on confirmed patient graph.
Observers the Number of patient is overlapping with graph

Expected behavior
A clear and concise description of what you expected to happen.
Graph of Confirmed patient overlap with numbers of patients

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I would like to work on this. Please assign me

@strikertanmay hey, thanks for planning to work on it. How are you planning to go about the fix?

@jeremyphilemon By giving some left padding fix this problem very well. Attached SS after applying padding. If all things look fine to you. Can I make PR for this? :)

Also the stats area prevents the user to click on the very left points in the graph as the stats area overlaps it.

Adding a left padding for the graph is an option, but it has to left pad more to fix the overlapping issue and there will be more wasted blank space in the small screens. OR can left pad with minimal content so that there won't be much wasted space.

OR

Display the minimal stats text on the top or bottom of the graph and place graph accordingly so that the text won't affect the graph.

OR

Display the stats in a tooltip/popover in small screens so it will be placed accordingly.

Thoughts?

@nsjithin U are right. As we can the stats are already minimal and I don't think there is a point to minimalize the content just to fix the UI bug.
On point, I would like to say only a minimal amount of padding can fix this issue. I checked on different media screen sizes no such blank space wasted and UI looks cleaner and good.
That's why as an example I attach SS of the screen size (375 * 812) which is very smaller.

@nsjithin https://covid19india-react-cv8k071nf.now.sh, please view this and if you really think changes are required then we will discuss what we can do next. Thanks :)

Please select state Kerala and 2 Weeks filter from bottom and try to click on the first point in the graph. The stats area prevents the click as the stat area div is over the point.
This issue will start to appear more when the curve gets flatten. Now the data is in increasing phase so there will be room over the top left of the graph, but when the curve gets flattened the left/first points in the graph will be more top aligned and the stats area will overlap it.

Please select state Kerala and 2 Weeks filter from bottom and try to click on the first point in the graph. The stats area prevents the click as the stat area div is over the point.
This issue will start to appear more when the curve gets flatten. Now the data is in increasing phase so there will be room over the top left of the graph, but when the curve gets flattened the left/first points in the graph will be more top aligned and the stats area will overlap it.

I can understand your concern. Sorry but I don't face any problem while clicking over the first point. And I am saying that because of padding if the stats area div is outside the graph axis then how it can prevents the click or overlap the content ?

@strikertanmay Instead of applying the left padding, can we show "Yesterday" on the right of the graph instead?

@strikertanmay Instead of applying the left padding, can we show "Yesterday" on the right of the graph instead?

By considering your given option there will be chances that it can overlap with "confirmed" or with dates. That's why I think padding is the best and safest option.
Please tell if I'm wrong or you have any more approach

@strikertanmay, I patched the issue by moving them to the right, also addressing @nsjithin 's concerns
We needed to introduce changes to the testing, hence I had to hijack this issue, I hope you understand :)


Disable lexical tracker for many_to_many

Leftover from #1670
Closes #2579

@wojtekmach I think we have unrelated changes in this PR? :)

@josevalim that was intentional: examples/ecto_assoc was pinned to stable hex, so I couldn't test the there. Happy to revert that obviously.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Improve CI time, change package.json check

Tasks
The way I implemented the check slows down the pipeline by more than a minute, since we run an additional npm i.
Maybe we can simply just compare the two version numbers from the two files, if that is all we want to check, instead of performing this large installation.

Use case
No response
Related Pull request
No response

I don't think that self-implemented version checks will be correct (get all corner cases). And we actually want to check if npm i was executed by the developer if needed.
Maybe we simply put this in its own stage and execute it in parallel?

Maybe we simply put this in its own stage and execute it in parallel?

Maybe, I will think about it.


How to Play video located on Google drive?

Hi, i try this but nos not work with my:
var player = new Clappr.Player({ source: "https://drive.google.com/file/d/0B9triytxOLMnU1RwY0pRbVhqaVk/view?usp=sharing", mimeType:"video/mp4", parentId: "#player",
Thank you for help

This url seems to be an html Content-Type: text/html; charset=utf-8

it's possible to play this url?

@Abdel-ilah this URL seems to generate a dynamic URI to the mp4 file, for instance, your URL resolves dynamically to the example down below, although this example works you'll need to figure out how to extract the mp4 from your sharing google drive file.
var playerElement = document.getElementById("player-wrapper");

var player = new Clappr.Player({
  source: 'https://r3---sn-q4flrne7.c.drive.google.com/videoplayback?id=1a16700f2e6ae431&itag=18&source=webdrive&requiressl=yes&pl=21&sc=yes&ttl=transient&ei=-71uWe6uHZb5-AXkhKqADQ&susci=o-ABAwT--HibBdZ4pArImL5cceC6WIjTxodI911sOGy8_flWk&driveid=0B9triytxOLMnU1RwY0pRbVhqaVk&mime=video/mp4&lmt=1500394115659217&ip=<IP_ADDRESS>&ipbits=0&expire=1500444219&cp=QVNFUkVfU1JPSlhOOjZHbFItSGFNSVA2&sparams=cp,driveid,ei,expire,id,ip,ipbits,itag,lmt,mime,mm,mn,ms,mv,pl,requiressl,sc,source,susci,ttl&signature=601794F7EB3839442066460662ACA7E21152EB78.4289A2EDC9A50B0F32189F463D6AC7FF30F35CF5&key=cms1&app=texmex&cpn=ehoiLjaaVNFzRKEs&c=WEB&cver=1.20170712&redirect_counter=1&cm2rm=sn-gpve67s&req_id=571f8e95aecf36e2&cms_redirect=yes&mm=34&mn=sn-q4flrne7&ms=ltu&mt=1500429755&mv=m',
  mimeType:"video/mp4",
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640
});

player.attachTo(playerElement);


[Feature] passing matched_trigger and captures to show_condition like condition

Hi, thanks for all your work on LuaSnip!
This is a actually a minor issue, but is it possible to pass matched_trigger and captures to show_condition? The reason why I want this is because currently there's no convenient way to detect if a snippet with regTrig=true can be expanded in the show_condition callback, consider the following snippet:
s({ trig = '(%w+)test', regTrig = true }, {
  f(function()
    -- do some stuff...
    return ''
  end, {}, {}),
}),

Currently an completion entry to the snippet above will be shown if the cursor is after a parenthesis:

which is undesired since the snippet is intended to be expanded after alphanumeric characters.
A direct solution is to add the attribute
show_condition = function(line_before) --[[ return true if line before cursor matches (%w+test) ]] end

but it is cumbersome to write a different show_condition callback for each snippet with a regex trigger.
If the show_condition callback accepts matched_trigger or captures just like condition callback do, one can simply check the matched_trigger and return false if matched_trigger is nil or an empty string, then register a new snippet like this:
local s = ls.extend_decorator.apply(ls.snippet, {
  show_condition = function(_, matched_trigger, _)
    return matched_trigger and matched_trigger ~= ''
  end,
})

-- define new snippets using `s`...

A even better way I can think of is to add a new option show_only_when_expandable, which automatically sets show_condition to the same functions as condition for snippets with normal triggers and sets show_condition to a function that returns true when the text before the cursor is expandable (e.g. condition returns true and text before matches the regex trigger) for snippets with regex trigger.

Hmmm yeah, show_condition is a bit restricted, and your usecase is quite nice...
show_only_when_expandable sounds like a nice idea, but I think I'd like to put its implementation into the user-side of things (for more flexibility), ie. provide api for determining whether the snippet matches some text (and retrieving the captures if it does).
If the show_condition also receives the snippet ( <-would require some refactors/soft-deprecations, but nothing I'm unwilling to do :D ), this could be implemented pretty easily.
One remaining issue is that cmp_luasnip (I'm assuming you're using that) can't expand snippets with non-plain triggers (by default) since it doesn't detect whether the string in front of the cursor currently matches the snippet, so that would also need some thought/modifications.
Are you actually expanding the regTrig-snippet via cmp, or are they just polluting your results?

Thanks for your reply!

Are you actually expanding the regTrig-snippet via cmp, or are they just polluting your results?

In most cases I use cmp just to trigger snippets provided by language servers, for self-made snippets I simply hit <Tab> to expand them, so yes, the completion entries of the regex triggers are just polluting the results.

so yes, the completion entries of the regex triggers are just polluting the results.

Yeah alright.. I think in that case it makes most sense to just set hidden on those snippets, they shouldn't show up at all with that.

Yeah I also noticed this, it will be great if there's a way to expand snippets with regex triggers using cmp, although in most cases I just use  to expand them.

The idea with the pattern-expansion is that we expand a helper-snippet where all groups of the trigger can be filled in, which I think fits the usecase of cmp pretty nicely, but obviously somewhat gets in the way of using cmp as a replacement for regular expansion (which also doesn't really make sense)
If you're happy with setting hidden (via extend_decorator ofc :D), for your specific issue, we should close this, and I'll create another issue for extending show_condition in the way I described earlier (I'm sure this may come in handy, but it's not pressing, more like a nice to have)

Sounds reasonble to me, thanks for your suggestion!


io_loop error when running Dask Actors on SGECluster

What happened:
Getting an error when trying to submit an Actor to a client started with an SGECluster cluster.
Using example code found here. Works fine with a LocalCluster . I get an io_loop error when running with an SGECluster.
Error:
AttributeError: type object 'Counter' has no attribute '_io_loop'

What you expected to happen:
I expect the Dask Actor to work on an SGECluster
Minimal Complete Verifiable Example:
Example:
class Counter:
    """ A simple class to manage an incrementing counter """
    n = 0

    def __init__(self):
        self.n = 0

    def increment(self):
        self.n += 1
        return self.n

    def add(self, x):
        self.n += x
        return self.n

future = client.submit(Counter, actor=True)  # Create a Counter on a worker
counter = future.result()

counter.add(1)

Error:
AttributeError                            Traceback (most recent call last)
Input In [6], in <cell line: 1>()
----> 1 counter.add(1)

File /hpc/apps/bifrost/test/x86_64/envs/bifrost.66/lib/python3.8/site-packages/distributed/actor.py:214, in Actor.__getattr__.<locals>.func(*args, **kwargs)
    211         return _OK(result["result"])
    212     return _Error(result["exception"])
--> 214 actor_future = ActorFuture(io_loop=self._io_loop)
    216 async def wait_then_set_result():
    217     actor_future._set_result(await run_actor_function_on_worker())

File /hpc/apps/bifrost/test/x86_64/envs/bifrost.66/lib/python3.8/site-packages/distributed/actor.py:190, in Actor.__getattr__(self, key)
    187     else:
    188         return attr
--> 190 attr = getattr(self._cls, key)
    192 if callable(attr):
    194     @functools.wraps(attr)
    195     def func(*args, **kwargs):

AttributeError: type object 'Counter' has no attribute '_io_loop'

Anything else we need to know?:
Environment:

Dask version: 2022.5.0
Dask-jobqueue: 0.7.3
Python version: 3.8.13
Operating System: CentOs
Install method (conda, pip, source): conda

@graingert @fjetter could this be related to the upstream ioloop work in distributed?

the issue is the _io_loop @property is raising an AttributeError causing attribute lookup to fallback to Actor.__getattr__
https://github.com/dask/distributed/blob/5feb17151cdf660a3443abf8596444a9f51dc575/distributed/actor.py#L122-L128

@jacobtomlinson can you find out what the counter._worker, counter._client, counter._worker.io_loop, counter._client.io_loop both on the client side and the worker side?

@graingert thanks for responding here. I think some of your sentence got cut off in your last comment and I'm not sure what you're asking.

@jacobtomlinson fixed

Hi @jacobtomlinson @graingert , I checked for those attributes on counter and they do not get set:

counter.__dict__

{'key': 'Counter-70d13dd5-903b-46c6-8da0-b9dc95a7593c',
 '_cls': __main__.Counter,
 '_address': '...',
 '_future': None,
 '_worker': None,
 '_client': None
}

Checking on client side, client.io_loop is set to zmq.eventloop.ioloop.ZMQIOLoop.
Let me know where else I can check

I think https://github.com/dask/distributed/blob/5feb17151cdf660a3443abf8596444a9f51dc575/distributed/actor.py#L108 is getting hit here?

Looks like it ! LocalCluster also sets worker attributes to None

@graingert , interesting, get_client() does not work when I stand up an SGECluster, but it does for LocalCluster . Do I need to run this within a context manager?

What happens if you run the example from
https://distributed.dask.org/en/stable/api.html#distributed.get_worker
def f():
    return get_worker().address

print(client.submit(f).result())

@graingert I get this :
TypeError: Data serialized with error but only able to deserialize data with ['pickle', 'dask']

Forget the message above. I do get an address back

@graingert  I think I fixed it! I had set set_as_default=False when starting my Client. I set that to True and now it does set Actor._client.io_loop . Thanks for the help ! You pointed me to some code that allowed me to debug that further


[tests] add fuzzer test for dbus client

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is.
fuzzer test is missing in this project.
Describe the solution you'd like A clear and concise description of what you want to happen.
add a fuzzer test for dbus interface.
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
add a fuzzer test for the dbus client library as well.
Additional context Add any other context or screenshots about the feature request here.

Closing stale issue.


Document Haiku version of JAX transforms (hk.jit, ...)

We currently don't explain what hk.jit, hk.remat, etc. are and why they exist. It would be good to extend the documentation with these.

As it's not documented I'm not sure if this is a bug or (not) working as intended:
jnp.exp(0)  # 1.0
jax.jit(jnp.exp)(0)  # 1.0
hk.jit(jnp.exp)(0)  # IndexError: deque index out of range

Lmk if I should delete this comment and report it instead :)

@sjmielke: Thanks for finding that! It fails because the hk.* transforms assume that they run inside of hk.transform right now, but there's no reason why they shouldn't work outside. I have a fix for this in #17.

We've made a start here with these two:
https://dm-haiku.readthedocs.io/en/latest/transforms.html
https://dm-haiku.readthedocs.io/en/latest/api.html#jax-transforms
Closing for now.


Appsync CloudFormation Template Limit Exceeded

Which Category is your question related to?
AppSync
Amplify CLI Version
v4.21.1
What AWS Services are you utilizing?
Appsync, Cognito, S3, DynamoDB, Lambdas
Provide additional details e.g. code snippets
My Schema has 25 models, and will probably Continue to grow as our functionality increases. I feel there's a general issue with the way Amplify approaches Partition and Sort Keys, in that it is not really using DynamoDB to its fullest, which results in us needing so many different tables. We're running into cloudformation template restrictions and are needing to go in and add ex: (subscription: null, queries: null) etc. to all of our models to try to strip down functionality as needed.

Thanks for the response @SwaySway. Will using minify prevent my team from using amplify push?

No as it's a flag used to remove whitespace from the generated graphql json cfn templates.


License?

Which license is this available under? Thanks.

Hey @bamber123, the License is up now! Is under the MIT :)
License

Fantastic, thank you! 😊


times setup

There is bug with setTimeout.
function setTimeout($timeout) set time in seconds:
$this->_timeout = $timeout**/1000**
but when you set curl options in buildOptions(array $request) you should set time in seconds but you once again make /1000
$options[CURLOPT_CONNECTTIMEOUT] = max(1, $this->_timeout/1000); //minimum of 1 second
$options[CURLOPT_TIMEOUT] = $this->_timeout/1000;

God! Thanks!

I as well stumbled upon the issue. setTimeout is indeed buggy in that it divides the microseconds when it shouldn't, because it's done later.

Will fix.

On Oct 9, 2016, at 5:24 AM, whataboutpereira<EMAIL_ADDRESS>wrote:
I as well stumbled upon the issue. setTimeout is indeed buggy in that it divides the microseconds when it shouldn't, because it's done later.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Resolved in newest version. Switched to using CURLOPT_CONNECTTIMEOUT_MS and CURLOPT_TIMEOUT_MS. CURLOPT_CONNECTTIMEOUT and CURLOPT_TIMEOUT will be unset to avoid conflict