PHP 8 Support

This is temporarily blocked by https://github.com/Jean85/pretty-package-versions/pull/25 (which in turn is blocked by https://github.com/phpspec/prophecy/issues/491)

Closing/reopening to trigger CI restart.

I think that phpspec/prophecy has been updated to support PHP 8, can you please rebase the PR and check if everything works?

Please don't merge the branch on the PR but rebase instead to keep the history cleaner 😉 Also build is failing due to PHPStan

History is not an issue since we do squash+merge; I prefer merges since they create less issues with conflicts.
PHPStan issue fixed.

Blocked by #4408 (which is already fixed but unreleased)

Also, I can't reproduce current failures locally :cry:

You can merge your changes with the one from #1093 (I think that it didn't got merged in time before the release of version 3.0 and then I forgot about its existence) as I did the big of the work already

Done, but I still get those failures :( I get those only with PHPUnit 9 and using --coverage-clover

May it be because of XDebug not being compatible with PHP 8 yet?

The failure look to me like it was caused by https://github.com/vimeo/psalm/issues/4459 which has now been fixed and is in psalm 4.1.1

the remaining failures are caused by XDebug emitting a backtrace when reporting errors while running the .phpt tests.
Probably, the way how PHPUnit deals with the phpt tests has changed and previously, the phpt tests were run by a php instance that didn't have XDebug.
However, even if I add
--INI--
xdebug.default_enable=0

to the phpt tests to leave the stack trace alone, this doesn't fix some tests which seem to fail to actually call the sentry handlers with debug present in the phpt tests

with the just released XDebug 3, we can use xdebug.mode = coverage to force xdebug into coverage only mode. This fixes the tests:
https://github.com/pilif/sentry-php/commit/a8ca0cfa928a36384128a59354ea2a73b59d98e4
however, I don't know how to update xdebug for travis - heck, their latest php builder doesn't even mention xdebug at all, so I'm unclear as to how they get xdebug installed

I'm unclear as to how they get xdebug installed

I don't know honestly, better wait a few days to see what happens, anyway some of our dependencies are still not compatible with PHP8 so we cannot release anyway the new version. In the meanwhile @Jean85, if you have time I think it would be worth checking if reverting all those changes to the PHPT tests are still needed with XDebug 3

Hi @Jean85,
I was able to find the issue why error_handler_respects_error_reporting.phpt keeps failing. Don't know if you solved that one, yet. If not, I created a pull request: https://github.com/getsentry/sentry-php/pull/1141

Thanks for accepting my PR @ste93cry!
I was able to find another two issues, this time related to dependencies which are also related to php 8 support: https://github.com/getsentry/sentry-php/pull/1144

Probably, the way how PHPUnit deals with the phpt tests has changed and previously, the phpt tests were run by a php instance that didn't have XDebug.

This is being tracked in sebastianbergmann/phpunit#4529

this doesn't fix some tests which seem to fail to actually call the sentry handlers with debug present in the phpt tests

I tracked the issue down to PhpParser\Parser\Tokens\startLexing() that is called during the collecting of the  code coverage at the script shutdown and that resets the fatal error. As a consequence of this our handler runs, there is no error and so it does nothing. I'm not sure what changed in the middle of the call stack and how it worked before, so any help is welcome

Once nikic/PHP-Parser#736 gets merged finally the tests should pass and the build should be green

The PHP-Parser package released a new version v4.10.3 including https://github.com/nikic/PHP-Parser/pull/736, but unfortunately Travis CI still keeps failing. The main reason is the "Segmentation fault" error. At this point, I think this is a problem in the Travis environment. When running the same tests locally or via GitHub actions, this error does not occur. I don't know if you want to stick with Travis here, but if not, feel free to use the GitHub actions I created in my fork.
However, apart from the CI stuff, there is still one issue pending:
As soon as code coverage is activated, the test tests/phpt/error_handler_captures_out_of_memory_fatal_error.phpt does not call the shutdown function whenever it runs out of memory. This only happens for the highest dependencies, but so far I have no clue what the issue might cause.

Travis got its PHP 8 images!
I'll try one more run...

I'm a bit surprised that the memory test was so easy to fix, but it makes a lot of sense that newer phpunit versions just use more memory when running with code coverage. I didn't think of that 😄 Nice work @ste93cry! If you now change the php 8 Travis image to 8.0snapshot, Travis should be completely green. 🥳 They are still working on a php 8.0 tag.

Can we get a tag for this? There is still no stable tag for PHP 8.


Stable version

At the moment the library is at version 1.0.0-alpha08, I would like to use it in an app on the production channel but I do not think it's a good idea as long as it remains in the apha version.
Is it possible to know when it will be released in a stable version?
There is a roadmap?

I have also used WorkManager in my production app but had to revert it as it was having a lot of issues including crashes and ANRs.
So it would be great if you guys could give us some timeline for the stable version release.

I'm using WorkManager on the beta channel of an app and I'm not having any problems but the users are few and I do not trust to use it in production.

Thanks for reporting this.
I'm closing this issue because this forum is for issues with the codelab.
If you think that this is a problem of the WorkManager library, please open a bug on the WorkManager public issue tracker: https://issuetracker.google.com/issues/new?component=409906&template=1094197
Please reopen if you still think this is an issue with the codelab.


feat: add @angular/fire lib.

#30

#30  Solved

#31 solved

#32 solved

#33  solved

@eneajaho

Hi @eneajaho.
How to manage when, for an example, there is a release for V14, V12 but not for V13.

Hello @Vic-rider
I was away last week. Can you rebase please? So we can merge this?
Also, can you check if some libs are already added?
Thanks again for this!


Fail to configure firewall for the PostgreSQL Single server with an error

OS: All
Azure Resource Extension Build Version: 20220421.32 (unified)
Azure App Database Extension Build Version: 20220422.3 (unified)
Regression: Not a regression
Repro Steps:

Expand a PostgreSQL server.
Expand the postgres node -> Click "Configure firewall to connect to...".
Pop up a prompt asking to continue -> Yes.
Check whether succeeds to configure firewall for the PostgreSQL Single server.

Expect:
Succeed to configure firewall for the PostgreSQL Single server.
Actual:
Fail to configure firewall for the PostgreSQL Single server with an error.

More Info:
There is a same error under the postgres node of the PostgreSQL Flexible server

Closed by #2000


links to wiki.adempiere.net don't work

Hello,
many of the documentation pages link to the wiki site https://wiki.adempiere.net/
for example, https://www.adempiere.io/docs/system-administration/installation/application-server-installation-and-setup.html has the section "See Also" at the bottom where all the links point to wiki.adempiere.net .
wiki.adempiere.net is running with an expired TLS Let's Encrypt certificate (since 05 Jul 2022 ).
If the links pointing to a wrong site, then there's a need to point them to the good site.
If the wiki.adempiere.net is the right site, then its certificate needs to be renewed
Regards

Well I guess this project is dead


Zoom not working on android, java error on zoomBy method

Environment
flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Linux, locale en_GB.UTF-8)    • Flutter version 1.12.13+hotfix.5 at /home/pijus/flutter/flutter    • Framework revision 27321ebbad (5 weeks ago), 2019-12-10 18:15:01 -0800    • Engine revision 2994f7e1e6    • Dart version 2.7.0 [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)    • Android SDK at /home/pijus/Android/Sdk    • Android NDK location not configured (optional; useful for native profiling support)    • Platform android-29, build-tools 29.0.2    • Java binary at: /home/pijus/Downloads/android-studio-ide-191.5900203-linux/android-studio/jre/bin/java    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[!] Android Studio (version 3.5)
• Android Studio at /home/pijus/Downloads/android-studio-ide-191.5900203-linux/android-studio
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.40.1)
• VS Code at /usr/share/code
• Flutter extension version 3.7.1
Description
double zoomFactor = 100;
controller.zoomBy(zoomFactor);

Expected behavior:
Zooms successfuly
Current behavior:
Throws error:
PlatformException (PlatformException(error, java.lang.Double cannot be cast to java.lang.Float, null))
Also pich to zoom does not work

Fixed in the new version 3.0.0.


Dataproc Spark Streaming example

Revives the Spark streaming example.
Only a slight modification of the non-streaming one.
Still needs tests, can do a basic unit test but given it's streaming a more thorough system test might require more instrumentation, going to look into continuous testing.
@sduskis @pkmc @nkashy1 @mbrukman

I generally favor smaller PRs but can combine if you want.


Feature Request: Integration of Algolia as a Search Engine Option

Problem Description
Currently, the project has Inkeep as its only search engine, which is a paid tool. This can be a barrier for users with limited budgets or smaller projects that need a more accessible solution.
Proposed Solution
Add support for Algolia as an alternative search engine option alongside Inkeep. Algolia offers a free layer, allowing users to access advanced search features without initial costs, which could make the project more accessible to a broader community.

I see that this is a relatively new project, I would like to contribute to it, if you agree I can take charge of this feat.

Hi @FranciscoJBrito , thanks for bringing this up! Yes we definelty would love to support Algolia as a Search Engine Option. And we're glad to acceppt a plugin for that.
Note that the SearchEngine Plugin interface is not well specced out, so feel free to jump into Discord for discussion or if you have questions!


Build Parser Outputs Partially Incorrect PCI Classes

When I run the crate binary with the latest commit, I noticed my WiFi NIC showed up as a 'Mass Storage Controller'. However, standard lspci binary shows the device as a 'Network controller'.
$ cargo run 2>&1 | grep MT7921
0000:03:00.0 Mass storage controller: MEDIATEK Corp. MT7921 802.11ax PCI Express Wireless Network Adapter

$ lspci | grep MT7921
03:00.0 Network controller: MEDIATEK Corp. MT7921 802.11ax PCI Express Wireless Network Adapter

Peering into the PCI class file generated by the build,  the 'Mass storage controller' is the first entry for the 'Network Controller' class and there is no 'Network controller' subclass entry either. Comparing to the pci.ids file (specifically this section) parsed by the build, the Mass storage controller is actually part of the previous section.
(2, PciClassEntry { id : 2u8 , name : "Network controller" , subclasses : & [PciSubclassEntry { id : 128u8 , name : "Mass storage controller" , progs : & [] } , PciSubclassEntry { id : 0u8 , name : "Ethernet controller" , progs : & [] } , ... PciSubclassEntry { id : 8u8 , name : "Fabric controller" , progs : & [] }] }),

From what I can tell, this is a bug in the PCI class parsing logic. It appears to affect all PCI classes as well as parsing PCI devices. I'll post a PR soon to address this the PCI class portion. If I have time, I may post a follow-up PR for the PCI device parsing logic.

Resolved.


retinoid (CHEBI:26537) parent

retinoids (CHEBI:26537) are defined as
"Oxygenated derivatives of 3,7-dimethyl-1-(2,6,6-trimethylcyclohex-1-enyl)nona-1,3,5,7-tetraene and derivatives thereof."
This compound, however, does not exist yet in (released version of) ChEBI. The hydrocarbon parent of retinoids is the "basic hydrocarbon" that JCBN refers to as "deoxyretinol" or "axerophthene"
https://www.qmul.ac.uk/sbcs/iupac/misc/ret.html#p41
It corresponds to CAS 6895-29-0 and PDBeChem:AZE
ALL-TRANS AXEROPHTHENE or 2-[(1E,3E,5E,7E)-3,7-dimethylnona-1,3,5,7-tetraen-1-yl]-1,3,3-trimethylcyclohexene
So
deoxyretinol is a diterpene (CHEBI:35190)
retinoid (CHEBI:26537) has parent hydride deoxyretinol
Links
https://www.ebi.ac.uk/pdbe-srv/pdbechem/chemicalCompound/show/AZE
https://chem.nlm.nih.gov/chemidplus/rn/6895-29-0

An entry has now been created for axerophthene (CHEBI:40918).
The issue with having deoxyretinol as the parent hydride of retinoid (CHEBI:26537) would be slightly misleading since there are children in this class which have double bonds in the cis-configuration and also 3rd/4th generation retinoids whose structures are completely different.


getaddrinfo ENOTFOUND api-app.dc-ww.ww.ecouser.net

What issue do you have? Please be as thorough and explicit as possible.
Getting the following error:
[11/03/2023, 21:47:33] [deebot] ***** Disabling plugin. *****
[11/03/2023, 21:47:33] [deebot] ***** getaddrinfo ENOTFOUND api-app.dc-ww.ww.ecouser.net at Function.AxiosError.from (/var/lib/homebridge/node_modules/homebridge-deebot/node_modules/axios/lib/core/AxiosError.js:89:14). *****

Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?
Homebridge UI-X

Which version of Homebridge/HOOBS do you have?
Homebridge v1.6.0

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.
Raspberry Pi

Which version of this plugin (homebridge-deebot) do you have? Has the issue started since upgrading from a previous version?
6.0

Which ECOVACS devices do you have that are causing issues? Please include product models if applicable.
Deebot T10

Please paste any relevant logs below.

[11/03/2023, 21:53:14] [HB Supervisor] Restarting Homebridge...
[11/03/2023, 21:53:14] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[11/03/2023, 21:53:14] [HB Supervisor] Started Homebridge v1.6.0 with PID: 1319
[11/03/2023, 21:53:15] Loaded config.json with 0 accessories and 4 platforms.
[11/03/2023, 21:53:15] Loaded 1 cached accessories from cachedAccessories.
[11/03/2023, 21:53:15] ---
[11/03/2023, 21:53:15] Loaded plugin<EMAIL_ADDRESS>[11/03/2023, 21:53:15] Registering platform 'homebridge-appletv-now-playing.AppleTvNowPlayingPlatform'
[11/03/2023, 21:53:15] ---
wasm streaming compile failed: TypeError [ERR_INVALID_ARG_TYPE]: The "source" argument must be an instance of Response or an Promise resolving to Response.

Thanks for the reply! My config code has it as AU?
  "name": "deebot",
            "countryCode": "AU",
            "username"<EMAIL_ADDRESS>            "password": "0405803379Dg1986",
            "platform": "Deebot",
            "refreshTime": 30

Thanks for the reply! My config code has it set as AU:
  "name": "deebot",             "countryCode": "AU",             "username": "****",             "password": "****",             "platform": "Deebot",             "refreshTime": 30

@daragill
Ok, I see ... I already started to fix this in the library
cc: @bwp91

Thanks! When I set it to WW the error is there still but the WW disappears:
[11/03/2023, 22:17:34] [deebot] ***** Disabling plugin. *****
[11/03/2023, 22:17:34] [deebot] ***** getaddrinfo ENOTFOUND gl-ww-api.ecovacs.com at Function.AxiosError.from (/var/lib/homebridge/node_modules/homebridge-deebot/node_modules/axios/lib/core/AxiosError.js:89:14). *****

@bwp91
Please update to version 0.9.4-beta.0 of the library. Thanks

@daragill
Is it working if you use an Asian country like "ID", "SG" or "PH"?

@mrbungle64
Yes! Have tested with ID and its working fine now.

@daragill closing this, glad this has been resolved
@mrbungle64 thanks for your input here (thanks as always!)

@bwp91
Please update to version 0.9.4-beta.0 of the library. Thanks

@bwp91
Can you please update to version 0.9.4-beta.0 of the library? 😉

hi @mrbungle64 sorry for delay, new beta available with 0.9.4 beta of your client

@daragill
Can you please test if country code "AU" works again with the latest beta?

@mrbungle64
Have tested 6.0.2-beta and it's not working on AU

[19/03/2023, 21:06:49] [deebot] [OakBOT] sent error [DNS lookup failed: getaddrinfo ENOTFOUND api-app.dc-ww.ww.ecouser.net].

@daragill
Sorry, I checked for the wrong letter case 🙈
@bwp91 Can you please update to 0.9.4-beta.1?

@mrbungle64 done - what exactly is the issue here? thinking of what i can do in the plugin to at least state what is happening

@bwp91

@mrbungle64 done

Thanks 👍🏻

what exactly is the issue here? thinking of what i can do in the plugin to at least state what is happening

I switched to a different API endpoint with version 0.9.3:
https://github.com/mrbungle64/ecovacs-deebot.js#093
The problem is, that countries with "continent" "WW" cannot use the this new API endpoint. It seems to be different for that countries.
With the old API endpoint many users (incl. me) had several timeout errors per day:

https://github.com/mrbungle64/ecovacs-deebot.js/issues/303
https://github.com/mrbungle64/ioBroker.ecovacs-deebot/issues/412
https://github.com/mrbungle64/ioBroker.ecovacs-deebot/issues/432
https://github.com/mrbungle64/ioBroker.ecovacs-deebot/issues/439

That's why I switched to the new endpoint. It seems to be working fine so far (for most countries).

@daragill
Can you please check it works with v6.0.2-beta.1 now (using country code "AU")?

@mrbungle64
This has been tested and its working with "AU"
Thanks!

@mrbungle64
This has been tested and its working with "AU"
Thanks!

Great! Thank you as well 👍🏻

I'm assuming this has been fixed, so closing, please reopen if necessary.
I just released new version of the plugin.


Track unavailable segments in InstanceSelector

Unavailable segments are the segments that has no enabled instance or all enabled instances are in ERROR state.
We don't count segment with enabled instance in OFFLINE state as unavailable because it is a valid state when segment is new added and has not become ONLINE/CONSUMING.
This PR only returns the unavailable segments to the broker request handler. We need another PR to include them into the query response.

@fx19880617 This PR changed the broker debug API to return the unavailable segments within the routing table. Please check whether it is okay for presto connector

Codecov Report

Merging #5337 into master will increase coverage by 9.48%.
The diff coverage is 86.79%.

@@            Coverage Diff             @@
##           master    #5337      +/-   ##
==========================================
+ Coverage   56.88%   66.36%   +9.48%
==========================================
  Files        1073     1075       +2
  Lines       54722    54780      +58
  Branches     8159     8168       +9
==========================================
+ Hits        31126    36355    +5229
+ Misses      21149    15753    -5396
- Partials     2447     2672     +225

Impacted Files
Coverage Δ

...rg/apache/pinot/broker/routing/RoutingManager.java
78.62% <50.00%> (+12.85%)
:arrow_up:

...org/apache/pinot/broker/api/RequestStatistics.java
64.51% <66.66%> (+64.51%)
:arrow_up:

...e/pinot/broker/api/resources/PinotBrokerDebug.java
79.31% <75.00%> (+79.31%)
:arrow_up:

...roker/requesthandler/BaseBrokerRequestHandler.java
79.89% <81.81%> (+59.73%)
:arrow_up:

...routing/instanceselector/BaseInstanceSelector.java
98.01% <96.22%> (+9.44%)
:arrow_up:

.../org/apache/pinot/broker/routing/RoutingTable.java
100.00% <100.00%> (ø)

...ker/routing/instanceselector/InstanceSelector.java
100.00% <100.00%> (ø)

...org/apache/pinot/broker/queryquota/HitCounter.java
92.30% <0.00%> (-7.70%)
:arrow_down:

.../realtime/impl/ThreadSafeMutableRoaringBitmap.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...he/pinot/controller/util/SegmentIntervalUtils.java
0.00% <0.00%> (ø)

... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52001be...584eea6. Read the comment docs.

@fx19880617 This PR changed the broker debug API to return the unavailable segments within the routing table. Please check whether it is okay for presto connector

Discussed offline. Will keep the API unchanged.


[ISSUE #6222] update addAndGet use

Make sure set the target branch to develop
What is the purpose of the change
close #6222
Brief changelog
update addAndGet use
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6223 (fef77ff) into develop (88000da) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6223      +/-   ##
=============================================
- Coverage      43.18%   43.18%   -0.01%
  Complexity      8848     8848
=============================================
  Files           1094     1094
  Lines          77184    77184
  Branches       10070    10070
=============================================
- Hits           33332    33331       -1
- Misses         39682    39684       +2
+ Partials        4170     4169       -1

Impacted Files
Coverage Δ

...he/rocketmq/client/impl/consumer/ProcessQueue.java
62.99% <100.00%> (+2.20%)
:arrow_up:

...he/rocketmq/controller/impl/DLedgerController.java
66.49% <0.00%> (-2.62%)
:arrow_down:

.../apache/rocketmq/controller/ControllerManager.java
71.87% <0.00%> (-2.09%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
58.11% <0.00%> (-1.71%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
82.21% <0.00%> (-1.45%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
70.27% <0.00%> (-1.36%)
:arrow_down:

.../apache/rocketmq/store/ha/DefaultHAConnection.java
65.72% <0.00%> (-1.21%)
:arrow_down:

...che/rocketmq/acl/plain/PlainPermissionManager.java
78.22% <0.00%> (-0.54%)
:arrow_down:

...rocketmq/client/impl/factory/MQClientInstance.java
46.82% <0.00%> (-0.15%)
:arrow_down:

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (ø)

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Maybe the author just wanted to emphasize the semantics of minus i.e. negative ? Without sufficient good reason, I prefer NOT changing it.

thanks for reviewing，I prefer concise code.


[GH-15970] Remove unnecessary changeCSS() for .mentions--top

Summary
Removes the changeCSS() function called on unused CSS selector - .app__body .mentions--top in file utils/utils.jsx
Part of the campaign to replace older theme implementation.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/15970
Jira Ticket: https://mattermost.atlassian.net/browse/MM-29695

Hello @Pranav2612000,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Pranav2612000 Do we have these rules defined in the css files somewhere?

@Pranav2612000 Do we have these rules defined in the css files somewhere?

@Pranav2612000 Do we have these rules defined in the css files somewhere?

@asaadmahmood No. Couldn't find them.

@Pranav2612000 Then we should add that css rule in the mentions css file properly.

@Pranav2612000 Then we should add that css rule in the mentions css file properly.

Couldn't find it attached to any element too.

Skipping QA review as it is to a feature branch


Export MemoryInstallationStore and FileInstallationStore

Summary
Fixes #941
Exports the MemoryInstallationStore and FileInstallationStore classes from @slack/oauth to allow developers the ability to import and use them directly in their projects as the chosen InstallationStore.
Dependent on<EMAIL_ADDRESS>Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

As the failing builds indicate, you need to release a new version of @slack/oauth that provides the store implementations first.

Yep! I've noted that dependency in the Summary. I'm trying to get everything in order and ready to go.


not able to send transaction template email

i am using this api send_transactional_template to send the template as a transnational email. i don't get any error but mail is not delivered. i am getting the following response -
{ code: 'success', message: 'Updated the Template.', data: [] }
It seems there is an error and it is calling update template api rather than sending the transaction template mail.

Hello @ShahnazK
Thank you for contacting us.
The issue is happening because you are redefining some parameters already defined in the template.
For your particular case it could be subject or from which are invalid input parameter for send_transcational_template API.
Regards
SendinBlue Team


Describe the features in more detail

Overview
It is necessary to add more details to the features and describe how they work. This greatly limits the ability of new users to use these features for their own purposes.
First of all, need to check:
vl3-basic, nse-composition, policy-based-routing

Very much looking forward to the success of your great work

hi @dualBreath @glazychev-art
Where can I see the results of your latest document? Do you have a link? Thank you very much.

Diagrams, first try:
composition.zip

@316953425 The document is not ready at the moment. I have prepared a few diagrams for NSE composition example which should be reviewed by the team before adding them

hi @dualBreath
thank you very much,


curl is misspelled

URL for relevant page?
https://docs.influxdata.com/influxdb/v1.2/troubleshooting/frequently-asked-questions/#what-words-and-characters-should-i-avoid-when-writing-data-to-influxdb
curl is misspelled here:
curl the /ping endpoint:
$ url -i 'http://localhost:8086/ping'

Thank you for pointing that out, @jheerdegen!


Link "Docker Enterprise Edition" not working in Chrome v62 and v63

The menu on the left hand side of the page has a non working first link "Docker Enterprise Edition" when using Chrome in either version 62 or 63 on MacBookPro.
In Firefox and Safari the link works and expands the subtopics.
File: manuals.md, CC @johndmulhausen

I can't reproduce this with a Macbook running Chrome 62. Can't you check the develop tools console to see if there's any error? Also, are you using any pop-up blockers or anything like that?

Duplicate of #5511


bug: ui-router state ordering breaks tabs app

Type: bug
Platform: all
I have an app based on the "tabs" starter application. I'm curious as to why the order of the states listed below breaks the application; is this expected behavior?  In the instance where it doesn't work, clicking the settings tabs presents and empty tab window with a "< Back" on the left side of the header. The only difference is the order in which the states are defined. Thanks!
The following code works as expected
 $stateProvider

  // setup an abstract state for the tabs directive
    .state('orders', {
    url: "/orders",
    abstract: true,
    templateUrl: "templates/tabs.html",
    // data property is inherited by child states
    data: {
      loginRequired: true
    }
  })

  // Each tab has its own nav history stack:

  .state('orders.list', {
    url: '/list',
    views: {
      'orders-list': {
        templateUrl: 'templates/tab-dash.html',
        controller: 'OrderListCtrl'
      }
    }
  })

  .state('orders.all', {
      url: '/all',
      views: {
        'orders-all': {
          templateUrl: 'templates/tab-chats.html',
          controller: 'AllOrdersCtrl'
        }
      }
    })
 .state('orders.settings', {
    url: '/settings',
    views: {
      'app-settings': {
        templateUrl: 'templates/settings.html',
        controller: 'SettingsCtrl'
      }
    }
  })

  .state('orders.detail', {
    url: '/:id',
    views: { 'orders-list':{
      templateUrl:'templates/order-detail.html',
      controller: 'OrderDetailCtrl',
      resolve: {
        order: function($stateParams, $rootScope, OrderService){
          // set the order on the rootScope
          // prototypical inheritance finally pays off
          $rootScope.order = OrderService.get($stateParams.id);
        }
      }
  }
}
})
   .state('login', {
    url: '/login',
    templateUrl: 'templates/login.html',
    controller: 'LoginCtrl'
    });

The following code does not work as expected, exhibiting the behavior described above
 $stateProvider

  // setup an abstract state for the tabs directive
    .state('orders', {
    url: "/orders",
    abstract: true,
    templateUrl: "templates/tabs.html",
    // data property is inherited by child states
    data: {
      loginRequired: true
    }
  })

  // Each tab has its own nav history stack:

  .state('orders.list', {
    url: '/list',
    views: {
      'orders-list': {
        templateUrl: 'templates/tab-dash.html',
        controller: 'OrderListCtrl'
      }
    }
  })

  .state('orders.all', {
      url: '/all',
      views: {
        'orders-all': {
          templateUrl: 'templates/tab-chats.html',
          controller: 'AllOrdersCtrl'
        }
      }
    })

  .state('orders.detail', {
    url: '/:id',
    views: { 'orders-list':{
      templateUrl:'templates/order-detail.html',
      controller: 'OrderDetailCtrl',
      resolve: {
        order: function($stateParams, $rootScope, OrderService){
          // set the order on the rootScope
          // prototypical inheritance finally pays off
          $rootScope.order = OrderService.get($stateParams.id);
        }
      }
  }
}
})
  .state('orders.settings', {
    url: '/settings',
    views: {
      'app-settings': {
        templateUrl: 'templates/settings.html',
        controller: 'SettingsCtrl'
      }
    }
  })
   .state('login', {
    url: '/login',
    templateUrl: 'templates/login.html',
    controller: 'LoginCtrl'
    });

According to ui-router documentation states can be declared in any order

Greetings @thebalaa!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

In our demos it works fine. I suspect there's more to the story. Can you reproduce this in a codepen we can inspect?

Greetings @thebalaa!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.

Greetings @thebalaa!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.


Add FEA_TRACE_SUPPORT flag as an option to enable tracing.

@jupe

@kjbracey-arm @SeppoTakalo  could you check this out

Seems reasonable to me - if mbed_trace.h is acting as a replacement for ns_trace.h, FEA_TRACE_SUPPORT is the macro we seem to be using, with HAVE_DEBUG being deprecated. There should indeed be some non-Yotta-branded selection method.
There are still people using HAVE_DEBUG, mind. Although I'm fine with losing that - the name is unhelpful.

lgtm but lets wait feedback from @SeppoTakalo before merging

@SeppoTakalo Could you take a look at this please.

+1
I'm ok with the change.
When we take the mbed-trace library into use, we can replace the HAVE_DEBUG flag with the FEA_TRACE_SUPPORT.


A panicked error occurred.

v0.2.0 release.
In some cases, an error occurs under certain conditions.
Error output :
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/main.rs:189:38

Need to analyze the cause.

Bug analysis：
The name of the PATH is also required to be a UTF-8 encoded string in captures, otherwise a panic error will be generated.
Fix policy：
It is costly to support all formats including UTF-8. If a panic occurs, we want to exclude PATH names from processing.


Hash id with Social Profile Table : cake php 3.6

Hello i am using the hash ids plugin https://github.com/dereuromark/cakephp-hashid .
facing issue with hash id. While implementing the social AUTH Login then user_id save as 0 in social_profiles table. in getUser() function i have encoded/decoded the user id but Profile data already fetch/saved by this plugin internally and not be able to encode/decode ids there. Also created a new model Social Profile and used the hashid in the same plugin but not successful. Kindly do needful.

I don't use hashids and don't have the time or motivation to look into this. You can welcome to submit a patch to support your use case.


nc_inq_type fails with NC_INT64

This was first reported as an error in the netcdf-cxx interface, see

https://github.com/Unidata/netcdf-cxx4/issues/30

Diagnosis is ongoing.

nc_inq_type() fails when queried with an invalid ncid and a type that is not present in the base nc3 data model.  After discussion with @DennisHeimbigner we've decided that this function should return information, as there are other safeguards in place should the user try to use a data type not available to the file they're working with.

The fix has been merged into master, closing out.


Update to cats 2.9.0

Supersedes #144.  Fixes it by upgrading to Scala 3.2.

This should unblock #149 and #150.

Eh, #143 will handle this.


New version: JasonWei512.code-radio-cli version 0.1.9

Pull request has been automatically created using 🛫 WinGet Releaser.
Microsoft Reviewers: Open in CodeFlow

Adding labels so it doesn't get automatically closed
@msftbot Dependencies

Sorry I didn't test it on Windows Sandbox 😅
I will publish a statically linked version (0.1.10) without VC++ dependency.
Closing this PR.


(feat): New kubernetes backend endpoints

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@freben ready for another review 🙏

@Rugvip ready


Support for parsing body text from POST request?

It seems like it might be cleaner on the URL to POST to /parse/text and pass the input string in the body of the request - is there support for that?  Are there potential limits to the length of text sent in the querystring?

Nevermind, found the manner to submit parameters in the form body when POSTING.  Works as intended!


Gateway enhancement

Is your feature request related to a problem?
Hotchocolate is great, I am considering it for production,
But i thking the gateway lacks some important functions,  like heathcheck,  schema  register automatically  for new published service without restart gateway. etc.
For now , I had to register each service Manually (maybe can read from config file or anywhere else) , like this:
services.AddHttpClient(Accounts, c => c.BaseAddress = new Uri("http://localhost:5051/graphql"));
services.AddHttpClient(Inventory, c => c.BaseAddress = new Uri("http://localhost:5052/graphql"));
services.AddHttpClient(Products, c => c.BaseAddress = new Uri("http://localhost:5053/graphql"));
services.AddHttpClient(Reviews, c => c.BaseAddress = new Uri("http://localhost:5054/graphql"));

The solution you'd like

I think the service downstream can generate this format when publish the schema to the redis.
{
    "serviceName":"demo",
    "servicePort": 80,
    “scheme”:"xxx"   //base64 format string
}

so the full url is http://{serviceName}:{servicePort}/graphql                (kindly for k8s)
ant the gateway can read config from redis and register/update schema of service downstream automatically,
And healthchek is clearly to implement.
Product
Hot Chocolate

This is all coming with version 13. I am closing this issue since its to broad in focus and we already have implemented most of it.

join us on slack.chillicream.com if you want to follow announcements on this.


Here is the training code from third party

We re-implemented the training process of MobileSAM, the training code can be downloaded from here for your reference. A very simple code version just for research purpose. Much thanks to the research group of MobileSAM!

thanks  a  lot bro

It does not exist now.


Don't have any "actions" available to bind

Hi,
Maybe I'm missing something but I don't seem to have any option when I add the Tricaster Newtek connections, the "actions" library doesn't load up.
But the Presets are available so I find it kind of weird since the presets themselves are recalling actions that even I cannot see, but they work well,
any idea on how I can fix it?
(I've tried on companion beta and the problem is still here)
Thanks!

Are there any errors in the companion log?
Do you variables and feedbacks show up properly?
And are you trying to access the actions through the "browse" button, or with the dropdown menu?

Yes I have one error, the companion can't connect to the Tricaster but it's because I'm using one that is not compatible with LivePanel, but the actions from the presets are still working, and I've tried for other connections I don't even need it to be connected to have access to the actions list.
Yes the variables are visible and the feedbacks only shows when clicking the "browse" button, but I think that it is normal?
I've tried with both the browse button and the dropdown menu, but the only thing I see is "Internal" but no Tricaster, which is weird because when I bind a preset to a button, I can see that the action of the button is a "Tricaster : xxxxx" but I still can't see any other
Thank you for your time !

I know in v3 it shouldn't show actions, feedback, etc until connected. The thinking here is a lot of the action options are built based on the model being used, so we wait until that's confirmed before binding those.
When you say the "actions from the presets are still working" do you mean they're showing up, or do they actually work with the tricaster? Also what Tricaster are you using?

Alright that can explain why I can't see them, but it's weird that I can still have access to feedback and variables, maybe it is because when I try to connect, it says connected for .2s et then come back to "not connected".
I mean that when I'm binding the DDR1 PLAY/PAUSE on a button, the play/pause button does work on the Tricaster, even though it doesn't say connected, so it actually works. I'm using a Tricaster TXCD410 running on the update 2-6-200110, and I believe that it is the latest version I can have without having to buy another licence.

Can you provide a readout of what happens when you go to
http://`tricasterip`/v1/version
in a browser?

I can't seem to reach it, and I'm 100% confident that I'm calling the right IP, I've tried in different browsers but they all can't reach it.
I tried to do a 'netstat -a' on my Tricaster to try and figure out how can I go in this page, but I can't find any ports that shows any UI when typed in a browser.
But the streamdeck connected to another computer on the same network as my Tricaster can still trigger the DDR via the preset button of the companion
I will try to connect the companion to another Tricaster that has Livepanel, make a config and export it to see if the actions stills works even though it doesn't say "connected", I'll keep you updated
Thanks again for your time !

Got it. So it seems like the /version was likely added in a later Tricaster update than what you have installed.
I'll try to work on a better onboarding process for Tricasters that don't have the version api calll.

https://github.com/bitfocus/companion-module-newtek-tricaster/pull/39 should allow you to at least connect while using an older firmware. I can't promise 100% compatibility, but you should at least be able to see the actions, etc


Make FileDropBox with props for maxFiles, KBWarn and KBMax

This will allow
Setting drop box to only accept 1 file
Provide a file size to warn at ( show large files )
Provide a file size to block ( prevent saving - show as error )

Added and you can call like this

      <FileDropContainer
        fileTypes={ Common_MIME_Objects }  // Accept only PNG and JPEG files
        setParentFilesData={handleFileUpdate}  // Callback to receive file updates
        maxCount={null}
        KBmax={ 50000 }
        KBwarn={ 10000 }
      />


Issue 6904 first free council vote

Beta implementation to resolve the issue Participating in Governance should be Free for First Time Voters #6904

First level of demo sequence

Hello Shawn,
Like to do quick check on implementation approach for the issue.
In above Demo test sequence, able the detect the first-time voters. But looking for some clarity on balance transaction.
From my initial analysis, looks like fee is not getting detected in all cases ...

Hello Shawn,
Thanks for guidance, reverted pallet-democracy changes.
and modified only pallet-collective.
Used below logic to detect the first vote within a proposal.

And verified with testcase "tests::motions_revoting_works()" [slightly modified] ...
From below trace account 2 is detected as first vote in a proposal ...

Note:: Plz ignore changes in "frame/democracy/src/tests.rs", Some mistake in my cleanup ... will correct it :-)

Hello Shawn,
Moved the "mod test" to tests.rs
Introduced new test case "motions_all_first_vote_free_works()" to validate the changes ...
looks like I am messing up in testing for Pay::Yes & Pay::No
For Ok condition I using assert_eq!() pattern

And for Err case I am using match {} pattern

Plz suggest best alternate ...

Plz Ignore this PR, instead use   PR | 7661


Find runnning python scripts on system

TIP: psutil (library of python)

Use a class-based approach which can contain the below methods or more.
detect and return pid of all running Python script on the system,
a function that can take pid of a process and kill that.
a function that can just log all the running script basic info (pid, script path...)

@bhargavnova hey i can try this

Sure!!

Hey can I try this

Hi @TanyaKansal , I have already assigned this to @Siddharth9890 ,
So you can check out other issues,
or you can submit something of your own,
Thanks : )
Happy Coding!!

Thank you for your contribution @Siddharth9890,
Once again, thank you for your exceptional work. We're looking forward to achieving even greater heights together!
Warm regards,


App Crash: RCTImagePickerManager.m line 128 __77-[RCTImagePickerManager imagePickerController:didFinishPickingMediaWithInfo:]_block_invoke

[ ] Review the documentation: https://facebook.github.io/react-native
[ ] Search for existing issues: https://github.com/facebook/react-native/issues
[ ] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
Run react-native info in your terminal and paste its contents here.
Environment:
OS: macOS High Sierra 10.13.4
Node: 8.5.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: v16.3.2 => 16.3.2
react-native: 0.53 => 0.53.3
Description
Go and Take Picture Application crashing at some time. it's not always reproducible but we are seeing it our customer reporting it in production.
Reproducible Demo
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x1848bf164 __exceptionPreprocess
1  libobjc.A.dylib                0x183b08528 objc_exception_throw
2  CoreFoundation                 0x184857c9c _CFArgv
3  CoreFoundation                 0x18478a8a0 -[__NSPlaceholderArray initWithObjects:count:]
4  CoreFoundation                 0x18479687c +[NSArray arrayWithObjects:count:]
5   SOMEMOBILEAPP                0x104816f70 __77-[RCTImagePickerManager imagePickerController:didFinishPickingMediaWithInfo:]_block_invoke (RCTImagePickerManager.m:128)
6  libdispatch.dylib              0x18423ea54 _dispatch_call_block_and_release
7  libdispatch.dylib              0x18423ea14 _dispatch_client_callout
8  libdispatch.dylib              0x18424b698 _dispatch_main_queue_callback_4CF$VARIANT$mp
9  CoreFoundation                 0x184867344 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
10 CoreFoundation                 0x184864f20 __CFRunLoopRun
11 CoreFoundation                 0x184784c58 CFRunLoopRunSpecific
12 GraphicsServices               0x186630f84 GSEventRunModal
13 UIKit                          0x18dedd5c4 UIApplicationMain
14 SOMEMOBILEAPP             0x1046f5d4c main (main.m:16)
15 libdyld.dylib                  0x1842a456c start

FYI The logs are captured using crashlytics.

This seems to be a fix for me.
RCTImagePickerManager.m , Line No :- 128 , replace the code with

  `[self _dismissPicker:picker args:tempImageTag ? @[tempImageTag, RCTNullIfNil(height), RCTNullIfNil(width)] : nil];`

Fix landed.


edit section in sidebar menu: edit page of selected item / collection / community does not refresh

This bug affects DS 7.5 and it can be reproduced in the DS 7.5 demo instance.
bug description and steps to reproduce

hover over sidebar menu and choose Edit menu section

within menu section choose entry Community, Collection or Item

(the following description assumes that a collection was chosen)

choose a collection from the collection list that is shown in the modal dialog (in this example 1205TestCollection was chosen)

the edit form of the selected collection is shown

go back to step 1 and repeat the process until step 5 (choose another collection in step 5)

After the second pass of step 5 the browser URL changes (from https://demo7.dspace.org/collections/733388bf-9adb-4218-b899-ce22deb27fdd/edit/metadata to https://demo7.dspace.org/collections/33441398-de98-4ec1-86b7-3f57688b1856/edit/metadata), but the form fields are not updated, e.g. in the Name input field the name of the previously chosen collection is still present (marked in the screenshot).

If you refresh the page or open https://demo7.dspace.org/collections/33441398-de98-4ec1-86b7-3f57688b1856/edit/metadata directly, the Name input field contains the correct value:

The same (buggy) behaviour appears if you choose a community or item in step 2. Any subsequent selection of an another community or item shows the values of the community / item that was initially selected.

I can reproduce this locally... the steps are pretty simple & unfortunately occur both for "Edit -> Community" or "Edit -> Collection".

Go to "Edit -> Community" (or "Edit -> Collection")
Select a Community (or Collection).  It doesn't matter which one, but pay attention to which you have selected
Go back to the same "Edit -> Community" (or "Edit -> Collection")
Select a different Community (or Collection).  Bug: Look closely. The form still contains the metadata of the previously selected Community or Collection.

I'll see if anyone can dig into this.  It appears to be a caching issue with the form. If you reload the page, the form then reloads properly.

Thanks, @tdonohue . Items are also affected.
Normally, the UUIDs in the URL and in the Item internal ID match.

If the caching issue appears, the UUIDs do not match


ReflectionProperty::getValue() expects exactly 1 parameter, 0 given

I write this issue because i don't know why i got this Warning: ReflectionProperty::getValue() expects exactly 1 parameter, 0 given Is i doing something wrong?... Help me!

Experiencing the same issue. Anyone has a solution?

This problem seems to only apply to public entity properties. Switching to private (and manage access via getter/setter methods) seems to resolve this.

i have the same error, my entity properties are private =(

a year ago I've been using laravel framework... I think is a good option to develop sites too. I hope I'm not being rude.

Can't check my repo right now, but I vaguely remember it had to do with underscores. So if you have variable $some_var in your entity, the setter methld is setSomeVar... Solution might be to have alias method for the setter with underscore like setSome_var($val) { return $this->setSomeVar($val); }. Same for getter. Let me know if that works!

Hello,
I deleted the cache, it works normal, tnks..


Add avatar component

@cg-julian-taylor please can you alter the without style avatar documentation to use the text instead of the link. I also think when using the external link you shouldn't see text

The link should just accept a url and maybe some aria labels, when using the external link you should be able to see the image or text

No problem with changing the without style documentation. It does look a bit odd.
As for what you pass in to the avatar itself I believe you should be able to pass in an aria-label as a prop.
You can pass in whatever child components you wish, e.g. an SVG.
I assume the typical use case of passing an image url or initials, however I wanted to demonstrate that the contents are flexible so used an external link as that was the most likely use case I could think of adding.
I also made the assumption that if a user is injecting something such as an SVG they would manipulate styling.
However if I am wrong or you disagree please let me know what use cases I should aim for.

@cg-julian-taylor can you please remove the design system folder from storybook as it is currently broken. It will be picked up in a separate ticket as it requires a bit more work.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6d567f6) to head (37559df).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           release/1.1.0      #689   +/-   ##
===============================================
  Coverage         100.00%   100.00%
===============================================
  Files                 89        90    +1
  Lines               1663      1675   +12
  Branches             584       589    +5
===============================================
+ Hits                1663      1675   +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No message due to failed attempts

Expected Behavior
When settings OTP_HOTP_THROTTLE_FACTOR is not 0 user after failed attempts should get error message:
Verification temporarily disabled because of {n} failed attempts, please try again soon.
Current Behavior
User gets misleading error:
Invalid token. Please make sure you have entered it correctly.
Possible Solution
Problem is that in AuthenticationTokenForm we don't have a field for user selected device which OTPAuthenticationFormMixin requires:
        #. Define three additional form fields::

            otp_device = forms.CharField(required=False, widget=forms.Select)

and therefore later in method _verify_token it never triggers device.verify_is_allowed() since device at this point will always be None and it tries to match the token with all devices, and if it fails return generic Invalid token error whereas it should return Verification disabled due to failed attempts.
To Fix this issue, we could simply override in AuthenticationTokenForm  method _chosen_device:
    def _chosen_device(self, user):
        device = super()._chosen_device(user)
        if not device:
            device_qs = TOTPDevice.objects.devices_for_user(user, confirmed=True)
            return device_qs.last()
        return device

In that case, when device is not specified it takes the last confirmed one (if exists) and later properly triggers for it verify_is_allowed. Therefore when user already had few failed attempts doesn't get a misleading Invalid token when she is sure the token is correct.

There is also a second way, we already pass initial_device to AuthenticationTokenForm we could simply save it:
self.initial_device = initial_device

and overload _chosen_device this way:
    def _chosen_device(self, user):
        device = super()._chosen_device(user)
        if not device:
            device = self.initial_device
        return device

If someone says that this wouldn't work properly if someone has multiple devices, we can even go a step further and add:
    def _chosen_device(self, user):
        device = super()._chosen_device(user)
        if not device and count(TOTPDevice.objects.devices_for_user(user, confirmed=True)) == 1:
            device = self.initial_device
        return device

To make sure that if user has more than one device and didn't select any match_token method will be invoked.
I think we should implement something along this lines since I guess most implementation are single device only, and for those user shouldn't get invalid token error when she should get Too many failed attempts. Wait a moment.

Related #299

What is the status of this? How can I get correct failure message when throttle limit os exceeded?

@claudep I think this issue is solved by https://github.com/jazzband/django-two-factor-auth/pull/626 too and can be closed


SCons: Add num_jobs as an explicit option so it can be set from other sources

The -j flag is only settable via the command line, which makes it hard to configure when running builds from places like VS, where the flag isn't easily exposed or configurable.
This adds a num_jobs option, which lets users configure the number of jobs to be used by default (in a custom.py file or other similar mechanism) if -j isn't specified, instead of always defaulting to number of cores - 1.
Contributed by W4 Games :heart:

Fixed a small issue found after more testing, this is ready to go 👍

Tested, it seems to work well.
Worth noting that if both num_jobs and -j are used, -j takes precedence, regardless of the order. num_jobs in custom.py seems to work fine too.

That's a good point. Where should that note be? Maybe
Use up to N jobs when compiling (equivalent to -j N). Defaults to max jobs - 1. Ignored if -j is specified.
?

I tweaked the message to note the precedent of -j.

Thanks!


Import CA Certificate

This app lists system certificates but is there a way to import certificates via flutter? I've been searching for a way to do it but to no avail.

Even native android apps are not allowed to import CA certificates to the device. Most apps that need a custom certificate for some functionality ask the user to save/download the certificate and then import it manually through the device's settings app.


Add sphinx immaterial theme at version 12.2

Description of changes
From readme.md
This theme is an adaptation of the popular mkdocs-material theme for the Sphinx documentation tool.

This theme is regularly maintained to stay up to date with the upstream mkdocs-material repository.
The HTML templates, JavaScript, and styles from the mkdocs-material theme are incorporated directly
with mostly minor modifications.

Independent of the upstream mkdocs-material theme, this theme integrates with and significantly
extends Sphinx’s API documentation functionality.

This theme is a fork of the sphinx-material theme, which proved the concept of a Sphinx theme based
on an earlier version of the mkdocs-material theme, but has now significantly diverged from the
upstream mkdocs-material repository.

It looks pretty good and is used in many places it also is growing continuously.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a fixed version of the PR #319350 where I rewrote to much history .. sry for the inconvenience. Will fix styling right now ..

@Aleksanaa thanks for the review. I adapted the changes you suggested
@minijackson I updated also to the latest version of sphinx immaterial theme
Thanks for checking the PR!


Cannot create KeyedArray from some tables

Docs for wrapdims say

wrapdims(table, value, names...; default=undef, sort=false, force=false)
Construct KeyedArray(NamedDimsArray(A,names),keys) from a table matching
the Tables.jl API.
(It must support both Tables.columns and Tables.rows.)
The contents of the array is taken from the column value::Symbol of the table.
Each symbol in names specifies a column whose unique entries
become the keys along a dimenension of the array.

It works with the most basic column-table:
julia> wrapdims((a=[1, 2], b=[2, 1]), :a, :b)
1-dimensional KeyedArray(NamedDimsArray(...)) with keys:
↓   b ∈ 2-element Vector{Int64}
And data, 2-element Vector{Int64}:
 (2)  1
 (1)  2

but not with a rowtable - an exception gets thrown:
julia> wrapdims([(a=1, b=2), (a=2, b=1)], :a, :b)
ERROR: ArgumentError: wrong number of names, got (:a, :b) with ndims(A) == 1
Stacktrace:
 [1] check_names(A::Vector{NamedTuple{(:a, :b), Tuple{Int64, Int64}}}, names::Tuple{Symbol, Symbol})
   @ AxisKeys ~/.julia/packages/AxisKeys/KCixh/src/wrap.jl:105
 [2] wrapdims(A::Vector{NamedTuple{(:a, :b), Tuple{Int64, Int64}}}, n::Symbol, names::Symbol)
   @ AxisKeys ~/.julia/packages/AxisKeys/KCixh/src/wrap.jl:87

Looks like a wrong method gets dispatched: https://github.com/mcabbott/AxisKeys.jl/blob/master/src/wrap.jl#L87 instead of https://github.com/mcabbott/AxisKeys.jl/blob/master/src/tables.jl#L213.

That's unfortunate, I guess it's an argument for not using the same function to construct from an array and from a Table. We did not think of this problem when adding the feature, in https://github.com/mcabbott/AxisKeys.jl/pull/21, although we did think that wrapdims is a weird function that should perhaps be re-organised.
The short-term hack is of course to call the inner function yourself:
julia> AxisKeys._wrap_table(KeyedArray, identity, [(a=1, b=2.2), (a=10, b=22.0)], :a, :b)
1-dimensional KeyedArray(NamedDimsArray(...)) with keys:
↓   b ∈ 2-element Vector{Float64}
And data, 2-element Vector{Int64}:
  (2.2)   1
 (22.0)  10

julia> wrapdims([(a=1, b=2.2), (a=10, b=22.0)], :c)
2-element NamedDimsArray(::Vector{NamedTuple{(:a, :b), Tuple{Int64, Float64}}}, (:c,)):
↓ c  (a = 1, b = 2.2)
     (a = 10, b = 22.0)


Add "Read Next"

Add a list to the profile page that shows the next book in the series to read.

Completed as part of #113


bug: Float Terminal: text very hard to read

Consider changing background color and text color. Would it be possible to use the terminal emulator colors, where neovim was started with?

which color? floate terminal just config the shadow color. it does not change builtin terminal color

which color? floate terminal just config the shadow color. it does not change builtin terminal color

Terminal emulator colors (Alacritty):
background: '0xfafafa'
foreground: '0x383a42'
It appears the foreground color is used for the background. How do you read the colors?

Terminal emulator colors (Alacritty):
background: '0xfafafa'
foreground: '0x383a42'
It appears the foreground color is used for the background. How do you read the colors?

This is your colorschme issue. it should config terminal color

This is your colorschme issue. it should config terminal color


graph_sensor_locations.csv for PEMS-BAY

can you provide the graph graph_sensor_locations.csv dataset for PEMS-BAY dataset?

+1

+1

Sorry for the super late reply. The corresponding file has been added in data/sensor_graph/graph_sensor_locations_pems_bay.csv


Making it official package?

This is HUGE! Is there any plan to make it official?

Hi. I doubt this is really possible, since Aegisub is basically a dead project. The last commit to the original repository was in 2019, and the last official release was all the way back in 2014. Even the official website was dead at the moment of creating this package. (recently they resurrected it, mayhaps the project is going to see some activity soon?)
The original version doesn't even build on modern Linux systems without patching, I might've needed to use the Ubuntu 16.04 runtime to make that work without much intervention.
Because of that, I use the already unofficial fork that has all the patches for smoother use and build on the modern systems.
Maybe later if the original project resurrects, or some kind of big fork appears, I will look into making this package official. And also before that I need to figure out how to fix the version number being a commit ID.


missing adressbook for DFI and all Tokens

What would you like to be added: adressbook
Why is this needed: good for sending token to cake or later coins to exchanges, possibly crypto.com for creditcard loading

Hi @Otti24xx , posting non-bug related issues here will eventually turn stale. You can publish your idea on DeFiChain Discussions, garner some support from the community, and the team can decide whether to implement the feature in the future. Thank you!


Time execution of robot_wrapper.display are dependent on the call frequency ?

To give a little bit of context, I'm planning on making the connection with the viewer non blocking by using a shared memory and the multiprocess module. While doing so, I realized some strange behavior, that someone might be able to explain :
I ran some test and realized that execution time of python calls to robot_wrapper.display are dependent on the call frequency.
If called a few times, display execution time is about 1ms in the worst case on my machine,
however, called in a loop, with a reasonable delay of 50ms between calls increase this time to 17ms!
import cProfile
def d(r,t=0):
    for i in range(r):
        robot.display(q_viewer)
        time.sleep(t)

cProfile.run('d(1,0.05)')
gives
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.051    0.051 <ipython-input-3-e24e84bd22c0>:1(d)
        1    0.000    0.000    0.051    0.051 <string>:1(<module>)
        1    0.000    0.000    0.000    0.000 gepetto_visualizer.py:114(<listcomp>)
        1    0.000    0.000    0.000    0.000 gepetto_visualizer.py:115(<listcomp>)
       13    0.000    0.000    0.000    0.000 gepetto_visualizer.py:9(getViewerNodeName)
        1    0.000    0.000    0.001    0.001 gepetto_visualizer.py:95(display)
        1    0.000    0.000    0.000    0.000 graphical_interface_idl.py:577(applyConfigurations)
        1    0.000    0.000    0.000    0.000 graphical_interface_idl.py:580(refresh)
        1    0.000    0.000    0.001    **0.001** robot_wrapper.py:248(display)
        1    0.000    0.000    0.051    0.051 {built-in method builtins.exec}
        1    0.050    0.050    0.050    0.050 {built-in method time.sleep}
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}
        2    0.000    0.000    0.000    0.000 {method 'invoke' of '_omnipy.PyObjRefObject' objects}

but cProfile.run('d(1000,0.05)') gives
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.016    0.016   66.605   66.605 <ipython-input-3-e24e84bd22c0>:1(d)
        1    0.000    0.000   66.605   66.605 <string>:1(<module>)
     1000    0.072    0.000    0.091    0.000 gepetto_visualizer.py:114(<listcomp>)
     1000    0.135    0.000    0.135    0.000 gepetto_visualizer.py:115(<listcomp>)
    13000    0.019    0.000    0.019    0.000 gepetto_visualizer.py:9(getViewerNodeName)
     1000    0.074    0.000   16.502    0.017 gepetto_visualizer.py:95(display)
     1000    0.006    0.000    0.200    0.000 graphical_interface_idl.py:577(applyConfigurations)
     1000    0.006    0.000   16.001    0.016 graphical_interface_idl.py:580(refresh)
     1000    0.006    0.000   16.508    **0.017** robot_wrapper.py:248(display)
        1    0.000    0.000   66.605   66.605 {built-in method builtins.exec}
     1000   50.082    0.050   50.082    0.050 {built-in method time.sleep}
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}
     2000   16.191    0.008   16.191    0.008 {method 'invoke' of '_omnipy.PyObjRefObject' objects}

Even more bizarre, when I call d(100,0.), the cpu spend 0.28ms per display calls in average..
but d(1000,0.) gives an average of 3 to 6ms per display calls.

Using gui.setRefreshIsSynchronous(False) before the benchmark should give a more stable behavior. It makes the call to refresh de-synchronized with the rendering loop.

Many thanks @jmirabel this solved my timing issues.
In the meantime, i also implemented a very simple multiprocess class to call the viewer an other process:
from multiprocessing import Process, Lock
from multiprocessing.sharedctypes import Value, Array
from ctypes import c_double
import pinocchio as pin
import numpy as np
import time
class NonBlockingViewer():
    def __init__(self,robot,timeIntervals=0.05):
        # a shared c_double array
        self.timeIntervals = timeIntervals
        self.shared_q_viewer = Array(c_double, robot.nq, lock=False)
        p = Process(target=self.display_process, args=(robot, self.shared_q_viewer))
        p.start()

    def display_process(self,robot, shared_q_viewer):
        ''' This will run on a different process'''
        q_viewer = robot.q0.copy()
        while(1):
            for i in range(robot.nq):
                q_viewer[i] = shared_q_viewer[i]
            robot.display(q_viewer)
            time.sleep(self.timeIntervals)

    def display(self,q):
        for i in range(len(self.shared_q_viewer)):
            self.shared_q_viewer[i] = q[i]

def benchmark():
    pin.switchToNumpyMatrix()
    modelPath = "/opt/openrobots/lib/python3.5/site-packages/../../../share/example-robot-data/robots"
    urdf = modelPath + "/solo_description/robots/solo.urdf"
    robot = pin.RobotWrapper.BuildFromURDF( urdf, modelPath, pin.JointModelFreeFlyer())
    robot.initDisplay(loadModel=True)

    def job(n,t,disp):
        for i in range(n):
            disp(robot.q0)
            robot.q0[7:]+=0.01
            time.sleep(t)

    #blocking, in sync
    t=time.time()
    job(10000,0.01,robot.display)
    print (time.time()-t)

    #blocking, not synchronous
    robot.viewer.gui.setRefreshIsSynchronous(False)
    t=time.time()
    job(10000,0.01,robot.display)
    print (time.time()-t)

    #non blocking
    nbv = NonBlockingViewer(robot,0.0)
    t=time.time()
    job(10000,0.01,nbv.display)
    print (time.time()-t)

benchmark()

benchmarks give for 10k calls delayed by 10ms:
default : 333.11 s
Asynchronous gui : 106.87 s
shared memory : 101.55 s
So basically, the shared memory only saves 0.5ms per display calls.
This is still useful in my case since I'm calling the display from a realtime thread when prototyping 1kHz controller.

A few remarks:

the accuracy of time.sleep is not so high and is close to the actual computation cost of the function you want to benchmark. Running the following script gives me ~101.30 seconds

import time

def job(n,t):
    for _ in range(n):
        time.sleep(t)

t = time.time()
job(10000, 0.01)
print(time.time() - t)

from your benchmark, I understand that the asynchronous gui takes about 0.6ms per call. This is reasonable because there are inter-process communications. However, 0.155ms is extremely high. You only copy a configuration vector.

Putting the two together, I think the 1.55 extra seconds (in 101.55s) are due, almost entirely, to the bad accuracy of time.sleep.

You are right, the shared memory method is basically the reference point (Comparable of doing nothing), this should not really be part of the benchmark.
As you point out, I can still deduce the time of the display with asynchronous gui, witch is, as you said closer to 0.6ms than 0.5ms.

Using gui.setRefreshIsSynchronous(False) before the benchmark should give a more stable behavior. It makes the call to refresh de-synchronized with the rendering loop.

Why to not set this value by default in gepetto-gui?

Why to not set this value by default in gepetto-gui?

I asked myself the same thing. I think the only reason was for code like:
gui.refresh()
gui.captureFrame("image")

When not synchronous, you don't know which image will be rendered to the file. However, after thinking twice about it and checking the source code, I think you are still guaranteed to render to latest one.
I will change the default for some time on my laptop to see if I encounter any other issues.

Thanks @jmirabel for solving this issue.


GlobalConfigs' "log_format" should be of type String instead of Bool.

Running dbt debug from the CLI task with GlobalConfigs generated throws an error that log_format should be of type String and not bool.
On the other hand, setting a string value via GlobalConfigs throws an error that it should be of type bool.
https://github.com/PrefectHQ/prefect-dbt/blob/dc5f504e0ced080ddf8ceab1cc1e502c5256d9f6/prefect_dbt/cli/configs/base.py#L154

Thanks for the report; I've verified that it should be a string: https://docs.getdbt.com/reference/global-configs#log-formatting
Would you be interested in contributing a PR that changes this into:
log_format: Optional[str] = None and adding a simple test to test instantiating GlobalConfigs with log format set?

Absolutely, let me look into this and I'll ping back if I face any issues setting up the development env

Thanks!


Introduce a thin error API with optional stack trace capturing.

The goal of this package is to enable to capture stack traces when the error are being raised, which speeds up the development process, if enabled at compile time. To do so, this set of changes introduces an internal/errors package to handle errors with four functions: .New, .Errorf, .Is and .Unwrap.
If the code is compiled with the debug build tag, the stack trace will be captured when an error is created or wrapped (both with .New). Without that build tag, the errors packages falls back to simply comparing values and performs no wrapping at all.
This means that it's usable for targeting WASM because it does not depends on reflect / reflectlite as opposed to the standard errors package when .Is or .As is called (such a good call @asdine to point me out that issue before I hit the wall 🙏) There's obviously no free lunch, it also means that we lose along the way the ability to wrap errors and thus be able to get the original type (1).
It also come with a new testutil/assert package which replaces the require package when it comes to checking or comparing errors and printing the stack traces if needed.
Finally, the test target of the Makefile uses the debug build tag by default. A testnodebug target is also provided for convenience and to make sure no tests breaks due to not having used the internal/errors or testutil/assert package.

For the above, the diff is rather small and located in internal/errors and testutil/assert. The rest, the massive set of changes is merely a grind through the codebase to update the API. I have double checked myself on those.
I'm sure there must be a few errors unwrapped, it's hard to catch everything, but. that should cover most of it.
(1) There was one occurence of this, in the online doc package I recently added, but I removed it along the way because it didn't bring much.
PS: please don't mind the commit names, we'll squash as usual :)

Codecov Report

Merging #429 (4a3dca4) into main (076bbac) will decrease coverage by 0.05%.
The diff coverage is 59.21%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   68.99%   68.93%   -0.06%
==========================================
  Files          94       95       +1
  Lines        9706     9726      +20
==========================================
+ Hits         6697     6705       +8
- Misses       2289     2301      +12
  Partials      720      720

Impacted Files
Coverage Δ

document/array.go
62.35% <0.00%> (ø)

document/create.go
65.06% <ø> (ø)

document/encoding/custom/format.go
69.23% <ø> (ø)

internal/binarysort/binarysort.go
79.24% <ø> (ø)

internal/database/constraint.go
78.43% <0.00%> (ø)

internal/database/database.go
60.71% <ø> (ø)

internal/database/sequence.go
77.45% <ø> (ø)

internal/expr/constraint.go
0.00% <ø> (ø)

internal/expr/functions/builtins.go
9.54% <0.00%> (ø)

internal/expr/operator.go
44.06% <ø> (ø)

... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076bbac...4a3dca4. Read the comment docs.

Closing this in favour of #431.


ReferenceStrip not displaying correctly if viewer is 0 height on creation

Hello, I'm newbie with OpenSeadragon. I'm try to update from v1.2.1 to v2.1.0. My problem is ReferenceStrip not display correctly.
In v1.2.1, i create div "openseadragon1" without css, and call OpenSeadragon as follow.
	OpenSeadragon( { 		id: "openseadragon1", 		prefixUrl: "./images/", 		tileSources: ["./dzi/file1.dzi","./dzi/file2.dzi","./dzi/file3.dzi","./dzi/file4.dzi","./dzi/file5.dzi",], 		showNavigator: true, 		showReferenceStrip: true, 	} );
ReferenceStrip is displayed correctly(width: 27897px; height: 106.2px).
In function Viewer.openTileSource(), viewer.element has clientWidth=1581px and clientHeight=531px (in my case) before creating ReferenceStrip.
But in v2.1.0, with below code
	OpenSeadragon( { 		id: "openseadragon1", 		prefixUrl: "./images/", 		tileSources: ["./dzi/file1.dzi","./dzi/file2.dzi","./dzi/file3.dzi","./dzi/file4.dzi","./dzi/file5.dzi",], 		showNavigator: true, 		sequenceMode: true, 		showReferenceStrip: true, 	} );
ReferenceStrip isn't displayed correctly(width: 35275px; height: 0px).
In function Viewer.open(), viewer.element has clientWidth=2015px, clientHeight=0px.
After debug, I see
In v1.2.1: The first  time getImageInfo() function is called before creation of  ReferenceStrip.
In v2.1.0: ReferenceStrip is created before calling getImageInfo() function.
But i'm not sure this is problem.
How to display ReferenceStrip correctly with v2.1.0 as v1.2.1 without setting height to div "openseadragon1"

Interesting...this may be a bug in the reference strip (that it doesn't work if the viewer has no height to start with). Why is it important for your viewer to not have a specified height?
One possible workaround would be to use the referenceStripWidth and referenceStripHeight properties (looks like you need to use both or it won't work) when creating OpenSeadragon.
Otherwise, fixing the bug would involve having the reference strip watch for changes in the viewer size and resize the reference strip's element.style.width, element.style.height, panelWidth, and panelHeight, if you want to look into that.

Why is it important for your viewer to not have a specified height?
Div don't have specified height because I want ReferenceStrip resize base on Browser's size. It worked in v1.2.1.
I try to use referenceStripWidth and referenceStripHeight, it affect ReferenceStrip but in viewerSize.y = 0 and panelHeight=8. So, height of images in ReferenceStrip just only 8px .

Yes, having it resize based on the browser size would be lovely. I'm sorry to hear that has broken. Seems to me like your options are:

Debug ReferenceStrip and fix the issue (with my suggestion above); I'm happy to answer questions and point you in the right direction.
Use a fixed viewer size, at least at the start while it's loading.
Go back to OSD 1.2.1.
Write your own referenceStrip plugin.
Hope someone comes along to fix this bug.

And other abnormal, the size of image in the first open is not same the size of image when home button is clicked.

This is unrelated to the reference strip, but part of moving from 1.2.1 to 2.1.0? Can you share a link to this in action?

Thanks for your suggestion. Finally, I use a fixed viewer size. Now it works perfectly.

And other abnormal, the size of image in the first open is not same the size of image when home button is clicked.

This abnormal occurred when i cheat to display reference strip.

Good to hear!


Install QEmu from prebuild images

Add a script to the prebuild images to install QEmu and the required dependencies when using a prebuild images. By far, the only needed one is qemu-system-x86 package.

Status?

Not started :-) Do you want to take it?

Yeah, sure!

Taking a shot at this now.  Has QEMU been wrapped in a npm module yet or do I need to create that too?

Do a search on npm for the qemu package ;-)
El 22/6/2016 11:30 PM, "Lite McFish"<EMAIL_ADDRESS>escribió:

Taking a shot at this now. Has QEMU been wrapped in a npm module yet or do
I need to create that too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/240#issuecomment-227882868, or mute
the thread
https://github.com/notifications/unsubscribe/AAgfvnXxKMiBHXpBgVzuZwsKerg3BRixks5qOal2gaJpZM4IknMl
.

Any update on this?

I'm without computer right now (I do all work from my phone) so it's up in the air for anyone to grab!


Disable -warn-error by default

Ideally we'd like to enable -warn-error for developer builds but disable
-warn-error for tagged release builds. This patch disables -warn-error
for both cases: it's not worth too much work on the current build and
packaging system when we're likely to switch over to topkg soon.
This allows vpnkit to build with lwt.2.7.0.
Related to [ocaml/opam-repository#8195]
Related to [ocaml/opam-repository#8196]
Signed-off-by: David Scott<EMAIL_ADDRESS>

Perhaps you could just remove warning 3 (deprecated feature) from the warning-as-error list? Most others are safe, I believe, and help keep the codebase clean by making warnings unmissable.

@dsheets good idea, I'll do that.


observer loop. This to stop secrets payload from ending in the MR

Description of your changes
Change Observer loop not resolve secret in start of loop but rather resolve the secret in the create/update/delete funcs
to not leak the secrets data in the the k8s MR object.
Fixes #223
Description of your changes
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
manual test locally to see that the secret is not leaking in to the MR using this manifests.
provider for testing have been started with --sanitize-secrets
---
apiVersion: kubernetes.crossplane.io/v1alpha2
kind: Object
metadata:
  name: secretpatch
spec:
  references:
  - patchesFrom:
      apiVersion: v1
      kind: Secret
      name: secretpatch
      namespace: crossplane-system
      fieldPath: data.sensitive
    toFieldPath: data.key-from-secret
  forProvider:
    manifest:
      apiVersion: v1
      kind: Secret
      metadata:
        namespace: default
      data: {}
  providerConfigRef:
    name: kubernetes-provider
---
apiVersion: v1
kind: Secret
metadata:
  name: secretpatch
  namespace: crossplane-system
type: Opaque
data:
  sensitive: cGFzc3dvcmQ=

I have looked at the test but could not see any clear way to add testing to confirm the new secrets logic


Error 500 on user login

I'm unable to login to my selfhosted instance. Emails are not redirected either.
v1.1.0
Don't know what could have changed. I'm seeing no log output on the php docker.

Oh sorry @willbrowningme.
Thought it was a software issue at first.
Well, it was not.

 What's your compose configuration looks like? DB is not exposed in our examples: https://github.com/anonaddy/docker/blob/fd6c9fba9578499f7704047d628c59556d9dcbc7/examples/compose/compose.yml#L4-L18

The compose file uses the provided example.
.env
MYSQL_USER=luckydonald
MYSQL_PASSWORD=2346ljkdfjsdfgj32409#1215t24399DHKZ45z9bdß043tkldvsvbjn4btn-asdfag,sf342659023

All I added was a second phpmyadmin container.
I would log in with the user luckydonald and the secure password 2346ljkdfjsdfgj32409#1215t24399DHKZ45z9bdß043tkldvsvbjn4btn-asdfag,sf342659023 there.

All I added was a phpmyadmin container

Not sure if you don't share your compose file and we also don't have anything like this in our examples.
Closing as this is not reproducible with our exmaples.

I don't understand why you deliberately want the root user to have the very insecure password "" without documenting that...

then it's probably why your db got hacked.

It didn't got hacked, someone used the default password you set to "root" with the password "" .

I don't understand why you deliberately want the root user to have the very insecure password "" without documenting that...

What is provided in https://github.com/anonaddy/docker/tree/master/examples are just examples to have a anonaddy compose stack running. Up to anyone to tweak it based on their needs but setting root password in our examples is not needed.

That's a good solution. Thanks.


Unexpected behaviour in admin UI if change permission is set to False

I would expected that if I set a Page object to not modifiable that the sidebar is not shown at all. Additionally a unexpected red tab with "Unknown region: undefined" appears and the delete checkbox is replaced with a drop down menu:

Pseudo code
models.py
class Page(AbstractPage, RedirectMixin):
    regions = [
        Region(key="main", title="Main"),
    ]
    ...

admin.py
@admin.register(models.Page)
class PageAdmin(ContentEditor, TreeAdmin):
    inlines = [
        RichTextPluginInline,
        ImageWithRichTextPluginInline,
        PeoplePluginInline,
    ]
    ...

    def has_change_permission(self, request, obj=None):
        return False

    def has_delete_permission(self, request, obj=None):
        return False

Thank you for the quick fix!
If not to troublesome I would suggest to also hide the following elements:

Makes sense!

looking good - thank you again for the very quick fix!
NB: one could still use drag & drop plugins - but that is not very obvious - nothing happens anyway


Adjust bash integration in README.md

Hi! Really nice project :) !
For me the following line works in bash, as well (i.e., with an additional back slash before "$()"):
if [ "$TERM" != "linux" ]; then
    PS1="\$(~/powerline-shell.py $? 2> /dev/null)"
fi

Hm, no, I guess it is not working, it just seemed so.


Move download-folder-button to the dropdown

LINKED ISSUES:
Resolves #3949

TEST URLS:
https://github.com/sindresorhus/refined-github/tree/main/media

SCREENSHOT:

I added repeatOnBackButton: true, since I found that when going from dir to dir it was not applying unless I refreshed (nothing to do with the current PR)

I found that when going from dir to dir it was not applying

That’s the same as #3945. The global anti-duplication mechanism is preventing the call of inits on file lists. It’s a tough problem 😕 it’s worth adding a comment pointing to #3945 on the repeatOnBackButton line

@fregante is this good?

After the outstanding comments, feel free to merge this, #3962 and release a new version via the Actions repo tab 🚢


Moderation Tools: Bot answers when shouldn't be

Can the bot not answer to the command how to use it correctly

if the user can not use this command at all?
Or did I configure smth wrong?

use command overrides to restrict it to staff roles only

it can ban all commands or none(( Is there a workaround for in-between solutions? like few commands can be used but others cannot

it can ban all commands or none
That is not the case. Command Overrides (at the bottom of the page) can be used to create exceptions to settings, for specific commands.
Though, this is a line of enquiry better suited for the support server.


Ngtsc error shown since last Typescript update

Hi, I've upgraded my Angular project lately (from an earlier 18.X to the 18.2.8) which also upgraded Typescript. Sublime Text is now showing the error "this kind of expression is always falsy" (ngtsc 2873), which is a bit annoying since the code is actually working.
The culprit is the ?. operator whenever I use it on an optional variable. For example: <app-configuration-panel [configuration]="currentApp?.configuration" /> (perfectly valid, the input accepts undefined/null values).
I don't have any TS error if I disable Ngx HTML so I believe that this is the plugin that handles TS's errors in HTML templates. Is there a way to disable specific TS errors? I'd like to keep the ones that cause compilation errors and disable only the 2873. I've tried using tsc-silent but it didn't work.
Thanks for your help!

I ran into this problem, too. I haven't got the time to fix it. The fix will probably be in lsp-angular, or in my own configs.

Ok thanks! I'll check LSP-Angular to see if there's anything there (yet).

So I finally got to this. Looks like it's because LSP-angular upgraded to ts 5.6 too soon. The fix is easy, though. Simply install @angular/language-server and<EMAIL_ADDRESS>somewhere and point LSP-angular to use that.
An example for Windows users, *nix users can simply replace the path with *nix format
{
  "command": [
    "${node_bin}"<EMAIL_ADDRESS>    "--logFile", "C:\\Users\\chenp\\tmp\\angular-ls\\ngls.log",
    "--ngProbeLocations", "C:\\Users\\chenp\\tmp\\angular-ls\\node_modules",
    "--tsProbeLocations", "C:\\Users\\chenp\\tmp\\angular-ls\\node_modules",
    "--stdio"
  ],
}

LSP-angular also has an example at the bottom of its readme for projects that have language server package as part of its dependencies, that would work on any platform.


SightLayer method has been renamed. Broken compatibility with 0.7.6.

SimpleFog 0.1.11 was a little flaky under FoundryVTT 0.7.5, but it still basically worked. However, it is completely broken in Foundry VTT 0.7.6. Loading a map with the module enabled generates the following error in the console:
You are calling the SightLayer#update method which has been renamed to SightLayer#refresh to be consistent with other PIXI objects.
update @ foundry.js:39500
onClick @ controls.js:21
_onClickTool @ foundry.js:19874
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
The drawing tools show up outside of the map, but disappear when you move your mouse over the actual map. No fog shows up on the map (new or previously drawn). I suspect this is because it cannot update the sight layer due to the method being renamed.

Additional information:
My server is running FoundryVTT 0.7.6 using NodeJS 14.15 on top of Ubuntu Linux 20.04.1 with all updates applied. My client is running Google Chrome 86.0.4240.183 on Windows 10 v2004.

Well, I did a little more experimenting. I updated the module to replace calls to sight.update to instead call sight.refresh. That cleared the error and made the drawing tools work again. However, the fog canvas is not aligned with the underlying map so it looks like this is going to be a bigger issue than a simple renamed method.

I am also experiencing this issue. Thanks for the wonderful mod so far

Yes amazing mod but I had to disable it for the moment.

I was able to fix this module, and just did a pull request. Can't promise it fixed everything but not getting any errors after testing this on all settings, switching maps, etc. Had one other person test too. Not sure if Vance is updating  anymore, so feel free to switch to my forked version. https://raw.githubusercontent.com/crhampton1/simplefog/0.1.12/module.json

Just providing an update on all open issues with Vance's module. This has been taken over by the League of Foundry Developers. This will help prevent lapses in updates. I have taken over as main contributor. All new releases and updates will be managed through the new forked version. We will get the link updated on the Foundry VTT website, but you may want to go ahead and switch. We have already updated and added some new features.
To install this fork, you first will have to uninstall the old module, then install based on this manifest url. You should not lose your fog on maps you have used previously.
https://raw.githubusercontent.com/League-of-Foundry-Developers/simplefog/master/module.json


Remove spells that can't be used properly by NPCs

Spells that break NPCs (must be removed):

~All Cloaks: NPCs thinks this is the most damaging spell, so they only use these cloaks until magicka dries out.~ Doesn't look like it. In my testing mage only briefly recasted cloak and switched back to other spells.
Summon Arvak: NPCs don't need horse 🙂
Soul Trap: Too high-tech for NPCs to use.
No Runes: those guys don't know that runes go onto surfaces and not in player's face 🙂

Spells that NPCs ignore (may leave those in case another mod fixes their problem):

~Thunderbolt~ fixed
~Wall of Storms~ fixed
Ritual spells (Blizzard, Fire/Lightning Storms). They might use it only when faced multiple enemies though
Whole Illusion is basically pointless

Other notes:

I think I figured out the cloaks problem. Mages should ever learn one cloak spell, otherwise they'll be stuck recasting every cloak they have.

This enhancement is part of a larger-scale thorough rework, so I'm gonna close it as redundant.


Please replace pycrypto with pycryptodome

Hi,
pycrypto becomes an obsolete package, it is really hard to compile it on Windows, there are no binary releases for Python 3.5 and 3.6.
pycryptodome is a drop-in replacement which has better support.
Please consider replacing pycrypto with pycryptodome, as in this pull request. No source changes in pdf miner.six are required,
as Python 3 is your area of interest, pycryptodome will give us better support for pdf miner.six on Windows.
thank you for a great package BTW!

Thank you !


remove mafin section from mafin config

@dkiadrynski
Looks good to me!
I've also notices couple of disrepances in README file though, so I went ahead and fixed them.
Please, let me know if the change looks good or not.


adding colours and groups to the logger

I like the colours but think a few things could be clearer

a bit confusing that my prev and next states are in data.prev and data.next and not beside the action args.
bit confusing why args is under the origin

When debugging my actions I will mostly care about the prev/next state and args. This would take about 6 clicks to get all the information. I'm not sure what the best grouping is, but my suggestion is to move args with the universe changes

+1 to Jake - I've found the Redux logger to be quite useful in the past with their prev state | action | next state structure (although maybe I'm just used to it now too).

as per discussion IRL we will

keep the arguments on the same line as action name (group)
"prev" line of universe before (use spread)
"next" line of universe after (use spread)
"meta" is a group, and you unfold it to get effects (if any), patches, renrender, nextActions, origin...

How's this? Technically meta is just a log instead of groupCollapsed right now. I can show a groupCollapsed alternative if you'd prefer.
Should I make it prevUniverse.state or do we want them to see plugin states too?

Merging since Bruno approved verbally...

Maybe rename meta to action and put it in the middle? That would be more similar to redux-logger...


nodepro.xyz-validator.toml

Please provide some contact info provided. Not merged for now due to no contact info

hey @adrianbrink is it possible to re do the pr? or do you think I should create a new file and make a pr with that?

dc: gloreix#1617
tg: nodepro.xyz
mail<EMAIL_ADDRESS>


Question

Hi, how is this different from Whaticket or Press-ticket?  https://github.com/FilipeCamillo/Press-Ticket

Hi, how is this different from Whaticket or Press-ticket? https://github.com/FilipeCamillo/Press-Ticket

Good morning! This code performs an automated service. The customer contacts the connected number, selects the category (financial, commercial, …) created by you and starts a conversation with the available attendant.


Support html format

Upload html documents
Add 3mb limit to filezise
Sanitazion happens on the backend to prevent the upload of files with xssattacks
Sanitization whitelists a set of tags, attributes and propperties
View document page renders content accordingly (txt with new lines, html with styles)
Annotation on html documents
Change button label from choose to select in both uploads (task and document)

Was closed and reoponed as a different PR to change the destination branch from 'main' to 'dev'.