CardinalityRepository is unusable

As of now, the code in the CardinalityRepository is commented.
However, especially for ML use cases, sampling and storing measured cardinalities can be an essential step.
I think we should try to fix the code to provide this functionality to users.

Desirable output can resemble this:
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":206,"upperBound":206,"confidence":1.0}],"operator":{"class":"org.apache.wayang.spark.operators.SparkFlatMapOperator"},"output":{"name":"out","index":0,"cardinality":1759}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":206,"upperBound":206,"confidence":1.0}],"operator":{"class":"org.apache.wayang.basic.operators.FlatMapOperator"},"output":{"name":"out","index":0,"cardinality":1759}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":206,"upperBound":206,"confidence":1.0}],"operator":{"class":"org.apache.wayang.java.operators.JavaFlatMapOperator"},"output":{"name":"out","index":0,"cardinality":1759}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1759,"upperBound":1759,"confidence":1.0}],"operator":{"class":"org.apache.wayang.basic.operators.FilterOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1759,"upperBound":1759,"confidence":1.0}],"operator":{"class":"org.apache.wayang.spark.operators.SparkFilterOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1759,"upperBound":1759,"confidence":1.0}],"operator":{"class":"org.apache.wayang.java.operators.JavaFilterOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.basic.operators.MapOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.spark.operators.SparkMapOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.java.operators.JavaMapOperator"},"output":{"name":"out","index":0,"cardinality":1611}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.basic.operators.ReduceByOperator"},"output":{"name":"out","index":0,"cardinality":493}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.spark.operators.SparkReduceByOperator"},"output":{"name":"out","index":0,"cardinality":493}}
{"inputs":[{"name":"in","index":0,"isBroadcast":false,"lowerBound":1611,"upperBound":1611,"confidence":1.0}],"operator":{"class":"org.apache.wayang.java.operators.JavaReduceByOperator"},"output":{"name":"out","index":0,"cardinality":493}}

Requires configuration like this:
Configuration config = new Configuration();
config.setProperty("wayang.core.log.enabled", "true");
config.setProperty("wayang.core.log.cardinalities", filePath);
config.setProperty("wayang.core.optimizer.instrumentation", "org.apache.wayang.core.profiling.FullInstrumentationStrategy");


Ensure BuildPack.python_version is specified

removes lockfile copies without Python version number
enforces that buildpack.python_version is always specified (major_pythons['3'] in cases where it could have been falsy before)
warns when Python version is unspecified, which ensures future reproducibility failures

closes #1243

I don't trust the coverage report (and don't think we should have any coverage failure conditions), because it says if self.separate_kernel_env is never True, but it clearly is in e.g. tests/conda/py2.

good enough for me, @minrk :)


Huge runtime difference between running with and without encryption with Workload E

i have made some test running ycsb in mongodb enterprise with and without encryption at rest. I was using the default workloads and i found some weird results when running the workload E.
Without encryption the runtime was about 13mins but when i switched it to an encrypted database the runtime jumped to a suspicious 17HOURS!!!
There must be something wrong but i cant figure what it could be. All the tests are being made with 100K operation count and 10M itens count, and im rebooting the system after each run. Would appreciate some help figuring this one out

any ideas here @allanbank ?

Still interested in chasing this down @nelsonbrabra?


Cannot access site unless you are a member of the thoughtbot team error

So, I took pester out for a spin (trying to incorporate it to our workflow). Set up went smoothly however, I keep getting the following notification after a successful login:
You cannot access this site unless you are a member of the thoughtbot team

The GITHUB_TEAM_ID env var is already set in Heroku to match my org's. Any thoughts?
thanks,

nvm, re-set env var and reboot app. Got it working. Thanks!


Make AnimatedSprite const correct

Animated sprite has a bunch o fgetters hat are not const.
They should be const.
Adding noexcept where it belongs would also be nice.

getters are now const.

Merged into Dev


capture() fails with WinError[995]

I am trying to get high speed capture using capture->delay->stop. When calling creat(), I always got this exception:
Unhandled exception in event loop:
  File "C:\Python38\lib\asyncio\proactor_events.py", line 768, in _loop_self_reading
    f.result()  # may raise
  File "C:\Python38\lib\asyncio\windows_events.py", line 808, in _poll
    value = callback(transferred, key, ov)
  File "C:\Python38\lib\asyncio\windows_events.py", line 457, in finish_recv
    raise ConnectionResetError(*exc.args)

Exception [WinError 995] The I/O operation has been aborted because of either a thread exit or an application request
Press ENTER to continue...

This issue seems only to impact the ipython environment.

Apologies for the late reply. This appears to be an ipython bug with an issue that is still open: https://github.com/ipython/ipython/issues/12089
It's unrelated to D3DShot so I'm going to close the issue, but for the record, I also get it on Windows 10 once in a while with the latest ipython.


Can't copy and paste without xclip

For portability, ( and IMHO), a terminal editor should not depend on xclip for clipboard.
How about an internal clipboard that doesn't depend on xclip, and uses it only if it exists?
Or a fallback tiny one
With an internal clipboard, and things like #67 and #64, we are able to use micro with no mouse and no window system.
But don't get me wrong, I dig the mouse.

Yes you're definitely right. I think it might be worth forking atotto/clipboard to add a fallback non-system clipboard if xclip or xsel isn't installed.


Formatting/copying issues in the chat window

The problems described below were found by me in the Cody extension for VSCode.

The mouse context menu command "copy" does not work in the chat window.
But <Ctrl + C> works.
The problem with all html documents is that list item markers are not selected
and cannot be copied along with the contents of the list:

 action one

 action two

 action three

 firstly

 secondly

 thirdly

Cody also uses similar formatting in his replies and
so all the lists in the reply are copied garbled (no item markers).

If a query string contains an expression with angle brackets,
it will be cut out when displayed in chat, i.e.:

What is <int>?
it's turning into:
What is ?
Although, the content <...>, judging by the replies, Cody receives.

Hey @JohnMcLaren what OS are you using? I was unable to replicate it on macOS.
Just out of curiosity does "Insert at Cursor" also not work?

Hey @jdorfman !
I'm using Linux.
Initially, those problems were found in Kali Linux.
I then checked the behaviour of Cody in Debian Live and Kali Live.
VSCode was installed in them in the same way  from the console:
# Get additional utilities
sudo apt install wget gpg apt-transport-https

# Add Microsoft key and repo
wget -qO- https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > packages.microsoft.gpg && \
sudo install -D -o root -g root -m 644 packages.microsoft.gpg /etc/apt/keyrings/packages.microsoft.gpg && \
sudo sh -c 'echo "deb [arch=amd64,arm64,armhf signed-by=/etc/apt/keyrings/packages.microsoft.gpg] \
https://packages.microsoft.com/repos/code stable main" > /etc/apt/sources.list.d/vscode.list' && \
rm -f packages.microsoft.gpg

# Update repo sources
sudo apt update

# Install VSCode (~380 MB)
sudo apt install code

I noticed that the contents of the "About" window in VSCode in Live systems are different from what I saw in Kali Linux.
============================ Debian 12 XFCe Live
VSCode "About"
    Version: 1.80.1
    Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
    Date: 2023-07-12T17:22:25.257Z
    Electron: 22.3.14
    ElectronBuildId: 21893604
    Chromium: 108.0.5359.215
    Node.js: 16.17.1
    V8: <IP_ADDRESS>-electron.0
    OS: Linux x64 6.1.0-9-amd64

============================ Kali Linux Live (XFCe v4.16 GTK v3.24.34)
VSCode "About"
    Version: 1.80.1
    Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
    Date: 2023-07-12T17:22:25.257Z
    Electron: 22.3.14
    ElectronBuildId: 21893604
    Chromium: 108.0.5359.215
    Node.js: 16.17.1
    V8: <IP_ADDRESS>-electron.0
    OS: Linux x64 5.18.0-kali2-amd64

============================ Kali Linux (XFCe v4.18 GTK v3.24.37 NodeJS v17.4.0)
VSCode "About"
    Version: 1.80.1
    Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
    Date: 2023-07-12T17:22:25.257Z
    Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.80.1 Chrome/108.0.5359.215 Electron/22.3.14 Safari/537.36

Then I completely re-installed VSCode on the main Kali Linux system and that seems to have solved the copying problem.
============================ Kali Linux (XFCe v4.18 GTK v3.24.37 NodeJS v17.4.0)
VSCode "About" (after re-installing VSCode)
    Version: 1.80.1
    Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
    Date: 2023-07-12T17:22:25.257Z
    Electron: 22.3.14
    ElectronBuildId: 21893604
    Chromium: 108.0.5359.215
    Node.js: 16.17.1
    V8: <IP_ADDRESS>-electron.0
    OS: Linux x64 5.18.0-kali2-amd64

Differences in behaviour between Debian and Kali Linux

Behaviour of buttons on code in the chat window:

"insert at Cursor" - inserts, regardless of the selection, all code at the specified position.
"Copy" - in Kali copies all code regardless of selection. In Debian it copies the selected code fragment.
Copying the selected code with the mouse - works.

Behaviour on plain text in the chat window:
Copying selected text with the mouse - works identically in both Kali and Debian.
One more question, why are there "Cut" and "Paste" items in the mouse context menu
if they don't even apply to the text of Cody's reply anyway?
The behaviour with angle brackets in the request, in both systems is the same, they are not displayed:

The behaviour when copying lists in the response text is also identical,
only the text without markers and indentation is copied.
To test this, create a request to which Cody will respond with a list.
For example, "Steps to calculate Pi."
Then select the list and copy it. As you can see the list markers are not selected:

Once pasted into a plain text document, the list will turn into this:

Is it a different behaviour on Macs and the lists are copied correctly?

Thank you so much @JohnMcLaren, for this detailed report! I will share it with the team and follow up asap.

@jdorfman , I was able to get 100% reproduction of the mouse copy problem in the Cody panel.
The thing is, to get the "Forward" and "Backward" code navigation buttons

, we do the following:

Enable Command Center showing - enable the "Window: Command Center" option

Set the value of "Window: Title Bar Style" to "custom"

It is after doing the 2nd point that - copying with the mouse begins to work incorrectly.
Instead of copying a selected text/code fragment in the Cody panel,
a line from the code window with the cursor on it is copied to the clipboard.


distro-specific build patch go-lint fix

Signed-off-by: Sally O'Malley<EMAIL_ADDRESS>

Merged.


improve compile times even further

this will consist of mainly moving all non-templated function bodies out of the forward declaration part and into the implementation. Also I might use an anonymous namespace for the implementation details in the implementation part - to make them with internal linkage.
first commit for this: 13e574ca5b4b9ba942fdbfd69c7cf9e63a616686
another one: fe3008d330d31170289599ece2bc32b13e1f5f4d
more: 31e76506b495ff16d60772e5cac9200303abf24c

seems that my work from today made the header ~40% lighter for inclusion! on my machine with MSVC in Debug it went down from 17ms to 10ms !!!


Is KW_TARGET_HAS_INVOCATION_EXCEPTION_BUG still valid?

KiwiConfiguration.h includes the following comment:

As of iPhone SDK 4 GM, exceptions thrown across an NSInvocation -invoke or
forwardInvocation: boundary in the simulator will terminate the app instead
of being caught in @catch blocks from the caller side of the -invoke. Kiwi
tries to handle this by storing the first exception that it would have
otherwise thrown in a nasty global that callers can look for and handle.
(Buggy termination is less desirable than global variables).
Obviously, this can only handles cases where Kiwi itself would have raised
an exception.

Recently, I wrote a spec that checked if a wrapper method was properly catching an exception and turning it into an error result. To simulate the exception, I stubbed a called method and raised inside a block. With KW_TARGET_HAS_INVOCATION_EXCEPTION_BUG defined, Kiwi swallows the exception and fails the spec, though not for the reason one might expect. It fails because of the exception (even though there's a @try/@catch further up the stack), not because the method under test returns the wrong result.
iOS 4 was a long time ago, so I disabled this workaround to see what would happen. Doing so allowed my new spec pass and did not generate any new failures. I am wondering if sometime between iOS 4 and iOS 7, Apple fixed the problem with the simulator and this workaround is no longer needed.

Hit this today, disabled KW_TARGET_HAS_INVOCATION_EXCEPTION_BUG and not experiencing any issues with it disabled.


"Deposit Period" proposal status, allow multiple people to submit deposits

If proposal deposits are enabled, it would be nice if multiple people could team up to submit a proposal deposit. This mirrors things work in the Cosmos SDK governance module.
Use case: imagine a very large DAO with a very high proposal deposit. Poorer DAO members may not be able to afford the full deposit, but they can create a proposal and convince others to join in.
Adding this period gets us really close to the full proposal life cycle we're aiming for:
draft -> deposit -> live -> executed

This change will have some UX implementations. For convenience, it would still be nice if I can create a proposal and pay the deposit in the same create proposal transaction.

Think this will need a larger refactor. Really like this approach: https://github.com/DA0-DA0/dao-contracts/discussions/462

https://github.com/DA0-DA0/dao-contracts/pull/481


Improve storage_write documentation

There is a way to store data directly from registers, but it requires a hacky input:
https://github.com/near/NEPs/issues/137#issuecomment-784645813
This should be documented in storage_write interface.

Related https://github.com/near/docs/issues/1163 and even https://github.com/near/sdk-docs/issues/6 (mentions documenting register usage)
going to move this issue to the docs repo as this seems like the best place to indicate that pattern


call _handleAccountsChange when selectedAddress changed in config

When I used the Metamask Inpage Provider in my chrome extension, it didn't get any wallet_accountsChanged event. Also it can be useful if the selectedAddress changes in ConfigStore, can be handled correctly by calling the  _handleAccountsChange method.

Hi @nugaon, the reason we don't check for selectedAddress in the publicConfigStore state is because we've removed it in MetaMask. In fact, we are going to remove the publicConfigStore entirely, and replace it completely with JSON RPC notifications.
Consequently, we will not modify the existing publicConfigStore functionality in this module, and I am closing this PR.


feat: update CMakeLists for Visual Studio

2nd attempt

I member now, I wanted to do this for a reason.  But that reason is not longer valid.   Now it is just confusing me with the parent repo pr.  I need to keep local changes local, and master here sync'd to parent repo master.  Otherwise I'll confuse and comingle things I can't keep track of.


Add logo

@volodya-lombrozo please assign this one to me. I'll send few drafts

@l3r8yJ Could you please describe in a few words what you are going to do?

@volodya-lombrozo I want to put a police hat on Duke

@l3r8yJ I got it :) our cop clearly lacks a hat


count limit in api.py/search_raw(self, q: str, limit=-1, kv=None) is not used

count is always 20 "count": 20

Hi, @samisme24062000.
I'm not sure I understand your question.
Limit is internal logic of lib, its not connected to twitter api.
Count is field in api call, you can see this issue for more details: https://github.com/vladkens/twscrape/issues/4

Hello, @vladkens  , im using the api.search method , it always return 20 tweets, no matter what the limit set in arg, because the parameter is passed to function but not used in def search_raw(self, q: str, limit=-1, kv=None), i had to change the "count": 20 to "count": limit

@samisme24062000 limit behaviour (for non raw methods) fixed in v0.6.0
count in twitter api in many methods ignored by twitter side.
to update use: pip install --upgrade twscrape


[IPAM] fix uninstall

Description
This PR fixes the uninstall with the new IPAM.
In particular, it sets a specific annotation to networks installed with Helm. Since these are required through the whole lifecycle of Liqo, we do not add a finalizer since we do not need to unmap them (as we are uninstalling anyway).

/test


Create fr.js

Some translations might be inaccurate but most of them are correct.
I also didn't edit the dates format as I didn't exactly know how can I edit them and t he "set times" field as I didn't see where does it go to notice the exact translation ^^

Thanks both! I'm merging what we've got here and left a comment filled with everything left to translate (stuff I've added since, sorry!). Merci beauçoup !


Pipeline Workaround: Command Output

Right now, in order to get output from an command, you have to pipe it into a file and then read that file (example).
This is the approach recommended by the pipeline plugin for now, but it's pretty hacky. We should keep our eyes out for a better solution to this.

Fixed in #203


Add device management tutorial

Describe the feature request
Also explain how to react to the Audio Notification Subsystem's notifications to automatically set the same audio output device in the plugin as in UE5.

Will be available in 1.1.0-beta.7 ; the notification system will be explained in another ticket.


[Bug] Styling broken for Shadow DOM

Reproducible in vscode.dev or in VS Code Desktop?

[ ] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
const template = document.createElement('template');
template.innerHTML = `
<style>
    #innercontainer {
        height: 100%;
    }
</style>
<div id="innercontainer">

</div>`;

class MonacoWC extends HTMLElement {
    constructor() {
        super();
        this.attachShadow({ mode: 'open' });
        this.shadowRoot.appendChild(template.content.cloneNode(true));
    }

    connectedCallback() {
        const innercontainer = this.shadowRoot.getElementById('innercontainer');
        monaco.editor.create(innercontainer, {
            value: "function hello() {\n\talert('Hello world!');\n}",
            language: 'javascript'
        });
    }

    render() {

    }
}
window.customElements.define('monaco-wc', MonacoWC);
const container = document.getElementById('container');
const wcEditor = document.createElement('monaco-wc');
container.append(wcEditor);

Actual Behavior
editor is loaded, however styling is off. lines change order upon scrolling
Expected Behavior
editor should load normally, woth scrolling not affecting lines order.
Additional Context

I marked this as question as we don't have the resources to investigate issues in third party source code.
Please provide a minimal example that is reproducible in the monaco editor playground.

@hediet Please see the updated issue. I created a Playground example that shows the issue. Just replace the Javascript in the HelloWorld example. Thank you!

Thanks for the example! I can reproduce, it looks completely broken.

I found a workaround : include the monaco-editor/min/vs/editor/editor.main.css styles in the shadow dom

@cameronbraid nice, I confirm that this works.
Also I created a simple to use lit based web component, that works out of the box: https://gitlab.com/designestate/dees-editor
Simply put the  component anywhere where you want to have a monaco editor.
The API will get more features over the next few days.

Check out this example.
You have to include the CSS in the web component.


Create fr.json

Add translation French File

@laventin85 it's already done in the previous PR. Thanks!!!


Copy Cash Karp to fresh branch to test build (Issue #2334)

Summary
This is just a copy of https://github.com/stan-dev/math/pull/2336 to check if the Rtools 3.5 tests pass.

Looks like the 1 core thing worked, so closing this


test the right package on Travis

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5878f12). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   46.51%
=========================================
  Files             ?        2
  Lines             ?       86
  Branches          ?        0
=========================================
  Hits              ?       40
  Misses            ?       46
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5878f12...1a4ca5f. Read the comment docs.


removed unnecessary space

What's done:

fixed mistake according to new rules in: https://github.com/objectionary/eo/issues/1604 issue

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 16min)


Add JEP for Notebook v7 early draft.

This draft was co-edited by most listed co-authors (save Jeremy who wasn't present) during today's Governance call.
I'm making this PR here first against my own repo so we have a place for early discussion and feedback from some key folks who weren't there today during the gov call while we drafted this...
In particular:

@jtpio - we'd discussed you authoring/co-authoring the JEP, and your input is critical! Since you weren't on the call today and we wanted to avoid delays, we took the opportunity to make some progress, but I'm totally happy supporting you in any capacity. First question is whether you'd still like to be listed as co-author and work on it :) And beyond that, any further input/feedback you may have before we push it as a proper JEP and request a number for it.

@Zsailer @kevin-bates: @afshin was on the call today, but we want to make sure that this doesn't blindside you (or anyone else spending time on the v6 notebook repo!).  There will be plenty of time for further discussion on it while a JEP draft, but we wanted to give you an early heads-up. Ideally we'd like to move this over from here to a proper JEP repo PR next Wednesday Nov 17 2021, after the Notebook call (I'll try to make that but I'm not sure I can). If you have any objections, obviously let us know and we'll pause, or if you have any changes you'd like to suggest before it becomes a formal JEP draft.

Pinging from today's call - @sharanf @afshin @ellisonbg @SylvainCorlay @jasongrout. I've given you all write access to my repo so you can more easily make edits before we make the proper JEP PR next week (assuming there are no objections above from the Notebook folks).

Tagging the two open issues #6210 and #6220 in case anyone watching those would like to pitch in early here. Note that we'll move this over to the proper JEP repo next week, but we'll adopt any early feedback before then here.

BTW @sharanf @afshin @ellisonbg @SylvainCorlay @jasongrout - feel free to edit at will here and push commits as if we were still working on this morning's hackpad! We can make the process a bit more formal next week once it's on the JEP repo as a proper PR, but for now this should make it just as lightweight, while giving us this thread to record any discussion or take external input.

Thanks @fperez, this looks good to me and I'm happy to be listed as co-author and work on it :+1:

I merged the typo/grammatical suggestions by @jtpio.

Under this JEP, there are three “classic” Notebook experiences we’ll support (for 2 years):

RetroLab + Jupyter Server
Notebook 6 JS + NBClassic + Jupyter Server
Notebook 6 JS + Notebook 6 Server

(1) is incompatible with (2) and (3), since the latter two require Notebook <7. Should we list these 3 scenarios and their incompatibilities in this JEP?
Also to confirm, we don’t want to allow users to ever install the Notebook 6 and 7 experiences in the same environment—even via NBClassic—correct?
I’m double checking, since NBClassic will choke if (future) RetroLab is installed. We’ll need to take some care on how we decouple JupyterLab and NBClassic. Today, we would have a circular dependency: Lab -> NBClassic -> Notebook 7 (i.e. RetroLab) -> Lab. If users upgrade to Notebook 7, pip will likely throw a warning about NBClassic incompatibility. I know these are implementation details, but they are subtle areas of friction for users.

Should we list these 3 scenarios and their incompatibilities in this JEP?

I think that this is an implementation detail and we should leave it out of the thread which will probably be very active.

We discussed some of this in the last call - I think we should flag the main point, b/c otherwise it will be an immediate question, so it's clear we're not ignoring it. But other than the main contours being that the expected default path is to have nb7 + JupyterLab be the "documents + ide/workbench experience", with nb v6 not being simultaneously deployed, we can leave some of the details for discussion in the implementation (things like potential alternate routes, pypi/conda names, etc).
I think it's fair to say that, just like you may use python 2 and python 3 but need to separate them into their own environments, you may use both nb v6 and v7, but with some separation. How does this sound? I can update accordingly.

Should we list these 3 scenarios and their incompatibilities in this JEP?

I think that this is an implementation detail and we should leave it out of the thread which will probably be very active.

We discussed some of this in the last call - I think we should flag the main point, b/c otherwise it will be an immediate question, so it's clear we're not ignoring it.

Expanding on the specific way we plan to address this seems distraction from the main point of the JEP which is at a much higher level.
The thread following the JEP will probably attract a lot of people and there is a risk of confusing readers if we start getting into the weeds with respect to the notebook server vs the jupyter server.

there are three “classic” Notebook experiences we’ll support (for 2 years):

Thanks @Zsailer for bringing that up :+1:
We'll probably face this very soon when we start publishing the notebook 7 pre-releases, so it's good to keep that in mind.

Thank you everyone for working on this. Things are busy for me leading up to AWS reInvent (week after thanksgiving) but I have been watching the discussion.
A few things have come up for me that I think we should align on in this context before submitting the main JEP PR.
How do we make decision (IOW, what are the principles) in situations where the notebook and JupyterLab offer the exact same user experience or functionality in different ways
Examples of this, include:

Visual styling of the notebook document (the document itself, not the UI around it), which includes prompts, typography, spacing, color changes, etc.
Differences in interaction design, such as cell/section collapsing and selection, large output collapsing/scrolling, etc.
Menu differences, such as different naming of menu items that do the same thing, different top level menu organization structure.

I think our current language makes statements that provide conflicting answers to these questions and there will be significant tradeoffs to be made. How will we approach these decisions? What will guide how we make the tradeoffs?

any way to last minute update the accessibility statement?

@fperez any way to last minute update the accessibility statement?

The PR is open in [DRAFT] mode so there's time to update it: https://github.com/jupyter/enhancement-proposals/pull/79


Remove SkidrowReloaded

Remove SkidrowReloaded because isn't safe.

It's better to replace to the https://www.gog-games.to.

Sure, I'm nw working on a settings page to enable/disable sites, I included gog and will have skidrow disabled by default. (me and my friends use Skidrow for years, I failed to see why a lot of people think it's unsafe, but I'll respect it and disable it by default but keep it for those who are like me.

u can check the megathread on piratedgames reddit so you can know safe websites

i've been using skidrowreloaded for a  long loooooooooooooooong time never got any virus , so please keep it <3

As long as its there at all I will recommend people to stay away from this at all cost.


Rename version to revision, consistent use

This reverts using master election for patching injection webhook - each revision will take care of its own webhook, since it may use different root CA.
( operator or a 'master' istiod can take care of all webhook patching - but that's not yet in place )

This also consistently uses 'clusterResource' - all configs that are 'singletons', i.e. cluster wide are now generated if the resource is set to true.

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
943fb17ef9ee51e0c37596ff5dc01fa58f360784
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

unit-tests_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

unit-tests_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test unit-tests_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

unit-tests_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test unit-tests_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

unit-tests_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test unit-tests_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
ba6a965e2b3f1d4985cb33d423bdfb62a837b44f
link
/test gencheck_istio

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test gencheck_istio

lint_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test gencheck_istio

lint_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test lint_istio

e2e-dashboard_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test gencheck_istio

lint_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test lint_istio

e2e-dashboard_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-dashboard_istio

integ-conformance-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test gencheck_istio

lint_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test lint_istio

e2e-dashboard_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-dashboard_istio

integ-conformance-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-local-tests_istio

integ-istioio-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test release-test_istio

integ-security-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-local-tests_istio

integ-galley-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-local-tests_istio

unit-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test unit-tests_istio

integ-galley-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-galley-k8s-tests_istio

integ-pilot-local-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-distroless-k8s-tests_istio

e2e-mixer-no_auth_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

lint_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test lint_istio

e2e-dashboard_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test e2e-dashboard_istio

integ-istioio-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-istioio-k8s-tests_istio

gencheck_istio
d5c2094fe3c0b4d33c193655bedc6031205b55a0
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
f92bdff9e13d524bbd58112fda93622fdaf1c177
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
54aa3d8857d79421ff9733f9945903d87d67d771
link
/test integ-security-k8s-tests_istio

gencheck_istio
f92bdff9e13d524bbd58112fda93622fdaf1c177
link
/test gencheck_istio

integ-istioio-k8s-tests_istio
f92bdff9e13d524bbd58112fda93622fdaf1c177
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


The github repo does not persists between pages

Switching pages rolls back to the "helm/helm" repo.
https://github.com/user-attachments/assets/d7e7f91b-57b8-41ae-9992-b3701704912b

@ceccopierangiolieugenio Thanks for reporting this. In part this was intentional so that a user who is switching between tabs will see a prefetched result (helm/helm). If not there will be an empty graph while fetching the same repo already specified in the other tab. This is particularly bad as at the moment on issues and forks there's not a progress bar telling something is going on.
Will definitely try to fix this after adding the progress bars as in the stars feature.


Default local env URLs to http

Codecov Report

Merging #67 (c0d821c) into main (fb62abc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #67   +/-   ##
=========================================
  Coverage     47.13%   47.13%
  Complexity      328      328
=========================================
  Files            42       42
  Lines           925      925
=========================================
  Hits            436      436
  Misses          489      489

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[Question]: Find top-K nodes with a given node

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hi, I build an index and have it persisted in local disk. I'm able to see the embeddings in default_vector_store.json. How do I find top-K nodes with a specific node? I know I can find top-K nodes with a query. However, is it possible to achieve this with a node id instead of a query?

@MikeChu-GitHub You can probably get text with the help of node id and use that text as query in your retriever.

Yeah, but it will require the node content to be embedded. I'm trying to avoid this(and the fee) since this is already available in the index.

You could probably use get_top_k_embeddings function by passing the node embedding as query embedding and embedding ids as nodes ids and accordingly use it.


type errors with any's

Hello 👋
Neat Project! I am looking for something of a lite nosql db for small docs and found this project.
When I went to work with it using typescript, I ran into a few type warnings with the any type.
So I added some types to the src/mod.ts file, would you be interested in reviewing and see it this is worthy of a PR?
If you get a chance check it out. - https://github.com/hyper63/dndb/blob/main/src/mod.ts
It did make my type errors go away, but I had to use ts-ignore, which I know is not great, I will have to look into better solutions to add types to the executor add function, since it may return different results based on the initial argument.
Thanks again for the project, if this change is in the direction you are looking for, let me know and I will submit a PR.
Cheers!

Hi dude 👋  , I was checking and I see you got rid of the ts-ignore, amazing! So when you have all the changes ready, list them in the PR to review and merge them. Thanks for getting involved with DnDB, big changes are coming.

Done, this will be available at 0.3.3 this Monday, thank you mate!


Error stopping entities being created now

Hi- this integration was previously working- however now I am getting:

Logger: homeassistant
Source: custom_components/ge_home/devices/dual_dishwasher.py:22
Integration: GE Home (SmartHQ) (documentation)
First occurred: 30 August 2023 at 20:23:56 (37 occurrences)
Last logged: 16:57:23
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/config/custom_components/ge_home/update_coordinator.py", line 303, in on_device_initial_update
self.maybe_add_appliance_api(appliance)
File "/config/custom_components/ge_home/update_coordinator.py", line 135, in maybe_add_appliance_api
api.build_entities_list()
File "/config/custom_components/ge_home/devices/base.py", line 135, in build_entities_list
e for e in self.get_all_entities()
^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ge_home/devices/dual_dishwasher.py", line 22, in get_all_entities
GeErdSensor(self, ErdCode.DISHWASHER_RINSE_AGENT, erd_override="lower_rinse_agent", icon_override="mdi:shimmer"),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/enum.py", line 783, in getattr
raise AttributeError(name) from None
AttributeError: DISHWASHER_RINSE_AGENT

Hmm, seems like you might be running an earlier version (that code doesn't exist in the latest couple versions).  Please let me know if doing so doesn't fix it and I can reopen.


Consider removing ResultValue from QIR Runtime API

The QIR Runtime API includes a ResultValue enum that includes representation for Zero, One, and Pending results, defined in CoreTypes.hpp. The presence of Pending implies that this enum is somehow related to the way clients should handle asynchronous execution, but it is really just a type for one function, GetResultValue in QirRuntimeAPI_I.hpp. This seems like a function that would be useful for testing but confusing and dangerous to use in any production code. For tests, they should either use the production API surface (if they are a scenario test) or link directly against the implementation and call into the internals of the runtime (if they are unit tests). This kind of test/diagnostic utility shouldn't be part of the public API as it will just lead to confusion and misuse.

@samarsha FYI, this was the type we talked about wanting to remove.

QubitToString likewise is starting to feel like test code that made its way into the API. While it may be common for infrastructure to want a way to easily get the string representation of our opaque types, it isn't needed for any of the QIR functionality so shouldn't be on the runtime and require clients to provide an implementation (even if it's just an empty one).


Look into pwa from app starter kit

Reverse engineer or come up with possible solution where on publish we write the hash values in dynamically for the files being requested.

offline capable out of the box now


[rebranch] Merge branch 'main' into rebranch

Conflicts:
include/swift/SIL/SILBuilder.h

[Benchmarks][stdlib] Adding an extra benchmark for set isDisjoint for disjoint sets of different size
Added -enable-experimental-defined-lifetimes.
[SILGen] Emitted [defined] borrow scopes for lets.
Shouldn't this be labeled as a C++ file?
Disabling arm64e testing in two tests
Fix TOC entry for Linux in GettingStarted
[Serialization] Restrict loading swiftmodule files to the builder's SDK
[Test] Use -parse-stdlib to avoid loading an incompatible stdlib
[APIDigester] Don't check whether the stdlib was built for a different SDK
[SIL] Added lexical flag to alloc_stack.
Refactor IsBindableVisitor's handling of generic nominals.
Have IsBindableVisitor consider conditional conformances.
Run type_lowering_subst_function_type_conditional_conformance.swift test with requirement machine enabled
SIL: Fix for when conditional requirements reference nested type parameters
Remove metadata section functions from the stdlib (#39236)
Add flag -swift-async-framepointer=auto,never,always to  control swift extended frame information emission
Change the logic to exclude extended frame info on all platforms but darwin
Default to SwiftAsyncFramePointerKind::Always for now
[stdlib] Improve set isDisjoint by iterating on smaller set
SIL: Use correct SILFunctionConventions when computing method self type in verifier
[Swift CI] Re-enable sanitizer symbolication tests (#38489)
Avoid using strcasecmp and unroll the comparison to 'snan' instead (#39182)
CMake: disable libdispatch when targeting Wasm/WASI (#39274)
Revert "[Swift CI] Re-enable sanitizer symbolication tests (#38489)" (#39320)

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - b4291916f2f5bb73f13fdaed0a0ee0c0c0ae7cef

Build failed
Swift Test OS X Platform
Git Sha - b4291916f2f5bb73f13fdaed0a0ee0c0c0ae7cef


Remove single quotes and spaces from profile names

There are several issues with the current variant:

spaces are error-prone as everything needs to be quoted (e.g the credentials_process is missing them)
the JS SDK seems to break with single quotes in the profile name (it just doesn't find it at all)

Solution?
I would recommend removing all spaces from the account name when generating profile names.
In my scripts I normally do:
const safeName = acc.Name.replace(/[^A-Za-z0-9-]/g, '-').replace(/-+/g, '-').toLowerCase();

Hm, yeah. For the second bullet, you're saying if the profile name itself has a single quote in it, or if a profile name is quoted in single quotes?
I am a little uncomfortable automatically flattening quote-needing profile names, in case somebody has a situation where two accounts would translate to the same name, but I could add a --safe-profile-names flag?

The profile name was quoted in the config file [profile 'some name with spaces']. This broke the JS SDK.
I see the problem with duplicate safe names but IMHO the current solution just does not work for these accounts. So duplicate profile names or broken ones do not make a difference. But it would be great to fail on duplicates to make the problem transparent.

I think I will implement the "safe account names" by default, and not address duplicates at this time, but allow it to be disabled. Can you open a ticket with the JS SDK that they do not correctly parse the config files?

I am going to implement this as s/[^A-Za-z0-9-._]+/-/g, any objections?

Sounds great. Maybe you want to deduplicate dashes afterwards. I will investigate the JS SDK issue and open a ticket.

Makes sense. s/-*[^A-Za-z0-9-._]+-*/-/g then

The JS SDK problem happens here: https://github.com/aws/aws-sdk-js/blob/a8edd6d37fd42bb1e35907124b3f5328ba7bbc86/lib/shared-ini/ini-loader.js#L10

Seeing that, I'm tempted to say the replace should only be for [\s]+

Oof.
golang doesn't even support anything other than exactly "profile " as a prefix. https://github.com/aws/aws-sdk-go/blob/039c0ff7b11be2b2d94477e47e56d980a9f1e3e6/aws/session/shared_config.go#L276
Java removes "profile" and then trims whitespace. https://github.com/aws/aws-sdk-java-v2/blob/61f6c94f6426fe6395f3f5dd6f1f4c520987ca3a/core/profiles/src/main/java/software/amazon/awssdk/profiles/internal/ProfileFileReader.java#L198
Ruby may not even work with ~/.aws/config profile names, I can't tell in here where it does that https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/lib/aws-sdk-core/shared_config.rb

JS SDK v3 seems to parse it correctly.

Yep, it's now /^profile\s(["'])?([^\1]+)\1$/. Still a problem in other SDKs, though.
https://github.com/aws/aws-sdk-js-v3/blob/314d3b37ac9d0d500e5762705be6188d9bd69625/packages/shared-ini-file-loader/src/index.ts#L57

I've made this changes as CLI version 4.22. Let me know if it's all working for you. I'm still looking for good ways to be able to create a test suite for this, given that it depends so highly on Orgs and AWS SSO APIs, and on so many languages.

I've made this changes as CLI version 4.22. Let me know if it's all working for you. I'm still looking for good ways to be able to create a test suite for this, given that it depends so highly on Orgs and AWS SSO APIs, and on so many languages.

LGTM! multiple dashes are not merged into one but everything is working fine.

LGTM! multiple dashes are not merged into one but everything is working fine.

That's correct; given that it's only spaces that were replaced, I'm not expecting that it's too common that spaces adjoin dashes, and then it's also less likely that it will fold two account names down to the same value.

That's correct; given that it's only spaces that were replaced, I'm not expecting that it's too common that spaces adjoin dashes, and then it's also less likely that it will fold two account names down to the same value.


As an Admin, I want to be warned when I'm making invitations public so that I don't accidentally release them early

This story involves creating the mechanism to make invitation statuses public.
This involves making a button on the top of a show's detailed view "Submission" tab that says "Make Public". When clicked, it shows a confirmation modal explaining that statuses will be made public immediately (provided judging is complete) and this is a permanent action. This modal has "Cancel" and "Make Public" buttons. "Cancel" closes the modal. "Make Public" sends a mutation to the backend setting the show's "finalized" property to "true". The modal closes, and the "Make Public" button becomes disabled (forever).

fixed in 241


Improve wording in README.lmd

ES model —> physics-based models or geoscientific model
inference model —> pre-trained ML model

Done in last release v0.9.2


Implementing Merge Functionality

We have started collecting application metrics inside of a .NET application using Metrics.NET. The application is a server application that sometimes peaks at fairly high volumes, and we collect a lot of metrics (up to 100 metrics while serving a given request, where requests generally last about 50-100 milliseconds). Most of our metrics are timing metrics. While testing the viability of the new Metrics infrastructure, in simulated high volume situations, the locking inside of Metrics.NET was causing interaction between threads, where threads would block on each other, which resulted in a non-trivial drop in throughput (and CPU usage).
While looking for a workaround, we noticed that though the documentation largely recommended using the static global objects for doing things, Metrics.NET was actually nicely written around contexts that didn't necessarily have to interact. So we designed the infrastructure such that each request got it's own private metrics context. Which worked great except at the end, while reporting metrics to the external service, the reporter infrastructure expected the global object. But attaching contexts to the global object become problematic because metrics of the same type for the same thing for parallel requests were being represented separately.
To handle this, we set up the concept of a "Merge," where different MetricsContexts can be merged together logically to appear as though the parallel requests were serial as they are reported. Then, after the requests are processed, the associated contexts are placed onto a merge queue. A separate background thread picks up the contexts off of the queue and merges them into the global one. This is the patch that we used to enable the Merge.
There were some changes in some places to preserve a bit more history as to enable the appropriate replay functionality.
Thank you so much for this great Contribution!

Wow this is a big PR. Thanks for the effort. I will most probably merge it in the next few days after I'll get a change to review it.
Thanks again.

Thank you again for the effort. I will merge this for now as the "context merging" functionality makes sense, but I still want to test and maybe re-think some bits of it. Depending on external factors (like snow forecast and ski condition) It might take one or more weeks to finalize and push a new release. If you need it I could publish a nuget with a pre-release version containing this changes.
I never managed to measure any noticeable impact on highly concurrent applications. I know there is an impact and I'm almost certain there are cases where the impact is visible I just have not hit them yet.  In a production app I have timers measuring operations that execute concurrently and that take 3-5 ms each and nothing changes if I remove the timers. It is true that I don't have even close to ~100 timers in the context of one request. That is a scenario I would really like to test.
Lately in my day job I had to do a lot of low level performance optimizations - and learned a lot doing it - and I was thinking of doing a "performance iteration" over the metrics library. Some of the main goals are:

avoid any memory allocation on metrics collection path ( and minimize allocations on metrics reporting path)
minimize the amount of sharing of instance between threads (see point below)
implement/use hdrhistogram - which seems to be extreamly efficent- as an option or maybe even as default histogram for timers
maintain simple and clear public api for most common cases (this is very important to me)

Related to instance sharing between threads. I was thinking that (at least in theory) it should be possible to collect metrics without any kind of sharing between threads. Conceptually the backing store for the metrics could be thread static and no locking/interlocked operations should be needed to update the internal structures. This should not even be very hard to implement. The problem now becomes aggregating and reporting. A separate thread could go over the structures where the metrics are collected and with minimal interference would collect the values, aggregate them and pass them to the reporting implementations. This is probably a generalization of what you achieved with the context merging. I'll play a bit with a possible implementation and come back with updates.
It would be very useful if you could run a contention profiling session on the code and environment where you noticed the impact of timers. Maybe there is something more fundamental causing the issues.
Thanks,
Iulian
PS: i've noticed you also are a contributor/author to the SignalFx adapter. While I know very little about SignalFx i've noticed the concept of "dimensions". Let me know if you think support for metrics "metadata" could be improved of if you have any concrete ideas on how that could be done.

No rush on the new release. It seems like a lot of where you are going would moot the need for the merge functionality in our use case (or potentially expand on it) - although it still might be useful for other less performance-based and more logical-based requirements. But it seems like your train of thought went right through the limitations we ran into while trying to report via SignalFx with thread-specific contexts. And that is precisely where context merging came from, as you concluded.
I will see what I can do regarding a contention profiling session. Perhaps you could give some advice on tooling. It's always hard doing it the manual way (which is all I did) since it's one of those things where observation affects the outcome.
I think the big reason that SignalFx wrote their own custom Context extension was to differentiate metrics not just by name but by "dimensions." So metadata wouldn't be a bad idea - but the only logical role it would need to play to support the SignalFx use case is to index (and report) the metrics as separate units for each unique combination of metadata.
Thanks for the merge, and thanks again even more for building this. Now if only I can find something as friendly but also as thoroughly implemented in C++, my life will be much more complete :laughing:

For contention profiling the Visual Studio profiler is good enough most of the times. In VS 2013 go to "Analyse" => "Performance Diagnostics" => select "Performance Wizard" & profiling target=> in the wizard select "Resource contention data (concurrency)". You will have to try with different scenarios until the data starts to make sense. CPU profiling can also show possible bottlenecks which are not obvious from code.


Set KIND_VERSION at the job scope

The framework needs it to determine whether to install Gatekeeper.
(This is also a test since I'm not 100% sure whether the matrix context is available at this scope, but the docs seem to indicate it is: https://docs.github.com/en/actions/learn-github-actions/contexts#matrix-context)
ref:

https://github.com/stolostron/governance-policy-framework-addon/pull/238

(One alternative to this PR is to pull the Gatekeeper installation out of the install-resources target in the repo to only have Gatekeeper installed during the repo E2E.)

Looks like it works: 🙂
kind create cluster --name hub --image kindest/node:v1.19.16

https://github.com/stolostron/governance-policy-framework/actions/runs/7400062771/job/20132888232?pr=702#step:8:43


Update transact-sql-syntax-conventions-transact-sql.md

minor

@CharleyPeng1 : Thanks for your contribution! The author, @douglaslMS, has been notified to review your proposed change.

#sign-off


Add New Video Resource Debunking digieconomics fud

Debunking Digiconomist Bitcoin Mining Energy FUD & False Data Reported By Mainstream News Outlets (Ben Gagnon Chief Mining Officer of Bitfarms)
https://youtu.be/lDhCvNFUDvo

Thank you. Probably won't be adding it because the focus is on articles, not videos. The site probably isn't the right format for aggregating videos.

fair enough, the last three slides in this deck focus on the video, but i dont think thats enough https://bitcoinminingcouncil.com/wp-content/uploads/2022/07/2022.07.19-BMC-Presentation-Q2-22-Presentation.pdf

Thanks for understanding.


Uncaught TypeError: Cannot read property 'onDidUpdateState' of undefined

Stack Trace
Uncaught TypeError: Cannot read property 'onDidUpdateState' of undefined
At .atom\packages\copy-with-style\lib\atom_editor.js:58

TypeError: Cannot read property 'onDidUpdateState' of undefined
    at Editor.process_lines (/packages/copy-with-style/lib/atom_editor.js:58:70)
    at HTMLgenerator.generate (/packages/copy-with-style/lib/html_generator.js:58:45)
    at Object.copy (/packages/copy-with-style/lib/main.js:58:68)
    at HTMLElement.copyWithStylePreset1 (/packages/copy-with-style/lib/main.js:19:45)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.31.1/resources/app/src/command-registry.js:384:49)
    at Object.didConfirmSelection (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/command-palette/lib/command-palette-view.js:152:35)
    at SelectListView.confirmSelection (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/atom-select-list/src/select-list-view.js:413:26)
    at HTMLDivElement.core:confirm (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/atom-select-list/src/select-list-view.js:118:20)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.31.1/resources/app/src/command-registry.js:384:49)
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:621:22)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:412:28)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.31.1/resources/app/src/window-event-handler.js:110:40)

Commands
     -0:16.6.0 command-palette:toggle (input.hidden-input)
     -0:13.7.0 core:confirm (input.hidden-input)
     -0:13.7.0 copy-with-style:preset1 (input.hidden-input)

Non-Core Packages
atom-beautify 0.33.4
atom-clock 0.1.16
auto-save-on-idle 1.2.1
copy-with-style 1.1.0
firacode 0.3.0
formatter-clangformat 1.0.1
gpp-compiler 3.0.7

I have this error after I changed Line 21.
this.lines = new Array( this.editor.buffer.getLines().length );
Regards,

Same here, error occurs after applying fix to #6.


HDR Sandcastle crashes when log depth is off

Sandcastle - click the HDR button to disable HDR. Then it crashes with this message:

An error occurred while rendering. Rendering has stopped.
TypeError: Cannot read property 'execute' of undefined
TypeError: Cannot read property 'execute' of undefined
at executeCommand (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:244061:60)
at executeCommands (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:244427:17)
at executeCommandsInViewport (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:244840:9)
at updateAndExecuteCommands (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:244633:13)
at render (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:245284:9)
at tryAndCatchError (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:245304:13)
at Scene.render (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:245375:13)
at CesiumWidget.render (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:259308:25)
at render (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:258679:32)

Duplicate of #8372.


java_simple: update deps and JVM version.

My Maven was too new to support the old JVM, so I updated that, and bumped the dependency versions too.

Thanks!


packages defined in subdirectories

Is it possible to have dependabot manage updates for a sub-directory of a repo?
ie repo looks like
/
/package.json
/subfolder
/subfolder/package.json

Absolutely - if you click "add language" in your dashboard and then "advanced options" then you can select a sub-directory for Dependabot to operate on there. If you use Lerna or Yarn workspaces then it will automatically pick up all of your packages and update them in a single PR (per dependency, rather than multiple PRs for the same dependency).

Awesome. Thanks!


Create Report: All the capital cities in a continent organised by largest population to smallest.

AB#31

As a Customer
I want all the capital cities in a continent organised by largest population to smallest
So that the user can access and view the required data with ease


Why not use the Undetected_chromedriver v2

I was looking on the modules used and noticed that u are using v1.
The v2 looks more promising

this script just uses UC to patch the chrome driver nothing more.. script also uses a monkey patch to patch the chrome driver on each start. I went through both of v1 and v2 codes and tested them.
why do you think it's more promising? what's missing in this current script?

during some testes i did i saw that the v2 passes https://nowsecure.nl

@ardit171  can you confirm that you can pass the site while using a proxy in v2?

in a lot of cases it passed. I used a free proxy list , but most of the cases it failed. I am pretty sure it was because of the really bad proxy. I think it is a good idea to take a look. I was facing some problems installing extensions


ENH: integrate.cubature: support for infinite limits

Reference issue

#20252
Builds on:

#21330
#21473

Originally part of #21632, which is now being split into multiple PRs so it is easier to review.

What does this implement/fix?
This adds support to cubature for approximating integrals with one or more sets of infinite limits:
$$
\int^\infty_{-\infty} \int^\infty_{-\infty} e^{-x^2-y^2} \text dx \text dy
$$
cubature(gaussian, [-np.inf, -np.inf], [np.inf, np.inf])

This is achieved by applying the same variable transformations used in quad_vec to each variable separately. Integrating over intervals of the form $[a, \infty)$, $(-\infty, b]$ is also supported.
This PR also adds supports for specifying problematic points in the integrand's domain through a points argument:
$$
\int^1_{-1} \frac{\sin x}{x} \text dx
$$
cubature(sinc, [-1], [1], points=[[0]])

These additions maintain support for array API, with the exception of JAX, as the implementation of the variable transformations use in-place index assignment.
Acknowledgements
Thanks to @izaid and @ev-br, who have provided lots of help implementing this functionality, and thanks to @lucascolley for help with array API support.

I've just pushed some changes hopefully addressing most of what is above:

Fix the details of the transformations being used in the docstring
Pass xp to _split_subregion, _is_strictly_in_region and _apply_fixed_rule rather than repeatedly calling array_namespace
Respect the dtype of the inputs when returning results
Tighten tolerances on some tests

Also, I realised that _negate_pos in _InfiniteLimitsTransform code was redundant, so I've removed it. Also from above:

Indexing arrays with a list rather than looping over indices: I'm getting errors using array_api_strict for this, and using boolean indexing also isn't working in expressions like x[..., self._semi_inf_pos] where _semi_inf_pos is a boolean array.
Nodes and weights are now float64 by default rather than the default floating dtype of the array library.

using boolean indexing also isn't working in expressions like x[..., self._semi_inf_pos] where _semi_inf_pos is a boolean array.

https://data-apis.org/array-api/draft/API_specification/indexing.html#boolean-array-indexing seems to suggest that, for example, you can replace:
In [13]: x.shape
Out[13]: (2, 2)
...
In [10]: x[..., np.asarray([False, True])]
Out[10]:
array([[2],
       [4]])

with
In [20]: np.expand_dims(x[np.asarray([[False, True], [False, True]])], axis=1)
Out[20]:
array([[2],
       [4]])

I'm not sure how this generalises, but maybe you can do something like that.

@lucascolley I've just run a very informal comparison on my machine, but it seems like using a for loop is comparable in performance to using boolean arrays in NumPy:

x shape: (10, 10, 10)
ix: [2, 4, 6]

Method
Time

[..., ix]
8.32 μs ± 90.5 ns

[..., ix_bool]
9.95 μs ± 51.7 ns

for loop: 8.05 μs
89.7 ns

Similar to what will actually occur with a 5D integrand
x shape: (21**5, 5)
ix: [1, 2]

Method
Time

[..., ix]
40.9 ms ± 1.87 ms

[..., ix_bool]
38.9 ms ± 1.36 ms

for loop
13.3 ms ± 203 μs

The notebook I used to check:
data = np.random.rand(21**5, 5)
ix = [1, 2]
ix_bool = [False, True, True, False, False]

%%timeit
data[..., ix] *= 2
data[..., ix] /= 2

%%timeit
data[..., ix_bool] *= 2
data[..., ix_bool] /= 2

%%timeit
for i in ix:
    data[..., i] *= 2
    data[..., i] /= 2

Is it worth trying the other method or do you think a for loop over the indicies is acceptable?

@ollybritton, just to let you from tomorrow onwards I'll be away travelling for the next four months without much computer access. I might be able to have a look on the mobile app but hopefully someone else will be able to pickup the review for your final pr for arbitrary regions.

Where does this PR stand w.r.t. review comments?

Where does this PR stand w.r.t. review comments?

I think it is just https://github.com/scipy/scipy/pull/21657#discussion_r1790529005 that needs resolving

Congrats @ollybritton ! Do we have a tracking issue for possible follow-ups to the cubature work? If not, could you please open one.

Yeah, I'd suggest closing gh-20252 with a summary of what has been implemented, and opening a new issue with further ideas.


Bad Link

https://go.microsoft.com/fwlink/p/?linkid=62651

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88adfdea-1e88-ef02-d639-4d44b65730fc
Version Independent ID: 65bf0f14-bd82-d72d-be80-49948d0e83ea
Content: Windows Metadata and Internet Services - Windows drivers
Content Source: windows-driver-docs-pr/install/windows-metadata-and-internet-services.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

@wdkbot. This issue is  duplicate, same user already created another request #1883, so close


Research the use of Adaptive Cards for the Bot Framework & FB Messenger

Adaptive cards are not going to work properly the way we want with Facebook since they are down rendered. This means that any buttons which are presented as part of the Adaptive Card will not work.
Source -- https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-howto-add-media-attachments?view=azure-bot-service-4.0&tabs=csharp#send-an-adaptive-card


feat(nuxt): usePreviewMode composable

🔗 Linked issue
resolves https://github.com/nuxt/nuxt/issues/15639
❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Adds usePreviewMode composable that will force useAsyncData and useFetch to make new requests even if payload was there
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Hey @danielroe, my first time here! Would love any feedback 😀

/trigger release

Highlighting notes by @danielroe: https://github.com/nuxt/nuxt/issues/15639#issuecomment-1596891939 (added myself as reviewer to check on nitro side)

I don't think that i fully understand what provider aware means and nitro job in preview mode. Could you provide some more details ?

Thank you for the PR @logotip4ik
What is controls used for?

@Atinux @lihbr
Thank you for the review! I was using the VueUse library as an example and they use controls in some composables to expose more controls from the return value (for example useNow). If you think controls aren't a good fit here, I would happily remove them )

Would it be possible to update the docs? 🙏

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@e3f349f). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21705   +/-   ##
=======================================
  Coverage        ?   58.65%
=======================================
  Files           ?        5
  Lines           ?      861
  Branches        ?       46
=======================================
  Hits            ?      505
  Misses          ?      356
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi, just wanted to knock and ask if this will be supported in ISR as well. We are very much looking forward to this.

Hi @Buffalom, yes it revalidates on the client all useAsyncData and useFetch even if payload was there.
To clarify what would happen, after the initial request to Vercel (for example), it will send the prerendered page with Nuxt's payload in it. After client-side javascript loads, it will check if preview mode is enabled, and if so, Nuxt will revalidate its payloads.

Sounds awesome. Thanks for clarifying. Do you have an idea on when this might be ready to 🚢?

@logotip4ik Maybe you need to re-request review? It's in the 'request changes' now

Double checked, re-request review button is showing only for lihbr review, and Atinux, pi0, Daniel showing as pending

CI failed because of Lychee error on: https://stackoverflow.com/help/minimal-reproducible-example and other two tests failed with not related changes

No worries. I am glad to participate in Nuxt community ❤

@logotip4ik: Your claim has been rewarded! Please complete your Algora onboarding to collect the bounty.


[docker] remove redundant named dockerfiles

While there are two commits in this PR, the intention is to only review the second commit as the first commit is handled in https://github.com/libra/libra/pull/3278
Which begins the process of moving all Dockerfiles to just Dockerfile since they are already namespaced by the directory in which they reside.
Once that PR lands, there is some circle ci work to be done
And then this PR can land to remove the full named files.

@bors-libra delegate+
Chatted with David offline about the landing sequence and commit history. See detail in #3278.

:v: @davidiw can now approve this pull request

:umbrella: The latest upstream changes (presumably e362b41d014e3b1c4d8762bb60dfe70e80c0e9d6) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=sausagee

:pushpin: Commit 0724952 has been approved by sausagee

:hourglass: Testing commit 0724952a2cc98d8b5bd80be21adee81ce3cde602 with merge 255503e94406f49a70f69e8cb4f0c6fa5d03ebf0...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing 255503e94406f49a70f69e8cb4f0c6fa5d03ebf0 to master...