Factory Bot does not work with the latest activesupport release

Description
In combination with the latest activesupport gem (version 7.2.1) just requiring factory_bot resolves in the following error:
.../lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/delegation.rb:47:in `generate': uninitialized constant #<Class:ActiveSupport::Delegation>::Inflector (NameError)

          unless Inflector.safe_constantize(to.name).equal?(to)
                 ^^^^^^^^^
	from .../lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/core_ext/module/delegation.rb:161:in `delegate'
	from .../lib/ruby/gems/3.3.0/gems/factory_bot-6.4.6/lib/factory_bot/definition_hierarchy.rb:3:in `<class:DefinitionHierarchy>'
	from.../lib/ruby/gems/3.3.0/gems/factory_bot-6.4.6/lib/factory_bot/definition_hierarchy.rb:2:in `<module:FactoryBot>'
	from.../lib/ruby/gems/3.3.0/gems/factory_bot-6.4.6/lib/factory_bot/definition_hierarchy.rb:1:in `<top (required)>'
	from <internal: .../lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
	from <internal: ...lib//ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
	from .../lib/ruby/gems/3.3.0/gems/factory_bot-6.4.6/lib/factory_bot.rb:8:in `<top (required)>'
	from <internal: .../lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:141:in `require'
	from <internal: .../lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:141:in `rescue in require'
	from <internal: .../lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:135:in `require'
	from test.rb:1:in `<main>'
<internal: .../ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- factory_bot (LoadError)
	from <internal: .../lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
	from test.rb:1:in `<main>'

Reproduction Steps
Gemfile:
# frozen_string_literal: true

source 'https://rubygems.org'

gem 'factory_bot'

Test file:
# test.rb
require 'factory_bot'

Running: ruby test.rb will result in the above error.
But also a typical setup with requiring factory_bot in the spec_helper will fail.
Expected behavior
factory_bot should be able to load.
Actual behavior
factory_bot crashes.
System configuration
factory_bot version:  6.4.6
rails version:
ruby version: tested with 3.3.1 and 3.3.4

Adding active_support/inflector to the requires in factory_bot.rb solves the problem:
require "set"
require "active_support/core_ext/module/delegation"
require "active_support/core_ext/module/attribute_accessors"
require "active_support/deprecation"
require "active_support/notifications"
require "active_support/inflector"

require "factory_bot/internal"
require "factory_bot/definition_hierarchy"
require "factory_bot/configuration"
require "factory_bot/errors"
...

But it's kind of strange that one has to add a class that is used by activesupport internally.

Can you add to your gemfile this
gem 'activesupport', '< 7.2.1'
Then run:
bundle update activesupport
Add the following to the top of your test.rb or spec_helper.rb file:
require 'active_support/inflector'
require 'factory_bot'

@souadfettah Thank you for the very fast reply ❤ !
I know how to hot-fix the problem in my projects.
Nevertheless, I think that should be fixed in factory_bot.

It looks like this is resolved in #1686 (v6.5.0)

Just verified the problem is solved with v6.5.0.
Thanks to all involved! ❤


Close the gap of acs-engine api and ACS public document

Is this a request for help?:
No
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE

I am noticing the api model on acs-engine is not aligned with what published here. For example, acs-engine requires user pass in a valid MasterProfile.Count field, but the document clearly states that is not required, and be default to 1.
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
All
What happened:
Once we rollout acs-engine with acs rp in the next one or two months, broader people will notice the breaking change even with the same api-version, such as 2016-09-30. The behavior will be different.
What you expected to happen:
User shouldn't notice we swapped the backend service. As we still conform the same api specs.
How to reproduce it (as minimally and precisely as possible):
Check 2016-09-30's validate function on MasterProfile.Count, apparently 0 is not allowed. The document allows 0, or empty.

@amanohar , thx for lighting me into this issue. IMO, I agree, it is P0.
@seanknox, @anhowe , how do you think?

Three approaches are:

Make a breaking change (including the old API versions - though I don't think this is advisable) and make all the previously optional fields mandatory.
Remain backward compatible for old API versions and enforce all fields to be mandatory on the new API model
Make it easy for a customer to standup a cluster by providing a minimal set of inputs aka not make fields like count, vmSize, osType for the new API versions as well by using default values.

I prefer #3  but I understand that it will need some work in ACS Engine since the current validation is not ACS RP public API compatible.

I prefer #3 as well.
So i will need to populate default values for version 2016-03-31, 2016-09-30, and 2017-01-31.
For the latest 2017-07-01, i am not sure do it or not.
How to populate?
As i mentioned, i think Unmarshal is the best place. It it before validation. And we have precedence in manipulate the fields in Unmarshal, like OrchestratorType.

Keeping this open until #951 is delivered.


I used this tool to connect mysql server running in docker, but it failed. As you can see below

Connection error! ER_NOT_SUPPORTED_AUTH_MODE: Client does not support authentication protocol requested by server; consider upgrading MySQL client

+1

I know the reason.
mysql 8 use a new encryption method.   nodejs still not supported.
so


Use message composition to extend contracts

This is an alternative approach to #42 and #91 on how to extend the CW-721 contract.
There are three approaches on how a custom NFT contract can inherit/extend the base cw721 contract:

42: the base contract to provide a "wildcard" extension
91: the base contract to provide a macro for extending the message enum
this PR: the child contract to compose message types

Comparison
In this section, we use an example to compare the three approaches.
Terminology: Let's say the contract being extended is the "parent" contract, while the contract extending it is the "child" contract.
For this example, we use cw721-base as the parent, and cw2981-royalties as the child. cw2981 wants to extend cw721-base's query message by adding a custom method, royalty_info.
#42
cw721-base/src/msg.rs
pub enum QueryMsg<Q> {
    ContractInfo { .. },
    NumTokens { .. },
    // ...

    // the wildcard extension
    Extension { query: Q },
}

cw2981-royalties/src/msg.rs
// the child defines its custom query methods as an enum...
pub enum CustomQuery {
    RoyaltyInfo {
        token_id: String,
        sale_price: Uint128,
    },
}

// ...and plug it into the parent enum as a generic
pub type QueryMsg = cw721_base::msg::QueryMsg<CustomQuery>;

cw2981-royalties/src/contract.rs
pub fn Query(deps: Deps, env: Env, msg: QueryMsg) -> StdResult<Binary> {
    match msg {
        // if it is the extension, dispatch to the appropriate handler function
        QueryMsg::Extension { custom_query } => {
            match custom_query {
                CustomQuery::RoyaltyInfo { token_id, sale_price } => {
                    query_royalty_info(deps, token_id, sale_price)
                }
            }
        },

        // otherwise, dispatch it to the parent
        _ => {
            let parent = Cw721Contract::<Extension, CustomMsg, CustomQuery>::default();
            parent.query(deps, env, msg)
        },
    }
}

#90
cw721-base/src/msg.rs
// the parent defines a macro to "autofill" its query methods
#[proc_macro_attribute]
pub fn cw721_base_query(metadata: TokenStream, input: TokenStream) -> TokenStream {
    // ...
}

// the parent's message type
#[cw721_base_query]
#[cw_serde]
pub enum QueryMsg {}

cw2981-royalties/src/msg.rs
// the child applies the macro, and appends its custom methods below
#[cw721_base_query]
#[cw_serde]
pub enum QueryMsg {
    RoyaltyInfo {
        token_id: String,
        sale_price: Uint128,
    },
}

// the child also needs to implement a function to cast the custom message
// to the parent's one
impl TryFrom<QueryMsg> for cw721_base::QueryMsg {
    // ...
}

cw2981-royalties/src/contract.rs
pub fn Query(deps: Deps, env: Env, msg: QueryMsg) -> StdResult<Binary> {
    match msg {
        // if it is the custom variant, dispatch to the appropriate handler function
        QueryMsg::RoyaltyInfo { token_id, sale_price } => {
            query_royalty_info(deps, token_id, sale_price)
        },

        // otherwise, try cast the message to the parent type, and dispatch to parent
        _ => {
            let parent = Cw721Contract::<Extension>::default();
            parent.query(deps, env, msg.try_into()?)
        },
    }
}

This PR
The parent does not provide any special arrangement for the child.
cw721-base/src/msg.rs
// the child defines its enum "nesting" the parent one
// note the use of serde "untagged" option
#[serde(untagged)]
pub enum QueryMsg {
    Parent(cw721_base::msg::QueryMsg),

    RoyaltyInfo {
        token_id: String,
        sale_price: Uint128,
    },
}

cw2981-royalties/src/contract.rs
pub fn Query(deps: Deps, env: Env, msg: QueryMsg) -> StdResult<Binary> {
    match msg {
        QueryMsg::Parent(msg) => {
            let parent = Cw721Contract::<Extension>::default();
            parent.query(deps, env, msg)
        },
        QueryMsg::RoyaltyInfo { token_id, sale_price } => {
            query_royalty_info(deps, token_id, sale_price)
        },
    }
}

Overall, I feel this PR is the best solution

It seems for some reason, using #[serde(untagged)] (the approach suggested by this PR) introduces float operators into the wasm build. ??

@larry0x I had this issue a while back. It's because serde includes a debug/log function that handles an f64 value in one of the match arms. You can get around it by writing a custom serializer.

@larry0x I had this issue a while back. It's because serde includes a debug/log function that handles an f64 value in one of the match arms. You can get around it by writing a custom serializer.

Yes this is a known issue: https://github.com/CosmWasm/serde-json-wasm/issues/43


Remove config_var_length from our applications

Requires https://github.com/wellcometrust/terraform-modules/pull/77

Yep, already done. Just need to wait for Travis to mint a new version.

🎉


Update install_ava_node.sh

make the PATH export as explained at https://golang.org/doc/install

thank you to have merged it ;)


Add a translation schema validate to CI builds

User Story
As a report stream developer, I would like translation schema validation to happen for a PR that changes a schema in the source code
Description/Use Case
This will be a new step uses the schemas in the PR along with the schemas in the staging container and run the validateSchemas command.  This will be required to pass in order to merge
Risks/Impacts/Considerations
Dev Notes
This could be added to an existing required action or introduced as a new one
Acceptance Criteria

[ ] Changes to schemas residing in source are validated against staging before a PR can be merged

Hey team! Please add your planning poker estimate with Zenhub @arnejduranovic @brick-green @jack-h-wang @JessicaWNava @JFU-NAVA-PBC @jimmyfagan @luis-pabon-tf @mkalish @thetaurean


GEODE-9369: Command to copy region entries from a WAN site to another

This pull request contains the commit of the already approved pull request with the command to copy region entries from a WAN site to another plus two commits in order to fix failures of some distributed tests under windows.

For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

I am trying to reproduce the windows error. Please do not merge yet.


fix desktop input

We already have a container around input. Now we let it expand and only apply the maxWidth to the actual input area.


Fixes and Rev4 updates for session lock controls

These are all the changes we have made in our repo at https://github.com/djhaynes/inspec-profile-disa_stig-el7 relating to session lock controls. This includes updates of these controls to RHEL7 STIG Rev4, as well as various fixes.

@trevor-vaughan Ok I've done what you asked and revised all of the controls to use gsettings rather than hard-coded file paths.


chat-with-rendezvous: The provided host does loose addresses

After the host with its []ma.Multiaddr addresses were kadDht.Provide provided and kadDht.FindProviders found again by the same host the addresses were lost

Can you elaborate?
Do you mean the same host calling Provide followed by FindProviders can't see it's own addresses in the list?

Hi @upperwal,
I have elaborated it. Here is what I found:
host.Peerstore().SetAddrs(host.ID(), host.Addrs(), peerstore.ConnectedAddrTTL) is needed to set the addresses in the peerstore.
Cheers, Stefan


fix: Add compatibility with AGP 8

Hi @Laennart ,
Thank you so much for your valuable contribution! It's truly heartening to see such engagement :)
While our project is indeed open-source, current company guidelines restrict us from accepting external collaborations directly. However, to ensure your valuable input is not lost, I will re-author your Pull Request (PR) and open it immediately with some small modifications. This way, it can be included in our upcoming version release.
For future contributions, would you kindly submit a support ticket through our customer support portal? This process helps us streamline contributions in line with our project guidelines.
Once again, thank you for your understanding and continued support!


Update style video

This is just the link that was missing from the demo of how to update the styles in a chart

Thanks, could you lint the code?

Thanks!


Offer page logic

As we found it's possible to offer the account clicking one button, the workflow under it is the following:

make sure the account's balance >= 0.5 NEAR, otherwise disable the button
(here user click onto "offer the account" button)
before adding random full access key, save current list of keys and inFavor account id in local storage
(run the procedure of adding random full access key)
check if we currently logged in after adding full access key
run offer
delete all stored keys
delete random full access key
log out the user
show label that we successfully added the account to the market

Implemented


Default_value +  confirm='menu' error

After using this comand:
:lua require('searchbox').replace({default_value = vim.fn.expand('<cword>'), confirm = 'menu'})<CR>
On text  (cursor is over  'numpy' :
if True:
    numpy as np
numpy as np
numpy as np

Popup menu is displayed, confirm menu is displayed ok too, but then accepting first change with   gives error:

It seems error is happening only when first numpy is indented once, and then next occurance of numpy is not indented.
Btw. small feature request - can replace happen from place where cursor is located, and not from to of file?  Great plugin btw.

Should be fix now in a7f20cd.

Thanks @VonHeikemen  the issue is fixed .  Any chances, for searchbox.nvim to start replacing words from current cursor position, rather than from start of file?

the issue is fixed

Awesome.

Any chances, for searchbox.nvim to start replacing words from current cursor position, rather than from start of file?

It is possible, just annoying to do. Open a new issue, so I can remember to look at it in another moment.


Conditional Generation

How to Use the trained model for conditional generation???

The code has been updated. I hope it is easier to reproduce now.


Add support for tvOS

Added RNCNetInfo-tvOS target so the library now works also on tvOS like before.

Hi there 👋
Thanks for adding this back in. This is something I completely missed. Just out of interest, do you have a tvOS app in production currently?
To be able to test this properly, can you please add a tvOS target to the example project?

We are currently developing a TV app for Mobile and TV devices with React Native. And a lot of libraries forget to include the target. So I’m trying to fix them all 😀
It’s working in our app, but I’ll add the target to the example project.

We are currently developing a TV app for Mobile and TV devices with React Native. And a lot of libraries forget to include the target. So I’m trying to fix them all 😀
It’s working in our app, but I’ll add the target to the example project.

That would be great! It's just useful to have an easy way for us to test it so we don't break anything in the future.
I'm sure the community would love to hear your experience with React Native on tvOS when you're done 😄

I added the Target in the Example project. It compiles and looks like everything is working.

I don't have an actual Apple TV to test with, but on the simulator that works great!
Thanks again for the contribution and good luck with the app development!


Create /mnt/plumb in case it does not exist

Plumber fails, and rio does not start if it does not exist.
Signed-off-by: golubovsky<EMAIL_ADDRESS>

Don't we have that cool file server that creates whatever directory you
want under /mnt?
On Sep 16, 2016 20:44, "Robot Harvey"<EMAIL_ADDRESS>wrote:

Please review this @0intro https://github.com/0intro, @floren
https://github.com/floren and @rminnich https://github.com/rminnich
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Harvey-OS/harvey/pull/303#issuecomment-247747013, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFuc-E8tGsXuQo2sAM6e6ap0o9li4nwks5qq2IkgaJpZM4J_fxs
.

Yeah, I think we should modify the script to use slashn on /mnt

I thought on this, but if it never was in profile, I guessed it shouldn't be.
If someone tweak slashn or whatever for this, this PR and mine will be abandoned. But think that for now Harvey doesn't boot without any of two. So think quickly.

/mnt is where things go that are more system level. /n is other stuff and where slashn server runs.
The problem with this change to profile is you are assuming the nodes you cpu into will let you do the mkdir, i.e. that /mnt is writeable to you. That's not really a good assumption. In fact it's almost certainly wrong because /mnt is more of a system level thing like /usr or /lib.
You can run a server that lets you write mkdir /mnt/plumb but that's just more overhead to create a directory that should already exist.
Let's just go ahead and make sure /mnt/plumb is in our repo by adding it.
-2

Fixed in #301

OK, whatever is the right solution, mine was just a quick fix.
Thanks

And always welcome. Thanks to you.


Add a cheet sheat for PyTorch

What does this PR do?
Add resource(s)
For resources
Description
Add a Cheet sheat for Pytorch provided by Datacamp
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Please accept my P.R  or add  hacktoberfest-accepted label.


Allow Certificate secretTemplates to set the cert-manager.io/allow-d…

Allow Certificate secretTemplates to set the cert-manager.io/allow-direct-injection annotation
Signed-off-by: Brian Dunnigan<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4621
Special notes for your reviewer:
Release note:

Allow Certificate secretTemplates to set the cert-manager.io/allow-direct-injection annotation

Added a comment here, as I think this is not required: https://github.com/jetstack/cert-manager/issues/4621#issuecomment-979833968

I agree that this is probably not required and I added some further comments to https://github.com/jetstack/cert-manager/issues/4621#issuecomment-990907872
I think the sentiment of the cert-manager maintainers is that we want to try and avoid adding special cases like this and that perhaps there are better ways to solve this problem.
@bdun1013 I'll close this PR, but please re-open or discuss further in the original issue.


WIP: try using larger runners as CNCF org provisioned (#2135)

The armadaproject organization has runners provisioned (apparently as part of CNCF enterprise membership):

ubuntu-latest-4-cores
ubuntu-latest-8-cores
ubuntu-latest-16-cores
windows-latest-8-cores

This PR sets runs-on to ubuntu-latest-16-cores for the Go code compilation, to see if/how-well it runs.

Codecov Report
Base: 46.53% // Head: 46.53% // No change to project coverage :thumbsup:

Coverage data is based on head (0a341a9) compared to base (2a9b6e8).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2175   +/-   ##
=======================================
  Coverage   46.53%   46.53%
=======================================
  Files         223      223
  Lines       33081    33081
=======================================
  Hits        15394    15394
  Misses      16450    16450
  Partials     1237     1237

Flag
Coverage Δ

armada-server
46.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


disabled tabs again

What Angular MDC version are you using?
0.38+
App code dependent on the ability to disable tabs that was graciously provided in #147 now breaks in 0.38+ as the disabled attribute is not available on the new tab bar implementation. Can this feature please be restored somehow?

Can do. Thanks for reminding me.

PR incoming

Will be releasing v0.40.1 today.

Just fyi, I may need to submit another PR for disabling navigation via keyboard.

Thank you so much.


[Bug] Typography component always shows as bold text

Describe the bug
Passing "bold" prop to Typography component doesn't affect the text and the default is bold (700)
To Reproduce
Steps to reproduce the behavior:

Go to any component that uses Typography
Make sure that it doesn't receive "bold" as prop
see that the text is still bold (font-wheight: 700)

Expected behavior
The text shouldn't be bold
The issue is that the useBold function receives an object holding the bold prop and is checking that object is always true

fixed via #775


🐛 Use direct endpoint instead of search to find repository URL from npm database

What kind of change does this PR introduce?
This PR is a bug fix. When finding the github repository URL for an npm package, the application uses the GET·/{package}/latest  endpoint instead of the GET·/{package}
What is the current behavior?
The application finds the github URL of an npm package by using the search functionality.  If a user incorrectly enters a github URL instead of an npm package name, the user will not receive feedback about their mistake and the application will run the checks on the first package that the search finds.
What is the new behavior (if this is a feature change)?**
When a user enters a github URL instead of an npm package name, an error message is displayed saying that the npm package could not be found.

[x] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes
Fixes #3166.
Special notes for your reviewer
Does this PR introduce a user-facing change?
NO

NONE

Thanks for the contribution! Could you add some unit tests that expect an error when a GitHub/NPM URL is passed to the --npm flag instead of a project name? Even better to test the projects from #2144 and #3166, which silently score the wrong projects because of the inexact name match.

I added unit tests for #3166 and #2441 with mock http responses

Still getting linter issues, try make fix-linter.
For package_manager_test.go, can we make the diff smaller by only returning the parts of the HTTP/JSON response in args.result that we'll actually end up parsing?

I don't think fix-linter is working correctly on my machine. It just adds line breaks between every single line. Any reason this may happen?

Hm, that's strange that --fix has that behavior, I think you'll need to fix those issues manually then. It looks like some lints were fixed but there are still some issues. Make sure that make all passes, because our CI requires that for merge.

I don't think fix-linter is working correctly on my machine. It just adds line breaks between every single line. Any reason this may happen?

Can you share a little bit about your environment? You're running the linter with make check-linter? The double-space the whole file approach should be reverted.

I think the issue was stemming from the fact I was working with windows. I have switched to Linux and I believe it is working now.


Segmentation fault when taking a heap snapshot on OSX

Project it occurs on:
git clone https://github.com/bevry/taskgroup.git taskgroup
cd taskgroup
git checkout es6
npm install
./node_modules/.bin/cake compile
node es5/test/profile.js

Output ends with:
[1]    7876 segmentation fault  node es5/test/profile.js

System details:
$ iojs --version
v1.6.1
$ npm --version
2.7.1
$ iojs -p process.versions.v8
<IP_ADDRESS>

OSX Version: 10.10.2
Machine: iMac (27-inch, Mid 2011)
Also occurs on Node 0.12.0

Seems https://github.com/iojs/io.js/issues/1058 was the culprit as this issue is cured in io.js 1.6.3


ConfigProvider.fromEnv not compatible with vite.

https://github.com/Effect-TS/effect/blob/56ddb9c7d6a2d655038fcf6696e74466c9dd8440/src/internal/configProvider.ts#L107
https://vitejs.dev/guide/env-and-mode.html
Vite stores env variables under import.meta.env, not under process.env. Can we update this line to test for import.meta.env as well?

isn't import.meta available only in esm?

Maybe.. The mdn docs don't mention esm specifically but I'm honestly not sure.

Maybe.. The mdn docs don't mention esm specifically but I'm honestly not sure.

Yup it's esm only:
michaelarnaldi@Michaels-MacBook-Pro effect % node
Welcome to Node.js v18.16.1.
Type ".help" for more information.
> import.meta;
import.meta;
       ^^^^

Uncaught SyntaxError: Cannot use 'import.meta' outside a module
>

Only way I can think of working around this is to have a sub-module, something like effect/env that internally contains a conditional package.json and two files:

index.cjs
index.mjs
where each file exports the env object, either found it via process or import.meta or better a merge of the two

cc @tim-smart for ideas

@jessekelly881 would you mind giving a try to #1567 and see if it fixes the issue

Ah it would actually not work because vite needs the statically know the keys https://vitejs.dev/guide/env-and-mode.html#production-replacement

Actually given https://vitejs.dev/guide/env-and-mode.html#production-replacement there is no way to make it compatible, the only way would be using the Map provider and manually listing import.meta.env.KEY entries

Actually given https://vitejs.dev/guide/env-and-mode.html#production-replacement there is no way to make it compatible, the only way would be using the Map provider and manually listing import.meta.env.KEY entries

A user could leverage the envPrefix option (https://vitejs.dev/config/shared-options.html#envprefix) to automatically copy all .env values with a certain prefix (e.g. VITE_ by default).

No worries. Thanks for taking a look @mikearnaldi @fubhy :)


FancyZones grids always on top

Environment
Windows build number: 10.0.18363.900
PowerToys version: 0.19.1
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Whenever I try to use FancyZones, the overlay looks kinda weird. The numbers are duplicated and in different spots, which results in FancyZones looking like this.
These are my FancyZones settings:  & . I do not have any custom layouts and encountered the issue when using the default grid style. Other styles also seem to give the issue, but the grid style is then "on top" of the chosen style, as seen here.
By the way, it seems to only be a visual issue, as it will always apply the correct zone, e.g. when using rows and grid style is on top, the window snaps to the row format, not to the grid format.

@larssieboy18
it looks like the same problem as in https://github.com/microsoft/PowerToys/issues/4846

Looks like it, although I am not sure that it happened after my PC coming out of sleep mode. I do, just like the other issue, have multiple screens

@larssieboy18
let's close this one as duplicate of #4846 for now, we can reopen it if it will turn out to be something else.
Thanks.


Set limit for Month and Year to show.

Hi, this is an awesome lib.
But now I don't want infinitive scrolling when choosing year and month, I need to limit the showed years in yearTable between current year to next 100 year. How can I do that? And similar to the calendarTable. I just want to begin from the current month.
Thank you so much

Any solution to this?


fixing merge failure and adding CircleCI badge

Updated URL for assignment

@amfleming Hi Adam, this change did not go through for some reason, despite being approved. I reopened it.

@amfleming  I updated to the new README, and I see there are no issues and the only change I have is to my entry in the README file


Migration guide from v3 to v6?

We have an older website which got stuck on react-router v3 because of the drastic changes that came in v4. Main issue was that all the routing in this website was based around single routes files with nested routes, and a rewrite of that was just too much and impossible to get prioritized. Maybe others are in the same situation?
Either way, I see that in v6, this feature is coming back?

Another important reason for using the element prop in v6 is that  is reserved for nesting routes. This is one of people's favorite features from v3 and @reach/router, and we're bringing it back in v6.

For the v6 release, would it be possible for someone knowledgeable to write a migration guide for upgrading from v3 to v6? Not necessarily super detailed, but just some sort of guidance with coming from v3 in mind, particularly surrounding how to migrate v3 nested routes to v6 nested routes?
🙏 #hopeful-we-can-finally-upgrade-and-get-those-tasty-hooks-in-this-project-as-well

If someone wants to write that guide and submit it as a PR, we can definitely include it. But it's not something we're going to write ourselves, given the large number of changes between the two and the age since we've worked on anything v3-related.

Fair enough. 👍


[Enhancement] Get user details of the logged in user

First of all, this package is so LIT. Kudos to the dev.
 User user = context.getSignedInUser();
 print(user);

The above code gives me just a User(user: FirebaseUser(Instance of 'PlatformUser')), But Is it possible to get individual data about the user, like display name or email?
 User user = context.getSignedInUser();
 print(user.email);

should give me, email id of the logged-in user.

Thanks for the kudos 👍
Sorry this is a documentation issue. After all of the features are added I'll put in more effort to improve the docs. The package uses Freezed for unions. So depending on the status of the user you'll get a different state: empty, initializing, or success. If the user is signed in you'll get the FirebaseUser.
User user = context.getSignedInUser();
user.map(
      (value) => print(value.user.email),
      empty: (_) {},
      initializing: (_) {},
    );

The value.user is the FirebaseUser object. The FlutterFire plugins have recently gone through a massive overall. So expect some changes to this package - especially naming, as I believe the FlutterFire plugins now use User and not FirebaseUser. I'm open to suggestions to make the process easier, or more intuitive.

Documentation updated.


Fixed smartcard filter for empty arguments.

This fixed the issue, as noted on the ML:
[FreeRDP-devel] Smartcard support in latest git is lost for Kobil token
Thank you, guys.


Jesse: Watch 4gspycamera.com

Jesse requests the watch of the watch_keyword 4gspycamera\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

4gspycamera\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Make the search operator query distinct.

This fixes a weird issue with the search operator.
Before this, a query like: http://localhost:3000/api/v3/public/cards?filter[search]=in_restriction%3Atrue&page[limit]=250&page[offset]=0
would return paging links along the default 100 items lines, but the data would only have a handful of records.  It was pulling back the same card_id from the unified_restrictions join multiple times (1 per restriction a card is on), applying paging, then deduping before the results were sent.
This makes things behave as expected.
Note: The rails query thing does "find all the ids" then "select * from the model's table where id = ?" for each one.  :/. The query above takes almost 400ms on my local machine, but I think with a materialized view we can get that down < 100ms pretty easily.

Look up n+1 queries about rails, there are a ton of articles about getting the rails query builder to behave correctly.

https://charliereese.ca/rails-performance-3-tips-for-removing-n-1-queries/ is right

This particular change was a correctness change, not a speed change.
I'll dig in on those links as well as keep plugging away at a materialized view for cards and printings to do some comparisons. Thanks for the leads!

Yeah I just mean to provide information for you. Don't check discord enough to post it there.

hehe, it's much appreciated, Noah!


Update pod tolerations doc to include full pod example

fixes #16157

Updated per suggestions. I removed the node selector because it was from a previous example pod.

/approve
/lgtm


rework of assignment

fixes: #1429, #1345

Nice work. I made same remarks.

Two remarks. You can immendiately rebase (and add a nice and pretty ;-) commit message that also shows that a database reset is required.)


Union types aren't always narrowed properly after predicate functions

TypeScript Version:  3.8.0-dev.20191122

Search Terms:
union types, narrowing, guarding
Code
// Imagine redux here. Redux reducers get actions from various places. They have a vague type
type Action = {
  type: any
}

// Our app has 2 actions
type ActionA = {
  type: 'a'
  payload: () => void
}

type ActionB = {
  type: 'b'
  payload: string
}

// This type is a union of all of em. They have distinct types, which can
// be used to discriminate them
type AllOurActions = ActionA | ActionB

// This function takes any action, and determines if it happens to
// be one of ours. If so, it narrows the action's type
declare function isActionOneOfOurs(action: Action): action is AllOurActions

// This is how you could narrow our action type to a specific action type
declare const wereSureAlready: AllOurActions
// This guard usually works
if (wereSureAlready.type === 'a') {
  // Since the `type` property is 'a', we know the payload is a function
  // since 'b' actions have a string payload
  wereSureAlready.payload()
}

// We got this action in our reducer.
// It could be from anywhere(e.g.redux dev tools or a third party lib)
declare const someGivenAction: Action

// If this is true, we know the action is one of ours
if (isActionOneOfOurs(someGivenAction)) {
  // can be narrowed by switch
  switch (someGivenAction.type) {
    case 'a': someGivenAction.payload()
  }
  // can't with other stuff?
  if (someGivenAction.type === 'a') {
    // Why doesn't this work if someGivenAction was narrow by a predicate
    // function.
    someGivenAction.payload()
  }

  // it works if you rebind it
  const worksIfYouRebindIt = someGivenAction
  if (worksIfYouRebindIt.type === 'a') {
    // Why doesn't this work if someGivenAction was narrow by a predicate
    // function. it works if you cast it
    worksIfYouRebindIt.payload()
  }
}

Expected behavior:
Action type properly narrowed by the predicate function and an if statement
Actual behavior:
Action type not narrowed unless you rebind it prior to narrowing or a switch statement is used
Playground Link:
http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=58&pc=2#code/PTAEEkFsEMHMEsB2BTUAnZATArgD1ABbIYB0oASlnulQMbEDOosyALqNLa-APaJMAzND0igAbtDS9sTAA4AbTsgZkAKkQCehaGNTRxcbKlYbZyAFAmzoAIJdeiUAF5QAb3OhQV5AC4OiDXMAX3NzEFAAeWw0DllZbSYAJg57PgZLU1Q7bj4bZzcPL0y-AHJoEsLZaA15HmhMPwAKAEpnAD5xHnhMYNDvW1TEACF8909vUoAjCs8qmrqG0AZWKURYXrCwdXgmfp2OUGxEB1AeAQ55eVPz5Eg1TW1dUEwd7kQuIrMGABpQAHcCPBaARQLRoI5NqBJqgZFgvDxnjtaFJIEhoKxjERIBlrDZLlE0NkHEwXETcqAAD4DHLDULhbaCI6DLzQADWyn8Wk4NN+4MwzzYxFRKCY8HO8HYBGgcWQ-HhkOhpxQ11O0RUEHODB4vwloEQkmEf12RBSNJKu0y5kwyFoigwoAETJpoB2ZMQERQEQEBIYjW5Dj8buafn9fBdTDx8gJbvSkIZ4cIPD+oA0PGwoLT8n5+rQhtVMVDjn6rAR+gYZloYqBppO3itNrtqFoaXYf2IyAAytFkHiMPUNIH8dEY3HAUxYNhJPyZJPLlo-jw0Kz0mLQI02xguxhe8h+yR+k5D6AyiVWmNQOEO0h6F4TQADbx30CyYRmNAmBMn35t0CsxBJ29UDmWp6gTfRHXeGlCnCBhr1QEpphrNJHj0JYViQWBn2qECek8DdO27Hc92AhYWg2cIAHVUFgHh2FYMckMcJB8xoHB6DQEhIXAdhm2wLMoVQIQRE5AF20aZASFgEgMBwfBrTEeEeHkJhFwOej4DQfkqnfLR5HgSZmnrW1JCbFslhEZAAHF4F0RA3UDQY6TAcBznU0VdjQIxv1QP8APovRmX2PhUDOfMV3ORpXUGD1kC9H1Gi1SArJs2UgzPaCwDBRxFRzQ04UmLQGD+CVgUKIqSpBBKLOs2y3X3TJ0s8TwwQYeDyj8RLktqwYSBI+oyM8EJPHCLKSlbCUQVoogYmWbABAEAB+QpVyqpKatSnqDyPE9GqayiCC0TAeGURAxtvfYFyXF1NWqlK7OZP5oCYXKAIKg4XywIF0QsJqLzACCetAQpPE69b7ppXrsNIwzBtCYawF1S7l2ulM0xoSYkH5CVCmbfhW0XZcXIATTTSgMcQTBuPyUG7rdZaIqRhhidJ5Bycp1h6usQ8XB2gpfv2w7joYU66IYpGUZp7rnUe56DVerlnxkr6MWBv6HSdBwyERgnRXOVN0xa9hsd+xnmewMnMe4yH5n6mHQBCIIgA
Related Issues:
Couldn't find anything directly related

Duplicate of https://github.com/microsoft/TypeScript/issues/13962

This shows that the binding can be narrowed despite not being a union, as long as its narrowed with a switch statement: http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=27&pc=2#code/C4TwDgpgBAggxsAlgewHZQLxQN4CgpSiQBcUAhqiLgL665HTxJoyY76HgSkDkZPHMGRAAbZGQAmpABQBKTAD4oAN2SIJNOg1gIUqAEJs8BBrwBGAgkNHipUAM7AATolQBzTfS6wRIgPIArk5MevZsISxQAD46zAZ0EhBwImRO0ABmAai6aFCI9hGofqgQfumBTvbSZDmopIWypDVxeWEwvhWF9glJKWlQcGiODsgAthAA4ojKEKiF9bV0APRLUACS6YQAFvmthE4BEAA0UADu0ADWqMin29DNento0MibyEHdiJvS+YXFpeUPtJ7GNJtNZg15MYoCsBhQoGZoKhUk4bhAJAiQA5TohgHAthx7Di8VsoMDQVMZnNagA6BhQjgEOBkezQPg8Ugg8aUiG06xiSRyDi0ahAA
type Action = {
  type: any
}

type ActionA = {
  type: 'a'
  payload: () => void
}

type ActionB = {
  type: 'b'
  payload: string
}

type AllOurActions = ActionA | ActionB

declare function isActionOneOfOurs(action: Action): action is AllOurActions

declare const someGivenAction: Action

// If this is true, we know the action is one of ours
if (isActionOneOfOurs(someGivenAction)) {
  // can be narrowed by switch
  switch (someGivenAction.type) {
    case 'a': someGivenAction.payload()
  }
}

Duplicate  #30557

Narrowing by discriminant only applies when the declared type of the identifier is a union type

What makes the switch statement different that narrowing works for that but not for if?  I couldn't find anything in the linked issues that explained this discrepancy.


Repo website links to a mostly broken page

The repo website link https://microsoft.com/PowerShell for some reason redirects to https://docs.microsoft.com/en-us/previous-versions/msdn10/mt173057(v=msdn.10). That seems to be some kind of horrible, outdated, badly formatted page with no working links:

Can this be fixed?

/cc @SteveL-MSFT @sdwheeler not sure which end this would best be fixed on, but y'all would have a better idea than me, I'm sure. 🙂

Fixed.

Fixed.


Objects already exists in Lab 8

In the "Rate Limiting" lab, I was unable to "create" the new object.
[user5:~] $ oc create -n user5-tutorial -f /opt/app-root/workshop/content/src/istiofiles/destination-rule.yml
Error from server (AlreadyExists): error when creating "/opt/app-root/workshop/content/src/istiofiles/destination-rule.yml": destinationrules.networking.istio.io "recommendation" already exists
[user5:~] $ oc replace -n user5-tutorial -f /opt/app-root/workshop/content/src/istiofiles/destination-rule.yml
destinationrule.networking.istio.io/recommendation replaced

Might be related to #11

should be fixed by #15


Support parsing alter table  to add an foreign key

Support parsing alter table to add a foreign key
Modify ast.ForeignKey to implement ast.Node interface.

I wonder if ALTER TABLE ... DROP FOREIGN KEY or additional foreign key related syntax are supported in today's Spanner SQL. If they are supported, here is a good place to implement them.

Spanner does support ALTER TABLE DROP CONSTRAINT. I'll send another PR for that.
https://cloud.google.com/spanner/docs/data-definition-language#alter_table

@tyamagu2 Okay. Thank you so much!


Normal form for associative, unital operations

A standard trick in computer algebra, including in the current GAT implementation in Catlab (#57), is to normalize binary expressions for associative operations by using trees with arbitrary branching. Gatlab should implement this too.
Note that this transformation is not handled by generic rewriting, but at the level of the data structures themselves.

This is split into #88 and #41; one issue for GATExprs and one issue for AlgTerms.


Support NLP workloads

This includes:

[ ] Show an example now how to pass text and padding (it should work with the code base as it is now)
[ ] Integrate slow pytorch based HuggingFace Tokenizers
[ ] Integrate fast Rust based HuggingFace Tokenizers

I definitely don't have the bandwidth to do that now but I'm keeping this issue if someone wants to work on it.

@GuillaumeLeclerc were you thinking something like this for the first task? https://github.com/libffcv/ffcv/issues/57#issuecomment-1016529098 If so I can clean it up and put it in a more prominent location (could maybe make a page about it in the docs?).

I don't think this example shows how to get the actual length and pass it to the model right ?


Improved the debug script to grab the docker unit file.

This changes the debug script to call systemctl to get the complete docker unit file and then finds out the docker run file used, and pulls the contents of that to get the interface config.

Looks good.


Fix Clang/GCC virtual overload error

not seeing this on the bots - I'd rather work around the issue to avoid the need for such disabling - what version of clang/gcc do you see this on?
(bots seem to be using gcc 9)

I used clang-17.

fixed this by renaming the method to matchAndRewriteOnAffinity so there's no overloading happening anymore


Update RELEASE-NOTES.txt

Submisison Checklist

[ ] Run unit tests: ./runTests.py src/test/unit
[ ] Run cpplint: make cpplint
[ ] Declare copyright holder and open-source license: see below

Summary
Intended Effect
How to Verify
Side Effects
Documentation
Reviewer Suggestions
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Spelling of my name :)

Thanks for catching that and sorry about the misspelling!

Bob

On Jun 16, 2016, at 12:07 PM, Avraham Adler<EMAIL_ADDRESS>wrote:
Submisison Checklist
•  Run unit tests: ./runTests.py src/test/unit
•  Run cpplint: make cpplint
•  Declare copyright holder and open-source license: see below
Summary
Intended Effect
How to Verify
Side Effects
Documentation
Reviewer Suggestions
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
• Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
Spelling of my name :)
You can view, comment on, or merge this pull request online at:
https://github.com/stan-dev/stan/pull/1925
Commit Summary
• Update RELEASE-NOTES.txt
File Changes
• M RELEASE-NOTES.txt (2)
Patch Links:
• https://github.com/stan-dev/stan/pull/1925.patch
• https://github.com/stan-dev/stan/pull/1925.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

My pleasure; thanks for the reference!


bpf: datapath: Fix fetching configured base devices

Before this change, the base loader logic was not creating the slice of
base devices properly.
Fixes: 9e48678686e2 ("bpf: datapath: Rewite base devices setup in Go")
Reported-by: Martynas Pumputis<EMAIL_ADDRESS>Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

test-me-please

thinking is there a testing / CI gap here?

@joe This should fix the ipvlan mode and the flannel mode. For both we don't have tests at the moment. The former will be replaced by https://github.com/cilium/cilium/pull/14436 and the latter should be deprecated in favor of the CNI chaining.

retest-runtime

retest-4.19

@brb yes, I tested manually


[REQUEST] Enable.disable scrolling programatically

Is your feature request related to a problem? Please describe.
I would like to enable/disable scrolling programatically
Describe the solution you'd like
Add a .shouldScroll(bool) modifier to Pager Where we can disable/enable scrolling

hi @skywalkerdude , have you tried allowsDragging?


[FEATURE] Rearrange, insert & remove params from windows

Would be nice to have what KER has, ability to arrange window information as you want

This is planned but requires some major rewriting before doing it.

@Micrologist, if you don't have immediate plans to tackle this, I'd like to try it, if that's ok with you.
Was thinking on working on rearranging, adding/removing items in a window, as well as having an ability to create custom windows.

Got busy with real life for a bit, sorry.
What I had in mind was abstracting the sections/windows into a class that holds the relevant information like title, popoutstate / popout position and a list of entries (where each entry has a name and a reference to the value it should display).
Also the whole value gathering and calculating should be moved to Update since OnGUI might be called multiple times per frame and there is no situation where recalculating readouts multiple times is a useful thing to do.


High Memory usage due to Jenkins Client

Hi Team
Thanks for creating such a useful library which was easily integrated with .NET code..
I am using it however post PRODUCTION deployment i can see high memory usage on servers. I am having different - different Base URL based on job name and creating client every time when my code is getting invoked.
var client = new JenkinsClient
{
BaseUrl = jenkinsBaseUrl,
UserName = username,
ApiToken = token
};
I can't make it static as i create BaseURL dynamically and each client can have different base url.
What is the best practice here for better memory utilization , do i nullify this object in finally block ?

@petelopez  @null511  Waiting for your quick reply as i need to solve high memory usage quickly on PROD


Add ability specify base dir which will not be cleaned after restart

Here is the case:

my git repo is inaccessible
I've got nodes with config server crashing (require new instance setup)

I'll probably loose my config server under these conditions in production. It would be nice to
a) allow to specify some base path so I can use mounted folder to keep files
b) use same folder on startup
Does this make any sense to implement? I tried to use repo uri as the key for each checkout, so if there is overlapping repos by key, they might get corrupted
NOTE: Not sure who decided to instantiate MultipleJGitEnvironmentRepository via ConfigurationProperties, but this is really strange decision. Its complaining that  PatternMatchingJGitEnvironmentRepository must have default constructor? Really?

@vasilievip Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@vasilievip Thank you for signing the Contributor License Agreement!

Current coverage is 71.10% (diff: 72.72%)

Merging #614 into master will decrease coverage by 0.20%

@@             master       #614   diff @@
==========================================
  Files            67         67
  Lines          2140       2156    +16
  Methods           0          0
  Messages          0          0
  Branches        357        360     +3
==========================================
+ Hits           1526       1533     +7
- Misses          473        481     +8
- Partials        141        142     +1

Powered by Codecov. Last update 2efe1a4...18a790d

Not sure I understand the need for this.  Restarting the server or creating a new instance would just cause the config repo to be cloned again.
Your git repo does not need to be remote today, and we already have the ability to use the native file system for configuration properties.

native file system might be the option (while I have to maintain repo on some shared store)


[Bug][gitlab]  gitlab connection syncs indefinitely

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
A gitlab connection never finishes to collect data.  When the job is successful, it takes about 12 min. to complete.  Every now and then the job runs continuously for days without completing.  The cancel button doesn't cancel the job.  I restart the devlake containers to end it.
Other gitlab jobs run just fine, there seems to be something special with this one.
I thought it was a one-time event but it's been happening a few times now.
What do you expect to happen
Scan to complete in about 12 min.
How to reproduce
Create project with a gitlab connection.  Select a number of repositories.  Create a daily schedule.  Monitor job for status.
Anything else
No response
Version
v0.17.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

wrongly closed the issue.

@MarcViola Thanks for your report, there were so many tasks, can you point out which task failed/stucked?

Seems like the connection to the database had failed. Maybe the mysql container crash for some reason? How about the storage and memeory usage? Can you set up some monitoring mechanism for it?

The container itself is ok.  Storage is ok.  But I'll setup some monitoring and see what happens to CPU and memory.

CPU idle and Free mem during the night when data collection is happening. I have disabled the collection of unused projects and will monitor again tonight and see if it makes a difference.  It does look like resources may be a problem at some point.

I will add more memory to the VM.  I'll close the ticket for now and re-open if it's still an issue.  Thanks.


GITHUB Webhook error reading config-logging configmap

Expected Behavior
no error
Actual Behavior
logs
k  logs -n knative-sources      github-webhook-78cf686cd5-z2xmx
2020/02/04 17:27:03 Registering 1 clients
2020/02/04 17:27:03 Registering 1 informer factories
2020/02/04 17:27:03 Registering 3 informers
2020/02/04 17:27:03 Registering 3 controllers
2020/02/04 17:27:03 Error reading/parsing logging configuration: configmaps "config-logging" is forbidden: User "system:serviceaccount:knative-sources:github-webhook" cannot get resource "configmaps" in API group "" in the namespace "knative-sources"

Steps to Reproduce the Problem

Install knative Serving and Eventing
Install the github.yaml  from 12.1

Additional Info

seems to be fixed now.


Problem: Guzzle/Pool with kevin-rob/guzzle-cache-middleware - Invoking the wait callback did not resolve the promise

Guzzle version(s) affected: 7.2.0
PHP version: 7.4.12
cURL version: 7.64.0
Project using Symfony 5.1.8
Versions info:
root@7a917597f9c1:/var/www# composer show | grep guzzle
guzzlehttp/guzzle                     7.2.0     Guzzle is a PHP HTTP client library
guzzlehttp/promises                   1.4.0     Guzzle promises library
guzzlehttp/psr7                       1.7.0     PSR-7 message implementation that also provides common utility methods
kevinrob/guzzle-cache-middleware      v3.3.1    A HTTP/1.1 Cache for Guzzle 6. It's a simple Middleware to be added in the HandlerStack. (RFC 7234)
spatie/guzzle-rate-limiter-middleware 2.0.0     A rate limiter for Guzzle

Description

Using https://github.com/Kevinrob/guzzle-cache-middleware for caching, the error below occurs when we try to do asynchronous request using Pool if the cache is used.
request.CRITICAL: Uncaught PHP Exception GuzzleHttp\Promise\RejectionException: "The promise was rejected with reason: Inv
oking the wait callback did not resolve the promise" at /var/www/vendor/guzzlehttp/promises/src/Create.php line 62 {"exception":"[object] (GuzzleHttp\\Promis
e\\RejectionException(code: 0): The promise was rejected with reason: Invoking the wait callback did not resolve the promise at /var/www/vendor/guzzlehttp/pr
omises/src/Create.php:62)"} []

Part of stacktrace:
GuzzleHttp\Promise\RejectionException:
The promise was rejected with reason: Invoking the wait callback did not resolve the promise

  at vendor/guzzlehttp/promises/src/Create.php:62
  at GuzzleHttp\Promise\Create::exceptionFor('Invoking the wait callback did not resolve the promise')
     (vendor/guzzlehttp/promises/src/Promise.php:72)
  at GuzzleHttp\Promise\Promise->wait()

How to reproduce

Step 1:
Let's execute this code
private function test(){

        $productIdsToCheck = new ArrayCollection([1,2,3,4,100,6,7,8,9,99]);

        // Create request function
        $requests = function ($productIdsToCheck)
        {
            foreach ($productIdsToCheck as $key => $productId)
            {
                yield new Request(
                    'GET',
                    'https://httpbin.org/'.$productId
                );
            }
        };

        // Create the pool using $request function
        $pool = new Pool($this->httpClient, $requests($productIdsToCheck), [
            'concurrency' => 5,
            'fulfilled' => function (Response $response, $index)
            {
                // this is delivered each successful response
            },
            'rejected' => function (RequestException $reason, $index)
            {
            },
        ]);

        // Initiate the transfers and create a promise
        $promise = $pool->promise();

        // Force the pool of requests to complete.
        $promise->wait();
    }

Everything is ok the first time.
Step 2:
Now, just change the value from 100 to 10 into the ArrayCollection $productIdsToCheck variable and re-execute the same code
private function test(){

        $productIdsToCheck = new ArrayCollection([1,2,3,4,10,6,7,8,9,99]);

        // Create request function
        $requests = function ($productIdsToCheck)
        {
            foreach ($productIdsToCheck as $key => $productId)
            {
                yield new Request(
                    'GET',
                    'https://httpbin.org/'.$productId
                );
            }
        };

        // Create the pool using $request function
        $pool = new Pool($this->httpClient, $requests($productIdsToCheck), [
            'concurrency' => 5,
            'fulfilled' => function (Response $response, $index)
            {
                // this is delivered each successful response
            },
            'rejected' => function (RequestException $reason, $index)
            {
            },
        ]);

        // Initiate the transfers and create a promise
        $promise = $pool->promise();

        // Force the pool of requests to complete.
        $promise->wait();
    }

And the error message appears:
The promise was rejected with reason: Invoking the wait callback did not resolve the promise

Dependencies injection as i am using symfony 5.1.8:
#services.yaml

services:
_defaults:
        autowire: true      # Automatically injects dependencies in your services.
        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
        bind:
            $httpClient: '@http_api_client'

        Kevinrob\GuzzleCache\Storage\Psr6CacheStorage:
                class: Kevinrob\GuzzleCache\Storage\Psr6CacheStorage
                arguments: [<EMAIL_ADDRESS>]

            Kevinrob\GuzzleCache\Strategy\GreedyCacheStrategy:
                class: Kevinrob\GuzzleCache\Strategy\GreedyCacheStrategy
                arguments: [ '@Kevinrob\GuzzleCache\Storage\Psr6CacheStorage', '3600' ]

            Kevinrob\GuzzleCache\CacheMiddleware:
                class: Kevinrob\GuzzleCache\CacheMiddleware
                arguments: [ '@Kevinrob\GuzzleCache\Strategy\GreedyCacheStrategy' ]

        GuzzleHttp\HandlerStack:
                class: GuzzleHttp\HandlerStack
                factory: [ 'GuzzleHttp\HandlerStack', create ]
                calls:
                    - [ push, [ '@log_middleware', 'log' ] ]
                    - [ push, [ '@Kevinrob\GuzzleCache\CacheMiddleware', 'cache' ] ]
                    - [ push, [ '@Spatie\GuzzleRateLimiterMiddleware\RateLimiterMiddleware', 'rate-limit' ] ]

        http_api_client_
                class: GuzzleHttp\Client
                arguments:
                    - handler: '@GuzzleHttp\HandlerStack'

Possible Solution

Do not use Pool (asynchronous request) or do not use https://github.com/Kevinrob/guzzle-cache-middleware/issues
No real workaround found
Additional context

Info 1 : If i remove the cache feature by commenting  the line   - [ push, [ '@Kevinrob\GuzzleCache\CacheMiddleware', 'cache' ] ] ,  then everything woks fine.
If you re-enable cache feature, the problem appears again. Seems linked to the cache.
Info 2: I tested different type of cache (flysystem, doctrinecache and psr6) with GreedyCacheStrategy. Same issue for both. I cannot test with PrivateCacheStrategy because in my use case the cache do not cache correctly with that strategy. But it seems to confirm that the problem appears only when the cache is used.
Info 3: Same issue with Guzzle6
I will added more comments to this issue if I found more info to help for debugging.

Thanks for opening this, I stumbled upon this too - without you using the cache middleware and using guzzle 7.2. But I still got to proper research the responses. Their might other reasons than in your case.


Vue Styled with Pseudo

Not sure what im doing wrong...
but this:
export const backgroundExample= styled.div`
background: black;
height: 50px;
width: 50px;

&:hover {
    background: yellow;
  }
`
doesn't work for me...

Dependencies

"vue": "^2.5.2",
"vue-router": "^3.0.1",
"vue-styled-components": "^1.2.3"

devDependencies

"webpack": "^3.6.0",
"webpack-bundle-analyzer": "^2.9.0",
"webpack-dev-server": "^2.9.1",

I've pushed a new version 1.4.12
In the examples section there is a &:hover example, and it's working.
Thank you for reporting :)


Fix TRACE build

Compilation was failing on LOG_TRACE builds. This PR fixes it.

Coverage increased (+0.01%) to 71.476% when pulling 2a45bc3c22142f15931e837b67b625e234e63deb on pmenon:fix-trace-build into 8e87b9f885ac49df67b2d120134980f79819d251 on cmu-db:master.

Coverage increased (+0.004%) to 71.468% when pulling 56183c7e7888c8db8ee727b9e5e49cde0fbe7557 on pmenon:fix-trace-build into 8e87b9f885ac49df67b2d120134980f79819d251 on cmu-db:master.


Analyzer doesn't notice incorrect return type of generic method

dart analyze gives no errors on the follow code:
void main() {
  method(getB());
}

void method(String b) => print(b);

B getB<B extends A>() {
  return A() as B;
}

class A {}

I would have suspected it to say something along the line of The argument type 'A' can't be assigned to the parameter type 'String'.
Dart SDK version: 3.4.3 (stable) (Tue Jun 4 19:51:39 2024 +0000) on "linux_x64"

Inference produces B:=Never hence no error because Never is a bottom type.
I assume this is expected cc @eernstg @stereotype441

It's definitely tricky code. Probably the code is a little too smart for its own good.
The inference of Never is a success. It satisfies the bound, and since the function can return any type that is a subtype of A, and in this case it certainly returns Never as the result of A() as Never (aka, the as throws like it's intended to).
I assume the function B getB<B extends A>() { return A() as B; } is constructed for the example, a body like that wouldn't be what you'd want in real code - the A() as B will throw for any binding of B other than A.
More likely the type B is used to look up some value that is likely to implement B, and then cast it.
That means that getB treats the type parameter as an argument, it's not just generic in the type (code works the same for all valid type arguments), rather the type parameter likely affects control flow too. (Even in this example, the as B behaves differently for different types.) Using a type parameter that way dangerous and potentially fragile, but not impossible to do successfully.
Then that function is called without an argument, but because it's a type argument, one is inferred.
That works well when the context type is a subtype of A, then it's easy to infer type for B.
It breaks down when the context type is not a subtype of A.
Reasonable examples could be C? or FutureOr<C> with C a subtype of A. Those are actually solved with B=C.
Unreasonable examples would be some type that has no relation to A, like String, which are solved with B=Never. Which is a correct solution that satisfies everything the body requires.

We could say that the invocation of f is dead code when we encounter f(e1, .. ek) such that the type of ej is Never for some j (and similarly for methods, operators, and setters).


Add a .not() operator for negating matchers

I commonly find myself wanting to write compound matches, but I need to negate one of the matches.
.to include(a: '1').and.not(include(b: '2'))

We attempted this previously (see #505) but ran into problems.  Providing an understandable description and failure_message from a negated matcher becomes a natural language problem that's out of scope for what RSpec is meant to do.  Instead, we decided to add RSpec::Matchers.define_negated_matcher -- that allows you to define a new matcher that is the negation of an existing one.  We found that this works better, because the user provides the alternate phrasing (via the matcher name) that expresses the negation that we can use for the description and failure_message.  So, for example, RSpec::Matchers.define_negated_matcher :exclude, :include defines exclude and we can simply substitute "exclude" for "include" in the description and failure message and it reads well and is very understandable.

I'm happy with define_negated_matcher FWIW

I'm curious why the built-in matchers don't have negated forms by default?

I'm curious why the built-in matchers don't have negated forms by default?

For one, because no one has ever asked for it before.  define_negated_matcher was new in RSpec 3.1.
I'm also concerned that many (perhaps most) of the matchers have multiple ways to phrase negation and the "best" way is subjective and non-obvious.  I don't want to add a bunch of negated forms and than have users suggest alternatives that are better and have to keep adding new APIs to RSpec for this.  I think a better way to go about it would be a gem that provides all these, that the community can contribute to until we have a consensus, and then we can consider rolling it into RSpec.
There's also the issue of the aliases we added that read well for composability -- when building composed matchers we offer non-phrase aliases for the build in matchers, and another use case for defining a negated matcher is to pass a negated matcher to another one -- e.g. expect { }.to raise_error(a_string_excluding("boom")) -- a_string_excluding would be a negation of a_string_including which is an alias of include.  If we ship negated forms for all the built-in matchers it suggests we should ship them for all the aliases as well....and now we're talking about serious API bloat.
All in all, it seems better to let users meet their own needs with the simple use of define_negated_matcher.

Closing as there's nothing clearly actionable here given our past choice to go with define_negated_matcher over a negation operator.


Changed project name to agora.

Renamed project to agora per Juan's suggestion.

Coverage remained the same at 97.159% when pulling 3b153bb8f7e79da99bc0f008660ea68a71465c4a on rename-project into 87b0d8a99cf5263309bf231757acd858dcaaae20 on develop.


Disarm without code

The disarm function from card button and inside button is different.
When you try to disarm the alarm clicking in alarm status and then disarm in the icon menu, you have to insert whatever number in the keyboard or you cannot disarm the alarm panel.
Different behaviour has the disarm button in the card. Here you can disarm without insert the code.
Always in the configuration status WITHOUT REQUIRED CODE.
Any ideas about that?

did you setup a code in your configuration?

no, i don't

But can you explain a little bit more what is what is happening and what do you expect to happen? Thanks!

Hi,
I try to explain better. With a configuration without setting a code..I expect that you never need to put code when you are going to disarm the alarm.
The disarming clicking disarm button in the card works well..I mean you don't need to put any code to disarming (obviously because of you made a configuration without code) but. with the same configuration if you go into the icon menu that show when you click in alarm status and press disarm, you have to insert whatever number in the keyboard to disarm the alarm and this doesn't make sense with no code configuration.
I expect to have explained better now.
Thanks a lot for your support


Login dont work

Hi,
when I try to log in with both the admin account and a created account, nothing happens. There is no error in the browser or in docker.

Hi,
when I try to log in with both the admin account and a created account, nothing happens. There is no error in the browser or in docker.

Would you share the configuration used?

services:
  snapp:
    image: uraniadev/snapp:latest
    ports:
      - 3000:3000
    environment:
      DATABASE_URL: 'file:./db.sqlite'
      DATABASE_PROVIDER: sqlite # mysql | sqlite | postgres
      TOKEN_SECRET: ***
      SMTP_HOST: ***
      SMTP_USER: ***
      SMTP_PASS: ***
      SMTP_FROM: ***
      SMTP_PORT: 465
      SMTP_SSL: true
      ENABLE_SIGNUP: true
      ORIGIN: http://<IP_ADDRESS>:3000

You are trying to access via HTTP, that is not secure and the cookie expire on being set. try node env or use a ssl certificate :)
  ORIGIN: http://<IP_ADDRESS>:3000
  NODE_ENV: development

Also, fyi, when I first started, my ADMIN_USERNAME= had the first letter capitalized and since the login prompt doesn't let you use uppercase letter, it wouldn't let me log in. It let me after I did an all lowercase username.

Also, fyi, when I first started, my ADMIN_USERNAME= had the first letter capitalized and since the login prompt doesn't let you use uppercase letter, it wouldn't let me log in. It let me after I did an all lowercase username.

i'll fix with sanitizing username

OK, it worked with NODE_ENV: development.
I wanted to try it out without a certificate first.
I have a feature request: Multi Domain support. So that you can choose which domain you want to use

shouldn't that easily solvable with proxy? 🤔

Yes, I solved it that way too, but I want to be able to select the domain. So, for example, the short domain XY.de/abc redirects somewhere other than YX.de/abc. If you know what I mean.

atm is not planned, but we'll see 🤔

is it also possible to use the shortcode with capital letters? I think that's a point for a new issue
this is by design to avoid ambiguities actually...


Add battery test sensor?

As I believe you are already parsing the logs for the FCR-D state, would it be possible to also parse for the latest battery test run add a sensor with the result? Having that value, seeing it over time, and also give the possibility for automations/alerts in HA could be beneficial for multiple reasons.

Thanks for the proposal, but it will be rejected.
You can easily create such a sensor using Templates as described in the documentation. The FCR-D is available as an attribute on the CM10 sensor.
On top of that, FCR-D changes are already published as Events, again as described in the documentation.  Said events can be used to trigger automations.
The following events are thrown and can be used to create automations: fcrd_activated, fcrd_deactivated, fcrd_failed
See example automation in the documentation.

(Too quick to close...)
The issue will be converted to a discussion should feeback be needed.


Can't find the task

Hi,
I've created a release pipeline and agentless job, but nonetheless I cant see the Manual Intervention task. Can you help me with that?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1c633b9-c8b2-e05d-de2c-7754894d28fd
Version Independent ID: df031b76-0fe7-e138-dd36-2736757a97fd
Content: Manual intervention task for Azure Pipelines and TFS
Content Source: docs/pipelines/tasks/utility/manual-intervention.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

I added a Delay task instead. Then after a refresh and coming back to the release pipeline I'm suddenly able to see the Manual Intervention task.

This looks like a bug and should be reopened. I had the same issue of not being able to see the "Manual Intervention Task" until I actually clicked the "Refresh" button by "Add Tasks". All other manual refreshes would not show it until this exact refresh button was clicked.

Thank you for your feedback. I've tried this several times and cannot reproduce the issue. I don't think that there is a fault in the documentation. I suggest you post it on the Product Feedback site (Developer Community - https://developercommunity.visualstudio.com/spaces/21/index.html) to see if you can get a more specific answer to the issue.

@alexhomer1 As of now, all I can see is a 404 for the GitHub URL in the docs:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks/ManualIntervention

Looks like the GitHub doc has been removed in favor of the topic "Manual intervention task for Azure Pipelines and TFS" (linked above). I'll remove the link to GitHub.


Add Device Operations Using Downlink messages

Add the ability to implement device operations (methods) which gets executed by downlink messages. This will facilitate automating the systems.

I think I probably got it wrong. Looks like Push notifications is the way to go with sending requests back to the devices. And I don't see ability to set push notification as the output of stream analytics jobs output sink. So we may need a service (Can WebJobs be used?) to convert event hub to push notifications?
Or Is there a better way to achieve this

Now that we are using IoT Hub instead of Event Hub (since V2) we can do this using native Cloud 2 Device functionality. This is something I am planning to work on soon. Stay tuned.

I have added a Cloud to Device message each time an alert is triggered.


FCS_COP.1.1(1) Application note needs to be updated.

FCS_CKM.1(1) does not exist in this PP so it either needs to be added or the link needs to be removed from the application note of FCS_COP.1.1(1).

Fixed


Reading a recipe for the second time does not consume item

In fact, if we didn't see you read it the first time, we can deduce you learned it.
Ash proxy record fields:
ash $item[warbear metalworking primer].skill -> Shrap
ash $item[Recipe of Before Yore: Pete's wily whey bar].recipe -> Pete's wiley whey bar
(Yes, I bug reported the disparity in names to KoL)
New String Modifier: Recipe: "CONCOCTION"
I only added them to Recipes of Before Yore, for now
When you find the Sot's Parcel, give a navigation link to go see him.

Is it worth adding modifiers for the other 11 recipe items (minus the crystallized memory, which teaches multiple recipes)?

I think it is. I'm not sure I want to add the detection for "you already know this recipe" unless it is the same. Heck, I could make it a negative test: unless we get "you learn a new recipe" assume you aleady learned it.
I'll take look.

I inverted the test - NOT seeing "You learn to craft a new item" - and added 11 more recipes.


Generics Extending Distributed Conditionals Cannot be Narrowed

Bug Report
🔎 Search Terms
Generics, Union, Narrow, Narrowing, Distributed, Conditional, Inference
🕗 Version & Regression Information
TS v4.3.5 (and nightly build as of 7/23/2021)

This is the behavior in every version I tried, and I reviewed the FAQ for entries about conditional types & inference

⏯ Playground Link
Playground link with relevant code
💻 Code
type Tuplify<A> = A extends unknown ? [A] : never
type test = Tuplify<'a' | 'b'> // test = ['a'] | ['b']

declare const inferFunc: <A, R extends Tuplify<A>>(a: A, b: R) => R
declare const testval: 'a' | 'b'
const retval: ['a'] = inferFunc(testval, ['a']) // this should work (?)

🙁 Actual behavior
const retval: ['a'] | ['b']

🙂 Expected behavior
const retval: ['a']

I expected R to be inferred as a subtype of Tuplify<A>, since that's how parameterized union types work as of https://github.com/microsoft/TypeScript/issues/13995 (I think)
Please forgive me if this is actually expected behavior or has already been reported

Constraints aren't inference locations, so there isn't a sufficient hint at b to infer a literal type for the array.
You could write it this way, which works as expected:
type Tuplify<A> = A extends unknown ? [A] : never
type test = Tuplify<'a' | 'b'>;
declare function inferFunc<A, R>(a: A, b: R & Tuplify<A>): R;
declare const testval: 'a' | 'b';
const retval: ["a"] = inferFunc(testval, ['a']);

@RyanCavanaugh Thank you for such a speedy response!
I'm not sure I understand - different constraints give the correct inference:
declare const inferFunc2: <R extends ['a'] | ['b']>(b: R) => R
const retval2: ['a'] = inferFunc2(['a']) // works fine

declare const inferFunc3: <A extends 'a' | 'b' | 'c', R extends Tuplify<A>>(a: A, b: R) => R
const retval2: ['a'] = inferFunc3(testval, ['a']) // works fine

I think this is somehow related to the Tuplify type specifically, or maybe distributed conditionals (there are other counter-examples in the linked playground)

You could write it this way

I'm realizing that my acceptance criteria were poorly outlined - it looks like your inferFunc actually returns [string], which technically matches ['a'] but doesn't solve my problem. Imo ideally it would return exactly ['a']

I've realized that this is a string literal inference issue:
type Tuplify<A> = A extends unknown ? readonly [A] : never
declare const inferFunc: <A extends string, R extends Tuplify<A>>(a: A, b: R) => R
declare const testval: 'a' | 'b'
const retval = inferFunc(testval, ['a'] as const) // correctly inferred as `readonly ['a']`

Thanks for your guidance!

In case anyone else is reading, this works too and is a little simpler:
type Tuplify<A> = A extends unknown ? [A] : never
declare const inferFunc: <A extends string, R extends Tuplify<A>>(a: A, b: [...R]) => R
declare const testval: 'a' | 'b'
const retval = inferFunc(testval, ['a']) // correctly inferred as `['a']`


[WFCORE-2660] Upgrade WildFly Elytron to 1.1.0.Beta36 and backport latest fixes.

⚠ Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. ⚠
The following issues can be resolved with this PR: -
https://issues.jboss.org/browse/WFCORE-2653
https://issues.jboss.org/browse/WFCORE-2660
https://issues.jboss.org/browse/WFCORE-2661
https://issues.jboss.org/browse/WFCORE-2445
https://issues.jboss.org/browse/WFCORE-2570

Experimental Builds: -
https://ci.wildfly.org/viewLog.html?buildId=54663&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments
https://ci.wildfly.org/viewLog.html?buildId=54665&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows

Replacement experimental jobs including a minor IPv6 related fix: -
https://ci.wildfly.org/viewLog.html?buildId=54702&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments
https://ci.wildfly.org/viewLog.html?buildId=54704&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows


validations.errors not updating when hasMany validation changes

Environment

Ember Version: 2.6.0
Ember CLI Version: 2.4.2
Ember CP Validations Version: 2.9.4

Steps to Reproduce

Add has many validation to a model with a has many to an object that also has more than one validator defined. E.g. team has many players, player has a firstName and lastName that must both be present.
Add a new empty player. Validation (team.validation.errors) correctly includes that firstName and lastName must both be present.
Set firstName on the player.

Expected: team.validation.errors no longer contains an entry for the firstName field, just the lastName.
Actual: team.validation.errors includes the original two errors.
If team has further validation rules (e.g. it's teamName must be set) then the team.validations.errors correctly updates if the parent validation state changes. It's just that if you change the child model but not to the point that isValid/isTruelyValid is true, the parent errors don't update. Worth noting the child ones do (e.g. player.validations.errors).
Not sure if this is an issue or something I'm doing wrong / expecting that isn't right.

@jameshoward can you post some snippets for your models / validations?

I've built a test project that demonstrates the issues I'm having: https://github.com/jameshoward/ember-cp-validations-test
You can either dig around in the code or fire it up and have a look. Here's what I'm seeing:

Initial state shows that the team is invalid because nameis blank. Correct.
Add a player. Validation for the player is correct as firstName / lastName is blank. However, the validation errors for the team do not include the hasMany errors. (This may be correct behaviour but isn't consistent…)
Enter a name for the team. The team validation errors update to show the issues with the player. This seems correct, but it's odd they only appear at this point.
Enter a firstName for the player. The player's validation correctly updates but the team validation suggests the firstName is still blank.
Enter a lastName for the player. All validation is now fine.

Things get even more funky if you add 2 players then start entering values. At that point I can never see any of the hasMany validations showing for the team.
If the idea is that validations.errors doesn't include hasMany errors, that's cool and I can work around that but then no. 3, where they do show up, doesn't make sense.
Any help greatly appreciated. This module is really helping with the validation and this has been the only thing I'm struggling with a bit.

@jameshoward thanks for putting this together. Ill take a closer look when I have some time later this week.

@jameshoward I've been working on a pretty big internal re-work the last couple of days which just landed in master this evening (#321). When I ran your dummy app and used the current version in master, it seemed to solve the issue! 🎉
Im waiting on another PR to land and then ill release another beta version with this fix. Thanks for taking the time to put the dummy app together 😸

Excellent, sounds good. No worries on the dummy app, happy to help since this library is doing great stuff for my project.

Just FYI, I've just updated our app to use v3.0.0 and it's working as expected now. Thanks again!

@jameshoward thats great to hear! Thanks for the confirmation! 😺


Extractor Not able to detect the Collector Name

⚠ Pre Checklist
Summary
Adding a nil check before throwing an error.

Does this close any open issues?
Closes #3307
Screenshots
Before

After

Other Information
Any other information that is important to this PR.

@keon94 @mindlesscloud  Can you verify it.  It closes #3307 .


Fix docker-machine config does not work on fish

Tiny PR to fix #2415 - Fix for docker-machine config broken on fish shell. Already covered by test

LGTM


MorrisPreOrder Traversal

Detailed description
Morris Traversal is an algorithm for Binary tree traversal in O(1) space.
https://en.wikipedia.org/wiki/Tree_traversal
Context
It can help users to understand how morris traversal works, and how it can be used for preorder traversal.Morris
Possible implementation
It is implemented with threaded traversal. i.e., changing tree internally during traversal and restoring it to original state.
Additional information
No response

Hi Muhammad, I can implement the algorithm in C++. If this is the requirement can you please assign the issue to me?
Regards,
Sharan


Release 1.0.0-rc3

@rhatdan @runcom @sameo PTAL

LGTM. Hopefully we will not have to release RC4.

@rhatdan Yeah, we can switch to 1.0 final but can keep the dev version as rc4 for now.

Looks like a Flake and has nothing to do with this Patch.


Query count estimation

Some variables are less likely to be used in the later stages of an execution of a program. Keeping track of the different states of these variables is inefficient. Merging the states can reduce the total number of branches.
The goal of this issue is to identify a strategy to estimate whether a variable is likely to be used later on or not.
Goal:

Find a way to identify which variables are important and which ones are less important.

Resources:

Efficient State Merging in Symbolic Execution

Refrences #181


Roadmap: Task 2b: Report-style dashboard layouts

Support for automatic conversion of a Jupyter notebook to a shareable dashboard, with a fixed report-style layout

Panel.show and panel.servable and other panel capabailitys (such as latex functionarliy) fulfills this


Improved options for adding policies

I'd love to be able to have the Cors middleware resolve my policies from the container.  If any of my policies require configuration parameters, it seems like there's no nice clean way to break them out into their own files that can depend on IOptions<Something>.
Alternatively, it might be nice if I could better leverage the options system to set up my CorsOptions instance.
The current setup seems to force me to either move lots of definitions to an extension method, or I end up having to leave them inside of my Startup.cs, which obviously gets quite big.

You mean some way to load policies dynamically (e.g. from a DB)?

Well, not from a DB.  But I have some IOptions instances that have values I'd love to get into my policy.  So maybe not as heavy as DB ;)

For me I need a DB. I was just wondering if we could achieve 2 birds with 1 stone here.

It's possible.  I wouldn't be surprised if somehow the approach was similar.

We have no plans to implement this in the box, but we do have an example of a dynamic CORS policy provider here: https://github.com/aspnet/Entropy/tree/dev/samples/Mvc.DynamicCorsPolicyProvider (the example uses MVC, but the CORS stuff is all the same regardless of MVC).
You could certainly use that sample as a starting point to implement other types of CORS providers. If you come up with something and publish it, we'd be happy to link to it.


feature: Contribution Highlights

note: there is a sub-nav that switches to the user's highlights

This was mocked by me by manipulating the existing design. cc @pixelsbyeryc
https://www.figma.com/file/OpVX6WT7dmWqnwRuEvADMF/OpenSauced-—-Insights-(insights.opensauced.pizza)?node-id=5204%3A6170&t=T8av4JLONEnmJyCa-0

FYI @OgDev-01, @getaheaddev is going to update this design and let you know when it is ready.****

@OgDev-01 Its ready

@OgDev-01 I'm working on this design right now.

I'm going to correct somethings about the design. Make highlights the first tab. also what it looks like when you have zero highlights


Nodes stuck in 'done' state after Linux job failure

Information

Onefuzz version: 2.18
OS: Linux latest

Provide detailed reproduction steps (if any)

Run the job from #961 with the keep_on_failure flag.

Expected result
Nodes to be in halt state after failure
Actual result
Node is in done state after failure
    "nodes": [
        {
            "instance_id": "0",
            "machine_id": "4b2e10d7-d04e-4409-a459-8eb74d06c530",
            "state": "done"
        },
        {
            "instance_id": "1",
            "machine_id": "39bd7988-1f05-4037-be36-fb89de6c1cc5",
            "state": "done"
        },
        {
            "instance_id": "2",
            "machine_id": "f6d2c71b-7a99-4fd9-bbbc-6cd8f32e7a54",
            "state": "done"
        },
    ],

Checking a single node:
{
    "debug_keep_node": false,
    "delete_requested": false,
    "heartbeat": "2021-06-03T16:55:36+00:00",
    "machine_id": "4b2e10d7-d04e-4409-a459-8eb74d06c530",
    "messages": [
        {
            "stop": {}
        }
    ],
    "pool_name": "***",
    "reimage_requested": true,
    "scaleset_id": "e14978e0-db1e-4483-b91d-337d1bd39b44",
    "state": "done",
    "tasks": [],
    "version": "2.18.0"
}

Tried reimaging it via onefuzz nodes reimage 4b2e10d7-d04e-4409-a459-8eb74d06c530 but did not observe any change.

Also curious that "debug_keep_node": false is present despite running with the keep on failure flag. Is this maybe because it's not being detected as a failure?

@bmc-msft, any WIP relate to this, or investigation notes to share here?
@jagunter, have you seen this recently (since 3.0)?

The underlying cause should have been addressed by the combination of #1005, #1054, and #1103.


plotjuggler: 3.0.2-3 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository plotjuggler to 3.0.2-3:

upstream repository: https://github.com/PlotJuggler/PlotJuggler.git
release repository: https://github.com/PlotJuggler/plotjuggler-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.0
previous version for package: 3.0.1-1

plotjuggler
* fix icon color in dark mode
* updated to latest Qads
* temporary fix for #349 <https://github.com/PlotJuggler/PlotJuggler/issues/349>
* link updated
* use correct dependency
* fix issue #348 <https://github.com/PlotJuggler/PlotJuggler/issues/348>
* Contributors: Davide Faconti

I am having some issues, as you can see here:
https://github.com/ros/rosdistro/runs/1467636226?check_suite_focus=true
Any suggestion about how this can be fixed? I moved the repo and I used the new URL in bloom, but the error persists.


Ready to release v0.5.0.

This PR bumps the version to 0.5.0 and once merged, will trigger a release to Pypi and an update of the documentation on RTD.
I'll keep this PR open for a week, for people to review and comment.
Here is the API documentation for this version: https://ld.readthedocs.org/en/latest/

Since nobody objected in a week, I am merging this PR.
We are now at version 0.5.0 as far as the repo goes.
What is still ahead, is to release 0.5.0 to PyPI.


Revise FAQ answer for Trusted Signing for question on "subject name change"

Please modify the answer to the question "What if my Trusted Signing subject name is different from my earlier certificate and my MSIX package name is different now?"
This answer is very misleading. The persistent identity technology is not available on Windows 10. So unless the MSIX package will exclusively run on Windows 11, this answer is incorrect.
In 2024 I expect very few people that need a public code signing certificate to target only Windows 11.
The real answer is that the app needs to be uninstalled and reinstalled on all devices.
This can be done by users manually, or apps can automate this process using the packaging APIs to programmatically.
The steps that the app can programmatically take are roughly like this:

install the new app.
start the new app
close the old app
Transfer settings manually
uninstall the old app.

Quite a few issues remain with this approach, because Start-Menu pinning, Taskbar pinning, Desktop shortcuts, file assocciations all need to be handled manually.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5a7ca8eb-6afa-6a8d-590b-52fddaee8ecb
Version Independent ID: d8e0ee40-2504-35ff-2ef9-61ba4b85329c
Content: Trusted Signing FAQ
Content Source: articles/trusted-signing/faq.yml
Service: trusted-signing
GitHub Login: @microsoftshawarma
Microsoft Alias: rakiasegev

@Marv51
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Python 3.10 macOS wheel is tagged as universal2 but only supports x64 (install error on M1 Mac: "incompatible architecture (have 'x86_64', need 'arm64e')")

I have installed libraw with brew install libraw and rawpy with pip install rawpy. However I receive the following error when trying to import rawpy in my code
% python3
Python 3.10.1 (main, Dec  6 2021, 22:18:13) [Clang 13.0.0 (clang-13<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import rawpy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/matt/code/venvs/tc/lib/python3.10/site-packages/rawpy/__init__.py", line 5, in <module>
    import rawpy._rawpy
ImportError: dlopen(/Users/matt/code/venvs/tc/lib/python3.10/site-packages/rawpy/_rawpy.cpython-310-darwin.so, 0x0002): tried: '/Users/matt/code/venvs/tc/lib/python3.10/site-packages/rawpy/_rawpy.cpython-310-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/local/lib/_rawpy.cpython-310-darwin.so' (no such file), '/usr/lib/_rawpy.cpython-310-darwin.so' (no such file)

I don't really understand how python packaging and wheels work but my understanding is the --no-binary :all: option should try and build the package from source but I got this error.
pip install rawpy --no-binary :all:
ERROR: Could not find a version that satisfies the requirement rawpy (from versions: none)
ERROR: No matching distribution found for rawpy

Does rawpy support running on arm64 systems?

rawpy doesn't publish arm64 wheels yet (because GitHub Actions doesn't have M1 runners yet), but for some reason the x64 wheel for Python 3.10 is tagged as universal2 which it shouldn't be. This is why it successfully installs for you but then fails during import.
You can build from source by following https://github.com/letmaik/rawpy#installation-from-source-on-linuxmacos. Note that arm64 hasn't been tested, so you're on your own here.
I'll leave this issue open to deal with the mistagged 3.10 wheel.

@letmaik thanks, I was able to get it to install from source and it imports ok. I will try using it now. Do you want me to report any issues with arm64 that I run into on a different issue or this one?

For arm64 issues, please open new issues please.
Regarding the tagging issue, seems like this is known: https://github.com/pypa/setuptools/issues/2520#ref-pullrequest-807916179

u don't need to wait for arm64 runners, use docker buildx actions, take a look: https://github.com/kamikaze/fastapi-auth-service/tree/master/.github/workflows


global.yaml environment variables not populated

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request

Minimal steps to reproduce

Create the same pipeline structure as the project:
│   cd.yaml
│   ci.yaml
│   main.tf
│   pr-main.yaml
│   pr-production.yaml
│   provider.tf
│   README.md
│   schedule-drift.yaml
│   var.tf
│
├───stages
│       ci.yaml
│       pull-request.yaml
│
├───steps
│       confirm-kv-loaded.yaml
│       debug-vars.yaml
│       terraform-init.yaml
│       terraform-plan.yaml
│
└───vars
        global.yaml

Any log messages given by the failure

In Azure DevOps pipeline, running it against the main branch, the isMain is not populated in the Debug - Branch Variables step and I get the following:

---------
Debugging
---------
isMain:
isProduction:
Build.SourceBranch: refs/heads/main
Finishing: Debug - Branch Variables

Expected/desired behavior

I expect the isMain: true
Versions

Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.189.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash

Mention any other details that might be useful

The pipeline is fails at "Debug - Key Vault loaded?" step
--------------------------------
Confirm Key Vault 🔑 Integration
--------------------------------
KV_DEBUG_ENV: ***

⛔ Key Vault not loaded
Please double check configuration Variable Groups in Azure Pipelines UI and that the YAML pipeline is running against the 'main' or 'production' branch.
##[error]Bash exited with code '1'.
Finishing: Debug - Key Vault loaded?

although $KV_DEBUG_ENV" != '$(kv-debug-env)

Fix is to change the syntax in debug-vars.yaml from:  ${{ variables.isMain }} to $(isMain)


chore(versioneye): add version eye integration

https://www.versioneye.com/user/projects/5728e1dba0ca350034be67be for info

[Current coverage][cc-pull] is 82.60%

Merging [#697][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #697   diff @@
==========================================
  Files            29         29
  Lines          2558       2558
  Methods           0          0
  Messages          0          0
  Branches        396        396
==========================================
  Hits           2113       2113
  Misses          323        323
  Partials        122        122

Powered by Codecov. Last updated by [24a8292...a5e6cd6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/24a82922a4d088ace1f6ac0ea83f409332291489...a5e6cd6481c04878ffd91e806a38827bdbb82908
[cc-pull]: https://codecov.io/gh/deis/controller/pull/697?src=pr


golang.org/x/crypto/ssh marshal/unmarshal errors

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.8.3
What operating system and processor architecture are you using (go env)?
amd64 darwin
What did you do?
This program ( https://gist.github.com/tobowers/8118cd1a668926c40909639a2b2af195
) generates the output:
$ go run marshal.go
2017/08/17 09:53:16 error unmaarshaling: ssh: unmarshal error for field Key of type Certificate: unsupported type: ssh.PublicKey
exit status 1

play.golang apparently doesn't have x/crypto/ssh so I couldn't have it runnable on there.
What did you expect to see?
I expect an immediate call to Unmarshal from a marshaled certificate to succeed without error.
What did you see instead?
The program errors with the output above.

hmmm.... changing the code to: https://gist.github.com/tobowers/7df99bac5fb2cb30bb06e4ce4d540364#file-marshaled-fixed-go-L40-L48 works.
It's confusing that you need to use ParsePublicKey and then type assert into a certificate to have this work.

ssh.Unmarshal is the mirror ssh.Marshal.
If you want to send a clarification of the SSH package docs, that would be great.