docs(module:experimental-image): provide missing NzImageService

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

CAN NOT open experimental image page https://ng.ant.design/experimental/image/en

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Frankly I think it's weird that the experimental image component imports NzImageDirective but does not provide NzImageService, as a result users have to provide the service manually.
What about importing NzImageModule instead of NzImageDirective in the experimental image component? WDYT @HyperLife1119

How about setting NzImageService to provided root?

How about setting NzImageService to provided root?

Agree with you. NzImageService just only has a preview method, it's ok to provide it in root.
I will create a new PR in v19


Get-DBAAgentJobHistory adding an hour on to the enddate and duration

#issue
Issues seen with duration and enddate adding an extra hour on to some jobs
tested on dbatools verion 0.9.490
#reproduce
I've been able to reproduce this using the logic from Get-JobHistory
$DurationInSeconds = ($execution.RunDuration % 100) + [int]( ($execution.RunDuration % 10000 ) / 100 ) * 60 + [int]( ($execution.RunDuration % 1000000 ) / 10000 ) * 60 * 60
where runduration in this case is the equivalent of 1 hours 56 minutes 14 seconds
$runduration = 15614
The current function logic returns:
Enddate: 25 October 2018 03:02:15
$durationinseconds = ($runduration  % 100) + [int]( ($runduration  % 10000 ) / 100 ) * 60 + [int]( ($runduration  % 1000000 ) / 10000 ) * 60 * 60
(get-date -date "2018-10-25 00:06:01.000").AddSeconds($durationinseconds)
using logic from Rob's post
https://sqldbawithabeard.com/2016/09/12/converting-sql-agent-job-duration-to-timespan-using-powershell/
[timespan]$durationinseconds2 = ($runduration).tostring().padleft(6,'0').insert(4,':').insert(2,':')
(get-date -date "2018-10-25 00:06:01.000").AddSeconds($durationinseconds2.TotalSeconds)
returns
25 October 2018 02:02:15
which is the expected result based on sql agent job history

I observed this issue today with build 0.9.777 on at least one server out of 100 that I queried, and was wondering why this bug report appears to be closed as stale / won't fix?

Thanks for re-opening.  I re-checked my results; in a query of one job on each of 86 instances, 16 reported incorrect Duration and EndDate.  But it's not always a one hour difference; sometimes it's a difference of just one minute.

As @NickGuy1 mentioned in his original bug report, the formula for $DurationInSeconds returns incorrect values in some cases.  If the digit in the "tens" position of either seconds or minutes (possibly hours also) is a 5 and any digits are greater than zero, an incorrect result is returned.  Input of "50" seconds returns output of 50 seconds; input of 51 seconds returns output of 111 seconds (instead of 51).  Input of 50 minutes returns 3000 seconds; input of 51 minutes returns 6660 seconds (instead of 3060).

Submitted pull request.
https://github.com/sqlcollaborative/dbatools/pull/5157

fantastic, thank you, @sqlgb!


diff of cftime.Datetime

What happened?
A cftime variable returns a timedelta64[ns] when calling diff / + / - and it can then not be added/ subtracted from the original data.
What did you expect to happen?
We can add cftime timedeltas.
Minimal Complete Verifiable Example
import xarray as xr

air = xr.tutorial.open_dataset("air_temperature", use_cftime=True)

air.time + air.time.diff("time") / 2

MVCE confirmation

[x] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[x] Complete example — the example is self-contained, including all data and the text of any traceback.
[x] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[x] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
air.time.variable.values[1:] - air.time.variable.values[:-1]

returns array([datetime.timedelta(seconds=21600), ...]) but then
xr.Variable(("time",), np.array([datetime.timedelta(0)]))

returns a dtype='timedelta64[ns]' array.
Anything else we need to know?

See upstream PR: xarray-contrib/cf-xarray#441
Similar to #7381 (but I don't think it's the same issue, feel free to close if you disagree)
That might need a special data type for timedeltas of cftime.Datetime objects, or allowing to add 'timedelta64[ns]' to cftime.Datetime objects
The casting comes from

https://github.com/pydata/xarray/blob/d8ec3a3f6b02a8b941b484b3d254537af84b5fde/xarray/core/variable.py#L366
https://github.com/pydata/xarray/blob/d8ec3a3f6b02a8b941b484b3d254537af84b5fde/xarray/core/variable.py#L272
Environment

INSTALLED VERSIONS
commit: d8ec3a3f6b02a8b941b484b3d254537af84b5fde
python: 3.10.9 | packaged by conda-forge | (main, Feb  2 2023, 20:20:04) [GCC 11.3.0]
python-bits: 64
OS: Linux
OS-release: 5.14.21-150400.24.63-default
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_GB.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.12.2
libnetcdf: 4.9.1
xarray: 2023.2.1.dev20+g06a87062
pandas: 1.5.3
numpy: 1.23.5
scipy: 1.10.1
netCDF4: 1.6.2
pydap: installed
h5netcdf: 1.1.0
h5py: 3.8.0
Nio: None
zarr: 2.13.6
cftime: 1.6.2
nc_time_axis: 1.4.1
PseudoNetCDF: 3.2.2
iris: 3.4.1
bottleneck: 1.3.6
dask: 2023.2.1
distributed: 2023.2.1
matplotlib: 3.7.0
cartopy: 0.21.1
seaborn: 0.12.2
numbagg: 0.2.2
fsspec: 2023.1.0
cupy: None
pint: 0.20.1
sparse: 0.14.0
flox: 0.6.8
numpy_groupies: 0.9.20
setuptools: 67.4.0
pip: 23.0.1
conda: None
pytest: 7.2.1
mypy: None
IPython: 8.11.0
sphinx: None

cc @spencerkclark @znicholls

cc @spencerkclark @znicholls

Legend thanks

@mathause

That might need a special data type for timedeltas of cftime.Datetime objects, or allowing to add 'timedelta64[ns]' to cftime.Datetime objects

I think this might be related:

https://github.com/numpy/numpy/issues/15479#issuecomment-1399292370


Installation gets stuck on<EMAIL_ADDRESS>

While installing the package via npm, it gets stuck on the following:
[   ...............] \ loadDep:tape: sill resolveWithNewModule<EMAIL_ADDRESS>checking installable status
Can you please update on this?
Thanks.

@r12543 sounds like an npm bug, and cant reproduce -- let me know if you are still encountering this


[BUG] - Node 1.33.0 in P2P mode does not proceed after peer selection with host-addr <IP_ADDRESS>

External
Area
Cardano-Node Peer 2 Peer
Summary
Running node 1.33.0 in P2P mode and a set host-addr (listen-addr) to <IP_ADDRESS> does not proceed after the initial peer selection from the ledger. It just hangs - waiting.
Steps to reproduce

Enable/Set all the P2P configs
Start the node with the parameter --host-addr <IP_ADDRESS>

Expected behavior
The node should continue to establish connections to ledger peers also when the local host address is set to <IP_ADDRESS>. This can be used just for a passive node, or a node that is only doing transactions, not a relay-node.

If you are giving the host address <IP_ADDRESS> it will not be able to connect to any peers in the ledger because they are not reachable over the loopback interface.

Makes total sense yes, thx for the reply!

Not to mention that the <IP_ADDRESS> nonsense hurts the Internet and is better avoided. The localhost address is ::1.

It doesn't hurt my local lan behind my firewall/router/nat. 😄


ocaml modules needed for XAPI (XenServer)

Most of the comment to PR5529 still applies: thank you; there are evaluation error; attribute paths are redundant (ocamlPackage.ocaml_omd); several packages are already there.

@vbgl, thanks, I've renamed the packages, and tried to remove the duplicates.
Just for me, is there a quick way to evaluate and build all new packages of a commit at once?

Maybe nox-review? I think that is what our Travis CI is using. https://github.com/madjar/nox

@vbgl, thank your very much for efforts of reviewing the new packages! I went through the list again and removed packages that are already in nixpkgs. I also tried to apply changes according to your comments.
Concerning the change from fetchurl to fetchFromGithub, is there a tool to do the conversion automatically, because there seem to be a lot of packages throughout nixpkgs that are affected?
Also, would you be fine with the changes in #8705 ?

Concerning the change from fetchurl to fetchFromGithub, is there a
tool to do the conversion automatically

I’ve got no idea. I’d just do it lazily, when a package breaks or is
updated. Or when adding a new package.

Also, would you be fine with the changes in #8705 ?

Not at all. It looks like a random and massive breaking of the nixpkgs API.

So would it be possible to change to fetchFromGithub lazily in further updates as well, just as there are so many packages involved to get XAPI in? Maybe at the same time the packages could be changed from stdenv.mkDerivation to buildOcaml as well.
About #8705, just for clarification, are you objecting the renaming in general, or just the way I went about doing it? In the first case, are there any naming guidelines that I could follow? In the second case, do you know of a way of introducing deprecation warnings for the old names and leave them as links to the new names?

So would it be possible to change to fetchFromGithub lazily in
further updates as well, just as there are so many packages involved
to get XAPI in?

Are you suggesting that there are too much packages involved in this PR
to go through all of them?

do you know of a way of introducing deprecation warnings for
the old names and leave them as links to the new names?

No (but there is a hint at the bottom of all-packages.nix). Maybe you
should ask on the mailing-list.

(triage) status?

Closing as abandoned.


Move defconfig and device tree from meta-xt-rcar to product layer

Could you please fix the commit descriptions?
We don't allow lines longer than 80 characters for the commit messages, and no more than 70 for the commit captions

I fully support idea to relocate *.dts but I see that incorrect DTS is used for KF (*-kf-dom?.dts). Need to take into account changes from xen-troops/meta-xt-rcar#19. Explanation is provided in PR.

fixed and rebased

Wrong content for *-kf-domd.dts - it's not DTS, it's domd.cfg.
Wrong content for *-kf-xen.dts - it is taken from REL7.0 which doesn't work for KF. We need to take it from prod-devel branch master.

it has been built and tested at KF

regarding *-kf-xen.dts - it has been taken from meta-xt-rcar (branch master)

I was able to run prod-devel-rcar domD+domU on KF with first two commits and fixed domd.cfg.
So, please:

remove last commit (domu.dts)
fix domd.cfg related comit (replace domd.cfg with proper one and remove domu.cfg)
add ulcb-ab.dtsi to first commit

After that, (and removal or ulcb-ab.dtsi from xt-rcar #23) we are ready to merge.

Reviewed-by: Ruslan Shymkevych<EMAIL_ADDRESS>Please merge it with https://github.com/xen-troops/meta-xt-rcar/pull/23


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In ab2611a, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7200 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in e15db79.


TaskAssignments panel MVP refactoring & bugfix test migration

Migrating several selenium bugfix tests we have to presenter gwt unit tests.
To enable this, TaskAssignments panel had to be refactored to MVP.

+1 @jhrcek thanks a lot Jan!

+1, thanks @jhrcek

Thanks.
master: fdce6b1328cedcd3e41eb44ff6c9b901a30c9a6b


recordedit: Add link to 'create new' entry for out-bound foreign key

Extends #656 with a 'create new' entry button or link to the recordset directive. When using this link for the recordedit modal this link should open a new window or tab. However, from the recordset app, we might want this to replace the current window.

Here's the lines I added to recordedit's html page.

I would suggest taking the recordedit2-master branch and creating a new branch based off of that one. When you finish the implementation, we can merge it back into the recordedit2-master branch.

To limit the scope, we will first add a link next to the peudo-column to allow users to create a new entry to be added in the domain table. This will just open recordedit in a new tab.


Module 4: Bolding or other markup errors

It seems that Module 4, under The Role of Continuous Integration & Testing --> Why Continuous Integration? there are some markup errors as I see a couple of "** **" markups, e.g.
Linus Torvalds, invented the git** **system and
Automated builds** **are run on as many variations of software
The repository must be monitored by a continuous integration server** **which runs scripted automation tests
The founding projects** **are:

Edit: Could not figure out how to get the asterisk signs to appear they do on the text, so I used insert "code" above.

I ran into this a bit when translating some of the other modules. The output of the tool that converted to Markdown had some problems properly bolding text, so I had to update it manually.


[Crashed] trigger repl_curr_off!= master_repl_offset assert failure when having pending write cases

It is a master/slave use case, when there is a pending write situation, we are seeing the following assert failure:
replication.cpp:5714 'replica->repl_curr_off != g_pserver->master_repl_offset' is not true
This problem only occurs when there are pending client writes. If there are pending write operations, and when repl_curr  happens reset to have the same value as repl_offset at a moment,  it triggers the assert failure.
This was discovered when we ran a migration use case. The details are as follows:

Load some cache on a slave/master server
Configure a second slave (a python script is executed for configuring and starting a second slave), etc.)
A master server crash occurs since there are pending writes when the code is validating the assertion above.

The fix is to wait until all pending writes have been completed before performing "ProcessPendingAsyncWrites". (see the MR).
Here is the part of the stacktrace collected from the master server:
:16:M 24 Oct 2022 11:00:11.086   audit: receive "psync ea81fbf568320eb1bfbf5219940390f363c8cceb 1" from trusted network, client: <IP_ADDRESS>:30385(:0), db:0
1:16:M 24 Oct 2022 11:00:11.086 * Replica <IP_ADDRESS>:6379 asks for synchronization
1:16:M 24 Oct 2022 11:00:11.086 * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for 'ea81fbf568320eb1bfbf5219940390f363c8cceb', my replication IDs are '3637bc8d4bedc4c5fe3e118da629b05e1552230c' and '0000000000000000000000000000000000000000')
1:16:M 24 Oct 2022 11:00:11.086 * Starting BGSAVE for SYNC with target: disk
1:16:M 24 Oct 2022 11:00:11.088 * Background saving started
1:16:M 24 Oct 2022 11:00:11.088 * flushReplBacklogToClients: replica->repl_curr_off=11473417814; g_pserver->master_repl_offset=11473417814
=== KEYDB BUG REPORT START: Cut & paste starting from here ===
1:16:M 24 Oct 2022 11:00:11.088 # === ASSERTION FAILED ===
1:16:M 24 Oct 2022 11:00:11.088 # ==> replication.cpp:5714 'replica->repl_curr_off != g_pserver->master_repl_offset' is not true
------ STACK TRACE ------
Backtrace:
/opt/redis/redis-server <IP_ADDRESS>:6379(flushReplBacklogToClients()+0x2bf) [0x62f5cf]
/opt/redis/redis-server <IP_ADDRESS>:6379(processCommand(client*, int)+0xde5) [0x67dac5]
/opt/redis/redis-server <IP_ADDRESS>:6379(processCommandAndResetClient(client*, int)+0x65) [0x5d9685]
/opt/redis/redis-server <IP_ADDRESS>:6379(processInputBuffer(client*, bool, int)+0x174) [0x5dc2a4]
/opt/redis/redis-server <IP_ADDRESS>:6379(processClients()+0xc9) [0x5dd799]
/opt/redis/redis-server <IP_ADDRESS>:6379() [0x6a27b2]
/opt/redis/redis-server <IP_ADDRESS>:6379(beforeSleep(aeEventLoop*)+0x16e) [0x59bc4e]
/opt/redis/redis-server <IP_ADDRESS>:6379(aeProcessEvents+0xe8) [0x597858]
/opt/redis/redis-server <IP_ADDRESS>:6379(aeMain+0x37) [0x59b947]
/opt/redis/redis-server <IP_ADDRESS>:6379(workerThreadMain(void*)+0x64) [0x6a2844]
/usr/lib64/libpthread.so.0(+0x8f4b) [0x7fab63752f4b]
/usr/lib64/libc.so.6(clone+0x3f) [0x7fab6368a7ef]

@JohnSully @benschermel John and Ben, i found another crash which happens only where there are pending write on the client, and it triggers an assert failure. Please review the fix. Detail description can be found in the MR. Thank you.

@JohnSully @benschermel John and Ben, based on our discussion, I changed to using LL_DEBUG. Please merge it.  Thank you.

commits: https://github.com/Snapchat/KeyDB/commit/560d8a839cb2c9c37cc8c919dee0435122e746ee https://github.com/Snapchat/KeyDB/commit/496bc38fda87face2601173af9357275476b0657


chore: [POC] dataTree split

Description
Fixes https://github.com/appsmithorg/appsmith/issues/17763
Type of change
performance imporvement
How Has This Been Tested?
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Older POC before linting performance optimization was merged.
Moved changes here https://github.com/appsmithorg/appsmith/pull/18080


UMake Actions for Android

Added AndroidKeyAction to automate the signing of keys for Android.
Added IncrementBundleVersion to increment the bundle version, automating the steps of release for google play.
Added possibility of changing app version using UMake's version

nice


[CODING CHALLENGE] Habitat Suitability

Our changing climate is changing where key grassland species can live, and grassland management and restoration practices will need to take this into account.
In this project, you will create a habitat suitability model for Sorghastrum nutans (or a plant species of your choice), a grass native to North America. In the past 50 years, its range has moved northward. The model will be based on combining multiple data layers related to soil, topography, and climate. You will also demonstrate the coding skills covered in this class by creating a modular, reproducible workflow for the model.
You will create a reproducible scientific workflow
Your workflow should:

Define your study area:  If you are using Sorghastrum nutans, you can download the USFS National Grassland Units and select at least 2 as study sites.
Fit a model: For each grassland:

Download model variables as raster layers covering your study area envelope, including:

At least one soil variable from the POLARIS dataset
Elevation from the SRTM (available from the earthaccess API)
At least one climate variable from the MACAv2 THREDDS data server. Your project should compare two climate scenarios of your choice (e.g. different time periods, different emission scenarios). You can find a tutorial on how to access these climate data on earthdatascience.org

Calculate at least one derived topographic variable (slope or aspect) to use in your model. You probably will wish to use the xarray-spatial library, which is available in the latest earth-analytics-python environment (but will need to be installed/updated if you are working on your own machine). Note that calculated slope may not be correct if you are using a CRS with units of degrees; you should re-project into a projected coordinate system with units of meters, such as the appropriate UTM Zone.
Harmonize your data - make sure that the grids for each of your layers match up. Check out the ds.rio.reproject_match() method from rioxarray.
Build your model. You can use any model you wish, so long as you explain your choice. However, if you are not sure what to do, we recommend building a fuzzy logic model (see below).

Present your results in at least one figure for each grassland/climate scenario combination.

If you are unsure about which model to use, we recommend using a fuzzy logic model
To train a fuzzy logic habitat suitability model:

Research S. nutans, and find out what optimal values are for each variable you are using (e.g. soil pH, slope, and current climatological annual precipitation).
For each digital number in each raster, assign a value from 0 to 1 for how close that grid square is to the optimum range (1=optimal, 0=incompatible).
Combine your layers by multiplying them together. This will give you a single suitability number for each square. Check out this article about raster math for more info.
Optionally, you may apply a threshold to make the most suitable areas pop on your map.

You will be evaluated on your code AND how you present your results
I will use the following rubric:

Description
Maximum Points

GITHUB REPOSITORY
30

Project is stored on GitHub
3

The repository has a README that introduces the project
5

The README also explains how to run the code
5

The README has a DOI badge at the top
5

The repository has a LICENSE
2

Repository is organized and there are not multiple versions of the same file in the repository
5

Repository files have machine and human-readable names
5

CODE
120

The code runs all the way through using the instructions from the README
10

The code follows the PEP-8 style standard
10

The code is well-documented with comments
10

The code uses functions and/or loops to be DRY and modular
10

Any functions have numpy-style docstrings
10

The code makes use of conditionals to cache data and/or computations, making efficient use of computing resources
10

The code contains a site map for the US National Grassland(s) used (1 ugrad, 2+ grad)
10

For each grassland (ugrad 1, grad 2+), the code downloads at least model variables as raster layers: soil, elevation, and climate (ugrad 1, grad 2 scenarios)
10

The code correctly calculates a derived topographic variable
10

The code harmonizes the raster data
10

For each climate scenario (1 ugrad, 2+ grad), the code builds a habitat suitability model
10

For each grassland/climate scenario combination, the code produces at least one (sub)figure displaying the results
10

Any unfinished components have detailed pseudocode or a flow diagram explaining how they could be finished in the future, and or a complete bug report explaining the problem
up to 90 points, in place of other categories

WRITTEN ANALYSIS
50

The notebook contains a project description
10

The notebook contains a researched site description
10

The notebook contains a data description and citation for each data source
10

The notebook contains a model description
10

The notebook contains a headline and description for each figure
10

Keep your eyes out for videos!
I won’t release a full demo of this, but you will have videos on writing pseudocode, accessing data sources, and any tricky problems that come up.

/teamassign @earthlab-education/ea-students


[ShadowContainer][Docs] Simple improvement for easier reading and understanding

GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?
We have the docs.
What is the new behavior?
Simple improvement for easier reading and understanding.
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[x] Docs have been added/updated
[ ] Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal)
[ ] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

https://github.com/Mergifyio backport legacy/3x


Change the default font

If it is possible, an option to change the default font can be added so that for languages such as Persian and Arabic, the tasks can be written in the desired font.
The first screenshot from Errands use default Font

The second screenshot from Librewiter uses Vazirmatn Font

Fonts are handled at the system level, and I can't change them. If you want to use different font, you need something like GNOME Tweaks for GNOME and for KDE, I belief, it's in system settings.

I'll see, maybe I can add an option

I've decided not to add font selection. It's must have for document / text editor, but for todo app, i don't think is necessary.


Add helper functions for options wrapped in a TaskResult

Proposed Changes
Add util functions to work with Task<Result<'success option, 'error>> values.
This will close #184
Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] Build and tests pass locally
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added the necessary documentation (if appropriate)

I'm unsure about the last one.
Further comments
I wonder if there are similar enhancement opportunities in other modules. Not only working with options wrapped in task results but also options wrapped in normal results. Also, potentially applying this to additional functions (other than requireNone and requireSome). I also wonder if a new module named TaskResultOption should be created to complement the existing TaskResult and TaskOption modules.

I wonder if there are similar enhancement opportunities in other modules. Not only working with options wrapped in task results but also options wrapped in normal results. Also, potentially applying this to additional functions (other than requireNone and requireSome).

Yeah I would say add these similar things to the AsyncResult and JobResult modules.
While there is quite a bit of require type functions I think it's fine on this pass to just do the requireNone requireSome cases.

I also wonder if a new module named TaskResultOption should be created to complement the existing TaskResult and TaskOption modules.

We do have this module already but it's semantics try to keep the happy path of Ok(Some foo) and not folding into just Ok(foo) so I'm unsure how it would fit within that modules concepts.


Failed to save Steam session key.  Steam account will not stay logged in

Hi,
Trying to run a prefill and I get the following error:
$ ./SteamPrefill prefill --debug
[1:09:35 PM] Starting login!
A Steam account is required in order to prefill apps!
Please enter your Steam account name :
Please enter your Steam password. (Password won't be saved) : ************
SteamKitDebug - ServerList: Resolving server list
SteamKitDebug - ServerList: Server list provider had no entries, will query SteamDirectory
SteamKitDebug - ServerList: Resolved 200 servers
SteamKitDebug - ServerList: Next server candidate: <IP_ADDRESS>:27017 (Tcp)
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/TcpConnection: Connecting to <IP_ADDRESS>:27017...
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/TcpConnection: Connected to <IP_ADDRESS>:27017
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/EnvelopeEncryptedConnection: Got encryption request. Universe: Public Protocol ver: 1
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/EnvelopeEncryptedConnection: Encryption result: OK
2FA required for login.  Please enter your Steam Guard code from your authenticator app : SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/TcpConnection: Socket exception occurred while reading packet: System.IO.IOException: Connection lost while reading packet header.
 ---> System.IO.EndOfStreamException: Unable to read beyond the end of the stream.
   at System.IO.BinaryReader.InternalRead(Int32 )
   at System.IO.BinaryReader.ReadUInt32()
   at SteamKit2.TcpConnection.ReadPacket()
   --- End of inner exception stack trace ---
   at SteamKit2.TcpConnection.ReadPacket()
   at SteamKit2.TcpConnection.NetLoop()

SteamKitDebug - ServerList: Next server candidate: <IP_ADDRESS>:27017 (Tcp)
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/TcpConnection: Connecting to <IP_ADDRESS>:27017...
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/TcpConnection: Connected to <IP_ADDRESS>:27017
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/EnvelopeEncryptedConnection: Got encryption request. Universe: Public Protocol ver: 1
SteamKitDebug - 3ad58eb5483b441482209f12a1ae0e9e/EnvelopeEncryptedConnection: Encryption result: OK
[1:10:23 PM] Logged into Steam
[1:10:33 PM] Failed to save Steam session key.  Steam account will not stay logged in...
[1:10:33 PM] Steam session initialization complete!

[1:10:35 PM] Prefill complete!
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  Prefilled 65 apps in 01:00.26

   Updated │ Up To Date
  ━━━━━━━━━┿━━━━━━━━━━━━
      0    │     65

[1:10:35 PM] Disconnected from Steam!

after that session finishes, trying again produces:
$ ./SteamPrefill prefill --debug
[1:28:57 PM] Starting login!
System.NullReferenceException: Object reference not set to an instance of an object.
  at async Task SteamPrefill.Handlers.Steam.Steam3Session.ConfigureLoginDetailsAsync()
  at async Task SteamPrefill.Handlers.Steam.Steam3Session.LoginToSteamAsync()
  at async Task SteamPrefill.SteamManager.InitializeAsync()
  at async ValueTask SteamPrefill.CliCommands.PrefillCommand.ExecuteAsync(IConsole console)
[1:28:57 PM] Already disconnected from Steam

This is with:
$ ./SteamPrefill --version
v1.9.1

Removing the "Config/account.config" file allows me to run a prefill, but doesn't save the session key.
I have manually nuked all sessions in the Steam Guard a few days ago when this first appeared.

I have the same exact issue, same version. I'm running it on Unraid.

I am having the same issue

Looks like this is not isolated to just SteamPrefill,  ArchiSteamFarm is running into the same issue as well:
https://github.com/JustArchiNET/ArchiSteamFarm/issues/2840
Possibly related to : https://github.com/SteamRE/SteamKit/pull/1129

The same issue seems to be also at since version 1.8.4, perhaps even earlier?

This issue is due to Steam changing how they handle authentication going forward,  they will no longer issue or accept "login keys".
I've played around with the changes in SteamKit2 that will handle the auth change, and have the most basic of scenarios logging in correctly.  Even though its working, I'd rather take the time and make sure that I understand the changes 100%, and to make sure I don't introduce any new bugs with these changes.  So stay tuned.

@tpill90 is already a beta out? We're hosting our LAN-Party starting tomorrow and would need some prefill 🥲

No beta build yet, however there is a workaround.
The current workaround is to delete the account.config located in the Config directory in between runs.  You'll still have to enter your credentials again every time, however you will still be able to run the prefill with your currently selected apps.

Fix has been released in  v2.0.0

Thank you 😊

Working as expected, thank you for getting the fix pushed out.


WIP Attempt to Migrate to Electron Forge + GitHub Actions for CI/CD

This commit attempts to migrate our deployment process from a manual one to an automated CI/CD process using Electron Forge (https://www.electronforge.io/) to manage signing, notarizing, and building the app. Doing this will provide these benefits:

Easier support for Auto Updates (https://www.electronforge.io/advanced/auto-update)
Automating the code signing (https://www.electronforge.io/guides/code-signing)
Sign and build on every push to main via Github Actions (https://github.com/jsoma/action-electron-forge)

Here's the primary steps I took thus far (though I branched off in a few different directions for various explorations I can walk through if interested):

Cloned the Webpack + Typescript sample app (https://www.electronforge.io/templates/typescript-+-webpack-template) to see the files needed to build a project with Forge.
Compared the configuration in our app with the sample app and migrated over the key details. The big things I did here are:

Created forge.config.js which contains the configuration for forge. Right now, all of the stuff related to signing and notarizing is commented out, as are some of the icon image paths (was mainly trying to get the thing to build first).

Also note that this file currently only covers the various platform makers and github publication. It references our existing webpack configuration files, but it doesn't implement any of the webpack configuration within Forge — this is possible, but problematic because TypeScript.
I have a separate fork locally that I can share which has all of the webpack configuration directly embedded in the forge config if you're interested in checking that out.

Updated location of main in package.json to point to our webpack configuration at webpack.config.main.prod.ts and removed the manual build configurations. Note the original package.json file is preserved in package-old.json for easier comparison.

Added .github/workflows/config.yml which installs build dependencies and manages the signing and notarizing as part of CI/CD. There are some keys needed here as well.
Added add-osx-cert.sh , a shell script that sets up a temporary keychain on a macOS machine, imports a certificate into it, and configures it for code signing as part of CI/CD. The github action mentioned above calls this.
Temporarily commented out the environment check script because for some reason it wasn't properly distinguishing between production and development. I traced the issue to the call in webpack.config.renderer.prod.ts (line 19) and the decision to run the prod vs. dev webpack configuration which is made on lines 18 and 123 in forge.config.ts.

We're 90% of the way there, but I keep coming back to the issue that it doesn't like that we're using ESM syntax for imports and exports in main.ts even though we can use it just fine in all of our other files. This seems like an easy thing to fix, but each strategy I try creates a new problem with import / export compatibility because we're ultimately using a mix of ESM and require syntax in certain files.
Happy to go deep on any of this as I'd love to see this thing make it across the finish line! Unfortunately I think I've taken it about as far as I can without further help!

. This seems like an easy thing to fix, but each strategy I try creates a new problem with import / export compatibility because we're ultimately using a mix of ESM and require syntax in certain files.

this is the entire bull case for deno


Add project shield images to README

Travis CI provides a "shield" or "badge" image that quickly indicates to the reader the pass/fail state of the current project's build. Via websites like shield.io, there are many more badges to be had.
Because we want our users to glean as much information as they can about us at a single glance, we should implement as many of these shields as is prudent. The shield integrations take a bit of finagling, however, so this can be put off until a later date.

We now have a Travis CI badge and a Coveralls badge. We are in the process of adding license, code quality, and download count badges.


[Service Bus] Run live tests in the canary region

Similar to what we did for event-hubs... https://github.com/Azure/azure-sdk-for-js/pull/11318

Triggered pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=559073&view=results


feat(helper): persistHierarchicalRootCount: true

BREAKING CHANGE: the option persistHierarchicalRootCount no longer exists. The default behaviour is now the same as used to be with persistHierarchicalRootCount: true
FX-3185

by the way this means that https://github.com/algolia/instantsearch/pull/6445#issuecomment-2493209337 is now fixed for hierarchical in all cases, not just when the flag is set (because the default has changed)


[JOSS Review]: No comparison with other algorithms and no data-tests

The provided paper includes some considerations about how the computations should be made, but there is no comparison with other existing tools. Also test suite do not include data-based tests. That means that subsequent versions could also change the result of the simulation and it could not be tracked.
Changing of physics results in different code versions is a major problem of simulation software in particle physics so I think there should be an effort to mitigate that. As well as a chapter in the paper about the comparison.

@gerudo7  I think if we solve our previous issues about checking all input files and checking the resulting distributions in the Python testing, that will mostly satisfy this issue.
Also for testing the Python we can probably just make output data files to check distributions instead of checksums on the .pngs.

@gerudo7 for comparison with other algorithms I can try to set up a comparison with Geant4 which is basically the only other code I know of that implements something like the NR recoils after capture.

Noting here that #77 added tests for all of the inputs and #80 added tests for resulting distributions, so I believe the only thing left is the Geant4 comparison testing, which is in progress.

We now have a comparison with G4 and are testing against G4 v4.7.3 in the CI. This was added in PR #98


FFMPEG Camera causes HASSIO UI to hang

Using FFMPEG platform cause HASSIO web UI to hang. Same issue as reported in https://community.home-assistant.io/t/hassio-and-cameras/23811 issue still exists in latest version of HASSIO.

similar to https://github.com/home-assistant/home-assistant/issues/7572


HSEARCH-2069 SortableField on id field will make initialization crash if the entity is @IndexedEmbedded in another

Follow up for https://github.com/hibernate/hibernate-search/pull/956
https://hibernate.atlassian.net/browse/HSEARCH-2069

Hey @fenrhil, could you sign the JBOSS contributor license agreement if you haven't done so? It's a simple web app living at http://cla.jboss.org/. Thanks!

Hi @gunnarmorling , I already did quite a while ago, in the context of this pull request: https://github.com/hibernate/hibernate-search/pull/523
So I thinks everything's OK. Let me know if it isn't!

Ok, cool, thanks!

Thank @gunnarmorling I'll fix the test and re-open this pull request


Open Source Contributions Importance

Do you think open source development can help in career or getting a job ? (insta :-rohitb1023)

Yes Rohit, it is incredibly helpful.
Checkout this video where I talk about how it helps.


Update/Add uv/uvx

Tool name
uv
Tool license
MIT
Add or update?

[X] Add
[ ] Update

Desired version
latest
Approximate size
No response
Brief description of tool
uv and uvx are much faster alternatives to pip, poetry and other python package managers
URL for tool's homepage
https://docs.astral.sh/uv/
Provide a basic test case to validate the tool's functionality.
installing a package with a pip compatible command:
`uv pip install ...`
building a package (similar to pipx, so no need to specify environment, will auto-create new one):
`uvx --from build pyproject-build --installer uv`

Platforms where you need the tool

[X] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[X] macOS 14
[X] macOS 14 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
# for macos and linux (with specific pinned version)
curl -LsSf https://astral.sh/uv/0.4.2/install.sh | sh
# for windows
powershell -c "irm https://astral.sh/uv/0.4.2/install.ps1 | iex"

Tool installation time in runtime
1s
Are you willing to submit a PR?
yes

Hey @eavanvalkenburg!
We do not want to add any tools currently to the macOS images due to the issues with the disk space available.

ah thats a shame, let me know if that changes at some point, I think the installed size is quite small, but not sure exactly much

uv is a really powerful tool that can save minutes in Python package installations. I have 2+ min installations seen going to <5 seconds.
Having uv pre-installed might help the adoption of the installation method, and therefore reduce overall runtime. And that helps both the environment 🌳 and GitHub 💰!

I wondered about opening a similar issue a few months ago, but then I saw pipx wheel is 78kB while uv is 15MB.
(Also, is curl -LsSf https://astral.sh/uv/0.4.2/install.sh | sh more efficient than pipx install uv given pipx is already installed ?)


gio: Only assign to GError**s if they're not NULL

Fixes https://github.com/gtk-rs/gtk-rs-core/issues/57

Thanks!


[config] Cleanup and SafetyRules prep

This PR will serve to major purposes:

Eliminating cruft due to genesis being the source of truth (recent work) and cruft in general
Moving appropriate data into a place that makes sense from a SafetyRules perspective

The specifics:

Cleaning up dynamic-config-builder junk
Moving consensus_keypair from consensus config to test config
Eliminating consensus_peers from consensus_config
Eliminating the need for network_peers for validator networks
Generating a ValidatorSet during validator generation rather than network / consensus peer configs
Deleting consensus peer config

:umbrella: The latest upstream changes (presumably 0f97648bd9df4fa8e5da2eadc34d164e75727529) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra delegate+

:v: @davidiw can now approve this pull request

@dmitri-perelman, thanks for the review!
Updated to include testing method. I fixed our local running of docker images.
The smoke tests are actually really good at testing these type of things as well.
I did try to use the cluster testing but hit some issues with the environment setup.

@bors-libra r=dmitri-perelman

:pushpin: Commit 0dd9098 has been approved by dmitri-perelman

:hourglass: Testing commit 0dd9098570afa44ad4cbbf7cb28403b17e5ee774 with merge a7ef849dff190466ef10518157ded26a31d278ab...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: dmitri-perelman
Pushing a7ef849dff190466ef10518157ded26a31d278ab to master...

Btw, looks like a nice cleanup, thanks!


[WIP] Implement SE-0193

@airspeedswift @milseman @lorentey @lancep Just a heads-up that I'm planning on landing this shortly, and it touches a lot of stdlib files. Do you have any big changes in flight I should wait for?

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - e96e819de3513ee993b99628059d77c9b383e11e

Build failed
Swift Test Linux Platform
Git Sha - e96e819de3513ee993b99628059d77c9b383e11e

@swift-ci Please test source compatibility

I’ll fix the other comments and drop the default argument change for now. We can discuss it separately.


[Feature]: Make the publish command update the site

Description
The question here is do we really need a separate update command?
The only difference between publish and update is that update needs the published site object ID. Can we automate it so that the update command is not needed at all?
For example, we could store the site object ID in .walrus-site.yaml after publishing the site the first time and read it on publishing the site the second time. Actually, Walrus config already has system_object field which could be used for that purpose.
This change could simplify things and consequently improve DX.
Component
site-builder
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Hey @kkomelin , thanks for the feature request!

Actually, Walrus config already has system_object field which could be used for that purpose.

the system_object in the walrus config is Walrus's system object, which is required to look up committee information, so we could not use that. In general, the Walrus config is required to configure the Walrus CLI, and therefore is separate from Walrus Sites.

For example, we could store the site object ID in .walrus-site.yaml after publishing the site the first time and read it on publishing the site the second time

this could work. I like the separation between publish and update, but we can add something along these lines at some point. Just FYI, at the moment we are working on higher priority issues unfortunately, so it may take a while.
One minor problem I see is that we are introducing a Walrus-Sites-specific "magic" file, which is not produced by the framework that built the site, and therefore may be wrongly interpreted by other tooling (for example, if you publish both to walrus sites and to a conventional server, the .walrus-site.yaml will be included in the latter).

For now, I've developed a custom script which publishes the app on the first run, sores the site object ID in .env.local and updates the app on the subsequent runs https://github.com/kkomelin/sui-dapp-starter/blob/main/packages/frontend/scripts/walrus-site-deploy.cjs


Weather fetching api, added env

#259

Hey @kashnx, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

Hey @kashnx, Closing the PR as we are already having the similar issue under discussion opened before you and PR for the same is also under discussion, so to avoid duplicate PR's, am closing this PR.

@kashnx ,I wanted to reach out and let you know that we have decided to close your pull request.🙇
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


More control over Windows 11 Context Menu use

Description of the new feature / enhancement
As well as "default and extended" vs "extended only" options, it would be really great to extend the choices available for users, so that the new context menu doesn't land up getting clogged up again....

Windows 11 menu only, would also not have it on the extended menu
Legacy (Show More Options) menu only which would use default and extended menu
Both which is effectively the same as the current "default and extended" option
Extended Only mode which is as per the current "extended only" option

Secondly, it would be good to offer the option to keep all the PowerToys menu items in a submenu, both on the Windows 11 menu and on the legacy menu.
This approach would allow users to keep lesser used features on the legacy menu and off the Windows 11 main context menu, to simplify the legacy menu if it is on the Windows 11 menu, cope with users whose 3rd party file managers need the legacy entries...
Many more applications are now explicitly providing the option to NOT have the entries on the legacy menu, and it would be great if PowerToys had the same.
Scenario when this would be used?
User wants to keep new Windows 11 menu just focussed on most used features and have lesser used features in the "Show More Options" menu.
User wants the Show More Options menu to only show those items (other than system commands) that are not available on the main Windows 11 menu.
User wants to group all PowerToys items together on the menu, so that the menu length does not grow too much.
Supporting information
No response

/dup #33

Can you clarify which this specifically duplicates? I have done a search and can't find these specific feature requests. If there is one which is "similar" then I am happy to add these as commentary to it.

Is this issue about the ability to change the context menu generally, or just how the PowerToys utilities show up in the context menu?

Specifically how the PowerToys utilities show up in the context menu, so extending the menu for this settings (example using PowerRename)...

and adding a setting in the Global section to either group (or not) all PowerToys menu items into a sub-menu.

How is this issue different from #21719?

OK, fair enough :-) I had completely forgotten that I'd done that one --- it was quite a while ago!
I'll copy the new one so it can be closed (if not already closed) and will spend some time to copy across some of the additional ideas/clarifications as comments in the original request.


refactor: use Uint8Array instead of Buffer

Webpack 5 does not include Buffer polyfill anymore. This PR should make this library easier to use in any JavaScript app since Uint8Array works everywhere.

Thanks for the PR @SamSamskies
This seems directionally great, but I would prefer using @digitalcredentials/base58-universal instead of base58-universal as it seems more maintained and more popular than the fork.

Hey @ruigomeseu, base58-universal only ships an esm module and I'm not sure exactly why, but your tests fail when calling the decode function. It throws an error ReferenceError: Cannot access 'alphabet' before initialization which refers to this line. This seems to be the reason the fork was created https://github.com/digitalcredentials/base58-universal/pull/1.

It looks like there's PR https://github.com/digitalbazaar/base58-universal/pull/4 approved to fix the issue in base58-universal. It was approved on Oct 21st, but still hasn't been merged.

Another alternative package that gets the job done https://www.npmjs.com/package/base58-js.

That package seems good to me 👍

Swapped out @digitalcredentials/base58-universal with base58-js.


Add a Gitter chat badge to README.md

Microsoft/SparkCLR now has a Chat Room on Gitter
@skaarthik has just created a chat room. You can visit it here: https://gitter.im/Microsoft/SparkCLR.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Hi @gitter-badger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


Port polyeval (CPU) into mops

can you rebase/merge this one?

Done!

This one is ready @Luthaf

@Luthaf all these small errors are also fixed in future PRs


Feature/search 1883 update search service version

The bamboo build has been completed successfully for this change
https://bamboo.alfresco.com/bamboo/browse/PLAT-ACSCOMHELM61-DI-3

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update README.md

Fixed Markdown formatting

Hey, thanks for fixing this. I honestly had forgotten about it having got caught up in other things, lol. Let me make an issue so I can assign it to this and then I'll merge your PR in a bit. Thanks a bunch!


Parity with simple-peer 9.10.0

These changes bring this fork up to date with recent changes in the upstream (cdad35fb2797c60b61689a539e420a1e3c4fa434, 0e70f43d51a4eae1eee9f6ca83e1ab5836d3775e).

good job @dmotz
this lib has saved my life many times over cause i needed bundler support.
hope this PR can be merged and pushed out to npm as a new release @mitschabaude
thank you both 🙏🙏🙏

Nice, will merge

Hi, so I looked at this in more detail and concluded that I'll do it in a slightly different way.
I didn't like that this PR introduced completely new commits, I'd rather be able to just keep merging the upstream simple-peer into this package while resolving any conflicts that may arise.
So I did just that, I pulled the current version of simple peer in. I also pushed an update to npm. From now on, I always want to use the same version number as simple-peer so that it becomes clear how up to date with it we are. This means that this time, there is a jump from version 1.0.0 to version 9.10.0 in the package

A thing I've changed to facilitate continuing updates is to remove the minified simplepeer.min.js, it's just unnecessary headaches to keep maintaining that. The minified file is in the npm package though.
New npm version of simple-peer-light is already published btw

I'll close this now, thanks a lot for helping me keep this library up to date!
I'll be happy to merge future "parity" PRs, but let's stay as close as possible to the commit history of upstream simple-peer.


treewide: set -u everywhere

2 years or so ago I made stdenv and cc-wrapper use set -u, which enormously helped with debugging. But I didn't want to change all of nixpkgs so I added lots of temporary set +u-ing.
Well, I think it's now time to bring the benefit to all of nixpkgs. Why? Because we have another big repo-wide refactor going on https://github.com/NixOS/nixpkgs/pull/72074. This will make that much easier to debug, and hopefully get some momentum going for stdenv tech debt fixing. Everyone chip in!
In particular, I think this is the easiest stdenv refactor we'd like to make, Why? This has the nice property that programs that continue to not fail have the same behavior. [Actually, this is  not true with trap to catch failures or no set -e, but we use set -e and still fail after trap-ing.] That means it's very easy to debug; no getting a bunch of things working only to find some deeper dependency was built wrong and needing to backtrack, and no needing to debug complex failures.
I swear there was an issue for thus, but I couldn't find it.
Hydra job: https://hydra.nixos.org/jobset/nixpkgs/bash-no-undef-vars#tabs-evaluations

How likely is it to break things and how much as been tested?

This should be also mentioned in the release notes as it can break out-of-tree nixpkgs.

Wow, is there no way to mark a PR draft after the fact?!?! Embarrising, GitHub.

Hydra reached the point where the legitimate failures were buried amidst all sorts of spurious failures. This makes it harder to use it. I think it might be ready to go to staging then, at least after this these newer evals get further? @globin @matthewbauer

https://hydra.nixos.org/eval/1552118?compare=1551936&full=1#tabs-now-fail here is a comparison to the base commit, which is a nixpkgs-unstable eval.

@FRidh that is a commit pushed post merge.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-weekly-14-hercules-ci-launch-performance-improvements-in-nixpkgs-single-dependency-kubernetes-clusters/4769/1

qt needs a fix: https://github.com/NixOS/nixpkgs/pull/73586#issuecomment-555380665

qtWrapperArgs is fixed with ef43c5f5d928758d15cd42b18454e7145a163331. Now there are issues left with the setup hooks of both plasma5 packages and kdeFrameworks packages.
pkgs/desktops/plasma-5/default.nix
pkgs/development/libraries/kde-frameworks/default.nix
Looked into this briefly, https://github.com/NixOS/nixpkgs/pull/73756

Actually my commit could not be enough, but @mic92's won't work either. The issue is bash says an undefined variable and and undefined variable are the same thing (which is terrible!!!).
The direct workaround is awful ${foo+${foo[@]}}, but thankfully there are other ways like ${#foo[@]} to get the same result.

Hmm, it appears this is not enough. For example wrapPython setup hook is running with +o nounset: https://github.com/NixOS/nixpkgs/commit/a6bb2ede232940a96150da7207a3ecd15eb6328c#commitcomment-36605469
In fact, when I comment out
https://github.com/NixOS/nixpkgs/blob/4c7a9a0a88ea6e8efe43661f215e0c5d32504f2e/pkgs/stdenv/generic/setup.sh#L1307-L1308
and try to build python3.pkgs.setuptools, it fails on trying to build xz:
/nix/store/aknix5zw9cj7hd1m3h1d6nnmncl1vkvn-multiple-outputs.sh: line 55: shareDocName: unbound variable

Indeed the work isn't done! https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh#L1307-L1308 needs to be guarded by IN_NIX_SHELL so it doesn't mess up normal builds.
I should have made an issue earlier when I realized this, but didn't have the time to immediately start fixing it.


Upload file works

You wrote "Fetching files hasn't been tested yet. It may not work.". Just wanted to say I tried the template plugin and it works! It's only needed to change the ansible remote_tmp variable to something like remote_tmp=/tmp/.ansible
Cool software, thank you, very very helpful!

@kototama do you want to send a PR for the README? would be a great easy commit.

@kototama just to clarify, do you mean that copying files to the target host or from the target host? Usually template copies from your local to the remote host.

Copying from local to remote works. Was it expected? I may have misunderstood the documentation.

I will be short in time to do that.

Copying a file from local to remote - uploading - is known to work.
The bit in the README is specifically about copying files from remote to local - downloading. For example, using the fetch module. I just tried it, and was not successful:
- name: fetch file
  fetch:
    src: /etc/resolv.conf
    dest: test.resolv.conf
    flat: true

    bootstrap: TASK [redis : fetch file] ******************************************************
    bootstrap: fatal: [redis1]: FAILED! => {"msg": "Unable to create local directories(/vagrant/vagrant/test.resolv.conf/redis1/etc): [Errno 13] Permission denied: b'/vagrant/vagrant/test.resolv.conf'"}
    bootstrap: fatal: [redis0]: FAILED! => {"msg": "Unable to create local directories(/vagrant/vagrant/test.resolv.conf/redis0/etc): [Errno 13] Permission denied: b'/vagrant/vagrant/test.resolv.conf'"}

I'm not sure if this is related to my vagrant setup or a problem with the plugin. I'll try to get it working, and if not successful, I'll update the README and open a tracking issue

Copying a file from local to remote - uploading - is known to work.
The bit in the README is specifically about copying files from remote to local - downloading. For example, using the fetch module. I just tried it, and was not successful:
- name: fetch file
  fetch:
    src: /etc/resolv.conf
    dest: test.resolv.conf
    flat: true

    bootstrap: TASK [redis : fetch file] ******************************************************
    bootstrap: fatal: [redis1]: FAILED! => {"msg": "Unable to create local directories(/vagrant/vagrant/test.resolv.conf/redis1/etc): [Errno 13] Permission denied: b'/vagrant/vagrant/test.resolv.conf'"}
    bootstrap: fatal: [redis0]: FAILED! => {"msg": "Unable to create local directories(/vagrant/vagrant/test.resolv.conf/redis0/etc): [Errno 13] Permission denied: b'/vagrant/vagrant/test.resolv.conf'"}

I'm not sure if this is related to my vagrant setup or a problem with the plugin. I'll try to get it working, and if not successful, I'll update the README and open a tracking issue

Update: it was indeed a problem with vagrant. I've verified that file downloading works as expected, and removed the note in the readme accordingly.

Update: it was indeed a problem with vagrant. I've verified that file downloading works as expected, and removed the note in the readme accordingly.


Create assets for tree

Acceptance Criteria

Create sprite assets for the above-ground portion of tree, in healthy state
The tree should be a multi-tile entity that takes up most of the screen when completely above ground (i.e between 15 to 30 tiles in height)
The tree should include a hole in it where the rabbit character will be placed

This is done!


Show more is throwing a 404 on sights

Steps to recreate...
• Go to any Destination
• Go to Sights pageScroll to end of listed sights • • Click 'Show More'
It attempts to load and then gives  404 in console

This is example request url: http://www.lonelyplanet.com/caribbean/sights.json?page=2
@mkunkel I guess it fails because of https://github.com/lonelyplanet/dispatch/commit/b0327005bb977f0be924a36ae4c9b71fdda6dbdf
Do you think I could add - "%.*/sights.json"? That should fix the problem, right?

@laserchicken seems legit, think you can get that fix in?

@jcreamer898 should I add $ anchor at the end or leave it as it is, I'm not sure...

@lemmiestone this is fixed, you can close the issue


fix eip 712

in the latest version many of the examples tests will fail, for example when doing yarn test in examples/dex:
 1) Dex
       getLiquidityPool works:
     Error: -32603: execution revert: Other("invalid currency id"): 0x000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001c4f746865722822696e76616c69642063757272656e63792069642229

@ntduan

ok seems like our mandala docker image is outdated, this works with latest acala node

UPDATE: false alarm
in the latest version many of the examples tests will fail, for example when doing yarn test in examples/dex:
 1) Dex
       getLiquidityPool works:
     Error: -32603: execution revert: Other("invalid currency id"): 0x000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001c4f746865722822696e76616c69642063757272656e63792069642229

@ntduan is this error introduced by the eip712 signature so it got unexpected currency id?

This may be caused by a change in the address of the chain contract


dns: don't generate alt-hosts for FQDN

Please provide a description of this PR:
Fixes #47340
If we already have an unambigous name, don't generate additional alternatives hosts.
Otherwise we will end up with something like istio-egressgateway.istio-system.svc..

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@leosarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ca6c43cf436d123d5c1ce935da9190fb525239f4
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

LGTM
/assign  @howardjohn

can we add some tests coverage?

Sure, tomorrow I will work on that

what about 1.19 ?

1.19 is EoL

1.19 is EoL

not now, https://istio.io/latest/docs/releases/supported-releases/#support-status-of-istio-releases

ah, IC

@leosarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
63f0a516d84f2052d9bb805c5cefba7da5fef21c
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leosarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
63f0a516d84f2052d9bb805c5cefba7da5fef21c
link
true
/test unit-tests-arm64

unit-tests_istio
63f0a516d84f2052d9bb805c5cefba7da5fef21c
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leosarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
63f0a516d84f2052d9bb805c5cefba7da5fef21c
link
true
/test unit-tests

lint_istio
659df1d3623dc3957dc485747932316fd9b42131
link
true
/test lint

unit-tests-arm64_istio
659df1d3623dc3957dc485747932316fd9b42131
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leosarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
659df1d3623dc3957dc485747932316fd9b42131
link
true
/test lint

unit-tests-arm64_istio
659df1d3623dc3957dc485747932316fd9b42131
link
true
/test unit-tests-arm64

unit-tests_istio
659df1d3623dc3957dc485747932316fd9b42131
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Existing tests are checking that specific names can be resolved via the DNS protocol and to which address they are resolved to.
The new tests are checking which alt hosts are generated, test will fail if we have more or less addresses than expected.
I did not check the whole DNS table (e.g: I do not check entry related to ipv4/6.localhost name). Let me know if you prefer me to check also the remaining ones or if you wish me to go for a different approach regarding the verification.

@howardjohn I realized that the test case was flaky due to a race condition in how the start/cleanup of the DNS server is handled.
It can happen that the cleanup of the tests is performed before the start of the DNS server has concluded.
This only became apparent in my test because, unlike the other ones, I'm not running real DNS queries via a DNS client (which may have a timeout/retry logic) but I'm simply checking how the local tables were filled -> test terminates in a short time.
I tried to update the initDNS() test function to wait for a "IsReady()" condition before returning but it does us no good as IsReady does not check if the underlying server has started. The underlying mikieg's DNS library has a "isStarted" method which would come in handy if only it was not a private one.
For the time being I handled the issue as such:

updated my test to create a DNS server without starting it as verifying the building of the alternate hosts does not require a running DNS server.
Keep the rest unchanged as I don't think the existing tests will encounter the issue due to the retry/timeout logic. I will still keep an eye on it going forward.

Considering that I have changed the tests considerably since your last approval I have added a do-not-merge label, if things still looks good to you I will remove it.

Thank you @howardjohn for the review :)

In response to a cherrypick label: new pull request created: #49634

In response to a cherrypick label: new pull request created: #49635

In response to a cherrypick label: new pull request created: #49636


UPD(coreclient): Use system CA database by default if not set explicitly

It is not necessary to check trust store path and raise exception if not set, because Qpid Proton Python can use system CA database by default.

Changes looks good


Necessity of constant-time encoding for PathORAM buckets of arbitrary size?

Hi,
This is more of a theoretical question, rather than a real attack proposal. In the Path ORAM paper, they note that each bucket is padded to the maximum number of blocks so the server can't tell which of the buckets in the path have the "real" blocks, which might allow correlation attacks.
But the marshalling function here https://github.com/cloudflare/utahfs/blob/master/persistent/oblivious.go#L18-L60 does not process buckets in constant-time. My questions are 1) is this attack of theoretical importance? and 2) is this attack of any practical importance, or do network latencies completely mitigate any issues here? Especially because (from a brief glance) there seems to only be 4 blocks per bucket.

Right, the marshalling function is fast enough that I can't see a timing attack being practical here. I can't say whether or not it's theoretically meaningful.


Mixed render targets display, CryEngine, DX12 capture

Description
RenderDoc seems to incorrectly detect which texture is used as a render target when debugging a CryEngine demo application. When I run the sample FPS level there is a simple scene with a character. Most of the stuff is rendered using a deferred shading technique. If I capture the scene using PIX I can, for example, find a draw call that renders the gun:

You can see in the OM section, there are 6 render targets with contents as I would expect. But if I try to capture the same frame and lookup the same draw call in RenderDoc, I see some unexpected textures bound there.

It is worth mentioning, that the final image looks the same as when I run the application in Pix.
I suspect RenderDoc from having more issues in the texture debug/display functionality, but I find this case easily reproducible.

Steps to reproduce

Download CryEngine from https://www.cryengine.com/ (you have to register and download the launcher first, than download the engine)
Create a FirstPersonShooter project from a template, open and export example.level to the game
Switch the renderer to DX12, it can be done by adding "r_Driver": "DX12" to the console_variables section of your project file
Run the game launcher using render doc: set executable path to C:\Program Files (x86)\Crytek\CRYENGINE Launcher\Crytek\CRYENGINE_5.6\bin\win_x64\GameLauncher.exe and add -project YourProject.cryproject argument
hit F12 to capture the frame after the level loads (you have to move a bit to let the character draw the weapon)
(optional) do the same using PIX to get the "correct" capture
find for example the weapon draw call under SCENE->GRAPHICS_PIPELINE->GBUFFER->OPAQUE_VELOCITY, the render targets should be set to textures as shown in the pix capture

Environment

RenderDoc version: git 455eddf3b49007a09969322a8fc921c0a4a82b54
Operating System: Win 10 Pro
Graphics API: DX12

Thank You!

Since you're filing other related DX12 bug does this mean #1986 can be closed? Either if it's not a problem any more or if you don't have time to look into it further. Unless you're able to share a repro case or provide more information I can't look any further into that issue.

This was related to a change I had to make a while ago to immediately read descriptors inside OMSetRenderTargets. Even though it requires a heap and descriptors the parameters are actually consumed immediately so the descriptors are pointless. Calls to CreateRenderTargetView() would be reflected but calls to CopyDescriptors*() would not, if they happened mid-capture before a OMSetRenderTargets call.


Add ix5.org website

Hi fellas,
I really like the idea of this whole project!
Especially the clean esthetic of black-and-white sites that a few owners here have.
I hope my site - ix5.org - fits right in here; the landing page is hand-crafted and optimized that it clocks in at 75KB.
The linked "RSS" feed is actually an atom feed.
Location of the magic icon:

And once again further down:

Very cool website Felix :) Don't put the webring icon in the header, it's fine just once at the bottom 👍

Very cool website Felix :)

Thanks for merging!

Don't put the webring icon in the header, it's fine just once at the bottom +1

Done.


Download from YouTube is interrupting

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.04.30
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl -v "https://www.youtube.com/watch?v=1La4QzGeaaQ"
[debug] System config: []
[debug] User config: [u'-f', u'bestvideo[height<=?1080]+bestaudio/besty']
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=1La4QzGeaaQ']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.04.30
[debug] Python version 2.7.16 (CPython) - Linux-4.19.37_1-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3
[debug] Proxy map: {}
[youtube] 1La4QzGeaaQ: Downloading webpage
[youtube] 1La4QzGeaaQ: Downloading video info webpage
WARNING: unable to download video info webpage: <urlopen error [Errno -3] Temporary failure in name resolution>
WARNING: unable to download video info webpage: <urlopen error [Errno -3] Temporary failure in name resolution>
WARNING: unable to extract channel id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[debug] Invoking downloader on u'https://r6---sn-ug5onuxaxjvh-jx3l.googlevideo.com/videoplayback?id=o-AGJqjrDjQQOuyRRAm2ZTD_0_Cj1rdoLP5itnlKAjoAov&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C271%2C272%2C278%2C298%2C299%2C302%2C303%2C308%2C313%2C315%2C330%2C331%2C332%2C333%2C334%2C335%2C336%2C337%2C394%2C395%2C396%2C397%2C398&itag=299&source=youtube&requiressl=yes&mm=31%2C29&mn=sn-ug5onuxaxjvh-jx3l%2Csn-ug5onuxaxjvh-n8v6&ms=au%2Crdu&mv=m&pcm2cms=yes&pl=22&ei=B4XRXOiPIYWW7QTzt7P4DA&initcwndbps=1383750&mime=video%2Fmp4&gir=yes&clen=214332583&dur=337.704&lmt=1556991510694739&mt=1557234877&fvip=6&keepalive=yes&c=WEB&txp=5532232&ip=<IP_ADDRESS>&ipbits=0&expire=1557256551&sparams=ip%2Cipbits%2Cexpire%2Cid%2Caitags%2Csource%2Crequiressl%2Cmm%2Cmn%2Cms%2Cmv%2Cpcm2cms%2Cpl%2Cei%2Cinitcwndbps%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&signature=5AF73B4FEF6E8E8B8E8431F6BA524B3B4D1F0A48.1AEF1F86ED3A15FD983248AC3C8733CF620D00AB&key=yt8&ratebypass=yes'
[download] Destination: Peru 8K HDR 60FPS (FUHD)-1La4QzGeaaQ.f299.mp4
[download]  14.6% of 204.40MiB at  1.13MiB/s ETA 02:34ERROR: unable to download video data: <urlopen error [Errno -3] Temporary failure in name resolution>
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1909, in process_info
    partial_success = dl(fname, new_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1854, in dl
    return fd.download(name, info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/downloader/common.py", line 364, in download
    return self.real_download(filename, info_dict)
  File "/usr/lib/python2.7/site-packages/youtube_dl/downloader/http.py", line 341, in real_download
    establish_connection()
  File "/usr/lib/python2.7/site-packages/youtube_dl/downloader/http.py", line 109, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 2227, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 429, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 447, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/site-packages/youtube_dl/utils.py", line 1140, in https_open
    req, **kwargs)
  File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno -3] Temporary failure in name resolution>

Description

For another video, the download doesn't even start:
youtube-dl "https://www.youtube.com/watch?v=H_yATzyi-3g"
[youtube] H_yATzyi-3g: Downloading webpage
ERROR: Unable to download webpage: <urlopen error [Errno -3] Temporary failure in name resolution> (caused by URLError(gaierror(-3, 'Temporary failure in name resolution'),))

A week ago, everything worked. Now I can not download any videos from YouTube.

Network issue on your side.


No proposed structure auto-gen?

Hello, I had the idea that this extension comes with a way to auto-gen folders as the proposed structure but cant find the way to do it yet. I am just doing it manually by now.
Thanks the great work on this extension!

Hello, all here are snippets and Wrappers, to place your widgets inside an obx with Alt + o for example or using control +. and selected wrap in ObX / GetBuilder / GetWidget, but for that there is https://pub.dev/packages/get_cli, my proposed structure is out of date at the moment, but you can use other ones, or continue doing it, it is not quick: 3 hsuahusa thanks for support, enjoy.


Create parts directly in hydrate()

This updates hydrate() to put the TemplateInstance tree into a usable state before render() is ever called. This removes hydration code from Parts, especially NodePart's handling of TemplateResults.
As part of this I changed how attribute bindings are marked. Now we just emit a marker comment after an element with attribute bindings that contains the node index in the template. This lets us continue to walk only the comment nodes during hydration, and associate attribute bindings by index.
I've reverted all changes to part.ts, all SSR-related options from RenderOptions, and a few new types that were used to pass "prerendered" part descriptions.
With this attribute expressions and nested templates are working, at least minimally. We're now priming the current part values, so I was able to add a test check that there are no DOM mutations for hydration + initial re-render with the same data.
As part of removing the SSR-specific code from parts, we don't have the code to emulate SSR'ed DOM in lit-html anymore. This is fine because that was diverging from lit-ssr. I have ported over the client-side only hydration tests from lit-html to the lit-ssr integration tests to retain coverage.
This PR breaks repeat(), so the repeat() tests ported to lit-ssr are skipped there. I think we need a bit of a rethink on directive handling to make this pay for play. I'm mulling over a way that directives can emit the serializable state they need for hydrate() to work.
The corresponding PR to emit the new <!--lit-bindings {x}--> marker is coming in soon.

Looks like CI is complaining on clang-format


Enable dynamic plugin model for external DNS providers

All supported providers are currently configured statically via the switch statement enumerating  types in main.go. It appears feasible to implement a plugin model here where "plugin" type would load an external .so using Go plugin: https://golang.org/pkg/plugin/. It may be accompanied by a config file for the plugin.
This would help allow supporting close source providers or providers which are not of interest to be statically maintained in external-dns.

@if-ivan-else I believe this could be a goal for after a v1.0 release. Do you have experience with this and would be able to help?


Don't allow renaming of read-only Dats

Via inline-editing, I can rename a read-only dat (=edit dat.json).
That probably shouldn't happen.

opened a pr for this