[enhancement]: compy with the openapi specs

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
discord: inori_aizawa
What should this feature add?
considering this project has an API that has swagger docs. and an openapi.json
is it possible to make it comply with the openapi specs
that way tools like this could be used. which would speed up api development to integrate invokeai with other projects. in case the API changes a bit the tool could be ran again to update the libary
Alternatives
an alternative would be for every developer to manually create a library for their project. this is error prone and when the api changes it needs fixing
Additional Content
No response

We use openapi codegen on the project already (we generate typescript types and a backup HTTP client, and have used two different codegens without issue).
What isn't in spec? What doesn't work?

What are you using to generate them? Maybe it is an error on my part.

@Yvonne-Aizawa
The project currently uses https://github.com/drwpow/openapi-typescript but we also have used https://github.com/ferdikoomen/openapi-typescript-codegen in the past.
https://apitools.dev/swagger-parser/online/ reports the schema as valid, FWIW

in that case i will look further. i will close this issue. sorry for taking your time

@Yvonne-Aizawa No worries, please @ me if you find any problems, we can definitely fix any issues.


CB-10411: Add FreeIPA backup debug to logs

Add FreeIPA backup debug to salt output and /var/log/ipabackup.log.
Include redaction of the x-amz-security-token.
This was tested using a local deployment of cloudbreak.
See detailed description in the commit message.

I added lot rotation in case the hourly backups fail to upload the backup to the storage location. In that case, the logs will grow since there will be more backups that are attempted to be synced every hour until it is successful. It appears that the logs may grow pretty quickly during failure cases since every hour it will attempt to sync all backups that haven't been successfully uploaded. A provision failure due to permissions issues resulted in 16 MB of logs (with the provision retries there were about a dozen full backups that were attempted to be uploaded about dozen times).

LGTM, only the space seems a bit much for the log. KDC log already can take 12GB, if both take it we would might need instances with bigger root disks.(I think it's 50GB right now)

We might consider decreasing the "rotate 12" to a lower value

I decreased the log retention to less than 1 GB total.


Add support for unlabeled events as well

Basically, what it says on the tin.
We've got this wired up to add a bug to the backlog board when we yank the "needs-triage" label off the issue. However, if all we do is remove that label, the action doesn't fire.
Case in point: https://github.com/microsoft/terminal/pull/13975

I also tried this here: https://github.com/microsoft/terminal/commit/cf1d4de20b17ee3d48fd683c7f0fd7dbd6e53abc#diff-e5439f3ce1299e194f3d09ed4c3ea1dd1d4e11907ba3ea7b160c6b1a20057c01, but that didn't work and instead generated: https://github.com/microsoft/terminal/actions/runs/3056215991

Oh my god I'm so embarrassed. Apparently I just don't know yml at all.
https://github.com/microsoft/terminal/commit/446ef2204454b3997da9103cbe86473fdab41c62 has the fix for us in it.


Cache break CSS

Looks like Firefox caches the CSS a bit too much (#641). We'll need to break the cache, maybe append the version number to the filename. This doesn't appear to be a problem in dev builds, so the version number would suffice.

This is a problem in dev builds, requires the extension to be removed and readded for me at least. Might not be a problem in webstore only, it happened when I switched from dev to webstore.


Users have to answer join questions when invited to join a group

https://www.figma.com/file/CcODuMOQv9ShB1ryHTDqfr/Onboarding-Flow?node-id=0%3A1&viewport=-123%2C-1619%2C0.34902629256248474

[ ] When clicking on an invite link, after joining the group show pop up modal with questions to answer (as part of Group Welcome modal)
[ ] These are optional questions for now, answers can be blank, but do get saved
[ ] Question: if there are group agreements do we show these before or after in a long list? or separate steps of the Group Welcome modal?
[ ] Eventually could have a setting to say whether they have to answer or not
[ ] Purpose & Agreements come first as first page, then next to see join questions & suggested skills

I started looking at this but realized it hinges a bunch on the agreement work you are in the middle of, and I didn't want to cause massive merge conflicts. I'll do the mobile version for now and come back to this once you've had a shot at adding the recheck of agreements when they change


Make rate limits configureable

Closes #49
Make rate limits period and threshold configurable by adding 'rate_limit_count' and 'rate_limit_period' to configuration option.

Thanks for this PR @kannapoix :) I'll finally take a look on Monday.

@dunxen No, it's ok. 確認ありがとうございます ✨
Commits squashed.
When is the right time to squash commits?
I thought it was bad to squash commits during a review, because changing the commit number makes comments unassociated with a commit. So I always squash them after a reviewer asks me to(just like you did).
Is this OK, or should I organize commits when I feel it is necessary?

When is the right time to squash commits? I thought it was bad to squash commits during a review, because changing the commit number makes comments unassociated with a commit. So I always squash them after a reviewer asks me to(just like you did). Is this OK, or should I organize commits when I feel it is necessary?

You are 100% correct! You did the right thing to leave the fixup commit for review.

I'll wait a little while for @orbitalturtle to have a final look, but this does LGTM so I think it can be merged some time today, otherwise :)


Extraneous '>' introduced in diff

Correct diff: https://try.gitea.io/silverwind/symlink-test/commit/d0c0659f1313d935e2934ae74a6d47c2c234d665

Incorrect diff: https://try.gitea.io/silverwind/symlink-test/commit/3debed8064253858d45cacc554d1b5ddca36051a

The > is not part of the actual diff and is being introduced by our diff code. The only difference in the examples above is the file extension of the updated file.
cc: @mrsdizzie

I think this is a duplicate of #14231
I think :
https://github.com/go-gitea/gitea/issues/14231#issuecomment-757361996
points towards a solution

I think this is a duplicate of #14231
I think :
https://github.com/go-gitea/gitea/issues/14231#issuecomment-757361996
points towards a solution


fix(stream): stream hop window ignore the null time

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix https://github.com/risingwavelabs/risingwave/issues/8130
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers
~- [ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.~

@st1page The change here is data records that has null time values will be ignored by time window functions. Correct?

@st1page The change here is data records that has null time values will be ignored by time window functions. Correct?

Yes!


CentOS updates for EOL

Thank you @bebound for your feedback. I'm merging this PR with as sufficient time has been left for team review.


Override template parameters: Unexpected token $

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Question
Enter Task Name: ARM Template Deployment
Environment

Server - Azure Pipelines

Issue Description
We are getting this error with the ARM template deployment task:

There was an error while overriding 'alertThresholdForIcMTrigger' parameter because of 'SyntaxError: Unexpected token $ in JSON at position 0', make sure it follows JavaScript Object Notation (JSON)

In the Override Template Parameters multiline input box, we have:
-alertThresholdForIcMTrigger $(AlertThresholdForIcMTrigger)
where AlertThresholdForIcMTrigger is set to an integer in the Variables section of the Release pipeline.
Would anyone know what is causing this issue?  Sorry if this was already addressed somewhere else.

@sarahkang58 I am not able to reproduce it. Can you please share the debug logs with variable system.debug set to true?

@anuragc617 We are facing the same issue, the challenge is how can we effectively define an integer variable in Azure DevOps Classic release pipeline and pass as override parameter to ARM template deployment task? This task is assuming the value as String
Task version: 3.*

@musema pls share debug logs

Closing this .
Feel free to reopen if issue persists.


Autofill Spinners doesn't work

Hi,
I have tried your sample CreditCardSpinnersActivity and the Spinners isn't autofill, it works for the creditcardnumber and the vcc but spinners not moving.
Tested on a Nexus 5X with Android 8.0.

Hi sorry for such a late response. It works for me.

Have you set the default autofill service to Multi-Dataset Autofill Service?
Have you tried filling in that page (instead of a different cc page) and saving the autofill data?

Hi,
Question 1 : I tried with the "Autofill with Google" to get my credit card data saved on my google account.
Question 2 : To make a new test, I have changed my default autofill service to "Multi-Dataset Autofill Service" and fill a credit card form, but the system didn't ask my if I want to save my data....

I have followed your instruction, and, in this case, it works !
So, my question still remain, why it works with the autofill provider "Multi-Dataset Autofill Service" but not with the provider "Autofill with Google" ?

"Autofill with Google" does not support credit card expiration date like that yet, but it will soon.
Anyways, the best way to test the sample apps (and your apps as well) is using the  "Multi-Dataset Autofill Service" implementation first. Think of the "Multi-Dataset Autofill Service" as a reference implementation - if your app works with it but not with other services, the problem is in the other service implementation, not in your app.

Hi @the-felipeal !
You are right, it was a trouble in "Autofill with Google". I have changed nothing on my code and today it's working !


Can receipt managers submit transactions?

Task: Confirm that the receipt manager can successfully submit concludeAndWithdraw transactions in our e2e tests.
There is evidence that indexers are not submitting concludeAndWithdraw transactions. Investigate if that is due to indexers always (or almost always) losing the race to submit a transaction or because the receipt manager is not configured for the chain service to submit transactions.
I think the sequence of tasks for this investigation is:

Can we observe the indexer chain service submitting concludeAndWithdraw transaction in graph-payment e2e tests?
If yes, then either

conditions in the graph network are different so that the gateway wins the race to submit a transaction most of the time
indexers configure receipt-managers in a way where the indexer chain service is unable to submit a transaction.

At the moment, I am not able to run graph-payments tests locally.
➜  e2e-testing git:(main) ✗ ./scripts/run-local.sh
yarn run v1.22.4
warning package.json: No license field
$ npx ts-node ./scripts/db-utils.ts create_schema postgresql://postgres@localhost/payer
Using db connection {"user":"postgres","password":"","port":null,"host":"localhost","database":"payer"}
Creating schema if needed
✨  Done in 1.91s.
yarn run v1.22.4
$ yarn test:e2e
$ FUNDING_STRATEGY=Fake jest e2e.test.ts --ci --runInBand
ts-jest[versions] (WARN) Version 4.1.2 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=3.8.0 <4.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.
(node:28848) V8: graph-payments/node_modules/rustbn.js/lib/index.asm.js:2 Linking failure in asm.js: Unexpected stdlib member
 FAIL  __tests__/e2e.test.ts (12.661 s)
  Payment & Receipt Managers E2E
    ✕ Can create and pay with 2 allocations (6053 ms)
    ○ skipped Can remove 2 allocations using syncAllocations
    ○ skipped Payment and Receipt can get back in sync if indexer offline
    ○ skipped Payment and Receipt can get back in sync if payer missed receipt

  ● Payment & Receipt Managers E2E › Can create and pay with 2 allocations

    Request failed with status code 406

      at createError (../../node_modules/axios/lib/core/createError.js:16:15)
      at settle (../../node_modules/axios/lib/core/settle.js:17:12)
      at IncomingMessage.handleStreamEnd (../../node_modules/axios/lib/adapters/http.js:244:11)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 3 skipped, 4 total
Snapshots:   0 total
Time:        12.7 s

Not part of the generic solution


mgmtfn/k8splugin: add network setup unit test

This PR adds a unit test for some of the network setup functions from driver.go.
This increases the coverage from 25% to 33.4%.

ping @abhinandanpb @erikh @jojimt @gaurav-dalvi

Any chance I could convince you to use gocheck for this? We are using it in a lot of the newer test systems.

another advantage of gocheck; if we used it the test fixtures we could do the setns setup/reap so they were re-usable by other tests.

@erikh: I'll make the changes as you've proposed. There's no need to convince me. The reason why I've written it like that was to make the changes as small as possible.

Will merge once system tests pass. Thanks for taking care of this.

needs a kick, this was last committed when the CI was down.

I'll merge this now. Joji has said he'd merge once the system tests pass. I need it for my next PR.


Change MDN reference url to zh-CN

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Hi,
Thanks for this pull request (PR).
Since you already had another PR for this same file, I have made the following change on the other PR (#21779) on your behalf and will close this PR.
文档： [MDN](https://developer.mozilla.org/zh-CN/docs/Web/CSS/background-size)

Thank you


Step1 button should be enabled only when at least one row has been activated.

Already in place as part of another commit.

When a row is activated and/or the peak selection moves, the Bragg Edge Infos tab should update itself with the right lambda min and max values.


docs: dfx-nns.md

using new default 4943 port for the replica
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:

[ ] The title of this PR complies with Conventional Commits.
[ ] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.

actually, it seems like dfx nn install expects port 8080. can we change this please?

actually, it seems like dfx nn install expects port 8080. can we change this please?

By "change this," what do you mean exactly?  Change the document here?  Or change the fact that dfx nns install requires port 8080?

Change the fact that it requires port 8080


concurrency agent not working reliably with multiple clusters

With multiple clusters Openwhisk can create multiple containers for a concurrent action even with minimal traffic. Invocations in a cluster will create a new container in the same cluster. If invocations (actual invocation to debug vs. wskdebug polling) happen in different clusters, there will be 2 containers and they won't see each other, and wskdebug will fail to catch any invocations. This has been observed as a new behavior.
Some internal discussion.
Workaround
Use another agent, either:

--ngrok
--disable-concurrency (only available on wskdebug master right now, uses the activation db polling agent)

@alexkli the slack link is inaccessible to the slack community - can you summarize relevant parts?

The summary is above :-) The link was a note for me to find it later if I need it.

Thanks!

@alexkli just confirming, ---disable-concurrency is enabled in<EMAIL_ADDRESS>correct? (looking at the source, it seems it is: https://github.com/apache/openwhisk-wskdebug/blob/1.3.0/src/agentmgr.js#L188)

@alexkli just confirming, ---disable-concurrency is enabled in<EMAIL_ADDRESS>correct? (looking at the source, it seems it is: https://github.com/apache/openwhisk-wskdebug/blob/1.3.0/src/agentmgr.js#L188)

@shazron yes.

@shazron yes.

Added the --disable-concurrency flag for the Project Firefly app plugin (5.4.0) VS Code launch config: https://github.com/adobe/generator-aio-app/pull/128


Apps landing page

Creates /apps page to choose between two buttons: Cost of Capital or Taxbrain
Adjusts the links on home page under the word Apps to point to /apps rather than /taxbrain

Looks like we have no tests in the webapp/apps/pages to test the main pages.  Should I add some there?

Cost of Capital should be second.
It'd be nice to swap out the TaxBrain specific material in the blue banner. Maybe the big OSPC logo? Or maybe keep TaxBrain and just add the Cost of Capital Calculator logo next to it (in which case we would fill the thing up as we add more apps .. kind of cool .. )

@PeterDSteinberg ah I see we do have apps/pages/tests.py but that is not run on Travis CI right now. Those tests are not that big of a deal anyway. If you find something that you want to test for this landing page, that's fine to add it, but I typically only add a test when I have a view that is doing something nontrivial. I think the OSPC logo would look good up at the top.

The full page with new ospc logo:

The expandable section at the top for B-Tax and Taxcalc version information:

Added a tiny test to apps/pages/tests.py

@MattHJensen The "About Apps" section shown in the image above was formerly just information about Taxbrain.  I changed it to have blurbs about B-Tax and Taxbrain and their versions.  Does that make sense to you, and if so, should the expandable section like this on /btax show both Taxbrain and B-Tax blurbs/versions or just B-Tax's?

@PeterDSteinberg

I changed it to have blurbs about B-Tax and Taxbrain and their versions. Does that make sense to you

Yes, that's great.

should the expandable section like this on /btax show both Taxbrain and B-Tax blurbs/versions or just B-Tax's?

Just B-Tax

It seems ok to remove that test in 090e161. There's actually quite a bit of work to do to mock that out correctly. We don't have similar tests on the taxbrain side for that kind of thing. We have some tests that are captured JSON from the compute node that are return by a MockCompute object. I'm not sure if we need that for this initial version.

I think it is handled ok by the 1) the test that checks post redirects ok and 2) the test that ensures the mock table works (test of the json assets).


OSSM-5293 Add rawValues field

Please also add a test(s). At least one test that checks that rawValues are passed to helm charts. The test should also test what happens if the same value is specified in both values and rawValues. Which of these fields has precedence?


org/http4s/blaze/util/package.class is present twice in the classpath

org/http4s/blaze/util/package.class is present twice in the classpath
JarClassLoader: Warning: org/http4s/blaze/util/package$.class in lib/http4s-blaze-core_2.12-0.17.0-RC1.jar is hidden by lib/blaze-core_2.12-0.12.6.jar (with different bytecode)
JarClassLoader: Warning: org/http4s/blaze/util/package.class in lib/http4s-blaze-core_2.12-0.17.0-RC1.jar is hidden by lib/blaze-core_2.12-0.12.6.jar (with different bytecode)

So that depending on the final classpath order one might get in runtime:
java.lang.NoSuchMethodError: org.http4s.blaze.util.package$.End()Lscala/util/Right;

This package object is new in 0.17, so it doesn't affect 0.16.
The problem is that http4s-blaze-core (from the http4s project) and blaze-core (from the blaze project) are both in the same namespace.  We should move all the classes in http4s-blaze-core to a different package.

Even though we haven't caused a clash in 0.16, we probably ought to do the renaming in 0.16 and bubble it up, just to avoid any future problem.  The split package problem has existed for a long time.

This is fixed now, right?

Yes.


“vaccine proper name” vs “product name”

The ontology entries have a field “vaccine proper name” but no “product name” field in the few examples I have looked at.  Are there any actual “product name” entries?   Maybe we should change from the empty “product name” to “vaccine proper name” on the Dashboard? (from Ken's email)

In the source data, the attributes like trade names, product names, proper names, etc. are not completely and consistently coded. Currently, the Product Name is from the comment attribute if its content starts with "Product Name:". There are only 30 Product Names in the latest version of data.
Should we add a proper name, or replace the product name?

Assuming “vaccine proper name” is populated for all entries, let's just use that instead of product name.

Tested in production, works as expected. Note that not all vaccines have a proper name or a trade name, they are left blank in the GUI in that case.


⚠ Bofrost.at has degraded performance

In aade4f1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1680 ms

Resolved: Bofrost.at performance has improved in 7cbca49 after 9 minutes.


Added requirement plan-for-teams-live-events.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/4221
@LanaChin please double check it. I'm almost sure about it because if you don't have schedule meetings available in Teams...

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Pinged PM to confirm

Thanks @dariomws and JohanFreelancer9, updates merged.


Create a basic Dockerfile for the server

There is a great node image on dockerhub that will bootstrap node.js for you. All you need to run after is the actual node server. Add some arguments so that when starting the container, you can start it in a dev environment, or build the server for production. Check the answer to this question for inspiration

#26


Missing YAML documentation for Task Control Options

Where are is the YAML documentation for the task control options? I need to run a publish test results task even when a test fails.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8098f527-ebdf-60d5-3989-5228b7a207c1
Version Independent ID: ce27c817-9599-00ef-5af2-3ac1dbad8dc6
Content: Build and Release Tasks in Azure Pipelines and TFS - Azure Pipelines & TFS
Content Source: docs/pipelines/process/tasks.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

https://docs.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=vsts&tabs=yaml I believe should give you what we need. Looks like we might need to integrate the topics a little better.

On the [Conditions[https://docs.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=vsts&tabs=yaml) page it says to use condition: after the job, but the initial question is about a condition on a task.
Do you mean I can use the condition on a task the same way like on the job?
Same here "I need to run a publish test results task even when a test fails."

I just completed a PR to fix the original issue (with the tasks topic). I can also see how the conditions topic is confusing; will think about ways to improve.


Graphenedb_url authentication returns error 403

I'm using node-neo4j. And I when I test using localhost:7474 I passed neo4j:mypassword@localhost:7474 and it worked but when i'm trying to use graphenedb the url looks like this app45353535:sdddgt3434c645e5@app45353535:dodgers.fd54f4444d:35454 but it returns error 403 but when I take all the parameters after the @ and paste on the browser, it takes me to the neo4j db

db = new neo4j('app5453544:app545e43@test5535et:******');


ADD: Teespring

Data

name: Teespring
difficulty: hard
email<EMAIL_ADDRESS>email_subject: Delete Account Request
email_body: Please delete the account associated with this email address.
domains: teespring.com

There needs to be a url with this.
Do they have a support article saying they accept deletion requests at that address? If not, their privacy policy may be acceptable.

The thing is I have not found any official sources, though the common consensus when searching for a solution on Google is to use said email above. Eg. https://libreddit.s.nachtalb.io/r/Teespring/comments/fdmzn5/close_storedelete_account/

I've sent them an email asking for clarification. If I don't get a response in a few days, Ill try again with the email address they have in their privacy policy (privacy@spri.ng).

Ahh, thanks for the proactive investigation! 👍

After 5 days, I haven't received a response from either<EMAIL_ADDRESS>or<EMAIL_ADDRESS>I'm not sure what to do here. Maybe it could be added as impossible for now along with their email and a note encouraging to try emailing a request anyway. Something like:
"notes":  "It's currently unknown if they allow account deletions, but you can try emailing and asking. Do share their response with us on GitHub!"
Could include a hyperlink to this issue in there.
What do you think, @tupaschoal?

I think 5d is relatively too soon, I'd say if you don't hear back from then in two weeks, then we can add it as impossible.

@SvicidalBug if you haven't heard back from them by now, I think it's safe to list it as impossible.


Add get_results, add model_base_kwargs

Issue #, if available:
Description of changes:

Added get_results to searchers, useful for debugging and for future extensions to HPO functionality.
Added new way to init a BaggedEnsembleModel that avoids having to init the base model prior to initing the bagged ensemble model.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1618-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1618/1/index.html


Use proper proper REST Methods (POST PUT or PATCH) and send payload normally

Is your feature request related to a problem? Please describe.
Encoding the request payload as a GET is extremely obtuse and makes creating new clients difficult and non-intuitive for other developers.
Describe the feature you'd like
Instead decoding the request in the Lambda, re-factor the API gateway implementation to pass along the payload json so that the API supports either POST or PUT as the verb and a normal JSON payload.
Additional context
Encoding payload in GET instead of using url parameters, as well as using GET for something that modifies data goes against RESTUL conventions in general.

Hi @kpconnell,
I don't agree with this, any request made to SIH is retrieving a resource, which feels like exactly the use case for a GET request. Making a request with edits doesn't modify any data, it retrieves the requested image, generating it if required. As well, we're using CloudFront to cache responses to these requests in order to prevent having the Lambda generate image for duplicate requests, which wouldn't be possible with POST or PUT requests.
I'm going to close this issue for now, but feel free to re-open if I've missed or misunderstood anything,
Thanks for your interest in Serverless Image Handler,
Simon

You may disagree with which verb, (this DOES create data which you agreed to)  but even if. you like your GET , why not use proper query string parameters like the rest of the world does?

Hi @kpconnell,
That is something we're considering, it is tracked over at #184.
Thanks,
Simon


[HUDI-3024] Add explicit write handler for flink

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Merge this pr now, the tests failure should not be triggered by this PR.


what does  create-domain.sh and  kubectl apply -f domain.yaml do ?

During deployment of WebLogic/soa etc on Kubernetes, we are asked to run first create-domain.sh and then domain.yaml.
Can we get clarity, a little bit in detail on what these scripts do?
Thanks

The create-domain.sh script is a sample that creates a WebLogic domain configuration (domain home filesystem) on a persistent volume and then also creates a YAML file specifying a resource of type, Domain, which describes how WebLogic instances should be run in the cluster. This Domain resource type is defined by a CRD and is related to the WebLogic Server Kubernetes Operator (https://github.com/oracle/weblogic-kubernetes-operator). The second step to kubectl apply creates the resource and triggers the operator to start WebLogic instances.

thx


bug: delegate tooltip doesn't close on mobile

Go to delegate pages on mobile,
Click on new delegate button
Notice that tooltip still appears on top

Yes this is the case for all tooltip, I guess we need to remove them on mobile


Minor updates regarding zones and error handling

Adding the following

Started adding support for DEBUG module for additional logging
Handle problem of getting volume from a zone zone without volume available
getZone to basicinfo object

Thanks! Was on vacation, so it took some time


How do I pass the template options for nunjucks

Hi,
I am trying to pass a filter to use in the nunjucks templates. Example:
var env = new nunjucks.Environment();
env.addFilter('shorten', function(str, count) {
  return str.slice(0, count || 5);
});

var newsletter = new emailTemplate(path.join(templatesDir, templateFile),{
          env: env
});

When I pass the template name, I am getting the following error:
[Template render error: (unknown path)
Error: filter not found: shorten] name: 'Template render error' }

Any idea how can I use the template filters? Any help is appreciated.
Thanks,

I'm trying to do the same thing with little success. Because the templates are rendered in the current working directory instead of relative to where the EmailTemplate is instantiated...

Well, I was messing around and did something like this:
    // Set the directory for template path resolving
    // used by email-templates => consolidate.js => nunjucks
    // (otherwise it will default to the CWD)
    const settings = {
        views: path.join(__dirname, '../')
    };

    template.render({ settings, otherViewModelStuff })
    .then(...)

No documentation, I had to look at the source. :)
You can also pass loader directly into consolidate.js, and/or add nunjucks directly to loader.nunjucks on const emailer = require('email-templates')

Wow I'm really sorry.  Can you submit a PR @aeharding with documentation for this?  😦 I didn't think I let this package slide that much!!!!

@aeharding ping

I ran into this issue today and may be missing something, but was unable to get @aeharding solution working yet

@aeharding @timelf123 Hey, thanks to both of you for discussing this. Here I am months later and ran into the exact same problem for my new framework https://github.com/crocodilejs/crocodile-node-mvc-framework... I will be updating documentation for this shortly.

So it appears that renderString is used in consolidate, and of which it does not support includes per https://github.com/mozilla/nunjucks/issues/730.

Any idea how to get env working? I am trying to add a custom filter like OP
var env = new nunjucks.Environment();
env.addFilter('nl2br', function(str) {
    return str.replace(/\r|\n|\r\n/g, '<br />')
})

  var options = {
    settings: {
      views: path.join(__dirname, 'templates'),
      env: env
    }
  };

@timelf123 take a look at how I did https://github.com/crocodilejs/crocodile-node-mvc-framework/blob/development/src/jobs/index.js - I actually stopped using this package (email-templates) in favor of the approach I took in that code.  Anyways, if you wanted to use a custom env for this package, you could do so by the latest which supports my fork of consolidate.js, see the Readme note here https://github.com/niftylettuce/consolidate.js#notes

Pretty slick thanks for the example @niftylettuce. Unfortunately I'm not able to use all the ES6 wonderfulness quite yet
With your new approach/focus on crocodilejs, does that mean shuttering support for email-templates?

Yeah I'll probably refactor it @timelf123 completely or build something new!

@timelf123 really this wrapper is kind of useless IMO, I built something beautiful in CrocodileJS per link above which I plan to componentize.

Please use latest version v2.5.4 from NPM via npm install --save email-templates@latest.  Thank you.  If you need documentation on Nunjucks see notes in https://github.com/tj/consolidate.js/#notes.


TP-Link Component: Failure to find one switch results in entire component failing

Home Assistant release with the issue:
0.89
Last working Home Assistant release (if known):
0.87
Operating environment (Hass.io/Docker/Windows/etc.):
Docker on RHEL7
Component/platform:
TPLink
https://www.home-assistant.io/components/tplink/
Description of problem:
I have a number of TP-link switches, some of which are only used part of the year. For example, I keep one for my Christmas tree.  They have static IP addresses, and I don't want to use discovery (I have a complex network configuration, HA is on a different network than the IoT stuff).  If one switch is unavailable, then the entire component doesn't load.
I can comment them out, but I'd prefer not to.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# IP addresses are masked
tplink:
  discovery: false
  switch:
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX
    - host: 192.168.XX.XX

Traceback (if applicable):
2019-03-07 01:08:44 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry TP-Link Smart Home for tplink
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 116, in _query_helper
    request=request,
  File "/usr/local/lib/python3.7/site-packages/pyHS100/protocol.py", line 47, in query
    sock = socket.create_connection((host, port), timeout)
  File "/usr/local/lib/python3.7/socket.py", line 727, in create_connection
    raise err
  File "/usr/local/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
OSError: [Errno 113] No route to host
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/config_entries.py", line 283, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/app/homeassistant/components/tplink/__init__.py", line 120, in async_setup_entry
    await hass.async_add_executor_job(_fill_device_lists)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/tplink/__init__.py", line 110, in _fill_device_lists
    if dev.is_dimmable:  # Dimmers act as lights
  File "/usr/local/lib/python3.7/site-packages/pyHS100/smartplug.py", line 131, in is_dimmable
    return "brightness" in self.sys_info
  File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 185, in sys_info
    return defaultdict(lambda: None, self.get_sysinfo())
  File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 195, in get_sysinfo
    return self._query_helper("system", "get_sysinfo")
  File "/usr/local/lib/python3.7/site-packages/pyHS100/smartdevice.py", line 119, in _query_helper
    raise SmartDeviceException('Communication error') from ex
pyHS100.smartdevice.SmartDeviceException: Communication error

Additional information:

according to the pyHS100 library, dev.is_dimmable calls get_sysinfo which raises SmartDeviceException. Either we need to catch this or first see if device is reachable.

I have the exact same setup and issue 😄

Fixed now in dev branch, thanks to @ljmerza!

Thanks 🙏 That was fast!

any news about this ?

Merged in dev but not in 89.1 or 89.2 unfortunately....

Just pulled dev(0.90.0b1) and I'm getting this:
Mar 14 23:51:50 hassbian hass[675]: TypeError: 'NoneType' object is not subscriptable
Mar 14 23:51:50 hassbian hass[675]: 2019-03-14 23:51:50 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Mar 14 23:51:50 hassbian hass[675]: Traceback (most recent call last):
Mar 14 23:51:50 hassbian hass[675]:   File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
Mar 14 23:51:50 hassbian hass[675]:     result = coro.send(None)
Mar 14 23:51:50 hassbian hass[675]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 257, in _async_add_entity
Mar 14 23:51:50 hassbian hass[675]:     if entity.unique_id is not None:
Mar 14 23:51:50 hassbian hass[675]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/tplink/switch.py", line 62, in unique_id
Mar 14 23:51:50 hassbian hass[675]:     return self._sysinfo["mac"]
Mar 14 23:51:50 hassbian hass[675]: TypeError: 'NoneType' object is not subscriptable
Am I missing something?


Intellisense stops working at random instances

VSCode Version: 1.9.0
OS Version: Windows

Tested on 4 different machines running Windows 10/Windows 10/Linux/macOS

Steps to Reproduce:

Write code in * language
Observe lack of intellisense

This happened in =< 1.8,1 at random points of time, but it was okay for a bit after closing VS Code and starting it again. Now the situation is different. Intellisense stops every 2-3 lines of input.
No matter the language used.
As you can see, even code-hinting / linting does not work. So does auto-beautify or whatever plugin that has some kind of dynamic function. Every functionality except input is not present.

Git is on, Gulp is running in the Terminal (integrated)
Plugin list:
ActiveFileInStatusBar - Version :1.0.2
auto-rename-tag - Version :0.0.11
beautify - Version :0.7.3
Bookmarks - Version :0.10.2
code-settings-sync - Version :2.4.3
color-highlight - Version :1.3.0
githistory - Version :0.1.5
gitignore - Version :0.5.0
guides - Version :0.6.1
html-css-class-completion - Version :1.0.3
html-snippets - Version :0.0.18
HTMLHint - Version :0.3.3
htmltagwrap - Version :0.0.3
indenticator - Version :0.2.1
jquerysnippets - Version :0.0.1
lorem-ipsum - Version :1.0.0
path-intellisense - Version :1.2.0
php-intellisense - Version :1.0.0
sass-indented - Version :1.3.0
stylelint - Version :0.22.0
Theme-Easyballs - Version :0.0.2
vscode-autoprefixer - Version :2.0.0
vscode-color - Version :0.2.3
vscode-csscomb - Version :4.0.0
vscode-eslint - Version :1.2.2
vscode-gutter-preview - Version :0.8.2
vscode-npm-script - Version :0.1.8
vscode-scss - Version :0.6.0
vscode-simple-icons - Version :0.8.1
vscode-svgviewer - Version :1.3.0

Experienced in javascript and python too.

It looks like the extension host is no longer responding.

Open the developer tools (Help > Toggle Developer Tools' and check the console.
Open the output view and check for output in the 'Extensions' channel.
Disable extension html-css-class-completion and see it this makes a difference.
If that doesn't solve the issue, run without any extension (run code with code --disable-extensions) and see it that makes a difference.

@jrieken Any tips how to get more information what the extension host is busy doing?

Tried all the things you suggested, still no intellisense after initial try.
Here is my console log:
Overwriting extension <<.scss>> to now point to mime <<text/x-sass>>
Ctrl+Alt+ keybindings should not be used by default under Windows. Offender:  2601  for  bookmarks.toggle
Ctrl+Alt+ keybindings should not be used by default under Windows. Offender:  2602  for  bookmarks.jumpToNext
Ctrl+Alt+ keybindings should not be used by default under Windows. Offender:  2600  for  bookmarks.jumpToPrevious
[Extension Host] Windows_NT
[Extension Host] Looking for parseable documents...
[Extension Host] Found all parseable documents.
[Extension Host] Parsing documents and looking for CSS class definitions...
[Extension Host] Sumary:
[Extension Host] 8 parseable documents found
[Extension Host] 12407 CSS class definitions found
[Extension Host] 1724 unique CSS class definitions found
[Extension Host] 0 failed attempts to parse. List of the documents:
[Extension Host]
[Extension Host] [Guides] Sending usage statistics...
[Extension Host] [Guides] Error while sending usage statistics: Error: getaddrinfo ENOTFOUND api.digitalparticle.com api.digitalparticle.com:80
[Extension Host] [Guides] Usage statistics will retry in the next 5 minutes

This is most likely an issue with an extension consuming too much CPU time and therefore taking away the chances of other extensions doing something useful - all extension run in a single threaded process.
@sqnkov Are you saying this happens when you have started with --disable-extensions?

@jrieken  , indeed, I stopped the extensions like @aeschli said.
I will do a full day of coding and will report back later in the day.

@aeschli , @bpasero , @jrieken
1.9.1 Update - still being able to reproduce without failing. Any time.
Disabled all extensions one by one.
I still think that Git markers that appear on the left cause this drop. The moment I go on a new line, start typing and get a green bar on the left, which means there is a new change that can be staged and pushed, is when intellisense stops.

@joaomoreno FYI

Can you reproduce in a workspace that is not a git repository?

@joaomoreno this also works at random. I am really frustrated.
Here is a CPU profile at the time of the issue.
CPU-20170209T121404.zip

@sqnkov Can you reproduce in a workspace that is not a git repository?

The CPU profile that I've just uploaded is recorded in a non-Git environment.

So, I assume it still happens even with Git disabled.
It's definitely very strange that it still reproduces with code --disable-extensions... so can I ask you to show us a CPU profile in that situation instead?

All extensions disabled:
CPU-20170209T131311.zip

Thanks a lot @sqnkov for your help, it is very much appreciated. It would be awesome if you can stick with us, as we're trying to nail this freezes (a.k.a intellisense stops to work).
The profile unfortunately doesn't tell me much as it only shows what's happening in the renderer process. What is busy is the extension host process or the CSS language server process and we only have limited capability to see what's going on there.
Experiment 1:

launch code with code --logExtensionHostCommunication. Open the dev tools and observe the console. There are going to be a lot of messages. What's interesting is, what is the communication when you see the 'freeze'. Is the Extension host talking back to the Window? What's the last request that the Window sent to the Extension hist.

Experiment 2:

set user setting "css.trace.server": "messages". Open the output view on the 'CSS Language Server' tab. This logs the communication between the extension host and the css language server (again a separate process). My theory is that while the 'freeze' there will not be any communication as the extension host is frozen.

Experiment 3:

Check out the OS processes view. In windows, look at the 'Details' tab, sort by process 'Code' and observe the 'CPU', 'Memory' and 'Command Line' column while you see the freeze.

@aeschli , where are the logs from the console stored? I have the option checked.

You can access and save t from the Dev Tools Console:

Help > Toggle Developer Tools
in the dev tool, open the 'Console' tab
right click in the console: Save As...

Took a bit longer this time, but still managed to freeze it. You will see it near the end, along with a lot of Ctrl+z
-1486640401448.zip

What are the steps you are doing? Typing, Ctrl+Space, Typing, Undo, Ctrl+Space ?

@aeschli I am basically clicking on a row, hitting enter, start typing a property, if intellisense appears, I hit Ctrl+Backspace to delete the property that I've just created, select a new row, repeat.
I am not using Ctrl+Space at all.
But as I use it just now, it seems to be loading some type of intellisense stuff, or something like that.

From the log it seems that extensions are still active, e.g. the SirTori/indenticator extension still writes to the status bar.

Can you start code with
code --disableExtensions --logExtensionHostCommunication

Once code hast started, can you open the console and paste to the dev tools command line
var oldLog = console.log; console.log = function() { oldLog(JSON.stringify(arguments)); };

That will give us some nicer rendering

Then reproduce the error as before, and save the log.

Also if you have any insights from Experiment 2. I'd love to see what the last messages were to the language server.

BTW, thanks again for your time. I truly appreciate it.

@aeschli
Experiment 2 Output:
[Trace - 17:06:38] Sending request 'initialize - (0)'.
[Trace - 17:06:38] Received response 'initialize - (0)' in 188ms.
[Trace - 17:06:38] Sending notification 'initialized'.
[Trace - 17:06:38] Sending notification '$/setTraceNotification'.
[Trace - 17:06:38] Sending notification 'workspace/didChangeConfiguration'.
[Trace - 17:06:38] Sending notification 'textDocument/didOpen'.
[Trace - 17:06:39] Sending request 'css/colorSymbols - (1)'.
[Trace - 17:06:39] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:39] Received response 'css/colorSymbols - (1)' in 242ms.
[Trace - 17:06:41] Sending notification 'textDocument/didChange'.
[Trace - 17:06:41] Sending notification 'textDocument/didChange'.
[Trace - 17:06:41] Sending request 'textDocument/codeAction - (2)'.
[Trace - 17:06:41] Sending request 'textDocument/completion - (3)'.
[Trace - 17:06:41] Received response 'textDocument/codeAction - (2)' in 285ms.
[Trace - 17:06:41] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:41] Received response 'textDocument/completion - (3)' in 433ms.
[Trace - 17:06:41] Sending request 'css/colorSymbols - (4)'.
[Trace - 17:06:41] Received response 'css/colorSymbols - (4)' in 10ms.
[Trace - 17:06:42] Sending notification 'textDocument/didChange'.
[Trace - 17:06:42] Sending request 'textDocument/codeAction - (5)'.
[Trace - 17:06:42] Received response 'textDocument/codeAction - (5)' in 206ms.
[Trace - 17:06:42] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:42] Sending notification 'textDocument/didChange'.
[Trace - 17:06:42] Sending request 'textDocument/codeAction - (6)'.
[Trace - 17:06:42] Received response 'textDocument/codeAction - (6)' in 199ms.
[Trace - 17:06:42] Sending notification 'textDocument/didChange'.
[Trace - 17:06:42] Sending request 'textDocument/codeAction - (7)'.
[Trace - 17:06:42] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:42] Sending notification 'textDocument/didChange'.
[Trace - 17:06:42] Sending request 'textDocument/codeAction - (8)'.
[Trace - 17:06:42] Received response 'textDocument/codeAction - (7)' in 250ms.
[Trace - 17:06:43] Received response 'textDocument/codeAction - (8)' in 340ms.
[Trace - 17:06:43] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:43] Sending request 'css/colorSymbols - (9)'.
[Trace - 17:06:43] Received response 'css/colorSymbols - (9)' in 10ms.
[Trace - 17:06:43] Sending notification 'textDocument/didChange'.
[Trace - 17:06:44] Sending request 'css/colorSymbols - (10)'.
[Trace - 17:06:44] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:44] Received response 'css/colorSymbols - (10)' in 165ms.
[Trace - 17:06:44] Sending notification 'textDocument/didChange'.
[Trace - 17:06:44] Sending request 'css/colorSymbols - (11)'.
[Trace - 17:06:44] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:44] Received response 'css/colorSymbols - (11)' in 153ms.
[Trace - 17:06:46] Sending notification 'textDocument/didChange'.
[Trace - 17:06:46] Sending request 'textDocument/codeAction - (12)'.
[Trace - 17:06:46] Sending request 'textDocument/completion - (13)'.
[Trace - 17:06:46] Received response 'textDocument/codeAction - (12)' in 216ms.
[Trace - 17:06:47] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:47] Received response 'textDocument/completion - (13)' in 314ms.
[Trace - 17:06:47] Sending notification 'textDocument/didChange'.
[Trace - 17:06:47] Sending request 'textDocument/codeAction - (14)'.
[Trace - 17:06:47] Received response 'textDocument/codeAction - (14)' in 186ms.
[Trace - 17:06:47] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:47] Sending notification 'textDocument/didChange'.
[Trace - 17:06:47] Sending request 'textDocument/codeAction - (15)'.
[Trace - 17:06:47] Sending notification 'textDocument/didChange'.
[Trace - 17:06:47] Sending request 'textDocument/codeAction - (16)'.
[Trace - 17:06:47] Received response 'textDocument/codeAction - (15)' in 308ms.
[Trace - 17:06:47] Sending notification 'textDocument/didChange'.
[Trace - 17:06:47] Sending request 'textDocument/codeAction - (17)'.
[Trace - 17:06:48] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:48] Sending notification 'textDocument/didChange'.
[Trace - 17:06:48] Sending request 'textDocument/codeAction - (18)'.
[Trace - 17:06:48] Received response 'textDocument/codeAction - (16)' in 660ms.
[Trace - 17:06:48] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:48] Received response 'textDocument/codeAction - (17)' in 470ms.
[Trace - 17:06:48] Sending request 'textDocument/codeAction - (19)'.
[Trace - 17:06:48] Received response 'textDocument/codeAction - (18)' in 412ms.
[Trace - 17:06:48] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:48] Received response 'textDocument/codeAction - (19)' in 259ms.
[Trace - 17:06:48] Sending request 'css/colorSymbols - (20)'.
[Trace - 17:06:48] Received response 'css/colorSymbols - (20)' in 12ms.
[Trace - 17:06:48] Sending notification 'textDocument/didChange'.
[Trace - 17:06:48] Sending request 'textDocument/codeAction - (21)'.
[Trace - 17:06:49] Sending notification 'textDocument/didChange'.
[Trace - 17:06:49] Sending request 'textDocument/codeAction - (22)'.
[Trace - 17:06:49] Received response 'textDocument/codeAction - (21)' in 272ms.
[Trace - 17:06:49] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:49] Received response 'textDocument/codeAction - (22)' in 306ms.
[Trace - 17:06:49] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:49] Sending notification 'textDocument/didChange'.
[Trace - 17:06:49] Sending notification 'textDocument/didChange'.
[Trace - 17:06:50] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:50] Sending notification 'textDocument/didChange'.
[Trace - 17:06:50] Sending notification 'textDocument/didSave'.
[Trace - 17:06:50] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:50] Sending request 'css/colorSymbols - (23)'.
[Trace - 17:06:50] Received response 'css/colorSymbols - (23)' in 213ms.
[Trace - 17:06:50] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:52] Sending request 'textDocument/documentHighlight - (24)'.
[Trace - 17:06:52] Sending request 'textDocument/codeAction - (25)'.
[Trace - 17:06:52] Received response 'textDocument/documentHighlight - (24)' in 28ms.
[Trace - 17:06:52] Received response 'textDocument/codeAction - (25)' in 29ms.
[Trace - 17:06:53] Sending notification 'textDocument/didChange'.
[Trace - 17:06:53] Sending request 'css/colorSymbols - (26)'.
[Trace - 17:06:53] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:53] Received response 'css/colorSymbols - (26)' in 178ms.
[Trace - 17:06:54] Sending notification 'textDocument/didChange'.
[Trace - 17:06:54] Sending request 'css/colorSymbols - (27)'.
[Trace - 17:06:54] Received notification 'textDocument/publishDiagnostics'.
[Trace - 17:06:54] Received response 'css/colorSymbols - (27)' in 170ms.
[Trace - 17:06:56] Sending notification 'textDocument/didChange'.
[Trace - 17:06:56] Sending request 'textDocument/codeAction - (28)'.
[Trace - 17:06:56] Sending request 'textDocument/completion - (29)'.

And the log file with --disableExtensions --logExtensionHostCommunication
-1486652678891.zip

Amazing, thanks. So the last message for the language server is a completion request without any response. After that, you still type, but don't see no code assist windows are seen anymore, nor any requests are sent to the extension host?

Exactly.
The typing and row manipulation afterwards are just repeated attempts, to see if it is just some lag, but I think this is a more serious issue. I saw a 660 ms request from something in the tracer:
[Trace - 17:06:48] Received response 'textDocument/codeAction - (16)' in 660ms. - is this normal?
I hope there is a fix for all this.

@aeschli , did you managed to derive some verification from all this?

Sorry, haven't find the culprit yet...

this is fixed on
https://github.com/Microsoft/vscode/commit/cc69bea6dfd868d010d88504a4b6a69aa52ee624 ?

@sqnkov I think we found the issue. Thanks a lot for your help. You can verify the fix in the latest insiders build.

@aeschli , everything seems to be working fine now. Thanks for that!

@aeschli , thanks , looking forward to the next release.

verified based on @sqnkov 's comment

Hello!
I didn't want to open up a new Issue for this.
I am still having this problem, mainly with .ts/TypeScript and .js/JavaScript files.
I can work 10 Minutes, up to two hours until Intellisense just freezes,. If i press CTRL+Space, it only says "Loading...", but never actually loads the typings up anymore. I need to Restart VSCode to have it working again.
I am on VSCode 1.11.1
Installed Plugins:
abusaidm.html-snippets
Angular.ng-template
christian-kohler.path-intellisense
DavidAnson.vscode-markdownlint
dbaeumer.vscode-eslint
donjayamanne.githistory
DotJoshJohnson.xml
eg2.tslint
fantasytyx.tortoise-svn
filipw.scriptcsRunner
lonefy.vscode-JS-CSS-HTML-formatter
michelemelluso.code-beautifier
mkaufman.HTMLHint
mquandalle.graphql
mrmlnc.vscode-csscomb
ms-vscode.csharp
ms-vscode.PowerShell
msjsdiag.debugger-for-chrome
polunzh.start-git
vismalietuva.vscode-angular-support
xabikos.JavaScriptSnippets

All Plugins are up-to-date.
But I have this behaviour even without any active/installed Plugins.
Maybe it's worth noting that we have a pretty huge project (several hundret .ts/.js files), maybe it has something to do with that?

@aeschli , I can confirm @Z3roCoder 's information.
The issue is back at full power.

@sqnkov @Z3roCoder Please file a new issue. Please try with no extensions and please give detailed information where exactly the freeze happens. In what language, in what size of a file. Code examples are very useful.


A lot of established connections on rancher servers hosts

Useful
Info

Versions
Rancher v1.6.2 Cattle: v0.181.4 UI: v1.6.5

Access
openldap admin

Orchestration
Cattle

Route
stacks.index

Part of netstat:
...
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:40104
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:49502
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:36564
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:53786
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:44044
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:58220
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:49788
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:39946
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:54732
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:36436
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:55418
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:55454
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:52358
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:51402
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:47480
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:60120
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:56950
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:37470
ESTAB      0      0         ::ffff:10.0.x.x:8080    ::ffff:<IP_ADDRESS>:41232
...

I got this message.
Error: Requested content '<IP_ADDRESS>:8080/' cannot be accessed. Server data timeout.

Same with https://github.com/rancher/rancher/issues/9306 .
Scheduler v0.8.2 will fix this issue.


Simplify windows paths & better class support

Hi,
I think this package is really neat, and makes it so much easier to work with BayesTraits. Wonderful!
I was having some problems with running the code on Windows with a working directory that contained spaces. While attempting to fix this issue (by quoting paths etc.) I realized that the code can be simplified a lot.
Since shell already uses the current working directory as the path, there is no need at all to manually construct the file paths by concatenating the file names with the working directory.
note: it seems to me that the same changes can be made to the unix code, but I run on Windows right now so cannot test.
Secondly, I made the checking at the start a bit more general. Instead of checking for class == 'data.frame', using the inherits(data, 'data.frame') makes sure that the derived data.frame classes (the tibble family and data.table) also work out of the box.
Please let me know if you have any comments, and if you think this is useful.

Thank you for taking the time to fix the code! These are very helpful changes. I use tibbles all the time and should have thought of that. I think you're right that the code could probably be simplified for MacOS too, and I usually use MacOS so I will look into that.

There is no should in working open software!


Creation time should sort by sysstamp

Hi,
I have about 12 albums on my server. I changed all of their sysstamp to the right date, but there is an album, where I did not change the sysstamp value, which is set to March 2016. All the other albums are older and show in the right order (Sorting: Creation Time, desc). The date shown under the album name is correct everywhere, but the March 2016 album is listed last instead of first.
Thanks for helping.
Version 3.1 #475

So, after some debugging and changing some values in the database I found out something. Lychee, even if it's set to sort albums by creation time (sysstamp), sorts albums by the album ID, which is an option Lychee does not even include :laughing:
I just can't figure out how to change the setting in the lychee_settings database since phpMyAdmin tells me I can't edit it...

Sorting by creation time is the same as sorting by id. New albums always have a higher id than the previous ones. But yes, I agree that's confusing when changing the sysstamp. Should be updated.

Edit: Will stay with "creation time" === "id" for now. It might be possible to edit the sysstamp through the interface in a future version. A new option "date" would than sort by sysstamp.

How can I manually tweak the ordering then ? Should I modify the ID ?


Cannot compile string_view_test.cc due to constexpr errors

Hi,
Got a compilation issue here. Any help is much appreciated! Thanks in advance.
I will provide as much information as I can. Let me know if more is needed for people to debug.
OS: Ubuntu 16.04
CPU: x86_64
Compiler: clang-5.0.0 (the clang-based toolchain is fully installed under /opt/clang/5.0.0 on the OS)
branch: master (720c017e30339fd1786ce4aac68bc8559736e53f)
Build using Bazel.
Tweaked the original BUILD.bazel files to build when included as source.

That's ... odd.  The char* c'tor for string_view should be constexpr, as should the underlying call to char_traits::length.
http://eel.is/c++draft/string.view.cons
http://eel.is/c++draft/char.traits.specializations.char
Seems likely to be a stdlib bug?  But still perhaps something that we need to work around.
Assigning to @zhangxy988 to investigate.

First, note that absl::string_view is just an alias to std::string_view in your setting.
Second, the issue here is: char_traits<char>::length(nullptr) is currently undefined by the standard. libstdc++ considers it to be 0, but libc++ thinks it is invalid (out of range) and forbids nullptr in constexpr context. See https://godbolt.org/g/CUnpGe for a minimal reproduction of the issue.
Regardless of whether the standard will define this behavior or not, I'll need to work around this issue in string_view_test by conditional compilation. We also need to update our internal integration test to cover this setting. Please allow a few days before the fix gets in.
Thanks for reporting this issue to us!

Hi @zhangxy988 ,
Thanks!
Ah, I believe you are correct! I am using libc++ instead of libstdc++ and the issue you linked is exactly what the error was about. Thanks for replying so promptly!
Please feel free to let me know if any more information and testing is needed on me.
Best,
Zhongming


Fix route extraction

Fix route extraction
Add more tests

Pull Request Test Coverage Report for Build 7

19 of 20 (95.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.0%) to 95.238%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/metrics-middleware.js
19
20
95.0%

Totals

Change from base Build 3:
8.0%

Covered Lines:
50

Relevant Lines:
51

💛  - Coveralls

Pull Request Test Coverage Report for Build 7

19 of 20 (95.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.0%) to 95.238%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/metrics-middleware.js
19
20
95.0%

Totals

Change from base Build 3:
8.0%

Covered Lines:
50

Relevant Lines:
51

💛  - Coveralls


Add Programmed mode

Hi,
My normal (presence) mode is programmed mode, because it helps me in case i forget to arm cameras at night.
The integration is not compatible with Programmed mode, yet this could be a useful feature.
Regards.

What does programmed mean? Tell me more, probably with a page link describing the feature

There is already a service called schedule, it will switch to that mode. Please go through readme or examine existing services.


Removing parameter on Add Current file to project command

Hi,
I am having Content files in project somewhat like this
<ItemGroup>
    <Content Include="Data/pincodes.csv" CopyToPublishDirectory="PreserveNewest"/>
 </ItemGroup>

Other than main item group where all the F# files are there. But when I am adding a new F# file using the command F# add current file to project. It is arranging this and removing CopyToPublishDirectory="PreserveNewest". Arranging is OK. But removing the parameter is breaking the project.
It would be great if you can provide a workaround or point me if I am doing it wrong somewhere.

That's a limitation of Forge. See #679.
The only workaround is to edit the project file by hand.

Should be fixed with 5.0


Add bars to the chart for the geometric mean of all the bars in the chart for each ruby version

Refactor bar chart into data phase and drawing phase
Add bars at the end of the chart for geomean of all speedups

Note that this is not a geomean of all benchmark speedups, just the benchmarks included on each chart.
Thoughts on the style?
Do we like the bars?  We could also put the number (2.05x) in the legend by each ruby name 🤷 .

Do we want anything else?
We already have

at the top which is the geomean of the headline benchmarks comparing CRuby dev to YJIT dev
(whereas the new bars compare the baseline (CRuby stable) to each other version).
So they are close but different.

Thoughts on the style? Do we like the bars? We could also put the number (2.05x) in the legend by each ruby name 🤷 .

I think it looks good. We could potentially put a number below the legend for each? That would make sense.
One small comment is that it should be possible to compute error bars for the geomean as well. IIRC there is a formula for that. Feel free to do that as a separate PR if you prefer. IIRC I've done this a long time ago for my PhD and may be able to dig up the old Python code if helpful.

at the top which is the geomean of the headline benchmarks comparing CRuby dev to YJIT dev (whereas the new bars compare the baseline (CRuby stable) to each other version). So they are close but different.

Good point. Ideally we should make these figures the same as the new geomean bars for simplicity. We should probably say something like "Overall YJIT is 70.0% faster than the CRuby 3.3.1 interpreter, and railsbench specifically runs 77.8% faster with YJIT." (without the exclamation points).

For the YJIT 3.3.1 the data looks like this:
irb|3.3.0 /main:120:0:> values
 =>
[2.2657585242448564,
 1.5708325894402306,
 2.059392010268813,
 1.7226601255477567,
 1.3928198109254495,
 1.3054977436962951,
 2.4261204639049425,
 1.3942077457555093,
 1.5858192632742103,
 1.576269153146121,
 1.9305577209806641,
 1.5826211702531454,
 1.5175470469094292,
 1.2370932021502943]
irb|3.3.0 /main:121:0:> geomean(values)
 => 1.6505173934796604
*irb|3.3.0 /main:122:0:> geo_stddev(values)
 => 1.2247992631041489
# I don't know if this calculation is useful, I made it up after seeing the relative stddev used on the other bars.
*irb|3.3.0 /main:123:0:> geo_stddev(values) / geomean(values)
 => 0.742069891503535

Thanks, I appreciate it.
@paracycle had some thoughts, but I feel like I need to take a course on statistics and probabilities (perhaps https://www.khanacademy.org/math/statistics-probability/random-variables-stats-library) to learn how to do this correctly 😅
So, perhaps we'll get to this eventually :)

I removed the error bars commit for now


Publish Release Candidate Docker Images

The master builds are published as docker images on dockerhub. However, I cannot find the release candidates. I think those should be easy to test to allow people to easily test them before the actual release. For that, it would be helpful if you can publish the release candidate docker images on dockerhub with their respective tag.

I just noticed that the 1.0 RCs had been published to dockerhub. Unfortunately, the 1.2 RCs aren't.

Bump.
v1.3.0 has been released 8 days ago but unfortunately there still isn't any docker image available.

Closing this issue as RC tags are being published to docker hub:
2.0.1rc6
1.5.3rc1


Fix deep-reblame css selector

Is needs to be stronger.
When we made it originally we used a. but then we changed it to a button so we removed the a. Github has link-hover-blue we have 2 options, remove Githubs or change our selector.
<!--

Thanks for contributing! 🍄

1. LINKED ISSUES:
   Does this PR close/fix an existing issue? Write something like `Closes #10`

2. TEST URLS:
   Add some test URLs

3. SCREENSHOT:
   Add a screenshot here if your PR makes visual changes

Missing testing links as always...


Brutilize problem

Sometimes i noclip below the floor when using it.
Mod list if needed: 018fb6f1-1880-60f5-b01d-a5fa61d2645b

All dashes that pierce do this including things like merc


Add Hash to avoid duplicate email and a merge feature for two csv files

We don't need to merge different CSV now.
Make sure emails are sorted correctly even from the same day
Write some test cases for function in the PR


Use docker 1.10 user namespacing

Docker 1.10 introduces user namespacing. This allows us to lock down the docker daemon to a non root user account.
This means doing
docker run -it -v /:/hostroot busybox touch /hostroot/things-owned-by-root

Will no longer be able to modify the host as root.
Apart from being much more secure, it means that files created inside a docker based build script will be owned by buildkite-agent, instead of root. This happens often when projects volume mount the project root into the container.
This is a brand new feature, and there are likely to be bugs. At the very least wait till 1.10.3 for https://github.com/docker/docker/pull/20446 to be fixed.
Things that do not work with userns:

Using --privileged mode flag on docker run
sharing PID or NET namespaces with the host (--pid=host or --net=host)
sharing a network namespace with an existing container (--net=container:other)
sharing an IPC namespace with an existing container (--ipc=container:other)
A --readonly container filesystem (this is a Linux kernel restriction against remounting with modified flags of a currently mounted filesystem when inside a user namespace)
external (volume or graph) drivers which are unaware/incapable of using daemon user mappings

This also solves #30

I also don't think docker 1.10 is available yet for the Amazon Linux AMI (which this AMI depends on) :(

Indeed, although the worse blocker is an open bug in 1.10. This PR will hang around until 1.10.1 is out.

On Mar 3, 2016, at 8:09 AM, Jerome Gravel-Niquet<EMAIL_ADDRESS>wrote:
I also don't think docker 1.10 is available yet for the Amazon Linux AMI (which this AMI depends on) :(
—
Reply to this email directly or view it on GitHub.

I've updated this to use docker 1.10.3, should be good to go but CI dosent seem to trigger on 3rd PRs.


docs(samples): add runReport samples for dimension inlist and exclude filters

I'd like to mere #206 before merging these samples. Thanks!


urserver: <IP_ADDRESS>5 -> <IP_ADDRESS>5

Motivation for this change
New upstream release, has apparently been available for some time, but I missed it.
Things done
Also tested that it still runs as a service, and still does the things I used it for.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114727 at fba127b9 run on x86_64-linux 1

1 package built:

urserver

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/urserver/default.nix:31:3:
   |
31 |   installPhase = ''
   |   ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 114727 run on x86_64-linux 1

1 package built:

urserver

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

urserver:

warning: build-tools-in-build-inputs
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/urserver/default.nix:23:3:
   |
23 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

Have to be a bit careful since the buildInputs paths are added at runtime, but it seems to work still.


API tests fail Intermittently on coreApiMain/checksums.feature

Failed Build: https://drone.owncloud.com/owncloud/ocis/23619/59/5
@issue-1296
  Scenario Outline: uploading a file with checksum should work for file with special characters                                                              # /drone/src/tests/acceptance/features/coreApiMain/checksums.feature:334
    Given using <dav_version> DAV path                                                                                # FeatureContext::usingOldOrNewDavPath()
    When user "Alice" uploads file "filesForUpload/textfile.txt" to <renamed_file> with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" using the WebDAV API # ChecksumContext::userUploadsFileToWithChecksumUsingTheAPI()
    Then the HTTP status code should be "201"                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file <renamed_file> for user "Alice" should be:                                                                                # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.

      Cheers.
      """

    Examples:
      | dav_version | renamed_file      |
      | old         | " oc?test=ab&cd " |
      | old         | "# %ab ab?=ed"    |
      | new         | " oc?test=ab&cd " |
        Failed step: And the content of file " oc?test=ab&cd " for user "Alice" should be:
        The content was expected to be 'This is a testfile.

        Cheers.', but actually is ''. HTTP status was 404
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''
      | new         | "# %ab ab?=ed"    |
      | spaces      | " oc?test=ab&cd " |
      | spaces      | "# %ab ab?=ed"    |

This failure cannot be reproduced locally. Checked on CI where this scenario is checked for 67 times. There were no failures on CI related to this scenario. https://drone.owncloud.com/owncloud/ocis/23660/44/5

depends on the usage of contentOfFileForUserShouldBe function. Could you paste the link to the function here?

https://github.com/owncloud/ocis/blob/753c8f2372cf42fffbf1ba13606516577119dca3/tests/acceptance/features/bootstrap/WebDav.php#L1184


tensorrt_llm_bls disregards top_k / temperature setting

System Info
Triton + TRT-LLM 0.9.0, llama2 70b model, fp8 quantization, run on 2xH100 80GB, tp 2, pp 1
config.pbtxt for tensorrt_llm_bls (otherwise unchanged):
parameters: {
  key: "accumulate_tokens"
  value: {
    string_value: "true"
  }
}
parameters: {
  key: "tensorrt_llm_model_name"
  value: {
    string_value: "tensorrt_llm"
  }
}

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
curl -X POST localhost:8000/v2/models/tensorrt_llm_bls/generate -d '{"text_input": "What is machine learning?", "max_tokens": 20, "bad_words": "", "stop_words": "", "temperature": 100.0, "top_k": 100}'

output
{"context_logits":0.0,"cum_log_probs":0.0,"generation_logits":0.0,"model_name":"tensorrt_llm_bls","model_version":"1","output_log_probs":[0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0],"text_output":"- Quora\nMachine learning is a field of artificial intelligence which enables machines to learn without being specifically"}

Expected behavior
given temperature 100.0 and top_k 100, one would expect a nonsensical (and not the canonical) answer
actual behavior
see above, the reproduction part
additional notes
Ensemble model works as expected. I have sent the following request to the same running engine just a few seconds after the tensorrt_llm_bls request above:
curl -X POST localhost:8000/v2/models/ensemble/generate -d '{"text_input": "What is machine learning?", "max_tokens": 20, "bad_words": "", "stop_words": "", "temperature": 100.0, "top_k": 100}'

output:
{"model_name":"ensemble","model_version":"1","sequence_end":false,"sequence_id":0,"sequence_start":false,"text_output":"Crussischroo-Nau ™ Technocrord! Evaluuj poddano"}

Hi，Did you solve this problem？
I met the same problem with using TRT-LLM 0.9.0 and TRT-LLM 0.7.0.

@Elissa0723
Hi, I am sorry for the late reply. Not yet. We did not need tensorrt_llm_bls (streaming) for some time. I expect to give it a try after TRT-LLM 0.12.0 is released. Besides, there could be similar issue when inferring using grpc, but I need to investigate this first.

Hi @janpetrov @Elissa0723 , the "disregarding" of temperature should be fixed with this PR: https://github.com/triton-inference-server/tensorrtllm_backend/pull/578. You should see that temperature is now correctly passed when using the BLS model: https://github.com/triton-inference-server/tensorrtllm_backend/blob/edf17484f98e64d0ec1d267323d3a478d72decdb/all_models/inflight_batcher_llm/tensorrt_llm_bls/1/lib/triton_decoder.py#L401, whereas it wasn't being passed before this PR.

thank you for mentioning and repairing this, works now


Add Heap Record-Replay, -memory record

This is an interesting idea. Can you add more information about possible use cases for this?

Added. I wrote this to help diagnose what Laghos was doing that caused the Isomempool to perform so poorly. By inspecting the output files I could see that it was allocating and then freeing the same two sequences of buffers tens of thousands of times.


UI Issue: Missing User Name With  Images After Sign In

Description
The "Sign In" button is not visible in the dashboard site after the user is signed in, this is applicable only for those users whose profile picture is not stored in the database.
Steps to Reproduce (only if your image URL is not stored in the database):

Navigate to the homepage of the dashboard site.
If you are already signed in you can see that the 'sign in with github' button is not visible, neither the 'hello, username' is visible.

Expected Behavior:
After Sign In, the user should be able to see the name and image (or a default image) on the top right corner of the page.
Current Behavior:

Is this issue open? can I work on this?

Khemchand is working on this issue


Screen Width

Was having an issue with WIndows 10 and a large UHD monitor etc
So I started to google...
I noticed trying  http://gregquan.com/detect/  if I am in OS mode 150% - recommanded you return device width and height as 2560 by 1440 pixels. - so does a demo java program I found with same search that use screen.width and height..  I also noticed that most website don't have this problem but the newyork time in chrome does - the font title in their case is like 1 inch high on that monitor..  You do report the right dimension when I set the OS preference to 100% but it's not workable as everything is way too tiny.
However if I go here:  http://www.infobyip.com/detectscreenresolution.php
It reports the right size (3820x2160)...

Hi Pierre,
What you are describing seems like expected behavior. If you set your OS zoom level to 150% with a native resolution of 3820x2160, it effectively only draws 2560x1440 unique pixels.
-Greg

Here's a little test for you why I think it's misleading and misleads people
I have a windows 10 system with a UHD monitor
The specs are as follow:  3840x2160, 144 ppi and I set the OS display setup to 1.5X which is Microsoft recommended setup.
I open a .png file in any desktop app - a single horizontal or vertical line is still a line and the image at 100% has all the pixels - no image scaling
Now open the same image in Google chrome. FIrst thing you will notice is it's real small.- I need to set Chrome to 175% to have the image shown at the expected size (e.g. if the image is UHD that it covers the whole screen). Doing this the result is a blurry image (the higher res the display, the more blurry the image).  There appears even to be two scaling happening, aside the image zoom to 175% there is either a pre scaled down first or an assumption that a bitmap has a certain dpi.  Not sure the reason yet, but net is it's not possible to review work over the internet through a browser because of that.


How do we run test.sh on test dir?

I found the test dataset and training dataset are the same. So the first time I run the model and run the test.sh, I found the accuracy is about 90%. So I split training set to 2 parts (train and test) and want to run test.sh on the test dataset. But it will always showing it will get img from training dir.
Something like this
  File "test_net.py", line 69, in <module>
    imdb, roidb, ratio_list, ratio_index = combined_roidb('kitti_val', False)
  File "/home/yujiaq3/Stereo-RCNN/lib/roi_data_layer/roidb.py", line 123, in combined_roidb
    roidbs = [get_roidb(s) for s in imdb_names.split('+')]
  File "/home/yujiaq3/Stereo-RCNN/lib/roi_data_layer/roidb.py", line 115, in get_roidb
    print("get_roidb start",imdb_name, len(imdb.roidb), imdb.roidb)
  File "/home/yujiaq3/Stereo-RCNN/lib/datasets/imdb.py", line 77, in roidb
    self._roidb = self.roidb_handler()
  File "/home/yujiaq3/Stereo-RCNN/lib/datasets/kitti.py", line 134, in gt_roidb
    for index in self.image_index]
  File "/home/yujiaq3/Stereo-RCNN/lib/datasets/kitti.py", line 209, in _load_kitti_annotation
    objects_origin = kitti_utils.read_obj_data(filename, calib_it, im_left.shape)
  File "/home/yujiaq3/Stereo-RCNN/lib/model/utils/kitti_utils.py", line 173, in read_obj_data
    detection_data = open(LABEL_PATH, 'r')
IOError: [Errno 2] No such file or directory: './data/kitti/object/training/label_2/007000.txt'

And also I met this problem,
./data/kitti/object/training/calib/007000.txt
Traceback (most recent call last):
  File "test_net.py", line 296, in <module>
    calib, alpha, dim, box_left, box_right, cls_kpts[detect_idx])
  File "/home/yujiaq3/Stereo-RCNN/lib/model/utils/box_estimator.py", line 216, in solve_x_y_z_theta_from_kpt
    alpha = kpt2alpha(kpt_pos, kpt_type, box_left)
  File "/home/yujiaq3/Stereo-RCNN/lib/model/utils/box_estimator.py", line 159, in kpt2alpha
    alpha = -m.pi/2 - m.asin(clamp((kpt_pos-box[0])/box_width,-1,1))   # 0 -> -90, 1 -> -180
TypeError: sub() received an invalid combination of arguments - got (numpy.float32), but expected one of:
 * (Tensor other, Number alpha)
 * (Number other, Number alpha)

Same question
It is beyond logic and above reason

Since the label of the test set is not publicly available, we split the training set into train and validation split following the previous work. We provide the training split in the data folder, which are commonly used in extensive 3D object detection works. You don't need to split the training set by yourself.
The second issue is due to the incompatibility between PyTorch tensor and numpy.array. Please make sure your pytorch version is consistent with we specified in the readme, or convert thet data type handly.

由于测试集的标签不是公开可用的，因此我们按照先前的工作将训练集分为训练和验证。我们在data文件夹中提供训练分组，通常在广泛的3D对象检测工作中使用该训练分组。您无需自己拆分训练集。
第二个问题是由于PyTorch张量与numpy.array不兼容。请确保您的pytorch版本与自述文件中指定的版本一致，或手动转换数据类型。

Thanks for answers.
How to use the model on my own data？

Since the label of the test set is not publicly available, we split the training set into train and validation split following the previous work. We provide the training split in the data folder, which are commonly used in extensive 3D object detection works. You don't need to split the training set by yourself.
The second issue is due to the incompatibility between PyTorch tensor and numpy.array. Please make sure your pytorch version is consistent with we specified in the readme, or convert thet data type handly.

Thanks for answers.
How to use the model on my own data？

Did anyone figure out how to get it to work on your own test data?


Bump common utils in server/

Bump common-utils in server/

I thought this was supposed to be into next because you're bumping to 0.33.1 as this is a breaking change. It's not a pressing issue that you get this into main right away. Having it in next is fine as well.

@WayneFerrao let me know if I can help. Sorry for going dark, but ping me tomorrow if you want to chat.

Closed and reopened a new PR  to next


test_embed failure with Python 3.7.2 and cython 0.29.2

In Nixpkgs we run the test suite after building and installing. It failed with:
======================================================================
FAIL: test_embed (__main__.EmbedTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "runtests.py", line 1803, in test_embed
    "make PYTHON='%s' CYTHON='%s' LIBDIR1='%s' test > make.output" % (sys.executable, cython, libdir)))
AssertionError: 0 != 512

On the following page the reference to the log can be found:
https://hydra.nixos.org/build/86735910

I don't see any other reference to test_embed in the log.

Ah, right, the names of the specific files are different. This is the error:
/nix/store/3xwc1ip20b0p68sxqbjjll0va4pv5hbv-binutils-2.30/bin/ld: cannot find -lncurses
collect2: error: ld returned 1 exit status
make: *** [Makefile:19: embedded] Error 1

My guess is that CPython was somehow built with ncurses and remembered that in its distutils build flags, but during the Cython build, the library is not available. Not an actual Cython problem, rather a dependency problem with the specific CPython installation.

Ahh, thanks for showing that. We recently wiped some info from sysconfigdata in not a very clean way, so it may be related to that. Might have to do that. Thanks again!


Add User Agent information to understand usage

It's not clear how many users are using this library and should continue to support it.
We should include User-Agent header information with the name of library and version.
In discussion with @jesselovelace.

Ben you fixed this already. Marking closed unless I misunderstand.


Fix bugs related to the presence of time in date objects

I faced a bug that made me pull my hairs off for hours, but I've finally found the problem ! :fist_raised:
Here is a summary of my bug :
In my project I have two different datepickers, I pass them the exact same value for disabled-dates but for some reasons, one of them was displaying my available dates correctly while the other was showing every dates as disabled... arg ! Turns out the only difference between those two was that the first one had an initial date selected, while the other had none. So I dug from there...
Explanation :
And discovered that if no initial value is defined, a new date object would be created (new Date()) which would incorporate current time. Things works anyway, until it reaches that point : https://github.com/wmcmurray/vuejs-datepicker/blob/30d81e56a7f7f4cd05388266d48eaaa76d76bc4a/src/components/PickerDay.vue#L263
in my case it was checking (for exemple) if Jan 06 2019 19:00:00   >   Jan 06 2019 00:00:00 and was returning true because yes, its 19 hours bigger, so Jan 06 was shown as disabled even if it shouldn't.
Solution :
So I searched for every places where a new date object is created without params or with a user specified value (ex: openDate prop), and made sure the time is set to 0 on those.
BONUS POINTS : also found that the openDate prop validation in DateInput.vue was not the same as in Datepicker.vue (which where causing a vuejs error in console when we pass a string value).
Hope my explanations are clear enough ! :slightly_smiling_face:

Coverage remained the same at 100.0% when pulling 30d81e56a7f7f4cd05388266d48eaaa76d76bc4a on wmcmurray:fixes into 41061e85da288b9c9b86fb902896fa812599d744 on charliekassel:master.


Add a README

Should eventually contain a description of the program, how to compile, and how to run the tests.

May be appropriate to add that the naming convention for branches and commits is {feat | doc | bug | etc}/{issue number}.


Recheck Emission View Data Generation

Overview
During QA testing for https://github.com/US-EPA-CAMD/easey-ui/issues/5793 the following was found:
I've been seeing random instances where a lot of the other views are missing column data as well which may explain some of the comments above. I looked at this a bit closer and I see "CALL camdecmpswks.refresh_emissions_views..." getting stuck. In this example, it's been running for 15+ minutes. I saw others in there stuck for days but killed the processes. Does this procedure get called after an evaluation? That's when I've noticed it getting stuck and a lot of calculated columns missing data.
Your Mission

Correct the problem that caused the errors for the following in the Research  Information table below.

[x] DAILYCAL: Unable to recreate the problem.

#6203 had a duplicate key issue for ORIS 3, CS0AAN.

[x] MATSHG:

Unable to recreate the problem.
Updated query to correct speed problem by including RPT_PERIOD_ID in the where or on condition for any table with a RPT_PERIOD_ID partition.

[x] MATSSORBENT

Updated SQL to avoid the missing sampling train information that caused the no null constraint failure.
Updated query to correct speed problem by including RPT_PERIOD_ID in the where or on condition for any table with a RPT_PERIOD_ID partition.

Improve the speed of the following to less than or equal to 2 seconds.

[x] NOXAPPEMIXEDFUEL

Updated query again to correct speed problem by including RPT_PERIOD_ID in the where or on condition for any table with a RPT_PERIOD_ID partition.

[x] NOXMASSCEMS

Note that NOXMASSCEMS was updated as part of https://github.com/US-EPA-CAMD/easey-ui/issues/5793#issuecomment-2197236558 to remove the pivot method.  The time exceeded 100 seconds before that change.  Also read https://github.com/US-EPA-CAMD/easey-ui/issues/5793#issuecomment-2198594760.
Updated query again to correct speed problem by including RPT_PERIOD_ID in the where or on condition for any table with a RPT_PERIOD_ID partition.

[ ] Investigate reasons for "stuck process" mentioned in the the note from https://github.com/US-EPA-CAMD/easey-ui/issues/5793.  Determine whether the issues are related t the errors identified in the Research table below.

Research and Suggested Test Information.

EM View Code
Description
ORIS (Facility) - Locations
Quarter
Speed

ALL
All
1356 (Ghent) - CS023, 2, 3
2023 Q3
<= 2s

CO2APPD
CO2 App D
7697 (Washington County Cogen [Olin]) - CC1
2023 Q3
<= 2s

CO2CALC
CO2 Calc
147 (Kyrene Generating Station) - K-7
2023 Q3
<= 2s

CO2CEMS
CO2 CEMS
1356 (Ghent) - CS023, 2, 3
2023 Q3
<= 2s

CO2DAILYFUEL
CO2 Daily Fuel
260 (Moss Landing Power Plant) - 1A
2023 Q3
<= 2s

DAILYCAL
Daily Calibration
2712 (Roxboro) - CS004A, 4A, 4B
2023 Q3
<= 2s

HIAPPD
HI App D
7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
2023 Q3
<= 2s

HICEMS
HI CEMS
1356 (Ghent) - CS023, 2, 3
2023 Q3
<= 2s

HIUNITSTACK
HI Unit Stack
7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
2023 Q3
<= 2s

LME
LME
7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
2023 Q3
<= 2s

LTFF
Long Term Fuel FLow
1305 (McPherson 2) - CP001, GT1, GT3
2023 Q3
<= 2s

MASSOILCALC
Mass Oil Calc
1599 (Canal Station) - 1
2023 Q3
<= 2s

MATSHCL
MATS HCl
60 (Gerald Whelan Energy Center) - 1
2023 Q3
<= 2s

MATSHF
MATS HF

MATSHG
MATS Hg
2712 (Roxboro) - CS004A, 4A, 4B
2023 Q3
<= 2s

MATSSO2
MATS SO2
130 (Cross) - 1
2023 Q3
<= 2s

MATSSORBENT
MATS Sorbent Trap
887 (Joppa Steam) - CS1, 1, 2
2022 Q1
<= 2s

MATSWEEKLY
MATS Weekly Tests
2712 (Roxboro) - CS004A, 4A, 4B
2023 Q3
<= 2s

MOISTURE
Moisture
10298 (Air Liquide Bayport Complex) - CG804
2023 Q3
<= 2s

NOXAPPEMIXEDFUEL
NOx App E Mixed Fuel
7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
2023 Q3
<= 2s

NOXAPPESINGLEFUEL
NOx App E Single Fuel
6137 (A B Brown Generating Station) - 3
2023 Q3
<= 2s

NOXMASSCEMS
NOx Mass CEMS
880041 (Ascend [Decatur Plant]) - X015
2023 Q3
<= 2s

NOXRATECEMS
NOx Rate CEMS
7697 (Washington County Cogen [Olin]) - CC1
2023 Q3
<= 2s

NSPS4T
NSPS4T
645 (Big Bend) - BB05
2023 Q3
<= 2s

OTHERDAILY
Other Daily Tests
2712 (Roxboro) - CS004A, 4A, 4B
2023 Q3
<= 2s

SO2APPD
SO2 App D
7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
2023 Q3
<= 2s

SO2CEMS
SO2 CEMS
2712 (Roxboro) - CS004A, 4A, 4B
2023 Q3
<= 2s

Lookup Information

ORIS (Facility) - Locationss
MP ID

60 (Gerald Whelan Energy Center) - 1
MDC-19939DF8A9FD4C12B3869C394A2C0B1D

130 (Cross) - 1
MDC-3B23A43070D74F53AA2DAD83ABFC190C

147 (Kyrene Generating Station) - K-7
MDC-A386218BD0334270BDB2FBB2192D1C0A

260 (Moss Landing Power Plant) - 1A
MDC-F8343B35AEAB4AE8986E74C085B741BB

645 (Big Bend) - BB05
CESW-TUTBW-1FA14B71D64D45E69593A9F6ED66CD6E

887 (Joppa Steam) - CS1, 1, 2
MDC-0B5C7E00DEFD410A9B883B5E381A8C4B

1305 (McPherson 2) - CP001, GT1, GT3
BPU094-545C837365784BE781EDECEAA08626A3

1356 (Ghent) - CS023, 2, 3
PGGHNTPIEN-9B524FF4486B46CFA7942DB513344D0E

1599 (Canal Station) - 1
MDC-07AC944F78A043E08E21977F9DA727EA

2712 (Roxboro) - CS004A, 4A, 4B
MDC-4F0130B46ADB4B4F9C2EE0BA4A72D463

6137 (A B Brown Generating Station) - 3
MDC-98642474BB9D49CAB5CB11F2352A3598

7697 (Washington County Cogen (Olin)) - CC1
MDC-6F6D3CDF11584A639727CF10C34E3BB4

7760 (Tilton Power Station) - CP01, 1, 2, 3, 4
RMUENSTERL-FBE23B81FE4A4C6DADBDDAA1496DB309

10298 (Air Liquide Bayport Complex) - CG804
MDC-FE5F270AB1F64DF8855318C44501BAAF

880041 (Ascend (Decatur Plant)) - X015
MDC-EC0E1E1664394A6DB9DF0DBCFD5C93C1

Quarter
RP ID

2022 Q1
117

2023 Q3
123

Closing Comment
Additional changes and testing will occur a s part of #6410.


Shortcode mode fixes

This PR fixes bugs in "shortcode" mode:

Block "Place order button" when order is being submitted
Fixed "Term of service" flag detection
Suppress checkin warnings
Show "cart is empty" message when cart is empty

I don't quite understand the rationale behind this change, can you please write a bit in the description of every pull request why the pull request exists?

Sorry, was in hurry, so i didn't write description. Fixed.


Flee3: port new agent spawning to run_par.py

This is done now :)
https://github.com/djgroen/flee/commit/f9e90c700f0f57db53070f422012fffeac2c115d


Getting Client challenge required error

Hi,
thank you for making this amazing extension.  Today, when i tried to use the extension, it is constantly giving me the same error. I even checked my ChatGPT and relogged in also. I am still facing the same error. Can you please check it once .
Failed to load response from ChatGPT:
{"detail":{"message":"Client challenge required","code":"challenge_required"}}

@hunaidkhan2000  This means you have to login to chat.openai.com again.


[microTVM] Fix security vulnerability CVE-2007-4559

Borrowed from https://github.com/tlc-pack/relax/pull/335. The original author is @TrellixVulnTeam from the Advanced Research Center at Trellix.
This PR patches the security vulnerability CVE-2007-4559 in the Arduino and Zephyr Project API servers. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar  Model Library Format file could perform a directory path traversal attack, silently overwriting files outside the target project target dir when creating new projects, for instance. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. Further technical information about the vulnerability can be found in this blog.

Co-authored-by: TrellixVulnTeam<EMAIL_ADDRESS>

@YuchenJin I've tweaked a bit the PR description to tell give more context on how this CVE could affect the microTVM specifically.

cc @guberti since it also touches Arduino and also because tvm-bot didn't tag him :-)

@YuchenJin Friendly ping :-)

Thank you @gromero @guberti for the reviews and suggestions, updated accordingly.

@tvm-bot rerun

Not sure exactly what went wrong with Jenkins but it seems like there are a few legit CI errors still remaining

@driazati hm the error really doesn't seem to be related to the change proposed here. Could it be related to this change https://github.com/apache/tvm/pull/13812 and so needs a CI retrigger indeed?

The lint error (https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-lint/detail/PR-13751/3/pipeline) is definitely real so this will at least need a fix for that, a rebase probably wouldn't hurt either

The lint error (https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-lint/detail/PR-13751/3/pipeline) is definitely real so this will at least need a fix for that, a rebase probably wouldn't hurt either

@driazati ah, fair enough! I was looking at a different log: https://ci.tlcpack.ai/blue/rest/organizations/jenkins/pipelines/tvm-arm/branches/PR-13751/runs/3/nodes/104/steps/142/log/?start=0

@tvm-bot retrigger

@tvm-bot rerun

Hi, just a random heads up that this fix for path traversal in tar.extractall is insufficient. Here you can read more information about it: https://github.com/python/cpython/issues/74453#issuecomment-1500321322


Add 'returntype' case to MethodGenerator::fromArray()

Can you add a test for this, please?

Sure, I'll get to it tonight hopefully.

All done.

Merged into develop at zendframework/zend-code@da7ef15d562ee3b7c3388c6f2cd08fe1f6fb7c49
Thanks @djmattyg007, and sorry for the delay!


feat(user-profile): show picture upload error message

I gave up on making the welcome page also use this mechanism for the signin errors.
It's not worth the effort, that one can stay as is, it's more of a Route that shows the toast to be honest, except based on query params not patchname, and closing the toast is a history change. It's too far from how these toasts here work (imperatively push one, and let the ToastStack take over from them and manage dismissal).