V4 docs for collapse accordion reference missing V3 panel-* classes

In the docs page for Collapse (http://v4-alpha.getbootstrap.com/components/collapse/), the Accordion example references the old v3 panel classes.

Duplicate of #18375

@Starsam80 Thanks!


Scripting  Webmesh CLI

The Webmesh CLI syntax certainly seems designed in part for using scripts to Provision, Configure, Manage, etc Webmesh Nodes
I did some github & google searches to see if there was by chance anyone already creating or collecting such Webmesh Scripts
Found nothing, so I thought I'd ask here if such a repository/collection of Webmesh Scripts already exists somewhere?
thanks...

For a three month old project I'd be shocked if there is such an ecosystem developing already :stuck_out_tongue:
The CLI was always just for me to kind of smoke-test stuff. Then when the project evolved beyond container based use cases, it served as a good way to provide an easy to manage simple PKI for mTLS. It is definitely not a battle-tested tool by any means. I welcome any and all contributions in that area though :smile:


145 improve search after swe

It turns out that MySQL does not support fulltext searches unless the name of the fulltext index is the same as the name of the column (Found this out the hard way). Hence, I had to rewrite the migration.
Also turns out that knex's dropIndex() function adds some extra garbage at the end. So I had to make the rollback statements for the migration also use knex.raw.
The new search finally works now.
Let me know if it all looks alright. Thanks!

Also the unit test that failed isn't you, that should be fixed in #412

Hey, just to recheck this - you wanted me to write the scoredQuery function in the database-calls file in the search route instead?

you wanted me to write the scoredQuery function in the database-calls file in the search route instead?

Yes exactly!

Sorry about checking in those files - I ran git add -A in a hurry.

No worries, it happens to the best of us! But it's definitely a good habit to start using git status more and then you should have those files in .git/info/exclude or a global gitignore I guess :).
Also, your branch now has merge conflicts :'(, sorry, can't merge it yet

Coverage decreased (-0.04%) to 5.785% when pulling dcdaa07eda71e81b66e9ba89d3c365ba1e051f83 on 145-improve-search-after-swe into af82d5a86edca55ccab1def041d7852e97f3cd42 on master.

Also, the reason Coveralls is complaining is because we waived the integration test for the sql for now, we can live with that for now though we want it tested in the future for sure


Follow 18 f

WIP. still need to follow some other rules of 18F. Takes care of #5

hm... I think most of these routes actually return inspections, and not businesses etc. Maybe the main route is /inspections and there's just a bunch of query params to filter by business, zip, location, districts etc. Will need to check app behavior still. @leordev def WIP.

Going to close this PR. Will create a new one that updates api in various ways, including follow 18F, logging to a file, better error codes/msgs, and make some fields (zip, dates) optional.


Map not loading in southern hemisphere

Using default coords or manual ones. Only shows a white screen doesn't load the map at all

have you tried different location first?

Default co ords:

Result:

Set to yank coords:

Map loads:

"Set" button doesn't appear to do anything at that point
If I manually enter the southern hemisphere co ords I also get a blank map

Set button will "work" (hopefully) in near feature allow you to move your self in the map without the need of closing the application.
I see that you got something in map, whats wrong than?

Thanks for your help
The issue is that the map only loads when using a positive value for latitude
E.g. -42, 147 won't load. 42, 147 will load

indeed there is no "-" in lang / lat
good luck :+1:

I don't follow...
Half the world is in - latitude

Yes only if you live in South America , Africa etc etc you said you line in south hemp.
Hu lol read my post ment to say in your location

Can you get it working for negative latitudes?

Sure why not (probably?) haven't tried it yet and I'm on my phone so it's a good question to ask

Much appreciated

Yeah I'm also not able to get this working for Australian location.

@R467 @IMNoob1 Can you guys try version 0.0.6? There was a bug with negative latitudes that I'm guessing was causing this.

It's working now.


SCRUM-3953: load expression experiments afer annotations

Still need integration tests to be written/updated.  Even if there's no validation taking place for the experiment part of the load, we should be checking that we can retrieve the data and that the returned data is as expected.

Still need integration tests to be written/updated. Even if there's no validation taking place for the experiment part of the load, we should be checking that we can retrieve the data and that the returned data is as expected.

The endpoints we usually call in the integration tests don't trigger the full load. They call someExecutor.runLoadAPI with a list of entitines (GeneExpressionAnnotations for example). I have been testing the code running the UI.

Still need integration tests to be written/updated. Even if there's no validation taking place for the experiment part of the load, we should be checking that we can retrieve the data and that the returned data is as expected.

The endpoints we usually call in the integration tests don't trigger the full load. They call someExecutor.runLoadAPI with a list of entitines (GeneExpressionAnnotations for example). I have been testing the code running the UI.

Manual testing doesn't catch errors caused by future code change.  Is there a reason that we can't have a runLoadAPI method for expression annotations that triggers the expression load?  You just need to override the generic method.

Still need integration tests to be written/updated. Even if there's no validation taking place for the experiment part of the load, we should be checking that we can retrieve the data and that the returned data is as expected.

The endpoints we usually call in the integration tests don't trigger the full load. They call someExecutor.runLoadAPI with a list of entitines (GeneExpressionAnnotations for example). I have been testing the code running the UI.

Manual testing doesn't catch errors caused by future code change. Is there a reason that we can't have a runLoadAPI method for expression annotations that triggers the expression load? You just need to override the generic method.

Test added with the runLoadAPI override


Testing: switch

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

冲突啦

先合 Select 那个，那个我把冲突解了。现在各种排队冲突= =

Coverage increased (+0.5%) to 35.833% when pulling bf183410e75ddbfc6787ba1857f9c289d01178af on Leopoldthecoder:Testing-switch into c7103edd6516e0ece3b183c1e1dc2fad689cfbcd on ElemeFE:master.

resolved


render_placeholder tag raise exception

I created an simple app with Apphook.
However I got the following exception.

Django Version:	1.8.9
Exception Type:	AttributeError
Exception Value:	'tuple' object has no attribute 'has_change_permission'
Exception Location:	/cms/templatetags/cms_tags.py in _get_value, line 1142
Python Version:	3.4.2

/cms/templatetags/cms_tags.py in _get_value
1138        if isinstance(placeholder, string_types):
1139            placeholder = PlaceholderModel.objects.get(slot=placeholder)
1140        if not hasattr(request, 'placeholders'):
1141            request.placeholders = {}
1142                    perms = (placeholder.has_change_permission(request) or not placeholder.cache_placeholder)
1143        if not perms or placeholder.slot not in request.placeholders:
1144            request.placeholders[placeholder.slot] = (placeholder, perms)
1145        else:
1146            request.placeholders[placeholder.slot] = (
1147                placeholder, perms and request.placeholders[placeholder.slot][1]
1148            )

The "placeholder" variable has this tuple.
(<cms.models.fields.PlaceholderField>,)
I think the variable should be an instance of Placeholder model.
Could someone help me?
My simple app is like this.
models.py
class News(models.Model):
    description = PlaceholderField('news_description'),

admin.py
class NewsAdmin(PlaceholderAdminMixin, admin.ModelAdmin):
    pass

admin.site.register(News, NewsAdmin)

views.py
class NewsDetailView(DetailView):
    model = News

template.html
{% render_placeholder object.description %}

@hoerin Hi there, is that a typo on your News model?

@czpython OMG you are correct! I removed the typo and run again. it completly works!!
Thanks so much. I was suffering all day today :'-D


Temporary fix for CI

Which issue does this PR close?

Temporary fix for #13686
Rationale for this change
Tests panicked in arrow's pretty_format_batches_with_options, caused by the new release of lexical-write-integer.
This PR pins the version of lexical-write-integer and makes cargo choose the common version among DataFusion and arrow-rs to v1.0.2.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?
No. Only modify dev-dependencies.

I filed an upstream ticket (with reproducer): https://github.com/Alexhuszagh/rust-lexical/issues/191

Thanks again @jonahgao  for getting us unblocked


Incorrect directory listing in case of same folder names but different virtual paths

@Rocker2102

Fixed in commit 986ec1c


[FEATURE] Handle non "project.json" based projects

Hi @pmowrer ,
I have used your package for javascript projects and would like to use it for .NET Core projects.
By looking at your code, very few is specific to "project.json" files.
The only dependencies are for locating the file in order to filter the commits and for getting the project name.
I tried to put all those references in a separate file in order to have multiple implementations for different project types :
const pkgUp = require("pkg-up");
const readPkg = require("read-pkg");
const getPackagePath = async () => {
    return await pkgUp();
}
const getPackageName = async () => {
    return (await readPkg()).name;
}
module.exports = {
    getPackagePath,
    getPackageName
};

My problem is I cannot figure out how to retrieve a parameter which would indicate the project type (defaulting to npm for backward compatibility) in order to select the corresponding implementation.
Do you think it is possible and do you have an idea how ?

There doesn't seem to be a way to give a parameters through the extends option so I went an other way.
I added "top level" files so it should be possible to do this:

"extends": "semantic-release-monorepo"
"extends": "semantic-release-monorepo/npm"
"extends": "semantic-release-monorepo/dotnet"
Do you want to take a look (https://github.com/zedtk/semantic-release-monorepo/tree/feat/dotnet) or should I just create a pull request ?

Hi @GuyLescalier,
Thanks for the thoughtful issue/PR and sorry for the wait!
I'm not familiar with .NET workflows... would you mind providing some more context? Is this something that semantic-release supports? This repo is meant to augment semantic-release specifically for the purposes of applying it to a monorepo. I would expect anything to do with supporting .NET to be handled in a separate semantic-release plugin rather than baked into this lib. Is there something like that out there?

Hi,
As you say semantic-release tries to be agnostic of the technical stack. For example, you need to use @semantic-release/npm to handle npm projects and I developped a plugin @zedtk/semantic-release-nuget to handle dotnet/nuget projects.
The only difference between these stacks is the format of the file that defines the project (project.json or .csproj).
Yet in semantic-release-monorepo you need information from the project (path, name, version). And you provided an implementation assuming the project file would be a project.json.
So my proposition was to separate the code which is responsible to retrieve those informations. That way you can have multiple implementations for different types of projects.
Actualy the best way would be to externalize completely this part instead of having semantic-release-monorepo provide thos multiple impementations.
Until today I didn't think it could be possible. But I saw another feature request (https://github.com/pmowrer/semantic-release-monorepo/issues/110) mentionning global configuration. This would allow to set in the global configuration the name of the plugin responsible for retrieving project scoped information and dynamicaly require it.

Hi again 😄
I did some tests with global config and was able to inject functions.
My release.config.js file:
`const readPkg = require('read-pkg');
module.exports = {
  plugins: [
    '@semantic-release/commit-analyzer',
    '@semantic-release/release-notes-generator',
  ],
  getProjectName: async () => (await readPkg()).name,
  getProjectVersion: async () => (await readPkg()).version,
}`

So maybe that would be the best way to do it. You would have a default "npm based" implementation for the functions that read package metadata.
And everyone could use global config to override those for different kinds of project files.
What do you think ?

Any progress on this? I was looking into making a .NET monorepo :)

+1 -- I'm trying to implement this in largely a Dart-based monorepo. @GuyLescalier's PR seems to work well!


Unable to import SVCs if cases are empty

Issue Title
Unable to import SVCs if cases are empty
Description
If I want to import SVC from another system then I cant do it with an empty cases list in the current project. The example below does not work. This is a desirable feature.
filters:
  sys001:
    svc_ids:
      includes:
        - svc134
        - svc140
        - svc142
        - svc148
        - svc149
        - svc150
        - svc151
        - svc152
        - svc153

cases: []

I cannot recreate this. What version of reqstool are you using?

I tested this in 0.4.4 and looks like it's already fixed


Vue UI as a PWA

What problem does this feature solve?
This feature would allow users to access Vue UI without browser window.
What does the proposed API look like?
It would appear as shortcut on desktop.

That would require to install the PWA to localhost, wouldn't it?
...which in turn would provoke weird console errrors whenever you run any other app on localhost on the same port, I think... @Akryum  ?

Vue UI requires a local node.js process running, so this simply can't be done.


Only apply increment when isKeyFrame()

Hello,
sorry for being so spammy, but I was wondering why the increment is applied to the current pose even though it may not be a keyframe. This results in a lot of noise in my laser odometry calculation (only checked CSM so far). When I execute the posePlusIncrement() only when isKeyFrame() is true, then I get a lot cleaner results.
So I propose a change in the process order:
process :
       - if first reading
           - initialize
           - return
       - preProcessing
       - getIncrementPrior
       - processImpl
       - is_keyframe = isKeyFrame(delta_pose)
       - if is_keyframe is true
          - posePlusIncrement
          - isKeyFrame
       - if is_keyframe is NOT true
          - isNotKeyFrame
       - postProcessing

My implementation looks like this:
https://github.com/fabolhak/laser_odometry/commit/b13a459a76ba2091d882fae74c552386cee9ac58

Hi,
thanks for your interest in this project. Let me start by saying that unfortunately I didn't have time to fully finish / wrap it up therefor all plugins may not be fully functional. I'm mostly using the rf2o plugin for my use case. The same manner I should improve the documentation as soon as possible.
The rational behind this execution scheme is actually inspired from the csm node implementation. Let me summarize it here.

processImpl The scan matching is performed with the last scan selected as 'keyframe' and the last received scan. It thus estimates the displacement from the 'keyframe' pose (considered as identity) to the current one in the sensor frame. That is the increment_ variable.
posePlusIncrement First it transforms the estimated displacement increment_ from the sensor frame to the base frame (increment_in_base_). It then compose the 'keyframe' pose with the new increment to obtain the current pose in the fixed frame (origin of the tracking)
( -> fixed_to_base_ = fixed_to_base_kf_ * increment_in_base_ )
The pose is then expressed in the optional 'global frame' fixed_origin_to_base_ = fixed_origin_ * fixed_to_base_ (by default fixed_origin_ = I).
updateKf Finally, in case increment_in_base_ is considered for creating a 'keyframe', the 'keyframe' pose is updated fixed_to_base_kf_ = fixed_to_base_.

Notice that the odometry message is constantly updated & published. Maybe should it be published only on new 'keyframe'. The noise you are observing may comes from this ?
Please have a look at https://github.com/artivis/laser_odometry/commit/f133a3a85212b99a7348e08e33be7ee7bad39316.
While I cannot guarantee 100% that the implementation is error-proof, I have been using it successfully for a while now.
As for your modification fabolhak/laser_odometry@b13a459, just a remark. The variable increment_ is in the sensor frame, making it sometime difficult to get your head around what should the 'keyframe' thresholds be. One the other hand, shall the laser frame be very different from the base frame, one should probably consider increment_ rather than increment_in_base_.
I will 'play' with 'csm' as soon as possible see if I experience the same issue. In the mean time feel free to provide more feedback / PR :+1: .

This particular issue was addressed in #31 . Closing.
@fabolhak Please feel free to re-open it if needed.


Incompatibility with Brutal company minus

Hello, i just installed BCM and found out that the scrap settings i set in LQ don't work with it, dunno if its due to LQ or BCM... just letting you know :)
Edit: BCM seem to also have a problem with Advanced Company scrap so it seem it comes from BCM i guess.

Thanks. When you say does not work, do you mean that there is an error in the console, or that BCM overrides whatever values you set in LQ? If BCM overrides LQ values, then there is nothing I can do about that.

I think BCM overrides LQ's values yes, haven't seen any error in the log :/

This has been fixed !


Documentation and Public API Controls updated

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Updated the Quick Start documentation - aligned images
Moved all of the controls from the public API to the modern style

Why should this Pull Request be merged?

Feedback implementation

What testing has been done?

Local testing has been done on the dev machine

The change looks good. While you're at it, please rename these polymorphic instances to match the labels and the LV style guide: "All" (capital A) and "By Label"

Applied


Need help: information too long

In some scenarios, the video info is too long (e.g. there are many streams or its title is too long)
A reasonable and practical solution needs to be given.

Fixed in dev pull request #5


Failed connection on mlab mongodb

2017-10-26T12:26:21.556+0100 W NETWORK  [thread1] Failed to connect to <IP_ADDRESS>:29415 after 5000ms milliseconds, giving up.
2017-10-26T12:26:21.559+0100 E QUERY    [thread1] Error: couldn't connect to server ds229415.mlab.com:29415, connection attempt failed :
connect@src/mongo/shell/mongo.js:237:13
@(connect):1:6
exception: connect failed
what could be wrong?

@princenazi There isn't much info here, but it looks like you do not have access to that mongo server from the machine where you are running dropwizard.  Can you manually connect using the mongo client?

I figured the problem was from Cyber roam, for some reason it wouldn’t let me connect to certain services from my cli. Cant really tell how it was configured, Buh Mongodb connects well on my production server. Thanks @ctrimble


Intermittent text errors with fill_in

Currently seeing errant behavior with fill_in where the static text being passed to fill_in is dropping characters.
An Example
session
  |> visit("/")
  |> find("#myFormId")
  |> fill_in("formFieldA", with: "SomeInputTextThatIWant")
  |> fill_In("formFieldB", with: "TheTextForFieldB")
  |> click_on("formSubmit")

result = session
  |> find(".state-change")
  |> text

assert result == "I expect to see this"

In the rudimentary example above, I'm seeing the second find for the state change fail (the form was not submitted), and when I look at the screenshot, I'm seeing (intermittent and random) characters missing from the two form fields I'm writing to with fill_in.
Is anyone else seeing any such issues?
EDIT 12/15/2016
The issue is as a result of the form failing to submit due to validation constraints.  The find(".state-change") is actually appropriately failing because the state change never occurs due to the original fill_in()/2 helper failing to put in my specific text from a string literal.  So, the attempt at finding the state change is irrelevant.

@jpettit Can you re-create a demo of the failure? I'll be happy to take a look at it. Some other thoughts. Is this just a basic form? Are there any Javascript interactions with the form? Are you sending special characters of any kind?

@keathley No special characters.  Characters are just dropped (and it seems random).  The input form is defined with action=javascript::void(0);.  The input fields have the following attributes: autocomplete id name class autofocus type style
I am using v0.15.0 - despite the docs stating v0.14.0.  Let me try v14.

I did some more experimentation and I'm finding that I'm only seeing the fill_in/2 helper from the example above really only input the correct text maybe 1 out of 10 times.
I added the following to replace the second session statements:
assert find(session, "#formFieldA")     |> has_value?("SomeInputTextThatIWant")

Another update - I've installed and configured Hound with phantomjs and the same issue occurs using their library.  So this is probably an issue with phantomjs, and a troubling one considering Wallaby does not support selenium or chromedriver

Based on what you're describing it sounds like it might be an issue with the site you're trying to test. Not being able to fill in form fields is probably something that would get reported pretty quickly after all 😄.
I want to help solve this issue but currently I don't have a lot to go on. Even a gist of the html and relevant js would be helpful. Can you double check the version of phantom you're running? Can you give me a specific example of text you're trying to submit? The more information the better.

Since I'm not really sure how to reproduce this I'm going to close this issue for now. If you have some more info then feel free to re-open it.


Suggest widget rendering broken (IE9)

from @isidorn

IE9, https://microsoft.github.io/monaco-editor/index.html
Trigger suggest widget, scroll down, scroll back up -> notice how the rendering is broken, none of the suggestions get rendered

Closing since we're no longer supporting IE9


Roadmap: Nice to have plugins

New plugins

mhinz/vim-startify
Shougo/vimshell.vim
pelodelfuego/vim-swoop
projectile-switch-project equivalent ? (some ideas: xolox/vim-session, Stackoverflow)

Alternatives support

vim-scripts/tComment
scrooloose/nerdcommenter find a way to avoid default mapping
Shougo/vimfiler.vim

https://github.com/pelodelfuego/vim-swoop is nice, too

@CodeFalling vim-swoop added to the roadmap. Thanks

https://github.com/kana/vim-arpeggio
call arpeggio#map('i', '', 0, 'fd', '<Esc>')
let g:arpeggio_timeoutlen = 100

to replicate evil-escape-key-sequence


Backwards compatibility with Zabbix 2.2 possibly broken

Per blog commenter Edur:
Hi, nice work!
I checked out the last revision on github. But the meters does not work, the font only works after I add “” to the header and the RAM values are wrong calculated i think (ex. shows -4G / 16G). I have an zabbix server v2.2. Have you an working copy like your Screenshot? :)
Thanks a lot.

I think it depends on the vm.memory.size[*] items you have set up for your hosts. There are many possible, we are only using a few for our math. I wonder if we need to make this more generic so that it works on all OS, but we will always need to advise the user what items we require.

Could be that he doesn't have the proper values configured per our readme, I'll check back with him on the blog.

:warning: I can reproduce this issue on Zabbix 2.2.9 using this items to get the mem info:

vm.memory.size[available]
vm.memory.size[total]

@vicendominguez does it work if you configure memory items per our readme?

I think it will work, but I cannot check it now...
Perhaps this topic a little FUD but, why to check free memory and not available?? It would be interesting to know for my understanding.....
The original Zabbix Linux template is checking available key (it has a trigger too), at least in Zbx 2.2.x.

I believe the reason we do things this way is because Windows and Linux servers report memory usage in different values. Zabbix 2.5 also made a breaking change to the way memory is reported if I recall correctly.
Check out #6 for more details on this particular issue.

@vicendominguez RedHat and CentOS 6 do not have "available" memory, among others. So Zabbix has no way of reporting it. This is depends on the kernel version.
Defining what is available vs "free" memory is a somewhat subjective thing, and hard to make the same in different OSs. I consider Free memory the sum of 'free' and 'cached' values on a pre-3.14 Linux kernel, because applications can reclaim cached memory immediately. The kernel devs have a different (but possibly) more accurate approach.

Thx for the answers guys and for your work.
I have about 40 Centos 6.x without issues with the  available  memory. It is easy to change that key in the index.html.... i prefer to choose the  available  value.
:+1:

Sounds like this issue is resolved as it appears to be down to end user preference. Closing this ticket out.


Header file name "winsock.h" conflicts with the system header file "winsock.h" on windows

Version: libuv1.x (current HEAD)
Platform: Windows

We have a header file named with winsock.h under the src/win directory. However, on Windows, there's also a header file from system runtime named with winsock.h.
Generally specking, this shouldn't be a problem, since the winsock.h is placed inside the src/win folder and is treated as a internal header file. However, under certain circumstances, when we want to hack with libuv, we expose the internal include directories to external c files, then the c compiler will get confused and include the wrong header files.
This issue is a request to rename our winsock.h (may as well as winsock.c) to avoid the conflict and the confusion with system's header file on Windows. Since our winsock.h is only used internally, the renaming shouldn't cause any uncomfortable backwards compatibility issue.

I don't think changing names will help with anything. If you expose internal headers sooner or later you will get some kind of name clash. You can always use relative paths in your C files - like #include "deps/libuv/src/win/winsock.h" or something similar.
That said, I think that having more descriptive name like winsock_wrap.h or something similar would make it slightly more readable. I would be +0 on such change.
I will close this issue. If you have time, feel free to open a PR with this change.

I'm -1 personally.  It means we need to invest time and accept churn for no value to libuv.


Properly handle reload of finding files to avoid an empty list of findings in the UI

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/270
Closes https://github.com/getappmap/appmap-intellij-plugin/issues/182
The reload of finding files uses a cancellable ReadAction, which means that it could be executed multiple times.
The code, which was executed multiple times, had side effects, which could break the UI.
This PR removes the side effects and consistently applies the results collected by the ReadAction to the UI.
Most likely, this is also a fix for https://github.com/getappmap/appmap-intellij-plugin/issues/270, which may be caused by a disposed project.

:tada: This PR is included in version 0.35.3 :tada:
The release is available on:

v0.35.3
GitHub release

Your semantic-release bot :package::rocket:


Allow mapped type to declare functions

Suggestion
🔍 Search Terms

mapped types
instance member function
instance member property
instance method
subclass constructor
overriding

✅ Viability Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
📃 Motivating Example

In our universe, there are two kinds of animals, dogs and cats.
type Animal = 'dog' | 'cat';

Some people can handle dogs. Some people can handle cats. Some people can even handle both. But if you can't handle dogs or cats, you're just not a handler. We can express this generically in TypeScript.
type Handler<A extends Animal> = {[animal in A as `handle${Capitalize<animal>}`]: (animal: animal) => void};

Let's say you have a dog handler that doesn't do anything interesting.
class BoringDogHandler implements Handler<'dog'> {
	handleDog(dog : `dog`) {}
}

You could also have someone who can handle both and keeps a record of how many animals handled.
class CountingUniversalAnimalHandler implements Handler<Animal> {
	count = 0;

	handleDog() {this.count++;}
	handleCat() {this.count++;}
}

Some dog handlers are well known for broadcasting to the world whenever they are handling a dog. Since this is such a common thing, we'd like to create a mixin for it.
function NoisyDogHandler<H extends {new (...args: any[]): Handler<'dog'>}>(base: H) {
	return class extends base {
		handleDog(dog : `dog`) {
			console.log("Handling dog");
			return super.handleDog(dog);
		}
	};
}

Looks innocuous enough. But this doesn't work! Typescript informs us that

Class Handler<"dog"> defines instance member property handleDog, but extended class (Anonymous class) defines it as instance member function. (2425)

If we were allowed to declare that the handle${Capitalize<A>} members were not mere properties, but actually methods, TypeScript would not fear letting us override them. The natural syntax would look like this, which is currently not allowed:
type Handler<A extends Animal> = {[animal in A as `handle${Capitalize<animal>}`](animal: animal): void};

A subtle distinction for a subtle distinction.
Playground Example
💻 Use Cases
What do you want to use this for?
Mix-ins are powerful, and when they work they're fantastic, but they're currently somewhat brittle to work with.
This is one of the pieces of the puzzle needed for classes extending constructors of mapped types to override methods (#27689). The other piece needed is to be able to keep the member function status of methods obtained from type indexing (#38496, c.f. #35416, and #46802).
What shortcomings exist with current approaches?
For small enough use cases, you can do the mapping "by hand":
type Animal = 'dog' | 'cat';

type DogHandler = {handleDog(dog: 'dog'): void};
type CatHandler = {handleCat(cat: 'cat'): void};
type BothHandler = DogHandler & CatHandler;

type Handler = DogHandler | CatHandler;
type HandlerFor<A extends Animal> = ('dog' extends A ? DogHandler : {}) & ('cat' extends A ? CatHandler : {})

Obviously this doesn't scale well if you create multiple methods with Animal instead of just one, or Animal has many more cases. Less obviously, there isn't a really satisfactory way to implement a generic method that takes an animal and handler, calls the right handle method, ensures at compile time that the handler can handle the animal, and doesn't involve casting. See this playground for several attempts.

Based on the use case I'm inclined to just discard the ... defines instance member property ..., but extended class ... defines it as instance member function. error when the base class property is created through a mapped type. Thoughts?

Keep in mind that, assuming this proposed syntax does create methods, TS would likely treat them bivariantly, meaning you could potentially unsoundly assign a CatHandler to a DogAndCatHandler.
See https://github.com/microsoft/TypeScript/wiki/FAQ#why-are-function-parameters-bivariant and note that strictFunctionTypes enables contravariant parameters for function types, but not methods.

Based on the use case I'm inclined to just discard the ... defines instance member property ..., but extended class ... defines it as instance member function. error when the base class property is created through a mapped type. Thoughts?

That sounds reasonable to me.

Oh, but if you do discard the error message, make sure it discards it for subclasses as well.

Dealing with this as well. Removing the error for this situation is idea. I'd go as far to say that anytime an instance member property can be either a single method signature (or undefined) then it should be overridable as if it was a method.

Yes would be good if this wasnt an error.
I'm creating some utils to infer class types from some legacy code I'm working with, which uses mapped types and this error means a lot of ts-ignores need to be used when overriding methods from these inferred classes in TS

I have the same problem as well 👍

Here is my case
export type AbstractModuleService<
  TContainer,
  TMainModelDTO,
  TOtherModelNamesAndAssociatedDTO extends OtherModelsConfigTemplate
> = AbstractModuleServiceBase<TContainer, TMainModelDTO> & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `retrieve${ExtractSingularName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: (
    id: string,
    config?: FindConfig<any>,
    sharedContext?: Context
  ) => Promise<TOtherModelNamesAndAssociatedDTO[K & string]["dto"]>
} & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `list${ExtractPluralName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: (
    filters?: any,
    config?: FindConfig<any>,
    sharedContext?: Context
  ) => Promise<TOtherModelNamesAndAssociatedDTO[K & string]["dto"][]>
} & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `listAndCount${ExtractPluralName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: {
    (filters?: any, config?: FindConfig<any>, sharedContext?: Context): Promise<
      [TOtherModelNamesAndAssociatedDTO[K & string]["dto"][], number]
    >
  }
} & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `delete${ExtractPluralName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: {
    (
      primaryKeyValues: string[] | object[],
      sharedContext?: Context
    ): Promise<void>
  }
} & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `softDelete${ExtractPluralName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: {
    <TReturnableLinkableKeys extends string>(
      primaryKeyValues: string[] | object[],
      config?: SoftDeleteReturn<TReturnableLinkableKeys>,
      sharedContext?: Context
    ): Promise<Record<string, string[]> | void>
  }
} & {
  [K in keyof TOtherModelNamesAndAssociatedDTO as `restore${ExtractPluralName<
    TOtherModelNamesAndAssociatedDTO,
    K
  > &
    string}`]: {
    <TReturnableLinkableKeys extends string>(
      productIds: string[] | object[],
      config?: RestoreReturn<TReturnableLinkableKeys>,
      sharedContext?: Context
    ): Promise<Record<string, string[]> | void>
  }
}

Where I expect the mapped type to be function of the class and not properties, the objective is to allow classic override of the function. But being properties (since there is a limitation), the only way I found around it is to override it like the following
  @InjectManager("baseRepository_")
  async listVariants_(
    filters: ProductTypes.FilterableProductVariantProps = {},
    config: FindConfig<ProductTypes.ProductVariantDTO> = {},
    @MedusaContext() sharedContext: Context = {}
  ): Promise<ProductTypes.ProductVariantDTO[]> {
    const variants = await this.productVariantService_.list(
      filters,
      config,
      sharedContext
    )

    return JSON.parse(JSON.stringify(variants))
  }

  get listVariants() {
    return this.listVariants_
  }

any news in terms of advancement on that topic?

Same issue, would be nice to just remove that error.


[OSCI] Add new author Israel Geoffrey

Description
[Describe what this change achieves]
Add Israel Geoffrey as an author
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Short and simple description 👍🏾


Compare resource on their UUID and FQName

Fix code to compare resources between their UUID and FQName instead
of all their properties as some of them can vary between two reads
(as the last update time stamp).

Coverage increased (+0.2%) to 77.574% when pulling ea98bce005d79723ae1997f3c04023fe68df19a7 on Doude:resource-compare into ffa9e7b9576f402e63014f5d7d70fd13b2ff65a4 on eonpatapon:master.

Coverage increased (+0.2%) to 77.574% when pulling ea98bce005d79723ae1997f3c04023fe68df19a7 on Doude:resource-compare into ffa9e7b9576f402e63014f5d7d70fd13b2ff65a4 on eonpatapon:master.


Fix ajv query message errors

:tada: This PR is included in version 7.67.5 :tada:
The release is available on:

v7.67.5
GitHub release

Your semantic-release bot :package::rocket:


When retrieving a list of answer sets, don't limit steps to > 1

After #593, we're no longer correctly loading the list of answer sets because the default is to filter to interview where steps > 1. Answer sets don't have any steps.
We just need to change the way we invoke get_saved_interview_list so that exclude_newly_started_sessions is False, but we might also consider changing the default to False and just using that filter on the interview_list.yml page instead of everywhere.

"steps" are just rows in the database--Docassemble saves a new row in the database each time the user clicks "back" or "continue". It makes sense that when you copy a session's variables into a new session it collapses the context of the "back" and "continue" button as you're not guaranteed to have any questions that match. It would just invisibly erase the user's answers.


Horizontal white lines appear when tapping a cell in subreddit search

Also appears vertically in the ReplyVC

Fixed both!


Unable to install module (missing package.json)

I tried to install your module but it wans't working. Then I double checked errors and realized that module was not installed because there is no package.json.

Yep, thanks for the hint!
Just updated it.
Please do a
git pull && npm install

Afterwards everything should work as expected again

Thank you!


docs: add backend internal docs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#402
#401
#400  👈
#399
#398
#397
#396
#395
#394
#393
#392
#391
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Modified BuildDevSave to use mono tools

Changed the framework target for Mono
Added readme instructions for building with Mono tools
Removed vestigial lua file

This is ready to merge, right?

Yeah, it's fine. Probably inconsequential, but fine.


x/net/http2: setting Request.Close doesn't close TCP connections

What version of Go are you using (go version)?

$ go version
go version go1.16.10 linux/amd64

Does this issue reproduce with the latest release?
go1.16.10, which is the latest release of go1.16, is affected.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOHOSTARCH="amd64"
GOHOSTOS="linux"

What did you do?

go run the source code below:
package main

import (
        "context"
        "fmt"
        "io"
        "net"
        "net/http"
)

func main() {
        tr := http.DefaultTransport.(*http.Transport).Clone()

        dialContext := tr.DialContext

        tr.DialContext = func(ctx context.Context, network, addr string) (net.Conn, error) {
                conn, err := dialContext(ctx, network, addr)
                if err != nil {
                        return conn, err
                }

                fmt.Printf("%v -> %v\n", addr, conn.RemoteAddr())

                return conn, nil
        }

        c := http.Client{
                Transport: tr,
        }

        for i := 0; i < 2; i++ {
                req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, "https://example.com", nil)
                if err != nil {
                        panic(err)
                }

                req.Close = true

                resp, err := c.Do(req)
                if err != nil {
                        panic(err)
                }
                defer resp.Body.Close()

                io.ReadAll(resp.Body)

                fmt.Println("body read")
        }
}

With go1.16.9, it outputs:
example.com:443 -> <IP_ADDRESS>:443
body read
example.com:443 -> <IP_ADDRESS>:443
body read

IP address lookup is done per request and connection is not reused.  Note that connection is HTTP/2.
With go1.16.10, it outputs:
example.com:443 -> <IP_ADDRESS>:443
body read
body read

Notice that IP address lookup is done once and the connection is reused for the second request.
This contradicts the documentation of Request.Close:
	// Close indicates whether to close the connection after
	// replying to this request (for servers) or after sending this
	// request and reading its response (for clients).
	//
	// For server requests, the HTTP server handles this automatically
	// and this field is not needed by Handlers.
	//
	// For client requests, setting this field prevents re-use of
	// TCP connections between requests to the same hosts, as if
	// Transport.DisableKeepAlives were set.
	Close bool

If Transport.DisableKeepAlives is set to true, go1.16.10 does not reuse connection.
So go1.16.10 has a different behaviour between Transport.DisableKeepAlives and Request.Close.
What did you expect to see?
go1.16.10 should not reuse connection if Request.Close is set to true.
What did you see instead?
go1.16.10 reuses connection even if Request.Close is set to true.

cc @neild @tombergan

Missed because our HTTP/2 tests for connection reuse call ("http2".Transport).RoundTrip directly, and don't exercise the more common path where net/http manages creating new connections.
Sorry about that.

I think there's a preexisting bug in here as well.
Request.Close states that setting it prevents re-use of TCP connections. However, for HTTP/2 connections (even prior to the introduction of this bug), a request with Close set can be sent on a connection with in-flight requests on it.

@gopherbot Please open backport issues for 1.16 and 1.17


Stage reported as SUCCESS even though it failed

########## STARTING STAGE: SYNC ORIGIN PULL REQUEST 15034 ##########
+ [[ -s /var/lib/jenkins/jobs/kargakis_test/workspace/activate ]]
+ source /var/lib/jenkins/jobs/kargakis_test/workspace/activate
++ export VIRTUAL_ENV=/var/lib/jenkins/origin-ci-tool/ffb84452f35d4a28991a0f4e31f3686509895285
++ VIRTUAL_ENV=/var/lib/jenkins/origin-ci-tool/ffb84452f35d4a28991a0f4e31f3686509895285
++ export PATH=/var/lib/jenkins/origin-ci-tool/ffb84452f35d4a28991a0f4e31f3686509895285/bin:/sbin:/usr/sbin:/bin:/usr/bin
++ PATH=/var/lib/jenkins/origin-ci-tool/ffb84452f35d4a28991a0f4e31f3686509895285/bin:/sbin:/usr/sbin:/bin:/usr/bin
++ unset PYTHON_HOME
++ export OCT_CONFIG_HOME=/var/lib/jenkins/jobs/kargakis_test/workspace/.config
++ OCT_CONFIG_HOME=/var/lib/jenkins/jobs/kargakis_test/workspace/.config
/tmp/hudson2337358816745890171.sh: line 3: PULL_REFS: unbound variable
++ set +o xtrace
########## FINISHED STAGE: SUCCESS: SYNC ORIGIN PULL REQUEST 15034 [00h 00m 00s] ##########
Build step 'Execute shell' marked build as failure

@stevekuznetsov we have discussed this one before.

Hmmm -- last we talked we were not using the temp script approach. The errors before where the shell failed but the stage didn't should now be fixed. I'll dig.

Wait, this is in a shell block on the Jenkins master, not on the remote host. Even weirder.

/shrug
/close


Flash: Route error information back to the origin

This is a basic and naive implementation of the error routing.
It should be secured in multiple ways in the future.

I guess we'll use onion-based error routing later, right?

I rebased your branch after merging your other PR. I'll merge this one soon.


Send more emails

PyPI sends a fairly low volume of event-based emails to users, which results in the occasional spam report causing an abnormally high overall % of complaints.
Some ideas of things we could send emails for, to increase our overall email send, that would be a net positive user benefit and not just considered noise:

[ ] New releases (sent to all maintainers)
[ ] New files added to old releases (sent to all maintainers)
[ ] Login from new IP addresses (sent to primary email)
[ ] New email added (sent to any other emails on the account)
[ ] New primary email (sent to the old primary email)

Other ideas:

Emails whenever a release gets yanked or unyanked
All of the new release/file/yanked/etc emails should be able to be subscribed to by any user for that project.

I added and deleted a few API tokens today and was surprised to not get any emails about it.

@aganders3, what's your PyPI username?

I am also @aganders3 there.

@aganders3 Sorry, thought we already had that one! Great point, I've added it to the list.

Another email idea: we should periodically notify project owners about stale/unused API tokens, e.g. if a project has had releases in the past N months that don't use a particular token.
As a conditional sequence:

If the project has API tokens;
and those API tokens haven't been used in the last N months;
and a release been has done in the last N months (e.g. with a different API token or trusted publishing);
then send an email notifying the owner of the API token + project owners that they have one or more stale tokens still registered.

This will be particularly helpful/useful as more projects roll out trusted publishing, since they may forget to delete the old tokens that trusted publishing replaces.

https://github.com/pypi/warehouse/issues/11524 would be related to that as well.

#997 would help increase volume

Triaging: we're doing a couple of these as part of STF-funded work.
I've asked @xBalbinus to start with emails for yanking and unyanking of releases.

Emails whenever a release gets yanked or unyanked

Looks like this one was already done ~3 years ago: https://github.com/pypi/warehouse/blame/7c6c4cf16d9f46660f687123a44766fb775dcea7/warehouse/email/init.py#L901-L935
I've asked @xBalbinus to work on the "New email added" one for the time being.

New email added (sent to any other emails on the account)

Done in #13866, thanks @xBalbinus!

New primary email (sent to the old primary email)

This might be a good next one if you're looking for something else to work on!

Sounds great! Thank you so much!
On Thu, Jun 8, 2023 at 10:49 AM Dustin Ingram @.***>
wrote:

New email added (sent to any other emails on the account)
Done in #13866 https://github.com/pypi/warehouse/pull/13866, thanks
@xBalbinus https://github.com/xBalbinus!
New primary email (sent to the old primary email)
This might be a good next one if you're looking for something else to work
on!
—
Reply to this email directly, view it on GitHub
https://github.com/pypi/warehouse/issues/13234#issuecomment-1582731155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASH4FPS3QZQXPKMA2KUAY53XKHQ5ZANCNFSM6AAAAAAV7B6C6U
.
You are receiving this because you were mentioned.Message ID:
@.***>

FTR, NPM sends emails for all new releases and this is very useful to get liveness feedback on CD.

For the record, about "New releases (sent to all maintainers)", here is the NPM email

A new version of the package crawler-user-agents (1.0.152) was published at 2024-10-19T06:39:58.891Z from GitHub Actions: https://github.com/monperrus/crawler-user-agents/actions/runs/11415392939/attempts/1 (triggered via a "workflow_run" event on git ref "refs/heads/master").
The shasum of this package is 3279ecc6499581f409f6aa4643d25847a6f5b5c0.

If you have questions or security concerns, you can contact us at https://www.npmjs.com/support.

Thanks,

The npm team

It contains lots of interesting information.

Hmm, how does NPM get that context? I don't think they support Trusted Publishing yet, although perhaps they get it directly from their --provenance feature?
Regardless, agreed on that being useful/interesting information to include :slightly_smiling_face:

Yes this is from --provenance


Create BinanceStaking.json

i see you staked all 100 INJ.
As explained in Step-3,
100 INJ = inj_amount_to_stake + extra_inj_balance
Your extra_inj_balance = 0. You won't be having any balance to pay for transactions.
Can you create new genTx and submit new PR?


[Feature Request] Adding maintainable lists and a "List" field type to assign them to templates

As I mentioned in another issue I try to build a digital inventory for tracking my woodworking assets: tools, materials, consumables, workpieces, etc.
One helpful feature I'm missing in this otherwise very appealing software is this: a field of a type "List", that I can assign to a template, and which then gets assigned an actual list that has a bunch of entries. Basically, this is about adding user-defined (one-dimensional) arrays, that can be assigned to templates (or items directly), and is then providing the content of the respective array to the item that is created/edited.
Example
Let's say I have an item "Table saw", that already has the following attributes by default:

Name
Collection
Quantity
Visibility
Tags

Now I apply a template that also adds these fields:

Model (Text)
Manufacturer (List)
Supplier (List)
Receipt (File)
Manual (File)
Supplier Link (Link)
Purchase Date (Date)

The values for the two attributes "Manufacturer" and "Supplier" I would like to pick from lists, that are created similarly as templates. A link in the menu "Lists", and then lists of different manufacturers, of suppliers, or one that just has "Corded" and "Cordless" in it.
Whenever I add a "List" to an item it should ask which list and then provide the content as a pull-down for the value field in the form.
Does that make sense so far?
Thanks in advance!

Hello, this feature is now available since version 1.3.7


[BUG] Microsoft.MachineLearningServices @ 2024-04-01 - casing in user assigned identity in encryption for workspaces is not preserved

API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/262a9d16d94c3448fc7f37c840757f6e74acf7de/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2024-04-01/machineLearningServices.json#L5135
API Spec version
2024-04-01
Describe the bug
The API returns all ID segments for the user assigned identity ID for encryption in lower case:
PUT:
...
    "encryption": {
      "identity": {
        "userAssignedIdentity": "/subscriptions/***/resourceGroups/acctestRG-aiservices-240918114038029797/providers/Microsoft.ManagedIdentity/userAssignedIdentities/acctestuai-240918114038029797"
      },
...

GET:
"encryption": {
      "status": "Enabled",
      "identity": {
        "userAssignedIdentity": "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourcegroups/acctestrg-aiservices-240918114038029797/providers/microsoft.managedidentity/userassignedidentities/acctestuai-240918114038029797"
      },

Expected behavior
The API preserves the casing in the user specified segments.
Actual behavior
The API does not preserve the casing in the user specified segments.
The resource group name in the segment was sent with acctestRG-aiservices-240918114038029797 but returned acctestrg-aiservices-240918114038029797
Reproduction Steps
Provision an AI services hub with encryption using a user assigned identity with upper and lower casing in the ID segments.
Environment
No response

@ZhidaLiu Please help take a look, thanks.


test: avoid running controller and node drivers on same node

We haven't found a good solution for the networking issues on Clear
Linux (https://github.com/intel/pmem-csi/issues/555) that plague our
periodic builds.
As a workaround, ensuring that the controller runs on the master node
and thus never on the same node as a node driver avoids the
problematic case.

Before we merge, let's check that the full branch build also succeeds: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/job/clear-linux-network-workaround/

Superseded by PR #604.


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2024-11-20)
Features

(re)introduce can_sync_with (cf3b2c7)
add set to UniqueList (f49a8ab)
Rename sync player feature to set members (3ad6717)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.1
:sunflower:


Host static_content locally

In config/settings.py there are a number of "STATIC_CONTENT" settings.  They refer to an S3 buckets.
Add a new config setting such as STATIC_CONTENT_LOCAL=True/False , and similar settings, which allows local development from a local filesystem and do not require an S3 bucket.
Example settings:
STATIC_CONTENT_AWS_ACCESS_KEY_ID = env(
    "STATIC_CONTENT_AWS_ACCESS_KEY_ID", default="changeme"
)
STATIC_CONTENT_AWS_SECRET_ACCESS_KEY = env(
    "STATIC_CONTENT_AWS_SECRET_ACCESS_KEY", default="changeme"
)
STATIC_CONTENT_BUCKET_NAME = env("STATIC_CONTENT_BUCKET_NAME", default="changeme")

STATIC_CONTENT_REGION = env("STATIC_CONTENT_REGION", default="us-east-2")

STATIC_CONTENT_AWS_S3_ENDPOINT_URL = env(
    "STATIC_CONTENT_AWS_S3_ENDPOINT_URL", default="https://s3.us-east-2.amazonaws.com"
)

@sdarwin do you want to talk through what this entails?

@gavinwahl , are you on Slack?  We could chat there.  It's late in the week, maybe on Monday.
There are instructions to run website-v2 locally, here: https://github.com/boostorg/website-v2/blob/develop/docs/development_setup_notes.md
This Django website depends on S3, to display boost library documentation.
The website uses S3, to display the user guide and contributor guide.
During testing, how could that be set up locally instead?  In other words, retrieve S3 content from the local filesystem, instead of across the internet to S3?
Option 1:  Install and run a service on your own local machine, that serves files using an S3 api.  Point your docker-compose environment at that API.  Maybe this would be the best choice, if possible.
Option 2:  What was mentioned above.  Add a variable.  Such as STATIC_CONTENT_LOCAL=True
If that variable is TRUE, then have the django code access the S3 content locally somehow, on the same filesystem as the web server.
In either of those cases, a developer would no longer need access to S3, and that would solve the issue.

@gavinwahl , thinking about this issue more,  there might be a much easier solution.   If I create yet another set of AWS keys that have read-only access to the staging buckets.  A local developer could point their docker-compose environment at the live S3 buckets.  Dev tests that involve write-access are prevented.  But the files in question are generally being read, not written. They are documentation.  So it should be enough.

@sdarwin is there anything left to do on this?

It should be ok. I have created new aws keys for read-only access to STATIC content. if anyone needs a copy, DM me in Slack.


Lastest fix to recipe unregistering caused other plugin's custom recipes to not register in the recipe book

In my case it's the recipes from these 2 plugins that stopped showing up on book after I updated Teak's Tweaks
AngelChest
CustomCrafting
There are free versions of these plugins in case you might need some testing done
CustomCrafting's recipe still work if you put in the correct ingredients but AngelChest's fetching item recipe stopped working completely

It shouldn’t interact with other plugins at all, but I’ll have a look when I get a chance

Seems to happen after a vanilla reload command. Is fixed after a restart.

/reload is not recommended by spigot as it can have unintended issues. Therefor this will be marked as "wontfix" unless i can find a simple fix for this. Always restart instead of reload


RC2 - Preview tooling, build error.

Created a new .NET Core Library project targeting .net 451 (may be same for others, not sure)

Built the vanilla project - no issues.
Went into project.json, and changed it from this:

{
  "version": "1.0.0-*",

  "dependencies": {
    "NETStandard.Library": "1.5.0-rc2-24027"
  },

  "frameworks": {
    "netstandard1.5": {
      "imports": "dnxcore50"
    }
  }
}

To this:
{
  "version": "1.0.0-*",
  "frameworks": {
    "net451": {
      "frameworkAssemblies": {
        "System.DirectoryServices.AccountManagement": "<IP_ADDRESS>"
      }
    },
    "netstandard1.5": {
      "imports": "dnxcore50",
      "dependencies": {
        "NETStandard.Library": "1.5.0-rc2-24027"
      }
    }
  }
}

Now when I build:

Why is this?
And here seems to be the relevent section from the msbuild output log:

Target "CoreCompile" in file "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Common.Targets" from project "c:\users\darrell\documents\visual studio 2015\Projects\ClassLibrary11\src\ClassLibrary11\ClassLibrary11.xproj" (target "Compile" depends on it):
1>       Using "GetBuildOptions" task from assembly "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Tasks.dll".
1>       Task "GetBuildOptions"
1>       Done executing task "GetBuildOptions".
1>       Using "Dnx" task from assembly "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Tasks.dll".
1>       Task "Dnx"
1>         C:\Program Files\dotnet\dotnet.exe build "c:\users\darrell\documents\visual studio 2015\Projects\ClassLibrary11\src\ClassLibrary11" --configuration Debug --no-dependencies
1>     1>
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Common.Targets(241,5): error : Object reference not set to an instance of an object.
1>       Done executing task "Dnx" -- FAILED.
1>     1>

It seems this was all just related to #1548 - i.e need to do a "restore" after adding the new TFM to frameworks.


Building a Loader Using Animations in Tailwind CSS

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #2468

@hectorkambow, can you please run a plagiarism check on this article?

plagiarism check done

Great work - very nice tutorial - very easy to follow along @M0nicah
cc @kayere 👍
cc @LinusMuema
Please be sure to go through my final edits to better improve future articles/reviews.


Added support for dynamic registration of text document synchronization

This makes lapce more compliant to the LSP spec

Don't respond to requests until lapce have received initialized from the server.
Check if server have dynamically registered for text document synchronization of a document.

There are still some unresolved issues:

didChange should comes after didOpen.
didOpen cannot be sent again before sending didClose.

Adding checks for these are a bit tricky  but it should be possible with some wiring?

[x] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #2149 (d115d11) into master (5ee7ede) will increase coverage by 0.03%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##           master   #2149      +/-   ##
=========================================
+ Coverage    8.93%   8.96%   +0.03%
=========================================
  Files         136     136
  Lines       59280   59067     -213
=========================================
- Hits         5296    5295       -1
+ Misses      53984   53772     -212

Impacted Files
Coverage Δ

lapce-proxy/src/plugin/catalog.rs
0.00% <0.00%> (ø)

lapce-proxy/src/plugin/lsp.rs
0.00% <0.00%> (ø)

lapce-proxy/src/plugin/mod.rs
0.00% <0.00%> (ø)

lapce-proxy/src/plugin/psp.rs
0.00% <0.00%> (ø)

lapce-proxy/src/plugin/wasi.rs
12.01% <0.00%> (-0.55%)
:arrow_down:

lapce-proxy/src/terminal.rs
0.00% <ø> (ø)

lapce-data/src/keypress/keypress.rs
73.02% <0.00%> (-0.21%)
:arrow_down:

lapce-ui/src/app.rs
0.00% <0.00%> (ø)

lapce-ui/src/title.rs
0.00% <0.00%> (ø)

lapce-data/src/data.rs
0.00% <0.00%> (ø)

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


materialTheme in MainWindow

Original report (archived issue) by mingfei sun (Bitbucket: mingfeisun).

It seems that the material theme for the main window is “Light”, which may cause the visibility issues. See
https://github.com/ignitionrobotics/ign-gui/blob/2dd4f0bf9bbcd90399ecbecddfe5a8cf46aa9f73/src/MainWindow.cc#L428
The visibility problems when displaying ign gazebo in Ubuntu Bionic:

I temporally changed the code as follows: this->materialTheme = “Dark”; after recompiling, it works ok. But it’s not flexible. May I ask if there are any solutions to solve this problem?

I can't reproduce this issue. I'll close it for now. If someone can reproduce it again please speak up and we can reopen the issue.


Create Image Tools Interface

Describes an interface that the image-tools project could provide for image validation
Signed-off-by: Rob Dolin<EMAIL_ADDRESS>

On Mon, Mar 20, 2017 at 02:48:12PM -0700, Rob Dolin (MSFT) wrote:

Describes an interface that the image-tools project could provide
for image validation

Maybe this should be an image-tools issue/PR?  I expect a certifier to
be using image-tools directly, and don't see a need to specify its API
independent of the implementation.  For comparison, the runtime
command line API in opencontainers/runtime-tools#321 is aimed at the
runtime API, not at the runtime-tools API.
For your UI with number-of-cases, failed cases, verbose listing, one
approach would be to make image-tools's image validator a TAP
producer.  Then you could run it from a TAP harness to get a compact
or verbose report.  For an example of this in practice, see the
comments in opencontainers/runtime-tools#308.  Prove 1 is one such
harness and has options for:
-Q,  --QUIET           Only print summary results.
-f,  --failures        Show failed tests.
-o,  --comments        Show comments.
If we get granular TAP results like opencontainers/runtime-tools#308
(or in any OCI compliance testing), I think the TAP comments are a
great place to put the spec links you're looking for.
And you could probably get all of this pretty handling with a number
of test harnesses or suites that output structured results.  I'm
floating TAP because I know it already handles these cases, and runC
(via bats 2) and runtime-tools (opencontainers/runtime-tools#302)
are already using some TAP.  But if OCI maintainers prefer other
structured test-result formats, they would be fine too.

cc: @opencontainers/image-tools-maintainers maintainers and @opencontainers/image-spec-maintainers for RFC

@RobDolinMS is it possible for you to bring this up at the OCI Dev meeting and gather feedback from the OCI TDC?

@RobDolinMS also any thoughts about just merging this into the README instead of a separate doc? (just keeps it easier to track)

@caniszczyk Yes, I mentioned this PR on the OCI Dev ConCall a few hours ago.
I'm also tagging @opencontainers/image-spec-maintainers and @opencontainers/image-tools-maintainers to please take a look at this DRAFT (PR #26) requested interface from the @opencontainers/certification-maintainers: https://github.com/opencontainers/certification/pull/26/files

@opencontainers/image-tools-maintainers - Does this proposal roughly align to how the code runs?

On Mon, Apr 03, 2017 at 04:45:04PM -0700, Rob Dolin (MSFT) wrote:

Does this proposal roughly align to how the code runs?

Current invocation is documented here 1.

this tab has been open for a few days. I like the direction, just want to ensure it plumbs-up to expected behavior

for a deterministic badge of validation, I think those three things are
needed/suitable to triangulate precisely what was tested on which
artifacts, and a timestamp for freshness check.
On Wed, Apr 5, 2017 at 3:44 PM W. Trevor King<EMAIL_ADDRESS>wrote:

@wking commented on this pull request.
In image-tools-interface.md
https://github.com/opencontainers/certification/pull/26#discussion_r110010181
:

+The below document describes an interface for the OCI Image Tools project as desired by the OCI Certification Program working group (Cert WG.)
+
+Goals:
+* An engineer can verify a container image complies with the OCI Image Spec (https://github.com/opencontainers/image-spec/releases)
+
+Inputs:
+* (REQUIRED): Path or reference to a container image
+* (OPTIONAL): If the user would like verbose output
+
+Outputs:
+* Number of cases run
+* Number of cases passed
+* Number of cases failed
+* List of cases failed
+* Version of OCI Image Tools
and maybe git commit of the tool?
I like this, but note that in a similar context the OCI consensus (as
voiced by @duglin https://github.com/duglin here
http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2016/opencontainers.2016-07-20-21.03.log.html#l-75)
was that a consistent API for extracting the implementation version was not
required for interop.
And the timestamp the validation just ran.
Does this matter? Hopefully the version of the test suite/tools and the
digest(s) of the tested object would be sufficient without recourse to the
validation timestamp. Higher-level tooling can always add a timestamp if it
feels it would be useful.
Also, presumably this would need to output the digests of the objects
tested.
This is tricky for stuff outside of CAS. For example, if validation was
pointed at an image-layout via a HTTP URL, or at a directory, what digest
hash do you show for complaining about “I couldn't find index.json there”?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/certification/pull/26#discussion_r110010181,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6XvUoWB2S2WRVy5BiA9e0dQsBijJks5rs-8ygaJpZM4MjDtp
.

On Wed, Apr 05, 2017 at 12:48:00PM -0700, Vincent Batts wrote:

… and a timestamp for freshness check.

But what is the purpose of the freshness check?  I think the tooling
for deprecating old versions 1 (and their certification results)
should depend on the tested OCI version, not on the timestamp of the
testing.

Perhaps timestamp isn't a hard requirement, but rather a nice-to-have.
On Wed, Apr 5, 2017, 16:00 W. Trevor King<EMAIL_ADDRESS>wrote:

On Wed, Apr 05, 2017 at 12:48:00PM -0700, Vincent Batts wrote:

… and a timestamp for freshness check.

But what is the purpose of the freshness check? I think the tooling
for deprecating old versions 1 (and their certification results)
should depend on the tested OCI version, not on the timestamp of the
testing.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/certification/pull/26#issuecomment-291979740,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6T90CyU5Tsyxgnx3UXxg3eWWN2ACks5rs_LpgaJpZM4MjDtp
.

Any comments here @stephenrwalli


[Feature]: support ListenOptions in lazyCompilaton

What problem does this feature solve?
Webpack allows specifying ListenOptions
interface ListenOptions extends Abortable {
    port?: number | undefined;
    host?: string | undefined;
    backlog?: number | undefined;
    path?: string | undefined;
    exclusive?: boolean | undefined;
    readableAll?: boolean | undefined;
    writableAll?: boolean | undefined;
    /**
     * @default false
     */
    ipv6Only?: boolean | undefined;
}

What does the proposed API of configuration look like?
Same as webpack

This had been supported, the ListenOptions will be merged when the server starts, just like webpack. https://github.com/web-infra-dev/rspack/blob/main/packages/rspack/src/builtin-plugin/lazy-compilation/backend.ts#L90

I still think the types need to be updated
https://github.com/web-infra-dev/rspack/blob/a19ca91a4fda7198de826565cc5f900f155d8973/packages/rspack/src/config/zod.ts#L1290-L1297

More precisely, it doesn't support the backend property as in webpack: https://webpack.js.org/configuration/experiments/#experimentslazycompilation
For instance, the following doesn't type check:
    experiments: {
      lazyCompilation: { backend: { listen: { port: 7654 } } },
    },


Add/Remove Layers, Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

I get the same error as with this example: This is a map with dynamic addition and deletion of layers

I tried to mimic This is a map with dynamic addition and deletion of Overlays and Dynamic addition/removal of layers, which work, but was unable to find the difference.
Any ideas?

Hey @BergWerkGIS, I'm having the same problem but didn't get your solution. I have a custom controller with injected $scope, as always, in which I "append" the layers options. How could it be wrong?


Allow user to choose in which chain/token they want to pay.

As detailed here: https://x.com/LefterisJP/status/1813154377579839584 it's impossible for a user to figure out how they can pay.
It's impossible for a user to find out what tokens or chains they can pay in. Ligi pointed out here: https://x.com/mr_ligi/status/1813178235468808455 that the payment processing software shows you only what you have funds on. That is a well-intentioned though misguided approach.
I as a user want to pay with stables in whatever evm chain I have stables and has at the moment lowest fees. All my stables are in various protocol earning yield. Say Aave, compound, curve etc. The payment processor does not detect (and I don't expect it to) stables locked in protocols.
I suggest making it show all possible choices, but maybe just pointing out at the UI if at the moment of selection the user has sufficient funds for the selected payment.
At rotki we do something like that. We use a custom-made payment processing (rudimental) system we made. Looks like this:

Also since I want to pay in the next 2 days to get my devcon ticket, and don't want to put pressure on ticket solving is there a place to see all possible payment options for devcon? This way I can "cheat" my way out of the problem by choosing what I want and withdrawing from defi to pay.

Thanks for your submission! Rotki is terrific.
Totally makes sense. A user's "ways to pay" will now be shown all the time after this PR lands is released to production in about 20 minutes.https://github.com/3cities/3cities/pull/152

Thanks a lot for solving this so fast! I can confirm it works.

My pleasure! Thanks for the feedback and testing. Cheers
On Tue, Jul 16, 2024, 1:16 PM Lefteris Karapetsas @.***>
wrote:

Thanks a lot for solving this so fast! I can confirm it works.
—
Reply to this email directly, view it on GitHub
https://github.com/3cities/3cities/issues/151#issuecomment-2231431468,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACJCPHMBDF4ZHRRA6V6OCDZMVINHAVCNFSM6AAAAABK6NWD2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGQZTCNBWHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Broken string size inference

With the latest F* master, this:
let tls_client_label = FStar.Bytes.utf8_encode "client finished"

throws
(Error) Subtyping check failed; expected type (s:string{ String.length s < pow2 30 }); got type string
Related location (C-c C-' to visit, M-, to come back): /mnt/f/dev/sec/everest/verify/FStar/ulib/FStar.Bytes.fsti(274,13-274,35)

This used to work until recently. Also, there seem to be many vaguely related problems with inference of implicit arguments.

Bytes.utf8_encode s requires that String.length s < pow2 30 but String.length = String.strlen is abstract (it's assumed in FStar.String.fsti), so there is currently no way of proving the required bound.
I believe this has been broken since our switch to FStar.Bytes from Platform.Bytes, where the encoding function didn't enforce any bounds. A temporary solution would be to assume the lengths of any string literals until such time they could be computed.

Yep, that looks like the right analysis! I'll continue adding lots of assumes :)

Currently F* can't infer lengths of string literals at all - this has nothing to do with proving that String.length = String.strlen. The solutions here are to either define strings in terms of some other type already in F* (eg. arrays of chars, or lists of chars), or to keep strings as a primitive and use SMT to reason about them. I have a WIP PR regarding the latter option.

@A-Manning The temporary solution that @nikswamy suggested and we ended up implementing is something midway.
We define
let strlen s = List.length (list_of_string s)

(**
 When applied to a literal s of less than n characters, this predicate
 reduces to True before going to the SMT solver.
 Otherwise, the left disjunct reduces partially but the right disjunct
 remains as is, allowing to keep `strlen s <= n` in the context.
*)
unfold let maxlen s n = b2t (normalize_term (strlen s <= n)) \/ strlen s <= n

And use maxlen to state a length bound that we might need to prove on string literals.
This relies on list_of_string being a primitive in the normalizer.


Remote CPU members

@sgibb and @jotsetung - I have updated the CPU page and added you as remote members - see https://lgatto.github.io/cpu-who/. Are you fine with this, and could you check the short paragraphs and amend as you see fit. @jotsetung, any link for add for you?

fine for me. regarding the link: for now you could use: http://www.eurac.edu/en/research/health/biomed/staff/Pages/staffdetails.aspx?persId=34084

regarding the link: for now you could use: http://www.eurac.edu/en/research/health/biomed/staff/Pages/staffdetails.aspx?persId=34084

Done, thanks

fine, thanks


Adds BrooklynViewerLauncher (for tests)

As per the javadoc:
/**
 * A convenience for started the Brooklyn REST api and web-app in a test, so that one can visually
 * inspect the app that the test creates. This is intended as a read-only view (but it has the real
 * management context so one can perform actions through this UI).
 *
 * It expects to be configured with an existing {@link org.apache.brooklyn.api.mgmt.ManagementContext}.
 *
 * Various other configuration options (e.g. {@link #application(String)) will be ignored.
 *
 * An example of where this is very useful is when testing a blueprint where an effector hangs -
 * one can visually inspect the app, drilling into the activities view to see what it is doing
 * and why it is blocked.

Note that AbstractBlueprintTest used to do this with BrooklynLauncher, but that is broken - that launcher also tries to set the managementPlaneId on the management context, but it's already set so it throws an exception.
My motivation for fixing + adding this is mostly for use in downstream projects. I want to run unit/integration tests that deploy + test some complicated blueprints. It's very useful to have this visualisation in such tests (particularly if it fails, and one places a breakpoint to see what activities have executed by that point).

Looks a lot like BrooklynJavascriptGuiLauncher, but otherwise LGTM.

@neykov good point about BrooklynJavascriptGuiLauncher (and the BrooklynRestApiLauncher that it delegates to). I'd forgotten about those.
The existing BrooklynJavascriptGuiLauncher is only used in a couple of simple tests (in BrooklynJavascriptGuiLauncherTest). It is not configurable to inject a management context, which is what I want to do (obviously we could add that if we chose).
The BrooklynRestApiLauncher can be configured with a management context but does not include the UI. There is a surprisingly large amount of code in that class! I presume it's duplicating what is in BrooklynLauncher. I therefore much prefer my approach of just extending BrooklynLauncher, overriding start().
At some point we could try re-writing BrooklynRestApiLauncher to extend BrooklynLauncher, but just now I don't want to risk accidentally breaking all the rest-api tests that use BrooklynRestApiLauncher. I suggest we come back to that in another PR in the future.
@neykov are you ok with merging this as-is?

+1, merging.


Build pipeline: Remove static libraries, and build arm+arm64 along with UWP

We (Microsoft) needed the loader built for UWP packages and ARM/ARM64 so this modifies the build a bit to support that. Summary of changes and why:

"UWP" target was added because HoloLens 2 apps will need them.
Removed builds of the static loader. I do not believe it is safe to build static libs because compiler settings such as around exception handling can impact whether things link together (to the best of my knowledge at least).
Since the DLL is a robust ABI, we don't need to draw attention to msvs2019 as opposed to msvs2017 so I removed that from the directory names
I re-arranged the final output artifact because it assumed only 32-bit and 64-bit Intel, but we need ARM and ARM64 too. I changed the root folder names so that they include the target platform name and then each folder contains a 'lib' and 'bin'  subfolder (no more lib32/bin32). I also moved the 'include' folder to the root because every copy is the same.

The removal of static lib might be debatable so if this is not desired I can undo it. I'm also happy to change the final folder structure. You can see my pipeline results here including the artifacts: https://bryceh.visualstudio.com/OpenXR/_build/results?buildId=26&view=results

Can I trouble you for a changelog fragment?


Design update to heading and title styles of public profile pages

Context
The text styles of the titles, subtitles, and headings of public profile pages are somehow off, for example:

Description
Version in production
Design proposal

Here, the collective's name (Also the page title) is competing with the next title, should be subordinated to the main page title. Right now, bot are 32 px, we are changing the collective's name to 40 px

Similar to the previous one, we have a subtitle with the same style as the title. We changed it from 32 px both to 32 px and 24 px respectively

In this case, we have yet another title style, this one even bigger than the page title. We changed it from 40 px to use a subtitle in 24 px

We will have lesser, more consistent styling in headings and titles with these updates.
🎨 Design file reference
cc @Betree

@Memo-Es Is the design linked above ready for implementation?

@Betree Yes, literally is just having a descending order in the text styles from 40 - 32 - 24 px so I made the changes directly in the library file, that's why is not in production ready


Introduce missing order execution price into the model

Once we execute an order we know the execution price and have to keep it around.

In rust business logic is makes sense to depict this as falue on the Filled enum variant.
For the Order exposed on the API I opted for a nullable fields, because complex enum variants are not fun to be mapped into Dart.

bors r+

@da-kami : is this branch rebased against latest master?

@da-kami : I think it's not your fault. This might have been introduced with: https://github.com/get10101/10101/issues/157

@da-kami : I think it's not your fault. This might have been introduced with: #157

I see, that's unfortunate.
I still have some work on my TODO list on the position UI (want to get this over the finish line); if this is still a problem once I have that PR ready I'll have a look :)

@da-kami : I think it's not your fault. This might have been introduced with: #157

I see, that's unfortunate. I still have some work on my TODO list on the position UI (want to get this over the finish line); if this is still a problem once I have that PR ready I'll have a look :)

I think we'll need this to fix it:
https://github.com/get10101/10101-PoC/blob/main/.github/workflows/ci.yml#L151-L166

bors retry

bors retry

bors r+


Add func ChromeDriver(path string) to support -Dwebdriver.chrome.driv…

Thank you!
This needs a unit test, but since I'm delinquent in this review, I'll merge this and follow up separately.


Redo delay option missing

3.2.8 SNAPSHOT
The editor option "Redo delay" is missing in this version. Its not possible to set the redo delay.

This is not a bug. Option has been moved to the WIP section for that dev build.

So the redo delay will return in a later version?

It's still in-game under Planner (WIP) -> option 4, but shows up as NULL because it's a dev build. That said, all of the existing redo-delays still work and can be edited in the config under 'planner.cooldown'


Docs initial revision

Not to be merged while WIP is in the title
Im Opening this PR for review, so there can be changes made as needed.
Should be able to close #6

Added installation istructions, docs for helpers and json-maestro module and cli tool documentation

Scripts are wrappers around mdbook commands so we dont have to store duplicate files

Removing WIP from title

This PR requires following changes to the repository:

In Pages settings it requires deploy from options to be set to from Action

All currently shown examples have been tested locally, perhaphs there should be examples directory in the tests directory added later that would test if shown examples are working correctly
Current Examples are crude and are used more as place holders

Preview of docs site is avaible at https://shoshta73.github.io/json-maestro/
It is based of this commit

Merging as is.
Tagging merge commit as v0.0.2


[IO-427] Add TrailerInputStream

Add a new TrailerInputStream which holds back the last x bytes of the underlying input stream while reading it.
This is useful, e.g., when a payload is followed by a fixed-length checksum.
https://issues.apache.org/jira/browse/IO-427

If this class is indeed generally useful, can it be reused from our Tailer classes?

Whilst the class seems to work well, I'm not convinced that there is a sufficient need for it.
Every extra class adds to the maintenance load, so there needs to be a demonstrated to make it worth the extra effort.

Right, I agree, and as I mentioned earlier: Could this be reused as is within IO itself (Tailer class) and from Tika which provides a similar class?


Support node 12

This arised from support ticket :point_right: https://issues.liferay.com/browse/LPP-36579

Apparently this won't be possible unless we upgrade gulp.

So, this turned out to be a duplicate of #148, so I'm closing it.


[WIP] TUH updates

-improved selection of recordings to be loaded
-added verbose argument to suppress mne logging

@MFattouh Do these changes work for your use case?

Is this still relevant @MFattouh ?

@robintibor yes of course. On top of potential performance improvements, I think this code refactor makes it easier to extend the behavior of TUH constructor.

Closing this for now as it is unfinished and doesn't have somebody right now motivated to work on it, can still be reopened if somebody feels interested.


Adding a few comments where necessary

I am adding a few comments in the python script where I found them to be necessary. I would be adding some more soon.
Briefly edited the Readme.

@shaleenx Can you rebase the branch to remove unrelated changes?


Parallel generate file

WHY
To improve processing performance.
WHAT

new and gen subcommand generate file parallel.
Remove hardcode template file name.

new command generates all files at the application root. Plz fix this.
$ ls
#version.go#    db.go           main.go         router.go       set_db.go       version_test.go
README.md       field.go        pagination.go   server.go       version.go

(#version.go is a backup file by Emacs)

Sometimes gen command fails due to concurrent map write / read.
panic log: https://gist.github.com/dtan4/98b38981d36a213bf5f2fd6ec74d4c2d
Probably there are some non-thread-safe points. Please take a look.

As always, if one goroutine is writing to a map, no other goroutine should be reading or writing the map concurrently.
https://blog.golang.org/go1.6

😄  ...FIx it.

Fixed.
generated path
>>> bin/apig new hoge
	create /Users/muni/.go/src/github.com/munisystem/hoge/.gitignore
	create /Users/muni/.go/src/github.com/munisystem/hoge/router/router.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/helper/field.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/server/server.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/.gitkeep
	create /Users/muni/.go/src/github.com/munisystem/hoge/models/.gitkeep
	create /Users/muni/.go/src/github.com/munisystem/hoge/version/version.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/db/db.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/middleware/set_db.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/.gitkeep
	create /Users/muni/.go/src/github.com/munisystem/hoge/main.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/version/version_test.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/README.md
	create /Users/muni/.go/src/github.com/munisystem/hoge/db/pagination.go
===> Created /Users/muni/.go/src/github.com/munisystem/hoge

>>> ls $GOPATH/src/github.com/munisystem/hogee
README.md   db          helper      middleware  router      version
controllers docs        main.go     models      server

Concurrent R/W map (golang v1.6)
>>> go version
go version go1.6.2 darwin/amd64
>>> make
go get github.com/jteeuwen/go-bindata/...
./glide install
[WARN]	The name listed in the config file (github.com/wantedly/apig) does not match the current location (.)
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Found desired version github.com/gedex/inflector 91797f1712fd58f224781be1080b8613d096187e!
[INFO]	--> Found desired version github.com/tcnksm/go-gitconfig 6411ba19847f20afe47f603328d97aaeca6def6f!
[INFO]	Setting references.
[INFO]	--> Setting version for github.com/gedex/inflector to 91797f1712fd58f224781be1080b8613d096187e.
[INFO]	--> Setting version for github.com/tcnksm/go-gitconfig to 6411ba19847f20afe47f603328d97aaeca6def6f.
go generate
go build -ldflags="-s -w" -o bin/apig

>>> ./apig gen
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/nation.apib
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/user.apib
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/accountname.apib
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/user.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/accountname.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/nation.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/profile.apib
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/email.apib
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/profile.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/controllers/email.go
	create /Users/muni/.go/src/github.com/munisystem/hoge/docs/index.apib
	update /Users/muni/.go/src/github.com/munisystem/hoge/router/router.go
	update /Users/muni/.go/src/github.com/munisystem/hoge/README.md
===> Generated...

LGTM 👍


[SIP-5] Refactor filterbox

Remove dependency to d3.
Organize variables
Break render function into smaller ones.
Update PropTypes

Codecov Report

Merging #5789 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
- Coverage   63.78%   63.77%   -0.02%
==========================================
  Files         364      364
  Lines       23111    23115       +4
  Branches     2587     2586       -1
==========================================
  Hits        14741    14741
- Misses       8355     8359       +4
  Partials       15       15

Impacted Files
Coverage Δ

superset/assets/src/visualizations/filter_box.jsx
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4b1b7...6fe6528. Read the comment docs.


Add user exp attributes

Add following experiment attributes :

[x] User name
[x] Script name
[x] Date of experiment beginning
[ ] Enable to navigate left/right if there are too much things to show on the table

Not sure about the need of navigating through different pages


#644 Describe Helm Values for installation

Closes #644.
This PR describes helm-values for installation for 0.7.x. I haven't copied it over to the 0.8.x folder yet, as I still need input/changes from @agrimmer regarding the values.

Preview Install Docs 0.7.x
Preview Advanced Install Docs 0.7.x

Todo

[x] Get input and additional values provided by @agrimmer
[ ] Copy the resulting changes over to the 0.8.x folder

Thank you for introducing this well-structured table of the provided Helm values!


X509_dup: up_ref the EVP_PKEY instead of duplication

The EVP_PKEY_dup operation is not supported with ENGINE based
or application method based legacy keys. We use EVP_PKEY_up_ref instead
as X509_PUBKEY_dup uses EVP_PKEY_up_ref only as well and the EVP_PKEYs
are "mostly immutable".
Fixes #16606

This is an alternative PR to #16645 - I prefer doing just an up_ref for consistency instead of doing dup and falling back to up_ref.

@mattcaswell are you fine with this change?

Seems ok - but is this technically a beahviour change?

Yes, it is. Probably worth getting an explicit exception from OTC.

I'll add a documentation (also mentioning the X509_PUBKEY_dup()) and a test case.

It is also worth mentioning that 1.1.1 simply relied on the default ASN1_item_dup operation for X509 meaning that it was doing i2d and d2i when duplicating.

Testcase added.

I've verified that the testcase fails if the fix is reverted.

This pull request is ready to merge

OTC: up_ref is wrong here, both X509_dup and X509_PUBKEY_dup should duplicate the key (or recreate from scratch if not possible to duplicate)


Preset and rendering for boundary=protected_area

Description
boundary=protected_area was introduced to indicate nature conservation areas. It is rendered on Mapnik, but in iD (as in JOSM) it is not defined or displayed by a preset.
The relationship between boundary=protected_area and leisure_nature=reserve is unclear and is also not clear when reading the wiki pages. In practice, both are often used together. Unfortunately the explanations differ also depending on the language of the wiki page. See also https://wiki.openstreetmap.org/wiki/Talk:Tag:leisure%3Dnature_reserve#leisure=nature_reserve_vs._boundary=protected_area
However, if a preset would be created, boundary=protected_area could be better used (for protected areas, as intended). In iD it could be named "Conservation Area" or "Protected Area".
Screenshots
No response

There isn't a strong distinction between these tags. The nature reserve tag is often used with the protected area tag because the protected area tag doesn't render by itself in osm-carto.

Something weird goes on in Carto: this protected_area (without leisure=nature_reserve) is rendered just fine, while this one is not. The former is just a closed way and the latter a relation, but I don't think this matters. (There are a few other invalid multipolygons in that area, which may affect rendering of so large entity).
iD currently supports boundary=protected_area as a subtype of boundary relation, but it does not have a preset for closed ways. I would argue that protected areas are better off that way, i.e. only as relations, but the practice (and Wiki) says otherwise.

because the protected area tag doesn't render by itself in osm-carto.

That's not true. It renders both.

Something weird goes on in Carto: this protected_area (without leisure=nature_reserve) is rendered just fine, while this one is not.

Yes that's weird. I tried it out, it doesn't matter if it's a relation or a way. Does it render if you add leisure=nature_reserve?

It's not weird at all.
leisure=nature_reserve renders.
boundary=protected_area plus certain values of protect_class render.


Filter duplicate events from ClusterGroup reconcile

Enroll into unstable-runtime to control and reuse object streams from watches.
Reduce cache size by removing managed_fields
Set the finalizer on the ClusterGroup object to ensure deletion events are not missed, and object is recreated
Upon fleet team request - removed creation of local cluster with --set bootstrap.enabled=false

Fix: #84

After merging this it is worth considering new patch release


Change dependents to optionalPrerequisitesOf

This changes the name of the Dependency API member dependents to optionalPrerequisitesOf. The former name was causing large amounts of confusion where users thought that declaring a dependent meant that the downstream dependent would get scheduled. In actuality, declaring a dependent meant injecting an optional prerequisites.
This makes the migration in a backwards-compatible way by adding a new optionalPrerequisitesOf member with a default implementation of dependents. The PR then deprecates dependents and changes names/comments in the DependencyManager to remove references to "dependents". All transforms are then migrated to set optionalPrerequisitesOf instead of dependents.
This is currently sitting on top of #1534 and should be merged after that.
Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[x] Did you update the FIRRTL spec to include every new feature/behavior?
[x] Did you add at least one test demonstrating the PR? (N/A, no new feature added.)
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

new feature/API

API Impact

deprecates firrtl.options.DependencyAPI[_].dependents
adds firrtl.options.DependencyAPI[_].optionalPrerequisitesOf

Backend Code Generation Impact

None.
Desired Merge Strategy

Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Deprecate Dependency API dependents, renames dependents to optionalPrerequisitesOf

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Since this has all the commits with master as the base, could we not just rebase-and-merge this PR and get all the commits?

@albert-magyar: My plan was to get #1534 merged and then rebase this (#1537) onto master and merge it. However, directly merging #1537 would be equivalent.


Fixing sky material

where "pow(skyColor,vec3(1.0/(1.2+(1.2*sunfade)));" may generate wrong values. Just keep retColor = skyColor instead

Just committed the clamp