Don't return a file path from _find_observable_paths

We can return a file path when there is file path in sys.path (A zip or a launcher exe). This causes a WindowsError for ERROR_INVALID_PARAMETER.

Please be more specific about the error and why it needs to be fixed. Is it causing something to fail? The reloader already handles skipping paths that Watchdog can't observe (files).
This fix also seems too broad. Perhaps files should be added to self.extra_files so that the specific file is watched, rather than watching the entire dir.

I'm running a Flask app on Python 3 6 on Windows by using flask run, have watchdog installed, and I'm getting the following:
Traceback (most recent call last):
  File "lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "lib\site-packages\watchdog\observers\api.py", line 146, in run
    self.queue_events(self.timeout)
  File "lib\site-packages\watchdog\observers\read_directory_changes.py", line 77, in queue_events
    winapi_events = read_events(self._handle, self.watch.is_recursive)
  File "lib\site-packages\watchdog\observers\winapi.py", line 347, in read_events
    buf, nbytes = read_directory_changes(handle, recursive)
  File "lib\site-packages\watchdog\observers\winapi.py", line 307, in read_directory_changes
    raise e
  File "lib\site-packages\watchdog\observers\winapi.py", line 303, in read_directory_changes
    ctypes.byref(nbytes), None, None)
  File "lib\site-packages\watchdog\observers\winapi.py", line 108, in _errcheck_bool
    raise ctypes.WinError()
OSError: [WinError 87] The parameter is incorrect.

Because I seem to have "Scripts\flask.exe" in sys.path which is than passed to watchdog's observer schedule.

Why isn't this caught in WatchdogReloader.run? The except OSError catches watching files instead of directories on Linux at least. Should the except be expanded?

Why isn't this caught in WatchdogReloader.run? The except OSError catches watching files instead of directories on Linux at least. Should the except be expanded?
It's thrown in the watchdog Observer thread and not in the WatchdogReloader thread.

Sadly this also means that you can't listen for files that temporarily might not exist. I really think this is a bug in watchdog. We can probably add a windows specific workaround but not sure how I feel about that.

In Linux:
werkzeug1157.py
import time
import logging
from watchdog.observers import Observer
from watchdog.events import LoggingEventHandler

with open('hello.txt', 'w') as f:
    f.write('Hello, World!')

logging.basicConfig(level=logging.INFO)
event_handler = LoggingEventHandler()
observer = Observer()
observer.schedule(event_handler, 'hello.txt')
observer.start()
try:
    while True:
        time.sleep(1)
except KeyboardInterrupt:
    observer.stop()
observer.join()

Output
➜ python wekzeug1157.py
Traceback (most recent call last):
  File "wekzeug1157.py", line 13, in <module>
    observer.start()
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/observers/api.py", line 255, in start
    emitter.start()
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/utils/__init__.py", line 111, in start
    self.on_thread_start()
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/observers/inotify.py", line 121, in on_thread_start
    self._inotify = InotifyBuffer(path, self.watch.is_recursive)
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/observers/inotify_buffer.py", line 35, in __init__
    self._inotify = Inotify(path, recursive)
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/observers/inotify_c.py", line 187, in __init__
    self._add_dir_watch(path, recursive, event_mask)
  File "/home/segev/tests/watchdog/local/lib/python2.7/site-packages/watchdog/observers/inotify_c.py", line 363, in _add_dir_watch
    raise OSError('Path is not a directory')
OSError: Path is not a directory

The exception is thrown from start and not from schedule, I think the try ... except in WatchdogReloader.run won't even help and you will simply be hit with this OSError when this happens which will probably exit the process entirely.
watchdog simply doesn't want files in schedule, with poor error reporting of it. Sadly watchdog appears to be unmaintained, so any pull request against it will likely be left hanging with no response at all.
Having non existent items in sys.path is kinda weird. I think Python ignores them, but I'm not sure... Sadly watchdog can't watch non existent directories either. And watchdog chokes on them in a similar fashion too...

Merging this after the conversation above.


Cached Docker images in GitHub Action

Currently, it takes between 20-24 minutes to pull and convert the needed Docker images.
Refactor the CI workflow to run cached Docker images and decrease the running time.

Note that this is a low priority issue. You can spend some time exploring what options there are, if any, and then we can see if there's anything that we could reasonably implement.
But one way or the other, tests will run several minutes at least, and we will need to deal with that.
Also, typically the local development environment shouldn't be much different from that on the CI virtual machine, so if you only push your commits after tests have passed locally (which should be much faster), in the vast majority of cases, the outcome of the CI tests will not differ from that of the local ones.


Eater princess decompilation issue

[ ] the princess is squished

[ ] sprite.z is not decompiled correctly

I'll open a separate issue for the z thing, the princess decompilation is fixed.


Failed building wheel for cffi

When installing, an error is given:
Failed building wheel for cffi
Reason:
c/_cffi_backend.c:15:17: fatal error: ffi.h: No such file or directory
I believe that libffi-dev has to be installed before building, but that this is not yet checked for beforehand?

Mentioned in dependencies but not checked by requirements.txt


Avoid downloading scripts to /tmp

/tmp often has noexec for security reasons, and Docker requires privileged access in order to mount /tmp. Please have the rustup install script download to another directory, such as $HOME, for better support for these surprising *nix environments.

An environment variable TMPDIR should be able to configure the location:

https://www.gnu.org/software/coreutils/manual/html_node/mktemp-invocation.html
https://doc.rust-lang.org/std/env/fn.temp_dir.html

You may want to give it a try.

rustup-init.sh honours $TMPDIR via the mktemp -d command.


Examples on source and data

Could you post a simple example on how to use this as library? Moreover, a sample on how the data and class labels should look like. It would help others immensely.

Could you post a simple example on how to use this as library?

Done:
https://github.com/lemire/lbimproved/blob/master/example.cpp

Moreover, a sample on how the data and class labels should look like. It would help others immensely

The library just seeks nearest neighbors between same-size arrays. If you want to use it for classification, that's a higher level concept, but it should not prove difficult.
I'll close this issue. If you can narrow down your question, ideally with code samples, I'll be glad to  follow up.


Add handling of automod actions to the strike cog

yeah I give up with this - can't get it to work / make sense


Credential Rotation Feature

Add a feature to rotate the IAM access keys.
Needs to support using current session token to create new access keys, verify and write back to the keychain. Think about failure scenarios.

Feature added with #11


Updating github.com/docker/docker/pkg/term Godep.

This matches the version of the rest of the Docker package. There is no
actual code change, but the mistmatch made it impossible to udpate the
dependency (or any that depended on this).

Why does this update the Godep but not the files?

You're saying that the existing code and Godeps file didn't match? Not too hard to believe. LGTM

@bgrant0607 only one of the dependencies changed the version we target but the bump in version was not accompanied by any change of code in that package. For some reason not all of our Docker deps were at the same revision.


get the image-registry image name from the cluster env

/assign @legionus
in theory this will cause us to inherit the cluster-defined source for the image when the operator is installed by the CVO.

Good job, CI.
aws_eip.nat_eip.5: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: 5154a95f-1ecc-4281-9d14-76865b4feeb5

/retest

@bparees we don't have anything to migrate yet. But just out of curiosity how will we know that the provided image and the installed image have different major versions and additional actions are required? I don't see how we can get the version.

@bparees we don't have anything to migrate yet. But just out of curiosity how will we know that the provided image and the installed image have different major versions and additional actions are required? I don't see how we can get the version.

Great question.  @jwforres any details on how that's supposed to work?  Essentially the operator can be told "install this registry image" w/o knowing anything about the registry image its supposed to install.  What happens if migration is needed prior/after updating the registry image?  How does the operator know it needs to do that?

@legionus any concerns that can't be discussed in a followup?  This gets our operator to deploy the "correct" image-registry image.

any concerns that can't be discussed in a followup?

As you wish.
/lgtm


Remove module-info.class from artifact

Closes #22

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


return of the knockdown bug

destroyed the leg on the jenner, it falls then starts to slide around instead of standing back up
output_log.txt
cleaned_output_log.txt
harmony_summary.log
ModTek.log
2020-02-29T13:01:26 FYLS [LOG] Actor Jenner (358c5692-25ee-433b-b9ce-bab9ae35528e.0) - Jenner (358c5692-25ee-433b-b9ce-bab9ae35528e.0) FLAGGED FOR KNOCKDOWN!

if you need any other logs let me know


Nullreference exception with some markdown

Description
"System.NullReferenceException: Object reference not set to an instance of an object" thrown with some markdown, only when colorcode extension is used
Expected Behaviour
No error is thrown and markdown is produced
Actual Behaviour
Error was thrown
Affected Version
1.0.3
Steps to Reproduce
Sample code
using Markdig;
using Markdown.ColorCode;
using ColorCode.Styling;
using System;

public class Program
{
	public static void Main()
	{

		var markdownPipeline = new Markdig.MarkdownPipelineBuilder()
            .UsePipeTables()
            .UseAdvancedExtensions()
            .UseColorCode(StyleDictionary.DefaultDark)
            .UseAutoLinks()
            .UseEmojiAndSmiley()
            .UseMediaLinks()
            .UseCitations()
            .Build();

		var result = Markdig.Markdown.ToHtml("To print \"Hello World\" in C#, you can use the following code:\n```c",markdownPipeline);
		Console.WriteLine(result);
	}
}

Error is not thrown if UseColorCode line is commented out
Checklist

[x] I have read the contributing guidelines
[x] I have verified this does not duplicate an existing issue

On investigating further it's something to do with the language name after the backticks. Adding a newline character on the string to be formatted still produces the error, but adding a newline followed by at least one other character works.

Thanks for the details, @ogchrislem!
I will start looking into this as I have time, but you can also feel free to open a pull request if you've found the problem and would like to address this issue yourself.

@ogchrislem I'm able to replicate your issue and see what the problem is.
You aren't including any lines of code in your code block, which is causing lines here to be null, which is immediately followed up by that null reference exception you are hitting.
My expectation would have been that this value would be an empty array rather than null, but it seems like Markdig is setting it to null when no lines of code are included and I will have to handle for that case.

@ogchrislem https://github.com/wbaldoumas/markdown-colorcode/pull/89 currently addresses this.
Feel free to give it a try by installing preview version 1.0.4-preview-2. Let me know how that works and I will work to get a new release out when I can.

@ogchrislem version 1.0.4 should be published and available for use. Closing this issue, since it seems like this resolved what you were seeing.
Thank you for your contribution!


Issue Note | N : 8

documentations

1. All the algorithm SVG files are deprecated and unparsable.

Signed off by: @KhodeNima

Issue resolved in V : 14.1.2.


Multiple constraints

I couldn't find an option to add multiple constraints. I want to optimize in 3d space. Several separate 3d regions should be part of the search space.
My use case is sensor placement optimization. I want to define disconnected regions where sensors can be placed, e.g. certain areas at different walls of a robot cell. The optimizer should provide solutions within these regions. How can I define a parameter space like that?

Hello! There is no problem for multiple constraints.
You can add constraints with the contraint_violation mechanism.
For example with ask and tell:
optimizer.tell(candidate, value, [constraint_violation1, constraint_violation2, constraint_violation3])
Other examples at: https://facebookresearch.github.io/nevergrad/optimization.html
(register_cheap_constraint is another possibility, but for most users constraint_violations is better)

when I use optimizer.tell(candidate, value, [constraint_violation1, constraint_violation2, constraint_violation3]), the warning is:  optimizer.tell(candidate, objective_value, constraint_violations) TypeError: tell() takes 3 positional arguments but 4 were given


Add http server code to communicate with PSLab over wifi using ESP

Currently, there is no functionality available to communicate with PSLab wirelessly. This issue aims to add server code for wifi communication

@CloudyPadmal now basic code is there... which other endpoints we aim to add to server?

Also wont we need a c library like other functionalities so we can connect esp module to pslab and also get voltage data from PSLab and broadcast them over wifi

Think about ESP chip as the same UART chip. UART chip has some internal firmware

to send data from outside to microcontroller and
to send data to outside from microcontroller

Functionality of ESP is the same. It will have an endpoint to write whatever the data we are sending to serial port and read from serial port and send whatever the data coming from microcontroller to outside. No need to do any data processing inside ESP. Only two endpoints are needed (Get and Post). But we can customize and have multiple endpoints to group calls and increase performance. But the basic idea is similar to what the UART chip is doing. ESP will be just an interface.

so will need to endpoints as you said... getData() and sendData().... on the ESP side... and from the PSLab android app we will call these endpoints when we want to communicate... for example to get version of PSLab... we will first send (POST request) 11 and 5 to sendData endpoint and then will make a GET Request to getData() to receive the data. Sounds right?

Yes. Sounds right.

So for now I will keep the post request contain simple json object with one parameter of data having the required byte string. Also from the proposed methods i think the 2nd one seems logical. Creating two flavors would add a lot of redundancy i believe. I will open an issue to add http communication handler in android app.

Looks like this project https://github.com/fossasia/labs.fossasia.org/issues/286 is dependent in some way on this issue.


TCP Challenge Ack and envoy SO_REUSEADDR

Title:  TCP Challenge Ack and envoy SO_REUSEADDR
Description:
Plato is using envoy in L2 mode behind a AWS NLB (no preserve source ip & proxy protocol, no cross zone) and we have been seeing our average request time for hitting envoy (returning 404) spike to over a second every now and then.
Tracing this down I have found that the amazon linux 2 (kernel 5.10) that envoy is running on is sending a challenge ack causing the client to wait a second and then restart the tcp connection (same port) and every thing works fine their after. With the way the NLB from AWS is configured it is doing NAT and using the same ip for hitting the envoy host every time but the strange thing is that wireshark (i.e. tcpdump) traces dont show that the port was reused recently but still the linux kernel is triggering a tcp challenge ack.
The one thing that has made this issue almost disappear is disabling SO_REUSEADDR by disabling enable_reuse_port in envoy listener.
Note: envoy is running in k8s with host networking enabled on a 2 core ec2 node to it self.
Has any one seen this before?
Is there any other envoy settings that might cause the linux kernel to trigger this bad behavior?

cc @mattklein123 @alyssawilk


Issue: customizations show up locally but not when deployed

So I added the dracula theme for prism by adding the CSS file to my app. I see the changes locally, but when it deploys (Netlify), the changes don't show up:
Local:

Deployed:

Any ideas on what to do differently?

@MelSumner I am not seeing prism or ember-prism in the package.json of ember-a11y-refocus. My guess would be the CSS is not getting deployed correctly or a PurgeCSS or something similar is removing the styles?

@rwwagner90 that's not the repo- see https://github.com/MelSumner/ember-a11y-for/issues/1 👍


Add subtitle support

This project uses semver, please check the scope of this pr:

[ ] #patch# - backwards-compatible bug fix
[x] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Added optional subtitle property to modals to support adding a subtitle to the header.
Upgraded devDependencies to latest versions for demo app.

Visual Acceptance tests:
No changes

Approved


BadMsgNotification 32 for msg #39C6

When my app has run about 1 day, it has high opportunity to occur the error "BadMsgNotification 32 for msg #39C6".
And the result is the current session can not use, I have to login again to create a new session.
How to fix this problem.
Basic information:
1 I use MTProto
2 I send a message to a group per 30 seconds as heart beat.
3 no more other actions, just received OnUpdate event , and print to console.

I 'v modified  function Helper.RandomLong();
and used DateTime.Now.Ticks as a initial data, and return increment data.
and it can run by the old session.
I'll wait and see if the problem occur again.

It happen again.  BadMsgNotification 32 for msg #15C3

If you're the only one getting this, i bet you must be doing something weird with your session/session file/client, like copy/duplicate/instanciate them and running them at the same time...
Make sure you don't and you Dispose the client properly before recreating one for the same session.


about nested FieldArray some question

when you use in nested FieldArray like this
const renderMembers = ({ fields, meta: { touched, error } }) => (

      <button type="button" onClick={() => fields.push({})}>Add Member</button>
      {touched && error && {error}}

    {fields.map((member, index) =>

        <button
          type="button"
          title="Remove Member"
          onClick={() => fields.remove(index)}/>

Member #{index + 1}

        <Field
          name={`${member}.firstName`}
          type="text"
          component={renderField}
          label="First Name"/>
        <Field
          name={`${member}.lastName`}
          type="text"
          component={renderField}
          label="Last Name"/>
        <FieldArray name={`${member}.hobbies`} component={renderHobbies.bind(this)}/>

    )}

)

i only  change example

<FieldArray name={${member}.hobbies} component={renderHobbies/>
to
<FieldArray name={${member}.hobbies} component={renderHobbies.bind(this)}/>

you have to  click twice  to focus input(Hobby#1)..until click#2  focus to Hobby#1

Hi there. I'm unsure what your question is about exactly?

Hi @timtian, you question is not clear.
Also, in React when a function is supposed to render a component it's usually not a good idea to call .bind(this) on it, as the new component may interfere with the external component's this.
In case you can show us code that reproduces your issue, it would be great.


My Ci is failing

Just started happening - any idea why it can't download it?
#13 275.2 error: failed to run custom build command for `utoipa-swagger-ui v7.0.3`
#13 275.2
#13 275.2 Caused by:
#13 275.2   process didn't exit successfully: `/app/target/release/build/utoipa-swagger-ui-94ae60d10ee2cff4/build-script-build` (exit status: 101)
#13 275.2   --- stdout
#13 275.2   OUT_DIR: /app/target/release/build/utoipa-swagger-ui-605372b8f80681d0/out
#13 275.2   SWAGGER_UI_DOWNLOAD_URL: https://github.com/swagger-api/swagger-ui/archive/refs/tags/v5.17.3.zip
#13 275.2   start download to : "/app/target/release/build/utoipa-swagger-ui-605372b8f80681d0/out/v5.17.3.zip"
#13 275.2   cargo:rerun-if-env-changed=SWAGGER_UI_DOWNLOAD_URL
#13 275.2   reqwest feature: Err(NotPresent)
#13 275.2   trying to download using `curl` system package
#13 275.2
#13 275.2   --- stderr
#13 275.2   thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/utoipa-swagger-ui-7.0.3/build.rs:58:47:
#13 275.2   called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
#13 275.2   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
#13 275.2 warning: build failed, waiting for other jobs to finish...
#13 ERROR: process "/bin/sh -c set -e\ncargo build --release\n\ncp ./target/release/$APP_NAME /bin/server\n" did not complete successfully: exit code: 101

hmm just started working again after retry several times

FYI this also happened to us. I pinned utoipa-swagger-ui 7.0.1 for the moment as a workaround. But if it's now magiced a solution, I'll unpin it and report back to see if that's true for us.

I believe that the actual issue lies within GitHub itself. Since it tries to download the Swagger UI from GitHub releases and it is not meant for heavy traffic IMO and might be bit unpredictable.
However it tries to download the Swagger UI with curl and fails if underlying system does not have that package. Alternatively it can be downloaded with reqwest via reqwest feature flag or since 7.1.0 there is vendored feature flag that provides vendored Swagger UI which basically behaves the same as pre 7.x.x versions. I noticed that there is still a need for a vendored Swagger UI to give ultimate stability in sandboxed environments.

Can confirm that not having curl in the underlying container is the issue.
"trying to download using curl system package" in that sense isn't the most helpful of errors, would suggest something more explicit like "failed to find the system package curl".

True, could actually improved at sometime in future. I'll add task to the board about this


Rotate and switch methods and tests

Gurgen jan chem haskanum mots mvn install anumem sax tester@ normal ancnuma stex che(((


Error executing "bundle exec fastlane setup"

Hello,
I have found your SDK and also your DemoApp for this SDK but I am not able to run either of them.
After executing the command " bundle exec fastlane setup" I get this error:
" Exit status of command 'carthage build --no-use-binaries --platform iOS --configuration Debug --cache-builds' was 1 instead of 0.
*** No cache found for BigInt, building with all downstream dependencies
*** No cache found for DataKit, building with all downstream dependencies
*** No cache found for ref-GemCommonsKit, building with all downstream dependencies
*** xcodebuild output can be found in /var/folders/kw/5wzswvfs2rqdc1dw9tt3vts40000gn/T/carthage-xcodebuild.WL9lbn.log
*** Building scheme "BigInt-iOS" in BigInt.xcworkspace
A shell task (/usr/bin/xcrun lipo -create /Users/bogdanpralea/Library/Caches/org.carthage.CarthageKit/DerivedData/14.3_14E222b/BigInt/v5.3.0/Build/Intermediates.noindex/ArchiveIntermediates/BigInt-iOS/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/BigInt.framework/BigInt /Users/bogdanpralea/Library/Caches/org.carthage.CarthageKit/DerivedData/14.3_14E222b/BigInt/v5.3.0/Build/Products/Debug-iphonesimulator/BigInt.framework/BigInt -output /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Build/iOS/BigInt.framework/BigInt) failed with exit code 1:
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: /Users/bogdanpralea/Library/Caches/org.carthage.CarthageKit/DerivedData/14.3_14E222b/BigInt/v5.3.0/Build/Intermediates.noindex/ArchiveIntermediates/BigInt-iOS/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/BigInt.framework/BigInt and /Users/bogdanpralea/Library/Caches/org.carthage.CarthageKit/DerivedData/14.3_14E222b/BigInt/v5.3.0/Build/Products/Debug-iphonesimulator/BigInt.framework/BigInt have the same architectures (arm64) and can't be in the same fat output file
Building universal frameworks with common architectures is not possible. The device and simulator slices for "BigInt" both build for: arm64
Rebuild with --use-xcframeworks to create an xcframework bundle instead."
The log looks like this:
"/Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/BigInt/BigInt.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'BigInt-iOS' from project 'BigInt')
** BUILD SUCCEEDED **"
After searching a bit I have found that this is a problem with Carthage and the recommended solution on their forums(https://github.com/Carthage/Carthage/issues/3333) is by using a script.
So I created the script and tried to run it with " sh carthage.sh update --platform iOS --use-xcframeworks --no-use-binaries" and it still fails with the error:
"*** Building scheme "NFCCardReaderProvider" in OpenHealthCardKit.xcodeproj
Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -project /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/OpenHealthCardKit.xcodeproj -scheme NFCCardReaderProvider -configuration Release -derivedDataPath /Users/bogdanpralea/Library/Caches/org.carthage.CarthageKit/DerivedData/14.3_14E222b/ref-OpenHealthCardKit/1.0.3 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive VALIDATE_WORKSPACE=NO -archivePath /var/folders/kw/5wzswvfs2rqdc1dw9tt3vts40000gn/T/ref-OpenHealthCardKit SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO FRAMEWORK_SEARCH_PATHS=$(inherited)\ /var/folders/kw/5wzswvfs2rqdc1dw9tt3vts40000gn/T/carthage-xcframework-xQQx (launched in /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit)"
and the error in the log : "
/Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Reader/NFCCardReader.swift:71:27: error: cannot assign to property: 'value' is a get-only property
cardPresenceBlock.value = block
~~~~~~~~~~~~~~^"
....
** ARCHIVE FAILED **
The following build commands failed:
CompileSwift normal arm64 (in target 'NFCCardReaderProvider' from project 'OpenHealthCardKit')
SwiftCompile normal arm64 Compiling\ NFCCard.swift,\ NFCCardChannel.swift,\ NFCCardReader+NFCTagReaderSessionDelegate.swift,\ NFCCardReader.swift,\ NFCCardReaderController.swift,\ NFCCardReaderProvider.swift,\ NFCISO7816APDU+CommandType.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Card/NFCCard.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Card/NFCCardChannel.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Reader/NFCCardReader+NFCTagReaderSessionDelegate.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Reader/NFCCardReader.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Reader/NFCCardReaderController.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Provider/NFCCardReaderProvider.swift /Users/bogdanpralea/Documents/Study/TestApp/Carthage/Checkouts/ref-OpenHealthCardKit/Sources/NFCCardReaderProvider/Card/NFCISO7816APDU+CommandType.swift (in target 'NFCCardReaderProvider' from project 'OpenHealthCardKit')
(2 failures)
"
Can you help me with this ?
Thanks!
carthage-xcodebuild.924P9r.log
carthage-xcodebuild.WL9lbn.log

Hi,
the documentation/Readme is outdatet (we will change that soon).
Executing make setup in the project's root directory should set up the project (brew will be needed).
Does the error continue to exist afterwards?

I close this due to inactivity.
Let us know whether the problem persists.


Client CSR is not deleted CentOS 7

When revoking the clients the CA cert is not removed from the server.
Current Code
- name: Revoke certificates
  command: sh revoke.sh {{ item }}.crt
  changed_when: true
  args:
    chdir: "{{ openvpn_key_dir }}"
  with_items:
    - '{{ openvpn_revoke_these_certs }}'
    - '{{ openvpn_cert_sync_revoke | default([]) }}'

New Code
- name: Revoke client crt
  file:
    path: "{{ openvpn_key_dir }}/{{ item }}.crt"
    state: absent
    force: true
  with_items:
    - '{{ openvpn_revoke_these_certs }}'
    - '{{ openvpn_cert_sync_revoke | default([]) }}'

I think this would be fixed by #186.

Merged to the forked role: https://github.com/aovpn/ansible-role-openvpn/pull/37


Dimension attrs lost when creating new variable with that dimension

What happened:
When creating a new variable based on an existing dimension, the attrs of the dimension are lost.
What you expected to happen:
The attrs should be preserved.
Minimal Complete Verifiable Example:
import xarray as xr

ds = xr.Dataset()
ds['x'] = xr.DataArray(range(10), dims='x')
ds['y'] = xr.DataArray(range(len(ds['x'])), dims='x')
ds['x'].attrs['foo'] = 'bar'
print(ds['x']) # attrs of ds['x'] are preserved

print('\n****\n')

ds = xr.Dataset()
ds['x'] = xr.DataArray(range(10), dims='x')
ds['x'].attrs['foo'] = 'bar'
ds['y'] = xr.DataArray(range(len(ds['x'])), dims='x')
print(ds['x']) # attrs of ds['x'] are lost

Output of above code:
<xarray.DataArray 'x' (x: 10)>
array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9])
Coordinates:
  * x        (x) int64 0 1 2 3 4 5 6 7 8 9
Attributes:
    foo:      bar

****

<xarray.DataArray 'x' (x: 10)>
array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9])
Coordinates:
  * x        (x) int64 0 1 2 3 4 5 6 7 8 9

Environment:
Output of xr.show_versions()
INSTALLED VERSIONS
commit: None
libhdf5: 1.10.5
libnetcdf: 4.7.4
xarray: 0.16.0
pandas: 1.0.3
numpy: 1.19.1
scipy: 1.3.1
netCDF4: 1.5.3
pydap: None
h5netcdf: 0.8.0
h5py: 2.10.0
Nio: None
zarr: None
cftime: 1.2.1
nc_time_axis: None
PseudoNetCDF: None
rasterio: 1.1.3
cfgrib: None
iris: None
bottleneck: 1.3.2
dask: 2.18.1
distributed: 2.25.0
matplotlib: 3.2.1
cartopy: 0.18.0
seaborn: 0.10.0
numbagg: None
pint: 0.15
setuptools: 49.6.0.post20200814
pip: 19.2.2
conda: 4.8.4
pytest: 5.4.1
IPython: 7.14.0
sphinx: None
None

I think this is #2180; see https://github.com/pydata/xarray/issues/2180#issuecomment-391932929 . Basically the RHS is prioritized and the x variable gets overwritten with the version of x on the RHS.
You can avoid this by going the Variable route instead of the DataArray route:ds["y"] = ("x", range(len(ds.x))) https://xarray.pydata.org/en/stable/data-structures.html#creating-a-dataset

Huh, I would not have expected that behavior. To my mind, it seems unwanted, but I don't totally follow the discussion in #2180. Thanks for the heads up.


fix(version): update fabric8-runtime-console to 0.8.22

There were the following issues with your Pull Request

Commit: f202cd477b9b30152daae3858d28e598c9959d5f
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


Not works with .dev local domains

What are you trying to achieve? (Expected behavior)
Open http://mylocaldomain.dev
What do you get instead? (Actual behavior)
Error

Details

Php-webdriver version: Latest
PHP version: 7.0
Selenium server version:
Operating system: Ubuntu
Browser used + version:

@akalongman Hi, this is not a problem of php-webdriver - it seems the .dev domain is being registered as a new top level domain, thus you cannot use it for local domains. Try different one, like .local.
See also https://superuser.com/questions/919278/err-icann-name-collision-when-trying-to-use-localhost-dev-in-chrome for more information.

It can be also achieved by changing the '/etc/host' file on your workstation.


Compilation errors in 1.19

Expected behavior
To be properly compiled
Actual behavior
× ｢atl｣: Checking finished with 3 errors                                                                                × ｢wdm｣:    1023 modules
ERROR in [at-loader] ./node_modules/jquery.terminal/js/jquery.terminal.d.ts:316:11
TS2430: Interface 'Cmd' incorrectly extends interface 'JQuery'.
Types of property 'resize' are incompatible.
Type '{ (handler: (eventObject: JQueryEventObject) => any): JQuery; (eventData: Object, ha...' is not assignable to type '{ (eventData: TData, handler: EventHandler<HTMLElement, TData> | EventHandlerBase<any, Eve...'.
Type 'JQuery' is not assignable to type 'this'.
ERROR in [at-loader] ./node_modules/jquery.terminal/js/jquery.terminal.d.ts:422:11
TS2430: Interface 'JQueryTerminal' incorrectly extends interface 'JQuery'.
Types of property 'next' are incompatible.
Type '() => JQueryTerminal' is not assignable to type '{ (): this; (selector?: string): this; }'.
Type 'JQueryTerminal' is not assignable to type 'this'.
ERROR in [at-loader] ./src/js/app/console/console.component.ts:36:51
TS2306: File 'C:/root15/Sources/Projects/ManagementConsole/node_modules/jquery.terminal/js/jquery.terminal.d.ts' is not a module.
i ｢wdm｣: Failed to compile.

fixed definition file, the issue was that I was testing on wrog type file for jQuery.

The fix is in version 1.19.1.


Maximum nesting level reached

Hey I'm running a very simple test:
`/** @test */
public function it_reserves_an_event()
{
    $this->post('api/v1/reservations', [
        'first_name' => 'rodrigo',
        'last_name' => 'lessa',
        'phone_number' => '9543030759',
        'date' => '2015-06-18',
        'guests' => '5'
    ])
        ->seeJson()
        ->seeStatusCode(200)
        ->seeInDatabase('reservations', [
            'first_name' => 'rodrigo',
            'last_name' => 'lessa',
            'phone_number' => '9543030759',
            'date' => '2015-06-18',
            'guests' => '5'
        ]);
}`

and I get this error:
EPHP Fatal error:  Maximum function nesting level of '100' reached, aborting! in /home/rodrigo/WebApps/ThreeAccents/enjoy_louville/api/enjoy_louville/vendor/laravel/framework/src/Illuminate/Contracts/Cache/Factory.php on line 3
But i know its working because when I use postman that error is not thrown.

Sounds like you're using Xdebug. You need to increase the max nesting level.
http://stackoverflow.com/questions/4293775/increasing-nesting-functions-calls-limit

@bobbybouwmann  It seems like that is just covering up the problem and not getting to the route of the problem

No. It's just that default nesting is deep threw function calls and class calls.
If there is a loop, rising it to 500 won't help you.

I have put the limit to 200 in my php.ini and even added ini_set('xdebug.max_nesting_level', 200);
I have received this same error for the past 8months using old and new versions of Test Dummy. Never been fixed for me. I cannot run a simple test using them.
OH Well. Sorry I am no help. But this has been the most frustrating issue I've ever come across.

And if you set it to 500? Or disable xdebug?

I tried 500 and I got a different error. I can't remember exactly but it was something to do with hitting a STDError limit for the stack trace I believe.
Anyways, I figure it was the way the ModelFactory itself was developed (on my end).
 So I made the owner_id set to 1 and will change it on fly if needed. Seems to work.


[FLOC-3077] Retry list in client tests to avoid spurious failures

Our centos-7 tests often fail with docker.errors.APIError: 500: Internal Server Error: Unknown device
This is probably due to a race condition in Docker. See FLOC-3077 for discussion.
The work-around is to retry the list operation in the test in order to avoid the race condition.
Rather than putting all of that logic in the test, I added a new retry_failure helper which does this. I considered trying to shoe-horn loop_until to fit this purpose, but it seemed cleaner to do it this way.

Awesome little test wrapper.
Your tests look like they want to be written in pymock :grin:. A nit and a question on your drive-by added XXX. Address and merge at will.

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

flocker/node/_docker.py, line 792 [r1] (raw file):
Should this be here, or at the class level? looks like auto_threaded is used with classes rather than functions. Also see optional point below about potentially removing:
:grey_question: Fine as is... but I'm never sure what to think of comments like this. Presumably while you were coding this PR, you noticed this, left the TODO/XXX.
The proposed value-add of this comment is later, if someone comes across this and is wondering why it isn't using this nice wrapper, they'll see your comment, and feel vindicated that it should use the nice wrapper and will go on coding it.
I don't think we ever will schedule a "reduce TODOs" epic, so I don't think this comment puts work on any engineer work-queue.
Comments always have the overhead of adding maintenance and risk becoming stale. Some of the methods of this class do some synchronous stuff before calling deferToThread. Perhaps it'd be okay for that work to be delayed til the other thread, but it might intentionally be done synchronously before scheduling async work, or that might be the case in the future. In that case this might misdirect a future reader.
Potentially consider just removing the comment and letting future maintainers make the assessment if the wrapper is useful? I'll defer to your judgement on if it's value-add is worth it.
 Are you familiar with https://pypi.python.org/pypi/retry/? looks like this is just the twisted implementation of that. Just thought I'd note that here in case you wanted to look at that for API ideas. Looks like you've got it covered though.

flocker/testtools/init.py, line 268 [r1] (raw file):
:grey_question: iterable of Exceptions rather than just "the exceptions" is clearer I think. Or I guess anything that can be unpacked to be arguments to Failure.check.

Comments from the review on Reviewable.io

Thanks! It will take more than that to overcome my postjudice (is that a word? is now) against mocking.  ;)

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

flocker/node/_docker.py, line 792 [r1] (raw file):
Done. That's a good analysis of TODO/XXX comments.

flocker/testtools/init.py, line 261 [r1] (raw file):
I wasn't, actually. Decorator and built-in backoff & jitter are both nice features (although I am perhaps over-fond of the iterator approach I've taken here).

flocker/testtools/init.py, line 268 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

Have re-run failing tests manually on buildbot.


bottle/github_packages: include path_exec_files.

all_files is added to the bottle JSON but not actually used by GitHubPackages yet.
Awaiting fixes for what caused the issues: https://github.com/Homebrew/homebrew-core/actions/runs/9568731423/job/26379623093
Reverts Homebrew/brew#17529

Thanks @Bo98!


Target class [App\FormFields\NumberFormField] does not exist

Version information

Laravel: v7.3.0
Voyager: v1.3.#
PHP: 7.2
Database: [type] [version] (e.g. MySQL 8.0)

Description
I do like this.
https://voyager-docs.devdojo.com/customization/adding-custom-formfields
But error:
Illuminate\Contracts\Container\BindingResolutionException
Target class [App\FormFields\NumberFormField] does not exist.

That's a basic Laravel error unlikely to be Voyager related.
Double check class name, namespace and where you put your class.

Also as far as I know only Voyager 1.4, not released yet, works with Laravel 7 and v1.3.# is not a valid version.

@MrCrayon I'm using Laravel v6.18.3 and voyager v1.3

@MrCrayon I double-checked the class name, but the error still exists.

It's OK.


Authentication error

For me i think the parameters are good configured on environment.ts fille but show to me this return message the call to the google sheet:
message: "Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project."
status: "UNAUTHENTICATED"
Any Idea what its bad configured ?

Yes, i follow all the instructions and get the api key proberly. but fail in the get
{
"error": {
"code": 403,
"message": "Requests from referer \u003cempty\u003e are blocked.",
"status": "PERMISSION_DENIED",
"details": [
{
"@type": "type.googleapis.com/google.rpc.ErrorInfo",
"reason": "API_KEY_HTTP_REFERRER_BLOCKED",
"domain": "googleapis.com",
"metadata": {
"consumer": "projects/155477220882",
"service": "sheets.googleapis.com"
}
}
]
}
}
in chrome inspector:
Failed to load resource: the server responded with a status of 401 ()
google-sheets-db.service.ts:193 Backend returned code 401, body was: [object Object]
handleError @ google-sheets-db.service.ts:193

How do the settings in the Google Cloud Platform Console for the API key look like? (https://console.cloud.google.com/apis/credentials)
In the "Application restrictions" you should either choose None or HTTP referrers (web sites) with localhost for local development and/or the URL your webapp will be deployed to:

Sure, i tried this configuration point but the same, and open to all only for test but the same too. My organizacion user profile for enterprise not allow publish for all web, only for corporate users, so i suppose by the message:
"message": "Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",
Its needed some OAuth 2 authentication to access, i'll try more to find some solutions to this.
Thanks for your help.
...with the api "try" on this link... works fine but i suppose its for getting the OAuth 2 added to the call in some way.
https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/get?apix=true&apix_params={"spreadsheetId"%3A"1loan_qtaTiF3km3Gfz6JTGORPXa-CNMBgRacY1JIZo4"}
You know how to add the validation gapi to angular in properly format to call this GSheets Api?.

The case with restrictions in enterprise accounts happens quite often.
In this case, you may try to use a private account without these restrictions.


Kotlin: Find Address sample

New sample up for the Java/Kotlin migration work, this time for Find Address sample. It follows pretty much the same pattern as the existing Java sample, and I've updated the readme to match that of the common-samples design. @hud10837 could you do a first review please? Thanks!

thanks @hud10837, that was a really helpful review. I've made those changes and some more after running Analyze -> Inspect code -> Module 'find-address'. This runs the Android linter which catches a few of the format things, a handy tip I got from Trevor! Could you take another look please?

thanks @hud10837 , @sorenoid could you do a second review please?

@TADraeseke this has already been through the review with the exception of the inclusion of a spinner which contains a list of suggested addresses. The readme will be updated as part of that larger job. Please could you take a look at the spinner code and let me know if you're happy with it? I just plonked it above the search bar!

oops, I realised the find address read me for this won't be updated since this is a brand new kotlin sample....last commit I pushed up updates the readme too :)

thanks for that @TADraeseke ! I've gone through and addressed your comments. Could you take another look please?

cool, thanks @TADraeseke! That change is made: I'll go ahead and merge.


Quiet Mode

Would it be possible to implement a quiet mode for the tool?
So that for example you could define a list of components you want to have/apply using a .yaml file or similar and then call the tool with the corresponding arguments like --quiet --config config.yaml ? That would be very nice because I would like to use the tool on a couple of servers I don't want to click trough the tool 30 times by hand :)

This is a duplicate of #130.


Upgrade to support latest versions of Ruby (3.x+) & dependencies

This issue was fixed by https://github.com/Wolfpack-Digital/apipie-postman/pull/20.


Fix CA Bundle format

Summary
Fixes #https://github.com/rancher/dashboard/issues/10725

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 you already approved this but it was reverted (I merged it in 2.9, my bad) https://github.com/rancher/dashboard/pull/11419


Unifi component fails in 0.95

Home Assistant release with the issue:
0.95.4
Last working Home Assistant release (if known):
0.94.3
Operating environment (Hass.io/Docker/Windows/etc.):
hass.io
Component/platform:
device_tracker.unifi
Description of problem:
Unifi component reports as not working for .95 upgrade:
[14:24:09] INFO: Installing Home Assistant: latest...
[14:24:09] INFO: Please be patient, this might take a few minutes...
[14:24:55] INFO: Installed Home Assistant 0.95.4
[14:24:55] INFO: Don't worry, this temporary installation is not overwriting your current one.
[14:24:55] INFO: Making a copy of your configuration for checking...
[14:25:03] INFO: Checking your configuration against this version...
[14:26:50] ERROR: The configuration check did not pass!
[14:26:50] ERROR: See the output below for more details.
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at /tmp/config
INFO:homeassistant.util.package:Attempting install of zeroconf==0.23.0
INFO:homeassistant.util.package:Attempting install of pyhusmow==0.1.1
INFO:homeassistant.util.package:Attempting install of aiohttp_cors==0.7.0
INFO:homeassistant.util.package:Attempting install of netdisco==2.6.0
INFO:homeassistant.util.package:Attempting install of hass-nabucasa==0.15
INFO:homeassistant.util.package:Attempting install of python-nest==4.1.0
INFO:homeassistant.util.package:Attempting install of PyNaCl==1.3.0
INFO:homeassistant.util.package:Attempting install of py-august==0.7.0
INFO:homeassistant.util.package:Attempting install of mutagen==1.42.0
INFO:homeassistant.util.package:Attempting install of aiofiles==0.4.0
INFO:homeassistant.util.package:Attempting install of backoff==1.8.0
INFO:homeassistant.util.package:Attempting install of packaging==19.0
INFO:homeassistant.util.package:Attempting install of distro==1.4.0
INFO:homeassistant.util.package:Attempting install of sqlalchemy==1.3.3
Failed config
General Errors:
- Platform not found: device_tracker.unifi
Successful config (partial)
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
device_tracker:
  - platform: unifi
    host: <IP_ADDRESS>
    username: readonly
    password: password
    verify_ssl: false
    consider_home: 60
    new_device_defaults:
      track_new_devices: False

Traceback (if applicable):

Additional information:

This issue was also reported by others however i didn't see any issue logged. Please let me know what other info is needed.

Have you tried disabling it during upgrade?

Same issue on Hassbian with 0.95.4! "Check config" gives:
Validate your configuration if you recently made some changes to your configuration and want to make sure that it is all valid
Configuration invalid
Platform not found: device_tracker.unifi

I've reproduced this on a clean install. Weird it doesn't happen on my dev environment.
Try stopping Hass and then starting it to see if that works. Seems to be verifying the configuration that breaks

I'm experiencing the same issue. It's hit and miss. Sometimes it integrates, sometimes it doesn't.
On an clean install with nothing else, yes it loads no problem.
As soon as you put into production with the rest of components it starts acting up.

Thinking that the Synology sensor in 0.95.x is a little flaky. I have never received a platform not found error, but having issues getting it connect to UniFi at all now. Refer https://community.home-assistant.io/t/unable-to-connect-to-unifi-controller-5-10-25-using-ha-0-95-x for the full details.

I have the same issuse as above. Unifi component was ok on 0.94.3, now is broken:
2019-07-05 23:22:01 ERROR (MainThread) [homeassistant.components.unifi] Error connecting to the UniFi controller at [IPAddressRedacted]
2019-07-05 23:22:01 ERROR (MainThread) [homeassistant.components.unifi.device_tracker] Failed to connect to Unifi:
2019-07-05 23:22:01 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform legacy

@michalterbert. Try configuring the UniFi integration through the Configuration/Integrations menu. Leave your sensors there - configure both.
I did that under the direction of one of the code owners of the UniFi integration (not sure if it was you, @Kane610 under another user id in the HA community forums), and it seems to have resolved the connection issues as far as I can tell.

I had the same issue - I confirm that adding it through the Configuration/Integrations menu solves the issue.

I had the same issue - I confirm that adding it through the Configuration/Integrations menu solves the issue.

Only once I did this did the log say it was installing requirements. Not sure if that is a manifest parsing bug, or another clue.

The Integration page workaround addresses the Unifi component however if I read the documentation correctly the device tracker part is not covered in the unifi component configured through the integrations page.

For the device tracker you can use the workaround of disabling the config and running the upgrade without the unifi device tracker enabled. Once upgraded to 95.x you can re-enable the unifi device tracker and everything seems to be working.

What do those who already upgraded and don't have a backup do?

@alterego-SWI you should be able to just disable the device tracker config part. Then the system should boot without issue. Once done you can re-enable. Mine upgraded fine without the config in there at time of upgrade after I could just re-enable and everything worked fine.


luci-mod-network: wireless SAE MFP bug

selecting WPA3 and optional or require MFP setting works as expected, setting MFP to disabled removes config entry for MFP and luci reverts it to required. from what i read it should be possible to use SAE without MFP.
OpenWrt SNAPSHOT r11895-fba8083 / LuCI Master git-20.004.64129-d60a1a1

LuCI follows the OpenWrt implementation here: https://github.com/openwrt/openwrt/blob/master/package/network/services/hostapd/files/hostapd.sh#L328
Currently neither SAE, nor SAE-PSK (mixed) allow disabling MFP.


Custom template is using component styles instead of my styles

Vue2-dropzone Version: 2.3.5 (npm list --depth=0)
Node Version (node -v): v8.2.0
NPM Version (npm -v): v5.3.0
OS: macOS Sierra 10.12.16

Description:
Currently using vue-dropzone with a custom template as per the example in docs. I've written my own styles however they seem to be getting overwritten by the component itself.
Steps To Reproduce:
Just follow the Custom Dropzone preview template example and try to use custom styles for e.g the dz-error-mark which has a color: white !important set on it. I can provide a more detailed example but my issue is fairly explanatory. I understand this may not be an issue if so could you point me in the right direction to overwrite the base styles when using a custom template.
Thanks for the package its really nice!

Try setting something like
.dz-error-mark i {
   color: red
}

You might also be able to pass in your id selector of the component to add more specificity. Let me know how you get on.

@Esslamb I can confirm that, as specified in docs which you mentioned can't override the css!
Meanwhile you can try approach suggested @rowanwins.
I'm on it and I'll update the example! Thanks for pointing it!

I had already tried that @rowanwins but the  element has an !important color attached to it so unless I update the package files I'm unable to overwrite regardless of what css styles I use on my end. The alternative would be to use my own css selectors but then I miss out on the cool fade in animations and opacity functionality.
Thanks for the update @vrajroham. If I could make a suggestion, perhaps allowing the user to have some kind of toggle to turn off styles or make some hooks available for the selectors that have animations attached to them such as the icons. I understand these things can be tedious, I will pull the project tonight and see if I can figure something out to give you guys a hand.

Hi @Esslamb
Thanks for the feedback and offer to help. In v3 we'll do away with all the !important selectors so it should be much easier, there will also be a no styles option as well.

Hi @Esslamb
V3 is now published with brand new docs including how to override styling (it's now much easier!)

This is awesome @rowanwins well done!


ERRO when getText() (IOS Only)

Hi @xrb21 . have problem when getText() in ios platform

Same issue here,
_keyEditor.currentState.getText() dont work in ios, only in Android works.

I have the same question.
I tested it on ios 12,13 and 14. After the plugin finishes rederring, it will throw exception in all ios system(12,13 and 14), but it can work.
[VERBOSE-2:ui_dart_state.cc(177)] Unhandled Exception: PlatformException(evaluateJavaScript_failed, Failed evaluating JavaScript, JavaScript string was: '$(".note-placeholder").html("请填写回复内容");'
Error Domain=WKErrorDomain Code=5 "JavaScript execution returned a result of an unsupported type" UserInfo={NSLocalizedDescription=JavaScript execution returned a result of an unsupported type}, null)
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:582:7)
#1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18)
<asynchronous suspension>
#2      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:332:12)
#3      MethodChannelWebViewPlatform.evaluateJavascript (package:webview_flutter/src/webview_method_channel.dart:115:21)
#4      WebViewController.evaluateJavascript (package:webview_flutter/webview_flutter.dart:672:39)
#5      HtmlEditorState.setHint (package:html_editor/html_editor.dar<…>

When I call getText() after input some content, ios 14 will throw exception, but ios 12 and 13 will work without exception.
[VERBOSE-2:ui_dart_state.cc(177)] Unhandled Exception: PlatformException(evaluateJavaScript_failed, Failed evaluating JavaScript, JavaScript string was: 'GetTextSummernote.postMessage(document.getElementsByClassName('note-editable')[0].innerHTML);'
Error Domain=WKErrorDomain Code=5 "JavaScript execution returned a result of an unsupported type" UserInfo={NSLocalizedDescription=JavaScript execution returned a result of an unsupported type}, null)
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:582:7)
#1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18)
<asynchronous suspension>
#2      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:332:12)
#3      MethodChannelWebViewPlatform.evaluateJavascript (package:webview_flutter/src/webview_method_channel.dart:115:21)
#4      WebViewController.evaluateJavascript (package:webview_flutter/webview_flutter.dart:672:39)
#5      HtmlEditorState.getT<…>

I found a solution. Download the source and modify the html_editor.dart
add setTimeout() to getText() and setHint():
Future<String> getText() async {
    String content = await _controller.evaluateJavascript(
        "setTimeout(function(){GetTextSummernote.postMessage(document.getElementsByClassName('note-editable')[0].innerHTML)}, 0);");
    return text;
  }

setHint(String text) {
    String hint = '\$(".note-placeholder").html("$text");';
    _controller.evaluateJavascript("setTimeout(function(){$hint}, 0);");
  }

And then there is a problem, the getText() will return null in the first time. We can get text from getTextJavascriptChannel() after called getText().
Add a function for HtmlEditor:
final Function(String) returnContent;
HtmlEditor(
      {Key key,
      this.value,
      this.height = 380,
      this.decoration,
      this.useBottomSheet = true,
      this.widthImage = "100%",
      this.showBottomToolbar = true,
      this.hint, this.returnContent})
      : super(key: key);

And then call this function in getTextJavascriptChannel():
avascriptChannel getTextJavascriptChannel(BuildContext context) {
    return JavascriptChannel(
        name: 'GetTextSummernote',
        onMessageReceived: (JavascriptMessage message) {
          String isi = message.message;
          if (isi.isEmpty ||
              isi == "

" ||
              isi == "

" ||
              isi == "

") {
            isi = "";
          }
          setState(() {
            text = isi;
          });
          // call returnContent
          if(widget.returnContent != null) {
            widget.returnContent(text);
          }
        });
  }

Finally, add function for HtmlEditor when you use it，and call keyEditor.currentState.getText() when you want the content.
HtmlEditor(
    hint: Strings.content,
    key: keyEditor,
    returnContent: _submitContent )

_submitContent(String content) {
   // do something
  }

Any fix possible without setTimeout?

Did anyone find a fix for this issue?


Support Android Library Projects

Summary
There have been many solutions proposed to support using Butterknife in Android Libraries i.e non-final IDs in R. This approach uses a combination of Gradle Plugin + Annotation Processing + Custom Lint to ensure this is done as safely as possible with minimal configuration.
Usage

Apply gradle plugin to the library project.

apply plugin: 'butterknife'

The plugin generates an R2 class which is essentially a copy of R with final values and the correct support annotations.

Specify the R class for the library using the @Rclass annotation, just once, anywhere in code. Use R2 instead of R in all butterknife annotations.

package butterknife.library;

import android.view.View;
import butterknife.BindView;
import butterknife.OnClick;
import butterknife.RClass;

@RClass(R.class)
class Foo {

  @BindView(R2.id.footer) View bar;

  @OnClick(R2.id.hello) void sayHello() { }
}

The @Rclass annotation is used by the annotation processor to map the integer ids to symbols in R. This in turn generates code like
target.bar = finder.findRequiredView(source, com.example.butterknife.library.R.id.footer, "field 'bar'");
view = finder.findRequiredView(source, com.example.butterknife.library.R.id.hello, "method 'sayHello'");

in the ViewBinder. This ensures that the final values used for the R values will be generated by the app consuming the library.

If R2 is being used outside butterknife annotations, a custom lint rule will throw an error

This is important because values in R2 are final and would be inlined as constants somewhere other than in the ButterKnife annotations.
Profit!

Pros

Api invisible to consumers of the library. R2 is not packaged into the aar just like R.
Full compile time safety. No referring to R values using strings.
Migrating existing library projects to take advantage of this approach is very simple.
No changes to the butterknife annotation APIs.
Backward compatible with existing app projects that use butterknife. In fact, just adding @RClass will output human friendly generated code in existing app projects.
Forward compatible with Butterknife extensions (#573) as the approach makes no assumptions about listener classes.
Other build systems like buck and bazel can generate their equivalent of R2 very easily by implementing the logic on their own or by just reusing FinalRClassBuilder (written entirely in java) from the gradle plugin module.

Cons

When performing rename refactors of R values in the Android Studio/IntelliJ, they are kept in sync with the layout files etc. automatically by the IDE, but R2 is only generated after the gradle task that generates R. To keep R and R2 in sync, the rename would need to be done twice once for R and immediately in R2. Without doing so, compilation would fail. This problem can be fixed easily by writing a custom intellij plugin that links the values in R2 and R, similar to how the values in R are linked to the layout xml files etc. This can be a future enhancement.

Wish the processor could have extracted the fully qualified names by itself so the plugin wasn't necessary for that, but can't have it all :). Awesome work

This solution is similar as Butterfork.
Users have to replace R by R2/B.
I found a better solution ButterCookie. Using ButterCookie, you don't need to change any existing code with Butterknife in Library project.

I found a better solution ButterCookie. Using ButterCookie, you don't need to change any existing code with Butterknife in Library project.

I have looked at ButterCookie, but here are some issues I noticed with it

Relies very heavily on what annotations are supported by Butterknife in its plugin class and the format of the generated code. This will break with butterknife extensions and new binding/listener annotations added to butterknife itself.
Manipulates the variant.javaCompiler dsl which will not work with jack.
Does reflection on the internal private APIs of the android gradle plugin and is very easily prone to breakage with android plugin updates.
Relies on the internal implementation details of the apt plugin

It would need to keep up with every possible combination of changes in butterknife/the android gradle plugin/apt plugin and would become very hard to maintain.

This solution is similar as Butterfork.
Users have to replace R by R2/B.

This is slightly different than Butterfork because

It generates an R2 class with integers instead of strings. This makes the IDE refactor friendlier than Butterfork, as there is no need to do a full recompile when renaming R values.
Butterfork lacks the type safety ensured by using support annotations like @IdRes, @StringRes etc (which are part of butterknife) to make sure the integer you are passing to the annotation is of the correct type. The R2 class comes with the correct annotations on all the generated fields, so this issue does not exist in this approach.
It also gives safety in the form of custom lint checks to make sure you do not use R2 in places not intended.
ButterFork would need to keep in sync with butterknife always, which can get hard to maintain

@kageiit Fully agreed on the points about Butterfork, I will deprecate it as soon as this gets merged. Great work! 👍

Would it be possible to do something like this to generate R2 using ButterKnifeProcessor instead of a Gradle plugin?
AnnotationMirror rClassAnnotationMirror = getRClassAnnotationMirror();
Element rClass =
    (TypeMirror)
        AnnotationMirrors.getAnnotationValue(rClassAnnotationMirror, "value").getValue();
List<RInnerClass> rInnerClasses = new ArrayList<>();
for (Element element : rClass.asElement().getEnclosedElements()) {
  Name rInnerClassName = element.getSimpleName();
  List<? extends Element> rInnerClassFields = element.getEnclosedElements();
  rInnerClasses.add(new RInnerClass(rInnerClassName, rInnerClassFields));
}
// Use rInnerClasses to generate R2.

(See #591 for how getRClassAnnotationMirror could be implemented.)
I'm fairly new to Java processors, so I may be missing something, but if this is possible it would be preferable to the Gradle plugin.

Also, instead of annotating a random type with @RClass, it might make more sense to make it target packages and use package-info.java.
e.g.
@RClass(R.class)
package my.android.library;

would generate my.android.library.R2.

@grahamrogers I spent a lot of time trying to generate R2 using during the annotation processor rounds. The problem lies since R2 does not exist, The processor would need to defer processing on all the butterknife annotated elements to the next round. But then, the type mirror of R2.id.value etc would have changed on the next round, so the int value cannot be extracted easily by querying the value parameters on the butterknife annotations.
This also makes the logic inside the processor needlessly complex as it would have to handle the cases when the RClass annotation exists and not. Would be hard to maintain as butterknife evolves as well.
I settled on this approach as a nice balance between ease of use, a clean api and maintainability.
The location of where to out the RClass does not matter, but the import to R does not exist yet if it's on top of a package element. One would then have to use the fully qualified name. I would prefer to have it look terse instead. The decision of where to put the RClass annotation can be left to the consumer.

For the Bazel case, since there is one Android library per package annotating the package would make sense for that case since the annotated package would be the same as the package used for R and R2. It's only a minor detail, but adding PACKAGE as a Target for RClass would at least give people the option and wouldn't change the implementation.
You raise good points about using code generation for R2, although I would question whether they outweigh having to maintain a plugin for each supported build system. I don't think there's a right answer, so plugins are fine for me (as long as a Bazel one is made :stuck_out_tongue:).

Not a big fan about adding a package target for RClass. The package for R2 is decided by the plugin of the build system so you could just put that detail in bazel to allow it. The same goes for buck.
The build systems are responsible for generating R. They should be able to generate R2 as well. I don't think a plugin will be provided out of the box for buck/bazel in butterknife. I'm planning to add first party support for R2 in buck after this merges. You may need to propose the same in bazel for your use case.

I think the effort of having to use RClass in conjunction with the plugin is minimal. In buck, we just need to add an option for generating R2 and the rest will work the same. Modifying the annotation options as part of buck itself just to support usage of butterknife is not ideal.
The same goes for bazel. This way, there is no need to wait on android-tools for this support, since that will be purely be scoped to only gradle users. Once that support is available, we can make the usage of R2 optional as well for gradle users by enhancing the plugin.

We should also not rely on variant.javacompile dsl as that is not compatible with Jack. The android apt plugin currently does not work when Jack is enabled due to the same reason.

Also, if we go down the approach of "generating a file with information", anytime that file format changes, all build systems would need to fix their logic based on the version of butterknife they depend on which is not desirable. This decouples the logic and is single responsibility for the annotation and the plugin.

First IDE import is problematic:
Error:Could not find com.jakewharton:butterknife-gradle-plugin:8.1.1-SNAPSHOT.
Searched in the following locations:
    file:/Applications/Android Studio 2.2.app/Contents/gradle/m2repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/maven-metadata.xml
    file:/Applications/Android Studio 2.2.app/Contents/gradle/m2repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.pom
    file:/Applications/Android Studio 2.2.app/Contents/gradle/m2repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.jar
    https://repo1.maven.org/maven2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/maven-metadata.xml
    https://repo1.maven.org/maven2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.pom
    https://repo1.maven.org/maven2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.jar
    https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/maven-metadata.xml
    https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.pom
    https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.jar
    file:/Users/jw/.m2/repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/maven-metadata.xml
    file:/Users/jw/.m2/repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.pom
    file:/Users/jw/.m2/repository/com/jakewharton/butterknife-gradle-plugin/8.1.1-SNAPSHOT/butterknife-gradle-plugin-8.1.1-SNAPSHOT.jar
Required by:
    com.jakewharton:butterknife-sample-lib:8.1.1-SNAPSHOT

The one thing we do in other projects is keep the samples on the release version and only update them after a new release. I'll probably do that here too once the version with this is released.

merged as 20aad6c46eb2d4ffd06c19f0781e71df49c0b173

Buck support here: https://github.com/facebook/buck/pull/789


more complex case

@rultor release, tag is 0.0.3

@rultor release, tag is 0.0.3

@yegor256 Done! FYI, the full log is here (took me 3min)


testserver: reset job problems between requests

I thought I'd done this but obviously forgot to merge the PR. These changes are now included with #31


Revert "@damassi => [Artist] Use meta tags and structured data from Reaction" and upgrade reaction

Reverts https://github.com/artsy/force/pull/4650
Upgrades reaction to get this revert: https://github.com/artsy/reaction/pull/2929

To fix structured data errors. Discussion here

Warnings

:warning:

Please don't include .js files, we want to be using TypeScript found: Meta.js and Meta.jest.js.

  Generated by :no_entry_sign: dangerJS against 98db0c4d489c6033f1372c538d3a9bf8dcb4b24b

🙏


license

I want to publish this on the AUR, can you add a license?

Done, MIT License is added.

thanks: https://aur.archlinux.org/packages/sweep-rs-git


Unable to add an image/icon to Select options

Hi! I'm new to mantine components for Dash in Python, and I'm trying to use the Select component to show different options with an icon in the left, as I previously did with the component Dropdown of dash components.

I have decided to use the Select component of dash-mantine in order to separate the select options by categories, the only problem is that, when I try to set the option's label to an Image component, it returns an error.
This is the code I've created. As it is shown, the label instead of only being a string, is a Div component that includes the image I want to show side by side the value of the option.
                     dmc.Select(
                        label="Select framework",
                        placeholder="Select one",
                        id="framework-select",
                        value="ng",
                        data=[
                            {
                                "value": "react",
                                "label": html.Div(
                                    [
                                        html.Img(
                                            src="assets/tasks-list/Penguin.png",
                                            height=20,
                                        ),
                                    ]
                                ),
                            },
                            {
                                "value": "svelte",
                                "label": html.Div(
                                    [
                                        html.Img(
                                            src="assets/tasks-list/Penguin.png",
                                            height=20,
                                        ),
                                    ]
                                ),
                            },
                        ],
                        style={"width": 200, "marginBottom": 10},
                    ),
                    dmc.Text(id="selected-value"),

This is how the Select component looks:

Although, when I click on the Select component an error is thrown in the inspector console. This is the error:

My question here is: is it possible to have an image side by side with the text value on the select component options?
Thanks in advance for any response 😉

This won't be part of the main dmc library. I think a better place for them is a separate library, maybe called dmc-extra-components, though I won't be working on it - open to the community.


Obfuscated code in your source !

Please remove the obfuscated code by a publicly review-able version, we don't want or need malware in a library like this...

Until then i would not advise anyone to use your code...or at least urge them to edit the file and removing the obfuscated code before usage...

It is base64 encoded character data.
I think it is review-able at createStringToBytes function.
  /**
   * @param unicodeData base64 string of byte array.
   * [16bit Unicode],[16bit Bytes], ...
   * @param numChars
   */
  qrcode.createStringToBytes = function(unicodeData, numChars) {

    // create conversion map.
    ...
    ...

Yes, Unicode-SJIS conversion requires a large data table.
(2(Utf-16) + 2(SJIS)) x 7070(chars) * 1.33(b64) = 37K
So I defined it in base64.
If defined with native array or object map, it would be more large.

Still is better to have a larger map that is readable by anyone without need to decode...
Plus move the SJIS-code back into its own file, to leave the main file small...

@kazuhikoarase We need to be able to audit this code to ensure it doesn't contain malware.  How may we do so?

You could confirm how endoded string is extracted.
line 556~575
Also you see extracted is a map named 'unicodeMap' and not a malware.

I think it would be better to keep the original plain text version in github, make a build script and publish a pre-build version in NPM. Does it possible?

I couldn't understand why my code was possible to be a malware. I think there are no difference between raw array and base64 string in security issue. But okay, I moved back it to separate file.

@kazuhikoarase , why are you resisting to put your SJIS-code in UN-obfuscated form on github?
Resisting to do so makes people suspicious...
In case of programming code when there is the slightest suspicion it is best to AVOID that code in its total.
So you have 2 options:

Publish your SJIS-code in UN-obfuscated form on github, then everyone will be willing to use your code.
Keep your SJIS-code in obfuscated form on github, then only a handful of people will use your code because they don't care about anything.

It's not executed - it's effectively binary data. It's common to include binary data in a format that's suitable for the language being used.

@marksteward , I agree. It is a point of view that the pre-build / minified / "binary" files should include in Github repository. There is no right way in real world. For examples:

No "binary" in source repository and it publish in other distribution channels (cdn, github release, npm). You cannot use a hotlink (rawgit.com ?) to include the library in webpage.
Examples:
https://github.com/facebook/react
https://github.com/jquery/jquery

Include "binary" in source repository and other distribution channels (cdn, github release, npm). The library can be include the library in webpage with hotlink approach.
Examples:
https://github.com/twbs/bootstrap ( https://github.com/twbs/bootstrap/tree/v4-dev/dist/js )
https://github.com/zingchart/zingtouch ( https://github.com/zingchart/zingtouch/tree/master/dist )

@marksteward
It's common to include binary data in a format that's suitable for the language being used.

Since when is it common to include binary "data" in sources of javascript?
Especially when that "binary data" is being parsed (eg. executed) by the javascript engine?

I think there's a misunderstanding here. Can you link to the line where it's executed?

The javascript code decodes his SJIS before running the decoded code right?
How else would that code be used by the javascript engine....
Even a code that decodes into "a = [1,2,3]" or even plain "[1,2,3]" that is then parsed in the normal code as "a=[1,2,3]" is being executed...

It seems you have not read my code.

The javascript code decodes his SJIS before running the decoded code right?

Not quite.
(1) the plugin calls createStringToBytes, passing its base64-encoded table of mappings:
qrcode.createStringToBytes('AAAAAABAAEAAgAC.../+OBUP/lgY8=', 7070)

(2) createStringToBytes initially decodes this from base64, returning a stream that looks like this:
<\0\0\0\0\1\0\1\0\2\0\2...\xff\xe3\x81\x50\xff\xe5\x81\x8f>

(3) It then processes the stream into a map, which relates Unicode characters to their Shift-JIS equivalents:
Object {'\0': 0, '\1': 1, '\2': 2, ..., '￣': 33104, '￥': 33167}

(4) Finally, createStringToBytes returns a function that looks up Unicode codepoints in this map, and outputs the corresponding single-byte or double-byte characters. This function replaces qrcode.stringToBytes.
At no point is the data executed - mathematical operations are performed to convert from the encoded format into the keys and values in the mapping.
I agree with @hermanho that it might be nice to include the source object and script used to generate the base64 data, but this is of limited use as this code will not change often.
Your approach in this ticket and #34 is the sort that can put people off open source software. You're relying on the good will of people usually working in their free time - it's not helpful to say "we don't want or need malware" and "you have 3 options".

I agree with @hermanho that it might be nice to include the source object and script used to generate the base64 data, but this is of limited use as this code will not change often.

I agree too. I had written a short code and pushed it. (But no one need to generate again.)
https://github.com/kazuhikoarase/qrcode-generator/tree/master/js/misc

@marksteward
Your approach in this ticket and #34 is the sort that can put people off open source software. You're relying on the good will of people usually working in their free time - it's not helpful to say "we don't want or need malware" and "you have 3 options".

It doesn't matter because we have to rely on word of mouth and "trust" explanations instead of actually being able to confirm whats going on.
I still stand by my point that obfuscated code has no place on github, be it base64 encoded "unicode" or "zipped data/code"
I and others objecting to things on "github and a like" are also people working in their free time...
If a programmer is unable to provide transparent code and gets discouraged by comments like mine then that is actually for the better of the community...

Reading through the comments, I'm trying to understand if the code is verifiable and has been verified to not contain malware.  Is it?  I'd like to use this in my own project, but I cannot if the code is not 100% verifiable because it will be handling user funds.  Thanks in advance.

Just following up.  I think it is fine if the source code contains base64 or other encoded data as long as the steps to create the data can be verified and/or it can be verified that the data is not executable.  @marksteward listed steps of how the base64 encoded data is processed (thank you!).  Can we similarly get instructions to recreate the encoded data starting from an unencoded version?  I ask only because people need to be able to audit the code that they run, especially in a financial application like mine.  Any verifiable assurance that the code cannot be malicious is appreciated.  Thank you!

I added this one. Would this help you?
https://github.com/kazuhikoarase/qrcode-generator/tree/master/js/misc

It doesn't matter because we have to rely on word of mouth and "trust" explanations instead of actually being able to confirm whats going on.

@TriMoon No, you don’t have to rely on word of mouth. Read the source code about how the data is used, like what @marksteward did. I don’t think that meets the definition of “execution”.
In addition, before you know for sure that it is executed, it is misleading to call it “obfuscated code”. It should at most be called “suspicious data” (that may contain anything, including obfuscated code). Similarly you won’t call a suspect “murderer” on a court. Please bring down emotion as much as possible.

It doesn't matter because we have to rely on word of mouth and "trust" explanations instead of actually being able to confirm whats going on.

@TriMoon No, you don’t have to rely on word of mouth. Read the source code about how the data is used, like what @marksteward did. I don’t think that meets the definition of “execution”.
In addition, before you know for sure that it is executed, it is misleading to call it “obfuscated code”. It should at most be called “suspicious data” (that may contain anything, including obfuscated code). Similarly you won’t call a suspect “murderer” on a court. Please bring down emotion as much as possible.


Add String Interpolation to documentation

Changes

Adds basic string interpolation documentation. It's my first time writing new content to the documentation.
Question: Does the script parser support string interpolation?

Checks
By submitting your pull request for review, you agree to the following:

[X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[X] To the best of my knowledge, all proposed changes are accurate.

Thanks for the suggestions. I guess placeholders are too complicated. Moved it up to after the Escaping Strings category.
I added an example of standard formatting rules that uses both backticks and curly braces and prints to the new examples. I hope the formatting team loves that example. (GitHub.Dev doesn't format it right)

Hi @idontyboi, looks great -- terrific stuff. Thanks a bunch for contributing!


Spooler fails if message is too long

In SpoolerTask, when message is too long, args and kwargs parameters are passed in body parameter, which is ok.
if len(repr(message_dict)) >= UWSGI_MAXIMUM_MESSAGE_SIZE:
   # message too long for spooler - we have to use `body` parameter
   message_dict = base_message_dict
   message_dict['body'] = pickle.dumps({
      'args': self.args,
      'kwargs': self.kwargs,
})

The problem is that the message is not cleaned from original args/kwargs params (message_dict['args'] and message_dict['kwargs']), and in the result these are not encoded and passed to uwsgi.spool function.
In the end uwsgi.spool fails with

ValueError: spooler callable dictionary must contains only bytes.

Thank you for reporting the issue, but I don't see any problem here actually:
# here we are making copy of base_message_dict, so when we change message_dict this
# do not affect base_message_dict at all, so base_message_dict does not contain args and kwargs
message_dict = base_message_dict.copy()
message_dict.update({
    'args': pickle.dumps(self.args),
    'kwargs': pickle.dumps(self.kwargs)
})

# in case of huge args/kwargs size we reuse base_message_dict,
# which does not contain args,kwargs as show above.
if len(repr(message_dict)) >= UWSGI_MAXIMUM_MESSAGE_SIZE:
    # message too long for spooler - we have to use `body` parameter
    message_dict = base_message_dict
    message_dict['body'] = pickle.dumps({
        'args': self.args,
        'kwargs': self.kwargs,
    })

And as I can see message_dict is totally replaced in the lines above.
Could you please clarify where is my reasoning incorrect?

It actually does contain unpickled args and kwargs from the beginning:
    def get_message_content(self):
        base_message_dict = self.__getstate__()
        (...)

    def __getstate__(self):
        return {
            'function_name': self.function_name,
            'args': self.args,
            'kwargs': self.kwargs,
            'setup': self.setup,
        }

In a pull request that I posted a while back (#8), I've proposed the fix that was simplest for me to prepare, but maybe it would be a good idea to do some larger changes so the flow is easier to read.
There is also a regression test that fails without the rest of the changes.

I'm running into this same error when message_dict is larger than 64kb.

@miszczu @almussel thank you, I have release a new version on pypi (0.7.2), so feel free to use it.
But I'm still curious why do you use so huge messages?

Closed because of inactivity.


PLUS_LOGIN scope unconsistent behaviour

Hi,
as mentioned in documentation, Google_Service_Plus::PLUS_LOGIN scope fetches 3 things viz.

connections in circles,
age range
languages
internally it also fetches USERINFO_PROFILE scope which is basic info of User.

when trying this in Google REST API Explorer, adding only plus_login I am able to fetch G+ connections, but however in my application I am not able to fetch G+ connection. tried same thing on Google OauthPlayGround with Plus_login scope, and over there also it didnt fetch G+ connections.
however I had this feature working fine till 13/10/2016. is there any change in google-api-php-client or scope or service ??

The APIs are changing all the time to reflect those changes the autogenerated client-services are regenerated.
Did this behavior start after a composer update?

Thank you for filing this issue. We asked some clarifying questions or suggested a course of action a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to comment with more information and we will re-open this issue.


HDMI Quality

Hello! I noticed that the HDMI output quality decreased considerably compared to the stock OS.
I was using ADB to change the 353v resolution to 1280x720, and the TV did show my screen in 720p with the stock OS, however with GamaOS it seems that the image has a lower bitrate, I presume? or maybe it is capped to 480p somehow, which the stock OS was not.
Similarly to the Stock OS, it also squeezes the output, leaving some horizontal bars, even when the screen resolution is 16:9.

When I played arcade games + HDMI to TV setup, there's a noticeable lag/delay between what is shown in the TV vs device.


Toggle toolbar issue

When I click the button to hide the toolbar, it doesn't active and it cover the hide button up.

Thanks for create this great plugin.

you are using any extension that changes the Toolbar?

Thanks for you advice. I try to disable some extension and it's working now.

:+1:

It's HTML Designer for Brackets.

Yes.. confirmed. HTML Designer for Brackets

update and comment please


Only use the default email when name is empty

I've also added angle-bracket email stripping which is also related to the issue. Tests are modified so they pass.
See https://github.com/gollum/gollum/issues/954.

Many thanks!

My pleasure :)


Patch to make alacritty work on gru-kevin-coreboot rk3399 w/ Mali860 GPU under sway

Which operating system does the issue occur on? Linux
If on linux, are you using X11 or Wayland? Wayland
Are you including a patch that fixes the issue? Why yes in fact I am glad you asked
Hi, after much suffering I managed to get alacritty (under sway)
working on the Samsung Chromebook Plus (aka gru-kevin) using its the
Mali 860 GPU, which is OpenGLES 3.2-only, so I had to backport the
shaders.  The new ones work on GLES 3.0 and later.
Below are the patches to alacritty.
There are four patches:

glutin-0.21.0-alacritty-rk3399-patch.txt is a patch to
glutin-0.21.0.    Maybe glutin could
offer an environment variable to override the advertised GLES
support level reported by the driver in cases like this?

0001-use-kludged-version-of-glutin-0.21.0.patch is a patch to
alacritty to use an in-tree local version of glutin with the
patch above.

0003-shader-hacks.patch backports the shaders to OpenGL ES 3.0.
I really wish the theory of operation on the shaders was
better-documented in the code; I still can't figure out what a
"rect shader" does or why on earth the text shader uses
multisample blending.  Ultimately I just started poking at things
until I found a combination that works, but I don't understand
why it works.  Please document the meaning of the two shader
outputs and why they are separate (color+alpha) instead of a
single vec4.

When you run alacritty under sway on rk3399 hardware each
individual character will render upside-down.  If you use weston
on rk3399 this doesn't happen.  If you use sway on ATI/AMD this
doesn't happen.  It's a very weird bug.  I don't know what's
going on here, but 0002-vertical-flip-hack-for-mali-opengl.patch
clobbers it into working by simply flipping each character again.
Don't ask me why this is needed, I don't understand it either.

I found that alacritty will freeze up randomly unless sway is launched
with -Dnoatomic. Unfortunately the libMali blob is very, very
unforgiving, and the freezing is due to it crapping all over the call
stack when it gets in a bad mood.
Performance is excellent.  Without GPU support alacritty is unusable on this hardware; with it alacritty-wayland is, by far, the fastest terminal emulator for the rk3399.  However startup time is still annoyingly long, several hundred milliseconds to perhaps even half a second.  Is there some way for a single alacritty process to be shared by all the terminal windows a user opens, like Terminal.app and urxvt?  Rust binaries are fast but monomorphization makes them big; part of the (wise) tradeoff chosen by Rust and MLton means their binaries will always start a bit slower in order to run much much faster.
The patches to sway can be found in this issue: https://github.com/swaywm/wlroots/issues/1812
glutin-0.21.0-alacritty-rk3399-patch.txt
0001-use-kludged-version-of-glutin-0.21.0.patch.txt
0002-vertical-flip-hack-for-mali-opengl.patch.txt
0003-shader-hacks.patch.txt

First of all, thanks a lot for looking into this. I'll try to address all the points you've made, but if I miss something, please let me know.
General

For some reason glutin misinterprets libMali's advertisement of what GLES versions it supports

This would probably be best reported to glutin directly, but I'm curious why your patch and solution aim to override the support response instead of fixing what glutin does wrong. You said that "glutin misinterprets libMali's advertisement of what GLES versions it supports", which sounds like something that should be fixable, without requiring a workaround, right?

When you run alacritty under sway on rk3399 hardware each individual character will render upside-down

This sounds like an extremely strange bug, but if weston works and sway does not, maybe this is something that needs to be fixed in the compositor?

Is there some way for a single alacritty process to be shared by all the terminal windows a user opens, like Terminal.app and urxvt

This is tracked in issues like https://github.com/jwilm/alacritty/issues/607 or https://github.com/jwilm/alacritty/issues/241.
It should be noted though that often the first start takes more time than all following initializations because of what seems to be driver initialization, though more research could certainly be done in that area (see https://github.com/jwilm/alacritty/issues/2303 and https://github.com/jwilm/alacritty/issues/782). I don't think we can blame Rust for this one since drivers/OpenGL might have a significant impact here.
OpenGL Shaders
I'd like to go into a bit more detail here since I think the work on the OpenGL shaders could potentially be upstreamed. There has been a long standing issue (https://github.com/jwilm/alacritty/issues/128) about supporting lower OpenGL versions and I think it might be very beneficial to support at least a few more years of old GPUs. That should hopefully help with bringing Alacritty to a few more people out there and reduce the barrier that OpenGL imposes.

I still can't figure out what a "rect shader" does

The rect shader is used for drawing rectangles like the message bar background, underlines, strikeout and the visual bell.

why on earth the text shader uses multisample blending

I did not write this code so I can only take guesses why multisampling is enabled. But I'd assume that this was done to improve glyph outlines. However in my testing I can't make out any concrete differences. Why is this relevant to your changes though?
The commit which introduced this (eac9747a78fb3fe2eb6563ea95c2847eb0ec9f0a) doesn't shed a lot of light on things, though it's very very old.

why they are separate (color+alpha) instead of a single vec4

Are you talking about the alphaMask output of the text fragment shader?
This is the original commit message:

Correct sub-pixel font rendering with OpenGL
Uses the GL_ARB_blend_func_extended to get single-pass, per-channel alpha blending. gl_generator is now used instead of gl to enable the extension.
The background color is removed since that presumably needs to run in a separate pass.

I'm not very familiar with OpenGL myself and haven't written this code, but it seems like this separate alpha blend mask is necessary for the OpenGL blend function extension in use by Alacritty.
If you take a look at c70acbac0b721ea2f1b1442898c22aee0f360ef2, you'll see that previously something more similar to what you might have expected is used, however here you can see that the alpha value is constant and it's blended in the shader. It seems like what we currently have allows us to have a blend map with a custom blend factor for each individual channel.
If the goal is purely to share these patches, I think this issue can be closed. However I'm very open to upstream as many things as possible for improved platform support as long as it doesn't significantly impact existing systems.
I think support for earlier OpenGL and GLSL versions should be tracked in https://github.com/jwilm/alacritty/issues/128 though, so all further comments on that are likely better posted on this more specific issue.

You said that "glutin misinterprets libMali's advertisement of what GLES versions it supports"

Good point, you're right.  I will figure out why glutin is parsing libMali's response as None instead of Some(3,2) and submit a patch to glutin.

When you run alacritty under sway on rk3399 hardware each individual character will render upside-down

if weston works and sway does not, maybe this is something that needs to be fixed in the compositor?

Quite possible.  To be clear I did not mean to assign blame on this issue.  The behavior is strange enough that fault could lie with any of the participants!  I just wanted to document what I'd noticed.

If the goal is purely to share these patches, I think this issue can be closed.

Ok, no problem, you can close this issue.

I think support for earlier OpenGL and GLSL versions should be tracked in #128 though, so all further comments on that are likely better posted on this more specific issue.

I will post the rest of my reply there.

Oh, just an idea to increase visibility, you could also document this in the wiki, however I'm not quite sure how much sense that makes in the current state of patches required.


Remove python 37

https://app.shortcut.com/galileo/story/6981/dq-remove-support-for-python-3-7
Additional context: https://galileoteamworkspace.slack.com/archives/C02NSBN4ZK3/p1690213086742379
From https://www.python.org/downloads/release/python-3717/
Note: The release you are looking at is Python 3.7.17, the final security bugfix release for the legacy 3.7 series which has now reached end-of-life and is no longer supported. See the downloads page for currently supported versions of Python.

Codecov Report

Merging #733 (07484db) into main (f9f0b76) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   89.72%   89.69%   -0.04%
==========================================
  Files         168      168
  Lines       13608    13594      -14
==========================================
- Hits        12210    12193      -17
- Misses       1398     1401       +3

Files Changed
Coverage Δ

tests/test_dataquality.py
100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Will hold off merging until 8/8/23 after @setu4993 has had a chance to review :)

@setu4993 👍 done