Update to Go 1.19

Please specify the area for this PR
What does does this PR do / why we need it:
Updates registry-library to Go 1.19 with dependency updates.
Which issue(s) this PR fixes:
Fixes #?
https://github.com/devfile/api/issues/1469
PR acceptance criteria:

[ ] Test Coverage

Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

[ ] Does the REST API doc need to be updated with your changes?
[ ] Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

/hold
Need to verify dependents.

Stale branch, refer to #212 for further updates on this.


Use ps1 extension for pwsh shebangs

As of PowerShell/PowerShell#15859, which is in PowerShell Core 7.2, pwsh.exe requires a ps1 extension for -File arguments on Windows. This "works on my (Win 10) machine" but I know very little about PowerShell and even less about Rust. Not sure if it's worth trying to make Just's behavior here Windows-specific.

Looks good to me! Could you add a test? No worries if not, I can add it. It should be really easy, just copy the powershell_script_filename test in the same file twice, give them new names, and test the cases you added.

Looks good to me! Could you add a test? No worries if not, I can add it. It should be really easy, just copy the powershell_script_filename test in the same file twice, give them new names, and test the cases you added.

Done!
I was tempted to join the powershell filename tests together (like the various check calls in split_shebang) but maybe it's better to keep them separate to have well-named tests. Is the #test annotation something you can abstract over in Rust?
Thanks for all your work on this project. just is near the top of my most used (and loved) CLI tools.

Done!

Awesome!

I was tempted to join the powershell filename tests together (like the various check calls in split_shebang) but maybe it's better to keep them separate to have well-named tests. Is the #test annotation something you can abstract over in Rust?

I think separate well-named tests is good. You can abstract over the test annotation using macros, but it winds up being a little gross. I'm actually moving away from having macros that generate tests, the tests in the tests directory are mixed, some use macros, some don't.

Thanks for all your work on this project. just is near the top of my most used (and loved) CLI tools.

You bet! That's great to hear.


Config should be able to create .tscn like config files

Would be nice if .tscn like ini could be generated and used for the game.
[tscn name="name" type="type1" parent="parentname"]
key = 20

set_tscn("name", "type1", "parentname")
set_tscn_value("name", "type1", "key", 20)
get_tscn_types()  = return a list of all types
get_tscn("type1") = return a list of all tscn objects of that type
get_tscn_keys("name", "type1") = returns a list of all keys for that name and type
get_tscn_values("name,"type1") = returns a list of all valeus for that name and type
set_tscn("name","type1", "newname", "newtype", "newparent")

I know people may be confused by this but tscn essentially is an alternative to  json or yaml. Since Godot uses it why not make it a proper system for storing tree like data.

Maybe you could write a TOML parser instead

This example API is confusing to me, I'm not sure what the methods do by looking at the signature. Also, it should be grabbed by id since .tscn can have more than one object of the same type.
It's easier and more practical to use ConfigFile's functions.

I don't see the point. .tscn (and other scene formats) is designed to be created from a scene tree and the other way around, not manually (unless you are brave enough to edit it manually).

There is PackedSceneState or similar already that might do most of it... (except the writing AFAIK)

I just thought since Godot uses this special ini type config it should also be able to generate one for the game.  For this tool that I am using a tscn like config file would be much more useful over regular Config or JSON.

no intention of adding this as built-in, use ConfigFile


Entries in the Tool list gets hidden when display size for the app is small.

Electron build - e6f2a4aaa
Entries in the Tool list gets hidden when display size for the app is small.
https://github.com/user-attachments/assets/28b40fe3-bdce-4fab-9515-0e6531db2151

Until this bug is fixed, the issue can be resolved by increasing the viewport height

I can live with this bug


Improve Variable guide

Mention chainer.grad
Use Variable.array rather than Variable.data
Fix dead links

jenkins, test this please.

Jenkins CI test (for commit 874c7f8d621cedee3cc46bcca4f7b084fdb9c556) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@niboshi, @hvy Thanks for review, I fixed accordingly.

Jenkins, test this please.

Jenkins CI test (for commit 69e004c8e59aff75aa558e52d72f61ae0ea61719) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Thanks for the additional section. I added some more nitpicks, mind taking a look again?

Thanks, fixed accordingly.

Jenkins CI test (for commit 69e004c8e59aff75aa558e52d72f61ae0ea61719) succeeded without errors!

Jenkins, test this please.

@niboshi Could you check and approve the review?

jenkins, test this please.

jenkins, test this please.

Jenkins CI test (for commit 847ff4abe90a6bb5184a71c9f075bdc2802f85bf) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM, the CI failure is not related to this PR.


singer language difference

I found there are 52 singer.
All of them is in chinese ?
Or they have different language

all in chinese

Can I use other language such as english singer or a janpanese singer to train new singer?

yes


There are too many code modules that need subcontracting

The code should be distinguished according to different learning channels or project examples, so as to be clearer

#25 resolved


Minor comment spelling fix.

Changing excerpt spelling in the mnist_with_summaries.py file.

Can one of the admins verify this patch?


ustreamer not running on startup

Ustreamer installs correctly as i can get it running manually however i must do this everytime the computer reboots. Would be amazing if it started on a service that was installed via the script!

Did you go through the 'Add Camera' step? That makes a service file that automatically starts on boot.

Yep, when creating the printer. Plugged in the printer first to get the usb port, then clicked yes for the camera and plugged that in. After restarting the PC The camera doesnt boot until manually booting ustreamer via ssh.
Running the latest stable release of debian 11 on a bmax mini pc with a n3350 processor
Thanks for the response!

What command are you giving to start ustreamer?
What is the output of ls -la /etc/systemd/system/cam*?


doc: various improvements to documentation

This provides several minor improvements to the documentation. It mostly polishes and fixes some minor things.
A notable changes is regarding the "Optimality" documentation that now refers to ANytime planning and suggest using it when no optimality guarantee is needed.
The other important change is to the contributors guide that is now much more complete.
The most controversial thing is the addition of a justfile at the root of the repository that should aim at documenting, making discoverable and easily accessible the various commands taht are useful to interact with the code base.
just is command line utility that you can think of as a much better make. If you haven't used it I strongly suggest giving it a try.
Even without using it the justfile is useful in centralizing the different commands (without going into the CI configuration as I usually have to do).
The objective of the PR is not to generalize the usage of just but if there is consensus that it is a desirable thing it could be be extended (e.g. for running the tests) and used in CI to avoid duplication.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (01c4614) 84.96% compared to head (8bc0b6b) 84.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   84.96%   84.96%
=======================================
  Files         200      200
  Lines       26433    26433
=======================================
  Hits        22458    22458
  Misses       3975     3975

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Philly Glow Event Bugs

Describe your bug here.
Whenever i use philly glow in the philly bg, it just zooms in whenever doing 0 or 1 (off/on) and gradient reset doesn't even work. it just makes the random color have a gradient going up whenever i use the event. please help.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, Just Added Mods N' Stuff.

How were you able to get all the base game assets to work in the Engine?


Notebook README links don't work

Currently the links to the notebook README.md file point to what I assume is an internal Apple Github instance so these aren't resolvable on the public internet.

Thanks, @massdosage, we had to redo the repository from scratch and now all links should work.

OK, great, thanks for letting me know.


FindTAO cmake module

I'm sorry about the slow reply. Is this still relevant since TAO became part of PETSc in v3.5 (released last year)?

I need to check this, i use this with PETSc 3.4.5 and TAO 2.2.2.

Yikes, those versions have not been supported in a while.  Please upgrade to PETSc 3.6.

This module is not needed anymore with PETSc 3.6


Fix depwarn of readall in deps/build.jl

Appveyor seems to have some issue with Conda.jl and then hit https://github.com/JuliaLang/julia/issues/15789 . Restart to see if the issue is gone (in any case it should be unrelated to this PR)...


Use OrderedDict for sorting releases in JSON

Right now releases in JSON are sorted as strings and not as versions, and that might be because of unsorted dict usage.
https://pypi.org/pypi/boto3/1.9.220/json

I'm not sure this necessary. We don't imply any ordering here, and a JSON object is by definition an unordered set of name/value pairs.
Even if we use an OrderedDict here, there's no guarantee that whatever parser/serializer/deserializer between us and the user is going to maintain that ordering.

I agree with @di, if sort order is important it should be handled explicitly by the client. Are you considering this a regression or just a proposed feature @techtonik, I'm not certain how pypi-legacy responded.

Some languages are sorting JSON by default. It is not for client - it is for debugging. Specifically, if you try to locate entry for the latest release of https://pypi.org/pypi/boto3/json, it will be located somewhere in the middle of the list. Releases are already sorted there, but as strings, not versions. Sorting them doesn't break the JSON standard, and if somebody relies on the sorting behavior - that's not a problem with PyPI.

Reviewing this older issue.
Python 3.7 introduced dict ordering preserved on insertion order. We already order the release_files before adding them to releases, so the current state is that the results are ordered, unintentionally.
To support visual debugging, the latest release is (often) the last one, but as was pointed out, JSON object ordering is not explicit.
Recommend closing!


[WIP] New fabric parity tests

What does this PR do?
Rewrite of all parity tests. Cleaner and easier to read.

Asserts the final weights are equal (as before)
Asserts the iteration time overhead (we allow ~1ms difference)
DDP and mixed precision tested as well
Asserts that peak memory usage is no bigger than that of torch
Standardized model interface so it can be switched out / parameterized later. We may want to test larger models as well with smaller tolerances (and fewer iteration steps) in the future.

Since these tests don't run on an isolated system, there will be noise from other tasks that can lead to flakiness in the assertions for timings we make. To mitigate this, we rerun the test up to 3 times if it fails.
Each test runs for about 8 seconds, 1000 training iterations. This is to ensure we get a robust measurement.
cc @carmocca @justusschock @awaelchli @borda

It would be very cool if we could add a test(s) like this:
class TrackingMode(TorchDispatchMode):
    def __init__(self):
        super().__init__()
        self.calls = []

    def __torch_dispatch__(self, func, types, args=(), kwargs=None):
        self.calls.append(f"{func.__module__}.{func.__name__}")
        return func(*args, **kwargs)

def test_parity_aten_tracking():
    # Train with Fabric
    fabric_tracking = TrackingMode()
    with fabric_tracking:
        fabric = Fabric(precision=32, accelerator="cpu", devices=1)
        train_fabric(fabric)

    # Train with raw PyTorch
    raw_tracking = TrackingMode()
    with raw_tracking:
        train_torch(
            fabric.to_device, precision_context=fabric.autocast, input_dtype=torch.float32
        )

    assert fabric_tracking.calls == raw_tracking.calls

@carmocca I like it, and I quickly tested it, works for the cpu case, but there are small differences between torch and fabric when running on cuda.
E       AssertionError: assert ['torch._ops....default', ...] == ['torch._ops....default', ...]
E         At index 13 diff: 'torch._ops.aten.zeros.default' != 'torch._ops.aten.lift_fresh.default'
E         Full diff:
E           [
E            'torch._ops.aten.empty.memory_format',
E            'torch._ops.aten.random_.default',
E            'torch._ops.aten._local_scalar_dense.default',
E            'torch._ops.aten.zeros.default',...
E
E         ...Full output truncated (126005 lines hidden), use '-vv' to show

tests/tests_fabric/parity/test_parity_simple.py:159: AssertionError

Let's investigate this for a follow up.

I also just found that this tracking/dispatching is non-deterministic. Running a simple model on CPU multiple times leads to different calls on re-runs. Sometimes the assertion passes, sometimes not. If we want to do this, we need to figure out how to make it deterministic.


IRGen: Store scalars as bytes to avoid undefined bits

Don't tempt llvm to misbehave on partially initialized bytes -- it will.
rdar:///66701259

@swift-ci Please test

Do you have an LLVM bug tracking the "misbehavior"? Thanks!


Kubernetes Federation Operator Not Working

Before I begin, let me paste the versions of my setup:
kubefed2: v0.0.6-39-g10df7a98
Kubernetes: 1.12.5-gke.5
I'm using GKE and to keep my tests as simples as possible, I've create 2 clusters (one node each) using Ubuntu's image (internal requirement).
I followed every step I read about:

How to install an Operator;
Installing the operator;
Checking that every Pod is up and running (both in OLM and Operators namespaces).

Here things start to break down... As per the instructions, I'm supposed to enable the namespaces, but if I do I receive the following error message:
$ kubefed2 enable namespaces --federation-namespace operators
customresourcedefinition.apiextensions.k8s.io/federatednamespaces.types.federation.k8s.io created
F0307 02:06:44.590594   10200 enable.go:111] error: Error creating FederatedTypeConfig "namespaces": FederatedTypeConfig.core.federation.k8s.io "namespaces" is invalid: []: Invalid value: map[string]interface {}{"kind":"FederatedTypeConfig", "apiVersion":"core.federation.k8s.io/v1alpha1", "metadata":map[string]interface {}{"uid":"cd4f22fe-4096-11e9-87c6-42010a9e0fcc", "name":"namespaces", "namespace":"operators", "creationTimestamp":"2019-03-07T05:06:44Z", "generation":1}, "spec":map[string]interface {}{"target":map[string]interface {}{"pluralName":"namespaces", "version":"v1", "kind":"Namespace"}, "namespaced":false, "propagationEnabled":true, "federatedType":map[string]interface {}{"pluralName":"federatednamespaces", "group":"types.federation.k8s.io", "version":"v1alpha1", "kind":"FederatedNamespace"}}, "status":map[string]interface {}{}}: validation failure list:
spec.comparisonField in body is required
spec.template in body is required
spec.placement in body is required

I had to add --federation-namespace operators myself since there is not a single mention that the Federation Controller expects to run under federation-system. Anyhow, the User Guide lists this step after both clusters are joined, so I momentarily ignored this issue and went on to join them.
Here, I use the commands I need:
$ kubefed2 join cluster1 --cluster-context cluster1 --host-cluster-context cluster1 --add-to-registry --v=2 --federation-namespace operators
$ kubefed2 join cluster2 --cluster-context cluster2 --host-cluster-context cluster1 --add-to-registry --v=2 --federation-namespace operators

I see the secrets are created with the right content inside, but still it doesn't work.
I0307 05:11:11.258392       1 federated_informer.go:216] Cluster operators/cluster1 not added; it is not ready.
I0307 05:11:11.258455       1 federated_informer.go:216] Cluster operators/cluster1 not added; it is not ready.
I0307 05:11:11.258521       1 federated_informer.go:216] Cluster operators/cluster1 not added; it is not ready.
I0307 05:11:11.258936       1 federated_informer.go:216] Cluster operators/cluster1 not added; it is not ready.
I0307 05:11:11.258994       1 federated_informer.go:216] Cluster operators/cluster1 not added; it is not ready.
E0307 05:11:11.268554       1 controller.go:163] Failed to create corresponding restclient of kubernetes cluster: clusters.clusterregistry.k8s.io "cluster1" not found
W0307 05:11:13.259003       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:11:53.268179       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:12:33.274642       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:13:13.282018       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:13:53.288814       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:14:33.298364       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:15:13.301249       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:15:53.308184       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:16:33.316091       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:17:13.323766       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:17:53.326507       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:18:33.332443       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:19:13.339601       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:19:53.347379       1 controller.go:200] Failed to get client for cluster cluster1
I0307 05:20:30.219088       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
I0307 05:20:30.219272       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
I0307 05:20:30.219341       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
I0307 05:20:30.219420       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
I0307 05:20:30.220725       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
I0307 05:20:30.220800       1 federated_informer.go:216] Cluster operators/cluster2 not added; it is not ready.
E0307 05:20:30.229959       1 controller.go:163] Failed to create corresponding restclient of kubernetes cluster: clusters.clusterregistry.k8s.io "cluster2" not found
W0307 05:20:33.351895       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:20:33.352234       1 controller.go:200] Failed to get client for cluster cluster2
W0307 05:21:13.362653       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:21:13.362677       1 controller.go:200] Failed to get client for cluster cluster2
W0307 05:21:53.365988       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:21:53.366013       1 controller.go:200] Failed to get client for cluster cluster2
W0307 05:22:33.370930       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:22:33.370961       1 controller.go:200] Failed to get client for cluster cluster2
W0307 05:23:13.374098       1 controller.go:200] Failed to get client for cluster cluster1
W0307 05:23:13.374123       1 controller.go:200] Failed to get client for cluster cluster2

And now I'm at a lost. I get this is all in Alpha stage, but I don't seem to get past the most basic step in this whole configuration, not to mention some confusion between the Operator's instruction and the User Guide...
Does anyone know how to fix these issues? Or if the Operator worked and I'm missing something?

Hi @davi5e - I'm working on an update to a much newer version of this operator that should be up soon. Hang tight and we'll work through it in the next few days. We're working to improve doc in this area, so it's really helpful that you raised this issue.
cc @abrennan89

@davi5e I suspect that the problem is related to a mismatch between the version of kubefed2 that you're using and the version of the operator, and that my coming update should get you unstuck. I would really like to connect and talk to you in detail about how you felt the operator's instructions could be improved.

@pmorie That's great news! I'll be sure to check it out.
For the time being, my team is moving back to v1 just to carry on with some tests we need to do.
As for the docs, I'll send you an e-mail.

@davi5e could you post the output of kubefed2 version ?

$ kubefed2 version
kubefed2 version: version.Info{Version:"v0.0.6-39-g10df7a98", GitCommit:"10df7a98e8c937de79dd4fed6479a9bfcb7337a6", GitTreeState:"clean", BuildDate:"2019-03-07T04:42:04Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

That's the version I used (compiled from here). Not sure if there is a newer one though...

Okay, that's the latest one, and would explain why you had trouble with 0.0.2. I've got a fairly significant update to the description in progress, would you be interested in giving me a review?

I'd be more than happy to go through it!

@davi5e - can we close this?

Yes, fixed by v0.0.6


chore: migrate downsampler to glsl 330

migrate down sampler shader to gls330
downsampler is used for the exposure affect but I'm not sure this even works correctly. it should still work the same way in its current state.  can be enabled from setting exposure.
PR: https://github.com/Terasology/CoreRendering/pull/49

 OpenGL migrations


FullTypeStringer fails on a type with no package

My tests aren't in a package, and this makes the type stringer fail. It's an easy fix but I'm unable to get IntelliJ to load Kodein properly.
https://github.com/SalomonBrys/Kodein/blob/master/kodein-core/src/main/kotlin/com/github/salomonbrys/kodein/typeDisp.kt#L82

I'll fix this on the next version of Kodein 3 & 4.
Thanks for the report :)

BTW, to load Kodein in IDEA, you should disable the JS or Android projects in settings.gradle.
Kotlin + JS + Android is just too much for IDEA :)

Awesome, thanks for the help 👌

I've updated the sources of Kodein 4 so that IDEA should be able to load the project ;)

Version 3.4.1 & 4.0.0-beta2 are fixed and uploaded ;)


Fix for pyolog and opyhd

Fixes for ophyd and pyolog. Sorry @tacaswell, @dchabot I forgot to put this PR in in my reduced state yesterday.

I have modified recipes also not checked in on one of the srx machines, let
me reconcile those before this gets merged please.
On Thu, Feb 12, 2015, 08:07 Stuart Wilkins<EMAIL_ADDRESS>wrote:

Fixes for ophyd and pyolog. Sorry @tacaswell
https://github.com/tacaswell, @dchabot https://github.com/dchabot I
forgot to put this PR in in my reduced state yesterday.
You can view, comment on, or merge this pull request online at:
https://github.com/NSLS-II/conda-prescriptions/pull/16
Commit Summary

ENH : Added pyolog
BUG : no ipython in ophyd

File Changes

M ophyd/meta.yaml
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-0
(1)
A pyolog/build.sh
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-1
(4)
A pyolog/meta.yaml
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-2
(33)

Patch Links:

https://github.com/NSLS-II/conda-prescriptions/pull/16.patch
https://github.com/NSLS-II/conda-prescriptions/pull/16.diff

—
Reply to this email directly or view it on GitHub
https://github.com/NSLS-II/conda-prescriptions/pull/16.

No problem
Best wishes,
Stuart
On Feb 12, 2015, at 08:45, Thomas A Caswell <notifications<EMAIL_ADDRESS>wrote:
I have modified recipes also not checked in on one of the srx machines, let
me reconcile those before this gets merged please.
On Thu, Feb 12, 2015, 08:07 Stuart Wilkins <notifications<EMAIL_ADDRESS>wrote:

Fixes for ophyd and pyolog. Sorry @tacaswell
https://github.com/tacaswell, @dchabot https://github.com/dchabot I
forgot to put this PR in in my reduced state yesterday.
You can view, comment on, or merge this pull request online at:
https://github.com/NSLS-II/conda-prescriptions/pull/16
Commit Summary

ENH : Added pyolog
BUG : no ipython in ophyd

File Changes

M ophyd/meta.yaml
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-0
(1)
A pyolog/build.sh
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-1
(4)
A pyolog/meta.yaml
https://github.com/NSLS-II/conda-prescriptions/pull/16/files#diff-2
(33)

Patch Links:

https://github.com/NSLS-II/conda-prescriptions/pull/16.patch
https://github.com/NSLS-II/conda-prescriptions/pull/16.diff

—
Reply to this email directly or view it on GitHub
https://github.com/NSLS-II/conda-prescriptions/pull/16.

—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/conda-prescriptions/pull/16#issuecomment-74072067.


Incorrect timing report when asserts are not used before delays.

'use strict'

const {promisify} = require('util')
const {test} = require('tap')

const delay = promisify(setTimeout)

test('assert after delay', async t => {
  await delay(1000)
  t.ok(true, 'test after 1 second delay')
})

test('assert before delay', async t => {
  t.ok(true, 'test before 1 second delay')
  await delay(1000)
})

This test file reports incorrect timing for assert after delay (tested on tap 14).
$ node test/timing.js |npx tap -
 PASS  assert after delay 1 OK 6ms
 PASS  assert before delay 1 OK 979ms

  🌈 SUMMARY RESULTS 🌈

Suites:   2 passed, 2 of 2 completed
Asserts:  2 passed, of 2
Time:     1s

It seems that the reported time does not begin until the first assertion, but this can often be wrong for async testing.  Found this on graceful-fs testing test/avoid-memory-leak.js was reported as taking 28ms though it takes many seconds.

Yeah, this looks like an issue with treport's timing when piping in.  I think in those cases it  should probably print the # time=... value instead of timing the actual test time.  When the "test" it's reporting is just parsing input, it's almost never going to match the actual test timing.  For example, even the 979ms  is wrong -- it should be something a little above 1000ms.

Fixed on 14.7.2


Finalized the OpenAPI Client Validator Spec

Description:
This issue is created to track the subtask of openAPI client generator implementation.
Describe your task(s)

[x] Identify the feasibility of the implementation
[ ] Identify the initial scenarios need to validate

Related Issues (optional):
Core issue: https://github.com/ballerina-platform/ballerina-standard-library/issues/5388
Suggested Labels (optional):

Suggested Assignees (optional):

Close this issue we have no major requirements for this.


Installing on windows fails

Using Racket <IP_ADDRESS>--2017-07-15(83540d1ae6/a) on Windows 10 x64 with the latest Github version of video, installation of video fails with the following error:
ffi-lib: couldn't open "avutil-55.dll" (The specified module could not be found.; win_err=126)
  context...:
   C:\Users\Ben Chung\AppData\Roaming\Racket\snapshot\pkgs\video\video\private\ffmpeg.rkt: [running body]
   C:\Users\Ben Chung\AppData\Roaming\Racket\snapshot\pkgs\video\video\private\init.rkt: [traversing imports]
   C:\Program Files\Racket-<IP_ADDRESS>\collects\compiler\cm.rkt:363:0: compile-zo*
   C:\Program Files\Racket-<IP_ADDRESS>\collects\compiler\cm.rkt:572:26
   C:\Program Files\Racket-<IP_ADDRESS>\collects\compiler\cm.rkt:564:42
   C:\Program Files\Racket-<IP_ADDRESS>\collects\compiler\cm.rkt:635:0: compile-root
   C:\Program Files\Racket-<IP_ADDRESS>\collects\compiler\cm.rkt:782:4: compilation-manager-load-handler
   standard-module-name-resolver

This is repeated many times in the output of raco pkg install.

It seems like this issue has been resolved. (Based on conversations outside of this issue.) If this is not the case feel free to reopen. :)


Vault controller fix

RBAC prevents accessibility to cluster scope. To alleviate this, we changed kube.go to only search within namespace scope.

Can you expand on why RBAC does not allow access to the cluster scope? A ClusterRole can be used to grant access to cluster-wide resources: https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole
We currently allow the ability to watch multiple namespaces using a regex pattern. This is predicated on the requirement that we can watch all namespaces. Unfortunately, your changes will break if a regex pattern is passed in as the watch namespace.


ENYO-5405: Fix Picker 5-way focus behavior

Issue Resolved / Feature Added
When using 5-way to navigate between buttons in a non-joined Picker component, certain layouts can cause focus to change to other outside elements, rather than the intended alternate Picker button.
Spotlight attempts to set focus to the natural "next" target based on the direction pressed. The targets gaining focus here are generally expected, however when pressing a 5-way directional key towards an opposing Picker button, it is always assumed that the other button should gain focus.
Resolution
Since we handle the Picker's internal button keydown events and have access to the spottables, we can decide during keydown when to prevent default spotlight behavior and set focus elsewhere, if needed.
Enact-DCO-1.1-Signed-off-by: Jeremy Thomas<EMAIL_ADDRESS>

This works as expected, but we found another bug from a joined vertical picker within a item list.
5-way into joined vertical picker itself works as expected, but we have an issue with using 5-way left and right.

@haileyR That appears to be a consequence of a vertical Picker being equal distance from 2 Item components, so the 1st match will receive focus. As I commented on ENYO-5421, I wouldn't classify this as a bug - it's a layout issue. If a developer wished to direct focus elsewhere, they should use directional spotlight function props (onSpotlightRight) on the Picker to do so.


Simplify CSR (config) generation

openssl doesn't accept - as an input filename, but there is still /dev/stdin you can use to feed a config directly.
Used positional parameters instead of $altnames to simplify the creation of the subjectAltName= line.
Just a proposal from my own script.

I can't recall what exactly but I'm pretty sure that I tried this and I had a problem with it, also temporary files don't really hurt anybody so I'm leaving it as it is right now.


is there a way to install globally a package for all versions of node.

Basically what i want to run npm install -g grunt and find it no matter what version of node i've switched to. Is there a way to do that?

No, and you shouldn't. npm modules shouldn't be shared across node versions, because they are highly likely to be incompatible.
You may find nvm reinstall-packages helpful to "copy" your global packages from one version of node to another.

ok, nvm reinstall-packages is exactly what I needed, thanks.


Add Twist Relaxer stub

Used on a very small number of avatars. [Ex: Nardotaur 3.0]
Confirmed working with projects using FIK 1.9.

Thanks, we will change the files to work with our scripts, and release it somewhere in the next while


Status bar hangs in ansible-language-server v0.2.4

Description
When a syntax error occurs, the status bar ansible-lint Processing files... message no longer disappears.
Furthermore, each time it is executed, the message will increase without disappearing.
It seems to be after the falling back process to "ansible syntax-check" was added.
DEMO(mp4)
[NG] v0.2.3-beta
https://user-images.githubusercontent.com/188642/137939562-a9d109e1-ed61-4c03-b481-611ee952fd4a.mp4
[OK] v0.1.1-0
https://user-images.githubusercontent.com/188642/137939630-aac0db5f-e765-495b-bf1b-02b405c10282.mp4

@priyamsahoo I have created a pull request to be adjusted. 🙇


docs: clearify comments in table.proto -> message DataFragment -> physical_rows

#2345

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.79%. Comparing base (d05a1d6) to head (e38ae06).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   80.79%   80.79%   -0.01%
==========================================
  Files         192      192
  Lines       56213    56213
  Branches    56213    56213
==========================================
- Hits        45419    45418       -1
  Misses       8128     8128
- Partials     2666     2667       +1

Flag
Coverage Δ

unittests
80.79% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Empty parameter list with IN statement lead to runtime TSQL syntax error

Query part like:
where i.Id in @ìds
Compiles with empty ids list to:
WHERE ([i].[Id] IN ());
Which is syntax error:
Msg 102, Level 15, State 1, Line #
Incorrect syntax near ')'.

Good catch. I started with SQLite which accepts this syntax (it's pretty liberal about a lot of things).
The tricky part about fixing this is that the (comma,separated,list) part of these IN @whatever expressions gets generated at runtime, and currently is unaware of the backend in use. So to fix this without making a bigger change to expose the backend at runtime, it'd have to be something that works on all DBs.
At first I thought simply translating an empty array to (SELECT NULL WHERE 1=0) would work. That would be a 5-second fix, but it seems it doesn't work on Postgres because PG can't figure out the row type of the subquery.
I'll think about this a little more. Probably the best approach will be to refactor so that the backend can be used at runtime, which will be helpful in the long run anyway.

Ultimately I decided to hack this in by sniffing the connection type at runtime, in order to satisfy Postgres's very picky typechecker. Thankfully there was already a DbType produced by the RZSQL typechecker available with the array parameter.
As of 0.6.2, behavior for IN with an empty array is:
SQLite (unchanged):
x IN ()

Postgres:
x IN (SELECT NULL::numeric WHERE FALSE)

numeric could also be text, timestamptz, bytea or uuid depending on the parameter type associated with the empty array (inferred by the RZSQL compiler, so should "just work" in terms of matching the type of x enough to satisfy PG).
All others:
x IN (SELECT NULL WHERE 1=0)


AI feauters using userChromeJS

Hi!
The Arc browser has AI capabilities, it would be cool to make them too.
More details here

Download
https://www.mediafire.com/file/nyekc4ehyxg2ijy/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/nyekc4ehyxg2ijy/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/nyekc4ehyxg2ijy/fix.zip/file
In the installer menu, select "gcc."


improve logging

either use logrotate conf or simply log to journal.
currently there is no log file maintenance configured and the server will run out of space eventually

Done. The logfiles are rotating


Auto copy selection to primary clipboard.

With save_to_clipboard: true in selection section of
alacritty.yml. The selected string will automatically copy to primary
clipboard.

Tested on Archlinux and OSX 10.13.6.

I tested this and it dies with a crash if save_to_clipboard is missing in selection. That probably needs to be fixed, but otherwise the functionality looks good!!!

@unphased Thanks for test. I will fix it ASAP.

@unphased I have uploaded the new patch and it works on my Archlinux, can you try it again? Thank you.

OK, so it defaults to true when the config flag is missing? I like that, but I dont know if thats what should be done.
Looks good to me but maybe you should look into syncing with master and checking whats going on with the failing travis build.

@jwilm Thanks for the review. I have uploaded the new patch based on your suggestions.

@cathay4t it seems that the tests are broken on this branch. Would you mind checking that out?

The clippy reports some false alarm on Use of undeclared type or module Buffer. Let me find a way
to ease that.

@jwilm CI is happy now.

New patch uploaded. Changes since last one:

Will copy to both the selection and primary clipboards if save_to_clipboard: true.
CHANGELOG.md updated to include this changes.
Rephrased the comments of config file.

Thanks for the review. New patch updated.

Thanks for the review. Rephrased.


Speaker2Log repetition

Hi sinneDeeL, this is not a bug; it's for accuracy. If you are annoyed by it, I recommend setting both the 'Speaker Record Timeout' and 'Speaker Phrase Timeout' to the same number of seconds. This should reduce that behavior a bit.


npm WARN<EMAIL_ADDRESS>requires a peer of continuation-local-storage@~3 but none was installed.

I ran
npm install
and got this error

It's a warning from one of the dependencies. Shouldn't be anything critical. Do you see any errors?

Please re-open an issue with additional details if your continue experiencing problems.


Not respond

server.get('/', async (req, res) => {
  return { message: 'OK' }
})

server keep requesting. (52) Empty reply from server

@mengheangrat Can you maybe provide more context on how to reproduce the issue? Maybe an example project. On which platform are you, and in which versions does the issue appear?

Same issue :
curl: (52) Empty reply from server
"react-native": "0.72.4",
MacBook Air M1

repo to reproduce this issue :
https://github.com/abdelhameedhamdy/rn-http-server

Since this bug is the same as #21. I will close this thread. Please check #21 for news.


Reconnection to the broker after each message

Hello,
First, thanks for your code. My charging automation is saved and it was straightforward to use :-)
I noticed that the client always disconnects and reconnects to the MQTT broker. After looking into the code, it might be due to the -E flag of mosquitto_sub. When used, the client disconnects after the subscription is acknowledged by the broker.
If I remove the flag and move listen_to_mqtt outside of the while true loop, then it still works fine and there are no more disconnection/reconnection. But then, I believe some error handling must be done in case mosquitto_sub has a problem and is killed. It must be respawned again.
What is your opinion?
Thanks.

Hello, thanks for your comments.
Did you install the 'dev' branch version, as I didn't use the -E flag in the 'main' branch version?
I'm using the E flag to deliberately break the connection so I can also use bluetoothctl to scan for presence of the car. The manual https://mosquitto.org/man/mosquitto_sub-1.html says to use -E and -c together to create what it calls a 'durable client' session.
Is there a disadvantage of the constant connection / disconnection? If so I might have to have a rethink how to achieve the presence detection which was requested by other user (and something I will find useful too). I did consider spawning a separate process for the presence detection, but the two processes will try to access the bluetooth at the same time (which may or may not cause a problem)
Thanks

Hello,
Indeed, I was using the dev branch (for the wakeup call which works fine btw). Sorry for not mentioning it.
No, I had no problem with the constant connection/disconnection, I just found it strange to see the behavior in the MQTT server logs. Ok, I now understand your concerns with the presence detection, it makes sense.
I guess we can close this ticket.
Thanks again for the code which arrives at the perfect moment!


Wrong splash screen for ASP.NET Core Web Site - Empty

From @sebastienros on May 4, 2016 17:5
Actual result:

Where it actually is a middleware based app, without views and and without Gulp/Bower files.
Copied from original issue: aspnet/Templates#538

From @peterblazejewicz on May 4, 2016 20:26
@sebastienros
At the moment the VS team provides an unified starter noob document. They are seeing the problem with that model though:
https://github.com/aspnet/Templates/issues/498

This is no longer an issue in 2.0.


Inconsistent build.gradle.kts groups between client and server

codgen-client and codegen-core:
https://github.com/awslabs/smithy-rs/blob/2f70ac8ec08aacc5896bf51e02e6a992c0190370/codegen-client/build.gradle.kts#L18
https://github.com/awslabs/smithy-rs/blob/2f70ac8ec08aacc5896bf51e02e6a992c0190370/codegen-core/build.gradle.kts#L19
codegen-server:
https://github.com/awslabs/smithy-rs/blob/2f70ac8ec08aacc5896bf51e02e6a992c0190370/codegen-server/build.gradle.kts#L19
The build.gradle.kts should be also examined for any additional inconsistencies and tooling dependent on this should be assessed for breakages.
This should probably be prioritized before we publish to Maven?

@hlbarber can you assigned to me this issue?

And you tell me what is this issue?

And you tell me what is this issue?

The format of codegen-server group is currently inconsistent with the others.  Really, codegen-server should be - software.amazon.smithy.rust.codegen.
We want uniformity across these three build scripts. Other aspects of the files might not be uniform when they should be, we should make them conform too.

Sir I made changes in this file. Sir please check and let me know if is
this working or not?
On Fri, 28 Apr 2023, 6:12 pm Harry Barber, @.***> wrote:

Assigned #2600 https://github.com/awslabs/smithy-rs/issues/2600 to
@Aditya3815 https://github.com/Aditya3815.
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/smithy-rs/issues/2600#event-9124450052, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJNUV6S6VXUCZZTOH5FH3XDO3NBANCNFSM6AAAAAAXD7YBG4
.
You are receiving this because you were assigned.Message ID:
@.***>

/*

Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
*/

import org.gradle.api.tasks.testing.logging.TestExceptionFormat
plugins {
kotlin("jvm")
jacoco
maven-publish
}
description = "AWS Specific Customizations for Smithy code generation"
extra["displayName"] = "Smithy :: Rust :: AWS Codegen"
extra["moduleName"] = "software.amazon.smithy.rustsdk"
group = "software.amazon.smithy.rust.codegen"
version = "0.1.0"
val smithyVersion: String by project
val kotestVersion: String by project
dependencies {
implementation(project(":codegen-core"))
implementation(project(":codegen-client"))
runtimeOnly(project(":aws:rust-runtime"))
implementation("org.jsoup:jsoup:1.14.3")
implementation("software.amazon.smithy:smithy-protocol-test-traits:$smithyVersion")
implementation("software.amazon.smithy:smithy-aws-traits:$smithyVersion")
testImplementation("org.junit.jupiter:junit-jupiter:5.6.1")
testImplementation("io.kotest:kotest-assertions-core-jvm:$kotestVersion")
}
val generateAwsRuntimeCrateVersion by tasks.registering {
// generate the version of the runtime to use as a resource.
// this keeps us from having to manually change version numbers in multiple places
val resourcesDir = "$buildDir/resources/main/software/amazon/smithy/rustsdk"
val versionFile = file("$resourcesDir/sdk-crate-version.txt")
outputs.file(versionFile)
val crateVersion = project.properties["smithy.rs.runtime.crate.version"]?.toString()!!
inputs.property("crateVersion", crateVersion)
sourceSets.main.get().output.dir(resourcesDir)
doLast {
versionFile.writeText(crateVersion)
}
}
tasks.compileKotlin {
kotlinOptions.jvmTarget = "1.8"
dependsOn(generateAwsRuntimeCrateVersion)
}
tasks.compileTestKotlin {
kotlinOptions.jvmTarget = "1.8"
}
// Reusable license copySpec
val licenseSpec = copySpec {
from("${project.rootDir}/LICENSE")
from("${project.rootDir}/NOTICE")
}
// Configure jars to include license related info
tasks.jar {
metaInf.with(licenseSpec)
inputs.property("moduleName", project.name)
manifest {
attributes["Automatic-Module-Name"] = project.name
}
}
val sourcesJar by tasks.creating(Jar::class) {
group = "publishing"
description = "Assembles Kotlin sources jar"
classifier = "sources"
from(sourceSets.getByName("main").allSource)
}
tasks.test {
useJUnitPlatform()
testLogging {
events("passed", "skipped", "failed")
exceptionFormat = TestExceptionFormat.FULL
showCauses = true
showExceptions = true
showStackTraces = true
showStandardStreams = true
}
}
// Configure jacoco (code coverage) to generate an HTML report
tasks.jacocoTestReport {
reports {
xml.isEnabled = false
csv.isEnabled = false
html.destination = file("$buildDir/reports/jacoco")
}
}
// Always run the jacoco test report after testing.
tasks["test"].finalizedBy(tasks["jacocoTestReport"])
publishing {
publications {
create("default") {
from(components["java"])
artifact(sourcesJar)
}
}
repositories { maven { url = uri("$buildDir/repository") } }
}

That looks good to me, thanks. Please post a PR with the included changes.


Autoload is maybe wrong: Cannot redeclare Safe\array_combine()

Larastan Version: v0.6.11
--level used: 8

Description
When running phpstan with larastan extension on specific functions this error happened. I created a repository to reproduce this:
https://github.com/nepda/phpstan-larastan-bug
Without larastan, it will run perfectly.
Laravel code where the issue was found
<?php declare(strict_types=1);

namespace App;

use function Safe\dns_get_record;

class Test2
{
    private function test(): void
    {
        dns_get_record('example.com');
    }
}

php ./vendor/bin/phpstan analyse app/Test2.php                                                                                [11:59:21]
Note: Using configuration file /var/www/html/phpstan.neon.
PHP Fatal error:  Cannot redeclare Safe\array_combine() (previously declared in /var/www/html/vendor/thecodingmachine/safe/generated/array.php:20) in /var/www/html/vendor/thecodingmachine/safe/generated/array.php on line 20
Fatal error: Cannot redeclare Safe\array_combine() (previously declared in /var/www/html/vendor/thecodingmachine/safe/generated/array.php:20) in /var/www/html/vendor/thecodingmachine/safe/generated/array.php on line 20

In array.php line 20:

  Cannot redeclare Safe\array_combine() (previously declared in /var/www/html/vendor/thecodingmachine/safe/generated/array.php:20)

Failed to execute command php ./vendor/bin/phpstan analyse app/Test2.php: exit status 255
FAIL

If you remove those lines:
includes:
    - vendor/nunomaduro/larastan/extension.neon

it will run without errors.
This is related to: https://github.com/thecodingmachine/safe/issues/253

Try adding , false, see the above PR.

Want to see stange things?
Replace the contents of vendor/thecodingmachine/safe/generated/array.php with
error_log('-----------------------------------------------------------------------------------------------');
var_export(debug_backtrace(0, 6));

Okay, the tests seems to complain about your changes...
Will there be a new version?

@canvural Could you chime in?

I've made a fix in thecodingmachine/safe, which you will find in this branch: https://github.com/asbiin/safe/tree/enclose-functions

It seems like the autoloading problem is in our side, in Larastan.

Hi,
From the example repo you created, file Test3 passes successfully. So I think this error should be fixed in thecodingmachine/safe not here. If it was an issue with Larastan's autolading stuff, json_encode also would cause problems.

Hi,
From the example repo you created, file Test3 passes successfully. So I think this error should be fixed in thecodingmachine/safe not here. If it was an issue with Larastan's autolading stuff, json_encode also would cause problems.

I'm sorry to comment back on a closed issue, but I believe the issue is on larastan and this issue shouldn't be closed.
I've been debugging it and the problem come from these lines, larastan is checking whether Safe\array is a subclass of Model or Builder using is_subclass_of, unfortunately, the is_subclass_of call with Safe\array, finds the Safe\Array class is not loaded (because it isn't a class, although the file itself with the functions is already loaded) so it triggers the autoloader again, loading the array.php file again and hence causing the error Cannot redeclare Safe\array....
I'm a bit lost on the larastan code so I'm not sure why is trying to check whether Safe\array is a subclass of Model, or how to avoid it, but I do believe the issue is on larastan side. #742 went on the right direction, but I'm not sure what check (if any) can be added to make sure that the string returned by $nameScope->resolveStringName($innerTypeNode->name) is indeed a class, but I know it is being loaded the 2nd time because of that code in larastan.
Maybe the solution comes from finding out why larastan is trying to check Safe\array as a class in the first place, but I'm not that familiar with the code yet. Hope this helps somebody with more knowledge to find a solution.

@j3j5 I added a commit that not uses is_subclass_of Can you try dev-master now?
If it still happens it means it's an issue in either PHPStan or Safe.

Ok, good news, I've found the issue, haha, and it turns out it's either on Safe's side or PHPStan's. It turns out that the PHPDocs on the functions defined on the Safe library use array to specify the param type or return type, and then, PHPStan (or rather, its PHPDocParser) tries to resolve array within the Safe namespace as Safe\array, and since there's a file called array.php that matches the PSR4 spec for a class with that name, it tries to autoload it to see if that's the correct type, but the file is already loaded so the error of "redeclaring" the function gets thrown. That explains why Test.php (which uses openssl_pkcs12_read) and Test2.php (using  dns_get_record()) throw the error but Test3.php (with json_encode()) doesn't, because its PHPDoc does not contain any conflicting type.
Now, using \array as the type for @param or @return on the Safe library fixes this issue, but I have to wonder whether this is a bug on PHPDocParser (unless explicitly defined, it should go for native types first) or not. I can't find anything specific on it but it never occurred to me to use the global namespace for native types on PHPDocs on my own code, but maybe it is the right thing to do. I'm going to suggest that solution on the Safe repo.


Is there any plan to support TFO(TCP Fast Open)?

We already have TLS1.3 with 0-RTT now and if we can use TFO when doing DoH queries, the difference of latency between DoH and traditional UDP will be further reduced. However the standard library of golang doesn't have TFO support by now, while lots of other implements using syscall or setsockopt have been talked by peoples(https://github.com/golang/go/issues/4842). So is there any plan to do our step towards TFO?

Go doesn't support 0-RTT, and this is still being discussed due to security issues.
TFO isn't supported by Go either, and also reduces privacy. If the router strips it, it's useless. If it doesn't, and your public IP address changes (for example if you connect to a VPN), TFO can be used to track all your IP addresses.
Along with reliability issues, TFO, if implemented, will be disabled by default. This is still blocked by Go not supporting it for now.
The best way to reduce latency with traditional UDP is to use traditional UDP :)

FWIW, you can easily enable TFO in go by setting the appropriate setsockopt using the new net.ListenConfig.

PR welcome :)


Incompatible with Composer v2

The latest version of Composer gives a warning that this package soon won't work anymore. The namespace is missing the 'Http' folder in the path.

Deprecation Notice: Class Infinety\Filemanager\Exceptions\InvalidConfig located in ./vendor/infinety-es/nova-filemanager/src/Http/Exceptions/InvalidConfig.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/mampenv/bin/composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201

My bad, I see this is fixed already! Thanks!


ENHANCEMENT add unit tests

closes #1

Current coverage is 0.00%

Branch #7 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


feat: handle pillow images as input

Small fix for avoiding re-reading an image path when you already have it.

thanks

This unfortunately introduces a bug when doing upsample_preds, im_A and im_B will already be a Tensor in this implementation, which means that doing the resizing there gives poor interpolation. I'm reverting this for now and forcing it to be path/str.


Tarpaulin developer wiki feedback

I've started work on a github wiki for tarpaulin https://github.com/xd009642/tarpaulin/wiki/Developers this issue is for any feedback on the content and how helpful it is, missing things, things that need improving and general improvements.
It's still a work in progress but the following checklist shows roughly what's done and pending.
Checklist

[x] Project overview
[ ] Cross platform support overview
[ ] Building other projects

[ ] Some words on using cargo
[ ] Linker arguments

[ ] Source analysis

[ ] Code that should be included but may get missed
[ ] Code that shouldn't be in coverage stats but might mistakenly get added

[ ] Instrumenting code

[ ] Explanation of DWARF
[ ] Usage of tools like objdump to debug issues

[ ] Process tracing

[x] Launching and tracing tests basics
[ ] ptrace and it's difficulties
[ ] Issues or difficulties tarpaulin faces
[x] Breakpoint system
[x] State machine
[ ] Something about decision/condition coverage

[ ] Generating reports - need to assess once #55 is merged in

Questions

How best to advertise wiki?
What information would be most useful?
Is the list of files associated with each section helpful?
What should be the balance of Tarpaulin architecture and design choices versus technology used like ptrace, DWARF, ELF etc.

Missing a closing paren.

Tarpaulin also currently only supports x64 systems to AMD and Intel 64 bit processors. This is due to needing processor specific opcodes to add breakpoints and processor registers - the program counter. However, this in theory wouldn't be a large amount of work. But ptrace support can vary wildly between different operating systems and architectures.

This paragraph is worded a bit awkwardly -- specifically the first couple sentences.

- When one thread stop they all stop
+ When one thread stops they all stop

As well as various lacking punctuation throughout :P

Anywho, overall its pretty descriptive and made of mostly well-formed thoughts that make sense :+1: no major complaints on my end.

Tarpaulin also currently only Dear lord, all I can say is stream of consciousness and rapid editing. Ideas like proof reading and grammar fly out of the window.
Cheers :+1:

Closing due to age and lack of activity/interest-in-wiki


Add license information

Also fixes a few compiler warnings.
Closes #10

Thank you!
Apparently, I have not improved this code in five years. A lot has changed about rust best practice in that time. And I have learned a lot. If you see things that look not right, they're probably wrong. I would love to see them fixed, or discuss why I thought that was the correct way at the time. Let me know how I can be supportive!


Remove ffi module from wasm-opt-cxx-sys

Everything in this can just be defined at the crate level instead.

done


use std::filesystem for framework 2.0

#462 is a great implementation that depends upon platform specific code for filesystem classes (i.e. windowsFileSystem, unixFileSystem class etc).  I would suggest that we can switch to using std::filesystem to provide a common class that takes away the need for platform dependent code.

I like the idea of doing this. The main thing id want to keep is a standard way of defining virtual paths in the project. I guess now we are using c++17 we might be able to use https://en.cppreference.com/w/cpp/filesystem/path
I dont know enough information about this to implement it.
How hard would this be with the current #462? And can #462 merge without this change and the C++17 Filesystem be added as a separate PR?

I think it's fair to do it as a separate PR.  It feels like it's a different task and it depends upon C++17 to get fully merged first so why add an extra hurdle to #462?


plugin issu

i m using unity 4.6.9 i have an issue command invocation failure how can i solve it  the error is
Error building Player: CommandInvokationFailure: Failed to re-package resources. See the Console for details.
D:\adt-bundle-windows-x86_64-20131030\sdk\build-tools\23.0.2\aapt.exe package --auto-add-overlay -v -f -m -J gen -M AndroidManifest.xml -S "res" -I "D:/adt-bundle-windows-x86_64-20131030/sdk/platforms/android-23\android.jar" -F bin/resources.ap_ --extra-packages com.google.unity
stderr[
AndroidManifest.xml:17: error: Error: No resource found that matches the given name (at 'theme' with value '@style/Theme.IAPTheme').
AndroidManifest.xml:19: error: Error: No resource found that matches the given name (at 'value' with value '@integer/google_play_services_version').
]
stdout[
Configurations:
(default)
Files:
drawable\app_icon.png
Src: () res\drawable\app_icon.png
values\strings.xml
Src: () res\values\strings.xml
AndroidManifest.xml
Src: () AndroidManifest.xml
Resource Dirs:
Type drawable
drawable\app_icon.png
Src: () res\drawable\app_icon.png
Type values
values\strings.xml
Src: () res\values\strings.xml
Including resources from package: D:\adt-bundle-windows-x86_64-20131030\sdk\platforms\android-23\android.jar
applyFileOverlay for drawable
applyFileOverlay for layout
applyFileOverlay for anim
applyFileOverlay for animator
applyFileOverlay for interpolator
applyFileOverlay for transition
applyFileOverlay for xml
applyFileOverlay for raw
applyFileOverlay for color
applyFileOverlay for menu
applyFileOverlay for mipmap
Processing image: res\drawable\app_icon.png
(processed image res\drawable\app_icon.png: 94% size of source)
(new resource id app_icon from drawable\app_icon.png #generated)
]

Looks like you are having issues with Resources.
Have you considered using the Jar Resolver?


Fix #2837 - Make it easier to get ParameterInfo/PropertyInfo

For a typical configuration, it's now possible to cast a parameter
descriptor to ControllerParameterDescriptor or
ControllerBoundPropertyDescriptor to access the corresponding reflection
type.

/cc @pranavkm

We're deliberately not changing ActionDescriptor to expose these more specialized types. The top level signatures are supposed to be abstract and free of details like reflection.
I took a look, and didn't see any opportunities to benefit from using these new properties in the existing code without a big perf-focused rewrite. This is here mostly for users.

This is here mostly for users.

I was trying to figure out what the utility for this change was.
:shipit:

Yeah, see the linked bug for an example. I'd think a fair number of users have code like this. It's a nice convenience and eventually we'll get to doing something with perf that will likely benefit from this change.


Any plans for a Android 5.x release?

:grin:

Google provides an official Sketch template for Material Design, or do you mean support for more display densities?
I did start on a 5.x template in the same vein but abandoned it after Google came out with their own. May revive it if you can convince me it's worth pursuing... :wink:

I didn't see that official template from Google. I guess it's better to stick with their template then.
Thanks for this anyway!


Codable improvements for ActorID tags

Enables serializing tags, and paves the way to drop paths

@swift-server-bot test this please

@swift-server-bot test this please

57 failure was which we're trying to investigate; seems to be a race in actor runtime itself, not protecting the actor access...


(feature) 444 pro rata salary

As hiring staff, I can publish pro-rata salary for part time roles, so that I can accurately convey the pay for part time roles

As a job-seeker, I can see the pro-rata salary for a part time roles, so that I have a clear understanding of the pay for that role

list view

post view

post view mobile

create job form

edit job page

edit job form

job review page

Rebased


As a frontend developer I want to be able to delete a certain professional if he wishes to do so

Delete all the data related to this professional, no archive, simply delete.
Keep tags that do not belong to any one professional for the time being.

Elastic part was done w/ #5, KC Part is missing

Keycloak is the leading system. If KC deletion was successful but ES deletion wasn’t, we can do a clean up independent of Humlib backend, maybe as cron job (or similar)


move as much as possible to module docs

What are you wanting to move to the module docs? The readme material?

Some of the readme material. Also move tests to the module docs as well because the work as good examples

I've been wanting to help a bit on the documentation side to clean things up a bit if you're interested. Perhaps by re-organizing the main aspects of the lib?:

Concise with syntax for OK.with.
Concise |> syntax for tagged result pipelines.
Semantic success/failure matching

I say re-organize, because it looks like OK.with could be realllly cool. I love Elixir's pattern matching and Erlang's ok/error tagging idiom. It's just one of those things that makes the language(s) awesome. But in with statements, they become noisy and the noise reduction really makes for better reading, as well as regains precious horizontal real estate. So I would put the OK.with first in the readme (and module docs).
I could just do some stuff for the docs and you could see what you like?

re-organising makes perfect sense. Stuff in the readme is in the order it was created.
I recon just start a PR with the things that seam most important to change and that'll be easiest to discuss around. I have no attachment to the docs as they stand

Taking this out of the README (from the very end)...looks like notes of things todo? But perhaps this is better left in the issue tracker.

Possible extensions to include implementing bind on structs so that errors can be better handled.
Implement a catch functionality for functions that error.
Implement existing monad library protocols so can extend similar DB functionality e.g. slick

this is an open ended issue so will close it and can just tackle PR's on docs for changes as they occur


Add Mocha test framework.

We need Mocha test framework for proper JS Testing.

Mocha framework is already implemented, the real problem is test with coroutines are not working.


iOS Apps Crashes when setting retrier

[ V ] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I distributed an app using Alamofire.
Only few users faced the crash when setting retrier to nil.
What did you expect to happen?
Not crash when setting retrier.
What happened instead?
App crashed.
Alamofire Environment
Alamofire version: 4.8.2
Xcode version: 10.2.1
Swift version: 5.0
Platform(s) running Alamofire: iOS
macOS version running Xcode: 10.14.5
Demo Project
ℹ Please link to or upload a project we can download that reproduces the issue.
crash log attached instead of project.
0	Alamofire	0x000000010137ca48 __swift_destroy_boxed_opaque_existential_0 (in Alamofire) + 4
1	Alamofire	0x00000001013b6d50 outlined assign with take of Alamofire.RequestAdapter? (in Alamofire) + 32
2	Alamofire	0x00000001013ae0f4 Alamofire.SessionManager.retrier.setter : Alamofire.RequestRetrier? (in Alamofire) + 84

Hi @cpromise,
Many users are using retriers without issue. I'd recommend you first check out the documentation, then head over to Stack Overflow and tag alamofire if you are still having issues. We use our GitHub project for bug reports and feature requests.
Best of luck! 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


hextazy: init at 0.2

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

For the license, I have opened an issue upstream as it is unclear : https://github.com/Faelian/Hextazy/issues/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4232

Anything left to change @AndersonTorres ?


'cd' command hangs when 3rd+ level directory does not exist

The 'invalid directory' error is not thrown for directories which do not exist, 3 levels deep plus. Observing the following:
/ ▶ cd /foobar
invalid directory

/ ▶ cd /sys/foobar
invalid directory

/ ▶ cd  /sys/dev/foobar
[ hangs here, no error ]

Another great find. This isn't related to depth as much the special httpfs filesystem mounted at /sys/dev by the dev server. Apparently it doesn't handle non-existent files well.


Add contact page models

Adds models for the contact page.

@akmiller01 - you mentioned that his PR should not go into the add-page-models branch, based on changes being made in #65.
As such, am marking as incomplete for now.


Implement Linear Programming optimisation algorithm for charging schedule optimisation

Fritz. I think this task is completed now. Would you like to close it?


Error message and comment improvements

Inform the user that watches must occur within a watching_widget within error messages.

Thanks a lot, I will review the PR over the weekend
Thomas
Am 29. Juni 2023, 15:49 +0200 schrieb Kevin Chadwick @.***>:

Inform the user that watches must occur within a watching_widget within error messages.
You can view, comment on, or merge this pull request online at:
https://github.com/escamoteur/watch_it/pull/3
Commit Summary
• ce3f334 Error message and comment improvements
• f02ea44 Merge pull request #1 from kevlar700/kevlar700-error-message
File Changes
(1 file)
• M lib/src/watch_it.dart (60)
Patch Links:
• https://github.com/escamoteur/watch_it/pull/3.patch
• https://github.com/escamoteur/watch_it/pull/3.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I know its only a nit but because how PRs work, it would be nice if you could add the small changes

I don't believe I got an email until just now. I shall try to sort this later today.


Issues with Microsoft Natural Keyboard

As per the tutorial:

If you would like to provide a product string, you can run `make; ./list-keyboards' in c_src/mac to list the product strings of all connected keyboards.

I just tried using kmonad with a Microsoft Natural Ergonomic Keyboard 4000 and when I run the above commands to get its name, I see the following in the output: Natural\u00c6 Ergonomic Keyboard 4000. Using that exact string in my .kdb file gives the following error:
kmonad: Parse error at 3:29:
  |
3 |   input (iokit-name "Natural\u00c6 Ergonomic Keyboard 4000")
  |                             ^
unexpected '\'
expecting '"' or literal character

Attaching my keymap for reference. Any assistance you could provide would be appreciated! Thanks again for making a great product!
microsoft-natural-keyboard.kdb.txt

I reckon this is an encoding issue; I reckon the keyboard name does not contain an unprintable character :)

Thank you, any thoughts on how I might be able to get around it?

Try using this character in place of \u00c6:
https://util.unicode.org/UnicodeJsps/character.jsp?a=00C6


fix: image size

Fix the image size
Image animated from invisible to visible

@charleserious It is been approved


AutoPan not working when infowindow opens

I did not set disableAutoPan as input and its not panning to opened infoWindow. Is this a knon issue?

@smgjreinieren works as intended, created a plunker: http://plnkr.co/edit/F5oIDN?p=preview
Feel free to reopen if you still think it's a bug.

The autopan is so minimal is it possible to center the infowindow to the center when clicked?


Fix uploaded blob content different from local file

Purpose

Fix the uploaded file content, as it contains the path to the local file as a string instead of the content of the local file.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check
Verify that the following are valid

Check that local file and downloaded blob file have the same content

I think this should be merged


How many types of coordinates are there in Habitat?

❓ Questions and Help
Hi, can I know how many types of coordinates are there in the Habitat-API/Habita-Sim settings? What is the origin of each coordinate? For origin, I mean the following:

When we consider cartesian, it is x=0, y=0 (position) and theta=0 (orientation)
When we consider polar, it is r=0 (position) and rho=0 (orientation).

Types of Coordinates
Currently, I have found the following types of coordinates in the Point Goal Navigation scenario:

Global coordinate

Not sure where the origin is
For orientation, we have HeadingSensor
For position, it seems like we do not have a sensor. If I want to have access to the global position, do I have to write my own sensor for this?
My understanding is the agent_state generated from Habitat-Sim, which is required by almost all sensors, gives us the global coordinate information. Is this correct?

Episode coordinate

The origin position and heading is defined by the starting point of each episode
For orientation, we have EpisodicCompassSensor
For position, we have EpisodicGPSSensor

Top-down map coordinate

From my understanding based on this, the origin is the top-left corner of the map
Can I know the difference between _ind_x_min, _ind_x_max, and _coordinate_min, _coordinate_max defined in TopDownMap?
Why is COORDINATE_MIN negative? Is it related to the global coordinate's origin? If so, does this mean the origin of the global coordinates is fixed across all scenes?

Definition/Correlation between Coordinate Systems
Besides, I also have a question about the definition of the global and episodic coordinates. Assume we have two points p1 and p2.

From my thinking, the value of each element from p1 and p2 could be changed with a different origin. However, the difference (or vector) between two points, namely p1 - p2, should remain exactly the same no matter what the origin is.
I find this statement holds for orientation. No matter whether p1 and p2 comes from HeadingSensor or EpisodicCompassSensor, p1 - p2 remains the same.
I find this statement does not hold for position. The p1 - p2 depends on whether they are from EpisodicGPSSensor or agent_state.position.

Can I know whether I misunderstand something here?
Thanks!

For polar vs. cartesian, you have 2D cartesian correct, but 2D polar is wrong. (r, rho) defines the position and theta still defines heading/orientation.
For the global coordinate system, the origin is arbitrary as the global coordinate system is defined by the mesh itself and those typically have arbitrary origins.  Yes, if you want global position you have to add something for that.  Global heading and global position really shouldn't be inputs to the agent and thus should be sensors (we should really move the HeadingSensor CC @mathfac @abhiskk).  You are correct about agent state.
For TopDownMap, _ind_x_min and co, you can see how they are computed here: https://github.com/facebookresearch/habitat-api/blob/59228a5e246dccbab4809ed0bcac3218760a365a/habitat/tasks/nav/nav.py#L714-L717
It is simply what part of the map actually has navigable space in it.
COORDINATE_MIN, COORDINATE_MAX are really related to only the grid like coordinate system used for the top-down map as we have to do some shift/scaling to get into a grid-like coordinate system. The global coordinate system is fixed in the sense that every scene has a fixed coordinate system, but the coordinate system in each scene is arbitrary (i.e. the point (0, 0, 0) has no physical or special meaning in each scene).
The episodic coordinate frame specifics both a rotation and translation wrt to the coordinate frame of the scene.  The rotation means that p1 - p2 will change.  ||p1 - p2|| won't change, nor will the angle between them change, etc, but p1 - p2 will.

@erikwijmans Hi, thanks a lot! Yes, I find that I make a mistake that p1 - p2 will indeed change. What will remain the same are || p1 - p2 || and the angel.
A follow-up question to verify that I understand the sensor part correctly. Let's define the local coordinate, whose origin is the agent_state.position and the negative-z axis is the direction the agent faces, namely agent_state.rotation.
When the agent takes an action, if I want to know the position change in the local coordinate, will the following code give me the result?
# agent_state1 is the state before taking action
pos1 = quaternion_rotate_vector(agent_state1.rotation.inverse(), agent_state1.position)

# agent_state2 is the state after taking action
pos2 = quaternion_rotate_vector(agent_state2.rotation.inverse(), agent_state2.position)

local_pos_change = (pos2[0] - pos1[0], - (pos2[-1] - pos1[-1]))

quaternion_rotate_vector is defined as following:
https://github.com/facebookresearch/habitat-api/blob/59228a5e246dccbab4809ed0bcac3218760a365a/habitat/tasks/utils.py#L39

Whoops, apologies, I misread your statement about the agent state.  The agent state does not "gives us the global coordinate information", the state itself is in the global coordinate system for a given scene.  What it does is you you access to information in the global coordinate system.
I don't understand your example. In your example, the difference in local pos would be 0 as, by definition, agent_state1.position == [0, 0, 0] in the coordinate system defined by agent_state1 and similarly for agent_state2.  If you want to compare positions/orientations, it only makes to do so in a common coordinate frame.

Hi, I think there are some misunderstandings between us.

Let us assume we have an env = habitat.Env. I could have agent_state = env._sim.get_agent_state().  My understanding is agent_state will give us position (x, y, z) and orientation theta information w.r.t (x0_global, y0_global, z0_global) and theta0_global.
The aim of defining local coordinate system is that I want to know the distance the agent moves along each axis when enabling actuation noises. For example, when disabling noise, MOVE_FORWARD will give us 0.25m along the negative-z axis and 0m along the x axis. I think these x and z axes are defined locally.
When taking an action, I think the only information we could have from the simulator is the position and orientation changes w.r.t the global coordinate systems. However, the actions, namely MOVE_FORWARD, are defined locally since the concept of FORWARD is local.  What my code wants to do is to compute the changes in local coordinate system from the information of the global coordinate system.

Does this make sense? Thanks

Ah, makes sense.  In order to do what you want, here is how I think about it: The state of the agent at time t can be interpreted as the transformation from a its local coordinate frame to world coordinates.  The delta in position/orientation between two subsequent time steps is the position/orientation of the agent at time t+1 in the local coordinate frame defined by the state at time t.  This can be computed by applying in inverse of the transformation defined by the state at time t to the state at time t+1.
So,

agent_state1 = ... # Agent state at time t
agent_state2 = ... # Agent state at time t+1

state_delta = ... # This is position/orientation of the state at time t+1 in t's coordinates,
# AKA the delta between t and t+1

state_delta.rotation = agent_state1.rotation.inverse() * agent_state2.rotatiton
state_delta.position = (
    quaternion_rotate_vector(
        agent_state1.rotation.inverse(),
        agent_state2.position,
    )
    - quaternion_rotate_vector(
        agent_state1.rotation.inverse(),
        agent_state1.position,
    )
)

We may want to consider writing a utility function for this.
On Sat, May 9, 2020 at 10:25 PM Erik Wijmans<EMAIL_ADDRESS>wrote:

Ah, makes sense. In order to do what you want, here is how I think about
it: The state of the agent at time t can be interpreted as the
transformation from a its local coordinate frame to world coordinates. The
delta in position/orientation between two subsequent time steps is the
position/orientation of the agent at time t+1 in the local coordinate
frame defined by the state at time t. This can be computed by applying in
inverse of the transformation defined by the state at time t to the state
at time t+1.
So,
agent_state1 = ... # Agent state at time t
agent_state2 = ... # Agent state at time t+1
state_delta = ... # This is position/orientation of the state at time t+1 in t's coordinates,# AKA the delta between t and t+1
state_delta.rotation = agent_state1.rotation.inverse() * agent_state2.rotatiton
state_delta.position = (
quaternion_rotate_vector(
agent_state1.rotation.inverse(),
agent_state2.position,
)
- quaternion_rotate_vector(
agent_state1.rotation.inverse(),
agent_state1.position,
)
)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/habitat-api/issues/390#issuecomment-626262763,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPVMX3P2CW4RCDM5SAOMN3RQYGAHANCNFSM4M4Q47WA
.

Ah, makes sense. In order to do what you want, here is how I think about it: The state of the agent at time t can be interpreted as the transformation from its local coordinate frame to world coordinates. The delta in position/orientation between two subsequent time steps is the position/orientation of the agent at time t+1 in the local coordinate frame defined by the state at time t. This can be computed by applying in inverse of the transformation defined by the state at time t to the state at time t+1.
So,
agent_state1 = ... # Agent state at time t
agent_state2 = ... # Agent state at time t+1

state_delta = ... # This is position/orientation of the state at time t+1 in t's coordinates,
# AKA the delta between t and t+1

state_delta.rotation = agent_state1.rotation.inverse() * agent_state2.rotatiton
state_delta.position = (
    quaternion_rotate_vector(
        agent_state1.rotation.inverse(),
        agent_state2.position,
    )
    - quaternion_rotate_vector(
        agent_state1.rotation.inverse(),
        agent_state1.position,
    )
)

@erikwijmans Hi, I totally agree with your logic. I think there is a typo and it should be:
quaternion_rotate_vector(
        agent_state2.rotation.inverse(),
        agent_state2.position,
    )

Another thing is since we the FORWARD is along negative-z, we may need to reverse the sign of delta along z axis. The delta on x axis does not have this problem.

We may want to consider writing a utility function for this.
…
On Sat, May 9, 2020 at 10:25 PM Erik Wijmans @.***> wrote: Ah, makes sense. In order to do what you want, here is how I think about it: The state of the agent at time t can be interpreted as the transformation from a its local coordinate frame to world coordinates. The delta in position/orientation between two subsequent time steps is the position/orientation of the agent at time t+1 in the local coordinate frame defined by the state at time t. This can be computed by applying in inverse of the transformation defined by the state at time t to the state at time t+1. So, agent_state1 = ... # Agent state at time t agent_state2 = ... # Agent state at time t+1 state_delta = ... # This is position/orientation of the state at time t+1 in t's coordinates,# AKA the delta between t and t+1 state_delta.rotation = agent_state1.rotation.inverse() * agent_state2.rotatiton state_delta.position = ( quaternion_rotate_vector( agent_state1.rotation.inverse(), agent_state2.position, ) - quaternion_rotate_vector( agent_state1.rotation.inverse(), agent_state1.position, ) ) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#390 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPVMX3P2CW4RCDM5SAOMN3RQYGAHANCNFSM4M4Q47WA .

@Skylion007 Hi, do I need to send a PR?

That would be very welcome!

No,
quaternion_rotate_vector(
        agent_state1.rotation.inverse(),
        agent_state2.position,
    )

is not a typo.  That is the way to calculate the position of agent_state2 with respect to the coordinate frame defined by agent_state1.

Looks like it is correct in the PR.


get_all_security_groups() doesn't return default SecurityGroup

In http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#default-security-group, AWS states that there is a default SecurityGroup per region in classic.
However, Moto does not seem to report this default securitygroup:
reference boto code:
>>> import boto.ec2
>>>
>>> conn = boto.ec2.connect_to_region('us-east-1')
>>> res = conn.get_all_security_groups()
>>> len(res)
1
>>> print res[0]
SecurityGroup:default

with moto:
>>> import boto.ec2
>>> from moto import mock_ec2
>>>
>>> mock = mock_ec2()
>>> mock.start()
>>> conn = boto.ec2.connect_to_region('us-east-1')
>>> res = conn.get_all_security_groups()
>>> len(res)
0

However, trying to create the default group fails with the error I would expect it the group was already created:
>>> conn.create_security_group(name='default', description='default group')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/gildas/virtenv/env.aws/local/lib/python2.7/site-packages/boto/ec2/connection.py", line 3003, in create_security_group
    SecurityGroup, verb='POST')
  File "/home/gildas/virtenv/env.aws/local/lib/python2.7/site-packages/boto/connection.py", line 1207, in get_object
    raise self.ResponseError(response.status, response.reason, body)
boto.exception.EC2ResponseError: EC2ResponseError: 400 Bad Request
<?xml version="1.0" encoding="UTF-8"?>
  <Response>
    <Errors>
      <Error>
        InvalidGroup.Duplicate
        <Message>The security group 'default' already exists</Message>

      </Error>
    </Errors>
  <RequestID>7a62c49f-347e-4fc4-9331-6e8eEXAMPLE</RequestID>
</Response>

Thank you for reporting this!
Yes, you are correct. We had some code that would create the default group if you asked for it, but that strategy clearly has the flaws you demonstrated here. This should now be fixed with https://github.com/spulec/moto/commit/6c9bba2ca1813e3ff8336b594058115df009486d. Feel free to reopen if it was not sufficient.

Hi, thanks (with a bit of delay due to holidays :))
I haven't been able to test yet, however I've noticed in your diff that your comment for the default group is  'The default security group'.
Not sure if that's always the case or even if it should be raised as a separate issue, but in my case the default group comment is 'default group' instead. I guess that moto's behaviour should mimic the real behaviour and hence have the comment changed to 'default group'?

Yes, updated with https://github.com/spulec/moto/commit/bdfbdd8b1c17f528b0b3fa3a8c6cc2b7fd7406b1. Thanks!


Cluster-autoscaler: more readme

This PR adds some documentation about:

what is the goal of Cluster Autoscaler
when and how ScaleUp is executed
when and how ScaleDown is executed

This change is

recomputing cla status...


verify repo first line

Hi,
I had a problem with my connection and executed a deb-get update and the 01-main.repo got cleared, I am not sure why. To make sure it won't happen again, I added a few lines to reapply the main URL in such case.
And took the opportunity to make sure other repos start with http(s).
Thanks,
Bruno

Yes, 968 solves the same issue


Make build formats dict openly available

Added tests for changed code. No significant changes.

This allows for poetry plugins to easily register custom builders. Small change, I don't see any tests that would be needed for that.

Do you have an example for such a plugin?

Do you have an example for such a plugin?

A plugin for building distro-specific packages (.deb, .rpm) for example.

Probably obsolete if we decide for https://github.com/python-poetry/poetry-core/pull/680#issuecomment-1879031775. I suppose it's better to have an interface for poetry plugins in somewhere in poetry itself instead of poetry-core anyway.


Update to latest keycloak version: 16.1.1

Update to latest keycloak version: 16.1.1
Update wildfly-maven-plugin version to 2.1.0.Final

Hi, @bruce-stewart ! Is there anything else that needs to happen for this version increase other than the pom dependencies? I have the 16.1.1 version of Keycloak and I need this plugin to work, and I'm considering just building this branch locally so I can get the jar asap.


Adds ActiveMQ 5.x transport

Due to popular demand, this adds support for ActiveMQ 5.x.
This is enabled when the env variable ACTIVEMQ_URL is set to a valid
broker. Thanks very much to @IAMTJW for early work towards this change.
To try this change, you can use jitpack https://jitpack.io/#openzipkin/zipkin
Ex.
TAG=activemq-SNAPSHOT
curl -sSL https://jitpack.io/com/github/openzipkin/zipkin/zipkin-server/${TAG}/zipkin-server-${TAG}-exec.jar > zipkin.jar
ACTIVEMQ_URL=tcp://localhost:61616 java -jar zipkin.jar

Supercedes #2466
Fixes #1990

cc @moekelley76 @Shatakshi26 @vlatk0o @thanhct

TODO: I want to try Amazon MQ to see if anything special is required to support this

ZipkinActiveMQPropertiesOverrideTest has wrong words（zapkin ->zipkin）

this is intentional :) to make sure the default can be changed

I was able to connect to AWS MQ like this. I think similar to sqs and elasticsearch, we could add a helper in zipkin-aws to generate the config lines. cc @llinder @devinsba
ACTIVEMQ_URL='failover:(ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-1.mq.ap-southeast-1.amazonaws.com:61617,ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-2.mq.ap-southeast-1.amazonaws.com:61617)' ACTIVEMQ_USERNAME=zipkin ACTIVEMQ_PASSWORD=zipkin12345678 ACTIVEMQ_CONCURRENCY=8 java -jar ./zipkin-server/target/zipkin-server-*exec.jar --logging.level.zipkin2=DEBUG

I'm very confident in this change. I will merge so easier to try from snapshot and will also post a one-off docker image also. Any feedback post-merge is welcome also.

updated instructions on how to test


Order of relation fields influences generated input types

Bug description
When a model has multiple one-to-many relationships to the same model, the generated <ModelName>RelationFilter input type only depends on the first relation field. If the fields differ in nullability, the generated types and the runtime behavior (validation) change depending on the order of those fields.
Minimal schema: https://github.com/tomhoule/-prisma-dmmf-relation-field-ordering-influences-input-type-arity-repro
Clonable repro that shows the problem in TypeScript: https://github.com/aqrln/prisma-relation-filter-input-type-arity-e2e-repro
Real-world schema: https://github.com/prisma/prisma/blob/main/packages/internals/src/tests/fixtures/odoo.prisma
How to reproduce

Clone https://github.com/aqrln/prisma-relation-filter-input-type-arity-e2e-repro
Run npm install && npx prisma generate
Run npx ts-node index.ts or open index.ts in the editor and see that the first and second Prisma queries:

  await prisma.b1.findMany({
    where: {
      brf: {
        is: null,
      },
    },
  });

  await prisma.b1.findMany({
    where: {
      b2rf: {
        is: null,
      },
    },
  });

both type-check while the third and the fourth queries:
  await prisma.b2.findMany({
    where: {
      brf: {
        is: null,
      },
    },
  });

  await prisma.b2.findMany({
    where: {
      b2rf: {
        is: null,
      },
    },
  });

both fail type checking.
This is wrong in half of the cases: the first query incorrectly typechecks although brf is not nullable in the schema, while the fourth query is incorrectly rejected although b2rf relation field is nullable.
The same problems are reproducible with runtime validation when running the script with ts-node-transpile-only and ignoring TypeScript errors because the issue is in the DMMF.
Expected behavior

The first query in the repro should fail type checking and runtime validation
The fourth query in the repro should pass type checking and runtime validation
Generally, order of fields must not change the same input type (and consequently both generated TS types and runtime behaviour)

Prisma information

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlite"
  url      = "file:dev.sqlite"
}

// B1 and B2 are identical except the order of relation fields.

// Nullable field first
model B1 {
  bid  Int  @id
  b2fk Int?
  b2rf A1?  @relation(name: "b1_to_a1_opt", fields: [b2fk], references: [aid])
  bfk  Int
  brf  A1   @relation(fields: [bfk], references: [aid])
}

model A1 {
  aid  Int  @id
  arf  B1[]
  arf2 B1[] @relation("b1_to_a1_opt")
}

// Non-nullable field first
model B2 {
  bid  Int  @id
  bfk  Int
  brf  A2   @relation(fields: [bfk], references: [aid])
  b2fk Int?
  b2rf A2?  @relation(name: "b2_to_a2_opt", fields: [b2fk], references: [aid])
}

model A2 {
  aid  Int  @id
  arf  B2[]
  arf2 B2[] @relation("b2_to_a2_opt")
}

import { PrismaClient } from "@prisma/client";

async function main() {
  const prisma = new PrismaClient();

  await prisma.b1.findMany({
    where: {
      brf: {
        is: null,
      },
    },
  });

  await prisma.b1.findMany({
    where: {
      b2rf: {
        is: null,
      },
    },
  });

  await prisma.b2.findMany({
    where: {
      brf: {
        is: null,
      },
    },
  });

  await prisma.b2.findMany({
    where: {
      b2rf: {
        is: null,
      },
    },
  });
}

void main();

Environment & setup

OS: macOS, Linux
Database: SQLite, PostgreSQL
Node.js version: v19.8.0

Prisma Version
prisma                  : 4.11.0
@prisma/client          : 4.11.0
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 8fde8fef4033376662cad983758335009d522acb (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8fde8fef4033376662cad983758335009d522acb (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.11.0-57.8fde8fef4033376662cad983758335009d522acb
Default Engines Hash    : 8fde8fef4033376662cad983758335009d522acb
Studio                  : 0.483.0

Closing the issue as "Gone away".

I closed the issue as "Not planned" 👍


Ratings count is 0 in the About section

Currently, the app fails to count the number of movies the user has rated. Instead, in the About section, the user is told that they have rated zero movies.

I know this fix is as small as it gets.. I'm trying to get the hang of contributing to OSS before I start trying to make bigger changes. Any sort of guidance as to what the next step would usually be is greatly appreciated. (Should I even make a pull request for something this small? Is there a better way for me to contribute or is opening an issue and linking my fix the best way to do this? Thanks kindly.)
In any case, here's the fix for this:
https://github.com/JKelner/HeirloomRottenTomatoes/commit/0a22333a273aa315ecc2d01a7999b63a71d88801

@JKelner Thank you for even noticing this!  No bug is too small to fix.  Really big thanks for taking the time to informing me and even work on a fix.  I decided to create my own fix because I wanted to do some housekeeping in that same area of the code.  Also see my note on your fork.
I don't know the etiquette of OSS or Github.  I'm just glad for help in any form.


sample: custom checkboxes

ex.

The star rating example is kind of like this. It's just dressed up radio buttons.

closing this as it's already addressed.


Implements Config API

Adds server command to serve Envoy Gateway.
Adds logr logging framework and uses zapr as the default logging implementation.
Adds initial Kubernetes provider implementation.
Adds make target to run EG locally against a k8s cluster.

Signed-off-by: danehans<EMAIL_ADDRESS>

Codecov Report

Merging #146 (e495246) into main (9ed4405) will decrease coverage by 72.30%.
The diff coverage is 24.19%.

@@             Coverage Diff              @@
##              main     #146       +/-   ##
============================================
- Coverage   100.00%   27.69%   -72.31%
============================================
  Files            1        2        +1
  Lines            5       65       +60
============================================
+ Hits             5       18       +13
- Misses           0       46       +46
- Partials         0        1        +1

Impacted Files
Coverage Δ

internal/cmd/server.go
16.07% <16.07%> (ø)

internal/cmd/root.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed4405...e495246. Read the comment docs.

Merging since @youngnick already /approve.


Virus in the package?

Windows Defender found a virus in the package when I tried to download it:
Trojan:Win32/Azden.A!cl

Interestingly, you're not the first one to report this. Seems to be a false positive (if you're in doubt - you can clone the repo and compile the source yourself). I'm trying to contact the Windows Defender team to find out what's going on.

Can you provide the Definition Version of your Windows Defender software? Thanks!

Do you need a more details on this treat from Defender?

That's fine - thanks!

I got an answer from the Windows Defender team:

We have removed the detection. Please follow the steps below to clear cached detection and obtain the latest malware definitions.

Open command prompt as administrator and change directory to c:\Program Files\Windows Defender
Run “MpCmdRun.exe -removedefinitions -dynamicsignatures”

Run “MpCmdRun.exe -SignatureUpdate”

Alternatively, the latest definition is available for download here: https://www.microsoft.com/en-us/wdsi/definitions


chore: bdd-gh-1590247020 to 0.0.1

chore: Promote bdd-gh-1590247020 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Awake's expected behavior like MacOS & Gnome's Caffeine, one-click activation

Description of the new feature / enhancement
I work with multiple OS'es frequently and having this tool as a constant is actually fantastic:
on MacOS I use Caffeine, on Gnome (Linux) as well and I just discovered PowerToys for Windows has it too!
Expected behavior like MacOS & Gnome's Caffeine, one-click activation from the taskbar.
right now the context menu pops up on both mouse buttons, which doesn't make a lot of sense to me.
Scenario when this would be used?
single non-distracting click on the system-tray icon triggers the preferred(configured) awake setting.
Supporting information

https://www.macupdate.com/app/mac/24120/caffeine
https://extensions.gnome.org/extension/517/caffeine/

I agree. It is unnecessarily cumbersome. Left click should turn it on indefinitely, right click should open the context menu for options.


How to use DragFloat3?

There is currently no example of DragFloat3 out in the wild.
The constructor takes a single float, which makes no sense in my eyes if you have 3 float inputs.
So how does it work?

DragFloat3 takes a ref Vector3 which should be fairly self-explanatory. Can you explain more what you’re looking for?

You are absolutely right, I'm not sure how i overlooked this >-<
Sorry for bothering you with that!