Is this framework for unit test only?

This doesn't test actual apps?

@pradgnyak this can test any bot in any environment.
I'm not sure what your question is. I'd be happy to give more insight if you want it

I have installed the package and set the
{
"defaultAddress": {
"id": "0nmmm6f3c5440d2a3494954147fdeda",
"channelId": "console",
"bot": {
"id": "B8G870T1GF:T8XXCKV6M",
"name": "mwtest_bot"
},
"user": {
"id": "U8FPUIT5GE:T8ELLV66M",
"name": "mwtest"
},
"conversation": {
"id": "B8G870T1GF:T8XXCKV6M:D8ED66N0H",
"name": "directmessage"
}
}
}
my test file -
var botbuilder = require('botbuilder');
var IAddress = require('botbuilder').IAddress;
var IMessage = require('botbuilder').IMessage;
var Message = require('botbuilder').Message;
var Prompts = require('botbuilder').Prompts;
var Session = require('botbuilder').Session;
var UniversalBot = require('botbuilder').UniversalBot;
var botTester = require('bot-tester');
// import { IAddress, IMessage, Message, Prompts, Session, UniversalBot } from 'botbuilder';
require('chai');
require('mocha');
var expect = require('chai').describe;
// import { BotTester, TestConnector } from 'bot-tester';
// import { getAdaptiveCard, getAdaptiveCardAttachment, getAdaptiveCardMessage } from './adaptiveCardProvider';
// import { read } from 'fs';
const connector = new botTester.TestConnector();
describe('BotTester', () => {
var bot;
beforeEach(() => {
    // bot = new UniversalBot(connector);
    // var connector = new botbuilder.ChatConnector({
    //     appId: '35fbfc2c-d399-46f3-82b0-f0518218ed0e',
    //     appPassword: 'xokLHPC148$mzzyDGH72##('
    // })
    var connector = new botTester.TestConnector();
    // connector.listen();
    bot = new UniversalBot(connector);
    console.log(bot);
});

it('can handle a single response', () => {
    bot.dialog('/', (session) => {
        session.send('hi!');
    });

    var bt = new botTester.BotTester(bot)
        .sendMessageToBot('Hola!', 'hi!');

    return bt.runTest();
});

});
Result*

mocha test1

BotTester
UniversalBot {
domain: null,
_events: {},
_eventsCount: 0,
_maxListeners: undefined,
name: '',
dialogs: {},
libraries:
{ BotBuilder:
Library {
domain: null,
_events: {},
_eventsCount: 0,
_maxListeners: undefined,
name: 'BotBuilder',
dialogs: [Object],
libraries: {},
actions: [ActionSet],
recognizers: [IntentRecognizerSet],
triggersAdded: false,
_localePath: '/Users/pradgnyakulkarni/mwpk/bottester/node_modules/botbuilder/lib/locale/' } },
actions: ActionSet { actions: {} },
recognizers:
IntentRecognizerSet {
_onEnabled: [],
_onFilter: [],
options:
{ intentThreshold: 0.1,
recognizeOrder: 0,
recognizers: [],
processLimit: 4,
stopIfExactMatch: true },
length: 0 },
triggersAdded: false,
settings:
{ processLimit: 4,
persistUserData: true,
persistConversationData: true },
connectors:
{ '': TestConnector { newConvoCount: 0, onEventHandler: [Function] } },
mwReceive: [],
mwSend: [],
mwSession: [],
_localePath: './locale/' }
1) can handle a single response
0 passing (37ms)
1 failing

BotTester
can handle a single response:
Error: the string "timedout while waiting to receive [\n  "hi!"\n]" was thrown, throw an Error :)
at tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (node_modules/bluebird/js/release/promise.js:512:31)
at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:569:18)
at Promise._settlePromise0 (node_modules/bluebird/js/release/promise.js:614:10)
at Promise._settlePromises (node_modules/bluebird/js/release/promise.js:689:18)
at Async._drainQueue (node_modules/bluebird/js/release/async.js:133:16)
at Async._drainQueues (node_modules/bluebird/js/release/async.js:143:10)
at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/release/async.js:17:14)

npm ERR! Test failed.  See above for more details.

Could you please format your submission and tidy up the code a tad? I'm having some trouble following what you did

what version of the bot-tester framework are you using? Are you running with Node or typescript?

Updated the comment.
I am running with Node,
├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>deduped
├─┬<EMAIL_ADDRESS>

Great catch. Looks like something is wrong with the timeout when it's not set in the config file. I'll have another release out soon to resolve the issue. In the meantime, let me know if throwing int a timeout: <some number> resolves the issue on your end (I'd recommend 500+, its in ms)

I had tried it with timeout too but it resulted in same error.

here's the file I'm running (same as yours, fluff removed)
var botTester = require('bot-tester');
var botbuilder = require('botbuilder');

var UniversalBot = botbuilder.UniversalBot;

require('chai');
require('mocha');

const connector = new botTester.TestConnector();

describe('BotTester', () => {
    var bot;

    beforeEach(() => {
        var connector = new botTester.TestConnector();
        bot = new UniversalBot(connector);
    });

    it('can handle a single response', () => {
        bot.dialog('/', (session) => {
            session.send('hi!');
        });

        return new botTester.BotTester(bot)
            .sendMessageToBot('Hola!', 'hi!')
            .runTest();
    });
});

and the bot-tester.json with it passing
{
    "timeout":1000,
    "defaultAddress": {
        "id": "XXXXXXX",
        "channelId": "console",
        "bot": {
            "id": "XXXXXX:XXXXXX",
            "name": "mwtest_bot"
        },
        "user": {
            "id": "XXXXX:XXXXX",
            "name": "mwtest"
        },
        "conversation": {
            "id": "XXX;XXXX;XXX",
            "name": "directmessage"
        }
    }
}

and the bot-tester.json with it failing
{
    "defaultAddress": {
        "id": "XXXXXXX",
        "channelId": "console",
        "bot": {
            "id": "XXXXXX:XXXXXX",
            "name": "mwtest_bot"
        },
        "user": {
            "id": "XXXXX:XXXXX",
            "name": "mwtest"
        },
        "conversation": {
            "id": "XXX;XXXX;XXX",
            "name": "directmessage"
        }
    }
}

The error message I'm is exactly the same as the one you're getting:
Error: the string "timedout while waiting to receive [\n  \"hi!\"\n]" was thrown, throw an Error :)

Test passes after adding the timeout, but I do not see the interaction on my slack. Where is this request going?

When you say you don't see the interaction on your slack, what are you expecting to see?
botTester.sendMessageToBot mocks any incoming message to the bot. All outgoing messages seen but not intercepted. If you use the ConsoleConnector instead of the TestConnector you will actually see messages that the bot responds with.
The behavior I would expect is only having bot responses being seen on the slack channel. I personally have not tested with a bot out in the wild.
I'm unsure why the messages would not be sent properly. Is no request being sent out? Can you take a snapshot of the messages you're attempting to send?
Try attaching an outgoing listener and see what's actually being sent. Also try with the ConsoleConnector to see if the messages are printed to the console

My test case is
1: Slack user says 'hi'
2. Bot responds with options to the user on Slack
How can I simulate this using bot-tester?
Is there a detailed documentation of all the available methods?

I think the answer you're looking for is:
botTester.sendMessageToBot can take in a string, regex, or an IMessage. To mock the slack channel, you would need to create an IMessage with the same structure that would be seen from a message originating from slack. Currently, there is no built in support for that. You would need to home bake the IMessage structure yourself. I'm guessing it would just be part of the address field. If you're unsure what it would look like, I'd recommend putting in a receive listener and inspecting the structure through a message you manually send through slack.

A possible feature request could be adding functions like sendSlackMessageToBot, though that would take some thought on how to make it work cleanly.

The detailed docs for sendMessageToBot documentation can be found  in the BotTester Framework Docs. It gives a full type definitions along with any typedocs associated with methods, fields, or classes.

As a final note: unless your bot acts differently for messages from slack than it would from other channels, I would recommend you reconsider how you're testing or viewing your testing altogether. This framework is can test a bot in any environment, but only simulate receiving messages (I'm still unsure if it would actually send them out seeing because outgoing message's destination channel shouldn't exist).
tldr; as of this writing, this is good for unit to integration/component level testing

@pradgnyak let me know if this helped or there is more clarity you need. I'd be happy to work with you and extend the existing functionality to suit your needs

Thanks a lot, we have decided to use slack API's for testing since they are exposed and can be used for end to end testing in real environment. If we change our approach I will get in touch with you.


Fixing 32/64 bit issues for vehicle_id

When using this on a 32 bit platform, the response fails to parse vehicle_id when compiles for 32 bit platforms:
panic: json: cannot unmarshal number<PHONE_NUMBER>31 into Go struct field .response.vehicle_id of type int

See https://github.com/jsgoecke/tesla/issues/41

See #41

Oh, thanks!


feat: support material you and dark mode in demo app

#162  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


[6.0 DNM] Empty PR to test WebAssembly

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves #NNNNN, fix apple/llvm-project#MMMMM.

@swift-ci please test WebAssembly

Not finding any job in CI to compare the results I got for https://github.com/apple/swift/pull/73642, so for now kicking a standalone job


Update readme.md

Changes made to the document:
i. Bullet lists.
ii. Caution and notes
iii. Link titles
iv. Simple language
Let me know what you want next.

Many thanks to Rhadiak Kode for these improvements!!!


[WIP] transaction from charm lib to python package

This change represents a transaction from prometheus_scrape charm library
to prometheus-scrape as a python library. This allows the use of the
prometheus-scrape interface for LMA reactive charms instead of using the http
interface and to achieve consistency between the Prometheus charm on
Kubernetes and on machine.

This is a draft as it is a significant change that needs to be properly tested.

I am not sure I understand the scope and goal of this patch. I understand that the goal is to replace the charm library we have today with a Python package, but that is not the standard way of doing libraries for sidecar charms.
Moreover, and changing the relation interface from prometheus_scrape to prometheus-scrape would break every single charm out there that has integrated with COS, and that is not a breaking change we can accept.
As a note: For reactive charms, we have backwards compatibility with LMA relations via https://charmhub.io/cos-proxy .
Happy to discuss the idea further, I have the feeling I am missing something.


_export: docker: supports docker option arguments

Fix https://github.com/treasure-data/digdag/issues/941
Example)
_export:
  docker:
    image: ruby:2.5.1
    build:
      - apt install vim
    docker: /usr/local/bin/nvidia-docker
    run_options: ["-v", "/tmp:/tmp"]
    build_options: ["--pull"]

DESIGN: Note that DockerComandExecutor automatically adds some options of docker, thus, some options may conflict with the default options. But, this PR does not take care of it. Users have to take care of it by seeing DEBUG log.

@sonots Thanks for improving for the flexibility. The feature sounds good to me. Let us take a look the details.

@sonots sorry We don't have much time to take a look this PR but probably update back to you within next week.

@muga I guess enable/disable "options" in system config may be one of the way.

@muga No test exist for docker options currently. I tried to add acceptance tests for docker as I pushed, but I get an error like:
    2019-03-10 00:49:28 +0900 [ERROR] (0037@[0:docker]+docker_build+check_touch) io.digdag.core.agent.OperatorManager: Task failed with unexpected error: java.io.IOException: Cannot run program "docker":
error=2, No such file or directory
    java.lang.RuntimeException: java.io.IOException: Cannot run program "docker": error=2, No such file or directory
        at io.digdag.standards.command.DockerCommandExecutor.buildImage(DockerCommandExecutor.java:194)

although the docker_build.dig works with:
$ digdag run --project digdag-tests/src/test/resources/acceptance/docker docker_build.dig

Could you create a first-step to add tests for docker opitons?

I mean that, if I use docker: /usr/local/bin/docker option which I added with this PR, I can make the acceptance tests work. But, how I can set PATH to digdag server?

BTW, I wondered which spec is better:
    options:
      run: ["-v", "/tmp:/tmp"]
      build: ["--pull"]
      pull: ["--disable-content-trust"]

and
    run_options: ["-v", "/tmp:/tmp"]
    build_options: ["--pull"]
    pull_options: ["--disable-content-trust"]

I changed the spec to the latter version because I felt it makes .dig files shorter most of cases.

@sonots About the option change, I also prefer your change "run_options:" and "build_options:" options instead of generic "options:". simple is good 👍

Could you create a first-step to add tests for _export: docker:?

Yes, let me try adding a simple test do that. Thank you for adding tests anyway.
@yoyama Ah yes, your idea sounds good to me. Let's separate it from this PR and will make improvement on another PR.

Tests have not passed at https://github.com/treasure-data/digdag/pull/1047, how should I proceed with this PR?

@sonots So sorry to my slow progress of the dev on #1047.. we've recognized you're waiting for it. Let me resume it.

@sonots Sorry to be late, I finished creating a simple test on docker-in-docker. Please take a look https://github.com/treasure-data/digdag/pull/1047

@muga Tests passed. PTAL.

@sonots thanks for waiting and adding tests. the change looks good.
@yoyama when you get a chance, please decide to include this in release v0.9.37 or 38.


New design/group page 3

Description
Fixes #...
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
...
Test cases

[ ] Case 1:

Given I am the usual user
When I go to this page
Then I see changed design for tabs and table on current composition section

change switch label: "Display all descendants" -> "All descendants"
as it was before, the default table when arriving on the page should be "users" without descendants

Probably not from this PR but still:

the text is truncated without ways to scroll (should probably go on several lines)
the crown should not be for the member part (probably already fixed)


Color not Dash Output type

The color option is not a Dash Output type. I would like to change the color of the switch depending on the user input. Should I instead use the theme parameter?
The error message I got:
dash.exceptions.IncorrectTypeException: The output argument stop_know.color is not of type dash.Output.
My component:
daq.ToggleSwitch(id='stop_know', value=False, color="#FF5E5E")

Hey @matthijsramlab! Would you be able to post the code that you're using?

Hi, you can close the issue.

Glad you figured it out :)


nullTracers

Checking the cardano-explorer code I found a few nullTracers which should not be in a production code.  This will not allow us to debug the application, and should not be in a production code.

ncSubscription_V1 traces
handshake tracer
mux tracer
chain-sync tracer

I have looked at the ToObjectOrphans.hs module in cardano-node (it has moved to https://github.com/input-output-hk/cardano-node/blob/master/cardano-config/src/Cardano/Tracing/ToObjectOrphans.hs ).
That is 1300 lines of code which I think is rather a lot. That gives me two options, copy/paste it from node which seems insane, or pull in cardano-node as a dependency (db-sync) does not otherwise depend on node (which also seem insane).
Even if I do one of the above, what do I replace the nullTracer with?

Yes, copying all is not good, a long term solution, in my opinion, is to add  cardano-monitoring-framework library which has all the instantiations, and is easily reusable by other clients.

Even if I do one of the above, what do I replace the nullTracer with?
You must have a top level tracer.  It should be general enough to use its contravarince to transform it to the form required by the network tracers. cardano-node does this in Cardano.Tracing.Tracers. Again there's a lot of code, some more specific to the node (e.g. consensus tracers, network tracers for node to node protocols).

There's also work on cli tools, but it lives inside cardano-node.  They should pull it out and set a proper boundaries between clients and the node code.

The current problem we don't know how to debug is:

Proper tracers are in https://github.com/input-output-hk/cardano-db-sync/pull/8 which has not yet been merged due to CI issues.

Still with the proper tracers we couldn't see anything useful in the logs, even if enabled Debug severity (see my branch coot/haskell-updates.  @karknu replaced the logging trace with stdoutTracer and was able to get the information that we needed to debug the connection issue.  This suggest that there's something wrong with the configuration of the loggers.
^ @CodiePP

The tracers fix has been merged to master. Closing this.


Config server client tries localhost:8888 even if URLs are configured

This seems to have started some time in the past week, but I am not 100% sure. I am testing with by pulling down the "main", building it, installing locally, and using 4.0.0-SNAPSHOT in my local client.
In this scenario, configure one of the following ways:

Configure one or more config server URLs under spring.config.import.
Or, set up spring.config.import=configserver: without URLs. Set one or more URLs via spring.cloud.config.uri.

Either of the above scenario produces same issue.
Expected: A spring-cloud-config-client will try connecting only to the configured config server URLs.
Observed: The client will try to connect to the default URL "http://localhost:8888" first.
I have attached a sample IntelliJ project that demonstrates the issue. Due to https://github.com/spring-cloud/spring-cloud-config/issues/2051, if you run this as-is, it won't produce a log file, so you can't see the log showing that it is calling localhost. To observe in the logs, update the uri(s) in the application.yml file to point to a real config server and set the application name, password, etc. so that the server will return a 200 and a log will be produced. I will also attach a sample log file.
Note that I was running with Java 17. (Ignore the name of the file in the zipped project that has "Java8".)
LogFile_CallsLocalhost.txt
ConfigServerClient_CallsLocalhost.zip

@ryanjbaxter Asked me to try 2021.0.1, also. I will see if I can reproduce it that way.

I switched spring-cloud.version to 2021.0.1 and the issue still presented itself.

I'm also seeing this issue. Did you find any resolution?

I'm on 2021.0.3. When defining anything other than the default localhost:8888 using spring.config.import, it calls my specified server, then it calls localhost:8888, which fails and the application will not start up.
application.properties:
spring.application.name=msgw(_)application
spring.config.import=aws-secretsmanager:${ENVIRONMENT}/secret/path,configserver:https://my.server.com
spring.cloud.config.label=${CONFIGURATION_GIT_BRANCH}
spring.cloud.config.username=${username}
spring.cloud.config.password=${password}

Startup logs:
2022-09-01 07:50:58.763 |  | restartedMain | INFO | Fetching config from server at : https://my.server.com | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 07:50:58.763 |  | restartedMain | INFO | Loading secrets from AWS Secret Manager secret with name: dev/secret/path, optional: false | io.awspring.cloud.secretsmanager.AwsSecretsManagerPropertySources | logTo | 255 |
2022-09-01 07:50:58.763 |  | restartedMain | INFO | Fetching config from server at : http://localhost:8888 | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 07:50:58.763 |  | restartedMain | INFO | Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 07:50:58.764 |  | restartedMain | INFO | Fetching config from server at : http://localhost:8888 | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 07:50:58.764 |  | restartedMain | INFO | Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 07:50:58.793 |  | restartedMain | ERROR | Application run failed

POM:
    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.springframework.cloud</groupId>
                <artifactId>spring-cloud-dependencies</artifactId>
                <version>2021.0.3</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>
...
        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-config</artifactId>
        </dependency>

For reference, I posted this question on SO to try and get some answers. https://stackoverflow.com/questions/73570600/spring-cloud-config-client-tries-localhost8888-in-addition-to-my-specified-serv

@ryanjbaxter It's the same example. Using the aws piece or not does not change the behavior.

I'll remove it and test again, and provide the logs.

spring.application.name=msgw(_)application
spring.config.import=configserver:https://sccs-nonprod.gw.dev.hbu.co
spring.cloud.config.label=${CONFIGURATION_GIT_BRANCH}
spring.cloud.config.username=${username}
spring.cloud.config.password=${password}

2022-09-01 10:19:58.418 |  | restartedMain | INFO | Fetching config from server at : https://sccs-nonprod.gw.dev.hbu.co | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.419 |  | restartedMain | INFO | Located environment: name=msgw/application, profiles=[dev], label=prod, version=401ea4bb26f13d49602a30e20997dff088d62934, state=null | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.419 |  | restartedMain | INFO | Fetching config from server at : http://localhost:8888 | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.419 |  | restartedMain | INFO | Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.419 |  | restartedMain | INFO | Fetching config from server at : http://localhost:8888 | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.419 |  | restartedMain | INFO | Connect Timeout Exception on Url - http://localhost:8888. Will be trying the next url if available | org.springframework.cloud.config.client.ConfigServerConfigDataLoader | logTo | 255 |
2022-09-01 10:19:58.453 |  | restartedMain | ERROR | Application run failed

I will need to create a new repo to do this - working out of my enterprise repo that is private. I'm sure I can recreate with a basic setup though.

@ryanjbaxter Well, after I created a small example app, it worked as expected. So now I'm off to determine why my actual client app isn't working.

Seems my issue was trying to import the aws secret needed to access my server in the same spring.config.import config as my config server. So I'll just need to inject the username password a different way. I thought I tested without both imports, but I had to wipe my target directory and repackage for it to work.

OK I am going to close this for now then.

Can you provide an example to reproduce the issue?  If so I will reopen it.

I provided an example in the original post.

Is there a reason why you are using both spring.config.import and spring-cloud-starter-bootstrap?  That is the reason you are seeing the two requests.

You are right. Once I removed that starter, then it called the correct URL. (I had that in there as a relic from testing a change to this project that had to work with the legacy, also. Since it had been working even with the starter for a while during my testing, and then broke one day when I pulled the latest, I hadn't realized the starter was the issue.)
Thanks for the info.

Please note that log4j library allowing to load log4j configuration files from config server has dependency to the bootstrap starter. I don't know why, but I have filed the issue under:
https://github.com/apache/logging-log4j2/issues/2157


[Improve] add cache for docker build CI workflow

Description
No response
InLong Component
Other for not specified component
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

docker cache can not work for the maven docker plugin.


ORC-836: StringGroupFromDoubleTreeReader Use Long toString

What changes were proposed in this pull request?
When converting from Double to String, use the Double class methods directly. Lower overhead of encoding by using ASCII.
Why are the changes needed?
Performance.
How was this patch tested?
No change in functionality.  Use existing unit tests.

@dongjoon-hyun This is a trivial one.  Can you please take a look? Thanks!

@dongjoon-hyun Thanks!!
You are correct, I meant to say "Double" instead of ~Long~
I changed the commit message.
All other instances correctly use the toString instead of valueOf, this was the only one.


Bot triggered twice for the same article

Post

Comment 1
Comment 2

Was the cause of the issue detected? If not, might I suggest validating the post for the AutoTL;DR bot first, before posting?


Cannot reach global context from deeply included template.

Output of helm version:
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}
Linter is enough.
Here is the repo with minimal helm app to reproduce: https://github.com/Antiarchitect/helm-include-bug
deployment.yaml:
{{ include "myapp.deployment" (dict "name" "cloud") }}

_deployment.tpl:
{{- define "myapp.deployment" -}}
apiVersion: apps/v1
kind: Deployment
metadata:
  name: {{ include "myapp.fullname" $ }}-{{ .name }}
  labels:
    {{- include "myapp.labels" $ | nindent 4 }}
spec:
{{- if not $.Values.autoscaling.enabled }}
  replicas: {{ $.Values.replicaCount }}
{{- end }}
  selector:
    matchLabels:
      {{- include "myapp.selectorLabels" $ | nindent 6 }}
  template:
    metadata:
    {{- with $.Values.podAnnotations }}
      annotations:
        {{- toYaml . | nindent 8 }}
    {{- end }}
      labels:
        {{- include "myapp.selectorLabels" $ | nindent 8 }}
    spec:
      {{- with $.Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      serviceAccountName: {{ include "myapp.serviceAccountName" $ }}
      securityContext:
        {{- toYaml $.Values.podSecurityContext | nindent 8 }}
      containers:
        - name: {{ $.Chart.Name }}
          securityContext:
            {{- toYaml $.Values.securityContext | nindent 12 }}
          image: "{{ $.Values.image.repository }}:{{ $.Values.image.tag | default $.Chart.AppVersion }}"
          imagePullPolicy: {{ $.Values.image.pullPolicy }}
          ports:
            - name: http
              containerPort: 80
              protocol: TCP
          livenessProbe:
            httpGet:
              path: /
              port: http
          readinessProbe:
            httpGet:
              path: /
              port: http
          resources:
            {{- toYaml $.Values.resources | nindent 12 }}
      {{- with $.Values.nodeSelector }}
      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with $.Values.affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with $.Values.tolerations }}
      tolerations:
        {{- toYaml . | nindent 8 }}
      {{- end }}
{{- end }}

Linter error:
[ERROR] templates/: template: myapp/templates/deployment.yaml:1:3: executing "myapp/templates/deployment.yaml" at <include "myapp.deployment" (dict "name" "cloud")>: error calling include: template: myapp/templates/_deployment.tpl:5:11: executing "myapp.deployment" at <include "myapp.fullname" $>: error calling include: template: myapp/templates/_helpers.tpl:15:14: executing "myapp.fullname" at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

{{ include "myapp.deployment" (dict "name" "cloud") }}

In your first invocation call, you passed a dictionary to the function. include uses the second argument as the root context for the function's invocation, which is why .Values cannot be accessed.
If you want to have access to other values, you need to pass in either $ or ..

But $ should be always a root context just for such cases - there are plenty examples with range cycle, what is wrong with my case.
I want to move out boilerplate code into myapp.deployment and it uses external templates inside. Why _deployment.tpl sees global context through $ but _helpers.tpl inside of it don't?

what is wrong with my case.

When you call a function, the root scope is modified. This is different from a call to range or with because they change the local scope, not the global scope.
Consider the following python code:
def myfunc():
    i = 1
    for i in range(5, 8):
        print(i)
    myotherfunc(i)

def myotherfunc(i):
    print(i)

myfunc()

If you ran that, you'd get the following output:
5
6
7
7

Notice that the local scope of i was modified in the for loop, and the global scope of myotherfunc was given the value of i. This is identical to your case: you passed a dictionary with one value (name: "cloud") to a function call, and nothing else. The global scope changed to the root of that dictionary.
Hope this helps.

Okay, I see the mechanics, is there any solution to my case, if I want to use a specific set of variables on each _deployment.tpl include? Maybe it is possible to pass variables in some other way to include or merge them in . context? When I tried to pass . as a context to include - I cannot see the variables declared before the include in deployment.yaml

You could try {{ include "myapp.deployment" (dict "name" "cloud" "Values" .Values "Chart" .Chart) }}.

Worked like a charm, added .Release and .Template.
@bacongobbler Thank you so much for your patience!


[BUG]DefaultAzureCredential cache fetch performance

Library name and version
Azure.Identity
Describe the bug
I'm using Azure.Identity to replace all calls in my application to Microsoft.Azure.Services.AppAuthentication which is marked deprecated.
But there is one interesting behavior that I observed. It seems that the time spent on calling DefaultAzureCredential.GetToken is more or less constant. i.e. if I have a slow connection and my initial call to DefaultAzureCredential.GetToken took me 1000ms, that means my following calls will all take 1000ms even if the initial result is cached. I can confirm that the caching is functional(I can still get the token if I disconnect the internet which definitely gives me the cached result.)
This is very different from the behavior of AzureServiceTokenProvider.GetAccessToken from Microsoft.Azure.Services.AppAuthentication library which returns the token immediately once it's cached.
I'm not sure whether this changed behavior is intentional or not. I understand, under certain circumstances, making this process fix-timed may increase the level of security(when some cryptographies are involved), but when the initial call is slow, the time cost to get the cached token is simply too high.
Expected behavior
Described above
Actual behavior
Described above
Reproduction Steps
Described above
Environment
.NET SDK:
Version:   7.0.102
Commit:    4bbdd14480
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22621
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\7.0.102\
Host:
Version:      7.0.2
Architecture: x64
Commit:       d037e070eb

//cc: @schaabs

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

This could depend on which credential you are selecting initially. Would you mind enabling logging to see what is happening?
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/README.md#logging

This could depend on which credential you are selecting initially. Would you mind enabling logging to see what is happening?
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/README.md#logging

[Informational] Azure-Identity: DefaultAzureCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: EnvironmentCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: EnvironmentCredential.GetToken was unable to retrieve an access token. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  Exception: Azure.Identity.CredentialUnavailableException (0x80131500): EnvironmentCredential authentication unavailable. Environment variables are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/environmentcredential/troubleshoot
[Informational] Azure-Identity: ManagedIdentityCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************] MSAL MSAL.NetCore with assembly version '<IP_ADDRESS>'. CorrelationId(********-****-****-****-************)
[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************] === AcquireTokenForClientParameters ===
SendX5C: False
ForceRefresh: False

[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************]
=== Request Data ===
Authority Provided? - True
Scopes - https://database.windows.net/.default
Extra Query Params Keys (space separated) -
ApiId - AcquireTokenForClient
IsConfidentialClient - False
SendX5C - False
LoginHint ? False
IsBrokerConfigured - False
HomeAccountId - False
CorrelationId - ********-****-****-****-************
UserAssertion set: False
LongRunningOboCacheKey set: False
Region configured:

[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************] === Token Acquisition (ClientCredentialRequest) started:
   Scopes: https://database.windows.net/.default
  Authority Host: login.microsoftonline.com
[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************] Authority validation enabled? False.
[Informational] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:21Z - ********-****-****-****-************] Authority validation - is known env? True.
[Informational] Azure-Core: Request [********-****-****-****-************] GET http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=REDACTED
Metadata:REDACTED
x-ms-client-request-id:********-****-****-****-************
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.8.1,(.NET 7.0.2; Microsoft Windows 10.0.22621)
client assembly: Azure.Identity
[Informational] Azure-Core: Request [********-****-****-****-************] exception Azure.RequestFailedException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Http.HttpRequestException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Sockets.SocketException (10051): A socket operation was attempted to an unreachable network.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   --- End of inner exception stack trace ---
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
[Informational] Azure-Core: Request [********-****-****-****-************] retry number 1 took 00.1s
[Informational] Azure-Core: Request [********-****-****-****-************] GET http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=REDACTED
Metadata:REDACTED
x-ms-client-request-id:********-****-****-****-************
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.8.1,(.NET 7.0.2; Microsoft Windows 10.0.22621)
client assembly: Azure.Identity
[Informational] Azure-Core: Request [********-****-****-****-************] exception Azure.RequestFailedException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Http.HttpRequestException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Sockets.SocketException (10051): A socket operation was attempted to an unreachable network.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   --- End of inner exception stack trace ---
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
[Informational] Azure-Core: Request [********-****-****-****-************] retry number 2 took 00.0s
[Informational] Azure-Core: Request [********-****-****-****-************] GET http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=REDACTED
Metadata:REDACTED
x-ms-client-request-id:********-****-****-****-************
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.8.1,(.NET 7.0.2; Microsoft Windows 10.0.22621)
client assembly: Azure.Identity
[Informational] Azure-Core: Request [********-****-****-****-************] exception Azure.RequestFailedException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Http.HttpRequestException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Sockets.SocketException (10051): A socket operation was attempted to an unreachable network.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   --- End of inner exception stack trace ---
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
[Informational] Azure-Core: Request [********-****-****-****-************] retry number 3 took 00.0s
[Informational] Azure-Core: Request [********-****-****-****-************] GET http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=REDACTED
Metadata:REDACTED
x-ms-client-request-id:********-****-****-****-************
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.8.1,(.NET 7.0.2; Microsoft Windows 10.0.22621)
client assembly: Azure.Identity
[Informational] Azure-Core: Request [********-****-****-****-************] exception Azure.RequestFailedException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Http.HttpRequestException: A socket operation was attempted to an unreachable network. (<IP_ADDRESS>:80)
 ---> System.Net.Sockets.SocketException (10051): A socket operation was attempted to an unreachable network.
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   --- End of inner exception stack trace ---
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
[Error] Azure-Identity: False MSAL <IP_ADDRESS> MSAL.NetCore .NET 7.0.2 Microsoft Windows 10.0.22621 [2023-01-31 01:49:26Z - ********-****-****-****-************] Exception type: Azure.Identity.CredentialUnavailableException
---> Inner Exception Details
Exception type: System.AggregateException
---> Inner Exception Details
Exception type: Azure.RequestFailedException
---> Inner Exception Details
Exception type: System.Net.Http.HttpRequestException
---> Inner Exception Details
Exception type: System.Net.Sockets.SocketException

   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
=== End of inner exception stack trace ===

   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
=== End of inner exception stack trace ===

   at Azure.Core.Pipeline.HttpClientTransport.ProcessAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RedirectPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
=== End of inner exception stack trace ===

   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Identity.ManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ImdsManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
=== End of inner exception stack trace ===

   at Azure.Identity.ImdsManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ManagedIdentityClient.AuthenticateCoreAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ManagedIdentityClient.AppTokenProviderImpl(AppTokenProviderParameters parameters)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.SendTokenRequestToProviderAsync(CancellationToken cancellationToken)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.FetchNewAccessTokenAsync(CancellationToken cancellationToken)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.ExecuteAsync(CancellationToken cancellationToken)
   at Microsoft.Identity.Client.Internal.Requests.RequestBase.RunAsync(CancellationToken cancellationToken)
[Informational] Azure-Identity: ManagedIdentityCredential.GetToken was unable to retrieve an access token. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  Exception: Azure.Identity.CredentialUnavailableException (0x80131500): ManagedIdentityCredential authentication unavailable. Multiple attempts failed to obtain a token from the managed identity endpoint.
 ---> System.AggregateException (0x80131500): Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry.
[Informational] Azure-Identity: VisualStudioCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: VisualStudioCredential.GetToken was unable to retrieve an access token. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  Exception: Azure.Identity.CredentialUnavailableException (0x80131500): Process "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\Asal\TokenService\Microsoft.Asal.TokenService.exe" has failed with unexpected error: TS003: Error, TS001: This account<EMAIL_ADDRESS>needs re-authentication. Please go to Tools->Options->Azure Services Authentication, and re-authenticate the account you want to use..
 ---> System.InvalidOperationException (0x80131509): TS003: Error, TS001: This account<EMAIL_ADDRESS>needs re-authentication. Please go to Tools->Options->Azure Services Authentication, and re-authenticate the account you want to use.
[Informational] Azure-Identity: AzureCliCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: AzureCliCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
[Informational] Azure-Identity: DefaultAzureCredential credential selected: Azure.Identity.AzureCliCredential
[Informational] Azure-Identity: DefaultAzureCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
[Informational] Azure-Identity: DefaultAzureCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: AzureCliCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: AzureCliCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
[Informational] Azure-Identity: DefaultAzureCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
1114.7444ms
[Informational] Azure-Identity: DefaultAzureCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: AzureCliCredential.GetToken invoked. Scopes: [ https://database.windows.net/.default ] ParentRequestId:
[Informational] Azure-Identity: AzureCliCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
[Informational] Azure-Identity: DefaultAzureCredential.GetToken succeeded. Scopes: [ https://database.windows.net/.default ] ParentRequestId:  ExpiresOn: 2023-01-31T03:14:45.0000000+00:00
1093.0621ms
Avg: 1103.90325ms

I can see a fallback process here: azure managed identity -> Visual Studio and it ends up using Azure CLI's credential which is not obvious in the log. In subsequent calls to GetToken, such process is omitted and the token is returned straight away from the cache.
But that reminds me, after testing this snippet on one of VMs on Azure I get this:
13.1522ms
0.6221ms
0.1904ms
0.1789ms
0.1625ms
0.1684ms
0.1671ms
0.188ms
0.2454ms
Avg: 1.675ms

Meaning if it's using managed identity provided by Azure then it shouldn't cause any problems.
But I'm still not sure whether this behavior(when using local credential) is expected.


node-sass missing linux-x64 bindings

Summary of issue:
A fresh install of node-sass as a npm dependency (I'm using yarn) results in a failure to be able to actually use the node-sass module, as can be seen below:  node -p "require('node-sass').info" fails.
When reporting an bug, you must provide this information:

NPM version (npm -v): 3.10.9
Node version (node -v): v7.1.0
Node Process (node -p process.versions):

{ http_parser: '2.7.0',
  node: '7.1.0',
  v8: '5.4.500.36',
  uv: '1.10.0',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '51',
  openssl: '1.0.2j',
  icu: '58.1',
  unicode: '9.0',
  cldr: '30.0.2',
  tz: '2016g' }

Node Platform (node -p process.platform): linux
Node architecture (node -p process.arch): x64
node-sass version (node -p "require('node-sass').info"):

/app/webapp/node_modules/node-sass/lib/binding.js:15
      throw new Error(errors.missingBinary());
      ^

Error: Missing binding /app/webapp/node_modules/node-sass/vendor/linux-x64-51/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 7.x

Found bindings for the following environments:
  - OS X 64-bit with Node.js 6.x
  - OS X 64-bit with Node.js 7.x

This usually happens because your environment has changed since running `npm install`.
Run `npm rebuild node-sass` to build the binding for your current environment.
    at module.exports (/app/webapp/node_modules/node-sass/lib/binding.js:15:13)
    at Object.<anonymous> (/app/webapp/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:573:32)
    at Object.Module._extensions..js (module.js:582:10)
    at Module.load (module.js:490:32)
    at tryModuleLoad (module.js:449:12)
    at Function.Module._load (module.js:441:3)
    at Module.require (module.js:500:17)
    at require (internal/module.js:20:19)
    at [eval]:1:1

npm node-sass versions (npm ls node-sass):

<EMAIL_ADDRESS>/app/webapp
`--<EMAIL_ADDRESS>
If you delete this text without following it, your issue will be closed.

This usually happens because your environment has changed since running npm install.
Run npm rebuild node-sass to build the binding for your current environment.

The error message is telling you what happened, and how to fix it

Yes, fixing it is easy and not what this issue is about. But are you saying that "yarn install" is expected to not result in a node-sass that works? I was expecting it work. I think you are saying that the expected way to use node-sass is to include in packages, run install, and the run rebuild to make sure it works? That doesn't sounds right to me...?

Yarn is just calling NPM, so if you're changing OS (likely running this from a container) the behaviour is the same. If you can reproduce this in a clean folder in a reproducable form, then it's something to look at. There are several reports that something in the latest yarn broke some installs, so you might want to read those issues first

Yeah, I've been doing this in a clean container environment. Would you like me to upload a minimal Dockerfile to demo the issue?

Meh, turns out my original Dockerfile was accidentally copying a node-modules directory, so I think you're right, this is not an issue. Keep to closed. Sorry for the noise.


  What's the rationale for throwing away typing on Object.create()?  We have several places that create subtypes via var foo = Object.create(bar).  Now that that's typed as any, it leaves much of our code untyped and breaks downstream typing, as we have noImplicitAny turned on. For instance, this typed fine before but now fails:
    var foo = { prop: [1, 2, 3] },         bar = Object.create(foo);     bar.prop.map(x => x + 1); // fails, as x now has implicit any type


Added HIP_PLATFORM_AMD=1 for non JIT build

This PR is required in addition to https://github.com/microsoft/DeepSpeed/pull/4539 to define HIP_PLATFORM_AMD on ROCm.
This is required for DeepSpeed non-JIT build. For JIT build we have https://github.com/microsoft/DeepSpeed/pull/4570.
This is required for DeepSpeed extensions build in those docker images with PyTorch built before https://github.com/pytorch/pytorch/pull/111975.
cc: @jeffdaily @jithunnair-amd

The PR failure is not due to changes here, and we will get this merged as we get that other issue solved.

Hi @loadams, is this PR ready to be merged? Thanks.

Hi @loadams, is this PR ready to be merged? Thanks.

Yes, we've identified a CI issue that's unrelated we are trying to fix, will have this merged right after that.


System.setProperty("java.io.tmpdir", myTempDirectory); regression in MOE 1.10.0

in java you should be able to set the System property for "java.io.tmpdir"
this works on desktop java and on android, and also used to work fine on MOE 1.9.0
but this seems to be broken on 1.10.0

What exactly is failing?
According to the documentation, some methods that use the tempdir property are not guarantee that System.setProperty for java.io.tmpdir has any effect on them:

A different value may be given to this system property when the Java virtual machine is invoked, but programmatic changes to this property are not guaranteed to have any effect upon the temporary directory used by this method.

Source: https://docs.oracle.com/javase/8/docs/api/java/io/File.html for createTempFile
The change of behaviour you see was introduced by fixing https://github.com/multi-os-engine/multi-os-engine/issues/183
Is there still a use case to set java.io.tmpdir?


WIP: Fix: Fail to access healthz in  Bare Mental Env

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>

/assign @qiujian16

/unassign @qiujian16

It's seems not the root reason of this issue.
/Close


ARROW-9345: [C++][Dataset] Support casting scalars to dictionary scalars

@jorisvandenbossche precisely

@pitrou done, PTAL

The null case doesn't hit the new code here, so I think I'll merge now and add more tests in follow up


Add hook to the top of others hook

Is it possible to add a hook to the top of other hooks? Maybe some hack to do this?

app.hooks might perhaps help depending on the details of your use case. You can check hook.path to see which service is being called. https://docs.feathersjs.com/api/hooks.html#application-hooks
Otherwise you'd have to mess with the interal data of the service object which should be avoided.

Okay, thanks.

Also, if you call app.service('myservice').hooks() again, those hooks will be added after the existing ones.

@daffl Yes, but I need to add them before and that's a problem.

A hook function is a function whose parameter is the hook object. Many of the common hooks are as simple as https://github.com/feathersjs/feathers-hooks-common/blob/master/src/services/set-created-at.js
The combine hook sequentially calls a set of hook function. So its parameters are functions each of which expects the hook object as a parameter. https://docs.feathersjs.com/api/hooks-common.html#combine
You can place a custom hook at the front of the service which mainatins an array of hook functions. You can mutate the array any way you want. Use combine after a mutation to form a callable set of hooks functions.
Your custom function, upon being called by a service, just calls the result of that combine.


add harbor arm base image build step

add step to build base image because there isn't base image in DOCKERHUB.

add step to build base image because there isn't base image in DOCKERHUB.

When you build the harbor arm image locally, the base image is built when each component is built

there is no nedd to build base, close this pr because the new pr https://github.com/goharbor/harbor-arm/pull/39 has do same thing.


[WIP] [SPARK-8673] [launcher] API and infrastructure for communicating with child apps.

This change adds an API that encapsulates information about an app
launched using the library. It also creates a socket-based communication
layer for apps that are launched as child processes; the launching
application listens for connections from launched apps, and once
communication is established, the channel can be used to send updates
to the launching app, or to send commands to the child app.
The change also includes hooks for local, standalone/client and yarn
masters.

Merged build triggered.

Merged build started.

This is a WIP since I still want to have a second look at the API and implementation. Also, I separated things into 3 commits in case people think the change is too large to be reviewed in one shot.

Merged build triggered.

Merged build started.

Test build #35889 has started for   PR 7052 at commit bc7eed8.

Merged build finished. Test FAILed.

Test build #35889 has finished for   PR 7052 at commit bc7eed8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

This patch adds the following public classes (experimental):

Most of those are package-private, seems like the script needs some tweaking.

Merged build triggered.

Merged build started.

Test build #37152 has started for   PR 7052 at commit 9798293.

Merged build triggered.

Test build #37152 timed out     for PR 7052 at commit 9798293     after a configured wait of 175m.

Merged build finished. Test FAILed.

Jenkins retest this please.

Merged build triggered.

Merged build started.

Test build #37237 has started for   PR 7052 at commit 9798293.

Merged build triggered.

Merged build started.

Test build #16 has started for   PR 7052 at commit 9798293.

Test build #16 has finished for   PR 7052 at commit 9798293.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test build #37237 has finished for   PR 7052 at commit 9798293.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #37259 has started for   PR 7052 at commit 27079ec.

Merged build triggered.

Merged build started.

Test build #37277 has started for   PR 7052 at commit 33fdf9a.

Test build #37259 has finished for   PR 7052 at commit 27079ec.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #37277 has finished for   PR 7052 at commit 33fdf9a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Jenkins retest this please.

The last failures seem unrelated, so I'll remove the "WIP" since I think I'm content with the current state of the patch.

Merged build triggered.

Merged build started.

Test build #37297 has started for   PR 7052 at commit 33fdf9a.

Merged build triggered.

Merged build started.

Test build #19 has started for   PR 7052 at commit 33fdf9a.

Test build #19 has finished for   PR 7052 at commit 33fdf9a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #37297 has finished for   PR 7052 at commit 33fdf9a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #38740 has started for   PR 7052 at commit 267501a.

Test build #38740 has finished for   PR 7052 at commit 267501a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38771 has started for   PR 7052 at commit 17697e5.

Test build #38771 has finished for   PR 7052 at commit 17697e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #41383 has started for   PR 7052 at commit 3c78f1c.

Test build #41383 timed out     for PR 7052 at commit 3c78f1c     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41383/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #41459 has started for   PR 7052 at commit 3c78f1c.

Test build #41459 has finished for   PR 7052 at commit 3c78f1c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41459/
Test FAILed.

Merged build finished. Test FAILed.

weird pyspark errors, not sure how they could be related. so, retest this please.

I think now that 1.5 is winding down, it's time to start pinging people directly... @andrewor14 @squito any chance you guys could take a look?

Merged build triggered.

Merged build started.

Test build #41472 has started for   PR 7052 at commit 3c78f1c.

Test build #41472 timed out     for PR 7052 at commit 3c78f1c     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41472/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #41553 has started for   PR 7052 at commit 8d3111b.

Test build #41553 has finished for   PR 7052 at commit 8d3111b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41553/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #41656 has started for   PR 7052 at commit 8608f56.

Test build #41656 has finished for   PR 7052 at commit 8608f56.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41656/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #42143 has started for   PR 7052 at commit e697824.

Merged build triggered.

Merged build started.

Test build #42148 has started for   PR 7052 at commit 6cfef3a.

Test build #42148 has finished for   PR 7052 at commit 6cfef3a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42148/
Test FAILed.

Test build #42143 has finished for   PR 7052 at commit e697824.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42143/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42153 has started for   PR 7052 at commit 3ac46bf.

Test build #42153 has finished for   PR 7052 at commit 3ac46bf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42153/
Test FAILed.

Merged build finished. Test FAILed.

streaming failure. retest this please.

Merged build triggered.

Merged build started.

Test build #42163 has started for   PR 7052 at commit 3ac46bf.

Test build #42163 has finished for   PR 7052 at commit 3ac46bf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42163/
Test FAILed.

again unrelated failures (sadface). retest this please.

Merged build triggered.

Merged build started.

Test build #42173 has started for   PR 7052 at commit 3ac46bf.

Test build #42173 has finished for   PR 7052 at commit 3ac46bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42173/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #42494 has started for   PR 7052 at commit bf92906.

Test build #42494 has finished for   PR 7052 at commit bf92906.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42494/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #42503 has started for   PR 7052 at commit bf92906.

Test build #42503 has finished for   PR 7052 at commit bf92906.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42503/
Test PASSed.

Alright, I think this is in pretty good shape now. Pinging @squito and @andrewor14 again.

lgtm, just some very minor comments

Merged build triggered.

Merged build started.

Test build #43041 has started for   PR 7052 at commit c0a1766.

Test build #43041 has finished for   PR 7052 at commit c0a1766.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43041/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #43065 has started for   PR 7052 at commit 80599a4.

Test build #43065 has finished for   PR 7052 at commit 80599a4.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43065/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #43066 has started for   PR 7052 at commit a7e4d17.

Test build #43066 has finished for   PR 7052 at commit a7e4d17.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43066/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Test build #43093 has started for   PR 7052 at commit a582e12.

Test build #43093 has finished for   PR 7052 at commit a582e12.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43093/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #43098 has started for   PR 7052 at commit a582e12.

Test build #43098 has finished for   PR 7052 at commit a582e12.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43098/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #43298 has started for   PR 7052 at commit 7c53f3d.

Test build #43298 has finished for   PR 7052 at commit 7c53f3d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43298/
Test FAILed.

Merged build finished. Test FAILed.

Test failures seem to be caused by SPARK-10964. I'll rerun the tests once that one is fixed.

Merged build triggered.

Merged build started.

Test build #43335 has started for   PR 7052 at commit 97e5b38.

Test build #43335 has finished for   PR 7052 at commit 97e5b38.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43335/
Test FAILed.

The tests fail because of the netty RPC backend. They pass locally when I revert the default to akka. I'll investigate that before pushing this.

SPARK-10987 is the new bug to watch...

retest this please

Merged build triggered.

Merged build started.

Test build #43404 has started for   PR 7052 at commit 97e5b38.

Test build #43404 has finished for   PR 7052 at commit 97e5b38.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChildProcAppHandle implements SparkAppHandle
abstract class LauncherConnection implements Closeable, Runnable
final class LauncherProtocol
 static class Message implements Serializable
 static class Hello extends Message
 static class SetAppId extends Message
 static class SetState extends Message
 static class Stop extends Message
class LauncherServer implements Closeable
class NamedThreadFactory implements ThreadFactory
class OutputRedirector

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43404/
Test PASSed.

lgtm,  merging to master!


recycled certificates

Description
regenerate the expired CA

Processing this pull request

Pull request rejected by merge tool. Destination branch iso 3 is not a dev branch. Merge tool only supports dev branches as destination. Dev branches are master, iso4, iso3

Processing this pull request

Merged into branches master in 5a89c94b06f13883ec0236509eb7e96435a0f098

Processing #3400.

Processing #3399.


Allow initialization of MeasurementKeys with empty strings

An empty string is still a string and is used occasionally as a
placeholder in user code.  We should support creation of measurement
keys with empty strings.

Question to cirq-maintainers.  Is this sufficient to prevent problems with backward incompatibility or should we roll back instead?

Can you add a reference to the PR that introduced the change so we have it on the record. GitHub will also show this PR to any future viewers of the previous one

The PR introducing this change was intentionally breaking since

There was inconsistency between cirq.measure(q) and cirq.MeasurementGate().on(q) for some qubit q. The former would assign the measurement key q while the latter would have an empty string.
We decided(1, 2) that dynamically remapping empty keys based on what qubits are operated on was not a desirable behavior.

So, either we could keep this inconsistency, change cirq.measure to stop assigning the "default" key or disallow empty keys in MeasurementGate. We went with the last option since it seemed that empty keys are not really much useful in real world circuits and simulations. Since our Results are keyed by a measurement key string, it doesn't seem too radical to make the key argument sort-of required when constructing measurements.

@smitsanghavi At the very least, we have to at least temporarily roll this change back, since a significant amount of internal code uses the empty string as a placeholder for "anonymous" measurements.  If we want to re-break this, we need to migrate that code first.


PHOENIX-7488. Use central repo, not repository.apache.org

What changes were proposed in this pull request?
Remove repository.apache.org definition, to let the build use central repo from super POM.
Please see last item about repository.apache.org at https://infra.apache.org/infra-ban.html.
https://issues.apache.org/jira/browse/PHOENIX-7488
How was this patch tested?
Local build:
$ mvn -DskipTests clean package
...
[INFO] Reactor Summary for Apache Phoenix 5.3.0-SNAPSHOT:
[INFO]
[INFO] Apache Phoenix ..................................... SUCCESS [  0.988 s]
[INFO] Phoenix Hbase 2.6.0 compatibility .................. SUCCESS [ 15.988 s]
[INFO] Phoenix Hbase 2.5.4 compatibility .................. SUCCESS [ 15.753 s]
[INFO] Phoenix Hbase 2.5.0 compatibility .................. SUCCESS [ 26.659 s]
[INFO] Phoenix Hbase 2.4.1 compatibility .................. SUCCESS [ 17.087 s]
[INFO] Phoenix Core Client ................................ SUCCESS [ 34.392 s]
[INFO] Phoenix Core Server ................................ SUCCESS [  3.473 s]
[INFO] Phoenix Core ....................................... SUCCESS [  9.634 s]
[INFO] Phoenix - Pherf .................................... SUCCESS [ 10.289 s]
[INFO] Phoenix - Tracing Web Application .................. SUCCESS [  1.625 s]
[INFO] Phoenix Client Parent .............................. SUCCESS [  0.011 s]
[INFO] Phoenix Client Embedded ............................ SUCCESS [09:16 min]
[INFO] Phoenix Client Lite ................................ SUCCESS [06:08 min]
[INFO] Phoenix Server JAR ................................. SUCCESS [03:06 min]
[INFO] Phoenix Mapreduce .................................. SUCCESS [02:31 min]
[INFO] Phoenix Assembly ................................... SUCCESS [ 11.413 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

@stoty can you please review when you have some time?
Related changes:

https://github.com/apache/phoenix-connectors/pull/149
https://github.com/apache/phoenix-omid/pull/177
https://github.com/apache/phoenix-thirdparty/pull/11

Thanks @richardantal for reviewing and merging the PRs.

Thank you for the fix.


Update manage-sql-server-in-automation.md

Make the sql part on authentication more obviouse

Also why I got
Failed to execute query. Error: '<my object id from step 1>' is not a valid object id for '<my object id from step 1>' or you do not have permission.

@SnehaSudhirG - Can you review the proposed changes?

I sent an email to the content owner today.

#sign-off