Adding Support of Nonblocking socket

Adding support for Nonblocking socketso, pldm will not blocked during
data transfer between host and BMC.

This code is hitting a clang formatting fail in CI:
-    virtual int
-        writeFromMemory(uint32_t /*offset*/, uint32_t /*length*/,
-                        uint64_t /*address*/,
-                        oem_platform::Handler* /*oemPlatformHandler*/,
-                        ResponseHdr& /*responseHdr*/,
-                        sdeventplus::Event& /*event*/)
+    virtual int writeFromMemory(uint32_t /*offset*/, uint32_t /*length*/,
+                                uint64_t /*address*/,
+                                oem_platform::Handler* /*oemPlatformHandler*/,
+                                ResponseHdr& /*responseHdr*/,
+                                sdeventplus::Event& /*event*/)

Also, please provide links to upstream version of this code.


Single-sentence text inference directly using FCGEC-Joint

Hello, I have finished predicting the test set according to the steps you provided, but now I want to predict only one line of text how to do it? Obviously the prediction steps you provided are a bit too responsible, can I just use Forwardl of FCGEC-Joint to fix a single line of text? If so could you please give me an example?

Thank you for your interest in our work. Actually, I have designed a tool (website with server) for error correction in the process of modeling. It may meet your requirements. I will simplify it into a DEMO version and update it in the code. Please keep an eye on our repository.

Ok thanks a lot, looking forward to your subsequent contributions.

Yes, that's what I was looking for, thanks a lot!

：）You're welcome


Close immediately upon backdrop onTap

Is there a setting to make the bottom sheet close immediately when backdrop is tapped?
It seems there is a default delay in the animation when closing.
Opening is much quicker.
Thank you!

I was adding a transform to the backdrop, which seems to have caused the delay.


Update zio, zio-macros, zio-streams, zio-test, ... to 2.0.18

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-macros
dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.2 to 2.0.18
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.0.2).
You might want to review and update them manually.
project/versions.scala

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #235.


Update imports takes too long to show on large projects

From #64986
Repo

With "typescript.updateImportsOnFileMove.enabled": "prompt"
Open VS Code codebase
Open src/vs/base/common/paging.ts
Wait for js/ts intellisense to load
Rename the file

Bug
It takes a long time before we show the update import prompt

Addressed potential cause of this on VS Code side with a87dc2b62f5e271e25d5a885df65a905fb72b989
Looks like there is still a TypeScript issue, or with how we are using the TS server api


Bump Requirement: pyvista >= 0.38.1

This should solve #2500.
To be very safe, someone should check the builded package.

Hello @germa89
Thank you very much for your kind invitation. Yes, I would like to become an external contributor and then recreate my PR as I would certainly contribute patches from time to time.

Hi @beppo-dd
You have been added as external collaborator. You can now open a new PR!


Toggle groups are finicky, and should probably be a different feature entirely.

In the following example:

Example from the spec
in which a panel-set contains multiple panel-tab only one of which can be active at the same time, thanks to the group feature

<panel-set>
  <panel-tab>first tab</panel-tab>
  <panel-card>first panel</panel-card>
  <panel-tab>second tab</panel-tab>
  <panel-card>second card</panel-card>
  ...
</panel-set>
<style>
panel-set {
  /* The common ancestor sets up a group */
  toggle-group: tab;
}
panel-tab {
  /* Each tab creates a sticky toggle
    (so once it’s open, clicking again won’t close it),
    opts into the group,
    and declares itself a toggle activator */
  toggle: tab 1 group sticky;
}
panel-tab:first-of-type {
  /* The first tab also sets its initial state
    to be active */
  toggle: tab 1/1 group sticky;
}
panel-tab:toggle(tab) {
  /* styling for the active tab */
}
panel-card {
  /* cards are hidden by default */
  display: none;
}
panel-card:toggle(tab) {
  display: block;
}
</style>

What happens if the element that is the active toggle gets removed by script? Will this lead to a situation where no panel-card will be opened anymore? This doesn't feel like the right behavior for a tabbed interface.
Similarly, what happens if a new tab and card are inserted as first elements in the panel? The toggle for that new element is supposed to be set as 'active' per the css rule, unactivating the previous tab (I would think).
Based on this and the other issue I plan to file about what I perceive as accessibility issues with the current design, I'm wondering whether it wouldn't make more sense to take an approach where grouped-toggles are no longer allowed, and rather are moved to a different feature, called radio-group.
A radio-group has a name and a selection algorithm (when it's set to default-to-first, the group must always have a :checked radio element, and if no currently eligible element is active, the first such inactive element gets activated on the spot; default-to-last: works similarly but selects the last element in dom order instead; no-default enables a state where no element is selected in the group)
Then the code can be:
panel-set {
    radio-group: tab default-to-first;
}
panel-tab {
    radio-group-element: tab;
}
panel-card {
    display: none;
}
panel-tab:checked {
    /* active state */
}
panel-tab:checked + panel-card {
    display: block;
}

This is, in my opinion, both easier to understand and more semantic.

I supposed that to avoid overloading it, we could decide to rename the :checked pseudo-class above into :radio-active(tab) ☢ or :active-radio(tab) 📻 or something similar

What happens if the element that is the active toggle gets removed by script? Will this lead to a situation where no panel-card will be opened anymore? This doesn't feel like the right behavior for a tabbed interface.

Yes, if you remove the element that is currently active, there won't be any active toggles. This is how radio groups work today, for example. It won't stop you from activating one of the remaining toggles, tho.

Similarly, what happens if a new tab and card are inserted as first elements in the panel? The toggle for that new element is supposed to be set as 'active' per the css rule, unactivating the previous tab (I would think).

It's currently unspecified what happens if a new toggle is created in the group with an active value, and there are several possibilities:

Treat it like it was triggered to the starting value (thus unsetting the existing active toggle)
Simply initialize it as specified without triggering, so there might be multiple active elements until a trigger does come thru and rationalizes the values.
When a new toggle would be part of a group, immediately apply the "only one active" rule as if the element was around for the most recent trigger (thus setting the new toggle to 0).

I suspect (3) is the best way to do this; it feels like the most expected behavior.

I'm wondering whether it wouldn't make more sense to take an approach where grouped-toggles are no longer allowed, and rather are moved to a different feature, called radio-group.

As far as I can tell, this is exactly the same behavior as the toggle-* properties, just renamed and with the currently-unspecified behavior specified in some way. (And note that you still need the toggle-trigger equivalent, too; that's not mentioned in your example.)
The one new feature seems to be the ability to force one toggle to be active, rather than just enforcing that at most one toggle is active. Notably, this is not how radio buttons works, so calling it "radio-*" probably isn't great. ^_^  We could just add this functionality to toggle-group, tho.
Is there any other reason why you think the toggle-group functionality should be moved to a new name, when it still has to exactly duplicate the existing complete set of toggle-* functionality?

You don't need to specify toggle-trigger because an element that is a radio-group-element has a trigger automatically to become the active one once activated, in the current design. The mechanism behind this would be similar to toggle, but cleanly separated so that the semantic defaults make sense for the use case.
That said, my main reason for wanting a separate system is that, from an accessibility point of view, I'm unhappy with the idea to use "heuristics" to define behaviors that are significantly different from one another (toggles vs radio). It is very easy for authors to "update" the system to deal with an exception case ("well, maybe this one should have the value 2 if it's the selected element by default and not by click") and break the accessiblity entirely. I will elaborate this at some point, but I don't have the energy to look up and reference all the ARIA specs, but I eventually will.
For this reason, I would rather have toggles and radios be two different things.
The other reason I would want that, is that it's super confusing to have to set values like 1/1 group sticky. It's not clear what that does, while the behavior that is desired is rather straightfoward. Specifying the fallback algorithm (default-to-first/...) on the element that defines the group is also very logical as a choice, and avoids to write a special rule to select the first default element, that is creating finicky issues later on (yes, we can of course resolve them in some ways, but this is not going to be obvious to authors either).

In more details, I would rather have three interfaces for toggles.

radio-group (or select-group or whatever) where one only needs to define

the group name and element scope
which elements are radio-group-elements
which elements are affected by the tab visibility state

state which is a value that is defined on the root element only, and can be updated by trigger to either

increment the value
decrement the value
set the value
descendants of elements defining a state can have trigger for that state, but it is stored on the root, not on that element.

But I guess my main complain is that a true/false that define a unique (or no) active state is fudamentally different from a system where you can define a value that is non-binary. These things should be exposed with different accessibility values.
In one case, you have a state that is a number; in the other case, you have one element that is the active descendant (or none). It is not just a number, and in fact cannot be.


Predict journals

What is this idea about?
From which data do you plan to predict journals? Note that typically we do have the journal title to start with, although depending on the source of information this string needs to be normalized before it matches an existing journal entry in the journals collection

It's a wild idea we had with Eamonn today to use the system we have to predict journal labels instead of keywords and subject categories that we do right now. We could train it on our corpus (with the normalization if necessary) and deploy a small webservice at CERN for people. It's like a side project though :)

What exactly do you mean by journal labels? Just to fully understand :)

The names of the journals - in any form that we decide on. Basically a user would be able to type in his abstract and we can advise him which journals would be appropriate for his work.

:open_mouth:

My wife tells me that they write abstracts depending on the journal to which they want to submit (e.g. they write abstract in PRL style if needed to submit to PRL), and they submit to a given journal depending on the impact factor... sad but true... On the other hand the project sounds funny. Maybe it can help the physicist to cross check that the journal would be compatible in style.

Yeah, it was just an idea, because we could easily do it using the software we have now. Maybe it could be useful for somebody :) We could also do it for other domains, not only HEP. But not sure if we'll have time for that :)


Refactor DynamoDB Logstore integration tests

Refactor examples/python/dynamodb_logstore.py into storage-dynamodb/integration_tests

Move it to a separate test within run-integration-tests.py

To run the test provide command line argument --run-storage-dynamodb-integration-tests (this runs only the DynamoDB logstore test and none of the other integration tests)

TODO: need to merge #990 into this and adjust code

@allisonport-db - is this good to merge?


How to install Fuse Angular Material template + Laravel

Hello,
It is my first time to use Laravel and AngularJS integration.
This starter is pretty awesome.
Now I bought Fuse Angular Material template and wanna install it.
Could you give any suggestion for this?
I am worried to rebuild my whole structure again after some time.
So before starting, I need support from experienced people.
I wanna make really perfect and secured project using laravel 5.2, angular 1.5.5 with Fuse template, RESTful API, JWT Authentication,...
Thank you very much
Mudin

Hello @Mudin i already did it. First of all you don't need to use the starter project of @jadjoubran but a fresh installation of laravel. Refer to this:  & my old request

Hi Daniel,
I will check it.
Thanks a lot

also if you find a better way let me know.

Daniel,
I didn't get anything in "your old request".
What Ruffles suggested is putting fuse files inside resources/assets/{css or js}.
This is how I am doing now in my project without this starter and without Fuse template.
My gulpfile.js is currently like this:
`elixir(function(mix) {
mix.sass('app.scss');
mix.scripts([
    'app.editor.js',
    'controllers/core.editor.js',
    'controllers/main.editor.js',
    'controllers/vrTour.editor.js',
    'controllers/scene.editor.js',
    'controllers/asset.editor.js',
    'controllers/hotspot.editor.js',
    'controllers/marker.editor.js',
    'services/sceneService.js',
    'directives/myBlur.js',
    'directives/myFocus.js',
], 'public/js/editor.js');

});`
And I think it is not well structured. It would be nice if it is like Fuse or this starter.
Can u share ur gulpfile and file structure?
Thanks

why is this here? this is not a starter issue :S Fuse has his own repository  you should ask this there

Yeah you are right. Sorry.
But I believe that here are more people who are good at laravel and angular integration.
It is not an issue. I just need suggestion

You also have Stack Overflow

Changing the title, won't changue the fact that this shouldn't be here, but okey...
1.- You can use this starter to handle the backend because well this already has JWT although it's really not that hard to implement it on a fresh laravel installation and that's all you need from this starter apparently.
2.- I own Fuse template as well... so i can tell you you don't have to mix them (the starter and the template) that will just complicate things you know? because each one (the starter and the template) hast they're own gulpfiles and bower's dependencies, so just use the template as your front end, all you have to set it's the route to your RESTFUL API.
if you want to complicate.. well you'll have to hack into the code of both the template and the starter to mix the gulp tasks en the bower dependancies, wich in the future when the starter or the template updates, you might have to do all that procces of adjusting the tasks and dependencies.

@flick36,
This is gonna be great help for me.
Thank you very much :)


Make compatible with more recent pyopenssl, #697

I tried to get empire working on Arch and figured instead of using virtualenv or downgrading pyopenssl I'd just use os.urandom instead. Seems to work fine so far with a (PKGBUILD which pulls in pyopenssl 17.3.

Is pyopenssl even used for stuff other than generating pseudo-random data?   If so perhaps we should rely on the OS instead and drop the dependency?

Well, it looks like everything else that's ssl/cryptostuff doesn't seem to be taken from pyopenssl, so it might not even be needed any more at all – but I know little about python, so I might be quite wrong.

@lsfxz everything checks out. Can you re-submit this to dev? I'll merge it then.


⌘+W to close conversation, not whole window on OSX

To be contingent with OSX's standard behavior, ⌘+W should close the active conversation (like clicking on the little grey ╳.
The thing is, this ╳ only appears when you start a new conversation (clicking on the blue notepad or pressing ⌘+N). So to be contingent with messenger's own behavior, this is the only conversation that ⌘+W should be able to close...
So I'm not sure what's the appropriate thing to implement here. It feels like there's a conflict of paradigms.

cmd+w behaviour matches what the native Messages app does — closing a conversation in that is cmd+shift+w.

Is there a way to "close" a conversation? Or is it the same as deleting it?

I think you can only close a new conversation (this doesn't delete it). You get 'new message to ...' and the ╳.

But this only applies to new conversations. I prefer having CMD+W close the window. But we could think about using CMD+Shift+W to close a new conversation. Although this is probably a rarely used feature.

Totally. I'm not even saying I'd use it. It's just for coherence with the OS.

There's precedent in both directions in OS X apps – ⌘+W in Messages closes the entire chat window; ⌘+W in Safari closes the active tab.
I think I like the latter action better: there are no other possible windows available for the Goofy app, and so I can't think of a possible reason why a user would want to close the conversation window. +1 for making ⌘+W close the current conversation and ⌘+Shift+W close the entire window.


Move some of backend to LSTS syntax

LSTS syntax is a lot nicer to read and maintain.

LSTS frontend TODO:
✓ replace String with SmartString in types
✓ replace CString with String in types
✓ parse ascription :: in expression position
✓ parse match expression
✓ parse string destructuring on LHS
✓ parse String literals
parse regular expressions
parse format strings in string literals
✓ parse complex types with <> [] , compounds
✓ parse let bindings
✓ parse comments

PRIORITY ports from LM to LSTS

type system

100% error message coverage with good errors
add support for distinct arity per type Tuple<x,y> vs Tuple<x,y,z>
add support for multipass inference with Algorithm W
add support for corollary functions and guided inference


Publish Docker Container

When the v1 build has stabilized a bit, we might consider publishing a docker container and updating the INSTALL.md.

Evidently there is a bug in Podman that prevents it from building things from a git repo address. Publishing an image would help us build docker-compose.yml files that will run in Podman, so this has been moved up in priority.


Didn't restore after screen is rotated.

It would be better if this work like DialogFragment.

The demo will be cashed when the dialog dismissed,and the logcat print the error:java.lang.NullPointerException
at android.view.View.drawAnimation(View.java:13968).......
at android.os.Looper.loop(Looper.java:136)...
I don't know why, I can't,location the error.

I think you need to do this programmatically, something like:
 // NOTE: I'm not sure if this is a bad practice...

static boolean isDialogShowing = false;

onStart() {
    super.onStart();
    if ( isDialogShowing ) {
        showDialog();
    }
}

showDialog() {
    isDialogShowing = true;

    // Build your dialog here...

    // Whenever you dismiss your dialog, remember to set isDialogShowing to false
}

This would be great! If we can build on top of AlertDialog or Dialog, we could use DialogFragment. Not sure how the animations could still work though.

I've got an idea to make this restorable on restore by building on top of Dialog. This would mean we can use a DialogFragment which would restore the dialog. I'll try an experiment and see if the animations, etc. work still.
What do you think?


Fix nested form data in Snowboard requests

This fix allows nested objects within the request data to be correctly converted to nested form data when sending the request.
Previously, if the data option in a Request contained nested objects or arrays within the data, these were being incorrectly converted to [Array array] or [Object object], as the FormData object would simply convert them to strings. With this fix, we traverse the data structure and ensure that they are given the right key in order to keep the shape of the data in the POST data.

@bennothommo that resolves the issue.
thanks.

@mjauvin when you get a chance, could you give it one more test with the latest changes - I've just simplified the code a little.

@mjauvin when you get a chance, could you give it one more test with the latest changes - I've just simplified the code a little.

Looks good!

@bennothommo I tested with the data structure below:
$this['data'] = [
    'key' => 'value',
    'nested' => [
      'otherKey' => 'other value',
      'secondLevel' => [
        'moreLevels' => [
          'third' => 'third level',
          'thirdObj' => (object)[
            'fourth' => 'fourth level',
          ],
        ],
        'second' => 'second level',
      ],
    ],
];

got the following result from the ajax handler:
[2024-08-13 14:31:12] dev.INFO: Array
(
    [key] => value
    [nested] => Array
        (
            [otherKey] => other value
            [secondLevel] => Array
                (
                    [moreLevels] => Array
                        (
                            [third] => third level
                            [thirdObj] => Array
                                (
                                    [fourth] => fourth level
                                )

                        )

                    [second] => second level
                )

        )

)


New larky sample AES CCM-n-GCM

Python, YAML and larky unit test of AES encryption and decryption in both CCM and GCM modes

Ran the tests locally and everything works 👍 .


Add cookie banner to design system site

Closes https://github.com/alphagov/govuk-design-system/issues/1618
What

Adds the cookie banner component to the design system site
Adds cookie banner JavaScript to control the hiding/showing of the banner; the accept/reject buttons within the banner; the hide button on the confirmation message
Hooks into the cookie helper functions to set and delete cookies according to the user's preference

Cross Browser Testing
✅ IE11
✅ Chrome
✅ Firefox

✅ Safari
✅ Android
✅ iOS
✅ IE10
✅ IE9
✅ IE8
Accessibility Testing
✅ JAWS / Chrome
✅ JAWS / IE 11
✅ NVDA / Firefox 81
✅ NVDA / Chrome 86
✅ Voiceover / Safari (macOS Catalina)
✅ Talkback / Chrome 86 (Android 10)
✅ Windows High Contrast mode

Cumulative Layout Shift (CLS)
I've measured the impact on Cumulative Layout Shift (CLS). This is the scoring system:
Good score: 0-0.1
Needs Improvement: 0.1-0.25
Poor: 0.25+
The current live version of the Design System has a CLS value of 0 on mobile and desktop.
The Netlify preview of this work with the new cookie banner has a CLS value of 0.178 on desktop (needs improvement) and 0.541 on mobile (poor). This was tested using Lighthouse in Chrome dev tools.
I’d be interested to know if anyone has any ideas how we can help reduce this

The current live version of the Design System has a CLS value of 0 on mobile and desktop.
The Netlify preview of this work with the new cookie banner has a CLS value of 0.178 on desktop (needs improvement) and 0.541 on mobile (poor). This was tested using Lighthouse in Chrome dev tools.
I’d be interested to know if anyone has any ideas how we can help reduce this

The only thing I can think of would be to check to see if the cookie banner needs to be displayed in inline JS immediately after the cookie banner in the HTML. However, it looks like we'd end up having to duplicate a lot of code from cookie-functions.js to make that work?

Do we want the cookie banner to be included in the cumulative layout shift metric? If not, we can use a webpagetest script to set the cookies so that the banner doesn't appear:
// Set a cookie on the root speedcurve.com path
setCookie	https://speedcurve.com/	userid=xxxxxxxxxxxx

https://support.speedcurve.com/en/articles/74065-adding-webpagetest-scripts-to-urls
https://support.speedcurve.com/en/articles/1543261-testing-pages-that-require-authentication

@lfdebrux I don't think we'd want to ignore the cookie banner in any metrics as Google now/will soon take CLS into account in page ranking.
@36degrees We can recreate some of the cookie functions, but the tricky bit is the consent cookie version. I think we'd end up storing CONSENT_COOKIE_VERSION in two places (inline, and in cookie-functions.js), which might make it more likely to be missed when we version the banner and the two get out of sync.
We can add something like this as an inline script, which tests that we're 1) not on the /cookies page and 2) the user has no existing consent cookie before showing the banner. This would catch new users to the design system site - CLS should be 0 in those cases (from my testing) - but it wouldn't handle users with outdated consent cookies.
<script>
  var currentPage = window.location.pathname
  var currentConsentCookie = document.cookie.match(new RegExp('(^| )design_system_cookies_policy=([^;]+)'));

  if (currentPage !== "/cookies/" && (!currentConsentCookie)) {
    var cookieBanner = document.querySelector("[data-module='govuk-cookie-banner']")
    cookieBanner.removeAttribute('hidden')
  }
</script>

For context, these are the issues we were seeing in IE8:

document.head is null or not a function
This is happening because IE8 does not support document.head. I've added a commit with a fallback to using document.getElementsByTagName('head')[0]
can't move focus to the control because it is invisible...
This seems like a more tricky issue. From a bit of research it looks like this happens because IE8 (and older versions) are slow to repaint the DOM. So we have some JavaScript to un-hide the confirmation message and then focus it - but because IE is slow to repaint, it thinks we're trying to focus on the confirmation message when it's still hidden.
The popular workarounds (using a timeout, or trying to prompt a quicker DOM refresh by reading a property that would be affected by the visibility change) either didn’t resolve the issue at all or removed the error logged in the console but didn’t visually seem to speed anything up.
I also noticed we see an error from the Google Tag Manager script itself in IE8, which stops it from working. So now I’m wondering if we should just remove the banner from IE8 and under for now until we know if the GTM script actually supports it…

Looks like GTM doesn't officially support Internet Explorer 8: https://support.google.com/tagmanager/answer/4620708?hl=en

January 30, 2018
Tag Manager no longer officially supports container functionality in Microsoft Internet Explorer 8. Containers should load, but there may be inconsistencies in how some triggers and settings behave. Example: Link Click, Form Submit, and History Change triggers that use the Wait for Tags or Check Validation settings may not function as expected.

@hannalaakso I've added a commit to make it clearer that the consent cookie version variable is in global scope, and reference that in cookie-functions.js instead of duplicating it. Unfortunately I can't think of a good way of doing the same for the isValidConsentCookie function - if I go down the route of referencing that in cookie-functions.js instead of duplicating it, it makes it really tricky to test the logic (and I'd be nervous of changing the logic inside the function and not catching it with tests). I've left that as it is for now, but let me know if you want to chat about it.


Add Task.whenAllResult to collect results of multiple parallel tasks

Creates a task that completes when all of the provided tasks are complete.
If none of the tasks faulted and none of the tasks were cancelled, the resulting task will end completed. The result of the returned task will be set to a list containing all of the results of the supplied tasks in the same order as they were provided (e.g. if the input tasks collection contained t1, t2, t3, the output task's result will return an List<TResult> where code list.get(0) == t1.getResult(), list.get(1) == t2.getResult(), and list.get(2) == t3.getResult()}.

Re: Task.whenAllTResult
This seems to make a drastic change to whenAll where we will now keep references to all results until all inner tasks are complete. This would be a problem where we want to launch a bunch of large file downloads where this might now hold all the files in memory until all the tasks complete, when we really just want to write to disk and lose the references to the files as they complete.
It would be better to call whenAll internally from whenAllTResult as opposed to the other way around and construct the result List in the continuation like:
public static Task<List<TResult>> whenAllTResult(final List<Task<TResult>> tasks) {
  return whenAll(tasks).onSuccess(
    // Get the results from tasks and return them in one list.
  );
}

This would prevent holding on to any unwanted references.
Re: Task.whenAllResult
I'm not sure we need this as I don't see many people needing to read the results of many tasks with different types and if they do, they can write one-off code like above. Additionally, it's not part of the .NET spec.
We can remove this and rename Task.whenAllTResult to Task.whenAllResult and simplify our APIs.
Re: AggregateException
I'm sorry about the List vs array change. This has been amended in #47 and it would be great to hear your thoughts on it.

@grantland thanks for the feedback, will remove Task.whenAllResult and the changes to AggregateException and leave those for issue #47
I'll also make the recommend changes to whenAllTResult

@grantland updated

Looks perfect! Once you squash your commits, I'll accept the PR.

Squashed

One comment, otherwise LGTM


Enable data-search-clear intended functionality.

Uses the onclick event for the data-search-clear span to clear the search field value.

Thanks @k00p. I closed it in favor of 797ac73 though.


It seems to have removed Slack from my machine

Is that by design?

Hi, it isn’t specifically designed to remove slack or discord or any IM applications. I’m happy to add them to the whitelist so that they won’t be removed if you run it again.
I was thinking about creating a function that will kind of scan your machine and tell you what might be removed and ask if you want to do a system restore
Sent from my iPhone

On Feb 11, 2019, at 10:52 AM, tolache<EMAIL_ADDRESS>wrote:
Is that by design?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for explaining!

I added Slack to the whitelist.


Eng 2011 Handle Asynchronosly created conda env in UI

Describe your changes and why you are making these changes
This PR adds basic UI changes to render conda env creation status in UI. In this PR we only adds basics to only render the status. In the next milestone (and before releasing the feature), we will add more details to the page as tracked in https://linear.app/aqueducthq/issue/ENG-2027/[m3]-show-more-details-about-conda-creation
Since execStatus is not associated with workflow, we moved previous WorkflowStatus file to execution/chip for better clarity.
Related issue number (if any)
ENG-2011
Loom demo (if any)
https://www.loom.com/share/1dc0308ebeb3416d92cc229f45eaf2c3
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Small design nit: is there a way we can make the "In Progress" bar width be just as wide as the text "In Progress"?

Thanks @agiron123 ! The changes are not finalized, this PR is mainly to set the foundation to render execState for conda integration. In follow up PRs, we will render more details and adjust alignments before we merge everything.
So I think you could proceed with your changes and keep me in the loop, I can try to incorporate with them

Thanks @agiron123 ! The changes are not finalized, this PR is mainly to set the foundation to render execState for conda integration. In follow up PRs, we will render more details and adjust alignments before we merge everything.
So I think you could proceed with your changes and keep me in the loop, I can try to incorporate with them

@likawind Sounds good, I'll let you know when my changes are ready. Should be some time tomorrow.


Dashboard Bind to specifc role

Hi team,
i have a issue , i want to bind my dashboard to specific role rather than giving the ownership to each individual user .
What i want is let say we have a dashboard and i associate this dashboard to some specific role . than that role is automatically created by our custom security manager and role is assigned to him . so that he can view the dashboard.
So that i dont have to manually give access to ownership for that dashboard .
Any help is highly appreciated.

Hi @vbhama21 there is a current proposal for this implementation on: https://github.com/apache/incubator-superset/issues/10408
Feel free to add any comments there.


Is Knex Support outdated?

On the readme it says that it only works through 0.11, but the current version is 0.12.x, I think.

This is true! Thanks for pointing it out. Will update shortly.


$fixtureDataPath should be '@tests/_data' as Codeception does

Codeception sets protected $dataDir = 'tests/_data'; in src/Codeception/Template/Bootstrap.php:
https://github.com/Codeception/Codeception/blob/e3eba4c2bc1bec26c5270a0c780f95ab7ab4ea00/src/Codeception/Template/Bootstrap.php#L13
and yii2-app-basic sets it in codeception.yml:
https://github.com/yiisoft/yii2-app-basic/blob/9245d033e4c1cc41aa1beabcd4564af497535ad0/codeception.yml#L5
but yii2-faker sets $fixtureDataPath as '@tests/unit/fixtures/data':
https://github.com/yiisoft/yii2-faker/blob/bc6238fc7478d0eb252ee7144d98b9c6e732ec55/FixtureController.php#L148
yii2-faker should sets $fixtureDataPath = 'tests/_data', as Codeception does.

Q
A

Yii vesion
2.0.14

PHP version
7.2.2-3+ubuntu16.04.1+deb.sury.org+1

Operating system
Ubuntu 16.04.3 LTS

In the Fixtures section of the guide, the sample code uses codecept_data_dir() function, which returns 'tests/_data' but not 'tests/unit/fixtures/data':
namespace app\tests\unit\models;

use app\tests\fixtures\UserProfileFixture;

class UserProfileTest extends \Codeception\Test\Unit
{
    public function _fixtures()
    {
        return [
            'profiles' => [
                'class' => UserProfileFixture::className(),
                // fixture data located in tests/_data/user.php
                'dataFile' => codecept_data_dir() . 'user.php'
            ],
        ];
    }

    // ...test methods...
}

The more I look into it, the less I think this PR is interesting. IMO, documentation and code from yii2 & yii2-faker is messy about fixtures paths & namespaces. I'm going to close this PR by now and I'll try to prepare another PR which bring some global order.

I closed this issue because I think we'll first try to bring some order to the messy fixtures paths & namespaces.


Buttons not working.

I can't use the buttons on the PS Move controllers when in Steam VR or Beatsaber.
The PS button works to bring up the menu but nothing else.
I've tried reconfiguring with the Steam Key Mapper.

You have pirate beatsaber? Have you tried to play other vr games to test input? (some free like surgeon simulator vr: meet the medic)

The same problem for me i have bought all my games there is not steamvr.settings file to edit and i can't use my controllers ingame in anyway... I can only move them and use the triggers in the steamvrhub like settings not the vr home or other games...


[CBR-374] Simplify CoinSelHardErr

Description
This will make it easier to write instances for CoinSelHardErr.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-374
Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

Merging as none of this touches the wallet integration tests and the failure must be a red herring.
Usual considerations for AppVeyor applies.


chore: 🤖 Add github workflow to check commits for failures

In order to avoid problems like described in #40 about a build breaking. This workflow will run on all pushes to the repo and on incoming pull requests.

@TimMikeladze thanks for your contribution. The main issue with #40 is, that the built dist folder was changed to compiled via tsup. The local storybook built was working.
For this reason I created a local example via NextJS, I have to see if I get it working again (some problem with the yarn link of the project)


feat: :sparkles: Added Loading animation

Added dependency: Spinners
Bumped version
Updated libdtf version
Added test data for large JSON diffs

Source for large_json files: https://microsoftedge.github.io/Demos/json-dummy-data/

Decided not to redistribute the large json examples. Closing PR. Will reopen without that data.


[Relay] Fix typo in parser

Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@MarisaKirisame please restart ci

@vinx13 on it.


The other participant (that does not end the debate) is notified the other player withdrew and is also sent to the view with the list of debate topics.

25a5b1afac0e95d12c269dd1c5e9e1147bc3f467


Fix typos in the document

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/auto-cc

@Fish-pro thanks

/lgtm


Test/duration t [5760]

@laura-eprosima Due to some changes that were merged into master recently, this branch no longer builds. Can you have a look and fix it, please?


nesting {{helper name}} within {} causes parsing error

G'day mate! Thanks for the insanely useful plugin, its awesome!
However I can't get the pascalHelper to add my filename as my CSS class name (CSS Modules), have pictured below. Any suggestions, did I miss something obvious? Appears to be an issue with nesting the helper moustache within another set of curly braces?
Cheers,
Mick

Hmmm, okay, it works with a space added after the helper moustache:

A suggestion! How about allowing use of VSCode user snippets in the template files? e.g. provide a placeholder for snippet names in the templates: {{snippetName: blahblah}}. That way the templates could be made as snippets including the curser positioning functions etc...

Still an issue really... Adding a space before and after the enclosing curly braces does solve the parsing issue however it results in compiled format of className={ styles.FileName } which STANDARD Linting dislikes (and I agree):

Hmm... I will take look over the weekend. We use handlebars internally so if you find a solution related to that it should work here.

On Jun 29, 2018, at 5:32 AM, michaelleone<EMAIL_ADDRESS>wrote:
Still an issue really... Adding a space before and after the enclosing curly braces does solve the parsing issue however it results in compiled format of className={ styles.FileName } which STANDARD Linting dislikes (and I agree):
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

kk will look into it!

Here's the solution: http://handlebarsjs.com/expressions.html#whitespace-control

☝ should do it. The ~ tells it to remove the whitespace the tag is replaced! Gonna close this out.


payload field in pub enum Event appears unused for ConnectionAck, Ping and Pong

This is referring to pub enum Event in src/protocol.rs.


Visualize files revamp

Refactored old visualize files & made them independent of data loaders / utils files, dark/light-mode support

Time-step prediction visualizer takes top-3 most probable character for time-step, generates CTC encoding table, pre-processes "invisible" or unknown characters.

Filter activations visualizer: plots conv layer activations on top of input sample image, plots conv layer activations when provided with a random noise image, accounts for models of different channels / sample image shapes

PDF combiner that creates a single sheet of the created visualizers

vis_arg_parser: used for processing user arguments in the terminal similar to how loghi-htr processes arguments.

README instructions

Changes made


[feat] Add on_before_backward hook

Blocked by https://github.com/PyTorchLightning/pytorch-lightning/pull/8070
What does this PR do?
This PR adds on_before_backward hook and passes only the loss.
The optimizer, optimizer_idx could also be passed along. Any thoughts on this @carmocca @awaelchli ?
Fixes #7789
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Is it not better to call on_before_backward in the training loop directly (instead of plugins) like we do for the on_after_backward? Or is there a blocker?
otherwise LGTM makes sense to include this hook

Is it not better to call on_before_backward in the training loop directly (instead of plugins) like we do for the on_after_backward? Or is there a blocker?
otherwise LGTM makes sense to include this hook

Hey @awaelchli.
Calling on_before_backward in training_loop
Pros:

Simpler and less code

Cons:

When using precision, as a user, I would expect to receive the scaled loss.

IMO, I think this hook should be called right before backward and after any loss transformations.
Best,
T.C

Should we also add it to LightningModule?

The optimizer, optimizer_idx could also be passed along

on_after_backward doesn't include them so let's not include them here. We could do it in a future PR if somebody requests it.

Should we also add it to LightningModule?

The optimizer, optimizer_idx could also be passed along

on_after_backward doesn't include them so let's not include them here. We could do it in a future PR if somebody requests it.

Yes, good idea !

Missing a call here
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/loops/training_batch_loop.py#L570-L571
And a test for it
You can grep all the on_after_backward uses to check if you missed any
Also

Update the hooks section of lightning_module.rst
Add it to the API reference in lightning_module.rst
Add it to the API reference in callbacks.rst

Hey @carmocca,
The call is made inside the precision plugin, so we can capture the loss which is actually used for training.
And there is a test for all deepseed plugin +  normal run.
Best,
T.C

Also maybe pass batch idx just like for after bwd?

Hello @tchaton! Thanks for updating this PR.

In the file pytorch_lightning/callbacks/restart.py:

Line 3:1: E302 expected 2 blank lines, found 1
Line 7:64: W291 trailing whitespace
Line 11:9: W292 no newline at end of file


Dockerfile question

Hi, just want to say I am not familiar with jupyter noebook so this is more of a question than an issue at this point.   Dockerfile build was successful without errors, looks like the default is to 8888.  Able to connect fine,  but it just looks like a blank jupyter instance.   Am I missing something, I was expecting notebooks etc to all be populated, not sure what to expect.  Is there more getting started documentation?

Hello @jasonblanks ! that docker image is to be used with Binder. however, it should work locally too. I believe Binder sets the working directory to HOME/jovyan which has the docs folder in it and in there there are notebooks for each playbook.
I believe, locally, it is setting the working directory to another location. most likely /opt/jupyter/notebooks I believe that is the default directory assigned in the entrypoint script of the JUPYTER BASE image created for OTR. Would you mind sharing logs of the Jupyter server when it initializes. it should tell you which directory is using when being initialized locally.
Thank you @jasonblanks !

Oh yea, definitely need to learn up on  binder & jupyter. I feel like I made this harder than it needed to be.   Just edited the image's /opt/jupyter/scripts/jupyter-cmd.sh to point to '/home/jovyan/docs' below.
NOTEBOOK-JUPYTER-DOCKER-INSTALLATION-INFO] Running Jupyter Type: notebook.. [NOTEBOOK-JUPYTER-DOCKER-INSTALLATION-INFO] Running the following parameters --ip=<IP_ADDRESS> --port=8888 --notebook-dir=/opt/jupyter/notebooks --no-browser --NotebookApp.max_buffer_size=5 36870912 --NotebookApp.base_url=/ [NOTEBOOK-JUPYTER-DOCKER-INSTALLATION-INFO] Starting Jupyter notebook.. [I 17:59:04.362 NotebookApp] Writing notebook server cookie secret to /home/jovyan/.local/share/jupyter/runtime/notebook_cookie_secret [I 17:59:05.526 NotebookApp] JupyterLab extension loaded from /opt/conda/lib/python3.7/site-packages/jupyterlab [I 17:59:05.527 NotebookApp] JupyterLab application directory is /opt/conda/share/jupyter/lab [I 17:59:05.530 NotebookApp] Serving notebooks from local directory: /opt/jupyter/notebooks [I 17:59:05.531 NotebookApp] The Jupyter Notebook is running at: [I 17:59:05.531 NotebookApp] http://1062e7d44996:8888/?token=bad5b1287853e141a21f80840856b [I 17:59:05.531 NotebookApp]  or http://<IP_ADDRESS>:8888/?token=bad5b12878580ce2444d8566e6940c3e141a21f80840856b [I 17:59:05.531 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation). [C 17:59:05.538 NotebookApp]
entrypoint cmd after inspecting the image and EDITING the "/opt/jupyter/scripts/jupyter-cmd.sh"
`
Notebooks Forge script: jupyter-cmd.sh
Notebooks Forge script description: Runs Jupyter type and specific parameters
Notebooks Forge build Stage: Alpha
Author: Roberto Rodriguez (@Cyb3rWard0g)
License: GPL-3.0
NOTEBOOK_INFO_TAG="[NOTEBOOK-JUPYTER-DOCKER-INSTALLATION-INFO]"
NOTEBOOK_ERROR_TAG="[NOTEBOOK-JUPYTER-DOCKER-INSTALLATION-ERROR]"
#JUPYTER_NOTEBOOKS=/opt/jupyter/notebooks
JUPYTER_NOTEBOOKS=/home/jovyan/docs
`

Thank you @jasonblanks !


Accessibility compliance

To be compatible with WCAG 2.0 (Level AA), a few modifications would be welcome:
1-For HTML documents add the lang attribute and a valid ISO-639-1 two letter language code to the opening HTML element. You could edit baseof.html like this:
<!DOCTYPE html>
<html{{if .Site.Language.Lang}} lang="{{ .Site.Language.Lang }}"{{end}}>

2-Add text to the label element of search box. You could edit body-beforecontent.html like this:
        <div class="searchbox">
          <input data-search-input id="search-by" type="text" placeholder="{{T "Search-placeholder"}}" label="{{T "Search-placeholder"}}">

3- Add a label element that surrounds the control's label. You could edit selectnavigation.html like this:
  {{- if .IsSection}}
    <option value="{{ .RelPermalink}}"{{if eq .URL $currentNode.URL}} selected{{end}} label="{{.Title}}">

4- The i element is not handled as well by screen readers as the em and strong elements. Unfortunatly, I haven't found a good solution for this one. Maybe a <span> element?
You can check your template with this site : https://achecker.ca/checker/index.php.

may be worth raising a pull request with these changes...


QR Generator

I want to add QR generator from entered URL and text. Please assign me in this task.

@suvamita issue assigned  ✌


Provider name error

I've added a PR to fix an issue I have seen when saving a composition that contains a provider

Updating CompositionSerializer to handle the PartyIdentified name field as a string rather than DvText
Updating diadem.xml to include provider on an evaluation so the RawJsonTest unmarshall test confirms there is no errors deserialising the provider details

Please don't review this yet, I need to sort out the file cahnges as I only made 2 but I have extra changes in this PR. I'll update once I have resolved it.

Closing this PR as there are unrequired changes in it, planning to open another one


Multicast Ethernet Mask fix

OxmEth Serialize() is fixed to output the correct mask for multicast Ethernet.
Multicast ethernet mask's first octet is copied to all other octets due to hard-coded index. Added unit test and updated the code for the proposed solution.

+1


compilation error on iOS

iOs compiler raise an error
static AblyCodecDecoder readTokenRequest = ^ARTTokenRequest*(NSDictionary *const dictionary) {
    __block NSString *mac = nil;
    __block NSString *nonce = nil;
    __block NSString *keyName = nil;

    ON_VALUE(^(const id value) { mac = value; }, dictionary, TxTokenRequest_mac);
    ON_VALUE(^(const id value) { nonce = value; }, dictionary, TxTokenRequest_nonce);
    ON_VALUE(^(const id value) { keyName = value; }, dictionary, TxTokenRequest_keyName);

    ARTTokenParams *const params = [AblyFlutterReader tokenParamsFromDictionary: dictionary];
    return [[ARTTokenRequest new] initWithTokenParams:params
                                              keyName:keyName
                                                nonce:nonce
                                                  mac:mac];
};

'new' is unavailable in ARTTokenRequest new statement
flutter doctor -v | pbcopy
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.3 20E232 darwin-x64, locale it-IT)
    • Flutter version 1.22.6 at /Users/enrico/development/flutter
    • Framework revision 9b2d32b605 (3 mesi fa), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/enrico/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/enrico/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/enrico/Library/Android/sdk
    • Java binary at: /Users/enrico/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Users/enrico/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (1 available)
    • iPhone di Enrico (mobile) • 2c7ef6d2717ca0247a62685da4612571d1b2f6b4 • ios • iOS 14.5

! Doctor found issues in 1 category.

Thanks @Miamoto-Musashi - this is definitely a mistake at our end. We should be using alloc instead of new, and I'm guessing we've not currently got tests in place that would have revealed this. We'll get this sorted ASAP.

As far as I can tell there are three locations in the codebase that need fixing (new > alloc):
ably-flutter % git grep '\s*new]\s*init'
ios/Classes/codec/AblyFlutterReader.m:    return [[ARTTokenDetails new] initWithToken:token expires:expires issued:issued capability:capability clientId:clientId];
ios/Classes/codec/AblyFlutterReader.m:    ARTTokenParams *const o = [[ARTTokenParams new] initWithClientId: clientId nonce: nonce];
ios/Classes/codec/AblyFlutterReader.m:    return [[ARTTokenRequest new] initWithTokenParams:params

this bug is preventing my delivery, do you have a roadmap?
thanks

Sorry this is blocking you, @Miamoto-Musashi.
I want to get this sorted quickly for you, which should mean within the next 48 hours.
In the meantime, could you perhaps continue testing with basic authentication (i.e. API key from client-side) until this gets addressed?

thanks @QuintinWillison to take into address this, since the app is not compiling I will wait for the next day and start tests.

@Miamoto-Musashi We've pushed to pub.dev so would love to hear if this unblocks you...
https://pub.dev/packages/ably_flutter/versions/1.2.0-preview.2
Thanks. 😁


Angular typescript client generation support for DeepObject

I think the section from /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid
{% elseif parameter.IsDeepObject -%}
must also be added to the typescript version in /src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestUrl.liquid for correct DeepObject suppor.

Deep objects are not yet supported by the TypeScript templates... probably more is needed than just adding this line :-)


refactor!: combine app modules

Combine modules linux-app and windows-app into app to reduce code reuse.

Tests pass 🎉

By merging this, we won't have to maintain duplicate variables, outputs and extension resources for both modules 🙂


a11y: accessibility issue 2026

Description
Update code to make lg, lu, recent bot, notification and save as file selector tables' cell associate with table name. And the cell can only be focused through keyboard operation.
Task Item
Refs #2026

I approve this in general, but I'd really like some feedback about proper table behavior from someone who depends on using a screen-reader. I feel like a good SR should be handling this automatically. That's not a fault of this code, though - just a separate thought.
@beyackle

You can check the info https://github.com/microsoft/BotFramework-Composer/pull/2640 here. @corinagum described a lot about the right behavior.


Add clawback tests

Description
This adds clawback test cases where it shows that the pointer referenced struct and the actual state object have different states.
Running clawback on an actual node, my expectations were that they use account from state, while I confirmed via ctx.Logger that it was somehow using the old pointer referenced account when a msg is sent to the node.

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Closing this PR, adding comments about this in the original PR

Codecov Report

Merging #192 (58e233a) into mattverse/clawback (6836611) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           mattverse/clawback     #192      +/-   ##
======================================================
- Coverage               60.98%   60.98%   -0.01%
======================================================
  Files                     590      590
  Lines                   54383    54383
======================================================
- Hits                    33166    33165       -1
- Misses                  19179    19180       +1
  Partials                 2038     2038

Impacted Files
Coverage Δ

crypto/keys/internal/ecdsa/privkey.go
82.45% <0.00%> (-1.76%)
:arrow_down:

Changing the test cases in a table driven way(would be able to merge with previous tests as well)

Closing this per merge structure plan


How to access scoped services from middleware

Hi all,
I am attempting to implement an authentication middleware. Once the auth is completed, I need to store the user context, such as the token in a scoped service (for later potential usage).
The middleware is a singleton per process, so I shall not resolve scoped services in its constructor (because the scope would then be falsely global).
Hence I attempted to use the FunctionContext to resolve the scoped service:
public class MyMiddleware : ...
{
  public Task Invoke (FunctionContext context, ...)
  {
    context.InstanceServices.GetRequiredService<IUserContext>(); // Builds an instance of the user context for each request
  }
}

This correctly creates an instance for each request. However, a later attempt to inject the context through a constructor creates ANOTHER instance of it:
public class ActiveDirectoryLookup : IActiverDirectoryLookup
{
  public ActiveDirectoryLookup (IUserContext userContext) {... } // Results in **another** instance for the same request
}

Both services are registered with scope, i.e.

  services.AddScoped<IUserContext, UserContext>();
  services.AddScoped<IAzureDirectoryService, AzureActiveDirectoryService>();

The scope however seems to be similar, but different (both are by request, but not equal)

Two questions therefore:

How to access scoped services from middleware (if not through function context)
How to pass data from middleware to a (business service), if a scoped service is not the way?

Aron

This is more a note (as it doesn't seem to relate to my issue, but the following in DefaultFunctionContext is wrong:
public override IServiceProvider InstanceServices
       {
           get
           {
               if (_instanceServicesScope == null)
               {
                   _instanceServicesScope = _serviceScopeFactory.CreateScope();
                   _instanceServices = _instanceServicesScope.ServiceProvider;
               }

               return _instanceServices!;
           }

           set => _instanceServices = value;
       }

If the public setter is used before the getter was used, the assigned value will be ignored and replaced on the get (since internalServicesScope is still null then)

I thinks my issue is not with middleware/ azure functions. The fishy is swimming in dependency injection space.
(I tried to reproduce the case within the middleware example and it was fine!)

@Manthazar I'm assuming you've looked at the sample as a reference and that was working as expected, correct?
From your sample above, can you please clarify:

How you're registering IActiverDirectoryLookup
How you're consuming IActiverDirectoryLookup

If you can have a small repro in a GitHub repo and share that, that would be the best option as it would enable us to take a closer look at your specific scenario.
Thanks!

Yes, I tried to reproduce it in the example and failed. That has led me to the conclusion that the fish is not in Azure Function Worker water.
After that, I had checked the lifetime of that service and it was scoped. Went down the rabbit hole and found that the caller was also scoped, but it has received a service provider supposedly being a singleton (or in different scope) ultimately  turning the cache instance to a singleton.
Anyway, I changed the orchestration in the following to not mess with timelines:
BEFORE: roleProvider (scoped) --> directory-cache (singleton) --> Azure Directory Service (scoped)
AFTER:  roleProvider (scoped) --> directory-lookup mediator (scoped)
                                                    --> On valid cache entries: directory-cache (singleton)
                                                    --> On cache expiration: Azure Directory Service (scoped)

Bottom line is that singletons should never be in the middle of a call chain -only at the end.
It is a bit surprising though that the code works with Azure Function NetCore 3.1 though -there must be some other dark magic* going on.
Sorry for wasting your time!
*The Azure Directory lookup uses there the IHttpContextAccess interface which is no longer available in the new version. That magic is dark because one would like to thing that it should fail for the same/ similar reason, but it doesn't.

No worries! Glad you found the root cause.
One thing that might help identify similar issues in the future is the enablement of scope validation.
Something similar to what is described here


JetBrains: Cody: Overwrite the current line suffix when it's not included in multiline autocomplete

Current Behaviour
https://github.com/sourcegraph/cody/assets/18601388/447a8729-4622-4722-b80c-545a5dee6fc2
The current line suffix is still visible when a multiline autocomplete suggestion is rendered.
Additionally, it is being added after the first line of the auto completion.
Expected behaviour
If the current line suffix is not contained in the multiline completion, we should write over it.
It shouldn't be visible as the autocomplete suggestion is being rendered, and applying it should overwrite it on the spot.

Closing this as wontfix since the agent-powered completions already handle this scenario.


navigator should scroll horizontally, and show both horizontal and vertical scrollbars

MN: I've tried to tweak this in the browser devtools, and it does not appear to be a trivial change. It's not absolutely critical because we can resize the navigator

@liady I'm assigning this to you in the hope that it will be trivial for you (since you actually know about these things :)


Ability to sync filters across multiple report pages

in the same way as sync slicers.

Thanks for your comment, @chrispaquet. This looks like product feedback, rather than documentation feedback. You can submit product feedback or feature ideas by going to Power BI Ideas. You can also engage with the Power BI engineering team by being active in the Power BI Community.


Difficult To Edit Document Link Information When Many Documents Already Added

It is very difficult to edit document links when there are already multiple document links present on an activity as finding the document requiring amendment can be quite confusing. Would it not be easier to list the document links on the main activity screen and then allow the user to select the specific document to edit from the list (or add new)?

Yes, in that case, we need to have this something like transactions with the listing first and then add/edit. Will see if this could be released on the first launch or in later sprints.

This enhancement has been completed. Now the document links are listed like transactions and results. Users will be able to add and edit document links individually.


Bump to go 1.17

Bump to go 1.17, update codegen

Codecov Report

Merging #332 (763a6a7) into main (a3e27bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   80.57%   80.57%
=======================================
  Files          20       20
  Lines         767      767
=======================================
  Hits          618      618
  Misses        135      135
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e27bc...763a6a7. Read the comment docs.

needs rebase

@dprotaso rebaseddddddddd


Module not found: Can't resolve 'async_hooks'

Pretty sure it just needs to be added to package.json

What version of Node.js are you using?

And are you sure that server getters are not used in client components?

Hey @vordgi, my version is Node 18.x

And are you sure that server getters are not used in client components and not assembled into client bundle?

Not end-to-end, but the wrapper of it is used. Here is my setup:
UserProvider.tsx
import createServerContext from 'next-impl-getters/create-server-context';
import { User } from '@/app/_types/types';

export interface UserContextProps {
    children: React.ReactNode;
    initialUser: User;
}

export const UserContext = createServerContext<{ user: User | null }>();

export const UserProvider = ({ children, initialUser }: UserContextProps) => {
    return <UserContext.Provider value={{ user: initialUser }}>{children}</UserContext.Provider>;
};

layout.tsx
const user = await getUser(); // api call

<UserProvider initialUser={user}>

user.ts
import getServerContext from 'next-impl-getters/get-server-context';
import { UserContext } from '@/app/_components/providers/UserProvider';
import { User } from '../_types/types';

export const useUser = (): User | null => {
    const context = getServerContext(UserContext);
    return context ? context.user : null;
};

My actual app pages / components example usage:
const user = useUser();

But these components can be both server or client components. Is that not allowed? And if not, whats the recommended solution to just make one API call getUser(); at the root layout level and retrieve that information across all pages / components?
I guess an alternative not use a provider at all, and just user the same API call in other pages, and just pass user down to all the components that need it. But I am not sure if Next will de-dupe the same API call across different pages / layouts.

Yes. To be honest, I thought a lot about this point - should this work on both the client and the server. But in the end I decide no. It will have a lot of problems, hidden logic and will be difficult to debug.
In your case, you can create both a server context and a client context and work with both of them.
And one more thing - be careful with contexts in layout. It will not be rerendered (next.js specifics) and there may be artifacts that the user has changed/left, but everything in the layout remains unchanged

But I am not sure if Next will de-dupe the same API call across different pages / layouts.
They rewrote fetch for this purpose. That is, fetch is optimized in this regard, but all other solutions are not

They rewrote fetch for this purpose. That is, fetch is optimized in this regard, but all other solutions are not

Thanks, honestly just doing the multiple calls and passing user down sounds easier.

and one more thing - be careful with contexts in layout. It will not be rerendered (next.js specifics) and there may be artifacts that the user has changed/left, but everything in the layout remains unchanged

This is pretty annoying, esp with typical user cookies, but I've been getting around it by doing window.location.reload on login / logout. Is there any better way?

Maybe router.refresh() will work

Maybe router.refresh() will work

Doesn't seem to reload that actual layout though

https://nextjs.org/docs/app/api-reference/functions/revalidatePath#revalidating-a-specific-url this is the best I found, pretty good actually it doesn't turn the page blank momentarily link window.location.reload and it clears a specific layout.tsx

I close the task because there is no error. Thanks for the feedback, I created a new issue to add an example with a provider with client and server contexts (#27)


Fix typo accounTypeRequired to accountTypeRequired

1. Why is this change necessary?
Just a variable with a typo.
2. What does this change do, exactly?
Rename a variable and keep the old one with a deprecation mark.
3. Describe each step to reproduce the issue or behaviour.

Read the code
See the typo

4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Deprecation hint needs to be improved

Hi @JoshuaBehrens,
is there any chance you'll get to this PR any time soon?
This is pending over a month. If you still need time I'd like to close this PR due to inactivity and you are free to create a new one once this is ready slightly_smiling_face
Sunny regards
Pantrtxp

How do proper deprecation comments look like?

Hi @JoshuaBehrens,
so you still need something from us :sweat_smile:
We still need to create a public deprecation workflow. So I guess we'll leave that one pending
sunny regards
Pantrtxp

Thanks @mitelg 👍
Well there are by now some more and different languages in the game than in shopware 5 so I am not sure yet how to write them properly.

you should now squash your commits, otherwise @pantrtxp will complain about that :wink: :smile:

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9565
Please use this issue to track the state of your pull request.

Hey @JoshuaBehrens,
thank you for your contribution! 💙
We've recently merged your changes.

Wohooo 🎉 You're welcome and thanks for merging :shipit:


Composer, not be found in any version.

Running composer require "fintech-fab/laravel-queue-rabbitmq" pulling dev-master but you warn at documentation that not use dev-master.
When trying to pull with "fintech-fab/laravel-queue-rabbitmq": "5.0" it gives error that version not found.It seems 5.0 not presented at packagist nor tagged here yet.
I guess we have to use dev-master?

Yes, 5.0 haven't been tested yet, you may use dev-master on your dev machine, but please do not use it on production. Also, if you will test dev-master, send us the results of everything works properly
Sent from my iPhone

On 14 Feb 2015, at 13:10, Hakan ERSU<EMAIL_ADDRESS>wrote:
Running composer require "fintech-fab/laravel-queue-rabbitmq" pulling dev-master but you warn at documentation that not use dev-master.
When trying to pull with "fintech-fab/laravel-queue-rabbitmq": "5.0" it gives error that version not found.It seems 5.0 not presented at packagist nor tagged here yet.
I guess we have to use dev-master?
—
Reply to this email directly or view it on GitHub.

Thank you @vladimir-yuldashev i'll report issues.


[extractor/kick] Add extractor

kick.com is a twitch.tv clone currently in "beta"
Closes #5722
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Update -- these pages actually exist now:
https://kick.com/privacy-policy
https://kick.com/terms-of-service
It appears the site does actually care about being legitimate

Is this working still. I tried it out today with version 2023.01.02 and get this error
yt-dlp -U

Latest version: 2023.01.02, Current version: 2023.01.02
yt-dlp is up to date (2023.01.02)

yt-dlp https://kick.com/kmack710

[Kick] Setting up session
ERROR: [Kick] kmack710: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

@camjac251 I can't reproduce; it is still working for me. Can you open a site bug issue with a verbose log (the output of yt-dlp -vU https://kick.com/kmack710)?

@bashonly
$ ./yt-dlp https://kick.com/suspendas -vU
[debug] Command-line config: ['https://kick.com/suspendas', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd2508] (zip)
[debug] Python 3.9.2 (CPython x86_64 64bit) - Linux-5.10.0-21-amd64-x86_64-with-glibc2.31 (OpenSSL 1.1.1n  15 Mar 2022, glibc 2.31)
[debug] exe versions: ffmpeg 4.3.5-0, ffprobe 4.3.5-0, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.9.7, certifi-2020.06.20, pyxattr-0.7.2, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1764 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)
[Kick] Setting up session
ERROR: [Kick] suspendas: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
File "./yt-dlp/yt_dlp/extractor/common.py", line 679, in extract
self.initialize()
File "./yt-dlp/yt_dlp/extractor/common.py", line 588, in initialize
self._real_initialize()
File "./yt-dlp/yt_dlp/extractor/kick.py", line 17, in _real_initialize
self._request_webpage(HEADRequest('https://kick.com/'), None, 'Setting up session')
File "./yt-dlp/yt_dlp/extractor/common.py", line 827, in _request_webpage
raise ExtractorError(errmsg, cause=err)

File "./yt-dlp/yt_dlp/extractor/common.py", line 809, in _request_webpage
return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query))
File "./yt-dlp/yt_dlp/YoutubeDL.py", line 3730, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.9/urllib/request.py", line 523, in open
response = meth(req, response)
File "/usr/lib/python3.9/urllib/request.py", line 632, in http_response
response = self.parent.error(
File "/usr/lib/python3.9/urllib/request.py", line 561, in error
return self._call_chain(*args)
File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
result = func(*args)
File "/usr/lib/python3.9/urllib/request.py", line 641, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

I contacted kick several times, they claimed to have added my IP address to the whitelist, and yet I also get a 403 error.

I contacted kick several times, they claimed to have added my IP address to the whitelist, and yet I also get a 403 error.

Does kick.com load in your web browser?

@bashonly I am running yt-dlp on the server, so I only checked in a text browser without JS, which is running cloudflare challange without success.
wget https://kick.com immediately gets 403


Toggleable wildcard permissions

Some people for some reason don't like wildcards, so we should have a way to disable it.

Finished.


Clear Background not working in Board Component

Describe the bug 🐛
A clear and concise description of what the bug is.
In Board Component clear background is not working
To Reproduce
Steps to reproduce the behavior:

Go to 'board'
Click on 'graph background'
Click on 'white background'
See error

Observed behavior
A clear and concise description of what you have observed.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information; delete this section if the issue does not arise on desktop):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information; delete this section if the issue does not arise on smartphones):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I will fix this

Sure i will assign it to you.


Implement swift-metrics

Fixes #3 😄

Awesome work here in general — glad we managed to polish the final bits together during try swift :) I’ll plan to do a full review here during the week 👍

Thanks a lot @ktoso! I’ll take a look ASAP and address your comments!

Also very belated 👍 , thank you @MrLotU !! (And thanks @ktoso + @weissi for the reviews!)


Change to be min and max instead of min_ and max_.

While trying to do min= and max= with the normal Redis client, I noticed this minor issue.  None of the tests use keyword arguments as far as I can tell.

It was easier to apply these changes directly to develop than to merge them because so much has changed.
See 26ab9d559ec87c49c531df4acd4b404eaca223e8


The length annotation behaves wierdly

Describe the Bug
A clear and concise description of what the bug is.
when i add a length annotation:
it has only one length number as below: 57.14

but after refresh the page, there are two lines overlapped as below: 57.1 and 57.14

i use azure health data service to retrieve the data
Steps to Reproduce:

add length annotation
refresh the page

Please use code blocks to show formatted errors or code snippets

The current behavior
show as picture:

The expected behavior
show as picture:

:warning: Reports we cannot reproduce are at risk of being marked stale and
closed. The more information you can provide, the more likely we are to look
into and address your issue.

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


updates for flutter 3.0.0

Thanks this looks good. will run it then merge

any updates on this?

any update

@cmdrootaccess It would be nice to merge the changes


Could not load package kylekatarnls/update-helper

composer install
[15.5MiB/0.02s] Loading composer repositories with package information
[20.8MiB/1.56s] Updating dependencies (including require-dev)
[RuntimeException]
Could not load package kylekatarnls/update-helper in http://repo.packagist.org: [UnexpectedValueException] Could not parse version constraint ^2.0.x-dev: Invalid version string "^2.0.x-dev"
[UnexpectedValueException]
Could not parse version constraint ^2.0.x-dev: Invalid version string "^2.0.x-dev"

See #9. Thanks.


Add factors list to Field object, representing the strength factor on each coupled level pair.

This is to be used for adding angular momentum structure. In the case that no factors are passed, the factors should be ones.

[x] Add to get_json_dict()
[x] Add to attributes in docstring
[x] Add to init
[x] Add to __repr


Don't allow answer without RemoteDescription

Resolves #563

Pull Request Test Coverage Report for Build 2756

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 80.539%

Totals

Change from base Build 2752:
0.01%

Covered Lines:
3166

Relevant Lines:
3931

💛  - Coveralls

LGTM


Emulator's ChainState produces an EmulatorState with empty WalletState Map

Summary
Using the Emulator's ChainState to produce an EmulatorState results in an empty WalletState Map. This is probably minor because there is agentState for this purpose, but still good to investigate.
Steps to reproduce the behavior
There is a commented out test to recreate this bug, see here. Please re-enable once fixed.
Actual Result
let trace :: Trace.EmulatorTrace () = do
        thisChainState <- Trace.chainState
        let traceBlockchain = thisChainState ^. chainNewestFirst
            traceEmulatorState = emulatorState traceBlockchain
            walletStateMap = traceEmulatorState ^. walletStates
            w1State = fromJust $ M.lookup w1 walletStateMap -- Fails here: Maybe.fromJust: Nothing

Expected Result
It is possible to get all TxOutRef for any wallet from Trace's ChainState.
Describe the approach you would take to fix this
No response
System info
https://github.com/input-output-hk/plutus-apps/commit/a8540dbc92ecf5e6883eb30e3c47efab3f35b446

Indeed emulatorState only recreates the chainState of an EmulatorState. Its main purpose is to perform a partial initialisation of the EmulatorState when we start the emulator, not to provide access to the whole emulatorState.
Its behaviour is aligned with the behaviour of the other initializer: create the chain index and update the wallets through the EmulatorEvents. In this particular case, as we don't replay the events on the newly (re)created state, the wallet list is empty.
We have already discussed the need to clean up and clarify the API, especially to clarify which parts of it are public. I think it's a pretty good example of it. I suggest that we remove the test, and that we initiate an action item (epic or story (?)) about cleaning and clarifying the API.


expression: implement ToBase64 and FromBase64

What have you changed? (mandatory)
implement ToBase64 and FromBase64
NOTE
This is not ready to merge yet, but I'm opening this PR so we can discuss the changes
What are the type of the changes? (mandatory)
Improvement
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
#3275

hi,  Sorry for open this WIP PR.  It's almost completed. but I need help.  according to TiDB implements, we need to check maxAllowedPacket and mysql.MaxBlobWith, how can I get this in TiKV?

Hi, Sorry for open this WIP PR. It's almost completed.

You can mention this in the PR description: "This is not ready to merge yet, but I'm opening this PR so we can discuss the changes".

@niedhui Thank you for the PR. I've left few comments, PTAL.

hi, @DorianZheng  I had update the base64 crate to 0.10. the line_wrap logic is based on the line-wrap crate. please take a look. still had a few question:

there lots of things for base64 related code,  maybe we should move these helper method to a separate file , any advice?
How can I get the maxAllowedPacket and add warning message, refer to https://github.com/pingcap/tidb/blob/master/expression/builtin_string.go#L3052

Please merge master changes, thanks!

@crazycs520 PTAL

Hi, we have just merged a PR that rewrote some facilities. types.rs is removed and you need to put your definitions in cop_datatypes. Also self.tp becomes self.field_type.

updated, PTAL

hi  @ice1000  ,  TODO comment had removed.  leave it to #3736 . PTAL

@niedhui Thank you for the PR, looks good now, we will merge it till CI pass

test raftstore_cases::test_split_region::test_delay_split_region ... thread 'raftstore_cases::test_split_region::test_delay_split_region' panicked at 'can't get value None for key "k5"', components/test_raftstore/src/util.rs:64:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:345
   7: test_raftstore::util::must_get
             at components/test_raftstore/src/util.rs:64
   8: test_raftstore::util::must_get_none
             at components/test_raftstore/src/util.rs:76
   9: integrations::raftstore_cases::test_split_region::check_cluster
             at tests/raftstore_cases/test_split_region.rs:279
  10: integrations::raftstore_cases::test_split_region::test_delay_split_region
             at tests/raftstore_cases/test_split_region.rs:323
  11: integrations::__test::TESTS::{{closure}}
             at tests/raftstore_cases/test_split_region.rs:288
  12: core::ops::function::FnOnce::call_once
             at /checkout/src/libcore/ops/function.rs:223
  13: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1454
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:640
  14: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:106
FAILED

@ice1000  I think the failed tests are not related to this PR, see #3669

Don't worry, you can just wait for some admins to merge your work.


prepared contextdeadline contribution

@ninthclowd provided a wonder contribution to the odbc project to support go context deadlines.
Reasons for this:

(primary): resolve merge conflicts on our branch
(primary): be able to adjust all vendor URIs in one go.
(secondary): desire to unvendor dependencies as a part of merge

I'm taking the contribution at face value.

This was removed from mainline as it was causing panics. Additionally, a closer review of the code showed a lot of unfinished todos and other loose ends that should have been cleaned up before merging.


Make sure ShaderUniformDataType matches rlShaderUniformDataType

It seems like with version 5.5 ShaderUniformDataType and rlShaderUniformDataType went out of sync with the addition of RL_SHADER_UNIFORM_UIXXX caused  SHADER_UNIFORM_SAMPLER2D to be interpreted as RL_SHADER_UNIFORM_UINT in rlSetUniform.
Depending on how lenient your specific OpenGL version is that might work fine, but in my case this caused issues.

@RicoP Thanks for the review! I missed those additions on raylib.h side