v3.0.5 doesn't work on Windows 7 / 32 bits with node 0.12.X

I have tried v3.0.5 on Windows 7 / 32 bits. It works very well with node 0.10.36.
But doesn't work with node 0.12.X.
The first connection launches the error :

module.js:338
throw err;
^
Error: Cannot find module 'C:\node.js\node_modules\sqlite3\lib\binding\node-v14-win32-ia32\node_sqlite3.node'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (C:\node.js\node_modules\sqlite3\lib\sqlite3.js:4:15)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)

The directory ..\binding\node-v14-win32-ia32\ doesn't exist,
but I find the file node_sqlite3.node in the directory ..\binding\node-v11-win32-ia32.
Changing the directory name ...v11 to v14 just does :

module.js:355
Module._extensions[extension](this, filename);
^
Error: La procédure spécifiée est introuvable.
C:\node.js\node_modules\sqlite3\lib\binding\node-v14-win32-ia32\node_sqlite3.node
at Error (native)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (C:\node.js\node_modules\sqlite3\lib\sqlite3.js:4:15)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)

Same issue here I tried a few things such as renaming the directory (which doesn't work).

Keep in mind that npm install installs binaries for your specific node version, arch, and operating system. If you change node versions you need to run npm install again. It sounds like the problem is that you need to re-run npm install. Please do not rename directories: that will not work.

This is occurring on a fresh install (no priori node_module).

@sandorfr you did not share your error message. it might be different so I'll need to see the entire message.

In fact it was exactly the same but :
I was using a 0.10.32 version of node. I upgraded to 0.12.0 (removed node_modules and run npm install) and now it works fine.

I reinstalled al but had a new error.
I eventualy found the solution. I use the binary version of node (not with installer). At a moment in the npm process node.exe wasn't found anymore. So I added the path of node.exe to %PATH%, and so the update worked. After this, node 0.12.2 and sqlite3 3.0.5 do it well on Windows7.


AttributeError: module 'config' has no attribute 'use_sentry'

I tried to open "food.py" but it gave me an error saying that "AttributeError: module 'config' has no attribute 'use_sentry'"
Can Anybody Help?

You need to rename config-example.py to config.py. Refer to the README.md for more info.

Now It says "AttributeError: partially initialized module 'responses' has no attribute 'document_template'" can you help?


Performance/optimize put drinking and moving

Removed convoluted method to populate drinks  and array_flip call that was not needed


fix libusb-package dependency

The previous version was missing tomli as a dependency, thus breaking on some platforms.

force-merging this hot fix as it should unblock users who need to install on some platforms.


Mutual exclusivity between "planetary" and "fleet-carrier" options

Need to think about this for a bit.
If planetary and fleet-carrier only contain "Y" then there will never be any results.

Debating with myself whether to do anything about this. There's nothing in the underlying tradedangerous to stop you doing this - all it does is return no results. Perhaps the warning should come from there?

I'm not sure that it should come from TD.
GUI development, as it's designed to simplify things and possibly be more hand holding, can issue any warnings it wants at the dev's descretion. If TD throws the warning, it's not going to stop users doing it and it's something realistically you might have to test for anyway.


Add session hash to access log

What does this PR do?
This PR adds a new field on AccessLog to better track sessions.
There is still an issue for sessions in which a user changes its password: because django.contrib.auth creates a new session upon password change and no logout/login signal is fired since this is neither a login nor a logout. I suppose it would be fine to keep this case "untracked" since it is not possible to hook into that method and usually changing password is not a frequent task.
When no session engine is configured it falls back to current behaviour: a logout will set the logout_time to every AccessLog without it. However this could be tolerated since there is no standard way to track such case and usually when there is no session there is not the concept of login/logout.
Fixes #1190
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

Released as version 6.5.0.


Filter efo trait names

Filter out efo trait names added for cellbase records but aren't needed for Open Targets submission
Fixes #16

Coverage decreased (-1.1%) to 77.672% when pulling e3c6444b645c8670adaf5bbdd7246f62b841bbdd on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

Coverage increased (+0.05%) to 78.86% when pulling 776ea29370559a8483f35cb9f08c3077a0619b3e on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

Could the reasoning behind disabling the "skip" be clarified? Is performance acceptable? Should the test check a single request? If the "skip" is not going to be present, it is better to remove the last 2 commits from the PR.

Coverage increased (+0.05%) to 78.86% when pulling c8246be8d5715c933c13e4caf84a5d1b1312a81c on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

I've removed the commits

I now remember why I put the skip test in- for some reason the cellbase records test sometimes returns a 500 error when it tries to get data from cellbase: https://travis-ci.org/EBIvariation/eva-cttv-pipeline/builds/145022989

Coverage decreased (-1.3%) to 77.515% when pulling 3e90382d3698dc3e37658b3aac4c9fe02493300b on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

Coverage decreased (-1.5%) to 77.356% when pulling 03092f0ee673de443a19e7c49f2d4b14eb85ebce on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

Could the iPython notebook and related scripts be taken out from this PR into another branch? I feel they are not directly related to this one, and there are some things I would like to discuss about them before merging into the main code base.

Coverage decreased (-1.3%) to 77.483% when pulling d0dd4a37f49080f8f56c4f42d15d2998bcfd12ac on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.

I see PR #19 now, but could the associated files still be extracted from this one? I can help with that if necessary (hint git cherry-pick).

I've removed the ipthon notebooks from the repo's history

Coverage decreased (-1.3%) to 77.483% when pulling aac3be13f6a4a0d1eec05cc7c2ef0547a27cfcf4 on tomdcsmith:filter_efo_trait_names into 8417669dad788f49489dd89e5d31512c20ec94e4 on EBIvariation:master.


Sensor AGE and Battery AGE

In order to see the change of the battery, as well as the change of the sensor in AAPS, one would have to change the event type from "Note" to "Pump Battery Change" and change the event type when changing the sensor to "Sensor Change". Would that be possible to provide compatibility with AAPS?

I have just seen that with the profile switch, only the event type "Note" is set and not the event type "Profile Switch".

I'll have a look at the sensor and battery requests.
Profile Switch is always sent to NS for a pattern change pump event.

Any news on this?

It will be in the next version but I don't have a date for that. If you want it now and can compile the code yourself it's a simple change of the type that's sent to NS.
Make this: "Sensor Change"
https://github.com/pazaan/600SeriesAndroidUploader/blob/07c55a4afa8a8245495aed896209846a4e9a5d22/app/src/main/java/info/nightscout/android/model/medtronicNg/PumpHistoryMisc.java#L55
Make this: "Pump Battery Change"
https://github.com/pazaan/600SeriesAndroidUploader/blob/07c55a4afa8a8245495aed896209846a4e9a5d22/app/src/main/java/info/nightscout/android/model/medtronicNg/PumpHistoryMisc.java#L58

Thanks, this is great. I try to compile it by myself.
Thank you Pogman


【Help Wanted】How can i add NevMeshLink by set a value like Jump Distance or Step Height of Navigation

Just like title:
How can i add NevMeshLink automaticly by setting a value like Jump Distance or Step Height of Navigation  when bake navmesh dynamicly by using NavMeshSurface.BuildNavMesh()

The Unity editor does not have any built-in capability to automatically add NavMeshLinks the way you have described.


Unit tests for HNSW vector retrieval

Please add unit tests...
For example https://github.com/castorini/anserini/blob/master/src/main/java/io/anserini/collection/JsonDenseVectorCollection.java can be easily tested...

cf. #2275 #2300


[Frames-iOS] - Update ReadMe with how to disable billing address

UpdatedREADME to deactivate the billing address in Default view.
Issue
README did not mention any way to deactivate billing address
Issue ticket number and link.
PIMOB-2355
Proposed changes
README updated with how to disable the billing address
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] Reviewers assigned
[x] I have performed a self-review of my code and manual testing
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if applicable)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

Hey @aashna-narula-cko, let's move this change under the make it your own sub ReadMe? I think it's more appropriate there. Would recommend having a look through that page to see where you think it might fit best.


Import via NPM

Hi,
I'm trying to include this as part of my javascript bundle. I've downloaded the package via NPM but how do I import it via webpack into my bundled JS?

@ddanier
Any Idea? What needs to be done for this?

In general it should be possible to import the library, see: https://webpack.js.org/guides/webpack-and-typescript/#using-3rd-party-libraries
I'm not sure whether the library itself needs to be packed in some special way for this to work (see https://webpack.js.org/guides/author-libraries/#author-a-library). If you need any particular changes to our code please file a pull request.

sorry that question was slightly wrong. I've managed to import the it "import browserUpdate from 'browser-update';" but how do I initialise it within this context?

something like this?
import browserUpdate from 'browser-update';
...
browserUpdate.$buoop = {vs:{i:12,f:-4,o:-4,s:9,c:-4},unsecure:true,api:4};

I was going to create a pull request for this that would fix the issue but I got incredibly confused.
This file:
https://github.com/browser-update/browser-update/blob/master/update.js
Is completely different to this file:
[local-project-folder]/node_modules/browser-update/update.js
So instead of trying to figure out what weird system you are using to publish to npm I'll just explain the fix here. It's pretty quick and easy.
Just to be clear, these instructions refer to this file:
[local-project-folder]/node_modules/browser-update/update.js
NOT this file:
https://github.com/browser-update/browser-update/blob/master/update.js
Currently you have this at the bottom of the update.js file:
var $buoop = $buoop||{};
$bu=$buo($buoop);

That is what is causing the incompatibility with webpack and browserify.
Instead, replace it with this:
module.exports = $buo;

By changing those last 2 lines, webpack and browserify users will then be able to write this in their javascript:
var browserUpdate = require('browser-update');

browserUpdate({ [configuration-options] })

Or if they have an es6 compatible build environment, they would do this:
import browserUpdate from 'browser-update';

browserUpdate({ [configuration-options] })

On a side note, if you are going to have completely different files for the browser and npm, then can you ensure that the npm version is stored in git? The file that npm loads by default is defined here in the package.json file: "main": "update.js". You could add an update.npm.js file for the npm version and update that property to "main": "update.npm.js".
If you have some sort of automated system for generating the npm version then can you please document it?

Thanks a lot for the detailed information. I will add a update.npm.js and update the build system to generate it with your suggested changes.

First question: Should update.npm.js be minified? Or is this commonly handled by build tools?

the npm's update.js should in general be the same as the normal one (except for the module.export you suggested). But I did not update the npm versions because I still have a problem I do not know how to solve:
The normal script loads lazy-loads the javascript to show the notification (update.show.min.js) only if an outdated browser is detected.
How should this be done with the npm version?

Should the update.show.min.js be loaded from browser-update.org?
Or is it possible to load the local copy of udate.show.min.js?
Or should I combine all code in one file?

Do you have an idea how to slove this?
Thanks!

Should update.npm.js be minified?
Nah, if a developer is using npm to load the module then they would already have minification built into their build process. So no need to minify the file.
How should I load  update.show.js?
I think just including all the js in the one update.npm.js file is the best option. Lazy-loading js in an npm module is very problematic. :/

You can't use a relative path designed to point to a local file on the server because files in the node_modules folder don't actually go on the server. They are only referenced to in the site source files.
You could instruct people to move the file from the node_modules folder into their file system like what babel does with it's babel-polyfill code but this is super annoying for people and it's likely you could lose some users if you force that on people.
You could do it CDN style and have the script reference a file that is hosted online somewhere. This will get flagged as a cross-site-scripting vulnerability in many automated security tests though. The cross-site-scripting flag will lead many clients to ask for the code to be removed, especially government clients. Seeing as the whole point of this project is to get it on as many sites as possible in order to get as many people upgrading as possible, this goes against your best interests. Especially since Government users are the most likely to need the message and doing it CDN style will make them the least likely to receive it.

So yeah, just include the whole thing in the update.npm.js file. Up to date browsers will need to download a few extra bytes but that's the least damaging of all the options, especially since js gets cached.

Ideally to avoid all the duplication and having to do everything twice when you make updates to the code, I'd recommend setting up an npm build system for the project. The repeated functionality could get their own files then you can use es6 imports to import the functions into 2 files. One file for the browser and one file for npm.
Try taking a look at my mq-js set up as a reference. The index.js file in the root folder is the one that is read by npm. The one that I edit though is the one in the /src/_scripts/index.js file. The setup is basically a modified Yeogurt setup.
Also if you're confused by the dependencies vs devDependencies lists in npm, I wrote this article which will likely clear things up for you.

Thanks for the help so far. I commited a new version. Could you check if I did it correctly?
I added the update.npm.full.js as the main file. This includes all the code necessary to notifiy the users.
I also added update.npm.js which has only the browser checkcing and lazy-loads the notification from the cdn. Just in case people like this. But I don't know how people can invoke this with import.

That's a good work around to let people decide for themselves if they prefer the cdn method or the full file method :)
Yes, it's possible for people to access the alternate file by doing this when they import it:
var browserUpdate = require('browser-update/update.npm.js');

browserUpdate({ [configuration-options] })

I think you left the critical module.exports line off of the update.npm.full.js file though. Without that line at the end of the file it won't work properly.
The changes won't be available on npm until you run the npm publish command.

I've done a bit of testing and the export appears to be working now :)
I didn't spot the module.exports line before since I was expecting to find it at the bottom of the file. It works ok where it is though so no need to change it.
Just publish it to npm now and the issue can be closed :)

To avoid having to delete all those files that you don't want up on npm before publishing, you can use an .npmignore file.
It works the exact same way as a .gitignore file except it only applies to npm publishing.
You might like to use this to create it: https://www.npmjs.com/package/npmignore

Thank you for all your help! I hope it works now. I published it to npm. It seems I don't need the .npmignore right now because no unneeded files are in the package right now, but thank you for the tip.

No problem :)
I mainly helped out because I really wanted to be able to use this in my projects but it didn't fit into my build process. Now it does :)


How to remove copy and define in a document when i open with UIDocumentInteractionController?

problem statement: preventing the copy (copying text) functionality in iOS app Document/PDF Viewer (.pdf, .doc, .docx, .txt & etc).
Description: Currently, We are developing an iOS app. as a part of app requirement we need to restrict the copy functionality. I am using UIDocumentInteractionController for previewing files (.pdf, .doc, .docx, .txt & etc) in my app. While previewing the file we need to restrict the copy (copying text) functionality.

Sorry for the late feedback. Are you asking about how to prevent copying text on iOS or how to do that on your app after bringing it to Windows using the Bridge?

Thank you ...I am asking about how to prevent copying text on iOS

Sorry, we don't know the answer to that. Closing since this is not related to the iOS bridge itself.


Supported for standard macOS tabbed interface

The option to manage all open windows as tabs would be very welcome. Including the "Merge All Windows" command.
It can sometimes be as simple as one IB change.

Window Controller, open the Attributes Inspector and switch the Tabbing Mode control to Preferred.
https://www.raywenderlich.com/613-windows-and-windowcontroller-tutorial-for-macos

Also see #131

Thanks, I’ll look forward to seeing this in the next release.


Compile Error: modules and worldserver failed

Have seemingly done all correct steps, after cleaning and attempting to build I in VS2022 I get:
22>Done building project "modules.vcxproj" -- FAILED.
25>------ Build started: Project: worldserver, Configuration: RelWithDebInfo x64 ------
25>Building Custom Rule F:/Games/WoW/_Setup/AzerothCore/azerothcore-wotlk/src/server/apps/CMakeLists.txt
25>cmake_pch.cxx
25>Main.cpp
25>ACSoap.cpp
25>CliRunnable.cpp
25>RASession.cpp
25>WheatyExceptionReport.cpp
25>ServiceWin32.cpp
25>LINK : fatal error LNK1181: cannot open input file '......\modules\RelWithDebInfo\modules.lib'
25>Done building project "worldserver.vcxproj" -- FAILED.
26>------ Build started: Project: ALL_BUILD, Configuration: RelWithDebInfo x64 ------
26>Building Custom Rule F:/Games/WoW/_Setup/AzerothCore/azerothcore-wotlk/CMakeLists.txt
========== Build: 24 succeeded, 2 failed, 0 up-to-date, 0 skipped ==========
========== Build started at 3:47 PM and took 18:17.160 minutes ==========

https://github.com/ZhengPeiRu21/mod-playerbots/pull/190

#190

I just tried his version and it still failed with the exact same statements.


Package.json exports field somehow confuses Rollup

While bundling a project that indirectly uses @uu-cdh/timing-util through @uu-cdh/backbone-util, Rollup issues the following warnings:
Could not resolve import<EMAIL_ADDRESS>in<EMAIL_ADDRESS>using exports defined in<EMAIL_ADDRESS><EMAIL_ADDRESS>is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency

exports defined in<EMAIL_ADDRESS>refers to this, but I don't see a problem with it:
https://github.com/CentreForDigitalHumanities/js-timing-util/blob/0e644eb4c63529822974a46b0328a73e9f20c008/package.json#L17-L22
I double-checked the contents of the node_modules and all the files are there.

What's the easiest way to reproduce this? (I haven't used either of these packages).

Make a local clone of EDPOP and run docker compose up frontend.


Request Permission Location for android 11

Pull Request Template
Types of changes
What types of changes does your code introduce to Woosmap Geofencing?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Documentation Update (if none of the other choices apply)

Checklist
Before you submit a pull request, please make sure you have to following:

[X] I've read contributing guidelines
[X] My code contain tests relevant for the problem I'm solving
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)

I did some adjustments earlier this morning (after your review @JeanCarriere I guess...)
Maybe @Llumbroso and @JeanCarriere have a quick look at my commit


how do i setup a custom domain?

thats the question, where and how i set a custom domain if im using this action

Hi @ankris812
You can set your custom domain via option cname as below:
- uses<EMAIL_ADDRESS>        with:
          provider: 'github'         # Default is github
          token: ${{ secrets.GITHUB_TOKEN }} # It's your Personal Access Token(PAT)
          ...
          cname: 'www.example.com'                  # Default is to not use a cname

Thanks


pbiviz --install-cert crashes powershell

pbiviz --install-cert outputs error:
This command cannot be run due to the error: The system cannot find the file specified.
At line:1 char:1

start C:\Users...\AppData\Roaming\npm\node_modules\powerbi-vis ...

  + CategoryInfo          : InvalidOperation: (:) [Start-Process], InvalidOperationException
  + FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c4bae6e-72e1-e41c-4419-48a56423e81e
Version Independent ID: 6d864495-b578-2d28-169d-edb5409de943
Content: Developing a Power BI Custom Visual - Power BI
Content Source: powerbi-docs/developer/custom-visual-develop-tutorial.md
Service: powerbi
Sub-service: powerbi-custom-visuals
GitHub Login: @sranins
Microsoft Alias: rasala

Hi, @williamdlupo, I've assigned your question to the author. In the meantime I recommend asking the Power BI community, https://community.powerbi.com/.

i had the same problem fix by typing .\pbiviz --install-cert

or you can add C:\Users...\AppData\Roaming\npm\node_modules\powerbi-vis ... to your PATH

@williamdlupo hello, could you tell the version of powershell on your system?

Hi @williamdlupo
This looks like a support request or product question rather than documentation feedback.
You might find a solution in the Power BI Community. If not, try our support page.


gtfs read issues

 Issue by evansiroky
Sunday Oct 29, 2017 at 03:37 GMT
Originally opened as https://github.com/catalogueglobal/datatools-server/issues/55

does not read in calendar_dates
does not read stop's zone id

 Comment by landonreed
Tuesday Nov 13, 2018 at 17:14 GMT

@evansiroky, I can you close this if you agree it's no longer an issue (thanks to your work in conveyal/gtfs-lib#141)? I believe zone_id support was added some time ago, too.

 Comment by landonreed
Tuesday Nov 13, 2018 at 17:19 GMT

Actually, this is more or less a dupicate of #80, so I'm going to close.


Segmentation fault in flutter build (DUPE #21623)

Flutter V0.8.2 which is currently Flutter Release Preview 2 still has the problem and the app gives similar output which is dupe of https://github.com/flutter/flutter/issues/21623, Requesting the team to change the release preview 2 to v0.8.7 from 0.8.2

Please check https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

Every few weeks, we pick the "best" dev build of the previous month or so, and promote it to beta. These builds have been tested with our codelabs.

If the fix for #21623 doesn't cause other issue it will be included in the next beta.


Use prepared statement result metadata to decode rows

Fixes: https://github.com/scylladb/scylla-rust-driver/issues/169
Motivation
Currently, the driver does not make a use of an optimization that CQL protocol offers during exeuction of prepared statements. The client is allowed to provide SKIP_METADATA flag during Session::execute, so the server doesn't attach a result set metadata. The driver can use the cached metadata (received in response to Session::prepare) to deserialize the results.
Changes
PreparedStatement
As mentioned previously, the driver can cache the prepared statement's result metadata. This is why we extend the PreparedStatementSharedData by result_metadata field which holds the metadata. The metadata is obtained from the server during statement preparation (Session::prepare). This metadata is eventually passed to the function which deserializes the results of query execution.
Schema changes
Before introducing the optimization, the driver was immune to the problems related to prepared statement's result metadata and schema changes.
After some schema change, Scylla and Cassandra invalidate the server-side caches and discard all of the prepared statements. When the driver executes a prepared statement after the schema change for the first time, it receives the UNPREPARED error frame (server does not recognize the id of the prepared statement since it was discarded). Currently, Scylla drivers handle such case by repreparation of the statement. Notice that after the schema change, the result metadata may be changed (depends on the actual change of schema). Without the optimization, Scylla always provides a valid (updated during repreparation) result metadata in the response to statement execution so we don't need to worry about it.
This raises an issue when we try to cache the metadata on the client side. It should be mutable so the driver holds a metadata that is always up to date (should be updated during reprepares). However, looking at the other drivers we can see that the client-side metadata caches are immutable. This is why we follow the same approach and not care about the schema changes.
Config
Extended and StatementConfig by skip_result_metadata boolean flag which defaults to false. When set to true, it enables the optimization. Thanks to that, the users can enable the optimization per-statement.
Points to discuss

should maybe skip_result_metadata flag be enabled by default? Since it's an optimization, it might make sense for it to be enabled by default.

Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] I added relevant tests for new features and bug fixes.
[ ] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[x] I have provided docstrings for the public items that I want to introduce.
[ ] I have adjusted the documentation in ./docs/source/.
[x] I added appropriate Fixes: annotations to PR description.

I need to adjust the test case so we alter the table in some other way. The logs from CI:
thread 'transport::session_test::test_use_prepared_result_metadata' panicked at scylla/src/transport/session_test.rs:2017:10:
called `Result::unwrap()` on an `Err` value: DbError(Invalid, "Altering column types is no longer supported")

Changes

I would prefer if you summarized your changes using prose and not a bulleted list. As a reviewer, I'm interested in:

The motivation behind the PR (A single link to an issue doesn't count),
An overview of the solution and how it addresses the motivation,
Decisions that you made and the rationale behind them.

Your bullet points don't give me this information, not easily at least. They concentrate too much on the details. For example, this point:

added result_metadata: ArcSwap<ResultMetadata> field to PreparedStatementSharedData

doesn't give any justification what it is for. After some adjustments it would serve well as a commit title (which should also be accompanied with a description unless the title itself is descriptive enough).
After reading all the bullet points I can form some idea about how the whole thing looks like, given that I'm familiar with the codebase and I created the issue that is being fixed here. However, other developers who will want to modify your code in the future might not have that luxury.
Besides helping maintainers, reviewers and other developers in the long run, I believe that preparing such a summary gives one a good opportunity to reflect on their proposed changes and help convince oneself that their changes make sense (or decide that they don't).

Changes

I would prefer if you summarized your changes using prose and not a bulleted list. As a reviewer, I'm interested in:
* The motivation behind the PR (A single link to an issue doesn't count),

* An overview of the solution and how it addresses the motivation,

* Decisions that you made and the rationale behind them.

Your bullet points don't give me this information, not easily at least. They concentrate too much on the details. For example, this point:

added result_metadata: ArcSwap<ResultMetadata> field to PreparedStatementSharedData

doesn't give any justification what it is for. After some adjustments it would serve well as a commit title (which should also be accompanied with a description unless the title itself is descriptive enough).
After reading all the bullet points I can form some idea about how the whole thing looks like, given that I'm familiar with the codebase and I created the issue that is being fixed here. However, other developers who will want to modify your code in the future might not have that luxury.
Besides helping maintainers, reviewers and other developers in the long run, I believe that preparing such a summary gives one a good opportunity to reflect on their proposed changes and help convince oneself that their changes make sense (or decide that they don't).

Thank you for the feedback, I'll make sure to adjust the PR description as well as commit messages that are not descriptive enough.

I'd like to know more about how the driver behaves when a signal to reprepare is missed (i.e. some other application reprepares and this one misses it). The scenario with SELECT * and adding a column is known, but I wonder what happens if we have a UDT column or a tuple and we add a field to the UDT/tuple. I think this case might actually be quite common contrary to SELECT * so I'm wondering whether other drivers handle it correctly and if we handle it correctly.
Could you do a test and see how our driver behaves in this scenario? I'd also like to know how other drivers handle it, for example the Java driver - it seems the most mature of the drivers I know.

So I've tested the UDT case you provided with both rust and java drivers. The key thing to notice is that java driver actually does NOT update the result metadata of the prepared statement during repreparations. The metadata is immutable - set only once during the first preparation of the statement. In result, the scenario you described fails even when only one client connects to the database.
The demo (on scylla-4.x branch):
import com.datastax.oss.driver.api.core.CqlSession;
import com.datastax.oss.driver.api.core.cql.PreparedStatement;
import com.datastax.oss.driver.api.core.cql.Row;
import com.datastax.oss.driver.api.core.data.UdtValue;

public class CreateAndPopulateKeyspace {

  public static void main(String[] args) {

    CreateAndPopulateKeyspace client = new CreateAndPopulateKeyspace();

    try {
      client.connect();
      client.createSchema();
      client.prepareStatement();
      client.alterSchema();
      client.reprepareStatement();

    } catch (Exception ex) {
      ex.printStackTrace();
    } finally {
      client.close();
    }
  }

  private CqlSession session;
  private PreparedStatement preparedStatement;

  public void connect() {
    session = CqlSession.builder().build();

    System.out.printf("Connected session: %s%n", session.getName());
  }

  public void createSchema() {

    session.execute("DROP KEYSPACE IF EXISTS simplex");

    session.execute(
        "CREATE KEYSPACE IF NOT EXISTS simplex WITH replication "
            + "= {'class':'SimpleStrategy', 'replication_factor':1};");

    session.execute("CREATE TYPE simplex.my_type (a int)");

    session.execute(
        "CREATE TABLE simplex.tab (a int PRIMARY KEY, b int, c simplex.my_type)");

    session.execute("INSERT INTO simplex.tab (a, b, c) VALUES (1, 2, { a: 1 })");
  }

  public void prepareStatement() {
    preparedStatement = session.prepare("SELECT c FROM simplex.tab");
  }

  public void alterSchema() {
    session.execute("ALTER TYPE simplex.my_type ADD d blob");
  }

  public void reprepareStatement() {
    Row row = session.execute(preparedStatement.bind()).one();

    UdtValue udtValue = row.getUdtValue("c");
    System.out.println(udtValue);
  }

  public void close() {
    if (session != null) {
      session.close();
    }
  }
}

The output:
Using Scylla optimized driver!!!
08:36:27.544 [main] INFO  c.d.o.d.a.c.session.SessionBuilder - Using Scylla optimized driver!!!
08:36:27.770 [main] INFO  c.d.o.d.i.c.DefaultMavenCoordinates - DataStax Java driver for Apache Cassandra(R) (com.scylladb:java-driver-core) version <IP_ADDRESS>-SNAPSHOT
08:36:27.859 [main] INFO  c.d.o.d.i.c.c.CqlPrepareAsyncProcessor - Adding handler to invalidate cached prepared statements on type changes
08:36:28.139 [s0-admin-0] INFO  c.d.o.d.internal.core.time.Clock - Using native clock for microsecond precision
Connected session: s0
08:36:36.463 [s0-io-4] WARN  c.d.o.d.i.core.cql.CqlRequestHandler - [s0|1848289347|0] Statement 0xf4bf63c95f8a8b21c40745cbc1055ff9 is not prepared on Node(endPoint=/<IP_ADDRESS>:9042, hostId=d99848a9-2754-43e9-9aa1-0d708514c8b3, hashCode=4c3d379d), repreparing
java.lang.IllegalArgumentException: Too many fields in encoded UDT value, expected 1
	at com.datastax.oss.driver.internal.core.type.codec.UdtCodec.decode(UdtCodec.java:109)
	at com.datastax.oss.driver.internal.core.type.codec.UdtCodec.decode(UdtCodec.java:32)
	at com.datastax.oss.driver.api.core.data.GettableByIndex.get(GettableByIndex.java:90)
	at com.datastax.oss.driver.api.core.data.GettableByIndex.get(GettableByIndex.java:127)
	at com.datastax.oss.driver.api.core.data.GettableByIndex.getUdtValue(GettableByIndex.java:550)
	at com.datastax.oss.driver.api.core.data.GettableByName.getUdtValue(GettableByName.java:650)
	at com.datastax.oss.driver.examples.basic.CreateAndPopulateKeyspace.reprepareStatement(CreateAndPopulateKeyspace.java:99)
	at com.datastax.oss.driver.examples.basic.CreateAndPopulateKeyspace.main(CreateAndPopulateKeyspace.java:35)

Process finished with exit code 0

This is the exact same reason why SELECT * prepared statement won't work when we add/drop the column to the table after statement preparation (even in 1-client scenario).
The same test case that uses rust driver works since we update the client-side result metadata after statement repreparation. However, this won't work in the following 2-client scenario:

[CLIENT 1]: Prepare schema - create keyspace, udt, table (as in java example).
[CLIENT 1]: Prepare the SELECT c FROM simplex.tab statement
[CLIENT 2]: Prepare the SELECT c FROM simplex.tab statement
[CLIENT 1]: Alter the user-defined type
[CLIENT 1]: Execute the prepared statement - the repreparation takes a place, server caches the id of the prepared statement
[CLIENT 2]: Execute the prepared statement - the server already holds an id of the prepared statement, we miss the reprepare and so we make use of the outdated metadata to deserialize the result. We end up with deserialization error (expected 1 field of UDT, received 2 fields).

Now the question is whether we want to follow the java driver's approach and make result_metadata immutable (then we can get rid of ArcSwap as well).
Unfortunately, no solution to the multi-client scenario comes to my mind. Since java driver is vulnerable to this as well, I believe there is no reasonable solution to the problem. AFAIK, the 5th version of CQL protocol offers some solution where the server informs all of its clients about the change of metadata.

Thanks for checking.
I think it makes more sense to make the result metadata immutable. The approach with ArcSwap works OK only if you have only one instance of PreparedStatement for a given potentially-problematic query across all running applications that share the same cluster. I also think there might be some issues if you try to execute the same PreparedStatement instance and one of them gets reprepared... All in all, it only works in very specific circumstances which might be hard for the user to ensure. I think an incorrect but consistent behavior in the form of returning metadata that was returned at first prepare is better.

v2: rebased on top of master

v3 - addressed review comments:

made result_metadata immutable - in result got rid of ArcSwap
moved skip_result_metadata flag from SessionConfig to StatementConfig
adjusted getters and setters for two types of metadata contained in PreparedStatementSharedData

Question related to tests:

since the previously introduced test case tested whether the client-side metadata is updated during reprepare, we got rid of this test case as we made result_metadata immutable. What is the best way to test our solution? I believe we could maybe use scylla-proxy crate and check whether the server does not attach the metadata in the response when client sents SKIP_METADATA flag. Correct me if I'm wrong, as I don't have any experience with the proxy.

Note: there is still an issue with metadata.clone() mentioned in the review comment. I'm still investigating the issue.

v4: adjusted docstrings

since the previously introduced test case tested whether the client-side metadata is updated during reprepare, we got rid of this test case as we made result_metadata immutable. What is the best way to test our solution? I believe we could maybe use scylla-proxy crate and check whether the server does not attach the metadata in the response when client sents SKIP_METADATA flag. Correct me if I'm wrong, as I don't have any experience with the proxy.

Yes, the proxy would be the right tool for this kind of test.

And - thanks for adding the descriptions as I requested. I really appreciate that.
Don't forget to update it when you make changes to the implementation that would make it outdated (I see that it mentions ArcSwap right now, but AFAIK you got rid of it).

Rebased on top of main, so the CI passes

v5: addressed review comments

v6:

resolved conflicts with main
changed the name of the parameter of StatementConfig::set_use_cached_result_metadata from should_skip to use_cached_metadata


Specification of input TSV file

Input TSV file is Tab Separated Values, without header line.
Sphinx definition: tsvpipe has tab character as hardcoded delimiter and has no quoting rules.
Each value is interpreted as string inside sphinxsearch, nevertheless of quotes. Using tab character inside text values is not possible!
We need specific column order from input TSV file, because this order is than used in sphinx configuration.
Columns:

osm_id - MUST BE UNIQUE INTEGER "DOCUMENT ID" accross complete database
display_name
name (=utf-8)
name_en
name_de
name_es
name_fr
name_ru
name_zh
class
type
north (=boundingbox)
south
east
west
lat
lon
scalerank - we have it
place_rank - nominatim has it
importance - exactly as in nominatim calculated
country (=country code, ISO-3166 2-letter country code)
street=< housenumber > < streetname >
city=< city >
county=< county >
state=< state >
country=< country >
postalcode=< postalcode >

Related tickets: https://github.com/geometalab/OSMNames/issues/1 and https://github.com/geometalab/OSMNames/issues/3

The students from HSR @lukasmartinelli and @manuelroth will prepare a first basic export based on the possibilities of what we have now in OSM2VectorTiles database.
Once they provide the first export file we adjust our sphinx.conf to be aligned to what they supply - and we will use this for initial tests.
The final exact official definition of the OSMNames project is now discussed - and final decisions are to be made at later point.

It settled down - in the https://github.com/geometalab/OSMNames repo.


Add a manually triggerable Github Action for generating release notes

Summary
This PR adds a manually triggerable Github Action job to generate release notes.
An example of how you can start it can be seen here: https://github.com/bstatcomp/math/actions?query=workflow%3A"Release+notes"
The result of the job can be seen here: https://github.com/bstatcomp/math/actions/runs/284867780
This script lived on my computer, but I think its better if it lives in the repository so anyone can run it without actually having to do anythin locally.
Tests
/
Side Effects
/
Release notes
Checklist

[x] Copyright holder: Rok Češnovar, Univ. of Ljubljana
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

The only way we can test this is if we run it "on PR", and then revert that change.

There you go: https://github.com/stan-dev/math/actions/runs/285971782
Will revert back to only trigger manually.

Oof I guess that means poor Jenkins gets to sweat another 8 hours, but thanks for the test.

Oh wait it says it is passed, great.

Jenkins skips if the change is not source code or tests or Jenkins config.

Now that I have you here. I want to add something similar for math benchmarks (manually triggered job). When you have a minute: https://github.com/bbbales2/math-benchmarks/issues/1


calico/node-driver-registrar:v3.25.0-s390x apparently has a x86-64 binary.

I'm trying to install calico 3.25.0 with k8s 1.26 on s390x Linux machine via tigera operator.
Expected Behavior

Container is running
Current Behavior
Container node-driver-registrar is in CrashLoopBackOff.
$ kubectl -n calico-system   logs   csi-node-driver-sdrpd -c csi-node-driver-registrar
exec /usr/local/bin/node-driver-registrar: exec format erro

I checked the binary in image and i could see that others binary are in s390x but node-driver-registrar is in x86-64 :
$ ctr images mount quay.io/calico/node-driver-registrar:v3.25-s390x /tmp/teste/
$  file /tmp/teste/usr/local/bin/node-driver-registrar
/tmp/teste/usr/local/bin/node-driver-registrar: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

$ file /tmp/teste/bin/busybox
/tmp/teste/bin/busybox: ELF 64-bit MSB shared object, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-s390x.so.1, stripped

Possible Solution

Steps to Reproduce (for bugs)

In a s390x machine run  docker run  quay.io/calico/node-driver-registrar:release-v3.25-s390x
container exits with message: standard_init_linux.go:228: exec user process caused: exec format error

Context

Your Environment

Calico version: 3.25.0
Orchestrator version (e.g. kubernetes, mesos, rkt): k8s 1.26.0
Operating System and version: Red Hat 8.7 s390
Link to your project (optional):

I believe this should fix it https://github.com/projectcalico/calico/pull/7315

This is still happening on v3.29.0
exec /usr/bin/node-driver-registrar: exec format error
as mentioned on 8784


jQuery Migrate 3.0.1 - outdated focus() event shorthand is deprecated

While using v1.18.0 of the jQuery Validation plugin, alongside jQuery Migrate 3.0.1, I got a console warning concerning the following line using deprecated markup:
https://github.com/jquery-validation/jquery-validation/blob/dd187b016a1b4eef22ae93500eb37a44bf2ecd0d/src/core.js#L605
Looking through the rest of the code, the up to date on()/off()/trigger() event handlers are used, so it's entirely possible this is the only instance of the code which is deprecated?
It only needs changing from:
focus()
to
trigger('focus')
The Migrate plugin doesn't appear to complain about anything else, but would be grateful if anyone can confirm this?
Many thanks
Stephen Scott

Thx for the report. I guess this is an oversight on our end.
Are you willing to provide a PR to fix the warning?
Thx

@staabm - I can certainly have a go.

Fixed by #2243


Set-CAKRACertificate changes my certificates thumbprint

I use PSPKI in Windows 2016 Core test environment. I know Windows 2016 is not in the list of supported OS, but I thought it's worth a try. ;)
The CA is newly installed, I do not have any KRA on this system added. I want to you PSPKI to add a KRA. The KRA certificate is already issued by another CA. The certificate is valid and trusted. It has the thumbprint (sample) 0F75CCFC39455ABD64851AAEF50D202B7580C3A7.
$CA | Get-CAKRACertificate
Certificate: Empty
$KRACert = Get-ADKRACertificate -Subject "CN=$CAKRA*"
$KRACert is from the type System.Security.Cryptography.X509Certificates.X509Certificate2 and contains the correct certificate, with the thumbprint 0F75CCFC39455ABD64851AAEF50D202B7580C3A7
$KRA = $CA | Add-CAKRACertificate -Certificate $KRACert
$KRA is from the type PKI.CertificateServices.KRA and the thumbprint is still 0F75CCFC39455ABD64851AAEF50D202B7580C3A7
$KRA | Set-CAKRACertificate -RestartCA  $CA | Get-CAKRACertificate
After using Set-CAKRACertificate, the thumbprint suddenly changes! The thumbprint is now (sample) 5106DD2F848595803C817E72E1205A0AA1EF67C7. The subject, serial number etc. however is as expected (=correct). But, because of the wrong thumbprint, the certificate is, of course, invalid.
I tried to add Get-CAKRACertificate, Remove-CAKRACertificate etc. to my command. But still, in every scenario, as soon as I use Set-CAKRACertificate, the thumbprint changes to the wrong value (its always the same wrong value).
If I use the Certification Authority console I can add the Key Recovery Agent successfully (and valid ;) ).

I will take a look. Though unlikely that earlier than next week.

@Crypt32 , please let me know if you need further information or I can support you anyhow

I don't think I need more information right now. I'm able to repro the issue and trying to figure out what happens.

Found the issue. I forgot to make casting in DER converter. Tested and it works as expected.

I can confirm that it's working now. Thank you, Vadims!


Date picker: no way to disable mouse wheel.

Using a native HTML input date, we can disable mousewheel over it. This is mainly used to avoid users to focus the input, choose a date, scroll down to continue, and notice they've changed the date unintentionally.
Example with jQuery and jQuery-mousewheel:
<input type="date">
<script type="text/javascript">
$(function() {
    $('input[type="date"]').on('mousewheel', function(event) {
        event.preventDefault();
    });
});
</script>

Unfortunately, webshim doesn't reproduce this behavior, or doesn't seems to provide any way to do it.
A good way to test it is to compare Chrome/Firefox behavior

You can disable this with the following option:
webshim.setOptions("forms-ext", {
	"widgets": {
		noSpinbtn: true
	}
});

Ok, I misunderstood this option. Thanks for your quick feedback!


Adding purgecss for vuetify on Nuxt3 breaks uno.

Hi I am using Uno css + vuetify on Nuxt3 project and everything works great. Unfortunately vuetify generate lots of unused CSS so I wanted to add purgecss by postcss. When I add this I'm getting this error:
[unocss] does not found CSS placeholder in the generated chunks                                                                                16:06:14
This is likely an internal bug of unocss vite plugin

Removing ''@unocss/nuxt' from  nuxt.config modules fix this, and purger works great (70% reduce) but I do not want to remove uno from project :(
Reproduction:

Go to https://stackblitz.com/edit/github-w6cj1g?file=nuxt.config.ts
do npm run build

Ok i got it. @antfu UnoCSS fire unocss:global:build:generate after postcss. When I've added purger to postcss to Nuxt3, purger purged all of uno placeholders. When I've added this to purger whitelist  /--unocss--/g, everything works great. It Would be great if uno build fired before postcss

Ok i got workaround. @antfu UnoCSS fire generateBundle() after postcss. When I've added purger to postcss to Nuxt3, purger purged all of uno placeholders. When I've added this to purger whitelist  /--unocss--/g, everything works great. It Would be great if uno build fired before postcss.

How to whitelist unocss? Can I ask for some guidance?


Application Customizer Top should really be at the Top

Category

[ ] Question
[ ] Typo
[X] Bug
[X] Additional article idea

Expected or Desired Behavior
When adding Office Fabric React Components to the new Application Customizer at the Top, the customizer should really be at the top and the css should not be influenced by parent DOM Elements.
Observed Behavior
Currently on modern pages there are global styles applied that change the look and feel of our application customizers, because the top control is nested in several DIVs that apply global decendent styles to the customizers. This happens for example, when using office ui fabric react controls.
Steps to Reproduce
Add a office ui fabric react command bar with buttons and Icons to an application customizer at the top and see that it renders wrong.

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


UI error if widget is inside Expanded

I want MenuButton to expand the available width. But if I put it in Expanded - it is broken down

I have the same problem but, i resolved my problem using media query and calculate the correctly width, i don't know if this resolve your problem..

this is the last variant, becuase I have not only this widget in the row. Should be fixed

Yes I had that problem too, I'll have some time to watch next week. Can you put a code to reproduce the problem so the resolution will be more efficient. Thanks

@huextrat have you also updated for this one too??

@dipcse07 No i'm working on it this afternoon to find a suitable solution. Can you confirm the the issue is on the child & toggledChild property ?

yes on the drop down menu items or the child items . wait a second i will add two screen shot..

When there is only 2 button items then there is another two button area in the drop down menu items before even selecting the button items..i guess..

When there is 4 button items then after selecting one button item it shows the remaining 3 button item with extra another area for button item

these are the problems i am having..

Okay that sounds like another problem that I think is solved in the latest master version. Can you confirm by retrieving master?

okay..  i am upgrading..

@dipcse07 v1.2.0+1 should solve your problem

@dipcse07 Ok and you are using an Expanded widget or not ?

if i have understood currectly i am not for menu button...  i have only used which is given in the how to use section of the pub.dev for this packages..
here is the code:
`  body: Container(
alignment: Alignment.center,
child: Column(
crossAxisAlignment: CrossAxisAlignment.center,
children: [
//              FlatButton(
//                onPressed: () {
//                  getData();
//
//                  print('the count: $count');
//                },
//                child: Text('get data'),
//              ),
          MenuButton(
            child: SizedBox(
              width: 83,
              height: 40,
              child: Padding(
                padding: const EdgeInsets.only(left: 16, right: 11),
                child: Row(
                  mainAxisAlignment: MainAxisAlignment.spaceBetween,
                  children: <Widget>[
                    Flexible(

                      child: Text(
                        selectedItem,
                        style: TextStyle(color: Colors.black),
                        overflow: TextOverflow.ellipsis,
                      ),
                    ),
                    SizedBox(
                        width: 12,
                        height: 17,
                        child: FittedBox(
                            fit: BoxFit.fill,
                            child: Icon(
                              Icons.arrow_drop_down,
                              color: Colors.grey,
                            )
                        )`

@mishatron @lucas-sesti menu_button: 1.2.1 should solve the issue when you have MenuButton in Expanded widget. I'm gonna close the issue please tell me if you still have the problem.
@dipcse07 Your problem looks like it's not related to this issue, please open a new one with code sample and same screenshot as above ;) Thanks

okay i will do that now..


Remove src file

Removes the src file on the root of the repository.
Reasoning
This is a monorepo, each package includes its own src folder. Packages are being managed with the yarn workspaces feature

😅


WIP: Control Themes

What does the pull request do?
WIP Implementing control themes as described in #7120. More details to come.
For subsequent PRs

Validate selectors in control themes
BasedOn
Default control themes (i.e. Generic.xaml equivalent)
Port fluent and simple theme

Damn wrong branch. Will open another PR.


Remove bug autofocusing dropdown menu triggers

I'm afraid my previous PR #647 introduced a bug whereby mounting a dropdown menu causes the trigger to be focused initially.

The problem arises from this effect (in menu/create.ts) initially running and setting focus to the trigger on mount.
effect(
		[rootOpen, rootActiveTrigger, preventScroll],
		([$rootOpen, $rootActiveTrigger, $preventScroll]) => {
			if (!isBrowser) return;

			const unsubs: Array<() => void> = [];

			if (opts.removeScroll && $rootOpen && $preventScroll) {
				unsubs.push(removeScroll());
			}

			if (!$rootOpen && $rootActiveTrigger && opts.disableTriggerRefocus === false) {
				handleRovingFocus($rootActiveTrigger);
			}

			sleep(1).then(() => {
				const menuEl = document.getElementById(rootIds.menu);
				if (menuEl && $rootOpen && get(isUsingKeyboard)) {
					if (opts.disableFocusFirstItem) {
						handleRovingFocus(menuEl);
						return;
					}
					// Get menu items belonging to the root menu
					const menuItems = getMenuItems(menuEl);
					if (!menuItems.length) return;

					// Focus on first menu item
					handleRovingFocus(menuItems[0]);
				} else if ($rootActiveTrigger) {
					// Focus on active trigger trigger
					if (opts.disableTriggerRefocus) {
						return;
					}
					handleRovingFocus($rootActiveTrigger);
				} else {
					if (opts.disableTriggerRefocus) {
						return;
					}
					const triggerEl = document.getElementById(rootIds.trigger);
					if (!triggerEl) return;
					handleRovingFocus(triggerEl);
				}
			});

			return () => {
				unsubs.forEach((unsub) => unsub());
			};
		}
	);

Before my PR disableTriggerRefocus was true and therefore the final else block did not fire.
My solution proposal would be to simply delete the else, since I'm unsure why it would be needed? as I understand the code, focus should only be moved to the trigger if the dropdown has been opened.
An alternative could be to simply skip the first execution of the effect. Or more closely track whether or not the dropdown has been opened.

Hey @AndreasHald, this is fixed and being addressed by #663.

@huntabyte amazing! can't wait :D I'm closing this PR


add jhipster plugin to index

This is the official JHipster Fisherman plugin. It would be cool if it can be found and installed via fisher jhipster.
More Information can be found here:
https://github.com/jhipster/jhipster-fisherman-plugin
http://jhipster.github.io/fisherman/
https://github.com/atomfrede/jhipster-fisherman-plugin

sorry this took so long.


[TAGUI][ERROR] - missing image file, OCR and echo() - pending replication

user query

I was trying out the OCR automation using TagUI for Python. Ran through the use cases examples, but got an error as seen below:

This is my code:
import tagui as t
t.init(visual_automation = True)
t.echo(t.read('C:/Users/USER/testocr.png'))
t.close()

I have tried using an online .png URL to test out this script, instead of a local .png file. Both does not seem to work.
I would also like to ask what does the echo action do. It says on Github that the purpose of echo is to print text to output, how come the output location is not specified in the script?

This error message happens when an image file is specified but not found. To isolate the problem, you can try enter Python in interactive mode. After that do the steps to test out the functions. Maybe enter a direct filename t.read('testocr.png') to see if there is something wrong with the path. Or maybe 'testocr.PNG' if the file extension is in upper case for Windows. And also make sure the user ID that you launch the command prompt has read access to that image file.
After you get it working, there are interesting things you can do with OCR. You can specify a window frame or PDF window frame image with the centre body empty (0% opacity) to do selection of a window with varying contents to perform OCR. You can also define the rectangular boundaries using the x1, y1, x2, y2 coordinates. More details here - https://github.com/tebelorg/TagUI-Python#api-reference
For echo() function, output is referring to the standard output which is the display screen. For writing to text files, use write() or dump(). More info here - https://github.com/tebelorg/TagUI-Python#basic-functions
Do raise questions and issues on the GitHub page so that other users can contribute or learn!

Closing issue for now, do post here if you run into problem specifying image for visual automation!


Remove "AzureGateway-GUID.cloudapp.net"

Self-signed certificate (AzureGateway-GUID.cloudapp.net) is not using now.
https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-point-to-site-gateway-public-ca

@ShuheiUda : Thanks for your contribution! The author(s) have been notified to review your proposed change. @chadmath

@anzaman Can you take a look?

#sign-off

@anzaman: I'm sorry - only the author of this article, @chadmath, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Please confirm these before moving forward

[x] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
The installer which is downloaded via the command winget install Microsoft.VisualStudio.2019.Enterprise --accept-package-agreements --accept-source-agreements --silent --scope Machine is for visual studio 2022 and installs as such. Im not sure why this is occuring but I cant find a link for the 2019 installer on microsofts website that isnt the 2022 version without going through the azure version of the download IE. https://my.visualstudio.com/Downloads?q=visual%20studio%202019&wt.mc_id=o~msft~vscom~older-downloads. The issue with this method is that it is behind a login wall so we cant just use the link.
Steps to reproduce
winget install Microsoft.VisualStudio.2019.Enterprise --accept-package-agreements --accept-source-agreements --silent --scope Machine
Actual behavior
Downloads visual studio 2022
Expected behavior
Downloads visual studio 2019
Environment
Windows Package Manager v1.2.10941
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19041.1415
Package: Microsoft.DesktopAppInstaller v1.17.10941.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs
No response

@jedieaston - Any ideas?

This is where I get it from: https://docs.microsoft.com/en-us/visualstudio/releases/2019/history
I’m guessing I messed up the link for 2019, once I’m back to my PC I’ll open a fix PR.


Revisit eigenvalue solver

We experienced that Cardano's method is not really stable and reliable for our use case. We may however reconsider this method and try to make it more stable. Also, the unit test test_jacobi_1.f90 fails if there are eigenvalues close to each other. This is no bug in the Jacobi, but a problem of checking the result.

Just a few links discussing/using Cardano's method:

https://www.sciencedirect.com/science/article/pii/S2405844020308422
https://www.sciencedirect.com/science/article/abs/pii/S0096300318301346
https://math.stackexchange.com/questions/2434354/numerically-stable-scheme-for-the-3-real-roots-of-a-cubic
https://fortran-lang.discourse.group/t/numerical-resolution-using-cardan-method/344/6

Cardano's method with eigenvectors calculated following Kopp's paper does not give accurate results when eigenvalues are close (nearly identical). This paper by Scherzinger and Dohrmann (https://doi.org/10.1016/j.cma.2008.03.031) describes a robust eigenvalue/eigenvector solver for real symmetric 3x3 matrices that is comparable in speed to analytical solutions and as accurate as iterative methods.


deploy: update sidecar image repository from quay.io/k8scsi to k8s.gcr.io/sig-storage

Update sidecar image repository and tag
The image repository has been migrated to k8s.gcr.io/sig-storage from
quay.io/k8scsi.
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

@Madhu-1 there are changes on RBAC required for some of the sidecars .  so that will be updated and all the things we require to get latest sidecars will be taken care. Backward compability is broken for some of the sidecars. So I am looking into those as well and also splitting it to different commits/PRs.

@Madhu-1 there are changes on RBAC required for some of the sidecars . so that will be updated and all the things we require to get latest sidecars will be taken care. Backward compability is broken for some of the sidecars. So I am looking into those as well and also splitting it to different commits/PRs.

Marked this as draft because it still seems to be a work in progress.

/retest all

@Madhu-1 @nixpanic ptal .

@Madhu-1 updated. ptal .

@nixpanic ptal.


How does Gemstash compare to Geminabox?

Obviously Geminabox has been around for a while and Gemstash is relatively a new comer. It would be great to have a comparison on features, security, hosting setup etc. So the gem server shoppers can make a more informed decision on which one to pick.

PRs are welcome! :smile:

Closing this one as it has been lingering for a while.


Remove unused private member 'step_' from nlb7 class

In the nlb0 and nlb3 classes step_ is used to support the command
line option multi-cl.  This option is not present in nlb7.
Fixes the clang error.
.../opae-sdk/tools/extra/fpgadiag/nlb7.h:79:14: error: private field 'step_' is not used [-Werror,-Wunused-private-field]
uint32_t step_;
^

Coverage remained the same at 81.185% when pulling f8feeb76fbcb8025591784b942abcff0b2c797c1 on trixirt:trix/master/sa-nlb7 into b742dfe553c47d382a14764b8233d0f6b8493dd9 on OPAE:master.


Move schoolbook squaring implementation into a macro

Applying this to BoxedUint results in an almost 50% speedup at 4096 bits.
Also adding benchmarks for multiplication.

Hmm, swear I tried this and it didn't effect a performance increase with BoxedUint, but this looks like it's worth a shot


[$500] IOU - System message is not shown after completing send money request flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.42
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:  Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap fab ---- send money
Enter an amount and tap next
Select an user
Tap pay elsewhere
Tap on send money request created to open report page

Expected Result:
After completing send money request flow, in IOU report page, for paid system message must be displayed
Actual Result:
After completing send money request flow, in IOU report page, for paid system message is not displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/1236896f-5f5f-4c94-83e5-2f4bce8811b8
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019999a8d5ba73ff93
Upwork Job ID:<PHONE_NUMBER>823669248
Last Price Increase: 2024-02-15

Production:
https://github.com/Expensify/App/assets/78819774/42264fb0-0fc6-4b93-8474-9105cfe882fc

We think that this bug might be related to #vip-bills
CC @davidcardoza

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - System message is not shown after completing send money request flow
What is the root cause of that problem?
We are forcefully ignoring markedAsReimbursed actions and not displaying it.
https://github.com/Expensify/App/blob/9843f6641f65d11e125c4325df1f95feae9d1259/src/libs/ReportActionsUtils.ts#L396-L400
What changes do you think we should make in order to solve the problem?
Removing the above code will fix the issue. However need to check why was that introduced in the first place.
What alternative solutions did you explore? (Optional)
NA

cc @Gonals Looks like you added this in https://github.com/Expensify/App/pull/34719, was this an intentional change and if so should we update the testrail?


Archive Collective: delay subscription cancellation

This PR cancels subscription when executing daily charge subscription for an archived collective and notifies the user through email using a new archived.collective.hbs email template.

Email Content
Subject:

Archived Collective: Subscription cancelled to APEX

Body:

Dear Xavier Damman,
APEX has been archived, we won't be able to process your order and your subscription has now been cancelled.
If you have questions, you can always email us at<EMAIL_ADDRESS>Warmly,
– Team Open Collective

Ref (#1825)

Coverage decreased (-0.03%) to 67.167% when pulling 007a6b415c279df69518e075b427a401607e9dd2 on cancel-subscription into bd97592430fbcd4e34a20c2ec3f64e0ab629d034 on master.

Suggested changes:

Archived Collective: Subscription cancelled to APEX

Archived Collective: Your subscription to APEX has been cancelled.

Body:
Dear Xavier Damman,
APEX has been archived, we won't be able to process your order and your subscription has now been cancelled.
If you have questions, you can always email us at<EMAIL_ADDRESS>Warmly,
– Team Open Collective

Dear Xavier Damman,
The APEX collective has been archived by its core contributors and it is no longer accepting contributions. We are unable to process your order and your subscription has been cancelled.
If you have any questions, you can always email us at<EMAIL_ADDRESS>Warmly
-- The Open Collective Team


Parsing fails with examples from HTTP Signature

Hello,
I tried to use the library to parse an example given in HTTP Header "Signature-Input", from the HTTP Signature latest draft:
   Signature-Input: sig1=(*request-target, *created, host, date,
       cache-control, x-empty-header, x-example); keyId="test-key-a";
       alg=hs2019; created=1402170695; expires=1402170995

Turns out the parsing fails. Here is the error output:
$ node index.js
/redacted/node_modules/structured-field-values/index.js:134
    throw new Error(`failed to parse: trailing values ${result.rest}`)
    ^

Error: failed to parse: trailing values =(*request-target, *created, host, date, cache-control, x-empty-header, x-example); keyId="test-key-a"; alg=hs2019; created=1402170695; expires=1402170995
    at Object.parseDict (/redacted/node_modules/structured-field-values/index.js:134:11)
    at Object.<anonymous> (/redacted/index.js:14:5)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47
error Command failed with exit code 1.

I found out by trial and error that two things are triggering this error:

keyId should be lower case. Using keyid works. Because the character class of parameter key is lcalpha.
Making the List an InnerList by replacing the , separator with   separator. Not totally sure why? But I figure only InnerLists should be used inside a Dictionnary.

Am I by any chance correct in this analysis, or is it actually a bug in the parser? Meaning it would all of the examples of the HTTP Signature specifications are invalid?
I'm sorry to write an issue for something that could actually not be an issue in the parser. But I feel like you are more knowledgeable of the HTTP Structured Headers specifications, and thus more legitimate to actually dismiss the examples of the HTTP Signature draft.
Thanks for your time reading this.

Hi @DeGuitard
in my understanding, this example intends Dictionary and invalid.
according to https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-19

dict key should not be uppercase

so keyId should be keyid, key_id or key-id
   key           = ( lcalpha / "*" )
                   *( lcalpha / DIGIT / "_" / "-" / "." / "*" )

dict members are separated by ',' not ';'

   sf-dictionary  = dict-member *( OWS "," OWS dict-member )

inner list members are separated by space not ','

 inner-list    = "(" *SP [ sf-item *( 1*SP sf-item ) *SP ] ")"
                   parameters

So I think this should be encoded like below.
- sig1=(*request-target, *created, host, date, cache-control, x-empty-header, x-example); keyId="test-key-a"; alg=hs2019; created=1402170695; expires=1402170995
+ sig1=(*request-target *created host date cache-control x-empty-header x-example), key_id="test-key-a", alg=hs2019, created=1402170695, expires=1402170995

in my implementation also works fine.
console.log(parseDict('sig1=(*request-target *created host date cache-control x-empty-header x-example), key_id="test-key-a", alg=hs2019, created=1402170695, expires=1402170995'))
{
  sig1: {
    value: [
      { value: Symbol(*request-target), params: {} },
      { value: Symbol(*created), params: {} },
      { value: Symbol(host), params: {} },
      { value: Symbol(date), params: {} },
      { value: Symbol(cache-control), params: {} },
      { value: Symbol(x-empty-header), params: {} },
      { value: Symbol(x-example), params: {} }
    ],
    params: {}
  },
  key_id: { value: 'test-key-a', params: {} },
  alg: { value: Symbol(hs2019), params: {} },
  created: { value:<PHONE_NUMBER>, params: {} },
  expires: { value:<PHONE_NUMBER>, params: {} }
}

hope it helps you.

Hi @DeGuitard
in my understanding, this example intends Dictionary and invalid.
according to https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-19

dict key should not be uppercase

so keyId should be keyid, key_id or key-id
   key           = ( lcalpha / "*" )
                   *( lcalpha / DIGIT / "_" / "-" / "." / "*" )

dict members are separated by ',' not ';'

   sf-dictionary  = dict-member *( OWS "," OWS dict-member )

inner list members are separated by space not ','

 inner-list    = "(" *SP [ sf-item *( 1*SP sf-item ) *SP ] ")"
                   parameters

So I think this should be encoded like below.
- sig1=(*request-target, *created, host, date, cache-control, x-empty-header, x-example); keyId="test-key-a"; alg=hs2019; created=1402170695; expires=1402170995
+ sig1=(*request-target *created host date cache-control x-empty-header x-example), key_id="test-key-a", alg=hs2019, created=1402170695, expires=1402170995

in my implementation also works fine.
console.log(parseDict('sig1=(*request-target *created host date cache-control x-empty-header x-example), key_id="test-key-a", alg=hs2019, created=1402170695, expires=1402170995'))
{
  sig1: {
    value: [
      { value: Symbol(*request-target), params: {} },
      { value: Symbol(*created), params: {} },
      { value: Symbol(host), params: {} },
      { value: Symbol(date), params: {} },
      { value: Symbol(cache-control), params: {} },
      { value: Symbol(x-empty-header), params: {} },
      { value: Symbol(x-example), params: {} }
    ],
    params: {}
  },
  key_id: { value: 'test-key-a', params: {} },
  alg: { value: Symbol(hs2019), params: {} },
  created: { value:<PHONE_NUMBER>, params: {} },
  expires: { value:<PHONE_NUMBER>, params: {} }
}

hope it helps you.

Hello,
Thanks a lot for your answer. I agree with you, the example given in the latest HTTP Signature draft does seem wrong. I'm not really used to reading drafts from IETF, so maybe errors like these are common, I was just surprised that the specification of a field as important as keyId would not be compatible with the structures headers draft.
I went with an implementation similar to what you are suggesting. I do think though that the ; usage in the dict is correct, as per my understand these are parameters of the inner list. Basically it could look like:
sig1=(*created, x-example); keyId="test-key-a"; alg=hs2019; created=1402170695, sig2=(*created, digest); keyId="test-key-b"; alg=hs2019; created=1402170695

I'll try to send a message to the working group of the HTTP Signature through their mailing list.

Hello,
Thanks a lot for your answer. I agree with you, the example given in the latest HTTP Signature draft does seem wrong. I'm not really used to reading drafts from IETF, so maybe errors like these are common, I was just surprised that the specification of a field as important as keyId would not be compatible with the structures headers draft.
I went with an implementation similar to what you are suggesting. I do think though that the ; usage in the dict is correct, as per my understand these are parameters of the inner list. Basically it could look like:
sig1=(*created, x-example); keyId="test-key-a"; alg=hs2019; created=1402170695, sig2=(*created, digest); keyId="test-key-b"; alg=hs2019; created=1402170695

I'll try to send a message to the working group of the HTTP Signature through their mailing list.

Note: I found a new version (published 4 days ago) that contains the aforementionned fixes
https://httpwg.org/http-extensions/draft-ietf-httpbis-message-signatures.html
The new example:
Signature-Input: sig1=(*request-target *created host date
    cache-control x-empty-header x-example); keyid="test-key-a";
    alg=hs2019; created=1402170695; expires=1402170995

Note: I found a new version (published 4 days ago) that contains the aforementionned fixes
https://httpwg.org/http-extensions/draft-ietf-httpbis-message-signatures.html
The new example:
Signature-Input: sig1=(*request-target *created host date
    cache-control x-empty-header x-example); keyid="test-key-a";
    alg=hs2019; created=1402170695; expires=1402170995


BERT for text summarization

BERT is designed to solve 11 NLP problems. Which includes text summarization.
Is there any example how can we use BERT for summarizing a document? An approach would do and and example code would be really great.
Thanks in advance

I think you are using Google.colab.
I want to run the same on a local machine which is having P4000 GPU with 8GB RAM it is modest but I think suffices my requirements. However i am unable to run it here.
Can you tell me how to do a work around.
Thanks in advance

What is the error you get.. By default texar places all the tensors on gpu

### While running this block i.e. the last block

_#tx.utils.maybe_create_dir(model_dir)
#logging_file = os.path.join(model_dir, 'logging.txt')
model_dir = "gs://bert_summ/models/"uncased_L-12_H-768_A-12/bert_model.ckpt
logging_file= "logging.txt"
logger = utils.get_logger(logging_file)
with tf.Session() as sess:
sess.run(tf.global_variables_initializer())
sess.run(tf.local_variables_initializer())
sess.run(tf.tables_initializer())
smry_writer = tf.summary.FileWriter(model_dir, graph=sess.graph)

if run_mode == 'train_and_evaluate':
    logger.info('Begin running with train_and_evaluate mode')

    if tf.train.latest_checkpoint(model_dir) is not None:
        logger.info('Restore latest checkpoint in %s' % model_dir)
        saver.restore(sess, tf.train.latest_checkpoint(model_dir))

    iterator.initialize_dataset(sess)

    step = 5000
    for epoch in range(max_train_epoch):
      iterator.restart_dataset(sess, 'train')
      step = _train_epoch(sess, epoch, step, smry_writer)

elif run_mode == 'test':
    logger.info('Begin running with test mode')

    logger.info('Restore latest checkpoint in %s' % model_dir)
    saver.restore(sess, tf.train.latest_checkpoint(model_dir))

    _eval_epoch(sess, 0, mode='test')

else:
    raise ValueError('Unknown mode: {}'.format(run_mode))_

### The error I am getting is:-

PermissionDeniedError                     Traceback (most recent call last)
 in
10     sess.run(tf.tables_initializer())
11
---> 12     smry_writer = tf.summary.FileWriter(model_dir, graph=sess.graph)
13
14     if run_mode == 'train_and_evaluate':
~/anaconda3/envs/tf-1.8/lib/python3.6/site-packages/tensorflow/python/summary/writer/writer.py in init(self, logdir, graph, max_queue, flush_secs, graph_def, filename_suffix)
350
351     event_writer = EventFileWriter(logdir, max_queue, flush_secs,
--> 352                                    filename_suffix)
353     super(FileWriter, self).init(event_writer, graph, graph_def)
354
~/anaconda3/envs/tf-1.8/lib/python3.6/site-packages/tensorflow/python/summary/writer/event_file_writer.py in init(self, logdir, max_queue, flush_secs, filename_suffix)
65     self._logdir = logdir
66     if not gfile.IsDirectory(self._logdir):
---> 67       gfile.MakeDirs(self._logdir)
68     self._event_queue = six.moves.queue.Queue(max_queue)
69     self._ev_writer = pywrap_tensorflow.EventsWriter(
~/anaconda3/envs/tf-1.8/lib/python3.6/site-packages/tensorflow/python/lib/io/file_io.py in recursive_create_dir(dirname)
372   """
373   with errors.raise_exception_on_not_ok_status() as status:
--> 374     pywrap_tensorflow.RecursivelyCreateDir(compat.as_bytes(dirname), status)
375
376
~/anaconda3/envs/tf-1.8/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py in exit(self, type_arg, value_arg, traceback_arg)
517             None, None,
518             compat.as_text(c_api.TF_Message(self.status.status)),
--> 519             c_api.TF_GetCode(self.status.status))
520     # Delete the underlying status object from memory otherwise it stays alive
521     # as there is a reference to status from this from the traceback due to
PermissionDeniedError: Error executing an HTTP request (HTTP response code 401, error code 0, error message ''), response '{
"error": {
"errors": [
{
"domain": "global",
"reason": "required",
"message": "Anonymous caller does not have storage.objects.get access to bert_summ/models/.",
"locationType": "header",
"location": "Authorization"
}
],
"code": 401,
"message": "Anonymous caller does not have storage.objects.get access to bert_summ/models/."
}
}
'
when reading metadata of gs://bert_summ/models/

I received the same error.

the problem is i am writing it to my google cloud platform which you will not have access please change the location to your local filesystem (all gs: file paths with your local paths)

https://github.com/santhoshkolloju/bert_summ
I have replaced the Encoder part with Bert and kept the transformer decoder as it is . let me know if it helps

Do you have any examples of generated summaries?

I cannot share the results its my own data. But I have good results it was able to copy rare words as well. Initially I tried fine tuning both encoder(bert) and decoder both because of which Bert weights got disturbed. The. I freezed the weights of Bert and just trained the decoder part.
It was giving much readable and grammatically correct sentences.

@santhoshkolloju, Can you share your experience?
When I use your code, 'hypotheses' always have same value on every references.
for example,
references: ['do', 'n', "'", 't', 'wear', 'rings', 'when', 'working', 'on', 'engine', 'internal', '##s', '.', '[PAD]', '[PAD]', '[PAD]', ...]
hypotheses: ['do', 'n', "'", 't', 'try', 'to', 'do', 'n', "'", 't', 'mix', '.', '', '', '', ...]
references: ['broke', 'the', 'elevators', 'at', 'work', ',', 'basically', 'shot', 'myself', 'in', 'the', 'foot', 'in', 'doing', 'so', 'because', 'all', 'our', 'heavy', 'shit', 'is', 'downstairs', '.', '[PAD]', '[PAD]', '[PAD]', ...]
hypotheses: ['do', 'n', "'", 't', 'try', 'to', 'do', 'n', "'", 't', 'mix', '.', '', '', '', ...]
I used tifu dataset suggested from "Abstractive Summarization of Reddit Posts with Multi-level Memory Networks" paper.

There was a problem.. Freeze the Bert weights and run again
tf. get_trainable_variables()
And exclude all the variables which starts with "bert" then pass non Bert variables to optimizer

@santhoshkolloju Sorry for my question...
I tried hard freezing but I do not know what to do based on this codes..
Are you suggest how to freeze?
I tried to fix run_pretraining.py using export_savedmodel and removed all tpu related code.
But, loading pb file is failed..

In the notebook I shared replace this line code like shown below and run again it should work.
allvars = tf get_trainable_variables()
nonBert =[v for v in allvars if 'bert' not in v]
train_op = tx.core.get_train_op(
mle_loss,
learning_rate=learning_rate,
variables=non Bert,
global_step=global_step,
hparams=opt)

Thank you for your advice. I finally trained. Freezing bert encoder makes much readable and grammatically correct sentences. But Still cannot summarize well :'(..

In my case my data is some what easy one. It was not generating the sentences as it is but it is rephrasing which gives same meaning.
Try training for more iterations or passing the entity information to the model

Pointer generator is to be used when you have unknowns in the data with the subword tokenization hardly there are unknowns.
But let me know if you were able to improve on this

I am looking to use BERT model for abstractive text summarization, I checked out @santhoshkolloju code, will run and see, however, it would be really helpful if someone could guide me to articles/papers/resources/ code for abstractive summarization with BERT.

I am looking to use BERT model for abstractive text summarization, I checked out @santhoshkolloju code, will run and see, however, it would be really helpful if someone could guide me to articles/papers/resources/ code for abstractive summarization with BERT.

Check out this paper: https://arxiv.org/pdf/1810.04805.pdf
They still haven't released their code yet, but I'm currently working on reimplementing it in PyTorch and will make the code public once I'm done with it.

I am looking to use BERT model for abstractive text summarization, I checked out @santhoshkolloju code, will run and see, however, it would be really helpful if someone could guide me to articles/papers/resources/ code for abstractive summarization with BERT.

Check out this paper: https://arxiv.org/pdf/1902.09243.pdf
They still haven't released their code yet, but I'm currently working on reimplementing it in PyTorch and will make the code public once I'm done with it.

I would be, to put it mildly, extremely interested in this!

I tried the summarization on some wiki articles. Splited the text into sentences then averaged the CLS vectors from each sentence to get the "whole text CLS vec", then just picked a few sentences that were most similar to the whole text CLS (cosine similarity). Results were interesting, but not good enough for something serious (too simple and vague i guess).

For those interested, looks like we have an implementation! https://github.com/nayeon7lee/bert-summarization

For those interested, looks like we have an implementation! https://github.com/nayeon7lee/bert-summarization

it is not complete... :(

It's been almost half a year since BERT released. Does anybody know where to find any colab notebook which shows working summarization example?

Thank you for your advice. I finally trained. Freezing bert encoder makes much readable and grammatically correct sentences. But Still cannot summarize well :'(.. maybe we need more technic like Pointer Generator ,Bottom-Top Summarization... etc :)

Could you share your exprerience about bert encoder + transformer decoder + pointer generator? I wonder whether it will summarize well with pointer generator. Thanks

Is there anyone alive?

There is this paper
https://arxiv.org/pdf/1903.10318.pdf

@santhoshkolloju I think the result might have something to do with the batch size? I tried to print out the batches generated by the iterator(FeedableDataIterator from texar), and despite trying to set batch_size to 32, the size of the generated batch remained 4....

@Santosh-Gupta They have their code released here: https://github.com/nlpyang/BertSum, though it's not a colab example

hmm, any idea how to use it to end up with a function like summary_result = BertSum.summarize("Text to be summarized") ?

There is this paper
Fine-tune BERT for Extractive Summarization

Not extractive, Abstractive example please...

There is this paper
Fine-tune BERT for Extractive Summarization

Not extractive, Abstractive example please...

So you're looking to generate a summary, not just extract the most importance sentences?

I'm looking for both, thanks for the above link. I will look into it right away.

So you're looking to generate a summary, not just extract the most importance sentences?

Yes

I tried a bert encoder + similar transformer decoder on generating summaries. And none of them work.
I believe there are a lot of tricks I didn't realize for fine-tuning the network.

It looks like this repo is completed
https://github.com/nlpyang/BertSum
Also, UNILM gives some great abstractive summarization scores, maybe the best

UNILM gives some great abstractive summarization scores

I found UNILM paper only. Do you know where can we download the model? Any code example?

The authors say that they are preparing a release of the code and pretrained model

I found one useful paper which gave better performance than BERT for text summarization.
paper: https://arxiv.org/pdf/1905.02450.pdf
code: https://github.com/microsoft/MASS
Codes are not fully ready yet although.

Please see our paper using BERT for both extractive and abstractive summarization
https://arxiv.org/abs/1908.08345

How we can make BERT use our own ebooks (. Azw,. Epub or. Mobi) or pdf files?
And also specific website example success. Com
Thank you

@nlpyang, great! How do the results look like? Could somebody post here some examples, please?


fix(helm): resolve URLs and SemVers correctly

The original dependency resolution did not correctly resolve version or
URL of a dependency. Version was tracked by filename, and URL was
assumed to be absolute. This fixes both of those.
Closes #1277

This change is

LGTM pending CI


Ref #3660: platform.GetDefaultTimeZone fallback logic

Ref #3660

@jackhorton I'm not sure what the issue is with the bytecode causing tests to fail.
I'll close this PR since it's not worth putting effort into resolving a change this small by itself. Feel free to include this JS change in your branch as you work on #3659


Allow sub-bullets in change lists

Is there any reason not to allow this? There are no sub-bullets in the example in the spec, but also nothing forbidding their existence.
### Changed

- #6: Bla bla bla
  - Details

Currently, auto-changelog validate will error on   - Details.

This was a mistake. It might actually require that each changelog entry is a single line? I'll investigate.

I didn't intend #45 to close this. Re-opening.


Let getFreshValue know whether the update is happening in the background or not

Here's what I've got:

function abortTimeoutSignal(timeMs: number) {
  const abortController = new AbortController()
  void new Promise(resolve => setTimeout(resolve, timeMs)).then(() => {
    abortController.abort()
  })
  return abortController.signal
}

async function gravatarExistsForEmail({
  email,
  request,
  timings,
  forceFresh,
}: {
  email: string
  request: Request
  timings?: Timings
  forceFresh?: boolean
}) {
  return cachified({
    key: `gravatar-exists-for:${email}`,
    cache: lruCache,
    request,
    timings,
    forceFresh,
    ttl: 1000 * 20,
    staleWhileRevalidate: 1000 * 60 * 60 * 24 * 365,
    checkValue: prevValue => typeof prevValue === 'boolean',
    getFreshValue: async () => {
      const gravatarUrl = getAvatar(email, {fallback: '404'})
      try {
        const avatarResponse = await fetch(gravatarUrl, {
          method: 'HEAD',
          signal: abortTimeoutSignal(1000 * 2),
        })
        return avatarResponse.status === 200
      } catch (error: unknown) {
        console.error(`Error getting gravatar for ${email}:`, error)
        return false
      }
    },
  })
}

I have the abortTimeoutSignal thing in place so gravatar won't cause me issues if my page is waiting on it. I think if my page is waiting on it I'd prefer that the timeout time be more like 500ms, but if the update is happening in the background (SWR) then I'm fine with it taking even 10 seconds. Thoughts? Maybe an argument passed to getFreshValue?

Hi Kent 👋 Sounds useful to me 👍
To be clear: When you say "In the background", you mean a case where the cachified call returned a stale cache value and getFreshValue is called in the background to eventually provide a fresh value for the next call right?

Exactly 👍

Could you give<EMAIL_ADDRESS>a try?
The info is passed on the new GetFreshValueConext
cachified({
  /* ... */
  ttl: 5,
  staleWhileRevalidate: 20,
  getFreshValue({ background }) {
    console.log(background);
    return 'value'
  }
});

Sweet! I'll give this a try soon and report back. Thanks!

Works great 👍 Thank you.

Glad to hear that! It's released under v3.1.0

Super, thanks a lot :)


token is hardcoded as response_type

response_type is always coming as token.  It should be either code or token based on the oauthGrantType

created a PR for your review: https://github.com/marmelab/ra-auth-cognito/pull/17


[vcpkg] Resolve macos host machines running out of disk space by reducing size and using fixed disks.

vcpkg-eg-mac-11 is already running with this change so I think we can merge  this without rerolling all the machines.

vcpkg-eg-mac-11 is already running with this change so I think we can merge  this without rerolling all the machines.


How to efficiently print an srt_string*?

What I'm doing right now:
srt_string* srt = ss_dup_c("some string");
printf("the string is: %s\n", ss_to_c(srt));

Hi @drkameleon, the ss_dup_c() involves heap allocation, requiring further deallocation, with ss_free() (internally does one call to malloc() and one to free() -C library, with from 0 to 2 OS trap calls, depending on the allocation pool-). The call to ss_to_c() is O(1), while the call to "printf" would typically involve one 0 to 1 OS trap calls (printf() is buffered, so not always translated to one OS trap call).
void example1()
{
        srt_string* srt = ss_dup_c("some string");
        printf("the string is: %s\n", ss_to_c(srt));
        ss_free(&srt);
}

If you don't need to modify the data, you can use ss_crefa() instead of the "dup" function, involving zero heap usage and zero copy (it uses a very small amount of memory on the stack for allocating the reference to the original string), e.g.
void example2()
{
        const srt_string* srt = ss_crefa("some string");
        printf("the string is: %s\n", ss_to_c(srt));
}

In the future I'll probably add a full implementation of sprintf supporting the "srt" strings, just for fun, so the formatting can be done avoiding strlen() calls (in the same way of ss_cat*() work, doing just one resize no matter the number of parameters given).

Thanks a lot for your answer!
And thanks for making clear the use of ss_crefa (I've played with it but wasn't 100% what the caveats were).


Variables were missing the leading character

Hi @lavahot, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@lavahot  Thanks for the contribution! I've forwarded this change to the author for review.

Wow, good catch -- a formatting error when it was moved from MSDN. Yes, OK to accept. Many thanks!


Fix pinch crash in touch-responsive views.

Motivation (required)
Multiple react native developer (including myself) have run into a crash with the react-native-photo-view library (and possibly others). The common solution to this problem lies in the underlying java code, and thus requires a change in the react native source.
The stack trace I am getting is the same as listed here https://github.com/alwx/react-native-photo-view/issues/15.
There was a PR to fix this (#12085) but it was closed. In response to the comments there, in my PR, I do log the exceptions. I don't think we can get any closer to the exception because in the next level of the stack trace, we are in the android sdk code.
Looking at some stack overflow pages and the android bug tracker, it seems that this is the common solution to this bug, and does not cause any impact any functionality.
https://code.google.com/p/android/issues/list?can=1&q=pointerindex+out+of+range&colspec=ID+Status+Priority+Owner+Summary+Stars+Reporter+Opened&cells=tiles
Test Plan (required)
I have manually tested this by compiling react native android from source and have confirmed the exception still gets hit and logged, but does not cause the app to terminate.

@mkonicek, I think this looks reasonable as the underlying Android bug is documented

@gillessed, there is also https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayout.java#L37 having the same crash there

It's popular in photo view.

Hi there, any news on this ?
It seems that the tests are failing due to a timeout. Can someone restart the build ?

@gillessed Could you rebase and look at adding the check to ReactDrawerLayout  too?

Sorry for leaving this for so long. I'll try to rebase tonight.

Having the same crash with the react-native-maps library from Airbnb: https://github.com/airbnb/react-native-maps

@gillessed Could you rebase again and make sure the tests pass?
@hramos Any chance of merging this once it's rebased and the tests pass?

@ericvicenti I don't really know what's causing those test failures since they seem completely unrelated to what I changed. This isn't as important for me anymore since we switched to using a different component. If I could get some insight into why the tests are failing, this could be a quick process, but I don't have a lot of time to sink into this right now.

Tests should be green now. Can you rebase and address the conflicts?

@hramos I think maybe you already landed this fix in my PR that was a fork of this? https://github.com/facebook/react-native/pull/17167