iOS 14 UI discussion

Hi!
While working on my project, I worked on a way to get the date picker to show up like the new iOS 14 native date picker. A GIF is attached to show what it looks like.
It removes the header text, as well as the cancel and confirm buttons. Instead of changing with the onConfirm, I leverage @react-native-community/datetimepicker's onChange prop. And instead of using a cancel button, the user can just tap outside the modal to have the window close.
If you're interested, would love to work with you to implement this version into your library. Let me know what you need from me.
Best,
Scott

Hey @scott-massey welcome back :D
This looks exactly like what I was planning to do after #558 gets merged.
My idea was to show the "new" picker for the date and datetime mode, and use the old spinner picker for the time mode planning to pick just the time — because using the new layout on the time alone doesn't look very good in a modal.
Are you doing the same?
I'm curious to see what changes you're making... IIRC in my case #558 + changing the display mode was enough to achieve a look like the one you're using in your picker 🤔

I'm dumb. I didn't notice you remove the confirm/cancel buttons 😬 Let's talk about it. From my perspective, the problem with it, is that it would have a different API from Android — and I think it's pretty important to maintain the same API between the two platforms (given it's one of the main use cases)

If you're worried about the buttons missing, we can implement buttons that look like this instead. That way the modal looks more friendly in the center of the screen

Additionally, I had to do a decent amount of work to get the modal to show up in the center of the screen, as well as bump it up when the keyboard opens. Nothing crazy but we'd want to implement that code as well.

If you're worried about the buttons missing, we can implement buttons that look like this instead. That way the modal looks more friendly in the center of the screen.

Looking good. Do you know if there's any native API that is using this "look" for a picker? Or any iOS setting that I can tap on to show a modal/dialog with buttons? Just to understand what the official iOS guidelines are promoting.

The one frustrating thing with the buttons though is that there is no built-in localization support like there is on android, and we can't implement that without forcing devs to install react-native-localize, which seems like an undue burden.

Isn't this the same problem we already have with the current version?
The workaround is to localize them using cancelTextIOS and confirmTextIOS — on one hand, it's true that it would be better if users didn't have to go through it to customize the buttons... on the other hand, if you're localizing your app you're probably already using a localization lib (which is why this issue hasn't been reported often) :/

Additionally, I had to do a decent amount of work to get the modal to show up in the center of the screen, as well as bump it up when the keyboard opens. Nothing crazy but we'd want to implement that code as well.

Yeah sorry, I didn't see you removed the confirm/cancel button. By going down this path there's definitely some UI work that needs to be done, I agree 👍

Looking good. Do you know if there's any native API that is using this "look" for a picker? Or any iOS setting that I can tap on to show a modal/dialog with buttons? Just to understand what the official iOS guidelines are promoting.
I just looked up "ios 14 date picker" on google images. Most didn't have any buttons, but a couple had smaller buttons. I recreated one of the screenshots I saw pretty easily, see the attached screenshot. Would love your thoughts.
Isn't this the same problem we already have with the current version?
The workaround is to localize them using cancelTextIOS and confirmTextIOS — on one hand, it's true that it would be better if users didn't have to go through it to customize the buttons... on the other hand, if you're localizing your app you're probably already using a localization lib (which is why this issue hasn't been reported often) :/
Makes lots of sense, got it.

Thanks. I'll look for native modals/dialog 👍

How would you deal with the time-picker?

I haven't needed to for my project, but it would probably make sense to keep the time picker as a spinner like before

Hey @scott-massey. I investigated a bit, the iOS guidelines aren't still saying anything about what kind of button/modals to use. So, for the time being, I'm still planning to use the same components we're currently usings since they work well with all use cases.
I also updated #558 to add some more info on how to support the new iOS 14 style (e.g.: added padding to the modal + updated the README.md). I'm open to feedback and I'm keeping this issue open to continue the discussion in the future :)

Hi @scott-massey!
I'm currently working on something pretty similar on what you implemented.
Could you share how you came up with the solution?
I was considering implementing without this library, but after @react-native-community/datetimepicker closing your issue there, I'm mostly lost on what to do.

Hey @stearruda , just FYI, we now support all picker styles: #558 .
Additionally, it looks like from iOS 15 their reverting back to the pre-iOS14 style as the default time and date picker.

Tks for the info @mmazzarolo!
I'll share the info of iOS 15 with my team too. I didn't know that.
BTW In the end, I've implemented the Date Picker with react-native-modal-datetime-picker together with my Text Input from RN-Paper.
I believe it would take me much more time to do it my own than using the library.
I was having some foundation on how to implement from a previous code of my job (in the deprecated RN the Date Picker) which had an open method. It made me really confused on what to do without it and in this new world of Date Picker. :sweat_smile:

Hi @stearruda! Apologies on not responding, I totally missed this. I ended up using the React Native modal styles to hack together a version that fit with what I needed. Let me know if you still want more info.

No worries @scott-massey !
Like I said before I've used the library in the end because of time constraints on my project.
I'm glad that I could find something that handled that already. 🙌


Add CI/CD integration test for URL phishing and security scanning

Reach out me for more details!

Reach out me for more details!

would love to help on this!


Set up CI with Azure Pipelines

Coverage remained the same at 90.652% when pulling fd83cc35869f7037977b30b859065f2fa7bccc5a on azure-pipelines into 8c30834ccce40c78ad8c3fd2a1bad344a0a72d05 on master.

Coverage remained the same at 90.652% when pulling fd83cc35869f7037977b30b859065f2fa7bccc5a on azure-pipelines into 8c30834ccce40c78ad8c3fd2a1bad344a0a72d05 on master.


Docs: Add how to develop locally

I have received the same question lately a couple of times. It's not documented anywhere how to develop a plugin locally with Grafana so adding it here. Maybe @grafana/docs-squad can suggest a better place for a guide like this? (rather than having to write this for each plugin).

Nice!
Not all contributors have the need to run grafana locally. I wonder if we should also start providing docker-compose files for all our plugins that will allow enable running the plugin without cloning Grafana? I sometimes find this useful myself. Thoughts @andresmgot @yaelleC?
version: '3.7'

services:
  grafana:
    image: grafana/grafana:latest
    ports:
      - '3000:3000'
    volumes:
      - ./:/var/lib/grafana/plugins/redshift-datasource
      - ./provisioning:/etc/grafana/provisioning
    environment:
      - TERM=linux
      - GF_LOG_LEVEL=debug
      - GF_DATAPROXY_LOGGING=true

Good call!
I was starting to look into something along these lines too for the e2e tests. Something with GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS too?
That seems very useful to plugin contributors, less hassle 👍

This information will surely help the community. Thanks for putting this together.
Are these instructions generic and can be used to build any plugin? As far as location goes, I will recommend that we add this content as a topic after this: https://grafana.com/docs/grafana/latest/developers/plugins/. What do you think?

I was starting to look into something along these lines too for the e2e tests. Something with GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS too?

Yes good catch! Probably good to include a storage volume too. Something like this
version: '3.7'

services:
  grafana:
    image: grafana/grafana:latest
    ports:
      - '3090:3000'
    volumes:
      - ./:/var/lib/grafana/plugins/redshift-datasource
      - grafana-storage:/var/lib/grafana
      - ./[path-to-provisioning]:/etc/grafana/provisioning
    environment:
      - COMPOSE_INTERACTIVE_NO_CLI=1
      - TERM=linux
      - GF_LOG_LEVEL=debug
      - GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=grafana-redshift-datasource
volumes:
  grafana-storage:

Thanks for the comments! I am going to move now this guide to https://grafana.com/docs/grafana/latest/developers/plugins/.

Moved the doc to https://github.com/grafana/grafana/pull/47121 :)

This can be finally merged


Can't connect to my bot from bot emulator

When I try to connect with my emulator, I get the following error:
POST connect ECONNREFUSED <IP_ADDRESS>:3979
I tried running VS as administrator and created a 'virtual directory' in:
project properties -> web tab -> create visual directory.
Visual Directory is set to: http://localhost:3979/, where '3979' is my local port get from running VS bot template. When you run the template from VS, it opens the browser with the url below:
http://localhost:3979/, so I am sure that Virtual Directory is right.
Your shared ideas are highly appreciated.

Closed because 'BotFramework-Emulator' is more specific.


Command to show in split or popup explicitly.

Show/Toggle should respect the user's setting.
But an explicit :ShowSplit or :ShowPopup would be useful in a case where you temporarily want the other one.

This is done and we have ExecutorSwapToSplit and ExecutorSwapToPopup


Show icons in tab navigations in playground in android

As it is mentioned here https://github.com/react-community/react-navigation/issues/516 there is need to set showIcon: true for tab navigators to show the icons.
This PR fixes navigation playground on android platform.

The example is working as intended. Android tabs with icons it not very common.


LineChart TooltipLine does not display the correct color

Describe the bug
The Tooltip Line of the LineChart is by default colored as the upper positioned line, this works very unreliably. See image for a visual impression:

The bottom brown vertical line should be red from my understanding.
Versions
Flutter version
Flutter 2.5.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 18116933e7 (5 weeks ago) • 2021-10-15 10:46:35 -0700
Engine • revision d3ea636dc5
Tools • Dart 2.14.4

Fl Chart Version:
  fl_chart: ^0.40.2

The indicator lines are drawn by the order of the lines.
In your example, brown is the frontest line and that's why you see brown.

An understandable programming pov, but from the design perspective this might need improvement.
I understand if this is too much effort to do, so I'd argue, to handle it like syncfusions chart package and to be able to set the line color as one color (if that is not already possible)

I understand it is not good from design perspective.
There is an opened issue already.
You can follow-up this issue here: #198

Thank you for linking the right issue.
I close this one as duplicate of #198.


Package.getActivationCommands is deprecated.

Auto-generated issue:
Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:
  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (C:\Users\jelmaa\AppData\Local\atom\app-0.196.0\resources\app.asar\src\package.js:790:9)
Package.hasActivationCommands (C:\Users\jelmaa\AppData\Local\atom\app-0.196.0\resources\app.asar\src\package.js:715:20)
<unknown> (C:\Users\jelmaa\AppData\Local\atom\app-0.196.0\resources\app.asar\src\package.js:169:24)
Package.measure (C:\Users\jelmaa\AppData\Local\atom\app-0.196.0\resources\app.asar\src\package.js:147:15)

+1

Merged pull request #98


Fix compability break with OIIO < 2.2 (from change 1295)

Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

I expect most of the CI tests to fail for unrelated reasons (it's because of changes in the ASWF docker images, which are in the processes of being fixed).


Enderman can teleport to and inside of shafts

Describe the Bug
See video.
Reproduction Steps

Place a lot of shafts in the void.
Force endermen to teleport.

Expected Result
Teleporting into blocks doesn't sound intended.
Screenshots and Videos
https://github.com/user-attachments/assets/c3a68771-da61-42eb-8127-7def8a58e656
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
None
Additional Context
Occurs in Forge and Fabric.

PR'd upstream


ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI

Set ARROW_WITH_OPENTELEMETRY: ON in C++ GitHub Actions workflow
Add default value for ExecNode::ToStringExtra argument indent argument

Is the option making it though to the build? I see the env variable but this line suggests it's not actually turned on in the CMake Configure:
https://github.com/apache/arrow/runs/5040342323?check_suite_focus=true#step:7:460
Also, maybe we should also add this to a Linux build, like the AMD64 Conda C++ one?

Is the option making it though to the build? I see the env variable but this line suggests it's not actually turned on in the CMake Configure:
https://github.com/apache/arrow/runs/5040342323?check_suite_focus=true#step:7:460

Thanks for spotting that! I forgot to update the build script.

Also, maybe we should also add this to a Linux build, like the AMD64 Conda C++ one?

This is blocked on https://github.com/apache/arrow/pull/11963. I'll add a reminder to that PR to enable OpenTelemetry in CI once that gets merged.

Disabling OT in Windows builds in this PR. The fix from #11963 should also fix those builds: https://github.com/apache/arrow/blob/8573ba86990968ab95ac8e53d05071f917da93d4/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4126-L4128

@github-actions crossbow submit -g cpp

@github-actions crossbow submit test-ubuntu-18.04-*

The "python-sdist" nightly build started failing (see https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true), with a message that seems related to OpenTelemetry:
 -- stderr output is:
CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
  error: could not find git for clone of opentelemetry-proto
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
  cmake/opentelemetry-proto.cmake:9 (ExternalProject_Add)
  CMakeLists.txt:363 (include)

CMake Error at /build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep-stamp/opentelemetry_ep-configure-DEBUG.cmake:47 (message):
  Stopping after outputting logs.

So potentially related to this PR (note, I didn't actually look into it, just looked at commits in the last day that could be related to the new failure, and pinging here in case you could take a look).

The "python-sdist" nightly build started failing (see https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true), with a message that seems related to OpenTelemetry:
 -- stderr output is:
CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
  error: could not find git for clone of opentelemetry-proto
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
  cmake/opentelemetry-proto.cmake:9 (ExternalProject_Add)
  CMakeLists.txt:363 (include)

CMake Error at /build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep-stamp/opentelemetry_ep-configure-DEBUG.cmake:47 (message):
  Stopping after outputting logs.

So potentially related to this PR (note, I didn't actually look into it, just looked at commits in the last day that could be related to the new failure, and pinging here in case you could take a look).

It looks like git is removed before the build starts: https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true#step:6:501.
Should we change that or disable OpenTelemetry for these builds?

This removal of git was added in https://github.com/apache/arrow/pull/10342, cc @kszucs

I opened https://github.com/apache/arrow/pull/12356 for the python-sdist failure.

This removal of git was added in #10342, cc @kszucs

@kszucs do you remember the reason for it?
We now have a similar failure of the python-sdist build, this time the new substrait option requiring git:
 CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
  error: could not find git for clone of substrait_ep
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
  src/arrow/engine/CMakeLists.txt:50 (externalproject_add)

This removal of git was added in #10342, cc @kszucs

@kszucs do you remember the reason for it?

Git was used to generate a version number even for a python sdist release with explicit version and already available source code.

We now have a similar failure of the python-sdist build, this time the new substrait option requiring git:
 CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
  error: could not find git for clone of substrait_ep
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
  src/arrow/engine/CMakeLists.txt:50 (externalproject_add)

I think we should avoid hard dependency on git and prefer downloading tarballs from github.

I think we should avoid hard dependency on git and prefer downloading tarballs from github.

Opened a JIRA for this: https://issues.apache.org/jira/browse/ARROW-15760

We should pass
    URL "https://github.com/${ARROW_SUBSTRAIT_REPO}/archive/${ARROW_SUBSTRAIT_TAG}.tar.gz"

instead of
https://github.com/apache/arrow/blob/bee67c5f2ff84a1759d02b45d7a0cea9b494175b/cpp/src/arrow/engine/CMakeLists.txt#L51-L52


Fix failure if LOGIN_REDIRECT_URL is an URL

If LOGIN_REDIRECT_URL is an URL (and not a named URL), adding or removing an backup phone will generate an error: Reverse for '/accounts/login/' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []
This is due to PhoneSetupView and PhoneDeleteView that pass LOGIN_REDIRECT_URL to reverse_lazy. But reverse_lazy only works with an named URL or a view function.
To reproduce this issue, changing tests.settings.LOGIN_REDIRECT_URL from "two_factor:profile" to "/account/two_factor/" will reproduce this issue when running tests.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 5680563e6a6b5995bbc0fddedf386289d0586c53 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

@PierreF tests?

To add test, I have to change LOGIN_REDIRECT_URL and it must be done very early because when PhoneSetupView is defined, it will capture the current value of settings.LOGIN_REDIRECT_URL).
Changing later (using @override_settings or similar) has no effect.
The only clean solution I think of is to add another test flavour for tox and use environment to change the value of LOGIN_REDIRECT_URL. In a similar way custom_user is done. But this will add more tests combination... does it worth it ?
Another idea could be to monkey-patch two_factor.views.core.PhoneSetupView.success_url in a test, something like:
with self.settings(LOGIN_REDIRECT_URL='/account/two_factor/'):
    two_factor.views.core.PhoneSetupView.success_url = settings.LOGIN_REDIRECT_URL
    # Test

But it's not very clean... the test-case monkey-patch the code with a (partial) fix.

Surely just setting values (both by plain urls and reverse_lazy) of success_url and then calling get_context_data/get_success_url to check the output would be enough? LOGIN_REDIRECT_URL is only the default value and doesn't need to be touched (in my opinion)

I've added some tests. Are you thinking to tests like those ?
get_success_url only exists with the DeleteView not with the WizardView. So for PhoneSetupView I only test get_context_data.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

Coverage increased (+0.009%) to 95.883% when pulling 603b18ca5fb4c31764be0e22e7399d5028d58484 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

You should also be testing with LOGIN_REDIRECT_URL = reverse_lazy('blah') (because people will probably want that) and with URL names LOGIN_REDIRECT_URL = 'blah' (for backwards compatibility testing)
Sorry for the late reply.

Coverage increased (+0.009%) to 95.883% when pulling d3bd99b35209c15b6cafb89f349aee437742ea98 on PierreF:login-redirect-url-as-url into 4b3dddeae8c3d479152976fa6e7bdd8d1ed24e69 on Bouke:master.

It is good with latest changes or something is still missing on the tests ?

Had a quick look at your latest commit, looks good.

Coverage increased (+0.009%) to 95.879% when pulling 391271682cdfdb3e1c8d85c378487a28f334c49a on PierreF:login-redirect-url-as-url into 3856fe2a6db3de11561fe02e4937c87c86907fba on Bouke:master.

Thank you for your contribution!


Support for multi project workspace with all config at workspace level

I use vscode with one workspace to hold all of my esp32 projects (TestBlink, TestWifi, ..), and I'm trying to configure all of my development tasks and settings at the esp32 workspace level - ideally with no .vscode in each project. I use the cmake extension for project building, and gdb/openocd over jtag for flash and debug.
I have three issues/feature requests between me and "success".

It seems to me a sensible use case that I have several projects in my esp32 workspace, with some concept of a currently selected project which my scripts then operate on. The cmake extension almost supports this with its "Select Active Folder", but there doesn't appear to be a way to access this selection in my scripts (e.g. ${command:cmake.activeFolder} or similar). I may yet raise a feature request with them for this, but it does seem a better solution that vscode supports this (and changes ${workspaceRoot} accordingly). However, in the scenario with multiple projects
with no .vscode, I'm told by vscode that "${workspaceRoot} cannot be resolved, please open a folder". Just so, but what does opening a folder mean? The only workaround is to only ever have a single project loaded into my workspace.

I use a preLaunchTask to flash the target. However, it seems I'm forced to provide a project level tasks.json defining "Flash", because otherwise vscode won't resolve the "Flash" task name to a workspace level task. Or perhaps I'm not using the undocumented "type:" in the preLaunchTask config correctly?

Rather than the (naff) situation at present where "Run without Debug" still hits the debug entry breakpoint, I'd like some variable (e.g. ${currentCommand} or similar) which I can pass into my pre-launch Flash script. This could perform the Flash, then switch on the command and if "Run without Debug" it can just issue a hard reset to the target before exiting with nonzero status to bypass the debugger. Does a suitable variable exist?

We already support workspace level settings, tasks and launches. Looks like user have issues with

${workspaceRoot} - resolving this config variable (Debug or Tasks)?
preLaunchTask - Tasks
currentCommand in Run without Debug

Hence moving to tasks and debug owners.

Please use ${workspaceFolder} scoped per folder. More details here https://code.visualstudio.com/docs/editor/variables-reference#_variables-scoped-per-workspace-folder
I leave this to Alex Ross
This sounds like a feature request please file a new concise issue explaiaing what exaclty you need

I use a preLaunchTask to flash the target. However, it seems I'm forced to provide a project level tasks.json defining "Flash", because otherwise vscode won't resolve the "Flash" task name to a workspace level task. Or perhaps I'm not using the undocumented "type:" in the preLaunchTask config correctly?

Can you give an example of the relevant files for this (launch.json, .code-workspace, and task.json)?

On Mon, 2020-04-06 at 02:07 -0700, Alex Ross wrote:

I use a preLaunchTask to flash the target. However, it seems I'm
forced to provide a project level tasks.json defining "Flash",
because otherwise vscode won't resolve the "Flash" task name to a
workspace level task. Or perhaps I'm not using the undocumented
"type:" in the preLaunchTask config correctly?

Can you give an example of the relevant files for this (launch.json,
.code-workspace, and task.json)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "
https://github.com/microsoft/vscode/issues/92260#issuecomment-609670184
",
"url": "
https://github.com/microsoft/vscode/issues/92260#issuecomment-609670184
",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Hi,
In trying to reproduce I now realise this is only an issue when
attempting to call a workspace-level task from a project-level launch
task (and maybe vice versa - I haven't tried that). So with everything
at workspace level (as in working-example...) the Flash task executes,
but with the project-level launch task I get "Could not find task
Flash".

Since my aim was everything at the workspace level, this is no longer
an issue for me.  However, I guess somebody else may
come up against the issue.
Cheers,
Ross.
{
"settings": {
"C_Cpp.default.compilerPath": "${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc",
"C_Cpp.default.compileCommands": "${workspaceFolder}/build/compile_commands.json",
"C_Cpp.default.includePath": ["${env:HOME}/esp32/esp-idf/components/xtensa/include","${env:HOME}/esp32/esp-idf/components/xtensa/esp32/include","${env:HOME}/esp32/esp-idf/components/newlib/platform_include","${env:HOME}/esp32/esp-idf/components/freertos/include","${env:HOME}/esp32/esp-idf/components/freertos/xtensa/include","${env:HOME}/esp32/esp-idf/components/heap/include","${env:HOME}/esp32/esp-idf/components/log/include","${env:HOME}/esp32/esp-idf/components/lwip/include/apps","${env:HOME}/esp32/esp-idf/components/lwip/include/apps/sntp","${env:HOME}/esp32/esp-idf/components/lwip/lwip/src/include","${env:HOME}/esp32/esp-idf/components/lwip/port/esp32/include","${env:HOME}/esp32/esp-idf/components/lwip/port/esp32/include/arch","${env:HOME}/esp32/esp-idf/components/soc/src/esp32/.","${env:HOME}/esp32/esp-idf/components/soc/src/esp32/include","${env:HOME}/esp32/esp-idf/components/soc/include","${env:HOME}/esp32/esp-idf/components/esp_rom/include","${env:HOME}/esp32/esp-idf/components/esp_common/include","${env:HOME}/esp32/esp-idf/components/esp32/include","${env:HOME}/esp32/esp-idf/components/driver/include","${env:HOME}/esp32/esp-idf/components/driver/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_ringbuf/include","${env:HOME}/esp32/esp-idf/components/efuse/include","${env:HOME}/esp32/esp-idf/components/efuse/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_timer/include","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32/include","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32/../include","${env:HOME}/esp32/esp-idf/components/vfs/include","${env:HOME}/esp32/esp-idf/components/esp_wifi/include","${env:HOME}/esp32/esp-idf/components/esp_wifi/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_event/include","${env:HOME}/esp32/esp-idf/components/esp_netif/include","${env:HOME}/esp32/esp-idf/components/esp_eth/include","${env:HOME}/esp32/esp-idf/components/tcpip_adapter/include","${env:HOME}/esp32/esp-idf/components/app_trace/include","${env:HOME}/esp32/esp-idf/components/mbedtls/port/include","${env:HOME}/esp32/esp-idf/components/mbedtls/mbedtls/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/port/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/include/esp_supplicant","${env:HOME}/esp32/esp-idf/components/bootloader_support/include","${env:HOME}/esp32/esp-idf/components/app_update/include","${env:HOME}/esp32/esp-idf/components/spi_flash/include","${env:HOME}/esp32/esp-idf/components/nvs_flash/include","${env:HOME}/esp32/esp-idf/components/pthread/include","${env:HOME}/esp32/esp-idf/components/espcoredump/include","${env:HOME}/esp32/esp-idf/components/perfmon/include","${env:HOME}/esp32/esp-idf/components/asio/asio/asio/include","${env:HOME}/esp32/esp-idf/components/asio/port/include","${env:HOME}/esp32/esp-idf/components/cbor/port/include","${env:HOME}/esp32/esp-idf/components/coap/port/include","${env:HOME}/esp32/esp-idf/components/coap/port/include/coap","${env:HOME}/esp32/esp-idf/components/coap/libcoap/include","${env:HOME}/esp32/esp-idf/components/coap/libcoap/include/coap2","${env:HOME}/esp32/esp-idf/components/console","${env:HOME}/esp32/esp-idf/components/nghttp/port/include","${env:HOME}/esp32/esp-idf/components/nghttp/nghttp2/lib/includes","${env:HOME}/esp32/esp-idf/components/esp-tls","${env:HOME}/esp32/esp-idf/components/esp_adc_cal/include","${env:HOME}/esp32/esp-idf/components/esp_gdbstub/include","${env:HOME}/esp32/esp-idf/components/tcp_transport/include","${env:HOME}/esp32/esp-idf/components/esp_http_client/include","${env:HOME}/esp32/esp-idf/components/esp_http_server/include","${env:HOME}/esp32/esp-idf/components/esp_https_ota/include","${env:HOME}/esp32/esp-idf/components/protobuf-c/protobuf-c","${env:HOME}/esp32/esp-idf/components/protocomm/include/common","${env:HOME}/esp32/esp-idf/components/protocomm/include/security","${env:HOME}/esp32/esp-idf/components/protocomm/include/transports","${env:HOME}/esp32/esp-idf/components/mdns/include","${env:HOME}/esp32/esp-idf/components/esp_local_ctrl/include","${env:HOME}/esp32/esp-idf/components/sdmmc/include","${env:HOME}/esp32/esp-idf/components/esp_serial_slave_link/include","${env:HOME}/esp32/esp-idf/components/esp_websocket_client/include","${env:HOME}/esp32/esp-idf/components/expat/expat/expat/lib","${env:HOME}/esp32/esp-idf/components/expat/port/include","${env:HOME}/esp32/esp-idf/components/wear_levelling/include","${env:HOME}/esp32/esp-idf/components/fatfs/diskio","${env:HOME}/esp32/esp-idf/components/fatfs/vfs","${env:HOME}/esp32/esp-idf/components/fatfs/src","${env:HOME}/esp32/esp-idf/components/freemodbus/common/include","${env:HOME}/esp32/esp-idf/components/idf_test/include","${env:HOME}/esp32/esp-idf/components/jsmn/include","${env:HOME}/esp32/esp-idf/components/json/cJSON","${env:HOME}/esp32/esp-idf/components/libsodium/libsodium/src/libsodium/include","${env:HOME}/esp32/esp-idf/components/libsodium/port_include","${env:HOME}/esp32/esp-idf/components/mqtt/esp-mqtt/include","${env:HOME}/esp32/esp-idf/components/openssl/include","${env:HOME}/esp32/esp-idf/components/spiffs/include","${env:HOME}/esp32/esp-idf/components/ulp/include","${env:HOME}/esp32/esp-idf/components/unity/include","${env:HOME}/esp32/esp-idf/components/unity/unity/src","${env:HOME}/esp32/esp-idf/components/wifi_provisioning/include"],
"C_Cpp.default.configurationProvider": "vector-of-bool.cmake-tools",
"cmake.generator": "Ninja",
"cmake.environment": {
"IDF_PATH": "${env:HOME}/esp32/esp-idf",
"IDF_TARGET": "esp32",
"PYTHON_DEPS_CHECKED": "1",
"ESP_PLATFORM": "1",
"CCACHE_ENABLE": "0",
"PATH": "${env:HOME}/esp32/esp-idf/components/esptool_py/esptool:${env:HOME}/esp32/esp-idf/components/espcoredump:${env:HOME}/esp32/esp-idf/components/partition_table/:${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin:${env:HOME}/.espressif/tools/xtensa-esp32s2-elf/esp-2019r2-8.2.0/xtensa-esp32s2-elf/bin:${env:HOME}/.espressif/tools/esp32ulp-elf/2.28.51-esp-20191205/esp32ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/esp32s2ulp-elf/2.28.51-esp-20191205/esp32s2ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/bin:${env:HOME}/esp32/esp-idf/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"CXXFLAGS": "-DRMT_DEBUG"},
"task.autoDetect": "off",
"terminal.integrated.env.linux": {
"IDF_PATH": "${env:HOME}/esp32/esp-idf",
"PATH": "${env:HOME}/esp32/esp-idf/components/esptool_py/esptool:${env:HOME}/esp32/esp-idf/components/espcoredump:${env:HOME}/esp32/esp-idf/components/partition_table/:${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin:${env:HOME}/.espressif/tools/xtensa-esp32s2-elf/esp-2019r2-8.2.0/xtensa-esp32s2-elf/bin:${env:HOME}/.espressif/tools/esp32ulp-elf/2.28.51-esp-20191205/esp32ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/esp32s2ulp-elf/2.28.51-esp-20191205/esp32s2ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/bin:${env:HOME}/esp32/esp-idf/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"IDF_WORKSPACE": "${env:HOME}/esp32/esp-idf_workspace",
"OPENOCD_SCRIPTS": "${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/share/openocd/scripts"
}
},
"launch": {
"configurations": [
{
"name": "Debug",
"type": "gdb",
"request": "launch",
"preLaunchTask": "Flash",
"gdbpath": "${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin/xtensa-esp32-elf-gdb",
"autorun": [
"target remote | ${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/bin/openocd -c 'gdb_port pipe' -f ${env:HOME}/esp32/esp-idf_workspace/esp32_jlink.cfg",
"set remote hardware-watchpoint-limit 2",
"mon reset halt",
"flushregs",
"thb app_main",
"c"
],
"cwd": "${workspaceRoot}",
"target": "${command:cmake.launchTargetPath}",
"internalConsoleOptions": "openOnSessionStart",
"valuesFormatting": "parseText"
}
]
},
"tasks": {
"version": "2.0.0",
"tasks": [
{
"type": "shell",
"label": "Flash",
"command": "${env:HOME}/esp32/esp-idf_workspace/flash.sh all jtag '${command:cmake.launchTargetPath}'",
"problemMatcher": [],
"presentation": {
"panel": "shared",
"reveal": "always",
"showReuseMessage": false
}
}
]
},
"folders": [
{
"path": "."
}
]
}
{
"settings": {
"C_Cpp.default.compilerPath": "${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc",
"C_Cpp.default.compileCommands": "${workspaceFolder}/build/compile_commands.json",
"C_Cpp.default.includePath": ["${env:HOME}/esp32/esp-idf/components/xtensa/include","${env:HOME}/esp32/esp-idf/components/xtensa/esp32/include","${env:HOME}/esp32/esp-idf/components/newlib/platform_include","${env:HOME}/esp32/esp-idf/components/freertos/include","${env:HOME}/esp32/esp-idf/components/freertos/xtensa/include","${env:HOME}/esp32/esp-idf/components/heap/include","${env:HOME}/esp32/esp-idf/components/log/include","${env:HOME}/esp32/esp-idf/components/lwip/include/apps","${env:HOME}/esp32/esp-idf/components/lwip/include/apps/sntp","${env:HOME}/esp32/esp-idf/components/lwip/lwip/src/include","${env:HOME}/esp32/esp-idf/components/lwip/port/esp32/include","${env:HOME}/esp32/esp-idf/components/lwip/port/esp32/include/arch","${env:HOME}/esp32/esp-idf/components/soc/src/esp32/.","${env:HOME}/esp32/esp-idf/components/soc/src/esp32/include","${env:HOME}/esp32/esp-idf/components/soc/include","${env:HOME}/esp32/esp-idf/components/esp_rom/include","${env:HOME}/esp32/esp-idf/components/esp_common/include","${env:HOME}/esp32/esp-idf/components/esp32/include","${env:HOME}/esp32/esp-idf/components/driver/include","${env:HOME}/esp32/esp-idf/components/driver/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_ringbuf/include","${env:HOME}/esp32/esp-idf/components/efuse/include","${env:HOME}/esp32/esp-idf/components/efuse/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_timer/include","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32/include","${env:HOME}/esp32/esp-idf/components/soc/soc/esp32/../include","${env:HOME}/esp32/esp-idf/components/vfs/include","${env:HOME}/esp32/esp-idf/components/esp_wifi/include","${env:HOME}/esp32/esp-idf/components/esp_wifi/esp32/include","${env:HOME}/esp32/esp-idf/components/esp_event/include","${env:HOME}/esp32/esp-idf/components/esp_netif/include","${env:HOME}/esp32/esp-idf/components/esp_eth/include","${env:HOME}/esp32/esp-idf/components/tcpip_adapter/include","${env:HOME}/esp32/esp-idf/components/app_trace/include","${env:HOME}/esp32/esp-idf/components/mbedtls/port/include","${env:HOME}/esp32/esp-idf/components/mbedtls/mbedtls/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/port/include","${env:HOME}/esp32/esp-idf/components/wpa_supplicant/include/esp_supplicant","${env:HOME}/esp32/esp-idf/components/bootloader_support/include","${env:HOME}/esp32/esp-idf/components/app_update/include","${env:HOME}/esp32/esp-idf/components/spi_flash/include","${env:HOME}/esp32/esp-idf/components/nvs_flash/include","${env:HOME}/esp32/esp-idf/components/pthread/include","${env:HOME}/esp32/esp-idf/components/espcoredump/include","${env:HOME}/esp32/esp-idf/components/perfmon/include","${env:HOME}/esp32/esp-idf/components/asio/asio/asio/include","${env:HOME}/esp32/esp-idf/components/asio/port/include","${env:HOME}/esp32/esp-idf/components/cbor/port/include","${env:HOME}/esp32/esp-idf/components/coap/port/include","${env:HOME}/esp32/esp-idf/components/coap/port/include/coap","${env:HOME}/esp32/esp-idf/components/coap/libcoap/include","${env:HOME}/esp32/esp-idf/components/coap/libcoap/include/coap2","${env:HOME}/esp32/esp-idf/components/console","${env:HOME}/esp32/esp-idf/components/nghttp/port/include","${env:HOME}/esp32/esp-idf/components/nghttp/nghttp2/lib/includes","${env:HOME}/esp32/esp-idf/components/esp-tls","${env:HOME}/esp32/esp-idf/components/esp_adc_cal/include","${env:HOME}/esp32/esp-idf/components/esp_gdbstub/include","${env:HOME}/esp32/esp-idf/components/tcp_transport/include","${env:HOME}/esp32/esp-idf/components/esp_http_client/include","${env:HOME}/esp32/esp-idf/components/esp_http_server/include","${env:HOME}/esp32/esp-idf/components/esp_https_ota/include","${env:HOME}/esp32/esp-idf/components/protobuf-c/protobuf-c","${env:HOME}/esp32/esp-idf/components/protocomm/include/common","${env:HOME}/esp32/esp-idf/components/protocomm/include/security","${env:HOME}/esp32/esp-idf/components/protocomm/include/transports","${env:HOME}/esp32/esp-idf/components/mdns/include","${env:HOME}/esp32/esp-idf/components/esp_local_ctrl/include","${env:HOME}/esp32/esp-idf/components/sdmmc/include","${env:HOME}/esp32/esp-idf/components/esp_serial_slave_link/include","${env:HOME}/esp32/esp-idf/components/esp_websocket_client/include","${env:HOME}/esp32/esp-idf/components/expat/expat/expat/lib","${env:HOME}/esp32/esp-idf/components/expat/port/include","${env:HOME}/esp32/esp-idf/components/wear_levelling/include","${env:HOME}/esp32/esp-idf/components/fatfs/diskio","${env:HOME}/esp32/esp-idf/components/fatfs/vfs","${env:HOME}/esp32/esp-idf/components/fatfs/src","${env:HOME}/esp32/esp-idf/components/freemodbus/common/include","${env:HOME}/esp32/esp-idf/components/idf_test/include","${env:HOME}/esp32/esp-idf/components/jsmn/include","${env:HOME}/esp32/esp-idf/components/json/cJSON","${env:HOME}/esp32/esp-idf/components/libsodium/libsodium/src/libsodium/include","${env:HOME}/esp32/esp-idf/components/libsodium/port_include","${env:HOME}/esp32/esp-idf/components/mqtt/esp-mqtt/include","${env:HOME}/esp32/esp-idf/components/openssl/include","${env:HOME}/esp32/esp-idf/components/spiffs/include","${env:HOME}/esp32/esp-idf/components/ulp/include","${env:HOME}/esp32/esp-idf/components/unity/include","${env:HOME}/esp32/esp-idf/components/unity/unity/src","${env:HOME}/esp32/esp-idf/components/wifi_provisioning/include"],
"C_Cpp.default.configurationProvider": "vector-of-bool.cmake-tools",
"cmake.generator": "Ninja",
"cmake.environment": {
"IDF_PATH": "${env:HOME}/esp32/esp-idf",
"IDF_TARGET": "esp32",
"PYTHON_DEPS_CHECKED": "1",
"ESP_PLATFORM": "1",
"CCACHE_ENABLE": "0",
"PATH": "${env:HOME}/esp32/esp-idf/components/esptool_py/esptool:${env:HOME}/esp32/esp-idf/components/espcoredump:${env:HOME}/esp32/esp-idf/components/partition_table/:${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin:${env:HOME}/.espressif/tools/xtensa-esp32s2-elf/esp-2019r2-8.2.0/xtensa-esp32s2-elf/bin:${env:HOME}/.espressif/tools/esp32ulp-elf/2.28.51-esp-20191205/esp32ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/esp32s2ulp-elf/2.28.51-esp-20191205/esp32s2ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/bin:${env:HOME}/esp32/esp-idf/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"CXXFLAGS": "-DRMT_DEBUG"},
"task.autoDetect": "off",
"terminal.integrated.env.linux": {
"IDF_PATH": "${env:HOME}/esp32/esp-idf",
"PATH": "${env:HOME}/esp32/esp-idf/components/esptool_py/esptool:${env:HOME}/esp32/esp-idf/components/espcoredump:${env:HOME}/esp32/esp-idf/components/partition_table/:${env:HOME}/.espressif/tools/xtensa-esp32-elf/esp-2019r2-8.2.0/xtensa-esp32-elf/bin:${env:HOME}/.espressif/tools/xtensa-esp32s2-elf/esp-2019r2-8.2.0/xtensa-esp32s2-elf/bin:${env:HOME}/.espressif/tools/esp32ulp-elf/2.28.51-esp-20191205/esp32ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/esp32s2ulp-elf/2.28.51-esp-20191205/esp32s2ulp-elf-binutils/bin:${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/bin:${env:HOME}/esp32/esp-idf/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"IDF_WORKSPACE": "${env:HOME}/esp32/esp-idf_workspace",
"OPENOCD_SCRIPTS": "${env:HOME}/.espressif/tools/openocd-esp32/v0.10.0-esp32-20191114/openocd-esp32/share/openocd/scripts"
}
},
"tasks": {
"version": "2.0.0",
"tasks": [
{
"type": "shell",
"label": "Flash",
"command": "${env:HOME}/esp32/esp-idf_workspace/flash.sh all jtag '${command:cmake.launchTargetPath}'",
"problemMatcher": [],
"presentation": {
"panel": "shared",
"reveal": "always",
"showReuseMessage": false
}
}
]
},
"folders": [
{
"path": "."
}
]
}

@aussiross can you also please read this here: https://github.com/microsoft/vscode/issues/95182 and upvote if you find it useful ?

Since author said:

Since my aim was everything at the workspace level, this is no longer
an issue for me.

I'm closing this issue.


Different test values on julia v1.9.3

Recently, CI fails due to different test values in one elixir with a 1D TreeMesh, see e.g. here. I was able to reproduce the error locally on julia v1.9.3 (and v1.10.0-beta2), but not on julia v1.9.2.

@andrewwinters5000 The failure occurs for one of the wet-dry elixirs. Could you maybe take a look at it and increase the test tolerance if required?

Thanks a lot!

Investigating the results of elixir_shallowwater_beach.jl using julia 1.9.0 versus julia 1.9.3 the error values for all the quantities start changing around the 10 decimal place. Because the error in the bottom topography is always quite small it seems to be more sensitive to whatever changes have happened "under-the-hood" in the new julia release. Running to tspan=(0.0,0.05) as done in the beach test we get:
# For julia 1.9.0
(l2 = [0.17979210479598923, 1.2377495706611434, 6.289818963361573e-8], linf = [0.845938394800688, 3.3740800777086575, 4.4541473087633676e-7])
# For julia 1.9.3
(l2 = [0.17979210239962704, 1.2377495649103047, 6.289758492103817e-8], linf = [0.8459383936345142, 3.374080078500849, 4.451690074347425e-7])

The fluid quantities pass but the bottom topography errors fail as, e.g.,
abs(l2_julia190[3] - l2_julia193[3]) = 6.047125775517298e-13

which is larger than the default atol=1.1102230246251565e-13 used in the testing.
We could adjust the tolerances, but I think a better way is to change this elixir to set adaptive=false in the SSPRK43 time integration scheme and update the reference values accordingly. My reasoning is two-fold. 1) The adaptive time stepping can cause the method to "lose" well-balancedness at least up to the (default) tolerances set in the adaptive integrator. This has not given us any positivity issues yet, but it is something to keep in mind. 2) When I run elixir_shallowwater_beach.jl to the final time I get a different number of accepted and total time steps between the two julia versions but using identical Trixi and OrdinaryDiffEq versions.
# For julia 1.9.0
Final time: 10.0  Time steps: 15078 (accepted), 20324 (total)
# For julia 1.9.3
Final time: 10.0 Time steps: 15073 (accepted), 20387 (total)

In contrast, when I run elixir_shallowwater_parabolic_bowl.jl that currently uses adaptive time stepping, the number of accepted and total time steps for both julia versions are identical. However, the parabolic bowl is a slightly simpler test case  than the beach run-up, which might explain the differences.

This is weird... Is there any discontinuous behavior involved in this setup that could explain these differences?

This is weird... Is there any discontinuous behavior involved in this setup that could explain these differences?

The velocity is discontinuous but the water height and bottom are not.

What I meant was more some discontinuity in the discretization. Since this is a test case with drying, we do use some thresholds etc. that may explain this

I think you could just use a slightly larger absolute tolerance in this case?

I think you could just use a slightly larger absolute tolerance in this case?

That would be okay from my side, although it is interesting that the error based time stepping changes so noticeably.

Yes, definitely...


[backport] Improve contribution docs

Backport of #6492

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 44fc45e5f012a6596a20ca957b15fb8b1533dbfe, target branch v6) succeeded!


add hfnet cpp ros inference module

Hi!
Thank you so much for your contribution. It's great that you managed to integrate HF-Net into an actual pipeline - I am sure that many will find this valuable! For the sake of clarity, and because I don't have time to test this PR, I think that hfnet_ros should remain a separate repo and not be merged here. I do not plan to actively maintain the HF-Net codebase, partly because it is outdated and the hloc toolbox is much easier to work with. Our recent combo hloc+SuperGlue is surely more computationally expensive than HF-Net, but I think that focusing on improving the accuracy over the runtime is the right thing to do.

ok,Thanks any way. I guess just leave the hfnet_ros package along. hloc+SuperGlue is also a great project, I am studying it recently. The localization Accuracy is very important, but I wanna transfer the work to real application, and test it in our own framework, For the real application, the fusion is needed, We can combine the hfnet/hloc results with IMU/Odom/GPS to get a better results.


bug: When piping into jlv, colors are lost

When I run
$ some-command | jlv

I don't have colored log levels - different from when opening a file w/ jlv somelog.json.
Probably the interactive terminal detection goes wrong due to stdin being used?

could it be that some-command also uses colors?
Plain experiment:
echo '{"msg":"test","level":"debug"}' | jlv

The experiment yields jlv with colored debug; however, the original program does in fact only emit json logs, nothing else. It is a nodejs process.
This sample, though, also shows colors:
$ node -e 'console.log(JSON.stringify({msg: "test", level: "debug"})); console.log(JSON.stringify({msg:"error", level: "error"}));' | jlv

I will investigate the original script.

Fixed in #113

Awesome, I can confirm it works as expected now. Thank you!


Item repositioning after a state change seems to wrongly calculate initial coordinates

Related to #669
Changing the position of an item seems to wrongly "remember" (or fail to reset) the previous position of the item. In this sandbox, the "^" button moves the items to position 3. If an item above the position 3 has been moved, future items animation seem to start from way up instead of from their actual position.
Sandbox: https://codesandbox.io/s/dnd-kit-sortable-forked-443to2?file=/src/App.jsx
https://user-images.githubusercontent.com/1038822/159350764-b095a31a-1902-44f8-9557-bf177611ec39.mov

This issue should be resolved by https://github.com/clauderic/dnd-kit/pull/672

Perfect, thank you

hey @clauderic I am trying to use the latest releases and I am getting this again
https://codesandbox.io/s/dnd-kit-sortable-forked-17d4j7?file=/src/App.jsx

@clauderic hi, sorry to bother. Do you happen to have an update on this?


GenericTransfer and Postgres - ERROR - SET AUTOCOMMIT TO OFF is no longer supported

Trying to implement a generic transfer
t1 = GenericTransfer(
  task_id = 'copy_small_table',
  sql = "select * from my_schema.my_table",
  destination_table = "my_schema.my_table",
  source_conn_id = "postgres9.1.13",
  destination_conn_id = "postgres9.4.5",
  dag=dag
)

I get the following error:
--------------------------------------------------------------------------------
New run starting @2015-11-25T11:05:40.673401
--------------------------------------------------------------------------------
[2015-11-25 11:05:40,698] {models.py:951} INFO - Executing <Task(GenericTransfer): copy_my_table_v1> on 2015-11-24 00:00:00
[2015-11-25 11:05:40,711] {base_hook.py:53} INFO - Using connection to: 10.x.x.x
[2015-11-25 11:05:40,711] {generic_transfer.py:53} INFO - Extracting data from my_db
[2015-11-25 11:05:40,711] {generic_transfer.py:54} INFO - Executing:
select * from my_schema.my_table
[2015-11-25 11:05:40,713] {base_hook.py:53} INFO - Using connection to: 10.x.x.x
[2015-11-25 11:05:40,808] {base_hook.py:53} INFO - Using connection to: 10.x.x.x
[2015-11-25 11:05:45,271] {base_hook.py:53} INFO - Using connection to: 10.x.x.x
[2015-11-25 11:05:45,272] {generic_transfer.py:63} INFO - Inserting rows into 10.x.x.x
[2015-11-25 11:05:45,273] {base_hook.py:53} INFO - Using connection to: 10.x.x.x
[2015-11-25 11:05:45,305] {models.py:1017} ERROR - SET AUTOCOMMIT TO OFF is no longer supported
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/airflow/models.py", line 977, in run
    result = task_copy.execute(context=context)
  File "/usr/local/lib/python2.7/dist-packages/airflow/operators/generic_transfer.py", line 64, in execute
    destination_hook.insert_rows(table=self.destination_table, rows=results)
  File "/usr/local/lib/python2.7/dist-packages/airflow/hooks/dbapi_hook.py", line 136, in insert_rows
    cur.execute('SET autocommit = 0')
NotSupportedError: SET AUTOCOMMIT TO OFF is no longer supported

[2015-11-25 11:05:45,330] {models.py:1053} ERROR - SET AUTOCOMMIT TO OFF is no longer supported

Python 2.7
Airflow 1.6.1
psycopg2 2.6 (Also tried 2.6.1)
Postgeres destination 9.4.5
Any idea on what might cause this problem?

We don't run postgres at Airbnb so I can't really test a fix, but the first thing I'd try would be to change that line to False.
https://github.com/airbnb/airflow/blob/master/airflow/hooks/postgres_hook.py#L12
As a side note, autocommit in DbApiHook should probably be set in a different way, perhaps a set_autocommit(cur, conn, autocommit=True) method that receives an active cursor and connection object and does what it needs to do. Class deriving DbApiHook for specific DBs would have to implement it.

The above fix solved our problems.


doc(Chart.yaml): Add license header for trg-5-02

Missing License Header
Hello, I would like to suggest adding the license header for the values.yaml files to avoid license conflicts and following tractus-x release guidelines: https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-02
Kind regards
Maximilian Wesener
Traceability-Foss

@ds-mwesener   These changes are already present in the repo
I think we can close this PR.


MH-13087, Update Runtime UI Libraries

This pull request updates and cleans out the libraries for the runtime
interface used by all non-admin nodes of Opencast. To make future
updates easier, npm is used to manage JavaScript libraries.

@lkiesow How can I actually test this locally?

Start up a non-admin node (e.g. a worker) and head to http://localhost:8080

Yep, but what is the easiest way to start a non-admin node?

% mvn clean install
% cd build
% tar xf *worker*
% cd *worker*
# Make sure activemq is running
./bin/start-opencast


Is modsim/test_modsim.py still a valid unit test

Viewing modsim/test_modsim.py in VSC with PyLance shows a lot of errors.
A lot of functions are missing.
An object can't be an instance of a function.
pint is not used, and also UnitStrippedWarning

Yes, the test code is out of date with the current version of modsim.py


Add option to define ChallengeBehavior in ChallengeResult

Today I was trying to get Azure AD B2C to play nicely with ASP.NET Core. I did however run into a problem with it. When the user tries to edit their profile, they would be given a Forbidden error. And so I found the reason for this in the end was that ChallengeBehavior.Automatic was used by the AuthenticationHandler. Could we get a constructor for defining this behavior since the overload for AuthenticationManager.ChallengeAsync() exists already? Also a controller extension for specifying it would be nice.

/cc @HaoK

Seems like a reasonable ask, that's why its there in HttpAbstractions, in case the developer wants explicit control over the behavior.  Exposing it in the challenge result is reasonable, the larger question is whether we should expose it in some way for Authorize to make it easier to use to change the behavior there (maybe a new global option in Mvc?) (cc @blowdart)

Global seems like a good idea too.

Right, AuthorizeAttribute would need similar customizability. A global default setting would be nice, and also being able to set it per usage.

@HaoK Is this issue going to be handle be the work you are doing on auth in 2.0?

Probably you can assign this to me

@Eilon please assign

Note we want to remove ChallengeBehavior from Authentication in 2.0 and have that decision made more explicitly in Authorization. https://github.com/aspnet/Security/issues/901

@HaoK - has this scenario been improved? Is there any work left to do here in MVC?

Can probably close this, ChallengeBehvaior got nuked, Forbid is first class and MVC already has both Challenge and Forbid results

See 4c2d727e38b593e4c1ebb8cf002618c2552912a2

So if I return a ChallengeResult from an action, it would always run the same behaviour, even if the user is logged in?

Yeah Challenge => 401, Forbid => 403, no more automatic

Awesome, will have to test later.

Perfect, thanks!


AFL Compile Error : error: no matching constructor for initialization of 'llvm::DILocation'

Hi there .
I just got this error while compiling and building savior .
It's not able to build AFL.
error: no matching constructor for initialization of 'llvm::DILocation'
I am looking for a workaround for this, getting it to work .
Thanks!

Hi,
this error is likely due to LLVM version mismatch, based on https://github.com/evanmak/savior-source/issues/4  if you are manually following the installation script you need to ensure that you point to the correct llvm headers. To do that you may use llvm-config.
Another workaround is to comment out the DILocation related code in AFL, they were added to aid debugging.


Leon spanish supported?

Leon spanish supported?

Hello @johnfelipe,
Thanks for asking. No, it is not yet supported as the focus is not set there for the moment. However, I may consider to add it in the future.
In the future, will you be interested to help with the translations?

Count with me
Pls ensure to notify me
El sáb., 4 de ene. de 2020, 2:07 a. m., Louis Grenard <
<EMAIL_ADDRESS>escribió:

Hello @johnfelipe https://github.com/johnfelipe,
Thanks for asking. No, it is not yet supported as the focus is not set
there for the moment. However, I may consider to add it in the future.
In the future, will you be interested to help with the translations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/leon-ai/leon/issues/150?email_source=notifications&email_token=AADIWFDWHGWPKEJYJ5FIFS3Q4AYSLA5CNFSM4KCTXXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICSOCA#issuecomment-570763016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADIWFBAM6J4EMX46RAJE43Q4AYSLANCNFSM4KCTXXXA
.

 ✨ Languages support

Awesome, thanks!


Cannot edit Package information.

I've attempted several times now to edit my Package to add a link back to my "Project Site" aka GitHub...
Every attempt to edit fails, it starts out saying

An edit is pending for this package version. You are seeing the edited package description now.
These changes will be applied to the package file and become visible to everybody soon unless you first.

And ended up displaying the following message.

Your last edit to this package was not successfully applied. You can edit the package and submit the edit again to retry the edit.

I have verified, several times that the link I provided is correct and working.
Why won't my package information update?
Package in question:
https://www.nuget.org/packages/Rogue/1.0.2
Link I am attempting to add under the 'Project Home Page URL'
http://github.com/enkimatt/rogue/

Your package edit should have been applied now. Let us know if you still hit any issues.

I'm having the same issue with the package https://www.nuget.org/packages/ini-parser/
Is there any solution?

Related to #2521


How does Dropout2d help in cloze task?

class ClfHead(nn.Module):
    """ Classifier Head for the transformer """

    def __init__(self, clf_token, cfg):
        super(ClfHead, self).__init__()
        self.n_embd = cfg.n_embd
        self.clf_token = clf_token
        self.dropout = nn.Dropout2d(cfg.clf_pdrop)  # To reproduce the noise_shape parameter of TF implementation
        self.linear = nn.Linear(cfg.n_embd, 1)
        nn.init.normal_(self.linear.weight, std=0.02)
        nn.init.normal_(self.linear.bias, 0)

    def forward(self, h, x):
        # Classification logits
        clf_h = h.view(-1, self.n_embd)
        flat = x[:, :, :, 0].contiguous().view(-1)
        clf_h = clf_h[flat == self.clf_token, :]
        clf_h = clf_h.view(-1, x.size(1), self.n_embd, 1)
        clf_h = self.dropout(clf_h)
        clf_h = clf_h.view(-1, self.n_embd)
        clf_logits = self.linear(clf_h)
        return clf_logits.view(-1, x.size(1))

Here the self.dropout(clf_h) essentially removes the representation of a sentence and its conclusion, there is remote chance (0.2*0.2) that both representations get removed for a given data item. I am confused on how this aids training .

If I'm not mistaken, the input of Dropout2d is (N, C, H, W) where C corresponds to x.size(1), i.e. 2, so it will only force the same dimensions are dropped out for both sentences.

Pytorch docs for nn.Dropout2d

Randomly zeroes whole channels of the input tensor. The channels to zero-out are randomized on every forward call.

I tried Dropout2d , it zeroes out the entire channel, here sentence.

Interesting, thanks @sai-prasanna for investigating that.
I had some interrogation on how to best reproduce the noise_shape parameters of the TF implementation indeed (the original is here: https://github.com/openai/finetune-transformer-lm/blob/master/train.py#L189).
Dropout2d might not be a good option. Do you have any idea on an alternative option?
Otherwise, maybe a simple `Dropout. I will try to benchmark the two options.

Instead of nn.Dropout we can create a mask using torch.bernoulli and apply it to both the sentences with broadcasted multiply? https://discuss.pytorch.org/t/how-to-fix-the-dropout-mask-for-different-batch
We have to make sure that scaling is done, and its not applied in eval mode .

Ok so I ran an experiment on this section of the code. With the current version of the code (using nn.Dropout2d) I get the following output:
device cuda n_gpu 1
Encoding dataset...
Loading weights...
running epoch 0
Logging
1 187 2.277 7.512 94.92 88.50
running epoch 1
Logging
2 374 0.593 11.446 99.47 88.50
running epoch 2
Logging
3 561 0.315 14.687 99.73 87.97

I modified the code to use the classical dropout:
class ClfHead(nn.Module):
    """ Classifier Head for the transformer """

    def __init__(self, clf_token, cfg):
        super(ClfHead, self).__init__()
        self.n_embd = cfg.n_embd
        self.clf_token = clf_token
        self.dropout = nn.Dropout(cfg.clf_pdrop)  # To reproduce the noise_shape parameter of TF implementation
        self.linear = nn.Linear(cfg.n_embd, 1)
        nn.init.normal_(self.linear.weight, std=0.02)
        nn.init.normal_(self.linear.bias, 0)

    def forward(self, h, x):
        clf_h = h.view(-1, self.n_embd)
        flat = x[..., 0].contiguous().view(-1)
        clf_h = clf_h[flat == self.clf_token, :]
        clf_h = self.dropout(clf_h)
        clf_logits = self.linear(clf_h)

        return clf_logits.view(-1, x.size(1))

I am getting the following output which seems significantly better.
device cuda n_gpu 1
Encoding dataset...
Loading weights...
running epoch 0
Logging
1 187 2.840 8.655 94.92 89.84
running epoch 1
Logging
2 374 0.858 15.130 99.20 91.44
running epoch 2
Logging
3 561 0.000 15.668 100.00 90.91

Is what I'm doing correct ? And if so, should I create a pull request ?

@rodgzilla I got different results.
When using nn.Dropout2D, I got
running epoch 0
Logging
1 187 7.826 9.969 78.34 75.94
running epoch 1
Logging
2 374 1.318 6.060 97.59 90.11
running epoch 2
Logging
3 561 0.368 12.730 99.47 90.37
../../../datasets/original/ROCStories/
checkpoints/OpenAITransformer/ROCStories.tsv
checkpoints/OpenAITransformer/rocstories.jsonl
ROCStories Valid Accuracy: 90.37
ROCStories Test Accuracy:  88.13
When using classical dropout, I got:
running epoch 0
Logging
1 187 2.907 10.442 95.99 88.50
running epoch 1
Logging
2 374 0.722 13.166 99.73 89.84
running epoch 2
Logging
3 561 0.002 15.808 100.00 89.84
../../../datasets/original/ROCStories/
checkpoints/OpenAITransformer/ROCStories.tsv
checkpoints/OpenAITransformer/rocstories.jsonl
ROCStories Valid Accuracy: 89.84
ROCStories Test Accuracy:  86.26

Seems the performance is kind of random.
I use CPU.

@BangLiu You're right, I did not run enough experiments.
I launched the code with 5 different seeds (42, 43, 44, 45, 46) with classical dropout and I get the following validation accuracies after the third epoch: 90.01, 89.30, 91.44, 88.5, 90.37.
I then launched the code with the same 5 seeds using the 2D version of dropout and I get the following result: 87.97, 89.84, 92.25, 86.9, 90.11.
The result are marginally better with the classical dropout in 3 of the 5 cases but I don't think the sample size is big enough to draw any kind of conclusion.
If I understand correctly the OpenAI code that @thomwolf linked above, dropout2d should be the correct way to implement their algorithm.
clf_h = tf.reshape(clf_h, [-1, 2, n_embd])
if train and clf_pdrop > 0:
    shape = shape_list(clf_h)
    shape[1] = 1
    clf_h = tf.nn.dropout(clf_h, 1-clf_pdrop, shape)

the shape given to dropout should be (batch_size, 1, n_embd). The TF documentation of tf.nn.dropout is saying this:

By default, each element is kept or dropped independently. If noise_shape is specified, it must be broadcastable to the shape of x, and only dimensions with noise_shape[i] == shape(x)[i] will make independent decisions. For example, if shape(x) = [k, l, m, n] and noise_shape = [k, 1, 1, n], each batch and channel component will be kept independently and each row and column will be kept or not kept together."

As the code have shape[1] = [1] and dimension 1 is corresponding to the sentence selection index, I think dropout 2D corresponds to this behavior. As I'm not too familiar with TensorFlow could someone check what I am saying ?
Is it what they really wanted to do ? The research paper only states the following:

Fine-tuning details Unless specified, we reuse the hyperparameter settings from unsupervised pre-training. We add dropout to the classifier with a rate of 0.1.

They do not precise that they drop all the network outputs corresponding to a specific sentence but at the same time they reshape clf_h specifically for this purpose. Any opinion ?

@rodgzilla  I don't know tensorflow that much. But From the mask's documentation I understood that, the mask will apply the same dropout mask for the sentence pair dimension.
In Open AI code we have shape as (batch_size, 1, n_embd)
Data size is (batch_size, 2, n_embed), so essentially for a given sentence pair , same  dropout is applied.
For given batch item dropout mask will be calculated independently for each dimension on n_embed dimension . Statistically p% of the activations will be zero. But only one such mask is calculated for the (sentece,left) and (sentence,right) pair.
eg,
Lets say batch_size is 2 and n_embed is 3

activation = [
                        [
                           [ 1, 2, 3],
                           [ 3, 4, 5]
                         ],
                        [
                           [6, 7, 8],
                           [9, 10, 11]
                         ],
                       ]

After applying dropout of 0.5 (without scaling by 1/(1-p))
activation = [
                        [
                           [ 1,0, 3],            #Second dimension is dropped out in sentence pairs
                           [ 3, 0, 5]
                         ],
                        [
                           [0,0, 8],              #First and second dimension is dropped out in sentence pairs
                           [0,0, 11]
                         ],
                       ]

But Pytorch Dropout2D just drops out the entire (sentence,right) and (sentence,left) pair , zeroing out all the values. Same example after doing pytorch dropout2d,
activation = [
                        [                          #Channel not dropped out
                           [ 1,2, 3],
                           [ 3, 4, 5]
                         ],
                        [                         # Channel dropped out
                           [0,0, 0],
                           [0,0, 0]
                         ],
                       ]

I think a  prior to do this would be to force the predictor to learn to distinguish which is correct answer from different sets of same dimensions.

@rodgzilla  To accomplish the same thing as tensorflow, we have to create a dropout mask using torch.rand, for each batch of n_embed dimension, Multiply the same mask to both the rows in dimension 1. Then multiply by 1/(1-p), And just do this in training time ( if self.training:) .

@sai-prasanna I was not sure if you were right about the behavior of tf.nn.dropout when using the noise_shape argument so I tried it and it turns out you were right.
I will work on the proper way to implement this behavior in PyTorch and will create a pull request.

Ok, I think I have a very simple fix.
We can indeed use torch.nn.Dropout2d to reproduce this behavior, the only problem is that we do not want to drop a channel (every value corresponding to a sentence) but a "column" (a specific value for each of the sentences forming an input). So we just have to transpose the tensor before applying the dropout and transpose again right after (in a way we conjugate by a transposition).
This following example in a Python interpreter should be clearer.
In [88]: t = torch.randn(3,2,4)

In [89]: t
Out[89]:
tensor([[[ 0.7503,  0.7338, -0.3102,  0.3698],
         [ 0.6638, -0.9277,  0.1738, -0.4256]],

        [[-2.5322,  0.2958,  0.1383, -0.1261],
         [ 2.2745,  0.2616, -0.1744,  0.2710]],

        [[ 0.7897, -1.6991, -0.1027, -0.2370],
         [-0.8105, -0.2241, -0.1237, -1.5941]]])

In [90]: dropout = torch.nn.Dropout2d(0.5)

In [91]: dropout(t.transpose(1,2)).transpose(1,2)
Out[91]:
tensor([[[ 1.5006,  1.4676, -0.0000,  0.0000],
         [ 1.3276, -1.8554,  0.0000, -0.0000]],

        [[-5.0645,  0.5917,  0.2766, -0.0000],
         [ 4.5490,  0.5233, -0.3488,  0.0000]],

        [[ 1.5794, -0.0000, -0.2054, -0.0000],
         [-1.6209, -0.0000, -0.2475, -0.0000]]])

I am on my laptop at the moment so I am not able to test the new version of the code properly (no GPU), I'll test it tomorrow morning and if it is fine I will create a pull request.
I think that PyTorch should natively allow to do this kind of things. I will try to implement it and create a pull request for it.

I created the pull request for this fix.
I ran a few trainings just to be sure that it is working and I get the following results:
Seed 42
device cuda n_gpu 1
Encoding dataset...
Loading weights...
running epoch 0
Logging
1 187 4.358 7.397 91.18 84.49
running epoch 1
Logging
2 374 0.807 8.412 99.20 90.37
running epoch 2
Logging
3 561 0.000 20.528 100.00 90.11
ROCStories Valid Accuracy: 90.37
ROCStories Test Accuracy:  87.17

Seed 43
device cuda n_gpu 1
Encoding dataset...
Loading weights...
running epoch 0
Logging
1 187 1.390 8.253 96.52 89.30
running epoch 1
Logging
2 374 0.098 13.438 99.73 90.91
running epoch 2
Logging
3 561 0.000 16.577 100.00 91.18
ROCStories Valid Accuracy: 91.18
ROCStories Test Accuracy:  87.17

Seed 44
device cuda n_gpu 1
Encoding dataset...
Loading weights...
running epoch 0
Logging
1 187 3.236 7.552 91.18 83.69
running epoch 1
Logging
2 374 1.036 12.025 98.66 86.36
running epoch 2
Logging
3 561 0.055 17.220 99.73 86.90
ROCStories Valid Accuracy: 86.90
ROCStories Test Accuracy:  84.66


1.20.3 / 1.20.4

Done in https://github.com/Minestom/MinestomDataGenerator/commit/17ba1b9f67c26430df5f4c3d961d051976f6dfea


Update web terminal operator

Update web terminal operator to the latest version.
Remove unused instance objects that are now automatically installed by the operator.

LGTM.


Obtain amount of memory currently used by the domain

I would like to obtain the amount of memory currently used by the domain like here
I'll try to implement REMOTE_PROC_DOMAIN_MEMORY_STATS, ok? What do you think? :-)

Fixed by Ben's commit of Amanda's implementation, and also present in the new generated code. Closing.


Distance from Bubble Image to Avatar

Can I change distance from Bubble Image to Avatar image?

yes when u do cachedImageView = yourImageView
advising to put it like this
container with width size bigger by 10
xPos of yourImageView 10 with width smaller by 10
container.addSubview(yourImageView)
cachedImageView = container

Hey @1bannamgiauten :smile:
I'm cleaning up old issues and trying to finish the next release of the library. I'm sorry I don't have time to respond to all questions.
I'm going to close this issue, but the community should feel free to continue the discussion.
Other ways to get help:

Ask on StackOverflow with the jsqmessagesviewcontroller tag
See the FAQ
Search previous questions


broken URL

https://sourceforge.net/p/spinalcordtoolbox/discussion/help/thread/fe890860/?limit=25&page=1
take the opportunity to move items to "media" instead of "_media" on the wiki server, to be able to upload directly from dokuwiki interface

now fixed


Register Oceananigans v0.5.4

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/964
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.4 -m "<description of version>" f262e1879e0b3eca71ed64fdff682dd218ce1674
git push origin v0.5.4

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/964
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.4 -m "<description of version>" 1bd203648dd9070574fa08568d1b68bea4fe0590
git push origin v0.5.4

TODO: Look into switching to https://github.com/apps/julia-tagbot


Thank You

This is to thank for creating an amazing piece of software. I installed micro yesterday and started loving it.
Hope this issue brings smile on your face @zyedidia !
Please feel free to close this issue.

Thanks for the kind words :). I hope it serves you well!

I also thank you @zyedidia. I hope to say goodbye to vi soon.
I'll think of you every time I'll quit so easily from my editor 😍

Thanks for your continuous work on micro, @zyedidia! :heart:


using volley with okhttp

I was using volley with okhttp.
However, I was getting this warning:
W/SingleClientConnManager﹕ Invalid use of SingleClientConnManager: connection still allocated.
Make sure to release the connection before allocating another one
and this error :
NetworkDispatcher.run: Unhandled exception java.lang.IllegalStateException
java.lang.IllegalStateException
at com.squareup.okhttp.internal.http.HttpEngine.getResponse(HttpEngine.java:416)
at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:386)
at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:495)
at com.xxx.http.headresponse.MultiHeaderResponseHurlStack.performRequest(MultiHeaderResponseHurlStack.java:94)
at com.xxx.http.multipart.MultiPartStack.performRequest(MultiPartStack.java:48)
at com.android.volley.toolbox.BasicNetwork.performRequest(BasicNetwork.java:96)
at com.android.volley.NetworkDispatcher.run(NetworkDispatcher.java:112)

Sorry,it's my own fault. I caught the exception in HttpEngine.readResponse() but didn't throw it out, then HttpURLConnectionImpl.execute() returned true which was not correct.


[2018 Nissan Leaf] Occasionally disengages when lead car brakes

Describe the bug
Occasionally, when following a lead car, using the Nissan ProPilot stock cruise control doing logntiunal control and OpenPilot doing steering, when the lead car brakes, OpenPilot/ProPilot completely disengage with the seatbelt unplugged message shown on the HUD.
How to reproduce or log data

Have openpilot activated for steering, with Nissan stock system doing longitudinal control.
Have lead car indicated on HUD with set speed faster than lead car speed.
Lead car brakes.

Expected behavior
Leaf should brake along with lead car and stay engaged, as it does 9/10 times.
Device/Version information (please complete the following information):

Device: comma two
Dongle ID: e4d79cf6b8b19a0d
Route: e4d79cf6b8b19a0d|2021-03-01--18-30-59
Timestamps: 18:35:52, 18:45:45, 18:47:18 (may have happened other times on this drive, but these are the timestamps I am sure that it happened at).
Version: 0.8.2 (also happened with previous versions)
Car make/model: 2018 Nissan Leaf SV w/ tech package (ProPilot)

Additional context
It hasn't been happening recently (it seems like either it happened more during the warmer months OR happened more on pre-0.8 OpenPilot), but it happened at least 3x on this one drive.
I submitted a bug report about this several months ago but never responded with a route, apologies for that. I'll close that and link to this.

It looks like the route that has been provided is no longer on the server. If you can get another route with this occurring please let if fully upload, then through useradmin (my.comma.ai/useradmin), click "preserve" on the route.
Also, does this also occur without openpilot? You can set the toggle in settings for "enable openpilot" to off and record a drive.

It looks like the route that has been provided is no longer on the server. If you can get another route with this occurring please let if fully upload, then through useradmin (my.comma.ai/useradmin), click "preserve" on the route.
Also, does this also occur without openpilot? You can set the toggle in settings for "enable openpilot" to off and record a drive.

Looks like the brake pedal message isn't quite right, and is what is disengaging OpenPilot. I did NOT press the brake pedal here; this is the Nissan ACC engaging the friction brakes.
My guess is that most of the time, friction brakes are not really used much on the Leaf, thus, this issue is sporatic and happens more at high state of charge (when regen can't be used as heavily).

OK, I think I've figured out what's going on with the help of the following route, as the first section is down a big mountain with lots of regen and occasionally friction brakes because it is so steep: e4d79cf6b8b19a0d|2021-02-28--11-40-33
Please note: I have a fork of OpenDBC that has the messages needed to make the graphs below)
Observations:

2b0, 4th byte, 2nd bit looks to be 1 when the brakelight is on and 0 when the brakelight is off. The brakelight on the Leaf engages when the brake pedal is pressed, or, with e-pedal engaged, when the accelerator pedal is fully released. The downhill section of the above route was driven entirely with e-pedal off in B mode, so anytime the brake light is engaged, the driver pressed the brake pedal.

The other relevant braking-related messages look to be 1cb and 1cc.

Approx 440-450 in the above log has very interesting data. It looks to me like the car was going down the mountain, and then hit a small bump which disabled the regen (the car disables regen anytime any grip is lost to avoid braking on 2/4 wheels).

Assuming I have correctly identified the above messages, it looks the brake pedal signal we were using is really the braking system hydraulic pressure, and so when the braking system mixes in friction braking (which happens more at high SOC and when grip is lost momentarily, among other factors), the "brake pedal" signal was tripping of OpenPilot.
I think we should be able to just increase the brake pedal disengage minimum value to above what the brake controller will ever mix in and we should be good. It looks, based on the above, like there's a well defined maximum friction braking force requested by the brake mixing algorithm (see around when the pedal was actually pressed at ~252).

Further update - looks like on the other Nissans there's an explicit USER_BRAKE_PRESSED message.... well I took a look at the Leaf and indeed, we also have this in the CRUISE_THROTTLE message.
Glad I understand how the Leaf braking system works in depth now though :joy:
I'll test OpenPilot looking at this bit instead of directly at the hydraulic pressure tomorrow night and report back.

@willemcvu Any update on this?

@vanillagorillaa nope, my Leaf has been in the shop for the past 3 weeks, I just got it back. I'll be sure to post an update if I make further progress on this issue.

any progress @willemcvu? would be great to get a fix in for 0.8.5

@adeebshihadeh no progress, sorry. If there's someone else here that has a Leaf that can take up this issue (@razem-io ?) that would be super ideal as I've been too busy at work recently to spend time on this. I haven't even had my C2 installed for the past month :/

@willemcvu My time is also very limited at the moment. I plan to get a new fingerprint for my car soon, maybe I find the time to look into this too. As I understand it you already have an updated DBC file? Would you be so kind to provide this file?

Here's my DBC:
https://github.com/willemcvu/opendbc/blob/master/nissan_leaf_2018.dbc
To be honest it isn't in super great shape, it's sort of a first pass at
figuring out a bunch of undocumented messages or messages that are
documented elsewhere.
On Thu, May 20, 2021, 9:06 AM Julian Pieles @.***>
wrote:

@willemcvu https://github.com/willemcvu My time is also very limited at
the moment. I plan to get a new fingerprint for my car soon, maybe I find
the time to look into this too. As I understand it you already have an
updated DBC file? Would you be so kind to provide this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/19631#issuecomment-845102020,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHVARPFQPE2VKURP2LJJLL3TOUCM3ANCNFSM4VQUA3VQ
.

No worries. Thanks! I will try to figure it out.

@razem-io @willemcvu As a fellow 2018 Nissan Leaf owner I was curious if any progress has been made on this bug. Thanks!

@compbiolover not yet. Currently working on fingerprinting v2 as this seems to be the bigger issue for now. When this is resolved I will give this a try. Maybe someone else can step in. I guess I can start working on this at the end of this year.

@razem-io No problem. I don't currently have a comma2 or comma3 and my background is in R, but if there is anything I can do once I have a comma device please let me know.

I am fairly certain @willemcvu had the right idea with the USER_BRAKE_PRESSED message, however i cannot for the life of me get that working in Carstate.py without OP blocking me with an error "waiting for controls to start"
I added one line to my DBC through SSH under BO_ 569 CRUISE_THROTTLE: 8 XXX
SG_ USER_BRAKE_PRESSED : 37|1@0+ (1,0) [0|3] "" XXX
If i use that DBC to test on a cabana log, it works flawlessly
If i however dare to touch line 36 of selfdrive/car/nissan/carstate.py from
ret.brakePressed = bool(cp.vl["BRAKE_PEDAL"]["BRAKE_PEDAL"] > 3)
to
ret.brakePressed = bool(cp.vl["CRUISE_THROTTLE"]["USER_BRAKE_PRESSED"] > 0)
I get the before mentioned error. So it seems the problem lies deeper, or i am missing something.. it LOOKS so straightforward though :(

Fixed thanks to @TheKirkMiller!

This is still happening. 2019 Nissan Leaf SL Plus. Comma Three.

What branch/version are you using? I haven't encountered this issue on a 2022 SL Plus/Comma Three since the fix was implemented in the main branch. It might be a different issue you could try to document.

EDIT: I think I know the issue you're talking about, it's a Nissan Long issue, not related to openpilot. When the lead car completely disappears (like turning off in front of you without merging), with no user input, Nissan Long will automatically disengage, this is stock behavior of the car not controlled by openpilot.

@cellfreak can you confirm it's this issue? if not, I'll reopen this

Knowing the source of this issue and how it was fixed, it is a different issue. And i suspect Adeeb is right.
i have not had this issue in over 50.000km's


Add PubSub subscription dataAsPayload flag

Signed-off-by: Taction<EMAIL_ADDRESS>Description
Add PubSub subscription dataAsPayload flag that sends only the data/data_base64 value of the data attribute to the application.
Issue reference

Please reference the issue this PR will close: #3801
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-run

/ok-to-test

@artursouza please help trigger /ok-to-test

/ok-to-test

@Taction Thanks for creating this PR! Please check the e2e test logs.

@pkedy I have checked the latest e2e error, it seems related to actor and I don't think it is related to this pr.

Please fix CI build.

CI build fixed.

ping @Taction


filter out unmaintained repositories

It's possible to detect which repository is being actively maintained, for example see this study: https://dl.acm.org/doi/abs/10.1145/3239235.3240501 Let's implement such a filtering (or a similar one) inside discover-repositories.rb
See this one too: https://arxiv.org/pdf/2003.04755

@yegor256 I would like to work on this issue if it's possible. thank you!

@dfarkhutdinova sure, go ahead!

@yegor256 hi, i would like to take this issue, already have some groundwork if u are interested

@lueFlake sure, go ahead (but it's rather complex task, keep in mind)

@yegor256 What do you think about using llm models to solve that problem?

@dzhovi this would be an interesting idea. maybe some studies/tools/experiments already exist and we can use them? otherwise, let's try to create our own implementation.

@yegor256 I've implemented separate python module and uploaded it to pypi: https://github.com/dzhovi/repositories-reasoner
https://pypi.org/project/repo-reasoner/0.0.6/
Based on second paper you referenced, I came up with 5 main parameters: Stars, Forks, Last Push, Open Issues and whether a repo is archived.
From my experiments, llm approach shows itself very well on big repositories: 10 out 10 cases with 100+ star repos classified correctly. But it can make mistakes on smaller ones: 4 out 5 cases classified correctly
I want to use implementation i provided to solve the given issue. What do you think?

@dzhovi looks perfect, let's use repositories-reasoner in CaM


[tests] use recommended network forming method in tests

This makes tests use the recommended method to form networks.
Depends-On: openthread/pyspinel#110

Superseded by #9215


Microsoft.Azure.Management.Fluent (Get database not working)

I have a web api that uses Microsoft.Azure.Management.Fluent to copy database from Azure.
When i use console app it works fine, but on my Web api all the async methods works fine bt the Get method in databases doesnt work. The program just keeps loading there. No error is displayed

This might be related:
@hovsepm pushed 2 commits.
343580f Removed Sync method from the AutoRest generated code.
900b0dd Fixed the rest of sync over async calls and ContinueWith pattern

On Jul 23, 2017, at 1:50 PM, HeroSpha<EMAIL_ADDRESS>wrote:
I have a web api that uses Microsoft.Azure.Management.Fluent to copy database from Azure.
When i use console app it works fine, but on my Web api all the async methods works fine bt the Get method in databases doesnt work. The program just keeps loading there. No error is displayed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I don't have AutoRest generated code..
Here is my code
`var catalogServer = await  azure.SqlServers.GetByResourceGroupAsync(catalogConfig.ResourceGroup, "servername");
var tenantdb = await catalogServer.Databases.Get("basetenantdb").RefreshAsync();
var tenantServer = await  azure.SqlServers.GetByResourceGroupAsync(catalogConfig.ResourceGroup, "tenantservername");
            var database = await tenantServer.Databases.Define(tenantName)
                .WithSourceDatabase(tenantdb)
                .WithMode(CreateMode.OnlineSecondary)
                .CreateAsync();
            await  database.Update().WithExistingElasticPool("Elastic-Pool")
                .ApplyAsync();
            return true;`

When i deploy it online i get error Could not load file or assembly 'Microsoft.Rest.ClientRuntime, Version=<IP_ADDRESS>

@HeroSpha we base Fluent SDK on top of AutoRest generated code. We have a known bug https://github.com/Azure/azure-sdk-for-net/issues/3238 for ASP.Net targeting .Net 4.5.2 blocking calls for sync operations. Please use a separate thread for now in fluent calls (check the issue thread above) until we will ship a fix.
Regarding ClientRuntime exceptions - could you share your project nuget package references?

I have fixed issues by wrapping the synchronous method get with async method in Task like
await Task.Run(async() => {    var db = sqlServer.Databases.Get("dbName"); })


Add ImGui.Progressbar

The title is the best summary I have...
Screenshot from the sample: https://i.imgur.com/fUiaZkw.png?1

Hey @ZingBallyhoo , sorry for the delay. The change looks good. The bracing style on this line doesn't match the rest, but I won't bother you to re-submit with that fixed. I can correct it after the merge.
Thanks for the contribution!


Allocator improvements

WIP; DO NOT MERGE; DO NOT CHANGE
This PR will cover the following goals:

Allocator will become abstract. All hardware-dependand logic will be transferred into Mover interface implementations.
Allocator won't rely on DirectBuffers as original storage, thus removing memory overuse
Thread->Device affinity will be reconsidered.
Memory reuse is implemented, to reduce number of global syncs at cuda driver, and time spent for allocation.

Now it also implements reuse of previously allocated pinned memory.
Cache for device allocations probably shoudn't be implemented, but yet to be decided/prooved.

HostAlloc price is somewhere between 50k ns and 500k ns, depending on allocated memory size.
Cache extraction price is somewhere between 130ns and 250ns, depending on moon phase.
However, exact price of HostAlloc/Free can't be statistically determined, due to hidden device syncrhonization there. So, that price only rises. Memory cache is constant time.

Simple preallocation added, looks like it's greatly reducing "warm up" time.

Also, host memory garbage collector is reconsidered to become thread-independent.


docker-compose and docker build timeout fix

fixed:
dockerfile path location,
env file path
networks
also fixed the readme file which becomes more easy for users to understand how to build and run via docker-compose

I found the solution for docker build timeout by setting
ENV GENERATE_SOURCEMAP=false
FYI I have a high end macbook pro and even for me
$react-scripts build # step fails inside docker, if the GENERATE_SOURCEMAP is true,
with this ENV and other docker-compose fix which i committed earlier, docker-compose up -d works!
docker build works, however interestingly docker-compose build fails at step
COPY conf /etc/nginx

Step 13/16 : COPY conf /etc/nginx/conf
ERROR: Service 'viewer' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder418443906/conf: no such file or directory

docker-compose up -d now works,
Creating network "nginx-dcm4che_dcm4che_default" with the default driver
Creating nginx-dcm4che_db_1   ... done
Creating nginx-dcm4che_ldap_1 ... done
Creating nginx-dcm4che_arc_1  ... done
Creating ohif-viewer          ... done
however nginx conf is still an issue, needs debugging why its not serving the website.

@EsrefDurna, I will likely merge your dcm4che changes. Thanks for taking a stab at resolving those issues. I have less expertise there, and I appreciate you tidying things up.
I had on my list to fix up the root dockerfile and publish our docker ohif/viewer image when new release versions are cut. You should see some light info on that in dockerhub, and it should work more smoothly locally now.
That file was renamed from dockerfile-web to dockerfile
I'm not sure why it was timing out on your machine, but it could be because we cap the amount of memory available to prevent OOM exceptions on docker and CI instances with less available. I think our react build process needs some fine tuning as it consumes a lot of memory and takes entirely too long to run.

I will close this PR and will create a new one.


Problems with CSP Subscriptions

When opening the pbit file and logging into a CSP tenancy, I'm running into a load problem, probably because there are no management groups and there isn't a table called tenants in the Resource Groups

If I run the CcoDashboardDConnector without the pbit, then I'm able to pull down the all the tables available.  The get entities Management Group shows this:

Kind Regards,
Rob

Hi Jobbio, If you check the code line 55 from here https://github.com/Azure/ccodashboard/blob/master/src/CustomConnectors/CcoDashboardAzureConnector/CcoDashboardAzureConnector.pq you will realize that you actually don't have enough permissions to retrieve the data from your subscriptions. Please check that the user account you are using actually has read permissions across multiple tenants.

Hi Christian,
I have no issue running the infrastructure pbit, the issue only occurs on the governance pbit with the same credentials, so I don't believe it is a permissions issue.
JR

We are not querying the same APIs. The Management Groups APIs and in particular the Get Entities requires additional permissions at the MGs level and across tenants. Without these permissions you wont be able to read that information. Also, please have in mind that for now, the delegation only works at subscription level but not at MG level….
Cristian Edwards
Solutions Program Manager
Secure Infra Domain – Solutions Strategy Team
<EMAIL_ADDRESS>Mobile: +34 619270386
CCO Power BI Dashboard https://github.com/Azure/ccodashboard
From: jobbio<EMAIL_ADDRESS>Sent: Tuesday, April 14, 2020 11:14 AM
To: Azure/ccodashboard<EMAIL_ADDRESS>Cc: Cristian Edwards Sabathe<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [Azure/ccodashboard] Problems with CSP Subscriptions (#88)
Hi Christian,
I have no issue running the infrastructure pbit, the issue only occurs on the governance pbit with the same credentials, so I don't believe it is a permissions issue.
JR
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fccodashboard%2Fissues%2F88%23issuecomment-613323495&data=02|01|Cristian.Edwards%40microsoft.com|0cfea47cd43e4c337b8608d7e0543920|72f988bf86f141af91ab2d7cd011db47|1|0|637224524652313138&sdata=KzOJGsxYrw0vromcnIDZiYusLSLRpvHauqZJ0sxYt5o%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD7OBX3APNEYS7VEQU3XWNTRMQSO7ANCNFSM4MF6MR3Q&data=02|01|Cristian.Edwards%40microsoft.com|0cfea47cd43e4c337b8608d7e0543920|72f988bf86f141af91ab2d7cd011db47|1|0|637224524652313138&sdata=Qh9HPcta7yzMhzcbTD7KGsQ67Q%2FarrY6jZhWd96K4AY%3D&reserved=0.

Hi Cristian (sorry for adding the h before).
I elevated the account I was using to see all management groups https://docs.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin and there are no management groups in the CSP tenancy.
This is all I see after elevating a Global Administrator account:

I ran the pbit again with the Global Admin elevated and still got the same errors as originally posted.
JR

Hi Jobbio,
This is shedding some light to our troubleshooting effort. As the message states, you havent enabled MGs in your Tenant/s. We havent considered and controlled this potential scenario and error... hence, that's is why is not working for you in your case. Can you please confirm that the Dashboard is working with another tenant with MGs enabled? we just need the root tenant MG. We dont need you to create any child MG.

Hi Cristian,
I was able to utilise a different tenancy and create a root MG.  This tenancy successfully completed the data pull down with an account that only had reader access to the subscription and no other rights within AAD.
The root MG that was created was NOT associated with the subscription, so it appears that the code is just looking for the existence of a root MG, but association isn't necessary.

Hi @jobbio,
Once the use of management groups is enabled, all subscriptions will depend on that since it will act as root.


Rename ReadOnly to Writable on 11.x tag

Hello,
Thank you for your amazing work so far. We have a lot of websites running with this package. Many of them are running PHP 7.4 and need an update tot PHP 8. To make this possible we would need to have a version working on both PHP 7 and PHP 8.
I propose to create a 11.x branch where we can ship a minor version to support these. I have already a working branch, but I can not create a PR because there is no 11.x branch on this repo.
You can check it out here: https://github.com/MaximVanhove/extended-acf/commit/5c1aff4bf49dd3758220666e74d379f5d3a04b5a

I'm glad you like the package. Unfortunately, we cannot release a new minor version on 11 with your suggested changes, as it would be a breaking change. This could potentially break a lot of projects using that version. What is preventing you from upgrading to a later version?

No worries! If you have any other suggestions, don't hesitate to send them my way.