Feature/optimization

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #409 (b678a9a) into index-operation (c21ee9a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           index-operation     #409   +/-   ##
================================================
  Coverage            58.83%   58.84%
================================================
  Files                  230      230
  Lines                 7623     7624    +1
  Branches              1250     1250
================================================
+ Hits                  4485     4486    +1
  Misses                2817     2817
  Partials               321      321

Impacted Files
Coverage Δ

...Aliases/components/IndexControls/IndexControls.tsx
100.00% <0.00%> (ø)

...eateIndex/components/IndexMapping/IndexMapping.tsx
84.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Only first slide works, after that slick stops working

I applied slick on this DOM:

Then, I call this:
$('.hse-carousel.swiper-container .swiper-wrapper').slick({
  infinite: true
});

And the DOM changes to this:

Then, I open the website on Google Chrome (OS X) and drag one of the slides from right to left. That works. But after that I cannot slide anymore. I can't even go back to the first slide. It's completely stuck! It's just as if slick suddenly stops working.
What's wrong?

Can you recreate in a test case?
https://github.com/kenwheeler/slick/blob/master/CONTRIBUTING.markdown
closing pending test cae

Hi, thanks for your reply. It's very hard for me to reduce the page to a fiddle since it's a major enterprise website. So, I tried to strip off as much as I could and uploaded a testpage here where the issue can be reproduced (all js files are not uglified):
http://www.timo-ernst.net/misc/files/tmp/hsetest/pages/home.html
Would this be ok?

Nah, something like a jsfiddle or codepen. There's a fiddle in the contribution guidelines you can fork to recreate the slick option set you're having trouble with.

Actually I didn't set any options at all =/

Ah, well then it's almost certainly something to do with your local environment. Good luck!

For anyone who's interested in the solution or may have the same issue:
After stripping down the code piece by piece to create a fiddle I found that I had overwritten the setInterval and setTimeout functions for debugging purposes:
setInterval = function () {console.log("setInterval called")};
setTimeout = function () {console.log("setTimeout called")};

That's why Slick stopped working. Silly me. Sorry for taking your time.


Pass sorting warnings up through API and output via CLI

Rather than simply printing warnings to stdout/stderr while in the middle of sorting a file, this refactors µsort to use a class-based sorter implementation, which tracks any warnings encountered while sorting, and includes those warnings in the Result object generated in the API. These warnings are then handled by the CLI and output to stdout alongside the appropriate diff/status output.
Notes:

This deprecates the usort_bytes() and usort_string() API's in favor of the new usort() function that returns a Result object directly. The deprecated functions now wrap usort(), include a deprecation warning, raise if errors were encountered, and return the output/encoding to match existing behavior.

Does this need a small docs update too?

Does this need a small docs update too?

I looked at the docs, but we don't yet have any documentation about the API. I'll be sure to include this in the changelog though.


BUG: handle predicted annotations with no segments, fix #393

See rationale for this fix on that issue:
https://github.com/NickleDave/vak/issues/393
and related bug report in
https://github.com/NickleDave/vak/issues/386

change lbl_tb2segments to return all Nones
when lbl_tb passed in is all 'unlabeled' class
also add logic to lbl_tb2segment to handle case
where post-processing removes all labeled segments;
in that case again return all Nones
change vak.core.predict so it just continues
when lbl_tb2segments returns all Nones

i.e. do not create an Annotation instance for the vocalization

@avanikop after making these fixes I was able to run vak predict using your config + checkpoint + data without a crash
I will also add tests for this.
Would you be okay @avanikop with me adding your checkpoint and a couple of the data files (specifically the ones that end up being "not labeled") to this public dataset?
https://osf.io/vz48c/
I will not share all the files, just the one or two I need to replicate the cases where it predicts no segments
It would be great @avanikop @marichard123 if you could check this branch out and test that it works for you, and also behaves as you expect.
To do that, you'd need to

[ ] set up a development install with a local copy of this repo
[ ] check out the branch

For a dev install, you'll want to follow instructions here:
https://vak.readthedocs.io/en/latest/get_started/installation.html#installation-from-source-e-g-for-development
@avanikop I think the steps for setting up an environment should work as-is for you on Mac but I haven't tested.
@marichard123 you might run into issues with torch not playing well with poetry. If so, please let me know and we can figure out a workaround.
Once you get the code copied and cloned into an environment, you'll want to check out the branch.
You can do that with git wherever you clone the code:
(vak-env) ~/code/vak $ git checkout -t origin/add-logic-handle-predicted-no-annotations-#393

Let me know and I can help if you get stuck on any of that.
Any feedback you can give me will be much appreciated!

Unit tests passed for me locally so this doesn't seem to have broken anything else.
Will wait to see what the CI says.

I am going to go ahead and merge this and release a new dev version, so ppl can test by installing that

I am going to go ahead and merge this and release a new dev version, so ppl can test by installing that

@all-contributors please add @Luke-Poeppel for doc
@Luke-Poeppel I'll be sure to credit you for other contributions when I merge them (like a contributing.md!) -- working on it!

whoops @Luke-Poeppel I meant to comment on your PR
🤔 It still seemed to work though, shows your commits when I click on the book emoji in the README


Produce qlpacks as a build artifact

Description
This PR amends our automation and release process to produce qlpacks in addition to the existing bundle:

The existing compilation of queries in .github/workflows/code-scanning-pack-gen.yml is modified to (a) perform all compilations in a single step (instead of separately for c and cpp), and (b) increases the compilation cache size to ensure we retain the cached compilations for all Coding Standards queries.
A new step is added to .github/workflows/code-scanning-pack-gen.yml to generate qlpacks in a .tgz format. This uses the cached compilations, and should be quick to complete.
The new packs are uploaded as an artifact with the name coding-standards-qlpacks. This should be generated for every PR and push to main, as with the existing artifact.
release-layout.yml is updated to include the new artifact. This should ensure that the artifact is copied onto releases in a similar way to the existing code-scanning-cpp-query-pack.ql artifact.

This PR does not attempt to change our release process to publish the generated packs - only add them as an artifact to the release page. For the next release I plan to manually push the packs to the registry, and look to automate for following releases.
Change request type

[x] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[ ] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[x] No rules added
[ ] Queries have been added for the following rules:

rule number here

[ ] Queries have been modified for the following rules:

rule number here

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[ ] Yes
[x] No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

[ ] Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

@knewbury01 I've updated to address your latest comment, and added a release note.


Are compare-asc and compare-desc both neccesary?

If they do the same thing, but in reverse, could we just rely on compare-asc and rename it to something that indicates the ability to check for ascending and descending order checking?

Both functionalities are necessary for use in the context of Array.sort(compare-asc || compare-desc).


Configuration driven from cloud-init style yaml files

/etc should be configured on boot driven by  extensible cloud-init style yaml files.
Similarly, users can drop config files into the /oem ( or /usr/local/oem ) or /usr/local/setup folder to achieve persistent configurations. The cloud-init format should allow extensions too.
A default config should be among the lines of : https://github.com/rancher/k3os/blob/1688b718da51b39d48c17e2a20d453f37f3d58c7/overlay/libexec/k3os/boot
This issue is about finding a tool that accomplishes that, and embed it into the various stages of the OS (at least): initramfs, boot, network. Replacing also the current skel package that does handle /etc setup.
Ideally, the tool that mimic cloud-init shouldn't have dependency, and be portable (possibly written in Go) see for e.g.:

https://github.com/rancher/k3os/tree/master/pkg
https://github.com/coreos/ignition
https://github.com/mudler/yip
.. ?

See also https://github.com/mocaccinoOS/os-commons/tree/master/packages/systemd/yip-systemd for a possible integration with systemd boot

Closing this as we have a cloud-config mechanism, for the /oem setup, we will have a follow-up (in #24) as there is no decision yet if that has to be in the persistent area or not


About positive and negative samples

Thank you for your response. I couldnt get idea on collecting positive samples. Can you provide downloadable link of your positive image dataset?
thank you once again

depends on what you want to have, you could also write on your own scraper


Use dataclass.asdict() for namcouple types

Is there a reason why you implemented as_dict() for each dataclass in types.py, instead of using dataclasses.asdict()?
I checked and at a glance, I do not see any case where the methods you implemented would behave differently from the default implementation. But I might have overlooked something!

If all goes well, you should be able to get rid of all the as_dict() definitions in types.py.
Then, add from dataclasses import as_dict in scriptengine_task.py and change l. 46 to:
f.write(yaml.safe_dump(asdict(namcouple)))

Very good catch! I did not know about dataclasses.asdict() and in particular I did not expect any "built-in" variant to handle things recursively (which is what we need here).
I agree, it looks like we could get rid of *.as_dict. I will try in a branch!

I did an ECE4 test run with #24 and it worked well. So I guess I can merge the change.


Uncaught TypeError: Cannot read property 'top' of undefined

Upvote
TypeError: Cannot read property 'top' of undefined
1 File malihu-custom-scrollbar-plugin/jquery.mCustomScrollbar.concat.min.js line 6 col 6195 in te
2 File malihu-custom-scrollbar-plugin/jquery.mCustomScrollbar.concat.min.js line 4 col 24789 in eval

I need more info in order to help with such error. Can you send me your link?

I got the same issue. Seems like this doesn't work:
focus: function(e,ui){ 				if(!ui.item){ 					var first = $(".ui-autocomplete li:first"); 					first.trigger("mouseenter"); 					$(this).val(first.data("uiAutocompleteItem").label); 				} 				var el = $(".ui-state-focus").parent(); 				if(!el.is(":mcsInView") && !el.is(":hover")){ 					$(".ui-autocomplete").mCustomScrollbar("scrollTo", el, {scrollInertia:0,timeout:0}); 				} 			}

+1

There are issues throughout... if you fix that error you hit another on 2105.  The problem is that the plugin assumes $('.mCSB_container')[0] exists.

I hit this particular issue while using the plugin in Angular 2.
As a hack/fix, I added a property to the directive I've got wrapping the plugin that changes in sync with the control conditions that would invoke the DOM to change.   I'm an advocate of sharing knowledge, so I'm going to attempt to do so quickly below...
@Directive({
  selector: '[custom-scrollbar]'
})
export class CustomScrollbarDirective implements AfterViewInit, OnDestroy, OnChanges {

	@Input('custom-scrollbar') public condition: boolean;
	private uniqueId: string;

	constructor(private el: ElementRef, private renderer: Renderer) {
             this.uniqueId = _.uniqueId();
             renderer.setElementAttribute(el.nativeElement, 'data-unique-id', this.uniqueId);
        }

        private init() {
            const $target = $(`[data-unique-id="${this.uniqueId}"]`);
	    if ($target.length <= 0) return;

	    // already initialized.
	    if ($target.hasClass('mCustomScrollbar')) return;

	    // run on the target element.
	    $target.mCustomScrollbar({ ... });
        }

        private destroy() {
            const $target = $(`[data-unique-id="${this.uniqueId}"]`);
	    if ($target.length <= 0) return;

	    // TODO: CUSTOM-SCROLLBAR - Possible memory leak if $target not found.
	    if ($target.mCustomScrollbar) {
		$target.mCustomScrollbar('destroy');
	    }
        }

	public ngAfterViewInit(): void {
            this.init();
        }

        public ngOnChanges(changes?: SimpleChanges) {
            const condition = changes['condition'];
            if (condition) {
                if (condition.currentValue === true) {
                    this.init();
                } else {
                    this.destroy());
                }
           }
        }

	public ngOnDestroy() {
            this.destroy();
	}
}

I consume the directive like this
<div [custom-scrollbar]="DivHasContent">...</div>
as my content changes, the value of DivHasContent changes true => false => true causing custom scrollbar to re-build itself in the directive's ngOnChanges() event.

+1
Error is on the line 2355
el.offset().top-p.offset() is undefined


Viewer remove external curly brackets when caret is end of text

1.32 version

Select attached file and open in notepad++ with JSON-Viewer plugin.
Press 'End' key or move caret to end of text
Press 'Ctrl+Shift+Alt+M' combination.
External Curve brackets are missed in formatted JSON

JSONViewerIssue.txt

not able to reproduce the issue. For me the formatter works perfectly. But, at one instance i was not able to see the external curve brackets due to the cursor position, i scrolled left and it was there.

I have the same issue. It's a scroll issue. Scroll to right and then to left to show the brackets/braces.


Added singleton class to store and access geometry constants for Hidra

Singleton class with all geometry constants for Hidra Prototype.
This class uses G4SystemOfUnits so all lengths are converted in units of mm.
Geometry constants are stored as static constexpr class members. They are known at compile time and can be used, for instance, to set the size of std::array<T,N> or other static size containers.
Each geometry constant has at least one getter method in the class to access its value. All getters are also constexpr so the values returned can be used to perform some basic calculations on geometry at compile time, since their value is known.
This class is read-only so its instance can be simply declared as const auto.
Array-like values are returned using std::array.
Usage example
This class can be used in any part of Geant4 code by just adding the header.
#include "HidraGeometryConstants.hh"

int main (int argc, char *argv[]) {
  // Get a pointer to geometry class
  const auto geoConstants = HidraGeometryConstants::GetInstance();

  // PRINT SOME CONSTANTS
  // Access all values via getter methods
  std::cout << "Module size on X axis: " << geoConstants->moduleSizeX() << "\n";
  std::cout << "Tube outer radius: " << geoConstants->tubeOuterRadius() << "\n";
  std::cout << "Tube diameter: " << geoConstants->tubeOuterDiameter() << "\n";
  std::cout << "Fiber cladding inner diameter: " << geoConstants->fiberCladdingInnerDiameter() << "\n";

  // PRINT MODULE FLAG
  // moduleFlag is a std::array<int32_t,120>
  const auto moduleFlag = geoConstants->moduleFlag();
  std::cout<<"Modules flag:";
  for (int i = 0; i < geoConstants->nModules(); ++i) {
    if (i % geoConstants->nModulesOnX() == 0){
      std::cout<<"\n";
    }
    std::cout << moduleFlag[i] << "\t";
  }
  std::cout << "\n";
  return 0;
}

This class can (should) also be used to retrieve important geometry information for the analysis.

Accepting for new class with geometry parameters.


[IRGen] Check for nil in final class cast opt.

As an optimization, there is a fast-cast to non-final classes that just compares isa pointers.  If the source of the cast is an Optional<class>, though, it's not allowed to "directly compare the isa-pointer"; because the source might be Optional.none, i.e. null.
Add a check for null when emitting the fast class cast.
rdar://108614878

@swift-ci please test


Fix comments that were modified by a find & replace

The find & replace of ES module import syntax to cjs requires in #3227 modified some comments.

Thanks!


Parallel sync smoke IDE test

Fixes #30091

@bot-gradle test prf

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.


bug: hitting space bar while typing into search bar activates keyboard shortcut to play/pause instead

When typing into the search bar, when a user adds a space for, say, multiple search terms, that activates the keyboard shortcut to pause the sound if it's playing or play the sound if it isn't. In addition, the space will not show up in the search bar.
I think looking at some of the changes in #66 and #85 might be helpful.

I think looking at a relevant issue in the repository we used for this functionality might be helpful.

Good catch. Maybe we can check if the input search is focused. If it isnt focused then we know the user isn't typing into it so we allow the spacebar and all other shortcuts to proceed.

@hamirmahal Interested in taking this on?

@hamirmahal Interested in taking this on?

Sure! But, maybe not immediately. I definitely want to completely finish the pull request I have open, first, before opening new ones.


Adds Pushnami

Powering more than 20,000 global sites, Pushnami is the #1 push platform for marketers. With Pushnami’s browser-based push notifications, you can deliver your message through desktop and mobile browsers with ease.
Used By

https://trends.builtwith.com/widgets/Pushnami/United-States

Thanks!

Thanks for merge. I noticed an issue with the converted SVG not resizing correctly. When I went back to my test machine I noticed I'm not seeing anything in the converted folder after build. This should be populated when running ./run links ?


CC2530(+CC2591) crashes after few hours

I dont know why nobody has the same questions but i go with zigbee2mqtt since months with various hardware and nothing is working longer than 1,5 days.
I firstly go with CC2531 but the range is a big problem. The max device firmware can't work with routers. The default and max stability firmware didn't work here with CC2530(+CC2591) as router very well.
The CC2530(+CC2591) as coordinator, default or max stability is equal,  crashes between 12h to 24h. With luck it's enough to reboot, else you have to reflash the whole CC2530(+CC2591).
I don't know if everything is wrong with my installation but i never get it constantly work more than 2 days in a row.
My actual installation is one CC2530(+CC2591) as coordinator (latest max stability firmware) at an Raspberry Pi 3+ connected over serial on GPIO. One CC2530(+CC2591) as router (latest router firmware). Zigbee2MQTT at latest master firmware. I checked latest dev firmware but it's the same.
4x Xiaomi Mija Temp/Humidity Sensors
1x Xiaomi Door/Windows Sensor
2x Philips Hue Outdoor Sensors
2x Osram Bulbs
7x Ikea Tradfri Bulbs
1x Ikea Tradfri Remote
4x Osram Smart+ Plugs
All works fine for 13 hours this day and then crash. Reboot dosn't work, i had to remove the power. And thats the best working setup i find the last months.
The CC2530(+CC2591) as router (only power connected) works since 7 days without a problem.
So what has to be done to get a stabilized working setup because my family is very sad (to say it friendly)

This probably happens because running out of memory (CC2530 firmware has less memory available than the CC2531).
In order to get things stable, I would recommend using the CC2531 with the max stability firmware as the coordinator and put the CC2530 + CC2591 close to it with a router firmware.

Ok, thanks for your reply and tipps.
I'll test this improvement now.

Let me know your findings.

Oh, one question before i start.
I am right that every Router connects directly to the coordinator? If so i can't test your suggestion because i have a CC2530 + CC2591as Router Outdoor for the Philips Hue Outdoor Motion Sensors and it can't connect stable to the CC2531 thats indoor. Thats why i'll use the CC2530 + CC2591 as coordinator.

Routers can also connect to other routers, they will automatically find the best connection.

Hi, same here with CC2530 + CC2590 (actually the new Ebyte E18). Unfortunately I don’t have any router since I am running a strong coordinator with 100mw. All my 12 Xiaomi devices have more than 70 linkquality but after 2-3days they stop working. I am running the dev coordinator 2019-4-25 from 1.2 Z-Stack.

Hello @all,
after many days of testing my setup is now working without problems for days.
But the solution is not what you expect i think. All testing with several setups and @Koenkk  solution ended in problems. Devices that lost connection for hours or forever. Coordinator crashes and so on. But i found a solution for me.
I bought a new (from private person) Hue Bridge for 20€ and connected all Osram & Ikea Bulbs, the Hue Motion Sensors and the Osram Switches to it. My Osram Gardenpole that stopps working from one day also to another with zigbee2mqtt (only connects but no control) also (and he begins to functioning again).
Then i builded a second zigbee network with zigbee2mqtt (raspberri pi and one CC2530(+CC2591) over uart) and connetced the Xiaomi Sensors only to this network.
In Homeassistant i used the Hue Bridge Plugin additionally to mqtt and voila. All is running!
Since 6 Days without one single Problem. No extra Routers, no Linkqualitys that fluctuating between 0 and 120 and no broken connections.
My conclusion, either the Sticks are to small (Memory etc.) or the Rasoberry Pi is the limiting Factor.
I'm sorry that this is the naked truth but thats my conclusion after 3 Months of pain and an angry wife ;-)
Now all is superb!

@jonnycastaway

Devices that lost connection for hours or forever

Your problem may not be a cc25xx crash but this here: Enddevices unreachable because rejoin=false
After I removed Osram and MüllerLicht, my net is stable too.
Please test without Osram routers, but with other routers. Ikea seems to be ok.

@allofmex

Please test without Osram routers, but with other routers.

Mhm, eleminate the Osram Smart+ Plugs is not a solution for me. They switches my whole Media (TV, AVR, Subwoofer) and other things. And with the Hue Bridge there is no Problem.
The Ikea Router (i have one here) connects with zigbee2mqtt but i have never seen any single device (in the networkmap) that ever used it. The Xiaomi Sensors didn't work better (checked the Linkquality permanently) with this Router. So i removed it.
The biggest Problem i had with my Osram Gardenpole Light that works at the beginning for days (i think 5) and then went not controlable forever. All resets of Gardenpole, Zigbestick, Zigbe2mqtt whatever, nothing worked.
I forgot at the last Post, my Tradfri Remote is also connected to zigbee2mqtt and working perfect (Thanks Homeassistant that i can use all together).

@jonnycastaway

eleminate the Osram Smart+ Plugs is not a solution for me

Sure. We just need some more users to confirm that they cause problems with disconnecting enddevices. Then we can contact manufacturer.

I have 2 Osram Smart+ plugs in my network and every 3-4 weeks one of my IKEA tradfri bulbs gets disconnected. It's not always the same bulb. Didn't know that this might have to do with the Osram plugs. Looking at the logs though they behave different. Everytime I restart zigbee2mqtt those 2 plugs get "successfully configured" messages while none of my other devices shows this behaviour:

5/11/2019,` 4:40:58 PM - info: Successfully configured lr_power_outlet (0x7cb03eaa0*******)
5/11/2019, 4:41:00 PM - info: Successfully configured kt_power_outlet (0x84182600********)

(note: I masked the MAC addresses)
Regards
Andreas


Improve documentation of feature flags

x11rb has some explanation of its feature flags on its main documentation page. This commit improves this to explicitly say which "X11 extensions that are needed internally" are always enabled. Additionally, some unnecessary "crate::" at the beginning of links is removed.
Then, a similar documentation is added to x11rb-protocol and x11rb-async.

Merging based on the textual approve above.


add portal https guide

What's the purpose of this PR
add portal https guide
Which issue(s) this PR fixes:
Fixes #4655
Brief changelog

add faq about how to enable portal access in nginx with https

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

the nginx conf example missing the redirect section
server {
    listen 80 default_server;

    location / {
        return 301 https://$http_host$request_uri;
    }
}


Q4 2024: Requests for updates to Mass Digitisation Guide

Updates needed July - September 2024.

[x] Solutions for author names discrepancies
[x] Improve "Go Back/Forwards" section. Currently very focused on changing MSO status to SSO, needs to be broader so the focus is on correcting any mistakes in the record. Possibly make use of green box graphic elements to set apart from the rest of the text and mention the use of the database to make mass corrections.

Add the solutions for discrepancies between author names in the dropdown vs. on Herbarium folders (https://github.com/orgs/NHMDenmark/projects/29/views/1?pane=issue&itemId=61283542)

Please print up copies and include at all workstations once revisions have been made and accepted.

Document title of the guide has been brought back to follow a "v.1.2.3"-format where 1 signifies major changes, 2 substantial changes and 3 minor changes, starting at v.1.0.0.
Quaterly updates will fall under 2.
Current guide's title changed from "Mass Digitisation Guide v.1.1.18  3rd edit<PHONE_NUMBER>" to "Mass Digitisation Guide v.1.1.19" to signify a title change.
Date of the edit can still be found on the first page of the guide.
The guide being updated has been titled "Mass Digitisation Guide v.1.2.0" and can be found in the "Editing in process" folder.

I think we should improve the section about the "go back" and "go forwards" buttons, there was a lot of confusion about this during training. The main issue was how to overwrite/change wrong information (e.g. when accidentally scanning the same barcode twice). I think it should describe this in easy steps, like go back, overwrite barcode, save, go forwards.

The "How to Navigate the Fields in the App" section has this section, which I've tried to make clearer.

Note that a section on how to open and navigate the SQLite database has been added prior to this section.
Is this clear enough or does it need to be spelled out more?

I think this is clearly explained.

The "How to Navigate the Fields in the App" section has this section, which I've tried to make clearer.

Note that a section on how to open and navigate the SQLite database has been added prior to this section.
Is this clear enough or does it need to be spelled out more?

I think this is clearly explained.

@nms419 Can this ticket be closed or is it still in progress?

The updates requested in this ticket has been implemented, I'll go ahead an close it now :)


Test Issue created at Tue, 18 May 2021 13:50:57 GMT

Test issue body  Tue, 18 May 2021 13:50:57 GMT

Comment on issue at Tue, 18 May 2021 13:51:01 GMT


the power reading on SP2

the power reading on SP2 in "contrib-broadlink-controlne" does not work except sp3s this works. In this "contrib-broadlink" it works SP2 but it doesn't work SP3s. So I would ask you if you can arrange for SP2 to work in "contrib-broadlink-controlne"

I made changes in SP2.js
WAS
case 0x08:
                   if (Number.isInteger(payload[7])) //possible fix for issue #7
                   {
                       this.emit("energy", { energy: (payload[7] * 256 + payload[6]) + payload[5] / 100.0});
                   }
                   else
                   {
                       this.emit("energy", { energy: (payload[7].charCodeAt(0) * 256 + payload[6].charCodeAt(0)) + payload[5].charCodeAt(0) / 100.0});
                   }
                   break;

NOW
case 0x08:
                  this.emit("energy", { energy: (payload[7] * 100 + payload[6]) + (payload[5] / 100.0)});
                  break;

Now the SP3S shows a power similar to the readings from IHS.


Remove gapic_v1.method.wrap_with_paging

Closes #4233

Why did this need to happen?

Turns out we didn't need this functionality in the first place. I originally added it for parity with gax, as when gax wrapped methods it would also handle wrapping the response with a page iterator. While exploring changing the generator to use api_core, @landrito and I noticed that methods that return operations just construct the operation in the generated method body, so we saw no reason why we couldn't do the same with page iterators.


react-native-xaml not compatible with jest

RNX seems to be incompatible with jest unit tests within node_modules\react-native-xaml\lib\Types.js

@jechternach could you please provide some more details on this? it isn't really actionable as it is :)


Added support for multiple line endings in a single file

Hey!
I had a use case where a user would upload a csv file and then I'd parse it converting it to JSON.  Since a user would submit a windows csv ( \r line endings ) or a *nix csv ( \n line endings), it was necessary for me to allow an or case when determining the value of this.endLine.
Therefore I introduced a bit of code to allow this.  endLine can now be an array.  To maintain backward compatibility, I did not mandate an array to be passed.  I found this useful and thought perhaps it should be included.
Cheers

fill myself like necromanct)) but will it be implemented?


add number of the line with syntax error

for example:
(56 - 3 - 15) - (lex - table - error line)

fixed. starting from 1 now


Confirmation Controller responds with JSON

Nice work in testing! Can I ask you why this change? Because it is semantically correct returns 404 if the resource to confirm doesn't exist.
If you want the account_confirmation_success in the response, maybe you can add the status to the response (status: :not_found).
I prefer using the http status than reading the body for failure responses (except the body contains extra information like the reason of the failure)

Hi there @cristhiano    ,
In an effort to cleanup this project and prioritize a bit, we're marking pull requests that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this pull request. Obviously feel free to re-open it at any time if it's the right time or this was done in error! If you do, please rebase it with the latest master and explain why it's still needed.
We really appreciate your contribution, we're just trying to make this project manageable again to move it forward.
Hope all is well.


Switch RDF exports to use Graph Store Protocol

Issue #, if available:
Description of changes:
Switches to GSP for complete RDF graph exports. GSP provides more reliable and stable performance compared to the existing query-based implementation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (1ab85d2) 43.52% compared to head (df1f28c) 43.42%.

Files
Patch %
Lines

...naws/services/neptune/rdf/NeptuneSparqlClient.java
0.00%
21 Missing :warning:

...java/com/amazonaws/services/neptune/io/Target.java
0.00%
1 Missing :warning:

...zonaws/services/neptune/rdf/ExportRdfGraphJob.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    43.52%   43.42%   -0.10%
===========================================
  Files          247      247
  Lines         8497     8518      +21
  Branches       871      871
===========================================
+ Hits          3698     3699       +1
- Misses        4525     4545      +20
  Partials       274      274

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[CAN] Enable FlexCAN for i.MX 93 EVK

requires #69330 to be merged first.

requires #69330 to be merged first.

How come?

This is due to the i.MX 93 EVK board design. The ADP5585 gpio expander controls:

A set of 1:2 digital mux that switch pin signal between 2 functions.
The S (or EN) pin of CAN xcvr.

Please rebase this PR as https://github.com/zephyrproject-rtos/zephyr/pull/69330 has been merged.

Rebased. note that flexan2, lpi2c2, mfd0, can_phy is enabled in board dts. will disable after ci pass.

Rebased. note that flexan2, lpi2c2, mfd0, can_phy is enabled in board dts. will disable after ci pass.

Is there any testing or sample application can be used to verify the driver? we can add overlay in the application and also the driver can be verified.

not sure why ci is not building any mimx93_evk tests...

Is there any testing or sample application can be used to verify the driver? we can add overlay in the application and also the driver can be verified.

I wrote a test application to receive and echo can frames, and it works fine.

Is there any testing or sample application can be used to verify the driver? we can add overlay in the application and also the driver can be verified.

I wrote a test application to receive and echo can frames, and it works fine.

Could we leverage existing application in Zephyr kernel? such as application in tests/drivers/can samples/subsys/canbus/isotp? if not upstream you test code? I mean with an application available in Kernel will make it easy to verify FlexCAN.

Please ensure the following tests all pass with the changes from this PR:
west twister -p imx93_evk/mimx9352/a55 -t can

Please ensure the following tests all pass with the changes from this PR:
west twister -p imx93_evk/mimx9352/a55 -t can

verified pass.
$ west twister -p imx93_evk/mimx9352/a55 -t can
INFO    - Using Ninja..
INFO    - Zephyr version: v3.6.0-3652-g714b403b801b
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/ckovmk/Repository/zephyrproject/twister-out/testplan.json
INFO    - JOBS: 8
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete: 2581/2581  100%  skipped: 2569, failed:    0, error:    0
INFO    - 2785 test scenarios (2581 test instances) selected, 2569 configurations skipped (2568 by static filter, 1 at runtime).
INFO    - 12 of 2581 test configurations passed (100.00%), 0 failed, 0 errored, 2569 skipped with 0 warnings in 107.01 seconds
INFO    - In total 252 test cases were executed, 14114 skipped on 1 out of total 1 platforms (100.00%)
INFO    - 0 test configurations executed on platforms, 12 test configurations were only built.
INFO    - Saving reports...
INFO    - Writing JSON report /home/ckovmk/Repository/zephyrproject/twister-out/twister.json
INFO    - Writing xunit report /home/ckovmk/Repository/zephyrproject/twister-out/twister.xml...
INFO    - Writing xunit report /home/ckovmk/Repository/zephyrproject/twister-out/twister_report.xml...
INFO    - Run completed

verified pass.

Try again with west twister -p imx93_evk/mimx9352/a55 -t can -v and you'll see that no CAN controller tests are run due to the CAN devicetree nodes being disabled.

is it the right way if I add initialize priority to board defconfig?

is it the right way if I add initialize priority to board defconfig?

I'd say so, yes. This is due to the GPIOs controlling the CAN transceiver coming from a GPIO expander.

twister pass with this rev.

By running zephyr/tests/drivers/can/api, following errors occur:
*** Booting Zephyr OS build v3.6.0-3652-g12e5c8a739b2 ***
Running TESTSUITE can_classic
===================================================================
START - test_add_filter
 PASS - test_add_filter in 0.001 seconds
===================================================================
START - test_add_invalid_ext_filter
E: invalid filter with extended (29-bit) CAN ID 0x1fffffff, CAN ID mask 0x20000000
E: invalid filter with extended (29-bit) CAN ID 0x20000000, CAN ID mask 0x1fffffff
 PASS - test_add_invalid_ext_filter in 0.015 seconds
===================================================================
START - test_add_invalid_null_filter
 PASS - test_add_invalid_null_filter in 0.001 seconds
===================================================================
START - test_add_invalid_std_filter
E: invalid filter with standard (11-bit) CAN ID 0x7ff, CAN ID mask 0x800
E: invalid filter with standard (11-bit) CAN ID 0x800, CAN ID mask 0x7ff
 PASS - test_add_invalid_std_filter in 0.013 seconds
===================================================================
START - test_bitrate_limits
 PASS - test_bitrate_limits in 0.001 seconds
===================================================================
START - test_classic_get_capabilities
 PASS - test_classic_get_capabilities in 0.001 seconds
===================================================================
START - test_filters_added_while_stopped
 PASS - test_filters_added_while_stopped in 0.002 seconds
===================================================================
START - test_filters_preserved_through_bitrate_change
 PASS - test_filters_preserved_through_bitrate_change in 0.003 seconds
===================================================================
START - test_filters_preserved_through_mode_change
 PASS - test_filters_preserved_through_mode_change in 0.003 seconds
===================================================================
START - test_get_core_clock
 PASS - test_get_core_clock in 0.001 seconds
===================================================================
START - test_get_state
 PASS - test_get_state in 0.001 seconds
===================================================================
START - test_invalid_sample_point
 PASS - test_invalid_sample_point in 0.001 seconds
===================================================================
START - test_max_ext_filters
 PASS - test_max_ext_filters in 0.001 seconds
===================================================================
START - test_max_std_filters
 PASS - test_max_std_filters in 0.001 seconds
===================================================================
START - test_receive_timeout
 PASS - test_receive_timeout in 0.101 seconds
===================================================================
START - test_recover
 PASS - test_recover in 0.001 seconds
===================================================================
START - test_recover_while_stopped
 PASS - test_recover_while_stopped in 0.001 seconds
===================================================================
START - test_reject_ext_id_rtr
 PASS - test_reject_ext_id_rtr in 0.101 seconds
===================================================================
START - test_reject_std_id_rtr
 PASS - test_reject_std_id_rtr in 0.101 seconds
===================================================================
START - test_send_and_forget
 PASS - test_send_and_forget in 0.001 seconds
===================================================================
START - test_send_callback
 PASS - test_send_callback in 0.001 seconds
===================================================================
START - test_send_ext_id_out_of_range
E: invalid frame with extended (29-bit) CAN ID 0x20000000
 PASS - test_send_ext_id_out_of_range in 0.006 seconds
===================================================================
START - test_send_fd_format
E: unsupported CAN frame flags 0x04
 PASS - test_send_fd_format in 0.004 seconds
===================================================================
START - test_send_invalid_dlc
E: DLC of 9 exceeds maximum (8)
 PASS - test_send_invalid_dlc in 0.003 seconds
===================================================================
START - test_send_null_frame
 PASS - test_send_null_frame in 0.001 seconds
===================================================================
START - test_send_receive_ext_id
 PASS - test_send_receive_ext_id in 0.004 seconds
===================================================================
START - test_send_receive_ext_id_masked
 PASS - test_send_receive_ext_id_masked in 0.004 seconds
===================================================================
START - test_send_receive_ext_id_rtr
 SKIP - test_send_receive_ext_id_rtr in 0.001 seconds
===================================================================
START - test_send_receive_msgq
 PASS - test_send_receive_msgq in 0.010 seconds
===================================================================
START - test_send_receive_std_id
 PASS - test_send_receive_std_id in 0.004 seconds
===================================================================
START - test_send_receive_std_id_masked
 PASS - test_send_receive_std_id_masked in 0.004 seconds
===================================================================
START - test_send_receive_std_id_rtr
 SKIP - test_send_receive_std_id_rtr in 0.001 seconds
===================================================================
START - test_send_receive_wrong_id
 PASS - test_send_receive_wrong_id in 0.102 seconds
===================================================================
START - test_send_std_id_out_of_range
E: invalid frame with standard (11-bit) CAN ID 0x800
 PASS - test_send_std_id_out_of_range in 0.005 seconds
===================================================================
START - test_send_while_stopped
 PASS - test_send_while_stopped in 0.001 seconds
===================================================================
START - test_set_bitrate
 PASS - test_set_bitrate in 0.001 seconds
===================================================================
START - test_set_bitrate_too_high
 PASS - test_set_bitrate_too_high in 0.001 seconds
===================================================================
START - test_set_bitrate_while_started
 PASS - test_set_bitrate_while_started in 0.001 seconds
===================================================================
START - test_set_mode_while_started
 PASS - test_set_mode_while_started in 0.001 seconds
===================================================================
START - test_set_state_change_callback
 PASS - test_set_state_change_callback in 0.001 seconds
===================================================================
START - test_set_timing_max
 PASS - test_set_timing_max in 0.006 seconds
===================================================================
START - test_set_timing_min
 PASS - test_set_timing_min in 0.002 seconds
===================================================================
START - test_set_timing_while_started
 PASS - test_set_timing_while_started in 0.001 seconds
===================================================================
START - test_start_while_started
 PASS - test_start_while_started in 0.001 seconds
===================================================================
START - test_stop_while_stopped
 PASS - test_stop_while_stopped in 0.001 seconds
===================================================================
TESTSUITE can_classic succeeded
Running TESTSUITE can_stats
===================================================================
START - test_can_stats_accessors
 PASS - test_can_stats_accessors in 0.001 seconds
===================================================================
TESTSUITE can_stats succeeded
Running TESTSUITE can_transceiver
===================================================================
START - test_get_transceiver
 PASS - test_get_transceiver in 0.001 seconds
===================================================================
TESTSUITE can_transceiver succeeded
Running TESTSUITE can_utilities
===================================================================
START - test_can_bytes_to_dlc
 PASS - test_can_bytes_to_dlc in 0.001 seconds
===================================================================
START - test_can_dlc_to_bytes
 PASS - test_can_dlc_to_bytes in 0.001 seconds
===================================================================
START - test_can_frame_matches_filter
 PASS - test_can_frame_matches_filter in 0.001 seconds
===================================================================
TESTSUITE can_utilities succeeded
Running TESTSUITE canfd
===================================================================
START - test_canfd_get_capabilities
 PASS - test_canfd_get_capabilities in 0.001 seconds
===================================================================
START - test_filters_preserved_through_classic_to_fd_mode_change

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/can/api/src/canfd.c:101: send_test_frame: (err not equal to 0)
failed to send frame (err -114)
 FAIL - test_filters_preserved_through_classic_to_fd_mode_change in 0.015 seconds
===================================================================
START - test_filters_preserved_through_fd_to_classic_mode_change

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/can/api/src/canfd.c:101: send_test_frame: (err not equal to 0)
failed to send frame (err -114)
 FAIL - test_filters_preserved_through_fd_to_classic_mode_change in 0.015 seconds
===================================================================
START - test_invalid_sample_point
 PASS - test_invalid_sample_point in 0.001 seconds
===================================================================
START - test_send_receive_classic

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/can/api/src/canfd.c:161: add_rx_filter: (filter_id equal to -ENOSPC)
no filters available
 FAIL - test_send_receive_classic in 0.014 seconds
===================================================================
START - test_send_receive_fd

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/can/api/src/canfd.c:137: add_rx_msgq: (filter_id equal to -ENOSPC)
no filters available
 FAIL - test_send_receive_fd in 0.013 seconds
===================================================================
START - test_send_receive_mixed

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/can/api/src/canfd.c:137: add_rx_msgq: (filter_id equal to -ENOSPC)
no filters available
 FAIL - test_send_receive_mixed in 0.013 seconds
===================================================================
START - test_set_bitrate_data_while_started
 PASS - test_set_bitrate_data_while_started in 0.001 seconds
===================================================================
START - test_set_bitrate_too_high
 PASS - test_set_bitrate_too_high in 0.001 seconds
===================================================================
START - test_set_timing_data_max
 PASS - test_set_timing_data_max in 0.001 seconds
===================================================================
START - test_set_timing_data_min
 PASS - test_set_timing_data_min in 0.001 seconds
===================================================================
START - test_set_timing_data_while_started
 PASS - test_set_timing_data_while_started in 0.001 seconds
===================================================================
TESTSUITE canfd failed.

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [can_classic]: pass = 43, fail = 0, skip = 2, total = 45 duration = 0.518 seconds
 - PASS - [can_classic.test_add_filter] duration = 0.001 seconds
 - PASS - [can_classic.test_add_invalid_ext_filter] duration = 0.015 seconds
 - PASS - [can_classic.test_add_invalid_null_filter] duration = 0.001 seconds
 - PASS - [can_classic.test_add_invalid_std_filter] duration = 0.013 seconds
 - PASS - [can_classic.test_bitrate_limits] duration = 0.001 seconds
 - PASS - [can_classic.test_classic_get_capabilities] duration = 0.001 seconds
 - PASS - [can_classic.test_filters_added_while_stopped] duration = 0.002 seconds
 - PASS - [can_classic.test_filters_preserved_through_bitrate_change] duration = 0.003 seconds
 - PASS - [can_classic.test_filters_preserved_through_mode_change] duration = 0.003 seconds
 - PASS - [can_classic.test_get_core_clock] duration = 0.001 seconds
 - PASS - [can_classic.test_get_state] duration = 0.001 seconds
 - PASS - [can_classic.test_invalid_sample_point] duration = 0.001 seconds
 - PASS - [can_classic.test_max_ext_filters] duration = 0.001 seconds
 - PASS - [can_classic.test_max_std_filters] duration = 0.001 seconds
 - PASS - [can_classic.test_receive_timeout] duration = 0.101 seconds
 - PASS - [can_classic.test_recover] duration = 0.001 seconds
 - PASS - [can_classic.test_recover_while_stopped] duration = 0.001 seconds
 - PASS - [can_classic.test_reject_ext_id_rtr] duration = 0.101 seconds
 - PASS - [can_classic.test_reject_std_id_rtr] duration = 0.101 seconds
 - PASS - [can_classic.test_send_and_forget] duration = 0.001 seconds
 - PASS - [can_classic.test_send_callback] duration = 0.001 seconds
 - PASS - [can_classic.test_send_ext_id_out_of_range] duration = 0.006 seconds
 - PASS - [can_classic.test_send_fd_format] duration = 0.004 seconds
 - PASS - [can_classic.test_send_invalid_dlc] duration = 0.003 seconds
 - PASS - [can_classic.test_send_null_frame] duration = 0.001 seconds
 - PASS - [can_classic.test_send_receive_ext_id] duration = 0.004 seconds
 - PASS - [can_classic.test_send_receive_ext_id_masked] duration = 0.004 seconds
 - SKIP - [can_classic.test_send_receive_ext_id_rtr] duration = 0.001 seconds
 - PASS - [can_classic.test_send_receive_msgq] duration = 0.010 seconds
 - PASS - [can_classic.test_send_receive_std_id] duration = 0.004 seconds
 - PASS - [can_classic.test_send_receive_std_id_masked] duration = 0.004 seconds
 - SKIP - [can_classic.test_send_receive_std_id_rtr] duration = 0.001 seconds
 - PASS - [can_classic.test_send_receive_wrong_id] duration = 0.102 seconds
 - PASS - [can_classic.test_send_std_id_out_of_range] duration = 0.005 seconds
 - PASS - [can_classic.test_send_while_stopped] duration = 0.001 seconds
 - PASS - [can_classic.test_set_bitrate] duration = 0.001 seconds
 - PASS - [can_classic.test_set_bitrate_too_high] duration = 0.001 seconds
 - PASS - [can_classic.test_set_bitrate_while_started] duration = 0.001 seconds
 - PASS - [can_classic.test_set_mode_while_started] duration = 0.001 seconds
 - PASS - [can_classic.test_set_state_change_callback] duration = 0.001 seconds
 - PASS - [can_classic.test_set_timing_max] duration = 0.006 seconds
 - PASS - [can_classic.test_set_timing_min] duration = 0.002 seconds
 - PASS - [can_classic.test_set_timing_while_started] duration = 0.001 seconds
 - PASS - [can_classic.test_start_while_started] duration = 0.001 seconds
 - PASS - [can_classic.test_stop_while_stopped] duration = 0.001 seconds

SUITE PASS - 100.00% [can_stats]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.001 seconds
 - PASS - [can_stats.test_can_stats_accessors] duration = 0.001 seconds

SUITE PASS - 100.00% [can_transceiver]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.001 seconds
 - PASS - [can_transceiver.test_get_transceiver] duration = 0.001 seconds

SUITE PASS - 100.00% [can_utilities]: pass = 3, fail = 0, skip = 0, total = 3 duration = 0.003 seconds
 - PASS - [can_utilities.test_can_bytes_to_dlc] duration = 0.001 seconds
 - PASS - [can_utilities.test_can_dlc_to_bytes] duration = 0.001 seconds
 - PASS - [can_utilities.test_can_frame_matches_filter] duration = 0.001 seconds

SUITE FAIL -  58.33% [canfd]: pass = 7, fail = 5, skip = 0, total = 12 duration = 0.077 seconds
 - PASS - [canfd.test_canfd_get_capabilities] duration = 0.001 seconds
 - FAIL - [canfd.test_filters_preserved_through_classic_to_fd_mode_change] duration = 0.015 seconds
 - FAIL - [canfd.test_filters_preserved_through_fd_to_classic_mode_change] duration = 0.015 seconds
 - PASS - [canfd.test_invalid_sample_point] duration = 0.001 seconds
 - FAIL - [canfd.test_send_receive_classic] duration = 0.014 seconds
 - FAIL - [canfd.test_send_receive_fd] duration = 0.013 seconds
 - FAIL - [canfd.test_send_receive_mixed] duration = 0.013 seconds
 - PASS - [canfd.test_set_bitrate_data_while_started] duration = 0.001 seconds
 - PASS - [canfd.test_set_bitrate_too_high] duration = 0.001 seconds
 - PASS - [canfd.test_set_timing_data_max] duration = 0.001 seconds
 - PASS - [canfd.test_set_timing_data_min] duration = 0.001 seconds
 - PASS - [canfd.test_set_timing_data_while_started] duration = 0.001 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION FAILED

It seems to be working fine in classic can, failing can-fd tests. I don't think it is related to soc & board level enablement in this pr.
I'll open an issue for that.
Ping @dleach02  @henrikbrixandersen  @JiafeiPan

issue: #73757

By running zephyr/tests/drivers/can/api, following errors occur:

How does this correlate with your comment https://github.com/zephyrproject-rtos/zephyr/pull/70201#issuecomment-2102171581 here saying all tests pass?

By running zephyr/tests/drivers/can/api, following errors occur:

How does this correlate with your comment #70201 (comment) here saying all tests pass?

Sorry, I was meaning all test build pass. But that's not the case here either. Let me check what goes wrong. It seems what caused the build failure is some nodes are disabled / KConfkg not enabled.

By running zephyr/tests/drivers/can/api, following errors occur:

How does this correlate with your comment #70201 (comment) here saying all tests pass?

Sorry, I was meaning all test build pass. But that's not the case here either. Let me check what goes wrong. It seems what caused the build failure is some nodes are disabled / KConfkg not enabled.

As we discussed, you should disable related CAN nodes in default dts, and enable them in overlay of testcase.

As we discussed, you should disable related CAN nodes in default dts, and enable them in overlay of testcase.

What leads you to believe this is the right solution? This is the opposite of what all other boards do.

As we discussed, you should disable related CAN nodes in default dts, and enable them in overlay of testcase.

What leads you to believe this is the right solution? This is the opposite of what all other boards do.

Would you please give more detailed explanation why enable all the device nodes in board dts is the best choice?  For MPU platform, we need to run multiple OS on the single platform,  so that we can't enable the same peripherals on multiple OS, that is to say, in order to run a hello world zephyr simultaneously with running Linux, we have to disable so much unused dts nodes in Zephyr board dts as all the peripherals have already be enabled in Linux, right?

Would you please give more detailed explanation why enable all the device nodes in board dts is the best choice? For MPU platform, we need to run multiple OS on the single platform, so that we can't enable the same peripherals on multiple OS, that is to say, in order to run a hello world zephyr simultaneously with running Linux, we have to disable so much unused dts nodes in Zephyr board dts as all the peripherals have already be enabled in Linux, right?

Enabling a devicetree node does not enable the peripheral driver unless the corresponding Kconfig is enabled as well. So in your example, the hello world Zephyr application would not enable CONFIG_CAN and therefore enabling the FlexCAN devicetree node has no impact.

Would you please give more detailed explanation why enable all the device nodes in board dts is the best choice? For MPU platform, we need to run multiple OS on the single platform, so that we can't enable the same peripherals on multiple OS, that is to say, in order to run a hello world zephyr simultaneously with running Linux, we have to disable so much unused dts nodes in Zephyr board dts as all the peripherals have already be enabled in Linux, right?

Enabling a devicetree node does not enable the peripheral driver unless the corresponding Kconfig is enabled as well. So in your example, the hello world Zephyr application would not enable CONFIG_CAN and therefore enabling the FlexCAN devicetree node has no impact.

Oh.., my bad, clear now, thanks for your explanation.


Online changing resolved-ts.advance-ts-interval can't take effect immediately

Bug Report

What version of TiKV are you using?

Master
What operating system and CPU are you using?

No Matter
Steps to reproduce

Run following sql
set config tikv `resolved-ts.advance-ts-interval`='1h';
set config tikv `resolved-ts.advance-ts-interval`='1s';

What did you expect?
advance-ts-interval becomes 1s after the second sql run
What did happened?
advance-ts-interval becomes 1s after 1h, namely after the previous config interval timeout.

Does set config tikv resolved-ts.advance-ts-interval='1s'; works?

Does
set config tikv `resolved-ts`.`advance-ts-interval`='1s';

works?

Yes, it works. It just needs to wait for the previously configured interval timeout to take effect.
For example, the interval was set to 10s, and we change it to 1s, the interval will become 1s after 10s

/severity Moderate

I can say RunnableWithTimer have the same problem. It also has to first come timeout then take the new interval effect. Maybe some interrupt mechanisms are needed.


(GH-1591) Expose plugins in config file transport config

This adds support for using plugins under transport config settings in a
config file. Plugins references under transport config are resolved
immediately after plugins are configured and before inventory is loaded.
This also includes a refactoring of the Bolt::Config class and the
introduction of new transport configuration classes (e.g.
Bolt::Config::SSH, Bolt::Config::WinRM). Each transport config
object handles merging and validating transport config options set at
the config, group, and target levels, while the Bolt::Config class
will now only load config files, pass data along to the appropriate
classes, and validate Bolt-specific config.
Previously, transport configuration was validated and handled completely
by the Bolt::Config class. When resolving transport configuration for
specific targets, this required cloning the entire config object,
passing the group- and target-specific data to the config object,
re-validating the config, and pulling the transport-specific config out
of the config object. This approach was expensive and created
unnecessary duplicate objects, which slowed down the loading and
validating of large inventories.
Closes #1591
TODO

[x] Update broken transport integration tests
[x] Pass transport config to inventory instead of config
[x] Type validation from OPTIONS hash on each transport config object
[ ] Look at including defaults and advisory_defaults to OPTIONS hash
[x] Resolve transport config plugin references from inventory
[x] Update Bolt::Config::Transport#merge to accept multiple hashes
[ ] Add changelog entry

CLA signed by all contributors.

It looks like there may be some sort of error happening during the puppet_agent::install task. I'm not sure if it's transient/network-related or what, but the same commit was passing all tests earlier:
https://github.com/puppetlabs/bolt/actions/runs/50312993
And now it's failing:
https://github.com/puppetlabs/bolt/actions/runs/50347208

Failing integration tests will be fixed by https://github.com/puppetlabs/bolt/pull/1655

@puppetlabs/skeletor This PR changes how inventory is initialized, which affects the bolt server client script. Relevant changes are here: https://github.com/puppetlabs/bolt/pull/1644/commits/9a920759d411c16cdd8d810e95c2ba7df7e173eb


Some extensions are not found

Some file extensions like .aab, .keystore or .jks are not found by File Picker on Android.
This problem occurs on Android, I tested several extensions in the same code, I also tested the library sample code, .aab, .jks and .keystore extensions are not found.
Desktop works

The getMimeTypeFromExtension method searches for registered extensions, as there is no such extension in the MimeMap, so it returns empty.
To "solve" the problem, I changed the code to remove the extension filter if none were provided:
https://github.com/Wavesonics/compose-multiplatform-file-picker/pull/143


Create educagri.txt

Pour les professeurs de l'enseignement agricole

@BigDaddyNFT First stage of verification passed, official domain is agriculture.gouv.fr as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://draaf.bretagne.agriculture.gouv.fr/les-coordonnees-et-sites-web-a131.html

@BigDaddyNFT Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Hi Philip!
This is not a school address, this is the official mail address for all teachers of farming ministry in France which gather more than 400 schools (here is the main page https://educagri.fr/)
Address of the ministry is 78 Rue de Varenne, 75007 Paris, France
Here are links refering some of the IT course program for differents levels
https://chlorofil.fr/fileadmin/user_upload/02-diplomes/referentiels/secondaire/bactechno/bac-techno-da-C4.pdf
https://chlorofil.fr/fileadmin/user_upload/02-diplomes/referentiels/secondaire/btsa/info-communes/tronc_commun_m41_m42/btsa-da-iea-m42.pdf
https://chlorofil.fr/fileadmin/user_upload/02-diplomes/referentiels/secondaire/btsa/tc-2022/btsa-tc-da-m5.pdf
And to conclude as a proof i send you this link saying that educagri.fr is the official email domain for teachers (and only teachers) from french farming ministry schools
https://r2math.ensfea.fr/wp-content/uploads/sites/8/2010/07/3-2-messagerie.pdf
don't hesitate to ask if you need more details!
Regards,


CB-17780 Missing check for Acceptable classes with Generics

In CB-17642 the constructor parameters and class private fields
were not appropriately checked if they were a Generic type.
This change inspects the constructors' parameters in a different way
by parsing the type name (unfortunately there is no better way as of now).
The 2 interesting classes in this PR are FlowPayloadSerializabilityChecker and GenericParameterTypeParser.

pls resolve conflicts


Setting --fhirSinkPath to a GCP FHIR Store does not work

How to replicate
Spin up the OpenMRS and MySQL images:
 docker-compose -f docker/openmrs-compose.yaml up

Next, compile the JARs:
mvn clean -DskipTests install
Then run a batch pipeline, setting the --fhirSinkPath to a GCP FHIR store:
java -cp batch/target/fhir-batch-etl-bundled-0.1.0-SNAPSHOT.jar     org.openmrs.analytics.FhirEtl  \
--openmrsServerUrl=http://localhost:8099/openmrs     --openmrsUserName=admin  --openmrsPassword=Admin123 \
--fhirSinkPath=projects/84163485625/locations/us-central1/datasets/testme/fhirStores/openmrsrelay \
--resourceList=Patient,Encounter,Observation --batchSize=20

The program exits, with the stacktrace:
java.lang.NoClassDefFoundError: com/google/api/services/healthcare/v1/CloudHealthcare$Builder
        at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:371)
        at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:339)
        at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:219)
        at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:67)
        at org.apache.beam.sdk.Pipeline.run(Pipeline.java:322)
        at org.apache.beam.sdk.Pipeline.run(Pipeline.java:308)
        at org.openmrs.analytics.FhirEtl.runFhirFetch(FhirEtl.java:138)
        at org.openmrs.analytics.FhirEtl.main(FhirEtl.java:219)
Caused by: java.lang.NoClassDefFoundError: com/google/api/services/healthcare/v1/CloudHealthcare$Builder
        at org.openmrs.analytics.GcpStoreUtil.createClient(GcpStoreUtil.java:124)

Issue
It seems the JAR does not contain the  com.google.api.services.healthcare.v1.CloudHealthcare$Builder class, which is used in GcpStoreUtil.java.
I verified this by listing the contents of the jar using:
jar -tf batch/target/fhir-batch-etl-bundled-0.1.0-SNAPSHOT.jar  | tee content.text
and did not see the com/google/api/services/healthcare/v1/CloudHealthcare$Builder path.
Potential Fix
In the batch pom.xml file, add:
		<dependency>
			<groupId>com.google.apis</groupId>
			<artifactId>google-api-services-healthcare</artifactId>
			<version>v1-rev20200515-1.30.9</version>
		</dependency>

to the dependency tree. However, this would mean this dependency existing in both the batch pom, and the common module pom. Is that OK?

Thanks @omarismail94 for finding this issue and investigating it. I finally had a chance to look into some details here and I think what is happening is that in the batch module we are getting com.google.apis:google-api-services-healthcare from two different dependencies, i.e., from common and org.apache.beam:beam-sdks-java-io-google-cloud-platform (this might have started to be an issue after we upgraded our Beam dep version). So for the common module we have:
$ mvn dependency:tree -pl common | grep healthcare
[INFO] +- com.google.apis:google-api-services-healthcare:jar:v1-rev20200515-1.30.9:compile

but for the batch module we have:
$ mvn dependency:tree -pl batch | grep healthcare
[INFO] |  +- com.google.apis:google-api-services-healthcare:jar:v1beta1-rev20210217-1.31.0:compile

I am guessing because these are different versions of the same artifact, Maven drops the older one. And it causes the problem because package name for CloudHealthcare.java has changed.
As for the solution, your proposed one works but I prefer to upgrade the dep version in common to a newer version (i.e., the other way around). Can you please try that and see if it fixes the problem?
BTW, can you please file a bug to extend our e2e tests to include GCP FHIR store scenario as well? We should have caught this at the time that it was broken.

@bashir2 I updated the dep version in common to v1beta1-rev20210217-1.31.0, and updated two packages that needed a higher version for them to work: google-api-client and google-api-http-client

Thanks @omarismail94 for finding this issue and investigating it. I finally had a chance to look into some details here and I think what is happening is that in the batch module we are getting com.google.apis:google-api-services-healthcare from two different dependencies, i.e., from common and org.apache.beam:beam-sdks-java-io-google-cloud-platform (this might have started to be an issue after we upgraded our Beam dep version). So for the common module we have:
$ mvn dependency:tree -pl common | grep healthcare
[INFO] +- com.google.apis:google-api-services-healthcare:jar:v1-rev20200515-1.30.9:compile

but for the batch module we have:
$ mvn dependency:tree -pl batch | grep healthcare
[INFO] |  +- com.google.apis:google-api-services-healthcare:jar:v1beta1-rev20210217-1.31.0:compile

I am guessing because these are different versions of the same artifact, Maven drops the older one. And it causes the problem because package name for CloudHealthcare.java has changed.
As for the solution, your proposed one works but I prefer to upgrade the dep version in common to a newer version (i.e., the other way around). Can you please try that and see if it fixes the problem?
BTW, can you please file a bug to extend our e2e tests to include GCP FHIR store scenario as well? We should have caught this at the time that it was broken.

Done! Isse #200 created and assigned to me

BTW, can you please file a bug to extend our e2e tests to include GCP FHIR store scenario as well? We should have caught this at the time that it was broken.


tutorials/your-first-mac-aspnet.md "Your First ASP.NET Core Application on a Mac Using Visual Studio Code"

Add content to the Your First App on Mac tutorial to discuss the various artifacts in the generated project
Right now most of the content in the Your First App on Mac tutorial talks about Yeoman, Visual Studio Code and Azure. We should add content that actually goes through what is in the generate project.

[ ] First occurrence of Visual Studio Code in the article append (VSC), then refer to it as VSC. Visual Studio Code gets tedious.

@spboyer  can you take a look at the Live Fyre questions. Folks can't get this to work.

@Rick-Anderson addressed.  The yeoman generator is using a previous version of the sdk.  The fix is
add a file to the root of the project called "global.json" with the following content
{
  "projects": [ "." ],
  "sdk": {
    "version": "1.0.0-preview2-1-003177"
  }
}

if the source of the project is in the root then set the "projects" value to ".", otherwise set it to where ever it is. i.e. "src"
set the version to the value of the dotnet version "1.0.0-preview2-1-003177", this is the version that yo aspnet is currently generating.

Hey,
I would like to help concerning an article which could be called like "Your First ASP.NET Core Application using the dotnet CLI Visual Studio Code"? Would this be helpful in any way? Would do it on a windows system. This issue here seems technically close so I did not create a new one.
Could I help you out with that?

@FabianGosebrink Thanks for offering to help with the ASP.NET Core docs! I think the intent is that the existing Mac+VSCode doc should already cover what you are offering to write. We will be updating this article to use the latest CLI commands including using dotnet net instead of Yeoman shortly.
We will also need to look at adding an article that covers how to get started with ASP.NET Core and Visual Studio for Mac. Filed https://github.com/aspnet/Docs/issues/2767 to track.

Closed via #2831


websockets.serve() doesn't shutdown on future.set_result(0) if no clients are connected

hi,
i noticed there's a problem with closing an empty server on linux. basically, if no client is connected and you hit ctrl+c the program hangs forever and you need to kill it.
import asyncio
import websockets
import signal

GLOBAL_OBJECTS = {}

def signal_handler(signum, frame):
    global GLOBAL_OBJECTS
    print(f"shutting down server")
    GLOBAL_OBJECTS["server_future"].set_result(0)
    return

signal.signal(signal.SIGINT, signal_handler)
signal.signal(signal.SIGTERM, signal_handler)

async def message_sender(websocket_object):
    while True:
        await websocket_object.send("test message")
        await asyncio.sleep(1)
    return

async def main():
    global GLOBAL_OBJECTS

    event_loop = asyncio.get_running_loop()
    server_future = event_loop.create_future()
    GLOBAL_OBJECTS["server_future"] = server_future

    async with websockets.serve(message_sender, host=None, port=8090, ping_timeout=None):
        print("starting server")
        await server_future

    return

if __name__ == "__main__":
    asyncio.run(main())

i capture sigint and sigterm and set the future result to 0 whenever the client hits ctrl+c but nothing happens. i also checked with the debugger and it does indeed set the result to 0. also it does work fine if there is at least 1 client connected and it does work properly on windows but not on linux.
any idea what it might be?
thanks

SIGINT handling in Python conflicts with KeyboardInterrupt. I don't know the details but I know there are traps.
Do you have the same problem with signals other than SIGINT?

SIGINT and SIGTERM don't work but SIGKILL does work but returns a non zero return code.

OK - that's expected - you don't handle SIGKILL so it terminates your program instantly.
I have no idea what's happening.

hi, i found some stack overflow answers that i thought might be related to this.
How can I "wake up" an event loop to notify it that a Future was completed from another thread?
When to use loop.add_signal_handler?
apparently there's the idea that event loops need to be woken up before performing an action, maybe that's why the server doesn't close if no one is connected?

i've done some more research and it turns out that the reason why the loop doesn't respond to the signal handler is because it's being accessed from another thread and also because the loop is asleep at the time.
some people suggested to use this if the event loop is not awake:
import asyncio, signal

def signal_handler(signum, frame):
    print("setting result")
    loop = asyncio.get_running_loop()
    loop.call_soon_threadsafe(some_future.set_result, None)

signal.signal(signal.SIGINT, signal_handler)
signal.signal(signal.SIGTERM, signal_handler)

async def main_function():
    global some_future
    some_future = asyncio.get_running_loop().create_future()
    await some_future
    print("main function returning")

asyncio.run(main_function())

using call_soon_threadsafe() would call instead _write_to_self() which wakes up the loop and reads the future result.
here are the links to the source code:
https://github.com/python/cpython/blob/v3.11.2/Lib/asyncio/base_events.py#L504-L505
https://github.com/python/cpython/blob/v3.11.2/Lib/asyncio/base_events.py#L804-L813
and someone else suggested to use the built in signal handler and i didn't want to at first because i thought it broke my other functions but i tested it and it looks good:
import asyncio
import websockets
import signal

GLOBAL_OBJECTS = {}

async def message_sender(websocket_object):
    while True:
        await websocket_object.send("test message")
        await asyncio.sleep(1)
    return

async def main():
    event_loop = asyncio.get_running_loop()
    server_future = event_loop.create_future()
    GLOBAL_OBJECTS["server_future"] = server_future
    event_loop.add_signal_handler(signal.SIGTERM, GLOBAL_OBJECTS["server_future"].set_result, None)
    event_loop.add_signal_handler(signal.SIGINT, GLOBAL_OBJECTS["server_future"].set_result, None)

    async with websockets.serve(message_sender, host=None, port=8090, ping_timeout=None):
        print("starting server")
        await server_future

    return

if __name__ == "__main__":
    asyncio.run(main())

i tested it with ctrl+c empty and with clients and i also run the module from another module with subprocess.Popen() and it works fine.

one more thing i wanted to point out, the add_signal_handler() method is not available on windows, only on linux.
https://docs.python.org/3/library/asyncio-eventloop.html#unix-signals

it turns out that the reason why the loop doesn't respond to the signal handler is because it's being accessed from another thread and also because the loop is asleep at the time

I don't understand how this could happen with the example you posted at the beginning of this discussion. Indeed, that example doesn't involve any threading.
That being said, it looks like you found a solution to your problem not involving changes in websockets. I'm going to close this issue. Let me know if I missed something!

yeah i think it's all good, we can close the ticket. i think the documentation should be updated to mention that add_signal_handler() isn't supported on windows.
it's true that the op example didn't have any threads explicitly but whenever you assign a signal handler using signal.signal() it automatically calls a new thread when the signal is raised. that's where the multithreading happens.

Oh. I didn't know that. This can fail in a variety of interesting ways. Thank you for the explanation.
Since it's an asyncio x signals x Linux/Windows matter, I don't think it has to be documented specifically for websockets; rather it should be in asyncio's documentation.


CASMINST-5207: Add typescripts to upgrade procedure & back them up

Backport of https://github.com/Cray-HPE/docs-csm/pull/2348

Resolving merge conflicts


Fix styling bug in menu editor.

Purpose or Intent
Redo changes by @epwinchell from
https://github.com/ManageIQ/manageiq/pull/9656
on top of JSONized explorer presenter
https://bugzilla.redhat.com/show_bug.cgi?id=1346765
@epwinchell : please review, I mostly cut-n-pasted you chages except for the presenter ruby and javascript side.
In Darga, we have @epwinchell 's fix.

@dclarizio Tested. Looks good.

@epwinchell : thx
@dclarizio, @h-kataria : please, merge, all tested and green


JPASQLQuery querying SQL and returning Entity with Projections.constructor() fails

The code above works fine:
private QUser user = new QUser("user");
private SUser sUser = new SUser("user");
...
getJPASQLQuery()
                .select(user)
                .from(sUser)
                .fetch();

This one fails with java.lang.IllegalArgumentException: argument type mismatch
private QUser user = new QUser("user");
private SUser sUser = new SUser("user");
...
getJPASQLQuery()
                .select(Projections.constructor(UserDTO.class, user))
                .from(sUser)
                .fetch();

The class UserDTO has a constructor:
public UserDTO (User user) {
...
}

Not sure if its a new Feature request or a Bug.
query-dsl version: 4.1.3

So to be clear, you're mixing two different metamodel types?

Yeah, just like the docs says.
http://www.querydsl.com/static/querydsl/4.1.3/reference/html_single/#d0e431
Em 25 de ago de 2017 18:52, "Ruben Dijkstra"<EMAIL_ADDRESS>escreveu:

So to be clear, you're mixing two different metamodel types?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/querydsl/querydsl/issues/2191#issuecomment-325042425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGz0aQCq__1Z49aEATkM1EUEvpZ6NgDAks5sb0IVgaJpZM4PDHB1
.


export const myname = () => {} functions have no name (according to React Devtools)

TypeScript Version:  2.1.5
This issue was originally reported to React Dev Tools and Dan Abramov referred me to log an issue here.
Code
const ArrowFunction = () => { }; // OK
function NamedFunction() { } // OK

export const ExportedArrowFunction = () => { }; // Problem: shows <Unknown> in react-dev-tools
export function ExportedNamedFunction() { } // OK

const ExportedArrowFunctionOnObject = () => { }; // OK
export { ExportedArrowFunctionOnObject } // OK

Expected behavior:
Using Chrome's React Dev Tools and using each function above as a React functional stateless component, I expected to see each function name in the tools, ex <ArrowFunction> and <ExportedArrowFunction>.
Actual behavior:
As mentioned in code comments in the above example, all function forms show their name in tools as expected except ExportedArrowFunction, which shows as <Unknown>. (And unfortunately, this has become the most common form in my code as of late!) This is apparently because it does not have a function.name. It seems that the export throws off the browser's ability to derive a name from the function. Looking at the emitted ES5 (using AMD modules? I'm actually using CommonJS modules but it looks very similar) I'm guessing that the assignment exports.ExportedArrowFunction = function () { } is what throws browsers off, in that it doesn't pick up ExportedArrowFunction as the name.
Solution?
In the original issue thread it was advised by Dan Abramov that a .name should be emitted by the compiler (if I understood his comment). However it looks like TS does not emit a .name for any function. When I used to write ES5 (many years ago -- thank-you TS! :) ) I would always give my functions names, even when I assigned them to things, like exports.ExportedArrowFunction = function ExportedArrowFunction() {} so that the name would appear in call-stacks. Maybe this could work here? Is there another way we could have exported const functions get a proper name?

This is actually part of the ES spec, but we just haven't implemented it.
We could fix this, but one has to be careful in the following case:
export var foo = 10;

var x = {
  foo: () => foo
}

A naive transformation would result in
export var foo = 10;

var x = {
  foo: function foo() { return foo }
}

which is wrong.
I'll note that as a workaround, you could just use function declarations instead. I've never understood why a person would want to use the
const x = () => {
    // ...
}

pattern given that function declarations often take fewer characters. 😄

Hm, interesting.
That example looks like it would actually work fine in ES5 emit but I see your point.
Looking at how Babel compiles these examples I see they always emit named functions, and they add a _ to avoid name scope clashes.

I've never understood why a person would want to use the const x = () => { } pattern given that function declarations often take fewer characters

Well I used to feel that way, but it also lets you omit the { } brackets and return which makes for clean functional expressions, and then you want consistently so you start using it everywhere. :)

Duplicate of https://github.com/Microsoft/TypeScript/issues/6433

And for whatever reasons this is the form that has become standard convention with React stateless functional components...

I don't think there is any "standard" it's just how some of people are using it.
I for instance prefer function because the power of hoisting. Anyway React Stateless component is just a function not a special REACT pattern.
How we are dealing with this behaviour is explicitly exporting stuff which is also good pattern which makes every js file/module consistent -> imports on the top, exports at the bottom
import * as React from 'react';
import {SFC} from 'react';
import {SomeCmp} from './components';

type HelloProps = {who:string}
const Hello: SFC<HelloProps> = ({who,children}) => (

Who are you? -> {who}

{children}

);

export {
 Hello,
 HelloProps // this is needed to mage `declaration: true` work
}

I don't think there is any "standard" it's just how some of people are using it.

Absolutely, it's not a real "standard" just a (very) common pattern, especially for React SFCs but also JS functions in general. There's various good reasons for it, and some tradeoffs, I personally don't have a strong preference either way; that's all besides the point, thought, the point is that this common pattern and a particular intersection of common patterns (exported function expression) causes unexpected/undesirable behavior only in TS (ie not Babel). Not really TS's fault, either, but it's confusing, and could be fixed by TS (whether its worthwhile is still a legitimate question). Personally it took me (and others) awhile to even figure out what was going on here.

How we are dealing with this behaviour is explicitly exporting stuff which is also good pattern which makes every js file/module consistent -> imports on the top, exports at the bottom

Yeah that's the workaround I posted in the original thread, but again, its not as common a pattern and can cause some confusion (2 github "confused" emojis, the ultimate proof! /joking). It's sort of a hidden dependency for devs.

yup yup fair points, absolutely agree.
cheers man 🍻
there is also solution to use TS just for type checking and Babel for transpilation, but I personally try to avoid "double compilation"

@DanielRosenwasser the const foo = () => {…} pattern is nice because it allows you to specify the type of foo, which isn't possible with function foo() {…}, e.g.
const Foo: React.SFC = props =>
{props.children}

I just got bitten by the export const foo = () => {…} CJS emit being exports.foo = () => {…} which Chrome does not infer the name foo for. It would be very useful if the emit preserved the names at runtime.
I use this for storybooks and tests where I need to name the thing I'm demonstrating:
// test
describe(Foo.name, () => {
  it("does something");
});

// storybook
storiesOf(Foo.name, module).add("default", () => <Foo />);


download websocketd-0.3.0-windows_amd64 zip

when I decompress the zip ,click the websocked.exe program,the client shutdown immediately，then  websocketd --port=8080 ./counter.sh，the shell throw bash: websocketd: command not found
can you give me assistance to reslove the issues.Thank you very mush

what operating system and version of it are you using?
(I don't really understand how Bash is  in play on Windows)

windows-64 bit operating system
git bash

Can you just run ./counter.sh and it works?  that example is really not made for windows so it might fail for many reasons unfortunately :(

in windows you may have to run it like this:
websocketd --port=8080 "c:\path\to\bin.exe" "c:\path\to\whatever.script"
Obviously you would have to replace both with the exact file names, which would be bash command shell executable and the counter.sh file.


Fix insertion of toggle hint into nested spans

Possible fix for #44
This commit makes the query changing the text of the toggle button more specific
to not insert the hint in unrelated spans that are nested in the toggleable region

@choldgraf No there was no particular reason for the selector like that. I switched it now.
I was working with XML XPaths a lot and not so much javascript and that's just the first thing that came to my mind


Row Level Security vs Role Level Security

Both this page and the Power BI security whitepaper¹ reference "RLS". In the whitepaper, it denotes Role level security, while this page denotes Row level security (Row vs Role, but use the same acronym).
Are these the same things?

https://docs.microsoft.com/en-us/power-bi/whitepaper-powerbi-security#user-authentication-to-data-sources

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5505062-94f3-e15d-a52f-ce1ac7f8cb69
Version Independent ID: 34076b73-0ded-2111-ed44-2a31e07deb53
Content: Row-level security (RLS) with Power BI - Power BI
Content Source: powerbi-docs/service-admin-rls.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Hi, @bfrancom -- thanks for your question(s)! I've assigned both to the authors.

Is Row level security and Role level security the same?

@bfrancom, @stoicmz  - yes these are the same thing in Power BI. It's role based but has the effect of controlling access to specific rows.


translate directive not translating after source modification

Current behavior

Changing the source array at runtime, doesn't trigger content update on nodes defined with directive.
Expected behavior

Directive should also update it's content as same as pipe.
Minimal reproduction of the problem with instructions

Open the minimal demo app
https://stackblitz.com/edit/github-ngx-translate-904?file=src/app/app.component.ts
Wait for a few seconds after app loads
Click "Set Sample Items" button

Environment

ngx-translate version: 10.0.2
Angular version: 6.0.9

Browser:
- [x] Chrome (desktop) version 63.0.3239.108 (Official Build) (64-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: v9.8.0
- Platform:  Linux

Others:

- OS: Ubuntu 16.04

Duplicate of https://github.com/ngx-translate/core/issues/887


pinch zoom broken in Safari (7.1.2)?

Has anyone else noticed this, pinch zooming seems broken in Safari?
I also get in this mode now on pinch zoom out:

Suggested implementation in #3817


Is this repo looking for a maintainer?

Hey this project needs some basic maintenance (releasing a tag to allow dependency managers to properly install via a fix that has been merged into the master branch)
I'm happy to do it if you add me as a maintainer to the repo ;)

https://github.com/hpcloud/tail/issues/146

Agreed, last tag April 2016 with many improvements merged since then.

The organization hpcloud has 0 members at the moment. Maybe time to decide an official fork. Or is there a process to add new contributors to abandoned repos?

I like and use this lib. Because the project looks dormant I started merging PRs in my forked repo. I also updated the build up to the latest go release (1.13) and made the repo available for go mod. Work in progress, but I put already a release out with 4 PRs applied.

Great. Will switch over. Really sad that none of the old maintainers is available to make this an orderly process.

I like and use this lib. Because the project looks dormant I started merging PRs in my forked repo. I also updated the build up to the latest go release (1.13) and made the repo available for go mod. Work in progress, but I put already a release out with 4 PRs applied.

Damn, I did the same!

@Pandry I merged a lot of PRs (evaluating them here and started looking at issues. I am certainly open to pooling resources. For this reason, I reserved the org go-tail for in case my repo would get any traction and more people would like to collaborate.

@nxadm Actually, I did the same
I will look to see the differences between out versions, and in case look forward to collaborate, if you want to

@Pandry Looking forward to it. Feel free to ask about the changes we made (or didn't: PR not merged).


Broken image fetch

Hello!
Currently I'm getting the error:
Unable to parse images from json. Google may have changed the way their data is stored

As the message says, the json format probably changed and the package is unable to fetch the urls.

Hello!
Thank you for bringing this to my attention. It does look like Google changed their formatting, and it's in a bigger way than usual (not just different JSON indices). I should have a patch up by the end of the week at the latest. Sorry for the inconvenience!


Update LazyFilterCollection.startIndex for removal of ++ operator

Related to: https://github.com/apple/swift-evolution/blob/master/proposals/0004-remove-pre-post-inc-decrement.md

SIL is identical: https://gist.github.com/nielsandriesse/90761d98194b5f15a536


Add public SSRC methods

Internal client updates.
This is based on PR #2457, which updated the API client.
Discussion
Working with @lahirumaramba and @trekforever.
Testing
Ran npm test and all tests pass.

Thank you for reviewing, @jenh. I've updated this PR with your suggested changes.


BUG: Fixed duplicate "Search" placeholder text in ctkSearchBox

CTK rendered placeholderText even when built with Qt versions >= 4.7, while in these Qt versions Qt rendered placeholder text already.
On hi-DPI screens with Qt5, Qt rendered placeholderText in a slightly shifted position, which made duplicate rendering of the placeholderText by CTK and Qt very visible.
Fixed it by correcting the Qt version check (CTK paints placeholderText only when Qt version < 4.7.
Ghosting of placeholderText before the fix:

LGTM - thanks!

Thank you for fixing this!!!


Updated gradle & android project to use variables from root project

I've used changes made to https://github.com/luggit/react-native-config/compare/master...Aranda-Cyber-Solutions-LLC:master?diff=split&name=master as a reference and updated android project so it builds on the React Native 0.56 without problems and it also uses global project variables if those are present.

can you follow react-native-camera pattern https://github.com/react-native-community/react-native-camera/blob/master/android/build.gradle?

Do you mean safeExtGet?

yep, and maybe the same defaults

Okay, I've updated PR to follow that pattern and confirm everything builds just fine in my React Native 0.56 project that uses react-native-fabric.

tks for the PR


Create attribute class selector

I want to merge this change because...

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1166 Add component to manage attributes types

Task linked: SALEOR-1198 Use updated queries to get product attributes

Task linked: SALEOR-1415 Add metadata editor to page views


SAK-49621 Fix dark mode issues in Gateway iframes, input forms, and improve theme scripts

Thanks, Adrian!


Expected to find namespace named ''@ioc:Adonis/Addons/Auth''

I have installed @adonisjs/auth and @adonisjs/lucid but this thing happen when i do the node ace configure adonis5-jwt and i don't know why
   Error: Expected to find namespace named ''@ioc:Adonis/Addons/Auth''.

   ⁃ Object.throwIfNullOrUndefined
     .../node_modules/.pnpm/@ts-morph+common@0.11.1/node_modules/@ts-morph/common/dist/ts-morph-common.js:469
   ⁃ SourceFile.getModuleOrThrow
     .../node_modules/.pnpm/ts-morph@12.2.0/node_modules/ts-morph/dist/ts-morph.js:11160
   ⁃ getDefinedProviders
     .../node_modules/.pnpm/adonis5-jwt@1.1.7/node_modules/adonis5-jwt/build/instructions.js:127

@BayuDC did you get it solved this issue?

no, i finally implemented my own jwt middleware instead of using this package

Can you please share with me any code?


Debounce block fetch in docstore

Right now when fetching N documents after a search, there are no mechanism to make sure we do not attempt to download the same block over and over.
A possibility could be to debounce read calls at the storage layer.
Another possibility could be to group by blocks, but that will require to expose internals.

Also may make sense to combine adjacent blocks into a single request

That would be even nicer... although are cache won't liek that at all.

@PSeitz, can we close this issue?

Yes that's finished


Do you have an example with javascript?

Is there an example of using Javascript on the client side?

This project is not related to javascript, but there is a similar example shown here which should be more or less compatible with the ChatServer.java program: https://javascript.info/websocket
let socket = new WebSocket("wss://javascript.info/article/websocket/demo/hello");

socket.onopen = function(e) {
  alert("[open] Connection established");
  alert("Sending to server");
  socket.send("My name is John");
};

socket.onmessage = function(event) {
  alert(`[message] Data received from server: ${event.data}`);
};

socket.onclose = function(event) {
  if (event.wasClean) {
    alert(`[close] Connection closed cleanly, code=${event.code} reason=${event.reason}`);
  } else {
    // e.g. server process killed or network down
    // event.code is usually 1006 in this case
    alert('[close] Connection died');
  }
};

socket.onerror = function(error) {
  alert(`[error] ${error.message}`);
};

See ChatServer example: https://github.com/TooTallNate/Java-WebSocket/blob/2c9b09127fbbc6d73438097a961a1337dd0d8a65/src/main/example/ChatServer.java#L72
Whenever a message is received, the onMessage method is called with the message as parameter.

up+