Package request: waveterm

waveterm
Modern open-source terminal emulator supporting inline rendering.

homepage URL: https://www.waveterm.dev/
source URL: https://github.com/wavetermdev/waveterm
license: Apache-2.0
platforms: linux, darwin

I've tried, got stuck at packaging waveterm with scripthaus. However i have packaged scripthaus which is required here.
Maybe someone with better understanding of nodejs will make it.

Here's my attempt at cobbling something together for linux, which seems to be working locally for me (well, it's "working" in the sense that it builds, the GUI shows up and the basic shell features seem to be working): https://github.com/ErnWong/dotfiles/blob/689d0fe8932a188f524c20bd8121fc3bfc8ce6ed/pkgs/waveterm/default.nix
nix shell github:ErnWong/dotfiles#waveterm --command waveterm

I wasn't able to get it building using the provided scripthaus scripts yet, but I'm also quite inexperienced in this area so that could be why.  I haven't carried across all the build flags from waveterm's provided scripthaus scripts though, and you might also see some vestigial code that I copied from other packages that don't apply for waveterm which I haven't cleaned up yet. If I have time I might give the scripthaus scripts another try.
Some other remaining todos that I'm aware of include the desktop icon, getting it working on darwin, checking the AI features, checking that the package includes all the dependencies it needs at runtime, and fixing a failing test regarding command completions.
Please feel free to continue working off from what I have if it helps, especially if I don't get back to this soon.

Waveterm offers a .deb packages. I was installing Vivaldi and noticed that it fetched a .deb package and installed it. Is it not possible to do the same? I also saw in this Reddit post that .deb packages are pulled for Opera and Skype as well. So, is it possible to do the same for Waveterm as well?

Forced M1 user here, tried packaging wave but didn't manage to make the scripthaus scripts run without fails, mainly because both go and scripthaus try to create cache directories and I didn't manage to disable this behaviour.
I also tried to use @ErnWong package but due to it requiring electron and it not being available for the M1 architecture I couldn't compile the application from source, so I think packaging for the M1 will have to be done through the .dmg that they have on the realeases page. I'll try packaging the application when I have time this weekend.

In the end I couldn't resist and worked something out for M1 in my free time, this works and creates a ./result directory with an application I can open, so I think it's pretty much done. The only thing missing is integrating with @ErnWong solution... I'll try doing it this weekend.
# package.nix
{
  lib,
  fetchurl,
  stdenvNoCC,
}: let
  pname = "waveterm";
  info = lib.importJSON ./info.json;
  meta = tag-version: {
    changelog = "https://github.com/wavetermdev/waveterm/releases/tag/v${tag-version}";
    description = "An Open-Source, AI-Native, Terminal Built for Seamless Workflows";
    homepage = "https://github.com/wavetermdev/wavetermn";
    license = lib.licenses.asl20;
    mainProgram = pname;
    platforms = lib.platforms.unix;
  };

  darwin = let
    version = info.darwin.version;
  in
    stdenvNoCC.mkDerivation (
      finalAttrs: {
        inherit pname version;
        meta = meta version;

        src = fetchurl {
          inherit (info.darwin) hash;
          url = "https://dl.waveterm.dev/releases/Wave-darwin-universal-${version}.dmg";
        };

        sourceRoot = ".";

        unpackPhase = ''
          runHook preUnpack

          # Since the .dmg is using APFS we can't use undmg.
          # I also tried to use _7zz but it corrupts the .app.
          /usr/bin/hdiutil attach $src
          cp -r "/Volumes/Wave ${version}-universal/Wave.app" .
          /usr/bin/hdiutil detach "/Volumes/Wave ${version}-universal"

          runHook postUnpack
        '';

        installPhase = ''
          runHook preInstall

          mkdir -p $out/Applications
          cp -r *.app $out/Applications
          chmod +x $out/Applications/*.app

          runHook postInstall
        '';
      }
    );
in
  darwin

info.json
{
  "linux": {
    "hash": "",
    "version": "0.7.6"
  },
  "darwin": {
    "hash": "sha256-b75eQnUteQ767+crVe+gWfBf7PrrEjoNFVTx8s/jTXM=",
    "version": "0.7.6"
  }
}

due to it requiring electron and it not being available for the M1 architecture I couldn't compile the application from source

where did you get that info from?

When I searched for electron on Nix packages it never appeared a platform for darwin... I know it should be possible to have electron in M1 but at least on Nix it isn't packaged for it already.

https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=electron-bin

Oh, nice! I thought the panel with platforms displayed all of them, clearly it doesn't. I'll first merge the linux build mentioned previously and then I'll try using that electron to build the app from scratch. Thank you!


Rename minetest to luanti

Renamed the manifest minetest to luanti. Also updated its metadata (version, description, homepage, download links, hashes) to reflect the new version.

Closes #1293

[x] I have read the Contributing Guide.

@Calinou I would like you to review this. Thank you.
p/s. Is it normal that users who installed it before will now have to manually reinstall?

p/s. Is it normal that users who installed it before will now have to manually reinstall?

Yes, I don't think Scoop has explicit package renaming handling in place.


Link from apps to related issues

User story
As the user of an app, I want to find out about known issues and plans for improvements and further development
Details
We can make it easier for the users of an app to find out about issues related to the app by providing links to issues in giantswarm/roadmap from several contexts:

An app repository's README.md
The web UI's app details page

As a prerequisite, we should make sure that there is a label in the roadmap repository for each app. Currently we don't have a consistent label group for this. I suggest app/<app-name>.
In day-to-day processes we should also remind ourselves to use the appropriate labels for issues.

@giantswarm/cnp-product can we get a quick ack or nack on the suggestion of adding app/<appname> label?

I am having difficulties finding out what the difference between an app and a component is, because we already have the component labels. In my understanding an app is for example nginx-ingress- so then we would have app/nginx-ingress and component/nginx-ingress as labels?

We introduced the component labels before we even had the app concept.
If we introduce app/*, many component/ labels should be migrated to app/.

Then. It looks good to me.


Wording inconsistencies within the Help Text

Describe the bug
Within the Help text for the Status, Files and Peers pages, the first page advises to continue to learn more yet the button is titled next.
As a sucker for consistency, I would advise changing the statement to say "Click next to learn more"
To Reproduce
Steps to reproduce the behavior:

Go to either the Status, Files, or Peers page.
Click on the Question Mark Icon.
View the Statement that says "Continue to learn more"
View the Next Button

Expected behavior
The statement would say "Click Next to learn more"
Screenshots

Desktop (please complete the following information):

OS: Windows 10 (Laptop)

Additional context
Add any other context about the problem here.

@davenes8148 -- thanks for pointing this out. Would you be interested in making a PR to fix?


[Event Request] codeunit 418 "User Management" - OnValidateUserNameTestingUserName

Hello, would it be possible to add OnValidateUserNameTestingUserName event to codeunit 418 "User Management", like this:
procedure ValidateUserName(NewUser: Record User; OldUser: Record User; WindowsUserName: Text)
...
              if User.FindFirst() then
                 Error(Text002Err, NewUser."User Name");

             IsHandled := false;
>             OnValidateUserNameTestingUserName(IsHandled, WindowsUserName, NewUser); //New Event
             if not IsHandled then begin
                 if NewUser."Windows Security ID" <> '' then
                     NewUser.TestField("User Name", WindowsUserName);

local procedure OnValidateUserNameTestingUserName(var IsHandled: Boolean; WindowsUserName: Text; NewUser: Record User)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[FEATURE] Add classification algorithms

Classification is a common ML requirement. We don't support classification algorithms now. Tribuo supports classification, we can  add classification support by integrating with Tribuo. Or other options like a better library supporting classification?

Apache OpenNLP is now integrated with HuggingFace Transformers. Could also be an option. In the below example uses a pretrained modelin HuggingFace for text classification.
https://blogs.apache.org/opennlp/entry/accelerate-hugging-face-transformer-models


Refacored logging

Reduced verbosity of logging by reducing the severity of state transition failures (which are expected) to WARN.
Also removed redundant date parse/format classes (these have been moved to rm-common-service).

And, yes, yes, I know the SNAPSHOT version will need to be changed once rm-common-config is checked in and before this is merged ... ;-)

Codecov Report

Merging #45 into master will decrease coverage by 0.87%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   55.06%   54.19%   -0.88%
==========================================
  Files          36       34       -2
  Lines        1224     1216       -8
  Branches      129      129
==========================================
- Hits          674      659      -15
- Misses        516      523       +7
  Partials       34       34

Impacted Files
Coverage Δ

...e/impl/change/ScheduledStateTransitionHandler.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c2c23...79c5816. Read the comment docs.


Remove unused prod canary

Ops todo before this gets merged:

delete deployment
delete service
delete ingress
@zwolf I know we talked about ^ those three operations yesterday. I can't remember if you were going to add this onto your plate or you were fine with me going ahead and just doing it. Either is fine with me. Lmk.

Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

I deleted those resources (deployment, service, ingress). This should be merged and included with the next production deploy. :shipit:

I deleted those resources (deployment, service, ingress). This should be merged and included with the next production deploy. :shipit:

Awesome! Thanks!


Test regex names capitalization

Prerequisites

[x] Have you read the documentation on contributing? https://github.com/bee-san/pyWhat/wiki/Adding-your-own-Regex

Why do we need this pull request?
Regex names capitalization are now tested.
Some words are ignored:

If they contain already one upper case char (e.g: SSH, URL, TOTP) or I also think about brand names like iPhone.
If they contain one numeric char like ed25519 or say, i18n.
If they are specified in the test (for now "a", "of", "etc).

What GitHub issues does this fix?

#205

Tell me what you think about the test and if you might have any false positive in my mind

Please move test_if_all_tests_exist()and test_sorted_by_rarity()to test_regex_formating.py

I just moved test_sorted_by_rarity(), I'm not sure if test_if_all_tests_exist() has to do with regex file formatting though ?

Make a new test file for testing the tests file? 👀

Please move test_if_all_tests_exist()and test_sorted_by_rarity()to test_regex_formating.py

I just moved test_sorted_by_rarity(), I'm not sure if test_if_all_tests_exist() has to do with regex file formatting though ?

Make a new test file for testing the tests file? 👀

That would be too much files, maybe rename test_regex_formatting.py?

Please move test_if_all_tests_exist()and test_sorted_by_rarity()to test_regex_formating.py

I just moved test_sorted_by_rarity(), I'm not sure if test_if_all_tests_exist() has to do with regex file formatting though ?

Make a new test file for testing the tests file? 👀

That would be too much files, maybe rename test_regex_formatting.py?

That's only 5 test files? If we want, we could put them into folders, no?

Please move test_if_all_tests_exist()and test_sorted_by_rarity()to test_regex_formating.py

I just moved test_sorted_by_rarity(), I'm not sure if test_if_all_tests_exist() has to do with regex file formatting though ?

Make a new test file for testing the tests file? eyes

That would be too much files, maybe rename test_regex_formatting.py?

That's only 5 test files? If we want, we could put them into folders, no?

I think test_if_all_tests_exist() could stay in test_regex_identifier.py.

And while we are discussing tests files, I'm not sure about the usefulness of some tests in test_click.py. We do test that all regex work in test_regex_identifier.py and #202 plans to make it easier which is great. But there is a lot of repetition in test_click.py, every regex is also tested there. Either as an arg or from the fixture file.
I added some tests myself, as I seemed to be the way it was done but I'm not sure it is useful and pretty sure it could at least be simplified.
Any thoughts ? Maybe I'm just missing something.

Let's discuss this on #199


Java sample implementation

Is there a sample implementation of this in Java as well?

Thanks for asking, @essieM. Welcome to Wendy!
At this time, no, there is not a sample in Java. Wendy is written in Kotlin and is focused on Kotlin.
Because Kotlin and Java work really nicely together, I don't see a reason that Wendy would not work with Java.
Have you tried to use Wendy with Java before? If so, feel free to make a sample app and we can put a link in the README to your sample project.

Thanks for your response @levibostian.
I'll give this a try in Java.


feat(no-overfetching): add getYearnInvestor singleton

Description
Paranoia PR against overfetching, makes sure we instantiate new YearnInvestor() only once, reducing the number of Infura calls.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk

Ensure Yearn is still working as expected and no console errors are displayed.
Testing

There is only a single call to Infura initiating from YearnProvider
Yearn feature is showing no regressions

Engineering

See top-level testing notes

Operations

See top-level testing notes
Initiator can be seen by clicking a specific request, then clicking "Initiator"

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2780

PR #2782   👈

This comment was auto-generated by Graphite.

Have you see react-singleton-hook?

Have you see react-singleton-hook?

Very interesting one! If it does what it says on the docs, I can definitely see some areas we'd want to use it, but it's probably overkill to write a hook for the sole purpose of instantiating YearnInvestor in that case, however.


[FEATURE] Add functionality to change hamburger menu icon status

Description
For mobile view (Next.js), click on hamburger item should transform from hamburger menu icon to close icon
Screenshots
Before Clicking Hamburger Menu Icon

After Clicking Hamburger Menu Icon

Additional information
On clicking the menu hamburger icon

Overlay component should display (not seen in the above images)
Within that overlay component the menu  (not seen in the above images)

Please Sir, assign me this issue i can do it as early as possible.

I already have worked on it, but am ok if @Dhruv1969Karnwal wants to give it a try. Happy to help if you run into issues. :)

I think there is a PR for this https://github.com/EddieHubCommunity/LinkFree/pull/3202

There are issues for this already, so I will close this


Dungeon Game.java

Aim
Solving a dp  hard level problem on leetcode
programming language
-->

[ ] C
[ ] C++
[ ] Java
[ ] Python

I would like to work on this issue. Please assign me the same

/assign it would be helpfull


vmxnet3 reads too small packet size in VMWare Fusion

Running a IncludeOS network service in VMWare Fusion (Mac OS) the maximum size that can be received seems to be 1510 when MTU is set to 1500  (which means with Ethernet it should be 1514).
This only happens to me when using the vmxnet3 driver with VMWare, with qemu everything works fine.
How to replicate:

Add print to vmxnet3::recv_packet: printf("<vmxnet3> RX Packet %d\n", size);
Run a network service with etc/wmware script.
Ping the service with payload:
$ ping -s 1468 <IP_ADDRESS>
$ ping -s 1470 <IP_ADDRESS>

Some output with different ping sizes (with IP debug) on WMVare:
<vmxnet3> RX Packet 1508
<IP4::receive> IP: tot_len=1494 cap=1480 dat=1474 PKT: sz=1494 cap=1500
<vmxnet3> RX Packet 1510
<IP4::receive> IP: tot_len=1496 cap=1480 dat=1476 PKT: sz=1496 cap=1500
<vmxnet3> RX Packet 1510
<IP4::receive> IP: tot_len=1498 cap=1480 dat=1476 PKT: sz=1496 cap=1500
<vmxnet3> RX Packet 1510

Qemu:
<vmxnet3> RX Packet 1510
<IP4::receive> IP: tot_len=1496 cap=1480 dat=1476 PKT: sz=1496 cap=1500
<vmxnet3> RX Packet 1512
<IP4::receive> IP: tot_len=1498 cap=1480 dat=1478 PKT: sz=1498 cap=1500
<vmxnet3> RX Packet 1514
<IP4::receive> IP: tot_len=1500 cap=1480 dat=1480 PKT: sz=1500 cap=1500

The only difference I've seen is qemu and vmware using different versions of the driver.
Qemu: [ vmxnet3 ] Version 1.1 VMWare: [ vmxnet3 ] Version 3.1.

This problem happens on Workstation for Linux too and can be worked around by setting MTU to 1496

Most probably the problem is here: https://github.com/hioa-cs/IncludeOS/blob/master/src/drivers/vmxnet3.cpp#L215
should be:
shared.misc.mtu = MTU();

VMWare fusion on Mac shows the same issue again, now with TCP traffic. This time changing the MTU in the vmxnet3 constructor do not help either.
If the packet is a full segment (i.e MTU + 14 bytes (ethernet)), 4 bytes is missing of the reported length passed to the recv_packet function.

Same as https://github.com/hioa-cs/IncludeOS/issues/1519 (who would have thought!)
Solved by adding 4 bytes (size of VLAN tag) to buffer without changing MTU!

Solved with https://github.com/alfred-bratterud/IncludeOS/commit/c15756eb02143934b423019d08ca5d2b93a96cc8


SEVE Internal server error - Authentication 401

Currently testing orientdb, most of it works fine but I got into some trouble. I work on a graph database. Most of the things are extended from V and E and also from ORestricted. Working on testing multi tenancy and record based access / rights.
Last action I did was remove an edge from the web interface. I got a confirm like: "Sure you want to delete document...."
I clicked ok.
Now I cannot access the database anymore with a normal user. I get no useful error:
SEVE Internal server error: java.lang.NullPointerException

For me as a user it is not possible to fix this, since I have no information on what happened and where I could fix it. It seems the database went corrupt.
Expectation: As a user I do not expect a nullPointer error.
The errors happen every time I get a 401 error.
2014-09-03 22:37:58:039 INFO Loading configuration from: /XXXXXX/orientdb/config/orientdb-server-config.xml... [OServerConfigurationLoaderXml]
2014-09-03 22:37:58:408 INFO OrientDB Server v1.7.8 (build UNKNOWN@r; 2014-08-13 15:56:07+0200) is starting up... [OServer]
2014-09-03 22:37:58:416 INFO Databases directory: /XXXXXXX/orientdb/databases [OServer]
2014-09-03 22:37:58:470 INFO Listening binary connections on <IP_ADDRESS>:2424 (protocol v.21, socket=default) [OServerNetworkListener]
2014-09-03 22:37:58:471 INFO Listening http connections on <IP_ADDRESS>:2480 (protocol v.10, socket=default) [OServerNetworkListener]
2014-09-03 22:37:58:490 INFO Installing dynamic plugin 'studio-1.7.8.zip'... [OServerPluginManager]
2014-09-03 22:37:58:595 INFO Installing GREMLIN language v.2.5.0 - graph.pool.max=50 [OGraphServerHandler]
2014-09-03 22:37:58:605 INFO Installing Script interpreter. WARN: authenticated clients can execute any kind of code into the server by using the following allowed languages: [sql] [OServerSideScriptInterpreter]
2014-09-03 22:37:58:605 INFO OrientDB Server v1.7.8 is active. [OServer]
2014-09-03 22:39:59:618 SEVE Internal server error:
java.lang.NullPointerException [ONetworkProtocolHttpDb]
2014-09-03 22:44:09:443 SEVE Internal server error:
java.lang.NullPointerException [ONetworkProtocolHttpDb]
2014-09-03 22:44:15:752 SEVE Internal server error:
java.lang.NullPointerException [ONetworkProtocolHttpDb]

Check database
Check database succeeded. Nothing found.
Console as admin
Based on these findings I checked the console:
orientdb> connect remote:localhost admin xxxxxxxxxx

Connecting to remote Server instance [remote:localhost] with user 'admin'...Cannot connect to the remote server/database 'remote:localhost/'
Wrong user/password to [connect] to the remote OrientDB Server instance. Get the user/password from the config/orientdb-server-config.xml file
-> com.orientechnologies.orient.server.OServer.serverLogin(OServer.java:400)
-> com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.connect(ONetworkProtocolBinary.java:665)
-> com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.executeRequest(ONetworkProtocolBinary.java:221)
-> com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:169)
-> com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:45)
Error: com.orientechnologies.orient.core.exception.OStorageException: Cannot connect to the remote server/database 'remote:localhost/'

Error: com.orientechnologies.orient.core.exception.OSecurityAccessException: Wrong user/password to [connect] to the remote OrientDB Server instance. Get the user/password from the config/orientdb-server-config.xml file

Console as root
This works
orientdb> connect remote:localhost root xxxxxxxxxx

Connecting to remote Server instance [remote:localhost] with user 'root'...OK
orientdb {remote:localhost/}>

Console as root with connection to database and list classes
I can understand this works because root seems to bypass all authentication and it's credentials are not stored in the database.
orientdb> connect remote:localhost/advisors root xxxxxxxxxxxxx

Connecting to database [remote:localhost/advisors] with user 'root'...OK
orientdb {advisors}>

orientdb {advisors}> list classes

CLASSES
----------------------------------------------+------------------------------------+------------+----------------+
 NAME                                         | SUPERCLASS                         | CLUSTERS   | RECORDS        |
----------------------------------------------+------------------------------------+------------+----------------+
 _studio_bookmark                             |                                    | 11         |              0 |
 Client                                       | V                                  | 13         |              8 |
 E                                            | ORestricted                        | 10         |              0 |
 OFunction                                    |                                    | 7          |              0 |
 OIdentity                                    |                                    | -          |              0 |
 ORestricted                                  |                                    | -          |              0 |
 ORIDs                                        |                                    | 6          |              0 |
 ORole                                        | OIdentity                          | 4          |             11 |
 OSchedule                                    |                                    | 8          |              0 |
 OTriggered                                   |                                    | -          |              0 |
 OUser                                        | OIdentity                          | 5          |              4 |
 Post                                         | V                                  | 15         |              1 |
 PostBelongsTo                                | E                                  | 17         |              0 |
 User                                         | V                                  | 12         |              3 |
 V                                            | ORestricted                        | 9          |              0 |
 WorksFor                                     | E                                  | 14         |              0 |
 Wrote                                        | E                                  | 16         |              0 |
----------------------------------------------+------------------------------------+------------+----------------+
 TOTAL = 17                                                                                27 |
----------------------------------------------+------------------------------------+------------+----------------+

Console local with admin user
Strange thing (to me) is that this works, with the same credentials. Looking like the HTTP connection is different but the database still has the right user and password available to authenticate.
orientdb> connect plocal:/xxxxxx/orientdb/databases/advisors admin xxxxxx

Disconnecting from the database [null]...OK
Connecting to database [plocal:/xxxxxxxxx/orientdb/databases/advisors] with user 'admin'...OK
orientdb {advisors}>

Suspected issue
Somewhere I expect the database is mixed up with the ORole and OUser part which disables me from logging in at all.
To find the issue (or real error message) I tried to show more logging but I cannot get any more useful information out of it:
    <properties>
        <entry name="db.pool.min" value="1"/>
        <entry name="db.pool.max" value="50"/>
        <entry name="cache.level1.enabled" value="true"/>
        <entry name="cache.level2.enabled" value="true"/>
        <entry name="cache.level2.size" value="0"/>
        <entry name="profiler.enabled" value="true"/>
        <entry name="log.console.level" value="fine"/>
        <entry name="log.file.level" value="fine"/>
    </properties>

You cannot connect to the server with database's users:
orientdb> connect remote:localhost admin xxxxxxxxxx

You should rather connect to your db:
orientdb> connect remote:localhost/mydbname admin xxxxxxxxxx


Move mongo-replicaset to stable

Move to stable directory
Update to mongo:3.4
Replace PetSet with StatefulSet in docs
Update readme examples and links
Remove obsolete code from on-start.sh

cc @foxish for review

@k8s-bot ok to test

Looks like tests are still running for incubator, not stable.
Did I miss something?

@viglesiasce I can see, that tests are running against /src/incubator/mongodb-replicaset, not /src/stable/mongodb-replicaset
Any hints on fixing that?

Hey @iMelnik it might be because of the way the files were moved. Did you use git mv or mv and then git add?

mv + add, I guess this was a wrong thing to do.
I'll fix conflicts and update the pr

Had to remove readme.md changes to make tests pass. I guess I would have another PR for that

Thanks @iMelnik!
Sorry I dropped the ball on this one.
I'll take a look today.

LGTM except that one comment

@foxish removed the annotation

LGTM

Any updates on this? It looks mostly ready for primetime and I'd love to get using it ;)

@InAnimaTe there are new conflicts, I would update the branch soon and, hopefully, @prydonius would accept it

Sweetness!
Hmm, also, just stumbled upon replication config for the bitnami image, which is used for the stable/mongodb chart. Wonder if that would make setting up replication any easier?
Additionally, I'm interested in helping contribute to either make this chart support or create a new chart which can spawn a sharded cluster.

@InAnimaTe with this chart applied multiple times I was able to create a sharded cluster with 3 replicasets and a replicaset for config servers. Yet there were some manual steps to connect replicasets to config servers.

@prydonius @foxish @viglesiasce I fixed merge conflicts, I guess you could merge now.
Updates to readme would be in a separate PR

@iMelnik I'd love to hear more about you setting up a sharded cluster with this. We might be able to work together to eradicate those manual steps and make a simple toggle in values for people who might want a mongo cluster of that type.
Thanks for your (and others`) work on this!

@InAnimaTe my workflow was:
Create 3 "shardsvr" replicasets, create "configsvr" replicset, add each replicaset to config via sh.addShard( "<replSetName>/s1-mongo1.example.net:27017"), add mongos instance connected to configsrv cluster.
Basically, I was following https://docs.mongodb.com/manual/tutorial/deploy-shard-cluster/
I have not tried creating variable number of replicasets in one chart, but it might be possible

@prydonius @foxish @viglesiasce please have a look, AFAIK no more changes needed.

@prydonius @foxish Is this GTG?

No more comments from my end, all good to go.

Hi @iMelnik, can you bump the chart version to 1.0.0? I'l merge it then. Thanks!

Removing LGTM until we come to a decision about this at #767

@unguiculus @iMelnik how should we proceed given these two PRs?

I would wait until #767 is merged and update this one

@iMelnik will do

@lachie83 rebased after #767, only minimal changes here.

@viglesiasce @lachie83 I think we can merge this.

@viglesiasce @lachie83 @seanknox @prydonius any way to get this merged?

I'll do another review.

Looks fine to me, @lachie83 did you want to give this a quick look?

LGTM


Reproduction of Meta-Llama-3-8B-Instruct results on MBPP

The test results of Llama-3-8B-Instruct on MBPP differ greatly from scores on the official reports and leaderboard. I got the same result both using vllm and hf as the backend.
My results:

The official result and leaderboard's results:

MBPP+
MBPP

leaderboard
59.3
70.1

official
-
70.6

The command I ran was:
python evalplus/evaluate.py --model "meta-llama/Meta-Llama-3-8B-Instruct" --dataset mbpp --backend hf --greedy

The environment:
vllm                                     0.5.1
torch                                    2.3.0
transformers                             4.45.2

I just ran a repro via vllm 0.6.3.post1 but got an even worse result:

Also checked the log and so far it does not seem to be an EvalPlus....

I also just ran Llama3.1-8B and it does not seem to be as good as the reported Llama3-8B somehow:

I just ran a repro via vllm 0.6.3.post1 but got an even worse result:

Saw a post-processing inconsistency issue and am looking into it:

Actually it's not a parsing error but a generation issue -- the truncation is right since the bracket is not closed.

Got a higher score using HuggingFace.

I'm updating the leaderboard to reflect the latest results.
Earlier results could be higher for various reasons as I shared some other issues (https://github.com/evalplus/evalplus/issues/236#issuecomment-2430997706). 5pp difference is still strange though (may be achieved by using a stronger prompt).


Role file cross ref

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

THis still has a merge commit in your branch, please rebase your branch in a way that gets rid of the merge commit. It's acceptable to just do git reset --hard 87b80e701a2af6165fd3860de8b18788ba48b4d3 && git push -f


Fixes VELOCITY-953

VelocimacroProxy polutes context stack due to wrong handling of #break or exceptions.
First PR failed testing. This one adds a guard due to MacroOverflowException already cleaning up the stack.

link to Bug: https://issues.apache.org/jira/browse/VELOCITY-953

Thanks for the fix.


CI: Runtime Test (privileged): Test/linuxPrivilegedIPv6OnlyTestSuite/TestArpPingHandling

CI failure
level=info msg="Detected devices" devices="[]" subsys=linux-datapath
level=info msg="Detected devices" devices="[dummy0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[dummy0]" subsys=linux-datapath
level=info msg="Direct routing device detected" direct-routing-device=dummy1 subsys=linux-datapath
level=info msg="Detected devices" devices="[dummy0 dummy1 dummy2]" subsys=linux-datapath
level=info msg="Direct routing device detected" direct-routing-device=dummy1 subsys=linux-datapath
level=info msg="Detected devices" devices="[dummy0 dummy1 dummy2]" subsys=linux-datapath
level=info msg="Direct routing device detected" direct-routing-device=cilium_foo subsys=linux-datapath
level=info msg="IPv6 multicast device detected" ipv6-mcast-device=cilium_foo subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2]" subsys=linux-datapath
level=info msg="Direct routing device detected" direct-routing-device=cilium_foo subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2]" subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2 veth0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2 dummy3 veth0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2 dummy3 veth0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[cilium_foo dummy0 dummy1 dummy2 veth0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[bond0 cilium_foo dummy0 dummy1 veth0]" subsys=linux-datapath
level=info msg="Detected devices" devices="[dummy0 dummy1]" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0]" subsys=linux-datapath
level=info msg="Listening for device changes" subsys=linux-datapath
level=info msg="Listening for device changes" subsys=linux-datapath
level=warning msg="Failed to get link by index" error="Link not found" linkIndex=3 subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0]" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0 dummy1]" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0 dummy1 veth0]" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy1 veth0]" subsys=linux-datapath
level=info msg="Listening for device changes" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0]" subsys=linux-datapath
level=info msg="Devices changed" devices="[dummy0 dummy1]" subsys=linux-datapath
level=info msg="Unpinning map with incompatible properties" file-path=/sys/fs/bpf/tc/globals/cilium_tunnel_map new="Type:Hash KeySize:20 ValueSize:20 MaxEntries:65536 Flags:1" old="Type:Hash KeySize:20 ValueSize:20 MaxEntries:65536 Flags:0" subsys=bpf
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=info msg="Successfully removed non-GC'ed neighbor entries previously installed by cilium-agent" count=1 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=info msg="Successfully removed non-GC'ed neighbor entries previously installed by cilium-agent" count=1 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
level=warning msg="Attempted to deallocate a node ID that wasn't allocated" nodeID=0 subsys=linux-datapath
--- FAIL: Test (120.90s)
    --- FAIL: Test/linuxPrivilegedIPv6OnlyTestSuite (6.68s)
        --- FAIL: Test/linuxPrivilegedIPv6OnlyTestSuite/TestArpPingHandling (2.12s)
            node_linux_test.go:1246:
                ... obtained bool = false
                ... expected bool = true

FAIL

Link
PR (for main branch)
No artifacts

Seem to have hit this in https://github.com/cilium/cilium/actions/runs/6084992765/job/16508115998#step:16:1138 in https://github.com/cilium/cilium/pull/27796.

Another hit here from https://github.com/cilium/cilium/pull/28166

https://github.com/cilium/cilium/pull/28238 hit this flake.


xwm: correctly send focus event to new window

Even if we allow the focus change to the new window, we have to send the
focus explicitly. Otherwise the focus may get lost when we close a
window belonging to the same process, but do not send focus to the
remaining window.
Fixes swaywm/sway#4926

Unfortunately this did not fix the issue with firefox for me.

Indeed, it is keyboard input which breaks, I was only testing mouse input. I'll need to dig into this some more.

IIRC I tried to do what this PR does, but it caused Xwayland lockups. Could have been a bug in Wayfire though.

Feedback for your changes:
This patch doesn't fix my issue with rxvt-unicode in daemon mode (empty workspace, create two urxvtc terminals, close one using ctrl+d -> focus doesn't move to prior focussed window) but makes the cursor go crazy blinking (I'm using hide cursor while typing) when hovering over some terminals, looks inconsistent and makes things worse for me.


[Feature] Ability To Use Other Search Engines Than Bing

If its possible can you add support for Baidu, Google, Duckduckgo, Yandex, Sogou, Ecosia, You, Startpage, Brave, etc. rather on being on bing by default?

I would say not considering this at the mo. PRs are welcomed.

I don't think it is possible though. The search feature is provided by Microsoft and is tightly built into the chatbot, which is not something we can control. Workarounds may be possible, but they are sort of out of scope of this project.


fix: query params with no values should be strings

This change fixes the aws v4 signature when query string params with no values are used. This lambda is used when the option regional.enableServerUrlIamAuth = true is set in SsrSite (in my case RemixSite).
For example, posting to Remix index routes hits an endpoint such as:
https://xxxxx.cloudfront.net/?_data=routes%2F_index&index=
This version of the URL works as expected following the change

Thanks

Thanks @scarperharper! Will be in the next release.


Backlinks not loading

I'm not sure what I'm doing wrong but backlinks aren't working: site, repo.
The [[test] backlink should work, test.md is also in docs. Could you help? I'd provide more information but I have no inkling of what I'm doing wrong

Hi @rajlego !
I  tried looking around but can't find a reason it shouldn't work. I forked your repo and it seems to be working for me. Did your github actions work without any errors? Or can you try serving mkdocs locally?

Hi again @rajlego
Here is the site  I build from forking your repo
I'm curious to see what is not working on your repo

Hi @rajlego, it looks like the backlinks didn't work because your site was deployed from your main branch. Try changing that to gh-pages under Settings > pages


Helm chart updated erpnext but not frappe

Hello, I've updated the deployment using helm upgrade --install command. Erpnext version was bumped but frappe wasn't.

Are there any other steps necessary?
Thank you!

This is because frappe didn't release an update. You can check the releases here:
https://github.com/frappe/frappe/releases
For erpnext:
https://github.com/frappe/erpnext/releases

Oh, you're right. I didn't check that. Sorry for the trouble!


Meshworks

Description
This PR fixes:

Previous meshworks PR missed out the considerations where the hostname for the service (istio adapter) as well as meshery server can change, this PR adds environmental variables and reasonable defaults to them in both dockerfile and main.go
Previous meshworks PR missed adding the newly added oam directory to the github image which this PR fixes.

Adds better handling of resource deletion, that is now it deletes traits first and then proceeds to delete the application.
Notes for Reviewers
Please let me know if the env vars defaults are reasonable. The defaults value for Dockerfile is picked from the meshery server's docker-compose.yaml while the defaults in the main.go are in accordance with the dev setup.
Signed commits

[x] Yes, I signed my commits.

Println over to meshkit logger

Lgtm


fix(manager): allow sqlite-storage feature with stronghold, fix backup and restore

Description of change
This is needed on the nodejs binding because we want to offer both storages for the Node.js users.
Type of change

Enhancement (a non-breaking change which adds functionality)

How the change has been tested
The faucet.
Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that new and existing unit tests pass locally with my changes

LGTM

LGTM


can't boot up to the linux kernel

when the installation is allegedly completed, I get this screen, apparently my PC can't locate the linux kernel. I know that the problem must occur somewhere in the BTRFS mounting/formating/subvolumes but I couldn't find the error message from the outputs, I tried every command line by line so the procedure or the order of installing it must be somehow unfinished or wrong because I can't boot up to the OS.

Sorry for the late reply, I have just come back to Arch. Anyhow, it should be fixed now.


Introduce Y043: Ban type alias names from ending in 'T'

Fixes #234

Typeshed PR at https://github.com/python/typeshed/pull/8129


Introduce RecordOf to get record type from a table type

Introduce RecordOf syntax to get record type from a table type.
eg:
Account := Type(RecordOf(Accounts));

Points := Type([{x : Number, y : Number}]);
Point := Type(RecordOf(Points));
 distance(a: Point, b: Point): Number = Sqrt(Power(b.x-a.x, 2) + Power(b.y-a.y, 2));

RecordOf works only within a TypeLiteral . Lays foundations for future type helpers (eg: Union multiple record types ... ) that we may have.

This ensures that we can avoid reserving RecordOf keyword in functions
Avoids ambiguity when we move Named formula syntax to use := for example ,

Account := RecordOf(Accounts);

can mean type vs an UDF

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.


feat: connection_type()

successfully tested on Vodafone  Power Station with IP4 connection only.
Firmware: XS_<IP_ADDRESS>


(core dumped) poetry run pytest on CI when _should_start_thread is True

I'm updating anywidget to version 0.7.1 to take advantage of the really nice https://github.com/manzt/anywidget/pull/345. One consequence is that I can't run CI tests without the JS parts built, because if those files aren't found, anywidget will error.
I've been hitting a very consistent (core dumped) poetry run pytest on Github Actions CI when the JS files exist and when watchfiles is installed. It looks to be some sort of threading issue, and so not having watchfiles installed ensures that _should_start_thread is False:
https://github.com/manzt/anywidget/blob/2600bd8a85c7e8e5f5ce572410592314b713ec72/anywidget/_util.py#L178-L187
Here's a minimal example of what I'm seeing: https://github.com/developmentseed/lonboard/pull/234
Run poetry run pytest
============================= test session starts ==============================
platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/runner/work/lonboard/lonboard
plugins: anyio-4.0.0
collected 11 items

tests/test_layer.py ..                                                   [ [18](https://github.com/developmentseed/lonboard/actions/runs/6827322556/job/18569190597#step:13:19)%]
tests/test_map.py .                                                      [ 27%]
tests/test_traits.py ........                                            [100%]

============================== 11 passed in 3.66s ==============================
FATAL: exception not rethrown
/home/runner/work/_temp/4f63a42f-5562-4a63-a9ca-331e37c02752.sh: line 1:  [22](https://github.com/developmentseed/lonboard/actions/runs/6827322556/job/18569190597#step:13:23)85 Aborted                 (core dumped) poetry run pytest

This is using anywidget 0.7.1 and watchfiles 0.21.0

maybe we could create a environment variable? to force no HMR?

Yeah, that would be an ok solution... As a workaround I make sure I don't install watchfiles on CI. It would be nice if we could figure out what's actually wrong, but that might be a 🕳

Hmm, ok looking into this. The root of the issue is that we automatically read the file if a path is detected in class definition. Maybe we should delay this until the first instance of the class is created.

I don't think that's the root issue here. Maybe that was before I built the JS resources on CI, but now that the JS files exist, the class initialization works fine. It's something specifically with the threading around the HMR.

Oh ya, threads and CI can be really tricky.

haven't looked too closely yet, but if the issue only happens when start_thread is True and FileContents._background_thread is started, then the the first thing I'd try to do (just to confirm that we're right about the issue) is to force that thread to be stopped and joined in any test where it's used.  That might make for some temporarily ugly test code, but if you can demonstrate that joining/stopping that thread always prevents the core dump, then you can look into test fixtures that make sure that any FileContents threads that get started up in a test are definitely stopped.

dfdsfjjjjdfasdf
asdfdf

I got the same problem in py-maplibre, where using the widget is optional. Beside the error with pytest, I also get an error when I import the widget in __init__.py but it is not used, because e. g. the user only uses the Shiny integration of maplibre. When the Shiny app is stopped, the core dumped is thrown.

Thanks for pinging this again. I have made https://github.com/manzt/anywidget-core-dump-repro to try to reproduce the error and get to the bottom of it, as @tlambert03 described.

I just added a join/stop at the end of the code, and the thread never joined (I ended up cancelling the test in GH Actions): https://github.com/manzt/anywidget-core-dump-repro/actions/runs/7616199837

Next release of anywidget will make starting the background thread opt-in with an environment variableANYWIDGET_HMR=1.


Fix: delete PipelineRun resources along with the deletion of Pipeline

This pull request fixs a bug.

When deleting the Devops Pipeline CRD resources, the controller will erase the relevant Devops PipelineRun CRD resources, including the generated Tekton PipelineRun CRD resources and Tekton-generated Pods.
There is no reason to hold serval PipelineRun related resources if its reference Pipeline is removed.

Notes for code revision.

Delete useless comments and log printing.
Revise the comment and log message style.

After inspecting other projects like Kubernetes, I found that the comment and log message had similar pattern.
When the comment or the log message is a whole sentence, they will captilize the first letter. Otherwise, they will use a lower case.
Following the above rule, I revise the comment and log message.

Add core logic for deleting PipelineRun resources.

@LinuxSuRen Unit test was done.

Integration test was commented.

/lgtm


feat: Add pending spinner icon for pending messages (draft)

Ticket
https://sendbird.atlassian.net/browse/AC-2609

It seems that we frequently need to ask for confirmations. Please check the following list before requesting a review:

Ensure that the ticket requirements have been clearly implemented.
Verify that all CI checks have passed.
Conduct a self-review and further check for any areas of improvement or discrepancies with the requirements.

@liamcho 이거는 계속 draft 로 남아있는데, 티켓은 in review 상태인거같네요, 작업을 진행하던가 티켓 상태를 업뎃하면 좋을 것 같습니다.

@bang9 폼 작업 -> 템플릿 작업 -> 이후 재개 할 예정이라 백로그로 변경했습니다

duplicate of https://github.com/sendbird/chat-ai-widget/pull/363


Improve placeholder text in chatbox to mention @ and / commands

This PR tells users how to refer to uploaded files and prompts in a workspace using @ and / commands.
It took quite a while to figure out how to access uploaded files in user queries. Before stumbling on the twitter post at #1047 I had to manually add the same file for each new chat :(
Since this is a useful feature, it would be nice to have a bit more guidance for new users. Screenshots below show a Before Vs After comparison. The only difference is in the text in the chatbox.

Made a minor change and merged. Welcome to contributors list!


feat: add support for wildcards in subscriptions

[x] I have added automatic tests where applicable
[x] The PR title is suitable as a release note
[x] The PR contains a description of what has been changed
[x] The description contains manual test instructions

Changes
Adds support of subscription wildcards. Changes the _isSubscriberInterestedIn check to also allow wildcards at the end of the expression.
Closes #101
Test
Using the event hub, register a wildcard event, for example "ftrack.*". Make an update in studio, see that the update event is picked up.

Can we add a unit test for this?

Woah, didn't see work had started on this as well!


Use yaml_unsafe_load to handle symbols

Prevent Psych::DisallowedClass: Tried to load unspecified class: Symbol while seeding due to the default change during the rails <IP_ADDRESS> release.
https://discuss.rubyonrails.org/t/cve-2022-32224-possible-rce-escalation-bug-with-serialized-columns-in-active-record/81017#releases-2
NOTE the changelog has config.active_storage.use_yaml_unsafe_load but the actual config option is config.active_record.use_yaml_unsafe_load
$ rails db:seed
** ManageIQ master, codename: Oparin
rails aborted!
Psych::DisallowedClass: Tried to load unspecified class: Symbol
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/coders/yaml_column.rb:50:in `yaml_load'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/coders/yaml_column.rb:26:in `load'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/type/serialized.rb:22:in `deserialize'
/home/grare/adam/.gem/ruby/2.7.0/gems/activemodel-<IP_ADDRESS>/lib/active_model/type/helpers/mutable.rb:8:in `cast'
/home/grare/adam/.gem/ruby/2.7.0/gems/activemodel-<IP_ADDRESS>/lib/active_model/attribute.rb:174:in `type_cast'
/home/grare/adam/.gem/ruby/2.7.0/gems/activemodel-<IP_ADDRESS>/lib/active_model/attribute.rb:42:in `value'
/home/grare/adam/.gem/ruby/2.7.0/gems/activemodel-<IP_ADDRESS>/lib/active_model/attribute_set.rb:28:in `transform_values'
/home/grare/adam/.gem/ruby/2.7.0/gems/activemodel-<IP_ADDRESS>/lib/active_model/attribute_set.rb:28:in `to_hash'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/attribute_methods.rb:261:in `attributes'
/home/grare/adam/.gem/ruby/2.7.0/gems/default_value_for-3.4.0/lib/default_value_for.rb:160:in `block in set_default_values'
/home/grare/adam/.gem/ruby/2.7.0/gems/default_value_for-3.4.0/lib/default_value_for.rb:155:in `each'
/home/grare/adam/.gem/ruby/2.7.0/gems/default_value_for-3.4.0/lib/default_value_for.rb:155:in `set_default_values'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:428:in `block in make_lambda'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:238:in `block in halting_and_conditional'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:517:in `block in invoke_after'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:517:in `each'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:517:in `invoke_after'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:136:in `run_callbacks'
/home/grare/adam/.gem/ruby/2.7.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:825:in `_run_initialize_callbacks'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/core.rb:337:in `initialize'
/home/grare/adam/.gem/ruby/2.7.0/gems/default_value_for-3.4.0/lib/default_value_for.rb:143:in `initialize'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/inheritance.rb:70:in `new'
/home/grare/adam/.gem/ruby/2.7.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/inheritance.rb:70:in `new'
/home/grare/adam/src/manageiq/manageiq/app/models/miq_user_role.rb:93:in `block in seed_from_array'
/home/grare/adam/src/manageiq/manageiq/app/models/miq_user_role.rb:90:in `each'
/home/grare/adam/src/manageiq/manageiq/app/models/miq_user_role.rb:90:in `seed_from_array'
/home/grare/adam/src/manageiq/manageiq/app/models/miq_user_role.rb:80:in `seed'

Will this have to go back to najdorf for security reasons?

The release was for a CVE so yes

Backported to morphy in commit cc10a37b02836b1d9fb110a190557866bb01ea85.
commit cc10a37b02836b1d9fb110a190557866bb01ea85
Author: Keenan Brock<EMAIL_ADDRESS>Date:   Tue Jul 12 16:05:16 2022 -0400

    Merge pull request #21988 from agrare/use_yaml_unsafe_load

    Use yaml_unsafe_load to handle symbols

    (cherry picked from commit a4f46361e660ff468399ce86446ea1de4e8ddcc9)


Changing the background of signup page and improving the U.I.

hey @YadavAkhileshh
I suggest few changes .

change the background of your signup page and also improve the aesthetics of the signup container.
It looks pretty bland , i could add few animations .

I could also change the ui of these buttons by adding hover and few animations.

i could work on these issues , kindly assign it to me under gssoc extd , hacktoberfest

Thankyou for assigning this issue to me , ill give it my best !

hey @YadavAkhileshh , shall i place the the start game button somwhere here :

it will look better i feel


x/crypto/ssh/test: TestAgentForward fails on x_crypto-gotip-darwin-amd64-longtest LUCI builder

=== RUN   TestAgentForward
    exec.go:88: test timed out while running command: /usr/sbin/sshd -f /Users/swarming/.swarming/w/ir/x/t/sshtest3423651030/sshd_config -i -e
panic: test timed out after 10m0s
running tests:
	TestAgentForward (10m0s)
[...]

See https://ci.chromium.org/ui/p/golang/builders/ci/x_crypto-gotip-darwin-amd64-longtest/b8759816251100556177/test-results for full details.
It doesn't seem to reproduce for me locally:
$ go test -v ./ssh/test -run=^TestAgentForward$
=== RUN   TestAgentForward
--- PASS: TestAgentForward (0.79s)
PASS
ok  	golang.org/x/crypto/ssh/test	1.355s

Nor on the old dashboard, though it's hard to be sure whether this test is running or being skipped there.
This failure is blocking the automated monthly tagging workflow, so adding Soon label. If this ends up taking a while to figure out and fix, we might want to temporarily skip the test since it's happening since the builder was added in LUCI, to unblock the rest of the tagging.
CC @drakkan, @golang/security, @prattmic.

I can't reproduce it locally either. Not sure if related to #63937
I've sent a CL to skip this test on macOS for now

This doesn't quite look like a symptom of #63937: there is nothing to suggest that the underlying sshd process has actually exited at the point where the hang occurs, and even if it has, there is a leaked net.UnixConn that might be holding the connection open if its finalizer is for some reason not being run.

The output for the pending change in https://go.dev/cl/554062 shows:

=== RUN   TestAgentForward
    agent_unix_test.go:37: NewSession: ssh: unexpected packet in response to channel open: <nil>
    test_unix_test.go:235: sshd:
        Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
        /Volumes/Work/s/w/ir/x/t/sshtest1028730279/sshd_config line 10: Deprecated option KeyRegenerationInterval
        /Volumes/Work/s/w/ir/x/t/sshtest1028730279/sshd_config line 11: Deprecated option ServerKeyBits
        /Volumes/Work/s/w/ir/x/t/sshtest1028730279/sshd_config line 17: Deprecated option RSAAuthentication
        /Volumes/Work/s/w/ir/x/t/sshtest1028730279/sshd_config line 22: Deprecated option RhostsRSAAuthentication
        debug1: inetd sockets after dupping: 4, 5
        BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
        Connection from UNKNOWN port 65535 on /Volumes/Work/s/w/ir/x/t/unixConnection1298930634/ssh port 65535
        debug1: Local version string SSH-2.0-OpenSSH_9.3
        debug1: Remote protocol version 2.0, remote software version Go
        debug1: compat_banner: no match: Go
        debug2: fd 4 setting O_NONBLOCK
        debug2: Network child is on pid 81555
        debug1: list_hostkey_types: rsa-sha2-512,rsa-sha2-256,rsa-sha2-512-cert-v01@openssh.com,rsa-sha2-256-cert-v01@openssh.com,ecdsa-sha2-nistp256 [preauth]
        debug1: SSH2_MSG_KEXINIT sent [preauth]
        debug1: SSH2_MSG_KEXINIT received [preauth]
        debug2: local server KEXINIT proposal [preauth]
        debug2: KEX algorithms: sntrup761x25519-sha512@openssh.com,curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256 [preauth]
        debug2: host key algorithms: rsa-sha2-512,rsa-sha2-256,rsa-sha2-512-cert-v01@openssh.com,rsa-sha2-256-cert-v01@openssh.com,ecdsa-sha2-nistp256 [preauth]
        debug2: ciphers ctos: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>[preauth]
        debug2: ciphers stoc: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>[preauth]
        debug2: MACs ctos: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 [preauth]
        debug2: MACs stoc: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 [preauth]
        debug2: compression ctos<EMAIL_ADDRESS>[preauth]
        debug2: compression stoc<EMAIL_ADDRESS>[preauth]
        debug2: languages ctos:  [preauth]
        debug2: languages stoc:  [preauth]
        debug2: first_kex_follows 0  [preauth]
        debug2: reserved 0  [preauth]
        debug2: peer client KEXINIT proposal [preauth]
        debug2: KEX algorithms: curve25519-sha256,curve25519-sha256<EMAIL_ADDRESS>[preauth]
        debug2: host key algorithms: ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,ssh-rsa,ssh-dss,ssh-ed25519 [preauth]
        debug2: ciphers ctos: aes128-gcm@openssh.com,aes256-gcm@openssh.com,chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr [preauth]
        debug2: ciphers stoc: aes128-gcm@openssh.com,aes256-gcm@openssh.com,chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr [preauth]
        debug2: MACs ctos: hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1,hmac-sha1-96 [preauth]
        debug2: MACs stoc: hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1,hmac-sha1-96 [preauth]
        debug2: compression ctos: none [preauth]
        debug2: compression stoc: none [preauth]
        debug2: languages ctos:  [preauth]
        debug2: languages stoc:  [preauth]
        debug2: first_kex_follows 0  [preauth]
        debug2: reserved 0  [preauth]
        debug1: kex: algorithm: curve25519-sha256 [preauth]
        debug1: kex: host key algorithm: ecdsa-sha2-nistp256 [preauth]
        debug1: kex: client->server cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none [preauth]
        debug1: kex: server->client cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none [preauth]
        debug1: expecting SSH2_MSG_KEX_ECDH_INIT [preauth]
        debug1: SSH2_MSG_KEX_ECDH_INIT received [preauth]
        debug2: monitor_read: 6 used once, disabling now
        debug2: ssh_set_newkeys: mode 1 [preauth]
        debug1: rekey out after<PHONE_NUMBER> blocks [preauth]
        debug1: SSH2_MSG_NEWKEYS sent [preauth]
        debug1: Sending SSH2_MSG_EXT_INFO [preauth]
        debug1: expecting SSH2_MSG_NEWKEYS [preauth]
        debug1: SSH2_MSG_NEWKEYS received [preauth]
        debug2: ssh_set_newkeys: mode 0 [preauth]
        debug1: rekey in after<PHONE_NUMBER> blocks [preauth]
        debug1: KEX done [preauth]
        debug1: userauth-request for user chrome-bot service ssh-connection method none [preauth]
        debug1: attempt 0 failures 0 [preauth]
        debug2: parse_server_config_depth: config reprocess config len 848
        reprocess config line 17: Deprecated option RSAAuthentication
        reprocess config line 22: Deprecated option RhostsRSAAuthentication
        debug2: monitor_read: 8 used once, disabling now
        debug2: input_userauth_request: setting up authctxt for chrome-bot [preauth]
        debug2: monitor_read: 4 used once, disabling now
        debug2: monitor_read: 10 used once, disabling now
        debug1: userauth_send_banner: sent [preauth]
        debug2: input_userauth_request: try method none [preauth]
        debug1: userauth-request for user chrome-bot service ssh-connection method publickey [preauth]
        debug1: attempt 1 failures 0 [preauth]
        debug2: input_userauth_request: try method publickey [preauth]
        debug2: userauth_pubkey: valid user chrome-bot querying public key ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBGHDtsTSokVGDixBzO1WAKeexzcimznWLRw/N2eIczT1QuLTOZnRgzyy/CBML2LtsKvpaV3xkJzTG82H/YLKRtM= [preauth]
        debug1: userauth_pubkey: publickey test pkalg ecdsa-sha2-nistp256 pkblob ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo [preauth]
        debug1: temporarily_use_uid: 502/20 (e=502/20)
        debug1: trying public key file /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys
        debug1: fd 6 clearing O_NONBLOCK
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:1: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCitzS2KiRQTccfVApb0mbPpo1lt29JjeLBYAehXHWfQ+w8sXpd8e04n/020spx1R94yg+v0NjXyh2RNFXNBYdhNei33VJxUeKNlExaecvW2yxfuZqka+ZxT1aI8zrAsjh3Rwc6wayAJS4RwZuzlDv4jZitWqwD+mb/22Zwq/WSs4YX5dUHDklfdWSVnoBfue8K/00n8f5yMTdJvFF0qAJwf9spPEHla0lYcozJk64CO5lRkqfLor4UnsXXOiA7aRIoaUSKa+rlhiqt1EMGYiBjblPt4SwMelGGU2UfywPb4d85gpQ/s8SBARbpPxNVs2IbHDMwj70P3uZc74M3c4VJ
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:1: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAABAQCitzS2KiRQTccfVApb0mbPpo1lt29JjeLBYAehXHWfQ+w8sXpd8e04n/020spx1R94yg+v0NjXyh2RNFXNBYdhNei33VJxUeKNlExaecvW2yxfuZqka+ZxT1aI8zrAsjh3Rwc6wayAJS4RwZuzlDv4jZitWqwD+mb/22Zwq/WSs4YX5dUHDklfdWSVnoBfue8K/00n8f5yMTdJvFF0qAJwf9spPEHla0lYcozJk64CO5lRkqfLor4UnsXXOiA7aRIoaUSKa+rlhiqt1EMGYiBjblPt4SwMelGGU2UfywPb4d85gpQ/s8SBARbpPxNVs2IbHDMwj70P3uZc74M3c4VJ
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:2: check options: 'ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAID7d/uFLuDlRbBc4ZVOsx+GbHKuOrPtLHFvHsjWPwO+/
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:2: advance: 'AAAAC3NzaC1lZDI1NTE5AAAAID7d/uFLuDlRbBc4ZVOsx+GbHKuOrPtLHFvHsjWPwO+/
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:3: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+D11D0hEbn2Vglv4YRJ8pZNyHjIGmvth3DWOQrq++2vH2MujmGQDxfr4SVE9GpMBlKU3lwGbpgIBxAg6yZcNSfo6PWVU9ACg6NMFO+yMzc2MaG+/naQdNjSewywF5j2rkNO2XOaViRVSrZroe2B/aY2LTV0jDl8nu5NOjwRs1/s7SLe5z1rw/X0dpmXk0qJY3gQhmR8HZZ1dhEkJUGwaBCPd0T8asSYf1Ag2rUD4aQ28r3q69mbwfWOOa6rMemVZruUV5dzHwVNVNtVv+ImtnYtz8m8g+K0plaGptHn3KsaOnASkh3tujhaE7kvc4HR9Igli9+76jhZie3h/dTN5z
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:3: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAABAQC+D11D0hEbn2Vglv4YRJ8pZNyHjIGmvth3DWOQrq++2vH2MujmGQDxfr4SVE9GpMBlKU3lwGbpgIBxAg6yZcNSfo6PWVU9ACg6NMFO+yMzc2MaG+/naQdNjSewywF5j2rkNO2XOaViRVSrZroe2B/aY2LTV0jDl8nu5NOjwRs1/s7SLe5z1rw/X0dpmXk0qJY3gQhmR8HZZ1dhEkJUGwaBCPd0T8asSYf1Ag2rUD4aQ28r3q69mbwfWOOa6rMemVZruUV5dzHwVNVNtVv+ImtnYtz8m8g+K0plaGptHn3KsaOnASkh3tujhaE7kvc4HR9Igli9+76jhZie3h/dTN5z
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:4: check options: 'ssh-dss AAAAB3NzaC1kc3MAAACBAPo8NITJeIj2N82z3ta4zjoxIMJiU6pbDzRqM3XoCiG0GdyzVgGUeT/91A68Jg6xhoT6A2LHaO2hGPBeEOxzbn8ipBtTVqFvuYHz+uxogtEYhsDlYfcSAW0mZcWi8PPeJ/oXpPO+EWkeAlGYthVHxyqx7MveERk6++zaIfsyiuTHAAAAFQCRw5w/NvpcYdn2+DzLCIml7nQLAQAAAIBBF/tD+Jo9Gfjdmq5SF3pbC+KupSP62Qi7p5XadlZiZcuWoVAoTLhN6OXtaTLOvY5Ji9tcvOjtM3EsqhaivqKmzSmFg88zJeV3XiuO6FPbgKuE7O4syEN24wOLTfbAMhkbhj4rsSVTw65+fxKPlaB7yvoA2aZWCYV/KesWF1gKeAAAAIEA3ucGJ93/Mx4q4eKRDxcWD3QzWyqpbRVRRV1Vmih9Ha/qC994nJFzDQIdjxDIT2Rk2AGzMqFEB68Zc3O+Wcsmz5eWWzEwFxaTwOGWTyDqsDRLm3fD+QYjnOwuxb0Kce+gWI8voWcqC9cyRm09jGzu2Ab3Bhtpg8JJ8L7gS3MRZK4=
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:4: advance: 'AAAAB3NzaC1kc3MAAACBAPo8NITJeIj2N82z3ta4zjoxIMJiU6pbDzRqM3XoCiG0GdyzVgGUeT/91A68Jg6xhoT6A2LHaO2hGPBeEOxzbn8ipBtTVqFvuYHz+uxogtEYhsDlYfcSAW0mZcWi8PPeJ/oXpPO+EWkeAlGYthVHxyqx7MveERk6++zaIfsyiuTHAAAAFQCRw5w/NvpcYdn2+DzLCIml7nQLAQAAAIBBF/tD+Jo9Gfjdmq5SF3pbC+KupSP62Qi7p5XadlZiZcuWoVAoTLhN6OXtaTLOvY5Ji9tcvOjtM3EsqhaivqKmzSmFg88zJeV3XiuO6FPbgKuE7O4syEN24wOLTfbAMhkbhj4rsSVTw65+fxKPlaB7yvoA2aZWCYV/KesWF1gKeAAAAIEA3ucGJ93/Mx4q4eKRDxcWD3QzWyqpbRVRRV1Vmih9Ha/qC994nJFzDQIdjxDIT2Rk2AGzMqFEB68Zc3O+Wcsmz5eWWzEwFxaTwOGWTyDqsDRLm3fD+QYjnOwuxb0Kce+gWI8voWcqC9cyRm09jGzu2Ab3Bhtpg8JJ8L7gS3MRZK4=
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:12: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQC8A6FGHDiWCSREAXCq6yBfNVr0xCVG2CzvktFNRpue+RXrGs/2a6ySEJQb3IYquw7HlJgu6fg3WIWhOmHCjfpG0PrL4CRwbqQ2LaPPXhJErWYejcD8Di00cF3677+G10KMZk9RXbmHtuBFZT98wxg8j+ZsBMqGM1+7yrWUvynswQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:12: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAAAgQC8A6FGHDiWCSREAXCq6yBfNVr0xCVG2CzvktFNRpue+RXrGs/2a6ySEJQb3IYquw7HlJgu6fg3WIWhOmHCjfpG0PrL4CRwbqQ2LaPPXhJErWYejcD8Di00cF3677+G10KMZk9RXbmHtuBFZT98wxg8j+ZsBMqGM1+7yrWUvynswQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:13: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDBrjzJ9YWLe4h2rO5/1fsLZnF95r8hprDTMjAe52kXxT3ZZUiILmWgS5bX45pWLdRZ8gSNYxXW0cbKysc7C3BzfgE8ImomSdRA78q0NMFMng+vKHDVtY8L330vNr7KsJN01BgHOhE5coTFmA8WH2lMyLnCqkcO45DapkUgQjeVPQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:13: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAAAgQDBrjzJ9YWLe4h2rO5/1fsLZnF95r8hprDTMjAe52kXxT3ZZUiILmWgS5bX45pWLdRZ8gSNYxXW0cbKysc7C3BzfgE8ImomSdRA78q0NMFMng+vKHDVtY8L330vNr7KsJN01BgHOhE5coTFmA8WH2lMyLnCqkcO45DapkUgQjeVPQ==
        '
        debug1: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14: matching key found: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14: key options: agent-forwarding port-forwarding pty user-rc x11-forwarding
        Accepted key ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo found at /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14
        debug2: auth_check_authkeys_file: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys: processed 14/14 lines
        debug1: restore_uid: (unprivileged)
        debug2: userauth_pubkey: authenticated 0 pkalg ecdsa-sha2-nistp256 [preauth]
        Postponed publickey for chrome-bot from UNKNOWN port 65535 ssh2 [preauth]
        debug1: userauth-request for user chrome-bot service ssh-connection method publickey [preauth]
        debug1: attempt 2 failures 0 [preauth]
        debug2: input_userauth_request: try method publickey [preauth]
        debug2: userauth_pubkey: valid user chrome-bot attempting public key ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBGHDtsTSokVGDixBzO1WAKeexzcimznWLRw/N2eIczT1QuLTOZnRgzyy/CBML2LtsKvpaV3xkJzTG82H/YLKRtM= [preauth]
        debug1: temporarily_use_uid: 502/20 (e=502/20)
        debug1: trying public key file /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys
        debug1: fd 6 clearing O_NONBLOCK
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:1: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCitzS2KiRQTccfVApb0mbPpo1lt29JjeLBYAehXHWfQ+w8sXpd8e04n/020spx1R94yg+v0NjXyh2RNFXNBYdhNei33VJxUeKNlExaecvW2yxfuZqka+ZxT1aI8zrAsjh3Rwc6wayAJS4RwZuzlDv4jZitWqwD+mb/22Zwq/WSs4YX5dUHDklfdWSVnoBfue8K/00n8f5yMTdJvFF0qAJwf9spPEHla0lYcozJk64CO5lRkqfLor4UnsXXOiA7aRIoaUSKa+rlhiqt1EMGYiBjblPt4SwMelGGU2UfywPb4d85gpQ/s8SBARbpPxNVs2IbHDMwj70P3uZc74M3c4VJ
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:1: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAABAQCitzS2KiRQTccfVApb0mbPpo1lt29JjeLBYAehXHWfQ+w8sXpd8e04n/020spx1R94yg+v0NjXyh2RNFXNBYdhNei33VJxUeKNlExaecvW2yxfuZqka+ZxT1aI8zrAsjh3Rwc6wayAJS4RwZuzlDv4jZitWqwD+mb/22Zwq/WSs4YX5dUHDklfdWSVnoBfue8K/00n8f5yMTdJvFF0qAJwf9spPEHla0lYcozJk64CO5lRkqfLor4UnsXXOiA7aRIoaUSKa+rlhiqt1EMGYiBjblPt4SwMelGGU2UfywPb4d85gpQ/s8SBARbpPxNVs2IbHDMwj70P3uZc74M3c4VJ
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:2: check options: 'ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAID7d/uFLuDlRbBc4ZVOsx+GbHKuOrPtLHFvHsjWPwO+/
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:2: advance: 'AAAAC3NzaC1lZDI1NTE5AAAAID7d/uFLuDlRbBc4ZVOsx+GbHKuOrPtLHFvHsjWPwO+/
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:3: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+D11D0hEbn2Vglv4YRJ8pZNyHjIGmvth3DWOQrq++2vH2MujmGQDxfr4SVE9GpMBlKU3lwGbpgIBxAg6yZcNSfo6PWVU9ACg6NMFO+yMzc2MaG+/naQdNjSewywF5j2rkNO2XOaViRVSrZroe2B/aY2LTV0jDl8nu5NOjwRs1/s7SLe5z1rw/X0dpmXk0qJY3gQhmR8HZZ1dhEkJUGwaBCPd0T8asSYf1Ag2rUD4aQ28r3q69mbwfWOOa6rMemVZruUV5dzHwVNVNtVv+ImtnYtz8m8g+K0plaGptHn3KsaOnASkh3tujhaE7kvc4HR9Igli9+76jhZie3h/dTN5z
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:3: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAABAQC+D11D0hEbn2Vglv4YRJ8pZNyHjIGmvth3DWOQrq++2vH2MujmGQDxfr4SVE9GpMBlKU3lwGbpgIBxAg6yZcNSfo6PWVU9ACg6NMFO+yMzc2MaG+/naQdNjSewywF5j2rkNO2XOaViRVSrZroe2B/aY2LTV0jDl8nu5NOjwRs1/s7SLe5z1rw/X0dpmXk0qJY3gQhmR8HZZ1dhEkJUGwaBCPd0T8asSYf1Ag2rUD4aQ28r3q69mbwfWOOa6rMemVZruUV5dzHwVNVNtVv+ImtnYtz8m8g+K0plaGptHn3KsaOnASkh3tujhaE7kvc4HR9Igli9+76jhZie3h/dTN5z
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:4: check options: 'ssh-dss AAAAB3NzaC1kc3MAAACBAPo8NITJeIj2N82z3ta4zjoxIMJiU6pbDzRqM3XoCiG0GdyzVgGUeT/91A68Jg6xhoT6A2LHaO2hGPBeEOxzbn8ipBtTVqFvuYHz+uxogtEYhsDlYfcSAW0mZcWi8PPeJ/oXpPO+EWkeAlGYthVHxyqx7MveERk6++zaIfsyiuTHAAAAFQCRw5w/NvpcYdn2+DzLCIml7nQLAQAAAIBBF/tD+Jo9Gfjdmq5SF3pbC+KupSP62Qi7p5XadlZiZcuWoVAoTLhN6OXtaTLOvY5Ji9tcvOjtM3EsqhaivqKmzSmFg88zJeV3XiuO6FPbgKuE7O4syEN24wOLTfbAMhkbhj4rsSVTw65+fxKPlaB7yvoA2aZWCYV/KesWF1gKeAAAAIEA3ucGJ93/Mx4q4eKRDxcWD3QzWyqpbRVRRV1Vmih9Ha/qC994nJFzDQIdjxDIT2Rk2AGzMqFEB68Zc3O+Wcsmz5eWWzEwFxaTwOGWTyDqsDRLm3fD+QYjnOwuxb0Kce+gWI8voWcqC9cyRm09jGzu2Ab3Bhtpg8JJ8L7gS3MRZK4=
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:4: advance: 'AAAAB3NzaC1kc3MAAACBAPo8NITJeIj2N82z3ta4zjoxIMJiU6pbDzRqM3XoCiG0GdyzVgGUeT/91A68Jg6xhoT6A2LHaO2hGPBeEOxzbn8ipBtTVqFvuYHz+uxogtEYhsDlYfcSAW0mZcWi8PPeJ/oXpPO+EWkeAlGYthVHxyqx7MveERk6++zaIfsyiuTHAAAAFQCRw5w/NvpcYdn2+DzLCIml7nQLAQAAAIBBF/tD+Jo9Gfjdmq5SF3pbC+KupSP62Qi7p5XadlZiZcuWoVAoTLhN6OXtaTLOvY5Ji9tcvOjtM3EsqhaivqKmzSmFg88zJeV3XiuO6FPbgKuE7O4syEN24wOLTfbAMhkbhj4rsSVTw65+fxKPlaB7yvoA2aZWCYV/KesWF1gKeAAAAIEA3ucGJ93/Mx4q4eKRDxcWD3QzWyqpbRVRRV1Vmih9Ha/qC994nJFzDQIdjxDIT2Rk2AGzMqFEB68Zc3O+Wcsmz5eWWzEwFxaTwOGWTyDqsDRLm3fD+QYjnOwuxb0Kce+gWI8voWcqC9cyRm09jGzu2Ab3Bhtpg8JJ8L7gS3MRZK4=
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:12: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQC8A6FGHDiWCSREAXCq6yBfNVr0xCVG2CzvktFNRpue+RXrGs/2a6ySEJQb3IYquw7HlJgu6fg3WIWhOmHCjfpG0PrL4CRwbqQ2LaPPXhJErWYejcD8Di00cF3677+G10KMZk9RXbmHtuBFZT98wxg8j+ZsBMqGM1+7yrWUvynswQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:12: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAAAgQC8A6FGHDiWCSREAXCq6yBfNVr0xCVG2CzvktFNRpue+RXrGs/2a6ySEJQb3IYquw7HlJgu6fg3WIWhOmHCjfpG0PrL4CRwbqQ2LaPPXhJErWYejcD8Di00cF3677+G10KMZk9RXbmHtuBFZT98wxg8j+ZsBMqGM1+7yrWUvynswQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:13: check options: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDBrjzJ9YWLe4h2rO5/1fsLZnF95r8hprDTMjAe52kXxT3ZZUiILmWgS5bX45pWLdRZ8gSNYxXW0cbKysc7C3BzfgE8ImomSdRA78q0NMFMng+vKHDVtY8L330vNr7KsJN01BgHOhE5coTFmA8WH2lMyLnCqkcO45DapkUgQjeVPQ==
        '
        debug2: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:13: advance: 'AAAAB3NzaC1yc2EAAAADAQABAAAAgQDBrjzJ9YWLe4h2rO5/1fsLZnF95r8hprDTMjAe52kXxT3ZZUiILmWgS5bX45pWLdRZ8gSNYxXW0cbKysc7C3BzfgE8ImomSdRA78q0NMFMng+vKHDVtY8L330vNr7KsJN01BgHOhE5coTFmA8WH2lMyLnCqkcO45DapkUgQjeVPQ==
        '
        debug1: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14: matching key found: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14: key options: agent-forwarding port-forwarding pty user-rc x11-forwarding
        Accepted key ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo found at /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys:14
        debug2: auth_check_authkeys_file: /Volumes/Work/s/w/ir/x/t/sshtest1028730279/authorized_keys: processed 14/14 lines
        debug1: restore_uid: (unprivileged)
        debug1: auth_activate_options: setting new authentication options
        Accepted publickey for chrome-bot from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
        debug1: monitor_child_preauth: user chrome-bot authenticated by privileged process
        debug1: auth_activate_options: setting new authentication options [preauth]
        debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
        debug1: monitor_read_log: child log fd closed
        BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
        debug1: do_cleanup
--- FAIL: TestAgentForward (0.11s)

Some interesting differences vs. a gomote on a legacy TryBot:

The LUCI log shows an extra line at the beginning:
Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
Unfortunately, ["Error reading managed configuration"] is currently a Googlewhack. 😅

The LUCI log shows debug1: do_cleanup where the gomote log shows User child is on pid XXXX.

I suspect that the Proceeding with default configuration. line is telling us the nature of the problem: I suspect that somehow we are picking up a default configuration beyond what is in the sshd_config provided by the test, but I can't seem to get gomote to give me a LUCI instance (@cagedmantis, maybe?), and man sshd on the legacy TryBot doesn't indicate any kind of option that would correspond to that.

Hmm. The source of that very unique error message seems to be here:
https://github.com/apple-open-source/macos/blob/8a7a6aab534a6ca275e9354cc818b7a1d527daa6/OpenSSH/openssh/sshd.c#L1602-L1623
But it looks like the “default configuration” is just “not doing the custom Apple fork thing”, so maybe that's not the problem after all.
Still, there are enough #ifdef __APPLE_… in that file that I do wonder if Apple has just broken our use of sshd with some recent vendor patch. 🤔

I tried go test -v ./ssh/test -run=^TestAgentForward$ on another Mac which is closer to a "default out of the box" setup, running macOS 14.2.1 (23C71), and the issue reproduces on it (i.e., it stalls). Its sshd is located at /usr/sbin/sshd and its version is OpenSSH_9.4p1, LibreSSL 3.3.6.
@drakkan You mentioned having OpenSSH_9.0p1, LibreSSL 3.3.6. Which macOS version is that on?

@dmitshur I have a 2017 iMac with macOS 13.6.3 (22G436)

This is now mitigated by skipping the failing tests at head. Leaving open to investigate the root cause and hopefully remove the skips.

I wonder if this is related to the race reported in #64094. 🤔

I wonder if this is related to the race reported in #64094. 🤔

The code for tcpip and streamlocal forwarding is not covered in test cases :smiling_face_with_tear:

Hello, is there gomote access to a macOS 14 instance? This would make testing much easier. Thank you

Hello,
I was finally able to get access to macOS 14 (using QEMU/KVM on Linux).
This error

Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.

does not seem relevant. The managed configuration directory resolves to /private/var/db/ManagedConfigurationFiles which is empty in my installation.
The relevant error looks like this and occurs every time we open a session

BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
Could not create new audit session

It is generated here.
In previous versions, this error was not fatal.
In the latest version Apple added
#ifdef __APPLE__
	if (rc < 0 && e != EPERM)
		fatal("Could not create new audit session");
#endif

I guess the error happens because we start sshd in inetd mode like this
cmd := testenv.Command(s.t, sshd, "-f", s.configfile, "-i", "-e")

if we start sshd in TCP mode the error does not happen and it also work it we connect to sshd managed by launchd so the issue seems limited to our test cases.
I'm not sure how to proceed, maybe we can start sshd in tcp mode on Darwin (or all platforms), this will complicate things. Please let me know what you think. Thank you

It sounds like Apple has just completely broken inetd support in their sshd? In that case, we should probably ask someone at Apple what they intend to be used instead.
Is it even feasible to start sshd in TCP mode? It would need to pick its own port and omcmunicate that somehow, but I don't see a standard flag that does that.

We generate a config file on the fly, we can set the port there. We should first find a free port and then set it in the configuration file, this could be problematic with parallel tests, if we want to proceed this way perhaps it is better to add a TestMain and start the server(s) there.

We should first find a free port from Go and then set it in the sshd configuration file, this could be problematic with parallel tests

It's problematic period. In a heavily loaded CI environment, we cannot assume that there aren't other processes running concurrently that may be opening previously-free ports.
The usual solutions are to have the program allocate its own port (and log that for the consumer to connect to), or to avoid communicating over ports entirely (instead using an inetd-style API, a Unix domain socket, or similar API that avoids use of the global port namespace).


Crash on admin screen after favoriting a view

Admin view on content items list view crashes after favoriting a view.

GetFavoriteViewsForAdmin.Query is crashing when mapping to ViewDto because Route is not included in the query result.

We need to add .Include(p => p.Route)

Fixed with v1.0.3


Download page

Tasks:

Required:

[x] #268
[x] #399
[x] #400

Would be nice to have:

[ ] #415

@rmanaem Let's close this down and keep #415 around?

Sounds good, do u wanna detach #415 from this epic?

@rmanaem Yes!


UTF-8 encoding of from and fo field in emails

Neither the "To" nor the "From" field are properly encoded to support display-names with special characters (e.g. "Max Müstermann" <mm@example.org>). The display-name of the name-addr would require an encoding similar to the already performed encoding of the subject.

Linked to https://github.com/silverstripe/silverstripe-framework/issues/1366.
Mailer is bad and has this among other problems.

Best solution here is #1366, and as such I'm going to close this.


🗑 Deprecation of toStrictlyNegativeInt function in ResultContext with warning level

📝 Description
We would like to deprecate the toStrictlyNegativeInt function in ResultContext with a warning level for using the StrictlyNegativeInt.Companion.create(Number) function instead.
🔗 Dependencies
This issue is blocked by the following ones:

[x] #441

✅ Checklist

[ ] Deprecate the declaration with a warning level, refactor its usages and update the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

We are not ready to implement this change.


Glitches regarding simple eyes.

As I have already read through other reports, you can add multiple eyes to a character, this causes some issues with the simple eyes which go directly on the skin and therefore are always active and caused my 2y2 eyes to look glitched and only partially black. I attempted everything that has been already said and it did not work. the only thing that happened to make it work slightly was removing the pixels that make up the extra eyes, which in my case works since im in singleplayer but makes it a hassel to switch between a skin I can use for multiplayer and back.
Even then the eyelashes did not seem to work properly as when I looked up with the mod and skin the eyelashes would extend.
Not sure if there's a way to toggle which eyes get used and if that would also help the eyeslashes in turn as Im 99% sure that issue has to do with the missing pixels?

Trying to recreate it has yielded no results weirdly enough but here is what I have found with the 2x2 eyelashes extending even with the model that has all pixels and the skin texture im using


[Chore][docs] Update codebase connection

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Update codebase connection
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

HI @wuchunfu, could you please tell us more about the update of codebase connection, thanks

HI @wuchunfu, could you please tell us more about the update of codebase connection, thanks

The main change is to change https://interestinglab.github.io to https://seatunnel.apache.org , because the official website is now available


Add commentary on reuse of interfaces/boundaries data structures

Can be merged when tests pass :+1:


Synthesis failed for Google.Cloud.Container.V1

Hello! Autosynth couldn't regenerate Google.Cloud.Container.V1. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to a new branch 'autosynth-Google.Cloud.Container.V1'
Cloning into '/tmpfs/tmp/tmp68sszk8c/googleapis'...
Note: checking out '88316b63a486002727e14032d104690541179fc9'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 88316b63a Generated synth.py files with multiple commits enabled
Note: checking out '7be2811ad17013a5ea24cd75dfd9e399dd6e18fe'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 7be2811a fix: Update gapic-generator version to pickup discogapic fixes
Switched to a new branch 'autosynth-Google.Cloud.Container.V1-2'
Running synthtool
['/tmpfs/src/git/autosynth/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-03-30 07:23:14,960 synthtool > Executing /tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Container.V1/synth.py.
Contents of preconfig file:
{"preclonedRepos": {"https://github.com/googleapis/google-cloud-dotnet.git": "/tmpfs/src/git/autosynth/working_repo", "https://github.com/googleapis/googleapis.git": "/tmpfs/tmp/tmp68sszk8c/googleapis"}}Extracted repo location: /tmpfs/tmp/tmp68sszk8c/googleapis
generateapis.sh: line 40: declare: GOOGLEAPIS: readonly variable
2020-03-30 07:23:15,006 synthtool > Failed executing /bin/bash generateapis.sh --check_compatibility Google.Cloud.Container.V1:

None
2020-03-30 07:23:15,008 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Container.V1/synth.py", line 22, in <module>
    hide_output = False)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('/bin/bash', 'generateapis.sh', '--check_compatibility', 'Google.Cloud.Container.V1')' returned non-zero exit status 1.
Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 482, in <module>
    main()
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 334, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 429, in _inner_main
    branch,
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 135, in synthesize_loop
    metadata_path, extra_args, deprecated_execution, environ, synthesize_py_path,
  File "/tmpfs/src/git/autosynth/autosynth/synth.py", line 278, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/git/autosynth/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Update footer.html

Updated folder.html
Pull Request Type
[ ] Solved an issue/task
--> Solved: Fork, Commit, Merge - Easy Issue 3 (HTML) #1576
What is the current behavior?
--> Issue Number: #1576
What is the new behavior?
--> The copyright text "Copyright © 2023 Fork, Commit, Merge" appears inside a  (paragraph) element that is added to the bottom of the page by this code snippet.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


feat: save filters to localstorage

Description
discord username: Uğur Demirel#7911
closes #893
I add simple useLocalStorage hook to save filters and load it back when page is refreshed.
## Things to check before creating a PR

[ ] I have inspected my topic, checked.
[ ] If it is a core feature, executed detailed tests.

Changes

[x] A new feature (a change that adds a new feature, not a breaking change)
[ ] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

Instead of saving values to local storage separately we can use persist middleware from zustand to sync the store with localStorage.

I'm not familiar with zustand actually, so I made these changes with localstorage. Feel free to close pr if it will mess up the structure 👍

how logical is it to save filters to localStorage? Do I really need to see the same filter when I enter the site 2 days from now?
It makes more sense to keep it in the url instead.

agreed, this needs to be saved in url.


fast-fail in as_bind_group

Objective
prevent gpu buffer allocations when running as_bind_group for assets with texture dependencies that are not yet available.
Solution
reorder the binding creation so that fallible items are created first.

this is an improvement but i should note: we still potentially create some textures before discarding them, if earlier images in the binding_impls order are available and later ones are not.
it would be a little more involved to gather all the required handles before creating any gpu resources but probably worthwhile.


MeshService list and view

Description
MeshService has landed and we should make it appear in the list and have a detail view.
What apis on the backend are we missing (policy attachment probably missing for .e.g).
Will need a feature flag (or maybe we just don't show if there's no MeshService in the meshinsight?)

Related PRs:

https://github.com/kumahq/kuma-gui/pull/2546
https://github.com/kumahq/kuma-gui/pull/2561
https://github.com/kumahq/kuma-gui/pull/2562
https://github.com/kumahq/kuma-gui/pull/2564

Closing this seeing as list and details views where done in the above PRs. Theres also #2470 to cover MeshService deeper integration


Add RTL

Hello,
Please add this pull request to add RTL support for off-canvas.
I will more to make full RTL.

May I rewrite the code based on yours?

Yes, you can.
Just I want to add full RTL support I will add more code in next days.

@AGhasemzadeh Could you list all places that you will need RTL support? (Actually I am not a RTL habit guy. So I need your help.)

yes,
I will list them and RTL support as pull request.

@picturepan2 Please merge this pull after that I will edit all parts.

@alighasemzadeh Hi Ali. My name is Peyman and I think we are both interested in RTL support in Spectre. Would you please tell me how much support does it have, and do you need any help in this task ?


swr repeated render problem

Use the react-router-v6 version and use Outlet to map sub-components. When the navigation is rendered, the const { data } = useSWR('/api/user', fetcher) data of the sub-component will be re-rendered. This is a problem. swr2.2.0 version

When const { data } = useSWR('/api/user', fetcher) is not used, the subcomponent will not be rendered.

I tested it and it worked fine before version 2.1.3, but started to have problems after version 2.1.4. Please check if there are any major changes in version 2.1.4.


page render fail when server api not ready.

Environment

Operating System: Windows_NT
Node Version:     v18.15.0
Nuxt Version:     3.4.3
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, experimental, css, colorMode, nitro, app, build, pwa, devtools
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://github.com/transtone/vitesse-nuxt3
Describe the bug
If use top lever await in server api. On waiting, it will get a 500 page with message: Cannot access 'renderer$1' before initialization
Additional context
No response
Logs
No response
relation issue:
https://github.com/nuxt/nuxt/issues/20576

Nitro does not support top-level await. (Instead, you can use defineLazyEventHandler in these situations.)
cc: @pi0

https://github.com/nuxt/nuxt/issues/14348#issuecomment-1411724974

the key is Cannot access 'renderer$1' before initialization, not only top-level await, but other nitro wait cause this.
why client hmr can't wait till nitro is ready?

the key problem is, when the error start, the whole client gos wrong forever! all page become the error page,  refresh and reopen has no effect.

it MUST kill the server and restart it.

Would you provide a reproduction without using top-level await? 🙏

This problem appeared in an internal project with server/api, It hard to trace the real problem.
but when update to nuxt-3.5.2 with https://github.com/nuxt/nuxt/pull/21008, it never appeared again.