Access control

Closes https://github.com/devonfw-sample/devon4quarkus-reference/issues/27

Added Smallrye JWT extension
Added role-based access control to the products service to secure the delete and post method
Adapted tests
Added documentation on how to deploy and configure keycloak

@GuentherJulian please check the credentials and please redo a clean PR. There are private keys  here as part of the PR.
Not sure where they come from. But we have to be careful to not have any passwords and private keys in Git if possible although if they are just for "testing" as it will ring alarms at different ends as well and we'll get contacted to clarify such things as there is always the risk that we will oversee some critical occurrences for sure.


Add NFS CSI plugin to DC/OS

High-level description
Add NFS CSI plugin into DC/OS
Corresponding DC/OS tickets (required)

D2IQ-65490 Add NFS CSI plugin into DC/OS

@mesosphere-mergebot help

@mesosphere-mergebot test all

@mesosphere-mergebot test all

@mesosphere-mergebot test all

@mesosphere-mergebot ready-for-review-label

@mesosphere-mergebot ready-for-review-label

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot test all

Ideally I think this PR would come after one which has already set up the csi_plugin_config_dir flag on an updated Mesos agent to pick up the config file which is added by this PR. That way, we would know that the plugin container is launched successfully on agent startup.
We could either include the Mesos bump and Mesos agent flags update in this PR, or we could just wait until the Mesos bump lands to test/merge this one, I would be OK with either. WDYT?

Yeah, I would suggest we land #7574 and #7586 and then land this one. WDYT?

Ideally I think this PR would come after one which has already set up the csi_plugin_config_dir flag on an updated Mesos agent to pick up the config file which is added by this PR. That way, we would know that the plugin container is launched successfully on agent startup.
We could either include the Mesos bump and Mesos agent flags update in this PR, or we could just wait until the Mesos bump lands to test/merge this one, I would be OK with either. WDYT?

@greggomann Yeah, I would suggest we land #7574 and #7586 and then land this one. WDYT?

Yep, sgtm.

@mesosphere-mergebot changelog-not-required internal


New endpoints, quicker responses & more

New endpoints:

/reset: resets the chat thread
/regenerate: clicks on the Try again button to regenerate response

Also added logic to get the response as soon as it's done rendering (instead of sleeping 10s).
Documentation touchup to include new endpoints.

good job

Am I missing something or is your PR missing the run.sh file?


Feature request: Convert to TypeScript

Prerequisites

[X] I have searched the repository’s issues and Kinde community to ensure my feature request isn’t a duplicate
[X] I have read the contributing guidelines
[X] I agree to the terms in the code of conduct

What is the problem you’re trying to solve?
Feedback from the community is they would like a TS version of the SDK.
We currently expose all the types in a type definition file index.d.ts
What solution would you like to see?
Conversion of library to TypeScript
Additional information
No response

Hey @DaveOrDead ! willing to pick this up next :smile:  please assign it to me

Awesome stuff, you're on fire! 🔥

Hey @DaveOrDead, sorry if this is taking a bit long, but I just wanted to let you know that I'll have a pull-request up for this, sometime this week :smile:

Champion - thanks @atifcppprogrammer!


Add exclude method on posts while querying

Adding exclude method on posts while querying
https://medium.com/@InaniT0/sometimes-when-querying-some-models-we-want-to-exclude-colmuns-from-the-results-the-same-as-using-b2001af4b0ec

@themsaid - I have fix for this, need permission to push this fix

Any reason for not using a select (or setting the columns in get) while querying?
$medicines = \App\Medicine::get(['id', 'name']);

This would give me the id and name fields of Medicine, without the description.
(Btw. Medium is not available in Egypt, where themsaid resides, so he can't see the linked article.)

What @ventrec says.
Wink is just a backend. You can use the Post model to query posts as you wish in your frontend.


mat-menu generation using dynamic data not showing arrow and nested sub-menus on hover

Reproduction
I am trying to generate n-level nested mat-menu using dynamic data,
If you repeat the reproduction steps with static html you will get the same issue.
here is theStackBlitz https://stackblitz.com/edit/angular-dlzv3q-fofemy
Steps to reproduce:

wrap mat-menu-item in a ng-template outside of mat-menu
use ng-container with ngTemplateOutlet inside mat-menu to render template created in step 1

Expected Behavior
mat-menu should display the arrow for nested mat-menu and on hover it should display the nested mat-menu
Actual Behavior
mat-menu is showing only top-level mat-menu-items without arrow and hover behavior, but on clicking an mat-menu-item(which have nested menu) main menu closes and nested menu opens up..
Environment

Angular: 8.1.0
CDK/Material: 8.0.2
Browser(s): Chrome
Operating System: Windows

Im having the exaclty same issue. Couldnt find a away to avoid that.

Same here.  It works correctly back in angular/components 8.0.1.  Have the same issue even with angular/components 8.1.0.

Could the failures in the dynamic cases be due the move to @ContentChildren(MatMenuItem, {descendants: true}) in #11720 for mat-menu and/or mat-menu-item?

Just noticed #16502 reverted the changes.  Simply hasn't been released yet.

The PR to revert this was closed without being merged.  I'm not sure where things stand.

Same problem... Any other way to create dynamic menus as of now? We cant upgrade to the new version due to this problem...

Dynamic menus are also not functioning properly for me. I am using this concept: https://stackblitz.com/edit/dynamic-nested-topnav-menu but I'm on Angular Material 8.1.3.
Navigation Component:
<nav fxLayout="row" fxLayoutGap="1em">
  <ng-container *ngIf="_navItems$ | async as navItems">
    <ng-container *ngFor="let item of navItems">
      <!-- Handle branch node buttons here -->
      <ng-container *ngIf="item.items && item.items.length > 0">
        <a mat-button [matMenuTriggerFor]="menu.childMenu">
          {{item.title}}
        </a>
        <app-menu-item #menu [items]="item.items"></app-menu-item>
      </ng-container>
      <!-- Leaf node buttons here -->
      <ng-container *ngIf="!item.items || item.items.length === 0">
        <a mat-button>
          {{item.title}}
        </a>
      </ng-container>
    </ng-container>
  </ng-container>
</nav>

Menu Item Component:
<mat-menu #childMenu="matMenu" [overlapTrigger]="false">
  <ng-container *ngFor="let child of items">
    <!-- Handle branch node menu items -->
    <ng-container *ngIf="child.items && child.items.length > 0">
      <button mat-menu-item color="primary" [matMenuTriggerFor]="menu.childMenu">
        {{child.title}}
      </button>
      <app-menu-item #menu [items]="child.items"></app-menu-item>
    </ng-container>
    <!-- Handle leaf node menu items -->
    <ng-container *ngIf="!child.items || child.items.length === 0">
      <button mat-menu-item>
        {{child.title}}
      </button>
    </ng-container>
  </ng-container>
</mat-menu>

For me, the top level menu is staying open on each click of a top level item. So I end up with a bunch of mat-menus open at one time. Possibly related to this pull request: https://github.com/angular/components/pull/15373

So far, whoever requires dynamic menu nesting is stuck with 8.0.x.
This directly affects the library I developed for that very purpose ng-action-outlet(@ng-action-outlet/core and @ng-action-outlet/material). Feel free to use it.

Official statement: https://github.com/angular/components/issues/17073#issuecomment-548459282

To everyone looking for dynamic menus in angular 8 i made a working example:
https://stackblitz.com/edit/dynamic-material-menu-angular-8

@Harpush yes this works, I already use it in my library, but it's not flexible enough. It works perfectly fine with direct menu nesting, however if in the middle of mat-menu-item you wanna have any other component it will break (This is required for ng-action-outlet).
I will try to refactor it completely to make it run again on 8.1.x (not sure yet if it will work though), I do hope however Material will not change it in a month again :)

I managed to update ng-action-outlet above Material ~8.1.0. This required a substantial refactoring though.
If you're writing your own component to render menus dynamically, the key is to maintain the direct menu nesting between mat-menu and mat-menu-item, without any components in between, due to that recent material change of querying for direct children only.
Example from @Harpush demonstrates this nicely: https://github.com/angular/components/issues/16457#issuecomment-548547659

Anyone interested in a library, here are the usage examples:

As mentioned above, this doesn't work because the menu items are defined outside the menu. Closing since there are ways around it above. Also this is how the framework works and we can't do much about it.


Fix Event ID and Source for Cloud Events without SelfLink

Expected Behavior
Event ID and Source are setup according to https://github.com/cloudevents/spec/blob/master/spec.md#producer without using
Actual Behavior
Right now the ID is a newly generated uuid and source is ObjectMeta.SelfLink.
That should be enough to ensure that that the source+id in globally unique, however SelfLink is deprecated, so it needs to be replaced.
Steps to Reproduce the Problem

https://github.com/tektoncd/pipeline/blob/a6081f167c5b1461a197ab98e93103f405247f19/pkg/reconciler/events/cloudevent/cloudevent.go#L102

Additional Info
https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190711-remove-selflink.md#risks-and-mitigations

Hi @afrittoli ,
After thinking about Source attribute, I am wondering if we can introduce new func in the objectWithCondition to get CloudEventSource to populate it (also should be renamed). For example, GetCloudEventSource and its corresponding  function in both run_types.go (This examples are from Knative impl though).
I think this would be a fair alternative to imitate SelfLink before the removal comes.
Renamed candidate: Runnable, Emittable, Reportable... I do not have a good sense for naming stuff😅
I would like to pick up this as my first contribution to Tekton.
Or, would you plan for another semantics for ID and Source?
It would be my pleasure to let me know if you have a better idea.
Thanks,

Sorry I have missed #2684 and its context. Never mind.😓

I have missed #2684 and its context, and turns out it it not really good first issue. Never mind😅

@tom24d sorry, I'm a bit late on replying to this. #2684 was an idea, but it would need to go with a TEP probably before going ahead, it's not something we've agreed upon yet.
I like the idea of using an interface for solving the source issue, and I don't like the existing name of the interface I created :D so I wouldn't mind changing it.
Emittable sounds like an interesting idea :)
How would you build the source for taskrun and pipeline runs? I see two alternatives, one a specific tekton installation as the source and the other (like today) would be to have the taskrun or pipeline run being the source (so the producer of the event).

@afrittoli
No problem! Thanks for the reply.

one a specific tekton installation as the source

Is it implying we want to identify the sources for the case of Tektons in multi-cluster? That sounds needed for me, but I assume we want to avoid having DefaultCloudEventSourceForTaskRun, DefaultCloudEventSourceForPipelineRun,.. etc. I am wondering if we have new one field such as DefaultClusterName(=https://tekton.dev as default) in the ConfigMap, then composing the source by:
<DefaultClusterName>/pkg/apis/<version>/namespace/<ns>/**run/<name>
How does this sound?
Maybe I have seen a comment that Tekton folks are a bit worried about the increase of settings, but I do not remember where :(
Would you think it is worth?

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Just ran into this on a Kubernetes 1.20.2 cluster and ran into this issue. It is causing cloudevent sending to fail with this error message:
{"level":"warn","ts":"2021-02-13T21:03:45.224Z","logger":"tekton.github.com-tektoncd-pipeline-pkg-reconciler-pipelinerun.Reconciler","caller":"cloudevent/cloud_event_controller.go:145","msg":"Failed to send cloudevent: source: REQUIRED\n","commit":"95144d9","knative.dev/traceid":"d2d67f73-3676-417b-b631-c3b6a7e24cfb","knative.dev/key":"default/pipelinerun-7aed775c-ef40-462e-9ec5-5c6c4c45bf67","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/pipeline/pkg/reconciler/events/cloudevent/cloud_event_controller.go","line":"145","function":"github.com/tektoncd/pipeline/pkg/reconciler/events/cloudevent.SendCloudEventWithRetries.func1"}}

What this means is that the Kubernetes API is returning an empty string for this call:
https://github.com/tektoncd/pipeline/blob/master/pkg/reconciler/events/cloudevent/cloudevent.go#L98
There needs to be some sort of patch for this otherwise it fails very silently. I can submit a PR to change the source to something that will resolve, but its going to be a breaking change in some manner.

/remove-lifecycle rotten


Add a scroll to top icon / button for longer pages

Describe the solution you'd like
For long blog posts there should be a scroll to pop button / icon that returns the user to the beginning of the page

for this app version primeicons should be used
applied in the app.component should be fine

@DongreJaipal can you also comment here so I can assign this completed issue to you

.take


PHPUnit 6 does not work with the default ExampleTest

Detailed description
PHPUnit 6 wants PHPUnit\Framework\TestCase
but the default file has extends \PHPUnit_Framework_TestCase
so if composer install installs 6 per the composer.json options ~4.0||~5.0||~6.0
then this will break.
Context
Not sure the best solution. The user might not run composer install prior to running the prefill file so hard to fix it during setup.
Possible implementation
Maybe update the docs? I am happy to provide a fix just not sure the best way to go with it.
Your environment

PHP 5.6

I'd say we can move away from version 4.0. If I'm not mistaken 5.0 supplies both the _'d class and the namespaced one, so we can just move to the namespaced one.

thanks for the fix @ozh


Improve file structure

We should come together and discuss this one. I like it best if my folders/modules grow naturally, have a similar size and contain similar content. If there are other things we want to consider, share them below.

@bionboy, I need to merge this PR. Otherwise, we'll have a huge clusterfuck later on. Let me know in discord (or by creating a new PR) if you think we should use a different style.
There probably are styles to creating submodules other than "what feels right".

@ClashLuke LGTM!


Bug : Our Mission and Our Vision Section Collides

Description
In the About Us Page , Our Mission and Our Vision Section Collides with each other . Which made it difficult to read some part of Our Mission section.
Steps to Reproduce
Steps to Reproduce the Issue:
Open the website: Navigate to https://pathsphere.netlify.app/
Navigate to the Footer:
Scroll down to the About Us
Click on the About Us.
Observe the behavior:
Our Mission and Our Vision Section Collides with each other . Which made it difficult to read some part of Our Mission section.
Expected Behavior
No response
Actual Behavior
No response
Screenshots

Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[X] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I want to work on this issue. (optional)

If possible , could you assign me this issue under gssoc extd , level1,hacktoberfest and hacktoberfest-accepted labels ? Looking forward for your response .

sure go ahead
Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like this:
Closes #IssueNumber
Note: the level of the issue may change based on the quality of the PR cod


Add default value support to components

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Add the ability to pick the default value for a component
Examples 🌈
No response
Motivation 🔦
I would like the license key generator to default to a subscription mode. I'm using the Select component, in which it's impossible to implement.

It's currently possible (as a test I've set your license model to "perpetual" by default), but the UI currently doesn't update with it. The reason is that default values are set on the first render only. I'd consider this a bug.

I have found a new use case for that defaultValue with a TextField. I would like it to be new Date(new Date().getTime() + 1000 * 366 * 60 * 60 * 24).getTime().

I have landed again on this problem. It behaves strangely. Here is a different angle:

Add a TextField on the page
Set the value to Foo
💥 the value is not visible on the text field
💥 same in the binding view

Reload: ✅

It behaves strangely.

The reason it behaves like this is that default value is only used during the first render. When the default value is changed while the component is already being rendered, it doesn't have an effect. But I agree it's strange behavior, we should probably make an exception to it for when the value is changed by the user in the editor.
There may also be a benefit to having a separate defaultValue property.

The reason it behaves like this is that default value is only used during the first render.

+1 to try to experiment with remounting the component when the value changes.  If it's not enough, then defaultValue, might be needed.

I have found a new use case. I would like in https://master--toolpad.mui.com/_toolpad/app/cl4hla83p01949xoizo5uxf2a/editor/pages/cl4hla87800029xoihl7tf4qz to be able to use a page parameter.
To be more precise, my use case is to be able to add ?order=121 in the URL, which would be equivalent to execute:
npx @material-ui/x-license --order 121

I can't bind the URL parameter to the "value":

Are you looking for a way to two-way bind? as in, changes in the text editor should also be reflected in the url?

Are you looking for a way to two-way bind? as in, changes in the text editor should also be reflected in the URL?

No, one-way binding: URL -> Default value.

Awesome, a feature now in used for https://master--toolpad.mui.com/deploy/cl4hla83p01949xoizo5uxf2a/pages/cl4hla87800029xoihl7tf4qz?order=5225


Change uuid library

Switch to using a different UUID library before code.google shuts down
I am not entirely sure on the version of UUID required by these methods but the proposed library supports them all. Whichever library is used, such as the one used in the rabbitmq module, code.google needs to change

The uuid library was moved to https://github.com/pborman/uuid. So we can just switch to that quite easily. Also the PR includes 30 file changes for imports.

Switched to github.com/pborman/uuid which is basically just an import of the one from code.google.com

Yeah sorry, was changing on my fork but not in mown branch :P was only meant to submit the original change my bad


Use Continue rather than Submit for the identity flow

When a user has arrived via the identity flow, the Submit button on the
check answers page is misleading, because the flow doesn't end there.
A more appropriate term is Continue.
This change ensures that when a TrnRequest is generated via the identity
flow, that we display the appropriate term.
Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally

Tests are breaking:
undefined local variable or method `when_i_press_the_submit_button'


support mounting APIs somewhere other than /_matrix

there is at least one major 'run your own cloud' project which cannot ship Matrix currently because they demand all their services are mounted on specific subpaths on the server root, of which /_matrix is apparently not desirable. I suggest we make .well-known let you route to alternative subpaths.

Closing in favour of https://github.com/matrix-org/matrix-doc/issues/2780


Chore - Add storybook

This PR adds Storybook to the project, including:

[x] An example for Footer and Header components
[x] Snapshot testing

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


skip sc-list when it is not found, so other repos can be cloned

what should we do, if there is no sc-list in repo? Just Load All? Or write some more meaningfull error?


How to get control by name?

Hello.
Please, help. How do I get control as an object by its name?
In ksaml, its code looks like this:
    <TabControl Width="480" Height="{Binding $parent.Bounds.Height}" x:Name="tabControl">     </TabControl>
and i need access to this control from code like this:
    this.tabControl
Is it possible to do?

And one more question - as can be seen from the announcement of the TabControl, its height is given as a number. Is there a way to do something like this:
  Width="{Binding $parent.Bounds.Width * 0.6}" ?
Thank you in advance.

this.FindControl<TabControl>("tabControl")
You need to use value converters http://avaloniaui.net/docs/binding/converting-binding-values#binding-converters

@kekekeks Thank you very much!


Test: Blockquote

For #271
Tests pass, but how would I determine which classes should be used in the snapshot?  When the Blockquote renders on the website it has some additional styles (as in screenshots of my inspector below). 😐
Shouldn't I be testing for the styles that these components actually render? What am I misunderstanding here?

I was mimicking the Avatar style tests. (the styles look different in my browser devtools too)

What kind of change does this PR introduce?
Test

Does this PR introduce a breaking change?
No

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   67.18%   67.18%
=======================================
  Files          85       85
  Lines         649      649
  Branches      149      149
=======================================
  Hits          436      436
  Misses        213      213

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7991f5...c17e8eb. Read the comment docs.


Implement Tag Task Command, Logic, Storage

Codecov Report

Merging #108 (4aa0b1a) into master (8e8b77b) will decrease coverage by 1.06%.
The diff coverage is 28.37%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     57.27%   56.20%   -1.07%
- Complexity      450      456       +6
============================================
  Files            94       96       +2
  Lines          1725     1788      +63
  Branches        186      201      +15
============================================
+ Hits            988     1005      +17
- Misses          679      721      +42
- Partials         58       62       +4

Impacted Files
Coverage Δ

src/main/java/manageezpz/MainApp.java
0.00% <ø> (ø)

...java/manageezpz/logic/commands/TagTaskCommand.java
0.00% <0.00%> (ø)

...ava/manageezpz/logic/parser/AddressBookParser.java
66.66% <0.00%> (-2.90%)
:arrow_down:

.../manageezpz/logic/parser/TagTaskCommandParser.java
0.00% <0.00%> (ø)

src/main/java/manageezpz/model/AddressBook.java
24.03% <ø> (ø)

src/main/java/manageezpz/model/Model.java
100.00% <ø> (ø)

src/main/java/manageezpz/model/task/Task.java
67.56% <25.00%> (-5.16%)
:arrow_down:

.../main/java/manageezpz/storage/JsonAdaptedTask.java
47.61% <48.57%> (+1.46%)
:arrow_up:

src/main/java/manageezpz/model/ModelManager.java
73.41% <50.00%> (+2.68%)
:arrow_up:

...anageezpz/storage/JsonSerializableAddressBook.java
91.66% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8b77b...4aa0b1a. Read the comment docs.


Allow InferenceService url scheme to be configurable

What this PR does / why we need it:
This allows the URL scheme to be configurable in the inferenceservice-config configmap.
We have a wildcard certificate in the istio gateway to allow https traffic. We would like this to be reflected in the isvc url so users know they can use https.
Type of changes
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

add `urlScheme` to the inference service configmap which by default is set to http

This is quite useful, thanks @markwinter !
/lgtm
/approve


Bring Jordi Coverage up

Jordi is probably the service with the lowest coverage and its averaging down on the rest of the project, so this needs a fix

Now the coverage is up to 90%


Using self.free() in a script causes errors in release builds only

Godot version
4.0.rc1
System information
Fedora 36 x86_64
Issue description
Context: I tried having an instanced game/level scene free itself and return to main menu when pressing ESC. Editor runs and debug builds don't report anything and it works as I expected, but release builds behave unexpectedly.
Running a release build (I tried both Linux and web) throw this to console:
SCRIPT ERROR: Parse Error: Function "free()" not found in base self.
and apparently further signals cannot find their method in the same script, like this:
ERROR: Error calling from signal 'body_entered' to callable: 'Node2D(gamescene.gd)::_on_drop_body_entered': Method not found.
Commenting out self.free() method call is enough to have the rest of the script behave as expected in release builds.
Now, calling self.free() may be a bad idea in general (is it? I didn't read anything about it in docs), but I would like debug and release builds to behave in the same way, bar performance.
Only checked GDscript, not sure if it happens with C#.
Steps to reproduce

Create a parent scene that instantiates another (possibly this step can be skipped)
Create a scene with a script that calls self.free() in some manual way (Input event, button)
Export/run debug/editor build - no issues
Export a release build - script calling self.free() throws above error and breaks signals in the same script (possibly doesn't parse the rest of the script?)

In the attached minimal reproduction project the control.gd script instantiates the gamescene and gamescene.gd contains the call to self.free().
There is an example of signal not firing when the box enters the blue Area2D.
Minimal reproduction project
40rc1free.zip

For anyone stumbling on this - I fixed my project by connecting a signal to the instancing (menu) scene and calling .queue_free() from there on the game instance.
Still, the issue of inconsistency between debug and release builds remains.

Got bitten by this as well.
I've found that defining a helper,
func free_object(obj: Object):
	obj.free()

and replacing calls to free() with free_object(self) is enough to entirely work-around the issue.


Minimize hard-coded interfaces

The interfaces in the using-python branch (e.g. for Vector) have hard-coded wrappers for every single supported function and property from NEURON. In principle, we could get to feature complete for NEURON's built-in classes by auto-generating these wrappers, but that would produce many lines of repetitive code that would have to be updated as methods are added. More importantly, this wouldn't support any custom HOC classes whose interface is user-defined.

Example of dynamic properties
Key steps: closures to keep track of names and inheriting from dynamicprops.
In practice instead of using disp, we'd send to the Python/C++ API the object, the name, (and for the setter the value).
classdef mywrapper < dynamicprops
    methods
        function add_property(obj, name)
            new_prop = obj.addprop(name);
            function my_setter(obj, val)
                disp(sprintf("Attempting to set %s to %g", name, val));
            end
            function value=my_getter(obj)
                disp(sprintf("Attempting to read %s", name));
                value=17;
            end
            new_prop.SetMethod = @my_setter;
            new_prop.GetMethod = @my_getter;
        end
    end
end


SCOW image

Hey there.
Is the docker SCOW image or the vagrant one suitable for productionnal use?
Is there like automated script that can deploy to remote cloud? like Azur...
Thanks

Hello.
We use docker SCOW image in production, the vagrant one is for trail and development.
We only have scow-cli tool for local server dployement at this time.

Could you please give me the link to and steps to install the SCOW docker image If possible in english? I would like to deploy it on cloud server. Thnaks

This is SCOW document, https://pkuhpc.github.io/SCOW/.
You can follow steps here https://pkuhpc.github.io/SCOW/docs/category/安装.
You can using some tools provided by browser to translate the whole pages to english .


Scroll restore before data loads in

The scroll restore happens immediately after page has been shifted to previous one, not allowing the data to load on page (and not allowing to scroll yet). It would be nice to expose some kind of method which will be used once the data has been loaded and that would trigger the scroll to correct position.
For example my shop has a list of products provided by GraphQL query. When user clicks on a product a new page loads with product details. When user swiches back to the list the products load again from graphQL and only then (graphql query onComplete) can I scroll back to correct position.

Thank you for your advice, I will find the best way to solve it.
Please look forward to it.

Thank you for your advice, I will find the best way to solve it.
Please look forward to it.


Cannot move the map on IOS

Hey, i just download the sample.
The android vers. is working as expected, but on IOS project I cannot move the map. It only gets stuck on the pre-defined position that is set on Initialize the page.
Making the scale factor lower (as on the screenshot), makes the map able to move around the screen, but again inside the "shape" it is not possible to do it - touch is not detected.

Let me know if you need some more info for reproducing the issue, and thanks for the help.

Set the InputTransparent="True" to Overlay and it should work. I just did  the same in my app.


Use RoutePatternMatcher logic in TemplateMatcher

Addresses part of #472

@jbagga,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@rynowak Updated


Node.js Version Upgrade from v16 to v18

Pull Request Description: Node.js Version Upgrade from v16 to v18
Summary: This pull request updates the Node.js version used in the v8_installer.sh from v16.20.1 to v18.17.1.
This change was made because the otnode can't start with the installed node v16.20.1. The node goes to the restart loop.
Changes:
Updated the install script to install Node.js v18 via NVM.
Modified related configurations to align with the new version.
This change ensures compatibility with modern environments while improving stability and security.
The node started with the new version successfully.

Node.js 20 will become a requirement after merging #3375


[BugFix] remove unnecessary check in statistic calculate phase

Fixes #issue

When the statistical information query results are abnormal, set the statistical information column to an unknown value to prevent the failure of dervie statistics in the planning stage.
Delete unnecessary check items, and supplement the exception information when the check fails.

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 20 / 31 (64.52%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ColumnRefOperator.java
0
3
00.00%
[113, 115, 117]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/Statistics.java
2
4
50.00%
[70, 72]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnBasicStatsCacheLoader.java
5
9
55.56%
[176, 177, 178, 179]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnStatistic.java
8
10
80.00%
[151, 152]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnDict.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ExpressionStatisticCalculator.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 25 / 31 (80.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnBasicStatsCacheLoader.java
5
9
55.56%
[176, 177, 178, 179]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnStatistic.java
8
10
80.00%
[151, 152]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ColumnDict.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/Statistics.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/ExpressionStatisticCalculator.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ColumnRefOperator.java
3
3
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


match DUMP and INFO output of apache httpd mod_cluster

The DUMP and INFO output of the undertow mod_cluster implementation contains formatting errors. This fix updates dump and info functions so that the output matches that of apache httpd mod_cluster.

Can one of the admins verify this patch?

This is ok to test

Windows Build 2211 outcome was FAILURE using a merge of 9a1f229e1164d1d473b20c81fa6d9fe250e12405
Summary: Tests passed: 2964, ignored: 613; exit code 1 Build time: 00:28:37

@stuartwdouglas JIRA issue added, commit message updated.

Windows Build 2214 outcome was FAILURE using a merge of fe1d62dc58ae8fd7d74f690bb48beee64fb86479
Summary: Tests passed: 2964, ignored: 613; exit code 1 Build time: 00:36:50


Update hausbus_de to 1.4.6

Please update my adapter ioBroker.hausbus_de to version 1.4.6.
This pull request was created by https://www.iobroker.dev c0726ff.

RE-CHECK!

RE-CHECK!

RE-CHECK!

RE-CHECK!

@mcm1957 This version was pushed to stable directly because support for a new hardware module was added. This does not affect the current logic or functionality but allows to use the new hardware. This was just about making the adapter recognize the new hardware version. So potential side effects should be under control. If needed I can inform our customers that they will have to switch to latest or wait 1-2 weeks

Fixes for checker errors available at
https://github.com/hausbus/ioBroker.hausbus_de/pull/54
https://github.com/hausbus/ioBroker.hausbus_de/pull/55
https://github.com/hausbus/ioBroker.hausbus_de/pull/56

RE-CHECK!

@mcm1957 This version was pushed to stable directly because support for a new hardware module was added. This does not affect the current logic or functionality but allows to use the new hardware. This was just about making the adapter recognize the new hardware version. So potential side effects should be under control. If needed I can inform our customers that they will have to switch to latest or wait 1-2 weeks

OK, I'll release it as an exception as the number of users is small.
But normally a new version should by available at least 7 days at latest and have at least a few installations. 1.4.6 does not have any installation recorded today.


Y axis doesn't scale when I zoom

Bug report
Explanation

What is the behavior you expect?
I expect Y axes will be scaled when I zoom a chart.
I use Zoom In icon on the chart
What is happening instead?
When I zoom Y axis doesn't scale. The chart is zoomed but the Y axis doesn't scale when Zoom In and Zoom Out.
What error message are you getting?
no error message

The code of the page where I try to zoom is very simple:
`

no answer for a long time


Remove knockout-mapping

Proposed
Remove all mentions of ko-mapping to close #2117. Replace with
koHelpers.mapJStoKO which includes an exclude option.
Repercussions
If someone is going to use knockout-mapping in their feature, this will break it.

Just a little documentation to add, and this is good to merge. :bullettrain_side:


Implement Meet Page: Display Meta Data

Display meta data including name, and transcript around the relevant videos optimized for desktop and mobile. Consider display an icon or "read more" to view the transcript text on mobile

#73


API: papplSystemCreatePrinters, PAPPL-Create-Printers IPP operation

Experience has shown that existing printer applications all have some variation of the "autoadd" sub-command built into them. Proposed API:
extern bool papplSystemCreatePrinters(pappl_system_t *system, pappl_devtype_t types, pappl_pr_create_cb_t cb, void *cb_data);

This function lists devices of the specified types and attempts to add any new devices using the current printer drivers. If not NULL, the specified callback function is called for each printer that is created.
A corresponding  IPP vendor operation ("PAPPL-Create-Printers") can also be registered with the PWG to allow the "autoadd" sub-command to request the server to create printers via the proposed API. Request attributes:
Group 1: Operation attributes:
  "attributes-charset (charset)"
  "attributes-natural-language (naturalLanguage)"
  "system-uri (uri)"
  "smi55357-device-type (1setOf keyword)"

Response attributes:
Group 1: Operation attributes:
  "attributes-charset (charset)"
  "attributes-natural-language (naturalLanguage)"

Groups 2-N: Printer attributes (one per printer created):
  "printer-name (name(127))"
  "printer-state (type1 enum)"
  "printer-state-reasons (1setOf type2 keyword)"
  "printer-xri-supported (1setOf collection)"

[master 8e0f4c1] Register and document PAPPL-Create-Printers operation (Issue #245)

[master 5b1b3e5] Implement PAPPL-Create-Printers operation (Issue #245)

[master baa108b] Refactor Create-Printers/Find-Devices code (Issue #245)

[master cae49bf] Implement papplSystemCreatePrinters API (Issue #245)


[flink] supports upgrading from versions below 0.8.0 (excluding 0.8.0) to 0.8.1+.

[flink] supports upgrading from versions below 0.8.0 (excluding 0.8.0) to 0.8.1+.

Purpose

Linked issue: close #3367

Supports flink job state compatibility when upgrading from versions below 0.8.0 to 0.8.1+.
When upgrading from 0.6/0.7 to 0.8.1+, users can configure state.compatible-for-less-than-08 to use the legacy serializer to deserialize the state.
Tests

org.apache.paimon.manifest.ManifestCommittableLegacyV2SerializerCompatibilityTest#testCompatibilityToLegacyVersion2

API and Format

No
Documentation

No

Closed as #3476  has been merged.


Bumping eks-a cli staging version

Description of changes:
Bumping eks-a cli staging version
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


graalvm8: 19.1.1 -> 19.2.1

Motivation for this change
Bumping graalvm8
Things done
I fixed fastr and truffleruby so these are now included. I was planing to make it work for darwin, but I'll have to find time later for that, next weekend or next week. I refactored the cache generation into the postUnpack phase. I guess I could refactor some of the patching from the mxgitcaches into the postPatch phase later on.

[ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ x ] NixOS
[ x ] macOS
[ ] other Linux distributions

[ x ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ x ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @volth

I'm noticing some hash mismatches as I'm trying to implement for darwin. Please wait with reviewing.

I'll have to admit my inability to get it running on darwin. I was able to get svm running, but I realized that I compiled with clang and not gcc, I asked on graalvm slack, and they re-iterated that graalvm relies on gcc. And while trying to get this running, the gcc call, which is coming from substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/c/codegen/CCompilerInvoker.java doesn't seem to take anything from the environment into account, hence these CoreFoundation patches, because it seemed, no matter how hard I tried or how much gcc manual I read, I couldn't make CoreFoundation.h discoverable (except with direct reference but then all the other headers which CoreFoundation imports will fail).
So anybody with darwin experience, please help. The current error message is
 [lli:32101]    classlist:   3,945.83 ms
[polyglot:32100]    classlist:   3,986.76 ms
[polyglot:32100]        (cap):     617.01 ms
[polyglot:32100]        setup:   1,097.46 ms
Error: Error compiling query code (in /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c). Compiler command  /nix/store/by6a964hw1pcx2mwg8782096vi7b8jw8-gcc-8.3.0/bin/gcc -F /nix/store/732051j6rg2p3zb3nr5crfqlpaib158z-apple-framework-CoreFoundation/Library/Frameworks -framework CoreFoundation /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c -o /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives output included error: /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c:78:10: fatal error: CoreFoundation/CoreFoundation.h: No such file or directory
    C file contents around line 78:
    /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c:77: #include </nix/store/701x446sv332xjff12adla3dvzpf53hk-zlib-1.2.11-dev/include/zlib.h>
    /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c:78: #include <CoreFoundation/CoreFoundation.h>
    /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-13236726821528075/PosixDirectives.c:79: #include <sys/event.h>
Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception
[lli:32101]        (cap):     646.13 ms
[lli:32101]        setup:   1,169.34 ms
Error: Error compiling query code (in /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-4470645386342471800/LibCHelperDirectives.c). Compiler command  /nix/store/by6a964hw1pcx2mwg8782096vi7b8jw8-gcc-8.3.0/bin/gcc -F /nix/store/732051j6rg2p3zb3nr5crfqlpaib158z-apple-framework-CoreFoundation/Library/Frameworks -framework CoreFoundation /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-4470645386342471800/LibCHelperDirectives.c -o /var/folders/9k/hr12t49132lgnpzq88w_h6740000gn/T/SVM-4470645386342471800/LibCHelperDirectives output included error: collect2: error: ld returned 1 exit status
Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception
Error: Image build request failed with exit status 1
Process Process-362:

@volth
The current head on my PR is in a messed state, I'll either stop trying to get it running on darwin and clean it up for linux and submit this PR that way. Or I find a way to solve it and I keep this PR open.

@volth
The current head on my PR is in a messed state, I'll either stop trying to get it running on darwin and clean it up for linux and submit this PR that way. Or I find a way to solve it and I keep this PR open.

I am happy without Darwin support, it was @regadas who wanted GraalVM on Nix/Darwin

Hi, I'm interested in getting this working on Darwin as well. I could take a look! I'm pretty new to Nix so this might take a little while. If this is a blocker for this PR, then I could do this on a separate branch.

I'm pretty close to getting this done on Darwin. Still an unrelated gcc problem in the way.

That’s nice! I actually ended up creating a custom pkg with the pre built Graal binaries (easier and kinda online with other jdk packages)

@regadas
Prebuilt binaries are here as well (https://github.com/NixOS/nixpkgs/pull/74010), and they lack Darwin support too.
It would be nice it someone add Darwin binaries (I just have no Darwin hardware to test).

I successfully got all the polyglots working with Darwin, it's quite invasive, becuase the changes to libdispatch, which is required by System framework, requires absolutely everything to be rebuilt. Also I needed to add Java frameworks which weren't implemented.
Anyway, a quick question, I'm back on linux verifying that everything still works as expected, but I'm encountering
/nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04/nix-support/setup-hook: line 1: JAVA_HOME: unbound variable

Which is strange since the setup-hook is everywhere the same for java
$ cat /nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04/nix-support/setup-hook
if [ -z "$JAVA_HOME" ]; then export JAVA_HOME=/nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04; fi

I'm super happy to see it working on darwin after 24 days of struggling.
Could you start @GrahamcOfBorg @volth ? This JAVA_HOME error is most likely some strangeness happening for me locally.

No, if you mean Darwin's @GrahamcOfBorg
My letters to ofborg start only Linux builders. This is not very
useful, because they run implicitly on every PR change :
https://github.com/NixOS/nixpkgs/pull/72331/checks?check_run_id=318228537
On 11/24/19, Hlöðver Sigurðsson<EMAIL_ADDRESS>wrote:

I successfully got all the polyglots working with Darwin, it's quite
invasive, becuase the changes to libdispatch, which is required by System
framework, requires absolutely everything to be rebuilt. Also I needed to
add Java frameworks which weren't implemented.

Anyway, a quick question, I'm back on linux verifying that everything still
works as expected, but I'm encountering

/nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04/nix-support/setup-hook:
line 1: JAVA_HOME: unbound variable

Which is strange since the setup-hook is everywhere the same for java

$ cat
/nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04/nix-support/setup-hook

if [ -z "$JAVA_HOME" ]; then export
JAVA_HOME=/nix/store/30b80ymkvhryc8kkifc93psy7mppwz3q-jvmci-19.3-b04; fi

I'm super happy to see it working on darwin after 24 days of struggling.

Could you start @GrahamcOfBorg @volth ? This JAVA_HOME error is most likely
some strangeness happening for me locally.

--

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub:

https://github.com/NixOS/nixpkgs/pull/72331#issuecomment-557908544

sorry, I always had the idea that @GrahamcOfBorg didn't try to built unless instructed to. I fixed that hash mismatch, crossing fingers.

I did screw up the linux build after working with Darwin, but I've fixed all the build errors for linux, but @GrahamcOfBorg doesn't go all the way trough.
building of '/nix/store/j5658lwxd2yjc9ip52vp9b9nqyip5ghg-graal-19.2.1.drv' timed out after 3600 seconds
error: build of '/nix/store/j5658lwxd2yjc9ip52vp9b9nqyip5ghg-graal-19.2.1.drv' failed

I thought we were mostly dealing with memory problems :)
Otherwise, if anyone has the ability to start a Darwin build on @GrahamcOfBorg, now would be a good time.

@GrahamcOfBorg build graalvm8

Thanks @d-goldin
strange thing just happened, linux timed out, not surprising. But so did Darwin too, but I guess Darwin wasn't behaving well to the stop sign ( so it's still running, and realistically, it will run for another 4-6 Hours).
building of '/nix/store/xsx87x54cshn80i7560wgzqww80y8nga-llvm-7.1.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/5379f0fgblwbi0cpigdb5sf2cd441q3l-compiler-rt-7.1.0.drv': 1 dependencies couldn't be built
[ 25%] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/Internalize.cpp.o

is this expected?

@hlolli:

strange thing just happened, linux timed out, not surprising. But so did Darwin too, but I guess Darwin wasn't behaving well to the stop sign ( so it's still running, and realistically, it will run for another 4-6 Hours).

Yeah, there is a timeout of 3600 secs configured in ofBorg. I'm not sure if there is a way to disable it.
How long does the graalvm build itself take? Here it looks like it starts building llvm and what not, which of course cuts into the time.
If the build itself is not too crazy heavy, it might help to just wait for the dependencies to appear in the binary caches. Otoh, if it times out on amd64, it's unlikely going to be faster.

ADDED: Darwin timed out as well. So I guess ofborg isn't of much use here.

Maybe there is some way to invoke that differently or some other resources one could use to test.
Let's see. Maybe @grahamc or @NixOS/darwin-maintainers can help out here.

@hlolli: Meanwhile, here is a build on NixOS: https://gist.github.com/d-goldin/39c9baf677d0b8ea15a5e9e543dfb44a

@hlolli: Meanwhile, here are the last 1000k lines of a build on NixOS/amd64: https://gist.github.com/d-goldin/39c9baf677d0b8ea15a5e9e543dfb44a

Thanks, 100k lines, WOW
exit code status 137 seems to indicate memory problems. Which is what we were used to. Where could I access these logs?

Btw it takes around 40-55 minutes to build graal8 on my gamer Lenovo Legion laptop. On my brand new MacBook, it takes even shorter, but in this PR I'm adding a patch that causes ~3 hour rebuild from scratch (gcc/llvm/clang are all recompiled), so this PR will be exceptionally long for Darwin.

@hlolli: That's from a local build. Too big for most paste services, so I dropped it here: https://github.com/d-goldin/random_stash/blob/master/pr_72331_5fbd9fbd7908289b1d72df18f5a2c735178b82be.log

The same thing happening here, exiting with 137. Since I was on the train,
I destroyed my fingers scrolling to the bottom of that page on my phone.
I wonder if there’s any precedence for adding swap file while building a
derivation?
On Tue, 26 Nov 2019 at 00:30, Dima<EMAIL_ADDRESS>wrote:

@hlolli https://github.com/hlolli: That's from a local build. Too big
for most paste services, so I dropped it here:
https://github.com/d-goldin/random_stash/blob/master/pr_72331_5fbd9fbd7908289b1d72df18f5a2c735178b82be.log
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/72331?email_source=notifications&email_token=ABOLDATOG6EIDXJGV5G5OULQVRNXXA5CNFSM4JHA66U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEFKHI#issuecomment-558388509,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOLDAVNBATU26JAEQZPUN3QVRNXXANCNFSM4JHA66UQ
.

@volth is this merge-able? Is there something I need to do?

@volth is this merge-able? Is there something I need to do?

Maybe 19.3.0 ?
Which is LTS and has Java 11, so it could stay for few months

I'll start working on 19.3.0, but that shouldn't prevent this PR from being merged? Can't this be merged?

I can be merged, but since this is a mass-rebuild on macOS, we need this to go through staging. Can you rebase your pull request onto the staging branch?

It can be merged, but since this is a mass-rebuild on macOS, we need this to go through staging. Can you rebase your pull request onto the staging branch?

done

We're ready to merge this to staging, yeah?  Somebody want to hit the button?


continue training model in transformers (after LoRA training)

System Info
huggingface. transformers, peft, accelerate
Who can help?
@BenjaminBossan
@younesbelkada
@sgugger
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
Expected behavior
Hi, could someone please help me?
I have trained an LLM model of Llama3 using the AutoModelForSequenceClassification class. Before training I used LoraConfig and get_peft_model. Now I have saved the checkpoint and want to continue my training. I loaded the model from the checkpoint as follows:
model = PeftModel.from_pretrained(base_model, path_to_checkpoint, is_trainable=True)
I then set the same Training arguments and Trainer and did
trainer.train(resume_from_checkpoint="path_to_checkpoint")
After this code I get error:
object of type method has no len()
My packages:
transformers==4.41.2
Peft==0.4.0
Do you think it could be because I'm using an older version of the Peft package? I can't install a newer version at the moment due to a system error in the company.
Thank you.
.

Thanks for reporting the error. Please don't ping Sylvain or Younes, who are not at Hugging Face anymore.
Regarding the error, I tried to reproduce it. When I use peft==0.4.0 and transformers==4.41.2, I get an import error

ImportError: cannot import name 'PeftMixedModel' from 'peft' (/home/vinh/work/forks/peft/src/peft/init.py)

I'm not sure how this can work for you but the PEFT version is far too old for the given transformers version.
Switching back to the latest versions of PEFT and transformers, I could successfully resume training from a checkpoint. Here is the script:
import torch
from datasets import load_dataset
from peft import LoraConfig, get_peft_model, PeftModel, TaskType
from transformers import AutoModelForCausalLM, AutoTokenizer, Trainer, TrainingArguments, DataCollatorForLanguageModeling

tmp_dir = "/tmp/peft/1913"
model_id = "facebook/opt-125m"
model = AutoModelForCausalLM.from_pretrained(model_id, device_map=0)
tokenizer = AutoTokenizer.from_pretrained(model_id)

config = LoraConfig(
    r=16,
    lora_alpha=32,
    target_modules=["q_proj", "v_proj"],
    lora_dropout=0.05,
    bias="none",
    task_type="CAUSAL_LM",
)

model = get_peft_model(model, config)

data = load_dataset("ybelkada/english_quotes_copy")
data = data.map(lambda samples: tokenizer(samples["quote"]), batched=True)

def get_trainer(model):
    trainer = Trainer(
        model=model,
        train_dataset=data["train"],
        args=TrainingArguments(
            per_device_train_batch_size=4,
            gradient_accumulation_steps=4,
            warmup_steps=2,
            max_steps=3,
            learning_rate=2e-4,
            fp16=True,
            logging_steps=1,
            output_dir=tmp_dir,
        ),
        data_collator=DataCollatorForLanguageModeling(tokenizer, mlm=False),
    )
    return trainer

trainer = get_trainer(model)
trainer.train()
del trainer, model

model = AutoModelForCausalLM.from_pretrained(model_id, device_map=0)
checkpoint_path = tmp_dir + "/checkpoint-3"  # adjust
model = PeftModel.from_pretrained(model, checkpoint_path, is_trainable=True)
trainer = get_trainer(model)
print("resuming training from checkpoint")
trainer.train(resume_from_checkpoint=checkpoint_path)

Maybe you could try if it works for. If you still get the same error as reported above, there is probably no solution other than trying to upgrade the versions. You could paste the full error message and perhaps I can spot something, but it's unlikely.

I'm sorry, I didn't know Sylvain or Younes were no longer Huggingface.
Thanks for the help, I finally got to a newer version of the peft package and the code works for me.


Fix Typos In Docs & Code Comments

There are several typos in files within the ./examples/* directory, so just a PR to fix them

Hi michaelg100 , Thanks for Contributing.
LGTM for Python Changes


write the 'after getting started Wiki page'

I started this, and will continue with later
https://github.com/JATOS/JATOS/wiki/Write-and-run-your-own-studies

Can you please review this?
https://github.com/JATOS/JATOS/wiki/After-Getting-Started

Have you had experience with Kahn website? Is it really good?
I changed:
The most difficult part -though it's still easy!- (removed comma)
of very useful functions that you have to use to communicate with jatos
If you are a newbie to HTML/JavaScript programming
Once you have collected all your data, export it on to text files. If you
used the JSON format (which is handy - but any other text is fine too) you
can analyse your data using this nice
On Fri, Jun 19, 2015 at 5:50 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Can you please review this?
https://github.com/JATOS/JATOS/wiki/After-Getting-Started
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113554367.

I don't have experience but I think it is good.
On So., Juni 21, 2015 at 8:03 nachm., JATOS/JATOS
<EMAIL_ADDRESS>wrote:
Have you had experience with Kahn website? Is it really good?
I changed:
The most difficult part -though it's still easy!- (removed comma)
of very useful functions that you have to use to communicate with jatos
If you are a newbie to HTML/JavaScript programming
Once you have collected all your data, export it on to text files. If you
used the JSON format (which is handy - but any other text is fine too) you
can analyse your data using this nice
On Fri, Jun 19, 2015 at 5:50 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Can you please review this?
https://github.com/JATOS/JATOS/wiki/After-Getting-Started
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113554367.

—
Reply to this email directly or view it on GitHub
[https://github.com/JATOS/JATOS/issues/98#issuecomment-113935996] .[https://github.com/notifications/beacon/AIQMe_EMYsRv-W9cNIfLra4kiKoKbmR0ks5oVvPggaJpZM4FFMQl.gif]

And my changes ... you agree?
On Sun, Jun 21, 2015 at 8:09 PM, elisafilevich<EMAIL_ADDRESS>wrote:

I don't have experience but I think it is good.
On So., Juni 21, 2015 at 8:03 nachm., JATOS/JATOS
<EMAIL_ADDRESS>wrote:
Have you had experience with Kahn website? Is it really good?
I changed:
The most difficult part -though it's still easy!- (removed comma)
of very useful functions that you have to use to communicate with jatos
If you are a newbie to HTML/JavaScript programming
Once you have collected all your data, export it on to text files. If you
used the JSON format (which is handy - but any other text is fine too) you
can analyse your data using this nice
On Fri, Jun 19, 2015 at 5:50 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Can you please review this?
https://github.com/JATOS/JATOS/wiki/After-Getting-Started
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113554367.

—
Reply to this email directly or view it on GitHub
[https://github.com/JATOS/JATOS/issues/98#issuecomment-113935996] .[
https://github.com/notifications/beacon/AIQMe_EMYsRv-W9cNIfLra4kiKoKbmR0ks5oVvPggaJpZM4FFMQl.gif]
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113937355.

yes
On So., Juni 21, 2015 at 8:33 nachm., JATOS/JATOS
<EMAIL_ADDRESS>wrote:
And my changes ... you agree?
On Sun, Jun 21, 2015 at 8:09 PM, elisafilevich<EMAIL_ADDRESS>wrote:

I don't have experience but I think it is good.
On So., Juni 21, 2015 at 8:03 nachm., JATOS/JATOS
<EMAIL_ADDRESS>wrote:
Have you had experience with Kahn website? Is it really good?
I changed:
The most difficult part -though it's still easy!- (removed comma)
of very useful functions that you have to use to communicate with jatos
If you are a newbie to HTML/JavaScript programming
Once you have collected all your data, export it on to text files. If you
used the JSON format (which is handy - but any other text is fine too) you
can analyse your data using this nice
On Fri, Jun 19, 2015 at 5:50 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Can you please review this?
https://github.com/JATOS/JATOS/wiki/After-Getting-Started
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113554367.

—
Reply to this email directly or view it on GitHub
[https://github.com/JATOS/JATOS/issues/98#issuecomment-113935996] .[

https://github.com/notifications/beacon/AIQMe_EMYsRv-W9cNIfLra4kiKoKbmR0ks5oVvPggaJpZM4FFMQl.gif]

—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/98#issuecomment-113937355.

—
Reply to this email directly or view it on GitHub
[https://github.com/JATOS/JATOS/issues/98#issuecomment-113938439] .[https://github.com/notifications/beacon/AIQMe2WG-GO_R3-YKAiNtBViXMnIR1hJks5oVvrtgaJpZM4FFMQl.gif]


Add location addresses data from India

Hey. Can you assign me this issue?

Hey, sure no problem assigned :)
Please also give a star to the project to make it more popular :fire:

how is it going?

Hi,
If this issue is available, could you assign it to me?
Thanks!

Hello, it is, assigned


Improve polarity marking of CHIPLED packages

Every time I assemble some CHIPLEDs, I'm confused about the polarity. Especially because the bar on the bottom, which looks like a cathode bar, is actually on the anode side. And then I'm not sure whether the dot on the top marks the cathode or the anode.
Thus I improved the polarity marking of the CHIPLED 0603 and 0805 packages:

Adding a hole to the pad polygon on the documentation layer (corresponds to the cathode dot in the datasheet).
Adding the bar on the bottom side of the package to the documentation layer, so we can see that the bar is on the anode side.
Since the above changes are not visible on the silkscreen, I also added a dot to the placement layer, so after assembling you can verify that the dot on the package is on the same side as the dot on the silkscreen. To save space, I shortened the outline polygon and added the dot in between, I'm not sure if that's a good idea ;) What do you think @dbrgn?

Datasheet drawing:

I like the new look :slightly_smiling_face: Didn't verify the footprint in LibrePCB, I trust your screenshot.
The "cathode mark" on the anode side is very confusing indeed...


P1 Assignment Checklist

A checklist of all our P1 assignment grading specs.

[x] Landing Page (this could be the main search page or sign-up/log-in page) [2 marks]

[x] User should not be logged in on this page

[x] Login Page [4 marks]

[x] Initial view
[x] Same page with error message, e.g., invalid username and password combination.

[x] Signup Page (one for pet seeker and another for pet shelter) [8 marks]

[x] Initial View
[x] Same page with error messages, e.g., invalid email address.
[x] You can design this page so that one page handles signup for both pet seeker and pet shelter.

[x] Search Page [12 marks]

[x] Initial view
[x] With a filter turned on
[x] With a sort option turned on

[x] Pet Detail Page [8 marks]

[x] Should have link to pet adoption page if available
[x] Should have some error message for pets in other states, i.e., pending, adopted, withdrawn.
-> Pet 2 leads to pet-details-pending.

[x] Pet Adoption Page [8 marks]

[x] Should display the application form (unfilled).
[x] Should not be possible if user already has an application for the same pet. Can show an error page. Better yet, the pet detail page disable the link to this page.

[x] Application Page [8 marks]

[x] Shows the current pet adoption application information (filled, and cannot be changed)
[x] Can show the conversation between pet shelter and user, or it can go to a separate page.

[x] Pet Creation Page [8 marks]
[x] Pet Update Page [2 marks]

[x] This should probably look fairly similar to the pet creation page.

[x] Shelter Detail Page [8 marks]

[x] Shelter reviews can go here or in a separate page.

[x] Shelter Management Page [8 marks] (My Pets in the header, pet-management.html

[x] Easy to use interface to manage their pet listings

[x] Account Update Page [10 marks]

[x] One for regular users and another for pet shelter

[x] Notifications [4 marks]

[x] Have at least one page (of your choice) show what happens when there is notification, and what happens when you click on the notification icon. It should either take you to a notification page or show a drop down of notifications

Checklist complete, will close this issue once migration to MarkUs is complete.


[DNM] Upgrade Fluent Bit to a remote branch with hotfixes

Testing cherrypick. DNM.

Fluent-bit submodule now is updated to 2.2.1 release (see https://github.com/GoogleCloudPlatform/ops-agent/pull/1559). No need for this PR anymore.


docs: update vitepress

Description
This PR updates VitePress to the latest version. With this release, VitePress contains a huge refinement on styles.
Vite docs are mostly unaffected, but I've deleted no longer required .dark scoped CSS variables, and made button white text to be pure white for better readability.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Thanks! I noticed a minor change that seems unintentional.

Is this bottom border intended to be non-transparent even if the page isn't scrolled? The header itself is transparent when the page isn't scrolled.

The scrollbar on the sidebar looks a bit strange.
This PR

The previous version

@sapphi-red

The scrollbar on the sidebar looks a bit strange.

Thanks for catching this! This is happening because I've changed how header is structured, and now the header title section has BG color and probably hiding the sidebar underneath.
I think I can fix this. I'll update VitePress with this fix and update this PR.

@patak-dev

I wonder if the black border could also be transparent instead of solid when you are at the top.

The border was intended, but now I'm rethinking it 🤔
When I did this, I though especially in dark mode, this black "gutter" like border has cool sharp looking, like it got paper cut kinda, with consistency of following sections have the same border.
However, now that I think of, yea it would probably be cleaner, and when user scrolls, then that's the time they see further section and gets the "consistency" I was talking about.
So, I'll update VitePress to adjust this as well and update this PR 🔥

@patak-dev @sapphi-red Fixed both of the issue and updated the VitePress. It should be fixed. Can you guys please check it again 🙏

Thanks! It looks really nice. ✨
It seems there's two places with a transparent 1px line (at the bottom part of the header, and on the left of the vite logo). You can see the line by scrolling down and then hovering on the stackblitz sponsor panel.

Ah, damn, thank for the check! It happens on specific viewport 😅 I'll fix it!

OK, I think it's fixed 👀


Skip Chromatic in Dependabot PRs

What are you changing?

Adds a separate job to the CI workflow to run Chromatic against Dependabot PRs with the skip flag enabled.
Resolves #570

Why?

To cut down on the number of Chromatic snapshots we don't want to run Chromatic against Dependabot PRs as they tend to hang around for a while before being merged and get rebased multiple causing unnecessary runs. As the UI tests are a required merge check we run Chromatic with the skip flag which marks these as passing and does not prevent merging of the PR.

This is great James! I wondered if rather than repeating all the code we could just do something like:
skip: github.actor == 'dependabot[bot]'

would that work?

Ooo, I hadn't thought of that. That would be a lot simpler! 😅 I'll give it a go…

Thanks! I've no idea if that actually would work but maybe something similar either way


Add GRPC to packages

I had to add "grpc": "0.13.0" to the dependencies in packages.json for it to work out of the box

Was that needed to run it locally or for deploying to bluemix?
What does your environment look like?

@pdulong "grpc" is a dependency of "hfc" (client sdk) package, as reported here, so it should be included already in your environment. How did you notice its missing? Can you please post a log from your terminal after a fresh "npm install"?


Disable search in text editor

Description
Prevent the custom javascript search when editing a file from the UI, and use the native browser search.
If this have to disable everything they add to their custom textarea (soft line wrap, line numbers, etc), so be it. Then we could just call "use native textarea for file edit" instead of "disable custom search".
I rarely edit files on the github UI, but when I do I immediately regret it as soon as I press Ctrl+F. It is awful in every aspect.
Screenshot
No response
Example URLs
https://github.com/org/repo/edit/main/file

That isn't possible because CodeMirror (the editor you see) doesn't render the entire file on screen. The lines that are not visible, are not part of the dom at all, so the browser cannot find it.
You have two solutions:

break CodeMirror so it leaves a raw textarea (not very practical)
use GhostText: https://ghosttext.fregante.com

Other than this, Refined GitHub unfortunately can't do anything about it, as much as I also don't like the custom search.

Thanks for the background on this! much appreciated.
would blocking codeMirror be a feature here?

Thanks for the background on this! much appreciated.
would blocking codeMirror be a feature here? ~I tried to block it via my adblocker, but there's no individual network request i can use to block it :(~ Here is the "fix" via uBlock origin: ||*/assets/editor-$script,domain=github.com (just update the domain at the end for corporate urls)
...Will try ghosttext and report back, but i'm almost sure it will not help until we get the raw text area to begin with.... Update: correct, it won't work until after you blocked the editor script. After you blocked, it is the best.

At the moment the rule https://github.githubassets.com/assets/react-code-view-*.js seems to work


fix(ngRepeat): Check own object property

Care to explain why?

I signed it.

@Narretz sure, without the check the loop will iterate over every property in the object's prototype chain. It appears a CI test is failing though, I'll have to look into it!

Looks like our unit tests don't like this change at all ... ;)
lastBlockMap is actually created as Object.create(null), doesn't that mean it has no prototype at all? The code comments say exactly that it safeguards against prototypically inherited properties.
If you could give a clear use case example where this problem happens for you, that would be great.

Ah yes an Object.create(null) instantiation would negate the need for this. It's not an issue I've faced in general - from what I understand if Objects accumulate a nested hierarchy of prototypal properties, searching down the prototype chain would negatively affect performance. Doesn't seem to be an issue here, though. I'll close this out - thanks for taking a look!


CLOUDP-220794: add required instance flag to help usage in connection list

Proposed changes
CLOUDP-220794
The --instance flag is required for the connections streams commands so its desirable to display it in the usage docs when accessing -h for a command. This PR updates the Use to add that in.
Checklist
[✅ ] Ran make gen-docs

Thanks for your input @gssbzn, after discussing with the team I'm going to close this since it breaks the cli help usage guidelines.


Auto import suggestions heavily slows intellisense

TypeScript Version:  3.6.0-dev.20190628
Search Terms: auto import auto import performance
Code
Enter this into a blank TypeScript project in VSCode:
import {S3} from 'aws-sdk'

const a: s

Expected behavior:
Intellisense suggestions to pop up in under 500ms.
Actual behavior:
2+ seconds for the suggestions to appear.
After banging my head for a few hours trying to get to the bottom of intellisense slowness(next, insiders, old versions, etc, etc) I narrowed this down to auto import suggestions; disabling this feature removes the delay. I believe tsserver provides this service to VSCode? The aws-sdk does have a huge type surface area..

Same issue here. Using aws-sdk only in a few files but it slows down whole project

It's not clear what to do here - people looove auto-import, but clearly there are too many things in aws-sdk to performantly offer. It'd be a bummer if the feature just "turned off" when a complex library was around, but there's no obvious culling strategy for reducing the number of things in the list when there are too many.

I haven't had the chance to dive into this(I have never looked at the code in this project so I'm pretty much procrastinating) but I had hoped it was just an algorithm choice or caching issue.. But isn't everything? 😄
For my part I usually care more about auto-import suggestions for my own code. Having that option may be a nice stop-gap for people who don't want to completely disable it.
Outside of that perhaps fuzzy-ish search through all the available types could be disabled? And/or a prefix index? I'm just spit-balling here as I have no clue as to why it should be so dang slow. Really I suppose I or somebody else would need to hook up the profiler and figure out where the time is(could be VSCode).

Databases can search through millions of items in no times. A lot of exports from any library should not be a problem with the correct data structure and algorithm.
If you want to provide suggestions while typing it sounds like the classbook example of a problem solved by a radix index/tree.

I filed a suggestion for VS Code to show some suggestions whilst waiting for auto import suggestions, so that other suggestions are not slowed down by auto import suggestions: https://github.com/microsoft/vscode/issues/138449. Unfortunately the issue was closed, but if there's no way to improve performance on TypeScript's side then I think this issue should be re-opened. It would be great if other people could chime in on that issue.
For now, I've had to disable auto import suggestions entirely because they are so slow.


rewrite masking function to be tail-recursive and use binary matches

closes #16
saw these results with benchee:
Operating System: Linux
CPU Information: Intel(R) Core(TM) i7-9700KF CPU @ 3.60GHz
Number of Available Cores: 8
Available memory: 31.30 GB
Elixir 1.12.1
Erlang 24.0

Benchmark suite executing with the following configuration:
warmup: 2 s
time: 10 s
memory time: 2 s
parallel: 1
inputs: none specified
Estimated total run time: 28 s

Benchmarking match...
Benchmarking stream...

Name             ips        average  deviation         median         99th %
match        10.11 K       98.91 μs    ±19.70%       96.12 μs      203.03 μs
stream        1.95 K      511.57 μs     ±5.05%      505.31 μs      623.51 μs

Comparison:
match        10.11 K
stream        1.95 K - 5.17x slower +412.66 μs

Memory usage statistics:

Name      Memory usage
match          0.38 MB
stream         2.06 MB - 5.39x memory usage +1.68 MB

**All measurements for memory usage were the same**

the bench file
Mix.install([:benchee])

defmodule Foo do
  def stream_mask(payload, <<a, b, c, d>>) do
    [a, b, c, d]
    |> Stream.cycle()
    |> Enum.reduce_while({payload, _acc = <<>>}, fn
      _mask_key, {<<>>, acc} ->
        {:halt, acc}

      mask_key, {<<part_key::integer, payload_rest::binary>>, acc} ->
        {:cont, {payload_rest, <<acc::binary, Bitwise.bxor(mask_key, part_key)::integer>>}}
    end)
  end

  def match_mask(payload, mask, acc \\ <<>>)

  def match_mask(payload, nil, _acc), do: payload

  # n=4 is the happy path
  # n=3..1 catches cases where the remaining byte_size/1 of the payload is shorter
  # than the mask
  for n <- 4..1 do
    def match_mask(
          <<part_key::integer-size(8)-unit(unquote(n)), payload_rest::binary>>,
          <<mask_key::integer-size(8)-unit(unquote(n)), _::binary>> = mask,
          acc
        ) do
      match_mask(
        payload_rest,
        mask,
        <<acc::binary, Bitwise.bxor(mask_key, part_key)::integer-size(8)-unit(unquote(n))>>
      )
    end
  end

  def match_mask(<<>>, _mask, acc), do: acc
end

payload = :crypto.strong_rand_bytes(10_000)
mask = :crypto.strong_rand_bytes(4)

Benchee.run(
  %{
    "stream" => fn -> Foo.stream_mask(payload, mask) end,
    "match" => fn -> Foo.match_mask(payload, mask) end
  },
  time: 10,
  memory_time: 2
)

woof that was a lot of memory consumption beforehand!

what's this masking function?
When the client sends frames to the server, it masks them using 4 random bytes. The operation is that you take each byte of the mask and XOR it with a byte of the payload. When you reach the end of the mask bytes, you repeat the mask. When you reach the end of the payload, you're done! I don't quite remember why we do this (cache busting, some outdated idea of a security mechanism, etc.), but we do this often, so might as well make it efficient.

:boom: compiling inline makes it even better dang
bench file
Mix.install([:benchee])

defmodule Foo do
  def stream_mask(payload, <<a, b, c, d>>) do
    [a, b, c, d]
    |> Stream.cycle()
    |> Enum.reduce_while({payload, _acc = <<>>}, fn
      _mask_key, {<<>>, acc} ->
        {:halt, acc}

      mask_key, {<<part_key::integer, payload_rest::binary>>, acc} ->
        {:cont, {payload_rest, <<acc::binary, Bitwise.bxor(mask_key, part_key)::integer>>}}
    end)
  end

  def match_mask(payload, mask, acc \\ <<>>)

  def match_mask(payload, nil, _acc), do: payload

  # n=4 is the happy path
  # n=3..1 catches cases where the remaining byte_size/1 of the payload is shorter
  # than the mask
  for n <- 4..1 do
    def match_mask(
          <<part_key::integer-size(8)-unit(unquote(n)), payload_rest::binary>>,
          <<mask_key::integer-size(8)-unit(unquote(n)), _::binary>> = mask,
          acc
        ) do
      match_mask(
        payload_rest,
        mask,
        <<acc::binary, Bitwise.bxor(mask_key, part_key)::integer-size(8)-unit(unquote(n))>>
      )
    end
  end

  def match_mask(<<>>, _mask, acc), do: acc

  @compile {:inline, compile_mask: 2, compile_mask: 3}
  def compile_mask(payload, mask, acc \\ <<>>)

  def compile_mask(payload, nil, _acc), do: payload

  # n=4 is the happy path
  # n=3..1 catches cases where the remaining byte_size/1 of the payload is shorter
  # than the mask
  for n <- 4..1 do
    def compile_mask(
          <<part_key::integer-size(8)-unit(unquote(n)), payload_rest::binary>>,
          <<mask_key::integer-size(8)-unit(unquote(n)), _::binary>> = mask,
          acc
        ) do
      compile_mask(
        payload_rest,
        mask,
        <<acc::binary, Bitwise.bxor(mask_key, part_key)::integer-size(8)-unit(unquote(n))>>
      )
    end
  end

  def compile_mask(<<>>, _mask, acc), do: acc
end

payload = :crypto.strong_rand_bytes(10_000)
mask = :crypto.strong_rand_bytes(4)

Benchee.run(
  %{
    "stream" => fn payload -> Foo.stream_mask(payload, mask) end,
    "match" => fn payload -> Foo.match_mask(payload, mask) end,
    "compile" => fn payload -> Foo.compile_mask(payload, mask) end
  },
  time: 10,
  memory_time: 2,
  inputs: %{
    "Small" => :crypto.strong_rand_bytes(100),
    "Medium" => :crypto.strong_rand_bytes(10_000),
    "Large" => :crypto.strong_rand_bytes(1_000_000)
  }
)

and the results:
Operating System: Linux
CPU Information: Intel(R) Core(TM) i7-9700KF CPU @ 3.60GHz
Number of Available Cores: 8
Available memory: 31.30 GB
Elixir 1.12.1
Erlang 24.0

Benchmark suite executing with the following configuration:
warmup: 2 s
time: 10 s
memory time: 2 s
parallel: 1
inputs: Large, Medium, Small
Estimated total run time: 2.10 min

Benchmarking compile with input Large...
Benchmarking compile with input Medium...
Benchmarking compile with input Small...
Benchmarking match with input Large...
Benchmarking match with input Medium...
Benchmarking match with input Small...
Benchmarking stream with input Large...
Benchmarking stream with input Medium...
Benchmarking stream with input Small...

##### With input Large #####
Name              ips        average  deviation         median         99th %
compile        102.28        9.78 ms     ±3.34%        9.76 ms       10.69 ms
match           75.66       13.22 ms     ±3.79%       13.19 ms       14.41 ms
stream          14.29       69.99 ms     ±3.87%       69.99 ms       76.22 ms

Comparison:
compile        102.28
match           75.66 - 1.35x slower +3.44 ms
stream          14.29 - 7.16x slower +60.21 ms

Memory usage statistics:

Name       Memory usage
compile        23.84 MB
match          38.15 MB - 1.60x memory usage +14.31 MB
stream        206.00 MB - 8.64x memory usage +182.15 MB

**All measurements for memory usage were the same**

##### With input Medium #####
Name              ips        average  deviation         median         99th %
compile        5.49 K      182.31 μs    ±34.67%      186.93 μs      330.78 μs
match          3.85 K      259.92 μs    ±25.36%      250.79 μs      405.32 μs
stream         0.85 K     1179.86 μs    ±28.18%     1170.20 μs     1905.72 μs

Comparison:
compile        5.49 K
match          3.85 K - 1.43x slower +77.61 μs
stream         0.85 K - 6.47x slower +997.55 μs

Memory usage statistics:

Name       Memory usage
compile       245.31 KB
match         391.83 KB - 1.60x memory usage +146.52 KB
stream       2111.56 KB - 8.61x memory usage +1866.25 KB

**All measurements for memory usage were the same**

##### With input Small #####
Name              ips        average  deviation         median         99th %
compile      211.05 K        4.74 μs  ±2293.28%        1.51 μs        3.45 μs
match        162.84 K        6.14 μs  ±1770.60%        1.90 μs        4.65 μs
stream        47.81 K       20.92 μs   ±512.20%        6.76 μs      461.43 μs

Comparison:
compile      211.05 K
match        162.84 K - 1.30x slower +1.40 μs
stream        47.81 K - 4.41x slower +16.18 μs

Memory usage statistics:

Name       Memory usage
compile         3.61 KB
match           5.11 KB - 1.42x memory usage +1.50 KB
stream         23.28 KB - 6.45x memory usage +19.67 KB

**All measurements for memory usage were the same**

looks like gun does this in just about the same way but without the metaprogramming: https://github.com/ninenines/cowlib/blob/0f5c2f8922c89c58f51696cce690245cbdc5f327/src/cow_ws.erl#L526-L542
mask(<<>>, _, Unmasked) ->
	Unmasked;
mask(<< O:32, Rest/bits >>, MaskKey, Acc) ->
	T = O bxor MaskKey,
	mask(Rest, MaskKey, << Acc/binary, T:32 >>);
mask(<< O:24 >>, MaskKey, Acc) ->
	<< MaskKey2:24, _:8 >> = << MaskKey:32 >>,
	T = O bxor MaskKey2,
	<< Acc/binary, T:24 >>;
mask(<< O:16 >>, MaskKey, Acc) ->
	<< MaskKey2:16, _:16 >> = << MaskKey:32 >>,
	T = O bxor MaskKey2,
	<< Acc/binary, T:16 >>;
mask(<< O:8 >>, MaskKey, Acc) ->
	<< MaskKey2:8, _:24 >> = << MaskKey:32 >>,
	T = O bxor MaskKey2,
	<< Acc/binary, T:8 >>.


fix(codebases): Updated to reflect latest mockups

Added open workspace button.
Modified kebab options to create a workspace.
Added default workspace selection to menu using the new last_used_workspace property from /api/spaces/x/codebases API.
Added create workspace link when no workspaces are available.
Added busy indicator when workspace is created and/or opened.
Added info icon and tooltip in workspaces column header.
Added timer to poll for new workspaces in order to set the workspace selection menu.

First timer interval is 3 sec, then every 30 sec for 5 min or a new workspace is found.
Reviewed with @catrobson

@dlabrecq snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1126-fabric8-ui.int.rdu2c.fabric8.io

[test]

@dlabrecq - when I hover on the info tip, the first row is highlighting:

Otherwise things look really good!

Thanks. I'll look at the row highlight separately.


update code of conduct polish version

I updated the Polish version od code of conduct, where I provided fixes of grammar and changed the translations to make it more natural in Polish.

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

ernest-rudnicki:code-of-conduct-update-pl


[Wallet] Update help link in CICO flow

Description
Follow up on #5757 to change the link displayed in the "Add Funds" and "Cash Out" info dialog.
It's now https://valoraapp.com/support (not yet live though).
Tested

Related issues

Part of #5424

Backwards compatibility
Yes

Hi @tarikbellamine Verified task on latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5<PHONE_NUMBER>) by using following scenarios
Scenarios:
Add Funds

Verify user is able to see "Select a digital currency (i)" on add funds page Pass
Verify "Funding valora" popup should open along with "Valoraapp.com/support" Deeplink button Pass
Verify user is able to see OK button on Funding valora popup Pass
Verify popup get closed when user tap on OK button Pass

Cash Out:

Verify user is able to see "Select a digital currency (i)" on Cash out page  Pass
Verify "Withdraw from valora" popup should open along with "Valoraapp.com/support" Deeplink button Pass
Verify user is able to see OK button on Withdraw from valora popup Pass
Verify popup get closed when user tap on OK button Pass

Please let me know if i need to verify thing else?


Integrate zipping library

How lucky, zippuccino is there :)

For this, the resolution of #1 is required


Edge wraps around.

CodeSandbox: https://codesandbox.io/s/objective-bush-m81ne?file=/src/index.js
When blurred, the leftmost part of the image shows color from the rightmost part.

CodeSandbox: https://codesandbox.io/s/objective-bush-m81ne?file=/src/index.js
When blurred, the leftmost part of the image shows color from the rightmost part.

This has nothing to do with this algorithm, but rather how the underlying Graphics API samples the texture.
In the OpenGL or WebGL, set the texture or the framebuffer texture to GL_CLAMP_TO_EDGE instead of GL_REPEAT and the the wrapping is fixed.


How to calculate in the pgp file the camera matrix P?

Hi:
The paper calculates image projection matrix  P = KR[I| - C]
not understand what meaning K, R[I| -C],  How to get this several values

The projection matrix is described for example here https://en.wikipedia.org/wiki/Camera_resectioning
You can either construct it from known values or calibrate it with opencv for example.


doom-homage themes break consult-theme preview

Theme(s)
doom-homage-black, doom-homage-white
What were you expecting?
The Consult package has a command called consult-theme that allows you to scroll through themes, previewing them as you do so. Scrolling through doom-themes loads each theme in turn as you scroll through them. Hitting return exits the preview leaving the last theme loaded in effect.
What actually happened?
When scrolling through themes using consult-theme, the doom-homage-black-theme and doom-homage-white-theme break the preview, and it gets stuck on that theme. And at least occasionally seems to break the ability to switch themes altogether, even by using other commands to do so.
This happens at least when visiting an org-mode buffer during the preview, not sure about others.
No error messages, but some of this from Messages might be related:
QuitWarning: setting attribute ‘:background’ of face ‘outline-1’: nil value is invalid, use ‘unspecified’ instead.
Error in post-command-hook (consult--preview-post-command-hook): (error "Invalid face box" :line-width -1 :color "#5B6268" :style 'released-button)
face-spec-set-2: Invalid face box: :line-width, -1, :color, "#5B6268", :style, 'released-button

I do not know if this is a Consult bug or a doom-themes bug, also reporting to Consult
Steps to reproduce

Open an org-mode buffer
M-X consult-theme
scroll down to doom-homage-white or doom-homage-black
try to scroll to the next theme

Operating system
macOS
Emacs version
GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.0.0, NS appkit-2487.00 Version 14.0 (Build 23A344)) of 2024-02-17
Installed commit of doom-themes
version: 2.3.0 ff26f26

Don’t mind me, I’m just putting the root cause asap for faster triage
1
https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html

The value of style specifies whether to draw a 3D box. If it is released-button, the box looks like a 3D button that is not being pressed. If it is pressed-button, the box looks like a 3D button that is being pressed. If it is nil, flat-button or omitted, a plain 2D box is used.

2
Emacs started errorring on invalid style values (in 30 preview I guess?? see https://github.com/agraul/doom-alabaster-theme/pull/1)
3
Double quoting in org-thing


Update a page design in presentationRequest protocole

In presentationRequest process when the VC does not exist.
Improve the design of the page displayed (see Hugo)

Not a priority !


Newsletter Timeline: Drop Date 11/22/16

10/21 - Open Call for Topics to Community (Tweet on 10/21, Google Group 10/21, DevCall 10/25)
10/25 - Last Call for idea submissions
10/27 - Close Call for Topics
10/27 - Ana to begin initial draft + find headliner image (request design help if needed)
11/5 - Ana to finish draft
11/7 - Send email requesting feedback to Medium editors (BG, CW, FP, JW, MB)
11/9 - Send email reminder to editors - last chance to respond on 11/14
11/14 - Close feedback process for editors, prepare for final draft
11/16 - Planned Publish date on Medium - Delayed
11/22 - Publish date

I want to flag that feedback week for editors (11/7 to 11/11) will be the week of the Fall Developers Meeting. This will be challenging. However, I do not want to push this one week as that would push publishing into the week of Thanksgiving which would be even more challenging. Let me know if you have any concerns or other ideas.

Could we submit something perhaps only tangentially related to Jupyter, but is more about general interesting things in computing or development more broadly. The idea would be to have a way to grab the attention of people who would be interested in Jupyter but not in reading about Jupyter to still know what the newsletter is. Something that is more in the style of the Atlantic or a New Yorker article.
I'm willing to help and edit such a feature section if people are interested in this proposal and no one else wants to.

@michaelpacer Did you have a particular topic in mind? I could see this being a strategy now or in the future to pull in readers.

Michael - can I ask you to move this discussion to a new issue? I do think this is an interesting idea, are you thinking something along the lines of - this week in Data Science, or Open Source Happenings? That sort of thing? I think the challenge with this new section is similar to the challenge for any of the existing sections. Gathering and creating the content. If you're willing to help with that part I'm happy to further discuss!

This drop date was delayed to November 22. Lack of content was the core issue. I will send a draft out to the editors now and will look to get things back on track for December. I'll close out the issue tomorrow if/when I am able to successfully send this out.

@willingc @ellisonbg @fperez @JamiesHQ  - the final draft is available in Medium. Please remember to click "Close" and "Save for later" on the bottom right after making your edits. Note I will update with our Tuesday DevMeeting if we have one tomorrow.

@Ruv7 Would you mind posting the link? I've tried all 3 medium accounts that I have and I can't find the draft :( Thanks!

Medium changed their interface. Does this take you there? https://medium.com/jupyter-newsletter/letters If not then hover over your photo and then click publications. Select view/manage publication to the right of the Jupyter Newsletter. Once you do this the Jupyter Newsletter icon should show up next to your own photo at the top of the interface. Hover over that and select "Letters". Call me if that doesn't work! Its hard to describe all these steps :-b

The link did the trick @Ruv7. Weird that it didn't appear before. Oh well.

@Ruv7 Edits completed. Some minor punctuation and grammar tense changes. Added one sentence re: Grace Hopper and Reese.

Oh yeah! Love that. Thanks for thinking of this and for the quick response.

Just sent this out. Btw, @willingc - I logged in from a different device today and wasn't able to manage the publication either. It kept taking me to the main newsletter page as if I was visiting and didn't have admin rights. Clicking on the link I had sent you above worked. Not sure what's going on with that :(

if you have details on what you did when it didn't work, I can check with them on Monday.


Crashes on 1.18.2

This is what i get when trying to run this on 1.18.2.
Stacktrace:

Line in question is https://github.com/TheGaming999/PrisonRanksX/blob/master/src/me/prisonranksx/utils/EventPriorityManager.java#L459

Also, happens on both java 17 and 18.

Seems to be working fine for me:

I used Java 17. Are you sure that you are using the latest version of 1.18.2?

Anyway, here is a version without EventPriorityManager. Test it and tell me if it works or not.
PrisonRanksX-2.8.5dev_03.zip

I'm at school rn, I do have purpur so I am gonna test your version with purpur and then the other version withouth purpur.

I don't know exactly what are you running, but latest spigot 1.18.2 gives me this

Your dev03 version does work on purpur (and probably would on spigot) withouth any problems. Weird

Also that was just testing the dev version from discord on normal spigot (cause it was fine on your end from the ss)

I don't know exactly what are you running, but latest spigot 1.18.2 gives me this  Your dev03 version does work on purpur (and probably would on spigot) withouth any problems. Weird

This was indeed an issue and it has been fixed. It must be a problem from your end. It even works for me with the latest version of Purpur:

Also, I used the latest update of java 18 if that makes any difference


Documentation references to facebook/parler_tts-small

Docstrings contain broken code examples, such as:
https://github.com/huggingface/parler-tts/blob/8e465f1b5fcd223478e07175cb40494d19ffbe17/parler_tts/modeling_parler_tts.py#L2610
My research suggests that parler was never Facebook's TTS model; however the documentation has facebook/parler_tts-small references in several places.
This will not work: ParlerTTSForConditionalGeneration.from_pretrained("facebook/parler_tts-small") and it should be for example: parler-tts/parler-tts-mini-v1

Hey @rsxdalv, thanks for opening this issue! Feel free to open a PR to fix this, if you have time!


kakounePlugins.kak-connect: init at 2020-11-01

Merge after #107033.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Superseded by kakoune-cr.


test error on visual genome

I run test_net.py on pre-trained visual genome dataset and at last it break down.
python test_net.py --dataset vg --net vgg16
--checksession 1 --checkepoch 19 --checkpoint 48611
--cuda
VOC07 metric? No
vg_2500-1000-500_val gt roidb loaded from /data1/zyd/faster-rcnn.pytorch/data/cache/vg_2500-1000-500_val_gt_roidb.pkl
/data1/zyd/faster-rcnn.pytorch/lib/datasets/vg.py:362: RuntimeWarning: invalid value encountered in divide
f = np.nan_to_num((prec*rec)/(prec+rec))
AP for water tank = 0.0000 (npos=4)
Traceback (most recent call last):
File "test_net.py", line 324, in
imdb.evaluate_detections(all_boxes, output_dir)
File "/data1/zyd/faster-rcnn.pytorch/lib/datasets/vg.py", line 294, in evaluate_detections
self._do_python_eval(output_dir)
File "/data1/zyd/faster-rcnn.pytorch/lib/datasets/vg.py", line 371, in _do_python_eval
pickle.dump({'rec': rec, 'prec': prec, 'ap': ap,
AttributeError: 'bool' object has no attribute 'dump'
How can I fix this problem?
Thank you very much!

Sorry was a fix found for this error?

Little modification of _do_python_eval function in /lib/datasets/vg.py would resolve that error. It seems that pickle is assigned True by default.
(line 336) from

def _do_python_eval(self, output_dir, pickle=True, eval_attributes = False):

to

def _do_python_eval(self, output_dir, use_pickle=True, eval_attributes = False):

and (line 369) from

if pickle:

to

if use_pickle: