Repository has no license file

It would be nice to have a license file.
What can I assume if a publicly published project has no license?

See #31


Understanding the point_collate_fn.

Hi,
I am currently in the process of training using custom data, and I have encountered some confusion regarding batch processing. For instance, when the batch size is set to 6, sometimes the batch composition appears in the form of 0, 0, ..., 0, 1, 1, ..., 1, 2, 2, ..., 2, ([204800, 204800, 204800] like this... original size is 102400) suggesting some kind of batch merging. I am unsure why this merging occurs. During debugging, it seems that something related to this is handled in point_collate_fn, but I do not fully understand the necessity of this operation. Could you please clarify why this is required? Thank you for your assistance.
def point_collate_fn(batch, mix_prob=0):
assert isinstance(
batch[0], Mapping
)  # currently, only support input_dict, rather than input_list
batch = collate_fn(batch)
if "offset" in batch.keys():
# Mix3d (https://arxiv.org/pdf/2110.02210.pdf)
if random.random() < mix_prob:
batch["offset"] = torch.cat(
[batch["offset"][1:-1:2], batch["offset"][-1].unsqueeze(0)], dim=0
)
return batch

Hi, refer paper Mix3D and you can set mix_prob = 0 to prevent this.


CAS-441 add releaseDate and accommodationRequiredFromDate to referral report

This PR adds 2 fields to the referral report, the updatedReleaseDate and the updatedAccommodationRequiredFromDate, as per CAS-441

I was looking at the PR but I don't  find test in case the updatedReleaseDate and the updatedAccommodationRequiredFromDate have null values
When we add new properties is good to add them to the factories in this case TemporaryAccommodationAssessmentEntityFactory


chore(tests): refactor E2E logger to ease maintenance, writing tests and parallelization

Issue number: #1441
Summary
This PR refactors Logger E2E test following the new Infrastructure and explicit tests.
Tasks

[x] Create LoggerStack and use new infrastructure
[ ] Refactor get_logs to be consistent with other fetcher UX
[ ] Refactor get_logs to accept date time (consistency) and convert to epoch int
[ ] Test for cold start side effect
[ ] Refactor handlers to make logging and append keys dynamic
[ ] Revisit get_logs on whether we could make assertion easier
[ ] Revisit any Lambda specific feature in Logger we can't test w/ functional tests

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[ ] Meet tenets criteria
[ ] I have performed a self-review of this change
[ ] Changes have been tested
[ ] Changes are documented
[ ] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report

Merging #1460 (3cce3a0) into develop (4d0f1a2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3cce3a0 differs from pull request most recent head fc5e8a6. Consider uploading reports for the commit fc5e8a6 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1460   +/-   ##
========================================
  Coverage    99.89%   99.89%
========================================
  Files          123      123
  Lines         5496     5496
  Branches       629      629
========================================
  Hits          5490     5490
  Misses           2        2
  Partials         4        4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Similar to Tracer, I've created a LogFetcher to ease assertion and potential enhancements like assert "key|value|keys" in logs.
Before
def test_basic_lambda_contextual_data_logged(execute_lambda: conftest.InfrastructureOutput):
    # GIVEN
    required_keys = (
        "xray_trace_id",
        "function_request_id",
        "function_arn",
        "function_memory_size",
        "function_name",
        "cold_start",
    )

    lambda_name = execute_lambda.get_lambda_function_name(cf_output_name="basichandlerarn")
    timestamp = execute_lambda.get_lambda_execution_time_timestamp()
    cw_client = boto3.client("logs")

    # WHEN
    filtered_logs = data_fetcher.get_logs(lambda_function_name=lambda_name, start_time=timestamp, log_client=cw_client)

    # THEN
    assert all(keys in logs.dict(exclude_unset=True) for logs in filtered_logs for keys in required_keys)

After
It combines all other tests into a single test by making the payload dynamic.
def test_basic_lambda_logs_visible(basic_handler_fn, basic_handler_fn_arn):
    # GIVEN
    message = "logs should be visible with default settings"
    custom_key = "order_id"
    additional_keys = {custom_key: f"{uuid4()}"}
    payload = json.dumps({"message": message, "append_keys": additional_keys})

    # WHEN
    _, execution_time = data_fetcher.get_lambda_response(lambda_arn=basic_handler_fn_arn, payload=payload)
    data_fetcher.get_lambda_response(lambda_arn=basic_handler_fn_arn, payload=payload)

    # THEN
    logs = data_fetcher.get_logs(function_name=basic_handler_fn, start_time=execution_time)

    assert len(logs) == 2
    assert len(logs.get_cold_start_log()) == 1
    assert len(logs.get_log(key=custom_key)) == 2
    assert logs.have_keys(*LOGGER_LAMBDA_CONTEXT_KEYS) is True

@rubenfonseca @mploski @leandrodamascena could either of you have a pass? It's a lot smaller now that we don't need non-related cleanups


Report ELB instance health per cluster

https://issues.redhat.com/browse/OSD-2968
This refines the elb monitoring to report per cluster. Current implementation checks per AWS account and some accounts have multiple clusters.
This relies on filtering by tag:
Both sets of elbs - elbs provisioned as part of our clusters and elbs created by service of type LoadBalancer -  have the tag kubernetes.io/cluster/<cluster_id>: owned
Also https://issues.redhat.com/browse/OSD-2665
This script should only alert for elbs created from service of type LoadBalancer from within openshift- and kube- namespaces

@dofinn Can you have a quick review please?

/lgmt

This needs an accompanying change in o-a-p for permissions "elasticloadbalancing:DescribeTags",
and a sop update re namespaces -> https://github.com/openshift/ops-sop/blob/master/v3/alerts/check_elb_health.asciidoc#21-health-checks

cc @dofinn d17feb748f62106511f0ca6be28603c8fd131846

/lgtm


Fix compilation on aarch64-unknown-linux-musl

trust/cross don't support this architecture, so it's non-trivial to add CI testing for this to nix, but this fixed it locally for me. Since it's not a supported platform, I haven't added anything to the CHANGELOG, since this could break before the next release.

Fixes it on arm-unknown-linux-musleabi and armv7-unknown-linux-musleabihf as well.

Didn't build on FreeBSD due to ENOSPC.  If you push again, I think it'll build.  Or, you can bypass bors and just press the merge button, just this once.

Hi Gents, are you planning to merge this? It would be very helpful for us - we are trying to build on aarch64-musl and stuck on this one.

@agend while this fixes nix now, it's likely this will break again in the future. If you really want to get proper support added to nix, please contribute to japaric/cross as we rely on that for our CI testing.
bors r+

bors r+


PublicApiAnalyzer refinements

Enforce documentation of public API only for PRs targeting the main branch
Add PublicAPI files as AdditionalFiles
Exclude PublicAPI files from search results
Add new APIs to unshipped

SonarCloud Quality Gate failed.
  0 Bugs
  0 Vulnerabilities
  0 Security Hotspots
  1 Code Smell
 100.0% Coverage
 0.0% Duplication

This Code-Smell should be ignored. It's that the parameter name on the implementation is different from the one on the interface. I changed this in another PR, but technically it would've been a breaking change. I reverted it and essentially just undid my previous change:
https://github.com/ChilliCream/hotchocolate/pull/3677/files#diff-da4e9423d08f59f3dd6a29541a5b52914417755475add15c36627fcecaa80a9dL116-R117

@michaelstaib Thanks for updating the nuke build!
I'll update the documentation and remove the obsolete scripts. How can I specify the From and To parameters on the command line? I tried --from main or From=main, but it didn't work.

@michaelstaib I added the remaining Nuke targets and also tested the GitHub action in my fork of HotChocolate.
This PR should be good to go! :rocket:

@michaelstaib I'm not exactly sure how the changes here have messed with the build, but it seems like we should install all the frameworks we're targeting in the build pipeline, e.g. net5.0 and netcoreapp3.1.
Should I do this or do you know something else that could be the cause?

This Code Smell should be ignored. It's that the parameter name on the implementation is different from the one on the interface. I removed this Code Smell in another PR, but technically it's a breaking change. Therefor I reverted it and essentially just undid my previous change:

we can ignore this since the API is obsolete and will be removed in future. I will override the validation.

Build seems to work now again. I updated the devops pipelines to also install the old 3.1 framework.

The red tests are flaky ... will deal with them in a separate issue.


Check if color is a human, visible color [MacAdams Limits]

I'm not quite sure how I'd like to approach this, or when, but it would be interesting to implement if possible. While neat, it is not absolutely required, but I'd like to look into. There are already premeasured limits out there, much like the Pointer gamut, but it would be cool to calculate it if we can do so in a way that doesn't take forever to calculate. this would allow more accurate results.

https://www.researchgate.net/publication/44673524_Fast_and_accurate_model_for_optimal_color_computation
In case it's helpful, there's a MATLAB algorithm in this article that I've seen referenced a few places. "The computation takes around 10s for each locus using MATLAB 2010a with Windows XP x64/2.8 GHz Intel Core 2 Duo/2 GB RAM." So maybe a second or two on modern hardware. No idea if there's a smart way to less work by either:

only computing the sliver of the locus that shares a hue angle with the color in question
using some set of fixed illuminants, rather than arbitrary illuminants

I did look at that paper before. I saw this as well: https://www.researchgate.net/publication/39435417_A_new_algorithm_for_calculating_the_MacAdam_limits_for_any_luminance_factor_hue_angle_and_illuminant.
I just haven't taken the time to dig deeper than a quick glance at the papers.

So I think you might be able use the same technique you used to implement Pointer's Gamut checking, but with MacAdam's data from this 1935 paper (Here are some relevant screenshots: 1, 2, 3). R here = "visual efficiency", this technique will only work if that = luminance (Y). I am not sure about that assumption.

Yes, a LUT would obviously work. Of course a tradeoff of how big a LUT to keep in memory vs accuracy would have to be considered. I'd hate to include a high precision LUT table as it would be large and eat up a bunch of memory. The Pointer gamut approach uses a very small table because that is the only data available and it is small enough to not be a big deal. I'd like to get around to dynamically calculating whether a point is in or outside of gamut, but obviously a LUT is a solution that would indeed work.


[CI] Run tests through GitHub Actions

This PR proposes to run the tests through GitHub Actions rather than Jenkins (similar to what we did on Clinica a few months ago).
The VM that was used until now is running on CentOS7 and was clearly missing recent updates.
In addition, CentOS7 will be EOL in June 2024 (https://endoflife.date/centos).
Because of these reasons, I created and configured a new VM running on Ubuntu 20.04-lts.
I should have installed the required tools that we use (like dvc, pipx, poetry, miniconda...) but let me know if something is missing.
I also deployed a new GitHub runner on this VM (there is also one deployed on the CentOS VM but the workflows are crashing due to an old version of glibc, I'll delete it later).
This PR proposes to port two tests: test_cli.py and test_tsvtools.py to Github Actions, making sure that tests with and without access to clinical_data_ci are working fine.
If the proposed solution is accepted, I'll port the remaining tests and remove the associated Jenkins pipeline.
I will also need to take a closer look at the machine were are using for testing GPU support to see if we could implement something similar.

Thanks for the review @thibaultdvx ! 👍
I'll take care of the other tests no worries. I still need to deploy runners on the GPU machine (and maybe an aramis workstation), so I don't mind finishing.
@camillebrianceau is this good for you or do you want to take a closer look before we merge ?

I'm gonna go ahead and merge this.
We can always revert if we don't like it in the end...


Do not send gift card emails for gift cards that are not redeemable

Update the rake task to only look for and send gift cards that are redeemable.
Spec.

:+1:

:+1:


Add: Slide Toggle

Description
Added a new toggle component: Slide Toggle
Files changed
Updated Toggle Cards:

src/showcase/ui-group/ToggleCards.tsx

Updated Credits:

credits.md

Files added
New component - Slide Toggle:

src/showcase/components/toggle/SlideToggle.tsx

New page - Slide toggle:

src/app/(docs)/components/toggle/slide-toggle/page.mdx

Screen recording
https://github.com/Ansub/SyntaxUI/assets/97196113/da174fc2-ae96-426f-b5f8-1bbe5d6f75d9
Checklist
Please check the boxes that apply:

[x] I have tested the changes locally
[x] I ran npm run build and build is successful
[x] I have added necessary documentation (if applicable)
[x] I have updated the credits.md file (if applicable)

you can please rebase and fix the merge conflict @user-aiko

Merge Conflicts

Merge Conflicts

Fixed!


Doesn't work with currency formatted numbers

It's good if we use it just for numbers, but if we need to use it with real world data i.e. formatted numbers according to currency then it's of no use, cause the formatted string can't be accepted in animateToNumber prop.

Agree, it could be nice to add a prepend / append option to add locale


Update Sequence diagram

Codecov Report

Merging #370 (e8cc404) into master (825ef9b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage     61.20%   61.20%
  Complexity      716      716
=========================================
  Files           126      126
  Lines          2877     2877
  Branches        369      369
=========================================
  Hits           1761     1761
  Misses          979      979
  Partials        137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825ef9b...e8cc404. Read the comment docs.


Extract PDF form field names from a PDF form

How to extract pdf form fields from this lib ... Is it possible to extract from using javascript only ?
PDFTK Command : # pdftk input.pdf dump_data_fields
Click here for Sample

I am looking for a similar solution. I want to get PDF label name same as in PDF.

var nameRegex = null;

var FDF_data = pdfFiller.generateFDFTemplate( sourcePDF, nameRegex, function(err, fdfData) {
    if (err) throw err;
    return fdfData;
});

it generates field names from the form.  you can try var pdfFiller = require('pdffiller-keepfields'); to also get field values

I need fields and its values

The above is my requirement and the image i pasted will be sent as the pdf

Is it possible in pdf-lib for my data retrieval as mentioned above??

Please explain more in detail what do you mean


General refactor 'client' & usability

Extract client base -> allow use it as type hint in resource.py
Maybe help methods that allow easy create new task/list from current task/client

listing as generators
helpers property for getting lists & Co.


RAR files extract corrupted files if the filenames are not encrypted

When a file from the viewing window of the program is opened or extracted from a password-protected rar file, the resulting file is corrupted. The problem is the library this application uses to open the archive, SharpCompress, does not have a check for passwords for rars and also does not have validation for file data, like CRC. I may have to find a way to validate the file, possibly by the file size because it seems to create an empty file.
Need to keep an eye on CRC Validation support in SharpCompress: adamhathcock/sharpcompress#246

Added filesize check https://github.com/JordantheDewott/ArchiveManagerSharp/commit/51c213004ff74249667e9b6a1d928ef6cdc52a16 which fixes the error for the extract button in my test . Still need to fix it in the the drag-drop handler


[SPEC] Change "services" to "components", to be more C4-like

Currently, the ArchDoc spec outlines two major contracts: users and services. The 'service' construct refers to microservices or apps that exist within your architecture. However, I feel we want to rename the term "service" to "component" to be more general. Components can be APIs, databases, storage buckets, etc. Another advantage of components is that it adheres to the C4 architecture framework terminology.
Examples
Instead of the following ArchDoc spec:
services:
  api:
    description: The API gateway of the application.
    repository: https://github.com/MyOrg/api-gateway
    tags:
      - backend
      - public

We will be using the following:
components:
  api:
    description: The API gateway of the application.
    repository: https://github.com/MyOrg/api-gateway
    tags:
      - backend
      - public

Acceptance Criteria

ArchDoc UI parses ArchDoc spec files so that the services is renamed to components
All ArchDoc UI tests are modified to reflect this
All ArchDoc spec examples are updated to the latest schema

ArchDoc v0.2.0 now uses "components" instead of "services".
Version

Spec

UI


IBM Developer Tools CLI Installer (idt-installer) for Windows - Anti Virus Blocking

Unable to install CLI through Powershell, below shown is the code and error, request you to help.
[Net.ServicePointManager]::SecurityProtocol = "Tls12, Tls11, Tls, Ssl3"; iex(New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/IBM-Cloud/ibm-cloud-developer-tools/master/windows-installer/idt-win-installer.ps1')
At line:1 char:1

[Net.ServicePointManager]::SecurityProtocol = "Tls12, Tls11, Tls, Ssl ...

This script contains malicious content and has been blocked by your antivirus software.
+ CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : ScriptContainedMaliciousContent
Operating System
Specify: (Windows)

@Babareddy as a quick work-around for you, I suggest installing the tools manually. This documentation will guide you through this: https://cloud.ibm.com/docs/cli?topic=cli-install-devtools-manually


Added Weather App Python Gui Tkinter

Fixes
#280 Issue No.

Description

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New project (non-breaking change which adds functionality)

How Has This Been Tested?
This program is run by me :)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have included a README.md file
[x] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[x] I have added demonstration in the form of GIF/video file
[x] I am a GSSoC'22 Participant

Didn't thought issues are really needed to make.
Updated now!


calculate climo files on history tapes other than h0

The atmospheric budget diagnostics require climo files on monthly instantaneous output (currently uses the h1 files). We need to change the climo.bash template to allow input files other than h0 by adding lines below:
{% elif frequency == 'monthly_inst' %}

ncclimo \
--case={{ case }} \
{%- if exclude %}
-n '-x' \
{%- endif %}
{%- if vars != '' %}
--vars={{ vars }} \
{%- endif %}
--parallel=mpi \
--december_mode=sdd \
--mdl_nm=eam \
--hst_nm=h1 \
--fml_nm={{ case }}.h1 \
--yr_srt={{ yr_start }} \
--yr_end={{ yr_end }} \
--input={{ input }}/{{ input_subdir }} \
{% if mapping_file == '' -%}
--output=output \
{%- else -%}
--map={{ mapping_file }} \
--output=trash \
--regrid=output \
{%- endif %}

@tangq : I think we can implement something along these lines, but I'd like to have a more generic implementation to avoid having too many special cases.
I wonder if we could replace
https://github.com/E3SM-Project/zppy/blob/ff980c6c0d707e9d2b339a11506c36ef06c055a7/zppy/templates/climo.bash#L25
with an if for "monthly" or "monthly_inst" and add the flexibility to use different h* input files, something like
--history={{ input_files.split(".")[1] }}
(--history appears to be the same as --hst_nm, but less obscure).
Need input from @forsyth2.

@golaz , I found it's more flexible to handle this in the "ts" section, because for my application the time series data is better than the climos. But it's still useful to have a more flexible climo options.

Sounds like this is no longer needed if using "ts" is better for what you want to do. Let's close this for now until there is a need.


Add logging guidelines for developers

Proposed changes
Problem:
The project doesn't include logging guidelines. As a result, there is risk the logging:
(1) Evolves chaotically.
(2) Not adequately addresses both users and developer needs.
Solution:
Add logging guidelines for developers.
Solves https://github.com/nginxinc/nginx-kubernetes-gateway/issues/547

Note:
I included a temp doc with a list of issues I see that are spawned by the guidelines. They show the diff between the guidelines and the code. I didn't want to add them before the PR is reviewed and merged, as they might change because of that.

Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Added issues:

https://github.com/nginxinc/nginx-kubernetes-gateway/issues/918
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/918
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/919
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/922
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/920
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/921
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/923
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/924
https://github.com/nginxinc/nginx-kubernetes-gateway/issues/926


Add option to get translation from Musixmatch

How you think the new feature/improvement would be helpful, or what problem you think it would solve

Very obvious but,

Good for listening to music that the user doesn't speak language of.
Help in learning language.

I found this I don't if will help -
https://github.com/Spikatrix/Traly
https://github.com/markzhai/LrcCleaner
https://github.com/brandonw3612/TranslateLrc
https://github.com/slowfog/LrcSpliter
https://github.com/marz1877/SyncedLyrics-.lrc_v2

Please provide addition information, as mandated in the feature request template. Closing until then.
Is this even something musixmatch provides? Can you link to any documentation on it?
On the balance of it, I probably wouldn't want to add this anyway (at least without many people asking for it) because of the amount of complication it would introduce.

Is this even something musixmatch provides? Can you link to any documentation on it?

https://www.youtube.com/watch?v=Cdj87UTuKQ8
https://support.musixmatch.com/article/89-how-can-i-display-the-lyrics-translation

On the balance of it, I probably wouldn't want to add this anyway (at least without many people asking for it) because of the amount of complication it would introduce.

Add option in setting to turn in on/off.

Add option in setting to turn in on/off.

No. That would be more complication.

Add option in setting to turn in on/off.

No. That would be more complication.

I mean on and off option for downloading translations. Not translated lines

@jacquesh Please reopen this

@jacquesh More people are interested in Translation
https://www.reddit.com/r/foobar2000/comments/y35b04/comment/isba0jm/?context=3

@jacquesh would you allow if someone else writes a patch?

Maybe, but realistically, probably not. The problem isn't doing the work to add it, the problem is that I don't think translation really falls into the realm of "things openlyrics should concern itself with" and that once its added I have to maintain it for all time or risk the wrath of users if I take it out later in pursuit of simplicity.

#include <curl/curl.h>
#include <libxml/parser.h>
#include <libxml/tree.h>

// Function to retrieve translated synced lyrics from musixmatch.com
std::string getTranslatedLyrics(int trackId, std::string apiKey, std::string lang) {
    // Construct the API URL
    std::string apiUrl = "https://api.musixmatch.com/ws/1.1/track.subtitle.get?"
                         "track_id=" + std::to_string(trackId) + "&"
                         "apikey=" + apiKey + "&"
                         "subtitle_format=mxm&"
                         "language=" + lang;

    // Initialize libcurl and set the options
    CURL* curl = curl_easy_init();
    curl_easy_setopt(curl, CURLOPT_URL, apiUrl.c_str());
    curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, &curlWriteCallback);

    // Create a buffer to hold the response
    std::string responseBuffer;

    // Set the buffer as the data to write to
    curl_easy_setopt(curl, CURLOPT_WRITEDATA, &responseBuffer);

    // Send the request
    CURLcode res = curl_easy_perform(curl);

    // Check for errors
    if (res != CURLE_OK) {
        // Handle error
    }

    // Cleanup libcurl
    curl_easy_cleanup(curl);

    // Parse the XML response
    xmlDocPtr doc = xmlReadMemory(responseBuffer.c_str(), responseBuffer.length(), NULL, NULL, 0);
    xmlNodePtr root = xmlDocGetRootElement(doc);

    // Traverse the XML tree to find the synced lyrics
    xmlNodePtr trackNode = root->children;
    while (trackNode != NULL) {
        if (xmlStrcmp(trackNode->name, (const xmlChar*)"track") == 0) {
            xmlNodePtr subtitleNode = trackNode->children;
            while (subtitleNode != NULL) {
                if (xmlStrcmp(subtitleNode->name, (const xmlChar*)"subtitle") == 0) {
                    xmlNodePtr syncedLyricsNode = subtitleNode->children;
                    while (syncedLyricsNode != NULL) {
                        if (xmlStrcmp(syncedLyricsNode->name, (const xmlChar*)"synced_lyrics") == 0) {
                            // Found the synced lyrics
                            std::string syncedLyrics = (char*)xmlNodeListGetString(doc, syncedLyricsNode->xmlChildrenNode, 1);
                            xmlFreeDoc(doc);
                            xmlCleanupParser();
                            return syncedLyrics;
                        }
                        syncedLyricsNode = syncedLyricsNode->next;
                    }
                }
                subtitleNode = subtitleNode->next;
            }
        }
        trackNode = trackNode->next;
    }

    // Cleanup libxml2
    xml

#include "stdafx.h"
#include "../SDK/foobar2000.h"
#include "../helpers/helpers.h"
#include "../SDK/components.h"
#include <string>
#include <sstream>
#include <algorithm>
#include <curl/curl.h>
#include <rapidjson/document.h>
#include <rapidjson/writer.h>
#include <rapidjson/stringbuffer.h>
#include <map>
#include <regex>

using namespace rapidjson;

class musixmatch_lyrics : public lyrics_provider_v2 {
private:
    std::string useragent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0";

    std::string get_lyrics_url(const std::string& artist, const std::string& title, const std::string& lang) {
        std::string url = "https://www.musixmatch.com/ws/1.1/macro/search_lyrics?user_language=en&q_lyrics=";
        std::string query = artist + " " + title;

        std::stringstream ss;
        ss << std::hex << std::uppercase << std::hash<std::string>{}(query);

        url += ss.str();
        url += "&q_track=";
        url += url_encode(title);
        url += "&q_artist=";
        url += url_encode(artist);
        url += "&q_lang=";
        url += lang;

        return url;
    }

    std::string get_lyrics(const std::string& url) {
        CURL* curl = curl_easy_init();

        if (!curl) {
            return "";
        }

        curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
        curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
        curl_easy_setopt(curl, CURLOPT_USERAGENT, useragent.c_str());
        curl_easy_setopt(curl, CURLOPT_HTTPGET, 1L);

        std::string response;
        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_callback);
        curl_easy_setopt(curl, CURLOPT_WRITEDATA, &response);

        CURLcode res = curl_easy_perform(curl);

        curl_easy_cleanup(curl);

        if (res != CURLE_OK) {
            return "";
        }

        Document doc;
        if (doc.Parse(response.c_str()).HasParseError()) {
            return "";
        }

        const Value& status = doc["message"]["header"]["status_code"];
        if (status.GetInt() != 200) {
            return "";
        }

        const Value& lyrics = doc["message"]["body"]["macro_calls"]["track.lyrics.get"]["message"]["body"]["lyrics"]["lyrics_body"];
        std::string str_lyrics = lyrics.GetString();

        str_lyrics.erase(std::remove(str_lyrics.begin(), str_lyrics.end(), '\r'), str_lyrics.end());
        str_lyrics.erase(std::remove(str_lyrics.begin(), str_lyrics.end(), '\n'), str_lyrics.end());

        return str_lyrics;
    }

    std::string get_translated_lyrics(const std::string& lyrics_id, const std::string& lang) {
        std::string url = "https://www.musixmatch.com/ws/1.1/track.lyrics.translation.get?commontrack_id=";
        url += lyrics_id;
        url += "&selected_language=";
        url += lang;

        CURL* curl = curl_easy_init();

        if (!curl) {
            return "";
        }

        curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
        curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
        curl_easy_setopt(curl, CURLOPT_USER

@jacquesh reconsider this please

ESLyric can get MusixMatch translations ?
"ESLyric supports js syntax lyrics source and can also display translations"
How to get enhanced format
LRC - https://github.com/Robotxm/ESLyric-LyricsSource/
https://github.com/ESLyric/scripts/tree/main/parser
https://www.musixmatch.com/lyrics/Green-Day/Basket-Case/translation/german
@jacquesh

Out of scope.


IGListAdapterDelegate needs Swift name of ListAdapterDelegate

Will be breaking so let's queue for 4.0

I'll take this

Thank You


Responsivity of image to pdf service page is done

Thanks for your support of the project. Please check the below-mentioned points -
What kind of change does this PR introduce?
I have made the image to pdf service page responsive for all devices.
solved #191
Documentation updated ?
Yes
Checklist

[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Links
https://devikavarshney.github.io/Student-portal/
Screenshots
For laptop

For mobile phones

For iPad

@aakankshabhende @shivshankar9 @swati2603 Please check this PR solved #191

@shivshankar9 @aakankshabhende Thank you so so much 😭


KYLIN-3839 Strorage clean up after refreshing and deleting segment

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c0b9e51). Click here to learn what that means.
The diff coverage is 13.18%.

@@            Coverage Diff            @@
##             master     #502   +/-   ##
=========================================
  Coverage          ?   24.46%
  Complexity        ?     5029
=========================================
  Files             ?     1161
  Lines             ?    70393
  Branches          ?    10019
=========================================
  Hits              ?    17220
  Misses            ?    51433
  Partials          ?     1740

Impacted Files
Coverage Δ
Complexity Δ

...torage/hbase/steps/HBaseSparkOutputTransition.java
0% <0%> (ø)
0 <0> (?)

.../main/java/org/apache/kylin/cube/CubeInstance.java
38.57% <0%> (ø)
52 <0> (?)

...ava/org/apache/kylin/rest/service/CubeService.java
0% <0%> (ø)
0 <0> (?)

.../apache/kylin/storage/hbase/steps/HBaseGCStep.java
0% <0%> (ø)
0 <0> (?)

...pache/kylin/storage/hbase/steps/HBaseJobSteps.java
0% <0%> (ø)
0 <0> (?)

...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java
39.04% <28.57%> (ø)
8 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b9e51...115c952. Read the comment docs.

Pull Request Test Coverage Report for Build 4209

12 of 91 (13.19%)  changed or added relevant lines in 6 files are covered.
8 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.008%) to 26.94%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseGCStep.java
0
1
0.0%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseSparkOutputTransition.java
0
1
0.0%

core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
0
4
0.0%

server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
0
14
0.0%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseJobSteps.java
0
29
0.0%

server-base/src/main/java/org/apache/kylin/rest/job/StorageCleanJobHbaseUtil.java
12
42
28.57%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
1
43.57%

core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java
1
81.08%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
3
78.42%

server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
3
0.0%

Totals

Change from base Build 4206:
-0.008%

Covered Lines:
18964

Relevant Lines:
70393

💛  - Coveralls

pr updated


Add a shortcut for switching between open files in the script editor

Quick Open Script is nice when you have a name in mind and the file isn't already open, but when you're moving between a small set of files, being able to switch between them by tabbing through a list is ideal:
https://gfycat.com/NeedySardonicCassowary
That video was taken in Qt Creator, which uses the following shortcuts for this feature:

Ctrl+Tab on Windows
Alt/Option+Tab on macOS

See also https://github.com/godotengine/godot/issues/22846 (which is about the scene editor).

This is already available with Ctrl + Shift + , and Ctrl + Shift + .. You can reassign those shortcuts in the Editor Settings.
However, reassigning those to shortcuts such as Ctrl + Shift + Up and Ctrl + Shift + Down won't work in 3.x because the script editor will intercept those shortcuts.


AudioFrame playback chunk and the simulator

From @microbit-matt-hillsdon in https://github.com/microbit-foundation/micropython-microbit-v2/pull/163#issuecomment-2032427825, broken out here to be able to keep discussions on their own thread:

The existing sim implementation of playing AudioBuffers has always been problematic because of the 4ms chunk size. For audio frames of longer duration I had more hope, but at the moment the chunk size used is the same even though we likely have a much larger buffer in the frame itself.
Our work-in-progress record/playback sim implementation works OK if you increase LOG_AUDIO_CHUNK_SIZE from 5 to 6. (it's possible that on slower computers a bigger buffer still might help, I've not had a chance to test yet). We can't just do that as I think it means regular audio frames are pitch/rate shifted but it might show a way forward for the sim.
The sim changes without the LOG_AUDIO_CHUNK_SIZE change can be seen here: https://review-python-simulator.usermbit.org/beta-updates/demo.html (microbit-foundation/micropython-microbit-v2-simulator#113) - see sample "Record". For now you'll have to rebuild locally to see the benefit of the buffer size change. We've not yet looked at edge cases etc. but I think this problem will remain.

@dpgeorge this is currently the only thing blocking putting audio/record in the simulator for beta so we'd appreciate a view on this - especially if it needs a design change as we iterate the audio stuff anyway to make sure it works. (I'm thinking about our conversation about how a contiguous memoryview is more natural and efficient compared to a generator of smaller buffers)

I think I have a way forward here to allow for a minimum AudioFrame size of 32 bytes, but also have a larger output buffer, and the output buffer is filled as much as possible before calling down in to the lower layer (CODAL, simulator) to play the data.

I have pushed some commits to the audio-recording branch which should resolve this issue.  You can now define (at the C level, in mpconfigport.h) the following macro to increase the audio output buffer size:
#define AUDIO_OUTPUT_BUFFER_SIZE (256) // this can be any value, defaults to 32 bytes

That will be the number of bytes that are sent at a time down to the lower layers of the audio pipeline (eg to the simulator).
@microbit-matt-hillsdon see if that works!

Thank you, this is way better for playback of recordings and improves the situation for traditional audio frame use.
Updated here:
https://review-python-simulator.usermbit.org/beta-updates/demo.html
https://review-python-editor-v3.microbit.org/beta-micropython/
(At some point in these sim changes we've broken regular AudioFrame use on Firefox - I'll track that down shortly).
Needs some testing on slower hardware but I think this is more an asyncify/event loop tick resolution issue than a performance one so I'm optimistic.
I used the smallest viable buffer (64) because of an issue with wait=True.
As I understand it, we stop waiting when we've finished sending the audio to play not when it's finished playing.
The Web Audio side currently request an extra buffer when we start playing (to avoid stalling) and more buffers as we finish playing each buffer. So the last writeData returns with two 64 sample buffers still to play.
Initially we had a sim-only issue where we'd overlap audio if there was a subsequent play after a wait=True play but we've fixed that. So the remaining issue is that control is arguably returned to the user program early. These issues are somewhat noticeable in the "Audio" sample on the sim demo page.
It might still be possible to overlap different types of audio by the two buffers time - e.g. I think we could start playing speech while still processing the last two raw audio buffers.
I'm not sure these issues have a straightforward fix and they might be acceptable.
There's one more thing I wanted to check: If you ever play an AudioFrame then we now seem to play silence after it indefinitely. Is that an intentional change? We don't think this happened before the MicroPython update and maybe happened in this latest change. I'm dropping the silent frames in the C-side of the HAL at the moment.

Thank you, this is way better for playback of recordings and improves the situation for traditional audio frame use

Great!  I'm glad it works.

There's one more thing I wanted to check: If you ever play an AudioFrame then we now seem to play silence after it indefinitely. Is that an intentional change?

Oops, that's a mistake on my side.  Now fixed, see the most recent commit on the audio-recording branch.  Please can you test this to see if it fixes it for you?

As I understand it, we stop waiting when we've finished sending the audio to play not when it's finished playing.

This is a bug on the MicroPython side that we will try to resolve.  See https://github.com/microbit-foundation/micropython-microbit-v2/issues/182#issuecomment-2084104624, and related https://github.com/microbit-foundation/micropython-microbit-v2/issues/206

There's one more thing I wanted to check: If you ever play an AudioFrame then we now seem to play silence after it indefinitely. Is that an intentional change?

Oops, that's a mistake on my side. Now fixed, see the most recent commit on the audio-recording branch. Please can you test this to see if it fixes it for you?

Looks good now that I've updated the sim to 17aaa115ad4ad285377b2eb210f37b0e94f61aa9 (same demo links as above). Thanks.

Looks good now that I've updated the sim to ...
Very good!  Thanks for confirming.
I think we can probably close this issue now.


Add support for tvOS

Adding support for tvOS...
Related: https://github.com/bustoutsolutions/siesta/issues/28

Great, thanks! Are you using Siesta in a tvOS app? Is it working for you? Do the specs run?
I don't want to officially declare tvOS support until there’s confirmation from real projects that it’s working properly.

@pcantrell Cheers! I just started working on this project and got it to compile today with the updated specs. So far so good and it compiles nicely. I thought I'd create the PR early to keep you updated as I go forward.

Excellent, please do. I’d love to officially add tvOS support once it’s confirmed to work.

Absolutely, I need that too.

@pcantrell I've been using Siesta in a tvOS app for nearly 2 years now using a similar patch (requiring tvOS 10.0 instead) and it has been working very good.

Thanks, @snoozemoose, that’s great to know!

@pcantrell I can now safely say that Siesta works very well on tvOS and the changes in this PR was the only thing needed for that matter.

@pcantrell It would be great if we can merge this in. If there's anything else associated with this merge request that needs to be done, I will try to help.

Yes! Sorry to leave you hanging. I’m working on this now.
I’m doing a pass now to change all the settings for the tvOS targets to match the other targets as closely as possible. There are currently several places where there are minor internal differences that don’t stop the tvOS targets from working, but might cause trouble in the future (e.g. differences in how build settings specify relative paths). I’m also enabling the SiestaUI target for tvOS, where it should work other than lacking a default .xib file for the status overlay.

I’ve pushed the build setting changes. While I get Travis sorted out, @omidontop, would you please try my latest push to this branch on your project and make sure my setting changes work on your end?

@pcantrell Great work! Thank you so much for picking this up again. Of course I can test it :) Give me a sec.

@pcantrell It compiles and works just fine!

Fantastic! Now I just have to get tvOS working on CI, then I’ll merge.

Is the scheme name correct? You know with the whitespaces and all...
-scheme Siesta tvOS

It’s some more fiddly mistake having to do with mismatches between the various names different Xcode CLI tools use for simulator platforms & versions. Trying different settings in between making dinner here.
Fair warning: once I have it figured out, I’m going to roll up all the intermediate “fiddling with Travis” commits and force push so we don’t end up with a dozen Travis experiments littering the history.

OK, it’s working! Couldn’t get CI to work with any version of tvOS except 12.1, but I’m pretty sure it’s a Travis / Xcode issue and not a Siesta issue, so … oh well. Merging!

@pcantrell Bravoo! Thanks a lot for the awesome work! 🍺 Had many more bits and pieces involved than I imagined! Do you also have any new releases scheduled?

Not scheduled, but planning to cut one whenever I finally get the new FileCache stuff sorted out.

And thanks to you and everyone who tried it out on tvOS! It was crucial having real users for this.


GH1051 Drop astype tests for Mac arm for float128 and complex256

[x] Closes #1051
[x] Tests added: Please use assert_type() to assert the type of any return value

Needed to let poetry choose the right version of tables, wondering if it is okay, at least we will need that to move to supporting python3.13.


Persist the preview when not all information is present yet

typing 'r at 12' will change from the preview snippet to a google search as there aren't all of the parameters available.
Would it be possible to maybe have some indicator if the reminder is valid or invalid (maybe a tick or cross), but to keep the workflow active while it is invalid so that you still know that the workflow.
I have just started using this, and was attempting to create a reminder for a lunch event, so when i typed 'r at' the preview was there, but after writing 12 it went to a google search preview, which made me think that I did something wrong.
Maybe some visual feedback that you're still on the right track would be useful for new users.

This is what should be happening, so something is broken. I'll look into it.


Eslint updates

This PR updates eslint from 5.0.0 to ^5.15.0 and eslint-plugin-shopify from ^23.1.0 to 27.0.1. This latter was 4 major releases so there were a lot of new rules, and the big things were all the new @typescript-eslint and react-hooks stuff.

@lemonmade this is ready for another look.


Bugfix/circleci - wrong folder variable

wrong folder variable

If we plan to upgrade terraform to version 0.10.0, we need add option -check-variables=false to validate command. We can do that later (https://github.com/hashicorp/terraform/issues/15758)

Thanks!

Thanks @tfhartmann
The build detail is at https://circleci.com/gh/terraform-community-modules/tf_aws_ecs


The Witcher 3 Texture Flickering

Certain terrain flickers. Ground/earth on side of grass planes and mountains/rocks. Plants and other greenery seem to be unaffected.

Also uploaded video clips and more pictures showing the issue to Firefox send (limited to 24hours, will renew link when necessary):
https://send.firefox.com/download/603dd3311b/#ghj0LzAff2ffInpu6hmBpQ
The clips show the issue best
Software information
Witcher 3 Wild Hunt
Vsync: On
Resolution: 1920 x 1080
FPS limit: 60
Everything else set to Ultra with exception of:
Detail Level: High
Shadow Quality: medium
Ran the game through Proton 3.16-6 Beta. Had the issue with non beta.
GPU: RX 580 Nitro+ 4GB
INTEL-MESA: warning: Haswell Vulkan support is incomplete         deviceName     = Intel(R) Haswell Desktop         deviceName     = AMD RADV POLARIS10 (LLVM 8.0.0)
server glx vendor string: SGI server glx version string: 1.4 client glx vendor string: Mesa Project and SGI client glx version string: 1.4 OpenGL vendor string: X.Org OpenGL renderer string: Radeon RX 580 Series (POLARIS10, DRM 3.27.0, 4.19.11-041911-generic, LLVM 8.0.0) OpenGL core profile version string: 4.5 (Core Profile) Mesa 19.0.0-devel - padoka PPA OpenGL core profile shading language version string: 4.50 OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.0.0-devel - padoka PPA OpenGL shading language version string: 4.50 OpenGL ES profile version string: OpenGL ES 3.2 Mesa 19.0.0-devel - padoka PPA OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
Attempts at finding the cause of the issue:

Installed kernel 4.19, was at 4.15 prior to installation. No effect
Toggled graphic settings on and off (vsync, window mode, etc) to see if flicker stopped. Only changing Texture quality had a impact but the issue of things not rendering was still prevalent.

This looks very much like this llvm regression which has recently been fixed. Try again with llvm7 or wait until your ppa updates llvm to the revision which contains the fix.

You opened the same issue twice. #830

This is a known LLVM bug, if you use LLVM 8.0 then please update your LLVM.

This is a known LLVM regression as @Oschowa said, please update to the latest revision.

Ty. I will wait for update.


[bug] eslint error in typescript compiled object destruct syntax in async function.

Is this a bug report?
Yes. And I created a repository just to show the bug. https://github.com/xialvjun/cra-eslint-bug
If you do not use that repository, you can create-react-app cra-eslint-bug and copy the src/abc.js in https://github.com/xialvjun/cra-eslint-bug to cra-eslint-bug/src/abc.js, then import './abc'; in cra-eslint-bug/src/App.js...
The src/abc.js file is just a typescript compiled file from code:
const abc = async () => {
    const obj = await Promise.resolve({a: 1, b: 2, c: 3, d: 4});
    const {a, b, c, d} = obj;
    await Promise.resolve(null);
    console.log(a, b, c, d);
};

abc();

Hi @xialvjun , thanks for the report. Are you wanting to use TypeScript with CRA? CRA 2.1+ now supports TypeScript.
As for the issue you've reported, that looks very strange, but is actually an eslint issue from what I can see. When using the eslint VSCode extension, I also get that error.

Note that replacing the commas with semicolons on that line resolves the problem. You could also add that file to a .eslintignore file, as a file generated by TypeScript is not likely to meet linting standards without some editing.

@xialvjun if you want to use your own TSLint instead of the built-in linting, check out the Rescripts framework + the use-tslint-config rescript (I just released it and would really love your feedback!) :)


make update broken

make update fails:
[dbelyavs@myvirt openssl]$ make update
( cd .; /usr/bin/perl VMS/VMSify-conf.pl \
			< apps/openssl.cnf > apps/openssl-vms.cnf )
( cd .; /usr/bin/perl crypto/bn/bn_prime.pl > crypto/bn/bn_prime.h )
( cd .; /usr/bin/perl crypto/objects/objects.pl -n \
			crypto/objects/objects.txt \
			crypto/objects/obj_mac.num \
			> crypto/objects/obj_mac.new && \
    mv crypto/objects/obj_mac.new crypto/objects/obj_mac.num )
( cd .; /usr/bin/perl crypto/objects/objects.pl \
			crypto/objects/objects.txt \
			crypto/objects/obj_mac.num \
			> include/openssl/obj_mac.h )
( cd .; /usr/bin/perl crypto/objects/obj_dat.pl \
			include/openssl/obj_mac.h \
			> crypto/objects/obj_dat.h )
( cd .; /usr/bin/perl crypto/objects/objxref.pl \
			crypto/objects/obj_mac.num \
			crypto/objects/obj_xref.txt \
			> crypto/objects/obj_xref.h )
( cd .; /usr/bin/perl crypto/conf/keysets.pl \
		        > crypto/conf/conf_def.h )
( cd .; /usr/bin/perl crypto/asn1/charmap.pl \
		        > crypto/asn1/charmap.h )
( cd .; /usr/bin/perl fuzz/mkfuzzoids.pl \
			crypto/objects/obj_dat.h \
			> fuzz/oids.txt )
( b=`pwd`; set -e; cd .; \
          /usr/bin/perl util/ck_errf.pl -strict -internal; \
          /usr/bin/perl -I$b util/mkerr.pl  -internal )
Global symbol "@disablables_int" requires explicit package name (did you forget to declare "my @disablables_int"?) at util/mkerr.pl line 313.
Execution of util/mkerr.pl aborted due to compilation errors.
make: *** [Makefile:584: errors] Error 255

I think it is urgent

Are you sure you did make clean and/or properly reconfigure?
I cannot reproduce this on current master.

Also it is not visible in CI - latest master run: https://github.com/openssl/openssl/runs/2473843775

./configdata.pm -r should clear that up

Thanks!
./config did it


fix: allow injecting JWT options when creating a VC fixes #89

I created a proposal to fix the bug described in #89. Happy to hear your feedback.

I added a test to check whether the created VC has a correct exp set. I am not sure whether a test for canonicalize makes sense and how to do that with jest.
I updated the implementation as you suggested and also did the same for the Verifiable Presentation.
There, I was not sure whether a test makes sense because iat is explicitly set to undefined for VPs.


Piston needs introductory docs

Which outline the ecosystem, point out the most notable projects, and describe how to make them fit together into an actually useful game.  They should describe the goals of Piston, the overall design, and where it lies in terms of meeting those goals; ie, what works and what doesn't.
That way when people come into #rust-gamedev on IRC and ask "How do I Piston" we have somewhere to point them.

The REAMDE contains links to an overview of Piston https://github.com/PistonDevelopers/piston/blob/master/README.md. An advanced Piston tutorial is in progress https://github.com/PistonDevelopers/Piston-Tutorials/tree/master/advanced.

The overview is insufficient, because it a) does not describe how to actually use any of the components it talks about, b) does not describe how they relate to each other beyond (admittedly nice) dependency graphs, and c) most of the crates it links to (eg, ai_behavior) are essentially undocumented.

Do you have any thoughts about how we could explain better how to use the components?
We are working on improving the docs.

I think the advanced tutorial is the right direction, but that also needs to exist for getting started. On this page: https://github.com/PistonDevelopers/piston/wiki/Piston-overview it lists what is under piston core, but doesn't really show how to use them to put something together. Clicking on the examples, I can see some smaller pieces of code, but it's not explained. When i was first getting into Rust, I remember looking at some of those loops, but i had no idea where the graphics methods were coming from.
So I think there needs to be a fairly in depth tutorial leveraging some of the more important crates. Make a pong game or something simple, using textures, not just flat colours. So you can show an example on loading textures.
This tutorial should explain the different crates you're pulling in, why you're pulling them in, and how we're supposed to use them.

I wrote a skeleton outline for a "The Piston Game Engine (TPGE)" book a few months back. Forgot about it while waiting for approval from legal to work on it. Still relevant for this discussion.

Also the discussion in this thread is relevant

yeah that looks like a great idea. Might be a bit heavier to flush out compared to what myself & icefoxen are referring to though.

@echochamber Please go ahead!
Making a game tutorial is a great idea. I'll start writing on it, and see how it goes. I don't want to create Pong so I'll do Sudoku instead.

I've now written the first 6 chapters of the Sudoku tutorial https://github.com/PistonDevelopers/Piston-Tutorials/tree/master/sudoku.
Feedback issue https://github.com/PistonDevelopers/Piston-Tutorials/issues/164


Create spring boot project

Create a new project using Start Initializr(https://start.spring.io/).

Summary by CodeRabbit

New Features

Introduced a new .gitignore file to maintain a cleaner repository by excluding unnecessary files.
Updated the project branding and purpose in the README.md, now titled "coderabortory-spring."
Added a Kotlin-based build configuration with essential dependencies for a Spring Boot application.
Established the entry point for the Spring Boot application with a new application class.
Configured application properties for better management within the Spring ecosystem.
Created a test class to ensure the application context loads successfully.

Documentation

Enhanced README.md with detailed project objectives and structure.

The features mentioned are part of the initial setup created by start.spring.io, and were not developed by me. Could you please revise the summary?

Create a new project using Start Initializr(https://start.spring.io/).
Summary by CodeRabbit

New Features

Introduced a new .gitignore file to maintain a cleaner repository by excluding unnecessary files.
Updated the project branding and purpose in the README.md, now titled "coderabortory-spring."
Added a Kotlin-based build configuration with essential dependencies for a Spring Boot application.
Established the entry point for the Spring Boot application with a new application class.
Configured application properties for better management within the Spring ecosystem.
Created a test class to ensure the application context loads successfully.

Documentation

Enhanced README.md with detailed project objectives and structure.

The features mentioned are part of the initial setup created by start.spring.io, and were not developed by me. Could you please revise the summary?

@coderabbitai it would be better to remove all the bullet points. They seem to provide too many details. I think it’s sufficient to convey the intent clearly. If there’s nothing specific to mention about the initial project, there's no need for a separate summary.

@coderabbitai I appreciate it. Could you update the summary in the body of my first PR with the revised summary?

@coderabbitai Very nice! Would you revise the content


Space_Invader

Hi, thanks for the contribution, unfortunately your game is showing error on launch:
pygame 2.1.2 (SDL 2.0.18, Python 3.9.7)
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "/Users/sparsh/Code/python/py-games/src/space_invader/main.py", line 17, in <module>
    BULLET_HIT_SOUND = pygame.mixer.Sound('Assets/Grenade+1.mp3')
FileNotFoundError: No file 'Assets/Grenade+1.mp3' found in working directory '/Users/sparsh/Code/python/py-games/src/space_invader'.

You can push your fixing commit on the same branch and it should update this PR as well.

Can i make another pull request and i will update everything of this game

As you wish but you can update without making new one too

Actually this is my first time doing this so I don't know how to update this.


decouple from Logging ,and  change minimum iOS version  from 14.0 to 13.0

Thank to the author for making this project!
Logging is the perfect usecase for Swift Macro,  and this project is the only one I can find by now.
we can  make StaticLogger comparable to iOS 13 by switch to os_log
Swift Macro: minimum iOS 13
Logger:  minimum iOS 14
os_log: minimum iOS 10

@dazuiba os_log is deprecated now


Adds packer for kubespray base AMI building

Awesome feedback @ketzacoatl :+1:
I've addressed all of the above so I'm merging.


CSI amplitudes

Hello.
I have successfully obtained the CSI signal. But as in this question "https://githubmemory.com/repo/StevenMHernandez/ESP32-CSI-Tool/issues/23"
CSI is in one cell with real and imaginary parts .
So how can I get all amplitudes from real and imaginary parts? I know I can calculate the absolute value, but I don't know how to do it because they are in one cell. I would like to automatically determine the amplitude from a csv file and graph it.
Sorry for my bad English, English is not my native language.

#23

I found that I could just run parse_csi.py. However, it seems that windows does not allow me to run it, so I have to start anew and run it again.


Problem with new Django release

Could not find a version that matches Django<1.12,==2.0,>=1.2,>=1.3,>=1.4,>=1.5,>=1.8

What Django version is installed?
django-hijack and django-hijack-admin have no official support for Django 2.0 yet.

Yes. Django 2.0. Will be supported or only LTS versions are supported?

Absolutely not. We are aiming to support Django 2.0 ASAP. See https://github.com/arteria/django-hijack/issues/149

Thank you!


num_steps of training for those demo sample?

Hi,
This repo is really great. May I ask the number of training steps (with batch_size 32) required for your demo samples? Given the amount of training data used here (around 26 hours recordings), I guess the 100k num_steps as provided in the config.json is not enough, right?
Many thanks!

Hi @bayesrule,
Thanks! The audio on the demo page is generated with the pretrained model I uploaded which was only trained for 100k steps. I was also surprised by how quickly it trains. You get intelligible samples by 20k steps and decent results by 60k-80k steps.
I've noticed that generated audio for the out-of-domain speakers are a bit noisy. I'm not sure if longer training times would help with that or if it is a limitation with the ZeroSpeech dataset (which is pretty noisy).

Hi @bshall,

I was also surprised by how quickly it trains.
Could you share some data points w.r.t. absolute training time vs. corpus size and hardware used?
Im building a TTS prototype based on Tacotron and am looking for a vocoder with better quality than GL but less training effort than required e.g. by Wavenet.
Thanks!

Hi @te0006
I share my results.
I am grad if it is good for you.
https://tarepan.github.io/UniversalVocoding/
Dataset: total 10 hours utterances
Machine: Google Colab T4
others: in GitHub Pages
In my impression, RNN_MS is surprisingly fast and robust.

Hello, thanks for replying so quickly.
For such a short training run (5hrs/60ksteps) your results certainly sound impressive.
I think training time is often neglected in publications even though it is critically important for people looking to integrate/adapt a method, where you want to be able to try and fiddle with parameters without prohibitive computational cost.
BTW your last, English sound example seems to exhibit considerably more noise and distortion than the Japanese ones (but perhaps, not speaking the language and thus not being used to hearing it, I simply cannot hear the artifacts in the Japanese examples).
Do you already have experience w.r.t how far (and how fast) the speech quality improves with more training time?

Many reproducible experiments (including this repository) kindly give information of training time. I agree with you and hope papers itself give the information too.
Your hearing is correct.
Out of domain En utterance is more noisy.
In my opinion, it is because of language difference.
English coutain phonemes which are not in Japanese.
Not yet, but I will.


Orphaned Payload

Hi big fan of the project, it looks to me like a payload with id 5fe3c02fb3467846b324218f appears to have no valid launch associated with it.
Not found when visiting its associated launch

Ah, that was from a postponed launch, should be removed now 👍


Make a "latest" tag for docker

Releases will be tagged with latest, every commit for now is tagged with master


Fix for flaky tests in JSEditorComment_spec.js

Description

Fixed JSEditorComment_spec.js

Type of change

Flaky test fix

How Has This Been Tested?

Cypress

Checklist:
QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=7461f11

/ok-to-test sha=234e623

/ok-to-test sha=71ea951


Upgrade to rust-secp256k1 0.21 once released

The 0.21 release will include https://github.com/rust-bitcoin/rust-secp256k1/pull/326 which is required for interoperability with the ThirtyTwoByteHash trait. In order to use rust-secp256k1-zkp in a project together with rust-secp256k1 0.21, we will need to bump the version we are depending on and release a new version as well.

Looks like we have a release: https://github.com/rust-bitcoin/rust-secp256k1/pull/347

We need to do a point release (probably today) beacuse we added a new type but forgot to export it publicly.

Yeah I saw that. Shouldn't matter much for this repository though because we don't pin the version to the patch release so I am going to go ahead and prepare a patch to bump to 0.21.


Using package

Hi there!
I'm trying to use etherscan-python in my project. For that, I installed it through pip by using pip install etherscan-python.
Then when I try to import it
from etherscan import Etherscan
eth = Etherscan('mykey')
It throws:
FileNotFoundError: Package has no location <module 'etherscan.configs' (namespace)>
Any suggestion?
Thank you in advance!

Hi, issue verified and I am working on a fix. Please git clone and install from source by running pip install . as a quick fix (and not via PyPI). Thanks!

@julianlen the issue should now be solved, kindly let me know if everything works ok after pip installing the new v2.0.2.


Parallax scrolling of image on main page is rough

I've noticed that the image used in parallax scrolling on the main page seems to jump a little bit when scrolling (as if being repositioned). Need to investigate the issue. Maybe if I can move from the tag <img> to the CSS property background-image with background-size set to cover it will handle size changes more easily.

Especially on mobile devices (Nexus 5X)

@eduncan911, sounds like a good idea. Would you like to open a PR? I won't be able to get to this until the weekend, otherwise.

Once I start using this skin, absolutely!  And to resolve a number of other issues.


update dependencies (cargo update)

Build failed on nightly rust due to:
error[E0635]: unknown feature proc_macro_span_shrink
--> /Users/xxchan/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-be2141875385cea5/proc-macro2-1.0.56/src/lib.rs:92:30
|
92 |     feature(proc_macro_span, proc_macro_span_shrink)
|

This has been in 4da1bd7, thanks for the reminder!


Stonks Server (standalone application + remote service)

Resolves #28
This PR aims to add Stonks Server to sync market data between multiple game server instances.
Packets
The packet thing is pretty simple: 4 bytes for contentLength, which is a signed integer (signed because this is Java), followed by a sequence of bytes with contentLength length.
Inside the content, we have the ID of the message type, which is 2 bytes for stringLength, followed by a sequence of bytes. After that, we have the message content.
Messages
Will be added to documentations.

You might have noticed Stonks Server also have "client" subcommand. This command allows users to connect to Stonks Server and make service calls, without having to start a game server.


[invite] Fix error being logged for empty comments

When the comment field is empty, GitHub sets it to null, which results in an error when trying to parse macros. This has no impact except logging errors since empty comments obviously contain no macros. This PR aborts trying to process a comment if it's empty.

test comment


Have snakebite HDFS client fallback to HADOOP_USER_NAME from env

It turns out that the HADOOP_USER_NAME environment variable propagates nicely to the hadoop jar and hdfs dfs invocations that luigi triggers but the same is not true for the in proc snakebite client.
The attached patch rectifies this, provided that effective_user is not explicitly set in configuration.

:+1:

lgtm although if config is set then I think we should set the env variables.
i.e. if you don't want to use environment variables you shouldnt' have to

Can you add a parameter description saying that the default value is not a constant, it is what is in your $HADOOP_USER_NAME?

also would prefer if we don't fetch this on startup but when needed (i.e. pull from env dynamically)
otherwise i think it will try to pull it when building documentation etc
but no biggie

Ah true. It could be put in the code where it's actually used, or there could be a def get_effective_user(): helper function

I have tried to have the default of effective user to be set to something other than None in the documentation generation without luck (i.e. HADOOP_USER_NAME=some_name tox -e docs). Because of this I think it makes sense to keep getenv in the Parameter constructor call. I did update the documentation though to reflect behaviour.

(As the snakebite client is lazily constructed but kept between usages, the semantics of getting the environment variable after the fact would not change but setting default in config.py is a more straight forward approach IMHO)
ping @Tarrasch @erikbern for re-review.

I'm not sure I understand. Did you add any documentation? The patch seems to only contain a one line code. :)

@Tarrasch I did push a new ref but it did not contain any differences compared to the old one, with the actual documentation update resting safely on my laptop. Silly me. This time I actually looked at the change in the github UI :)

LGTM.


Bazel java_verifier_test: implement dependent tests [phab:D196]

Created by schroederc at 2015-04-16 21:39:32:

schroederc wrote at 2015-04-16 22:19:19:
Use tools/jdk/jdk/bin/javac instead of binary found on PATH

zarko accepted this revision at 2015-04-16 22:22:17

schroederc closed via commit 49906610a28c583f6c91a59c82832ea7e06d3044 at 2015-04-16 22:31:33


WPF / .Net Forms

Hello,
Does WinAppDriver support WFP / .Net Forms / MSAA ui automation? (using ui automation under the hood perhaps).
Thanks

Yes, please let us know if you run into any trouble.  WinAppDriver does use UI Automation API's under the hood.
Thanks!

Many thanks for the reply, and hats off to Microsoft for this!


Streams can't be defined

When using it with the following config I have TypeError: 'in <string>' requires string as left operand, not dict
source:
  docker_image: "airbyte/source-github" # GENERATED | string | A Public Docker Airbyte Source. Example: `airbyte/source-faker:0.1.4`. (see connectors list at: "https://hub.docker.com/search?q=airbyte%2Fsource-" )
  config: # PREGENERATED | object | PLEASE UPDATE this pre-generated config by following the documentation https://docs.airbyte.com/integrations/sources/github
    credentials:
      personal_access_token: ${GITHUB_TOKEN} # SECRET (please store in environment variables) | REQUIRED | string | Log into GitHub and then generate a personal access token. To load balance your API quota consumption across multiple API tokens, input multiple tokens separated with ","
    repositories:
      - "ORG/REPO"
    start_date: "2023-10-09T00:00:00Z"
  streams: workflows_run
destination:
  connector: "print"
  config:
    buffer_size_max: 100
remote_runner:
  type: "cloud_run_job" # GENERATED | string | Runner Type. Must be one of ['direct', 'cloud_run_job']
  config: # PREGENERATED | object | PLEASE UPDATE this pre-generated config
    project:  # REQUIRED | string | GCP Project where cloud run job will be deployed
    region: "europe-west1" # REQUIRED | string | Region where cloud run job will be deployed
    service_account: "" # OPTIONAL | string | Service account email used bu Cloud Run Job. If empty default compute service account will be used

If you don't set streams it works, but requires to retrieve all data

Thanks 🙏 for raising this issue @griseau àd for being so reactive !!
Let me open my laptop and have a check

Fixed. Thanks @griseau !

Closing the issue


Outdated procedure?

Hi, for Skype for Business On-Prem the procedure seems to have changed to setup the Skype Consumer federation.
https://pic.lync.com is not valid anymore and instead one should use: https://support.microsoft.com/oas/. Got this info from O365 support:
Thank you for contacting PayOps CBO.  Our team is unable to assist with this request as it falls out of our scope as of 2/6/2018.   For O365 provisioning assistance, please raise a request with Customer Support at the link below:

https://support.office.com/en-us/article/Contact-support-for-business-products-Admin-Help-32a17ca7-6fa0-4870-8a8d-e25ba4ccfd4b?ui=en-US&rs=en-US&ad=US

If On Premise, please contact the below:

800.936.4900 - Professional
https://support.microsoft.com/oas/

We will now be closing this request.

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: 1210ada3-644f-fec5-f52e-9644008daf90
Version Independent ID: 10a6e831-e15e-cc4e-4c01-aedaed9a007c
Content: Deploy Skype Connectivity in Skype for Business Server 2015
Content Source: Skype/SfbServer/deploy/deploy-skype-connectivity.md
Service: unspecified
GitHub Login: @kenwith
Microsoft Alias: kenwith

@StessVictinus - thank you for reporting. This issue affects multiple cmdlet links so I will get these updated and report back. Thanks again for taking the time to make the docs better!

@StessVictinus - Did Microsoft support give you a new URI to use instead of the pic.lync.com that is referenced in the article? I am trying to get to the bottom of this one.

@StessVictinus - after investigating I think the link that was given was for you to open a support ticket with Microsoft and not the link to use as per the article states. If I am misunderstanding please re-open this ticket. I also have a number of threads open to validate any changes to the procedure in the article you referenced and anything I find I will update in article. Closing this out but feel free to re-open if I am wrong.


Fix version sort issue in version negotiation in get_version request.

REF: https://github.com/DMTF/libspdm/issues/125
Signed-off-by: Jiewen Yao<EMAIL_ADDRESS>

Looks good to me.


SR won't work on real world images

Hi, thanks for sharing this implementation.
I'm researching SR for real world cases - and get out of memory issues with an empty 16GB P100 GPU
2020-11-26 09:03:19.928246: W tensorflow/core/framework/cpu_allocator_impl.cc:81] Allocation of<PHONE_NUMBER> exceeds 10% of free system memory.
I've tested SR with 1200px and this crashes each time

hi, how much memory do you have in your GPU?
The number of this network is quite huge (34M) so that kind of big image will cause the OOM like that. If you have any idea on reducing the number or params, please feel free to make a pull request!

I have 16GB of GPU (P100)
The implementation here - https://github.com/swz30/MIRNet does work on such images - but the Super-Resolution output effect is not good compared to the input image.
Is Mirnet currently still the SoTa compared to "Deep Plug-and-Play Image Restoration"
https://github.com/cszn/DPIR
P.S - the link to Google Drive - for weights of the lighting model isn't correct.

let share to me the link to the image that you want to test. I will try with my machine.
And thank you for your contributions! :D

And about SOTA or not: I would say that depends on the number provided by the original paper. I was not able to reach the number stated in the paper anyway.

Thanks!
I tried with this image
https://i.ytimg.com/vi/agLZhd98Sus/maxresdefault.jpg


[DO NOT MERGE] Adding instance pools swagger

Instance pools
Adding a new instancePools.json swagger file and its examples.
Instance pools are a new deployment option for managed instances, enabling pre-provisioning of compute as a customer step. This enables customers to target managed instances in an instance pool and have predictable provisioning times.
This instancePools.json swagger file is hooked up with the basic CRUD operations for an instance pool.

Create an instance pool
List / Get an instance pool
Delete an instance pool

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

Automation for azure-sdk-for-go

@kpajdzik assigning this one to you for review, thanks!

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

Fixed typo in examples @nschonni .
Adding @jaredmoo to help with the review.

Note I don't plan on making updates to the README.md file just yet,
I intend on merging the instancePools json and its examples alone so we can deploy ARM Manifest and test instance pool CRUD in production using .NET SDK.

If you haven't taken a look at our new onboarding experience at OpenAPIHub, it's a convenient way to create your PR when you're copying from an existing API version or when you're editing your existing specs. If you have any feedback or questions, feel free to use the feedback button on top of the site for help. Thanks!

Taking a look at OpenAPIHub @kpajdzik, thanks 👍
Can you help me re-run the linter diff, not sure why it's breaking after I undid changes to README.md

Thanks for the reviews everyone.

@johnpaulkee, seems like it's signed off from ARM and our side as well. When do you want to merge it?
Also, if you're not aware, GitHub introduce Pull Request Drafts which are better solution than "[Do not merge]" tags in the title (they can't be merged by accident). More information: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Hey @kpajdzik, ready to merge :)
We probably won't add changes to README.md until a separate PR with changes to managedInstances.
Also, that's a cool new PR draft feature github added. Will use it next time.
Thanks! 👍

@johnpaulkee , Do you want me to merge it?

@johnpaulkee, If you need to release the new SDK, please create a request on the portal mentioned above (http://aka.ms/openapihub).


Sign in – Able to dismiss Onboarding modal when click on browser back button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
In Sign in page enter new Gmail account
When Onboarding modal appears click on browser back button

Expected Result:
Onboarding modal is present
Actual Result:
Onboarding modal disappears
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/a463e86e-280b-4fab-a537-9524d81653b8

View all open jobs on GitHub

We think that this bug might be related to #wave-collect

@filip-solecki Could you have a look into this in the morning please?

Should we call this NAB if we're ok waiting till morning for a resolution? 🤔

Agreed! Marking NAB!±

Me and @adamgrzybowski  are not able to reproduce it, did you try to clear Onyx data?

Asked in QA if they can repro this on mac too https://expensify.slack.com/archives/C9YU7BX5M/p1723547272644439 the video is from windows

https://github.com/user-attachments/assets/d2d566ba-28ce-4e46-8a16-59160f8a89e1
As you can see I can't reproduce it on my end. The difference I noticed in my and your case is that the URL with the report id shows briefly in your.
Not sure why this happens but I won't be able to debug this issue without reliable reproduction steps.
I can point you to this function https://github.com/Expensify/App/blob/c5feb89f9f02cfb303e86246408f40c4f5a23119/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts#L103-L118
I would guess this value const targetFocusedRoute = findFocusedRoute(action?.payload);  is wrong. Could you please check it with the debugger? Maybe I will see what is wrong

@kavimuru Were your reproduction steps on Mac any different than what is listed in the GH description?

This may be a race condition. It looks like the initial chat doesn't have time to load and break the behavior on my end.

I reached out to @kavimuru in Slack.

I asked for a retest in Slack but have not yet heard back.

I asked for a retest in Slack but have not yet heard back.

@deetergp can you link the thread when making these kind of references, just helps follow the breadcrumbs. Where are we at with this re-test?

Of course! This is where I asked previously https://expensify.slack.com/archives/C9YU7BX5M/p1724783266169849, but I think it got lost in the shuffle. Asked again here https://expensify.slack.com/archives/C9YU7BX5M/p1725431001409449

Not reproducible
https://github.com/user-attachments/assets/55d61b2d-79c1-44aa-bedd-3f411f4983c2

Cool, so then let's close this out @deetergp?


The buttons are not working

when we click on the buttons like on the footer designed by OS-CODE then it redirect to the home page , same like in our services section in Web design . If you want to fix that thing than assign to me I am GSSOC'23 contributor

Yes , go ahead @Rajatkumarbehera11


Feature/test

Pre-PR Checklist

[x] I added/updated relevant documentation.
[x] I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
[x] I squashed the repeated code commits.
[x] I signed the [CLA].
[x] I added/updated test cases to check the change I am making.
[x] All existing and new tests are passing.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9a9914c). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   72.64%
=========================================
  Files             ?       67
  Lines             ?     4537
  Branches          ?      558
=========================================
  Hits              ?     3296
  Misses            ?     1194
  Partials          ?       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Does ale conflict with asyncrun?

When run both ale and asyncrun, i encountered some error like this:

According to this image, we can know the error comes from ale.
When i stop ale, run asyncrun, everything is ok!
When i stop asyncrun, run ale, everything is ok!
Only if run both ale and asyncrun, some errors occur!

Is that the whole error message, or are there any lines above that? What's the output of :sign place  when you get the error? I can't find a variable named m in the ALE codebase.

After the error occurs,  i run :sign place. Then i get nothing.

Is it possible that the error is what ale detects in asyncrun's code?

I'm sure either ale or asyncrun run on my computer alone is always well. But when the both run, some error occur!

Thank you for your tests! I made some tests same as yours just now.

Create a new file, content is print('hello world')
Modify content to ssssssssprint('hello world'), and run :w to save the changes.
Some errors have been detected by ale.

Run :AsyncRun -raw python %. Output is the same as yours.

Run :w again, some errors occur!

My vimrc is the same as yours, but i haven't installed any other tools excepet for flake8.
" ale
let g:ale_echo_msg_format = '[%linter%]-[%severity%]-%s'

let g:ale_linters = {
\ 'javascript': ['eslint'],
\ 'python'    : ['flake8'],
\ 'coffeescript'    : ['coffee','coffeelint'],
\}

let g:ale_fixers = {
\ 'javascript': ['prettier', 'eslint'],
\ 'coffeescript'    : ['coffee','coffeelint'],
\}

let g:ale_sign_column_always = 0
let g:ale_lint_on_save = 1
let g:ale_fix_on_save = 1
let g:ale_lint_delay = 2000
let g:ale_lint_on_text_changed = 'never'
let g:ale_lint_on_enter = 0

let g:asyncrun_open = 6
let g:asyncrun_bell = 1

" asyncrun
let $PYTHONUNBUFFERED=1

augroup MyGroup
    autocmd User AsyncRunStart call asyncrun#quickfix_toggle(8, 1)
augroup END

noremap <F9> :call asyncrun#quickfix_toggle(8)<CR>

Can you help me? I have spent three days on solving the problem. Thank you very much!
My vim is gvim 8.1/windows 10 too.

This is output from :sign place so @w0rp may help to look into this issue, I can :w successfully, there's no error. I can't find var m in codebase either. To extend possibilities: I use gvim downloaded from here:

@tuyenpm9
Thank you for your answer!
I configured ale by the next 3 steps

Add Plug 'w0rp/ale' in my vimrc
Enter vim, and run PlugInstall
Run pip install flake8 in windows 10's cmd.

Is there lack of some essential steps? I'm afraid ale isn't configured correctely in my computer.

No one could ever reproduce this issue, so I'm closing this.


OSTree based images add the ssh key for the root user to the wrong HOME

When you create an Edge type of image (or any ostree based image) and you add a ssh key for the root user, osbuild puts the key in the wrong directory.
Here is an example of the content of an image created with osbuild-composer, but looking at the code, it should have the same issue building directly with the osbuild:
[root@vm ~]# echo $HOME
/root
[root@vm ~]# pwd
/root
[root@vm ~]# ls -a
.  ..  .cache
[root@vm ~]# ls -l /
total 20
lrwxrwxrwx.   2 root root    7 Oct  4 16:41 bin -> usr/bin
drwxr-xr-x.   6 root root   86 Oct  4 16:42 boot
drwxr-xr-x.  16 root root 2720 Oct  4 20:00 dev
drwxr-xr-x. 104 root root 8192 Oct  4 20:00 etc
lrwxrwxrwx.   2 root root    8 Oct  4 16:41 home -> var/home
lrwxrwxrwx.   3 root root    7 Oct  4 16:41 lib -> usr/lib
lrwxrwxrwx.   3 root root    9 Oct  4 16:41 lib64 -> usr/lib64
lrwxrwxrwx.   2 root root    9 Oct  4 16:41 media -> run/media
lrwxrwxrwx.   2 root root    7 Oct  4 16:41 mnt -> var/mnt
lrwxrwxrwx.   2 root root    7 Oct  4 16:41 opt -> var/opt
lrwxrwxrwx.   2 root root   14 Oct  4 16:41 ostree -> sysroot/ostree
dr-xr-xr-x. 129 root root    0 Dec 31  1969 proc
lrwxrwxrwx.   2 root root   12 Oct  4 16:41 root -> var/roothome
drwxr-xr-x.  34 root root  840 Oct  4 20:00 run
lrwxrwxrwx.   2 root root    8 Oct  4 16:41 sbin -> usr/sbin
lrwxrwxrwx.   2 root root    7 Oct  4 16:41 srv -> var/srv
dr-xr-xr-x.  12 root root    0 Oct  4 20:00 sys
drwxr-xr-x.   5 root root   43 Oct  4 16:42 sysroot
drwxrwxrwt.  11 root root 4096 Oct  4 20:01 tmp
drwxr-xr-x.  12 root root  155 Dec 31  1969 usr
drwxr-xr-x.  24 root root 4096 Oct  4 19:26 var
[root@vm ~]# ls -l /var/home/root/.ssh/authorized_keys
-rw-r--r--. 1 root root 381 Oct  4 19:26 /var/home/root/.ssh/authorized_keys

At the OSTree based images, the root's HOME is at /root, which is a link to /var/roothome, but the osbuild adds the key to a directory called root inside the directory where the normal users are: /var/home/.
Here is the blueprint used for this image: https://gitlab.com/redhat/edge/ci-cd/manifests/-/blob/composer-with-raw-image/ci/files/blueprint.toml#L239

The problem is that we dont special case the root user:
https://github.com/osbuild/osbuild-composer/blob/e76543d7792db7d0085be902333e8b8765f462e0/internal/distro/rhel85/stage_options.go#L90

The problem is that we dont special case the root user:
https://github.com/osbuild/osbuild-composer/blob/e76543d7792db7d0085be902333e8b8765f462e0/internal/distro/rhel85/stage_options.go#L90

Oh, I see. Would the error affect the images created using the osbuild + a manifest?
I mean, this is composer code, if the problem is just here, it shouldn't, but I wonder if the other side (osbuild) might have similar issue. I guess it's a non very common use case.

Oh, I see. Would the error affect the images created using the osbuild + a manifest?

If you design your own manifest you could craft the first-boot stage that is being used here in the correct way. So no. This is a defect in the composer code, I am afraid.


New Taskbar Icon Suggestion

Describe the bug
The Motrix icon on the taskbar is small; and for presenting various details in your drawing, is not something pleasant to visualize.
I suggest you create a new (simpler) icon. Showing the percentage (in color) of the completed download.
Screenshots

Environment (please complete the following information):

Deepin 15.10.2 Lion
Motrix 1.4.1 (AppImage)

This is the system tray icon used by the macOS version of Motrix. Is it OK to change the Linux version to this icon?
https://raw.githubusercontent.com/agalwood/Motrix/master/static/mo-tray-dark-normal%402x.png
https://raw.githubusercontent.com/agalwood/Motrix/master/static/mo-tray-dark-active%402x.png
It is a bit difficult to develop "show download progress in the system tray icon".

The important thing is to change the icon (if possible). The progress bar - personally - I see no use (it's just perfumery).
These macOS icons do not resemble Motrix; who knows, my suggestion of icon might help.


⚠ Turnos 24x7 has degraded performance

In 8a59a56, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 888 ms

Resolved: Turnos 24x7 performance has improved in 8d097d2.


Reorganize and drop unused external declarations. See issue #3321

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rdkservices/3325/rdkcentral/rdkservices

Commit:<PHONE_NUMBER>b54e80e1b50127e22db34a25db3c65

Report detail: gist


Line Chart - Add Custom Segment Value in Y-Axis #328

Currently we can define number of segments in Y-axis by using the property "segments". But, the segment values are auto generated from the values of Y-axis. Can we define segment values on our own. For example I want the Y-axis values will be 1000, 5000, 10000, 15000 etc.

Hi, Did you find any solution for this need ? Thanks

I am also looking for a solution on this. Any idea? Somebody?


Cry-Alchemy Plugin

Description
Replaces the default high and low level alchemy animations with the cry animation, keeps the alch gfx but raises it a little to meet with head in hands.
First attempt at a simple plugin inspired by dance party, testing the waters a little here.
Screencap

Can this be added to animationtransmog?


Refactor EnforceLineLength

Pull Request Test Coverage Report for Build 2663d4ef62be61ccde6d20cf1eb7bfa343a1efe0-PR-45

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.164%

Totals

Change from base Build b326d8e1fa2f58172001e9c39be80a08c74b3a6f:
0.0%

Covered Lines:
550

Relevant Lines:
610

💛  - Coveralls


Tags

Bart is looking pretty good. :) In blog.hbs I added:
{{#each page.head.tags}}
  {{this}}
{{/each}}

and styled it via .blog-post-meta a.tags { .. }
I have two issues to resolve with tags:

I would like a side bar listing the tags. I would like them sorted by Number of Occurrences and then Latest date. If a tag is listed twice last year, it will be listed before a tag with one occurrence from yesterday. If two tags have the same number of occurrences, the one with the newest post date should be first. I believe this should be done with a rhai script similar to date sorting via blogs.rhai

In my old CMS, Grav, the link from ie the tag for bash linked to /tags:bash. This page should be similar to the blog listing but filter the tag for bash. What would be the best way to handle this?

Thanks!

I am glad to hear that bartholomew is working well for you. I will add the structure for the basic tagging system into the template when I get the change later this week or the next but in the meantime, here is how I would accomplish the above requirements.

For you question about generating tags on the side bar, you are correct in assuming that you would need rhai scripts. Here is a starting point for it:

// Param 1 should be `site.pages`
let pages = params[0];

let tags = [];
let keys = pages.keys();
for item in keys {
    if item.index_of("/content/blog/") == 0 {
        let path = item.sub_string(8);
        let page = pages[item];
        for tag in page.head.tags {
            if !tags.contains(tag) {
                tags.push(tag);
            }
        }
    }
}

tags

This script gathers all the tags listed in the blog posts. It does not currently sort them. To that you would need to use a hashmap that indexes based on the tag and has data such as the latest date and then a count of times it has appeared.

For achieving this, I think the current best way is to use query parameters. I would change the link on you implementation of tags in the snippet you provided to be something like

{{this}}

then create a new file at content/tag.md with the following contents
title = "tags"
description = "A page that filters blog post based on content"
template = "tag"
date = "2021-12-23T17:05:19Z"
---

Then add a new template in templates/tag.hbs with the following content
{{> content_top }}

Showing articles tagged with "{{url_query_params request.spin-full-url "selected_tag" ""}}"

    {{#each (tagged_pages site.pages (url_query_params request.spin-full-url "selected" ""))}}

{{page.head.title}}

                {{#if page.head.date }}{{date_format ../site.info.extra.date_style page.head.date}} {{/if}}
                {{#if page.head.extra.author}} by {{page.head.extra.author}}{{/if}}

            {{! Since this is HTML, we use the triple-curly }}
            {{{truncate_post page.body}}}

View the Post

    {{/each}}

{{> content_sidebar }}
{{> content_bottom }}

You would need to add the tag template to the list of templates that get access to the entire site's file structure by changing the value of index_site_pages in config/site.toml to the following
index_site_pages = ["blog", "tag"]

You would also need to add the 2 following scripts
tagged_pages.rhai
// This function lists all pages that are tagged with the given tag.
//
// It returns an array of objects of the form:
//  [
//    #{ uri: "path/to/page", page: PageObject, weight: int }
// ]

// Param 1 should be `site.pages`
let pages = params[0];

// Param 2 should be the tag name
let tag = params[1];

// Loop through them and return all of the page objects that are in
// the blog path.
let tagged_pages = [];

// Get each blog post, assigning it to {path: object}.
let keys = pages.keys();
for item in keys {
    // Remove /content
    if item.index_of("/content/blog/") == 0 && pages[item].head.extra.type == "post" {
        let path = item.sub_string(8);
        let page = pages[item];

        if page.head.tags.len == 0 {
            continue;
        }

        let index = 0;
        let tag_index = -1;
        for element in page.head.tags {
            if (element == tag) {
                tag_index = index;
            }
            index = index + 1;
        }
        if tag_index >= 0 {
            // Remove .md
            path = path.sub_string(0, path.index_of(".md"));
            tagged_pages.push(#{
                uri: path,
                page: page,
                weight: tag_index,
                tags: page.head.tags
            });
        }
    }
}

// Return the matches, sorted by weight
fn sort_by_weight(a, b) {
    if a.weight < b.weight {
        -1
    } else {
        1
    }
}

// Sort by how close to the front of the tag list a given tag was.
tagged_pages.sort(Fn("sort_by_weight"));

tagged_pages

url_query_params.rhai
let full_url = params[0];
let string2match = params[1];
let defaut_value = params[2];
let query_params = #{page: defaut_value};
let query_string;
let query_param;

if full_url.contains("?") {
    // Get the query string
    query_string = full_url.sub_string(full_url.index_of("?") + 1);
    do {
        // Seperate by parameters
        if query_string.contains("&") {
            query_param = query_string.sub_string(0, query_string.index_of("&"));
            query_string = query_string.sub_string(query_string.index_of("&") + 1);
        } else {
            query_param = query_string;
            query_string.clear();
        }
        // set the page parameter to the value from the url
        if query_param.sub_string(0, query_param.index_of("=")) == string2match {
            try {
            query_params.page = query_param.sub_string(query_param.index_of("=") + 1);
            } catch {
                query_params.page = defaut_value;
            }
        }
    } while ( query_string.len() > 0)
}

query_params.page.replace("%20", " ");

// Return the query_params
query_params.page

Hope this helps!

Hi @mabushey
Is this issue able to be closed now? Is there anything else that you need help with regarding this issue?
Thanks so much
Tim