Add a Codacy badge to README.rst

Coverage remained the same at 80.944% when pulling ebb5b87dfc92bec62b0a729417446ebd2e173c02 on codacy-badger:codacy-badge into 925018b2f0ceb82c0653048458905c99ba2d4a51 on MicroPyramid:master.


[breaking] use devalue to (de)serialize action data

This is a breaking change for everyone who fetches the actions directly and doesn't go through use:enhance (so hopefully close to noone).
+ import { parse } from 'devalue';

const response = await fetch(action, {
	method: 'POST',
	headers: {
		accept: 'application/json',
		'x-sveltekit-action': 'true'
	},
	cache: 'no-store',
	body: data,
});

result = await response.json();
+ if (result.data) {
+ 	result.data = devalue.parse(result.data);
+ }

Allows for Date objects and more be part of the response
Closes #7488
Draft because we first need to decide if we really want this, and if we do, I need to update the types. The public type should stay the same, but we need to adjust the usages and accomodate for the fact that data is a string until parsed.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Should SK expose devalue somewhere (or maybe just its parser function)? That would make sure people wouldn't be on a different version, duplicating it in their project. It would mean we could have changes in the serialization format without it being a breaking change. And it would just be one fewer dependency for people to install if they were doing this.
That said, I don't have particularly strong feelings about whether we want to be switching to devalue in the first place.

If we go down this road then yes, definitely — probably via $app/forms since that's the only place you'd need this. We could just re-export the unflatten function from devalue (perhaps with a different name if we don't like that one?)

Thinking ahead, with the current system in place we can adjust the code so that it's possible for people to provide their own (de)serializer, therefore an import location that is more generic would be better. If we agree on adding something like this in the future (or reserving the right to do so), then we probably need $app/something-new because it doesn't fit in any of the existing ones.

$app/serde
$app/data
?

provide their own (de)serializer

Do you mean make it so that devalue can be replaced entirely by the user or that the user can add their own (de)serializers to devalue from sk. Either way, I can see uses for, but I don't think either are super necessary in the short-term.

I'd vote for $app/data over $app/serde, since a lot of people aren't familiar with that term, and data is more generic and therefore future-proof.

Do you mean make it so that devalue can be replaced entirely by the user or that the user can add their own (de)serializers to devalue from sk

Would probably mean adding custom (de)serialisation to devalue. Need to establish whether there's sufficient demand first

I added $app/data - but I realized in the process that it's not that easy usage-wise. To deserialize the action response, you have to do const result = await result.json() and then result.data = devalue.parse(result.data) - similar things for the load response from the server. Furthermore, I'm now wondering where outside of form actions you would need to explicitly deserialize stuff - for load, that's all handled under the hood. This is not possible to encapsulate in a generic manner in a (de)serialize function. Also, when would you want to serialize something yourself? At this point you're doing custom stuff anyway.
So an export from $app/forms is probably better after all? -> switching the implementation to do that instead (we can revert that commit if we want a more general location).

the hell is windows doing

seems this worked, but now there's an error with the sharp package, maybe due to the bumping of the patch dependencies..? Redeploying without cache works, so it's likely a missing postinstall script running or sth


Firestore plugin: support for merge:true in setData()

From the Firestore docs:

If the document does exist, its contents will be overwritten with the newly provided data, unless you specify that the data should be merged into the existing document, as follows:

https://firebase.google.com/docs/firestore/manage-data/add-data#set_a_document
var cityRef = db.collection('cities').doc('BJ');

var setWithMerge = cityRef.set({
    capital: true
}, { merge: true });

Please add this feature to Flutter's Firestore plugin.

https://github.com/flutter/plugins/commit/2b89c20924da181dd53f8ca4bdb79bca27823962
it was added 8 days ago.

Aha, sorry - I missed that!
Closing this issue then. Thanks @jonasbark


In Chapter 10, net.sci.gsfc.nasa.gov api has a ssl problem.

In Chapter 10, NASA Api has SSL Problem.
This code can solve ssl challenge.
closed: #4

@loinsir thanks so much ! I'll keep this open for a short while as I'll need to update the book text as well.


Build and push manifests for container images

We build and push images for various architectures, but are not
publishing a single manifest that can be used to look up the images.
test/images in main k/k repository and kube images in k/release already
publish manifests for all the image we need for e2e testing, so we
should do the same as the 2 images in this repository are part of the
conformance e2e test suite.
Bumping version numbers as well.
Change-Id: I5f87af9e5ad15da86b9e99bcb7a60a81870d0836

/assign @ixdy
/assign @ahmetb
/assign @mkumatag

related to comment from https://github.com/kubernetes/kubernetes/pull/66741#discussion_r207326942 by @ixdy

/lgtm
let me or @.ixdy know if we need to republish images.

@ahmetb yes, please publish the images, i have bumped the version numbers so we won't break anything (cross my fingers)

I hit an error: https://gist.github.com/ahmetb/f8fb3e2b8e605b364ba9ff788ed528fc
@ixdy will try too

@ahmetb @ixdy looks like missed a spot - https://github.com/kubernetes/examples/pull/258


Problem with [SRGSSR] extractor on newer videos; older (approx 1-month old) videos are OK

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.11.26
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

youtube-dl --verbose -F "https://tp.srgssr.ch/p/rsi/embed?urn=urn:rsi:video:13639072"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-F', 'https://tp.srgssr.ch/p/rsi/embed?urn=urn:rsi:video:13639072']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.11.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.1-2020-11-19-essentials_build-www.gyan.dev
[debug] Proxy map: {}
[SRGSSR] 13639072: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 502: Bad Gateway (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\extractor\common.py", line 632, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\YoutubeDL.py", line 2248, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default
Description

WRITE DESCRIPTION HERE
Please note that older videos posted on the same website are fine; see example below:
youtube-dl --verbose -F "https://tp.srgssr.ch/p/rsi/embed?urn=urn:rsi:video:13405488"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-F', 'https://tp.srgssr.ch/p/rsi/embed?urn=urn:rsi:video:13405488']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.11.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.1-2020-11-19-essentials_build-www.gyan.dev
[debug] Proxy map: {}
[SRGSSR] 13405488: Downloading JSON metadata
[SRGSSR] 13405488: Downloading HTTP-HDS-HD token
[SRGSSR] 13405488: Downloading f4m manifest
[SRGSSR] 13405488: Downloading HTTP-HDS-SD token
[SRGSSR] 13405488: Downloading f4m manifest
[SRGSSR] 13405488: Downloading HTTP-HLS-HD token
[SRGSSR] 13405488: Downloading m3u8 information
[SRGSSR] 13405488: Downloading HTTP-HLS-SD token
[SRGSSR] 13405488: Downloading m3u8 information
[info] Available formats for 13405488:
format code       extension  resolution note
HTTP-HLS-HD-351   mp4        480x272     351k , avc1.66.30, mp4a.40.2
HTTP-HLS-SD-351   mp4        480x272     351k , avc1.66.30, mp4a.40.2
HTTP-HLS-HD-931   mp4        640x360     931k , avc1.66.30, mp4a.40.2
HTTP-HLS-SD-931   mp4        640x360     931k , avc1.66.30, mp4a.40.2
HTTP-HLS-HD-3777  mp4        1280x720   3777k , avc1.64001f, mp4a.40.2
HTTP-HLS-SD-3777  mp4        1280x720   3777k , avc1.64001f, mp4a.40.2 (best)

for this link - https://tp.srgssr.ch/p/rsi/embed?urn=urn:rsi:video:13639072
play the video and press  F12 on your keyboard the debug menu opens,
select Network and type m3u8 in the search box, copy the file with the m3u8 in the file
and paste the link into youtube-dl.

It works! Thx!
youtube-dl --verbose -F "https://codww-vh.akamaihd.net/i/rsi/unrestricted/2020/11/27/b08cdc5ba4cffb98ba97737a753d2afa_20201127_212412_,360,272,.mp4.csmil/index_1_av.m3u8?start=0.0&end=4132.046"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-F', 'https://codww-vh.akamaihd.net/i/rsi/unrestricted/2020/11/27/b08cdc5ba4cffb98ba97737a753d2afa_20201127_212412_,360,272,.mp4.csmil/index_1_av.m3u8?start=0.0&end=4132.046']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.11.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.1-2020-11-19-essentials_build-www.gyan.dev
[debug] Proxy map: {}
[generic] index_1_av.m3u8?start=0.0&end=4132: Requesting header
WARNING: Could not send HEAD request to https://codww-vh.akamaihd.net/i/rsi/unrestricted/2020/11/27/b08cdc5ba4cffb98ba97737a753d2afa_20201127_212412_,360,272,.mp4.csmil/index_1_av.m3u8?start=0.0&end=4132.046: HTTP Error 405: Method Not Allowed
[generic] index_1_av.m3u8?start=0.0&end=4132: Downloading webpage
[generic] index_1_av.m3u8?start=0.0&end=4132: Downloading m3u8 information
[info] Available formats for index_1_av.m3u8?start=0.0&end=4132:
format code  extension  resolution note
0            mp4        unknown


remove util.Function. bump node engine version

Version 0.2.10 is actually not backward compatible. So first commit restore it.
Also, I've checked latest tests on all node versions from 0.8.6 to 0.5.0 and found that first compatible version is 0.9.3.

Published as version 0.2.11.


Using Federated Authentication with jsForce

Hello,
I would like to be able to send a SAML assertion to SFDC and receive a token to get a session Id.  Is this possible with jsForce?  If so, please show a sample that would allow it to work.
In addition, if there is any way to do a REST passthrough, where I build the POST and jsForce sends it on and passes back the response, that could work for me too.
Also, SSO is definitely working as I can login to the identity provider and go directly to salesforce.
Thanks in advance!
Scott

You mean 0Auth2 SAML bearer assertion flow ? If so, you can simply pass the SAML assertion to the token endpoint to fetch access token and instance url, and pass them to JSforce's Connection constructor options.

Thank you very much for your response!  I think we solved the problem -we are generating a SAML assertion within our node app and sending it to SFDC, and we are indeed getting a token and instance url.
Thanks again for the help!
Scott

@scromie @stomita
Would you be able to provide some quick guidance into how you are generating the SAML assertion? I have things working if I generate it through that Axiom interface and then using that assertion, but since its only valid quickly I can't use it again, which is why I assume you're generating a new one.
I guess the flow is then to make a POST  to generation the SAML assertion, then use that SAML assertion to post to the services/oauth2/token endpoint to give you the access_token and instance_url which you can then use moving forward from your app... Any help is appreciated, thanks!

@scromie Hello
I am trying to implement a SAML Bearer Assertion Flow within my app, same as you. Could you please give me more detail about how you generated the SAML Assertion within you node app ? I can't seem to be able to get my SAMLResponse after a successful authentication (I can see it on the Chrome Inspect but I can't get it on my Nodejs app).
Thanks !


GDScript: Fix wrong unsafety mark for binary operator

var a := 1
var b := 1 + a # should be safe

In #73291 it should have been ANNOTATED_INFERRED instead of ANNOTATED_EXPLICIT...
Closes #73951.

Thanks!


Socket.io timeout does nothing when there is JWT token available

@Creiger commented on Mon Dec 19 2016
Steps to reproduce
When the feathers server is not running and there is already a JWT token stored in client cookies, this function
app.authenticate().then(showApplication, showLogin);
never fires anything. It does not throw any error also. When i delete JWT token, showLogin function is fired.
Expected behavior
I think this should throw an error after socket.io timeout set in app configuration.
Actual behavior
Does nothing.

@marshallswain commented on Tue Jan 03 2017
Thanks @Creiger I'm moving this to the feathers-authentication-client repo.

This will also need fixing in the old feathers-authentication/client plugin.


Gremlin Java Client Demo no longer works

Connections through nlb with iam-auth and enable-ssl no longer works
timeouts during handshake.

Hi @jfassad  - thanks for reporting this. Can you tell me which region you were running in, and which Neptune engine version you are running? I'll then try and reproduce. Thanks, ian

Hello @iansrobinson . region is us-east-1 , neptune engine is <IP_ADDRESS>.R2
It appears the problem might be related to something in the AWS NLB .
I've replaced the NLB for a simpleproxy running in an EC2 instance and the problem went away.

@iansrobinson, I made another test. I've created a new NBL with TCP listener and it works. The problem happens only using NBL with a TLS listener.

I was able to reproduce this locally as well.
Neptune engine version - <IP_ADDRESS>
Region - us-west-2
We do not have a NLB and upgrading our gremlin library to 4.3.13 seems to have fixed the issue so far.
Exception below:
Caused by: org.apache.tinkerpop.gremlin.driver.exception.ConnectionException: Could not complete connection setup to the server. Ensure that SSL is correctly configured at both the client and the server. Ensure that client WebSocket handshake protocol matches the server. Ensure that the server is still reachable.
	at org.apache.tinkerpop.gremlin.driver.Channelizer$WebSocketChannelizer.connected(Channelizer.java:268) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at org.apache.tinkerpop.gremlin.driver.Connection.<init>(Connection.java:120) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at org.apache.tinkerpop.gremlin.driver.ConnectionPool.lambda$new$0(ConnectionPool.java:102) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at java.util.concurrent.CompletableFuture$AsyncRun.run$$$capture(CompletableFuture.java:1736) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
	... 3 more
Caused by: io.netty.handler.ssl.SslHandshakeTimeoutException: handshake timed out after 10000ms
	at io.netty.handler.ssl.SslHandler$7.run(SslHandler.java:2112) ~[netty-handler-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:170) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute$$$capture(AbstractEventExecutor.java:164) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:503) ~[netty-transport-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	... 1 more

I was able to reproduce this locally as well.
Neptune engine version - <IP_ADDRESS> Region - us-west-2
We do not have a NLB and upgrading our gremlin library to 4.3.13 seems to have fixed the issue so far.
Exception below:
Caused by: org.apache.tinkerpop.gremlin.driver.exception.ConnectionException: Could not complete connection setup to the server. Ensure that SSL is correctly configured at both the client and the server. Ensure that client WebSocket handshake protocol matches the server. Ensure that the server is still reachable.
	at org.apache.tinkerpop.gremlin.driver.Channelizer$WebSocketChannelizer.connected(Channelizer.java:268) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at org.apache.tinkerpop.gremlin.driver.Connection.<init>(Connection.java:120) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at org.apache.tinkerpop.gremlin.driver.ConnectionPool.lambda$new$0(ConnectionPool.java:102) ~[gremlin-driver-3.4.11.jar:3.4.11]
	at java.util.concurrent.CompletableFuture$AsyncRun.run$$$capture(CompletableFuture.java:1736) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
	... 3 more
Caused by: io.netty.handler.ssl.SslHandshakeTimeoutException: handshake timed out after 10000ms
	at io.netty.handler.ssl.SslHandler$7.run(SslHandler.java:2112) ~[netty-handler-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:170) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute$$$capture(AbstractEventExecutor.java:164) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:503) ~[netty-transport-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.72.Final.jar:4.1.72.Final]
	... 1 more

I believe you meant version 3.4.13 instead of 4.3.13 and, either way, the problem still lingers. Plus, the timeout is from netty and is untouchable. Any other timeouts (even the 15s one) don't mean much, because the netty 10s timeout takes place.
Anyway, this problem is still happening now and it doesn't matter if we're using NLB, simpleproxy or anything else. It seems to happen randomly, with a higher rate of not completing the handshake.


Confusing ensureNullTerminated in NSDataBigString

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
There is an expensive copy operation for data buffer when loading and parsing JS Bundle in RN.  In my case, I have a 4.8 MB JS bundle. The instrument shows it takes 15.81 MB in NSData mutableCopyWithZone,  which happens in  ensureNullTerminated in NSDataBigString.

I followed the backtrace showing in the instrument. Saw that the brief process for RCTBridge loading JS bundle is like this:

Initially, I thought it has to treat data buffer in a contiguous region of memory as a null-terminated byte string (NTBS) .  In Objective-C, NSData is an immutable object. In order to add the Null byte, firstly, it has to copy the original immutable NSData object and construct a mutable object.
But when I deleted these mutable copy and return the data directedly. Seems my app works fine. So does the RNTester .
So I am confused now:

Is this code necessary? What is it for?
If it is necessary,  why doesn't the RN packager add Null to the bundle as its last byte to align the behavior of iOS lib?
Does Android have a similar process to copy bundle?

React Native version:
Run react-native info in your terminal and copy the results here.
react-native: v0.63.3
device: iPhone 5s
OS version: 12.4.8
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

open RNTester in react-native repo. react-native/packages/rn-tester
find ensureNullTerminated  and set a breakpoint there
run the RNTester

Expected Results
Describe what you expected to happen.

remove this expensive copy operation or show us a way to avoid it, like building a JS bundle and add Null previously

Snack, code example, screenshot, or link to a repository:

Really interesting finding, let me try to surface this to the FB team 👍
(and sorry, I'm just finding out about this now)

Interesting find!!
How do we know that creating a mutable copy is expensive?
Using the instruments memory profiler is probably not the tool we'd need here. Creating a copy and appending null shouldn't take up more space unless both data objects are retained. (Are they?)
We'd probably want to use the time profiler and measure the current impl vs. replacing m_data = ensureNullTerminated(data); with m_data = data;

Using the instruments memory profiler is probably not the tool we'd need here. Creating a copy and appending null shouldn't take up more space unless both data objects are retained. (Are they?)

Yes. Both data object actually are different kinds of Class; different objects.

The copied data object is about   5058038 bytes when using Xcode debugger to check it.
(lldb) frame variable data
(NSConcreteMutableData *) data = 0x0000600003a35fe0 5058038 bytes

Env:

device: iPhone X
iOS 14.0
Xcode Version 12.4
Project:
rn-tester
building scheme:

Debug.
I tried to use release build, source is nill in this function in release build in rn-tester.

bundle size: about  4.8 MB
For the time cost, I actually add some code to measure the diff

static NSData *ensureNullTerminated(NSData *source)
{
  if (!source || source.length == 0) {
    return nil;
  }

  NSUInteger sourceLength = source.length;
  unsigned char lastByte;
  [source getBytes:&lastByte range:NSMakeRange(sourceLength - 1, 1)];

  // TODO: bundles from the packager should always include a NULL byte
  // or we should we relax this requirement and only read as much from the
  // buffer as length indicates
  if (lastByte == '\0') {
    return source;
  } else {
    struct timeval val;
    gettimeofday(&val, NULL);
    int32_t t = val.tv_sec * 1000000 + val.tv_usec;

    NSMutableData *data = [source mutableCopy];
    unsigned char nullByte = '\0';
    [data appendBytes:&nullByte length:1];

    struct timeval tv;
    gettimeofday(&tv, NULL);
    int32_t t2 = tv.tv_sec * 1000000 + tv.tv_usec;
    printf("[ry]  copy diff %d \n", t2 - t);

    return data;
  }
}

Num
time diff (micro second)

1
1636

2
1351

3
5238

4
1249

5
2082

I tried to use release build, source is nill in this function in release build in rn-tester

Interesting. I took a quick look at the bridge and had thought that this codepath would get hit in release build, but I never tested anything.
If this only affects debug builds, probably not worth worrying about, right?

I tried to use release build, source is nill in this function in release build in rn-tester

Interesting. I took a quick look at the bridge and had thought that this codepath would get hit in release build, but I never tested anything.
If this only affects debug builds, probably not worth worrying about, right?

Hi, my bad. tried again. will hit  ensureNullTerminated rn-tester .

So the impact is

this copy operation will create a tmp object to obtain mutable data  to append \0 . The memory cost of the object is related to the js bundle size.
time cost looks like minor according to the tests i made.

To my understanding,  ensuring null seems make no sense here.

You got size of the data in  NSDataBigString

In evaluateJavaScript phase,  you will convert NSDataBigString
to  BigStringBuffer; got its valid size

the final JSStringRef to JSEvaluateScript also uses the size

Please correct me if i am wrong


Add to Space Wizard: Import repositories to use multi-selection

if we change the back end to use multi-selection the UI (UISelectMany) the UI is much slicker and lets folks pick the repos they want to import using multi-selection and filtering - which also avoids accidentally importing all of them too :)

the problem is the Next step then sends no selections for the gitReposityPatterns property so we can't implement the wizard on the server side.

so we need to tweak the UI to handle this one

I tried a quick debug and I never saw any of the methods in this controller being triggered to change the values
https://github.com/jstrachan/fabric8-ui/blob/4fbc302e1e0f922b1c14b4022d921f80df9c5c53/src/app/space-wizard/components/app-generator-multiple-selection-label-list/app-generator-multiple-selection-label-list.component.ts#L20
then when I clicked Next I ended up in gotoNextStep() with a single field with no values. So seems somethings borked with the AppGeneratorMultipleSelectionLabelListComponent component


False positive warning about calling compute() before update()

🐛 Bug
I have an example using RunningMean that warns the user about calling compute() before update(), even though it isn't true.
To Reproduce
from torchmetrics.aggregation import RunningMean
import torch

metric = RunningMean(window=3)
metric.update(torch.tensor(2.))  # also happens if calling forward
print(metric.compute())

Output:
/home/adrian/.conda/envs/lit-gpt/lib/python3.10/site-packages/torchmetrics/utilities/prints.py:43: UserWarning: The ``compute`` method of metric MeanMetric was called before the ``update`` method which may lead to errors, as metric states have not yet been updated.
  warnings.warn(*args, **kwargs)  # noqa: B028
tensor(2.)

Expected behavior
No warning, because the order of update and compute is correct.
Environment

TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source): 1.2.1 (pip)
Python & PyTorch Version (e.g., 1.0): 3.10, 2.2.0.dev20231207+cu121
Any other relevant information such as OS (e.g., Linux): Linux

Additional context

Thanks @SkafteNicki, very nice!


Remove superfluous tx gas validation

What was wrong?
The transaction.validate() call in the next
line has exactly the same logic making this a
superfluous extra check.
https://github.com/ethereum/py-evm/blob/042cd4bc215d8567d560f43564dbee2aba5c970d/evm/rlp/transactions.py#L106-L113
How was it fixed?
Removed superfluous check
Cute Animal Picture

Also, the check in evm/rlp/transactions reads like a yoda condition

:joy: Are we talking yoda from star wars?
Just to make sure we mean the same thing. You (and I) would prefer the check to be:
if self.gas < self.intrinsic_gas:
    raise ValidationError("Insufficient gas")

@voith ha! It's a real thing!

Haha yup, that's the one! :)

"Intrinsic gas more than the transaction gas, this is" ~Yoda validating a transaction


not associating TLS canceled as a connection close

When running the tests against a server using TLS, it doesn't seem to be detecting the TCP connection closing:
Hypertext Transfer Protocol Version 2 (HTTP/2)
  5. Streams and Multiplexing
    5.4. Error Handling
      5.4.1. Connection Error Handling
             [send] SETTINGS Frame (length:6, flags:0x00, stream_id:0)
             [recv] SETTINGS Frame (length:0, flags:0x00, stream_id:0)
             [send] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
             [recv] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
             [send] Raw Data (0x000008060000000003)
             [send] Raw Data (0x0000000000000000)
             [recv] GOAWAY Frame (length:8, flags:0x00, stream_id:0)
             [recv] Error: remote error: tls: user canceled
        using source address [::1]:52387
        × 1: Sends an invalid PING frame for connection close
          -> The endpoint MUST close the TCP connection
             Expected: Connection closed
               Actual: Error: remote error: tls: user canceled

I am pretty certain the "tls: user canceled" is coming from the low-level Go TLS library when the socket is closed. I check netstat and the connection is dropped.
Gemini AI shows this to be expected with:

The "tls: user canceled" error in Go typically occurs when a TLS (Transport Layer Security) connection is interrupted or terminated prematurely by the client. Here's a breakdown of the possible causes and solutions:
Possible Causes:
Client-Initiated Termination:
The client might have closed the connection intentionally, such as by closing the browser tab or terminating the application.

what's interesting in this case is that has received the GOAWAY - most of the tests use GOAWAY, RST_FRAME, and connection drop as the same.

This appears to be resolved after upgrading the Go libraries.


Infinite loading of the world bug

Endless loading of the world when trying to connect to the server. In the debug console, rendering error spam is observed. At the same time, in a single game, the modification does not cause bugs. Perhaps it has something to do with interaction with Optifine or other mods.
When a bug occurs, the screen "loading terrain..." is displayed. Only stopping the game or the server helps.
debug.log
latest.log

yes, bbor confilcts with optifine
theres currently no way to properly fix this problem.


Add GitHub Actions Workflow Update for Dependabot

This adds GitHub Actions to dependabot.yml for auto upgrade workflow actions.
Related to https://github.com/jhipster/generator-jhipster/issues/12103

@DanielFran : Thanks for the review. :+1:


Add probability tests to check vectorized/scalar lpmfs/lpdfs are the same

This is the replacement for https://github.com/stan-dev/math/pull/1989
Fixes #1861 and #1978
This also adds similar tests to prevent problems with the log ccdf and cdf functions.
Release notes
Added more tests for vectorized probability functions
Checklist

[x] Math issue #1861, #1978

[x] Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[ ] the code is written in idiomatic C++ and changes are documented in the doxygen

[ ] the new changes are tested

@t4c1 ready for review again, though we might want to wait for tests to pass again since we're checking more things now that I enabled the fvar stuff you pointed out.

@bbbales2 You have some failed tests here

Green check green check green check! Man that feels good


STORM-860 disable "Activate" button when topology status is not "inactivate"

When we activate topology while it is rebalancing or killed from UI, UI shows that "Error while communicating to nimbus".
Based on these, "Activate" only makes sense while inactivated.

+1. Good catch.

Thank you @HeartSaVioR . This change is merged to master now.

@kishorvpatil Thanks for merging!


feat: add json cache

Changes

#939  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


Blurry text after scrolling/translating coordinates

Describe the bug
When moving around the page, the renderer often keeps some areas blurry.
To Reproduce
Steps to reproduce the behavior:

Open a PDF on android.
Zoom in
Move the page around.

Expected behavior
Text should be rendered cleary.
Screenshots

Smartphone (please complete the following information):

Pixel 2 XL
11 (but other (previous) versions same behaviour

hi @suxma
please open your issue in repository of pdf_view
because flutter_cached_pdfview depend on it


Fix python code formatting

Description: Reformat the python code, and the example starts successfully
Risk Level: not
Testing: yes
Docs Changes: not
Release Notes: not

@reatang all of our code is formatted automatically by the format job during CI. This PR will not pass automatic formatting. Thanks for the contribution, but I am inclined to close this PR.


Parallelize tests

Codecov Report

Merging #26 (12a4a7b) into main (ceeba02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   60.11%   60.11%
=======================================
  Files           6        6
  Lines         692      692
  Branches      103      103
=======================================
  Hits          416      416
  Misses        256      256
  Partials       20       20

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Unable to change language to spanish but french and english work

Subject of the issue
Unable to change language to Spanish
Your environment

version of angular-translate : 2.18.1
version of angular : 1.6.8
which browser and its version : Chrome 70

Steps to reproduce
Use this angular module config :
import fr from './fr';
import en from './en';
import es from './es';

angular.module('translations', [])
    .config([
        '$translateProvider', ($translateProvider) => {
            $translateProvider
                .translations('en', en)
                .translations('fr', fr)
                .translations('es', es)
                .registerAvailableLanguageKeys(['en', 'fr', 'es'], {
                    'en*' : 'en',
                    'fr*' : 'fr',
                    'es*' : 'es',
                    '*'   : 'es'
                })
                .determinePreferredLanguage()
                .useSanitizeValueStrategy(null);
        }
    ]);

Call $translate.use('es') and console.log ($translate.use()) in a controller.
Expected behaviour
console.log should return es.
Actual behaviour
English is use instead.

Hello,
as we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.
Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.


SDK 30 file issue - not showing

Hi, I really love your design for this file picker.
However, the project that I implemented with this library cannot find document-related file such as .pdf, .doc, .xlsx, .zip , etc.
I am now using SDK 30, only image/video-related file displayed.
Do you mind to help me to check it out?

Hello @WenLonG12345 ,
Thanks for reporting your issue. I would be happy to help you out with this.
Can you give me a little more detail about your problem?
Thanks,

Hello @WenLonG12345 ,
Thanks for reporting your issue. I would be happy to help you out with this.
Can you give me a little more detail about your problem?
Thanks,

Hi, thanks for replying.
I just clone your sample project, and then observe that the SDK version is 30 and run the app.
There is files in .pdf, .doc and .xlsx
I am here to attach some screenshot to illustrate my problem.

As you can see, all the pdf, doc and even xlsx is missing. I think it was because of Android 11's scoped storage.

Hi, thanks for replying.
I just clone your sample project, and then observe that the SDK version is 30 and run the app.
There is files in .pdf, .doc and .xlsx
I am here to attach some screenshot to illustrate my problem.

As you can see, all the pdf, doc and even xlsx is missing. I think it was because of Android 11's scoped storage.

Thanks for the screenshots @WenLonG12345 .
If you have just cloned the sample project and have not made any changes, then I suggest you check the setFilters setter in the initialization.
 UnicornFilePicker.from(MainActivity.this)                     .addConfigBuilder()                     .selectMultipleFiles(true)                     .showOnlyDirectory(true)                     .setRootDirectory(Environment.getExternalStorageDirectory().getAbsolutePath())                     .showHiddenFiles(false)                     .setFilters(new String[]{"pdf", "png", "jpg", "jpeg"})                     .addItemDivider(true)                     .theme(R.style.UnicornFilePicker_Dracula)                     .build()                     .forResult(Constants.REQ_UNICORN_FILE);
the sample project is set to display only pdfs and images. You can omit the filters altogether and the file picker will by default show all the files in your directory.
Please look into this and check if this solves your issue.

Thanks for the screenshots @WenLonG12345 .
If you have just cloned the sample project and have not made any changes, then I suggest you check the setFilters setter in the initialization.
 UnicornFilePicker.from(MainActivity.this)                     .addConfigBuilder()                     .selectMultipleFiles(true)                     .showOnlyDirectory(true)                     .setRootDirectory(Environment.getExternalStorageDirectory().getAbsolutePath())                     .showHiddenFiles(false)                     .setFilters(new String[]{"pdf", "png", "jpg", "jpeg"})                     .addItemDivider(true)                     .theme(R.style.UnicornFilePicker_Dracula)                     .build()                     .forResult(Constants.REQ_UNICORN_FILE);
the sample project is set to display only pdfs and images. You can omit the filters altogether and the file picker will by default show all the files in your directory.
Please look into this and check if this solves your issue.

This definitely might be the problem caused by Android 11's scoped storage for which there is no support as of now. I am still working on it and I welcome any helpful PRs.
I will put this on the roadmap. Thanks.

This definitely might be the problem caused by Android 11's scoped storage for which there is no support as of now. I am still working on it and I welcome any helpful PRs.
I will put this on the roadmap. Thanks.

I did try to add difference extension such as "xlsx", "docx", etc. but it is not working.
Thanks for putting this issue up.
and also, I have also no clue for the scoped storage. It makes the working so complicated even if I am using a default file picker.
Will return back to you if I got any brilliant idea to share or any solution for this.
Thank you 👍

I did try to add difference extension such as "xlsx", "docx", etc. but it is not working.
Thanks for putting this issue up.
and also, I have also no clue for the scoped storage. It makes the working so complicated even if I am using a default file picker.
Will return back to you if I got any brilliant idea to share or any solution for this.
Thank you 👍

same issue here. i have tried 2 devices with 2 different android Version. SDK 30 cannot be found for file.

found same issue, but I also notice that the issue occurred in android 11 using SDK 30

This file picker is made for Android on 2021 but still it DOES NOT WORK on scoped storage! Soon every library is forced to use scoped storage. Hope you find time to work with this Mr. Wen.

@MKickelberg I think there is no custom 3rd party file picker for scoped storage on Android 11 yet. Official documentation suggest to use System picker and you might currently use it instead of any 3rd party library

I can't able to see even images even in android 28 OS also.


net: duplicated code of resolution of hosts in internetAddrList

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
master
What did you do?
Resolver. internetAddrList() trying first to resolve the host as IPv4 then as IPv6 and only then to parse it with Resolver. LookupIPAddr(). Although, that's exactly what Resolver. LookupIPAddr() do anyway.
https://github.com/golang/go/blob/d8a7990ffad9aebfb7261df7afb3049da4a09986/src/net/ipsock.go#L253
What did you expect to see?
Resolver. internetAddrList() should reuse the code by resolving the host only by Resolver. LookupIPAddr()

/cc @mikioh

I think it's fine to consolidate the code with the fix for #20790.


Erorr when cracking

Hello just trying to crack the 335300 = Dark souls II scholar of the sin
here is the error_tkinter.log
error_tkinter.log

Seems like a rare error where the unpacked exe file is still in write. Did you manage to fix the problem?

well I was using goldberg crack so the achievement watcher will work better in goldberg
after error I simply use ali213 and was successful then I use the goldberg again and that was successful too.

Seems like a rare error where the unpacked exe file is still in write. Did you manage to fix the problem?

well I was using goldberg crack so the achievement watcher will work better in goldberg
after error I simply use ali213 and was successful then I use the goldberg again and that was successful too.


Fixes custom action parsing

Signed-off-by: Clay Downs<EMAIL_ADDRESS>Issue #, if available:
NA
Description of changes:
Fixes custom action parsing which was failing due to having the token assertions in the wrong order. Custom parsing was being tested exclusively through unit tests, and there was no unit test for actually parsing an extension action written out with the "custom" wrapper, adds that unit test.
CheckList:

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #309 (045d79e) into main (6d93359) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
- Coverage     75.55%   75.52%   -0.04%
+ Complexity     2001     1999       -2
============================================
  Files           253      253
  Lines         11467    11467
  Branches       1815     1815
============================================
- Hits           8664     8660       -4
+ Misses         1772     1770       -2
- Partials       1031     1037       +6

Impacted Files
Coverage Δ

...anagement/indexstatemanagement/ISMActionsParser.kt
88.52% <100.00%> (+8.19%)
:arrow_up:

...nt/indexstatemanagement/model/destination/Slack.kt
40.90% <0.00%> (-13.64%)
:arrow_down:

.../action/explain/TransportExplainTransformAction.kt
64.77% <0.00%> (-4.55%)
:arrow_down:

.../rollup/action/start/TransportStartRollupAction.kt
66.27% <0.00%> (-3.49%)
:arrow_down:

...anagement/indexstatemanagement/model/Transition.kt
64.78% <0.00%> (-2.82%)
:arrow_down:

...exmanagement/opensearchapi/OpenSearchExtensions.kt
86.41% <0.00%> (-1.24%)
:arrow_down:

...nt/rollup/action/stop/TransportStopRollupAction.kt
70.93% <0.00%> (-1.17%)
:arrow_down:

.../opensearch/indexmanagement/rollup/model/Rollup.kt
83.96% <0.00%> (-0.95%)
:arrow_down:

...nt/indexstatemanagement/ManagedIndexCoordinator.kt
72.18% <0.00%> (-0.63%)
:arrow_down:

...gement/transform/model/ContinuousTransformStats.kt
69.23% <0.00%> (+3.84%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d93359...045d79e. Read the comment docs.


Better documentation

Please, give us some gifs showing what you've done.

Ok, next Readme update I'm going to put some gifs


Support execute python script in distributed mode

What type of enhancement is this?
API improvement
What does the enhancement do?
Currently python script can only be executed in standalone mode. I think we can extend it to distributed mode. It should be fairly easy.
Implementation challenges
No response

duplicated


feature_request(encoding): force UTF-8 for Windows users

1. Summary
In my opinion, UTF-8 should be the default encoding for Windows users. If developers of delegator.py don't want to do this, it would be nice to have an option for UTF-8.
2. Argumentation
I don't understand, why needs these lines for Windows users.
if sys.platform == 'win32':
    default_encoding = locale.getdefaultlocale()[1]
    if default_encoding is not None:
        encoding = default_encoding

More about locale.getdefaultlocale(). I have English Windows and Russian language for non-unicode programs. Python interpreter output:
>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'cp1251')

I change my language for non-Unicode programs to English (United States) as recommend in this answer:

I restart Windows → I open Python Interpreter again:
>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'cp1252')

Not UTF-8 again. The example shows that locale.getdefaultlocale() can't set UTF-8 for Windows.
3. Example

SashaDelegator.py (in UTF-8):

import delegator

print(delegator.run('echo Саша Богиня!').out)

I run in console python SashaDelegator.py
4. Expected behavior
Саша Богиня!

5. Actual behavior
???? ??????!

This hack also doesn't help.
import _locale
import delegator

_locale._getdefaultlocale = (lambda *args: ['en_US', 'utf8'])

print(delegator.run('echo Саша Богиня!').out)

I get the same output.
And if I use hacks, I have problems with code quality tools.
6. Environment

Windows 10 Enterprise LTSB 64-bit EN
Python 3.7.0
delegator.py 0.1.0
PYTHONIOENCODING utf-8

Thanks.

@nateprewitt , @kennethreitz, any ideas, how to fix it?
Thanks.

For what it's worth, this sounds like a Python issue perhaps? The locale module is part of Python itself, of course (https://docs.python.org/3/library/locale.html) ...
Also, be aware that a lot of Windows -things- default to UTF-16... Also, check out Microsoft Terminal for a much improved CLI experience (https://github.com/microsoft/terminal)


[CLI]: W&B service deadlock on KeyboardInterrupt with PyTorch-Lightning and Hydra

Describe the bug

I have a Pytorch-Lightning-Project where I use hydra for configuration. A simplified code example follows below:

import pytorch_lightning as pl
from pytorch_lightning.loggers import WandbLogger
import wandb
import hydra

@hydra.main(config_name="config", config_path=".")
def train(cfg : DictConfig) -> None:
    logger = WandbLogger(project='project')

    model = Model(cfg)
    data = DataModule(cfg)

    trainer = pl.Trainer(
        **cfg.trainer,
        logger=logger
    )

    try:
        trainer.fit(model, datamodule=data)
        trainer.test(datamodule=data)
        exit_code = 0
    except Exception as e:
        exit_code = -1
        raise e
    finally:
        wandb.finish(exit_code)

if __name__ == "__main__":
    train()

But since Pytorch-Lightning version 1.6.0 my code hangs, if I interrupt the training with a CTRL+C. I used the hanging-threads library to find out the hanging thread and the traceback reads:

Epoch 0:   12%
Aborted!
/home/user/.local/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py:724: UserWarning: Detected KeyboardInterrupt, attempting graceful shutdown...
  rank_zero_warn("Detected KeyboardInterrupt, attempting graceful shutdown...")
[...]
wandb: Waiting for W&B process to finish... (failed -1). Press Control-C to abort syncing.
[...]
---------Thread<PHONE_NUMBER>20640 "MainThread" hangs ---------
        File "/home/user/.local/lib/python3.7/site-packages/wandb/sdk/wandb_manager.py", line 126, in <lambda>
                self._atexit_lambda = lambda: self._atexit_teardown()
        File "/home/user/.local/lib/python3.7/site-packages/wandb/sdk/wandb_manager.py", line 134, in _atexit_teardown
                self._teardown(exit_code)
        File "/home/user/.local/lib/python3.7/site-packages/wandb/sdk/wandb_manager.py", line 141, in _teardown
                result = self._service.join()
        File "/home/user/.local/lib/python3.7/site-packages/wandb/sdk/service/service.py", line 119, in join
                ret = self._internal_proc.wait()
        File "/opt/conda/lib/python3.7/subprocess.py", line 1019, in wait
                return self._wait(timeout=timeout)
        File "/opt/conda/lib/python3.7/subprocess.py", line 1653, in _wait
                (pid, sts) = self._try_wait(0)
        File "/opt/conda/lib/python3.7/subprocess.py", line 1611, in _try_wait
                (pid, sts) = os.waitpid(self.pid, wait_flags)

Then I modified the wandb-service code and added a timeout in L121 in wandb/sdk/service/service.py and this solved the issue by killing the service-process. Since the service-process was added to the WandbLogger from PyTorch-Lightning in version 1.6.0 (see here) I suspect it to be the problem.
Additional Files
No response
Environment
WandB version: 0.12.11 (also tested 0.12.14)
OS: Ubuntu 16.04.
Python version: 3.7
Versions of relevant libraries:
PyTorch-Lightning 1.6.0 (also tested 1.6.1)
Additional Context
No response

Hi @kielnino,
Thank you for reporting this and I am sorry you are facing this issue. Could you share a bit more information regarding this issue? Specifically, could you share the debug.log and debug-internal.log files associated with the run where you see this deadlock? They should be present in a folder called wandb in the directory where you ran these experiments.
I'll try to reproduce this issue on my end so that we can get this resolved ASAP.
Thanks,
Ramit

Hi @ramit-wandb,
thank you for the quick response. Here is a complete running code-example and the corresponding log-files:
pip install hydra-core==1.1.0
pip install pytorch-lightning==1.6.1
pip install wandb==0.12.14

First create a file config.yaml with the following content:
trainer:
  max_epochs: 50
  log_every_n_steps: 1

and then run this python-file from the same folder:
import pytorch_lightning as pl
from pytorch_lightning.loggers import WandbLogger
import wandb
import hydra
import torch
from torch.nn import functional as F
from omegaconf import DictConfig
from torchvision import transforms
from torchvision.datasets import MNIST
from torch.utils.data import DataLoader

class MNISTModel(pl.LightningModule):
    def __init__(self):
        super().__init__()
        self.l1 = torch.nn.Linear(28 * 28, 10)

    def forward(self, x):
        return torch.relu(self.l1(x.view(x.size(0), -1)))

    def training_step(self, batch, batch_nb):
        x, y = batch
        loss = F.cross_entropy(self(x), y)
        return loss

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.02)

@hydra.main(config_name="config", config_path=".")
def train(cfg : DictConfig) -> None:
    logger = WandbLogger(project='project')

    mnist_model = MNISTModel()
    # Init DataLoader from MNIST Dataset
    train_ds = MNIST('/tmp', train=True, download=True, transform=transforms.ToTensor())
    train_loader = DataLoader(train_ds, batch_size=32)

    trainer = pl.Trainer(
        **cfg.trainer,
        logger=logger
    )

    try:
        trainer.fit(mnist_model, train_loader)
        exit_code = 0
    except Exception as e:
        exit_code = -1
        raise e
    finally:
        wandb.finish(exit_code)

if __name__ == "__main__":
    train()

Here are the debug files:
debug.log
debug-internal.log

Hi @kielnino, Thanks a lot for reporting this issue and for the detailed reproduction steps, it was a pleasure to read your issue. We were able to reproduce it and working on a solution. Hopefully this will be included in the upcoming release.

Hi @kielnino,
This should now be resolved with our latest release of wandb 0.12.16. Please let me know if you have any questions with this.
Thanks,
Ramit

Hi,
The issue still exist with the latest versions. I'm using wandb=0.13.1 and pytorch-lightning=1.7.1, and KeyboardInterrupt will deadlock Pytorch Lightning when a WandbLogger is used, but works fine when there is no WandbLogger.

@TheMrZZ Thanks for reporting the issue. mind sharing more details about your code?
(since service was enabled in pytorch-lightning=1.6 where we verified the issue was resolved)
In the meantime we will try to reproduce it in the latest version of pytorch-lightning

Thanks. The minimum reproduction example available here.
Removing logger=... will allow the program to stop successfully on KeyboardInterrupt.
Output with logger
(removed clutter from the logs)
  | Name   | Type   | Params
----------------------------------
0 | linear | Linear | 2
----------------------------------
2         Trainable params
0         Non-trainable params
2         Total params
0.000     Total estimated model params size (MB)
Epoch 94: 100%|████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 333.36it/s, loss=0, v_num=fkyi]

C:\Users\redacted: UserWarning: Detected KeyboardInterrupt, attempting graceful shutdown...
  rank_zero_warn("Detected KeyboardInterrupt, attempting graceful shutdown...")

Aborted!
⬜

And then, the program deadlocks.

@TheMrZZ Thanks a lot for the repro. I see that you are using windows, I think this is the reason the fix didn't work for you. We are working on a new fix and will update this branch when it is available. Apologies for the inconvenience.

@TheMrZZ I think this branch should fix your issue if you want to give it a try: https://github.com/wandb/wandb/pull/4116
It will probably be included in the official release beginning next month


keybase gpg gen timing out

Hello, I am trying to generate my new gpg keys, tried two times from console, bu
t always getting Error Operation timed out
my log id: f265de1686817cb141723c1c

I might have the same issue... as well

I tried again yesterday and it worked.

I'm also having this issue.

@lamorbidamacchina your log shows your app blocking on a passphrase prompt. Are you sure the keybase passphrase prompt wasn't just hidden behind another window?

Not sure, it can be. I retried 2 days ago, I could see the prompt and completed the process successfully.
Maybe adding a message in console feedback (something like
"check your keybase password prompt if it doesn't show up automatically") could help.

I'm not seeing a prompt, even after foregrounding Keybase.

Which options did you pick when generating the key?

I used all the defaults. I believe it was Y to both questions.

Try no and no
On Wed, Sep 4, 2019 at 10:14 PM Zane Shelby<EMAIL_ADDRESS>wrote:

I used all the defaults. I believe it was Y to both questions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/19158?email_source=notifications&email_token=ADS4PXY6PQEGSRVJCFBRCXDQIBTPLA5CNFSM4IQG5UA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD55SYOQ#issuecomment-528165946,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADS4PX4SWQ6EIWY3UHEDDGTQIBTPLANCNFSM4IQG5UAQ
.


Reaction wheel control returns to normal sometimes at the end of mission

About 50% of the time in a mission such as the following

launch a pod to a space station
dock with station
undock from station and do de-orbit burn
decouple pod and reenter

reaction wheel control for the pod behaves like in stock KSP after the final decoupling.
The other 50% of the time, reaction wheel for the pod completely does not work by that point, not even stabilization, see https://github.com/gotmachine/MandatoryRCS/issues/7

Should be fixed in 1.6


Update uninstall-azure-arc-data-controller.md

when deleting a namespace, only the namespace is required not the parameter

@dnethi

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Feature request: overloading load/dump to accept filename/paths

Would you be interested in a patch to allow pytomlpp.load and pytomlpp.dump to accept a filename/path object instead of an io.TextIOBase object ?
Rationale: this change would allow for a seamless migration from the better known pure Python toml parser to this package. The whole process would be done by simply replacing
import toml

with
import pytomlpp as toml

Ack, isn't this a breaking change? I will need to consider if this s a breaking change.

I honestly don't think it has to be, unless you consider that raising an error from pytomlpp.load("myfile.toml") is a feature :)
I'm game to propose a patch, with tests :)

That would be great! Thanks!


ruff format not producing same results as vs code extension

in my local repo I have these pyproject.toml settings
[tool.ruff]
line-length = 100
indent-width = 4
include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"]

[tool.ruff.lint]
extend-select = ["D403"]

[tool.ruff.lint.per-file-ignores]
"*.ipynb" = ["E402", "F401"]

[tool.ruff.lint.isort]
force-single-line = true
lines-between-types = 1
order-by-type = false

and produces this when I run ruff format --config=pyproject.toml
https://github.com/astral-sh/ruff/assets/11903445/f05099dd-28fc-4ab9-a1e0-98a5abb8bcee
and also ruff check --fix says "All tests passed!"
whereas my vscode extension points to a ruff.toml which looks like this
line-length = 100
extend-select = ["D403"]
extend-include = ["*.ipynb"]

[isort]
force-single-line = true
lines-between-types = 1
order-by-type = false

[per-file-ignores]
"*.ipynb" = ["E402", "F401"]

and produces this result when I save
https://github.com/astral-sh/ruff/assets/11903445/079eca51-7343-4ae7-afe5-61f43c5edb45
The vs code extension results are the ones I want and I don't know how to achieve them

It looks like in the latter case, Ruff is attempting to sort the imports, whereas in the former it's not. Is that correct? You might have organizeImports enabled in VS Code, which will attempt to organize imports even if the rule isn't selected.

@charliermarsh yes correct, but how do I turn on organizeImports using the CLI?

Change:
[tool.ruff.lint]
extend-select = ["D403"]

To:
[tool.ruff.lint]
extend-select = ["D403", "I"]

I had to also do this
ruff check --fix --config=./pyproject.toml
ruff format --config=./pyproject.toml

but that worked! Thanks @charliermarsh !


Add a link for the Kotlin wrapper?

I have published this Kotlin wrapper that does a lot with Netflix-graph if you want to link to it.
https://github.com/klutter/klutter/tree/master/netflix-graph
Is on maven central from version 0.1.1 of Klutter onwards.

Added to the wiki.  Thank you!


Adding buttons

We need to start adding buttons for robot control by the driver(s).

These need to be documented for the drivers in a typed document.

have documentation for this and it is in the oi code


[Help]: Using PyGMTSAR in Spyder

I managed to install the package and run a few examples correctly. The problem appears in the LakeSarez_Landslides_2017, sbas.compute_geocode(1) gives No clients found. So I added the Client initialization lines provided in the notebook. Then, it enters a loop error and I have to stop it.
This is part of the message:
RuntimeError: An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.

This probably means that you are not using fork to start your
child processes and you have forgotten to use the proper idiom
in the main module:

    if __name__ == '__main__':
        freeze_support()
        ...

The "freeze_support()" line can be omitted if the program
is not going to be frozen to produce an executable.

3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0]
2024.3.15.post4
Scenes defined: 19
Go to work directory: /media/tidop/18TB/PYGMTSAR/prueba02
None
None
3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0]
2024.3.15.post4
Scenes defined: 19
Go to work directory: /media/tidop/18TB/PYGMTSAR/prueba02
None
None

Do you mean console scripts maybe? In this case you need to adopt the notebooks as it illustrated in PyGMTSAR CI scripts runners:
        # remove Google Colab specific commands and add __main__ section
        cat imperial_valley_2015.py \
            | sed '/if \x27google\.colab\x27 in sys\.modules:/,/^$/d' \
            | sed 's/^[[:blank:]]*!.*$//' \
            | awk '/username = \x27GoogleColab2023\x27/ {print "if __name__ == \x27__main__\x27:"; indent=1} {if(indent) sub(/^/, "    "); print}' \
            > imperial_valley_2015.fixed.py
        python3 imperial_valley_2015.fixed.py

The same note is printed in your error message above: "... use the proper idiom in the main module: if name == 'main':".

The fixed script seems to work fine. Thanks!


Update DataFusion to latest version

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I think we can close this issue now


VPN Client

Hi,
Is it possible to install a openvpn client on the router so that all traffic going-out-of/coming-to the LAN be sent through that client tunnel. If possible how could it be configured
Thanks

I've updated the library to support openvpn tunneling. Please use version 1.20. The GitHub documentation pages describe how to configure and run this in such a way that you get balancing and failover.


Landing Page

https://vanshsood.com/cazar

Thanks :D
On Sun, Jul 14, 2019, 7:10 PM Sayam Kanwar<EMAIL_ADDRESS>wrote:

@sayamkanwar approved this pull request.
Looks good to me, thanks! Will be awarding bonus points as well! :D
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/XINO-DPSR/open-source-marathon/pull/26?email_source=notifications&email_token=AGDUCVKJCTJXGPQV7DG4W2LP7MUGNA5CNFSM4IDO5ZT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LXBLQ#pullrequestreview-261583022,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGDUCVLU5C5QM64UCV2HDCDP7MUGNANCNFSM4IDO5ZTQ
.


Add health check endpoint and refactor request handling logic

Introduce a health check endpoint for service status verification and streamline the request handling logic for improved clarity and efficiency.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.38%. Comparing base (7ddf65b) to head (9e90ec6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   94.37%   94.38%   +0.01%
==========================================
  Files          39       40       +1
  Lines        1759     1763       +4
==========================================
+ Hits         1660     1664       +4
  Misses         69       69
  Partials       30       30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Add fields used for thread viz

In order to power our threads viz, we needed to pull out:

thread_id
the "start time" of a model
the "end time" of a model

In doing so, I noticed that end_time - start_time != execution_time, so we dug in a little bit on our side.
execution_time is the delta between this line of code and this line of code (via this method). As such, it includes some of dbt's internal processes.
It felt weird to have fields named started_at, completed_at, and then not have the delta not match the execution_time. So we renamed:

started_at → compile_started_at
completed_at → sql_completed_at
execution_time → total_node_runtime

Open to other name ideas here!

cc: @jtcohen6


Use the title of the custom slide directly in the slide

Fixes #2050

We need the Agenda title (which contains also the item number) not only the customslide title...

In this case you have to load the item and use the old code. The item is not loaded and therefore the title can not be shown

Closed. See #2056


feat. quote

Description of Changes
Here is reference: #25

support 'quote block' block
-> add custom solution for rendering 'Quote block'
Review point

could this component be more sementic? (regarding tag and aria-attribute)

Should we integrate an existing solution or use a custom implementation for 'Quote block'?
To reproduce

npm run story:start
click 'Quote' on the Storybook left side panel

Screenshot

Review Guide
Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

could you resolve merge conflict?? if you do, I will approve it

Yes, I will resolve the merge conflict.


twttr.txt.extractMentions doesn't find mentions with an extra "@"

twttr.txt.extractMentions('@Gheerwijn @@EenPonyEnEenKat') returns [ "Gheerwijn" ]
On twitter.com the @EenPonyEnEenKat is also highlighted: https://twitter.com/EenPonyEnEenKat/status/966653086008774664

(JavaScript)

Related to #35


Documentation - Details for setting up BigCommerce integration

Hi
Can you please show with examples on what steps must be taken after configuring a BigCommerce provider so that orders created in BigCommerce flow through to IOM?
Example - what should be the Internal - External Mapping values? What other steps must be completed in addition to configuring BigCommerce (BC) provider before orders can flow through?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a8ea1445-e45a-69e5-7473-7e058616159c
Version Independent ID: c6a05d1e-2086-577a-8401-762ce91e83ea
Content: Set up BigCommerce provider
Content Source: topics/set-up-bigcommerce-provider.md
Service: dynamics-365-intelligent-order-management
GitHub Login: @josaw1
Microsoft Alias: josaw

Thanks for your feedback. @anvenkat, can you please review?


A reason of the 'The requested compute system operation is not valid in the current state' error

Hello,
I already create an issue in the moby repository https://github.com/moby/moby/issues/37395 but did not receive any feedback yet.
We face with this error on a few of our Windows Server 2016 servers. When we see this error then usually
docker ps hangs (if Docker is not upgraed to 18.03-ee) or docker run stuck.
What can be a reason of this error? What recommendations can be here to debug it and prevent in future?
Thanks!

For the hanging, this needs to go through a support case with Docker Inc, they're the only ones who can identify what might be wrong with (I assume) 17.06. In reality, while I don't have EE access, I can tell from debug logs that the code base between the 17.06 cutoff and 18.03 cutoff is vastly different, especially around the libcontainerd library code.


[E2B-396] The stdout or stderr of a process is sometimes not returned full

We investigated this with @ValentaTomas and found a race condition in our infrastructure in the envd.
There are 3 goroutines on the backend:

scanning stdout pipe
scanning stderr pipe
waiting for the process to finish

The last goroutine sometimes finishes faster than the first two and unsubscribes all the frontend listeners to the process.
Proposed solution: have another goroutines that announces the process has finished to the frontend only after all 3 goroutines have finished
From SyncLinear.com | E2B-396

I added code that should fix this to devbookd - @jakubno is now also fixing the homedir, bashrc,.. problems so the new templates rebuild should have the fix.


Interactive diagram

First touches for making the diagram interactive.
Hover over creates a drop shadow, and facet text gets larger with a white glow.
Need to fix it so that the drop shadow is working relative to the angle of the arc as some sections highlight better than others. ('effect' doesn't "lift" much)
Mouse cursor goes to hand on hover over.
Perhaps some sfx when hovering over the sunburst might be good?!
Clicking a facet on the left changes the text on the right to the relevant info about each facet. as the given sketch suggested

first draft of zoom in functionality
Clicking on a facet 'zooms' in on that facet similiar to [(https://bl.ocks.org/mbostock/4348373)]
The text size is adjusted by the depth level of the zoom.
Facet text is deactivated for facets not needed and the text of the facets that are visible will transition to aligns to it's appropriate facet/position.
Currently using setTimeout so that the appropriate x,y co-ordinates are set, but this needs to be improved so the transitions are smoother.

Looking very nice! On my firefox it is a bit unstable if I move the mouse during a transition but still very nice 👍 I added some more comments and will add that parent() function today

Mucho Commits! :laughing:
Anyway, Phase2..
I updated the diagram so that the facet hover over angle is relevant to position so it's more obvious that it's interactive.
The text position and size now transitions in sequence with the facet/arc transition by means of the same tween.
Tier is set from the taxonomy and the parent info is too.
Hover in/out are delayed for the duration of the 'click' transitions so it's less buggy.
The facets that aren't being used are hidden so that this black line in the top centre of the diagram doesn't sit there any more.
When text reappears it transitions in by it's opacity for aesthetic purposes

More changes going from commit 'text aligned'.. that 'recovery point' commit was just me having issues with changes being overwritten.
The text now lines up with the angle of the arcs, and rotates to a flat horizontal line when being hovered over so it's easier to read.
Cleaned up the code so it's less buggy with the extended taxonomies and made all the changes as requested.
The purple facets might be too dark a colour to use, might be easier to read if it was lighter.
Also we can change the depth so that it only shows 2 or 3 levels at a time.. I guess if it's any longer it won't make any sense anyway. Could also implement a feature where the user can select how deep it goes?!


Publish to npm :)

'doppler' is available on npm! https://www.npmjs.com/package/doppler

I'm not sure what I feel about publishing a client-side-only libraries to npm.

Seems like more people are doing it though. I've added it. Thanks! :D

You should add some info about this in the README.


Configure the eslint formatter from .eslintrc

Configuring the eslint formatter from webpack itself doesn't seem like a nice solution when  it is already configrable from the .eslintrc.

Never mind. The eslint formatter is actually configured through the cli.


[hotfix][docs] Remove and update useless html anchor in hadoop_compatibility.md

Since the html anchor "index.html#data-types" no longer exists, this pull request removes and updates useless html anchor in hadoop_compatibility.md.

Thanks for the PR. @wenhuitang !
IMO. hotfixes are generally very urgent and important bugs. The current PR is about documentation improvements, I recommended that you first create JIRA.
What do you think?
Best,
Jincheng

I have created the JIRA. FLINK-11777 and link the PR to it. @wenhuitang

LGTM. +1 to merged.
@flinkbot approve all

Merging...


Can not train a model with multi_process kvworkers

Hi,
I am trying to train models with ps-lite. It works well in multi_thread mode like test_kv_app_multi_workers, but in multi_process model, only one worker process works and the others are blocked in the PS::Start stage.
Trace the code of ps:Start, we can find that there is a barrier in this stage.After all the scheduler/servers/workers shoot the barrier command, every node will be activated by setting the barrier_done_ to true. But the code followed below only will set
the barrier_done_ to true for customer_id 0.
void Postoffice::Manage(const Message& recv) {
CHECK(!recv.meta.control.empty());
const auto& ctrl = recv.meta.control;
if (ctrl.cmd == Control::BARRIER && !recv.meta.request) {
barrier_mu_.lock();
auto size = barrier_done_[recv.meta.app_id].size();
for (size_t customer_id = 0; customer_id < size; customer_id++) {
barrier_done[recv.meta.app_id][customer_id] = true;
}_
barrier_mu_.unlock();
barrier_cond_.notify_all();
}
}

The bug can be fixed by the code followed.
void Postoffice::Manage(const Message& recv) {
CHECK(!recv.meta.control.empty());
const auto& ctrl = recv.meta.control;
if (ctrl.cmd == Control::BARRIER && !recv.meta.request) {
barrier_mu_.lock();
for (auto iter=barrier_done[recv.meta.app_id].begin();iter!=barrier_done_[recv.meta.app_id].end(); iter++)
{
size_t customer_id = iter -> first;
barrier_done_[recv.meta.app_id][customer_id] = true;
}_
barrier_mu_.unlock();
barrier_cond_.notify_all();
}
}

@eric-haibin-lin can you review this commit?


AccountPage: Use wallet balance from oasis node directly instead of explorer

Related to #403 and #407. Currently, the wallet balance is fetched from the block explorer and if the service went down, the balance was 0. This PR uses the balance reported by the local oasis node only.

I think this was effectively superseded by https://github.com/oasisprotocol/oasis-wallet-web/pull/737


#6550: [1.10.x] no required on client side if default value is set (TextField)

Fixes partially #6550.
Re-done to target 1.10.x. Other fields will come, i'll try to group them but i need to test again all options and each field has its special cases.

If required and a default value is set, then no required on client side, but still with the required class to have the red star, and still required on server side.

Special case: The default value is tokenized in a 2nd driver and the result can be empty. So, the required checking is also done in the 2nd driver. Because, if the default has a value, it has not been done in the 1st driver.

Best

I lost my changes after a bad squash / revert. I'll re-do it asap

@sebastienros Added specflows.

@sebastienros
Not urgent at all for me, it's just for infos because it's the last one of the serie where i've added specflows.
Note: Other fields are already commited to 1.10.x (and recently merged in dev).
Best.

I am merging this one, but the goal of squash is to get a single commit, not an extra one named squash ;)

Ok, sorry.


Move elasticsearch query-building functions to separate module

Issue number: N/A
Description of change
This moves all the query-related functions out of datahub.search.elasticsearch to try and organise that bit of the code base a bit better. Wasn't sure what to call the new module – started with query but seemed like could conflict with variables named query.
Also wasn't sure what to do (name-wise) with all the test_elasticsearch modules in the search apps with this change, as they all do different things. Have left those as test_elasticsearch at the moment.
Checklist

[x] Have any relevant search models been updated?
[x] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[x] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[x] Has the admin site been updated (for new models, fields etc.)?
[x] Has the README been updated (if needed)?

@marcofucci Do you want to work on those improvements? I could find some time as well.

@marcofucci Do you want to work on those improvements? I could find some time as well.

Yes, I think I might have a bit of time. Maybe merge this one as it is and I'll prepare another one with some proposed changes to comment on.

@marcofucci  I thought this PR would be only to move query builder to separate module and I would expect possible improvements to be in separate PR(s). I think doing improvements here could make it too big.

@marcofucci I thought this PR would be only to move query builder to separate module and I would expect possible improvements to be in separate PR(s). I think doing improvements here could make it too big.

Yep, moving things around thanks to @reupen 's work just revealed a couple of improvements what we never had time to spend time on. I agree that could be part of a different PR.

Another thing I forgot to mention, I'm not sure about the use of get in all the function names (get_xxx_query etc.). They don't seem to be getting anything from anywhere to me. Could go for a different verb like prepare, make or create.

yeah I thought the same, I was proposing build or make but maybe prepare could work.

Codecov Report

Merging #903 into develop will increase coverage by <.01%.
The diff coverage is 97.64%.

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
+ Coverage    96.57%   96.58%   +<.01%
===========================================
  Files          166      167       +1
  Lines         4853     4855       +2
  Branches       468      468
===========================================
+ Hits          4687     4689       +2
  Misses         103      103
  Partials        63       63

Impacted Files
Coverage Δ

datahub/search/dashboard/views.py
100% <100%> (ø)
:arrow_up:

datahub/search/views.py
96.15% <100%> (ø)
:arrow_up:

datahub/search/interaction/signals.py
100% <100%> (ø)
:arrow_up:

datahub/search/elasticsearch.py
78.37% <100%> (-15.5%)
:arrow_down:

datahub/search/serializers.py
94.44% <100%> (ø)
:arrow_up:

datahub/search/query_builder.py
97.51% <97.51%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68544b...6569794. Read the comment docs.

Build seems fair, the module is called query_builder after all :slightly_smiling_face:


Bug: Lexical editors in multiple windows

Steps To Reproduce
I'm not sure how to make an easy reproduction, but I noticed this in our app which pops out a DOM-only Electron window. It opens a new window via window.open() and renders to it from the parent window. As a result, there are multiple window objects that can host Lexical editors and one JS environment.
The current behavior
Lexical tracks lastTextEntryTimeStamp in a way that does not account for multiple windows over the lifetime of the application. It adds an event listener to the first window and not subsequent ones.
let lastTextEntryTimeStamp = 0;

function updateTimeStamp(event) {
  lastTextEntryTimeStamp = event.timeStamp;
}

function initTextEntryListener(editor) {
  if (lastTextEntryTimeStamp === 0) {
    getWindow(editor).addEventListener("textInput", updateTimeStamp, true);
  }
}

There were a number of buggy behaviors which resulted from this, due to applying input mutations during beforeinput. The most obvious bug was the MarkdownShortcutPlugin would duplicate the closing tag.
The expected behavior
Lexical should support editors in multiple windows.

I patched lexical 0.12.2 to fix it like this:
diff --git a/node_modules/lexical/Lexical.dev.js b/node_modules/lexical/Lexical.dev.js
index bcc05e3..db20147 100644
--- a/node_modules/lexical/Lexical.dev.js
+++ b/node_modules/lexical/Lexical.dev.js
@@ -197,18 +197,25 @@ const TEXT_TYPE_TO_MODE = {

 const TEXT_MUTATION_VARIANCE = 100;
 let isProcessingMutations = false;
-let lastTextEntryTimeStamp = 0;
+const lastTextEntryTimeStamp_ = new WeakMap();
 function getIsProcesssingMutations() {
   return isProcessingMutations;
 }

-function updateTimeStamp(event) {
-  lastTextEntryTimeStamp = event.timeStamp;
+function lastTextEntryTimeStamp(window) {
+  return lastTextEntryTimeStamp_.get(window);
+}
+
+function updateTimeStamp(window) {
+  return function(event) {
+    lastTextEntryTimeStamp_.set(window, event.timeStamp);
+  }
 }

 function initTextEntryListener(editor) {
-  if (lastTextEntryTimeStamp === 0) {
-    getWindow(editor).addEventListener('textInput', updateTimeStamp, true);
+  const window = getWindow(editor);
+  if (!lastTextEntryTimeStamp_.has(window)) {
+    window.addEventListener('textInput', updateTimeStamp(window), true);
   }
 }

@@ -257,7 +264,8 @@ function shouldUpdateTextNodeFromMutation(selection, targetDOM, targetNode) {

 function $flushMutations$1(editor, mutations, observer) {
   isProcessingMutations = true;
-  const shouldFlushTextMutations = performance.now() - lastTextEntryTimeStamp > TEXT_MUTATION_VARIANCE;
+  const window = getWindow(editor)
+  const shouldFlushTextMutations = window.performance.now() - lastTextEntryTimeStamp(window) > TEXT_MUTATION_VARIANCE;

   try {
     updateEditor(editor, () => {

Another multi-window issue, this time in LexicalLinkPlugin
event instanceof ClipboardEvent

returns false, I suppose because ClipboardEvent refers to the first window's class. This fixes the check:
event instanceof editor._window.ClipboardEvent

This is all fairly surprising to me, to be honest.

Here is a relevant documentation page
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_realms

This is an interesting one - thanks for reporting.
Would you be interested in submitting that patch as a PR?

Hi @acywatson , any feedback on the PR? The only X is the deployment to lexical-playground, but I'm not able to see the issue there.

Hi @acywatson , I found and fixed another multi-window issue and added it to the PR. Can you please have a look? I think it's ready to go.

One more ping @acywatson after the holiday


deprecated dependencies with vulnerabilities in the sample

Sample has a reference to ubuntu18.04 base image that is deprecated since January 2023. Anyone who is using the sample will be flagged for vulnerabilities.
Also at the very least these packages have high and critical vulnerabilities
%%writefile {dependencies_dir}/conda.yaml
name: model-env
channels:

conda-forge
dependencies:
python=3.8
- numpy=1.21.2
pip=21.2.4
- scikit-learn=0.24.2
- scipy=1.7.1
pandas>=1.1,<1.2
pip:

inference-schema[numpy-support]==1.3.0
- mlflow== 1.26.1
- azureml-mlflow==1.42.0
psutil>=5.8,<5.9
tqdm>=4.59,<4.60
ipykernel~=6.0
matplotlib

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ccf83708-46f5-aa23-3f59-c90ca4c4b8ca
Version Independent ID: 7c65eb09-fe59-039b-bf64-ab516f983b3a
Content: Tutorial: Train a model - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-train-model.md
Service: machine-learning
Sub-service: core
GitHub Login: @ssalgadodev
Microsoft Alias: ssalgado

@vizhur
Thanks for your feedback! We will investigate and update as appropriate.

@vizhur
Thank you for bringing this to our attention.
I've delegated this to content author @ssalgadodev, who will review it and offer their insightful opinions.

@ssalgadodev
Could you please review add comments on this, update as appropriate.

Could you explain to me why do we need the dependency restrictions at all?

@leoniewgnr We need dependency restriction for reproducibility and compatibility. Or pretty soon you'd get another ticket that says conda environment can't be materialized or not compatible with the code executed on it.


Update Argo CD to 2.7.11.

2.8 is out today, so let's update to the latest patch release first.
Tested: running in staging.

Rolled out everywhere now.


Allow exit if no files are being skipped

Fixes #7

Can you please change this PR to just contain the fix?

I think you'll  have to give me more guidance. I either don't understand the intent behind the existing flow, or it doesn't work. The Pr changes it, ensuring the program behaves the same whether you are watching a directory or individual files.


Custom CSS

Hello, great app.
Please tell me, is it possible to somehow connect custom css? Via env or volume.
I would like to change the background color.

Currently not. PRs are welcomed :)


Include option for including links to PRs with no release notes

Changes

The github_release_notes task now has an include_empty option to for the ability to include links to PRs that have no release notes.

@davisagli - The added tests now provide full coverage for the new code; however, I'm not sure I've satisfied the "integration" test that you mentioned earlier. I was attempting to have a test where I can setup mocked PR data and utilize the GithubReleaseNotesGenerator.__call__ method but we don't currently have the endpoint that GithubChangeNotesProvider._get_pull_requests() calls out to mocked under cumulusci/tasks/release_notes/tests/utils.py --> MockUtil.
I can definitely make a mock for the endpoint but I wasn't quite sure how to tie-together pull requests generated by MockUtil.mock_pull_request to be returned by the newly mocked endpoint.
Would love to hear your thoughts, and definitely happy to implement this as it would be nice to test all of the parts as a whole.

@Br4nd0R I think you can add the mock response for _get_pull_requests something like this:
    responses.add("GET", "{}/pulls".format(mock_util.repo_url), json=[pr1, pr2])

But I think your existing tests do a good job of testing the pieces and a full integration test isn't super important (especially since the piece that that would add of interacting with github is mostly mocked out anyway).


Adding Snagit

Added it to the list in Screenshots. But secondarily mentions in the feedback and mockups sections.
Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[x] I added the appropriate labels: free, open-source or mac.
[x] I put the tool only to one category.
[x] I followed Contribution Guidelines.

I added one additional link to explain a concept. Please let me know if that should be removed. I can certainly do that!!
I love this list. Digging in more now.

@chrismlarson thanks for adding https://www.techsmith.com/screen-capture.html to our list.
I removed your suggestions in Design Feedback Tools and Mockup Tools, because of several reasons:

It's not exactly a feedback tool.
Under Mockup Tools section you put a link on the article (https://www.techsmith.com/blog/simplified-user-interface/). We couldn't publish it, as it looks like a promo.

I think the most related and relevant section for your product is Screenshot Software :)


[HOLD for payment 2024-10-17] [API Reliability] Prevent infinite reauthentication loop

Problem
We have seen users getting to a state of the App, where it seems like the app works fine thanks to the offline first design, but all requests made were returned with 407 error (logs).
From these logs, we can see that the user has been hitting this error from the authentication call as the required params been missing.
We throw an error Parameter partnerUserID is required for "Authenticate" and that leads to skipping the reauthentication sign out logic as we do not handle any catch block.
The error is because the Reauthenticate call is missing the required params.
### Solution
Make sure to sign user out if the authenticate call throws an error
Issue OwnerCurrent Issue Owner: @alexpensify

No payment process is needed here; this one was handled internally.


refreshed CI settings

bumped several nuget versions
matching builds for Xamarin.Android

Does this also need to update the android workload?
https://github.com/xamarin/XamarinComponents/blob/df29e1fe1db5a744f3f1336e8a888b87ecfbb159/azure-pipelines.yml#L80-L83

Not sure. But I think it makes sense to update.

Added snippet for workload installation and update from AX and/or GPS-FB-MLKit

@moljac can you make a small change in Tensorflow to test at least one of them?

@moljac can you make a small change in Tensorflow to test at least one of them?

OK
I will bind the same version as in GPS-FB-MLKit, so that we have one parameter less to take into account.
Should I multitarget net6.0?
We left it here as monoandroid9.0
https://github.com/xamarin/XamarinComponents/blob/main/XPlat/TensorFlow.Lite/source/Xamarin.TensorFlow.Lite.Bindings.XamarinAndroid/Xamarin.TensorFlow.Lite.Bindings.XamarinAndroid.csproj#L12

@moljac can you pick one that targets .NET 6? Maybe Xamarin.Android.Glide?

One thing to keep in mind when changing .yaml files for this repository is that it is set up to always use the YAML from main:
https://github.com/xamarin/XamarinComponents/blob/main/azure-pipelines.yml#L15-L19
Therefore it will never test your PR changes to YAML files.  (I do not know why it is set up this way 🤷♂)
This commit breaks the Linux lane with:
Workload ID maui isn't supported on this platform.

As a result we can no longer publish anything out of this repository.  We need to figure out if these changes were actually needed, and if so, how can we work around it for Linux.


config for disabling anonymous sessions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 11 (18.18%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 84.273%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/pro/handlers/users.rs
2
5
40.0%

services/src/pro/server.rs
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

services/src/pro/server.rs
1
0%

services/src/server.rs
1
67.2%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
25850

Relevant Lines:
30674

💛  - Coveralls


Bump fct to 4.1.17

bump FSharp.Compiler.Tools to v4.1.17
the 4.1.17 contains the commit https://github.com/Microsoft/visualfsharp/commit/060054c60b80cb51ea67131a5a50c1b445e21dbc who fix https://github.com/Microsoft/visualfsharp/pull/2899 /cc @nosami

@dotnet-bot test Windows_NT x64 Release Build please
@dotnet-bot test Ubuntu16.04 x64 Debug Build please

@nosami can you check fix your issue? i added a package in the dev feed:

feed: https://www.myget.org/F/netcorecli-fsc/api/v3/index.json
<PackageReference Include="FSharp.NET.Sdk" Version="1.0.5-rc1-0001" PrivateAssets="All" />

if is ok, i'll publish as 1.0.5 on nuget, so will works OOTB

Yeah, debugging works out of the box with this package - great!


Allow a field with custom schema to be nullable during deserialization

Given these schema
class ChildSchema(halogen.Schema):
    some_other_field = halogen.Attr(halogen.types.String())

class ParentSchema(halogen.Schema):
    some_field = halogen.Attr(ChildSchema)

To make some_field nullable during deserialization, I have to create a deserialize class method on ChildSchema:
class ChildSchema(halogen.Schema):
    some_other_field = halogen.Attr(halogen.types.String())

    @classmethod
    def deserialize(self, value, **kwargs):
        return None if value is None else super().deserialize(value)

It would be nice if halogen.Attr supported a nullable parameter:
some_field = halogen.Attr(ChildSchema, nullable=True)
Or alternatively support wrapping:
some_field = halogen.Attr(halogen.Nullable(ChildSchema))

As an alternative nullable can indicate that default should be used or not. This way it will be similar to required, which indicates if the attr/key has to be present and nullable would indicate if the default should be used if the value is None.

Fixed in #17


cmd/fmt: imperfect error message

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10 linux/amd64
Does this issue reproduce with the latest release?
yes
What did you do?
package main

func f() {}

func main() {
	f(,)
}

/*
...
*/  // missing ',' in argument list

What did you expect to see?
a.go:6:4: expected operand, found

What did you see instead?
a.go:6:4: expected operand, found ','
a.go:11:37: missing ',' in argument list

I’m confused. Your expected output isn’t sufficient (nothing after “found”).
Are you saying that it should not say a.go:11:37: missing ',' in argument list at all but the first message (a.go:6:4: expected operand, found ',') is OK?

yes

This is another case of go/parser being behind cmd/compile/internal/syntax in terms of reporting errors to humans.
$ gofmt f4.go
f4.go:6:4: expected operand, found ','
f4.go:7:3: missing ',' in argument list
$ go build f4.go
# command-line-arguments
./f4.go:6:4: syntax error: unexpected comma, expecting expression

I'll let @griesemer decide what to do.


Moving to docsy

This moves from the "Learn" theme to "Docsy" and reorganizes the pages accordingly, along with making several stylistic changes and adding some content to the landing page. The documentation itself, which is now under a "docs" tab, is largely untouched.

FSH Playground isn't ready for prime time yet. Should we remove references to it for now or are we going to hold back all of FSH School until it is ready?

I'm not sure. It depends on what you consider ready for prime time. FSHPlayground (or FSHOnline) is functional.

Also... I noticed on some pages we get partial shorties (e.g., I see just the school master's hat in the "About" page). I thought you were going to use the background without shorties for those pages?

Yeah it is just the about page. I need a copy of the background without Shorty. @markkramerus can you share that with me?

I think maybe we should add this to the README, as it's not obvious why hugo server is failing if you're not aware that we use submodules (or not aware how submodules work).
Will do

FSH Playground isn't ready for prime time yet. Should we remove references to it for now or are we going to hold back all of FSH School until it is ready?

I'm not sure. It depends on what you consider ready for prime time. FSHPlayground (or FSHOnline) has some functionality.

I think it needs the console before we really call it functional, else it doesn't tell users when something is wrong or what specifically is wrong.  And based on where @markkramerus set the bar on calling FSH School ready, I'm guessing we'll need to style the playground some more before he wants to put it front and center.

I think it needs the console before we really call it functional, else it doesn't tell users when something is wrong or what specifically is wrong. And based on where @markkramerus set the bar on calling FSH School ready, I'm guessing we'll need to style the playground some more before he wants to put it front and center.

Also, we should move it from github.com/standardhealth to github.com/FSHSchool -- but that should be pretty trivial.

Yeah that's fair. Do you want me to make it a "Coming soon!" like the US Core Patient Tutorial is right now, or just hide any reference to it for now?

We can let @markkramerus decide how he wants to handle the rollout of FSH Online.  Mark?  Do you want us to:
(a) keep all references to FSH Online and link to FSH Online as it is whenever we release this site?
(b) keep all references to FSH Online but just mark it as "Coming Soon" w/ no links
(c) temporarily remove all references to FSH Online

https://github.com/FSHSchool/site/pull/1/commits/4c9367bff596e36e2083de32709cf78f27eeb883 should contain all of the requested changes, except those which are waiting on a response.

Ok @cmoesel, https://github.com/FSHSchool/site/pull/1/commits/ff97124f7212f64cf711be366446989c12d82c5c should resolve all outstanding comments. I added a blank background to the about page, and added a coming soon for when people click on a link leading to FSH Online.