Setup Lottie

Details
Sets up Lottie animations in E/App. Replaces the two gifs we already have in place with their Lottie equivalent.
I wanted to set up .lottie files because they're only about 10% the size of their .json equivalent, but it looks like it's going to be a bit more involved because neither lottie-react-native nor react-native-web-lottie currently support that format. Will address this in a follow-up issue, but I don't think it's critical right now.
Fixed Issues
$ (partial) https://github.com/Expensify/App/issues/12261
Tests

Hardcode this line to true
Open the app, then create a workspace if needed.
Go to workspace settings -> reimburse expenses -> connect bank account
Verify that you see the scanning bank info animation and it looks good.
Change this line to replace ROUTES.SETTINGS_PAYMENTS with ROUTES.ENABLE_PAYMENTS.
Comment out these lines and replace these lines with just: <ActivateStep userWallet={this.props.userWallet} />
Then open the settings menu and click on Payments. Verify that you see the scanning animation and it looks good.
Replace isGoldWallet on this line with true.
Verify that you now see the fireworks animation and it looks good.

[ ] Verify that no errors appear in the JS console

Offline tests
None.
QA Steps
This should be covered by regression tests. As you go through the regression tests for wallet setup and bank account connection, verify that the animations appear as they normally do.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/47436092/218197732-65a69d6c-86b2-4068-b998-977ada5b7da7.mov
https://user-images.githubusercontent.com/47436092/218197735-d47086fa-a862-47b4-9a89-6a6818fea8a8.mov
https://user-images.githubusercontent.com/47436092/218197741-2ed5dfba-4d37-499e-aec3-750dabe7a665.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/47436092/218199396-e421ac13-3a7d-45cd-b4e2-f0b493a7ec5d.mp4
https://user-images.githubusercontent.com/47436092/218199414-6afac5ac-3c2c-4a0c-b0c6-8f44363a0c57.mp4
https://user-images.githubusercontent.com/47436092/218199426-0d8be342-7a2e-4a3b-86fc-b913b671c700.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/47436092/218198340-05256b4d-e063-4e1e-9d13-16eca3cc3d60.MP4
https://user-images.githubusercontent.com/47436092/218198351-45b7e824-2951-4cb2-a3ec-3ffca4306dc8.MP4
https://user-images.githubusercontent.com/47436092/218198356-8ce24029-2a4a-4d4f-901d-bb243cdf056b.MP4

Desktop
https://user-images.githubusercontent.com/47436092/218199981-750d2ecd-3c5d-42f7-a83d-bf0b2cf0fa87.mov
https://user-images.githubusercontent.com/47436092/218199983-59d3a22a-c269-4d2a-8e4b-020e70ff5f4a.mov
https://user-images.githubusercontent.com/47436092/218199984-b0fc8c88-34ab-45c8-993e-2602a3ed9d60.mov

iOS
https://user-images.githubusercontent.com/47436092/218189907-703e087c-a77a-4fe6-b5c9-da11668f5851.MP4
https://user-images.githubusercontent.com/47436092/218192491-1d04e5eb-fdec-4889-806e-f62870fbfc84.MP4
https://user-images.githubusercontent.com/47436092/218192666-f4c19013-05b2-4d96-b915-1697bfbce427.MP4

Android
https://user-images.githubusercontent.com/47436092/218196999-25351dab-1f12-4e71-b06b-eaf53b95295b.mp4
https://user-images.githubusercontent.com/47436092/218197010-ec2d71f0-05e5-4356-9497-a078828b4c40.mp4
https://user-images.githubusercontent.com/47436092/218197025-fdbb6de1-3f82-407d-8b63-d4bb9938f093.mp4

Use the links below to test this build in android and iOS. Happy testing!

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/14393/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/14393/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PULL_REQUEST_NUMBER/NewExpensify.dmg
https://$PULL_REQUEST_NUMBER.pr-testing.expensify.com

@stitesexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/14393/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/14393/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PULL_REQUEST_NUMBER/NewExpensify.dmg
https://$PULL_REQUEST_NUMBER.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/14393/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/14393/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PULL_REQUEST_NUMBER/NewExpensify.dmg
https://$PULL_REQUEST_NUMBER.pr-testing.expensify.com

Bump – don't want this getting too stale

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Tested on physical device, looking great!
https://user-images.githubusercontent.com/36083550/220962718-eeaf9ea6-2192-42ae-b610-0b3b30579ebc.MP4

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.76-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.76-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

There is a console error bug while we defined the animation: PropTypes.string but we where passing type of object to it. This has been found and rectified as part of this issue - https://github.com/Expensify/App/issues/19365


Error:  The Node.js native addon module (tfjs_binding.node) can not be found at path...

I am trying to install DanfoJS on windows 10 using below command:
npm install danfojs-node

but I get following error when I run npm start

Error: The Node.js native addon module (tfjs_binding.node) can not be found at path:

I tried to ran npm rebuild @tensorflow/tfjs-node build-addon-from-source but still having problem.

This error is from TFJS. I've noticed it for Windows users. Here's a link to a similar GitHub issue on the TFjs issues page, see if it works for you.
https://github.com/tensorflow/tfjs/issues/2046

I tried almost everything was mentioned on the issue page you forwarded, still having same problem :(

here is my package.json:
"devDependencies": {
    "babel-polyfill": "^6.26.0",
    "electron": "^10.1.0",
    "electron-packager": "^13.1.1"
  },
  "dependencies": {
    "@tensorflow/tfjs-node": "^2.3.0",
    "body-parser": "^1.18.3",
    "danfojs-node": "^0.1.4",
    "electron-log": "^3.0.6",
    "express": "^4.16.4",
    "local-devices": "^2.0.0",
    "node-thermal-printer": "^4.1.0",
    "react-select": "^3.1.0",
    "regenerator-runtime": "^0.13.5",
    "ws": "^7.2.0",
    "xml2js": "^0.4.22",
    "xpath": "0.0.27",
    "yargs": "^14.0.0"
  },

I think I see the issue, danfo-node uses @tensorflow/tfjs-node": "^2.1.0", so I think it is conflicting with the current version. Try removing the @tensorflow/tfjs-node": "^2.3.0" dependencies and run npm install again

ok I did what you said and still having the same issue.  current package.json:
  "devDependencies": {
    "babel-polyfill": "^6.26.0",
    "electron": "^10.1.0",
    "electron-packager": "^13.1.1"
  },
  "dependencies": {
    "@tensorflow/tfjs-node": "^2.1.0",
    "body-parser": "^1.18.3",
    "danfojs-node": "^0.1.4",
    "electron-log": "^3.0.6",
    "express": "^4.16.4",
    "local-devices": "^2.0.0",
    "node-thermal-printer": "^4.1.0",
    "react-select": "^3.1.0",
    "regenerator-runtime": "^0.13.5",
    "ws": "^7.2.0",
    "xml2js": "^0.4.22",
    "xpath": "0.0.27",
    "yargs": "^14.0.0"
  },

I meant to remove the Tensorflow dependency and then run npm install

yeah I tried removing Tensorflow dependency first and I ran npm install I got same error and then I tried npm i<EMAIL_ADDRESS>and still the same issue

That's weird. Have you tried a clean start? you could start a new project in a different director, and try to install danfo-node without TensorFlow dependency added  Meanwhile, I'll try to replicate your issue here. What is your OS spec?

I tried deleting node_modules several times, with and without TensorFlow dependency. I'm on windows 10 x64.

You can actually use Tensorflowjs with directly install it. Since it is a dependency of danfojs, it gets installed automatically. So I'm definitely sure the issue is coming from windows build.

Try installing version 2.1.0 of Tensorflowjs and see if you can build it successfully.

If not, you may need to download the windows-build-tools (https://github.com/tensorflow/tfjs/blob/master/tfjs-node/WINDOWS_TROUBLESHOOTING.md#msbuildexe-exceptions

If you can successfully build TFjs, then, Do a clean start, and npm install danfojs-node in your project. Do not install Tensorflowjs again, and do not add it to the package.json file. You should be able to import and use it.

I did all these steps already and I just did it again since you asked me. Just to mention I have both python 2.7 and 3.8 and I suspect I have to set a default to target one of them.

Did you solve this issue?

no unfortunatly I am still looking for solution. I am going to try different node versions to see if it will work

I also was using a different node.js version that Electron was. so I installed node.js version is the same as the version of Electron is using (12.16.3)  and that solve the problem

That's great, I'll go ahead and close this issue now.


change docs when installing typings global install

typings install --save --ambient firebase will results in
typings ERR! deprecated The "ambient" flag is deprecated. Please use "global" instead
typings install --save -g firebase will fix it

I signed it!

Hi @udnisap!
Thanks for the PR! However, we no longer use typings as we ship with the firebase.d.ts file now. In the future the firebase sdk will ship with them and we will reference those.
Cheers,
David


HTML cell contents are incorrectly rendered in the filter

(Original issue 23 created by altmany on 2011-12-12T15:55:46+00:00)
What steps will reproduce the problem?
1. Create a JTable with some HTML cell contents. For example: "<html><b>bold
text"
2. Notice that the cell displays the cell contents correctly (i.e., as a bold text
in this example). This is because JTables accept HTML strings, just as in other Swing
components.
3. Apply a filter with auto choices to this table

What is the expected output? What do you see instead?
The filter displays the data as "\<html><b>bold text" instead
of rendering it as an HTML-formatted label. This makes the filter ugly and unusable
for any table column that contains HTML contents.

What version of the product are you using? On what operating system?
4.2.0 on JVM 1.6.0u17, WinXP

Please provide any additional information below.
Notice that if I use CustomChoices instead of the AutoChoices, then the HTML string
*does* render as expected (i.e., with all the relevant HTML formatting).

Original issue reported on code.google.com by altmany on 2011-12-12 15:55:46

(Original issue 23 last updated on 2011-12-12T15:55:46+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by coderazzi on 2011-12-17T09:12:26+00:00)
Hi,

Yep, I see the problem; the reason why the filter displays it as '\<html>....' is because
when it is evaluated, without the initial backslash it would interpretate it as the
minus operator.

In addition, the default filter works as a regular expression matcher, so it is totally
oblivious to html content -would work in most of the cases, anyway.

I will check how to better implement it,

Cheers,

  Lu.

Original issue reported on code.google.com by coderazzi on 2011-12-17 09:12:26

(Original comment by coderazzi on 2012-01-16T22:44:46+00:00)
Fixed on release 4.3.0

Original issue reported on code.google.com by coderazzi on 2012-01-16 22:44:46


Update pattern-matching.md

Commented lines translated into Spanish

I've prepared a stage to preview changes. Open stage or view logs.

Thanks @RTJ!
@erickgnavar / @jesusangelm this one too if you have a moment, thank you

@erickgnavar is this PR good to merge?

Yep, sorry for the late response

No worries, I appreciate all of your help!

Thank you @RTJ!


Add support for metadata API

Motivation
In order to reduce memory and I/O pressure, we can use the (undocumented) metadata API. Instead of retrieving an entire object, we can retrieve only the metadata. This is useful in lots of scenarios where users might not be interested in the spec or status.

Solution
Metadata-only requests are made possible through the REST API by including an extended Accept header. The header will notify the API Server a JSON response is expected, and it will encode an additional 'as=PartialObjectMetadata' k=v pair to receive only the metadata of the object. This is more efficient when only the metadata needs to be parsed (as opposed to the whole spec).
To make it possible to use the API, this change adds new (metadata specific) request impls in kube-core, and new metadata methods on the Api<K> type. Unfortunately, the methods on the Api type get complicated really quickly when attempting to preserve the function signatures originally posted in #1027. Deserializing the wire format we have in the response directly into an ObjectMeta type works if we first deserialize into a Value and then into the concrete type. For wrapper types (such as in list_metadata or watch_metadata) this gets even more complex.
To get around it, I've added a new PartialObjectMeta type that is supposed to mirror the Go counterpart. A wrapper list has also been added. Both of these support conversions to ObjectMeta (or ObjectList<ObjectMeta>). This makes it a bit neater to implement everything.
This is still WIP (so the code is not super tidy), I wanted to show the progress and find a consensus moving forward (or even some ideas on how we could deserialize this better if we're not happy with the PartialObject types).

 Sending requests through curl
Thought it might be helpful. This helped me look at the format a bit more closely.
First, run kubectl proxy & and then send requests with curl
# Get a deployment's metadata
curl -H "Accept: application/json;as=PartialObjectMetadata;g=meta.k8s.io;v=v1" http://localhost:8001/apis/apps/v1/namespaces/kube-system/d
eployments/foo

# List a deployment(s) metadata
 curl -H "Accept: application/json;as=PartialObjectMetadataList;g=meta.k8s.io;v=v1" http://localhost:8001/apis/apps/v1/namespaces/kube-syst
em/deployments

# Watch
curl -H "Accept: application/json;as=PartialObjectMetadata;g=meta.k8s.io;v=v1" "http://localhost:8001/api/v1/namespaces/kube-system/pods?&
watch=true&resourceVersion=0&timeoutSeconds=290&allowWatchBookmarks=true"

Closes https://github.com/kube-rs/kube/issues/1027
Signed-off-by: Matei David<EMAIL_ADDRESS>

Thanks a lot for the review! Added docs, might need some wordsmithing though. Thanks for the nightly toolchain and just recipe tip (yay for more just! makes my life easier). Fixed a unit test, put up docs, expanded the integration test. Let's hope we're all green :D

Codecov Report

Merging #1137 (8b6bcb9) into main (4c26615) will increase coverage by 0.29%.
The diff coverage is 77.24%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
+ Coverage   72.48%   72.78%   +0.29%
==========================================
  Files          65       66       +1
  Lines        4896     5063     +167
==========================================
+ Hits         3549     3685     +136
- Misses       1347     1378      +31

Impacted Files
Coverage Δ

kube-core/src/metadata.rs
15.38% <15.38%> (ø)

kube-client/src/api/core_methods.rs
71.83% <46.15%> (-14.84%)
:arrow_down:

kube-core/src/request.rs
94.41% <88.77%> (-1.99%)
:arrow_down:

kube-client/src/lib.rs
93.88% <93.33%> (-0.12%)
:arrow_down:

kube-core/src/resource.rs
53.57% <0.00%> (+8.33%)
:arrow_up:

This is all sensible to me. As discussed on discord, a watcher setup would be nice, but it's non-trivial without any further indirection so let's put a clear break here for now.
CI is green (EDIT: github was lagging, hopefully still after the approval) apart from the unrelated deny issue, so all good for me. Can merge tomorrow unless you have objections.

No objections :) will start playing with the code to see how we can get a watcher setup working


Document AudioServer.playback_speed_scale in Engine.time_scale

This also documents physics_ticks_per_second not being automatically adjusted, which can be important when speeding up simulation.

Thanks!


Time taken for carbon removal as a metric

Hello CarbonPlan,
This database is fantastic, thank you so much for providing this.
One of the main issues I have when considering carbon removal projects for clients is the time taken for a tonne of carbon dioxide to be removed.
For example, a lot of afforestation / tree-planting projects and other nature-based solutions are calculated over the lifetime of the tree.  So if a tree takes 50 years to sequester 1 tonne, the price of the 1 tonne of carbon reflects purchasing that 1 tree, but there is no factoring in the time.  Companies therefore claim that that 1 tonne has been dealt with / neutralised, whereas in fact it won't be absorbed for another 50 years.
With CDR projects such as Climeworks, when you pay for 1 tonne of removals that tonne will be gone within a year, approximately, allowing for the administration and backlog etc of the company.
Therefore, could you add in an additional metric which is called something like 'time to removal' or 'removal speed'?
As time is of the essence for climate change retardation, I think this is a crucial aspect when weighing up projects to invest in.
Thanks so much!
Emma Littlewood (Green Element and Compare Your Footprint).

Hi Emma,
Thanks for raising this issue, and apologies for the slow response. We totally agreed that the timeline of proposed offsetting solutions is important for understanding their climate impacts.
When a removal timeline is clearly represented in a project’s proposal, we try to include it in the volume notes (e.g. see this entry). But often, the timeline associated with the offered removal is ambiguous. This is frequently the case for forest and soil projects, as the offered credits are not usually clearly vintaged. For these projects, you might reference the project lifetime included in the Permanence comment (e.g. see this entry), which is equivalent to the range of possible removal dates.
Of course, understanding when a removal happens is just one piece of the puzzle. In our minds, how long removed carbon will be stored (i.e. the permanence metric) is much more important for understanding how a project will contribute to net zero goals, cumulative carbon emissions, and long-term warming.
Thanks again for your note, and we’ll think about how we can more consistently represent the information you’re hoping to find.
Freya

Closing this issue for now. Thanks again for reaching out, Emma!


Add prop function

As discussed in #159. I've a few reservations about this, firstly if I define S.prop as var prop = S.prop = def(... then I get lots of errors in the tests when I replace instances of R.prop in index.js:

TypeError: prop is not a function
at createSanctuary (/home/stefano/git/sanctuary/index.js:9:16296)
at /home/stefano/git/sanctuary/index.js:9:45767
at _ (/home/stefano/git/sanctuary/index.js:9:268)
at Object. (/home/stefano/git/sanctuary/index.js:9:779)

Another thing is that Accessible is a very permissive type for this function, it allows you to pass numbers or booleans in even though they don't support property access so you end up getting error messages that leak implementation details to the user:
S.prop('a', true)
// => TypeError: Cannot use 'in' operator to search for 'a' in true

Also, I think it's strange that a function that operates on Records should consider keys that are present in the prototype chain. What are people's thoughts?

I think it's strange that a function that operates on Records should consider keys that are present in the prototype chain.

It's not clear to me which is the most appropriate membership check.
I can, though, provide what I believe is a compelling example in favour of key in obj:
//  Pair :: (a, b) -> Pair a b
function Pair(fst, snd) {
  this[0] = fst;
  this[1] = snd;
}

Pair.prototype.length = 2;

Should S.prop('length', new Pair(0, 0)) evaluate to 2? I argue that it should. Otherwise we'd be drawing a distinction between two equivalent implementations (length as a prototype property or as an instance property).
Also, the usual traps with inherited properties affect object-as-dictionary rather than object-as-record. When using an object to keep track of claimed usernames, name in usernames would erroneously evaluate true for name values such as 'toString' and 'valueOf'. When using an object as a record, though, one asks for a known property. Presumably if one writes S.prop('toString', obj) one wants to reference the toString method of obj (regardless of whether it's attached to obj directly).

So kind of a more type-dangerous get? Might be nice to mention get in the description (and this in the description for get.. do we have @sees?), how they're different, when you might use one vs the other.
Should we include props in this PR?

prop and get are certainly related, but should be used in different contexts. get and gets perform a role similar to that of Haskell's Aeson library: providing a safe way to interact with uncertain data.
We don't use @see (as I detest JSDoc), but we should certainly include reciprocal links and a sentence or two describing the differences.

prop and get are certainly related, but should be used in different contexts. get and gets perform a role similar to that of Haskell's Aeson library: providing a safe way to interact with uncertain data.

Ya, I was thinking something along those lines.

as I detest JSDoc

ha!

You make a convincing case for key in obj, David. Regarding my second point, do you think we should tighten up the definition of Accessible to something like this:
function(x) { return x != null && R.contains(_type(x), ['Array', 'Function', 'Object', 'String']); }

I still have no idea why I can't use S.prop in the file before it's defined even though I declare it as a var (I assumed hoisting would take care of that). It would be nice for use to eat our own dogfood rather than relying on R.prop.

[D]o you think we should tighten up the definition of Accessible[?]

What's the motivation for doing so?

I still have no idea why I can't use S.prop in the file before it's defined even though I declare it as a var (I assumed hoisting would take care of that).

There are two different concepts in JavaScript referred to as "hoisting": var hoisting, and function declaration hoisting.
When one writes…
(function() {
  console.log(x);
  var x = 42;
}());

var hoisting means one has effectively written…
(function() {
  var x;
  console.log(x);
  x = 42;
}());

This will log undefined rather than throw a ReferenceError as one would expect without var hoisting. Note, though, that it does not log 42.

It would be nice for use to eat our own dogfood rather than relying on R.prop.

We could do so by defining prop near the top of the file…
var prop =
def(…);

then assigning prop to S.prop at the appropriate point in the file.

What's the motivation for doing so?

Because R.prop as it is currently defined will not throw the correct type error if we pass a primitive value in and instead we'll get something like TypeError: Cannot use 'in' operator to search for 'a' in true. If Accessible is supposed to represent types that allow property access then why does it allow primitive types that don't?

Thanks for the explanation, Stefano! I now understand the motivation. :)

If Accessible is supposed to represent types that allow property access then why does it allow primitive types that don't?

Primitive values other than null and undefined support property access:
> true.a
undefined

> 'foo'.toUpperCase()
'FOO'

So Accessible isn't quite right, in this case. We could remove the constraint and determine whether the second argument is valid in the function body. This would enable consistent error messages:
S.prop('x', null);
// ! No ‘x’ property in null

S.prop('x', {});
// ! No ‘x’ property in {}

Primitive values other than null and undefined support property access:

Ah yes, through the magic of autoboxing. Although something like 1.toString() is a syntax error so you have to do 1['toString']()

We could remove the constraint and determine whether the second argument is valid in the function body.

Sounds good, I should be able to work on this later on today.

Although something like 1.toString() is a syntax error so you have to do 1['toString']()

… or (1).toString() or 1..toString(). ;)

1..toString()

Ha. That's a new one, how does that work?

1. is a valid representation of one. The double dot removes the "decimal" ambiguity, I assume.

This implementation got really hairy in the end. To support S.prop('length') for strings I've had to manually autobox the final argument; given that I had to override the linter to do so this all seems a bit wrong.

I don't see a reason to support S.prop('length', 'abc') but not S.prop('toFixed', 42).
We should be able to use the Object function to simplify matters:
-        if (typeof obj === 'string') {
-          /*jshint -W053 */
-          obj = new String(obj);
-          /*jshint +W053 */
-        }
-        if (obj != null && typeof obj !== 'number' &&
-           typeof obj !== 'boolean' && key in obj) {
+        if (obj != null && key in Object(obj)) {

Ah yes, that's much better.
:zap:

Actually, can we remove the null check and reinstate the Accessible type constraint now?

Actually, can we remove the null check and reinstate the Accessible type constraint now?

Wouldn't that send us back here?

Wouldn't that send us back here?

Not if we do something like this:
var boxed = Object(obj);
if (key in boxed) {
  return boxed[key];
...

Ah, I see what you're saying. Sounds great to me!

This is shaping up a lot better now. :zap:

It's a shame we can't leave custom reactions to comments like :zap:

It's a shame we can't leave custom reactions to comments like :zap:

Haha! With :zap:, though, the fact that a comment generates an email notification is usually desirable.

Actually, that's a good point.

Is there any more that needs to be done on this?

Is there any more that needs to be done on this?

No, but I'd like to do a few other things before merging this pull request:

Update and merge plaid/sanctuary-def#38
Publish<EMAIL_ADDRESS>Submit and merge a pull request to update our sanctuary-def dependency (to address #165)
Publish<EMAIL_ADDRESS>
I plan to take care of these things this evening. :)

I plan to take care of these things this evening. :)

Actually, I did my tax return this evening instead. :\

Haha. Rather you than me!

Could you rebase this branch, Stefano?

Yes, of course. :zap:

You'll need to update the expected error messages. ;)
While you're at it, you can take advantage of the assert.throws :alien:.

Yup, on it!

:deciduous_tree: Thank you for persevering with this one, Stefano!

A surprisingly tricky one!


npm run setup never ends up

I cloned the repository and then ran "npm run setup" and it never ends up. About a week ago it worked normally but now it never ends up. What I see is "Installing dependencies... ".

When I finished writing this issue it finally ended up! It took so much time, but if ended up!

After setup completes, does npm start work?
Network problems?
If you do another clone and setup does it take a long time, or complete normally?

I did another clone and did "npm run setup". It ended up only after 8 minutes! No network problems. During this time I see only "Installing dependencies... " in console. After this npm run start works normally.

This isn't really a bug with this boilerplate, that's just your network/npm being slow!


background color

hello,
I am looking for a way to change the background color of the interface, but I don't find which file I have to modify and I don't have very good knowledge in HTML/CSS/JS.
I already try to modify the /themes/Style.css file but it done nothing.
Can you hlp me ?

Hello,
It's really not an easy thing if you'r not familiar with this.
The interfac'e is build on jquery-ui which offers some preset theme and it's what I used.
If you're looking at the css used, you'll find them into /js/jquery-ui but don't think about a full revamping. There're a lot of parameter and some graphical objects used too.
Hope you'll find what you're looking for ;)

I try to modify the theme using the link in the jquery-ui.css file, but it's not working.
thank you for the answer even if i don't succeed i learn something today ;)

Yes, style of jquery-ui elements are not easy to modify.
The backgound alone is in the the theme/style.css (background-color) but it's the smallest part of the css.


added all contributors cli

Fixes #34
Description: I have used all-contributors bot for automating adding the contributors. Here are the set of commands for adding the contributors to your README.md. Please let me know if anything else is needed. Thanks! 😄

Hello @ShreyaPrasad1209 Can you please tell, why you've pushed the whole node_module folder. Is there any requirement specific for the same?


Pasted Signatures are not updated after initial paste

Describe the bug
Pasting works now from everywhere 🥳
But once you paste the signatures the list does not get populated. You need to deselect the system and select it again to update.
Expected behavior
Signatures should immidiately show up after pasting.

in /src/Pages/Mapper/Overview.cs:line 447
whmapper_1  | fail: WHMapper.Services.EveAPI.EveAPIServices[0]
whmapper_1  |       On NotifyWormholeSignaturesChanged error
whmapper_1  |       System.NullReferenceException: Object reference not set to an instance of an object.
whmapper_1  |          at WHMapper.Pages.Mapper.Overview.b__99_12(String user, Int32 mapId, Int32 wormholeId)


Question on feature usage

You mention that this plugin can do all this more than iconize:
Download and import icon packs
Use Twitter-style emojis
Type icons directly into your notes
Show icons beside links
Show icons beside note titles
Obey icon and icon Color properties
Auto-set icons based on filename rules
Customize icon size & margins
Other than click the menu in the upper right or right clicking a folder or file. That is only 2 features that I can get to work.  I don't see any way to do any of the above mentioned items and no instructions either.  I am just trying to get an icon in my note.  How is that done?
Thanks.

Sorry for the confusion! That section of the readme is a feature comparison with Iconize, and the bullet points you've listed are the features this plugin doesn't support.
See: How is this plugin different from Iconize?

Ah, sorry about that. I should have caught that.  Thanks for responding!


Rename and move RefreshableDataView

It's confusing because it is a view and we import it from views module but actually we use it as an Item in boxes! Besides it's uses the term "data" but truly it works only for charts (with display=Item.AS_HIGHCHARTS), when using it as an Item.
Of course if user defines a child of RefreshableDataView, he can return everything he wants from the get function, and use it as he wishes in a custom template.
I think RefreshableContent would be a good compromise. But then where to put it?

Renamed PartialResponse since it returns JSON as update content.


ci(test): collect environment secrets from a prepared staging environment

Summary
This PR updates the integration tests to use a staging environment 🔐 for workflow jobs. This staging environment has an access check that requires approval from @slackapi/developer-tools and then grants access to environment secrets when running the jobs.
The previous pull_request_target access_check checks were reverted here but a note remains in the maintainer's guide.
Notes
Using environment might act as a "deployment" which will appear on the repo home page. I suggest we hide this since the staging environment is only used in testing.
Reference

https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment
https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-environment

Requirements

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

This is epic!

The pull_request_target jobs should disappear once main is updated!

@seratch thanks! I'll forgo pressing the "start all waiting jobs" button - leaving this to you or any other reviewer! - but think we'll need one more secret for this to work 🔑 🤐

But it might be interesting to run these tests before the secret appears to see if we can break things 😏

Just tested without the SLACK_WEBHOOK_URL repository secret and the job failed! This is kinda what I wanted. Going to add this back as an environment secret and try again.

Awesome that works 👍  Will merge now and hope for the same with @dependabot. Appreciate all of the reviews 🙌


iotop not working

This bug-tracker is monitored by developers and other technical types.  We like detail!  So please use this form and tell us, concisely but precisely, what's up.  Please fill out ALL THE FIELDS!
If you have a feature request, please post to the UserVoice.  If you're reporting a BSOD, don't post here!  Instead, e-mail<EMAIL_ADDRESS>and if possible attach the minidump from "C:\Windows\minidump".

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.15063]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

install iotop
try to execute iotop

What's wrong / what should be happening instead:
program should start but doesn't

Strace of the failing command, if applicable:  (If <cmd> is failing, then run strace -o strace.txt -ff <cmd>, and post the strace.txt output here)

See our contributing instructions for assistance.

Also experiencing the same issue with build 16184

CONFIG_TASKSTATS, CONFIG_TASK_DELAY_ACCT, CONFIG_TASK_IO_ACCOUNTING would be a User Voice feature request kind of thing. Not supported at the moment.


CI failing

Because of https://github.com/tox-dev/tox/issues/1785

Fixed in tox 3.21.1

Fixed in tox 3.21.1


[JIRA-1] editconfig crate

Description
.editconfig 만들었습니다.
Fixes # (issue)
Type of change
Please select the relevant option.

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[x] Other

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings or errors
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)
Please include screenshots of the change if applicable.

머지합니다.


cargo-semver-checks: 0.23.0 -> 0.24.0

Diff: https://github.com/obi1kenobi/cargo-semver-checks/compare/v0.23.0...v0.24.0
Changelog: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.24.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259806 run on x86_64-linux 1

1 package built:

cargo-semver-checks


Use single quotation mark in java-args

to escape double quotes in some JVM_OPITIONS
enable disabled tests
add related issue to MathLoadTest_bigdecimal_special test

Fixes #2042
Signed-off-by: renfeiw<EMAIL_ADDRESS>

tested internally: Grinder_TKG/834

Tested disabled target internally for linux and win platforms. MathLoadTest_bigdecimal_special was hang due to a known issue, use the issue link to disable it.

linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/149/console
win: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/150/console

Hi @renfeiw - is there a way to run the targets enabled by this PR to see if they work with your fix in the quotation?
For example, I was looking for the Daa load test targets that are now being re-enabled (e.g. DaaLoadTest_daa1_special) in the Grinders you ran, but couldn't find them there.
Or, are they being tested somewhere else?

re: https://github.com/AdoptOpenJDK/openjdk-tests/pull/2044#issuecomment-725637638 Sorry for the confusion, I have updated the build links.


Ashenafi: Component Based Design, 3 chapters

progress

[x]  🥚Write elements with JSX syntax

🥚functional React components: you can ...

[x] Create a React function component (both function definition and arrow function styles)
[x] Import/export components between files
🥚 Render data: you can
[x] Use interpolation ({}) to insert JavaScript expressions into JSX
[x] Render a list using the .map method
🥚 Components and props : you can ...
[x] create a  reusable pieces of components
[x] how to pass props into React components
🥚 Create reusable components: you can ...
[x] Nest components within other components

one folder with a main component
sub-components for your convenience (not part of public contract)

🐣deeper look in hooks:
[ ] make your own counter hook
[ ] useState  not shared between components
[ ] useEffect (any side-effect)
🐣 create components that manage internal state and emit custom events
[ ] handling events
[ ] build reusable components that take functions as arguments
[ ] child components communicating with parent components
[ ] passing functions as props
[ ] 🐥 splitting components with logic in mind

why create dumb components when hooks can be anywhere?

[ ] re-render cycles (all children)

why putting state at lower levels is efficient
why not to use everything in global state

[ ] 🐥 fetch and use API data in components
[ ] async useEffect callbacks
[ ] 🐔react router
🐔being careful about what you put in useContext

[ ] only move data to context when it's necessary
[ ] store and manage global app state shared between components

🐔useContext
[ ] other state management systems/strategies exist

Check-in
Chapter 1 : Rendering Data

I have pushed my progresses to the exercise repos Google Twitter

I Need Help With:
  -

What went well?

The fact that react is a JavaScript library and uses JS syntax makes it relatively easy to understand the concepts.
I have a good practice to the basic concepts by working on the exercises.

What went less well?
 -

Lessons Learned

JSX syntax
components
props
creating reusable components
nesting components
using .map to render lists

Sunday Prep Work

reading about stateful Components

Check-in
Chapter 2: Stateful Components and Events

I have pushed my progresses to the exercise repo

I Need Help With:
  -

What went well?

The lecture class at beacon was very helpful
I like the flow of concepts in the modules from basic JavaScript to react, the the JS library

What went less well?
 -

Lessons Learned

React hooks

useState
useEffect

Handling events

Sunday Prep Work

working on the movie list deliverable


Version 0.1.0

Fix review issues to be able to make the first version.

@georgms I will merge it today and create a release. Please add a comment here if you have anything to add.


Curvature range

I am playing around with the vedo library a bit and find it super helpful to work with surfaces. In particular, I turn point clouds into surfaces with recoSurface() and then measure curvatures with the addcurvatureScalar() function and the Gaussian curvature method.
The visualized surface looks like this:

According to the definition of the curvature method, the algorithm takes into account the edges connecting an individual vertex with its neighbours. I was wondering if it was possible to increase the range within which points will be considered as neighbours and thus calculate the curvature in a bit more global fashion? Because for a sufficiently large amount of points, any surface will appear locally flat (as in the screenshot), but I'm more interested in the larger-scale curvatures.
Do you have a suggestion on how to do this? Any tips are greatly appreciated :)

Hi, Thanks for your interest!
There are 3 different metrics for curvature but as you say they mostly grab the local curvature of the neighbor vertices.
So I see a few options to get a sort of "wider-range" measurement.
One could be to smooth out your mesh surface to make the neighbor vertices more representative of the average region around them. This can be done with mesh.smooth(). You can also subdivide() your mesh which has a similar effect (check out examples/advanced/mesh_smoother2.py.
There is also the possibility to explicitly fit a sphere to a 3d point cloud (this is done analytically in vedo so it's very fast), from that you can extract the curvature (inverse of the radius) of any region of your choice, here you have an example with a random mesh (actually a mouse limb shape). Click on the surface to fit 20 points:
from vedo import *
from vedo.pyplot import histogram

#msh = Torus()
msh = Mesh(dataurl+'290.vtk').scale(100)

msh.addCurvatureScalars( method=2 ).print()
name = 'Maximum_Curvature' # names: Gauss_Curvature Mean_Curvature Maximum_Curvature
msh.cmap('PRGn', name, vmin=-0.01, vmax=0.01)
msh.addScalarBar()

txt = Text2D(bg='yellow', font='Calco')

arr = msh.pointdata[name] # numpy array
histo = histogram(arr, bins=50)

def func(event):
    p = event.picked3d
    if p is None:
        return
    pts = msh.closestPoint(p, N=20)
    pts = Points(pts, r=6)  # make it a vedo object
    s = fitSphere(pts).alpha(0.1)
    txt.text(f'radius: {s.radius}\nresidue: {s.residue}')
    plt.add([s, pts])

plt = Plotter(N=2, sharecam=False)
plt.addCallback('mouse click', func)
plt.show(msh, txt, at=0)
plt.show(histo, at=1)
plt.interactive().close()

I would like to keep the surface density of vertices constant; I currently do this with the densify() function.

oh clever! Aside from (or along with) densify() you can also use clean(tol=...) with tol being a fraction of the bounding box size (a meaningful value is typically around 0.02) with ensure that any 2 points in the pointcloud will be at least separated by that distance... this will make the cloud very nice and uniform!

I could then iterate over all the vertices on the surface, extract all neighbors within a defined range and fit a sphere to these. I'll try this and let you know 👍

This is where I end up with this, which is pretty much what I had in mind:

Would you be interested in having this included as a small example script on the documentation pages?

you can also use clean(tol=...) with tol being a fraction of the bounding box

I tried that, too, like this:
pts4vedo = vedo.Points(my_point_array).clean(tol=0.02).densify(targetDistance=0.25)

but I'm receiving a warning there:
[vedo.pointcloud.py:1581] WARNING: clean(tol=...), please use subsample(fraction=...)

Can I ignore/turn off this warning somehow? I assume that subsample operates on the point cloud such that it removes every k-th vertex whereas clean operates on a distance criteria so the distance-based operation would be the way to go for me.
Also, another follow-up question: It should be possible to determine the sign of the curvature from the curve-fitting approach from above by comparing the normal vector at the point of interest n_i with the vector of the fitted sphere towards this point v. The sign of np.dot(n_i, v) should correspond to the sign of the curvature - right? Or is there a simpler way to do this in vedo?

Would you be interested in having this included as a small example script on the documentation pages?

Sure - feel free to submit a PR.

I'm receiving a warning there:

oh OK you are already using the latest version... so forget clean() it's just a renaming.

It should be possible to determine the sign of the curvature

Yes! You can do it the way you just describe using the normals (mesh.computeNormals() and mesh.normals() to get the numpy array).

BTW, be careful that in the transition from positive to negative radii there is a ..zero! You will notice that if you try fitting a very flat region you actually get a small (and unstable) radius. That's why you may also want to consider the fit residue.

@jo-mueller I am also interested in this. I would be happy if you could share an example for this.

There goes :) I'm not so seasoned on visualizing with vedo, though.


Consistent path

Currently, __DIR__ returns two different things in middleman-php and the real server. Probably a matter of changing the working directory to the location of the PHP file. I can look into this soon and submit a PR.

Good catch :+1:


optimization for scanRight

should perform better for IndexedSeqs

Thx!

Current coverage is 90.71%

Merging #842 into master will not affect coverage as of 346ec96

@@            master    #842   diff @@
======================================
  Files           79      79
  Stmts         8480    8480
  Branches      1691    1691
  Methods          0       0
======================================
  Hit           7693    7693
  Partial        211     211
  Missed         576     576

Review entire Coverage Diff as of 346ec96

Powered by Codecov. Updated on successful CI builds.


Migrate /etc/environment modifications to helpers

Description
Improvement
Use functions from helpers/etc-environment.sh in order to

modify /etc/environment from install scripts:

installers/rust.sh
installers/1604/php.sh
installers/1604/php.sh
installers/dotnetcore-sdk.sh

remove legacy updatepath.sh used to modify /etc/environment
rename the helpers functions for better readability

Related issue:
https://github.com/actions/virtual-environments-internal/issues/334
Check list

[x ] Related issue / work item is attached
[x ] Changes are tested and related VM images are successfully generated

/azp run ubuntu1604, ubuntu1804


Fix to allow owner of list to view list that is Friends Only.

I made a new account, made a new private list afterwards, then changed the privacy of the list to Friends Only. Now I can't view my own list. I think it's because the Cache does not have my friends list, but the line also isn't checking to see if I'm the owner of the list to begin with. I also fixed subsequent lines to match bracket placement.

Ahh. thank you! :)


fix(test): slow query schema

Codecov Report

Merging #1372 (5d772b0) into master (00fd549) will decrease coverage by 1.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   26.16%   24.81%   -1.36%
==========================================
  Files         200      166      -34
  Lines       15371    14828     -543
  Branches       99        0      -99
==========================================
- Hits         4022     3679     -343
+ Misses      11078    10878     -200
  Partials      271      271

Flag
Coverage Δ

be_unit_test
27.59% <ø> (+0.01%)
:arrow_up:

e2e_test
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fd549...5d772b0. Read the comment docs.


current version issues

Unsure what is going on with versions here, the latest update is applied to the develop branch? why is this?
I am using platform = https://github.com/HelTecAutomation/platform-asrmicro650x.git#develop but its still not picking up as 1.6 release, and of course its the old 1.4 framework release.
Can we get a full release with the latest framework package 1.5 too, we are lagging behind.
Cheers
Jez

Please with to the new dev-platform https://registry.platformio.org/platforms/heltecautomation/heltec-cubecell


pycall tests fail with failure to load plugins with a recent pybind11 version (e.g. 2.6.0)

In GitLab by @jbigot on Nov 15, 2020, 16:34

This is due to an upstream pybind11 bug: https://github.com/pybind/pybind11/issues/2664
However, we do not provide much feedback about the actual loading error issue apart from the last one (in system path), that should be improved.

mentioned in commit 00065571fc828fdfe919d70f994f7c3295d48eb1

mentioned in commit 74fbbee1e4348f7ee76460c30bb81872f10b2168

mentioned in commit d778be2b021dd6665a251ffbae5c74fa1f2422ba

mentioned in commit a9a9db23555239c22c7547966ac49e1b4a51fbbc

mentioned in commit c7c49450dc9399f40516556eff575980c3c6ca69


Review EDA

https://spring.io/event-driven
https://www.oreilly.com/library/view/software-architecture-patterns/9781491971437/ch02.html
https://blog.avenuecode.com/event-driven-architecture-and-its-application-in-java-part-1?hsCtaTracking=e60e2a29-5459-46f1-848f-570d07f5f0fc|0ca49065-68f4-4201-9ef8-548108484f76
https://www.lightbend.com/blog/reactive-in-practice-java-development-guide-to-event-driven-systems
https://axoniq.io/#0
https://aws.amazon.com/event-driven-architecture/

https://www.confluent.io/blog/journey-to-event-driven-part-1-why-event-first-thinking-changes-everything/


(chore) Fix typescript type exports

Resolved #2945.
Changes

Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md

@joshgoebel can you please backport this into v10? I'd be happy to migrate to v11, but unfortunately I can't, because I use dynamic imports, see https://github.com/webpack/webpack/issues/13865

V10.0 is about to drop off the supported list entirely.   The core team really does not have time to support multiple versions.  Even a PR here isn't super trivial as it would have to pull over the new changes but then also back out the changes to types that occurred between 10 -> 11.

but unfortunately I can't, because I use dynamic imports, see webpack/webpack#13865

import isn't the only way to use the library.  You could use the stand-alone JS builds (as a separate file even) or even append our web build at the very end of your build process (I'm sure Webpack has a way of doing this).  So there are ways to use v11 with Webpack despite the bug.

If the exports was a huge issue we might perhaps drop them entirely, but it seems only a few broken tools are having issues and that mostly everything else works - unless others would like to chime in here.

More context: we're developing a component library, and our Code component loads languages on demand in runtime depending on the passed language prop value. How would I do that without using dynamic imports or migrating away from webpack?
Source: https://github.com/JetBrains/ring-ui/blob/typescript/components/code/code.tsx#L15-L21

Well, I'm not a webpack person I have no idea what the magic comment is trying to do but I'd imagine for dynamic run-time dependencies (via import) you would just use the new ESM CDN builds that we publish (as of 11.2) unmodified... the grammars are all package up in individual files for dynamic usage... and the "main" Highlight.js bundle could be:

loaded separately
concated to the end of your web pack build
imported dynamically as well (via ESM CDN build)


Support KiND cluster for local dev environment

Describe the proposal
This is the proposal to support KiND. Unlike Minikube, KiND is running all k8s controllers in the single docker container so that it require to create VM.

[ ] Provide the document to use KiND for local dev environment
[ ] Update sample docs to support KiND

Update the docs to say KIND cluster is supported

@tcnghia is this done?

Since there is no bridge to docker0 network on a Mac (and maybe also Windows), none of the KinD IPs (nodes, LoadBalancers) are accessible from the host network. Currently, this is one thing our e2e tests are assuming. We can change the e2e tests to use port-forwarding instead. I see that we already have the facilities in the code.
On the doc side, we can always instruct te users to use kubectl port-forward (already done so in many places), so it isn't a problem.

This is where it can be placed: https://docs.dapr.io/operations/hosting/kubernetes/cluster/

Hello @tcnghia, please check if this WIP https://github.com/dapr/docs/pull/2038 is of some help for this task.

Thanks for taking this on @robsondepaula, PR looks great.

Thanks for the feedback @yaron2, PR updated.


Possibility to set the table page size

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

Changing datatable's limit (page size) doesn't change anything.
Expected behavior

Add possibility to set the page size  by changing the table [limit] input.
Reproduction of the problem

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Table version: 9.3.x

Angular version: 4.3.x

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

While this isn't a perfectly clean solution, this behavior can be emulated by using ViewChild to get the datatable's instance and then setting the limit directly like so..
@ViewChild(DatatableComponent)
datatable: DatatableComponent;

updateLimit(size) {
  this.datatable.limit = size;
  this.datatable.recalculatePages();
}

@incinirate - thanks for providing that example. Perhaps we should call recalc pages when u set limit.

@amcdnl Based on this issue am I to assume binding to [offset] and [limit] does nothing?
Do I need to take the approach @incinirate shows to be able to set these values?


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_90rmnrtr4l/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_90rmnrtr4l/clone/recipe/meta.yaml:29: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_90rmnrtr4l/clone/recipe/meta.yaml:33: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, reference https://spdx.org/licenses/
Errors were found


Add trailing slashes to URL conf paths

Description

This PR adds trailing slashes to two URLs that did not have those. This makes them more consistent with the rest of the URLs in the codebase and also makes it possible to call them from the frontend (which mandatorily suffixes a slash to API calls).
It will not affect any existing users as APPEND_SLASH setting should ideally redirect them to the right address.
Testing Instructions

Check out the branch and run the dev server just up.
Try visiting the changed URLs (with and without the slash).
Observe redirects when you visit the URL without the slash.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I'm not a hundred percent sure of the reason but I've always preferred trailing slashes after URLs because Django will automatically append those if you miss it but will never strip them if you add one accidentally.
Also, the URL config looks much cleaner and nests easily if each path segment ends with a slash, so for consistency, it's generally easier to just add the slash everywhere.

I don't think I've seen any linter that can catch missing trailing slashes but I'll definitely go through the URLs manually and ensure we're not missing any.

A unit test might be able to do it though, if not a linter (which I also doubt is able to given the programatic nature of these)?

@obulat suggested that for validation we can use the generateschema command and then pass it through a validation. Olga, can you share what tool you were using to validate the generated schema?

@dhruvkb I opened this PR with a proposal of a start to how we might validate it using Olga's approach: https://github.com/WordPress/openverse-api/pull/806
I'm not sure if it's the best way though and it doesn't appear to be currently catching the lack of trailing slashes on some endpoints, so it doesn't even seem to accomplish what we want from it anyway.

@sarayourfriend IIUC the specifications that the tool validates only check for a leading slash and not the trailing one.

We could write our own validation against the generated YAML schema to check for the trailing slashed at least... in addition to spec based validation (which seems useful anyway?).
We'd need to extend the validateopenapischema command to check the parsed YAML for trailing slashes and raise an error when appropriate. Do you think that could work?

+1, Staci. Makes sense to me!


KYLIN-4626 add set kylin home shell

Pull Request Test Coverage Report for Build 6118

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 28.056%

Files with Coverage Reduction
New Missed Lines
%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
66.67%

Totals

Change from base Build 6117:
-0.003%

Covered Lines:
26222

Relevant Lines:
93464

💛  - Coveralls

@xiaowangyu how do you see


⚠ ClamAV has degraded performance

In 2f36c72, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 0fda21d after 23 minutes.


Node version limited to 10.

Any way to use it with an updated node version ?
The lib looks great but node 10 is too old ... please change luisa-utils node requirements .
https://github.com/KlausSchaefers/luisa-util/blob/main/package.json

Hi,
thanks for pointing this out. Try
npm install<EMAIL_ADDRESS>


Form Error Messages for Administrator Roles Error

Invalid form submission should create an error message at the top of the form. At a minimum this should be a generic error message such as "Submission error, please correct invalid field(s).". Potentially it should also include the field name(s) and maybe details.
Currently this isn't a big problem as the forms are small and it's easy to see the field in error. But this will be an issue for longer forms.

This is actually just a problem when there's an error in the roles checkbox field group of Administrator insert/update.

This looks to be a FormFormer problem, where the general error message "Submission Error" is set upon any field error but seems to not be for a fieldset error, in this case the roles fieldset.

Fixed in FormFormer: https://github.com/it-all/FormFormer/commit/36be5cd0d0ac6ba2d247f5086c54417788d20de4


preround status optimization

We made optimization to the size of status messages. Instead of sending the preround certificate as in the original article, we count on the fact that preround messages will arrive no later than the following round, hence each participant is expected to be able to find proof of status messages at the end of the status round.
Thi optimization required a few tweaks like moving status message validation to the end of the round (instead of instantly) and doing union over preround messages from the same sender. Both are not trivial from the security aspect and actually expose us to some attacks (like a union of messages that can grow bigger and bigger).
The research team was not intimidated nor worried about the implications of that optimization. Dr. Barak & Gavrad were concerned about it.
A follow up to this optimization is a wider optimization. The certificate of preround messages is no special and it can be done also for SVP and commit certificate.
IMO, this should be thoroughly considered and analyzed by the research time before proceeding. I do recommend that we do find some way to optimize the size of Hare messages. Graphene is or just using IDs of messages are also good candidates.

@barakshani wrote:

Recall that our implementation deviates from the original protocol by not including in status messages a certificate (with preround messages). It's a computation-wired data tradeoff, since one could validate a status message given all of the preround messages. (a side note: in one of the summits we went over why we cannot to do this for proposal messages.) Hence, we first allow receiving preround messages during the entire execution; secondly, we propagate status messages without verifying their validity, which is done at the end of the status round.

Basically there are several issues here: allowing preround at all times, we take union of the sets if an adversarial miner sends more than one preround message (which may blow up our memory), it (not verifying status) may spam the entire network. We discussed this briefly in the last summit, and you didn't seem to be concerned about these issues. I think it will be good to consider it more deeply. It is possible that a resolution will come from adding refences to hare messages, as we discussed in the past, because then the wired data won't be that significant.

Note, the optimisation could not be done to SVP.

@gavraz wrote:

Just adding to what Barak said:

before - we could limit the receiver to hold no more than one preround message per sender (pubkey). A participant that wants to send a preround message could simply use the information he gathered to create a preround certificate. Attaching the certificates allows each receiver to validate it independently of what he witnessed.

after - since there are no preround certificates in status messages, a participant must have received all preround messages used to form the status message (assuming the status message is valid and provable). This situation required us to receive preround messages even after the preround round and even hold more than one message per sender. We optimized it a bit by holding only the union of preround message per sender and not the actual message but we are exposed to the same issue, we can be spammed over the union...

@jonZlotnik curious to get your take on this once you've had a chance to consider it


Relabel cp in buildroot for Fedora 31 and RHEL 8

By labeling cp with system_u:object_r:install_exec_t:s0 we allow it to copy labels unknown to the host. PR #799 introduces this for Fedora 32, but we should do the same for Fedora 31 and RHEL 8 as soon as the PR gets merged.
This work requires changing the build pipeline generation to something like this:

	selinuxOptions := osbuild.SELinuxStageOptions{
		FileContexts: "etc/selinux/targeted/contexts/files/file_contexts",
		Labels: map[string]string{
			"/usr/bin/cp": "system_u:object_r:install_exec_t:s0",
		},
	}

and regenerating all relevant test cases.

This might not work on Fedora 31 (which is nearing end of life anyway) and RHEL 8, because of bug 1777831.

Fedora 31 is EOL and RHEL 8 seems to work. Closing this.


OCPBUGS-11117: Upgrade glibc

@joepvd Pleases squash all the commits into a single one with some explanation in the commit message (this is a required step for passing ci/prow/check-commits-count).
ci/prow/e2e-aws-driver-toolkit-presubmit is broken and I will override it once we are ready for merging.

Backporting https://github.com/openshift/driver-toolkit/pull/131

/approve
/lgtm
/override ci/prow/e2e-aws-driver-toolkit-presubmit
/hold
Wait for https://github.com/openshift/driver-toolkit/pull/131 to reach 4.15 and 4.14 first.

/label backport-risk-assessed

/label cherry-pick-approve

/unhold


Document the ramifications of changing from syncFileSystem to Google Drive API

Create a list of things that will change if we decide to use Google Drive:

Application will be using Oauth to connect to Google Drive.

more to come...

Migration of files
Offline support/handling when to sync


community-operators ibm-spectrum-scale-csi-operator (2.2.0)

Signed-off-by: Chetan R Kulkarni<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Submit operators to both upstream-community-operators and community-operators at once
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@kulkarnicr Sinc you are previous contributor, can you have a look at changes if ok with you?

@kulkarnicr Since you are previous contributor, can you have a look at changes if ok with you?
@mvalarh , I am one of the previous contributor. These changes look good to me.

@kulkarnicr sorry my bad.


DOCS for APID ghs feature cc

Closing this PR due to unverified commits. The correct PR is at https://github.com/mulesoft/docs-design-center/pull/188

Closing this PR due to unverified commits. The correct PR is at https://github.com/mulesoft/docs-design-center/pull/188


Handle edge case in XXDecomposer when no basis fidelity is known

Summary
In the XXDecomposer class when run as part of the unitary synthesis pass there was a bug when the input value of the basis_fidelity field on the constructor was an empty dictionary. In that case when trying to find the best decomposition the code that loops over the possible decompositions would fail because there are no known fidelities to use for comparison. This commit fixes this issue by changing an infinite loop which was supposed to break on finding the best decomposition to only iterate while there are available decompositions to evaluate. Without this it is possible the loop will continue to try to iterate after there are no further decompositions to evaluate which when basis_fidelity is always on the second iteration because there is nothing to compare against.
Details and comments
Fixes #9935

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
12 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 85.407%

Files with Coverage Reduction
New Missed Lines
%

qiskit/circuit/tools/pi_check.py
1
91.23%

qiskit/pulse/library/waveform.py
3
91.67%

crates/accelerate/src/vf2_layout.rs
8
86.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
67647

Relevant Lines:
79205

💛  - Coveralls

I agree with Lev here and don't think this is the correct fix, I'm going to close this.


Fast Muter/Bypasser, with toggleRestriction Max/Always One, when muted and unmuted, all options get enabled

I have a Fast Muter inside a group. It's to manage ControlNet Preprocessors. It's in a group because I may not want that instance of controlnet to run at all. When I unmute the group, this node turns all options to "yes", despite the toggle restriction. Forcing me to click them all/most back over to "no".
Maybe there's a better way to handle this. I'm open to suggestions. Thanks!

related to #171

I found a workaround using the Repeater Node.

The toggleRestriction is only enforced when you actually toggle an item (by clicking on the toggle) and not if the nodes' modes are changed outside of the muter.
This is in the README and in the Node Help as well:

All to say, when you change a group to "enabled" that has it all linked to the Enable Processing? Fast Muter, it's not that Fast Muter is just updating the status, it's not doing anything functionally. (Also, the mute/enable status of that Fast Muter itself also has no bearing on functionality).
I'm glad you found a workaround! I can't think of something else off the top of my head, tbh.


Chat history for streamlit app

Is there any way to retain chat history in streamlit app just like flask ?

Streamlit is pretty limited in this respect -- to do a chat history with a sidebar isn't very straightforward with streamlit's execution model


[BUG] - Beta 8 and newer cause lag in animations for components in Card

Describe the bug
When using the Card component in Beta 8 or later, animations of components inside the card (e.g., hover with Button) experience a significant lag. Merely downgrading to Beta 7 removes the lag instantly.
Beta 8 & 9 - slow animations
https://user-images.githubusercontent.com/170023/174913771-0da76ce3-05bc-4407-b8f7-03fb85598222.mov
Beta 7 - fast animations
https://user-images.githubusercontent.com/170023/174913796-ed17fa13-b3e3-4f88-bb1a-8c263b49b98f.mov
Steps to Reproduce the Bug or Issue

Create a new Next.js project with the default NextUI setup.
Use this example _app.tsx page:import { Button, Card } from "@nextui-org/react";
import type { NextPage } from "next";

const Home: NextPage = () => {
  return (
    <Card>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
      <Button flat>Test</Button>
    </Card>
  );
};

export default Home;

Run next dev and experience the slow hover and click animations in the browser (as shown in the first screen recording above).
Downgrade to NextUI beta 7:yarn add<EMAIL_ADDRESS>

Run next dev and experience the fast hover and click animations in the browser (as shown in the second screen recording above).

Expected behavior
Expected smooth animations.
Operating System Version
OS: macOS 11.6.7
Processor: 2.8 GHz Quad-Core Intel Core i7
Memory: 16 GB 1600 MHz DDR3
Browser
Tested in Chrome and Safari, but slowness is more pronounced in Safari

Hi @DannyNemer have you tried beta9? I think the performance has been improved since then. Here's a working sample: https://codesandbox.io/s/multiple-buttons-3wevf4

Hi @DannyNemer have you tried beta9? I think the performance has been improved since then. Here's a working sample: https://codesandbox.io/s/multiple-buttons-3wevf4

@imchell Yep, performance issues are identical in beta9 as beta8

Ah I can reproduce it in Safari.

It seems this issue is coming from this style filter: var(--nextui-dropShadows-lg);
Current:

Set filter: none:

@DannyNemer
If you don't need shadow, you can avoid this issue with variant="flat"
  <Card variant="flat">
    <Button flat>Test</Button>
  </Card>

To fundamentally fix it, we can choose between several options, but let's wait for the maintainer's opinion first 😅

Hey @DannyNemer could you please share the specs of your machine?
I've tested it, on safari and chrome and it works without lag
https://user-images.githubusercontent.com/30373425/177015738-934ddabe-3b3c-49cc-b1fd-0ffe065499ad.mov
@TroyTae could you share the name of the tool you used for measuring the CPU?

@jrgarciadev
It's built-in tool of Safari (https://webkit.org/blog/8993/cpu-timeline-in-web-inspector/)
You can find timelines tab in Safari Web Inspector!

Thanks @TroyTae 🙏🏻

Hey @DannyNemer could you please share the specs of your machine?
I've tested it, on safari and chrome and it works without lag https://user-images.githubusercontent.com/30373425/177015738-934ddabe-3b3c-49cc-b1fd-0ffe065499ad.mov
@TroyTae could you share the name of the tool you used for measuring the CPU?

@jrgarciadev Thank you for investigating!
Specs:
OS: macOS 11.6.7
Processor: 2.8 GHz Quad-Core Intel Core i7
Memory: 16 GB 1600 MHz DDR3

I was able to replicate this issue by disabling hardware acceleration on Chrome/Brave. Safari also exhibits this issue. As suggested by @TroyTae, the lag can be mitigated by disabling shadows.

Hey guys, could you try again using the latest version v10? I've added box shadows for safari instead of a drop-shadow filter

Hey guys, could you try again using the latest version v10? I've added box shadows for safari instead of a drop-shadow filter

It's still laggy in Chrome but solved in Safari

Is this issue still active?

Is this issue still active?

Is this issue still active?

Persists on v10; changing the variant to flat helps.

Hey please update to v2.0 https://nextui.org/blog/nextui-v2 due to v1 will not receive more updates. New version is way more perfomant


[FEAT] Supplier Contact: display the execution count of the "email regenerate loop" in a overlay

This will show that we can update the value at runtime
Notes: this will be implemented with a hack as bpmn-visualization currently (v0.33.0) doesn't support it.
Remove overlays, then add a new one.

@tbouffard
Below are my attempts. The edge delay is set to 500.
1. Multiple overlay styles to mimic the style of the edge

2 & 3: Only one overlay style that is not changed
2. The following style is used:
font: { color: 'white', size: 20 },
fill: { color: 'rgba(0, 0, 255, 0.5)' },
stroke: { color: 'rgba(0, 0, 255, 0.5)', width: 2 }

3. The following style is used:
font: { color: 'white', size: 20 },
fill: { color: 'rgba(0, 0, 255, 0.7)' },
stroke: { color: 'rgba(0, 0, 255, 0.7)', width: 2 }

After discussion with @assynour and @csouchet, we decided to implement this issue and choose the option 1 described in https://github.com/process-analytics/bonita-day-demo-2023/issues/48#issuecomment-1483118456


Multiple Netatmo Homecoaches

I have two Netatmo Home Coaches, as well as a Weather Station with several modules.
Since the latest update of HomeAssistant, all Weather Station modules as well as one of the two Home Coaches are discovered. Before that, only the Weather Station modules were recognised
However, as said ... only one of the two Home Coaches show up ...

This is the bug/issue tracker for Home Assistant. Please use the forum for questions about installation, setup, configuration and usage.
If it's a bug, please re-open the issue with the issue template filled.


cmd/go: can't handle relative TMPDIR

It seems like go build is not able to handle non-absolute TMPDIR and fails to build instead.
go version
go version go1.9.2 linux/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/tmp/gopath"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/tmppath/go-build325593383=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
#!/bin/bash

# prepare testsetup
workdir=$(mktemp -d)
echo "Working in $workdir"
demofile=$workdir/gopath/src/a/demo.go
GOPATH=$workdir/gopath
mkdir -p /$workdir/gopath/src/a/
mkdir -p /$workdir/tmpfoo

cat > $demofile <<EOF
package main

import "fmt"

func main() {
	fmt.Println("Hello World")
}
EOF

# starting the tests

cd $workdir
echo 'This will succeed (1)'
go build a  # this will succeed
echo 'Yep it did (1)'

TMPDIR=$workdir/tmpfoo
echo 'This will succeed (2)'
go build a  # this will succeed
echo 'Yep it did (2)'

cd $workdir
TMPDIR=tmpfoo
echo 'This will fail (3)'
go build a  # this will fail, although the directory is present
echo 'Yep it did (3)'

What did you expect to see?
go build (3) in script above succeed as well as (1) and (2)
What did you see instead?
go build (3) in script above failing.

I'm not sure this is something we want to worry about supporting.  It seems simple enough to not do that.  Do most Unix tools support a relative TMPDIR?

I think if this is not supported, we should at least provide a more useful error message (the current error message is something along the lines of could not create $WORK/src/a/a.a: No such file or directory which took us a while to figure out).

This sounds like a good idea, if $TMPDIR doesn't fit through
https://godoc.org/path/filepath#IsAbs the go tool (or compiler, or both?)
should quit early with a reasonable error.
On Thu, Dec 28, 2017 at 11:22 AM, Axel Wagner<EMAIL_ADDRESS>wrote:

I think if this is not supported, we should at least provide a more useful
error message (the current error message is something along the lines of could
not create $WORK/src/a/a.a: No such file or directory which took us a
while to figure out).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/23264#issuecomment-354201873, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA-11VBTRNJgjqEBD5dMrWXSlaad0ks5tEt8ogaJpZM4RN5Up
.

I started adding this, but it doesn't reproduce anymore on tip, presumably because of the build cache changes. Some go commands still fail, if TMPDIR does not exist, even if they shouldn't use it at all (like go version) or if they seemingly don't actually need/use it (go build doesn't seem to actually write anything there anymore). There might still be places where this problem persists, so we might still add the check.
I think supporting a relative TMPDIR in the go tool would be as simple as erroring out: We can just call filepath.Abs on what os.TempDir returns to get an absolute path and use that. So I sent a CL to that effect.
I tried some of the POSIX interfaces to create temporary files and they all seem to do the same thing as Go in that regard: Use it just like /tmp and return a relative path. Meaning Go is consistent here with POSIX and that any C tool with a similar case (calling chdir(1), potentially in a child process). We could also consider doing that in os.TempDir directly, eliminating this problem in all Go code, but I'm not sure it's actually always the right thing to do.


[testutil] Pin winapi-util to 0.1.8

Closes #1572

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.70%. Comparing base (b43acd9) to head (a10f532).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   87.70%   87.70%
=======================================
  Files          15       15
  Lines        5563     5563
=======================================
  Hits         4879     4879
  Misses        684      684

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.