[C++] Move rank implementation into separate module

The rank kernel implementations are currently in vector_sort.cc, amongst other things.
To make the code more readable and faster to compiler, we should move them into their own file.
Reporter: Antoine Pitrou / @pitrou
Note: This issue was originally created as ARROW-18396. Please see the migration documentation for further details.

@pitrou / @benibus  -- It looks like this issue was taken care of as part of https://github.com/apache/arrow/pull/14753, which also resolved #33559. Is that correct? If so can this be closed, and if not can more information be added? As of right now it appears to me that the ranking kernel is in the vector_rank.cc file, but I'm very new to this codebase.

@chrisjordansquire Oh, yes, you're right. Thanks for noticing!


[Bug]: save_period argument in ultralytics.YOLO.train function is ignored  when checkpointing is enabled in add_wandb_callback

Describe the bug
OS version: Ubuntu 20.04.6 LTS (Focal Fossa)
Python version: 3.10.14
Used python-pip packages:
ultralytics==8.2.90
wandb==0.17.9
roboflow==1.1.44
torch==2.4.1

When enable_model_checkpointing=True is set in add_wandb_callback, the save_period argument in model.train is ignored, and the model is saved after every epoch, regardless of the specified save period. Here is the code snippet to reproduce it, in order for it to work you should provide your own roboflow and wandb api key:
import sys
import os
import wandb
import torch
from wandb.integration.ultralytics import add_wandb_callback
from roboflow import Roboflow
from ultralytics import YOLO

# Get API keys
ROBOFLOW_API = <your api key>
WANDB_API = <your api key>

# Initialize WandB
# os.environ['WANDB_MODE'] = 'disabled'
wandb.require("core")
wandb.login(key=WANDB_API)
wandb.init(project="football_yolov9", job_type="training")

# Set up Roboflow dataset
rf = Roboflow(api_key=ROBOFLOW_API)
project = rf.workspace("roboflow-jvuqo").project("football-players-detection-3zvbc")
version = project.version(12)
dataset = version.download("yolov9")

# Fix data.yaml paths in dataset
YAML_PATH = os.path.join(dataset.location, 'data.yaml')
with open(YAML_PATH, 'r') as file:
    yaml_data = file.read()

yaml_data = yaml_data.replace('test: ../test/images', 'test: test/images')
yaml_data = yaml_data.replace('train: football-players-detection-12/train/images', 'train: train/images')
yaml_data = yaml_data.replace('val: football-players-detection-12/valid/images', 'val: valid/images')

with open(YAML_PATH, 'w') as file:
    file.write(yaml_data)

# Initialize YOLO model
model = YOLO("yolov9m.pt")
model.info()

# Set device based on GPU availability
devices = None
try:
    if not torch.cuda.is_available():
        devices = "cpu"
        print("Using CPU")
    else:
        num_gpus = torch.cuda.device_count()
        if num_gpus == 1:
            devices = 0
            print(f"Using single GPU: {torch.cuda.get_device_name(0)}")
        else:
            devices = list(range(num_gpus))
            print(f"Using {num_gpus} GPUs: {', '.join([torch.cuda.get_device_name(i) for i in range(num_gpus)])}")
finally:
    print("\n++++++++++++++++++++++++")
    print(f"Devices: {devices}")
    print("++++++++++++++++++++++++\n")

# Add custom WandB callback
add_wandb_callback(model, enable_model_checkpointing=True)

# Train the model
results = model.train(
    data=os.path.join(dataset.location, 'data.yaml'),
    epochs=10,
    batch=-1,
    imgsz=640,
    verbose=True,
    device=devices,
    project='trained_models',
    save_period=3,
    fraction=0.01,
)

wandb.finish()

After running this code, the ./trained_models/train/weights directory has model weights for each epoch.
When wandb is dissabled, the ./trained_models/train/weights directory has weights saved for every 3rd epoch as expected

Hi @mykola-mmm Good day and thank you for reporting this to us. Let me review this with our team and we'll get back for an update. Thanks again!

Hi @mykola-mmm Good day! I spoke with our Engineering team and they we'd like you to refer to our docs page here for Ultralytics. Let me know if this helps!


Implement CSV ConfigStore in Node.js SDK

Resolves: #151

Hi @Sadaf-A,
Please review the following impl suggestion for CsvFileConfigStore.
Like I said, it shouldn't extend KeyValueConfigStore.
The following is inspired by JsonFileConfigStore (ts/packages/node/src/stores/JsonFile.ts) please use it for insperation as well.

Replace csv-parser package with csv package. the latter is much bigger and stable.
As with JsonFileConfigStore, please rename to CsvFileConfigStore
CsvFileConfigStore.read should read and parse the file content, iterate the first 3 colunms where the first should correspond to set, the second is key and the third is value. These together are Config and this method should return an array of them.
Your impl currently returns only the key and the value without a set. This will only work if we didn't support nested sets. ie. /set1/set2
CsvFileConfigStore.get should read the file and return configs matching with set and key. Your impl currently only looking for the key.
CsvFileConfigStore.set should read and parse the file and its configs. append new configs, override values for existing configs and delete configs with empty-string value and write the file back to the file-system. In this order

Please make sure your branch is up-to-date with main and run tests locally to verify your code runs and behave as expected
Here is an example of what the CSV could look like. This example has headers but they will not exist on this impl:

Let me know if you need anything else. You can also find me on Discord (Markeitect)

Thank you for your contribution, and we appreciate the effort you put into this PR. However, after careful consideration, we've decided to close this PR because it has taken longer than expected to be merged.
Your contributions are valued, and we encourage you to submit new PRs in the future. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you again for your understanding.


Hotspot keeps disconnecting

Hi,
When I have the service running, it constantly disconnects my hotspot.
I was hoping I could use it to create an access portal for people connecting to my hotspot.

the DHCP server must not be started on a subnet that already has another DHCP server.. there can be only one :)


Adding header to API request

http://stackoverflow.com/questions/3595518/facebook-graph-api-search-results-depends-on-location
Based on that Q&A, it will be good if we can add header when sending an API request. Like 'Accept-Language: en-us,en;'. It will affect the result since Facebook automatically detect the requester location.
I think that's a great idea!

Absolutely, @vionemc! Please feel free to submit a pull request if you find the time. There's :cake:. And it's not a lie.

Hi @jgorset and @vionemc ,
I'd like your opinions on my approach:

I created a dictionary of all supported locales, Example:{'German' : 'de_DE' .....}
Users can use the keys to insert their values.

2.The value of the key from the selected language is inserted as header
3.I would change the _query method in graph_api.py to accept headers
Would that suffice?

Any update on this?

Sorry for going silent on you guys! I just explored the Graph API and it seems that this is no longer needed; search now accepts a query parameter center to set the location, and as far as I can tell no other endpoints need custom headers (but please just reopen if I'm wrong about that!)


Feat/add termination

This PR adds the termination feature to the El Collectooorr.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feat/2-agent-service@68256ff). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             feat/2-agent-service     #155   +/-   ##
=======================================================
  Coverage                        ?   89.45%
=======================================================
  Files                           ?       67
  Lines                           ?     5453
  Branches                        ?        0
=======================================================
  Hits                            ?     4878
  Misses                          ?      575
  Partials                        ?        0

Flag
Coverage Δ

unittests
89.45% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Improvement in the way the package is presented

I have the feeling this package would get more users if the way it is presented was improved.
First, I think the name of the package and the name of the github repo should match. EDIT: and the name of the API entry point (currently ReactiveForms).
Second, I think the package should be renamed from 'templates:forms' to something more unique, like 'jonjamz:forms' or 'circus:forms' (use case: "I use the form package from aldeed, what form package do you use? I use xxxx").
Third, I think the documentation should emphasize more why people should use this package and how easy it is. I will post a draft here.

I think the best way to emphasize why people should use this package is to create a much better set of examples and, as you say, improve the docs.
For example, check out this screenshot from Virgin America's flight ordering process:

While I haven't built a replica of this using templates:forms, I'd imagine that building this element would be almost impossible with AutoForm, where it would be much easier with this package.
Why? Because templates:forms lets you do pretty much anything you want using the normal Blaze syntax and doesn't break. It also gives you flexibility with how you handle/transform events before data gets validated and saved in the form's data context.
And, you can add your own set of helpers onto any element or form block template and they'll stack with the ones this package provides--just like any Blaze template can have more than one call to Template.helpers.
A note on the real-time pricing in that screenshot:
I think I'd have to make the form data context reactive and easily accessible through a helper, but it's possible that providing real-time pricing information based on a user's selections is easily achievable, even now.

Thanks for thinking about this, and I look forward to seeing your ideas!

Here is the draft:
https://github.com/steph643/meteor-issue-3194/blob/master/old/README2.md
Please let me know your thoughts.

I think this is a great starting point for new docs. Very clear. I really like your examples. :+1:

Thanks.
Please post here as soon as you make changes to the doc and I will be glad to proofread.

An additional note about examples and package marketing:
I am quite sure you alienate half of potential users if you have sample code in CoffeeScript.
See this typical discussion.
I think package authors who want to promote CoffeeScript without alienating anyone should go double-language.

Sure--but my examples are all JavaScript.
Unless you're talking about the live example, which indeed is CoffeeScript. I should fix that...
I have no problem going double-language, it just takes up a lot of space. Perhaps the new docs could also exist on a separate website where I could use the templates:tabs package for this.

Well, it was just long-term consideration and a precaution for new coming examples. I don't think it is urgent to fix the live example, and maybe it could stay as it is if more examples are provided.
Regarding double-language, it is a lot of effort that might be best invested in revamped doc, new features and maybe changing the schema layer.

If I could add my two cents here, as a compete novice...the new draft of the readme would help a lot. I'm learning how to write code as I build an app and have been relying heavily on SimpleSchema and Autoform to do so. Everything I have read elsewhere sounds like template:form is the easier way to go, but the current docs are pretty daunting (especially for my relatively simple use case). This new doc would make it much easier for me to get on board. Is the draft accurate for me to rely on?

Somewhat accurate, although some of the naming is off (for example, the package name is still templates:forms and basicFormModel is actually basicFormBlock.
I'm working on a pretty big update to the package this weekend so I'll adjust the docs too.

Late to this discussion, but I here are my two cents:

the live example that you link to should be an easily found-and-cloned repo, so new users can really kick the tires locally
all example code (including the above) really should be javascript, as noted above

Thanks!

Now that this latest update is out, I'll spend some more time fixing up the docs and working on examples.

Check out the in-progress docs for v2.0.0 including many examples and guides:

Wow, that looks great!

I find the new documentation excellent. Did not yet have time to look into all details, but it appears now really well structured and straight forward. Very good job!

Hey @jonjamz any update on when documentation will be officially ready? I think the Meteor community would greatly benefit from it! I find this package to be a breath of fresh air compared to the overly verbose Autoforms package.
Let us know if you need any help :)

Basically all that's left before I put up the new docs is to make sure the API methods have the right names. I also need to test out the examples, particularly some of the more complex ones.

Brilliant news! :) I just tested AdjustableNumberOfInputs. When changing a field value it seems to output this error:
Uncaught RangeError: Maximum call stack size exceeded - module.js:705
I think the error is coming from validationValue but I'm not sure.
The field that it was using had a schema like this:
foo:{
   type:[Object],
}

@7immy thank you for helping with this! Let's continue this discussion in issue #92.

:+1:


Added logging to fail handlers

I was having troubles getting my contracts published on CI, after much hair being pulled out I resorted to adding logs to publisher.js. Turned out it was failing because I made a typo in the provider name and the broker was returning the provider has not been created error.
To prevent other people from struggling with this I've added logs to the fail branches of the promises.

Thanks for that, definitely a welcomed contribution.  My only request would be that if this is an error, could you please call logger.error instead of logger.warn.  After that, I'll merge it and release a new version.
Cheers.

Hm, after some thought, I've started modifying how we're logging things.  In essence, I want to use the logger less and use promise resolutions instead to bubble up all errors.  I'm currently changing this right now, making your PR redundant.  I'll close it, but the fix should be coming up soon.
Cheers.

@mboudreau Sounds great, as long as it stops failing silently I'm happy 👍

@marcodejongh agreed.    Please try it to make sure it solves your issue.  Cheers.


initial simple rate limiting

Description
this is a very simple implementation of rate limiting for the imageproxy service.
Motivation
addresses #200

@googlebot I signed it!

Hey @BrianGreenhill, I'm finally catching up on outstanding PRs 😕
I'm curious what you think of the alternate approach in #235.  Rather than wrapping the handler and limiting all requests like tollbooth does, I'd kind of like to be more surgical and limit just the requests that are likely to consume resources... namely, those that require transformations.  If a response is already cached, there's probably not a need to limit it.  (Though I guess the counter argument there is that if it's cached, then it's probably going to return very quickly, and won't block other requests for very long.  hmm....)

Hey @BrianGreenhill, I'm finally catching up on outstanding PRs confused
I'm curious what you think of the alternate approach in #235. Rather than wrapping the handler and limiting all requests like tollbooth does, I'd kind of like to be more surgical and limit just the requests that are likely to consume resources... namely, those that require transformations. If a response is already cached, there's probably not a need to limit it. (Though I guess the counter argument there is that if it's cached, then it's probably going to return very quickly, and won't block other requests for very long. hmm....)

@willnorris  if we can be more specific and limit requests that we know will consume more resources then I think that's the better solution. I wonder if a global rate limiting flag as an upper bound for limiting rps may also be desirable for some users? However, this concern can also be handled in other ways and doesn't necessarily have to be the responsibility of the application.
Thanks for responding and please go ahead with the alternative approach here :+1:


Do not run Azure Host Servicing test in non-development environments

Which issue this PR addresses:
Fixes ongoing rollout
What this PR does / why we need it:
Skips the Azure Host Servicing E2E test when not in development environments. This is required as this test performs direct actions on the cluster VMs, which are protected by ARO's deny assignment in production regions. This causes this E2E test to fail when used e.g. to validate a production region during our deployment process.
Note that this is intended to be a temporary fix - we should evaluate a more permanent solution that allows us to validate this behavior in all regions during our rollout.
Test plan for issue:

E2E tests continue to work (I don't know if this test will now get skipped in CI here or not?)

Is there any documentation that needs to be updated for this PR?
No.

/azp run e2e


V2/tatu/grpc getallrows querybuilder oss

What this PR does:
Which issue(s) this PR fixes:
No issue filed (stargate v2 prototyping)
Checklist

[x] Changes manually tested -- no functional change, existing "getAllRows()" tests exercise
[ ] Automated Tests added/updated
[ ] Documentation added/updated

Wrong branch, close.


Update Yarn version to x4

Description
Yarn has released v4. This resolves the problems with the audit command which up until now was broken and returned a 400 bad request.
Using yarn v4 requires node 18+
Make sure to reinstall lcp globally to be able to use the proxy again if you're not yet using node 18 locally.

Processing this pull request

Pull request rejected by merge tool. No change entry file found

Processing this pull request

Merged into branches master, iso7 in 29ff336d120b0b826b4f0948854e43ca4e21b6e5


Force $newPosition to be an integer

I got some problems with sorting when $movePosition is a string. Forcing to be an integer solves this problem. Apparently Gedmo/Sortable does car about the type of sort (integer vs string).

@nicolasricci Could you please take a look at this?

@ceesvanegmond is this still required or is it fixed by #71?

@nicolasricci Still needs to be required 👍 . Could you tag new release after this merge?

@nicolasricci 👍


polymer 1.0 TypeError on initialization

Error on element initialization.
 I'll investigate.

I just did a quick check to make sure that basic-aspect on the master branch can be instantiated, and it can. I'm not seeing this exception.
There are two classes implicated in this issue: Basic.Aspect and Basic.Collective. The first depends on the second, but it sounds like second (Basic.Collective) isn't defined by the time Basic.Aspect needs it.
Since it looks like you're using vulcanize, and vulcanize can potentially have unintended effects on the order in which scripts, etc., are evaluated, can you check the following?

Look in your vulcanized file (vulcanized.html) for the line mentioned in the bug:

    new Basic.Collective(this);

Now look in the same vulcanized file for the line that defined Basic.Collective:

function Collective() {

Please let me know if the line for #1 comes after the line for #2.

My mistake. Should have included the
inlineScripts: true,
inlineCss: true
as my polymerVulcanize props.
 Both basic-carousel and basic-carousel-fit are styling my images incorrectly while displaying both images at the same time :(

Can you provide more detail so I can investigate further?

Is the selected CSS class applied to only one image at a time?
basic-carousel and basic-carousel-fit don't hide the other images -- they just try to ensure that they're outside the visible bounds of the component. basic-carousel should set the width of the images such that they completely fill the component area. E.g., in the basic-carousel demo, there are 5 images, so they're each made to be 20% as wide as the horizontally scrolling surface, which is 500% the width of the component. Hence, each image should be 100% the width of the component. basic-carousel-fit does something similar, but calculates a different value for the left attribute of each image. Can you verify that the image width/left is being set as in the demos?
If you're using basic-carousel, can you verify that the component has been styled to the height and width you want?
If it's possible to run directly the original unvulcanized source, does the carousel work then? I normally develop without vulcanize (as above, vulcanize can introduce issues of its own), and then only add vulcanized when I've got things working as expected.
Can you share any other details, or share code if that's possible?

Also: which browser are you using?

@canufeel Just wondering if you were still interested in this issue.

I got this exact issue when I imported the HTMLs from raw.githubusercontent.com instead of rawgit.com and therefore with a "text/plain" MIME type.

@Jamtis That particular case sounds like an issue using HTML Imports against a server that's not really set up for that. If so, this issue would lie far below the level at this code works. We're working on a solution for serving up these source files so that they can be properly imported from a server with, among other things, the correct MIME type. That's not ready for use yet, however.
Given the age of the original issue, and that we don't have more details to go on right now, I'm going to close this. If anyone hits this again and can provide a repro case, please reopen! Thanks.


feat(minifier): add MinimizeConditions pass

#5747  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Unbalanced parens make SidewaysArgumentTextobjI/A jump to unrelated line

Several times I've had sideways select text that doesn't include my cursor position. I think it would make more sense to do nothing than jump to another part of the buffer. I've found a reliable and small repro case:
EditorGUI.BeginProperty(position, label, property);
{
    SerializedProperty joint = property.serializedObject.FindProperty("Bone"); // will jump to here

    Debug.Log(string.Format("1) Found a good one: {0}"), joint); // selecting from here
}
EditorGUI.EndProperty();

Do:
/joint)
vi,

(i, is SidewaysArgumentTextobjI)
Result:
The SerializedProperty line is selected.
va, selects the S in SerializedProperty and the space before it.
The only case I can think of where sideways selects something that doesn't include my cursor position is on a comma and the next argument is on the following line (but I'd argue it should select the preceeding argument). Would it make sense to limit the textobjs to require inclusion of the cursor position?
Using 2d5cd2b3cb853067f192cd0e445c35e6007d6fe3 on Gvim 8.0.596 Win64

There's some interesting layers to the problem here.
In general, the plugin couldn't handle unbalanced brackets. It expects that an expression is valid, because I honestly don't know how I'd handle the logic for it otherwise :). That said, the problem here is that the bracket is in a string, and that should be ignored by default.
The thing is, I ignore particular syntax groups for ruby (https://github.com/AndrewRadev/sideways.vim/blob/01a96f716bad0f7b03043a779e49550139fa2069/plugin/sideways.vim#L39), but this is a Java example (I think), which uses a global definition.
So, first off, I fixed a few places that weren't correctly skipping syntax patterns. I also added some default behaviour to try to ignore all "Comment" and "String" patterns, with a setting to escape it if it's necessary. The relevant docs are here:

https://github.com/AndrewRadev/sideways.vim/blob/01a96f716bad0f7b03043a779e49550139fa2069/doc/sideways.txt#L76-L84
https://github.com/AndrewRadev/sideways.vim/blob/01a96f716bad0f7b03043a779e49550139fa2069/doc/sideways.txt#L166-L180

Long story short, the example you showed should work as expected now, but you should consider the relevant documentation in case you run into similar issues that I haven't thought of.
Does this seem to solve the problem?

I can confirm that updating to 6703dae2c6b1ea0cc44dbbfd6beafda5b664e071 fixes my C# example above. Thanks so much!
However, I experience some similar jumping to far away text (also C#):
if (true)
{
    Debug.LogError(
            "",
            sdfsf,
            children.Length, // selected without deleteme
            joint);
    return null;
}
else
{
    GUI.Label(position,
            "deleteme",
            jumps_to_here);
}

And
/joint)
vi,

The jumps_to_here text is selected instead of joint.
Alternatively, minor modifications cause the comment to be selected instead of joint:

Removing the first string or making it nonempty
Removing the deleteme line
Removing the whole else block

Removing the first string and the comment makes it behave as expected.
Possibly this is related to your changes. On 2d5cd2b3cb853067f192cd0e445c35e6007d6fe3, the comment is selected instead of jumps_to_here.

The jumps_to_here text is selected instead of joint.

Hm, something to do with the string matching, I think. I've adjusted one of the search patterns, and it seems to work now, for this example.

Alternatively, minor modifications cause the comment to be selected instead of joint:

This one is going to be trickier. I'll need some time to think it over. Comments are ignored mostly to avoid code that's competely commented out. A line-based comment in an argument list is something I hadn't considered.

On 01bcf0f, sideways is better behaved but not correct on my example (copypasted to new cs file). It selects the comment instead of jumps_to_here.
If sideways uses syntax then you should know I'm using omnisharp vim to improve vim's C# syntax.


Script Running after waking from Windows Sleep Freezes Window

Windows Terminal version
Version: 1.19.11213.0
Windows build number
10.0.22631.0
Other Software
Batch file running a Python script.
Steps to reproduce

Use task manager and schedule a task that can running during Windows sleep wake up (delayed).
Sleep Windows
Wake Windows later

Expected Behavior
No response
Actual Behavior
The window appears but is unresponsive and does not render frame (script does not run) and the process has to be manually ended.
e.g.

Thanks for filing! We're going to mark this as a /dup of #15936


Updates to IBM Cloud IAM Operator v0.1.0 - Community

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x ] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Submit operators to both upstream-community-operators and community-operators at once
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@J0zi Is there anything that I need to do to rebase this file and resolve the merge conflict?

the same https://github.com/operator-framework/community-operators/pull/2186#issuecomment-673501623

@J0zi rebase and merge completed. Please let me know if this looks good

/test CVP

/test CVP

/ok-to-test

asked CVP team

/test CVP

CVP is down, we cannot test. Once they fix it, we can continue. Thanks for understanding.

Sounds good. Thanks for the update.


Consider adding closeDrawer and closeEndDrawer in ScaffoldState

The scaffold state provides way to open drawer and endDrawer. However, it doesn't provide an API to close them. The API doc of openDrawer suggests:
https://api.flutter.dev/flutter/material/ScaffoldState/openDrawer.html
To close the drawer once it is open, use Navigator.pop.

This is reasonable if there is only one navigator. For nested navigator, it is non-trivial to figure out which navigator it should pop.
e.g. https://github.com/flutter/flutter/issues/51638
We should add the closeDrawer API to ScaffoldState instead

cc @HansMuller @goderbauer


Modify str and repr functions

Modify str and repr functions of octree, octnode, tri etc classes to give the user more useful information

Done in master


Overhaul 2 - New features and complete functionality

This PR includes support for

Better multifunction encoding
Option to choose from different encoding techniques
Evolution enhanced mapping
Parameterisation of cost function and optimized boundary handling
Regularization and boundary loss for the above

Other than that, better tests which aim to catch a wrong function call, incorrect function definition and other such problems through  all the features.

Pasting a png file here

Looks great!
Make an issue about improving that derivative handling, but it's more than fine enough for now.


Device S10 Status is not send via MQTT when received via webhook

Hello, when status data like workingStatus, taskType, battery, etc is received via webhook it is not send to MQTT.
See example: Data received 09:24 am via webhook like "taskType":"cleanAll" or "workingStatus":"Clearing" is missing in the MQTT-Payload.
MQTT Messages:
`Received 08:31:29  => POLLING
QoS: 0
Payload:

deviceId: XXXXXXX
deviceType: WoSweeperOrigin
workingStatus: ChargeDone
onlineStatus: online
battery: 100
waterBaseBattery: 100
taskType: standBy

Received 09:24:25 => WEBHOOK
QoS: 0
Payload:

deviceType: Robot Vacuum Cleaner S10
deviceId: XXXXXXX

Received 09:24:33 => WEBHOOK
QoS: 0
Payload:

deviceType: Robot Vacuum Cleaner S10
deviceId: XXXXXXX

Received 09:24:35 => WEBHOOK
QoS: 0
Payload:

deviceType: Robot Vacuum Cleaner S10
deviceId: XXXXXXX

Received 09:24:45 => WEBHOOK
QoS: 0
Payload:

deviceType: Robot Vacuum Cleaner S10
deviceId: XXXXXXX

Received 09:25:35 => WEBHOOK
QoS: 0
Payload:

deviceType: Robot Vacuum Cleaner S10
deviceId: XXXXXXX

Received 09:26:13 => POLLING
QoS: 0
Payload:

deviceId: XXXXXXX
deviceType: WoSweeperOrigin
workingStatus: Clearing
onlineStatus: online
battery: 99
waterBaseBattery: 100
taskType: cleanAll

`
Corresponding Logs:
08:31:27 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Send GET,devices/XXXXXXX/status,(null)
08:31:29 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Response GET,https://api.switch-bot.com/v1.1/devices/XXXXXXX/status,{"statusCode":100,"body":{"deviceId":"XXXXXXX","deviceType":"WoSweeperOrigin","workingStatus":"ChargeDone","onlineStatus":"online","battery":100,"waterBaseBattery":100,"taskType":"standBy"},"message":"success"}
09:24:07 trce: SwitchBotMqttApp.Services.MqttCoreService[0] receive command XXXXXXX,{   "CommandType": "command",   "Command": "startClean",   "ParamName": "times",   "ParamValue": "2" }
09:24:10 trce: SwitchBotMqttApp.Services.MqttCoreService[0] receive command XXXXXXX,{   "CommandType": "command",   "Command": "startClean",   "ParamName": "action",   "ParamValue": "sweep_mop" }
09:24:12 trce: SwitchBotMqttApp.Services.MqttCoreService[0] receive command XXXXXXX,{   "CommandType": "command",   "Command": "startClean",   "ParamName": "fanLevel",   "ParamValue": "3" }
09:24:18 trce: SwitchBotMqttApp.Services.MqttCoreService[0] receive command XXXXXXX,{   "CommandType": "command",   "Command": "startClean",   "ParamName": "btn",   "ParamValue": "action" }
09:24:18 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Send POST,devices/XXXXXXX/commands,{"commandType":"command","command":"startClean","parameter":{"action":"sweep_mop","param":{"fanLevel":3,"waterLevel":2,"times":2}}}
09:24:20 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Response POST,https://api.switch-bot.com/v1.1/devices/XXXXXXX/commands,{"statusCode":100,"body":{},"message":"success"}
09:24:25 info: SwitchBotMqttApp.Controllers.WebhookController[0] {"eventType":"changeReport","eventVersion":"1","context":{"deviceType":"Robot Vacuum Cleaner S10","deviceMac":"XXXXXXX","timeOfSample":1725002665366},"onlineStatus":"online","taskType":"cleanAll"}
09:24:33 info: SwitchBotMqttApp.Controllers.WebhookController[0] {"eventType":"changeReport","eventVersion":"1","context":{"deviceType":"Robot Vacuum Cleaner S10","deviceMac":"XXXXXXX","timeOfSample":1725002673422},"onlineStatus":"online","workingStatus":"Clearing"}
09:24:35 info: SwitchBotMqttApp.Controllers.WebhookController[0] {"eventType":"changeReport","eventVersion":"1","context":{"deviceType":"Robot Vacuum Cleaner S10","deviceMac":"XXXXXXX","timeOfSample":1725002675762},"onlineStatus":"online","workingStatus":"Clearing"}
09:24:45 info: SwitchBotMqttApp.Controllers.WebhookController[0] {"eventType":"changeReport","eventVersion":"1","context":{"deviceType":"Robot Vacuum Cleaner S10","deviceMac":"XXXXXXX","timeOfSample":1725002685412},"onlineStatus":"online","workingStatus":"Clearing"}
09:25:35 info: SwitchBotMqttApp.Controllers.WebhookController[0] {"eventType":"changeReport","eventVersion":"1","context":{"deviceType":"Robot Vacuum Cleaner S10","deviceMac":"XXXXXXX","timeOfSample":1725002735455},"onlineStatus":"online","battery":99}
09:26:11 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Send GET,devices/XXXXXXX/status,(null)
09:26:13 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Response GET,https://api.switch-bot.com/v1.1/devices/XXXXXXX/status,{"statusCode":100,"body":{"deviceId":"XXXXXXX","deviceType":"WoSweeperOrigin","workingStatus":"Clearing","onlineStatus":"online","battery":99,"waterBaseBattery":100,"taskType":"cleanAll"},"message":"success"}

Thank you for the feedback.
In #27, the webhook wasn't being sent, but it seems that it is now being delivered.
However, the webhook being sent appears to have a structure different from what is described in the OpenAPI specification... According to the specification: inside context, but in reality: outside context.
expect:
{
    "eventType": "changeReport",
    "eventVersion": "1",
    "context": {
        "deviceType": "Robot Vacuum Cleaner S10",
        "deviceMac": DEVICE_MAC_ADDR,
        "workingStatus"："StandBy",
        "onlineStatus": "online",
        "battery": 100,// 0-100
        "waterBaseBattery": 100,
        "taskType": "explore",
        "timeOfSample": 123456789
    }
}

actual:
{
  "eventType": "changeReport",
  "eventVersion": "1",
  "context": {
    "deviceType": "Robot Vacuum Cleaner S10",
    "deviceMac": "XXXXXXX",
    "timeOfSample":<PHONE_NUMBER>366
  },
  "onlineStatus": "online",
  "taskType": "cleanAll"
}

If it’s just a matter of changing the reading position, it would be simple, but there are other issues. It seems that only a portion of the state is received with a single webhook.
In the current add-on, state topics are divided into three categories: those that can be obtained only through the API, those that can be obtained only through the webhook, and those that can be obtained through both. Therefore, if we accept a webhook with missing parts, the values of other sensors will become unknown.

I need to either modify the status topics to be divided by sensor or wait until the webhook is sent according to the specification, but I would like to take a little more time to assess this.
First, I will proceed with the following tasks. Please wait for a while.

Provide feedback on https://github.com/OpenWonderLabs/SwitchBotAPI/issues/321 that the webhook is now being sent, but the payload differs from the specification.
Re-verify whether, when the missing payload is sent to the status topic, the previous state of the missing sensor is overwritten. (It should have been the case when I tested it before, but I will double-check.)

After rechecking, even when the payload in the status topic was missing, the values did not become unknown. (It seems I was mistaken.)
I'm not sure which version of the OpenAPI specification is correct, but since I don't expect much of a response from the issue on the SwitchBot, I plan to modify the implementation to "retrieve the value from inside context if it's there, and from the outside if it's not."
With the API specifications for K10 and K10Pro now available, I intend to release the update, likely by the end of today(in JST few hours). Once it's released, I will add a comment here.

I have just fixed it and released version v1.0.24.
I would appreciate your feedback after trying it out.

I have one question I'd like to ask.
I want to know what possible values deviceType can take.
Specifically, I want to know the value of the S10 in the DeviceList API (when you press the [Fetch Devices By SwitchBotApi] button on the Ingress page).
The webhook shows Robot Vacuum Cleaner S10, while the Status API shows WoSweeperOrigin, which is quite different from the specification. So, I'd like to understand the value in the DeviceList as well.

I will do some further testing later. But i can say taskType and workingStatus are set now. But sometimes one of the both values is empty.
Here is the result of the DeviceList API:

14:43:44 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Send GET,devices,(null)
14:43:45 trce: SwitchBotMqttApp.Logics.SwitchBotApiClient[0] Response GET,https://api.switch-bot.com/v1.1/devices,
{
    "body": {
        "deviceList": [
            {
                "deviceId": "B0E9FE00391E",
                "deviceName": "Floor Cleaning Robot S10 1E",
                "deviceType": "Robot Vacuum Cleaner S10",
                "enableCloudService": true,
                "hubDeviceId": ""
            }
        ],
        "infraredRemoteList": [
        ]
    },
    "message": "success",
    "statusCode": 100
}

Thank you for the device list values.
Additionally, I checked the behavior of the MQTT integration.
For numeric fields (sensors) like battery or temperature, if they are not present in the payload, their values remain unchanged.
However, for string-based fields (sensors), they seem to be converted to empty strings.
The previous check was conducted only on numeric fields.
Please give me a more time.
I will investigate whether the issue can be avoided with the MQTT Discovery sensor configuration.
If that doesn't work, we can either break down the topics into more detailed fields or wait for the webhook specification to be corrected.

I have just fixed it and released version v1.0.25.
As a specific change, I have modified the value_template of the MQTT sensor.
he new template now checks for a value, and if it exists, it uses that value; otherwise, it falls back to the current value.
This change prevents the value from becoming "unknown" even if part of the Webhook data is missing.
"value_template": "{{ value_json['battery'] if (value_json['battery'] is defined and value_json['battery'] is not none) else states('sensor.both_battery_FFF921xxxxxx') }}"

I would appreciate your feedback after trying it out.

This works fine. Nice work👍
I just have one little inconsistency:
On polling also the webhook_timestamp is updated.

Thank you for confirming !
Regarding the timestamp issue, it was an oversight during the fix. The state topic payload was referencing the same value.
I feel like the add-on is being updated too frequently, so I'll address this in the next update when I make other changes.


MissingPluginException(No implementation found for method showToast on channel PonnamKarthik/fluttertoast)

After adding flutter screen in my existing ios app, I am getting this following runtime error:
'[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: MissingPluginException(No implementation found for method
showToast on channel PonnamKarthik/fluttertoast)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:154:7)
<asynchronous suspension>'

Any solution for this?

@Alok81234881 Try restarting the application (full restart)
or
try flutter clean then install
If error still persists please provide sample code
Thanks

Still getting the same error. Here is the sample code:
'AppDelegate.swift
      import UIKit
      import Flutter
      import FlutterPluginRegistrant

    @UIApplicationMain
    class AppDelegate: FlutterAppDelegate  {

          lazy var flutterEngine = FlutterEngine(name: "my flutter engine")
         override func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions:
          [UIApplication.LaunchOptionsKey: Any]?) -> Bool {

                 flutterEngine.run();

                 GeneratedPluginRegistrant.register(with: self.flutterEngine);
               return super.application(application, didFinishLaunchingWithOptions: launchOptions);
     }
}

ViewController.swift
   import UIKit
   import Flutter
   import FlutterPluginRegistrant

  class ViewController: UIViewController {

        override func viewDidLoad() {
          super.viewDidLoad()

        let flutterEngine = (UIApplication.shared.delegate as! AppDelegate).flutterEngine
        let flutterViewController = FlutterViewController(engine: flutterEngine, nibName: nil, bundle: nil)
       present(flutterViewController, animated: true, completion: nil)
   }

Main.dart
  import 'package:flutter/material.dart';
  import 'package:flutter/services.dart';
  import 'package:fluttertoast/fluttertoast.dart';

 void main() => runApp(MyApp());

 class MyApp extends StatefulWidget {
      @override
      _MyAppState createState() => _MyAppState();
  }

  class _MyAppState extends State<MyApp> {

        @override
        Widget build(BuildContext context) {
          return MaterialApp(
             home: Scaffold(
              appBar: AppBar(
                  title: const Text('Razorpay Sample App'),
               ),
            body: Center(
                   child: Row(
                         mainAxisAlignment: MainAxisAlignment.center,
                        children: <Widget>[
                         RaisedButton(onPressed: buttonClicked, child: Text('Show Toast'))
                         ])),
                     ),
             );
       }
      void buttonClicked() async {
               try {
                     Fluttertoast.showToast(msg: "Alok Singh: ", timeInSecForIos: 4);
               } catch (e) {
                   debugPrint(e);
                  }
          }
    }

Flutter Doctor
 [✓] Flutter (Channel stable, v1.17.3, on Mac OS X 10.15.5 19F101, locale en-IN)
• Flutter version 1.17.3 at /Users/aloksingh/Developer/flutter
• Framework revision b041144f83 (7 weeks ago), 2020-06-04 09:26:11 -0700
• Engine revision ee76268252
• Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
• Android SDK at /Users/aloksingh/Library/Android/sdk
• Platform android-30, build-tools 30.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode 2.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.8.4

[✓] Android Studio (version 4.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
• iPhone SE (2nd generation) • 3D27866E-392A-454E-9406-214C0538A0EE • ios •
   com.apple.CoreSimulator.SimRuntime.iOS-13-5
  (simulator)

 • No issues found!

[ERROR:flutter/lib/ui/ui_dart_state.cc(166)] Unhandled Exception: MissingPluginException(No implementation found for method showToast on channel PonnamKarthik/fluttertoast)
Bro, I am getting the error?

https://github.com/flutter/flutter/issues/23832

Facing this issue.
Please the example code snippet
//Please note it is an async method
void updateUserProfile(
      String firstName, String lastName, String userName, String email) async {
    SharedPreferences prefs = await SharedPreferences.getInstance();
    if (prefs.get(Constants.API_Token) == null ||
        prefs.get(Constants.API_Token) == '') {
      loginToast('Please Login to update profile!!!');
    } else {
      CommonHelper.showProgressBar(context, "Requesting ..........");
      updateProfile(firstName, lastName, userName, email).then((response) {
        if (response['status'] == true) {
          loginToast('Profile Updated');
          User user = response['data'];
          Prefs.setDisplayName(user.displayName);
          Prefs.setEmail(user.email);
          Prefs.setUserName(user.username);
          Prefs.setMobile(user.mobile);

          Navigator.of(context).pop();
        } else {
          loginToast(
              'Sorry could not Update Profile. Please try again later!!!');
        }
        FocusScope.of(context).unfocus();
        Navigator.of(context, rootNavigator: true).pop('dialog');
      });
    }
  }

The code I am using to show toast. This code is inside util class
//code snippet fomr util class
void loginToast(String message) {
   Fluttertoast.showToast(
       msg: message,
       toastLength: Toast.LENGTH_LONG,
       gravity: ToastGravity.CENTER,
       backgroundColor: Colors.white,
       textColor: Colors.green,
       fontSize: 16.0);
 }
}

facing the same issue. can it be because i am using null safe version with the flutter sdk version that is not null safe ?

1- flutter clean
2- run
works for me!!


Add missing methods to Series

Pandas methods like to_timestamp are trivial to add to dask.dataframe.  We should go through the API and verify that we've implemented everything like this that is more-or-less trivial to do.

This is the list I came up of missing methods that should be relatively simple to add.
-[ ]T
-[ ]align
-[ ]all
-[ ]any
-[ ]applymap
-[ ]axes
-[ ]combine
-[ ]combineAdd
-[ ]combineMult
-[ ]combine_first
-[ ]compound
-[ ]corrwith
-[ ]diff
-[ ]divide
-[ ]dot
-[ ]duplicated
-[ ]eq
-[ ]ewm
-[ ]expanding
-[ ]first_valid_index
-[ ]ge
-[ ]get_value
-[ ]gt
-[ ]iget_value
-[ ]irow
-[ ]isin
-[ ]items
-[ ]iteritems
-[ ]kurt -> manually calculate 4th moment?
-[ ]kurtosis ^^^
-[ ]last_valid_index
-[ ]le
-[ ]lt
-[ ]mad -> manually calculate?
-[ ]ne
-[ ]nsmallest
-[ ]prod
-[ ]product
-[ ]reindex
-[ ]reindex_axis
-[ ]round
-[ ]select_dtypes
-[ ]stack
-[ ]std -> manually calculate?
-[ ]to_string
-[ ]to_timestamp
-[ ]transpose
-[ ]unstack
-[ ]var -> manually calculate?

Nice list.  It might be interesting to organize these methods by communication patterns that are already well supported with generic functions like elemwise (round, to_timestamp, to_string, ge, le, ...) and reduction (nsmallest, any, all, ...).  There will also be others, like kurt, that will require more thought, and transpose, which we probably can't easily support.

i really hope complete unstack() method

Howdy, came across this trying to use isin(). Looks like this has been open for some time. Is the idea that contributors will add functionality as needed?

I can see if I can contribute anything worthwhile.
I think this issue is still valid, because at least for me, the ability to interact with dataframse using many of the above methods is pretty useful, if not a requirement. If there are other methods to do so, it might be good to note how those could be done. That would help one in the transition from pandas to dask, which I have struggled with somewhat. My use for dask isn't so much for memory size, but for compute. Yes, I could use other methods, but I'm lazy.

Looks like this has been open for some time. Is the idea that contributors will add functionality as needed?

I suppose so, yes. If you have an interest in contributing improvements to isin that would be welcome.
We might also consider closing this. I suspect that it is out of date.

Im afraid it is not yet out of date. I ran into .dt.to_timestamp raising an AttributeError  issue today and after some searching into the core I think I know what to change but am unsure yet on if it's optimal, or even possible. Perhaps you could shed some of your expertise on the proposition?
The current implementation
https://github.com/dask/dask/blob/master/dask/dataframe/accessor.py#L88 Here in the class underneath the accessor is set once, and never again. This is fine for every Attribute that is found in the Series.dt accessor.
class DatetimeAccessor(Accessor):
    _accessor = pd.Series.dt
    _accessor_name = 'dt'

The pandas implementation
However, the pandas Series DatetimeAccessor is set at runtime. Meaning that whenever you call .dt on a Series object. It fires off the evaluation as found in https://github.com/pandas-dev/pandas/blob/master/pandas/core/indexes/accessors.py#L294
which actually calls the is_period_arraylike and/or is_datetime_arraylike functions on the data to evaluate the type (Period or Datetime) and thus return the corresponding properties.
A possible solution?
I think this problem can be solved within Dask by allowing the DatetimeAccessor object to:

Call a sample of the underlying Series
Apply the resolution order of Pandas with the  is_period_arraylike  and is_datetime_arraylilke functions. (I believe this can be done as simple as pushing the entire sample through the CombinedDatetimelikeProperties class within Pandas.)
Set the correct _accessor based on the result. (Datetime / Timedelta / Period properties)

It doesn't seem to difficult to implement this and I'm willing to do it somewhere during this week. I'm not yet sure though if this is possible. @mrocklin what do you think?

I'd recommend waiting for pandas 0.24 before attempting this. Currently pandas doesn't have a proper period dtype, so the meta for a dask series with period data isn't "correct".
In [2]: ser = dd.from_pandas(pd.Series(pd.period_range('2017', periods=4)), 2)

In [3]: ser._meta_nonempty
Out[3]:
0    foo
1    foo
dtype: object

with pandas 0.24, the dtype will be Period[D] and dask can have some correct metadata.
Then, we can maybe just update with the following
diff --git a/dask/dataframe/accessor.py b/dask/dataframe/accessor.py
index 4b7920b8..11398617 100644
--- a/dask/dataframe/accessor.py
+++ b/dask/dataframe/accessor.py
@@ -93,9 +93,12 @@ class DatetimeAccessor(Accessor):

     >>> s.dt.microsecond  # doctest: +SKIP
     """
-    _accessor = pd.Series.dt
     _accessor_name = 'dt'

+    @property
+    def _accessor(self):
+        return self._series.dt
+

 class StringAccessor(Accessor):
     """ Accessor object for string properties of the Series values.

and things will all just work (maybe).

That'd be the neatest implementation. Sure worth the wait in that case.

I'd like to start contributing to Dask, and this was tagged as a "good first issue".  But it's not clear to me what items to focus upon.  Can I assume (a) to stay away from time-related API methods, and (b) any of the unchecked items in the OP with the checklist are equally helpful / worthwhile?
I'm thinking I'd start with T and reindex.

I don’t think transpose makes sense for dask DataFrame’s design.
Reindex should be doable, but will require some care.
It sounds like an updated list of missing methods with guesses about the implementation difficulty would be useful, but I’m not sure if anyone will have time to put that together near term.

On Apr 20, 2019, at 21:18, Mike Williamson<EMAIL_ADDRESS>wrote:
I'd like to start contributing to Dask, and this was tagged as a "good first issue". But it's not clear to me what items to focus upon. Can I assume (a) to stay away from time-related API methods, and (b) any of the unchecked items in the OP with the checklist are equally helpful / worthwhile?
I'm thinking I'd start with T and reindex.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

OK.  I'll look for another issue with clearer goals where I can help w/out causing more hassle.  ;-p

I believe this ticket was closed by mistake while merging https://github.com/dask/dask/pull/7236. Can this be reopened?

I'd like to take up this issue and help in adding the following method(s) to Dask's Serial:

axes
product
divide (I believe this has been already added)
(feel free to suggest any other method from the complete list which is important or easy to implement)

@TomAugspurger which one of the listed ones or the ones I mentioned would be easier to implement?
This would be my first contribution to Dask :smile:!

I think product or axes. product would be more useful, and would follow the pattern of Series.add.

I think product or axes. product would be more useful, and would follow the pattern of Series.add.

Perfect! I will start working on dd.Serial.product

@TomAugspurger
Turns out, dd.DataFrame.prod already exists.
https://github.com/dask/dask/blob/c5633c21e754df6b2c13195f1e2688e347c48963/dask/dataframe/core.py#L1718-L1740
And, I fond out that it is the same as product and I feel that it would be redundant to implement a new method -> dd.DataFrame.product
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.product.html
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.prod.html

And np.prod and ndarray.prod both end up calling umath.multiply.reduce, so there is really no difference between them, besides the fact that the free functions can accept array-like types (like Python lists) in addition to NumPy arrays.

For an ndarray, prod() and product() are equivalent.
For an ndarray, prod() and product() will both call um.multiply.reduce().
If the object type is not ndarray but it still has a prod method, then prod() will return prod(axis=axis, dtype=dtype, out=out, **kwargs) whereas product will try to use um.multiply.reduce.
If the object is not an ndarray and it does not have a prod method, then it will behave as product().
The ndarray.prod() is equivalent to prod()

Source: https://stackoverflow.com/questions/49863633/numpy-product-vs-numpy-prod-vs-ndarray-prod
According to my understanding, this is also relevant to Dask. So, I propose adding an alias to the dd.DataFrame.prod method call. Would you be fine with that?
This could be as simple as just inserting this simple line below the prod's method definition,
https://github.com/freyam/dask/commit/68941c5d3ccc93da7f3515fc98d7062716ba5b06?branch=68941c5d3ccc93da7f3515fc98d7062716ba5b06&diff=unified
and adding the required test methods similar to the prod tests in dask/dataframe/tests/test_arithmetics_reduction.py and the other test files.
Should I proceed with this? or do you have other plans in your mind?

I have opened up a new Pull Request #7517 regarding the product() method. They passed all the tests and have no conflicts.
Now, I shall start working on adding the axes() and duplicated() methods, while waiting for your review on the PR.

Hey!!
I'd like to work this issue, specifically on the following methods:

to_string
first_valid_index
last_valid_index

These seemed like good methods to pick for my first contribution to Dask. I'd love any input or suggestions on what other methods should take up or any specifics regarding the methods chosen.
For reference I've gone through the Pandas documentation and looked at the descriptions given there.
CC: @mrocklin @TomAugspurger @postelrich

I'd love any input or suggestions on what other methods should take up or any specifics regarding the methods chosen.

I think you're best off implementing what you can, and then coming back for more.

What do you expect as the return value for the axes() when it comes to Dask DataFrames?
Over at Pandas, pandas.DataFrame.axes

Return a list representing the axes of the DataFrame.
It has the row axis labels and column axis labels as the only members. They are returned in that order.

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.axes.html

I would expect axes() to return a list containing:

df.index (which is a  dask.dataframe Index)
df.columns (which is a  pandas Index)

Hello @postelrich is this issue still open ?


(Bug) [RN] support dialog layout broken

the initial call .open sometimes seems to not be working

@mauriguz error isn't reproduced anymore
Checked on  native 1.3.1-1
Desktop: Windows 10 // Google Chrome  86.0.4240.75


Stopping a client nicely: are lifecycle hooks possible?

@kazmijawad, @ewidl is there an approach for stopping a client cleanly? The Redis/Opal-RT client starts a pool of threads for reading data from Redis. How do I hook the closing of the thread pool to the closing of the client?
I think having the possibility to add lifecycle hooks for the clients could prove useful on the long run. What do you think?

Setting up such a hook would be possible and a good feature also. As discussed today, it will be considered with the additional features planned to be rolled out in the coming months.


Throw an exception if there isn't a routematch object

This change ensures that we don't fatal with: Fatal error: Call to a member function getParam() on a non-object in /www/zend-framework/zf2/library/Zend/Mvc/Application.php on line 325

This is fixed in my feature/view-layer branch now, and will merge once that feature is ready.


Port wont open

Describtion: Minecraft server with 150+ mods / Host can join but others can´t / Server properties are correct, already tried to set server ip to his local ip but didnt change anything
I have no clue if this is the right section for this to be posted, however, i got a problem with my port forwarding.
I know how to set up a port forwarding, have done it many times and always worked, but now on a different pc in a different network, it just wont work, i checked if the port was open with https://canyouseeme.org/ and it told me that its not open.
So i opened the same port in the firewall, didnt change anything tho and now i have no clue what to do??
Please correct me if this is in the false category

This is the right place; however debugging port forwarding is tough since every network is a little different.
Double check that you are forwarding that port over UDP and not TCP. Speaking of which, I can’t tell from their docs if https://canyouseeme.org/ checks for UDP. When I get a chance I’ll spin up a container on GCP and see that tool reports.

Oops, that test won't work since https://canyouseeme.org/ can only point to your own IP address and not something arbitrary like a GCP cluster.

I tried switching from UDP AND TCP to only UDP but it didnt change anything :/

I wonder if there's a firewall rule blocking incoming connections to that UDP port on the host running Docker?


Install and demo fail

Windows 10
Cloned latest code from GitHub
Following README.md:
git clone https://github.com/500tech/angular-tree-component

cd angular-tree-component/example/cli
npm install
npm install -g angular-cli
ng serve

Results below:
C:\ae\angular-tree-component>npm install
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
<EMAIL_ADDRESS>C:\ae\angular-tree-component
+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| `--<EMAIL_ADDRESS>+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | `--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| `--<EMAIL_ADDRESS>+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>...

| |     `--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  |   +--<EMAIL_ADDRESS>  |   +--<EMAIL_ADDRESS>  |   `--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\angular-cli\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

C:\ae\angular-tree-component>

Your environment has been set up for using Node.js 6.11.0 (x64) and npm.

C:\Users\peter>cd \ae\angu*

C:\ae\angular-tree-component>ng serve
As a forewarning, we are moving the CLI npm package to "@angular/cli" with the next release,
which will only support Node 6.9 and greater. This package will be officially deprecated
shortly after.

To disable this warning use "ng set --global warnings.packageDeprecation=false".

You have to be inside an angular-cli project in order to use the serve command.

C:\ae\angular-tree-component>

would it be nice to use it as a package like npm install angular-tree-component without using the javascript version.

I get the same error on macOS with the latest commit from the master branch (9c62a8a).
git clone https://github.com/500tech/angular-tree-component
Cloning into 'angular-tree-component'...
remote: Counting objects: 3610, done.
remote: Total 3610 (delta 0), reused 0 (delta 0), pack-reused 3609
Receiving objects: 100% (3610/3610), 16.32 MiB | 694.00 KiB/s, done.
Resolving deltas: 100% (2393/2393), done.

cd angular-tree-component/example/cli

npm install
><EMAIL_ADDRESS>install /Users/stevengbrown/Documents/git/500tech/angular-tree-component/example/cli/node_modules/fsevents
> node install

[fsevents] Success: "/Users/stevengbrown/Documents/git/500tech/angular-tree-component/example/cli/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile

><EMAIL_ADDRESS>install /Users/stevengbrown/Documents/git/500tech/angular-tree-component/example/cli/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/stevengbrown/.npm/node-sass/4.5.3/darwin-x64-57_binding.node

><EMAIL_ADDRESS>postinstall /Users/stevengbrown/Documents/git/500tech/angular-tree-component/example/cli/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/stevengbrown/Documents/git/500tech/angular-tree-component/example/cli/node_modules/node-sass/vendor/darwin-x64-57/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
added 1066 packages in 41.921s

npm install -g angular-cli
npm WARN deprecated<EMAIL_ADDRESS>angular-cli has been renamed to @angular/cli. Please update your dependencies.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
/usr/local/bin/ng -> /usr/local/lib/node_modules/angular-cli/bin/ng

><EMAIL_ADDRESS>install /usr/local/lib/node_modules/angular-cli/node_modules/fsevents
> node install

[fsevents] Success: "/usr/local/lib/node_modules/angular-cli/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile

><EMAIL_ADDRESS>install /usr/local/lib/node_modules/angular-cli/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/stevengbrown/.npm/node-sass/4.5.3/darwin-x64-57_binding.node

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/angular-cli/node_modules/node-sass
> node scripts/build.js

Binary found at /usr/local/lib/node_modules/angular-cli/node_modules/node-sass/vendor/darwin-x64-57/binding.node
Testing binary
Binary is fine
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

+<EMAIL_ADDRESS>added 897 packages in 30.704s

ng serve
As a forewarning, we are moving the CLI npm package to "@angular/cli" with the next release,
which will only support Node 6.9 and greater. This package will be officially deprecated
shortly after.

To disable this warning use "ng set --global warnings.packageDeprecation=false".

You have to be inside an angular-cli project in order to use the serve command.

The example/cli package.json lists @angular/cli as a dependency, not angular-cli.
Let's try again with the same Angular CLI version installed to node_modules.
./node_modules/.bin/ng serve
** NG Live Development Server is running on http://localhost:4200 **
Hash: d633b3f39eb61240f8d8                                                    / Time: 11988ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 260 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.js.map (main) 40.2 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 10.2 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 3.78 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.

Hooray, that works!

Opened pull request #409


KYLIN-3756 Support check-port-availability script for mac os x

JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3756

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4276

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.009%) to 26.883%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java
1
81.08%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

Totals

Change from base Build 4274:
-0.009%

Covered Lines:
18942

Relevant Lines:
70460

💛  - Coveralls

Codecov Report

Merging #542 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #542      +/-   ##
============================================
- Coverage     24.42%   24.41%   -0.02%
  Complexity     5025     5025
============================================
  Files          1161     1161
  Lines         70460    70460
  Branches      10020    10020
============================================
- Hits          17209    17201       -8
- Misses        51516    51522       +6
- Partials       1735     1737       +2

Impacted Files
Coverage Δ
Complexity Δ

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
74.41% <0%> (-2.33%)
12% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...g/apache/kylin/source/datagen/ColumnGenerator.java
70.94% <0%> (-1.36%)
8% <0%> (ø)

...a/org/apache/kylin/dict/Number2BytesConverter.java
82.53% <0%> (+0.79%)
18% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d0a37...6456b36. Read the comment docs.


Update Drone for 2.1 Milestones

removing Travis and adding Drone for 2.1 Milestone Bullseye build.

This was opened to initiate Drone. No longer required for milestone release.


[WIP] dwarf-fortress: 0.47.04 -> 0.47.05

Motivation for this change
Can't get the game to launch without seg faulting
maybe @shazow @bbigras  you could help?
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114710 at b936d598 run on aarch64-linux 1

1 package failed to build:

dwarf-fortress-packages.dwarf-therapist-original

I have to go into PRINT_MODE:TEXT to avoid an SDL initialization failure. I'm running on wayland/sway if that matters.

I have to go into PRINT_MODE:TEXT to avoid an SDL initialization failure. I'm running on wayland/sway if that matters.

That's probably because you have SDL_VIDEODRIVER=wayland in your environment. The SDL version used by dwarf-fortress is too old to have heard of Wayland. You should be able to use SDL_VIDEODRIVER=xcb when launching dwarf-fortress.

Would it make sense to update dwarf-therapist separately (to at least v41.2.0)? The current version is incompatible with the latest version of dwarf-fortress (v47.0.4) in nixpkgs.

Would it make sense to update dwarf-therapist separately (to at least v41.2.0)? The current version is incompatible with the latest version of dwarf-fortress (v47.0.4) in nixpkgs.

I can do that

dwarf-therapist was updated: https://github.com/NixOS/nixpkgs/pull/127136

I'm not sure why, but launching the game with gdb, I was able to determine that the crash was coming from unfuck. For now, I just chose to alias the 0.47.05 to 0.47.04 release, and it seems to have fixed everything... (probably gtk3 related failures, not sure)

cc @Artturin

I've been playing it for a while.


version 2.2.2 is not working with IntelliJ IDEA 2017.3 EAP Public Preview

[x] Plugin is in the latest version
[x] Issue was not reported yet
[x] Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description
Plugin version 2.2.2 is not working with IntelliJ IDEA 2017.3 EAP Public Preview (Build #IC-173.3415.22, built on October 25, 2017)
26-Oct-17
15:52	Plugin Error
			Problems found loading plugins:
			The following plugins are incompatible with the current IDE build: .ignore

Stack trace
2017-10-25 10:48:22,239 [ 144757]   INFO - notification.NotificationGroup - Notification group IGNORE_GROUP is already registered
java.lang.Throwable
	at com.intellij.notification.NotificationGroup.<init>(NotificationGroup.java:65)
	at com.intellij.notification.NotificationGroup.<init>(NotificationGroup.java:50)
	at com.intellij.notification.NotificationGroup.<init>(NotificationGroup.java:43)
	at mobi.hsz.idea.gitignore.util.Notify.show(Notify.java:84)
	at mobi.hsz.idea.gitignore.util.Notify.show(Notify.java:68)
	at mobi.hsz.idea.gitignore.TrackedIgnoredFilesComponent.handleFiles(TrackedIgnoredFilesComponent.java:115)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.util.messages.impl.MessageBusConnectionImpl.deliverMessage(MessageBusConnectionImpl.java:117)
	at com.intellij.util.messages.impl.MessageBusImpl.doPumpMessages(MessageBusImpl.java:448)
	at com.intellij.util.messages.impl.MessageBusImpl.pumpWaitingBuses(MessageBusImpl.java:409)
	at com.intellij.util.messages.impl.MessageBusImpl.pumpMessages(MessageBusImpl.java:398)
	at com.intellij.util.messages.impl.MessageBusImpl.pumpMessages(MessageBusImpl.java:386)
	at com.intellij.util.messages.impl.MessageBusImpl.sendMessage(MessageBusImpl.java:379)
	at com.intellij.util.messages.impl.MessageBusImpl.access$200(MessageBusImpl.java:45)
	at com.intellij.util.messages.impl.MessageBusImpl$2.invoke(MessageBusImpl.java:231)
	at com.sun.proxy.$Proxy122.handleFiles(Unknown Source)
	at mobi.hsz.idea.gitignore.IgnoreManager$RefreshTrackedIgnoredRunnable.run(IgnoreManager.java:601)
	at mobi.hsz.idea.gitignore.IgnoreManager$RefreshTrackedIgnoredRunnable.run(IgnoreManager.java:567)
	at mobi.hsz.idea.gitignore.IgnoreManager$5.task(IgnoreManager.java:180)
	at mobi.hsz.idea.gitignore.IgnoreManager$5.task(IgnoreManager.java:174)
	at mobi.hsz.idea.gitignore.util.Debounced$1.run(Debounced.java:72)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:242)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
2017-10-25 10:48:30,904 [ 153422]   INFO - .diagnostic.PerformanceWatcher - Unindexed files update took 19694ms; general responsiveness: ok; EDT responsiveness: 0/20 sluggish, 1/20 very slow

Steps to Reproduce

upgrade to IntelliJ IDEA 2017.3 EAP Public Preview (Build #IC-173.3415.22, built on October 25, 2017)

Versions
Plugin:
2.2.2

IDE:

IntelliJ IDEA 2017.3 EAP (Community Edition)
Build #IC-173.3415.22, built on October 25, 2017
JRE: 1.8.0_144-b01 amd64
JVM: Java HotSpot(TM) 64-Bit Server VM by Oracle Corporation
Windows 10 10.0

OS:
Windows 10, 64 bit, version 1709

Also seeing this in:
PhpStorm 2017.3 EAP
Build #PS-173.3415.21, built on October 25, 2017
PhpStorm EAP User
Expiration date: November 24, 2017
JRE: 1.8.0_152-release-1024-b6 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
.ignore Version: 2.2.2

Same in new CLion 2017.3 EAP build
Build #CL-173.3415.24, built on October 25, 2017
JRE: 1.8.0_152-release-1024-b6 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 8.1 6.3

Just to be more precise: IntelliJ upgrade from 2017.3 EAP 173.3302.5 (Released: October 18, 2017) to 2017.3 Public Preview 173.3415.22 (Released: October 26, 2017) introduced some issues for idea-gitignore plugin version 2.2.2
Related links:

https://blog.jetbrains.com/idea/2017/10/intellij-idea-2017-3-public-preview/
https://confluence.jetbrains.com/display/IDEADEV/IntelliJ+IDEA+2017.3+173.3415.22+Release+Notes

@hsz I can try to perform git bisect in order to discover intellij-community exact commit that caused issues for your plugin. Sounds good ?

@dejan2609  thank you for this report. Since we have many thumbs up, I'll fix it for sure this weekend and release - so I'd open this issue back.
I know what is the issue, commit discovering is not required, but thank you very much!

Note: just realized that I accidentally closed this ticket...
@hsz take your time and thanx in advance !

same with:
Gogland (1.0 Preview) 1.0 EAP
Build #GO-173.3415.23, built on October 25, 2017
JRE: 1.8.0_152-release-1024-b6 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6
.ignore Version: 2.2.1

Looks like mobi.hsz.idea.gitignore <= 2.2.2 was added to the brokenPlugins.txt resource in resources.jar for the latest IntelliJ release. Should reach out to Jetbrains to figure out why they've blocked the plugin again as in #408

Fix has been released with v2.3.0-RC.1 on EAP channel. Can you please verify if everything is fine for you?

@hsz For me your plugin works again as expected. Thanks a lot!
IntelliJ IDEA 2017.3 EAP (Ultimate Edition)
Build #IU-173.3415.22, built on October 25, 2017
IntelliJ IDEA EAP User
Expiration date: November 24, 2017
JRE: 1.8.0_144-b01 amd64
JVM: OpenJDK 64-Bit Server VM by Azul Systems, Inc.
Linux 4.4.0-62-generic

I'm using PHPStorm EAP 2017.3 and it still thinks the latest .ignore plugin is v2.2.2

@philCryoport
This early build is not available in public plugin channel.
Here is the instruction for switching to Early Access Preview repository channel
You an also download it manually from releases section

EAP v2.3.0-RC.1 has everything working fine for me again. Thanks.

Plugin version 2.3.0-RC.1 works like a charm with IntelliJ IDEA 2017.3 EAP (Build #IC-173.3415.22).
Thanx @hsz !

Previous plugin versions affects IDE stability and performance:

https://youtrack.jetbrains.com/issue/IDEA-180296
https://youtrack.jetbrains.com/issue/IDEA-180954
Here are comment for plugin's author in advance
https://github.com/hsz/idea-gitignore/issues/484#issuecomment-337858100
https://youtrack.jetbrains.com/issue/IDEA-180954#comment=27-2492220

@nicity I have reviewed above issues and everything should be now fine. All of your suggestions have been applied.

Thank you for fixing the issues!
My comment is about (historical) reasoning of the particular version having been disabled and notifications to you currently being used.

Yeah, it's also a good summary for this thread.
I'll handle a couple more things this week and then go with me public rise. Until then it'll be available only in EAP channel.

I can not start IntelliJ anymore after updating gitignore plugin. Preparing workspace... and nothing comes.

@boxsters1423 Thanks for letting me know. This is very strange situation.
Do you have any logs? I.e. when starting IDE from command line.
Do other projects are loading correctly?

macOs Sierra 10.12.6 (16G29)
IntelliJ IDEA 2017.2.5 Ultimate
@hsz How can I start it from command line ? show logs ? and remove the plugin ?

@boxsters1423 On Mac OS logs and plugins should be located in:

Logs (idea.log.path):
~/Library/Logs/
Plugins (idea.plugins.path):
~/Library/Application Support/

@hsz I updated to the new IntelliJ release 2017.2.5 perhaps it will work.

@hsz I guess this ticket can be closed:

two weeks passed since last comment was submitted and
plugin version 2.2.2 is working as expected on IDEA 2017.3 (Build #IC-173.3622.25, built on November 9, 2017).

@boxsters1423 @dejan2609 Thanks for the confirmation! Closing.

Im having the same problem:
I have moved from 2017.2.3 to the the new InteliJ 2017.3 version, and now cannot make any commits and pull requests on my Company app repository (they are still using 2017.2.3 version).
Any advice?


[SB8]: text panel component is not styled correctly

https://develop.design-system.pages.dev/?path=/story/components-forms-text-panel--text-panel-story
Button is not styled properly, component is not reacting on controls changes

Fixed


Exiting App via Touchscreen

Hi
Liking the app! I run it on a Pi 3b using an Official Raspberry Pi 7" Touchscreen. Currently the only way I can exit the app and return to the desktop is either by pressing Ctrl + C or via the [Stop] button on the html menu.
Would it be possible to create a script that when the screen is touched would enable an "Exit to desktop" option?
Thanks.

Glad it's working OK. This has cropped up before, and it would be quite easy to change https://github.com/helgeerbe/picframe/blob/main/picframe/viewer_display.py to do what you want, just add a pi3d.Mouse instance, check for clicks in the loop function and return False if one happens. However the functionality should really be made to enable other things to happen such as going to the next/previous slide or showing/hiding the clock. I think the previous suggestion was for a long press to stop the show.
I will try to think of a more flexible way to do this - maybe something along the lines of the interface_kbd.py but for mouse would work.

There is a pending Pull Request #179
@bobcoup are you able to test it?

@helgeerbe Sorry for the delayed response. Does this still need testing?

Hi @bobcoup would be great, if you have time.

Will work in release 2022.01.22


Webpack 2

Is there any plans to move Blendid to Webpack 2?

Absolutely! Pull requests will be accepted! If no one else gets to it, I do have a solid week coming up in my calendar to bang out the last few things, with that being a top priority along with custom task support #352

Ok great, I would be happy to contribute. Will try to provide something before your week arrive.

Done, and merged with the blendid branch!


Crash with explicitly annotated universes in the case of let-bound arrows

Following program crashes with U_name a not found error:
module Test

type t = #a:Type u#a -> x:a -> Tot unit

This was fixed and pushed to master.


[ClosureSpecializer] Don't release trivial noescape apply arg twice.

When a specialization is created, in the original function, releases are added in two different places:
(1) ClosureSpecCloner::populateCloned
(2) rewriteApplyInst
In the former, releases are added for closures which are guaranteed or trivial noescape (but with owned convention). In the latter, releases are added for closures that are owned.
Previously, when emitting releases at (2), whether the closure was trivial noescape wasn't considered.  The result was inserting the releases twice, an overrelease.
Here, fix (2) to recognize trivial noescape as not +1.
rdar://110115795

@swift-ci please test


fix: roles for 2.12.0-rc1 is missing create on secerts and list on sa

In 2.12.0-rc1 when using SSO RBAC - argo fails to create the secret, due to missing permissions in the argo-server-role
https://github.com/argoproj/argo/blob/0931baf5fbe48487278b9a6c2fa206ab02406e5b/server/auth/sso/sso.go#L135-L138

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

list permission is required on serviceaccounts:
https://github.com/argoproj/argo/blob/bfc13c3f5b9abe2980826dee1283433b7cb22385/server/auth/gatekeeper.go#L167-L171

Please run make codegen to fix build.

I'm not 100% sure we should add list sa and create secret to argo-server role. It is new privileges only needed for SSO + RBAC.
@jessesuen thoughts?

I dont understand why the codegen fails, it reports no change in my local branch.
And the DCO says: 'Commit sha: af85335, Author: Alex Collins, Committer: GitHub; The sign-off is missing.'

I'm not 100% sure we should add list sa and create secret to argo-server role. It is new privileges only needed for SSO + RBAC.

So long as this is in the namespace of the argo-server, I don't see a problem with it

This looks good, but it needs either (a) run make codegen or (b) apply this patch:
diff --git a/manifests/quick-start-minimal.yaml b/manifests/quick-start-minimal.yaml
index f70741e9..5468fc25 100644
--- a/manifests/quick-start-minimal.yaml
+++ b/manifests/quick-start-minimal.yaml
@@ -612,7 +612,8 @@ spec:
         runAsNonRoot: true
       serviceAccountName: argo-server
       volumes:
-      - name: tmp
+      - emptyDir: {}
+        name: tmp
 ---
 apiVersion: apps/v1
 kind: Deployment
diff --git a/manifests/quick-start-mysql.yaml b/manifests/quick-start-mysql.yaml
index ae1b29f1..4021bb39 100644
--- a/manifests/quick-start-mysql.yaml
+++ b/manifests/quick-start-mysql.yaml
@@ -656,7 +656,8 @@ spec:
         runAsNonRoot: true
       serviceAccountName: argo-server
       volumes:
-      - name: tmp
+      - emptyDir: {}
+        name: tmp
 ---
 apiVersion: apps/v1
 kind: Deployment
diff --git a/manifests/quick-start-postgres.yaml b/manifests/quick-start-postgres.yaml
index c77ffede..12688edc 100644
--- a/manifests/quick-start-postgres.yaml
+++ b/manifests/quick-start-postgres.yaml
@@ -656,7 +656,8 @@ spec:
         runAsNonRoot: true
       serviceAccountName: argo-server
       volumes:
-      - name: tmp
+      - emptyDir: {}
+        name: tmp
 ---
 apiVersion: apps/v1
 kind: Deployment

LGTM