capact act watch cannot be stopped

Description
capact act watch cannot be stopped using ctrl-c
Expected behavior
should stop
Actual behavior
doesn't stop :)
Steps to reproduce

create any action
run it
watch it
try to stop it

We use argo watch command directly and looks like they don't use Context from Cobra command:
		Run: func(cmd *cobra.Command, args []string) {
			if len(args) != 1 {
				cmd.HelpFunc()(cmd, args)
				os.Exit(1)
			}
			ctx, apiClient := client.NewAPIClient() // <-- Here
			serviceClient := apiClient.NewWorkflowServiceClient()
			namespace := client.Namespace()
			watchWorkflow(ctx, serviceClient, namespace, args[0], getArgs)
		},

Going few levels deeper, we have:
	gatekeeper, err := auth.NewGatekeeper(auth.Modes{auth.Server: true}, clients, restConfig, nil, auth.DefaultClientForAuthorization, "unused")
	if err != nil {
		return nil, nil, err
	}
	ctx, err := gatekeeper.Context(context.Background())

And what gatekeeper does is adding few values:
func (s *gatekeeper) Context(ctx context.Context) (context.Context, error) {
	clients, claims, err := s.getClients(ctx)
	if err != nil {
		return nil, err
	}
	ctx = context.WithValue(ctx, WfKey, clients.Workflow)
	ctx = context.WithValue(ctx, EventSourceKey, clients.EventSource)
	ctx = context.WithValue(ctx, SensorKey, clients.Sensor)
	ctx = context.WithValue(ctx, KubeKey, clients.Kubernetes)
	ctx = context.WithValue(ctx, ClaimsKey, claims)
	return ctx, nil
}

So we can't just replace the context with the cmd.Context(), we would need to merge it. As the context.Merge proposal is still open, we would need to use something like https://github.com/teivah/onecontext.
Or, figure some other way 🙂

I created a PR in Argo, which would fix this problem:
https://github.com/argoproj/argo-workflows/pull/6667


feat: Update minter for BSX so royalty can have 2 decimal places

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #4005
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

minted NFT with 10.11 royalty rate no problem, doesn't load on deploy (https://deploy-preview-4008--koda-nuxt.netlify.app/snek/gallery/659233203-1), but after trying to open it on local I get this:

doesn't load on deploy (https://deploy-preview-4008--koda-nuxt.netlify.app/snek/gallery/659233203-1)

minted NFT with 10.11 royalty rate no problem, doesn't load on deploy (https://deploy-preview-4008--koda-nuxt.netlify.app/snek/gallery/659233203-1), but after trying to open it on local I get this

Thanks for the test. Already fixed it.

Thanks for the test. Already fixed it.

in the meantime I found out that this was actually also problem on beta, and not a problem with this specific PR. perhaps related to some of the latest snek changes

perhaps related to some of the latest snek changes

Yes, it's because of the change of decimals of royalty.

setting royalty rate to 0 isn't permitted?

setting royalty rate to 0 isn't permitted?

Yup, the minimum limit is 0.01%.
Could royalty be 0? I'm not sure about it. @petersopko

setting royalty rate to 0 isn't permitted?

Yup, the minimum limit is 0.01%. Could royalty be 0? I'm not sure about it. @petersopko

I found that in the original code, it limits the royalty to be greater than zero.

I'm minting okay, just one last thing regarding the UX, I think it's a little bit of overkill to set the steps to 0.01%, moving up 1% requires me to either type it or tap/click 100 times 😄 can we set it to 0.10% per step?

703c29d

Good idea!
✅ Done

sorry to be a nitpicker but now the user doesn't see there's a possibility to add 0.01% difference (I guess zeros get hidden), can we alter the way we present the numbers there, i.e. always show 0.01% difference (even with zero?)

How about setting the default value to 0.15% ?

How about setting the default value to 0.15% ?

I think it'll work for now 😄

pay 50 usd

😍 Perfect, I’ve sent the payout
💵 $50 @ 44.68 USD/KSM ~ 1.119 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x2fb4729f55caeae55b9f6519ccce4f802e5820a1c5dc0200af4ac5d733784498
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Argument list too long: recursive header expansion failed

I'm having a problem.  How to fix it? Thanks.

Did you follow the readme setup steps and then still get the error?
Please provide ur compiling environment.
react native version.
react-native-agora version.
xcode version.
I didn't get this error in my environment.

If you can, I think that should be better way to upload your issue repo to Github that i can help u to fix that.

I found the reason for this issue. After I installed Firebase/Database. This is my package.json file
{
"name": "Trust",
"version": "0.0.1",
"private": true,
"rnpm": {
"assets": [
"./src/assets/fonts/"
]
},
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"test": "jest",
"devtools": "react-devtools"
},
"dependencies": {
"@expo/vector-icons": "^9.0.0",
"@react-native-community/async-storage": "^1.2.2",
"@types/lodash": "^4.14.123",
"@types/react-native-drawer": "^2.5.2",
"@types/react-native-i18n": "^2.0.0",
"@types/react-native-loading-spinner-overlay": "^0.5.1",
"@types/react-native-vector-icons": "^4.6.4",
"@types/react-navigation": "^3.0.1",
"@types/react-redux": "^6.0.12",
"axios": "^0.18.0",
"firebase": "^5.9.2",
"moment": "^2.24.0",
"native-base": "^2.10.0",
"react": "16.6.3",
"react-native": "^0.59.2",
"react-native-agora": "^2.3.3-alpha.5",
"react-native-awesome-alerts": "^1.2.0",
"react-native-elements": "^0.19.1",
"react-native-firebase": "^5.2.3",
"react-native-flash-message": "^0.1.10",
"react-native-gifted-chat": "^0.7.2",
"react-native-i18n": "^2.0.15",
"react-native-linkedin": "^1.3.1",
"react-native-linkedin-signin": "^0.0.2",
"react-native-loading-spinner-overlay": "^1.0.1",
"react-native-router-flux": "^4.0.6",
"react-native-vector-icons": "^6.2.0",
"react-navigation": "^3.0.9",
"react-redux": "^6.0.0",
"redux": "^4.0.1",
"redux-saga": "^0.16.2"
},
"devDependencies": {
"@types/react": "^16.7.18",
"@types/react-native": "^0.57.25",
"babel-jest": "23.6.0",
"jest": "23.6.0",
"metro-react-native-babel-preset": "0.51.1",
"react-devtools": "^3.6.1",
"react-native-typescript-transformer": "^1.2.11",
"react-test-renderer": "16.6.3",
"typescript": "^3.2.2"
},
"jest": {
"preset": "react-native"
}
}
Pod file
Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'Trust' do
pod 'AgoraRtcEngine_iOS'
Required by RNFirebase
pod 'Firebase/Core', '~> 5.15.0'
pod 'Firebase/Auth'
pod 'Firebase/Database'
pod 'react-native-agora', :path => '../node_modules/react-native-agora'
end

But I can't resolve it.

This is my repository: https://github.com/duongduckien/Trust.git

Can you help me? Thanks!

I m already clone your repo and trying setup it on local.

Okay, I find the problem and fixed the compiling environment already, but I still don't know why.
I will do more work around to find the reason. You could try below step to fix it in your Xcode.

Find RCTAgora.xcodeproj in project Libraries folder. and the select the target RCTAgora -> Build Settings -> Header Search Paths + Framework Search Paths, change recursive to non-recursive and replace all ../ios/Pods/ to ../ios/Pods/AgoraRtcEngine_iOS as the picture.

I can't resolved the GoogleService-Info.plist but i can compiled the RCTAgora module in my Xcode environment's. I think you could try my fix step first.

I can't resolved the GoogleService-Info.plist but i can compiled the RCTAgora module in my Xcode environment's. I think you could try my fix step first.

I'm trying the first way. Thanks!

@Matrixbirds It's working now. Thanks!


Wishlist

Here are some of the features to (possibly) be included.
Priority:

[ ] Plot of gene expression per ROI
[ ] Differential gene expression analysis
[ ] Interactive plot (top DE genes)
[ ] Display IF image to the side

Bonus points:

[ ] PCA
[ ] k-means / Louvain
[ ] UMAP
[ ] Heatmaps DE genes

Bonus A+ points:

[ ] Image registration

Pages

[ ] Upload/Description
[ ] Gene Expression and plots
[ ] Clustering


resize image upload

Summary
images should be compressed and resized before upload to server.
Environment Information

Device Name: iPhone 13 Pro - Asus  Zenfone Max Plus
OS Version: 16.1 - Android 7
Mattermost App Version: 1.55.1
Mattermost Server Version: 7.0.1

Expected behavior
the image should be resized on the client BEFORE uploading automatically (eg. like whatsapp)

Hi @yousefg, thanks for the feedback. Can you help me understand why this is desirable?
To shed some context here, we previously used to compress images but received negative feedback about the reduced image quality. We've since uploaded images at full size to maintain high quality when accessed via the computer or shared outside mattermost.

Got it, can you help a feature request on our idea forum so we can track it there? Agree it should be optional.
https://mattermost.uservoice.com/forums/306457-general

there is a request submitted on 2017!
https://mattermost.uservoice.com/forums/306457-general/suggestions/18343426-resize-image-upload

Thanks @yousefg, are you open to contributing an improvement like this? I am envisioning a system console setting where the admin can decide the default behaviour for the server (ie compressed or uncompressed)

Yes I’ll do my best, but I think client side compressing has better performance than server side. user can choose quality of images for upload(like Microsoft Teams). although admin already can limit Maximum File Size.

@yousefg can you share the settings or options you're referring to in Teams?

@Rishselva looping you in here as it relates to the investigation you were doing on max image dimensions and max file size defaults. I wonder if there's a solution here that solves both these use cases? I'll leave this in your hands to take over.

Thanks @esethna for your consideration.
Microsoft Teams Image upload quality screenshot:

@esethna There was any decision on this?

Certainly open to a contribution that implements this behaviour: https://github.com/mattermost/mattermost-mobile/issues/6718#issuecomment-1302565779
Otherwise, let's close this to track in the uservoice request.


Read Binary Content as Stream instead of a Binary Ressource

In FHIR an enhanced RESTful API for Serving Binary Resources is defined. Using it to read Binary resource content directly as stream will allow larger data transfers in data use projects.

Can be implemented after mii-processes-commons#28.


release: some components have a dependency to angular2 beta 8.

It seems like, a few scope components still have a dependency to an older version of angular. (Without scoping packages etc.)

Update: Seems like it's only card and checkbox

+1

+1

+1

+1

Yep, I missed removing it from those package.json files when I did the last release. You can ignore the warnings until the next alpha release.

Well I am glad i read this before creating a new issue for the checkbox :)
I will wait a couple of weeks until the angular team gets some rest from ng-conf and google IO and makes some releases that are not sleep deprived :wink:

@jelbourn when is the next alpha release going to happen

The next milestone should always have a date associated with it.
https://github.com/angular/material2/milestones

Should be fixed in the alpha.5 that was released today.
(we'll be setting a target date for alpha.6 in a couple of days)

Great work guys! Thank you.


Use nntrainer model for feature extraction

Hello!
I would like to use nntrainer as a feature extractor, like how tflite is used in the KNN example. But calling forwaring/inference uses the automatically added loss layer. Right now after calling inference i'm using model.getFlatGraph().back()->getOutputs() ... to get the values from the last layer added by me. Is there a better way to do this?

:octocat: cibot: Thank you for posting issue #927. The person in charge will reply soon.

Hello
There are multiple ways to extract the features from a pre-trained model -

As you described, running the inference() method and then model.getFlatGraph().back()->getOutputs(). However, this becomes complicated when extracting features from other layers.

Unfortunately, the current implementation of NNTrainer always attached a loss to the end of the model. With the loss attached, the inference includes the affect of the loss. In order to extract the features manually, there is no better way for now.
Soon we will be supporting extracting nntrainer trained model with TfLite compatible format #899 and then, you can directly use your trained model for feature extraction.
If the extracted features are going to be used later for more processing, you can directly use the model till the last layer as a backbone for your final task.
If the goal is just to extract the features, there is another hack you can try meanwhile is to use a loss (MSE in this case) for the inference model which does not affect the output of the layer. The inference model can use a submodel of the full training model as a backbone, and then use the features correspondingly.

We will add support for allowing no loss in the model, in order to facilitate your requirement.
The PR for this will be up soon.

Please check #934 which allows setting loss as none or skipping adding loss to a model.
You can create two model definition files (ini), one for training and another for feature extraction (consider using backbone while specifying desired output layer), load the trained model binary file in the model created for feature extraction.
Please let me know if you have more questions on this.

Can you please give me an example of an ini file for feature extraction? I tried to make one with loss=none and using my original ini as backbone, but i'm getting way different values then using the method i posted before. Also i tried to simply use setProperty({"loss=none"}) from the code using my originial ini, but i'm getting the same different values as with the second ini.

As you noticed, using the method you posted before vs using loss=none can give different results in two scenarios:

Last layer is softmax and loss is cross-entropy
Last layer is sigmoid and loss is cross-entropy
For numerical stability, these two layers are merged together as a single operation. So, when you use your method, model.getFlatGraph().back()->getOutputs(), this would return the output of the model without softmax/sigmoid.
However, with loss=none, the output would include softmax/sigmoid operation.

I will add a few examples of ini file for feature extraction based on different loss and last layer activations soon.

#934 has been updated to provide a mnist_inf.ini as an example to create a model without loss.
If you want to even remove the last layer, you can provide InputLayer and OutputLayer as arguments to backbone to select a submodel for feature extraction (refer ) or write the model in the ini file without the required layers/features (check line 63) as shown in comments in mnist_inf.ini.


gzip missing

Probably a nix problem (https://github.com/NixOS/nixpkgs/issues/28527)
Steps to reproduce:
 git clone https://github.com/nmattia/homies.git
 pushd homies
 nix-env -f default.nix -i --remove-all

Getting:

unpacking 'https://github.com/NixOS/nixpkgs/archive/c32e94c0c5129fab007900673c93a1da98324e30.tar.gz'...
tar (child): gzip: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
error: program 'tar' failed with exit code 2
(use '--show-trace' to show detailed location information)

gzip was just missing from the host.
Sorry for the spam.


User Mobile Number

@NeslyPetitBert  please change user-> mobile into nullable, its create error while we working with Oauth2

It's done ! (User->mobile not nullable TO User->mobile nullable)


Cannot connect to ActiveMQ

Hi,
I'm trying to connect to ActiveMQ 5.8.0 (running on port 8161) using your lib like this:
stompit.connect({     host: 'localhost',      port: 61613,     connectHeaders:{         host: '/',         login: 'admin',         passcode: 'admin'     } }, function(error, client){ if(error){ // error handling} //do something() });
Also tried to use the 8161 port..
But I keep getting "connect ECONNREFUSED <IP_ADDRESS>:61613"...
What could be wrong?
Thanks.

config for stomp was missing in activemq.xml


Add snippets

Adds a code snippet utility which returns a Python example for connecting to a given cluster.
In code
>>> dask_ctl.lifecycle.get_snippet("proxycluster-8786")
from dask.distributed import Client
from dask_ctl.proxy import ProxyCluster

cluster = ProxyCluster.from_name("proxycluster-8786")
client = Client(cluster)

or via the CLI
$ daskctl cluster snippet proxycluster-8786
from dask.distributed import Client
from dask_ctl.proxy import ProxyCluster

cluster = ProxyCluster.from_name("proxycluster-8786")
client = Client(cluster)

Codecov Report

Merging #12 (3f47d7e) into main (3cd2ee3) will decrease coverage by 1.36%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   79.18%   77.81%   -1.37%
==========================================
  Files           8        8
  Lines         269      284      +15
==========================================
+ Hits          213      221       +8
- Misses         56       63       +7

Impacted Files
Coverage Δ

dask_ctl/utils.py
100.00% <ø> (ø)

dask_ctl/cli.py
72.13% <46.66%> (-5.46%)
:arrow_down:

dask_ctl/tests/conftest.py
88.88% <80.00%> (-11.12%)
:arrow_down:

dask_ctl/__init__.py
100.00% <100.00%> (ø)

dask_ctl/discovery.py
85.71% <100.00%> (-0.96%)
:arrow_down:

dask_ctl/lifecycle.py
63.46% <100.00%> (+20.60%)
:arrow_up:

dask_ctl/proxy.py
91.30% <0.00%> (-6.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd2ee3...3f47d7e. Read the comment docs.


Integrate directly a PayByPhone API directly into paybybot3

Hello,
I have contacted PayByPhone customer support to verify if paybyphoneapis.com is owned and maintained by PayByPhone company. That is his answer:
I confirm that this site is not recognized as belonging to our company's domain.

Unfortunately, we do not provide APIs for developers.

paybyphoneapis.com is managed by a third party.
I think pass account and password to a third party could has some security issue. We don't know if this third party website is reliable. If a malicious people get user account and password from paybyphoneapis.com, he can use CB of the account to buy parking tickets for other cars.
And if one day, the website is down, paybybot3 will don't work. All software system build on is less robust than if paybybot3 communicate directly with PayByPhone official website.
I think that could be interesting to integrate directly a PayByPhone API from reverse engineering directly into paybybot3, instead using a  third party website API. What do you think?

Hello,
Please refrain from opening issues on the repo for non-issues. To clear up the confusion, if you try reverse engineering, you'll see that the official PayByPhone website uses this domain to communicate with its backend.
Customer support might not always have full technical details, so their response could be misleading.
Your concerns about security are generally valid, but in this case, this domain is part of the PayByPhone infrastructure, not a third-party site.
Feel free to verify this yourself through the reverse engineering process to confirm that domain is legitimate.
Thanks.

Thank you for clarifying my concern.

Please refrain from opening issues on the repo for non-issues.

Maybe the repo can activate the discussion feature of Github, so developer can discuss about the project. Currently, we can only communicate through issues.


Coap - v2

from v1:

changed api name
fix usage on coap
added missing functions

lgtm

:+1:

+1


Aqualand Check-In URL uses base64 encoding

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: Pixel 4XL
Android version: 11
App version: 2.4.3

Describe the bug
The Aqualand in Cologne is promoting the event check-in via CWA. They use an own system with a qr code and on the result page there is a base64 encoded deeplink for the CWA. This deeplink does not work when trying to open it on Android.
Link:
https://e.coronawarn.app/?v=1#CAESOAgBEhZBcXVhbGFuZCBHbWJIICYgQ28uIEtHGhxNZXJpYW5zdHJhw59lIDEsIDUwNzY1IEvDtmxuGnYIARJggwLMzE153tQwAOf2MZoUXXfzWTdlSpfS99iZffmcmxOG9njSK4RTimFOFwDh6t0Tyw8XR01ugDYjtuKwjjuK49Oh83FWct6XpefPi9Skjxvvz53i9gaMmUEc96pbtoaAGhAmIP0ROe/na9NpzD6f8WImIgcIARABGPAB
Result:

Steps to reproduce the issue
Simply try to open the link on an Android device.
Expected behaviour
The link is working.
Possible Fix
The base64 payload needs to be encoded as base64url.
Additional context
On iOS it is working as expected:

Internal Tracking-ID: EXPOSUREAPP-8237

It looks like the deeplink is encoded in Base64 while CWA Android is decoding in Base64URL, hence the character '/' which is contained in the deeplink can't be resolved.
Does CWA iOS use Base64? Is there any caveat switching Android to Base64 also for encoding and decoding?

We cannot use base64 because the built in qr code decoder handle this as url. This cause encoding problem of url strings.
Please forward the information the base64 needs to encoded as base64url

@PhilippNowak96
So if you just exchange '/' with '_' it results in a link encoded in Base64URL:
https://e.coronawarn.app/?v=1#CAESOAgBEhZBcXVhbGFuZCBHbWJIICYgQ28uIEtHGhxNZXJpYW5zdHJhw59lIDEsIDUwNzY1IEvDtmxuGnYIARJggwLMzE153tQwAOf2MZoUXXfzWTdlSpfS99iZffmcmxOG9njSK4RTimFOFwDh6t0Tyw8XR01ugDYjtuKwjjuK49Oh83FWct6XpefPi9Skjxvvz53i9gaMmUEc96pbtoaAGhAmIP0ROe_na9NpzD6f8WImIgcIARABGPAB
Which results in Android in:

Thanks everyone. We have created a ticket for tracking the issue and will see what we can do about this by communicating the problem to the associated parties.

Corona-Warn-App Open Source Team

Hey everyone,
thanks for the clarification! I wrote a support email to the recoverapp team (https://recoverapp.de/) describing the issue and added this issue as a link too. I will come back here again if I get any response of them.
@vaubaehn It was indeed very relaxing, thank you :)

The same issue was encountered here: https://github.com/corona-warn-app/cwa-website/pull/1130#issuecomment-825133260
I think one of the two clients should be changed so that they both behave the same.

We have informed the involved parties and made it more clear in the specification that base64Url encoding should be used (not regular base64). This should hopefully solve the issue.

Corona-Warn-App Open Source Team

I received an answer yesterday and they told me there needs to be a fix on some sort of interface. I'm not 100% sure if they mean their own one or something on CWA side. But they wanted to write me back as soon as they have a statement of one of their developers (first answer wasn't from a developer directly).


Fix the nullable parameter declarations for compatibility with PHP 8.4

Q
A

Is bugfix?
:white_check_mark:/:heavy_multiplication_x:

New feature?
✔/❌

Breaks BC?
✔/❌

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

I have prepared a small fix that resolves the following issue:
DEPRECATED  Yiisoft\Translator\TranslatorInterface::translate(): Implicitly marking parameter $locale as nullable is deprecated, the explicit nullable type must be used instead in vendor/yiisoft/translator/src/TranslatorInterface.php on line 46.

Yiisoft\Translator\TranslatorInterface
   public function translate(
       string|Stringable $id,
       array $parameters = [],
       string $category = null,
       string $locale = null
   ): string;

@martio Thank you 👍


Avoid reducing code readability

I see this change was made quite recently. In my opinion it makes it significantly harder to understand that bar calculates barycentric coordinates, compared to a method named Barycentric.

It is a matter of preference, I guess. For me, bar is a sufficient name (and even better when it is used in mathematical context) since this is a private, non-public method.
This bar is only used in PointInsideTriangle and probably could be converted to a local function.

@HalfVoxel
PS bar is a common name used in the literature for this 🙂

@HalfVoxel
I've been thinking about your issue.
In my opinion, many programmers tend to overcomplicate names for functions, variables, etc. This becomes a real problem when dealing with code that heavily contains mathematical expressions. I do not see a problem with using short names for math or internal purposes. I believe shorter names are even better, but everything should be balanced, of course. There are many other names in the project which have some ambiguous meanings, e.g., Kron, max, min, div, etc. Potential contributors/developers should learn about the usage of the internals themselves. Longer or shorter name will not help. In your example, I think shortening Barycentric to b may be too short (but not necessarily, e.g., in a local function this should be fine), but Barycentric to bar seems very reasonable.
To partly resolve this issue, I modified the CONTRIBUTING.md file
+ **Avoid overly complex names.** Simple names are usually more readable and easier to understand, especially in mathematical expressions and for internal use.

I hope this helps.
Best,
Andrzej

I respectfully disagree.
I'm also not a fan of too much abstraction and names like BeanManagerFactoryFactory. But I also think names should be clear. It's all well and good if you are working on a project alone, but if you want contributors to join in, then having comments and understandable names will help so much.
Case in point: I am pretty familiar with barycentric coordinates, I even wrote a method using them only two days ago. Yet, it took a lot of head scratching for me to realize that bar meant barycentric coordinates. Even still, without more context, I wouldn't have known if this method calculated barycentric coordinates from a point, or if it used barycentric coordinates to get a world-space point in a triangle.
max, min, div have pretty well understood meanings, even for people who are not mathematicians and programmers. kron is a bit sketchy, but at least googling for "kron function" immediately gives you the right result. Googling bar function gives you absolutely nothing relevant.
Having bar as a variable name would be totally fine, I think. But that is predicated on being able to see where that value came from (perhaps a method named Barycentric), so that one can quickly understand what it means.
Remember, mathematical literature is typically self-contained and they define their variables. If I read a paper that used the symbol ξ, I would expect to be able to find the definition pretty quickly.
That is to say, if one must have extremely short names, then there should at least be comments explaining what it means. For example, I have absolutely no idea what the alpha function you have means:
public readonly double alpha(double D, double d, bool initial) {
    var k = (int)math.round(math.log2(0.5f * d / D));
    var alpha = D / d * (1 << k);
    return initial ? alpha : 1 - alpha;
}

All names are just a single letter (alpha, D, d, k), and it's pretty much impossible to figure out what it actually does without perhaps trying to find the specific paper you used as a reference for implementing this algorithm (which I also believe is not written anywhere).
You may write your library in any way you like, but I'm just telling you that for me as a contributor, it would be a lot easier if names were easier to understand.

@HalfVoxel
In my opinion, your points don't make sense and seem to be influenced by the clean code principles, which I personally dislike and disagree with. To contribute meaningfully in this area, it's important to know what you're doing. Coding alone isn't enough—you need to understand the relevant literature and commonly used notations.
For example, how is ConcentricShellsAlphaParameter better than just alpha? To grasp this, you need to study the papers and research behind it. I've provided references to the literature in the documentation. As for commenting on internals, it often doesn't make sense since it introduces additional clutter and text that needs to be maintained. The idea that code should be 'self-commenting' is, in my opinion, a myth and a bad practice.
Additionally, I'm unsure about the purpose of opening issues like 'Avoid reducing code readability.' Project issues are typically focused on the API, bugs, performance, and features. Reporting on naming conventions seems unnecessary and a bit overly meticulous.
Best,
Andrzej

In my opinion, your points don't make sense and seem to be influenced by the clean code principles, which I personally dislike and disagree with.

I haven't personally read these, so I can't comment on them.

To contribute meaningfully in this area, it's important to know what you're doing. Coding alone isn't enough—you need to understand the relevant literature and commonly used notations.

Sure. But for a new contributor to a package, having good names/comments can make it significantly easier for them to get to that level of understanding.

For example, how is ConcentricShellsAlphaParameter better than just alpha
The first one does indicate that it has something to do with concentric shells. But it also contains "alpha" and "parameter" which are pretty redundant. Perhaps I could suggest edgeSplitFraction, as this indicates what it is used for.

/// See `Delaunay Refinement Algorithm for Quality 2-Dimensional Mesh Generation` page 40.
float edgeSplitFraction(float smallestConcentricShellRadius, float edgeLength, bool initialSplit)

I've provided references to the literature in the documentation.
Indeed, you have. Looks like you've added the documentation page since I last checked out this repo. Looks nice.

The idea that code should be 'self-commenting' is, in my opinion, a myth and a bad practice.
I agree. But it's either self-commenting or comments. The absence of both is what makes code hard to understand.

As for commenting on internals, it often doesn't make sense since it introduces additional clutter and text that needs to be maintained
True, to some extent. It's a balance that depends on team size primarily.

Additionally, I'm unsure about the purpose of opening issues like 'Avoid reducing code readability.' Project issues are typically focused on the API, bugs, performance, and features. Reporting on naming conventions seems unnecessary and a bit overly meticulous.

Sure. I didn't expect this to start a debate. Sorry about that.
I just thought that the diff I mentioned in the first post was such an obvious case of making things harder for contributors, that I thought I'd mention it. Obviously we disagree.


Add .env and node_modules

Fixes #4 and Fixes #5. This will also update the node version from 14 (:skull: ) to 20! the LTS

Thanks for the edits. It still needs a bit more work as far as proper structure is concerned actually, but these are a few good fixes.


METIS4 formula on Homebrew.jl

https://github.com/staticfloat/homebrew-juliadeps/pull/80

Done in 8d08cd3352e5d71d875b83cc8b4c403145ebc37d.


Simplify test_utils and align them closer to standard karma/jasmine. Add backend as a flag to ENV

This change is

Reviewed 2 of 3 files at r1, 43 of 44 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

src/environment.ts, line 291 at r2 (raw file):

      return false;
    } else if (feature === 'BACKEND') {
      return null;

here is where the defaults live, you should call this.getBestBackendType here, and below where you have "backendType = ..." just call ENV.get('BACKEND').

src/test_util.ts, line 26 at r3 (raw file):

export const WEBGL_ENVS: Features[] = [
  {'WEBGL_FLOAT_TEXTURE_ENABLED': true, 'WEBGL_VERSION': 1},

explicitly mark backend webgl for clarityx

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

src/environment.ts, line 291 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
here is where the defaults live, you should call this.getBestBackendType here, and below where you have "backendType = ..." just call ENV.get('BACKEND').

Done.

src/test_util.ts, line 26 at r3 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
explicitly mark backend webgl for clarityx

Done.

Comments from Reviewable


Example congif open access

Please give an open-source link to the example configurations that are currently hosted in an MIT repository that require an existing account for access. Thanks, great work.

Fixing in #7

Done!


Address Kafka Streams state machine changes introduced in KIP-696

KIP-696 made some changes in the way the error state in the Kafka Streams state machine is interpreted.
See this blog for more details (look under Kafka Streams section for KIP-696). With this change, the ERROR state is no longer considered a terminal state and the application may choose to stay alive and continue processing. This brings some issues in the binder in terms of backward compatibility. In the versions of Kafka streams prior to 2.8.0, the default behavior was that the client terminates if there is an uncaught error. Applications written with that assumption will fail with the change introduced by KIP-696 in Kafka Streams 2.8.0. This is especially a problem for the health check indicator in Kafka Streams binder. We should add an UncaughtExceptionHandler that restores the default behavior of previous versions - i.e. terminating the Kaka Streams client if there is an uncaught error. Users still have the option to override this by providing a custom UncaughtExceptionHandler in the application. See this for more details.

@sobychacko This seems to have broken the ability to override with a custom StreamsUncaughtExceptionHandler. In earlier versions, we were able to override using:
@Bean
    public StreamsBuilderFactoryBeanConfigurer streamsCustomizer() {
        return factoryBean -> factoryBean.setStreamsUncaughtExceptionHandler(nimbusStreamsUncaughtExceptionHandler);
    }

However, since the StreamsBuilderFactoryBean gets created and this gets set BEFORE the StreamsBuilderFactoryManager.start() is run, it replaces the custom exception handler with the function you set here to always SHUTDOWN_CLIENT. I am not finding a way to get around this--I think StreamsBuilderFactoryManager.start() should check to see if streamsBuilderFactoryBean.getStreamsUncaughtExceptionHandler() is null before setting the default one.

@jmelby70 This repository has been migrated to the core Spring Cloud Stream repository. In addition, this is a closed issue. Could you create a new issue in core and link it from there? Thanks!


Remove lsp-scala, as lsp-metals is bundled in lsp-mode

lsp-scala is deprecated. It's now bundled in lsp-mode as lsp-metals.

Looks good to me. Thanks for your help!

@jsravn @hlissner Sorry, I encoutered some problems. I mkdir a new dir and have simple build.sbt  declarations, ((scala +lsp) enabled in my init.el)
I have installed "Metals" (i.e. metals-emac binary is available in my PATH)
and yet when I M-x lsp-metals-build-import, the response I got is:
lsp-request: Timeout while waiting for response. Method: workspace/executeCommand.

I'm a total newbie of Scala or bst, any idea what I might have missed?

@alxiong it's fairly finicky to set up. Try lsp-metals-doctor-run and see if it complains about anything. I suggest asking on Discord too.


Uses interfaces

This feature requires the latest development version of league/event for now. We'll have to wait for a minor release to use EmitterAwareInterface. /cc @frankdejonge

Hm, seems like something went wrong with the coverage

2.1 version of league/event has been tagged. I updated the PR.

This needs rebasing.

Rebased

:+1:

Hm, why is scrutinizer always failing?


Sierra / Auth0 synchronisation

This is working in stage; we need to deploy it in prod before this is done.

Question - do we need to deploy it to prod to do any of the other work or can it wait to be deployed until when Jonathan is back and can check he's comfortable with the change in approach? (next week).


Upgrade to Rust 2021

Move to Rust 2021 and Refactor
Updates
Rust edition 2018 –> 2021
Version 2.5.2 –> 2.6.0
msrv according to cargo-msrv 1.40.0 –> 1.60.0, tested on x64 and arm64.
Small changes
Added "xdg" as keyword in cargo.toml
Add Swatinem/rust-cache to ci.yml and docs.yml for CI speed up.
Add CI and Doc-test badges to README.md.
actions/checkout v3 –> v4
Make lint workflow continue on fmt error, so clippy can also run.

Thanks! It looks like clippy is still unhappy: https://github.com/TimTheBig/rust-xdg/actions/runs/9257836687/job/25466781313#step:6:22

The main clippy complaint does make the code a lot cleaner so I would consider it:
self.state_home.as_ref().map(|home| home.as_path()),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using`self.state_home.as_deref()`

I can also make clippy ignore it if you prefer.

Yeah, let's apply that.

Yeah, let's apply that.
Apply the lint?

Feel free to swash on merge.


Date interface returns date without timezone offset on windows platform

Date interface works fine on ubuntu, but not on windows platform
on ubuntu
jerry> var a = new Date()
undefined
jerry> a
Sun Sep 27 2020 11:08:36 GMT+0800

windows platform
jerry> var a = new Date()
undefined
jerry> a
Sun Sep 27 2020 03:10:05 GMT+00:00
jerry>

Timezone handling should work fine on Windows too a year ago. (And it works for me locally.)
2b3faf683d5f78e696ad97999b761b53f3fed0ae implemented it and was included in 2.1.0 release.
If you still see this issue on the latest JerryScript, please tell us your JerryScript version (release or GIT hash),
details about your OS environment (OS version, local timezone, etc.)

@godmiaozi Can you confirm if it works for you too?

@ossy-szeged
Thanks for your reply and sorry for reply you so late. I have figured out why it does not work for me. I'm using MINGW to cross compile jerry, which tries to compile the windows compatible executable from linux platform. In this case, MINGW does not define the macro _WINDOWS, so the Date interface does not work correctly on my side. But it seems that  _WIN32 is defined by MINGW. i don't know whether it is better for jerry  to switch from _WINDOWS to _WIN32 or not.

@godmiaozi: Thanks for the investigation, I got it.

Ah, I forgot it, thanks for the ping. I'll prepare the PR.

@ossy-szeged What is the progress on this error?

Ah, I forgot it, thanks for the ping. I'll prepare the PR.


Hi when will the code be released please?

Hi,
The code is available now. Thank you for your patient waiting!


Network expose coreApiUrl

Description
This PR exposes the coreApiUrl  from the network interface because  currently coreApiUrl is no longer accessible on a given network instance.
const foo = (network: StacksNetwork) => {
  console.log(network.coreApiUrl);       // Not possible to access coreApiUrl on network interface
}

After applying the fix in this PR its possible execute network.coreApiUrl on given network interface
This PR closes issue #1065
Type of Change

[ ] New feature
[X] Bug fix
[ ] API reference/documentation update
[ ] Other

Does this introduce a breaking change?
No
Are documentation updates required?
No
Testing information
coreApiUrl can be accessed on given network interface
const foo = (network: StacksNetwork) => {
  console.log(network.coreApiUrl);       // possible to access coreApiUrl on network interface
  return network.coreApiUrl;
}

Checklist

[ ] Code is commented where needed
[ ] Unit test coverage for new or modified code paths
[X] npm run test passes
[ ] Changelog is updated
[X] Tag 1 of @yknl or @zone117x for review

Lint error needs fixed, otherwise LGTM

@zone117x Lint error fixed.
cc: @reedrosenbluth (if ready for merge or need further changes).

cc: @reedrosenbluth (if ready for merge or need further changes)


When you attempt to update the module in v11 it gives an error

I get the following error whenever I check for updates on the module:
Error: No module manifest found at https://github.com/YourFavouriteOreo/VTT-Chat-Reactions/releases/latest/download/dist/module.json

https://github.com/YourFavouriteOreo/VTT-Chat-Reactions/releases/download/v2.3.0/module.json should work , try it

That works but after you install it, every time you hit the update button it tries to download the update from the wrong place so it throws the error.

Fixed! I tracked down the bug to Github automated actions replacing the manifest URL with the one in the error. After downloading version 2.3.3 from the URL https://github.com/YourFavouriteOreo/VTT-Chat-Reactions/releases/download/v2.3.3/module.json, there should be no more issues checking for updates!


changesets-renovate

Current dependencies on/for this PR:

main

PR #20   👈

This comment was auto-generated by Graphite.


Metrics should be part of PolyMath

Cosine similarity, euclidean distance - these things are not limited to NLP. So they should be in PolyMath. And people who use Polyglot can install PolyMath if they need metrics

Sure, I can go ahead and add these to PolyMath but installing all of such a large package just for a few simple methods seems a little overkill.


scrobbles last listened to item on soundcloud perpetually

not sure why but whatever my last played thing in soundcloud is it endlessly scrobbles that over and over. this seemingly when i start a listening session later

This is a common problem that I am working on.

appreciate the reply and glad to hear ity'all rock. On Aug 8, 2019 1:22 PM, Austin H<EMAIL_ADDRESS>wrote:This is a common problem that I am working on.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

My best bet is only storing tracks when a good duration of the time the app is actively using the sound focus bit in android.
Luckily android requires apps tell android when they are using audio output.
This link really describes what I need to look at implementing.

#479 <- please try the newest signed debuggable android apk.


AB#9395 Display application and assessment summary in details panel

Can we get the summary to display off of the Value for the dropdowns and not the key?


Define max height of base image

Before of release I could set the max height of the image this way (work in Chrome):

Demo: https://codesandbox.io/s/react-image-crop-demo-wm7qs
Bug now, with version >= 8.3.0, this does not work.
https://codesandbox.io/s/react-image-crop-demo-x2rd7
Is there any other way to do this?

Hi check the release notes: https://github.com/DominicTobias/react-image-crop/releases/tag/8.3.0
I had to remove max-height: fill-available due to a serious Chrome bug. If you want that behavioud still then add it back via CSS:
https://github.com/DominicTobias/react-image-crop/commit/64693daabfcf42cf2a3029b33a27b8eec793fd79


Part of fileutil_concatMatlab wrong. In which cases do we need that part?

Do we need the following part of fileutil_concatMatlab at all?
Anyway, it seems to me to be outdated (old svn toolbox based on samples not on time).
if ~isempty(iMrkBV),
if length(varargcat{iMrkBV})>1,
orig_fs= file_loadMatlab(file_list{ii-1}, 'vars','fs_orig');
TT(ii-1)= round(T(ii-1)/varargcat{iNfo}.fs*orig_fs);
shift= sum(TT(1:ii-1));
for ii= 1:length(varargcat{iMrkBV}),
varargcat{iMrkBV}(ii).pos= varargcat{iMrkBV}(ii).pos + shift;
end
varargout{iMrkBV}= cat(1, varargout{iMrkBV}, varargcat{iMrkBV});
else
varargcat{iMrkBV}.pos= varargcat{iMrkBV}.pos + sum(T(1:ii-1));
varargout{iMrkBV}= ...
mrk_mergeMarkers(varargout{iMrkBV}, varargcat{iMrkBV});
end
end

This is for the case, that the markers are also stored in the 'original BrainVision format' (variable 'mrk_orig'). The times are stored in unit 'samples', can therefore require this code.


Add git SHA to output

Can we modify Olympia such that it always outputs the git SHA used to build the simulator? This will be helpful for reproducibility.

Yeah.  It's pretty easy.  I'll look into it.

@arupc can I take up this isssue?


programatically swiping card and left

am unable to do swipe card right or left programatically. as you have given some methods like cardStack.swipeTopCardRight() its is having some paramter like duration which is not explained in your example. and i want animation  to occur just as when we swipe even though we doi programtically.

you will have to elaborate, the parameter is the animation duration in milliseconds (it swiped left/right from the center to off screen in that time.)


Vibration API example

As far as I know, every browser that supports vibration does os without requiring permissions. But it's still a good example.
(Suggested by @marumari on Twitter: https://twitter.com/aprilmpls/status/717801697503002624)

Similarly, we may want to look at:
Battery API
Gamepad API
There are probably other ones that are essentially interacting with hardware, but in ways that don't require permissions.


POC - DO NOT MERGE: Deprecation cleanup

It seems ForeachProcessor was added to a public package by accident: this PR moves it into internal package. -- Technically this is a breaking change. Do we need a KIP for this, and actually only deprecate it instead?
This PR also deprecates a couple of "getters" on Joined object that "leak" -- we have JoinedInternal for getters, and I think Joined should be cleaned up. Happy to do a KIP for it (or both, ie happy to include ForeachProcessor).
We could also do a single KIP also including StreamsConfig. cf https://github.com/apache/kafka/pull/14548

Filed to tickets for both cases. Better save than sorry:

https://issues.apache.org/jira/browse/KAFKA-17224
https://issues.apache.org/jira/browse/KAFKA-17253

Will update this PR to just keep all the other cleanup.


Not working on a local network dev server

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
When launching developpement server on local network (ng serve --host <IP_ADDRESS> --disableHostCheck), tranloco tries to retrieve the language files on localhost and not the local network server.

Expected behavior
Transloco should retrieve language files on server host enpoint.
Minimal reproduction of the problem with instructions
Just launch ng serve --host <IP_ADDRESS> --disableHostCheck and access the developpement server from external device.
What is the motivation / use case for changing the behavior?
Test the web app on mobile device.
Environment

Angular version: 9.1.0

Browser:
- [ ] Chrome (desktop) version XX
- [x] Chrome (Android) version 81.0.4044.117
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 12.16.1
- Platform: Android

Others:
- Server: Windows 10
- Client: Android 8.1.0
- IDE: Webstorm 2020.1

Hi @mariusvn it is not related to Transloco, in order to load the translation with the above configuration you must fetch data from your IP or from <IP_ADDRESS> instead localhost.

Sorry, my bad ...


how to create(register)  actors?

/area runtime
/area placement
/area docs

Ask your question here
how to create(register)  actors?

See here: https://docs.dapr.io/reference/api/actors_api/#invoke-actor-method

oh,I noticed it,thank a lot !

@yaron2 I'm sorry, maybe I didn't describe it clearly.I have reviewed the relevant documentation.I still don't clear how to create actors.i noticed in default statestore.yaml likely flowing:
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: statestore
spec:
  type: state.redis
  metadata:
  - name: redisHost
    value: localhost:6379
  - name: redisPassword
    value: ""
  - name: actorStateStore
    value: "true"

contains: actorStateStore attribute. and dapr run find logs :
== DAPR == time="2020-11-16T17:34:07.261774912+08:00" level=info msg="placement order received: lock" app_id=addapp instance=yabing scope=dapr.runtime.actor type=log ver=0.11.2

== DAPR == time="2020-11-16T17:34:07.261834797+08:00" level=info msg="placement order received: update" app_id=addapp instance=yabing scope=dapr.runtime.actor type=log ver=0.11.2

== DAPR == time="2020-11-16T17:34:07.261853708+08:00" level=info msg="placement tables updated, version: 0" app_id=addapp instance=yabing scope=dapr.runtime.actor type=log ver=0.11.2

== DAPR == time="2020-11-16T17:34:07.26187218+08:00" level=info msg="placement order received: unlock" app_id=addapp instance=yabing scope=dapr.runtime.actor type=log ver=0.11.2

the actors created already, but where the actortype and actorId.

i'm sorry,   so register actors is via  dapr calling to user service code, the endpoint GET http://localhost:<appPort>/dapr/config


Field onBlur callback has newValue always equal to previousValue

version 6.5.0
<Feild      onBlur={(e, newValue, previousValue) => {         console.log(newValue === previousValue) /> <---always evaluates to true

<Feild -> There is a typo here.
Is this rendering correctly?

@diwakar-s-maurya, please provide a minimal, working example. Start from here: https://jsfiddle.net/gustavohenke/48814zsq/
And also please follow the template issue.

ping @diwakar-s-maurya


HHH-18139 remove IdentifierGeneratorFactory and related code

Apocalyptic change to how legacy generators are handled.

https://hibernate.atlassian.net/browse/HHH-18139
https://hibernate.atlassian.net/browse/HHH-18136

1050 lines of code, niiice.


Make dimensional storage actuators correctly report item amounts to mods that introspect ItemHandlers

Is your feature request related to a problem? Please describe.
The Dimensional Storage Actuator doesn't correctly report the stored item counts to other mod's inventory introspection features. For example, monitoring a Dimensional Storage Actuator with Botania's Corporea will report only a single item stack even if there are multiple stacks of items stored. 200 wheat is reported as 64. Here are images demonstrating the issue:

Similarly, adding multiple Corporea Sparks to the same Storage Actuator (via wormholes) will duplicate the item counts (Corporea will treat it as two separate inventories), as seen here:

Describe the solution you'd like
Ideally I would like if the Storage Actuator would correctly report item counts to other mods, and for wormholes to proxy to the actuator for item transport capability, rather than act as their own ItemHandlers. I am unsure if this is easily done, but I do know it is possible, because it worked with Arcane Archive's storage networks in 1.12. Perhaps looking at their code might shed some light on how to achieve it.
Additional context
Provided above.

ad item counts: The storage actuator does not "report" item counts - it simply provides an item capability handler for other mods to handle as they need (as do most storages, because that's the system used by vanilla). Wrong item counts happen if the other side does not take into account max stack size. The actuator has a stack size of 1024 in order to improve performance (speed & memory / network bandwidth usage) with (very) large storage counts.
Changes to that are currently not planned, however I can make the stack size configurable if that is desired - but I cannot account for side effects of changing the stack size or negative performance impact of a low stack size. Please do open a separate ticket if this is desirable.
ad capability: The wormhole already acts as a proxy, it finds the linked storage controller and forwards the capability from that controller. It does not have an item handle of its own:
    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, Direction side) {
        if (this.getLinkedStorageController() != null) {
            return ((TileEntity) this.getLinkedStorageController()).getCapability(cap, side);
        }
        return super.getCapability(cap, side);
    }

I assume corporea does not compare the capability references it gets from the wormholes and instead probably uses the block position of the tile entity (which is not unreasonable in 99% of all scenarios).
I'm closing this ticket as there are not changes directly related to it, but please feel free to make further comments or create new issues related to this!

ad item counts: The storage actuator does not "report" item counts - it simply provides an item capability handler for other mods to handle as they need (as do most storages, because that's the system used by vanilla). Wrong item counts happen if the other side does not take into account max stack size. The actuator has a stack size of 1024 in order to improve performance (speed & memory / network bandwidth usage) with (very) large storage counts.
Changes to that are currently not planned, however I can make the stack size configurable if that is desired - but I cannot account for side effects of changing the stack size or negative performance impact of a low stack size. Please do open a separate ticket if this is desirable.

I just gave myself a major headache reading through the Corporea code (forgive me for this, as I'm not a modder and lack the contextual knowledge) to see how it handles this, which sent me on a dive through Forge documentation and old forum posts. I apologize, I wasn't aware of the limitations on determining stack sizes and just how much work is involved in making inventories that hold more than the max stack size per slot.
It seems that the Crystal cube, when updating it's count, finds it's attached spark, which then finds all the other attached sparks, iterates through all the "nodes" (tile entitites attached to those sparks) and if it's a vanilla or forge tile entity with an Item capability, it iterates through all the slots of the inventory and calls the itemStack.getCount() method for that slot, finally adding all the counts together.
My limited programmer knowledge tells me that overriding that getCount method through some facade abstraction might be a much cleaner solution, but I'm unsure if this is possible in the MC modding world, so if it's a faff, then a config setting like you described that can decrease the max stack size to the vanilla defaults would be an acceptable solution, barring whatever performance penalties there may be.
One question I have about that is how the actuator would behave with things that have different default stack sizes, like Eggs, Ender Pearls, Potions, Buckets, etc?

I assume corporea does not compare the capability references it gets from the wormholes and instead probably uses the block position of the tile entity (which is not unreasonable in 99% of all scenarios).

You are correct, it does work this way. One thing that boggles me is how it works with Arcane Archives networks somehow, but that suggestion was more of a "polish" suggestion as it's not crucial to gameplay - one can just limit themselves to one spark per actuator "network".


Instant crash whenever launchbuddy is launched

Whenever I launch it the program shows a black window and crashes without any kind of error messages.

I clicked on Launch Buddy this morning and it disappeared completely did nothing else so I attempted to reload and the same thing happened, any suggestions ?

Corrupted LB Config files will nwo be overwritten when import failed.
https://github.com/TheCheatsrichter/Gw2_Launchbuddy/commit/9b22b7a4c7039d73d4f6f463f5b953d393f28bf9
This fix will be pushed with the next release

#289


Remove case-sensitivity from vote command

Fixed in https://github.com/HTSTEM/TWOW_Bot/commit/1ea62fca9a806917c1130c23515e8727eea4d8ff


fix(deps): Upgrade Relaynet lib to v1.41+

Looking into broken build: https://gradle-community.slack.com/archives/CAHSN3LDN/p1610031398019200

Looking into broken build: https://gradle-community.slack.com/archives/CAHSN3LDN/p1610031398019200


guide: Persisting Experiments

A document in Experiment Management section to tell different ways of persisting experiments may be nice.
Related #2548

Could also be part of https://github.com/iterative/dvc.org/issues/2548 possibly. At least initially

I mean https://github.com/iterative/dvc.org/pull/2752


[Meta] Adding Cloth Config API as a Required Dependency in CurseForge & Modrinth

With this, the launchers(both CF and MR) will automatically download Cloth Config API when downloading this mod(Suggestion Tweaker).
It improves the user experience.

I was going to do that at some point but I forgot. Thanks for the reminder! All new versions will have this.


How standard is current JSON format of EnclaveInfo?

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

I would like to re-use the validatequotes.core C# utility for Microsoft Azure Attestation (MAA) in Graphene (validatequotes.core).
This utility takes a JSON file as input and sends the request to the MAA service and gets the JWT result back.
According to the MAA standard, the "Attestation Request" to the MAA service only requires two fields:

Quote (your typical SGX quote provided by the Quoting Enclave)
Enclave Held Data (basically, SGX report's reportdata)

However, the JSON file that the validatequotes.core expects has several additional fields: Type, MrenclaveHex, etc. See for example https://github.com/Azure-Samples/microsoft-azure-attestation/blob/master/intel.sdk.attest.sample/genquotes/out/enclave.info.release.json.
Given that I need to construct the "expected" JSON file in Graphene, do I actually need to specify anything other than the required Quote and Enclave Held Data? Or to ask differently: is this JSON format only an example or it may be considered standard (if I want to use validatequotes.core or a similar utility in the future)?

@dimakuv you are correct, for the quote validation sample it should be sufficient to pass only quote and enclave held data within the JSON file.

@dimakuv - thanks for reaching out.
The enclave info JSON file format is only used by the sample code.  In addition to the info required to call the MAA attest API (i.e. quote + enclave-held-data), the enclave info JSON file contains a copy of the values that the sample code believes should be encapsulated in the quote (i.e. type, mrenclavehex, ...).  This is because the sample code will verify that the fields in the JWT token produced by the MAA service match the values used when the enclave was originally compiled.
Closing this issue since it seems resolved.


ADD RED RUNNER GAME

Red Runner
Red Runner, Awesome Platformer Game.
It is now free and open source and always will be. :clap: :tada:

:sparkles: Getting Started
:rocket: Download
:camera: Screenshots

SCREENSHOT:

@Sulagna-Dutta-Roy  , Could you please assign me this issue under gssoc'24 ?
GSSOC'24

Assignee has received the full points from my repo. Closing this


Fix small typo in readme

Please write a description in this text box of the changes that are being
made.

Small change to README.md documentation.

Please ensure that you have written units tests for the changes made/features
added.

Reviewed in text editor.

build


Invoice - There is "Delete expense" option in the invoice paid system message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4728016
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:

User has received invoice.
The following steps will be performed by the invoice receiver.

Click on the invoice preview.
Click on the pay button.
Pay the invoice.
Right click on the paid system message.

Expected Result:
There should be no "Delete expense" option in the invoice paid system message.
Actual Result:
There is "Delete expense" option in the invoice paid system message. The invoice cannot be deleted.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/8af6bb68-c8e7-40f8-a470-b72bf42c4ce1

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - There is "Delete expense" option in the invoice paid system message
What is the root cause of that problem?
As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned  here
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1635
which will make the report action to be deleteable
What changes do you think we should make in order to solve the problem?

We need to change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1633
            if (!isEmptyObject(linkedReport) && (isMoneyRequestReport(linkedReport) || isInvoiceReport(linkedReport))) {

What alternative solutions did you explore? (Optional)
Or we can also change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1634
to
return !isInvoiceReport(linkedReport);

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - There is "Delete expense" option in the invoice paid system message
What is the root cause of that problem?
As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned  here
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1635
which will make the report action to be deleteable
What changes do you think we should make in order to solve the problem?

We need to change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1633
            if (!isEmptyObject(linkedReport) && (isMoneyRequestReport(linkedReport) || isInvoiceReport(linkedReport))) {

What alternative solutions did you explore? (Optional)
Or we can also change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1635
to
return !isInvoiceReport(linkedReport);

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - There is "Delete expense" option in the invoice paid system message
What is the root cause of that problem?
As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned  here
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1635
which will make the report action to be deleteable
What changes do you think we should make in order to solve the problem?

We need to change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1635
to
return !isInvoiceReport(linkedReport);

or
return false;

What alternative solutions did you explore? (Optional)
Alternatively we can change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1624-L1628
to
const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
        const isPayAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY;

        if (isSplitAction || isPayAction) {
            return false;
        }

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - There is "Delete expense" option in the invoice paid system message
What is the root cause of that problem?
As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned  here
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1635
which will make the report action to be deleteable
What changes do you think we should make in order to solve the problem?

We need to change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1635
to
return !isInvoiceReport(linkedReport);

or
return false;

alternatively change
https://github.com/FitseTLT/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632
to
            if (!isEmptyObject(linkedReport) && (isMoneyRequestReport(linkedReport) || isInvoiceReport(linkedReport))) {

What alternative solutions did you explore? (Optional)
But we can disallow delete menu for  all pay type IOU report actions by changing
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1624-L1628
to
const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
        const isPayAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY;

        if (isSplitAction || isPayAction) {
            return false;
        }

We can also include other REPORT_ACTION_TYPE if needed

Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - There is "Delete expense" option in the invoice paid system message
What is the root cause of that problem?
As the linkedReport is an invoice type canAddOrDeleteTransactions will not be executed and true will be returned  here
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632-L1635
which will make the report action to be deleteable
What changes do you think we should make in order to solve the problem?

we should disallow delete menu for  all pay type IOU report actions by changing
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1624-L1628
to
const isSplitAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT;
        const isPayAction = ReportActionsUtils.getOriginalMessage(reportAction)?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY;

        if (isSplitAction || isPayAction) {
            return false;
        }

We can also include other REPORT_ACTION_TYPE if needed
We can narrow down the logic by applying it to pay actions of only invoice reports  isInvoiceReport(linkedReport)
What alternative solutions did you explore? (Optional)
We can change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1635
to
return !isInvoiceReport(linkedReport);

or
return false;

alternatively change
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632
to
            if (!isEmptyObject(linkedReport) && (isMoneyRequestReport(linkedReport) || isInvoiceReport(linkedReport))) {

Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an option to delete expense on a paid system message on an invoice report.
What is the root cause of that problem?
The option to delete will show if canDeleteReportAction returns true.
https://github.com/Expensify/App/blob/f392cd369131e80b09e1ada8afd239d461257b24/src/libs/ReportUtils.ts#L1616-L1637
For money request action, if the money request action belongs to a money request report (IOU/expense), then it will check using canAddOrDeleteTransactions, otherwise, it will straightly returns true.
In our case, it's not either an IOU/expense report, but an invoice report, so canDeleteReportAction always returns true for the paid system message (which is also an IOU action) which shows the option to delete the message.
What changes do you think we should make in order to solve the problem?

We can simplify the condition by following the condition from the details page as shown below:
https://github.com/Expensify/App/blob/f392cd369131e80b09e1ada8afd239d461257b24/src/pages/ReportDetailsPage.tsx#L195
https://github.com/Expensify/App/blob/f392cd369131e80b09e1ada8afd239d461257b24/src/libs/ReportUtils.ts#L1631-L1636
to
return isActionOwner && (canAddOrDeleteTransactions(linkedReport) || isSelfDM(linkedReport)) && !ReportActionsUtils.isDeletedAction(reportAction);

we actually don't need isDeletedAction because once we delete an aciont, we can't interact with it anymore, even while offline, but I'm gonna leave that

@jayeshmangwani we have a couple of proposals above when you have a chance — thank you!

@bernhardoj Can you please break down for us how this issue will be solved if we use the same condition from the details page?
I see you are suggesting removing the checks for isEmptyObject and isMoneyRequestReport. Will this not cause a regression if we do not check these before calling canAddOrDeleteTransactions?
Lastly, do we need to add an isSelfDM check here? I am not sure if the invoice will be for the self DM.

Can you please break down for us how this issue will be solved if we use the same condition from the details page?

The money request action opens the transaction thread and to delete it, we need to delete it from the details page, so it makes sense to use the same condition for both details and money request action. If you compare the condition, they look similar,
https://github.com/Expensify/App/blob/ccf9591f3c603716afd92a26a11bc137eecd0b5e/src/libs/ReportUtils.ts#L1628-L1634
https://github.com/Expensify/App/blob/ccf9591f3c603716afd92a26a11bc137eecd0b5e/src/pages/ReportDetailsPage.tsx#L196
but the canDeleteReportAction is not really good. If isActionOwner is false, then it proceeds with the non-money request action logic instead of returning false. If it's not a money request report, then we always return true.

I see you are suggesting removing the checks for isEmptyObject and isMoneyRequestReport. Will this not cause a regression if we do not check these before calling canAddOrDeleteTransactions?

canAddOrDeleteTransactions already contains the condition for isMoneyRequestReport which will returns false if it's not a money request report compared to the current logic which will return true. If it's an empty object, then isMoneyRequestReport will be false.
https://github.com/Expensify/App/blob/ccf9591f3c603716afd92a26a11bc137eecd0b5e/src/libs/ReportUtils.ts#L1589-L1592

Lastly, do we need to add an isSelfDM check here? I am not sure if the invoice will be for the self DM.

We need it for the self DM track expense.

I feel that we should only add the missing isInvoiceReport Check here, as suggested by @FitseTLT in their alternate Proposal
https://github.com/Expensify/App/blob/7ba66a1542fa815eed5cb4622244bc2935593484/src/libs/ReportUtils.ts#L1632
🎀 👀 🎀 C+ reviewed

No update on the PR

@FitseTLT you have been paid!
@jayeshmangwani can you complete the checklist at your earliest convenience?

Payment Summary
@FitseTLT — paid $250 via Upwork
@jayeshmangwani — to be paid $250 via NewDot

[x]  [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/40303
[x]  [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40303#issuecomment-2284067204
[x]  [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x]  [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
[x]  [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: Ensure the user has received an invoice.
Open App -> Go the invoice chat.
Click on the invoice preview.
Click on the Pay button to pay the invoice.
Right click on the Paid system message.
Verify that the Delete Expense option does not appear.

Do we agree 👍 or 👎

No worries thank you! Payment summary is linked here!
Test rail regression GH linked above, so closing!

Requested on ND as per https://github.com/Expensify/App/issues/45632#issuecomment-2283981817

$250 approved for @jayeshmangwani


Feat(inbound): Bind company name from domain

Problem

The company name is the company domain name, which is not what the user expects

Solution

Improve company name parsing from domain

How To Test

Send a mail with inbound e-mail address

Additional Checks

[X] The documentation is up to date
[ ] Tested with fakerest provider (see related documentation) (N/A)

Setting up a library leads to problems with unit tests due to the incompatibility with node and Deno. We will need to invest on this to set up everything correctly


DynamoDB Local Repository broken [HTTP Response 404]

Trying to use the maven repository for dynamodb local artifacts. The hosted repository (http://dynamodb-local.s3-website-us-west-2.amazonaws.com/release) is returning HTTP 404 errors.
Getting build errors from gradle.
Could not resolve all dependencies for configuration ':testCompile'.
Could not find any matches for com.amazonaws:DynamoDBLocal:1.+ as no versions of com.amazonaws:DynamoDBLocal are available.
     Searched in the following locations:
         https://jcenter.bintray.com/com/amazonaws/DynamoDBLocal/maven-metadata.xml
         https://jcenter.bintray.com/com/amazonaws/DynamoDBLocal/
         https://repo1.maven.org/maven2/com/amazonaws/DynamoDBLocal/maven-metadata.xml
         https://repo1.maven.org/maven2/com/amazonaws/DynamoDBLocal/
         http://dynamodb-local.s3-website-us-west-2.amazonaws.com/release/com/amazonaws/DynamoDBLocal/maven-metadata.xml
         http://dynamodb-local.s3-website-us-west-2.amazonaws.com/release/com/amazonaws/DynamoDBLocal/

Changing the repository URL to https://s3-us-west-2.amazonaws.com/dynamodb-local/release fixes the dependency resolution problem.
From: http://dynamodb-local.s3-website-us-west-2.amazonaws.com/release
To: https://s3-us-west-2.amazonaws.com/dynamodb-local/release
Inspecting the two urls, this looks like the same s3 bucket. Could this perhaps be an issue with the S3 service itself?

It broke our production deployment.

Apologies for the inconvenience, as a security measure we stopped serving traffic via HTTP, but failed to update all relevant documentation. For the time being, we have re-enabled HTTP traffic, but will be migrating to HTTPs only in the near future.
Please use this HTTPs link in your pom file:
https://s3-us-west-2.amazonaws.com/dynamodb-local/release
We will be updating the official AWS docs soon to notify everyone of this change.

please please please inform us before making this kind of change. it may seem like a simple change change but maven cannot know the new urls so you can break our continuous integration and deployment systems with this small change. you may at least redirect traffic to https and update the docs before making any backward incompatible change.

when accessing: https://s3-us-west-2.amazonaws.com/dynamodb-local/release
it comes an error:

NoSuchKey
The specified key does not exist.
release
10C05F0C9DDA579A
FgsMC8+3I4sC+b/CP/G5dw9aFRriHfccEfiyki0xsr661jW6Vfr+jXIojgO2feNd4jc49t6omYA=

I found the following worked:
    <repositories>
        <repository>
            <id>dynamodblocal</id>
            <name>AWS DynamoDB Local Release Repository</name>
            <url>https://s3-us-west-2.amazonaws.com/dynamodb-local/release</url>
        </repository>
    </repositories>

        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>DynamoDBLocal</artifactId>
            <version>[1.11.119,2.0)</version>
        </dependency>

If you want the latest version it can be found here https://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_latest.tar.gz


Add bucket name check

Wonder if can do this at cdk diff stage
1/5 | 11:43:29 | UPDATE_FAILED | AWS::S3::Bucket | seleniumbase_bucket (seleniumbasebucket4FC88E60) Bucket name should not contain '_'

Absolutely. Should be easy to add this validation.

We had some at some point but removed it because of stringified tokens. But that's just an if away


Would you be willing to help implement this feature?

WTF

Most certainly, created by accident when browsing issues on mobile. Thanks for reporting!


feat: add Validation to/in Autocomplete control

🙋 Feature Request
Using the Autocomplete control, we are dynamically setting required to "true" when a different control is populated.
This properly sets the requirement; you cannot submit the form when the control is empty. However, the field remains required and will not validate successfully, even after you select a value. It would be nice for the validation to properly accept a value and allow for submission.
This was reported as a Bug, but marked 'working as designed'. So I'm converting it to a feature request for future consideration.
🤔 Expected Behavior
When we select a value in the autocomplete control, it should no longer say that the field is required, and allow the form to submit.
😯 Current Behavior
Field fails validation, even after a selection is made.

💁 Possible Solution

🔦 Context
We would like to have a an autocomplete control be required when another field is selected. The control should require a selection and validate properly.
💻 Examples
Examples provided in referenced Bug ticket.

Indeed. This feature is not yet implemented, as described in the doc.
I don't think we'll have time to develop it before v5. You have to handle this exception manually.


1 to the power of anything is 1

Add a new function to simplifyBasics, similar to the others there, to simplify 1^___ => 1
Now, technically 1^infinity is not 1, so we should probably only do this simplification if the exponent has no symbol terms (i.e. it would eventually simplify to a constant, which you can check with MathResolveChecks.resolvesToConstant)

added in #69


Suggestion: Terminology Primer Page

Hi Anais and Rishab,
Awesome project. Thank you for creating it.
What do you think about adding a "Terminology Primer" page to the "Let's get started" section. It could be a glossary of sorts with the most common terms that people will encounter as they are on their 100 Days of Kubernetes journey. We could add one line explanations for each term.
I think this might help people who are brand new to the space.
If you think it will be useful, I can pull something together over the next day or two and submit a pull request.
Let me know what you think.
Thanks
Karl Cooke (@Karl_ITNerd)

Hey Karl,
I think that sounds amazing! Do you want to have it under a separate section that is just focused on the glossary?
It would be amazing if you want to give it a go. Obv. I am here to help and others are probably excited to contribute, too 🙂
Lmk if you have any questions!

Glossary sounds like a good spot! I'll give it a go over next couple days and then, once it's up it can grow from there.

I have this mostly completed. I'll submit as a PR later.

@irishtechie great, thank you! Please link to this issue :)

@AnaisUrlichs, will do. Thank you.

@AnaisUrlichs I feel a bit dumb but the option to link with a PR on the right isn't editable by me. Perhaps I am missing something.


Fixes based on Freshteam OpenAPI spec update

Spec update

[x] Add updated Freshteam OpenAPI spec as a resolved JSON file
[x] Generate code from updated Freshteam OpenAPI spec

Applicants

[x] Applicant.archive() now takes an Applicant instead of ApplicantArchive. Remove the unused model.
[x] Applicant.list() now has pagination support
[x] Pagination tests for Applicant.list()
[x] Model ApplicantListQuery has pagination fields sort, sort_type, and page.
[x] Model ApplicantListQuery has new field requisition_id
[x] Model ApplicantListQuery has new field created_at
[x] Rename model: InlineObject4 -> Applicant1. Retain alias ApplicantSubStage

Employees

[x] Rename model: InlineObject2 -> EmployeeFields. Retain alias EmployeeFieldCreate
[x] Fix typo in internal method: fieldsApi.createEmployeeField()
[x] Pagination tests for Employees.list()

Job Postings

[x] JobPostings.list() now has pagination support
[x] Model JobPostingsListQuery has pagination fields sort, sort_type, and page.
[x] Pagination tests for JobPostings.list()

Time-Offs

[x] TimeOffs.approve() now takes a LeaveRequest instead of LeaveRequestApprove. Remove the unused model.
[x] Rename model: InlineObject -> LeaveRequest1. Retain alias LeaveRequestReject

Need to configure GH Actions runners for the repo.


Empty documentation is beeing generated

Search terms
empty documentation, modules, import
Question
Hey guys! I'm getting an empty documentation when try to generate that.
But this is actual only for imported files. When I add e.g. any class to the file specified in entryPoints, I get documentation for that.
But for imported files I get nothing.
I have such typedoc.json:
{
  "entryPoints": ["src/app.ts"],
  "out": "docs",
  "includes": "src"
}

Full source code is here
How can I solve this?

I wont say, maybe you go learning python, and didn't have more exceptions

I should use entryPointStrategy instead.


Project abandoned??

Last commit was over a month ago, and it seems like most issues are not getting solved.
Did this project go abandoned??

nah

yes, sorry.


NCCL issues on single node

Hello, I'm trying to use DeepSpeed on a VastAI instance with 2x 3090 but I'm getting the following error with NCCL:
2021-02-08 22:59:17,860] [WARNING] [runner.py:117:fetch_hostfile] Unable to find hostfile, will proceed with training with local resources only.
[2021-02-08 22:59:17,910] [INFO] [runner.py:355:main] cmd = /opt/conda/bin/python -u -m deepspeed.launcher.launch --world_info=eyJsb2NhbGhvc3QiOiBbMCwgMV19 --master_addr=<IP_ADDRESS> --master_port=29500 ./trainer.py
[2021-02-08 22:59:18,790] [INFO] [launch.py:71:main] 0 NCCL_IB_DISABLE 1
[2021-02-08 22:59:18,790] [INFO] [launch.py:71:main] 0 NCCL_DEBUG info
[2021-02-08 22:59:18,790] [INFO] [launch.py:71:main] 0 NCCL_SOCKET_IFNAME lo
[2021-02-08 22:59:18,790] [INFO] [launch.py:78:main] WORLD INFO DICT: {'localhost': [0, 1]}
[2021-02-08 22:59:18,790] [INFO] [launch.py:87:main] nnodes=1, num_local_procs=2, node_rank=0
[2021-02-08 22:59:18,790] [INFO] [launch.py:99:main] global_rank_mapping=defaultdict(<class 'list'>, {'localhost': [0, 1]})
[2021-02-08 22:59:18,790] [INFO] [launch.py:100:main] dist_world_size=2
[2021-02-08 22:59:18,790] [INFO] [launch.py:103:main] Setting CUDA_VISIBLE_DEVICES=0,1
Special tokens have been added in the vocabulary, make sure the associated word embedding are fine-tuned or trained.
Special tokens have been added in the vocabulary, make sure the associated word embedding are fine-tuned or trained.
Loading cached split indices for dataset at tokenized_stories/cache-c445c6e9b0614129.arrow and tokenized_stories/cache-046b4417a885620e.arrow
Loading cached split indices for dataset at tokenized_stories/cache-c445c6e9b0614129.arrow and tokenized_stories/cache-046b4417a885620e.arrow
[2021-02-08 23:00:50,288] [INFO] [logging.py:60:log_dist] [Rank -1] DeepSpeed info: version=0.3.10, git-hash=unknown, git-branch=unknown
[2021-02-08 23:00:50,288] [INFO] [distributed.py:40:init_distributed] Initializing torch distributed with backend: nccl
[2021-02-08 23:00:50,701] [INFO] [logging.py:60:log_dist] [Rank -1] DeepSpeed info: version=0.3.10, git-hash=unknown, git-branch=unknown
[2021-02-08 23:00:50,701] [INFO] [distributed.py:40:init_distributed] Initializing torch distributed with backend: nccl
5525f7acde8f:5585:5585 [0] NCCL INFO Bootstrap : Using [0]lo:<IP_ADDRESS><0>
5525f7acde8f:5585:5585 [0] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
5525f7acde8f:5585:5585 [0] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
5525f7acde8f:5585:5585 [0] NCCL INFO NET/Socket : Using [0]lo:<IP_ADDRESS><0>
5525f7acde8f:5585:5585 [0] NCCL INFO Using network Socket
NCCL version 2.7.8+cuda11.0
5525f7acde8f:5586:5586 [1] NCCL INFO Bootstrap : Using [0]lo:<IP_ADDRESS><0>
5525f7acde8f:5586:5586 [1] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
5525f7acde8f:5586:5586 [1] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
5525f7acde8f:5586:5586 [1] NCCL INFO NET/Socket : Using [0]lo:<IP_ADDRESS><0>
5525f7acde8f:5586:5586 [1] NCCL INFO Using network Socket
5525f7acde8f:5585:5638 [0] NCCL INFO Channel 00/02 :    0   1
5525f7acde8f:5585:5638 [0] NCCL INFO Channel 01/02 :    0   1
5525f7acde8f:5585:5638 [0] NCCL INFO threadThresholds 8/8/64 | 16/8/64 | 8/8/64
5525f7acde8f:5585:5638 [0] NCCL INFO Trees [0] 1/-1/-1->0->-1|-1->0->1/-1/-1 [1] 1/-1/-1->0->-1|-1->0->1/-1/-1
5525f7acde8f:5585:5638 [0] NCCL INFO Setting affinity for GPU 0 to 0f,ffffffff
5525f7acde8f:5586:5640 [1] NCCL INFO threadThresholds 8/8/64 | 16/8/64 | 8/8/64
5525f7acde8f:5586:5640 [1] NCCL INFO Trees [0] -1/-1/-1->1->0|0->1->-1/-1/-1 [1] -1/-1/-1->1->0|0->1->-1/-1/-1
5525f7acde8f:5586:5640 [1] NCCL INFO Setting affinity for GPU 1 to 0f,ffffffff
5525f7acde8f:5586:5640 [1] NCCL INFO Could not enable P2P between dev 1(=1a000) and dev 0(=19000)
5525f7acde8f:5585:5638 [0] NCCL INFO Could not enable P2P between dev 0(=19000) and dev 1(=1a000)
5525f7acde8f:5586:5640 [1] NCCL INFO Could not enable P2P between dev 1(=1a000) and dev 0(=19000)
5525f7acde8f:5585:5638 [0] NCCL INFO Could not enable P2P between dev 0(=19000) and dev 1(=1a000)
5525f7acde8f:5586:5640 [1] NCCL INFO Channel 00 : 1[1a000] -> 0[19000] via direct shared memory
5525f7acde8f:5585:5638 [0] NCCL INFO Channel 00 : 0[19000] -> 1[1a000] via direct shared memory
5525f7acde8f:5585:5638 [0] NCCL INFO Could not enable P2P between dev 0(=19000) and dev 1(=1a000)
5525f7acde8f:5586:5640 [1] NCCL INFO Could not enable P2P between dev 1(=1a000) and dev 0(=19000)
5525f7acde8f:5585:5638 [0] NCCL INFO Could not enable P2P between dev 0(=19000) and dev 1(=1a000)
5525f7acde8f:5585:5638 [0] NCCL INFO Channel 01 : 0[19000] -> 1[1a000] via direct shared memory
5525f7acde8f:5586:5640 [1] NCCL INFO Could not enable P2P between dev 1(=1a000) and dev 0(=19000)
5525f7acde8f:5586:5640 [1] NCCL INFO Channel 01 : 1[1a000] -> 0[19000] via direct shared memory
5525f7acde8f:5585:5638 [0] NCCL INFO 2 coll channels, 2 p2p channels, 2 p2p channels per peer
5525f7acde8f:5585:5638 [0] NCCL INFO comm 0x7f8234001060 rank 0 nranks 2 cudaDev 0 busId 19000 - Init COMPLETE
5525f7acde8f:5585:5585 [0] NCCL INFO Launch mode Parallel
5525f7acde8f:5586:5640 [1] NCCL INFO 2 coll channels, 2 p2p channels, 2 p2p channels per peer
5525f7acde8f:5586:5640 [1] NCCL INFO comm 0x7f7688001060 rank 1 nranks 2 cudaDev 1 busId 1a000 - Init COMPLETE
[2021-02-08 23:00:53,589] [INFO] [engine.py:72:_initialize_parameter_parallel_groups] data_parallel_size: 2, parameter_parallel_size: 2
[2021-02-08 23:00:53,592] [INFO] [engine.py:72:_initialize_parameter_parallel_groups] data_parallel_size: 2, parameter_parallel_size: 2

5525f7acde8f:5586:5647 [0] init.cc:573 NCCL WARN Duplicate GPU detected : rank 1 and rank 0 both on CUDA device 19000

5525f7acde8f:5585:5646 [0] init.cc:573 NCCL WARN Duplicate GPU detected : rank 0 and rank 1 both on CUDA device 19000
5525f7acde8f:5586:5647 [0] NCCL INFO init.cc:840 -> 5
5525f7acde8f:5585:5646 [0] NCCL INFO init.cc:840 -> 5
5525f7acde8f:5586:5647 [0] NCCL INFO group.cc:73 -> 5 [Async thread]
5525f7acde8f:5585:5646 [0] NCCL INFO group.cc:73 -> 5 [Async thread]
Traceback (most recent call last):
  File "./trainer.py", line 33, in <module>
Traceback (most recent call last):
  File "./trainer.py", line 33, in <module>
    trainer.train()
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 725, in train
    trainer.train()
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 725, in train
    model, optimizer, lr_scheduler = init_deepspeed(self, num_training_steps=max_steps)
  File "/opt/conda/lib/python3.7/site-packages/transformers/integrations.py", line 384, in init_deepspeed
    model, optimizer, lr_scheduler = init_deepspeed(self, num_training_steps=max_steps)
  File "/opt/conda/lib/python3.7/site-packages/transformers/integrations.py", line 384, in init_deepspeed
    config_params=config,
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/__init__.py", line 119, in initialize
    config_params=config_params)
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 150, in __init__
    config_params=config,
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/__init__.py", line 119, in initialize
    self._configure_distributed_model(model)
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 504, in _configure_distributed_model
    config_params=config_params)
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 150, in __init__
    self._broadcast_model()
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 482, in _broadcast_model
    self._configure_distributed_model(model)
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 504, in _configure_distributed_model
    group=self.data_parallel_group)
  File "/opt/conda/lib/python3.7/site-packages/torch/distributed/distributed_c10d.py", line 864, in broadcast
    self._broadcast_model()
  File "/opt/conda/lib/python3.7/site-packages/deepspeed/runtime/engine.py", line 482, in _broadcast_model
    work = group.broadcast([tensor], opts)
RuntimeError: NCCL error in: /opt/conda/conda-bld/pytorch_1607370156314/work/torch/lib/c10d/ProcessGroupNCCL.cpp:784, invalid usage, NCCL version 2.7.8
    group=self.data_parallel_group)
  File "/opt/conda/lib/python3.7/site-packages/torch/distributed/distributed_c10d.py", line 864, in broadcast
    work = group.broadcast([tensor], opts)
RuntimeError: NCCL error in: /opt/conda/conda-bld/pytorch_1607370156314/work/torch/lib/c10d/ProcessGroupNCCL.cpp:784, invalid usage, NCCL version 2.7.8

Here is the output of my ds_report
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires one of the following commands '['llvm-config', 'llvm-config-9']', but it does not exist!
 [WARNING]  sparse_attn requires the 'cmake' command, but it does not exist!
 [WARNING]  sparse_attn requires CUDA version 10.1+, does not currently support >=11 or <10.1
sparse_attn ............ [NO] ....... [NO]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/lib/python3.7/site-packages/torch']
torch version .................... 1.7.1
torch cuda version ............... 11.0
nvcc version ..................... 11.0
deepspeed install path ........... ['/opt/conda/lib/python3.7/site-packages/deepspeed']
deepspeed info ................... 0.3.10, unknown, unknown
deepspeed wheel compiled w. ...... torch 1.7, cuda 11.0

Hey!  I also ran into this and was able to fix this by installing the pytorch nightly builds. There is also a pre-release for 1.8 which might also work:
# install nightly
conda install pytorch torchvision torchaudio -c pytorch-nightly

# to install 1.8 pre-release
conda install -y -c pytorch-test -c conda-forge pytorch

Ok so for anyone reading this I managed to get it working.
I am using HuggingFace's interface for DeepSpeed so there were multiple things I needed to do.
I installed the pre-release as suggested by @SeanNaren and installed DS from source AND installed the cuda 11.1 toolkit. So my DS report looks like the following:
 --------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires one of the following commands '['llvm-config', 'llvm-config-9']', but it does not exist!
 [WARNING]  sparse_attn requires the 'cmake' command, but it does not exist!
 [WARNING]  sparse_attn requires CUDA version 10.1+, does not currently support >=11 or <10.1
sparse_attn ............ [NO] ....... [NO]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/envs/deepspeed1/lib/python3.8/site-packages/torch']
torch version .................... 1.7.1
torch cuda version ............... 11.0
nvcc version ..................... 11.1
deepspeed install path ........... ['/opt/conda/envs/deepspeed1/lib/python3.8/site-packages/deepspeed']
deepspeed info ................... 0.3.11+6ee3b29, 6ee3b29, master
deepspeed wheel compiled w. ...... torch 1.7, cuda 11.0

I also compiled the latest transformers library from their master branch commit 77b86284 and had to manually change local_rank to 1


Backend : conditionAllow should not be applicable to create operation.

As we have a condition-based rule and currently it's getting applied for all the Operations, but the issue is if we want to evaluate the policies rule against any resource we should have that resource id/fqn but when we are creating any resource having resource id/fqn is not possible.
So we should not have conditionAllow for creating Operation.

@harshach and @Sachin-chaurasiya, a few things are changing with this:
OrganizationPolicy was allowing all operations when the condition isOwner() was met. That is give permission to perform all the operations on all the resources when the authenticated user is the owner of the resource. This meant that, when evaluating permissions, all operations ended up becoming conditionally allowed.
This patch is change it as follows:

The rule for owners is changed from allowing all the operations to allow EditAll, ViewAll, and Delete. The Create operation is removed. Because of this Create operation will no longer be shown as conditional.
EditAll, ViewAll, and Delete will be conditional as it is today. Unless a specific resource and a user are given, they will remain so. When you give a specific resource and a user, Deny, Allow, or Not Allow will be provided in the permissions.


Add is_view or similar "simulate-only" flag for deploy commands

What problem does your feature solve?
When user is about to deploy a contract to main-net, the (estimated) fee for the upload and install is unknown.
What would you like to see?
soroban contract deploy --wasm xx --network xx --is_view (or other named flag) to allow a simulation against the actual network
In the same way soroban contract invoke has the --is_view flag to only simulate a call.
What alternatives are there?
As far as I know, an approximate calculation could be made if the wasm size and network settings are know, but it's non-trivial.

+1 I think we should make the --is-view a command that is present on all commands that submit a tx.
Separate to this I think we should also rename --is-view to --simulate-only, because reading your suggestions above in the title, simulate only is much easier to understand. Is view assumes an EVM/Solidity background and understanding.

This ticket tracks separatingsimulate, sign, and send and provides simulate. I'd like to close this in favor of https://github.com/stellar/soroban-cli/issues/1265

This ticket tracks separatingsimulate, sign, and send and provides simulate. I'd like to close this in favor of #1265

I think this makes sense as one way to go. To be clear the way that you would emulate this behaviour is with the following:
soroban contract deploy ... --build-only | soroban tx simulate

Although @willemneal was also exploring adding a --sim-only option alongside --build-only, which I think is also fine, and is basically what this issue is proposing. If others are okay with that, then we keep this issue, and mark the following pull request as resolving it:

https://github.com/stellar/soroban-cli/pull/1267