Fixing claude v2 in AWS Bedrock

Renamed the provider from claude to bedrock-claude for AWS Bedrock Claude to distinguish between AWS Bedrock Claude and the Anthropic Claude clients.
Resolved the issue where the history display was incorrectly using bedrock-claude.

Hey @drawal1 , #751 is closed. Are you planning to create another pull request for the update?

@xiaochuan-du - yes, I found some issues while testing. I will resubmit today

Hey Kevin,
Here's the new PR after bug fixes - https://github.com/stanfordnlp/dspy/pull/772

From: Kevin Du @.>
Sent: Tuesday, April 2, 2024 4:14 AM
To: stanfordnlp/dspy @.>
Cc: Dhar Rawal @.>; Mention @.>
Subject: Re: [stanfordnlp/dspy] Fixing claude v2 in AWS Bedrock (PR #745)
Hey @drawal1https://github.com/drawal1 , #751https://github.com/stanfordnlp/dspy/pull/751 is closed. Are you planning to create another pull request for the update?
—
Reply to this email directly, view it on GitHubhttps://github.com/stanfordnlp/dspy/pull/745#issuecomment-2031479831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3F2UHFMUX53HNBZ4T3MH2LY3KAJ5AVCNFSM6AAAAABFRDWNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGQ3TSOBTGE.
You are receiving this because you were mentioned.Message ID: @.***>


Implements steady_clock for monotonicity within a process

This adds monotonicity to the timestamp generation function epoch() - limiting the chances of colliding UUIDs within processes. Particularly useful in scenarios where UUID0 is used heavily.

hey @shayanjm . thanks for the PR. those lines are only affecting the unit-tests afaik

My fault! Closing PR!


Added new meta columns to tags table

no-issue
This prepares the database for future work, allowing tags to store metadata

@allouis Will just need a bump from 03- to 04- :slightly_smiling_face:

@daniellockyer I've renamed to 05- because of this: https://github.com/TryGhost/Ghost/pull/12019

Updated again to 04- & will merge after tests pass


add dependencies of gtk-layer-shell to readme

Add missing dependencies of the new gtk-layer-shell to the README.
I have tested the apt install only on Debian testing, not on Ubuntu 19.10

Thanks


archive/zip: need new api to support local file name encoding

The archive/zip can't support gbk filename on chinese windows.
This is a simple test (test-gbk-zip.go):
// only for go1.4

// Go output on Chinese Win7/64bit
// go run test-gbk-zip.go
//
// File name(%s): ����/���¶���.txt
// File name(%q): "\xc0\xee\xb0\xd7/\xd4\xc2\xcf¶\xc0\xd7\xc3.txt"
// File name(%s): �Ÿ�/
// File name(%q): "\xb6Ÿ\xa6/"
//

// 7z output on Chinese Win7/64bit
//
// 7z l -r 中文-测试.zip
//
// 7-Zip [64] 9.25 alpha  Copyright (c) 1999-2011 Igor Pavlov  2011-09-16
//
// Listing archive: 中文-测试.zip
//
// --
// Path = 中文-测试.zip
// Type = zip
// Physical Size = 483
//
//    Date      Time    Attr         Size   Compressed  Name
// ------------------- ----- ------------ ------------  ------------------------
//                     .....          282          228  李白\月下独酌.txt
//                     D....            0            5  杜甫
// ------------------- ----- ------------ ------------  ------------------------
//                                    282          233  1 files, 1 folders

package main

import (
    "archive/zip"
    "fmt"
    "log"
    "os"

    "golang.org/x/text/encoding/simplifiedchinese"
)

type ZipTest struct {
    Name string
    File []ZipTestFile
}

type ZipTestFile struct {
    Name string
    Body string
}

func main() {
    makeGbkTestfile()

    r, err := zip.OpenReader(gbkZipTest.Name)
    if err != nil {
        log.Fatal(err)
    }
    defer r.Close()

    for _, f := range r.File {
        fmt.Printf("File name(%%s): %s\n", f.Name)
        fmt.Printf("File name(%%q): %q\n", f.Name)
    }
}

func makeGbkTestfile() {
    file, err := os.Create(gbkZipTest.Name)
    if err != nil {
        log.Fatal(err)
    }
    defer file.Close()

    wzip := zip.NewWriter(file)
    defer func() {
        if err := wzip.Close(); err != nil {
            log.Fatal(err)
        }
    }()

    for _, file := range gbkZipTest.File {
        localGbkName, _ := utf8ToGBK(file.Name) // 文件名转换为 GBK编码
        f, err := wzip.Create(localGbkName)
        if err != nil {
            log.Fatal(err)
        }
        _, err = f.Write([]byte(file.Body))
        if err != nil {
            log.Fatal(err)
        }
    }
}

func utf8ToGBK(text string) (string, error) {
    dst := make([]byte, len(text)*2)
    tr := simplifiedchinese.GB18030.NewEncoder()
    nDst, _, err := tr.Transform(dst, []byte(text), true)
    if err != nil {
        return text, err
    }
    return string(dst[:nDst]), nil
}

var gbkZipTest = ZipTest{
    Name: "中文-测试.zip",
    File: []ZipTestFile{
        {
            Name: "李白/月下独酌.txt",
            Body: `月下独酌 - 李白

花间一壶酒，独酌无相亲。
举杯邀明月，对影成三人。
月既不解饮，影徒随我身。
暂伴月将影，行乐须及春。
我歌月徘徊，我舞影零乱。
醒时同交欢，醉后各分散。
永结无情游，相期邈云汉。
`,
        },
        {
            Name: "杜甫/",
            Body: "",
        },
    },
}

So i create CL9381 try to fix this poblem.
But CL9381 can only support utf8 encoding,
it can't create local gbk encoding zip.
I think we need new api for user defined filename encoding:
func OpenReaderEx(name string, decoder func(x string)(utf8Name string)) (*ReadCloser, error)
func (w *Writer) CreateEx(name string, encoder func(x string)(localName string)) (io.Writer, error)

If the decoder or encoder is nil, the local encoding is utf8.
The func (w *Writer) Create(name string) (io.Writer, error) force use utf8 encoding.

I think we just need to export the FlagEncodingUtf8
constant and let the user choose what he/she needs.
The (*Writer).Create method could default to UTF-8 if
name is valid utf-8 encoding, but not ASCII.

@minux If a filename is GBK and valid utf8, and i want to use GBK(not utf8),
How to do this?

@chai2010, use CreateHeader directly, and not Create.

@bradfitz If we force use utf8 encoding for valid utf8 gbkFilename (as @minux suggest), CreateHeader will set the flag bit11,
and will call
if err := writeHeader(w.cw, fh); err != nil {
    return nil, err
}

we can't clear flag's bit11 before writeHeader(w.cw, fh).
But the filename is gbk, NOT utf8string(though utf8.ValidString test is true).
The user need local encoding, not utf8.

I didn't suggest CreateHeader to change fh.Flags.
Only Create will set fh.Flags to a sane default based
on the name.
If you use CreateHeader method, then you need to
set the Flags field by yourselves.

@minux I agree with you. Only Create will set fh.Flag.

What's the status of this issue?
At least we should document the bit11 - I've had to read through the APPNOTE.TXT of the ZIP spec to find out how t ostore UTF-8 names in the zip file.
The best (IMHO) would be to document & make Create set that bit, as in Go, every valid string is UTF-8, if one wants something else, should use CreateHeader.

The fact that many zip writers use local character encoding is a hack since the specification only seems to support two different encodings: CP-437 or UTF-8.
CL/39570 (exposed in Go1.9) changed it such that the UTF-8 flag was set automatically if the string looked like valid UTF-8, but it seems that the check was too liberal.
It seems to me that the thing that can be practically done here is to provide the user with a way to ensure bit 11 (which controls UTF-8) is cleared. The automatic detection scheme adding in Go1.9 is problematic, so we can either revert it for Go1.10 or explicitly add API to control clearing it.
If we revert CL/39570, users were always able to set UTF8 by manually setting bit 11 on FileHeader.Flags. To assist with that, we can document it and/or export a constant for it.
\cc @mattn

When set utf-8 string in filename, it works fine.
package main

import (
	"archive/zip"
	"io"
	"log"
	"os"
)

func init() {
	f, err := os.Create("sample.txt")
	if err != nil {
		panic(err)
	}
	f.Write([]byte("hello world"))
	f.Close()
}

func main() {
	zf, err := os.Create("sample.zip")
	if err != nil {
		log.Fatal(err)
	}
	defer zf.Close()

	zw := zip.NewWriter(zf)
	defer zw.Close()

	info, err := os.Stat("sample.txt")
	if err != nil {
		log.Fatal(err)
	}

	hdr, err := zip.FileInfoHeader(info)
	if err != nil {
		log.Fatal(err)
	}

	hdr.Name = "サンプル.txt"
	zh, err := zw.CreateHeader(hdr)
	if err != nil {
		log.Fatal(err)
	}

	f, err := os.Open("sample.txt")
	if err != nil {
		log.Fatal(err)
	}
	io.Copy(zh, f)
}

Windows command line.

Linux

Also Windows explorer.

Sorry, I don't know how this works on OSX.
When set non-utf-8 multi-byte string, user should handle himself.
sample.zip
This zip archive contain filename in Shift_JIS. Windows explorer (japanese environment) works well. But zip command line doesn't since the archive doesn't have encoding name. You must convert filename manually.
package main

import (
	"archive/zip"
	"io"
	"log"
	"os"

	"golang.org/x/text/encoding/japanese"
)

func main() {
	zr, err := zip.OpenReader("sample.zip")
	if err != nil {
		log.Fatal(err)
	}
	defer zr.Close()

	name, err := japanese.ShiftJIS.NewDecoder().String(zr.File[0].Name)
	if err != nil {
		log.Fatal(err)
	}
	f, err := os.Create(name)
	if err != nil {
		log.Fatal(err)
	}
	defer f.Close()

	r, err := zr.File[0].Open()
	if err != nil {
		log.Fatal(err)
	}
	io.Copy(f, r)
}

hi!
How you made this sample.zip?
As i mentioned in #22367, i cant use local encoding like ShiftJIS with Go 1.9.
Sorry about that my issue post was unclear.
If i call zip.CreateHeader with local encoding, Any non ascii characters is recognized as valid utf8 in hasValidUTF8 function.
package main

import (
  "fmt"
  "log"
  "unicode/utf8"

  "golang.org/x/text/encoding/japanese"
  "golang.org/x/text/transform"
)

func main() {
  name, _, err := transform.String(japanese.ShiftJIS.NewEncoder(), "日本語")
  if err != nil {
    log.Fatal(err)
  }

  for _, s := range name {
    b := utf8.ValidRune(s)
    fmt.Printf("%x = %v\n", s, b)
  }
}

output is
fffd = true
fffd = true
fffd = true
7b = true
fffd = true
fffd = true

So zip.CreateHeader set bit 11 and results corrupted zip file.
(file name is encoded ShiftJIS but utf-8 flag is on)
And Windows7 without optional hotfix can't handle utf-8 encoded zip.

I created it with 7-zip.
I'm thinking it is not neccesary that Go can create zip file with non-utf-8. It's enough that Go can read/write utf-8 file and read non-utf-8 filename as bytes.

I can agree. I think using utf-8 encoding with bit 11 is a standard way.
Please don't revert CL/39570.
but Go 1.8 had a way to handle custom encoding.
so add simple api to clear bit 11 is also welcome.

Or one another idea. Add new field into ZipHeader like below.
NameEncoder  func(string) (string error)
NameDecoder  func(string) (string error)

This translate filename and comments in zip file. NameEncoder can be set japanese.ShiftJIS.NewEncoder().String. And NameDecoder can be set japanese.ShiftJIS.NewDecoder().String. @khiro, @dsnet  How do you think?

little mistake. Reader.File can not provide way to do it. So only NameEncoder for Writer can be useful.

:+1: for CL/72410
Thanks for taking time for this.
This is better way than provide api to edit utf8 bit manually.

I post one another CL. Which do you like?

CL/72410
There is no possibility to set wrong flag. easy to use.
But only for writing. if i want read same zip, i need to manually decode string.
CL/72430
Less modification.
I think most people are fine with utf-8 encoding.
I just needed local encoding for compatibility to old windows os and this is special case.
so CL/72430 is more acceptable for anyone?


Duplicate pledge gives error when the FSP or charities are active and inactive

The Donation History is needed to Duplicate the Pledge. Chances are that the charities and FSP might not be active anymore. So, when the Duplicate Pledge button is clicked, the user gets a pop-up message saying that the charity or FSP is not active anymore. And when continue is clicked, user must be navigated to the First step of the donations flow.

Root cause: Issue caused by the recent change on the BI summary data, the summary transaction is now storing region code instead of region name, need to update this program to use 'region code'.
Resolution: For BI summary data, in model class, use regioin code instead of region name for lookup Region instance.

looks like it is when I checked yours pull request.
What's your change, is related to the same ticket "Duplicate pledge gives error when the FSP or charities are active and inactive" ?

looks like it is when I checked yours pull request.
What's your change, is related to the same ticket "Duplicate pledge gives error when the FSP or charities are active and inactive" ?

Its a different issue that uses the same method

Thank you Paul for the code review and approve


Endpoint for Events for the new API

Hello, I would like to see an endpoint for the events that occur in AC:NH in the new API. I am not sure if it is planned or not, but would love to know if it is in the to-do list!
As well as making a new AC:NH events endpoint for the new API, I would like to request if it is possible for invalid dates to return an invalid date error. For example on the old API, giving a date of September 31st would return the events on October 1. Giving an invalid date (like March 32nd) would return December 31st on a Wednesday.
Another request for the endpoint on the new API would be the ability to look up all the events that happen on a certain month, which would allow us to see seasonal events as well as villager birthdays that are happening during the month given.

Adding to the discussion, some potential ideas for this API:

Query parameters

month: similar format to ones that are already provided 01, 1, "jan", "january"
day: integer, 01 to 31
year: integer, 2000 to 2050, or until when is desired

Treat invalid month, day, and year combinations as illegal, which is easily doable

game: accept only one from "DNM" "AC", "E_PLUS", "WW", "CF", "NL", or "NH"
hemisphere: optional param, defaults to "north", useful for NH data where the Bug-Off is dependent on

Returns

birthday: an array of objects detailing whose birthday it is
events: an array of objects detailing the events on that particular day

birthday is already implemented similarly in /villagers, but events, such as New Year's, the Bug-Off, etc. have yet to be stored in any Cargo table, and storing them may be another question. There are events that fall on specific dates e.g., New Year's, on a specific weekday e.g., the Fishing Tourneys, or using a lookup table e.g., Festivale....

Honestly, the biggest thing that needs to happen for this is a cargo table to exist for events.


Add Molecular Interaction Fields

This updates @dfhahn's code for molecular interaction fields from #318 and gets it working again.

@greglandrum I am about half-way through my review. I'll submit a PR to your branch once I am done.

Thanks for the initial work on this @dfhahn !


Resend verification email to nonexistent user doesn't fail

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
When sending an email to a user that used to exist, but doesn't anymore, I got a false positive. I'd expect the following to fail when the user isn't valid / doesn't exist:
await supabase.auth.resend({ email, type: 'signup' })

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

await supabase.auth.resend({ email, type: 'signup' }) with a valid email for an invalid user
No error

Expected behavior
An error should be thrown
System information
"@supabase/ssr": "^0.5.2"
Additional context
Really minor issue. I see in the docs:
This method will only resend an email or phone OTP to the user if there was an initial signup, email change or phone change request being made.

But still, an error would make sense here.

Thanks for the report, this is a deliberate design decision so that you may not use the endpoint to determine if users are registered with the site or not.


Make any remaining changes to colonoscopy white paper XML.

Attached is the white paper @linophth had sent out on January 19th, 2019, as approved by VA SMEs.
20180525REVISED-CDSK_CCWP_B1B20B21B22B23B24B25B26B27B42B63Colos_final_508_copyright_KBS_APPROVED_LLW.JAD edits.docx

@Fcuello Would it be possible to get these edits today?

@preston done, there were only a couple of edits.

Sent over to @ssebast2 today.


SyntaxError: invalid escape sequence '\w'

Hello! I'm getting the following error
from pytestarch.diagram_extension.diagram_parser import PumlParser
E     File "/usr/local/lib/python3.11/site-packages/pytestarch/diagram_extension/diagram_parser.py", line 28
E       ANY_ARROW_TEXT = "(-?|\w+-)"  # noqa: W605
E                        ^^^^^^^^^^^
E   SyntaxError: invalid escape sequence '\w'

I use

Python: 3.11.9
pytestarch: 3.0.0

As I understand noqa: W605 disabled warning about that situation but now Python reports it as a syntax error.
Why not use that regex str like this "(-?|\\w+-)" or like this r"(-?|\w+-)"?

Hi!
Thanks for bringing this to my attention! I don't quite recall why I opted to suppress the warning, but this clearly needs to be fixed.
If you want to provide the patch, I would be very happy to merge it. :) Otherwise, I'm going to fix it over the weekend.

I've released the fix as version 3.0.1. Let me know if you're still experiencing issues - if not, I would close the ticket :)
Thank you very much for contributing the fix!


Add brotli.version

brotlipy 0.7.0 has no brotli.version; brotli-python does. It would help applications / interactive use of Python to have it.

Could you submit a PR with this change?

This is now available in brotlicffi v0.8.0

thanks! Sorry for not being able to help more directly.

@jason-sachs No problem! Thank you for your patience :)


chore: spell fix for issue template

fixes spelling  for "scratch"

@Samyak2 currently I feel those template sections are useful, as user can delete those if not required, but we can do updates if required maybe later. cc : @manassolanki


Trying to find an open source project, specifically Front-end development

Description
A brief description of the question or issue:
You can also join the discord community here
Feel free to check out other cool repositories of EddieJoaude Community here

Have an Idea let me know!

What technologies do you use?
We are a few frontend projects starting up if you want to join in:

Map project (display where people on the live stream are) https://github.com/EddieJaoudeCommunity/EddieBotMap
Website (we have not started yet, probably be html, css, tailwind for now)
EddieBot UI (not much movement on this at the moment)

On the website we will list these and their technologies so it is clearer for people. You join at an interesting time, because it is so early on, you can help shape the community with us 🤓

Hey,
The technologies I use are HTML / CSS and javascript but am still learning
to great and comfortable with them as well as React
I would really want to be a part of this BTW,
I can definitely contribute on the website side, but for the rest, I need
to learn typescript to be able to discord project with you guys.
It is gonna take me some time but it's worth it.
On Thu, Aug 20, 2020 at 12:07 AM Eddie Jaoude<EMAIL_ADDRESS>wrote:

What technologies do you use?
We are a few frontend projects starting up if you want to join in:

Map project (display where people on the live stream are)
https://github.com/EddieJaoudeCommunity/EddieBotMap
Website (we have not started yet, probably be html, css, tailwind
for now)
EddieBot UI (not much movement on this at the moment)

On the website we will list these and their technologies so it is clearer
for people. You join at an interesting time, because it is so early on, you
can help shape the community with us 🤓
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EddieJaoudeCommunity/support/issues/76#issuecomment-676703750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANQDQDCHCJ7SUBCQBRJNFITSBQ5JXANCNFSM4QFAIYBA
.

We are all still learning so dont worry, it is part of the fun 🤓 - we will all figure it out together 💪

@JoelAngels I think this ticket has been resolved as this community already has some pretty funky stuff.
Definitely brush up on TailwindCSS for a framework as you are "actually using CSS properties" even when you use a utility framework.
Closing issue 💯

@JoelAngels  Since this ticket was created, we have started work on the community website. Like @stemount says it is tailwind focused for now https://github.com/EddieJaoudeCommunity/EddieJaoudeCommunity.github.io


[DNM] Test PR for Swift-DocC custom aside titles (5.7)

The PR this was testing has already been merged, closing...


Add Socks5 authentication

If we want to expose this to internet we will need authentication but right now it doesn't provides any but this PR should fix that.

Thanks! This should address one of the problem in #8.


Titan World (Unofficial Attack on Titan RPG)

Hi,
I know quite a few games of this are ran on roll20, but there isn't a sheet built in. This is an unofficial Attack on Titan RPG that's pretty basic - location of rule book etc is provided in the instructions in the JSON (it's fan made so it's not a pirated rulebook).
This is my fist ever time using github and submitting a sheet, so apologies if I've ballsed something up.
Flash

Thanks. When do these go live on roll20? Sorry, first time doing this and have a game waiting on the change.

@Lloydski246 Should live in a few hours (in general, around 24 hours after the merge)

@NathaTerrien Awesome, thanks.


Pass options through to redirect_to

Use case: allow setting a flash message when using redirect_back_or with a SignInGuard to require email confirmation (based on https://thoughtbot.com/blog/email-confirmation-with-clearance):
class UsersController < Clearance::UsersController
  def create
    @user = user_from_params
    @user.email_confirmation_token = Clearance::Token.new

    if @user.save
      UserMailer.confirm_email(@user).deliver_later
      redirect_back_or url_after_create, notice: t("flashes.confirmation_pending")
#                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    else
      render template: "users/new"
    end
  end
end

This implementation Works On My Machine™ but after reading how redirect_to is implemented I'm still kind of not sure how this works so it's probably naïve, fragile, dangerous or all three.
This allows me to show a flash message like "Sign up request received. Please check your email."
Apologies if there's a better way of achieving this.

Done in #968


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Coverage increased (+1.7%) to 85.711% when pulling 1d4b7996276436b1adee6d0c816fc379708538a8 on template-sync-1 into 07ed5135c800b8bd4ba481ef5e3ced2ae2bc4b0e on master.


watcher: small ring buffer of latest status

DEBUG_STATUS only handles characters and doesn't have any history.
This request is for a small (32?) entry ring buffer where kernels can log what they are up to and have that dumped by the watcher.
The buffer would involve no handshake, ie, the device can just write in a loop w/o a handshake to the host.
Ideally, there would be 1 buffer shared by all 5 riscvs and would be safe to write w/ atomics.  Not sure if that is feasible w/ current hw (may need 5x32 buffers...which may not be worth it).

Implemented with https://github.com/tenstorrent-metal/tt-metal/pull/6652, only caveat is that we don't have atomics and don't have access to noc semaphores from triscs. So ring buffer access from multiple riscs on the same core results in undefined behaviour. Re-visit this in later when we have atomics support


chore: many backward compatibility flags are no longer needed

The majority of the backward compatibility flags, introduced during the move to v4.8.0-rc1, are no longer needed. 🎉

!bench

bors merge


Update service bus to enable live testing in sovereign clouds for multiple services

These changes enable service bus to run live tests against Public, UsGov and China.

Update file: sdk/servicebus/service-bus/test/internal/serviceBusClient.spec.ts
Update to match endpoint on UsGov and China cloud.

Update file: sdk/servicebus/service-bus/test/public/atomManagement.spec.ts
Update to match host on UsGov and China cloud.

Update file: sdk/servicebus/service-bus/tests.yml
Update to enable service bus to run live tests against UsGov and China.

Pipeline results:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1167878&view=results

Service bus has a new issue to resolve and close the PR to wait the issue has been resolved


[SPARK-42285][DOC] Update Parquet data source doc on the timestamp_ntz inference option

What changes were proposed in this pull request?

This is a follow-up of https://github.com/apache/spark/pull/39856. The configuration changes should be reflected in the Parquet data source doc
Why are the changes needed?

To fix doc
Does this PR introduce any user-facing change?

No
How was this patch tested?

Preview:

Was this patch authored or co-authored using generative AI tooling?

No

BTW, did you upload the screenshot? The link seems to be broken, @gengliangwang .

@dongjoon-hyun Yes, the screenshot is just updated.

Merging to master/branch-3.5. @dongjoon-hyun Thanks for the review.


Bookstore: connect to API

Bookstore: connect to API
In this milestone I was able to implement the following requirement :
Make use of the Bookstore API as my backend
Use fetch  with  createAsyncThunk to make API calls
Fetch my books from Bookstore API when the component has rendered with useEffect
Refactor my add book and remove book features to persist my changes in the serve

Thank you.


include VCR to VLMEvalKit

Hi, the pull request is ready for merging, we've done all the tests and the current version passed the pre-commit tests.

Thanks for your work. We will help review and merge it.


Fix Thread.join sig to reflect nil-ability

The return value of Thread.join was incorrectly specified as always being a Thread, but if limit is specifed, then the join operation may time-out and the return value will be nil. This can cause errors in code which correctly handles the nilable return value. See: https://github.com/sorbet/sorbet/issues/3499
I've used sig overloading (which I believe is allowed for stdlib types?) to reflect the behaviour of the std library (and minimise the number of incorrect type errors which will result from this change).
I've also typed the limit parameter as numeric (since it must be a number of seconds).
Motivation
https://github.com/sorbet/sorbet/issues/3499
Test plan
TODO: If reviewers are happy with this solution, then I'll add some tests based on the example in the issue.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IDp9jH5aCv7PF9


Upgrade testing system

This moves the Turnt-based pipeline tests to a new Python-based testing system. The explication-only tests (currently, the scheduling folder) are unaffected.
I started working on this for a pretty dumb reason: the Turnt scripts (for pipeline tests, not explication) use Posix utilities like cat which prevents them from running in the normal Windows shell. The new version indeed works in the Windows shell but it has a bunch of other benefits too.
The testing script has three modes:

clean, which is what it sounds like
run, which is build + cargo test
build

The build mode recursively searches for all .cair and .ron files in the test directory and runs caimanc on them. If they successfully compile, the generated code is emitted to src as a Rust module. If a Rust file exists in the same directory as the source file with the same filename, the generated code include!(...)s that Rust file. For example, caiman-test/basics/external_test.cair gets compiled to src/external_test.rs which contains include!("../basics/external_test.rs"). A major advantage this is that if the problem lies in Rust code, you can just edit the original Rust code and run cargo test without having to rerun the test script.
All of the generated files are then "linked" into one Rust library, which you can then build and test with cargo test. This takes advantage of Cargo's nice testing infrastructure and output. Keeping everything in one library also makes the tests run faster since we can reuse the same WGPU instance. Also, rust-analyzer is able to understand the crate structure, which helps diagnose error/warnings/suggestions.
Instead of storing output in a separate file, you just directly check it in the testing code. Most tests use crate::expect_returned! to do this, which is conceptually the same as assert_eq! except it returns a Result instead of panicking (a panic would poison the WGPU mutex).

Hmm, I appreciate the sentiment (I am on Windows as well, and had to do a lot of fiddling to make it work on my machine without bonking Linux; I relied on cygwin though).  The main problems I have with switching, however, are twofold:

We end up recreating a lot of the benefits (and problems with) turnt.  This means that we end up having to add whatever is needed that Turnt already has (the most obvious being parallel testing), and end up with kind of a light-weight test suite that awkwardly in-between super-minimal tests and building a proper unit test library suite
We also lose any benefits of being in any ecosystem

The upsides, to be fair, seem to me to be that

We get control over caiman testing directly, and don't have to worry about Turnt breaking independently for some reason
The tests can be more customized for the caiman environment, which has pros and cons I suppose in terms of design

In short, I'm fine with it, but I'm not fully sold that we want to have a completely custom, but still light-weight test set.

To be clear the actual pipeline tests run via Cargo, so I wouldn't really say it's a custom testing system. The Python script is just an adapter that compiles all the Caiman inputs first and then sticks them in the proper folder, which is what the shell scripts inside the Turnt configs were doing anyway. As far as ecosystem goes... we're ultimately testing (generated) Rust code, and Cargo unit tests are the most popular way to do that.
I don't think we need Turnt's power for the pipeline tests. IMO the main value of the pipeline tests is making sure that we didn't break Caiman's functionality, and Cargo tests are more ergonomic for that since they're deeply integrated into Rust. (Cargo actually supports parallel testing but we don't take advantage of that right now.)

I buy it, seems good to me then.  I admit, this is what I was tempted to do initially, and I do like having more control of course.  I'll download and fiddle with the branch when I get back from ASPLOS myself to make sure it works and will integrate well, but conceptually gets a thumbs up from me!


msgpackrpc.error.TimeoutError : Request timed out

msgpackrpc.error.TimeoutError : Request timed out

Here is my issue.. I cannot find a solution searching for google..
The version of msgpack, airsim is same with requirements_gpu.txt

Hi, have you solved this problem? I have the same problem. Can you please tell me how to solve it?

I also kept getting this error after one success. I then resolved it by updating the AirSim IP address.


Fix linting errors

Currently flake8 is run every time a commit is made and it finds quite a few issues with the code. It would be good to fix the issues and when this is done make linting errors fail the tests, so we can keep the quality of the code in check more easily in the future.

#100 solved most of the linting issues. There are currently still 10 left. When these are resolved, it would be possible to make the tests fail if there is a linting issue.


Use Cargo's JSON diagnostics for suggestions

Fix #688 .
Uses JSON message format to communicate with cargo when building and running. This allows suggestions to be prompted correctly.
Example
Currently

New output

Possible TO-DOs

[ ] Any mode other than "building" and "running" is still using human-readable mode since I'm not sure how are they different from the normal cargo output.
[ ] cargo_metadata crate has been used. Not clear if the library can work with different cargo versions, or we need to do some kind of versioning. As far as I tested it works for all three variants at least for now.
[ ] No multi-line diagnostics have been tested. I wasn't able to find or think of any fixes with more than one line.
[ ] The standard error output's timeline is not correct. Currently, all cargo's output is located at the bottom of the standard error output, regardless of the time arrangement between outputs. Related cargo comment
[ ] Better prompt. Maybe discard the "rendered_message" and render the diagnostics message ourselves? This way we can have suggestions in message clickable, instead of having a list of suggestions under the message, which might be confusing.

Should we leave the cargo message in stdout instead of moving it to stderr? This way the timeline will not be disrupted.

I just wanted to swing by to let you know that I've seen this PR, but I'm not sure when I'll have time to give it the review focus it deserves. I'm super excited about this change, however!
Random thoughts that may or may not be useful or even relevant (as I haven't even looked at the implementation)...
We'll want to (as best we can!) preserve the structure of the API response/requests. e.g. we might want to add a new structured field for the compiler response, instead of repurposing the existing fields. Sadly, people use the existing APIs and assume they will be stable, even though almost no one has ever asked. 😢

Maybe discard the "rendered_message" and render the diagnostics message ourselves? This way we can have suggestions in message clickable, instead of having a list of suggestions under the message, which might be confusing.

Yeah, I think this is the ultimate end goal. Obviously it's more of a PITA, but would allow removing the custom regex-based error / warning formatting as well. Maybe this would also allow splitting out Cargo's output from the programs stderr/stdout as well.

Not clear if [cargo_metadata] can work with different cargo versions

I'd expect that as long as we are using the v1 of the output (our whatever is the current version) that it should be compatible.

We'll want to (as best we can!) preserve the structure of the API response/requests

So should we preserve (at least to our best) the stdout and stderr field in the JSON response for URL /execute? If that's the case, then we might need to add a new field to the response (like actions):

Current response example
{
  "success": false,
  "stdout": "",
  "stderr": "   Compiling playground v0.0.1 (/playground)\nerror[E0433]: failed to resolve: use of undeclared type `HashMap`\n --> src/main.rs:3:13\n  |\n3 |     let a = HashMap::new();\n  |             ^^^^^^^ not found in this scope\n  |\nhelp: consider importing one of these items\n  |\n1 | use hashbrown::HashMap;\n  |\n1 | use std::collections::HashMap;\n  |\n\nFor more information about this error, try `rustc --explain E0433`.\nerror: could not compile `playground` due to previous error\n"
}

Proposed response example
{
  "success": false,
  "stdout": "",
  "stderr": "   Compiling playground v0.0.1 (/playground)\nerror[E0433]: failed to resolve: use of undeclared type `HashMap`\n --> src/main.rs:3:13\n  |\n3 |     let a = HashMap::new();\n  |             ^^^^^^^ not found in this scope\n  |\nhelp: consider importing one of these items\n  |\n1 | use hashbrown::HashMap;\n  |\n1 | use std::collections::HashMap;\n  |\n\nFor more information about this error, try `rustc --explain E0433`.\nerror: could not compile `playground` due to previous error\n",
  "actions": [
    {
      "link": {
        "startline": 9,
        "endline": 9,
        "startcol": 4,
        "endcol": 27,
        "target": "stderr"
      },
      "solution": {
        "startline": 1,
        "endline": 1,
        "startcol": 1,
        "endcol": 1,
        "replacement": "use hashbrown::HashMap;"
      }
    },
    {
      "link": {
        "startline": 9,
        "endline": 9,
        "startcol": 4,
        "endcol": 34,
        "target": "stderr"
      },
      "solution": {
        "startline": 1,
        "endline": 1,
        "startcol": 1,
        "endcol": 1,
        "replacement": "use std::collections::HashMap;"
      }
    }
  ]
}

It's definitely going to be more complex than the implementation this PR proposed (especially for front-end). An advantage for such response is that we might be able to remove almost all regex (not only the "import" one) since highlighting and error location (currently handled here) can be extracted directly from Cargo JSON output and passed to front-end using the new field in HTTP JSON response.

I've been poking around and writing custom diagnostic renderer for the last few days and it's way more complicated than I expected. In order to not break existing API, we basically need to port this so that it can not only output formatted message but also "actions" linked to part of the message. A port would be at least 1000+ lines and include some dirty hacks (because we are getting cargo's metadata instead of rustc's one, so we need to parse it back again). Therefore, I'm think continue to use pre-rendered output and do some matching would be a better idea, like this (pseudo-code)
fn add_suggestion_actions(pre_rendered: &str, diagnostic: cargo_metadata::diagnostic::Diagnostic, actions: &mut Vec<Action>) {
    if let Some(position) = pre_rendered.find(diagnostic.suggested_replacement) {
        actions.push(Action(position, ActionType::Replacement(diagnostic.suggested_replacement)));
    }
}
fn add_filejump_actions(pre_rendered: &str, diagnostic: cargo_metadata::diagnostic::Diagnostic, actions: &mut Vec<Actions>) {
    let file_loc = format!("{}:{}:{}", diagnostic.file_name, diagnostic.line_start, diagnostic.column_start);
    if let Some(position) = pre_rendered.find(file_loc) {
        actions.push(Action(position, ActionType::Jumpto(diagnostic.line_start, diagnostic.column_start)));
    }
}


Purpur doesn't send Ender Dragon position to the client.

Spark link
https://spark.lucko.me/7Xiaif6BSX
Expected behavior
Ender Dragon position is sent to client.
Observed/Actual behavior
Ender Dragon position is not sent to client.
Steps/models to reproduce
Go to the end or summon an Ender Dragon.
Purpur version
Current: git-Purpur-1685 (MC: 1.19)*
Previous: git-Purpur-1670 (MC: 1.19)

You are running the latest version

Agreements

[X] I am running the latest version of Purpur available from https://purpurmc.org/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
Video of me showing the bug and visual location (Client Location) doesn't match /tp location (Server location) on a server with no plugins.
PurpurEnderDragonFail.mp4.zip

I am unable to reproduce this.

I reproduce this on a local server with no plugins, nothing.
I just downloaded latest Purpur 30 seconds ago.

@Encode42 I was able to reproduce that on Pufferfish, I will report to them.


[WIP][Relay][Frontend] Chainer frontend introduced

Chainer frontend is added among other Relay frontends.
Note: This is just a skeleton now. And it is under active development.
Please do not refer for review.
Once it is ready for review, will update and include respective reviewers.
However, if anyone has any specific requirement from chainer framework, please feel free to post here. Will sure take it up.

You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reasons:

Chainer is now in maintenance mode
We already have ONNX and PyTorch frontend. Existing Chainer users are being encouraged to switch to PyTorch, so they can use either frontend

I agree that given the current support of chainer, perhaps we should not introduce this frontend.

@tqchen, @masahi: Thanks for your feedback. However I couldn't not agree completely on the reasonings shared by masahi.
Please find my response accordingly.
I know the current support of ONNX, but is that not the case for many of the frontends already supported now?
Also if the CI slowness is the worry, then we should come up with a solution for that. We should not restrict to fewer frontends.
As I see, the numerous user of chainer framework will get benefitted by this frontends, even though they are encouraged to switch to other framework.
As the concern raised for development and maintenance, definitely I will take care of that through constant effort. Also one point, the maintenance effort is proportional to no of active user(as the requirement also increases with that).
My opinion is this frontend will attract more user towards TVM. Thanks!

@ANSHUMAN87 feel free to send an RFC to the discuss forum to get more feedbacks

See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch backend. Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or  "attracting more users" or

I agree some points of @ANSHUMAN87 .  TVM is so attractive, I think one reason is we are very open and happy to provide stage for them . However, given current status of chainer, we are more willing to discuss more detail about it in RFC. Like whether we should introduce it into TVM, how to support it better and so on.

@tqchen , @masahi , @FrozenGene : I am really thankful for your responses. I will definitely raise RFC very soon(mostly within 2 days) for this feature and obtain all your expert opinions. TIA!
NOTE: Because of working timezone differences. You might see my response little delayed. However i will ensure my best effort to respond all your posts as early as possible. Please bear with me for that.

RFC raised.

@tqchen : This PR is now ready with one complete model VGG16 importing from Chainer. Same test case is also added.
But when i check the CI report, it fails because of missing Chainer package. Can you please help me on resolving this issue? TIA!


Loading progress bar

Some very significant speedups are currently being pushed out, that'll result in reports loading in a handful of seconds. However since load times are strongly correlated with bounce rate, an aesthetically pleasing progress bar with potentially relevant information (such as filenames that are being loaded) could help retain the user whilst the report is loading.

I think Shyal sped up load time enough that this is pretty low priority now, assigning P3 accordingly


Add namespace to list resources error message

Add the namespace in the error message of clustersmngr.Client.ClusteredList (https://github.com/weaveworks/weave-gitops/blob/main/core/clustersmngr/client.go#L122)  to make clear what calls are being made, otherwise, the errors look repeated.

Believe we've improved the response here, please re-open if still a requirement.


JSON-RPC version in JsonRequest class

JsonRequest class has no JSON-RPC version, can somebody explain why? Is there any particular reason?

If there was, I've forgotten by now. Might be able to drum up a reason, but it might not be a good reason. :)


[flutter_markdown] RangeError with a particular Markdown input

What package does this bug report belong to?
flutter_markdown
What target platforms are you seeing this bug on?

Yes
Dependency versions
flutter_markdown version 0.7.3+1
Steps to reproduce
Go to the example in the repository and use the following markdown input in one of the markdown inputs
![Image](
<>
![Image](
<>

Expected results
No crash
Actual results
Crashes
Code sample
Code sample
Example app in the package repository

Screenshots or Videos
No response
Logs
Logs
[+1862 ms] ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
                    The following RangeError was thrown building MinimalMarkdownDemo:
                    RangeError (length): Invalid value: Not in inclusive range 0..24: 25

                    The relevant error-causing widget was:
                      MinimalMarkdownDemo
                      MinimalMarkdownDemo:file:///home/david/data_ssd/Dev/Flutter/flutter_packages/packages/flutter_markdown/example/lib/screens/home_screen.dart:26:11

                    When the exception was thrown, this was the stack:
                    #0      _StringBase.codeUnitAt (dart:core-patch/string_patch.dart)
                    #1      InlineParser.charAt (package:markdown/src/inline_parser.dart:324:35)
                    #2      LinkSyntax._parseInlineBracketedLink (package:markdown/src/inline_syntaxes/link_syntax.dart:305:25)
                    #3      LinkSyntax._parseInlineLink (package:markdown/src/inline_syntaxes/link_syntax.dart:263:14)
                    #4      LinkSyntax.close (package:markdown/src/inline_syntaxes/link_syntax.dart:63:26)
                    #5      InlineParser._linkOrImage (package:markdown/src/inline_parser.dart:150:32)
                    #6      InlineParser.parse (package:markdown/src/inline_parser.dart:106:9)
                    #7      Document.parseInline (package:markdown/src/document.dart:94:67)
                    #8      Document._parseInlineContent (package:markdown/src/document.dart:100:29)
                    #9      Document._parseInlineContent (package:markdown/src/document.dart:105:9)
                    #10     Document.parseLineList (package:markdown/src/document.dart:88:5)
                    #11     Document.parseLines (package:markdown/src/document.dart:80:7)
                    #12     _MarkdownWidgetState._parseMarkdown (package:flutter_markdown/src/widget.dart:384:45)
                    #13     _MarkdownWidgetState.didChangeDependencies (package:flutter_markdown/src/widget.dart:348:5)
                    #14     StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:5636:11)
                    #15     ComponentElement.mount (package:flutter/src/widgets/framework.dart:5463:5)
                    ...     Normal element mounting (71 frames)
                    #86     Element.inflateWidget (package:flutter/src/widgets/framework.dart:4340:16)
                    #87     Element.updateChild (package:flutter/src/widgets/framework.dart:3849:18)
                    #88     SliverMultiBoxAdaptorElement.updateChild (package:flutter/src/widgets/sliver.dart:860:37)
                    #89     SliverMultiBoxAdaptorElement.createChild.<anonymous closure> (package:flutter/src/widgets/sliver.dart:845:20)
                    #90     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2845:19)
                    #91     SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:837:12)
                    #92     RenderSliverMultiBoxAdaptor._createOrObtainChild.<anonymous closure> (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:360:23)
                    #93     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:2688:59)
                    #94     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:1097:15)
                    #95     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:2688:14)
                    #96     RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:349:5)
                    #97     RenderSliverMultiBoxAdaptor.addInitialChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:435:5)
                    #98     RenderSliverFixedExtentBoxAdaptor.performLayout (package:flutter/src/rendering/sliver_fixed_extent_list.dart:315:12)
                    #99     RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #100    RenderSliverEdgeInsetsPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:121:12)
                    #101    _RenderSliverFractionalPadding.performLayout (package:flutter/src/widgets/sliver_fill.dart:158:11)
                    #102    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #103    RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:601:13)
                    #104    RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1516:12)
                    #105    RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1427:20)
                    #106    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #107    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #108    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #109    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #110    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #111    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #112    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #113    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #114    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #115    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #116    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #117    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #118    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #119    MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:173:12)
                    #120    _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:1097:7)
                    #121    MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:237:7)
                    #122    RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:404:14)
                    #123    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #124    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #125    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #126    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #127    _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1426:11)
                    #128    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #129    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #130    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #131    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #132    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #133    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #134    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #135    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #136    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #137    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #138    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #139    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #140    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #141    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #142    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #143    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #144    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #145    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #146    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #147    RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3710:14)
                    #148    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #149    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105:21)
                    #150    RenderObject.layout (package:flutter/src/rendering/object.dart:2577:7)
                    #151    _RenderTheaterMixin.layoutChild (package:flutter/src/widgets/overlay.dart:974:13)
                    #152    _RenderTheater.performLayout (package:flutter/src/widgets/overlay.dart:1288:9)
                    #153    RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:2416:7)
                    #154    PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1051:18)
                    #155    PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1064:15)
                    #156    RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:577:23)
                    #157    WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:1138:13)
                    #158    RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:443:5)
                    #159    SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1392:15)
                    #160    SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1313:9)
                    #161    SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1171:5)
                    #162    _invoke (dart:ui/hooks.dart:312:13)
                    #163    PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:419:5)
                    #164    _drawFrame (dart:ui/hooks.dart:283:31)

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.1, on Fedora Linux 39 (Workstation Edition) 6.10.8-100.fc39.x86_64, locale en_US.UTF-8)
    • Flutter version 3.24.1 on channel stable at /home/david/.puro/envs/3.24.1/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5874a72aa4 (3 weeks ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2

Thanks for the report. I was able to replicate this on latest versions.
Stable : 3.24.2
Master: 3.26.0-1.0.pre.72

 runnable code

import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:markdown/markdown.dart' as md;

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
          child: MarkdownBody(
              data:
              '![Image](<>![Image](<>',
           //   selectable: true
          )
      ),
    );
  }
}

class B2BlockSyntax extends md.BlockSyntax {
  static const String _pattern = r'^\[\[warning\]\](.*)$';
  @override
  RegExp get pattern => RegExp(_pattern);

  B2BlockSyntax();

  @override
  md.Node parse(md.BlockParser parser) {
    var childLines = parseChildLines(parser);

    var content = childLines.join('\n');

    final md.Element el = md.Element('p', [
      md.Element('warning', [md.Text(content)]),
    ]);

    return el;
  }

}

class WarningBuilder extends MarkdownElementBuilder {
  @override
  Widget visitElementAfter(md.Element element, TextStyle? preferredStyle) {
    return Builder(builder: (context) {

      return Container(
        width: double.infinity,
        margin: const EdgeInsets.symmetric(vertical: 15),
        padding: EdgeInsets.all(10),
        decoration: BoxDecoration(
          color: Colors.white,
          border: Border(left: BorderSide(color: Colors.red, width: 2)),
        ),
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            Padding(
              padding: EdgeInsets.only(bottom: 10),
              child: const Text('Warning !', style: TextStyle(fontWeight: FontWeight.bold)),
            ),
            Text(element.textContent, style: preferredStyle),
          ],
        ),
      );
    });
  }
}

I fixed this in markdown with PR https://github.com/dart-lang/markdown/pull/624.


Changing sapply for vapply in makeDistanceMatrix()

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   97.73%   97.73%
=======================================
  Files           8        8
  Lines         353      353
=======================================
  Hits          345      345
  Misses          8        8

Impacted Files
Coverage Δ

R/calculateSimilarity.R
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb10483...e6dd442. Read the comment docs.


feat: IonicConfig properties per mode

Feature Request
Enable to set IonicConfig properties in IonicModule import per mode 'ios' and 'md'. This used to be available in Ionic 3 but not anymore since Ionic 4. Makes it hard to set different branded backButtonIcon per platform.
Ionic version:

[x] 5.2.1
Describe the Feature Request

Enable to set IonicConfig properties per platform like in Ionic 3.
Describe Preferred Solution

Like it was available in Ionic 3 (https://ionicframework.com/docs/v3/api/config/Config/)
Related Code

This example of IonicConfig sets the backButtonIcon on both platforms, i would like to set a different default icon per platform.
IonicModule.forRoot({
    backButtonText: '',
    backButtonIcon: 'assets/icon/arrow_left.svg',
    swipeBackEnabled: true
})

Ok, i just found that isPlatform is a thing https://ionicframework.com/docs/angular/config#per-platform-config


Refactoring

A few more styling tweaks. Looks far-reaching, but really not so much.

LGTM, but there's a merge conflict?

Thanks for cleaning this stuff up.

@ggreer Sure thing! I'm thinking of hacking on the code a bit—step one is to tidy up the workshop. ;)

@ggreer I added one little commit (6482c5627b7df24dc383acf1d03fdc8a61d19c4e) to master that didn't make it before you merged. Hope that's cool.

Yep, that's fine.


Support uploading files to cloudflare

get presigned upload url from server
upload files to cloudflare (event: 'start' | 'progress' | 'success' | 'error')
save uploaded url to database

Providers/Adapters

default GridFS
Cloudflare

external interface

uploadFile(file: File, callback(event))
uploadFileWithPreview internally call uploadFile but with extra preview (compressed) image uploaded

deprecated


Read and Identity Enums

Enums are allowed as a query parameter - it would be great if it could read this and identify the possible routes based on this.
Moreover, generally identifying the data type of the route param would be great.
For example; for uuids:
/users/{record} => record: string
For autonumber ids:
/users/{record} => record: integer
Where model is an enum, record is string:
/{model}/{record} => model: enum [users, projects, tasks, quotes]
Probably displayed as a table, such as:
Query Params:

Field    | Type   | Data
===================================
model    | enum   | users, projects, tasks, quotes
-----------------------------------
record   | string |
-----------------------------------

Could add

Hmm I tried but this can't be added


How to use BP_GO_WORK_USE

Summary
Companion docs PR for https://github.com/paketo-buildpacks/go-build/pull/537
Use Cases

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

The only other thing the spell checker is worked up about is the word "workspaces" (not sure why) this can be fixed by adding it here https://github.com/paketo-buildpacks/paketo-website/blob/main/scripts/.util/spellcheck-dictionary.txt. If you would be willing to do that I would appreciate that!

The only other thing the spell checker is worked up about is the word "workspaces" (not sure why) this can be fixed by adding it here https://github.com/mamachanko/paketo-website/blob/topic/mamachanko/main/bp_go_work_use/scripts/.util/spellcheck-dictionary.txt. If you would be willing to do that I would appreciate that!

It's done!


Added CoPresent icon from google material design

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots

[x] Testing

[x] Changes have been manually tested

What are the relevant tickets?
Close #510
What's this PR do?
Adds CoPresent icon for course features.
How should this be manually tested?
Verify proper icon shows up in learning resource type
Any background context you want to provide?
The CoPresent Icon was not available in out current icon library so I had top import the google material design font icon library and used the icon from it.
Screenshots (if appropriate)

Looks good from a user perspective!


Link prefetch causes locale to be switched without user interaction

Description
Context:

Following docs for app router with server components
Not using static generation

Mandatory reproduction URL (CodeSandbox or GitHub repository)
https://github.com/philefstat/next-intl-bug-template-app-forked-
Reproduction description

Clone reproduction & npm install
Important - since prefetch only is enabled in production, run npm run build && npm run start rather than dev
Page loads with english (should say "welcome"). If you reload without scrolling, it stays english.
Scroll to the bottom of the page where there are two links, one to /en, one to /fr. Do NOT click the links.
Refresh the page - the locale has now switched to fr (page should say "bienvenue") despite the links not having been clicked

Optional

Set prefetch={false} on the french link and try the steps above again - the locale does NOT switch now

Expected behaviour
Locale should not switch when there are links to a different locale but the user hasn't clicked them.
Perhaps it's simply a matter of updating the docs to indicate that links in a different locale should have prefetch={false}, but ideally the middleware would detect that it's a prefetch and not set the cookie in this case (I don't know if this is possible or not).

The issue happens because you're using next/link instead of next-intl/link (which sets prefetch accordingly).
Hope this helps!

@amannn 🤦 thanks!


Maintain min height of data table on load/pagination

Also review flash (with scrollbar) on FF.

Obsolete.


Restructure documentation for request package - fixes #178

This is an almost complete rewrite of the section about request processing as outlined in this ticket: https://github.com/finagle/finch/issues/178.
This is probably difficult to review based on the diff, you can alternatively read the rendered version.

Coverage remained the same at 91.05% when pulling 72f1a4b9afa314798b7e68860a294c55fb4b8f8c on Sphonic:request-docs into 8e42d7e36700951b268d96527e2801fb13b574ad on finagle:master.

Coverage remained the same at 91.05% when pulling 86cdb9b6536c4e93f1d1b2b423c12d5b1497575e on Sphonic:request-docs into 8e42d7e36700951b268d96527e2801fb13b574ad on finagle:master.

Coverage remained the same at 91.05% when pulling 86cdb9b6536c4e93f1d1b2b423c12d5b1497575e on Sphonic:request-docs into 8e42d7e36700951b268d96527e2801fb13b574ad on finagle:master.

This is amazing! Thanks a lot @jenshalm for this hard work! I will merge this once you're happy with the state of this PR.

I switched to use built-in rules in the two example you commented. I also added a small section mentioning these built-in rules. The only downside is that our examples for custom rules now still mostly show logic you can do with built-in rules. I did not have a quick idea how to rewrite the samples with something not supported out of the box without making it very contrived. So in my view this is good to be merged now and we can rethink those samples later.

Coverage remained the same at 91.05% when pulling f01bd318cb7bc11138cb7ff6c9ed61a955cc6d2e on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Coverage remained the same at 91.05% when pulling f01bd318cb7bc11138cb7ff6c9ed61a955cc6d2e on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Coverage remained the same at 91.05% when pulling f01bd318cb7bc11138cb7ff6c9ed61a955cc6d2e on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Coverage remained the same at 91.05% when pulling 3a2aeac3db5f56aa084216ff6664db8596b23b2c on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Coverage remained the same at 91.05% when pulling 3a2aeac3db5f56aa084216ff6664db8596b23b2c on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Coverage remained the same at 91.05% when pulling 3a2aeac3db5f56aa084216ff6664db8596b23b2c on Sphonic:request-docs into 69329da01e12918360a59e3514cfc9905dd960b3 on finagle:master.

Super cool! I'm merging this.


Radicale: update to v2, fixing and enabling test

Motivation for this change
It has been long overdue for a radicale update, this PR does that. I also modified the test to work, it seemed to be disabled for not working.
ToDoDone: Backwards-compatibility
The 2.x releases of radicale are NOT backwards compatible. There should be two derivations for radicale1 and radicale2, while radicale = radicale2. To not mess with previously working radicale setups, there should be a package option for the radicale module, defaulting to radicale1 if systemVersion <= 17.03 and radicale2 otherwise. Users can then manually upgrade to 2.x by setting package = radicale2, adjusting the config and following the official guide for migration. This should be added to the release notes.
Edit: This has been done
Things done
I have been running this version for a few days now and haven't run into any problems.

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Pinging @aneeshusa @edwtjo and @pSub as they are in the maintainers list.

Thanks!


Typescript typings incorrect casing

Casing for functions oneof, nonShrink are wrong, they should be oneof, nonshrink. This makes these functions unusable from Typescript, ending up in TypeError: jsc.oneOf is not a function errors

Hello! I will be making this PR. 😃


Support the Mistral AI official huggingface weights for Mixtral-8x7B-v0.1

per the current example:

Download the models from HuggingFace:
git clone https://huggingface.co/someone13574/mixtral-8x7b-32kseqlen

I'd really rather not have to re-download many GBs of weight files, and less-so from someone13574 (no offense) when there weights are posted by Mistral AI itself: https://huggingface.co/mistralai/Mixtral-8x7B-Instruct-v0.1
would this work already? could the example be updated to use these weights?

Yea it's a good point. Will look into updating the example to use the official weights instead of the ones from MixtralKit

One major issue how to run it with 64 GB memory ? This is a huge model, we need to think of reducing the precision. Is it also possible to think of delta in the weights between the chat (instruction version Mixtral-8x7B-Instruct-v0.1) and the navite generator (mixtral-8x7b-32kseqlen). But I don't see an easy way so far to run on M1 64 GB.  running the convert give me a terminal killed message
(tf) tgg@gvalmu00008 mixtral % python convert.py --model_path mixtral-8x7b-32kseqlen/
zsh: killed     python convert.py --model_path mixtral-8x7b-32kseqlen/

I'm able to get the someone13574 running.
I attempted the cat/convert process on the official instruct model, but no dice.
Is there a way to modify the convert script to get the instruct version going?

This one right? https://huggingface.co/mistralai/Mixtral-8x7B-Instruct-v0.1
I'll test it after getting the official Mistral one working

That's the one.

#107


Error while exporting to CloudFormation template for CUDOS dashboard

I use the StartAssetBundleExportJob API (https://awscli.amazonaws.com/v2/documentation/api/latest/reference/quicksight/start-asset-bundle-export-job.html) to create the CloudFormation template from a QuickSight Dashboard.  The Job fails with an error
"The dashboard has associated errors and cannot be exported. Call DescribeDashboardDefinition to retrieve the errors. (Service: null; Status Code: 0; Error Code: null; Request ID: null; Proxy: null)"
When using the DescribeDashboardDefinition API on the dashboard, I get error such as,
"Errors": [
        {
            "Type": "FILTER_SOURCE_PARAMETER_NOT_FOUND",
            "Message": "The filter is using a parameter that has been deleted. Choose a new parameter and save changes.",
            "ViolatedEntities": [
                {
                    "Path": "filter-group/bd3276ea-9c57-4eeb-aa77-e35c3a1da239/filter/7d4a6fe9-3027-4d65-8693-89d664fc6e73"
                }
            ]
        },
        {
            "Type": "DATA_SET_NOT_FOUND",
            "Message": "The DataSet that used in the calculated field can not be found in the analysis",
            "ViolatedEntities": [
                {
                    "Path": "calculated-field/Savings %"
                }
            ]
        },
        {
            "Type": "DATA_SET_NOT_FOUND",
            "Message": "The DataSet that used in the calculated field can not be found in the analysis",
            "ViolatedEntities": [
                {
                    "Path": "calculated-field/Cost"
                }
            ]
        },
        {
            "Type": "DATA_SET_NOT_FOUND",
            "Message": "The DataSet that used in the calculated field can not be found in the analysis",
            "ViolatedEntities": [
                {
                    "Path": "calculated-field/RI_SP Savings"
                }
            ]
        }

Please create a support case. This is not an issue with dashboards but the way how QS exports. This is why we are not yet moving to bundle API.

Has a support case been raised and if so is there anywhere it can be tracked?

Yes. The support case is in progress.


storage: add storage component

What have you changed?
Add a new component which allows TiKV save and load data to external storage. This PR also add the local storage which saves files to local disks.
For now, the storage is dead code, it's preparation for the upcoming backup feature.
What is the type of the changes?

New feature (a change which adds functionality)

How is the PR tested?
Unit tests.
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.

/run-unit-test

/run-unit-test


CONFIG_SPIRAM_IGNORE_NOTFOUND does not work on ESP32-PICO-V3 (but works on ESP32-PICO-D4) (IDFGH-14168)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v4.4.6, v5.4.0-beta1
Espressif SoC revision.
ESP32-PICO-V3
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
ESP-PICO-KIT-1
Power Supply used.
USB
What is the expected behavior?
When using CONFIG_SPIRAM_IGNORE_NOTFOUND=y the app should be able to boot without PSRAM. This works correctly on ESP32-PICO-D4 (no PSRAM) for example:
I (5643) boot: Loaded app from partition at offset 0x20000
I (5643) boot: Disabling RNG early entropy source...
I (5653) quad_psram: This chip is ESP32-PICO
E (5654) quad_psram: PSRAM ID read error: 0xffffffff, PSRAM chip not found or not supported
E (5658) esp_psram: PSRAM enabled but initialization failed. Bailing out.
I (5665) cpu_start: Failed to init external RAM; continuing without it.
... app boot continues normally

What is the actual behavior?
When this option is enabled on ESP32-PICO-V3 (no PSRAM) the app boot fails and ESP reboots:
I (607) boot: Loaded app from partition at offset 0x20000
I (623) boot: Set actual ota_seq=1 in otadata[0]
I (623) boot: Disabling RNG early entropy source...
E (632) quad_psram: This chip is ESP32-PICO-V3. It does not support PSRAM (disable it in Kconfig)
abort() was called at PC 0x40086a9c on core 0
Backtrace: ....
...
Rebooting...

Steps to reproduce.
Using following options in sdkconfig file:
CONFIG_SPIRAM=y
CONFIG_SPIRAM_BOOT_INIT=y
CONFIG_SPIRAM_IGNORE_NOTFOUND=y

Debug Logs.
No response
More Information.
ESP32-PICO-V3-02 works correctly as it does have PSRAM.

@mmrein have reproduced your issue, the fix will be updated here soon~

Thank you for quick solve!
I've successfully tested the fix on v4.4.6 too, just the line and file in question is this one, in case someone else needs it: https://github.com/espressif/esp-idf/blob/357290093430e41e7e3338227a61ef5162f2deed/components/esp_hw_support/port/esp32/spiram_psram.c#L839
Change to return ESP_FAIL;


Unable to deploy stock-notification branch localhost. Heap Issues.

Unable to deploy branch feature/notification-preferences_my-interests_stock-notification in localhost.
Upon start-up, I'm getting Javascript out of heap memory errors.
Regarding #5123

Hi Giancarlo, thanks for your report. could you please write down the detailed info to help us reproduce the error?

what's your OS?
what's your JDK/Angular/SPA/.... version
what's your local environment
what's your steps to see the error

reproducing the error is the first step to resolve the issue.
because CI has passed, it seems that it is related with your local environment, we must know your environment clearly.
Thanks
Kate

answers via slack

Already merged.


Remove Katacoda source files from docs repo

Follow-up to https://github.com/cockroachdb/katacoda/pull/1,
which moved the files to a new repo specific for Katacoda
content.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/05b9ad0bec3b1d2114a1a994b50cc59f79df1823/


No longer set GOPATH

brew install go (above) will always install golang 1.8+, and the
default behavior starting with that version is as this code was setting.

I think this change must have already have happened in this repo. Safe to close PR?


Jails doesn't seem to complain when the config json is incorrect

I messed up and added a trailing comma in my jails.json file, and it took a while to figure out why jails won't respect the configuration, because I haven't seen anything in the logs about config not being valid. Seems like the server just silently applies the defaults if something goes wrong. Maybe a log entry about failing to parse the config file would be useful for situations like this.

I also had a fair bit of confusion trying to configure it correctly. It seems like VS code shows the default under Workspace settings, even when you click reset and it's supposed to be inheriting the path from User settings. Idk if this is a VS Code bug or what.. but eventually it started working. I think you also have to restart the extension every time you update the config for it to take effect, that seemed to help me.

Yeah, restarting the extension a couple times and looking at debug output indicates when it gets the new settings.


[upstream PR #773]: Fix some compile problems on weird/old compilers.

Generated this PR automatically by looking at the list of merged PRs upstream and creating new PRs (from the same commit) here.

@apoelstra What's the plan here? Is this just a test for your scripts? Or should we review this?

@real-or-random both. If we can merge this I can do a series of these PRs, until we hit a merge conflict, then we can decide on a process for how to deal with that.
My proposal here is that we start continuously merging PRs from upstream into libsecp-zkp, rather than rebasing (and rather than doing the subtree-based schemed that @jonasnick has been experimenting with).


[enhancement]: details on The New Approach To CLI ?

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
I'm a bit sad that the old CLI was retired, but I'm glad to hear there's a new one in the form of invokeai-node-cli.  I haven't been able to find any documentation on how to use it though.  The old CLI documentation was quite good so it would be great to have something similar for The New One.
Alternatives
No response
Aditional Content
No response

I asked about this in the discord Q&A they just did. The invokeai-node-cli is more of a way to build node pipelines form the cli, not really a way to do image generation like the old cli. They have a plan to bring back batch file generation eventually, but it's lower priority unless enough people speak up asking for it.
My input on what I would like to see based on my use; I primarily run Invoke on a remote colab like server, so it's easier to run it in a non interactive mode, so I want to be able to download a model from a url (or at least be able to convert a downloaded model for the command line), and run a batch of prompts. I don't need an interactive prompt like the old cli. I'd also likely be able to adapt to being able to launch just the back end and hit the API, if that API is stable enough to be documented.
I'd also be keen to see a way of building a node pipeline in the web ui on my local computer, then exporting that to a file which could be imported on the remote machine where I can run faster generations.

Thumb up for batch file generation. Something like deprecated !replay

Read prompts from a file would be great for batch processing.

The official statement is:

...The original "invokeai" command-line interface has been retired. The invokeai command will now launch a new command-line client that can be used by developers to create and test nodes. It is not intended to be used for routine image generation or manipulation.

It was a bit confusing to fire up InvokeAI and realize that you couldn't do batch processing from the command line anymore. That was such a convenient tool! I really hope that it'll be brought back. So from what I understand, the only true/easy way to image generation hereon after is through the browser interface?

I really want to use the new version and explore with SDXL, but I actually used more the CLI than the UI when I was using InvokeAI. Hope the InvokeAI team bring that feature back, I'll keep the old version as far as I can :/

Yeah CLI and batches is the only way I can find to use multiple GPUs at once. It'd be nice to get back, even in a very basic form.

Literally the only reason I was even interested in InvokeAI was for the CLI, a feature that was missing from every other Stable Diffusion solution. I can't begin to express my utter disappointment that it's seemingly being left by the wayside. I very, very much hope it makes a return. Until it does, I simply cannot upgrade to 3.0.

If they do add CLI again, they should make it more of an API where you call the InvokeAI server through some kind of REST service so that it can be optimized by retaining the selected model like the UI frontend does now with the backend. This will make generation of images not spend time having to re-load the model which I see is a common problem with CLI type AI implementations.

Sorry folks. A CLI is a bit too much to manage for us now and has been totally removed.
Indeed, if we were to support a CLI in the future, it would be a probably be lightweight REST client as suggested by @64jcl .
Closing this as we have no CLI to document now.


XF86 Keys Support

Hi, sir! I really love your works, i'm using Wmderland for now.
But, it's not support for Xf86 like

XF86MonBrightnessUp
XF86MonBrightnessDown

When i try to set my keybinds like this
bindsym XF86MonBrightnessUp exec xbacklight -inc 5
bindsym XF86MonBrightnessDown exec xbacklight -dec 5

Wmderland won't start.
Heres the pictures

Hi there
Thanks for reporting! But I've been busy with several semester projects, so I'm not able to solve this immediately. I'll take a good look at the source code of xbindkeys after this semester, for the time being maybe you could use xbindkeys as a replacement?
$ cat ~/.xbindkeysrc
--- trimmed ---
"light -A 10"
    XF86MonBrightnessUp
"light -U 10"
    XF86MonBrightnessDown
--- trimmed ---

Hello there,
Full support for XF86 keys has been added since 2c1c63f.
If you are updating from an old version, please make sure to change:
bindsym $Mod+h focus_left -> bindsym $Mod+h navigate_left
bindsym $Mod+l focus_right -> bindsym $Mod+l navigate_right
bindsym $Mod+j focus_down -> bindsym $Mod+j navigate_down
bindsym $Mod+k focus_up -> bindsym $Mod+k navigate_up
Sorry for breaking the backward compatibility.

These are the keybinds that I've tested which works well:
bindsym XF86MonBrightnessUp exec light -A 10
bindsym XF86MonBrightnessDown exec light -U 10
bindsym XF86KbdBrightnessUp exec kbdlight up 10
bindsym XF86KbdBrightnessDown exec kbdlight down 10
bindsym XF86LaunchA exec rofi -show window
bindsym XF86LaunchB exec rofi -show drun
bindsym XF86AudioPrev exec mpc prev
bindsym XF86AudioNext exec mpc next
bindsym XF86AudioPlay exec mpc toggle
bindsym XF86AudioMute exec amixer -q -D pulse set Master toggle
bindsym XF86AudioRaiseVolume exec amixer -q -D pulse set Master 5%+ unmute
bindsym XF86AudioLowerVolume exec amixer -q -D pulse set Master 5%- unmute
bindsym XF86PowerOff exec qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout -1 -1 -1

bindsym Control+Shift+3 exec scrotutl -f
bindsym Control+Shift+4 exec scrotutl -s
bindsym Control+Shift+space+4 exec

If you are still using Wmderland, please clone the latest version from master branch. Also, it is now very stable since multiple bugs have been fixed. Thanks!


Add circuit breaking error handling to ReactiveSeq

Dedicated operators to switch on error and handle errors
* onErrorSwitch(Function<? super Throwable,? extends Publisher<T>> fn)
* onErrorSwitch(Publisher<T> pub)

* onError(Consumer<? super Throwable> consumer)

* onErrorSwitch(Publisher<T> pub)

Should be called
* recoverWith(Supplier<Publisher<T>> pub)

For consistency with other Operators in cyclops.
An onErrorBreak operator is required (at least internally to force circuit breaking behaviour).

Released in 10.3.0


add optional chaining in response to sentry logs

Time to time there are errors in sentry:
Cannot read properties of null (reading 'getItem')

The storage parameter is required and can't be null as it must implement the interface StorageInterface

StorageInterface interface declaration
/**
 * Storage interface
 */
export interface StorageInterface<T> {
  /**
   * Get a value from the storage.
   *
   * If the value doesn't exist in the storage, `null` should be returned.
   * This method MUST be synchronous.
   * @param key The key/name of the value to retrieve
   */
  getValue(key: string): T | null

  /**
   * Save a value in the storage.
   * @param key The key/name of the value to save
   * @param value The value to save
   */
  setValue(key: string, value: T): void

  /**
   * Remove a value from the storage
   * @param key The key/name of the value to remove
   */
  deleteValue(key: string): void
}

To add the optional chaining to make code works, indicate that the compiler didn't do its job and allowed an invalid value.
Furthermore, the storage can't be defined later, so the nothing will ever be persisted in this case

If you need to conditionally set a storage, and need a "fallback" storage, you can use the createNoopStorage function (it will create a storage that don't persist anything)
(The createNoopStorage is used when the requested storage is not available, like trying to use a localStorage on a Node.js server)

I was using library within createLocalStorage, but because it's missing in some environments we got crashes in sentry.

The issue seem to be here instead.
The createLocalStorage should fallback in noopStorage if the localStorage is not available: https://github.com/MacFJA/svelte-persistent-store/blob/main/src/core.ts#L267
Do you have more details about the environment that create the crashes ?

It was safari mobile, I think it was private session in it. It seems that before latest releases localStorage was or absent, or with 0 size available.
https://www.reddit.com/r/javascript/comments/2z06aq/local_storage_is_not_supported_with_safari_in/

Like this https://developer.mozilla.org/en-US/docs/Web/API/StorageManager/estimate returning 0 for local storage.


Adding auth_header option to inject a jwt bearer authentication header

I get it. this is nice idea. Unfortunately code you PR is not very practical or so to say flexible. It only use Bearer type. But there are others. Would it be nice to be able to extend not only headers but anything?
I think we have to add beforeSend  callback. And there any user will be able to add any header or even parameters.
What do you think?
Could change auth_header option to before_events_request and make it a callback? Also add something to readme file so people could know about that.

You're right, I think it's a better and more flexible way to implement a callback in order to define any possible header. I'm quite new to the contribution mechanism of github so l have produced a code that fits to my particular situation, absolutely not flexible indeed.
I'll modify the code accordingly to your suggestions as soon as possible.

All you need to do is to apply changes to master and push it to your fork on gitHub. those changes will appear here automatically. You do not need to do another PR.

Ok!

Nice!


Deadlock in simulation for same config

Not sure if deadlock is the correct terminology here, but at the reshuffling stage, for 1 in 20 runs for the same config, the simulation lags forever. Below are the logs for two succeeding runs and two failing runs for the following config:
{
    "FoodOnPlatform": 100,
    "Team1Agents": 1,
    "Team2Agents": 1,
    "Team3Agents": 1,
    "Team4Agents": 1,
    "Team5Agents": 1,
    "Team6Agents": 1,
    "RandomAgents": 2,
    "AgentHP": 100,
    "AgentsPerFloor": 1,
    "TicksPerFloor": 10,
    "SimDays": 8,
    "ReshuffleDays": 1,
    "maxHP": 100,
    "weakLevel": 10,
    "width": 45,
    "tau": 10,
    "hpReqCToW": 2,
    "hpCritical": 5,
    "maxDayCritical": 3,
    "HPLossBase": 10,
    "HPLossSlope": 0.25
}

Succeeding logs:
good.zip
Failing logs:
bad.zip

Not a deadlock, I think it's an infinite loop in the shuffle function.
I suspect it's this line:
		for remainingVacancies[newFloor] == 0 || newFloor == agent.BaseAgent().floor {


Is there a way to get all running or active workers?

I want to get all running workers and the status(busy/idle) of them at a certain time. How could I get such information? Is there any API for that? Thanks.

Conductor does not store any information about the number of running workers. The only information that is available is the poll data for a given task which is last polled by who and last polled when.


fix DECL_ASSIGN_LINE raised on constants

Hi, I think the issue #17 has been closed by error with this one #12.
So, just a little fix for #17.

Sorry for all this mess. Next time I'll use another branch than master.
Didn't knew Github keep track of push force, even if there only 1 ahead between both branch.

All good :)
Thanks for the PRs


[SPARK-33908][CORE][FOLLOWUP] Correct Scaladoc of resolveDependencyPaths/resolveMavenDependencies

What changes were proposed in this pull request?
Fix un-correct doc of last change https://github.com/apache/spark/pull/30922#discussion_r551453193
Why are the changes needed?
FIx doc
Does this PR introduce any user-facing change?
No
How was this patch tested?
Builds finished correctly.

FYI @xkrogen @maropu

FYI @xkrogen @maropu

Pending GA.

Pending GA.


Set up your Kanban board

https://github.com/ArthurGC/Api-webapp-capstone-project/projects/1
Team:

Ricardo Rodriguez R.
Arthur Guzman

Hello Team,
Good job so far! However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

All cards have to be assigned to all team members this means we shall be able to see under each card an avatar of the students who were assigned to that specific card
Cards should be assigned to team members in a fair way

Cheers and Happy coding!👏👏👏
Feel free to leave a question, or a comment on the PR thread if something is not clear 100%.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team, well done. You have made the requested changes and your project is complete. You can proceed to the next milestone. :clap: :dancers:


Switch CI to GitHub Actions (#338)

Codecov Report

Merging #363 (9b29765) into develop (e6c99cd) will increase coverage by 0.79%.
The diff coverage is n/a.

:exclamation: Current head 9b29765 differs from pull request most recent head 332b2f2. Consider uploading reports for the commit 332b2f2 to get more accurate results

@@             Coverage Diff              @@
##           develop      #363      +/-   ##
============================================
+ Coverage    99.20%   100.00%   +0.79%
============================================
  Files          101         5      -96
  Lines         4626        77    -4549
  Branches         7         6       -1
============================================
- Hits          4589        77    -4512
+ Misses          37         0      -37


Prepare for release 5.0.0-alpha02

Signed-off-by: Matt Ramotar<EMAIL_ADDRESS>Please see our contributing guidelines (contributing.md) primarily make sure to sign our cla as we cannot accept code externally without a signed cla
https://opensource.dropbox.com/cla/

Codecov Report

Merging #484 (3f296f3) into store5 (3f296f3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3f296f3 differs from pull request most recent head 8f4e1e4.


Single idp callback for old and new implementation

At the moment I do have two different idp callback urls, depending on the login ui I use (go hosted login, or session api).
To be able to easily change between the different logins without the need of additional documentation and confusion, we want to allow one idp callback for all implementations
Acceptance Critiera

[ ] Existing idp callbacks is able to handle old and new implementation
(/login/externalidp/callback)

I really hope you guys update in conjunction with this issue, when I build a UI with session API, I only wanna show the public login domain, not the private zitadel domain. The devops team would never open only 1 router for idps callback URL.
https://github.com/zitadel/zitadel/issues/8032


Mix of positive and negative values in Barchart?

Does Vico support a mix of positive and negative integer values in a Barchart? I tried a simple bar chart with a mix of positive and negative y-axis values and the resulting bar chart was strange. Before I try any further, wanted to confirm if this is indeed a supported usecase?

Hello @parrotcar00,
Unfortunately, it’s not supported yet, but it’s a feature we will implement soon.

While I was trying to figure out how to best create a chart to display a collection of positive and negative values, I came across this chart:

Seems to me if positive and negative values come into play in a bar chart, then horizontal bar charts become easier to read?
Just sharing some food for thought.
Thanks for your work!

This is a different type of column chart that we didn’t plan to implement yet.
Our goal is to achieve something like below.

I only shared it as something I thought about, maybe good as a future enhancement idea?
Your above solution absolutely works :)

Hello! Vico 1.5.1 is now available, and it introduces the improvement in question.


[HIGH] Front-Running Vulnerability in AnonAadhaarVerifier.sol

Author
VictoryGod
Summary
This vulnerability allows malevolent entities to manipulate the order of transactions to their benefit. The functions verifyProof in AnonAadhaarVerifier.sol and verify in Vote.sol, are the root of this issue, as they expose on-chain the values used for verification. This exposure allows an attacker to observe these values in the transaction pool, or mempool, before they are added to the blockchain. The attacker can then use this information to manipulate the transaction order and falsely authenticate themselves.
Proof of Concept
Lines of Code:
https://github.com/anon-aadhaar-private/anon-aadhaar-example/blob/0ebb2ee1a4916d7f1106c22633823eff4c76d7ab/contracts/contracts/AnonAadhaarVerifier.sol#L40C4-L45C34
https://github.com/anon-aadhaar-private/anon-aadhaar-example/blob/0ebb2ee1a4916d7f1106c22633823eff4c76d7ab/contracts/contracts/Vote.sol#L35C4-L37C6
When these functions are called by a user with their unique values, the transaction is sent to the mempool. Before it's included in a block, an attacker can observe this transaction. The attacker can then create their own transaction calling the same functions with the same values, but with a higher gas price to incentivize miners to include their transaction in the blockchain first. If successful, the attacker's transaction is confirmed first, leading the contract to recognize the attacker as the one who provided the unique values, instead of the original user.
Impact
The impact of this vulnerability is significant, especially for projects that rely on the AnonAadhaarVerifier API for user identity verification. An attacker could impersonate a genuine user and gain unauthorized access to services. This undermines the integrity of the verification process and can lead to unauthorized access to sensitive user data, potential financial losses, and reputational damage.
Attack Scenario

A banking application uses the AnonAadhaarVerifier API for real-time verification of customers' identities.
Alice submits a verification request which calls the verifyProof function with her unique Aadhaar values.
This request goes into the mempool, where Bob observes it.
Bob submits his own verification request that calls verifyProof with the same values, setting a higher gas price to incentivize miners to include his transaction in the blockchain first.
If successful, Bob's transaction gets confirmed first, allowing him to authenticate himself falsely as Alice.

Recommendation
To mitigate this issue, projects could design their verification process such that they don't reveal critical information.

Hey @V1C70RYG0D
This issue has been resolved since v1.0.0 release.
Using the new signal mechanism you can ask your user to commit to his ETH address while generating the proof and then check in your smart contract logic that the committed address and the sender's address match.
This example here
Thanks again for reporting this,
I'm going to close this issue as resolved


[MI200][NCHW][SWDEV-312112] Fixed WorkspaceSize for ConvAsmImplicitGemmGTCDynamic*XdlopsNHWC in find-db (leftover of 1324)

Resolves #1349
Added 3 * 255 bytes to workspace to the following solvers workspace size in fdb where it was non-zero:

ConvAsmImplicitGemmGTCDynamicBwdXdlopsNHWC
ConvAsmImplicitGemmGTCDynamicFwdXdlopsNHWC
ConvAsmImplicitGemmGTCDynamicWrwXdlopsNHWC

This can be merged after run #3 is passed.