Alternative algorithm (from Twitter)

Hi @mattrothenberg, as mentioned on Twitter, I started out with this lib as a foundation, but went with a different algorithm, this is how my version currently looks in case you want to borrow any of the approach. It's not a drop-in replacement, as i've stripped out some functionality I wasn't using, and there's some coupling to MUI, but may still be useful:
import {
  useState,
  useRef,
  useLayoutEffect,
  ReactNode,
  ComponentProps,
} from 'react';
import useEffectEventShim from '../hooks/useEffectEvent';

import { useResizeDetector } from 'react-resize-detector';
import { Stack } from '@mui/material';

/**
 * Returns a function that will schedule a layout effect to run on the next
 * render.
 */
function useScheduleLayoutEffect() {
  const [s, ss] = useState<object>();
  const fns = useRef(new Map<string | number, () => void>());

  useLayoutEffect(() => {
    const fnCopy = Array.from(fns.current.values());
    fns.current = new Map();
    fnCopy.forEach((f) => f());
  }, [s]);

  return (id: string | number, cb: () => void) => {
    fns.current.set(id, cb);
    ss({});
  };
}

export interface OverflowListProps<T> extends ComponentProps<typeof Stack> {
  items: Array<T>;
  itemRenderer: (item: T, numShown: number, index: number) => ReactNode;
  overflowRenderer: (args: {
    items: Array<T>;
    overflownItems: Array<T>;
  }) => ReactNode;
  minVisibleItems?: number;
  alwaysRenderOverflow?: boolean;
}

export default function OverflowList<T>({
  items,
  minVisibleItems = 0,
  alwaysRenderOverflow = false,
  overflowRenderer,
  itemRenderer,
  ...stackProps
}: OverflowListProps<T>) {
  const [numVisible, setNumVisible] = useState(items.length);

  const hasHiddenItems = items.length > numVisible;

  const schedule = useScheduleLayoutEffect();
  const spacer = useRef<HTMLDivElement>(null);

  useLayoutEffect(() => {
    setNumVisible(items.length);
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [JSON.stringify(items)]);

  const maybeOverflow =
    hasHiddenItems || alwaysRenderOverflow
      ? overflowRenderer({
          items,
          overflownItems: items.slice(numVisible),
        })
      : null;

  const containerSize = useResizeDetector();

  const bisect = useEffectEventShim(
    (
      low: number,
      high: number,
      path: Array<{ index: number; result: 'over' | 'under' }>
    ) => {
      let mid = Math.floor(low + (high - low) / 2);

      if (high - low === 1) {
        if (path.find((p) => p.index === high)) {
          mid = low;
        } else {
          mid = high;
        }
      }

      if (path.find((p) => p.index === mid)) {
        const pathEntry = path.findLast((p) => p.result === 'under');
        if (pathEntry) {
          setNumVisible(
            pathEntry.index < minVisibleItems
              ? minVisibleItems
              : pathEntry.index
          );
        }
        return;
      }

      setNumVisible(mid < minVisibleItems ? minVisibleItems : mid);

      schedule('recur', () => {
        const spacerWidth = spacer.current?.getBoundingClientRect().width ?? 1;

        if (spacerWidth > 1) {
          path.push({ index: mid, result: 'under' });
          bisect(mid, high, path);
        } else if (spacerWidth < 1) {
          path.push({ index: mid, result: 'over' });
          bisect(low, mid, path);
        }
      });
    }
  );

  useLayoutEffect(() => {
    bisect(0, items.length, []);
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [containerSize.width, JSON.stringify(items)]);

  return (
    <Stack
      flexDirection="row"
      flexWrap="nowrap"
      width="100%"
      minWidth={0}
      ref={containerSize.ref}
      {...stackProps}
    >
      {items.length > 0 ? (
        <>
          {items
            .slice(0, numVisible)
            .map((item, index) => itemRenderer(item, numVisible, index))}
          {maybeOverflow}
          <div
            style={{ flexShrink: 1, width: 1, flexGrow: 1 }}
            ref={spacer}
            data-spacer
          />
        </>
      ) : null}
    </Stack>
  );
}

The logic itself is probably a bit messy, i've been grappling with getting this right, so this is just the first version that worked well. But the basic premise is to bisect the list, check if we're underflowing or overflowing, and recurse until we find the solution (with some gnarly edge case handling). It uses a scheduled layout effect trick to allow use to measure the layout after each recursion. Obviously, multiple sync layouts aren't great, but it's O(log n), so it should end up being tolerable fast.

Thanks so much for this @AndrewIngram .

https://github.com/mattrothenberg/react-overflow-list/assets/8526127/49d2fd16-16cb-4691-a115-cfdb737bb633
@mattrothenberg  Hi! Thanks for your component. Tell me how can I get rid of flashing during page loading?

Hi @mattrothenberg, as mentioned on Twitter, I started out with this lib as a foundation, but went with a different algorithm, this is how my version currently looks in case you want to borrow any of the approach. It's not a drop-in replacement, as i've stripped out some functionality I wasn't using, and there's some coupling to MUI, but may still be useful:
import {
  useState,
  useRef,
  useLayoutEffect,
  ReactNode,
  ComponentProps,
} from 'react';
import useEffectEventShim from '../hooks/useEffectEvent';

import { useResizeDetector } from 'react-resize-detector';
import { Stack } from '@mui/material';

/**
 * Returns a function that will schedule a layout effect to run on the next
 * render.
 */
function useScheduleLayoutEffect() {
  const [s, ss] = useState<object>();
  const fns = useRef(new Map<string | number, () => void>());

  useLayoutEffect(() => {
    const fnCopy = Array.from(fns.current.values());
    fns.current = new Map();
    fnCopy.forEach((f) => f());
  }, [s]);

  return (id: string | number, cb: () => void) => {
    fns.current.set(id, cb);
    ss({});
  };
}

export interface OverflowListProps<T> extends ComponentProps<typeof Stack> {
  items: Array<T>;
  itemRenderer: (item: T, numShown: number, index: number) => ReactNode;
  overflowRenderer: (args: {
    items: Array<T>;
    overflownItems: Array<T>;
  }) => ReactNode;
  minVisibleItems?: number;
  alwaysRenderOverflow?: boolean;
}

export default function OverflowList<T>({
  items,
  minVisibleItems = 0,
  alwaysRenderOverflow = false,
  overflowRenderer,
  itemRenderer,
  ...stackProps
}: OverflowListProps<T>) {
  const [numVisible, setNumVisible] = useState(items.length);

  const hasHiddenItems = items.length > numVisible;

  const schedule = useScheduleLayoutEffect();
  const spacer = useRef<HTMLDivElement>(null);

  useLayoutEffect(() => {
    setNumVisible(items.length);
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [JSON.stringify(items)]);

  const maybeOverflow =
    hasHiddenItems || alwaysRenderOverflow
      ? overflowRenderer({
          items,
          overflownItems: items.slice(numVisible),
        })
      : null;

  const containerSize = useResizeDetector();

  const bisect = useEffectEventShim(
    (
      low: number,
      high: number,
      path: Array<{ index: number; result: 'over' | 'under' }>
    ) => {
      let mid = Math.floor(low + (high - low) / 2);

      if (high - low === 1) {
        if (path.find((p) => p.index === high)) {
          mid = low;
        } else {
          mid = high;
        }
      }

      if (path.find((p) => p.index === mid)) {
        const pathEntry = path.findLast((p) => p.result === 'under');
        if (pathEntry) {
          setNumVisible(
            pathEntry.index < minVisibleItems
              ? minVisibleItems
              : pathEntry.index
          );
        }
        return;
      }

      setNumVisible(mid < minVisibleItems ? minVisibleItems : mid);

      schedule('recur', () => {
        const spacerWidth = spacer.current?.getBoundingClientRect().width ?? 1;

        if (spacerWidth > 1) {
          path.push({ index: mid, result: 'under' });
          bisect(mid, high, path);
        } else if (spacerWidth < 1) {
          path.push({ index: mid, result: 'over' });
          bisect(low, mid, path);
        }
      });
    }
  );

  useLayoutEffect(() => {
    bisect(0, items.length, []);
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [containerSize.width, JSON.stringify(items)]);

  return (
    <Stack
      flexDirection="row"
      flexWrap="nowrap"
      width="100%"
      minWidth={0}
      ref={containerSize.ref}
      {...stackProps}
    >
      {items.length > 0 ? (
        <>
          {items
            .slice(0, numVisible)
            .map((item, index) => itemRenderer(item, numVisible, index))}
          {maybeOverflow}
          <div
            style={{ flexShrink: 1, width: 1, flexGrow: 1 }}
            ref={spacer}
            data-spacer
          />
        </>
      ) : null}
    </Stack>
  );
}

The logic itself is probably a bit messy, i've been grappling with getting this right, so this is just the first version that worked well. But the basic premise is to bisect the list, check if we're underflowing or overflowing, and recurse until we find the solution (with some gnarly edge case handling). It uses a scheduled layout effect trick to allow use to measure the layout after each recursion. Obviously, multiple sync layouts aren't great, but it's O(log n), so it should end up being tolerable fast.

Hi, where possibly to see full code?


Several Voice API webhook models are missing

Describe the bug
While some Voice API Webhook types are present i.e. InputEvent and CallEvent other events documented here are missing: https://developer.vonage.com/en/voice/voice-api/webhook-reference
e.g.

Answer
Completed
Transfer

Missing headers field access
Additionally the existing models don't allow to read SIP header values:

For the Answer Webhook they are directly added to the payload as described here:
https://developer.vonage.com/en/voice/voice-api/webhook-reference#transmitting-additional-data-with-sip-headers
For all the Event Webhooks they are in a headers field holding key/value's

Vonage SDK Version

Version: 7.7

Java SDK Version

Version: 11

Thanks again for reporting this. Will aim to have a fix soon™.

Fixed in #506, will be released in v8.2.0.


i18n(zh-cn): Update i18n.mdx

Description (required)
Update i18n.mdx
Related issues & labels (optional)

#9780
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

zh-cn/recipes/i18n.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Error on Android and Electron build on version 18.0.1

Bug report

CHECKLIST

[ x] I have read the issue reporting guidelines

[ x] I confirm this is a suspected bug or issue that will affect other users

[ ] I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.

[x ] I have read the documentation thoroughly and it does not help solve my issue.

[x ] I have checked that no similar issues (open or closed) already exist.

Current behavior:
With the new version 18.0.1 the android and electron apps are not builded.

I get the following error:
cordova-plugin-androidx-adapter: Processed 58 source files in 1044ms
Executing script found in plugin cordova-plugin-firebasex for hook "after_prepare": plugins\cordova-plugin-firebasex\scripts\after_prepare.js
The provided path "C:\Users\rodri\CBOARD\ccboard\platforms\ios" is not a Cordova iOS project.
CordovaError: The provided path "C:\Users\rodri\CBOARD\ccboard\platforms\ios" is not a Cordova iOS project.
    at new Api (C:\Users\rodri\CBOARD\ccboard\node_modules\cordova-ios\bin\templates\scripts\cordova\Api.js:98:15)
    at Utilities.getAppName (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\lib\utilities.js:71:24)
    at setupEnv (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\after_prepare.js:25:25)
    at module.exports (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\after_prepare.js:67:5)
    at runScriptViaModuleLoader (C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:157:32)
    at runScript (C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:136:12)
    at C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:108:40
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
CordovaError: The provided path "C:\Users\rodri\CBOARD\ccboard\platforms\ios" is not a Cordova iOS project.
    at new Api (C:\Users\rodri\CBOARD\ccboard\node_modules\cordova-ios\bin\templates\scripts\cordova\Api.js:98:15)
    at Utilities.getAppName (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\lib\utilities.js:71:24)
    at setupEnv (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\after_prepare.js:25:25)
    at module.exports (C:\Users\rodri\CBOARD\ccboard\plugins\cordova-plugin-firebasex\scripts\after_prepare.js:67:5)
    at runScriptViaModuleLoader (C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:157:32)
    at runScript (C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:136:12)
    at C:\Users\rodri\AppData\Roaming\nvm\v18.18.1\node_modules\cordova\node_modules\cordova-lib\src\hooks\HooksRunner.js:108:40
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Within the 18.0.0 version all is working properly. I was not able to test with the Ios app because I dont have a mac.

Expected behavior:
Get a succesful build of the Android and Electron apps.

Steps to reproduce:
Just use the last 18.0.1 and cordova android build --debug

Screenshots

Environment information

Cordova CLI version :

 12.0.0<EMAIL_ADDRESS>

Cordova platform version

Installed platforms: android 13.0.0 electron

Plugins & versions installed in project (including this plugin)

com.lampa.startapp 6.1.6 "startApp" cordova-clipboard 1.3.0 "Clipboard" cordova-plugin-android-permissions 1.1.5 "Permissions" cordova-plugin-androidx-adapter 1.1.3 "cordova-plugin-androidx-adapter" cordova-plugin-cboard-speech-tts 0.0.1 "cboard-speech-tts" cordova-plugin-default-browser 1.0.0 "CordovaPluginDefaultBrowser" cordova-plugin-fbsdk 4.1.1 "Facebook Connect" cordova-plugin-file-opener2 2.2.1 "File Opener2" cordova-plugin-file 8.1.2 "File" cordova-plugin-firebasex 18.0.0 "Google Firebase Plugin" cordova-plugin-fullscreen 1.3.0 "cordova-plugin-fullscreen" cordova-plugin-ionic-keyboard 2.2.0 "cordova-plugin-ionic-keyboard" cordova-plugin-iosrtc 8.0.4 "iosrtc" cordova-plugin-market 1.2.0 "Market" cordova-plugin-media 7.0.0 "Media" cordova-plugin-network-information 3.0.0 "Network Information" cordova-plugin-purchase 13.11.1 "Purchase" cordova-plugin-saf-mediastore 0.7.0 "cordova-plugin-saf-mediastore" cordova-plugin-sign-in-with-apple 0.1.2 "cordova-plugin-sign-in-with-apple" cordova-plugin-statusbar 2.4.3 "StatusBar" ionic-plugin-deeplinks 1.0.22 "Ionic Deeplink Plugin"

Dev machine OS and version, e.g.

Windows 10

Android build issue:

Node JS version

v18.18.1

Gradle version

8.7

Target Android SDK version

34

Related code:
insert any relevant code here such as plugin API calls / input parameters

Console output

console output

// Paste any relevant JS/native console output here

Other information:
I think its something within the hook after_prepare that runs this plugin. I have the p.list and the google-services.json files on my repo.

ah, looks like PR #896 broke this

Fix published in<EMAIL_ADDRESS>

Nice! Thanks!


knex did not recover from broken oracle db connection with oracledb 6.x - add NJS-500 codes

Environment
Knex version: 2.5.1
Database + version: Oracle 19
OS: Oracle Linux 7
oracledb npm: oracledb 6.1.0
@atiertant
Bug

Explain what kind of behaviour you are getting and how you think it should do

In the even an oracle database connection becomes broken, knex should be able to discard the broken connection from connection pool and obtain a new connection.  Recently when a db connection was lost knex kept trying to use the same broken connection (forever).  I had a cron task that kept querying the db frequently, which also made this worse, because the bad connection never expired either.
The issue is easy to fix by updating the knex file lib/dialects/oracle/utils.js by adding the NJS-500 error to the isConnectionError() function.
In fact oracledb 6.x seems to have introduced several new error codes in the NJS 500-521 range.  See  https://github.com/oracle/node-oracledb/blob/main/lib/errors.js
Please make this update.

Error message

Nov 06 2023 11:55:41~[ERROR]~DNS request processor: Error: select * from ... - NJS-500: connection to the Oracle Database was broken
DPI-1010: not connected
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errorNum: 0,
  offset: 0,
  code: 'NJS-500'
}

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to MySQL or PostgreSQL, then single file example which initializes
needed data and demonstrates the problem.

install oracledb 6.1.0 npm and knex.
Create a loop/cron task that queries the DB every few seconds.
Then in sqldeveloper login as an admin user, go to (tools -> monitor sessions), find the session in the report, right click it and kill it.  This will cause the NJS-500 error to appear repeatedly.

Then, stop the program.  Update node_modules/knex/lib/dialects/oracle/utils.js by adding  'NJS-500', to the isConnectionError() function.  Repeat the test above.  Now knex is able to reconnect to the db immediate when it detects the NJS-500 error.

Same problem here. I can create a PR as @vpeltola was expecting this to be fixed by someone else

@kibertoad Thanks and sorry to ask this but.... is the release coming soon ? 😁


Gitpod can't sign in to near account to call functions

So I was following the standard instructions in the readme:

And go the error that you can see down below.


AUR package

Hey there,
Would you mind creating an AUR package for this? I'm not very fond of installing things that I can't easily uninstall.
I really like the idea and would like to try what this has to offer though!
Thanks!

While making packages for easier installation of Pluto is on our radar, I don't see what you mean by "things that I can't easily uninstall". In principle, you can drop the pluto and plutoc executables anywhere, including a folder that's in your path — that's a state I might call "installed" — but it would be just as easy to delete the executables again.

the issue with running e.g. make install is that you need the makefile (and a rule) to uninstall it again, otherwise you end up with orphan files on your system.

I see. We only have a makefile because of Lua legacy iirc, it's completely unreadable and unmodifyable in my eyes. So my suggestion for getting started with Pluto (outside of using the interactive web playground nor pre-built libraries) would be to compile Pluto either with make, Sun, or the PHP scripts, and then drop executable(s) where ever you see fit.

Going to track this in #274


Models are invisible

Hello! I have tried obj-mc and made a model and it was invisible. I put in the resourcepack from the folder in obj-mc and the shuba was also invisible. I have my graphics settings on "Faboulus!" and this is my command: /summon minecraft:armor_stand ~ ~ ~ {ShowArms:1b,ArmorItems:[{},{},{},{id:"minecraft:potion",Count:1b,tag:{CustomModelData:1,CustomPotionColor:0}}],ArmorDropChances:[0f,0f,0f,0f]}  but there was no shuba. Any ideas?

if the default models are invisible then most likely it means you arn't playing the right version of the game
make sure you are in vanilla 1.19.4+


SSHChat - fix connection logic and remove send bug

The existing logic for establishing connections in the SSHChat bridge contained potential race-conditions as it did not wait for the connection to be successful before returning.
Additionally we reintroduce a missing if condition on handling file attachments that was previously wrongly removed.

Thanks! Look into this later.
I'm curious why codeclimate doesn't trigger anymore, didn't change anything. Maybe also on holiday :)

Thanks!


support android opengl ES 2.0? how to build ?

support android opengl ES 2.0 or 3.0?
how to build for andorid?
use glfw with glew support android?

Android support was already mentioned here https://github.com/glfw/glfw/issues/611
As far as I know, there's no android implementation in this repo, maybe in some fork. I'm not sure how a mobile port would work if not rewriting the whole library from bottom to top. Inputs are handled different, creation of windows (display) is completely different.
Even with the NDK, a minimal application in Java is still required to make interface with the system.

tks for answers , android  mobile（TV ,arm board） is linux ,which diffrent is EGL window , and cut of some openGL API for arm(you donot care). EGL window using android surface interface will be OK for handle ,about input same sa linux.
whith NDK, without any of java ,we just use NDK's gcc make etc. same as linux and osx, android devices can run console aplay  draw openGL ES UI
who want  to use for java apk ,just expose ti's c jni api will be fine.
i am still look forward ,Forgive me for my low eng level...

@liulover5 As @felipefs said, there is currently no support for Android. Perhaps check out GLFM for a GLFW-like library that does support Android.


Inconsistent behavior when tracing messages within a failing validator (version <IP_ADDRESS>)

Summary
I have witnessed an inconsistent behavior when using trace functions within validation code. In some cases, the message actually appears in the final result, and in others, it does not.
Here is a vanilla example. Consider the following validator:
traceValidator :: Pl.TypedValidator MockContract
traceValidator =
  Pl.mkTypedValidator @MockContract
    $$(Pl.compile [||val||])
    $$(Pl.compile [||wrap||])
  where
    val :: () -> () -> Pl.ScriptContext -> Bool
    val _ _ _ = Pl.traceIfFalse "this is false" False
    wrap = Pl.mkUntypedValidator

When called, this validator produces the following validation error:
Evaluation error [ PT5 ]

Before, in version <IP_ADDRESS>, we used to get:
EvaluationError ["Data decoded successfully","Redeemer decoded successfully","Script context decoded successfully","this is false","PT5"]

I have conducted some further testing with various variations of this validator.

Here are the variations that do produce a trace of the expected messages:

The validator with a boolean and a string as parameter. We get a trace of either the given string, or the statical one, depending on the value of the boolean:
val :: (Bool, Pl.BuiltinString) -> () -> () -> Pl.ScriptContext -> Bool
val (b, s) _ _ _ = Pl.traceIfFalse (if b then s else "this is false") False

The validator with a boolean as parameter:
val :: Bool -> () -> () -> Pl.ScriptContext -> Bool
val b _ _ _ = Pl.traceIfFalse (if b then "this is true" else "this is false") False

The validator with a String as parameter:
val :: Pl.BuiltinString -> () -> () -> Pl.ScriptContext -> Bool
val s _ _ _ = Pl.traceIfFalse s False

The validator with two conditions, both tracing a message:
val :: () -> () -> Pl.ScriptContext -> Bool
val _ _ _ =
  let a = Pl.traceIfFalse "this is true" False
      b = Pl.traceIfFalse "this is also true" False
  in a && b

Here are other examples where we do not get anything traced:

Encompass the string in a let binding:
val :: () -> () -> Pl.ScriptContext -> Bool
val _ _ _ = let s = "this is true" in Pl.traceIfFalse s False

Encompass the whole expression in a let binding:
val :: () -> () -> Pl.ScriptContext -> Bool
val _ _ _ = let a = Pl.traceIfFalse "this is true" False in a

I have no idea where these discrepancies come from. Everything used to be printed properly in v<IP_ADDRESS>.
Steps to reproduce the behavior
Create the following dummy validator:
traceValidator :: Pl.TypedValidator MockContract
traceValidator =
  Pl.mkTypedValidator @MockContract
    $$(Pl.compile [||val||])
    $$(Pl.compile [||wrap||])
  where
    val :: () -> () -> Pl.ScriptContext -> Bool
    val _ _ _ = Pl.traceIfFalse "this is false" False
    wrap = Pl.mkUntypedValidator

Run it by consuming one of its outputs.
Actual Result
Evaluation error [ PT5 ]
Expected Result
Evaluation error [ this is false,  PT5 ]
Describe the approach you would take to fix this
No response
System info
Ubuntu.
Library version <IP_ADDRESS>

Thanks to @nhenin I managed to fix this. To my understanding, it turns out that this was not a bug but a feature where default optimizations would in fact remove some of the tracing. By using conservative-optimisation it works as it did before. Note that the option preserve-logging which is supposed to be implied by the former actually is not recognized by itself.

Hi @mmontin,
I see that you've already discovered the conservative-optimisation flag which is not turned on by default. So by turning it on you disable certain optimisations that can remove traces. This is useful for development and debugging.
There is also another compiler option called remove-traces / no-remove-traces. This test spec uses both options to verify tracing preservation.
As for the preserve-logging option's behaviour - I'd need to investigate. Thanks for mentioning it!


Unguarded gets need to be guarded.

Description
Calling the get method from  Optional, Map, and List classes can throw runtime exceptions or return nulls. We have lots of gets that are not checked, and these gets need to be guarded by checking Optional#isEmpty, Map#containsKey, and List#size when appropriate.
Desired outcome
All Optional#get and Map#get calls are guarded by checks. If a value needed is not available, a 4XX-level HTTP status code should be returned to the user if it is the result of bad user input, or a RuntimeException should be thrown if it is the result of a bug in the system.
For an example see: #434
Additional context
A good place to start would be grep \.get\( app/* -R --include="*.java". Not all of these are bad gets!

Working on this.

Thanks for picking this up. There may be some complexity in terms of handling asynchronous exceptions. Let me know if you have any questions!


Clarify install instructions?

This is a great library, but the install is complicated. That would be okay, but the instructions here are pretty difficult to follow. Specifically, I'm having trouble understanding this step:
pygrib installation opt

pygrib installation options can either be set with environment variables, or specified in a text file (setup.cfg). To use environment variables, set $GRIBAPI_DIR, $JASPER_DIR, $OPENJPEG_DIR, $PNG_DIR and $ZLIB_DIR so that the include files and libraries for GRIB API, Jasper, OpenJPEG, PNG and zlib will be found. For example, the include files for jasper should be found in $JASPER_DIR/include or $JASPER_DIR/include/jasper, and the jasper library should be found in $JASPER_DIR/lib or $JASPER_DIR/lib64. If any of those environment variables are not set, then it is assumed that GRIB API was not built with support for that library. If the libraries and include files are installed in separate locations, the environment variables $GRIBAPI_INCDIR and $GRIBAPI_LIBDIR can be used to define the locations separately (same goes for JASPER, OPENJPEG, PNG and ZLIB). Note that if both $GRIBAPI_DIR and $GRIBAPI_INCDIR/$GRIBAPI_LIBDIR are specified, $GRIBAPI_DIR takes precedence. To use setup.cfg, copy setup.cfg.template to setup.cfg, open setup.cfg in a text editor and follow the instructions in the comments for editing.

What do I set these environment variables to?

And how do these instructions mesh with pip install? Is there a separate set of instructions I can follow to get the pip install to work?

pip install pygrib should just work with version 2.1.2


Incorrect Batch number reassigned when batches are in descending order in nacha file

ACH Version
v1.33.3
What were you trying to do?
We are trying to process a file that looks something like this:
batch 3
   - entry 1
 batch 2
   - entry 1
   - entry 2
 batch 1
   - entry 1
   - entry 2

When the file is getting parsed, we noticed that the batch numbers were incorrectly reassigned because of the <= logic here. In the loop, when we get to 3rd batch (batchSeq = 3) which is batch 1, the <= condition allows the if block to execute where we are resetting the batch number to 3. So we end up with 2 different batches set to the same batch number.

Note that we do have AllowUnorderedBatches validation option set to allow for random ordering of batches.

What did you expect to see?
Batch number should not be reset to 1 when the batches are in descending order
What did you see?
batch number 1 is reassigned to 3
How can we reproduce the problem?
Create a small file with descending batches and atleast one entry in each batch and run it through the parser.

Side note: If we deem this to be a valid issue, i'd love to work on this as my first good task :)

Interesting.. My recollection of the Nacha spec says batch numbers must be in ascending order, so this likely isn't handled. Go ahead and open a PR for this! How were you planning on fixing this?

Yeah, batches can be unordered as well it looks like.
I'm thinking that just removing = here should resolve it.

I'm not sure if that will work. We rely on tabulation of BatchNumbers in a few code paths, but I'm curious to see what you come up with.

Yeah Im digging more into this today. But the general direction im looking at is that, do not reassign a batch number unless its set to anything less than 1 instead of the current behavior which is resetting the value for anything <= 1.

Is there a strict rule about starting batchNumber = 1 ? I found another library that starts from 0.  Could be that an issue?


Updates for v2.6 release, including Ruby and gem bumps

See CHANGELOG.md additions for details.

Bad form to self-review but this pretty much all just boilerplace and procedure.


About "x_0" and "x_next" in the diffusion.py

                x0 = self.pred_x0_from_xt(x_t, noise_pred, C_pred, cur_time)
                x0.clamp_(-1., 1.)
                C_pred = -1 * x0
                x_next = self.pred_xtms_from_xt(x_t, noise_pred, C_pred, cur_time, s)

why traj[t-1] = x_next.detach(), why not traj[t-1] = x_0.detach()

@shrxht
You can seem x0 as an estimation in each denoising step, and x_next is the real denoised signal.


RELATED-TO field removed when marking as completed

I use a task manager that has support for subtasks using RELATED-TO. When I mark such a task as completed in OpenTasks, after updating, it turns out the RELATED-TO field has been removed. Can it be that OpenTasks is responsible, or is it the sync adapter? (I currently use DavDroid.)

I have contacted the DavDroid developers and they state that DavDroid does not throw away RELATED-TO. So I am really interested in knowing whether this is a known issue of opentasks (or even the provider).

I can't imagine any reason why we would remove relations when a task is marked complete. Nor can I remember any code which might cause this. Is completing a task the only trigger for this behavior or do other changes result in the same issue?


Add a property to Material icon button to customize the minimum splash radius

Description
Add a property to Material icon button to customize the minimum splash radius.
Tests
I added the following tests:

IconButton with explicit min splash radius.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[?] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[X] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

Replied to comments.


Pure pipes versions of impure pipes

I'm thinking maybe doing only pure pipes for the 2.0.0 release to motivate people to use immutability instead of push, pop, etc


Revert "Revert the move to node-rdkafka 2.0"

Reverts wikimedia/change-propagation#230
We need to finally upgrade to node-rdkafka v2 because right now we can't really deploy ChangeProp in SCB.
This depends on updating librdkafka on SCB and a coordinated deploy together with EventStreams.
cc @wikimedia/services @ottomata

Coverage increased (+0.9%) to 90.564% when pulling fe9272b977ad978cee1d9d20bfc2337c06a25f5e on revert-230-revert-node-rdkafka-2.0 into 33e0e5b58e82699d8d06ee174667c747c11cfe3b on master.


Add base TestCase for transformers

It could be great to have a base class for TestCase on transformers which are subclass of AbstractTransformer.
We have a lot of initialization to do for implementing TestCase on subclass of AbstractTransformer and this generate massive code duplication.

Fixed with #36


twister stopped at exit with: function: libtorrent::piece_manager& libtorrent::torrent::filesystem()

twister 0.9.34 was running over tor for 56h

I exited it and this happened (A)

last lines from log here (B)

some hours before exit: I tried these commands (C) and noticed then that twisterd was consuming since then 5% more cpu load

(A)
./twisterd
assertion failed. Please file a bugreport at http://code.google.com/p/libtorrent/issues
Please include the following information:
version: <IP_ADDRESS>
$Rev: 7680 $
file: 'libtorrent/src/torrent.cpp'
line: 6405
function: libtorrent::piece_manager& libtorrent::torrent::filesystem()
expression: m_owning_storage.get()
stack:
1: ) [0x8088943]
2: ) [0x81fc376]
3: ) [0x820082c]
4: ) [0x824d9dd]
5: ) [0x819f291]
6: ) [0x819deb5]
7: ) [0x807e086]
8: ) [0x80823c4]
9: ) [0x81cb614]
10: ) [0x80825f6]
11:
12: clone
Abgebrochen (Speicherabzug geschrieben)
(B)
2015-12-23 18:18:52   skipping , resume file up-to-date
... [this line repeating a lot]
2015-12-23 18:18:52   skipping , resume file up-to-date
2015-12-23 18:18:52 saving user_data (followers and DMs)...
2015-12-23 18:18:52 maintain-dht-nodes thread exit
2015-12-23 18:18:53 twister threads to join = 0
2015-12-23 18:18:53
saving session state
2015-12-23 18:18:53 saving user_data (followers and DMs)...
2015-12-23 18:18:53 libtorrent + dht stopped
(C)
the first three commands returned their results fast, only the last 2 commands needed longer!
./twisterd peekpost erkan_yilmaz 123
./twisterd peekpost erkan_yilmaz 1
./twisterd peekpost mfreitas 1
./twisterd peekpost google 1
error: {"code":-24,"message":"timeout or post not found"}
./twisterd peekpost google 1
error: {"code":-24,"message":"timeout or post not found"}

crash on exit?
it looks like an interesting bug to fix, but it is hard to do so without the backtrace. apparently it failed to resolve the stack adresses into symbol names.
is this a debug build (./configure --enable-debug)?

no dump available (1)
I can let run twisterd with debugger again
(1) twister was behaving good the last months :-)


npm install --save prop-types causes severe problems with CRNA storybook

I'm not sure if npm install of other packages will cause the same problem, I haven't tested that, but npm install --save prop-types to an out-of-the-box CRNA storybook app on RN 44, leads to loads of npm run storybook  errors like Error: Can't resolve 'react' in '/Users/kmac/Desktop/storybook/react-native-multi-level-select/node_modules/react-modal/lib/components'
And in the end I had to remove prop-types and @storybook/react-native then rerun getstorybook for it to work again

Thanks @kdenz I'll check it out and see (1) whether I can reproduce the problem, and (2) whether I can make sense of what's going! It'll be a couple days though, so if anybody else wants to jump in here, go right ahead!

If this is still a problem on the latest versions, please reopen. The cli should now install prop-types by default.
https://github.com/storybooks/storybook/blob/master/lib/cli/generators/REACT_NATIVE/index.js#L45


LoadState(FromFile) endpoints

RFC=0023

@gaschler Can you update client_server_test.cc?

Done, added test coverage for the trajectory remapping return value.

@wally-the-cartographer merge

Merge requested by authorized user gaschler. Merge queue now has a length of 1.


Update bindgen [WIP]

Closes https://github.com/fortanix/rust-mbedtls/issues/5.
Also bump serde_derive minor version to match that of serde and to reduce Cargo.lock bloat associated with this PR.

Final PR: #152

Fixed in #152


Research optimal threading configuration, and implement it.

Likely a dedicated admin thread, and 1-2 worker threads.

The number of worker (envoy definition) threads to use.
Determine optimal threading model/configuration (in terms of overallCPU usage, latency/throughput). Expose configuration knobs if necessary.

Currently we have 2 threads with fixed config.
I think we still want:

Dedicated admin thread for debug interface and XDS
Find the optimal amount of threads for default. Is it really 2?
Allow "thread per core" detection when configured to 0 threads.

I can investigate on it, while I am new to tokio.

https://www.influxdata.com/blog/using-rustlangs-async-tokio-runtime-for-cpu-bound-tasks/ is a good reference.
I am thinking we have 1 runtime for "admin" (xds, stats, debug endpoint) with 1 thread. Then another data plane runtime for readiness probe and proxying with N threads (default 2 but configurable).
This is pretty similar to Envoy


Create sprint-specific team with edit permissions

Hello @philerooski! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file kirallymanager/manager.py:

Line 466:26: E251 unexpected spaces around keyword / parameter equals
Line 466:28: E251 unexpected spaces around keyword / parameter equals


Add support for ES6 generators that works in both V8 and SM

This patch adds support for ES6 generators that works both in V8 (with flag) and latest SpiderMonkey, while retaining support for legacy generators.

Yes, all browsers supporting generators, including Chrome 39+ and Firefox 26+.
Code can also be compiled to es5 with Babel to work with all browser.


Is Database UnwindSafe?

I have no idea :) This is the first time I've heard of UnwindSafe. If you figure it out though, do let me know!


Typo from aimexam()

I used imexam on jupyter notebook with ginga. Simply doing aperture photometry, its output printed in the notebook has typo. Here is from my screen:
read: a at 271.0, 285.0
xc=271.0797	yc=286.0884
x              y              radius         flux           mag(zpt=2.5e+01)              sky/pix        fwhm(x,y)
271.00         285.00         5              4.1e+01        2.1e+01        0.863          0.56,0.64
271.0796761204972<PHONE_NUMBER>840574 24.0

thanks - can you point out the type specifically for me?

--------------- from output screen ------------------
x y radius flux mag(zpt=2.5e+01) sky/pix fwhm(x,y)
271.00 285.00 5 4.1e+01 2.1e+01 0.863 0.56,0.64
271.0796761204972<PHONE_NUMBER>840574 24.0
--------------- should it be? ------------------------
x y radius flux mag(zpt=2.5e+01) sky/pix fwhm(x,y)
271.079 286.088 5 4.1e+01 2.1e+01 0.863 0.56,0.64
I think you might just pass wrong values.
Also, flux value = 41. Could you check if this is correct? And, what unit is it? I could not find out about the unit from the website.

will you add the version of imexam that you are using?

0.9.1

imexamine.py
Correct
L637
pstr = f"\n{x:.2f}\t{y:0.2f}\t{radius}\t{total_flux:0.2}\t{mag:0.2}\t"
to
pstr = f"\n{xx:.2f}\t{yy:0.2f}\t{radius}\t{total_flux:0.2}\t{mag:0.2}\t"
Delete
L685
print(xx,yy,pad)
Thanks


Added support for Google buckets storage.

What does this PR do?
Adds support for Google buckets storage.
Motivation
Needed for persistent storage.

Named the new project BaGet.GCP rather than BaGet.Gcp to match capitalization of aws project, I'm not sure which you prefer.

@loic-sharma This has been superseded by #233 and can be closed.

Yes it can, thanks for the reminder! :)


Use haddock in code climate?

Can we use haddock in code climate to check automatically the quality of our documentation?

Can we also see the coverage of code climate?
See https://docs.codeclimate.com/v1.0/docs/setting-up-test-coverage

There was nothing implemented for Haskell when I checked. That is why we tried with coveralls. See #92. This looks more like something we can do in our free time for now....

regarding your comment on long lines,
I would like to automate this check:
Is there a general code climate plugin for checking long lines (or long files)?
Or could we make one (doesn't seem that hard ;-)?

We might have to write engines for coverage and line length
https://docs.codeclimate.com/v1.0/docs/building-a-code-climate-engine


this site content it outdated !!!

I found this article that has the correct latest instructions.
https://docs.microsoft.com/en-us/azure/active-directory/saas-apps/cisco-spark-tutorial
Please merge these 2 articles

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee0d3d2c-71f4-9366-73a3-f0c910cf9073
Version Independent ID: 953ee878-2afd-d2b4-c5f0-a750ecd910a9
Content: Tutorial: Azure Active Directory integration with Cisco Webex Meetings
Content Source: articles/active-directory/saas-apps/cisco-webex-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@davidkklim
Thanks for your feedback! We will investigate and update as appropriate.

@davidkklim Cisco WebEX and WebEx meetings are two different apps. I think you are getting confused here. So please use the correct app from the gallery. We have got both these documents verified by the Cisco Identity team.

#please-close


Fix printing of SRK hashes

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@cb8fe4c). Click here to learn what that means.

Files
Patch %
Lines

cmd/provision/main.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #122   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?      19
  Lines           ?    1338
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?    1338
  Partials        ?       0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG]:  ORANGE OAB VAL DE REUIL :Ext4 filesystem is consuming extra reserved space from the total available size

Bug Description
ORANGE OAB VAL DE REUIL :Ext4 filesystem is consuming extra reserved space from the total available size
Logs
We’ve notice two issues with CSI Driver :
The first one is an issue with RedHat "Migration Toolkit for Virtualization" application which is supposed to import virtual machines from a RedHat Virtualization cluster to an Openshift Virtualization environment.
When doing such an import using Filesystem volume mode, we cope with an issue regarding volume size.
You’ll find all details concerning this issue in the following RedHat Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=2059057 [bugzilla.redhat.com] which is exactly what we’ve encountered.
We don't currently know if this issue is resulting from the application itself or from DELL CSI driver ext4 implementation.
The Second one is that, in some cases, we need use a single PV in more than one container at same time.
It's seem that, in this case, we need use the PV in ReadWriteMany access mode.
We’ve notice that your documentation tell that this access mode in currently not available according to our configuration.
So questions are :
Do you plan to put this kind of access mode in DELL CSI Driver (as Red Hat tells us it's just a matter of driver coding) ?
If Yes, is there an existing roadmap or a currently existing driver version with this feature implemented ?
Is there any applicable workaround for this case ?
As mentioned by phone, we’ll quickly create an helpdesk ticket for this.
, Additional Info: { Sales Order Number: 00000}
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
create a pvc of 100GB size using ext4 file system and ISCSI protocol. We observed that only 98.3 GB of storage space could be used .
Expected Behavior
This is an expected array behavior. Every time we create a volume with certain space , some percentage of it is reserved for file system.
CSM Driver(s)
CSI Driver for Unity XT v2.1
Installation Type
csi driver unity
Container Storage Modules Enabled
No response
Container Orchestrator
Kubernetes 1.23.1
Operating System
RHEL 8

Mail communication details
Hi @Lucey, Brian,
This is an expected array behavior. Every time we create a volume with certain space , some percentage of it is reserved for file system.
If the customer is looking for exact space to be available, he/she  needs to do the math based on filesystem being used(example : for ext4, 5 percent is reserved) and create the volume accordingly. As of now driver leaves it to the array on how much space needs to be reserved for filesystem.
We can use the following ticket to track the issue further :
https://jira.cec.lab.emc.com/browse/KRV-4107
If needed we can get into a zoom call. Please let us know.
Regards,
Karthik K
Internal Use - Confidential
From: Lucey, Brian<EMAIL_ADDRESS>Sent: Wednesday, March 30, 2022 4:25 PM
To: K, Karthik; Coulombel, Florian; Muthukumarasamy, Prasanna; Gasho, Frank; DevCon BLR CSI Team; Thomas, Rensy; Indukuri, Rajendra; Ghivari, Deepak
Cc: OCallaghan, Mark (CS Cork); Gowtham, Mayura; Schmaelzle, Matt; Gallacher, Sean
Subject: RE: SR 138122165 | Dell CSI driver unity driver for Openshift
Hi Karthik,
Any update on this issue?
Is this an issue with the driver, array or Openshift?
I haven’t been able to test this myself with Unity but when testing via PMAX iSCSI, a 100GB PVC appears as 100GB on the array but 120GB on the pod, with 104GB usable.
Thanks
Brian
Internal Use - Confidential
From: K, Karthik<EMAIL_ADDRESS>Sent: Monday 28 March 2022 15:28
To: Coulombel, Florian; Muthukumarasamy, Prasanna; Gasho, Frank; DevCon BLR CSI Team; Thomas, Rensy; Indukuri, Rajendra; Ghivari, Deepak
Cc: Lucey, Brian; OCallaghan, Mark (CS Cork); Gowtham, Mayura; Schmaelzle, Matt; Gallacher, Sean
Subject: RE: SR 138122165 | Dell CSI driver unity driver for Openshift
Hi,
For the first question,
We tried to reproduce the scenario by creating a pvc of 100GB size using ext4 file system and ISCSI protocol. We observed that only 98.3 GB of storage space could be used as seen in the screenshot attached.
We have reached out to unity storage team to know the actual space that would be used by ext4 filesystem.
We had faced similar issue when provisioning using NFS protocol, where meta data was consuming 1.5 GB of the storage space. The issue was resolved by adding 1.5GB space to the requested capacity of the file system volume in the array.
For the second question,
As Florian mentioned,  ReadWriteMany (RWX) is supported only for NFS/raw block volumes and  not for ISCSI/FC (as this is not supported from the storage array).
Regards,
Karthik K
Internal Use - Confidential
From: Coulombel, Florian<EMAIL_ADDRESS>Sent: Monday, March 28, 2022 12:45 PM
To: Muthukumarasamy, Prasanna; Gasho, Frank; DevCon BLR CSI Team; Thomas, Rensy; Indukuri, Rajendra; Ghivari, Deepak
Cc: Lucey, Brian; OCallaghan, Mark (CS Cork); Gowtham, Mayura; Schmaelzle, Matt; Gallacher, Sean
Subject: RE: SR 138122165 | Dell CSI driver unity driver for Openshift
Hi,
On the first question about the size of the PV has an interesting point.
@Muthukumarasamy, Prasanna, maybe there is an enhancement to implement to reserve space for the meta data with formatted LUNs (as we do with NFS share). I’m not sure what is the recommendation in our field about that.
On the ReadWriteMany, the problem is that to allow multiple nodes to access the same block device we need a filesystem that accepts concurrency (NFS, GlusterFS, etc.) ; ext4 doesn’t allow concurrent access.
To allow RWX with Unity you have to use a Raw Block device (volumeMode: block) or the NFS provider.
HTH
--- Answers in French
Comme décrit dans l’article, une fois formatté une partie de l’espace du volume est réservé pour les meta-données ext4.
Les solutions sont soit de :

demander un volume plus grand
ou de redimentionner le volume existant
ou d’utiliser un Raw Block Device en assumant que l’application va le formatter (ce qui semble être le cas d’après l’article).

ReadWriteMany signifie que plusieurs nœuds ou serveurs vont accéder au même volume de façon concurrente. Ext4 n’est pas un système de fichiers qui supporte la distribution sur plusieurs serveurs. Il n’est donc pas possible d’utiliser RWX.
Avec Unity, le RWX est supporté pour un accès via NFS ou avec un Raw Block device (volumeMode: block) en assumant que l’application qui utilise ce volume s’occupe de l’intégrité des données.
Cdt.
Internal Use - Confidential
From: Muthukumarasamy, Prasanna<EMAIL_ADDRESS>Sent: Monday, March 28, 2022 6:40 AM
To: Gasho, Frank; Coulombel, Florian; DevCon BLR CSI Team; Thomas, Rensy; Indukuri, Rajendra; Ghivari, Deepak
Cc: Lucey, Brian; OCallaghan, Mark (CS Cork); Gowtham, Mayura; Schmaelzle, Matt; Gallacher, Sean
Subject: RE: SR 138122165 | Dell CSI driver unity driver for Openshift

@Thomas, Rensy, @Indukuri, Rajendra @Ghivari, Deepak

Thanks and Regards,
Prasanna M.
<EMAIL_ADDRESS>Internal Use - Confidential
From: Gasho, Frank<EMAIL_ADDRESS>Sent: Saturday, March 26, 2022 1:13 AM
To: Coulombel, Florian; DevCon BLR CSI Team
Cc: Lucey, Brian; OCallaghan, Mark (CS Cork); Gowtham, Mayura; Muthukumarasamy, Prasanna; Schmaelzle, Matt; Gallacher, Sean
Subject: SR 138122165 | Dell CSI driver unity driver for Openshift

Unity CSI team and Engineering management for awareness
Also pasted in Slack for awareness.

Hi Florian,
I notice there is a case in our q for Monday 5 am pickup for a customer in France called ORANGE OAB VAL DE REUIL (FR) with requested language of French.  I was curious if you could help our EMEA team out with some of this?
138122165
ORANGE OAB VAL DE REUIL (FR)
Nicolas SIMON
Severity: Medium
For the first question, I’m not familiar with some of what they are doing and I don’t find any hits for similar in Jira for what has been described so far in the Bugzilla.  I don’t have access to the Red Hat solution that is linked in the Bugzilla(but asked in Slack).  From the github that is linked in the Bugzilla could it be as simple as using a bigger PV?  Like I said, I am not familiar with what they are doing.  It might not even be our issue since there is a PR.  This isn’t the typical create a PV/PVC and assign it to a pod that we usually do.  We will need to get some logs and better details, but since this is new to me and my team it may be good to get you and/or engineering on the call sooner rather than later to get the details.
For the second question RWX is supported.  I pasted print screens from the support matrix below.  So I’m not sure where the confusion comes from here.
Customer opened the case with the following with a description in the Bugzilla.  I am not clear if this is the same customer or if there are 2 customers out there with the same issue:
Hi,
We currently building an OpenShift cluster (3 nodes compact mode cluster) with an DELL UNITY fiberchannel disk array.
At the moment we’ve installed OpenShift 4.9 with your DELL CSI-unity driver release 1.6.
We’ve notice two issues with CSI Driver :
The first one is an issue with RedHat "Migration Toolkit for Virtualization" application which is supposed to import virtual machines from a RedHat Virtualization cluster to an Openshift Virtualization environment.
When doing such an import using Filesystem volume mode, we cope with an issue regarding volume size.
You’ll find all details concerning this issue in the following RedHat Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=2059057 [bugzilla.redhat.com] which is exactly what we’ve encountered.
We don't currently know if this issue is resulting from the application itself or from DELL CSI driver ext4 implementation.
The Second one is that, in some cases, we need use a single PV in more than one container at same time.
It's seem that, in this case, we need use the PV in ReadWriteMany access mode.
We’ve notice that your documentation tell that this access mode in currently not available according to our configuration.
So questions are :
Do you plan to put this kind of access mode in DELL CSI Driver (as Red Hat tells us it's just a matter of driver coding) ?
If Yes, is there an existing roadmap or a currently existing driver version with this feature implemented ?
Is there any applicable workaround for this case ?
As mentioned by phone, we’ll quickly create an helpdesk ticket for this.
, Additional Info: { Sales Order Number: 00000}
For clarification I think they mean that they are using Operator version 1.6.  Not CSI Driver for Unity 1.6.  This is often confused.  According to the 1.6 releases this supports OpenShift 4.9:
https://github.com/dell/dell-csi-operator/releases
To me it looks like RWX is supported:
https://dell.github.io/csm-docs/v1/csidriver/
Ext4 and FC look supported:
Thanks,
Frank
Frank Gasho
Senior Engineer | Primary Storage Integrated S/W
Dell Technologies | ISG Support Services
1-800-945-3355 EXT. 6278222
<EMAIL_ADDRESS>Hopkinton, MA, USA (GMT-5)
My work schedule is 9:00 am ‒ 5:00 pm ET, Monday – Friday
Need assistance outside of my working hours?
ProSupport<PHONE_NUMBER>
https:/www.dell.com/support/incidents-online/en-us/contactus/dynamic [nam10.safelinks.protection.outlook.com] [nam10.safelinks.protection.outlook.com]
My Manager is<EMAIL_ADDRESS>Internal Use - Confidential

Customer is ok to close this as per the internal jira tracking. Hence closing this.


How to obtain the current playing song using a command?

A musikcube user opened a feature request https://github.com/hykilpikonna/hyfetch/issues/364 to display musikcube's current playing song on neofetch. How can I obtain this information using one command?

How can I obtain this information using one command?

I think the best solution for now would be parsing of playerctl metadata. Something like:
playerctl metadata --format "Now playing: {{ artist }} - {{ album }} - {{ title }}"

https://github.com/altdesktop/playerctl


support for html angular

No support for HTML(angular) templates

@cpt-agemman thanks for the suggestion.
The Register Additional Grammar (Experimental) section in the package setting provides a solution.
Please do the following

open your template then do command Editor: Log Cursor Scope
copy the first list item in the notification dialog: Scopes at Cursor
open package setting pane of ide-html
paste the copied grammar at the input of Register Additional Grammar (Experimental)
restart Atom

BTW what's the grammar of your angular templates? I am considering including it to default setting.

Closing as I use VS Code, and Atom has been flagged as EOL.


Batch Script Encoding

@SFuhrmann commented on Sun Sep 30 2018
A hint on the right encoding of the setup.bat file would be nice.
I ran into the issue that the PowerShell script was not executed. In the log file on the local Service Fabric Cluster Node it said "powershell.exe was not found" etc. I spent a lot of time trying to find out why the SF Node did not find the powershell.
The problem was: The setup.bat was encoded as UTF-8 with BOM. These were interpreted by the command line as well, resulting in the wrong command. I could only figure this out when I started the setup.bat manually and have a look at the output there, because in textfile editors the BOM were interpreted correctly again.

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 3ac102a5-e9ad-0046-f217-446f1ad263c5
Version Independent ID: a47523e2-0c30-dee4-0037-5f58836fa37f
Content: Hinzufügen eines HTTPS-Endpunkts zu einer Service Fabric-App in Azure mithilfe von Kestrel
Content Source: articles/service-fabric/service-fabric-tutorial-dotnet-app-enable-https-endpoint.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Hi team,
Please check the issue reported by the user.
Thanks!

@timlt, @tysonn can you help get this to the correct person to handle the feedback since this is not a en-us doc

@MicahMcKittrick-MSFT, you can contact @rwike77 or @TylerMSFT or @jpconnock who are the service fabric team, for follow up.

Thanks @timlt
@jpconnock, @rwike77 I assigned to you both but let me know how you want me to adjust it.

This is still happening, and saving the file without BOM doesn't seem to help either. The application host terminates unexpectedly as soon as a SetUpEntryPoint is defined and the bat executes. What's the final status of this issue? Is there a link to the github issue or a resolution?

Hi, LisandroSu.  Sorry you have run into this.  As this is a product issue, not a doc issue, I have contacted a member of our product team to let them know about the issue.

#reassign @erikadoyle

Closing, as this repo is only for documentation issues. If you still need assistance, please file an issue at https://github.com/azure/service-fabric-issues/issues. #please-close

I hit the same issue. When service fabric app is in the progress of deployment and hit the setupEntryPoint to execute Setup.bat, it throw exception "powershell.exe is not recognized as internal or external".
The content of Setup.bat is:
powershell.exe  -ExecutionPolicy Bypass -Command ".\Set-CertAccess.ps1"
If there is an problem, the doc should give the corrected contents.


We currently rely on the cosmology package which has been archived

Describe the Bug
I'm aware this is on our organisation, but if it's in active use it shouldn't really be archived https://github.com/glass-dev/cosmology
To Reproduce
import glass
...
Expected Behaviour
No response
Actual Behaviour
No response
Version In Use
N/A
Additional Context

Python version:
Operating system:

Duplicate of #124?

Duplicate of #124?

Yeah, good spot


SSR Migration, several errors

Describe the bug
I recently moved to SSR via sveltejs/adapter-auto, after dropping in my existing src folder I'm getting these errors:
* flowbite doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.
* <Any flowbite-svelte component> is not a valid SSR component. You may need to review your build config to ensure that dependencies are compiled, rather than imported as pre-compiled modules

On the second error I tried adding this lines to my config: (as per this workaround, didn't really work)
optimizeDeps: {
    include: ['flowbite-svelte']
}

but it just produces this new error:
Unknown file extension ".svelte"
Steps to reproduce the behavior:

install @sveltejs/adapter-auto
use it as the adapter on svelte.config.js
install and call flowbite-svelte components on any route
See error

Code samples
/// svelte.config.js

import adapter from '@sveltejs/adapter-auto';
import preprocess from 'svelte-preprocess';

// omitted env setup script

/** @type {import('@sveltejs/kit').Config} */
const config = {
	// Consult https://github.com/sveltejs/svelte-preprocess
	// for more information about preprocessors
	preprocess: [
		preprocess({
			postcss: true
		})
	],
	kit: {
		adapter: adapter(),
		vite: {
			server: {
				port: env.ASPNETCORE_HTTPS_PORT ? env.ASPNETCORE_HTTPS_PORT : '44447',
				https: {
					ca: certFilePath,
					key: keyFilePath
				},
				headers: {
					Connection: 'Keep-Alive'
				},
				proxy: {
					'/api': {
						target: env.ASPNETCORE_URLS?.split(';')[0] ?? 'https://localhost:44447/',
						changeOrigin: true,
						rewrite: (path) => path.replace(/^\/api/, ''),
						secure: false
					}
				}
			},
			// optimizeDeps: {
			// 	include: ['flowbite-svelte']
			// }
		}
	}
};

export default config;

Expected behavior
Call flowbite-svelte components normally without errors

Also on tailwind.config.cjs, there's this ts error
Could not find a declaration file for module 'flowbite/plugin'. '<PROJECT PATH>/node_modules/flowbite/plugin.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/flowbite` if it exists or add a new declaration (.d.ts) file containing `declare module 'flowbite/plugin';`ts(7016)

/// tailwind.config.cjs contents

const config = {
  content: [
  	'./src/**/*.{html,js,svelte,ts}',
  	'./node_modules/flowbite-svelte/**/*.{html,js,svelte,ts}'
  ],

  theme: {
  	extend: {}
  },

  plugins: [require('flowbite/plugin')],
  darkMode: 'class'
};

module.exports = config;

Regarding the error about * flowbite doesn't appear to be written in CJS, ..., it doesn't affect Flowbite-Svelte. It generates from Flowbite JS files and we don't use it.
You just ignore it for now and you don't need optimizeDeps: either.
Regarding Unknown file extension ".svelte" error, there must be an issue with your set up.
I suggest start a new project and install Flowbite-Svelte and your components on the top of that.
Is it feasible?

Okay so I removed the optimizedDeps, and ran npm run build && npm run preview, then click on any parent component I get a variant of this error:
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".svelte" for <PROJECT PATH>\node_modules\flowbite-svelte\accordions\AccordionItem.svelte
    at new NodeError (node:internal/errors:372:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:76:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:118:38)
    at defaultLoad (node:internal/modules/esm/load:21:20)
    at ESMLoader.load (node:internal/modules/esm/loader:407:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:326:22)
    at new ModuleJob (node:internal/modules/esm/module_job:66:26)
    at ESMLoader.#createModuleJob (node:internal/modules/esm/loader:345:17)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:304:34)
    at async ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:82:21)
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".svelte" for <PROJECT PATH>\node_modules\flowbite-svelte\accordions\AccordionItem.svelte
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".svelte" for <PROJECT PATH>\node_modules\flowbite-svelte\accordions\AccordionItem.svelte

My package.json looks like this:
{
	"name": "svelte-app",
	"version": "1.0.0",
	"scripts": {
		"dev": "svelte-kit dev",
		"build": "svelte-kit build",
		"package": "svelte-kit package",
		"preview": "svelte-kit preview",
		"test": "playwright test",
		"check": "svelte-check --tsconfig ./tsconfig.json",
		"check:watch": "svelte-check --tsconfig ./tsconfig.json --watch",
		"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. . && eslint --ignore-path .gitignore .",
		"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ."
	},
	"devDependencies": {
		"@iconify/svelte": "^2.2.1",
		"@playwright/test": "^1.19.1",
		"@sveltejs/adapter-auto": "next",
		"@sveltejs/kit": "next",
		"@typescript-eslint/eslint-plugin": "^5.10.1",
		"@typescript-eslint/parser": "^5.10.1",
		"autoprefixer": "^10.4.4",
		"date-picker-svelte": "^2.0.0",
		"eslint": "^7.32.0",
		"eslint-config-prettier": "^8.3.0",
		"eslint-plugin-svelte3": "^3.2.1",
		"jspdf": "^2.5.1",
		"n2words": "^1.11.1",
		"postcss": "^8.4.12",
		"postcss-load-config": "^3.1.4",
		"prettier": "^2.5.1",
		"prettier-plugin-svelte": "^2.5.0",
		"svelte": "^3.44.0",
		"svelte-check": "^2.2.6",
		"svelte-headless-table": "^0.10.2",
		"svelte-preprocess": "^4.10.5",
		"tailwindcss": "^3.0.23",
		"tslib": "^2.3.1",
		"typescript": "~4.5.4",
		"wretch": "^1.7.10",
		"xlsx": "https://cdn.sheetjs.com/xlsx-0.18.9/xlsx-0.18.9.tgz"
	},
	"type": "module"
}

its a new project where I just re-installed the same dependencies then dropped in the entire src folder (after some minor bug fixes)

If I run npm run dev, I get this:

Is it possible to share your repo?

so I tried installing it as a non-dev dependency, not my package.json looks like this:
{
	"name": "svelte-app",
	"version": "1.0.0",
	"scripts": {
		"dev": "svelte-kit dev",
		"build": "svelte-kit build",
		"package": "svelte-kit package",
		"preview": "svelte-kit preview",
		"test": "playwright test",
		"check": "svelte-check --tsconfig ./tsconfig.json",
		"check:watch": "svelte-check --tsconfig ./tsconfig.json --watch",
		"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. . && eslint --ignore-path .gitignore .",
		"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ."
	},
	"devDependencies": {
		"@hurtigruten/svelte-table": "^2.0.3",
		"@iconify/svelte": "^2.2.1",
		"@playwright/test": "^1.19.1",
		"@sveltejs/adapter-auto": "next",
		"@sveltejs/kit": "next",
		"@typescript-eslint/eslint-plugin": "^5.10.1",
		"@typescript-eslint/parser": "^5.10.1",
		"autoprefixer": "^10.4.4",
		"date-picker-svelte": "^2.0.0",
		"eslint": "^7.32.0",
		"eslint-config-prettier": "^8.3.0",
		"eslint-plugin-svelte3": "^3.2.1",
		"jspdf": "^2.5.1",
		"n2words": "^1.11.1",
		"postcss": "^8.4.12",
		"postcss-load-config": "^3.1.4",
		"prettier": "^2.5.1",
		"prettier-plugin-svelte": "^2.5.0",
		"svelte": "^3.44.0",
		"svelte-check": "^2.2.6",
		"svelte-headless-table": "^0.10.2",
		"svelte-preprocess": "^4.10.5",
		"svelte-typeahead": "^4.2.2",
		"tailwindcss": "^3.0.23",
		"tslib": "^2.3.1",
		"typescript": "~4.5.4",
		"wretch": "^1.7.10",
		"xlsx": "https://cdn.sheetjs.com/xlsx-0.18.9/xlsx-0.18.9.tgz"
	},
	"type": "module",
	"dependencies": {
		"flowbite": "^1.4.7",
		"flowbite-svelte": "^0.19.7"
	}
}

while the site looks like this:

Is it possible to share your repo?

Can't, its a migration of our system, the package works so long as its not installed as a dev dependency, from my testing, unsure why tho

So the issue was, my template was using an outdated version of SvelteKit, but updating to the latest (at the time of writing 1.0.0-next.354) introduces a bug where the vite dev server wouldn't apply the --port flag correctly and would produce a different error, so that was fun... I had to lock it to 1.0.0-next.350, then regenerate my pacakage.lock.json & delete .svelte-kit to fix the issues


add tagging and pushing released commit from internal

Resolves https://github.com/dotnet/source-build/issues/3653
Fixes issues originally introduced with https://github.com/dotnet/source-build/issues/3637
Test runs:

dry-run: build
tag does not exist: build
tag does not exist and tag push failed: build
tag exists and is referencing the correct commit: build
tag exists and is referencing the wrong commit: build

tag does not exist and tag push failed: build

I think I don't understand what flow is this testing? Why did it fail to push?

tag does not exist and tag push failed: build

I think I don't understand what flow is this testing? Why did it fail to push?

Its just the last fail-safe to make sure the tag is pushed successfully. For example if the bot would losoe write access to the repo the push would fail
The message is there just so that's instantly visible in the run UI, but can be removed (since there is no set -e failing the push would fail the step, i.e. no need to catch it)


feat(*): configuring minio with SSL certs

addresses part of https://github.com/deis/minio/issues/1

Until Helm fixes this situation, I'm okay with doing things this way. (And even then we may need this for Makefile-based builds.)

:+1:
Variable substitution would remove the need for manifest_replace.go and I would love that! I spent a while spinning my wheels on the best way to do it in a shell script before deciding it was cleaner in Go...
Also, if Helm gets generators, I'm happy to contribute a ssl-cert-gen one.

note that we've decided not to run minio with ssl for alpha. see https://github.com/deis/minio/issues/1#issuecomment-163709214


System.TypeInitializationException in CSharpMath.Rendering

When I try to use the Draw method of SkiaMathPainter :
painter.Draw(e.Surface.Canvas, 0f, 0f);

I'm getting the System.TypeInitializationException exception:
The type initializer for 'CSharpMath.Rendering.MathFonts' threw an exception.

InnerException.StackTrace:
   at Typography.OpenFont.CFF.Cff1Parser.ReadRealNumber()
   at Typography.OpenFont.CFF.Cff1Parser.ReadEntry()
   at Typography.OpenFont.CFF.Cff1Parser.ReadDICTData(Int32 len)
   at Typography.OpenFont.CFF.Cff1Parser.ReadPrivateDict()
   at Typography.OpenFont.CFF.Cff1Parser.ParseAfterHeader(UInt32 cffStartAt, BinaryReader reader)
   at Typography.OpenFont.Tables.CFFTable.ReadContentFrom(BinaryReader reader)
   at Typography.OpenFont.Tables.TableEntry.LoadDataFrom(BinaryReader reader)
   at Typography.OpenFont.OpenFontReader.ReadTableIfExists[T](TableEntryCollection tables, BinaryReader reader, T resultTable)
   at Typography.OpenFont.OpenFontReader.Read(Stream stream, ReadFlags readFlags)
   at CSharpMath.Rendering.MathFonts..cctor()

MCVE
I have no idea what's could be reason of this behaviour, maybe I miss something important. Sample from the CSharpMath.Forms.Example folder works fine to me.

It is weird...
When I type double.Parse("0.04546") in the Watch, it throws FormatException but not when I try it in the C# Interactive.

When I type double.Parse("0.04546") in the Watch, it throws FormatException but not when I try it in the C# Interactive.

Could it be different settings for culture? (for float-point separator)

The behaviour is not related to the CSharpMath, so I'll close the issue.

Just to history: #134


Track client uptime

Summary by CodeRabbit
Release Notes

New Features

Enhanced SectorsPieChart to display a user-friendly alert when no data is available.
Introduced a timer in the SettingsManager to show client uptime.
Improved error handling in MultiTickerSectorAllocation and SectorAllocation components.

Improvements

Streamlined rendering logic for various components, enhancing responsiveness and user experience.
Added consistent color assignment for sectors using a new utility function.

Bug Fixes

Resolved issues with data fetching and error management across multiple components.

@coderabbitai Can you regenerate the summary?


Add kubernetes 1.26 into nightly(integration) tests and e2e tests

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
Kubernetes 1.26 is expected to released this Week, we need add tests on running KIC on k8s 1.26 to verify the compatibility.
Proposed Solution

Add v1.26.x into kubernetes versions to test on into workflows of nightly and e2e tests.

Additional information
Blocked on kind to support k8s 1.26.
Acceptance Criteria

[ ] nightly and e2e tests include tests running in k8s 1.26 cluster.

blocked on:

k8s official release of 1.26 (now k8s has a v1.26.0 tag, but no 1.26 release)
kind supports k8s v1.26


Rename this tool "LIT Style"

After using "LIT Style" in the design doc I just wrote, my only suggestion is to make it "LIT Styler", since "LIT Style" is a little confusing on if it refers to the style guide. It kinda works if you think of it as a proper noun, ("LIT Style processes metrics"), but I keep wanting to write "The LIT Style", which doesn't work. ("The LIT Styler" does though)


Feat/redux

Redux implemented

work for : https://github.com/project-7337/rasoi-backend/issues/27 included


Weird developer organization names in generated pom

This is what the generated  entries look like:
    <developer>
      <name>Ludovic Orban</name>
<EMAIL_ADDRESS>      <organization>org.apache.maven.model.Organization@291b9a0d</organization>
      <organizationUrl>http://ehcache.org</organizationUrl>
    </developer>

Ended up checking out Gradle and there is an issue with the way you can fill a pom. It seems the system confuses the organization node inside developer which should be a String with the root organization node which is a complex object.
Found a work around and will be pushing out a PR soon. Also investigating where to report this to Gradle.


Resolve #218, Resolves kubernetes-client/python#1335

Fixed the bug from https://github.com/kubernetes-client/python/issues/1335

added exception to JWT validation
added a rule to fix the url unsafe characters
changed base64.b64decode to base64.urlsafe_b64decode for correct oidc token encoding

Codecov Report

Merging #220 (df58beb) into master (2da2b98) will decrease coverage by 1.76%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   92.29%   90.52%   -1.77%
==========================================
  Files          13       13
  Lines        1635     1636       +1
==========================================
- Hits         1509     1481      -28
- Misses        126      155      +29

Impacted Files
Coverage Δ

config/kube_config.py
78.13% <33.33%> (-5.28%)
:arrow_down:

config/dateutil.py
95.83% <0.00%> (-2.09%)
:arrow_down:

config/kube_config_test.py
95.05% <0.00%> (-0.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da2b98...df58beb. Read the comment docs.

/retitle fix problem with oidc token encoding

/assign

/remove-lifecycle stale
Thanks for the PR! Could you sign the CLA and add a unit test?

/remove-lifecycle stale


Test result attached to a different workflow that is being run concurrently

Describe the bug

I have two separate workflows with different goals. One to test Android, the other IOS
Both of these workflows are being run together when a PR is created.
Both of these workflows utilise a composite step where it prints out the results e.g.

name: "Print test results"
description: "Prints test results into github actions"

runs:
  using: "composite"
  steps:
      - name: Test Report
        uses<EMAIL_ADDRESS>        if: success() || failure()
        with:
          name: Test results
          path: ./results/*.xml    # Path to test results
          reporter: jest-junit

To Reproduce
Steps to reproduce the behavior:

Create two separate workflows that run tests and produce an XML test result
Both workflows should be triggered at the same time e.g. both should have a similar trigger like on push
At the end of the two workflows, add a step that reads those result
Check result

Expected behavior
Job should be attached to their respective workflows
Screenshots
Two different workflows

Last one does not contain the test result

First workflow to be triggered contained both the results

Additional context
I attempted to separate test results without using the custom action and explicitly added the test report script into separate workflows but still got the same issue.

No tests under Jobs: https://github.com/i2van/hourglass/actions/runs/10468117626

Two tests under Jobs: https://github.com/i2van/hourglass/actions/runs/10468062689

EDIT
It's actually random. I suspected it was due to tests outcome but it is not.
Sometimes it simply shows up in the other workflow, which is shorter and always ends first..

I experienced the same issue with different steps to reproduce, the other workflow doesn't use this action:
To Reproduce
Steps to reproduce the behavior:

Have one or more workflows running
Generate test report

Hello
I saw the same behavior too. We fire two workflows at the PR and sometimes it's appended to the other one.
But isn't this problem that we all see related to the github limitation mentioned in the readme?
https://github.com/dorny/test-reporter?tab=readme-ov-file#github-limitations
I found other github actions for TRX reports and they all mention the same. Only GitHub today "is allowed to create a check suite for each workwflow run and there is no public Check Suite API" [cit].
Take it or leave it ...

Check this line https://github.com/dorny/test-reporter/blob/main/src/main.ts#L178
where the action uses the octokit client to create the check using the sha of the commit.
Here the official API called to create the run: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run
In the body there is no mention "of the workflow" and only name and head_sha are required.
If it goes to another workflow, it's probably GitHub's fault.

Also, this has never been solved on GitHub side: https://github.com/orgs/community/discussions/24616

I can't say for sure, but I might have a workaround, give it a try and see if it works:
I added another step after the report step and now GHA is attaching to the correct workflow, it worked 3 times in a row, could be coincidence tho.
Example
- name: Test Report
  uses: dorny/test-reporter@v1
  with:
    name: Unit Tests
    path: 'test-results/*.xml'
    reporter: java-junit
    list-tests: none
    max-annotations: '50'
- name: Random step
  run: echo "Test"

@peterbrendel - that didn't work for me. In our setup the master build runs on a cron job, and the test reports get appended to the original build that was merged back into master.

I have the same issue and I suspect that the problem is somewhere here. The github API seems not used correctly as far as I can judge:
export function getCheckRunContext(): {sha: string; runId: number} {
  if (github.context.eventName === 'workflow_run') {
    // should be "event_name" ?
    core.info('Action was triggered by workflow_run: using SHA and RUN_ID from triggering workflow')
    const event = github.context.payload
    if (!event.workflow_run) {
      throw new Error("Event of type 'workflow_run' is missing 'workflow_run' field")
    }
    return {
      sha: event.workflow_run.head_commit.id,
      runId: event.workflow_run.id
    }
  }

  const runId = github.context.runId
  // should be "run_id" ?
  if (github.context.payload.pull_request) {
    core.info(`Action was triggered by ${github.context.eventName}: using SHA from head of source branch`)
    const pr = github.context.payload.pull_request as PullRequest
    return {sha: pr.head.sha, runId}
  }

  return {sha: github.context.sha, runId}
}

@ccpp are you able to confirm that this the workflow is the correct one with your patch?

No, sorry, this is untested! @lneuhaus
I even cannot reproduce the problem at the moment, probably since I switched to the artifact configuration. now the report is shown in the summary of the correct  workflow

No, sorry, this is untested! @lneuhaus
I even cannot reproduce the problem at the moment, probably since I switched to the artifact configuration. now the report is shown in the summary of the correct workflow

What exactly do you mean by switched to the artifact configuration ? I've been fighting this issue on and off for a few days thinking it was something I had done wrong only to get looking for solutions and opening the can of worms that is multiples of bugs opened for this shortcoming of GitHub's.

Hi @bt-abarber ,

What exactly do you mean by switched to the artifact configuration ?

I don't have the codebast at hand, but what I did was to save my .xml reports in artifacts, and to create a fresh job which picks up those reports using the artifact: statement.
Would be interesting if it solves the issue alsoo on your side!

Any update on a fix or workaround?

Any update on a fix or workaround?

@liyaka can you confirm that my approach works for you too ( https://github.com/dorny/test-reporter/issues/512#issuecomment-2513752995 )? Then that would be the workaround you're looking for

Unfortunately I'm still not having any luck:
name: fake_job_as_example
  workflow_call:
    inputs:
      target:
        required: false
        default: ''
        type: string

jobs:
  checkout:
    runs-on: [self-hosted, Windows]
    continue-on-error: false
    name: Checkout
    timeout-minutes: 0
    environment: my_env
    steps:
    - name: checkout
      uses<EMAIL_ADDRESS>

  build_project:
    runs-on: [self-hosted, Windows]
    continue-on-error: false
    environment: my_env
    name: Build Project
    needs: [checkout]
    steps:
    - shell: powershell
      run: get-childItem ./ -recurse | Where {$_.name -like "*.csproj"} | dotnet build $_

  job_name:
    runs-on: [self-hosted, Windows]
    environment: my_env
    name: Job 1
    needs: [build_project]
    if: ${{ !cancelled() }}
    steps:
    - name: Run Tests
      shell: powershell
      run: dotnet test ./job_1.csproj --logger "trx;logfilename=job_1.trx" -v n --no-build --no-restore MSTest.Parallelize.Scope="ClassLevel"
     - name: Run Tests 2
      shell: powershell
      run: dotnet test ./job_2.csproj --logger "trx;logfilename=job_2.trx" -v n --no-build --no-restore MSTest.Parallelize.Scope="ClassLevel"
    - name: Archive results
      if: success() || failure()
      uses: actions/upload-artifact@v4
      with:
        name: test_results
        path: ./TestResults/*.trx

test_summary:
    needs: [job_name]
    runs-on: [self-hosted, Windows]
    name: Test Summary
    environment: my_env
    if: ${{ !cancelled() }}
    steps:
        - name: Generate test summary
        uses<EMAIL_ADDRESS>        with:
            name: Test Summary
            artifact: test_results
            path: "TestResults/*.trx"
            only-summary: 'true'
            reporter: dotnet-trx
            fail-on-error: true
            list-tests: 'failed'
            list-suites: 'all'

Files are made in to an artifact as expected, the test_summary job opens them, sees them and generates its reports but the files are still attached to the first instance of the commit for the workflow.

@bt-abarber OK I guess I cannot help then. Last time I used this in a project it seemed to resolve the issue for me.
Sharing shortened for readability, essentially looks just like your setup. You could try changing to the specific version 1a288b62f8b75c0f433cbfdbc2e4800fbae50bd7 that was needed for our team to get NUnit working:
name: Build
on: [push, workflow_dispatch]

jobs:
  merge_conflict_check:
    (...)

  build_uwp_pass1:
    (...)
    steps:
      (...)
      - name: Test Project
        run: .github/workflows/run-tests.ps1

      - name: Upload Test Results
        uses: actions/upload-artifact@v4
        with:
          name: Test-Results
          path: TestResults
        if: always()

    (...)

  check_test_result:
    name: Test Report
    needs: build_uwp_pass1
    runs-on: ubuntu-latest
    steps:
      - name: Test Report
        uses: dorny/test-reporter@1a288b62f8b75c0f433cbfdbc2e4800fbae50bd7
        with:
          name: Unity Test Results
          artifact: Test-Results
          path: ./*.xml
          reporter: dotnet-nunit
          fail-on-error: true
(...)


Convert alias value to PX

I added the capability, to have aliases for the spacing, but it also needs to be converted to pixels, if its a number. So it can be defined the same as without aliases:
e.g.
export const space = {
  none: 0,
  0: 0,
  xxs: 2,
  1: 2,
  xs: 4,
  2: 4,
  s: 8,
  3: 8,
  m: 16,
  4: 16,
  l: 24,
  5: 24,
  xl: 32,
  6: 32,
};

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #245   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines         184    184
=====================================
  Hits          184    184

Impacted Files
Coverage Δ

src/space.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d902b7...beb5e0d. Read the comment docs.

Thanks for the PR and sorry for the delay! Would you mind adding some unit tests for this functionality?

Yeah, the tests are failing because of an upstream change in jest – I can push a separate PR to get those passing again

In that case, feel free to merge this or wait for the upstream fix :)


add --publish option to push subcommand

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 27.79%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

main.go
0
7
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
254

Relevant Lines:
914

💛  - Coveralls


Property 'mergeStyle' does not exist on type 'IntrinsicAttributes & MarkdownProps & { children?: ReactNode; }'.

When using the mergeStyle prop using Markdown as in this example,
          <Markdown style={stylesMd} mergeStyle={true}>
                  {itemState.content}
          </Markdown>

a linting error is displayed claiming that
Property 'mergeStyle' does not exist on type 'IntrinsicAttributes & MarkdownProps & { children?: ReactNode; }'.
The program itself works fine, but it may be helpful to prevent this from showing.
I'm using VSCode.

Hmmmmm, is this to do with the typescript defs do you think?

I'm actually unsure. Sorry.

can you please test something for me
can you please delete this file - node_modules/react-native-markdown-renderer/src/index.d.ts
and tell me if the error vanishes?

Yes, it does. Also, by adding mergeStyle?: boolean; to MarkdownProps the issue is fixed. I'll submit a pull request.

Super, 6.0.1 released with the fix
Thanks @realToadtoad !


Add Missing Integration Tests for existing React code for BFF

Basic tests to ensure that aggregate components get rendered with expected data
Per #115, use Puppeteer.
(e.g. we load a resource template in the editor, and the Editor, ResourceTemplate, PropertyWrapper, Property, PropertyValueConstraint components (etc) all have data from the selected resource template)
e.g.

[ ] Editor page has sinopia header
[ ] Editor page has sinopia footer
future
[ ] clicking in starting points menu brings up appropriate resource template form
[ ] resource template form has appropriate fields and buttons
[ ] modal form with lookup does the right thing
[ ] modal form shows text fields appropriately
etc. ?

Perhaps similar to our list of original integration tests for the BFE?

Closing in favor of more specific testing tickets.


NTR - Popbio: egg & larva collection, species assay result

Mentioned at semantic harmony meeting today.
VectorBase label: collection of eggs
VEuPath label: egg specimen collection process
definition: An arthropod specimen collection process in which the arthropods are in the embryo stage.
parent: aquatic arthropod specimen collection process
VectorBase label: collection of larvae from traps
VEuPath label: larval specimen collection process from traps
definition: An arthropod specimen collection process in which the arthropods are in the larval stage and a trap is used to collect the specimens.
parent: larval specimen collection process
VectorBase label: species assay result
VEuPath label: organism identification datum
definition: A data item that is the specified output of an organism identification assay.
parent: data item

In release; closing.

In release; closing.


Workspace size double during first use (query time init)

Hello,
I have large dataset. My workspace is 27GB after indexing (I have sent. embeddings, token embeddings and metadata).
But after first inference init workspace grows to 53 GB which is totally strange.
I have
annlite==0.3.5
jina==3.6.9
Any clues why this is happening?
Thanks

There is something wrong with loading the indexer from the disk which will double the workspace, we are trying to fix this, thanks for pointing it out.

Thank you,
do you have any update on this ?
Thanks

@tommykoctur We are working on it. The patch will be released by Tomorrow.

@tommykoctur Hi, we have released a new version to fix this issue. Please try it again.

HI @numb3r3 @jemmyshin thank you for your effort.
I have installed:
pip install git+https://github.com/jina-ai/annlite.git@b602acce8f7f2ac085f9cbccae6fadeee1ebcb85
I can confirm that it works, and workspace is not double, it is slight increase and some new files are there.
Before:
27G     workspace/cell_0
27G     workspace

Now (with the same dataset):
1,3G    workspace/snapshot-4578fd099e1f6581d36464d45b50131e/2022-08-23#22:31:25-SNAPSHOT
1,3G    workspace/snapshot-4578fd099e1f6581d36464d45b50131e
4,0K    workspace/parameters-4578fd099e1f6581d36464d45b50131e
27G     workspace/cell_0
28G     workspace

Is this correct behaviour ?

I have noticed that first inference load is very slow tens of minutes for such a big dataset, but after those snapshots are calculated another start is very fast.
I like it.

Yes, we will create some snapshots and it will load the indexer from these files so it will be faster.

Great thank you. Very good job. !


Independent connectors for grouped shapes

Watch video to understand - https://youtu.be/KkHsvHZ7vwY
It would be nice to connectors for groups

Hi,
What browser version and drawio version are you using? (can be seen under Help)
Basically, you would like to have blue arrows shown when a group is hovered?
And please attach the diagram file so it can be tested.
Regards,

Hello,
Draw.io (Web version)

Browser

Diagram
https://drive.google.com/file/d/1gWKCaVAx8jMdNw6b8wUXWxUmQJzxrMom/view?usp=sharing
Yes I would like to have connectors for groups. And it should also work with Expand/Collapse of "Organization shape"
Thank you.


Build Linux wheels in Docker container for manylinux2010 compatibility

This changes the maturin build process in CI to allow compatibility with manylinux distributions that are older than the host system. It follows the recommendations from the maturin documentation and builds the Linux wheels inside a Docker container provided by pyo3.
This of course introduces some platform-specific logic, as only Linux builds are affected. A potential solution to reduce the number of these platform-specific code paths could be to use cibuildwheel, but you have to decide that for yourself.
I took the liberty to add an upload-artifact step to the CI build so that the built wheels can be downloaded and manually tested. If you want me to remove it, I can do so.
This fixes #10.

This of course introduces some platform-specific logic, as only Linux builds are affected. A potential solution to reduce the number of these platform-specific code paths could be to use cibuildwheel, but you have to decide that for yourself.

I think we should switch to https://github.com/messense/maturin-action so that we are also able to add build for aarch64 later

That sounds like a good idea a well. Is that more of a long term plan or do you want to do it instead of this PR?

That can be for later, I want to do a release this week

Thanks


TP-149 Refactor geographical areas list

Summary
Refactor geographical areas to be more  inline with  the designs
Screenshots

Not quite sure what we want to do with the tests in this PR, I don't want to remove them if they provide value, because geoarea-ui-detail is going to re-appear in the next one anyway. They are breaking the tests currently however, so i've  ended  up commenting them out.

@NDevox Anything else that you can see?

Codecov Report

Merging #191 (c96517c) into master (ffc6628) will decrease coverage by 0.21%.
The diff coverage is 74.26%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   61.82%   61.60%   -0.22%
==========================================
  Files         173      176       +3
  Lines       10470    10543      +73
  Branches      767      790      +23
==========================================
+ Hits         6473     6495      +22
- Misses       3822     3868      +46
- Partials      175      180       +5

Impacted Files
Coverage Δ

additional_codes/models.py
12.00% <ø> (ø)

common/business_rules.py
41.66% <0.00%> (+0.68%)
:arrow_up:

footnotes/tests/bdd/test_edit_footnote.py
48.88% <ø> (-2.18%)
:arrow_down:

measures/import_handlers.py
11.69% <0.00%> (+0.06%)
:arrow_up:

measures/querysets.py
10.00% <0.00%> (ø)

quotas/validators.py
8.69% <ø> (+0.69%)
:arrow_up:

regulations/models.py
8.42% <0.00%> (ø)

regulations/serializers.py
3.30% <0.00%> (ø)

urls.py
60.00% <ø> (ø)

measures/business_rules.py
25.36% <16.66%> (+0.07%)
:arrow_up:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8498593...38ecf28. Read the comment docs.


Update monitoring-the-sdn-manager-and-dialog-listener.md

Docs Build status updates of commit 743c8d6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/monitoring-the-sdn-manager-and-dialog-listener.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore(buildpacks): update heroku-buildpack-python to v78

See https://github.com/heroku/heroku-buildpack-python/compare/v77...v78 and deis/deis#4977

I tested this with the workflow-beta1 chart and example-python-django and example-python-flask.


feat: support set and show time zone

What did
Support to set and show timezone information for date-time, to keep consistency with dbaas.
Preview
Local time: 12:00 UTC+8:00，DBaas timezone: UTC+0:00

Related doc: https://day.js.org/docs/zh-CN/manipulate/utc-offset

Codecov Report

Merging #1393 (c965898) into master (6764ed5) will decrease coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
- Coverage   29.44%   27.59%   -1.85%
==========================================
  Files         128       93      -35
  Lines       10516     9972     -544
  Branches       99        0      -99
==========================================
- Hits         3096     2752     -344
+ Misses       7240     7040     -200
  Partials      180      180

Flag
Coverage Δ

be_unit_test
27.59% <ø> (ø)

e2e_test
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6764ed5...c965898. Read the comment docs.


feat: Add expiry to oauth arguments for refresh

Currently the oauth flow does not do refreshes if the access token is expired, as Credentails() does't know when the access token expires, so it completely skips refreshing.
Credentails() will only refresh when a expiry datetime object is passed, so here we add an oauth argument for expiry, and pass it to Credentails().

@JichaoS thanks for the PR!
I've only used a service account so I'm not familiar with this flow. Can you help me understand how this works, does the library do the refresh automatically if you provide the expiry parameter? I wasn't able to easily find this in their docs. It sounds like currently the tap would fail if the token expired mid sync, is that right? So after this PR merges, if a expiry is provided, the sync would start and if the token expires mid run it will refresh itself and continue. Is that true or will it only do it on initialization?

@pnadolny13 ty for the review!

does the library do the refresh automatically if you provide the expiry parameter?
Yes exactly

tap would fail if the token expired mid sync
I suspect that's the case, but haven't tried it out. FWIW the code here suggests that is the case: https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/transport/requests.py#L552

The case I'm targeting is getting the library to refresh the token when handed an already-expired access token along with a refresh token. The library currently tries to use the access token, and gets back an error saying the oauth token is invalid, even if the user provided a refresh token (and other refresh credentials)

The case I'm targeting is getting the library to refresh the token when handed an already-expired access token along with a refresh token. The library currently tries to use the access token, and gets back an error saying the oauth token is invalid, even if the user provided a refresh token (and other refresh credentials)

@JichaoS that makes sense, I'm fine with your approach but had another crazy idea, curious what you think - I wonder if hardcoding (or defaulting) the expiry parameter to always be in the past would work. Then the user doesnt need to add a parameter and the token is always assumed to be expired and the refresh flow kicks off. What do you think? Am I missing a piece of how this works?

This should now be resolved by https://github.com/MeltanoLabs/tap-google-analytics/pull/159. The access token is not needed when a refresh token is provided.