Merge pull request #1 from dangdangdotcom/master

update

update

Coverage remained the same at 85.445% when pulling 631b939dafe32dffd7d9a83049ffb98b803083e1 on sam2099:master into 4b9b8c8d301c9f1a62c42c1c0c399358b0dcc159 on dangdangdotcom:master.

Coverage remained the same at 85.445% when pulling 631b939dafe32dffd7d9a83049ffb98b803083e1 on sam2099:master into 4b9b8c8d301c9f1a62c42c1c0c399358b0dcc159 on dangdangdotcom:master.


Speed up project management page

The project management page loads all project data even when we just need to show a selected project's info.
This PR makes two changes:

When a project is selected, we do not load all projects data. This speeds up the page loading.
When no project is selected, we continue to load all projects. So the page speed remains the same!

Coverage remained the same at 94.433% when pulling 5fc51e5ae25829b083cd8df37ebd6dd5d37708d1 on fix-project-screen-loadtime into 457c0a2719b9a2983d1e78107853827ded4e5552 on main.


Checkbox component - Warning: Failed prop type because of missing icon

When using the Checkbox component, a warning: Failed prop type: invalid prop type name of value 'ios-checkmark-outline' is thrown with the latest version of @oblador/react-native-vector-icons.
Looks like the icon in question was renamed to ios-checkmark-circle: https://oblador.github.io/react-native-vector-icons/
When using CRNA (with Expo), the current version of @oblador/react-native-vector-icons (as expo/vector-icons) is automatically used, so I had to change the Native Base code for Checkbox manually for now.

Mind walking me through how you changed it manually @cseelus ? Many thanks for your help and time.

@juanorellana13 Go to your projects node_modules folder and find the native-base folder. In there, you need to change ios-checkmark-outline to ios-checkmark in the following files:

src/basic/icon/NBIcons.json:678
dist/src/basic/icon/NBIcons.json:678
src/basic/Checkbox.js:48
dist/src/basic/Checkbox.js:1
dist/src/basic/Checkbox.js.map:1

Thats what I did and it works in iOS Simulator as well as in the iOS app I built and tested via Apple Testflight.

That did the trick @cseelus. Once again, thank you.

#2368

I have updated to 2.8.1 and still this issue persists.
The only difference i have is I'm using the expo  icon wrapper @expo/vectoricons 8.0.0

Yep, this still very much the case for 2.8.1, can to manually rename from ios-checkmark-outline to ios-checkmark


chore: homepage content nits

I thought the Brisa website could have some improvements. This PR is a proposal to make it a bit more appealing, and consistent.
Happy to hear your feedback!

@gariasf The initiative is good, but for the moment I don't approve of it, there are several things that don't convince me.
I recommend that you divide the PR, the spelling mistakes without changing styles on one side and the styles on the other. For the moment my disapproval is in the styles.

It seems to me good to change the emojis from unicode to SVG, but they would have to be well integrated for all the devices and I would add the icons of the sections below.

There shouldn't be a case where it doesn't do a wrap but the order is the wrong way round, you will probably have to change the media query. Now the 2 sections with this screen size have a different order than before. Besides, the icon looks very small. It needs to be integrated.
About the font family, I am not convinced to change it. I had a hard time finding one that was easy to read, we were using https://fonts.google.com/specimen/Inter

why do we delete the image?

why did we remove the padding on the video caption?

I saw it more attractive with the emojis.... 😕
nit: Brisa is not a "projec" is a "project" 😉

These are all my thoughts on seeing it. Nevertheless, the initiative is good, and thanks for all the input. Perhaps here it would be good for others to give their opinion of the changes, CC:  @danielart  @AlbertSabate @adriablancafort

Reviewed the comments about the emojis. And I can give my thoughts on that. In my opinion emojis are not unprofessional when used with moderation, I think it gives a young and friendly vibe to the project.
I also asked Chat GPT for opinion, and this is what it told me:

In regards of the spaces on the landing, I agree it could be better padding and margins needs more work. Contrasts I'm not a designer, can't help here :)

In general, I think we should be mindful about the impression that is put out there regarding Brisa. In the end, what matters is the tool itself, that's true. With that said, a landing page is also marketing and first impressions matter.

I'll leave it with just my rephrasing nits. Can you please review?

Thanks for that contribution @gariasf


Add precise seek

cc @mthrok
Implements precise seek and seek to any frame in torchaudio

For testing correctness, using binary files as reference is not a sustainable approach for the following reasons;

Binary files are not browsable. Inspecting it requires writing a script, which is tedious and error-prune.
The binary files are not always possible to re-create in the future.
It looks like that decoded reference frames are checked-in. This means, it was decoded by some decoder implementation, which can be different from the decoder used during the test. Different decoders might produce the different result, even if the test logic is correct.
It increases the size of source distribution.

Therefore, in torchaudio, we check-in binary files only when it's absolutely necessary. I think checking-in an AVI file might be necessary to test for ANY seek. (see below)
As an alternative, what we can do is to check whether the decoded frames after seek match frames decoded without seek.
The gist of the logic is;

decode the entire video and store the frames as reference.
for each seek test, decode frames after seeking and compare the resulting frames against reference frames by extracting the corresponding part.

For example, the video file at test/torchaudio_unittest/assets/nasa_13013.mp4 has (only) two key frames; at the beginning and at 8.08 second (which is 203rd frame from the beginning). See the analysis here. (this was obtained with ffprobe test/torchaudio_unittest/assets/nasa_13013.mp4 -print_format 'csv' -select_streams v:0  -show_entries frame=pict_type,key_frame,pict_type,pkt_pts_time,pkt_dts_time,best_effort_timestamp_time,pkt_duration_time)
Using this information, we can check whether the seek is working fine by slicing the reference frames at the index that corresponds to the seek timestamp.
The following code snippet implements such test logic.
import torch
import torchaudio
from torchaudio.io import StreamReader

src = 'test/torchaudio_unittest/assets/nasa_13013.mp4'

# Using the first video stream (which is not default video stream)
stream_index = 0

# Decode all frames for reference
s = StreamReader(src)
s.add_basic_video_stream(-1, stream_index=stream_index)
s.process_all_packets()
ref_frames, = s.pop_chunks()
print(ref_frames.shape)

def test(mode, seek_time, ref_indices):
    s = StreamReader(src)
    s.add_basic_video_stream(-1, stream_index=stream_index)
    s.seek(seek_time, mode=mode)
    s.process_all_packets()
    frame, = s.pop_chunks()
    print(frame.shape)

    hyp_index, ref_index = ref_indices
    torch.testing.assert_close(frame[hyp_index:], ref_frames[ref_index:])

configs = [
    # Test keyframe seek
    # The source video has two key frames the first frame and 203rd frame at 8.08 second.
    # If the seek time stamp is smaller than 8.08, it will seek into the first frame at 0.0 second.
    ("key", 0.2, (0, 0)),
    ("key", 8.04, (0, 0)),
    ("key", 8.08, (0, 202)),
    ("key", 8.12, (0, 202)),

    # Test precise seek
    ("precise", 0.0, (0, 0)),
    ("precise", 0.2, (0, 5)),
    ("precise", 8.04, (0, 201)),
    ("precise", 8.08, (0, 202)),
    ("precise", 8.12, (0, 203)),

    # MP4 decoder does not really support ANY.
    # we need an AVI file. Perhaps we check-in an AVI?

]

for conf in configs:
    print(conf)
    test(*conf)

We need to test, the combination of audio and filter graph, in addition to the script I shared above, but I think testing video-only seek behavior is enough for this PR.

@mthrok Thank you for the suggestion, I think it makes total sense.
I added the tests and a avi video to test the "any" seek behaviour. My only issue is that with "any" seek I can only test equality for the i-frames. I will add some tests for delta frames to make sure they are different.

@mthrok Thank you for the suggestion, I think it makes total sense. I added the tests and a avi video to test the "any" seek behaviour.

Thanks. Regarding the new video, I am not comfortable to check-in this video for privacy reason as it contains a minor with face, even if the copyright allows to copy it. Could you replace it with something else? Perhaps convert the nasa_13013.mp4 into AVI format?

My only issue is that with "any" seek I can only test equality for the i-frames. I will add some tests for delta frames to make sure they are different.

For any seek that produces rubbish frames at the beginning, by spec, there is no reference we can have for these beginning frames. Those are like NaN values we cannot compare against anything. So  I don't think we can test the beginning frames, and we should not compare them against anything.

Note: follow-ups

test more cases where filters are involved, check the imprecation to other streams (such as audio)
cache the timestamp in filtergraph/sink object so that tiemstamp computation is only done once instead of every time a frame is processed.

@jdsgomes I looked into the issue with the tutorial. The root cause is that the AVFrames returned by AVFilterGraph does not have the same time_base / pts as the input frames. (pts starts from 0 and time_base corresponds to the output frame rate.) I searched for a way to fetch the relevant information from AVFilterGraph struct, but it does not seem there is a way. Therefore it is difficult to apply discard mechanism on AVFilterGraph. So I think we can discard frames after decoder, which is what you were suggesting originally. I tested it and it passes tests and tutorial builds fine.


Only validation experiment

This PR was opened according to https://github.com/intel/openfl/issues/236 and https://github.com/intel/openfl/issues/191

If only validation task was given, we do not split it into two ones. For now we leave only aggregated_model_validate task and change rounds_to_train variable to 1
Fixed message output when get_best_model or get_last_model method was called to provide more info about returned model

Jenkins please retry a build

Jenkins please retry a build


fix: validation processor prints [object Object] in log output

Description
Wrote a failed Validation() handler during Dashies today & got something like this as an error:
Action failed with error: [object Object]

which, was... not that helpful.
This PR expands the validation-processor's error output to make it serialize an error before printing  (so it can be properly read in the log output).
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@dba7eb1). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage        ?   83.21%
=======================================
  Files           ?       23
  Lines           ?      727
  Branches        ?      123
=======================================
  Hits            ?      605
  Misses          ?      114
  Partials        ?        8

Flag
Coverage Δ

pull_request
83.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Autoformat code before saving

It's a must-have if we're talking about IDE-like experience.

It seems like not all LSP servers support formatting. For example, pyright, LSP server for Python, doesn't support formatting. Instead, Python projects rely on CLI tools like black, autopep8 or ruff. Before any implementation we need to think about how to install and run these CLIs. One option is to run them on host but I think it violates the whole concept of isolated dev envs, so I would prefer if we installed formatting tools in devcontainers.
Another question is how to support different formatters. I think it would be nice if Hide users could specify formatter as part of their project configuration along with the formatter settings. On top of that, Hide could autodetect formatters based on the familiar configuration files in the repo.


DOC: POD syntax fixes in doc/man1/openssl-cmp.pod.in

@DDvO, I've a question re the SYNOPSIS.

Put the command name there, like the others do.

Put the command name there, like the others do.

Thanks, but I'm not entirely sure that it's as evident as I believe, and would like to hear from @DDvO if that was the intent, or if more work is needed.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Put the command name there, like the others do.

Thanks, but I'm not entirely sure that it's as evident as I believe, and would like to hear from @DDvO if that was the intent, or if more work is needed.

Thanks @levitte for pointing out this problem and asking what the intention was.
The idea was to structure the large number of CLI options.
It looks like this is not really supported for (the given implementation of) POD files.
Having a closer look I found that also many other apps have problems here,
at least those having a - meanwhile deprecated -  -engine option.
I've provided a not very nice but working solution for that in #12932; please switch over to there for any further discussion.

I don't really understand why those added empty lines help

PODs are read in paragraph mode, which means that:

For this one, the whole paragraph, including the explaining text, was interpreted as the item instead of item + explaining text:

=item B<-no_proxy> I<addresses>
List of IP addresses and/or DNS names of servers
not to use an HTTP(S) proxy for, separated by commas and/or whitespace
(where in the latter case the whole argument must be enclosed in "...").
Default is from the environment variable C<no_proxy> if set, else C<NO_PROXY>.

So the mapage output result (surrounding text added) became:

      -proxy [http[s]://]address[:port][/path]
          The HTTP(S) proxy server to use for reaching the CMP server unless
          no_proxy applies, see below.  The optional http:// or https://
          prefix and any trailing path are ignored.  Defaults to the
          environment variable "http_proxy" if set, else "HTTP_PROXY" in case
          no TLS is used, otherwise "https_proxy" if set, else "HTTPS_PROXY".

      -no_proxy addresses List of IP addresses and/or DNS names of servers
      not to use an HTTP(S) proxy for, separated by commas and/or whitespace
      (where in the latter case the whole argument must be enclosed in
      "..."). Default is from the environment variable "no_proxy" if set,
      else "NO_PROXY".
      -path remote_path
          HTTP path at the CMP server (aka CMP alias) to use for POST
          requests.  Defaults to any path given with -server, else "/".

The other one:

  cd /path/to/openssl
  export OPENSSL_CONF=openssl.cnf
=begin comment
  wget 'http://pki.certificate.fi:8081/install-ca-cert.html/ca-certificate.crt\
        ?ca-id=632&download-certificate=1' -O insta.ca.crt
=end comment
  openssl genrsa -out insta.priv.pem
  openssl cmp -section insta

Resulted in this manpage output:

         cd /path/to/openssl
         export OPENSSL_CONF=openssl.cnf
       =begin comment
         wget 'http://pki.certificate.fi:8081/install-ca-cert.html/ca-certificate.crt\
               ?ca-id=632&download-certificate=1' -O insta.ca.crt
       =end comment
         openssl genrsa -out insta.priv.pem
         openssl cmp -section insta

Merged
6600baa9bb6e59be91692791a6251c172a099a65 DOC: POD syntax fixes in doc/man1/openssl-cmp.pod.in


Internal Server Error on overview page

puppetboard is returning a 500 error when attempting to access the overview page for all environments.  For example, the following URL results in an error.
https://puppetboard.example.com/*/
Accessing the same page for a specific environment works without any errors.
The logs show what appears to be a puppetdb error however there have been no changes made to the puppetdb configuration.
uwsgi[2097]: DoesNotComputeError: java.lang.Exception : No access from client <IP_ADDRESS> allowed

See issue 566 for a probable solution to this issue.  I have a feeling the config file changes will fix the access issue.

See issue 566 for a probable solution to this issue. I have a feeling the config file changes will fix the access issue.

Looks like the solution posted in #566 does stop the errors.  Thanks for the help.


Option to disable other mods' configs

A config option (json-only maybe?) to hide the configs of other mods it provides support for would be nice, mainly because I am concerned about the sustainability of it.

excuse me, could you please elaborate what is meant to be solved in this issue ? i read it a few times and couldn't understand

got it , thanks :+1:


Update Fault Node Status to RUNNING on Experiment Start

Fixes #4724
Proposed changes
Previously, fault node statuses in ChaosEngine events often remained stuck at INITIALIZED during experiment execution, resulting in inaccurate state reporting. The update introduces refined status transition mechanisms to ensure precise tracking and reporting of ChaosEngine states, specifically addressing transitions from INITIALIZED to RUNNING.
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[X] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Hi @andoriyaprashant, can you check broken pipelines?

subscriber build is failing can you check?

subscriber build is failing can you check?

Okay I'll take a look and fix it


Simplify the implementations of hasOrd and hasEq

Description
This simplifies the implementation by relying on a generalization of the IsTypeable dict
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[x] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

@TimSheard another nice trick!

@lehins there is a bug in fourmolu - it's suggested change does not have the same meaning as the original code and fourmolu knows this. However, the CI still fails.

there is a bug in fourmolu

@MaximilianAlgehed Can you report it as a bug?
It can either be a bug in ormolu or fourmolu, so you'd need to try applying a snippet using latest versions of both of those tools and report it on the appropriate repo, I suspect it will be ormolu, since that's the package responsible for getting the source AST and majority of the formatting decisions.
Should be as simple as downloading the ormolu binary from the repo release and applying it to the snippet that has the semantic broken by it.

This is the specific error that I got on commit 897a6dd:
@@ -443,6 +443,6 @@
    MaybeR (repHasInstances -> ia) -> requireInstances ia
    GenR (repHasInstances -> IsTypeable) -> IsTypeable

- lubIs :: ((c a, c b) => c (f a b)) => Is c a -> Is c b -> Is c (f a b)
+ lubIs :: (c a, c b) => c (f a b) => Is c a -> Is c b -> Is c (f a b)
  lubIs Is Is = Is
  lubIs _ _ = Isn't
@@ -458,6 +458,6 @@
  lubInstances (Type eq_a ord_a) (Type eq_b ord_b) =
    Type (lubIs eq_a eq_b) (lubIs ord_a ord_b)

- requireIs :: (c a => c (f a)) => Is c a -> Is c (f a)
+ requireIs :: c a => c (f a) => Is c a -> Is c (f a)
  requireIs Is = Is
  requireIs _ = Isn't

  AST of input and AST of formatted code differ.
    at libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs:446:11-33
    at libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs:446:39-[7](https://github.com/input-output-hk/cardano-ledger/actions/runs/6236465538/job/16927825935#step:4:8)0
    at libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs:461:15-2[8](https://github.com/input-output-hk/cardano-ledger/actions/runs/6236465538/job/16927825935#step:4:9)
    at libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/TypeRep.hs:461:34-53
  Please, consider reporting the bug.
  To format anyway, use --unsafe.

I checked the issue tracker over at the fourmolu repo and a very similar issue has been marked as resolved https://github.com/fourmolu/fourmolu/pull/342. Before I go digging around with this - are we sure we are using the latest version of fourmolu in this repo or are we on a version from before this fix?

are we sure we are using the latest version of fourmolu

Good point. We are not. I'll submit a PR in a moment that updates it. So, you might be able to remove this commit https://github.com/input-output-hk/cardano-ledger/pull/3735/commits/d2daee739c59be077fd454ae27fe2fd81ef671ef

Good point. We are not. I'll submit a PR in a moment that updates it. So, you might be able to remove this commit https://github.com/input-output-hk/cardano-ledger/commit/d2daee739c59be077fd454ae27fe2fd81ef671ef

@MaximilianAlgehed Just in case you didn't notice #3742 fixed the issue with outdated version of fourmolu

@lehins that updated version of fourmolu doesn't appear to have fixed the issue. Perhaps the fix hasn't been released yet? I can put back the work-around for now with a note to follow this up in the future.

I can put back the work-around for now with a note to follow this up in the future.

Before putting workarounds, I'd suggest verifying the problem is not fix and submitting an issue with a reproducer case on fourmolu or ourmolu repo, depending who's responsible for the problem

@lehins https://github.com/fourmolu/fourmolu/issues/374

@MaximilianAlgehed could you rebase this on master? We've had a PR merged.
FYI, now that you have write permissions to the repo, if you create branches on this repo, instead of a fork, I'd be able to do rebases for you right in the github UI, which would remove this inconvenient friction.

Yes, I'll build my future PRs on this repos origin


Cleanup

Some cleanup and refactoring on the configuration.

I get the following error when attempting to build, but in general I think the code looks good! The below could be related to my local configuration:
ERROR: The project name '.settings' must not start or end with a '.'. Set the 'rootProject.name' or adjust the 'include' statement (see https://docs.gradle.org/6.0.1/dsl/org.gradle.api.initialization.Settings.html#org.gradle.api.initialization.Settings:include(java.lang.String[]) for more details).

Looks great!

./gradlew build builds the project without any errors
./gradlew test runs all unit tests, which are all passing


How to Acknowledge a Specific Vulnerability

I want to acknowledge CVE-2018-15664 ( as it's presently a zero-day ) and only can continue the Jenkins build. What is the recommended way to do so? I haven't located the correct documentation describing the procedure.

Hi Jared,
Thank you for your input. We support this functionality in our commercial product (Aqua CSP) - allowing our customers to acknowledge security issues so that they won't block the next scans.
For the microscanner, you can try parsing the JSON/HTML result and exclude the CVE from the results.
Amit Bismut,
Product manager @ Aqua


Using  statement evaluated as a function(e.g. f.bind()) inside v-on handler doesn't work

Version
2.5.21
Reproduction link
https://codesandbox.io/s/vq4rx8pzk7?module=%2Fsrc%2FApp.vue
Steps to reproduce
Use method with bind()(e.g. someMethods.bind(this)) in v-on handler
<button v-on:click="handleButtonClick.bind(this);">not working</button>

What is expected?
When the event triggered,  the registered method handler should be called.
What is actually happening?
The registered method is not called. some.Methods.bind(this) is recognized as simple inline statement.

It's expected. Vue will invoke the handler for you only if you provide a property path or a function literal.
https://github.com/vuejs/vue/blob/0ed0aad77228b95e9a61a87386736938837527f8/src/compiler/codegen/events.js#L99-L106
BTW, You don't need to call bind because methods are already bound to the component instance, unless you mistakenly used arrow functions.


Fix false failures with trivy config scan

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d169cb8) 51.94% compared to head (c63da6a) 51.94%.

:exclamation: Current head c63da6a differs from pull request most recent head cb5229f. Consider uploading reports for the commit cb5229f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1652   +/-   ##
=======================================
  Coverage   51.94%   51.94%
=======================================
  Files          42       42
  Lines        4911     4911
=======================================
  Hits         2551     2551
  Misses       2210     2210
  Partials      150      150

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move Footnotes to the Bottom and Re-Index Footnote are not working with 500+ footnotes

I tried these two functions of the Linter plugin with 500+ footnotes and it didn't work.

Most likely related, I also noticed that the linter seems to break Obsidian when I use it in a bigger document. (In my case, it was only a dozen or so of footnotes). I am not entirely certain what causes the issue, though.

Thanks for your information, Christ. In my case, the Obsidian froze, and I needed to restart the Obsidian, so I didn't know which one was the cause (move footnotes to bottom or re-index footnote).

Thanks for your information, Christ. In my case, the Obsidian froze, and I needed to restart the Obsidian, so I didn't know which one was the cause (move footnotes to bottom or re-index footnote).

Now, I remember that I also tried Chris's templater code to move the footnotes to the bottom (with the same doc), and it worked. When I tried the Linter's re-indexing footnotes, the Obsidian froze again.

Now, I remember that I also tried Chris's templater code to move the footnotes to the bottom (with the same doc), and it worked. When I tried the Linter's re-indexing footnotes, the Obsidian froze again.

Im having trouble reproducing, can you share a file that crashes?

I had deleted the file, but I just made a new one with 108 footnotes, and didn't work either.
Here is the file. Thanks!
Linter-Footnote Testing.md


Error installing puppeteer npm package after buildpack during build

Hi @jontewks ,
Having an issue getting the buildpack and the npm package to install correctly at build.

Running node 10.6.0 on Heroku-18 stack
Added puppeteer-heroku-buildpack (its listed first in my buildpacks)
puppeteer 9.1.1 is a dependency in my package.json

When the build sequence starts, it installs this buildpack, and associated dependencies. Then it installs my npm packages, and fails when installing puppeteer.

I tried adding clearing the build cache, and adding the PUPPETEER_SKIP_DOWNLOAD config var. This makes the build succeed, but then puppeteer throws an error on launch and says that chromium isn't installed. I also tried downgrading to puppeteer5.5.0 and the same error as above. Any ideas?

This is pretty odd, definitely never seen it before. Have you tried creating a new project on heroku just using the same repo? I've had that fix issues that seemed like a cache problem but clearing the cache hadn't fixed it.

Haven't heard back in a long time. Feel free to comment if this is coming back up, or comment with how you resolved it for any future people running into the same thing, thanks!

Sorry for the late reply - I ended up building a new project. Was originally trying to set this project up so that it would all be part of our API and run as a separate process from a chronic job, but I ended up just making a separate app for this. its possible it was a caching issue or incompatibility with another package or configuration detail, but the issue is resolved for now! thanks.


Logic for disabling course notifications

Includes stub UI that is only visible if PUSH_NOTIFICATIONS flag is
enabled.

Starts adopting an environment passing pattern for dependencies. The
architectural goal is for the OEXRouter to be responsible for injecting
view controller dependencies. This way each controller is isolated.

JIRA: https://openedx.atlassian.net/browse/MA-607

@hanningni please review

:+1:


Method to delete local cache

If you're processing a lot of data in a loop and want to reclaim disk space after you're done with one path, then it could be helpful to have a way to delete the locally cached file. I don't think this should cause any problems because other methods that use the cache will check if it exists and download.
Currently, one can do this with cloud_path._local.unlink() but it would be better to have a method in the public API for this.

Consolidated to #10


pull request for e2e test at 12/31/2016 14:45:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add option to mount Docker socket inside container

There should be a label to mount the Docker socket inside the container automatically so tools which require Docker can be installed with Whalebrew.
For example, Docker Compose has a shell script which runs Compose as an image and mounts the Docker socket.
It should also ask permission.

Hey have you seen #36? I've just updated the description to make it simpler.


Possible regression when using vkCmdCopyImage

I've encountered a difference between vulkansdk-macos-<IP_ADDRESS> and vulkansdk-macos-<IP_ADDRESS> where using vkCmdCopyImage will result in an image of only black pixels in the more recent version. I came across the issue when experimenting with screenshot functionality.
I've adapted Sascha Willems' screenshot example into a minimally reproducible example. The screenshot code that includes the call to vkCmdCopyImage can be found here. In this function supportsBlit evaluates to false on the macOS devices I tested which appears to be expected behaviour.
I wondered if it was related to #908 but the target  image memory is specified as VK_MEMORY_PROPERTY_HOST_COHERENT_BIT.

It seems that in MVKCmdCopyImage<N>::encode, when source image is a swapchain image, this call:
id<MTLTexture> srcMTLTex = _srcImage->getMTLTexture(srcPlaneIndex, _dstImage->getMTLPixelFormat(dstPlaneIndex));

does not ultimately call the overriden MVKSwapchainImage::getMTLTexture. Tomorrow I'll look closer into a fix.

I tested the fix with my project and it now works as expected. Thanks for the fast turnaround @js6i and @billhollings.


Introduced NotificationData to abstract and simplify the extraction of AEPPushTemplatePayload

Simplified the construction of AEPPushTemplate classes using NotificationData interface
instead of two constructors1. constructor(Map<String,String>)
2. constructor(Bundle)

to ->init(NotificationData)

Renamed a few pushTemplate properties
notificationBackgroundColor -> backgroundColor
expandedBodyTextColor -> bodyTextColor
carouselLayoutType -> carouselLayout
carouselOperationMode  ->  carouselMode

Changes the signature of the method
NotificationManager.createNotificationChannelIfRequired(
    context: Context,
    channelId: String?,
    customSound: String?,
    importance: Int,
    isFromIntent: Boolean)

to
internal fun NotificationManager.createNotificationChannelIfRequired(
    context: Context,
    template: AEPPushTemplate)

Removed the IntentKey Constants used for building notification
Use the RemoteMessage keys for Intent notification
Created the following method for easier building Intent for notification. The intent will have all the required fields for rebuilding the notification

override fun createIntentWithAction(action: String): Intent

Rather than having objects PushTemplateIntentContants which is public and PushTemplateConstants which is internal, can we refactor to have a parent public objects PushTemplateConstants with one internal object having non public constants another public object with public constants?

Fixed the following things in my latest commit:
Edited log statements (better indentation for readability)
Add getRequiredString field
Map,Intent Data as internal classes
add getImportance in AEPPushTemplateClass
payload version as String
Remove fromIntent Boolean from Template Constructor
Add actionName to IntentData class
Make CarouselPushTemplate class constructor protected


It seems impossible to enter either the @ or ! symbol in a document

Pressing @ and ! call the markdown:link and markdown:image keybindings, which on the one hand seem to do nothing (nothing happens to the marked text), but on the other, make it impossible to actually enter these characters in the document.
Interestingly I just tested _,* and ~ and they seem to both modify the text while at the same time entering the character, so while it allows to enter those characters, we also get a spurious character.
So highlighting bold and pressing * gives bold*. A solution would probably be to enter one less character at the end of the word, although that doesn't work with removing the effect.

Try reloading Atom
On Thu, 3 Nov 2016 at 06:07, laughingrice<EMAIL_ADDRESS>wrote:

Pressing @ and ! call the markdown:link and markdown:image keybindings,
which on the one hand seem to do nothing (nothing happens to the marked
text), but on the other, make it impossible to actually enter these
characters in the document.
Interestingly I just tested _,* and ~ and they seem to both modify the
text while at the same time entering the character, so while it allows to
enter those characters, we also get a spurious character.
So highlighting bold and pressing * gives bold*. A solution would
probably be to enter one less character at the end of the word, although
that doesn't work with removing the effect.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/burodepeper/language-markdown/issues/154, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADiC6iZqIZL59xs5mF9FQ_H1NIYgsV-0ks5q6Wv-gaJpZM4KoAgt
.

Thanks, my bad, I should have caught this one.

No problem. It seems to be an issue with Atom itself when adding certain
new stuff to a package in an update. Have reported the issue to them a
while back, but to no avail yet.
On Thu, 3 Nov 2016 at 06:16, laughingrice<EMAIL_ADDRESS>wrote:

Thanks, my bad, I should have caught this one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/burodepeper/language-markdown/issues/154#issuecomment-258066076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADiC6tI1cqevgdHHpjYtQ_zrz64QG2IFks5q6W5DgaJpZM4KoAgt
.


Memory leak - anonymous subclass of TimerTask

com.xxx.digital.views.activities.HomeActivity has leaked:
* GC ROOT java.util.Timer$TimerImpl.<Java Local>
* references com.daimajia.slider.library.SliderLayout$3.this$0 (anonymous subclass of java.util.TimerTask)
* references com.daimajia.slider.library.SliderLayout.mContext
* leaks com.xxx.digital.views.activities.HomeActivity instance

My fragment code:
public class ImageSliderFrag extends Fragment {
  private SliderLayout mSlider;
  public void stopAutoPlay() {
        if (mSlider != null) {
            mSlider.stopAutoCycle();
        }
    }

    @Override
    public void onStop() {
        Log.w(TAG, "onStop");
        // To prevent a memory leak on rotation, make sure to call stopAutoCycle() on the slider before activity or
        // fragment is destroyed
        stopAutoPlay();
        super.onStop();
    }
}

Hi ericn37,
Did you find any solution for this memory leak.

Hi @HasanShaikh , it was a false alarm for me. Memory leak only happens when I run the app directly from my computer i.e. the app was running, then I click "Run" in Android Studio, thus abruptly terminated the previous app "session".
The memory leak has never occured otherwise


add instructions on how to run blog locally

Can we add instructions on how to run the blog locally, in the blog repo.
As an example, I have this for Data Umbrella, that came with the template.  Not that I have been unable to get my own blog running locally.
https://github.com/data-umbrella/data-umbrella.github.io#installation
Some instructions on what needs to be installed and getting it running will be helpful for folks.

Done!


Missing function fetch_nightly_tarball required for pypy-latest

The commit c8ab429d7b0990d901494f9bcd95f6baa5cc51af removed the function fetch_nightly_tarball
These recipes use install_nightly_package:

plugins/python-build/share/python-build/pypy-c-nojit-latest
plugins/python-build/share/python-build/pypy-c-jit-latest

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31459939-missing-function-fetch_nightly_tarball-required-for-pypy-latest?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).

I tested all the urls in the pypy-c-jit-latest, the compressed file itself has the same name as in the url, but the uncompressed folder has the actual commit, so the recipe won't work by just adding install_nightly_package back.

Additionally build_package_pypy_builder has python hardcoded, this could be either python 3 or python 2, if it's python 3 the installation will fail:
/tmp/python-build.20160229180917.22779/pypy-dev /tmp/python-build.20160229180917.22779 /mnt/extra/third_party/python/pyenv
  File "rpython/bin/rpython", line 17
    print __doc__
                ^
SyntaxError: Missing parentheses in call to 'print'

Gimme PRs

For RPython's Python issue, there is a workaround in pyenv-install which will find some Python 2.7 from pyenv. Obviously it will not work with bare python-build, though.
https://github.com/yyuu/pyenv/blob/a6f1f480eb6e607d2e5a012873bc7737737dd97f/plugins/python-build/bin/pyenv-install#L203-L224

Thanks!


Write a C program to print numbers from n to 1 without using a loop

Description
Write a C program to print numbers from n to 1 without using a loop
Input  : 5
Output : 5 4 3 2 1

How to contribute

Save the solution in program/PrintNumbersFromNTo1WithoutUsingALoop.c file
Add PrintNumbersFromNTo1WithoutUsingALoop.c file in print-numbers-from-n-to-1-without-using-a-loop folder

i can solve it
plz assign it to me

Hey @mdArshad10,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


Update command prefixes

Updated User Guide for new prefixes

Pull Request Test Coverage Report for Build 168

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.586%

Totals

Change from base Build 160:
0.0%

Covered Lines:
1894

Relevant Lines:
2068

💛  - Coveralls


Added KnitFile2Synapse.R code to knit an Rmd file and upload it to synap...

...se by creating a synapse entity (if doesn't exist) and populate the wiki with markdown.

Thanks Thanneer! But there is already a file with the function you have - we should sit and do the merge together.
Can you submit another pull request that only has the change to use a separate hook for plotting, and then we'll figure how to incorporate your improvements?

Need to do a separate pull w/ only the hook (hook_synapseMdSyntax_plot.R), and then rename the file to knitfile2synapse.R so it can be merged with the existing.


Enhancing docker-machine ip to support multiple host arguments

Fixes #999
Signed-off-by: Dave Henderson<EMAIL_ADDRESS>

Why not use  runActionWithContext like start and stop commands do?  This logic is already implemented there.

@nathanleclaire - that's exactly why this is still a WIP ;)
I looked at runActionWithContext for inspiration, but there was some reason I thought I couldn't use it. I'll give it another shot with that :)

Oh yeah, I remember now... runActionWithContext is geared towards methods that don't return anything  other than an error. But I think I might be able to work around that by wrapping the GetIP() call...

@nathanleclaire - PTAL - have I done this sanely? :)

Looks like you've definitely got the right idea - how about adding a GetIP method to Host like the way the others are done?  You should be able to take the closure that you have almost verbatim for this.

Oh, and also, let's just call the action "ip" for consistency's sake - unless I'm mistaken, they map directly to the commands that you invoke on the CLI.

Yeah, ok that sounds better... :)

Ok, this time I think I like it. I'm going to work on some tests, and get some documentation worked out now.

Nice.  Code LGTM

@nathanleclaire - ok, I've added some tests and docs, and squashed. I think this is done now - PTAL :)

LGTM!  Appreciate you taking the initiative on the test and doc.

cc @ehazlett for review

LGTM


[chart]KeyError in Bar Chart if value is null

Starting from version 1.0.1 Bar chart graph stopped working if one  metric value is null.
I have a metric so defined:
AVG(indicatore) FILTER (WHERE codlivterr = '15' and selezionato = 1) AS "Italia selezionata"
if the result is null I obtain this error:
KeyError: "['Italia selezionata'] not in index"
I had to modify in:
coalesce(AVG(indicatore) FILTER (WHERE codlivterr = '15' and selezionato = 1),0) AS "Italia selezionata"
Up to v. 1.0 null values were accepted.
DB is PostgreSQL.

Closing in favour of #13968


Error when saving Protocol skins with level set lower than 5

Updated VIM to v1.2, configured 3 sheriff skins to randomize, when I click X/Save on the sheriff window VIM throws this error:
2023-05-12 14:05:13,707 [ERROR] VIM_errors: ----- EXCEPTION -----
2023-05-12 14:05:13,708 [ERROR] VIM_errors: Traceback (most recent call last):
  File "src\server.py", line 126, in ws_entrypoint
  File "src\inventory_management\profile_manager.py", line 116, in update_profile
TypeError: unhashable type: 'dict'

I think it might have something to do with the Protocol skin as I've only gotten the error when Protocol is added to the randomize pool Seems to be caused by the Protocol skins when they are set at a level lower than 5. Screenshot below shows the settings I have selected right before the error.

https://github.com/colinhartigan/valorant-inventory-manager/releases/tag/v1.2.1


[Task] <In the Documentation Contribution Guidelines, add the Documentation Writing Guidelines>

Description
Nowadays, there is no standardization of document writing, we can use [Docs]https://github.com/ruanyf/document-style-guide] as a guide to standardize the use of documents.
@tomsun28 @zhangshenghang @zqr10159, how do you think?
Task List
No response

hi we already has the markdown lint check https://github.com/apache/hertzbeat/blob/master/.markdownlint-cli2.jsonc , it is also a standardization of document writing.

hi we already has the markdown lint check https://github.com/apache/hertzbeat/blob/master/.markdownlint-cli2.jsonc , it is also a standardization of document writing.

I think they are different. The format check of md is aimed at the fixed md writing format. And what is in the link is the content. I think they can compare it to ci checking the style of the composition. The function of this link is how to write a more vivid composition.

I looked at the above document, it can be recommended as a best practice, it cannot be used as a requirement to constrain everyone, I think format check still uses markdownlint-cli2.jsonc, You can improve the configuration rules of markdownlint documents to make the documents more standardized.

I looked at the above document, it can be recommended as a best practice, it cannot be used as a requirement to constrain everyone, I think format check still uses markdownlint-cli2.jsonc, You can improve the configuration rules of markdownlint documents to make the documents more standardized.

yep, That's what I mean, use him as a best practice guide, not a mandatory requirement, and refer to it when writing.


Support custom anomaly threshold

Task Overview

Currently all anomalies are calculated statistically with a fixed global threshold (it's configurable with a var called anomaly_score_threshold, its default is 3). In some use cases it's better to define a more / less sensitive threshold based on the underlying dataset. Currently all the monitors are implemented as dbt tests and therefore the ideal solution would be to provide an additional test parameter that could receive this custom anomaly threshold for a specific test. If this parameter was not provided to the test, the the default should remain as it's configured with the global var 'anomaly_score_threshold'.

Design

There are three main files where the test macros are implemented - test_table_anomalies.sql, test_column_anomalies.sql and test_all_columns_anomalies.sql (please note that currently there is some code duplication in these files and in the future we will probably fix it).
All of these test macros should receive a new parameter (defined at the end) with a default value 'none', called 'anomaly_threshold'.
Then each test should pass this value to the macro 'get_anomaly_query'
If the received value of this param is none, the code in 'get_anomaly_query' macro should use the macro elementary.get_config_var to get the global var 'anomaly_score_threshold' and use its value instead (this is the behavior today).
Then the anomaly query should use this param (or the global value of the var anomaly_score_threshold) to determine if there is an anomaly or not (look for 'where abs(anomaly_score)')

Hey @oravi I've attempted to start the implementation in https://github.com/elementary-data/dbt-data-reliability/pull/26 - happy to incorporate any feedback

Added by @Ecalzo in version 0.3.16 of the package.
Thanks @Ecalzo 🌟


add metadata field to TrackHandle

Closes #24.  Untested but should work theoretically.  Does not solve the issue of storing extra data into the handle

Thanks!


Geode Crashing on Android32

Geode Issue

[X] I confirm that this crash is NOT related to a mod but directly to Geode Loader itself.

Platform
Android32
Geode Version
Latest as the time of writing
Mods Installed

Steps to Reproduce
Navigate menus, modify the settings of mods, change color settings of mods, go to downloads, search for mods, and much more I don't know about, and be using a Xiaomi device of the Redmi series ig, use the 32bit version of GD (crashes have a good chance of happening however on my system (Xiaomi Redmi 13C) however this may be different for other systems
Crash Report
The latest update doesn't store them
Additional Information
No response

I'm on Android64 now and so far things are better

Nvm I don't know if a mod caused it anyways things are better on Geode 3.0.0 so I'm closing this for now


MINOR: Fix typo

Thanks for the PR, but please have a look at contributing.md and make the changes are per it.

Sure thanks.
I made the changes.


[Statie] Nicer error messages

When generating static output, an exception often came out to me with a message like this:
Unexpected token ',' on line 2.
But from the message I couldn't tell which file is affected, only that it happened when compiling latte templates.
Could it nicely print out at least a filename, which had been processed when the exception was thrown, please?
Thanks for a great tool!

Thanks so much. After seeing your frustration, I wanted to create this issue myself. Sorry for that.
Could you send me list of use cases, that created these errors? I recall these:

comma in any neon format text

either *.neon file
or file data (between --- and `---)

No problem, it's better to be frustrated two days during the implementation than to have cancer from a CMS and an FTP access :)
I don't remember, honestly, I think this particular error was shown due to the comma in *.neon files and it was the most frustrating one.
But there were other (not so cryptic) errors that could also benefit from having the original filename and line number printed out next to them. For example, when using a non-existing or null variable in a foreach loop.

Found nice use case just now:

Motivation++ :+1:

Probably wrap NeonDecoder https://github.com/Symplify/Symplify/blob/master/packages/Statie/src/Configuration/Parser/NeonParser.php#L24

Done!

Thank you, @TomasVotruba, for preventing people from getting cancer!

Oh yea!
"Open source - creating and fighting cancer together!"


changeEffect/setEffect/clearGraphEffects

changeEffect G, N    # G = ColorEffect | FishEye | Whirl | Pixelate | Mosaic | Brightness | Ghost
setEffect G, N
clearGraphEffects

G = ColorEffect, Brightness is important.

v1.0.0 only support: ColorEffect, Brightness


Single response from array in top hits aggregation fails to deserialize

NEST/Elasticsearch.Net version: 5.5.0
Elasticsearch version: 5.6.8
Description of the problem including expected versus actual behavior:
I have a top hits aggregation, which returns a single nested object.
.Aggregations(a => a
                .Nested("global", gb => gb
                    .Path("locations")
                    .Aggregations(a2 => a2
                        .Terms("locations", l => l
                            .Field("locations.name.keyword")
                            .Aggregations(a3 => a3
                                .TopHits("locationHit", th => th
                                    .Size(1)
                                )
                            )
                        )
                    )
                )

I then try to retrieve the top hit:
        var globalLocations = searchResponse.Aggs.Nested("global").Terms("locations");

        foreach (var globalLocation in globalLocations.Buckets)
        {
            var locationResults = locationHit.Hits<Document>();
        }

This causes the following error:
Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'System.Collections.Generic.List`1[MyObject+Location]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.
To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object.
Path 'hits[0]._source.locations.coordinates', line 1, position 589.
The json for locationResults is:  (locations isn't an array, though it is mapped as nested)
{{
  "_index": "documents",
  "_type": "document",
  "_id": "9cd79253703ad1b588d8bec827bc696230a4dac9",
  "_nested": {
    "field": "locations",
    "offset": 0
  },
  "_score": 1.0,
  "_source": {
    "locations": {
      "coordinates": {
        "lat": 37.63983154296875,
        "lon": -123.173828125
      },
      "sizeInKm": 84.83842089198464
    }
  }
}}

The Location class looks like this:
        public class Location
        {
            public string name { get; set; }
            [GeoPoint]
            public GeoLocation coordinates { get; set; }
            public double sizeInKm { get; set; }
        }

and it is nested within a Document:
        [ElasticsearchType(Name = "document")]
        public class Document
        {
            ....
            [Nested]
            public List<Location> locations { get; set; }
            ....
        }

@carasel would you be able to provide the complete JSON response to the request you're making (obfuscate any data that shouldn't be posted publicly)?

Closing due to lack of response.


Can't enable available checker?

Not sure why but I can't get this to work.
I have pep8 installed and in the $PATH but syntastic won't apply checks? It's available but it's not running it to report syntax errors.
This is the relevant part of my vimrc
let g:syntastic_python_checkers = ['pep8']
let g:syntastic_c_checkers = ['gcc', 'make']
let g:syntastic_ruby_exec = '~/.rvm/rubies/ruby-2.0.0-p0/bin/ruby'

Here's the relevant portion of :SyntasticInfo
Syntastic version: 3.6.0-57 (Vim 704, Darwin)
Info for filetype: python
Global mode: active
Filetype python is active
The current file will be checked automatically
Available checkers: pep8 python
Currently enabled checkers: -

running :SyntasticCheck doesn't do anything either. I feel like it's a simple fix but I don't see what it is. Thanks!

Do you have other plugins that mess with syntastic configuration, such as Eclim or YouCompleteMe?  Your version of syntastic is pretty old, more recent versions can detect that kind of problems (well, most of them) and warn you about it.

okay well at least I'm not crazy. let me try updating it and get back to you

Alright, running :PluginUpdate isn't getting me any progress, same problem. However I do have YCM installed and working. I know the two might conflict.
How can I force an update of syntastic to see the updated error messages? (because tbh I love syntastic too much to let it go)

How can I force an update of syntastic to see the updated error messages?

:PluginUpdate sounds like a Vundle command.  I'm afraid my knowledge about Vundle is mostly theoretical, so perhaps ask on some Vundle-related forum?  Syntastic itself doesn't really care how you install it.

@DavidAwad did you ever get this fixed? I'm having the same problem with ESLint

@Someguy123 Please open a new issue.
I had js_checkers instead of javascript_checkers (Got confused by my previous attempt at using jsx_checkers, which didn't work so I had to switch to ESLint)


The radius

Hi, I was looking into your code, and I guess overlap is the radius or diameter of the hard spheres?

Hello, in the isoverlap functions the "overlap" variable indeed denotes the diameter of the hard spheres. For this reason, if the distance between two sphere centroids is less than their diameter, then they will register as overlapping (they are then rejected by the Monte Carlo sampling)

Thank you


Drag and drop ordering ?

Hello ! Nice tool 👍
Is it possible to add ordering by drag and drop system ?
I can work on this feature if it pleases 😄
Thanks !

I'd like that too if you can !

Hi @xonlly,
Unfortunately, this is an SVG chart. And SVG doesn't have drag and drop event. However, You can add this feature to the task list.
Something like this https://dhtmlx.com/docs/products/dhtmlxGantt/

@MaTeMaTuK any news on the drag-and-drop?
Is there any way we can pass an onDrag handler to the component?

@xonlly any update about drag and drop task list? have you completed this feature.


Investigate BOM stripping in URLs

Via Fiora on twitter: https://pastebin.com/c0aJhuVQ seems goo.gl strips BOMs and causes issues... We should really use our own shortener...but see if there's a work around, maybe?

The Pastebin is unavailable

Oh, good point. I hadn't realised it would time out.... :(  I guess we'll hang on for another report. Closing for now.


feat(Bounties): create loading skeleton

we should do something different for the posted page when the user is not logged in, not sure wha the behavior should be
don't allow clicking on the tab?
show a login prompt on the page?
show a simple "you must be logged in to see your posted bounties"?

Disabling the tab will make it feel broken to some people.
Directly prompting the user may not be what they want (assuming you mean the Alby prompt).
I vote for showing a message with a button for the user to log in.


GNU license should be added as well

This library is based on VideoCompressor by lalongooo which in turn is based on Telegram. So this library should include the GNU license as well.

@samirshrestha OK got it. Thanks for the feedback

@samirshrestha, Its done.
Thanks


spec: clarify sequencing of function calls within expressions

The program below tests the order-of-evaluation semantics of return *p, f(p). With gccgo, it prints 0 (i.e., evaluating *p before calling f(p)), and with cmd/compile it prints 2 (i.e., evaluating *p after f(p) returns).
But is it allowed to print 1? I.e., can *p be evaluated in the middle of f(p) being evaluated, after the *p = 1 and before the *p = 2?
The spec says simply:

For example, in the (function-local) assignment
y[f()], ok = g(h(), i()+x[j()], <-c), k()

the function calls and communication happen in the order f(), h(), i(), j(), <-c, g(), and k(). However, the order of those events compared to the evaluation and indexing of x and the evaluation of y is not specified.

I don't think there's any other text in the spec that requires evaluation of a function call to within an expression to be handled atomically with respect to other expressions either.
@griesemer and I agree only 0 or 2 should be allowed (i.e., 1 should not be allowed), but that the spec could be clearer about this.
package main

func main() {
	x, _ := g()
	println(x)
}

func g() (int, int) {
	p := new(int)
	return *p, f(p)
}

func f(p *int) int {
	*p = 1
	*p = 2
	return 0
}

FWIW, if we agree the intention is to only allow 0 or 2, I think one easy way to at least informally codify that would be to update the example from:
f := func() int { a++; return a }

to
f := func() int { a++; a++; return a }

I don't think the spec currently prevents printing 1.  And my first reaction is that I don't think it should prevent that.  I think that the language should either specify the order of evaluation, or it should not.  And right now it does not.  If f is inlined, then we have three expressions/statements to evaluate:

*p
*p = 1
*p = 2

It is clear that *p = 1 must precede *p = 2.  But there is no ordering defined between *p and the two assignment statements.  Therefore, any ordering is permissible.
We could certainly add a rule saying something like "all function calls must be fully evaluated with respect to all other operations."  But I don't think that helps people writing Go code.  This code is already indeterminate.  Making it less indeterminate, while still leaving it indeterminate, doesn't make anything clearer or easier to understand.  It would help to make it fully determined, but that isn't what seems to be suggested here.
If we don't make this kind of expression fully determined, I'm inclined to think that we should have a guideline like "if a single statement both reads and writes the same variable, and there is no order of evaluation specified between the reads and writes, then the read may observe the original value of the variable or it may observe any of the values written to the variable, and exactly which value it observes is unspecified."
(I also think we should have a vet check for statements that both read and write the same variable with no ordering specified, but unfortunately that seems like a difficult check to write.)

I don't think the spec currently prevents printing 1. And my first reaction is that I don't think it should prevent that.

Does your reasoning extend to something like *(*int)(nil) + f()? Does f need to be defensively coded because the nil-pointer-dereference panic can happen at any time within it?

Thanks, that's a plausible argument for introducing the rule "all function calls must be fully evaluated with respect to all other operations."

In practice I am not bitten by these things, but looking at examples like this makes me wonder why.
I would not be opposed to specifying ordering, especially w.r.t multiple assignments and _.

(I also think we should have a vet check for statements that both read and write the same variable with no ordering specified, but unfortunately that seems like a difficult check to write.)

+1. I think we are not far from the pointer part of the complexity for go 1.17.  Combine that with happens-before, especially with the memory model work going on, and things get harder.  Approximations can help.  Type params + pointer analysis (and  + x/tools/go/ssa) is an as-of-yet unsolved problem, at least for library code AFAIK.

In practice I am not bitten by these things, but looking at examples like this makes me wonder why.

There are occasional issue reports about it. E.g., cmd/compile and gccgo compile return x, f(&x) differently.

In practice I am not bitten by these things, but looking at examples like this makes me wonder why.

There are occasional issue reports about it. E.g., cmd/compile and gccgo compile return x, f(&x) differently.

Regarding the vet check, perhaps an approach focusing on simple patterns like this one could work. @mdempsky, how frequent is occasional in your opinion?
A more general approach relying on pointer analysis might have a false positive rate above the vet threshold.

@mdempsky, how frequent is occasional in your opinion?

Somewhere between "once ever" and "once per year". I can recall it being independently reported by at least 2 people, but I can't recall beyond that. I doubt it's frequent enough to merit a vet check.

Regarding mentioned vet check, there is a similar check in go-critic linter, I think it was added because such patterns make code less clear but the example above regarding gc and gccgo sounds not so good. CC: @quasilyte

Since TinyGo depends on the SSA package to parse Go code, this bug is also affecting TinyGo code generation.  We just hit this with real-world code.

@dgryski Can you elaborate on how this problem affects x/tools/go/ssa and TinyGo? I didn't think x/tools/go/ssa performed function inlining, so I wouldn't expect it to be affected.

Ah yes, I realize this bug is about the spec and not the SSA package.  However, the SSA package implements one version of the spec and the Go compiler seems to implement another interpretation.
Here is a small Go program with different behaviour under Go and TinyGo, but note that TinyGo is doing a faithful translation of the SSA produced by the x/tools/go/ssa (via ssadump).
~/go/src/github.com/dgryski/bug/multi $ cat main.go
package main

import (
	"strings"
)

func main() {
	s1 := "hello"
	s2, err := s1, toUpper(&s1)
	println(s1, s2, err)
}

func toUpper(s *string) error {
	*s = strings.ToUpper(*s)
	return nil
}
~/go/src/github.com/dgryski/bug/multi $ tinygo run main.go
HELLO hello (0:nil)
~/go/src/github.com/dgryski/bug/multi $ go run main.go
HELLO HELLO (0x0,0x0)
~/go/src/github.com/dgryski/bug/multi $ ssadump -build=F main.go |sed -n '/func main/,/^$/p'
func main():
0:                                                                entry P:0 S:0
	t0 = new string (s1)                                            *string
	*t0 = "hello":string
	t1 = *t0                                                         string
	t2 = toUpper(t0)                                                  error
	t3 = *t0                                                         string
	t4 = println(t3, t1, t2)                                             ()
	return

Note that if we replace main with the statements produced by SSA, we get the same result with Go and TinyGo, so the issue really is coming from the SSA package not matching Go's behaviour.
func main() {
	t0 := new(string)
	*t0 = "hello"
	t1 := *t0
	t2 := toUpper(t0)
	t3 := *t0
	println(t3, t1, t2)
}

@dgryski I see, thanks for elaborating. Yes, that's a known difference between cmd/compile and gccgo too, and I think there are other issues filed about it. Both behaviors are spec compliant, and our response to date has been that applications should not depend on which behavior the compiler implements.
I think it's outside the scope of what this issue is about though (namely whether expression evaluation can be interleaved with executing a function call's body, not merely scheduled before or after).

@mdempsky beat me to responding. I don't have too much more to add other than here is a godbolt link where you can confirm gccgo and tinygo agree on the output HELLO hello: https://go.godbolt.org/z/dPesK1T8b .

As @mdempsky said, it is users' responsibilities to avoid the unspecified behavior.
Now that code line can be written as
s2, err := strings.Repeat(s1, 1), toUpper(&s1)


Add Marathon properties to DCOS doc

Description

https://jira.mesosphere.com/browse/DOCS-1949
Urgency

[ ] Blocker
[ ] High
[x] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

@meichstedt @jdef see https://github.com/dcos/dcos-docs/blob/bededd726fca72ed2d3d65a126742b1fc7d6a3df/1.9/deploying-services/marathon-parameters.md

@meichstedt re making changes to my branch - i'd prefer to make them myself for future references. it always creates some extra work in my branch after someone else commits to it (but not a huge deal). thanks for the feedback!


Check RayCluster ray job submit can successfully create a job by running it in the head Pod

This is a subtask of https://github.com/ray-project/kuberay/issues/2310. See the parent issue for more information.
Implementation Details

Implement the EasyJobRule here with Golang.
https://github.com/ray-project/kuberay/blob/e5dc0f802e48e2c851f8de0a0736565a6340b8d5/tests/framework/prototype.py#L247-L253
Implement this check as a utility function so that other tests can use it
Add the test after this line
https://github.com/ray-project/kuberay/blob/e5dc0f802e48e2c851f8de0a0736565a6340b8d5/ray-operator/test/sampleyaml/raycluster_test.go#L90

Hi @MortalHappiness I'd like to help with this


[RFC]: Add support for IBM Spyre accelerator

Motivation.
IBM has recently announced its Spyre AI accelerator at Hot Chips 2024. This accelerator has been designed, in collaboration with IBM Research,  to scale-up enterprise AI workloads running on IBM's mainframe systems (IBM Z), as well as on IBM's Power platform. Since IBM is building our inference stack on top of vLLM, we would like to enable support for IBM Spyre within the vLLM framework.
Spyre has been designed to fit seamlessly into the PyTorch ecosystem via torch.compile. Specifically, IBM Research has developed a new backend for torch.compile that will compile torch FX graphs for execution on the Spyre hardware. In this sense, we envision that Spyre support in vLLM can work in a similar way to how the TPU support is working today (e.g., see here).
Today, there are two key limitations that affect this integration and need to be worked around. Specifically:

Spyre only supports execution of the modeling code from IBM's open-source Foundation Model Stack (fms). This is only a temporary limitation, the end-goal is that, via torch.compile, we can also run the native vLLM modeling code on Spyre. We hope that recent efforts to make vLLM models torch compilable will significantly accelerate this effort.
Spyre does not currently support paged attention or continuous batching. This means that, after prefilling a batch, we need to keep decoding until all of the sequences within that batch are finished. Our team is working to remove this limitation in the near future.

Proposed Change.
In this RFC, we propose the following sequence of PRs to enable IBM Spyre support in vLLM:

[ ] P1: Add support for single Spyre card via new SpyreExecutor class
[ ] P2: Changes to scheduling algorithm to disable continuous batching.
[ ] P3: Enable TP execution across multiple Spyre cards via MultiprocessingSpyreExecutor class.
[ ] P4: Enable paged attention and continuous batching for Spyre.
[ ] P5: Enable vLLM modeling code to run on Spyre.

While much of the work here (P1, P2, P3) has already been completed in an private fork, we plan to upstream the changes as a sequence of smaller PRs, to make the changes easier to review. Below we will discuss the planned changes from each PR step.
P1: Add support for single Spyre card via new SpyreExecutor class
We will introduce a set of classes, inheriting from the core vLLM classes, that will enable execution on a single Spyre device. Architecturally, this will look very similar to the equivalent classes that were introduced for running on AWS Inferentia (e.g., NeuronExecutor, NeuronWorker, NeuronModelRunner, NeuronCausalLM). In a similar way to how the NeuronModelRunner use the modeling code from the transformers_neuronx package, these new classes will execute the modeling code from IBM's fms package.
In the diagram below, we compare the proposed Spyre classes, with the corresponding classes that already exist for the AWS Inferentia support:

Since Spyre works via torch.compile, to ensure that compilation does not occur on the critical path (e.g., serving user requests), we need to ensure that all compilation gets triggered at init time. This PR will also introduce a routine for warming up the inference server when using the Spyre, triggering compilation of all required shapes (e.g., prompt length, number of output tokens, batch size). We will write code to ensure that batches get padded to one of the compiled shapes before execution. This behaviour is akin to what happens today in vLLM for CUDA graphs, and presumably something like this warmup will also be needed once vLLM starts using torch.compile more extensively. This could be one area to explore commonality with others parts of the codebase.
Testing: While testing on the real hardware can only be performed internally for now, we can test the vast majority of the integration on the CPU by either (a) running in eager mode or (b) by using torch compile with the inductor backend. Thus, in this PR we will also add a set of unit and integration tests to verify that everything behaves as expected. The tests will focus on the offline mode, since changes to the scheduling algorithm are needed to support online mode (see P2). We will also add a Dockerfile.spyre containing all necessary dependencies (e.g., FMS) in which the tests can be executed. Whether we could have these tests running as part of vLLM's CI/CD is something we would like to discuss.
P2: Changes to scheduling algorithm to disable continuous batching.
We need to introduce a few changes to the scheduling algorithm to workaround the lack of continuous batching support. Specifically:

We must not schedule another prefill until all decodes in the running batch are finished (one line change).
We need to introduce some logic to decide how to batch together request based on the prompt lengths and max output tokens, in order to best fit the shapes that have been compiled on Spyre during the warmup phase.

These changes must be conditional and not affect the behaviour of the scheduler on existing supported devices. They could either be applied within the scheduler itself (e.g., by checking is_spyre()) or we could try to "plug in" an alternate scheduler design? This is one of the design choices we would like some feedback on.
Testing: As part of this PR, we will also introduce tests to cover the integration with the MQLLMEngine and online operation.
P3:  Enable TP execution across multiple Spyre cards via MultiprocessingSpyreExecutor class.
We have found that the MultiprocessingGPUExecutor can be easily adapted into a MultiprocessingSpyreExecutor to enable TP execution across multiple Spyre devices in parallel. However, to reduce code duplication we propose refactoring the common code between MultiprocessingGPUExecutor and MultiprocessingSpyreExecutor into a common parent class MultiprocessingExecutor. By inheriting from MultiprocessingExecutor and a corresponding mixin class (e.g., GPUExecutor or SpyreExecutor) it should be possible to achieve the desired behaviour with very little device-specific code. Note that something along these lines already exists for the MultiprocessingXPUExecutor (e.g., see here), but the design proposed below would give more flexibility for device-specific specialization, and would also easily allow us to create multi-processing executors for all support devices if we want.
The architecture would look something like this:

Testing: We will add tests to verify that the MultiprocessingSpyreExecutor behaves as expected for tensor parallel execution when running using eager or usinginductor backend on CPU. Internally, we will run these tests against the real hardware.
P4: Enable paged attention and continuous batching for Spyre.
TBD
P5: Enable vLLM modeling code to run on Spyre.
TBD
Feedback Period.
2 weeks
CC List.
@njhill @simon-mo @youkaichao @zhuohan123 @comaniac @WoosukKwon @Yard1
Please cc anyone else as you see fit!
Any Other Things.
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Hi @tdoublep, thanks for the thorough writeup! I had some torch.compile related questions

Specifically, IBM Research has developed a new backend for torch.compile that will compile torch FX graphs for execution on the Spyre hardware

Is this a torch dynamo backend? Or does it integrate via Inductor?

This PR will also introduce a routine for warming up the inference server when using the Spyre, triggering compilation of all required shapes (e.g., prompt length, number of output tokens, batch size). We will write code to ensure that batches get padded to one of the compiled shapes before execution. This behaviour is akin to what happens today in vLLM for CUDA graphs, and presumably something like this warmup will also be needed once vLLM starts using torch.compile more extensively.

Agreed, something like this would be useful for GPUs. We want to be able to write custom inductor passes where we only apply certain optimizations depending on the number of tokens we're working with. (cc @bnellnm who is working on an inductor pass like that)
BTW: It sounds like the Spyre might require all shapes to be static, is that true?

Thanks for reading @tlrmchlsmth

Is this a torch dynamo backend? Or does it integrate via Inductor?

Thanks for reading @tlrmchlsmth

Is this a torch dynamo backend? Or does it integrate via Inductor?

The former, it integrates at the level of FX graphs.

BTW: It sounds like the Spyre might require all shapes to be static, is that true?

Right now each compile has a static prompt length and batch size, but the number of output tokens is dynamic to an extent (we still need to define some maximum). We are able to compile multiple graphs to support different cases though, and we have some logic to pad to the nearest reasonable shape (again, sort of like how CUDA graphs works today iirc).

Update from our side: we have now open-sourced the code for Spyre support on IBM's fork of vLLM:
https://github.com/IBM/vllm

Nice, looks like all the needed changes are contained in this PR https://github.com/IBM/vllm/pull/56?

@tlrmchlsmth Yes, those are the changes compared with a commit from last month. We will continue developing on the open repo from here onwards, and will be pulling in changes from upstream frequently.


Add unique file for Java

@ybyzek I changed "e.g." to "for example" and applied line wrapping.

@tikimims I made the corresponding change as well: https://github.com/tikimims/examples/pull/3/files#diff-33adfff3e88a285cf32543ed65e17d3e

Looks good!


added header html element.

Found a small bug where the html element "header" was missing

Thanks, I guess have to recheck that I didnt miss anything.


Update JDK/JRE + Gradle

Tickets addressed: closes https://github.com/NASA-AMMOS/aerie/issues/1209
Review: By commit
Merge strategy: Merge (no squash)

Description

Updates JDK/JRE to 21, as well as Gradle to 8.4.
Updates sim engine to only use virtual thread per-task executor. Removes a test that checks thread count in the sim driver since that fails with virtual threads. @Twisol
Verification

Just 👀'ing at e2e-tests
Future work

A few TODOs are now unblocked by this JDK update. (e.g. rg "TODO" | rg "21")

Manual testing has shown:

JDK 19 built models run fine on Aerie w/ JRE 19
JDK 19 built models run fine on Aerie w/ JRE 21
JDK 21 built models DO NOT run on Aerie w/ JRE 19
JDK 21 built models run fine on Aerie w/ JRE 21

So, upgrading the JRE of aerie-* container images should be backwards compatible, but mission modelers will need to hold off on upgrading to JDK 21 until their target venues are also running JRE 21.

We should also update https://github.com/NASA-AMMOS/aerie-mission-model-template as well :)

Pending a couple questions that @skovati will look into:

Can/should we replace the thread release test with something new supported by Loom?
Can we upgrade to latest gradle (now >8.4)

@Mythicaeda will test this with building the Clipper model in JDK 21

I've tested building the Clipper model against this branch. Once I was able to get the Clipper model to accept Java 21 artifacts, it compiled on J21 and simulated, although I do not do a deep dive into whether the results were the same as the version compiled on J19 using J19 Aerie artifacts.
However, in order to get Clipper to build I had to change the Clipper build process, as they specifically look for Java 19 artifacts and reject JARs compiled on other Java versions. This means that the version of Aerie that includes the J21 upgrade will be breaking to Clipper.

Merging to include with 2.4.0 release - thanks!


Meteor.logout()

I've created small app with 2 routes.
However I have a problem, In my component I have a method logout() which executes
logout(){
        Meteor.logout(()=>{
            this.router.navigate(['Auth']);
        });
    }

I am logged out, router navigates me to "Auth" component, Auth constructor is executed but ngOnInit is not. Also my view is not rendered.
But this works without problem - any reason why I have to do it?
logout(){
        this.zone.runOutsideAngular(()=>{
            Meteor.logout(()=>{
                this.zone.run(()=>{
                    this.router.navigate(['Auth']);
                });
            });
        });
    }
}

Meteor.logout's callback runs outside of the angualr2 zone, that's why changes to the UI not applied.
But what happens if you don't do this.zone.runOutsideAngular?

Thx, Alex
Yes - this.zone.runOutsideAngular - is not necessary here. Just after any Meteor method, call this.zone.run()


feat: avm/res/storage/storage-account Add additional built-in roles to Storage Module

Description
Add additional Builtin Roles to the Storage module
Closes #2698
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[X] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@Azure/alz-core-team Please can you check on the Failure above (Set AVM GitHub PR labels) and approve once resolved. Thanks! :)


Cf cell method

🚀 Pull Request
Description

This is a draft while making sure doctests pass, Also missing a whatsnew entry that will be added when moving out of draft
Finishes #4279.
The cell methods section of the cube printout was not printing in a CF-compliant manner and so this PR goes towards changing that.

Consult Iris pull request check list

Also this pre-commit failure is an easy fix - just remove the import.

Also this pre-commit failure is an easy fix - just remove the import.

P.S. you should be forewarned of this when you commit locally, so I guess you are have not installed the pre-commit tool.
There is advice here : https://scitools-iris.readthedocs.io/en/stable/developers_guide/contributing_code_formatting.html?highlight=pre-commit#code-formatting
For extra points, it would be great to know, if that does not work!

Great! I'll merge once this is out of draft


Friday Pitch Night Venue

Oct 18th 4:30pm -> 10pm TBA

I'm talking to FIREFLY restaurant on Sept 12th. They are requesting a $3000 minimum tab on food and drinks. In return, we'll have the entire restaurant inside for the event. That cost also includes catering. Drinks will be cash bar only. They have a sound system for pitches. I think we can find a sponsor or sponsors to cover the minimum.
Also, Through the Looking Glass just got back to me on Sept 11th. They can rent their space at a discounted rate, but I haven't received the cost. Their communications with me have been very slow. In this case, we'll find a sponsor to cover both the venue fee and the cost of the pizza.
I'll go with whoever can finalize their agreement first.

Through the Looking Glass has offered a discounted venue fee of $750, which is a 50% savings.
We have decided to move forward with their offer.

I've opened https://github.com/becamp/becamp.github.io/issues/19 to address the need for a sponsor to cover the venue fee.


Upgrade to latest php images.

Images in namespace https://github.com/wayofdev/docker-php-dev were significantly updated, so docker-compose and Makefile should be aligned.

Completed in https://github.com/wayofdev/laravel-starter-tpl/releases/tag/v1.7.0


1D formats for IRFs (ARF, RMF), counts vector (PHA)

I am using the OGIP format for 1D spectral analysis in Gammapy. It has, however some slight modifications, so it would be useful to have a page here that is basically a diff to the OGIP standard pages
https://heasarc.gsfc.nasa.gov/docs/heasarc/ofwg/docs/spectra/ogip_92_007/node5.html
http://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002/cal_gen_92_002.html#tth_sEc4
http://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002/cal_gen_92_002.html#tth_sEc3.1
Question: Where should this page live?
Proposal: Split at top level - i.e. IACT IRFs -> 2d IRFs. Add page: 1D IRFs
Do you agree?

+10 to document this here, especially if there are special keywords or comments to be made when doing XSPEC analysis with OGIP-formatted inputs for TeV astronomy.
My proposal would be to leave https://github.com/gammapy/gamma-astro-data-formats/tree/master/source/irfs alone for now (other people are editing the files there at the moment) and to either add a new folder source/irfs/xspec or source/xspec ... I'm not sure I'd call it 1D IRFs, the PHA files aren't considered IRFs and you want to make notes on that as well, no?
In ~ 1 week when most of the content is accumulated we can discuss proposals to re-structure it better.

@joleroi - I'll try and finish up most of the data format specs before the HESS FITS data telcon on Wednesday. Do you have time for this one and / or EDISP2D or should I do it?

I will start with the EDISP2D

Done, should I start with PHA or are you on it?

Done

Thanks!

@joleroi - I think the most tricky part is EDISP2D and RMF normalisation / interpolation, no?
Can you cross-link the EDISP2D and RMF sections, provide the formula to go back and forth, and say something about normalisation?
For PSF I tried to specify normalisation here:
http://gamma-astro-data-formats.readthedocs.org/en/latest/irfs/psf_table/index.html#normalisation
I don't think it's really useful yet.
If it's not clear what to say about energy resolution normalisation, maybe just leave a TODO for now and make a GH issue?


chiaki4deck: 1.4.0 -> 1.4.1

Description of changes
https://github.com/streetpea/chiaki4deck/releases/tag/v1.4.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2800

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2889

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2998

Result of nixpkgs-review pr 261945 run on x86_64-linux 1

1 package built:

chiaki4deck

LGTM, thanks


Fix Bug of len(holders) being 1 (no other data)

This allows script to keep running smoothly for stocks without holders information

Guys let me know when I can update yfinance via pip so as to have this within the official release rather than a local change on my machine
Thanks!

CodeFactor — 2 issues found. --> Those are existing issues and irrelevant to my changes

solved in PR #459


xFileUpload.schema.psm1: Fix Custom DSC Resource Kit PSSA rule violations

Details of the scenario you tried and the problem that is occurring
There's a number of script analyzer issues getting reported in xFileUpload.schema.psm1. These should be fixed.
Verbose logs showing the problem
[00:05:13]     Context xFileUpload.schema.psm1
[00:05:13]       [+] Should pass all error-level PS Script Analyzer rules 82ms
[00:05:13]       [+] Should pass all required PS Script Analyzer rules 356ms
[00:05:14]       [+] Should pass all flagged PS Script Analyzer rules 63ms
[00:05:14]       [+] Should pass any recently-added, error-level PS Script Analyzer rules 63ms
[00:05:15]       [+] Should not suppress any required PS Script Analyzer rules 948ms
[00:05:15] Custom DSC Resource Kit PSSA rule(s) did not pass.
[00:05:15] The following PSScriptAnalyzer rule 'DscResource.AnalyzerRules\Measure-ParameterBlockParameterAttribute' errors need to be fixed:
[00:05:15] xFileUpload.schema.psm1 (Line 23): The [Parameter()] attribute must start with an upper case 'P'. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:15] xFileUpload.schema.psm1 (Line 27): The [Parameter()] attribute must start with an upper case 'P'. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:15] xFileUpload.schema.psm1 (Line 31): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:15] xFileUpload.schema.psm1 (Line 33): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:15] For instructions on how to run PSScriptAnalyzer on your own machine, please go to https://github.com/powershell/PSScriptAnalyzer
[00:05:15] Common Tests - Custom Script Analyzer Rules will not fail unless you opt-in.
[00:05:15] To opt-in, create a '.MetaTestOptIn.json' at the root
[00:05:15] of the repo in the following format:
[00:05:15] [
[00:05:15]      "Common Tests - Custom Script Analyzer Rules"
[00:05:15] ]
[00:05:15]       [+] Should pass all custom DSC Resource Kit PSSA rules 791ms

Version of the DSC module that was used ('dev' if using current dev branch)
dev

Got this one.


Will you be planning uploading viddy to crates.io?

It would be great to be able to download it from crates.io like other Rust tools.
e.g.
cargo install viddy

@mimikun Thank you.
Viddy is available at crates.io now.
https://crates.io/crates/viddy


Non-predictable public/sitemap.xml (random order of )

Running gutenberg build several times doesn't give the same public/sitemap.xml every time.
The order of <url></url> seems to be random.

Do the sitemap urls even need to be predictable?

Probably not… It's just that the file is changing for no reason (which is polluting my diffs :grin:).
That's not a major issue, just a possible enhancement :slightly_smiling_face:

(which is polluting my diffs grin).

Good enough reason!


default backend ingress not work on another nodes

What kind of request is this (question/bug/enhancement/feature request): Question
Steps to reproduce (least amount of steps as possible):
https://rancher.com/docs/rancher/v2.x/en/installation/install-rancher-on-linux/#about-rancherd-installs
I followed the steps on these documents. I have installed this to three vm servers.(HA-Cluster)
Result:
When a create an ingress, i can only access that ingress from the first node i installed rancherd. i can't access these ingress from other two nodes. Based on a high availability structure, i need to access these ingress from all my nodes.
Other details that may be helpful: These three are only present in the first node i create, but need them in all nodes.

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5.7
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom (Hetzner Cloud VMs)
Machine type (cloud/VM/metal) and specifications (CPU/memory): VM, 4 VCpu 8 GB memory per node
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.16+rke2r1", GitCommit:"7a98bb2b7c9112935387825f2fce1b7d40b76236", GitTreeState:"clean", BuildDate:"2021-02-24T15:46:26Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.16+rke2r1", GitCommit:"7a98bb2b7c9112935387825f2fce1b7d40b76236", GitTreeState:"clean", BuildDate:"2021-02-24T15:46:26Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version): Rancherd (v1.18.16+rke2r1)

Node 1:
Architecture | amd64
-- | --
Boot ID | f318c67d-e2be-4982-a0d0-e2741569d3f6
Container Runtime Version | containerd://1.3.9-k3s1
Image | Ubuntu 20.04.2 LTS
Kernel Version | 5.4.0-66-generic
Kube Proxy Version | v1.18.16+rke2r1
Kubelet Version | v1.18.16+rke2r1
Machine ID | 85bf48ff45314b9d815a6bedce32f3b5
Operating System | linux
System UUID | 85bf48ff-4531-4b9d-815a-6bedce32f3b5

Node 2:
Architecture | amd64
-- | --
Boot ID | 8c147cbb-5406-45ec-af7d-9f8fbdef5b9a
Container Runtime Version | containerd://1.3.9-k3s1
Image | Ubuntu 20.04.2 LTS
Kernel Version | 5.4.0-66-generic
Kube Proxy Version | v1.18.16+rke2r1
Kubelet Version | v1.18.16+rke2r1
Machine ID | 41525295cb304506847a0a26629d5052
Operating System | linux
System UUID | 41525295-cb30-4506-847a-0a26629d5052

Node 3:
Architecture | amd64
-- | --
Boot ID | d6938e2b-f1d0-430a-9800-3496a160a6db
Container Runtime Version | containerd://1.3.9-k3s1
Image | Ubuntu 20.04.2 LTS
Kernel Version | 5.4.0-66-generic
Kube Proxy Version | v1.18.16+rke2r1
Kubelet Version | v1.18.16+rke2r1
Machine ID | 9143c6b0b1c34bed92b0e7b8c4f27ca1
Operating System | linux
System UUID | 9143c6b0-b1c3-4bed-92b0-e7b8c4f27ca1

I assume you might have to change the number of replicas for the components you want to run multiple times.. if I remember right - the ingress controller is running only once and is configured for host networking per default - so changing this to three replicas and running one on each host should do the trick.

@Martin-Weiss
I cannot modify any deployments managed by rancher helm.

but I saw something like this on this page(global > rke templates > add template), I guess it might be related to that

I do this override with a helmchartconfig:
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rke2-ingress-nginx
  namespace: kube-system
spec:
  valuesContent: |-
    controller:
      replicaCount: 3

yes this will make sense, but how can we make possible at least one pod running on every node?

Not sure if I understand this question right.. why should we run a replica of a pod on every node?
Is this required and if yes - why?
Ways to think about:

adjust the number of replicas based on the number of nodes?
use a daemon set instead of a deployment?
in case you want to make the service reachable on all hosts you could also use nodeport instead of host network?

@Martin-Weiss Thank you for reply.
As you said I solved it using DaemonSet. I can access nginx-controller on any node right now.
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rke2-ingress-nginx
  namespace: kube-system
spec:
  valuesContent: |-
    controller:
      kind: DaemonSet
      daemonset:
        useHostPort: true

I don't know what the DaemonSet is, I researched it when you said it.
Thank you!

@Martin-Weiss Thank you for reply.
As you said I solved it using DaemonSet. I can access nginx-controller on any node right now.
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rke2-ingress-nginx
  namespace: kube-system
spec:
  valuesContent: |-
    controller:
      kind: DaemonSet
      daemonset:
        useHostPort: true

I don't know what the DaemonSet is, I researched it when you said it.
Thank you!


Remove redundant check for loop carried dependence

Can you explain the redundancy here? I think this is the only place the LCD classification is actually run and the flag is set on the LCD edges.


[BUG] Unifi Errors

Describe the bug
I cannot seem to get Unifi to work. I keep getting the following errors:
INFO : helpers : UNIFI_SERVER_IDS : [1],
DEBUG : iniparser : ********1.248:8443 is a valid URL in module [unifi-1].,
ERROR : unifi : Could not retrieve session cookie from UniFi Controller,
ERROR : unifi : Could not get list of sites from UniFi Controller,
INFO : __init__ : Running job Every 300 seconds do thread(<bound method UniFiAPI.get_usg_stats of <unifi-1>>) (last run: [never], next run: 2019-11-06 14:00:56),
ERROR : unifi : Attempting to reauthenticate for unifi-1,
ERROR : unifi : Could not retrieve session cookie from UniFi Controller,
ERROR : unifi : Disregarding Job get_usg_stats for unifi-1

To Reproduce
Steps to reproduce the behavior:

Configure varken.ini
Start varken.ini
Check logs

Expected behavior
Varken to connect to Unifi Controller and function properly
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: Ubuntu 18.04.1, Docker latest, Unifi Controller 5.12.22 (running on Cloud Key G2+)
Varken (latest docker tag)

Additional context
I have tried all different configurations of varken.ini with the site name capitalized and lowercase, set up a new user for varken to use, also tried my normal user/password.
Also of note, my Unifi Cloud Key G2+ does not have a TLD name, so I have configured it to connect via a static IP assigned to the Cloud Key.
EDIT: Here is my config:
[unifi-1]
url = internal-ip-address:8443
username = myusername
password = myuserpassword
site = default
usg_name = rt-Unifi-1
ssl = false
verify_ssl = false
get_usg_stats_run_seconds = 300

Try setting ssl = true.
I found that out after I visited the internal-ip-address:8443/api in the browser and it gave me the following error:

Bad Request
This combination of host and port requires TLS.

Please use appropriate channels (Discord) for support. Thanks!