Add read_json and let to_json use spark.write.json

This PR proposes to use spark.write.json API to enable distributed computation when path is specified. If path is not specified, it just calls pandas' to_json as was.
Also, this PR adds read_json API.

Codecov Report

Merging #753 into master will decrease coverage by 2.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   93.91%   91.58%   -2.34%
==========================================
  Files          32       32
  Lines        5669     5679      +10
==========================================
- Hits         5324     5201     -123
- Misses        345      478     +133

Impacted Files
Coverage Δ

databricks/koalas/generic.py
96.72% <100%> (+0.72%)
:arrow_up:

databricks/koalas/namespace.py
80.79% <100%> (-1.21%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
77.5% <0%> (-7.5%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
94.53% <0%> (-1.71%)
:arrow_down:

databricks/koalas/plot.py
93.78% <0%> (-1.13%)
:arrow_down:

databricks/koalas/utils.py
97.24% <0%> (-0.69%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12990a...f813bb7. Read the comment docs.

Let me merge this. although it's a breaking change, we should use spark's API whenever possible.


Support Container Registry Auth in create_template

Is your feature request related to a problem? Please describe.
I'm using this sdk to create templates and pods.
I create tempaltes that pull private images from my ghcr. Up until now, i've used the UI and chose my ghcr auth in the dropbox provided.
However, when I try to create_template within the sdk its no possible to pass any containerRegistryAuthId or any other container registry info , therefore im unable to create templates -> pods/
Describe the solution you'd like
I would like to pass container registry auth values in create_template function.
Describe alternatives you've considered
Currently I don't see any possible alternative to schematically generate templates within the sdk.

I created that fixes that, let me know if you are interested integrating that :)

@matankley PRs are always welcome


[BUG]-getroutingports crash on display devices (inherited from TwoWayDisplay)

Command getroutingports throwe exception.
Stacktrace
470. Error: SimplSharpPro.exe [App 1] # 2021-01-06 15:19:31  # CustomApplicationCMDProcessorThread: NullReferenceException -    at PepperDash.Essentials.Core.DeviceManager.GetRoutingPorts(String s)
at Crestron.SimplSharpProInternal.SimplSharpProManager.k()
To Reproduce
have device inherited from TwoWayDisplay
issue  getroutingports  from console
issue getroutingports  to narrow down to device.
Expected behavior
It should handle devices not implemented IRoutingInputsOutputs interface and allocated OutputPorts property, such as display devices and end devices in the routing chain.
Additional context
Function: public static void GetRoutingPorts(string s) in the Essentials/essentials-framework/Essentials Core/PepperDashEssentialsBase/Devices/DeviceManager.cs  accessing OutputPorts property without checking for device implemented that interface in line 365:
var outputPorts = (device as IRoutingInputsOutputs).OutputPorts;
If device is not implementing IRoutingInputsOutputs, (device as IRoutingInputsOutputs)) is null and this is effectively (null).OutputPorts...
I believe it should be:
var outputPorts = ((device as IRoutingInputsOutputs) == null)?(device as IRoutingInputsOutputs).OutputPorts:null;

#541

#541


Fixes for #1081 - Format usage hours similar to cost

Codecov Report

Merging #1103 into master will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   75.24%   75.24%
=======================================
  Files         228      228
  Lines        4408     4408
  Branches      833      833
=======================================
  Hits         3317     3317
+ Misses        974      973    -1
- Partials      117      118    +1

Impacted Files
Coverage Δ

src/utils/formatValue.ts
78.12% <33.33%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c9609...1d33557. Read the comment docs.


Build(deps-dev): Bump eslint from 8.39.0 to 8.40.0 (#4842)

Pull request opened by the merge tool on behalf of #4842

Merged in 5d8b0a7bc61681c03456b28de076fd0b58a65f72


regfile performance improvement

Add forward paths for data and locks

@tahmeedKENJI I'll let you know when to begin once the design changes are there

@tahmeedKENJI RTL is ready

Suppose rs1_addr is 20 currently locked. But we have Unlock arriving for it in the same cycle. So instead of waiting for the unlocking, we're rerouting the rs1_data from unlock_data
I don't remember the exact pin names, but you'll be able to relate to correct name

@tahmeedKENJI are you working on this?

Yes vaiya. I'll send in the PR as soon as I'm done.

0f931e4bd02e6cd693fd0da8f82a3225a4dc691e


Assignment 04 done

Assignment Submission : Suhith Lakshmipathi Bharatam
Collab : Krishna Teja

Good job! 128 points.


Export option type

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.613%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
141

Relevant Lines:
152

💛  - Coveralls


[Feature] Line chart, or flag to prevent painting the area

Feature Description
Area chart is nice for single series. But it prevents us from display multiple series like Lightweight Charts does

Or when you want to display tick activities from Bid, Ask, Mid lines. You can't. Also it hurts performance when we want to draw real-time in fast moving session.
I know KLineChart is for KLine/Candle, but a simple flag to prevent painting the area will make KLineChart more flexible.
So by just adding a flag, or absence of backgroundColor to skip painting the area would be nice.
To Do
Add a flag like isFilled with default is true to the field area in the candle's styles
  area: {
      lineSize: 2,
      lineColor: '#2196F3',
      value: 'close',
      isFilled: false, // to disable painting area
      backgroundColor: [{
        offset: 0,
        color: 'rgba(33, 150, 243, 0.01)'
      }, {
        offset: 1,
        color: 'rgba(33, 150, 243, 0.2)'
      }]
    }

Or by not provide backgroundColor
  area: {
      lineSize: 2,
      lineColor: '#2196F3',
      value: 'close'
    }

so i discover we can set backgroundColor: [] to prevent painting the area
for multiple series, we probably need another issue


Tiny tweaks to comments in lm1b example.

CC @levskaya , trying to build some momentum with an easy PR :)

Thanks!


[stable/prometheus-operator] fix prometheus ruleSelector example

What this PR does / why we need it:
Which issue this PR fixes

fixes #8831

Special notes for your reviewer:
Commentary altered by results of discussion in #8831, I've tested examples to be working.
@vsliouniaev, could you please take a look?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped

/assign @gianrubio

/ok-to-test
@vsliouniaev could you review it?

@gianrubio looks good to me

/ok-to-test
/lgtm

Please approve once more:) Needed to bump version because got merged later than other one.


Unable to delete parameters or resource if the resource path contains (.)

Description
Can not delete the resources or resource parameters if there is a dot "." in the resource path.
Step to reproduce
Create an API with a resource path which contains a dot ".".
Try to delete the resource or a parameter.
Affected versions
2.2.0
Similar issue: https://github.com/wso2/product-apim/issues/5388

Fixed with wso2/carbon-apimgt#8063


Need to add Rabbitmq exporter to Prometheus configuration to scrape the data

I am creating custom dashboard wherein Prometheus will poll the data from rabbitmq exporter, please let me know where I can modify the Rabbitmq exporter any template to include the Rabbitmq exporter in scrape_configs.

attaching rabbitmq deployment and service:
rabbitmq deployment
`
apiVersion: apps/v1beta1
kind: Deployment
metadata:
 name: rezoomex-rabbitmq-deployment
 labels:
  app: queue
spec:
 replicas: 1
 template:
  metadata:
   labels:
    app: rabbitmq
  spec:
   containers:
    - name: rabbitmq
      image: rabbitmq:3.6.11-management-alpine
      env:
        - name: RABBITMQ_DEFAULT_USER
          value: user
        - name: RABBITMQ_DEFAULT_PASS
          value: password
      ports:
        - name: rabbitmq
          containerPort: 5672
          protocol: TCP
        - name: rabbitmq1
          containerPort: 15672
          protocol: TCP
    - name: rabbitmq-exporter
      image: kbudde/rabbitmq-exporter
      ports:
        - name: exporter
          containerPort: 9090
      env:
        - name: RABBIT_USER
          value: user
        - name: RABBIT_PASSWORD
          value: password

    # mount efs drive
      volumeMounts:
       - mountPath: /var/lib/rabbitmq
         name: rezoomex-volume
    # Node selector
   nodeSelector:
    services: other-services
   volumes:
    - name: rezoomex-volume
      nfs:
        server: fs-8f298826.efs.us-west-2.amazonaws.com
        path: /

`

rabbitmq service
`apiVersion: v1
kind: Service
metadata:
  name: rabbitmq
  namespace: default
  labels:
    app: rabbitmq-service
  annotations:
    prometheus.io/scrape: "true"
    prometheus.io/port: "9090"
spec:
  type: LoadBalancer
  ports:
  - name: rabbitmq
    port: 5672
    #targetPort: 15672
    protocol: TCP
  - name: rabbitmq1
    port: 15672
    protocol: TCP
  - name: exporter
    port: 9090
    targetPort: exporter
    protocol: TCP
  selector:
    app: rabbitmq`

Hi @abhijt-zanak Please create this servicemonitor:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: rabbitmq
  namespace: monitoring
  labels:
    app: rabbitmq-service
spec:
  selector:
    matchLabels:
      app: rabbitmq-service
  endpoints:
  - port: exporter
    interval: 10s
  namespaceSelector:
    matchNames:
    - default

For me works fine:

Thanks for the reply.
I have added service monitor, however not able to see rabbitmq endpoint in Prometheus targets, in order to take effect Do I need do any other changes at Prometheus end? or do I need to do any more changes?

The servicemonitor has to be in the monitoring namespace and you have to specify the namespace of rabbitmq in the namespaceSelector. Here is the full example that works fine for me:
apiVersion: v1
kind: Service
metadata:
  name: rabbitmq
  labels:
    app: rabbitmq
spec:
  ports:
  - name: rabbitmq
    port: 5672
    #targetPort: 15672
    protocol: TCP
  - name: rabbitmq1
    port: 15672
    protocol: TCP
  - name: exporter
    port: 9090
    targetPort: exporter
    protocol: TCP
  selector:
    app: rabbitmq
---
apiVersion: apps/v1beta1
kind: Deployment
metadata:
 name: rezoomex-rabbitmq-deployment
 labels:
  app: queue
spec:
 replicas: 1
 template:
  metadata:
   labels:
    app: rabbitmq
  spec:
   containers:
    - name: rabbitmq
      image: rabbitmq:3.6.11-management-alpine
      env:
        - name: RABBITMQ_DEFAULT_USER
          value: user
        - name: RABBITMQ_DEFAULT_PASS
          value: password
      ports:
        - name: rabbitmq
          containerPort: 5672
          protocol: TCP
        - name: rabbitmq1
          containerPort: 15672
          protocol: TCP
    - name: rabbitmq-exporter
      image: kbudde/rabbitmq-exporter
      ports:
        - name: exporter
          containerPort: 9090
      env:
        - name: RABBIT_USER
          value: user
        - name: RABBIT_PASSWORD
          value: password
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: rabbitmq
  namespace: monitoring
  labels:
    app: rabbitmq-service
spec:
  selector:
    matchLabels:
      app: rabbitmq-service
  endpoints:
  - port: exporter
    interval: 10s
  namespaceSelector:
    matchNames:
    - default

@abhijt-zanak After erasing and creating again using the above configuration, it stopped working for me also. I'll update the issue after I find the solution. It works fine with any other apps. I think I miss something.

ok, thanks for updating me.

As weird as may sound (maybe there is documented somewhere) but after changing the labels, everything works fine. I have changed the app: rabbitmq to k8s-app: rabbitmq. Deleted and recreated several times and it works. Here is the exact yaml I'm testing:
apiVersion: v1
kind: Service
metadata:
  name: rabbitmq
  labels:
    k8s-app: rabbitmq
spec:
  ports:
  - name: rabbitmq
    port: 5672
    #targetPort: 15672
    protocol: TCP
  - name: rabbitmq1
    port: 15672
    protocol: TCP
  - name: exporter
    port: 9090
    targetPort: exporter
    protocol: TCP
  selector:
    k8s-app: rabbitmq
---
apiVersion: apps/v1beta1
kind: Deployment
metadata:
 name: rezoomex-rabbitmq-deployment
 labels:
  app: queue
spec:
 replicas: 1
 template:
  metadata:
   labels:
    k8s-app: rabbitmq
  spec:
   containers:
    - name: rabbitmq
      image: rabbitmq:3.6.11-management-alpine
      env:
        - name: RABBITMQ_DEFAULT_USER
          value: user
        - name: RABBITMQ_DEFAULT_PASS
          value: password
      ports:
        - name: rabbitmq
          containerPort: 5672
          protocol: TCP
        - name: rabbitmq1
          containerPort: 15672
          protocol: TCP
    - name: rabbitmq-exporter
      image: kbudde/rabbitmq-exporter
      ports:
        - name: exporter
          containerPort: 9090
      env:
        - name: RABBIT_USER
          value: user
        - name: RABBIT_PASSWORD
          value: password
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: rabbitmq
  namespace: monitoring
  labels:
    k8s-app: rabbitmq
spec:
  selector:
    matchLabels:
      k8s-app: rabbitmq
  endpoints:
  - port: exporter
    interval: 10s
  namespaceSelector:
    matchNames:
    - default

thanks a lot, issue is resolved, after changing the labels it worked perfectly.
your repo helped us immensely to configure Prometheus and Grafana.
Hence, closing the issue.

I'm glad it helped. To better understand the issue, Prometheus Operator will look for ServiceMonitor objects that match serviceMonitorSelector which by default is configured to k8s-app. You can see it here: https://github.com/camilb/prometheus-kubernetes/blob/master/manifests/prometheus/prometheus-k8s.yaml#L22
So,  the ServiceMonitor label has to be k8s-app: something

ahh, thanks for the info.


Rebranding

Refactored the application to remove every mention to Metrics Framework
Fixed MUnit response payload that was causing unit tests to fail

Need to check which version should be set in pom.xml


Fixes #14 : Added Sql\Predicate\NotBetween

Adds a NotBetween predicate:
$sql->notBetween('count', 1, 5);

Where 'count' is the field identifier, 1 is the minimum (left side), and 5 is the maximum (right side).

Merged to develop for release with 2.6.0.


Implement page.authenticate method

This patch implements page.authenticate which should cover all
cases of HTTP authentication.
Implementation notes:

Since HTTP authentication is based on request interception internally, the implementation
of NetworkManager splits the "requestInterceptionEnabled" flag into two:

userRequestInterceptionEnabled - true if the user has enabled request interception
protocolRequestInterceptionEnabled - true if we've enabled request interception in protocol

In case of invalid credentials, in order to escape infinite authentication loop we maintain the attemptedAuthentications set that stores all the interception ids we've tried to authenticate.

Fixes #426.

This works great - even worked for NTLM

@aslushnikov Proxy authentication -> Request interception -> Cache disabled
Is there a way to use an authenticated proxy with an enabled cache?


Rename TeeZip to ZipSource and deprecate TeeZip

Currently what is called Zip should probably be called TeeZip.
Deprecating current TeeZip so that the name can be used for Zip
in the next breaking change.

Codecov Report

Merging #271 into master will decrease coverage by 4.48%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   90.60%   86.11%   -4.49%
==========================================
  Files          20       20
  Lines        1373     1268     -105
==========================================
- Hits         1244     1092     -152
- Misses        129      176      +47

Impacted Files
Coverage Δ

src/lister.jl
80.48% <ø> (-7.32%)
:arrow_down:

src/processes.jl
89.54% <ø> (+2.18%)
:arrow_up:

src/library.jl
93.73% <66.66%> (-0.29%)
:arrow_down:

src/interop/dataframes.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/basics.jl
35.00% <0.00%> (-50.72%)
:arrow_down:

src/simd.jl
78.12% <0.00%> (-21.88%)
:arrow_down:

src/core.jl
72.78% <0.00%> (-17.70%)
:arrow_down:

src/unordered.jl
79.59% <0.00%> (-17.02%)
:arrow_down:

src/interop/onlinestats.jl
70.00% <0.00%> (-10.96%)
:arrow_down:

src/reduce.jl
69.47% <0.00%> (-10.73%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e2758...bf55a27. Read the comment docs.


Unwanted left column padding in listings with chooser modals

Issue Summary
Chooser listings appear to have an unwanted padding.

Steps to Reproduce

Open any page editor where the page model has RichText enabled
Navigate to the RichText field
Select to add a link
Observe in the chooser modal that there is a large amount of additional padding on the left column
Expected: This padding should not be there.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: (no)

Technical details

Wagtail version: 6.1a
See file client/scss/components/_listing.scss, somewhere around the lines indicated below
This nested usage of not/has is overly complex and may need to be reviewed across all usage of listings
Possibly from this commit 81ea6d6266f72bc313bf4358cbc8f16eca8ed472 / #11332

https://github.com/wagtail/wagtail/blob/bded2cb98bef3dacb5b39ba739496a9101885fec/client/scss/components/_listing.scss#L612-L626
Working on this
Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.
Be sure to fully understand the impact of any changes here with nested usage of not has and other selectors, plus the listings are used within modals and outside of modals.

Thank you! I can confirm this, and yeah it does seem to be a regression from the PR.

On another note, I also noticed that there might be another regression from #1150 when the side panel is opened:

Oh, sorry, just noticed that you've opened #11703 for the other issue. Thanks!


Removed condition for retrieving connector stats with roaming site areas

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Find a way to preview many github metrics

Currently, we only have a github dashboard for Grafana

See https://github.com/PyGithub/PyGithub


Not Playing Video - Ionic Android

Streaming-Meda-Cordova-Plugin: 0.1.4
Cordova Version: 6.4.0
Ionic Version: 2.1.4
Testing on my physical device running android 5.1.1 with this code:
<button class="button button-block button-energized" ng-click="abrir()">Play</button>
            $scope.abrir = function() {

              var options = {
                successCallback: function() {
                  console.log("Video was closed without error.");
                },
                errorCallback: function(errMsg) {
                  console.log("Error! " + errMsg);
                },
                orientation: 'landscape'
              };
              window.plugins.streamingMedia.playVideo("http://techslides.com/demos/sample-videos/small.mp4", options);

            };

There is any console errors.

Same problem with Ionic 2:
let options: StreamingVideoOptions = {
      successCallback: () => { console.log('Video played') },
      errorCallback: (e) => { console.log('Error streaming') },
      orientation: 'landscape'
    };
StreamingMedia.playVideo('https://www.youtube.com/watch?v=kqh9bKs9shE', options);

Having same issue - Anyone find any solution for this ??

It's not just on ionic 2. Any mobile it stops working, means it's the plugin itself that has problem. Any help to fixing it to play on android? Thanks.

You guys sure it's the plugin and not your Content-Security-Policy meta attributes? They changed what's needed in the content attribute in recent Android versions. It's all working fine for me with the correct policy.

Get visit
https://github.com/khalisafkari/Ionic-dash-palyer

Hi bcolflesh can you tell us exatcly what you do with the Content-security-Policy? I working around this issue but I can't figure out how to fix it. Thanks!

Works now in my ionic app!
Installing the cordova-streaming-plugin, then  the cordova-whitelist-plugin and then adding in the index.html:
<meta http-equiv="Content-Security-Policy" content="style-src 'self' 'unsafe-inline'; media-src *; connect-src *">
and in the config.xml:

<allow-intent href="*" />
<access origin="*" />
<allow-navigation href="http://*/*" />
<allow-navigation href="https://*/*" />
<allow-navigation href="*" />
<allow-navigation href="data:*" />

and in app.js, after device ready:
var videoUrl = "https://___MY_STREAMING_ENPOINT_HERE__.m3u8";

var options = {
		successCallback: function() {
		  alert("Video was closed without error.");
		},
		errorCallback: function(errMsg) {
		  alert("Error! " + errMsg);
		},
		orientation: 'landscape'
		};
window.plugins.streamingMedia.playVideo(videoUrl, options);

In my case only works well using .m3u8 access. AND only in real devices.
Hope it helps.

Hi, I'm not able to play HLS (m3u8) audio or video streaming. I've tried @ParVisual  workaround but it doesn't work for me.

hey,i got a problem that the plugin works well on ios,but it plays as a black backgroung on android;

Anyone find any solution?

check your debug notes, this probably isn't related to the plugin.

@agoncharovdev  any solution for playing youtube video.

it is strange to blame Ionic for YouTube's policy of not wanting you to stream their videos outside of their own embedded player
if you want to stream YouTube you need to use a YouTube embed


Adding the tgdb cog to the master branch

This is inprogress work
I need to add the notes, player info etc from crossed cogs  getnotes, with any local modifications.
Further more the DM side of the API needs to be worked up, and the appropriate SQL schema applied to tgstation.
TODO

[ ] ADD dm side of the API, generating one time token, making sure you can't generate more if you have one already, putting a suitable round time out on it
[ ] Allow .verify bare, with no one time token, and then match based on the discord id against the discord links table, so you can verify if you have previously and not have to regenerate a token
[ ] If you can't find a match, tell/link the user to some explanatory text about how to actually create a one time user token.
[ ] Investigate redbot/discord,py to see what options there are for preventing users abusing a command (time out) to prevent many repeated verification requests hitting the database hard.
[ ] Add a documented method for setting up redbot, using the phasecorex docker image + how to add this repo and the appropriate cogs.

Rough schema for the tg db

DROP TABLE IF EXISTS `discord_links`;
CREATE TABLE `discord_links` (
	`id` int(11) NOT NULL AUTO_INCREMENT,
	`ckey` VARCHAR(32) NOT NULL,
	`discord_id` BIGINT(20) DEFAULT NULL,
	`timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
	`one_time_token` TEXT NOT NULL,
	PRIMARY KEY (`id`)
) ENGINE=InnoDB;

We already have a discord_id column in the player table. Surely theres a better way to do this?

@AffectedArc07 the seperate table exists primarily at request of the tgstation host
There are two reasons

It's easier to manage permission grants on a per table, rather than per column basis, and you need to grant at least one update for this cog

having a seperate table facilitates storing a record of all linked discord accounts, meaning you can identify a list of all historical discord id's for a given ckey when it's banned and remove them from your server/deverify them.

When I update the tgstation repo, I will be removing the old historical discord id record.

So long as everyone doesnt have to re-link their damn accounts, works for me

I will add an sql script to take the existing discord_id's and insert them as entries into the discord_links table.

INSERT INTO discord_links (ckey, discord_id, one_time_token) SELECT ckey, discord_id, "one_off_presync_from_player_table" FROM player WHERE discord_id IS NOT NULL;
Will do the one off updates.


feat(button, split-button): show active state when expanded (VIV-1562)

@rachelbt You're right in that works for the buttons, but it also breaks other components that have aria-expanded, like nav-disclosure and accordion

@rachelbt You're right in that works for the buttons, but it also breaks other components that have aria-expanded, like nav-disclosure and accordion


Add more detail to Authentication section

Please add more detail to the authentication section to indicate that the account (PAT) used to register the agent is only used when registering and nothing else. Also, mention the server permissions needed to register the agent. I believe you have to be a local admin.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47625b86-abd5-ee15-6d61-8bcf81861b96
Version Independent ID: be9a6174-a69b-7aed-d584-5f602fcc5eb4
Content: Build and Release Agents
Content Source: docs/pipelines/agents/agents.md
Service: unspecified
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

FYI, I noticed the Edit link is back on the VSTS pages, however get a 404 error in GitHub when clicking it.

I noticed this is now working again for Edit. I updated the doc and created the following PR to fix: https://github.com/MicrosoftDocs/vsts-docs/pull/985

Closing this issue since PR https://github.com/MicrosoftDocs/vsts-docs/pull/985 was merged.


row.LastCellNum is to high

Hello there,
i recently started working with NPOI and just did some experiments to get to know the Framework.
So i created a very simple xlsx file and looked how to get acces to the data.
Here is my code:
var sheet = WB.GetSheetAt(0);
int check = sheet.LastRowNum;
var r = sheet.GetRow(3);
var sb = new StringBuilder();
var cell = r.GetCell(4);
sb.AppendLine(string.Format("row  from {0} to {1}", sheet.FirstRowNum, sheet.LastRowNum));
sb.AppendLine(string.Format("Col from {0} to {1}", r.FirstCellNum, r.LastCellNum));

So nothing difficult.
with the following example file i expected
row from 0 to 5
col from 0 to 4
HelloWorld.xlsx
But actually LastCellNum says 5.
And when i looked into r.Cells (the array has the 4 expected cells) and jumped to the last cell it says ColumnIndex = 4.
At first i thought there is just an empty Cell in the next column but after i deleted the complete coloumn with ctrl+- the result was the same. And the number changed aswell as i added the last column with the random character.

Aha, i'm also curious about this question. The 'CellNum' starts from 0 and ends with the actual max number plus 1.
In my opinion it's a mistake which cannot be corrected because a lot of people realize and obey it. If it changes, it may cause a large disaster for the projects using it. The developers cannot inform total users of the changes which aren't compatible to old versions.

Firstly, blank cells don't mean it's really empty in some cases.  The blank cells look same as non-existing cells. For any case, while loop through the cells, don't forget to check if the cell is null and if you go over the upper boundary of Cells property.


Update comment to reflect availability with WebSockets

Feature from #1447 wasn't reflected in this comment

Error: internal/coremsgs/en_struct_descriptions.go:1:17: Expected:2024, Actual: 2023

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fd542c0) 99.99% compared to head (0c9117d) 99.99%.
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   99.99%   99.99%
=======================================
  Files         321      322    +1
  Lines       23175    23273   +98
=======================================
+ Hits        23173    23271   +98
  Misses          1        1
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Avoid false positive of no-consecutive-blank-lines TSLint rule in Vue file

fix https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/130#issuecomment-411216056
Now VueProgram adds // for each blank line to avoid that the tslint reports false positive no-consecutive-blank-lines warning.
Input:
<template>

Hello

</template>

Resolved TypeScript  code:
//
//
//
//

import Vue from 'vue';
export default Vue.extend({});

Looks good - thanks!

Shipped with 0.4.5 https://github.com/Realytics/fork-ts-checker-webpack-plugin/releases/tag/0.4.5

Thanks!


Add Contributing Info for viewing the site

Useful for reviewing PRs and viewing potential changes.
I didn't find this information anywhere else in the repository.

Closes #192


[Snyk] Upgrade react-bootstrap from 2.10.1 to 2.10.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-bootstrap from 2.10.1 to 2.10.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2024-03-18.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-1.azurewebsites.net


Added flyout events to color picker button

Hi there,
The ColorPickerButton had no way of letting me know when it's flyout was being opened or closed, so I added those events in this PR.
For my own application I've been using the color picker with the confirm/dismiss buttons disabled to realtime show the difference your new selection makes (the new color is displayed on the LEDs of devices). This is great but I need to know when the user is finished picking a color so I can execute an undo/redo command, hence this PR :)
I made a slight tweak to ColorPickerFlyout here to make sure events happen in a (to me) more logical order, it also made managing the _isFlyoutOpen state of ColorPickerButton a bit easier.
The order of things is now always:

OnFlyoutOpened
OnFlyoutDismissed or OnFlyoutConfirmed
OnFlyoutClosed

Ofcourse the dismissed/confirmed events never fire if you disabled that functionality, I made sure this doesn't break anything.
PS: I really like what you did with the demo application, great job 👍🏻

Hey, glad to be of help 👍🏻
I went through your comments and resolved everything :)


[VSphere] fn_ert_balanced_azs does not support Availability zones names with spaces.

In pcf-pipelines/tasks/config-ert/task.sh
  local azs_csv=$1
  echo $azs_csv | awk -F "," -v braceopen='{' -v braceclose='}' -v name='"name":' -v quote='"' -v OFS='"},{"name":"' '$1=$1 {print braceopen name quote $0 quote braceclose}'
}```

Only gets the first word and not the full az name as vSphere allows spaces.

Where it's called needs " around it - which fixes the issue.

This has been merged.


Replace check_header_and_update_state with an architecture similar to ibc-go

While implementing the new API, I found several bugs. I implicitly fix those by not re-introducing them in the new API implementation.
Main issue:
Closes: #535
Bugs fixed:
Closes: #583
Closes: #585
Closes: #589
Closes: #598
Closes: #601
Description

[x] tendermint light client methods to implement:

[x] verify_client_message
[x] check_for_misbehaviour
[x] update_state_on_misbehaviour
[x] update_state

[x] update_client::validate calls client_state.verify_client_message, similar to here in ibc-go
[x] update_client::execute calls client_state.{check_for_misbehaviour, update_state_on_misbehaviour, update_state}, similar to here in ibc-go
[x] cleanup

[x] remove now unused ClientState::{check_header_and_update_state} and ClientState::{check_misbehaviour_and_update_state}, and all unused with_* functions
[x] remove now unused misbehaviour::{validate, execute}
[x] remove checks from TmMisbehaviour::new(); this should be a light constructor.

[x] Adapt MsgUpdateClient

[x] MsgSubmitMisbehaviour and MsgUpdateClient are merged into the "new"  MsgUpdateClient
[x] Add a TryFrom<RawMsgSubmitMisbehaviour> for MsgUpdateClient
[x] Update TryFrom<Any> for MsgEnvelope
[x] Rename MsgUpdateClient.header to MsgUpdateClient.client_message, and add update_kind enum field

PR author checklist:

[x] Added changelog entry, using unclog.
[ ] Added tests.
[x] Linked to GitHub issue.
[x] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Created #600; I won't implement in this PR but it's a very desirable feature which we should have.

@ancazamfir I will wait for your approval as well before merging


Update accel entry method attributes documentation

Indicate that "accel," "readwrite," "writeonly," and "accelblock" are seemingly unused, but reserved for future/experimental usage in accel.

Fixes #2721.

Closes #2721


file_data: remove "file too big for CR" error

Now that we store blocks on disk during CR, there's no need for a hard limit on file size.  If the disk fills up during CR, the code will RemoveAll the CR directory and treat it like a normal error, rather than just panic'ing.

I assume the code that actually does the removing was part of the PR that made that a disk-based store?

I assume the code that actually does the removing was part of the PR that made that a disk-based store?

Yeah this is made possible by the previous PRs that started storing the fileBlockMap and the blockPutState on disk, instead of in memory.


[wip]fix number of partitions issue in describe formatted

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2750/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11011/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2979/


Authentication Error

Seems RH changed how authentication works, I've been looking around for a fix.

Checkout the latest commit to Robinhood.py file... Its working for me, I will clean up later.

yep - back up and working - - you rock!

Awesome!


IOS Home screen app-icon has a black background when opening and closing a flutter app.

I noticed that any flutter project whether new or old, has a black underlay whenever the app is launched or minimised on IOS. Haven't tested this out on android yet. I might be wrong and just seeing things because I do have pixel paranoia. :-)
I attached a slow mode representation of the issue.

Steps to Reproduce

Run 'flutter create project-name' , using the stable version of Flutter as of the time of filing this issue.

Run  "flutter run -d " where the device id is the id of a potential iOS simulator or a real iOS device. An example flutter run -d 583ehbefbeiubfue434

Navigate to the home screen and attempt to open the app.

Repeat step 3 to notice it easily.

Hi @adeolaex
please follow up on https://github.com/flutter/flutter/issues/53154,
I'm closing the current one as duplicate

Hello @VladyslavBondarenko . Thank you very much for that info.


Create java_output_ formatting.java

Added  Java Output formatting Problem
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] Make sure your files are in the right folder!
[x] Make sure you add the extension of the file (.cpp, .python, .java, etc).
[x] If your code is a solution for a code problem, please tell which one.
[x] Make sure your code is working, test for a lot of cases.

Description
Please describe your pull request.
:heart: Thank you!

please add this file to java folder


Can I develop a GAMM(Generalized Additive Mixed  Models) in this package?

@chjq201410695 unfortunately no. The estimation of GAMM is quite different.
However, you might consider a non-parametric model of your data's distribution using expectiles. Expectiles and quantiles are very closely related, while expectiles are much easier to fit.
You can achieve this using ExpectileGAM and even search for a particular quantile using gam.fit_quantile(X, y)

@chjq201410695 Unfortunately no. pyGAM cannot estimate GAMMs currently.

@chjq201410695 Unfortunately no. pyGAM cannot estimate GAMMs currently.

OK, thanks for your response; do you have plan to involve GAMMs in near future?

OK, thanks for your response; do you have plan to involve GAMMs in near future?

no, not in the near future :/
There are other more urgent things that i would like to fix before adding new features.

OK, thanks for your response; do you have plan to involve GAMMs in near future?

no, not in the near future :/
There are other more urgent things that i would like to fix before adding new features.

OK, good luck!  I will close this issue.


Identifiers validation failed for dataset INSDC Host Organism Sequences

Identifier validation failed for the dataset INSDC Host Organism Sequences:

Crawler attempt: 118
Publishing organization: European Nucleotide Archive (EMBL-EBI)
Publishing country: UNITED_KINGDOM
Installation: GBIF Europe and Central Asia
Number of occurrences indexed for this dataset at the time of the issue: 1345328
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 86%, total records count 9816697, absent records count 8478821
Step metrics:

Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3042140/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the INSDC Host Organism Sequences : https://doi.org/10.15468/e97kmy.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

I think there is a problem with this dataset, see https://github.com/gbif/portal-feedback/issues/4864#issuecomment-1633800202, I don't think we should ingest the dataset until the issue is solved.

The fixed dataset ingested without any interference with identifiers.


removed property cluster name and creation index in setup

Description
Removed non used code and index creation in setup
Reviewer
@gserranojc
Test
All passed
Scalastyle
All test passed.

Jenkins job pending... wait for confirmation message before merging.

Jenkins job went KO. Its up to someone to merge.


adding the final plaits models to plaits~

first draft. need to fix fm ops models not working

since it is a derivative work, and it runs in pd, we could've called it "bangs" that would've been cute :laughing:

ops models?

oh, fm, what's wrong with them?

3 of the new models are 2-voice, 6-operator fm (each of those 3 has 32 different presets) those are the only thing not working yet
my guess it's probably something because of allocation. this feels wrong, they need to be different i think
https://github.com/porres/pd-else/pull/1795/files#diff-0bd2d3b3772f4738bfa63d65c86610d8616ac220717087f876471d6108ba1b04R107
but that's an adventure for tomorrow-amy

they're described better here https://pichenettes.github.io/mutable-instruments-documentation/modules/plaits/firmware/

what changes in the documentation? so we'll really have new modules?

wow, checked the link, holly shit

heheh yeah it's gonna be a new row of models, just need some time to figure out the fm ones
here you get to see a crash too :laughing:
https://github.com/porres/pd-else/assets/86204514/2d638324-fc64-4115-9018-fc7fdd870825
don't worry i'll take care of the help file after i'm done with the cleaning

amazing, can't wait to add the plaits module to the collection of modular inspired abstractions.

I have made major overhauls like this a few times from time to time. Biggest motivation is having things better organize that annoys me in my workflow. I never really knew how plugdata kept up with these by the way. I thought it just used whatever structure I had or something, like a submodule.
Now, quite recently I made huge changes and @timothyschoen liked it and said it now made it better and easier to use it as a submodule indeed... I don't really know how it works on your side over there, but it seemed to me it made things easier and I could mess around without worries.
Anyway, I haven't really settled with this last reorganized because there isn't a new release yet and I'm trying to get things over with next week the latest. So I did this minor change compared to my very last one because it organizes things even better for me, and I'm getting rid of things that aren't used (like the 'libpd' folder)
And, well, it's nice that control and audio are next to each other alphabetically and extra is on the bottom, that's just it. Moreover, that's actually how Cyclone is organized and I was actually inspired by that, and then I checked and saw I made it differently, and now I see this is actually better and I'm also trying to make both repositories more consistent and structured in the same way...
Anyway, I'd wait until I finish the release and then I'll try to stick with the way things end up. There's now an inconsistency that is annoying me. In Cyclone I'm calling "binaries" and in ELSE I'm calling "compiled". I'll try to make a decision on changing one or another.

yeah, but it's work. like, you have to update your makefile, tim has to update the cmake stuff in plugdata (and a script that packages the abstractions).. just feels better to pick something and stick to it

yep, looking sharp
https://github.com/porres/pd-else/assets/86204514/1393a571-2593-497f-9939-fa0b6ff1d5d1

i meant to do this in another branch, but i always git branch and forget to git switch xD

great, we need to update the help file now, right?

hehe yeah, leave that to me. i wanna give it the love it deserves :hearts:

btw, in case you want to play, here's a description (the orange ones)
https://drive.google.com/file/d/16VGibJgQ9SlxVPtzf2Ln_RW0WqDNyuym/view

nice, but working on sfz~ now

nice! have fun <3

I wonder how we can import DX7 files...

see this is one of the banks of patches loaded by default (this has 32 presets)
https://github.com/porres/pd-else/blob/b45a9adffb9e8f27769d99ce2ce0674820956f5c/Code_source/Compiled/audio/plaits~/plaits/resources.cc#L37
the three of them are added together here
https://github.com/porres/pd-else/blob/b45a9adffb9e8f27769d99ce2ce0674820956f5c/Code_source/Compiled/audio/plaits~/plaits/resources.cc#L3117
and then when we switch to one of those engines we load the corresponding bank
https://github.com/porres/pd-else/blob/b45a9adffb9e8f27769d99ce2ce0674820956f5c/Code_source/Compiled/audio/plaits~/plaits/dsp/voice.cc#L175
and the LoadUserData function in the engine handles the rest
https://github.com/porres/pd-else/blob/b45a9adffb9e8f27769d99ce2ce0674820956f5c/Code_source/Compiled/audio/plaits~/plaits/dsp/engine2/six_op_engine.cc#L94
also look at the original plaits logic that i had to edit a little cause we don't use any actual user data (yet)
https://github.com/pichenettes/eurorack/blob/08460a69a7e1f7a81c5a2abcc7189c9a6b7208d4/plaits/dsp/voice.cc#L130
so the part i don't know anything about is how you can read dx7 files as an array like that, after that it's just a matter of calling LoadUserData on it and resetting the engine just like in voice.cc

also this https://github.com/porres/pd-else/blob/master/Code_source/Compiled/audio/plaits~/plaits/dsp/fm/patch.h


OCPBUGS-36500: remove cvo hypershift profile annotation from psm-operator manifests

Remove cvo hypershift profile annotation from psm-operator manifests

/retest

/jira refresh

/lgtm


Incorrect value converted in tooltip

In this demo code -1072352461 is converted to 0x3FEACCCD which is the negated value. The correct result is 0xC0153333.
However the output in Clang is correct:
-4605718748921121997 = 0xC015333333333333

Nice catch! An off by one error was making us skip the check for negative numbers if they happened to be on the last line.
:)


Error: Minified React error

Hi @moonsieurdjodjo225 , can you please provide some extra context? What were you doing when the error occurred? Can you try checking if it also happens in Incognito mode or another browser?
If you haven't done so already, you can also try running composer update to update Ignition or its dependencies to the latest version.
Thanks for reporting this issue and good luck!

Hey, let's continue this issue in https://github.com/spatie/ignition/issues/107


Use cert, err := x509.ParseCertificate(derBytes) to process the certificate
What did you see happen?
Error message：cannot parse URI "https://1kYj\[@.cfZGv3T_Tr.D?/zrm3/4WA/Ir}BQ/yR]/0[g?<tX=uR?&K'O={d2}&sG?rLi=<}e>": parse "https://1kYj\[@.cfZGv3T_Tr.D?/zrm3/4WA/Ir}BQ/yR]/0[g?<tX=uR?&K'O={d2}&sG?rLi=<}e>": net/url: invalid userinfo
What did you expect to see?
The results are different from Openssl and Gnutls. Openssl's openssl x509 -noout -text -in filename and gnutls's certtool -i --infile=filename --inraw successfully viewed the certificate.Both successfully resolved SAN

This seems to happen here:
https://github.com/golang/go/blob/6853d89477e0886c7c96b08e7efaf74abedfcf71/src/crypto/x509/parser.go#L389-L397
And the URL seems to be invalid, see simpler reproducer https://go.dev/play/p/IMYvwnRjF7F
CC @neild (as per https://dev.golang.org/owners for net/url) not sure how to judge that URL. I guess openssl x509 does not validate URLs and just display them, so it works there.


Any way to have it run the tests in the background?

First of all, I really love wbench. Awesome stuff. That being said, is there any way to make it not open and close google chrome in the foreground to run the tests? It would be much nicer if that stuff ran in the background.
Thanks!

Hello!
Since version 59 Google Chrome is being shipped with a headless feature and it is easy to run headless with chrome: --headless.
There is an way to pass flags to Chrome with wbench?
Thanks!


Testing...

Relevant information
This PR will be deleted because its main intention is for testing purposes.
Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Daniel Pardo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


ExtensionsToDeleteOnClean isn't documented

ExtensionsToDeleteOnClean isn't documented.
I found this property in Microsoft.Cpp.Common.props.
Adam Comella
Microsoft Corp.

@rigdern Can you provide more context on this setting? For example, in which configuration file would you set it or which existing docs.microsoft.com topic would likely include the description. This will help with assigning the issue to the appropriate doc team and writer. Thanks

@gregvanl Sorry, I'm new to msbuild and wasn't sure what context would be useful. I updated the issue description with an additional detail. Let me know if that's sufficient.

@rigdern Great, this helps. Sounds like it is C++ specific for MSBuild.

Property looks specific to C++ and maybe extensibility also. I don't see any docs on this subject, but it would probably belong in C++ if it were doc'ed. I looked through their docs, and it doesn't look like they are doc'ing every property either (though that would be nice). Closing as out of scope.


Add react-jss example

Added a clear example on how to use react-jss with injecting the styles on the server.
cssinjs/jss#457

@kof @oliviertassinari could you have a look at this example 🕵 If it looks alright I'll merge it 👍

@HenriBeck How do you solve the hot reloading class name missmatch issue? On Material-UI we had to remove the moduleId.

There aren't any mismatches when hot reloading. I can change the styles or a component, and I get the new changes applied.
I think the reason it works, is because react-jss doesn't implement anything specific for HMR updates and remounts the component/tree.

It's good to know.

A mismatch should only happen when the client is being hydrated which only happens on the first render if I'm correct. The HMR should only rerender/update the components.


[Bug]: client selects some local dp, not all local dp

Describe the bug
client selects some local dp, not all local dp

https://github.com/cubefs/cubefs/pull/1956

https://github.com/cubefs/cubefs/pull/1958


chore(action): bind debug input to action debug

description
When an action will be executed in debug mode (e.g. via GitHub UI) the secret ACTIONS_STEP_DEBUG will be set to true (empty if not enabled). This typically will allow to detect if a run is in debug mode. Because a GitHub action can not automatically read secrets the runner.debug variable needs to be used to determine if debug mode is enabled.
When using this as default for the debug input of the action the debug will automatically be forwarded to SecHub.
Overwriting is always possible for the endusers because it is only the default setting of this action.
This change was already tested within GHE.
useful links

Enabling debug logging
runner context

limitation
The only problem here is that instead of a not existing steps.debug variable the runner.debug variable is used.
For debugging steps the usage of the steps context would be better here - but because this context does not offer a debug property we are using the runners property here.
Because when the debug is enabled via UI (I guess this is the most common approach) it will trigger the debug mode for this action as well (...but via the runner).
re-run (failed) jobs popup

additonal information
Because the runner.debug returns a 1 a expression is used to make a boolean out of it.

Marco Lecheler<EMAIL_ADDRESS>Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

@fty4 : First of all: Thank you for the contribution.
Currently I am extremely refactoring the complete github action (more scan types, provide an integration test to run/test it at local machine (mocking automatically GH actions) and much more).
When I have done the refactorings and the improvements, I will return to this PR and give you feedback/discuss further steps etc.
Sorry for the inconvenience/the delay...


Lailah contribution branch

Make my profile in the Contribution md file

Sorry
This was a typo on my part as my computer was hibernating.
On Mon, 11 Oct 2021, 6:44 pm David Leal, @.***> wrote:

@.**** requested changes on this pull request.
Please see the comments above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/LinkFree/pull/494#pullrequestreview-776435262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGWPV3ADPWNO4BTHACQ5BNLUGMA7NANCNFSM5FWSGNGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


When Rancher GUI session times out, you are prompted for an API key

When the GUI session times out,  and no links are clicked, the browser is given a popup HTTP-AUTH prompt to "Enter API access key and password", instead of being redirected to the login page.  It would be preferable if the UI recognised a session timeout, and instead prompted the user to login again.
Cancelling the login popup and then clicking on any link will correctly redirect to the user login form.

There is a header specifically sent to have the API not include the www-authenticate header in 401 responses to the UI, so this should never happen..  What screen was it on?  What auth mode?  SSL termination or anything else special involved?

I have rancher-server installed on a separate docker host, behind an nginx proxy that does SSL offloading.  I was connected via https to nginx and then on to rnahcer-server.
I left the desktop logged in overnight viewing the Infrastructure screen (Hosts) and when coming in in the morning saw the http-auth prompt.
The rancher-server is configured with LDAP authentication to AD.  rancher-server v0.43.1

The nginx configuration was pulled from the Rancher website instructions:
upstream rancher {
  server rancher-server:8080;
}

server {
  listen 443 ssl;
  server_name rancher.container.auckland.ac.nz;
  ssl_certificate     certs/rancher.container.auckland.ac.nz.crt;
  ssl_certificate_key certs/rancher.container.auckland.ac.nz.key;

  location / {
    proxy_set_header Host $host;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header X-Forwarded-Port $server_port;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_pass http://rancher;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
    # This allows the ability for the execute shell window to remain open for up to 15 minutes. Without this parameter, the default is 1 minute and will automatically close.
    proxy_read_timeout 900s;
  }
}

Ok I think this is from the subscribe websocket;  The no-challenge header is missing on that request, because there is no way to set custom headers on websocket requests.
That normally wouldn't normally matter because it's the last thing opened on the page and something earlier would have gotten unauthorized first.. But the socket reconnects automatically, so if your connection dropped briefly overnight it would reconnect and trigger the prompt.  This will require a change on the API side.
Note to future me / @westlywright: catalog and a couple add-host drivers also have some requests that are doing raw AJAX and should be fixed.  Everything should use store.{request,rawRequest}, not ajaxPromise or [Ember.]$.ajax.

@ibuildthecloud added a fix for the server-side for next release

Version - Master
Verified Fixed


how to move page corner by touch point

thanks for your great work.
I want to move page corner by finger.It like google map on ipad do.How can i do this?

I am gonna add a demo of this feature in the samples app as soon as possible.
Anyway, this can be achieved through the XBPageCurlView, but there are some stuff yet to be implemented.

Hey,
Any update on this?
Thanks :)

Hi, sorry for the delay.. I started to implement this but didn't commit anything yet. Been busy. I will try to continue to work on this feature this week.

Awesome. Thanks

I currently have the first working version in the branch "flip". I will continue to work on it to improve the API (suggestions are welcome) and I still have to implement correct dragging while the cylinder is snapped to another point.
The PageCurlViewController is the sample that uses this feature in a MapView. The process to make your view behave like that is quite manual yet. First you have to create a XBPageCurlView, configure it, add is as subview on top of the view you want to curl (add it to the superview of that one) and set it as hidden. Enable snapping and add some snapping points so that the cylinder will stick to them when the user releases his finger off the screen.
You also need another view that will act as a button that will start the curling (like in Google Maps for the iPad, where the "button" is the curled corner of the view on the bottom right of the screen). In the first touch, since the pageCurlView is hidden, we have to start to delegate the touches to it, hence you have to implement the touches* methods. In touchesBegan:withEvent: you also have to setup the pageCurlView for display and start its rendering loop.
One more thing that must be done is to implement XBPageCurlViewDelegate to be notified about snapping to the snapping point located at the bottom right which should stop the curlView and hide it and show the original mapView.
It's quite a lot of things to do to get this working yet :) . API suggestions are welcome.

Hey,
Thanks, let me give it a try. I keep you in touch (no pun intented) ;)


Update auxlib, clib, javalib, nativelib, ... to 0.5.3

About this PR
📦 Updates

org.scala-native:auxlib
org.scala-native:clib
org.scala-native:javalib
org.scala-native:nativelib
org.scala-native:nscplugin
org.scala-native:posixlib
org.scala-native:sbt-scala-native
org.scala-native:test-interface
org.scala-native:windowslib

from 0.5.1 to 0.5.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.5.1).
You might want to review and update them manually.
project/plugins.sbt
sbt-locales/src/sbt-test/sbt-locales/common-filtering/project/plugins.sbt
sbt-locales/src/sbt-test/sbt-locales/no-filtering/project/plugins.sbt

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, old-version-remains, commit-count:1

Superseded by #344.


[CP] DevTools related cherry pick request for Dart 2.17

This cherry pick request is to roll the DevTools version in the SDK from 2.12.1 to 2.12.2. User risk is low.
[commit to cherry pick] This is the SDK commit that bumps the DEPS version for DevTools to 2.12.2: https://github.com/dart-lang/sdk/commit/2badd2e71eaeb5c6b24005af5005fe1220ce21a9
Here is a diff DevTools 2.12.1 vs 2.12.2: https://github.com/flutter/devtools/compare/v2.12.1...v2.12.2.
DevTools 2.12.2 contains 3 functional commits that

fix a breakage where traces will not be rendered properly with Track Widget Builds enabled (see https://github.com/flutter/flutter/issues/101379 for details)
fix a bug preventing the inspector from loading the widget tree

/cc @mit-mit @whesse @athomas @vsmenon @devoncarew

cc @itsjustkevin


Reactivity is lost when using Reactive Props Destructure on props with default values specified using withDefaults.

Vue version
v3.5.13
Link to minimal reproduction
https://play.vuejs.org/#eNq1U0uP0zAQ/itTX9KVSqJV4VLSSjxWAg6wWpC4WEJRMmm9OHZkT7JFUf47Y2dTCiy9cfN83zy+eXgQr9o27TsUG5H70qmWwCN17U4a1bTWEQzgsIYRamcbSNg1OVFvbNM+4mkWjJApeSlNaY0naPwetiF6mbxDrS18tU5Xi+RKmjybinEZNgibVheEbAHkh+vdMMTgccwztiKqTNsR9M8aW6HeSsG8FJBNZBSyYeg3Is/OEouVIM+6arVP77013PAQYqUoOVhpdJ9aUqxbig1EJnAFy374EDFyHa5mvDxg+f0J/N4fAybFrUOPrkcpThwVbo800TefP+KR3yeS2+o0e18g79Bb3QWNk9vrzlQs+8wvqn0fd6PM/ou/ORIaPzcVhAbPMfpLwbsKc/tX67/krtPnMU6akac47/nsYnRhwuSJE5yuJ8vgDouSVK/oBygP2nqaL+NxvXwdD4oOb7EuOk1+WWGtDN462/p8YI8NeHLcybhbXq1gQqSYbinIWCykGPmanqhmLMuKFZn630Ugcuetbf9KEbu9VPvyp6hUHx8QE/Ka5h8S2Wyi/zz4bz26sH5e1Tp9kV6vxfgTLfRRWA==
Steps to reproduce

Update msg in App.vue from Preview from input tag.
The Comp: Hello World! shown in Preview does not change according to the input value (msg).

What is expected?

That reactivity is not lost and that the Comp: Hello World! shown in Preview is changed to match the msg in App.vue.

What is actually happening?

Reactivity is lost and the Comp: Hello World! displayed in Preview is not changed to match the msg in App.vue.

System Info
No response
Any additional comments?
As shown below, it seems to occur when you set default values with withDefaults while expecting Reactive Props Destructure and split assigning props.
// Reactivity is lost
const { msg } = withDefaults(defineProps<{msg: string}>(), {msg: "Hello Comp!!"})

// Reactivity is not lost
withDefaults(defineProps<{msg: string}>(), {msg: "Hello Comp!!"})

// Reactivity is not lost
const { msg = "Hello Comp!!" } = defineProps<{msg: string}>()

The original intention of the design of "Reactive Props Destructure" was to replace withDefaults, it only takes effect when directly deconstructing the return value of defineProps.

As @KazariEX said. this is by design.

@KazariEX @edison1105
Thank you for your comment!
I now understand that the design is effective only when directly deconstructing defineProps.
I got it!😄


Google Earth file needs to be reworked since the number of vehicles has increased

Loading all vehicles at once is probably not the best way. I've had Google Earth crash.
Perhaps, it should just send a list of all vehicles, and load the data per vehicle when selected.

Could be viable, its not often that you do need all the flights, other than when showing "the crowded skies" effect ;-)  Mostly rely on using the "vehicles" filter to select those required at a given time.
One down side would be that updates would be occurring at frequent intervals which makes saving details a problem as GE locks the files during updates - this DOES cause crashes, requiring a restart of GE with loss of all data prior to the crash, this would be a serious problem.

If the volume of data is reduced, would it be possible to consider adding "Placemark" information which could contain additional data for each point reported, i.e height, temperature, battery etc.  if so they should be added as a separate branch within the tree which could be enabled for display as required.  This would then enable plotting of measured parameters against geographical position rather than as a simple time line.


iOS performance investigations

iOS performance is quite bad on o!f right now, even with Metal being utilised for rendering. Initially, we've expected that decreasing the rendering resolution (i.e. using a "render scale") would improve performance to a usable level, but it turns out that actually had little to no effect.
To explain briefly, there are two phases during the rendering of a frame:

The encoding phase, which represents all the time spent by the CPU queuing up (i.e. encoding) Metal commands to the command buffers.
The drawing phase, which represents all the time spent by the GPU executing the submitted command buffers (processing commands, running vertex/fragment shaders).

It has been expected that iOS was behaving badly due to our draw calls and vertex/fragment shaders being unnecessarily complicated for the GPU to handle (or basically a lot of fragments to process), but actually most of the overhead is coming from the encoding phase instead.
For example, on osu! master, profiling iOS performance on song select yields 30ms-40ms being spent on encoding and 10ms being spent on drawing. Both are pretty wild intervals for such a 2D scene.
Using the "render scale" changes and downscaling the game all the way down to 0.1x decreases drawing/GPU time down to 1-2ms as expected, but the encoding time doesn't change even a notch, therefore nothing will feel any different in song select with render scale, it remains performing at 24-30 FPS.
High level investigations
I've started things off by investigating this briefly at a higher level using framework test scenes which uses basic rendering functionality and monitor the frame statistics display.
I didn't gain much knowledge other than that increasing the number of masked containers rendered per frame, and/or increasing the number of native textures used on sprites, would all increase encoding time, and that's nothing new as it all indicates vertex batches being flushed quite frequently, and there are so many draw calls in the frame.
I've also noticed that the visual test browser is already adding overhead even on a blank test scene due to all the sprite texts displayed around it (test labels, control labels, etc.).
Therefore I've switched to our "sample game" project and I've made it render 500 boxes using a fill flow container with a flush between each box, and I realised the FPS counter actually went down to 40 FPS...which leads us to the next topic that I've spent around a week on...
Low level investigations
Taking things at a lower level, with no render scaling involved, I've set up a drawable with a custom draw node that draws 500 quads with a flush after each draw (i.e. 500 draw calls), and the results were quite interesting:

"Commmand Buffer 0" and "Render Command 0" represent the command buffer and rendering pass in which the 500 quads were drawn at. The GPU spent ~1ms processing these draw calls, which is mostly sane, but, the CPU has spent over 10ms encoding just that!
My immediate thoughts were that 500 draw calls are expensive to encode, but after writing a quick Metal app with Swift which does the same to a certain extent, the encoding overhead in release configuration could go as low as 0.3ms!!

Then I thought maybe Veldrid's implementation of Metal isn't quite optimal for iOS consumption, and I went ahead and made a quick isolated Veldrid app that pretty much copies what the Swift app above does, and the encoding overhead is oddly unstable, it could range between ~2-3ms all up to ~5ms:

After multiple days of investigating this, turns out our renderer implementation is being slightly inefficient (plus Veldrid validation code):

Veldrid renderer fetches pipeline & resource sets from dictionaries every single draw call

adds around 1ms CPU overhead per frame, therefore increasing encoding time

Veldrid renderer switches to a new vertex buffer every single draw call rather than re-using the previous one until it's filled

adds around 2ms encoding time overhead per frame, because setVertexBuffer is being called on every draw call.

Veldrid's validation code being executed even in release configuration

adds around 1ms CPU overhead per frame.

EDIT: All of the above, except for #5892 maybe, were caused by running the game under Mono interpretation. Switching to AOT as tracked in #5902 resolves the issue.

In summary, we're spending a lot of time encoding frames, and there's still a lot to investigate at a high level scale, the overhead may be coming from us issuing too many draw calls, or us spending too much time in draw nodes, or Veldrid not performing efficiently on iOS in certain scenarios.
The following is a list of observations I've gathered during my investigations the past week.
### Tasks
- [ ] https://github.com/ppy/osu-framework/issues/5892
- [ ] https://github.com/ppy/osu-framework/issues/5895
- [ ] https://github.com/ppy/osu-framework/issues/5920
- [ ] https://github.com/ppy/osu-framework/issues/5902
- [x] Metal rendering may get stuck waiting for next drawable every frame on iOS, potentially increasing encoding time (alleviated by waiting for drawable in `WaitForNextFrameReady`, see: https://github.com/ppy/veldrid/pull/28)
- [ ] Remove Metal command buffer completion handler for iOS Metal debugging ease
- [ ] Investigate garbage collection happening every frame on iOS

I'm going to close this as iOS performance is much tolerable now compared to how it was before, the last two tasks are not as mandatory as the others to keep this issue thread open.


Create Striking/homepage images page

[x] Create page
[x] Add description of what is being covered
[x] Add description of checks required on this content, compiled from current protocol documents
[x] Add examples covering correct and incorrect scenarios, as required to support checks
[ ] Populate with schematron messages
[ ] Provide explanations for how to fix schematron errors and warnings
[x] Review house style document to ensure all requirements are covered by GitBook and schematron
[ ] Review schematron messages related to this topic to ensure they are user friendly
[ ] Becky approved page
[ ] Melissa approved page
[x] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Share page with Exeter and invite feedback
[ ] Revise with Exeter's suggestions

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?
[ ] Assign Fred to update the Schematron

I believe this is now ready for Production to review (eekk!) @naushinthomson @JGilbert-eLife @FAtherden-eLife @Melissa37
https://app.gitbook.com/@elifesciences/s/productionhowto/toolkit/striking-images-1

Is it worth providing the screenshot without the browser highlighting over 'striking image'?

They may only include the title of the article without the article number but you can often find this by searching in eJP using the article title or email address of the author.

Is this referring to the email subject? If so, I think this should be made clearer.

If you are unable to do so, the author will need to be asked for this so that we can ensure the striking image is uploaded correctly.

Suggest changing to:
If you are unable to determine which article the striking image relates to, the author will need to be asked what their manuscript tracking number is, so that the striking image can be uploaded correctly.

Depending on the status of the article, you can upload this striking image through eJP or the Kriya dashboard.

Please clarify what status determines this.

Alternatively, you can look in the Production inbox for the XML notification.

Suggest changing to:
Alternatively, search the manuscript number in the Production Inbox, and check if there's an XML notification email which indicates that the article has been sent to Kriya (see here).

It is worth noting that you are unable to select multiple images to upload through the 'Select file' icon and each image will need to be selected separately (but within the same uploading session).

Would it be worth including a screenshot or two of this process to make absolutely clear?

After clicking on 'Update' the uploader will not automatically close.

Huh, I didn't know that! I've always just waited (in some cases for a long time), for the pop-up to close.

You allude to the fact that other journals might include these as covers, and sometimes eLife authors contact us expecting the same - i.e. "I provided a striking image but the poster for my article doesn't contain it - why is that?"
Does this need to be covered in this page, or the production inbox page? I see there are email templates relating to Striking images as well. Should these be covered in this page or the production inbox page? If the latter, then I think we should mention these in this page referring the user to the appropriate section in that page.

Out of scope for this ticket but, looking at the email template for responding to a striking image email:

Dear
Thank you very much for sending over your striking image. I have uploaded it to our system for you now.
Best wishes,

Is it worth clarifying what it will be used for in the template?
I used to say something like, "I have uploaded it to our system for possible selection by our social media team".
The attempt here is to mitigate against the "I provided a striking image but the poster for my article doesn't contain it - why is that?" type emails.

Uses for striking images
Striking images can be used in the following ways
...
within the eLife digest [see here for the digest channel]

Suggest change to:
to accompany the Digest in the eLife digest channel (note: this cannot accompany the Digest on the journal article HTML view or in the PDF)

The authors are also free to use these images for their own social media and press releases and do not need to ask permission for this.

...because they fall under the CCBY license along with the rest of the content.

Would it be worth putting uploading to Kriya and AWS above uploading to eJP?
Is the thought process?

Is it in Kriya?

yes:

Does it already have a striking image?
* yes -> upload to AWS
* no -> upload via Kriya

no:

upload to eJP

If so, then I think it should be ordered based on that.

That's it from me - thanks Becky, nice job.

@bcollins14 can you add the url link to where this page is again? I cannot get the link to work from the top of this ticket.
Thanks!
M

To maximise the impact of an article upon its release, it is beneficial to accompany an article with an eye catching image that highlights the research article.

Suggest adding hyphen between eye and catching:

To maximise the impact of an article upon its release, it is beneficial to accompany an article with an eye-catching image that highlights the research article.

At eLife, when an acceptance letter is sent out, we encourage authors to submit a promotional image which we call a 'striking image', which can be emailed to the Production team and/or uploaded during their submission to eJP.

Suggest changing to following:

At eLife, when an acceptance letter is sent out, we encourage authors to submit a promotional image that we call a 'striking image'. This can be emailed to the Production team directly and/or uploaded during their submission to eJP.

These images should preferably be in colour, in a landscape format and be at least 1800 x 900 pixels.

I believe we use the Oxford comma:

These images should preferably be in colour, in a landscape format, and be at least 1800 x 900 pixels.

Photographs, microscopy images and illustrations work best

Suggest Oxford comma usage:

Photographs, microscopy images, and illustrations work best

To add: If an author had uploaded the image via eJP (or emailed Production) and Features also send us the image. Need to check what has been uploaded already to the AWS bucket and ensure correct caption is included.

This information is provided to authors, and it is up to them to ensure the images they provide adhere to these guidelines. We do not check them and we upload whatever is provided to Kriya.

I don't think this is very clear - what info?
Should it be?

We assume the images provided are licensed under CC-BY and do not check this information. If there is a caption or attribution information provided with the image this should be added to the 'metacontent' when uploading to Kriya (see below).

How is this info provided if in EJP?

Tautology (remove "via email"):

Authors can email Production with a striking image via email as indicated in the acceptance email from Editorial and will have been provided with the guidance shown below.

They may only include the title of the article without the article number but you can often find this by searching in eJP using the article title or email address of the author. If you are unable to do so, the author will need to be asked for this so that we can ensure the striking image is uploaded correctly.

Suggest changing to:

They may only include the title of the article without the article number but you can often find this by searching in eJP using the article title or email address of the author. If you are unable to do so, the author will need to be asked for this so that we can ensure the striking image is associated with the correct article.

Depending on the status of the article, you can upload this striking image through eJP or the Kriya dashboard.

Suggest changing to:

If the article has been exported from eJP and is in Kriya, upload the image via the Kriya dashboard. If the article is still within eJP and not yet exported, upload it to eJP. It is important not to load it to eJP if the article is already in the production system because the systems do not transfer further information with each other after export has occured.

To upload this via eJP, you should bring up the accepted version of the article.

Suggest changing to:

To upload the image to eJP, search eJP using the MS number.

Ensure this article has not already been exported from eJP to Kriya. To check, you can look to see if under  'More Manuscript Info and Tools' on the right hand side of the page, and see if the 'Export to Exeter' option is not displaying but instead says 'Resend/Export to Exeter Premedia'. Alternatively, you can look in the Production inbox for the XML notification.

Suggest changing to:

Ensure this article has not already been exported from eJP to Kriya. The most efficient way to do this is to search the Production inbox for the XML notification, which informs production an article has been exported from eJP.
However, if you are in eJP look at 'More Manuscript Info and Tools' on the right-hand side of the page. If the 'Export to Exeter' option is not displaying but instead says 'Resend/Export to Exeter Premedia' this means the article has already been exported.

Might be worth rejigging with the part above too. Perhaps move "Ensure this article has not already been exported from eJP to Kriya. The most efficient way to do this is to search the Production inbox for the XML notification, which informs production an article has been exported from eJP." to above the section about loading to eJP?

When the uploader appears, select the file and then click on 'Update'. Leave the 'metacontent' as is, unless the authors have provided a caption or attribution information in which case these should be entered instead.

Suggest changing to:

When the uploader appears, select the file and then click on 'Update'. Do not add text to the 'metacontent' field unless the authors have provided a caption or attribution information, in which case enter the provided text here.

It is worth noting that you are unable to select multiple images to upload through the 'Select file' icon and each image will need to be selected separately (but within the same uploading session). This is because with each image upload, it will overwrite what is previously in the striking images AWS bucket. To add additional images to an article has already has an image, please see below.

Suggest changing to

It is worth noting that you are unable to select multiple images to upload through the 'Select file' icon. If an author has provided more than one image uploaded them successively within the same session.
Successive upload sessions overwrite what was previously uploaded.
Authors who provide more than one image are giving us more choice of images to use.

Uploading via the striking images AWS bucket

Need to explain what the AWS bucket is, how to get there and what it's purpose is

Open this folder and drag and drop the new striking image in to upload it. Make sure the striking image is titled appropriately - e.g. '56754-b_striking_image' if there is already a '56754-a_striking_image'. If the authors have provided a title, caption, or attribution information, enter this into a .txt file and save with the same title (i.e. '56754-b_striking_image'). If they have not provided this information, you do not need to include a .txt file.

Are the file names created with the -a  suffix even if there is only 1?

This ticket is called Create Striking/homepage images page but it does not include info about the homepage. Is that going to be in another page/ticket?
Thanks! I'm all done @bcollins14

Thanks for this @bcollins14!
"To maximise the impact of an article upon its release, it is beneficial to accompany an article with an eye catching image that highlights the research article. "
I think this phrasing might be a little bit misleading - articles are not accompanied by the images in the way that authors tend to assume they will be - the images are used to promote their articles, but don't appear on the website etc etc. Maybe:
"To maximise the impact upon publication, it is beneficial if an eye-catching image highlighting the research is available to promote the article."

Maybe say in the legend for the image that it's an example of a graphical abstract? Just to be 100% clear

Are the file names created with the -a suffix even if there is only 1?

They are, yes.

". . . we upload whatever is provided to Kriya."
To be really picky, we don't upload them to Kriya. We upload them via Kriya but the end-point is the striking image bucket. I think this is a distinction worth drawing because we sometimes have to do this manually for really large images, or if Kriya is borked.

Hmm - I wonder if it's less hassle to simply take an existing image and reupload it if you need to add an extra one through Kriya. It's a faff either way, but that might be the easier route?

I think everyone has already covered anything I would have noted. Thanks for working on this Becky!

After clicking on 'Update' the uploader will not automatically close.
Huh, I didn't know that! I've always just waited (in some cases for a long time), for the pop-up to close.

It hasn't always been this way, it used to close automatically but this has been a work around for a while now. It took me a while to realise it had indeed broke >_<

Opps would help if I was signed in as myself!

This ticket is called Create Striking/homepage images page but it does not include info about the homepage. Is that going to be in another page/ticket?

I felt having a separate page for the homepage would be better as it can go into how the process works too. I need to make another ticket for this.

@JGilbert-eLife @Melissa37 @FAtherden-eLife @naushinthomson I believe this is now ready for review again https://app.gitbook.com/@elifesciences/s/productionhowto/toolkit/striking-images-1

Thanks Becky, do we need something in the Uploading a striking image section about whether the article already has a striking image, and what to do in that case? I.e. don't upload via Kriya if there already is a striking image (or images) since it will be overwritten?

Cover images - These are used as front cover images on the article's journal issue.

Should we add something like "eLife produces 'vanity covers' for authors, but the image used is a stock image and not what the author provides as a striking image)?

It is important not to load it to eJP if the article is already in the production system because the systems do not transfer further information with each other after export has occurred.The most efficient way to do this is to search the Production inbox for the XML notification, which informs production an article has been exported from eJP.

Suggest changing to (note also the missing space after the full stop):

It is important not to load it to eJP if the article is already in the production system because after export has occurred there is no further push of information from eJP to Kriya. The most efficient way to do this is to search the Production inbox for the XML notification, which informs production an article has been exported from eJP.

But suggestions welcome, don't think that's quite right yet!
Sorry, know it was my suggested wording originally!

To upload a striking image to an article, download the image provided by the author, go to the article in the Kriya dashboard and click on 'Striking image'.

 If you require access to this, please speak to a member of Production. You can use cloud storage browsers such as Cyberduck or Transit to view the bucket.

It's Transmit, not Transit :-)

For ease, you can search if an article has a striking image using the 'Search' bar and typing in the MS number.

Suggest changing to:

To find whether an article has a striking image using the 'Search' bar and typing in the MS number.

There are times when you may need to access the striking images bucket directly, for example, if an image is too large to upload via Kriya, Kriya is down, or a striking image has already been uploaded.

I know we discussed this, but it seems really inefficient loading it to Kriya. What are the benefits of loading it via Kriya? Could they be added?

It is typically easier, if you can, to use the Kriya dashboard as it sets up the initial folder and creates the .txt files automatically. In certain situations, mentioned above, you may need to manually create a folder for an article's striking image.

Suggest moving this to the start of the section about uploading via Kriya and reword it appropriately

To do this, you need to go to the 'elife-striking-images' bucket and create a new folder. You can either do this through the 'File' menu at the top left hand corner of your screen or right click to bring up this option on the 'elife-striking-images' bucket overview. Click 'New Folder...'.
.

Suggest adding hyphens between left and hand and also right and click

right-click - a late instance where this hyphen could be added:

Once it has finished uploading, you will need to right click on the file to rename it.

Open this folder and drag and drop the new striking image in to upload it. Make sure the striking image is titled appropriately - e.g. '56754-b_striking_image' if there is already a '56754-a_striking_image'.

Suggest changing to:

Open this folder and drag and drop the new striking image in to upload it. Make sure the striking image is titled appropriately - e.g. '56754-b_striking_image' because there is already a '56754-a_striking_image'.

In this scenario it's a given there is an "a" file in place already

Existing striking images

Please explain that Kriya will overwrite what's in the bucket already and that's why you need to do this process :-)

If you have multiple images to upload with captions, you may prefer to upload these all together through the Kriya dashboard. To do this, you should download any existing images and .txt files (if these contain any captions) from the bucket and upload these along with the new images as shown in the previous section.

suggest changing to:

If you have multiple images with captions to add to existing images provided by the author, you may prefer to use the Kriya dashboard. You will need to re-upload the old images at the same time as the new images to prevent overwriting. To do this, you should download any existing images and .txt files (if these contain any captions) from the bucket and upload these along with the new images as shown in the previous section.

However, if you are in eJP look at 'More Manuscript Info and Tools' on the right-hand side of the page

Suggest changing to:

However, if you are already in eJP look at 'More Manuscript Info and Tools' on the right-hand side of the page

The Features team work...

Change to

The Features team works...

The Features team work with authors to write Digests and often, during this correspondence the authors will send them striking images. Features will then forward on these emails to us.

There is a comma missing:

The Features team works with authors to write Digests and often, during this correspondence, the authors will send them striking images. Features will then forward on these emails to us.

Suggest changing
"Occasionally, eLife authors contact us expecting to see their striking image on the personalised poster which they can download from their 'The full version of your eLife article is now available' email they receive upon publication."
to
"Occasionally, eLife authors contact us expecting to see their striking image on the personalised poster which they can download from the publication notification email ('The full version of your eLife article is now available')."

Other than that, seems good to me.

'The most efficient way to do this is to search the Production inbox for the XML notification, which informs production an article has been exported from eJP.'
Can you add a screenshot of this email?

Just a minor point but you can delete the following text from the changelog:
'After Exeter has fed back on the page and it has been updated, any further changes to the page should be listed in order from oldest to most recent. '

That's all from me!

Just had a thought - do we need to cover what to do when an article has been PoA'd but not yet loaded in Kriya and the authors send a striking image through? Even if it's just 'leave a note on the email'?


About IMC 2023

Thank you very much for you works
I have some questions about IMC2023. I want to turn my pipeline with your Lightglue, my feature matching is superpoint and superglue which i get 0.65 in heritage_dioscuri scence
But i turn to superpoint and lightglue ,the scores is 0.48 ,i am very confused with the results beacuse the large decline .
It is Strange beacuse in other scences the scores improved.
The two ways have the same settings with resized to 1600 and the number of superpoint is 2048
Thank you

Thank you very much!
I will try more.

Hello,I want to confine some parameters about superpoint and lightglue . When using sp+lg ,the best parameters is
superpoint
"nms_radius": 8,
"max_num_keypoints": 4096,
"detection_threshold": 0.000,
lightglue
'depth_confidence': 0.95,  # early stopping, disable with -1
'width_confidence': 0.99,  # point pruning, disable with -1
"filter_threshold": 0.1,


Re-submit of Italian Language Support

Ok, I think I am doing it right this time.

Looks great, thanks! It's been merged to https://github.com/Smithsonian/dpo-voyager/tree/rc-46 for the next release.


"Plots" Lecture

WIP.

@jlperla Not urgent, but what do you think about adding UnicodePlots to this setup? In terms of playing around with stuff from a REPL or something, the convenience and speed is miles ahead of the rest.

For sure when we get to this document.  It is pretty cool.

Just writing this down so it's not forgotten, but could also be worth investigating https://github.com/JuliaPlots/Makie.jl Apparently it's the shiny new thing in terms of Julia visualization, and the plots look fantastic.

I am removing for now.  Vegalite and others are emerging.... and recipes are an essential part of the plots ecosystem.