[MRG] Uniform log accross scheduler + job id in log name

Superseeds https://github.com/clusterlib/clusterlib/pull/26

Coverage decreased (-0.69%) to 92.78% when pulling cb2ee53dfb2264014e6ee89597fe2b11db092e84 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling cb2ee53dfb2264014e6ee89597fe2b11db092e84 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling cb2ee53dfb2264014e6ee89597fe2b11db092e84 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling cb2ee53dfb2264014e6ee89597fe2b11db092e84 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling c87ebf34eecd99e17276541c77074a16a321f419 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling c87ebf34eecd99e17276541c77074a16a321f419 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.69%) to 92.78% when pulling f45a47df5ccbe32873f2f998ecdc9ad28e43189f on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.74%) to 92.73% when pulling e915ffd7e6ac1ff4ec0457f8606310cb10a4205a on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.74%) to 92.73% when pulling e915ffd7e6ac1ff4ec0457f8606310cb10a4205a on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-6.01%) to 87.46% when pulling a6716a749b8a0e7457d314db356a71530109fbcf on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-0.59%) to 92.88% when pulling 9a39c934231d652f5b455d108a8f7d3fd7ad4b48 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage decreased (-7.35%) to 86.12% when pulling 5ccc67a00c7049fc6b0fd0c470e80f22d81ad385 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

@ogrisel This should be ready for a last look before squashing everything and merge it to master.

Coverage increased (+1.19%) to 94.66% when pulling 5ccc67a00c7049fc6b0fd0c470e80f22d81ad385 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

@ogrisel I would like to merge this before the week end. If you don't have time to review, it's not a problem. Cheers!

@ogrisel I will merge this in the evening. Furthermore, I have added some doc to fix https://github.com/clusterlib/clusterlib/issues/30

Coverage increased (+1.19%) to 94.66% when pulling 72ffa9fd3aa5f32b8cfa3afe99b3a44be7c9b5a4 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 72ffa9fd3aa5f32b8cfa3afe99b3a44be7c9b5a4 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 72ffa9fd3aa5f32b8cfa3afe99b3a44be7c9b5a4 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 72ffa9fd3aa5f32b8cfa3afe99b3a44be7c9b5a4 on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 848083aba9d2177d33c983d82e050895d317f55b on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 848083aba9d2177d33c983d82e050895d317f55b on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 848083aba9d2177d33c983d82e050895d317f55b on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

Coverage increased (+1.19%) to 94.66% when pulling 848083aba9d2177d33c983d82e050895d317f55b on arjoly:uniform-log into 9362b8ceaa39d5b6aa3a5292693a7f8bbd65e8d0 on clusterlib:master.

merged :-) thanks @ogrisel

Thanks @arjoly. Sorry for the lack of feedback. I plan to resume work on clusterlib soon-ish.


Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That is the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/

Thanks @gmlewis - your contribution is much appreciated. Good luck with your PR campaign!

For users coming late to this issue, you need to understand a few things:

We don't maintain the legacy folder. This change was contributed by someone working on getting everyone on GitHub using this particular version to upgrade. We might not be so lucky next time, so if you are using the legacy code please let us know. If there is enough interest we would consider spinning out a separate project.

We don't use the kind of object serialization that would allow exploitation of this vulnerability. However...

This fix doesn't close the entire security hole. If you are exposing things like XML-RPC, JMX, remote debugging, etc to untrusted peers (i.e. the Internet) you are still exposed. Stop it.


Plugin formats space-indented JSDoc comments

When using tabs as indentation, the following situation gets incorrectly formatted:
/**
 * Makes sure VIM Whitespace control knows the file is tabs
 */
function foo(){
	const identation = '<-- tab'
}

Gets formatted to
/**
* Makes sure VIM Whitespace control knows the file is tabs
*/
function foo(){
	const identation = '<-- tab'
}

Note the dedenting of the JSDOC comment.

Fixed


Fixing #9 : Added dark Mode

Fixes #9
Added dark mode.
Theme Mode is changed to themeMode.system
Will add toggle button for switching between dark mode and light mode soon.

Should I also have to change the button color?

Should I also have to change the button color?

Yeah you can use 0xFF3172F5 for the buttons.
And, the colors that I have mentioned earlier, use the lighter one for the appBar and the darker one for the rest.

I have made the required changes. Please review it

@noman2002 Kindly let us know which program are you a part of so that we can provide the appropriate labels to the PR

@smaranjitghose Please provide the tags for LGMSOC. I'm part of lgmsoc program.


Some minor contributions

These are a few that I'm guilty of using over the years that I didn't see in the list.

Thank you so much!


29 duplicate symbols for architecture i386

Hello, how to fix this problem please tell me. i can't run ibactionsheet, because is shown this error.
here you have all errors in a note:
http://justpaste.it/kxad

Your errors refer to JGActionSheet which I'm not familiar with.  If you are having issue with it I would recommend talking to the developer of it.


Clarify the starting offset for Event Hubs ingestion

Hi! Would it be possible for this document to clarify the initial offsets used for Event Hubs ingestion? In my testing it appears that it uses the latest position - that is, it will only start reading events published after the connection is created. Is there any way to set an initial offset / timestamp or to specify that it should read all available events upon creation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 48946887-6f4c-9fc9-a3ba-1609b1059cab
Version Independent ID: 73781e6f-3343-5abf-e483-05c0dac13075
Content: Ingest from Event Hub - Azure Data Explorer
Content Source: data-explorer/ingest-data-event-hub-overview.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

@joelw - Thanks for posting the question. We are looking into it and will update you shortly.

@orspod - As per my understanding, it is not configurable today. Can you please share your thoughts on the ask.

@kerend and @LeaShallev - will you respond re: the question?

@kerend and @LeaShallev can you assist with this question? Thanks.

Please see the note on the subject - events are ingested from the moment the connection was created.

Ah! You're absolutely correct. I did not see that for some reason. Thank you and sorry for the trouble!

@joelw since your questions was answered I will now close your issue.
@kerend thanks for the assistance


RFC: Date Picker

Which scope/s are relevant/related to the feature request?
date-picker
Information
TBD
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue

[X] Yes
[ ] No

This is a light wrapper around the calendar component so we will tackle this after!


drag_window scuffed even on Windows

Describe the bug
https://user-images.githubusercontent.com/5992217/138809615-738f3334-7306-4fab-81c7-1bbabcdddedd.mp4
Expected behavior
Either:

A clean drag, or
The documentation to note that it's awkward on Windows as well as macOS and impossible on the web

Desktop (please complete the following information):

OS: Microsoft Windows (10 Education) Version 21H1 (OS Build 19043.1288)

Additional context
My original code
impl epi::App for _ {
    fn update(&mut self, ctx: &egui::CtxRef, frame: &mut epi::Frame<'_>) {
        let InnerResponse { response, .. } =
            egui::TopBottomPanel::top("top_toolbar").show(ctx, |ui| {
                egui::warn_if_debug_build(ui);
            });

        if response.hovered() {
            frame.drag_window();
        }

        egui::CentralPanel::default().show(ctx, |ui| {
            ui.label("Hello, world");
        });
    }

was even more scuffed, never leaving the jitter phase. Funnily enough, it's jittery enough that it triggers Windows's "wiggle a window around to minimize all other windows" feature, even if I'm moving my cursor smoothly.

@CAD97 Hi, I have the same trouble on my Windows.
I've created PR with the fix. Can you check it for your case?
More info here:
https://github.com/emilk/egui/issues/943


pubsub: unit tests cause emulator to use excessive CPU

The pubsub emulator recently started using large amounts of CPU on OSX during our unit tests (other platforms untested). High CPU usage persists after the test suite has completed and all clients disconnected, until the process is restarted. I am able to reproduce this behaviour with simple clients and with google-cloud-go's own test suite.
Steps to reproduce:

Start the emulator:
gcloud beta emulators pubsub start --host-port=localhost:8822
In the directory cloud.google.com/go/pubsub, run the test suite:
env PUBSUB_EMULATOR_HOST=localhost:8822 go test -v

On my system, the pubsub emulator Java process CPU usage is at 45% after one run, 145% after the second run, and so forth.
This is undoubtedly a bug in the emulator, but git bisect shows that google-cloud-go only started triggering the issue with commit 927c81288027fdcd2bebdeac522c799440e988a4. This commit is included in the v0.10.0 release.
Software versions used:

google-cloud-go master
pubsub-emulator 2017.03.24
OSX 10.12.5

Thank you for the detailed analysis. That commit increases the number of worker goroutines from 1 to 10*CPU. So this makes a lot of sense.
Against the real service, this shouldn't be a problem, since pubsub service tries to keep connection open and respond only when there are messages to send. Emulator seems to not do this, leading to the CPU consumption you saw.
In your test, could you try adding sub.ReceiveSettings.NumGoroutines = 1? This should bring CPU consumption back to the level before the commit you linked.

Ah, I'm sorry. I misread the part where you said "High CPU usage persists after the test suite has completed". I'll loop in the emulator folks.

The fix for this has been made to the emulator and going to be published soon.
We've also scaled back NumGoroutines, so this should alleviate the problem in the mean time.
I'll close this for now.


🐞 Editor Crashes After renaming a file

Description
Renaming files crashes the text editor
To Reproduce
Step to reproduce
1 - Open a swift project
2 - Rename a file, the No Editor will be displayed
Moreover, none of files will display anything.
Expected Behavior
I expected to be able to use continue using the editor instead of not displaying any content of files
Version Information
CodeEdit: [0.3.0]
macOS: [15.0]
Xcode: [16.1]
Additional Context
No response
Screenshots
No response

I have a PR open that should fix this! A few root causes with this bug but should be fixed with the next release.

I have a PR open that should fix this! A few root causes with this bug but should be fixed with the next release.

Thank You!


[PSA] Devtools Next for Vue 3 + Vite users

We are aware that the latest 6.6 version has a number of issues and are looking into it.
In the meanwhile, if you are using Vue 3 + Vite, consider using devtools-next instead. It is being more actively developed. For now it is only available as a Vite plugin or an Electron app, but will eventually replace the current extension in the future.

Update: current Devtools 6.6.3 should have addressed the memory issue in 6.6.0~1, please report here if you are still running into memory issues / crashes with 6.6.3.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/817 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit ab8b17a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Screen resolution: Email addresses cut off

Depending on the screen resolution, graphs/ tables are ordered/displayed differently (presumably to fit the available space) thus causing long email addresses to be cut at different lenghts.
In all tested screen resolutions, rows 1 and 2 display the counts (mails total etc.) and the activity graphs (Y/Q/M/Q and activity in 2021), respectively.

1680x1050 - Two more rows displayed. Third row: graphs for Daytime, Weekday, Month; Fourth row: Temporal distribution, Most received from, Most sent to.
2560x1440 - Only one more row, displaying graphs for Daytime, Weekday, Month, Temporal distribution, Most received from, Most sent to.
1080x1920 - Three more rows displayed. Third row: graphs for Daytime, Weekday; Fourth row: graph for Month, Temporal distribution; Fifth row: Most received from, Most sent to.

In all of the resolution, longer email addresses (listed in either Most received from or Most sent to) are cut off, at around 44 characters (resolution 1), 32 characters (resolution 2), and 41 characters (resolution 3).
Possible solution: Make "widgets" (i.e. little unit displaying a graph or list of addresses) scalable so that view can be adjusted.

Thank you for this detailed report 👏🏻
I already revamped the stats page layout with #231 (organizing all charts in tab groups) and now improved responsiveness even more with #238. That means:

Resolution 1 should now show all characters as this is now a one column view
Resolution 2 should now show a lot more characters too (I only tested up to 50 characters)
Resolution 3 still shows around 42 characters (depending on the character width)

I will not further optimize this as you can always see the full email address in the corresponding tooltip. Implementing resizable widgets will be high effort for little benefit. I hope this is ok for you.
You can download the latest build here, if you can't wait for the next release:
https://third-stats.cdn.devmount.com/

Thank you for this detailed report 👏🏻
I already revamped the stats page layout with #231 (organizing all charts in tab groups) and now improved responsiveness even more with #238. That means:

Resolution 1 should now show all characters as this is now a one column view
Resolution 2 should now show a lot more characters too (I only tested up to 50 characters)
Resolution 3 still shows around 42 characters (depending on the character width)

I will not further optimize this as you can always see the full email address in the corresponding tooltip. Implementing resizable widgets will be high effort for little benefit. I hope this is ok for you.
You can download the latest build here, if you can't wait for the next release:
https://third-stats.cdn.devmount.com/


[No QA] [TS migration] Migrate 'Permissions.js' lib to TypeScript

Details

Migrate 'Permissions.js' lib file to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/24809
$ https://github.com/Expensify/App/issues/24827
$ https://github.com/Expensify/App/issues/24868
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/41169160/302f662d-fe69-4e2c-9eee-a25653d06723

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

https://github.com/Expensify/App/assets/41169160/86b66cf8-ce3d-4b22-b78f-066d7e9e339b

Android

https://github.com/Expensify/App/assets/41169160/baa7080b-98c1-43dc-b634-0ca7c1fb3512

Unit tests seem to be failing

@BartoszGrajdek Why are we migrating this mocks files?

Hi, sorry for the confusion... We were discussing this issue internally - it turns out that the Permissions file and mocks for unit tests related to the Permissions need to be migrated at once, otherwise the unit tests will be failing. We aren't sure yet if this solves this problem 100%, so let's hold on with this issue for now (I'm removing cross-review from spreadsheet as well). Tomorrow me and Błażej will try to solve all these problems. @fabioh8010

We still seem to have some tests failing. How is that going?

@Gonals Working on it now 👍

Nice!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


C58922: Missing backticks

Hello, @rmcmurray,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.
Many thanks in advance.

Hello, @rmcmurray,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Cc: @mbaldwin, @JennieHubbard @arob98 @nokura

Hello, @rmcmurray,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Cc: @mbaldwin, @JennieHubbard @arob98 @nokura

Hello, @rmcmurray,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Cc: @mbaldwin, @JennieHubbard @arob98 @Alisha-Acharya

Hello, @rmcmurray,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Cc: @mbaldwin, @JennieHubbard @arob98 @Alisha-Acharya

@SunnyDeng @SonjaSaltzman  @tysonn This is something @v-makoud can just change and merge.

@v-maudel As we talked last week, please do the self-signoff.
thanks

cc @v-makoud

Hi @SunnyDeng ,
We agree to sign off PRs that contain known issues or obvious changes but unfortunately this repository doesn't have automation feature.
Regards.

 This is the expected behavior of the build system.

OPS Build status updates of commit 78815bd:
:warning: Validation status: warnings
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Already corrected in master.


Change Convert dialog and h_img output files

Description:

If we use inline instead of inline constexpr I think it will still work with pre-C++17 compilers, they just won't make the variable unique. We should confirm that, and if so, remove the C++17 option from the Embed dialog and always prefix with inline.
The Embed dialog should have an option to include the GetImageFromArray() function that we use for embedded images. Since it's prefixed with inline it's fine to put it in a header file that's included in more than one place. The one caveat is that it should be in the wxue_img namespace to avoid conflict -- which also means the generated class constructors also need it in their namespace section.
If the array is also within the wxue_img namespace then the header file can be used interchangeably with the Embed command as long as the original art doesn't change. For a C++17 compiler this will automatically prevent duplicates.

The convert dialog has been removed (except in Debug builds) and support for h_img as an output format has been removed. As such, this issue is no longer relevant.


The pattern inferred as an integer instead of a boolean.

Describe the bug
Assuming the case mentioned below should be correct, but it fails as it is inferred as an integer type.

    assert result.columns[0].inferred_type == expected_shmessy_type
E       AssertionError: assert 'Integer' == 'Boolean'
E         - Boolean
E         + Integer

To Reproduce
@Parametrization.case(
    name="Base case - 1 / 0 as string",
    df_data={
        "test_column": ["1", "0", "1", "1", "0", "1", "1", "0", "1", "0"]
    },
    expected_result=[True, False, True, True, False, True, True, False, True, False],
    expected_shmessy_type="Boolean",
    expected_numpy_type=np.dtype("bool")
)

Desktop (please complete the following information):

OS: win11
python version: 3.11

@ohadmata is that a bug?

@DanielAvdar It passes on my laptop (mac) and the CI. Were does it failed?
It is happen only in win11/python3.11?

@DanielAvdar It passes on my laptop (mac) and the CI. Were does it failed? It is happen only in win11/python3.11?

@ohadmata, please take note that this is a new test. #118

#119


Sniper turret shooting base layer has near-transparent shadows

Shadows are not fully masked, need to be removed

Also the raising base layer.


Please correct the installation Manual

Hi,
idk if it's platform-related or version-related but on Windows there's no menu called "Entitas" on the toolbar. It's under "Tools". I know it's not a big deal but I was still confused for a while thinking there was some kind of an error.  And just generally the installation process is very vague and missing a few steps.
Thank you

Who volunteers to update the wiki :)

I'm talking specifically about the "tutorials" section of wiki.

But yes, you're right. Entitas used to be a top level menu item. Unity requires asset store menus to be under Tools, so I changed it to Tools/Entitas

Btw, feel free to update sections in the wiki that are not correct or outdated.

Updated the tutorials section.

I replaced the installation section of that tutorial entirely with link to the new dedicated step-by-step guide I made over a week ago. This new page rendered that section unnecessary and repetitive. I also moved the troubleshooting section to FAQ page and plan to update the install guide to cover that issue as well.

Very nice :)

Okay, I just spent way too much time updating the step-by-step guide to address both project path and script assemblies issues, but it should be pretty comprehensive now. Still have no idea why I'm spending so much time updating the docs for a framework I don't even use! 😆 😕 I think I might be broken or something.


Changing Namespace Prefix?

All the SAML requests/responses that I am able to generate are formatted with a namespace prefix of "ns0", or "ns1". The IdP that I am using requires the namespace prefix to be 'saml2p' or 'samlp' instead.
For example, here is an AuthnRequest that I generate using the pysaml2 library:
<ns0:AuthnRequest AssertionConsumerServiceURL="http://myserviceprovider:8000/saml/acs"
        Destination="https://oktapreview.com/app/myserviceprovider/k40ctg3zVVFQYUMEJFTB/sso/saml"
        ID="id-02a0e2290bbc7fda421483af6b02a9a5" IssueInstant="2015-01-20T22:57:02Z"
        ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Version="2.0"
 xmlns:ns0="urn:oasis:names:tc:SAML:2.0:protocol">
    <ns1:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity" xmlns:ns1="urn:oasis:names:tc:SAML:2.0:assertion">http://myserviceprovider:8000/metadata.xml</ns1:Issuer>
    <ns0:NameIDPolicy AllowCreate="true" Format="urn:oasis:names:tc:SAML:2.0:nameid-format:transient"/>
</ns0:AuthnRequest>

Is it possible to change the namespace 'ns0' and 'ns1' to 'saml2p' and 'samlp'?
I am creating the above AuthnRequest using the Saml2Client.prepare_for_authenticate method.

2 feb 2015 kl. 03:01 skrev steveroger<EMAIL_ADDRESS>All the SAML requests/responses that I am able to generate are formatted with a namespace prefix of "ns0", or "ns1". The IdP that I am using requires the namespace prefix to be ’saml2p' or 'samlp' instead.

That IdP is broken !
That statement probably does not help you :-)

For example, here is an AuthnRequest that I generate using the pysaml2 library:
<ns0:AuthnRequest AssertionConsumerServiceURL="http://myserviceprovider:8000/saml/acs"
Destination="https://oktapreview.com/app/myserviceprovider/k40ctg3zVVFQYUMEJFTB/sso/saml"
ID="id-02a0e2290bbc7fda421483af6b02a9a5" IssueInstant="2015-01-20T22:57:02Z"
ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Version="2.0"
xmlns:ns0="urn:oasis:names:tc:SAML:2.0:protocol">
<ns1:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity" xmlns:ns1="urn:oasis:names:tc:SAML:2.0:assertion">http://myserviceprovider:8000/metadata.xml</ns1:Issuer>
<ns0:NameIDPolicy AllowCreate="true" Format="urn:oasis:names:tc:SAML:2.0:nameid-format:transient"/>
</ns0:AuthnRequest>
Is it possible to change the namespace ’ns0' and 'ns1' to 'saml2p' and 'samlp'?

Not in an easy way.
If you’re signing your request then I would say it’s too complicated right now.
If you’re not there is a modification you can do to the code.
I might bring this into the main branch but not right now and when and if I do it will work also for signed requests.
Anyway back to the what you can do.

I am creating the above AuthnRequest using the Saml2Client.prepare_for_authenticate method.

There is this line (line 74 in my version) in prepare_for_authenticate:
_req_str = ”%s” % req
if you rewrite it to be:
_req_str = req.to_string(nspair={”saml2": saml.NAMESPACE, ”saml2p”: samlp.NAMESPACE})
you should get what you want.

Roland

"It is the consequence of humanity. We are all formed of frailty and error; let us pardon reciprocally each others’ folly - that is the first law of nature.” - Voltaire

Checked in fix that allows you to give name space prefixes as argument to prepare_for_authenticate.

Thanks for the help and the fix. Everything worked as expected.


Pass session around

We should have a Session to pass around to all nodes that need to be evaluated. With this session, we can pass dependencies around (such as the repository pool for gitquery) and any other dependencies that are needed elsewhere in the code along with user data, if any.
Possible use cases for this:

request-scoped metrics
dependency injection
passing of session data

Any thoughts? /cc @ajnavarro @mcarmonaa @jfontan
Proposal:
A way of implementing this in a way that's not very disruptive to the current API would be the following:

Implement a Session type. It could either be a concrete type or an interface with a base implementation that can be extended to provide extra features (this option could be really powerful for gitquery).

type SessionData struct { /* yada yada */ }

type Session interface {
	Data() SessionData
        // yada yada
}

type BaseSession struct {
	data SessionData
}

func (s BaseSession) Data() SessionData {
	return s.data
}

// another file or even another package

type CustomSession struct {
	BaseSession
	mything MyType
}

// inside an UDF, for example
customSess, ok := session.(*CustomSession)
if ok {
	customSess.mything.foo()
}

Change the signature of Expression.Eval to Eval(Session, Row) (interface{}, error)
Change the signature of Node.RowIter to RowIter(Session) (RowIter, error)
Change the signature of AggregationExpression.Update to Update(session Session, buffer, row Row) error
Change the signature of AggregationExpression.Merge to Merge(session Session, buffer, partial Row) error
Change the signature of Aggregation.Update to Update(Session, Row) (Row, error)
Change the signature of Aggregation.Merge to Merge(Session, Row)
Change the signature of Aggregation.Eval to Eval(Session) (interface{}, error) (and make it return an error, while we are at it

That's about all the places that would need the session passed around. Then it's the job of whoever calls these methods to provide them the session and so on.

Hmm, in my opinion, I see the session more like a global entity that can be accessed from any place, more than a parameter that is passed throught the tree. What do you think, can yo add more explained use cases for this?

But how can it be accessed from elsewhere? Like a singleton? The UDFs, for example, would need it for dependency injection and so on.

We were thinking about having a Context instead of a Session at that level. Then we can have a Session into the Context, and also we can cancel queries executions.

Makes sense.
On Tue, 27 Feb 2018 at 16:44, Antonio Navarro Perez <notifications<EMAIL_ADDRESS>wrote:
We were thinking about having a Context instead of a Session at that level. Then we can have a Session into the Context, and also we can cancel queries executions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/src-d/go-mysql-server/issues/36#issuecomment-368922158, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQFF1DVv-NCpbWDW5Va-vJ-uTuNAkFEks5tZCLggaJpZM4SN3Co.

Going ahead with the first proposal, but Session will implement Context too.

Should we also make it have a Cancel method? It depends if we want to let nodes control when the session is cancelled or not.
On Thu, 1 Mar 2018 at 12:09, Antonio Navarro Perez <notifications<EMAIL_ADDRESS>wrote:
Going ahead with the first proposal, but Session will implement Context too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/src-d/go-mysql-server/issues/36#issuecomment-369558736, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQFFy9Pf6vK4p2lFwHlRcvz2VD8lJDSks5tZ9bQgaJpZM4SN3Co.

I think nodes shouldn't cancel a session... Can you put an use case for that?

Yeah, you're right, nodes shouldn't.


[Doc] [5.7.0] Configuring X509Certificate Authenticator

The doc [1] for Configuring X509Certificate Authenticator in IS 5.7.0 is incorrect. The following are the corrections to made specifically for 5.7.0 version.

Do not need to add org.wso2.carbon.extension.identity.authenticator.x509Certificate.connector-X.X.X.jar, already available in the product.
Do not need to add x509certificateauthenticationendpoint.war, already available in the product.
Disable crlvalidator and ocspvalidator in the registry through the management console

[1] https://docs.wso2.com/display/ISCONNECTORS/Configuring+X509Certificate+Authenticator#6b39a9c6aacc4b998fa20e098aec2215

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


"Can not create database...Locked, space ?" on wiff files

Sorry for bothering again, David xD
I have tried to convert my wiff files to mzdb, and have encountered this error.
I1118 17:40:57.769676 10112 mzdb_writer.hpp:232] AB Sciex metadata extractor created
I1118 17:40:57.785310 10112 mzdb_writer.cpp:406] updating dataProcessing...
I1118 17:40:57.785310 10112 mzdb_writer.cpp:1051] DDA / DIA test
I1118 17:42:07.225293 10112 mzdb_writer.cpp:1056] DDA Mode detected
I1118 17:42:07.225293 10112 raw2mzDB.cpp:611]

************ Summary of the parameters ************

Treating file: Cursos GTPB\formicicum_proteomics\wiff\CS1_1uL.wiff (DDA ABI WIFF format)
MS 1    Selected Mode: FITTED
MS 2    Selected Mode: CENTROID

Bounding box dimensions:
MS 1    m/z: 5 Da, retention time: 15sec
MS n    m/z: 10000 Da, retention time: 0sec

I1118 17:42:07.225293 10112 mzdb_writer.hpp:352]
I1118 17:42:07.225293 10112 mzdb_writer.hpp:353] SQLITE VERSION: 3.8.9
I1118 17:42:07.225293 10112 mzdb_writer.hpp:354] ProteoWizard release: 3.0.7320 (2015-3-18)
I1118 17:42:07.225293 10112 mzdb_writer.hpp:355] ProteoWizard MSData: 3.0.7303 (2015-3-13)
F1118 17:42:07.272192 10112 mzdb_writer.hpp:360] Can not create database...Locked, space ? Exiting
*** Check failure stack trace: ***

I have not been able to find the stack trace as well. Without error traceback, I do not know how to deal with this issue.
Thank you for your attention

Hi João,
Try to use "/" or "\" in your path instead of "". The converter does not understand the "" as a separator and so it tries to create a file named "GTPB\formicicum_proteomics\wiff\CS1_1uL.wiff.mzDB" which is not allowed by the system.
I'm sure it's just that :)
Alex

Thank you, the problem was in fact in the input, but I didn't quite understand what you said. I had a space in the path to the file, after changing with underscore it was fixed!


All of plugins brokem after aliucord update

They just dont load with the message saying that there is no mainfest for them

This isn't my plugin.

To come back on this, I can safely say this is an Aliucord issue. All my plugins have a manifest.
Try to reinstall the plugins, see if that fixes it. If not, complain to the Aliucord maintainers.

all other plugin devs have already updated their plugins to the new mainfest thats why none of your plugins and ltmgfy work -_-


🐛 A double click in the text on a zone without text does not select the text.

Describe the bug
If we double click on the text in a textbox, the text is selected. But if we click on an "empty" area of the textbox, the text if not selected.
For example, if we double click here:

On Windows that's generally the case (and that's the case on WinUI3 Gallery).

This looks more like a Flutter issue. We make use of Flutter's EditableText.
I don't think we can workaround this issue in any ways because we'd intercept taps, and that can cause unexpected issue

This is not reproducible with the latest version of fluent_ui and Flutter. Closing as not planned


[Test] Add two lexical lifetime verification tests.

Verify that lexical-lifetimes and copy-propagation interact correctly to keep objects named by variables alive in a couple interesting cases: unsafe pointers, synchronization point calls.

@swift-ci please test

@swift-ci please smoke test and merge

Build failed
Swift Test Linux Platform
Git Sha - d8e01ef9d73322312df3633d92d882ae63a280ef

Build failed
Swift Test OS X Platform
Git Sha - d8e01ef9d73322312df3633d92d882ae63a280ef


core: fix PydanticOutputParser typing in LCEL chains

By subclassing the JsonOutputParser, the PydanticOutputParser wasn't propagating the typing information from #18740 to the BaseOutputParser. This change removes JsonOutputParser as a subclass and instead directly subclasses BaseCumulativeTransformOutputParser so we get the correct typing when using LCEL.
Before:

After:

@eyurtsev One last typing fix for the pydantic parser when you have time

would prefer a fix that still mains the inheritance


Add AES GCM Python utility

Added the AES GCM Python utility.
The following documents will be submitted by Monday EOD.

SonarQube Report
Code Coverage Report
User Guide and Instructions - Readme.md

Didnt find the readme.md


[BEAM-1108] DataflowRunner: remove deprecated TEARDOWN_POLICY control

R: @davorbonaci
CC: @pjesa

Looks good. Pending tests.

LGTM. Please self-merge.


Databus on Kubernetes

Running multiple instances with mods on Kubernetes

Ceph.io seems cool. I found this<EMAIL_ADDRESS>They disable object-map, fast-diff, deep-flatten for docker.  I mean ceph.io can be mounted as a normal file system, so it might work. However, it get's much slower: https://yourcmc.ru/wiki/Ceph_performance

I think it’s performance should be enough for writing metadata and data files… for SPARQL endpoint  this may be too slow… this needs thorough testing, which is unlikely we will do atm, but at the start this should be good enough


#10 対応

closes #10

Codecov Report

Merging #12 (adff77e) into main (a0beca2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   97.34%   97.34%
=======================================
  Files          10       10
  Lines         188      188
  Branches       24       24
=======================================
  Hits          183      183
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0beca2...adff77e. Read the comment docs.


sfdx force:org:list does not display scratch org under scratch org list

Summary
Scratch orgs are shown in Hub/Org list and not in scratch org.
Steps To Reproduce:

Run sfdx force:auth:web:login -r https://test.salesforce.com -a kv0508
Run sfdx force:org:list
scratch org is shown under Org list

Expected result
scratch org should be displayed under scratch org list.
Actual result
scratch org is shown under Org list
Additional information
Feel free to attach a screenshot.
SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.57.1-dbf54fc584 darwin-x64 node-v10.15.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
sfdx plugins --core
OS and version:
MacOS 10.15.4

@kvor , I am unable to reproduce this. Is this still an issue? Are there any further details you could provide that could potentially help me reproduce this?When you go into the auth file of any scratch org thats being displayed in the org list, what fields do you see?

@nramyasri-sf  Yes it is still reproducible. Scratch orgs are displayed in Hub Org list. I am not sure how you are trying to reproduce it.
This is a scratch org info which we see it Org list and not in Scratch org list
      {
        "username"<EMAIL_ADDRESS>        "orgId": "00D210000003ZSIEA2",
        "accessToken": "xxx",
        "instanceUrl": "https://site-inspiration-3834-dev-ed.cs26.my.salesforce.com",
        "loginUrl": "https://test.salesforce.com/",
        "clientId": "PlatformCLI",
        "alias": "kv0508",
        "lastUsed": "2020-05-15T05:33:11.519Z",
        "connectedStatus": "Connected"
      },

And this is another scratch org where multiple users are now displayed
      {
        "username": "test.ip_viewer+0511-8deaac0eb7d7@xxx",
        "orgId": "00D8A000000C4A4UAK",
        "accessToken": "xxx",
        "instanceUrl": "https://momentum-force-2xxx-dev-ed.cs45.my.salesforce.com",
        "loginUrl": "https://CS45.salesforce.com",
        "clientId": "PlatformCLI",
        "createdOrgInstance": "CS45",
        "created": "1589092101000",
        "devHubUsername": "xxxx",
        "scratchAdminUsername": "0511-8deaac0eb7d7@xxx",
        "userProfileName": "IP xxx",
        "userId": "0058A000004Pp9QQAS",
        "expirationDate": "2020-05-25",
        "lastUsed": "2020-05-11T10:12:05.067Z",
        "status": "Active",
        "isExpired": false
      }
  {
        "username": "0511-8deaac0eb7d7@xxx",
        "orgId": "00D8A000000C4A4UAK",
        "accessToken": "xxx",
        "instanceUrl": "https://momentum-force-2xxx-dev-ed.cs45.my.salesforce.com/",
        "loginUrl": "https://CS45.salesforce.com",
        "clientId": "PlatformCLI",
        "createdOrgInstance": "CS45",
        "created": "1589176822631",
        "devHubUsername": "xxx",
        "isDevHub": false,
        "expirationDate": "2020-05-25",
        "alias": "0511",
        "lastUsed": "2020-05-12T09:16:18.081Z",
        "status": "Active",
        "isExpired": false,
        "signupUsername": "0511-8deaac0eb7d7@xx",
        "createdBy": "xxx",
        "createdDate": "2020-05-11T06:00:10.000+0000",
        "devHubOrgId": "00D30000001GuvSEAS",
        "attributes": {
          "type": "ScratchOrgInfo",
          "url": "/services/data/v48.0/sobjects/ScratchOrgInfo/2SR4Q000000HjyFWAS"
        },
        "orgName": "IPfolio",
        "edition": "Developer",
        "connectedStatus": "Unknown"
      }

It seems that something was changed in last 2 versions and breaks force:org:list response.

@clairebianchi Is there any status update on this?

@kvor the short answer is that we add scratch orgs to the scratch org list when they're created from a hub using org:create (and the auth files include information about the hub so future org:list can ask the hub about the org's status.
If you do what you did (web:auth to an org that you got login credentials for) there's not an easy way for the CLI to know that it is a scratch org OR which hub created it (possibly even a hub that CLI isn't auth'd to) so it's treated like a non-scratch org.

I'm also seeing scratch orgs not being listed in sfdx force:org:list.
I have just created one with this sfdx force:org:create -s -f config/project-scratch-def.json --json -d 30 -a  my-scratch and the org was created and can be seen in our dev hub.
I can also run commands using the alias my-scratch, but it's just not appearing in the list results. For example if I run sfdx force:org:display -u my-scratch then I see the details.
Currently using sfdx-cli/7.92.0-88320113e7 linux-x64 node-v14.15.4
Happy to do further commands/digging if it helps @mshanemc .

Ah I wonder if this is related to #940, could be.


Disable AuxPoW mining in the beta client

utACK, mining on the first beta is not a good idea, agreed. Waiting for the patch by @patricklodder so we can focus on testing this part more until next beta.


[windows][cws] Fix stats crash on map

Collecting stats can cause a crash on concurrent map access. This change adds a mutex to protect the maps.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Run in performance environment.  Ensure there aren't spurious system probe restarts.

/merge


Cross-platform build (tsc alternative)

What this PR does / why we need it:
Provides cross-platform build possibility by using tsc clean capabilities instead of os specific command line.
Closes #60
Alternative to #62
Special notes for reviewers:
Additional information (if needed):

Hi @JBBianchi
the problem I see with this approach is that if you delete a file (from the src folder) the transpiled js files are not removed from the dist folder.
Personally I prefer the other approach ( #62 ) , what do yo think?

The output directory might indeed have "ghost articfacts", I'll close this PR in favor of #62


[MM-26960] Fix Archive Icon not showing up for archived channels on system console > Channels page

Summary

Archive icon not showing up on channels page for archived channels is fixed in this PR.
Ticket Link

https://mattermost.atlassian.net/browse/MM-26960
Screenshots

Why 3 different classes applied on all 3 elements instead of just applying one class?

Why 3 different classes applied on all 3 elements instead of just applying one class?

No reason. Probably can do that ... Just didn't realise or atleast I thought this way was better haha. Will fix that up

Why 3 different classes applied on all 3 elements instead of just applying one class?

I just realised that not all of them use the 3 properties. Only some of them use some so it's easier to break it out into 3. Do you still think better if I merge together somehow?

Thanks @hahmadia - this is fixed and the archived icons are showing up correctly for archived channels in System Console > Channels page.
Just a question... On the Jira ticket there is a note as follows - has the E2E cypress test been fixed too?:

NOTE: Also please modify the archived_channels_spec.js and ensure the E2E cypress test is working fine, when this issue is fixed.

Oddly enough, I looked at that test and it has nothing to do with the system console portion or the work I'm doing. That test deals with the chat facing side of things as it's doing a cy.visit(/${team.name}/channels/${testChannel.name}); which has nothing to do with my work. I believe that test is okay to be left alone.

As per @srkgupta comment on the Jira ticket, this is suppose to be cherry picked and merged into 5.26 release branch.


Switch to yield the select to the block

accept select on x-option
use select on x-option when register
fallback to nearestNeighbor for non-ember-2 beta
yield select to the block in handlebars
pass the select for blockless version

Attempt to resolve #44.

I'm going to go ahead and close this since this bug is actually an ember bug. It should be fixed in 1.13.4. If not we'll revisit :D

This bugfix is gone in ember 2 beta. I believe it was intentionally removed. So, this will probably be broken again shortly.
This PR supports both the explicit yield, and the old syntax in 1.13.4. And it appears to be the way ember wants components to move.

This bugfix is gone in ember 2 beta.

Can you point me to what you mean? nearestOfType should continue to work in 2.0.0-beta.3...

I'm also unsure how well the addon works in the beta right now. We need to upgrade ember-mocha to see where our test suite is at :)

I'll try beta 3. It just appeared that the conversation was saying the code is or would soon be deprecated. I'm mostly concerned because I can't find the bug fix from 1.13.4 in master in nearestOfType.

https://github.com/emberjs/ember.js/issues/11170 That conversation.

FWIW, I actually would prefer to not use nearestOfType, and once we can yield component helpers as block params it would be unecessary. Until then, it does provide the nicest api to the user.

From https://github.com/emberjs/ember.js/issues/11170#issuecomment-105060642:

We decided not to deprecate accessing parentView at the moment because it does not make much sense to force component authors to switch to an alternative now only to switch to scoped helpers based solution when that lands (hopefully in an early 2.x release).

tldr; what @cowboyd said :smiley_cat:

@rwjblue Is that bug fix in Ember 2 beta? I couldn't find the code for it.

@tpitale - The actual code changes to fix the behavior has changed (done a different way now), but all the tests added in https://github.com/emberjs/ember.js/pull/11266 are still included and passing on beta and canary of Ember.

Thanks @rwjblue. I'll try beta 3.


ERROR CUPS Unable to get PPD file

Please I need some help, I have my print server on a server with oracle Solaris 11.3 for sparc, for some reason the 12 printers stop printing and right now I just have 2 of them working, this happen eventualy and I donpt know what is the problem. these is the error_log
W [15/Jul/2019:23:30:22 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [15/Jul/2019:23:38:20 +0500] [CGI] Bad SNMP packet from <IP_ADDRESS>: variable-bindings uses indefinite lengthDEBUG2: cgiCopyTemplateLang(tmpl="
E [15/Jul/2019:23:38:20 +0500] [cups-deviced] PID 6525 (smb) stopped with status 1!
E [15/Jul/2019:23:39:38 +0500] [cups-deviced] PID 6678 (smb) stopped with status 1!
W [16/Jul/2019:05:32:11 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:05:33:52 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:05:34:38 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:05:49:37 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:05:50:15 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:05:52:49 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:08:11 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:10:26 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:12:00 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:13:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:19:25 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:21:33 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:25:36 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:32:39 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:45:48 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:50:42 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:52:46 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:53:45 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:54:50 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:06:56:29 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:03:05 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:06:02 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:07:03 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:09:53 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:37:54 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:07:40:26 +0500] [cups-deviced] PID 9488 (smb) stopped with status 1!
W [16/Jul/2019:07:44:44 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:07:58:41 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:00:19 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:02:47 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:04:01 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:09:25 +0500] [CGI] Bad SNMP packet from DEBUG2: <IP_ADDRESS>  Starting at file position 804...
E [16/Jul/2019:08:09:25 +0500] [cups-deviced] PID 12979 (smb) stopped with status 1!
W [16/Jul/2019:08:11:45 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:12:19 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:16:24 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:18:46 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:19:28 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:22:19 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:23:59 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:26:14 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:28:01 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:29:57 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:31:12 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:34:30 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:36:07 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:37:37 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:39:07 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:52:15 +0500] [cups-deviced] PID 22398 (smb) stopped with status 1!
W [16/Jul/2019:08:52:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:53:58 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING02.ppd: 404 - Not Found
E [16/Jul/2019:08:53:59 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:08:53:59 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:08:54:06 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING02.ppd: 404 - Not Found
E [16/Jul/2019:08:54:07 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:08:54:07 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:08:54:34 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:55:34 +0500] [CGI] Bad SNMP packet from <IP_ADDRESS>: variable-bindings uses indefinite lengthDEBUG2:
E [16/Jul/2019:08:55:34 +0500] [cups-deviced] PID 22973 (smb) stopped with status 1!
W [16/Jul/2019:08:55:36 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:57:25 +0500] [cups-deviced] PID 23274 (smb) stopped with status 1!
W [16/Jul/2019:08:57:28 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:08:58:24 +0500] [cups-deviced] PID 23303 (smb) stopped with status 1!
W [16/Jul/2019:08:58:34 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:08:59:38 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:00:42 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:03:23 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:03:23 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:09:03:33 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:03:33 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:09:03:45 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:04:14 +0500] [CGI] Bad SNMP packet from DEBUG2:   <IP_ADDRESS>Returning at file position : variable-bindings uses indefinite length
E [16/Jul/2019:09:04:14 +0500] [cups-deviced] PID 23925 (smb) stopped with status 1!
E [16/Jul/2019:09:04:21 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING02.ppd: 404 - Not Found
E [16/Jul/2019:09:04:21 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:04:21 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:09:04:40 +0500] [CGI] Bad SNMP packet from DEBUG2: <IP_ADDRESS>  : variable-bindings uses indefinite length
E [16/Jul/2019:09:04:40 +0500] [cups-deviced] PID 23952 (smb) stopped with status 1!
E [16/Jul/2019:09:04:53 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING11.ppd: 404 - Not Found
E [16/Jul/2019:09:04:53 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:04:53 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:09:06:12 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:07:33 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:12:48 +0500] [cups-deviced] PID 24329 (smb) stopped with status 1!
E [16/Jul/2019:09:13:56 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:13:56 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:09:14:06 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:14:06 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:09:14:10 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:14:45 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:16:21 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:17:41 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:18:35 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:19:11 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:21:10 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:21:54 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:22:26 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:23:01 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:23:39 +0500] Returning IPP client-error-not-authorized for Print-Job (ipp://<IP_ADDRESS>:631/printers/rec2) from <IP_ADDRESS>
W [16/Jul/2019:09:24:10 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:25:11 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:26:46 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:28:08 +0500] Returning IPP client-error-not-authorized for Print-Job (ipp://<IP_ADDRESS>:631/printers/rec2) from <IP_ADDRESS>
W [16/Jul/2019:09:28:40 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:31:29 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:32:20 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:32:56 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:35:39 +0500] Returning IPP client-error-not-authorized for Print-Job (ipp://uiortbidbp02:631/printers/rec2) from <IP_ADDRESS>
W [16/Jul/2019:09:36:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:38:42 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:39:37 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:41:08 +0500] [cups-deviced] PID 27694 (smb) stopped with status 1!
E [16/Jul/2019:09:41:27 +0500] [CGI] Unable to get PPD file /printers/REC1.ppd: 404 - Not Found
E [16/Jul/2019:09:41:27 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:41:27 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:09:41:38 +0500] [CGI] Unable to get PPD file /printers/REC1.ppd: 404 - Not Found
E [16/Jul/2019:09:41:38 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:41:38 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:09:42:40 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:43:13 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:44:26 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:45:10 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:47:51 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:49:21 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:50:01 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
E [16/Jul/2019:09:52:20 +0500] [cups-deviced] PID 28777 (smb) stopped with status 1!
E [16/Jul/2019:09:52:51 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING02.ppd: 404 - Not Found
E [16/Jul/2019:09:52:52 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:52:52 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
E [16/Jul/2019:09:53:01 +0500] [CGI] Unable to get PPD file /printers/PRTPICKING02.ppd: 404 - Not Found
E [16/Jul/2019:09:53:01 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/kyocera_ppd_8.2.txt"!
E [16/Jul/2019:09:53:01 +0500] [cups-driverd] Bad driver information file "/usr/share/cups/model/foomatic-db-ppds/Kyocera/ReadMe.htm"!
W [16/Jul/2019:09:55:32 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:56:48 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:57:23 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:58:21 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:09:59:59 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:06:51 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:07:22 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:13:08 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:16:45 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:18:51 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:21:15 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:22:41 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:23:40 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:24:23 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:26:29 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:27:26 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:28:37 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:31:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:32:02 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:32:34 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:34:54 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:35:52 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:37:19 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:39:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:40:44 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:42:30 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:44:09 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:45:28 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:47:37 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:49:58 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:51:16 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:51:52 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!
W [16/Jul/2019:10:53:23 +0500] Notifier for subscription 42 (rss:///.rss?max_events=20) went away, retrying!

@VeronicaMinango That sounds like the PPD files were deleted from the /etc/cups/ppd directory...

No response from reporter, closing...

Hi, I have a similar problem with a samsung c430w, and /etc/cups/pppd is empty. How do I get the files back?


.png icons not cropped

Hi, I seem to recall downloading PNG icons at 72px  would result in tightly cropped images. I see now the download results in a large frame with the 72px image off to a corner.

Same result for me, and I tried this on Firefox, Edge, and Chrome.

Even this view doesn't download the icons with the correct size:

24px: icons are 36x36
36px: icons are 54x54
48px: icons are 72x72
I still used this approach to get centered icons and resized them in paint.net or some other image manipulation app.
It feels like something is off with either the SVG code, or whatever libraries the website uses to generate icons based on user input sizes.


Start workflow request includes createdBy

Pull Request type

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[ ] Other (please describe):

Changes in this PR

Added createdBy to StartWorkflowRequest and WorkflowSummary (WorkflowModel already has this property).
When making a request to start a workflow createdBy can be set to an id or email of the user that started the Workflow.
If there's a security layer the request value could be ignored or overridden and set to the id or email of the user making the request.
createdBy is persisted.

E.g.:
curl -X "POST" "http://localhost:8080/api/workflow" \
     -H 'Content-Type: application/json; charset=utf-8' \
     -d $'{
  "correlationId": "8e4caba8-43d0-4e86-bc97-bab8a4a8e446",
  "name": "test",
  "createdBy"<EMAIL_ADDRESS>  "version": 1
}'

Hi @jmigueprieto We are currently working on an authorization layer for workflows and feel that the createdBy value can be populated at this layer. We will keep this PR on hold till we have finalized a design and get back to you on this.


Feature Request: the @inlet/react-pixi package should be taken down or the docs amended to note it's deprecated

Description
Searching for pixiJS and react lead me to  @inlet/react-pixi. It would be better for new users to be directed more forcefully towards this repo IMO. I lost an hour or two trying to figure out why it wouldn't work I'm assuming React18.. :-(
Maybe this npm page could be amended: https://www.npmjs.com/package/@inlet/react-pixi
And the docs page here: https://reactpixi.org, where the install instruction is npm install @inlet/react-pixi --save

Wow, I just had the exact same problem. Wasted an hour working with the wrong package.

Wasted 2 hours downgrading all of my dependencies for this..

Same.

Well I am glad that I found this issue ... after 30 minutes of trying I almost started to look for an alternative 😄

+1 - Was following https://reactpixi.org/ thinking it was the official docs

@inlet I believe you can help with this, since you own that older package.
I'd recommend deprecating the package by running npm deprecate @inlet/react-pixi "package moved to @pixi/react"
This will leave old versions accessible, but will show a warning when installing the package and on the npm page.

Good point guys! Sorry to hear it wasted your valuable time.
I’ll deprecate the package with a good deprecation message and bring down reactpixi.org asap

I've just deprecated the npm package @inlet/react-pixi and removed the reactpixi.org site as this is no longer needed.


README.md: add live examples

Hi @platisd since I use your Action in a real project hosted on the GitHub, I want to offer to share some real-world examples of workflows used to run your Action, so that end users understand that running clang-tidy manually is not so difficult, and also so that they have a real example before their eyes instead of abstract your-clang-tidy-script.sh (and so they can even cut-and-paste it to use in their own workflows).
Also I would like to highlight the feature that allows to analyze PRs from forks in a safe manner, because it really is a "killer feature" of this Action. Other Actions are usually combined "all-in-one" and they just can't do it. And this is a very important feature for a popular GitHub project with many external contributors.

Hi @platisd I have addressed your comments, please take a look at your convenience.

Overall, we should keep the documentation focused on how to use the Action rather than how to use clang-tidy.

On the one hand, this is true, but on the other... You see, when the end user looks at "he won't run clang-tidy for you" and abstract scripts like your-clang-tidy-script.sh in examples, he thinks: "OMG, it's all too complex, I have no idea how to run it all myself, I have no experience in writing bash, python and js scripts" (and he is right here - it's hard to make it all properly and securely), "so I'll just take it some all-in-one combined solution that will run clang-tidy for me" and then he will need to analyze 3rd-party pull requests and he runs the workflow under the pull_request_target permissions, and then... his repo gets pwned. Therefore, I think that it is better to provide working examples - maybe they look a bit complicated, but at least they work and they may be used as-is (with minimal changes) via cut-and-paste :)

@platisd

If the git diff -U0 HEAD^ | is there only for optimization, can you please remove it from the examples? 👼

You see, clang-tidy-diff expects diff as input, so I can't remove it :) I'll need to replace the clang-tidy-diff by something else "out of my head", and this will no longer be a working and tested example.

@platisd

If the git diff -U0 HEAD^ | is there only for optimization, can you please remove it from the examples? angel

You see, clang-tidy-diff expects diff as input, so I can't remove it :) I'll need to replace the clang-tidy-diff by something else "out of my head", and this will no longer be a working and tested example.

Ooh, OK then, so it's not there just for optimization. :grin:
Will squash and merge :+1:


Pre-Installation Steps Errors

Description
Certain CSI Knowledge Center Pre-Installation Tasks (https://www.ibm.com/docs/en/spectrum-scale-csi?topic=installation-performing-pre-tasks) are incomplete and inaccurate.

For the "Verify the file system configuration" task:

There are no instructions on how to set the Quota Value displayed in
mmlsfs gpfs0 --filesetdf -Q --perfileset-quota
Instructions should include command needed to set Quota Value prior to this task:
mmchfs gpfs0 -Q yes

For the "Enable quota for root user by issuing the following command" task:

The instructions include this command:
mmlsconfig enforceFilesetQuotaOnRoot=yes
The command should be:
mmchconfig enforceFilesetQuotaOnRoot=yes

For the "For Red Hat OpenShift, ensure that the controlSetxattrImmutableSELinux parameter is set to "yes" by issuing the following command" task:

The instructions include this command:
mmlsconfig controlSetxattrImmutableSELinux=yes
The command should be:
mmchconfig controlSetxattrImmutableSELinux=yes

Also, there is another KC error on the Secret instructions (https://www.ibm.com/docs/en/spectrum-scale-csi?topic=configurations-secrets#concept_pkl_ghh_53b).
For the "Create secret in the CSI namespace by issuing the following command" step:
The instructions include this command:
kubectl create secret generic [secret_name] --from-literal=username=[gui_username] --from-literal=password=[gui_password] -n ibm-spectrum-scale-csi-driverCopy
The command should be:
kubectl create secret generic [secret_name] --from-literal=username=[gui_username] --from-literal=password=[gui_password] -n ibm-spectrum-scale-csi-driver

@tristan-le is there anything pending on this one?

I am waiting for the KC changes to be committed.

The Pre-Installation Steps were fixed here: https://www.ibm.com/docs/en/spectrum-scale-csi?topic=installation-performing-pre-tasks
And the Secret instructions were fixed here: https://www.ibm.com/docs/en/spectrum-scale-csi?topic=configurations-secrets#concept_pkl_ghh_53b
Closing the issue.


Update location of Spark YARN shuffle jar

Looking at the distributions provided on spark.apache.org, I see that the Spark YARN shuffle jar is under yarn/ and not lib/.

cc @vanzin?

Test build #69628 has started for PR 16130 at commit 979a8a1.

Test build #69628 has finished for PR 16130 at commit 979a8a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69628/
Test PASSed.

Merged build finished. Test PASSed.

Merging to master / 2.1.

And 2.0 too, since it's relevant there.

Didn't merge to 2.0 (forgot I changed these docs in 2.1).


fix: package name not visible in output when run tests recursive

Description
When running all tests recursive the package title is not visible in the output.
very_good test --optimization --coverage -r
Folder structure:
packages/name123
packages/name456
packages/name789

Output:
✓ Optimizing tests (56ms)
00:16 +58: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages...
✓ Optimizing tests (61ms)
00:20 +377: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages...
✓ Optimizing tests (54ms)
00:14 +31: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages...
✓ Optimizing tests (57ms)

Expected Behavior
Title of each package is visible in the output:
✓ Optimizing tests (56ms)
00:16 +58: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages/name123...
✓ Optimizing tests (61ms)
00:20 +377: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages/name456...
✓ Optimizing tests (54ms)
00:14 +31: All tests passed!
Running "flutter test" in /Users/danielfelten/Projekte/test/packages/name789...
✓ Optimizing tests (57ms)

Hello @DFelten 👋,
I wanted to test if my changes to the fork for this issue are correct or not. How can I test it by replicating the project structure provided by you?

Hello @DFelten 👋, I wanted to test if my changes to the fork for this issue are correct or not. How can I test it by replicating the project structure provided by you?

Hi @superiorsd10, I'm glad you want to implement the feature. The folder structure is described above. You just need to create several packages and run the tests in the root directory.


Net namespace  no create

Description
I use kubelet to call cri service of  containerd. But network create failed.
The  containerd log info as fellow:
Dec 28 01:21:35 kwepddde00001 containerd: time="2020-12-28T01:21:35.513642411Z" level=info msg="RunPodSandbox with config &PodSandboxConfig{Metadata:&PodSandboxMetadata{Name:agnhost-pod-1,Uid:b13a6b64-2740-4156-bac5-4b9efd15398a,Namespace:default,Attempt:0,},Hostname:agnhost-pod-1,LogDirectory:/var/log/pods/default_agnhost-pod-1_b13a6b64-2740-4156-bac5-4b9efd15398a,DnsConfig:&DNSConfig{Servers:[],Searches:[default.svc.cluster.local svc.cluster.local cluster.local],Options:[ndots:5],},PortMappings:[],Labels:map[string]string{io.kubernetes.pod.name: agnhost-pod-1,io.kubernetes.pod.namespace: default,io.kubernetes.pod.uid: b13a6b64-2740-4156-bac5-4b9efd15398a,},Annotations:map[string]string{kubectl.kubernetes.io/last-applied-configuration: {"apiVersion":"v1","kind":"Pod","metadata":{"annotations":{},"name":"agnhost-pod-1","namespace":"default"},"spec":{"containers":[{"image":"agnhost:2.21","name":"agnhost-pod-1","resources":{"limits":{"memory":"200Mi"},"requests":{"memory":"100Mi"}}}]}}
Dec 28 01:21:35 kwepddde00001 containerd: ,kubernetes.io/config.seen: 2020-12-24T09:01:13.459489789Z,kubernetes.io/config.source: api,kubernetes.io/limit-ranger: LimitRanger plugin set: cpu request for container agnhost-pod-1,},Linux:&LinuxPodSandboxConfig{CgroupParent:/kubepods/burstable/podb13a6b64-2740-4156-bac5-4b9efd15398a,SecurityContext:&LinuxSandboxSecurityContext{NamespaceOptions:&NamespaceOption{Network:POD,Pid:CONTAINER,Ipc:POD,},SelinuxOptions:nil,RunAsUser:nil,ReadonlyRootfs:false,SupplementalGroups:[],Privileged:false,SeccompProfilePath:runtime/default,RunAsGroup:nil,},Sysctls:map[string]string{},},}"
Dec 28 01:21:35 kwepddde00001 containerd: time="2020-12-28T01:21:35.513684430Z" level=debug msg="Generated id "100bb5cc03f57a568a3ea3170d4c451fedffc004eda4be68969b3088bcc10f8f" for sandbox "agnhost-pod-1_default_b13a6b64-2740-4156-bac5-4b9efd15398a_0""
Dec 28 01:21:35 kwepddde00001 kernel: [829168.112259] IPVS: Creating netns size=2056 id=31768
Dec 28 01:21:35 kwepddde00001 systemd: run-netns-cni\x2d0e70fc72\x2dbe5b\x2d5c1a\x2d19a8\x2d853832532994.mount changed dead -> mounted
Dec 28 01:21:35 kwepddde00001 systemd: run-netns-cni\x2d0e70fc72\x2dbe5b\x2d5c1a\x2d19a8\x2d853832532994.mount changed mounted -> dead
Dec 28 01:21:35 kwepddde00001 containerd: time="2020-12-28T01:21:35.549800468Z" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:agnhost-pod-1,Uid:b13a6b64-2740-4156-bac5-4b9efd15398a,Namespace:default,Attempt:0,} failed, error" error="failed to setup network for sandbox "100bb5cc03f57a568a3ea3170d4c451fedffc004eda4be68969b3088bcc10f8f": Failed to add network use CNI, err: Net namespace is not exist, netns is /var/run/netns/cni-0e70fc72-be5b-5c1a-19a8-853832532994"

kwepddde00001:/home# ll /var/run/netns/
total 0

cotainerd verision:
containerd github.com/containerd/containerd 1.2.2<PHONE_NUMBER>f7fe2f4e74d43e2fc7ccd237edcbce

OS verison: CentOS 7
What's wrong ?
Is it refer to ones:
Dec 28 01:21:35 kwepddde00001 systemd: run-netns-cni\x2d0e70fc72\x2dbe5b\x2d5c1a\x2d19a8\x2d853832532994.mount changed dead -> mounted
Dec 28 01:21:35 kwepddde00001 systemd: run-netns-cni\x2d0e70fc72\x2dbe5b\x2d5c1a\x2d19a8\x2d853832532994.mount changed mounted -> dead

Can anyone give me some guide? possible problem

While containerd 1.2.x is unsupported and no longer serviced, your specific version (v1.2.2) is also extremely out of date--the final release of the 1.2.x service line was v1.2.13.
I'm not suggesting that is the only issue, but it would be important to attempt this on a supported containerd (either 1.3.x or 1.4.x) and see if you are still hitting an issue. My guess is that there is a CNI plugin configuration/setup issue that is causing an issue with your netns for the container. Once you attempt this with a supported containerd, it would be good to know the CNI provider and the Kubernetes version as well.

@estesp  thanks
/close


PCRGibsonOverhaul

This overhauls several aspects of how the PCR and Gibson reactions work in Coral, which fixes several quirks/bugs found in gibson assembly reaction and pcr reaction. A summary of the features/fixes is listed below:
(1) PCR reactions use a separate reaction called ‘_anneal.py’ to determine primer binding locations. ‘_anneal.py’ finds the largest annealing from the 3’ to the 5’. Annealing and overhang sequences are implicitly discovered. This method leaves open the possibility for modifying the method for mismatch primers and annealing.
(2) PCR detects if there are possible ambiguous annealing at the 3’ of the primer not explicitly stated in the primer definition. Raises error if ambiguous annealing is detected.
(3) Fixes a quirk in which if reverse and forward primers were added to the arguments in the incorrect order, the overhang would be attached to the resulting fragment incorrectly.
(4) Gibson Assembly now automatically annotates features from the corresponding fragments features.
(5) Fixed small quirk in setup.py that made threw error when installing to MacOS. This needs to be reviewed…
(6) Fixed a 'feature qualifier bug' in which 'qualifiers' and 'gaps' were initialized incorrectly.
(7) Several new test methods added to test _pcr.py and _anneal.py

Thanks, Justin! This is awesome!
I spruced up the code a bit, but the core is intact. I'll merge once the CI tests pass.


Add  as single model

That is, the model will automatically infer how many components are required and return data for that.
The use will not have to specify how many components are used.

Previous merge only looped over model number, no trial-switch number


letsencrypt can't access the test file - nginx conf problem?

latest ee version, Debian 8 (on Linode)
Worked well few months ago, on another Linode VPS installation
Can't enable letsencrypt. Even tried clean install
letsencrypt logs show that xxx/.well-known/acme-challenge/testfile can't be accessed, which is true
New VPS installation + EE installed perfectly + new site created via EE. Nothing special. WP site is accessible and running

Thanks!

Same for me. When I run this the SSL Certificate generation fails:
ee site create mydomain.com --wpfc  --letsencrypt --user=me<EMAIL_ADDRESS>--php7
When I run /opt/letsencrypt/letsencrypt-auto certonly --webroot -w /var/www/mydomain.com/htdocs/ -d mydomain.com -d www.mydomain.com --email<EMAIL_ADDRESS>--text --agree-tos
You get the following error:
   Domain: mydomain.com
   Type:   unauthorized
   Detail: Invalid response from
   http://mydomain.com/.well-known/acme-challenge/P70j2Bf1LwNB-xHOjKG9vjkAQ1PhiLChVglt0EV8wnw:
   "
   <title>404 Not Found</title>

404 Not Found

"

My real domain is of course replaced by mydomain.com.

They confirmed (quickly replying, btw), that it is a known issue and will be addressed in the coming update
For the meanwhile
http://community.rtcamp.com/t/workaround-for-letsencrypt-error-unable-to-setup-lets-encrypt/8864

Thank you @eddr! That worked great! 😁

Glad to hear. You might need to renew the certs yourself though (or make a cron job)

This looks like a fixed one. :)
We are cleaning up issue tracker and closing this issue because we won't be able to contribute to this discussion further.
Please use http://community.rtcamp.com/c/easyengine for future support questions.


No objects (PPU Player 1.3)

There are no sprites in the signal rendering.
Need to find out where they went and how to get them back.

Output OAM/TempOAM. Only the 1st byte is propagated:


License in README.md is inconsistent with LICENSE file

The License section in README.md says:

This project is licensed under the GPL-3.0 License - see the LICENSE file for details.

While the LICENSE file is copy of the MIT license, which seems to be the intended license as it is newer in the commit history.
Please update the readme or license file to be consistent, because some organizations have restrictions against using GPL software.

Solved with https://github.com/keymetrics/docker-pm2/commit/eaf622c47245a3d3700df05de777e9f4f2cf7446
Thank you for taking the time to open this issue. 🎉


Update CI checks

This PR adds credo as a dependency and to our CI tests. I've used the credo file that I typically add to projects. Its less strict than a typical setup, but it enforces the stuff that I think typically make the most sense. I'm happy to discuss changes if y'all have a strong preference about any of this stuff.

Great! I'm favor of this

hmm...I'm not sure why that's failing on elixir 1.7.4. I'm guessing some sort of AST change or something? That with expression has 2 lines in it so it's not actually wrong.

Hm why did credo pass on elixir 1.10, but not on 1.7 🤔

Hm well I think the warning says it should have more than one <- clause, so it doesn't count the multiple else clauses. I wouldn't mind changing it to a three clause case

I think its a bug. Or I'm misinterpreting the error. But that with clause has two expressions in it before the else.

Oh I was looking at master where it does only have one clause: https://github.com/keathley/finch/blob/master/lib/finch/pool.ex#L29
But here is this branch: https://sentry.io/organizations/appmonet/issues/1582780741/?project=1889179&query=is%3Aunresolved

Looks like on "pull_request" it runs against the merged pr:
commit 6a67d3448636b5a7862d3d6b43479e06e4b38a24
Author: Chris Keathley<EMAIL_ADDRESS>Date:   Wed Apr 8 13:35:57 2020 +0000

    Merge 2e7be0c8c234640ade6f8cdb06294e728012f9a4 into 6bde388f8ca19e62420da5b7b6ac7e50749a6cfd

and on "push" it just checks out the current branch
commit 2e7be0c8c234640ade6f8cdb06294e728012f9a4
Author: Chris Keathley<EMAIL_ADDRESS>Date:   Wed Apr 8 09:35:30 2020 -0400

    Implement credo suggestions

Ah duh. I didn't realize I hadn't rebased on master. Should be fixed up now.


Does this also come as a python package?

I'm interested in using this to pre-process data as part of a Python pipeline. Is this currently possible?

Guess I gotta do the good things myself

I think you will find your answer here


Documentation improvements, handle non-lowercase file extensions, and add public method to scan from within Java

This PR adds two commits, one to improve Main.java and one to improve Detector.java.
The commit for Main.java adds the following:

Javadocs and comments throughout
Improved console output by compiling a list of infected files to show at the end
Added support for running a scan from within Java (i.e. launcher automatically check downloaded mod files, etc.)
Converted file name to lowercase when checking file extension to ensure capitalization does not affect scanning (i.e. JAR, JaR, JAr, jaR, etc.)

The commit for Detector.java adds the following:

Javadocs and comments for the class itself and the scan method.
Improved the scan method so it returns a boolean indicating if infection was found or not.
Converted file name to lowercase when checking for .class file extension to ensure capitalization does not affect scanning (i.e. CLASS, claSS, CLasS, etc.)

Will fix conflicts and update

@MCRcortex @IMS212 @Huskydog9988 This pull request is ready for review now. My apologies for tagging you if not the correct person, but I just wanted to make sure this was back on the radar now that earlier conflicts are resolved.

we are currently working on some issues with detection rn, but you have the clear from me

we are currently working on some issues with detection rn, but you have the clear from me

Sounds good. Hopefully everyone approves/like these changes., and let me know if you need anything with regards to changes.

Eating dinner then will fix conflicts

Hey are you fine reimplementing the color codes from #23? Currently we may need to drop them temporally because the gui can't render the ansi colors.

Hey are you fine reimplementing the color codes from #23? Currently we may need to drop them temporally because the gui can't render the ansi colors.

Sorry I did not see this sooner. I have that handled already in this PR. I do a replaceAll on the ANSI color codes which I moved in to a constants file

Oh, I did not see that more PRs were merged. More conflicts....again....

Ok, I have addressed all conflicts

Fixes #27

Corrected a mistake (sorry) where I omitted output of compiled scan results on the GUI.

our discord is now public, you can coordinate with us here if you want  https://discord.gg/zPdFK47682 (we are currently working on a rewite)

I will try joining in the morning.
I am fairly discouraged. 😞 At this point, I have had to handle merge conflicts 4+ times, some rather large.
Hopefully there is a review soon, so these changes can be rebased into the rewrite branch and not lost again. There is a great deal of improvement here that shouldn't be missed including:

Better Javadocs
Documentation fixes
Main class improvements to allow launchers, etc. to start a scan and receive a list of results (infected files)
ANSI color code handling
Auto-scroll for log in GUI (there is a checkbox to turn it off too)
Cancel button in GUI
more...

yea hopefully we can get one in, ill try and remind the maintainers tomorrow

sorr looking at it now