FIX: skip render the subcharts for sealer build.

Signed-off-by: tgfree<EMAIL_ADDRESS>
Describe what this PR does / why we need it
Skip render the subcharts.
Does this pull request fix one issue?
Try to fix #1689

@tgfree7 @kakaZhou719 The render for subcharts should be skipped? I think I need more information.

@tgfree7 @kakaZhou719 The render for subcharts should be skipped? I think I need more information.

Render subcharts may list unwanted images, like this:
values.yaml for chart apps-all-in-one
app1:
    Registry: release.com
    image: app1:v1_2022

and values.yaml for subcharts app1 in the apps-all-in-one
app1:
    Registry: test.com
    image: app1:v1_2022

In the case, render the subchart app1 will list the unwanted images. test.com:app1:v1_2022
And render subcharts may cause the tpl error, if app1 call the tpl of _helper.tpl in the apps-all-in-one

@tgfree7 If i'm not mistaken, subcharts has their own values? And of course the parent values could be passed to the subcharts. But what will happen if the user need the "test/com/app1:v1_2022"

Yes, subcharts has their own values.yaml.
But when we release the chart apps-all-in-one and set the subchart app1(s Registry, images,etc.) by the parent chart values.yaml. this means we just need the image release.com/app1:v1_2022 in this helm chart.
For the chart apps-all-in-one, we release the apps(app1,app2,etc) in one chart.

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting.
The subcharts_and_globals shows the details.

Codecov Report
Base: 18.06% // Head: 18.06% // No change to project coverage :thumbsup:

Coverage data is based on head (cc68afa) compared to base (47f8ada).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1690   +/-   ##
=======================================
  Coverage   18.06%   18.06%
=======================================
  Files          66       66
  Lines        5354     5354
=======================================
  Hits          967      967
  Misses       4265     4265
  Partials      122      122

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting. The subcharts_and_globals shows the details.

Yes, helm will render, but the render logic in sealer will do the same thing? Could you help confirm this? Write a test for this part will be perfect.

Okay, I understand what you mean. But in this case, we need to know that the (registry. images) for app1 has been specified in parent values.yaml, Right? What if user assign the app1 (registry. images) in subcharts only? I think it will igonre the image.

If user assign the app1 (registry. images) in subcharts only, helm render will use the subcharts' setting. The subcharts_and_globals shows the details.

Yes, helm will render, but the render logic in sealer will do the same thing? Could you help confirm this? Write a test for this part will be perfect.

Yes, i confirm that RenderHelmChart will render in the same way,and i will write a test for the RenderHelmChart.

@tgfree7 Thanks for your work. I think you can create test samples(subchart included and excluded). And call the function of sealer, check the expected content.

@tgfree7 Thanks for your work. I think you can create test samples(subchart included and excluded). And call the function of sealer, check the expected content.

In the test case, where the chart should i store? in the sealer's path test ? I reivew the old test case, the chart ./test/alpine are not found.

@tgfree7 You can create a testfile dir under the build or buildimage.

@tgfree7 You can create a testfile dir under the build or buildimage.

test case added.

There is license problem.
make install-addlicense && make filelicense
Could you plz try this command?
And Probably the install-addlicense will fail, in that case, you can try install it yourself, and do make filelicense.

make install-addlicense

There is license problem. make install-addlicense && make filelicense Could you plz try this command? And Probably the install-addlicense will fail, in that case, you can try install it yourself, and do make filelicense.

ok, license added.

There is license problem. make install-addlicense && make filelicense Could you plz try this command? And Probably the install-addlicense will fail, in that case, you can try install it yourself, and do make filelicense.

ok, license added.

LGTM
@kakaZhou719 Help check this work.


Merge attach process picker to master

This merges commit c2b5c1ba6c9a57b931a0359ef77f1169063b72a1 from dev into master. Original description:

Adding attach process picker.

This feature will light up when the required vscode features are available in stable release.

Incorporating code review comments.

Changing the command to csharp.listProcess.
Sorting the process, such that dotnet process are shown at the top.

:+1:


⚠ Cioos Pacific CKAN Sitemap has degraded performance

In 59c95ec, Cioos Pacific CKAN Sitemap (https://catalogue.cioospacific.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 11830 ms

Resolved: Cioos Pacific CKAN Sitemap performance has improved in 3252a9f after 40 minutes.


Not an issue but a request :)

Hello, I want to say that I feel like Snowrunner is almost unplayable without this mod, so THANK YOU for your hard work.
My request, is there any chance you could make a similar mod for Spintires and Mudrunner? :)
Thanks again.

Why would you need this mod for ST and MR ? Like the Manual Gear thing was like the second best thing in the game

You can only do manual gears with a shifter though, can't do it via keyboard like this mod does with Snowrunner.

Mudrunner - maybe, Spintires - less so. I think Spintires is very different in terms of code in how it operates vehicles.
But I should probably finish wheel support before I look into different games.


Missing CHANGES entry describing the legacy provider

I can't seem to find a CHANGES entry which describes the introduction of the legacy provider, and the fact that certain algorithms that were previously available by default are no longer available.

Fix in #14465

IMO this should be even in NEWS.md

IMO this should be even in NEWS.md

Done in #14465


Unable to trade BUSD on BNB to ETH on ETH

Overview
Getting something went wrong when trying to trade BUSD on bnb to ETH on eth
References and additional details
https://github.com/shapeshift/web/assets/100157997/1bb385f2-62e3-4ab0-bb6b-7cddfa09d774

Acceptance Criteria
Should be able to trade BUSD on bnb to ETH on eth
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

https://discord.com/channels/554694662431178782/1229321437626630154/1229558738038427708
more context here, but it appears the issue is caused by degraded nownodes performance. i have switched back over to our own infra for the remaining supported chains (eth, bsc, btc, ltc) for the time being until issues are resolved upstream.

Closed thanks to big Kev 🚀

I have a user who is still experiencing an issue trying to trade busd to eth.... any ideas on why the issue would be persisting?.

reopening as user still experiencing issue.
user found this article which believes it may be the reason why : https://forum.openzeppelin.com/t/can-not-call-the-function-approve-of-the-usdt-contract/2130

@MBMaria I was able to swap just fine from BUSD to ETH:
https://github.com/shapeshift/web/assets/17035424/51afd9e2-7a9d-466a-80f6-ac5893e9e0ca
Is this something you're able to repro? For such hard to repro issues, most likely related to current issues with nodes or upstream services (Li.Fi) it would be helpful to have the failing network requests (in this case, most likely bnbsmartchain's send or estimate request or li.quest requests) for engineering to debug.
Obviously not something we'd ideally want to ask users to do and better for ops to repro instead - especially here as they're a mobile app user and can't inspect network requests.

@MBMaria bump

@gomesalexandre i am still able to reproduce - i am on native but i can see you are on metamask ..?
https://jam.dev/c/c030162a-5cba-4a19-b9be-6787cdc83e6f

This is a legit issue and can repro locally, hitting http 520 on bnbsmartchain /send endpoint:
curl -H 'Content-Type: application/json' \
      -d '{"hex": "[encoded data, 7980 characters]"}' \
      -X POST \
      https://dev-api.bnbsmartchain.shapeshift.com/api/v1/send

@kaladinlight assigning to you, would it be possible to debug on node side using the example above?

@woodenfurniture Finally got around to looking at this and first attempt to send actually succeeded, though the tx failed on chain (most likely due to non existent route or expiries). https://bscscan.com/tx/0xbb98a1fd3b8ee07352dfb61a6097fc83ba572d59025afdffe8ff721c7f855730
I noticed when looking at the unchained api yesterday that we are proxying send calls through to blockbook. I am going to take a look at updating this and removing any sort of retries that would result in client timeout to see if we can improve the error handling of sends as a first step.

https://github.com/shapeshift/unchained/pull/1007 update to /send endpoint so we can get more useful error info as returned directly from the node for debugging.

closing ticket for the moment as we should get more useable information from endpoints at this point and help in future debugging


Generated manifest has some missing items

Lighthouse failed on the following

Manifest contains name    The name property identifies your app and is required. Learn more.
Manifest contains background_color    When your app launches from a user's homescreen, the browser uses background_color to paint the background of the browser while your app loads for a smooth transition experience. Learn more.
Manifest contains theme_color
Manifest contains icons at least 192px

I think this webpack plugin is not related to web-app manifests. It's purpose is to generate an asset manifest which maps hashed filenames to original file-names.


Missing configuration data

Hi,
I'm trying tot connect a basic Sonoff Switch to Homekit using Homebridge.
I installed the plugin but after rebooting Homebridge I got the following info:
[eWeLink] Initializing eWeLink platform...
[eWeLink] Initialization skipped. Missing configuration data
The Switch is not showing up in my accessoire.
Please give my some advice how to handle this problem.

I used this plugin https://github.com/bwp91/homebridge-ewelink#readme and it works smouthly


how open the history api about nodeos v2.0.4

how open the history api about nodeos v2.0.4

I'm sorry it is not clear what this means.

/v1/history/get_key_accounts
Which api replaces the above interface。
What nodes need to do。
nodeos v 2.0.4

There is no provided replacement for that api currently.


FilamentCanvas error

When using FilamentCanvas we got the following error:
in virtual void filament::PlatformWGL::makeCurrent(Platform::SwapChain *, Platform::SwapChain *):184
reason: wglMakeCurrent() failed. hdc = FFFFFFFFA7011C12

Using FilamentPanel works fine.

OS: Windows
GPU: NVIDIA GeForce GT 750M
Backend: OpenGL
Java: 1.8.0_151; Java HotSpot(TM) 64-Bit Server VM 25.151-b12
Filament: filament-sceneform-1.9pr1

Is there any additional error message? And is this reproducible 100% of the time?

It happens every time, i.e. it is not possible to use FilamentCanvas, while wit FilamentPanel the exact same source code works. The window remains blank and no other errors are shown.
The attached simple example can be used to reproduce the bug (it is a NetBeans 8.2 project but the application structure is simple enough that I hope it can be opened in any IDE).
Commenting/uncommenting lines 82/83 can switch the use of FilamentCanvas/FilamentPanel.
FilamentJavaExample.zip

Can you try with an older release of Filament, say Sceneform 1.7pr6 and see if it still errors? Curious if this is a recent regression.

I've done some tests with pre-built binaries, and the error happens with every version I've tested:

Sceneform-1.9pr1
Sceneform 1.7pr6
Sceneform 1.6pr3

The pre-built binaries don't show any error message, they just crash.
The library used in my initial report was Sceneform-1.9pr1 built with ninja 1.9.0 and LLVM/clang 7.0.1.

Thank you. I've been able to reproduce on my side and will continue looking into it.

@gdm-tts This should be fixed now in latest master.

@bejado Yes, it now works for me. Thanks!


Issue starting

As soon as I click the start screencast or whatever it just opens up on the side but nothing is showing.

-bump-


Will the dataset be open source？

Great Work! The reconstruction pipeline is really good，but this period costs too much time. So, may I ask if the dataset will be open source?

Hi! Thanks for your interest - can you please reach out at<EMAIL_ADDRESS>Thanks!


Android 14 Beta 4 New Easter Egg!

So add new easter egg from Android 14 Beta 4.

v1.9.5 has been released, but the decompiled version does not yet support all features.

decompiled easteregg14.apk from tg linuxct: https://drive.google.com/file/d/1arLBcDYkcSFN0j0FVHqkq4SQV-TYV42a/view?usp=sharing

I've tried decompiling 14 Easter Egg for the Android 14 Beta 4 release, but there's no way to make it compatible until AOSP releases the source code.
------------------ 原始邮件 ------------------
发件人:                                                                                "hushenghao/AndroidEasterEggs"                                                                                @.>;
发送时间: 2023年7月15日(星期六) 上午10:14
@.>;
@.>;"State @.>;
主题: Re: [hushenghao/AndroidEasterEggs] Android 14 Beta 4 New Easter Egg!  (Issue #25)
decompiled easteregg14.apk from tg linuxct: https://drive.google.com/file/d/1arLBcDYkcSFN0j0FVHqkq4SQV-TYV42a/view?usp=sharing
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>


Newer version and less round-trip code

It would be helpful if the patches could be cleaned of whitespace and reformatting changes.


Update docker-hub/publish/index.md

Proposed changes
Update Docker Store to Hub.

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 4471d31e3937486fbb0099200b410a0b88aa0e2a
https://deploy-preview-9184--docsdocker.netlify.com

@ry4nz - Thanks for your contribution.


support oci: url, pass through host

Two changes:

support oci:// in addition to docker:// (nothing against docker the company, but this is broader)
support non-docker hub registries

The latter is the most important. You can do any of the below, and they will work:

docker://library/nginx:latest
docker://library/nginx
docker://library/nginx:v1.14
docker://nginx:latest
docker://library/nginx
docker://nginx:v1.14
docker://docker.io/library/nginx:latest
docker://docker.io/library/nginx
docker://docker.io/library/nginx:v1.14
docker://quay.io/coreos/etcd:latest
docker://quay.io/coreos/etcd

etc

Fixes #210

Hi, @deitch. Thank you for your modifications!
I sent your PR to our Jenkins, unfortunately the check failed.
Can you please modify lines https://github.com/lf-edge/eden/blob/master/tests/docker/testdata/2dockers_test.txt#L18-L19
from nginx:latest to library/nginx:latest

Yes, I will fix it

Updated and pushed. Please rerun

It works, thank you!

Approved by @giggsoff


[BUG]: Authentication healthcheck is not stopped on disabling authentication

What is the bug related to?
Registry Core
What went wrong?
On disabling authentication

[ ] it still checks for Keycloak service health
[ ] Workflow should also work without authentication enable

What did you expect to see?
A bug should not have happened, instead ...
Additional Context
No response
Relevant logs/output (if any)
No response

@holashchand can you update this?


Exception when persisting class unlisted in disciminator map (Issue 867)

Q
A

Type
feature/improvement

BC Break
yes

Fixed issues
https://github.com/doctrine/mongodb-odm/issues/867

Summary
Updated persisting logic to throw exception of class is not listed in discriminator map.
There is no new tests is added since library have a set of old tests that is cover most of the cases.
Right now exception message contain information only about unlisted class without parent class since in the places of the checks I don't find a way of extracting parent class info.

This logic forbid use of empty discriminator map. Now all embedded and referenced documents must have target document or discriminator map.

This answers one of my comments :) I don't think we should go that far, not specifying discriminatorMap is IMO very useful and the only strictness we should introduce is, as per #867, throwing an exception if user has opted in for using a map AND document being persisted is not listed there.

This logic forbid use of empty discriminator map. Now all embedded and referenced documents must have target document or discriminator map.

This answers one of my comments :) I don't think we should go that far, not specifying discriminatorMap is IMO very useful and the only strictness we should introduce is, as per #867, throwing an exception if user has opted in for using a map AND document being persisted is not listed there.

@malarzm , I really gone to far with strictness). I will decrease checks for making discriminatorMap optional. Can you, please, check my answers to your comments?

@malarzm , it was not so hard revert partially changes and introduce only exception in this PR). Also I updated PR description. Can you, please, check all again?

@alcaeus , @malarzm , is there will be any other remarks about PR? All previous remarks is already implemented.

Updated docs according to suggestions


Issues in the backend

Issue Report
Products not displayed when 'Shop now' button is clicked
Description
The backend code has some issue and is not able to display the products when 'Shop Now' button is clicked and the page is redirected to the /products route
Screenshots (if applicable)

Examples
Example 1
Title: Product Search Feature Returns No Results
Description: The product search functionality fails to display any results even for valid search queries.

Steps to Reproduce:

Navigate to the product search bar on the homepage.
Type "Wireless Mouse" into the search field.
Press the Enter key.

Expected Behavior: The system should display a list of products matching "Wireless Mouse."

Actual Behavior: The message "No results found" appears, regardless of valid input.

Example 2
Title: Login Issue with Valid Credentials
Description: Users are experiencing issues logging in, despite entering the correct username and password.

Steps to Reproduce:

Access the login page.
Input a valid username and password.
Click the "Login" button.

Expected Behavior: The user should successfully log in and be redirected to their dashboard.

Actual Behavior: An error message states, "Invalid credentials," preventing access.

Thank you for taking the time to report this issue! We appreciate your help in improving our project.

i will work on this


Improve how model.cond works

Description of feature
The implementation for finding the baseline level for each variable is currently hacky. Need to reach out to the formulatic devs for input.

Hi Gregor,
I was looking into getting the default values again and was wondering if the following works or if there was a reason why we dismissed it?
import formulaic
import pandas as pd
import numpy as np

data = pd.DataFrame({"celltype": ['A', 'A', 'B', 'C', 'C', 'C'],
        "condition": ['a', 'b', 'a', 'b', 'a', 'b'],
        "cont": [1, 2, 3, 4, 5, 6]})
formulaic.model_matrix('~ condition', data).model_spec.encoder_state['condition'][1]['categories']
data["condition"] = pd.Categorical(data["condition"], categories = ["b", "a"], dtype = "category")
formulaic.model_matrix('~ condition', data).model_spec.encoder_state['condition'][1]['categories']

The reason was that if you use the syntax described here, it breaks:
>>> formulaic.model_matrix('~ C(condition, contr.treatment(base="b"))', data).model_spec.encoder_state['C(condition, contr.treatment(base="b"))'][1]['categories']
['a', 'b']

Of course, also something we could decide not to support initially, but it would be nice to have a robust way to achieve this.

Ah yes. But I think it is fine to nonetheless use 'a' as a reference level. I think the reference level should be based on whatever the data contains and not which additional modifications the formula applies.
I think a helpful analogy is to consider a continuous covariate and formulaic.model_matrix('~ I(cont + 10)', data). The formula shifts all values up by 10, but that doesn't mean that we would move the continuous intercept to -10.  Applying the same logic to the categorical covariates means that I think it's fine to just look at the categories.

But it does change the design matrix accordingly?

Also adding here that I think this function should print out the actual contrast vector used (maybe omit zeros).
It's already a dataframe, so something like
contrasts.T.loc[lambda x: x[0] != 0]

could work nicely.

Closed by #36
Follow up in https://github.com/theislab/pertpy/issues/612


bug: Tapping the navbar to scroll to top is broken in 1.2.1

Type: bug
Platform: mobile webview
Hi there,
Great work by all at Drifty on Ionic -- I love it. After updating to 1.2.1 from 1.1, tapping the nav bar to scroll to top does not work anymore. Here's the requisite codepen demonstrating the bug. Scroll down a bit, tap the nav bar and on 1.1, it scrolls to top, but on 1.2.1 it doesn't.
Working on getting a new update to my app out and noticed this. Thanks again and happy holidays.
Luke

Greetings @lukemiles!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

@Ionitron :heart:

same problem here +1

The directive was commented out
https://github.com/driftyco/ionic/commit/cfa8042
Putting that line in fixes issue.
It looks like the intent was to allow native scrolling to kick-in, but still need to hookup the header 'tap' to scroll to top.

Hey, we removed that because it's non-standard and if you use the cordova-plugin-statusbar you'll get that for free, and it will actually work with the statusbar.
I'm open to adding it back, but I'm not sure we should be doing it. I need to be convinced :stuck_out_tongue:

Don't disagree, anyone can implement by providing on-tap themselves.
Would suggest updating the main doc page ion-header-bar and ion-nav-bar since the documented default is for this to happen. Guessing no-tap-scroll should just be removed?
My reasons for keeping are not strong enough

expected behavior in ionic apps (though not standard)
browser platforms do not have mobile equivalent

My resolution for browser platform: add a directive for class 'header-item'
angular
  .module('app')
  .directive('headerItem', ['$ionicScrollDelegate', function($ionicScrollDelegate) {
    var directive = {
      restrict: 'C',
      link: function(scope, element, attr) {
        element.bind('click', function() {
          $ionicScrollDelegate.scrollTop(true);
        });
      }
    };

    return directive;
  }]);


Example failing on newer firefox

"Connection failed. WebTransportError: WebTransport connection rejected"
Works in Firefox 132.0.2 (64-bit).  Tested with a fresh clean profile.
Fails in Firefox Developer Edition 133.0b8 (64-bit).  Tested with a fresh clean profile.
I see a related earlier issue that was resolved: #166

Thank you for the report.
I was indeed able to reproduce with Firefox Developer Edition 133.0b8 (64-bit).
From a first glance, it does not seems to be related to #166.
From what I see, inspecting the packets, the HTTP3 layer does not even start. Firefox closes the connection right after the QUIC/TLS handshake (maybe certificate validation fails, but wihtout TLS alert?)
I am going to investigate more on this, but it does not seem to be related to webtransport protocol

@mikedilger have you tried by using proper certificates? That is, a webtransport server that uses a certificated signed by a CA trusted by the system root store

I confirm that on Firefox version 133.0.3 it does not work indeed.
I'm using certificates generated by mkcert, and that the CA store of Firefox recognizes the mkcert authority.
In the Rust debug log I can see:
2024-12-14T07:27:24.401607Z DEBUG wtransport::endpoint: New incoming QUIC connection
2024-12-14T07:27:24.401637Z DEBUG wtransport_native: Connection accepted (<IP_ADDRESS>:4433)
2024-12-14T07:27:24.401761Z  INFO Connection{id=0}: wtransport_native: Waiting for session request...
2024-12-14T07:27:24.402560Z DEBUG Connection{id=0}: quinn_proto::connection: failed to authenticate packet
2024-12-14T07:27:24.403578Z DEBUG Connection{id=0}:drive{id=0}: quinn_proto::connection: ECN not acknowledged by peer
2024-12-14T07:27:24.418908Z ERROR Connection{id=0}: wtransport_native: ConnectionClosed(ConnectionClose(ConnectionClose { error_code: APPLICATION_ERROR, frame_type: None, reason: b"" }))

if that could help.

And I confirm that firefox-esr 128 works correctly

Firefox closes the connection but sometimes it returns a crypto error instead of application error
CONNECTION_CLOSE (Transport) Error code: CRYPTO_ERROR (Unsupported Certificate)
    Frame Type: CONNECTION_CLOSE (Transport) (0x000000000000001c)
    Error code: CRYPTO_ERROR (299)
    TLS Alert Description: Unsupported Certificate (43)
    Frame Type: 0
    Reason phrase Length: 0
    Reason phrase:

Amazing work on this project - It's been tremendously valuable to me. I've reproduced the issue on Firefox with a fresh copy of the repository using cargo run --example full. Unfortunately it's also an issue in my own project which uses wtransport (and certgen for local TLS certificates). I believe it started occurring in firefox after an update. Here are some additional details if it's helpful.

Tested on commit 26872fd14552ffebecd0b18ce7f9b3f49894a788
Firefox version: 133.0 (64-bit)
Operation System: Arch linux

Steps to reproduce

Clone new repository
cargo run --example full

Results (with RUST_LOG=trace):
2024-12-15T20:14:29.276902Z  INFO full::webtransport: Server running on port 49653
2024-12-15T20:14:29.276911Z  INFO full::http: Server running on port 8080
2024-12-15T20:14:33.596086Z DEBUG wtransport::endpoint: New incoming QUIC connection
2024-12-15T20:14:33.596221Z  INFO Connection{id=0}: full::webtransport: Waiting for session request...
2024-12-15T20:14:33.596306Z DEBUG wtransport::endpoint: New incoming QUIC connection
2024-12-15T20:14:33.596371Z  INFO Connection{id=1}: full::webtransport: Waiting for session request...
2024-12-15T20:14:33.596644Z TRACE Connection{id=0}:first recv:frame{ty=CRYPTO}: quinn_proto::connection: consumed 615 CRYPTO bytes
2024-12-15T20:14:33.597266Z TRACE Connection{id=0}:first recv: quinn_proto::connection: Handshake keys ready
2024-12-15T20:14:33.597285Z TRACE Connection{id=0}:first recv: quinn_proto::connection: wrote 90 Initial CRYPTO bytes
2024-12-15T20:14:33.597328Z TRACE Connection{id=0}:first recv: quinn_proto::connection: Data keys ready
2024-12-15T20:14:33.597359Z TRACE Connection{id=0}:first recv: quinn_proto::connection: wrote 636 Handshake CRYPTO bytes
2024-12-15T20:14:33.597392Z TRACE Connection{id=0}:first recv: quinn_proto::connection: negotiated max idle timeout Some(30s)
2024-12-15T20:14:33.597412Z TRACE Connection{id=0}:first recv: quinn_proto::connection: got Data packet (595 bytes) from [::ffff:<IP_ADDRESS>]:34117 using id<PHONE_NUMBER>000000
2024-12-15T20:14:33.597439Z TRACE Connection{id=0}:first recv: quinn_proto::connection::packet_crypto: decryption failed with packet number 5011686
2024-12-15T20:14:33.597451Z DEBUG Connection{id=0}:first recv: quinn_proto::connection: failed to authenticate packet
2024-12-15T20:14:33.597465Z TRACE Connection{id=0}: quinn_proto::endpoint: new connection id=0 icid=00d6694e19deb7cc
2024-12-15T20:14:33.597541Z TRACE Connection{id=0}:drive{id=0}:send{space=Initial pn=0}: quinn_proto::connection: ACK ArrayRangeSet([0..1]), Delay = 1212us
2024-12-15T20:14:33.597562Z TRACE Connection{id=0}:drive{id=0}:send{space=Initial pn=0}: quinn_proto::connection: CRYPTO: off 0 len 90
2024-12-15T20:14:33.597614Z TRACE Connection{id=0}:drive{id=0}:send{space=Handshake pn=0}: quinn_proto::connection: CRYPTO: off 0 len 636
2024-12-15T20:14:33.597634Z TRACE Connection{id=0}:drive{id=0}:send{space=Handshake pn=0}: quinn_proto::connection::packet_builder: PADDING * 385
2024-12-15T20:14:33.597667Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: sending 1200 bytes in 1 datagrams
2024-12-15T20:14:33.597717Z TRACE Connection{id=1}:first recv:frame{ty=CRYPTO}: quinn_proto::connection: consumed 615 CRYPTO bytes
2024-12-15T20:14:33.598169Z TRACE Connection{id=1}:first recv: quinn_proto::connection: Handshake keys ready
2024-12-15T20:14:33.598183Z TRACE Connection{id=1}:first recv: quinn_proto::connection: wrote 90 Initial CRYPTO bytes
2024-12-15T20:14:33.598210Z TRACE Connection{id=1}:first recv: quinn_proto::connection: Data keys ready
2024-12-15T20:14:33.598230Z TRACE Connection{id=1}:first recv: quinn_proto::connection: wrote 636 Handshake CRYPTO bytes
2024-12-15T20:14:33.598252Z TRACE Connection{id=1}:first recv: quinn_proto::connection: negotiated max idle timeout Some(30s)
2024-12-15T20:14:33.598263Z TRACE Connection{id=1}:first recv: quinn_proto::connection: got Data packet (595 bytes) from [::ffff:<IP_ADDRESS>]:37198 using id<PHONE_NUMBER>000000
2024-12-15T20:14:33.598279Z TRACE Connection{id=1}:first recv: quinn_proto::connection::packet_crypto: decryption failed with packet number 209
2024-12-15T20:14:33.598287Z DEBUG Connection{id=1}:first recv: quinn_proto::connection: failed to authenticate packet
2024-12-15T20:14:33.598296Z TRACE Connection{id=1}: quinn_proto::endpoint: new connection id=1 icid=3da0ab65a789d21d
2024-12-15T20:14:33.598342Z TRACE Connection{id=1}:drive{id=1}:send{space=Initial pn=0}: quinn_proto::connection: ACK ArrayRangeSet([0..1]), Delay = 812us
2024-12-15T20:14:33.598354Z TRACE Connection{id=1}:drive{id=1}:send{space=Initial pn=0}: quinn_proto::connection: CRYPTO: off 0 len 90
2024-12-15T20:14:33.598380Z TRACE Connection{id=1}:drive{id=1}:send{space=Handshake pn=0}: quinn_proto::connection: CRYPTO: off 0 len 636
2024-12-15T20:14:33.598390Z TRACE Connection{id=1}:drive{id=1}:send{space=Handshake pn=0}: quinn_proto::connection::packet_builder: PADDING * 385
2024-12-15T20:14:33.598390Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=1 id=d23591d4e23c068d
2024-12-15T20:14:33.598408Z TRACE Connection{id=1}:drive{id=1}: quinn_proto::connection: sending 1200 bytes in 1 datagrams
2024-12-15T20:14:33.598414Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=2 id=f275ba5c0a349902
2024-12-15T20:14:33.598430Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=3 id=b65101bdf86173d5
2024-12-15T20:14:33.598445Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=4 id=87e9265d77a64f52
2024-12-15T20:14:33.598457Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=5 id=ef11e62223832a01
2024-12-15T20:14:33.598469Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=6 id=0601602efe2ef9d2
2024-12-15T20:14:33.598483Z TRACE Connection{id=0}:drive{id=0}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=7 id=a2688350018fbc98
2024-12-15T20:14:33.598513Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: sending 217 bytes in 1 datagrams
2024-12-15T20:14:33.598533Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=1 id=71b11657a8c6126a
2024-12-15T20:14:33.598554Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=2 id=67bda07c25d40434
2024-12-15T20:14:33.598565Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=3 id=efb2ff74ccc13c5e
2024-12-15T20:14:33.598561Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: got Handshake packet (47 bytes) from [::ffff:<IP_ADDRESS>]:34117 using id 923e7138de5f50e3
2024-12-15T20:14:33.598574Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=4 id=5587c9791248eac0
2024-12-15T20:14:33.598584Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=5 id=632a7f6cb2e004bd
2024-12-15T20:14:33.598591Z TRACE Connection{id=0}:drive{id=0}:recv{space=Handshake pn=0}: quinn_proto::connection: discarding Initial keys
2024-12-15T20:14:33.598594Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=6 id=207a05e0a3f2ef25
2024-12-15T20:14:33.598604Z TRACE Connection{id=1}:drive{id=1}:send{space=Data pn=0}: quinn_proto::connection: NEW_CONNECTION_ID sequence=7 id=ed6c3c2d9b4e6812
2024-12-15T20:14:33.598628Z TRACE Connection{id=1}:drive{id=1}: quinn_proto::connection: sending 217 bytes in 1 datagrams
2024-12-15T20:14:33.598628Z DEBUG Connection{id=0}:drive{id=0}:recv{space=Handshake pn=0}:frame{ty=ACK}: quinn_proto::connection: ECN not acknowledged by peer
2024-12-15T20:14:33.598655Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: connection closed
2024-12-15T20:14:33.598703Z  INFO Connection{id=0}: full::webtransport: Result: Err(connection aborted by peer: the application or application protocol caused the connection to be closed during the handshake)
2024-12-15T20:14:33.598979Z TRACE Connection{id=1}:drive{id=1}: quinn_proto::connection: got Handshake packet (46 bytes) from [::ffff:<IP_ADDRESS>]:37198 using id 14ffb35e7a8f38ee
2024-12-15T20:14:33.598988Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: got Handshake packet (47 bytes) from [::ffff:<IP_ADDRESS>]:34117 using id 923e7138de5f50e3
2024-12-15T20:14:33.599002Z TRACE Connection{id=1}:drive{id=1}:recv{space=Handshake pn=0}: quinn_proto::connection: discarding Initial keys
2024-12-15T20:14:33.599032Z DEBUG Connection{id=1}:drive{id=1}:recv{space=Handshake pn=0}:frame{ty=ACK}: quinn_proto::connection: ECN not acknowledged by peer
2024-12-15T20:14:33.599054Z TRACE Connection{id=1}:drive{id=1}: quinn_proto::connection: connection closed
2024-12-15T20:14:33.599079Z  INFO Connection{id=1}: full::webtransport: Result: Err(connection aborted by peer: the application or application protocol caused the connection to be closed during the handshake)
2024-12-15T20:14:33.666179Z TRACE Connection{id=1}:drive{id=1}: quinn_proto::connection: timeout timer=Close
2024-12-15T20:14:33.667397Z TRACE Connection{id=0}:drive{id=0}: quinn_proto::connection: timeout timer=Close

I'm willing to help investigate - any suggestions where to start? Test with older versions of Firefox to determine when it broke? Test with real TLS certificates instead of self-signed?

Thank you for the support and the help.
When reproducing, Firefox seemed to return Unsupported Certificate (43) sometimes (instead of application error). At this point of the investigation, the error happens during TLS handshake. It should not be related to webtransport protocol, rather to TLS/QUIC layer.
I've tried both with self-signed certificate and mkcert.
We should understand what changed in new Firefox release for certificate validation (maybe a look at firefox source code changes might worth it)

The last working firefox release was 132.0.2 and the first broken release was 133.0.
I built firefox from source and bisected changes. The first broken commit is 845419:299911741634. It references bug Bug 1929368 "Disable HTTP/3 only when a third party root certificate is used in connection" which sounds relevant.

Here is a temporary workaround that resolves the issue:

enter about:config in the firefox address bar
accept the scary warnings
change network.http.http3.disable_when_third_party_roots_found from true to `false

The diff proposed to fix this Mozilla bug appears to re-enable serverCertificateHashes. Relevant discussion: https://github.com/w3c/webtransport/issues/623


Add description/help

Need a brief description of what the heck this is and how to use it.

Fixed in 76eeb14c116b0bd24a5c759f3654edfc11c1a8f0


Blockzilla seems to no longer exist.

Blockzilla seems to be dead. All links to it don't work and it has been removed from filterlists.com.
It's safe to assume the filter has been discontinued.

README is updated now,


HiveWarehouseConnector fetching only 1000 rows through hive.execute()

we are using the spark 2.3.0 version with Hadoop3 to fetch the records using hive table. While using the hive connector library we are facing issue where it does only 1000 records fetch though we have more than millions records eligible for query we pass. Any possibility of overriding this value set for us to get more records.

I saw this issue a bit ago. execute looks like it only runs through the driver (and increasing that limit can OOM) and should be used primarily for catalog operations. The solution was to use executeQuery instead.

I saw this issue a bit ago. execute looks like it only runs through the driver (and increasing that limit can OOM) and should be used primarily for catalog operations. The solution was to use executeQuery instead.

Yes, but the LIMIT instruction used in executeQuery() does not return the required number of lines (up to 260x from my tests).


Add a second slide to the slideshow

Add one file in order to create a second slide.
And add one word to say bye.

Ok, I edited it now


fix index error when calling ticker's info

if the holders returned is a list of data frame, we should extract it before using it, otherwise there will be a index error

solved in PR #459


[TS Migration] Migrate NewChatPage

Details
[TS migration] Migrate NewChatPage page to TypeScript
Fixed Issues
$ https://github.com/Expensify/App/issues/25178
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Test NewChatPage:

Log into an account
Start a new chat and on the creation page check the following:
[ ] - TextInput filters the users
[ ] - Selecting a user works
[ ] - Creating a new chat works
[ ] - Keyboard behaviour works as expected

Offline tests
N/A
QA Steps

[x] Verify that no errors appear in the JS console

Same as in the Tests section.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ruben-rebelo Can you merge main here?

@shubham1206agra Done

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/58412969/50a50fdb-fe07-411d-9c36-13fbb414acde

Android: mWeb Chrome
https://github.com/Expensify/App/assets/58412969/fd627fc0-e5db-4b5a-bc13-d132c437dd3a

iOS: Native
https://github.com/Expensify/App/assets/58412969/16a7e2a9-b9f8-470f-b0be-59263f123a75

iOS: mWeb Safari
https://github.com/Expensify/App/assets/58412969/bdc729bd-a8d6-4510-a47b-fdc251132bef

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/58412969/76b96c82-c0b0-4a09-a562-26e1e9e700b8

MacOS: Desktop
https://github.com/Expensify/App/assets/58412969/f8b4079f-90c7-424e-881c-86d01ed811b6

@ruben-rebelo Please fix conflicts.

Conflicts resolved

@ruben-rebelo conflicts again, sorry to leave this open for so long!

Hello @jasperhuangg, no problem at all.
No conflicts anymore, thank you!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Peep hole opt for $logic_not with constant 1 in input A.

Can you give an example that is optimized by this, but not by the existing code for optimizing $logic_not cells?
For example:
module test(input [7:0] a, output [7:0] y);
  assign y = !(a | 16);
endmodule

Is optimized to y = 0 perfectly fine by the existing code:
2. Executing OPT_EXPR pass (perform const folding).
Replacing $or cell `$or$test.v:2$1' in module `test' with cells using grouped bits:
  New cell `$auto$opt_expr.cc:158:group_cell_inputs$4': A=7'0000000, B={ \a [7:5] \a [3:0] }
  New cell `$auto$opt_expr.cc:158:group_cell_inputs$6': A=2'10, B=2'10
Replacing $or cell `$auto$opt_expr.cc:158:group_cell_inputs$4' in module `\test' with identity for port B.
Replacing $or cell `$auto$opt_expr.cc:158:group_cell_inputs$6' (2'10, 2'10) in module `\test' with constant driver `$auto$opt_expr.cc:145:group_cell_inputs$5 = 2'10'.
Replacing port A of $logic_not cell `$logic_not$test.v:2$2' in module `\test' with constant driver: { 24'000000000000000000000000 $auto$opt_expr.cc:145:group_cell_inputs$3 [6:4] 1'1 $auto$opt_expr.cc:145:group_cell_inputs$3 [3:0] } -> 1'1
Replacing $logic_not cell `$logic_not$test.v:2$2' (1'1) in module `\test' with constant driver `$logic_not$test.v:2$2_Y = 8'00000000'.
Removed 0 unused cells and 4 unused wires.

It seems I have had thinking mistake. The bogus. It lead me to even make optimiser. :)
You are right, I can't find any constant 1 from input of $logic_not. So I changed this optimiser to clean $logic_not inputs of constant zeros. And for that I came up with this example.
This example has a lot of unnecessary zeros in input of $logic_not. Please see JSON
From JSON it's easy to see that both adders have room for addition due to concatenated LSB zeros i.e.. adder's output will contain at least one 1 that is input for $logic_not. Actually it's another optimisation for adders to detect if LSB bits have constants, then add those constants considering carry bit and driving this constant as adder's output.
module test(input [7:0] a, input [7:0] b, output [7:0] y);
  assign y = !{({a, 4'b0000}+1), 1'b0, ({b, 4'b0000} + 1'b1)};
endmodule


sigh manage --clean_pattern works, -p doesnt

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I have read the Contribution Guidelines

Issue Description
cleaning up files localy does work with --clean_pattern , but calling the same command with -p only lists profiles.
Complete output when running fastlane, including the stack trace and command used
fastlane sigh -v
fastlane installation at path:
/usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.13.0/bin/fastlane
sigh 2.13.0
fastlane sigh manage --help
manage
Usage: fastlane sigh manage
Manage installed provisioning profiles on your system.
 Required on CI.
-e, --clean_expired  Remove all expired provisioning profiles.
-p, --clean_pattern STRING Remove any provisioning profiles that matches the regular expression.
fastlane sigh manage -p "AdHoc"
[17:08:16]: Loading Provisioning profiles from ~/Library/MobileDevice/Provisioning Profiles/
[17:08:21]: Provisioning profiles installed
[17:08:21]: Valid:
... (list of profiles)
[17:08:35]:
[17:08:35]: Summary
[17:08:35]: 108 installed profiles
[17:08:35]: 0 are valid but will expire within 30 days
[17:08:35]: 108 are valid
fastlane sigh manage --clean_pattern "AdHoc"
[17:08:39]: Loading Provisioning profiles from ~/Library/MobileDevice/Provisioning Profiles/
[17:08:44]: The following provisioning profiles are either expired or matches your pattern:
Delete these provisioning profiles 0? (y/n)  n

@hjanuschka, @KrauseFx, @asfalcone
This seems to be related to https://github.com/fastlane/fastlane/issues/7935
The top level command short options will shadow subcommand short options.
Looks like this happens after monogem migration.
For example, sigh resign -p will be treated as sigh -p.

@mgrebenets yeah - we should dive into this - and find a way how to deal with subcommands short options

@mgrebenets @hjanuschka

The top level command short options will shadow subcommand short options.

This behaivior can be confirmed with commander.
We can test with runner_spec.rb like below.
diff --git a/spec/runner_spec.rb b/spec/runner_spec.rb
index ebff198..ff5dfca 100644
--- a/spec/runner_spec.rb
+++ b/spec/runner_spec.rb
@@ -263,6 +263,22 @@ describe Commander do
       expect(global_option).to eq('path')
       expect(command_option).to eq('bar')
     end
+
+    it 'should not disable local short options' do
+      global_option = nil
+      command_option = nil
+      new_command_runner('foo', '-p', 'bar') do
+        # Same at https://github.com/fastlane/fastlane/blob/42880c27c428b0875dc8dfbaba1ba14545f8a156/sigh/lib/sigh/commands_generator.rb#L25
+        global_option('-p', '--testing-command VALUE') { |v| global_option = v }
+
+        command :foo do |c|
+          # Same at https://github.com/fastlane/fastlane/blob/42880c27c428b0875dc8dfbaba1ba14545f8a156/sigh/lib/sigh/commands_generator.rb#L109
+          c.option('-p', '--duplicated-short-command VALUE') { |v| command_option = v }
+          c.when_called {}
+        end
+      end.run!
+
+      expect(global_option).to eq(nil) # Fail because it currently returns 'bar'
+      expect(command_option).to eq('bar') # Fail because it currently returns nil
+    end
   end

thx for the testcase, this is a good starting point - now we need to figure out how to drop the parent short options - as i think its supposed that subcommands have their own context

OK.
If so, how about using global_option instead of c.option?
It will succeed the test case.
diff --git a/spec/runner_spec.rb b/spec/runner_spec.rb
index ebff198..ff5dfca 100644
--- a/spec/runner_spec.rb
+++ b/spec/runner_spec.rb
@@ -263,6 +263,22 @@ describe Commander do
       expect(global_option).to eq('path')
       expect(command_option).to eq('bar')
     end
+
+    it 'should not disable local short options' do
+      global_option = nil
+      command_option = nil
+      new_command_runner('foo', '-p', 'bar') do
+        # Same at https://github.com/fastlane/fastlane/blob/42880c27c428b0875dc8dfbaba1ba14545f8a156/sigh/lib/sigh/commands_generator.rb#L25
+        global_option('-p', '--testing-command VALUE') { |v| global_option = v }
+
+        command :foo do |c|
+          # Same at https://github.com/fastlane/fastlane/blob/42880c27c428b0875dc8dfbaba1ba14545f8a156/sigh/lib/sigh/commands_generator.rb#L109
+          global_option('-p', '--duplicated-short-command VALUE') { |v| command_option = v }
+          c.when_called {}
+        end
+      end.run!
+
+      expect(global_option).to eq(nil) # Success
+      expect(command_option).to eq('bar') # Success
+    end
   end

Hi @nafu 👋
This is a very helpful investigation, thank you.
I believe this problem is a regression caused by introducing the -p --platform option to the sigh tool options. I think the most direct solution is to remove the -p short flag from this new --platform option. /cc @hjanuschka

Hi @mfurtak 👋
That's true about -p. But -i is also affected.

short option
duplication occured SHA (PR)

-p
790b6e89e334fe0162c3dbaa47fd5e2e78865926 (https://github.com/fastlane/fastlane/pull/6169)

-i
at least from 4da135cbe6c7e428fba308ad8c7c53b1c912a208 (https://github.com/fastlane/fastlane/pull/4579)

@nafu Yes, you're right!
I have proposed a fix in #8129 that should eliminate all such conflicts for sigh. (Other tools would need a similar fix, if we like the approach)
If you have the time, it would be very helpful if you test the solution in #8129 to see if you can find any regressions.
Thank you 👍

Hey @nafu, can you drop me a quick email to<EMAIL_ADDRESS>👍

I'm going to close out this issue because the fix was shipped in fastlane 2.16.0 👍


[SCB-361] fix warning in EventBus and MonitorManager and delete metrics-extension module

Signed-off-by: zhengyangyong<EMAIL_ADDRESS>Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

fix warning in EventBus and MonitorManager
delete metrics-extension module because nothing in it yet
change metrics-prometheus module name from Java Chassis::Metrics::Prometheus Integration to Java Chassis::Metrics::Integration::Prometheus

Coverage remained the same at 87.247% when pulling 4a1be61c0cf18393591b6203add8438c26932190 on zhengyangyong:SCB-361 into 255f86e1eb6d7626769d2ea67977f33654ea45ed on apache:master.


Package on conda-forge?

As mentioned on hsf-training/hsf-training-scikit-hep-webpage#49, awkward-pandas doesn't have a package on conda-forge yet. For the time being, we can install it with pip, but it would be better if everything could be installed with the same dependency manager.

tracking here https://github.com/conda-forge/staged-recipes/pull/23612

in :+1:


Static method 'buildExpression' requires that 'JustifiableFlowLayout' conform to 'View'

I get this error while trying to use the layout:
struct TableCards: View {
    var tops : [Top]
    var body: some View {
         JustifiableFlowLayout() { // <---
            ForEach(tops) { top in
                TableView(name: top.id, rows:top.rows)
                    .frame( width: 250, height: 500)
            }
        }
    }
}

Looks like you're just missing the minSpacing parameter. It's a requirement for JustifiableFlowLayout. E.g:
JustifiableFlowLayout(minSpacing: 15) {


Error in setup: "Error: Instance $root not found"

Environment

Operating System: Linux
Node Version:     v16.16.0
Nuxt Version:     2.16.0-27616340.013f051b
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      app, bridge, alias, ssr, target, publicRuntimeConfig, head, loading, css, plugins, components, modules, apollo, i18n, router, typescript, vuetify, build, serverHandlers, devServerHandlers, buildModules
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules<EMAIL_ADDRESS>
Reproduction
git clone https://github.com/devind-team/dcis
cd client
rm -r node_modules && rm yarn.lock && yarn
yarn run dev

Open browser:
browser is always loading
Describe the bug
I want to upgrade project up latest version of nuxt/bridge.
We use composition api and after run dev got this error:

Additional context
Use apollo and pinia.
Logs
No response

Would you please provide a more minimal reproduction? I can't run this as it seems to need a graphql server running, etc.
https://stackblitz.com/github/nuxt/starter/tree/v2-bridge

Stackblitz had an internal bug logging the vm instance. But otherwise the sandbox seems to be working: https://stackblitz.com/edit/github-5xqxyf-wxr7av


tfmirate says state file not found when running in github action.

2021/07/21 16:30:28 [INFO] [migrator] compute new states (./production/b => ./production/a)
2021/07/21 16:30:28 [INFO]<EMAIL_ADDRESS>remove the override file
2021/07/21 16:30:28 [INFO]<EMAIL_ADDRESS>switch back to remote
2021/07/21 16:30:30 [INFO]<EMAIL_ADDRESS>remove the override file
2021/07/21 16:30:30 [INFO]<EMAIL_ADDRESS>switch back to remote
failed to run command (exited 1): terraform state mv -state=/home/runner/work/_temp/tmp685864232 -state-out=/home/runner/work/_temp/tmp507658855 -backup=/dev/null module.alb module.alb
stdout:

stderr:
No state file was found!

State management commands require a state file. Run this command
in a directory where Terraform has been run or use the -state flag
to point the command to a specific state location.

Both the default tmp dir and github runner tmp dir drop this error.

@BeomSeo Thank you for reporting this. Could you provide how to reproduce the error to help debug? Because at least all existing unit tests are actually running on GitHub Actions and passing.

I understand what happened.
It happened because the project could not find the existing state because backend.tf settings were automatically created while using terragrunt in the project and tfmigrate did not run terragrunt.


Zeva - review frontend and backend unit test

The frontend and backend unit tests have been included in the pipeline for a while. Review and update the tools used ti run the tests.


Log module API

There will be no files created by bamt by default anymore. Instead:

API for logging module is implemented.
For more details, see new section of docs: "Setting up loggers".
FAQ Section updated.
Minor fix: plots will be displayed with cells in Jupiter.

Codecov Report
Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (28685d0) 65.73% compared to head (444cf04) 65.34%.

Files
Patch %
Lines

bamt/log.py
37.14%
22 Missing :warning:

bamt/networks/base.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   65.73%   65.34%   -0.40%
==========================================
  Files          43       42       -1
  Lines        2913     2906       -7
==========================================
- Hits         1915     1899      -16
- Misses        998     1007       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


afterbench command do not work well when afterbench field is not specified in isucontinuous.yaml

it was duplicated to #26


http - retry handler attributes updates

related https://github.com/microsoftgraph/msgraph-sdk-design/pull/106 retry_count attribute needs to be udpated and retry_delay attribute needs to be implemented

also look at #121 for additional attributes that should be updated for this handler


SAK-31346 adding exception catch on createEntity and use getEntity me…

…thod if thrown
Sometimes, when unzipping an archive in resources, the content collections and resources are created in an illogical order, causing an IdUsedException to be thrown.
For example, in one file I have a structure like:
mobile/1.pdf
mobile/2.pdf
mobile/
It creates the entities in top-down order. When it gets to "mobile/" it already exists, therefore the error is thrown.
This will get the content entity edit object instead if IdUsedException is thrown.

Thanks @teetoppz28!


[FIX] Handle subdirectories when deleting files

Add missing require
[Fixes #89668244]
[Fixes #89665122]

+r

LGTM :+1:

The build is good and I'm seeing 1 +1s from the following folks:

tdfischer

As such, I'll attempt to merge and close this pull request.


build error in libs/squire.

Summary
I am following this docs for making PR.

I forked && cloned tui.editor.
I was trying to build libs/squire.
npm installed and did npm run build.
but got this error
Screenshots

Version
the latest version of git repository
Additional context
package.json in squire

@joielee09
windows env doesn't support that script as default.
Please look for the method to run the makeFile and make script in windows.


Use beginless range for query instead of < ?

This seems a little trivial to suggest (sorry!) but using a range in Rails 7.1 turns the query value into a proper bind parameter and preparable statement. This will become unnecessary in the next release of Rails. And I like the beginless/endless queries and all the other queries in SolidQueue that I could find use this style too 👍🏻
Here's a writeup with a little more info: https://island94.org/2024/03/rails-active-record-will-it-bind

Ooh, great catch! Thank you so much 🙏  And great article too 💯


Add --use-cache option

Maybe we can download the repo to ~/.vue-cli/repos instead of a random temp path so that we can use cached version later. 🤔
How do you think?

I think it's good idea.  👍

I think this should just be by default and always check. This would also enable offline usage

Use cache  by default , --use-remote  option to download remote repo,  this may be better

Good idea.

@likun7981 I actually think we should always check and add an option for offline like yarn's --offline (only works if cached, no remote check). There's also --prefer-offline (download if no cache) which I don't think it's necessary since we should always check for the newest version and cache it. If we use the cache by default and make users use the --remote option manually to update, a lot of people will forget. However, if we have a remote first strategy, it'll work out of the box.
we can even add a vue cache update to update all templates cached and vue cache clear. But I don't think this is necessary since they update automatically

@posva  your idea is nice , but sometimes , I just want to update  the current one which I need .

@likun7981 That's what I was saying 😄 : vue init webpack  test would try to update the cached version of the webpack template while vue init --offline webpack test would directly use the cached version

Sorry , that’s my fault 😂 , I just didn't completely understand your meaning.  I understand now.
I just only saw vue cache update to update all templates

@likun7981 😆 No worries. I was just thinking out loud. I think we shouldn't add a vue cache update command

Any thoughts on https://github.com/vuejs/vue-cli/pull/303 ?


Rewrite memory function to work on older linux kernel versions.

This rewrite makes the memory function work on old linux kernel versions while also reducing the size of the function to 3 lines.

This fixes the issue inside  #152

cc @joshbenham

Closing and reopening to make Travis look at this.

I've done some testing in VMs and this works really well, so I'm merging this now.
@joshbenham, this fixes your issues. :)


Cancel button in the resource form is needed. After modifying the resource by mistake I cannot cancel the changes, because only the "Save" button is there.

Fixed in #906


add some way to skip a function inside of a #[autometrics]'d impl block

while it is really convient to just #[autometrics] a whole impl block, it is not always really all blocks one wants to audit. one example in this repo illustrates it very well:
#[autometrics]
impl Database {
    pub fn new() -> Self {
        Self
    }

    pub async fn load_details(&self) -> Result<(), ApiError> {
        // [...]
    }
}

here the new() function is very small and the compiler could even inline it, but by adding the #[autometrics] macro on top of it it'll add the metrics stuff and thus may even disqualify it from being inline'd and thus be a performance penalty.
something like this would be cool:
#[autometrics]
impl Database {
    #[skip_autometrics]
    pub fn new() -> Self {
        Self
    }

    pub async fn load_details(&self) -> Result<(), ApiError> {
        // [...]
    }
}

workarounds
currently, it is possible to workaround this by just splitting it into two impl blocks:
impl Database {
    pub fn new() -> Self {
        Self
    }
}

#[autometrics]
impl Database {
    pub async fn load_details(&self) -> Result<(), ApiError> {
        // [...]
    }
}

internal ref: slack chat with evan

I really like this suggestion.
One thing that's a bit annoying is that I think skip_autometrics would need to be a separate proc macro that you'd need to import. The ability for macros to work on additional attributes is limited to derive macros.
A bit of a silly workaround would be to simply call the macro skip so if you didn't separately import it, you would add #[autometrics::skip] to your function.


Does crosshair support several lines?

Please see this example of nvd3.js library - http://nvd3.org/examples/line.html. Here vertical line shows intersection with each line on the chart and tool tip shows aggregated iformation.
Does it possible to to the same with crosshair component?

Very good question. The crosshair itself supports rendering a single point with vertical / horizontal annotations. However, there is no reason why you couldn't use multiple crosshairs joined together.
I'll see if I can come up with an example of this at some point later today.

Colin thank you for participating. Maybe you already have an answer? Or you can prompt me what and how to modify?

I would be interested in looking at such an example as well @ColinEberhardt !

OK, had a bit of time to play around with this. While the crosshair itself doesn't natively support multiple series, d3fc is based on the concept of small components, and as a result you can construct this behaviour yourself by using some of the more 'low level' components and features.
The d3fc crosshair is bound (via D3 data-join) to an array which is populated with a single item that represents the current crosshair location. The crosshair is visually constructed using a point series and two line annotations.
The snapping concept is also a separate piece of functionality.
You can use the component parts to create the required result, a crosshair that tracks multipel series.
Here's an example:
https://jsbin.com/jepoverovu/edit?js,output
What I have done is construct data that is bound to the chart, which has two arrays, one for the 'real' crosshair (which tracks the sine curve) and one for the point that tracks the other series.
The tracking events (e.g. trackingmove) for the crosshair are handled and here the snapping function is applied to the cosine series. This updates the array which is 'bound' to the point that tracks the cosine series.
Notice that the chart is re-rendered in its entirety each time. This is a pattern which we favour, letting D3 take care of optimizing the re-render.
Whilst this works, it isn't ideal. I'll take a look at whether the crosshair can be enhanced to more 'natively' support multiple series.
Hope that helps!

Ok, thank you. But how to show tooltip with aggregated information from both lines?

Having tooltips for the aggregated information would be tricky - as I mentioned, I think crosshair itself should be enhanced to support this. I've changed the issue title to reflect this.

If i want to implement my own crosshair how i can append "mousemove" event handler? Something like:
var multi = fc.series.multi()
  .series([gridlines, sinLine, cosLine, point, crosshair])
  .mapping(function(series) {
      switch (series) {
          case crosshair:
              return data.sinCrosshair;
          case point:
              return data.cosCrosshair;
          default:
              return data.series;
      }
  }).on("mousemove", function(d, i) {
    ...
  })

Fixed by #999.


Updates to work with SwiftPhoenixClient(v3.0.0)'s breaking release

With this branch aimed at bringing SwiftPhoenixClient and Apollo up to their latest versions respectively, the code
changed is successfully using the most recent Apollo library, and reflects SwiftPhoenixClient's most recent 3.0.0 breaking release, which was in order to properly match the phoenix.js library, which in summary:

The client now uses the JSON V2 Serializer by default (Phoenix 1.3+)
message.payload.response is now automatically unwrapped and returned as message.payload for phx_reply events.

I also have been using the code base as part of a SplitNetworkTransport with no problems, thus also updated the README.

Thank you for this PR! I'm going to run through some manual tests on the upgrade branch and take another look at writing automated tests prior to releasing to main / tagging a version.

You're welcome. I am using this in production and would also like to see some automated tests included. If I can be of any help in this regard let me know.


Pattern fields in Path Item Object are treated as operations

My example is Swagger 2, I'm not sure if OpenAPI 3.x specs are affected as well (I only work in Swagger still).
Path Items are able to extend the schema using ^x- fields, docs: https://swagger.io/specification/v2/#patterned-fields-1
Example spec
"paths": {
    "/foo/bar": {
        "x-swagger-router-controller": "foo",
        "get": { ... }
    }
}

Generated Client
export class Api<SecurityDataType = any> extends HttpClient<SecurityDataType> {
  example = {
    /**
     * @name xSwaggerRouterControllerFoo
     * @request X SWAGGER ROUTER CONTROLLER:/foo/bar
     */
    xSwaggerRouterControllerFoo: (params?: RequestParams) =>
      this.request<any, any>(`/foo/bar`, "X SWAGGER ROUTER CONTROLLER", params),
...

Generated Namespace
/**
 * @name xSwaggerRouterControllerFoo
 * @request X SWAGGER ROUTER CONTROLLER:/foo/bar
 */
export namespace XSwaggerRouterControllerFoo {
  export type RequestQuery = {};
  export type RequestBody = never;
  export type ResponseBody = any;
}

The expected behavior is that these extensions would be ignored when collating the operations.
It might be as simple as replacing this omit with a pick and a hard-coded list of verbs.
https://github.com/acacode/swagger-typescript-api/blob/7a235842080f4ffbacc5e7608b9abc409f3bc9cd/src/routes.js#L179
But given this comment I didn't presume to open a PR myself. https://github.com/acacode/swagger-typescript-api/blob/7a235842080f4ffbacc5e7608b9abc409f3bc9cd/src/routes.js#L177

Hahaha 😄
Thanks for this issue @mastermatt, I'll try to fix that at next near release!

It should be fixed in 1.12.0


Allow options to be returned from a callback

Description
When running vite without a config file and passing options directly to build a server restart will not reload the config and plugins (and how could it?)
It would be nice to add the ability to pass the config as a callback which returns it and on server.restart() can reload the config from the callback
Suggested solution
Accept a function as a InlineConfig and call it in resolveConfig
Alternative
Accept a function as the option configFile in InlineConfig
Additional context
https://github.com/vitejs/vite/blob/775bb5026ee1d7e15b75c8829e7f528c1b26c493/packages/vite/src/node/config.ts#L401-L440
https://github.com/vitejs/vite/blob/775bb5026ee1d7e15b75c8829e7f528c1b26c493/packages/vite/src/node/config.ts#L335-L338
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

We've discussed the feature in https://github.com/vitejs/vite/pull/10326 before. I think you can workaround this by creating a Vite plugin with a config() hook that assigns the config instead?

@bluwy But then it puts this burden on all the plugins instead of the vite builder which would be able to reload everything at once

I don't understand why all plugins have to change their implementation. Wouldn't it be something like this?
createServer({
  inlineConfig: {
    plugins: [
      {
        name: 'config',
        config() {
          return { /* assign your config here */ }
         }
      }
    ]
  }
})

You'd miss out on the inline-config-only properties like configFile and envFile of course. Not sure if you're using that, but it would be strange for the config files and env files to change on every restart.

From what I tried the config hook is not able to assign plugins, it's already too late so this is not a viable workaround
It would also be a plugin reassigning plugins so there is some paradox here
plugins: [
      {
        name: 'config',
        config() {
          return { plugins: [/* Any plugin added here will never run */] }
         }
      }
    ]


DACT-421 Differentiate company appointment 404 errors

DACT-421
An issue has been found when an invalid appointment ID is sent in a TM01. A service is down response is sent rather than an officer not found error. Discussed how we would handle with Thunderbirds and it was suggested that we make a change to our response body.

Updated to address code coverage


created pr checker automation workflow

What does this PR do?
This workflow automatically checks every pull request for adherence to coding standards and quality guidelines. It runs linting and testing processes to ensure that code meets the repository's requirements before merging, helping to maintain code quality and consistency.
Fixes #60

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this be tested?

[x ] Test A
[ x] Test B

Mandatory Tasks

[ x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Hello @GauravKesh can you add atleast level 2 label


Add display name on project resource (rename project)

feature is available since v0.45.0

closed with #1900


📝 Ignore option not respected

Environment information
CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.13.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/1.22.22"

Biome Configuration:
  Error:                        The property trailingComma is deprecated. Use javascript.formatter.trailingCommas instead.
  Status:                       Loaded with errors
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Formatter:
  Format with errors:           false
  Indent style:                 Tab
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Ignore:                       ["**/.DS_Store", "**/node_modules", "**/npm-debug.log", "**/dist/", "*/package-lock.json", "**/yarn.lock", "**/.vscode", "**/.idea", "test/ts/**/*.js", "**/coverage", "**/*.sw[op]", "**/*.log", "**/package/", "**/preact-*.tgz", "**/preact.tgz", "benches/dist/", "benches/results/", "benches/logs/", "benches/logs-saved/", "benches/node_modules/", "benches/proxy-packages/*/package-lock.json", "**/package-lock.json"]
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              None
  Semicolons:                   Always
  Arrow parentheses:            AsNeeded
  Bracket spacing:              true
  Bracket same line:            false
  Quote style:                  Single
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           Auto

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

Workspace:
  Open Documents:               0

Configuration
{
  "formatter": {
    "enabled": true,
    "formatWithErrors": false,
    "indentStyle": "tab",
    "indentWidth": 2,
    "lineEnding": "lf",
    "lineWidth": 80,
    "attributePosition": "auto",
    "ignore": [
      "**/.DS_Store",
      "**/node_modules",
      "**/npm-debug.log",
      "**/dist",
      "*/package-lock.json",
      "**/yarn.lock",
      "**/.vscode",
      "**/.idea",
      "test/ts/**/*.js",
      "**/coverage",
      "**/*.sw[op]",
      "**/*.log",
      "**/package/",
      "**/preact-*.tgz",
      "**/preact.tgz",
      "benches/dist/",
      "benches/results/",
      "benches/logs/",
      "benches/logs-saved/",
      "benches/node_modules/",
      "benches/proxy-packages/*/package-lock.json",
      "**/package-lock.json"
    ]
  },
  "organizeImports": { "enabled": true },
  "linter": { "enabled": true, "rules": { "recommended": true } },
  "javascript": {
    "formatter": {
      "jsxQuoteStyle": "double",
      "quoteProperties": "asNeeded",
      "trailingComma": "none",
      "semicolons": "always",
      "arrowParentheses": "asNeeded",
      "bracketSpacing": true,
      "bracketSameLine": false,
      "quoteStyle": "single",
      "attributePosition": "auto"
    }
  },
  "overrides": [
    {
      "include": ["*.json", ".*rc", "*.yml"],
      "formatter": { "indentWidth": 2, "indentStyle": "space" }
    }
  ]
}

Playground link
Steps to reproduce:

Clone https://github.com/preactjs/preact
Run npm i
Run npm run build
Run biome format .

It will try to format all generated files in dist/ folders despite them being ignored in the config.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

That will work, but I think it's a workaround. **/dist should be still valid I think. Looking at how they run the command, they use biome format ., so the folder will be crawled with a path like this ./dist, which I think should match the pattern, however we know there's a bug filed (it's somewhere), and we came to the conclusion that we prefer to evaluate a better glob lib.

We have #2000.
Maybe it is a regression, because I remember making a change to ignore entire folders when specified under ignore. We should try the reproduction on different versions of Biome.

When I add the folders explicitly they are ignored as expected:
    "ignore": [
-     "**/dist/",
+     "hooks/dist/",
+     "debug/dist/",
+     "compat/dist/",
+     "dist/",
    ]

Seems like the leading ** are not working, or maybe I'm misunderstanding the syntax.

While I was working on #3317, I noticed some code that might be related to this issue:
https://github.com/biomejs/biome/blob/3c23f599d96a67e4a32e296c0419006b3e82a835/crates/biome_service/src/matcher/mod.rs#L104-L115
I think it was meant to be starts_with, but that will still match many false positives.
And I can't see where the root field in the Matcher is used.

We have many issues with the glob matcher library. This is something we want to improve in Biome 2.0 I started some experimentation two month ago.

one thing that could be fixed is how "foo/**/*" will match both <rootDir>/foo/x and <rootDir>/nested/dir/foo/x. there's currently no way to clamp down the glob to say just the /foo at root

I believe I'm having this issue.
https://github.com/emilte/biome-issues/tree/json-format-ignore-not-respected


Explore using covid.yapie.me as the backend

Description
I think we can explore using covid.yapie.me API instead of fetching and parsing the sheet using NodeJS every time we build the page, which slows down our build time.
If it is proven that using this API speeds up the build time and increase the data accuracy (due to the more frequent data update), we can merge the implementation of this issue to the main branch.
Implementation Model
Fetch the data from covid.yapie.me in getStaticProps of the ProvincesPage.
References & Context

https://github.com/akane10/corona_sucks
https://twitter.com/zainfathoni/status/1416662729448779783

Tasks

[ ] Fetch the data in getStaticProps of the ProvincePage
[ ] Replace the data source from wbw.json to the API response of covid.yapie.me
[ ] Use the fetch-wbw script as a fallback

I think it's better to maintain our own API (if needed), just make sure we are aware with the API's availability when decide to use 3rd party API.

Sounds good. Thanks for the suggestion Mas @mazipan.
I've been in touch with the creator of covid.yapie.me.
@adityapurwa will be consulting with him to improve our architecture and probably implementing our own API if necessary.


[BUG] AudioFile AttributeError

latest commit seems to have an issue with https://github.com/kokarare1212/librespot-python/blob/rewrite/librespot/audio/decoders.py#L21 where it should be AAC_24_NORM.
    if hasattr(file, "format") and AudioQuality.get_quality(
  File "AppData\Local\Programs\Python\Python310\lib\site-packages\librespot\audio\decoders.py", line 21, in get_quality
    audio_format == AudioFile.AAC_24_NORMAL,
AttributeError: type object 'AudioFile' has no attribute 'AAC_24_NORMAL'

Thank you for your inquiry.
This has been fixed in the following commit.
e843ac6e64e70de0d8ae008072b7ebb981793f9d


GDrive Model checkpoint access

Hello by running the notebook , i had this error by executing this cell below :

Thanks

Hello,
Thank you very much for raising this issue. It seems that Gdown limits the number of possible downloads, we will try to find an alternative for downloading the model.


Compiling Firmware

Hello,
Thank you very much for the project, and all the detailed information,
i have a little issue with compiling the firmware, after 5 hours of testing and research i was unable to compile the firmware using the Make file, i think i installed everything like it should but i am getting 1 error , the compilation is creating a build folder , with an empty version file.
I am not a code expert , i really tried , but i seem to be missing something. i can really use some help or the files already compiled , it will be great .(unless a step by step explanation is possible , it would be interesting to see what i am doing wrong ).
Thank you very much,
i am using windows 10
i tested:
-GNU arm gnu 14.2
-winget install ezwinports.make in win cmd

cygwin with the correspondant packages for make .....

I have published pre-built firmware binaries here, so would you like to try this?
Actually, I developed this gadget entirely on a Mac, and the Makefile for building the firmware was designed with Unix-like environments in mind. Because of this, building it on a Mac or Linux should work without any issues. However, attempting to build it in a native Windows environment might be challenging just to gather the necessary tools.
I’m not familiar with the numerous Posix-compatible environments available for Windows, so I can’t provide precise advice on how to proceed. That said, these days, using WSL2 is probably the easiest way to get things working without much hassle. Earlier, I tried building the firmware for simhid-g1000 on WSL2 (Ubuntu) with nothing more than the Arm GNU Toolchain installed, and everything worked perfectly without any issues.
In any case, not including this kind of information in the README might have made things a bit unclear. I’ll update the README to address this. Thank you for your report.

Thank you for your fast response & sharing the files,
i really appreciated , i will be testing everything this evening, and retrying with wsl2 & will try flashing with the files you shared too.
Anyways i will Keep you posted & great job man,
best regards


Fix Smoke Tests on unity-venue-test

Adding this ticket here for future reference.
Nightly smoke tests failed, specifically in the unity-venue-test venue. Upon investigation, the OGC Pod were crashing:
ogc-processes-api-5959bdcb78-h9hvs              1/2     CrashLoopBackOff   128 (2m28s ago)   13d
ogc-processes-api-5959bdcb78-m2qgc              1/2     CrashLoopBackOff   128 (65s ago)     13d
ogc-processes-api-redis-lock-758d7d954c-q94qr   1/1     Running            0                 13d
The cause was not clear:
cinquini@MT-509305 terraform-unity % k logs  ogc-processes-api-5959bdcb78-h9hvs -c git-sync -n airflow
INFO: detected pid 1, running init handler
{"logger":"","ts":"2024-07-25 11:09:49.750851","caller":{"file":"main.go","line":528},"level":0,"msg":"starting up","pid":11,"uid":65533,"gid":65533,"home":"/tmp","flags":[]}
{"logger":"","ts":"2024-07-25 11:09:50.072027","caller":{"file":"main.go","line":806},"msg":"too many failures, aborting","error":"Run(git fetch https://github.com/unity-sds/unity-sps.git develop --verbose --no-progress --prune --no-auto-gc --depth 1): exit status 128: { stdout: "", stderr: "POST git-upload-pack (323 bytes)\nPOST git-upload-pack (272 bytes)\nfatal: Unable to create '/dag-catalog/.git/shallow.lock': File exists.\n\nAnother git process seems to be running in this repository, e.g.\nan editor opened by 'git commit'. Please make sure all processes\nare terminated then try again. If it still fails, a git process\nmay have crashed in this repository earlier:\nremove the file manually to continue." }","failCount":1}
cinquini@MT-509305 terraform-unity %

Smoke tests were fixed by simply deleting the crashing Pods:
k delete pod ogc-processes-api-5959bdcb78-h9hvs -n airflow
k delete pod ogc-processes-api-5959bdcb78-m2qgc  -n airflow
The OGC deployment automatically started new healthy Pods, and the OGC endpoint did not have to be changed.


Unused prop in dts will cause the compiler to report an error.

TypeScript Version<EMAIL_ADDRESS>
Search Terms:
Code
class FooBar {
    #foo = 'foo'

    bar() {
        return this.#foo
    }
}

Expected behavior:
declare class FooBar {
    bar(): string;
}

Actual behavior:
declare class FooBar {
    #private;
    bar(): string;
}

Playground Link:
Related Issues:
https://github.com/microsoft/TypeScript/issues/38050

@RyanCavanaugh said that this is the intended behavior in https://github.com/microsoft/TypeScript/issues/38050.
But I got some errors when I use a dts file containing unused fields.
'#private' is declared here.
Property '#private' is missing in type


Remove namshi/jose on 3.x

It's a try to fix https://github.com/lexik/LexikJWTAuthenticationBundle/issues/938. I stayed on the scope of the remove namshi/jose.
Note: the 3.x branch need a rebase to remove all deprecation during the test

Great, thanks. Don't hesitate to tell me if you want some help regarding the test setup or anything, happy to do so.

@chalasr A merge of the 2.x into the 3.x would be nice

@maxhelias done in https://github.com/lexik/LexikJWTAuthenticationBundle/commit/3711d6fbe403606620c626dcb7211294fb1f776e

Thanks @chalasr !
It's difficult to fix the CI without cleaning the code base for symfony > 5.4. I can do it here and I can increase the compatibility with php too. Like  > 8.1 ? WDYT ?

Yes, please go ahead :) Requiring PHP 8.1+ and Symfony 6.2+ is fine to me

@chalasr it's ready for a review 😄

@chalasr can you merge 2.x into 3.x that i rework this PR. Thanks

@maxhelias done, rebase unlocked!

Thanks @chalasr ! Everything is good, I would like to have a first review. All that's left is to make the file UPGRADE-3.x.md

Thanks a ton Max! You rock.


NimBLE - Handle adv complete event in AFR

Handle adv complete event in AFR
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


Add support for list of urls

Hi @Willianvdv
I used Waybackurls and got list of js urls now i want that output to be fed into Linkfinder but could not find any Option for feeding urls.txt into linkfinder.
Please add support for urls txt file.
Thanks.

you can try this simple bash script for use a list of .js urls in txt file. fst go to the directory where linkfinder is located.
then open terminal and type:
nano yourfile.sh
then copy-past the following lines:
#!/bin/bash
file=$1
lines=$(cat $file)
for line in $lines
do
python3 linkfinder.py -i $line -o cli
done
then save the file and exit with ctrl+x and enter.
then give execution permission to yourfile.sh with:
chmod +x ourfile.sh
now try it with:
./yourfile.sh js-list.txt