Ability to use GPU and APU

Hello,
It will be much better if we can use both nvidia GPU and AMD APU or any integrated graphics like intel, Both at the same time as I think the current "use_gpus" is still looking for a nvidia GPU as it's not working with a nvidia GPU and AMD APU, It's only worked with nvidia and the APU usage is 0
So it will be great if we can use both of them to speed up the training process.

AMD ROCm support is only available for Linux machines, and I do not believe you can use CUDA and ROCm concurrently with Pytorch, although I may be wrong on that. That being said, according to this issue, AMD is not supported with this software.
https://github.com/RVC-Project/Retrieval-based-Voice-Conversion-WebUI/issues/272
Also, ROCm is not supported on AMD APUs, at least in any official capacity right now. So even if RVC supported ROCm, you would not be able to utilize your APU as a result of AMD's hardware support.

We will support AMD card by using Pytorch DirectML.

We will support AMD card by using Pytorch DirectML.

Judging by the experience of stable diffusion on direct-ml, the execution speed is likely to be much lower than on rocm...

Now AMD GPU is supported for inference.

Now AMD GPU is supported for inference.

Hi, at the risk of sounding silly, how do you configure RVC for use with an AMD GPU ?

Hi.. is it possible on AMD GPUs? I downloaded AMD version but it says no supported NVIDIA GPU found

@Skynetaa did you fix the issue? I also get same log as  it says no supported NVIDIA GPU found with AMD 6700xt.


Function After Object restricted by Unexpected Token.

IDK what happened to this simple code . Actually I cant pass this after @todo:[]  .Tried this  from Chrome console to ESlint. Take a look .
var todoList = {
  todo : []

addTodo :function(HEY){
this.todo.push({
  textTodo : HEY,
  completed : true
});
 this.displayTodo();
},

 displayTodo :function(){
console.log(this.todo) ;
if (this.todo.length === 0){
  console.log("You're Are Empty !") ;
}else {
   console.log(this.todo[i].textTodo) ;
}
for (var = i ; i<this.todo.length ; i++){
  console.log(this.todo[i].textTodo);
}
if (this.todo[i].completed === true){
console.log("Right");
} else {
   console.log("Wrong");
}
},
changeTodo: function(p,n){
  this.todo[p] = n;
this.displayTodo();
}
};

This doesn't seem to be related to this plugin since it's basic Javascript and not using React. Also, you have some syntax errors such as a missing comma after todo: [] and defining the variable incorrectly in your for loop. I would also suggest using code blocks for future issues to make your code samples easier to read.

Indeed, this is invalid JavaScript syntax.

Thanks For The Reply


Cost-model panic when loading savings page

kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model goroutine 20032 [running]:
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model net/http.(*conn).serve.func1(0xc00093af00)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/net/http/server.go:1769 +0x139
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model panic(0x1cf6cc0, 0xc009fccab0)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/runtime/panic.go:522 +0x1b5
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model github.com/kubecost/cost-model/costmodel.labelsFromPrometheusQuery(0x1c812a0, 0xc009fcca50, 0xc0077ca000, 0x4d0fd, 0x1c812a0)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/app/costmodel/costmodel.go:694 +0x988
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model github.com/kubecost/cost-model/costmodel.findDeletedPodInfo(0x237a300, 0xc00041a800, 0xc008865b98, 0xc002b97a5e, 0x2, 0x0, 0x0)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/app/costmodel/costmodel.go:672 +0x356
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model github.com/kubecost/cost-model/costmodel.(*CostModel).ComputeCostData(0xc001828000, 0x237a300, 0xc00041a800, 0x23f4f20, 0xc0000e6000, 0x23e2780, 0xc0005dca20, 0xc002b97a5e, 0x2, 0x0, ...)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/app/costmodel/costmodel.go:651 +0x5683
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model main.(*Accesses).CostDataModel(0xc000189ee0, 0x239cc40, 0xc000e3c460, 0xc001e0e300, 0x0, 0x0, 0x0)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/app/main.go:147 +0x412
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc000bf8c00, 0x239cc40, 0xc000e3c460, 0xc001e0e300)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/go/pkg/mod/github.com/julienschmidt/httprouter@v1.2.0/router.go:334 +0x948
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model net/http.(*ServeMux).ServeHTTP(0xc000bf8c80, 0x239cc40, 0xc000e3c460, 0xc001e0e300)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/net/http/server.go:2375 +0x1d6
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model net/http.serverHandler.ServeHTTP(0xc0028bc1a0, 0x239cc40, 0xc000e3c460, 0xc001e0e300)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/net/http/server.go:2774 +0xa8
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model net/http.(*conn).serve(0xc00093af00, 0x23a4140, 0xc00c584900)
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/net/http/server.go:1878 +0x851
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model created by net/http.(*Server).Serve
kubecost-cost-analyzer-bb4ccf969-bgmnh cost-model 	/usr/local/go/src/net/http/server.go:2884 +0x2f4```

Hi @leosunmo can you please provide the version you're running here? This should be fixed in 1.45.2, released yesterday.

This is 1.44.4. Will upgrade ASAP.

Leo, just wanted to double check to make sure this isn't still happening for you. Let me know if we can help!

@leosunmo going to go ahead and close for now, but please reopen if this is still occurring or if we can get you anything else!

This issue doesn't seem to occur anymore


objid_t: Support user-defined conversion functions

Original issue: https://charm.cs.illinois.edu/redmine/issues/173

-- at runtime
-- at compile-time (with accompanying generated code optimizations)
-- design discussion for how to deal with id --> idx inversion

Original date: 2013-10-07 19:05:51

This won't be ready for 6.6, so push it back.


Remove console.log debug calls from production

There are several console.log calls in the code that should be removed on production version

Done. Please take a look of new version.


Why aren't the common SDK environment variable names used?

The environment variables used here are different than those used by the other MSFT SDKs (dotnet, golang, java)
All of them use:

AZURE_CLIENT_ID
AZURE_TENANT_ID
AZURE_CLIENT_SECRET
AZURE_USERNAME
AZURE_PASSWORD

Here, you need to define entirely different variables names like AAD_SERVICE_PRINCIPAL_CLIENT_ID. Is there a reason for this inconsistency? Having it means that any execution environment that needs to use both kubelogin and an azure SDK must re-define the same values under two different names.

nope. there is no reason for that! I think it's at best to support both so that we don't regress existing users. Would you consider to contribute the changes?

ATM, I don't have time to contribute patches to this project. I've already accounted for this inconsistency in our pipelines, but believe it would save other MSFT customers time as they move over to kubelogin from the currently-defaulted and soon-to-be depreciated az-login aks#2728.

no problem. we will look into this later this month or next month

no problem. we will look into this later this month or next month

Bump, it's now beyond "next month" ;)

i'm planning to pick it up next week!

When will this get released?

ack. I will release it this week.


Upgrade @slack/web-api once a fix is released because of axios vulnerability

Tracking issue in the @slack/web-api repo: https://github.com/slackapi/node-slack-sdk/issues/796
This was shown to be an issue in this Action from GitHub security vulnerability notices, and the following command line details show that axios exists because of the above explicit dependency.
→ npm ls axios
<EMAIL_ADDRESS>/path/to/krider2010/slack-bot-action
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>

@krider2010 saw you were tracking the upstream issue; wanted to notify you that 0.18.1 was released. Fix instructions here

Really appreciate that @anulman - I'll get it sorted today 🙇♀

Fixed by #2


Never checks for new mail

I've been using K-9 Mail for five years, on both Android 4.4 and 9.0. I've never gotten it to automatically check for new mail in the background like every other e-mail client does. I've looked through all ofthe settings and none of the settings I've adjusted fix this. The only time it actually checks for mail is when I have it open and click the sync button. Why isn't it checking for e-mail on its own?

Please follow the issue template.

Duplicate of #3950


Add privacy manifest

Motivation:
NIOPosix and NIOFileSystem use stat(2) (or some variation of it). These are "required reason APIs" meaning that their usage and reason must be declared in a privacy manifest in order to be submitted to the App Store.
Modifications:

Add a privacy manifest to NIOPosix and NIOFileSystem

Result:
Apps using NIO won't be rejected from App Store submission for missing privacy manifests.

@swift-server-bot test this please


Full experiment with the new C-specific prompt

Running a full experiment with the new C-specific prompt.

@DavidKorczynski: Are there any other changes required to use the C-specific prompt?
Would you recommend updating the benchmarks before the exp?

/gcbrun exp -n dg

@DavidKorczynski: Are there any other changes required to use the C-specific prompt?

No

Would you recommend updating the benchmarks before the exp?

We can use these benchmarks for pure C projects only: https://github.com/google/oss-fuzz-gen/pull/371

/gcbrun exp -n dk-9000 -b c-specific

The experiment report with c-benchmarks only:
https://llm-exp.oss-fuzz.com/Result-reports/scheduled/2024-06-23-weekly-all/
The incorrect header error persists.
Take bind9 as an example:
The prompt provided the header full path (/src/bind9/lib/dns/include/dns/view.h), but LLM still used the incorrect path (/src/bind9/lib/isc/include/dns/view.h), which highlights the need to fix this programmatically.
@DavidKorczynski will you address this?

Re-running under the same config as 2024-06-23-weekly-all/ with C benchmarks only:
https://llm-exp.oss-fuzz.com/Result-reports/scheduled/2024-06-24-weekly-all/

Outdated.


Post Decision Notification

I would activate it after the Decision Stage is done. PCs can enter all the decisions and then use the Post Decision Stage to notify all the authors.
Another alternative is to move the notification functionality to the DecistionStage. I don't remember why I asked to do it in the Post Decision Stage.


[SPARK-34854][SQL][SS] Expose source metrics via progress report and add Kafka use-case to report delay.

What changes were proposed in this pull request?
This pull request proposes a new API for streaming sources to signal that they can report metrics, and adds a use case to support Kafka micro batch stream to report the stats of # of offsets for the current offset falling behind the latest.
A public interface is added.
metrics: returns the metrics reported by the streaming source with given offset.
Why are the changes needed?
The new API can expose any custom metrics for the "current" offset for streaming sources. Different from #31398, this PR makes metrics available to user through progress report, not through spark UI. A use case is that people want to know how the current offset falls behind the latest offset.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test for Kafka micro batch source v2 are added to test the Kafka use case.

Can one of the admins verify this patch?

hi @yijiacui-db, thanks for working on this. I'm still working on this and related API. The community has an agreement (SPARK-34366, PR #31476) on metric API for data source. Next step I will implement the API at data source (kafka). If you are interested in this work, welcome to help review the work later. Thanks.

hi @yijiacui-db, thanks for working on this. I'm still working on this and related API. The community has an agreement (SPARK-34366, PR #31476) on metric API for data source. Next step I will implement the API at data source including kafka data source. If you are interested in this work, welcome to help review the work later. Thanks.

Hi @viirya, this pull request exposes the backlog metrics to end-user through streaming query progress, not the metrics in the Spark UI.  I think it makes sense to combine both of them to expose this information at different levels. Sorry I used your jira number because I thought that's the jira number I should use. I can make another jira to track this work if you perfer.

For different purpose, I think it is better to create another JIRA. Thanks.

Agree with @viirya on creating another JIRA. Let's link these two tickets together.
IMO, we should have the metrics both in UI and progress reporter. We can do the follow-ups to combine the code (e.g., the metrics collection part).
Also cc @HeartSaVioR @gaborgsomogyi @Ngone51 @zsxwing

Agree with @viirya on creating another JIRA. Let's link these two tickets together.
IMO, we should have the metrics both in UI and progress reporter. We can do the follow-ups to combine the code (e.g., the metrics collection part).
Also cc @HeartSaVioR @gaborgsomogyi @bozhang2820 @Ngone51 @zsxwing

@viirya @xuanyuanking Thanks. I opened this SPARK-34854 to track the work.

It's OK to keep this PR open, just change the title to the new Jira number. :) @yijiacui-db

It's OK to keep this PR open, just change the title to the new Jira number. :) @yijiacui-db

@xuanyuanking Thanks! I reopened it and changed the jira # and also descriptions.

Yeah I guess it's just a matter of parsing and calculation on user end.

Do you have specific use case leveraging this information?
Are you planning to integrate this information to Spark UI or somewhere?
Could you please try out recent version of Spark and check the available information on SourceProgress, and see whether it could solve the same use case despite of some more calculation?

Do you have specific use case leveraging this information?

+1 on @HeartSaVioR comment and would be good to see the big picture before we go into the details.
Related UI it worth to create a separate Jira.

Yeah I guess it's just a matter of parsing and calculation on user end.

Do you have specific use case leveraging this information?
Are you planning to integrate this information to Spark UI or somewhere?
Could you please try out recent version of Spark and check the available information on SourceProgress, and see whether it could solve the same use case despite of some more calculation?

@viirya @HeartSaVioR  I don't think that's a duplicated information in source progress. The information recorded in the source progress now is the latest consumed offset by the stream, not the latest offset available in the source. Take Kafka as an example, we can have read limit while consuming the offsets, so we can only consume some certain number of offset, but the available data in kafka is more than that. That can be applied to all the other streaming sources too. There are some users want to know whether they fall behind and want to adjust the cluster size accordingly.
I don't think the current spark progress can calculate the information as i mentioned above, because the latest offset available information is internal for the source, there's no way to know that with the current source progress.
I didn't have a plan for integrating this information with spark UI. That's something I can work on after @viirya 's PR is merged in. I can refactor and adjust accordingly to see whether this metrics information can be exposed through spark UI too.

The latest offset in source progress is the latest offset available in the source, not the latest consumed offset by the stream.

The latest offset in source progress is the latest offset available in the source, not the latest consumed offset by the stream.

@viirya That's a good point. I referred to the latest consumed offset used in metrics method, without realizing that latestOffset available is reported by Kafka through reportLatestOffset. While implementing this metrics interface, it's more general for sources that don't implement reportLatestOffset, who doesn't have access to latest available offset in the source progress.
It's definitely true that for Kafka source, this api isn't that necessary because of that reported latest offset. @zsxwing @tdas Do you think that we should remove this api for kafka source because it's kinda duplicated? And if so, do we still want to merge the metrics api only to apache/spark?

What more metrics you have in mind? I see the flexibility on adding some sort of custom metrics, but want to make sure there're clear actual use cases, as we're adding public API here.

It's not only true for Kafka source. We'd need to think like this it can be true for all data sources migrated to Spark 3.2.0, as the API is available.
That said, if we only imagine the use case of the new API as the same purpose from #30988, I feel that is duplicated. That's the reason I'd like to see more use cases.

Besides the flexibility, I can see the new API here can help with the expansibility for the progress reporter. If new customized metrics needed in the future, we don't need to change the top-level for the output JSON string instead of new fields in the map-like field. It also gave us the possibility to customize metrics for different SparkDataSource.
It's definitely true that for Kafka source, this api isn't that necessary because of that reported latest offset.

Yes. Maybe you can also move the metrics added in #30988 to your new implementation. Either way is OK for me. cc @viirya for more opinions.
Agree with Gabor and Juntaek, here we need to provide more use cases for the new API. Besides the metrics added for Kafka source in this PR, from what I'm thinking, we can use this new API to expose more customized metrics for FileStreamSource only. E.g., the unread files, seen files, new files number now we exposed in the trace log.
Of cause, end-users can implement this in their customized SparkDataStream. Maybe @yijiacui-db can provide more use cases.

Take Kafka as an example, we can have read limit while consuming the offsets, so we can only consume some certain number of offset, but the available data in kafka is more than that. That can be applied to all the other streaming sources too. There are some users want to know whether they fall behind through the listener and want to adjust the cluster size accordingly.

If I understand correctly it's planned to monitor whether Spark is behind in Kafka processing. If that's true there is an existing solution for this which works like charm. The user can commit the offsets back to Kafka with a listener and the delta between available and committed offsets can be monitored. If this would be the only use-case then not 100% sure it worth the ~300 lines change set in the Kafka part.
I would like to emphasize I'm not against to make this better, just would be good to see a bit more from use-case perspective.

FYI, there was a PR to commit back the offsets from Spark itself which was not satisfying to everybody needs so was not merged.

@gaborgsomogyi @xuanyuanking We have some customized sources following the user’s requirements. They want to  dynamically adjust the size of the cluster based on how far they're falling behind the latest. With this PR, they can be exposed to this metrics through source progress at the end of each batch.
@tdas  @zsxwing  Feel free to correct me / add more details.

They want to dynamically adjust the size of the cluster based on how far they're falling behind the latest. With this PR, they can be exposed to this metrics through source progress at the end of each batch.

I think it's a reasonable use case for me. cc @HeartSaVioR @gaborgsomogyi for their opinions.
I'll take a close look at the code today.

Dynamic allocation based on load is something which is important to users and I support the direction so I'm fine.
I need some time to test the PR on cluster though...

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

Users can implement this interface in their customized SparkDataStream and know how far falling behind through the progress listener. Maybe this can provide more useful information to guide/trigger the auto scaling.

I see that that the comments are resolved but no changes pushed. Are you still working on this, doing some tests or just forgotten?

I see that that the comments are resolved but no changes pushed. Are you still working on this, doing some tests or just forgotten?

I'm sorry for the late reply. I was working on it but forgot to push the commit. Also I found a bug while I was working on it and also pushed the commit for the bug.

retest this please

Test build #138005 has started for PR 31944 at commit b870302.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42524/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42524/

Test build #138005 has finished for PR 31944 at commit b870302.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138005/

@viirya please make judgement how fits into the whole picture since I'm not involved in the metrics API development.

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

Users can implement this interface in their customized SparkDataStream and know how far falling behind through the progress listener. Maybe this can provide more useful information to guide/trigger the auto scaling.

This is a valid user-case. But my question is that current offsets in SourceProgress should already provide the information the use-case needs (consumed offset, available offset). The source progress should be also available on the customized SparkDataStream. Do you mean the metrics from the customized SparkDataStream is not offset related?

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

Users can implement this interface in their customized SparkDataStream and know how far falling behind through the progress listener. Maybe this can provide more useful information to guide/trigger the auto scaling.

This is a valid user-case. But my question is that current offsets in SourceProgress should already provide the information the use-case needs (consumed offset, available offset).

That is what understand as well - that is just a matter of "where" we want to put calculation.
I have mixed feeling of this as:

If the target persona is human, then I'd rather not let them calculate by themselves. It should be helpful to let Spark calculate and provide the information instead.

If the target persona is a "process" (maybe Spark driver or some external app?), then it should not be that hard to calculate by itself.

Not sure which is the actual use case for this PR.

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

Users can implement this interface in their customized SparkDataStream and know how far falling behind through the progress listener. Maybe this can provide more useful information to guide/trigger the auto scaling.

This is a valid user-case. But my question is that current offsets in SourceProgress should already provide the information the use-case needs (consumed offset, available offset). The source progress should be also available on the customized SparkDataStream. Do you mean the metrics from the customized SparkDataStream is not offset related?

Yes. Available offset is retrieved through reportLatestOffset, that's something Kafka already implemented, so that's duplicated because we can use the latest consumed offset and also the available offset to compute how far is falling behind.
But, for other customized spark data stream, it's possible that reportLatestOffset isn't implemented, so from the source progress report, there's no way to know the latest available offset to do the computation.  Also, the customized metrics, for example, how far the application is falling behind from the latest, can be represented in other ways (not only in the number of offset), which all depends on the how the stream defines it.

I've tested it on real cluster and works fine.
Just a question. How this it intended to use for dynamic allocation?

Users can implement this interface in their customized SparkDataStream and know how far falling behind through the progress listener. Maybe this can provide more useful information to guide/trigger the auto scaling.

This is a valid user-case. But my question is that current offsets in SourceProgress should already provide the information the use-case needs (consumed offset, available offset).

That is what understand as well - that is just a matter of "where" we want to put calculation.
I have mixed feeling of this as:

If the target persona is human, then I'd rather not let them calculate by themselves. It should be helpful to let Spark calculate and provide the information instead.
If the target persona is a "process" (maybe Spark driver or some external app?), then it should not be that hard to calculate by itself.

Not sure which is the actual use case for this PR.

@HeartSaVioR This is a good question! I already updated my answer in the comment above, for how it works, and why we need this metrics interface. No matter whether the target persona is human or process, it's always possible that what is available as the latest is something internal to the customized spark data stream and can't be reported as offset, so it's not possible to calculate metrics using offsets and report them as offsets.

Yeah I agree about the rationalization and benefits of "adding public API on custom source metrics", though it'd be even better if we could talk with real case which is not covered by #30988.
I feel that the reason the review gets dragging is due to Kafka use-case. Your explanation may make sense on "other" data source (hypothetically, as you haven't provided actual one), but for Kafka case it's possible for specific process to calculate lag with the change of #30988. I agree it's bad for human being to calculate the lag per topic partition and summarize by him/herself, but it's still not that hard for specific process to do that.

Yes that sounds like a good rationalization for real case. Thanks!
I looked into the changes on API side, and felt both #30988 and this can co-exist. #30988 covers specific cases where latest offset as Offset format can be provided by data source, and this covers more general ("arbitrary" might fit better) cases where the information data source wants to provide is not limited to the latest offset.
For sure, the actual behavioral change in #30988 can be implemented with the API being added here, but providing general output across data sources would be ideally more useful, like plotting to the UI. (I know the technical lack here on making it general as the format of "Offset" is varying across data sources and consumer has to take care.)
For the newly added Kafka metrics, it still makes sense when the target persona is human (convenient to check), but otherwise I agree with @viirya that it sounds like redundant. Despite the fact code change is not huge, probably good to split this down to two PRs with two JIRA issues 1) API changes 2) Kafka metrics, and finalize reviewing 1) first as there seems no outstanding concern on API changes.

cc. @HyukjinKwon @dongjoon-hyun as they reviewed #30988.

Okay, that metrics for FileStreamSource sound an use-case that makes sense. I'm okay you go with this PR.

retest this, please

@yijiacui-db
Appreciate if you could rerun your Github Action test in your fork. I guess rerunning action here wouldn't retrigger the test on your fork. We don't have good way for others (except author) to retrigger tests automatically yet.

retest this, please

retest this please

Test build #138163 has started for PR 31944 at commit 2f13f28.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42684/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42684/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42684/

Test build #138163 has finished for PR 31944 at commit 2f13f28.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138163/

Thanks! Merging to master!

Thanks all for thoughtful reviewing and thanks @yijiacui-db for the contribution! Merged to master.

Thanks all for thoughtful reviewing and thanks @yijiacui-db for the contribution! Merged to master.

@HeartSaVioR @xuanyuanking @gaborgsomogyi @viirya Thank you so much for reviewing this PR!


Modularize parser component

This build made some refactoring on the structure of the project so that Parser Component has a clearer API now. The other components can communicate with Parser Component by the ParserService Interface. The clients of Parser Component do not need to bother how to manipulate different parts of the parser to finish a task now, what the other components need to do is providing the input to appropriate port of the ParserService instance, and then the desired output will be returned. The clients who use Parser Service can put new requirements on Parser Component by adding methods in ParserService Interface.
@owolabileg  @pdaian  @yzhang90 Please review.

Hi,
I'd like to add you to my professional network on LinkedIn.

Qingzhou

Accept: https://www.linkedin.com/blink?simpleRedirect=3gSdzkSd3gQd3cQcz0VdPkTejkZh4BKrSBQonhFtCVF9Bphh7FEhllMfnBBiShBsC5EsOpQsSlRpRZBt6BSrCAZqSkConhzbmlQqnpKqiRQsSlRpORIrmkZpSVFqSdxsDgCpnhFtCV9pSlipn9Mfm4CdPkJtmJDcCNFdCAJp3sPtDBUbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I5975790271449825280_500&markAsRead=
You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=3sRbnlHpP9IqjpFbmgTcTpVu2QZp6BB9ARhdnhKp7kStjdbsAJnhQh1hmAJsT51iB1GoR9Uqmd5clhdck9HomtqiB19sPdId5gTgPBApkZfmktoqkhxelZls4pFjABebjcUpkFdtmdLjRpxpQVbkBdvtSNQcB9HujxUqBtHlQB7mz1eln0Tqkt8cTB5qlhfc75IimdPlSd5nQVDe5pekz4MgCdbmmV6dnllgk51gm5aq4l4skJ9oll5kk4Zp6BLr2pQsSlRpRZBt6BSrCAZqSkCkjoPp4l7q5p6sCR6kk4ZrClHrRhAqmQCrDlIfngCdPkJtmJDcCNFdCAJp3sPtDBUbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I5975790271449825280_500&markAsRead= Learn why we included this at the following link: https://www.linkedin.com/blink?simpleRedirect=0Ue3sQfmh9pmNzqnhOoipQsSlRpRZBt6BSrCAZqSkCr79lpmdFtD9BkT9BrmZQsTlzfm4CdPkJtmJDcCNFdCAJp3sPtDBUbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I5975790271449825280_500&markAsRead=
© 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA


Support: Added Disable Broadcast Warning in LLD

📝 Description
Added a simple label to LLD to warn when DISABLE_BROADCAST_TRANSACTION=1 has been enabled. This is because during testing it is easy to forget that it's been applied and can confuse tired QA's as to why their transactions and swaps are failing to get confirmed.
It will only display when DISABLE_BROADCAST_TRANSACTION=1 is put before the run command, for example:

For a .dmg executable: DISABLE_TRANSACTION_BROADCAST=1 DEV_TOOLS=1 /Applications/Ledger\ Live\ Beta.app/Contents/MacOS/Ledger\ Live\ Beta
For the dev build: DISABLE_TRANSACTION_BROADCAST=1 pnpm dev:lld

❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

[x] Test coverage N/A
[x] Atomic delivery
[x] No breaking changes

📸 Demo

https://user-images.githubusercontent.com/87659842/174921106-b5efa2e4-8aab-49cb-bc8c-0dea48d847ea.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

I'll happily review once it passes ci :pray:


jdk.internal.misc.Unsafe.park(Native Method)

Type: Bug
Component:
cloudwatch-metrics-publisher
Describe the bug
Shutting down the app results in a "unsafe park" error. Not sure if this is my fault or something new. Just upgrading to 2.3.0
Sample
2021-05-12 23:45:37.337 WARN o.a.c.loader.WebappClassLoaderBase   The web application [ROOT] appears to have started a thread named [cloudwatch-metrics-publisher] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
java.base@15/jdk.internal.misc.Unsafe.park(Native Method)
java.base@15/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:252)
java.base@15/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1661)
java.base@15/java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1182)
java.base@15/java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:899)
java.base@15/java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1056)
java.base@15/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1116)
java.base@15/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
java.base@15/java.lang.Thread.run(Thread.java:832)
JVM
openjdk version "17-ea" 2021-09-14
OpenJDK Runtime Environment (build 17-ea+5-266)
OpenJDK 64-Bit Server VM (build 17-ea+5-266, mixed mode, sharing)

Memory leak like this will take an effect only during WAR deployment, since the application server process lives longer than the application itself. With JAR deployments, this is a non-issue.
@youcangetme there is no cloudwatch-metrics-publisher component in Spring Cloud AWS - we only provide auto-configuration for micrometer-registry-cloudwatch. Perhaps you can create an issue in https://github.com/micrometer-metrics/micrometer.


quiche: Implement http2_reconstruct_object_impl.h.

Description:
Implement http2_reconstruct_object_impl.h, which provides simple test-only apis to re-construct c++ objects in place.  Also added BUILD rule "http2_test_tools_random" since it's needed by http2_reconstruct_object_impl.h.
Risk Level: none, code not used yet.
Testing:
bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all
Docs Changes: none
Release Notes: none

/assign @danzh2010

/assign @alyssawilk
/assign @mattklein123


Feature request: toPascalCase / classify

Converts the input text to pascal case.
Example usage
import toPascalCase from '@plexis/to-pascal-case';

toPascalCase('Cool');
// => 'Cool'

toPascalCase('cool mate');
// => 'CoolMate'

toPascalCase('Hey how are you today?');
// => 'HeyHowAreYouToday'

toPascalCase('camelCase');
// => 'CamelCase'

toPascalCase('kebab-case');
// => KebabCase

Aliases
import toPascalCase from '@plexis/to-pascal-case';
import {toPascalCase, classify} from 'plexis';

I'm happy to take this one on!

@jack-chapman Go for it and thanks for your contribution.

I've got this working pretty well, but I'm struggling on the case in the example above:
toPascalCase('camelCase'); // => 'CamelCase'
I haven't figured out how to tell if the given string is camelcase or not.
Currently it will do this: toPascalCase('camelCase'; // => 'Camelcase', as it treats all inputs the same.
A more specific camelToPascal() and pascalToCamel() functions might be better than having the toPascalCase function behave differently to normal when a camelcase input is supplied.

@jack-chapman I don't think you should I would go this way in simple steps:

Trim the text.

Use a regular expression that matches everything that's not alphadigital one or more times and the following character e.g
'hello world' => it will match ' ' as $1 and 'w' as $2
'hello --world' => it will match ' --' as $1 and 'w' as $2 etc

Replace the first group with '' and uppercase the second one
The implementation described above is toCamelCase #14

If you combine toCamelCase along with toTitle you can create the desired result.

@jack-chapman Another approach would be.

Use 'text'.split() along with a regular expression that matches non-numerical characters
Iterate the array and uppercase the first letter of each word using toTitle
Join the array using [].join()

You have implemented camelize again :D

Use toTitle once more for the first character of the output .

@jack-chapman One way or another you can start working with toCamelCase or wait someone's merging their PR, eventually you can create the desired example using a combination of these two packages. Does this approach make sense to you?

If @jack-chapman decides to drop this I can pick it.
It would be my first open-source contribution ever but I think I can do it properly. Let me know.

@vorillaz Thanks for the input and recommendations. I'll continue this later on tonight and hopefully raise a Pull Request for you 👍


AdditiveForceVisualizer: Use locally imported lodash filter

I found a usage of lodash's filter which was using the global _.filter instead of the imported function filter.

Sorry I missed merging this. Thanks!


[Feature]: Env variables support

What area(s) will this request affect?
Extension
What type of change do you want to see?
New feature
Overview
I thought it would be nice to have env variables support similar to Vite (https://vite.dev/guide/env-and-mode) - those can be set in .env file or in vite config. In Shopify CLI I imagine that they could be set on shopify.app.toml level and possibly in .env file. Then it should replace all import.meta.env... in extension files.
Motivation
Need simpler way to store API endpoint variable depending on the environment (dev/staging/production)

I'm aware of the lack of documentation for this, sorry about that. But this is stable and shouldn't change in the short term.

Unfortunately that's not possible. They way it works is that we pass the contents of process.env (all environment variables) to esbuild. And then esbuild does the replacement while building the extension. So we don't know which specific values are being replaced.
Since it has been solved, i'll close the issue :)


[WIP] Use encoding/json instead of json-iterator/go and fix serialization bug

Signed-off-by: Shubham Sharma<EMAIL_ADDRESS>Description
This PR moves away from https://github.com/json-iterator/go to go's std library - encoding/json. It also fixes the serialization bug mentioned in the referenced issue using Decoder.UseNumber docs.
This PR is based on #4093
Note to maintainers
Please squash commit this PR with the following:

Signed-off-by: Shubham Sharma<EMAIL_ADDRESS>Co-authored-by: Huei Feng<EMAIL_ADDRESS>
Issue reference
Please reference the issue this PR will close: #3837
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

There was a behavior change between jsoniter.RawMessage and json.RawMessage. Both of them are not equivalent. Instead, jsoniter.RawMessage behaves like []byte, wherein data is encoded in base64.


Bug: Address Data inconsistencies with compliance allowance based data

Steps to reproduce for compliance allowance based:
Navigate to CDD
Select compliance allowance based
Select a program
Select Preview data
After a user applies a program the owner/ operator filter is disabled. But when the data table is displayed the data table contains values for owner/ operator.
Navigate to the CDD
Select compliance allowance based
Select a year (years 2008 and later)
Select Preview data
After a user applies a year from 2008- later the owner/ operator filter is disabled. But when the data table is displayed the data table contains values for owner/ operator.
Spike #2449: Allowance Transactions/ Compliance allowance based Data Preview Inconsistencies
Compliance (Allowance Based):
Findings: Account Fact has Unit IDs for ARP (after 2006), NBP, and OTC data only. Other records are facility-level compliance records and are not unit-specific. Therefore, when originally joining with account_fact on unit_id many records were missing owner/operator information. The new query below uses program_year_dim to determine affected units at the particular facility and joins owner year dim with the unit fact table instead.

Defect D110 resolved @tlageman-epa


Start linting the examples folder

Fixes #1697
Description of the changes being introduced by the pull request:
The examples folder currently contains a repository example and it's
good if we start linting its content and as a result add type
annotations.
I run all of the linters on the example folder instead of only using mypy
as I thought that will be better for the code included there.
Signed-off-by: Martin Vrachev<EMAIL_ADDRESS>Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0004%) to 97.581%

Totals

Change from base Build<PHONE_NUMBER>:
0.0004%

Covered Lines:
4031

Relevant Lines:
4115

💛  - Coveralls

I rebased on top of develop and created a commit adding a lint_dirs variable as proposed by Jussi.
@lukpueh is right that this list will be simplified after we drop the old code base, but still, it will be useful to have
a lint_dirs variable even if the list is simply ./

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 98.579%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
3870

Relevant Lines:
3896

💛  - Coveralls


Add ragel [was: exe files forbidden]

I'm trying to package ragel : http://www.colm.net/open-source/ragel/
It's a tool that generate .cpp file implementing state machines.
It's a dependency of harfbuzz.
Unfortunatly it looks like exe are invalid distribution target for vcpkg. Here is the warning emitted by vcpkg :

The folder /include is empty. This indicates the library was not correctly installed.
The software license must be available at ${CURRENT_PACKAGES_DIR}/share/ragel/copyright .
file(COPY ${CURRENT_BUILDTREES_DIR}/src/ragel-6.9/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/ragel)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/ragel/COPYING ${CURRENT_PACKAGES_DIR}/share/ragel/copyright)

The following EXEs were found in /bin and /debug/bin. EXEs are not valid distribution targets.
C:/Users/vljno/Documents/GitHub/vcpkg/packages/ragel_x86-windows/bin/ragel.exe
C:/Users/vljno/Documents/GitHub/vcpkg/packages/ragel_x86-windows/debug/bin/ragel.exe

Is there a recommended way to build tools ? I guess it will likely matter for libintl too (which relies on tool to manage .po files)

Take a look at #59. For code generation tools, we actually recommend downloading pre-built binaries for x86 (if possible) and using them directly instead of building against the ports tree. The prebuilt executable should be placed in tools\ragel.exe or tools\ragel\ragel.exe if it has dll files that need to accompany it applocally.
If pre-built binaries aren't available (I didn't see any on ragel's website), then make sure to override the GENERATOR option to vcpkg_configure_cmake with "Visual Studio 14 2015". In the future, we will likely need a separate command to explicitly target the host's architecture (perhaps vcpkg_configure_host_cmake).

Fixed with #117


clang-format support

We should follow the lead of node-cpp-skel and implement easy support for clang-format: https://github.com/mapbox/node-cpp-skel/pull/56

PR over at https://github.com/mapbox/hpp-skel/pull/45

Merged https://github.com/mapbox/hpp-skel/pull/45


FEATURE: Add support for AspNet Controller

Add support for AspNet Controller to consume ArribaManagementService using Dependency Injection.
It also makes some fixes at the project Arriba.Server structure

Changed the history from the based branch.. closing this one


Upgrade

Motivation and Context

Description

Contribution Checklist

[x] I have built and tested the code locally and in a deployed app
[x] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[x] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[x] I didn't break any existing functionality :smile:

@maiconstedille please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{Maicon Stedille}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Hi @maiconstedille , this PR appears to contain customizations for your specific application, which we are unable to merge since it will affect all users of the repository.
I'm going to close this PR, but if you have a common feature or bugfix which can benefit all users please feel free to open another one in the future.


Allow to define custom XCom class

closes: #8059

Make sure to mark the boxes below before creating PR: [x]

[ ] Description above provides context of the change
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Target Github ISSUE in description if exists
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

are we sure that we want to implement XCom "override"?  This is relevant for XComAarg only, I was thinking about being able to override XComArg implementation, or control it if it's required.
What if implementation still wants to use basic XCom..
Anyway, let's see how it looks when it combines with XArg implementation. Probably, is the only way to validate this implementation is to implement "working" customization that will use this feature end to end.

Will add @casassg suggestion and let's move to apache for further discussion

Moved to https://github.com/apache/airflow/pull/8560


Added simple Home Assistant integration for Zulip

This is a very simple implementation of the integration and there are some possible improvements to it. For example, it would be more interesting to let the user decide whether the message should be sent to him directly or on a public stream. Also, the documentation is missing so far.

Automated message from Dropbox CLA bot
@ausDensk, it looks like you've already signed the Dropbox CLA. Thanks!

@ausDensk it looks like you've got some linter and mypy errors; can you fix those?

Also, did you forget to git add the doc.html file?

@timabbott I only have a server configured as a production server. It's a vm and can be cloned, etc. Any suggestions on the best way to test this? If there are docs that I should read point me to it and I will do my best to setup and test without bothering you. 🙂

Are you running 1.5.x?  But mostly I was wondering how you feel about the message formatting piece.
@ausDensk maybe you can post an example screenshot ?  We'll want one in the documentation anyway.

Updated it.
@GervaisdeM @timabbott can someone tell me where this error is coming from, and what I should do to fix it?
'''
File "/srv/zulip/zerver/lib/test_runner.py", line 132, in run_test
test_method()
File "/srv/zulip/zerver/tests/test_subs.py", line 626, in test_create_stream_by_waiting_period_threshold
self.assert_json_error(result, 'User cannot create streams.')
File "/srv/zulip/zerver/lib/test_classes.py", line 321, in assert_json_error
self.assertEqual(self.get_json_error(result, status_code=status_code), msg)
File "/srv/zulip/zerver/lib/test_classes.py", line 310, in get_json_error
self.assertEqual(result.status_code, status_code)
File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
assertion_func(first, second, msg=msg)
File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
raise self.failureException(msg)
AssertionError: 200 != 400
FAILED!
'''

I don't know where you're getting that error from; Travis CI seems to be showing linter errors?

@timabbott I am running 1.5.1 as I just upgraded.
@ausDensk I don't know about the error.

If we do not want to use the default homeassistant stream, would the stream be specified the same way as it is for the IFTTT integration by adding &stream=streamnameto the end of the resource url?

@GervaisdeM Yeah, it is possible to assign a different stream to the service's output via the way you described it. :)
@timabbott You're right, there is another linter error. At the moment I don't understand where it's coming from but it probably has something to do with doc.html since I only got it after adding that file.

Yeah I think it's that you have some malformed HTML in the doc.html.

I cleaned up the HTML and  merged this as 14024963f2b5fac9b1aaa2af2b3aec8f2323c746, thanks @ausDensk!  It probably would be worth changing the URL in automation-settings-config-yaml.png to show something a bit more reasonable (e.g. zulip.example.com) rather than the template syntax with {{}}.  Would you be up for submitting a quick PR updating that @ausDensk?  Thanks!


Bump xplat moving the fetchers

Changes
Xplat moved the fetchers to the backend. Fix all relevant files
Issue ticket number and link

Need to merge this to not fall stale, so resolving conflicts and merging.


sputkin -> sputnik

Hey @zeffii This is merging into the wrong branch! You want to make a pr for staging.

OK @benmcmahon100 my bad!


Use TypeScript and D3 v5

We will merge and iterate unless @cekees has some feedback on this.

Yes, please proceed. I’ll try to get caught up next week.

Thanks Chris, I will go ahead and make releases too. Not sure I have the rights to do it on PyPI and NPM though.

@cekees I cannot publish to NPM or PyPI, could you please give me the permissions?


incorporate vuejs

What is the best way to incorporate vuejs in the module while using de main vuejs / Vuex?

That's beyond the scope of the issue tracker here, I'd ask that elsewhere in a forum-setting like Reddit or the Laracasts community.


Reimplement sugar.DSN with net/url

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Reimplement sugar.DSN with net/url
Accidentally trim trailing spaces in CHANGELOG.md
Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #220 (0a323c8) into master (7eb5e28) will decrease coverage by 17.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #220       +/-   ##
===========================================
- Coverage   56.66%   39.05%   -17.62%
===========================================
  Files         140      138        -2
  Lines       15439    15359       -80
===========================================
- Hits         8749     5998     -2751
- Misses       6133     8923     +2790
+ Partials      557      438      -119

Flag
Coverage Δ

1.14.x
?

1.15.x
?

1.16.x
?

1.17.x
39.05% <ø> (-17.62%)
:arrow_down:

1.18.x
?

connection
?

discovery
14.42% <ø> (ø)

e2e
22.41% <ø> (-24.51%)
:arrow_down:

integration
22.41% <ø> (-24.51%)
:arrow_down:

macOS-latest
?

ratelimiter
16.87% <ø> (ø)

scripting
17.35% <ø> (ø)

table
?

ubuntu-latest
39.05% <ø> (-17.62%)
:arrow_down:

unit
26.85% <ø> (ø)

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

with.go
0.00% <0.00%> (-88.47%)
:arrow_down:

internal/repeater/repeat.go
0.00% <0.00%> (-80.29%)
:arrow_down:

internal/deadline/context.go
0.00% <0.00%> (-80.00%)
:arrow_down:

internal/table/statement.go
0.00% <0.00%> (-75.00%)
:arrow_down:

internal/scheme/config/config.go
12.50% <0.00%> (-75.00%)
:arrow_down:

internal/cluster/context.go
28.57% <0.00%> (-71.43%)
:arrow_down:

internal/balancer/list/list.go
0.00% <0.00%> (-70.84%)
:arrow_down:

log/table.go
0.62% <0.00%> (-70.46%)
:arrow_down:

table/table.go
8.41% <0.00%> (-65.43%)
:arrow_down:

internal/table/config/config.go
2.59% <0.00%> (-62.34%)
:arrow_down:

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb5e28...0a323c8. Read the comment docs.


[config] Improve Parse Error

Use a specific error type for parsing errors.

I want to eventually move to using thiserror which would make implementing one-off error types like this much easier.
@bors-libra r+

:pushpin: Commit d1e4ef5 has been approved by bmwill

@bors-libra r=bmwill

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #1862

:pushpin: Commit d1e4ef5 has been approved by bmwill

:hourglass: Testing commit d1e4ef5991fc49ce7e454a7fbcbde95b7aacd69a with merge 630ce3745e22fa938fcf222872090d1d1659daba...

@bors-libra r=bmwill

:pushpin: Commit 3b5bbb5 has been approved by bmwill

:hourglass: Testing commit 3b5bbb55d1a514fffa8ce0e7f62a4e5df752dc26 with merge 8790ca4227b39ea464cf043700024774d1f96b6f...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 8790ca4227b39ea464cf043700024774d1f96b6f to master...


How to set up a React drag-and-drop library?

Trying to install this one: https://github.com/hello-pangea/dnd
Getting permission access errors. I think this is a problem with npm?

Okay, I was doing a lot of things incorrectly but now the installation seems successful.


Classes Card: View All button not always available

The View All button on the Classes card is not always available. Investigate and fix.

Done on branch bugs/classes-view-all

Verified & merged into branch 6.5

Further testing revealed some issues which have been resolved in dc801c7 and 3108102 on branch 6.5


Handle JS interpreter (Jinter) errors more efficiently

Describe your suggestion
When deciphering streaming URLs, if something is not supported (say YouTube decides to use some obscure code in the nsig challenge) our JavaScript interpreter will fail in a pretty rudimentary way. It prints out the error in the console but gives no cue as to where the error might be coming from. This makes debugging things a whole nightmare.
Other details
See: https://github.com/LuanRT/Jinter
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

I've made some significant progress on this matter here: https://github.com/LuanRT/Jinter/pull/3.


Bug: URL, Redirect and Pagination misbehave

I've similar problems as #2119 + some bonuses :)
I've deployed project to test.com/e and set baseURL from .env file. Issues are:

Redirect:

redirect()->to('uri') function redirects to test.com/uri not test.com/e/uri
redirect()->to('uri') at localhost(spark serve) duplicates url when tries to redirect. But at server works as expected but with issue N1. At localhost I'm using with trailing slash to bypass the issue ->to('/uri')

base_url misbehave:

base_url('uri') -> test.com/e/uri.
base_url('/uri') -> test.com/uri. Should be test.com/e/uri I guess
base_url() . 'uri' -> test.com/e/uri (works but not a pretty solution)

Pagination: $pager->links() creates test.com/?page=2 instead of test.com/e?page=2

After RC3 update:

Redirect:

redirect()->to('uri') at localhost not duplicates URL but at server redirects to 'test.com' not 'test.com/e'

Rest of stays the same. Please, fix routing and redirect issues. Because all these stuff for daily use. Without these too hard

Can you provide more information so we can help ...

$baseURL setting
context in which you call redirect, eg. the controller method code

app.baseURL = 'http://test.com/e/'  from .env file

The simplest example: when I want to go admin panel, it should redirect to login page (test.com/e/admin/user/login). But redirects to test.com/admin/user/login (without folder name e)

Post.php (controller)
public function index()
{
        if(!$this->isLoggedIn())
        {
            return redirect()->to('/admin/user/login');
            // return redirect()->to('admin/user/login'); // this also not working
        }
        // some code
}


Quick hack for including csp_nonces from requests into script tags

This should fix #1723 as it optionally includes the csp_nonce from the django-csp module.

Thanks. Looks good. I'd like to have some tests for this; django-csp could be made a dependency for the testsuite so that we can actually verify that the code works as intended.

What bothers me more is that normally, link/style tags would require the nonces too. But since at its current state, 'strict-dynamic'-enabled script-src scripts can't inject styles which a lot of frameworks do), everyone just enables inlining styles and sameorigins in practice.
If this ever changes and someone enables 'strict-dynamic' for style-src, that will override 'self' on style CSPs and every link[rel=stylesheet]/style tag will require a nonce too from that point on.
I might add that preventative measure. The tests can be organized.

Sure! Feel free to include that.

So, tests are there, all working.
I'm not totally against the enforced opinionated formatting on someone's code (it's like no one is allowed to have their own code formatting), but so be it. I can just as much format the code back automatically when doing free and voluntary contributions to other projects.
In fact, I timed the dict() vs {} call with timeit and the latter seemed faster, so as per empirical evidence, I'll went with that.
Please merge and do a timely release.

So, tests are there, all working.
I'm totally against the enforcing of opinionated formatting on someone else's code (it's like no one is allowed to have their own code formatting), but so be it. I can just as much format the code back automatically when doing free and voluntary contributions to other projects.
In fact, I timed the dict() vs {} call with timeit and the latter seemed faster, so as per empirical evidence, I went with that.
Please merge and do a timely release.

Thanks for your contribution!
We're using code formatters so that we do not have to discuss code style over and over, as do many other projects. Also, we're not being paid for the work we're doing on this project either, free and voluntary here too.
The PR looks good to me at first sight, thanks. I'll take a closer look probably tomorrow.

@matthiask I'm unsure about the type definition changes here. If you're good with them, I'll let it be.
My specific concern is that we don't have a formal policy for them and I'm not sure how this current state improves things. I'd prefer to be consistent in the library so it's easier for folks to navigate around.

@tim-schilling My general opinion is that type annotations can be noisy, and not really worth it unless a big part of the code base is typed, but we have already started moving on this https://github.com/jazzband/django-debug-toolbar/issues/1705 so I'm neutral to slightly fine with it.

For context, I'm using pyright and with these added typings, my test and everything I did, checks out perfectly.
Don't be such an enemy of typing that will point out errors early with static analysis.

But the project doesn't use pyright, so it's possible for this to get out of date and cause confusion down the line.

You are confusing python typing and static analysis with pyright. The former will be valid even when the latter changes, as it's defined in python itself, and not the module.
There is only one comment in my code related to pyright, since I didn't want to go and add a missinfg type annotation in Django itself. The rest is standard python typing stuff.

Sorry, I shouldn't have even started is down that discussion. Thank you for the PR, this will be great to have.

@matthiask when you have time again, take a look at the revised PR. I'm now good with merging this.

Whoa, ruff was pretty bold here removing the HttpRequest import :D Hence why everything's failing.

Thanks!

@matthiask you're welcome.
Can I have a release please, so I could use the actual official package, instead of my fork?

@karolyi We're currently in the middle of a GSoC project adding async support to the toolbar, so I'm not sure if we want to do a release in the next few days without some additional testing first.
I generally think releasing quickly and trusting the test suite is the way to go, but I'm a bit wary now because of this larger project.

I see thanks. I've already set a notification on the releases of this project, so I'll be notified if there is a new one.
Until then, I'll keep using my fork.


[Google Cast] Fixed issue with bad conversion of nuint[] to object[]

There was an issue with passing in nuint[] arrays to the NSArray.FromObjects method that expects an object[] array.
Issue caused the nuint[] array to be wrapped inside a 1 element object[] array with exceptions as result.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@rickykaare Thank you so much for your contribution!


[Question]: sign in failure after upgrade in dev

Describe your problem
after done an upgrade in dev, unable to sign in using  userid and password and unable to create new password and id. how  to reset the existing id and password  Problem Fixed. thank you

Thank you！
On Tue, 15 Oct 2024 at 9:49 AM, Kevin Hu @.***> wrote:

Register a new user with the old password. Compare the password in MySQL:
rag_flow.user. Reset the old password to the new one using update statement.
—
Reply to this email directly, view it on GitHub
https://github.com/infiniflow/ragflow/issues/2825#issuecomment-2412650037,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKDA3Z2GHSCH2A2MSE44L23Z3RYCVAVCNFSM6AAAAABP4HRTHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGY2TAMBTG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


coding in Brackets

my whole code is not loading up it keeps on saying code the web and wont load anything

Can you provide your computer configuration?
Have you tried to reinstall Brackets?

this happened to me once when I just installed the Brackets and the folder contained lots of lots of files, so initially, it takes time to load, but afterward, it loads quickly. I have 12 GB of RAM, and an i5 processor @2.3 GHz.


Adding the target property

This helps with #201 https://github.com/probil/vue-moveable/issues/201

Merged. Thanks @russ


formly & JSON Schema Validation

Description

I build a website that renders dynamic forms with the combination of formly and json schema.
When my json schema has a field of type number and also mimimum maximum and multipleOf attributes, the input field renders correctly, but something goes wrong with the validation if the multipleOf is a float point number.

"float": {
"type": "number",
"title": "A float number",
"minimum": 3,
"maximum": 10,
"multipleOf" : 0.1
},

Another validation problem is that when I declare an integer on my schema if the user enters a float point number is considered valid by the form, and it shouldn't be valid.

fixed by #2441

duplicate of #2360


Create simple api point for notifing that the proposal is ended

https://docs.snapshot.org/webhooks

DONE


lua style counted for

in lua, there is another for cycle flavour, eg.:
-- counting from 1 up to 10
for i=1,10 do
  print(i)
end

It's something similar possible in Cor?

Actually Cor does not support range iterators, just FOR and FOR-IN see the docs. However the issue will remain open.

@severak I thought of this for flavor, my first proposal is:
for i in 1:10 {
    //something
}

what dou you think about?

@yosbelms: that looks great

soon in the next release

it has been addressed in a8fae3


Doesn't work with lastest MassTransit

Hi, this is great.
Small kink though. Doesn't work with the newest Masstransit 5.1.4.

I cloned the repository and updated the packages to the latest version, it seems to work so far.

I meant the official version.

Should be resolved by #2


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/53489

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/56394

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/60198

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/63610

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/78395

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/78435


GPL-415 ID positive samples for cherrypicking in QC report

User story
GPL-415 | As a SSR (Rich C) I  need to be able to identify positive samples for the subset of plates processed by Sample Management for cherry picking (expecting QC report needs to be adapted to show this)
Who the primary contacts are for this story
Rich C (SSR)
Danni W (SM)
Acceptance criteria
Please read section 1.1: https://ssg-confluence.internal.sanger.ac.uk/x/OpoKBg
To be considered successful it must:
The QC report as it stands now is fine, its just the addition of the disease state which needs adding to it.

Produce an excel file containing Plate ID, supplier IDs, Sanger Ids, well location and the information relating to disease state, as per manifest
It must contain all the plates which have been processed in Sample management and added to minilims for cherrypicking
It must identify all samples within the selection of plates to be processed for cherrypicking.
After identification of all the samples in the subset of plates, it must be able to filter for disease states (positive, negative or void)
It must be able to copy and paste sanger ID’s into the “create a submission” page.

Additional context
Add any other context or screenshots about the feature request here.
After discussion 5th May with Debbie and Rich C we have created a separate Heron product and added specific columns to that products criteria, including Phenotype (contains the disease state) and Sample Description (contains the Lighthouse Labs Root sample ID). Cuts out some other columns they don't need. All other product reports unaffected.
On deploy
Run
bundle exec rake product_heron:add

23rd April @13:05 Rich C wrote
The QC report as it stands now is fine, its just the addition of the disease state which needs adding to it.

  Produce an excel file containing Plate ID, supplier IDs, Sanger Ids, well location and the information relating to disease state, as per manifest

  It must contain all the plates which have been processed in Sample management and added to minilims for cherrypicking

  It must identify all samples within the selection of plates to be processed for cherrypicking.

  After identification of all the samples in the subset of plates, it must be able to filter for disease states (positive, negative or void)

  It must be able to copy and paste sanger ID’s into the “create a submission” page.

Change to requirements after discussion 5th May. See additional context above.

Deployment:
run rake task bundle exec rake product_heron:add


Why input size is 25 x 6?

what a great work!
I'm implementing with your code, but I have a question.
In your paper, Input is orientations in 6D representation of SMPL body model(24 x 6). When I check from debugging, The input shape is 25 x 6.
Which one is right? or What component is added to 24 x 6?

I check that it seems to zero padding.
Can I ask why do this?

The last channel is for global translation. Since its dimensions are 3 and not 6 it's zero-padded.

where is global translation from, it seems to be from the first action2motion joint, but why action2motion switch 0# and 8#?

If I remember correctly, this switching shouldn't be in use anymore. root rotation is at [0] and root translation is at [-1] (only the first 3 entries of it)

The switching seems to be in use:
https://github.com/GuyTevet/MotionCLIP/blob/main/src/datasets/amass.py#L94

That's a definition, not a usage, I don't see where this one is being used.


Update get-started-existing-container-image.md

@jonassamuelssoncab : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@craigshoemaker,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.

Thanks, @jonassamuelssoncab!
#sign-off


Multiple filters support

User Story:
As a user, I want to be able to conditionally apply multiple filters when querying Firebase.
Given 3 query parameters that are mutated by the User from the UI;
In model hook, I want to build the query based on params that the user interacted to.
Code example
model(params) {
  return this.store.query('modelName', {
    filter(reference) {
      return reference
        .orderBy('property-1')
        .where('property-1', '>', params['queryParam-1'])   // executed **only** when the user changes queryParam-1 query
        .where('property-1', '<', params['queryParam-2'])   // executed **only** when the user changes queryParam-2 query
        .where('property-2', '==', params['queryParam-3'])  // executed **only** when the user changes queryParam-3 query
    }
  })
}

I don't think this is ideal. You should probably make use of Route.refresh() instead.

I don't think this is ideal. You should probably make use of Route.refresh() instead.

I am refreshing the route via
  queryParams = {
    queryParam-1: {
      refreshModel: true,
    },
    queryParam-2: {
      refreshModel: true,
    },
    queryParam-3: {
      refreshModel: true,
    }
  };

since I need model hook to fire everytime the user changes the queryParams.
Can you elaborate?

I am refreshing the route via
  queryParams = {
    queryParam-1: {
      refreshModel: true,
    },
    queryParam-2: {
      refreshModel: true,
    },
    queryParam-3: {
      refreshModel: true,
    }
  };

since I need model hook to fire everytime the user changes the queryParams.
Can you elaborate?

What you're doing actually seems a good and ember-ish way so you should probably continue with that

What you're doing actually seems a good and ember-ish way so you should probably continue with that

But I may not have understood your problem. What do you mean by conditionally apply multiple filters?

But I may not have understood your problem. What do you mean by conditionally apply multiple filters?

The problem you have isn't within the scope of the adapter. Since filter is a function, you're in full control already on what query you want to execute. You can place the condition there.

The problem you have isn't within the scope of the adapter. Since filter is a function, you're in full control already on what query you want to execute. You can place the condition there.

Right, my problem is that I need to chain those methods.
When you say "place the condition there" what do you mean?
As far as I can say, my options are:

Cover all possibilities of the filters occurrence:

switch case for every filter alone and every possible combination. 7 in total. (Feels very verbose)

Optional chaining (Feels hacky, since the object itself wouldn't have the properties)
Call a default query in the place the ones user didn't interacted to. If the user does not set any queryParam I would repeat the same query three times. (Feels very hacky)
Call an opposite query in the place the ones user didn't interacted to , ('property-1', '!=', null) for instance. (Seems logic but I would bump in Firebase limitations)

Any other thoughts?
Thanks in advance
As a benchmark, what Emberfire does is to receive an array of arrays for where argument and then spread it to mount the query that actually goes to Firebase.

Right, my problem is that I need to chain those methods.
When you say "place the condition there" what do you mean?
As far as I can say, my options are:

Cover all possibilities of the filters occurrence:

switch case for every filter alone and every possible combination. 7 in total. (Feels very verbose)

Optional chaining (Feels hacky, since the object itself wouldn't have the properties)
Call a default query in the place the ones user didn't interacted to. If the user does not set any queryParam I would repeat the same query three times. (Feels very hacky)
Call an opposite query in the place the ones user didn't interacted to , ('property-1', '!=', null) for instance. (Seems logic but I would bump in Firebase limitations)

Any other thoughts?
Thanks in advance
As a benchmark, what Emberfire does is to receive an array of arrays for where argument and then spread it to mount the query that actually goes to Firebase.

Sorry, I'm still super confused with what you're trying to achieve. You said that:

As a user, I want to be able to conditionally apply multiple filters when querying Firebase.

If you want to conditionally apply filters then just wrap them in an if-condition:
if (...) {
  this.store.query('modelName', {
    filter(reference) {
      return reference.orderBy('property-1').where('property-1', '>', params['queryParam-1']);
    }
} else {
  this.store.query('modelName', {
    filter(reference) {
      return reference.orderBy('property-1').where('property-1', '<', params['queryParam-2']);
    }
}

// OR

this.store.query('modelName', {
  filter(reference) {
    if (...) {
      return reference.orderBy('property-1').where('property-1', '>', params['queryParam-1']);
    }

    return reference.orderBy('property-1').where('property-1', '<', params['queryParam-2']);
  }
}

But if you want to chain filters as per:

Right, my problem is that I need to chain those methods.

Then it already works. You have to remember that reference in filter(reference) is just a CollectionReference. Whatever it supports, the adapter will support as well, and whatever the limitation it has, the adapter will have that limitation as well.

Sorry, I'm still super confused with what you're trying to achieve. You said that:

As a user, I want to be able to conditionally apply multiple filters when querying Firebase.

If you want to conditionally apply filters then just wrap them in an if-condition:
if (...) {
  this.store.query('modelName', {
    filter(reference) {
      return reference.orderBy('property-1').where('property-1', '>', params['queryParam-1']);
    }
} else {
  this.store.query('modelName', {
    filter(reference) {
      return reference.orderBy('property-1').where('property-1', '<', params['queryParam-2']);
    }
}

// OR

this.store.query('modelName', {
  filter(reference) {
    if (...) {
      return reference.orderBy('property-1').where('property-1', '>', params['queryParam-1']);
    }

    return reference.orderBy('property-1').where('property-1', '<', params['queryParam-2']);
  }
}

But if you want to chain filters as per:

Right, my problem is that I need to chain those methods.

Then it already works. You have to remember that reference in filter(reference) is just a CollectionReference. Whatever it supports, the adapter will support as well, and whatever the limitation it has, the adapter will have that limitation as well.

Alright, thanks for the effort.
I will try to make myself clearer:
In my example, the user has the ability to filter simultaneously from three different fields.
Nevertheless, not necessarily.
So, if I have property-1, property-2 and property-3 and if I follow your instructions, I would need to have exactly seven if clauses to cover all the possibilities. For instance:
if (params.queryParam-1 && !params.queryParam-2 && !queryParam-3) {
  // Filter only by property-1
} else if (!params.queryParam-1 && params.queryParam-2 && !queryParam-3) {
  // Filter only by property-2
} else if (!params.queryParam-1 && !params.queryParam-2 && queryParam-3) {
  // Filter only by property-3
} else if (params.queryParam-1 && params.queryParam-2 && !queryParam-3) {
  // Filter only by property-1 AND property-2
} else if (params.queryParam-1 && !params.queryParam-2 && queryParam-3) {
  // Filter only by property-1 AND property-3
} else if (!params.queryParam-1 && params.queryParam-2 && queryParam-3) {
  // Filter only by property-2 AND property-3
} else if (params.queryParam-1 && params.queryParam-2 && queryParam-3) {
  // Filter only by property-1 AND property-2 AND property-3
}

What I wanted to do:
if (params.queryParam-1) {
  // Append to filter chain property-1
}

if (params.queryParam-2) {
  // Append to filter chain property-2
}

if (params.queryParam-3) {
  // Append to filter chain property-3
}

// Return query

Alright, thanks for the effort.
I will try to make myself clearer:
In my example, the user has the ability to filter simultaneously from three different fields.
Nevertheless, not necessarily.
So, if I have property-1, property-2 and property-3 and if I follow your instructions, I would need to have exactly seven if clauses to cover all the possibilities. For instance:
if (params.queryParam-1 && !params.queryParam-2 && !queryParam-3) {
  // Filter only by property-1
} else if (!params.queryParam-1 && params.queryParam-2 && !queryParam-3) {
  // Filter only by property-2
} else if (!params.queryParam-1 && !params.queryParam-2 && queryParam-3) {
  // Filter only by property-3
} else if (params.queryParam-1 && params.queryParam-2 && !queryParam-3) {
  // Filter only by property-1 AND property-2
} else if (params.queryParam-1 && !params.queryParam-2 && queryParam-3) {
  // Filter only by property-1 AND property-3
} else if (!params.queryParam-1 && params.queryParam-2 && queryParam-3) {
  // Filter only by property-2 AND property-3
} else if (params.queryParam-1 && params.queryParam-2 && queryParam-3) {
  // Filter only by property-1 AND property-2 AND property-3
}

What I wanted to do:
if (params.queryParam-1) {
  // Append to filter chain property-1
}

if (params.queryParam-2) {
  // Append to filter chain property-2
}

if (params.queryParam-3) {
  // Append to filter chain property-3
}

// Return query

if (params.queryParam-1) {
  reference.where('property-1', '>', params['queryParam-1']);
}

if (params.queryParam-2) {
  reference.where('property-1', '>', params['queryParam-2']);
}

if (params.queryParam-3) {
  reference.where('property-1', '>', params['queryParam-3']);
}

return reference;

Is this what you're looking for? That's already support if so. Again, whatever will work from Firestore's API you'll be able to do it in this Adapter as well. If it's not possible, then it's not possible here as well.
For this project, I tend to avoid adding convenience features. I would like to stick to whatever Firestore gives us for more flexibility and less maintenance.

if (params.queryParam-1) {
  reference.where('property-1', '>', params['queryParam-1']);
}

if (params.queryParam-2) {
  reference.where('property-1', '>', params['queryParam-2']);
}

if (params.queryParam-3) {
  reference.where('property-1', '>', params['queryParam-3']);
}

return reference;

Is this what you're looking for? That's already support if so. Again, whatever will work from Firestore's API you'll be able to do it in this Adapter as well. If it's not possible, then it's not possible here as well.
For this project, I tend to avoid adding convenience features. I would like to stick to whatever Firestore gives us for more flexibility and less maintenance.


Request:  The Feature Widget should be Interactive

Business Need
As a DevOps engineer, I want to be able to interact with the Feature widget on the Hygieia Dashboard in a meaningful way, so that I can get more detail into my agile content going through my pipeline.
Acceptance Criteria

GIVEN a configured Hygieia Feature Widget
WHEN certain progress values for an Agile team and sprint are unfavorable
THEN the Hygieia Feature Widget flags "Yellow" and/or "Red" depending on severity

GIVEN a configured Hygieia Feature Widget
WHEN the Widget is clicked
THEN the user is sent to a DevOps-configured web page (e.g., the content management source system or another tool that aggregates/analyzes Agile data)

Other changes may solve for this. Closing this.


Add OrbitalColony from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of RealGecko, to add OrbitalColony to CKAN.
Mod details:
name = /mod/1559/OrbitalColony
author = RealGecko
abstract = Civilian Population Assets with stock only functionality.
license = CC BY-NC 4.0
Homepage =
description = Ever wanted to create an orbital colony?
Emmm....
Let's say like this: ever wanted to create AN ORBITAL COLONY?
Here are some parts to help you.
Please direct questions about this pull request to RealGecko.

License must actually be "CC-BY-NC-4.0".


Sending to invoice AND attaching data throws error

Background
With lncli sendpayment you can pay an invoice (by using pay_req=lnbc...) or you can send some money without using an invoice by using the flag --keysend. When you use --keysend you may furthermore attach some data to the payment by using the --data flag.
However, when you send to an invoice and try to attach data there, you get a golang error:
panic: assignment to entry in nil map
Maybe there is no need to send data along with the payment when there you use invoices anyway and could just put your data into the invoice's memo field. But still, this could throw a cleaner error message than just the golang error.
Your environment

LND 0.13.4
x86_64 x86_64 GNU/Linux

Steps to reproduce

Create an invoice on node A
On node B, run the following command: lncli sendpayment --pay_req={INVOICE FROM NODE A} --data 3438382=0a21ff

Expected behaviour
Either it just works, or gives back an error message saying that the --data flag may only be used for keysend payments, but not when using invoices.
Actual behaviour
Throws a Go error with stacktrace (panic: assignment to entry in nil map)

Thanks for the report! Fix is up.


Format Typescript info on symbol/error hover

We use type aliases in our code instead of classes and interfaces. For larger types it becomes almost impossible to make any sense of the text that Typescript outputs because it can be more lines than what fits on a small screen.
It would be more than awesome if the text displayed on hover would be parsed and formatted. Perhaps collapse large types and make it possible to expand them by clicking on them?

This is something that the TypeScript team is currently investigating: https://github.com/Microsoft/TypeScript/issues/14662
Closing as upstream


Crash on v3.2.0-beta.1

Crash Log :
No implementation found for long com.shockwave.pdfium.PdfiumCore.nativeOpenDocument(int, java.lang.String) (tried Java_com_shockwave_pdfium_PdfiumCore_nativeOpenDocument and Java_com_shockwave_pdfium_PdfiumCore_nativeOpenDocument__ILjava_lang_String_2)

me too .
Here's how I solved it
step1:
add  to the module's  build.gradle
        ndk {              abiFilters "armeabi-v7a", "x86", "arm64-v8a"         }
   sourceSets {         main {             jniLibs.srcDirs = ['libs']        }    }
step2:
Add the corresponding SO file under the LIBS path

If the corresponding SO file cannot be found, it can be found in the APK that reported the error


Authenticating Tuya app not working

Added Smartlife through HACS to Home Assistant, but when trying to add the authorization for Home Assistant by scanning the QR code in the Tuya Smart app I get:
"please use the designated app to scan the code to log in"
I copied the user code from the app, so I am sure I am using the right code.
Any way to work around or debug this?
Edit: Account in the Netherlands if this might matter

Not support Tuya Smart app, Only supports Smart Life app.

不支持涂鸦智能应用，仅支持智能生活应用。

后期会支持涂鸦应用吗，还有国内一大堆涂鸦oem app

It seems, allowing Tuya App should not be a big problem because they are using the same APIs. I have all my devices set up with the Tuya App and switching to Smart Life would be a big hassle. Lots of devices with lots of automation.
Please, please consider extending this to Tuya App, too!
Or is there a way to adjust it in the source code? Probably not as it seems to be handled in the API gateway?

It seems, allowing Tuya App should not be a big problem because they are using the same APIs. I have all my devices set up with the Tuya App and switching to Smart Life would be a big hassle. Lots of devices with lots of automation. Please, please consider extending this to Tuya App, too! Or is there a way to adjust it in the source code? Probably not as it seems to be handled in the API gateway?

Tuya Smart Will support soon.

Why did you close it, it has not been added yet i believe?

I just added this with my tuya app.
What is the difference if i change to smart life?


cranelift: Fix i128 iconst on AArch64 with egraphs

👋 Hey,
This is the first of the bugs that the fuzzer found in the new egraph work. On AArch64 iconst.i128 is not implemented. This PR implements it for values that fit in a u64, which is (I think) all the values that can be passed in by the frontend.
We've had discussions in the past about removing iconst.i128 (I can't find the link), and I think I've previously disagreed with this, but maybe we can restrict iconst to i64 and add a helper method to the frontend that does the right thing? so, for example for -1 we can lower it to iconst.i64 -1 + sextend, or iconst + iconst + iconcat for other values etc..
What do you guys think about that?
cc: @cfallin

It's interesting that this was hit only when egraph-based optimization is on -- I suspect because of the different way that constants are rematerialized...
In any case, I do think that disallowing iconst.i128 makes the most sense: the type is kind of a lie, because the instruction can't actually carry a 128-bit payload. Given that it's not fully general, producers need to do something else to emit an arbitrary 128-bit constant anyway, so we might as well remove the partial support and relieve the backends of some complexity.


Inconsistent buttons on warning dialogs

VSCode Version: Code 1.19.0 (816be6780ca8bd0ab80314e11478c48c70d09383, 2017-12-14T12:06:44.860Z)
OS Version: Windows_NT ia32 10.0.16299

The warning messages we show to users should use consistent labels for buttons and should also be order the same where it makes sense. See the following example:

I propose

to use Never Show Again
to show Never Show Again right of Close, i.e. to not show an message again is a more deliberate motion than just clicking the right-most button.

We should think about enforcing the sequence of buttons in our code. I.e. shape the methods/APIs to declare whether a well-known button should be shown or not rather than where it should be shown.

@kieferrm all of that will change with the new notification UX, you should join our UX call next time Steven presents it.

fileService has the button order Don't Show Again / Close
extensionTipsService still is lower case

These are checkboxes, but just to note:

fileActions and explorerViewer uses Do not ask me again

@bpasero Please close if this is as designed.

@aeschli thanks for the findings, lets move to Feb.


Audio Only Quality

Thanks for great utility!
Audio only quality downloads are only available for streams that are presently live since 1.3.9. Perhaps this is due to the change in Twitch API? The Audio only quality is great for listening to Podcast style streams.

Yep, Twitch does not support audio only streams anymore.

I didn't notice that! For info, the last vods with the audio only option appear to be May 30. I use a freeware program to batch extract audio. May I name it?

Sure


Deprecation warning about Rails.application.secrets on rails 7.1

Environment

Ruby [3.2.2]
Rails [<IP_ADDRESS>]
Devise [4.9.3]

Current behavior
I see a deprecation warning when running tests. This should be reproducible on any rails 7.1 install with devise.
$ bundle exec rspec spec
DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. (called from <top (required)> at rails-project/config/environment.rb:7)

Expected behavior
No deprecation warning when running tests locally.
I think the https://github.com/heartcombo/devise/blob/main/lib/devise/secret_key_finder.rb will need to be updated to not attempt to call application.secrets, before calling application.config.secret_key_base (which is what development and test) seem to defer to.

Good idea. This worked for me:
Devise.setup do |config|
  config.secret_key = '' if Rails.env.test?
end


Missing newRelease information in configFile

The actual release number (1.0.0) and actual ip and port need to be added:
      {
        "uuid": "alap-1-0-0-http-c-nr-1-0-0-000",
        "ltp-direction": "core-model-1-4:TERMINATION_DIRECTION_SINK",
        "client-ltp": [
        ],
        "server-ltp": [
          "alap-1-0-0-tcp-c-nr-1-0-0-000"
        ],
        "layer-protocol": [
          {
            "local-id": "0",
            "layer-protocol-name": "http-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_HTTP_LAYER",
            "http-client-interface-1-0:http-client-interface-pac": {
              "http-client-interface-configuration": {
                "application-name": "NewRelease",
                "release-number": " >>> ReleaseNumber of the new release <<< "   <--- add correct value here
              }
            }
          }
        ]
      },
      {
        "uuid": "alap-1-0-0-tcp-c-nr-1-0-0-000",
        "ltp-direction": "core-model-1-4:TERMINATION_DIRECTION_SINK",
        "client-ltp": [
          "alap-1-0-0-http-c-nr-1-0-0-000"
        ],
        "server-ltp": [
        ],
        "layer-protocol": [
          {
            "local-id": "0",
            "layer-protocol-name": "tcp-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_TCP_LAYER",
            "tcp-client-interface-1-0:tcp-client-interface-pac": {
              "tcp-client-interface-configuration": {
                "remote-protocol": "tcp-client-interface-1-0:PROTOCOL_TYPE_HTTP",
                "remote-address": {
                  "ip-address": {
                    "ipv-4-address": " >>> IpAddress and Port (below) of the new release <<< "    <--- add correct value here
                  }
                },
                "remote-port": 7000    <--- add correct value here
              }
            }
          }
        ]
      },

fixed by #64


Slight code refactor in "Farmer" page

This PR:

Changes the title of the "Money Earned" and "Player Name" infoCards;
Changes the position of some infoCards.

(Read the commits' descriptions for details).

sure why not


remove deprecated field "facility"

facility is deprecated in Gelf specification.
Thus removed facility.

@n3xus I'm a bit reluctant to remove the facility from the GELF messages created by this library.
While the facility field has been deprecated, it's still being processed by Graylog (as of version 2.3.0):
https://github.com/Graylog2/graylog2-server/blob/2.3.0/graylog2-server/src/main/java/org/graylog2/inputs/codecs/GelfCodec.java#L171-L175
Removing it would suddenly change the messages created by this library and irritate people who use the facility field for filtering or in any other queries.

@n3xus As a soft migration path, it would probably make sense to use the custom _facility field instead of facility so that users can override the facility if they want to.


Add flake8 to requirements.txt in the backend.

Steps to follow:

create a feature branch
Follow backend setup instructions in the README
Add the latest version of flake8 to the requirements.txt file. At the time of writing the latest flake8 version is 7.0.0 so the requirements entry should be:

flake8==7.0.0

commit changes, push them up to your fork
create a Pull Request against the develop branch

@chikangatakudzwa is working on this issue

on it

Created a pull request

@ChikangaTakudzwa Thank you, I see it.


MockTransport proof of concept

This is how the TestTransport looks with mockall.
I have duplicated and converted one test to use the new transport (scroll up to see the original test) and kept the old TestTransport so that the project compiles.
Let me know if you think this is worthwhile before I start converting all of the tests @nlordell .

I converted a second test that has multiple calls. By default no order is enforced for mock calls. In this test I am using Sequence to enforce the order.
Do you mean assert_no_more_requests? That is implicitly enforced because the call to execute will panics if no expectation has been setup.

Do you mean assert_no_more_requests? That is implicitly enforced because the call to execute will panics if no expectation has been setup.

But what if you want to assert something was only called exactly once?

That is covered by .times(1) when setting up the expectation.


routing solver reseed

I read about reseeding when you are using random search strategy. But can you do it for other strategies or does that have no effect?

No effect.


Increase the timeout in DNS unit tests

Noticed some failures on this test, bumping the timeout from the default 2s to 5s see if it resolves the flakes.

LGTM


[embedded] Do not emit calls to swift_deallocPartialClassInstance in embedded Swift

See the attached testcase, the early throw-return in the initializer ends up causing a call to swift_deallocPartialClassInstance which we do not have in Embedded Swift. My understanding is (I would appreciate double checking this, thanks 😁) that the only difference between swift_deallocPartialClassInstance and swift_deallocClassInstance (which we do have in Embedded Swift) is that swift_deallocPartialClassInstance runs IVarDestroyers on the class hierarchy, and that IVarDestroyer is only non-null on classes when Objective-C interop is enabled. Because Embedded Swift explicitly disallows Objective-C interop, we don't need to run IVarDestroyers and can just call swift_deallocClassInstance directly.
rdar://125193196

@swift-ci please test

Apparently, this is not the right solution.


Add unstable CLI option for max ommers depth

Signed-off-by: Antoine Toulme<EMAIL_ADDRESS>

PR description
Add an unstable CLI parameter to specify the max ommers depth, with a default value of 8.
Fixed Issue(s)
Relates to issue #2572 and PR #2576
Changelog

[ ] I thought about the changelog and included a changelog update if required.

The MinigParameters constructor is too large and should probably move to a builder pattern.  In BesuCommand the construction should move to a method for readability, and in the tests all default options should not be set.  This will also improve readability so you know what false goes to which option.