Postfix spam / relay

I gave this image a test drive in the wild and I can see that it's accepting relaying to other domains. My theory, based on the postfix config file is that this is due to any emails that pass the spam filter because it is then local host that sends it from there and anything is accepted from localhost.
I think, in main.cf, the restrictions need to be modified to put permit_mynetworks below reject_unauth_destination for smtpd_recipient_restrictions and to be safe, probably also add smtpd_relay_restrictions with the same.
This should ensure that before trusting localhost to do anything, it must be a valid destination, ie the domain(s) Kolab is set up to use.
After making this change, I can see a lot of relay reject messages instead of sent (as expected) for domains that don't match my Kolab domain.
I do however now also see a lot of
connect to milter service: inet:localhost:8891:connection refused and am not sure if it is a result of this policy change and not sure how to confirm it without reverting postfix to a semi-open relay.
Here are my restrictions for reference, maybe you can validate?
main.cf
submission_sender_restrictions =
reject_non_fqdn_sender,
check_policy_service unix:private/submission_policy,
permit_sasl_authenticated,
reject
submission_recipient_restrictions =
check_policy_service unix:private/submission_policy,
permit_sasl_authenticated,
reject
submission_data_restrictions =
check_policy_service unix:private/submission_policy
smtpd_recipient_restrictions =
reject_unauth_destination,
reject_unauth_pipelining,
reject_rbl_client zen.spamhaus.org,
reject_non_fqdn_recipient,
reject_invalid_helo_hostname,
reject_unknown_recipient_domain,
check_policy_service unix:private/recipient_policy_incoming,
permit_mynetworks,
reject
smtpd_sender_restrictions =
permit_mynetworks,
check_policy_service unix:private/sender_policy_incoming
smtpd_relay_restrictions =
reject_unauth_destination,
permit_mynetworks,
permit_sasl_authenticated
(#)       defer_unauth_destination

Hi, thanks for issue,
I will fix this in the next v16 release.
I am currently work on it, please understand and wait some more.

I finally got to the bottom of my
milter service: inet:localhost:8891 issues which were specific to a change I made that was NOT related to this issue.


Compiler issues

Hey I am exploring the netlists and its not letting me run it with my solc compiler, 8.21. Its trying to tell me I need 5.7 but when I do it doesnt work. Have you seen this issue before?

this is what it is saying


Update pt-BR.coffee [subscribe]

Improved some translations but the main change was on the mixing translations for the word subscribe.
I believe the best translation for subscription would be assinatura instead of inscrição. The former is used in magazine and cable TV subscriptions contexts, for example. I found that both words were being used interchangeably and I decided to change everything to assinatura.

Coverage remained the same at 63.688% when pulling 1cd70f64f4072f7208203d75337e7a3602b81b86 on niander:patch-1 into 669502a3c0d94217e7212a31fb65f7827bbfda11 on codecombat:master.

Thanks!


enable DCO

A request should have been sent to the org to instal DCO integration.
An org admin needs to allow it.
cc @springcomp

I think this is completed.


Connection failure when running services/pods on separate nodes/subnets

Description:
The following error is shown in the browser when services referenced in HTTPRoute are targeting pods running on nodes that are not running the gateway
upstream connect error or disconnect/reset before headers. reset reason: connection failure

Repro steps:

Create a cluster with at least 2 nodes (observed on eks in this scenario)
Deploy the Gateway

# Note: the ReferenceGrant was created but excluded from example for the sake of brevity
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: northsouth-gateway
  namespace: envoy-gateway-system
spec:
  gatewayClassName: eg
  listeners:
  - allowedRoutes:
      namespaces:
        from: All
    hostname: api.example.com
    name: https-1de4e9455
    port: 443
    protocol: HTTPS
    tls:
      certificateRefs:
      - group: ""
        kind: Secret
        name: https-1de4e9455
        namespace: dashboard
      mode: Terminate

Deploy the HTTPRoute

apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: example-backend-route
  namespace: example
spec:
  hostnames:
  - api.example.com
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: northsouth-gateway
    namespace: envoy-gateway-system
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: example-backend
      namespace: example
      port: 8080
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /

Set the node affinity on the pod running the example-backend to the node that's not running the Gateway pod
Open api.example.com and observe the connection failure
Set the node affinity on the pod running the example-backend to the node that IS running the Gateway pod
Now it works

In short, this works
gateway on node-1
example-backend on node-1

and this does not
gateway on node-1
example-backend on node-2

Environment:
Running EnvoyGateway v0.5.0 on infrastructure was created with terraform which basically boils down to this:
data "aws_availability_zones" "available" {
  state = "available"
}

module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "5.1.2"

  name = "network-main"
  cidr = "<IP_ADDRESS>/16"
  azs  = slice(data.aws_availability_zones.available.names, 0, 3)

  private_subnets = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
  public_subnets  = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]

  enable_nat_gateway   = true
  single_nat_gateway   = true
  enable_dns_hostnames = true

  public_subnet_tags = {
    "kubernetes.io/role/elb" = 1
  }

  private_subnet_tags = {
    "kubernetes.io/role/internal-elb" = 1
  }
}

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "19.15.1"

  cluster_name    = "cluster-main"
  cluster_version = "1.26"

  vpc_id                         = module.vpc.vpc_id
  subnet_ids                     = flatten([module.vpc.public_subnets, module.vpc.private_subnets])
  cluster_endpoint_public_access = true

  eks_managed_node_group_defaults = {
    subnet_ids = module.vpc.private_subnets
  }

  eks_managed_node_groups = {
    default = {
      name           = "cluster-main-node-group"
      instance_types = ["t3.large"]
      min_size       = 2
      max_size       = 3
      desired_size   = 2
    }
  }
}

Note: the provisioned nodes are running in different subnets
Logs:
The logs don't reveal much; no errors, all routes are loaded, all listeners are loaded. The only error so far seems unrelated:
ERROR infrastructure runner/runner.go:70 failed to create new infra {"runner": "infrastructure", "error": "failed to create or update deployment envoy-gateway-system/envoy-envoy-gateway-system-northsouth-gateway-656e766f: for Update: Deployment.apps \"envoy-envoy-gateway-system-northsouth-gateway-656e766f\" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{\"app.kubernetes.io/component\":\"proxy\", \"app.kubernetes.io/managed-by\":\"envoy-gateway\", \"app.kubernetes.io/name\":\"envoy\"

Issue not related to envoy or the gateway api after all. Will add the resolution if I find one.

For eks user, please check your VPC firewall settings first.

For eks user, please check your VPC firewall settings first.

I tried allowing all traffic between the cluster and node security group to make sure it isn't some control-plane communication issue but still experiencing the issue. Anything else I could look for?

closing as this is not related to any issue within EG

If anyone comes across this issue, changing my service spec from
apiVersion: v1
kind: Service
metadata:
  name: example-backend
  namespace: example
spec:
  type: ClusterIP
  ports:
    - port: 8080
      targetPort: 80
      protocol: TCP
      name: http
  selector:
    ...

to
apiVersion: v1
kind: Service
metadata:
  name: example-backend
  namespace: example
spec:
  type: ClusterIP
  ports:
    - name: http
      protocol: TCP
      port: 8080
      targetPort: http
  selector:
    ...

resolved the issue. I'm not sure why this fixes it.
@arkodg Can you confirm it's still not related to envoy/gateway


[FEATURE] Controlled finalization for GPU-bound objects

Problem:
While most of the SkiaSharp objects can be safely disposed from any thread, GPU bound ones need the corresponding GPU context to be active on disposing thread. It's fine as long as the object lifetime is controlled by application, but Dispose might be called from the finalizer thread in following cases:

Main has exited
Environment.Exit(...) is called
Object was somehow leaked and collected by GC without being properly disposed

Libraries using SkiaSharp can deal with the third one by thoroughly controlling the object lifetimes, but unfortunately have no control over the application control flow. That leads to crashes such as https://github.com/AvaloniaUI/Avalonia/issues/4423
Proposed solution:
Instead of calling Dispose directly, call a user-specified callback that could properly enqueue the object for disposal on a proper thread or make the GPU context to be current. Such callback should be specified on object creation, e. g.
public static SKSurface Create (GRContext context, bool budgeted, SKImageInfo info, Action<Action> disposeCallback)
Finalizer should do something like this:
~SKSurface()
{
  if(_disposeCallback != null)
    _disposeCallback(() => Dispose(false));
  else
    Dispose(false);
}

We have a lot of crashes in Avalonia on mac when closing tooltips. This is the native stack trace (shortened). Can this be the same reason described above?
I did one PR in Avalonia where it fixes SKFont instance (Disposed on app exit so the workaround was to disable the finalizer. This can't be used everywhere.)
https://github.com/AvaloniaUI/Avalonia/pull/7887
@kekekeks
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000028
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [8893]

VM Regions Near 0x28:
-->
    __TEXT                      103869000-103879000    [   64K] r-x/r-x SM=COW  /Applications/Synergy Editor <IP_ADDRESS> Staging Beta Green.app/Contents/MacOS/Synergy.Editor.Avalonia.Mac

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libSkiaSharp.dylib            	0x000000010948d566 0x1091dd000 + 2819430
1   libSkiaSharp.dylib            	0x00000001094a99e5 0x1091dd000 + 2935269
2   libSkiaSharp.dylib            	0x00000001094bea4d 0x1091dd000 + 3021389
3   libSkiaSharp.dylib            	0x00000001094c01bb 0x1091dd000 + 3027387
4   libSkiaSharp.dylib            	0x000000010949c09e 0x1091dd000 + 2879646
5   libSkiaSharp.dylib            	0x000000010956eed7 0x1091dd000 + 3743447
6   libSkiaSharp.dylib            	0x000000010920f944 0x1091dd000 + 207172
7   libSkiaSharp.dylib            	0x000000010920f5b9 0x1091dd000 + 206265
8   libSkiaSharp.dylib            	0x000000010920f96e 0x1091dd000 + 207214
9   libSkiaSharp.dylib            	0x000000010957c0a1 0x1091dd000 + 3797153
10  ???                           	0x0000000110b831a3 0 +<PHONE_NUMBER>
11  ???                           	0x0000000110b6f0ec 0 +<PHONE_NUMBER>
12  ???                           	0x00000001116b4eee 0 +<PHONE_NUMBER>
13  ???                           	0x000000010fd764e2 0 +<PHONE_NUMBER>
14  ???                           	0x0000000110b96b69 0 +<PHONE_NUMBER>
15  ???                           	0x0000000111797048 0 +<PHONE_NUMBER>
16  ???                           	0x0000000111796ed7 0 +<PHONE_NUMBER>
17  ???                           	0x0000000111796b3a 0 +<PHONE_NUMBER>
18  ???                           	0x00000001117967cf 0 +<PHONE_NUMBER>
19  ???                           	0x00000001117964f5 0 +<PHONE_NUMBER>
20  ???                           	0x0000000111796389 0 +<PHONE_NUMBER>
21  ???                           	0x00000001117962ae 0 +<PHONE_NUMBER>
22  ???                           	0x000000010e9773d4 0 +<PHONE_NUMBER>
23  libAvaloniaNative.dylib       	0x000000010591a79b -[AvnWindow windowWillClose:] + 143
24  com.apple.CoreFoundation      	0x00007fff20788483 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
25  com.apple.CoreFoundation      	0x00007fff20823ef9 ___CFXRegistrationPost_block_invoke + 49
26  com.apple.CoreFoundation      	0x00007fff20823e74 _CFXRegistrationPost + 496
27  com.apple.CoreFoundation      	0x00007fff2075970e _CFXNotificationPost + 736
28  com.apple.Foundation          	0x00007fff214cbbc8 -[NSNotificationCenter postNotificationName:object:userInfo:] + 59
29  com.apple.AppKit              	0x00007fff2384e71b -[NSWindow _finishClosingWindow] + 124
30  com.apple.AppKit              	0x00007fff232ddc80 -[NSWindow _close] + 347
31  libAvaloniaNative.dylib       	0x00000001059123d4 WindowBaseImpl::Close() + 102
32  libAvaloniaNative.dylib       	0x000000010591245c virtual thunk to WindowBaseImpl::Close() + 16


The current npm version is not rename key side-effects to sideEffects

Hi,
In the current version of the npm package, the old version of package.json has a misspelling in the sideEffects key (old was named side-effects). This was fixed by the commit (here is link: https://github.com/ramda/ramda/commit/b0b1c1fdaa04fbd6ca494d952aa511339c90f0f6) but so far npm is delivering the version with an error. Because of this, tree shaking does not work with Webpack. Could you please rebuild the package?

We should be getting a new version out soon.  I don't know if there's any way to republish an existing version to NPM.

Property has been renamed and should be available in 0.28.0. Closing for now.


Enhancement: Full screen mode

Is it possible to configure roam42 to use Roam Research in full screen, or distraction free, mode?

Roam42 Issue Log Audit - unclear


When could the instruction finetuning code and data be released? #1

Gread Job, I would like to know if have any plan to provide instruction finetuning code and data.  If possible, can there be an expected time?

+1

+1

Excited about this work! hope to open-source.

When will data opensource?


MudTable: Align pager elements vertically

Description
CSS changes for MudTable that adjust pager element styling to improve vertical centering.
How Has This Been Tested?
Tested visually with existing test components.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:
After:
Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] (N/A) I've added relevant tests.

Edit: This still isn't quite right, seeing if I can improve.


Make sure rememberChoice is called

Added the call to rememberChoice functionality in subMitForm.js

currently it is not behind one as the function itself was already checking for the rememberChoice checkbox which is behind a feature check


Cannot install alignment-handbook==0.4.0

Dear authors,
Thank you so much for the dedicated efforts in reproducibility! I was trying to build the environment by using the provided environment.yml, but nevertheless met the following issue
ERROR: Ignored the following versions that require a different python version: 0.1.0 Requires-Python >=3.10.9; 0.2.0 Requires-Python >=3.10.9
ERROR: Could not find a version that satisfies the requirement alignment-handbook==0.4.0.dev0 (from versions: none)
ERROR: No matching distribution found for alignment-handbook==0.4.0.dev0

It seems to me that the latest version of alignment-handbook on pip is 0.2.0, which cause the above error message.
Would you mind letting me know how I may revolve this version issue in building the environment? Or otherwise which version of alignment-handbook (and possibly other packages as well) should I use?

Hi @Shentao-YANG
We recommend following the official installation instructions in alignment-handbook (i.e., build from source):
git clone https://github.com/huggingface/alignment-handbook.git
cd ./alignment-handbook/
python -m pip install .

which will install alignment-handbook==0.4.0.dev0.
Best,
Yu


BUG: BatchUpdatingIntents to enable all webhooks using updateMask

OS: Windows 10
Node: v10.16.3
Npm: v6.11.3
Dialogflow: v2
I am trying to batchUpdate all intents in order to enable the webhook for them.

Get a list of all intents: intentsClient.listIntents({parent: projectAgentPath});
For each intent set webhookState to 1 (enable)
Create request with updateMask: { paths: ['webhookState'] }

Removing the updateMask successfully updates the webhookState but also overrides all other fields (to zero) as expected. However, when applying the updateMask the webhookState does not get updated at all. Is this a bug or am I missing something?
If you require any extra information feel free to ask. I have added a code snippet below that shows how I use the library.
const foundIntents = getIntents(projectId);

let intents: any[] = [];

foundIntents.forEach((intent) => {
    intents.push({
        name: intent.name,
        displayName: intent.displayName,
        webhookState: 1,
    });
});

const request = {
    parent: projectAgentPath,
    intentBatchInline: {
        intents: intents,
    },
    updateMask: {
        paths: ['webhookState']
    },
};
await intentsClient.batchUpdateIntents(request)

@bcoe Is there any update on this? The updateMask still does not seem to work correctly (also tested using client.updateIntent(request);).
I am successfully able to update the intents using the rest API via the googleapis module, but would prefer to use this library to do so.

@nnegrey don't suppose you have any feedback, as you know this API better than me.
@TomHartogs reading the proto definitions, it looks like potentially your query should be:
    updateMask: {
        paths: "webhookState"
    },

I believe the FieldMask type expects a string path.

@bcoe When using the rest API the FieldMask property in the request body indeed expects a string. However, in this library an array is expected or else the following error is thrown: TypeError: .google.protobuf.FieldMask.paths: array expected.
Perhaps that's where things go wrong, during conversion of the FieldMask from this library to the underlying API.

@TomHartogs can you make TypeScript ignore that line, and see if things start working? If so it's a bug with our types which I can log with the upstream team :ok_hand:

Wouldn't the paths field be webhook_state because of underlying RPC rather than Node.js naming conventions?
I think I was able to get that to work, but I'm less of a Node.js expert.

@nnegrey you are correct, the mask indeed is supposed to be webhook_state. The documentation states updateMask: The mask to control which fields get updated, this led me to think I should pass in the symbolic path as described in the object passed in the function.
I wasn't aware of the naming convention for the RPC calls (relatively new to GCP), thanks for the clarification! Also thank you @bcoe, it does not seem to be a bug, nevertheless thank you for thinking along!


New package: funnyzak.TTSNow version 1.0.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


poquito.css is almost the same as layout.css

Add some font support or eliminate it?

Fixed in commit 1ef6beab8ee0e798deebf824b2c46da8afa2b56e


Add substitutor suggestion to nix flake

I'm not sure if we should add this. When using this flake, you will get a suggestion to add the resp binary cache.

What is the effect of accepting the suggestion? I guess the local nix will download from the cache that is filled by the github action?

Yes, if your user is authorized to do so. In a multi-user nix installation, you may not even have the right to do so, I'm getting this warning even after accepting:
$ nix run github:potsdam-pnp/pf2e-cards/nix-substitutor
warning: ignoring untrusted substituter 'https://potsdam-pnp.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.

Yeah just run into the same. I decided to sudoedit /etc/nix/nix.conf and add myself into the trusted users list. Then I had to jump through some hoops to restart the nix daemon, probably because I'm a noob and don't know how to "just restart" it :(
But now it seems to work.


Fix RecursionError for thunder.core.codeutils.to_printable (#747)

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes #747.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Thank you @kiya00 . Do you think it would be worthwhile to add a small test to make sure it does not get broken again?


fix: move reveal-centered into foundation-reveal mixin

Continuing the discussion in the right PR:

At least it makes not much sense to add it up there. The other code in my PR works too. Deduplication is done by libsass.
-- https://github.com/zurb/foundation-sites/pull/11086#issuecomment-375918639

Yes it makes sense, but it breaks reveal-modal-width. That's what I was explaining in https://github.com/zurb/foundation-sites/pull/11086#issuecomment-375917612. The placeholder is used in reveal-modal-width, and that mixin should be usable without having to call foundation-reveal first.
Again I don't understand: did you test it ? Does it generate code when importing Foundation without calling any mixin ? I did that for tests for a long and never seen that code being generated.

Does it generate code when importing Foundation

Sure, if you mean https://github.com/zurb/foundation-sites/blob/develop/dist/css/foundation.css#L8

The placeholder is used in reveal-modal-width

Then it should be only in reveal-modal-width I guess.

Does it generate code when importing Foundation without calling any mixin.
@import "foundation-sites';
// and that's all

Does it generate code when importing Foundation without calling any mixin.

The following does add the code at the top:
@import 'settings/settings';
@import 'foundation';
@import 'motion-ui';

@include foundation-everything($flex: false);

Without calling anything else it is not added.

But imo the current way how it works (added at the top) is not a very clean solution as it pollutes the statements at the top and changes the order of meaning (between normalize and the foundation-sites header) a bit.

Let's hear from @kball and @SassNinja what they think about the current code and my proposed solution.
So far imo the code should be at the right position to keep the context.

Does it make more sense to have this piece of code next to the Reveal code: Yes, obviously. Not because we would like to have the generated code more beautiful (we don't care, it will be minified anyway) but because CSS rules generated first are overriden by the next ones.
Can we make this being generated at the right place: As said previously, we can't without introducing a bug. As %reveal-centered is used in @mixin reveal-modal-width, moving it to @mixin foundation-reveal  prevent to use @mixin reveal-modal-width without @mixin foundation-reveal being called before. Because Foundation is also a Sass library, all mixins should being usable (and generate their own code) without the "main components mixins" @mixin foundation-* or @mixin foundation-everything.
The only solution is to move it to a dedicated mixin that must be called first but does not generate anything. That's an initialization step, and the current Foundation Sass architecture does not have it (only configuration, import and execution).
Is this code being generated at the wrong place a bug (or shoud it be resolved): It would if it introduced a specificity issue, or if code was generated at the import step (this is what I understood from https://github.com/zurb/foundation-sites/pull/11086#issuecomment-375918112). Actually it does not that. So it's not a bug, just not perfect and a bit ugly in the distribution files. So it's a much too minor issue to change the Sass architecture for it (but we can keep it in mind for v7).
What do you think ?

The only solution is to move it to a dedicated mixin that must be called first but does not generate anything.

That's what would have been my next question and step: Shouldn't we isolate this in a separate mixin?

That's what would have been my next question and step: Shouldn't we isolate this in a separate mixin?

Yes, something like @mixin foundation-init-reveal, but that mean we should expect the user to call it (like in foundation.scss or as shown it the Foundation Sass documentation) to be able to use reveal. So for now I'm for keeping that for later. That's only a minor issue without any bugs, let's not requiere migrations for that.

Yes, something like @mixin foundation-init-reveal, but that mean we should expect the user to call it (like in foundation.scss or as shown it the Foundation Sass documentation) to be able to use reveal. So for now I'm for keeping that for later. That's only a minor issue without any bugs, let's not requiere migrations for that.

Agreed.

See https://github.com/zurb/foundation-sites/pull/10101

I saw it already but we still need to wrap this in a mixin imho.

Agreed but https://github.com/zurb/foundation-sites/pull/11087#issuecomment-375921201


Stop duplicate session cookies on every request.

Ensure only a single Set-Cookie header is returned from Session once
we have data to save. Include backwards compatibility for PHP56
Headers were being sent twice, once by session_start() and once by Cookie::set()
The second header was unneeded, and meant Set-Cookie was appended to every request which
breaks WAF behaviour for sticky sessions
@see #8543

@madmatt  @dnsl48  I've created this one from 4 so it merges better, but replaced the php56 code, so it should be backwards compatible.
https://github.com/silverstripe/silverstripe-framework/pull/8544 for reference

@caffeineinc would you like to make the linter happy? :)

haha yeah sure. @dnsl48  There ya go 📦

@dnsl48 Please rebase from 4 to 4.3 yourself, to get this over the line. My assumption is that you can push to Simon's PR, otherwise just do it locally


fix(versions): update Activiti/activiti-cloud-application-chart versions

UpdateBot pushed helm dependency: activiti-cloud-notifications-graphql to: 7.1.14

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-notifications-graphql 7.1.14


[GUI] adjust template details

eliminate unnecessary areas:

Affected version: 0.3.0-unfiltered-nightly20180529


Add ServiceNow plugin to handle the password grant type token

So that consumers can still use their tokens to the light-gateway.

it is done already.


fix(VietualiedContext.js): add console

:tada: This PR is included in version 5.10.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Missing Properties of MultiplePickerField

Refers to -> https://discord.com/channels/1277612890668404798/1277612891008401459/1291006019463286835
Properties considered to add:
ItemDisplayBinding, SelectedIndex, and SelectedIndexes

I think it would also be useful to have ItemValueBinding and SelectedValue(s) properties.
I think in most of the cases we need the value of the selected item, not index


Problem of high ping value when connecting TCP clien (IDFGH-10191)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Official Code: D:\Espressif\frameworks\esp-idf-v5.0.2\examples\protocols\sockets\tcp_client
Device: ESP32C3
Router: ASUS router, only 1 meter away from ESP32C3
Demand:
The ping value is very high.Delay exceeded 300ms. How to optimize it to reduce the ping value? For example, reach within 100ms or 50ms.

@krxiaoyu You can check the IDF documentation on performance optimization and WiFi buffer usage, and WIFI_PS_NONE

https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/lwip.html#performance-optimization
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html#wifi-buffer-usage
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html#esp32-wi-fi-power-saving-mode

Hi @krxiaoyu
We will close this issue since so long no response.
Please feel free to reopen if still have this issue.
Thanks.


Add initial support for built-in methods with generatorified callbacks

This is an initial proof of concept for codecombat/codecombat#2874.
This PR, together with codecombat/codecombat#3433 adds support for built-in methods that accept generator functions as callbacks. As this is an early proof of concept, I've only added the [].forEach and [].map methods, in a pretty hackish way.
Please refer to codecombat/codecombat#xxx for details.
Here are a few things I already know that are missing:

[ ] "Yield automatically" mode
[ ] Tests

This is an early proof of concept, so please take a look and see if it is even worth considering to work on.

Great PR; going to do it via Esper/interpreter instead, though.


Failing to import FBX exported from Marvelous Designer

Issue description
Trying to import a test file exported from Marvelous designer fails with the following error stack:
modules\fbx\fbx_document.cpp:1381 - Condition "out_roots.size() == 0" is true. Returning: FAILED
modules\fbx\fbx_document.cpp:1459 - Condition "_verify_skin(p_state, skin)" is true. Returning: ERR_PARSE_ERROR
modules\fbx\fbx_document.cpp:3119 - Condition "err != OK" is true. Returning: ERR_PARSE_ERROR
modules\fbx\fbx_document.cpp:2973 - Condition "err != OK" is true. Returning: err
modules\fbx\fbx_document.cpp:3170 - Condition "err != OK" is true. Returning: err

The issue has something to do with skinning code, which is taken pretty straight from the glTF importer. There is something extremely cursed about skinned Marvelous files, as it connects skin clusters to root. However ufbx already has an internal quirk mode to fix it, but it's possibly related to the issue.
Steps to reproduce

Download https://ufbx-dataset.b-cdn.net/local/hana/hana.fbx (CC0)
Try to import the file
Note that it fails with the error mentioned

Minimal reproduction project (For SDK or engine issues)
No response
Using a released version?
cd3932a
What OS? Any other relevant information? (godot-ufbx revision, Godot revision, System information)
Windows, Godot 4.2 master

How does the internal quirks model to fix Hana work?

The quirks mode is enabled by default and should stop it from parenting the skin clusters to the root, so that shouldn't be an issue.
However there is likely some other things that are off with the model which causes issued on the Godot importer side. I'll check if I can find something broken in tje loaded ufbx scene tomorrow.

Loads now as of 572fba3, but looks like UVs may be wrong?

Turns out it was using UDIM textures and even then the UVs were incorrect for parts of the mesh, so the importer is working as intended (without UDIM support that is).


tailscale: 1.76.3 -> 1.76.6

Things done

https://tailscale.com/changelog#2024-11-06
Diff: https://github.com/tailscale/tailscale/compare/v1.76.3...v1.76.6
Change log: https://github.com/tailscale/tailscale/releases/tag/v1.76.6

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 354112

aarch64-darwin

:white_check_mark: 4 packages built:

tailscale
tailscale-gitops-pusher
tailscale-nginx-auth
tailscale.derper

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 354112

x86_64-linux

:white_check_mark: 5 packages built:

tailscale
tailscale-gitops-pusher
tailscale-nginx-auth
tailscale.derper
trayscale


pull request for e2e test at 12/19/2016 05:15:18

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Perform review on website migration and create issues of missing content

We need to perform a review on the website migration page by page to ensure no content is missed.
The sites to compare are:

https://www.calconnect.org
https://calconnect.github.io

Done.


Does node mysql allows updating multiple rows through one query

I have to update multiple rows and I want to do it with one single query. I was able to insert multiple rows but I'm not able to update multiple rows, below is the code snippet
var update_tasks="UPDATE tasks SET phy_1_id=? , phy_2_id=? where id=?";
                  db.query(update_tasks,[[-1,-1,10086],[-1,-1,10087]],function (er, results, fields){
                      if (er) {console.log("Error "+JSON.stringify(er));return res.status(500).send(er);}
                      else{
                        return res.status(200).json(results);
                      }
                  })

Can you tell what should I do.

This module should work find with any MySQL query. Is the above the query you are having an issue with? Are you getting an error running it, or something else?

Yes I'm using above query to update multiple rows, I'm getting below error
Error {"code":"ER_PARSE_ERROR","errno":1064,"sqlState":"42000","index":0}
Seems to be some parsing error but not sure whats wrong.

I'm not sure what you're trying to do in the values array--you're only supplying two values even though you have three question marks, and the values for the first two don't really make sense.

Yes I have three ? and I'm passing three values one for phy_1_id , other one for phy_2_id and the last one for id column of the row , that is the id of the where clause
[[-1,-1,10086],[-1,-1,10087]]

That's just two values. Check this out:
var values = [[-1,-1,10086],[-1,-1,10087]]
console.log(values.length)

That shows 2

Yes length of the array is two, because I'm trying to update two rows.

From the mysql package docs for updating a single row
connection.query('UPDATE users SET foo = ?, bar = ?, baz = ? WHERE id = ?', ['a', 'b', 'c', userId], function (error, results, fields) {
  if (error) throw error;
  // ...
});

But I'm trying to update multiple rows that's why I'm passing arrays of arrays
[[-1,-1,10086],[-1,-1,10087]]

Gotcha. That's not possible to do. You're welcome to make a PR if you want to add that feature.

The way it works is each question mark (?) is replaced with each element in the array, so the README example
connection.query('UPDATE users SET foo = ?, bar = ?, baz = ? WHERE id = ?', ['a', 'b', 'c', userId])

Is identical to the following:
connection.query('UPDATE users SET foo = ' + connection.escape('a') + ', bar = ' + connection.escape('b') + ', baz = ' + connection.escape('c') + ' WHERE id = ' + connection.escape(userId))

In your code above, you are doing
connection.query('UPDATE tasks SET phy_1_id=? , phy_2_id=? where id=?',[[-1,-1,10086],[-1,-1,10087]])

Which results in the following:
connection.query('UPDATE tasks SET phy_1_id=' + connection.escape([-1,-1,10086]) + ' , phy_2_id=' + connection.escape([-1,-1,10087]) + ' where id=?')

Which is not valid SQL

So I have to fire multiple update queries for updating multiple rows. Will this be good, considering performance. Or is there something else I can use to achieve this

We support any SQL query that MySQL supports. What is the raw SQL query you are trying to send?

@eMahtab from performance point of view (especially if you have large number of rows to insert) probably best way to use LOAD DATA INFILE - see example here https://github.com/mysqljs/mysql/blob/eeca1326c5f4d67725a486ddf1ef12c3f12d2187/test/integration/connection/test-load-data-infile.js

I have a requirement in my application to update multiple rows in the table, thats it.
update tasks
set phy_1_id=342,phy_2_id=762
where task_id=878
update tasks
set phy_1_id=234,phy_2_id=763
where task_id=879
update tasks
set phy_1_id=235,phy_2_id=764
where task_id=880
.....
Basically I'm assigning records to multiple physicians and trying to update the rows in the tasks table.

I was able to insert multiple rows
var query = "INSERT INTO phase_physician(phase_name,physician_id,physician_name,physician_email,role) VALUES ?";
         var phase_physicians=[];
         body.selectedPhysicians.forEach(function(item){
                var phy=[];
                phy[0]=body.phase;
                phy[1]=item.id;
                phy[2]=item.name;
                phy[3]=item.email;
                phy[4]=item.role;
                phase_physicians.push(phy);
         });

         db.query(query,[phase_physicians], function(er,data) {
             if (er) return res.status(500).send(er);
             return res.status(200).json(data);
         });

and I thought I can update multiple rows also like that. I am able to update single row but I'm looking to update multiple rows.

I don't believe MySQL has a syntax for bulk row updates in general, so I suppose MySQL would need to add syntax for that and then you could use it.

The closest you're going to get is either what @sidorares suggested or REPLACE INTO, though they're not exactly the same as UPDATE.


Strange vertical knockback with some weapons

Current/Expected Behavior
In the 1.8.8 (server version) + CrackShot, the vertical knockback of the weapons is totally different than in the 1.20.2 + WeaponsMechanics (or CrackShot) and, in general, in the modern version + WeaponsMechanics (or CrackShot).
The vertical KB in 1.8.8 with old weapons is always applied and not only when I am below the height of the target.
To explain the problem better, I show you these 2 recordings:

1.8.8 with CrackShot: https://www.youtube.com/watch?v=cCBddfwBlsE
1.20.2 with WeaponsMechanics (CrackShot has the same problem): https://www.youtube.com/watch?v=bo_MiChaf2s
1.16.5 with CrackShot (same problem): https://www.youtube.com/watch?v=EJGG_QtqgQE
I hope this problem can be resolved, because I haven't found a way to fix it yet.
The config I used:
Test.txt

Steps To Reproduce

Use the config that I provided.
Start the server with newer version.
Than you see the same KB in the video 2.

Log File
No required
Anything else?
No response

Sorry for my miscommunication, I didn't mean that, I already know that.
What causes problems is the knockback itself, I would like it to be like the one in the video with CrackShot on a 1.8.8 server and not like the one in the other 2 videos (which is strange), I don't know if it's feasible or fixable in any way.

If you want to replicate the vanilla knockback system, you can enable it in the config.yml.
Marking this as solved, as it is not a bug. Use discord for support.


Sensor limits.

It appears to me from reading the code that this if statement is the wrong way around.
The Qualifier limit is applied when not submitting to the qualifier.
if agent_track in (Track.SENSORS_QUALIFIER, Track.MAP_QUALIFIER):
        sensor_limits = SENSORS_LIMITS
else:
        sensor_limits = QUALIFIER_SENSORS_LIMITS

See here.

Got same error, the 2 limits maybe inverted in leaderboard/leaderboard/autoagents/agent_wrapper.py:
QUALIFIER_SENSORS_LIMITS = {
    'sensor.camera.rgb': 4,
    'sensor.lidar.ray_cast': 1,
    'sensor.other.radar': 2,
    'sensor.other.gnss': 1,
    'sensor.other.imu': 1,
    'sensor.opendrive_map': 1,
    'sensor.speedometer': 1
}
SENSORS_LIMITS = {
    'sensor.camera.rgb': 8,
    'sensor.lidar.ray_cast': 2,
    'sensor.other.radar': 4,
    'sensor.other.gnss': 1,
    'sensor.other.imu': 1,
    'sensor.opendrive_map': 1,
    'sensor.speedometer': 1
}

Hello, yes, that is correct! Will fix it ASAP. Sorry about that


Blank index page on macOS Big Sur

Hi,
I've been getting a blank index page from the sample projects as shown in the picture below.

I've checked that the index.html file does exist and that the program can see it. I've also tried using a link to a website to see if that would load instead.
I assume this could be an issue only on my machine but I can't seem to pinpoint what could cause this issue. Especially when I'm not getting any errors except one about the Touchbar: 2021-03-27 14:00:18.592 dotnet[43611:2198090] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x7fe9d97180f0>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
Any help would be appreciated.

Hi @CiaronHowell, did u found the solution for this issue?

Hi @sanme98, it was for my dissertation for University so it was a while ago but I think there was an issue with my HTML so it wouldn't load the page


Allow kustomize image override in Kustomization CRD

In a case where the person with control over the syncing(kustomization CRD) does not have control over the config repository where the kustomization.yml reside and they can only refer to it. It would be great want to allow making changes(overriding the images) in the Kustomization CRD
Link to discussion:
(https://github.com/fluxcd/flux2/discussions/135)[https://github.com/fluxcd/flux2/discussions/135]
In particular this comment

In the first, the person with control over the syncing does not have control over the config repository -- they can only refer to it. So they must resort to putting changes into the sync.

Here is an example that could be used in e2e testing.
Having a public repo and a kustomization for podinfo:
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: GitRepository
metadata:
  name: podinfo
  namespace: default
spec:
  interval: 5m
  url: https://github.com/stefanprodan/podinfo
  ref:
    branch: master
---
apiVersion: kustomize.toolkit.fluxcd.io/v1beta1
kind: Kustomization
metadata:
  name: podinfo
  namespace: default
spec:
  interval: 5m
  path: "./kustomize"
  prune: true
  sourceRef:
    kind: GitRepository
    name: podinfo
  validation: client

I want to change the podinfo image tag without modifying podinfo repo, to do that I can override the image with:
apiVersion: kustomize.toolkit.fluxcd.io/v1beta1
kind: Kustomization
metadata:
  name: podinfo
  namespace: default
spec:
  interval: 5m
  path: "./kustomize"
  prune: true
  sourceRef:
    kind: GitRepository
    name: podinfo
  validation: client
  images:
    - name: ghcr.io/stefanprodan/podinfo
      newName: ghcr.io/stefanprodan/podinfo
      newTag: 5.0.0

Implementation tasks:

[ ] add the Image struct and spec.images to Kustomization API (docs+api pkg)
[ ] implement the images override in the controller reconciliation
[ ] add e2e tests for the images


Lifetime labels aren't tokenized properly

I don't know if this is fixable, but lifetime labels like 'static appear to end up in an element category that isn't targeted by syntax themes.
Below the information Atom gives me on such elements (not sure if that helps):
Inherited from span.storage.modifier.lifetime.rust
atom-text-editor::shadow .storage.modifier.lifetime.rust, atom-text-editor::shadow .entity.name.lifetime.rust {
    color: #48fafd;
}

In case I wasn't clear enough, the following screenshot shows the mis-colored element:

I get cyan lifetimes regardless of the syntax theme used, and suspect it to be some fallback or ui-theme defined color. If lifetimes took on a color of the core theme palette, that would be nice. If other users do not experience this problem, then please speak up.

Lifetimes are recognized into scope storage.modifier.lifetime.rust (whole lifetime including apostrophe) and entity.name.lifetime.rust (only the lifetime's name). This allows syntax themes or your custom css to apply color specifically to lifetime labels. However, I don't know of any syntax theme that does so, so in most cases it will fall back to the more generic storage modifier or entity name color of the syntax scheme. There doesn't seem to be wrong tokenization from the grammar side here.

I looked into this again, since no theme implements it and found myself unable to override Atom's styling. It looks like there's a persistent definition that takes precedence over anything themes bring in, probably because the selector is more elaborate:

My attempted override is the yellow color style. I think this conflict is what causes every theme to fail applying its own style. Could you give your opinion on this? Is it something that would need to be fixed in the Atom editor repo?

Ok, someone pointed me to the reason. You're overriding lifetimes with your own stylesheet in the language package. This creates cyan lifetimes for every theme. Would have been helpful if you had mentioned that in your response. I think you should dial down the default mix from 70% to something betwenn 20% to 10%, since cyan doesn't mesh well with most themes.

Darn, I almost forget about that by myself! Yes, actually, I thought this would be a short-living workaround since there shouldn't be any styles in this package at all. We should find a more suitable permanent solution for this.

p.s. Mixing with a color other than @syntax-text-color might be another option. Most themes define it as a low-saturation color which – mixed with cyan – results in saturated cyan. But yeah, try ~20% or and see how  you like it; I think it's an acceptable quick fix.


add missing cmd/secrets-store-csi-driver-operator/main.go

Whoops, the last line in .gitignore left this dir out
/cc @gnufied

/lgtm
/approve


This walkthrough is incorrect for VS2019 Community edition

The first problem is stdafx.h doesn't even exist.... then the second step fails if you don't have #include <memory> in ChildView.h. Working my way through from there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd3722ed-f2a1-cd80-5e25-453b349505d4
Version Independent ID: 917820fe-456e-3bb9-98ed-188ced32eafb
Content: Walkthrough: Removing Work from a User-Interface Thread
Content Source: docs/parallel/concrt/walkthrough-removing-work-from-a-user-interface-thread.md
Product: visual-cpp
Technology: cpp-parallel
GitHub Login: @mikeblome
Microsoft Alias: mblome

@MartyMacGyver thanks for the feedback. The new default name for the precompiled header file is "pch.h".  I noticed we still use "stdafx.h" in several other places in the documentation so I'll fix those as well. The updated topic should be visible by Aug 20. Feel free to reopen if you find other issues in this topic.


Incompatible NumPy version

I am having trouble with getting SanntiS to run properly while following the install instructions in the README.
I have downloaded InterProScan and set it up following their directions on the ReadTheDocs. I ensured that the IPS directory was added to my path. The IPS steps run just fine.
When I run any command with SanntiS (e.g. sanntis --help), I get the expected usage information output but I also see this:
/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/tensorflow/python/keras/engine/data_adapter.py:61: UserWarning: A NumPy version >=1.22.4 and <2.3.0 is required for this version of SciPy (detected version 1.19.5)   from scipy import sparse as scipy_sparse  # pylint: disable=g-import-not-at-top
When I do end up running the SanntiS pipeline I use the command:
sanntis --meta False --outdir sanntis --cpu 15 wt_polished.fasta
It looks to run okay but then I see this Python error:
Traceback (most recent call last):
  File "/opt/miniconda3/envs/sanntis/bin/sanntis", line 10, in <module>
    sys.exit(main())
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/sanntis/_cli.py", line 166, in main
    annotate = AnnotationFilesToEmerald()
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/sanntis/modules/BGCdetection.py", line 49, in __init__
    self.vocab, self.typeModel, self.mbdoms = pickle.load(h)
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/sklearn/__init__.py", line 82, in <module>
    from .base import clone
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/sklearn/base.py", line 17, in <module>
    from .utils import _IS_32BIT
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/sklearn/utils/__init__.py", line 20, in <module>
    from scipy.sparse import issparse
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/sparse/__init__.py", line 294, in <module>
    from ._base import *
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/sparse/_base.py", line 5, in <module>
    from scipy._lib._util import VisibleDeprecationWarning
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/_lib/_util.py", line 18, in <module>
    from scipy._lib._array_api import array_namespace
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/_lib/_array_api.py", line 17, in <module>
    from scipy._lib.array_api_compat import (
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/_lib/array_api_compat/numpy/__init__.py", line 16, in <module>
    __import__(__package__ + '.linalg')
  File "/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/scipy/_lib/array_api_compat/numpy/linalg.py", line 2, in <module>
    from numpy.linalg import __all__ as linalg_all
ImportError: cannot import name '__all__' from 'numpy.linalg' (/opt/miniconda3/envs/sanntis/lib/python3.9/site-packages/numpy/linalg/__init__.py)

Can you give me some suggestions on what I can do to solve this?

Hi Sean,
Thank you for bringing this issue to my attention.
I could replicate the problem.
It seems that the problem is related to a version mismatch between scipy and numpy. The error you're encountering can be resolved by updating scipy to version 1.7.3, which is compatible with the other SanntiS dependencies.
To fix this, you can run the following command:
conda install scipy=1.7.3

This should resolve the error and allow SanntiS to run.
I'm currently working on making this fix propagate to the Bioconda installation to prevent this issue from happening in the future. In the meantime, the above command should do the trick.
Please let me know if you have any further issues or need more details, and thanks again for your patience!

Hi Santiago,
Thanks for checking on this. I thought to try changing my NumPy version to something >1.22 and the conda solver failed - I didn't think to try changing the SciPy version. I will do this now!
No need to thank me for patience, this is FOSS, you don't owe me anything! :)

Hi Sean,
Changes are now reflected in bioconda.
Thanks!


Osc sourcetype patch

When you try to create an OSC source type, it will throw an error because it think that the information field needs to be filled.

Looks good. Is the try catch revert just something else you are working on?

Yes. It was until I realized that it was an issue on my end with a config file. After deleting my config and trying again it stopped happening.

@josephdadams are you ok if I go ahead and deploy this?

Sure


[Bug]: Regex with global flag failed on subsequent usage

Version
29.0.3
Steps to reproduce
When testing a RegExp with the g flag, subsequent usage of the regexp fails, though it expected to succeed.
it("re-using regex with 'g' flag should succeed", () => {
  const regex = new RegExp("[f](\\d+)", "g");
  expect(regex.exec("f123")).not.toBeNull(); //< succeeded
  expect(regex.exec("f123")).not.toBeNull(); //< failed
});

Link to repl
https://replit.com/@muravjev/JestRegexGlobalFlagIssue
Expected behavior
Tests should pass
Actual behavior
Test fails with subsequent usage of the same global regexp
  ● re-using regex with 'g' flag should succeed

    expect(received).not.toBeNull()

    Received: null

      13 |   const regex = new RegExp("[f](\\d+)", "g");
      14 |   expect(regex.exec("f123")).not.toBeNull(); //< succeeded
    > 15 |   expect(regex.exec("f123")).not.toBeNull(); //< failed
         |                                  ^
      16 | });

Workaround
Create new RegExp on every check:
it("re-using regex with 'g' flag workaround", () => {
  const regex = "[f](\\d+)";
  expect(new RegExp(regex, "g").exec("f123")).not.toBeNull(); //< succeeded
  expect(new RegExp(regex, "g").exec("f456")).not.toBeNull(); //< succeeded
});

Environment
System:
    OS: Windows 10 10.0.17763
    CPU: (8) x64 Intel(R) Core(TM) i7-3632QM CPU @ 2.20GHz
  Binaries:
    Node: 18.5.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.12.1 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^29.2.1 => 29.2.1

Sorry, It looks like it is correct behavior, if we remove global flag, tests will be passed.


npm test failing for jasmine test cases

Environment

Server - Azure Pipelines?

Issue Description
I am using jasmine test cases for the node application, when I am running "npm test" from the azure pipeline(using npm custom task), getting sh: 1: jasmine: Permission denied
Error logs
2018-11-28T00:09:38.3034992Z ##[section]Starting: npm custom
2018-11-28T00:09:38.3038797Z ==============================================================================
2018-11-28T00:09:38.3038902Z Task         : npm
2018-11-28T00:09:38.3038939Z Description  : Install and publish npm packages, or run an npm command. Supports npmjs.com and authenticated registries like Package Management.
2018-11-28T00:09:38.3038976Z Version      : 1.0.30
2018-11-28T00:09:38.3039054Z Author       : Microsoft Corporation
2018-11-28T00:09:38.3039092Z Help         : More Information
2018-11-28T00:09:38.3039128Z ==============================================================================
2018-11-28T00:09:38.5705828Z SYSTEMVSSCONNECTION exists true
2018-11-28T00:09:38.6903312Z SYSTEMVSSCONNECTION exists true
2018-11-28T00:09:38.9021607Z [command]/usr/local/bin/npm --version
2018-11-28T00:09:39.0743303Z 6.4.1
2018-11-28T00:09:40.7989668Z sh: 1: jasmine: Permission denied
2018-11-28T00:09:40.7989780Z npm ERR! Test failed.  See above for more details.
2018-11-28T00:09:40.7994612Z [command]/usr/local/bin/npm config list
2018-11-28T00:09:40.7994679Z ; cli configs
2018-11-28T00:09:40.7994880Z metrics-registry = "https://registry.npmjs.org/"
2018-11-28T00:09:40.7994913Z scope = ""
2018-11-28T00:09:40.7995089Z user-agent = "npm/6.4.1 node/v8.12.0 linux x64"
2018-11-28T00:09:40.7995112Z
2018-11-28T00:09:40.7995159Z ; environment configs
2018-11-28T00:09:40.7995322Z cache = "/home/vsts/work\_temp\npm-cache"
2018-11-28T00:09:40.7995355Z userconfig = "/home/vsts/work/1/npm/44.npmrc"
2018-11-28T00:09:40.7995375Z
2018-11-28T00:09:40.7995666Z ; node bin location = /usr/local/bin/node
2018-11-28T00:09:40.7995698Z ; cwd = /home/vsts/work/1/s
2018-11-28T00:09:40.7995728Z ; HOME = /home/vsts
2018-11-28T00:09:40.7995938Z ; "npm config ls -l" to show all defaults.
2018-11-28T00:09:40.7995961Z
2018-11-28T00:09:40.7996092Z [command]/usr/local/bin/npm test
2018-11-28T00:09:40.7996131Z
2018-11-28T00:09:40.7996316Z ><EMAIL_ADDRESS>test /home/vsts/work/1/s
2018-11-28T00:09:40.7996359Z > jasmine
2018-11-28T00:09:40.7996378Z
2018-11-28T00:09:42.0684811Z ##[warning]Couldn't find a debug log in the cache or working directory
2018-11-28T00:09:42.0695725Z ##[error]Error: Npm failed with return code: 1
2018-11-28T00:09:42.0710967Z ##[section]Finishing: npm custom

looks specific to jasmine tests

@montyshashi Can you please attach your complete build logs from a run with system.debug set to true in build variables.

Closing the thread. Please reopen if you are still facing issues here.

Is this issue resolved?


Small changes on readme

Small changes on readme

thanks

That 2nd change needs reverting

Which one?

sane -> same was incorrect
On Sat, 17 Nov 2018, 18:47 Asmir Mustafic<EMAIL_ADDRESS>wrote:

Which one?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/php-serializers/ivory-serializer-benchmark/pull/12#issuecomment-439638895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmK8Na0b8Z_rTqHKKM-tkkotLbXxv9yks5uwFnHgaJpZM4Ynfy4
.

I've got confused on that sentence:
with sane defaults setup for benchmarking the serializers
What did you mean with this?

It means the benchmark config is reasonable or sensible. specifically, warmup, 5 revs + 5 iterations.

@bendavies fixed in https://github.com/php-serializers/ivory-serializer-benchmark/commit/42d021315f685bb8dfb54cc32d5d0c5615fbb9f6

👌👌👌
On Sat, 17 Nov 2018, 23:01 Asmir Mustafic<EMAIL_ADDRESS>wrote:

@bendavies https://github.com/bendavies fixed in 42d0213
https://github.com/php-serializers/ivory-serializer-benchmark/commit/42d021315f685bb8dfb54cc32d5d0c5615fbb9f6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/php-serializers/ivory-serializer-benchmark/pull/12#issuecomment-439653945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmK8PE1Fa_l3LNr7ZqYo1Ypg_R0Bd_Uks5uwJVLgaJpZM4Ynfy4
.

Understood. Apologies for my mistake.


Add support for functions in sub directories of server/functions

Description
Adds support for functions that exist in folders under server/functions/, like "server/functions/users/user.ts"
Linked Issues
#15
Additional context

This was by design, so you could have some folders to hide internal logics. We could have an option deep or scanDeep to support nested scanning for opt-in

Makes sense, I like the option.
Also, check out github.com/gsxdsm/nuxt-rpc - I tried to combine the best of nuxt-server-fn and nuxt-remotefn and added support for formdata and files.


prepare crate for no_std

This change is

@elintul wdyt?

@elintul I think @abdelhamidbakhta forwarded you some of my answers on telegram. Is there still questions about this PR?

If you have a hard commitment to using thiserror, you can use thiserror-no-std instead. It's just not my preferred way.
As I said to abdel, there is "nothing fundamentally wrong" with this crate, I an simply less confident about it's implem and the way it is maintained

About this specific PR, it does not introduce no_std, but it improves your code in several ways, using constant rather than lazy static, using a perfect hash map rather than a hash map, and making the users able to import the papyrus implem only if they actually need it.
I think it should be merged regardless of the no_std support.

@elintul
Yeah it has been done on the fork we are using, otherwise, we wouldn't have been able to run blockifier in a no_std environment, but that is not the point with this PR.
My point here, is that PR add some straight up upgrade to your code. Making it usable outside of papyrus without having to import papyrus stuff (which is the case of everybody except people working on papyrys), replacing some statics by constants (which is better) and using a perfect hash function instead of a regular hashmap when possible (which is better).
So I thought you would like to have those stuff in your codebase, because it makes it better and more usable, regardless of any no_std concern.

Hey @spapinistarkware,
I just forced push a rebase.
I got rid of the const+unsafe part. I replaced it with functions instead. It is a downgrade, but if as you said, it's only used for tests, we don't really care.
The is still one place where you are using OnceCell, in os_ressources. Once cell is not compatible with no_std. So if you think you will try to support it at any point in the future, prefers either constants or the lazy_static crate, which is.
Tell me if there is other things that need to change :)

Suggestion: Instead of having a static value, add it as a ctor on OsResources type. Make get_additional_os_resources (the only place that uses it outside tests) a method of OsResources. Every user of get_additional_os_resources will now need an instance of OsResources - make sure to create it as further up as possible, preferably, creating it only once at the top

Reviewed 1 of 10 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @elintul and @tdelabro)

Why can't I just do this?
#[ctor]
pub static OS_RESOURCES: OsResources = {
    serde_json::from_value(os_resources())
        .expect("os_resources json does not exist or cannot be deserialized.")
};

It seems to work, and avoid the very likely footgun where users of the lib instantiate multiple OsResources for their program, therefore having multiple instances of the hashmap. Unless there is a use-case of having multiple instances of OsResources with different definitions?
That's what I did in the last commit. Tell me if it need a change

That looks good. Didn't know about it.
Eventually we will want it outside, I believe. There might be a use for another instance for all the I know, but it's out of scope for this PR.


Restore open cmd window / performance issue

Hi,
Since 0.34.0 there is an issue on project build restore open up a cmd window and the restore operation is much more slower than before (0.33.2, had an issue with intellisense with 0.33.3)
The test was made in a solution with 25 projects and auto-restore off, but a restore operation cmd is open for each project. Each cmd is also taking focus everytime it pop.
I guess it would be safer to go :
startInfo.WindowStyle = ProcessWindowStyle.Hidden;
startInfo.CreateNoWindow = true;

And only one paket restore for the whole thing?
Thomas

yes. please send PR. I would release asap

+1

ok 0.35 should at least not open cmd window. please contribute improvements

And only one paket restore for the whole thing?

that's still open

I have done a fix that is doing a restore for all projects --references-file instead of multiple restore for each project on one --references-file.
Works way more faster on my solutions.
And sorry I'm bit of a newb with git :(

And only one paket restore for the whole thing?

Is this another issue?
@SuperRoflCopter does this need many changes?
If only one file needs to be changed, it could be done from the GUI, e.g

If you need more changes, then make a fork and make the changes there. From the fork we could merge the code to here (with a Pull Request)

Thanks, I did the pull request from a fork.
And forki did the release. (0.36)
Seems to works fine for the devs in my company.


[Feature] Add nodes affinity / Toleration to KFP/Ray nodes

Search before asking

[X] I searched the issues and found no similar issues.

Component
KFP workflows, Library/kfp
Feature
Some Kubernetes deployments require that KFP and Ray Pods deploy on a certain set of nodes.
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

This is supported by the API server through compute template definition https://github.com/ray-project/kuberay/blob/master/proto/config.proto#L130

I know, but in order to use it we have to update our KFP library and pipelines.
On the other hand, KFP supports affinity for its Pods, but again we have to update the pipelines.

I was making sure API server supports it

Done with https://github.com/IBM/data-prep-kit/pull/627, https://github.com/IBM/data-prep-kit/pull/643 and #648


11.0.0-alpha1 is available for testing.

What is alpha1?
This release is:

main @ 3470e22f9eb8d5a4067b512e781ef9c6b6d46e3a
https://github.com/highlightjs/highlight.js/pull/3159
https://github.com/highlightjs/highlight.js/pull/3139

How to get it:

npm install<EMAIL_ADDRESS>build it from source
fetch it via CDN.

Please open a new issue if you have bugs or issues to report.

Testing this out right now. Just writing down my notes upgrading:

Less languages supported, interesting
types changed; nice that they’re no longer global!
result.emitter no longer exists? it’s now result._emitter — but the types haven’t updated
I’m seeing dots in classes now? e.g., title.function — those are supposed to be two classes I guess?
Works well!

Less languages supported, interesting

What?  You just mean common?  We try to keep that to our idea of what's popular/useful.  The total number of supported languages in core actually has gone up (by 2).

types changed; nice that they’re no longer global!

Well, now they no longer work seamlessly in VS Code (so all my listing is broken) and I'm super frustrated, but other than that...

it’s now result._emitter

Yeah, bunch of renaming to indicate what is private vs public.

title.function

This is a single scope that will be split into multiple classes when rendered as HTML. (this is still in flux)  But if you're just talking with the emitter then you're dealing with just the scope name.  It's not converted to actual classes until parse tree is converted to HTML at the very end.

What? You just mean common? We try to keep that to our idea of what's most popular/useful. The total number of supported languages in core actually has gone up (by 2).

For lowlight I detect that based on hljs.registerLanguage calls in highlight.js/lib/index.js — that number went down (but it seems those weren’t “real” languages).

Well, now they no longer work seamlessly in VS Code (so all my linting is broken) and I'm super frustrated, but other than that...

Sounds like something is configured incorrectly? Now they work more like types in other projects from a user perspective.

Sounds good on the time. I’m rewriting some of the outer API of lowlight too, so would be nice to get both in at the same time (although: lowlight isn’t exposing hljs APIs, so a major for hljs doesn’t need to mean a major for ll)

(but it seems those weren’t “real” languages).

Ah, indeed some stubs and older things got thrown out...

Sounds like something is configured incorrectly?

Well if you could help me fix it I'd be grateful.  Before it just worked seamlessly.

I’m guessing it’s that you don’t import types at all! They used to be global state, which meant they could be accessed from everywhere.
I use TS through JSDoc. An import there looks like this: https://github.com/wooorm/lowlight/blob/6d531acc189a414c76525d5e9a3d809d798ffd69/lib/core.js#L4.
Here’s my commit adding types to lowlight

Yeah importing types everywhere was something I was hoping to avoid.  Plus a bunch of our types are private and not exported on purpose.  How does one import types that we never export?

Similar to how you do it with code: not completely, but put it in a file that’s not exported.

/**
@typedef {import('highlight.js').Mode} Mode
@typedef {import('highlight.js').CompiledMode} CompiledMode
@typedef {import('highlight.js').Language} Language
@typedef {import('highlight.js').HLJSApi} HLJSApi
@typedef {import('highlight.js').HLJSPlugin} HLJSPlugin
@typedef {import('highlight.js').PluginEvent} PluginEvent
@typedef {import('highlight.js').HLJSOptions} HLJSOptions
@typedef {import('highlight.js').LanguageFn} LanguageFn
@typedef {import('highlight.js').HighlightedHTMLElement} HighlightedHTMLElement
@typedef {import('highlight.js').BeforeHighlightContext} BeforeHighlightContext
@typedef {import('highlight.js/private').MatchType} MatchType
@typedef {import('highlight.js/private').KeywordData} KeywordData
@typedef {import('highlight.js/private').EnhancedMatch} EnhancedMatch
@typedef {import('highlight.js/private').AnnotatedError} AnnotatedError
@typedef {import('highlight.js').AutoHighlightResult} AutoHighlightResult
@typedef {import('highlight.js').HighlightOptions} HighlightOptions
@typedef {import('highlight.js').HighlightResult} HighlightResult
*/

Any way to beautify that?  It's a bit ugly/verbose.

What’s the context? Where are you importing things? These types could be in the core lib instead maybe?
For more info, see https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html

What’s the context?

Getting access to the types in my main source.

Where are you importing things?

highlight.js
https://github.com/joshgoebel/highlight.js/commit/5c65d22f4adca65a0d16637b11f8ca6ec6cd1d33

These types could be in the core lib instead maybe?

I dunno what that means?

For more info, see

I've read all that in the past. If there is a specific section you were pointing me too, please advise.

Getting access to the types in my main source. My source is all JS, it exports no types... all the type exports are ambient modules.

I’m proposing the inverse: define your types in your code.

I dunno what that means? You mean declare them in highlight.js itself and then export them, import them into index.d.ts and then reexport them? I'm not sure I know how to do that if that's possible - or advisable?

Indeed: write them in JavaScript. No need to add a manual index.d.ts: typescript can compile javascript and generate that index.d.ts.
Here’s a smaller example: https://github.com/words/levenshtein-edit-distance/commit/2c3d890068b0d9405881a94f1439b31f8d08c392.
Lowlight is a bit more involved.
A bit more complex is unist-util-select: https://github.com/syntax-tree/unist-util-select/commit/4c1b02e34f849394bc90b42ea3bce0f52d9b2512.
And quite complex is xdm: https://github.com/wooorm/xdm.
I am not a fan of typescript. I personally don’t really love types either. But they are somewhat useful — especially for newcomers to a giant ecosystem (unified).
I think types through jsdoc in javascript is rather nice: code is directly runnable, no building needed. But everything is still type checked by typescript (and I like type-coverage to ensure everything is completely typed).
It ensures .d.ts are kept up to date and work

typescript can compile javascript and generate that index.d.ts.

Ah, I hadn't even considered that that because I'm not really interested in adding TS to our build pipeline (in my prior experience it's ridiculous slow).  Something to consider for the future perhaps.  I just got the ambient module stuff working and not interested in burning more time on this now.
I will save all those references for future reference though.

I am not a fan of typescript.

I am, but not sure it's right for our codebase since it further limits who can contribute and I think we get most of the listing benefits with JS doctags.

I personally don’t really love types either.

I find they make me a lot more thoughtful/disciplined about the API of functions and shape of objects.  This has been helpful.

Having some problems as I’m no longer allowed to use extensions. https://github.com/xojs/xo is configured to enforce them. I quite like being explicit instead of magic, and would prefer to be allowed to use actual paths.

At the back of my mind something is saying "This is the new standard, people will need to update their linters" , but I'm not sure where I'm getting that from.  All the Node.js examples with conditional exports seem to show lack of extensions IIRC, so I guess perhaps that's at least one place that left me with that impression.
@aduh95 Any thoughts?

Of course if we end up walking back conditional exports before release this will cease to matter as you'll still just be able to import anything you wish...

This is the new standard, [...]

I’d say we used to do extensionless — now we do explicit extensions.
This is closer in line with how ESM works in the browser, or in deno.

I’d say we used to do extensionless — now we do explicit extensions.

I can't keep track because I feel it's changed a few times, I think TS had different ideas than JS for a while, and now conditional exports seems to be hinting at extension-less behavior I thought... I'm curious to see how other packages approach this.
The browser can only deal with files of course (without forcing the resolution behavior back onto the web server itself) so I'd say it was "stuck" without much of a choice...

Also: for xo and Sindre and me: this is folks who used to do extensionless, and are now switching to extensions.
I also don’t like export maps much. But it indeed seems that that prefers no extensions.

I dunno what to think yet... the promise is that ESM and CJS "just work" and no one has to think about highlight.js/cjs vs highlight.js/esm, which seems a nice idea?... whether that's worth all the magic or not... I dunno. :-)  Seems a lot of packagers early on had no idea what to make of all this new stuff... which is why it's still a little up in the air as to whether v11 with have conditional exports or explicit paths (the es folder).

Oh and preventing people from reaching into pieces of your library that are intended to be private is a nice benefit - though it doesn't really apply to us at the moment since we have a build process and if we don't want to expose it we just don't build it separately.

I guess most of your users are using generated bundles though, where it doesn’t matter.
I’d suggest to push for folks who are depending on the files to upgrade to ESM. Dual publishing is complex! ESM is closer to having files directly usable in browsers too.

the promise is that ESM and CJS "just work"

And I think that’s the problem. That promise seems to fail all the time 😬

I do think what your asking is at odds with the whole IDEA of conditional exports though... you're not longer specifying REAL paths or file at all, just identifiers... so to me the "spirit of the law" behavior seems to remove the extensions. No point pretending to be explicit if it isn't really.

Yes, exactly, the goal of conditional exports is to hide where the files happen to be in the npm archive, as it's considered an implementation detail. The idea is that hightlight.js/ada could move from ./lib/commonjs/ada.js to ./lib/wasm/ada.wasm in a semver-minor without the users having to care about what's actually inside the package.
It has also been introduced to Node.js with import maps in mind, which should work in the browser (still behind a flag in Chrome today).

What is the "it" this is referring to?

“It” here refers to module format (ESM vs CJS vs dual) — which doesn’t matter to bundle/CDN users

Huh, I'm not following? Which files and what do you mean "upgrade to ESM"?

I suggest that package maintainers start switching to ESM only.

Well the v11 release isn't necessarily going to happen until post Node v10 sunsetting

That’s in 7 days already!

I suggest that package maintainers start switching to ESM only.

Most of the reading I've seen on this is based on "just keep using our prior version if you still need CJS, easy!" which is NOT a philosophy we want to embrace.  We do not want tons of people on v10 forever anymore than we wanted tons of people on v9 forever after v10 was released.  The best experience is always on the latest and we don't want to give people reasons NOT to upgrade.

which doesn’t matter to bundle/CDN users

I agree for a whole lot of people just happily using our CDN module that this is an entire non-issue.  And our browser/CDN builds aren't changing.

That’s in 7 days already!

Oh, LOL..... well then it'll be after Node v10 I guess...  I'm really looking for some actual feedback with bundlers (or something) and such things where people literally can't use the library because something is broken broken.  So far all we have is your wishing the paths could have extensions.  I assume if you removed the extensions it worked fine (though you haven't said).
Also, the ~ official support window for Highlight.js v10 is ~ 3 months or so... so if a bundler doesn't support conditional exports yet but plans to soon that's also OK I think.

which is NOT a philosophy we want to embrace

I’m not suggesting users use CJS. I’m suggesting they use ESM

I'm really looking for some actual feedback with bundlers (or something) and such things where people literally can't use the library because something is broken broken

Some more info here: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c.
Jest, webpack@4 (CRA), Electron, in some cases Next, are mostly where the trouble is. But they can either be configured to work, or plan on landing this when Node@10 is EOL (so in ±6 days).
I don’t know about conditional exports support in bundlers, as I don‘t use that myself.

I’m not suggesting users use CJS. I’m suggesting they use ESM

Right, but ESM only is a reason for someone not to upgrade if their codebase is "stuck" on CJS.  I don't want to do anything to encourage "well we'll just keep using v10, it works".

ESM only is a reason for someone not to upgrade if their codebase is "stuck" on CJS

Definitely.
On the other hand, it’s going to happen anyway: some maintainers will use ESM. Especially for new projects. So users will notice it at some point in time.
I think there’s something to say for collective action from maintainers. That way it won’t be only one package that’s a version behind, but more and more. It’s not going to be the most of fun for users, but slowly moving over 2 years isn’t fun either, with collective action at least it’s swift.
highlight.js is relatively “high-level” project, with many beginners, compared to most of Sindre’s or my stuff. And it’s relatively unique at that for having no dependencies.
Generally I think these changes “bubble upwards” through the ecosystem, from low-level one-liners, through more user-facing projects, to users.
I think you have some options and that choosing to not be one of the first to switch is a fine strategy. On the other hand, most of your users won’t notice and the folks that do depend on it through npm are (presumably) aware of the CJS -> ESM move, and it might cause them to switch faster!

Yeah, I just wish I had more stats.  I just feel like v11 already has enough breaking changes and we already "force" our users to do enough (stay up-to-date with releases, including hopefully major ones)... all of this ultimately to serve their interests though - since we can only maintain a single version - the benefit they receive is new features, better grammars, bug fixes, etc... so there is a [hopefully] clear benefit to offset any annoyance.
At this point I just can't see the direct payoff for forcing users to upgrade to ESM if they don't wish to.  Our codebase is ESM already.  The final format of our build assets (ESM or CJS) honestly isn't very interesting to me.  Now we'll just have 3 output formats instead of 2 and users can use whichever works for their usage.  If that proves to be some sort of maintenance headache we'll see, but I'm not imagining it will be.


Fixed hacktoberfest image url

The original link was broken, it was working yesterday afaik

Hey, can I work on this issue...Please assign this to me.


Improve go report card score

https://goreportcard.com/report/github.com/ContainerSolutions/externalsecret-operator
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

        externalsecret-operator/secrets/asm/backend_test.go
        Line 1: warning: file is not gofmted with -s (gofmt)

Golint is a linter for Go source code.

        externalsecret-operator/secrets/onepassword/client.go
        Line 10: warning: exported type Client should have comment or be unexported (golint)
        Line 15: warning: exported type OP should have comment or be unexported (golint)
        Line 19: warning: exported method OP.SignIn should have comment or be unexported (golint)
        Line 30: warning: exported method OP.Get should have comment or be unexported (golint)

IneffAssign detects ineffectual assignments in Go code.

        externalsecret-operator/secrets/backend/backend.go
        Line 72: warning: ineffectual assignment to err (ineffassign)

Misspell Finds commonly misspelled English words

        externalsecret-operator/secrets/backend/backend_test.go
        Line 92: warning: "unkown" is a misspelling of "unknown" (misspell)

        externalsecret-operator/secrets/asm/backend.go
        Line 79: warning: "paramters" is a misspelling of "parameters" (misspell)

        externalsecret-operator/secrets/asm/backend_test.go
        Line 79: warning: "paramters" is a misspelling of "parameters" (misspell)
        Line 90: warning: "paramters" is a misspelling of "parameters" (misspell)
        Line 102: warning: "paramters" is a misspelling of "parameters" (misspell)

Fixed in #63
Found 0 issues across 29 files


ustream not working

The ustream site has changed and the plugin is now failing.
$ get_flash_videos-1.25.92 -d http://www.ustream.tv/recorded/90549242
No plugins installed
Trying to open plugin ~/.get_flash_videos/plugins/Www.pm
Using method 'ustream' plugin version 0.01 for http://www.ustream.tv/recorded/90549242
Downloading http://www.ustream.tv/recorded/90549242
-> GET http://www.ustream.tv/recorded/90549242
<- 200 text/html; charset=UTF-8 24881 (94628): UTF8 on, non-ASCII, 94628 characters 94677 bytes
Error:
Couldn't extract Flash movie URL. This site may need specific support adding,
or fixing.
Please confirm the site is using Flash video and if you have Flash available
check that the URL really works(!).

I submitted a pull request to restore ustream downloads. Basically it ended up being near total redo of the plugin. I can download the recorded sessions from NASA and other public entities. For some reason the individual recordings return a "null" flv record. May require a ustream login capability.


default blending settings for transparency

RenderStates::BlendParameters::TRANSPARENCY (actually, its equivalent before refactor) was originally set to the "traditional alpha blend equations" described here: https://www.khronos.org/opengl/wiki/Blending#Colors
In bc2c3c3, the source and destination alpha values were reversed. Was this intentional? I haven't extensively tested this default mode, but it seems like it would not work properly for most normal blending tasks.

I had to think a bit before I remembered, but yes it is actually on purpose. The only difference is how the alpha value is computed and since the destination alpha is not used for blending the colors are the same. The reason is that on web the rendered image must end up having an alpha value of one in all pixels otherwise it may look weird on some browsers since it then blends with whatever is behind the canvas. Actually wasn't it you that had a problem with this in the fireworks example? 🙂 Anyway if you find that it's not working in some case then please let me know!

Yeah, it was me: it took me a few minutes to remember the context.
We're just talking about a default value, so maybe it isn't worth too much more time, but let me make a case for returning it to
source_alpha_multiplier: BlendMultiplierType::One,
destination_alpha_multiplier: BlendMultiplierType::Zero,

I think you're right that it won't matter in examples/fireworks, because blending operations never use the destination alpha channel as an input. In this case, the preexisting destination alpha (1.0) is preserved through the entire buffer and prevents the weird browser transparency bug. (FYI: examples/fireworks does not actually use the default BlendParameters value, but examples/fog does)
However, the "traditional" equation will have the expected behavior in a case where buffer alpha is important. For (a contrived) example, consider the creation of a picture of fireworks in a RenderTarget, to be drawn multiple times in a scene with transparency:

the RenderTarget would initially be filled with rgba=(0,0,0,0)
some (non-overlapping) fireworks sprites would be rendered into the RenderTarget, writing their own alpha values into it
this RenderTarget can then be used as a texture in the main scene with correct transparency

If the source_ and destination_ alpha_multipliers are reversed, this RenderTarget buffer would have 0 alpha and could not be rendered in the main scene. Obviously there are lots of things that the traditional default can't do, but if there's a default, it may as well be as unsurprising as possible.
The way I fixed the browser transparency bug was to use the code in https://github.com/asny/three-d/discussions/60#discussioncomment-409999 after all rendering had been completed: this simply sets the alpha buffer to what browsers need, with no ramifications for the prior rendering process.
Sorry for resurrecting this issue: I don't remember even looking at the commit when it was made, so I should have made this comment back then.

That is a really good point. I will revert the default transparency back to what it was and then just not use the default in the examples where it causes problems 👍

And I am glad you brought it up again, so it can be fixed, so no worries 🙂


Negative lookbehind

It would be great the have a negative lookbehind for language definitions.

I'd like to suggest the following system:
'positive-number': {
    pattern: /(-)?\d+/,
    lookbehind: true,
    lookbehinddirection: false
}

The default value for lookbehinddirection is true, representing a positive lookbehind. false will represent a negative lookbehind.
The first group will be considered a match, if it matches anything (including the empty string), whatever lookbehinddirection may be. The rest of the expression will be considered a match will if firstGroupMatches ^ !lookbehinddirection is true. (This of course assumes that the whole expression matches in the first place.)
This is somewhat different from the current implementation, as a non-matching first group of a positive lookbehind will currently cause the whole expression to be a match.
(As a less verbose alternative for lookbehinddirection: false, one could use lookbehind: -1)

@RunDevelopment I like this idea. Regarding the wording, I'd prefer something like lookbehingNegative: true (defaults to false) rather than any of you propositions.
Apart from this, your implementation concept looks quite straightforward. Would you be interested in submitting a PR for this?

Sure, I can take a shot at implementing this.
Also: Yes, lookbehingNegative is better.

I will now close this for similar reasons as #1465.

It will add a lot of complexity and will only ever be used by a small number of languages.

I can not think of any way to implement this efficiently.

I have written dozens of languages and never needed it because...

Current positive lookbehinds can already do negation. To go with my motivating example: Using only positives lookbehinds, positive numbers can be matched using: /(^|[^-])?\d+/. This is a trick I regularly use.
More general: To get the Prism lookbehind of (?<!R) for any regular expression R, you have to find the complement of ^[\s\S]*R. This isn't easy but it is always possible.
E.g. (?<!a) ~= (^|[^a]), (?<!#\s*) ~= ((?:^|[^#\s])\s*)


1.2.5 angular-mocks copy change breaks tests using XML datatype

Apparently the XML datatype in Chrome/Firefox (and others?) contains pointers to itself.  The change here (https://github.com/angular/angular.js/commit/f69dc16241c8b631123ad0b09674f0a5e0ff32fe) copies the HTTP response.
If you are mocking an HTTP service with XML datatype as the return type, copy() never terminates.

angular.copy now handles cyclic structures (from 1.4.1 onwards - see https://github.com/angular/angular.js/commit/0e622f7b5bc3d5d0ab0fbc1a1bc69404bd7216d5) so I think we can close this.

Oh but I just realised that there are two issues here. The cyclic one is fixed. The XML one is not.


Unable to download database, CERTIFICATE_VERIFY_FAILED

Describe the bug
SSL: CERTIFICATE_VERIFY_FAILED error when trying to download the jlcpcb database, fresh install so I don't have any previous versions of the database loaded.
To Reproduce
Steps to reproduce the behavior:

Open Plugin
Click download
See error

Expected behavior
A clear and concise description of what you expected to happen.
KiCad Version

Application: KiCad PCB Editor x64 on x64

Version: 8.0.2, release build

Libraries:
	wxWidgets 3.2.4
	FreeType 2.12.1
	HarfBuzz 8.3.0
	FontConfig 2.14.2
	libcurl/8.5.0-DEV Schannel zlib/1.3

Platform: Windows 10 (build 19044), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Apr 27 2024 23:05:17
	wxWidgets: 3.2.4 (wchar_t,wx containers)
	Boost: 1.83.0
	OCC: 7.7.1
	Curl: 8.5.0-DEV
	ngspice: 42
	Compiler: Visual C++ 1936 without C++ ABI

Build settings:

I cannot reproduce this, neithor on Windows nor on Linux. Most likely not caused by the plugin. Re-open if the issue still exists


always on top error is not working on vs-code

Microsoft PowerToys version
0.75.1
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
Always on Top
Steps to reproduce
it not working on vs code application but everywhere else it is working
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Hi, thanks for reaching out. Could you attach /bugreport? Thanks
Also, can you update to v76 and check if this issue is still present?

It works in my circumstance in v0.76.0.

The possible reason could be that VSCode runs as admin, and PowerToys doesn't. Could you please try restarting PowerToys as administrator to check if it helps?

The possible reason could be that VSCode runs as admin, and PowerToys doesn't. Could you please try restarting PowerToys as administrator to check if it helps?

Yes after running the powertoy with administrator permission this is start working


bytes::IntoBytes could take a &mut [u8; MAX_PACKET_SIZE] to avoid allocation

Pretty much what the title says. This is a super nitpick and literally doesn't matter because this is all I/O bound but I am a fan of yeeting as many allocations as possible

While I am a fan of yeeting allocations, I'm trying to adhere as much as possible to the idioms and design language of the Rust standard library. Generally what I've noticed is that traits or methods that use the word into_blah typically allocate and/or move. Traits or methods that use as_blah typically are implemented as a borrow and don't allocate/move.
That's not to say I'm opposed to reducing allocations in this crate, but I'm not convinced this change should be made to IntoBytes.
It may be more work for whoever implements this, but perhaps a larger refactoring is needed to replace IntoBytes with something non-allocating.
What are your thoughts?

While I do agree that the naming of the trait as IntoBytes suggests that it returns an owned Vec, I'd argue that matters very little because this is an internal trait and we can literally IDE refactor it into another name. Therefore, we can rename the trait to something like Marshal and have it have the (singular) method
fn marshal(&self, buf: &mut [u8; MAX_PACKET_SIZE]) -> &[mut u8]

I'm not saying "no" to this, but I do enjoy the slightly higher-level interface as it is now. I think if we had benchmarks to compare with, it'd be easier to reason with this.

We'll see once #53 comes out :>


Design proposal: Simplify the spawn args

Current Status
Right now there are 3 turnkey arguments related to spawning processes:

--use-slurm
--process-isolation
--timeout TIMEOUT

This is bad UI design because the 3 flags all control the same thing, slurm/processes are mutually exclusive, and timeout only works if slurm/processes is used.
Design Proposal
Create a new argument, --runs-with, that replaces the 3 args above.

--runs-on slurm::TIMEOUT
--runs-on processes::TIMEOUT

@danielholanda to review

Help could look like:   --runs-on            Choose where to execute the turnkey evaluation for each input: local (default) evaluates all inputs in the same process. subprocess evaluates each input in its own subprocess. slurm evaluates each input in its own Slurm job (requires slurm installation).
still needs to incorporate the timeout though.

Closing; the rest of the CLI global arguments were simplified by so much during the refresh that this is no longer as much of a problem.


Constant time comparison

Added constant time comparison while decoding a token to avoid timing attacks on the HMAC signature verification
More info: https://en.wikipedia.org/wiki/Timing_attack

Hello @ivRodriguezCA
Thank you for this improvement. Before we can merge it in, will you please sign the appropriate CLA as specified in the previous comment by @cfdreddbot ? Once we see that it is signed, we'll get it merged in ASAP.
Thank you.

Hi @plfx
Here is the signed CLA
CFF_Individual_CLA.pdf
Thanks!
Ivan.


Failed to get detailed information

URL
https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/install
Operating system
windows
More information about your system
No response
Description
Failed to get detailed information about the configuration.
Apply :: WinGetPackage [install-dotnet8-SDK]
Install .NET 8 SDK
Module: Microsoft.WinGet.DSC
Settings:
id: Microsoft.DotNet.SDK.8
source: winget
Apply :: WinGetPackage [install-vs-code]
Install Visual Studio Code
Module: Microsoft.WinGet.DSC
Settings:
id: Microsoft.VisualStudioCode
source: winget
Apply :: VSCodeExtension [install-csharp-dev-kit]
Install C# Dev Kit
Module: Microsoft.VSCode.DSC
Dependencies: install-vs-code
Settings:
name: ms-dotnettools.csdevkit
exist: true
You are responsible for understanding the configuration settings you are choosing to execute. Microsoft is not responsible for the configuration file you have authored or imported. This configuration may change settings in Windows, install software, change software settings (including security settings), and accept user agreements to third-party packages and services on your behalf.  By running this configuration file, you acknowledge that you understand and agree to these resources and settings. Any applications installed are licensed to you by their owners. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages or services.
Have you reviewed the configuration and would you like to proceed applying it to the system?
[Y] Yes  [N] No:
dotnet --info
No response

Could you clarify the issue? Did you press 'Y' after this step?

Can you share the output of winget --info? I think I've seen this error before, but I don't remember how I encountered it. Having the information about the version of WinGet might help isolate what the problem is.


feat: hide things when cheater or banned

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Spiking on some implementation for https://github.com/freeCodeCamp/superboard/issues/41...
This PR:

Hides the profile progress when a camper is isCheater or isBanned.
Replaces the certification view with the hidden profile view when those flags are true

Removes the check in the API
Took this approach because Quincy wanted to preserve the URL

To discuss/evaluate:

Styling for the certification profile (it defaults to light theme because it's the certification)
Is it safe to move this check client side?
Mrugesh proposes specifying the message based on whether the camper is a cheater or banned.

Going to close this as stale - will revisit when we land on how we want to display this information.


Update Spanish translation of text

Update Spanish translation of text from "le" to "te"

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR in an attempt to attempt to break out of the Travis build pending status.

Thanks and congratulations on your first merged contribution!

Thanks and congratulations on your first merged contribution!