[USM] Add gRPC classification

What does this PR do?
This PR gives the tracer the ability to classify connections as carrying gRPC traffic, if those connections were classified as HTTP2 prior (as gRPC depends on HTTP2 as its "transport layer").

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The feature is covered by unit tests. If you wish to manually test it:

Start system-probe
Get a gRPC client & server to create gRPC traffic. An easy way to do so is to use the gRPC examples from the golang implementation of gRPC: https://github.com/grpc/grpc-go/tree/master/examples/helloworld
After making a gRPC request with the client, run the following: sudo curl --unix /opt/datadog-agent/run/sysprobe.sock http://unix/network_tracer/connections|jq '.conns[] | select(.protocol.stack | length > 0) | {protocol: .protocol.stack, laddr: .laddr, raddr: .raddr}'
You should see a couple of matching connections, being classified as both ProtocolHTTP2 and ProtocolGRPC.

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Load test results:
CPU:

System-probe RSS:

System-probe Working Set:

Very little increase in working set (3.8%), RSS and CPU are mostly the same or lower (probably noise).

Amazing work!


App inside Team no longer sets browser cookie as of today 9 Dec 2019

Hello
Starting this morning, most users can no longer access our applications. No changes have been made to the application, but it appears that authorization cookies are no longer being saved in the browser. The response header contains the following value
set-cookie: Listy_Authentication=168f6364-81fa-43ed-ab56-e6a8d4695e49; path=/; samesite=lax but cookie is never set in the browser.
We were able to save cookies as of Friday (12/6/2019).
Has there been any update to the Teams client that you are aware of?
When we run the application from Visual Studio and test via an ngrok URL the client appears to be remembering cookies and allowing authentication to flow properly.
Thank you very much in advance.

Was able to resolve some of the issue by setting SameSite = SameSiteMode.None on the cookie (which wasn't needed as of 1/6/2019). That resolved the issue in Chrome, Edge, and Edge Beta (chromium based). However, cookies are still not being saved in the Windows Desktop Client.


Remove redundant links from FAQ #where_can_i_get_tested

Internal Tracking ID: EXPOSUREAPP-11871

@larswmh
Why is only:

https://www.coronawarn.app/de/faq/#where_can_i_get_tested changed, but not
https://www.coronawarn.app/en/faq/#where_can_i_get_tested ?

@MikeMcC399 I have now also removed the redundant links from the English FAQ.

Changes approved, thanks @larswmh !


Findings should always be enabled if the user is signed in

The experimental setting should be removed

@jansorg do you think that manual QA will be needed for this update?

@kgilpin That would be useful. Because something is removed, it's not possible to test well with instructions ;) But the general testing of the plugin onboarding should cover all of it (i.e. installing plugin for the first time, opening a new project, signing in to the AppMap server, record AppMaps).


Consolidate migrate_singleton.sh and setup_singleton.sh script

For ticket: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/58360
How to test it:
run ./setup_singleton.sh --operator-namespace <operator_ns>
it will get the control namespace and do the migration for CP2 Instance,

Hi @qpdpQ
Would you mind removing all the references about setup_singleton.sh in migrate_singleton.sh script?
it could help to

make migrate_singleton.sh an internal script, move to common folder
largely reduce the number of parameters passed into migrate_singleton.sh


Redesign the Visual Studio UI to match Windows 11's design language

Do you mean Visual Studio or Visual Studio Code?
Can you given an example of what should change? Maybe a screenshot to illustrate>

Do you mean Visual Studio or Visual Studio Code?
Can you given an example of what should change? Maybe a screenshot to illustrate?

I mean Visual Studio Code, sorry. What I want is a UI that matches the design principles that Windows 11 uses like acrylic menus and toolbars and rounded corners. I hope you get my point

Do you mean Visual Studio or Visual Studio Code?
Can you given an example of what should change? Maybe a screenshot to illustrate?

I mean Visual Studio Code, sorry. What I want is a UI that matches the design principles that Windows 11 uses like acrylic menus and toolbars and rounded corners. I hope you get my point.

Visual Studio Code is already one of the best looking IDEs on the market. If the design principles of Windows 11 are incorporated into it, then it will be the cherry on top of the already unbeatable IDE which is much better than its competitors like any JetBrains IDE.

Do you mean Visual Studio or Visual Studio Code?
Can you given an example of what should change? Maybe a screenshot to illustrate?

Here they are, as per Microsoft, yes the devs.

Thanks for the feedback. Please see #115641 where we are tracking a similar request. Will be closing this one as a duplicate.


Feature request: Graph/history for vote count

It would be nice to be able to see how the amount of votes cast develops over time.

Nice idea for the admin interface. There may be some privacy concerns.

I've occasionally thought this would be nice, but I've also realized that if the admin is also a voter it would allow him the inside knowledge needed to bury more effectively.

I think if it's just a count of total votes, the admin wouldn't normally get much help in voting strategically.


Update program.md

Kinda after the fact, but this was stated as going from 13:30-13:30.

Thanks @jcapriot! Nice catch!


The shape of the InkWell hover can match the shape of the DataRow2 decoration

I don't think it's the better way to do it, but I think it can be useful

Can you demonstrate what this change achieves and how it compares to old behaviour?


Moved images under docs

Build failure on docs is expected, also once merged we will have broken images on npm until we make a new release.


Update to gov-au-theme

Did you get rid of the search box you showed yesterday?
Looks good, works locally :shipit:


A reflexive tactic for Z-modules (commutative groups), specific to Z

I call it ac_simplifier since I want to implement the ring_simplify style simplification later.
Currently, the reflection lemma is proved by assuming a commutative group as section variables. I plan to extend it with a simple hierarchy consisting of commutative monoids and commutative groups.

I call it ac_simplifier since I want to implement the ring_simplify style simplification later.

Can you split into files which are reusable by other languages and files which are specific to elpi? In general, I think a good structure is

files that define the problem and can be reused
files that are specific to the language you want to use
files that test the tactic / plugin and can be reused

Also I gave you admin rights on the repo

Done. Let's merge?


BUG Cannot upload files with CMS_ACCESS_LeftAndMain

Since 3.1.9, actually since https://github.com/silverstripe/silverstripe-framework/pull/3781, I think, the CMS_ACCESS_LeftAndMain permission does not work as intended. At least for the assets.
Now, by default, a user can only create a File, if he is an ADMIN or has the CMS_ACCESS_AssetAdmin permission. But if you use the CMS_ACCESS_LeftAndMain permission, which until then stood for "allow access to all admins", the user is not able to create files. But if you use this checkbox, the other admin checkboxes are disabeld. So for now there is only one way: you have to unset the CMS_ACCESS_LeftAndMain checkbox and set those admin checkboxes (eg. CMS_ACCESS_AssetAdmin) one by one.

Agreed that its violating expectations based on the label of the CMS_ACCESS_LeftAndMain permission. @tractorcow as the author of #3781, do you think we need to modify the Permission::check() call?

I agree this is a bug; Let's extend the check to allow CMS_ACCESS_LeftAndMain to imply CMS_ACCESS_AssetAdmin. It would be better if we had a way of automatically allowing permissions to extends other permissions, but for the time being a fix to this check should be enough.

There you go https://github.com/silverstripe/silverstripe-framework/pull/4085

Nice! But for the future, maybe you could consider to remove CMS_ACCESS_LeftAndMain instead of adding some kind of inheritance. Or at least decouple it from the CMS_ACCESS_... permissions. This would reduce complexity and leave ADMIN as the only super-permission.
Having CMS_ACCESS_LeftAndMain only to allow access to all admins quickly is not enough I think, it also adds the problem that newly added admins are accessible by default.

I think that's the main point for having an "all admins" permission so that you don't have to define additional rights each time a modeladmin is created. I agree that it's more complicated, but you would need to replace it with some other mechanism if it's removed, and I'm not sure having more ADMIN users is appropriate.
In an ideal world as few users would have ADMIN as possible. It shouldn't be necessary to be one to simply do day to day tasks.

Fixed by #4085


Works local, but not on EC2

I am using the json import functionality.
On localhost everything works fine. I pushed it to GitHub and pulled it to my ec2 instance.
When I call the calendar.php all files get generated, so permissions should be alright.
So although everything seems fine the calendar in calendar.php does not have any events and no title.
What could be the issue?

Hi @MNaake. Did you resolve the issue? What was the cause? 🙂

Yes I did. Sorry for not responding. Actually I didn’t read your instructions carefully enough. I just had to make sure that the write rights for the necessary folders exist. Thank you!


FormType not available

The README says to use FormType, but this is not an exported property of the library.
Expected Behavior
README should be updated with the latest changes or FormType should be made available for import.

This is probably due to https://github.com/iamguid/ngx-mf/issues/16.

Yes, it is not published yet, sorry for this. I'll publish today if it possible.


Integrate WPI preferences for our configurable values

We would like to be able to update PID constants using the smart dashboard while we were running our robot. It will make tuning pid faster.

@vkedia05 ’s auto balance/ drivetrain angle code had a reasonable implementation of this, which should be straightforward to port to the current codebase, unless @superyuuki wants to handle it differently.

This still needs to be done, but can be done with the new tunables.

Switched to tuneables; fixed


TS2307

I followed your README directions step-by-step on my existing create-react-app project.  I think it is half-working for me.  I still get an error from typescript itself:
TypeScript error: Cannot find module '@/res/R'.  TS2307

    4 | } from '@material-ui/core'
    5 | import { fade } from '@material-ui/core/styles'
  > 6 | import R from '@/res/R'
      |               ^
    7 |
    8 | const themeToStyles = (theme: Theme) =>
    9 |     createStyles({

Is there something that needs to be done in tsconfig.json too?  Here is my tsconfig:
{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext",
      "es6"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve"
  },
  "include": [
    "src"
  ]
}

Any ideas?

Only difference I see is the following line:
https://github.com/unzico/cra3-ts-antd-sass/blob/0d427d918e54e77951a206d4bd07b5963b24fbf2/tsconfig.json#L2
Does this fix your issue?

Hallelujah!  It fixed my issue!


Android Basics: SQL Basics

2/ Overview of a relational database
It seems like the table is messed up.

@M-Phuykong
Thank you for reaching out to us. The issue is fixed and published.


highly modified and updated

Changes made
EXTENSIVE commenting, & cleaned up a lot of artifact comments from the fork/other programs yu used as basis
deleted a bunch of non used stuff.
Fixed the error with operation of the goingUp & GoingDown sensors
(you used a common debounce for both, however this was causing issues because its used in two different Lambda Transforms)
chaincounter and chainspeed sensor .. i have changed these for correct operation with a "positive going pulse"from the sensor
Not sure what type of sensor you have ... however using a CHANGE trigger type is probably not advisable .. as this introduces
a situation where it counts "twice"..
IMO prefferable to use an EDGE trigger type..... for my example INPUT_PULLDOWN and RISING.
however for a negative pulse .. you would use INPUT_PULLUP and FALLING
the speedsensor counter reporting window was way to fast ..... my winch typically rotates very 1 to 2 secs
hence it was missing pulses ... using a 2000mS period means it works fine for slower with (with a 2 sec rotation period)
Note i have a digital pulse generator and have simulated and tested all the way from 0.5Rev/sec (2 sec period) up to 2Rev/sec (cant see a winch ever going that fast!)
note this requires changing the moving average scaling to 0.5
i have added a local button input for "reset counter"= 0
i have added a remote "reset counter" capability by using a true/false in a skpath
.. i would prefer to use a PUT or similar ... but not yet familiar with how to code these
have started to implement storeage of counter to non vol memory..
but not yet working
because im using it ONLY as a monitor (detecting goingUp/Down, and counter and speed)
i have commented out all the control goUp/Down stuff and max rode etc features..
hopefully all of above is helpful to you .. ive spent a couple of days so far getting it working to this point ...
still need to crack the Non Vol ("preferences stuff) .


typos in comments

fixed some typos. yay I'm helping ;-P

Fixed with https://github.com/l20n/l20n.js/commit/0120fc89a221014522d20564a824c07457918060
Thanks @mozfreddyb !


Add SessionWindow details page with simple analysis

To better understand data from rrweb, I started building simple session_window/details page.
It then spawned some base work on SessionWindow analysis, which could be first step in exploration of

Searching / filtering of recordings, including navigation and 404s/500s, button clicks, rage clicks, dead clicks, etc.

which I would love to look into :grin:
This PR adds:

some basic parsing of event data (types, source, href)
little analysis from this data (list of visited pages)
page for viewing session window data

It's pretty rough, but hope it might be good first step.

Ok, finally I got back to this

removed error tracking
updated to current code + design

I left there now empty tags, which I'm not sure if I should've, can remove it. I still hope I will soon look into how this data can be analysed and tagged usefully :grin:


[MRG] Fixes to epochs and baseline docs.

Just closing a couple of small issues.
Closes https://github.com/mne-tools/mne-python/issues/3518
closes https://github.com/mne-tools/mne-python/issues/3566

thx @jaeilepp merge when CIs are happy

Current coverage is 87.28% (diff: 33.33%)

Merging #3575 into master will decrease coverage by <.01%

@@             master      #3575   diff @@
==========================================
  Files           341        341
  Lines         60139      60142     +3
  Methods           0          0
  Messages          0          0
  Branches       9186       9187     +1
==========================================
+ Hits          52495      52496     +1
- Misses         4898       4899     +1
- Partials       2746       2747     +1

Powered by Codecov. Last update 7cd5d0e...1c71e31


STIX 2.1 support

The matcher doesn't appear to work with STIX 2.1 if using object_refs instead of a 2.0-style Observable Container.

@pcoccoli
https://github.com/oasis-open/cti-pattern-matcher/pull/76

Closed via https://github.com/oasis-open/cti-pattern-matcher/pull/76


Could not generate a decorated class for type NuGetPush

I recently tried to update the build system of an older project, bumping the java version, gradle and gradle plugin versions to something current. What I now observe is the following.
FAILURE: Build failed with an exception.

* Where:
Build file 'C:\project\build.gradle' line: 2

* What went wrong:
An exception occurred applying plugin request [id: 'com.ullink.nuget', version: '2.18']
> Failed to apply plugin [id 'com.ullink.nuget']
   > Could not create task ':gaia_msi:nugetPush'.
      > Could not create task of type 'NuGetPush'.
         > Could not generate a decorated class for type NuGetPush.
            > java.lang.ClassFormatError: Duplicate method name "setTimeout" with signature "(Ljava.lang.Object;)V" in class file com/ullink/NuGetPush_Decorated

The used gradle version is 6.1.1 and the used Java version is OpenJDK 13.0.0 x64 on Windows.
The gradle files itself do not call the setTimeout method and do not use the NuGetPush feature.
In the past the stuff worked with Java 11 and 12 and Gradle 5.3 with nuget plugin in version 2.15.
Can someone recommend any workaround for this or has an idea where this comes from?
Edit: The last working combination of plugin and gradle is 2.18 with gradle 6.0.1. Everything else, including 6.2-RC-1 does not work.

Hi, it is because gradle just added timeout in base class in gradle 6, can be fixed by removing it in #79
and use timeout from gradle directly if necessary

Is there a timescale to merge this PR and publish a 2.19 release? I'd love to move up to Gradle 6, but this is a blocker, unfortunately.

Sorry just released, but I didn't have time to test it thoroughly with the new Input Output requirements in gradle 6 / 7
if you encounter any problem, please notify us, thanks

That’s great, thank you!


Broken Pod docs

The official Mesos pod docs is broken: https://mesosphere.github.io/marathon/docs/pods.html

@sascala can you have a look?

Thks the URL is available now


Restrict ethers to v5

Getting an error from the latest versions of your package 0.8.14.

I believe its because you do not restrict the major version of ethers to v5. There is now a beta version of ethers 6.0.3 available on npm but I dont think its really ready for production and has many breaking changes. I believe your build is including this version and is breaking the build of our apps.

Build works for us by reverting to 0.8.9

Hey thanks for this! We've updated the semver to lock it to v5 for now


[TB] Develop the subscriber and publisher (for Worker module)

User story

As a SD
I want to develop the publisher and the subscriber
So that I can get relevant topics from the mqtt node on the robot, the localisation topic and the line measurement topic. Later I can publish the current location, speed and direction.

Acceptance criteria

Get relevant topics from the mqtt node on the robot, the localisation topic and the line measurement topic
Publish the current location, speed and direction

Definition of done (DoD)

Linter & Checker were performed and passed
Code Review has been completed
Code was merged in sprint release candidate
Updates are written in issue comments
Feature builds and tests successfully
Acceptance by product owner
User Story & Acceptance Criteria fulfilled

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Subscribers: LocalizationControllerResultMessage0502, LineMeasurementMessage0403, Order, EnergyLevel
Publisher: AGV Position, MotorPower


Enable include rule in php-cs-fixer

Continuation of #14100
See https://github.com/FriendsOfPHP/PHP-CS-Fixer
Refs https://github.com/yiisoft/yii2-app-basic/issues/123

Please resolve conflicts. Thanks.

Done.

Merged. Thanks!


Submit with Enter instead of Space

Is it possible to update this package to submit chip with the enter key?

@Entrebear Just published a new version on pub.dev
I have added a property createTagOnSubmit which is by default false, if it's true then the plugin will create tags on submit, if both separator and  createTagOnSubmit are used and separator will be ignored.
dependencies:
  flutter_chip_tags: ^2.0.1


fix CENC/CBC1 typo mistake

Summary: Fix CENC/CBC1 typo mistake
Type: Bugfix
Test Plan: UT

https://jenkins.code.rdkcentral.com/job/build-component/64404/ started.

Smoke tests for ['build-aml-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138814/

Smoke tests for ['build-aml-reftv'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138815/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138817/

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138819/

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/19864/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/32414/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/27863/ started

https://jenkins.code.rdkcentral.com/job/build-component/64419/ started.

Smoke tests for ['build-aml-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138844/

Smoke tests for ['build-aml-reftv'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138845/

Smoke tests for ['build-brcm-va'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138847/

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138850/

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138851/

https://jenkins.code.rdkcentral.com/job/github-triggered/27868/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/19869/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/32415/ started.

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138853/

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138854/

Smoke tests for ['build-aml-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138855/

'['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell']' Smoke test FAILURE, investigation pending.
Flash MC [FAILURE]
Flash HYB [FAILURE]
MC - Video Test skipped [FAILURE]
HYB - Video Test skipped [FAILURE]
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/40593/

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138862/

Smoke tests for ['build-aml-reftv'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138864/

Smoke tests for ['build-aml-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138863/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/138865/


Don't send content type in a 304 response

Makes that 304 sent by the static file router doesn't contain a Content-Type header. Otherwise it messes with Chrome's response preview.
Before this PR

After:

Not sure if changing webContentTypeToString is the best way. Let me know if there's something I should change

Thanks so much for your patch.


Document why services have to be Clone

Right now services must be Clone, but it's not obvious (imho at least) why they are clone. Users might make incorrect assumptions about what mutating their service object within a service implementation does. They might think they're modifying the one copy of the struct, while really they're just modifying a clone.
struct MyServer {
  counter: u64,
}

impl Service for MyServer {
  fn do_thing(&mut self) {
    self.counter += 1; // Only ever increments the copy that is made by the tarpc layer :(
}

Closing as dup of #57 which already has a note about Clone. Feel free to flesh out that issue a bit more.


setup.py: Use setup_requires for setup.py requirements

The dependecies on setuptools/pip/wheel were required for the setup.py
to run and not the actual source code to run.
install_requires won't work here because those are meant for the source
to run.
According to the packaging specification, setup_requires should be
provided for any dependencies needed by the setup.py to run.
Reference: https://pip.pypa.io/en/stable/reference/build-system/#controlling-setup-requires
Example: https://github.com/slundberg/shap/blob/v0.40.0/setup.py#L226
Fixes https://github.com/NicklasTegner/pypandoc/issues/198

Looks good. Thanks for contributing :)


Review impact of CHEBI role hierarchy on GO classification

Create version of chebi_import.owl without GOCHE logical definitions. Create reasoned diff compared to current chebi_import.

Here is the diff: https://docs.google.com/document/d/15aP0D1tRB5DwpiGEkj-4pgQvjCE0CjLVYRR9ee3WBnE/edit#

@balhoff - I think this is done so I'm going to close it. Reopen it with details of what is needed if you need any further input.


Default Position does not work with y-axis value

I am working on a graph drawing project and I find the Draggable data component does not work well with the y-axis value in defaultPosition prop.
For example, I have dragged the Draggables data into a specific position and saved their location by getBoundingClientRect(). They have the same y value but different x value. So I will expect the Draggables data will be displayed on the same line if I render the page and use the previously saved values. It turns out as below: they are located at their x value as expected but located at the wrong y-axis location (exactly 1 draggable data's height distance).
Is it a bug or I have missed sth in documentation?  Thanks!
Ref:
<Draggable       axis="both"       bounds="parent"       handle=".handle"       defaultPosition={getCalculatedEntityDefaultPosition(x, y)}       position={null}       grid={[5, 5]}       scale={1}       onStart={(e) => {         e.stopPropagation()         handleStart(e)       }}       onDrag={(e) => {         e.stopPropagation()         handleDrag(e)       }}       onStop={(e) => {         e.stopPropagation()         handleStop(e)       }}     >

Oh, if I change the div inside Draggable data to position: 'absolute' then it will jump to the next line anymore.
<Draggable>

 </Draggable>


Device not recognized - Not being able to perform a Hard-Reset

Which OS are you using? Windows 7 and Kali Linux VM
Which Arduino IDE Version? 1.8.9
The ESPtool you are using is from https://github.com/whid-injector/esptool ? Yes
The USB port you are using is USB 3.0? (sometimes they may create issues with arduino boards. try a usb 2.0 or a usb hub) Tried both 2.0 and 3.0
Did you try with an older version of Arduino IDE (i.e. 1.6.0)? Tried with 1.8.3 too.
Did you try to use an USB 2.0 port? Yes
Did you try with another laptop/PC? Yes

Hey guys, today i received my Cactus WHID, i had the famous problem involving not being able to properly see the AP because i changed the SSID.
So i followed this guide: https://github.com/exploitagency/ESPloitV2/tree/36638cfe1a4fb3749355faf63ef182c19419dd52 , made a mistake in one of the steps, and now no matter in wich device i insert the Cactus WHID, i get the "Unknown Device" thing ("the USB device is not being recognized").
Should i try a hard-reset (with the magnet and all)? I tried but it's kind of complicated to accomplish, plus the tutorial in the Wiki it's not that friendly: https://github.com/whid-injector/WHID/wiki#hardware-unbrick--hard-reset
EDIT: Already tried with three different tipes of magnets and nothing seems to happen, is there any special type of magnet that i need to use?
Thanks in advance for any tips!

Anyone..?

try harder.

Hey bro,
any advice? I changed the SSID too,
then I didn't have any access point.
I tried the magnet, I tried to flashing it with the sketches like the tutorial but still have no results.
Thanks
@whid-injector  @demian123


Improve test log readability of Travis and AppVeyor

This pull request just improves the readability of the test logs on Travis and AppVeyor
Currently, the test scripts have these issues:

When xspec.bats (a test script for *nix) fails, it prints the output without new line. Hard to read.
When xspec-bat.cmd (a test script for Windows) copies files, it works verbosely.

This pull request

enables echo in xspec.bats to print new line
copies files silently (and explicitly fails on error) in xspec-bat.cmd

No code change in XSpec core.

This pull request derives from #238. So needs to be handled after that.

This pull request just improves the output of the test scripts. It doesn't touch the XSpec code. None of the existing tests are removed.
The test scripts still catch test failures. (demonstrated on Travis and AppVeyor)
Some pending pull requests (towards #235 in particular) depend on the changes in this pull request.

@cirulls
So I think you can merge this (after #238) safely without going into details, or I'd like to merge this by myself in a few days.


Create debug mode

So as the code runs you can see the generation of dependencies and when they are completed and linked.  This will output the array of what is left straight after.

Created a very basic output for scripts added and loaded.  Also showed a basic connection of dependencies


Styling question.

Hello,
I am trying to create a full bleed layout such as the one in the screenshot below. However other slides should behave as they do now by default. The only way I've managed to do this layout is by applying some styles to the default Slide within the theme.js file. This then breaks other slides. Is there a better way of doing this or do I need to recreate the Slide layout.

Can you provide a bit more details? I don't think I quite understand from your description and screen shot, what exactly you're trying to do.
But from my understanding you want to place a background image for a single slide? Maybe you could look into creating a Provider? It's a single component that encapsulates the entire view and has access to the desk's state. So you could, say on the fifth slide, set the background of body to your image and remove it if not on the fifth slide. This would preserve the slide's styles. You could also create a floating image component and set the z-index so that it's just behind the slide's content.

This sounds like you're trying to use the Image layout component maybe? If so, you might want to add some styles like the example here https://github.com/jxnblk/mdx-deck/issues/221#issuecomment-475931318

Closing due to inactivity


Let tests be run for all flavors

Ensure that CircleCI runs tests on all build flavors.

I've removed the extra jacoco report generation as we can get the test results without now.
It's unclear how the extra coverage reports affect our results for the normal release build, and that's the important ones.
@AlexanderAlferov is checking that behavior and depending on his results we can re-add the task.


metadata acquisition help links

Coverage remained the same at 0.0% when pulling e1263d11deb7d8909a73505bb26427468c6c96f3 on theseyi:metadata-acquisition-help-links into<PHONE_NUMBER>5b1982ed3b01882101b12d7a582f07 on linkedin:linkedin.


torrent: cancelBlocks on wire 'close'

We may need to add even more logic: malicious peers may hold back responses indefinitely. What do you think about request timeouts?
(Albeit not for malicious reasons, I once got no response from certain peers when choosing a wrong request size (> 16 KB)).

@astro When a wire emits finish, all pending request callbacks are called with errors. Code here: https://github.com/feross/bittorrent-protocol/blob/c41d091549dc15261f81d3c22d6d59771a6b9cf1/index.js#L620-L621
This will be handled in gotPiece in torrent.js here: https://github.com/feross/webtorrent/blob/25c6a10e3180b4aeea1c36f8d57ad66a0e599b52/lib/torrent.js#L966 where storage.cancelBlock is called.
Unless I'm mistaken, this PR shouldn't be necessary! Do you agree?

malicious peers may hold back responses indefinitely. What do you think about request timeouts?

Timeouts are already handled by bittorrent-protocol here: https://github.com/feross/bittorrent-protocol/blob/c41d091549dc15261f81d3c22d6d59771a6b9cf1/index.js#L450 as long as we call wire.setTimeout in torrent.js.

There's even a test verifying that timeouts work as expected here: https://github.com/feross/bittorrent-protocol/blob/master/test/timeout.js

you're right.


Feature/issue9: Changes to update GEANT version to 4.10.x

Update of WCSim to be compatible with 4.10.1 (though should work w/ 4.10.2).  Most changes are for CLHEP, though some updates to physics model.  Work done by Sam Short and Francesca Di Lodovico.  Base update can be read here:
neutroncapturesgd_geant410_samshort_fdl.pdf
Some validation plots with the changes from 4.9.4 to 4.10.1 can be read here:
wcsim_terri_docdump.pdf
(Note: 4.10.2 also has a change to the Cherenkov time step that GEANT uses, which should affect the number of hits and possibly the timing.  Don't know exactly how just yet.)

Great, thanks for putting this pull request in. It looks like you have done extensive verification. Just so I can understand what you were testing, were you comparing your code with Geant 4.9.4 vs. 4.10, or were you comparing the old code with Geant 4.9.4 vs. your code with Geant 4.10? Both comparisons are interesting since the first case tells us what changes we would expect from just changing Geant versions while the second case would tell us if there were any differences in the code that will change our output. On a related note, if I run the code in this pull request with Geant 4.9.4, will it match identically with the current development branch run with Geant 4.9.4?

Hi Erin,
To quote you:
"Great, thanks for putting this pull request in. It looks like you have done extensive verification. Just so I can understand what you were testing, were you comparing your code with Geant 4.9.4 vs. 4.10, or were you comparing the old code with Geant 4.9.4 vs. your code with Geant 4.10? Both comparisons are interesting since the first case tells us what changes we would expect from just changing Geant versions while the second case would tell us if there were any differences in the code that will change our output. On a related note, if I run the code in this pull request with Geant 4.9.4, will it match identically with the current development branch run with Geant 4.9.4?"
I was comparing the old code w/ 4.9.4 and new code w/ 4.10.1, though as you can see in the docdump file, there's not much a difference in that respect.
For the question at the end, I haven't tried that, but I don't think it will due to the model changes and changes in header files by GEANT in the process of going from 4.9 to 4.10, so (assuming it compiles) it won't run.  Hope that clears things up a bit.

resolved with PR #211


Swap effect for a range of values

Hey! I'm new to the party but really enjoy flutter_animate so far. The only effect, I've missed so far (and maybe I'm just blind) is a way to swap/fade through a range of widgets/builders similar to https://pub.dev/packages/cross_fade. Would that be something that's already easy to emulate with flutter_animate or something you've considered?
Cheers and keep up the great work!

hmm... swapping through a list of items probably doesn't fit the core goals of the library, but it would be easy enough to do with a CustomEffect. I can see value to adding a CrossfadeEffect though. I might take a stab at that today.
Something like:
foo.animate()
  .crossfade(builder: () => etc, opaque: true)

I also likely won't support animating the size (at least initially), since it seems pretty situational, and I have to imagine it must cause some issues with adaptive layouts. I could look into adding it later behind a flag if there's demand.

Added CrossfadeEffect in 40a5c6716fef0d5fb6ca649c7f49c805668149f1
Kept it simple for now, but feedback is welcome.

Wow, that was impressively quick - thanks mate! :tada:
I'm still very interested in the list of things. For example: fading through a list of products based on scroll position.
Just making sure I understood your response correctly.

swapping through a list of items probably doesn't fit the core goals of the library

Do you mean that the common pattern is item.animate().doSomething(), i.e. animations are geared towards individual items rather than sets of items? Or do you mean something else?
In case of the former, I could naively see a similar approach to AnimateList work. Something akin to:
[a,b,c].animate(target: 2).fadeTo()

Anyway, since I'm still interested in lists of things, I took your CustomEffect suggestion to heart and gave it a spin. Were you thinking of something like:
  int value = 0;

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: <Widget>[
          Container().animate(target: value / 4).custom(
                begin: 0,
                end: 4,
                builder: (context, value, _) {
                  return Stack(
                    children: [
                      Container(height: 40, width: 40, color: Colors.red)
                          .animate(target: value != 0 ? 0 : 1)
                          .fade(),
                      Container(height: 40, width: 40, color: Colors.green)
                          .animate(target: value != 1 ? 0 : 1)
                          .fade(),
                      Container(height: 40, width: 40, color: Colors.blue)
                          .animate(target: value != 2 ? 0 : 1)
                          .fade(),
                      Container(height: 40, width: 40, color: Colors.yellow)
                          .animate(target: value != 3 ? 0 : 1)
                          .fade(),
                    ],
                  );
                },
              ),
          TextButton(
              child: Text('+ ($value)'),
              onPressed: () {
                setState(() {
                  value = (value + 1) % 4;
                });
              }),
        ],
      ),
    );
  }

? It does work, which is nice. I guess, the artisanal arithmetic makes changing the list a bit awful but nothing I couldn't abstract away. I'm mostly curious if you had a more straight forward solution in mind. Thanks!

Right, Animate is really aimed at targeting a widget, and manipulating it visually, whereas this is getting into a more state based feature. You could certainly leverage Animate to do the transitions, or even build something more robust using a CustomEffect (as per your proof of concept) or an Effect subclass, but it's unlikely that this specific will be rolled into the core library.


Use proper generator configuration in MinGW Windows toolchain

This fixes Windows builds where MSYS2 isn't installed, but MinGW is. Uses the technique described in https://github.com/alexcrichton/cmake-rs/issues/3#issuecomment-196528756.

🥥


Compile Backend Components Documentation

As a team member, I need to compile documentation on the backend components of the CLO feature for the high-level system overview. This documentation will offer insights into the architecture and functionality of the backend system.
Acceptance Criteria

Identify and list all backend components involved in the CLO feature.
Document the role and responsibilities of each backend component.
Specify any dependencies between backend components.
Include information on data storage, processing, and retrieval mechanisms.
Ensure the documentation is well-organized and easily accessible.

CLO Features Process Documentation
1. Verify Data Provider Identity and Data Integrity
What:
We ensure the authenticity of the data provider and verify the integrity of the submitted data.
How:

Data provider identity is verified using the JSON Web Token (JWT) received with the request.
JWT is obtained from TIKI Auth and used for authentication with TIKI Data Provider API during receipt image upload.

Systems Involved:

Data provider requests JWT from TIKI Auth.
TIKI Data Provider API authenticates using the JWT to verify identity.

2. Check User's License
What:
We validate if the data provider possesses a valid license for the user data.
How:

TIKI Data Provider API checks license validity using the TIKI License API
Requests without a valid license or expired licenses are rejected.

Systems Involved:

TIKI Data Provider API communicates with TIKI License API to verify the data provider's license.

3. Create a Request Record
What:
We generate a unique ID for tracking and future reference.
How:

TIKI Data Provider API creates a unique request ID for each submission.
An HTTP response includes this ID for user reference.

Systems Involved:

TIKI Data Provider API generates and returns the request ID.

4. Add a user Card
What:
We send the user card informatio to Kard to source offers and assign rewards to the user.
How:

TIKI CLO Service authenticates with Kard using its internal credentials.
The user is identified by the TIKI's internal user id and the card information is sent with no cardholder PII. A sample of the sent data can be found in Kard docs
The card information is retained in ephemeral memory until the card is registered with Kard, then discarded.

Systems Involved:

TIKI CLO Service authenticates with Kard using its internal credentials.
Kard does not require any cardholder information. The card data is treated according to their Privacy Policy

5. Send transaction data
What:
We send the transaction data to:

Kard to automatically identify redeemable card-linked offers (CLOs) for reward program cardholders.
TIKI Ocean to make it available to the data provider cleanroom and to be licensed to data buyers.

How:

TIKI CLO Service authenticates with Kard using its internal credentials.
The user is identified by the TIKI's internal user id and the transaction information is sent with no cardholder PII. A sample of the sent data can be found Kard docs
Tansaction data is structured to be ingested by TIKI Ocean.

Systems Involved:

TIKI CLO Service forwards transaction data to Kard and TIKI Ocean.
Kard matches the redeemable CLO and return the reward.
TIKI Ocean saves the transaction data into the data repository.


Upgrade (dev-)dependencies

Description of change
Upgrade (dev)dependencies per issue:
#19 eslint (dependency): 3.18.0 :arrow_right: 3.19.0
#18 espree (dependency): 3.4.0 :arrow_right: 3.4.1
#17 coveralls (dev-dependency): 2.12.0 :arrow_right: 2.13.0
#15 nyc (dev-dependency): 10.1.2 :arrow_right: 10.2.0
N/A handlebars (nested dev-dependency): * :arrow_right: 4.0.6
Pull request (PR) check-list

:white_check_mark: Please review and check the appropriate items.

Type of change

[ ] BREAKING CHANGE (with documentation) Please explain if selected
[x] Chore
[ ] Defect (bug) fix (with regression tests)
[ ] Documentation
[ ] Feature/enhancement (with JSDoc and/or Wiki article(s))
[ ] Hotfix (with documentation)
[ ] Performance improvement (with benchmarks)
[ ] Refactoring (with catalog reference)
[ ] Reversion
[ ] Tests

Code standards compliance

[x] Yes, eslint passes.
[ ] N/A (not applicable): Please explain if selected

Code quality. Do the quality gateways pass with an "A" grade?

[ ] Complexity
[ ] Duplications (0.00%)
[ ] Issues (0 issues or documentation for "won't fix" cases)
[ ] Maintainability/Technical Debt
[ ] Reliability
[ ] Security
[x] N/A (not applicable). Dependencies upgrades.

Test coverage

[x] The source code is 100% covered with passing specs.
[ ] N/A (not applicable). Please explain if selected

:information_source: These tasks are not required to open a PR and can be done afterwards, or while the PR is open.

Coverage remained the same at 100.0% when pulling fbf370db2bfa744db10ffc9df75d449d836b8195 on greenkeeper/eslint-3.19.0 into fff9f579e4bdf4eb7d51a4e6681f742c56a10f6a on develop.

Coverage remained the same at 100.0% when pulling fbf370db2bfa744db10ffc9df75d449d836b8195 on greenkeeper/eslint-3.19.0 into fff9f579e4bdf4eb7d51a4e6681f742c56a10f6a on develop.

Coverage remained the same at 100.0% when pulling 07bec3838266ab10362966648f25e593857406a1 on greenkeeper/eslint-3.19.0 into fff9f579e4bdf4eb7d51a4e6681f742c56a10f6a on develop.

Coverage remained the same at 100.0% when pulling 07bec3838266ab10362966648f25e593857406a1 on greenkeeper/eslint-3.19.0 into fff9f579e4bdf4eb7d51a4e6681f742c56a10f6a on develop.

Coverage remained the same at 100.0% when pulling a3fc457c89f74ed7d5498b04174581ca5f18bf19 on greenkeeper/eslint-3.19.0 into fff9f579e4bdf4eb7d51a4e6681f742c56a10f6a on develop.


Update clang-format and cppcheck versions to cpp17

https://jenkins.code.rdkcentral.com/job/github-triggered/39970/ started

https://jenkins.code.rdkcentral.com/job/build-component/78784/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6654/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/11168/ started.

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25183/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25182/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25203/


style problem of  create-react-app 2.X

Why do I have this problem with the 2.x version of Page style will flicker from no style to have style?

There is a known issue of FOUC in development mode since verison 2.1.3 - https://github.com/facebook/create-react-app/issues/6399

Thanks MarkLSky.  Yep this is tracked in #6399 and should be addressed in the next release.


How to export a specific type and all its children

The export function only exports the given type and not its children. How can I export a type and its children?

export is only designed to export a single type, to export a type + all its dependent types you'll need to iterate through the type_map that collects all the types that specta has walked into itself.
Specta is a fairly low level library atm and is best used with something that can collect types for you, like rspc or tauri-specta.
The way rspc is able to export all dependent types is by maintaining a single type_map that is passed to all invocations of Type::reference, and then the types are converted to TS in a loop to construct the final bindings.

I am going to reopen this issue as a reminder to myself that a better solution needs to exist here.
Brendan is completely right in the fact that the current APIs around dealing and exporting dependant types are very low-level and there is no reason that should remain the case. I think it has mostly ended up that way as we have added APIs into Specta as required for rspc and tauri-specta without really thinking super heavily about using Specta without a framework wrapping it.
It's worth noting that the export crate feature (example) does work with exporting dependant types out of the box and I think this will cover many use-cases. It's entirely possible it's not what your going for and that's all good but just wanted to mention it incase you haven't noticed it exists.

Yes I have noticed it. However, the way I want to use specta is that I want to write the export of different types to different files. If I understand correctly, specta right now works by appending each registered type to a typemap. That does not satisfy my use-case.

Completely fair.
We could potentially allow the user to define a function to decide the file to put the types into from the  ExportConfiguration because I feel like it has come up before but idk how useful that would be unless you had some well-defined measure for what goes in each file. I am fairly sure with #72 (which will be part of Specta v2) we will store the Rust module path on each type so maybe that could be used here for automatic module-based sorting?
Out of curiosity are you organising your types by module or some internal concept?
I will keep this all in mind for when I next have time to work on Specta.

Out of curiosity are you organising your types by module or some internal concept?

No, I just have them in one models.rs. Here is an example.
Schematic has the behavior of just exporting the given type and its children. Here is an export using schematic.

On a different note, does specta not export docs for each field?
I have added doc comments for the field but specta does not export them.
https://github.com/IgnisDa/ryot/blob/1dea787774047b40a20fea35143fef783b004c27/apps/backend/src/models.rs#L517-L572

I don't think it does right now. Nothing would be preventing that from working if added to the macros, was just an oversight.


Changing to 20.04 leads to "package not found"

Running this, with all the 19.10s changed to 20.04s, doesn't add any dotnet packages to apt.  When leaving the 19.10, it leads to the unmet dependency errors described in the feedback named "this does not work".  So no solution, it seems..

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: b5cbe58d-ad05-60fd-47d7-0d9ccfeecde4
Version Independent ID: c9773e9b-dbc1-cb7b-b303-287cf8bd354c
Content: Install .NET Core on Ubuntu 19.10 package manager - .NET Core
Content Source: docs/core/install/linux-package-manager-ubuntu-1910.md
Product: dotnet-core
GitHub Login: @Thraka
Microsoft Alias: adegeo

See https://github.com/dotnet/core/issues/4360. There are no official packages for 20.04 yet, though if you want, you can try the workarounds mentioned in that issue.

duplicate of #17638 -_-

Duplicate of #17638


taxon-removed

@balhoff @pgaudet
I merged this pull request. I don't think I should have. I was waiting for feedback and then got mixed up with this one:
https://github.com/geneontology/go-ontology/pull/25756
Le me know if I need to do anything

Do you want to restore it? I can revert it if so.

it might be ok. I only removed some constraints (intended).  I checked the file in and did a pull request (not sure if I needed to do that?) I couldn't figure out how to do the "regenerating?" part of the process. This is a heads up in case I caused a problem.

The regenerating will happen automatically once a day. Yes, always do a pull request for any sort of change.

OK it should be fine. I'm fixing the taxon constraint pre obsoletion now. I think that might be why I ran into issues before. I'll assume it's OK.


A Token search-field for inspect mode

I currently have to scroll to find certain tokens, it takes a bit of slowing down to find the ones I want to edit.
Current behaviour:

It would help if inspect mode had a modal show-up on screen or had a search-field of sorts to quick search the token set the user wants to edit
Design:

Closing this in favor of https://github.com/tokens-studio/figma-plugin/issues/1056


Is this possible?

I have family shared games that servers are shuted down, is it possible I can still get the achievements?

if you own the game in any way, its still possible to get those.
so to answer your question. yes

I tried it on crimecraft gangwars, a.v.a and others and it's says that I don't own the game tho (I have the games shared!!)


Error in the javascript sample code on your website....

Hi
Been trying this all out, not going too well... but nailed the main problem down to the sample code I copied from the example on your website...
On page https://keybase.io/kbpgp/docs/generating_a_pair
under 'generating a keypair' in the javascript version is shows

   console.log("private key: ", priv);

This should be

    console.log("private key: ", pgp_private);

Really easy to fix once you have found it! :)
Great code, thanks for the share - I love open source heros.

👍 You're absolutely write.
I even dare to say that on page https://keybase.io/kbpgp/docs/encrypting
In example 1 in the javascript version it's written
kbpgp.box(params, function(err, result_string, result_buffer) {
  console.log(err, result_armored_string, result_raw_buffer);
});

But to correspond to the parameters of the function it should be
kbpgp.box(params, function(err, result_string, result_buffer) {
  console.log(err, result_string, result_buffer);
});

These are only minor issues compared to your great work. ❤


Histograms are not writing and reading back properly

When testing stage damage curves, it appears that something is wrong with the reading and writing of histograms.
The following code gets triggered when hitting the save button on the computed stage damages UI:

This is the outputted xml:

I think a unit test is needed to test this.

This is on branch stage_damage_table_values although that branch is the same as main right now, so feel free to create a new branch if you want.

Within UncertainPairedData.ReadFromXML(*) we assume that all Y values will be continuous distributions, which is true. To construct those distributions from XML there is a static method on Continuous Distribution that uses reflection to look for properties with a StoredAttribute, to construct. For whatever reason Threadsafe Inline histogram is not using stored attributes to serialize and deserialize, so the FromXML() method on Continuous distribution doesn't find anything and doesn't instatiate anything.
That's why we have Zeros.
We can either add some special case logic into the Continuous Distribution.FromXML() method to check for Histograms and handle them differently, or we can refactor Histogram to work more like the other Continuous distributions when it comes to Serialization.
Option 1 is probably quicker and maintains backwards compatability with existing studies.
Option 2 breaks previous studies, but is probably the better way to handle this.
@rnugent3 Do you have thoughts?

Option 2 seems to be the way to go. Is there a way that we can support backward compatibility? If we want the histograms to inherit continuous distribution, we'll need to think of some name refactor, maybe double check the methods because a histogram is not continuous.

Thinking about this with a fresh brain, I no longer care about backward compatibility. It just flat doesn't work right now, so why should we care about backward compatible? Not like anybody has been relying on this.
Unless I'm missing something in my excitement right now, I'm just gonna start trucking on #2 and get it over with.

I agree, I don't think anyone cares about backwards compatibility for the stage damages. I know I don't.

Ok. in the end my solution was not either of the options. Uncertain paired data now checks for the name of the element to match either histogram or Threadsafe histogram, then builds those separately. Since they're not already a continuous distribution, I decided not to shoehorn it. The last pull request should address this.


Update Dependabot DEPENDENCIES

This pull request updates the DEPENDENCIES file for the suggestion version update.

Related to #6


Add write permissions to /etc/rancher/k3s

By giving write permissions to this folder, we avoid permissions errors when trying to use ...
kubectl config set-context --current --namespace=some-namespace

The entire folder needs write permissions because kubectl config set-context will create a temporary file in the folder before modifying the config file. I also raise the permissions of the kubeconfig file itself to ensure there isn't any issues there either.
Here is the permissions error I ran into.
error: open /etc/rancher/k3s/k3s.yaml.lock: permission denied

Workaround
It is possible to workaround this with...
sudo --preserve-env kubectl config set-context --current --namespace=some-namespace

But why not provide full access to the k3s kubeconfig for the users of this action?

I don't think we should be doing this by default, it goes against the standard kubernetes expectations. The generated kubeconfig is the admin config for the cluster, if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

I don't think we should be doing this by default, it goes against the standard kubernetes expectations. The generated kubeconfig is the admin config for the cluster, if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

An alternative is to copy the system kubconfig into the user's home directory in the default location (maybe something like ~/.kube/config? Which I think has the additional benefit that KUBECONFIG won't need to be set). Though now that we've released v1 we need to consider if this is a breaking change or not.

An alternative is to copy the system kubconfig into the user's home directory in the default location (maybe something like ~/.kube/config? Which I think has the additional benefit that KUBECONFIG won't need to be set). Though now that we've released v1 we need to consider if this is a breaking change or not.

I don't think we should be doing this by default, it goes against the standard kubernetes expectations.

It does? I guess there can be two expectations, k8s cluster admin expectations on setting up the cluster, and k8s client expectations. From the client perspective, being able to update my kubeconfig seems is for me at least a very clear expectation.
As a user of this github action, I think of myself as a k8c cluster client rather than k8s cluster admin.

The generated kubeconfig is the admin config for the cluster, if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

Okay, hmm, what does it really mean practically? Here is an example of k3s.yaml content. I think it contains:

public key info of k8s clusters
kubernetes client contexts (k8s cluster, k8s cluster user, k8s cluster namespace)
preferences
k8s users

public / private key for secure communication

apiVersion: v1
clusters:
- cluster:
    # certificate-authority-data is...
    # -----BEGIN CERTIFICATE-----
    # ...
    # ...
    # -----END CERTIFICATE-----
    certificate-authority-data: <LONG-BASE64-ENCODED-STRING>
    server: https://<IP_ADDRESS>:6443
  name: default
contexts:
- context:
    cluster: default
    user: default
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: default
  user:
    # client-certificate-data is...
    # -----BEGIN CERTIFICATE-----
    # ...
    # ...
    # -----END CERTIFICATE-----
    client-certificate-data: <LONG-BASE64-ENCODED-STRING>
    # client-key-data is...
    # -----BEGIN EC PRIVATE KEY-----
    # ...
    # ...
    # -----END EC PRIVATE KEY-----
    client-key-data: <LONG-BASE64-ENCODED-STRING>

if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

Hmmmm... Is there a point of having a own config? I think the point would only be if multiple users in the ci system used the same k8s cluster identity, then they could have different default values.

Concrete paths forward

We do nothing
We make the /etc/rancher/k3s/k3s.yaml and the folder writable for group/others as well (666 instead of 644), allowing kubectl to be used to update the namespace of the current context for example.
We copy/paste /etc/rancher/k3s/k3s.yaml to some irrelevant location and set KUBECONFIG to that instead of /etc/rancher/k3s/k3s.yaml and make sure that location is read/writable as well.

I think option 2, and probably favor 1 over 3 because that is a significant complexity addition that would break my expectations of the k3s setup github action.

I don't think we should be doing this by default, it goes against the standard kubernetes expectations.

It does? I guess there can be two expectations, k8s cluster admin expectations on setting up the cluster, and k8s client expectations. From the client perspective, being able to update my kubeconfig seems is for me at least a very clear expectation.
As a user of this github action, I think of myself as a k8c cluster client rather than k8s cluster admin.

The generated kubeconfig is the admin config for the cluster, if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

Okay, hmm, what does it really mean practically? Here is an example of k3s.yaml content. I think it contains:

public key info of k8s clusters
kubernetes client contexts (k8s cluster, k8s cluster user, k8s cluster namespace)
preferences
k8s users

public / private key for secure communication

apiVersion: v1
clusters:
- cluster:
    # certificate-authority-data is...
    # -----BEGIN CERTIFICATE-----
    # ...
    # ...
    # -----END CERTIFICATE-----
    certificate-authority-data: <LONG-BASE64-ENCODED-STRING>
    server: https://<IP_ADDRESS>:6443
  name: default
contexts:
- context:
    cluster: default
    user: default
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: default
  user:
    # client-certificate-data is...
    # -----BEGIN CERTIFICATE-----
    # ...
    # ...
    # -----END CERTIFICATE-----
    client-certificate-data: <LONG-BASE64-ENCODED-STRING>
    # client-key-data is...
    # -----BEGIN EC PRIVATE KEY-----
    # ...
    # ...
    # -----END EC PRIVATE KEY-----
    client-key-data: <LONG-BASE64-ENCODED-STRING>

if you need to modify it shouldn't you copy/create your own KUBECONFIG rather than modifying the system file?

Hmmmm... Is there a point of having a own config? I think the point would only be if multiple users in the ci system used the same k8s cluster identity, then they could have different default values.

Concrete paths forward

We do nothing
We make the /etc/rancher/k3s/k3s.yaml and the folder writable for group/others as well (666 instead of 644), allowing kubectl to be used to update the namespace of the current context for example.
We copy/paste /etc/rancher/k3s/k3s.yaml to some irrelevant location and set KUBECONFIG to that instead of /etc/rancher/k3s/k3s.yaml and make sure that location is read/writable as well.

I think option 2, and probably favor 1 over 3 because that is a significant complexity addition that would break my expectations of the k3s setup github action.

~/.kube/config isn't "some irrelevant location", it's the default location: https://kubernetes.io/docs/concepts/configuration/organize-cluster-access-kubeconfig/
For example it's where minikube puts the config when you create a cluster. If I'd thought about it at the time I'd have probably done that instead of exporting KUBECONFIG

~/.kube/config isn't "some irrelevant location", it's the default location: https://kubernetes.io/docs/concepts/configuration/organize-cluster-access-kubeconfig/
For example it's where minikube puts the config when you create a cluster. If I'd thought about it at the time I'd have probably done that instead of exporting KUBECONFIG

The other reason I'm against this change is you'd never do this on a production system. Although this is used in CI the idea is to have a fairly standard K8s cluster suitable for testing production applications. Small changes made for convenience can easily build up and be forgotten leading to unexpected behaviour in future. This is particularly the case where components are decoupled. If someone has to investigate a bug in their application and they discover this directory/file is world writeable I think they'd be very surprised even if it's not the root cause, and may end up wasting a lot of time before realising it's due to this action.
There are several non-Jupyter repos using this action (I was surprised by this! 😄 ): https://github.com/search?q=manics%2Faction-k3s-helm&type=code . I've been meaning to open PRs against them to switch them to jupyterhub, but personally I wouldn't feel happy to do that if we're making these sorts of changes.
Taking time to consider the impact on external users for changes and potentially holding back on changes increases our maintenance burden, but I think it'll improve the overall project including for JupyterHub, for example future JupyterHub maintainers are less likely to be surprised when this deviates from their expectations of K8s.

The other reason I'm against this change is you'd never do this on a production system. Although this is used in CI the idea is to have a fairly standard K8s cluster suitable for testing production applications. Small changes made for convenience can easily build up and be forgotten leading to unexpected behaviour in future. This is particularly the case where components are decoupled. If someone has to investigate a bug in their application and they discover this directory/file is world writeable I think they'd be very surprised even if it's not the root cause, and may end up wasting a lot of time before realising it's due to this action.
There are several non-Jupyter repos using this action (I was surprised by this! 😄 ): https://github.com/search?q=manics%2Faction-k3s-helm&type=code . I've been meaning to open PRs against them to switch them to jupyterhub, but personally I wouldn't feel happy to do that if we're making these sorts of changes.
Taking time to consider the impact on external users for changes and potentially holding back on changes increases our maintenance burden, but I think it'll improve the overall project including for JupyterHub, for example future JupyterHub maintainers are less likely to be surprised when this deviates from their expectations of K8s.

Sorry @manics I didn't meant to say ~/.kube/config was irrelevant, but that if we set KUBECONFIG, it doesn't matter much where that is.
Overview of thoughts influencing me while thinking about this:

Helm warns about kubeconfig being readable by group/everyone
kubectl cannot use the kubeconfig without being readable by group/everyone
The kubeconfig is obviously needed by a k8s cluster client, but is it also something that influence k3s itself? I currently think its generated for use by a k8s cluster client and ignored by k3s.
644 seems similarly problematic as 666
What makes kubeconfig fail to read the kubeconfig?

Perhaps the solution is to not modify the kubeconfig but alias kubectl to k3s kubectl or similarly?

@manics what do you think about making kubectl refer to k3s kubectl by default? Would it make kubectl+helm be able to use it without being group+world readable? Hmmm I haven't tried, that's the next step of exploration in my mind.

Sorry @manics I didn't meant to say ~/.kube/config was irrelevant, but that if we set KUBECONFIG, it doesn't matter much where that is.
Overview of thoughts influencing me while thinking about this:

Helm warns about kubeconfig being readable by group/everyone
kubectl cannot use the kubeconfig without being readable by group/everyone
The kubeconfig is obviously needed by a k8s cluster client, but is it also something that influence k3s itself? I currently think its generated for use by a k8s cluster client and ignored by k3s.
644 seems similarly problematic as 666
What makes kubeconfig fail to read the kubeconfig?

Perhaps the solution is to not modify the kubeconfig but alias kubectl to k3s kubectl or similarly?

@manics what do you think about making kubectl refer to k3s kubectl by default? Would it make kubectl+helm be able to use it without being group+world readable? Hmmm I haven't tried, that's the next step of exploration in my mind.

Doesn't ~/.kube/config solve all those problems? It's owned by the user so permissions can be restrictive, it doesn't need KUBECONFIG to be set so that's one less thing to manage, it avoids messing with the default k3s setup, and it should work for anything using the standard k8s libraries.

Doesn't ~/.kube/config solve all those problems? It's owned by the user so permissions can be restrictive, it doesn't need KUBECONFIG to be set so that's one less thing to manage, it avoids messing with the default k3s setup, and it should work for anything using the standard k8s libraries.

Yeah, it may do that! :) Thanks for iterating on this with me @manics!

Yeah, it may do that! :) Thanks for iterating on this with me @manics!


Add Query. startAt and Query. startAfter to firestore for Android, iOS

Library
Class
Member
Platforms

firestore
Query
startAt
Android, iOS

firestore
Query
startAfter
Android, iOS

Docs: https://firebase.google.com/docs/firestore/query-data/query-cursors

Also looking for this functionality.

Also looking for this functionality.

I've submited a PR (#219).
But it's missing the tests. I'll see if I will have the time to complete the PR with tests at some point, but I encourage you to do it, if you need the functionality 🙂

@nbransby PR #219 is awaiting review

closing as now merged in


Create test for attacks with new fixtures

Very cool! How did you generate the JSON for the attacks? Using generate.py?

How did you generate the JSON for the attacks? Using generate.py?
@trishankatdatadog yes. This is my first python so it may be a bit rough 😂

Would you mind upstreaming your PR to theupdateframework/tuf generate the attack fixtures?

@trishankatdatadog sure I can do that

Closing this PR. I open a more specific #101 one.
I am not sure we can create fixtures that simulate all types of attack but we should be able to simulate rollback attacks at least. We can have separate PRs different types of attacks


Updates DeckSwiper state when receiving new dataSource

Problem
DeckSwiper did not update even though I put a new dataSource in it.
Solution
componentWillReceiveProps detects the length of a new data source and changes its state.

Conflict fixed! @shivrajkumar

@mu29 Could you also add use-case or code snippet for this

Sure.
class TestComponent extends Component {

  ...

  render() {
    <Container>
      <Body>
        <DeckSwiper
          dataSource={ this.state.bookmarks }
          renderItem={ quiz => <Image source={ quiz.src } /> }
        />
      </Body>
      <Footer>
        <FooterTab>
          <Button full onPress={ this.onDeleteBookmark } />
        </FooterTab>
      </Footer>
    </Container>
  )
}

In earlier versions, calling onDeleteBookmark() on these components did not refresh DeckSwiper, so the deleted bookmark were remained on the top.


Promote failing for NuGet package just published in the same job

I have NuGet push task followed by promote task. Both using same .nupkg file and promotion is failed. I validated that package is in the feed.
The error is:
##[error]Package XXXX could not be found
Appreciate if you can provide any caveats for troubleshooting.

I think this has been resolved with #55

Great, thanks. Looks like this should solve the problem.

I validated using 5.0.3 version. it still fails. It went further and now fails on actual promotion. What is suspicious that logs says it was -1 byte payload for PATCH operation:
2020-05-17T16:44:32.5585207Z https://pkgs.dev.azure.com/1id/_apis/packaging/feeds/14be0141-d6b1-4ad8-bab5-d6ca72f9cb50/NuGet/packages/passwordmanager.passwordpolicymanager/versions/5.9.4-package-promotion.1%2B2?api-version=5.0-preview.1
2020-05-17T16:44:32.6471987Z ##[debug]PATCH https://pkgs.dev.azure.com/1id/_apis/packaging/feeds/14be0141-d6b1-4ad8-bab5-d6ca72f9cb50/NuGet/packages/passwordmanager.passwordpolicymanager/versions/5.9.4-package-promotion.1+2?api-version=5.0-preview.1 with -1-byte payload
2020-05-17T16:44:32.7703839Z ##[debug]Caught exception from task script.
2020-05-17T16:44:32.7760255Z ##[debug]Error record:
2020-05-17T16:44:32.8353968Z ##[debug]Invoke-RestMethod : The remote server returned an error: (404) Not Found.
2020-05-17T16:44:32.8358125Z ##[debug]At D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1:162 char:17
2020-05-17T16:44:32.8359864Z ##[debug]+ ... $response = Invoke-RestMethod -Uri $releaseViewURL -Headers $requestC ...
2020-05-17T16:44:32.8364446Z ##[debug]+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2020-05-17T16:44:32.8379154Z ##[debug]    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebExc    eption
2020-05-17T16:44:32.8394876Z ##[debug]    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand
2020-05-17T16:44:32.8407461Z ##[debug]
2020-05-17T16:44:32.8426280Z ##[debug]Script stack trace:
2020-05-17T16:44:32.8460121Z ##[debug]at Set-PackageQuality, D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1: line 162
2020-05-17T16:44:32.8472002Z ##[debug]at Run, D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1: line 301
2020-05-17T16:44:32.8484942Z ##[debug]at , D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1: line 307
2020-05-17T16:44:32.8496804Z ##[debug]at , : line 1
2020-05-17T16:44:32.8508406Z ##[debug]at , : line 22
2020-05-17T16:44:32.8520840Z ##[debug]at , : line 18
2020-05-17T16:44:32.8532849Z ##[debug]at , : line 1
2020-05-17T16:44:32.8553877Z ##[debug]Exception:
2020-05-17T16:44:32.8595063Z ##[debug]System.Net.WebException: The remote server returned an error: (404) Not Found.
2020-05-17T16:44:32.8610442Z ##[debug]   at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
2020-05-17T16:44:32.8622631Z ##[debug]   at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
2020-05-17T16:44:32.8910035Z ##[error]The remote server returned an error: (404) Not Found.
2020-05-17T16:44:32.8924903Z ##[debug]Processed: ##vso[task.logissue type=error]The remote server returned an error: (404) Not Found.
2020-05-17T16:44:32.8926269Z ##[debug]Processed: ##vso[task.complete result=Failed]
2020-05-17T16:44:32.9313664Z ##[section]Finishing: Promote NuGet packages to Prerelease view

Can you share a reproducible YAML file?
On Sun, May 17, 2020, 18:54 Vladimir Gusarov<EMAIL_ADDRESS>wrote:

I validated using 5.0.3 version. it still fails. It went further and now
fails on actual promotion. What is suspicious that logs says it was -1 byte
payload for PATCH operation:
2020-05-17T16:44:32.5585207Z
https://pkgs.dev.azure.com/1id/_apis/packaging/feeds/14be0141-d6b1-4ad8-bab5-d6ca72f9cb50/NuGet/packages/passwordmanager.passwordpolicymanager/versions/5.9.4-package-promotion.1%2B2?api-version=5.0-preview.1
2020-05-17T16:44:32.6471987Z ##[debug]PATCH
https://pkgs.dev.azure.com/1id/_apis/packaging/feeds/14be0141-d6b1-4ad8-bab5-d6ca72f9cb50/NuGet/packages/passwordmanager.passwordpolicymanager/versions/5.9.4-package-promotion.1+2?api-version=5.0-preview.1
with -1-byte payload
2020-05-17T16:44:32.7703839Z ##[debug]Caught exception from task script.
2020-05-17T16:44:32.7760255Z ##[debug]Error record:
2020-05-17T16:44:32.8353968Z ##[debug]Invoke-RestMethod : The remote
server returned an error: (404) Not Found.
2020-05-17T16:44:32.8358125Z ##[debug]At
D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1:162
char:17
2020-05-17T16:44:32.8359864Z ##[debug]+ ... $response = Invoke-RestMethod
-Uri $releaseViewURL -Headers $requestC ...
2020-05-17T16:44:32.8364446Z ##[debug]+
2020-05-17T16:44:32.8379154Z ##[debug] + CategoryInfo : InvalidOperation:
(System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebExc
eption
2020-05-17T16:44:32.8394876Z ##[debug] + FullyQualifiedErrorId :
WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand
2020-05-17T16:44:32.8407461Z ##[debug]
2020-05-17T16:44:32.8426280Z ##[debug]Script stack trace:
2020-05-17T16:44:32.8460121Z ##[debug]at Set-PackageQuality,
D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1:
line 162
2020-05-17T16:44:32.8472002Z ##[debug]at Run,
D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1:
line 301
2020-05-17T16:44:32.8484942Z ##[debug]at ,
D:\a_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.4\vsts-promotepackage-task.ps1:
line 307
2020-05-17T16:44:32.8496804Z ##[debug]at , : line 1
2020-05-17T16:44:32.8508406Z ##[debug]at , : line 22
2020-05-17T16:44:32.8520840Z ##[debug]at , : line 18
2020-05-17T16:44:32.8532849Z ##[debug]at , : line 1
2020-05-17T16:44:32.8553877Z ##[debug]Exception:
2020-05-17T16:44:32.8595063Z ##[debug]System.Net.WebException: The remote
server returned an error: (404) Not Found.
2020-05-17T16:44:32.8610442Z ##[debug] at
Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest
request)
2020-05-17T16:44:32.8622631Z ##[debug] at
Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
2020-05-17T16:44:32.8910035Z ##[error]The remote server returned an error:
(404) Not Found.
2020-05-17T16:44:32.8924903Z ##[debug]Processed: ##vso[task.logissue
type=error]The remote server returned an error: (404) Not Found.
2020-05-17T16:44:32.8926269Z ##[debug]Processed: ##vso[task.complete
result=Failed]
2020-05-17T16:44:32.9313664Z ##[section]Finishing: Promote NuGet packages
to Prerelease view

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/renevanosnabrugge/vsts-promotepackage-task/issues/51#issuecomment-629827955>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA724S6HZKB7OHHMV74LQLLRSAJEJANCNFSM4LGPIKQQ>
.

Can you share a reproducible YAML file?
…

My bad, Jesse. I was using wrong versioning scheme for the branch and actually tried to promote package version that doesn't exist. So, error was pretty accurate. Changed GitVersion mode to Continuous Deployment and now everything works fine.

❤!
On Sun, May 17, 2020, 21:08 Vladimir Gusarov<EMAIL_ADDRESS>wrote:

Can you share a reproducible YAML file?
… <#m_8357722989724505846_>
My bad, Jesse. I was using wrong versioning scheme for the branch and
actually tried to promote package version that doesn't exist. So, error was
pretty accurate. Changed GitVersion mode to Continuous Deployment and now
everything works fine.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/renevanosnabrugge/vsts-promotepackage-task/issues/51#issuecomment-629845458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA724S6CEU3R4WIJQ4OP7ADRSAY2BANCNFSM4LGPIKQQ
.


Update README.md

Doc change: add RAM caveats for Docker Desktop.

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[X] Docs have been added / updated (for bug fixes / features)

@tomhamer - any comments here?


Update cli-install-linux.md

What this PR does / why we need it
Matching the cli-install-linux.md with cli-install-mac.md, changing into the <DOWNLOAD-DIR> before using tar to extract files.
Details for the Release Notes (PLEASE PROVIDE)

NONE

Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

Special notes for your reviewer

Not that important, but also not stale i guess

Sorry for lack of feedback on this, but I think the general consensus is the one line command is preferred, so we don't want to separate this out into two steps that require changing directories. Thank you for working on this, but I'm going to close it without merging.


License and Privacy Policy

@i-bardinov
Hello, I have few questions

Does the plugin collect any user’s data?
Do I need to add anything to my app's Privacy Policy if I use this plugin?
Do I need to add "License" file to my project if I use this plugin?

Hello!

No it doesn’t
No you don’t
Up to you, I don’t insist

Вс, 21 мая 2023 г. в 17:55, SnailRabbids @.***>:

@i-bardinov https://github.com/i-bardinov
Hello, I have few questions

Does the plugin collect any user’s data?
Do I need to add anything to my app's Privacy Policy if I use this
plugin?
Do I need to add "License" file to my project if I use this plugin?

—
Reply to this email directly, view it on GitHub
https://github.com/i-bardinov/Godot-GooglePlay-InApp-Review/issues/7,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVDRZNSQXQYQTEDCF5ZRZTXHIUH3ANCNFSM6AAAAAAYJOK3Y4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@i-bardinov
Thanks :)


Repeated crypto implementation

objc[8348]: Class _TtC11CryptoSwift20AEADChaCha20Poly1305 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c12c98) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efd3b8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift3AES is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c12e30) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efd560). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift14BlockDecryptor is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13058) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efd778). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift14BlockEncryptor is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13150) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efd870). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift13CCMModeWorker is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c134a0) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efd9f8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtCV11CryptoSwift13CTRModeWorker10CTRCounter is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c139a8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efdc68). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift3GCM is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13aa8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efdd30). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift13GCMModeWorker is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13b70) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efddf8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwiftP33_B13760B67F74EDA1901BCF8168C3A85A2GF is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13c68) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efdef0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift3OCB is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13f38) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efdfe0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift13OCBModeWorker is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14000) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe0a8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift8Blowfish is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13240) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe1f8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift6CBCMAC is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13358) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe2e8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift4CMAC is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c138a8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe3e8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift8ChaCha20 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13700) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe4d8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift8Checksum is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c137c8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe5a0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift4HMAC is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13d58) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe6f0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift3MD5 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c13e48) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe7e0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift8Poly1305 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c141a8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe908). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift6Rabbit is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14270) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efe9d0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift4SHA1 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c144f8) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efeaa8). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift4SHA2 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c145e0) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efeb90). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift4SHA3 is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c146d0) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efec80). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift6Scrypt is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14358) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efed58). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift11SecureBytes is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14450) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efee50). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift15StreamDecryptor is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14790) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efeef0). One of the two will be used. Which one is undefined.
objc[8348]: Class _TtC11CryptoSwift15StreamEncryptor is implemented in both /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/Frameworks/CryptoSwift.framework/CryptoSwift (0x108c14848) and /private/var/containers/Bundle/Application/50A6D437-FCBB-441F-855A-9F939CF51414/AlphaWallet.app/AlphaWallet (0x105efefa8). One of the two will be used. Which one is undefined.

@oa-s @hboon It appears that a library is being embedded twice?

I think it's included as both a pod by us directly and as Swift Package by another Swift Package (WalletConnect v2 SDK)

Since SPM seems to work for us now, try replacing our CryptoSwift dependency in the Podfile and into SPM? Remember to try to build for both simulator and device?

Maybe it's easier just to remove the SPM version? @hboon

@eviltofu We can't remove the SPM version because the WalletConnect v2 SDK specifies it.
Oh, maybe we can't remove the pod version for the same reason?
Any ideas? Otherwise, let's keep them both around and make sure the version number always sync (not the best idea of course!)

Ok I've checked the entire Podfiles list and it seems like only a handful are not supported on SwiftPackageManager. Blockie, Charts, StatefulViewController, QRCodeReaderViewController, PaperTrailLumberjack, and one or two more.
Maybe shift everything to SwiftPackageManager?
@hboon

Yes, originally wanted to. But like you said not everything third party dependency we use supports SPM. and it looks like SPM can't have dependencies on pods, so we are going to have a mixture anyway. So it doesn't seem like the right time to move completely (or as much as we can) to SPM.
But are you suggesting we move only those pods that depend on CryptoSwift over to SPM? If that's the case, isn't it possible that we might in the future add a dependency that is only available on Cocoapods and we are back to the same problem?

Why not move WalletConnect to the pod file?

Because it's a third party library that only supports SPM. One way to go about it is to create PR to add support for Cocoapods.

Ok. Let’s close it for now. Maybe we can see if we can add support to the WC SDK for cocoa pods later.


Babel-loader doesn't work if parent folder is node_modules. Unexpected token (27:12) You may need an appropriate loader to handle this file type.

Gives error : Unexpected token (27:12) You may need an appropriate loader to handle this file type.

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template, or open a new issue.
Please submit support requests and questions to StackOverflow using the tag [webpack]. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.

ok, sorry

i solved with :
exclude: path.join(__dirname, '/node_modules'),


Fix flow error

@keybase/react-hackers
quick fix to fix flow errors on master.
TODO fix this properly.
it also seems that with the new version of flow doing IconProps.type just turns into any so we should probably export a new IconType

:+1:

👍

just merging now #YOLO