STO - Update terminology

Replaced with shift-left where I found left-shift mentions.
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[X] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

@douglas-j-bothwell Please review.

This PR has been automatically closed due to inactivity.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR due to merge conflicts, updating the terminology fix here: https://github.com/harness/developer-hub/pull/6249


Separate ListColumnIncluderator cache key parts with nul bytes

Otherwise an includerator of "fo" and "o" would serialize to the same thing as an includerator of "foo"

:+1:

@xvrl @drcrallen changed the separator to 0xff

:+1:  after travis


[solved] CLN stuck at 100% unable to advance to menu

Updated from 1.8.0c to 1.9 without using the upgrade menu accidentally (powered down rPi and just formatted SD card) and thought I'd report on what happened in case someone else ended up doing something similar and is here looking for a solution. Was running Bitcoin/CLN/Mempool/RTL

SSH console appeared to get stuck at "Syncing Bitcoin 100% and Lightning 100%" (waited days without any progress)
Mempool space page displayed but certain elements were missing some were outright wrong.
RTL appeared to be working without any issues

Anyway, it turned out /dev/root was 100% used as reported by df. Anyhow, the solution was to enter the menu manually, select update and update the 'proper' way, everything fixed. Went from a 'broken' 1.9.0 to a working 1.9.0 with free space on /dev/root. All is good again.

This problem is deeper than what the original post suggests. I will investigate a little further and update later if necessary. The out of disk space problem has recurred and I am not sure at this stage what the cause is. It was not, as I had assumed earlier, due to the incorrect update methodology.


Create a .md file under issue #160

Finalize your work on 158 and 159, then work on this to align with them.


New branch

I changed the background Image and changed the text color.

Deleted some extra commits and extra HTML elements

I changed the background Image and changed the text color.


BayesianLinearRegressors.jl

https://github.com/JuliaGaussianProcesses/BayesianLinearRegressors.jl
A student of mine just found this and asked me about it. Should compare functionality and performance?

Yes - thanks. I think I've seen this but not tried it


Add support for nip46 'secret'

I guessing this is just another way of adding in the "token" from nsecbunker but in the bunker://<pubkey>@<relay>?secret=<token> format?

Looks good. I'm guessing the secret is similar to the token in the npub#token format

It's exactly the same, just a new way to pass it spec-ed in updated nip46


activation fails to register CLI commands

from latest Lokl dev, unsure if related to recent refactoring of the WP_CLI::add_command's...
/usr/html # wp plugin activate wp2static
Error: Callable ["WP2Static\\CLI","options"] does not exist, and cannot be registered as `wp wp2static options`.
/usr/html # wp cli info
OS:     Linux 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020 x86_64
Shell:
PHP binary:     /usr/bin/php8
PHP version:    8.0.0
php.ini used:   /etc/php8/php.ini
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       /usr/html
WP-CLI packages dir:
WP-CLI global config:
WP-CLI project config:
WP-CLI version: 2.4.0

no need for subcommand adding as it will use all available in WP2Static's CLI class. silly me

Narrator: It was a php 8 breaking change:

Removed ability to call non-static methods statically.
Thus is_callable will fail when checking for a non-static method with a
classname (must check with an object instance).

Though removed cmd in this repo, add-ons required changing to static methods to load wp wp2static sub-commands to WP_CLI


Zoom doesn't work if image is wrapped within a

The zoom doesn't work if the image is wrapped in a <details> tag.
The magnifying glass 🔎 shows up when I hover over the image, that means the image is detected by the selector, but when I click it, the image doesn't zoom.
You can find a demo here: https://sweetcode.com/docs/wpm/plugin-configuration/google-analytics

It works fine if I don't wrap it in a <details> tag.
Is there a way to fix this?

I was able to replicate the issue and fix it by changing the themeConfig.zoomSelector (now themeConfig.imageZoom.selector). I changed my config from zoomSelector: '.markdown :not(em) > img' to zoomSelector: '.markdown img'. However, I'm not sure what was causing the issue, or why that fixed it. It could be an issue with the underlying medium-zoom plugin.

I should have mentioned this. I am already using  zoomSelector: '.markdown img' and it is still not working in my case. Something must be different in your install.


JAVA-3390: Support wildcard types in the PojoCodec

Evergreen patch: https://evergreen.mongodb.com/version/5d714415850e6124b1c59ac7

Adding the round trip test has exposed an issue. First, here is the test I added in PojoRoundTripTest.java:
        data.add(new TestData("Interface concrete and abstract model with list",
                new ConcreteAndNestedAbstractInterfaceModel("A",
                        singletonList(new ConcreteStandAloneAbstractInterfaceModel("B"))),
                getPojoCodecProviderBuilder(InterfaceBasedModel.class, AbstractInterfaceModel.class,
                        ConcreteAndNestedAbstractInterfaceModel.class, ConcreteStandAloneAbstractInterfaceModel.class),
                "{'_t': 'org.bson.codecs.pojo.entities.ConcreteAndNestedAbstractInterfaceModel', 'name': 'A', "
                        + "  'wildcardList': [{'_t': 'org.bson.codecs.pojo.entities.ConcreteStandAloneAbstractInterfaceModel', 'name': 'B'}]}"));

Running this test generates the following error:
Failed to decode 'ConcreteAndNestedAbstractInterfaceModel'. Decoding 'wildcardList' errored with: Cannot find a public constructor for 'InterfaceBasedModel'.
org.bson.codecs.configuration.CodecConfigurationException: Failed to decode 'ConcreteAndNestedAbstractInterfaceModel'. Decoding 'wildcardList' errored with: Cannot find a public constructor for 'InterfaceBasedModel'.

Here is the stack trace where the exception is thrown:
checkHasAnExecutable:139, CreatorExecutable (org.bson.codecs.pojo)
getInstance:107, CreatorExecutable (org.bson.codecs.pojo)
<init>:40, InstanceCreatorImpl (org.bson.codecs.pojo)
create:28, InstanceCreatorFactoryImpl (org.bson.codecs.pojo)
getInstanceCreator:72, ClassModel (org.bson.codecs.pojo)
decode:120, PojoCodecImpl (org.bson.codecs.pojo)
decode:125, PojoCodecImpl (org.bson.codecs.pojo)
decode:74, CollectionPropertyCodecProvider$CollectionCodec (org.bson.codecs.pojo)
decode:43, CollectionPropertyCodecProvider$CollectionCodec (org.bson.codecs.pojo)
decodeWithChildContext:93, DecoderContext (org.bson.codecs)
decodePropertyModel:213, PojoCodecImpl (org.bson.codecs.pojo)
decodeProperties:197, PojoCodecImpl (org.bson.codecs.pojo)
decode:121, PojoCodecImpl (org.bson.codecs.pojo)
decode:125, PojoCodecImpl (org.bson.codecs.pojo)
decode:159, PojoTestCase (org.bson.codecs.pojo)
decodesTo:142, PojoTestCase (org.bson.codecs.pojo)
decodesTo:137, PojoTestCase (org.bson.codecs.pojo)
roundTrip:90, PojoTestCase (org.bson.codecs.pojo)
test:124, PojoRoundTripTest (org.bson.codecs.pojo)

The issue is that wildcardList is a List with an interface as the upper bound type, and the interface does not have a constructor or a method. I am investigating TypeData some more to determine if there is a safe way to process a wildcard type.

Evergreen patch: https://evergreen.mongodb.com/version/5d73196a3627e053e7717ec6

I have debugged the round trip test, and I have determined that the CodecConfigurationException should be expected when decoding a wildcard list. I have added a custom test for this.

Evergreen patch: https://evergreen.mongodb.com/version/5da610d52fbabe66c09ca0ef


PDF export returns error (502 Bad Gateway, 1033 Argo Tunnel error)

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
PDF export returns either
"Error!"
or
"502 Bad Gateway
An error occurred while opening a stream to the origin."
or
"Error 1033
Argo Tunnel error"
To Reproduce
Steps to reproduce the behavior:

Create any diagram, can be empty
Click on 'File' > 'Export as' > 'PDF...'
Make any export configuration and click 'Export'
Leave 'Where' to 'Device' and click 'OK'
See error

Expected behavior
A PDF download of the diagram being started.
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 24.0.1

Desktop (please complete the following information):

OS: Windows 11
Browser Edge
Browser Version 122.0.2365.66 (Official build) (64-bit)

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:
-yes
Additional context
Monday 2024-03-04 10:00 GMT PDF export still worked, several hours later it stopped working. One day later, it's still broken.

This is now resolved, thanks for report.


Command Not Found

For those of you who run into the issue of "command not found" when attempting to execute
$ ./buildPatchedKernel.sh, chmod -R +x '/pathto/buildLibrealsense2TX2' will resolve the issue. The problem is that the scripts in the directory are not executable by default on a fresh install, even if it's run as super user.
@Tengyun-Mo Should I do a pull request to add it to the README.md or would you prefer to not add it?

It's a commonsensable issue


Autodetect indentSize takes template literal into account

VSCode Version: 0.10.11
OS Version: Mac OS X 10.11.3

Steps to Reproduce:

Open a new project and make sure editor.tabSize is set to auto
Create a new file test.js with the following contents

'use strict';

const multiline = `
  this is a multiline
  string with 2 space indentation
`;

function log(str) {
    console.log(str);
}

log(multiline);

Note: The indentation inside the log function is a tab but GitHub parses it to 4 spaces. So make sure to convert this to a tab when copy-pasting.

Close the file and reopen it

As you can see, it sets the tabSize to 2 because it is 2 in the multiline template literal. But it shouldn't take strings into account to determine this.
// @alexandrudima

I think the feature request label is appropriate for now...
The indentation detection code is language agnostic, so it just looks at the file contents (not at the tokens).
If we ever change that code to first tokenize the file and then guess, I agree that lines in multiline strings and lines in multiline comments should be omitted from the detection.

:+1:

To keep the number of issues in our inbox at a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: we look at the number of votes the issue has received and the number of duplicate issues filed. Thank you for your time and understanding.
P.S. If you disagree and feel that this issue is crucial: we're happy to listen and to reconsider.


Update README.md

Codecov Report

Merging #1126 (34312c6) into main (48ce70c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1126   +/-   ##
=======================================
  Coverage   57.56%   57.56%
=======================================
  Files          73       73
  Lines        2418     2418
  Branches       79       79
=======================================
  Hits         1392     1392
  Misses       1026     1026

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ce70c...34312c6. Read the comment docs.


MonthlyInvoicing

Enter a cell and exit it --> it saves
Check that something has actually changed before calling the backend.

I now added a JSON.stringify/parse but it's still happening. Do a deep merge?
Store vs internal state issue:
Each cell holds a copy of its part of model (timesheet & inbound) which is not reset after a store change
--> when we do a force verify of the outbound invoice, the state is only updated after the timesheet/inbound cells are destroyed/recreated


Godambe not working when running IM parsing example

Hello!
I was running into some issues while running examples/LD/parsing-and-inference-example.py. FYI, I forked the main repository and made a new environment to test it. Is there a bug in LD/Inference.py,  or is it something specific to this example script? This is the error message I got:
Traceback (most recent call last):
  File "/gpfs/home/jiseonm/moments/examples/LD/parsing-and-inference-example.py", line 205, in <module>
    uncerts = moments.LD.Godambe.GIM_uncert(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Godambe.py", line 398, in GIM_uncert
    GIM, H, J, cU = _get_godambe(
                    ^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Godambe.py", line 248, in _get_godambe
    grad_temp = _get_grad(func, p0, eps, args=[bs_ms, vcs])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Godambe.py", line 179, in _get_grad
    fp = func(pwork, *args)
         ^^^^^^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Godambe.py", line 226, in func
    ll = Inference.ll_over_bins(y, m, v)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Inference.py", line 252, in ll_over_bins
    ll_vals.append(_ll(xs[ii], mus[ii], Sigma_inv))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gpfs/home/jiseonm/micromamba/envs/moments_env/lib/python3.12/site-packages/moments/LD/Inference.py", line 211, in _ll
    return -1.0 / 2 * np.dot(np.dot((x - mu).transpose(), Sigma_inv), x - mu)
                                     ~~^~~~
ValueError: operands could not be broadcast together with shapes (14,) (13,)

There were two small changes I had to make to go through the lines before the Godambe step. I don't think it's relevant for my question, but I will report them here just in case. First, numpy.2 doesn't seem to be compatible with scikit.allel, so I had to downgrade it. Next, I changed line 57 to ts.write_vcf(fout, allow_position_zero=True) from ts.write_vcf(fout).
Thanks!

Hi @jiseonmin - thanks for opening in this issue. I'm busy at this very moment with the first week of teaching here, but I'll try to look into this as soon as possible. It may be that there is just an issue with that example script.
Your point about numpy 2 is right, and it could cause incompatibilities with other dependencies of moments, and possibly with moments itself. For that reason, we've pinned the numpy requirement to <2.0.


chore(console): update packages

Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

done with cnsl-sms-factor


expect that Intl.select fields are stored in lowercase format

This works in combination with https://github.com/dart-lang/intl_translation/pull/70 and helps to resolve https://github.com/dart-lang/intl_translation/issues/69.
Unfortunately, this is quite a breaking change for users that have camelCases or otherwise cased select cases in their translation setup.

This is too breaking indeed, especially since the use case of the translator console does not exist anymore.


how to add placeholder to the new field added?

if I write placeholder: "some text" it doesn't work. I want to add a placeholder to the field newly added. how can I do that?

It is currently not implemented, but it is a really good idea. I am currently using vfg-field-array on a daily basis for a paid project, and I might implement that feature soon (well, when i'll have time...)

It is currently not implemented, but it is a really good idea. I am currently using vfg-field-array on a daily basis for a paid project, and I might implement that feature soon (well, when i'll have time...)


fix fix wrong result precision for add/sub

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run feut

run feut


Support for BuildInfo

Is your feature request related to a problem? Please describe.
Discussed in https://github.com/VirtusLab/scala-cli/discussions/2051

Originally posted by ckipp01 April 23, 2023
I have a use case where I'm building a CLI app. A lot of times with apps like this you want to make sure you can display the version of the app via a command, and many times the value of that version is persisted utilizing a form of BuildInfo where based on git, or something else a file is generated and used for compilation. Is there any way to mimic something like this with scala-cli? All the solutions I'm coming up with request running scala-cli to generate a file first, and then running it again on your main project to utilize that created file. However, it'd be great if this could just be done in a single step somehow. Any ideas?
Describe the solution you'd like
We could have a directive/command-line option exposing BuildInfo data in the project.
//> using build.info

Describe alternatives you've considered
This could potentially also be delivered through code generators. (see #610)
Additional context
See the discussions in #2051 and #610.

cc @ckipp01

👍🏼 thanks for creating this @Gedochao. At least for my specific use case just having
//> using build.info

Wouldn't be enough since it wouldn't really know where to pull the version from. So having #610 would also be necessary to somehow grab the version and store it in the actual build info.


New paper about scene graph-based diffusion model

Hello, thanks for your great repo, it is really awesome. Recently we published our new paper "Diffusion-Based Scene Graph to Image Generation with Masked Contrastive Pre-Training" on arXiv, which proposes a diffusion model that directly conditions on scene graphs to generate images. Could you please add this paper to the repo? Thanks a lot!
arxiv: https://arxiv.org/abs/2211.11138
GitHub: https://github.com/YangLing0818/SGDiff

I will add it asap. Many remarkable papers on diffusion models have been published recently so there will be a slight delay in updating the repo. Thank you again for informing your paper!


Input wanted: create-react-app for build tooling?

I'm thinking about switching out the simple browserify-based client-side build script with some form of create-react-app. Anybody have strong feelings or preferences about this?
Options going this route:

use create-react-app as is. This requires renaming 'client-js' folder to 'src', benefits from future create-react-app updates but no modifications allowed
fork create-react-app/react-scripts and make a sqlpad rendition of it, allowing for customization and merging future updates. (https://github.com/facebookincubator/create-react-app/issues/682)
eject config immediately. Customize as desired but would require ownership of config

I'm leaning towards one of the first 2 options but I'm open to feedback

Published some branches for anyone curious. Leaning towards going the forked react-scripts route. Especially since now there's a scoped package out there...

Made a decision and decided to go with forked react-scripts!


Add option for setting config file name

Add ability to override _CONFIG_FILE_NAME
Adding this because I wanted to use this code to write to a file other than config, in the same format, since the data I wanted to write had more to do with state than with configuration.

@tjprescott requesting a review on this PR. Thank you! :)

Requesting a review. Thank you! @yugangw-msft @derekbekoe


fix: skip to stop BGM when announce file is not founded

PR Type

Improvement

Related Links

Description
音声ファイルが見つからなかった場合、発話をスキップするがBGMの中断も行わないようにする

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.

TIER IV INTERNAL LINK: https://tier4.atlassian.net/browse/T4PB-24519


Gravity Blocks

http://scratch.mit.edu/projects/132
http://phosphorus.github.io/#132
Error: XHR Error
    at XMLHttpRequest.xhr.onerror (http://phosphorus.github.io/phosphorus.js:225:21)

This is a 1.4 project, which we don't support. (#311)


Upgrade llm to torch 1.13.1

Title says it all. @alextrott16 let me know if you'd like to upgrade the BERT example in a second PR, or I'm also happy to take a swing at doing it in this PR.

@abhi-mosaic  If you feel like updating the BERT side in this PR, that's very much OK with me! Tag me in if you hit snags with that part of the code.


Create new unit tests

The software uses unit tests with JUnit but not all logic has test classes. Then add unit tests for the methods of the helpers package classes.

@pedrogneri  can I take this up?

Am working on it
Please merge #47 as the unit test are written on top of that commit

@sa160690
Am working on MatchesGenerator
You may pick up the others. In case of test failures, I have made a fix in #47, it is yet to be merged

@PraveenMathew92, yes sure. I will pick up other classes.

@pedrogneri, I have raised a pull request.

can I give a hand @pedrogneri ?

I've send you a PR (just for the PdfTableGenerator)  ;-)

Working on  TeamGroupsManager

Workgin on  UTF8Control


"Connection timeout" on iOS OpenVPN

Hi,
i just installed PiVPN and I just cannot get it to work. Portforwarding is up and running according to my router.
If I try to connect using the OpenVPN App on iOS I always get a "Connection timeout" after roughly a minute. I would really appreciate any help, I'm very new to the Raspberry so please be precise when asking for any debug information. The OpenVPN log on my phone: https://pastebin.com/CpiuRerC
Console output of pivpn debug
::: Generating Debug Output
:::                                     :::
::              PiVPN Debug              ::
:::                                     :::
::      Latest Commit                    ::
:::                                     :::
commit 7ed7e4652ebe322e51e85a0582907e83eea0d103
Author: Carlos Colaço<EMAIL_ADDRESS>Date:   Fri Oct 20 17:00:23 2017 +0200

    Added info regarding Raspbian Stretch

    added info about support for raspbian Strech, and changed the preference from Jessie to Stretch.

    Edited and merged directly since it is a minor edit.

::: Copy saved to /tmp/debug.txt
:::

Issue
Thanks for any help!
Regards
Marius

it seems to mee that it is not even reaching the server!
Do you have any logs on the server when you attempt to connect?
please provide the output of:
sudo systemctl status openvpn
and
sudo systemctl status openvpn@server
use journalctl -f to keep following the logs when you attempt to connect with your phone from 4G mobile da ( not from within the same network ) and check if openvpn produces any logs related to the connection you are trying to establish, if yes ... please provide it to us.

If you have a key with more than 2048 bits keylength you need to redo the key generation process (or the install alltogether) as i've found out that iOS does not (or cannot) handle such long keys :(
Once i had a key with a length of 2048 bits, it worked without a hitch.


2024.11.1 is Timing out

Thank you for the awesome integration.
I updated the integration to 2024.11.1, it times out on my mesh. I got MX5600 and MX5500 (Child and Parent)
I have latest HA version
I roll back to 2024.10.2 it works fine.

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 477, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 559, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 86, in ban_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 242, in auth_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 32, in headers_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle
    result = await handler(request, **request.match_info)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 81, in with_admin
    return await func(self, request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 285, in post
    return await super().post(request, flow_id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 74, in wrapper
    return await method(view, request, data, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 122, in post
    result = await self._flow_mgr.async_configure(flow_id, data)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 367, in async_configure
    result = await self._async_configure(flow_id, user_input)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 410, in _async_configure
    result = await self._async_handle_step(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 517, in _async_handle_step
    result: _FlowResultT = await getattr(flow, method)(user_input)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/linksys_velop/config_flow.py", line 705, in async_step_device_trackers
    self._devices = await _async_get_devices(mesh=mesh)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/linksys_velop/config_flow.py", line 274, in _async_get_devices
    await mesh.async_initialise()
  File "/usr/local/lib/python3.12/site-packages/pyvelop/mesh.py", line 799, in async_initialise
    await self.async_detect_capabilities()
  File "/usr/local/lib/python3.12/site-packages/pyvelop/mesh.py", line 561, in async_detect_capabilities
    responses: list[tuple[api.Request, api.Response]] = await asyncio.gather(
                                                        ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/pyvelop/mesh.py", line 279, in _async_make_request
    raise err from None
  File "/usr/local/lib/python3.12/site-packages/pyvelop/mesh.py", line 277, in _async_make_request
    req_resp = await req.execute(timeout=self._timeout)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/pyvelop/jnap.py", line 192, in execute
    raise MeshTimeoutError from err
pyvelop.exceptions.MeshTimeoutError: Timeout Error```

Stesso problema. "Configurazione non riuscita"

Can anyone pinpoint when this started to happen?  i.e., did a particular beta cause this?  I'm not seeing the issue here, so I'll need some help narrowing it down.

I think it'll be the integration version that is most interesting.  I am running HA 2024.11.1 without issue, so I'm confident it is most likely the integration.  I'm going to assume that one of the integration betas introduced the issue for all here.

To me, this happened with  linksys integration v2024.11.1 (haven't tried any beta only the sharp release), when I rollback to 2024.10.2 it works fine.
Core 2024.11.1
Supervisor 2024.11.2
Operating System 13.2
Rpi4

If you could try the betas, that would be great.  I think I can guess which one may have caused it, but I'd rather not guess.

2024.11.1b5❌
2024.11.1b4 Did not test
2024.11.1b3 ✔

Thanks.  I'm not sure what change between those versions would have caused this.  However, I have just put 2024.11.2b0 available for install.  I've sped up the gathering of devices when re-configuring and also put a (hopefully) better message in for a timeout on initialising.
If you could give that version a try it would be appreciated.

Your work is what's appreciated...
Yes I can confirm that 2024.11.2b0 is up and running smoothly :thumbsup:

Well, that's good. I wonder if the new initialise routine was running close to the timeout period.  Keep an eye on it.  I'll leave this issue open for a few days just in case.

Well, that's good. I wonder if the new initialise routine was running close to the timeout period for your devices. Keep an eye on it. I'll leave this issue open for a few days just in case.

Actually I did try increasing timeout on my own yesterday from 10 to 15, but no dough.

Did you reload the integration afterwards? I found earlier that if I changed the timeout after the error occurred (I could only force a timeout by dropping my timeout to something like 5 seconds) that I needed to reload the config.
I'll have to get that fixed as well, so that'll probably mean another beta soon.

Hopefully that doesn't matter, but it's worth noting.

Shouldn't matter as the integration just directs requests to whichever nodes are seen as primary.

2024.11.2 is out now.  I had a change of heart and thought that it needed to get out there quite quickly with 3 reports of timeouts already.  I'll close this off as anything else is likely to be related to 2024.11.2 rather than the reported version in this issue.


fix: resolving typing issues in JS codegen

🚥 Fixes #588

🧰 Changes

[x] Update codegen for CJS exports to have the main createSDK export set as export = in the .d.ts file. Having it as export default createSDK was causing issues where the typing was expecting you to to do sdk.default.someOperation even though the way you load the SDK doesn't require you to have to destructure it off default.
[x] This also updates JS type generation to no longer export types in the main SDK entry point as it's causing issues with the affformentioned default export issue and also JS users can't import these types anyways. They'll still have access to them by way of TS intellisense but if you want to import these types you'll obviously need to use TS codegen or load them from types.d.ts. And yes this does work even though the file has a .d.ts extension:

🧬 QA & Testing
This is what using a CJS SDK looks like now:

What it looked like before (with export default createSDK in the index.d.ts file):

Ignore the smoketest failures, the dataset from https://api.apis.guru seems to delete specs when they get version bumps and we run with a local copy of https://api.apis.guru/v2/list.json


Save zipped reports for fastqc

This should move the zipped reports to the resulting output directory. As a (desired) side effect it still removes it from tx_fastqc_out  as previously.

Guillermo;
Thanks for taking a look at this. Does the code currently create zipped reports? I had thought it doesn't do this by default so we might need some parameter tweaking. We'd also need to transfer these into the final upload directory. If all works with just this small change happy to pull it but I'd imagined it would take more tweaks.

Brad;
Sorry I didn't check this. However I think that the zipped reports are actually being created. The code that calls fastqc calls it with the flags -t, --extract, -o and -f, which actually generates the zipped reports and extracts the file without removing it. i.e
$ fastqc -t 4 --extract -o fastqc test.fastq
...

$ ls fastqc/
test_fastqc  test_fastqc.html  test_fastqc.zip

Is that right?
About the final upload dir, I'm not sure I understand what you mean. Doesn't the fastqc_out directory where I'm moving the zip file end up under wrok/qc/<sample_name>/fastqc?
Thanks for your help

Guillermo;
bcbio copies everything into a final output directory so you can remove the work directory on completion. By convention, it's typically ../final relative to the work directory. We'd want to copy the zip file over there if folks will use it. The code that handles conversion to this directory:
https://github.com/chapmanb/bcbio-nextgen/tree/master/bcbio/upload
I don't really know what FastQC does right now. Did this work as you expect with the unit tests (say ./run_tests.sh devel)?

Thanks for the guidance Brad.
So, after running the code (run_tests.sh) and debugging a little bit, I can confirm that fastqc is generating the zipped reports. Also, and that's a bit more unexpected, without further modification it ends up in the final upload directory:
[gcarrasco@node02 tests]$ ls test_automated_output/upload/Test1/qc/fastqc/
fastqc_data.txt     Per_base_N_content.tsv         Per_base_sequence_quality.tsv  Per_sequence_quality_scores.tsv  Sequence_Length_Distribution.tsv
fastqc_report.html  Per_base_sequence_content.tsv  Per_sequence_GC_content.tsv    Sequence_Duplication_Levels.tsv  Test1-sort_fastqc.zip

Note the zipped reports.
The logic I followed in the code is basically "put the zipped reports wherever the rest of the reports are copied", which in this case is fastqc_out. I imagine that bcbio is copying all that's in there to the upload directory.

Guillermo -- thanks so much for testing. Glad this worked out with so few changes -- this is much appreciated.


switched balancer private func endpointsDiff to xslices.Diff

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (d0ba2af) to head (32f0f7d).

Files
Patch %
Lines

internal/balancer/balancer.go
57.89%
8 Missing :warning:

internal/balancer/connections_state.go
42.85%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   42.29%   44.01%   +1.72%
==========================================
  Files         329      265      -64
  Lines       34445    24884    -9561
==========================================
- Hits        14567    10952    -3615
+ Misses      19401    13485    -5916
+ Partials      477      447      -30

Flag
Coverage Δ

go-1.20.x
44.01% <53.84%> (-0.65%)
:arrow_down:

go-1.21.x
?

go-1.22.x
?

macOS
44.01% <53.84%> (+2.17%)
:arrow_up:

ubuntu
?

unit
44.01% <53.84%> (+1.72%)
:arrow_up:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Nuke Quick Start / Tutorial

First attempt to make a hands on doc for artists. To be able to start quickly, and have and idea what can be done in OpenPype withouth reading many pages. Should have companion video.
Throws many things to one heap, global tools with key concepts and admin tips.  Not really sure that is a way to do.
I will redo some pictures and try to do a better layout.

I believe we could reduce this to only one

Also the outline is the part of the template so perhpas we dont need to create it at the beginning.

Unfortunatelly we are not having implemented click to scale image feature so there is no way how to observ this image in better size. Recomandation is to add it to next row and it will hopefully scale to bigger.


Remove a superfluous "s" in AnnotationsLayerBuilder from files in web/

This patch makes the naming consistent with the TextLayerBuilder, and also the new AnnotationLayer, and should thus help reduce possible confusion when working with the code.
Please note that the files were renamed using git mv, in order to preserve blame.

/botio-linux preview

/botio test

Thank you for addressing this; it was bugging me too for some time.


Add repository tag to yaml

One doesn't always want to push to dockerhub.com. This adds a tag to the workflow.yaml file, that allows to define an alternative registry url.
This is possible with the current setup by setting:
organization: my-custom-registry.com/my-project/my-image

However this will make the respective image appear as such locally as well, while often one likes to have my-project/my-image as the local name (I think that is the expected behavior?).
repository is not required and everything behaves as before if the tag is not used. It is also only used for pushing dockers, nowhere else.

I am closing this, I don't think this does what I expected it to do and only worked by chance when I tested it.


Quickopen history is missing

Open a file
Open quick open, that file should be at the top of "Recently opened", but it isn't

I noticed the same behavior today after updating. Went through my settings and Search > Quick Open > Include History is enabled. This is my primary method for navigating through multiple files.

Found a fix to get it into the next insiders. @bpasero please look at 3ba84a8c070b1abcdcb6ca64f2dd6dfd48709078

@roblourens thanks, I am not sure what I was thinking there, this strict property work is already causing bugs. I will probably revert that change altogether because it seems quite risky to me to always work on a different history object...

Looks like the latest update fixed it. Thanks for addressing this so quickly!


Added null check, fix #560

(need testing)

This change is

Should be fixed through 7bbdcac990a8bcf939b8012c642cbe2249e64758 ?

@mar-v-in: The problem has been fixed.
PS: I have just a note, I'm not sure if it is possible but in case the return value of cm.getActiveNetworkInfo() change between line 371 and 372 doesn't it remain in a inconsistent state with the current code?
Here.


Logout is broken in the publisher app

Description:
Logout is broken in the publisher app

Fixed with the following PR
https://github.com/wso2/carbon-apimgt/pull/5749


[BugFix] fix enable sync publish when clone

Why I'm doing:
In previous PR #27055 , we add config enable_sync_publish. When it is true, BE will return publish version request success until all version is queryable.
But when clone happen, BE report both version and max_readable_version to FE in finish clone request,  and FE will use version instead of max_readable_version to update replica version, so it will broken the rule that enable_sync_publish define, because version may not queryable yet.
What I'm doing:
Using max_readable_version instead of version to update replica version when clone finish.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

@mergify backport branch-2.5-bx


influx mock required to perform all bp_test.go tests

./bp_test.go:49: not enough arguments in call to bp.bp.Status
have (SSPMock, rules.Rules)
want (ServiceStatusProvider, PersistenceProvider, rules.Rules)
./bp_test.go:89: not enough arguments in call to s.svc.Status
have (SSPMock, rules.Rules)
want (ServiceStatusProvider, PersistenceProvider, rules.Rules)
FAIL	github.com/unprofession-al/bpmon [build failed]

mock was added in c466e30db983cbde1ff541b4c639400d0ab60615 and 9ba46599d9442297ae0342244a2818dc5f1b656b


Statamic 4 and Laravel 10 support

Fixes issue #15.

@octoper Could you please review this pull request?

Hello @royvanv!
Thank you for the PR!
I'm not using Statamic anymore and because I have a very limited time I can't support it, so I put a looking for maintainers on the repo, if you are interested on helping maintaining it you are welcome and you can reach me via email<EMAIL_ADDRESS>

Thanks for merging.
Unfortunately v2.0.0 still only lists statamic/cms: ^3.3 as dependency. See the Packagist page for version 2.0.0: https://packagist.org/packages/octoper/statamic-blade-components#2.0.0

Going to take some look and today, thank's for reporting that!


Add notifiyDataSetChanged()

When I try to call notifiyDataSetChanged() on the adapter or listview, I get an error message that it can't be resolved. However, when I use the swipe menu to delete a list item, I obviously need my list view to be updated subsequently. Am I missing anything?

i also get the error issue too

Facing same issue

Date: Thu, 14 Jul 2016 11:15:56 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [baoyongzhang/SwipeMenuListView] Add notifiyDataSetChanged() (#65)
Facing same issue
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
Use this...
compile 'com.nhaarman.listviewanimations:lib-core:3.1.0@aar'
compile 'com.nhaarman.listviewanimations:lib-manipulation:3.1.0@aar'
compile 'com.nhaarman.listviewanimations:lib-core-slh:3.1.0@aar'

This library is working. Instead of directly importing, add jar file to your android project and use the library.
Will work like a charm.


NOJIRA: Use index.md

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] documentation is changed or added

Description of change

so Jekyll will recognize file is starting point for folder.

:thinking: hmm,
earlier I was getting 404 when I tried to hit https://jasig.github.io/uPortal/implement/ or https://jasig.github.io/uPortal/developer/
Now it appears to be working.
:man_shrugging: maybe it was a bad build before.
Closing this PR out.
Thanks for catching that @apetro!


UPDATE: Relaxed country props in CountryFlag

Accept nullable string as code prop. Fallback to "anywhere" on unknown country code.
This Pull Request meets the following criteria:

[x] Tests have been added/adjusted for my new feature
LiveURL: https://orbit-components-relaxed-country-flag.surge.sh

cc @wEprous @tomashapl
From my point of view, why not. But it would be great if we logged somewhere if it fallback to anywhere so we have some indication about missing flag.

Added warning into console on unsupported country code. Please review

So what do you think @wEprous @tomashapl ?

@michalsanger Great 👏  Thanks

@tomashapl how do you it in this project? Could you point me to some code?

LGTM.
I'm not sure if a giving a console warn to a developer only is good enough in terms of maintainability. For me, it would be the best solution to have a log in Sentry and also give a developer warning.

@michalsanger This warning should not be called in production by design. It uses __DEV__ behind the scenes.

LGTM.
I'm not sure if a giving a console warn to a developer only is good enough in terms of maintainability. For me, it would be the best solution to have a log in Sentry and also give a developer warning.

We will have also bad requests in sentry, but we don't want to spam client's console

@michalsanger This warning should not be called in production by design. It uses __DEV__ behind the scenes.

So this shou

@michalsanger This warning should not be called in production by design. It uses __DEV__ behind the scenes.

So this should be installed as only dev dependencies ?

So could be @kiwicom/js installed just only in dev dependencies?

@tomashapl Probably not in your case because it's a function that's gonna be called in production. In our case (monorepo) we can have it as a dev dependency because it's being stripped out completely (WIP).
You'd have to use https://www.npmjs.com/package/@kiwicom/babel-preset-kiwicom but the invariant/warning removal is not implemented there yet. Awaiting here: https://gitlab.skypicker.com/incubator/universe/issues/432
TL;DR: keep to as a regular dependency for now.

So could be @kiwicom/js installed just only in dev dependencies?

@tomashapl Probably not in your case because it's a function that's gonna be called in production. In our case (monorepo) we can have it as a dev dependency because it's being stripped out completely (WIP).
You'd have to use https://www.npmjs.com/package/@kiwicom/babel-preset-kiwicom but the invariant/warning removal is not implemented there yet. Awaiting here: https://gitlab.skypicker.com/incubator/universe/issues/432
TL;DR: keep to as a regular dependency for now.

Thanks for explanation 👏 We add implement @kiwicom/babel-preset-kiwicom to our backlog.

Ups, I forget to change also the src/CountryFlag/README.md

@tomashapl @wEprous could you check this PR please? It has been here for more then one month.


Better handling of stack traces in Zones

feat(Error): Rewrite Error stack frames to include zone
The errors caused by the Zone contain extra stack frames. This feature
removes the confusing stack frames as well as appends the zone for each
stack frame to get a better understanding of the error messages.
Improved Error:
Error.spec.js:54 Error: Inside [InnerZone]
    at insideRun (Error.spec.js:31) [InnerZone]
    at Zone.run (zone.js:100) [<root> => InnerZone]
    at testFn (Error.spec.js:29) [<root>]
    at Zone.run (zone.js:100) [ProxyZone => <root>]
    at Object.eval (Error.spec.js:19) [ProxyZone]

Original Error:
Error.spec.js:53 Error: Inside
    at ZoneAwareError (zone.js:652)
    at insideRun (Error.spec.js:31)
    at ZoneDelegate.invoke (zone.js:216)
    at Zone.run (zone.js:100)
    at testFn (Error.spec.js:29)
    at ZoneDelegate.invoke (zone.js:216)
    at Zone.run (zone.js:100)
    at Object.eval (Error.spec.js:19)

LGTM


Add some kind of Pytest status monitoring endpoint to the SRI web services

At presence, the web services POSTs a testrun request, and uses a session id to get test run results, if and when they are available (this service can "time out" with a null response if the PyTests are not yet completed).
SRI Test runs are likely to be somewhat long-running. It would be helpful to provide an intermediate endpoint action to communicate status updates of the running of the Pytest test run before completion (to allow UI refresh).
This status feedback should also check if the Pytest run worker process is still "alive".

Basic /status endpoint working.


OK, for real, this issue will work!

Kumusta! This is the GitHub issue tracker bot for Adrienne. Thank you for leaving an issue, we will respond shortly. For now, check out the Developer Hub https://developer.mongodb.com


rust: optional protobuf schema and direct protobuf message writing support

Encoding protobuf message in mcap logs is a common use case that could be streamlined.  Currently a file descriptor set must be assembled and write to the schema manually, and messages must be encoded into a buffer before writing that buffer to mcap.
There are two popular rust protobuf crates: protobuf and prost.   protobuf provides reflection and json encoding support, whereas prost generates more idiomatic rust structs with less heap allocations.  Supporting both may be relevant to this project, however working with protobuf may be easier since message descriptors can be accessed via the MessageDyn trait, while prost (or protoc) can be configured to generate a file descriptor set file that must be loaded in order to write file descriptor sets to the mcap schema.
At the moment I'm using protobuf and am more familiar with it.
A protobuf file descriptor set schema may be naively built:
fn protobuf_schema(
    message_descriptor: &protobuf::reflect::MessageDescriptor,
) -> Result<Arc<Schema<'static>>, protobuf::Error> {
    fn collect_dependencies(
        descriptor: &protobuf::reflect::FileDescriptor,
        already_collected: &mut HashSet<String>,
    ) -> Vec<protobuf::descriptor::FileDescriptorProto> {
        let mut descriptors = vec![descriptor.proto().to_owned()];
        already_collected.insert(descriptor.name().to_string());
        for dep in descriptor.deps() {
            if already_collected.get(dep.name()).is_none() {
                descriptors.extend(collect_dependencies(dep, already_collected));
            }
        }
        descriptors
    }

    let data = Cow::Owned(protobuf::Message::write_to_bytes(
        &protobuf::descriptor::FileDescriptorSet {
            file: collect_dependencies(message_descriptor.file_descriptor(), &mut HashSet::new()),
            ..Default::default()
        },
    )?);

    Ok(Arc::new(Schema {
        name: message_descriptor.full_name().to_string(),
        encoding: "protobuf".to_string(),
        data,
    }))
}

It would be nice for this functionality to be built into the rust mcap library ex.
Writer::add_protobuf_channel(&mut self, topic: String, message_descriptor: &protobuf::reflect::MessageDescriptor, metadata: Option<BTreeMap<String, String>>) -> Result

In order to encode a message, we can do:
fn write_protobuf_message<W: Write + Seek>(
    writer: &mut mcap::Writer<W>,
    channel_id: u16,
    sequence_number: u32,
    log_time: SystemTime,
    publish_time: SystemTime,
    message: &dyn protobuf::MessageDyn,
) -> anyhow::Result<()> {
    // TODO: ideally use write_to_writer_dyn to avoid extra allocation and copy
    let data = message.write_to_bytes_dyn().context("encode protobuf")?;
    writer
        .write_to_known_channel(
            &mcap::records::MessageHeader {
                channel_id,
                sequence: sequence_number,
                log_time: log_time
                    .duration_since(SystemTime::UNIX_EPOCH)
                    .unwrap_or_default()
                    .as_nanos() as u64,
                publish_time: publish_time
                    .duration_since(SystemTime::UNIX_EPOCH)
                    .unwrap_or_default()
                    .as_nanos() as u64,
            },
            &data,
        )
        .context("write mcap message")
}

however this requires encoding the message into a temporary buffer before writing to the mcap writer.
Writer could potentially expose a method to borrow the a Write object ex. Writer::message_writer(&mut self, channel_id, sequence, log_time, publish_time) -> &MessageWriter where MessageWriter implements Write and computes the message length for you to allow using protobuf::MessageDyn::write_to_writer_dyn(&self, w: &mut dyn Write)
The library could also expose a convenience method ex. Writer::write_protobuf_message_to_existing_channel(channel_id, sequence, log_time, publish_time, message: &protobuf::MessageDyn).
If zero-copy encoding is to be supported for prost too,  we could have something like Writer<W: BufMut>::write_prost_message_to_existing_channel(channel_id, sequence, log_time, publish_time, message: &prost::Message)
This functionality could be added as optional features in the mcap crate, or as additional crate(s) implementing an extension trait on Writer.

I don't think we should put any protobuf specific dependencies or requirements in the base mcap library since there are users of that who do not use protobuf and should not need to bring in protobuf dependencies to build on top of the base library.
The way we've supported this in our other languages is to provide a separate support package which simplifies some of the common use cases for a specific serialization format. It would make sense to have a mcap_protobuf crate to handle some of these common tasks. Possibly even one for each variant of protobuf library if we have enough demand for that.

@defunctzombie makes sense.  Cargo optional features could also work, but I have no strong feelings.
How about adding a mechanism for zero-copy message writing?

@neilisaac

How about adding a mechanism for zero-copy message writing?

Seems sensible. Can you write up a separate feature request for that with specific note for how we would change the API to support this?

@defunctzombie I added https://github.com/foxglove/mcap/issues/693


x/tools/go/analysis/analysistest: support multiple, mutually exclusive suggested fixes

A single diagnostic may have multiple suggested fixes. For example, staticcheck has an analysis that finds double negations (!!x) and provides two suggested fixes: turn into a single negation, or remove the double negation.
analysistest doesn't support testing such an analysis. Currently, all suggested fixes get applied to the same source, and the result is compared against a single golden file. For example, !!x turns into !xx. In the worst case, the final result will not even be syntactically valid.
When dealing with just one diagnostic per analysis run, it would be pretty straightforward to adopt a file format like the one used by the Playground to support multiple files (https://play.golang.org/p/KLZR7NlVZNX). The virtual files could be named according to the descriptions of the suggested fixes, to avoid depending on the order of suggested fixes. This would result in a golden file looking something like this:
-- turn into single negation --
package pkg

func fn(x bool) { _ = !x }

-- remove double negation --
package pkg

func fn(x bool) { _ = x }

This, however, doesn't really work if an analysis produces multiple diagnostics, especially if different diagnostics have different sets of suggested fixes. If d1 has the fixes f1 and f2, and d2 has the fixes f1 and f3, what should the golden file look like? Should there be one virtual file for every unique suggested fix, identified by the fixes' descriptions?
I'm very open to better ideas.
/cc @matloob @ridersofrohan

I'd be open and welcome something like this, but I don't know that I have better ideas for how to handle multiple fixes produced by multiple diagnostics.
I think adding a virtual file for each unique suggested fix is a good idea, but we could potentially run into the same problem again if there are two diagnostics producing fixes with the same name that affect overlapping areas of code. (Which may or may not be too rare to matter).

but we could potentially run into the same problem again if there are two diagnostics producing fixes with the same name that affect overlapping areas of code

I'm not sure how we could fix that without having a one to one mapping between a single diagnostic and a single golden file. But in most cases, the user could achieve this by splitting the fixture into multiple files, each triggering a single diagnostic.
I've implemented my suggested idea to get a feel for the golden files. It's not terrible, but suffers somewhat from well-written messages for suggested fixes. For example, SA1016 flags untrappable signals (like os.Kill) and offers to remove the signal, or use a more appropriate signal. For UX, the message contains the names of the signals, so for my fixture that tests with os.Kill and syscall.SIGKILL, there are 4 possible suggested fixes

remove syscall.SIGKILL from list of arguments
remove os.Kill from list of arguments
use syscall.SIGTERM instead of syscall.SIGKILL
use syscall.SIGTERM instead of os.Kill

which results in this somewhat unwieldy golden file: https://play.golang.org/p/b1cVvL7Y_rV – I might be able to clean it up by having multiple files, one per signal, but multiple files rarely make things easier to use.

If this is the best we can come up with, then I'll send a CL shortly.

Yeah, I can't think of a anything significantly better for now


De-alias type aliases when it resolves into a function

I'm trying to use matthewsj/elm-ordering as dependency. Elixir source code is generated OK. But Elixir compiler is not happy with generated source code. Elixir version 1.5.3. Example
Example:
fromLessThan : (a -> a -> Bool) -> Ordering a
fromLessThan lt x y =
    if lt x y then
        LT
    else if lt y x then
        GT
    else
        EQ

->
  @spec from_less_than((any -> (any -> boolean))) :: ordering(any)
  curry from_less_than/1
  def from_less_than(lt, x, y) do
    cond do
      lt.(x).(y) -> :lt
      lt.(y).(x) -> :gt
      true -> :eq
    end
  end

Compiler
== Compilation error in file elm-deps/tim2CF/elm-ordering/1.1.1/src/Ordering.elchemy.ex ==
** (CompileError) elm-deps/tim2CF/elm-ordering/1.1.1/src/Ordering.elchemy.ex:87: spec for undefined function from_less_than/1
    (stdlib) lists.erl:1338: :lists.foreach/2
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6

Oh wow. I've never seen a type alias to be used that way
So the Ordering resolves from
fromLessThan : (a -> a -> Bool) -> Ordering a

to
fromLessThan : (a -> a -> Bool) -> (a -> a -> Order a)
```.

It probably was working before, but got bugged after aliases were made resolving to argumented types in #31

Right now there is an exception of resolving type aliases when applied to Structs polymorphism (because Elixir has none).
It should be enough to just add functions as an another exception

Thanks!
So to make it work right now, I should fork this library and replace
Ordering a

type with
a -> a -> Order

i.e. to not use this type alias?
Library is pretty small so it can be done easily

@tim2CF Yes. You could do that. But the library still uses valid code, so it definitely should be working. It seems like a minor change. I should be able to do that today. I'll keep you updated

Ok!

Hello @wende
It's different issue, but can be reproduced with the same library<EMAIL_ADDRESS>Elm code
explicit : List a -> Ordering a
explicit items x y =
    let
        scanForEither items =
            case items of
                z :: zs ->
                    if z == x then
                        scanForY zs
                    else if z == y then
                        scanForX zs
                    else
                        scanForEither zs

                [] ->
                    EQ

        scanForX items =
            case items of
                z :: zs ->
                    if z == x then
                        GT
                    else
                        scanForX zs

                [] ->
                    LT

        scanForY items =
            case items of
                z :: zs ->
                    if z == y then
                        LT
                    else
                        scanForY zs

                [] ->
                    GT
    in
        if x == y then
            EQ
        else
            scanForEither items

compiles to Elixir code
  @spec explicit(list(any), any, any) :: Elchemy.XBasics.order
  curry explicit/3
  def explicit(items, x, y) do
    scan_for_either = rec scan_for_either, fn items -> case items do
      [z | zs] ->
        cond do
          (z == x) -> scan_for_y().(zs)
          (z == y) -> scan_for_x().(zs)
          true -> scan_for_either.(zs)
        end
      [] ->
        :eq
    end end
    scan_for_x = rec scan_for_x, fn items -> case items do
      [z | zs] ->
        if (z == x) do :gt else scan_for_x.(zs) end
      [] ->
        :lt
    end end
    scan_for_y = rec scan_for_y, fn items -> case items do
      [z | zs] ->
        if (z == y) do :lt else scan_for_y.(zs) end
      [] ->
        :gt
    end end
    if (x == y) do :eq else scan_for_either.(items) end
  end

and Elixir compiler says
== Compilation error in file src/Ordering.elchemy.ex ==
** (CompileError) src/Ordering.elchemy.ex:129: undefined function scan_for_y/0


Typo in command

az networkfabric l2domain create
--resource-group "ResourceGroupName"
--resource-name "example-l2domain"
--location "eastus"
--nf-id "/subscriptions/xxxxxx-xxxxxx-xxxx-xxxx-xxxxxx/resourceGroups/NFResourceGroupName/providers/Microsoft.ManagedNetworkFabric/NetworkFabrics/NFname"
--vlan-id  750
--mtu 1501
There should be a space between "--vlan-id 750" and "" in this command.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c3c35147-6b44-d121-5c34-12d07f7cb453
Version Independent ID: 82014f0b-abd6-13ac-a342-97c11d10c72e
Content: Azure Operator Nexus: Configure L2 and L3 isolation domains
Content Source: articles/operator-nexus/howto-configure-isolation-domain.md
Service: azure-operator-nexus
GitHub Login: @jdasari
Microsoft Alias: jdasari

@saitbaransiyahhan
Thanks for your feedback! We will investigate and update as appropriate.


v1.9.0-RC2 - FreeBSD jenkins build failure

Hi there,
Any chances that someone take a look at the FreeBSD jenkins job that fails since 14 days ? =)
Not an expert in this field but seems that it is only a workspace issue :
https://jenkins.dockerproject.org/job/Docker Master (freebsd)/1555/console
Caused by: hudson.plugins.git.GitException: Command "git -c core.askpass=true fetch --tags --progress https://github.com/docker/docker.git +refs/heads/*:refs/remotes/origin/*" returned status code 1:
stdout:
stderr: remote: Counting objects: 8, done.
remote: Total 8 (delta 5), reused 5 (delta 5), pack-reused 2
From https://github.com/docker/docker
   75128c4..9328fc7  master     -> origin/master
error: Cannot lock ref 'refs/remotes/origin/release/1.8': 'refs/remotes/origin/release' exists; cannot create 'refs/remotes/origin/release/1.8'
 ! [new branch]      release/1.8 -> origin/release/1.8  (unable to update local ref)
error: Cannot lock ref 'refs/remotes/origin/release/v1.9': 'refs/remotes/origin/release' exists; cannot create 'refs/remotes/origin/release/v1.9'
 ! [new branch]      release/v1.9 -> origin/release/v1.9  (unable to update local ref)
error: some local refs could not be updated; try running
 'git remote prune https://github.com/docker/docker.git' to remove any old, conflicting branches

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Thanks for reporting! I'll try to get someone to have a look

ping @kvasdopil we may need your help here :heart:

@thaJeztah hi, i'll take a look asap, thx for ping

Thanks @kvasdopil !

The error doesn't seem to be related to freebsd build, looks like some kind of repository misconfiguration, maybe @jfrazelle could take a look.
However freebsd build is also broken, i'll try to fix it.

FreeBSD build faild on git fetch in jenkins:

git -c core.askpass=true fetch --tags --progress https://github.com/docker/docker.git +refs/heads/:refs/remotes/origin/
ERROR: Error fetching remote repo 'origin'

It's looks like simple or it not important?
Anyway thank you for your great job!

Freebsd machine is stopped for 4 months and also there is no active work on it. I'm closing this issue for now. Feel free to post new.


chore(DEVHAS-683): Delete HAS SLOs

Removes the HAS SLO alerts
Removes the tests for the removed alerts
Removes the SLO dashboard widgets for HAS

I also checked the availability metrics dashboard and didn't see anything specific to HAS to remove

/retest


Add UnixCredentials support on FreeBSD/DragonFly

This allows working with SCM_CREDS messages, which are like SCM_CREDENTIALS on Linux, but slightly different (always overwritten by the kernel, contain a bit more info — euid and groups).
With this PR, it is possible to write portable code that would use the appropriate message for the platform, but one remaining quirk is that PassCred thing still has to be present and cfg'd to Linux.
Adding the SCM_CREDS constant to libc: https://github.com/rust-lang/libc/pull/1740

The libc PR (https://github.com/rust-lang/libc/pull/1740) has apparently been merged, if that may be of use to this one.

ping @myfreeweb .  It looks like the libc PR has been merged.  Can you finish this one now?

It's still not released to crates.io.. Okay, switched to git for now.


eventhubs-emulator crashes on linux/helix

Starting mcr.microsoft.com/azure-messaging/eventhubs-emulator:latest on linux/helix fails. It fails on codespaces too.
fail: a.a.aaW[0]
      Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy
fail: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[103]
      Health check Emulator Health Check with status Unhealthy completed after 26546.109ms with message 'Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy'
Retry 1 encountered an exception: Emulator Health Check failed.. Waiting 00:00:00 before next retry.
fail: a.a.aaW[0]
      Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy
fail: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[103]
      Health check Emulator Health Check with status Unhealthy completed after 27109.5539ms with message 'Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy'
Retry 2 encountered an exception: Emulator Health Check failed.. Waiting 00:00:00 before next retry.
fail: a.a.aaW[0]
      Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy
fail: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[103]
      Health check Emulator Health Check with status Unhealthy completed after 26307.1877ms with message 'Emulator Start up probe Unsuccessful. MetadataStore Health status: Unhealthy BlobStore Health status: Unhealthy'
An error occurred: Emulator Health Check failed.

This needs to be investigated to see if it something in our setup or a bug with the docker image.
Example of a failing build.

This is fixed now.

This is fixed now.

Confirmed. Closing the issue.


PRD: [Cody Ignore] Enterprise users cannot use ignored repos as context for Generate Unit Test Command

Description:
When an enterprise admin has configured Cody to allow/ignore repos, Cody Generate Unit Test command must not be available to the user
As a user on an enterprise instance that has Cody allow/ignore repos configured...
P0: I cannot run the Cody Generate Unit Test command on any excluded code
P1: I am able to understand that I cannot use the command because the code has been excluded by my administrator
P2: I see guidance in the UX for how to request that my admin include an excluded repo
Objectives:
Cody does not send any code from excluded repos to the LLM when a user is using Cody's Generate Unit Test command feature.
Acceptance Criteria:

When the user selects content in an excluded file and attempts to perform a Generate Unit Test command operation using the context menu, they should not be able to complete the operation

When the user selects content in an excluded file and attempts to perform a Generate Unit Test command operation using the sidebar menu, they should not be able to complete the operation

When the user selects content in an excluded file and attempts to perform a Generate Unit Test command operation using a keyboard, they should not be able to complete the operation
When the user selects content in an excluded file and attempts to perform a Generate Unit Test command operation using the command palette, they should not be able to complete the operation

An appropriate notification is provided saying that these operations cannot be completed because the repo is excluded

Design Tasks:
### Design Tasks
- [ ] Add a draft title or issue reference here

Engineering Tasks:
### Engineering Tasks
- [ ] https://github.com/sourcegraph/jetbrains/issues/1169

Related Docs:
Cody Ignore and Cody Allow GA PRD
RFC 910: Cody Ignore GA Implementation
Related VSCode ticket

Just want to call out there's some risk and complexity here:
From the code perspective, there are three unit test commands (generate test/chat, generate test/edit, and add a test case.) I've found some defects and weaknesses in these, noted in the task list in sourcegraph/cody#3642.
From the schedule perspective, #1169 isn't complete yet.

All complete as part of 6.0.0


powershell: 6.1.2 -> 6.1.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/powershell/versions.
meta.description for powershell is: '"Cross-platform (Windows, Linux, and macOS) automation and configuration tool/framework"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/nix/store/khmpfs8mnsis9i663pig8qbwvqq01lm6-powershell-6.1.3/bin/pwsh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 6.1.3 with grep in /nix/store/khmpfs8mnsis9i663pig8qbwvqq01lm6-powershell-6.1.3
directory tree listing: https://gist.github.com/e260172c3d4e14b0e9e6fa27b0f0f248
du listing: https://gist.github.com/a841df9b9a8e69628a59cf95dcccf5ff

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
powershell

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/khmpfs8mnsis9i663pig8qbwvqq01lm6-powershell-6.1.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A powershell https://github.com/r-ryantm/nixpkgs/archive/e0b753cc728239b77b60bcc8027e3135b6ce4b74.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/khmpfs8mnsis9i663pig8qbwvqq01lm6-powershell-6.1.3
ls -la /nix/store/khmpfs8mnsis9i663pig8qbwvqq01lm6-powershell-6.1.3/bin

cc @yrashk for testing.

superseded by #59200


Add support for WSL

We should use powershell.exe to spawn on WSL.

@LitoMore thx for that, I will release it with the next major, merged it for now 🥇


add support for remap shortcut for language change (currently SHIFT+ALT)

Allow key mapping for language change. so an unused key could change keyboard language

hi @friedman30, just to clarify, you're hoping to remap a key (or shortcut) to change your keyboard language?

hi @friedman30, just to clarify, you're hoping to remap a key (or shortcut) to change your keyboard language?

@saahmedm
Right. i want to map a single key (not a combination of keys) to change the keyboard language.

Recent versions of MacOS have a nice feature to switch the language by pressing CapsLock. I like it a lot and I would be happy to be able to do it on my Windows machines.
I tried to map CapsLock to Win+Space in Keyboard Manager, but you can map only key to key and shortcut to shortcut.

this will work when we can map "Win + Space" to a single key like "Caps Lock" with #3290
closing this as a duplicate issue, as it will be resolved with #3290


bug: ion-picker column options overlapping

Bug Report
Ionic version:
[x] 4.3
Current behavior:
AddEventListener to catch ionPickerColChange event, when a Column item changed, filter another column, but those itmes overlapping
below is screen shot
https://ibb.co/wKsPGWx
Expected behavior:

I try set selectedIndex = 0,still not work
Steps to reproduce:

Related code:

    const picker =  await this.pickerCtrl.create({
      buttons: [{
        text: 'cancel',
      }, {text: 'ok', handler: (opt) => {
          const p = picker.getColumn('project')
              .then(data => {
                const index = data.selectedIndex;
                const grade = this.projectItems.items[index].grade;
                const param = {xmname: opt['project'].text,
                    grade: grade,
                    subject: opt['subject'].text,
                    tizuName: opt['tizu'].text,
                    tizuEnName: opt['tizu'].value,
                    fullHostName: window.location.hostname
                  };
                this.checkIsBackScore(param);
              });
        }}],
      columns: [
        {
          name: 'project',
          selectedIndex: 0,
          options: this.projects
        },
        {
          name: 'subject',
          selectedIndex: 0,
          options: this.subjects
        },
        {
          name: 'tizu',
          selectedIndex: 0,
          options: this.tiZus
        }
      ],
      // mode: 'ios'
    });
    picker.addEventListener('ionPickerColChange', async (event: any) => {
      const data = event.detail;
      if (data.name === 'project') {
        const curIndex = data.selectedIndex;

        this.subjects = [];
        Promise.all((data.options[curIndex] as PickerColumnOption).value.map((item) => {
          this.subjects.push({text: item.name, value: item.items, duration: 0, selected: true, disabled: false});
        }));

        this.tiZus = [];
        if (this.subjects.length > 0) {
          Promise.all(this.subjects.map((item) => {
            this.tiZus.push({text: (item as TizuItem).tizu_name, value: (item as TizuItem).tizu_enname, duration: 0,
              selected: true, disabled: false});
          }));
        }

        const columns = [];
        columns.push({name: 'project', selectedIndex: curIndex, options: this.projects, optionsWidth: '100px'});
        columns.push({name: 'subject', selectedIndex: 0, options: this.subjects, optionsWidth: '100px'});
        columns.push({name: 'tizu', selectedIndex: 0, options: this.tiZus, align: 'right', optionsWidth: '100px'});
        picker.columns = columns;

      }
    });
    picker.present();

Other information:

Ionic info:

insert the output from ionic info here

Hi there,
Thanks for the issue. Can you provide a repository with the code required to reproduce this issue? Also can you paste the output of running ionic info?
Thanks!

Hi liamdebeasi,
I have uploaded Source Code on git: https://github.com/pppp0836/WebExam
And Ionic info:
Ionic:
ionic (Ionic CLI)             : 4.12.0
Ionic Framework               : @ionic/angular 4.4.2
@angular-devkit/build-angular : 0.13.8
@angular-devkit/schematics    : 7.3.8
@angular/cli                  : 7.3.8
@ionic/angular-toolkit        : 1.5.1
System:
NodeJS : v11.13.0 (C:\Program Files\nodejs\node.exe)
npm    : 6.7.0
OS     : Windows 10

Hi there,
Thanks for the follow up. I am unable to get past the login screen in your application. Can you provide a repo that only contains a reproduction of the ion-picker issue you are seeing
Thanks!

Hi liamdebeasi,
Can we hold this issue,Because I will go out for a few days,Thank you

Hi liamdebeasi,
I am so sorry  to keep you waiting, and I made a simple demo to test Picker,https://github.com/pppp0836/testPicker
After run this demo, you can select Item on Column 1 ,Column 2 will be refresh,and items of Column occur overlapping.
Thank you very much.


Default value for the position column?

Seems like nil values should be avoided for the position column to avoid problems with ranked_model. (IMHO This should be mentioned in docs!)
Would this be the recommended practice assuming we would want new items to be at the bottom as default?
t.integer :sort_order, :default => RankedModel::MAX_RANK_VALUE

I know this is an old issue, however I am trying to find out what to do when I add raking to an already existing resource.
Should I have done an update on all records setting them to RankedModel::MAX_RANK_VALUE ?

It's been a long time, but I believe what I did was to run inside the migration an update setting the values to an incremental value evenly spaced apart by RankedModel::MAX_RANK_VALUE / MyModel.count. Since my tables were not so big, I had no performance issues. But be aware that if you are running against a table with, perhaps, millions of records that you might have issues.
If you decide to go along this path, just remember this: https://blog.makandra.com/2010/03/how-to-use-models-in-your-migrations-without-killing-kittens/

Thanks for the comment. For me, this was my solution:
class AddSortId < ActiveRecord::Migration[5.0]
  def up
    add_column :items, :sort_order, :integer

    table_name = "items"
    execute "UPDATE #{table_name} SET sort_order = id;"
  end

  def down
    remove_column :items, :sort_id
  end
end

This is similar to other proposed solutions above, where the sort_order matches the id at first. I haven't had any problems with this so far, but I am also working on old code with a bunch of hackey code invovled, so this might not be a one-size-fits-all solution.

Closing. I added a check for this on boot.


Split jobs into dedicated sync and async jobs

Description of changes:
This splits the BuildAndTest job into two: one for sync and one for async Rust. This allows us to cache the compilation artifacts per job, which should lead to faster builds. The caching is also implemented in this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.52%. Comparing base (8f7d38b) to head (4db1fb2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   89.52%   89.52%
=======================================
  Files         173      173
  Lines       31450    31450
=======================================
  Hits        28156    28156
  Misses       3294     3294

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Async build and test for sure is much faster now. Thanks!


Add access to debug window

Button to open the debug window is available in options dialog
Note : when debugging from VS console output is sent to VS directly and not in the debug window

Implemented. under issuing


Bootstrap Part 1: Small changes

This is a 3 part PR, only part 3 runs

https://github.com/keybase/client/pull/13245
https://github.com/keybase/client/pull/13246

The goal of these PRs is to cleanup and speed up the bootstrapping process.
A lot of the code this touches is very very old
This:

[x] Simplifies push logic
[x] Creates a more structured handshake/logout process so various sagas can register to do processing during that time correctly
[x] Removes races in figuring out where to navigate to on start
[x] Navigates directly to the target location
[x] Removes the keys animation on resume
[x] Uses quicker rpc to get provisioned usernames
[x] Moves badge handling logic into various sagas instead of being localized in a single one
[x] Parallelizes more things on startup
[x] Removed some pointless extras paths in the login route structure
[x] New colored logging for redux/engine

This PR focuses on smaller changes across a bunch of files

@keybase/react-hackers this is ready

@keybase/react-hackers this is big enough and important enough that this PR needs at least 2 thumbs . Please test part 3 on desktop and mobile. especially the push flows

higher level stuff:

Inbox doesn't reload on logout -> login
Linking to a profile in the app doesn't take you to the profile
Push doesn't take me into the conversation on mobile


germ line stem cell (sensu Vertebrata / sensu Nematoda and Protostomia)

germ line stem cell has two subclasses for vertebrate and protostomes:

germ line stem cell (sensu Vertebrata);
germ line stem cell (sensu Nematoda and Protostomia).

(And likewise for the sex-specific female germ line stem cell and male germ line stem cell.)
I am not sure there is a need to have distinct classes for vertebrates and protostomes in that case. I am more familiar with insect biology, but from my vague recollection of vertebrate developmental biology I don’t think germ line stem cells differ that much across taxa.
My feeling is that all those (sensu something)-classes should be avoided when possible, and only used when there is a genuine need to distinguish between cells that are similarly named but are actually completely different. If the only differentia of a germ line stem cell (sensu Vertebrata) relative to a generic germ line stem cell is that it is specific to vertebrates (and likewise if the only differentia of a germ line stem cell (sensu Nematoda and Protostomia) relative to a generic germ line stem cell is that it is specific to protostomes), then to me it suggests those terms really have no reason to exist.
If vertebrate and protostome germ line stem cells really differ enough to warrant distinct classes, then those terms should get proper definitions that explain at least summarily what the differences are.

Agreed.


Provide way to check sign of current is correct

The voltage of a battery should go up as it is charged. Can we use to warn if a sign convention for current is flipped?

Yes. However, it is not as simple as look at the voltage now and in the previous step, as there can be instrument error. But some form of dV/dt analysis could be performed to warn users of our convention.

A whole set of "gut checks" might be reasonable, such as verifying the sampling frequency is not way too small or large (suggesting in issue in the units for times) or inconsistencies between cycling statistics and raw data.


Finalize Github workflow logic for running recipes in feedstocks.

The proposed workflow logic for running recipes in feedstock repos is described here https://github.com/pangeo-forge/roadmap/blob/master/doc/adr/0001-github-workflows.md but we should probably review for a consensus decision and address some open questions around versioning, updating existing zarr archives.
The initial naive Github action will register and run the full recipe (replacing an existing zarr store if it exists) for each recipe in the repository when a new release tag is created.  While functional, there are several issues with this approach which should be addressed.

The action should really work in a similar fashion to the existing staged-recipes PR testing workflow which only proceeds when the PR includes changes to a meta.yaml file.  I'm unsure how diff should be used with a release tag in order to determine the listing of meta.yaml files that have been updated in a release.  There is also the possibility that the underlying recipe code can change with no corresponding change to the meta.yaml so I would suggest the possibility of including a root level version property to the meta.yaml spec to facilitate flagging with diff.

The current approach will naively replace the entire existing zarr archive when the recipe is re-run.  (Additionally, I would like clarification on how pangeo-forge-recipes will handle the case of writing to object storage when the target archive already exists.). There has been previous discussion about incrementally updating existing archives but this poses a few questions in relation to workflows.  How should underlying changes to source data (notably from reprocessing efforts) be handled?  How should intermediate cache files invalidation be handled for source data changes?

Should our zarr target structure patterns include some sort of versioning scheme which is tied to our release tagging?  This simplifies many aspects of the workflow process but may be confusing for end users when they encounter multiple versions of the archive.

Another open question around feedstock workflows concerns how we should manage recipes for different chunking strategies for the same data.  I believe it makes sense that we maintain single feedstocks for a source dataset and that different chunking strategies are treated as unique recipes within the feedstock.  With this approach, users could submit PRs for new chunking strategies and using the diff method discussed above we can run only the recipes which were changed in the release.

As discussed in the coordination meeting today.  I'll push forward with the naive approach initially so that we can close https://github.com/pangeo-forge/staged-recipes/issues/58.  Then @rabernat can schedule a sprint where we can address these open questions and update the workflows.

There is also the possibility that the underlying recipe code can change with no corresponding change to the meta.yaml so I would suggest the possibility of including a root level version property to the meta.yaml spec to facilitate flagging with diff.

Conda forge recipe.yaml (example) distinguishes between "version" (the actual software version, same as on pypi) and "build". To rebuild a recipe, you can increment "build" but not touch "version." We could consider doing the same.

2. The current approach will naively replace the entire existing zarr archive when the recipe is re-run.  (Additionally, I would like clarification on how pangeo-forge-recipes will handle the case of writing to object storage when the target archive already exists.).

For the XarrayZarr recipe, the original dataset will not be deleted. It will follow this code path, trying to open the target dataset. Then it will overwrite all the data variables, but not change the metadata. This is probably not the ideal behavior in all cases. It was done this way to facilitate "append" workflows.

Should our zarr target structure patterns include some sort of versioning scheme which is tied to our release tagging?  This simplifies many aspects of the workflow process but may be confusing for end users when they encounter multiple versions of the archive.

I think this would make lots of sense. It would require an update to ADR 3. Keep in mind that there is a layer of abstraction between the raw object store and the user: the catalog.

4. Another open question around feedstock workflows concerns how we should manage recipes for different chunking strategies for the same data.

For now, It think we can handle this simply as distinct recipes. The recipe names would include a reference to the chunking scheme, e.g. noaa_oisst_space_chunks vs noaa_oisst_time_chunks. This is not super elegant, but it would work and allow us to move forward. We can revisit this if it becomes a very common pattern.
I am eager to organize this sprint, but not sure when would be the best time. My week is once again a bit scattered, without a lot of consistent work time. I could possibly do Wednesday (tomorrow) 6-7 pm CET. Otherwise next week would probably be better.

Should our zarr target structure patterns include some sort of versioning scheme which is tied to our release tagging? This simplifies many aspects of the workflow process but may be confusing for end users when they encounter multiple versions of the archive.

I think this would make lots of sense. It would require an update to ADR 3. Keep in mind that there is a layer of abstraction between the raw object store and the user: the catalog.

👍  and seems like this would also require an update to ADR 3:

The recipe names would include a reference to the chunking scheme, e.g. noaa_oisst_space_chunks vs noaa_oisst_time_chunks

Seems like if we're ever going to want it there, then it's easiest to always include chunking in the target path name.

I could possibly do Wednesday (tomorrow) 6-7 pm CET. Otherwise next week would probably be better.

Available Wednesday (tomorrow) 6-7 pm CET, and also flexible next week.

then it's easiest to always include chunking in the target path name.

Not so sure about this. First of all, the chunking information is trivially accessible from the zarr metadata, so it is easy to discover when building the catalog. Second, I'm not sure how you would "encode" chunking into the path name. But we could try to work this out in a whiteboard session.

I am not sure if this hack is happening, but I'll join https://whereby.com/pangeo now.


Request for a better "laid out" Command Button

Something like this:

Where both the text lines are "inline" with the picture.
As per https://github.com/Smurf-IV/Elucidate

Completed on the 2019-01-05


Style suggestions

Cherry-pickable commits with style suggestions. Feel free to pick only what you like! :-)

Preview of color changes:


The scope of the unsafe block can be appropriately reduced

unsafe blocks encapsulate the code that needs to be correct to ensure soundness.
The value and type of vector are critical here, so reducing the block is (in my opinion) not correct.


godep no longer saving dependencies in Godep.json

Worked fine up until today. Now it wipes all dependencies from Godep.json if run in a project directory. Deleting Godep directory and doing a new save doesn't fix.
LoadPackages [.]
listPackage .
findDirForPath . <nil>
Looking For Package: . in /Users/aaron/documents/gowork/src/github.com/Throckmortra/ryp
&build.Package{
    Dir:            "/Users/aaron/documents/gowork/src/github.com/Throckmortra/ryp",
    Name:           "",
    ImportComment:  "",
    Doc:            "",
    ImportPath:     ".",
    Root:           "",
    SrcRoot:        "",
    PkgRoot:        "",
    PkgTargetRoot:  "",
    BinDir:         "",
    Goroot:         false,
    PkgObj:         "",
    AllTags:        nil,
    ConflictDir:    "",
    GoFiles:        nil,
    CgoFiles:       nil,
    IgnoredGoFiles: nil,
    InvalidGoFiles: nil,
    CFiles:         nil,
    CXXFiles:       nil,
    MFiles:         nil,
    HFiles:         nil,
    SFiles:         nil,
    SwigFiles:      nil,
    SwigCXXFiles:   nil,
    SysoFiles:      nil,
    CgoCFLAGS:      nil,
    CgoCPPFLAGS:    nil,
    CgoCXXFLAGS:    nil,
    CgoLDFLAGS:     nil,
    CgoPkgConfig:   nil,
    Imports:        nil,
    ImportPos:      {},
    TestGoFiles:    nil,
    TestImports:    nil,
    TestImportPos:  {},
    XTestGoFiles:   nil,
    XTestImports:   nil,
    XTestImportPos: {},
}
Done Looking For Package: . in /Users/aaron/documents/gowork/src/github.com/Throckmortra/ryp
&main.Package{
    Dir:            "/Users/aaron/documents/gowork/src/github.com/Throckmortra/ryp",
    Root:           "",
    ImportPath:     ".",
    Deps:           nil,
    Standard:       false,
    Processed:      false,
    GoFiles:        nil,
    CgoFiles:       nil,
    IgnoredGoFiles: nil,
    TestGoFiles:    nil,
    TestImports:    nil,
    XTestGoFiles:   nil,
    XTestImports:   nil,
    Error:          struct { Err string }{},
    Imports:        nil,
}
standard or dest skipping .
New Godeps Filled
&main.Godeps{
    ImportPath:   ".",
    GoVersion:    "go1.6",
    GodepVersion: "",
    Packages:     nil,
    Deps:         nil,
    isOldFile:    false,
}
[]main.Dependency(nil)
[]main.Dependency(nil)
[]string(nil)

What are the contents of /Users/aaron/documents/gowork/src/github.com/Throckmortra/ryp ? What is your $GOPATH?

Also, does go install -v . run / work / install anything?

According to the output, godep didn't find any valid go files in . (GoFiles is nil)

So you either have invalid go files in . (syntax error maybe?) or you need to specificy ./... when you save.

ryp aaron$ ls
Godeps		Procfile	README.md	main.go		manifest.yml	rypresource.go
$GOPATH
-bash: /Users/aaron/Documents/gowork: is a directory
go install runs and installs

https://github.com/Throckmortra/ryp/blob/master/Godeps/Godeps.json
this is the Godeps.json when I committed it, working, 23 days ago

godep save was working then and correctly saved Deps. Running godep save today after updating godep to v62 is wiping my deps on every project I've run it on

v62 was just a doc update.

as well as v61? https://github.com/Throckmortra/ryp/blob/master/Godeps/Godeps.json was commited while using v60

Your $GOPATH is /Users/aaron/Documents/gowork and you are in  /Users/aaron/documents/gowork. So there is still some case related isuses apparently.

retrying with fixed path now

thank god, that fixed it

sorry I'm an idiot. Thank you for your help

Hmm. Thanks for the report. I'll have to figure out a way to test this better. I don't think Travis CI has the option for case insensitive filesystems though.


Add Politeknik Hasnur

@sipha-cron First stage of verification passed, official domain is polihasnur.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@sipha-cron Pull request merged. Thank you!


fix(command-dev-trace): pin traffic mesh agent version

This PR fixes the netlify dev:trace command by pinning the traffic mesh agent to the latest known working version

Just realised one test is still running. Going to wait for it before releasing a new CLI version


Create mock data

Perhaps implementation as seed.ts which uses Prisma ton insert some data? Therefore this could be used in dev env and also in pipeline to seed staging env


Switch changelogs to new format

What does this PR do?

Switch changelogs for individual integrations to the new format, follow-on to https://github.com/DataDog/integrations-core/pull/15983
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Even though a bunch of people got tagged, I'm not waiting for reviews because this is a simple formatting change. For the record.