Rosetta stone for blaze <-> pandas

closes #888

This looks great.  Some suggestions after first glance

Code highlighting
Use same variable name on both sides rather than df and t.
Mention into, perhaps with read_csv, to_csv, from_sql as example operations on the Pandas side

So, I'd rather drink battery acid than make another table with reStructuredText.

got 1 and 2 down, adding the into examples now

Ha!  Maybe raw HTML?  Although I guess code highlighting becomes less fun.

@mrocklin i've addressed 1-3, i think this is good to go

I've issued a PR to your branch here https://github.com/cpcloud/blaze/pull/4

@mrocklin any more comments here?

Only that I shouldn't have held up documentation.  I think that this is a really useful document.

no problemo, bombs away on green


Pseudo Class can't copy to WeChat Edit

I use markdown-css, and I found the html is appear well, but when I copy the html into Wechat Edit, all the Pseudo Class is disappear.
Is there any solution?

Pseudo Class is not supported, you should use inline style css. we will soon publish one online markdown editor product which support many kinds of article theme.


trying to port wct transfer to numpy.

torch and numpy svd are different
u, e, v = torch.svd(conv, some=False)
ut, et, vt = [ x.data.cpu().numpy() for x in (u,e,v) ]
un, en, vn = np.linalg.svd ( conv.data.cpu().numpy() )
print ("diff=", np.sum(np.abs(ut-un)))
print ("diff=", np.sum(np.abs(et-en)))
print ("diff=", np.sum(np.abs(vt-vn)))

result:
diff= 10380.845
diff= 0.007629454
diff= 12652.448

scipy.linalg.svd - same wrong result
diff with tensorflow:
import tensorflow as tf
    tf_sess = tf.Session(config=tf.ConfigProto(device_count={'GPU': 0}) )
    tf_inp = tf.placeholder(tf.float32, shape=conv.shape )

    tfe, tfu, tfv = tf.linalg.svd( tf_inp, full_matrices=True ) #conv.data.cpu().numpy() )

    tfe, tfu, tfv =  tf_sess.run ([tfe, tfu, tfv], feed_dict={tf_inp: conv.data.cpu().numpy() } )
    print ("diff=", np.sum(np.abs(ut-tfu)))
    print ("diff=", np.sum(np.abs(et-tfe)))
    print ("diff=", np.sum(np.abs(vt-tfv)))

diff= 10259.318
diff= 0.03329885
diff= 10259.33

so is your net trained with torch.svd , and there is no way to use your method in other frameworks?
found similar issue pytorch/pytorch#16076
but it is closed

found similar issue https://github.com/pytorch/pytorch/issues/16076
but it is closed

hey @iperov if you see, the diff with tensorflow is also pretty large.
What you are looking at is two different singular value decompositions, both being mathematically correct.
With SVD, you dont need to have a bitwise same result to come back to have a correct answer.
hope this helps.

@iperov You should probably use np.sum(np.abs(ut)-np.abs(un)) since the singular vectors can have opposite signs np.sum(np.abs(vt)-np.abs(vn))
Note that if USV^T is a valid SVD, then (-U)S(-V)^T is also a valid SVD.

@soumith

if you see, the diff with tensorflow is also pretty large.

no.
( numpy.svd == scipy.svd == tf.svd ) != torch.svd

@vishwakftw ok I will continue to port, and check final result.

@iperov First of all, the network training is totally an independent procedure. It is trained for image reconstruction task on MSCOCO dataset. If you are familiar with WCT, this is why their method can stylize arbitrary images with arbitrary styles. After finishing the network training on image reconstruction, we use the pre-trained weight and stylize the features using SVD, which has nothing to do with training.
Secondly, as @soumith pointed out, SVD can provide multiple valid solutions.


[release] Bump MNE to 0.20.dev0

Update circle to track maint/0.19
Bump 0.20.dev0

@massich we have errors like:
E           RuntimeError: stim_channel was supposed to be removed in version 0.20, and it is still present in 0.20.dev0

Planning to fix? If not I can take care of it.


Spelling: 'browsless' -> 'browserless'

This fixes #89.

How did I misspell twice, I promise English is my first language. Thanks.

It's also misspelled in the About:

I guess you copy&pasted it :sweat_smile:

Yes, top right gear icon on https://github.com/trimental/inlyne


Create name layout should be full width

Resolves pivotal issue: "create_name template should use full width, just like edit_name"
https://www.pivotaltracker.com/story/show/143807293

Coverage remained the same at 88.077% when pulling 8aba17e56a1928e097f1490b3c26625960f17a34 on raysuelzer:edit_name_layout into 574c5986db40422653eb65ec89a2e12471f0ea48 on MushroomObserver:master.

Probably more important:
Could the styling of _form_name be changed so that the help text (e.g. form_names_text_name_help) takes advantage of the full available width of the screen?

Will make suggested changes and look at the _form_name styling.  The only thing about full width text is that it is very hard to read.

I have a feel the help text was intentionally set to avoid taking up the full screen.  Which on my monitor would mean everything was a single line, which is hard for the eye to track.  There is a specific setting in the CSS that defines this.  I don't think we want to override it.

Fair point about full-width text.
I was thinking about avoiding/minimizing scrolling and making better use of the screen real-estate.
What do you think about moving the help text to the right.  Or even (much harder) flowing everything into columns, the number of which would depend on screen width.

Coverage remained the same at 88.077% when pulling aa49ababd87ae5dfa334c732120955e4864b15c9 on raysuelzer:edit_name_layout into 574c5986db40422653eb65ec89a2e12471f0ea48 on MushroomObserver:master.

Coverage remained the same at 88.077% when pulling 1b4f934f9a0feb661006b736c81727b0ad16513a on raysuelzer:edit_name_layout into 574c5986db40422653eb65ec89a2e12471f0ea48 on MushroomObserver:master.


IOPS and throughput limits

This PR allows you to specify the IOPS and throughput limit for the VM .guest.rootDisk and for disks of type disks[].emptyDisk.
Limits successfully tested
tool used
Flexible I/O tester - fio
fio args

random read-write

fio --filename=/TESTFILE --rw=randrw --bs=4k --runtime=60 --numjobs=4 --time_based --name=iops --size=512m --group_reporting --direct=1

sequential read

fio --filename=/TESTFILE --rw=read --bs=4k --runtime=60 --numjobs=4 --time_based --name=iops --size=512m --group_reporting --direct=1

VM spec
apiVersion: vm.neon.tech/v1
kind: VirtualMachine
metadata:
  name: andrey-disk-speed
spec:
  restartPolicy: Never
  schedulerName: autoscale-scheduler
  guest:
    cpus:
      min: 1
    memorySlotSize: 1Gi
    memorySlots:
      min: 4
    rootDisk:
      image: neondatabase/vm-debian:11
      size: 20Gi

no limits
random read-write
read: IOPS=54.0k, BW=215MiB/s (225MB/s)(12.6GiB/60001msec)
write: IOPS=54.9k, BW=215MiB/s (225MB/s)(12.6GiB/60001msec); 0 zone resets

sequential read
read: IOPS=119k, BW=466MiB/s (489MB/s)(27.3GiB/60001msec)

IOPS limited to 3000
    rootDisk:
      image: neondatabase/vm-debian:11
      size: 20Gi
      iops: 3000

random read-write
expected:

iops summary = 3000, ~1500 for read and ~1500 for write
throughput summary = 11.7 MiB/s (4 KiB block size * 3000 iops), ~6 MiB/s for read and ~6 MiB/s for write

result:
read: IOPS=1499, BW=5999KiB/s (6143kB/s)(352MiB/60002msec)
write: IOPS=1504, BW=6019KiB/s (6163kB/s)(353MiB/60002msec); 0 zone resets

sequential read
expected:

iops summary = 3000
throughput summary = 11.7 MiB/s (4 KiB block size * 3000)

result:
read: IOPS=3004, BW=11.7MiB/s (12.3MB/s)(704MiB/60002msec)

throughput limited to 100 MiB/s
    rootDisk:
      image: neondatabase/vm-debian:11
      size: 20Gi
      throughput: 100

random read-write
expected:

iops summary = 25.6k (100 MiB/s / 4 KiB block size), ~12.8 for read and ~12.8k for write
throughput summary = 100 MiB/s, ~50 MiB/s for read and ~50 MiB/s for write

result:
read: IOPS=12.8k, BW=50.0MiB/s (52.5MB/s)(3001MiB/60002msec)
write: IOPS=12.8k, BW=50.1MiB/s (52.6MB/s)(3008MiB/60002msec); 0 zone resets

sequential read
expected:

iops summary 25.6k (100 MiB/s / 4 KiB block size)
throughput summary = 100 MiB/s

result:
read: IOPS=25.6k, BW=100MiB/s (105MB/s)(6010MiB/60002msec)

IOPS limited to 3000 and throughput limited to 100 MiB/s
    rootDisk:
      image: neondatabase/vm-debian:11
      size: 20Gi
      iops: 3000
      throughput: 100

expected:

the same as the IOPS-limited test, since in this case the throughput is limited by the IOPS

result:

same results as the test with limited IOPS

@sharnoff

then we'd want to adjust throttling at runtime (can we do that?)

yes, possible change IO throttling settings via QMP

Controlling IOPS globally for a VM, with the ability to adjust it at runtime

It is also possible to create a throttling group and assign all disks to this group. Then the total number of I/O operations per second for all disks cannot be greater than that specified in the group.

Setting IOPS on the VM spec as a multiple of CPU

Yes,. Had the same idea, but I didn't know how many IOPS to set on the CPU core. We can also rely on disk size, like AWS does for EBS gp2 (volumes 33.33 GiB and smaller are provisioned with the minimum of 100 IOPS, volumes larger than 33.33 GiB are provisioned with 3 IOPS per GiB).
In general, I initially added this throttling option to be able to set limits just to prevent situations where a noisy tenant was overloading the disk on the Kubernetes node. If this is not necessary now, we can close this PR and design the I/O throttling idea before implementing it.

In general, I initially added this throttling option to be able to set limits just to prevent situations where a noisy tenant was overloading the disk on the Kubernetes node.

Ah, yeah that makes sense.

If this is not necessary now, we can close this PR and design the I/O throttling idea before implementing it.

Fair enough! Maybe let's leave as a draft so it's still around.
In general, adding IOPS throttling for VMs is one of the prerequisites to enabling overcommit (although, maybe with real SSDs it doesn't need to be) - but yeah, let's talk design & we can get this [or something like it] merged in January. I'd like to be able to move away from the container-io-limiter-hack & allow IOPS proportional to CPUs.

Not needed at the moment.


Cache won't refresh when the GitHub repo is updated

The new implementation pushes caching away from the grlc implementation: now this is responsibility of the reverse proxy (nginx).
The docker image currently pushed into docker's hub (see #28) already incorporates nginx and an automated process of creating this cache via nginx templates.
Importantly, the core issue remains, since pushing the GitHub repo containing the SPARQL queries won't instantly invalidate nginx's cache. This will be worked out in future milestones.


traduction en francais / translate in french

Hello
Bravo for this work, bravo for this application
Attached is the file with the French translations, if you want to include them in a future release.
Localizable.xcstrings.txt

Hello, @freeshare
Sorry for the late reply, and I thank you for this, I'll find some time next week to implement it :)

French will be added to the new version coming in the next update :)


Progress of ad not shown during flash ads?

I noticed that Flash ads do not show a progress bar. Is this intended?
And is this even fixable or is this too hard?

we can do a loading, but the problem is that some ads they load as well their own stuff so you could have  multiple loading bars

I mean the time-bar with how long the ad takes, not the loading btw :)

Sorry for misunderstanding.
Regarding that it should work, but since is optional some ads doesn't provide the time, then in those cases, we don't show.
http://www.iab.com/wp-content/uploads/2015/06/VPAID_2_0_Final_04-10-2012.pdf
if is not implemented, the ad unit returns a -1 value. If the duration is unknown, the ad unit returns a -2. Unknown duration is typical when the user has engaged the ad
There is 2 events that provide that:
VPAID 1: adRemainingTime
VPAID 2 adDuration
If you have an ad that has this feature implemented and is not working with our videoplayer, please share so we can fix. I will confirm if this feature is really working

It seemed all examples on the demo page that use flash do not work currently

Ok after looking at the code we not handling this in the plugin even if VPAIDFLASHClient is triggering this events. I doubt that I can reuse the videojs progress bar

In the short term I can expose this events to videoplayer so if you want a progress bar you can create yourself.
later we can do a progress bar with the same styling has videojs.

Let me know if the first solution is ok for you or not

Yeah that's ok as we have our own progress bar for ads already using an ima plugin which we can probably reuse

like the other issue https://github.com/MailOnline/videojs-vast-vpaid/issues/136 if the ad implements is own progress bar you could have a duplicated progress bar

For our case this does not happen at least, so if we get the events we're ok


FSR 2.2 causes CPU Time to continuously increase until editor becomes unusable.

Godot version
4.2 dev 6
System information
Windows 11 - Vulkan - Nvidia RTX 4070 - intel i5 13600KF
Issue description
Firstly I have no idea how to reproduce this. I just don't know which combination of settings it is.
It happens almost 100% of times, sometimes it just doesn't happen immediately until I reload the project.
If I leave my project open and go take a shower it slowly climbs up to 40ms for the cpu time and then the project is unusable since it's very slow to do anything in it.
If I switch scaling to FSR 1 or bilinear then it doesn't happen but I can also disable some settings such as MSAA and Screen Space AA (it has to be both enabled together with FSR2.2 to start increasing the CPU Time that's the least I can tell right now) and then the CPU time goes slowly down. Though I'm not 100% sure the MSAA and SSAA have anything to do with it, it's hard to tell right now.
You definitely need to ahve something on screen, couple models otherwise I don't really know if it even kicks in or more like it might be taking hours just to see small change in the cpu time.
It happens in just couple seconds/minutes.
I can show a video if you want to see it in action, I really can't pinpoint how to make a minimal reproduction project with this issue.
Steps to reproduce
Currently no idea.
(I maxed all rendering settings I could find, world environment maxed out too, panorama sky included, but even if I turn the world environment stuff off it doesn't change the issue, only FSR2.2 consistently makes this happen or not as far as I can tell.)
Minimal reproduction project
None for now and who knows if I'll even be able to make one. My current project uses models which I can't share.
EDIT: I don't know how to reproduce this but if needed I can stream it and show you whatever you need in my small test project as you ask.

It sounds like it's probably related to https://github.com/godotengine/godot/pull/82451 if you can test it out.

I'll try it just in case it matters though, I have TAA disabled in my project. The fix seems to be related to TAA though, should I still give it a try?

I'll try it just in case it matters though, I have TAA disabled in my project. The fix seems to be related to TAA though, should I still give it a try?

Absolutely, both shared the same problem as the code path is shared between them.

I downloaded the windows editor artifact and I can no longer reproduce it as far as I can tell from couple tests right now. If anything I think the scene is even slightly faster than it was before :D.
So for now thank you very much!
I'll be testing it more when it gets merged into the next dev version I assume in couple weeks but so far it's great apart from a bit of shimmering on models which I assume is related to fsr itself and not this and probably normal artifact of the algorithm I assume (?).
Again, thanks a lot!

I'll be testing it more when it gets merged into the next dev version I assume in couple weeks but so far it's great apart from a bit of shimmering on models which I assume is related to fsr itself and not this and probably normal artifact of the algorithm I assume (?).

I've not been able to find a way to reduce the shimmering so I believe similarly it's inherent to it as DLSS doesn't exhibit the same issues with the same jittering configuration. That said, if FSR 3 rolls out with any improvements to the upscaling part, maybe we'll be lucky and get some progress there.

Should I close this as resolved?

Btw, what I meant by shimmering is this: https://youtu.be/R9q7rnSjtgo
(Unfortunately the video did not capture it entirely, most of the shimmering is not ivisble in the video but check what is visible and then look at the areas I highlight with the mouse cursor, the entire area does it)

Should I close this as resolved?

You can just leave it open until the fix is merged. That way other people can see it if they run into the same problem.

Btw, what I meant by shimmering is this: https://youtu.be/R9q7rnSjtgo (Unfortunately the video did not capture it entirely, most of the shimmering is not ivisble in the video but check what is visible and then look at the areas I highlight with the mouse cursor, the entire area does it)

Yup, for the most part this is pretty much on FSR's side as the implementation only links the resources it asks for and runs the library. It's not much unlike the artifacts that show up in other games that use it. We might look into ways of improving it if it's doable though.


Minor improvements and code formatting

Updated import paths to use github.com/lean-poker/poker-player-go
Extract Game, Player and Card to github.com/lean-poker/poker-player-go/leanpoker
Added quotes to JSON annotations field names
Cleaned up code and formatted using gofmt

Thank you for the pull request!

Yay! :+1:

If you have a bit more time there are two issues with this framework:

All player frameworks should use a dynamic structure as the game state, since the game state is subject to change. I can't keep modifying 15 repos every time the game state is changed. Something like a map should be used.
Please see if it's possible to make sure that when the repo is forked nothing needs to be updated. (See the usage instructions in the README.md... that should be unnecessary.)

It would be really awesome, if you could take care of those :)

I'll try to have a look.

Thanks! :)
On Tue, Aug 4, 2015 at 10:22 AM, Andrew Slotin<EMAIL_ADDRESS>wrote:

I'll try to have a look.
—
Reply to this email directly or view it on GitHub
https://github.com/lean-poker/poker-player-go/pull/1#issuecomment-127521451
.


Add update to statefulset concepts and basic tutorial

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

Fixes #3986

This change is

@kow3ns Looks like webp.yaml is failing Travis CI:
--- FAIL: TestExampleObjectSchemas (0.05s)
	examples_test.go:349: ../docs/tutorials/stateful-application/webp.yaml: webp does not have a test case defined

@chenopis docs LGTM

We still need a tech review for this.

@kow3ns FYI, all feedback must be addressed and LGTMs given by EOD Tue, June 27th so that this can be merged for the 1.7 release on June 28th.

LGTM overall. Some minor comments.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

docs/concepts/workloads/controllers/statefulset.md, line 36 at r1 (raw file):

* Ordered, graceful deployment and scaling.
* Ordered, graceful deletion and termination.
* Ordered automated rolling updates.

Comma after "Ordered" for consistency?

docs/concepts/workloads/controllers/statefulset.md, line 189 at r1 (raw file):

`Parallel` pod management tells the StatefulSet controller to launch or
terminate all Pods in parallel, and to not wait for Pods to becoming Running

"to become"

docs/concepts/workloads/controllers/statefulset.md, line 201 at r1 (raw file):

### On Delete

The `OnDelete` update strategy implements the legacy (1.6 and prior) behavior. When a StatefulSet's

Since it implements the legacy behavior, I'm guessing it's also the default in 1.7+? I think it would be good to say that explicitly if so.

docs/concepts/workloads/controllers/statefulset.md, line 202 at r1 (raw file):

The `OnDelete` update strategy implements the legacy (1.6 and prior) behavior. When a StatefulSet's
`.spec.updateStrategy.type` is set to `OnDelete`. The StatefulSet controller will not automatically

s/. The/, the/

docs/concepts/workloads/controllers/statefulset.md, line 211 at r1 (raw file):

StatefulSet. When a StatefulSet's `.spec.updateStrategy.type` is set to `RollingUpdate`, the
StatefulSet controller will delete and recreate each Pod in the StatefulSet. It will proceed
in the same order as Pod termination, updating each Pod one at a time. It will wait until an

"same order as Pod termination" means high-to-low ordinal, right? It might be good to call that out to remind readers that termination happens in reverse order compared to creation.

docs/concepts/workloads/controllers/statefulset.md, line 216 at r1 (raw file):

#### Partitions

The `RollindUpdate` update strategy can be partitioned, by specifying a

s/Rollind/Rolling/

docs/concepts/workloads/controllers/statefulset.md, line 217 at r1 (raw file):

The `RollindUpdate` update strategy can be partitioned, by specifying a
`.spec.updateStrategy.rollinUpdate.partition`. If a partition is specified, all Pods with an

s/rollinUpdate/rollingUpdate/

docs/concepts/workloads/controllers/statefulset.md, line 219 at r1 (raw file):

`.spec.updateStrategy.rollinUpdate.partition`. If a partition is specified, all Pods with an
ordinal that is greater than or equal to the partition will be updated when the StatefulSet's
`.spec.template` is updated. All Pods with an ordinal that is less than partition will not

Either "less than the partition" or "less than partition".

docs/concepts/workloads/controllers/statefulset.md, line 220 at r1 (raw file):

ordinal that is greater than or equal to the partition will be updated when the StatefulSet's
`.spec.template` is updated. All Pods with an ordinal that is less than partition will not
be updated, and, even if they are deleted, they will be recreated at the current version. If a

"current" version is ambiguous here. It could mean the template that's live in the StatefulSet spec right now (the new one). Should we say "previous" version?

docs/tutorials/stateful-application/basic-stateful-set.md, line 1003 at r1 (raw file):

### OrderedReady Pod Management

`OrderedReady` pod management is the default for StatefulSets. It tell the

s/tell/tells/

docs/tutorials/stateful-application/basic-stateful-set.md, line 1004 at r1 (raw file):

`OrderedReady` pod management is the default for StatefulSets. It tell the
StatefulSet controller to respect the the ordering guarantees demonstrated

s/the the/the/

docs/tutorials/stateful-application/basic-stateful-set.md, line 1014 at r1 (raw file):

Pod.

{% include code.html language="yaml" file="web.yaml" ghlink="/docs/tutorials/stateful-application/webp.yaml" %}

Should it say file="webp.yaml"?

Comments from Reviewable

@kow3ns Ping me when the tech review comments have been addressed. Thx

@chenopis addressed

Ok, I'm going to merge this. Any additional changes can be made in a separate PR.


Add task result

Add generic task result with value.
Add with implicit conversion to value and bool.

Create branch from main
issue-43-add-task-result


Feature request: "terminus site tag [add|remove]"

Add the ability to add and remove tags (the tags that appear on the organization dashboard) to/from a site.
Use case:  When we run our script which creates and installs sites, we'd like to add one or more tags that appear on our organization dashboard.
Linking: https://github.com/pantheon-systems/cli/issues/156

Tags live on the join between sites and organizations. So this command would require an --org= argument as well to determine in which org the tags will be applied for this site.

+1 We are starting to get more and more requests for this


Turn keymaps off

Hello!
I saw some key mappings on dev_setup function in init.lua file.
How can I turn these off without modifying otter's sources?
Thx.

the dev setup is just for development and testing. The regular otter.setup and otter.activate functions don't set any keybindings.

@jmbuhr I hope so, but my gr key is still replaced by the setting on dev_setup function.

My lazy.nvim setup is like below. I set dev as false intensionally.
  {
    "jmbuhr/otter.nvim",
    dev = false,
    dependencies = {
      { "neovim/nvim-lspconfig" },
    },
    opts = {
      buffers = {
        set_filetype = true,
      },
    },
  },

The dev keyword in lazy.nvim only refers to not using your own local version of the plugin, not a function in the plugin.
However, I see from your screenshot that you are using otter.nvim in the context of one of my other plugins, quarto-nvim. quarto-nvim does indeed set those keyboard shortcuts via its setup, but you can disable or remap them there.

Thanks! It's cleared after defining new config function with calling require("quarto").setup{...} explicitly.


feat: cpi feature for instructions

Changelog

Add CPI feature so instructions can be wrapped with Anchor's CPI features.

Could you explain what's going on here? Why is it helpful to have a "cpi" feature that's not used anywhere inside the mango program?

afaics cpi is an anchor feature, https://github.com/project-serum/anchor/blob/master/lang/syn/src/codegen/program/cpi.rs#L108, and mango is not built using anchor

@aiell0 Would you be up for reducing this to just the switchboard upgrade?

@ckamm I removed the cpi portion and left switchboard in there.

There are so many changes to cargo lock. Are all of these necessary? And why does switchboard 0.1.36 work now but there's a comment about how switchboard 0.1.36 doesn't work

@dafyddd I will look into the Cargo.lock changes. As far as the switchboard comments, you'd have to go back for that I'm not the one that placed that in there. If there are really no big issues with it we should just ignore this.


Add mobile and desktop view.

In this branch I worked on;

[ ] Mobile responsive version of the capstone project site.
[ ] Desktop responsive version of the capstone project site.
[ ] Home (Index) page of the website.
[ ] About page of the website.

Project description
https://www.loom.com/share/2b1be2573779454fb1c077f5d1afe9b7?sid=ce138de2-431c-46cc-9c40-4b6c026b5702

Hi @peter-mwovi ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not follow the correct gitflow
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @peter-mwovi ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not use the correct github flow please rename you add mobile first branch to dev
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi, @alexander16108, Thank you for the feedback.  I have fixed the branch name but unable to resubmit because the status on dashboard still reads as review pending. Could you advice on how to resubmit?


React fails to minify projects that have ipfs-api as a dependency

Running npm run build results in error:
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

./node_modules/ipfs-api/src/utils/module-config.js:7

when trying to build a react.js project that has ipfs-api as a dependency.
As suggested by https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify , the project should be published pre-compiled.

I did some work on this, providing a prepublish routine for npm at https://github.com/atfornes/js-ipfs-api/commit/bd3a68ed814646bcb0672f29ec60356b48c8ceea.
Please, let us know if it helped

@atfornes Can you make a PR and ask the maintainers to republish the package with the pre-compiled code?

@atfornes Could I simply add prepublish in node_modules/ipfs-api/package.json file?

@povi add help wanted label, please.

@GoodBoy962 @adrianmcli, please let me know if the pull request #630 solves your issues.

@atfornes Thanks! Waiting for pr confirmation

Hi all!
For a time, we published all of our dependencies transpiled for a while and then we decided to revert back. The reasons where the following:

It would increase bundle size
There are no source maps that can bring you back to the original line of code (for when a error happens) forcing you to npm link everything when debugging
One more step to maintain

The reality at the time was that there was no uglifyJS with ES6 support, but today (roughly started 6 months ago) there is indeed uglifyJS with ES6 support and we use it for our dist version.
You can use that version by requiring the module as require('ipfs-api/dist/index.min.js') and avoid hitting this problem.
What I would like to see is create-react-app to upgrade to the latest uglifyJS. Asking the entire world to publish ES5 code -- https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify -- specially when pretty much the only thing we do is Arrow Functions. Let me enphasize that there is an update uglifyJS that does indeed support ES6

Related, @hacdias hit the same issue using hjs-webpack and here is how he solved it:

https://github.com/ipfs/webui/pull/605#issuecomment-345961216
https://github.com/HenrikJoreteg/hjs-webpack/pull/349#pullrequestreview-78050901

thanks @diasdavid,
The only issue that remains for me is that the dist/ files are only available from official releases, and cannot be accessed from any commit/branch. This would be solved with a npm prepare instruction calling aegir build. Is there any chance that something like that would be merged?

@diasdavid
Here is the next fail:
Failed to minify the code from this file:   ./node_modules/ipfs-api/dist/index.min.js:1:33639

@GoodBoy962, using my pull request you could include lib/index.js which is transpiled, so it should not fail.

Let me enphasize that there is an update uglifyJS that does indeed support ES6

Uglify may support minifying ES6, but the code will then not run in IE 9 (syntactically).
We expect support for compiling package code sometime next year, so this package will probably remain broken or require you to eject until then.

@atfornes which file should i change in node_modules?

@GoodBoy962, I would not manually change any file in the node_modules, but instead install the modified branch with:
npm install --save atfornes/js-ipfs-api#transpiled

@atfornes I have got such a stack trace:
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-q4spe4KTfsAS1SUHLO0wz8Qiyf1+vMIAgpRYioFYDMNqKfHQbg+AVDH3i4fvpl71/P1L0dBl+fQi+P37UYf0ew== integrity checksum failed when using sha512: wanted sha512-q4spe4KTfsAS1SUHLO0wz8Qiyf1+vMIAgpRYioFYDMNqKfHQbg+AVDH3i4fvpl71/P1L0dBl+fQi+P37UYf0ew== but got sha1-Yi4y6CSItJJ5EUpPns9F581rulU=. (6052 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-dwVUVIXsBZXwTuwnXI9RK8sBmgq09NDHzyR9SAph9eqk76gKK2JSQmZARC2zRC81JC2QTtxD0ARU5qTS25gIGw== integrity checksum failed when using sha512: wanted sha512-dwVUVIXsBZXwTuwnXI9RK8sBmgq09NDHzyR9SAph9eqk76gKK2JSQmZARC2zRC81JC2QTtxD0ARU5qTS25gIGw== but got sha1-qRlH2h9KUW6jjltOwOw3c2deCIY=. (4568 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-m+qzzcn7KUxEmd1gMbchF+Y2eIUbieUaxkWtptyHywrX0rE8QEYqPC07Vuy4Wm32/xE16NcdBctb8S0Xe/5IeQ== integrity checksum failed when using sha512: wanted sha512-m+qzzcn7KUxEmd1gMbchF+Y2eIUbieUaxkWtptyHywrX0rE8QEYqPC07Vuy4Wm32/xE16NcdBctb8S0Xe/5IeQ== but got sha1-No8lEtefnUb9/HE0mueHi7weuVw=. (25587 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-DIWtzUkw04M4k3bf1IcpS2tngXEL26YUD2M0tMDUpnUrz2hgzUBlD55a4FjdLGPvfHxS6uluGWvaVEqgBcVa+g== integrity checksum failed when using sha512: wanted sha512-DIWtzUkw04M4k3bf1IcpS2tngXEL26YUD2M0tMDUpnUrz2hgzUBlD55a4FjdLGPvfHxS6uluGWvaVEqgBcVa+g== but got sha1-PdPT55Crwk17DToDT/q6vijrvAQ=. (8471 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA== integrity checksum failed when using sha512: wanted sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA== but got sha1-4TjMdeBAxyexlm/l5fjJruJW/js=. (4655 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-c0yTD2rbQzXtSsFSVhtpvY/vS6u066PcXOX9kBB3mSO76RiUQzL340uJkGBWnlBg4/HZzqiUXtaVA7wcRcJgEw== integrity checksum failed when using sha512: wanted sha512-c0yTD2rbQzXtSsFSVhtpvY/vS6u066PcXOX9kBB3mSO76RiUQzL340uJkGBWnlBg4/HZzqiUXtaVA7wcRcJgEw== but got sha1-QKBQ7I3DtTsz2ZCUFcAsC/Gr+60=. (49753 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA== integrity checksum failed when using sha512: wanted sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA== but got sha1-LN4J617jQfSEdGuwMJsyU7GxRC8=.MacBook-Pro-Alexander:MedicalCards alex$ npm install --save atfornes/js-ipfs-api#transpiled
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-q4spe4KTfsAS1SUHLO0wz8Qiyf1+vMIAgpRYioFYDMNqKfHQbg+AVDH3i4fvpl71/P1L0dBl+fQi+P37UYf0ew== integrity checksum failed when using sha512: wanted sha512-q4spe4KTfsAS1SUHLO0wz8Qiyf1+vMIAgpRYioFYDMNqKfHQbg+AVDH3i4fvpl71/P1L0dBl+fQi+P37UYf0ew== but got sha1-Yi4y6CSItJJ5EUpPns9F581rulU=. (6052 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA== integrity checksum failed when using sha512: wanted sha512-ItfYfPLkWHUjckQCk8xC+LwxgK8NYcXywGigJgSwOP8Y2iyWT4f2vsZnoOXTTbo+o5yXmIUJ4gn5538SO5S3gA== but got sha1-LN4J617jQfSEdGuwMJsyU7GxRC8=. (23213 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-lreewLK/BlghmxtfH36YYVg1i8IAce4TI7oao75I1g245+6BctqTVQiBP3YUJ9C6DQOXJmkYR9X9fCLtCOJc5w== integrity checksum failed when using sha512: wanted sha512-lreewLK/BlghmxtfH36YYVg1i8IAce4TI7oao75I1g245+6BctqTVQiBP3YUJ9C6DQOXJmkYR9X9fCLtCOJc5w== but got sha1-LtgVDSShbqhlHm1u8PR8QVjOejY=. (5535 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA== integrity checksum failed when using sha512: wanted sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA== but got sha1-4TjMdeBAxyexlm/l5fjJruJW/js=. (4655 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-c0yTD2rbQzXtSsFSVhtpvY/vS6u066PcXOX9kBB3mSO76RiUQzL340uJkGBWnlBg4/HZzqiUXtaVA7wcRcJgEw== integrity checksum failed when using sha512: wanted sha512-c0yTD2rbQzXtSsFSVhtpvY/vS6u066PcXOX9kBB3mSO76RiUQzL340uJkGBWnlBg4/HZzqiUXtaVA7wcRcJgEw== but got sha1-QKBQ7I3DtTsz2ZCUFcAsC/Gr+60=. (49753 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-DIWtzUkw04M4k3bf1IcpS2tngXEL26YUD2M0tMDUpnUrz2hgzUBlD55a4FjdLGPvfHxS6uluGWvaVEqgBcVa+g== integrity checksum failed when using sha512: wanted sha512-DIWtzUkw04M4k3bf1IcpS2tngXEL26YUD2M0tMDUpnUrz2hgzUBlD55a4FjdLGPvfHxS6uluGWvaVEqgBcVa+g== but got sha1-PdPT55Crwk17DToDT/q6vijrvAQ=. (8471 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-miowhl2+U7Qle4vdLqDdPt9m09K6yZhkLDTWGoUiUzrQCn+mHHSmfJgAyGaLRZbPmTqfFFjRV1QWCW0VWUJBbQ== integrity checksum failed when using sha512: wanted sha512-miowhl2+U7Qle4vdLqDdPt9m09K6yZhkLDTWGoUiUzrQCn+mHHSmfJgAyGaLRZbPmTqfFFjRV1QWCW0VWUJBbQ== but got sha1-r02RTrBl+bXOTZ0RwcshJu7MMDg=. (28358 bytes)
WARN registry Using stale package data from https://registry.npmjs.org/ due to a request error during revalidation.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm ERR! Cannot read property '0' of undefined
npm ERR!      /Users/alex/.npm/_logs/2017-11-22T11_35_10_016Z-debug.log

@GoodBoy962 please try a clean npm install, previously removing node_module folder and package-lock.json file. I have installed it with the same instruction without  problems.
this issue gives more details about those errors https://github.com/npm/npm/issues/16861

@atfornes thanks! That helped me to install your custom dependency.
But the build is still in fail.
./node_modules/ipfs-api/lib/utils/module-config.js:7

@GoodBoy962, can you share what is the content of that line in that file?
In my instalation is var multiaddr = require('multiaddr'); which should not bring errors.
can you also share what is the error message?

@atfornes  Here is the whole file. My 7th line is different
`
'use strict';
const getConfig = require('./default-config');
const requestAPI = require('./request-api');
const multiaddr = require('multiaddr');
module.exports = arg => {
const config = getConfig();
if (typeof arg === 'function') {
return arg;
} else if (typeof arg === 'object') {
return requestAPI(arg);
} else if (typeof arg === 'string') {
const maddr = multiaddr(arg).nodeAddress();
config.host = maddr.address;
config.port = maddr.port;
return requestAPI(config);
} else {
throw new Error('Argument must be a send function or a config object.');
}
};
`

@GoodBoy962, It is weird that a file in lib folder is not transpiled... (does not have arrow functions, for instance).
I am sorry I cannot continue following this issue, please try again to do a clean npm install and check that babel (the transpiler that transforms original code in src/ to transpiled code in lib/) process is run.
Please let us know if you found how to fix that issue.

@atfornes are you sure that after installing your custom solution I should have a file which is not the same as I published here?
Which result do you have after making next steps : 1) clean npm install, 2) npm install your custom ipfs ?

you are right @GoodBoy962, I missed the babel config file, which is fixed now by https://github.com/ipfs/js-ipfs-api/pull/630/commits/a1504c663c8d25c92d639b3b85a8feb7441faa9c.
Please try again now.

@atfornes That helped! Thank you a lot!
Unfortunately there is another the same error with cids(it is ipld) module.

@GoodBoy962, you can propose a similar PR for that module then. Please let us know when it is ready.

Any changes for that bug?

We now compile dependencies starting in react-scripts@^2, give it a try!

I got a simple fix on production build with create-react-app with 'js-ipfs/js-ipfs-api', add <script src="https://unpkg.com/ipfs/dist/index.min.js"></script> in index.html then you can use const IPFS = window.Ipfs; on .js file like this:
index.html
`

<link rel="manifest" href="%PUBLIC_URL%/manifest.json">
<link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">

<title>React App</title>
<script src="https://unpkg.com/ipfs/dist/index.min.js"></script>

      You need to enable JavaScript to run this app.

`
App.js
`import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';
const IPFS = window.Ipfs;
const node = new IPFS();
node.on('ready', () => {
console.log('Node ipfs is ready');
})
class App extends Component {
render() {
return (

Welcome to React

To get started, edit src/App.js and save to reload.

);
}
}
export default App;`

I got a simple fix on production build with create-react-app with 'js-ipfs/js-ipfs-api', add <script src="https://unpkg.com/ipfs/dist/index.min.js"></script> in index.html then on your javascript file declare it like this:
`const IPFS = window.Ipfs;
const node = new IPFS();
node.on('ready', () => {
console.log('Node ipfs is ready');
})`

Check https://github.com/ipfs/js-ipfs/issues/1321 for more info.


coder filter for searching inside method comments

Coder has filters for searching for class references inside methods, but if you want to search inside comments, you need to use a substring filter. That doesn't work well when searching for common words like Object since it matches any Object in the method text (e.g., variables with Object in the name like anObject or ProtoObject).


[WIP] @orta: Stub indicator

Does a few things:

Adds an orange "Stubbing" flag when stubbing responses.
Consolidates reachability testing into one function, which takes stubbing into account.
Lets unit tests pass while the testing machine is offline (say, on a plan :airplane:)

I did this all on a flight, so it still needs some polish/testing.

I dig the concept of being able to use as much functionality as possible in isolation of any other systems :+1:

Yeah, me too! It kind of just happened – as I reworked the code, I realized "hey, wait a minute..."

Ran a smoke test on this, removed the WIP.
@orta: :green_apple:

:+1:  ok, let's ship this


Map-reduce section in manual could use better naming

Summary:
I don't think referring (arguably incorrectly) to Google's Map-Reduce framework as the section title in our manual is helpful. I might suggest other names for the section and a lack of references to Map-Reduce since 1) we only have map_rect right now (no reduce) 2) we don't share almost anything with the Google implementation of these ideas.
Current Version:
v2.18.0

If you want me to do this, put the suggested wording in a comment on the next manual issue and then close this issue.  I always go through all the changes in the next manual issue before a release.
If you want to fix it, feel free to make a standalone PR.
We should definitely fix.  I hadn't realized "MapReduce" referred to Google specifically and or that it referred to a specific kind of map operation---I'd always heard it used more generally.  The Wikipedia also cites the split-reduce-combine framework, which is really what's going on with Stan.  They cite a paper of Hadley's, so I don't even know if "split-reduce-combine" is widely used terminology in computer science.  So however you want to reformulate this is fine with me.  I was just trying to use terminology that would be familiar.

Or would we want to expose a reduce function?


Transaction shown as sent before even signed on mobile

What happened?
On mobile, the modal with "Transaction Submited" is shown before transaction was even signed
https://user-images.githubusercontent.com/3176255/181476615-4436e5bd-5ae8-4692-949a-e125517f9e20.mp4
How can we reproduce it?
Just swap or add liquidity to see the issue
mobile
Mobile
What browsers are you seeing the problem on?
Safari
Anything else you want us to know?
No response

Fixing this might also fix #427 by simply not showing the modal


No Touch support

Cannot drag handle on touch devices.

+1

I found a way to fix this. Simply put, you need to also listen for touchstart, touchmove and touchend. Then in the position() function, use e.targetTouches[0] when it exists.
If people are still interested in a solution I can create a pull request. Let me know.


Downloaded html files with embeded code dont work

Ok but uhm I cant seem to get my button working. Wich I am using for surveys and stuff.


Add Feign AnnotatedMethodProcessor and AnnotatedClassProcessor

In the Feign support, there is an AnnotatedParameterProcessor customization available. I'd like similar support for method and class annotations. This would also make it simpler to support @GetMapping, @PostMapping, etc., along with non-MVC annotations (e.g., JAX-RS, Feign's annotations).

JAX-RS and other are already supported by feign.

What can I do when one class is using MVC annotations while another is using Feign annotations? It's not always feasible to remain consistent with the annotations depending on which developers create the interface.

See the documentation here http://cloud.spring.io/spring-cloud-static/Camden.SR4/#spring-cloud-feign-overriding-defaults
@FeignClient(name = "stores", configuration = FooConfiguration.class)
public interface StoreClient {
    //..
}

public class FooConfiguration {
    @Bean
    public Contract feignContract() {
        return new JAXRSContract();
    }
}

JAXRSContract is from https://github.com/OpenFeign/feign#jax-rs

Oh wow, can't believe I missed that. Thanks! I may end up making a PR to clarify the docs then.

After trying it out, this solution seems rather hacky itself. This requires every single @ComponentScan or @SpringBootApplication or similar to add a filter for either a list of configuration classes used only by this library, or a custom annotation which still needs to be manually filtered by every @ComponentScan. I guess that's a separate issue, though.

They don't need the @Configuration annotation.

Then what does this mean?

The FooConfiguration has to be @Configuration but take care that it is not in a @ComponentScan for the main application context, otherwise it will be used for every @FeignClient. If you use @ComponentScan (or @SpringBootApplication) you need to take steps to avoid it being included (for instance put it in a separate, non-overlapping package, or specify the packages to scan explicitly in the @ComponentScan).

It has to be @Configuration but doesn't need the annotation?

Basically, are you saying that I can do something like this?
public class UseFeignAnnotations {
    @Bean
    public Contract contract() {
        return new Contract.Default();
    }
}

@FeignClient(name = "foo", path = "/api/v1", configuration = UseFeignAnnotations.class)
public interface FooClient {
}

And then I don't need to add @Configuration to UseFeignAnnotations?

Docs are wrong :-) https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/FeignClientOverrideDefaultsTests.java#L160-L225

Oh that simplifies things quite a bit! Thanks


loginByCookie: Need to switch database BEFORE this method fires up

What steps will reproduce the problem?
I have multiple database connections and therefore multiple user tables. I use one "MasterUser" model which is declared in my config as:
'components' => [
            'user' => [
            'class' => 'yii\web\User',
            'identityClass' => 'common\models\MasterUser',

The getDB-function in this model determines, which db-selector to use.
Now we have autologin enables as well:
'enableAutoLogin' => true,

The cookies is here, the authKey is ok, BUT: After close the browser and revisiting the site, my old session is gone. I have a session-based variable which helps me to determine the database connections on base of a login-dropdown field while manually login.
It would be nice to make some stuff BEFORE User::loginByCookie fires up. The handleBeforeLogin Event is triggered AFTER loginByCookie.
What is the expected result?
Some way I could run a code one time before loginByCookie fires up.
What do you get instead?
loginByCookie does not use the correct database and resets the cookie.
Additional info

Q
A

Yii version
2.0.12

PHP version
5.5.9

Operating system
Ubuntu 14.04

Ok, if someone is interested: I made a workaround:
'session' => [
             ...
            'class' => 'common\components\Session'
             ...
        ]

    /**
     * This method overrides Session::open to set some things before the User::loginbyCookie Method fires up.
     */
    public function open() {
        parent::open();
        $value = Yii::$app->getRequest()->getCookies()->getValue(Yii::$app->user->identityCookie['name']);
        if(!isset($_SESSION['loginByCookieWorkaround']) && $value !== null && !isset($_SESSION['client'])) {
            Yii::info('Workaround: User is logged out but has valid cookie. Client assignment needed.');

            $data = json_decode($value, true);
            list($id, $authKey, $duration) = $data;

            foreach(Yii::$app->components as $component => $compValue) {
                if(strpos($component, 'db_client') === 0) {
                    Yii::trace('Found a match! => '.$component);

                    $client = substr($component, strlen('db_client_'));
                    Yii::trace('Will work with client: '.$client);
                    $_SESSION['client'] = $client;

                    // Now that the client-SESSION variable is set, the Model::getDB function selects another db
                    $user = User::findOne($id);
                    if($user && $user->auth_key == $authKey) {
                        Yii::trace('Yep, got right client - well, at least the userid and authkey macthes, so the possibility is very large that we got the right user.');
                        return true;
                    } else {
                        Yii::trace('Not the right client :(');
                        unset($_SESSION['client']);
                        continue;
                    }
                }
            }

            $_SESSION['loginByCookieWorkaround'] = true;
        }

    }
}

With that code, I create the base of database-selecton logic: session['client']. This makes loginByCookie working again ;)
However, a native possibility to do things once before loginByCookie() fires up would be nice to have.

Won't be implemented in 2.0.


[grammar] comma-related Inconsistency between the spec and implementation.

Consider:
void main() {
  for (;; print("foo"), ) {
    break;
  }
}

Notice the trailing comma, which, according to the spec, doesn't appear to be valid Dart syntax. However, that program is accepted as a valid dart program by the implementation.

Right, I don't think it's reasonable to introduce a breaking change in order to remove support for trailing commas in in particular situation where it is actually already implemented.
One thing, though, does dart format know about these trailing commas? I would have expected the following to have more line breaks, but it is actually formatted as shown here:
void main() {
  for (int i; i < 10; print("foo"), ++i, print("bar"),) {
    break;
  }
}

@munificent, what do you think about trailing commas in <forLoopParts>?

Wow, I'm a little surprised the formatter doesn't end up inadvertently dropping the trailing comma on the floor.
Filed this to track how we want to handle it: https://github.com/dart-lang/dart_style/issues/1354
As far as the language is concerned, it's hard to say. The language doesn't seem to have any consistent principle for where trailing commas are allowed:

Has closing delimiter and trailing comma is allowed: collection literal, argument list, parameter list, assert statement arguments.
Has closing delimiter but disallows trailing comma: type parameter list, type argument list.
Has no closing delimiter and disallows trailing comma: show clause, hide clause, implements clause, with clause.
Not sure how to categorize whether there is closing delimiter or not but allows trailing comma: enum values.

I guess for loop updaters are most similar to enum values where there is a closing delimiter, but the stuff inside the delimiter is more than just the comma-separated list of things? In an enum, there may be ; followed by members. In a for loop, there are the preceding for parts clauses.

For enums, I'd say there is a trailing delimiter, which is either } or ;.
I agree that the leading and trailing delimiters are not necessarily matched, and for loop increments are like that too, started by ; and ended by ).
Inside that, for-loop increments are more like function arguments, they are comma separated completely general expressions.
Currently implements also has a recognizable end, terminated by either { or ; (mixin application classes). I'd avoid exploiting that, since it's really just an accident that nothing else can come after.

I hope this issue isn't viewed as some evidence that there's "people who depend on this feature". I've discovered this one by accident (it seems that @lrhn discovered it first: https://github.com/dart-lang/language/issues/2430#issuecomment-1225458685!) and I don't plan on ever using it. I wouldn't mind a breaking change that removed this feature to prevent any potential formatter issues.

@munificent wrote

As far as the language is concerned, it's hard to say. The language doesn't seem to have any consistent principle for where trailing commas are allowed:

Has closing delimiter and trailing comma is allowed: collection literal, argument list, parameter list, assert statement arguments.
Has closing delimiter but disallows trailing comma: type parameter list, type argument list.

https://github.com/dart-lang/language/issues/2430


Replace all printf with fprintf(stderr) in regression tests

printf only prints at the end of exeuction, we need to replace with fprintf(stderr) to be able to track where in test the execution hangs or fails.

Fixed in #213


Obtaining statistics column from modkit

Hi Shian,
Thank you for the program!
I might be asking a silly question. I am currently using modkit, but I don't find a way to obtain a table that resembles your "methy" object in the user's guide. In particular, the statistics column. I have percentage of modification at each base in the modBAM file. Is there a way I can create the statistics column without Nanopolish?
So far, I have the BAM, BED and pileup files.
Thank you in advance!

Hi Pol,
Thanks for raising the issue, it's been something I've been meaning to implement for a while now. I've just pushed an update to allow you to import the result of modkit extract full using the create_tabix_file() function the same way you would for nanopolish output.
You can install it by remotes::install_github("shians/nanomethviz"). Let me know if it works, I'll test it further and make it fully available in the next bioconductor release.
Shian

Hi Shian,
Thank you so much for the quick reply. I just have one last question.
I have the BAM and BED files separately for each sample. I have 12 samples/files corresponding to one treatment, and 12 more from another treatment.
The  of the create_tabix_file(), should it be two files (one for each treatment), or 24 files? In other words, the modkit extract full, should I do it separately for each sample or should I pool all the samples of a treatment?
As soon as I get the reply, I will put my hand on it.
Thank you very much!

Hi Shian,
I tried the create_tabix_file() with the output of modkit extract (now the modkit extract fulldoes not exist anymore).
I called create_tabix_file(input files = c("<input1.tsv.gz>", "<input2.tsv.gz>"), output_file = "test.tsv.bgz"). I get the following error:
 [2024-09-18 19:22:28] WARNING: creating tabix file on windows requires at least twice as much memory as total size of methylation data [2024-09-18 19:22:28] creating methylation table processing //files1.igc.gulbenkian.pt/folders/ANB/Pol/Met/data/data_enrich/subset_tsv_gzip/extr_per-read_info_03.tsv.gz... Error in guess_methy_source(element$file) : Format not recognised.
Do you have any guess what can be wrong?
Thanks in advance!

Hi,
I will have a look at this today, according to the modkit documentation, I think the newest version should have modkit extract full. I do remember I once ran it without full so I will hunt down an older version which presumably output a slightly different format.
As for your files, they should be processed as 24 files.
Shian

Hi Shian,
Just an update on this. I updated the Modkit version.
I extracted the TSV with modkit extract full. Then I compressed the file with bgzip function and I tried again the create_tabix_file() function. I still get the error Error in guess_methy_source(element$file) : Format not recognised.
Maybe I'm missing something? Should I input the uncompressed file?


denoise-*: expose --collapse-no-mismatch parameter

forum xref

I can take this one 👍

I suspect the latter is what we're looking for, since it sounds like the forum user was interested in combining subsequences together. I'm a little curious as to what minOverlap is for, since it seems like we're dealing with +- a few nucleotides, so having a subsequence of only 20ish sounds pretty bad (and will probably bin into the most abundant read no matter what).

That being said, a new method would let us re-use this elsewhere...

that forum post seemed to suggest that this was a parameter, so that was my assumption when I opened this issue without further investigation.
I like the new method idea though.

I'll start with just the function I suppose. Would joining them have to be a pipeline then?

I'm not sure the best way to handle adding the function inline w/ denoise, as it'd require the flag to run it or not and also a flag for the overlap parameter

I think this would be conditionally run in the R scripts, right (like the chimera checking section)?

To "qiime" in, if this is something that is going to be integrated into the workflow commands, this may be best left until we migrate the plugin to the version 1.8 of the dada2 R package, as I am expecting to overhaul the q2-dada2 R scripts a bit at that time.

If I am not wrong, the 100% clustering of ASV can also be performed using q2-vsearch plugin ? So maybe there is no need to add a specific condition in q2-dada2 script?
What do you think?

I'm a bit uncertain if our implementation of de-novo will cluster shorter sequences or not. Also, the IDs are something to consider, but I don't see why these couldn't be made to be very compatible.


Interactive Window session lost without warning when changing folders

From a comment from Mira on our marketplace reviews. This is my interpretation of what their feedback was.

Open folder A, then launch an instance of the Interactive Window (Jupyter: Create Interactive Window)
Do some work there by entering Python commands in the input box.
Create and open folder B in the same instance of VS Code.
Reopen folder A again in the same instance of VS Code

Expected
The state of the interactive window opened and edited in step 2 is still available.
Actual
The interactive window is gone along with commands that had been entered.
Notes
The Interactive Window was designed to be an execution environment for writing Python scripts in a manner similar to that of creating a notebook. However, the design of the IW is geared more toward acting like a REPL or Python Terminal, so naturally its state is not saved when VS Code is closed or a new folder is opened.
Because the Interactive Window looks like a notebook, it seems reasonable to assume that many users will expect the state to either 1) be persisted or 2) warned about losing when the window is closed.
Marked as "important" due to the fact this can be interpreted as a data loss scenario.
Possible behavior changes

Consider providing a warning to users if an interactive window is opened that wasn't associated with a Python script.
Consider offering to save the IW as a notebook.
Automatically save the IW as a notebook or otherwise be persisted and re-established on loading a particular workspace.
Automatically save at least the command list that was entered (since we can't really save the execution state).

Pursuing hot-exit behavior which needs to be done in core.

@rebornix is the interactive window notebook using the same file based working copy support as normal notebooks do or is it not using working copies at all? Everything should be there, given it works fine for notebooks.

Hooking up serializer in the custom editor fashion works. Though I didn't test adding a setting yet, I found it's not going to work without changes in Jupyter. Problems I found so far:

After reloading, builtin renderers are not found. It didn't happen with untitled notebook though.

This is mainly because notebooks are serializer based, it will only open after the serializer extension is activated, which will be after the renderer handler from package.json being handled. However Interactive Window is inmem, which currently doesn't really wait for extension host.

After reloading, running cells from python file again will not pick up the restored interactive window. Instead it will create a new one.

Perhaps there should just be a command to retrieve your lost IW session. That way, it could load with the renderers, and wouldn't just be a stale window to be closed in most cases.


some snippets are gone

Description:
I have been using the lsp-zero plugin in Neovim for my language server configuration, and it has been working well in the past. However, recently, I noticed that some snippets are missing from the language server completion.
For instance, when I used to type "main," it would suggest a snippet to create a main function with a return statement in C++. Additionally, when composing a Git commit message using the git commit command, typing "cho" would suggest a chore() snippet and other Git commit-related snippets.
I have verified that clangd is installed as the language server, and my understanding is that lsp-zero relies on the language server to provide snippets. However, the problem might also be related to third-party snippets.
I have already tried to debug the issue, but I couldn't identify the root cause. I suspect it may be due to an update or a configuration change. I would greatly appreciate any help in resolving this matter and bringing back the missing snippets.
config:
cmp.setup({
  sources = {
    {name = 'nvim_lsp'},
    {name = 'cmp_luasnip'},
    {name = 'cmp-nvim-lsp'},
    {name = 'cmp-path'},
    {name = 'cmp-buffer'},
    {name = 'luasnip'},
  },
  mapping = {
    ['<C-y>'] = cmp.mapping.confirm({select = true}),
    ['<C-e>'] = cmp.mapping.abort(),
    ['<C-u>'] = cmp.mapping.scroll_docs(-4),
    ['<C-d>'] = cmp.mapping.scroll_docs(4),
    ['<Up>'] = cmp.mapping.select_prev_item(cmp_select_opts),
    ['<Down>'] = cmp.mapping.select_next_item(cmp_select_opts),
    ['<C-p>'] = cmp.mapping(function()
      if cmp.visible() then
        cmp.select_prev_item(cmp_select_opts)
      else
        cmp.complete()
      end
    end),
    ['<C-n>'] = cmp.mapping(function()
      if cmp.visible() then
        cmp.select_next_itgm(cmp_select_opts)
      else
        cmp.complete()
      end
    end),
  },
  snippet = {
    expand = function(args)
      require('luasnip').lsp_expand(args.body)
    end,
  },

Change the name of your sources. Like this.
  sources = {
    {name = 'nvim_lsp'},
    {name = 'path'},
    {name = 'buffer'},
    {name = 'luasnip'},
  },

You need to make sure you have all these plugins installed:

hrsh7th/cmp-nvim-lsp
hrsh7th/cmp-buffer
hrsh7th/cmp-path
saadparwaiz1/cmp_luasnip
rafamadriz/friendly-snippets

And add the luasnip loader in your config.
require('luasnip.loaders.from_vscode').lazy_load()

The plugin is working perfectly now, and I'm back to coding smoothly.
Thanks again for your fantastic work!
I'm attaching my configuration files related to the lsp-zero plugin. I hope they can be useful for other users facing similar issues.
packer.lua:
     use {
        'VonHeikemen/lsp-zero.nvim',
        branch = 'v2.x',
        requires = {
            -- LSP Support
            {'neovim/nvim-lspconfig'},             -- Required
            {                                      -- Optional
            'williamboman/mason.nvim',
            run = function()
                pcall(vim.api.nvim_command, 'MasonUpdate')
            end,
        },
        {'williamboman/mason-lspconfig.nvim'}, -- Optional

        -- Autocompletion
        {'hrsh7th/nvim-cmp'},     -- Required
        {'hrsh7th/cmp-nvim-lsp'}, -- Required
        {'L3MON4D3/LuaSnip'},     -- Required
        {"rafamadriz/friendly-snippets"},
        {"saadparwaiz1/cmp_luasnip"},
        {"hrsh7th/cmp-buffer"},

        --lspkind
        {"onsails/lspkind-nvim"},
    }
}

lsp.lua
 local lsp = require('lsp-zero').preset({"recommended"})

lsp.on_attach(function(client, bufnr)
  -- see :help lsp-zero-keybindings
  -- to learn the available actions
  lsp.default_keymaps({buffer = bufnr})
end)

lsp.set_sign_icons({
    error = '✘',
    warn = '▲',
    hint = '⚑',
    info = ''
})

lsp.setup()
 -- ####### CMP ######## --
local cmp = require('cmp')
local cmp_action = require('lsp-zero').cmp_action()
cmp.setup({
    -- sources
    select_behavior = 'insert',
    sources = {
        {name = 'nvim_lsp'},
        {name = 'path'},
        {name = 'buffer'},
        {name = 'luasnip'},
    },
    -- key-mapping
    mapping = {
        ["<Tab>"] = cmp_action.luasnip_supertab(),
        ["<S-Tab>"] = cmp_action.luasnip_shift_supertab(),
        -- `Enter` key to confirm completion
        ['<CR>'] = cmp.mapping.confirm({select = false}),
        -- Ctrl+Space to trigger completion menu
        ['<C-Space>'] = cmp.mapping.complete(),
        -- Navigate between snippet placeholder
        ['<C-f>'] = cmp_action.luasnip_jump_forward(),
        ['<C-b>'] = cmp_action.luasnip_jump_backward(),
        ['<C-e>'] = cmp.mapping.abort(),
        ['<C-u>'] = cmp.mapping.scroll_docs(-4),
        ['<C-d>'] = cmp.mapping.scroll_docs(4),
    },
    --snippets
  snippet = {
    expand = function(args)
      require('luasnip').lsp_expand(args.body)
    end,
  },
  --windows
  window = {
      completion = cmp.config.window.bordered(),
      documentation = cmp.config.window.bordered(),
  },
  --formating
  formatting = {
      fields = {'abbr', 'kind', 'menu'},
      format = require('lspkind').cmp_format({
          mode = 'symbol_text', -- show only symbol annotations
          maxwidth = 50, -- prevent the popup from showing more than provided characters
          ellipsis_char = '...', -- when popup menu exceed maxwidth, the truncated part would show ellipsis_char instead
      })
  },
})

require('luasnip.loaders.from_vscode').lazy_load()


Add support for circuit cutting in TNs

Refer:

[1] D. Guala, S. Zhang, E. Cruz, C. A. Riofrío, J. Klepsch, and J. M. Arrazola, “Practical overview of image classification with tensor-network quantum circuits,” Scientific Reports, vol. 13, no. 1, p. 4427, Mar. 2023, doi: https://doi.org/10.1038/s41598-023-30258-y.

Hi @SaashaJoshi I would like to work on this task for Hacktoberfest.

Hi @tinaoberoi, that's great.
Regarding the expectations from this issue: I do not particularly expect a code contribution, hence any non-code workflow/pipeline discussion or literature research as a part of Phase 1 of developing such a feature may suffice. I will be open to your ideas as well. I previously did some work on combining circuit cutting with tensor networks (here)[https://github.com/SaashaJoshi/QML-circuit-cutting] that you can take a look at. Let me know what you think!

Hi @tinaoberoi, let me know if you need help at any moment or wish to discuss things going forward.

Hi @SaashaJoshi
I read the QML-circuit-cutting repo where circuit cutting is implemented on tensor networks. I believe the qiskit circuit_knitting package is used for the implementation.
Since for piQture, we already have tensor networks in place. and once we integrate the circuit_kitting library
We can execute the circuit cutting using
observables = PauliList(["ZIIIIIII"])
partitioned_problem = partition_problem(circuit=ttn, partition_labels="AAAABBBB", observables=observables)
sub_circuits = partitioned_problem.subcircuits
sub_observables = partitioned_problem.subobservables
bases = partitioned_problem.bases

Let me know what you think.

This is great. I am thinking along similar lines. I believe classes like SamplerQNN and EstimatorQNN from the Qiskit Machine Learning library need to be modified to make them compatible with circuit cutting structures. This is because tensor networks need to be trained iteratively after a cut has been made on them and these classes do not readily accept multiple circuits that can be executed simultaneously.
However, modifying these classes or adding a module from scratch might be too much work for Hacktoberfest. If you are focused on Hacktoberfest, then quite honestly, I do not think this issue will be a good fit. But if you wish to discuss things irrespective of the event I am all ears.

I would like to work on this irrespective of Hacktoberfest.

Perfect!
As per my "exploration" sometime when Qiskit 1.0 was released, circuit cutting produces two sub-circuits per gate/wire cut. These two sub-circuits are difficult to train simultaneously when using the SamplerQNN and EstimatorQNN classes. Looking at the commit history here I do not think any changes have been made to accommodate multiple circuits.
A wrapper can be a good alternative to explore. Although I was thinking more along the lines of making the entire training module from scratch, however, starting with a wrapper class/function is good. Do you have some specifics on what the wrapper must do?

These two sub-circuits are difficult to train simultaneously when using the SamplerQNN and EstimatorQNN classes from the Qiskit Machine Learning library. Looking at the commit history here I do not think any changes have been made to accommodate multiple circuits.

Why is that the case? (Is it the limitatiion of the machine learning library in general or because of the subcircuits being depenedent). I found this as a way to parallelise QNN training
And

A wrapper can be a good alternative to explore. Although I was thinking more along the lines of making the entire training module from scratch, however, starting with a wrapper class/function is good. Do you have some specifics on what the wrapper must do?

I agree writing a training module should be the final step, but a wrapper will help me familiarize with the modules.

HI @tinaoberoi,

Why is that the case? (Is it the limitatiion of the machine learning library in general or because of the subcircuits being depenedent).
It is mainly because of how the functions are structured in Qiskit Machine Learning library. I'll be honest, I haven't had the ltest look though. I am updated till Feb 2024.

A wrapper function sounds good. Let me know if you'd need any help in making a PR etc. We should think more about its structure etc.


Route _xyzzy+/a._b.c.tsx does not nest correctly

In Remix's route module convention, the following three route module filenames are interpreted as an ordinary route, a pathless layout route, and another ordinary route, each containing the next:
a.tsx
a._b.tsx
a._b.c.tsx

However, with remix-flat-routes, this does not work as expected if the modules are contained within a folder, like this:
_xyzzy+/a.tsx
_xyzzy+/a._b.tsx
_xyzzy+/a._b.c.tsx

Add a (currently failing) unit test to demonstrate this bug.
Note: update Jest to 28.x because that version introduced test.failing.

These lines are the culprit:
https://github.com/kiliman/remix-flat-routes/blob/aadb03ae670493e888488086ddb1bfa364452c54/src/index.ts#L418-L425

Thanks! I'll take a look.


Use byteArrayEquals

Motivation

byteArrayEquals is better than ssz.Root.equals in terms of performance

Description
Added benchmark result:
// Compare state root
// ================================================================
// ssz.Root.equals                                                        17262.51 ops/s      57.92900 us/op 256558 runs    15.01 s
// ssz.Root.equals with valueOf()                                         61656.08 ops/s      16.21900 us/op 903088 runs    15.03 s
// byteArrayEquals with valueOf()                                         848896.4 ops/s      1.178000 us/op 9904067 runs    15.38 s

Closes #2708
Steps to test or reproduce

Can we make ssz.Root use byteArrayEquals instead? smile

We can! I ran the benchmark with https://github.com/ChainSafe/ssz/pull/130 and https://github.com/ChainSafe/lodestar/pull/2713 applied, got these results:
Compare state root
================================================================
ssz.Root.equals                                                         1101322 ops/s      908.0000 ns/op 12559206 runs    15.51 s
ssz.Root.equals with valueOf()                                         731528.9 ops/s      1.367000 us/op 8654589 runs    15.37 s
byteArrayEquals with valueOf()                                         785546.0 ops/s      1.273000 us/op 9585978 runs    15.39 s

since #2713 is merged do we not need this PR anymore?

since #2713 is merged do we not need this PR anymore?

We should still commit the perf tests here


Various micro optimizations

I was investigating potential bottlenecks and some possibilities for optimizations and prepared PR for that #2368.
Main changes:

use while instead of .slice() to copy array
Array.isArray(..) replaced by .. instanceof Array
this.items cached into local variable in order to avoid repeated getter calls
also check added in one place to avoid Array being treated as Object, which in that case might make difference

Please see https://github.com/Polymer/polymer/pull/2368#issuecomment-176491515


Immutable?

Should an interoperable Domain Payload be defined as immutable?

Since "true" immutability is not possible in PHP, my thought is "no."

Good point. While you are right that "true" immutability is not possible in PHP, I would still prefer it for the sake of consistency with PSR-7.

Domain Payloads can be "transformable" but not persisted, at least imo.

On further consideration, this might not be a question we need to address at all. @jakejohns in Aura.Payload_Interface suggested splitting the interface into "read" and "write" portions. Immutability would affect only the "write" portions of an interoperable interface; perhaps we need only concentrate on the "getter" portions, thereby obviating the issue.

A second point on restricting the interface (if we go through with this) to the "reading" portions only: it leaves the Domain-specific setting of values up to the Domain. The Responder (or other receiver of the Payload) needs only to be able to read those values out, not set them.

As I've used payloads, that's essentially the way it works.  In short, the Domain stuffs data into them and then the rest of the system reads stuff out of them.  As @geggleto mentioned above, I do use a Transformer object when necessary to mess with the contents of the Payload, but all it does is change them, not add to or remove them.

To be fair, though, I've pretty much only used an ADR-esque framework twice (once in a master class and once for a side project).  I'm not sure i have the domain experience (pun somewhat intended) to lend that much weight to the way I've done things.

Actually, that's not entirely accurate.  my Action objects sometimes add a bit to the Payload based on the needs of the Response.  E.g., if the domain responds with a Payload, but the Response needs some clarifying instructions, those instructions might be added by the Action to the Payload and then passed to the Response.

@dashifen I'd be interested to see examples of that.

https://github.com/dashifen/shadowlab/blob/master/src/Framework/Action/AbstractAction.php#L217
That method does it.  The Payload is received from the Domain on line 223, the data is extracted, and then if it represents a success case, its data is merged with the requirements of the Response template on line 237.  The merged data is crammed back into the Payload on line 245, and then it's all passed to the Response on 247.
The data added during the merge is all specific items needed by the Response.  For example, this is the success template: https://github.com/dashifen/shadowlab/blob/master/views/write/success.html.  I'm using Vue.js on the front end, so all of those {{ variables }} get filled in base don the data the Response finds in the Payload.

@dashifen Ah so. If you'll pardon me, that seems a little heavy for an Action; some of that can be avoided by having one Action per class, then, one Responder per Action (or per type-of-Action, to consolidate Responders). But, this does tell me where you're coming from -- thanks.

Yeah, it's a work in progress.  A lot of that used to be a higher level in that application and I recently moved it lower (i.e. to the AbstractAction).  I'm not real happy with the overall structure yet, but it's getting the job done and this is a for-fun project, not a for-profit one, that I'm considering a learning tool.

Some notes on which implementations are mutable:

Mutable: Adroit/Adrenaline, JoeBengalen, Dashifen, Geggleto, PerfectOblivion
Separate Read/Write: Aura (but combined at implementation, so mutable impl)
Immutable: Equip

Settled on defining only the "read" interface, not the "write" or "mutate" interface, rendering this discussion moot.


System.MissingMethodException: Default constructor not found for type System.Array

I'm having an issue and it only occurs on my device, not on the simulator.  My device is iOS 11.4 and is an iPhone 6s.  The simulator is also running 11.4.
The CarouselView version I am running is 5.0.0 ... I tried upgrading to the latest version but apparently there's a compatibility issue with .netstandard 1.4.
It was working fine only days prior and I have confirmed that the CarouselView is the cause of the error.
Any ideas?  I'm more than happy to provide further info where needed.

Check Link behavior option in iOS build window. For me, setting to "Don't Link" fixed the issue. But I didn't have enough time to investigate this further.

Thanks, that gets me by but obviously, in release mode doubles the size of the app.  Here's hoping you can find a permanent fix.  Thanks for the heads up anyway.

I am releasing an update to support XF 3.x.x. It will include some small fixes.


Automate downloading logs from servers

It would be nice to add a command to download log files from servers, perhaps using rsync.
https://gist.github.com/ari-gold/c63e6a2b5d47037dc8d7

:+1: for this - we should review whether this comes before or after 1.0, but it's a no-brainer to give it to folks.

I think we should implement this in the platform, and expose it through Terminus. Rather than implement it in Terminus.

So I just discovered yesterday that by creating a script that does an rsync every X seconds and tail -F you can pretty much stream logs locally. Not sure if that's a viable solution to bake into Terminus?


bugfix: bad tooltips and structure board areas positions

When the sideframe is opened, tooltips and structure board areas are
badly moved to the right.
As tooltips and area are "css positioned" and jquery offset function is
relative to the document (not the first relative/absolute parent), we
need to substract first relative/absolute parent offset.

Coverage increased (+0.2%) to 87.252% when pulling 51f88112e13bf9d9c3a282d76c9b6ef384358ae2 on webu:bugfix/structureboard_areas_and_tooltips_position into 525d91af9c2d430536bb6386bfb9d81df19179d7 on divio:support/3.0.x.


[AutoPR billing/resource-manager] Billing new Py path

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6052

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3853


Sections layout badly optimized (goes out of the screen)

Addon Version
v0.1.43
World of Warcraft Version
Retail
Describe the bug
Layout of the sections is not optimized. Some parts goes out of the screen while there's a whole lot of empty space on other columns. See here the recipes section: some of them are outside of the monitor at the bottom, and maybe other lines/sections: I have no ways to tell.
See the joined screenshot, taken on a QHD monitor (2560x1440), so above average FHD resolution. Cropped on the sides as it was irrelevant.

You can also note that some sections names are cut for no reason (I see the case for two of them on the screenshot); I can open another issue for this if necessary.
Also, I'll use the occasion of this issue for a question, to not open too many of them: BetterBags is pushed as meant for replacing AdiBags, however it's clearly not at feature parity for now. Is it meant to have it? If yes, is there an issue centralizing feature parity and things like that?
Steps to reproduce
Apart from filling your bank in a similar manner to this screenshot, it's hard to tell.

A few things that help:

Turn on Simple compaction

Add more items per row, and less columns, so the bank bag has more room to grow horizontally. You do this on the main bag today as seen in your screenshot -- do that on the bank as well.

AdiBags also did a tighter set of bin packing for sections, ignoring sort order and finding a best fit. BetterBags doesn't do that in favor of strict ordering, however a bin packing feature will come soon, along with better sorting options.

Also, I'll use the occasion of this issue for a question, to not open too many of them: BetterBags is pushed as meant for replacing AdiBags, however it's clearly not at feature parity for now. Is it meant to have it? If yes, is there an issue centralizing feature parity and things like that?

No, not even close. There are still quite a few things that need to be done. The issues are scattered all over this Github in various issues.

So we have no choice but to set this right manually? I had a good result in AdiBags without touching any parameters, just with the default settings and behavior.

It's two sliders you have to change, but I'll change the defaults in the bank to match the bag in the next release.

What do you mean by bin packing? I'm not sure I understand what's this.

It's a computer science term -- essentially, "pack things as tight as possible without wasting space".

Then I'll ask, if I may: what's the reason/goal behind the creation of BetterBags to replace AdiBags if it's by the same persons?

I've answered this both in the AdiBags github pinned issue, and in the Discord FAQ. PTAL there :)
Thanks!


Add img crossOrigin attribute as a parameter in the plugin configuration

Hi,
We have a case where the basic authentication is enabled in our server and the crossorigin=anonymous attribute prevented the images to load on Microsoft Edge, showing the error:
HTTP401: DENIED - The requested resource requires user authentication.
So We implemented and option to enable/disable this attribute.
Thanks!

I makes sense thanks


Rewrite XMLInputFormat in terms of chars not bytes. Fix handling of self-closing tags

This should supersede:

https://github.com/databricks/spark-xml/pull/316
https://github.com/databricks/spark-xml/pull/321
https://github.com/databricks/spark-xml/pull/149

To make the fix, it seemed necessary to rewrite the logic in terms of characters, not bytes. Honestly I don't know why the original implementation worked in terms of bytes, even though I might have been part of it.
This does handle self-closing tags, but not nested copies of the same row tag. The latter is either something we need to drop or, will require another rewrite to handle sanely.

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #352   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          14     14
  Lines         737    728    -9
  Branches       57     66    +9
=====================================
+ Misses        737    728    -9

Impacted Files
Coverage Δ

...cala/com/databricks/spark/xml/XmlInputFormat.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7db55a...9701345. Read the comment docs.


Added Dreamshaper

One of the most popular models currently

hi @wetcircle thanks ❤ please open dev
https://github.dev/camenduru/stable-diffusion-webui-colab
copy paste any model then modify it
and name should be like that
modelname_version_webui_colab.ipynb

Hello @wetcircle. I added the fixed clip version. It's now available.

thanks @etherealxx ❤ we have extra link inside the colab you can edit like this


App fails to recompile on Android after upgrading to Flutter 3. Execution failed for task ':app:compileFlutterBuildDevelopmentDebug'.

The issue
I am currently using flutter to develop a new app  - we have been using flutter 2.10 for a while but wanted to upgrade to version 3 which we did last week. But we have had nothing but problems since in the dev team.
The app will now run but only if we delete the /build and /android/app/build folders. We cant recompile the app at the moment.
Also the app will randomly crash when developing with fatal crashes and randomly breakpoints used in vscode debug will crash the app.
I can't find any fixes to the current issues and running a new project with flutter create works fine.
Steps to Reproduce
I can not provide an example of the code to reproduce- as the code base is massive and i have no clue where to start. I Suspect it has nothing to do with the code anyways - i have instead provided the pubspec.yaml file as it is more likely to come from android compiling and its dependencies.
Steps i have already attempted
I have tried deleting the flutter sdk and redownloading it from the website - with no results.
I have tried disabling most dependencies and recompiling while enabling them one after one - but not while also deleting build folder. no errors here.
I have ran the following commands;

flutter clean
flutter pub cache repair
flutter channel master
flutter pub upgrade

Hi @Bajerskov
The goal of this Github repo is not to give assistance on personal code or the whole package/plugin project,
but to improve flutter reporting bugs or with feature requests.
From your pubspec.yaml file, there are many 3rd party plugins that could cause this issue so we are not sure can give you a proper solution for this. But from the logs (log-compilation-failed.txt):

[        ] * What went wrong:
[        ] java.lang.StackOverflowError (no error message)

It looks like this StackOverflow answer can solve the issue: https://stackoverflow.com/a/72514048/5921933.
Let's try it to see if the issue is still reproducible.

@huycozy Appologies - I will move to another platform to find an answer.
I appreciate the effort - unfortunatly it had no effect.

Hi @Bajerskov
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away! Thanks for your contribution.


fix: update module name for major version change

Update module name to github.com/IBM/ibm-iae-go-sdk/v2.
Signed-off-by: Subin Shekhar<EMAIL_ADDRESS>PR summary
Added v2 to module name as required by GO modules for major version change.
Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


RFC for separate getter and setter types for properties

Separates out read access from write access to properties.

This is still a bit terse in places, e.g. on metatables and modules.

Split this PR in two: #77 and #79.


fix(drools-lsp): leverage simpler -jar syntax now that drools-lsp supports it

fix(drools-lsp): leverage simpler -jar syntax now that drools-lsp supports it
This PR in kiegroup/drools-lsp was merged and a new release was built, making this PR doable.
Signed-off-by: David Ward<EMAIL_ADDRESS>

Hello! I see that the latest release is v0.1.4, even though there is a v0.1.5 tag. However, even that tag doesn't contain this drools_lsp.lua server config file. Is there any way that someone could please (after merging this PR) tag and release a v0.1.6 so that drools_lsp is usable? Thank you! :)

Closing this PR in favor of another forthcoming.


The Organization requires a report on, All the countries in a region organised by largest population to smallest.

Did you pushed it?
On Wed, 13 Mar 2024 at 2:17 AM Robert-Smales @.***>
wrote:

Closed #5 https://github.com/Robert-Smales/sem-cw/issues/5 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Robert-Smales/sem-cw/issues/5#event-12096927905, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BC353PRLJ5I3UKU7IJD3YS3YX6ZJ7AVCNFSM6AAAAABEK74M7KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGA4TMOJSG44TANI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Package installs, but doesn't load anymore when restarting neovim

Adding this plugin to paq installs it and it loads normally after install. After restarting neovim the plugin doesn't load anymore.
The easiest way of testing this is to install the plugin and type nim in command mode and then press tab for command completions. Right after plugin install there are multiple commands provided by the plugin, but after restarting neovim and looking for commands that start with nim, there are none.
For now I worked around this by installing all my other plugins with paq and installing this one plugin with vim-plug. Its weird that all the other plugins I have work with paq, but this one doesn't.

I tried the plugin and the error I got was:
nim.nvim: nimsuggest (nimsuggest) cannot be executed: Vim(let):E475: Invalid value for argument cmd: 'nimsuggest' is not executable

nimsuggest doesn't appear in the requirements in the readme…

Right after plugin install there are multiple commands provided by the plugin, but after restarting neovim and looking for commands that start with nim, there are none.

When I open a Nim file, I get three commands: NimDocOf, NimReferences and NimTypeOf. The first two don't seem to do anything, and the third fails with:
nim.nvim: nimsuggest (nimsuggest) cannot be executed: Vim(let):E475: Invalid value for argument cmd: 'nimsuggest' is not executable
Error detected while processing function nim#suggest#def#ShowType[5]..nim#suggest#utils#Query:
line   16:
E716: Key not present in Dictionary: "query"

I'll take another look if alaviss/nim.nvim#44 is resolved.

Thanks for taking a look at this issue. Idk what has changed since then but I don't have this bug anymore. Also nimsuggest isn't listed as a requirement in that plugin because the plugin is meant for Nim developers and assumes you have installed the Nim programming language (and the tools that come with it).


[docs] Add missing Alias

I don't think that's needed, the name should be pulled from your GH profile. @jpechane, can you remind me, how does that work again?

So the way the process works is that we compare the name on the GH account with the names in the COPYRIGHT.txt.  If there is a match, then all is good.  The only time you would need to adjust Aliases.txt is if the name on the GH account is an alias and you would prefer your name in the COPYRIGHT.txtto be your real or full name, in which case the entry in theAliases.txtbridges the gap of linking the GH account to your entry inCOPYRIGHT.txt`.


Added SolidiFi Flare address

@perlindstroem Please see the new commit (4bd8368). I have added a new image for the Flare address and updated the one for Songbird as well.

I see the new image, but it does not seem to have been compressed with tinypng @apfz

FYI, we've updated our contribution guidelines: https://github.com/TowoLabs/ftso-signal-providers#how-to-add-your-signal-provider and clarified how to run tests locally.

@perlindstroem Since the guidelines mentioned tinypng as example I used my own image optimiser (ImageOptim). However, I have re-optimized it now with tinypng and saved an additional 2kb.

@apfz either "allow maintainers to update this branch" or solve merge conflicts against master.

Added in https://github.com/TowoLabs/ftso-signal-providers/commit/41b1eb24ed8b283ef053ff10ce7aeee301869e21


Fix out of bounds access to rotation array in assimp loader

🦟 Bug fix
Alternative to #478, it fixes the root cause of the issue that is undefined behavior due to access past the end of the array.
Summary
When the parsing function was written, the assumption was that the position keys array and the rotation keys array would be the same length, this proved to not be the case since they can have different lengths.
The root cause of the issue addressed through #478 was that the rotation key array only had one element while the position key array was much longer, hence we were accessing values past the end of the array which is undefined behavior and can cause all sorts of trouble to downstream users.
Other cases with other animations can cause NaN exceptions in OGRE2 that crash the whole application.
With this PR we iterate over the longest of the arrays (to make sure no data is lost) and set the access to the position / rotation keys to be the minimum between the current index and the length of the array, to avoid undefined behavior.
This means that the last key will be duplicated in case the array is shorter, but that is acceptable behavior. It seems assimp returns a rotation array of length 1 to denote that rotation does not change throughout the animation.
The first one-line commit fixes the issue we are personally observing but I added https://github.com/gazebosim/gz-common/commit/f2cb2ce011b75966849b5b946c39bfa882682820 to fix the symmetrical case
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I'm concerned that the approach of truncating the key frames to the array with a smaller number will throw away important animation information.
Instead I'd suggest fixing this by interpolating the smaller array to have the same number of key frames as the larger one, and then combining them in the poses used by the skeletal animation.


Files Share Swagger Update

Description
Updating swagger link to point to the correct SHA.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-file-share


[Release] sdk/resourcemanager/containerservice/armcontainerservice/2.3.0-beta.2

https://github.com/Azure/sdk-release-request/issues/3457

@Alancere Please regenerate this release code with correct tag.


Include the extension tarball

Install the lab extension using data_files.

cc @ jasongrout

@tacaswell, can you please enable Travis testing for this repo?  https://travis-ci.org/profile/matplotlib