Release of new component ownership structure

Motivation
As we learned in https://github.com/giantswarm/giantswarm/issues/27020 we can improve the general code organisation of our systems for higher efficiency with better engineering workflows. In this issue we want to release and roll out the changes introduced to our code structure on all providers
Todo

[ ] plan and coordinate the rollout of the new changes introduced in https://github.com/giantswarm/roadmap/issues/2742 on all providers

Outcome

We have the new structure for more efficient engineering workflows rolled out to all providers

Ticket no longer needed as it's done in the scope of the others


如何把text.h5变成pb文件

text.h5是权重，没有保存结构 当我转换的时候收到了错误
FailedPreconditionError (see above for traceback): Error while reading resource variable batch_normalization_v1_35/moving_variance from Container: localhost. This could mean that the variable was uninitialized. Not found: Container localhost does not exist. (Could not find resource: localhost/batch_normalization_v1_35/moving_variance)
[[node batch_normalization_v1_35/moving_variance/Read/ReadVariableOp (defined at /home/yuemengrui/Desktop/keras_to_tensorflow/keras_yolo3.py:43) ]]

你先重新跑一下tools底下的dartnet_to_keras.py，然后再重新导就可以了。我已经试过了，希望对你有用。

先加载模型到内存中，然后再导出


Remote terminal local echo breaks terminal wrapping

When I have local echo enabled, this happens when wrapping to scroll. Still wraps when it doesn't need to scroll.
If I disable local echo, it works as expected

thanks for the issue. I see this sometimes when copy/pasting long lines in. Doesn't happen on powershell, but does on bash or zsh

thanks for the issue. I see this sometimes when copy/pasting long lines in. Doesn't happen on powershell, but does on bash or zsh


Support of custom modelines

Are there any means to use a modeline not exported by edid?
(like e.g. in weston, cf. https://wiki.archlinux.org/index.php/wayland#Configuration (second [output]-section from bottom in ~/.config/weston.ini))

Modesetting of any kind isn't supported by WLC yet.

Am I correct that wlroots supports this now since https://github.com/swaywm/sway/issues/631, is it possible to implement this feature in sway-output now?

Sway supports this, see the man page (grep for --custom).

That only lets me specify the WIDTHxHEIGHT@RATE that's not in the EDID, not the full modeline which is often necessary for displays that do not specify an EDID at all.
In retrospect, that's not what the original issue was asking for, so I'm posting this in the wrong issue. Should I open a new one?

Can you explain why you need the full modeline? wlroots will automatically generate it.

wlroots can't automatically generate modes if there's no EDID information from the display. In that case you need to either specify the EDID blob yourself using the edid_firmware drm/kms-helper module param or if you don't have the EDID, you need to specify the full modeline. Weston has an option for this for precisely this reason, see man 7 weston-drm, search for mode=dotclock [...].

wlroots can

That's auto-detection/guessing, isn't it? How do we ensure that it's correct?

I would like support for custom (non-cvt) modelines, for switchres (a program that generates special arcade monitor modes). Would you accept a wlroots patch from me?

wlroots already supports this.
Why isn't the custom mode support enough?

The only public API seems to be wlr_output_set_mode() and wlr_output_set_custom_mode(), the latter of which at least only generates a CVT timing modeline. Arcade timings are generally non-CVT timings, generally closer to CEA timing. The main differences are active area and sync polarity, though there are also interlaced modes (gross I know).
I could also write directly to the drm device, but I don't think there is a good way to synchronize wlroots' state with it.

wlr_drm_connector_add_mode

Ah, I totally missed that was in a public header. That's exactly what I want, thanks!

Ah, I totally missed that was in a public header. That's exactly what I want, thanks!


Failed to run trunk despite trunk being installed

Current error:
[lily@localhost seedwing-policy]$ cargo run -- -p ~/.../seedwing-proxy/policy/ serve
   Compiling seedwing-policy-server-embedded-frontend v0.1.0-alpha.9 (/.../seedwing-policy/server/embedded-frontend)
error: failed to run custom build command for `seedwing-policy-server-embedded-frontend v0.1.0-alpha.9 (/.../seedwing-policy/server/embedded-frontend)`

Caused by:
  process didn't exit successfully: `/.../seedwing-policy/target/debug/build/seedwing-policy-server-embedded-frontend-fb7d3efef9c5e559/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=build.rs
  cargo:rerun-if-changed=../../frontend/Cargo.toml
  cargo:rerun-if-changed=../../frontend/Cargo.lock
  cargo:rerun-if-changed=../../frontend/Trunk.toml
  cargo:rerun-if-changed=../../frontend/package.json
  cargo:rerun-if-changed=../../frontend/yarn.lock
  cargo:rerun-if-changed=../../frontend/src
  cargo:rerun-if-changed=../../frontend/assets

  --- stderr
  thread 'main' panicked at 'Failed to run 'trunk':
  2023-03-01T17:32:58.920575Z  INFO 📦 starting build
  2023-03-01T17:32:58.922804Z  INFO spawning asset pipelines
  2023-03-01T17:32:59.265028Z  INFO copying directory path="assets/images"
  2023-03-01T17:32:59.265058Z  INFO copying directory path="node_modules/@patternfly/patternfly/assets"
  2023-03-01T17:32:59.265113Z  INFO copying file path="assets/codicon.ttf"
  2023-03-01T17:32:59.265123Z  INFO copying directory path="node_modules/@fortawesome/fontawesome-free/webfonts"
  2023-03-01T17:32:59.265152Z  INFO building seedwing-policy-frontend
  2023-03-01T17:32:59.265459Z ERROR ❌ error
  error from HTML pipeline

  Caused by:
      0: error from asset pipeline
      1: error taking canonical path of directory "/.../seedwing-policy/frontend/node_modules/@fortawesome/fontawesome-free/webfonts"
      2: No such file or directory (os error 2)

  Error: error from HTML pipeline

  Caused by:
      0: error from asset pipeline
      1: error taking canonical path of directory "/.../seedwing-policy/frontend/node_modules/@fortawesome/fontawesome-free/webfonts"
      2: No such file or directory (os error 2)
      Finished release [optimized] target(s) in 0.21s
  ', server/embedded-frontend/build.rs:33:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I believe that this issue was fixed by https://github.com/seedwing-io/seedwing-policy/pull/110 so I'll close this issue. Please re-open if you are still running into this.


How  can I  change  radius  in  CircleGeometry

I have draw  a lot of  circle  ,but I  can  not set a new radius  to change it
let id= primitive.geometryInstances[j].id;
let attributes=primitive.getGeometryInstanceAttributes(id);
attributes.boundingSphere.radius=this.radius;
 primitive.geometryInstances[j].geometry._ellipseGeometry._semiMajorAxis=Number(this.radius);
            primitive.geometryInstances[j].geometry._ellipseGeometry._semiMinorAxis=Number(this.radius);

Please ask your question on the Cesium community forum: https://community.cesium.com.


added button and dialog for prototyping adding labels

Signed-off-by: Gloria Gu<EMAIL_ADDRESS>
Description

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Docs update
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

Don't need it anymore.


Indexing and range lookup on datetime

I may have missed it in the doc. How can I index datetime fields and perform datetime range lookup?

+1
Regarding the documentation, even after converting a date into timestamp/Unix time (e.g. int64), the only possible comparison can be made on integers.
Any chance to add more query operations?

Really appreciate your interest in this project! Though it has been practically dormant since 2016. I'm afraid the functionality has been rather minimal and tiedot is missing an index feature suitable for range queries. Sorry about that, I hope there are more embeddable DB engines out with richer feature set.


allow time frames for metrics/viz to be adjust by user

options of last 30 days, last 6 months, or last year? or for the graph that shows a calendar year, let them choose the year, or select a custom range?

Big lift. Moving to MVP+2.

So Sarasti argued for this as well separate from Mathias. Let's see what kind of additional opinions he has that wasn't picked up by Matty.

So filters on the widgets would be amazingly useful. Since this is a Phase 2, Ernie - let's add it to things we'll be discussing with tech team here. I think it'll be essential to know how to do it in the future to keep the Dashboard fresh down the line.

We won't be able to get this in by time. Closing.


Wraps FileWriter in BufferedWriter.

BufferedWriter takes care of the closing of the writer it wraps. In previous version the FileWriter would not be closed if an exception was thrown before closing.

I see I've broken some tests. Will fix them first.


License is missing full copyright info

It only says:
Copyright (c) [year] [fullname]

@jhadenfeldt thanks!
fixed


Getting Cannot access package artifact

My project is using serverless-package-python-functions for packaging Python functions. I'm getting this error when trying to package my functions with warmup plugin
Error:
Cannot access package artifact at "_build/{serviceName}-{stage}-warmup-plugin-default.zip" (for "warmUpPluginDefault"): ENOENT: no such file or directory, access '{serviceName}-{stage}-warmup-plugin-default.zip'

Here is my warmup config in the custom stage
warmup:
    default:
      enabled: false
      cleanFolder: false
      package:
        individually: True
        artifact: ${self:custom.pkgPyFuncs.buildDir}/{serviceName}-${opt:stage}-warmup-plugin-default.zip

And the config at the function I want to warmup
  warmup:
    default:
      enabled: true

From my knowledge it's looking for the zip file containing the content of .warmup folder. So I tried to add the artifact part in my warmup config, but the error still hasn't been resolved. Would love someone could help me on this

You shouldn't really be using artifact since you are not providing your own zip.
Also indentation seems off.
This should do:
warmup:
    default:
        enabled: false
        cleanFolder: false

You shouldn't really be using artifact since you are not providing your own zip. Also indentation seems off.
This should do:
warmup:
    default:
        enabled: false
        cleanFolder: false

Hi, thanks for your input but the error still persist. I've created an example repo with the error output here
My guess would be because of the serverless-package-python-functions was tampering with the packaging stage.

Hi, sorry for the delay answering.
Did you figure this one out?
Can you set up a sample repo so I can reproduce?

Hi, sorry for the delay answering.
Did you figure this one out? Can you set up a sample repo so I can reproduce?

Yes I have a sample repo here
https://github.com/qngdt/serverless-python-package-warmup

Hi @qngdt,
Your repo is missing the package.json, so there is no way for me to know which version of serverless or the plugins you are using.
Are you using the latest warmup plugin?
You might be seeing an issue that was introduced in v6.1.0 and fixed in v7.0.1

Hi @qngdt,
Your repo is missing the package.json, so there is no way for me to know which version of serverless or the plugins you are using.
Are you using the latest warmup plugin? You might be seeing an issue that was introduced in v6.1.0 and fixed in v7.0.1

Hi @juanjoDiaz,
I have updated the repo with the package.json files. Sorry I did not realize that the example repo from serverless doesn't contain those. The error is still persist though.
Thanks for still keep eye on this issue.

Hi @qngdt,
The problem is here: https://github.com/ubaniabalogun/serverless-package-python-functions/blob/c8ce439fa46534716d0ebb9fa7e63298960474b0/index.js#L40-L46
The warmup plugin does a process to reset missconfigurations applied by plugins like serverless-package-python-functions, webpack, bundle, etc.
Unfortunately, because the serverless-package-python-functions plugin doesn't override the config but modifies. The fix doesn't work here.
The plugin should not modify functions that are not even Python to start with. Adding a check for that would be trivial.
Another solution could be for the author of the plugin to update his code so it overrides the setting, doesn't update the actual object:
  autoconfigArtifacts() {
    _.map(this.serverless.service.functions, (func_config, func_name) => {
      let autoArtifact = `${this.buildDir}/${func_config.name}.zip`
      func_config = {
        ...func_config,
        package: {
          ...func_config.package,
          artifact = func_config.package.artifact || autoArtifact,
        }
      }
    })
  }

So, unfortunately, you need to create an issue or a PR on that plugin. And it doesn't seem very well maintained 🙁


[Bug] cannot complete within constructor

Impact Target

v0.25.0-unstable

Steps
complete "typedef f($a : String) { var b = $a; $b."

Problem
cannot complete method names

close in commit 780fdf9ee2a1daaff4f62b41481f8adf5d1e9dac


Netflix Conductor 2.15.0 to 2.18.0

Notable:

new task for do-while loop
lots of bugfixes

Any idea why the Dockerhub build failed? Do we need/leverage that image?

@chessracer - yeah, I had an old class (CCCHttpTask) that no longer compiled after the base image changed a protected var name.  So, in the merge I removed that class, we'll update the class and new var name in our repo.


refactor: remove lib prefix from route values service

Issue or need
Route values service isn't publicly exposed. No need to add lib prefix then to avoid collisions

Proposed changes
Remove lib prefix name from route values service

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#837  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Google App Engine example doesn't work with Mozilla Firefox

Hi
I'm beginner on developing apps on GAE and started with a simple app that uses facebook login. Got your code example (for facebook login on GAE) and discovered it doesn't work fine with Mozilla Firefox.
Here is my app: ciro-app-id.appspot.com
When the user logs in with the facebook account, Firefox starts some kind of infinite requests loop.
This log has been taken from GAE logs and repeats itself for each request made by Firefox:
2013-10-22 19:14:42.364 / 200 109ms 1kb Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)
<IP_ADDRESS> - - [22/Oct/2013:19:14:42 -0700] "GET / HTTP/1.1" 200 1303 - "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)" "ciro-app-id.appspot.com" ms=109 cpu_ms=70 cpm_usd=0.000146 app_engine_release=1.8.6 instance=00c61b117c5ef2a696a0544fcffd207dae4362
In other browsers, the code works perfectly.
What can you tell me to do?

Unassigning myself since it is pretty clear that I am not going to get a chance to look at this anything soon.


WalletConnect connection to Hydra doesn't work

When connecting to walletconnect following the wiki, nothing happens and the following is printed in the console.

closed by #483


StartTlsIntegrationTestSuite/StartTlsIntegrationTest.SwitchToTlsFromClient/0 flakes on coverage

https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/74596/logs/245
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/74598/logs/241
I have no idea why this started flaking but @cpakulski could you take a look?

@alyssawilk I am looking at it.

Also failing on Window CI, not just coverage.
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/74729/logs/170

@bryce-anderson

I think this is caused by https://github.com/envoyproxy/envoy/pull/15443

If it is a blocker, please revert the PR until we correct it.

@antoniovicente Thanks for reviewing and merging!


[SPARK-28054][SQL][FOLLOW-UP] Fix error when insert Hive partitioned table dynamically where partition name is upper case

What changes were proposed in this pull request?
This is a small follow-up for SPARK-28054 to fix wrong indent and use withSQLConf as suggested by @gatorsmile.
How was this patch tested?
Existing tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12122/
Test PASSed.

Test build #106917 has started for PR 24971 at commit 2c2c129.

Test build #106917 has finished for PR 24971 at commit 2c2c129.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106917/
Test PASSed.

also cc @HyukjinKwon @cloud-fan

ping?

Merged to master.


Vision Position constantly re-initializing

Using vision position constantly prints out "EKF commencing external vision position fusion", and resets the estimator.
I believe the fix is to add the following directly after line 152 of control.cpp (where it says resetHeight();):
_control_status.flags.ev_pos=true;
This follows the same convention as the ev_yaw conditional below it and works well in simulation.

@lachyd How are you simulating vision estimates in simulation?

Using gazebo and ROS. I have a laser scanner mounted on the drone in my gazebo model, which I feed into an SLAM algo and pass the resulting coordinates to PX4 via the mavros vision position topic.

What Z position measurement are you sending with the pose? The scanner only gives you a 2D estimate.

I'm using a rangefinder for the Z measurement.

Makes sense. Can you please send in a pull request with your fixes?

Done, thanks!


feat: impl btc proof generator

how about use a separate repo ?
we can use this tool by download release or cargo install btc-proof-generator --git https://github.xx.git --tag vx.x.x ?
then, the updates of this tool and toCKB can be separated

how about use a separate repo ?
we can use this tool by download release or cargo install btc-proof-generator --git https://github.xx.git --tag vx.x.x ?
then, the updates of this tool and toCKB can be separated

It is still in active development, and the codes are tightly connected. I think we can leave it here.
We do not need to use a separate repo to support cargo install, it can find the crate in the workspace. And if we publish it on crate.io, we can use cargo install btc_proof_generator directly.


Make the caniuse script quieter for testing

While playing with bringing things over from the mockup, I found that it was nice to have less output from successful npm test runs. This is, admittedly, a minor annoyance—consider it optional.

I'd like to see this fixed too. The way that I've usually fixed this in other projects is to use some kind of logger that can be configured to be silent when testing. That way the log sites don't all have to check the "log level", which is a boolean in this case.
In BCD we have a custom logger, but a simple one using winston can be found here:
https://github.com/foolip/mdn-bcd-collector/blob/main/lib/logger.ts
WDYT about doing something similar here?

That's a good idea. I figured I ought to do something like that (and use an arg parsing library but that's a different can of worms) but I didn't have a library in mind. Glad to take this suggestion. 👍


fix ：#3434

fix ： #3434
Reduce client appearance Exception：the consumer's subscription not latest.
Increase the speed of consumers from starting to consuming.

Too many blank updates, please check the code format setting.

ok

see #3496

Coverage increased (+0.6%) to 55.105% when pulling 852b37ff0fe6694fe87d3d056b85b9b0d32e4d65 on Cczzzz:master into fe72057abc21cbdc17b46548971a3101defd172c on apache:develop.


Adds test back to show bug-28 (unparser deadlock) is fixed

dev branch, and this remains a snapshot version until daffodil 3.4.0 is released.

+1 though this PR contains two commits, I think one is from another merged commit.

Fixed the extra commit. Dev was behind 1 commit.


Tool Library and Tool Generation

The tool library can be something similar to prompt library which we have in watsonx.ai prompt lab, it will have a list of all working and properly tested tools and can be searched using the user tool requirements or tool description, also if the tool is not present in the library then it can have a option to generate the python function for a tool based on the tool requirements.
this feature can help non technical users to create agents.

I have added the same issue to bee-ui, not required here


[QUESTION] Docker image build

Hello I have problems when executing the .bash it appears "the inventory-hunter docker image does not exist ... please build the image and try again" but I already made the image and I don't know what to move it, it would be very kind of you if you supported me maybe I did something wrong but I follow all the steps you have

The first thing that comes to mind is that maybe the docker image was built with a different name than "inventory-hunter". Can you check the output of this command: docker images inventory-hunter

Yes, i think is that i don't know why

It appears the docker build command failed with "pip ... returned a non-zero code: 139". Never seen this error before!
A quick Google search suggests that something is segfaulting during the build.
Which model of Raspberry Pi are you using? I used a Raspberry Pi 3 Model B, which has 1 GB of RAM. It is possible that models with less memory aren't capable of building this Docker image (you can check how much memory your Raspberry Pi has with the free -h command).

It appears the docker build command failed with "pip ... returned a non-zero code: 139". Never seen this error before!
A quick Google search suggests that something is segfaulting during the build.
Which model of Raspberry Pi are you using? I used a Raspberry Pi 3 Model B, which has 1 GB of RAM. It is possible that models with less memory aren't capable of building this Docker image (you can check how much memory your Raspberry Pi has with the free -h command).

Ohhh... Yeah i think is that i have de first model with 500Mb lol, well thanks for the repply ill try to buy other with more Ram!

Other users reported similar build issues, so I make the lxml dependency optional: https://github.com/EricJMarti/inventory-hunter/issues/32#issuecomment-736225183


UI breaks after expanding a validator quickly after reload

open https://wallet.oasisprotocol.org/account/oasis1qq3xrq0urs8qcffhvmhfhz4p0mu7ewc8rscnlwxe/stake
open console and simulate slower network Network Throttling: Fast 3G
reload page
quickly click Staking Fund (before GetEpoch request?)
UI disappears

@matevz  Seems to be caused because props are readonly, and sort mutates original array
https://github.com/oasisprotocol/oasis-wallet-web/blob/e994b39d61e9362af7f30a7f27651fbc7862ec01/src/app/pages/StakingPage/Features/CommissionBounds/index.tsx#L54-L59

if I add .slice() to clone array before, there's no error but:

click quickly after reload
click slowly after reload

I can't seem to reproduce this. Are there issues with oasis monitor again?

I just have same problem
Http response at 400 or 500 level
The above error occurred in task ft
    created by takeEvery(network/selectNetwork, ft)
    created by ht
Tasks cancelled due to error:
takeEvery(network/selectNetwork, ft)
D@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1047878
Ft@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1070696
Ut/<@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1069926
Ue@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1056709
Be@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1056515
xt@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1064004
Tt@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1064785
r.W@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1065728
r.R@https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:1065705

@kinqsta That looks like a different problem

@matevz  I can't seem to reproduce this

Hm, I can't reproduce now either

Reproduced again by enabling Network Throttling: Fast 3G. Adding to description.

Reproduced again by enabling Network Throttling: Fast 3G. Adding to description.

Does it depend on the browser and incognito mode?

Nope, reproduced in normal Chrome and Firefox

I am able to reproduce this bug in any browser with or without extensions. I dont believe enabling Network Throttling: Fast 3G or running normally makes a difference on this bug.

I am an end user so It is difficult for me to debug when every variable and function is called Fi,Di,Li,Si. But it looks like the same bug error as posted before.
In my case specifically I cannot open info on the 'WePiggy Staking' validator. It is impossible for me to debond from them now. until this is fixed.
Another detail I dont know if matters or not is that the 'WePiggy Staking' is in between two other validators. I.e. it shows up in the middle for the UI.
Waiting an 'x' amount for time for 'y' to load makes no difference either it seems.
Please look into this, or offer an alternative to debonding as for now it is impossible. Thanks

@Boi4155 Can you check the Network tab if there are any failed requests? Maybe the oasismonitor was down for a moment and wallet couldn't connect to it?

I found nothing to do with failed requests there
Here's a video, although it is pretty much the same as the top one
https://user-images.githubusercontent.com/93211952/150904287-942fa8be-7f64-4867-a60a-94bc4077204d.mp4


chore: updated doc, added tests for transferBulk, disable initializer…

… in constructor for impl

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[AST] AssociatedTypeDecls cannot override itself

This fixes a validation test that relied on a test timing out due to memory exhaustion and instead uses assert() directly.

@swift-ci please smoke test

Ah, thank you. Which test?


Add envoy.extension.check tool

Once envoy.code.check lands there will only be the extension metadata tool left in Envoy that requires the envoy_py_binary macro and related pytest/coverage/code
We can shift the metadata checker pretty trivially, so probably we want to do that quite quickly just for the benefit of removing so much code.
There is currently also another tool that is billed as "dependency validation" but mostly it deals with extension dependencies, im thinking we can add that to the extension.check also

cc @htuch

im thinking we should add this instead to envoy.code.check as its essentially a static code check


8 byte discriminator did not match what was expected

The wallet is connected, but not able to mint. Any ideas?

Hey @shankqr, did you end up getting this figured out. I am having the same issue.


run autotune 4am-4am instead of midnight-midnight

When COB > 0 at midnight, it messes up autotuning of CR and post-midnight basals.  Since most people's schedules mean COB=0 at 4am a lot more often than at midnight, this PR changes autotune to run 4am-4am instead of midnight-midnight to mostly avoid those issues.
Anyone installing this branch will need to re-run oref0-setup and answer Y to deleting their old cron (or manually update the autotune cron line from 12:05am to 4:05am) or their autotune will stop tuning midnight-4am basals until they do so.

From safety perspective it's probably even better to run it just before people wake up. If it changes basals it's better that the people are (near) awake. So I would even propose a 5am run.

5am risks missing breakfast, which would be bad for morning basals.

I'll just put this here...
https://www.ted.com/talks/rives_on_4_a_m

I think this is a solid change.

@jdhigh can't argue with that link on the "explanation" of 4am. 👍  for 4am (but I will still be asleep 😄 )

Installed this yesterday works well so far


Support label based slicing even for unsorted indexes?

By sorting the index under the hood, we could support label based slicing even for unordered indexes.
Does this seem like a good idea? Here is what the implementation would look like, roughly:
def slice_indexer_anyorder(idx, start=None, end=None):
    # preprocessing takes time O(n * log(n)) and space 2 * n
    # (these variables could be cached on the index)
    ordering = idx.argsort()
    reordered = idx.take(ordering)
    # query complexity is O(log(n) + k * log(k)),
    # where k is the size of the result
    start, end = reordered.slice_locs(start, end)
    return np.sort(ordering[start:end])

The main potential for confusion here is that this conflicts with the current behavior for .loc, which is to sort all values with labels between the locations of start and end if start and end are found in the index. So adding this to .loc would require deprecating the existing usage.
CC @immerrr @jreback @jorisvandenbossche

On further thought, I'm taking back my suggestion of using this in .loc (I think we already had that discussion when I added monotonic decreasing indexing). So this would just be new Index method.

Actually... I don't really see a use for this.


modem: gsm_ppp: Unable to restart modem after calling gsm_ppp_stop()

Describe the bug
After calling gsm_ppp_start() and successfully connecting to the internet, I stop the connection by calling gsm_ppp_stop(). Subsequent calls to gsm_ppp_start() do not start the modem and, when logging is enabled via CONFIG_MODEM_LOG_LEVEL_DBG=y, I can see that this is because there is a timeout occurring in gsm_configure().
The modem I am using is a Simcom SIM800. Additionally, power cycling the modem does not help which suggests that this may be a bug with the GSM code in Zephyr. I have also tried waiting for network down events and adding delays before calling gsm_ppp_start() but the issue stays the same.
I see that a similar issue was mentioned here: #52885
To Reproduce
With a GSM modem configured with the KConfig options below:

call gsm_ppp_start() after boot
after connecting successfully by waiting for NET_EVENT_L4_CONNECTED event, call gsm_ppp_stop()
after disconnecting, call gsm_ppp_start()

Expected behavior
Subsequent calls to gsm_ppp_start() should work after calling gsm_ppp_stop().

Additional context
KConfig options:
#General Config
CONFIG_NEWLIB_LIBC=y
CONFIG_SHELL=y

#Main Stack Size
CONFIG_MAIN_STACK_SIZE=4096
CONFIG_IMG_BLOCK_BUF_SIZE=2048

#Minimal Heap mem pool size for the Hawkbit working
CONFIG_HEAP_MEM_POOL_SIZE=4096
CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4096
CONFIG_MODEM_GSM_WORKQ_STACK_SIZE=4096

# Network timeout tweaks for GSM
CONFIG_NET_TCP_ACK_TIMEOUT=1000
CONFIG_NET_TCP_INIT_RETRANSMISSION_TIMEOUT=1000
CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT=5000
CONFIG_NET_SOCKETS_CONNECT_TIMEOUT=5000

# UART support
CONFIG_SERIAL=y
CONFIG_UART_ASYNC_API=y
CONFIG_NET_PPP_ASYNC_UART=y

# GSM modem configuration
CONFIG_MODEM=y
CONFIG_MODEM_GSM_PPP=y
CONFIG_MODEM_GSM_APN="internet"
CONFIG_MODEM_GSM_SIMCOM=y
CONFIG_MODEM_GSM_FACTORY_RESET_AT_BOOT=y
CONFIG_GSM_PPP_AUTOSTART=n
CONFIG_PPP_NET_IF_NO_AUTO_START=y
CONFIG_MODEM_SHELL=y
CONFIG_MODEM_LOG_LEVEL_DBG=y

# Networking
CONFIG_NETWORKING=y
CONFIG_NET_NATIVE=y
CONFIG_NET_DRIVERS=y
CONFIG_NET_PPP=y
CONFIG_NET_L2_PPP=y
CONFIG_NET_SHELL=y
CONFIG_NET_IPV4=y
CONFIG_NET_IPV6=n

# Network management events
CONFIG_NET_CONNECTION_MANAGER=y
CONFIG_NET_MGMT_EVENT=y
CONFIG_NET_MGMT_EVENT_MONITOR=y
CONFIG_NET_MGMT_EVENT_MONITOR_AUTO_START=y
CONFIG_NET_MGMT_EVENT_QUEUE_SIZE=128

# Logging
CONFIG_LOG=y
CONFIG_NET_LOG=y

@rerickson1  Can you please look at this bug please and see if it still exists?

I have no hardware to be able to test this. @bjarki-trackunit, @ycsin, @jukkar any chance you can replicate this issue?


ubuntu line ending format issue

nogger start /var/log/jetty8/
/usr/bin/env: ‘node\r’: No such file or directory
seems like this stackoverflow should fix it
https://stackoverflow.com/questions/30344858/node-script-executable-not-working-on-mac-env-node-r-no-such-file-or-directo
"There is a problem with newlines in your script. Make sure that #!/usr/bin/env node is followed by \n (unix style) instead of \r\n (windows/dos style). To fix that, use the tr command to remove \r's from your file:cat your_script.js | tr -d '\r' > fixed_script.js"

This fixes it on ubuntu
apt install dos2unix
/usr/local/lib/node_modules
find ./ -type f -exec dos2unix {} ;
But then I got a SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
and realized I needed to update my node version
sudo npm install -g npm
sudo npm install -g n
sudo n stable
Finally change the /usr/bin/node symlink like this:
sudo ln -sf /usr/local/n/versions/node//bin/node /usr/bin/node


protobuf: apply patch for python 3.7 only when building with it

Change introduced in #50672.
The patch does not apply on older protobuf like protobuf3_1
$ nix-build -E 'with import ./. { }; python3Packages.protobuf.override { protobuf = protobuf3_1; }'
unpacking sources
unpacking source archive /nix/store/1zdyl0cxaa8ha2v1zp75zzdjd6j99d0m-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/util/python/BUILD
patching sources
applying patch /nix/store/yagx7hvylnnjq7lxbcia0y5lq1r736w3-0a59054c30e4f0ba10f10acfc1d7f3814c63e1a7.patch
patching file google/protobuf/pyext/descriptor.cc
Hunk #1 succeeded at 55 (offset -1 lines).
patching file google/protobuf/pyext/descriptor_containers.cc
patching file google/protobuf/pyext/descriptor_pool.cc
Hunk #1 succeeded at 47 (offset -1 lines).
patching file google/protobuf/pyext/extension_dict.cc
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file google/protobuf/pyext/extension_dict.cc.rej
patching file google/protobuf/pyext/message.cc
Hunk #1 succeeded at 82 (offset 3 lines).
Hunk #2 succeeded at 1425 (offset -104 lines).

Since the patch isn't necessary on python versions older than 3.7, let's
only apply it for version 3.7. This means that most things using older
protobuf implementation will now be able to build when using an older
pythonPackage set (as is most probably the case anyway).
This still leaves protobuf 3.1 using packages hanging, but the errors
will be localized to those that would be breaking anyway with the
upgrade to 3.7 as default python.
This can be tested using:
nix-build -E 'with import ./. { }; python36Packages.protobuf.override { protobuf = protobuf3_1; }'

Things done

✔ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

✔ NixOS
⬜ macOS
⬜ other Linux distributions

⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
⬜ Tested execution of all binary files (usually in ./result/bin/)
⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
✔ Assured whether relevant documentation is up to date
✔ Fits CONTRIBUTING.md.

cc @lopsided98 @worldofpeace

This looks good to me, but where is protobuf_3_1 actually used? A quick grep doesn't seem to show any usages in nixpkgs. Are you using it with something out of tree?

See #51809 for a package this fixes. Since the patch won't apply with python 3.6, changing to python 3.6 is not enough to fix caffe2.

Updated with isPy37.

I'll merge #51809 once nix-review is done, hence closing this one.


fix: first code group item is not open by default

Perhaps the site will be fixed, we should wait

Perhaps the site will be fixed, we should wait

Any updates?

None that I am aware of

@roj1512 could you chip and let us know if this should be merged or if the website will be fixed instead?


RangeError: Invalid string length when building with a very large number of blogs

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
docusaurus build returns RangeError: Invalid string length when building the website with a very large number of blogs (~30K)
Error:
$ NODE_OPTIONS=--max_old_space_size=12288 npm run build -- --locale fa

><EMAIL_ADDRESS>build
> docusaurus build --locale fa

[INFO] [fa] Creating an optimized production build...

Error: Unable to build website for locale fa.
    at tryToBuildLocale (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/commands/build.js:55:19) {
  [cause]: RangeError: Invalid string length
      at JSON.stringify (<anonymous>)
      at Object.contentLoaded (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/plugin-content-blog/lib/index.js:135:104)
      at /Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/server/plugins/index.js:99:22
      at async Promise.all (index 3)
      at async loadPlugins (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/server/plugins/index.js:63:5)
      at async load (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/server/index.js:76:58)
      at async buildLocale (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/commands/build.js:95:19)
      at async tryToBuildLocale (/Users/ardavan/Documents/sample.com/node_modules/@docusaurus/core/lib/commands/build.js:46:20)
}

[INFO] Docusaurus version: 3.1.1
Node version: v20.11.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Looking at the code, it looks like JSON.stringify({ blogPosts: listedBlogPosts } is the problematic part
Reproducible demo
No response
Steps to reproduce

Generate a lot of blog posts (~30K)
run build

Expected behavior

Should build the website without any issues

Actual behavior
it throws RangeError: Invalid string length
Your environment

Public source code:
Public site URL:
Docusaurus version used:
Environment name and version (e.g. Chrome 89, Node.js 16.4):
Docusaurus version: 3.1.1
Node version: v20.11.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS):
macOS 14.3.1 (23D60)

Self-service

[ ] I'd be willing to fix this bug myself.

A 30k blog post? 🤯 why do you have so many?
Yes, it seems like we should not use JSON.stringify but instead use a serialization lib supporting streaming.
For example https://github.com/dominictarr/JSONStream#jsonstreamstringifyopen-sep-close

Note to myself: I'll probably take this opportunity to encapsulate this streaming, and expose simpler, more testable interfaces to create route data bundles because I'm not a fan of our historic plugin actions API for that:
// Create a blog archive route
const archiveProp = await createData(
  `${docuHash(archiveUrl)}.json`,
  JSON.stringify({blogPosts: listedBlogPosts}, null, 2),
);
addRoute({
  path: archiveUrl,
  component: blogArchiveComponent,
  exact: true,
  modules: {
  archive: aliasedSource(archiveProp),
  },
});

That would be more convenient to have everything handled for you, and just write:
addRoute({
  path: archiveUrl,
  component: blogArchiveComponent,
  exact: true,
  props: {
    archive: {blogPosts: listedBlogPosts},
  },
});

@slorber thanks for looking into this issue, I'm replacing Wordpress with Docusaurus and I'm migrating an existing news website. The reason for this is the simplicity, speed and the low maintenance cost of Docusaurus!
You can see it in action: https://mesghalapp.com/en/news
Currently I have two blockers:
1- Is the issue with the JSON.stringify
2- The 26mb file limit of Cloudflare

The screenshot above is for including only ~2K blogs
The JSON.stringify({blogPosts: listedBlogPosts} creates a massive file especially when the blogs are written in other languages that need to be encoded as well.

is possible to split this file into smaller files as well?

https://mesghalapp.com/en/news/archive/
To be honest I don't think Docusaurus is designed to support that kind of scale. It seems you have 2k entries just for 2024, and if it keeps growing at the same pace the build time will quickly become unsustainable.
You'd rather use a docs framework that supports server-side-rendering.
Note that the blog archive page can be disabled with option archiveBasePath: null, so it might unlock you temporary:
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-blog#archiveBasePath
But even with that solution, I doubt Docusaurus will be the best choice for your need.

@slorber thanks for info, currently I'm only keeping the news for 3 months by deleting the older ones to manage this limitation.
I feel like the build process can be improved, can you please guide me on how to debug the build and get more performance log for each step of the progress?
I'm interested in improving the build performance

I'm interested in improving the build performance

You are lucky because upcoming v3.2 release will be faster and have some basic perf logging that you can turn on with DOCUSAURUS_PERF_LOGGER=true (internal usage, not publicly documented for now).
However, it does not fix all the problems yet, and the main unfixed bottleneck remains bundling your app with Webpack for both client consumption and SSR.
Yes the build process can be improved, but this is likely quite technical and I'd prefer it to handle it myself. Most likely we will try to swap Webpack by Rspack soon and provide a flag to enable Rspack to provider an incremental migration path. But Rspack is not yet 100% retrocompatible with Webpack so it might not even work right now.

@slorber
I tried version 0.0.0-5861, and here are the results:
><EMAIL_ADDRESS>build
> docusaurus build --locale en --out-dir build/en

[PERF] Get locales to build: 0.197ms
[INFO] [en] Creating an optimized production build...
[PERF] Load - loadContext: 149.412ms
[PERF] Plugins - initPlugins: 123.724ms
[PERF] Plugin - loadContent - docusaurus-plugin-sitemap@default: 0.609ms
[PERF] Plugin - loadContent - docusaurus-plugin-google-gtag@default: 0.646ms
[PERF] Plugin - loadContent - docusaurus-bootstrap-plugin@default: 0.703ms
[PERF] Plugin - loadContent - docusaurus-mdx-fallback-plugin@default: 0.865ms
[PERF] Plugin - loadContent - docusaurus-theme-classic@default: 22.973ms
[PERF] Plugin - loadContent - docusaurus-plugin-content-pages@default: 110.539ms
[PERF] Plugin - loadContent - docusaurus-plugin-content-blog@default: 1.233s
[PERF] Plugins - loadContent: 1.234s
[PERF] Plugins - contentLoaded - docusaurus-plugin-sitemap@default: 0.081ms
[PERF] Plugins - contentLoaded - docusaurus-theme-classic@default: 0.13ms
[PERF] Plugins - contentLoaded - docusaurus-bootstrap-plugin@default: 0.207ms
[PERF] Plugins - contentLoaded - docusaurus-mdx-fallback-plugin@default: 0.254ms
[PERF] Plugins - contentLoaded - docusaurus-plugin-google-gtag@default: 1.55ms
[PERF] Plugins - contentLoaded - docusaurus-plugin-content-pages@default: 3.212ms
[PERF] Plugins - contentLoaded - docusaurus-plugin-content-blog@default: 803.121ms
[PERF] Plugins - contentLoaded: 814.188ms
[PERF] Plugins - allContentLoaded - docusaurus-plugin-content-blog@default: 0.085ms
[PERF] Plugins - allContentLoaded - docusaurus-plugin-content-pages@default: 0.089ms
[PERF] Plugins - allContentLoaded - docusaurus-plugin-sitemap@default: 0.115ms
[PERF] Plugins - allContentLoaded - docusaurus-theme-classic@default: 0.134ms
[PERF] Plugins - allContentLoaded - docusaurus-plugin-google-gtag@default: 0.152ms
[PERF] Plugins - allContentLoaded - docusaurus-bootstrap-plugin@default: 0.168ms
[PERF] Plugins - allContentLoaded - docusaurus-mdx-fallback-plugin@default: 0.185ms
[PERF] Plugins - allContentLoaded: 1.043ms
[PERF] Plugins - loadPlugins: 2.176s
[PERF] Load - loadPlugins: 2.176s
[PERF] Load - loadSiteMetadata: 0.478ms
[PERF] Load - loadCodeTranslations: 1.057ms
[PERF] Load - createSiteFiles: 195.6ms
[PERF] Loading site: 2.529s
[PERF] Creating webpack configs: 334.828ms
[PERF] Deleting previous client manifest: 0.569ms

✔ Client
  Compiled successfully in 5.21m

✔ Server

● Client █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 stored

✔ Server

[PERF] Bundling: 5:21.375 (m:ss.mmm)
[PERF] Reading client manifest: 17.088ms
[PERF] Compiling SSR template: 1.507ms
SSG - Load server bundle
[PERF] SSG - Load server bundle: 44.964ms
[PERF] SSG - Server bundle size = 29.351 MB
[PERF] SSG - Evaluate server bundle: 842.003ms
[PERF] Loading App renderer: 887.578ms
[PERF] Generate static files: 1:55.173 (m:ss.mmm)
[PERF] Executing static site generation: 1:56.080 (m:ss.mmm)
[PERF] Deleting server bundle: 2.146ms
[PERF] Executing postBuild(): 215.985ms
[PERF] Executing broken links checker: 809.84ms
[SUCCESS] Generated static files in "build/en".
[INFO] Use `npm run serve` command to test your build locally.

it looks like that Generate static files and Executing static site generation steps are taking ~4 minutes.
Is this expected?

It's more 2min than 4min, because the log is unclear but one ask is composed of another.
And yes that seems expected that rendering, minifying and wriing thousands of static files takes time.
For a blog, the number of pages to generate can grow quickly depending on your usage of tags and your pagination setting.
What takes the most time remains the bundling phase, which has not been optimized yet.

I'm currently in the process of migrating from 2.4.3 to 3.4.0 and encountered the RangeError: Invalid string length error:
Full error portion of stack trace:
Error:  HookWebpackError: Invalid string length
    at makeWebpackError (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:48:9)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3181:12
    at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:24:1)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
-- inner error --
RangeError: Invalid string length
    at ConcatSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/ConcatSource.js:76:20)
    at CachedSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/CachedSource.js:101:48)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/optimize/RealContentHashPlugin.js:170:59
    at fn (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:544:19)
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:17)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/Hook.js:18:14)
    at cont (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3178:34)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3228:10
    at symbolIterator (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3485:9)
    at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3527:9)
    at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2830:7
    at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2865:11)
    at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2818:7
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4841:18
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:68:3
    at _done (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:39:22)
    at Cache.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:113:20)
    at ItemCacheFacade.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/CacheFacade.js:141:15)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4838:25
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:91:6
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:44:11
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/cache/IdleFileCachePlugin.js:78:9
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:94:6
    at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Error:  caused by plugins in Compilation.hooks.processAssets
RangeError: Invalid string length
    at ConcatSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/ConcatSource.js:76:20)
    at CachedSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/CachedSource.js:101:48)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/optimize/RealContentHashPlugin.js:170:59
    at fn (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:544:19)
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:17)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/Hook.js:18:14)
    at cont (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3178:34)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3228:10
    at symbolIterator (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3485:9)
    at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3527:9)
    at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2830:7
    at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2865:11)
    at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2818:7
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4841:18
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:68:3
    at _done (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:39:22)
    at Cache.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:113:20)
    at ItemCacheFacade.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/CacheFacade.js:141:15)
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4838:25
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:91:6
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:44:11
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/cache/IdleFileCachePlugin.js:78:9
    at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:94:6
    at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Error:  Error: Unable to build website for locale en.
    at tryToBuildLocale (/home/runner/work/pan.dev/pan.dev/node_modules/@docusaurus/core/lib/commands/build.js:54:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /home/runner/work/pan.dev/pan.dev/node_modules/@docusaurus/core/lib/commands/build.js:65:9
    at async mapAsyncSequential (/home/runner/work/pan.dev/pan.dev/node_modules/@docusaurus/utils/lib/jsUtils.js:20:24)
    at async Command.build (/home/runner/work/pan.dev/pan.dev/node_modules/@docusaurus/core/lib/commands/build.js:63:5) {
  [cause]: HookWebpackError: Invalid string length
      at makeWebpackError (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:48:9)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3181:12
      at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:24:1)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  -- inner error --
  RangeError: Invalid string length
      at ConcatSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/ConcatSource.js:76:20)
      at CachedSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/CachedSource.js:101:48)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/optimize/RealContentHashPlugin.js:170:59
      at fn (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:544:19)
      at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:17)
      at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/Hook.js:18:14)
      at cont (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3178:34)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3228:10
      at symbolIterator (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3485:9)
      at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3527:9)
      at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2830:7
[INFO] Docusaurus version: 3.4.0
Node version: v20.15.0
      at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2865:11)
      at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2818:7
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4841:18
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:68:3
      at _done (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
      at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:39:22)
      at Cache.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:113:20)
      at ItemCacheFacade.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/CacheFacade.js:141:15)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4838:25
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:91:6
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:44:11
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/cache/IdleFileCachePlugin.js:78:9
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:94:6
      at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  caused by plugins in Compilation.hooks.processAssets
  RangeError: Invalid string length
      at ConcatSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/ConcatSource.js:76:20)
      at CachedSource.source (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/node_modules/webpack-sources/lib/CachedSource.js:101:48)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/optimize/RealContentHashPlugin.js:170:59
      at fn (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:544:19)
      at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:17)
      at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/Hook.js:18:14)
      at cont (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3178:34)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:3228:10
      at symbolIterator (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3485:9)
      at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:3527:9)
      at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2830:7
      at done (/home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2865:11)
      at /home/runner/work/pan.dev/pan.dev/node_modules/neo-async/async.js:2818:7
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4841:18
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/HookWebpackError.js:68:3
      at _done (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
      at Hook.eval [as callAsync] (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:39:22)
      at Cache.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:113:20)
      at ItemCacheFacade.store (/home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/CacheFacade.js:141:15)
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Compilation.js:4838:25
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:91:6
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:44:11
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/cache/IdleFileCachePlugin.js:78:9
      at /home/runner/work/pan.dev/pan.dev/node_modules/webpack/lib/Cache.js:94:6
      at eval (eval at create (/home/runner/work/pan.dev/pan.dev/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
}
error Command failed with exit code 1.

The site is rather large but currently builds fine on 2.4.3, although it takes upwards of 45 minutes. Should 3.x have necessarily impacted Docusaurus' ability to scale to large sites? Any other troubleshooting steps or workarounds I can/should try? I'm planning to scour the docs, release notes and issues to see if I may have missed someone else posting a solution. Thanks!

@sserrata unfortunately I don't really know what's causing the issue above, but it looks like your JS assets are too big.
Maybe under v2, you were just under the limit, and we added extra React components and features in v3 that contribute to the bundle size increase that makes you reach that limit?
I don't know for sure but I don't remember anything that could have impacted the scalability.
What I see is that the error gets emitted in RealContentHashPlugin which looks responsible for computing hashes from content string. Even though the Webpack error message is unclear, you can probably add a breakpoint or try/catch/log here to figure out which file exactly is causing the problem:

Thanks @slorber! It looks like server.bundle.js may be the culprit which I think aligns with your hunch. If the site is indeed too large, is my only recourse to reduce overall content?

@sserrata I don't really know, maybe trying to configure the server to output more and smaller chunks could help.
Worth tracking this PR (https://github.com/facebook/docusaurus/pull/10402), it's possible that Rspack will solve the problem, although it's supposed to be a port so it may have the same limitations in practice


New Roformer Models

4 days ago in this release: all_public_uvr_models, 3 new models were added:

melband_roformer_instvoc_duality_v1.ckpt | config
melband_roformer_instvox_duality_v2.ckpt | config
melband_roformer_inst_v1.ckpt | config

Will they be added to audio-separator?

They already are!
audio-separator -l
    "MDXC": {
        "MDX23C Model VIP: MDX23C-InstVoc HQ 2": {
            "MDX23C-8KFFT-InstVoc_HQ_2.ckpt": "model_2_stem_full_band_8k.yaml"
        },
        "MDX23C Model VIP: MDX23C_D1581": {
            "MDX23C_D1581.ckpt": "model_2_stem_061321.yaml"
        },
        "MDX23C Model: MDX23C-InstVoc HQ": {
            "MDX23C-8KFFT-InstVoc_HQ.ckpt": "model_2_stem_full_band_8k.yaml"
        },
        "Roformer Model: BS-Roformer-De-Reverb": {
            "deverb_bs_roformer_8_384dim_10depth.ckpt": "deverb_bs_roformer_8_384dim_10depth_config.yaml"
        },
        "Roformer Model: BS-Roformer-Viperx-1053": {
            "model_bs_roformer_ep_937_sdr_10.5309.ckpt": "model_bs_roformer_ep_937_sdr_10.5309.yaml"
        },
        "Roformer Model: BS-Roformer-Viperx-1296": {
            "model_bs_roformer_ep_368_sdr_12.9628.ckpt": "model_bs_roformer_ep_368_sdr_12.9628.yaml"
        },
        "Roformer Model: BS-Roformer-Viperx-1297": {
            "model_bs_roformer_ep_317_sdr_12.9755.ckpt": "model_bs_roformer_ep_317_sdr_12.9755.yaml"
        },
        "Roformer Model: MB-Roformer-Inst-v1 by Kim": {
            "melband_roformer_inst_v1.ckpt": "config_melbandroformer_inst.yaml"
        },
        "Roformer Model: MB-Roformer-InstVoc-Duality-v1 by Unwa": {
            "melband_roformer_instvoc_duality_v1.ckpt": "config_melbandroformer_instvoc_duality.yaml"
        },
        "Roformer Model: MB-Roformer-InstVoc-Duality-v2 by Unwa": {
            "melband_roformer_instvox_duality_v2.ckpt": "config_melbandroformer_instvoc_duality.yaml"
        },
        "Roformer Model: Mel-Roformer-Crowd-Aufr33-Viperx": {
            "mel_band_roformer_crowd_aufr33_viperx_sdr_8.7144.ckpt": "mel_band_roformer_crowd_aufr33_viperx_sdr_8.7144_config.yaml"
        },
        "Roformer Model: Mel-Roformer-Denoise-Aufr33": {
            "denoise_mel_band_roformer_aufr33_sdr_27.9959.ckpt": "denoise_mel_band_roformer_aufr33_sdr_27.9959_config.yaml"
        },
        "Roformer Model: Mel-Roformer-Denoise-Aufr33-Aggr": {
            "denoise_mel_band_roformer_aufr33_aggr_sdr_27.9768.ckpt": "denoise_mel_band_roformer_aufr33_aggr_sdr_27.9768_config.yaml"
        },
        "Roformer Model: Mel-Roformer-Karaoke-Aufr33-Viperx": {
            "mel_band_roformer_karaoke_aufr33_viperx_sdr_10.1956.ckpt": "mel_band_roformer_karaoke_aufr33_viperx_sdr_10.1956_config.yaml"
        },
        "Roformer Model: Mel-Roformer-Viperx-1143": {
            "model_mel_band_roformer_ep_3005_sdr_11.4360.ckpt": "model_mel_band_roformer_ep_3005_sdr_11.4360.yaml"
        }
    },

The way I built it is so it pulls in the UVR config dynamically so if something gets added to UVR, it is automatically available in audio-separator too, so no action required here 😄
Thanks for the heads up though, I haven't tested those models so will give them a try later on :)

Cool!
I'll try to run them now :)

If they're good or offer something unique compared to the models I recommend already in this post, please share your findings 🙏
https://github.com/nomadkaraoke/python-audio-separator/discussions/133

I'm not the best at writing test results, but here's what I found out for myself. :)
I compared the following models:

BS-Roformer-Viperx-1297
Mel-Roformer-Viperx-1143
MB-Roformer-Inst-v1 by Kim
MB-Roformer-InstVoc-Duality-v1 by Unwa
MB-Roformer-InstVoc-Duality-v2 by Unwa

First off, I didn't hear much of a difference between MB-Roformer-InstVoc-Duality-v1 by Unwa and MB-Roformer-InstVoc-Duality-v2 by Unwa, so I'll talk about MB-Roformer-InstVoc-Duality-v2 by Unwa.

Model with the least noise: Mel-Roformer-Viperx-1143
Model with the best vocal clarity: MB-Roformer-InstVoc-Duality-v2 by Unwa

MB-Roformer-InstVoc-Duality-v2 by Unwa sounds a bit better than BS-Roformer-Viperx-1297, with clearer vocal separation, but it leaves some background noise.
MB-Roformer-Inst-v1 by Kim leaves a lot of noise, with instrumental sounds in the vocals and vice versa.
My personal ratings on a 10-point scale:
BS-Roformer-Viperx-1297                    - 8/10
Mel-Roformer-Viperx-1143                   - 7/10
MB-Roformer-Inst-v1 by Kim                 - 5/10
MB-Roformer-InstVoc-Duality-v1 by Unwa     - 9/10
MB-Roformer-InstVoc-Duality-v2 by Unwa     - 9/10

I'd give MB-Roformer-InstVoc-Duality-v2 by Unwa a 10 out of 10 if it didn't have background noise. I think it's a great model (personally for me)!

I tested these models on just one audio file, so the results might be different on other audio.

Nice, thanks for sharing! I'll check out the duality V2 model myself on some of my tracks later, if it's good enough to replace the current default model I might swap it out

Nice, thanks for sharing! I'll check out the duality V2 model myself on some of my tracks later, if it's good enough to replace the current default model I might swap it out

how to load melband_roformer_instvox_duality_v2.ckpt, I got an error RuntimeError: The size of tensor a (250047) must match the size of tensor b (485100) at non-singleton dimension 2


Unexpected breaking change in v0.24.0

Describe the bug
While updating from 0.23.4 to 0.24.0 (and 0.26.3) I have experienced all my tests failing with the same cause. I have went through the changes, but couldn't notice anything that could cause them to break.
My tests are using Solid.js and it looks like not all effects are executed or awaited. Mocking the timers does not help.
Reproduction
https://github.com/Exelord/solid-proxies/pull/115
System Info
System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 36.93 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.12.1/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v18.12.1/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Safari: 16.2
  npmPackages:
    vite: ^4.0.3 => 4.0.3
    vitest: ^0.23.0 => 0.23.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

To be honest, I am not sure why it worked before 🤔 solid always had a problem, because it resolves to two different solid instances. Adding this to you config helps:
  resolve: {
    conditions: ["browser"],
  },

Thank you @sheremet-va, that seams to work!
Would you mind sharing how can I check the resolutions? Also I knew there was a way to dump vitest build, however I coudn't find it in docs. That would be really helpful. I would like to understand the real cause behind it.
You are also right about the solid-js/server. Im curious why it was before resolved to to dev 🤔


[Feature request] Update Node.js version

As 8.x will be deprecated(EOL) in 2019 December, digdag-ui should support Node.js 10 and 12 and drop 8.x support in the near future.

Hello, @inductor
Thank you for telling us that information. We will appreciate if you create that PR.


Unable to resolve path to module error when building (nextjs) in server

When I build the project ( Nextjs ) in the server then I receive the following error:
./pages/assets/index.js
13:21  Error: Unable to resolve path to module 'local-storage-fallback'.  import/no-unresolved

assets page is rather long and imports the package like this:
import storage from 'local-storage-fallback';

when I run the same build script (yarn build) locally, then it works just fine. And the weirdest part is that the package is installed:
johndoe@server:~/dashboard-project$ ls -la node_modules/ | grep local-storage
drwxr-xr-x   3 r00t     r00t       4096 Jun  3 08:30 local-storage-fallback

Do you have any idea why it is happening with this particular package? I've installed them over and over by clearing the whole node_modules folder and reinstalling and that does not seem to improve anything either.

Ah, I see it's only happening on your server? If it's working locally, but not on the server there must be some kind of difference. Permissions, node versions, etc

sure, but why it's just with that single package? Especially after I went ´rm node_modules/ -rf´ and then installed everything again with same permissions?


More tuples!

Our function signatures are really long.
We need to use tuples / containers to pack arguments into Tuples or NamedTuples. Which groups make sense? The major ones I see are the source terms, the solution vector (u, v, w, T, S), and perhaps also parameters (eos, closure, constants, and g).
This may be helped by solving #163... but until then we can use tuples).
In addition @vchuravy suggested that we should pack the indices i, j, k into a tupled-index... perhaps I = (i, j, k) (or we can just use CartesianIndex).
For that, adding a convenience function to #249 to get the correct index associated with the intended ThreadsBlocksLayout for a given kernel might make sense.

Not sure if this helps with some of the issues discussed in #290, but it might.

Resolved bit-by-bit in many PRs.


Persistent bottom sheets should use state routes not ephemeral routes

[ ] Scaffold API to show a bottom sheet (contents to put on a Material).
[ ] Push a StateRoute when you show a bottom sheet.
[ ] Assert if you try to show a bottom sheet while showing a bottom sheet.
[ ] Support dragging a bottom sheet out.
[ ] Support animating a bottom sheet in and out.

[ ] do this without breaking the tests


BUG: Shap error after XGBoost classifier

Issue Description
I am trying to understand my XGBoost model using shap.
To the model I feed data in form of a dataframe with most columns having either -1,0,1 as values. 1 column has numerical values.
Code looks like this:
    n_estimators = 200000
    early_stopping_rounds = 10000

    max_depth=50
    #----- train: BUY ------
    X,y = getData(trainingStartDate, trainingEndDate, "buy")
    X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=0.2, stratify=y)
    buy_xgb = xgb.XGBClassifier(objective='binary:logistic',
        missing=1,
        eval_metric='aucpr',
        early_stopping_rounds=early_stopping_rounds,
        n_estimators=n_estimators,
        max_depth=max_depth)
    print(f"Training BUY model with {round(sum(y_train)/len(y_train)*100)}% targets")
    buy_xgb.fit(X_train, y_train, verbose=False, eval_set=[(X_test, y_test)])

The model works perfectly when trying to predict new values.
when trying
explainer_buy = shap.TreeExplainer(buy_xgb)
I get following error:
File /opt/conda/lib/python3.10/site-packages/shap/explainers/_tree.py:1778, in XGBTreeModelLoader.get_trees(self, data, data_missing)
   1774 self.features[i,j] = self.node_sindex[i][j] & ((np.uint32(1) << np.uint32(31)) - np.uint32(1))
   1775 if self.node_cleft[i][j] >= 0:
   1776     # Xgboost uses < for thresholds where shap uses <=
   1777     # Move the threshold down by the smallest possible increment
-> 1778     self.thresholds[i, j] = np.nextafter(self.node_info[i][j], - np.float32(np.inf))
   1779 else:
   1780     self.values[i,j] = self.node_info[i][j]

FloatingPointError: underflow encountered in nextafter

I already tried it with less estimators (20k). Still doesnt work.
Any idea on how to solve?
Minimal Reproducible Example
import shap
import xgboost as xgb

    buy_xgb = xgb.XGBClassifier(objective='binary:logistic',
        missing=1,
        eval_metric='aucpr',
        early_stopping_rounds=early_stopping_rounds,
        n_estimators=n_estimators,
        max_depth=max_depth)
    print(f"Training BUY model with {round(sum(y_train)/len(y_train)*100)}% targets")
    buy_xgb.fit(X_train, y_train, verbose=False, eval_set=[(X_test, y_test)])

explainer_buy = shap.TreeExplainer(buy_xgb)

Traceback
---------------------------------------------------------------------------
FloatingPointError                        Traceback (most recent call last)
Cell In[344], line 4
      1 #%%time
      2
      3 # Calculate SHAP values
----> 4 explainer_sell = shap.TreeExplainer(sell_xgb)
      5 explainer_buy = shap.TreeExplainer(buy_xgb)
      7 np.seterr(all='ignore')

File /opt/conda/lib/python3.10/site-packages/shap/explainers/_tree.py:166, in TreeExplainer.__init__(self, model, data, model_output, feature_perturbation, feature_names, approximate, **deprecated_options)
    164 self.feature_perturbation = feature_perturbation
    165 self.expected_value = None
--> 166 self.model = TreeEnsemble(model, self.data, self.data_missing, model_output)
    167 self.model_output = model_output
    168 #self.model_output = self.model.model_output # this allows the TreeEnsemble to translate model outputs types by how it loads the model

File /opt/conda/lib/python3.10/site-packages/shap/explainers/_tree.py:976, in TreeEnsemble.__init__(self, model, data, data_missing, model_output)
    974 self.original_model = model.get_booster()
    975 xgb_loader = XGBTreeModelLoader(self.original_model)
--> 976 self.trees = xgb_loader.get_trees(data=data, data_missing=data_missing)
    977 self.base_offset = xgb_loader.base_score
    978 self.objective = objective_name_map.get(xgb_loader.name_obj, None)

File /opt/conda/lib/python3.10/site-packages/shap/explainers/_tree.py:1778, in XGBTreeModelLoader.get_trees(self, data, data_missing)
   1774 self.features[i,j] = self.node_sindex[i][j] & ((np.uint32(1) << np.uint32(31)) - np.uint32(1))
   1775 if self.node_cleft[i][j] >= 0:
   1776     # Xgboost uses < for thresholds where shap uses <=
   1777     # Move the threshold down by the smallest possible increment
-> 1778     self.thresholds[i, j] = np.nextafter(self.node_info[i][j], - np.float32(np.inf))
   1779 else:
   1780     self.values[i,j] = self.node_info[i][j]

FloatingPointError: underflow encountered in nextafter

Expected Behavior
Give back shap values
Bug report checklist

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest release of shap.
[ ] I have confirmed this bug exists on the master branch of shap.
[ ] I'd be interested in making a PR to fix this bug

Installed Versions
shap version: '0.43.0'

Thanks for the bug report. I checked this on the latest master and it seems like this is a dataset specific problem. This works:
import shap
import xgboost as xgb
import sklearn

X, y = shap.datasets.adult(n_points=50)
X_train, X_test, y_train, y_test = sklearn.model_selection.train_test_split(X, y)
buy_xgb = xgb.XGBClassifier(objective='binary:logistic',
    missing=1,
    eval_metric='aucpr',
    early_stopping_rounds=1,
    n_estimators=10,
    max_depth=2)
print(f"Training BUY model with {round(sum(y_train)/len(y_train)*100)}% targets")
buy_xgb.fit(X_train, y_train, verbose=False, eval_set=[(X_test, y_test)])

explainer_buy = shap.TreeExplainer(buy_xgb)

Could you please provide some dummy dataset where this happens, so that we can reproduce the issue?

I just encountered this myself, but am mystified. I think this might be more of a core numpy bug (or something) because the np.nextafter function that actually raises the error fails when the first argument is 0 (screen shot):

This is on numpy==1.26.4 in a Python 3.10 env.. However, I installed numpy==1.26.4 in a clean Python 3.10 env to play around and could not reproduce the error. So It seems like something complex is happening.


Fix prometheus/promu#65 by compiling only provided ARM platforms

Should be merged just before merging promu's PR

Fixed

Still WIP?

Nop

My bash parser in my head isn't that good, but looks good as far as I can see.
:+1:


Introduction to Double Pointers

Proposed changes
Double pointers has been explained with relevant code snippets including declaration and initialization of Double Pointers and a brief idea of Pointer Arithmetics..!
Reviewers:
This will be filled by the people who review this particular Pull Request.

How to use Checkbox in PR Templates

u just have to put x in the between the square brackets and remove blank space it will do it and that tab called "Preview" u can use it to see how it will look.


[ubuntu] Fix static path in install.sh

Description
As pointed out by @luka5 in https://github.com/actions/runner-images/pull/9114, ubuntu build script contains statically defined path. This PR adds INSTALLER_SCRIPT_FOLDER variable usage instead.
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run ubuntu2004,ubuntu2204


Rename "nodeHost" to "consulAgentLocation"

"nodeHost" is misleading - use "consulAgentLocation" to refer to the IP location of consul agent.

not relevant anymore.


Add SSH/v2 subprotocol & schema for use with X/SSH grabs

This updates our SSH transform to work with the new v2 subprotocol we defined and output the new schema we defined. The old SSH/banner subprotocol has been completely removed.
This PR is compatible with the latest ZGrab from master (currently https://github.com/zmap/zgrab/commit/4c4f01ee32a5b6340c1d3b8f5300502549672e5d).
ZTag usage for X/SSH scans will now be as follows: ztag -P ssh -p 22 -S v2.
Example input (grab) and output (tagged) is available at https://gist.github.com/cdzombak/2987d220fcfd938b67526192e5cba5dd.

Should we merge the server_key_exchange and key_exchange dictionaries, too?

Example input (grab) and output (tagged) is available at https://gist.github.com/cdzombak/2987d220fcfd938b67526192e5cba5dd

@dadrian ddc6a9a9215b08107a00cbca7fc3497a7de62af9 removes certkey_public_key.key.raw.
I also notice that ztag_ssh_signature is used for the certkey public key, and includes raw too:
ztag_ssh_signature = SubRecord({
    "parsed":SubRecord({
        "algorithm":CensysString(),
        "value":IndexedBinary(),
    }),
    "raw":IndexedBinary(),
})

Should we keep raw here or simplify this signature structure?

@dadrian per our Slack chat, 2e6171ca21ce16ae680af38eb1051dde461f6e54 makes the SSH certkey_public_key signature structure consistent with zgrab_parsed_certificate's signature.

Thanks, @dadrian. I'll wait for a review from @zakird, too, before merging.

I'll try to take a look this afternoon.
On Tue, Aug 1, 2017 at 12:37 PM, Chris Dzombak<EMAIL_ADDRESS>wrote:

Thanks, @dadrian https://github.com/dadrian. I'll wait for a review
from @zakird https://github.com/zakird, too, before merging.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmap/ztag/pull/76#issuecomment-319426066, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMSUCgXH_Sny6nYF51E8aUvbHzbKtHvks5sT1Q7gaJpZM4OaVc2
.

This looks fine to me. Please remember to update the schema on Elasticsearch cluster before merging to stable.


SlackReader sleep time doesn't work, getting rate limited

I get rate limited by the Slack API when using SlackReader.
I think SlackReader is supposed to sleep for a suggested time, defined in the variable: retry_after which is supposed to be intercepted from the header of the Slack API error message. It seems to always be 10 seconds and is never enough to avoid rate limiting.
I created a default wait time of 15 seconds, and added 10 seconds for each consecutive error and that seems to avoid getting rate limited.

@brainstencil how did you setup slack ? what's the meaning of <Slack API Token>  ? how to setup it ?

It seems to be solved, feel free to open a PR with this improvement
@shufanhao if needed open a new issue with your question, we will be happy to help


Add optional cache hit/miss/set log funcs to dataloader

Adds optional arguments to the load and loadMany functions in dataloader so that we can log cache hit ratios as well as the cache keys used for dataloader calls. The intent is to temporarily use this fork in apollo to allow us to inject our own logging calls without having to do too much to modify dataloader. I'll also need to publish a private npm package to use this.
Test Plan

[x] passes existing dataloader tests, linting and type checks

(Note: I couldn't make this fork private since it's a fork of a public project. So these comments are visible to the world)

@stephenh yeah, I don't currently need this. The other implementation you suggested also sounds nicer, so it feels like something that can be revisited the next time somebody wants more general dataloader metrics.


'hub browse pr' (or similar) to get the existing pull request url?

I use git browse a lot. If there's an existing PR for this branch, github will show it in a button, e.g.:

Is there was a way to have browse or similar to go directly to the PR url, if exists?
If not, does this sound like a good idea for a feature?

This would be welcome! See #1451 #1107 #897 #867
There is already a hub pr subcommand in master branch. Maybe there could be a hub pr open command for this? I don't want to extend the hub browse command further because I want to deprecate it.

Coming soon to a hub near you 😄

any updates on the hub pr show mentioned above?

@eibrahim No, but you can list open PRs for the current branch using hub api and a shell script like the following:
existing-pr() {
  local branch
  if branch="$(git rev-parse --symbolic-full-name @{upstream} 2>/dev/null)"; then
    branch="${branch#refs/remotes/}"
    branch="${branch#*/}"
  else
    branch="$(git rev-parse --symbolic-full-name HEAD)"
    branch="${branch#refs/heads/}"
  fi

  hub api -t graphql -fbranch="$branch" -fquery='
    query($branch: String!) {
      repository(owner: "{owner}", name: "{repo}") {
        pullRequests(headRefName: $branch, states: OPEN, first: 10) {
          edges {
            node {
              url
              repository {
                owner {
                  login
                }
              }
              headRepository {
                owner {
                  login
                }
              }
            }
          }
        }
      }
    }
  ' | group_edges 3 | while read -r url base_owner head_owner; do
    [ "$base_owner" != "$head_owner" ] || printf '%s\n' "$url"
  done | head -1
}

group_edges() {
  grep -F '[' | cut -f2 | xargs -L${1?}
}

existing-pr

It might look complicated, but in reality it's straightforward: it detects the current branch (taking into account upstream configuration), then lists the URLs to PRs that have the current branch as the "head" branch, excluding PRs that come from forks.

Looks like hub pr show is in https://github.com/github/hub/commit/a7426780ae1c01a72d0c4b884ef08cf0f0f934c9
Many thanks!


how to interpret the result from binary:logitraw ?

I am doing a binary classification with result_a (0 in train) and result_b (1 in train). I am expecting to get the probability of being result_b for each line of X_test.
I use objective='binary:logitraw', eval_metric='auc', however, the prediction returns a matrix of 10000 * 2 ,for a X_test with 10000 rows.
How should I interpret the result?
Here is the output:
array([[-0.62289798, -0.62402767],
       [-0.65141809, -0.64892763],
       [-0.65141809, -0.64892763],
       ...,
       [-0.06447762, -0.07959807],
       [-0.30191213, -0.30507147],
       [-0.30191213, -0.30507147]], dtype=float32)

Thank you.

you want to set not set num_class for binary classification task, it will return margin value of logistic trasnformation

Well... Ok... When I unset num_class=2 then it works as expected. Thank you.


Issue with Firefox

Description
This library works almost flawlessly with Firefox. However, there is one massive issue that I'm unable to overcome.
When logging in using this library, the login page will not auto-close on Firefox.  If I manually close the page, then login fails. However, if I refresh the login page, then the page instantly closes and I'm logged in.
Expected behaviour
The login page closes automatically after successful login.
Actual behaviour
The login page stays stuck stating that it is Waiting for <tenant>.auth0.com...
Steps to reproduce the problem

Create auth0 account
Create new application of type native
Set up the callback and origin as per this post
Create a firefox extension that uses this library
Initialize it using:

const authResult = await new Auth0Chrome(auth0Env.AUTH0_DOMAIN, auth0Env.AUTH0_CLIENT_ID).authenticate({
  scope: 'openid profile offline_access email',
  audience: '<audience>',
  device: 'chrome-extension'
})

You could also try installing my firefox extension v<IP_ADDRESS>
Language / Framework Versions

Language used: Javascript
Framework used: NA

Testing environment

Operating system: Ubuntu 18.04
Browser version: Mozilla Firefox 65.0

FYI, this is a Firefox bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=1528562 . The fix has been approved for Firefox release 67 beta 12.

Ah! Thanks for letting me know. I'll get rid of my popup telling users to hit ESC if authentication hangs


Dev

This PR

adds this new feature

Related Issues

Fixes #1234523
Notes

Follow-up Tasks

How to test

outdated


Local Bump action rewrite git owner

When using bump action locally (CLI), it may rewrite .git dir owner. Looks like it happen after the first push
qmarie@qmarie-mint:~/Sources/ski-platform$ plasmactl platform:bump dev
Image "platform-actions-bump:latest" exists locally
Configuring dev environment...
Enter password to use for both ansible vault and ssh key passphrase:
Bump versions...
Modified files in the last commit:
- interaction/softwares/roles/skilld_academy/files/skilld_academy/composer.lock
- interaction/softwares/roles/skilld_account/files/skilld_account/composer.lock
- interaction/softwares/roles/skilld_kb/files/skilld_kb/composer.lock
- interaction/softwares/roles/skilld_landing/files/skilld_landing/composer.lock
Getting Ansible inventory data...
Processing resource interaction__softwares__skilld_academy
Processing resource interaction__softwares__skilld_account
Processing resource interaction__softwares__skilld_kb
Processing resource interaction__softwares__skilld_landing
Processing resource dependency interaction__services__academy_skilld_academy
Processing resource dependency interaction__applications__academy
Processing resource dependency interaction__services__account_skilld_account
Processing resource dependency interaction__applications__account
Processing resource dependency interaction__services__kb_skilld_kb
Processing resource dependency interaction__applications__kb
Processing resource dependency interaction__services__landing_skilld_landing
Processing resource dependency interaction__applications__landing
Updating interaction__softwares__skilld_academy version
Updating interaction__services__academy_skilld_academy version
Updating interaction__applications__academy version
Updating interaction__softwares__skilld_account version
Updating interaction__services__account_skilld_account version
Updating interaction__applications__account version
Updating interaction__softwares__skilld_kb version
Updating interaction__services__kb_skilld_kb version
Updating interaction__applications__kb version
Updating interaction__softwares__skilld_landing version
Updating interaction__services__landing_skilld_landing version
Updating interaction__applications__landing version
Commits changes to updated resources
---
qmarie@qmarie-mint:~/Sources/ski-platform$ git commit
error: insufficient permission for adding an object to repository database
error: Error building trees

How to reproduce

Clone any platform
Perform an update in any software
Perform plasmactl platform:bump dev
Try to commit

Used version
qmarie@qmarie-mint:~/Sources/ski-platform$ plasmactl --version
plasmactl version v0.1.2 linux/amd64
Built with launchr version (devel) linux/amd64
Plugins:
  - github.com/launchrctl/compose v0.0.3
  - github.com/launchrctl/keyring v0.1.0

Moved into launchr repo


[Keyboard Navigation - Zoom Combo box]: The value gets selected/applied while discarding the value by Esc key

While moving within the combo box items using arrow keys, the value which is highlighted gets selected when pressing "Esc". User did not perform any action to select the item, but still the item gets selected as the value of the combo box.
Configuration:

Web browser and its version: Chrome Version 97.0.4692.71 (Official Build) (64-bit) /Edge Version 97.0.1072.69 (Official build) (64-bit)
Operating system and its version: 21H2(OS build 22000.376)
PDF.js version: 2.13.107
Is a browser extension: No

Steps to reproduce the problem:

Navigate to https://mozilla.github.io/pdf.js/web/viewer.html
Open Zoom Combo box and use arrow key to navigate to an option
Use Esc key to close the Combo box.

What is the expected behavior? (add screenshot)
The selection/value is discarded and not applied.

Operating system and its version: 21H2(OS build 22000.376)

The actual name of the OS appears to be missing here, since you've only included what looks like a version number.

Open Zoom Combo box and use arrow key to navigate to an option
Use Esc key to close the Combo box.

The change event on a <select> element fires when the element loses focus, hence this is somewhat expected unfortunately.
Furthermore, in the case when you've opened a <select> element with the mouse but then use the arrow-keys to navigate through the <option>s there doesn't appear to be any keydown/keyup events dispatched. Hence it unfortunately doesn't seem generally possible to detect this particular case (in any simple way), which as far as I can tell is basically a shortcoming of the web-platform itself rather than the PDF.js default viewer.
All-in-all, given that this is an edge-case and that the web-platform doesn't seem to provide the necessary events to handle this particular situation, closing as WONTFIX (or even can't fix really).

@Snuffleupagus, I didn't try anything maybe we could try something with :focus-visible, wdyt ?

I didn't try anything maybe we could try something with :focus-visible, wdyt ?

Sorry, but I really understand how that'd help since the problem ought to be how the JavaScript is able to detect this case!?

I thought it'd be possible to change for example the visibility of a transparent div on :focus-visible :not(:focus) and then add a js focus listener and check the visibility of the div to the in which case we are.
But as said I didn't try anything, it's just an idea.

thought it'd be possible to change for example the visibility of a transparent div on :focus-visible :not(:focus) and then add a js focus listener and check the visibility of the div to the in which case we are.

While I cannot (still) really imagine what sort of work-around you have in mind here, what you describe nonetheless sounds like something that'd potentially complicate this code quite a bit, thus hurting both readability and maintainability, in order to try and work-around what to me seems like a web-platform limitation[1] affecting an edge-case in the PDF.js viewer.

[1] The issue being that the change event always fires when the <select> element loses focus.