tell users they can what IP range Hub webhooks can come from so they can...

... filter
Docker-DCO-1.1-Signed-off-by: Sven Dowideit<EMAIL_ADDRESS>(github: SvenDowideit)
Signed-off-by: Sven Dowideit<EMAIL_ADDRESS>

@fredlf @jamtur01

LGTM


[Outlook] (manifest) no absence of mobile support for JSON manifest

Learn Build status updates of commit ca08c45:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/no-mobile-with-json-note.md
:white_check_mark:Succeeded
View

docs/outlook/add-mobile-support.md
:white_check_mark:Succeeded
View

docs/outlook/mobile-log-appointments.md
:white_check_mark:Succeeded
View

docs/outlook/outlook-mobile-addins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 98a6d69:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/no-mobile-with-json-note.md
:white_check_mark:Succeeded
View

docs/outlook/add-mobile-support.md
:white_check_mark:Succeeded
View

docs/outlook/mobile-log-appointments.md
:white_check_mark:Succeeded
View

docs/outlook/outlook-mobile-addins.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


AWS Lambda Managed Layer with Modin and Ray

As of version 3.2.0 for Python 3.10, the Managed Layer does not have modin and Ray support (https://aws-sdk-pandas.readthedocs.io/en/stable/layers.html).
Example of the outputs using arn:aws:lambda:us-east-1:336392948345:layer:AWSSDKPandas-Python310:3
Lambda function:
import logging
import awswrangler as wr
import pandas as pd
# import modin.pandas as pd
from datetime import datetime
import pkg_resources

logger = logging.getLogger()
logger.setLevel(logging.INFO)

def lambda_handler(event, context):
    logger.info(pd.__version__)
    logger.info(wr.engine.get())
    logger.info(wr.memory_format.get())

    installed_packages = pkg_resources.working_set
    installed_packages_list = sorted(["%s==%s" % (i.key, i.version)
       for i in installed_packages])
    logger.info(installed_packages_list)

    return {}

Output:
[INFO]	2023-06-30T05:22:50.451Z	78c9a486-e32d-4e56-8912-b7f7e6063475	2.0.2
[INFO]	2023-06-30T05:22:50.469Z	78c9a486-e32d-4e56-8912-b7f7e6063475	EngineEnum.PYTHON
[INFO]	2023-06-30T05:22:50.469Z	78c9a486-e32d-4e56-8912-b7f7e6063475	MemoryFormatEnum.PANDAS
[INFO]	2023-06-30T05:22:50.469Z	78c9a486-e32d-4e56-8912-b7f7e6063475	['aenum==3.1.12', 'aiohttp==3.8.4', 'aiosignal==1.3.1', 'asn1crypto==1.5.1', 'async-timeout==4.0.2', 'attrs==23.1.0', 'awslambdaric==2.0.4', 'awswrangler==3.2.0', 'beautifulsoup4==4.12.2', 'boto3==1.26.90', 'botocore==1.29.90', 'certifi==2023.5.7', 'charset-normalizer==3.1.0', 'decorator==5.1.1', 'et-xmlfile==1.1.0', 'frozenlist==1.3.3', 'gremlinpython==3.6.4', 'idna==3.4', 'isodate==0.6.1', 'jmespath==1.0.1', 'jsonpath-ng==1.5.3', 'lxml==4.9.2', 'multidict==6.0.4', 'nest-asyncio==1.5.6', 'numpy==1.24.3', 'openpyxl==3.1.2', 'opensearch-py==2.2.0', 'packaging==23.1', 'pandas==2.0.2', 'pg8000==1.29.6', 'pip==23.0.1', 'ply==3.11', 'pyarrow==10.0.0', 'pymysql==1.0.3', 'python-dateutil==2.8.2', 'pytz==2023.3', 'redshift-connector==2.0.911', 'requests-aws4auth==1.2.3', 'requests==2.31.0', 's3transfer==0.6.1', 'scramp==1.4.4', 'setuptools==67.8.0', 'simplejson==3.17.2', 'six==1.16.0', 'soupsieve==2.4.1', 'typing-extensions==4.6.3', 'tzdata==2023.3', 'urllib3==1.26.16', 'yarl==1.9.2']

Can we have managed layers that comes with modin and ray support?

Hi @kangks, our Lambda managed layers never had Ray or Modin baked in. AWS Lambda layers are limited to 250Mb unzipped and 50Mb zipped in size. Our current layer is already at 230Mb unzipped and 48Mb zipped. Ray alone is 100Mb+. So there is simply no space for it.
Beyond the size issue however, I am not sure what would be a good use case for using Ray on Lambda. The framework is dedicated to distributed computing which is not a good pattern for Lambda functions. Better options on AWS include AWS Glue jobs (including AWS Glue for Ray).
If for some reason you must install Ray on a Lambda environment, then one option is to build your own container image that would include it alongside other dependencies.


[BUG]: unexpected DROP SEQUENCE statements on drizzle-kit push

What version of drizzle-orm are you using?
0.32
What version of drizzle-kit are you using?
0.23
Describe the Bug
I want to create migrations only for "currentSchema", but when I am trying to push a new migration, drizzle kit is trying to delete sequences from other postgresql schemas

Define config

export default defineConfig({
    dialect: "postgresql",
    schema: "./src/models",
    out: "./migrations",
    schemaFilter: settings.DB_SCHEMA_NAME, // currentSchema
    migrations: {
        table: "migrations",
        schema: settings.DB_SCHEMA_NAME,
    },
    dbCredentials: {
        url: settings.DB_URL,
    },
    verbose: true,
    strict: true,
});

Define any model

export const BaseSchema = pgSchema(settings.DB_SCHEMA_NAME);
export const groups = BaseSchema.table("groups", {
    id: uuid('id').primaryKey().notNull().$default(uuid4)
});

Generate migration via drizzle-kit generate
You will see something an expected migration file without DROP statements

CREATE SCHEMA "dy_m_workflows"; -- unrelated but also a bug https://github.com/drizzle-team/drizzle-orm/issues/2335
--> statement-breakpoint
CREATE TABLE IF NOT EXISTS "dy_m_workflows"."groups" (
	"id" uuid PRIMARY KEY NOT NULL
);

drizzle-kit push

-- drizzle-kit: v0.23.0
-- drizzle-orm: v0.32.0
-- Warning  You are about to execute current statements:

CREATE SCHEMA "currentSchema";

CREATE TABLE IF NOT EXISTS "currentSchema"."groups" (
        "id" uuid PRIMARY KEY NOT NULL
);

DROP SEQUENCE "ANOTHER_SCHEMA"."cities_id_seq";
DROP SEQUENCE "THIRD_SCHEMA"."users_id_seq";

These drop statements cause errors
cannot drop sequence ANOTHER_SCHEMA.cities_id_seq because other objects depend on it
Expected behavior
This bug appers only while using drizzle-kit 0.23.
When I am using drizzle-kit 0.22.8 and drizzle-orm 0.32 everything is ok.
drizzle-kit (0.22.8) push will print something this:
-- drizzle-kit: v0.22.8
-- drizzle-orm: v0.32.0
-- Warning  You are about to execute current statements:

CREATE SCHEMA "currentSchema";

CREATE TABLE IF NOT EXISTS "currentSchema"."groups" (
        "id" uuid PRIMARY KEY NOT NULL
);

Environment & setup
postgresql with at least 2 schemas ("currentSchema" and "ANOTHER_SCHEMA")
drizzle-kit: v0.23.0
drizzle-orm: v0.32.0
using postgres.js v3.4.4

thanks, will fix that!

should be fixed in<EMAIL_ADDRESS>

This issue has started appearing for me on the latest version of drizzle

This issue still appears in<EMAIL_ADDRESS>

Issue still appears in drizzle-kit@latest

facing same issue


fixes #3 add circle-ci configuration to trigger ant junit tests

👍 I'll merge it now. Thanks Matt.


[nodejs][25.bot logging] Fix minor typos and improve Readme structure and content

Proposed Changes

Fix minor typos
Add --appId and --appSecret arguments to msbot clone services command, and instructions on how to obtain them
Update botbuilder dependency version from 4.0.6 to 4.1.5 to solve vulnerabilities issues
Improve Readme file to match other samples' Readme

Testing
Follow Readme instructions and use the bot successfully.

merge after #916 is merged.  may introduce merge conflicts, but they should be minor


Sabrina/show contextual dialogs

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208077416568654/f
Description: Implements way of showing the contextual dialogs and performing action
Steps to test this PR:

Run the app as is try some navigation and check nothing happens
Change ContextualOnboardingDialogTypeProvider so that it returns try a search
Visit any site and check the dialog appears and if you click on a search is performed
Change ContextualOnboardingDialogTypeProvider so that it returns searchDone with shouldFollowUp true
Visit any site and check the dialog appears, press got it and check the visit site dialog appears, check clicking on site navigates to it
Change ContextualOnboardingDialogTypeProvider so that it returns try a site and test as above
Change ContextualOnboardingDialogTypeProvider so that it returns trackers with shouldFollowUp true (and any message)
Visit any site and check the dialog appears, press got it and check the visit site dialog appears, check fire dialog appears
Test TryFireButton actions
test HighFive dismissal

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.
If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

hey @SabrinaTardio I’m having issues testing the PR. It dismisses the dialog as soon as the page is loaded. Video attached.
https://github.com/user-attachments/assets/6df854d5-d479-4b7e-8cde-a8a0eb3c6d48

hey @SabrinaTardio I’m having issues testing the PR. It dismisses the dialog as soon as the page is loaded. Video attached.
Screen.Recording.2024-09-06.at.4.13.59.PM.mov

hey @SabrinaTardio I’m having issues testing the PR. It dismisses the dialog as soon as the page is loaded. Video attached.
Screen.Recording.2024-09-06.at.4.13.59.PM.mov

Actually it’s all good, I noticed I put the type to return in ContextualOnboardingDialogTypeProvider  within the guard instead of outside 😫


Chinese Characters Issue

Hey @nodkz. I'm hoping you can help us. We've been in a month long slice to get our site minimally viable for a Luxury Auction sale to chinese buyers. This included a lot of hard coding of chinese characters in the code base, but now our content team is adding translations into our database. I was able to trace this down by figuring out what page it was that was throwing the issue, here's a recap.

Everything works fine, until you request the page that has the chinese characters in relay response.
After that, every new page request will fail with the error message Server does not return response for request with id q*, (* being a wildcard) when in batching mode. If i remove batch middleware its this: Failed to execute 'fetch' on 'Window': Invalid value
If i remove Relay network layer in favor of default network layer from Relay, it works (but i don't consider it a viable solution unless i have no other choices).

If you have time to look into this i would appreciate it greatly, otherwise if you could point me in the right direction to implement a fix myself that would be fantastic.

If if helps, here are the chinese characters i'm testing with: 夏季待售房产

I can see what's wrong only on the next week. It's difficult to resolve problem and point you to right place from mobile. Please try to

look at forks https://github.com/nodkz/react-relay-network-layer/network Maybe someone solve similar problem
create test with Chinese symbols which fails
look on express-graphql or relay packages and try to find there issues with Chinese or utf-16 symbols. It maybe gives some ideas.

PS. I can merge PR and publish new package from mobile.

False alarm. It was in our custom middleware for adding headers where a chinese character was actually being added into a header and causing the entire fetch utility to fail after that. My bad! Thanks @nodkz


Add with_retry component, use for Eth RPC

Adds a with_retry function to the graph prelude based on the tokio-retry crate, and uses it to wrap all Ethereum RPC calls in the Ethereum adapter.
Resolves #389, resolves #333.

I'm going to go ahead and merge this into feature/block-stream.


Which license you selected for this project?

@Genbox ,
Which license you selected for this project?
Could you please add it.

This project is distributed under MIT


Is my rotor going forwards AND backwards?

This has never happened before. How is this possible?
It looks like, approximately, every rev starting around rev 15 has one timestep that reads as rev 33. Around rev 32 or 33, it gets more mixed up with an additional rev reading out for some timesteps. It's set to start saving data at rev 35. It's saving over old data from a run that failed, but that's never been an issue before.

Do you have two or more runs saving to the same file simulataneously? It is hard to see how you would get those timestep numbers otherwise.

It's the output of the executable. I looked in the output folder for field data and they're out of order too. Specifically, the file numbers are in order, but the dates/times on which they're saved go back in forth in time. More specifically, even though I'm saving over some old data from a previous run that failed, the files that are out of order are all the new ones from the current run.

Figured it out. This is the danger of "disowning" a process to make it resistant to some failures. I do in fact have more than one simulation outputting data to the same folder. I just completely forgot that I did that. User error all the way.


Added a Java Course in free-courses-bn.md file

Added a Java Course in free-courses-bn.md file
Update free-courses-bn.md
What does this PR do?

Add resource(s)

For resources
Description

Added a Java Enterprise course

Why is this valuable (or not)?

Through this course, large-scale scalable, and reliable enterprise software and web services can be created.

How do we know it's really free?

This course is totally free, check out the website

For book lists, is it a book? For course lists, is it a course? etc.

It is a course.

Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

none of the course materials appear to be available. please double check

The course is available and free for us, I checked it twice. First of all, we need to create a free account and log in, then course materials will be visible to us.

After Login, everyone can access the whole course contents. - @eshellman


memory_profiling_bark.ipynb inconsistency

I was reading this memory_profiling_bark.ipynb notebook, and the method to test with/without CPU offloading seems a bit inconsistent to me, maybe I'm missing it.
for offload_models in (True, False):
We define offload_models in here, but don't use it anywhere in the code except prints. Shouldn't it be like
os.environ["SUNO_OFFLOAD_CPU"] = offload_models
@gkucsko

@mikeyshulman i believe fixed

just pushed a fix. Thanks for catching this bug!


Assistant generator creates a basic UI

TODOs:

[x] Add tool_choice to the New Assistant form
[ ] Add tests
[ ] README.md entry
[ ] Add command to undo/destroy generated files. Might be able to run rails destroy ... already; needs to be tested.
[ ] Implement streaming (separate PR)
[ ] Add tools to the New Assistant form (depends on https://github.com/patterns-ai-core/langchainrb_rails/issues/111)
[ ] Create empty app/tools/.keep folder

TODOs:

[x]  Add tool_choice to the New Assistant form
[ ]  Add tests (added a few extra tests for the generated views)
[ ]  README.md entry (add to existing description)
[ ]  Add command to undo/destroy generated files. Might be able to run rails destroy ... already; needs to be tested. (this works already, added to readme)
[ ]  Implement streaming (separate PR)
[ ]  Add tools to the New Assistant form (depends on Fix how Tools are stored. #111)
[ ]  Create empty app/tools/.keep folder (separate PR?)


Change zenml init --template to optionally prompt and track email

Describe changes
Add a --starter flag to zenml init to generate the starter template without prompting for user input (use default param values).
Both zenml init --starter and zenml init --template ask for a user email the first time they are used, which is tracked.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Better, I hope:


Allow more than 2-nd level domain in incoming ln-addresses

Make /api/v1/lnurlscan  no longer require exactly 2 parts for name's domain split by "."
Payment to addresses like<EMAIL_ADDRESS>is now possible.

Thank you, excellent find!


Uncaught OSError in pathlib.py line 1110

Aider version: 0.54.8
Python version: 3.9.6
Platform: macOS-14.6.1-arm64-arm-64bit
Python implementation: CPython
Virtual environment: No
OS: Darwin 23.6.0 (64bit)
Git version: git version 2.46.0
An uncaught exception occurred:
Traceback (most recent call last):
  File "runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "__main__.py", line 4, in <module>
    main()
  File "main.py", line 385, in main
    io = InputOutput(
  File "io.py", line 218, in __init__
    self.append_chat_history(f"\n# aider chat started at {current_time}\n\n")
  File "io.py", line 553, in append_chat_history
    with self.chat_history_file.open("a", encoding=self.encoding) as f:
  File "pathlib.py", line 1242, in open
    return io.open(self, mode, buffering, encoding, errors, newline,
  File "pathlib.py", line 1110, in _opener
    return self._accessor.open(self, flags, mode)
OSError: [Errno 30] Read-only file system: '.aider.chat.history.md'

Thanks for trying aider and filing this issue.
The fix is available in the main branch. You can get it by installing the latest version from github:
aider --install-main-branch

# or...

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.


Rewrite rules text on paste

Is it possible to rewrite certain texts? For example, wrap a link in a rich text. For example https://github.com/p0deje/Maccy/pull/539 to p0deje/Maccy#539 and make it clickable as well.

You can totally do that by creating a custom Shortcuts workflow. Please see some examples of how to do this in https://www.reddit.com/r/macapps/comments/11sxz5t/maccy_026/.

When I open Shortcuts.app, I can't see any options for Maccy

Make sure you use the most recent version of Maccy.


Sorting is reset when opening a loom file

Describe the bug
Sorting is reset when opening a loom file.
Steps to reproduce

create loom file
select source
set sorting
close the file
reopen
sorting reset
If you make any change in one of the cells, the sorting will start to work

Expected behavior
When opening a file, the previously selected sorting works at once
Are you using the mobile app?
No
Obsidian debug info
SYSTEM INFO:
Obsidian version: v1.4.16
Installer version: v1.4.16
Operating system: Windows 10 Home 10.0.19045
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: halcyon v0.0.3
Snippets enabled: 2
Restricted mode: off
Plugins installed: 37
Plugins enabled: 29
1: Tasks v5.3.0
2: Meld Encrypt v2.3.5
3: Paste URL into selection v1.7.0
4: Shortcuts extender v2.2.0
5: Recent Files v1.3.8
6: Find orphaned files and broken links v1.9.1
7: Smart Random Note v0.2.1
8: Note Refactor v1.8.2
9: Buttons v0.4.19
10: Iconize v2.8.0
11: RSS Reader v1.2.2
12: Kanban v1.5.3
13: Dataview v0.5.64
14: Commander v0.5.1
15: File Info Panel v1.3
16: Editing Toolbar v2.4.0
17: Pane Relief v0.5.2
18: Telegram Sync v2.2.0
19: Text Extractor v0.4.9
20: Vault Statistics v0.1.3
21: Omnisearch v1.20.2
22: Image Toolkit v1.4.1
23: Tag Wrangler v0.6.1
24: Plugin Update Tracker v1.5.2
25: Templater v1.18.3
26: Update modified date v1.3.2
27: Advanced Tables v0.19.1
28: DataLoom v8.15.10
29: Pomodoro Timer v1.0.5
Relevant log output
No response

When I open the file, I see this

If I select sorting again, the situation is corrected.

Have the same problem, just that the sorting resets also after short period when i with the file.


AE Reference inputs should exclude superseded values

E.g. when unpacking or adding transaction items

Many apologies, this was posted in error. Please delete or disregard.


increased version number to 3.0

changed vr global name from openVR to vr

line 438  of vr_companion.py  not sure where this function is
FreePIE_version_2_0_required()
but maybe it should be renamed to something like
Validate_Freepie_Version()

line 438 of vr_companion.py not sure where this function is
FreePIE_version_2_0_required()
but maybe it should be renamed to something like
Validate_Freepie_Version()

It does not exists, thus it throws an error and stops the script with a "more readable" message :D


How to Start Examples

I've tried doing mix do deps.get,app.start and the servers shut down immediately.

each example is standalone, for echo_server, run
> cd echo_server
> mix deps.get
> iex -S mix

Cool. I'll submit a PR explaining that. Just so no one runs into the same issue ;)


Connect stackedit in Google Drive to other text file types like *.tex

Stackedit would be great for offline editing of (la)tex files stored in Google Drive. However, open a *.tex file with stackedit is not possible before renaming the file to a *.txt file.
I'm not really in programming of chrome web apps but I assume modifying the Google Drive mime type list in manifest file (as explained here: https://developers.google.com/drive/v2/web/listing) should be an easy solution.

Closing this. StackEdit being a Markdown editor, why would it open some other formats, and why Tex more than another ?


[vcpkg] Optionally limit the number of cores during vcpkg bootstrap

Add an option to the bash bootstrap script that allows a user to force the use of only a single CPU during both compilation and linking of the vcpkg executable.
Building on low-memory / high-core count systems like 1-2 GB variants of Raspberry PIs will often fail because of memory exhaustion.  Each compile will typically take a few hundred MB and running 4 of them concurrently will easily exhaust even a 2GB setup.  Further, such systems often have no swap space configured.  This command line option ensures that vcpkg will bootstrap successfully, albeit slowly, even when only 1GB of ram is available.
This PR does not attempt to address any similar issues that might arise from building packages using vcpkg

What does your PR fix?

Fixes #14534

Which triplets are supported/not supported? Have you updated the [CI baseline]

This is a modification to the bootstrap script and should have no impact on the triplets, only a potential impact on the speed of bootstrapping.

Does your PR follow the maintainer guide?

Yes.  The vast majority of the guide doesn't apply since this is a change to the boostrapping mechanism, not to any port or vcpkg functionality.

N/A

Could this feature also be implemented when compiling packages? Would be nice to leave half of the cores unattended when compiling big packages, i.e. Qt, to do other work to spend time.

@aizuon It would be inconsistent.  As far as I understand, not every package uses CMake for the build wrapper, and the approach here only works with CMake.  It's likely that there may be some necessary similar feature that would be useful for package building, but this PR is just focused on the bootstrap process and unblocking people in the situation described above.

@aizuon You can try setting the VCPKG_MAX_CONCURRENCY environment variable which most buildsystem helper functions support (there may be some ports with weird buildsystems that won't).

I feel like it would make more sense to just make bootstrap respect VCPKG_MAX_CONCURRENCY

@ras0219 I've modified the build script to respect VCPKG_MAX_CONCURRENCY and removed the other modifications.  I feel like it would be helpful to have some text in the -help output but I couldn't come up with something both informative and concise, so I left it as is.


Fcitx5-mozc always shows a vertical candidate list

I disabled "vertical candidate list", but fcitx5-mozc always shows a vertical list.

this is by design.. because mozc doesn’t really work for horizontal list.
the input method code is allowed force a layout if it wants to.


ci(actions): Change actions/checkout version

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Relates to https://github.com/ScoopInstaller/GithubActions/issues/21

[x] I have read the Contributing Guide.

Just a note: The title should be (chore): CI: Change actions/checkout version so that it gets ignored in the log.


Date Range Selection while adding contribution

Is your feature request related to a problem? Please describe.
I would like to have an option select date range when we add a contribution. We do some of the activities through out the year. For example, Sitecore Mentorship Program, Leading Sitecore User Group, etc. In this scenario, it is too much to add an entry for all the things we do as part of these activities. It would be good to have an option to select a date range in this scenarios.
Describe the solution you'd like

Describe alternatives you've considered

Additional information

Hi @khushboosorthiya ,
The current MVP application is being run from the new repo here: https://github.com/Sitecore/XM-Cloud-Introduction, this repository will be archived in the coming weeks.
Can you please post your issue in that repository so it can be tracked there?
Thanks

Sure. Thanks @robearlam

Closed as this repository is being archived.
This has been addressed in the new repository.


Support for aws_db_instance_role_association

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Yes ✅: please list the AWS provider version which introduced this functionality

aws provider: 2.33.0
Is your request related to a problem? Please describe.
N/A
Describe the solution you'd like.
Support for aws_db_instance_role_association to allow RDS instance to interact with AWS services (like s3) would be better integrated in this RDS module.
Describe alternatives you've considered.
Additional context
e.g. RDS SQL Server .ispac package import to SSIS, but used also for PostgreSQL and Oracle.

Hi,
some news on this.

This issue has been resolved in version 6.2.0 :tada:


HSD- 261 Update CheckmarkCard disabled UI

Problem/Feature

To support the work in an upcoming project, we had to implement some changes to the disabled state of the CheckmarkCard:
Update the UI
We removed all shadows and set a grey background (grey.200). Avatar is faded out and the heading/subtitle color are slightly lighter

Add tooltip support to the whole card
By passing a cardTooltipText prop to the CheckmarkCard, a tooltip will appear on focus/mouseover. The tooltip will still work when the card is disabled

Focus ring
we migrate the component to use the focusRing mixin for both the card and mark component. It simplifies the code but nothing should have change visually

@phamburglar @tinkertrain It's possible to hide the focus state on when the CheckmarkCard is disabled. I did include it here because I wanted to show the tooltip by both mouse and keyboard.
The question is, what is more inline with a11y here:  not focusable when disabled or not being able to show the tooltip when keyboard navigating to it 🤷. There is no perfect answer here I guess. The call we'll made will be the right one.
Long story short, anything's possible here 😄

@plbabin @tinkertrain Went down a mini rabbit hole and came across this link that explains how to make our scenario more accessible.
tldr; We should allow it to be focusable, even when disabled so that the user can see the tool tip. Essentially the "greyed" out opacity state will visually let them know it's disabled, but the focusable state will allow them to display the tooltip in line with what they're focused on. 👍

@phamburglar so are we good with the changes in this PR? I know you approved it but just want to make sure that everything's ok following the a11y discussion


Add a willChangeState delegate method

Easy addition: Add a willChangeState delegate method.

I'll fork and take care of this


[WIP] Docker containers for HealthPro

This is PR is for discussion on a way to unify on a Docker container rather than relying on various versions of PHP/MySQL/etc. It can be discarded in favor of a better solution later.
Known issues:

[ ] Bootstrapping the database schema on build
[ ] Documenting its use in the README/Wiki
[ ] Aligning versions with what's available in GAE

Additional known issue: need to start up datastore emulator

Remaining task status:
###Bootstrapping the database schema on build
Haven't found a way to do this beyond:
docker exec -it healthpro-web docker/database.sh

Documenting its use in the README/Wiki
Should we plan to update the Developer Onboarding document instead? New doc?
Aligning versions with what's available in GAE
Some of the lower-level stuff may not be locked at a particular version. We're already matching PHP and MySQL.


parquet-cli dictionary command fails on pages without dictionary encoding

parquet-cli's dictionary command fails with an NPE if a page does not have dictionary encoding:

$ parquet dictionary --column col a-b-c.snappy.parquet
Unknown error
java.lang.NullPointerException: Cannot invoke "org.apache.parquet.column.page.DictionaryPage.getEncoding()" because "page" is null
	at org.apache.parquet.cli.commands.ShowDictionaryCommand.run(ShowDictionaryCommand.java:78)
	at org.apache.parquet.cli.Main.run(Main.java:155)
	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
	at org.apache.parquet.cli.Main.main(Main.java:185)

$ parquet meta a-b-c.snappy.parquet
...
Row group 0:  count: 1  46.00 B records  start: 4  total: 46 B
--------------------------------------------------------------------------------
     type      encodings count     avg size   nulls   min / max
col  BINARY    S   _     1         46.00 B    0       "a" / "a"

Row group 1:  count: 200  0.34 B records  start: 50  total: 69 B
--------------------------------------------------------------------------------
     type      encodings count     avg size   nulls   min / max
col  BINARY    S _ R     200       0.34 B     0       "b" / "c"

(Note the missing R / dictionary encoding on that first page.)
Someone familiar with Parquet might guess from the NPE that there's no dictionary encoding. But for files that mix pages with and without dictionary encoding (like above), the command will fail before getting to pages that actually have dictionaries.
The problem is that this line assumes readDictionaryPage always returns a page and doesn't handle when it does not, i.e. when it returns null.
Reporter: Willi Raschkowski
Related issues:

Release 1.12.3 (is depended upon by)

Note: This issue was originally created as PARQUET-2120. Please see the migration documentation for further details.

Gidon Gershinsky / @ggershinsky:
@shangxinli and the Parquet community, can you assign this Jira to [~rshkv]


Crashed when trying to upgade

Steps to Reproduce
Please tell us what you were doing and what went wrong. If you are running flutter tools from the command line, please try adding the -v or --verbose option to gather more information.
If the problem is with your application's rendering, please attach a screenshot and any relevant source code.
If you are getting an exception in the logs, and your code is implicated in the first few frames, then please include the source code for the functions involved.
Logs
Run your application with flutter run and attach all the log output.
Run flutter analyze and attach any output of that command also.
Flutter Doctor
Paste the output of running flutter doctor -v here.

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

@kentonraiford can you attach the logs in verbose mode including the command you ran?

Hi Todd,
I deleted it and re-downloaded. It worked again.
Kenton
This electronic message has been marked confidential. Electronic communication is very serious, all emails and the messages contained within are legal documents. In forwarding or sharing the message without permission from the sender, the recipient acknowledges that the sender reserves their right to legal action.
CONFIDENTIALITY NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and/or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. The contents of this email, and any attachments are the intellectual property of Kenton. D. Raiford. Any release, or distribution without prior consent from Kenton D. Raiford is an act of copyright infringement.

On Apr 12, 2018, at 20:39, Todd Volkert<EMAIL_ADDRESS>wrote:
@kentonraiford can you attach the logs in verbose mode including the command you ran?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sounds good.  I'm gonna close this issue then.  If you encounter any more issues, please feel free to file again.


Add SUPEE-10752 for Magento1

See https://magento.com/security/patches/supee-10752

I do want to note that magento1 isn't officially supported with composer, so this is only useful as a reference, not for actually blocking something (or checking your composer.lock file for that matter)


feat: allow to set deviceCategory exposed in homekit while proxying

Hello,
I have open this FR https://github.com/AlexxIT/go2rtc/issues/982 and trying to add it now.
I don't really know what change are need, but as i understand, this PR can be the beginning of the feature.
Waiting for your feedback @AlexxIT
Thanks.

Are you sure this is enough? HomeKit has a rules for devices. Doorbell should have a button, maybe something else.

I’m not sure and i don’t know how to test my code change.
I would expect that proxying expose all original devices and not only camera.
Maybe it’s possible to do that in go2rtc for every homekit devices ?

Oh. This make sense for proxy mode.

It seems the current CategoryCamera does not proxy only the camera.
I have a "Somfy Indoor Camera" and the 4th entity are available (and working) in both Homekit and HA.

Stream
Identify
Mute Camera
Motion Sensor

So I would say it will also work for DoorBell or Bridge Category.

Your code will not compile anyway.


Fix error in CI for address-sanitizer

This fixes an error in the CI pass introduced by #4, which forgot to check out the repository

Seems you have fixed this in master

@mulimoen I'm sorry to have wasted your efforts by working on it. But I appreciate your PRs very much.
I have also done experiments to see what the results would be when I reverted the code before fixing #3.

@noritada More like I should apologise for introducing faulty code


Possible to add first nested resource only after user clicked Add?

Sorry I am not sure this should be in the Issues, but there is no Discussions available.
With current example from the documentation, a new nested resource will always be created when the user first visits the page.
  <template data-nested-form-target="template">
    <%= f.fields_for :todos, Todo.new, child_index: 'NEW_RECORD' do |todo_fields| %>
      <%= render "todo_form", f: todo_fields %>
    <% end %>
  </template>

  <%= f.fields_for :todos do |todo_fields| %>
    <%= render "todo_form", f: todo_fields %>
  <% end %>

An empty Todo item will always be created and displayed on the page this way. But what if I needed to create a new Todo item only after the user clicked the Add button?

I found the issue. I was using resource.nested_resources.build on the template, which will build a new nested resource.
I just need to use NestedResource.new instead of build to prevent creating a resource for the template.
That is, change
<%= f.fields_for :todos, todo_list.todo.build, child_index: 'NEW_RECORD' do |todo_fields| %>

to
<%= f.fields_for :todos, Todo.new(todo_list: todo_list), child_index: 'NEW_RECORD' do |todo_fields| %>

where todo_list is the parent resource.
Hope this helps someone.


Breaking changes: rename Error(s)

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 85.18%.

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   72.03%   72.03%
=======================================
  Files          40       40
  Lines        2750     2750
=======================================
  Hits         1981     1981
  Misses        624      624
  Partials      145      145

Impacted Files
Coverage Δ

vm/vmExprFunction.go
71.02% <100%> (ø)
:arrow_up:

vm/vm.go
81.52% <100%> (ø)
:arrow_up:

vm/vmStmt.go
64.8% <84%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b5492...934a253. Read the comment docs.

This is great :)

I put a note at here for everyone who use anko in master branch. I will merge breaking changes into master branch often. So please use tagged branch if you want to use stable.


Create Python prototype for DSL parser

Develop test cases and a parser for the RecordFlux DSL. We start with a Python prototype using pyparsing.

The parses reads the current definition of the DSL.


failed to create a spiderpool in kind cluster

usage issue
1.Use kind to start a cluster with the following configuration
kind: Cluster
apiVersion: "kind.x-k8s.io/v1alpha4"
networking:
  podSubnet: "<IP_ADDRESS>/16"
nodes:
  - role: control-plane
  - role: worker
  - role: worker

2.Use the following command to install spiderpool
$ export IPV4_SUBNET_YOU_EXPECT="<IP_ADDRESS>/16"
$ export IPV4_IPRANGES_YOU_EXPECT="<IP_ADDRESS>-<IP_ADDRESS>"
$ helm install spiderpool spiderpool/spiderpool --namespace kube-system \
  --set spiderpoolController.tls.method=auto \
  --set feature.enableIPv4=true --set feature.enableIPv6=false \
  --set clusterDefaultPool.installIPv4IPPool=true  \
  --set clusterDefaultPool.ipv4Subnet=${IPV4_SUBNET_YOU_EXPECT} \
  --set clusterDefaultPool.ipv4IPRanges={${IPV4_IPRANGES_YOU_EXPECT}}

3.Modify CNI configurations
{
	"cniVersion": "0.3.1",
	"name": "kindnet",
	"plugins": [
	{
		"type": "ptp",
		"ipMasq": false,
                "ipam":{
                   "type":"spiderpool"
                },
		"mtu": 1500

	},
	{
		"type": "portmap",
		"capabilities": {
			"portMappings": true
		}
	}
	]
}

4.failed to create a spiderpool
➜  Downloads cat spiderpool.yaml
apiVersion: spiderpool.spidernet.io/v1
kind: SpiderIPPool
metadata:
  name: custom-ipv4-ippool
spec:
  ipVersion: 4
  subnet: "<IP_ADDRESS>/16"
  ips:
  - "<IP_ADDRESS>"
➜  Downloads kubectl create -f spiderpool.yaml
The SpiderIPPool "custom-ipv4-ippool" is invalid: spec.ips: Forbidden: overlap with IPPool default-v4-ippool in IP ranges [<IP_ADDRESS>], total IP addresses of an IPPool are jointly determined by 'spec.ips' and 'spec.excludeIPs'

Version
➜  Downloads kubectl -n kube-system get po spiderpool-controller-cddcbb78f-d8slg -o yaml | grep image:
    image: ghcr.io/spidernet-io/spiderpool/spiderpool-controller:v0.3.7
    image: ghcr.io/spidernet-io/spiderpool/spiderpool-controller:v0.3.7

I understand. There is no overlapping IP. Why did you report an error
	Describe("Test IPsIntersectionSet", func() {
		It("finds the intersection set of two groups of IPv4 addresses", func() {
			ips := spiderpoolip.IPsIntersectionSet(
				[]net.IP{
					net.IPv4(172, 18, 40, 1),
					net.IPv4(172, 18, 40, 2),
				},
				[]net.IP{
					net.IPv4(172, 18, 40, 2),
					net.IPv4(172, 18, 40, 3),
				},
				true,
			)
			Expect(ips).To(Equal([]net.IP{net.IPv4(172, 18, 40, 2)}))
		})

The document I use is
https://github.com/spidernet-io/spiderpool/blob/main/docs/usage/basic.md

In step 2, you installed the default pool
$ export IPV4_SUBNET_YOU_EXPECT="<IP_ADDRESS>/16"
$ export IPV4_IPRANGES_YOU_EXPECT="<IP_ADDRESS>-<IP_ADDRESS>"
$ helm install spiderpool spiderpool/spiderpool --namespace kube-system \
  --set spiderpoolController.tls.method=auto \
  --set feature.enableIPv4=true --set feature.enableIPv6=false \
  --set clusterDefaultPool.installIPv4IPPool=true  \
  --set clusterDefaultPool.ipv4Subnet=${IPV4_SUBNET_YOU_EXPECT} \
  --set clusterDefaultPool.ipv4IPRanges={${IPV4_IPRANGES_YOU_EXPECT}}

Please confirm whether there is overlap between the default-v4-ippool you installed and custom-v4-ippool.
** View the created IPPool **

kubectl get sp

@ty-dc
Thanks for the guidance, the problem has been solved。
However, if you follow the example, you will get an error. Can we change the ip range of the example

https://github.com/spidernet-io/spiderpool/blob/main/docs/usage/basic.md
The v4-default-pool range given in the sample document is:
IPV4_SUBNET_YOU_EXPECT="<IP_ADDRESS>/24"
IPV4_IPRANGES_YOU_EXPECT="<IP_ADDRESS>-<IP_ADDRESS>"

Create a custom IPPool. The YAML file looks like:
apiVersion: spiderpool.spidernet.io/v1
kind: SpiderIPPool
metadata:
  name: custom-ipv4-ippool
spec:
  ipVersion: 4
  subnet: <IP_ADDRESS>/24
  ips:
  - <IP_ADDRESS>-<IP_ADDRESS>

Therefore, if you operate according to the document, there should be no unexpected error.
They are not in the same subnet, and the IP range does not overlap

https://github.com/spidernet-io/spiderpool/blob/main/docs/usage/basic.md
The v4-default-pool range given in the sample document is:
IPV4_SUBNET_YOU_EXPECT="<IP_ADDRESS>/24"
IPV4_IPRANGES_YOU_EXPECT="<IP_ADDRESS>-<IP_ADDRESS>"

Create a custom IPPool. The YAML file looks like:
apiVersion: spiderpool.spidernet.io/v1
kind: SpiderIPPool
metadata:
  name: custom-ipv4-ippool
spec:
  ipVersion: 4
  subnet: <IP_ADDRESS>/24
  ips:
  - <IP_ADDRESS>-<IP_ADDRESS>

Therefore, if you operate according to the document, there should be no unexpected error. They are not in the same subnet, and the IP range does not overlap

@ty-dc Thanks, I got it


build is failing with multiple def error

multiple definition of `cfile'; $WORK/b001/_x002.o:/home/user/golibwireshark/./include/lib.h
:23: first defined here
same for pdh

hello any update on this?


[Doc] Mutex timeout units

yii\mutex\Mutex documentation does not say anything about $timeout units. Look's like it's a seconds, but it's not so obvious.
Additional info

Q
A

Yii version
2.0.13-dev

fixed, thanks for reporting!


feat(filter-by): add strict mode; fixes #163

looks great @toddbranch, thx!

would you mind to update the readme file too?

Yeah no problem, I will submit PR later today.


[AST Builder] Implement InSubquery and QueryNode

Resolve #719

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

44 of 44 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 97.885%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
29390

Relevant Lines:
30025

💛  - Coveralls


Improved test coverage for catalog state service

PV https://www.pivotaltracker.com/story/show/145300045

@miq-bot add_label fine/no
@miq-bot add_label test

just tests, no UX.

I don't want to be a stickler for detail, but this doesn't appear to improve the code coverage, cc rating remains the same?

Where are you looking @AllenBW ?  The cc stuff only changes on merges to master.  I am watching cc in the next few to see if it improves.

Yeah, that's what we were checking

Mmmmm but this.... https://codeclimate.com/github/ManageIQ/manageiq-ui-service/coverage/5914c3bdf773b200010856c3
Red lines are da stuff it doesn't hit... 🤔


Add logic for computing capital gains

The CapitalGainsCalculator contains a CostBasisCalculator, and uses it
to generate CapitalGainsRecords from a sequence of buys and sells.
It supports marking certain sells as tax exempt (e.g. gifts).
Test plan:
New tests for the behavior, especially the precise time boundary around
long-term/short-term gains. Observe that they pass, and that yarn flow
works.

Looks good to me. I note that this code introduces test cases that use non-integer floating point numbers for money, so when you update #1 to require only integer numbers you’ll easily be able to verify that these tests break, as intended. :-)

PTAL


z not correct for axis and series line

I want the line to be in front of the axis. Is this a bug, or intended?
var options = {
    xAxis: {
        z: 1 // <-- 1!
    },
    series: [
        {
            z: 2 // <-- 2! In front.
            type: 'line'
        }
    ]
}

Sorry for the doc is not clear enough. z & zlevel is available in the option right now, it only can be set by theme. We will think about whether is a common use as options.
Right now, you can use it like this:
       var myChart = ec.init(
            document.getElementById('main'),
            {
                line: {z: 5}          // as a theme params when init()
            }
        );

Thanks.

Thanks for the quick response! Closing this issue.


Add usage guide to README

We should have a small example of how to set up, run, and use the crate.

Fixed #6


Godot should automatically convert 2.x code to Godot 3.x

This option at least exists in 2.1.5.

However, it can only do so much.  Some things have gone away entirely so there is no direct one for one conversion,  There isn't anything yet that can perfectly intuit your intentions and faithfully recreate new code based on your old code in different environments.

better start now my friend lol

This is not possible, the API changed a lot which makes translating code from one version to the other very difficult. Thus it cannot be made automatically.

Yeah, its changing rapidly. In 4.0 API will not be fully compatible even with 3.0. Dont know which volunteer want to write and support this titanic work from scratch..

I think its pointless to wait for someone to implement such complex thing, otherwise its already been existed. Closed.

Thanks for the feedback.  I like Godot and just trying to help improve it.
My intent here is forward thinking.  I realize it is a complex ask.  I converted the code for 7 tutorials before giving up.  I was introducing a new concept, that we start move forward by having such technologies in current times.  I was hooping to hear a counter, perhaps something like... it's a complex ask to do entirely atm; however we can improve the docs, improve the intellisense and work on a simple conversion/migration program which does some of the work via suggestion or the like.
It's hard to find enough examples on YT for Godot 3.0 that can teach all of the techniques needed, especially for someone new to Godot.  I spent much time converting the code of a 2.x tutorial myself, the instructor is very good and I find no competing example as good for 3.0 on this particular topic.
However, by the time I reach many instanced scenes, it consumes too much time and there is just not enough information online to figure it out.
I was hoping someone would offer a solution or alternative solution.
Thanks,
I look forward to the Godot 3.1 release.

This option at least exists in 2.1.5.

However, it can only do so much. Some things have gone away entirely so there is no direct one for one conversion, As far as I understand it, there isn't anything yet that can perfectly intuit your intentions and faithfully recreate new code based on your old code in different environments.

I'll consider starting the tutorial over in 2.1.5 and see how well the conversion to 3.x goes.  Thanks

Yeah, its changing rapidly. In 4.0 API will not be fully compatible even with 3.0. Dont know which volunteer want to write and support this titanic work from scratch..

Think big not small my friend.

I think its pointless to wait for someone to implement such complex thing, otherwise its already been existed. Closed.

New ideas and inventions haven't been invented yet until we create them.

This is not possible, the API changed a lot which makes translating code from one version to the other very difficult. Thus it cannot be made automatically.

I figured it wouldn't hurt to ask.  A smaller subset would be a good start.

code has to be converted by person, should be automatic. Not enough documentation exists to self debug all the issues. Time constraint.

better start now my friend lol

I don't have a specific project, however I would like to learn at a steady pace.  What I should have said, the conversion of code was dragging the pace down.  I started over in 2.1.5.

This option at least exists in 2.1.5.

However, it can only do so much. Some things have gone away entirely so there is no direct one for one conversion, As far as I understand it, there isn't anything yet that can perfectly intuit your intentions and faithfully recreate new code based on your old code in different environments.

I redid the tutorial up to the same point, Exported to 3.0 (WIP) with notes.  Unfortunately, I haven't found any changes yet, so I did the typical manual conversions. get_mouse_pos = get_mouse_position, Width = x, Height = y
Can you direct me to find the resource / documentation for converting the rest of 2.x to 3.x code?  ie. 	2.x = yield(get_node("anim"), "finished") 3.x = ?
I could use the help in finding the resources, right now I'm using internet search which are sparse and intellisense.
I appreciate any direction.

I think its pointless to wait for someone to implement such complex thing, otherwise its already been existed. Closed.

FYI, the export feature in 2.1.5 shows you are working on it, right?

FYI, the export feature in 2.1.5 shows you are working on it, right?

It is only a project conversion to allow you to open old scenes in the new version (while translating as much as possible). But there's no code conversion which was the original request in this thread. Converting code is very hard.
It's also pointless because when time passes there's less people using the 2.1.x series, so the number of users of that tool will only diminish. People with deep projects in 2.1.x probably won't take the effort to make the migration with the risk of facing new bugs and undoing the workarounds for bugs that were fixed.
So the problem is not only the amount of work, but also that it brings almost no gain.

For more specific guidance and help with the translation, consult some of our community channels. Unfortunately there's not much documentation about the changes.

FYI, the export feature in 2.1.5 shows you are working on it, right?

It is only a project conversion to allow you to open old scenes in the new version (while translating as much as possible). But there's no code conversion which was the original request in this thread. Converting code is very hard.
It's also pointless because when time passes there's less people using the 2.1.x series, so the number of users of that tool will only diminish. People with deep projects in 2.1.x probably won't take the effort to make the migration with the risk of facing new bugs and undoing the workarounds for bugs that were fixed.
So the problem is not only the amount of work, but also that it brings almost no gain.
For more specific guidance and help with the translation, consult some of our community channels. Unfortunately there's not much documentation about the changes.

Thanks for the feedback, makes sense.  Being new to coding and Godot, I am realizing some code conversion can be as simple as a search / replace, other code can be more tricky than that.  I redid the tutorial in 2.x and works fine.  I'm doing the code conversion now as more of an exercise to challenge myself in learning the code.  Maybe a bit silly since 2.x it's out of date, but it's more about using the debugger and resources at hand to find solutions to problems in front of me.
Thanks for bringing the community a great product for free.


Legacy builds

This PR use a monkey patched version of @vitejs/plugin-legacy.
Here is a forked hn.svelte.dev with legacy builds.
It works, but I don't know why the order of nodes are wrong.

*Some tests*

TODO:

[x] test in IE 11.
[ ] test in Safari 10.1.
[ ] resolve wrong order of DOM nodes.

there are issues covering legacy builds already #12 and #2745
Your PR adds an experimental monkey-patched version of vite-plugin-legacy as a dependency, which is not likely to get merged.
I suggest you mark it as a draft and join us on discord to discuss how legacy support can be achieved as an optional addon instead of a hard dependency.

I'd agree with Dominik that the best course of action would be to get any necessary improvements into vite-plugin-legacy as a first course of action

Ok, I will make a PR to vite-plugin-legacy to try to make it works with kit.

I'm going to close this for the time being to keep the review queue clean. We can reopen after vite-plugin-legacy has been updated


Review points

Do you have links to the underlying documentation for the Code?

The code for rainbow has been documented using API method/function documentation in Google Python Style. For example:
https://github.com/AlphonsG/Rainbow-Optical-Flow-For-ALI/blob/9af871407bb3fd6b0bf3f1f4f77cb348de509487/rainbow/file_processing.py#L93-L107

Alright thanks.


docs: replace Narrow no-break space with No-Break Space

@mgreenegit
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


dev<EMAIL_ADDRESS>from the root project

Reproduction
npm error
Steps to reproduce the bug

package.json

"devDependencies": {
   "typescript": "^5.0.0-dev.20230214",
}

npm install pinia get a npm error like this:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/typescript
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/pinia
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Expected behavior
no error
Actual behavior
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/typescript
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/pinia
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Additional information
No response

Duplicate of https://github.com/vuejs/pinia/issues/1969

Please, search existing issues and pull requests before opening issues, it saves maintainers a lot of time 🙏


Upgrade Mapbox to 2.8.0

Mapbox 2.8.0 is almost ready (currently it's in RC phase) so when it will become stable we should upgrade it.
┆Issue is synchronized with this Jira Uncategorised by Unito

Done in a91ec8bd31635a9192b14670b0f88de620ff4456


Suggestion: perhaps add an extra step to the isolation guide

I told a friend about how the component isolation problem in Cycle was now solved, and the immediate reaction was "awww man, so I have to manually call isolate every time I want to instantiate a component?!".
If a component should be isolated in various scenarios, it probably always needs to be isolated. Even if it is only used once, it can probably still be isolated without causing any issues.
Therefore, I'd suggest mentioning that, in developing a component, you could optionally take the burden away from the consumer like so:
function RawComponent(sources) {
    // ...
}

export function Component(sources) {
    return isolate(RawComponent)(sources);
}

// optional for flexibility and convenience:
Component.Unwrapped = RawComponent;

Doing this gives the consumer automatic isolation without having to think about it. I understand that some people might want the flexibility or freedom to choose how to isolate, but I'd guess that this is probably going to be an application-wide decision, rather than per-component. It might give newcomers an extra boost of confidence if they realise that exposing their application's components in a pre-isolated fashion is possible, and thus will make the rest of their code leaner.

+1

:+1:

I thought that was self evident, but I'll add it. Thanks for suggesting.

Done

Nice work! :)

Given that pretty much every component that's going to be repeated in the DOM (even in a simple loop), or otherwise uses DOM as a state mechanism will need to be isolated otherwise it breaks, it seems like redundant boilerplate for the component author.

@MadaraUchiha Two issues;
(1) Cycle is functional in nature; instantiating a component means making a function call. How do you propose that Cycle intercepts arbitrary function calls in JavaScript?
(2) Not all components are UI components. State management, business logic, etc. These don't necessarily qualify for isolation.


record are not filled

Hi, at first "woawww" nice :)
I used to create graphs with Mrecord and record shapes... but fillcolor isn't taken. Is there a way to get it work ?
Regards

Seems to be my dot version... no shape is filled :(

Which version of dot / graphviz are you using?
I haven't really tested with record shapes so they might be problematic regardless, but if you have a (small) sample I'd be happy to take a look.

my bad, I need to set node stule to "filled" to be colored :)
by the way, I'm very impressed by your work and I use parts of your code to make my own xsl that uses "filters"... I will fork your git to show you my test.
Thanks a lot !

https://github.com/metal3d/diagram-tools/blob/master/filter-shadow.xsl => my XSL


Update model with html, ajax and js implementation

Currently the model has the code which requests the service to display the page views. This needs to be updated with the service which displays the usage.

The service was implemented to display the usage with some dummy value (because usage script is not yet ready) and tested on http://stats-demo.vlabs.ac.in/test-stats/ (test environment). It also need to test on http://stats-demo.vlabs.ac.in/stats/ (production). But, It was dependent on issue #8.


Can now be done in Azure Portal

When working through this documentation it was found that OpenVPN can be selected as one of the Point-to-Site options in the Azure Portal configuration.  Can these steps be added to this doc?
Best,
Steve Doroff
Azure Networking Support

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf66871e-f045-8ecb-6aff-dd36e20f1601
Version Independent ID: 19b1740f-ba43-92a3-74e7-28fb6c462f2b
Content: How to configure OpenVPN on Azure VPN Gateway: PowerShell
Content Source: articles/vpn-gateway/vpn-gateway-howto-openvpn.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Hello @sbdoroff
thanks for your feedback, I have assigned this to the content author to evaluate your request
Best


add bindings for critical section API

refs #4265, specifically https://github.com/PyO3/pyo3/issues/4265#issuecomment-2293897660, ultimately we want to use this in GILProtected and GILOnceCell.
#4439 is an alternate approach that also uses this API for dict iteration (following the suggestion in the docs for PyDict_Next). I'm holding off on using this API in that spot because of the discussion in that PR.
That PR doesn't use opaque_struct on the GIL-enabled build, but I think that's actually the correct thing to do, since it's an opaque struct in the regular ABI:
https://github.com/python/cpython/blob/556e8556849cb9df0666629b0f564b5dd203344c/Include/cpython/critical_section.h#L70-L71
I'm not exposing the begin/end critical section macros because they include braces and are not expressible in rust.

I'm not exposing the begin/end critical section macros because they include braces and are not expressible in rust.

I kind of like the idea of an inline function that will initialise the 'CriticalSection' object for you before calling 'PyCriticalSection_Begin'.


Improve read me

Can I add how to contribute in readme section?

Add content in this file
https://github.com/arpit456jain/CodingEasy/blob/master/README.md

@arpit456jain I can only add how to contribute is it ohk?
Can I work now then assign me!

Yes

@arpit456jain done
Please add SWOC tag.

@ssurbhi09

@arpit456jain yes?

@arpit456jain u didn't merge why?
Any problem?

its  a issue @ssurbhi09 not a PR 😅 and that section how to contribute is already added


Add Map operations.

I’ll leave this PR for later because it has several compilation errors with dotty.

@Dveim - The reason is to allow the strawman to function as a drop-in replacement for the existing collections.  This has been a primary goal all along.  Since the behavior changes radically when it is lazy vs. eager, simply swapping one for another isn't something you can do blind, even if it compiles.  A lazy mapValues could be used to access a single element, making the eager version a million times slower.  Alternatively, the lazy version could load a file every time on something that's accessed many times, making the lazy version ten thousand times slower.  These kinds of speed differences are not just a performance detail, but the difference between working and effectively broken programs.  So I don't think we can change the behavior without changing the method name so people at least have a chance to think about what's going on.

Thanks for answer. Indeed, compatibility alone is enough to leave things as
is.
Do you plan to add strict version, mapValuesNow ?

see also https://issues.scala-lang.org/browse/SI-4776

I rebased to master and bumped the dotty version to take advantage of https://github.com/lampepfl/dotty/pull/2889 but we now have other compilation errors:
[error] -- [E045] Syntax Error: /home/julien/workspace/dev/scala/collection-strawman/src/test/scala/strawman/collection/test/GenericTest.scala:54:38
[error] 54 |    Parse.parseCollection[(Int, Int), immutable.HashMap[Int, Int]](immutable.HashMap).parse("1-2|3-4").contains(immutable.HashMap((1, 2), (3, 4)))
[error]    |                                      ^^^^^^^^^
[error]    |                                      cyclic reference involving type CC
[error] -- [E008] Member Not Found Error: /home/julien/workspace/dev/scala/collection-strawman/src/test/scala/strawman/collection/test/Test.scala:498:47
[error] 498 |    val xs7 = (xs: immutable.Map[String, Int]) map ({ case (k, v) => (new Foo, v) }: scala.PartialFunction[(String, Int), (Foo, Int)])
[error]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]     |value `map` is not a member of strawman.collection.immutable.Map[java.lang.String, scala.Int]

Dotty fix in progress: https://github.com/lampepfl/dotty/pull/2914 :smile:


Improve perf of notebook search

This issue is here to track cleanup of closed notebook search (#173726).
Notably, this includes:

Trying to reduce the communication between ext host and renderer processes to improve perf in remote.
Other small optimizations (ie: file matching improvements)

https://github.com/microsoft/vscode/pull/174287#discussion_r1255033860
https://github.com/microsoft/vscode/pull/174287#discussion_r1245614980

Note: we should be aware of how many calls to the ext host we make; with the current implementation, we make one call per notebook, but this can be quite bad in remote scenarios.
https://github.com/microsoft/vscode/blob/26f41a49948c6da4eec5c93836c1c331364b54f2/src/vs/workbench/contrib/search/browser/notebookSearchService.ts#L84

Ideally, there would be another ext host function adjacent to this one that takes a mapping of URI to VSBuffer and multiple buffers can be handled at once.
https://github.com/microsoft/vscode/blob/26f41a49948c6da4eec5c93836c1c331364b54f2/src/vs/workbench/api/common/extHostNotebook.ts#L292-L299
This would require changing ExtHostNotebookShape.
https://github.com/microsoft/vscode/blob/7a932b9c784e0291f736e023f16d12ab5398b674/src/vs/workbench/api/common/extHost.protocol.ts#L2315-L2322

Fixed by https://github.com/microsoft/vscode/pull/192358


BanditPAM 200x slower than quadratic algorithms at 10k MNIST

I've been comparing BanditPAM to FasterPAM on the first 10k instances of MNIST:
https://colab.research.google.com/drive/1-8fMll3QpsdNV5widn-PrPHa5SGXdAIW?usp=sharing
BanditPAM took 791684.18ms
FasterPAM took   3971.87ms, of which 90% are the time needed to compute the pairwise distance matrix
That is 200x slower. I will now try 20k instances.

First numbers for 20k of MNIST (one run each only, on colab):
BanditPAM: 4390447.39ms
FasterPAM: 16993.11ms
258x slower, so the gap has widened despite the latter being O(n²). But there is variance here, it may be similar.

Thanks for the report @kno10  --- I've requested access to the colab notebooks from 2 of my personal email addresses, would you mind granting access so I can investigate?

Sorry, I didn't click the right colab buttons, the link was meant to be public. It should work now.

Hi @kno10, thank you for filing this issue and providing an easily reproducible benchmark. It led us to discovering a number of issues that are being worked on:

** Distance Matrix:** In your benchmark script, the whole distance matrix is passed to FasterPAM. However, it's still not apples-to-apples with BanditPAM because computing the distance matrix up front is much faster (due to vectorization) than on-the-fly as is done in BanditPAM. To fix this point of comparison, I've allowed for a distance matrix to be passed to BanditPAM explicitly in the slowdown branch.

Multithreading: I think you may have misunderstood my comment here; my apologies for being unclear. Even when multithreaded, BanditPAM almost always returns the same output, even though it is a random algorithm. The call to banditpam.set_num_threads(1) is only necessary for instruction-level determinism, which is a stronger condition than necessary. For apples-to-apples comparison with FasterPAM, we need to multithread BanditPAM as well (I don't know Rust, but I believe the Rust implementation of FasterPAM is multithreaded? ). [Aside: due to incompatibility with M1 Macs, I've removed the .set_num_threads  functionality altogether; see v3.0.4)

Max Iterations: BanditPAM had a much higher default value for the maximum number of iterations than FasterPAM (1000 vs. 100); this led to many more swap steps being executed. So BanditPAM was finding a very slightly better solution but executing for much longer. I've updated this to 100 in the slowdown branch as well.

Swap Complexity: Most interestingly, the dependency on k of the SWAP step in BanditPAM is still O(k). I'm accelerating this to O(1) using the FastPAM1 trick in the slowdown branch, which was nontrivial to implement in our framework. This is was the root cause of #179.

The first three points above are all addressed in the branch slowdown. The fourth one is implemented as well, but for some reason is not working properly and often returns bad results. I'm going to continue working on this but need to put this on hold for some time due to my other commitments.
Thank you for providing all of these bugs in easily-reproducible ways. Please let me know if you have any other questions or comments while I continue to work on this.

Distance matrix: Indeed, the distance computations are the main cost, but that is also the baseline any non-quadratic method will need to beat. But even pairwise distance computations can be vectorized (e.g., with AVX - mnist should benefit from this) so I would not expect the benefits to be that huge to really have the matrix, unless you recompute the values very often. In my opinion, the benefits of vectorization at this level are often overestimated (because people tend to look at interpreted code, and "vectorized" then also means calling a compiled library function as opposed to using the Python interpreter, no matter whether the actual underlying code is vectorized or not).
Multithreading: The colab sheet uses n_cpu=1 for FasterPAM, i.e., no parallelism. The wrapper then calls a non-multithreaded implementation; the parallelized version came much later and is not as parallelism-efficient as we would like. I set both to use a single thread for a more fair comparison.
Max Iterations: It converges long before the maximum iteration counter - usually <10 will be enough. I added an "iter" counter to the colab sheet, and it was just 3 iterations on average. I also set it to max_iter=1000 but it will not make a difference. How much quality do you lose in BanditPAM when reducing the iteration limit?
Swap Complexity: Don't use the FastPAM1 version of the trick anymore, the FasterPAM version is both theoretically better (guaranteed, not just expected gains - FasterPAM1 still has a theoretical worst case of O(k)), better understood, and more elegant.


Replace fzf with skim

Replace fzf external tool usage with skim: https://github.com/lotabout/skim
This has the advantages:

The user won't have to add any third party tools to get fuzzy matching
We can control how the display looks instead of showing direct output of other commands

Didn't realise you had self-assigned this, but just raised a PR  #18  which seems to work for replacing with skim (docs are somewhat lacking on skim as a lib).

No problems, gratefully received!


Update Blazor Get Started CLI steps for Blazor 0.9.0

Followed the getting started guide from a fresh computer with .NET preview 3 using this change, and the starter projects compiles and runs perfectly 👍 💯


Example of a self referential relationship

Hi,
I was wondering what would be the best way to define a self referential relationship neoid, for example:
class User
  has_many :follows
  has_many :followed_users, through: :follows
end

class Follow < ActiveRecord::Base
  belongs_to :user
  belongs_to :followed_user, :class_name => 'User'
end

I'm putting this down to 2:50am coding, because:
  neoidable start_node: :user, end_node: :followed_user, type: :follows

Works just fine. Not sure what I was seeing before (probably put user,user).

Glad you found it working. Keep up the feedbacks.


fix bug with placeholder editing in IE

Reproduced https://jsfiddle.net/gxo4nydd/4/ on IE 10,11 on Windows 7
Just click on input several times rapidly until you see cursor and placeholder at the same time. Now you can edit the placeholder. Input value stays empty.
PS What use of blurring :inputs?

I guess this is more IE issue rather than Swiper's. This blur is required for mobile/touch devices to actually blur inputs when you click outside of it. With your fix, can you still blur input after focusing it if you click on other place of slide?

Ok, is the goal to avoid keeping focus on a non-active slide?
Blurring input on touchend / touchcancel will be much safer then.

The goal is to blur input when you click outside of input. By default it won't blur because of e.preventDefault in onTouchStart, maybe touchend/cancel can be better, will check it

Closing as outdated and incompatible with current version of Swiper


Switch to Google Cloud Platform

We have been provided credit to run our system on GCP so we should switch our system from Heroku to Google Cloud Platform.
We will use the Docker setup running on App Engine Flexible from CS Unplugged and CS Field Guide.

Fixed in 4aa5494673c423ae46eb2814ade4bb0762bb96c3


assertion failure in transaction manager

happens sometime around https://github.com/MystenLabs/sui/tree/6fa859ba7590deb6db72aad42ca689efd69d5329
2023-02-01T18:14:37.781102Z ERROR telemetry_subscribers: panicked at 'assertion failed: inner.executing_certificates.insert(digest)', crates/sui-core/src/transaction_manager.rs:190:17 panic.file="crates/sui-core/src/transaction_manager.rs" panic.line=190 panic.column=17
thread 'tokio-runtime-worker' panicked at 'assertion failed: inner.executing_certificates.insert(digest)', crates/sui-core/src/transaction_manager.rs:190:17
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: sui_core::transaction_manager::TransactionManager::enqueue
   4: <sui_core::consensus_handler::ConsensusHandler<T> as narwhal_executor::ExecutionState>::handle_consensus_output::{{closure}}::{{closure}}
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   7: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   8: tokio::runtime::task::core::Core<T,S>::poll
   9: tokio::runtime::task::harness::Harness<T,S>::poll
  10: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
  11: tokio::runtime::scheduler::multi_thread::worker::Context::run
  12: tokio::runtime::scheduler::multi_thread::worker::run
  13: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
  14: tokio::runtime::task::core::Core<T,S>::poll
  15: tokio::runtime::task::harness::Harness<T,S>::poll
  16: tokio::runtime::blocking::pool::Inner::run

Pushed f23377f17f48455c85ea8128f60b9ceaf7b3d4a4 to testnet branch.


bert_position_ner_hotpot_train_v1.1.json not found

Hi,
I read your paper and has tried to train your model.
But, I got a problem with bert_position_ner_hotpot_train_v1.1.json file.
I run the main.py with HotpotQA train set and dev set.
In arguments, train_ner_file, I replaced "bert_position_ner_hotpot_train_v1.1.json" string with "train_gold_ner.json" string
Though I could get gold_doc and gold_ner .json file respectively,
run_hotpotqa.py returned error when I trained model with train_gold_ner.json

At 286 line, list index out of range  occur ("ni" variable)
Is there something I have to do?
What is  bert_position_ner_hotpot_train_v1.1.json ?

Hi,
I read your paper and has tried to train your model.
But, I got a problem with bert_position_ner_hotpot_train_v1.1.json file.
I run the main.py with HotpotQA train set and dev set.
In arguments, train_ner_file, I replaced "bert_position_ner_hotpot_train_v1.1.json" string with "train_gold_ner.json" string
Though I could get gold_doc and gold_ner .json file respectively,
run_hotpotqa.py returned error when I trained model with train_gold_ner.json

At 286 line, list index out of range occur ("ni" variable)
Is there something I have to do?
What is bert_position_ner_hotpot_train_v1.1.json ?

could you have this question:python: can't open file 'main.py': [Errno 2] No such file or directory?


Users/hiyada/azure cli

@bryanmacfarlane
made a change to toolrunner.ts in L0 test lib, to accommodate tool.line function. else test fails if we use tool.line in the task.
Kindly review

Hi @hiyadav, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Himanshu Yadav). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Where to get LSUN dataset

Hi, I'm new to computer vision and is trying to get up to speed with everything. When I run the
python main.py --dataset lsun --dataroot [dataroot] --cuda
command there is an error saying lmdb.Error: [dataroot]/bedroom_train_lmdb: no such file or directory. It looks like that I need to download the dataset myself. Can you provide a pointer to which I can get the dataset? Thank you very much!

http://lsun.cs.princeton.edu/2016/


Fix PPSSPP with wrapQtApps #65399

Motivation for this change
PPSSPP was not starting (qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" error).
Things done
Use mkDerivation from arguments instead of stdenv.mkDerivation

Merged to master in 0ac7bb63284cd35e1983f235da269d4ea474849a.
Backport to 19.09 in 16defc9dd7d32141e734e75a1ffddb4c505c071b.
I just had to edit the commit message, in the future, if you could have them match

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

that would be great.
(allow edits from maintainers is pretty useful also)
Also, see the following for more information on submitting patches if you do in the future

https://nixos.org/nixpkgs/manual/#chap-submitting-changes

Thanks for the fix :sparkles:


.Net required even though i installed it using the popup link

I am trying to this software and it keeps giving me the same error.

I have already installed this version of .NET

Hi, I've got the same problem, did you solve it?

No, but i used previous version and it seemed to work.

Hi, I've got the same problem, did you solve it?

i just tried the latest release and it seems to work without any issues. maybe try the newest release!

Now it works, thanks for your help :D


Can you please add generic mode like 'on'

I am implementing the code to operate my water heater device from google smart home for that I am using "action.devices.traits.TemperatureSetting" trait.
My water heater has many modes which are not currently supported by this trait so while QUERY(what is water heater set to) it respond "water heater is off and it's currently N degrees". I found when it detects non-supported mode it considers as off mode
Can you please add some generic mode like 'on' so I can respond better response like "water heater is on and it's currently N degrees"
I tried 'on' mode and set thermostatMode: 'on' but it didn't help and gave above off mode response.

You could set the mode to heat, as that would also make sense. But you may also want to consider the similar TemperatureControl trait.


[Python] Flush prompt before reading input

Make sure the prompt has been flushed before reading commands. Buffering
is different in Python 3, which led to the prompt not being displayed in
the Xcode console.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@364335 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 1ef7d01da26909e017be2a6250aca6d26ef7b82d)

@swift-ci please test and merge

rdar://problem/52008158


[SPARK-8316] Upgrade to Maven 3.3.3

Versions of Maven older than 3.3.0 apparently have a bug in how they handle transitive dependencies.
I confirmed that upgrading to Maven 3.3.3 resolves at least the particular manifestation of this bug that I ran into.

Merged build triggered.

Merged build started.

cc @srowen

Test build #34732 has started for   PR 6770 at commit 6bed2d9.

Test build #34732 has finished for   PR 6770 at commit 6bed2d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

I believe we'd also need to require Maven 3.3 in the build, and in enforcer plugin? to actually fail if used with a local version that's not high enough?
3.3 is fairly new and most dev environments won't have it. I suppose that's why build/mvn exists too. It may still cause some surprise since most mvn ... would fail then.
Not enforcing this risks people hitting the issue that prompted this, I suppose, without knowing. then again, otherwise, earlier versions of Maven appear fine.
Hm. What do you guys think about the tradeoffs?

@pwendell may have some thoughts on this.
As I noted in a line comment, we can always install and use our own version of Maven, ignoring any existing installs on the user's machine.
That should, I believe, guarantee that we're always using the version of Maven that we want.

Has this issue ever affected anyone before now? If it's a relatively obscure issue I think failing builds with Maven < 3.3 might be a big inconvenience for developers.

Heh, well we have this problem right now: https://github.com/apache/spark/pull/6492
The reason it's popped up is that Hadoop 1 is now controlled by a profile, and profile handling behavior is at issue here.
Of course if we didn't support Hadoop 1, this would go away. (See what I did there?)
Nah, it's really nothing to do with Hadoop 1 per se, but profile handling, but I do wonder if this would eventually bite again anyway for a different profile.
I think the only reasonable way forward on this one right now is to, yes, download and use the latest Maven when that is requested, but not actually fail the build if 3.3 isn't used. This does mean that someone with 3.2 on their machine can run into https://github.com/apache/spark/pull/6492, but hey, that only affects people building for Hadoop 1. Maybe close enough for now.

We could also set a warning to print if a user already has mvn installed, but version < 3.3. That seems the least intrusive to the dev community without mandating they install the latest version. Just my 2c.

Is it an inconvenience if we just always download and use Maven, instead of checking for a local install first? We already do that for Zinc and Scala, so I don't see that we need to ever fail the build for using an out of date version of Maven.
As long as we always download our own version of Maven, then the only time a developer might still use an out-of-date version is if they already downloaded one using build/mvn before we make this update. Not a big deal as they can just delete the one downloaded to build/ and rerun build/mvn.

If it's a relatively obscure issue

I dunno if it counts as obscure, but the issue described here means at the very least that we will generate broken Spark builds for Hadoop 1 when using versions of Maven older than 3.3.

Other discussion aside, I think this is OK to merge, since it merely updates the version of Maven that is downloaded to a new version, which should be a generally good thing.


Shorten the running version on application list page

What would you like to be added:
In case an SHA value is being used, just show the first 7 characters and suffix with ....
For example, abcdefg...

Why is this needed:
In order to keep the page layout.

I think this issue has been already resolved.
🔗  https://github.com/pipe-cd/pipecd/pull/3308
🔗  https://github.com/pipe-cd/pipecd/pull/3567/files#diff-561b45876d43b4ef62f2607495d990b27a408098d8dfbce07b28850cd79b3598R178-R182

Right, Let's close this issue🙌
/close


[Task] Show private entity settings excluding on page load for modules

Show all settings for private actions and js collection
Exclude the on page load setting and confirm before execute

This is completed


PushNotificationIOS.removeEventListener method signature requires unused handler Function

https://github.com/facebook/react-native/blob/726d0012106316a40e36286f5eba0e881ef3bbba/Libraries/PushNotificationIOS/PushNotificationIOS.js#L236
This throws unhelpful flow errors. If this is an error, I can provide a PR removing this line.

@schumannd it seems unused, you could try removing it.

I think we should actually fix the code to handle multiple listeners. Right now, if you call addEventListener two times, the latter one will silently overwrite the former one.
I believe this is kind of behaviour you wouldn't expect.
If the API is designed to only handle single handler, it should be setEventListener.

This issue has been moved to react-native-community/react-native-push-notification-ios#10.


[ZEPPELIN-212] Multiple paragraph results

What is this PR for?
Currently a paragraph can display only a single type of result.
For example
print("""
%text textout
%html htmlout
""")

will display only last display system detected, "htmlout".
This pr implements multiple results supports, so not only the last, but also all the display systems in a paragraph outputs can be displayed.
To do that, Note.json format need to be changed. from
   paragraph : [
      {
          result : {
              code: "",
              type: "",
              msg: ""
          },
          config : {
             graph : {},
             ...
          },
          ...
      },
      ...
   ],
   ...

to
   paragraph : [
      {
          results : {
             {
                code: "",
                msg: [
                   {
                        type: "",
                        data: ""
                    },
                    {
                        type: "",
                        data: ""
                     },
                     ...
                ]
          },
          config : {
             results : [
                {
                    graph : {},
                },
                {
                    graph : {},
                },
                ...
             ]
          },
          ...
      },
      ...
   ],
   ...

What type of PR is it?
Improvement
Todos

[x] - Make InterpreterResult and InterpreterOutput support multiple display system
[x] - Automatic migration old format to new format
[x] - Render multiple results in front-end
[x] - Take care Importing old notebook format
[x] - Make helium framework support multiple results

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-212
How should this be tested?
run following code in a single spark paragraph.
%spark
// default output is text
(1 to 3).foreach{i=>
  println(new java.util.Date())
  Thread.sleep(1000)
}

// print something in html
println(s"""%html
Some HTML
""")

// create table
println(s"""%table key\tvalue
sun\t100
moon\t200

""")

// display text again
println("""%text""")
(1 to 3).foreach{i=>
  println(new java.util.Date())
  Thread.sleep(1000)
}

// another table
Thread.sleep(1000)
println(s"""%table key\tvalue
apple\t100
banana\t200
""")

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? yes
Does this needs documentation? yes

I think this PR is ready to be reviewed.
While this PR includes quite a lot of changes i'm highlighting some key changes.

Display multiple types of output in a single paragraph.
Previously, if output includes multiple display system directive (e.g. %html, %text, etc) only the last one was effective and all the previous output was ignored. After the change, a paragraph sequentially display all display system directive in the output result.
To do that, on the front-end side,
Created ResultCtrl controller under zeppelin-web/src/app/notebook/paragraph/result
and moved paragraph result rendering related scripts/templates under this directory.
/notebook/paragraph/paragraph-graph.html -> /notebook/paragraph/result/result-graph.html
/notebook/paragraph/paragraph-pivot.html -> /notebook/paragraph/result/result-pivot.html
/notebook/paragraph/paragraph-result.html -> /notebook/paragraph/result/result-results.html
/notebook/paragraph/paragraph-chart-selector.html -> /notebook/paragraph/result/result-chart-selector.html
on the back-end side,
Created zeppelin-interpreter/interpreter/InterpreterResultMessageOutput.java to take care of single output stream and existing zeppelin-interpreter/interpreter/InterpreterResultMessageOutput.java changed to take care of multiple outputs through InterpreterResultMessageOutput

Compatibility between old, new notebook format.
note.json format is changed to store multiple outputs in the paragraph.
To read note.json created by previous versions of Zeppelin, Notebook.convertFromSingleResultToMultipleResultsFormat() will automatically convert format when note.json is loaded in Zeppelin.
If old version of Zeppelin reads notebook created by newer version, everything will be load normally except for output. Output will be empty.
In detail, note.json is changed from
paragraph : [
   {
       result : {
           code: "",
           type: "",
           msg: ""
       },
       config : {
          graph : {},
          ...
       },
       ...
   },
   ...
],
...

to
paragraph : [
   {
       results : {
          {
             code: "",
             msg: [
                {
                     type: "",
                     data: ""
                 },
                 {
                     type: "",
                     data: ""
                  },
                  ...
             ]
       },
       config : {
          results : [
             {
                 graph : {},
             },
             {
                 graph : {},
             },
             ...
          ]
       },
       ...
   },
   ...
],
...

Every other changes are trivial
Most changes are trivial change due to change of InterpreterOutput and InterpreterResult api changes.

Very nice @Leemoonsoo 👍
I have tested this with the matplotlib tutorial notebook just to see if ZEPPELIN-1638 is also resolved by this, and everything checks out!

tried locally and works as expected, LGTM!

Thanks @agoodm @khalidhuseynov for the review!
Merge to master if there're no more comments.

@Leemoonsoo FYI, #1632 added another set of tests. The interpreter result format for these should be changed as well.

@agoodm merged master and addressed tests added from #1632.
CI failure is not related. Merge to master.


Sync with the mainnet doesn't work

Hello, I'm trying to set up the EOS node but for every p2p-peer-addresses I got errors such as Connection refused, Connection reset by peer or closed connection.
It worked a week ago, but now I can't sync my node with the mainnet.
What could be the reason and how can it be fixed?
EOS server version 1.6.0

@4ban I seems having the same issue. Could you help me?? How did you fix the issue??