Messages should have persistent counters

Problem
Message IDs are sequential and ids are used for request ack. If 1 is always a starting value, we have a high chance of collision during unexpected resets.
Proposed Solution
Use a PersistentCounter implementation for message id tracking, so that message numbers are not reused except after very long times.

@andy31415 Is this talking about PASE/CASE counters (which restart at 1 for each new key and are not persistent, per spec) or something else?


Increase count

Congratulations on making a pull request!
Please make sure you check all the items.

[x] The numbering of the company that you added starts with 1.
[x] You have increased the Total Companies Added count.

You can merge this


fix assertion failure when timer goes back

due to loss timer not causing anything to be sent and PTO timer for the previous sent event kicking in.

[x] discard Initial space and sentmap entries of Initial packets, before processing the payload of the first Handshake packet
[x] allow tail-recursion of quicly_send, only once, preferable only when under the condition being discussed
[x] cherry-pick #172 with necessary changes

fixes #171.

Confirmed using https://github.com/h2o/h2o/commit/dd75ecb8341a875320ed125690c0dc5f4a58ef86 that 0b71860 fixes the issue.

Great! Thanks for working on this, looks good so far.

Thank you for the review.


Support cross-origin isolation

I'm testing code that uses SharedArrayBuffer and I'm getting the following warning in the Chrome console:

[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.

Will there be a way to enable cross-origin isolation in Karma so that SharedArrayBuffer doesn't break?

After some digging through the code, I fould out that you can inject custom middlewares into the http server like this:
karma.config.js:
function CrossOriginIsolationMiddlewareFactory(config) {
    return function crossOriginIsolation(req, res, next) {
        res.setHeader('Cross-Origin-Opener-Policy', 'same-origin');
        res.setHeader('Cross-Origin-Embedder-Policy', 'require-corp');
        next();
    };
}

module.exports = function (config) {
    config.set({

        // ...

        plugins: [
            // load all default karma plugins (this would be the default value if we didn't specify the plugins manually)
            'karma-*',
            // add custom middleware plugin
            { 'middleware:cross-origin-isolation': ['factory', CrossOriginIsolationMiddlewareFactory] }
        ],

        // ...

        beforeMiddleware: [
            'cross-origin-isolation',
        ],

        // ...

    });
};

Would be amazing to have a simple configuration option nonetheless.

Thank you so much for posting this code! 100% agree that it would be really useful to have this as a simple configuration option.


Refactor generateNewCertificate() method in renew_certificate.go

Describe the issue
It is related to recent refactoring PR in dapr/dapr- https://github.com/dapr/dapr/pull/4582
We must refactor the method here https://github.com/dapr/cli/blob/0c514816cdc5de73bc0106a922103293bf810926/pkg/kubernetes/renew_certificate.go#L151
to make use of newly exported method from sentry here
https://github.com/dapr/dapr/blob/a1f71d1a47cd613b62662ac558e3f4314d1ea26e/pkg/sentry/ca/certificate_authority.go#L242
without the above change the renew certificate would fail as the earlier exported variables from sentry has been refactored.
Release Note

RELEASE NOTE:

/assign


adding content type for attachments for IE 11 support

Firefox and Chrome browsers derive the "Content-Type" header parameter from the attachment blob, but IE doesn't.

Another great catch - thanks!


comma-separated dash-strings

Make use of dash-plugin syntax for multi-docset search.
The third commit is not dependent on the two others, it's only more defaults for rust, stylus and tex.

Thanks for taking the time to do this! I've cherry picked the third commit here: https://github.com/keith/investigate.vim/commit/b097f21f7c23637487f44f1afc0b9c895e1f4471

As for the rest of these options I'm not sure that we want to include these in investigate. Since they vary pretty widely and you can combine these locally with Dash, I'd lean towards encouraging users to do that, or setting these in your vim config.

Well, without the first commit, you need different configurations for machines with old/new versions of Dash [old ones will choke on the comma-separated syntax], so you cannot really do this on the user side.
As far as the recommended settings go, what I like is that these defaults, as advised by https://kapeli.com/dash_plugins will be intersected with the docsets locally installed, resulting in the best possible experience, without having to sync in some weird way your installed docsets and your investigate config.
Moreover, currently there are some hardcoded choices, like "java6", that would benefit from the more general advised defaults.
Of course, this remains up to you…

Ah I hadn't seen these defaults before. Can you rebase this branch? I think we should merge this.

I think I just did (but I'm not a git guy, I'm a mercurial guy, so… sorry if I introduced spurious commits…).

Awesome, thanks a lot for doing this!


Turn off Security Center Defender to turn off automatic Provisioning?

Looking at this section:
How do I stop the automatic agent installation and workspace creation?
It recommends to turn off Azure Security Center Defender in order to turn off automatic provisioning?  Then just under, in the section, "What are the recommended steps when opting out of automatic provisioning?" it shows Azure Defender being on.
This is thoroughly confusing and contradictory.
I don't understand why you would have to turn off Security Center Defender to turn off Automatic Provisioning as Automatic Provisioning isn't a requirement when you turn on Security Center Defender.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d14c247-d347-28bc-11ce-516138d89ca8
Version Independent ID: 282e4e15-4718-7cc1-9573-8cba0b6a69cc
Content: Azure Security Center FAQ - data collection and agents
Content Source: articles/security-center/faq-data-collection-agents.yml
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@ElanShudnow Thanks for the feedback. I have assigned the issue to the content author to evaluate and update as appropriate.

Hi @ElanShudnow, thanks for the feedback and for taking the time to help us improve the docs.
You're right, this FAQ entry was definitely unclear. I've revised it and the new version will go live within the next 24hrs. Please take a look and let us know if you now agree it's a better description of the correct procedure.
I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
#please-close


[BUG] --test argument is not working when more than one suite specified

When run robot with --test option and more that one test suite specified, robot can not find that test.
For instance:
$ pybot --outputdir output --test Suite2.Suite2.MySuite.MyTest suite1 suite2
[ ERROR ] Suite 'Suite1 & Suite2' contains no tests named 'Suite2.Suite2.MySuite.MyTest'

Please note test name Suite2.Suite2.MySuite.MyTest. This how it appears in reports when several suites are specified.
Same for:
$ pybot --outputdir output --test Suite2.MySuite.MyTest suite1 suite2
[ ERROR ] Suite 'Suite1 & Suite2' contains no tests named 'Suite2.MySuite.MyTest'

Though
$ pybot --outputdir output --test Suite2.MySuite.MyTest suite2

works as expected.
This issue also affects --rerunfailed option:
-R --rerunfailed output  Select failed tests from an earlier output file to be
                          re-executed. Equivalent to selecting same tests
                          individually using --test option.

Tested on versions 2.8.5, 2.8.6 (Python 2.7.8, linux) .

Worked for me using --name Example! Thank you very much @pekkaklarck . I spent hours trying to resolve this problem!


Plans for a new release?

Next Sunday, it'll be exactly one year since the last release of thor.
I was wondering if there's plans for a new release?
I tried rails and bundler against the master branch of thor, and things are working fine (from a CI point of view, at least).
Thanks!!

I do have plans to make a new release and I believe it should be the 1.0. I still need to verify if there is any feature I want to include inside thor before doing so. I'll try to do in the next weeks.

@rafaelfranca  a new release would be great, we need to use the functionality allows multiple values if repeatable is specified and it would be great to have it in an official release.

I'm just preparing the release. It will require Rails to be released before thor otherwise we will see a lot of warnings. I'll start the preparation for a Rails release.

1.0.0 released


Added an operating system

I've added my OS that I've very casually worked on in my spare time for about a year now. I think it has enough substance to be worth sharing at this stage.

Thx for the PR!


assay in other format than matrix causes an error

Hi,
many our functions expect that assay is in matrix format. However, that is not the case all the time. In TreeSE, assay can also be in data.frame format, for instance. When user imports counts data in df format, this causes an error which is hard to interpret.
We should solve this somehow. We could

Add checks for every function that is affected by this problem, (and convert the data in matrix format if possible)

Add checkImport function that checks that the data is imported correctly

-Tuomas

I think this is a good solution, when accompanied by an informative warning that might suggest that the user considers converting the assay into matrix format. It is likely that they want to do that, if they are trying to call functions that expect this.
It is good to have an object validator and that could potentially check other things at the same go.


[Cosmos DB] az cosmosdb postgres Fix invalid escapes

Related command

Description
As part of https://github.com/Azure/azure-cli/issues/28829 fix
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Cosmos DB


GPII 2544 - Deploy CouchDB in cluster mode

The following changes creates a cluster of CouchDB 2 in Kubernetes. It uses CouchDB 2 to use the cluster capability.
More info at: https://issues.gpii.net/browse/GPII-2544

CouchDB 2

GPII uses couchdb 1 today. What are the impacts of the switch to couchdb 2 on the rest of the project?

Most of the comments solved. I have to check the restoration of the backups.


GEOMESA-2935 Optimize inArray filter function use

Signed-off-by: Jim Hughes<EMAIL_ADDRESS>

will merge when the CI build finishes


Would you rebuild the project for Firefox in a few months?

Unfortunately, I don't have any plans to do that right now.  Thanks for asking!


nz-select dropdown content does not scroll with the modal parent

Reproduction link
https://stackblitz.com/edit/angular-a5kqqf?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
Open the modal.
Click the nz-select control.
Scroll the modal content.
What is expected?
nz-select dropdown content should scroll together with the rest of the page and follow the control.
There are many tickets regarding this on ant-design repo. Please take a look: https://github.com/ant-design/ant-design/issues/8268
What is actually happening?
nz-select dropdown content does not move with the rest of the page and is fixed in one position.

Environment
Info

ng-zorro-antd
15.0.2

Browser
Chrome

This currently happens on the newer version as well.

ng-zorro-antd
15.0.3

this happens to me aswell but with the nz-mention, but in the demo docs it does work

this issue only occur when use in nz-modal.

The same for DatePicker, TreeSelect, etc. Reproduces in Drawer component as well.

hi @vthinkxie
I got the same issue. Please help to fix this issue.

@vthinkxie, I'm also having the same issue

I also have the same issue, and there are many dropdown menus in my project that exist on a scrollable page. This is a significant issue for me. Has anyone fixed it yet?

I also have the same issue! Has anyone any solution?

Iam also having same issue

Listen for box scrolling events, trigger the 'updateCdkConnectedOverlayPositions' method of the' NzSelectComponent ' instance element

Iam also having same issue. please help me someone

Same issue.

trans

Hi. Someone find a solution ?

Is there any solution for this ?

As a workaround, you can write a custom ScrollDispatcher.
The ScrollDispatcher is used to emit an event when any one of the Scrollable references emit a scrolled event.
It is used to update the position of an overlay when a scroll occurs, and by default, it listens only to the document.defaultView.window.
So I wrote the following CustomScrollDispatcher that will listen to all scroll events in your page, and register the HTMLElement who was scrolled in the ScrollDispatcher.
Hence, when you scroll it, the dropdown position will be updated.
Code is provided as is, I didn't notice yet any side effects.
import {
  ClassProvider,
  ElementRef,
  Inject,
  Injectable,
  NgZone,
  Optional,
} from "@angular/core";
import {CdkScrollable, ScrollDispatcher} from "@angular/cdk/overlay";
import {Platform} from '@angular/cdk/platform';
import {DOCUMENT} from "@angular/common";

@Injectable({providedIn: 'root'})
class CustomScrollDispatcher extends ScrollDispatcher {

  private scrollables: Map<HTMLElement, CdkScrollable> = new Map();

  constructor(_ngZone: NgZone,
              _platform: Platform,
              @Optional() @Inject(DOCUMENT) document: any) {
    super(_ngZone, _platform, document);
    this.registerAllScrollsAsScrollables(document, _ngZone);
  }

  registerAllScrollsAsScrollables(document: Document, ngZone: NgZone) {
    document.addEventListener('scroll', (event) => {
      if (event.target instanceof HTMLElement) {
        if (!this.scrollables.has(event.target)) {
          // Avoid memory leaks
          this.cleanScrollables();

          const scrollable = new CdkScrollable(new ElementRef(event.target), this, ngZone);
          this.scrollables.set(event.target, scrollable);
          this.register(scrollable)
        }
      }
    }, true)
  }

  cleanScrollables(): void {
    for (const [element, scrollable] of this.scrollables) {
      if (!element.isConnected) {
        this.scrollables.delete(element);
        this.deregister(scrollable);
      }
    }
  }

  override ngOnDestroy() {
    super.ngOnDestroy();
    this.scrollables.clear();
  }
}

export const CustomScrollDispatcherProvider: ClassProvider = {
  provide: ScrollDispatcher,
  useClass: CustomScrollDispatcher,
};

// export const appConfig: ApplicationConfig = {
//   providers: [CustomScrollDispatcherProvider, ...]
// };

same

This PR will fix the issue mentioned above for all components created with the CDK Overlay that are inside modals or drawers: #8804.
As a temporary fix, you can follow these steps:

Create a wrapper inside your modal or drawer
Add the cdkScrollable directive to the wrapper
Set overflow: auto on the wrapper

This way, the wrapper will handle the scrolling.
You can refer to this link for a sample.


height does not exist

height is in the docs but not in the code

Can you provide a link to where “height is in the docs”? There shouldn’t be a height function as it’s generally not a good css property to use often

This happened to me the other day. Have sense do not include height.
You expected height because width is present, but the reality is you only use height for fixed things, like cards, input, etc. There is no customization here, just a fixed.
so include it as HoC make impossible determinate a generic user case for use it.

I have a hero image where the height should be responsive so I'd like to use an array.
Why is height not a good CSS property to use?

Anyways it seems to be included now but it doesn't seem to work responsively.

It used in the doc here but does not seems to work


Can you give me a contact? I want to discuss some issues with you

Its on my Github & Gitlab Profile


Release Google.Cloud.Trace.V1 version 2.2.0

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Cloud.Trace.V1-2.2.0


[Challenge] Fast Peak Picker

Fast Peak Picker
Given a array that's sorted but rotated at some unknown pivot, in which all elements are distinct, find the "peak" element. An element is considered a peak if it is greater than both its left and right neighbors. For example, [1, 2, 3, 2, 1] has a peak element of 3.
Business Rules/Errata

The input will always consist of an array of numbers containing at least one element.
The first element in the array is always considered to be "larger" than the (non-existent) element to its left.
The last element in the array is always considered to be "larger" than the (non-existent) element to its right.
It is possible to solve this problem in less than O(n) time, attempt to find a more efficient solution.

Examples
pick_peak([1, 2, 3, 2, 1]);  // 3
pick_peak([1, 2, 3, 4, 5]);  // 5
pick_peak([5, 4, 3, 2, 1]);  // 5
pick_peak([1]);              // 1

Closed by #154

Closed by #154


Slowness during the display

As it was reported on our Slack community, some slowness is noticeable using the mini-dashboard.
This slowness is not present when only using instant-meilisearch (the dependency used by this repo).
As you can see:
Mini-dashboard:
https://user-images.githubusercontent.com/20380692/139108096-d4e8d7fc-03f8-4157-adc6-11697c02f239.mp4
Only instant-meilisearch
https://user-images.githubusercontent.com/20380692/139108334-2cd7f9fd-a200-46a2-a618-ced5a453a086.mp4
Also here are the processing time of Instant MeiliSearch

Can interest @bidoubiwa
Ask for @bidoubiwa for the dataset

Checked with @bidoubiwa, some additional information that might interest the mini-dashboard:

we are aware of some latencies (or feeling of latency) on the Instant-MeiliSearch side. We already know how to improve them, here are: https://github.com/meilisearch/instant-meilisearch/issues/588 and https://github.com/meilisearch/instant-meilisearch/issues/569. Once they are fixed, this might help the mini-dashboard being faster! Should be done by @bidoubiwa after the strapi work!
MeiliSearch is slower since v0.21.0 for some intensive searches because of the words criterion that gathers more candidates for each request. Ex: for the "coco titi" query, MeiliSearch now returns all candidates containing "coco" AND "titi" but also just "coco". Before v0.21.0 MeiliSearch only returns candidates containing "coco" AND "titi". This feature was widely asked, that's why it was added, but core team plans to add an option allowing the users to remove this behavior (beginning of 2022 probably). We'll let you know when it's released since it can interest the mini-dashboard.

However, these both points do not explain why there is a difference in latency between instant-meilisearch alone and the mini dashboard, unfortunately (cf videos in the issue description)

In my mini dashboard, just loading the index list causes the whole page to slow down. It's to be noted I have 1300 indexes as part of the experiment. Each index can have as much as 1000-150k documents, which is noticable in the screenshot. Some of the indexes have 0 documents.

Hey @entrptaher, I see a search request that has been done in the calls. How long do the stats and the search requests take?  This would let us now which one of the routes are being stressed in your setup :)

Hey @bidoubiwa 👋
Using the GET /indexes route could help since it's can be paginated with offset/ limit since v0.28

I agree @gmourier ! I was wondering out of curiosity if it was stats that is causing slowness but we should definitely use GET /indexes. @mdubus what do you think?

The requests are fast, but when they render 1300 items, it gets slow. :(

I think the solution to that would be to lazyload the index list See example and more information here

I would like to do this.

@bidoubiwa a quick update on this one. I am almost done with it. I am using react-window with react-select. Just need to do little style change and I will be done. Btw I want to know if testing it with 1300 (datasets)  is enough or I should go for more.

Hey @vaibhav135
Since this PR is very old, I'm not sure this is still an issue. In your PR, could you see a big difference in processing time?

Yes definitely, I would say when you have like 1300 (approx.) datasets loaded. The current dropdown is barely usable and super slow. I will attach the before and after once I am done.

Nice! Thanks a lot :) If you already see some significant improvements, you don't need to test with more. If you still would like to, you can use this one https://github.com/meilisearch/datasets/tree/main/datasets/movies

Hey, here's a quick before and after
Before
https://github.com/meilisearch/mini-dashboard/assets/39329182/acd1bc10-9fcd-4c3f-b221-c9c711562f1d
After
https://github.com/meilisearch/mini-dashboard/assets/39329182/1aa2f611-ab2a-4f07-8752-16a86401d359

Hey @vaibhav135 thanks, indeed it's way faster :)


Player resizing broken with galacticraft [1.12.2]

when using both galacticraft and chiseled me for 1.12.2 the player camera stays at the same height and the player hitbox sizing isn't working like it's supposed to.
this could be an issue with conflicting ASM code on either side.

The latest release of chiseled me is incompatible with Galactricraft, but in the discord server of the mod there is a beta with a fix for it (if you really want to use Chiseled me with Galactricraft now and can't wait for the new release to come out)

thank you, I am working on a pack featuring Chiseled me as one of the mods but sadly enough GalactiCraft isn't the only mod causing issues, I know VanillaFix messes with the player model and prevents chiseled me from starting but I'll open an issue for that once I have more information.
thank you very much for pointing this out to me, is it ok if I keep this issue open untill the release is on curseforge.

The discord release is technically a beta (albeit "released" only in discord) so you are free to use it.
Or like, you can clone this repo and compile it yourself :)
Yeah I was a bit busy with all sorts of stuff, so I'll try to make a release finally at some point

i am having the same issue where the game opens but then closes with no error on sky factory 4 modpack and added this mod to it wont allow it to start

@landpointpro if you don't know why the game doesn't start, I suggest you to make a new issue and post all the required files to make the developer possible to try to fix the issue. Reply here only if the issue is related to the Galactricraft mod

Closing as duplicate of #36, fixed in discord beta

Closing as duplicate of #36, fixed in discord beta


Add-CMSoftwareUpdatePoint - Not all Common Parameters are supported

The "Add-CmsoftwareUpdate" PowerShell cmdlet is documented as supporting the common_parameter set. However it appears the -errorAction cmdlet doesn't work properly.
-Verbose works but some of the others do not work as intended.

Upon further digging the example code seems to not be working properly either. If you attempt to use the example provided it complains that it's being handed an invalid object.

Should we replace [<CommonParameters>] with just -verbose to resolve your first comment?  -WhatIf and -Confirm are listed there already.

@ChrisKibble  -> I need to do some more digging but I think the actual cmdlet itself is broken.
If you use the "example" provided from Get-Help or the documentation it complains about an invalid object. I am going to go back and look at the required pieces.


Add support for Erlang

Based on an Elixir one (thanks @piisalie).
Tested to work with the Erlang starter kit available at
https://github.com/moiseev/starterkit-erlang.

Can we release your starter kit code under MIT license instead of Apache license? It's more convenient for us.

@beevee I see the Erlang starter kit already made its way to the official GitHub organization. Will remove mine. Thanks!

Yeah, we took your starter kit and tweaked it a little. Thanks!


Github Actions: Improve workflows

It seems like the package tests are not running Laravel 10 correctly and always install Laravel 9.
I also made some other improvements to the Github Action Workflows.

Thanks!


Move EventCategory definition to review-protocol crate

https://github.com/petabi/review-database/blob/c52ee92e4393026cfd5fcbfaa9edab88795cf0d9/src/types.rs#L44-L55
We've decided to assign EventCategory to the detected events when they are created.
To share the EventCategory definition between server and client(analyzer), the definition must be moved to review-protocol crate.

[x] Move EventCategory definition to review-protocol crate
[x] Remove the HttpThreat member from the EventCategory
[x] Modify related code

@msk
Is it ok to move the EventCategory to review-protocol crate?
I want to share the EventCategory definition between client and servers via review-protocol crate.

@syncpark,
Yes, it's fine to move the EventCategory definition to the review-protocol crate. This makes sense for sharing the definition between client and server components.
Here are a couple of points to consider:

In review-protocol, we want to keep the EventCategory definition minimal, with only the essential derives needed for protocol-level operations. This helps us minimize dependencies on other crates in review-protocol.

For review-database, we should create a separate EventCategory that wraps or maps to the one in review-protocol. This allows us to add any additional derives or functionality needed for database operations without affecting the review-protocol definition.

This approach allows us to maintain a clean separation of concerns and minimize dependencies in review-protocol while giving review-database the flexibility it needs.
Regarding your specific tasks:

Moving EventCategory to review-protocol: Approved. Please ensure you only include the minimal necessary derives for protocol-level operations.
Removing the HttpThreat member: If this is no longer needed, that's fine. Since we're already breaking backward compatibility, this removal shouldn't be an additional concern.

Can you explain how to do the enum wrapping?

Please see Wrapping a remote enum.


add additional utf-8 encodings

There was an error when generating the html report that this change fixes.

Thank you!


db.CreateTable() doesn't create index/unique_index/combined_index whereas db.AutoMigrate() does. Is it intentional ?

Yes, CreateTable should only create table just like its name ;)


Update sample code in ProcessMonitor documentation

In 1104a6ccc182d94e3ec25afa4a2d028d6c642cc4 an extra BackpressureAuth
parameter was added to ProcessMonitor::create(), but the sample code
was not updated.
[skip ci]

Thanks @clearyf!


demo commit

ron is learning Git and Pull requests :-)

Hi @rtielke, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

nice change @rtielke  :-)


"Add Azure Account" presents an unclickable link

Issue Type: Bug
When you try to sign in to an Azure account ("To sign in, use a web browser to open the page ..."), the link is not clickable, and the text can't even be selected to copy/paste it!
Azure Data Studio version: Azure Data Studio 1.0.0 (cab8f3e37c9ac4367e0dacef5185da08bd8021c2, 2018-09-20T21:41:50.803Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
32.00GB (0.12GB free)

Process Argv
/Applications/Azure Data Studio.app/Contents/MacOS/Electron -psn_0_3507032

Screen Reader
no

VM
0%

Extensions: none

This experience has been improved in the Feb release.  Please let us know if you're still impacted by this issue.  Thanks for reporting!


Requires trailing newline?

This is a tricky issue. I was going through the wiki page of examples and the readme, to remove all the tr munging now that we do '[:space:]' inside spark itself, when I discovered they weren't working! A stdin problem? But when I took the examples' output and manually echoed them in, spark worked! Huh?
$ echo -n 1,2, | spark && echo true
$
vs
$ echo 1,2, | spark && echo true
▁▂
true
I messed around and found that echo -n did cause the failure. After some more digging and use of set -x and tee, I found that spark was bombing out with an error at line 148, with read. If you do help read you find it demands a newline at the end of the input, or at least that its caller specify an end-of-input delimiter. We can't really do that because the last character will usually be a number we want! So I went to #bash and asked for help. It turns out that set -e is the problem - read is populating the array as we want it to, but then it reaches the end of input, returns a bad exit code, and per the arcane ad hoc rules governing it (http://mywiki.wooledge.org/BashFAQ/105) that kills the script. Or something like that. Bash example (note which one prints out):
$ echo -n 3,4, | { read var && echo true1; echo "$var"; } && echo true2
3,4,
true2
Removing set -e fixes the problem. The FAQ says 'GreyCat's personal recommendation is simple: don't use set -e. Add your own error checking instead.' so hopefully that wouldn't be too big an issue.

This is great work. Merged it in. Thanks so much for digging way way into this for me. I noticed something had broken it earlier but was too busy to actually dive in and see what the problem was.
:+1:


Opencv failing to install, no formulae found

Here is the error
❯ brew install homebrew/science/opencv --with-ffmpeg
Error: No available formula with the name "homebrew/science/opencv"
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/science is shallow clone. To get complete history run:
git -C "$(brew --repo homebrew/science)" fetch --unshallow
Error: No previously deleted formula found.
==> Searching for similarly named formulae...
==> Searching local taps...
Error: No similarly named formulae found.

Try using this
$ brew tap homebrew/science
$ brew install opencv3 --with-contrib --with-python3 --HEAD
If the head shows headless or something just remove --HEAD from the end


Room Tags Appear/Hide as you zoom in

The room/area tags should appear on the map as the user zooms in and out.
We will only show the tags of the larger rooms (rooms greater than x area) this is to be defined once we start working on it.
As the user zooms in, the room tag will auto-appear within the polygons, and as they zoom out they will l disappear in similar manner to issue 2 - Geofencing.
Only larger rooms will be shown as there is no need to view the tags of rooms such as toilets, meeting rooms, storage etc etc.

Done for now


Implement react-error-boundary

Fixes #270
Implement the react-error-boundary package to handle errors globally in the application.

Add Dependency

Add react-error-boundary to the dependencies section in package.json.

Update RootLayout Component

Import ErrorBoundary from react-error-boundary in src/app/layout.tsx.
Define an ErrorFallback component to display an error message.
Wrap the RootLayout component with ErrorBoundary and use ErrorFallback as the fallback component.

For more details, open the Copilot Workspace session.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.00%. Comparing base (0e9b776) to head (3903514).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   98.00%   98.00%
=======================================
  Files          22       22
  Lines         200      200
  Branches       59       59
=======================================
  Hits          196      196
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


EIO supports PHP 7 these days, but breaks on nightly

Ping @jsor (will squash and merge after you reviewed and approved this PR)


The plugin upi_india requires your app to be migrated to the Android embedding v2.

I cant use upi india as dependency. It shows migration error how to solve this issue.

That means your Flutter application is created using older version of the Android
embedding (v1) which has been deprecated. You need to migrate your application to use v2 embedding plugins.

That means your Flutter application is created using older version of the Android
embedding (v1) which has been deprecated. You need to migrate your application to use v2 embedding plugins.

https://stackoverflow.com/questions/65018588/your-flutter-application-is-created-using-an-older-version-of-the-android-embedd
This may help.

https://stackoverflow.com/questions/65018588/your-flutter-application-is-created-using-an-older-version-of-the-android-embedd
This may help.

Thank You For Your Quick Response. Regular Updates need. Thank You.

Thank You For Your Quick Response. Regular Updates need. Thank You.


Error Updating: Update hash signature mismatch

I didn't have an issue earlier today, but in the last hour or so something has changed as I'm now getting this failure:
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
heroku-cli: Updating to 5.2.40-09fa7ac... done
error loading plugin commands
sh: 1: /root/.heroku/heroku-cli: not found
error loading plugin topics
sh: 1: /root/.heroku/heroku-cli: not found
error loading plugin commands
sh: 1: /root/.heroku/heroku-cli: not found
sh: 1: /root/.heroku/heroku-cli: not found
Updating Heroku CLI... !    Heroku client internal error.
 !    Search for help at: https://help.heroku.com
 !    Or report a bug at: https://github.com/heroku/heroku/issues/new

    Error:       Update hash signature mismatch (Heroku::Command::CommandFailed)
    Command:     heroku --version
    Version:     heroku-toolbelt/3.42.15 (x86_64-linux) ruby/1.9.3
    Error ID:    8d6109d7682346b5b1ac17f0f3d05866

This is no longer a problem for me:
heroku-toolbelt/3.43.10 (x86_64-darwin10.8.0) ruby/1.9.3
heroku-cli/5.2.40-09fa7ac (darwin-amd64) go1.6.2
=== Installed Plugins
<EMAIL_ADDRESS>heroku-config
<EMAIL_ADDRESS>
Out of curiosity can you let us know why this happened. Thanks.

You were just updating during a partial release which was an error on our side. The release is complete now.


GL Image refactor

We haven't been taking care of the backend, so I'm trying to catch up a bit. This PR aligns the use sections to the other backends, fixes creation of image views and refactors them internally. Finally, it removes glutin code altogether.
cc @zicklag

Yay! So we can get rid of all of the WGL code then too right? Also, are we going to want move this commit over to the hal-0.6 branch too?
I figure to create that PR I'll be cherry-picking my GL commits plus the ones in this branch, though probably wait for this to merge right?

@zicklag please rebase your upcoming 0.6 changes on top of #3455

OK, it's up at #3457.


Open a convo when clicking on an assistnat in welcome page

Tiny PR to add a click interaction when clicking on an assistant in the welcome page.
It will open a convo asking the assistant how it can help.
Discussed here: https://dust4ai.slack.com/archives/C050A0S2Z7F/p1695817114308379

Answered on Slack to keep the discussion in one place!

Thank you!
(slack thread: https://dust4ai.slack.com/archives/C050A0S2Z7F/p1695817114308379)


Some links in the project links have incorrect/outdated label names

🐞 Problem

When following some links (Fun Retros, react, Node), the github page shows "No results matched your search" which might lead the beginner contributor to think there are no beginner-level issue.
🎯 Goal

To point the links to the proper list of issues (filtered using the proper labels)
💡 Possible solutions

Update the links
📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

So far I've checked the links on the repos I was interested at and only found the three enumerated above. I can work on fixing all the incorrect labels in the links in listOfProjects.js.

@aysonje, would you like to take this up and fix this?

@Roshanjossey yes, please!

@aysonje, All yours

@aysonje, I'm closing this.
Fixed in #845


Add query_string option to append params

Forked from #91. Solves #89 and #70.

@keslert @minibikini This has a pretty critical bug in it. On line 349 you're calling |> String.replace(~r/&?page=\d/, ""), which doesn't account for page numbers with multiple digits.


add decision group type

Today the filed DecisionGroup and ClustersPerDecisionGroup is on the same level,  and the name "ClustersPerDecisionGroup" makes user easy to misunderstand that it's used to define the cluster numbers of "DecisionGroup".
To avoid misunderstanding, this PR wants to add a decision group type static and dynamic, to clarify that DecisionGroup and ClustersPerDecisionGroup are working separately.

/assign @qiujian16 @serngawy

Not sure,  where is a confusion come from ? The user can only set the ClustersPerDecisionGroup to divide the selected clusters to groups

For example as below, the "DecisionGroups" "prod-canary-west" has 120 clusters, and it actually won't be divide by "numberOfClustersPerDecisionGroup". "numberOfClustersPerDecisionGroup" only works on the rest of "DecisionGroups" "prod-canary-west".
  DecisionStrategy:
    numberOfClustersPerDecisionGroup: 50
    DecisionGroups:
    - label: prod-canary-west
      clusterSelector:
        matchExpressions:
          - key: prod-canary-west
            operator: Exist
….
status:
  numberOfSelectedClusters: 200
  decisionGroups:
  - decisionGroupIndex: 0
    decisionGroupLabel: prod-canary-west
    placementDecisions:
    - ztp-placement-decision-0 // cluster1 to cluster 100
    - ztp-placement-decision-1 // cluster101 to cluster120
    clusterCount: 120
  - decisionGroupIndex: 1
    placementDecisions:
    - ztp-placement-decision-2 // cluster121 to cluster 170
    clusterCount: 50 //
  - decisionGroupIndex: 2
    placementDecisions:
    - ztp-placement-decision-4  // cluster171 to cluster 200
    clusterCount: 30

For example as below, the "DecisionGroups" "prod-canary-west" has 120 clusters, and it actually won't be divide by "numberOfClustersPerDecisionGroup". "numberOfClustersPerDecisionGroup" only works on the rest of "DecisionGroups" "prod-canary-west".
  DecisionStrategy:
    numberOfClustersPerDecisionGroup: 50
    DecisionGroups:
    - label: prod-canary-west
      clusterSelector:
        matchExpressions:
          - key: prod-canary-west
            operator: Exist
….
status:
  numberOfSelectedClusters: 200
  decisionGroups:
  - decisionGroupIndex: 0
    decisionGroupLabel: prod-canary-west
    placementDecisions:
    - ztp-placement-decision-0 // cluster1 to cluster 100
    - ztp-placement-decision-1 // cluster101 to cluster120
    clusterCount: 120
  - decisionGroupIndex: 1
    placementDecisions:
    - ztp-placement-decision-2 // cluster121 to cluster 170
    clusterCount: 50 //
  - decisionGroupIndex: 2
    placementDecisions:
    - ztp-placement-decision-4  // cluster171 to cluster 200
    clusterCount: 30

Well, looks kind of strange case; How is the num of canary clusters is more than the rest of running clusters ? theoretically this could happen but practically I don't think this right.
In other hand;  if that the case better to apply the numberOfClustersPerDecisionGroup to the decisionGroup so we could have many decision group with same GroupNameLabel and different GroupIndexLabel to satisfy the numberOfClustersPerDecisionGroup.

This example is not a real-world one, it is to explain why I think the name is confusing. The defined "DecisionGroups"  is actually not divided by "numberOfClustersPerDecisionGroup".

If we don't expect the canary clusters to be more than the rest of the running clusters and don't expect the canary clusters to be divided, the current name is confusing, that's why I create this PR.
If we think once canary clusters is larger than the "numberOfClustersPerDecisionGroup" and need to be divided, I'm to just keep the current API, just change the API explanation.


Will this work for ESXi 6.0 ?

Hi,
Will this version still work on ESXI 6.0?
Thanks in advance for your reply!
Ivo

It should work but be advised I have been given a report that ESXi may experience issues and so I am probably going to stop development on it.


add driver for keithley6500

@lucblom @astafan8 @WilliamHPNielsen

@Christian-Volk I addressed some of the comments, can you look at the remaining comments?


Update README.md

@adhir-lalla
The content is good and informative. I only had to add punctuation. I included a resource for commas in case you are curious.

Added comma after library as it’s an introductory phrase
Added comma before and after the phrase: ’and at the same time’
Added hyphen between large and scale
Added comma between adjectives large-scale, non-trivial
Added period after minimal
**This might be picky, but I think the verb form of ‘scales’ should follow the verb form of ‘to create’ as in ‘to scale’. So I recommended a change, too.

Source:
https://owl.english.purdue.edu/owl/owlprint/607/

Thanks Rochell. I will add the commas and hyphen but will leave the verb unchanged


Set bundle loader on darwin platforms to postgres binary

On linux linker assumes -unknown dynamic_lookup by default. This lets the extension shared object file assume the symbols will be provided at runtime. On macOS we can either set -unknown dynamic_lookup as a linker flag or better yet point to postgres binary as the bundle_loader.
This is the behavior postgres sources ensure as well, see: https://github.com/postgres/postgres/blob/master/src/makefiles/Makefile.darwin#L9

cc: @mkindahl, this is my first contribution to this repository. Thanks for making a useful project.

@iskakaushik Thank you for the patch. Merged it.


Supersnappy can raise an unlisted exception

Using supersnappy with Nim 1.6.0 devel :
/home/rcaillaud/.nimble/pkgs/supersnappy-2.1.1/supersnappy.nim(323, 56) template/generic instantiation from here
/home/rcaillaud/.nimble/pkgs/supersnappy-2.1.1/supersnappy.nim(341, 35) Error: newSeq(16384) can raise an unlisted exception: Exception

I am not seeing this with Nim 1.6.0 myself. What is your nim command and do you possibly have any flags / features enabled possibly changing behavior? For example, does a simple nimble test run?

It only happens if you compile with --gc:orc.

Hm, interesting. Thanks for the info. It seems odd to me --gc:orc makes newSeq raise a generic "Exception". I wonder why that is. Will need to take a look.

I added a bunch more test runs to Github Actions and am still not seeing any issues with --gc:orc and Nim 1.6 (or any other version). See this commit: https://github.com/guzba/supersnappy/commit/8deba1f26c6259cf4d97ae04e6f1edd0ec3ac1bc and these runs: https://github.com/guzba/supersnappy/runs/4305537686?check_suite_focus=true
Are you certain you're on stable 1.6? What OS are you seeing this on?

Supersnappy is at commit 62a7e2cea977e51b60005c64741e15ef91cdf542 (I pulled your latest, but I had the same behaviour with tag v2.1.1).
OS is Ubuntu; Nim compiler is devel (v1.6.0 seems to work)
Nim Compiler Version 1.7.1 [Linux: amd64]
Compiled at 2021-11-15
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: 6976d18519d102c9cc857a84a4b10b009c1e1a38

Their CI doesn't use 1.6.1.

Closing this. It's old and was a devel issue. Reopen if still relevant.


Estimate AWS hosting costs for OAR's grant application

OAR is discussing with Amazon the possibility of receiving hosting credits based on its new non-profit status. As part of this, they need to have an AWS account that is separate from the Azavea umbrella account and submit an application for a credit grant.
OAR needs Azavea to provide an estimate of the anticipated hosting costs, based on their AWS pricing calculator.

OAR likely deferring application until post-launch given capacity.

OS Hub no longer needs us to do this.


tools/vscode/generate_debug_config.py Failed

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: Exec tools/vscode/generate_debug_config.py //source/exe:envoy-static  --args "-c envoy-config.yaml" --debugger lldb failed
Description:

Describe the issue.
Local OS: Mac M1
I use vscode-remote container to debug envoy, but when i exec tools/vscode/generate_debug_config.py, it failed, the detail is:

could you please help me? thanks!
[optional Relevant Links:]

Any extra documentation required to understand the issue.

do not contain a toolchain support for cpu aarch

I think it is the root cause.
/cc @lizan

related to #23238

do not contain a toolchain support for cpu aarch

rules_python provides the python toolchain i think https://github.com/bazelbuild/rules_python/blob/main/python/versions.bzl#L120
im a bit confused as to what exactly is failing

the issue here is actually the cc toolchain, i think we need to define a aarch64 version over here to start https://github.com/envoyproxy/envoy-build-tools/blob/main/toolchains/configs/linux/clang/cc/BUILD
im not going to dig into this one anymore right now though

Hello. Is there any update?

change the default cpu type kvm64 to max.

I believe this is already resolved just by removing the line
build --config=rbe-toolchain-clang-libc++

in ~/.bazelrc inside your devcontainer.

@mathetake should we remove L8 from .devcontainer/setup.sh?

sure i think that makes sense


How do I ignore internal superclasses?

The schema generator should ignore internal superclasses.
Take the following example:
inner class User_WidgetsConnection (
  override val edges: User_WidgetsEdge,
  override val pageInfo: PageInfo
): KConnection<Widgets?>

internal interface KConnection<T> (val edges ...)
will throw: java.lang.IllegalArgumentException: Class declares 1 type parameters, but 0 were provided.
I think the reason is that Graphql does not support  typing (which graphql-kotlin correctly complains), but I think the correct behaviour is to ignore the internal KConnection class in the first place.

Thanks for reporting. Your problem is indeed caused by generics which as you noted is because GraphQL does not support it.
In general, graphql-kotlin will attempt to generate schema from the objects that you specify as queries/mutations. Currently we only explicitly filter class properties and functions to only pick up ones with public modifier. As it is right now we don't do any filtering on objects and interfaces. Our assumption was that generally they would have public visibility but nothing stops you from defining them as internal or even private. I'll make a change to make this behavior consistent, i.e. require queries/mutations to be public and only expose public interfaces.

Resolved in https://github.com/ExpediaDotCom/graphql-kotlin/issues/137


fix mention of Return.Successes

this setting was renamed twice. See:

5411ec3676ba932f988c614650cdc314b8def468
4189e55a44bd4e04772171b5e7a7b6dcd12603f6

Oops, thanks!

you're very welcome Evan.  We're big fans of sarama. greetings from NYC :)


Move to NHibernate organization?

I mean here: https://github.com/nhibernate

course we can!
I automate the build and deploy to the nuget with appveyor.
We will need to point to the new fork.

Good news :)
On Mon, Mar 23, 2015 at 3:35 PM, Antônio Milesi Bastos <
<EMAIL_ADDRESS>wrote:

course we can!
I automate the build and deploy to the nuget with appveyor.
We will need to point to the new fork.
—
Reply to this email directly or view it on GitHub
https://github.com/milesibastos/NHibernate.AspNet.Identity/issues/37#issuecomment-85027659
.

Ok, great.
Now you should be able to transfer the repository using settings page https://github.com/milesibastos/NHibernate.AspNet.Identity/settings

Done!


Add more device statistics

Pull Request Test Coverage Report for Build 140

22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.07%) to 98.762%

Totals

Change from base Build 134:
1.07%

Covered Lines:
319

Relevant Lines:
323

💛  - Coveralls


[$250] IOU - Members page is blank

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.85-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Log into staging.new.expensify.com
Navigate to a conversation
Create an IOU
Click on the header of the IOU to access the members

Expected Result:
A members page/ modal should open listing all the members
Actual Result:
The modal is empty (blank)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/cf7c5f36-dae9-46fb-a2d1-7cd0fb6db1f9
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017fcedc031d85e839
Upwork Job ID:<PHONE_NUMBER>624774803
Last Price Increase: 2024-07-08
Automatic offers:

allgandalf | Reviewer | 103086318

Issue OwnerCurrent Issue Owner: @allgandalf

@VictoriaExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Member list page is empty/blank when pressing the multiple display name of a report preview action.
What is the root cause of that problem?
In this old PR, we navigate the user to the report participants page if it's an IOU report (which it is in our case). We do this for both AvatarWithDisplayName (used in the IOU report header) and ReportActionItemSingle display name.
However, all participants are hidden, so when we get the member list, we get an empty list.
https://github.com/Expensify/App/blob/75614394a2fb1e8114e35bb2d8d33bdd0c565946/src/pages/ReportParticipantsPage.tsx#L72-L73
https://github.com/Expensify/App/blob/75614394a2fb1e8114e35bb2d8d33bdd0c565946/src/libs/ReportUtils.ts#L1850-L1856
If we see the AvatarWithDisplayName case, we now update it so that for the IOU report, we navigate to the report detail instead of the participants page.
https://github.com/Expensify/App/blob/75614394a2fb1e8114e35bb2d8d33bdd0c565946/src/components/MoneyReportHeader.tsx#L209-L211
https://github.com/Expensify/App/blob/75614394a2fb1e8114e35bb2d8d33bdd0c565946/src/components/AvatarWithDisplayName.tsx#L78-L82
Also, the IOU report detail page doesn't have a members section.

What changes do you think we should make in order to solve the problem?

I suggest changing the navigation to the report details page too for the IOU report.
Navigation.navigate(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(iouReportID));

I agree this looks buggy and have been able to reproduce the issue:

I believe this belongs to Project VSB

So sorry, I was OoO for a few days and am catching up.
Oh hmm this is a really good question. I initially thought that should show members but perhaps that "members" heading is a bit of a red herring. I'm going to get some input from others - I'll get back to you

Posted in Slack for some more eyes - https://expensify.slack.com/archives/C02NK2DQWUX/p1719985125522659

From Isabella with QA

So, in my case, I would expect that the members participating in the IOU are displayed since you're clicking in the participants mention.
If I would want to see the IOU details, then I would click the preview.
I don't think that we have a test to specifically validate this in TestRail so searching there would not return anything.

Hmm, the members page only shows the non-hidden member (except for group chat). When we create a new IOU, all of the participants are hidden. The IOU report details page also doesn't show the Members field. It only shows once we add a comment to the report.
Maybe we can show the detail page when all the members are hidden OR make an exception for the IOU report too so it shows all members, even the hidden one.

When we create a new IOU, all of the participants are hidden.

@bernhardoj do you know we do this?  Are there other examples of when/where we handle it like this?
For whatever we end up choosing to do here, I'd love for there to be precedence for the choice vs a one-off fix

do you know we do this? Are there other examples of when/where we handle it like this?

I'm not 100% sure why we do that, but I think a hidden participant is a participant who is in the chat but hasn't participated in a chat yet, which explains that they become non-hidden after adding a message. The other examples are group chat and new 1:1 DM, but for group chat, we always shows all members, including the hidden one.
https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/ReportDetailsPage.tsx#L144-L147

Thanks @bernhardoj, those details are helpful. I don't understand the logic or reasoning behind the decision of when to show and not show. Here are a couple examples.

I can see updates in LHN/search for #big-rig but I'm not a member.
When I visit a thread in #big-rig, where I haven't commented, when I click on members, it briefly shows me then I'm removed.  I understand why I'm not a member there but why does it show/remove quickly?

https://github.com/Expensify/App/assets/22508304/1d2600f4-9aac-4bf9-9f8a-f64ce995c72c
For this specific issue, it makes sense to me that we'd want to show the members involved in an IOU.  I'm asking in #expensify-open-source to get more 👀 before moving forward.
https://expensify.slack.com/archives/C01GTK53T8Q/p1720568142568069

Also posted in #vip-vsb.

Let's move forward with what's currently stated in the OP for expected behaviour

A members page/ modal should open listing all the members

Updated my proposal to include a solution to show all IOU report members.

If this involves the report.participants key at all, will you please comment here? We have other bugs related to that.

If this involves the report.participants key at all, will you please comment here?

@mallenexpensify We won't touch the report.participants key.
PR is ready
cc: @allgandalf

Requested in ND.

Hey @VictoriaExpensify a heads up I've issued the payment for @allgandalf per this Slack conversation, will let you post the payment summary though!

Not overdue just sorting out payment details

Contributor: @bernhardoj owed $250 via NewDot
Contributor+: @allgandalf paid $250 via Upwork

$250 approved for @bernhardoj


fix typo

Description (required)
The Chinese translation of this document mentions two 'astro/tsconfigs/strictest'.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


What to do with the GitHub TSA in trusted_root.json

Description
Currently we ship GitHub's TSA as part of trusted_root.json
This was made in an effort to support the community and possibly the npm work with a TSA, but it's not used outside of GitHub to my knowledge.
The certificate for GitHub's TSA have now been rotated, and the rotation frequency is currently every 6 months (yes this is frequent!). This will pose a challenge for sigstore root signing to keep up.
I'm thinking if we should remove the TSA from trusted_root.json?
cc @trevrosen @bobcallaway @haydentherapper

I’m unaware of anyone using it as well.

@jku fyi related to what we were chatting about, we can remove this as part of the next rotation

Test in staging ongoing in https://github.com/sigstore/root-signing-staging/issues/157


Nested Lists not handled

Is it something I am doing wring, or are nested lists not handled correctly?
import delta
d = delta.Delta(ops=[
{"insert":"This is a test\nThis is another"},
{"attributes":{"list":"bullet"},"insert":"\n"},
{"insert":"test"},
{"attributes":{"indent":1,"list":"bullet"},"insert":"\n"},
{"insert":"that is quite different"},
{"attributes":{"indent":1,"list":"bullet"},"insert":"\n"},
{"insert":"And this is back at level 1"},
{"attributes":{"list":"bullet"},"insert":"\n"},
])
delta.html.render(d)
'This is a testThis is anothertestthat is quite differentAnd this is back at level 1'
I'd expect the indented lists to be wrapped in their own ul tag, but instead a flat list is returned.

Definitely an issue, will have a fix as soon as I can. Thanks!

Are you still on this @DeadWisdom?
I am trying to evaluate if I change my frontend to send deltas instead of hml to my python backend. However I am hesitant to do so if this parser/renderer is not really reliable.
You have every right to do as little or as much as you please. ;)
I'm just trying to get an idea if you are aiming to actively still support this library.
What do you say? 🤔

Ping? :)

Man, sorry I did not have notifications turned on here. @Eraldo -- it is fixed now. Sorry if it's so late. Feel free to hit me up on twitter @DeadWisdom in the future.


[YUNIKORN-2808] E2E test Verify_preemption_on_priority_queue test is flaky

What is this PR for?
E2E test Verify_preemption_on_priority_queue test is flaky
What type of PR is it?

[ ] - Bug Fix

Todos

[ ] - Task

What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Preemption use single node for all these tests for simplicity. Failures happened only in Verify_preemption_on_priority_queue test. In this test, app submitted in low-priority queue has entered into reservation flow instead of going through preemption flow and eventually rejected because of its lower priority, followed by app waiting in high-priority queue not being able to complete the preemption because of node reserved  by app submitted in low-priority queue. This specific situation doesn't happen always in all runs. Now, modified a test a bit to trigger the preemption while the headroom checks itself for both the apps so that high priority app is able to get resources through preemption whereas low priority app is not able to.


A prime sieve

I've been having fun with prime sieves the last couple of days—perhaps I should add one to this project. I think I'll want a list of primes for testing if nothing else. As it turns out, you can generate primes up to a billion in 3.6 seconds on a MacBook Pro (13-inch, M1, 2020) with only 20 lines of code. Who'd a thunk it?
Edit: 2.2s from 3.6s by using [UInt] as a wannabe-bit-set.
Edit: 1.7s from 2.2s by wheeling 3, 5, 7 (the 2s took it from 7._s to 3.6s).
Edit: 1.5s from 1.7s by using wrapping arithmetic in hotspot.
Edit: 0.9s from 1.5s by chunking it (I haven't reimplemented wheeling yet).
Edit: 0.8s from 0.9s by reimplementing wheeling in increment().

That includes parameterization from 0 through UInt.max and proper overflow checking.

[!NOTE]
UInt.max is about 4 billion on a 32-bit platform.

I kind of want to add a first-one-million-primes.txt for testing, but that's 9.2MB of 23.5MB. Hm.

I added an enum option for generating the first 1 thousand or 1 million primes.

Segmentation and wheel factorization might take it below 1s, in case I care to optimize it.

Using [UInt] as a wannabe bit set is 60% faster for most sizes. Suppose I can do that.

Hm. Wheel factorizing multiples of 2, 3, 5, 7 takes it to 1.8s from 2.2s. Underwhelming.

Some 3, 5, 7 finessing gets it to 1.6s. Seems I'll have to segment it to get it under 1.0s.

Hm. Wrapping arithmetic in the hottest loop takes it to 1.5s.

That moment when your scrappy naive-but-segmented-15-min-draft runs in 1.1s :neutral_face:

Wheeling in segments is ...not elegant.

Adding 11 to the wheel takes the current solution to 1.4s from 1.5s. 13 makes it slower, however.

Hm. It might be better and simpler to always page in some increment dividing 2 ^ UInt.bitWidth.

So I notice while reworking the sieve that pagination removes the need for the PrimeCountLimit enum. It's more flexible than that. Instead of using a build-time constant, you can instead do something like:
public init(first count: UInt) {
    var cache: Cache; (self, cache) = Self.makeInitialState()
    while self.elements.last! < count {
        self.increment(using:  &cache)
    }
}

Hm. Since adding 11 to the pre-cull makes it faster, I thought of something. The 3 * 5 * 7 pattern needs 105 elements. The 3 * 5 * 7 * 11 pattern needs 1155 elements. I could chunk it up to 31 with only 829 elements, however, as follows 3 * 31 + 5 * 29 + 7 * 23 + 11 * 19 + 13 * 17. This culls 10 primes in 5 loops instead of 4 primes in 1 loop, so it's 5 primes for free instead of 3. It's not asymptotically faster, but it's perhaps worth trying.

Hm. I wonder if it's possible to just keeping going though 2 * 3 * 5 * 7 * ... if it's done lazily.

Also, on segmented wheeling: it seems pointless for primes that does not occur more than once per segment, because x + x and x + >x both exit the segment. Parhaps, that's a reason to keep a multiples array? Dunno.

Hm. I should perhaps keep a pure Sieve of Eratosthenes around because of how simple it is. It could be used for tiny lists, and to double-check the wheeling, segmenting, bit-fiddling, silly version.

I suppose another advantage of storing multiples is that they are always on the wheel, so you skip the headache of finding a suitable value on the wheel. I might try it, although I think it will run into the same memory problem that the unsegmented version did.

Hm. I'm a bit underwhelmed by the multiples array. But I'll keep at it. I suspect some kind of wheel map would be better.

Also, these fancy tricks don't reduce the asymptotic complexity. So maybe I'll opt for something a bit simpler.

Underwhelming is an understatement. But it works! Maybe I'll try doing something lazy, rather than storing multiples in a huge array.

Broke the 0.8s barrier when I removed the multiples array.
Test Case '-[NBKCoreKitBenchmarks.NBKPrimeSieveBenchmarks testNoLoop1E9]' passed (0.788 seconds).

I don't want to repeat options in multiple initializers, so perhaps:
let primes = NBKPrimeSieve(size: .kB(128)).sieve(first: 1_000_000).elements // at least 1,000,000

let sieve  = NBKPrimeSieve(size: .kB(128))

while sieve.elements.count < 1_000_000 {
    sieve.increment()
}

let primes = sieve.elements // at least 1,000,000

Alternatively, I could try to pick an appropriate size based on the initializer method's arguments.

Hm. If I want to be intelligent about it, then perhaps methods like increment(through:) don't make sense because the intent comes after the sieve is configured. So, perhaps I want this instead:
static func primes(first   count:  Int) -> ArraySlice<UInt>
static func primes(through limit: UInt) -> ArraySlice<UInt>

I could then, for example, use a 1:1 Sieve of Eratosthenes for < 1000 primes and never instantiate the segmented model. The above methods could also slice the collection to match the request.

I suppose the cache size does not need to be a multiple of two. It is only a requirement if you want the last possible page to include UInt.max. I still think it should be a multiple of UInt.bitWidth, however. It's not a hard constraint, but that makes it simpler. I could do something vague-but-flexible like having init(clamping: .increment(1000)) translate to a 480-bit cache with a stride of 2 * 480 == 960.

Hm. I don't think I can write a sensible convenience method without CPU info, so I'll drop that idea. Keep it simple.

Chunking the small primes 3 ... 67 takes it below 0.7s:
Test Case '-[NBKCoreKitBenchmarks.NBKPrimeSieveBenchmarks testLimit1E9]' passed (0.679 seconds).

Perhaps I should add a prime counting method to see how much time is spent managing the 3.2-billion-bit array.

If you can predict the number of elements in advance, then reserveCapacity(_:) is a better growth strategy:
Test Case '-[NBKCoreKitBenchmarks.NBKPrimeSieveBenchmarks testLimit1E9]' passed (0.580 seconds).

I suppose the minimum capacity should be set in the initializer and not in a method. The reason being the setup step appends some sequence of initial primes, like 80k of them depending on cache size. It would a bit silly to immediately ask the array to move them somewhere else when you could reserve enough elements before setup.

Hm. The x31 pre-cull limit was apparently based on bounds checking. With some unchecked buffer pointer action, the pre-cull primes 3 ... 67 take the benchmark to 0.52 from 5.8 seconds.


Undercompilation of macro-code (mainargs)

Problem
When using the macro-based CLI library mainargs, I noticed an undercompilation issue
When changing the @doc annotation of one argument in foo.Config, a recompile results in only on recompiled file Config.scala.

The expectation is, that also ConfigParser.scala gets recompiled. This does not happen. This results in an outdate/stale help message.
Info to reproduce

This reproducer uses the following versions:

Mill 0.10.11
Zinc 1.8.0
Scala 2.13.10
mainargs 0.3.0

The reproducer: https://github.com/lefou/mainargs-undercompilation-reproduction

Steps to reproduce

Compile and run reproduction project

$ mill clean
[1/1] clean
$ mill foo.run --help
[33/46] foo.compile
Compiling compiler interface...
[info] compiling 2 Scala sources to /tmp/mainargs-repro/out/foo/compile.dest/classes ...
[info] done compiling
[46/46] foo.run
apply
  --help  Print this help message.

Change the contents of the @doc annotation

$ sed -i "s/Print this help message/Print another message/" foo/src/Config.scala

Re-run the reproduction build and notice, that only one source file gets recompiled and the --help output has not changed.

$ mill foo.run --help
[33/46] foo.compile
[info] compiling 1 Scala source to /tmp/mainargs-repro/out/foo/compile.dest/classes ...
[info] done compiling
[46/46] foo.run
apply
  --help  Print this help message.

expectation
The compiler should also recompile the file which depends on Config.scala.

Here is the reproduction with mill --debug:
$ mill clean
[1/1] clean
$ mill --debug foo.run --help
Using explicit system properties: Map(mill.main.cli -> /home/lefou/bin/mill)
[33/46] foo.compile
Compiling compiler interface...
[debug] [zinc] IncrementalCompile -----------
[debug] IncrementalCompile.incrementalCompile
[debug] previous = Stamps for: 0 products, 0 sources, 0 libraries
[debug] current source = Set(/tmp/mainargs-repro/foo/src/Config.scala, /tmp/mainargs-repro/foo/src/ConfigParser.scala)
[debug] > initialChanges = InitialChanges(Changes(added = Set(/tmp/mainargs-repro/foo/src/ConfigParser.scala, /tmp/mainargs-repro/foo/src/Config.scala), removed = Set(), changed = Set(), unmodified = ...),Set(),Set(),API Changes: Set())
[debug] Full compilation, no sources in previous analysis.
[debug] all 2 sources are invalidated
[debug] Initial set of included nodes:
[debug] Recompiling all sources: number of invalidated sources > 50.0 percent of all sources
[debug] compilation cycle 1
[info] compiling 2 Scala sources to /tmp/mainargs-repro/out/foo/compile.dest/classes ...
[debug] Returning already retrieved and compiled bridge: /tmp/mainargs-repro/out/mill/scalalib/ZincWorkerModule/worker.dest/zinc-1.8.0/2.13.10/compiled.
[debug] [zinc] Running cached compiler 66d9c507 for Scala compiler version 2.13.10
[debug] [zinc] The Scala compiler is invoked with:
[debug]         -bootclasspath
[debug]         /home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar
[debug]         -classpath
[debug]         /tmp/mainargs-repro/foo/resources:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/mainargs_2.13/0.3.0/mainargs_2.13-0.3.0.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.13/2.8.1/scala-collection-compat_2.13-2.8.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/pprint_2.13/0.7.3/pprint_2.13-0.7.3.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/fansi_2.13/0.3.1/fansi_2.13-0.3.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/sourcecode_2.13/0.2.8/sourcecode_2.13-0.2.8.jar:/tmp/mainargs-repro/out/foo/compile.dest/classes
[debug] Scala compilation took 3.232703598 s
[info] done compiling
[46/46] foo.run
Run subprocess with args: '/opt/openjdk-bin-11.0.18_p10/bin/java' '-cp' '/tmp/mainargs-repro/foo/resources:/tmp/mainargs-repro/out/foo/compile.dest/classes:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/mainargs_2.13/0.3.0/mainargs_2.13-0.3.0.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.13/2.8.1/scala-collection-compat_2.13-2.8.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/pprint_2.13/0.7.3/pprint_2.13-0.7.3.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/fansi_2.13/0.3.1/fansi_2.13-0.3.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/sourcecode_2.13/0.2.8/sourcecode_2.13-0.2.8.jar' 'foo.ConfigParser' '--help'
apply
  --help  Print this help message.

$ sed -i "s/Print this help message/Print another message/" foo/src/Config.scala
$ mill --debug foo.run --help
Using explicit system properties: Map(mill.main.cli -> /home/lefou/bin/mill)
[33/46] foo.compile
[debug] [zinc] IncrementalCompile -----------
[debug] IncrementalCompile.incrementalCompile
[debug] previous = Stamps for: 4 products, 2 sources, 2 libraries
[debug] current source = Set(/tmp/mainargs-repro/foo/src/Config.scala, /tmp/mainargs-repro/foo/src/ConfigParser.scala)
[debug] > initialChanges = InitialChanges(Changes(added = Set(), removed = Set(), changed = Set(/tmp/mainargs-repro/foo/src/Config.scala), unmodified = ...),Set(),Set(),API Changes: Set())
[debug]
[debug] Initial source changes:
[debug]         removed: Set()
[debug]         added: Set()
[debug]         modified: Set(/tmp/mainargs-repro/foo/src/Config.scala)
[debug] Invalidated products: Set()
[debug] External API changes: API Changes: Set()
[debug] Modified binary dependencies: Set()
[debug] Initial directly invalidated classes: Set(foo.Config)
[debug] Sources indirectly invalidated by:
[debug]         product: Set()
[debug]         binary dep: Set()
[debug]         external source: Set()
[debug] All initially invalidated classes: Set(foo.Config)
[debug] All initially invalidated sources:Set(/tmp/mainargs-repro/foo/src/Config.scala)
[debug] Initial set of included nodes: foo.Config
[debug] compilation cycle 1
[info] compiling 1 Scala source to /tmp/mainargs-repro/out/foo/compile.dest/classes ...
[debug] Returning already retrieved and compiled bridge: /tmp/mainargs-repro/out/mill/scalalib/ZincWorkerModule/worker.dest/zinc-1.8.0/2.13.10/compiled.
[debug] [zinc] Running cached compiler 3341fd40 for Scala compiler version 2.13.10
[debug] [zinc] The Scala compiler is invoked with:
[debug]         -bootclasspath
[debug]         /home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar
[debug]         -classpath
[debug]         /tmp/mainargs-repro/foo/resources:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/mainargs_2.13/0.3.0/mainargs_2.13-0.3.0.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.13/2.8.1/scala-collection-compat_2.13-2.8.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/pprint_2.13/0.7.3/pprint_2.13-0.7.3.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/fansi_2.13/0.3.1/fansi_2.13-0.3.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/sourcecode_2.13/0.2.8/sourcecode_2.13-0.2.8.jar:/tmp/mainargs-repro/out/foo/compile.dest/classes
[debug] New invalidations:
[debug] Initial set of included nodes:
[debug] Previously invalidated, but (transitively) depend on new invalidations:
[debug] Final step, transitive dependencies:
[debug]         Set()
[debug] No classes were invalidated.
[debug] Scala compilation took 0.411515453 s
[info] done compiling
[46/46] foo.run
Run subprocess with args: '/opt/openjdk-bin-11.0.18_p10/bin/java' '-cp' '/tmp/mainargs-repro/foo/resources:/tmp/mainargs-repro/out/foo/compile.dest/classes:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/mainargs_2.13/0.3.0/mainargs_2.13-0.3.0.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.13/2.8.1/scala-collection-compat_2.13-2.8.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/pprint_2.13/0.7.3/pprint_2.13-0.7.3.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/fansi_2.13/0.3.1/fansi_2.13-0.3.1.jar:/home/lefou/.cache/coursier/v1/https/repo1.maven.org/maven2/com/lihaoyi/sourcecode_2.13/0.2.8/sourcecode_2.13-0.2.8.jar' 'foo.ConfigParser' '--help'
apply
  --help  Print this help message.

For the record, here's the reverse analysis of what might be happening from the Zinc PR https://github.com/sbt/zinc/pull/1316 by @Friendseeker. At https://github.com/lefou/mainargs-undercompilation-reproduction/blob/f1ee0417cab74d721063668ea5247f044870f958/foo/src/ConfigParser.scala#L7C3-L7C90
  private[this] lazy val parser: ParserForClass[Config] = mainargs.ParserForClass[Config]

as reported by OP.
https://github.com/com-lihaoyi/mainargs/blob/e1c8e25b93d1f652465dabd308aa268cb6e23696/mainargs/src/Parser.scala#L264
object ParserForClass extends ParserForClassCompanionVersionSpecific

and for Scala 2, ParserForClassCompanionVersionSpecific would be:
private[mainargs] trait ParserForClassCompanionVersionSpecific {
  def apply[T]: ParserForClass[T] = macro Macros.parserForClass[T]
}

Macros.parserForClass[T]
The macro code looks like this https://github.com/com-lihaoyi/mainargs/blob/e1c8e25b93d1f652465dabd308aa268cb6e23696/mainargs/src-2/Macros.scala#L24-L44
  def parserForClass[T: c.WeakTypeTag]: c.Tree = {

    val cls = weakTypeOf[T].typeSymbol.asClass
    val companionObj = weakTypeOf[T].typeSymbol.companion
    val constructor = cls.primaryConstructor.asMethod
    val route = extractMethod(
      TermName("apply"),
      constructor.paramLists.flatten,
      constructor.pos,
      cls.annotations.find(_.tpe =:= typeOf[main]),
      companionObj.typeSignature,
      weakTypeOf[T]
    )

    q"""
      new _root_.mainargs.ParserForClass(
        $route.asInstanceOf[_root_.mainargs.MainData[${weakTypeOf[T]}, Any]],
        () => $companionObj
      )
    """
  }

so in here, the ParserForClass.apply[Config] macro reads the parameter list of Config, and supposedly that's where it reads the annotation for the parameter list.
If we treat ParserForClass.apply[Config] as a simple function call, Zinc's current behavior of not invalidating the parser makes sense since the change of annotation does not change the binary API of the Config class, and Zinc invalidates the caller only if the signature change affects the inheritance of method calls.
expanding the scope of invalidation
If we treat ParserForClass.apply[Config] as an meta-programmed tree, even without knowing anything about its implementation, it does make sense to invalidate the entire compilation unit containing the macro application because its input (in this case Config) changed.
I think that's what https://github.com/sbt/zinc/pull/1316 does.


DEV-485 apply Lombok to authentication service

SonarQube analysis reported 5 issues

 5 minor

Watch the comments in this conversation to review them.
3 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AuthenticationService.java#L6: Annotate the "AuthenticationService" interface with the @FunctionalInterface annotation
 AuthenticationService.java#L8: Document this public method.
 CredentialsService.java#L14: Document this public method.

Coverage remained the same at 84.329% when pulling ada5a0470cefd07d966739b63af975fcf14af8af on DEV-485 into 6409fa0d9550cde3b7d57854152f9d6100946483 on master.


Question about tags or versioning

Does this project use semver for versioning?
If it does, why is there a version v0.2.16 after v0.3.0?

Does v0.2.16 contains patches for v0.2.15 which is not compatible with v0.3.0? But why?
Aren't version zero (v0.x.x) suppose to be unstable by design...?
why v0.2.16 and not v0.3.1 or v0.4.0?

it's crazy


Move thread spawning 'publish active errors' into ready function

Describe your changes
Move thread spawning 'publish active errors' into ready function
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

TODO:

[ ] https://github.com/actions/runner-images/issues/9692


generate email addresses

Feature description
We can generate dozens data types, but emails is still not possible

@leassis, thanks for giving the library a try. Haven you considered using a custom generator to generate emails?
Generator<String> emailGenerator = random -><EMAIL_ADDRESS>random.lowerCaseAlphabetic(10));

Person person = Instancio.of(Person.class)
        .supply(field(Person::getEmail), emailGenerator)
        .create();

Let me know if this solves your use case.
In general, Instancio doesn't support generating realistic test data out of the box. Instead it supports custom generators that can be reused within a project. This is because there are already some great faker libraries out there, for example:

https://github.com/datafaker-net/datafaker
https://github.com/nomemory/mockneat


Fix packages version pin for Debian, fix CI badge

Description
Fix packages version pin for Debian, more info in #220 issue.
Issues Resolved
Fixes #220, #221
Check List

[x] All tests pass. See https://github.com/sous-chefs/apache2/blob/master/TESTING.md
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable (not applicable)

P.S. Also it would be nice to update cookbook in the Supermarket. There is only the 1.2.0 version.

          1 Warning

:warning:
This Pull Request is probably missing tests.

  Generated by :no_entry_sign: Danger

CI fails with error definitely not related to my changes. Could you please review why?
$ chef exec delivery local all
Chef Delivery
Running Every Stage
Running Lint Phase
/opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/rubocop-0.62.0/lib/rubocop/target_finder.rb:103: warning: Insecure world writable dir /usr/local/bundle in PATH, mode 042777
Inspecting 48 files

ok, well the rubocop build warning is fixed in #223, but there's a whole lot of these errors in the next phase:
Recipe Compile Error in /tmp/d20190304-163-1huem31/cookbooks/sc-mongodb/recipes/default.rb
================================================================================

NoMethodError
-------------
undefined method `params' for nil:NilClass

Cookbook Trace:
---------------
  /tmp/d20190304-163-1huem31/cookbooks/sc-mongodb/recipes/default.rb:33:in `from_file'

Relevant File Content:
----------------------
/tmp/d20190304-163-1huem31/cookbooks/sc-mongodb/recipes/default.rb:

 26:  # allow mongodb_instance to run if recipe isn't included
 27:  allow_mongodb_instance_run = true
 28:  conflicting_recipes = %w(sc-mongodb::replicaset sc-mongodb::shard sc-mongodb::configserver sc-mongodb::mongos sc-mongodb::mms_agent)
 29:  conflicting_recipes.each do |recipe|
 30:    allow_mongodb_instance_run &&= false if node.run_context.loaded_recipe?(recipe)
 31:  end
 32:
 33>> mongodb_instance node['mongodb']['instance_name']['mongod'] do
 34:    mongodb_type 'mongod'
 35:    only_if { allow_mongodb_instance_run }
 36:  end
 37:

Details live in https://circleci.com/gh/sous-chefs/mongodb/88
Is this cookbook running correctly on your systems?

Yes, we use it for simple one node setup on Ubuntu and Debian systems.
And the only thing that was annoying me is that packages were installed with different versions.

to any other reviewers, diff is cleaner without whitespace: https://github.com/sous-chefs/mongodb/pull/222/files?w=1

👍 LGTM


Doesn't work in Debian 11 (missing libappindicator3-dev)

Specific Demand
I want to make dioxus desktop apps in Debian 11 but currently even simple examples fail to build with libappindicator3 library not found! error.
Implement Suggestion
Looks like Debian 11 is using libayatana-appindicator instead.
I don't know what needs to be changed to use this in dioxus.

Looks like crate tao has feature ayatana for this (dependency chain is dioxus > dioxus-desktop > wry > tao) but just adding this to Cargo.toml doesn't work for some reason:
[dependencies]
dioxus = { version = "0.1.8", features = [ "desktop" ] }
tao = { version = "0.5.2", features = [ "ayatana" ] }

This is related to tauri I believe: https://github.com/tauri-apps/tauri/issues/2647
Still pending though.

If you modify Dioxus desktop Tao dependency to use the tayana feature, can you get a compile working? They recently added a new feature to tao that doesn't use libappindicator.

But dioxus-desktop depends on wry which depends on tao - there is no tao dependency in dioxus-desktop.

On the most recent version of wry, there is a feature flag for "ayatana". Can you try enabling that and see if things work?

I believe ayatana is a feature on 0.5.2 tao? It seems it just hasn't propagated into wry yet :(

Cloning this repository and changing wry dependency in packages/desktop/Cargo.tomlto following makes examples compile:
wry = { git = "https://github.com/tauri-apps/wry", branch = "next", features = [ "ayatana" ] }

This didn't work for me. Looks like wry removed webview::RpcRequest,  with_rpc_handler and other rpc functionality. (See https://github.com/tauri-apps/wry/commit/c2c26b028278c333ce0408327a5bde6062eb26d1)
I didn't quite understand how the new with_ipc_handler function could used in https://github.com/DioxusLabs/dioxus/blob/master/packages/desktop/src/lib.rs so I just forked wry and reverted the rpc refactor commit.
I can now compile the examples by changing the  changing wry dependency in packages/desktop/Cargo.toml to following:
wry = { git = "https://github.com/Nykseli/wry", branch = "dev", features = [ "ayatana" ] }

Whenever wry releases their new version we'll updated it to include ayatana.
If anyone else is trying to build dioxus desktop on Deb 11 and runs into this issue, patch your wry version manually:
[patch.crates-io]
wry = { git = "https://github.com/Nykseli/wry", branch = "dev", features = [ "ayatana" ] }

PR up that upgrades wry to the recent version that supports ayatana. LMK if it works for you, and if there's any suggestions on how to best expose it to config flags at the top of our repo.

I don't completely understand how features interact, but wouldn't you need to somehow enable ayatana at top level?
i.e. instead of this (from the PR):
dioxus = { version = "*", features = [ "desktop" ] }
dioxus-desktop = { version = "*", features = [ "ayatana" ] }

wouldn't this require something like this instead since dioxus depends on dioxus-desktop
dioxus = { version = "*", features = [ "desktop-ayatana" ] }

I'll see if I can somehow test the PR, but I don't really know how to set that up.

Can you see if it's possible to simplify your dependency declaration for Dioxus using nested feature flags and not manually roping in dioxus-desktop?
dioxus = {  git = "https://github.com/DioxusLabs/dioxus", branch = "jk/wry-upgrade", features = [ "desktop", "dioxus-desktop/ayatana" ] }

That fails with following error:
error: failed to parse manifest at `/path/to/Cargo.toml`

Caused by:
  feature `dioxus-desktop/ayatana` in dependency `dioxus` is not allowed to contain slashes
  If you want to enable features of a transitive dependency, the direct dependency needs to re-export those features from the `[features]` table.

This is now fixed in master through the ayatana feature flag if you manually bring in dioxus-desktop.


Update Linux support statement Style

Update the Linux support statement to be in a info box style for a better visibility

@Ahmad-Al-Ali : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This request can be closed as OBE.  We have GA'd the Linux VNet Integration feature and that comment no longer applies.

@ktoliver
Hi Kristine, forgot to address this to you.

@ccompy Thanks :)


Update project directories

Move Flask into /server, static files in /assets. The original asset paths are maintained with a symlink, as an intermediate step, so Flask-Assets can still be used to compile.

@mbucknell I agree with your points here, and have addressed them in the next PR, I'll request your review on shortly.


Updated syntax

Original:

Updated:

Vue template will not compile if we will use the Orginal syntax that is mentioned in the doc, in order to apply classes and template to be compiled it should be replaced by Updated syntax

Hey @phanan can you please review this :).

The original code implied there are activeClass and errorClass properties in the component instance, just like isActive.

@Justineo That's fine 👍

Like @Justineo explained above, I don't think we need to change in this case. Looking forward to your next contributions ;)


[FLINK-25926][Connectors][JDBC] Update org.postgresql:postgresql to 42.3.3

What is the purpose of the change

Update PostgreSQL to the latest available version to address CVE-2022-21724 and GHSA-673j-qm5f-xpv8

Brief change log

Updated POM

Verifying this change
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure

@flinkbot run azure

Hi @MartijnVisser
it seems there are at least 2 changes in pgjdbc which should be adapted to make tests happy...
I have no idea how to propose changes to unchanged files with GitHub.... so I submitted a PR to your fork with such changes https://github.com/MartijnVisser/flink/pull/316
Please have a look once you have time

@snuyanzin Thanks for that, I wasn't able to look into it yet! Let me merge and update the PR

@flinkbot run azure

@MartijnVisser I'm sorry however it seems GitHub does not allow to suggest changes to lines which are not changed within the PR (https://github.com/MartijnVisser/flink/pull/317) ...
Do you mind if I ask you to merge another PR to your branch since I do not have permissions to commit there?
In those changes I addressed feedback from @fapaul

Do you mind if I ask you to merge another PR to your branch since I do not have permissions to commit there?

On it! :)


Problem: CacheWrapWithTrace api is not used

Solution:

remove the api

Description
Closes: #XXXX

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

just not sure if need replace cosmossdk.io/store => ./store

we can do dependees and dependers in different PRs I suppose.


MQTT Human Detection Issue

Hello,
Using Allwinner with Yi Dome X
Firmware Version | 0.2.9
Base Version | <IP_ADDRESS>A_202001211401
Model Suffix | y30qa
Serial Number | BFUS

Despite having configured MQTT and camera settings for Human Detection, and receiving notification in the Yi Home app, I can't see any human detection topic published under the topic I entered at the MQTT configuration page.
I tried many different times and played with settings both in the hack and in the app but no way.
I also have issue with an AllWinner-2 based camera where I sometimes only receive human_stop but never human_start
Any idea?
Thanks

This is a know issue.
Please read this:
https://github.com/roleoroleo/yi-hack-Allwinner-v2/issues/75
and the other related issues.


Not really a bug but a request for insight...

I looked inside the js code but I am lost!
Where does this value "21.5" come from???

Trying to get the dial to look like this...

Thanks!!!

The value with 21.5 is a bug because on the dial I only use .5 or fixed numbers instead of the actual value. I think there was a previous request to have in the center of the dial the value for the target instead of the actual temperature. I will get to configure this at some point to allow to change it from settings.
There is also another issue opened to update the look for the dial ticks to be more like your suggestion.


Resin config generate fails if you have two apps with the same name

Throws ResinAmbiguousApplication errors, whether using the name or the id.

This is now fixed: using the app name will still get an ambiguous application error, since it is indeed ambiguous, but you can use the unambiguous app id (visible in resin apps) instead and that will work reliably.


Alles Okey

Hello!
If you want to add your address to delegation registry, please follow this instructions:
https://docs.novawallet.io/nova-wallet-wiki/opengov/delegate-registry


Some maps are without credits

A few maps have no credit texts:

Endboss ZH v2
Proxy War ZH v1
Battle Between Them ZH v5
Desert Vortex ZH v7
Lethal Mill ZH v1
Persian Gulf Conflict ZH v5

Is not a problem. As designed? Or mistake?

We can only put credits where we know the mapper.

Ok, so I assume these remain unknown? Close this?

yup, we gotta close this


Fix target="blank"

If you use target="_blank"  we are currently just doing a location.assign so under the hood both urls will move. We need to check for that target, and do window.open in that situation.

Generally, it would be good to consider any set of target attributes if possible


icon of adobe indesign file

Description
Icon of indesign file type cannot be shown.
Steps To Reproduce
No response
Expected behavior
wish the adobe indesign file type icon can show correctly, thanks!
Files Version
<IP_ADDRESS>
Windows Version
win10 21H1 19043.1466
Relevant Assets/Logs
Right hand side is the preview of Files, left hand side is the indesign icon in win10 file explorer.

Merging with #2582


EmrEtlRunner: add warning about the array of in buckets in config.yml

The users seem to ignore YAML style of an array item, "-" symbol in config.yml. That generate a significant amount of questions in Google group. I think we need to indicate the significance of the symbol even if only one item is to be added. That could be done both in config.yml as a comment as well as in corresponding wiki page.

Improved title


Update meta.yaml

add runtime dependence on virtual __cuda package to avoid that cuda variant gets installed on non-cuda systems

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


HMR css/scss variables

Hey,
First of all thanks for the great setup.
I'm having issues with HMR and changing the scss variables.
For example changing the $color-primary, the change doesn't affect the component in storybook. Even reloading doesn't help and only after restarting the storybook/stencil combo the change is visible. I did also try this with CSS variables in _variables.scss file (did not work) or in init.scss (showed up in component after refresh). So my guess is it has something to do with the sass plugin and injectGlobalPaths.
I did try to follow how it all works but couldn't figure it out past where Stencil Dev Server Connector 2.0.3 gets injected into the storybook html.
Any idea how to get HRM working for CSS/SCSS variables?
Cheers

Hi Harles,
this same issue we have aswell, stencil recognize the changes but didnt reloaded it.
The only thing which works is to stop and start the storybook at the moment.
cheers


Make codespell an official linter

Make codespell implicit (required) in order to pass reviews.
Errors found by codespell will need to be fixed for PRs to be merged if this is agreed to.
About codespell:
Fix common misspellings in text files. It's designed primarily for checking misspelled words in source code, but it can be used with other files as well. It does not check for word membership in a complete dictionary, but instead looks for a set of common misspellings. Therefore it should catch errors like "adn", but it will not catch "adnasdfasdf". This also means it shouldn't generate false-positives when you use a niche term it doesn't know about.
Our configuration for it is here, it will be run by the precommit hook:
https://github.com/ansible/ansible-navigator/blob/main/.pre-commit-config.yaml#L150
This change is does close a range of preparatory changes that repaired problems identified by code-spell:

#728
#718
#710
#707
#690

Please do not gate this change until the entire team approves it.

recheck

For the record, I am terrible at spelling and seeing my own errors.
In this case, I'm a 0 and will approve the PR but leave it up to the team to make the decision.


[BUG]: Admin | Sync Template v2 (UI Flow Runs) - environment not found

Describe the bug
This environment was a trial environment and it got deleted after 30 days and not sure why the UI Flow Runs is looking for a deleted environment? When I go to the Environment entity and look for the trail environment the status says active, and the status reason also says active. I am guessing that once that environment is deleted it should mark as a deleted not active.
CRM organization with unique name 'org28743a32' not found.
Component (please tell us which flow or app you are experiencing issues with):

Solution - Core
Version - 1.70
Flow - Sync Template (v2) UI Flow Runs

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
it should not look for a deleted environment.
Screenshots

Additional context
Add any other context about the problem here.

Hi there. Thanks for letting us know. I repro and am investigating.

Thank you

We have just released the fix in CenterofExcellenceCoreComponents_1_70_1_managed
Thanks for helping make CoE great!


dse-graph-frame

Hi,
When I try to execute the sbt packge build, am getting the following error
[error] Unable to find credentials for [Artifactory Realm @ repo.datastax.com].
Looks like its not able to connect to the datastax artifactory repos to download the dependencies.
Am currently on sbt 0.13.11
Thanks!

Upgrade to SBT worked !

Which version of Sbt worked for this.