Generated TypeAdapters using Reflection

The TypeAdapterFactories generated by auto-value-gson are using reflection, which is inefficient on Android.  Since Android apps usually need to register type adapter factories at application start up this causes a significant delay in app start up.
For example for List<String> the following is generated in the TypeAdapterFactories constructor:
stringAdapter = gson.getAdapter(new TypeToken<List<String>(){})
Inside the default TypeToken constructor is where the reflection happens:
this.type = getSuperclassTypeParameter(getClass());
A better way would be to create an instance of java.lang.reflect.ParameterizedType and pass it into gson.getAdapter().  Unfortunately the only implementations of  java.lang.reflect.ParameterizedType are either in Guava or are in internal packages in Gson.  In Gson you can create one by calling com.google.gson.internal.$Gson$Types#newParameterizedTypeWithOwner(null, List.class, String.class).  Again this is an internal class so probably don't want to rely on it.
The only other solution would be to create an implementation of ParameterizedType and use it.  This would have to be a compile time dependency of the client library or application.
Here is a hacky method I created that would use the com.google.gson.internal.$Gson$Types#newParameterizedTypeWithOwner(null, List.class, String.class) solution.  Unfortunately it doesn't handle more complicated scenarios where the  ParameterizedType includes another ParameterizedType like List<Set<String>> or Map<String, Set<String>>
private CodeBlock getParameterizedTypeConstructorStatement(ParameterizedTypeName type, FieldSpec field, ParameterSpec gsonParam) {
    CodeBlock.Builder block = CodeBlock.builder();
    try {
      int typeArgsSize = type.typeArguments.size();
      int argsIndex = 0;
      Object[] args = new Object[5 + (typeArgsSize)];
      args[argsIndex++] = field;
      args[argsIndex++] = type;
      args[argsIndex++] = gsonParam;
      args[argsIndex++] = ClassName.get($Gson$Types.class);
      args[argsIndex++] = type.rawType;
      String[] genericTypesFormatWithClass = new String[typeArgsSize];
      for (int i = 0; i < typeArgsSize; i++) {
        args[argsIndex++] = type.typeArguments.get(i);
        genericTypesFormatWithClass[i] = "$T.class";
      }
      StringBuilder blockString = new StringBuilder("this.$N = (TypeAdapter<$T>) $N.getAdapter(TypeToken.get($T.newParameterizedTypeWithOwner(null,$T.class,");
      Joiner.on(",").appendTo(blockString, genericTypesFormatWithClass);
      blockString.append(")))");
      block.addStatement(blockString.toString(), args);
    }catch (Exception e){
      //Fall back on using reflection
      block.addStatement("this.$N = $N.getAdapter(new TypeToken<$T>(){})", field,gsonParam, type);
    }

Since Android apps usually need to register type adapter factories at application start up this causes a significant delay in app start up.

You do not need to register on startup. Registration should be one when the Gson instance is created which should be deferred to first use (and thus happen on a background thread).
I would argue that's the bug here, not necessarily the use of reflection.

Thanks for the feedback,  I have switched my application to lazily create gson on first use in a background thread.


Update README.md

The PR looks good. But...
AVAudioSession is not available in macOS. So that needs a different solution.

do you have any intuition on the lag the start when app boots up? i hit the button - and it can take 7 seconds to 30 seconds to proceed - but at this point things are faster - i'm on iphone pro 12. i added timers - but it seems like the javascript core is like doing some thing? im only using the basic story script. i attempt to break in and debug - but its not possible to achieve robost performance.

hmmm. I don't have an explanation about the startup delay. I'll have a look and see what instruments tells me.

I just did a test using Instruments on my iPhone SE (2020). Not a powerhouse by any means. It takes about a second to launch.
I do notice a substantial lag in the macOS version. And when I click the first button 'too soon', it crashes the app. It's as if the audio system is not yet ready. So I'm curious, what if you disable all the audio stuff, does that help performance?


Generate .torrent file from Hash

Is any fast method to create a torrent file from hashid?
I found a way to do with monotorrent is to start an torrent engine and add a torrent manager from hashid and wait for it to download, then stop manager and get the .torrent file saved in torrent folder, but it takes a very long time (about > 30s).

Do you know if these torrents are using DHT to find peers to retrieve the .torrent file, or if they can use a normal HTTP or UDP tracker to get a list of peers? Dht will always be a bit slower than trackers.
Apart from that, do you know roughly how long it takes for peer connections to be established?
MetaData downloading is probably slower than it needs to be. I've been contemplating rewriting it to use more or less the same logic as 'EndGameMode'. At the moment the logic to download the metadata is stored in MetaDataMode and is completely custom. I think there's a very good chance it could be rewritten to rely on an EndGamePicker, which could make things a little faster. At the least it might be a little less maintenance.

It's a great way, I think it will be faster than my method because it don't need to create folder, init Torrent Engine and many of unwanted settings

You would still have to create an Engine as downloading the metadata requires a TorrentManager under the hood.
Perhaps a better API would be something like:
BEncodedDictionary torrentMetadata = await ClientEngine.GetMetadataAsync (MagnetLink magnetLink);
In some respects it would be much easier internally if metadata downloading were completely separate to actual torrent downloading. Unfortunately the boat has kind of sailed on that decision :p a simpler API can still be exposed though as it would unlock some nice use cases (like allowing someone to view the files before actually registering the torrent for downloading).

If you need a torrent fast, you could try using https://itorrents.org service. Of course there is no guarantee, that it'll have torrent information, but it works pretty well otherwise.
Usage is straightforward:
                string itorrentsUri = "https://itorrents.org/torrent/" + magnetLink.InfoHash.ToHex() + ".torrent";
                Uri url = new Uri(itorrentsUri);
                await Launcher.LaunchUriAsync(url);

@uponatime2019 Implemented! The best performance will be with MagnetLinks which have trackers. They will return a list of peers very quickly. If you need to rely on Dht it will be a little slower as Dht initialization can take a little bit of time.
Leave your comments on the PR and thanks for the feature request!

I will try it! Thanks for listening


Warn when message rate exceeds limit for RateLimiter

Motivation
Addressing the warning feature from #3255
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

Thanks for the PR, please add appropriate reviewers (myself and @phlip9) for networking, so we get notified :)

Thanks, let me actually convert this PR into a draft first. I'll focus on the task of refactoring the NetworkBuilder, and the come back to this.

I think what we actually want to do here is strip this code out of the code base, I don't think it provides us much protection at all and gives a false sense of security. Feel free to follow up :)


Camera scan view should get explicit attibutes

V1 or V2
allow photo mode
allow move targeting view

Done with camera2 work.


check if kind.kind ends in y, if so remove y and add ies, else is the…

… same
Closes #201 by checking if kind.kind ends in y, if so, removes the y and adds ies. @jeff-mccoy lmk if there is a better place for this function

The way to handle this is with plurals
When(a.GenericKind, {
  group: "source.toolkit.fluxcd.io",
  version: "v1beta2",
  kind: "GitRepository",
  plural: "gitrepositories",
});

Resolved comments in issue #201


How to change used Preset?

It seems like it doesnt apply when written like:
`
[DLSSPresets]
; Overrides the DLSS preset used for each quality level, set to Default to leave the preset set to whatever game/DLSS decided for it
; Or set to A / B / C / D / F to try forcing that preset instead.
; Presets were added in DLSS 3.1, similar to the old method of swapping out different DLSS DLL versions, now instead you can just set a preset for it
; Unfortunately DLSS might override these presets with ones decided by NVIDIA instead
; Enabling OverrideAppId above might help with those (at least it fixes DL2)
; (recommend testing with the dev DLSS DLL along with ngx_driver_onscreenindicator.reg to make sure the preset is being overridden properly)
; Note that some games could have graphical artefacts when certain DLSS presets are overridden onto them
; There's not much DLSSTweaks can do to help with that unfortunately, hopefully trying a different preset could help
DLAA = F
Quality = F
Balanced = F
Performance = F
UltraPerformance = F
`
Do i need to write the preset name in some other fashion?

That should be working afaik, what game are you trying with?
Maybe give the beta build a try if you haven't already: https://github.com/emoose/DLSSTweaks/issues/2

I used with Control. It needed OverrideAppId


#200 Add detailed error message for iOS onError function.

This should improve error logging on js side.

I don't know why @DylanVann is ignoring these PRs, especially this PR is needed, thanks @Romick2005
I used patch-package to use this PR.


Error Loading webview: Simple Browser: Show

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.82.1
OS Version: Linux x64 6.4.14 fedora

Steps to Reproduce:

vite react template npm run dev

  VITE v4.4.9  ready in 988 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help

on command pallet Simple Browser: Show enter url

Error loading webview: Error: Could not register service worker:

InvalidStateError: Failed to register a ServiceWorker:
The document is in an invalid state..

Might be duplicate of #125993

Similar to #192965

in few previous version it was working... I just updated code today in fedora and this thing stopped working

i think it was some how related to the issue i faced recently vs code goes blank
after kill and disable gpu is start working and same for this simple browser i guess
$ killall code
$ code --disable-gpu

Duplicate of #125993


Add Discord channel to docs

There doesn't seem to be a reference to the Discord channel in the readme or other docs. Can we please add a link to the channel so people can find the room?

I can add this in the README, unless it's better to have a larger "getting involved" section in the other docs as well.


fix: rehaul-kubernetes

Added content from previous PR#637
Updated content to make it conversational.

Looks good. just some minor changes. Also in general, let's avoid could, would, should everywhere. I noticed it in a couple of places in the doc.

I have rewritten it. It would need a re-reading.

@sharat87 - Ready for your technical review.

@sharat87 - Fixed the review comments, indentation issues and the doc is ready for final review and approval. We'll need to wait for @pratapaprasanna to confirm before we can merge the PR. right?


Expose OptionSet name, and correctly marshal in FormulaType.Build

Fix #226.
When adding proper option set support, FormulaType.Build wasn't updated to ensure that the internal option set type gets properly converted back to the public FormulaType. This also exposes the name of the option set publicly on the OptionSetValueType, for use in hosts.

Why is this needed?

Refers to: src/libraries/Microsoft.PowerFx.Core/Public/Types/FormulaType.cs:52 in ce92819. [](commit_id = ce92819bcf3a6d26dc44b5a4945ff74a10bb2cc4, deletion_comment = False)


HLS support

This PR adds HLS support to the annotation tool.

From the amount of emails I'm getting about this, I presume you are still working on it? Just let me know when you want it reviewed. :wink:

Hi Julian, the PR is Ready, I was squashing and rebasing the commits. The only doubt I have is with the capital "H" on the "Hls" declaration because is more an aesthetic and convention naming. The package lock, even I tried to left like the develop branch always changes.

No offense but the history does not look very squashed to me. :wink: You could just reabse your changes on the current state of develop and then force-push that here.
If you want, I can do that for you, as well, and I might have to do so tomorrow, since I would like to cut the 2.0 release then, and I would like this feature in there. So if you want to practice git history rewriting, you have until tomorrow afternoon or something like that. :wink:
As for the "H": The convetion in this project is for the module names in the RequireJS configuration and calls to be in kebab-case, so it should be a small h there. The variable can be called Hls, I don't really care.

The package-lock.json issue could happen because I updated Node and NPM. Please ignore that for now and remove that file from this PR.

No offense but the history does not look very squashed to me. 😉 You could just reabse your changes on the current state of develop and then force-push that here.

Yes you have right, I forgot to apply the rebase  😅.

As for the "H": The convetion in this project is for the module names in the RequireJS configuration and calls to be in kebab-case, so it should be a small h there. The variable can be called Hls, I don't really care.

Perfect. All the changes requested are done. Please Re-review.


[Homebrew] Add homebrew downloads badge

I've added a downloads route for homebrew formulae.

I wanted to point out a few things.
As an example, the formula for cake has the following information: https://formulae.brew.sh/api/formula/cake.json
  "analytics": {
    "install": {
      "30d": {
        "cake": 93
      },
      "90d": {
        "cake": 182
      },
      "365d": {
        "cake": 922
      }
    },
    "install_on_request": {
      "30d": {
        "cake": 91
      },
      "90d": {
        "cake": 180
      },
      "365d": {
        "cake": 902
      }
    },
    "build_error": {
      "30d": {
        "cake": 0
      }
    }
  },

The name of the formula is in the key of the object.
const schema = Joi.object({
  analytics: Joi.object({
    install: Joi.object({
      '30d': Joi.object().required(),
      '90d': Joi.object().required(),
      '365d': Joi.object().required(),
    }).required(),
  }).required(),
}).required()

I would have liked to do something like the following:
function schemaGenerator({ formula })
  return Joi.object({
    analytics: Joi.object({
      install: Joi.object({
        '30d': Joi.object({ `${formula}`: nonNegativeInteger }).required(),
        '90d': Joi.object({ `${formula}`: nonNegativeInteger }).required(),
        '365d': Joi.object({ `${formula}`: nonNegativeInteger }).required(),
      }).required(),
    }).required(),
  }).required()
}

...

  async fetch({ formula }) {
    const schema = schemaGenerator({ formula }) // generate schema based on formula
    return this._requestJson({
      schema,
      url: `https://formulae.brew.sh/api/formula/${formula}.json`,
      errorMessages: { 404: 'package not found' },
    })
  }

But I get the following error:
[server]<PHONE_NUMBER> Server is starting up: http://localhost:8080/
[server] /Users/USER/gitrepos/shields/services/homebrew/homebrew-downloads.service.js:13
[server]        '30d': Joi.object({ `${formula}`: nonNegativeInteger }).required(),
[server]                            ^^^
[server]
[server] SyntaxError: Unexpected template string
[server]     at wrapSafe (node:internal/modules/cjs/loader:1018:16)
[server]     at Module._compile (node:internal/modules/cjs/loader:1066:27)
[server]     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
[server]     at Module.load (node:internal/modules/cjs/loader:967:32)
[server]     at Function.Module._load (node:internal/modules/cjs/loader:807:14)
[server]     at Module.require (node:internal/modules/cjs/loader:991:19)
[server]     at require (node:internal/modules/cjs/helpers:92:18)
[server]     at /Users/USER/gitrepos/shields/core/base-service/loader.js:26:20
[server]     at Array.forEach (<anonymous>)
[server]     at loadServiceClasses (/Users/USER/gitrepos/shields/core/base-service/loader.js:25:16)

As such, right now I've implemented with without validating the final depth of the data. If anyone knows how to do this let me know. I looked through the documentation for joi and javascript template strings, and I wasn't able to figure it out.

In the api data, there's downloads available for the last 30 days, 90 days and last 365 days. Based on other download badges for shields.io, I saw that the string /month and /year is used as part of the message. I couldn't think of a appropriate string to add for the label for 90 days, so I left it out for now. I can update the PR based on suggestions for this.

There's install and install_on_request fields in the data. I believe install_on_request is the download numbers when I user asks to install a package. The install download numbers include download analytics for when the package is downloaded as a dependency as well. I think install download numbers will always be greater than or equal to install_on_request download numbers. We can make it a drop down option if required.

I changed the version homebrew badge to have the label version instead of homebrew.

This PR will resolves #6190.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @kdheepak!

  Generated by :no_entry_sign: dangerJS against 38170eb60e25432ca45e3b5e4187e16f6e4678c6

Thanks for having a look at this. I've not read the code, but here's some answers to your questions..

You can use square brackets instead of a template string, which will work:

function getSchema({ formula }) {
  return Joi.object({
    analytics: Joi.object({
      install: Joi.object({
        '30d': Joi.object({ [formula]: nonNegativeInteger }).required(),
        '90d': Joi.object({ [formula]: nonNegativeInteger }).required(),
        '365d': Joi.object({ [formula]: nonNegativeInteger }).required(),
      }).required(),
    }).required(),
  }).required()
}

we normally name functions as verbNoun i.e: doThing() not thingDoer()

I couldn't think of a appropriate string to add for the label for 90 days

I'd probably call it downloads per quarter /dq.

Installs sounds like the metric that is most comparable with our other downloads/installs badges.

We can make it a drop down option if required.

It might be nice to at least give ourselves wiggle room in the route if we want to add it later. How about we make it homebrew/installs/:interval/:formula then if there is a clear case for adding install_on_request we can add the route in a non-confusing way.

Version badges should generally use the name of the package manager as the badge label:

Can you leave this as "homebrew"

I'd probably call it downloads per quarter /dq.

Homebrew doesn't seem to support having quarter in the message:

Thanks for your detailed comments! I've updated the PR based on your comments:

I changed the version service label back to homebrew.

I added a validation based on what you suggested. That worked great!

I changed the route to /homebrew/installs/:interval/:formula.

The only thing that I'm not able to figure out is how to get /quarter in the string of the message.

No worries :) The reason the test fails with quarter is because we've not used it before so the isMetricOverTimePeriod validator doesn't know about it. You can add quarter to the regex https://github.com/badges/shields/blob/1adfbe4f88bd1e0d957ab8006a209692cd668ff6/services/test-validators.js#L75-L77 and I think your tests should pass

Thanks for suggestion! I made the update.

Great first contribution- thanks

Thanks for all the suggestions!

Indeed, well done @kdheepak!

This is a very well organized piece of software and valuable resource to the community, thank you for all the time and effort you've put into it.


[CARBONDATA-3548]add spatial-index user guid to doc

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1224/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1234/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1243/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1639/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/12/

please add a link to tets case

@MarvinLitt : please handle kunal's comment. I want to merge this.

retest this please

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/862/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2570/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/874/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2582/

LGTM


Stabilization: Profile and optimize modifier decoding

One issue with modifier decoding right now is that we have to decode the entire modifier stack each time any modifier changes. One way around this could be doing something like how modclass converts itself to modifiers={...} . We could have modifiers={...} automatically convert to separate attributes for each modifier, modifiers:0={...} modifiers:1={...} ... . Then when a modifier is updated, we only receive a diff for one of them and can decode and update just that one attribute/View.

Entire Slack discussion:
https://dockyard.slack.com/archives/C02E1GA5THB/p1693948697416379
Carson Katri
5:18 PM
One issue with modifier decoding right now is that we have to decode the entire modifier stack each time any modifier changes. One way around this could be doing something like how modclass converts itself to modifiers={...} . We could have modifiers={...} automatically convert to separate attributes for each modifier, modifiers:0={...} modifiers:1={...} ... . Then when a modifier is updated, we only receive a diff for one of them and can decode and update just that one attribute/View. (edited)
May Matyi
5:38 PM
I think we would need the upstream LiveView parser to support transforming attributes at compile time before we could support that. I’m not happy with the current modclass implementation
Carson Katri
5:39 PM
Yeah, I agree
bcardarella
5:45 PM
let's just fork the template engine
5:45
we can do everything we need now then politic on how to return to mainline later
Carson Katri
5:45 PM
Another option would be changing it from modifiers={...} to just {...}, and having the result be a map which LV will already convert into separate attributes for each key.
bcardarella
5:50 PM
that would be atypical for how LV devs are expecting to write markup
May Matyi
5:53 PM
@bcardarella
We were doing that originally but Chris McCord advised against it https://dockyard.slack.com/archives/C02E1GA5THB/p1675289642977919
Chris McCord
@bcardarella
I am not in all the convos, but I would still make your custom engine a last resort
Posted in eng-rnd-liveview-native | Feb 1st | View message
5:53
I feel like we’ve been going around in circles over the past year on this :upside_down_face:
alex.zholtkevych
5:54 PM
FYI will create an issue for that ASAP for tracking
bcardarella
5:54 PM
@May Matyi
I know but we're constantly circling the drain on these things
5:55
Chris has asked for a comprehensive list of what we want, and I keep coming back to him with one-offs because we're surfacing them as we find them (edited)
5:55
I'd rather fork the engine, do everything that we need, then make a proposal on how to merge back


fix locals 'Deleting' to 'Terminating'

Signed-off-by: liuying<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #39
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9e62107). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage          ?   48.33%
=========================================
  Files             ?        6
  Lines             ?      542
  Branches          ?      150
=========================================
  Hits              ?      262
  Misses            ?      219
  Partials          ?       61


Authentication Problems

Hello, since ifttt has kicked me off their supposedly forever legacy plan, I'm trying to get thin working but I get to the point where I need to authenticate and get stuck, I copt the address to my browser, sign into my account, it redirects to http://localhost:3030/authorization_code?code=4/"blah blah code"&scope=https://www.googleapis.com/auth/youtube.readonly and the page says "This site can’t be reached" trying to copy the whole url or parts back into the terminal doesn't seem to do anything. if I press the stop button in docker it then shows "bbyen  | Paste the entire URL of the page you are redirected to (even if you receive 404):" which I assume should have popped up but obviously because  pressed stop it then goes
"bbyen exited with code 0" starting from the beginning. pausing did nothing
am I missing something?

Are you forwarding port 3030 in docker? In order to paste the url you might need to run docker with -it. How are you running docker? What os do you have?

thank you for replying,
"Are you forwarding port 3030 in docker" i don't know what that means haha, I have docker desktop running in w10 with docker itself running in some sort of windows built in linux vm as per the instructions they give via their install guide.
I'm using it in the cmd window for linux that opened after it installed, and I've followed your instructions, the only thing I've done through docker/desktop is look and I can see your app bbyen is running and when it didn't work I tried the stop and pause buttons to see if it would help. sorry this is a bit complicated for me haha, hence why I was paying ifttt.
"you might need to run docker with -it." what does this mean?

Ok, it sounds like you're using docker run from the WSL command line, not docker desktop GUI or docker compose. Is that right? Could you please share your entire docker run command?
About the port:
The reason that when you got to localhost:3030 it says "This site can't be reached" is because the server is only running in the container in a way that's completely isolated from Windows. You have to tell docker to connect the port 3030 on the host to 3030 in the container. You can just add -p 3030:3030 to your docker run command, so docker run -p 3030:3030 ....
About the copy-paste:
Docker by default only prints the output of the process running in the container. If you want the process to also be able to see your keypresses (and what you paste), you should add the -it (--tty and --interactive) flags: docker run -it ....
You should only have to do one or the other. If you send me your docker run command, I can tell you exactly what you need to run.

I just checked the readme. The instructions actually use docker compose. Sorry, it's been a while since I wrote that. Are you using docker compose? sudo docker-compose up


ExampleException in home#example

Test error in Example.com
ExampleException in home#example
Something really bad happened
View on Bugsnag
Stacktrace
app/controllers/home_controller.rb:123 - example
app/controllers/other_controller.rb:12 - broken
lib/important/magic.rb:4 - load_something

View full stacktrace
Created by Max Shenfield via Bugsnag

Test


Contact refactor/rework

Keeping tabs on the Contact representation "issue" internal to the library, see
https://github.com/onsip/SIP.js/issues/791#issuecomment-619389241
for some discussion and links to related issues.
Currently the recommended way to set the Contact for a UserAgent is to use

UserAgentOptions.contactName
UserAgentOptions.contactParams

But if we had a good representation for Contact and fixed the stuff outlined in the #791 comment, we arguably would be better off. So raising this issue as an acknowledgement that we know the way we are dealing with the user agent contact currently is not really where we would like it to be and a reference to what has been considered and some of the known gotchas.

Some work has apparently been done on this front, but still looking to keep tabs on it and do a review.

I will explain my problem here, as I was referred to this issue for here: https://github.com/onsip/SIP.js/issues/1014
The Sip.js code will throw a warning on the OK response from my server when it checks the Contact header if you have specified you own ContactName, and this Contact check fails, however, Asterisk thinks the extension is registered, but sip.js thinks its not. Interestingly, if you send it a call, it still works fine!
Sip.js refuses to recognise that the registration is complete (as Asterisk has sent the OK in response to the Auth Challenge), so the two states are not in agreement with each other.
In my case, the failure was on the following contacts:
Request
Contact: <sip:edgebrowser@<IP_ADDRESS>;transport=WS>;expires=300

200 OK
Contact: <sip:edgebrowser@<IP_ADDRESS>;transport=WS>;expires=299

I'm not sure what it failed the comparison on.

And again, I was referred here from: https://github.com/onsip/SIP.js/issues/1012
My other problem is that if you specify push notification parameters as per the RFC https://www.rfc-editor.org/rfc/rfc8599.html
The pn- parameters in the contact are applied to the UserAgent for Registration (as required by the RFC), but any subsequent request leaks this information, meaning if I issue a SUBSCRIBE, the pn- parameters are also used in the contact, and "leaked" to my subscription server. This is a major problem for me.

@InnovateAsterisk - thanks for the input.


After Effects support

Any plans for an After Effects plugin (or knowledge thereof), would it even be possible? The reason I ask is because it's my go-to for simple compositing and 2.5D animation. Mostly since Nuke is so expensive.
Photoshop support would be rad too for still work, but I'm probably already pushing it with AE. ;)

No current plans to develop that on our part. However this is an open source project and if someone steps up, that'd be fantastic.
If this is something you want, (especially if you'd be willing to pay for it), I would suggest contacting developers of AE and PS plugins and ask for it.


HBASE-24490 Revisit onlineRegions and onlineRegionsLock in HRegionServer

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 27s
Docker mode activated.

I believe here is flakey test failure for jdk11 branch? org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.


Menu contributions with alt command won't trigger

VSCode Version: Version 1.8.0-insider (1.8.0-insider) fb8939b09460ff9fbd40d39056b54c88d5aad9c8
OS Version: macOS Sierra 10.12.1 (16B2555)

Steps to Reproduce:

Using an extension that provides an alt command to a menu, press alt while clicking the menu
The alt command never seems to trigger, just the main command

This currently only works when menu item appear in the editor title, e.g when we render them. When showing them in the native context menu we cannot get the alt-behaviour to work because opening a menu stops the whole JS event loop

Instead of providing alt on click of a menu item -- what if the support was holding alt when opening the menu and then the menu would actually show the alternative options?

@jrieken I've finally gotten around to check this out -- and am loving the new behavior. Although I have noticed that intermittently the alt menu choices "stick" meaning, I open the context menu with alt pressed and the alternates show up correctly, and then I close the menu and without pressing alt, I open the menu again and sometimes the same menu with the alternates is shown.
Also, it would be really awesome if this new behavior was supported across all the context menus, not just the editor one.

Yeah, thanks for getting back on this. I reverted my changes and reopened this issue. It isn't as easy as I thought... The challenge is that as soon as the context menu opens we are blind and deaf, in particular we miss when the alt-key is being released. Since there is no API as is alt key pressed right now and since we emulate that by listening to various events it's quite bad that we miss those events...
Unsure how to fix this without getting more support from electron.

@jrieken Nooooo.  This should still be opened though right?

I know... the new year shouldn't start with such bad news ;-)


Implement tcp fast retransmit

To improve the TCP performance in case of occasional packet loss implement the fast re-transmit algorithm. This solves issue https://github.com/zephyrproject-rtos/zephyr/issues/46351 and https://github.com/zephyrproject-rtos/zephyr/issues/47240

Let's put it this way: It's a good thing the payload is not checked in static void test_server_recv_out_of_order_data(void), using the seq as a pointer probably not returning the data the tester intended.
,

Does it make sense increasing the default CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT to a value larger then 100 ms? What value would make sense?

While making the test I bumped into the following issue: https://github.com/zephyrproject-rtos/zephyr/issues/47240

Actually open TODOs:

Validate the data in the testcase upon reception
Handle the situation where the incoming data is fully including the packet that is already queued, in that case clear the existing buffer and start over.

@jukkar / @rlubos: I'm a little bit stuck getting the contents of the data. I made an attempt in https://github.com/zephyrproject-rtos/zephyr/commit/8ade6b57d5bbec7d4e0a4a3561ed9d119ddbcd54, but in the tcp_recv_cb, it looks like the pkt is always NULL, so I'm not able to check the contents properly. Am I on the right track or how would you implement this?

@jukkar / @rlubos: I'm a little bit stuck getting the contents of the data. I made an attempt in 8ade6b5, but in the tcp_recv_cb, it looks like the pkt is always NULL, so I'm not able to check the contents properly. Am I on the right track or how would you implement this?

It seems to me that your approach is correct - if the callback function gets a NULL pkt pointer all the time it could indicate some underlying issue...

@ssharks Is the PR ready for final review or are you still working on it?

Although the theory is nice, I ran the large socket test, with Nagle disabled and bumped into the following issue:
ASSERTION FAIL [buf->len >= len] @ WEST_TOPDIR/zephyr/subsys/net/buf.c:1155, aparently the way I handle buffers at the moment is not working in all cases.

It took considerable effort to make the fast re-transmit work reliable under all conditions, The modification of the pending_len needs to be done carefully in the function tcp_check_pending_data due to the way the result is used afterwards.
I attempted to cover a lot of corner cases by both manual analysis as well as the unit test.
I believe the current implementation is functional, although there is room for improvement on clarity. Suggestions from reviewers are very welcome.
This makes me believe we must be lucky the CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT is default at 100 ms, which pretty much disables the out of order processing. Because the original implementation was easily going wrong.

Will be fixed on Wednesday

@jukkar: Could you have a look at this PR?

@jukkar/@rlubos Should we increase CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT default value from 100 ms to for example 1500 ms to have it more effective in practice? It is likely in practice there will be a timeout of 100 ms somewhere which renders basically disables the reordering process, because it had already timeout.

@AndreyDodonov-EH This might be interesting for you as well

@jukkar/@rlubos Should we increase CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT default value from 100 ms to for example 1500 ms to have it more effective in practice? It is likely in practice there will be a timeout of 100 ms somewhere which renders basically disables the reordering process, because it had already timeout.

I think we can consider increasing the default value, however, we should carefully observe the results, as this would also imply increased buffer consumption.

@Andr

@jukkar/@rlubos Should we increase CONFIG_NET_TCP_RECV_QUEUE_TIMEOUT default value from 100 ms to for example 1500 ms to have it more effective in practice? It is likely in practice there will be a timeout of 100 ms somewhere which renders basically disables the reordering process, because it had already timeout.

I think we can consider increasing the default value, however, we should carefully observe the results, as this would also imply increased buffer consumption.

That is indeed a risk, the amount of stored data will never exceed the receive window, however due to fragmenting the number of used fragments can be larger then expected. This becomes worse the packets become smaller or the CONFIG_NET_BUF_DATA_SIZE becomes bigger. There is currently not a kind of defragmentation implemented or trimming of the end of the queue when the stack runs out of receive buffers.

@jukkar Could you look at this PR?

@ssharks can you rebase? There's a pending merge conflict.

@ssharks please rebase

During rebase I bumped into and issue, need to investigate first,

Rebased the PR, but do not review jet

I have found and fixed 2 remaining bugs. Also I had to do a rebase, with some merge conflicts so please carefully re-review. Especially around the ZWP exponential backoff.
There is always more to which for, but for now, I think this PR is ready for the time being.
On the which list:

Merge the tcp_check_pending_data and tcp_queue_recv_data into a single one
Support packets that are partially overlapping with already acknowledged data
Support multiple disjoint out of order sequences

Sorry, another comment fix. Needed to update a comment after copy paste.

@rlubos: Thanks for your review, I fixed the merge conflict in commit: https://github.com/zephyrproject-rtos/zephyr/pull/47115/commits/54956a72b346e85565c18086b8f25ec49f8a1ee4. The conflict was minor.

@jukkar: Are you satisfied with the implemented changes?


Use .cast() instead of as for type casting pointers

There are no behavioral changes by favoring .cast() over as casts, but using the method generally looks better and is easier to write. Overall, it feels more strict and concise, as as casts could be pretty lenient.

Here is an open discussion on this issue from clippy.


[pattgen] V2(S) Signoff

Description
Ensure V2(S) signoff criteria are still maintained (this is not a focus area block).

Thanks for the analysis @rswarbrick.
Given the priorities, I think we can accept 89.95% coverage for covergroups in this case ;).
As for the signoff order, it probably makes sense to use most of this analysis to close out the D2S issue here first: https://github.com/lowRISC/opentitan/issues/21004
Otherwise I think this is ok to sign-off at V2S, given the pass rates and coverage metrics reported.


[Event Request] Table 39 "Purchase Line" - OnValidateLocationCodeOnBeforeTestField

Hello. In table 39 Purchase Line, in field 7 "Location Code", in trigger OnValidate, we would like to add a condition at a specific moment. To do so, we would need a IsHandled flag and an event publisher here :
            if xRec."Location Code" <> "Location Code" then begin
                if "Prepmt. Amt. Inv." <> 0 then
                    if not ConfirmManagement.GetResponseOrDefault(
                         StrSubstNo(
                           Text046, FieldCaption("Direct Unit Cost"), FieldCaption("Location Code"), PRODUCTNAME.Full), true)
                    then begin
                        "Location Code" := xRec."Location Code";
                        exit;
                    end;

                IsHandled := false;
                OnValidateLocationCodeOnBeforeTestField(Rec, IsHandled);
                TestField("Qty. Rcd. Not Invoiced", 0);
                TestField("Receipt No.", '');

                TestField("Return Qty. Shipped Not Invd.", 0);
                TestField("Return Shipment No.", '');
            end;

With the event integration :
[IntegrationEvent(false, false)]
local procedure OnValidateLocationCodeOnBeforeTestField(var PurchaseLine: Record "Purchase Line"; var IsHandled: Boolean)
begin
end;

Thank you for your work.

You asked for IsHandled parameter that is not used after it is passed to the event call? Don't you miss 'if IsHanded then exit'?

You're right, sorry for that. I edited my post.


Add nikon nef (image/x-nikon-nef) mime-type

Add support of nikon NEF raw files : image/x-nikon-nef

Sorry, wrong project for this PR

Requests for new mime types should be submitted to https://github.com/jshttp/mime-db


Use mashumaro for serializing logging events

resolves #4504
Description
Use mashumaro to serialize json logging.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change

Mashumaro required that the Event class be a dataclass.  Changing the Event class to a dataclass with attributes with defaults means that the attributes of subclasses all have to have defaults too (because non-default attributes can only come before attributes with defaults). In some cases Event subclasses were being constructed without keyword names, which caused the passed in value to be used for the first attribute (i.e. log_version) which didn't work, so all constructors needed to use keyword arguments.
Mashumaro also expects to serialize everything in the case, so it didn't work to have various node objects in the event classes. I switched to putting the node_info construction code in the nodes themselves and passing the node_info the even classes instead of passing in the various node objects. I would have liked to make _event_status and node_info into a separate class, but mypy really didn't like that. The stubs.py file was removed.
I created a separate core/dbt/events/serialization.py file for handling the mashumaro serialization, since these classes didn't need some of the complications in core/dbt/dataclass_schema.py. It's also a good place to put other special serialization code if we need it.

Integration tests with json serialization on are hanging in the interop tests. I suspect there's an exception being raised in threads again.

I get a few failures too when I run DBT_LOG_FORMAT=json make integration locally. But it's definitely hanging sometime after the 73% mark.

"it looks like when an event takes a type that isn't serializable we are forced to convert it to a serializable type outside the event module which leaks a core abstraction of the event module back out to the rest of the code base"
I'm not sure that I agree that it is the event module's job to enable serialization for outside classes. In any case, serializing classes that are not needed for the event message feels unnecessary, since it gets thrown away anyway. I think that we're better off providing only the information that is needed for the event/message.

"mypy can no longer catch when we fail to provide event attributes even when mypy runs everywhere"
Providing defaults for attributes of subclasses is something that the Python dataclasses module forces you to do.  I think it's probably more important to consistently make the classes dataclasses than make a couple of methods abstractmethods, when executing those methods without an override will throw an error just like the abstract base class.

The way I see it, the event module is tasked with translating dbt's internal representations into a structured output that is versioned as an API so that downstream applications can rely on it. Serialization and schema conformity are both major parts of creating this API to an enterprise quality. I want this code to be written in such a way that if you are not modifying the event module you do not need to know anything about how it was built or what it needs to continue to conform to the logging API version.
If using dataclasses forces us to weaken our development-time guarantees for this API, we should switch tactics and do something else.

Just finished a quick sync with @gshank to go over the remaining comments. Here are the outcomes from that conversation:

The node_info field is going to move underneath data. This will require an API version increase.
The serialization strategy for datetime objects in serialization.py seems to be currently unused so it's going to be removed with a comment for now to avoid confusion between other datetime serializations. Cleaning up these across dbt-core is recorded in #4608
The "node_info" value is actually not being constructed here, it's just being passed through as a dictionary, so let's skip turning it into a nominal type here for now.
RunResult is a little tougher to serialize with mashumaro. Let's comment what makes that difficult and leave it as a dictionary value.


Update api version to match the version that swarm supports

Swarm reports that it uses api version 1.16, but this is a lie.  With the 1.0.0 release it supports api version 1.21.

I think this change will prevent swarm to manage docker engines with API < 1.21

not at all my bad
LGTM


There is no sound when notification is received. Android 8.

Hi, I'm trying to use sdk-26 branch. I test it on a devices and emulator. Everything is fine on android from 4.2 to 7. But on android 8 notifications appears on the screen but there is no sound.
I'm trying to send custom notification.
{
  token: deviceToken,
  data: {
    custom_notification: JSON.stringify({
       title: "Title",
       body: "Body",
       sound: "default",
       priority: "high",
       ticker: "Ticker",
       channel: "default"
    })
  }
}

"react": "16.0.0-alpha.12",
"react-native": "0.47.1",
"react-native-fcm": "github:evollu/react-native-fcm#sdk-26"

seems sound and vibration are controlled by notification channel now.
If you want to you can fix yourself and create a PR. or I will fix it later
https://github.com/evollu/react-native-fcm/blob/sdk-26/android/src/main/java/com/evollu/react/fcm/FIRMessagingModule.java#L86
https://developer.android.com/reference/android/app/NotificationChannel.html

any update?


Use Statement keyspace information for TokenAwarePolicy

Rebased to get the appveyor fixes in #299

The build bailed on jenkins is not related to this PR.


Move cloud-controller-manager functionality into dedicated controller

Is your feature request related to a problem? Please describe.
Upstream cloud-controller-manager is no longer supported. As per the 1.20.0 release notes:

Kubernetes will no longer ship an instance of the Cloud Controller Manager binary. Each Cloud Provider is expected to ship their own instance of this binary. Details for a Cloud Provider to create an instance of such a binary can be found under here. Anyone with questions on building a Cloud Controller Manager should reach out to SIG Cloud Provider. Questions about the Cloud Controller Manager on a Managed Kubernetes solution should go to the relevant Cloud Provider. Questions about the Cloud Controller Manager on a non managed solution can be brought up with SIG Cloud Provider.

Describe the solution you'd like
Move the work currently handled by the cloud-controller-manager hooks into a dedicated embedded controller. This is mostly just:

Setting the node external IP address
Removing the uninitialized taint on new nodes

Describe alternatives you've considered

Keep using the current mess that we had to hack in to get CCM to work in 1.20.0:
https://github.com/k3s-io/k3s/commit/c6950d2cb0b242595640ea3ad5a7570343ab7829#diff-c68274534954d72488196ca23f12cfb3ebe65998d9e7c4a43d7ba9acc9532574R914

Additional context

Possibly related to k3s-io/k3s#2425
kubernetes/sig-release#1378
https://twitter.com/ibuildthecloud/status/1336341788827611138

I have also seen CI flakes where the node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule taint doesn't clear on the test cluster nodes. In looking at the logs, it appears that the cloudprovider node lifecycle hook is failing, perhaps due to some internal caching that is causing it to fail to find the newly-added node?
I1216 19:41:56.710081       1 range_allocator.go:373] Set node 99cc7a89bf52 PodCIDR to [<IP_ADDRESS>/24]
I1216 19:41:56.710231       1 node_controller.go:390] Initializing node 99cc7a89bf52 with cloud provider
E1216 19:41:56.710271       1 node_controller.go:212] error syncing '99cc7a89bf52': failed to get provider ID for node 99cc7a89bf52 at cloudprovider: failed to get instance ID from cloud provider: Failed to find node 99cc7a89bf52: node "99cc7a89bf52" not found, requeuing
I1216 19:41:56.711156       1 range_allocator.go:373] Set node a2144c8e7203 PodCIDR to [<IP_ADDRESS>/24]
I1216 19:41:56.711435       1 node_controller.go:390] Initializing node a2144c8e7203 with cloud provider
E1216 19:41:56.711466       1 node_controller.go:212] error syncing 'a2144c8e7203': failed to get provider ID for node a2144c8e7203 at cloudprovider: failed to get instance ID from cloud provider: Failed to find node a2144c8e7203: node "a2144c8e7203" not found, requeuing

Validated in master branch commit: ada145641c2fd56c4b170ef6810804125e4b946c

Correctly sets ProviderID in default installs
Can still be disabled and that functionality is working correctly


Question -  YAML processing capability in groovy for z/OS

Hi,
Are there any YAML file processing capabilities in groovy for z/OS?

load a yaml file into a groovy object
save groovy object as yaml file

More generally, where can we find documentation on the groovy language in the version used by DBB?
Have adaptations to the language standard been added to the version for z/OS?
What then would be the differences / limitations / enrichments?

Hi @friedhelmmuench
Thanks a lot !


Update the documentation build configuration

don't generate nugets for this config
do generate documention XML for all libraries
do include all library projects
don't include test or sample projects

@drub0y , Updated.

Appreciate it, thanks.

Gah, for the record, the build broke running the LUIS tests due to an HTTP communication issue, not because of anything that was wrong with these actual changes. /cc @cleemullins

Failing build is unrelated to this change - it's the Machine Translation code timing out. I've reached out to @mostafaelaraby to get this resolved.


Unable to upload images correctly in the feedback

I am trying to upload images in a feedback, but it would be like this:

I found that the image has been successfully uploaded, but when retrieving the image, the URL does not have a port number.

So I add the a port number to this property.

Now I can see the image on the preview.

But after submitting, the image is missing.

I use ClearFlask on:

[√] Self-hosted (Own domain)
[ ] Cloud (clearflask.com)
[ ] Haven't tried (yet)

My financial contributions to ClearFlask:

[√] I use a free Plan
[ ] Thinking about it
[ ] Monthly / Yearly Plan
[ ] Lifetime Plan

This is high priority request:

[ ] Yes

Unfortunately I don't support accessing ClearFlask by IP. There are probably more issues you will run into, please setup a hostname or a domain name for your installation and add an SSL/TLS certificate.


Rename

[ ] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

Proposing this because I don't even remember why it's "generalized split".
It seems some of the changes from #191 have leaked in (sorry) so I'll clean this up once that one is approved.


Logging slurm job id +

Description
Added job init and job end logs.
Example of new logs on neptune exp run: https://app.neptune.ai/o/pmtest/org/llm-random-tests/runs/details?viewId=9a15c4c2-79b1-4509-9f98-9edd0595f46f&detailsTab=metadata&shortId=LLMTST-2625&type=run
Checklist

[x] Is this PR focused on a single feature without the possibility of being divided into smaller PRs?
[x] Are all variables set with logical defaults that are backward compatible?
[x] I attached link to neptune if it was necessary
[x] Have you successfully executed the linter and tests?
[x] Are all functions concise and don't require splitting?
[x] Is there documentation for arguments and complex logic?
[x] Are there no temporary solutions in the code? Should a task be added to Trello to refine the code?
[x] Are all functions placed in appropriate files?
[x] Is the PR name meaningful and descriptive?
[x] Is PR description provided, or unnecessary?

Other questions:

[ ] If I made changes to the requirements or anything related to the Singularity image I did generate new image and upload a new image to the clusters
[ ] If this change is significant enough I notified all individuals working with this repository (@channel in slack channel)
[ ] If there is a need for a second reviewer I requested additional review

Reviewer's checklist:

[ ] Does the Neptune link work and does it actually compare the situation before and after the PR?
[ ] Do I understand the code?
[ ] Do I think another reviewer is not needed or I commented that this PR need another reviewer?

@j321m added: https://app.neptune.ai/o/pmtest/org/llm-random-tests/runs/details?viewId=9a15c4c2-79b1-4509-9f98-9edd0595f46f&detailsTab=metadata&shortId=LLMTST-2625&type=run


How do I get an external address attached to the ingress controller

Hi!
 So please forgive me.
I am able to create a cluster and deploying helm charts in that cluster works fine. But when I install an ingress controller (I want to install Jenkins-X) I always end up with the external address in state "pending". What do I need to do to get an external address attached? Jenkins-X does not proceed with its installation as long there is no external address.
Thanks
Thomas

There are two ways of exposing services, LoadBalancer service type, and ingress. You are asking for LoadBalancer services. This means, a cloud provider takes a floating IP from the cloud infrastructures and connects to your cluster. This is a feature, which most commonly exists only in cloud kubernetes clusters, like on GCP, AWS or Azure. There also a custom one inside rancher. \
For the rest you use ingress. The ingress means, you declare an additional resource called Ingress which takes a service and a host name and makes the binding. You need a ingress controller to do this in real. For this purpose, you might use nginx ingress controller. You have one in the hetzner-kube admin section.
A quick google lead me to an obvious issue you ran into: as of http://jenkins-x.io/commands/jx_install/ jenkins-x automatically installs an nginx ingress controller for you. But the default ingress controller tries to get its IP over an external IP from a load balancer. That is not the way we do this in custom clusters like hetzner-kube. Here the ingress controller must be deployed as DaemonSets, running on every (specified) node with hostNetwork on. In order to use jx with a hetzner-kube cluster, you must use --skip-ingress and install hetzner-kube cluster addon install ingress -n your-cluster in advance.
I didn't test this, but this should work. Please close this issue if your issue is resolved.

yeah, really looks like a JX issue here.

This seems to be an Jenkins X problem. Closing issue.


ISSUE-87: Add support for Kafka Header Registry.

@satishd
Thanks for the review! Addressed your comments. Please take another look.


Added Rishabh Pant info (Hacktoberfest)

Added Rishabh Pant info (Hacktoberfest)

Hey I have resolved too. Please accept my PR #279


Avoid hanging when prompt for TRAMP

And fix the issue that C-g can't quit.

Could you provide more details? I don't experience the problems you describe (TRAMP hanging or not able to quit with C-g).

If the network is poor or something wrong with ssh configuration, it may be hanging,
and C-g will not work. Both on Windows and Linux, emacs version 27.1.
For example, typing /ssh:root@host.com:, and it will hang or stuck every keypress.
Nothing can do, but kill the emacs progress.

Okay, thanks using your example it hangs for a while but I can still quit by pressing C-g a few times. Using your PR quitting from this hand or from a password prompt will trigger an error in post-command-hook which will remove selectrums update function from it (which breaks further usage for the session). It seems we need to look for a way which will allow to quit more easily from the hanging TRAMP prompt but also avoids the error in post-command-hook.

My Case:

I can't reproduce your error, I don't known why..
There is a bug in TRAMP that still not fixed, when connecting to the latest FreeBSD, it will hang
In the above hanging, C-g not work, no matter how many times you pressed
This bug has been fixed in emacs 28
Except the hanging caused by this bug, other hanging problems also exists
Completing the remote file or not, in my opinion, should be an option can be choosen by user

I can't reproduce your error, please provide more information.

For example use /sudo::/ and when prompted for a password quit with C-g. This should throw the error and remove selectrum--minibuffer-post-command-hook from post-command-hook. Afterwards changing the input or editing the prompt will have no effect any more (selectrum won't update according to current input).

In the above hanging, C-g not work, no matter how many times you pressed. Killing emacs from taskManager is the only choice.

This isn't the case for me (on Linux Emacs 27.1), so it seems to be system dependent. If I press C-g multiple times I can edit the prompt again and selectrum keeps working.

Completing the remote file or not, in my opinion, should be an option can be choosen by user

Maybe there is already an Emacs option to control that? Otherwise we can think about adding such an option, especially if it helps avoiding the hanging problems you have.

Afterwards changing the input or editing the prompt will have no effect any more

It may be that I did not really understand what you mean, and I still did not reproduce the error you mentioned.

This isn't the case for me (on Linux Emacs 27.1)

In order to avoid the above bug, all my Emacs are now upgraded to 28. However, the hanging probleam occured on Windows 10 and Archlinux, both of which are Emacs 27 versions.
Strange and strange.

Otherwise we can think about adding such an option

This PR is very simple and rude, but it is enough to solve my problem. Maybe you can wait for other people with the same problem to raise an issue before deciding what to do.

In order to avoid the above bug, all my Emacs are now upgraded to 28. However, the hanging problem occurred on Windows 10 and Archlinux, both of which are Emacs 27.1. And all hangings occurred when connecting remote FreeBSD

I hangs for me, too but I can use C-g to fix it by pressing it multiple times.

Maybe you can wait for other people with the same problem to raise an issue before deciding what to do.

I would prefer that, I will open an issue referencing this PR and wait until we have clearer picture about it.


Fix Tuya BlitzWolf motion sensor

Proposed change
This reverts the BlitzWolf motion sensors to use the IasZone cluster instead of using the OccupancySensing cluster.
This change was made to keep existing entities working. The missing auto-reset delay was also reintroduced.
cc @prairiesnpr
Additional information
Small follow-up to https://github.com/zigpy/zha-device-handlers/pull/3612
Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[x] Tests have been added to verify that the new code works

Hmm, looking at the code we had for this before, I'm now also wondering if this sensor correctly sends a "reset" message.
Previously, we just reset it after 15 seconds of no messages.

Ok, got the sensor now and we need a timeout. The current zhaquirks code for MotionWithReset and so on still uses Bus, so that doesn't play well with quirks v2. I'll take another stab or revert that sensor part otherwise.

Changes work as expected now.
The timeout code is somewhat copied from MotionWithReset and related clusters from the base zhaquirks module.
However, that code is outdated, still uses Bus somewhat, and listens to the IAS zone status change commands.
We generally listen to IAS zone status attribute updates now. This is also needed for the Tuya DP conversion.

Hmm, reset_s was 15 before the changes in https://github.com/zigpy/zha-device-handlers/pull/3612 and is again with this PR, but my sensor seems to need a longer delay.
I'll leave this as-is for now to keep behavior "unchanged", but I wonder why nobody complained before..? 😄


Implement LLVM Modules

When I tried to build an iOS application with SQLite Framework on the latest swift 2.2 snapshot, I get build failed on the sqlite3 being non-modular.
Example of modules file looks like for sqlite3
    header "/Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/include/sqlite3.h"
    export *
}```

any developers have to create modules in each SDK.

@iNoles , can you please give the publicpod branch a try, per PR https://github.com/stephencelis/SQLite.swift/pull/314.
Along with some other build simplifications, it does (almost) exactly as you've suggested (see modulemap file) and I'd love to hear if it works for you or not... as I'm not running the Swift 2.2 snapshot.
The only difference is that it references "/usr/include/sqlite3.h" instead of the various platform includes to keep things simple between the various build targets. Fortunately, AFAIK, sqlite3.h is pretty platform agnostic. If you know of a better way...  I couldn't find a way to reference different paths for different build targets. I can't wait for the Swift Package Manager to be released. It will clean up so many things!

my concern about "/usr/include/sqlite3.h" would use system path, but not SDK ones.

Yes, that's my concern too. I just don't have a solution...  Do you know of one?
At least a step forward...

On 8 Jan 2016, at 12:02 PM, Jonathan<EMAIL_ADDRESS>wrote:
my concern about "/usr/include/sqlite3.h" would use system path, but not SDK ones.
—
Reply to this email directly or view it on GitHub.

@iNoles Please let us know if you run into issues there. Assuming the header is always available, the interface should generally be the same between the current SDK header. I'd love to have a general solution here, but it may have to wait for Swift Package Manager support and the forthcoming plans to support dynamic LLVM modules.

@stephencelis I had Swift 2.2 snapshot of December 31.
It did show this error
/usr/include/sqlite3.h:35:10: note: while building module 'Darwin' imported from /usr/include/sqlite3.h:35:
#include <stdarg.h>     /* Needed for the definition of va_list */
         ^
<module-includes>:32:9: note: in file included from <module-includes>:32:
#import "util.h"
        ^
/usr/include/util.h:107:10: error: 'utmp.h' file not found with <angled> include; use "quotes" instead
#include <utmp.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/usr/include/sqlite3.h"
        ^
/usr/include/sqlite3.h:35:10: error: could not build module 'Darwin'
#include <stdarg.h>     /* Needed for the definition of va_list */
         ^
/Users/jonathansteele/Desktop/mobile/iOS/SQLite.swift/SQLite/Core/Blob.swift:25:8: error: could not build Objective-C module 'SQLite3'
import SQLite3

I suppose we might need separate modules for CSQLite3_Linux and CSQLite3_Mac to support this in the meantime.

I think it is a best to create a modules map on each SDK for this.

Yup. This won't unfortunately work for Xcode-beta.app and installations other than /Applications/Xcode.app, but that'll have to do till LLVM modules are more flexible.

@iNoles - so can we close this now, on the basis of your comments re 0.9.2 in PR #327 ?

I guess so.


Support non-blocking mode

I would prefer to set a timeout for reading data instead of blocking till the connection get's closed.

here it is https://github.com/albenik/go-serial

Cool thanks, would be nice if it gets ported back into bugst.

Yes of course! But it depends on previous improvements (https://github.com/bugst/go-serial/pull/29) which where still not merged here a long-long time.

Fixed by #109


[Source Request]

Source website

Name: YouTube
Link: youtube.com
Language(s): Whatever you need....

Other details
So yeah, this might be a surprise but YouTube actually has a lot of anime that can be watched for free legally. A lot of channels simulcast latest releasing anime on YouTube for free.
Now contrary to what most people think, making a youtube plugin should be fairly easy as long as you know how to make REST API requests. There's this awesome project called invidious.io that exposes an api that can be used to get stream links. An option can be added in the plugin settings to enter the url to an invidious instance. This should be fairly easy since I have used the invidious api using curl in a shell script. I would create the plugin myself but I am not even remotely familiar with Android development and Kotlin... So please help me out!

Not gonna lie.... It would be sick

Bump! Has there been any work done regarding this?

Any and all work done will be shown here, you can subscribe to get notifications on it. Since nothing has been done since February last year it just means that no one is willing to work on this. Also, please do not "bump" issues as it doesn't help with anything.


applications always remain "Removing", and can not be removed

Describe your issue here

Useful
Info

Versions
Rancher v2.0.0-alpha10 Cattle: v0.184.10 UI: v2.0.11

Access
Disabled

Orchestration
``

Route
apps-tab.index

There have been major changes since this tech preview, please try the latest (v2.0.0-alpha23, https://forums.rancher.com/t/rancher-tech-preview-update-3-26-2018/9893) and file a new issue if you run into trouble.


WFLY-8207, WFLY-6973 JGroups 4.0.x, Infinispan 9.1.x upgrade

https://issues.jboss.org/browse/WFLY-8207
https://issues.jboss.org/browse/WFLY-6973
Component updates are inter-dependent, hence the single PR.
Kabir Edit: I saw https://github.com/wildfly/wildfly/pull/10804 first, so some of the discussion is there

@psakar @Skullman Are you able to build these upgrades?

Licenses:
JGroups: https://github.com/belaban/JGroups/blob/master/pom.xml#L39 + https://github.com/belaban/JGroups/blob/master/LICENSE
Infinispan: Uses the wrong word for the license at https://github.com/infinispan/infinispan/blob/master/pom.xml#L17 and has no license.txt.

The licenses are fixed upstream now

@pferraro any reason to not use the latest dependencies?
[7:01 PM] Petr Sakař: @KabirKhan I can see https://github.com/ben-manes/caffeine/blob/v2.4.0/build.gradle is quite old - there is already 2.6.1 version available https://github.com/ben-manes/caffeine/blob/v2.6.1/build.gradle
[7:03 PM] Petr Sakař: @KabirKhan HIkariCP - included 2.7.4 versus 2.7.7

@kabir I've updated Caffeine and HikariCP to the latest versions.  There do not appear to be any source/binary compatibility issues.

@kabir "For "Drop custom protocols - these are no longer necessary." - I am not familiar enough with this stuff to know how this is safe. Is there some conversion process if someone uses an older xml config? Did these do something in WF11?"
The dropped custom protocols are just an implementation detail which allowed the integration code to inject dependencies (e.g. key stores, datasources, etc).  The requisite changes that originally necessitated these are now in upstream.  The configuration is identical, so compatibility is not an issue.
"For "Deprecate cache mode. Transform mode to SYNC for legacy model versions." - I guess making means we're always SYNC now and this is no longer configurable?"
The "mode" attribute is now deprecated.  Async mode is being dropped upstream and is replaced by a programmatic API.   Our default configs have used SYNC mode by default for some time now.

@pferraro I was about to merge, but having looked a bit at the test failures I think they might be related.
There is a failure in the elytron job https://ci.wildfly.org/viewLog.html?buildId=88063&buildTypeId=WF_PullRequest_LinuxElytro, and this seems quite new https://ci.wildfly.org/project.html?projectId=WF_PullRequest&buildTypeId=&tab=testDetails&testNameId=4824753507849926218&order=TEST_STATUS_DESC&branch_WF_PullRequest=all_branches&itemsCount=50. The only other place it failed is in your #10753 which presumably is a variation on this one?
Similarly the Windows failure at https://ci.wildfly.org/viewLog.html?buildId=88061&buildTypeId=WF_PullRequest_Windows isn't super common. https://ci.wildfly.org/project.html?projectId=WF_PullRequest&buildTypeId=&tab=testDetails&testNameId=5201737289209392073&order=TEST_STATUS_DESC&branch_WF_PullRequest=all_branches&itemsCount=50 It shows up a few times for this PR and #10753 which makes me suspicious. It has never shown up on master, but still appears in a few other PRs so it might not really be an issue caused by this. Can you look into it?

@kabir Good catch.  infinispan-core has this configured as a runtime dependency for some reason (probably an oversight).  I'll just exclude it in the pom for now and fix upstream to properly scope it as a test dependency.  See: https://issues.jboss.org/browse/ISPN-8787

Re: test failures - these are all ultimately due to the same "Timeout waiting for topology N" while committing a transaction.  The primary culprit seems to be use of the AdvancedCache.getAll(...) operation, which we have found issues in the past.  I've added another commit that removes the usage of this operation, replacing it with multiple individual get operations.

retest this please


Invalid package name in documentation

Documentation says package name is goose - from PyPI/configs, looks like package name is goose-ai.

thanks - yep just merged in a pending change


Multifactor auth support

Hi!
We're migrating a native android app that uses multifactor auth to flutter. I haven't been able to find any documentation on how to do this within the auth flutter sdk.

Is this currently supported?
Is there any plan to support this? Or would we have to resort to native channel code for now?

@amitav13
There's an open discussion thread on MFA, https://github.com/FirebaseExtended/flutterfire/discussions/2386
Please follow-up there for updates or you may comment in it to get more attention from the team.
Closing from here as a duplicate.


Add support for linking NSS statically on macOS

This is an attmept to link with NSS statically on macOS (both Intel and
Apple M1).
Statically linking with NSS is a total mess and completely
undocumented. There are 20+ .a files to link with, and their linking
order matters. The main reference for this commit is a Mozilla Rust code
responsible for statically linking NSS:
https://github.com/mozilla/application-services/blob/b2690fd2e4cc3e8e10b6868ab0de8b79c89d3a93/components/support/rc_crypto/nss/nss_build_common/src/lib.rs#L94
Unfortunately, even with that in hand, a lot of hacking is needed to
make it all work.

Solves #24


Gate modifiers (square root, inverse)

Being able to hit gates with modifier tools might make the interface sparser by removing the need for having all the various square roots and inverses available up front...?

At the moment I don't think this is a good idea. Better to just lean on custom gate creation.


Add dynamic subscriptions to re-frame

Dynamic subscriptions allow the user to create subscriptions that depend on Ratoms/Reactions and will be rerun when they change. Users will subscribe with v and a vector of dynamic values. The dynamic values are dereffed and passed to the handler-fn. Dynamic subscriptions need to pass a fn which takes app-db, v, and the dereffed dynamic values.
Every time a dynamic value changes, handler-fn will be rerun. This is in contrast to standard subscriptions where handler-fn will only be run once, although the reaction that it produces will change over time.
A concrete example of the need for this is:

You want to subscribe to a query on a remote server which will return
a Reaction which changes in response to server changes.
You want this subscription to be able to be rerun when you change one
of the query parameters.

In the current system, all views need to be aware of the possibility of changing parameters and provide them in their subscriptions.
Example usage code:
(register-sub
  :todo-dynamic
  (fn todo-dynamic [_ _ [active-list]]
    (let [q (q/get-query active-list)]
      q)))

(register-sub
  :todos
  (fn todos [db _]
    (let [active-list (subscribe [:active-list])
          todos       (subscribe [:todo-dynamic] [active-list])]
      (make-reaction (fn todo-vals [] (update @todos :result #(vals (:list %))))))))

Tasks:

[ ] Write docs showing usage

I talked with @mike-thompson-day8 about this and he discovered a way to avoid calling run!. This is fixed in e01023a.

We must check that all items in active-list  implement IReactiveAtom

I've added an error message, when passing non-reactive parameters. I'm open to better wording for the error though.

@danielcompton my version of that error message and surrounds would be:
(when ^boolean goog.DEBUG
  (when-let [not-reactive-dynv (seq (remove (partial implements? reagent.ratom/IReactiveAtom) dynv))]
    (warn "re-frame: 3rd parameter to 'subscribe' should be a seq of input signals but you supplied non reactive items: " not-reactive-dynv)))

I've used your code, and modified the error message slightly to give the technical details.
re-frame: 3rd parameter to 'subscribe' should be a seq of input signals (implementing IReactiveAtom) but you supplied non reactive items:

While I think this is a pretty good solution and technically sound, I think we should mark this as experimental at first.

For anyone watching this issue, it's out in https://github.com/Day8/re-frame/releases/tag/v0.5.0-alpha1. Try it out in your apps and give us feedback.

Released in version 0.5.0


[Ask] Download in background

What is the best scenario to make Fetch2 able to keep on downloading whenever user move to other activities?
Should I use single Fetch instant?

@dreasn You can create a global Fetch instance that you can reference from any Activity. For example you can extend the Application class and place your Fetch global instance there. Then you can access your custom application class and reference the Fetch instance. In the activity you can then attach and detach Fetch listeners. Have a look at the sample project to see different use cases. Hope this helps.

alright.  already did so.  Thanks.

I approached it with FetchService (background long-running service) which communicates via broadcasts with the rest of the app (also binder can be easily applied). Since there's single service it holds single Fetch reference.


For scryfall filtering with the current season, automatically add f:pd to the query

This should apply on /rotation/changes/ as well as /cards/ but not /seasons/11/cards/ or /rotation/speculation/

Fixed by dec74cf


Graph mode data bug in data metanodes

This bug only occurs in graph mode, have not seen it in the prototype mode. It isn't a breaking bug, things still work but it is confusing to the end user that they have to wait a couple seconds longer.
Occurs with a couple of GlyGen's data metanodes that have somewhat long(er) backend process metanode logic. In the case of the protein set backend, multiple API calls have to be made to grab the final data. Likely what is happening is that pressing on the card for the process metanode immediately calls the output data metanode and within the data metanode's .view() function the input parameter data is being read before the backend promise (API calls) are completed.
I suspect some state logic will need to be implemented in order to catch this error from being thrown to the frontend.
@u8sand Pat and I were wondering whether you would like us to implement this logic internal to our metanodes or if a fix with a larger scope would be more appropriate?

Hi @seankim658 this is already fixed in #92 and which will make it to main in the near future


Fixed typing error from dict to Dict in 11 files

Issues:
Issue#81
Description:
I have changed dict to Dict as requested in 11 files, including the original baseinspector.py and 10 other classes inheriting from BaseInspector. Checked for any other instances of dict, but these were the only ones found. Also added Dict in the import sections of the files where it was necessary.

@nihalshetty-boop great! I have several questions:

Why did you change versions in requirements? We don't plan to change versions of libraries in the current version
You have different editor settings or something like that? Since if you change one line in a file, Github shows a big block with changes.  We use PyCharm with default formatting settings
The issue needs to change dict to Dict, but not simple Dict. Dict allows using types of keys and values, e.g. Dict[str, int] means dictionary with string keys and int values. The main goal of this issue is to add full type annotations in the code
You have a lot of conflicts

@nbirillo I've checked my commit and this is what I think:

Why did you change versions in requirements? We don't plan to change versions of libraries in the current version

I didn't change them. The commit I pushed is Corrected dict to Dict and there are only 18 insertions and 18 deletions in total.

You have different editor settings or something like that? Since if you change one line in a file, Github shows a big block with changes. We use PyCharm with default formatting settings

I use VS Code with default settings. Those big block of changes were a problem in the previous PR because I did not have an SSH-key so I wasn't able to push commits. So I simply uploaded the files to the fork which caused that issue. I didn't do that this time so in my opinion those changes are of this entire branch, not just my commit.

The issue needs to change dict to Dict, but not simple Dict. Dict allows using types of keys and values, e.g. Dict[str, int] means dictionary with string keys and int values. The main goal of this issue is to add full type annotations in the code.

Okay, I haven't touched the dictionary Dict, just the imported function from typing which were used in classes inheriting from BaseInspector.

You have a lot of conflicts

These conflicts are only arising in branch Develop as far as I know. When I push to Main there are no conflicts and it only shows the 18 changes I've made in Corrected dict to Dict. This branch is behind Main and I've cloned from Main so I think that is what's causing these conflicts. If you check requirements-test.txt in main then you'll see they have the same versions as mine. I didn't explicitly change these values. Also for some reason this PR wants to merge all 4 commits in this branch, not just mine. I don't know how that happened. I can submit another one if required. Please let me know!

@nihalshetty-boop yes, we have different versions in the main branch and in the develop branch since all changes here are faster than changes in the production, where we use this tool. It would be great if you have the develop branch as a base branch in your PR. In this case, you will not have a lot of conflicts here
In addition, it would be great, if you add types into Dict, e.g. Dict[str, int] since it is very important for better code understanding
If you have any questions you can ask me, I will happy to help you! Thank you a lot for helping with the issue

Okay, as far as I know, I would have to clone hyperskill:develop and then push the changes to my fork right? So should I close this PR, clone the repo again, commit and push changes, and then submit a new PR? Please let me know if there's a simpler solution, I'm new to Open-Source.

In addition, it would be great, if you add types into Dict, e.g. Dict[str, int] since it is very important for better code understanding

Can you give an example with respect to any specific file?

@nihalshetty-boop you can use this guide to sync repos and check out the necessary branch. This PR will be updated automatically after your push
Of course, for example, in the run_tool.py file you can find this code:
inspectors_config = {
    'language_version': LanguageVersion(args.language_version) if args.language_version is not None else None,
    'n_cpu': n_cpu,
}

It means, that config has the following type: Dict[str, Any]
In this case, we always have this type of config and you can use it.

@nbirillo
I used the guide to switch my fork to develop from main and then, I cloned the  hyperskill:develop files, made the changes and tried pushing them to this PR branch, but it failed. There are some conflicts since the PR branch has  hyperskill:main files and my local repo now has  hyperskill:develop files. It's the opposite of the conflicts in this PR lol. I think I'll have to close this PR, delete the branch Fixed-Typing-Error since it's no longer needed and submit a fresh PR.

It means, that config has the following type: Dict[str, Any]

Is this type the same for config in all the BaseInstructor sub-classes?  I haven't used Type Hints before, how do I find out what are the data types of the keys and values in that dictionary?


Adding support for reading/writing compressed files.

We're seeing compression rates of around 200x for salento files, as call-sequences tend to repeat very often.
This patch adds some transparent support for compressed files. The files are supported when they terminate in a supported extension: .gz, .xz, .lzma, and .bz2. There are no external dependencies.

This is quite useful to reduce data storage space. To train a model, the data still has to be loaded fully into memory, right?

Yes, the user still has to ensure there is enough RAM to load the data. And it is optional, so no need to enforce it.


PhantomJS Linux binary missing

Not sure if this counts as a valid issue since it's sort of a feature request.  I have Unity on Linux and when I drag a Twine HTML file into the Project, I get the following error:
NotSupportedException: Editor platform not supported.
Cradle.Editor.Utils.PhantomJS.Run[HarloweStoryData] (System.String url, System.String bridgeScriptFileName, Boolean throwExOnError) (at C:/Projects/(external)/Cradle/unity/Cradle/Assets/Cradle/.src/Cradle.Editor/Editor/Utils/PhantomJS.cs:23)
Cradle.Editor.StoryFormats.Harlowe.HarloweTranscoder.Init () (at C:/Projects/(external)/Cradle/unity/Cradle/Assets/Cradle/.src/Cradle.Editor/Editor/StoryFormats/Harlowe/HarloweTranscoder.cs:114)
Cradle.Editor.StoryImporter.Transcode () (at C:/Projects/(external)/Cradle/unity/Cradle/Assets/Cradle/.src/Cradle.Editor/Editor/StoryImporter.cs:44)
Cradle.Editor.CradleAssetProcessor.OnPostprocessAllAssets (System.String[] importedAssets, System.String[] deletedAssets, System.String[] movedAssets, System.String[] movedFromAssetPaths) (at C:/Projects/(external)/Cradle/unity/Cradle/Assets/Cradle/.src/Cradle.Editor/Editor/CradleAssetProcessor.cs:83)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:232)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MethodBase.cs:115)
UnityEditor.AssetPostprocessingInternal.PostprocessAllAssets (System.String[] importedAssets, System.String[] addedAssets, System.String[] deletedAssets, System.String[] movedAssets, System.String[] movedFromPathAssets) (at /home/builduser/buildslave/unity/build/Editor/Mono/AssetPostprocessor.cs:27)
UnityEditorInternal.InternalEditorUtility:ProjectWindowDrag(HierarchyProperty, Boolean)
UnityEditor.DockArea:OnGUI()
I downloaded the PhantomJS Linux 64 bit binary and I am going to try editing the code to add a case for it.

I put the PhantomJS binary in and modified the code but when I import a story, it is not converted to a script but no errors are generated.  I'll try to upload my branch to show what I've tried.

@daterre I was unable to push a new branch but basically I added a Linux option to .src/Cradle.Editor/Editor/Utils/PhantomJS.cs and added the phantomjs binary to ThirdParty/PhantomJS/bin/linux/
Is Linux support do-able?

Hi @michaelbianchini, sorry it took me so long to answer! Yes, totally doable. I don't really have the environment to test it at the moment thought - do you have your fork somewhere I can look at? Maybe it's a simple fix.

Thanks @daterre !  No problem, I am just grateful you will help.  I just pushed my changes to the fork I created with my username, can you see them?  One is the PhantomJS.cs code, a one line change to find the linux binary, and the other is the linux binary itself.

Hi @michaelbianchini, looking at the code section containing your fix:
			// Get the location of the phantom exe
			string phantomExecutable =
				Application.platform == RuntimePlatform.OSXEditor ? "phantomjs" :
				Application.platform == RuntimePlatform.WindowsEditor ? "phantomjs.exe" :
				Application.platform == RuntimePlatform.LinuxEditor ? "phantomjs" :
				null;

			if (phantomExecutable == null)
throw new NotSupportedException("Editor platform not supported.");

The exception you are getting can only happen if Application.platform is not one of the above. Could it be that Unity is reporting some other value there?

thanks @michaelbianchini, I'll try to get a Linux environment up and running to start testing this stuff!

Is this going to land in an official release? I just hit the same place and noticed this thread while looking to see if anyone else has tackled this.

I don't know if this is related. But I get the same type of error on Linux when trying to add the current Cradle to my empty Unity 2019.3.14 project. (I ignored installing from the unity store because comments say v 2.0.1 is broken.

NotSupportedException: Editor platform not supported.
Cradle.Editor.Utils.PhantomJS.Run[ResultT] (System.String url, System.String bridgeScriptFileName, System.Boolean throwExOnError) (at C:/Projects/Demo-Wind/unity/Demo-Wind/Assets/Cradle/.src/Cradle.Editor/Editor/Utils/PhantomJS.cs:23)
Cradle.Editor.StoryFormats.Harlowe.HarloweTranscoder.Init () (at C:/Projects/Demo-Wind/unity/Demo-Wind/Assets/Cradle/.src/Cradle.Editor/Editor/StoryFormats/Harlowe/HarloweTranscoder.cs:114)
Cradle.Editor.StoryImporter.Transcode () (at C:/Projects/Demo-Wind/unity/Demo-Wind/Assets/Cradle/.src/Cradle.Editor/Editor/StoryImporter.cs:46)
Cradle.Editor.CradleAssetProcessor.OnPostprocessAllAssets (System.String[] importedAssets, System.String[] deletedAssets, System.String[] movedAssets, System.String[] movedFromAssetPaths) (at C:/Projects/Demo-Wind/unity/Demo-Wind/Assets/Cradle/.src/Cradle.Editor/Editor/CradleAssetProcessor.cs:85)
System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <437ba245d8404784b9fbab9b439ac908>:0)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.


[BUG]

Describe the bug
There are times when a azure vm linux run command execution gets hung and remains in this state indefinitely and we are unable to queue new run commands on that VM. The 90 minute timeout mentioned in the docs does not kick in. Stopping and starting the VM also does not allow queueing a new run command.
One simple way to repro this is to restart the walinuxagent process while a run command script is executing. This is not the only reason why it's gotten hung though, it has happened a few times arbitrarily but restarting the walinuxagent is one definitive way to repro this issues.
Expected behavior
There should be a server side timeout for the run command if the walinuxagent never reports back the status of the runcommand due to various reasons such as systems restarts etc.
Actual behavior (include Exception or Stack Trace)
The previous command remains in progress indefinitely and we are unable to queue new commands even after the 90 min timeout described in the docs
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

One simple way to repro this is to restart the walinuxagent process while a run command script is executing.

Environment:

Name and version of the Library package used: https://docs.microsoft.com/en-us/cli/azure/vm/run-command?view=azure-cli-latest
Hosting platform or OS: Azure Linux VM, Debian.

Hi @ShreyasRmsft.   Unless I misunderstand the context, it appears that your feedback is related to the Azure CLI and not one of the .NET Azure client libraries.  The CLI is not part of this repository;  you may want to consider opening an issue in the CLI repository to ensure that the right folks are able to assist.
I'm going to close this out, but please feel free to reopen if you believe that there's further discussion needed.


Feature HTTP Client Library Asynchronous API + Demo

Feature HTTP Client Library Asynchronous API + Demo
Description
This PR contains the changes needed to support the asynchronous API in the HTTPS Client library.
In addition to the asynchronous API implementation are demos for the asynchronous workflow and a demo for synchronous file download.
All download demos download a file from S3 incrementally using byte range GET method requests.
All upload demos upload a demo configured string to S3 using the PUT method.
Testing can be found in the feat/http_test branch https://github.com/aws/amazon-freertos/tree/feat/http_test.
As changes needed are found during unit testing the branch this PR is based off of will be updated.
Uncrustify of files will happen in a separate PR.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this and redoing with starting with base branch as feat/http instead of master to avoid ugly failing of Code style checks.


Remove assertion non-and parse flag, and tests

Remove the ability to parse assertions with OR nodes. Please don't actually merge this. This is just to validate that these aren't used.

I once had a thought we'd allow keybase id (max || maxtaco@twitter).

Ok I figured, and am not proposing abandoning that. This PR represents me asking CI "is this legit never called?"

And CI has answered in the affirmative.


fix demo for LW at clinic

the demo was returning a not found error before. Make sure we have a demo that does not give a 404.

Looks like that demo view was deleted.
[x] create demo view, require logn, return empty response
[ ] create 10 fake responses
[ ] add pdfhook & adjust heroku setup instructions
[ ] fill out pdf with fake responses
[ ] (stretch) fill out RAP sheet request form.


How to use -f flag correctly?

Thanks a lot for providing this tool! It is actually tremendously helpful for maintaining my Zettelkasten! I just cannot figure out how to use the -f flag to force the file rename and suppress the confirmation. The documentation says:

Asks for confirmation for each rename, unless you specify the flag -f last in the command.

However, when I use the flag like so:
.\noteexplorer --backlinks-heading "## Backlinks"  ./Zettelkasten update-filenames -f
I get this error message:
error: Found argument '-f' which wasn't expected, or isn't valid in this context
USAGE:
noteexplorer.exe update-filenames
Moving the -f flag around to other locations in the call to noteexplorer didn't help either. Could you please elaborate how to use the -f flag correctly?
I am using noteexplorer-win-x64-0.2.1 on Windows 10.

Sorry about that! I never got around to releasing 0.3.0, which is where this flag was introduced.
Please download and try 0.3.0: https://github.com/cdaven/noteexplorer/releases/tag/0.3.0


Remove duplicated code in test runtime

The test runtime duplicates much of its code between std and no_std builds.  I just wasted four or five hours because I had changed the code in one version, but not the other.
We should deduplicate the code so that this does not waste anyone else’s time.

There are reasons we doing this and we try to minimize the amount of duplicate code as much as possible. Everything is wrapped in a cfg_if and nothing is hidden. Based on this, I will close this again.

What you really want is this: https://github.com/paritytech/substrate/issues/1120
Before we did not have any real apis implemented in the test-runtime. Just this TestApi that is strictly required to be implemented differently on std and no_std as we use it to test the runtime api implementation itself.
If you look for example at Grandpa, there we implement the GrandpaTrait manual to make it mockable. The given issue should simplify this mocking, but yeah until now I did not really had time for it. Sorry!


Change default Aladin zoom level?

Would it be beneficial to change the default Aladin zoom level to closer match the angular size of the ATLAS stamps? I would make it easier to register equivalent sources quickly by eye.
Current it defaults to a FoV of 1.19'

but a FoV of 4.83' is a closer match (not sure if it can be set to 5' programmatically)

Thanks for pointing this out! This is a bug caused by my merging of the Pan-STARRS & ATLAS web interface code. The original default zoom level on Aladin did originally match the ATLAS FOV.  (The default zoom level is at Pan-STARRS FOV at the moment!) I'll let you know when it's fixed, so leave this ticket open.

Fixed.