SystemStackError: stack level too deep error while executing import on child class using Single Table Inheritance

require 'mongoid'
Mongoid.connect_to 'articles'

class Article
  include Mongoid::Document

  field :id,    type: String
  field :title, type: String
  field :first_name, type: String
  field :last_name, type: String
  attr_accessible :id, :title, :published_at
  include Elasticsearch::Model

   settings index: { number_of_shards: 1 } do
    mappings dynamic: 'false' do
      indexes :title, analyzer: 'english', index_options: 'offsets'
      indexes :first_name, type: "string"
      indexes :display_name, type: "string", as: "full_name"
    end
  end

  def full_name
    "#{first_name} #{last_name}"
  end

  def as_indexed_json(options={})
    as_json(
	    except: [:id, :_id],
	    methods: [:full_name]
	    )
  end
end

class ChildArticle < Article
end
ChildArticle.create id: '0', title: 'title for test 0', first_name: 'jhon', last_name: 'carter'
ChildArticle.create id: '1', title: 'title for test 1', first_name: 'smith ', last_name: 'jones'

ChildArticle.import    # giving error for child class import
SystemStackError: stack level too deep
from /home/user/.rvm/gems/ruby-2.1.5/gems/pry-0.10.1/lib/pry/pry_instance.rb:355

I have the same problem here and found some stuff... I think it needs to be investigated, support and documentation for child classes with single table are unclear or lacking.
Anyway, if you don't want everything in the same index re-include Elasticsearch::Model in the child classes (ChildArticle in your example) seems to resolve the problem.
Now, if you want to index everything in the parent class (Article here), and want to use Elasticsearch::Model::Callbacks, it seems more complicated:
Article.import will import ChildArticles into the index, but it seems that the callbacks won't maintain the index, so you might need to re-write those. Also, you might want to add the "method" _type in as_indexed_json to use it as a filter.

Hey guys, I'm starting a two week vacation today, so I won't be able to investigate this properly. I agree that STI support is lacking, on the other hand, I don't personally believe in STI too much, so we must find some balance :)
With regards to:

Now, if you want to index everything in the parent class (Article here), and want to use Elasticsearch::Model::Callbacks (...)

Let me just say again that the bundled callbacks module is merely a convenience thing -- you can see even in the README how easy it is to implement indexing by yourself. And of course, any serious application should do that in the background with Sidekiq, Resque, etc.

Thanks for your answer, and enjoy your vacations!

See #144 for a workaround from @jlaw90 -- we need to address it in the gem somehow.

+1 to request support for this feature... @karmi Even if you don't believe in it personally, it's a widely used feature of Mongoid, and this gem supports Mongoid right :)
I'll look at the workaround for now... @karmi Thanks for all your work on this

@rbaghele @TomHoss Keeping this open, and I'll look into it, I think some work has/is being done about inheritance lately.

I was playing with this for almost an hour. The problem is cleary coming from proxying the methods in proxy.rb, but I cannot solve it properly.
There seems to be a practical solution though -- include the module "once again" in the child class. Then the "stack level too deep" problem goes away:
class ChildArticle < Article
  include Elasticsearch::Model
end
``

For whatever reason, though, the documents are not created in Mongo for me:

[1] pry(main)> ChildArticle.create! id: '0', title: 'title for test 0', first_name: 'jhon', last_name: 'carter'
=> #<ChildArticle _id: 0, id: nil, title: "title for test 0", first_name: nil, last_name: nil, _type: "ChildArticle">
[2] pry(main)> ChildArticle.all.to_a
=> []
Can you veryify this somehow?

(sorry for my english) Hi, I had the same problem (i'm working with Postgres/Rails 4), I just solved it by including Elasticsearch::Model (once again) in my child class, as @karmi suggested, now I can search using my STI approach and with many level of nesting. Many thanks!

@Johaned Cool, thanks for the verification! It's of course not a fix, but only a practical solution. I guess we'll have to live with it for a while until a proper solution for the proxying methods is found ( I cannot invest significant time into it right now).


    This simplifies the build logic
as well as paves the road to sub-builds for each target rather than a
monolithic build as we have today.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

CC: @gottesmm @Rostepher

I am all for excising this if we can safely. That being said, I think it is important for @Rostepher to check that we do not have internal dependencies on this right now. If he is busy, I can check as well.

LGTM

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test Linux platform

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 4b9e9d316443f8e797e41562b909d32c4920f340

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 4b9e9d316443f8e797e41562b909d32c4920f340

@swift-ci please test Linux platform


result: 1 of 1 post-start scripts failed. Failed Jobs: elasticsearch.

While deploying logsearch boshrelease, I get the below error but when i do bosh2 -e  -d  vms , it shows me all 6 VM's green, not sure what am i missing?

06:22:54 | Preparing deployment: Preparing deployment (00:00:01)
06:22:56 | Preparing package compilation: Finding packages to compile (00:00:00)
06:22:56 | Updating instance elasticsearch_data: elasticsearch_data/c8633974-12c7-4468-8d70-998a20d7b8e8 (0) (canary) (00:05:47)
L Error: Action Failed get_task: Task b94b276b-8727-4f86-651d-c48472bc8b18 result: 1 of 1 post-start scripts failed. Failed Jobs: elasticsearch.
06:28:43 | Error: Action Failed get_task: Task b94b276b-8727-4f86-651d-c48472bc8b18 result: 1 of 1 post-start scripts failed. Failed Jobs: elasticsearch.

I just had a similar experience. In my case it was caused by me switching stemcell version from the stemcell family specified in manifest.

Please check /var/vcap/sys/log/elasticsearch/post-start.stderr.log on failed node

Hi, i have the same issue as you guys :
Trying to update my logsearch deployment i have the same error :
Error:Action Failed get_task: Task 5880b5d8-c776-44fb-4139-dc03d563d765 result: 1 of 2 post-start scripts failed. Failed Jobs: elasticsearch. Successful Jobs: bosh-dns. Task 383792 | 15:00:13 | Error: Action Failed get_task: Task 5880b5d8-c776-44fb-4139-dc03d563d765 result: 1 of 2 post-start scripts failed. Failed Jobs: elasticsearch. Successful Jobs: bosh-dns
It's seems have no error on the failed node, /var/vcap/sys/log/elasticsearch/post-start.stderr.log is empty.
Any suggestions please?


helm: allow configuration of ipFamilyPolicy

This pull request adds allow configuration of ipFamilyPolicy for the descheduler service.
Since different versions of k8s have different support for ipv6/ipv4 dual stack, it is not enabled by default.

cc @a7i  PTAL

Thank you for the pr @dongjiang1989 In addition to requested changes, would you please squash and sign your commits?

Thanks for your review.
Done. PTAL @a7i

/ok-to-test
/approve

/retest

@dongjiang1989 just curious, why do you use a Service for Descheduler?

@dongjiang1989 just curious, why do you use a Service for Descheduler?

The Open Policy Agent is installed in the online kubernetes cluster. All services must have Dual Stack setting. It does not use this service itself.

Then you should be able to omit creating the Service, correct?

@dongjiang1989 just curious, why do you use a Service for Descheduler?

The Open Policy Agent is installed in the online kubernetes cluster. All services must have Dual Stack setting. It does not use this service itself.

Then you should be able to omit creating the Service, correct?

Hmmm... maybe not. OPA must support Deployment and Service appearing in pairs. 🤔

/lgtm


BITMAKER-2000 Resolve Dependabot Alerts

Description
Resolve Dependa bot observations
Issue
https://tasks.bitmaker.dev/issues/2000
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] My code follows the style guidelines of this project.
[ ] I have made corresponding changes to the documentation.
[ ] New and existing tests pass locally with my changes.
[ ] If this change is a core feature, I have added thorough tests.
[ ] If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
[ ] I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@Adriana618 this PR is now ready to a last review, In addition I went further and fix every warning in yarn installation, now it's alerts free. Also with DependaBot


kitti

Hello, I am a beginner and I have a question for you, about submitting on the official website of kitti dataset to get the test  set results, is there a result.txt file that needs to be submitted, and how do I get this file on my own server?

Follow OpenPCDet repo, you can use --save_to_file True in test.py file to get the test set format result.


The  advanced operator configuration in Packaging an operator for OLM is broken

Bug Report
What did you do?
Click on in the link  advanced operator configuration in https://olm.operatorframework.io/docs/tasks/packaging-an-operator/:

What did you expect to see?
Check the advanced options
What did you see instead? Under which circumstances?
Came back for the same page(on top)

Closing this out as the o-f/olm-docs repository now houses OLM documentation. This link no longer resolves to the task directory -- it looks like an advanced documentation now lives in the advanced-tasks directory.


Add option to persists temp key

saves the temp key in file

@leastprivilege,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Looking at this issue it looks like this was added to v1.4. I've just updated to v1.5 but don't see the AddTemporarySigningCredential overload with the persist parameter. Am I missing something?
Thanks!

Use AddDeveloperSigningCredential


pull request for e2e test at 01/07/2017 09:26:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


remove a condition to ignore placement rule if it contains finalizers

when defining a finalizer on a placement rule (which I think is totally valid) the placement rule is ignored by the controller.
I consulted with @mikeshng and he agreed that this is probably just a legacy placeholder code that should be removed.
we also asked @rokej who didn't have a good explanation why should the placement rule controller ignore CRs if they contain finalizers.
as part of our work with ACM far edge squad on multi cluster management at scale, we're making extensive use of policies and placement rules while defining finalizers and this bug is blocking us.
would appreciate if this PR can be handled asap.

@nirrozenbaum thank you for the PR. As @rokej mentioned, we are waiting for the repo owner to come back from vacation to double check. In the meantime, please use the PR image below to workaround the issue we discussed. Thanks.
docker pull quay.io/open-cluster-management/multicluster-operators-placementrule:2.4.0-PR117-e6a330d58539f84e308e12152e0d27ff1a410dde


CleanupManager: only cleaning yarn-apps of executions that are canceled by user or is EXECUTION_STOPPED

Why we need this
To fix an design fault that kills the yarn-apps of jobs defined to be "Finish Current Running" or "Finish All Possible".
What's done
Removed "FAILED/FAILED_FINISHING/FAILED_SUCCEEDED" from to-be-cleaned statuses for yarn-app-kill task.
Tests done

unit test
tested in staging cluster

To fix an design fault that kills the yarn-apps of jobs defined to be "Finish Current Running" or "Finish All Possible".

What happens if we don't have this PR? I think FAILED jobs are still okay to be yarn-cleaned?

To fix an design fault that kills the yarn-apps of jobs defined to be "Finish Current Running" or "Finish All Possible".

What happens if we don't have this PR? I think FAILED jobs are still okay to be yarn-cleaned?

This assumption was exactly the mistake we made.
The idea is that, if there's an executionX, it failed because its job1 failed, but job2, job3... are config to be "finish all running", and we kill all the yarn apps of X, then job2 and job3 will also failed, breaking the idea of "finish all running".

This assumption was exactly the mistake we made.

Got it. It makes sense to me now. One more Q: If execution is FAILED, will job2, job3... are possibly Running still due to "finish all running" or they must have been FAILED before the execution is marked as FAILED?

This assumption was exactly the mistake we made.

Got it. It makes sense to me now. Thanks for your elaboration!
One more Q: If execution is FAILED, are job2, job3... possibly RUNNING still due to "finish all running" config or they must have been FAILED before the execution is marked as FAILED?
Curious why ".put(Status.FAILED, new Pair<>(Duration.ofMinutes(recentTerminationValidity), UPDATE_TIME))" line is removed.

I think in some cases, one job failed will mark the execution "FAILED", and the execution's other RUNNING jobs defined with "Finish Current Running" or "Finish All Possible" will keep running until finish (no matter they succeed or fail).


Add json_render decorator

Glancing through https://github.com/skorokithakis/django-annoying/blob/master/annoying/decorators.py#L155 and it could be a starting place, but https://docs.djangoproject.com/en/4.0/ref/request-response/#jsonresponse-objects might be a different approach? There is also https://github.com/jsocol/django-jsonview, but it seems to do a lot. I should look through the code some more, though.

Done in https://github.com/adamghill/django-fbv/commit/ef3dc8f2b6b3a8153677c97b168a7614c29da66e.


bug: original_dst filter should update downstream local address

Prior to https://github.com/envoyproxy/envoy/pull/12935, the socket address was already updated before constructing stream info. Now that stream info is created ahead of listener filters, the value for the downstream socket address changed.

It affects logging mostly, but may also affect RBAC policies if they reference destination address. I think istio is the most affected downstream project as a heavy user of original_dst.

FWIW I would really love to have an integration test here, I just don't know if it's technically possible.


Required boolean field set to false is invalid

Current Behavior
With the schema below, the field active is removed when the switch is set to false. The data validation then fails, as the field must be given. The boolean can thus only be true. This is in line with documentation.
Expected Behavior
It should be possible to set a required boolean field to false. Other JSON schema validators validate both cases of data (true/false) given below. Also, otherwise, boolean does not really make sense, as only a constant value (true) is accepted.
Steps to Reproduce
Steps:

Paste Schema into Live Editor
Toggle active to false
"failed data validation" appears

Context
Schema:
{
  "type": "object",
  "required": [
    "active"
  ],
  "properties": {
    "active": {
      "type": "boolean"
    }
  }
}

Valid data:
{ "active": true }
{ "active": false }
Your Environment

Tech
Version

UI-Schema
v0.4.4

This comes from the "what is required in HTML-Forms", UI-Schema includes some special value-update handling for the required keyword.
e,g, an "unchecked checkbox" would be invalid for <input type="checkbox" required/>.
Atm. implemented here, which get's an rework in 0.5.0 to make those "value behaviour changes" as plugins.
In the widget, the required is passed to the update action.
If you don't want that, the current easiest way would be to remove required from the actions inside your onChange.
const onChange = React.useCallback((actions) => {
    if(!Array.isArray(actions)) {
        actions = [actions]
    }
    actions = actions.map(action => {
        if(action.required) {
            delete action.required
        }
        return action
    })
    setStore(storeUpdater(actions))
}, [setStore])


Bower main attribute is missing reference to css file

This should be an easy fix. I'll try to do the PR myself. Essentially the bower.json file should be changed to
"main": [
  "./dist/angular-tour-tpls.min.js",
  "./dist/angular-tour.css"
],

as opposed to what it is now
"main": "./dist/angular-tour-tpls.min.js",

Why is this important? When you run automated tasks like Grunt's wiredep it looks at this attribute to automatically generate your link and script tags, and the absence of it forces you to manually add the missing link tag every time a task runs.

Thanks!

Merge #65 fixes this.


portal, server & datastore fail on first install attempt

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

3.1.1

Affected Resource(s)

ArcGIS_Server
ArcGIS_Portal
ArcGIS Data Store

Configuration Files

1_portal_&_hosting.txt
Expected Behavior
Portal, Server and Datastore components install successfully.
Actual Behavior
Portal, Server and Datastore components fail to install. But if another script is run again with the same component, it successfully installs the second time.
Steps to Reproduce
Provision new Azure servers then run the DSC scripts.
Important Factoids
Running in Azure.
References
First install attempt:
ArcGISInstall-1-Verbose.txt
ArcGISInstall-1-19-2021-6-46-35-PM-Error.txt
Second attempt success:
ArcGISInstall-2-Verbose.txt
The same behavior is for ArcGIS server and datastore.

Hi @elwoodhouse,
Based on the initial logs I suspect the portal setup exited silently prior to finishing the installation. The module may not catch the error because the setup is being ran silently (/qn), therefore if the setups fails an error isn't thrown. When this happens I recommend checking the Windows Event Application logs to see if there is an msi related error. One possibility is an msi collision with a process running in the background.
Few other observations\comments:
Looks like module v2.1.1 is being used to install ArcGIS Enterprise 10.6.1. If possible, I recommend using our latest module v3.1.1 as it includes allot of improvements over v2.1.1. For example, it no longer uses 7Zip to extract the setup achieves, and also allows you to specify different username/password for portal and server. However, keep in mind though that a few changes will need to be made to your existing json file.
Here are some resources to help with transitioning to v3.1.1:
Variables used in V3:
https://github.com/Esri/arcgis-powershell-dsc/wiki/V3.-Variables-reference-page-for-JSON-configuration-files
Portal/Server Administrator Account examples:
https://github.com/Esri/arcgis-powershell-dsc/wiki/ArcGIS-Server-Primary-Administrator-Account-and-Portal-for-ArcGIS-Initial-Administrator-Account-variables
V3. Command Line Parameters:
https://github.com/Esri/arcgis-powershell-dsc/wiki/PowerShell-DSC-ArcGIS-Module-Command-Line-Parameters
V3. Sample Config for Multi-machine deployment:
https://github.com/Esri/arcgis-powershell-dsc/blob/master/SampleConfigs/v3/Base Deployment/BaseDeployment-MultiMachine.json

Note none of the modules currently support importing an ssl certificate into Data Store, so this can be removed from the json:

"SslCertificates" : [
                {
                    "Path" : "C:\\ArcGIS\\Certificates\\Wildcard-TST.pfx" ,
                    "Password" : "#{wildCardCertificateName}#" ,
                    "Alias" : "#{dataStore2}#" ,
                    "Target" : [ "DataStore" ]
                }
            ]

I also wouldn't recommend storing the portal content dir inside the install dir:
"ContentDirectoryLocation" : "C:\\Program Files\\Esri\\ArcGIS\\Portal\\Content\\arcgisportal\\content" ,
"ContentDir" : "C:\\Program Files\\Esri\\ArcGIS\\Portal\\Content"

I would recommend something like this:
"ContentDirectoryLocation" : "C:\\arcgisportal\\content" ,
"ContentDir" : "C:\\arcgisportal"

Hope this helps!
Thanks,
Cameron K.

Hi @elwoodhouse,
Based on the initial logs I suspect the portal setup exited silently prior to finishing the installation. The module may not catch the error because the setup is being ran silently (/qn), therefore if the setups fails an error isn't thrown. When this happens I recommend checking the Windows Event Application logs to see if there is an msi related error. One possibility is an msi collision with a process running in the background.
Few other observations\comments:
Looks like module v2.1.1 is being used to install ArcGIS Enterprise 10.6.1. If possible, I recommend using our latest module v3.1.1 as it includes allot of improvements over v2.1.1. For example, it no longer uses 7Zip to extract the setup achieves, and also allows you to specify different username/password for portal and server. However, keep in mind though that a few changes will need to be made to your existing json file.
Here are some resources to help with transitioning to v3.1.1:
Variables used in V3:
https://github.com/Esri/arcgis-powershell-dsc/wiki/V3.-Variables-reference-page-for-JSON-configuration-files
Portal/Server Administrator Account examples:
https://github.com/Esri/arcgis-powershell-dsc/wiki/ArcGIS-Server-Primary-Administrator-Account-and-Portal-for-ArcGIS-Initial-Administrator-Account-variables
V3. Command Line Parameters:
https://github.com/Esri/arcgis-powershell-dsc/wiki/PowerShell-DSC-ArcGIS-Module-Command-Line-Parameters
V3. Sample Config for Multi-machine deployment:
https://github.com/Esri/arcgis-powershell-dsc/blob/master/SampleConfigs/v3/Base Deployment/BaseDeployment-MultiMachine.json

Note none of the modules currently support importing an ssl certificate into Data Store, so this can be removed from the json:

"SslCertificates" : [
                {
                    "Path" : "C:\\ArcGIS\\Certificates\\Wildcard-TST.pfx" ,
                    "Password" : "#{wildCardCertificateName}#" ,
                    "Alias" : "#{dataStore2}#" ,
                    "Target" : [ "DataStore" ]
                }
            ]

I also wouldn't recommend storing the portal content dir inside the install dir:
"ContentDirectoryLocation" : "C:\\Program Files\\Esri\\ArcGIS\\Portal\\Content\\arcgisportal\\content" ,
"ContentDir" : "C:\\Program Files\\Esri\\ArcGIS\\Portal\\Content"

I would recommend something like this:
"ContentDirectoryLocation" : "C:\\arcgisportal\\content" ,
"ContentDir" : "C:\\arcgisportal"

Hope this helps!
Thanks,
Cameron K.

Thanks for the quick response Cameron. I have asked the client to upgrade to v3.1.1, knowing how I can tell in the logs when that happens through 7zip will help.
I'll review the windows logs and report back if after upgrading we encounter that same issue.
Cheers,
Leon.

Thanks for the quick response Cameron. I have asked the client to upgrade to v3.1.1, knowing how I can tell in the logs when that happens through 7zip will help.
I'll review the windows logs and report back if after upgrading we encounter that same issue.
Cheers,
Leon.

Starting in v3.2.0, We have added -EnableMSILogging switch to help capture silent installation logs of the setups.
https://github.com/Esri/arcgis-powershell-dsc/wiki/PowerShell-DSC-ArcGIS-Module-Command-Line-Parameters#parameters
Invoke-ArcGISConfiguration -ConfigurationParametersFile C:\config\BaseDeployment.json -Mode InstallLicenseConfigure -EnableMSILogging

https://github.com/Esri/arcgis-powershell-dsc/releases/tag/v3.2.0


Create Issue template

Create Issue template for Issues.
Get help from my UEMCRP project.
Don't blindly copy paste, make necessary changes.

I'd like to work on this, can you please assign it to me?

Please make sure to star this repo. It needs it


fqdn: Correctly set request/response in DNS monitor events

This is not a release blocker. The json monitor output will contain the correct information(apart from the flowtype)

This change is

test-me-please

Coverage increased (+0.02%) to 42.973% when pulling 96d972aed173ccf209ab5d68a9c23142ac999f32 on raybejjani:fqdn-monitor-print-response into 76e4a5bbb25dd0a737029766b0b40603049b2176 on cilium:master.


scroll wheel not working

Microsoft PowerToys version
v0.47.0
Running as admin

[x] Yes

Area(s) with issue?
Settings
Steps to reproduce
Open settings and try to scroll with scroll wheel or touchpad gestures
✔ Expected Behavior
the page start to scrolling
❌ Actual Behavior
Nothing happened
Other Software
No response

xref #3400

Hi @payambordbar, can you file a Windows Feedback item under Input and Lanugage\Mouse category and add a “Recreate my problem” repro trace and then paste the feedback link here?  That will give us the deeper data we need and can forward to appropriate team.

Hi @crutkas, feedback hub is not available in my region.

Ok, i find something
This problem only occurs when "X-Mouse Button Control" is running.
"PowerToys" is not the only program affected; "Windows terminal" and "Files" are also affected.

Confirmed, this is caused by X-Mouse Button Control. Workaround - create an XMBC profile for Powertoys (you may have to do this for more than one instance of it - it was "powertoys.exe", "powertoys.settings.exe" and "powertoys.keyboardmanagereditor.exe" in my case - might add more of them later if I notice the scrollwheel still not working someplace in Powertoys) and in the Options tab, check the "Disable Scroll Windows Under Cursor" checkbox. SOLVED :)


Run devnet in CI

Summary of changes

Changes introduced in this pull request:

Forest binaries are re-used and used in building the Forest CI image. This adds minimal overhead.
pre-built the Lotus image to https://github.com/orgs/ChainSafe/packages/container/package/lotus-devnet. Building it in the CI adds 15 minutes to the job duration, which is not worth it for the sake of having everything built in the CI at every commit (or even push to main). I moved it into a triggerable workflow.
check - check if Forest can get past the genesis block.

We could think of manually grabbing param files, but at the moment, it seems reasonable enough.

Reference issue to close (if applicable)

Closes https://github.com/ChainSafe/forest/issues/3034
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

It will be great if we could run devnet check in gen_coverage_report.sh to increase codecov of forest networking layer

It'd require quite a bit of tinkering for no big gain - I believe we'd only additionally catch the additional devnet parameters setting.


Remove direct coupling of opencensus

Closes #69
Thanks @peterbourgon

Decided to revert this since we're still going to depend on opencensus everywhere and tracing is something that should be explicitly part of SinkEntry imo since every logger should try and support it.


stratos can push docker app?

Deployment type
(select the type below by replacing the space with an x)

[x ] Cloud Foundry Application (cf push)
[ ] Kubernetes, using a helm chart
[ ] Docker, using docker compose
[ ] Docker, single container deploying all components
[ ] Other (please provide below)

Expected behaviour
docker app push
Actual behaviour
stage failure
Steps to reproduce the behavior
https://github.com/marcus-sds/cf-docker-cli.git

Hi @marcus-sds . Thanks for raising this issue. Before we tackle this we'd like to clarify a few things.

You have deployed the Stratos console to CF via cf push
You have done the above from the master branch
The issue raised is a failure to deploy the app at https://github.com/marcus-sds/cf-docker-cli.git using the Stratos 'Deploy` feature?

If the above points are correct, does the app at https://github.com/marcus-sds/cf-docker-cli.git successfully deploy to the same CF when using the CF cli directly?

On Feb 26, 2018 19:46, "Richard Cox"<EMAIL_ADDRESS>wrote:
Hi @marcus-sds https://github.com/marcus-sds . Thanks for raising this
issue. Before we tackle this we'd like to clarify a few things.

You have deployed the Stratos console to CF via cf push

-> right

You have done the above from the master branch

-> yes

The issue raised is a failure to deploy the app at
https://github.com/marcus-sds/cf-docker-cli.git
https://github.com/marcus-sds/cf-docker-cli.git using the Stratos
'Deploy` feature

If the above points are correct, does the app at
https://github.com/marcus-sds/cf-docker-cli.git successfully deploy to the
same CF when using the CF cli directly?
-> yes. cf push with recent cf cli is working.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry-incubator/stratos/issues/1664#issuecomment-368460943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVx7oTQKYgDhIr7VhQ1gilIS8mkKKQG8ks5tYouHgaJpZM4SRw5J
.

this has been fixed in V2 https://github.com/cloudfoundry-incubator/stratos/pull/2059

Closing - fixed in V2


Flexible maintainers CD Workflow

This PR introduces a change in the cd.yml Workflow.
We release our components versions using the tags v*
The process of release has two steps:

Run the functional tests (FT) using the component to be released v* tag (from main branch) against the latest releases of the components.
If the (FT) finishes successfully, the cd.yml releases the new Docker Image GitHub Registry and adds it to our Releases page in Github. (Python package in case of the CLI).

If step 1 fails, the release breaks the compatibility with the current release.
The problem we are solving is how to release a new version when it breaks the compatibility.
This PR adds the workflow dispatch option for releases.
The maintainers can now go to the Actions > CD > Run Workflow, choose the v* tag release, and specify the version of the components it is compatible with, including dev (main branch) to run the FT tests.
Using the Workflow dispatcher process, the Maintainers should bump to a version that shows it is breaking compatibility and make it clear on the release page.
We have a Release Process and we are not changing it, only adding the Workflow that allows those actions.

It was little confusing to review this pr as it had multiple commits that could be squashed into one. A clear example of that are commits: c9fc19b, 47eae6d and b447aff which can be squashed/ammended into one.

When I see a reasonable amount of commits I like to review them one by one in order to get an understanding of the flow of thoughts that lead to the final change. A couple of times I left a pending comment on one of your commits just to see that the thing I was asking for was removed in the next commit.

Yes, I can squashe them. This is because you need the commits to be able to test, re-test, do again as the GH Actions there is not a playground and real test is a required :/

I will move this PR to Draft, I will need to test it again applying what I mentioned above.

Codecov Report
Base: 93.77% // Head: 93.77% // No change to project coverage :thumbsup:

Coverage data is based on head (0d6f32e) compared to base (8b3c25b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   93.77%   93.77%
=======================================
  Files          16       16
  Lines         610      610
=======================================
  Hits          572      572
  Misses         38       38

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Minor cleanup to the console view

Removed some debug text
Added missing newlines
Added auto-scroll

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io


add support to read all rooms

HUBOT_CHATWORK_ROOMS=0 scans for all rooms in which the bot is on each request.

Please give me some days to check it.

I'm sorry, I'm not going to merge this PR.
Because I think it's dangerous in some case.
Ex:
If there are 100 members in a company,
Hubot must scan over 100 rooms(within direct chat rooms) per minute.
That needs too much resource and chatwork API limits.


How to implement a custom reporter and set it?

There is an option to set the custom reporter, but currently I don't see a simple way to implement a reporter and have it required. Having it defined in the helper does... not help!
bundle exec tldr --reporter TLDR::Reporters::Mini

.gem/ruby/3.3.0/gems/tldr-0.10.0/lib/tldr/argv_parser.rb:62:in `block (2 levels) in parse': uninitialized constant TLDR::Reporters::Mini (NameError)

          options[:reporter] = Kernel.const_get(reporter)

I don't think any have been created, but in that example you'd probably need to run the tldr CLI with ruby such that it loaded that class before running TLDR's code


New DateTime.CurrentTimeTimestamp sniff

This new sniff adds a check for use of current_time() to retrieve a timestamp.
A (fixable) error will be thrown when the $gmt parameter is set to true or 1, a warning when it is not.
Includes unit tests.
Includes fixer.
Includes documentation.
This new sniff has been added to the Core ruleset.
Fixes #1791
/cc @Rarst

@Rarst Looking at your blogpost at Make, should this sniff also check for get_post_time( 'U' ) ?

should this sniff also check for get_post_time( 'U' )

Uh... Maybe later. We hadn't scraped those out of core yet. Want to just let release go out and dust settle for a bit right now. :)

Uh... Maybe later. We hadn't scraped those out of core yet.

That shouldn't really be a consideration.
If that code pattern shouldn't be used, we can already start throwing errors/warnings for it.
As long as we don't make the error/warning auto-fixable, the Core builds won't fail on it (and it will help detect the issue in Core).

That shouldn't really be a consideration.
If that code pattern shouldn't be used, we can already start throwing errors/warnings for it.

Well, it is for me. Getting these things out of core is a necessary legwork to figure out what depends on it and what needs to be done to dump it in all (or at least a lot of) cases.
My opinion is that we hadn't done equivalent amount of work to get rid of that one and are not ready to start sniffing it out. Soft recommendation to start using replacements takes a lower level of confidence than a hard sniff for me.

Soft recommendation to start using replacements takes a lower level of confidence than a hard sniff for me.

Ok, fair enough. We can always add it at a later point in time.

Rebased for merge conflict.

Anything I can do to move this PR forward ?


Solved #2022- hexsweep game

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes:  #(issue no.)
#2022

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy
Kindly review and merge


Allow CommonMark in the description

In STAC we usually allow Common Mark in the description fields, it weould be nice to add that here as well.
Simply add  [CommonMark 0.29](http://commonmark.org/) syntax MAY be used for rich text representation. to the description of the description field :-)

Urks, I acceidently hit Enter too early and now it is committed already to main instead of creating a PR.
I can revert if desired: https://github.com/stac-extensions/classification/commit/7bbe0bf17997ab8f9142913b4abbdf1f1ff966e1

No worries!

Cleaned-up main and created a PR instead.


FDCAN (CAN-FD) peripheral support on STM32 (G0, G4, H5, L5, U5 and H7)

Many STM32 devices with "generic" CAN2.0 peripheral are currently supported via the bxcan library. The ones listed in the title have a different peripheral. Additionaly the H7 is a bit different flavor because why not. Those FDCAN peripherals are currently not supported.
There's plenty of semi-coordinated progress on making the FDCAN embassy driver and many partial not-merged solutions. I've created this issue to summarize all information I could gather.

There's a DRAFT pull-request focusing on H7: https://github.com/embassy-rs/embassy/pull/1692/files last changes 07.2023.
There's some work by @tcbennun  for other non-H7 devices from 21.11.2023:
https://github.com/MaxiluxSystems/embassy/blob/feature/fdcan/embassy-stm32/src/can/fdcan.rs
https://github.com/tcbennun/embassy-fdcan-mvp/blob/master/src/main.rs
Which was a basis for some other forks.
TheEppcJR from 08.12.2023 made some corrections to tcbennun. Commit descriptions aren't really certain about the change though. ;)
https://github.com/TheEppicJR/embassy-fdcan-mvp/blob/h750-can-test/Cargo.toml
https://github.com/TheEppicJR/embassy/commits/fdcan-exports/
There's work by Adam Morgan based on tcbennun change from 21.12.2023, which mentions G4:
https://github.com/lucimobility/embassy/tree/feature/rebased-fdcan

So my current understanding is to go with the (1) if using H7 or probably (4) if using the rest of devices. But I can't be sure. In near future I'll try (4) with stm32g431 and see how it goes.

I gathered changes from (2) and (4) on new branch to create something that might be mergeable - no debug prints, cleanly split commits, no commented code. Moved the example from FDCAN2/3 to FDCAN1. It compiles example for stm32g4, I haven't yet tried it on hardware.
Lacking:

stm32h7 example and maybe some changes (rcc?). Maybe from (1).
Docs; there's plenty of warnings about missing docs. I can probably fill those if this approach makes sense.

https://github.com/blaa/embassy/commits/feature/fdcan/
Two not included parts (were commented) are:
+    /*
+    pub async fn flush(&self, mb: bxcan::Mailbox) {
+        poll_fn(|cx| {
+            T::state().tx_waker.register(cx.waker());
+            if T::regs().tsr().read().tme(mb.index()) {
+                return Poll::Ready(());
+            }
+
+            Poll::Pending
+        })
+        .await;
+    }*/

+// TODO: impl Drop prevents us from changing modes without dropping the old one.
+//  there is a solution here but I need to think about it more
+/*
+impl<'d, T: Instance, M: FdcanOperatingMode> Drop for Fdcan<'d, T, M> {
+    fn drop(&mut self) {
+        // Cannot call `free()` because it moves the instance.
+        // Manually reset the peripheral.
+        T::regs().cccr().write(|w| w.set_init(true));
+        T::disable();
+    }
+}
+ */
+

@blaa let myself and @aaamorgan know if you need a hand reviewing or implementing anything for this. We are quite interested in getting what we built in (4) above merged in and if you have combined those forks that seems like a good place to start working from.
Happy to help with docs, test code, and any hardware testing that's needed. We have hardware that has a G4 with two transceivers that can be setup to talk to each other if that helps any for testing.

Hi have been kicking this can a little further down the road at: https://github.com/embassy-rs/embassy/compare/main...cschuhen:embassy:feature/fdcan
I added a HIL (internal loopback) test and added basic documentation for all of the public's that needed it. Tonight (Brisbane time) I intend to clean the changesets up a bit, squishing and reverting some of my own testing changes.
Hopefully then it will be in shape to PR and get opinions from the core embassy developers.

Heh, just an hour minutes ago I started documenting this code. I'll stop and leave it to you then - maybe add some comments somewhere (maybe here). If you wish I can create PR later or leave it to you - as you wish.
I've checked two TODOs in comments and added additional docs to Bit0Error and Bit1Error.
My partial diff follows
diff --git a/embassy-stm32/src/can/bxcan.rs b/embassy-stm32/src/can/bxcan.rs
index cc87b256..96f12584 100644
--- a/embassy-stm32/src/can/bxcan.rs
+++ b/embassy-stm32/src/can/bxcan.rs
@@ -16,6 +16,8 @@ use crate::rcc::RccPeripheral;
 use crate::time::Hertz;
 use crate::{interrupt, peripherals, Peripheral};

+use super::calc_bit_timings;
+
 /// Contains CAN frame and additional metadata.
 ///
 /// Timestamp is available if `time` feature is enabled.
diff --git a/embassy-stm32/src/can/fdcan.rs b/embassy-stm32/src/can/fdcan.rs
index 08f3398a..9c54ca15 100644
--- a/embassy-stm32/src/can/fdcan.rs
+++ b/embassy-stm32/src/can/fdcan.rs
@@ -18,17 +18,25 @@ use crate::interrupt::typelevel::Interrupt;
 use crate::rcc::RccPeripheral;
 use crate::{interrupt, peripherals, Peripheral};

+// as far as I can tell, embedded-hal/can doesn't have any fdcan frame support
+/// CAN frame (header + data) upon reception.
 pub struct RxFrame {
+    /// CAN Header
     pub header: RxFrameInfo,
+    /// CAN or FDCAN (8-64 bytes) of data
     pub data: Data,
 }

+/// CAN frame that will be transmitted.
 pub struct TxFrame {
+    /// CAN Header
     pub header: TxFrameHeader,
+    /// CAN or FDCAN (8-64 bytes) of data
     pub data: Data,
 }

 impl TxFrame {
+    /// Validate input data and return new TxFrame.
     pub fn new(header: TxFrameHeader, data: &[u8]) -> Option<Self> {
         if data.len() < header.len as usize {
             return None;
@@ -51,10 +59,12 @@ impl TxFrame {
         Some(TxFrame { header, data })
     }

+    /// Access frame data (without a CAN header)
     pub fn data(&self) -> &[u8] {
         &self.data.bytes[..(self.header.len as usize)]
     }
 }
+
 impl RxFrame {
     pub(crate) fn new(header: RxFrameInfo, data: &[u8]) -> Self {
         let data = Data::new(&data).unwrap_or_else(|| Data::empty());
@@ -62,6 +72,7 @@ impl RxFrame {
         RxFrame { header, data }
     }

+    /// Access frame payload
     pub fn data(&self) -> &[u8] {
         &self.data.bytes[..(self.header.len as usize)]
     }
@@ -91,6 +102,7 @@ impl Data {
         Some(Self { bytes })
     }

+    /// Access internal raw bytes.
     pub fn raw(&self) -> &[u8] {
         &self.bytes
     }

(...)

#[derive(Debug)]
+/// Possible CAN Bus errors.
 pub enum BusError {
+    /// Error: More than 5 equal bits in sequence are not allowed on the bus.
     Stuff,
+    /// Error: Fixed part of received frame was invalid.
     Form,
+    /// Error: Transmitted messages was not acked.
     Acknowledge,
+    /// Error: Error during transmit: sent dominant but read recessive.
     BitRecessive,
+    /// Error: Arbitration error during transmit: sent recessive but read dominant.
     BitDominant,
+    /// Error: Invalid CRC of received message.
     Crc,
+    /// Error: Other software error
     Software,
+    /// Error: Bus is in off state.
     BusOff,
+    /// Error: Bus is in passive state.
     BusPassive,
+    /// Error: Bus is in warning state.
     BusWarning,
 }

@@ -185,8 +216,10 @@ impl BusError {
     fn try_from(lec: LastErrorCode) -> Option<BusError> {
         match lec {
             LastErrorCode::AckError => Some(BusError::Acknowledge),
-            LastErrorCode::Bit0Error => Some(BusError::BitRecessive), // TODO: verify
-            LastErrorCode::Bit1Error => Some(BusError::BitDominant),  // TODO: verify
+            // `0` data bit encodes a dominant state. `1` data bit is recessive.
+            // Bit0Error: During transmit, the node wanted to send a 0 but monitored a 1
+            LastErrorCode::Bit0Error => Some(BusError::BitRecessive),
+            LastErrorCode::Bit1Error => Some(BusError::BitDominant),
             LastErrorCode::CRCError => Some(BusError::Crc),
             LastErrorCode::FormError => Some(BusError::Form),
             LastErrorCode::StuffError => Some(BusError::Stuff),

Those two functions might need re-adding:
@@ -409,11 +450,24 @@ impl<'c, 'd, T: Instance, M: fdcan::Transmit> FdcanTx<'c, 'd, T, M> {

             // Couldn't replace any lower priority frames.  Need to wait for some mailboxes
             // to clear.
+            debug!("fdcan: tx full, pending");
             Poll::Pending
         })
         .await
     }

+    /* TODO:
+    pub async fn flush(&self, mb: bxcan::Mailbox) {
+        poll_fn(|cx| {
+            T::state().tx_waker.register(cx.waker());
+            if T::regs().tsr().read().tme(mb.index()) {
+                return Poll::Ready(());
+            }
+
+            Poll::Pending
+        })
+        .await;
+    }*/
 }

 #[allow(dead_code)]
@@ -469,6 +523,20 @@ impl<'c, 'd, T: Instance, M: fdcan::Receive> FdcanRx<'c, 'd, T, M> {
         None
     }
 }
+
+// TODO: impl Drop prevents us from changing modes without dropping the old one.
+//  there is a solution here but I need to think about it more
+/*
+impl<'d, T: Instance, M: FdcanOperatingMode> Drop for Fdcan<'d, T, M> {
+    fn drop(&mut self) {
+        // Cannot call `free()` because it moves the instance.
+        // Manually reset the peripheral.
+        T::regs().cccr().write(|w| w.set_init(true));
+        T::disable();
+    }
+}
+ */
+
 impl<'d, T: Instance, M: FdcanOperatingMode> Deref for Fdcan<'d, T, M> {
     type Target = RefCell<fdcan::FdCan<FdcanInstance<'d, T>, M>>;

I have pushed more changesets and opened a PR but CI is failing.

I have cleaned up the PR.

I have pushed some more fixes after review comments.
Also, for those interested, I have a few more experimental changesets here on my fdcan_experimental branch: https://github.com/cschuhen/embassy/tree/feature/fdcan_experimental I was planning to leave these until after the main merge.

I have pushed some more fixes after review comments.
Also, for those interested, I have a few more experimental changesets here on my fdcan_experimental branch: https://github.com/cschuhen/embassy/tree/feature/fdcan_experimental I was planning to leave these until after the main merge.

This branch is redundant now. The important bits were merged into fdcan_r2

@blaa Can this be closed now?

For those interested, follow up PR:
https://github.com/embassy-rs/embassy/pull/2571


Slightly reword Javadoc on SpanBuilder#startScopedSpan.

FWIW, I've reused parts of SpanBuilder#startScopedSpan's Javadoc in https://github.com/census-instrumentation/opencensus-java/pull/766/files#diff-cdc21ce534c8e27c5a611a054d00c6a2R70, but reworded it only slightly. Sound better to me, but then again, English is not my first language.

Coverage remained the same at 80.12% when pulling f1360647fba5eec2852d06eabcd3b8187e32b5b2 on ubschmidt2:doc into dee6028822848588f05e04fadf00c5a4f7a336e1 on census-instrumentation:master.

Codecov Report

Merging #788 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #788      +/-   ##
===========================================
- Coverage     78.13%   78.1%   -0.03%
  Complexity      834     834
===========================================
  Files           152     152
  Lines          3682    3682
  Branches        349     349
===========================================
- Hits           2877    2876       -1
  Misses          732     732
- Partials         73      74       +1

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/io/opencensus/trace/SpanBuilder.java
72.72% <ø> (ø)
2 <0> (ø)
:arrow_down:

...census/implcore/trace/export/SpanExporterImpl.java
96.66% <0%> (-1.67%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee6028...f136064. Read the comment docs.


Fix/padded scaling

to be merged after #114 (because of the API change)
closes #100

Codecov Report

Merging #116 (588e136) into main (6c5cd31) will decrease coverage by 0.60%.
The diff coverage is 70.62%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   84.35%   83.75%   -0.61%
==========================================
  Files          42       42
  Lines        3919     4008      +89
  Branches      449      457       +8
==========================================
+ Hits         3306     3357      +51
- Misses        510      547      +37
- Partials      103      104       +1

Impacted Files
Coverage Δ

ott/core/gromov_wasserstein.py
98.09% <ø> (ø)

ott/geometry/low_rank.py
80.59% <35.13%> (-15.90%)
:arrow_down:

ott/core/bar_problems.py
48.63% <50.00%> (ø)

ott/geometry/geometry.py
84.64% <78.26%> (-1.02%)
:arrow_down:

ott/geometry/pointcloud.py
82.82% <79.31%> (-0.84%)
:arrow_down:

ott/core/segment.py
72.54% <100.00%> (ø)

ott/tools/sinkhorn_divergence.py
100.00% <100.00%> (ø)


Bug: sqlalchemy.exc.ArgumentError: Strings are not accepted for attribute names in loader options; please use class-bound attributes directly.

Summary
An error is thrown when there is a relationship in an sqlalchemy based model. The following is the stack trace:
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/starlette_admin/base.py", line 366, in _render_detail
    obj = await model.find_by_pk(request, pk)
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/starlette_admin/contrib/sqla/view.py", line 213, in find_by_pk
    stmt = stmt.options(joinedload(field.name))
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/sqlalchemy/orm/strategy_options.py", line 2359, in joinedload
    return _generate_from_keys(Load.joinedload, keys, False, kw)
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/sqlalchemy/orm/strategy_options.py", line 2261, in _generate_from_keys
    raise sa_exc.ArgumentError(
sqlalchemy.exc.ArgumentError: Strings are not accepted for attribute names in loader options; please use class-bound attributes directly.

Reproduction steps
Sample sqlalchemy models:
from sqlalchemy import ForeignKey, Integer, String
from sqlalchemy.ext.declarative import as_declarative, declared_attr
from sqlalchemy.orm import Mapped as T
from sqlalchemy.orm import mapped_column as column
from sqlalchemy.orm import relationship

@as_declarative()
class Base:
    id: Any
    __name__: str

    # Generate __tablename__ automatically
    @declared_attr
    def __tablename__(cls) -> str:
        return cls.__name__.lower()

class Parent(Base):
    id: T[int] = column(primary_key=True, autoincrement=True)
    name: T[str] = column(String(100))
    children: T[list["Child"]] = relationship(back_populates="parent")

class Child(Base):
    id: T[int] = column(primary_key=True, autoincrement=True)
    name: T[str] = column(String(100))
    parent_id: T[int] = column(ForeignKey("parent.id", ondelete="CASCADE"))
    parent: T[Parent] = relationship(back_populates="children")

Register models:
from starlette_admin.contrib.sqla import ModelView

admin.add_view(ModelView(Parent))
admin.add_view(ModelView(Child))

Open the admin and try to do some crud operations. This will result in an error.
Environment

Starlette-Admin 0.5.5
ORM/ODMs: SQLAlchemy 2.0.5.post1

Additional context
Following is what I have found from PDB:
(Pdb) field.name
'children'
(Pdb) l
206  	       )
207
208  	   async def find_by_pk(self, request: Request, pk: Any) -> Any:
209  	       session: Union[Session, AsyncSession] = request.state.session
210  	       stmt = select(self.model).where(self._pk_column == self._pk_coerce(pk))
211  ->	       for field in self.fields:
212  	           if isinstance(field, RelationField):
213  	               try:
214  	                   stmt = stmt.options(joinedload(field.name))
215  	               except:
216  	                   breakpoint()
(Pdb) stmt.options(joinedload(field.name))  # Gives error
*** sqlalchemy.exc.ArgumentError: Strings are not accepted for attribute names in loader options; please use class-bound attributes directly.
(Pdb) stmt.options(joinedload(getattr(self.model, field.name)))  # Works
<sqlalchemy.sql.selectable.Select object at 0x7f10ab5fcb50>

I also get the same error at:
  File "/home/user/.cache/pypoetry/virtualenvs/project-bghs2piA-py3.10/lib/python3.10/site-packages/starlette_admin/contrib/sqla/view.py", line 198, in find_all
    stmt = stmt.options(joinedload(field.name))

I think there are many places where this needs to be fixed.

It's already fixed in #113 and now released in 0.6.0


0.91 Run as Administrator -> Failed to load kernel driver.

Clicked "Run as Administrator" and get this message:
---------------------------
Registry Explorer
---------------------------
Failed to load kernel driver. Some keys will be inaccesible
---------------------------
OK
---------------------------

OS: Win10 x64 Pro

Do you have Secure Boot enabled?

yes

That's the issue. With Windows 10 version 1607 and higher, drivers must be signed by Microsoft. The driver is signed by my certificate only. If you turn Secure Boot off, it will be allowed to load.

Hmm...
Very Sad!
This means Admin-Mode is not possible in Win11 either?
Maybe another Methode then a "unsigned driver" will be better then?!
Because i can't even rename a key in HKEY_CURRENT_USER\SOFTWARE with Registry Explorer ;/
I use RegCool and O&O RegEditor for now and both are working fine in Admin-Mode and also mode with NSudo (TrustedInstaller)!

Fubawow, any reason you don't just use RegCool or O&O? Why do you need a third tool if these 2 are already working for you?


bug/stp-730-file-upload-field

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

force options.required to be false for file uploads field

this is a quick patch. ideally this entire component is driven off react state rather than mutating the component prop directly. #18.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

click testing

Checklist:

[x] My changes do not introduce any new linting errors
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation and versioning
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have rebased onto master and there are no code conflicts

LGTM


Fixed the issue with main.yml

A block of code that does not execute for Splunk full even though it is supposed to be executed.

Actually, the least-privileged setting only applies to the UF, and it does not work yet with a full installation anyway, and I am not sure if it's in the pipeline, that's why it's in the UF variables block.
Given all that, the when clause should probably be changed to
when: (splunk_package_version is version(9.0, '>=') and splunk_nix_user != "root")

that will look a lot cleaner nad makes a lot more sense. But it needs to be tested to make sure nothing breaks.

@jewnix - Why it does not apply to full installation?

What if the user wishes to collect the /var/logs from Splunk SH and IDX instances as well?

@VatsalJagani least-privileged is not available on a full installation. This is a product issue.
On a full installation, we run the configure_facl.yml task to allow the splunk user to access /var/log. That task will only run when not least_privileged.

@VatsalJagani
I'm not sure I understand the question, but least_privileged is set to false by default here. This will automatically set a full installation or a UF running as root to false, and only a UF running version >= 9 that is running as a non-root user will get the least_privileged = true variable.
The line you are referring to in the remove_splunk.yml is there to specify to only remove those settings when splunk is not running as root or it is a full install.

@jewnix  My question simplified:

Lets say if we remove the code block I changed, it does not make any change to execution for any tasks.

@VatsalJagani it does, it changes the value to true for UF v9, and the the configure_facl.yml task will skip instead of run. If it's running in least privilege mode, that task does not need to run.


"Connect Rasa-X to GIT" always appears even when a GIT repo is already added

Rasa version:  2.0.2
Rasa SDK version: -
Rasa X version: confirmed the bug with v0.33.0 and v0.33.1 docker images
Python version: Default Docker version for Rasa 2.0.2 / Rasa x 0.33.0
Operating system (windows, osx, ...): Docker version
Issue:
I have already connected my rasa-x to git however the “Connect Rasa X to Git” popup always displays and there is no button to go to the next step of instructrions or disable it.

Error (including full traceback):
I don't see any relevant errors in `docker-compose logs | grep -i error`

Command or request that led to error:
Connected git to my rasa x 0.33.0, the helper windows always appears and there is no button going to the next level as shown in the above screenshot

Thanks for the issue, @melindaloubser1 will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

Is your git repository still functionally connected when you see this message, or does it get disconnected every time?

It is fully functional, i.e. it restored all my data when I connected Rasa X to git using curl --request POST --url  "https://MYDOMAIN/api/projects/default/git_repositories?api_token=AUTHKEY" --header 'content-type: application/json' --data-binary @repository.json and it publishes changes to git whenever I click on Apply Changes to Git Server button:

If you had to make that post request for it to restore your data, then it means it isn't remaining connected to git, you're having to re-connect it each time. When is this happening? Is it after you do a docker-compose down && docker-compose up -d or is it happening each time you log in to Rasa X?

If you had to make that post request for it to restore your data, then it means it isn't remaining connected to git, you're having to re-connect it each time.

Sorry I didn't explain it well. I used the curl command to connect my Rasa X to GIT only one time, just after installing Rasa X for the first time on my server.

When is this happening? Is it after you do a docker-compose down && docker-compose up -d or is it happening each time you log in to Rasa X?

It happens each time I refresh the page, not only after login to Rasa X, but also on each page refresh.
My Rasa X is connected to GIT and it works pretty well, I don't need to reconnect it, it is connected and I can publish changes to the GIT server without any problem.
The problem is that this "Connect Rasa X to GIT" does not have any Next button, and I am not sure why this notification box thinks my Rasa is not connected to GIT while it is connected properly and working.
I can provide you access to the server / platform so you debug it.

Hey @mghadam!
Thanks for your detailed report. I was able to reproduce this issue locally but it's hard to say yet what's the reason for that. We will try to check it later this week and prioritize it higher because it seems to be a pretty important issue that might prevent users from finishing the onboarding flow.

I have a similar problem with "Rasa swag" window. I have already filled the form once, however, it appears several times a day. Shall I open a new issue for it?

@mjaycub i was not able to reproduce it locally, no popup appears after connecting to git

@MariyaGalasyuk are you debugging with on-boarding enabled?

@mjaycub so i ran  SKIP_FRONTEND_BUILD=true RASA_X_PASSWORD=rasa OPEN_WEB_BROWSER=false GIT_DEVELOPMENT_MODE=true rasa x for backend and cd src && REACT_APP_API_URL=http://localhost:5002 yarn run develop for frontend, which in my eyes should enable onboarding steps (?)

Ok replying in your DMs :D


Migrate the FontFamily extension

https://github.com/ueberdosis/tiptap/blob/main/packages/extension-font-family/src/font-family.ts

Would be cool if the related PR could be merged :)


Feature/skip actions

This PR adds a way to skip specific actions when doing operations that trigger events.
Closes #216.
Changes:

Added a kwarg skip_actions to all methods that trigger an action event (save, insert, replace, save_changes, validate_self):

Accepts Optional[List[Union[ActionDirections, str]]]: either an ActionDirection, or the name of an action

Exposed ActionDirections:

Before
After

Added tests for action events
Added doc for skip_actions
Fixed the doc for state_management (my previous PR)

@roman-right Any chance you can have a look at this PR?

Ah, sorry. I'm unfocused these days. I'll try to take a look till this weekend, if this is not super urgent

It's not, I didn't mean to be pushy, just to let you know! :)

Thank you for the contribution. It is in the 1.10.1 now


Add support for csr_attributes.yaml setup

It would be useful to add support for /etc/puppetlabs/puppet/csr_attributes.yaml in order to use secure autosign with passwords and setup trusted facts. Currently, you can't add this in /docker-custom-entrypoint.d because the cert request happens before these scripts are called. This file is only read during new certificate signing requests.
https://www.puppet.com/docs/puppet/latest/config_file_csr_attributes.html
Running /docker-entrypoint.d/20-use-templates-initially.sh                                                                                [20/7643]
Upgrading /opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems
Running /docker-entrypoint.d/30-set-permissions.sh
Running /docker-entrypoint.d/40-update-puppetdb-conf.sh
Running /docker-entrypoint.d/50-set-certname.sh
Running /docker-entrypoint.d/55-set-masterport.sh
Running /docker-entrypoint.d/56-set-environmentpath.sh
Running /docker-entrypoint.d/57-set-hiera_config.sh
Running /docker-entrypoint.d/60-setup-autosign.sh
Running /docker-entrypoint.d/70-set-dns-alt-names.sh
Running /docker-entrypoint.d/83-environment-cache.sh
Settings environment_timeout to unlimited
Running /docker-entrypoint.d/84-enable_graphite.sh
Running /docker-entrypoint.d/85-setup-storeconfigs.sh
Running /docker-entrypoint.d/88-enable-cache-delete-api.sh
Running /docker-entrypoint.d/90-ca.sh
turning off CA
Info: Refreshed CRL: A2:B5:C9:C0:45:B3:A7:97:B6:4D:98:28:00:AA:AF:82:2B:71:BD:D7:FC:3D:6E:30:9D:9C:93:E2:C1:D8:59:CA
Info: Creating a new RSA SSL key for puppetserver-6d56786d58-4n4g9
Info: csr_attributes file loading from /etc/puppetlabs/puppet/csr_attributes.yaml
Info: Creating a new SSL certificate request for puppetserver-6d56786d58-4n4g9
Info: Certificate Request fingerprint (SHA256): 6D:F7:BD:4D:F7:4D:43:1D:C6:86:77:79:25:FD:34:D9:F4:00:93:C2:01:BE:D2:D3:32:5A:F4:6F:9B:EE:AC:D6
Info: Downloaded certificate for puppetserver-6d56786d58-4n4g9 from https://puppetca.default.svc.cluster.local:8140/puppet-ca/v1
Notice: Completed SSL initialization
Running /docker-entrypoint.d/99-log-config.sh
System configuration values:
* HOSTNAME: 'puppetserver-6d56786d58-4n4g9'
* hostname -f: 'puppetserver-6d56786d58-4n4g9'
* PUPPETSERVER_HOSTNAME: 'puppetserver-6d56786d58-4n4g9'
* PUPPETSERVER_PORT: '8140'
* Certname: 'puppetserver-6d56786d58-4n4g9.pem'
* DNS_ALT_NAMES: 'puppet.default.svc.cluster.local'
* SSLDIR: '/etc/puppetlabs/puppet/ssl'
CA Certificate:
subject=CN = "Puppet CA generated on puppetca-78f7c89c8f-jpkrr at 2024-01-18 13:32:11 +0000"
issuer=CN = Puppet Root CA: ffa53cc76b5009
        X509v3 extensions:
            X509v3 Basic Constraints: critical
                CA:TRUE
            X509v3 Key Usage: critical
                Certificate Sign, CRL Sign
            X509v3 Subject Key Identifier:
                02:AF:72:E2:95:EB:7F:D7:93:02:E4:A0:0F:A4:28:66:AC:4E:02:B3
            Netscape Comment:
                Puppet Server Internal Certificate
            X509v3 Authority Key Identifier:
                44:F5:B7:2A:91:3E:5B:82:8E:33:89:BA:A4:C7:9D:4E:F9:70:6A:58
Certificate puppetserver-6d56786d58-4n4g9.pem:
subject=CN = puppetserver-6d56786d58-4n4g9
issuer=CN = "Puppet CA generated on puppetca-78f7c89c8f-jpkrr at 2024-01-18 13:32:11 +0000"
        X509v3 extensions:
            X509v3 Subject Alternative Name:
                DNS:puppet.default.svc.cluster.local, DNS:puppetserver-6d56786d58-4n4g9
            Netscape Comment:
                Puppet Server Internal Certificate
            X509v3 Authority Key Identifier:
                keyid:02:AF:72:E2:95:EB:7F:D7:93:02:E4:A0:0F:A4:28:66:AC:4E:02:B3
                DirName:/CN=Puppet Root CA: ffa53cc76b5009
                serial:02
            X509v3 Subject Key Identifier:
                70:3B:2E:3D:FC:E4:B4:0C:24:F1:00:C9:71:6F:E8:88:C6:49:C6:8E
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Extended Key Usage: critical
                TLS Web Server Authentication, TLS Web Client Authentication
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
Running /docker-custom-entrypoint.d/..2024_01_18_14_10_41.32789583/50-setup-csr-attributes.sh

Just to be sure that I got your request right: You want to set csr_attributes within the Puppetserver certificate.
Is this correct?

Just to be sure that I got your request right: You want to set csr_attributes within the Puppetserver certificate.
Is this correct?

Correct. I believe this file needs to be in place before this step happens. Puppet loads it automatically if it exists.


sv: remove certain unnecessary loop var ending value assignments

@zachjs is there something we can do to help get this is? This resolves the issue we tried to fix in #3043 so it'd be nice to get this merged

I discussed this with Claire earlier, and she suggested an alternative strategy which would be more robust. I'm looking to finalize the implementation by the end of the week.

This has been supplanted by #3150.


10 jdk_net tests failed with Can't assign requested address on jdk17 aix

10 tests failed with Execution failed: `main' threw exception: java.net.BindException: Can't assign requested address   on jdk17 aix.
It happened on test aix machine test-osuosl-aix715-ppc64-3
https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_extended.openjdk_ppc64_aix_testList_0/20/#showFailuresLink
Stacktrace
Execution failed: `main' threw exception: java.net.BindException: Can't assign requested address

java/net/DatagramSocket/Send12k.java.Send12k
java/net/MulticastSocket/IPMulticastIF.java.IPMulticastIF
java/net/Socket/B6210227.java.B6210227
java/net/Socket/GetLocalAddress.java.GetLocalAddress
java/net/Socket/HttpProxy.java.HttpProxy
java/net/Socket/SetSoLinger.java.SetSoLinger
sun/net/www/protocol/http/B6299712.java.B6299712
sun/net/www/protocol/http/HttpOnly.java.HttpOnly
sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java.PostThruProxyWithAuth
java/net/DatagramSocket/SendReceiveMaxSize.java.SendReceiveMaxSize
Those tests also failed on build aix machine build-osuosl-aix71-ppc64-2 though with different error message.
https://ci.adoptopenjdk.net/job/Grinder/3282/
seven tests under java/net got error message like Execution failed: main' threw exception: java.net.NoRouteToHostException: A route to the remote host is not available.https://ci.adoptopenjdk.net/job/Grinder/3283/ three tests under sun/net got error messagejava.net.BindException: The socket name is not available on this system.    `

Ref https://github.com/adoptium/aqa-tests/issues/3251 and https://github.com/adoptium/infrastructure/issues/2456
This might be an infra issue.
Try rerunning the failed tests on build-osuosl-aix71-ppc64-1. I didn't expect them to fail on build-osuosl-aix71-ppc64-2, but they might pass on -1

Those tests also failed on build aix machine build-osuosl-aix71-ppc64-2 though with different error message.
https://ci.adoptopenjdk.net/job/Grinder/3282/

Rerunning extended openjdk on test-osuosl-aix715-ppc64-3 after changes made in https://github.com/adoptium/infrastructure/issues/2456
https://ci.adoptopenjdk.net/job/Grinder/3684/console


add tests for json schemas

As an analyst I want test json schemas before pushing them to master.
Add, please, tests for all json schemas.

tests work with changed ehealth.api/apps/ehealth/lib/ehealth/validators/json_schema.ex file


Unexpected behavior when Docker or Vagrant isn't installed

Describe the bug
The Vagrant package logs a warning when the package is loaded and Vagrant isn't in PATH. This is currently suppressed by restricting all warning log level messages.
Expected behavior
It would be better to instead have build-magic check to see if Docker and Vagrant is installed, and only load the modules if the commands are found in PATH.


MD034/no-bare-urls false positive since v0.7.0

This code produces an error since v0.7.0:
[[text] text](https://some.url.org)

Or are there Markdown parsers which do not support brackets within the link text brackets? In case, is there a proper way to escape them?

Per the specification, if "text" were a valid shortcut link, then it would bind more tightly than the outer link and this error message would be correct.
Example here: https://dlaa.me/markdownlint/#%25m%23 Issue 150

[[text] text](https%3A%2F%2Fsome.url.org)

[text]%3A https%3A%2F%2Fexample.com

In this case, "text" is not a valid shortcut link, but because the linter assumes all shortcut links are valid even if undefined (needed for other reasons), it produces this misleading output.

As you suggest, it is perfectly valid to escape the inner brackets like so to avoid the warning: https://dlaa.me/markdownlint/#%25m%23 Issue 150

[\[text\] text](https%3A%2F%2Fsome.url.org)


[testing] Bazel build fix for pwrmgr test

Bazel build fix for pwrmgr_sleep_power_glitch_test.c
Signed-off-by: Arun Thomas<EMAIL_ADDRESS>

This PR also fails the chip:0.chip_sw_uart_tx_rx test in CI (private)

Due to compounding CI issues, these changes had to be included in #12452 to fix CI. Closing this.


Security Issue with your package from pypi.org

Hello! Found a security issue in your package in pypi:
https://pypi.org/project/boto3-stubs/
Affected versions of package:

1.24.11 (Jun 17, 2022)
1.24.12 (Jun 17, 2022)
1.24.13 (Jun 20, 2022)
1.24.14 (Jun 21, 2022)
1.24.15 (Jun 22, 2022)
1.24.16 (Jun 23, 2022)

There's an unmet dependency on module mypy-boto3-redshiftserverless if you will try to install these versions of boto3-stubs with extras all:
>python -m pip install --upgrade boto3-stubs[all]==1.24.16
Collecting boto3-stubs[all]==1.24.16
  Downloading boto3_stubs-1.24.16-py3-none-any.whl (46 kB)
     ---------------------------------------- 46.8/46.8 kB 1.1 MB/s eta 0:00:00
Collecting typing-extensions>=4.1.0
  Downloading typing_extensions-4.3.0-py3-none-any.whl (25 kB)
Collecting botocore-stubs
  Downloading botocore_stubs-1.27.46-py3-none-any.whl (44 kB)
     ---------------------------------------- 44.1/44.1 kB 2.1 MB/s eta 0:00:00
...
Collecting mypy-boto3-memorydb<1.25.0,>=1.24.0
  Downloading mypy_boto3_memorydb-1.24.36.post1-py3-none-any.whl (28 kB)
ERROR: Could not find a version that satisfies the requirement mypy-boto3-redshiftserverless<1.25.0,>=1.24.0; extra == "all" (from boto3-stubs[all]) (from versions: none)
ERROR: No matching distribution found for mypy-boto3-redshiftserverless<1.25.0,>=1.24.0; extra == "all"

It happens because there is missed requirement in setup.py file:
...
    install_requires=[
        "botocore-stubs",
        "typing-extensions>=4.1.0",
    ],
    extras_require={
        "all": [
            "mypy-boto3-accessanalyzer>=1.24.0, <1.25.0",
            "mypy-boto3-account>=1.24.0, <1.25.0",
            "mypy-boto3-acm>=1.24.0, <1.25.0",
...
            "mypy-boto3-redshift-data>=1.24.0, <1.25.0",
            "mypy-boto3-redshiftserverless>=1.24.0, <1.25.0",
...

It's dangerous because the intruder can create malicious package mypy-boto3-redshiftserverless on pypi and:

Make online guides how to use your package and abuse this malicious supply chain attack to compromise users
Infect automated CI/CD pipelines that uses old version of your package
Infect other users by hardcoding those versions of package in opensource projects that use it

It's dangerous because usage of boto3-stubs, even quite outdated, is not something strange. Everyone likes hardcoded versions of packages, even in the era of protestware.
The best solution is to delete exact versions of package from pypi. Better to break dependencies in some old pipelines than compromise them.
Also suggest you to set security email address for reporting this type of vulnerabilities: https://github.com/youtype/mypy_boto3_builder/security/advisories
Rakovsky Stanislav (Positive Technologies)

Yes, unfortunately I had to remove the package because botocore changed service name to redshift-serverless , and pypi does not accept packages with similar names.
I can potentially create post releases for all these versions

Post-releases are also good solution in this type of situation.
Also it would be great to register a CVE for this. CVEs would help security teams on customer side to properly execute vulnerability management process.
About non-accepting packages with similar names: 28 of July I have reported about package names requesys, that mimirty requests, this way idk about strictity of typosquatting politics)
Rakovsky Stanislav (Positive Technologies)

let me try to upload the packages now

ERROR WARNING  Error during upload. Retry with the --verbose option for more details.
ERROR ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
ERROR          The name 'mypy-boto3-redshiftserverless' is too similar to an existing project. See
ERROR          https://pypi.org/help/#project-name for more information.

So, I believe, the intruder cannot upload mypy-boto3-redshiftserverless due to PyPI restrictions. However, boto3-stubs[all]==1.24.11 installation is still broken. I will try to find a proper way.

The functionality of prohibitation: https://github.com/pypi/warehouse/blob/39daea188d2e1e6494c50753cd48cb5a8da3e8c4/warehouse/utils/project.py#L124
Can you try to register "mypy.boto3.redshiftserverless" instead of "mypy-boto3-redshiftserverless"? For pypi it's the similar names, but not for sql) If it will be success, it would be interesting bypass of collision check.

I have released post releases for all affected packages, which require mypy-boto3-redshift-serverless instead of mypy-boto3-redshiftserverless:
INFO [1/2] Published boto3_stubs_package 1.24.11.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.11.post2
INFO [1/2] Published boto3_stubs_package 1.24.12.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.12.post1
INFO [1/2] Published boto3_stubs_package 1.24.13.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.13.post1
INFO [1/2] Published boto3_stubs_package 1.24.14.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.14.post1
INFO [1/2] Published boto3_stubs_package 1.24.15.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.15.post1
INFO [1/2] Published boto3_stubs_package 1.24.16.post1
INFO [2/2] Published boto3_stubs_lite_package 1.24.16.post1

Please let me know if it solves the issue or if anything is left to be done. Thank you for the report!

Great!
This vulnerability was found as a part of my research at Positive Technologies for making open sourse projects more secure.
So to make the processes of secure development more smooth, I suggest you:

To set an email for security vulnerabilities issues here: https://github.com/youtype/mypy_boto3_builder/security/policy
Good example: https://github.com/apache/activemq/security/policy

Register a CVE for this vulnerability. CVE would help security teams on customer side to properly execute vulnerability management process and demonstrates that you are seriously take information security. Also I will be happy)

Thank you for taking a look at my project! Will do this today.

@rakovskij-stanislav I have added a security report.
Could you please guide me through the process of reporting a CVE? As far as I understand, I should do it here. However, I have no idea whom to select as a CNA.

Your project is opensource and you don't belong to Amazon (right?), so your CVE Numbering Authority is MITRE Corporation (https://www.cve.org/PartnerInformation/ListofPartners/partner/mitre)


fix #418 test for fsPromises.truncate(path[, len])

This fixes the issue #418.
There is now a test available for fsPromises.truncate(path[, len]) .
It checks if the length of the file is negative, and sends an error message.

@deepanjali19 this looks good, we just need to resolve this merge conflict.  Let's do it in class tomorrow together.

Sure @humphd !


DailySummary.js only reflects GMT time

Apparently new Date() in node only gives GMT time, and therefore getDailySummary.js can only yield one standard time for all users around the world. A small suggestion here to change it to ''+new Date() so users can get the proper output for their local time. See the thread here on getting locale time in node for more information.
BTW, awesome work on wakatime-cli. I've been looking for a good and stylish cli for it.

Thanks for suggesting this - I am pretty busy right now but I'll see if I can get to this sooner rather than later! (I'm also open to PRs if you're into that sort've thing).
Thanks again!

On it, though it might take me some time. Need to dig in on Jest first.

#47 should close this

Thank you! So excited to see wakatime-cli back in my everyday workflow


Change state

Hi.
Tell me, please, have any the possibilities to change the state of the button, without pressing the button? for example, I have a single-page application, and when I click on the "Home" link, the button state must be changed to default

Yeah, for sure.  First, make sure you're using v1 — you probably know that, but i'll be verbose for anyone else who sees this.
With v1, you'll define your button like this:
/*
 * because you'll need the button later,
 * attaching it to the window will make sure any
 * spa scoping doesn't get in the way
 */
window.buttonWithHomeState = L.easyButton({
  states: [{
    stateName: 'home',   // this is the name of the button's state
    icon: 'fa-home',
    title: 'add random markers',
    onClick: function(btn) {
      btn.state('other-not-home-state')
    }
  }, {
    stateName: 'other-not-home-state',
    icon: 'fa-question-circle',
    onClick: function() {
      // do something else
    },
    title: 'remove markers'
  }]
});

and from anywhere (probably click listener or home-nav hook), you'll be able to:
window.buttonWithHomeState.state('home');  // go a specific state by name

Good luck! Let me know how this works out, if there's trouble, let me know which spa framework you're using and i'll send something more specific to that.


Generate schema types to one file that can be imported for operations types

Is your feature request related to a problem? Please describe.
I work in a monorepo with a graphql server and multiple packagesthat make requests to the graphql server. Each package defines the queries it needs in a queries.graphql file and I use graphql-code-generator to generate React hooks for each operation defined with appropriate types. This all works great, but there is a lot of duplication in the generated files for each package since the typescript plugin generates the types for the whole graphql schema and then the typescript-operations plugin uses Pick to get the appropriate types based on the defined operations. The main problems I experience right now are:

git diffs are unnecessarily noisy. End up with the same changeset in each app when making any change to the schema.
Need to special case the generated file to not trigger running tests in CI for every app when making a non-breaking change to the schema.

Describe the solution you'd like
I would like if I could generate the typescript schema types to a single file for my monorepo since it's the same in all cases, and then have the operations I'm using defined per-app, importing from the file with the schema types. This removes all the duplication from each packages' generated file.
Describe alternatives you've considered
None.
Additional context
None.

We have near-operation-file preset at the moment. it should allow you to generate a single base-types file (from typescript) plugin, and then generate TS file per each operation found, and it will maintain imports. You can override the imports generated by this plugin and use scoped imports if you wish to have this done thought your monorepo structure.
We current don't have a file-per-each-package preset, but it should be pretty simple to implement, it's just a different breakdown than near-operation-file.  PRs are welcome ;)

Neat, thank you for pointing me to the near-operation-file preset. I actually only have one operation file per package, so I think this existing preset will work exactly the same as a file-per-each-package would for my purposes.


check list length

check list length, before index it

I find my frecency file has a block of binary data(0x00 0x00 ...  0x0a), and it will trigger list index error.


galaxy init mount jobs never reach completion when run a second time with persistence enabled

tar: can't open 'cvmfs/cloud.galaxyproject.org/tools/toolshed.g2.bx.psu.edu/repos/iuc/collection_element_identifiers/d3c07d270a50/collection_element_identifiers/collection_element_identifiers.xml': File exists
From galaxy-init-cloud-repo-partial
I am using persistence. After a first job completion, if the job is started again for any reasons (chart upgrade ...), it will keep crashing. After running chown a first time, tar runs into permission errors.
I would suggest:

checking if the files already exist or not before attempting to download them
tar --skip-old-files might solve this, but would miss on configuration changes
maybe adding a download complete check like you do for the db initialization, with a version number maybe as well

https://github.com/galaxyproject/galaxy-helm/blob/64668c982919d94d98206870d4ba058aa1f02635/galaxy/templates/jobs-init.yaml#L39

Interesting... running upgrades with an NFS shared filesystem is working for us, and existing files just get overwritten. When you say "if the job is started again for any reasons" do you mean actually restarting the same job or an upgrade (i.e. new revision number)? The current implementation already has a signal per revision same as the db wait, although only for the startup portion: https://github.com/galaxyproject/galaxy-helm/blob/master/galaxy/templates/jobs-init.yaml#L193.
I am wondering if the file was open, do you know by any chance if the tool had been run recently? Even if that's the case, we should still find a solution for it, just trying to better understand when it happens.

Hi, this is the same job that is restarted via restartPolicy: OnFailure.  I ran it again on a newly created PVC and I am getting the same thing from galaxy-init-cloud-repo:
tar: can't open 'cvmfs/cloud.galaxyproject.org/tools/toolshed.g2.bx.psu.edu/repos/iuc/samtools_fixmate/bc0cc7bfbfe9/samtools_fixmate/samtools_fixmate.xml': File exists
I am not using NFS, but a Rook / CephFS filesystem in ReadWriteMany access mode.

@nuwang @afgane @ksuderman We should probably discuss this at the meeting tomorrow. If overwriting files while unarchiving doesn't work universally on all filesystems, we should find an elegant solution for this, especially as we're thinking about abandoning the NFS as well.
@cyrilcros In the meantime, you could turn off the initJob and use the CVMFS with this set of values: --set initJob.downloadToolConfs.enabled=false --set cvmfs.repositories.cvmfs-gxy-cloud=cloud.galaxyproject.org --set cvmfs.galaxyPersistentVolumeClaims.cloud.storage=1Gi --set cvmfs.galaxyPersistentVolumeClaims.cloud.storageClassName=cvmfs-gxy-cloud --set cvmfs.galaxyPersistentVolumeClaims.cloud.mountPath=/cvmfs/cloud.galaxyproject.org

Hi, I can just work with a locally installed Galaxy for now.
I have had issues with CVMFS on Kubernetes 1.20/1.21, some CSI features changed. I tried forking the chart and making edits (RBAC rules for volumeattachment, upgraded images, changes to arguments). That worked on 1.20 for a while, but not now. https://github.com/cernops/cvmfs-csi hasn't been been updated in a while....

Yep, we noticed the same issues with 1.20, haven't gotten the time to update the CSI unfortunately :/ I'll try to make a simple fix (perhaps forcing a rm -rf followed by only unpacking the full tool set, which should guarantee that each file is only unpacked once. I will try to get to it this week, but no promises as there are many things to do so close to GCC. If you have the time to try and PR a simple fix yourself, that'd be a great start and we can  generalize it from there if necessary

@nuwang @afgane @ksuderman We should probably discuss this at the meeting tomorrow. If overwriting files while unarchiving doesn't work universally on all filesystems, we should find an elegant solution for this, especially as we're thinking about abandoning the NFS as well.

Interestingly, testing with Rook/Ceph was already on my To-Do list for this week.  I will see if I can recreate by tomorrow.

@cyrilcros Could you possibly share an installation example of your Rook/Ceph stack assuming you're using a relatively portable helm chart/operator? It might accelerate us being able to reproduce and then fix this

This is bare metal install, I copied the relevant stuff here: https://github.com/cyrilcros/storage-k8s

@cyrilcros Can you verify that exec'ing into the container and doing an
echo test > /cvmfs/cloud.galaxyproject.org/tools/toolshed.g2.bx.psu.edu/repos/iuc/collection_element_identifiers/d3c07d270a50/collection_element_identifiers/collection_element_identifiers.xml

works as expected?
When you said you chowned the first time, which owner was it changed to? If this a filesystem permission issue, could it be solved by settings fsGroup or something?

I think my issues are stemming from ArgoCD + this line: https://github.com/galaxyproject/galaxy-helm/blob/64668c982919d94d98206870d4ba058aa1f02635/galaxy/templates/jobs-init.yaml#L132
The job gets restarted by ArgoCD because it is removed after it completes. It would be nice to have it as a values like ttlForJobs in the chart, that lets you know what happened to the job if set to 0.
I will try to edit my ArgoCD application spec to ignore jobs....

@cyrilcros I made https://github.com/galaxyproject/galaxy-helm/pull/305. I suppose you could set it to a very high number if it only gets restarted after it gets cleaned up? However, wouldn't the expected behavior be to not restart the job if it completed successfully?

Thanks so much for reacting quickly, @almahmoud , I tried making my own fix....

I added
https://github.com/galaxyproject/galaxy-helm/pull/306/commits/2cbd1e031ea81b4beab565372952a103bca29a9f which should make it unsettable with --set initJob.ttlSecondsAfterFinished=null

That worked! I just set ttlSecondsAfterFinished: ~ in my values and the jobs finish without issues....


Add algorithm for decomposing multi-controlled rotation

This ia an algorithm requested in #2625.
@alexandrupaler

I addressed the comments. CI is passing.
@Strilanc

Can someone please take another look at this PR and approve it if no further changes are needed?
@Strilanc @alexandrupaler @viathor


Create firefuel initialize method to provide FirebaseFirestore.instance to all collections

Solved by https://github.com/SupposedlySam/firefuel/commit/b457e834583656b7f6938aa6eeadac4946cdbb7d


TypeError: Cannot read properties of undefined (reading 'confirm-reindex-modal')

Describe the Bug
Error while opening the search collection in the admin panel:
Error: Cannot read properties of undefined (reading 'confirm-reindex-modal')<PHONE_NUMBER>
Request: /admin/collections/search?limit=10 GET
Context: App Router /admin/[[...segments]] render server-rendering undefined
Runtime: nodejs
 ⨯ [TypeError: Cannot read properties of undefined (reading 'confirm-reindex-modal')] {
  digest: '3351752589'
}

Happens while server-rendering this component.
Unfortunately not much details in the stack trace:
The above error occurred in the <eval> component. It was handled by the <ReactDevOverlay> error boundary. Error Component Stack
    at eval (index.js:3157:17)
    at ReindexConfirmModal (index.js:14:3)
    at div (<anonymous>)
    at ReindexButtonClient (index.client.js:27:34)

Link to the code that reproduces this issue
https://github.com/cbratschi/payload
Reproduction Steps
Use the search plugin. Open the search collection admin page. Error occurs while loading.
Which area(s) are affected? (Select all that apply)
plugin: search
Environment Info
Binaries:
  Node: 22.9.0
  npm: 10.8.3
  Yarn: 1.22.22
  pnpm: N/A
Relevant Packages:
  payload: 3.6.0
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:23 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6031
  Available memory (MB): 65536
  Available CPU cores: 16

Hey @cbratschi, I'll look into this one too. Strange as your error message seems to be about the reindex modal slug passed to the modal hook. I did not notice this error in 3.6.0, but maybe try latest in the meantime?

Hey @cbratschi,
Just following up on this as promised! I can't reproduce this issue and haven't seen an instance of it since reindexing was introduced. As I mentioned above, the error you're seeing is related to the slug of the reindex modal so I'm thinking it might have something to do with the ui package modals. My recommendation would be to update to the latest or try reinstalling deps.
I tested against the monorepo using both mongodb and postgres. If you're still seeing this issue, then it'd be nice if I could see a valid repro or some more details about your environment.

It works now fine with Payload 3.12.0.


Enhancement/1483 chainspacing

Closes #1483
Closes #1336
This PR implements chainspacing in the URL.
All URLs that exist in the context of a Safe have a network ID (same ones that the Safe UI uses) prefixed to the address.
Additionally, error page logic has been separated to clearly identify the two scenarios that might occur for a Safe being unable to be loaded:

The given address simply isn't a Safe on the expected (as per the network prefix) Safe.
The app is connected to a different network than what the Safe is expecting (as per the network prefix).

Additionally, stronger typing has been enforced in the many places were navigation links exist. This stronger typing required early-exiting rendering attempts where either the network prefix or address are not available yet (e.g. as a Safe is loading), so special review and testing should be taken to ensure that the logical changes around rendering links was implemented correctly.
Testing
Functional changes in this PR include:

Safes will only load if they include a network prefix in the new query param-based address.
automatically applying a network prefix to the address in the new query param-based url only when redirecting from the old path-based URL.
fixing all internal links and navigation in the app to apply and utilize the new query param-based safe addresses.
splitting the "can't load Safe" error screen into three distinct messages

for when there is a problem with the format of the address query param
for when the app is connected to a different network than the network prefix in the address query param
for when the syntax and network are all good, but the Safe can't load because of actual loading issues, like the Safe API is down or the address just isn't an actual Safe.

@adamgall - approval given
I did lots of testing of this PR with Decent, shutter, and myosin by pasting old URLs into this deploy link
Good news is they were all handled successfully :slightly_smiling_face:
I can also confirm your point above that linking to an old link to the treasury page, will now link back to the core homepage (note - this is absolutely fine)

@Da-Colon @mudrila @tomstuart123 I have just pushed a bunch of fixes and nice QoL improvements, this is ready for review again.

Tried the new netlify link with 4 prior DAOs.
TLDR

All mainnet prior DAO links worked when on the right chain already and were reformated correctly
All sepolia prior dao links didn't work when on the right chain already and were given this

When on sepolia (different chain), all mainnet prior DAO links saw the below message which I believe is the intended error message

Mainnet DAO links tried

Decent multisig (mainnet) - https://app.dev.fractalframework.xyz/daos/0xD26c85D435F02DaB8B220cd4D2d398f6f646e235
Decent's tokenvoting (mainnet) - https://app.dev.fractalframework.xyz/daos/0xB98d45F9021D71E6Fc30b43FD37FB3b1Bf12c064
Shutter's token voting  (mainnet)- https://app.dev.fractalframework.xyz/daos/0x36bD3044ab68f600f6d3e081056F34f2a58432c4
AwakeVCs - https://app.dev.fractalframework.xyz/daos/0xdD6CeFA62239272f1eDf755ba6471eacb7DF2Fa5

Sepolia DAO links tried

Myosin multisig - https://app.dev.fractalframework.xyz/home?dao=0xdef90A94273a1A1A72B33D39129fa41E6C08Be3a
One of my sepolia test dao s- https://app.dev.fractalframework.xyz/home?dao=0xA287241240B5C8fce743Fb291D4F38cD669298d4

@tomstuart123 the Sepolia links you tried are indeed formatted incorrectly. Notice how they are the new query params, but don't include the network prefix. This is invalid as per this new PR.


Icon fonts missing from PDF

If :icons: font is applied to the document then icons go missing in the final PDF. Asciidoctor outputs the following warning
asciidoctor: WARNING: conversion missing in backend pdf for inline_image

gradle 2.3
asciidoctor 1.5.2
asciidoctorj-pdf 1.5.0-alpha.6

Take a look at: https://github.com/asciidoctor/asciidoctor-pdf/issues/9

I thinke it's also related to #15  and could maybe be solved with PR #90

Indeed. This seems like good Hackergarten material to me :)

@madmas this is only partially solved by #90. We still need to parse the inline image. Once we do that, then we can delegate to the icon method to draw the font-based icon. I'd say this is really a duplicate of #9.

I just got inline icon macros working. What's more, you can use one of 4 icon sets.
Here's a full example:
Available now at icon:amazon@pf[].

That reads "the amazon icon in the pf (payment font) icon set". You can also write it as:
Available now at icon:amazon[set=pf].

In addition to the sizes supported in the HTML backend (lg, 1x, 2x, etc), you can enter any relative value in the size attribute (e.g., 1.5em, 150%, etc).
icon:android[size=40em]

You can also set the icon set globally.
= Icons
:icon-set: octicon

icon:alert[] Don't miss this!

We don't yet support any way to color the icon.

I'm on Fedora 22 x86_64 with
asciidoctor -v
Asciidoctor 1.5.2 [http://asciidoctor.org]
Runtime Environment (ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux]) (lc:UTF-8 fs:UTF-8 in:- ex:UTF-8)
asciidoctor-pdf -v
Asciidoctor PDF 1.5.0.alpha.9 using Asciidoctor 1.5.2 [http://asciidoctor.org]
Runtime Environment (ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux]) (lc:UTF-8 fs:UTF-8 in:- ex:UTF-8)
I do not see the Font Awesome icons in the PDF but I do see them in HTML.
I've declared :icon-set: fa and use font like this icon:android[size=2x] this works in HTML but in PDF I see text [android]
I generate PDF using
asciidoctor-pdf asciidoctor-example.adoc
I'm sure I'm missing something here and any help is appreciated! Thank you for working on such an awesome project! This has made documentation so easy :)

Can you try?
asciidoctor-pdf -a icons=font asciidoctor-example.adoc

This worked like a charm for both icons and admonition icons.  Thank you!
I'ne sent in a pull request to improve some documentation around this.

:+1:

I just got inline icon macros working. What's more, you can use one of 4 icon sets.

fa - Font Awesome
octicon - Octicons
fi - Foundation icons
pf - Payment font

Here's a full example:
Available now at icon:amazon@pf[].

@mojavelinux  Does it also work on asciidoctor generating HTML?
I can't make it work (I tried with octicon, with/without :icon-set:).
Thanks

No, this is a feature specific to PDF.
There's some discussion about adding it for HTML in this PR: https://github.com/asciidoctor/asciidoctor/pull/1801, but there are technical challenges yet unsolved.

I'm amazed by your quick answer.
I have been in this PR and that's when I tried the icon-set Feather.
Looking forward the integration... and by the way, a big :+1: for the great work on Ascidoctor: this really revolutionized my way of doing technical documentation and presentations (+ Reveal.js) since I have discovered it in January 2018.

Thanks!

Could we use multiple icon sets in a single document?

To answer a super old question: yes, you can
For example:
:icons: font
...
icon:mortar-board[] icon:settings@octicon[]


Is there an example application similar to WinUI3 Gallery, or like Element-ui;Ant-Design

All samples you can find here: https://github.com/JetBrains/compose-jb/tree/master/examples.
We have widgets-gallery sample with a set of UI elements: https://github.com/JetBrains/compose-jb/tree/master/examples/widgets-gallery
Also, you can look at Android specific examples and code snippets here: https://foso.github.io/Jetpack-Compose-Playground/material/card/. Most of them are the same like you can do in Compose for Desktop (or multiplatform).

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.