fix: correctly fill plugins with arbitrary map fields

Kong plugin schemas support different type of fields, including maps. Moreover, these can either be arbitrary maps, or maps with their own subschema.
go-kong already supports well the second case, but it falls short with arbitrary maps. An example of arbitrary map field is the custom_fields_by_lua from the http-log plugin, which is defined as follows:
{
  "custom_fields_by_lua": {
    "keys": {
      "len_min": 1,
      "type": "string"
    },
    "type": "map",
    "values": {
      "len_min": 1,
      "type": "string"
    }
  }
}

This commit makes sure that go-kong is able to correctly handle such schemas as well.

Codecov Report
Base: 52.32% // Head: 38.75% // Decreases project coverage by -13.56% :warning:

Coverage data is based on head (2f9ab6d) compared to base (669d55b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #258       +/-   ##
===========================================
- Coverage   52.32%   38.75%   -13.57%
===========================================
  Files          51       51
  Lines        4610     4621       +11
===========================================
- Hits         2412     1791      -621
- Misses       1670     2497      +827
+ Partials      528      333      -195

Flag
Coverage Δ

2.1.4
35.29% <0.00%> (-1.67%)
:arrow_down:

<IP_ADDRESS>
?

2.2.2
35.29% <0.00%> (-1.67%)
:arrow_down:

2.3.3
37.02% <71.42%> (+0.06%)
:arrow_up:

<IP_ADDRESS>
?

2.4.0
37.11% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

2.5.1
37.11% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

2.6.0
37.11% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

2.7.0
37.11% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

2.8.0
37.11% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

3.0.1
36.50% <100.00%> (+0.15%)
:arrow_up:

<IP_ADDRESS>
?

3.1.0
38.15% <100.00%> (+0.14%)
:arrow_up:

<IP_ADDRESS>
?

community
38.75% <100.00%> (+0.14%)
:arrow_up:

enterprise
?

integration
38.75% <100.00%> (-13.57%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

kong/utils.go
85.71% <100.00%> (-0.15%)
:arrow_down:

kong/mtls_auth_service.go
0.00% <0.00%> (-62.50%)
:arrow_down:

kong/vault_service.go
0.00% <0.00%> (-56.67%)
:arrow_down:

kong/developer_service.go
0.00% <0.00%> (-54.87%)
:arrow_down:

kong/consumer_group_service.go
0.00% <0.00%> (-51.89%)
:arrow_down:

kong/rbac_role_service.go
0.00% <0.00%> (-48.94%)
:arrow_down:

kong/developer_role_service.go
0.00% <0.00%> (-46.67%)
:arrow_down:

kong/entity_permission_service.go
0.00% <0.00%> (-40.66%)
:arrow_down:

kong/consumer_group_consumer_service.go
0.00% <0.00%> (-38.19%)
:arrow_down:

kong/rbac_user_service.go
0.00% <0.00%> (-34.89%)
:arrow_down:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@Kong/team-k8s this PR is approved (but merge is blocked) and decK is already using this code. Can someone take a look please?

@Kong/team-k8s this PR is approved (but merge is blocked) and decK is already using this code. Can someone take a look please?

Done :)


Readme for both ep880 and ep910

Fix for https://github.com/IBM/rl-testbed-for-energyplus/issues/30
Signed-off-by: Tako Moriyama<EMAIL_ADDRESS>

Dropping this because it's no longer necessary.


nginx-nodejs-redis: add dev envs config

Add Docker Desktop Development Environments config
Upgrade NodeJS image
Rename nginx to proxy and use bind mount for config
for consistency with other examples

Marked this one as a draft because I'm not sure it makes sense to include in its current state.
The sample wants two web backends, presumably to show that the state is in fact stored in Redis. It achieves this pretty hackily by duplicating the config instead of using deploy.replicas. I tried to switch to that but I think there's a Compose enhancement needed here - DNS does not behave as expected in this case 😢
Thoughts?

@milas, I tried to use
    deploy:
      replicas: 2
    ports:
      - 81-82:5000

and remove the web2 service in compose and nginx conf, but I randomly hit a port collision between the 2 replicase 😬 (that shouldn’t happen, I'll see if we can fix that on compose side quickly)

The port bindings aren't really needed since we have the nginx proxy - remove those & launch again and then look at DNS aliases
They both get referred to as web or their "fully qualified" name with the project name (which we can't use since we can't predict that)
I was hoping there'd be web-1 and web-2 DNS aliases to use in the nginx upstream

Closing this - we're going to skip this one for now as it's not a good fit!


Adding an optional token to the dataset fetcher code to allow optional fetching from private repositories

Describe the new feature or enhancement
The dataset fetching code inside mne/datasets/utils.py, mne/utils/fetching.py are actually very general. I was hoping to leverage them without copy/pasting the code, so I can make use of upstream possible bug fixes / performance improvements (if they ever occur).
However, in some cases, I would like to unit test against private data I have stored on Github, and they require an API token with the HTTP request. Eventually, then some of that data would be made public after say a publication, but it's then nice to build into a CI for myself for a private research project in the meantime.
Is it possible to add an optional "token" into the dataset fetcher? This would also enable MNE to leverage private repos. In addition, it would lessen the code dependency for anyone trying to implement a data fetcher without copying every single function from MNE.
Describe your proposed implementation
Add optional token=None kwarg to the following functions:

_download
_fetch_file
_get_http

Then one can easily add optional tokens in _data_path, depending on which dataset is being fetched. This would also enable any "mne" package, like mne-bids/connectivity/etc. to leverage private Github repo data that might get passed in via GH actions.
Describe possible alternatives
If we further refactor things, so that key, urls, archive_names, folder_origs, folder_names, md5_hashes are passed into _data_path, rather then set inside _data_path, then to create a MNE-fetcher, one simply needs to define a data_path that then passes these to _data_path, and they have a fully functional: mne_downstream_package.testing.data_path() that fetches their own datasets for testing without having to rely on MNE-Python for data fetching.
Additional Information
I think this also might be helpful in further cementing MNE-Python as a platform for developing neuroscience/clinical-neuroscience applications that sometimes might need data fetchers in their CI / testing pipeline for "private data".
Ref: https://chanzuckerberg.com/eoss/proposals/improving-usability-of-core-neuroscience-analysis-tools-with-mne-python/

This is an interesting proposal @adam2392, I also have a private code repository for handling fetching my various datasets, so offloading some of that to MNE would be advantageous to me too. However, ...

I would like to unit test against private data I have stored on Github

Maybe this is more a curiosity, but do you actually store your data on GitHub? Looking at the LFS storage on GH its $5 per 50 GB per month ($0.1/GB), as opposed to something like backblaze at $0.005/GB. Or are you just talking about small testing datasets that fall under the 1GB limit?

Interesting idea. I'm not opposed in principle. Another option might be Pooch; not sure if they have support for API tokens already.
About 9 months ago I worked on migrating MNE-Python to use Pooch so that we could get rid of a lot of this code, but I didn't finish it because it took them so long to merge my enhancement PR. I'm mentioning this so you can investigate whether (1) you want to work on that migration with me, or (2) a future switch to Pooch would be incompatible with what you want to do.

^ small testing datasets that fall under the 1GB limit, but we can't make public "yet". And yeah I basically have like 4 different version of the current MNE fetcher code, but they all modify maybe like... 10 LOC, so that suggested to me that this would be a valuable refactoring in MNE.
It seems nowadays as well that MNE is more and more of a "platform", since it "enables" analysis and testing related to MEG/EEG/iEEG and then offloads analysis and more niche stuff to other mne packages, like mne-connectivity, mne-bids, etc. Part of this enablement in my opinion is making data fetching easier for CI/unittesting.

This is an interesting proposal @adam2392, I also have a private code repository for handling fetching my various datasets, so offloading some of that to MNE would be advantageous to me too. However, ...

:) I'm not alone

Interesting idea. I'm not opposed in principle. Another option might be Pooch; not sure if they have support for API tokens already.

Ooo interesting. I don't know what Pooch is, but I'll go read about it rn.

About 9 months ago I worked on migrating MNE-Python to use Pooch so that we could get rid of a lot of this code, but I didn't finish it because it took them so long to merge my enhancement PR. I'm mentioning this so you can investigate whether (1) you want to work on that migration with me, or (2) a future switch to Pooch would be incompatible with what you want to do.

Hmm can you link to the corresponding issues/PRs? If its within my abilities / doesn't take an enormous amount of time, I would definitely be down to work on this.
^ if it does take a lot of effort though, is there an opposition to the refactoring plan I suggested though? Or is that somewhat contradictory work?

Okay found your draft: https://github.com/mne-tools/mne-python/pull/8679

Also regarding Pooch having support for an API token: https://www.fatiando.org/pooch/latest/api/generated/pooch.HTTPDownloader.html#pooch.HTTPDownloader
looks like one can set up an HTTP downloader that passes in kwargs to request.get, which supports tokens in the request header.

Now that #9742 is almost done, what is your thoughts on generalizing the data fetching module with some documentation to easily allow any downstream package to create their own neural testing dataset (optionally in a private repo)?
I'm thinking an API would be a public version of the current _data_path(), and something like:
fetch_dataset(checksums_file_path, archive_map, url_map, folder_name_map, config_map=None, **_data_path_kwargs)
Then in the docstring, we can specify how one can create their own checksums file, and then just pass in some parameters and they leverage the MNE dataset fetcher with the same backbone. This can then be useful for say... mne-connectivity/mne-bids/etc. to store its own datasets, without having to make a PR to mne-python's datasets that would just increase the size there.
cc: @larsoner @agramfort

let's discuss during office hours today

Copying over here for next 2 PRs:

restructure dataset info as nested dict of dicts; incorporate MD5s into python and change pooch to temporarily write the registry file (separate PR) and whatever else is necessary to make it easier to add new built-in datasets
add generic dataset downloader function, that allows e.g., API keys (separate PR). This should probably look like a data_path() function that takes in URL, archive name, hash, etc, and does everything that one of our built-in data_path() functions does (except for checking/setting config keys)

Ref link: https://github.com/mne-tools/mne-python/pull/9742#issuecomment-921932044


Hey @Jngai! My preference would be simply to remove them since they were one-time-only tasks.

@alexsoble yup removed.


vsftpd: mistake in module help text. 'sslEnable' doesn't exist

The description of services.vsftpd.forceLocalDataSSL states:
'Only applies if sslEnable is true.'...
But there is no sslEnable option in this module
Metadata

system: "x86_64-linux"
host os: Linux 5.4.24, NixOS, 19.09.2284.bf7c0f0461e (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.3
channels(root): "nixos-19.09.2284.bf7c0f0461e, nixos-hardware, unstable-20.09pre213994.e2b4abe3c8f"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
  - services.vsftpd

Not to make this unstale, but to anyone looking for this ssl_enable is set automatically by specifying rsaCertFile. See https://github.com/NixOS/nixpkgs/blob/nixos-21.05/nixos/modules/services/networking/vsftpd.nix#L109

It seems that a number of configuration options has no impact on the actual config, i.e. ssl_tlsv1. That option exists, but its value is never used to render the config.


ragnarwm: init at 1.3.1

Description of changes
Ragnar is a minimalist C tiling window manager inspired by dwm,
bundled with more features out of the box to make is user-friendly.
Things done
I based myself on the dwm derivation to make it. tested it through Xephyr.

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Re: license:

Ragnar is using the GNU general public v3.0 license

I would understand that response more as gpl3Only than gpl3Plus, so I've also asked for further clarification.

Would it be possible for you to write a VM test? That way, there's some easily testable insurance that changes don't break basic functionalities of the WM.
You can take a look at the tests for herbstluftwm or i3 for some relatively simple ones. The tests are registered in nixos/tests/all-tests.nix, and you can add them as package tests like so.
If you can't do it then that's fine, but especially for a WM that'd be great to have.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1072


Fail to load template config at start up

Load template config from rmdtpl.txt fails at startup.

fixed in v1.09


Changes to support MAS 9.0.3..

Changes to support MAS 9.0.3..

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

@ocofaigh - Please review this PR. The pipeline run is successful.
This PR has updates for deploying MAS 9.0.3.
Also, a minor correction in displayed variable description is included. So "ibmc-vpc-block-retain-10iops-tier" is changed to "ibmc-vpc-file-500-iops" in description.
I was seeing below error during uninstall & to resolve the same, I have included the runAsUser: 1000 in uninstall Helm chart.
Error: container has runAsNonRoot and image has non-numeric user (root), cannot verify user is non-root (pod: "mas-undeploy-job-qwmzf_mas-uninstall-pipelines(b605c56f-8048-407a-ac16-6f22a7ebc77c)", container: mas-undeploy-job)

/run pipeline

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Missing menu entries in SCM menu when using custom menus

This is the SCM menu using native menus

This is the SCM menu with custom menus

Notice that the menu group after 'Undo Last Commit' is empty

Fixed via https://github.com/Microsoft/vscode/commit/b09094ea9e7946cdf236aa5fa4c0d6833e47de24


Hello World program does not found iostream header for riscv32 clang

https://godbolt.org/z/FkYGyC

It seems like riscv32 can't find any standard headers, not only iostream

This problem isn't exactly easy, it seems that the compiler just ignores all include folders that have x86_64 in them even when you supply them by hand with -I.
So I made a special folder for the riscv setup, and had to chance a define in c++config.h _(disabling _GLIBCXX_USE_FLOAT128 and GLIBCXX_USE_INT128). However it could be just as well that all the other system specific header files are incorrect for the riscv target.
It would be great if we had a proper riscv configuration set.
But meanwhile, you can try this out by supplying the parameters: -I/opt/compiler-explorer/riscv-include-7.3.0/ -I/usr/include
https://godbolt.org/z/hEo7cR
https://godbolt.org/z/Zi8kX1


Only start autocomplete when next character is empty or a space.

Just for discussion, do not commit.
bugsquad node: This is intended to solve #10695.

well, i was doing my godoty things, and i thought i'll activate that fancy autocomplete braces to spare me some keystrokes, and now the next character is a space rule makes no sense.

closing the logic doesn't work.


drivers/sensor: lis2dw12: fix for wrong gpio_callback handling

It seems that gpio_pin_disable_callback() has never been working
for that sensor as it was expected. We used there argument 'dev'
as its own (lis2dw12) device pointer. While this argument is a
gpio_port device pointer not lis2dw12 sensor device pointer. So
cfg->int_gpio_pin always tries to disable callback for some random
pin read from accidental data sector. It was working only because
current implementation triggers interrupt on rising edge not on static
level (high/low) so there is always only 1 edge during accelerometer
event and not working interrupt callback disabling was not visible.
Signed-off-by: Michał Oleszczyk<EMAIL_ADDRESS>

can you possibly evaluate the possible usage of CONTAINER_OF() as used in other drivers?

I have tried to but it is unfortunately impossible. The structure filed we have provided (cb) is a field of lis2dw12_data structure - so we can create new pointer pointing to its starting address basing on CONTAINER_OF(). But we cannot retrieve from it with similar operation a pointer pointing to "upper" structure which is struct device. In other words: field we have is nested too much relatively to structure we wand to get.
Taking it into account this is the cleanest option. On the other hand similar convention was already used in other type of sensors.

I think that there are other ST sensor driver with same mistake.

Indeed. There are similar bugs in other sensors too. But I


Consolidate SQL expired date garbage collector

Based on #2632 which should be reviewed and merged first.
PR adds a single internal package for handling the garbage collection of SQL data which has a TTL.
Package is used by sqlite, CockroachDB, and PostgreSQL.

Thanks, always welcoming PRs that unify code :)
Marking as draft until #2632 is merged

Thanks @ItalyPaleAle, LGTM! :+1:


launch.json configurations help for C/C++ extension missing help on console property

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.65.0
OS Version: Windows x64 10.0.19044

Steps to Reproduce:
Is this the right place to file help related issues?

Go to https://code.visualstudio.com/docs/cpp/launch-json-reference.
Help on "console" debug configuration property is missing.
I was interested in knowing if when providing a debug configuration dynamically from an extension, this value could point to an
existing  terminal that was created by the extension.

Go to help page https://code.visualstudio.com/docs/cpp/launch-json-reference#_externalconsole
When using the "externalConsole" debug configuration property in launch.json, the property is reported as "deprecated", however
the help does not point that fact or which property should instead be used.

/extCpp


Arbitrary hasura metadata customisations

I just added this to a metadata indexer related PR. See:
https://github.com/dipdup-net/go-lib/pull/4#issuecomment-1104558393
https://github.com/dipdup-net/go-lib/pull/4/commits/1b7297dc63c2848c24ba8c9c4ee0db3a8a55c08e
https://github.com/tz1and/metadata/commit/0724746ed388710738b72dfb5b517a7259208465
Basically, to allow running custom hasura api calls. Possibly to add other sources, remote schemas, relationships, or whatever else one might want to do with hasura.

Related: #289

Reference: https://github.com/dipdup-io/metadata/tree/master/cmd/metadata/custom_hasura_config
Apply after all sql files executed and internal Hasura metadata is written


Modify "About Us "section by havor effect

"ABOUT US" section is simple , if we create/add havor effect then it will look great.

Where would you add the hover effect?

i want to add hovor effect to this "About Us" section ,as it is very simple now.
please assign me this work!!

@MonalikaPatnaik

Hey..you are assigned!

@MonalikaPatnaik Thankyou for assigning work!!

currently i have exams till 2nd of june, so i'll be updating you with the PR a day or two after that. Is that fine?

hey, I want to work on this issue. can you please assign it to me?

i am too working on this issue, since i had exam so i couldn't able to complete it. But, now i will solve this issue @anupriyapoddar

I want to work on this issue.
I will fix this within few hours.
Please this work to me.

@MonalikaPatnaik  i have solved the issue of adding hover.json but i am facing this issue while running the application, could you suggest what the error could be?


animation on slow machines

is it possible to disable animation during dashboard initialization. i'm running dashboard view on raspberry pi and it hangs for a moment while loading page

Did you ever figure this out? I need to do the same.

Are there specific widgets that hang? I think you'd have to deal with this on a widget-by-widget basis, as they all work differently.
There are some animations in application.scss that you could disable, but I doubt those are slowing you down. CSS is usually blazing fast...


Add that atom can be built with iojs 2.x

Confirmed here: https://github.com/atom/atom/issues/8508

Can you also update windows.md and osx.md?  Thanks :)

@50Wliu squashed and done!

Windows actually needs two places where it needs updating (see Windows 8) :wink:.

Oops! @50Wliu should be good now. :shipit:

:+1:


Apply insecure flag to oras copy

Issue #, if available: When --insecure is passed eksctl-anywhere import images command, curated packages yaml bundles cannot be pushed to registry mirror with self generated cert. The following error will show:
x509: certificate signed by unknown authority
Description of changes: Insecure flag is applied to oras
Testing (if applicable): Manual invoked eksctl-anywhere import images with and without insecure flag.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cheery-pick 0.16.0

/cherry-pick release-0.16


Feature request: segment_argmax

Currently trying to return argmax from a tensor for selected slices (segments)
slices do not have the same length, so reshaping can't be used.
was looking for a function similar to tf.segment_max, only with indices as the return value.
for e.g
a = [1, 2, 3, 4, 5, 6]
seg = [0, 0, 0, 1, 1, 2]
tf.segment_argmax  return value will be
[2, 4, 5]

Contributions are welcome!

I can try to implement this.
Per the example by OP,  the segments are [1,2,3], [4,5], [6] and the segment_argmax function returns the indices of max element in each segment, but with a reference to the unsegmented list.
Is my understanding correct ?

yes,
indices will be with reference to the unsegmented list.
my intention was to use these indices to slice the original tensor for all the max tensors

I will go to work on this.

Any update on this? I would also extend the feature request to support unsorted_segment_argmax, segment_argmax, unsorted_segment_argmin, and segment_argmin.

Would also like to throw my vote on this as a feature ; this would be super useful.

How is this progressing?

Hi,
tf.segment_max returns the maximum values along segments, but you might need the corresponding indices using tf.where and tf.reduce_max.
Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.
Thank you!


chore(deps): Update composer-concerto to v0.70.5

Coverage remained the same at 94.563% when pulling df8a76efb743b8edc2eddbb40b68b62e942ca429 on mttrbrts:mr-concerto-0.70.5 into 88d9a851a753393cbf47b00b420305a0fea2ea3c on accordproject:master.


How to use it?

I already do as the readme.MD, but I don't know how to test it? How do I use it？it's not an issue, but I really don't know. Can I have some help, thank you very much.

Hi @chenyiping111! How is it going?
The best way to see everything working together (brokers/consumers/producers with security) is using this repository https://github.com/jairsjunior/kafka-playground.
At the playground repo you can see how to configure brokers and consumer/producer samples using Java or NodeJs. Another way of testing as a consumer/producer is using the kafka command line tools, you just need configuring the command line using a JAAS configuration file (the same file that you can find at samples folder)
If you have more questions, please let me know. I will be happy to help you.


[#IADevsIndia] Incorrect status message on incomplete/cancelled upload action

Bug Description
'Uploaded Successfully' incorrectly pops up while choosing to upload file and pressing cancel button on the file up load dialog.
It is a cosmetic issue but might be having underlying unexpected behavior in other cases not visible upfront. Please check attachment.
Reproduction
In the langflow landing patch dashboard, click on upload icon in the left side bar in folder section. Upon pop up of file upload dialogbox, click cancel.
Expected behavior
There should not be any message in case of incomplete/cancelled upload attempt
Who can help?
No response
Operating System
Windows 11
Langflow Version
1.0.17
Python Version
3.10
Screenshot

Flow File
No response

hey @vvtrip hope you are doing fine.
Please follow up this PR: #3659
Thanks for your feedback.

Thanks @Cristhianzl for taking this up. Happy to see this change in newer version!


Do I use copier correctly ?

Hello,
First time using copier here and I am facing a strange issue. Looking at the documentation, it seems pretty straightforward to configure a first template however I am really struggling to do it.
It is worth mentionning that I am trying to create a template out from an existing repository.
I've added a copier.yaml file at the root of my project that contains the following:
# CONFIGURATION -------------------------
_subdirectory: project
_templates_suffix: .jinja

# PROMPT --------------------------------
project_name:
  type: str
  help: Your project name

project_description:
  type: str
  help: Your project description

author_fullname:
  type: str
  help: Your full name
  default: "Next Gate Tech"

author_email:
  type: str
  help: Your email
  default<EMAIL_ADDRESS>
repository_namespace:
  type: str
  help: Your repository namespace
  default: "next-gate-tech"

repository_name:
  type: str
  help: Your repository name
  default: "[[ project_name|lower|replace('_', '-')|replace(' ', '-') ]]"

python_package_distribution_name:
  type: str
  help: Your Python package distribution name (for `pip install NAME`)
  default: "[[ project_name|lower|replace('_', '-')|replace(' ', '-') ]]"

My root directory contains a project directory that contain itself the actual template.
What's weird is that whenever I run:
copier /k/sandbox/template /k/sandbox/generated-from-template

copier is copying everything from an older state of my project (feels like my main branch actually) even though I am doing the generation from my local filesystem. (and I am 100% sure being on the correct branch)
It doesn't even ask for the inputs present in the upper configuration file.
Is there some sort of cache?
I am working on Windows 10 with Python 3.9.6 64bits

I just missed the -r, --vcs-ref VALUE:str switch from the cli...
Also, I am seing that if the project is a git repository, for changes to be taken into account by copier, it needs to be commited.
Maybe we could improve the documentation so that those two point are more seeable?
At least this issue might be usefull for other blind people like me 😬

The Discussions tab of this repo is a good place to ask about general usage tips for Copier. Copier is in flux right now, with v6 being tracked by this project and this milestone. The core devs have the following to say about it:

This is a long-term, mostly unfounded project, but we are in no hurry. This time, next release will take longer. New little-but-amazing features might be released faster as alphas. But the next release will be a big one.

As for this:

Also, I am seing that if the project is a git repository, for changes to be taken into account by copier, it needs to be commited.

Issue #312 tracks the progress on "allow to execute when git is not installed".
And this:

Maybe we could improve the documentation so that those two point are more seeable?

Depending on the dev's preference, I imagine the relevant documentation could be tracked in #312 or else here.

Perfect! Thanks for answering and sorry for the noise.

All is said, thanks!


Make schema and schema component method signatures consistent

Currently the SeriesSchemaBase class and subclasses have inconsistent method signatures, which pylint is complaining about, see: https://github.com/pandera-dev/pandera/pull/138#issuecomment-572138205
Need to come up with a solution to make signatures consistent, ideally without breaking the public API.

this would be addressed by #153

fixed by #153


Github gist not verifying

Hi,
My github gist will not verify. Here's the link. Let me know what else I might need to do.
https://gist.github.com/ericklind/410805c5f5be9de153a2bc07339dea2f
Thanks.
Erick

It worked.

It worked.


Run external contributor branch through CI

Running this PR https://github.com/KittyCAD/modeling-app/pull/4634 through CI on an authorized branch

Retrying the two e2e tests that failed

await expect(page.getByText('Unexpected token: $').first()).toBeVisible()

Looks like this might be a real failure. Probably a test that needs to get updated with the new error message.


Avalonia DevTools crash app on Windows on corporate laptops

Describe the bug
Avalonia.Diagnostics.Conventions crashes on corporate notebooks. I don't understand the reason. It tries to create folder that is already there C:\Users\SiarheiKuchuk\Pictures\Screenshots and fails.
   at Avalonia.Diagnostics.Conventions.get_DefaultScreenshotHandler()
   at Avalonia.Diagnostics.DevToolsOptions..ctor()
   at Avalonia.DevToolsExtensions.AttachDevTools(TopLevel root)
   at butil_ui.Views.MainWindow.InitializeComponent(Boolean loadXaml, Boolean attachDevTools) in D:\Personal\sources\butil\sources\butil-ui\obj\Debug\net8.0\Avalonia.Generators\Avalonia.Generators.NameGenerator.AvaloniaNameSourceGenerator\butil_ui.Views.MainWindow.g.cs:line 29
   at butil_ui.Views.MainWindow..ctor() in D:\Personal\sources\butil\sources\butil-ui\Views\MainWindow.axaml.cs:line 9
   at butil_ui.App.OnFrameworkInitializationCompleted() in D:\Personal\sources\butil\sources\butil-ui\App.axaml.cs:line 38
   at Avalonia.AppBuilder.SetupUnsafe()
   at Avalonia.AppBuilder.Setup()
   at Avalonia.AppBuilder.SetupWithLifetime(IApplicationLifetime lifetime)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, Action`1 lifetimeBuilder)
   at butil_ui.Desktop.Program.Main(String[] args) in D:\Personal\sources\butil\sources\butil-ui.Desktop\Program.cs:line 22
Avalonia.Diagnostics
Could not find file 'C:\Users\SiarheiKuchuk\Pictures\Screenshots'.
   at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)
   at System.IO.Directory.CreateDirectory(String path)
   at Avalonia.Diagnostics.Conventions.get_DefaultScreenshotsRoot()
   at Avalonia.Diagnostics.Screenshots.FilePickerHandler..ctor(String title, String screenshotRoot)
   at Avalonia.Diagnostics.Screenshots.FilePickerHandler..ctor()
   at Avalonia.Diagnostics.Conventions..cctor()
System.Private.CoreLib

To Reproduce
That's the first time i see it. It is not reproduced at home and at my own laptop.
Expected behavior
No error obviously, but also showing real error would be nice.
Avalonia version
11.0.10
OS
Windows
Additional context
NA

When i launch app via Ctrl+F5 - it works fine.

Basically idea is to add support for corporate environments?

For reference: #14069.

Conventions.DefaultScreenshotsRoot should probably return null on exception and/or we need fallbacks. It is always accessed on startup regardless of config, so if it fails, then it's fine if SuggestedStartLocation gets set to null. Better than always crashing with no mitigation. I'm not a fan of I/O in a property getter either.
I'm still unsure what the system configuration issue is though since the directory is supposed to exist on @drweb86's system.

I am guessing OneDrive is involved somehow and there is some weird folder redirection happening.

Directory is indeed exists. And yes, OneDrive create symbolic links to other directories.

As the docs explain, Directory.CreateDirectory ensure that the folder exists (eg: Linux does not have Screenshots folder) and creates it if it is not found.
Create a simple console app with this code and check if it works
                var dir = System.IO.Path.Combine(
                    Environment.GetFolderPath(Environment.SpecialFolder.MyPictures), "Screenshots");
                Directory.CreateDirectory(dir);

Hi. Bug stopped to reproduce since today. I don't know why. Probably Microsoft Defender was blocking it. I tried to delete screenshots folder and it still works. Also I tried to rename folder. First time - name remains the same, from second time - it gets changed. And anyway in this case it also works fine.
Console app also works good.

closing as not reproducible anymore.


Gradle sysnc errors

my develoption environment  is  “Android Studio：3.0  ；Gradle：4.1” ,when i  import this project ,it  displays  this  problem ,as follows:
"Error:Unable to load class 'org.gradle.api.internal.component.Usage'.
Possible causes for this unexpected error include:Gradle's dependency cache may be corrupt (this sometimes occurs after a network connection timeout.)
Re-download dependencies and sync project (requires network)The state of a Gradle build process (daemon) may be corrupt. Stopping all Gradle daemons may solve this problem.
Stop Gradle build processes (requires restart)Your project may be using a third-party plugin which is not compatible with the other plugins in the project or the version of Gradle requested by the project.In the case of corrupt Gradle processes, you can also try closing the IDE and then killing all Java processes."

The bintray-release plugin is out dated. Update to version 0.7.0 should fix this issue.
In the root build.gradle file, change
classpath 'com.novoda:bintray-release:0.4.0'

to
classpath 'com.novoda:bintray-release:0.7.0'

I've also updated build tools and dependencies in 669d48c89bd02266aaa70dca3f0b4531461e35c6.


Update setup-python in CI

In the workflow files, actions/setup-python@v1 is used, we should update to the latest (currently v4)

Yes great!


How can i get processed transactions for highload wallet?

Hi guys, want to monitor highload wallet transactions for actual operations statuses. And to do this highload wallet contract has method getProcessed that requires queryID, but in current SDK queryID is randomized inside the SDK and it is not returned anywhere in method like SendManyWaitTransaction or SendManyWaitTxHash. The only idea i have right now is to fork the SDK and update highload wallet interface/methods to add query id in  initialmessages []*Message as they are passed by link after sent. Or maybe i miss something and there is a way to get queryID for sent messages?

Hi, for HW3 you can set your own query id by default (example)
If you are using HW2 you can also hook query id creation, like this:
w.GetSpec().(*wallet.SpecHighloadV2R2).SetCustomQueryIDFetcherWithContext(func(ctx context.Context, subWalletId uint32) (ttl uint32, randPart uint32, err error) {
		return ...
})


Crashing bug while typing a change to a style property

Fatal crashing bug
(editing style tag takes down the editor) https://paradise-engineering.slack.com/archives/C1VLFSW0H/p1623693267017500
STR: ~not entirely clear, but involved editing the style part of a component. In the Slack link ^^^ there's React devtools download, and screenshots of the console~

Start with the code
 anywhere in your project
Updated that to

Don't profit :disappointed:

Also, if you open this project it (still) seems to show the error that initially took down the editor.
https://utopia.app/p/ec77ab7c-lyrical-candle/

I just tested this out and updated with steps to reproduce. The issue seems to be that a string is being passed in rather than an object (for the style prop), but I haven't looked into why that completely breaks the editor.

Yeah, this happened mid-edit (my intention was to remove the style object, and replace it with className, possibly repurposing part of the string from the style object - or maybe my hand slipped and I typed in the wrong place. The issue for me isn't the error, but that producing that error state took down the editor (since it's the kind of error you could also get while eg completing a style object, or going from "oops, only one set of curly braces, needs to").

Closing as this appears to have been fixed since filing (I suspect by #1359)

Huh! I really didn't expect #1359 to be the root cause here...


Add print statements summarizing performed actions

When building, customizing or uploading a survey it would be nice to have a short summary printed in the terminal giving an overview of what has been done, e.g.
>>>Building project: <project name>
>>> Including templates: <template 1>, <template 2>, ...
>>>Customizing <n> fields
>>> Uploading to server ... done
```

This has been implemented for the project_build sub module via https://github.com/INT-NIT/DigLabTools/pull/25. Can be extended also to other submodule on the same level (validation, project_control).


Unable to reproduce  unit tests in stand alone project.

Issue Description
I am setting up a small test project to quickly reproduce Nd4J tests while tackling some of the code issues in nd4j.java.  The duplicate code for CreaeDetached is an easy fix.  However the tests testCreateDetached_1 and testCreateDetached_2 fail in a standalone project. (Before any fixing).
Gist with details:
https://gist.github.com/RobAltena/d44b77204b68347b6771824f8c0237c8
Edit: Within Dl4J  both CreaeDetached methods are only used from these tests. Maybe they should be removed?
Based on this test:
 @Test
void testEnum() {
    long[] shape = new long[]{10};
    for(DataType dt : DataType.values()){
        try {
            DataBuffer dataBuffer = Nd4j.createBufferDetached(shape, dt);
            System.out.println(dt + " : " + dataBuffer.dataType());
        } catch (Exception e){
            System.out.println(dt + " : " + e.getMessage());
        }
    }
}

With this result:
DOUBLE : FP16 isn't supported for CPU yet
FLOAT : FP16 isn't supported for CPU yet
HALF : FP16 isn't supported for CPU yet
LONG : LONG
INT : INT
SHORT : Cannot create type: SHORT
UBYTE : Cannot create type: UBYTE
BYTE : Cannot create type: BYTE
BOOL : Cannot create type: BOOL
UTF8 : Cannot create type: UTF8
COMPRESSED : Cannot create type: COMPRESSED
BFLOAT16 : Cannot create type: BFLOAT16
UINT16 : Cannot create type: UINT16
UINT32 : Cannot create type: UINT32
UINT64 : Cannot create type: UINT64
UNKNOWN : Cannot create type: UNKNOWN

Removal seems in order.

cc @raver119
createBufferDetached seems like something we might need... though were the Nd4j.createBuffer methods going away longer term anyway?
If so, then maybe this could go away sooner rather than later...

Few thoughts from my side: We should and are providing an easy to use suite of factory methods for ndarrays. For buffers and detached buffers we could consider them a more advanced concept where the user should know what they are doing. A method like numpy.newbuffer could be all that we need.

Users typically never touch these methods, only we do, for out-of-workspace allocations. There methods were used for shapeInfoBuffers. Now shape info buffers are created in cpp. So on one hand we can remove those, but on other hand i'd keep those for a while, we might use those for upcoming SameDiff executioner changes. Hasn't decided yet.

I rebuild SkyMindIO/Deeplearning4j  libn4j and nd4j locally this morning.
All the tests pass and the output of testEnum looks a lot better:
DOUBLE : DOUBLE
FLOAT : FLOAT
HALF : HALF
LONG : LONG
INT : INT
SHORT : SHORT
UBYTE : UBYTE
BYTE : BYTE
BOOL : BOOL
UTF8 : Cannot create type: UTF8
COMPRESSED : Cannot create type: COMPRESSED
BFLOAT16 : BFLOAT16
UINT16 : UINT16
UINT32 : UINT32
UINT64 : UINT64
UNKNOWN : Cannot create type: UNKNOWN

Source builds, test pass --> Issue closed.


Update to use accessible-autocomplete v2.0.0

Fixes #1044

You can preview this change here:
Built with commit 483feaa2cab006448fb247fedebb849528053463
https://deploy-preview-1050--govuk-design-system-preview.netlify.com


Root div class of layout child component missing

Environment

Operating System: Windows_NT
Node Version:     v16.16.0
Nuxt Version:     3.1.0
Nitro Version:    2.0.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-cg71hh?file=package.json
Describe the bug
The class of the root div of a child component  (sidebar.vue) , which is served by  the layout component (default.vue),  disappears aka is not rendered when upgrading from nuxt v3.0.0 to v3.1.0.
Additional context
No response
Logs
No response

Seems to be relevant to which element the root is. If you change the <div> to a <p> then the class is properly applied.

This should be resolved in v3.1.1 via https://github.com/nuxt/nuxt/pull/18494

can confirm :thumbsup:


Added support for pre/post-generation hooks

Fixes #64

Changes Unknown when pulling bff9860b53c87b2feb3f692f731270eea441bdf9 on feature-generation-hooks into ** on develop**.

Changes Unknown when pulling bff9860b53c87b2feb3f692f731270eea441bdf9 on feature-generation-hooks into ** on develop**.


Browserify angular dependency injection compatiblity

This will allow users of browserify to inject Restangular into AngularJS using the CommonJS require syntax.
For example:
var angular = require('angular');
angular.module('myApp', [
  require('angular-animate'),
  require('angular-route'),
  require('restangular'),
]);

Resolves https://github.com/mgonto/restangular/issues/749

Anyony?

certainly a :+1:

i need this!
+1

:+1:

@mgonto this is only a one liner, yet very very helpful. please consider merge

+1 :thumbsup:

Is there any reason its not getting merged? It'd be awesome to finally have commonjs support.
/cc @mgonto @oznu

:+1: this would be great!

:+1:

Any news on this one? :)

Perfect! Merging!


Dataset: Fully support monocular datasets

There were some methods which didn't work properly with monocular datasets.
Now everything should be fixed.

Codecov Report
Patch coverage: 87.09% and project coverage change: +1.42 :tada:

Comparison is base (41e1474) 80.99% compared to head (b89fcc9) 82.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   80.99%   82.42%   +1.42%
==========================================
  Files          21       22       +1
  Lines         842      916      +74
  Branches      196      218      +22
==========================================
+ Hits          682      755      +73
- Misses        139      140       +1
  Partials       21       21

Impacted Files
Coverage Δ

src/pymovements/datasets/dataset.py
96.34% <87.09%> (+1.67%)
:arrow_up:

src/pymovements/events/idt.py
100.00% <0.00%> (ø)

src/pymovements/events/ivt.py
100.00% <0.00%> (ø)

src/pymovements/synthetic/step_function.py
100.00% <0.00%> (ø)

src/pymovements/utils/filters.py
87.09% <0.00%> (ø)

src/pymovements/events/engbert.py
96.00% <0.00%> (+0.44%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[FEATURE] Virtue's New Version

[Please do not close the request after a revision release is posted. Request will be closed by the developer when it is implemented to the base version or when it is flagged as not planned]
Feature
Some virtue ideas

Make it so you can chargeback the heavenly beam of virtues. Why? You can strike back the lightning of the Ferryman, so I see absolutely no reason that holy light should be excluded.

Make the explosion of the virtues core... explosive! Like the idols, who have the epic electric explosion. Also, I propose that +[ENRAGED] virtues should have a larger red explosion.

Usage

It gets you out of muddy situations easier; virtues are already fast, and the enraged triple insignia doesn't help either. That is why I propose this counter. Also, make it do 3 damage; it's not being to be like Maurice one-shot, as virtues would become useless because this would be the life-cycle:

[Spawn]
[Shoot Beam]
[Get Charge-backed]
[Die]

It not only punishes slow players that cannot escape the explosion, it also opens an entire new world when it comes to core parrying. The player is now given incentive to punch virtue core, as it can actually deal with crowds, as opposed to the old one, which barely kills anything, and sort of just knocks everyone around. Also, the red explosion of mad virtues presents a risk-reward game for players; "Do I make the virtue mad so that the explosion is larger, and I can get more enemies with it?"

Extras
N/A

I feel like Virtue beams are too wide to be chargebacked and I don't think Virtues are fast enough to necessitate implementing chargebacks as a counterplay
Explosive Virtue Cores sounds fun though, but maybe only give it a regular explosion when non-enraged and not parried, then maybe the lightning strike once parried (and maybe only on enrage)
If possible maybe the explosion also deals more damage to the player than enemies.
Rewarding the confident, but an explosive punishment awaits the lethargic, accident-prone or those who think too highly of their own abilities.


compressing jingles from WAV to high-quality OGG

Plug-and-play change of the audio files from WAV to OGG. Reduces built x64 executable size from 80,767 kB to 21,997 kB.
Addition of  header to Source/HUDManager.cpp was necessary to compile, as std::clamp() isn't otherwise included in the compilation unit.
Testing performed on Steam client.

I would prefer the straight conversion of the .wav to .ogg files without cutting into the fadeout this much

If you're concerned with how long it takes for queued jingles to play in certain scenarios, I have a plan for that where I define a length for how long each jingle is "blocking"

Oh, also, there are more references to the .wav files in App.vcxproj
Those should be changed too


As of right now, once Quests is installed, every NPC regardless of entity type will say "No more quests available." when a player right-clicks on them.
For servers that have other uses for NPCs (Sentinel, custom Denizen scripts, Interactions, etc.), the message can get in the way of natural dialogue or actions - especially if a player is fighting a Sentinel NPC; say they're using a shield to block; it's almost a constant spam of:
No more quests available.
No more quests available.
No more quests available.
No more quests available.
No more quests available.
No more quests available.
No more quests available.
No more quests available.

You can go to the lang file and remove the message, but the player will still see a blank chat message like so in the above example:

If it's possible, I think it would be a really cool feature if this message were only shown when a player right clicks on an NPC who has had a quest assigned to them, or an option in the config to disable this message entirely.
How would people use it?
For servers that have multiple uses for NPCs - Sentinel, Interactions, Denizen -, it would help conversations flow better, as well as other interactions not be interrupted by the message.

Try https://ci.codemc.io/job/PikaMug/job/Quests/331/ with noMoreQuests: ""

Thank you! Trying this now for both issues!


Fix- TRSV2-484 - Re-associating contacts with organisations

Codecov Report
Base: 53.86% // Head: 53.94% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (105a691) compared to base (9c43484).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    53.86%   53.94%   +0.07%
===========================================
  Files          204      205       +1
  Lines        11638    11657      +19
  Branches      1506     1506
===========================================
+ Hits          6269     6288      +19
  Misses        5369     5369

Impacted Files
Coverage Δ

...ore/management/commands/reassociate_contact_org.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


link to "fair is not fair enough" gives 404

Link at the end of "Sharing code and data" to the "fair is not fair enough" paper appears to be borken. Not sure what other information would be prudent to attach here?

Thanks Björn! A bit embarrassing/ironic that these links are broken. We will fix that.


-webkit-perspective: 1 kills performance in CSS column paginated large HTML documents

Some large HTML documents are totally unusable in Thorium, the jank / lag during user interaction is between 500ms and 1 whole second sometimes. Not just when "turning" pages (which is just horizontal scroll), but also just making text selections with the mouse in the current spread. The performance profiler (Chromium, Electron) shows costly layout recalc but mostly paint operations.
After much trial and error, I discovered that -webkit-perspective: 1; on the root HTML element is the culprit, and funnily-enough this is marked as "Fix bug for older Chrome" :)
https://github.com/readium/readium-css/blob/583011453612e6f695056ab6c086a2c4f4cac9c0/css/src/modules/ReadiumCSS-pagination.css#L45-L46

-webkit-perspective: unset; or -webkit-perspective: none; solves this (no need for !important if on the html@style attribute). However I am experiencing mouse hit-testing and x/y coordinate issues when tweaking via Chromium's web inspector, so I will build this in Thorium / r2-navigator-js properly to make sure no regressions are caused.

Furthermore, as with all alterations of the CSS rendering "stacking context", I must make sure this doesn't break position: fixed; used in some cases (from the top of my head: annotations / highlights, overlay modal dialog positioning)

So as an educated guess, I should be able to remove this considering how old the version of Chrome targeted by this fix is now.
But I’d like to double-check just in case.
@mickael-menu could you update me on the situation re. Android support? Thx.

We support down to Chrome 68 on Android, but I think we might raise this if needed. What's the problematic version?

@mickael-menu So that’s an interesting question and a rabbit hole I’ll have to go down into.
The issue is described in CanIUse’s “known issues” for CSS Multicolumn:

Chrome is reported to incorrectly calculate the container height, often breaks on margins and padding, and can display one pixel of the next column at the bottom of the previous column. Some of these issues can be solved by adding -webkit-perspective: 1; to the column container. This creates a new stacking context for the container, and apparently causes Chrome to (re)calculate column layout.

But is missing a link/source. So I’ll have to dig deeper.
What we can assume is that either the version @ which Daniel started removing the CSS hack is safe, or something else has been forcing Chrome to recalculate the column layout all along and it wasn’t really needed.

Alright some background, this issue popped up a couple of weeks after chromium switched to LayoutNG – specifically LayoutNGBlockFragmentation. Did my best to find clues in Chromium bug tracker re. multicolum and that’s all I could find at the moment, via this issue in which Thorium is mentioned.
But it sounds to me that’s more like coincidence than causation at the moment.
Also, as a sidenote:

if a multicol container has flex, grid, or table inside, the entire multicol container will fall back to legacy layout for now.

I remember Chromium switched to their initial implementation of fragmentation when they removed CSS regions, so I’ll have to confirm whether it was what was used until LayoutNGBlockFragmentation in early 2022. I’ll also check performance issues/regressions after that.
In any case, sounds a bit too much to ask to bump from v.68 to v.10x

Thanks @JayPanoz
Probably related ... I filed this bug report some time ago:
https://issues.chromium.org/issues/329478330

@danielweck Yeah I can’t say this is surprising to me as I saw quite a significant number of regressions after the switch while scanning all the issues. I’ll probably make another pass to collect unfixed issues that may be impactful.
@mickael-menu as far as I can tell, the complete switch to LayoutNG for columns happened with LayoutNGTableFragmentation, which was v.106.0.5245.0, according to Chromium Dash

Thanks, I'll update the Kotlin code if you remove -webkit-perspective!

Proposed solution: remove from ReadiumCSS and update the Kotlin code, and document the change.


Avoid invalid navigation

The fluent API allows to navigate from one entity to another even if there are defined query parameter options on the source entity. This leads to invalid API requests. Basically, it should not be possible to apply query parameter options when switching context / types using .NavigateTo(...). There are different places where the logic would be appropriate to apply - I decided to implement it at the first possible location - before parsing/executing the query.
Example:
await client
    .For("Products")
    .Key(1)
    .Select( // <<< this is invalid when calling .NavigateTo(...) afterwards
    .NavigateTo("Category");

Resulting request:
https://host/Products(1)?$select=Field1,Field2/Category
    Problem here:       |---------------------|

Sorry, I did a bunch of PR's and completely missed to run the tests again before pushing this one. I was able to identify the problem quickly, but I'm not sure how to resolve it since it may be a result of an inconsistency in the library. While implementing my change, I expected FluentCommandDetails.FilterIsKey and the correlated BoundClient.FilterIsKey to be true when the resulting command text would result in a key-based query like /Products(1).
Now, the FilterIsKey property is true, when calling BoundClient.Key(1), but false when you use BoundClient.Filter(x => x.PrimaryKey == 1. Both versions will result in the same query...
Now, which of the following alternatives would you prefer?

Invest some time to have a consistent behavior with the FilterIsKey property
Allow navigation when filters are present since I do not know if it is a PK-search or not
Prohibit navigation when filters are present which may prohibit PK-search using BoundClient.Filter(...)
Eliminate this feature completely

Let me refresh my memory about FilterIsKey and I will come back to you.

Of course - no pressure on this... I just had the issue that I accidentally tried to expand a query on which I already defined a projection ($select). This one failed on the server and I thought it would be nice to recognize this issue while constructing the query using BoundClient (fail early)...
If its too complicated, I'm absolutely fine to revert these changes :-)

@object, did you find the time to think about the FilterIsKey property and its impact on the client?

The project source code is under significant changes (see discussion here https://github.com/simple-odata-client/Simple.OData.Client/discussions/840), so if the PR is still valid, please resumbit it after the modernization activity is complete.


vector2 changes to float

Godot version:
v4.0.dev.custom_build.4dd915028
OS/device including version:
Archlinux with openbox window manager
Issue description:
When a vector2 is copied from an array and back, it can change to a float, but only under weirdly specific circumstances. This is the relevant code (a small part of a bunnymark):
	# If you use a variable index instead of a for loop -- it works.
	for i in a.size():

		var pos: Vector2 = Vector2.ZERO
		var speed: Vector2 = a[i]
		pos.y += 10 * delta

		# If you comment these lines out -- it works.
		if pos.y > 990:
			pos.y = 990
		if pos.y < 0:
			pos.y = 0

		a[i] = speed
		if not a[i] is Vector2:
			print(to_json(a[i]))
		assert(a[i] is Vector2)

Note that speed is not being changed anywhere. This error is so odd that I'm almost convinced that I'm doing something wrong. If you replace the array with a dictionary, the problem goes away.
Steps to reproduce:
Run the attached sample project. It requires very specific conditions. The variable "speed" should always be a vector2, but it changes into a float and the assertion fails. This happens reliably, despite the strange conditions needed to trigger it.
Minimal reproduction project:
variable-bug.zip
Edit: correct bad hash

What is 38c2524cd? Have you tried with latest master or a stable version?

same issue as #42050 and fixed here: #42067. see: https://github.com/godotengine/godot/issues/42050#issuecomment-692046984


CICO Fees preview

Description
CICO fees integration
Tested
Android & staging CICO services.
Related issues

Fixes #84

Closed in favor of #384


No longer possible to combine "expand" class with other button sizing classes

In Foundation 5.5.2 it was possible to combine both expand and any other button sizing class (for example tiny).
Since 5.5.3, the expand class now has the same font-size / padding than the default button style so it's no longer possible to combined it with another sizing class.
I don't know if it's a wanted behavior or a regression but I think it offers less flexibility and should be reverted to 5.5.2 behavior.
Here are both behaviors:

5.5.2: http://codepen.io/anon/pen/YyVBwa?editors=100
5.5.3: http://codepen.io/anon/pen/pjPGRJ?editors=100

Thanks for the report and the examples. Fixed by adding padding argument 6fa2668


Import Error

When I try to run the simple_chatbot example out of the box, I get an error
INFO:     <IP_ADDRESS>:58183 - "GET /start HTTP/1.1" 307 Temporary Redirect Traceback (most recent call last):   File "<frozen runpy>", line 198, in _run_module_as_main   File "<frozen runpy>", line 88, in _run_code   File "/Users/chrisbora/workspace/pipecat/examples/simple-chatbot/bot.py", line 21, in <module>     from pipecat.frames.frames import ( ImportError: cannot import name 'OutputImageRawFrame' from 'pipecat.frames.frames' (/Users/chrisbora/workspace/pipecat/examples/simple-chatbot/venv/lib/python3.12/site-packages/pipecat/frames/frames.py). Did you mean: 'URLImageRawFrame'?

hi @cbora can you provide more detail and logs?  what code or command are you running.  also what platform?  thank you!

This error probably occurred trying an example from the repo with an installed version of Pipecat instead of Pipecat from the repo. In any case this particular error should now be fixed.


bug: overflow of text-container in gitsign/usage

Description
The markdown contents inside the Detailed Gitsign Usage page is overflowing outside of the container.
Screenshots 👇🏼

Inspectable at gitsign/usage

Additionally, I've tested it locally on both big screens and mobile devices, checks out that the issue is reproducible & valid for both. ⬇

Big-Screen  🖥
Small-Screen 📱

with the only exception being medium screen devices (iPad, Tablets etc.) 👇🏼

[x] I am currently working on this & have started to find the root issue. I'll keep posting updates & create a PR once resolved.
cc: @ltagliaferri, @cpanato

OS :  Ubuntu (22.04 LTS, x64)    /    Windows 10 Pro (x64)
Browser :  Google Chrome — Version 111.0.5563.147 (Official Build) (64-bit)

Update:
@ltagliaferri I performed numerous permutations & combinations by modifying the content of the usage page [especially over here] & tried changing the format-type to html instead of markdown (which Nuxt supports), but all in vain :(
Furthermore, performed extensive research on @nuxt/content theme docs to figure out that it currently supports tables containing upto two columns in a single row & breaks the container if extended beyond it. It's currently deprecated, & has shifted to a new version, called Docus. The announcement can be explored here.

Yes, if I remove a single column in file-config table & tow columns from the Environment Variable table, it fixes the issue (for both big-screens & small-screens)

The current sigstore docs is built with Nuxt which internally comes with in-built Server Side Rendering (SSR) & all of the (lazy) hydration is performed on dynamic DOM directly on Netlify before sending resources to the client, making it a tad difficult to implement external script injection which might fix the issue with a compromise of lower SEO score.
The blog is being rendered from v0.10.1 of nuxt/content-theme-docs, where as the most recent release was v0.11.1. So, I even tried updating the version, but it didn't work out as expected.

So, is there any solution?
Yes, but idk if it's worth taking the shot or not. 😅
Instead of installing nuxt/content-theme-docs using yarn, we have to manually import the dependency package from a separate folder (which has to be kept outside of node modules) & inside that we have to head over to ..\content\nuxt-content.dev.vue (can be locally explored inside ..\.nuxt\content\nuxt-content.dev.vue) & have to update this CSS to update the overflow to disabled ⬇
<style scoped>
.nuxt-content-container {
  position: relative;

  /* HERE IS THE CHANGE */
  /* overflow: disabled; */
}

.nuxt-content-editor {
  width: 100%;
  padding: 8px;
}
</style>

That package has to be updated manually as it's enabled by default. This additionally will provide more options to perform custom customization. Besides, all this hassle is also the same reason why https://github.com/sigstore/docs/issues/96 can't be performed either, as to create changes, one has to directly perform it on the library files itself, which isn't possible without importing locally.
I'm still looking for other options. But as of now, I can suggest that the better way of fixing this, is to migrate the docs to a new revision of docs i.e. Docus (built on Nuxt 3) in near future.


Transaction subtotal shown incorrectly at the end of an auction

The transaction subtotal in the detail pane calculated & shown at the expiration of an auction is incorrect:

Current: Subtotal = For Sale Price + Additional Network Fee Payment
Should Be: Subtotal = Auction Price (0) + Additional Network Fee Payment

See screenshot. For Sale Price of this plot (pre-auction) is 3640. Auction has expired. Transaction triggered is correct (i.e. in this scenario only 1 GEO was debited).

Closing this issue as "wontfix" because we're moving to a streaming system and this won't be applicable.


Prepare MSSQL workflow for ubuntu-24.04 runner image

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
https://github.com/actions/runner-images/issues/10636

The ubuntu-24.04 runner image does not include the ODBC driver, so an additional step is required to install it.
ODBC Driver 18 introduces a breaking change: the default Encrypt setting is now set to yes. To address this, I added Encrypt=no to the connection settings.
Another way to fix the tests is to explicitly specify runs-on: ubuntu-22.04.

Looks like the mssql-server:2017 image won't start. Sad.

There's working on in https://github.com/yiisoft/db

Thank you!


Broken links checker: inconsistent trailing slash behavior

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
The broken link checker sometimes requires a trailing slash and sometimes it works without it.
The fix is then to do
[reported link]: /docs/test#abc
[working link]: /docs/test/#abc

Reproducible demo
No response
Steps to reproduce
You can reproduce it in our docs repository: https://github.com/21TORR/docs

check it out

run pnpm install

go to this file https://github.com/21TORR/docs/blob/live/docs/php/tooling/janus-php.mdx and change the links:
- [Composer bin plugin]: /docs/php/tooling/#composer-bin-plugin
+ [Composer bin plugin]: /docs/php/tooling#composer-bin-plugin
...
- [the note about it]: /docs/php/tooling/#phpunit
+ [the note about it]: /docs/php/tooling#phpunit

run pnpm build

And you will get the error:

Exhaustive list of all broken anchors found:

Broken anchor on source page path = /docs/php/tooling/janus-php:
-> linking to /docs/php/tooling#composer-bin-plugin
-> linking to /docs/php/tooling#phpunit

Expected behavior
I am not very familiar with the age old issue of trailing slashes and their handling in Docusaurus. But the pages themselves are accessible without trailing slash, so I would assume that the broken link checker would then just normalize the linked page before checking?
Or are there cases where these links will actually 404?
Actual behavior
The links are reported as issues, even if copying the link and pasting it into the browser works flawlessly.
Your environment

Public source code: https://github.com/21TORR/docs
Public site URL:
Docusaurus version used: 3.3.2
Environment name and version (e.g. Chrome 89, Node.js 16.4): the build is run on Cloudflare Pages with Ubuntu 22.04.2 and Node 18.17.1
Operating system and version (e.g. Ubuntu 20.04.2 LTS): see above

We have a public repository that I could share, however I fixed all the cases there. I will look at reproducing the issue however.
Self-service

[ ] I'd be willing to fix this bug myself.

Just added a reproducer

Note: please next time create a smaller sandbox repro. It's much easier than dealing with a large custom site.

Agree there is something unexpected here, only happening for broken anchors (not pathnames).
Repro: https://stackblitz.com/edit/github-u4bsfu?file=src%2Fpages%2Findex.js,src%2Fpages%2Findex.module.css
          <Link
            className="button button--secondary button--lg"
            to="/docs/intro/#getting-started"
          >
            {'/docs/intro/#getting-started'}
          </Link>

          <Link
            className="button button--secondary button--lg"
            to="/blog/welcome"
          >
            {'/blog/welcome'}
          </Link>

          <Link
            className="button button--secondary button--lg"
            to="/blog/welcome/"
          >
            {'/blog/welcome/'}
          </Link>

[WARNING] Docusaurus found broken anchors!
Please check the pages of your site in the list below, and make sure you don't reference any anchor that does not exist.
Note: it's possible to ignore broken anchors with the 'onBrokenAnchors' Docusaurus configuration, and let the build pass.
Exhaustive list of all broken anchors found:

Broken anchor on source page path = /:
-> linking to /docs/intro/#getting-started

If we don't report /blog/welcome/ as broken path, there's no reason to report /blog/welcome/#existingAnchor as a broken anchor.

But the pages themselves are accessible without trailing slash

That might be the case on your current host, or when using docusaurus serve, but it doesn't mean it will be the case for every host. To keep your site portable it's better to always link to the canonical URL.

@slorber thank you for your response.
I tried to repro it in a smaller setup, but wasn't able to.

That might be the case on your current host, or when using docusaurus serve, but it doesn't mean it will be the case for every host. To keep your site portable it's better to always link to the canonical URL.

Yes, the web server might treat these requests differently, depending on the trailing slash. In our case, it's Cloudflare Pages and both seem to work.
Is there some documentation about which URL is the canonical one? With or without trailing slash?

Is there some documentation about which URL is the canonical one? With or without trailing slash?

If you choose trailingSlash: undefined it depends if you put a trailing slash or not in your doc slugs. Otherwise it's the URL with/without the trailing slash according to the setting.
Otherwise your all site pages have this standard meta attribute that crawlers (Google) will use:
<link data-rh="true" rel="canonical" href="https://docusaurus.io/docs/installation">

And here's also some doc on how multiple hosts behave differently regarding trailing slash and static file hosting. As you will see, there's no standard behavior.
https://github.com/slorber/trailing-slash-guide


Adding OTC Option and Ordering Output Sections

This PR includes 2 changes designed to reduce the 'noise' experienced when committing context files to source control after regenerating them.
Change 1 - New Parameter
The below parameter has been included so if users wish to remove the generation of object type codes they can. This is useful for us as we develop in a number of different environments so the OTCs change causing PR noise. Additionally we do not use OTCs at all, so they are surplus.
{ command = "includeEntityTypeCode";
altCommands=["ietc"]
description = "Set to false to prevent generation of an Entity Type Code constant in each entity definition. Default is true."
required=false }
Change 2 - Ordering Output
While some sections of the context are alphabetised in the output, there are still some areas that are not. This can cause a headache at merge time as the orders can be very different and spotting the changes is a real challenge. Changes have been made to order any sections that are currently not ordered.
Thanks to all contributors to this project, it is instrumental in our CRM development approach.
James
WARP Technologies Limited

Added in 1.8.0


Simbad resolve name

With the latest PR (for Best2020 sources) there are ~450 sources without Simbad resolvable names. The test in test_integrity.py check just the primary name, perhaps they can/should be modified to only return a message if any name doesn't match and not just the primary key?

We should also think about our "policy" regarding the primary name be Simbad resolvable. Are we ok with the Simbad name just being in the Names table or do we want the primary name to always be Simbad resolvable if it's in Simbad.
I am pretty sure some of the primary names which are not resolving do indeed have Simbad names....so there's some work to do there.

NLTT 1011B is an example of an unresolvable name. I added an SIMBAD resolvable name to names table in #385

One possible option to maintain SIMBAD resolvable names without changing source names would be to modify/start with the find_survey_name_in_simbad function in ingest_utils to ingest the names in SIMBAD to the names table so all names in SIMBAD are at least available in other_names column


test rust caching in gh action

test rust caching in gh action to improve ci speed

Codecov Report

Merging #220 (a54a1a7) into main (d51e425) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head a54a1a7 differs from pull request most recent head ebf4e96. Consider uploading reports for the commit ebf4e96 to get more accurate results

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   73.74%   73.76%   +0.01%
==========================================
  Files          71       71
  Lines        5827     5827
==========================================
+ Hits         4297     4298       +1
+ Misses       1530     1529       -1

Impacted Files
Coverage Δ

quickwit-search/src/collector.rs
71.72% <0.00%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51e425...ebf4e96. Read the comment docs.


How do you control abr control in safari?

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.0
Please ask your question
When playing HLS images using ShakaPlayer in Safari, they automatically switch from low-definition to high-definition images. (360p -> 1080p )
In Chrome, you could disable abr control with the command below, but in Safari, how do you disable abr?
chrome:
player1.configure({abr: {enabled: false}});
My Video track: 360p / 480p / 720p / 1080p
Thanks !

If you are using Safari's native HLS implementation, Shaka Player is not in control of ABR.  In that case, there is no API in Safari to disable ABR (as far as I know).
On iOS, you don't have any other choice.  On desktop Safari, you can disable native HLS (and use Shaka's implementation) with:
player.configure('streaming.preferNativeHls', false);

Even if I set it up above, the video quality automatically changes :(
async function initPlayer() {
  const video1 = document.getElementById('video1');
  const player1 = new shaka.Player(video1);
  window.player1 = player1;

  player1.addEventListener('error', onErrorEvent);
  player1.configure({abr: {enabled: false}});
  player1.configure('streaming.preferNativeHls', false);
}

@baehongjun0212 are you using macOS or iOS?

On iOS, preferNativeHls: false can't work, because native HLS is all there is.  On desktop Safari, it's different.
Does this answer your question?


[app] escapes session save path dynamic path for consistency and for preventing any parsing issues.

Thank you @hhamon.


Compilation Albums of m4as not being marked as Compilation

It appears that m4as are not being properly marked as compilation even with AlbumArtist being all the same. I'm unfamiliar with php so I'm not entirely sure where the issue is. Could be an issue with AlbumArtist not being read properly due to the way m4as store metadata. A pretty minor issue but I don't believe it has been reported already. I can provide 2 properly tagged m4as from a compilation album if need be.
Koel version: 3.7.2
Node version: 8.9.1

Hi @Snailic! Normally these tag-related issues come from the getID3 library that Koel makes use of, but sure, if you could send the files over to me [at] phanan.net that would be great. Thanks!


assert with a message for mergers labeled as divisions

tracking algorithm does not allow mergers labeled as divisions

I will open it in ilastik/hytra...


How to convert image into 4d tensor typed Array

Hey @mrousavy ,
I have been working with a model which expects input in the following format.

Inputs:
float32 serving_default_input_1:0[1,768,768,3]

I have used the frame processor from react-native-vision-camera
   const frameProcessor = useFrameProcessor(
    frame => {
      'worklet';
      runAtTargetFps(1, () => {
        'worklet';
        if (actualModel == null) {
          // model is still loading...
          return;
        }
        const resized = resize(frame, {
          size: {
            width: 768,
            height: 768,
          },
          pixelFormat: 'rgb-uint8',
        });
        const result = actualModel.runSync([new Uint8Array(resized)]);
        console.log('result--->', result);
      });
    },
    [actualModel],
  );

My model is running and giving the same output for every frame. Can you help with that ?

Well you are resizing to uint8, that's not float.
I don't have float support yet, can you reformat your model to use uint8 instead?

And 4D arrays in TFLite are simply 1D arrays with the sum of the dimensions.


[#51] v1 api updates

this PR contains:

"v1beta1"->"v1" in readme and integration tests
all dependencies set to static versions to avoid breaking changes, httpretty updated after previous PR and now have a bit different way to specify binary data in mock uri, i think such updates should be done in separated PRs and if required
delete request now handles operation polling, and return operation name if operation is not reachable

Looks good! Can we also add an integration test? Looks like we have on for DeleteInstance, but not DeleteStudy/Series which return operations.

Looks good! Can we also add an integration test? Looks like we have on for DeleteInstance, but not DeleteStudy/Series which return operations.

done, now integration test uploads same file second time, deletes it by study id and performs compare of search result with expected


Intel(R) Distribution for Python's sklearn patches

of scikit-learn classes as a stand-alone module.
@fschlimb @anton-malakhov  @ogrisel
They can be invoked via
python -m daal4py.sklearn_patches  script.py args

or by explicitly enabling them via
import daal4py.sklearn_patches.dispatcher
daal4py.sklearn_patches.dispatcher.enable()

Names, design, etc. are up for discussion.

Très cool.
I suggest extending @ogrisel's structure to
- daal4py/
   - [native daal4py stuff]
    - __main__.cpp
    - sklearn/
        - decision_forest.py  # provides sklearn compatible estimator without having to patch
        - monkeypatch/  # has all the tools to monkeypatch the top level sklearn namespace.

This makes the '-m' feature more convienent and becomes '-m daal4py'.
Also, I suggest adding a function to the daal4py package so user can do
import daal4py
daal4py.patch_sklearn()

Also, please find a better name than 'daal4py_utils.py', maybe simply 'utils.py'.

We also need tests and documentation.
docu is generated through sphinx (and its autodoc) and lives on the gh-pages branch.

I have restructured the code as suggested. Monkey patching can now be enabled via python -m daal4py script.py.
I have used LooseVersion, updated the license.

Running
python -m daal4py -m pytest --disable-warnings --pyargs sklearn

in an environment with 0.20.1 installed currently produces 8 failures. One of them in test_parallel_classification which I can not explain today.

why not to rename the module as just daal - it will follow the same suit with mkl-service and tbb4py.

@anton-malakhov That would require renaming daal4py package into daal. That name has already been claimed by installed pydaal.

@ogrisel I looked into why test_parallel_classification fails.
Consider the following snippet:
# test_parallel_classifier.py
import sklearn
import sklearn.datasets
import sklearn.model_selection
import sklearn.utils
from sklearn.ensemble import BaggingClassifier
from sklearn.svm import SVC

iris = sklearn.datasets.load_iris()
rng = sklearn.utils.check_random_state(0)
X_train, X_test, y_train, y_test = sklearn.model_selection.train_test_split(
    iris.data, iris.target, random_state=rng)

backend = 'loky'
# backend = 'multiprocessing'
with sklearn.utils.parallel_backend(backend):
    base_est = SVC(gamma='scale', decision_function_shape='ovr')
    ensemble = BaggingClassifier(base_est, n_jobs = 2, random_state=0).fit(X_train, y_train)

print(ensemble.estimators_[0]._dual_coef_)

Execution vanilla scikit-learn with python test_parallel_classifier.py prints matrix of dual coefficients as expected.
Running the above snippet with monkey-patched code, python -m daal4py test_parallel_classifier.py
results in an error with n_jobs=2 and backend='loky', but not with n_jobs=1, or n_job=2 and backend='multiprocessing':
  File "test_parallel_classifier.py", line 19, in <module>
    print(ensemble.estimators_[0]._dual_coef_)
  File "./daal4py/sklearn/monkeypatch/svm.py", line 33, in _dual_coef_getter
    return self._internal_dual_coef_
AttributeError: 'SVC' object has no attribute '_internal_dual_coef_'

The following is my account of what transpires to the best of my understanding.

Monkey patching adds _dual_coef_ attribute to the class SVC, set be property(_dual_coef_getter, _dual_coef_setter). These are implemented in svm.py#L32-53, and serve the purpose of deleting daal_model from the instance if someone attempts to modify _dual_coef_ (see svm/tests/test_svm::test_tweak_params).

With 'loky' the instance of the class on the worker ends up being non-monkey patches. The fitted instances has attribute _dual_coef_ set to an explicit array. (I checked this by adding prints to _parallel_build_estimators in ensemble/bagging.py)

When results are gather at the host, somehow the fitted instances are those of the patched class, and the computed on the worker value of _dual_coef_ does not overwrite the property, but gets discarded.
The value of _internal_dual_coef_ was never set by un-patched fit on the worker, resulting in the observed behavior.

This problem is not observable if daal4py.sklearn.patch_sklearn() is called from sklearn/__init__.py, since instances of SVC on workers appear to be patched.
Hence questions:

If monkey patching is not done inside sklearn/__init__.py, is there a way to ensure that patching is also applied to the workers spawned by loky?
If that proves impossible, could you suggest a way to adjust _internal_dual_coef_getter to have a reasonable fall-back if _internal_dual_coef_ attribute is unavailable? Can the value of dual_coef_ be reused?
The only reason these setter and getter were added is to pass test_tweak_params test. Perhaps it is better/easier to mark this test as expected to fail with monkey patching?

Thanks for your input.

If monkey patching line is added to site-packages/sklearn/__init__.py , run of pytest --disable-warnings --pyargs sklearn completes with 6 failures, 5 of which all related to use of SVC. These are

sklearn.ensemble.tests.test_bagging::test_sparse_classification
sklearn.svm.tests.test_sparse::test_svc_iris
sklearn.svm.tests.test_sparse::test_sparse_realdata
`sklearn.svm.tests.test_svm::test_precomputed``
sklearn.svm.tests.test_svm::test_sample_weights

The other failing test is sklearn.cluster.tests.test_k_means::test_k_means_fit_predict. This is resolved of n_init is set to 1, instead of default 10.
The cluster of 5 SVC-related failures all have one thing in common. The dataset contains duplicate samples, or bagging results in choosing a subset of features, for which such duplicate samples appear.
I feel compelled to point out that such inputs lead to quadratic optimization problem with non-positive definite matrix Q, leading to ambiguity, typically resolved via use of parameter tau (see src/libsvm/svm.cpp#L89). While it is important for the implementation to gracefully handle such inputs, they can not be clearly separated into clusters, and lead of ambiguities and sensitivity of the solution to platform/compiler specific quirks.
I was able to resolve some of these failures by strengthening tolerance parameter:
diff --git a/sklearn/ensemble/tests/test_bagging.py b/sklearn/ensemble/tests/test_bagging.py
index 608df3dc43..5dcfd4dbea 100644
--- a/sklearn/ensemble/tests/test_bagging.py
+++ b/sklearn/ensemble/tests/test_bagging.py
@@ -118,7 +118,7 @@ def test_sparse_classification():
             for f in ['predict', 'predict_proba', 'predict_log_proba', 'decision_function']:
                 # Trained on sparse format
                 sparse_classifier = BaggingClassifier(
-                    base_estimator=CustomSVC(gamma='scale',
+                    base_estimator=CustomSVC(gamma='scale', tol=1e-8,
                                              decision_function_shape='ovr'),
                     random_state=1,
                     **params
@@ -127,7 +127,7 @@ def test_sparse_classification():

                 # Trained on dense format
                 dense_classifier = BaggingClassifier(
-                    base_estimator=CustomSVC(gamma='scale',
+                    base_estimator=CustomSVC(gamma='scale', tol=1e-8,
                                              decision_function_shape='ovr'),
                     random_state=1,
                     **params

and sometimes additionally loosening out fuzz:
diff --git a/sklearn/svm/tests/test_sparse.py b/sklearn/svm/tests/test_sparse.py
index ce14bda1db..33f695538a 100644
--- a/sklearn/svm/tests/test_sparse.py
+++ b/sklearn/svm/tests/test_sparse.py
@@ -138,17 +138,17 @@ def test_svc_with_custom_kernel():
 def test_svc_iris():
     # Test the sparse SVC with the iris dataset
     for k in ('linear', 'poly', 'rbf'):
-        sp_clf = svm.SVC(gamma='scale', kernel=k).fit(iris.data, iris.target)
-        clf = svm.SVC(gamma='scale', kernel=k).fit(iris.data.toarray(),
+        sp_clf = svm.SVC(gamma='scale', kernel=k, tol=1e-10).fit(iris.data, iris.target)
+        clf = svm.SVC(gamma='scale', kernel=k, tol=1e-10).fit(iris.data.toarray(),
                                                    iris.target)

         assert_array_almost_equal(clf.support_vectors_,
                                   sp_clf.support_vectors_.toarray())
-        assert_array_almost_equal(clf.dual_coef_, sp_clf.dual_coef_.toarray())
+        assert_array_almost_equal(clf.dual_coef_, sp_clf.dual_coef_.toarray(), decimal=4, err_msg=k)
         assert_array_almost_equal(
             clf.predict(iris.data.toarray()), sp_clf.predict(iris.data))
         if k == 'linear':
-            assert_array_almost_equal(clf.coef_, sp_clf.coef_.toarray())
+            assert_array_almost_equal(clf.coef_, sp_clf.coef_.toarray(), decimal=4)

 def test_sparse_decision_function():
@@ -310,11 +310,12 @@ def test_sparse_realdata():
          3., 0., 0., 2., 2., 1., 3., 1., 1., 0., 1., 2., 1.,
          1., 3.])

-    clf = svm.SVC(kernel='linear').fit(X.toarray(), y)
-    sp_clf = svm.SVC(kernel='linear').fit(sparse.coo_matrix(X), y)
+    clf = svm.SVC(kernel='linear', tol=1e-10).fit(X.toarray(), y)
+    sp_clf = svm.SVC(kernel='linear', tol=1e-10).fit(sparse.coo_matrix(X), y)

+    assert_array_equal(clf.support_, sp_clf.support_)
     assert_array_equal(clf.support_vectors_, sp_clf.support_vectors_.toarray())
-    assert_array_equal(clf.dual_coef_, sp_clf.dual_coef_.toarray())
+    assert_array_almost_equal(clf.dual_coef_, sp_clf.dual_coef_.toarray())

 def test_sparse_svc_clone_with_callable_kernel():

I'd like to argue that such failures are not misleading, and I'd suggest to add noise to the input data used for SVM to resolve any sample duplicates.
Perhaps I should open a separate discussion issue to this effect in scikit-learn project.

Before merging this PR, I think it would be good to change the travis configuration to launch the sklearn tests for the last stable vanilla release of scikit-learn with the code of the patches daal4py from this repo.
By looking at the current travis config, it seems that the daal4py tests them selves are not run by travis. Is this intentional? Or are they run automatically by conda build?
Latter we can also add a travis cron job that does the same against scikit-learn master.

Yes, the tests are run by conda build which is called in travis CI.

I'd like to have travis only run a the subset of sklearn tests that are affected by the daal4py. It should finish in reasonable time.
A cron job for regular full sklearn testing makes sense to me.

@ogrisel I tried to implement a work-around for the issue of interaction between loky and dynamic monkey-patching where workers end up being unpatched, and issues arise when combining worker results (trained instances) and clones of patches class on the host.
That can be found in branch features/sklearn-patches-try-subclassing. With this change, new failures sprout, like this one
python -m daal4py -m pytest --disable-warnings --pyargs sklearn.svm.tests.test_svm::test_unfitted

stemming from exception messages now containing the name of the class used to replace SVC instead of SVC itself:
>       raise self.test_case.failureException(msg)
E       AssertionError: ".*\bSVC\b.*\bnot\b.*\bfitted\b" does not match "This SVC_daal4py instance is not fitted yet. Call 'fit' with appropriate arguments before using this method."

Do you have any suggestions on how to work around these issues, or perhaps change the test to allow for patched test to pass tests.
Thank you

Wouldn't be possible to keep the same class names a strategy that looks like the following:
from sklearn.svm import SVC as SVC_sklearn

class SVC(SVC_sklearn):
    # put the patched method here

install_patch():
    from sklearn import svm
    sklearn.svm.SVC = SVC


Use keymaps to handle keyboard shortcuts

Currently handling keyboard commands manually in the modal tool. Use the Blender keymap system instead for configurability.

There doesn't seem to be good documentation on creating modal tool keymaps for addons yet. Temporarily displaying a modal keymap in addon preferences but this is put on hold until better documentation appears.
This is my Stack Exchange question on the issue: https://blender.stackexchange.com/questions/67427/modal-keymaps-for-modal-operators


Error: stat /dev/null/pre-push: not a directory 32.06  ELIFECYCLE  Command failed with exit code 1.

:wrench: Summary
This error happens when execute 'lefthook install' command in a docker build command with a react UI project.(in CICD ENV)
However, we can not encounter the same error in local PC when manually build an image with docker command.
The command pre-push is located at .git/command not the location '/dev/null/pre-push'
It seems that the method to get the command(pre-push) location(dir) is not correct in some conditions.

Lefthook version 1.5.0/1.6.5

Steps to reproduce
docker build --no-cache --network=host --pull --build-arg GOPROXY= --build-arg VERSION= --build-arg GIT_COMMIT= -t  -f ./Dockerfile.test .
Dockerfile.test:
RUN pnpm i
package.json:
"prepare": "lefthook install",

Expected results
The command 'RUN pnpm i ' should be executed successfully and image should be built successfullly.

Actual results
Error: stat /dev/null/pre-push: not a directory 32.06  ELIFECYCLE  Command failed with exit code 1.

Possible Solution

Logs / Screenshots

LEFTHOOK_VERBOSE=true git ...

Hey! Do you still have issues with lefthook auto install?

@ragrag what does git rev-parse --git-path hooks return in your case?

@mrexox thank you, when i run this in the repo root i get /dev/null

Looks like you have the git hooks configured to /dev/null. Please restore using this command: git config core.hooksPath .git/hooks/

@mrexox thank you for the help that did it!

would it make sense for lefthook to automatically set this when its incorrectly /dev/null? i seem to have this on all new git repos, (forgive me i'm not so fluent in git)

@ragrag you probably have a global config ~/.gitconfig with hooksPath set to /dev/null 🤔 I am not sure about it, but by default git must have .git/hooks configured for hooksPath.
Sometimes people use different hooksPath in their repos, and lefthook must adapt to this, so changing it implicitly may confuse other users. I think that this is more of a git-related things that lefthook-related.


Added DOER metric

#126 was added

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 11min)

Well, I tried removing the wrong spaces

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 10min)

@ocelot335 try to run make clean lint locally

@yegor256, can you please try again?

@rultor merfe

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@ocelot335 @yegor256 Oops, I failed. You can see the full log here (spent 10min)

Well, I forgot to update number of metrics, sorry

@rultor merge

@rultor merge

@ocelot335 @yegor256 Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@ocelot335 thanks!


[sysrst_ctrl,dv] Fix combo detect test

Signed-off-by: Madhuri Patel<EMAIL_ADDRESS>

This test is fixed in another pull request so I am closing this pull request


[Question] Is there a way to use custom browser version in Playwright?

Is there a way to use custom browser version in Playwright? This code from
Selenium allows us to have custom version of driver and some browser configuration. Does playwright have something like that? Do you maybe have any code example?
System.setProperty("webdriver.chrome.driver","X://chromedriver.exe");
ChromeOptions options = new ChromeOptions();
options.addArguments("--incognito");
ChromeDriver driver = new ChromeDriver(options);

You can specify custom path to a Chromium based browser via setExecutablePath option. Another way to run Playwright with a preinstalled official build of Google Chrome or MS Edge is to set browser channel as described in this guide.

Can you do this with Firefox?

No, stock firefox doesn't have necessary debugging protocol.


How to custom the color of rainbowcol1?

I custom the color of bracket like TSVariable, but it does not work.
highlights = {
           TSVariable = { fg = "#e06150" },
           TSParameter = { fg = "#ffb900" },
           rainbowcol1 = "#ff8800",
       },

Use fg as any other highlight group
require('onedark').setup {
  highlights = {
    rainbowcol1 = {fg = "#000000"},
    rainbowcol2 = {fg = "#000000"},
    rainbowcol5 = {fg = "#000000"},
    rainbowcol3 = {fg = "#000000"},
    rainbowcol4 = {fg = "#000000"},
    rainbowcol6 = {fg = "#000000"},
    rainbowcol7 = {fg = "#000000"},
  }
}

Thank you!


python311Packages.flux-led: 1.0.1 -> 1.0.2

Diff: https://github.com/Danielhiversen/flux_led/compare/refs/tags/1.0.1...1.0.2
Changelog: https://github.com/Danielhiversen/flux_led/releases/tag/1.0.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249083 run on x86_64-linux 1

12 packages built:

home-assistant-component-tests.flux_led
home-assistant-component-tests.led_ble
ledfx
ledfx.dist
python310Packages.flux-led
python310Packages.flux-led.dist
python310Packages.led-ble
python310Packages.led-ble.dist
python311Packages.flux-led
python311Packages.flux-led.dist
python311Packages.led-ble
python311Packages.led-ble.dist


Fixes newline token counting issue on Windows

Replaces \r\n newlines with \n to fix an issue with how newlines are counted as tokens
Fixes issue #145

@kayhantolga looks good to me! I can also confirm that now both tokenization tests succeed in my machine


How to delete the iso from cd_files

Looks like there is an ISO that gets dynmically created and uploaded to images when you are using "cd_files", how do I delete this ISO after packer is completed?
Also, Is ther a cd_name attribute that I can also name it the same each time?   if so, is there a cd_overwriet option? so if its there it will just delete and create a new one?
Otherwise I have a ton of Packer_* iso files that are gathering on each deployment?

today, image is automatically deleted if the build is succesfull
i will change the behaviour to change it and delete it in all case

Perfect, as it really doesn't need to there after the deploy is done that I can think of anyway.


About pretrained model weight

Hi, Thank you very much for publishing the source code. But I would like to know that can you share with the pretrained model weight?

Checkpoints available at https://github.com/mindslab-ai/nuwave/issues/18.