Bug: Air conditioner temperature not able to change

Describe The Bug
Whenever I use the apple's native home app to change the temperature of my air conditioner, it doesn't change the temperature at all. And also, I always select the cooling mode when I turn on, but instead does heating. The number of the temperature i set using a remote controller and the temperature displayed on the apple home app doesn't sync. As you can see from the log, program has failed to send statusCode instead sending the value of %s,%s,%s,%s
To Reproduce
TOSHIBA air conditioner and change temperature from apple's home app
Expected behavior
Temperature not changing
Relevant log output
[10/6/2021, 4:25:24 PM] [SwitchBot] Trigger Get CurrentTemperture
[10/6/2021, 4:25:24 PM] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "NaN" (number). See https://git.io/JtMGR for more info.
[10/6/2021, 4:25:24 PM] [@switchbot/homebridge-switchbot] Error:
    at CurrentTemperature.Characteristic.characteristicWarning (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2038:105)
    at CurrentTemperature.Characteristic.validateUserInput (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1931:16)
    at CurrentTemperature.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1456:24)
    at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:143:27)
    at Object.next (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:124:57)
    at fulfilled (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:114:62)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
[10/6/2021, 4:26:48 PM] [SwitchBot] Sending request for Air conditioner  Air Conditioner to SwitchBot API. command: setAll parameter: %s,%s,%s,%s commandType: command
[10/6/2021, 4:26:48 PM] [SwitchBot] %s %s pushChanges -
[10/6/2021, 4:26:49 PM] [SwitchBot] %s %s Changes pushed -
[10/6/2021, 4:26:49 PM] [SwitchBot] Unknown statusCode.
[10/6/2021, 4:27:22 PM] [SwitchBot] Sending request for Air conditioner  Air Conditioner to SwitchBot API. command: setAll parameter: %s,%s,%s,%s commandType: command
[10/6/2021, 4:27:22 PM] [SwitchBot] %s %s pushChanges -
[10/6/2021, 4:27:23 PM] [SwitchBot] %s %s Changes pushed -
[10/6/2021, 4:27:23 PM] [SwitchBot] Unknown statusCode.

Config for homebridge-switchbot
{
    "bridge": {
        "name": "Homebridge 2486",
        "username": "",
        "port":,
        "pin": ""
    },
    "accessories": [],
    "platforms": [
        {
            "name": "Config",
            "port": 8581,
            "platform": "config"
        },
        {
            "name": "SwitchBot",
            "credentials": {
                "openToken": "",
                "notice": "Keep your token a secret!"
            },
            "platform": "SwitchBot"
        }
    ]
}

Screenshots
No response
Device & Model
WH-UB01UJ (model of air conditioner)
W0202200 (model of Switchbot hub mini)
Node.js Version
v14.17.4
NPM Version
v7.24.0
Homebridge Version
v1.3.4
Homebridge Switchbot Plugin Version
v0.1.1
Homebridge Config UI X Plugin Version
v4.41.2
Operating System
macOS

I tried with latest beta but it's still the exact same result

@ilhuafbds When I get time I will look into this

@ilhuafbds, can you try Beta:

Can confirm the latest beta v0.1.2-bueta.39 does not work. Comes up with he same error.

The log I posted is copied from the homebridge server log.

@donavanbecker It's all the commands made when I tried to change the temperature from the apple home app.

When I change the temperature from the Switchbot app it works just fine.

@ilhuafbds okay I just pushed a new beta out can you try it?
@, can you try Beta:

It seems new beta version software cannot recognize my Hub mini. Every IR devices are not shown on HomeBridge.

 No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
npm ERR!
npm ERR! No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.
npm ERR!
npm ERR! No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.
npm ERR!
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
npm ERR! gyp ERR! build error
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (events.js:400:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
npm ERR! gyp ERR! System Darwin 21.1.0
npm ERR! gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /usr/local/lib/node_modules/@switchbot/homebridge-switchbot/node_modules/@abandonware/noble
npm ERR! gyp ERR! node -v v14.17.4
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok

npm ERR!      /Users//.npm/_logs/2021-11-07T09_45_00_125Z-debug.log

Command failed. Please review log for details.

@donavanbecker When I tried to install your latest beta, an error showed up and I couldn't install it.

@ilhuafbds Did you read the warning? You need to update your node version.

@ilhuafbds and @618116, sorry latest beta should work now.

Tested new beta, unfortunately it did not work.
Turn On and Off Air Conditioner works, however Set temperature does not works and there is Error(172) in SwitchBot app log.
This is log from HomeBridge plugin Debug mode when turn on Air Conditioner with setting "24℃, Heater" in iOS Home app:
[11/13/2021, 11:29:30 PM] [SwitchBot] [DEBUG] エアコン Set Active: 1 [11/13/2021, 11:29:30 PM] [SwitchBot] Sending request for エアコン to SwitchBot API. command: turnOn parameter: default commandType: command [11/13/2021, 11:29:30 PM] [SwitchBot] [DEBUG] エアコン pushChanges - {"commandType":"command","parameter":"default","command":"turnOn"} [11/13/2021, 11:29:31 PM] [SwitchBot] [DEBUG] エアコン Changes pushed - [object Object] [11/13/2021, 11:29:31 PM] [SwitchBot] [DEBUG] Command successfully sent. [11/13/2021, 11:29:32 PM] [SwitchBot] Sending request for エアコン to SwitchBot API. command: setAll parameter: 24,1,1,on commandType: command [11/13/2021, 11:29:32 PM] [SwitchBot] [DEBUG] エアコン pushChanges - {"commandType":"command","command":"setAll","parameter":"24,1,1,on"} [11/13/2021, 11:29:33 PM] [SwitchBot] [DEBUG] エアコン Changes pushed - [object Object] [11/13/2021, 11:29:33 PM] [SwitchBot] [DEBUG] Unknown statusCode.
And SwitchBot app had 2 logs:
"On, Heater, Auto, 25℃", "Error(172)"

Version 1.2.0 has been released, Please update me on this, and if it has been resolved with this version.

Unfortunately, still not fixed. Below is log from Homebridge when trying to turn on with 29℃ setting.

11/20/2021, 2:53:19 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン Set Active: 1
[11/20/2021, 2:53:19 PM] [SwitchBot] Air Conditioner: エアコン Sending request to SwitchBot API. command: turnOn, parameter: default, commandType: command
[11/20/2021, 2:53:21 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン pushChanges: [object Object]
[11/20/2021, 2:53:21 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン Command successfully sent.
[11/20/2021, 2:53:21 PM] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Active': characteristic was supplied illegal value: number 29 exceeded maximum of 1. See https://git.io/JtMGR for more info.
[11/20/2021, 2:53:21 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン TargetHeaterCoolerState: undefined
[11/20/2021, 2:53:21 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン HeatingThresholdTemperature: undefined

SwitchBot app log shows only "turn on, heat, auto, 24℃" log.
Also If I try to change temperature in home app, SwitchBot app log shows Error(172).

Hi i have Air conditioner temperature changing issue too
this is my log. i can't find issue related my error type so write here
i just updated plugin 1.2.0 but still got errors when change temperature while turn on/off is fine.
[20/11/2021, 19:45:30] [SwitchBot] Air Conditioner: Air conditioner Sending request to SwitchBot API. command: turnOn, parameter: default, commandType: command
[20/11/2021, 19:45:32] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic Active: 1
[20/11/2021, 19:45:32] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic RotationSpeed: 4
[20/11/2021, 19:45:32] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentTemperature: 24
[20/11/2021, 19:45:32] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentHeaterCoolerState: 0
[20/11/2021, 19:45:42] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner CurrentTemperature: 20, LastTemperature: 24
[20/11/2021, 19:45:43] [SwitchBot] Air Conditioner: Air conditioner Sending request to SwitchBot API. command: setAll, parameter: 20,1,1,on, commandType: command
[20/11/2021, 19:45:44] [SwitchBot] Air Conditioner: Air conditioner Device internal error due to device states not synchronized with server, Or command: {"statusCode":190,"body":{},"message":"Cannot read property 'toString' of null"} format is invalid
[20/11/2021, 19:45:44] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic Active: 1
[20/11/2021, 19:45:44] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic RotationSpeed: 4
[20/11/2021, 19:45:44] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentTemperature: 20
[20/11/2021, 19:45:44] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentHeaterCoolerState: 3
[20/11/2021, 19:45:47] [SwitchBot] Air Conditioner: Air conditioner Sending request to SwitchBot API. command: turnOff, parameter: default, commandType: command
[20/11/2021, 19:45:48] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic Active: 0
[20/11/2021, 19:45:48] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic RotationSpeed: 4
[20/11/2021, 19:45:48] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Active': characteristic was supplied illegal value: number 20 exceeded maximum of 1. See https://git.io/JtMGR for more info.
[20/11/2021, 19:45:48] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentTemperature: 20
[20/11/2021, 19:45:48] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner updateCharacteristic CurrentHeaterCoolerState: 3
[20/11/2021, 19:46:16] [SwitchBot] [DEVICE] Air Conditioner: Air conditioner CurrentHeaterCoolerState: 0

Having the same issue with a Mitsubishi AC.
Log:
[23/11/2021, 17:06:19] [Homebridge UI] Homebridge log truncated by hughfr4nc15.
[23/11/2021, 17:06:20] [SwitchBot] Air Conditioner: Master Bedroom AC CurrentTemperature: 23, LastTemperature: 22
[23/11/2021, 17:06:22] [SwitchBot] Air Conditioner: Master Bedroom AC Sending request to SwitchBot API. command: setAll, parameter: 23,1,1,on, commandType: command
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC pushChanges: [object Object]
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC Unknown statusCode.
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC updateCharacteristic Active: 1
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC updateCharacteristic RotationSpeed: 4
[23/11/2021, 17:06:23] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Active': characteristic was supplied illegal value: number 23 exceeded maximum of 1. See https://git.io/JtMGR for more info.
[23/11/2021, 17:06:23] [@switchbot/homebridge-switchbot] Error:
    at Active.Characteristic.characteristicWarning (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\homebridge\node_modules\hap-nodejs\src\lib\Characteristic.ts:2074:105)
    at Active.Characteristic.validateUserInput (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\homebridge\node_modules\hap-nodejs\src\lib\Characteristic.ts:1986:16)
    at Active.Characteristic.updateValue (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\homebridge\node_modules\hap-nodejs\src\lib\Characteristic.ts:1415:20)
    at HeaterCooler.Service.updateCharacteristic (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\homebridge\node_modules\hap-nodejs\src\lib\Service.ts:481:35)
    at AirConditioner.updateHomeKitCharacteristics (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\@switchbot\homebridge-switchbot\src\irdevices\airconditioners.ts:183:21)
    at AirConditioner.pushChanges (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\@switchbot\homebridge-switchbot\src\irdevices\airconditioners.ts:343:12)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at AirConditioner.pushAirConditionerDetailsChanges (C:\Users\Hugo Francisco\AppData\Roaming\npm\node_modules\@switchbot\homebridge-switchbot\src\irdevices\airconditioners.ts:331:5)
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC updateCharacteristic CurrentTemperature: 23
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC TargetHeaterCoolerState: undefined
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC updateCharacteristic CurrentHeaterCoolerState: 2
[23/11/2021, 17:06:23] [SwitchBot] Air Conditioner: Master Bedroom AC HeatingThresholdTemperature: undefined
[23/11/2021, 17:06:24] [SwitchBot] Meter: Master Bedroom Meter OpenAPI RefreshStatus
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter openAPIRefreshStatus: {"statusCode":100,"body":{"deviceId":"C9EC03C1F591","deviceType":"Meter","hubDeviceId":"D680602B728C","humidity":49,"temperature":23.9},"message":"success"}
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter OpenAPI parseStatus
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter Humidity: 49%
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter Temperature: 23.9°c
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter updateCharacteristic StatusLowBattery: 0
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter updateCharacteristic BatteryLevel: 100
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter updateCharacteristic CurrentRelativeHumidity: 49
[23/11/2021, 17:06:25] [SwitchBot] Meter: Master Bedroom Meter updateCharacteristic CurrentTemperature: 23.9

Let me know if I can provide anything more useful.
Thanks.

@hughfr4nc15, can you try Beta:

Click here to find out how to install Beta

Hello @donavanbecker, I've returned the equipments a couple of days after... If in the near future all works well I might try them again because they seem a cheap alternative to control the AC.
I'll keep following the project.
Thanks.

update 1.3.0 but still got errors
[06/12/2021, 21:48:04] [SwitchBot] Air Conditioner: Air conditioner pushChanges: {"statusCode":190,"body":{},"message":"Cannot read property 'toString' of null"}
[06/12/2021, 21:48:04] [SwitchBot] Air Conditioner: Air conditioner Device internal error due to device states not synchronized with server, Or command: {"statusCode":190,"body":{},"message":"Cannot read property 'toString' of null"} format is invalid

Tried 1.3.1-beta1 13. Not fixed.
Log from HomeBridge:
[12/13/2021, 7:38:27 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン pushChanges: [object Object] [12/13/2021, 7:38:27 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン Unknown statusCode. [12/13/2021, 7:38:27 PM] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Active': characteristic was supplied illegal value: number 27 exceeded maximum of 1. See https://git.io/JtMGR for more info. [12/13/2021, 7:38:27 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン TargetHeaterCoolerState: undefined [12/13/2021, 7:38:27 PM] [SwitchBot] [DEBUG] Air Conditioner: エアコン HeatingThresholdTemperature: undefined
SwitchBot App returned Error(172).

I have the same problem with 1.4.0 and get the logs below.
It seems this plugin push [temperture, 1, 1, on] regardless of HeaterCoolerState, which I set in the UI.
The second paramter indicate HeaterCoolerState: https://github.com/OpenWonderLabs/SwitchBotAPI.
All error logs shown in this thread also push the parameters with the same form above.
[12/18/2021, 12:57:56 PM] [SwitchBot] Air Conditioner: MyDeviceName Sending request to SwitchBot API. command: setAll, parameter: [21,1,1,on], commandType: command
[12/18/2021, 12:57:57 PM] [SwitchBot] Air Conditioner: MyDeviceName pushChanges: {"statusCode":190,"body":{},"message":"Cannot read property 'length' of null"}
[12/18/2021, 12:57:57 PM] [SwitchBot] Air Conditioner: MyDeviceName Device internal error due to device states not synchronized with server, Or command: {"statusCode":190,"body":{},"message":"Cannot read property 'length' of null"} format is invalid

I also tested the native SwitchBot API on python and found the facts below.
First, With auto mode (HeaterCoolerState=1), my air conditioner allows only 25 degrees, i.e., parameters of [25, 1, 1, on].
This plugin also successfully changed my air conditioner under this condition and got logs below.
My SwitchBot app also fixes the temper with 25 degrees with auto mode.
[12/18/2021, 1:07:27 PM] [SwitchBot] Air Conditioner: MyDeviceName Sending request to SwitchBot API. command: setAll, parameter: [25,1,1,on], commandType: command
[12/18/2021, 1:07:28 PM] [SwitchBot] Air Conditioner: MyDeviceName pushChanges: {"statusCode":100,"body":{},"message":"success"}

Second, It seems that the IR devices have no method to get the current state: https://github.com/OpenWonderLabs/SwitchBotAPI.
So, I think some problems occur around updating the current state.
I will share the results of my research so far.

I also tested the native SwitchBot API on python and found the facts below. First, With auto mode (HeaterCoolerState=1), my air conditioner allows only 25 degrees, i.e., parameters of [25, 1, 1, on]. This plugin also successfully changed my air conditioner under this condition and got logs below. My SwitchBot app also fixes the temper with 25 degrees with auto mode.

Thanks @y-muen!!! I have implemented this into that last beta. This should fix mostly everything.
@ilhuafbds @618116 @hughfr4nc15 @jhy-dabeeo, can you try the latest beta:

Click here to find out how to install Beta

Release v1.5.0, which fixes this issue. Closing issue. If other issues with Air Conditioner come up please open new issue.


Hex stuff is a bit of a mess

Issue to track all the hex discussion in one place and come up with a solution, please add links to any stuff that I've missed.
Converting to and from hex is common in bitcoin code. We used to have ToHex and FromHex, they were brain-dead easy to use but were inefficient. In attempting to improve on this we have gotten ourselves into a bit of a mess.  The current APIs are hard to use and hard to understand when to use which of the traits/functions - for library devs and also for users.
Parsing/Deserializing

We have hex::FromHex and also bitcoin::FromHexStr
We use FromStr coupled with Display and also FromHex coupled with DisplayHex, which to call
may not be obvious for users.
We are missing consensus::encode::deserialize_hex() (for types that implement Decodable)

Printing/Serializing

The hex::DisplayHex API is difficult to use, and difficult to implement. This is based on my subjective experience as well as complaints from others (see below).
We have a hex module in consensus::serde which AFAICT is currently unused.
We have consensus::encode::serialize_hex() for types that implement Encodable

Missing pieces

consensus::deserialize_hex (https://github.com/rust-bitcoin/rust-bitcoin/pull/2039)
Re-implement HexWriter (https://github.com/rust-bitcoin/rust-bitcoin/issues/1586)
Easy way to print transactions (https://github.com/rust-bitcoin/rust-bitcoin/issues/1706)

Complaints
Multiple people have complained about our removal of the very simple ToHex / FromHex traits (I can't find the thread where this was discussed, and the suggested solution to re-introduce them).
My two cents
I think we have made good progress, the new hex stuff is more correct and more efficient. A large part of the problem is, I believe, that we haven't finished the work. Its in such a mess now that I don't really know what direction to push - hence this issue. Please take this issue as an attempt to pull everything together, not as a whinge about the current stuff we have done.
Related issues/PRs

#1400
#2308
#1706
#2218

PR where we added FromStrHex: https://github.com/rust-bitcoin/rust-bitcoin/issues/1112

PR to add logic from FromHexStr to the hex-conservative module: https://github.com/rust-bitcoin/hex-conservative/pull/58

Slightly related: https://github.com/rust-bitcoin/rust-bitcoin/issues/2218

(I added "Related issues/PRs" section and deleted previous multiple comments with the same links.)

We have hex::FromHex and also bitcoin::FromHexStr

Originally FromHex was intended for hex-encoded bytes, not integers. FromHexStr for integers. The main difference being that hex-encoded bytes never start with 0x prefix so trying to write that code would be silly/buggy. However as I found out this accidentally changed during the transition to the hex crate and I disagree with the change. Or at least no prefix should be the default.

We use FromStr coupled with Display and also FromHex coupled with DisplayHex, which to call
may not be obvious for users.

Regarding former: Honestly, people should learn idiomatic Rust (or any language they work with) and not chase workarounds. That being said, I propose a hex encoding chapter int the cookbook.
Regarding latter: these should be only used on raw slices/arrays/vecs, not on our types. Ideally, people shouldn't call them at all (or rather, they're not bitcoin problem but hex-conservative problem, so if people are inventing their own hex protocols that's on them). This should be prominently documented in the hex-conservative crate.
I think a bunch of misunderstanding stems from people thinking hex-conservative is meant to be a replacement for bitcoin_hashes::hex which strictly it isn't.

We are missing consensus::encode::deserialize_hex()

Yes. I've hit this in the past too. I think we can share the code with consensus::serde but it'll need some refactoring.

The hex::DisplayHex API is difficult to use

How?

and difficult to implement

It shouldn't be implemented on anything else then what it already is implemented on - arrays and slices. Maybe it should be sealed. Needs doc I think.

We have a hex module in consensus::serde which AFAICT is currently unused.

It is used in the tests, async-electrum-client, and it might be used in Firefish in the future (we use base64 for now).

A large part of the problem is, I believe, that we haven't finished the work.

I think that a large part is that people got used to obviously, inherently inefficient API and refuse to make their code more efficient. :) If the API was good from beginning it'd be much less noise. But sure, let's help them out. Just let's not go backwards.

I think a bunch of misunderstanding stems from people thinking hex-conservative is meant to be a replacement for bitcoin_hashes::hex which strictly it isn't.

Then what are people supposed to replace bitcoin_hashes::hex with?

The hex::DisplayHex API is difficult to use

Using it is not so bad. Implementing is really weird. Usually you want to just convert your type to an array or slice and then call into the existing implementations, but if you can't do that then you've gotta implement a bunch of boilerplate. Similar problem to serde.

It shouldn't be implemented on anything else then what it already is implemented on - arrays and slices. Maybe it should be sealed. Needs doc I think.

Lol, if it's sealed then users have literally nowhere to go to implement hex encoding for their own crates. If this is the direction that hex-conservative is going then I will have to create my own bitcoin-hex and move rust-bitcoin to that.

Then what are people supposed to replace bitcoin_hashes::hex with?

Display/LowerHex/UpperHex/FromStr

but if you can't do that then you've gotta implement a bunch of boilerplate

When you can't do that?

users have literally nowhere to go to implement hex encoding for their own crates.

fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
    fmt::LowerHex::fmt(&self.inner_raw_bytes.as_hex(), f)
}

Where's the problem?

Where's the problem?

When there is no inner_raw_bytes, as in (for example) bitcoin::Transaction.

Then the trait being unsealed won't help you anyway.
But it is a different missing feature: https://github.com/rust-bitcoin/rust-bitcoin/issues/1586

#1586 is the last piece for this issue, I"m closing it now because 1586 is marked as milestone 0.32.0 so won't be forgotten.


Use TableMaker with GraphQL

We've been encountering some issues while hooking up tablemaker to CraftQL. In particular, we've been unable to read row/column data from the table field of our content type. Instead, our query throws this error:
{
    "error": "String cannot represent non scalar value: associative array(3) with first keys: \"columns\", \"rows\", \"table\""
}

Is there anything that we can do about this?

@engram-design why was a PR for this closed a few weeks ago

Ah, looks like due to deleting the master branch (in favour of craft-3 and craft-4) closed the PR. I've just merged this manually for the next release. To get this early, change your verbb/tablemaker requirement in composer.json to:
Craft 3
"require": {
  "verbb/tablemaker": "dev-craft-3 as 3.0.1",
  "...": "..."
}

Craft 4
"require": {
  "verbb/tablemaker": "dev-craft-4 as 4.0.1",
  "...": "..."
}

Then run composer update.

Thanks a ton @engram-design

Added in 3.0.2 and 4.0.2


Installing on Raspberry Pi OS does not automatically install dependencies

When running pip install tls-client I encountered that the file tls-client-arm.so was missing. After copying it over to the right directory everything was running as it was supposed to.

Hi,
Could you please let me know where you found the file tls-client-arm.so?
Thank you!

@JerryXu09 It can be found in this repo under dependencies: https://github.com/FlorianREGAZ/Python-Tls-Client/tree/master/tls_client/dependencies

@StephanAkkerman Thanks a lot!


Resolve CI::Actions via API

https://github.blog/changelog/2020-03-24-github-actions-api-is-now-generally-available/
API support for GH Actions was made available a few months ago.  This PR allows resolving shards using GH Actions via the GitHub API, versus a static list.
There is a ratelimit on the API, so authentication is required.

Cool 👍


ps4eye: 0.0.4-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository ps4eye to 0.0.4-0:

upstream repository: https://github.com/longjie/ps4eye.git
release repository: https://github.com/tork-a/ps4eye-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.25
previous version for package: null

ps4eye
* Fix create_udev_rules option. Change README.md.
* Add udev install script.
* Automatically loading firmware.
* all need is to run create_udev_rules script.
* add viewer argment to stereo.launch. Set true to bring up stereo viewer.
* Add ps4eye/ps4eye files and update README.md contents.
* using  to nodelet manager name
* use gscam nodelet instead of gscam node
* use load_driver, instead of setting DEVICE false to check use real camera
* Contributors: Hiroaki Yaguchi, Ron Tajima

See https://discourse.ros.org/t/releasing-repositories-form-other-people/1797/10


Loyalty needs to decade faster with no service

Airport still has non zero loyalty for many many many years, that does not make sense

Fixed in https://github.com/patsonluk/airline/commit/a04d0646510ad441d8bae00b0d205de3d92d907c


Make optimizer pluggable

Signed-off-by: Andy Grove<EMAIL_ADDRESS>This is mostly to help me with CBO research since I can maintain experimental code outside of the main repo for collecting CPU versus GPU costs.

build


Support: HPCS Modules

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Overhaul encoding, port renterhost

This PR ports the renterhost modules from lukechampine/us to core.  It became necessary to change the encoding system to make types implement encoding/decoding interfaces because something like WriteRequest(req SiaMarshaler) is not really possible otherwise.
Other differences to lukechampine/us:

Changed encoding system to the one in types, although objBuffer remains
Removed marshalledSize.  We just encode the value to the objBuffer, get the length of the buffer, and then reset the buffer.  This is technically inefficient but since the session outbuf is reused over time it shouldn't add that many allocations because while we are writing without a call to grow beforehand we would likely just be writing over existing capacity
I did not implement any kind of ReadPrefix (just calls to ReadUint64).  This is obviously a crash vector but I didn't implement it because it seemed it was undecided how to best do it, although the approach in https://github.com/SiaFoundation/core/pull/10 makes the most sense to me

Ok, finally found time to go through this. As usual I got kinda sucked in and ended up writing a lot more code than planned...
Most significantly, I decided to reimplement the RHP on top of mux. This is basically what RHP3 is anyway, and we don't need to worry about breaking compatibility, so why not? This greatly simplifies the code, because Session no longer needs to worry about encryption or framing at all.
I did get a bit lazy with the random values in session_test.go -- quite a few fields are simply commented out. Would be nice to restore those.
Also, gocritic can get bent lol. I know what I'm doing.

we don't need to worry about breaking compatibility

How much backwards compatibility with 1.x are we aiming for?

I can only think of one property that absolutely must be preserved: addresses.  That's why we need PolicyUnlockConditions.
But generally speaking, compatibility is going out the window. The transaction format is changing, so the signature format has to change too. And the network protocols. And the file formats. And the HTTP API. etc. Everyone has to upgrade anyway, so there isn't any benefit to preserving e.g. the old p2p protocol. It would be a different story if there were a bunch of third-party implementation of the formats and protocols, but AFAIK there aren't.
The danger is that we get rewrite-happy and try to overhaul everything at once. "If we have to break compatibility here anyway, I might as well use this opportunity to redesign XYZ..." I'm doing my best to resist that impulse. 😅


Update to method

Codecov Report

Merging #6 (3e89b22) into main (c1397ff) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   95.34%   95.59%   +0.24%
==========================================
  Files           7        7
  Lines        1849     1907      +58
==========================================
+ Hits         1763     1823      +60
+ Misses         86       84       -2

Impacted Files
Coverage Δ

src/decimal.rs
95.90% <100.00%> (+2.10%)
:arrow_up:

src/cmp.rs
97.56% <0.00%> (+2.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1397ff...3e89b22. Read the comment docs.


Update npm package

Could you please update npm package in order to use latest mime-types? Compilation streaming support for wasm module requires right mime type to be returned. But Send npm package is used by Express and it returns wrong mime type currently. It seems that this issue has already been resolved at source code. I will be really appreciate for updated npm package.

Could you please update npm package in order to use latest mime-types?

This module does not use the mime-types module as a dependency.
The included types are only the defaults. If you need a type, just define it: https://github.com/pillarjs/send/blob/master/README.md#custom-file-types
Releases of this module occur in lock with Express releases. The Express 4.17 release is being worked on and a new send will be released soon to go along with it.


[TF2][GraphDef] Make Const hide in the operators' initializers

Hi @lutzroeder , thanks for creating this cool tool.
In TF2 graphdef visualization, our const doesn't be hidden in the operators' in initializers attribute like our TF1 support. For example, in just one simple minist model, we will have this:

It will be look very weird when our model have many const node (or  simply many convolution ops).
If we open one TF1 model, we could have nice visualization:

Could we support TF2 graphdef like TF1? Or you could point me where I could modify the code to do this. Thanks in advance.

Duplicate of #342


chore(doc): replace main/master to tag/commit to make the url always accessible

Fix #7291
The match relationship is :
 {
    "oxc-project/oxc": "main",
    "cvazac/eslint-plugin-react-perf": "9bfa930661a23218f5460ebd39d35d76ccdb5724",
    "DefinitelyTyped/DefinitelyTyped": "b5dc32740d9b45d11cff9b025896dd333c795b39",
    "estree/estree": "e6015c4c63118634749001b1cd1c3f7a0388f16e",
    "fregante/eslint-formatters": "ae1fd9748596447d1fd09625c33d9e7ba9a3d06d",
    "javascript-compiler-hints/compiler-notations-spec": "c14f7e197cb225c9eee877143536665ce3150712",
    "mozilla-spidermonkey/jsparagus": "24004745a8ed4939fc0dc7332bfd1268ac52285f",
    "privatenumber/minification-benchmarks": "d8d54ceeb206d318fa288b152904adf715b076b2",
    "tc39/source-map": "1930e58ffabefe54038f7455759042c6e3dd590e",
    "tc39/test262": "05c45a4c430ab6fee3e0c7f0d47d8a30d8876a6d",
    "biomejs/biome": "cli/v1.9.4",
    "eslint-community/eslint-plugin-promise": "v7.1.0",
    "eslint-community/eslint-plugin-n": "v17.13.2",
    "rollup/plugins": "pluginutils-v5.1.3",
    "rome/tools": "lsp/v0.28.0",
    "A11yance/aria-query": "v5.3.2",
    "babel/babel": "v7.26.2",
    "denoland/deno_graph": "0.84.0",
    "eslint/eslint": "v9.9.1",
    "evanw/esbuild": "v0.24.0",
    "facebook/react": "v18.3.1",
    "gajus/eslint-plugin-jsdoc": "v50.5.0",
    "getsentry/rust-sourcemap": "9.1.0",
    "google/closure-compiler": "v20240609",
    "guybedford/es-module-lexer": "1.5.4",
    "import-js/eslint-plugin-import": "v2.29.1",
    "jest-community/eslint-plugin-jest": "v28.9.0",
    "jsx-eslint/eslint-plugin-jsx-a11y": "v6.9.0",
    "jsx-eslint/eslint-plugin-react": "v7.37.2",
    "Kilian/electron-to-chromium": "v1.5.60",
    "lukastaegert/eslint-plugin-tree-shaking": "v1.12.2",
    "microsoft/TypeScript": "v5.6.3",
    "nicolo-ribaudo/babel": "v7.25.8",
    "nodevault/node-vault": "v0.10.2",
    "prettier/prettier": "3.3.3",
    "ratel-rust/ratel-core": "v0.7.0",
    "rolldown-rs/rolldown": "v0.14.0",
    "rust-lang/rust": "1.82.0",
    "sindresorhus/eslint-plugin-unicorn": "v56.0.0",
    "terser/terser": "v5.9.0",
    "typescript-eslint/typescript-eslint": "v8.9.0",
    "vercel/next.js": "v15.0.2",
    "veritem/eslint-plugin-vitest": "v1.1.9",
}

Errors in ./crates/oxc_prettier/README.md

[404] https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js | Failed: Network error: Not Found

Good catch, it's because the tag of following repo does not start with "v"

'https://github.com/prettier/prettier/tree/3.3.3',
'https://github.com/getsentry/rust-sourcemap/blob/9.1.0',
'https://github.com/rust-lang/rust/blob/1.82.0',
'https://github.com/denoland/deno_graph/blob/0.84.0',
'https://github.com/guybedford/es-module-lexer/blob/1.5.4',

Fixed

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)
(see the "Check links" CI task)

Thanks, it's actually because my force-push was failed on my local machine because of net issue.
I wrote a script to repalce url, so the easier way is to rewrote everything and make a force push

Nice one! Thanks very much for doing this.


Add e2e test that verifies resources are restarted after configmap change

What would you like to be added:
We added new component (reloader) and that is an important feature that operators rely on. We should make sure that it works with integration/e2e test.

I believe this is covered by the recent work on the dependency hash and this test. While we don't test that something actually restarted, we do test that the corresponding plan is completed. Do you think this is enough @alenkacz, @ANeumann82 ?

yep I think it's covered 👍


Add readthedocs.org build status

[ci skip]
Signed-off-by: Nikolay Yushkevich<EMAIL_ADDRESS>

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@LiraLemur can you please jump in and help with styling and proper alignment? Thanks!

@neewy please check if you like my idea

@LiraLemur can we format it somehow so that it occupies less vertical space? e.g. table in all-contributors: https://github.com/all-contributors/all-contributors#emoji-key

It it better to reformat this table in two rows

Fixed the table


Buttons are not aligned properly - Improvement

Search Functionality and Add Opportunity Buttons are not aligned Properly

I Want to work on this Please!
@GSSOC22

Assigned @NPriyajit


Fixes #885 - Improve vFlow tests; fix issues with cross-network access to router vFlow agents

There were two issues with propagated indication of the presence of an in-process destination for an address.  One affected interior-interior forwarding and the other affected edge-interior forwarding.  This caused FLUSH commands from a remote vFlow collector to not arrive at the intended event source.
There were a number of defects in the existing vFLow tests that prevented the detection of the above issue.  The tests are also fixed in this PR.

Codecov Report
Base: 27.53% // Head: 27.53% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (6b86a96) compared to base (5f8f89a).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   27.53%   27.53%
=======================================
  Files         136      136
  Lines       32530    32534    +4
  Branches     5216     5217    +1
=======================================
+ Hits         8956     8959    +3
- Misses      22424    22425    +1
  Partials     1150     1150

Flag
Coverage Δ

unittests
27.53% <33.33%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...re/modules/edge_addr_tracking/edge_addr_tracking.c
1.73% <0.00%> (-0.03%)
:arrow_down:

src/router_core/modules/mobile_sync/mobile.c
0.70% <0.00%> (-0.01%)
:arrow_down:

src/router_core/route_tables.c
16.93% <100.00%> (+0.77%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ajssmith (the original finder of this defect) has tested the PR and verified that the vFlow problems are solved.

@ted-ross this looks ok to me and since @ajssmith has tested already, please feel free to commit


[HOLD for payment 2023-08-01] [$1000] IOS - The text below the input flickers upon typing the first character

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to ND
Go to settings > Security > Close account
Type a message
Observe flickering of the text (Please type your default contact method...)

Expected Result:
The text below the input should not flicker when typing the first character
Actual Result:
The text below the input flickers when typing the first character
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.37-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/7def69a7-05a0-474a-8e24-916e4e28a341
https://github.com/Expensify/App/assets/93399543/ab0aeca9-908f-4236-9cec-ee120440d486
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688995973983469
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aade6c9bc04abd1e
Upwork Job ID:<PHONE_NUMBER>165247488
Last Price Increase: 2023-07-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
The height of text input changes after typing the first character.
What is the root cause of that problem?
The issue is caused by the height property overriding the minHeight property, leading to the input height potentially becoming smaller than the specified minHeight. The root cause is in the absence of a check for the minimum height when setting the input height.
https://github.com/Expensify/App/blob/a51f7c7267069463ff6b94d494991c8eca4c7ddb/src/styles/styles.js#L862-L865
What changes do you think we should make in order to solve the problem?
We can ensure that the input height is calculated based on the provided textInputHeight value while considering the constraints of both the minimum height and the maximum height. The Math.min() function is used to ensure that the calculated height does not exceed the maxHeight, the minHeight property is explicitly set to maintain the specified minimum height.
autoGrowHeightInputContainer: (textInputHeight, maxHeight) => ({
        height: Math.min(Math.max(textInputHeight, variables.componentSizeLarge), maxHeight),
        minHeight: variables.componentSizeLarge,
    })

What alternative solutions did you explore? (Optional)
We can use the ternary operator to conditionally set the value of height.
autoGrowHeightInputContainer: (textInputHeight, maxHeight) => {
        const height = textInputHeight < variables.componentSizeLarge ? variables.componentSizeLarge : textInputHeight > maxHeight ? maxHeight : textInputHeight;

        return {
            height,
            minHeight: variables.componentSizeLarge,
        };
    }

Result
https://github.com/Expensify/App/assets/89839952/cb0e09e5-068e-49ec-a445-ed3c04e79156

Fielding proposals!

Hi,
I found that the height of TextInput's Container View is greater than the mininum height. Just put another condition to set height value is at least minimum height value.
Besides that, getAutoGrowHeightInputStyle function also set height of view to the something value and then I replace it to minimum height (the same value we put above) It works well.
https://github.com/Expensify/App/assets/15010888/2db3bec4-36d2-4380-adf4-8ec8408494fc

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~018b9f89626052eb90

@ahmdshrif's proposal looks good to me!
All of the proposals are quite similar, so let's proceed with the first one
🎀👀🎀 C+ reviewed!

Payment summary:

[ ] External issue reporter @aman-atg $250
[ ] Contributor that fixed the issue @ahmdshrif $1500
[ ] Contributor+ that helped on the issue and/or PR @eVoloshchak $1500

@eVoloshchak will you get paid via newDot or Upwork?

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/17878/
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17878/files#r1282444836
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a simple visual bug, I don't think there are any steps we could do besides automated UI tests
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? No
Is it an impactful bug? No
The bug has zero impact on functionality, while being very minor from the UI standpoint, a regression test isn't needed here I think

Nice! I agree w/ your reasoning, no regression test needed

@aman-atg and @ahmdshrif lmk when you accept my Upwork job offer so i can send the payment.

Requested the payment via NewDot🎉

Reviewed details for @eVoloshchak. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

all paid


Verify time zones in SQL, JS, and CSV

Times should be consistently UTC or local time.
Project > CSV Output > collection_time Timezone should be in UTC
Steps to Reproduce

Login as a User
Survey a plot in a project
Download the project's plots
Verify the collection_time time zone

Screenshot

Project Review > Publish Project
Steps to Reproduce

Login as admin of an institution
Go to the review project page for a unpublished project
Have the local time be a different day that UTC time
Click publish
Publish date is the UTC date not local date.

I think its JS that is timezone specific. Checkout ;;; Time processing in the dev branch (assuming the match drop branch is merged)

CSV Downloading issue:
So here are some of the relevant bits:

Postgres has it's own TIMEZONE configuration, which on the Prod/Dev is currently set to UTC
The client generates the initial collection_start timestamp in UTC (which is turned into a timestamp by projects.clj), while the server updates the collection_time timestamp
When the CSV is downloaded, the collection_time is formatted to the "Y-M-D HH:MM format in projects.clj

If we wanted to simply change the formatting of the collection_time to use the current client's Timezone, we could pass that as a parameter in the request to /dump-project-aggregate-data and shift the Timezone accordingly. If we do that, it would be useful to include the timezone in the header.
Publish/Create Project Dates mismatch:
This looks both the created and published are both dates (not timestamps) and set using Postgres now() function. This means whenever you create or publish a project you will end up creating it on the date that the Postgres instance is set to, not your local date.
The first step to remedy this would require a change of the existing projects table to use timestamp rather than date for both created_date and published_date. Next, we would have to figure out where the timestamp should be formatted. If we wanted the backend to handle the formatting, maybe we could have User's set a timezone in their user settings. We could also store their current client's timezone in a session variable when they visit the site. Alternatively, we could format the date in the front-end using something like getTimeZoneOffset


[Visualizer] Add index.html

this file is entry point for react
ONE-vscode-DCO-1.0-Signed-off-by: parkjisu6239<EMAIL_ADDRESS>

@parkjisu6239 Could you add the title to the commit message too? :)


Error when building using Java 18

What happened?
Unable to build image using spring-boot/maven using JDK 18.

What were you attempting to do? Build via spring boot

What did you expect to happen? A build using Java 18 to success

What was the actual behavior? Please provide log output, if possible.

[INFO]     [creator]     Paketo CA Certificates Buildpack 3.1.0
[INFO]     [creator]       https://github.com/paketo-buildpacks/ca-certificates
[INFO]     [creator]       Launch Helper: Contributing to layer
[INFO]     [creator]         Creating /layers/paketo-buildpacks_ca-certificates/helper/exec.d/ca-certificates-helper
[INFO]     [creator]
[INFO]     [creator]     Paketo BellSoft Liberica Buildpack 9.2.0
[INFO]     [creator]       https://github.com/paketo-buildpacks/bellsoft-liberica
[INFO]     [creator]       Build Configuration:
[INFO]     [creator]         $BP_JVM_TYPE                 JRE                  the JVM type - JDK or JRE
[INFO]     [creator]         $BP_JVM_VERSION              18.*                 the Java version
[INFO]     [creator]       Launch Configuration:
[INFO]     [creator]         $BPL_DEBUG_ENABLED           false                enables Java remote debugging support
[INFO]     [creator]         $BPL_DEBUG_PORT              8000                 configure the remote debugging port
[INFO]     [creator]         $BPL_DEBUG_SUSPEND           false                configure whether to suspend execution until a debugger has attached
[INFO]     [creator]         $BPL_HEAP_DUMP_PATH                               write heap dumps on error to this path
[INFO]     [creator]         $BPL_JAVA_NMT_ENABLED        true                 enables Java Native Memory Tracking (NMT)
[INFO]     [creator]         $BPL_JAVA_NMT_LEVEL          summary              configure level of NMT, summary or detail
[INFO]     [creator]         $BPL_JFR_ARGS                                     configure custom Java Flight Recording (JFR) arguments
[INFO]     [creator]         $BPL_JFR_ENABLED             false                enables Java Flight Recording (JFR)
[INFO]     [creator]         $BPL_JMX_ENABLED             false                enables Java Management Extensions (JMX)
[INFO]     [creator]         $BPL_JMX_PORT                5000                 configure the JMX port
[INFO]     [creator]         $BPL_JVM_HEAD_ROOM           0                    the headroom in memory calculation
[INFO]     [creator]         $BPL_JVM_LOADED_CLASS_COUNT  35% of classes       the number of loaded classes in memory calculation
[INFO]     [creator]         $BPL_JVM_THREAD_COUNT        250                  the number of threads in memory calculation
[INFO]     [creator]         $JAVA_TOOL_OPTIONS           -Xms2048m -Xmx2048m  the JVM launch flags
[INFO]     [creator]       No valid JRE available, providing matching JDK instead. Using a JDK at runtime has security implications.
[INFO]     [creator]
[INFO]     [creator]     Paketo BellSoft Liberica Buildpack 9.2.0
[INFO]     [creator]       unable to find dependency
[INFO]     [creator]       no valid dependencies for jdk, 18.*, and io.buildpacks.stacks.bionic in [(jdk, 8.0.322, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (jre, 8.0.322, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (jdk, 11.0.14, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (jre, 11.0.14, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (native-image-svm, 11.0.14, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (jdk, 17.0.2, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (jre, 17.0.2, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *]) (native-image-svm, 17.0.2, [io.buildpacks.stacks.bionic io.paketo.stacks.tiny *])]
[INFO]     [creator]     ERROR: failed to build: exit status 1

Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
using? Using spring-boot-maven-plugin latest.

Checklist

[x] I have included log output.
[x] The log output includes an error message.
[x] I have included steps for reproduction.

Java 18 had not been released in a buildpack yet (at the time you posted). We're releasing today, so it should be available soon. Just make sure your pull policy is "always" so that the tools pull in the latest buildpack images.

Newest release works great! Closing issue 👍

now I get the following error:
[INFO]     [creator]         Expanding to /layers/paketo-buildpacks_bellsoft-liberica/jre [INFO]     [creator]     unable to invoke layer creator [INFO]     [creator]     unable to load certificates [INFO]     [creator]     unable to read keystore [INFO]     [creator]     unable to decode keystore [INFO]     [creator]      got invalid magic


Some house cleaning

This PR removes some deprecated code that previously had been accessible via --enable-build-deprecated, which necessitated updating the LteMixture class interface.

Not sure what is going on with the gitlab failed test.  I cannot reproduce in my local build on that platform. So I suspect it is a fluke, and I'm going to merge the PR.   If it persists, I will sort it out separately.


[SPARK-15876] [CORE] Remove support for "zk://" master URL

What changes were proposed in this pull request?
Remove deprecated support for zk:// master (mesos://zk// remains supported)
How was this patch tested?
Jenkins

Test build #60367 has started for PR 13625 at commit be7d404.

Test build #60367 has finished for PR 13625 at commit be7d404.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60367/
Test FAILed.

Test build #60368 has started for PR 13625 at commit 18ad016.

Test build #60368 has finished for PR 13625 at commit 18ad016.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60368/
Test PASSed.

Merged build finished. Test PASSed.

LGTM - merging in master/2.0.


[e2e] Results of e2e tests in github actions for nft backend and ipv6 family.

There are some test cases failing for nft and ipv6 families.
Please check the below link for references
https://github.com/kubernetes-sigs/kpng/runs/4362502999?check_suite_focus=true

As we have less no of issues in each of the backends due to lot of issues fixed, closing this issue. We can open new issues for each failures now.


#78 assignment progress view

This issue addresses the issue #78 , this issue still work in progress last bit remaining is adding marker denoting current and Max possible grade

Removed the no-semi colon rule from Codacy! https://standardjs.com/rules.html#semicolons


fix(clerk-react): Added useAuth test and made getToken, and signOut stable

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[x] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Following on this issue https://github.com/clerkinc/javascript/issues/201, made the functions returned by useAuth() stable (as per the usual React terminology); meaning they will not change between unrelated re-renders. This allows you to properly depend on them without worries about re-renders, and when the underlying value does change (isomorphicClerk), then they will update properly.
The logic inside useAuth() should be identical as before, just reorganized it a bit to be able to use a useMemo to make auth also stable.
PS, modified the types a bit, unfortunately I'm not that familiar with TS but the default installation was giving me types issues (before any code change, just by importing the files into the test file). So some of the changes were fixes, and the one modifying UseAuthReturn was because I had trouble with getting the highly-dynamic variable to work otherwise.

#201

Thanks for the feedback! I'm in my lunch break, I won't be able to commit anything until the weekend, so feel free to add any other comment and I'll try to fix them all then.

Fixed the given points! Unfortunately I still had to change the types into 3 parts and cast each return independently with as {NAME}, since otherwise with the default code I was getting this error which I couldn't figure out how to fix in any other way:
src/hooks/useAuth.ts:80:14 - error TS2322: Type '() => { isLoaded: false; isSignedIn: any; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; } | { isLoaded: true; isSignedIn: false; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; } | { ...; }' is not assignable to type 'UseAuth'.
@clerk/clerk-react:test:       Type '{ isLoaded: false; isSignedIn: any; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; } | { isLoaded: true; isSignedIn: false; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; } | { ...; }' is not assignable to type 'UseAuthReturn'.
@clerk/clerk-react:test:         Type '{ isLoaded: false; isSignedIn: any; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; }' is not assignable to type 'UseAuthReturn'.
@clerk/clerk-react:test:           Type '{ isLoaded: false; isSignedIn: any; sessionId: string; userId: string; actor: any; signOut: SignOut; getToken: GetToken; }' is not assignable to type '{ isLoaded: true; isSignedIn: true; userId: string; sessionId: string; actor: ActJWTClaim; signOut: SignOut; getToken: GetToken; }'.
@clerk/clerk-react:test:             Types of property 'isLoaded' are incompatible.
@clerk/clerk-react:test:               Type 'false' is not assignable to type 'true'.
@clerk/clerk-react:test:
@clerk/clerk-react:test:     80 export const useAuth: UseAuth = () => {

This error was not shown when running the tests without useAuth.test.tsx, which makes me think it's something visible either only when running the tests, or because of the mocking the clerk instance is not being done properly. I believe these type changes should be totally retro-compatible, but please let me know if those are not acceptable.

@franciscop thank you for the contribution but we will close this PR in favor of : https://github.com/clerkinc/javascript/pull/980


RuntimeError: 3D or 4D (batch mode) tensor expected for input

Occasionally the running container throws the error (below) and halts. Sometimes it runs for tens of minutes without errors but sometimes under a minute.  Just for the reference the test machine had a fairly modest CPU: Intel(R) Core(TM) i3-7100. The container was started with the following command:
sudo docker run --shm-size=20gb \
 -it koodivaramu.eesti.ee:5050/taltechnlp/kiirkirjutaja python main.py \
 --youtube-caption-url http://upload.youtube.com/closedcaption?cid=(yourid) \
 rtmp://(yourstream)

This time it was started just after one crash and it crashed again quite soon, you can see the video and titles right before the crash here: https://youtu.be/1wuddvqdZJo?t=1800  and here is the last output from the container:
2021-10-21T07:38:23.097
 Ossinovski,
2021-10-21T07:38:23.637
 palun.

INFO:root:Response status 200 OK: 2021-10-21T07:38:24.226

Exception in thread Thread-22:
Traceback (most recent call last):
  File "/root/miniconda3/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/root/miniconda3/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/kiirkirjutaja/asr.py", line 33, in run
    for chunk in self.chunk_generator:
  File "/opt/kiirkirjutaja/lid.py", line 57, in filter
    language_id = self.get_language(buffer)
  File "/opt/kiirkirjutaja/lid.py", line 25, in get_language
    probs = self.get_language_probs(buffer)
  File "/opt/kiirkirjutaja/lid.py", line 19, in get_language_probs
    lang_logits, lang_group_logits = self.model(buffer.unsqueeze(0))
  File "/root/miniconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript, serialized code (most recent call last):
  File "code/__torch__/torch/nn/functional.py", line 61, in forward
          ops.prim.RaiseException(_5)
        if torch.eq(mode, "reflect"):
          _22 = torch.reflection_pad2d(input, pad)
                ~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
          _21 = _22
        else:

Traceback of TorchScript, original code (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/functional.py", line 4014, in forward
            assert len(pad) == 4, "4D tensors expect 4 values for padding"
            if mode == "reflect":
                return torch._C._nn.reflection_pad2d(input, pad)
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
            elif mode == "replicate":
                return torch._C._nn.replication_pad2d(input, pad)
RuntimeError: 3D or 4D (batch mode) tensor expected for input, but got: [ torch.FloatTensor{1,1,1,0} ]

Traceback (most recent call last):
  File "main.py", line 108, in <module>
    main(args)
  File "main.py", line 84, in main
    for res in turn_decoder.decode_results():
  File "/opt/kiirkirjutaja/asr.py", line 24, in decode_results
    result = self.result_queue.get()
  File "/root/miniconda3/lib/python3.8/queue.py", line 170, in get
    self.not_empty.wait()
  File "/root/miniconda3/lib/python3.8/threading.py", line 302, in wait
    waiter.acquire()

@alumae - perhaps you can also update the latest tag to point to the fixed version?

Yes, my bad, "latest" was not updated. Looking for a good place to put the changelog.

We now have "releases", which are in sync with the Docker image. I.e., today we published release 0.2.3 and the Docker image is also updated (available as koodivaramu.eesti.ee:5050/taltechnlp/kiirkirjutaja:latest and koodivaramu.eesti.ee:5050/taltechnlp/kiirkirjutaja:0.2.3).


[Bug]: version 27.4.0 depends on @jest/transform^27.4.0,but @jest/transform^27.4.0 has not been released!

Version
27.4.0
Steps to reproduce
install babel-jest of version 27.4.0
Expected behavior
27.4.0 been installed correctly.
Actual behavior
<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Can't find package<EMAIL_ADDRESS>Additional context
No response
Environment
babel-jest version:
^27.4.0

You probably hit a caching error just as I was releasing a new version, it's available now

Having a similar issue.  Fails with same error, for either pinned version 27.4.0 or 27.4.2.
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of '@jest/globals'


IKEA on of button not working since 2.2.0

Since update to 2.2.0 when pressing on or off sends double signals as on and off

I've a same problem too on 2.2.4 with IKEA Trådfri ON/OFF Switch (model E1743).

I am using version 2.2.4 installed on homebridge on a raspberry pi using raspbian. I have the same problem like exposed above. When pressing any button all button actions trigger. Thi happens with ikea on/off switch and the other remote that i have(TRADFRI remote control, IKEA E1524/E1810). for the IKEA E1524/E1810 when you press either buttons all 5 buttons trigger.

Should be fixed now

Hello,
Updated to latest version and the issue has changed, but still an issue, now for a 2 button remote, when pressing button 1 (short or long press) it sends button 2, than button 1 events. When pressing button 2 it does only button 2
Thanks,
Alexandru Tudor

Also tested the 5 button remote from ikea, on test all buttons are sending button 5 events but from all the 5 buttons just 4 of them are working(the middle on/off button does not send an event  )

Same here on v2.5.1 on a 5 Button Ikea Remote... The Power Button doesnt work...
And the other 4 Buttons seem all to send the same Signal to the same Actor... Regardless if i configure Brightness to Actor1 and Left/Right to Actor2...

Sorry for this annoying bug, I'll try to get it fixed in the next few days

@Figo66 @huddx01 @tutasca @kittapasp Can someone test version 2.5.2-beta.1 and tell me if buttons are now working as expected?

I forgot to ask: which device are you testing? Ikea On/Off or something else?

I forgot to ask: which device are you testing? Ikea On/Off or something else?

Its an IKEA Remote... as in my logs above...
 _manufacturerName: 'IKEA of Sweden',
    _powerSource: 'Battery',
    _modelID: 'TRADFRI remote control',
    _applicationVersion: 33,
    _stackVersion: 98,
    _zclVersion: 3,
    _hardwareVersion: 1,
    _dateCode: '20190708',
    _softwareBuildID: '2.3.014',

@huddx01 could you please attach the homebridge log after a restart? I need to understand which device is actually recognised from the plugin. And sorry for my delay in responding, but I am out for work and it's a bit difficult for me to follow "personal projects" in this period

@huddx01 I got on remote from IKEA and I finally found the problem...it's fixed in beta.6 version


TechDebt: Misc Odd Updates (keycloak, pipeline, favicon, etc)

Overview
Links to Jira tickets
n/a
Description of relevant changes

Removed some old git workflow files
Updated keycloak version, which changed it to always being defined (rather than potentially undefined), and so I removed a bunch of unnecessary ?. when dereferencing the keycloak object.

Added change_version to the version endpoint (mainly an experimental change, as I never really noticed that var before, but in theory it might let us put a version number in the UI)
Pulled some taxonomy-service changes from other projects, just misc updated
Added the BCGov favicon to the react app.
Added proper error handling to the db setup pipeline step, so it will properly fail the git action if it fails in openshift
Moved a bunch of old tests from manually specifying mock keycloak auth states, to using the getMockAuthState test helper function

PR Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@curtisupshall @AlfredRosenthal Thanks for the reviews, I had to fix some conflicts so will need a re-review. Nothing functional should have changed. I updated some tests while I was at it to use getMockAuthState rather than hardcoding it in each test. Will see how that evolves long term, but it seemed like we were having issues maintaining our mock auth states and so hopefully this will help centralize it a bit.


Adds .spec files to create RPMs and implements rpmbuild in CMakeList.txt

This adds the option to generate two rpms for this repository, one rpm with the necessary .so files and one devel rpm with necessary headers. Calling make rpm after a general make generates the rpms into .build/BUILD/RPMS.

Could we use CPackRPM for this?

What would you want added through CPackRPM. In the end it calls rpm-build so it would be very similar. Also, I could work towards getting the rpms on packagecloud if this gets merged into the CI.

@gabrielkay - I prefer using CMake's builtin support when it's available.
One advantage of working off of CPack is that different packaging targets can share the same cpack configuration variables, requiring less work to maintain them.
And pushing releases to pagecloud through the CI definitely sounds good.

Take a look at the changes I just made. Is that what you were thinking? Let me know if I should change/add anything.

I don't believe you need those custom targets if you're using cpack.
Take a look at the RPM section here: https://gitlab.kitware.com/cmake/community/wikis/doc/cpack/PackageGenerators

I've never used CPack before and couldn't quite figure it out. I tried to make two components that would turn into two rpms but it is always making just one rpm with all files in it. If you could help me out by pointing out any CPack "sets" I'm missing or what exact command line I should run to generate the rpms that would be extremely helpful.

@gabrielkay - I moved the line
set(CPACK_RPM_COMPONENT_INSTALL ON)

to the top of the CMakeLists.txt file above
cmake_minimum_required(VERSION 3.1)

then ran with
/opentracing-cpp/build# cpack -G RPM

and it generated two RPMs
CPack: Create package using RPM
CPack: Install projects
CPack: - Run preinstall target for: opentracing-cpp
CPack: - Install project: opentracing-cpp
CPack: -   Install component: Devel
CPack: -   Install component: Unspecified
CPack: Create package
CPackRPM: Will use GENERATED spec file: /opentracing-cpp/build/_CPack_Packages/Linux/RPM/SPECS/opentracing-cpp-Devel.spec
CPackRPM: Will use GENERATED spec file: /opentracing-cpp/build/_CPack_Packages/Linux/RPM/SPECS/opentracing-cpp-Unspecified.spec
CPack: - package: /opentracing-cpp/build/opentracing-cpp-1.5.0-Linux-Devel.rpm generated.
CPack: - package: /opentracing-cpp/build/opentracing-cpp-1.5.0-Linux-Unspecified.rpm generated.

@gabrielkay - cpack should handle the files for you. If you take the take the existing opentracing-cpp repository, run
git clone https://github.com/opentracing/opentracing-cpp.git
cd opentracing-cpp
mkdir build
cd build
cmake ..
cpack -G RPM --config CPackConfig.cmake

Then rpm -qlp opentracing-cpp-1.5.0-Darwin.rpm shows that all the headers and other files are included
/usr/include/opentracing
/usr/include/opentracing/config.h
/usr/include/opentracing/dynamic_load.h
...

What are you getting stuck with?
The CMake tutorial includes a section on cpack if you're looking for an example.

I agree that CPack works fine to just package everything into one RPM but I need to create two RPMs, one just with the libraries that I can link against (libopentracing.so.1.5.0 & libopentracing_mocktracer.so.1.5.0) and one for developing with all needed .h headers. I've been trying to use the component feature of CPack to do this but ran into issues when trying to create components and specify which files go into which component.

After a lot of trial and error, now CPack produces the two RPMs I need. They have the endings -DEVEL and -DIST. All that's needed to be done is calling cpack -G RPM in the .build directory after the directory is made. It also makes two more rpms by default (-Devel and no extension) but I see no way to prevent those two from being created. Looks to me like this is very close to being ready, let me know if you see something wrong.

Take a look at my changes if you have a chance. The rpms compile with cpack -G RPM. The only issue I'm encountering is I get the errors below when compiling with my project. Do you have any idea why these specific 3 calls break my compile? This error has been very frustrating.
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../lib64/libzipkin_opentracing.so.0: undefined reference to opentracing::v1::propagation_error_category()
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../lib64/libzipkin_opentracing.so.0: undefined reference to opentracing::v1::dynamic_load_error_category()
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../lib64/libzipkin_opentracing.so.0: undefined reference to opentracing::v1::tracer_factory_error_category()
collect2: error: ld returned 1 exit status

@gabrielkay - zipkin-opentracing hasn't been updated yet to the latest 1.5 release.
It's not linking because the ABI version number was bumped so that it has a different inline namespace.
If you want to add a PR to update it, it should look something like this: https://github.com/lightstep/lightstep-tracer-cpp/pull/105.
Otherwise, I'll be getting to it myself shortly.

Now the DIST rpm is only made when BUILD_SHARED_LIBS is on. The script was clarified, renamed, and moved.

I don't use OSX, how can that be fixed? Can CMake check the system's architecture?

Maybe use CMAKE_SHARED_LIBRARY_SUFFIX

CMAKE_SHARED_LIBRARY_SUFFIX worked fine for me on Linux. I added make install to the travis.yml so we can see if it fixed the OSX issue.

@gabrielkay - what happened to you separate installs for the version shared library? Did you end up not needing it?

OSX was using a naming convention of libopentracing.1.5.0.dylib with number before .dylib while the .so files had number after .so so using the variable didn't work. I just put made component a part of the shared library install for opentracing and installed the unnecessary .so's as well.  I also stopped packaging the libopentracing_mocktracer because there is no install call for it in the CMake so I couldn't package it without specifying its name. How is the libopentracing_mocktracer installed? I would prefer to package it here but I might just have to add the call back to my own branch if it breaks OSX

The mocktracer has its own cmake file, but you should be able to add the components to the installs in here

That works perfectly!

I think this is finally ready to be merged?


updates to tsconfig

here are changes to tsconfig.json needed to avoid issues installing slpjs

Pull Request Test Coverage Report for Build 1512

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.063%

Totals

Change from base Build 1409:
0.0%

Covered Lines:
2938

Relevant Lines:
3724

💛  - Coveralls


Option that enables generating rust code in 2018 edition

Here is a snippet generating by the crate, but in 2015 edition. However, the rest of my current project is written in Rust 2018 edition. So, I have to create another crate to isolate the grpc module from my 2018 edition code. Maybe adding an option to enable generating Rust 2018 Edition code will be more convenient in the future.
use protobuf::Message as Message_imported_for_functions; // use
use protobuf::ProtobufEnum as ProtobufEnum_imported_for_functions;

#[derive(PartialEq,Clone,Default)]
pub struct HelloRequest {
    // message fields
    pub name: ::std::string::String,
    // special fields
    pub unknown_fields: ::protobuf::UnknownFields,
    pub cached_size: ::protobuf::CachedSize,
}

OK, the question. What doesn't work with edition 2018?
I just checked, it seems to work fine: https://travis-ci.org/stepancheg/rust-protobuf/builds/501795233

Closing due to inactivity.


Windows: Set RTS before DTR to avoid issues

Supersedes #554
I couldn't verify that this actually works as I have not encountered this issue, see #554 and esptool workaround

@bjoernQ would you mind testing this just to ensure it still works on windows after this change?

Thank you for testing @bjoernQ! LGTM!


CustomScrollView or ListView with RefreshIndicator, jumpTo(0) trigger the unnecessary refresh.

Problem
As the title says, I only want to scroll to top, not refresh the list data.
...

  Future<Null> _refresh() {
    final completer = Completer<Null>();
    _loadPostsFollowing(
      more: false,
      refresh: true,
      completer: completer,
    );
    return completer.future;
  }

  @override
  Widget build(BuildContext context) {
    return Stack(
      children: <Widget>[
        widget.vm.bindingTumblr.userId == 0
            ? Center(
                child: Text(
                '请在“我”里面绑定 Tumblr 帐号\n以便查看你所关注的内容',
                textAlign: TextAlign.center,
              ))
            : RefreshIndicator(
                onRefresh: _refresh,
                child: ListView.builder(
                  controller: _scrollController,
                  physics: const AlwaysScrollableScrollPhysics(),
                  itemCount: widget.vm.postsFollowing.length,
                  itemBuilder: (context, index) => Post(
                        key: Key(widget.vm.postsFollowing[index].id.toString()),
                        post: widget.vm.postsFollowing[index],
                      ),
                ),
              ),
        Visibility(
          visible: _isLoading,
          child: Center(
            child: CircularProgressIndicator(),
          ),
        ),
      ],
    );
  }

...

Env
➜  app git:(master) ✗ flutter doctor -v
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.1 18B75, locale zh-Hans-CN)
    • Flutter version 1.0.0 at /Users/jagger/flutter
    • Framework revision 5391447fae (3 周前), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/jagger/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/jagger/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.0.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.30.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.21.1

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.
``

To investigate we would need a minimal runnable reproduction
as a single file so that we can just copy your code into lib/main.dart of a new project and run to reproduce.

@zoechi Here is the runnable app. Scroll the list view, and press the floating button to jump to top, it will print "refreshed" in the console.
import 'package:flutter/material.dart';

void main() => runApp(JWApp());

class JWApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'JW Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blueGrey,
      ),
      home: ListViewPage(),
    );
  }
}

class ListViewPage extends StatefulWidget {
  @override
  ListViewPageState createState() => ListViewPageState();
}

class ListViewPageState extends State<ListViewPage> {
  final _controller = ScrollController();

  Future<Null> _refresh() {
    print('refreshed');
    return Future.value(null);
  }

  @override
  Widget build(BuildContext context) {
    final items = List<int>.generate(100, (i) => i + 1).toList();
    return Scaffold(
      appBar: AppBar(
        title: Text('ListView'),
      ),
      body: RefreshIndicator(
        onRefresh: _refresh,
        child: ListView.builder(
          controller: _controller,
          physics: const AlwaysScrollableScrollPhysics(),
          itemCount: items.length,
          itemBuilder: (context, index) => ListTile(
                title: Text('Item ${items[index]}'),
              ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () => _controller.jumpTo(0),
        child: Icon(Icons.arrow_upward, color: Colors.white),
      ),
    );
  }
}


can't run ord preview on signet

I have signet bitcoind running, I am able to use commands like ord -s wallet balance, ord -s wallet send, ord -s inscribe, ...
but when I try starting the preview server I get:
ord -s preview

...
Listening on http://<IP_ADDRESS>:80 ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 0/103
error: Permission denied (os error 13)

If I try using sudo the server starts but on regnet.
sudo /home/ubuntu/bin/ord -s preview

How can I make it work on signet?

Thanks for the issue!
ord preview does not run on signet, it always spins up a local regtest node and inscribes to it. Signet is a public test net, so ideally a local regtest node should be used for previewing.


Connection reset by Peer (error 104) - When INT configuring SPINE

I am getting the following error when INT configuring spine switches in mininet emulated environment
kohila@kohila-vb:~/p4factory/mininet$ sudo ./int_ref_topology.py --model-dir=$HOME/install
Adding switch spine1
Adding switch spine2
Adding switch leaf1
Adding switch leaf2
Waiting 10 seconds for switches to intialize...
INT Config  spine1
Traceback (most recent call last):
File "./int_ref_topology.py", line 131, in
run_cfg(model_dir)
File "./int_ref_topology.py", line 91, in run_cfg
net = mgr.setupAndStartNetwork()
File "/home/kohila/p4factory/mininet/int_cfg.py", line 147, in setupAndStartNetwork
self.configSwitches()
File "/home/kohila/p4factory/mininet/int_cfg.py", line 237, in configSwitches
self.configSwitch(s)
File "/home/kohila/p4factory/mininet/int_cfg.py", line 251, in configSwitch
client.switcht_api_init( device )
File "/home/kohila/p4factory/submodules/switch/switchapi/switch_api_thrift/switch_api_rpc.py", line 1565, in switcht_api_init
return self.recv_switcht_api_init()
File "/home/kohila/p4factory/submodules/switch/switchapi/switch_api_thrift/switch_api_rpc.py", line 1577, in recv_switcht_api_init
(fname, mtype, rseqid) = iprot.readMessageBegin()
File "/usr/local/lib/python2.7/dist-packages/thrift/protocol/TBinaryProtocol.py", line 134, in readMessageBegin
sz = self.readI32()
File "/usr/local/lib/python2.7/dist-packages/thrift/protocol/TBinaryProtocol.py", line 217, in readI32
buff = self.trans.readAll(4)
File "/usr/local/lib/python2.7/dist-packages/thrift/transport/TTransport.py", line 60, in readAll
chunk = self.read(sz - have)
File "/usr/local/lib/python2.7/dist-packages/thrift/transport/TTransport.py", line 161, in read
self.__rbuf = BufferIO(self.__trans.read(max(sz, self.__rbuf_size)))
File "/usr/local/lib/python2.7/dist-packages/thrift/transport/TSocket.py", line 117, in read
buff = self.handle.recv(sz)
socket.error: [Errno 104] Connection reset by peer
kohila@kohila-vb:~/p4factory/mininet$
Anybody have faced similar issue ? Please help me to fix this issue.
Thanks
Kohila

Yep. Seeing the exact same error. This repo seems to have been abandoned, may have to start digging in here.
If you found a fix, please do share.

Okay, this required me to ensure that the switch driver (a file called: bmswitchp4_drivers) is correctly built and placed in the ~/install location. You would need to rebuild the switch docker after compilation.

Hi gopchandani,
I am getting the same socket error. I tried to ensure the switch drivers, but I am facing core dump. Can you explain in more detail what have you done to make it work ? I really appreciate any help you can provide.


[Styles] Global style for call to action buttons

Fix styling for buttons, like call to action buttons.
Sample page: https://main--netcentric--hlxsites.hlx.page/our-industries

Closed with #84


GlobalKTable should provide consumer lag metrics

Description
Java version of Kafka Streams emits a consumer lag for GlobalKTable. For example,
# HELP kafka_consumer_consumer_fetch_manager_metrics_records_lag The latest lag of the partition kafka.consumer:name=null,type=consumer-fetch-manager-metrics,attribute=records-lag
# TYPE kafka_consumer_consumer_fetch_manager_metrics_records_lag gauge
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="4",client_type="consumer",} 0.0
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="2",client_type="consumer",} 0.0
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="5",client_type="consumer",} 0.0
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="0",client_type="consumer",} 0.0
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="3",client_type="consumer",} 0.0
kafka_consumer_consumer_fetch_manager_metrics_records_lag{client_id="ks-test-4-28609cab-a6c3-49fb-8a16-effb44f14bfa-global-consumer",topic="transactions",partition="1",client_type="consumer",} 0.0

However, this is not emitted in dotnet.
How to reproduce

Run the sample below

var config = new StreamConfig<StringSerDes, StringSerDes>();
    config.ApplicationId = "test-app2";
    config.BootstrapServers = "localhost:9092";
    config.UsePrometheusReporter(9098, true);
    config.MetricsRecording = Streamiz.Kafka.Net.Metrics.MetricsRecordingLevel.DEBUG;
    config.StateDir = "./state-store";
    config.AutoOffsetReset = AutoOffsetReset.Latest;

    var isRunningState = false;
    StreamBuilder builder = new StreamBuilder();

    var storeName = "mystore2";
    var mystore = RocksDb.As<string, string>(storeName);

    builder.GlobalTable("transactions",  mystore);

    Topology t = builder.Build();
    KafkaStream stream = new KafkaStream(t, config);

    stream.StateChanged += (old, @new) =>
    {
        if (@new.Equals(KafkaStream.State.RUNNING))
        {
            isRunningState = true;
            Console.WriteLine("Running now");
        }
    };

    await stream.StartAsync();

    while (!isRunningState) {
        Thread.Sleep(500);
        Console.WriteLine("Waiting for running state");
    }

Run curl localhost:9098

Checklist
Please provide the following information:

[x] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[ ] A code snippet with your topology builder (ex: builder.Stream<string, string>("topic").to("an-another-topic");) N/a
[ ] Streamiz.Kafka.Net nuget version. ?
[x] Apache Kafka version. Confluent Cloud
[x] Client configuration.
[x] Operating system. Mac Ventura 13.6.4
[x] Provide logs (with in debug mode (log4net and StreamConfig.Debug) as necessary in configuration).
[ ] Critical issue.

@tsuz
I did some tests of the local branch attached in this issue.
Now, we have the consumer lag per Global Consumer Thread
stream_librdkafka_consumer_metrics_consumer_lag{thread_id="test-app-146c8352-0c9c-46d6-a0af-3fa8323dca68-GlobalStreamThread",librdkafka_client_id="test-app-146c8352-0c9c-46d6-a0af-3fa8323dca68-GlobalStreamThread",application_id="test-app",broker_id="2",topic="Input2",partition_id="0"} -1

But the lag is still to -1, because the GlobalKTable never commit the offset.
We will probably use the consumer_lag_stored stats in this case :
https://github.com/confluentinc/librdkafka/blob/master/STATISTICS.md

@tsuz
Can you test the PR with your use case and let me know if it's good for you ?

@LGouellec
Fantastic. Thank you for the quick turnaround.
I see this topic has 1 partition but has two consumer lag where one is -1? Is this a limitation on the kafka dotnet side?
stream_librdkafka_consumer_metrics_consumer_lag{thread_id="test-app-rocksdbconcurrency2-004fb3c0-3c28-42ca-ab2f-79c67a009c42-GlobalStreamThread",librdkafka_client_id="test-app-rocksdbconcurrency2-004fb3c0-3c28-42ca-ab2f-79c67a009c42-GlobalStreamThread",application_id="test-app-rocksdbconcurrency2",broker_id="11",topic="mytopic",partition_id="0"} 249
stream_librdkafka_consumer_metrics_consumer_lag{thread_id="test-app-rocksdbconcurrency2-004fb3c0-3c28-42ca-ab2f-79c67a009c42-GlobalStreamThread",librdkafka_client_id="test-app-rocksdbconcurrency2-004fb3c0-3c28-42ca-ab2f-79c67a009c42-GlobalStreamThread",application_id="test-app-rocksdbconcurrency2",broker_id="-1",topic="mytopic",partition_id="-1"} -1

@LGouellec Thanks, that makes sense. So far it looks good on my end of testing. 👍


Formatting zero-valued duration does not follow format

I have a function that accepts a duration in minutes and converts it to format HH[h]mm[m].
function (minutes) {
    return moment.duration(minutes, "minutes").format("HH[h]mm[m]");
}

Example: 123 => 02h03m
I am using this function as a render function for some DataTables columns that receive the data as integer but I need it to be formatted as above.
When the function was passed with 0 minutes, it returned only 00m. I was expecting it to be: 00h00m because I need them all to be in the same format. Shouldn't it follow the same format, regardless? Or am I missing something here?

You'll want to set the trim option.
The default behaviour trims leading zero-value tokens:
moment.duration(65, "minutes").format("HH[h]mm[m]");
"01h05m"
moment.duration(5, "minutes").format("HH[h]mm[m]");
"05m"
moment.duration(0, "minutes").format("HH[h]mm[m]");
"00m"

But setting trim: false:
moment.duration(5, "minutes").format("HH[h]mm[m]", { trim: false });
"00h05m"
moment.duration(0, "minutes").format("HH[h]mm[m]", { trim: false });
"00h00m"


Problem building Android example - unable to find library -lVulkan-Headers

Environment:
OS: macOS 13.3
Android Studio: Android Studio Hedgehog | 2023.1.1 Patch
NDK: 25.1.8937393
cmake: 3.22.1
Branch: #v0.9.0
Error:

What went wrong:
Execution failed for task ':app:buildCMakeDebug[arm64-v8a]'.
com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/.cxx/Debug/w4f86y3s/arm64-v8a'
[1/23] Generating ShaderLogisticRegression.hpp
[2/23] Generating ShaderOpMult.hpp
[3/23] Compile vulkan compute shader from file '/Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/src/main/cpp/shader/my_shader.comp' to '/Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/.cxx/Debug/w4f86y3s/arm64-v8a/shader/my_shader.comp.spv'.

-- Interpreting shader in little endian...
[12/23] Linking CXX static library kompute_build/src/logger/libkp_logger.a
[13/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/OpTensorSyncDevice.cpp.o
[14/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/OpTensorCopy.cpp.o
[15/23] Building CXX object CMakeFiles/kompute-jni.dir/KomputeJniNative.cpp.o
[16/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/Sequence.cpp.o
[17/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/Tensor.cpp.o
[18/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/Algorithm.cpp.o
[19/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/Core.cpp.o
[20/23] Building CXX object kompute_build/src/CMakeFiles/kompute.dir/Manager.cpp.o
[21/23] Linking CXX static library kompute_build/src/libkompute.a
[22/23] Building CXX object CMakeFiles/kompute-jni.dir/KomputeModelML.cpp.o
[23/23] Linking CXX shared library /Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/build/intermediates/cxx/Debug/w4f86y3s/obj/arm64-v8a/libkompute-jni.so
FAILED: /Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/build/intermediates/cxx/Debug/w4f86y3s/obj/arm64-v8a/libkompute-jni.so
: && /Users/sanim/Library/Android/sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android26 --sysroot=/Users/sanim/Library/Android/sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -fPIC -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security   -fno-limit-debug-info  -static-libstdc++ -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,--fatal-warnings -Wl,--gc-sections -Wl,--no-undefined -Qunused-arguments -shared -Wl,-soname,libkompute-jni.so -o /Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/build/intermediates/cxx/Debug/w4f86y3s/obj/arm64-v8a/libkompute-jni.so CMakeFiles/kompute-jni.dir/KomputeJniNative.cpp.o CMakeFiles/kompute-jni.dir/KomputeModelML.cpp.o  kompute_build/src/libkompute.a  -llog  -landroid  -lVulkan-Headers  kompute_build/src/logger/libkp_logger.a  _deps/fmt-build/libfmtd.a  -lVulkan-Headers  -latomic -lm && :
ld: error: unable to find library -lVulkan-Headers
ld: error: unable to find library -lVulkan-Headers
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
C++ build system [build] failed while executing:
/Users/sanim/Library/Android/sdk/cmake/3.22.1/bin/ninja
-C
/Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app/.cxx/Debug/w4f86y3s/arm64-v8a
kompute-jni
from /Users/sanim/Documents/UGA/Labwork/kompute/examples/android/android-simple/app

This library is included as part of the build and fetched using github as part of the cmake build. This has not been tested in mac, but has been tested in windows, can you check your build/_deps folder to confirm that vulkan-headers is located there?

I didn't see any vulkan-headers in _deps folder and its subfolders. Please see the attached image those are the things that are available in the _deps folder. Could you please let me know, Is there any cmake configs which are specific to windows?
FYI, I have also tested on ubuntu same error

@axsaucedo Do you have any idea seeing the attached picture from the previous comment?

Thank you for the followup message @math10, it seems I missed the notification - looking at the picture I can see that indeed there are dependencies missing - as you should see something more like the following:

Looking at the logs provided I don't see anything incorrect so far - could you run a clean and then a rerun to see if that helps? Having a verbose CMAKE could also help to understand what may be the issue when fetching the dependencies. It would be useful if you can also share the logs that show the variables set on the cmake build.


[Bug fixes] fix TP_of_chatglm

PR types

Bug fixes
PR changes

Models
Description

The MLP.dense_h_to_4h segmentation of chatglmV1 is based on the default segmentation, resulting in the activation operation and the single card not aligned.
Customize the segmentation strategy function in _get_tensor_parallel_mappings

PR还需要吗?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.