Comparison operator overloading doesn't work with sparse matrices

I'm the developer of a modeling framework for optimization problems called cvxpy. I'd like to support operator overloading between scipy sparse matrices and cvxpy objects.
Currently operator overloading works for arithmetic operations, but I also need it to work for comparison operators. The issue is that all comparison operators route through the _inequality function in scipy/sparse/compressed.py, and there's no code path in that function that returns NotImplemented.
Could you add some code path that returns NotImplemented like in the arithmetic operators? That way the reflection will be called on the cvxpy object. For example, if A is a sparse matrix and x is a cvxpy variable, the expression A <= x will first call A.__le__(x). This needs to return NotImplemented so Python calls x.__ge__(A), which creates a cvxpy constraint object.
The same issues apply to the __eq__ method in scipy/sparse/compressed.py. There should be some code path that returns NotImplemented.
Another solution would be to check __array_priority__ like in Numpy. The object with the higher __array_priority__ would have its comparison operator called first.

The currently active discussion at https://github.com/numpy/numpy/issues/5844 looks related.

A clarification: what I really want is a clean way to make <scipy sparse matrix>.__binop__(<cvxpy object>) return NotImplemented for all binops. Ideally this would be via a flag in cvxpy objects.

I was solving this issue, so shall I include various cases for dense matrix, sparse matrix ,etc: in the binary operator function that are there in add , subtract functions or should I just raise the error.

I'm not sure what you mean. Feel free to open a pull request with some partial fixes and mark it WIP. That way we can discuss the code directly.

Hi, I'd like to work on this bug if nobody is working on it currently. The last activity seems to be a year ago?
If it's possible, a point in the right direction (in terms of what files to understand and what code to modify) would be a big help.

If I understand correctly this has to be done at cvxpy side with either __array_priority__ (or __array_ufunc__ for NumPy 1.13+).

I'm working on another modeling framework for convex optimization and I am hitting the same issue, so I can confirm what @rileyjmurray said:

The trouble is that much of scipy.sparse.spmatrix doesn't check for array priority before calling internal functions. For example, spmatrix.__matmul__ doesn't check for array priority. I believe that not considering __array_priority__ is both the cause of this issue, and a larger issue in-of-itself.

I can add an example to clarify:
>>> import scipy.sparse, picos
>>> A = scipy.sparse.spdiags(range(4), 0, 4, 4)
>>> x = picos.RealVariable("x", 4)
>>> x.T*A  # PICOS gets to load A.
<1×4 Real Linear Expression: xᵀ·[4×4]>
>>> A*x  # SciPy tries to load x as a NumPy array, even though x has infinite priority.
Traceback (most recent call last):
  [...]
picos.valuable.NotValued: Mutable x is not valued.

Note that there is no such problem with NumPy, as ndarray respects x.__array_priority__:
>>> import numpy
>>> A = numpy.diag(range(4))
>>> x.T*A  # PICOS loads A.
<1×4 Real Linear Expression: xᵀ·[4×4]>
>>> A*x  # NumPy leaves the operation to PICOS.
<4×1 Real Linear Expression: [4×4]·x

On cvxpy's end, we have an extremely hacky workaround for the __array_priority__ issue. Basically, when you call import cvxpy, we execute the code in this file to replace spmatrix function handles with our own overloaded versions.

I was just now wondering how you do it! This is good to know, I assumed that you just did not have an __array__ interface on your expressions. This is weirdly appealing but no good for us as we don't import scipy.

This is weirdly appealing but no good for us as we don't import scipy.

@Viech do you mean you don't have SciPy as a dependency? You can still override SciPy's behavior when it's present. In a separate package I work on, I have to override some SciPy behavior and CVXPY behavior. I have SciPy as a dependency so that change is always made. When I override CVXPY behavior I have to check if it's installed first.

Thank you for the hint! We don't use SciPy as a dependency but I was actually referring to importing it (if it is present), as this would add time to import picos. I've measured it now and it seems to be in the order of 30-40 ms extra on a fast computer, which is faster than I expected, but it would still not feel particularly good to load a major library just to patch it.

For now I'll allow the user to patch this issue via picos.patch_scipy_array_priority(). The implementation is as follows:
def patch_scipy_array_priority():
    """Monkey-patch scipy.sparse to make it respect __array_priority__.

    This works around https://github.com/scipy/scipy/issues/4819 and is inspired
    by CVXPY's scipy_wrapper.py.
    """
    import scipy.sparse

    def teach_array_priority(operator):
        def respect_array_priority(self, other):
            if hasattr(other, "__array_priority__") \
            and self.__array_priority__ < other.__array_priority__:
                return NotImplemented
            else:
                return operator(self, other)

        return respect_array_priority

    base_type = scipy.sparse.spmatrix
    matrix_types = (type_ for type_ in scipy.sparse.__dict__.values()
        if isinstance(type_, type) and issubclass(type_, base_type))

    for matrix_type in matrix_types:
        for operator_name in (
            "__add__", "__div__", "__eq__", "__ge__", "__gt__", "__le__",
            "__lt__", "__matmul__", "__mul__", "__ne__", "__pow__", "__sub__",
            "__truediv__",
        ):
            operator = getattr(matrix_type, operator_name)

            # Wrap all binary operators of the base class and all overrides.
            if matrix_type is base_type \
            or operator is not getattr(base_type, operator_name):
                wrapped_operator = teach_array_priority(operator)
                setattr(matrix_type, operator_name, wrapped_operator)

@rileyjmurray and @SteveDiamond: I have not tested your wrapper as I have trouble installing CVXPY at work but I noticed two potential issues with it:

You are not wrapping __ge__, __matmul__, __ne__, __pow__ or __truediv__. I assume that most of these use the other operators internally but maybe this can change in the future.
You do not seem to wrap operators that are overridden in subclasses (e.g. scipy.sparse.csr_matrix.__le__).

Closed by gh-19593!

Wohoo!
On Mon, Dec 4, 2023 at 8:08 PM Lucas Colley @.***>
wrote:

Closed by gh-19593 https://github.com/scipy/scipy/pull/19593!
—
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/issues/4819#issuecomment-1839827166, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRLIFCJ5HOCD3YDJI6MRTLYHZX2RAVCNFSM4BCGIRJKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBTHE4DENZRGY3A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Bolt Review + Universal Invoice + Bifrost

Hi @dr-orlovsky,
I will use this issue to tracking all issues and features related with my LNP Node review.
I would like reference this issue  in all PRs.
BOLT Channel and Payment

[ ] #69 (WIP)
[ ] Allow AcceptChannel co-sign the "Refund TX"
[ ] Review payment management

Bifrost channel establishment (LNPBP 51)

[ ] Add Taproot  Support to LN
[ ] Allow upgrade/downgrade Bifrost

Bifrost payment flow (LNPBP 55)

[ ] Add universal invoice (LNPBP38)
[ ] Allow create invoice over Bifrost
[ ] Allow pay invoice over Bifrost

Minor Fixies/Improvements

[x] #66
[x] #64
[x] #68
[x] LNP-WG/lnp-core/pull/19
[x] #63
[ ] Fix peerd silent shutdown
[ ] Fix freeze after error in lnp-cli connect
[ ] Fix missing balance after channel opening failed

Can you add a tag this issue as "epic", please?

You are doing great job, @crisdut, thank you!


The window navigation overlaps settings

Description

Steps To Reproduce
Resize Files to a smaller area until you can see it happen
Expected behavior
Keep the settings dialogue either lower or less wide so it doesn't overlap
Files Version
Version: <IP_ADDRESS>
Windows Version
OS Version: 10.0.22000.194
Relevant Assets
No response

Merging with #6073.


Add loadbalancing support

Hi,
Just saw the latest beta release where it is possible to get power consumption for the solar integration which is nice. But as an addon to that would it be possible also to use that to update the Charging current sensor in case the overall load is getting to high so decreases that sensor? I have this control by another automation today but would be nice if it would be possible to integrate in the same component :)
Awesome job with the component.

Duplicate of #247


SSH connection stuck on "Connecting"

SSH configuration works on putty with same key and same server. Been using this configuration on Terminus for months, no idea why it has suddenly stopped working. I get no errors just "Connecting". Updated to latest build 135 and problem still happening. I open debugger and this the errors that show up when I try to connect.
GET file:///C:/Users/Twitch/AppData/Local/Programs/Terminus/resources/app.asar/dist/[object%20Module] net::ERR_FILE_NOT_FOUND
2
C:\Users\Twitch\AppD…es\core.umd.js:6479 ERROR Error: Uncaught (in promise): Error: spawn icacls ENOENT
Error: spawn icacls ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:269)
at onErrorNT (internal/child_process.js:465)
at processTicksAndRejections (internal/process/task_queues.js:80)
at resolvePromise (C:\Users\Twitch\AppD…s\dist\zone.js:1255)
at C:\Users\Twitch\AppD…s\dist\zone.js:1162
at rejected (C:\Users\Twitch\AppD…\dist\index.js:1537)
at ZoneDelegate.invoke (C:\Users\Twitch\AppD…js\dist\zone.js:400)
at Object.onInvoke (C:\Users\Twitch\AppD…s\core.umd.js:29203)
at ZoneDelegate.invoke (C:\Users\Twitch\AppD…js\dist\zone.js:399)
at Zone.run (C:\Users\Twitch\AppD…js\dist\zone.js:160)
at C:\Users\Twitch\AppD…s\dist\zone.js:1318
at ZoneDelegate.invokeTask (C:\Users\Twitch\AppD…js\dist\zone.js:434)
at Object.onInvokeTask (C:\Users\Twitch\AppD…s\core.umd.js:29190)
at ZoneDelegate.invokeTask (C:\Users\Twitch\AppD…js\dist\zone.js:433)
at Zone.runTask (C:\Users\Twitch\AppD…js\dist\zone.js:205)
at drainMicroTaskQueue (C:\Users\Twitch\AppD…js\dist\zone.js:620)

Somehow C:\Windows\System32 got removed from PATH. Adding it back through environmental variables resolved this problem, sorry for even creating the issue, figured it out 10 minutes later.


Disable Open Z-Wave in Docker

We were depending on the Python 3 Open Z-Wave branch that was removed yesterday. This caused our build Z-Wave script to stop working and our Docker builds to fail.
This PR is just to get the Docker builds working again.

FYI, I changed my Raspberry pi Dockerfile a week ago and it works fine;
--- a/virtualization/Docker/scripts/python_openzwave
+++ b/virtualization/Docker/scripts/python_openzwave
@@ -24,9 +24,11 @@ else
fi
git checkout python3
-pip3 install --upgrade cython==0.24.1
-PYTHON_EXEC=which python3 make build
-PYTHON_EXEC=which python3 make install
+#pip3 install --upgrade cython==0.24.1
+#PYTHON_EXEC=which python3 make build
+#PYTHON_EXEC=which python3 make install
-mkdir -p /usr/local/share/python-openzwave
-cp -R openzwave/config /usr/local/share/python-openzwave/config
\ No newline at end of file
+pip3 install python_openzwave
+
+#mkdir -p /usr/local/share/python-openzwave
+#cp -R openzwave/config /usr/local/share/python-openzwave/config

PRs welcome 👍


Worked on the share ixprez features

Please Verified and merged with the master

Verified and merged with the master.


tunnel supports using websocket and quic as transport protocol

The tunnel config add Transport field
The tunnel module support change transport protocol, like tcp(use by default), ws and quic
Removed the liveness probe because k8s does not support probes for the udp protocol
Added the transport config in helm the updated helm charts

How to use?
modules:
  tunnel:
    enable: true
    transport: quic   # <--- supported protocols ["tcp", "ws", "quic"]

You need to make sure that the transport configuration of both edgemesh-agent and edgemesh-server has been modified.

/cc @fisherxu


React intl aws details table

issue: https://issues.redhat.com/browse/COST-1372
https://user-images.githubusercontent.com/57504257/130530754-c1a4df79-95d3-4e08-bece-acb1041594ec.mov

Codecov Report

Merging #2112 (d802a5f) into react-intl_changeover (3ba2124) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           react-intl_changeover    #2112   +/-   ##
======================================================
  Coverage                  70.37%   70.37%
======================================================
  Files                        410      410
  Lines                       7506     7506
  Branches                    1457     1457
======================================================
  Hits                        5282     5282
  Misses                      2192     2192
  Partials                      32       32

Impacted Files
Coverage Δ

src/locales/messages.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e753b...d802a5f. Read the comment docs.


Can wildcards be used?

Like this.
gopass rm 192.168.*
gopass rm 192.168.*
Error: Can not delete key "<IP_ADDRESS>.gpg" from "<IP_ADDRESS>.gpg": entry is not in the password store

Actually since this is ZSH's wildcard at work.
This command is equivalent to the following command.
gopass rm <IP_ADDRESS> <IP_ADDRESS>
And it seems that most of the commands of gopass do not support manipulating multiple items at a time, the wildcards supported by ZSH are not actually available.

As you stated wildcard-expansions are done at the shell, and I'm not confident that you get the expected results even if your $PWD is pointing to the store-path. As your snippet shows it also appends the '.gpg' suffix on expansion.
Even if that would be removed, in the current version 'rm' only retrieves the first argument.
You can however delete directories recursively.

Wildcards are important, are there any plans to develop this feature?
And I can't seem to use the commands I'm used to, such as rm -rf, which makes me very uncomfortable.

gopass rm -rf is supported and should behave like the unix-tool, except with multiple arguments.
Do you have an example where it doesn't?
Currently fuzzy matching is not supported in rm, but I think this could be done.

Commands with two or more arguments probably fall into this category.

This should be patched by #2239 @daiaji
Can you try v1.14.3 and report if it now works as expected on your side?

I think I will try.

Feel free to re-open if still relevant.


feat(dart_frog_cli): include uninstall command to uninstall dart_frog_cli

Description
As a user I would like to uninstall dart_frog_cli by using dart_frog uninstall, this should:

Remove global files created when installing dart_frog_cli (for example, completion files)
Deactivate dart_frog_cli

Additional Context

Useful for sharing uninstallation logic between IDE extensions.
Improve user's experience since currently a full uninstall requires:

dart_frog uninstall-completion-files # Hidden command most users are not aware of.
dart pub global deactivate dart_frog_cli

Logging some of the decisions we made about this:
We should not assume that the CLI was installed via pub global activation, even though as of today, this is the only official way to install the DF CLI. As a result, there is not precise way to programmatically uninstall the CLI.
To tackle this issue now, one must:

Add an uninstall section to the DF docs site
Add the uninstall command to the CLI that will print a link to that section.

I can tackle this one 😄


Add support for aria-describedby to bind help text to inputs

Package version: 2.1
Django version: 4.2
Python version: 3.11
Template pack: crispy-bootstrap5==2024.2

Description:
I noticed that the aria-describedby attribute is not currently being added to form inputs to associate them with their help text. This is an important accessibility feature that allows assistive technologies to provide better context for users.
Is there a built-in or recommended way to include the aria-describedby attribute on inputs when using crispy forms? If not, could this functionality be considered for inclusion in a future update? It would greatly enhance the accessibility of forms generated with this library.

Actual HTML generated

      Organització

   <input type="text" name="organitzacio" maxlength="120" class="textinput form-control" required="" id="id_organitzacio">

Some help text

Expected HTML, check aria-describedby="id_organitzacio_helptext" :

      Organització

   <input type="text" name="organitzacio" maxlength="120" class="textinput form-control" required="" id="id_organitzacio" aria-describedby="id_organitzacio_helptext">

Some help text

Yes, absolutely. Errors too.
However, Crispy-forms relys on django for rendering of the <input>.
The good news though is that this should work with Django 5.0+. See release notes.
https://docs.djangoproject.com/en/5.1/releases/5.0/#forms


Preset for generate subtitles

Describe the feature
When we want to generate subtitles currently it's too long for each sentence.
A workaround is to enable word timestamps and max sentence length to eg 24 letters through the more options list.
We should provide preset button to set preset options eg for generate subtitles

Added in 2.6.9


Add UI Tests Workflow

Nearly there, but the prepare script hasn't had the desired affect.  Even though I've updated the test code, and the prepare script has run, I docker container build has used the cached code...


Do we need to use prebid universal creative?

We erogate only display banner on our website without AMP and without SafeFrame. We are using right now the legacy rendering code:
<script> var w = window; for (i = 0; i < 10; i++) {   w = w.parent;   if (w.pbjs) {     try {       w.pbjs.renderAd(document, '%%PATTERN:hb_adid%%');       break;     } catch (e) {       continue;     }   } } </script>
If I read the code of https://github.com/prebid/prebid-universal-creative/blob/master/src/renderingManager.js, I see that In my case the script erogates the legacy code:
    if (environment.isMobileApp(targetingData.env)) {       renderAmpOrMobileAd(targetingData.cacheHost, targetingData.cachePath, targetingData.uuid, targetingData.size, targetingData.hbPb, true);     } else if (environment.isAmp(targetingData.uuid)) {       renderAmpOrMobileAd(targetingData.cacheHost, targetingData.cachePath, targetingData.uuid, targetingData.size, targetingData.hbPb);     } else if (!environment.canLocatePrebid()) {       renderCrossDomain(targetingData.adId, targetingData.adServerDomain, targetingData.pubUrl);     } else {       renderLegacy(doc, targetingData.adId);     }
Do we need to use prebid universal creative? Are there any benefit to use prebid universal creative instead legacy rendering code in our case?

If you're not using safeframes, AMP, mobile, or native, then a direct call to pbjs.renderAd is fine.
I'll leave this open until we document this on prebid.org somewhere. There ought to be a page that talks more about PUC in general, including other load options some pubs may wish to consider.

The docs page at https://docs.prebid.org/overview/prebid-universal-creative.html was updated with alternate approaches to the PUC.


Depay how to support more chains?

Hello, our project is using Depay as the payment component for our application. Currently, the Depay documentation states that it only supports three chains: eth, bsc, polygon. Now, I would like to add support for Tron. Is it possible to do this by ourselves? Or , do you have plans to expand support for more chains?

Hi @dingcxx
We have plans to extend to more chains. We have quite a list of blockchains we want to add this year.
In this regard, we have our own priorities. Currently, TRON is not within our 1-tier priorities.
Nonetheless, you can help add support for new blockchains.
If you look into https://github.com/DePayFi/widgets/blob/main/package.json you will see that there are a lot of underlying libraries that all come together for the payment widgets. Adding a new blockchain always starts with adding them to the lowest level of our stack:
web3-blockchains
web3-mock
web3-client
react-token-image
web3-tokens
web3-wallets
web3-exchanges
web3-assets
web3-payments
Once support for the new blockchain is added to all underlying libraries widgets will be able to support the new blockchain.
If you currently rely on payment tracking via DePay APIs, that's obviously separate work but adding support for a new blockchain to all low-level DePay libraries is always the first step.

I understand, it seems like a huge project. There is also one question: since Tron blockchain does not support EVM, does this mean that all payment protocols have to be rewritten?

Yes. adding a non-evm-based blockchain is a lot of work. It's not just adding an rpc url. This is one of the main reasons we at DePay work on harmonizing various blockchains/platforms into a single Web3 Payments interface.

It is recommended to put all configurable data in a library, otherwise modifying it will be a major project. Wagmi provides the 'references' library to provide extensibility, so that third parties can contribute quickly. This approach may be more suitable for the current situation.

@qtdc1229 and your point is?
Does this not look like a configuration to you?
https://github.com/DePayFi/web3-blockchains/blob/master/src/blockchains/polygon.js


Deprecate Authorizers

Authorizers are a bit too complex and the implementation is not great currently. While they seem to offer a lot of flexibility they actually don't deliver as they are quite tightly coupled to the authenticator as they depend on values being retrieved by them. Instead we could probably provide a better mechanism for adding for injecting headers into outgoing requests as that's the use care in a majority of the projects out there. I'm thinking about an API somewhat like this for Ember Data adapters, e.g.:
import JSONAPIAdapter from 'ember-data/adapters/json-api';
import DataAdapterMixin from 'ember-simple-auth/mixins/data-adapter-mixin';
import config from '../config/environment';

const { comuted, inject: { service } } = Ember;

export default JSONAPIAdapter.extend(DataAdapterMixin, {
  session: service(),
  host: config.apiHost,
  headers: computed('session.data.authenticated.token', function() {
    let token = this.get('session.data.authenticated.token');
    return `Bearer ${token}`;
  })
});

I'm not sure whether Ember Data currently supports headers being a computed property but I guess that could probably be added. It might be cool if it could even support it returning a promise as there's the use case that a single use token for each request might be needed that would have to be retrieved as sort of a pre-flight request in which case the computed property would return a promise that resolves with the header then.
/cc @pangratz

Ember Data does support computed properties for headers. What value does DataAdapterMixin add in that case? If headers would have to be declared in each adapter, this seems it would lead to a proliferation of boilerplate in cases where you had model-specific adapters. This is particularly bad when you have multiple data sources as ED has no layer of adapter between application and model.

When you're using multiple adapters in the vast majority of cases they share a common base adapter. If that's not the case you could use a mixin to share the code that sets the custom headers.

I agree. If you're writing them all yourself, that's certainly an option.
I've recently been working with ember-data-github which tries to supply it's own token-passing mechanism based on a headers CP. I could monkey patch its adapter base class in an initializer or extend the model adapters adding an initializer in each one. The former is a bit ugly and the latter a bit laborious. I would see the latter as even worse without authorizers.
While the abstraction of an authorizer doesn't add a lot, I see it as useful for these kinds of cases. I would postulate that authorizers haven't been used very much because of a lack of documentation more than a bad design.

The point is that authorizers don't do much anyway. Previously they did more but were also tightly coupled to jQuery's AJAX API. In the case of the OAuth 2.0 Bearer authorizer what it does is really trivial and I'm not sure it's worth it keeping the concept around. I think sth. like DataAdapterMixin is far more valuable for most people.

I can see that. I don't like the way headers overrides everything. I wish it were additive instead. If there were a nice way to roll that into the mixin, that would be great.
BTW, the example above should
return { Authorization: `Bearer ${token}` };

I believe.

I can see that. I don't like the way headers overrides everything. I wish it were additive instead. If there were a nice way to roll that into the mixin, that would be great.

Yeah, that's a very good point.

Agreed. I started out with my own OAuth authenticator with email/password credentials, then started to hit snags as soon as I tried adding in GitHub and Google as identity services. All I'm ever querying is my own models -- I have no use for querying GitHub models as the GitHub example shows -- GitHub is  just an identity service to me, and this use case seems to be really hard for me to pull together.

By the way, here is how I got two authenticators working, one as my primary OAuth authenticator and authorizer, and a 2nd being Torii to use GitHub (and then others) as an identity service:
From my login controller:

session.authenticate('authenticator:torii', 'github').then(...)
this.get('target').send('setDisableDefaultSessionInvalidation', true') // disable page reload on logout
session.destroy() // destroy torii GitHub session
this.get('target').send('setDisableDefaultSessionInvalidation', false') // restore the usual reload-on-logout
session.authenticate('authenticator:auth', 'oauth:github:'+username, githubAccessCode) // authenticate with my normal OAuth backend using GitHub identity.

Then in my application route:
export default Ember.Route.extend(ApplicationRouteMixin, {
  disableDefaultSessionInvalidation: false,
  ...
  sessionInvalidated() {
    if (!this.get('disableDefaultSessionInvalidation')) {
      this._super()
    }
  },
  ...
  actions: {
    error: function(adapterError) {
      //let code = Number(_.get(adapterError,'errors[0].status'))
      _.forEach(adapterError.errors, (error) => {
        this.get('notify').error(error.detail, {autoClear:false})
      })
    },
    setDisableDefaultSessionInvalidation(disable) {
      this.set('disableDefaultSessionInvalidation', disable)
    }
 }

cleaning up old issues


1.65.0 Consuming a lot of CPU...code navigation is slow

Issue Type: Bug
After updating to the latest release of VS Code (1.65.0), it has starting consuming a lot more CPU and memory....code navigation is unusable.  Any insights as to why this is happening?
VS Code version: Code 1.65.0 (b5205cc8eb4fbaa726835538cd82372cc0222d43, 2022-03-02T11:12:08.962Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2904)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.74GB (18.62GB free)

Process Argv
--crash-reporter-id a33ec631-4700-4009-b1a5-ec7d22d15b65

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

nugetpackagemanagergui
ali
1.1.9

vscode-eslint
dba
2.2.2

xml
Dot
2.5.1

gitlens
eam
12.0.1

prettier-vscode
esb
9.3.0

gitkraken-authentication
git
1.0.3

vscode-nuget-package-manager
jmr
1.1.6

vscode-azurefunctions
ms-
1.6.0

vscode-azureresourcegroups
ms-
0.4.0

vscode-cosmosdb
ms-
0.18.1

vscode-docker
ms-
1.20.0

csharp
ms-
1.24.1

remote-containers
ms-
0.224.2

remote-wsl
ms-
0.64.2

azure-account
ms-
0.10.0

azurecli
ms-
0.5.0

powershell
ms-
2021.12.0

vscode-typescript-tslint-plugin
ms-
1.3.3

debugger-for-chrome
msj
4.13.0

language-stylus
sys
1.15.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30433507
vsclayoutctrc:30437038
vsrem710:30416614
dsvsc009:30440023
pythonvsnew555:30442236
vsbas813:30436447
vscscmwlcmt:30438805
vscgsvid1:30447480
helix:30440343

Please follow these instructions to collect performance information. Share the output of code-insiders --status

Here is the output of code --status:
Version:          Code 1.65.0 (b5205cc8eb4fbaa726835538cd82372cc0222d43, 2022-03-02T11:12:08.962Z)
OS Version:       Windows_NT x64 10.0.19044
CPUs:             Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2904)
Memory (System):  31.74GB (19.87GB free)
VM:               0%
Screen Reader:    no
Process Argv:     --crash-reporter-id a33ec631-4700-4009-b1a5-ec7d22d15b65
GPU Status:       2d_canvas:                  enabled
gpu_compositing:            enabled
multiple_raster_threads:    enabled_on
oop_rasterization:          enabled
opengl:                     enabled_on
rasterization:              enabled
PS C:\Code\Newton\EVolvED\source\service> code --status
Version:          Code 1.65.0 (b5205cc8eb4fbaa726835538cd82372cc0222d43, 2022-03-02T11:12:08.962Z)
OS Version:       Windows_NT x64 10.0.19044
CPUs:             Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2904)
Memory (System):  31.74GB (19.57GB free)
VM:               0%
Screen Reader:    no
Process Argv:     --crash-reporter-id a33ec631-4700-4009-b1a5-ec7d22d15b65
GPU Status:       2d_canvas:                  enabled
gpu_compositing:            enabled
multiple_raster_threads:    enabled_on
oop_rasterization:          enabled
opengl:                     enabled_on
rasterization:              enabled
skia_renderer:              enabled_on
video_decode:               enabled
vulkan:                     disabled_off
webgl:                      enabled
webgl2:                     enabled
CPU %   Mem MB     PID  Process
0       99   15252  code main
0      107   15044     shared-process
0       82    3504       fileWatcher
0       91   18024       ptyHost
0        6    2052         console-window-host (Windows internal process)
0       91   16304         C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe
0       16   10492           C:\WINDOWS\system32\cmd.exe /c ""C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\bin\code.cmd" --status"
0       84    2288             "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\bin..\Code.exe"  "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\bin..\resources\app\out\cli.js" --ms-enable-electron-run-as-node --status
6      115    4924               "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --status
0       74    4544                 crashpad-handler
0      169   15944     extensionHost
0       80    8996       "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=15944
8     1123   12724       "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node --max-old-space-size=3072 "c:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js" --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName C:\Users\KELLYH~1\AppData\Local\Temp\vscode-typescript\7a5c88b33ad1682e6614\tscancellation-b3185407371594c92e38.tmp* --globalPlugins typescript-tslint-plugin --pluginProbeLocations c:\Users\KellyHilliard.vscode\extensions\ms-vscode.vscode-typescript-tslint-plugin-1.3.3 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc
0       97   13236         "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:/Users/KellyHilliard/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/typingsInstaller.js" --globalTypingsCacheLocation C:/Users/KellyHilliard/AppData/Local/Microsoft/TypeScript/4.6 --enableTelemetry --typesMapLocation "c:/Users/KellyHilliard/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/typesMap.json" --validateDefaultNpmLocation
0      362   16084       "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node c:\Users\KellyHilliard.vscode\extensions\dbaeumer.vscode-eslint-2.2.2\server\out\eslintServer.js --node-ipc --clientProcessId=15944
0      127   16856       "C:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node --max-old-space-size=3072 "c:\Users\KellyHilliard\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js" --serverMode partialSemantic --useInferredProjectPerProjectRoot --disableAutomaticTypingAcquisition --cancellationPipeName C:\Users\KELLYH~1\AppData\Local\Temp\vscode-typescript\7a5c88b33ad1682e6614\tscancellation-30ff4f1db65b753a2316.tmp* --globalPlugins typescript-tslint-plugin --pluginProbeLocations
c:\Users\KellyHilliard.vscode\extensions\ms-vscode.vscode-typescript-tslint-plugin-1.3.3 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc
0       54   17012     utility-network-service
0      192   17024     gpu-process
0       34   17892     crashpad-handler
0      226   18228     window (hl7Import.ts - service - Visual Studio Code)
Workspace Stats:
|  Window (hl7Import.ts - service - Visual Studio Code)
|    Folder (service): 3032 files
|      File types: ts(815) html(389) jade(386) styl(371) js(369) bcmap(168)
|                  json(131) png(48) ttf(23) log(20)
|      Conf files: tsconfig.json(5) package.json(2) dockerfile(2)
|                  launch.json(1) settings.json(1) tasks.json(1) gulp.js(1)
|                  webpack.config.js(1)
|      Launch Configs: node(8)

Unfortunately that doesn't show anything using a lot of cpu
What language are you working in?  Does this reproduce in the latest VS Code insiders build with all extensions disabled?

I am using nodejs/express and no extension is enable except Visual Studio IntelliCode. And I have the same problem.

@mjbvz I will give that a try....I am working in Typescript.  I do notice that it really seems to kick in as soon as I open up a TypeScript file in the editor.

Just FYI....I downgraded back to the January version:
Version: 1.64.2 (user setup)
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:28.252Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19044
...the problem goes away there.  So it really seems like something introduced in 1.65.

@skhilliard Can you share a project that causes this issue so we can investigate?

@mjbvz I tried created a small project to reproduce but didn't have any luck.  This currently is happening with our project which is quite large...and for obvious reasons, I can't put our company's code base up here....what else can I provide to help you?

Try putting together a minimal project that demonstrates the problem so we can investigate on our machines
Alternatively, you can also try collecting the TypeScript server log. However this may include source code that you either need to scrub or share the log with us privately:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a large log file called tsserver.log

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

@mjbvz I will gather the Typescript server log for you.....how can I share this with you at Microsoft privately?
Thanks,
Kelly

@mjbvz I have some logs ready for you if you can supply the means by which to get them to you.
Thanks,
Kelly

Maybe related: #145309

@mjbvz Did you have a chance to review the Typescript logs I email to you?
Thanks!

@skhilliard Yes thanks, I've forward them along to the TS team as I didn't see anything that stood out to me. Hopefully they will identify what is going on

Has there been any feedback from the TS team regarding this?


Update: lite-regen-meter

Added better rendering and handling for debuff orb icons.

You need to pdate your config group value to be distinct from the one in runelite
https://github.com/Varietyz/literegenmeter/compare/75470dcc8e51c49e92626c046aad5facb7334c54...Varietyz:b0d70c2f3190d8327fbb3d99876b57e9fd53c580#diff-ac69d48cdfd018a21cb59dc6963b6c5b28ddbd412b8bca6596c549c98d8c9ad8L40

You need to update your config group value to be distinct from the one in runelite
Varietyz/literegenmeter@75470dc...Varietyz:b0d70c2f3190d8327fbb3d99876b57e9fd53c580#diff-ac69d48cdfd018a21cb59dc6963b6c5b28ddbd412b8bca6596c549c98d8c9ad8L40

Should be resolved now. :)


Use the latest photo_manager's paging to refactor the code.

hi，请问在icloud的图片可以正常显示吗，photo_manager 0.3.5版本

hi，请问在icloud的图片可以正常显示吗，photo_manager 0.3.5版本

This icloud problem should have been fixed in photo_manager 0.3.5.
You can use it.
photo_manager : ^0.3.5
photo: ^0.3.4+1

Photo_manager version 0.4.0 is being refactored
The latest version of photo will also be followed by photo_manager changes in the recent period.
The photo_manager version 0.4.0 link caijinglong/flutter_photo_manager#102

ok, thanks


Can radar chart border  support dash style.

** Don't make a duplicate issue.
You can search in issues to make sure there isn't any already opened issue with your concern.
Is your feature request relasted to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Please explain more about it and remove the placeholders of the issue template. Write about it.


Add a license to the spec

We're licensing hte spec under ASLv2. Add the LICENSE file, and add the
short-form to as much of the source as is practical right now (adding it to
json source is a massive pita).
(Fixes https://matrix.org/jira/browse/SPEC-412)

Other than ew with short form on alllll the files (which I guess we can't help) LGTM.


Exclusion Report | Gov Analyst Recommend Rejection |1|

Story:
As a Government Analyst, I want to be able to recommend rejection of an exclusion report.
Scenario:
GIVEN that I am an IDIR user
AND I have the Government Analyst role
AND I am viewing a submitted Exclusion Report (i.e. status = Submitted)
AND I am on the Exclusion Agreements page
WHEN I click on the Recommend Rejection button
AND I accept the confirmation alert
THEN I am returned to the main compliance reporting page
AND the status of the report in the UI changes to Reviewed - Analyst (back-end status should be "Recommended Rejection - Analyst")
And a report history record is created (see below)
AND a system alert appears on the screen
Status update visibility:

The status change should only be visible to IDIR users. For BCeID users, the status should remain at Submitted.

Report History Record:
A report history record should be created when the Gov't Analyst recommends rejection of the report. The format should be as follows:

Reviewed and <Status> on Month DD, YYYY by <First, Last Name> of <Organization Name>
Example: Reviewed and Recommended Rejection on March 31, 2019 by Justin Lepitzki of Government of British Columbia

Note: This report history record should only be visible to IDIR users.
Confirmation Alert Messaging:

Are you sure you want to recommend rejection of the exclusion report?

System Alert Messaging:

Rejection Recommended

https://trello.com/c/JdHg27zF/1687-exclusion-report-gov-analyst-recommend-rejection-1

 Exclusion Report | Gov Analyst Recommend Rejection |1|

resolved in sprint vulcan


when I use the gui interface the pattern run a generic exemple:

What happened?
when i give a yt transcript in gui interface and select a patternin this case "summarize debate",  (llm llama3 ). I was expecting  to get the summarize of the yt script  but happen instead that it give me a generic interviuwe    "Lera Boroditsky, a cognitive scientist, discusses how our language shapes our thought and perception of reality with Sam Harris, a neuroscientist......"  complitly out of context .
Version check

[X] Yes I was.

Relevant log output
No response
Relevant screenshots (optional)
No response

can you give a little more?
how about did you get node and npm?
are you using llama3:70b or llama3:latest?


Unbookmark API in 'My bookmarks' view displays empty page

Steps

Visit https://staging.apinf.io  (version 0.38.0)
Login as owner
Click on 'APIs'
Bookmark any two APIs
Go to filter and click on 'My Bookmarks'
Unbookmark any one API by clicking on 'flag' sign

Findings

Incorrect help text 'Bookmark API' when user bookmarked API already
Unbookmark any one API in 'My bookmarks' view displays empty page

Screenshot

@saralavanip This should be resolved. Please verify this with release 0.39.0, when it has been deployed to staging. Closing the issue.

@bajiat , verified this resolved issue on https://staging.apinf.io version 0.39.0 and it is not reproducible.


Fix negative partial-hour offsets

The sign of the offset needs to be applied after the timedelta is constructed, or else in the case of negative offsets the minutes will be counted in the opposite direction as the hours.

Merged in at  309faab


[RaceDepartmentBridge] new feed url & page struct

The base feed url and the page structure of the site has changed.

gj @t0stiman !


Sophiathekitty/issue13

i think i got the basic functionality and styles working for the mobile view.

shoot i forgot i still need to test the tasks styles.... ah well.... if i need to fix something with those i'll just do it on main...


Error uploading - stability issues

I was looking at code base.
How is STATUS_ACK_ERR_FRAGMENT_DURATION_REACHED a recoverable error?
https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/master/src/client/include/com/amazonaws/kinesis/video/client/Include.h#L198
If this is due to missing i frame how this error will recover? Isn't this a bug?

This is generated from KVS backend to indicate that the fragment is longer than 10 sec (I believe this is the default - should check the limits docs). This is normally caused by the encoder not producing regular interval Idr frames so the fragments go for longer.

Closing assuming answered


ARROW-15993: [CI] Add sphinx-tabs to ci/conda_env_sphinx.txt

sphinx-tabs 3.2.0 is compatible with our other dependencies now. Hence we should add it back to ci/conda_env_sphinx.txt so that the developer guide on building docs match reality.

@jorisvandenbossche Could you please review it? I don't think I'm responsible for the errors.

Can you also update conda-python.dockerfile?

@jorisvandenbossche Done! Also confirmed that sphinx-tabs is not explicitly mentioned anywhere in the repo other than ci/conda_env_sphinx.txt and docs/requirements.txt now.

@github-actions crossbow submit test-ubuntu-default-docs


repokitteh: fixing whitespace

Signed-off-by: Alyssa Wilk<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@RyanTheOptimist given the comment on   https://github.com/envoyproxy/envoy/pull/24356 I'm inclined to force merge this.  "Fixed" by searching for " " in VIM and replacing all the whitespace which wasn't highlighted so only moderately confident it'll fix things but highly confident it won't make things worse.

oh right you're afk will ping #maintainers


rescue Exception --> rescue LoadError

Rescuing from Exception is dangerous when not rethrown. In this case, a more specific class can be used. This PR uses the LoadError class, which has Gem::LoadError (the actual exception that is thrown) and Gem::ConflictError for descendants.
Rational for this PR here: http://stackoverflow.com/a/10048406/80636

Looks good, thanks!


Cannot download pretrained models from Git LFS

Hi,
I cannot download pretrained models due to quota issue on Git LFS. Here is the error message:
This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
Could you please fix it or host pretrained data anywhere else for me to download?
Thanks.

Thank you for the remark, models are now available through zenodo. We also updated the readme.


[Add] Add a new set of websites

Hi @Bhavesh0327 you'll need to remove duplicates links from your Pull Request.
Only one or two links per pull request is appreciable

Yes @sdmg15 sir for sure, can you please let me know which links should i remove?  I added 3 links actually, and i felt like all three were important and supposed to be there
i. leetcode
ii. Aditya verma Youtube channel
iii. Rust coding style guide


mne watershed

Hey guys, Is it possible to get a BEM for a t1 template? I tried to used watershed on mni template and it didn't work. It works on a standard t1.

I am sure their already exist good BEM surfaces for MNI template if it is
what you have in mind

you can rip the one out of SPM, I generated that based on the colin 27 scan. it isn't good the scans on most templates don't cover the whole head, and thus don't work well for BEMs. Generally, I just discourage people from using templates for source recon

I see .. Unfortunately I don't have the T1 for my participants. I was thinking of doing something like eLORETA. But then if I can get MNE to work then I can try multiple source recon methods and DICS. How about the 3T 18yo Schwartz ReactN32 that is in freesurfer?

I would just use the one from SPM, it is in their code somewhere. The weakness of the shape is unlikely to cause bigger problems than mapping data from one person to another.

@dgwakeman if you have time and since you already extracted the surfaces ... can you point me where to look in SPM and how to integrate with MNE. I following the tutorial and am at the point where I need the .surf files. Currently searching the SPM folder for clues.

OK I think I got it.

please share any insights here in case someone else has the goal

The surf files are in spmX/canonical/. I am testing them now. Freesurfer also has the same BEM data but they are in mat format. Dont know the surf format to convert time. Apparently they have a better estimate of the data by correcting for anti-aliasing.

However they are in .gii format need to convert them to surf. @dgwakeman Any ideas?

mris_convert does not support converting to .surf format.

nibabel can read gii and mne can save .surf files


Progress bar for form submissions

At the moment, progress bar is shown only for slow responses initiated by a click on a link. However, when a form is submitted and the response is slow, then no progress bar is shown and it looks like nothing is happening.
Is this intentional? Are there any plans for adding the progress bar to form submissions?
Thanks!

I'm sorry. I should have searched better. Closing in favor of #61.

I'm sorry. I should have searched better. Closing in favor of #61.


Optimize attribute escaping

Coverage remained the same at 100.0% when pulling a2068edc1934bdf7521e2f6b0d29d1efcb0453ef on escape into 57466ed5449121ab5bae976c1bffd4374c4c5ce9 on master.

Coverage remained the same at 100.0% when pulling 416c0136ab0c1e17e329a33fb8548124c8e5192a on escape into 57466ed5449121ab5bae976c1bffd4374c4c5ce9 on master.


Feature request: replay sound

I think it would be very good to be able to replay sound in the card

Update to the newest version of Ankimote that I just uploaded on Ankiweb. The "check for updates" button in Tools> Addons should find the update.
Then restart anki, go to Tools > Addons > Ankimote > Config,  and replace one of the custom action codes, such as cmd2, with "mw.reviewer.replayAudio()" .

Thanks a lot. I will go back to review now.


oev_text_color is not working

oev_text_color is not working.

Hi, this issue has been fixed with the latest release v0.1.6
Thanks for reporting an issue, glad to have assisted you.
Do continue using PassCodeText, and let me know if there are any enhancements in the future!


Removes printing of error messages when propagating

Per #385 if the user wants to propagate the exception and display the full stack trace on an unhandled exception, we have already printed out an error message ourselves resulting in both being displayed. This moves the printing of the message after the throws.

whoops, i disabled my auto-running of the tests last night while working on something and missed the mountain of unit tests that are now failing. gonna look at those now.

Bit more involved than I thought.
End of the day the unit tests were expecting the pretty message to be displayed, but because we were propagating the exception it wasn't receiving it anymore. It kind of felt like a hack at first to make the Pretty property public, but then the more I thought about it the more it felt like if I wanted access to it here while propagating then other users might want it too if they are propagating it.

@phil-scott-78 I agree. Merged!


WIP: inbox and message box contracts

Description
Closes #517
Closes #516
TODO: Add tests
Checklist:

[ ] I have reviewed my diff in github, line by line.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[ ] The branch has been merged or rebased against the head of its merge target.
[ ] I'm happy for the PR to be merged at the reviewer's next convenience.

When passing in structs to functions e.g., sendL2Message(L2Actor memory _recipient it often becomes more cumbersome to use as you need to import or define the struct, with foundry sometimes being unhappy about same struct defined multiple places if simply copying. Think it would be better if we don't have structs as the inputs for functions that are used externally or at least create a data structures library that can easily be imported for usage.

For the registry. Also useful to support fetching just one of the values. For portals doing an exit they don't need to know of the inbox so it wastes gas to fetch it if only supporting getL1L2Addresses.
Similar for the message box, your onlyRollup() modifier is pulling unused values from registry.

I've implemented this with interfaces for moving the structs about on my branch if you wanna yoink it @rahul-kothari


Add Starcoder 2

Adding new code models that dropped
merged to Transformers

This looks nice. Is it working?
There is an open issue btw #500, not sure if @lazarust made any progress? Maybe this is a good PR to collaborate on, though it looks like it is basically done?

@awni I haven't had time to make progress yet, but this solution looks like it's the right direction

Is it working?

@awni not yet hf is down 😞 but when trying to generate locally despite files being there and import working getting
ValueError: Model type starcoder2 not supported. Error: No module named 'mlx_lm.models.starcoder2'
but when I do in python shell I do not get that error but hf down error, is this behaviour intended
@lazarust happy to collaborate, this is still draft based on original mistral implementation I think we need some more changes from https://github.com/huggingface/transformers/pull/29120

but when I do in python shell I do not get that error but hf down error, is this behaviour intended

No it's not. Make sure you do not have another MLX LM installed (pip uninstall mlx-lm). Also make sure you have an editable install pip install -e .

qq @awni  is gelu_pytorch_tanh equivalnet in mlx is
    def __call__(self, x) -> mx.array:
        return self.w2(nn.gelu(self.w1(x)) * self.w3(x))

@Muhtasham the tanh approximation in PyTorch is not strictly the same as nn.gelu but it is close to several significant digits so it should not cause any issues. See the plot at https://github.com/ml-explore/mlx/pull/744#issuecomment-1965616223 for the difference between PyTorch's Tanh approximation and nn.gelu .

How is this going? Were you able to generate any sensible code yet?

Having some,
raise ValueError(f"Received parameters not in model: {extras}.")
I went through model config nothing seems extra  any hints @awni ?
command
python -m mlx_lm.convert \
    --hf-path bigcode/starcoder2-3b \
    -q \
    --upload-repo mlx-community/starcoder2-3b-4bit

I suggest either referring to the transformers implementation if you are familiar with the codebase, or loading the model weights and checking the weight names which will give you a hint of the model structure.
https://github.com/huggingface/transformers/blob/main/src/transformers/models/starcoder2/modeling_starcoder2.py#L1070

A couple more things from what I can see:

Replace RMSNorm with LayerNorm
Use transposed token embeddings (like in Gemma) as there are no output weights

thanks for all the help!
Resolved all the layer errors but now getting
ValueError: The checkpoint you are trying to load has model type starcoder2 but Transformers does not recognize this architecture. This could be because of an issue with the checkpoint, or because your version of Transformers is out of date.
I have trasfomers: 4.38.2 @awni  any leads here

Quick addition: apparently the 15B starcoder2 has output weights, so there needs to be a check when initializing the model.

@armbues @Muhtasham use this flag in the config to determine if embeddings should be shared with outputs.

I tried the 3B model, it looks almost right but maybe missing something as it goes off the rails at the end.
Also it ran without crashing with my install of Transformers library (4.38.0). I reverted the requirement.. maybe you had an old version?
 python -m mlx_lm.generate --model bigcode/starcoder2-3b --prompt "Write a quick sort in C++" --temp 0.0 --colorize --max-tokens 100
Fetching 6 files: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████| 6/6 [00:00<00:00, 98304.00it/s]
==========
Prompt: Write a quick sort in C++

#include <iostream>
using namespace std;
void swap(int &a, int &b)
{
int temp = a;
a = b;

}
int main()
{

int a = 1;

int b = 2;
int c = 3;

int main()

int main()

int

int
int
int

int

int

==========
Prompt: 18.702 tokens-per-sec
Generation: 33.758 tokens-per-sec

@awni  I uploaded wights with that version of transformers is that problem?
mlx-community/starcoder2-3b-4bit

@awni I uploaded wights with pre-release version of transformers is that problem?

Thanks for uploading the weihgts.
It's not a problem at all. The transformer version shouldn't effect the model you uploaded to Hugging Face.

Are you getting similar output as me for the 3B model? It looks like it should be a bit better..maybe the prompt is off?

Are you getting similar output as me for the 3B model? It looks like it should be a bit better..maybe the prompt is off?

Yes got same, since it is base model for code completion and fill in the middle objective seems expected
But tried this
python -m mlx_lm.generate --model mlx-community/starcoder2-3b-4bit --prompt "def print_hello_world():" --temp 0.0 --colorize --max-tokens 100

Fetching 7 files: 100%|████████████████████████████████████████████████████| 7/7 [00:00<00:00, 56461.78it/s]
==========
Prompt: def print_hello_world():

    print("hello world")
def print_hello_hello_world():
    print("hello world")
def print_hello_world():
    print("hello world")
def print_hello_world():
    print("hello world")
def print_hello_world():
    print("hello world")

def print_hello_world():
    print("hello world")
def print_hello_world():
    print("hello world")

def print_hello_
==========
Prompt: 2.273 tokens-per-sec
Generation: 22.712 tokens-per-sec

also qq @awni should we do anything extra for  "hidden_act": "gelu_pytorch_tanh"

fill in the middle objective

What do you mean by that exactly?

should we do anything extra for  "hidden_act": "gelu_pytorch_tanh"

Where did that come up?

What do you mean by that exactly?

Model is trained to predict middle span given the surrounding text, effectively learning to infill text See here: https://arxiv.org/abs/2207.14255

should we do anything extra for  "hidden_act": "gelu_pytorch_tanh"
Where did that come up?

Saw that in config but no act in MLP layers of the model

Model is trained to predict middle span given the surrounding text, effectively learning to infill text

Got it, thanks! So how is one supposed to use it for generation? Are there instruct / fine-tuned variants?

Got it, thanks! So how is one supposed to use it for generation? Are there instruct / fine-tuned variants?

It will follow, only found this public fine-tune of it https://huggingface.co/winstxnhdw/finetune_starcoder2
I was planning to fine-tune via mlx, we can also merge this as is if you want I will double check implementation with authors from HF, this will make it easier for them to check

Model is trained to predict middle span given the surrounding text, effectively learning to infill text

Got it, thanks! So how is one supposed to use it for generation? Are there instruct / fine-tuned variants?

By looking at the tokenizer config, it specifies token to allow the model to fill in the missing code in the middle of the code snippet, something like this <fim_prefix>${textAboveCursor}<fim_suffix>${textBelowCursor}<fim_middle>.

Ok found two more fine-tuned models
https://huggingface.co/m-a-p/OpenCodeInterpreter-SC2-3B
https://huggingface.co/m-a-p/OpenCodeInterpreter-SC2-7B

@awni for fine-tunes is it better to have separate file?
as they have lm_head which base model doesn't have like here
https://huggingface.co/m-a-p/OpenCodeInterpreter-SC2-7B/blob/cf493c6e9ab2b6bbf0e095622a54a8277d0d294f/model.safetensors.index.json#L6
and here
https://huggingface.co/bigcode/starcoder2-15b/blob/d020785eeb4c7e9493938fdafc11c10af30ca020/model.safetensors.index.json#L6

@awni for fine-tunes is it better to have separate file?

They should be the same file because they have the same model_type. However it is a bit unfortunate that they don't have the config relating to the tied embeddings.  We might have to patch that model to set it dynamically if you want to use those fine-tunes (alternatively you could send them a PR to set the config flag properly).

By looking at the tokenizer config, it specifies token to allow the model to fill in the missing code in the middle of the code snippet, something like this prompt = <fim_prefix>${textAboveCursor}<fim_suffix>${textBelowCursor}<fim_middle>.

I'm not sure i follow how you generate just the middle portion.. I guess I should look at the paper for the details.

By looking at the tokenizer config, it specifies token to allow the model to fill in the missing code in the middle of the code snippet, something like this prompt = <fim_prefix>${textAboveCursor}<fim_suffix>${textBelowCursor}<fim_middle>.

I'm not sure i follow how you generate just the middle portion.. I guess I should look at the paper for the details.

Yeah, basically it's just a different way to structure the prompt and allow the model to autocomplete for middle portion. A more practical example is similar to using GitHub Copilot, where the model will fill in the content at the cursor position.

Ok, I'm a little confused as to what to do with this. The model doesn't generate sensible outputs, so is the plan to land it so people can use LoRA / fine-tunes? Or do we need to fix the prompt? Or is there some other thing that I'm missing?

Ok, I'm a little confused as to what to do with this. The model doesn't generate sensible outputs, so is the plan to land it so people can use LoRA / fine-tunes? Or do we need to fix the prompt? Or is there some other thing that I'm missing?

I will do some testing tonight. In terms of fine-tuning, my understanding is that the FIM model is just different in training data prompt format and not different from normal fine-tuning. However, I have not done any FIM fine-tuning so I may be wrong.

I did some quick tests and it looks like there are issues in the mlx implementation. I couldn't figure out exactly where, but when you use the transformers example as shown below, you can see that the model generates correct FIM code. However, this doesn't work in the mlx implementation.
# pip install git+https://github.com/huggingface/transformers.git # TODO: merge PR to main
from transformers import AutoModelForCausalLM, AutoTokenizer

checkpoint = "bigcode/starcoder2-3b"
device = "cuda" # for GPU usage or "cpu" for CPU usage

tokenizer = AutoTokenizer.from_pretrained(checkpoint)

model = AutoModelForCausalLM.from_pretrained(checkpoint).to(device)

tokenizer.eos_token = "<file_sep>"
inputs = tokenizer.encode("<fim_prefix>\ndef quicksort(arr):\n<fim_suffix>\n<fim_middle>\n", return_tensors="pt").to(device)
outputs = model.generate(input_ids=inputs,
    temperature=0,
    max_new_tokens=100,
)
print(tokenizer.decode(outputs[0]))

output:
<fim_prefix>
def quicksort(arr):
<fim_suffix>
<fim_middle>
        if len(arr) <= 1:
                return arr
        else:
                pivot = arr[0]
                less = [i for i in arr[1:] if i <= pivot]
                greater = [i for i in arr[1:] if i > pivot]
                return quicksort(less) + [pivot] + quicksort(greater)

print(quicksort([10, 5, 2, 3]))<file_sep>

However, this doesn't work in the mlx implementation

You tried it with the correct prompt right? Do we add the FIM prompt by default or is that something you have to do manually at the moment?

However, this doesn't work in the mlx implementation

You tried it with the correct prompt right? Do we add the FIM prompt by default or is that something you have to do manually at the moment?

I used python -m mlx_lm.generate --model bigcode/starcoder2-3b --prompt "<fim_prefix>\ndef quicksort(arr):\n<fim_suffix>\n<fim_middle>\n" --temp 0.0  --eos-token "<file_sep>" --ignore-chat-template

Based on @Blaizzy's PR (https://github.com/ml-explore/mlx-examples/pull/518), the instruction prompt failed because it was using traditional Rope. Changing to traditional = False should fix it. However, I have tried his implementation and it still doesn't work with FIM prompt. I suspect there may be something wrong with the Rope implementation or configuration.

Ok just to make sure I understand - the only difference between this PR and #518 is that the RoPE traditional is False?

If that's the case, let's simply update that here? It's a one line change. I think it makes more sense than starting on a separate PR?

Can confirm, seems to work now! Thanks!

Based on @Blaizzy's PR (#518),
Can confirm, seems to work now! Thanks!
Thanks for the addition and contributions everyone!

Most welcome 😊!

Ok just to make sure I understand - the only difference between this PR and #518 is that the RoPE traditional is False?

@awni, there are some minor model args that need to be cleaned up. For example, the use of rms_norm_eps should be changed to norm_epsilon to match Starcoder2's configuration. Also, it would be more efficient to use the repeat header instead of mapping concatenate. I'm not sure if @Blaizzy would like to make a following PR for it; otherwise, I don't mind creating a patch PR to clean it up.

Ok just to make sure I understand - the only difference between this PR and #518 is that the RoPE traditional is False?

Didn't notice the last update on this PR early Saturday.
I'm happy it works now 🚀!

@mzbac I can do that :)

Also, it would be more efficient to use the repeat header instead of mapping concatenate.

Could you elaborate on this?

Also, it would be more efficient to use the repeat header instead of mapping concatenate.

Could you elaborate on this?

Yeah, in the current implementation here https://github.com/ml-explore/mlx-examples/blob/main/llms/mlx_lm/models/starcoder2.py#L71-L76, it would be updated to something like : https://github.com/ml-explore/mlx-examples/blob/main/llms/mlx_lm/models/llama.py#L83-L85.

I see, thanks for clarifying! Will do.
I thought so too because I used the llama's repeat.
If I may ask, why was it done differently?

Yeah, based on the previous PR, simply repeating is faster than concatenating. Just FYI: https://github.com/ml-explore/mlx-examples/pull/443

This feature came at the perfect time for me! 24 hours ago there was no support and now there is. Love open source! 🩶

So I'm trying to fine-tune StarCoder2 using QLoRA.
$ pwd
>>> /.../mlx-examples/llms

When I issue the fine-tuning command, I get an AttributeError:
$ python -m mlx_lm.lora \
    --model mlx-community/starcoder2-3b-4bit \
    --train \
    --data $(realpath ../lora/data) \
    --iters 10

>>> None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
Loading pretrained model
Fetching 7 files: 100%|███████████████████████████████████████████████████████████████████████| 7/7 [00:00<00:00, 61422.86it/s]
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/lora.py", line 246, in <module>
    run(args)
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/lora.py", line 172, in run
    linear_to_lora_layers(model, args.lora_layers)
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/tuner/utils.py", line 27, in linear_to_lora_layers
    if model.model_type in [
       ^^^^^^^^^^^^^^^^
  File "/Users/sameenislam/anaconda3/lib/python3.11/site-packages/mlx/nn/layers/base.py", line 137, in __getattr__
    super(Module, self).__getattr__(key, val)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'super' object has no attribute '__getattr__'. Did you mean: '__setattr__'?

Has anyone encountered this?

So I'm trying to fine-tune StarCoder2 using QLoRA.
$ pwd
>>> /.../mlx-examples/llms

When I issue the fine-tuning command, I get an AttributeError:
$ python -m mlx_lm.lora \
    --model mlx-community/starcoder2-3b-4bit \
    --train \
    --data $(realpath ../lora/data) \
    --iters 10

>>> None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
Loading pretrained model
Fetching 7 files: 100%|███████████████████████████████████████████████████████████████████████| 7/7 [00:00<00:00, 61422.86it/s]
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/lora.py", line 246, in <module>
    run(args)
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/lora.py", line 172, in run
    linear_to_lora_layers(model, args.lora_layers)
  File "/Users/sameenislam/source/sameenislam/mlx-examples/llms/mlx_lm/tuner/utils.py", line 27, in linear_to_lora_layers
    if model.model_type in [
       ^^^^^^^^^^^^^^^^
  File "/Users/sameenislam/anaconda3/lib/python3.11/site-packages/mlx/nn/layers/base.py", line 137, in __getattr__
    super(Module, self).__getattr__(key, val)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'super' object has no attribute '__getattr__'. Did you mean: '__setattr__'?

Has anyone encountered this?
Also including this to show that inference is working:
$ python -m mlx_lm.generate --model mlx-community/starcoder2-3b-4bit --prompt "hello"

>>> None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
Fetching 7 files: 100%|██████████████████████████████████████████████████████████████████████| 7/7 [00:00<00:00, 145347.17it/s]
==========
Prompt: hello
_1(void) {
	printf("hello, world\n");
}

void helloworld_print_double_1(double a) {
	printf("%f\n", a);
}

double helloworld_square_1(double a) {
	return a * a;
}

double helloworld_square_2(double a) {
	return a * a;
}

double helloworld_square_
==========
Prompt: 16.348 tokens-per-sec
Generation: 40.031 tokens-per-sec

There is a missing model_type in the starcoder2. You can try adding it to your local code as shown in this PR.

There is a missing model_type in the starcoder2. You can try adding it to your local code as shown in this PR.

Awesome, I've made the change locally from PR #522 and it's working like a charm!
$ python -m mlx_lm.lora \
    --model $(realpath mlx_model) \
    --train \
    --data $(realpath ../lora/data) \
    --iters 10

>>> None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
Loading pretrained model
Total parameters 602.983M
Trainable parameters 1.212M
Loading datasets
Training
Starting training..., iters: 10
Iter 1: Val loss 2.363, Val took 30.839s
Iter 10: Train loss 2.274, Learning Rate 1.000e-05, It/sec 0.490, Tokens/sec 196.036, Trained Tokens 3999
Saved final adapter weights to adapters.npz.

P.S. $(realpath mlx_model) is the model obtained with:
$ python -m mlx_lm.convert \
    --hf-path bigcode/starcoder2-3b \
    -q


Dye Hair option ask for microphone

Hello DaisukeNagata,
Thank you for share the code. This is pretty amazing.
I have checked that to use hair segmentation, the app ask access for microphone.
Since Apple policy is ask for less permission as possible and justify the permissions asked to user, when I take a picture it ask for microphone. This practice is not allowed by Apple policy, and if I deny the access it does not work.
Please, can you explain a little how to make truedepht camera feature works without asking permission for microphone access? Regards,
Jordi Martin

Hello Jordi
This is the Xcode log when microphone access is not allowed
This app has crashed because it attempted to access privacy-sensitive data without a usage description.  The app's Info.plist must contain an NSMicrophoneUsageDescription key with a string value explaining to the user how the app uses this data.
Thank you

2020/07/20 17:03、Jordi100<EMAIL_ADDRESS>Hello DaisukeNagata,
Thank you for share the code. This is pretty amazing.
I have checked that to use hair segmentation, the app ask access for microphone.
Since Apple policy is ask for less permission as possible and justify the permissions asked to user, when I take a picture it ask for microphone. This practice is not allowed by Apple policy, and if I deny the access it does not work.
Please, can you explain a little how to make truedepht camera feature works without asking permission for microphone access? Regards,
Jordi Martin
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/daisukenagata/MaskingLayer/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5R3TKTFVNPFKNCZ4OIM63R4P23VANCNFSM4PB77KUA.

Hello DaisukeNagata,
Thank you for your answer.
I have run and it do not crashes. My question is why the microphone permission is asked to take a picture? Is it totally necessary?
Regards,
Jordi


generate and upload spork docs?

It would be useful if the spork docs (rendered as html by mendoza) were available on or linked to from the Janet website.
Is there any way I can help?

It would be nice indeed. GitHub pages is a nice way to host docs. While it would be cool to have library docs (like for spork) and Janet-lang.org proper, I suspect it might be too difficult to be worth the effort, both to setup and maintain.

Spork docs are now periodically uploaded to https://janet-lang.org/api/spork/index.html
Much of the prose in the doc directory needs to be moved into janet-lang/janet-lang.org, but API level documentation is auto-generated.


Weekly patch release: 1.7.6 (draft)

What does this PR do?
Preparing for the weekly patch release, 1.7.6. Should go out on Tuesday (13th September 2022).
gh pr list -s merged -S 'merged:2022-09-06T22:00:00.000Z..2022-09-13T22:00:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == "pl:1.7.x") or (.milestone.title == null) or (.milestone.title == "all:next")) | [.url, .mergeCommit.oid, .title] | join(" ")' --limit 100

https://github.com/Lightning-AI/lightning/pull/14603 b0683b4eaeb5c630ad6cd57a4ea05bcbb59688f6 Use the `pull_request_target` workflow event
https://github.com/Lightning-AI/lightning/pull/14576 4d082e4dac7fec388bdc49578f1d50ae72e498fb Update fastapi requirement from <=0.79.0 to <0.83.0 in /requirements
https://github.com/Lightning-AI/lightning/pull/14582 6cf666c6f16f5ffe550efbca79e3e7f96a086a2d Update neptune-client requirement from <0.16.4,>=0.10.0 to >=0.10.0,<0.16.8 in /requirements
https://github.com/Lightning-AI/lightning/pull/14454 31dc6c67142ad1c1e4fa192cad320a99114dc4c1 Add compatibility when `torch.distributed` is not available
https://github.com/Lightning-AI/lightning/pull/14543 46519e2fc770f3393c7f5e72e6f36a01a15efb27 Add path filters to the TPU job
https://github.com/Lightning-AI/lightning/pull/14505 6de2b0b5284eb3c27583e4d8dc9017675a023b28 Docs [Fix]: use bytes instead of strings while writing
https://github.com/Lightning-AI/lightning/pull/14288 dbd7703e88c39421d740c010cac7f0bb23981c12 Update fsspec[http] requirement from !=2021.06.0,<2022.6.0,>=2021.05.0 to >=2021.05.0,!=2021.06.0,<2022.8.0 in /requirements

PR carried over, wasn't released in 1.7.4 and forgotten in 1.7.5: https://github.com/Lightning-AI/lightning/pull/14372
gh pr list -s merged -S 'merged:2022-06-09T22:00:00.000Z..2022-09-13T22:00:00.000Z' --json author,milestone --jq '.[] | select((.milestone.title == "pl:1.7.x") or (.milestone.title == null) or (.milestone.title == "all:next")) | ["@" + .author.login] | join("")' --limit 100 | sort --ignore-case | uniq | xargs echo

@akihironitta @Borda @carmocca @dependabot @j0rd1smit @justusschock @krshrimali @manskx @otaj @pierocor @rohitgr7

Does your PR introduce any breaking changes? If yes, please list them.
Nopes!
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

I'm looking to get these in:
https://github.com/Lightning-AI/lightning/pull/14599
https://github.com/Lightning-AI/lightning/pull/14637


Fix jobs' $selection_pattern

When $selection_pattern is set, we expect a new "Selection Pattern" entry to be emitted, not a "Selection Type" entry.

I encountered some unexpected failure on Travis-CI… Added a commit to workaround this issue, but it looks like some more love to the (Dir|Fd|Sd)Addresses would be welcome to allow setting multiple addresses or not specify the setting at all.
Currently, it is not possible to not have a (Dir|Fd|Sd)Addresses produced because the optional value defaults to $facts['ipaddress'].  Not sure if it is worth opening an issue though…

Good changes, thank you for the PR.  Not sure why the addresses started failing, but the template clean up here looks good to me.


2.1.0/1.19.2/surtrum

Adds Surtrum, the gravitite replacement.
Surtrum meteors/comets/? can be found occasionally around the world, and must be cracked with tnt, or a diamond level tool. Inside raw surtrum can be harvested, which is refined using buckets of lava into tools and armor.

Approved, but please address comments


Added functionality to contact form

Issue #476
\Added functionality to contact form. The form now accept response, displays confirmation message and reset the forms after displaying the message which is a good practice.
@varshith257 ma'am please have a look. Also please add gssoc and level label. Please add my name in assignes as well.
thank you

Thankyou for your contribution!
if possible please make footer better

@Anishkagupta04 ma'am please add gssoc and level label and my name under assignes
and surely i will try to make footer better


The content pipeline is failing with FontDescriptionProcessor

I've just cloned the demo, and when building I'm having a lot of
Processor 'FontDescriptionProcessor' had unexpected failure!
on every spritefont.
Also Could not find file 'D:/gamedev/GeonBit.Demos/SkinnedMesh/Content/game/mech/Mech5.obj'.

I was missing the bitstream fonts
I edited the spritefonts to use Arial and now works

Thank you for the report.
I think I'll reopen this ticket as a reminder for myself to build the spritefonts upfront and add the compiled files to the demo, since most people won't have them installed.
Thanks!


Performance slowdown in SassCompiler when switching from npm 2 to npm 3 on Windows

I gave node v4 and npm v3.3.9 a go for the first time today (had previously been using v0.12.7 and 2.11.x), my rebuild times (on windows 7) have near tripled to 48s from 20s. Rebuild output is below.
Build successful - 48766ms.

Slowest Trees                                 | Total
----------------------------------------------+---------------------
SassCompiler                                  | 17852ms
BroccoliMergeTrees                            | 4836ms
TreeMerger (vendor)                           | 4362ms
Funnel: App JS Files                          | 3636ms
ES6: App Tree                                 | 2544ms

Slowest Trees (cumulative)                    | Total (avg)
----------------------------------------------+---------------------
SassCompiler (1)                              | 17852ms
BroccoliMergeTrees (4)                        | 5059ms (1264 ms)
TreeMerger (vendor) (1)                       | 4362ms
Funnel: App JS Files (1)                      | 3636ms
ES6: App Tree (1)                             | 2544ms

Previously I was seeing a rebuild more like this with npm2:
Build successful - 20183ms.

Slowest Trees                                 | Total
----------------------------------------------+-------------------
Funnel: App JS Files                          | 2506ms
ES6: App Tree                                 | 2110ms
TreeMerger (vendor)                           | 1949ms
BroccoliMergeTrees                            | 1612ms
ConcatWithMaps                                | 1610ms
SassCompiler                                  | 1326ms

Slowest Trees (cumulative)                    | Total (avg)
----------------------------------------------+-------------------
Funnel: App JS Files (1)                      | 2506ms
ES6: App Tree (1)                             | 2110ms
ConcatWithMaps (4)                            | 2087ms (521 ms)
TreeMerger (vendor) (1)                       | 1949ms
BroccoliMergeTrees (4)                        | 1782ms (445 ms)
TreeMerger (lint) (2)                         | 1341ms (670 ms)
SassCompiler (1)                              | 1326ms
Babel (8)                                     | 1087ms (135 ms)

So the biggest offender appears to be the sass compiler.
I posted an example app for a different issue but this shows our sass layout and dependencies etc: https://github.com/adam-knights/order-example-oct-2015
ember-cli-sass 5.0.0, ember cli 1.13.8
I'm assuming this is a ember-cli-sass issue, but can post against ember-cli if thats the offender here.

Also tried ember cli from it's master branch, still similarly slow sasscompiler:
Build successful - 74514ms.

Slowest Trees                                 | Total
----------------------------------------------+---------------------
SassCompiler                                  | 23309ms
TreeMerger (appAndDependencies)               | 4690ms
TreeMerger (vendor)                           | 4470ms
TreeMerger (appJS  & processedEmberCLITree)   | 4440ms
Addon#treeFor (Ember CLI ic-ajax - vendor)    | 3822ms

Slowest Trees (cumulative)                    | Total (avg)
----------------------------------------------+---------------------
SassCompiler (1)                              | 23309ms
Babel (12)                                    | 12088ms (1007 ms)
TreeMerger (appAndDependencies) (1)           | 4690ms
TreeMerger (vendor) (1)                       | 4470ms
TreeMerger (appJS  & processedEmberCLI... (1) | 4440ms
Addon#treeFor (Ember CLI ic-ajax - ven... (1) | 3822ms

To confirm, leaving node at 0.12.7 but increasing npm to  v3.3.9 shows the issue is caused by npm from v2 to v3.

Hmmn, that is very strange. Are you doing a clean install when you change versions of npm and node (by deleting node_modules/)?

this is because ember-cli-sass and friends are somewhat overoptimistic in what paths they watch, as npm v3 dedupes, its more likely all of node_modules gets watched by mistake.
Long term, better utilization of watchman will prevent this (I'm waiting on them finishing some stuff for us, and for us to more fully embrace the fs-tree-diff stuff). Short term, removing all the input-watch paths (maybe opt-in) would improve this.
^^ is likely something we will want to pursue from ember-cli side, but its all quite intertwined.

Yes, in trying each combo I always ran rmdir /s /q node_modules bower_components dist tmp and then did new npm install/bower install's.

Update broccoli-sass-source-maps to disable caching as in tsing80/broccoli-sass-source-maps@a066c9ad50345c8114fe6b9a6049cafcca2c648f have big boost for me, not sure if it work for others though

Yup it likely would. Since the way to derive the cache key is currently must check for changes literally everywhere.

I believe the issue was, some addon,s like ember-cli-ic-ajax, accidentally inluded large chunks of node_modules (all of them) by mistake due to v3 deduping.
If the problem arises again, please provide a reproduction and i will glady dig into it and address.

I tried node 4 and npm 3 again with latest Ember CLI and rebuild times are now the best we've ever had, ~3s with no SSD.


Misleading wording on the configuration page

On the module's configuration page one can see this:

It reads "Customer's Country". The actual meaning is probably more like "Always add VAT for customers from:"
Also, the topmost menu entry (not visible in the screenshot) shouldn't read -- Choose a country --, but -- none --. It's perfectly fine to have no such country selected.
Third, the help text could be a bit more verbose.

Should be fixed with https://github.com/thirtybees/vatnumber/commit/db44528680603d14f53333932d37794d272ef7ed.


Feature/emergency and service banners

What
Make emergency and service banner appear on new search.; add health check for Zebedee.
How to review
Must have homepage content locally with a service message and emergency banner information. Banner and service message are currently not using the new design system so banner will appear white.
Who can review
Anyone

It might be worth us going through together the component test setup; just to tidy up how the component and external dependencies are setup

It might be worth us going through together the component test setup; just to tidy up how the component and external dependencies are setup

With regards to the component test, a few things were done of the following:
Removing Reset and BeforeScenario function

For each scenario in the test, a new controller component is created with its respective APIFeature. A fakeAPIRouter is also created within the controller component
The newly created controller component, APIFeature, and fakeAPIRouter are reset (empty) by default when they are created. Therefore, there is no need to call a Reset function for these features in the BeforeScenario function. Therefore, the Reset and BeforeScenario were removed
When the Scenario ends, it is important to close the controller component and fakeAPIRouter (essentially closing their server) otherwise these will be still running in the background. This is why the AfterScenario function is important

Increasing the HealthCheckCriticalTimeout

Whilst running the component tests 30 times consecutively, I noticed that there were issues with timings. At the time, within the component test, the HealthCheckInterval was set to 1s and the HealthCheckCriticalTimeout was set to 2s.  - In the scenario Returning a WARNING (429) status when one downstream service is critical and critical timeout has not expired, even though the test passes with this configuration most of the time, in some cases, the test failed as the test returned a 500 status code.
This is because in that particular case, the /health was called by the service after the HealthCheckCriticalTimeout even though we have specifically told it to call before. This was a strange one to solve but I then realized that the HealthCheckInterval and HealthCheckCriticalTimeout were close to each other (1s difference) in which the performance of the component running can allow for a change in result, especially with a close time range (1s difference).
As a result, I increased the HealthCheckCriticalTimeout to 3s which gave more room to avoid this issue, and ran the component test 30 times to which this passed.

Removing check for LastSuccess for healthcheck fails and LastFailure for healthcheck passes

Whilst running the component tests 30 times consecutively, we also experienced some test failures with the error invalid memory address or nil pointer dereference on some infrequent occasions. To be exact, out of the 4 scenarios which were run 30 times (120 scenarios run in total), this error only occurred in 2 out of the 120.
This specifically occurred in scenarios where the health does not return a 200.
When investigating those specific occasions, the pointer LastSuccess was nil when the healthcheck fails, even though we were expecting a specific date-time at this instance
For context, when the service runs, it calls /health to the downstream apps (just API router in our case) and it does this repeatedly on each HealthCheckInterval. We have set the component test to return 200 for this when the service begins initially and then this is changed accordingly for each scenario. Most of the time, some /health calls are made to the fakeAPIRouter before the scenario gets to run (this happens because the service is run and then the scenarios are called). During that time, the LastSuccess is populated with a date-time.
But as discovered, in some rare instances, the LastSuccess was nil and this occurred because, in that instance, the first /health call was made during the scenario rather than before the scenario is run. To be more specific, as we tell the fakeAPIRouter to return a non-200 in the scenario - when the first /health happens during the scenario, the LastSuccess cannot be populated as there was no previous success health in the first place.
To overcome this, we can add a delay after the service runs in the component to ensure that /health calls are made before the scenario is run. But this slows the component test even more for a check which isn't significant.
Therefore, the check of LastSuccess in failed healthcheck scenarios was removed. For consistency, the check of LastFailure was also removed for 200 health scenario. This means that we just check if the LastFailure is populated for a failure and LastSuccess is populated for a success - straightforward and simple

Adding mutex.Lock and Unlock for healthRequest

When running the component test, there was a data race issue. This data race occurred because we were writing and reading the healthRequest of the fakeAPIRouter at the same time. To be more specific, we were writing when changing the status code return of the healthRequest (/health) of the fakeAPIRouter for each scenario in the test. We were reading when the (/health) calls were made from the service (at each HealthCheckInterval).
To overcome this, mutex.Lock and mutex.Unlock were added when changes were made to the healthRequest (/health) of the fakeAPIRouter which resolved this issue

I can confirm that I re-ran the component tests 30 times consecutively and no errors came up as the issues were resolved as mentioned above


Batch Subscriber update still trying to use request over axios?

UpdateBatchSubscribers still looks like it's trying to use request over axios, and throwing an error about malformed URLs:
UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_URL]: Invalid URL: [object Object]

Given the other ways the drip API is called, it seems like changing to something like this might be enough, but I'm not sure if I'm missing something
 this.post(
        `${helpers.baseUrl}v2/${this.accountId}/subscribers/batches`,
        this.generateResource('batches', { subscribers: batch }),
        (error, response, body) => {


Minor proposal (line 99)

🚀 Pull Request
Description

Minor proposal (or small fix) on documentation in line 99

Consult Iris pull request check list

@kant Thanks for taking the time to submit this PR, much appreciated.
Just need you to sign the CLA, and we're good to go 👍

Closing this PR, as it's gone stale after six months.
Replaced by #4490


🐛 Splash on linux

Describe the bug
Splash on linux
To Reproduce

cd example
flutter create .
flutter run -d linux

Screenshots

Do you have any window features on?

Do you have any window features on?

all default
ubuntu 22.04


QR hangup during Windows build

First off, I really appreciate the work that you have put into this project; I found it by recommendation through Augmentor.jl and Images.jl while developing my package documentation.
When developing on Windows, I have an odd bug that I cannot seem to get around that may or may not be caused by DemoCards.jl. When building my documentation locally for development, I get the following error:

Further digging revealed that a process called qksqt.exe, which I assume to be associated with QR, is holding onto the folder, making me have to kill the process before I can manually delete the docs/src/examples/ folder that is autogenerated by DemoCards.jl before successfully rerunning. None of this occurs in my GitHub actions CI, however, just locally on both of my Windows machines.
Have I run into some common issue that I am ignorant of the workaround for, or do you otherwise know what might be the problem?

Have you tried to use some folder other than Julia's default dev folder? For instance, D:\Julia\AdaptiveResonance?

Good recommendation! I tried it on another folder and drive with no issue. It also seemed to end up being a transient issue; I removed the original problem folder that the system would hang on, re-added each file one at a time, and now can't reproduce my issue on the original location.
Thanks for your time. I'll close this issue for now.


Staging to Master

Everything is working with updated changes from staging, approved to merge with master

Another change from staging was made. Canceling this PR.


ModuleNotFoundError: No module named 'libs.knn.knn_pytorch._knn_pytorch'

D:\Users\xsf\PycharmProjects\6-PACK-master\libs\transformations.py:1912: UserWarning: failed to import module transformations
warnings.warn('failed to import module %s' % name)
Traceback (most recent call last):
File "D:/Users/xsf/PycharmProjects/6-PACK-master/train.py", line 18, in
from libs.loss import Loss
File "D:\Users\xsf\PycharmProjects\6-PACK-master\libs\loss.py", line 11, in
from libs.knn.init import KNearestNeighbor
File "D:\Users\xsf\PycharmProjects\6-PACK-master\libs\knn_init.py", line 7, in
from libs.knn import knn_pytorch as knn_pytorch
File "D:\Users\xsf\PycharmProjects\6-PACK-master\libs\knn\knn_pytorch_init_.py", line 3, in
from ._knn_pytorch import lib as _lib, ffi as _ffi
ModuleNotFoundError: No module named 'libs.knn.knn_pytorch._knn_pytorch'
Process finished with exit code 1

This is problem in windows.It  disappears in linux.


PubSub

A basic PubSub communication has been implemented but the way for it to read and write in the address space is hacky and should be disciplined before merging.
Things to do before merging this PR:

[ ] Make the PubSub entities use a configurable address space
[ ] Mirror in some way the PubSub entities in the server informational model
[ ] Allow server methods to act on the informational model to read/write the PubSub state

 Implement PubSub support (server)


HMR not working in windows

same issue with #2 , need to replace the path separator \ with /

fixed


Issue 329: Add new docs theme

Pull Request Template
Description
Changed the documentation theme to Just the Docs
Fixes #329 and #211
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Followed instructions for building and testing docs locally.  Previewed docs and clicked on links.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings
[x] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

This should be a purely cosmetic change to the pages.  No URLs should change or break.

@joewxboy @johnwalicki I am testing this PR locally but I am getting some errors while running the make init command, that says :

I will soon share a detailed review regarding the same, with the solution I tried, I already tried the suggested commands but it is not working.


Decorator issue with keyword arguments fixed

Reference Issues/PRs
What does this implement/fix? Explain your changes.

The #17 issue regarding the Decorator issue with keyword arguments is fixed.

Any other comments?

Not working (this time due to different issue):
>>> from nava import play
>>> play('/home/sadra/Music/test.wav')
Traceback (most recent call last):
  File "/home/sadra/local/nava/nava/functions.py", line 136, in play
    __play_linux(sound_path)
  File "/home/sadra/local/nava/nava/functions.py", line 43, in quoter
    return func(sound_path, *args, **kwargs)
TypeError: __play_linux() takes 1 positional argument but 2 were given

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/sadra/local/nava/nava/functions.py", line 116, in path_checker
    return func(sound_path, *args, **kwargs)
  File "/home/sadra/local/nava/nava/functions.py", line 138, in play
    raise NavaBaseError(SOUND_FILE_PLAY_ERROR)
nava.errors.NavaBaseError: Sound can not play due to some issues.

@sadrasabouri
It is fixed now.


Inconsistency between flashfetch and fastfetch

By default, using the 2.1.2 release, flashfetch includes my zram swap information, Swap: 0 B / 7.52 GiB (0%), whereas fastfetch does not include this information.

Completed.


[Operations]: Stable database at a crawl

Summary
The RDS database backing the cumulus api and website slowed to a crawl on evening of Thursday, August 25th, 2022.
Resolution
The database instance type was increased from db.t3.small --> db.t4g.medium. Api, website, database are snappy again. Some intensive database maintenance may have led to the CPU credits on the burstable class RDS instance (db.t* class) running to 0.
We should monitor credits occasionally over the next 2 months to make sure increased demand on database is not burning credits faster than they are earned.
Additionally, database backups were enabled every day at 07:15-07:45 UTC (very early morning hours) as part of changes that were applied. Daily backups are stored for 7 days.

Resolved Evening of Thursday, August 25th, 2022