Problem that bios is in exe format

System
Alienware a51 R4 pc

Motherboard: ms-7a87

BIOS Version: 2.0.7

GPU: 3090

Hey. Hope you are doing great. I wanted to follow your steps to activate rebar. but I was surprised that dell bios is .exe and not .bin
How can we fix it?
This is the bios link
https://dl.dell.com/FOLDER08945518M/1/Alienware_Area_51_R4_2.0.7.exe

On most prebuilts usually the only way to flash is through use of a hardware flasher like CH341A
@Electron-PSO might know more about this

Could be talk on discord? whats your username

Hello @mojarrah
You can extract the .rom file from the EXE file by using the /writeromfile switch at the command line
Alienware_Area_51_R4_2.0.7.exe /writeromfile
Once you have the file, you should be able to use the AMI AFUWin64 v3.05.04 with GAN support  to flash it.
As xCuri0 said, make backups first though
AFUWINx64.EXE /O      to save current ROM image to file

@Electron-PSO Got it, but could we discuss it on Discord now? whats your username? mine uchihamj

@Electron-PSO here or there, Use what's best for you. The problem is that any version of the bios I can't even open the exe file normally when clicking it in windows 11. Any version of the bios. It gives an error unable to load driver!!! Can you try please to extract it on your side and upload it. That would be l insanely helpful!!!

Hello @mojarrah,
Here is the rom file extracted from the 2.0.7 exe you posted
alienware_area_51_r4_2.0.7.rom.zip
Did you use the command line when you tried to extract it?  Like this?

Hello @Electron-PSO
Can confirm the ROM is working. Thanks
Moreover, I have written the same command but didn't work on the machine. It is Windows 11. Maybe it needs to be on Windows 10 to be extracted
Plus, can you please now in the form of steps, tell me exactly what I should do now(anything other than the rebar steps since they are on the site) and if you name any program send its link please

Hello @mojarrah ,
After you have the ReBAR modified file, you'll need something like AMI AFUWin64 v3.05.04 with GAN support to flash it.
See this guide for instructions.  I'm not sure about Win11, but I have managed to get Dell Alienware machines to flash in windows before.
https://winraid.level1techs.com/t/guide-how-to-flash-a-modded-ami-uefi-bios/30627

@Electron-PSO Downloaded the correct AMI version now
Can you mod the rom file with the uefirebar and upload it, please? since it is different from what other people have shown

Hello @mojarrah ,
It shouldn't be that different.
Search for the DXE section and insert the ReBar ffs at the end of it?

@Electron-PSO Look what it is giving me

@Electron-PSO But it is giving this error when trying to flash

P.S    I'm at work, so it is difficult for me to respond quickly.

@Electron-PSO downloaded windows 10. Now. The problem was from windows 11
But when flashing, it gives an error
Rom file size doesn't match the bios file and that true
Rom file 16mb
.exe around 8mb

Can you read the BIOS chip with the /O  option?

AFUWINx64.EXE /O to save current ROM image to file

@Electron-PSO
It is showing this when writing the command

You need to specify the file name you want to make
AFUWINx64.EXE backup.rom /O

Did and it said it's done. I restarted then used rebar program to to put 32 value. It said it did success. Restarted again but it still shows as disabled in gpuz

@Electron-PSO look

Make sure you have updated vbios on 3090
NVIDIA put out an update for it that's required for resizable bar to work

@Electron-PSO @xCuri0
vbios and everything updated

Literary the only option saying no in gpu z about rebar is: enabled in bios: no

@xCuri0 what do you think?

@Electron-PSO I used /O command again to check if the bios really flashed. And put it in uefi tool. And it's still the same. It didn't flash the modded bios

Did you run  ReBarState.exe  to set the BAR size?

@Electron-PSO Yes

@Electron-PSO also,
I used /O command again to check if the bios really flashed. And then I did put it in uefi tool. And the result were the bios didn't change. It didn't apply the modded bios. it's still the same. It didn't flash the modded bios

@Electron-PSO Is there a way to force it 100% to flash?

Maybe you need to set service jumper or something for it to flash
But best and safest method for flashing prebuilts is using a hardware
flasher like Ch341a
On Tue, Dec 12, 2023, 3:50 PM Mohammad Jarrah @.***>
wrote:

@Electron-PSO https://github.com/Electron-PSO Is there a way to force
it 100% to flash?
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1851745897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVLXLLEY5Q52FTQXP5DYJAVWFAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRG42DKOBZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xCuri0 Damn, I don't have a hardware flasher currently. Is their another way/software I can try

Would ReBarState be happy if the flash hadn't worked?

Didn't get what you mean @Electron-PSO

Did you use the /GAN command to flash the BIOS file?
It might not be needed, but worth a try.
AFUWINx64.exe modified.rom /GAN

Yes

If ReBarState couldn't set the variable it should error?
Try setting it to 1GB bar size
Then reboot
Then check with CPU-Z

Tried but didn't work also!!

OK
Ignore that last post
I see it does create and is happy with the variable on systems without the BIOS mod

So ReBarState shows it is set to some GB?

I set it to 10, which is 1gb(as far as I now) and it says successful. But still says disabled after reboot

Would ReBarState be happy if the flash hadn't worked?

Yes all it does is write a UEFI variable

So what to do?

I'm still finding it hard to believe the flash program can erase, program and verify without it actually doing it.
Not sure what to do now.
You could try a different flashing program or you could just do it the physical way.
If I had the board on my desk I would do this:

Unsolder the chip
Put it in a programmer
Read and save the current file
Erase the chip
Program it with the new file
Resolder it

But that depends on your ability to do the job.

@Electron-PSO
Do you recommend another flashing program? What is it?
Also, is their somehow a bios settings that is activated that didn't allow it to be flashed
Btw, when it flashed it didn't reboot by itself like I would expect it to happen, it just closed the cmd pop up. I rebooted manually

For some Dell machines, I have used a Windows GUI version of the AMI flash tool

I'll have a look for it

Here is the official link to the AMI flash utilities
https://www.ami.com/bios-uefi-utilities/
There are Win GUI versions in the zip folders
x64

There are multiple links for download
Drop the link for the exact one I should use

@Electron-PSO got it now and opened successfully The correct version
Moreover, what settings I should check to make it work 100%

@xCuri0 I flashed it successfully now using fpt win32 version as winpad site suggests. The problem now is if I activate the rebar and reboot screen no longer work. The system boot but their is no screen. I have to reset the bios using the battery to get it working. What is the solution?

Apologies for the delay,
I was travveling home and had some sleep.
It should be the Aptio V version

Try a small BAR size first
1GB

Then check in GPU-Z

What number to put in rebar to equal 1gb? @xCuri0 @Electron-PSO

It is 2^x        so for 1GB  set it to 10

@Electron-PSO it worked!!!!
Now I can set it to the maximum of what my gpu can handle
It's a 3090 24gb vram

You'll need 15  as the bar size to give you 32GB.  That will be enough to fit the 24GB VRAM

What's the best value?

Which Intel FPT did you use?
Have a link to it also?
I'm helping someone with a system and they have flashing issues too

Will send the link after the pc boot from pc bios reset
Moreover, it isn't working with anything above 1 or 2gb
@xCuri0
Tried multiple values, all of them led to failure!! What should I do?

Did you apply the patches via UEFI Patch tool ?
https://github.com/xCuri0/ReBarUEFI/wiki/Using-UEFIPatch

I've just applied the parches to the extracted rom file.
Two patches are applied
These would prevent you from using a 32GB BAR size
PciBus | Don't downgrade 64-bit BARs to 32-bit (Haswell)
3C1DE39F-D207-408A-AACC-731CFB7F1DD7 10 P:833E067506C70604000000833E077506C70605000000:66906690669066906690669066906690669066906690
PciBus | Remove <64GB BAR size limit (Skylake/Kaby Lake/Coffee Lake)
3C1DE39F-D207-408A-AACC-731CFB7F1DD7 10 P:B800000000100000004C3B:B8FFFFFFFFFFFFFF004C3B

Good, how to make sure the pad isn't corrupted? I couldn't figure it out

Also, should I remove the .patched extension before flashing or what?

@Electron-PSO ?

@xCuri0

@Electron-PSO I am also thinking to reflash the bios using the x64 version of ftp. What do you think? Is there a difference?

If the 32 bit version worked, keep using it
Steps to take:

Make ROM file from EXE
Add ReBarDxe.ffs at end of DXE section
Apply Patches

you'll get BIOS.ROM then BIOS_ReBAR.ROM  then BIOS_ReBAR_Patched.ROM
I like to keep the .ROM extension and only one   .    in the filename

Alright, so when the yeti patch give me bios.rom.patched
I remove the .patched extension?

@Electron-PSO @xCuri0 tried it now. It applied two patches by it self when I written the code. I flashed the bios. Put a value of 13 which is 8gb. When it rebooted. It started beeping and I had to flash the bios again!!!!

You have to enable 4G decoding and disable csm
On Wed, Dec 13, 2023, 3:18 PM Mohammad Jarrah @.***>
wrote:

@Electron-PSO https://github.com/Electron-PSO @xCuri0
https://github.com/xCuri0 tried it now. It applied two patches by it
self when I written the code. I flashed the bios. Put a value of 13 which
is 8gb. When it rebooted. It started beeping and I had to flash the bios
again!!!!
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1853588203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVKF6LCK3RNHRWYNTJTYJF2WNAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGU4DQMRQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xCuri0
Csm is disabled and 4g decoding enabled
Also, I have a skylake processor. And I flashed the bios with win32 version of the tool
And I didn't change anything in patches.txt, I just applied the code as is

@xCuri0 so what do you think?

This is what It shows when I use uefipatch with this code:
.\uefipatch .\rebar.bin

@xCuri0 @Electron-PSO  adding to the above
Why there are 3 bars showing in gpuz
BAR0
BAR1
BAR2

It is like this on Nvidia cards
BAR1 is the VRAM
BAR0 are Registers
BAR2 is something else
🤣

So, even with the patches you can't use BAR greater than 2GB?

Yes, I applied the patches but it still won't boot after using big value. Tried 4, 8, 32 nothing worked

Also, right now, I tried 11. Which means 2gb and it is also not working
Only 1gb working!!!!
What is going on?!!!
@Electron-PSO @xCuri0

@xCuri0  @Electron-PSO
This is the raw working bios
backup2.zip

That file is only 12MB
It should be 16MB for a full chip

Have you got the file you want to flash into the chip?

This is the file I read from the chip. And it's the raw version
It's 12mb
The one we get from .exe gives error if you remember from the first time we tried

The 16MB file from the exe extraction gives an error?

@Electron-PSO what do you think I should Do?

@Electron-PSO That what it gives when I try to flash it using fpt

@Electron-PSO The 16mb one I mean

Have you flashed the board with the latest BIOS using the normal update tool?

So it looks like the 12MB file you read out is the option to use.
Update to the latest bios version and then read out the file.
Perform the mods
Flash mod file.
Reboot

I think the 16MB file we got from the EXE is 12MB with some padding at the end

Yes, I did all of this process on the latest bios version already.
Moreover, I have no problem in downgrading. And I have an older bios version .exe file. But how can extract the 12mb Rom from it?

You could just flash the older version then read out the "Bios" part with FMT.

This Dell stuff   geeez
If x299 boards were not so expensive, I would recommend just replacing the board with an ASUS alternative.

It doesn't allow me to downgrade to older version when using the .exe

How to get the 12mb version from the exe?

@Electron-PSO @xCuri0
I literally returned to version 1 of the bios which is the oldest version
It booted successfully. Did rebar of value 11 to try. But it did beep like before and the system didn't start!!!!!!!

What should I do!!!!

@mojarrah maybe dell has some other bios setting that needs to be enabled for 4g decoding to work fully
and u could try connecting monitor to igpu, sometimes u need to do that when using rebar on skylake and the gpu will output when windows loads

@xCuri0 I have a dell a51 r4. Someone on Dell forms who has r2 but basically literally like the same bios. He was able to modify the bios and unhide the pci settings menu
How can I do it?

@mojarrah did you already say you enabled 4g decoding ?
there is a whole page for this, https://github.com/xCuri0/ReBarUEFI/wiki/Enabling-hidden-4G-decoding worked for several dell users

@xCuri0 Hey

@xCuri0 Gpu z was showing that above 4g is enabled while it actually was disabled
I unhide the bios menus to enable it
Is there something in these menus I should do before trying?

@xCuri0

@mojarrah there is nothing to do besides enabling 4g decoding, disabling csm and enabling rebarstate
also it's mentioned in multiple places that gpu-z in inaccurate and that almost no oems enable 4g decode by default idk why you thought it would be

@xCuri0 I tried value of 15 while above 4g is enabled and it started beeping!!

@mojarrah there are several things in the common issues wiki page you can try relating to skylake/kabylake systems (lga1151). i know you have x299 but it's probably similar

also some systems beep but eventually display output once windows loads

@xCuri0 Got it, btw I don't have igpu. Only the 3090. And it's connected using a display port to the screen

@xCuri0 I waited for it now. Didn't boot. Kept beeping
I tried also hdmi instead of the display port
Still not working
Btw, I have 64gb of rams. So I don't know if that may cause a problem

@xCuri0
Just to make sure, 100000%
After this selection, I insert the pfs of rebar, right?

Doing this again won't solve the issue you have, the rebar module clearly
is working fine without any issues
The only thing that might be causing it is not having applied Uefipatch but
iirc you did
On Thu, Dec 14, 2023, 11:29 PM Mohammad Jarrah @.***>
wrote:

@xCuri0 https://github.com/xCuri0
Just to make sure, 100000%
After this selection, I insert the pfs of rebar, right?
A7600E73-A7C2-40D6-AD5A-5A66D4B2C71B.png (view on web)
https://github.com/xCuri0/ReBarUEFI/assets/111957484/42c1570c-fbad-4a45-be89-c93bfd417190
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1856333357,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVMOTPZAIUQF6ZE77I3YJM5BLAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGMZTGMZVG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

This is what it showes when I apply the patch
Didn't change any single thing in patches.txt
Just typed the command and it did this
So is it correct
Moreover, when I flash the patched version…Should I remove the .patched extension and so it becomes xxx.bin

@mojarrah

Should I remove the .patched extension and so it becomes xxx.bin

Yes, idk if it's required for FPT tho but using BIOS menus to flash like on my Gigabyte board it is

Also, is it correct how I applied the patch?

Yes
On Thu, Dec 14, 2023, 11:47 PM Mohammad Jarrah @.***>
wrote:

Also, is it correct how I applied the patch?
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1856356999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVOPZAU24FGSMKQVQPDYJM7CTAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGM2TMOJZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Damnnnn!!!! So what is the problem?!!
I did every single step required

I don't really know anything more you can try if 4G decoding is really
enabled.
You can read the GitHub wiki pages for this project, one of them tells how
to modify hidden settings using setup_var. Maybe some other setting is
required to be set on Dell but only you could figure it out.
I remember some Dell Ivy Bridge system needed a custom uefipatch made but I
was only able to do it because of how similar to it was to other Ivy Bridge
motherboards
On Thu, Dec 14, 2023, 11:50 PM Mohammad Jarrah @.***>
wrote:

Damnnnn!!!! So what is the problem?!!
I did every single step required
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1856361911,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVJUDUBYJ4FTNJ45GRTYJM7QRAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGM3DCOJRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Alright, is their any other way I could check that 4g is 100% really enabled?

@mojarrah if it says enabled in the BIOS menu then it is.
Maybe Dell has some additional setting needed to be enabled only you could figure that our

Btw it gives 3 beeps
Then 3 beeps
Then 3 beeps
And so on

@xCuri0 the funny thing this that now, even 1gb makes it not boot

@xCuri0 btw I haven't applied dsdt patching. Is it required?

@xCuri0 realized something now, when enabling 4g decoding either in unhiding menu in bios or through setup var. Rebar doesn't work at all
Even 1gb doesn't work
Without enabling above 4g. I can do 1gb but nothing above
Why!!!!

I see you have 64GB of RAM
I think 3 beeps is RAM issue?
Do you have 8 sticks of ram?
If so, remove 4 (the correct4)

I have 4 slots @Electron-PSO

@Electron-PSO @xCuri0
Btw, when I searched in uefitool
Both “64 bit resource allocation” and “4g decod” appear when searching for them
And one has 0xF97 value
And one has 0x403 value

Can you tke out some sticks and try again?
There are some reports of more than 32GB being a problem.
If it is that, then all of this is for nothing until it can be resolved.

I take it you have 16GB DIMMS.
Try just using one stick
With the 3 beeps when it fails to boot, it might be a memory error.
At this point, I'm just throwing ideas about
🤖

@xCuri0 @Electron-PSO
I removed 3 of the 4
Nothing changed, still beeps
Moreover, now, I searched using uefi editor in the bios for menus related to the thing
I found another thing related to 4g. It's called above 4g mmio bios assignment
Does it have a role?

@xCuri0 @Electron-PSO
I removed 3 of the 4
Nothing changed, still beeps
Moreover, now, I searched using uefi editor in the bios for menus related to the thing
I found another thing related to 4g. It's called above 4g mmio bios assignment
Does it have a role?

Yes enable that too

Can you tke out some sticks and try again?
There are some reports of more than 32GB being a problem.
If it is that, then all of this is for nothing until it can be resolved.

I think X299 shouldn't have any issues like this

issues

Yes It doesn't any of these ram issues. I took 3 of the ram sticks. And still beeped.
I will try your last 3 advices and update you asap

@xCuri0
I also found this setting in uefi editor, should I enable it?

No unless you have some issue with the USB 3 ports
On Fri, Dec 15, 2023, 2:29 PM Mohammad Jarrah @.***>
wrote:

@xCuri0 https://github.com/xCuri0
I also found this setting in uefi editor, should I enable it?
image.png (view on web)
https://github.com/xCuri0/ReBarUEFI/assets/111957484/44326378-4305-42c2-ac85-db995aed9944
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1857516395,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVNX4MDWPQPIUUIAFUTYJQGQRAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJXGUYTMMZZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Also please use setup_var to change hidden settings instead of flashing
because it's way safer no risk of brick.
All this stuff in the wiki page hidden 4g decoding
On Fri, Dec 15, 2023, 2:29 PM Mohammad Jarrah @.***>
wrote:

@xCuri0 https://github.com/xCuri0
I also found this setting in uefi editor, should I enable it?
image.png (view on web)
https://github.com/xCuri0/ReBarUEFI/assets/111957484/44326378-4305-42c2-ac85-db995aed9944
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1857516395,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVNX4MDWPQPIUUIAFUTYJQGQRAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJXGUYTMMZZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xCuri0 the thing I find very strange is when enabling 4g decoding. Then Even 1gb won't work

Do you get an improvement in performance with the 1GB or 2GB BAR Size?

Yes. Btw I found something
I had a thought, why is even 1gb not working when enabling 4g decoding
Tried everything, still don't work
Until, right now, I redid the mod but without the uefi patch and then enabled 4g decoding. Tried a value of 1gb. It works. It doesn't beep now. But when using value of 32. It loads windows but doesn't post to screen

@xCuri0 @Electron-PSO read above

@xCuri0 tried everything setup_var and everything else
Like what the heck!!!!
The only time it worked is when I applied 4g decoding and 32 value. Without uefi patch. It turns on and system loads but doesn't post on sceeen(black screen)
If I use the patch with 4g decoding enabled then it will beep

Try setup_var stuff without uefipatch then
On Fri, Dec 15, 2023, 8:55 PM Mohammad Jarrah @.***>
wrote:

@xCuri0 https://github.com/xCuri0 tried everything setup_var and
everything else
Like what the heck!!!!
The only time it worked is when I applied 4g decoding and 32 value.
Without uefi patch. It turns on and system loads but doesn't post on
sceeen(black screen)
If I use the patch with 4g decoding enabled then it will beep
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1858058475,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVNA7VWCDA55MTRYZBLYJRTW5AVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGA2TQNBXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xCuri0 should I change anything using setup bar beside the 4g decoding enabled or disabled?

You already said there was several other things you can change
On Fri, Dec 15, 2023, 9:08 PM Mohammad Jarrah @.***>
wrote:

@xCuri0 https://github.com/xCuri0 should I change anything using setup
bar beside the 4g decoding enabled or disabled?
—
Reply to this email directly, view it on GitHub
https://github.com/xCuri0/ReBarUEFI/issues/103#issuecomment-1858076923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHBJLVL7W5UOGTOWGIOZGBTYJRVIRAVCNFSM6AAAAABAOPZDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGA3TMOJSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Tried now with only 4g using setup var and without uefi patch
It boots but doesn't show anything on the screen

@xCuri0 enabled now using setup_var
Above 4GB MMIO BIOS assignment,
Above 4g decoding
64 bit resource something
Still it fully boots but doesn't show anything on screen!!!!!!!!!!

@Electron-PSO @xCuri0 what should I do?!!

@xCuri0  @Electron-PSO
This is the raw working bios
backup2.zip

@xCuri0 This is my bios. Unedited
I tried every single thing. It didn't work!!!!
I am so sad and disparate

@xCuri0 @Electron-PSO anyone?

@Electron-PSO I got in new asus prime a x299 motherboard

@Electron-PSO but i am having a problem in booting. It would be amazing if you can help me a bit

@Electron-PSO not booting problem from rebar. But booting problem after swapping motherboards

Hello @mojarrah   is she posting at all?

@Electron-PSO I got it working. But I have a very strange problem
In hwinfo or msi afterburner statistics, cpu is working perfectly except it shows the power consumption of it is 2w max. It goes between 1 and 2!!!!

Windows 10 or 11 ?
Are there any missing devices in Device Manager?
Maybe you need a Chipset.inf for your board?

@Electron-PSO windows 11
And you are right. Thanks got it fixed
Btw, my alienware board support 64gb max ram and it has 4 slots
But I have 64gb(2x32gb) that I wish so much That I can use it with the board
Is there a way I can mod the bios to support more than 16 GB per slot?
Btw, I can access the bios hidden menus in UEFI bios editor

@Electron-PSO it would be insanely helpful if we can do it

The CPU has a 4 channel memory controller.
For best results, I would stick with 4 x 16GB sticks.
There may be a way to get around the limit, but is it worth it?

The CPU has a 4 channel memory controller.
For best results, I would stick with 4 x 16GB sticks.
There may be a way to get around the limit, but is it worth it?

@Electron-PSO its worth it for me
I is a way to enable it?

@Electron-PSO its worth it for me
I is a way to enable it?


Add a flappy bird game

Is your feature request related to a problem? Please describe.
I just made a game by using JavaScript
Describe the solution you'd like.
This is only a single-player & end-user game
Describe alternatives you've considered.
I used Html,Css & javascript
Add any other context or screenshots about the feature request here.
No response

I'll like to contribute on this, Kindly assign me!!

@KIET7UKE Can you provide more details regarding the game which you want to add?

It's a basically Single Player game built with the use of proper JavaScript

@KIET7UKE Good Luck 👍🏻


Flash mode bugs fix

Hey Sir, I found some bugs related to flash mode, so I fire this pull request to you, hope you can take a look it.
Thanks
Felix

👍  - I made these changes and flash works on iOS 10+, very nice, approving this!

thanks @felix8888 @Kaspik 🙌

@piemonte @felix8888 One more fix please (I don't wanna fork and include this one row fix).
PBJVision.m - row 1739, On iPhone 5, 6 etc with iOS 10 and front camera - it crashes if flashMode is not off (because these older devices don't support flash from screen).
please change whole row from:
settings.flashMode = (AVCaptureFlashMode)self.flashMode;

to
settings.flashMode = [self isFlashAvailable] ? (AVCaptureFlashMode)self.flashMode : AVCaptureFlashModeOff;

Also, method isFlashAvailable should have one more check - return (_currentDevice && [_currentDevice hasFlash] && [_currentDevice isFlashAvailable]);
via apple doc: The value of this property is a BOOL indicating whether the receiver's flash is currently available. The flash may become unavailable if, for example, the device overheats and needs to cool off.

@piemonte The same fix applies to your NextLevel Swift camera project (FlashModeOn for front camera on older devices). :)


Implement deselect upon data removal commands (e.g. checkout, clear, undo, redo)

Right now, detailed panel still displays guests that have been deleted, which is unintended.
Solution: Clear all detailed panel displays upon data removal commands

Fixed in #219


Advertise python 3.5 support

Django 1.8.6 adds official support for Python 3.5 into Django and Wagtail's run fine on Python 3.5 for months (despite Django not "officially" supporting it).
This PR adds Python 3.5 support into setup.py/readme.md

Great! Release note?


Boto no longer needs env variables, will check all locations

Boto is now a robust aws sdk and looks for  credentials in the following places (in this order)
1.Credentials passed into constructor
2.Environment variables for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY (what was previously coded)
3.Named profiles in the ~/.aws/credentials file (as specified)
4.Default profile in the ~/.aws/credentials files
5.Named profile in the boto config
6.Default profile in boto config
7.Instance profile credentials (if on EC2 instance)
We had to make this change because we are using instance profiles in AWS when building RPMs from our jenkins.

Thanks for that. Do you think you could just add a few lines to make sure that the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables are set based on AWS_ACCESS_KEY and AWS_SECRET_KEY (if they exist) so that it is backwards-compatible?

Yep, will work on it and let you know when its done.
On Thu, May 14, 2015 at 11:47 AM, Cyril Rohr<EMAIL_ADDRESS>wrote:

Thanks for that. Do you think you could just add a few lines to make sure
that the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment
variables are set based on AWS_ACCESS_KEY and AWS_SECRET_KEY (if they
exist) so that it is backwards-compatible?
—
Reply to this email directly or view it on GitHub
https://github.com/crohr/rpm-s3/pull/2#issuecomment-102079334.

Updated to have backwards compatibility.

Thank you!

Its a great tool. Thank you.
On Thu, May 14, 2015 at 2:12 PM, Cyril Rohr<EMAIL_ADDRESS>wrote:

Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/crohr/rpm-s3/pull/2#issuecomment-102123968.


Update develop scripts due to funds and assets rake task

Waiting for +1

After solving issue reported above :+1: from me :smile:

Thanks. Waiting for second +1

:+1:


What about the progress?

Hi, I have been working on this for few weeks and unfortunately, I still can't reproduce the result with the setting presented in the paper. how about your latest progress?

It's in the README. No remarkable progress.


How to handle host volumes in localkube

Hi,
The idea of this issue is discuss how to handle the host volumes used only for local development that, also, the absolute path changes across developers and all need to do local development.
I haven't really thought about it, but maybe using a file with all the containers for production, and the one for local dev just adds the volume mounts and a "cat prod dev-volumes > dev" is done and dev is always kept up to date. Probably this is not a good idea and something better can be done, but just to start the discussion :)

hey @rata, so sorry we missed this issue! since we moved work on localkube over to minikube, I believe dealing with host volumes is on their roadmap, and this issue (https://github.com/kubernetes/minikube/issues/422) has discussion on it!

On Fri, Jul 29, 2016 at 05:14:29PM -0700, Mackenzie Burnett wrote:

hey @rata, so sorry we missed this issue! since we moved work on localkube
over to minikube, I believe dealing with host volumes is on their roadmap, and
this issue (https://github.com/kubernetes/minikube/issues/422) has discussion
on it!

Np! I thought it was on minikube now, no that this issue was missed! :-)


Codespace: python-starter-app fails to create

Create a new codespace w/ the python-starter-app config. It fails with "workspace failed to create"
Notice this error in the logs
"[ERROR]: app_name is a required parameter.  Please update your devcontainer.json and include '"app_name": "my-payload-app"'"

Hide this for now until we move over the whole solution

python starter has not been fully moved over. For now, reference the ship-detector-onxx smaple for a python payload-app sample


[Refinery] Enable extra volume configurations in deployment config

Which problem is this PR solving?
These changes enable users to define additional volume and volumeMount configurations for the Refinery deployment object. This is important to enable volume-based secrets handling techniques such as the secrets-store-csi-driver.
Short description of the changes
Adds two new helm values: volumes: [ ] and volumeMounts: [ ], uses the existing patterns to call the values using toYaml and nindent.
How to verify that this has the expected result
From ./charts/refinery, I am able to confirm that the chart renders properly without the values set:
% helm template -f values.yaml .

and with the values set:
% cat /tmp/volumes.values.yaml
extraVolumeMounts:
  - name: honeycomb-secrets
    mountPath: "/mnt/secrets-store"
    readOnly: true

extraVolumes:
  - name: honeycomb-secrets
    csi:
      driver: secrets-store.csi.k8s.io
      readOnly: true
      volumeAttributes:
        secretProviderClass: "honeycomb-secrets"

% helm template -f values.yaml -f /tmp/volumes.values.yaml .

Hi @mars64 - thanks for the PR and sorry it's taken so long to get back to you. I'll be reviewing shortly to provide feedback.

Applied suggestions. Let me know if you need anything else from me here.


v1.16.0: add a method to pass on JVM memory settings on to forked JVMs

I've tested this locally on the java 7 util.etl cdh-513 build. The settings show up as expected in sbt, and they fix that build.

Comments:
1. The usage and purpose should be documented, because from this PR alone it's unclear what problem is being solved.
2. What's wrong with the build explicitly specifying the java options? e.g. `javaOptions in run += "-Xmx8G"`

Yeah, that's a fair question.
You can look at this PR as a bit of magic attempting to ensure that sbt "does the right thing" automatically when it comes to forking JVMs to run tests. Why is that the right thing to do? My logic went roughly as follows:

Currently memory settings are specified on the command line. People can (and already do!) change those settings locally and expect those changes to apply to all parts of their sbt build.
Memory settings for forked JVMs are a niche concern and so it's going to be difficult to communicate to everyone, as time goes on, what the different ways of managing memory for core sbt JVM vs. forked JVM are.
As such, it would be nice if memory management "just worked" (tm) in a consistent way for both core and forked JVM processes.
We have lots and lots (and lots) of ETL builds. If we put the logic into uniform it's specified once an can be maintained over time. If we put it into each build we'll be duplicating it tens or hundreds of times and can't realistically maintain it going forwards.
This logic is something that will need to be maintained over time, as Java memory management details are changing with each major version.
And in any case, it's opt-in and the user can still explicitly set javaOptions if they need to.

I guess there's still work planned here?  @SamRoberts


Use batch DDL for update-vid-model-foreign-keys-and-indexes.sql.

Without batch DDL, this changeset takes minutes to apply resulting in the update workflow timing out.

This change is


Use aspnetcore-dev

Looks like this repo got missed when @pranavkm  was updating repos to use aspnetcore-dev.

Nice catch. Must've missed this when I was updating.


Diagnostics & Feedback should no longer point towards recent Insider builds, it is now in main Windows.

@TheJokingTeen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Implement comments feature that posts user-inputted name and comment

I decided to change the logic a bit so the assignment of "Anonymous" is handled by doPost rather than getRequestParam

This branch is deployed on https://caseyprice-step-2020.appspot.com/comments.html


Fix: Cover differs

This PR

[x] covers differs

Follows #2826.

@localheinz , please don't squash your commits, we will do it during merging automatically ;)
without squashing, it's easier to see the difference instead of taking a look at whole diff again ;)

I faintly guess you agree with my reasoning ?

@localheinz , please fix travis

https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/jobs/241961977#L330
:(

Thank you @localheinz.

Thank you, @GrahamCampbell, @julienfalque, @keradus, and @SpacePossum!

Thanks @localheinz : D

with your approach @localheinz , you will shortly cover all untested classes ! ;D


ensure => present isn't the default?

When not specifying ensure, no key is installed.  Should ensure=>present be the default?

Bump


goldendict: 2022-05-10 -> 1.5.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Could you please address https://github.com/NixOS/nixpkgs/issues/180841 as well?

Done.


new plugin: vue2-leaflet-axesgrid

Hi thank you! We have another list in the docs too could you add it there?

hello! thank you too. I will add it there


Grammar module naming convention

Regarding https://github.com/highlightjs/highlight.js/blob/master/extra/3RD_PARTY_QUICK_START.md
The two examples,
<script type="text/javascript" src="/path/to/highlight.min.js"></script>
<script type="text/javascript" src="/path/to/highlightjs-robots-txt/dist/robots-txt.min.js"></script>
<script type="text/javascript" src="/path/to/highlightjs-cypher/dist/cypher.min.js"></script>

however on https://github.com/highlightjs/highlight.js/blob/master/SUPPORTED_LANGUAGES.md package names (3rd column) use the highlightjs-grammar convention.
Should we require the grammars modules use a standard naming convention with highlightjs- prefix?
<script type="text/javascript" src="/path/to/highlight.min.js"></script>
<script type="text/javascript" src="/path/to/highlightjs-robots-txt/dist/highlightjs-robots-txt.min.js"></script>
<script type="text/javascript" src="/path/to/highlightjs-cypher/dist/highlightjs-cypher.min.js"></script>

@joshgoebel

Should we require the grammars modules use a standard naming convention with highlightjs- prefix?

The naming convention is that the package name should should be highlightjs-[grammar], not the distributable (or npm library filename) - which is expected to be simply [grammar].  This is as intended.  If someone is copying this file into their own larger project I'd likely recommend it be placed in a  grammars or hljs folder for some context.
I do sort of see your point if the file is just thrown in an empty folder with no context... (ie, the file itself is treated as the entire "distribution")... but I'm not sure this is worth forcing everyone to change conventions midstream.
@highlightjs/core Further thoughts on this?

It's worth remembering a larger project might easily have multiple grammars... so repeating the name over and over vs just putting them in a folder for easy grouping seems a bit redundant and annoying to me.

The naming convention is that the package name should should be highlightjs-[grammar], not the distributable (or npm library filename) - which is expected to be simply [grammar]. This is as intended.

I'm ok with that, just wanted it to be officially stated as I want to make sure my 3rd party contributions are hitting the right conventions.

The question is answered.

.js file name matches language name.
packagename is highlightjs- + language-name


Support creating a repository_name claim when chaining

GitHub doesn't provide a claim in its token, or an environment variable/context value containing just the repository's name. It does give the owner in repository_owner though.
Having this available as a tag will be very useful when constructing policies. For example, you could create a policy that allows repos to push to s3 buckets named like
mycompany-${aws:RequestTag/repository_owner}-${aws:RequestTag/repository_name}

WDYT?
As an alternative, I could imagine an input to allow any custom tags to be sent, but I'm not sure we want to go that far.
(thanks for this action by the way, it's super helpful!)

Thanks for your contribution and glad the action has helped you :)
Looking over documentation I have written regarding "passing claims" I believe I could have done a better job and simplifying this and will get around to it as soon as I wrap something else up.
The only claims that are relevant for being "passed" are those claims listed at https://token.actions.githubusercontent.com/.well-known/openid-configuration. Depending on the GitHub Actions execution context, these are the claims that may appear in the access token that is sent to Cognito Identity and its these claims that can be mapped by Cognito Identity to session/principal tags.
Passing claims means that during role chaining we tag the new session with new session/principal tags that exactly matches the existing tags. In order for the claims to remain valid and trusted, the trust policy on the role that is being chained have to look similar to below:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": "arn:aws:iam::111111111111:role/MyInitialCognitoRole"
      },
      "Action": [
        "sts:AssumeRole",
        "sts:TagSession"
      ],
      "Condition": {
        "StringEquals": {
          // (Optional) Ensure that the role was assumed via Cognito Identity
          "aws:FederatedProvider": "cognito-identity.amazonaws.com",
          // Ensure that we set the tag "repository" in the NEW session with the exact same value of "repository" tag in the CURRENT session
          // Without this condition, any value could be passed by the assumer
          "aws:RequestTag/repository": "${aws:principalTag/repository}",
        },
        "ForAllValues:StringEquals": {
          // Ensure that AssumeRole cannot set any other tags than those listed here
          "aws:TagKeys": [
            "repository",
          ]
        },
        "StringLike": {
          // Ensure that the value of tag "repository" in the current session is like:
          "aws:PrincipalTag/repository": [
            "catnekaise/example.*"
          ]
        }
      }
    }
  ]
}

Since the value of repository_name is calculated (and I really wish that this claim existed also just like repository_owner) it means that it can be manipulated and can no longer be considered a claim that can be trusted.
Resource Tag solution
Obviously s3 buckets does not support / characters in them so using the repository claim would not work. What you could do is place less value on the name of the bucket and instead use resource tags on the bucket.
{
  Actions: [
    "s3:GetObject",
    "s3:PutObject"
  ],
  "Resource": "arn:aws:s3:::mycompany-*/*",
  "StringEquals": {
    "aws:ResourceTag/githubRepository": "${aws:principalTag/repository}"
  }
}

Prefix Solution
If separate buckets per repository is not a hard requirement, a single bucket and policies based on prefix can also work.
{
  "Effect": "Allow",
  "Action": [
    "s3:GetObject",
    "s3:PutObject"
  ],
  // the prefix path will become /repositories/organization-name/repo-name/
  "Resource": "arn:aws:s3:::my-bucket/repositories/${aws:principalTag/repository}/*",
  "Condition": {
    "StringLike": {
      "aws:PrincipalTag/job_workflow_ref": "catnekaise/shared-workflows/.github/workflows/*@refs/heads/main"
    }
  }
}

If using repository_name

I'm not sure if I've had to match principal tags using request tags so I cannot say for 100% this would work (will test tomorrow).

If intent is to calculate repository_name, the way to have it remain secure in role-chaining would look like:
{
  "StringEquals": {
    // Ensure that we set the tag "repository" in the NEW session with the exact same value of "repository" tag in the CURRENT session
    "aws:RequestTag/repository": "${aws:principalTag/repository}",
    // Ensure that we set the tag "repository_owner" in the NEW session with the exact same value of "repository_owner" tag in the CURRENT session
    "aws:RequestTag/repository_owner": "${aws:principalTag/repository_owner}",

    // Here we compare that the CURRENT session tag "repository" would equal repository_owner/calculated_repository_name
    "aws:PrincipalTag/repository": "${aws:RequestTag/repository_owner}/${aws:RequestTag/repository_name}"
  },
  "ForAllValues:StringEquals": {
    // Ensure that AssumeRole cannot set any other tags than those listed here
    "aws:TagKeys": [
      "repository",
      "repository_owner",
      "repository_name"
    ]
  },
  "StringLike": {
    // Illustrate that repository_name tag cannot be trusted
    "aws:RequestTag/repository_name": "*"
  }
}

Summary
While the last example might work, repository_name (which I also wish was a real claim) cannot be made into a "passed claim" as it cannot be trusted on its own and would have to have custom policies that validate it. However, I've thought about adding some kind of support for like "additional session tags during role chain" and basically concatenate them with the passed claims. Doing it this way to make it very clear what is a passed claim and what is just a tag with any value.
- id: repository_name
  run: |
    # Calculate repository_name and output
- uses: catnekaise/cognito-idpool-auth@v1
  with:
    chain-role-additional-tags: "repository_name=${{ steps.repository_name.outputs.repository_name }}"
    ## Or
    chain-role-additional-tags-2: "Key=repository_name,Value=${{ steps.repository_name.outputs.repository_name }}"

Please keep the PR open for discussion.
Additional Resources
https://catnekaise.github.io/github-actions-abac-aws/detailed-explanation/ the following might helpful if you have not read it yet.

Heya, thanks a lot for the detailed reply. For me, the main part is about how to trust the passed claims - do you agree?
My take is that all of the claims need to be verified (actually your guides helped me understand this). Even the ones we are simply passing straight through from Cognito to the chained role.
Otherwise, what could happen is a malicious actor manually runs the same steps that we're running in this action, but substitutes their values for the passed claims. If the sts:AssumeRole policy in the jump account isn't verifying these claims then we won't be able to stop that.
IMO this means that providing a way to pass any tags you want is opening up users to shooting themselves in the foot.
But at the same time, it's fine to pass derived tags as long as you can verify them from the original claims that came from GitHub. In this case it's like you said:
"Condition": {
    "Null": {
        "aws:TagKeys": "false"
    },
    "ForAllValues:StringEquals": {
        "aws:TagKeys": [
            "...",
            "repository_name"
        ]
    },
    "StringEquals": {
        "... checks for other tags passed ...",
        "aws:PrincipalTag/Repository": "${aws:RequestTag/repository_name}/${aws:RequestTag/repository_name}",
    }
}

So to sum up, all claims - even unchanged ones - need to be validated in IAM policies, and for repository_name in particular, since there's a way to verify it from the principal claims, it's acceptable for us to add it in.
The main part that's missing for me is documenting this explicitly. I'll go and add another commit to make this very clear now, and we can see what you think after that. Thanks again :+1:

Having had some more time to think it over I like your suggestion more as it simplifies usage and something like chain-role-additional-tags can be revisited in the future for truly additional tags.
This is also the single value that can be calculated among all claims and safely "passed", assuming the trust policy is correctly configured. This action has no control/insight to trust policies as that responsibility is with the user and this action is here to simplify usage for the user.
I don't believe GitHub will add repository_name as a claim since that makes it easier to make mistakes due to missing validation of the owner. That said, if they do I don't see any problems that cannot be solved because of it.
The Pull Request / Implementation
What I had like is help the user so it becomes harder to gloss over the need to validate repository_name.
Add a warning
Add a warning if passing repository_name while not also passing repository and repository_owner. This does not guarantee that the trust policy is correctly configured but should help.
  # implement a check
  # Add some language
  echo "::warning::The tag `repository_name`.... Read more https://github.com/catnekaise/cognito-idpool-auth#passing-repository-name"
  value="${GITHUB_REPOSITORY##*/}"

Documentation

Give your paragraph a title with three hashes and call it Passing Repository Name (or suggestion for a better title), and update the Table of Contents.
Move this title and paragraph under the table.
Update the example policy-fragment so it becomes more clear how the policy has to look.

{
  "StringEquals": {
    "aws:RequestTag/repository": "${aws:PrincipalTag/repository}",
    "aws:RequestTag/repository_owner": "${aws:PrincipalTag/repository_owner}",
    "aws:PrincipalTag/repository": "${aws:PrincipalTag/repository_owner}/${aws:RequestTag/repository_name}"
  }
}

Let me know what you think and if you need anything else.

Ok, thanks again for the feedback. I think I've addressed those requests. Here's a test run which issued a warning. It's kind of interesting since you don't need to pass those claims to be able to validate them, but you do need to map them in the ID pool. I don't know if that can be checked directly though. I played around a bit to try to find a way to access the role session tags for the jump role but couldn't do it. So this might be the best thing to do at least for now.
Just so you know, I won't be able to make any more updates for a few days. Feel free to push to this branch and merge it if you can, or check it out and make more changes on top.
Cheers!

There's no way that I know of to get the current session tags in real-time. You can see whatever tags you set during AssumeRoleWithWebIdentity or AssumeRole in CloudTrail.
A little bit unsure what you meant by "It's kind of interesting since you don't need to pass those claims to be able to validate them, but you do need to map them in the ID pool".
Given a claim mapped by Cognito Identity that sets the repository tag to catnekaise/example-repo, then a condition on the trust policy in the jump account as shown below would require setting the tag repository_owner (${aws:RequestTag/repository_owner}) to value catnekaise and then setting the tag repository_name (${aws:RequestTag/repository_name}) to value example-repo.
Not setting either of these tags or using a different value would fail the validation.
{
  "aws:PrincipalTag/repository": "${aws:RequestTag/repository_owner}/${aws:RequestTag/repository_name}"
}

If changing ${aws:RequestTag/repository_owner} to instead be ${aws:PrincipalTag/repository_owner}, then there's no requirement to set the tag (passing the claim) for repository_owner as we would have used the current correct value of the principalTag.
In the end this action can only help guide the user with documentation and a warning like now so that hopefully fewer configuration mistakes is made. It's entirely possible to configure identity federation in a way that grants unintended access.
Pull Request
Great work by the looks of it. I will perform thorough testing myself as soon as I get a chance and there's no rush getting this merged in case there's a small change required, but I will go ahead and merge if everything checks out. Have a great weekend!.

I've had a chance to test this out.
The following values set in chain-pass-claims must continue to work and the last 4 shall trigger the warning.
repository_name,repository,repository_owner
repository, repository_owner=owner, sha=commit
repository,repository_owner
repository_name,repository
repository_name,repository_owner
repository_name=repoName,repository=repo
repository_name,repository_owner=owner

Issue
The following change causes a problem as the individual claims cannot be correctly known here if the user have mapped claims to different tag names.
declare -A claims
while IFS=', ' read -r claim; do
  claims[$claim]=1
done <<< "$PASS_CLAIMS"

See the table here. In short, if setting value of chain-pass-claims to repository=foo, then tags set in AssumeRole would become Key=foo,Value=catnekaise/example-repo. Maybe not the most noticeable feature in the documentation but a feature that cannot break.
I see two options.
Option 1
Reset the changes above the original loop except addition of repository_name and run another loop just prior to the existing loop and populate the associative array.
declare -A claimsSet

for c in "${claims[@]}"; do
  IFS='=' read -ra parts <<< "$c"
  claim=${parts[0],,}
  claimsSet[$claim]=1
done

tags=()

for c in "${claims[@]}"; do
  # loop
done

Option 2
Reset the changes above the original loop except addition of repository_name, declare claimsSet and populate it in the existing loop and move to check the condition after the loop.
declare -A claimsSet

for c in "${claims[@]}"; do

  IFS='=' read -ra parts <<< "$c"
  claim=${parts[0],,}
  tagName=${parts[1]}
  claimsSet[$claim]=1

  # Rest of loop....

done

if [[ -v claimsSet[repository_name] ]] && ! [[ -v claimsSet[repository] && -v claimsSet[repository_owner] ]]; then
  echo "::warning::repository_name is being passed, but repository and repository_owner are not. You need to pass both in order to validate repository name in your IAM policy. Read more: https://github.com/catnekaise/cognito-idpool-auth#passing-repository-name"
fi

echo "value=${tags[@]}" >> "$GITHUB_OUTPUT"

Summary
The docs look good and I will get around to cleaning up the overall docs later after the PR is merged.
I'm OK with either option and open to other suggestions. I also have a working context of these changes now and should be able to quickly respond and merge the PR once it works.

Alright, back now. Cheers for spotting that. I missed that feature.
Care to take a look at f91d9c03582e865c94c5c884c8014eb9a55e9c74? That should address the concern as far as I can tell. We save the original pass_claims value in the values of the associative array, and have the keys be the plain (non mapped) claims. Then we can continue iterating over the values as before.
The only thing that wouldn't work is if the user has mapped the same claim twice, as in:
repository_name=foo, repository_name=bar

we would just use bar. I'm not sure if that is something we need to support.
Here are a couple of runs on this commit. One with chain-pass-claims: repository_name. showing it warns. And one with chain-pass-claims: repository_name, repository=foo, repository_owner. Don't worry that it fails, that's just because the role has no permissions. The important thing is that we tried to assume it - i.e. we passed the validation.
Looking forward to seeing if your testcase works too.
Passing claims and when it's strictly needed

A little bit unsure what you meant by "It's kind of interesting since you don't need to pass those claims to be able to validate them, but you do need to map them in the ID pool".

Just something I thought about while writing this stuff. Strictly, you do not have to have repository and repository_owner in chain-pass-claims to be able to validate it properly. It is enough to have it mapped in the Cognito ID provider and not passed, like this:

This means that you get the claims available for use in aws:PrincipalTag (tags on the role session that Cognito creates for us). So you can write a policy like:
{
  "StringEquals": {
    "aws:PrincipalTag/repository": "${aws:PrincipalTag/repository_owner}/${aws:RequestTag/repository_name}",
}

in that role's sts:AssumeRole policy (controlling when the Cognito-assumed role can further assume the next one), to verify that repository_name is fine, and just chain repository_name onwards.
That's only if you don't want to use repository or repository_owner in the final role's policies. For example, maybe you already checked repository_owner is your org in the trust policy for the jump account, so there's no need to pass it on and check that again.
But as far as I can tell we can't check that in this action, so what we're doing here is probably safest, even though we might make people pass "too much". It's pushing them towards doing the right thing. All of this stuff is very complicated :grimacing:

Great. Works for me. The warnings fire when they should fire and looking in both GitHub Actions logs and CloudTrail everything is in order when I test.
I would say the general implementation is approved but you are right and maybe a slight change to the warning could be warranted. Read below.
Passing claims when strictly needed
It's true that both do not need to be passed. One of my earlier replies for a policy suggestion had the example below. By referencing aws:RequestTag/repository_owner it is forced to be passed.
.
{
  "StringEquals": {
     // Validate repository_name
    "aws:PrincipalTag/repository": "${aws:RequestTag/repository_owner}/${aws:RequestTag/repository_name}",
     // Add if wanting to continue using the claim
    "aws:RequestTag/repository": "${aws:PrincipalTag/repository}"
  }
}

In any situation I think that either repository_owner (StringEquals) or repository (StringLike) should also be passed and the warning is about informing the user to not assume which GitHub organization the repository exists in after role-chaining.
A company running GitHub Enterprise may have multiple legit GitHub organizations and one or more sandbox organizations in where they allow users to test stuff out so there's the consideration of org-a/backend-service-1 and org-a-sandbox/backend-service-1.
I believe a final and small change to the warning logic that only triggers when neither repository_owner or repository is passed and a text similar to:
"::warning::repository_name is being passed, but neither repository or repository_owner is. You should pass one of them if wanting to match the GitHub organization in IAM your IAM policies. Read more: https://github.com/catnekaise/cognito-idpool-auth#passing-repository-name".
Do not worry about any documentation changes, I will get to it and expand on the subject of repository_name. Also need to implement support for it in my little cdk library.
Great effort and communication over all. So much for something so "little" but it's as you stated, pushing people to consider these things as errors in this can have great consequences. My expectation has always been that those that use this action either forks/copies the yaml file into their own repository, and in doing so, they could remove that single like of warning with ease if they find it annoying.
Summary

Trigger warning when both repository_owner and repository are not set
Update warning text like example or by phrasing it better than I did
Keep your current changes to README.md and I make a larger update as soon as I can.

I can approve the PR and merge it as soon as I see it and can do it during $DAYJOB as its just a 5minute thing.

Alright then, thanks once more. I've pushed 41ced8eea6d48833dd146c51f52fa784c9be863b which I think/hope implements the latest & last suggestion :pray: :wink:


[LLD] Dynamically set the minimum of global summary chart

✅ Checklist

[x] npx changeset was attached.
[x] Covered by automatic tests.
[x] Impact of the changes:

Sets the suggestedMin of the chart in the global summary to be the minimum of the balanceHistory that we are currently looking at

📝 Description
It is difficult to view the small changes in the balance if the values are much bigger than 0. Ideally, we are able to view the chart values in the relative range that we are currently viewing, making the viewing experience better.
Note that the mobile app already has this as the display - this PR is just to make it on parity with the desktop explorer as well.
This was originally opened with this PR: https://github.com/LedgerHQ/ledger-live/pull/6528, but it was closed to inactivity.
@gre said he would talk to product about this but there was never an update.
Old view:

New view:

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

sorry for missing the followup of this. Product agrees with the direction so we can proceed with this 👍  Thanks

@dkaplan65 can you rebase with latest develop of our repository? the CI can't run it because of this. thanks

@dkaplan65 can you rebase with latest develop of our repository? the CI can't run it because of this. thanks

@gre - rebased - con someone from your team authorize the deployment?
Thank you!

/generate-screenshots


⚠ Bofrost.lu has degraded performance

In bb9e173, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 840 ms

Resolved: Bofrost.lu performance has improved in bd0c28a after 8 minutes.


BC-breaking pytorch 1.9 vs 1.7.1 in multi_head_attention_forward

https://github.com/pytorch/pytorch/blob/v1.7.1/torch/nn/functional.py#L4222
https://github.com/pytorch/pytorch/blob/v1.9.0/torch/nn/functional.py#L4836
I cannot find scaling in pytorch 1.9, it seems has been removed. So, maybe First, [install PyTorch 1.7.1](https://pytorch.org/get-started/locally/) (or later) and torchvision is not correct.

It appears that they refactored the implementation, and the scaling part is now in:
https://github.com/pytorch/pytorch/blob/v1.9.0/torch/nn/functional.py#L4823


【vite】npm run build not could not load index.css

npm run build happen error.

I look find 'node_modules/vue3-draggable-resizable/src/components/index.css ' is exist. so i think version‘error，but i remove and npm install vue3-draggable-resizable，that error also。
why？

Maybe you don't have the corresponding loader?


Search highlight hard to see

Godot version:
3.0.2
OS/device including version:
Windows 10
Issue description:
When viewing documentation inside the editor, the search highlight is black, and when the search box is open there's a dark overlay, and there's a dark background color, which makes the highlighted text very hard to spot.
Perhaps use a bright highlight instead of a dark one (like the code editor does).
Example:

I'm pretty sure this has already been reported but I can't find the original...


Some paths are hard-coded to never be watched

Fireworm has default paths that it will not traverse.
But testem does not expose an option for us to override these paths, as far as I can see. So even if a user sets them explicitly in watch_files, they won't work.
There are good reasons to sometimes want to watch a path like node_modules -- like when you're actively developing multiple modules that are npm-linked together.
I can make a PR to fix this, but what public API should it have? I think testem's behavior is clearer if it simply sets skipDirEntryPatterns to [] and lets the user control the patterns via watch_files/src_files and src_files_ignore.

Yes, that would make sense. Could you send a PR?


Error trying to install

I expected to install androguard with the command:
$ pip install androguard
I first tried in termux on  Oxygen OS (android 13) OnePlus 8T (kb2007). I then tried on Ubuntu 23.10 x64-arm (proot in termux on top of the android OS. Both attempts have given me the same error:
ERROR: Could not build wheels for frida, which is required to install pyproject.toml-based projects
System Information

Androguard Version: master
Python Version: 3.4/3.5/...
Android 13 & Ubuntu 23.10

Are you able to pip install frida successfully? This is probably an issue with some underlying dependency attempting to be compiled on ARM.

@datshicray please check https://github.com/frida/frida/discussions/2411


Ignore fewer doc-tests

@tormol Awesome thanks! Once #687 merges, this'll just need a rebase and will be good for a merge :+1:

Done.
I don't understand why this needed a rebase though: The branches changed completely different files.

You're right. But I go back and forth about using a single rebased history, vs branching....I guess I could just start merging without worry about it since the history is already soup :stuck_out_tongue_winking_eye:
@homu r+

:pushpin: Commit 4ee85b9 has been approved by kbknapp

:hourglass: Testing commit 4ee85b9 with merge 47ffccd...

:sunny: Test successful - status

Github also required an update; that's what I don't understand.


Ability to provide global default options

Describe the feature you'd like to request
I'd like to be able to specify global defaults for the cli.
Describe the solution you'd like
Options like --cache-dir are best configured globally instead of always setting them in each command that is run. In general, I think it would be good to read these configuration options (with increasing priority):

From the package.json configuration
From an environment variable
From a cli option

Personally, I've adopted this pattern for literally every option in the cli tools that I maintain. There's always a weird edge case where in some environment you want to override one of the options conveniently via a environment variable (e.g. in CI) for instance.
Describe alternatives you've considered
The CLI options are currently very strictly parsed with positional arguments first and options second only. E.g. this is valid:
yarn turbo run build --cache-dir=.turbo

but this isn't:
yarn turbo run --cache-dir=.turbo build

This means that currently it's also not possible to e.g. specify a common base command like
"scripts": {
   ...
   "turbo:run": "turbo run --cache-dir=.turbo"
   ...
}

1000000000%.
Hoping to add this in #217

🙏🏼


[bug] Canvas content gets reset if app draws with delay

It seems that if I draw something on canvas using a timeout, the previous drawing will be erased.
Seems to occur on android and ios (devices only)
Samples to test:
This works

export function onContextReady(args) {
  var canvas = args.object;
  var ctx = canvas.getContext("2d");
  ctx.rect(50, 20, 200, 120);
  ctx.stroke();
  ctx.fillStyle = "red";
  ctx.fillRect(0, 0, 150, 100);
}

This is with timeout. It will erase first shape and draw red rectangle alone
export function onContextReady(args) {
  var canvas = args.object;
  var ctx = canvas.getContext("2d");
  ctx.rect(50, 20, 200, 120);
  ctx.stroke();
  ctx.fillStyle = "red";
  setTimeout(() => ctx.fillRect(0, 0, 150, 100), 2000);
}

Fixed in https://github.com/NativeScript/canvas/commit/9a5723f7f7b6aa555e8a3f020ffc8bfc5753ad50


Script for updating main README

While working on the documentation for the DNS, I am realizing that keeping the snippets, module-specific readme, and main readme consistent is quite difficult and time consuming. I wonder if for the future use, we could benefit from a script which would generate the main readme from the module specific ones. The main readme would look somewhat as follows:
Doing Magic
==========
{include magic-module:first-part}
{include magic-module:second-part}

The module specific one:
...
{block magic-module:first-part}
This is the first part...
{/block}
...
{block magic-module:second-part}
This is the second part...
{/block}
...

The script would simply do replacements making the main readme this:
Doing Magic
==========
This is the first part...
This is the second part...

and it would also erase annotations from the second module-specific readme.

I think this is a fine idea. I also think this relates to #607.
It would be nice if we had a script to re-create the readme files based on readme templates and providing a way to reference/include code and other readme fragments.
It looks like GitHub is not going to enable that anytime soon, so providing a script that one could trigger manually would probably be good enough.

This sounds like a very good idea!

This has been added to our feature backlog: https://github.com/GoogleCloudPlatform/google-cloud-java/wiki/Feature-backlog. This issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.


fix(android): exit fullscreen mode after finishing video playback

Summary
We don't need to exit fullscreen mode after finishing video playback because the user might be using repeat mode. This way, they won't need to interact with their phone after the video finishes.
Motivation
Fix this issue 3703.
Changes
Test plan

@KrzysztofMoch
About the first question: On iOS, after finishing the video it doesn't exit fullscreen mode.
For the second question: The default behavior on Android depends on the player. I checked with different players. One of them exits fullscreen mode after finishing, while another doesn't.
Third question: I think we can apply this change on Android because we should have the same behavior on both OS (iOS and Android).
Imagine a user wants to see a list of movies. The user start watching the first movie in fullscreen mode. When the first video finishes, another video starts immediately, but the player exits fullscreen mode. As a result, the user has to activate fullscreen mode again.
Finally, I think it's better to not exit fullscreen mode after finishing video playback.

Good explanation which justify the change. Agreed with @KrzysztofMoch , this behavior change is a breaking behavior it should be warned in release note !

I would like to change this to

if repeat is false we exit fullscreen after video finish
if repeat is true we don't exit fullscreen

WDYT ? @seyedmostafahasani

@KrzysztofMoch I agree with you.
What do you think about the point below?
Imagine a user wants to see a list of movies. The user start watching the first movie in fullscreen mode. When the first video finishes, another video starts immediately, but the player exits fullscreen mode. As a result, the user has to activate fullscreen mode again.


test_notebooks.py::test_notebook[kfp-v1-integration] failing on kubeflow 1.8: Unauthorized

Bug Description
Running Charmed Kubeflow on AWS using Calico as the CNI SQA has seen some failures when testing the kfp-v1-integration notebook.
One test run is running Juju 3.4.6 with k8s 1.31 and the other is running Juju 3.6 with k8s 1.30, however we have also seen passes on this tests in the same time range, with only 4/30 failing in the last 14 days.
On these failures we see that the UAT's are failing to authorize to the API:
test_notebook = '/tests/.worktrees/80012f66d062d03e85b77d164cce8a89a4d486c1/tests/notebooks/kfp_v2/kfp-v2-integration.ipynb'

    @pytest.mark.ipynb
    @pytest.mark.parametrize(
        # notebook - ipynb file to execute
        "test_notebook",
        NOTEBOOKS.values(),
        ids=NOTEBOOKS.keys(),
    )
    def test_notebook(test_notebook):
        """Test Notebook Generic Wrapper."""
        os.chdir(os.path.dirname(test_notebook))

        with open(test_notebook) as nb:
            notebook = nbformat.read(nb, as_version=nbformat.NO_CONVERT)

        ep = ExecutePreprocessor(
            timeout=-1, kernel_name="python3", on_notebook_start=install_python_requirements
        )
        ep.skip_cells_with_tag = "pytest-skip"

        try:
            log.info(f"Running {os.path.basename(test_notebook)}...")
            output_notebook, _ = ep.preprocess(notebook, {"metadata": {"path": "./"}})
            # persist the notebook output to the original file for debugging purposes
            save_notebook(output_notebook, test_notebook)
        except CellExecutionError as e:
            # handle underlying error
>           pytest.fail(f"Notebook execution failed with {e.ename}: {e.evalue}")
E           Failed: Notebook execution failed with ApiException: (401)
E           Reason: Unauthorized
E           HTTP response headers: HTTPHeaderDict({'content-type': 'application/json', 'date': 'Sat, 07 Dec 2024 04:10:41 GMT', 'content-length': '811', 'x-envoy-upstream-service-time': '1', 'server': 'envoy'})
E           HTTP response body: {"error":"List experiments failed: Failed to authorize with API: Failed to authorize with API: Unauthenticated: Failed to check authorization. User identity is empty in the request header: Unauthenticated: Request header error: there is no user identity header.: Request header error: there is no user identity header.","code":16,"message":"List experiments failed: Failed to authorize with API: Failed to authorize with API: Unauthenticated: Failed to check authorization. User identity is empty in the request header: Unauthenticated: Request header error: there is no user identity header.: Request header error: there is no user identity header.","details":[{"@type":"type.googleapis.com/google.rpc.Status","code":16,"message":"Failed to check authorization. User identity is empty in the request header"}]}

Details from these two runs can be found here:
https://solutions.qa.canonical.com/testruns/8363551a-4742-4e40-acc8-e586f818d42c
and here:
https://solutions.qa.canonical.com/testruns/3f43c62a-82ce-453a-894e-73a757eed01d
To Reproduce
The setup for a charmed k8s + kubeflow is a little bit extensive, but I can note the steps around kubeflow and the validator

juju deploy -m foundations-k8s:kubeflow --debug --channel=1.8/stable --trust ch:kubeflow
juju-wait -m foundations-k8s:kubeflow -t 7200 --machine-error-timeout 1800 --retry_errors 5 --workload --verbose -x oidc-gatekeeper -x istio-pilot -x dex-auth
kubectl --kubeconfig /home/ubuntu/project/generated/kubernetes-aws/kube.conf --context juju-context -n kubeflow wait --for=condition=Ready pod --timeout=-1s --all
sudo add-apt-repository ppa:deadsnakes/ppa -y
sudo apt update -y
sudo apt install python3.8 python3.8-distutils python3.8-venv -y
git clone https://github.com/canonical/charmed-kubeflow-uats.git /home/ubuntu/charmed-kubeflow-uats
git -C /home/ubuntu/charmed-kubeflow-uats checkout track/1.8
python3.8 -m venv .venv
.venv/bin/pip install tox
timeout 1800 .venv/bin/tox -e uats-remote -- --junitxml=/home/ubuntu/project/generated/kubeflow/charmed-kubeflow-uats/junit.xml --filter 'not mlflow'

Environment
One test run is running Juju 3.4.6 with k8s 1.31 and the other is running Juju 3.6 with k8s 1.30, however, we have also seen passes on this tests in the same time range, with only 4/30 failing in the last 14 days.
Relevant Log Output
Juju status for Kubeflow:
1) https://oil-jenkins.canonical.com/artifacts/3f43c62a-82ce-453a-894e-73a757eed01d/generated/generated/kubeflow/juju-crashdump-kubeflow-2024-12-09-19.44.54.tar.gz
2) https://oil-jenkins.canonical.com/artifacts/8363551a-4742-4e40-acc8-e586f818d42c/generated/generated/kubeflow/juju-crashdump-kubeflow-2024-12-07-04.20.16.tar.gz

Pod and K8s logs:
1) https://oil-jenkins.canonical.com/artifacts/3f43c62a-82ce-453a-894e-73a757eed01d/generated/generated/kubernetes-aws/juju-crashdump-kubernetes-aws-2024-12-09-19.45.03.tar.gz
2) https://oil-jenkins.canonical.com/artifacts/8363551a-4742-4e40-acc8-e586f818d42c/generated/generated/kubernetes-aws/juju-crashdump-kubernetes-aws-2024-12-07-04.20.24.tar.gz

Additional Context
No response

Hey @asbalderson, thx for reporting this. We've hit this issue before with 1.9 UATs and it was fixed by #120 and #122. I see you are running tests for 1.8 from branch track/1.8, and the fixes were not backported there.
We need to backport these 2 PRs to track/1.8 then, that should resolve it.
We'll make sure to prioritize this for next pulse.

Thanks @NohaIhab!

Thanks for the follow up here!

Fixed by #143 #144 #145
Please note that the 1.8 UATs are currently failing due to #146, we'll prioritize fixing it the upcoming pulses.


remove the first barcode nucleotide

hey @deyazoubi we here have a use case where the strength of branches in git become apparent: we don't know how the correct version of the demux sheet will look like --> thus, we should not yet merge it to master branch. For testing various things, I recommend creating branches, test versions and only merge the one branch that eventually leads to success.
Thus, you don't have to revert anything!

@sjanssen2
thank you for your comment
for this use case do you have any comments


Add support for Fast FAP loading

https://github.com/flipperdevices/flipperzero-firmware/pull/2790 bumps the SDK to 31 with 15x faster loading of FAP files. It requires adding .fast.rel sections, so we will need to alter flipperzero-rt to enable it.

Looking at the PR, I think what it's doing is creating a hash table for symbol lookup, rather than a linear search.
This might need to be done as some sort of post-processing step as I don't think it's possible to do this in build.rs or the linker script. This appears to be what scripts/fastfap.py is for.

Yep, fastfap.py is post-processing elf files not only for hashing, but also to create an optimized relocation structure for our elf loader. This removes a large number of calls to the storage, and that's how such an acceleration is achieved.
I recommend you to wait until this feature is released because the format of these sections is subject to change. I also left a fallback to the old usual linking process if optimized sections is not present.

@DrZlo13 Thanks for the information. Definitely appreciate the fallback, so this isn't an urgent thing to address.

This was released in firmware version 0.86.1, and once #93 merges we will require at least 0.87.0, so we can start working on this.

This is now implemented in #99. I think I got the encodings right, and it appears to work (cargo test gets noticeably faster) but I'm unsure if the MD5 for tempfile names in fastfap.py is just for convenience or meant to be load-bearing.

@str4d MD5 for temporary filenames is only for reducing filename size. Not all filesystems can handle files named from a C++ generated section name.

@DrZlo13 thanks, that clarifies things (I didn't know objcopy derives section names from filenames in this way).
I expect that means my current PR is adopting section names from the random file name being chosen by NamedTempFile, which defaults to .tmp<6_RANDOM_CHARS>. Making it deterministic on the section name seems like a better approach.


Choose logging library.

Use easyloggingpp. Plan:

replace all throw statement with proper logging string.
replace iostream with easyloggingpp.

After closing this issue, keep working on #8  .

Building boost libraries would not be a problem(#54). Hence, use Boost.Log instead.

Introduce easyloggingpp would result in:

linkage error of all testcases.
much more time on compiling.

So, try to write a project specific logger instead.


Model and Command Tests

WIP.

Coverage increased (+0.01%) to 80.554% when pulling 7c9bd9af725a6f5cbbaa431f39a995acbd9d815d on model-tests into cacdf320b0072981d3d053b7a04eb21b03d2f642 on master.

Coverage increased (+2.1%) to 82.659% when pulling f78d30c279829de6dad951d83e1f867f6e4f923d on model-tests into cacdf320b0072981d3d053b7a04eb21b03d2f642 on master.

Creating better named branch. Will close this PR.


Add state conversion logic from _create_partial_act_on_args to the corresponding ActOnArgs

This pull request implements the task proposed in #4825, i.e. adding state conversion logic from _create_partial_act_on_args to the corresponding ActOnArgs subclasses. The detailed list is:

Simulator -> ActOnStateVectorArgs
DensityMatrixSimulator -> ActOnDensityMatrixArgs
CliffordSimulator -> ActOnStabilizerCHFormArgs

I did not remove or deprecate _create_partial_act_on_args, though. Ideally, it should be moved to ActOnArgs. However, _create_partial_act_on_args has an initial_state parameter, which is difficult to be mapped to ActOnArgs. Maybe we can add an abstract method _on_init(inital_state: 'cirq.STATE_VECTOR_LIKE' = 0) and let the subclass to implement it.
The with_qubits method mentioned in the issue is also implemented.
close #4825

@daxfohl I have updated the code. Thanks for the instructions!

Look at MpsSimulator/MpsState and do the same there

MpsState already contains an initial_state:
https://github.com/quantumlib/Cirq/blob/4600f588876c5a3b4e6f497d9382d999a9157e79/cirq-core/cirq/contrib/quimb/mps_simulator.py#L221-L232
and MpsSimulator does not contain extra logic:
https://github.com/quantumlib/Cirq/blob/4600f588876c5a3b4e6f497d9382d999a9157e79/cirq-core/cirq/contrib/quimb/mps_simulator.py#L90-L119
So, maybe the current state is already what you want?

Since the logic is now in the constructors, it would be good to remove it from the _create_partial_act_on_args functions.

By removing the logic from the _create_partial_act_on_args functions, do you mean something like:
        if isinstance(initial_state, act_on_density_matrix_args.ActOnDensityMatrixArgs):
            return initial_state

        return act_on_density_matrix_args.ActOnDensityMatrixArgs(
            target_tensor=initial_state,
            qubits=qubits,
            prng=self._prng,
            log_of_measurement_results=logs,
            ignore_measurement_results=self._ignore_measurement_results,
            dtype=self._dtype
        )

In this case, should we rename target_tensor as initial_state? I have checked the code, ActOnDensityMatrixArgs is only used in  _create_partial_act_on_args (except for test files).

Oh that's right, MPS is already set up to handle integer initial states. Nothing required there.
Yes, that's what I meant. We don't need to have that code in two places.
@95-martin-orion Any concerns with renaming target_tensor in ActOnStateVectorArgs.__init__ to initial_state? Formally that's a breaking change, but now since it also accepts int, target_tensor is a strange name.

Any concerns with renaming the target_tensor arg in ActOnStateVectorArgs.__init__ to initial_state? Formally that's a breaking change, but now since it also accepts int, target_tensor is a strange name.

Agreed that initial_state would be preferable, though since the deprecation is cheap (just use deprecated_parameter and have both for a cycle) I think we should do the deprecation to make this non-breaking.

@daxfohl Thanks for the quick feedback. The logic in CliffordSimulator._create_partial_act_on_args still needs to be removed. I will wait until the discussion about the deprecation is done.

The case of ActOnStabilizerCHFormArgs is a little different from other ActOnArgs subclasses. Other subclasses such as ActOnDensityMatrixArgs, is only used in DensityMatrixSimulator._create_partial_act_on_args. Therefore, we can deprecate the target_tensor parameter and use initial_state instead. However, ActOnStabilizerCHFormArgs is called in places like this:
https://github.com/quantumlib/Cirq/blob/2dc428b32a83b8254d2b9eefb24cea26f7d722f0/cirq-core/cirq/sim/clifford/clifford_simulator.py#L287-L289
It expects assigning state.ch_form to ActOnStabilizerCHFormArgs.state directly, not converting from an initial state. Therefore, I suggest keeping the state parameter and adding an initial_state parameter. The logic in CliffordSimulator._create_partial_act_on_args will still be moved to ActOnStabilizerCHFormArgs.__init__.

Sure, that's been a weird kind of circular dependency since before I joined
and I keep meaning to look into it. I think your approach is fine for now
and I will file an issue for myself.
On Fri, Jan 28, 2022, 6:43 PM Jintao YU @.***> wrote:

The case of ActOnStabilizerCHFormArgs is a little different from other
ActOnArgs subclasses. Other subclasses such as ActOnDensityMatrixArgs, is
only used in DensityMatrixSimulator._create_partial_act_on_args.
Therefore, we can deprecate the target_tensor parameter and use
initial_state instead. However, ActOnStabilizerCHFormArgs is called in
places like this:
https://github.com/quantumlib/Cirq/blob/2dc428b32a83b8254d2b9eefb24cea26f7d722f0/cirq-core/cirq/sim/clifford/clifford_simulator.py#L287-L289
It expects assigning state.ch_form to ActOnStabilizerCHFormArgs.state
directly, not converting from an initial state. Therefore, I suggest
keeping the state parameter and adding an initial_state parameter. The
logic in CliffordSimulator._create_partial_act_on_args will still be
moved to ActOnStabilizerCHFormArgs.init.
—
Reply to this email directly, view it on GitHub
https://github.com/quantumlib/Cirq/pull/4847#issuecomment-1024814587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG464NDFWSXANMI5FGDJKLUYNH4BANCNFSM5MC274DA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Actually I only see a couple places in the code that call
Actonstabilizerchformargs. Can you just update them to call with argument
names instead of argument order?
On Fri, Jan 28, 2022, 6:43 PM Jintao YU @.***> wrote:

The case of ActOnStabilizerCHFormArgs is a little different from other
ActOnArgs subclasses. Other subclasses such as ActOnDensityMatrixArgs, is
only used in DensityMatrixSimulator._create_partial_act_on_args.
Therefore, we can deprecate the target_tensor parameter and use
initial_state instead. However, ActOnStabilizerCHFormArgs is called in
places like this:
https://github.com/quantumlib/Cirq/blob/2dc428b32a83b8254d2b9eefb24cea26f7d722f0/cirq-core/cirq/sim/clifford/clifford_simulator.py#L287-L289
It expects assigning state.ch_form to ActOnStabilizerCHFormArgs.state
directly, not converting from an initial state. Therefore, I suggest
keeping the state parameter and adding an initial_state parameter. The
logic in CliffordSimulator._create_partial_act_on_args will still be
moved to ActOnStabilizerCHFormArgs.init.
—
Reply to this email directly, view it on GitHub
https://github.com/quantumlib/Cirq/pull/4847#issuecomment-1024814587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG464NDFWSXANMI5FGDJKLUYNH4BANCNFSM5MC274DA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@daxfohl Sure. I can deprecate calling with argument order, like ActOnStateVectorArgs and ActOnDensityMatrixArgs.

@daxfohl I have finished all the planned changes, including moving logic from CliffordSimulator._create_partial_act_on_args to ActOnStabilizerCHFormArgs.__init__. I have also deprecated positional arguments in those __init__ functions. The logic (len(args) != 1) is a little different from what you mentioned (len(args) != 0) because self is also regarded as a positional argument in args.
I have updated some callings of ActOnStabilizerCHFormArgs.__init__ to the keyword style. Most usages of state are left unchanged due to the circular dependency you mentioned. Wish to see you fix them in the future!


Add Dataloader instrumentation library

What does this PR do?
The Dataloader package is a library often used in conjunction with the Absinthe GraphQL library to perform batch loading of data. This can be useful for efficiently querying databases using Ecto or other custom data sources. It is important to add instrumentation to Dataloader to be able to track and analyze the performance of data loads and identify potential issues such as slow data loads or N+1 queries.
I've looked at the conventions for naming the events but could not find any applicable but open to suggestions.

Whats the status on this PR? Anything someone can assist with?

@olivermt it is moving along. I just had another comment, it may be mergable soon.


Make Ball Search for Ball Devices Configurable

Currently MPF will eject ball from everything except a trough. Make this configurable

Hi, is this still open?

Hi @dziedada,
Yes this is still open. You can give it a go if you like. I suggest that you install MPF in dev in case you did not do that yet (http://docs.missionpinball.org/en/dev/about/contributing_to_mpf.html#install-mpf-in-development-mode). Here is a test for ball search in general: https://github.com/missionpinball/mpf/blob/dev/mpf/tests/test_BallSearch.py. The relevant code is here: https://github.com/missionpinball/mpf/blob/dev/mpf/devices/ball_device/pulse_coil_ejector.py#L80. Adding another tag would probably work. Alternatively, we could add an additional config option. Let me know if you have any questions!
Jan

Hi @jabdoa2 ,
I was just getting started working on this, and it's not completely clear how configurable it should be. My current understanding is that is should be configurable in such a way that individual devices can be made to not eject balls. Is this correct?
Thanks, Adam

Yes exactly. It should be possible to disable ball search for some devices. For example you might want to prevent it from ejecting balls from your ball lock (especially if there isn't any auto launcher).


Congrats on a super cool game! 🤓

Hi Ben and Salvatore,
Congratulations on winning js13k 2019! I too really enjoyed your game and was disappointed after completing the memory core! As a code golf with an high handicap still I looked at your code and noticed that you were using a lot of characters on random unimportant stuff, like pressed, momentary, targetsand so on... Variables that (in the name of the game) could be reduced to a single char making room for perhaps a level 7 or 8... 😁🙈
Anyways, I just did a quick calculation of the potential saving of changing e.g. {pressed: 1} to {p: 1} and just by a super quick overview I found a bunch of variables that could be reduced in length to save those sweet sweet bytes...
My calculation shows a reduction of 0,8 kB (6,4%)! - Just consider how much more you could golf it and how many more levels you could have added to further cement your victory!? 🤓
Was this something you considered during development?
arr = [
    { text: "pressed", count: 24 },
    { text: "momentary", count: 22 },
    { text: "start", count: 8 },
    { text: "targets", count: 23 },
    { text: "type", count: 23 },
    { text: "walls", count: 8 },
    { text: "doors", count: 8 },
    { text: "switches", count: 8 },
    { text: "polygon", count: 8 },
    { text: "playerLightPosition", count: 6 }
];
saved = arr
    .map(x => Array(x.count).fill(x.text).join("").length - x.count)
    .reduce((x, y) => x + y) / 1000;

console.log(`${saved} kB potential saving ~ ${(saved/13 * 100).toFixed(2)}% reduction`);

Looking forward to your entry for 2020! 😉

Hi Ahallora,
Thanks for the kind comments and the analysis!
Yes we definitely did consider it, and had it in mind (as well as many other size optimizations) for if we ever started getting close to the limit - but we never did. Time was a much bigger constraint for us than the 13k limit this year.
I think though that the savings wouldn't be so large as the 13kb limit is after zipping, and I expect the zip process optimises out most of the repetition on the text, but it would definitely be interesting to find out if you want to try implementing the changes :D
I'm also looking forward to next year! Will you enter / have you entered?

Cool, thanks for elaborating. 😄I'll just leave it here, because you're probably right about the zip process optimizations...
And no, I'm not planning on participating in js13k. I'm simply not that skilled a programmer to pursue such an endeavour; but kudos for those that do. 👍


Resize LinearLayouts for multiple icons

Since the LinearLayouts currently only take up half of the status bar (or half the status bar minus half the width of the center layout, if there are any centered icons), it is possible for them to run out of space and get cut off on small screens. A warning for this would probably be a good idea...

This could be done by getting the screen width and simply calculating the icon scale plus padding (and having some complicated thing to deal with the centered icons). Then again, it might be better to just re-do the whole thing with a better organization method - related: #22

Has this issue really been open for over a year? Maybe I should try to fix this sometime soon...
Procrastination is the best development tool.

Well, this is technically fixed now. I'm going to try to add a warning in the settings before closing it though.

Yep, this is fixed now.


Periods at the end of a sentence

Hi there,
Is there a way to get end of sentence periods or question marks when using SRT format?
Thanks,
Dan

I don't see many subs with periods or question marks.
So I suggest not to do this.


Add highcharts to graph list

Feature request for highcharts support https://www.highcharts.com/demo so designs can align with what is possible in development

@Shredivan Examples added to README


Bazel contribution doc should mention this plugin

I know it's probably low on the priority but the [bazel.io contributing page] (www.bazel.io/contributing.html) mentions the eclipse plugin but not the intellij one. For intellij it still talks about the generate.sh script.
If/When you want to draw more traction changing that will probably add more visibility.

Updated -- thanks!


Set 22.0.1-tem as SDKMAN env Java

What does this PR do?:
This configures sdkman to use Temurin 22 as the Java version when working in this repo.
Motivation:
We need the correct JDK registered for using JVMTI symbols when building, and dd-trace-java requires JAVA_HOME to point to a JDK 8 build. This is a convenient way of mitigating forgetting to run sdk use or some other env var switching prior to building.
Additional Notes:
I'm considering adding a shell hook here and in dd-trace-java + relevant private repos that will automatically set the appropriate environment variables for these multi-JDK-dep projects. I've used https://github.com/Shopify/shadowenv in the past and like it quite a bit, any of https://direnv.net/#related-projects would work though.
How to test the change?:

For Datadog employees:

[ ] If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[ ] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Nice, using the rc file :)
I wonder if we need JDK 22 for anything - we still need to keep the bytecode of the Java part compatible with Java 8.
What symbols we need from JDK 22?

@MattAlp Yes, the baseline is JDK 11 for us - because of the JVMTI sampler.
We can be progressive and use the tip (JDK 22) - we are setting the compatibility in ddprof-lib to Java 8 so we are fine at least for JDK 22

Is this still relevant? If not, please close it - it's been dangling for long enough time.


Contribute WinRT test support

Adding test support for Windows RT.
Some unused highgui #include's were removed (sample)
Instructions on building and running tests for WinRT are in platforms/winrt/readme.txt
NOTE: Tests are not supposed to run on real ARM devices in this contribution. Please use Windows 8.0 or Windows 8.1 PC to run tests.
Test results for Windows 8.0 VS2012 and Windows 8.1 VS2013 are there

Related PR https://github.com/Itseez/opencv/pull/4064

Merged, closing.


[Suggestion] "Pass" indicator

Add an indicator somewhere that "lights up" when the current file passes all the lint tests so checking the lint status is as easy as a simple glimpse.

+1 for this.
There's already an indicator for linter errors, so that could just change to green?

This has already been fixed in linter-plus.

@steelbrain I'm not sure what did you mean by that. Were you suggesting me to switch over to that other linter plugin? I was suggesting something to be done for this plugin.

@gsklee linter-plus is the rewrite of Linter all new features/issues will be resolved on linter-plus, when we are done it will be merged in Linter ;)

@iam4x + @steelbrain, what's the current status of linter-plus? It doesn't seem to be available via apm, even though the installation instructions say it should be.
Will it be backwards compatible with linter, i.e. will all current linters continue to work with it? Can I just disable linter and start using linter-plus?
Answers to the above could be added to the readme, and linter-plus could be mentioned in the linter readme ("Contributing" section).
Thanks for a great package! :+1:


Extract simple variants based on conversion region

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[ x] I am running the latest version
[ x] I checked the documentation and found no answer
[x ] I checked to make sure that this issue has not already been filed

Context
Tabix considers VCF POS and length of REF allele when looking for variants that intersect conversion region. We should replicate that approach when converting a VCF that doesn't include a tabix index.

We had been doing this: extract where POS intersects conversion region.
We should be doing this: extract where interval(POS...POS+len(REF)-1) intersects conversion region

resolved by https://github.com/elimuinformatics/vcf2fhir/pull/79


Keypoint visualization question

In this figure, it seems like keypoints for person_16 and person_24 are not accurately labeled. It's just a visualization issue?

In COCO standard there is a concept for keypoint visibility (self-occlusion and occlusion by other objects). We follow the same standard in our keypoint labeling. In the Unity Editor's visualization, the keypoints that are occluded are not shown. For more information please refer to the PeopleSansPeople paper and COCO.


Consider an in memory list of volumes in the plugin server.

When we do a volume list, the plugin server does a os.listdir() and goes about removing ".vmdk" in each virtual disk file name. Rather than do it this way, consider maintaining a list of volume names in memory. On plugin startup populate the list from the volume directory, update/delete on createVMDK()/removeVMDK(), list() simply returns this list.
Each list() call doesn't have to keep going to disk and reading large directory listings (which can grow to large numbers of files as volumes are created) and processing each disk name,

Get has been implemented for the server and  create does a get vs. a list. Closing this issue unless a fresh test shows a performance issue.