NavigationLink presented in top level controller with sheet presentation and custom navigation controller

Steps to reproduce:

Push
Present
Push

Expected result: view pushed inside the sheet
Actual result: view pushed in the root controller
https://github.com/nathantannar4/Transmission/assets/6103621/6e5e81e8-f633-4227-9fb6-3dc52857a7e6
struct Test: View {
    @State var flag = false

    var body: some View {
        NavigationContainer {
            VStack {
                Button("present") {
                    withAnimation {
                        flag = true
                    }
                }
                NavigationLink("push") {
                    Test()
                }
            }
            .presentation(
                transition: .sheet(
                    options: .init(
                        detents: .init([.medium])
                    )
                ),
                isPresented: $flag
            ) {
                Test()
            }
        }
    }
}

struct NavigationContainer<Content: View>: UIViewControllerRepresentable {
    @ViewBuilder let content: () -> Content

    func makeUIViewController(context: Context) -> UINavigationController {
        UINavigationController(rootViewController: UIHostingController(rootView: content()))
    }

    func updateUIViewController(_ uiViewController: UINavigationController, context: Context) {
    }
}

I think the newer NavigationLink(_ value: Value) APIs are unsupported, those are only expected to work with NavigationStack since it requires a navigationDestination to be registered.

I think the newer NavigationLink(_ value: Value) APIs are unsupported, those are only expected to work with NavigationStack since it requires a navigationDestination to be registered.

this is not new NavigationLink version, this one uses string as button title. NavigationLink(isActive works the same here.
with system sheet NavigationLink's button becomes disabled, displaying that it's not available in this context - it seems to be ignoring sheet navigation controller.. Maybe we would have to implement our version of  NavigationLink to keep custom navigation working

Oh yes you're right. Hmm I could have sworn this used to work.

Ah ok so I'm not sure how to fix this use case given that NavigationLink is a SwiftUI type. But the example that demonstrates this issue is not a "real world" use case example. This is because the NavigationLink pushes another instance of Test which creates a 2nd NavigationContainer. So something about this doubly nested UINavigationController messes up SwiftUI's NavigationLink.
The code example below works as expected. Notice the NavigationLink does not push a new NavigationContainer, only the PresentationLink
struct Issue20: View {
    var body: some View {
        NavigationContainer {
            NavigationLink {
                PresentationLink(
                    transition: .sheet(detents: [.medium])
                ) {
                    NavigationContainer {
                        NavigationLink {
                            Color.red
                        } label: {
                            Text("push")
                        }
                    }
                } label: {
                    Text("present")
                }
            } label: {
                Text("push")
            }
        }
    }
}

You're right, my original code was not real world - it was kind of a luck that it reproduced the issue =)
But the bug is not related to two nested navigation controllers, is't just about UIViewControllerRepresentable inside navigation controller - and that's what we have in real world.
struct ContentView: View {
    @State var isPresented = false

    var body: some View {
        NavigationContainer {
            TestController()
        }
    }
}

struct TestController: UIViewControllerRepresentable {
    func makeUIViewController(context: Context) -> UIViewController {
        UIHostingController(rootView: Test())
    }

    func updateUIViewController(_ uiViewController: UIViewController, context: Context) {

    }
}

struct Test: View {
    @State var flag = false

    var body: some View {
        VStack {
            Button("present") {
                withAnimation {
                    flag = true
                }
            }
            NavigationLink("push") {
                TestController()
            }
        }
        .presentation(
            transition: .sheet(
                options: .init(
                    detents: .init([.medium])
                )
            ),
            isPresented: $flag
        ) {
            NavigationContainer {
                TestController()
            }
        }
    }
}

This appears to just be broken SwiftUI.NavigationLink behaviour. You could use transmissions DestinationLink as a replacement. I fixed the delegate stuff you had messaged me about.
struct Issue20: View {
    var body: some View {
        NavigationView {
            VStack {
                SheetLink()

                NavigationLink("push") {
                    SheetLink()
                }
            }
        }
    }

    struct SheetLink: View {
        @State var isPresented = false

        var body: some View {
            Button("present") {
                withAnimation {
                    isPresented = true
                }
            }
            .sheet(isPresented: $isPresented) {
                NavigationContainer {
                    NavigationLink("push") {
                        Text("Hello, World")
                    }
                }
            }
        }
    }

    struct NavigationContainer<Content: View>: UIViewControllerRepresentable {
        let content: Content

        init(@ViewBuilder content: () -> Content) {
            self.content = content()
        }

        func makeUIViewController(context: Context) -> UINavigationController {
            let uiViewController = UINavigationController(rootViewController: UIHostingController(rootView: content))
            return uiViewController
        }

        func updateUIViewController(_ uiViewController: UINavigationController, context: Context) { }
    }
}

NavigationLink seems pretty broken in a few situations. Partially why I created DestinationLink for direct control. In 1.0.4 I fixed the delegate issue you mentioned.
NavigationLink is very broken even for the standard .sheet modifier, but for transmission it breaks when a Container is added as the root view of the NavigationLink. SwiftUI must mess something up.
struct Issue20: View {
    var body: some View {
        NavigationContainer {
            VStack {
                NavigationLink("push (broken)") {
                    Container { // <-- This causes issues
                        SheetLink()
                    }
                }

                NavigationLink("push") {
                    SheetLink()
                }
            }
        }
    }

    struct SheetLink: View {
        @State var isPresented = false

        var body: some View {
            HStack {
                Button("present w/ default (broken)") {
                    withAnimation {
                        isPresented = true
                    }
                }
                .sheet(
                    isPresented: $isPresented
                ) {
                    destination
                }

                PresentationLink(
                    transition: .sheet(detents: [.medium])
                ) {
                    destination
                } label: {
                    Text("present w/ transmission (working)")
                }
            }
        }

        var destination: some View {
            NavigationContainer {
                NavigationLink("push") {
                    Text("Hello, World")
                }
            }
        }
    }

    struct NavigationContainer<Content: View>: UIViewControllerRepresentable {
        let content: Content

        init(@ViewBuilder content: () -> Content) {
            self.content = content()
        }

        func makeUIViewController(context: Context) -> UINavigationController {
            let uiViewController = UINavigationController(rootViewController: UIHostingController(rootView: content))
            return uiViewController
        }

        func updateUIViewController(_ uiViewController: UINavigationController, context: Context) { }
    }

    struct Container<Content: View>: UIViewControllerRepresentable {
        let content: Content

        init(@ViewBuilder content: () -> Content) {
            self.content = content()
        }

        func makeUIViewController(context: Context) -> UIHostingController<Content> {
            let uiViewController = UIHostingController(rootView: content)
            return uiViewController
        }

        func updateUIViewController(_ uiViewController: UIHostingController<Content>, context: Context) { }
    }
}

What is the purpose of your TestController? I did find that if I swap it for a UIViewRepresentable then the issue does not reproduce.
struct Container<Content: View>: UIViewRepresentable {
        let content: Content

        init(@ViewBuilder content: () -> Content) {
            self.content = content()
        }

        func makeUIView(context: Context) -> _UIHostingView<Content> {
            let uiView = _UIHostingView(rootView: content)
            return uiView
        }

        func updateUIView(_ uiView: _UIHostingView<Content>, context: Context) { }
    }

In real life TestController is chat conversation controller that contains collection view and a bunch of UIKit stuff around it, not sure if it's going to be easy to convert it to UIViewRepresentable.
The updated DestinationLink seems to work fine, thanks! One last thing with it is that it overrides the background color set by NavigationContainer - I added an environment variable which I use to determine which value to pass to transition: .default(options: .init(preferredPresentationBackgroundColor: , it's fine, not sure if lib needs a change at this point.


[ERR:UH0703] Internal Error: adding wrong object type (ref_obj) in a property_expr_group group!

I receive the following error when parsing the SweRV EH1 core:
[ERR:UH0703] Internal Error: adding wrong object type (ref_obj) in a property_expr_group group!
Steps to repro:

git clone https://github.com/chipsalliance/Cores-SweRV.git
cd Cores-SweRV
export RV_ROOT=$PWD
Generate a valid config: ./configs/swerv.config
The SweRV core project uses generated defines that are not explicitly included in each file, and I don't see a way for Surelog to read a file full of   `defines and apply that to all files (separate issue?). As a workaround, prepend an explicit include to each design file:
find design/ -name '*.sv' -exec sed -i '1s/^/`include "common_defines.vh"\n/' {} \;
sed -i '1s/^/`include "common_defines.vh"\n/' design/include/global.h
Parse with Surelog's helloworld using the included surelog.f.txt file:
hellosureworld -parse -f surelog.f.txt | grep ERR

Hi there,
first of all, Surelog can parse both Verilog semantics:

The interpreted mode for which a define is valid from the time it is defined until the end of compilation or when it is undefined
The fileunit compilation where each file only sees the define included in that file

By default, Surelog does compile like the interpreted mode, you need to specify -fileunit option to compile each source file as an independent file unit.
Please check which Verilog semantic you want and command line option you are using,

Ok - I can look into that separately. I did try to add the .vh file as a source file at the start of the .f without -fileunit, but it didn't seem to make any difference.
But anyway, for the purposes of this issue, the internal error is problem at hand.

I see.
Properties are only handled in a primitive fashion in Surelog at this point.
If your intent is to Synthesize/Simulate the design, then ignore the error.
If your intent is to analyze the property in the design in some fashion then we need to finish the property modeling in Surelog/UHDM.
Please specify your intent.

Ok thanks for the context. I don't need to do anything with properties, just trying to browse the elaborated synthesizable design.
Is there a way for the API to expose the fact that an internal error is due to the limited property support?  I'd like to safely programmatically ignore this kind of error.

No way for the API to tell you that the modeling is unfinished business. What you get is the error you see.
Non-Synthesizable constructs like Constraints, Properties, Sequences, Classes are only very partially modeled in Surelog at this point, so they'll give out these errors or no errors (silently mishandled), until someone gets to finish that work. Note that all the constructs I just mentioned are actually parsed, but not modeled in UHDM.

The sure way to get rid of the error is to complete the modeling.


Update DeleteNotificationConfigSnippets.g.cs

Fix typo in the region tag, removing an extraneous "]". The region tag should work after this fix.

This is a trivial change, and failures in CI are not related. I'm force merging.


ENH: More work on Corrmap

See #1985 and discussion there.
I've only fixed a few minor things that went broke with the streamlining done by @dengemann and @Eric89GXL.
Passes tests on my machine, and works on my sample data.
Anybody wanna give it a try?

@Eric89GXL We currently have keywords plot and show. Shouldn't it be only show, or am I missing the rationale behind what you did there?

IIRC someone at some point wanted the functionality without any plots being made, thus the plot option. Even doing the plots without showing them could incur some overhead. This suggests to me that the two bits of functionality should be separated (promotes orthogonality of the functions), but I'm not actually very familiar with what it does.

I guess there could be a situation where you want the figures constructed, but only plotted later, in a different context, but right now, to me it seems mostly confusing to have both keywords.

the rationale is:

if function / method starts with plot_ then we need a show param.
if it's a function that runs numerics and can plot something for visual
inspection then use a plot param

ok?

I'm repeatedly coming across situations where I'd like to tell other users of MNE to use corrmap. I forgot, did we have any reservations regarding merging this once cleaned up, and which? It is after all an experimentally verified algorithm. @agramfort

No I don't think so. We can merge it.  I probably don't understand all of them. I'd like to continue working only with code I actually roughly understand the implications of, would it be possible to stash all of the changes irrelevant to corrmap?

The test_import_nesting.py changes were necessary in order to get tests to pass on this branch, so they need to stay. The changes to cov.py are pretty minor (overriding copy method) so I wouldn't worry about that one. I think if you don't touch either of those changesets you should be fine to continue working on the other bits.

There we are. I didn't really do anything but catch up with master.

Merge please? :)

@jona-sassenhagen for future reference we prefer rebasing to merging. I'll let @dengemann or @agramfort have a look and merge if they're happy.

There is 1 error in one of the Travis checks:
ERROR: Test fieldtrip_client
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/testenv/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
	self.test(*self.arg)
  File "/home/travis/build/mne-tools/mne-python/mne/utils.py", line 622, in dec
	return function(*args, **kwargs)
  File "/home/travis/build/mne-tools/mne-python/mne/realtime/tests/test_fieldtrip_client.py", line 55, in test_fieldtrip_client
	tmax=5, wait_max=1) as rt_client:
  File "/home/travis/build/mne-tools/mne-python/mne/realtime/fieldtrip_client.py", line 91, in __enter__
	raise RuntimeError('Could not connect to FieldTrip Buffer')
RuntimeError: Could not connect to FieldTrip Buffer

Rest is okay. I think the error is not about the actual code?

@jona-sassenhagen you should squash all commits into one to make sure the diff is up to date and history is clean.

Squash by author though so blame works, right @agramfort?

If you can. Or everything in one if its a pain

On 4 oct. 2015, at 15:28, Eric Larson<EMAIL_ADDRESS>wrote:
Squash by author though so blame works, right @agramfort?
—
Reply to this email directly or view it on GitHub.

It has the side effect of showing a diagnostics plot, but its primary purpose is modifying ICA objects.

ok. In the example please make the show=True param explicit.

Soooo ... what exactly do I do to squash?
git reset --soft HEAD~3000
git commit -m "squash"

?
This is what Google tells me.

have a look at
http://blog.houen.net/git-large-rebase-made-simple-easy-painless/

Ok so I create a new branch, merge in this branch, reset, merge, and then make a new PR for it?

Don't open a new PR. Just force push

On 4 oct. 2015, at 22:49, jona-sassenhagen<EMAIL_ADDRESS>wrote:
Ok so I create a new branch, merge in this branch, reset, merge, and then make a new PR for it?
—
Reply to this email directly or view it on GitHub.

I think that was it? Thanks @agramfort

Done.

@jona-sassenhagen it looks like your squash commit, and your latest commit (but not the three in between) don't link to your user account properly. Perhaps you are developing on two machines/logins where one does not have the git user info configured improperly?

Yes, I've been using an alternative computer for some of these, is that a problem?

It will make it so things like git blame and GitHub links don't work properly, so it would be good but not critical if you could fix it.

You can develop in as many places as you want so long as the git user information is configured properly in all those places.

Ok I'm setting it up on all computers I could potentially use, is there a simple way to make the already pushed stuff point to me?

You can re-squash if you want. Now that the merges are gone you can do it with git rebase -i HEAD~5, and then set all but the first commit to be s or squash instead of pick, and the latter 4 commits will be combined with the first. Then you can push force. As usual I recommend backing up your branch before doing that, though :)

Nah let's do it as-is :)

Sorry I'm still terrible at git.

@jona-sassenhagen it looks like there is something wrong, there is a conflict and there is a merge that shouldn't be there :(

... Can you maybe take over from the last commit before what I did today? There was a merge conflict, but it was just whats_new. Sorry.

Which commits are the right ones to take? I can't quite tell from the history.

Or should I just re-squash all the changes?

70d3895 is the one - just whats_new needs a fix.

Hmm, cherry-picking that one I get a conflicts outside of whats_new.py, including in ica. Is that expected?

When I checkout 70d3895 and merge in master now, I get a merge conflict in whats_new and in mne/tests/test_utils.py. The test_utils one should be simple: the import from mne.utils in line 10-20 shoudl be
from mne.utils import (set_log_level, set_log_file, _TempDir,
                       get_config, set_config, deprecated, _fetch_file,
                       sum_squared, estimate_rank,
                       _url_to_local_path, sizeof_fmt, _check_subject,
                       _check_type_picks, object_hash, object_diff,
                       requires_good_network, run_tests_if_main, md5sum,
                       ArgvSetter, _memory_usage, check_random_state,
                       _check_mayavi_version, requires_mayavi,
                       set_memmap_min_size, _get_stim_channel, _check_fname,
                       create_slices, _time_mask, random_permutation,
                      get_call_line, verbose, compute_corr)

ica.py is merged in without problems.

Ohhh, it's not just that one commit, it's that commit and the ones that precede it. I thought you had squashed it all down to one.

Sorry, no. That's what I mean - everything up to 70d3895.

@jona-sassenhagen I have the new version up on my fork Eric89GXL under the branch corrmap. If you do something like this, it will update this PR:
git checkout patch-8
git fetch Eric89GXL
git reset --hard Eric89GXL/corrmap
git push origin --force patch-8

Or you can give me push access to your repo and I'll push it there.

@jona-sassenhagen pushed, we'll see if the CIs are happy. Ready to go from your end if it is?

Yup. I can't think of a use case I haven't covered. Thanks.

@agramfort or @dengemann did either of you want to look again, or okay for merge from you?

@jona-sassenhagen Travis fails because of a couple of style things, I'll push a fix

CIs are happy, +1 for merge from my end.

Nice.

thanks guys !

Thanks!

thanks @jona-sassenhagen! looking forward to using it

and @Eric89GXL :)

Amazing, finally merged. Thanks @jona-sassenhagen !


chore(bolt-sidecar): fix lints

Ran cargo clippy locally and CI is running cargo clippy --all-targets --all-features -- -D warnings

It would be nice to add quick recipes for linting in the justfile, something like
clippy package:
	cd {{ package }} && cargo clippy --all-targets --all-features -- -D warnings

so we can do just clippy bolt-sidecar

It would be nice to add quick recipes for linting in the justfile, something like
clippy package:
	cd {{ package }} && cargo clippy --all-targets --all-features -- -D warnings

so we can do just clippy bolt-sidecar

Great idea!
https://github.com/chainbound/bolt/pull/436

@estensen @merklefruit you could even install this in a pre-commit hook

yes, but let's improve it one commit at a time

Not sure why I'm not able to repro failures locally
rustc 1.82.0 (f6e511eec 2024-10-15)

Not sure why I'm not able to repro failures locally
rustc 1.82.0 (f6e511eec 2024-10-15)

same


Please Update Wiki with Instructions for Browser Use

It is unclear how to use graphlib.js in a browser. It would be great to update the wiki with instructions on how to use it within a browser.

Attempting to call require reasonably throws an undefined error.
Attempting to load the js and instantiate Graph throws an undefined error.
Attempting to instantiate Graph in body onLoad handler throws an undefined error.

Steps to reproduce:
Download graphlib.js locally:
wget "https://cpettitt.github.io/project/graphlib/latest/graphlib.js"

Create index.html:
<!DOCTYPE html>
<html>
<head>
  <title>graphlib test</title>
  <script src="graphlib.js"></script>
</head>

<body>
    graphlib
  <script>
    var g = new Graph();
    console.log(g);
  </script>

</body>

</html>

Observe error:
Uncaught ReferenceError: Graph is not defined

Hi Gardner,
I suspect you've figured this out yourself at this stage, but I've updated the Wiki with browser instructions as you've suggested. You need to add the graphlib prefix so var g = new graphlib.Graph();
Regards,
Steve.

thanks @stevebarry

Thanks for the wiki update @stevebarry!


Runelite crashes upon entering Stronghold of Security and other dungeons.

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
When Runelite is running and I enter a dungeon, it crashes, however running OSRS normally does not reproduce this crash.
To Reproduce
Steps to reproduce the behavior:

Go to Stronghold of Security

Expected behavior
I expected Runelite not to crash upon entering a dungeon, but instead it does.
Screenshots
Not applicable.
Environment (please complete the following information):

OS: Windows 10, 64 bit
RuneLite version: 1.5.32
Launcher version: Latest

Additional context
Latest client and launcher logs included as files.
client.log
launcher.log

I'd love it if someone could tell me if this is an issue on my end or if it's a known bug that others are having, I can't stand playing Old School without Runelite ever since I tried it out.

Seems like it's a problem with the GPU plugin, had the same problem and solved it by disabling it.


Implicit m-n relations have an extra @relation field after introspection

Bug description
On introspecting a m-n implict relation, an extra @relation field is added that isn't added while using Migrate.
How to reproduce

Seed the following SQL in the database

CREATE TABLE "public"."Student" (
"id" SERIAL,
"name" text  NOT NULL ,
    PRIMARY KEY ("id"))

CREATE TABLE "public"."Course" (
"id" SERIAL,
"name" text  NOT NULL ,
    PRIMARY KEY ("id"))

CREATE TABLE "public"."_CourseToStudent" (
"A" integer  NOT NULL ,
"B" integer  NOT NULL )

CREATE UNIQUE INDEX "_CourseToStudent_AB_unique" ON "public"."_CourseToStudent"("A","B")

CREATE  INDEX "_CourseToStudent_B_index" ON "public"."_CourseToStudent"("B")

ALTER TABLE "public"."_CourseToStudent" ADD FOREIGN KEY ("A")REFERENCES "public"."Course"("id") ON DELETE CASCADE  ON UPDATE CASCADE

ALTER TABLE "public"."_CourseToStudent" ADD FOREIGN KEY ("B")REFERENCES "public"."Student"("id") ON DELETE CASCADE  ON UPDATE CASCADE

Running prisma introspect --experimental-reintrospection produces the following schema:

model Course {
  id      Int       @default(autoincrement()) @id
  name    String
  Student Student[] @relation(references: [id])
}

model Student {
  id     Int      @default(autoincrement()) @id
  name   String
  Course Course[] @relation(references: [id])
}

The below schema works with Migrate without a @relation field added.

model Student {
  id      Int      @default(autoincrement()) @id
  name    String
  Course Course[]
}

model Course {
  id      Int       @default(autoincrement()) @id
  name    String
  Student Student[]
}

Expected behavior
The relation field shouldn't be explicitly added for implicit m-n relations.
Environment & setup

OS: Debian
Database: PostgreSQL
Prisma version: 2.2.0
Node.js version: 12.18.1

Conversation with @mavilein and @do4gr showed that this is an outdated opinionation in our renderer that was correct in the past, but is now not any more - those @realation attributes do not need to be there any more.


UI Button: Colors

Description
Dashboard 1.0 offers customisation on the text and background colour of the button. Dashboard 2.0 should do this too.
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

I changed all my buttons (still dashboard 1) so that they now use css classes and no more the two color options.
So from  my point of view these two parameters are no longer needed; also they does not really fit in to the whole concept.


One-file exe work well local side, work not good on network path.

I made a tool for web crawler (not use --headless mode) and use nuitka to make it an one-file .exe file with:
nuitka --lto=no --standalone --plugin-enable=pyqt5 --onefile --include-package-data=selenium --disable-console --output-dir=BIOS --remove-output --windows-icon-from-ico=webcrawler.ico WindowController.py
After make it an .exe file (without window console), it works fine at local side (e.g. my PC) (work fine means it can display the GUI I created with Pyqt5 and press the button on it to show the browser and do the crawler task). But when I move the .exe from local to the network path (e.g. \srv\folder\python\crawler.exe) and run, it can jsut show the GUI and unable to do the crawler task (did not show the browser when press the button).
I thought maybe the disable console instruction caused the issue so I tried to remove the --disable-console and made .exe again.
After this, it works well both on local side and the network path. Although it can work on network path, it is still annoying there is a window console when users use it. So I want to figure it out why/what will cause this issue?
*(For some reasons, I prefer run the .exe on the network path.)
I have also tried nuitka 1.8.6 and nuitka 2.1.3 but got the same result.
I guess the issue will be relative with Seleium 4.10.0 and webdriver-manager 4.0.1 because my previous tool without these 2 packages didn't cause the "window console" issue on the network path. Here is code snippet:
from selenium import webdriver
from selenium.webdriver.chrome.options import Options
from selenium.webdriver.chrome.service import Service
from webdriver_manager.chrome import ChromeDriverManager

chrome_service = Service(ChromeDriverManager().install())
driver = webdriver.Chrome(service = chrome_service)

Main Python Package
Nuitka                       2.2
numpy                      1.25.1
openpyxl                   3.0.10
pandas                      1.5.3
PyQt5                        5.15.9
selenium                   4.10.0
webdriver-manager  4.0.1
Nuitka
2.2
Commercial: None
Python: 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 bit (AMD64)]
Flavor: CPython Official
Executable: D:\PyWorkSpace\Python_Project\venv_UITool\Scripts\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x64\cl.exe (cl 14.1).

Can you before reporting a Nuitka issue first make sure the Python program works when used in the same way? Or if that is not possible, reduce the issue to something that is reproducible by me without too much effort. If you can e.g. demonstrate the the forking of some executable on a network path works in Python but not in Nuitka on a network path, that would be a report, but I am not going to go out and figure out what your issue is for you between these things. I guess using a virtualenv on a network and demonstrating that to work might be enough there, provided the drivers are download to in in there too.

Thank for your reply. I will try to make a easy script to test what I have mentioned.
Briefly,

the tool with --disable-console:

local side: able to open the GUI and do crawler tasks
network path: able to open the GUI but unable to do crawler tasks

the tool without --disable-console:

Both local side and network path are able to open the GUI and do the crawler tasks

So, based on the scenario, I just thought if the --disable-console got conflict with Selenium 4.10 and webdriver-manager 4.0.1.
Anyway, I will use a easy script to test in a few days.

Don't make promises about what you will do, tell what you done in the next issue you open with the information gathered.


Incorrect file is reverted when multiple files have been uploaded and the instantUpload options is disabled

Summary
When the option instantUpload is set to false and multiple files have been uploaded, reverting any of the files causes the first file to be reverted.
How to reproduce
Configuration

allowMultiple: true
instantUpload: false
allowRevert: true

Add multiple files and upload them all.
click the "undo" button on the second file

Expected behaviour
The correct file is reverted.
Additional information
The issue seems to be caused by line number 4842. When instantUpload is disabled the 'REVERT_ITEM_PROCESSING' event is dispatched without any arguments. I assume that because the item.id is excluded that the default behaviour is to revert the first item.

Environment
Version

OS
Windows 10

Device
Desktop PC

Browser
Chrome 70.0.3538.102

You're absolutely right, tested and confirmed the problem.
Published version 3.3.2 just now, should fix the issue (does so in my tests).

Thank you. I can confirm that the issue has been resolved.


Running Firefox in the network namespace doesn't recover from network outages

Thanks very much for wg-netns - I am using it on two machines to help share my VPN connection.
I love the trick of running Firefox in the network namespace and in general it works well. But I've noticed that if my network connection goes down and comes back up (because it's crap and it just does that sometimes, or because the machine has been suspended and resumed), the Firefox running in the network namespace seems to permanently lose network access. The wireguard connection inside the network namespace seems fine when this happens - I can "exec" into the namespace and ping things, and other processes on my machine using the wireguard connection work fine. It's just the Firefox in the network namespace that doesn't recover.
On a possibly related note, I also tried running Mullvad Browser in the network namespace and couldn't get it to work at all.
Do you have any idea what might be going on or how this can be fixed? It's not the end of the world but it's a bit annoying to have to restart that Firefox after every network outage.

Sorry, but I don't know what cloud cause this behavior.

Thanks for getting back to me anyway, it's appreciated.
I am convinced there is a genuine issue here (albeit probably not one with wg-netns - I just hoped you might have some idea), but for what it's worth my machine suspended for an hour or so earlier today without the network namespace Firefox experiencing any problems. So the triggering event is probably not quite as simple as I described it above.

Good luck getting to the bottom of this :)


no warning when uploading nonvalid file

When uploading a file that is not an image or not a supported file format (e.g. PDF) no warning is given.
Specify supported fileformats in opening screen?
Validity check of uploaded file?

We will add this

this features has been added


Optimized integration test case DockerSuite.TestBuildUsersAndGroups fixes #19425

Fixes #19425 test case DockerSuite.TestBuildUsersAndGroups. Removed unnecessary RUN statements and combined some of the RUN statements into a single line. The run-time performance is seen as follows:
pre-change:
PASS: docker_cli_build_test.go:3826: DockerSuite.TestBuildUsersAndGroups  63.074s
post-change:
PASS: docker_cli_build_test.go:3826: DockerSuite.TestBuildUsersAndGroups  49.698s
Signed-off-by: Anil Belur<EMAIL_ADDRESS>

LGTM

LGTM


Add POC advice2 app.

Would like to see an example of what using crispy forms within this app would look like.

Would also like to see an example of a form making an API call.


An extra '.' shows next to the localized tooltip of the 'Copy' button in the Shared Access Signature dialog

Storage Explorer Version: 1.17.0
Build: 20201222.4
Branch: main
Platform/OS: Windows 10/ Linux Ubuntu 16.04 / MacOS Catalina
Architecture: ia32/x64
Language: Spanish/ Russian
Regression From: Not a regression
Steps to Reproduce

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select 'Español' -> Restart Storage Explorer.
Open one storage account -> Select one blob container -> Click 'Get Shared Access Policies...' -> Click 'Create'.
Hover over the localized button 'Copy' of the URI.
Check whether an extra '.' shows next to the tooltip.

Expected Experience
No extra '.' shows next to the tooltip.
Actual Experience
An extra '.' shows next to the tooltip.

Additional Context

This issue doesn't reproduce for the localized tooltip of the 'Query string' in the Shared Access Signature dialog.

This issue also reproduces for the localized tooltip of the 'Query string' on Russian.

This issue also reproduces for one file share/ queue/ table.

If there is a '.' in the english string, then there should be one in non-english, otherwise no '.'.

If there is a '.' in the english string, then there should be one in non-english, otherwise no '.'.

The extra . has been removed....but that only happened because the string changed and has been reset back to English. Will swing back around in a few weeks to double check on this.

Everything looks translated, and none of them have periods at the end (which is fine).

Verified on build 20210428.4. This issue has been fixed on 'Spanish' language.
But it is still reproduces for the localized tooltip of the 'Query string' on Russian. So we re-open it.😀


Values for X509ExtensionOid.CertTemplateInfoV2 and X509ExtensionOid.CertificateTemplate should be swapped.

https://github.com/PKISolutions/pkix.net/blob/5e50edda88ef9348403a1acf08b055b97075bf5b/PKI/Cryptography/X509Certificates/X509ExtensionOid.cs#L11-L16
CertificateTemplate should be : <IP_ADDRESS>.4.1.311.20.2
CertTemplateInfoV2 should be : <IP_ADDRESS>.4.1.311.21.7

fixed

one more thing: V2 template value is wrong as well. Should be <IP_ADDRESS>.4.1.311.21.7

It's fixed in previous commit: https://github.com/PKISolutions/pkix.net/commit/d106ca1cd4dadcaa3681875df9201a6348229f2b


feat: setting timeout for postgrest-py client

postgrest-py accepts a timeout parameter from v0.8.0
Added thetimeout option for the postgrest client and made it optional, with a defaulf of 5sec.
@anand2312 @J0 @dreinon @leynier
Closes #225

Closes #225

Closes #225 Edit: Whoops that didnt't work as I expected -- can you edit your PR description and add Closes #225  to it so that the issue is linked with this PR please?

okay sure!

I this getting merged?? @anand2312

Is there an update on this PR? Alternatively how can I adjust the timeout for the client in the mean time? I've tried the methods prescribed here, but I'm still hitting a 5s timeout (it's preventing me from querying any data from a large view)

Hey could we trouble you to run isort And black so the tests pass as well?
Thanks!

Is there an update on this PR? Alternatively how can I adjust the timeout for the client in the mean time? I've tried the methods prescribed here, but I'm still hitting a 5s timeout (it's preventing me from querying any data from a large view)

Hey man, If there is any issue then it coming from the postgrest-py lib. All I have done is updated the code to pass a timeout argument to the postgrest-py client like you'd see here

Hey @keosariel,
Thanks for the PR! Appreciate the contribution :) We've merged @mohnish7 's extension of this pull and will be closing this for now.
Let us know if you have any further questions/issues


[BUG] Bad Performance

Describe the bug
On my work project it slows down the build very much. From about 0.45s to 4min.
To Reproduce
Steps to reproduce the behavior:
Set plugin:tailwindcss/recommended to .eslintrc
Environment (please complete the following information):

OS: macOS
Softwares + version used:

node v16.13.0

Additional context
Add any other context about the problem here.
eslint config file or live demo
{
  "extends": [
    "plugin:@typescript-eslint/recommended",
    "plugin:react/recommended",
    "plugin:import/typescript",
    "plugin:@next/next/recommended",
    "plugin:tailwindcss/recommended"
  ],
  "plugins": [
    "@typescript-eslint",
    "react-hooks",
    "immutable",
    "import",
    "@next/eslint-plugin-next",
    "disable-autofix",
    "tailwindcss"
  ],
  "env": {
    "browser": true,
    "node": true
  },
  "parserOptions": {
    "ecmaVersion": 2018,
    "sourceType": "module",
    "project": "./tsconfig.json",
    "ecmaFeatures": { "jsx": true }
  },
  "rules": {
    ...
  },
  "settings": {
    "react": { "version": "detect" },
    "tailwindcss": { "callees": ["mergeClassnames"] }
  }
}

Hi
Difficult to tell what’s wrong without a demo project but I’m guessing it could be related to the parsing of CSS files.
Do you use a lot of CSS files ? Try providing a short/restricted list of CSS files via the globs option
https://github.com/francoismassart/eslint-plugin-tailwindcss/blob/master/docs/rules/no-custom-classname.md#cssfiles-default-css-node_modules--dist-build

@francoismassart We don't use css files, but styled-components. We migrate to tailwind. Could this be causing a problem?

A demo project demonstrating the issue could really help. Without it, I can’t really help as most users do not get these huge build times.
Maybe try proving an empty array for the cssFiles option…

Ok, I will try to provide smt

Closing the issue, please re-open it if you can provide a minimalist project demonstrating the issue.
Performances seems acceptable for most of the other users of the plug-in.


feat: add capability to purge old histogram data

What

add purge_timeout option to PrometheusBuilder
run a purger that purges based on the purge_timeout

Implements third way as prescribed here to purge old histogram data:

update the builder to generate a future which both drives the Hyper server future as well as a call to get_recent_metrics on an interval

Fixes https://github.com/metrics-rs/metrics/issues/245

As I read back through what I originally wrote... I think a major flaw with my proposal to do this by periodically calling render is that we would actually also handle things like expiration, which could lead to subsequent scrapes/pushes missing data.
I think what we'd actually have to do here is split the logic out of get_recent_metrics that handles draining the histograms. Essentially, take this code and stick it into a new method on the struct -- let's call it run_upkeep for this example -- and trim it down so it only iterates through each histogram, finds/creates the entry in self.distributions, and then drains samples into the entry. After that, we'd add a call to that method right before this block, and in that block we'd remove the logic where it drains the histograms.
Does that make sense?

Thanks for the update!

I think a major flaw with my proposal to do this by periodically calling render is that we would actually also handle things like expiration, which could lead to subsequent scrapes/pushes missing data.

Does this refer to the self.recency.should_store_* call where we check the validity of a metric? If so then I think eagerly calling this method would be fine. It would be helpful to understand your concern with an example.

Thanks for the update!

I think a major flaw with my proposal to do this by periodically calling render is that we would actually also handle things like expiration, which could lead to subsequent scrapes/pushes missing data.

Does this refer to the self.recency.should_store_* call where we check the validity of a metric? If so then I think eagerly calling this method would be fine. It would be helpful to understand your concern with an example.

(Sorry for the delayed response here.)
Yes, you're right that this would be the crux of the concern.
The example would be something like:

the exporter is configured with an idle timeout of 10 seconds, and a purger interval of 5s
the exporter is scraped at t=0, which includes metric A
metric A is updated at t=5 (meaning it will go idle at t=15 if not updated by then)
the purger runs at t=5 and t=10 and since nothing is idle yet, all it ends up doing is draining the histogram buckets
the purger again runs at t=15, but now, metric A is considered idle, which removes metric A from the registry
the exporter is scraper at t=30, which now no longer includes metric A

Despite metric A being updated between the two scrapes at t=0 and t=30, we've actually missed the update to metric A, which if we were only rendering during scrapes, would have been included in the second scrape.

Despite metric A being updated between the two scrapes at t=0 and t=30, we've actually missed the update to metric A, which if we were only rendering during scrapes, would have been included in the second scrape.

Ah this makes sense once I checked documentation for PrometheusBuilder::idle_timeout:

This behavior is driven by requests to generate rendered output, and so metrics will not be removed unless a request has been made recently enough to prune the idle metrics.

I have separated out the purge action to only drain the histograms now.


remove reference to KIND_CLUSTER

This PR will align the docs with the the merged PR https://github.com/open-cluster-management/registration-operator/pull/103
Signed-off-by: Paolo Dettori<EMAIL_ADDRESS>

/ok-to-test

/lgtm


Error pathway_errorbar  "$<-.data.frame(*tmp*, "group", value = c(2L, 2L, 2L, 2L,  :    replacement has 20 rows, data has 1"

Good morning
I have one differentially abundant pathway between two groups and wish to plot it using the "pathway_errorbar":
p <- pathway_errorbar(abundance = kegg_abundance, daa_results_df = daa_annotated_sub_method_results_df, Group = metadata$state, p_values_threshold = 0.05, order = "pathway_class", select = NULL, ko_to_kegg = TRUE, p_value_bar = TRUE, colors = NULL, x_lab = "pathway_name")
ERROR
Error in $<-.data.frame(*tmp*, "group", value = c(2L, 2L, 2L, 2L,  :
replacement has 20 rows, data has 1
In addition: Warning message:
In cbind(sample = colnames(sub_relative_abundance_mat), group = Group,  :
number of rows of result is not a multiple of vector length (arg 2)
Environment Information:

Operating System: mac
R Version: R version 4.3.1
Package Version: 1.7.3

Did you resolve this issue? I am also using R on a Mac, and while it worked last year, I'm encountering this problem now when trying to regenerate the plots this year.

I did solve it, but can't remember how and did not make notes in the script. Sorry!

I am having the same error.

Hi @raqxavier and others experiencing this issue,
Thank you for reporting this. The error occurs when attempting to create an error bar plot with only one significant pathway. This is a known limitation in the current implementation. Here are several solutions:

Adjust p-value threshold to include more pathways:

p <- pathway_errorbar(
  abundance = kegg_abundance,
  daa_results_df = daa_annotated_sub_method_results_df,
  Group = metadata$state,
  p_values_threshold = 0.1,  # Higher threshold to include more pathways
  order = "pathway_class",
  select = NULL,
  ko_to_kegg = TRUE,
  p_value_bar = TRUE,
  colors = NULL,
  x_lab = "pathway_name"
)

Manually select multiple pathways:

# Get significant pathway
sig_pathway <- daa_annotated_sub_method_results_df %>%
  filter(p_adjust < 0.05) %>%
  pull(feature)

# Add pathways with next lowest p-values
additional_pathways <- daa_annotated_sub_method_results_df %>%
  arrange(p_adjust) %>%
  slice(1:3) %>%  # Get top 3 pathways
  pull(feature)

# Plot with selected pathways
p <- pathway_errorbar(
  abundance = kegg_abundance,
  daa_results_df = daa_annotated_sub_method_results_df,
  Group = metadata$state,
  p_values_threshold = 1,  # High threshold to include all selected
  order = "pathway_class",
  select = additional_pathways,
  ko_to_kegg = TRUE,
  p_value_bar = TRUE,
  colors = NULL,
  x_lab = "pathway_name"
)

Custom visualization for single pathway:

# For single pathway visualization
library(ggplot2)

# Get significant pathway data
sig_pathway_id <- daa_annotated_sub_method_results_df %>%
  filter(p_adjust < 0.05) %>%
  pull(feature)

sig_pathway_data <- data.frame(
  Abundance = as.numeric(kegg_abundance[sig_pathway_id,]),
  Group = metadata$state
)

# Create plot
p <- ggplot(sig_pathway_data, aes(x = Group, y = Abundance, fill = Group)) +
  geom_boxplot() +
  theme_bw() +
  ggtitle(sig_pathway_id) +
  theme(legend.position = "none")

Note: This limitation will be addressed in the next release to better handle single significant pathway cases. For now, please use one of these workarounds.
Please let me know if you need any clarification or encounter other issues!
Best regards,
Chen


Create a couple of validation tests

Create a few validation tests to automate CI and check new commits/pulls.

valdata folder added
runtests.py executes all the necessary tests and compare the results with the reference one
check v1.1


Please add CPU only machine support.

Please add CPU only machine support.

Hi! Please elaborate on what you mean by "CPU only machine support"? The more details you give us about your problem, the sooner we can start working on it

Currently the Fedot library can't run in CPU only mahine. I hope it can run
in future.
On Wed, 2 Mar, 2022, 10:13 am Mikhail Sarafanov, @.***>
wrote:

Hi! Please elaborate on what you mean by "CPU only machine support"? The
more details you give us about your problem, the sooner we can start
working on it
—
Reply to this email directly, view it on GitHub
https://github.com/nccr-itmo/FEDOT/issues/578#issuecomment-1056200171,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC6RPGLSR2KNWT4UWGFKKKDU53WXVANCNFSM5PMD57UA
.
You are receiving this because you authored the thread.Message ID:
@.***>

We ran FEDOT on only-CPU servers and had no problems. We have also run framework in containers where there is no access to GPU. Please describe your problem in more detail. The best way is to describe exactly how you ran the framework and what error you encountered

Closed since we can't reproduce this problem.


Installation error: pip._vendor.resolvelib.resolvers.ResolutionTooDeep: 200000

Describe the bug
Installing Data curator (from both PyPi and source) is not working. The error is
ERROR: Exception:
Traceback (most recent call last):
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 105, in _run_wrapper
    status = _inner_run()
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 96, in _inner_run
    return self.run(options, args)
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 67, in wrapper
    return func(self, options, args)
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 379, in run
    requirement_set = resolver.resolve(
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 95, in resolve
    result = self._result = resolver.resolve(
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_vendor/resolvelib/resolvers.py", line 546, in resolve
    state = resolution.resolve(requirements, max_rounds=max_rounds)
  File "/opt/conda/envs/nemo/lib/python3.10/site-packages/pip/_vendor/resolvelib/resolvers.py", line 457, in resolve
    raise ResolutionTooDeep(max_rounds)
pip._vendor.resolvelib.resolvers.ResolutionTooDeep: 200000

Steps/Code to reproduce bug
First I created a separate conda env for this package
conda create -n nemo python=3.10
conda activate nemo

Then I installed cython (which worked fine) using
pip install cython

Then all of the following methods throws the error
Installation from PyPi, CPU-only --> pip install nemo-curator
Installation from PyPi, CPU and CUDA-accelerated modules --> pip install --extra-index-url https://pypi.nvidia.com nemo-curator[cuda12x]
Installation from source, CPU and CUDA-accelerated modules --> pip install --extra-index-url https://pypi.nvidia.com ".[cuda12x]"

Expected behavior
Expected the commands to just display some kind of successful installation message.
Environment details
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:

OS version -- Ubuntu 22.04.5 LTS (GNU/Linux 6.8.0-1015-aws x86_64)
Python version -- 3.10.15
pip version -- 24.2

Pip version is 24.2

It is working now. Thanks!

Thanks for confirming. We've also released 0.4.1 to address this issue so you would no longer need to install spacy<3.8 manually.


Kwmc bind does not work

I have just compiled and installed kwm at release 2.0.0. Launchd starts kwm properly and I can also observe that the process uses my config (the example one present in this repo), but for some reason none of the keybindings work. I am running OSX 10.11.4.
I am not sure what am I missing, any advice?

2.0.0 or 2.0.1? on 2.0.1 there is a bug caused by the support for using fn as a mod key

2.0.0, but still I am not using the fn key.

There was some really weird issue where simply adding the code that checks for the fn key would cause issues for binds that does not use it. It really did not make any sense so I went ahead and removed it again.

Also, make sure that your terminal does not have enabled "Secure Keyboard Entry".

Disabling "Secure Keyboard Entry" solved my problem. Thank you.


Created cloud

You have downloaded a previous version of Developer branch. I am going to close this pulll request and merge developer branch with yours.


Use python typing module to have a separate type for ndarray[ObjRef]

Since we got rid of type information in #394, this is no longer be relevant.


Problem: eth_sender transaction's base fee is not capped

Solution:
add a cap to base fee

Don't understand why caps the base fee in the eth sender, can you give more context?
in EIP-1559, there is no definition of the base fee cap.

Due to an issue on testnet, the l2_gas_price is capped to 10k
While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000
In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send transactions when Ethereum gas_price is over 40gwei.
This is the idea of this cap.

Due to an issue on testnet, the l2_gas_price is capped to 10k While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000
In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send l1 transactions when Ethereum gas_price is over 40gwei.
This is the idea of this cap.

I see, so it's a temp solution before the oracle, and will be removed after integrated the oracle, right?


libkbfs: make TlfHandleExtensionStaticTestDate an exported constant

Going to be using this in server tests too...

Not sure if you're looking for a review, but looks good to me.

Thanks!


Retune roadrunnner with new robot

hopefully this isn't needed

it will be needed, the track width changed. will try to do today

retuned track width, might need to change kV and kA but leaving for now

reopening because dead wheels exist now, will tune tomorrow


[API] Invoices data is in ASC order

I hope I am posting this issue in the correct repository.
Currently, the API at https://api.linode.com/v4/account/invoices returns a list of data sorted in ascending order (oldest first).
I can see two options from here:
1- Sort the returned data with the newest first.
OR
2- Add a sort query parameter with options like ASC and DESC, allowing the user to sort the data as they prefer. (https://techdocs.akamai.com/linode-api/reference/get-invoices)
Thanks

Hi @mmarif4u, thanks for reaching out! Could you try these curl requests (and add your authorization token):
curl --request GET \
   --url 'https://api.linode.com/v4/account/invoices?page=1&page_size=100' \
   --header 'x-filter: {"+order":"desc","+order_by":"date"}' \
   --header 'accept: application/json' \

curl --request GET \
   --url 'https://api.linode.com/v4/account/invoices?page=1&page_size=100' \
   --header 'x-filter: {"+order":"asc","+order_by":"date"}' \
   --header 'accept: application/json' \

We were able to see the data being ordered by differently - I'll look into getting the tech docs updated to reflect this!

Glad that worked.
I've submitted an internal ticket to update the documentation for that endpoint. Will let you know when it gets updated

Not directly related to invoices, but still related to filters.
I was checking the Events endpoint and found that there is a read object, which can also be filtered.
https://techdocs.akamai.com/linode-api/reference/get-events
I tried using the +or and +and filters, but I had no success.
https://techdocs.akamai.com/linode-api/reference/filtering-and-sorting
Can you please help me understand how the filterable options can be used with the x-filter header?
Thanks

@mmarif4u Could you let me know the requests you're trying to send?

@coliu-akamai the following is the request with the auth and x-filter headers.
https://api.linode.com/v4/account/events?page=1&page_size=100
Filter header
x-filter: {"+or":[{"read":"true"}],"+order":"desc","+order_by":"date"}
I am trying to sort the events by the read status here.

Thanks @mmarif4u! I'm not seeing a date field for Events - did you mean to sort using the  created field?
{ "+order":"asc", "+order_by":"created" }
If you want all the Events where read is true, ordered by created, this should work:
{ "read": true, "+order":"desc", "+order_by":"created" }
I am seeing errors when I try to use "+or" or an explicit "+and" for this query when using the read field  -- let me check with the API team to see if they have any clarifications. The guide you linked is definitely the way to go for understanding filtering/sorting though!

@mmarif4u I checked with the API team - currently read is not able to be used in compound filters, but they are looking into the issue. I'll let you know when there are updates. 😄

Hi @mmarif4u, thanks for your patience. Unfortunately I'm not sure who to contact for this - I'd recommend reaching out to Akamai Compute support to see if they can help.
Going to close this issue - if you have new Cloud Manager related issues, please feel free to open a one. Thanks!


Modebus-Flex-Getter Node stops working every few hours - "initialize"

My Flex-Getter node stops working every few hours, sometimes after one or two days. It then only says "initialize". The problem has to be within node-red-contrib-modbus as a php script which logs data into a database from the same modbus device works without problems.
The workaround/solution is:

log into Node Red
open the flow
open the flex-getter node
open the modbus server
change some small detail (usually "Queue delay (ms)" one ms up or down)
update modbus server with this new setting
close flex-getter node
deploy

Flex-Getter node immediately changes it's state to "active" and data is coming in.
So if there is no approach to avoid flex-getter to stop working: Is there a way to automatically "restart" the connection like I always do manually?

You could try the Status node to solve it. Mostly such a behaviour lays in too much reads or too fast reading to one node or wrong flow designs. Maybe you could provide an overview of your physical reads and timing per Modbus Connection and Node, please?
Please, reopen if you need ore and fill out the template questions. We need version information and more about to reproduce it!


Documentation Request - How to enable scrollback?

I'd like to propose a wiki with instructions for building a scrollback enabled version of alacritty. Periodically, I try to rebuild Alacritty and I always forget that the project does not include scrollback in master. My guess is that many other users of this project would also value a canonical way to get a scrollback-enabled build as well, but perhaps I'm mistaken.
(I'd much prefer to have a cargo feature for toggling scrollback support at compile time, but I realize that adds a lot of ongoing complexity that may be not desirable.)

I don't think officially documenting how to build PRs is going to be beneficial. I'd much rather push for merging Scrollback into Master, since it has been progressing nicely and as far as I know there's only one major issue left.
There are still a few minor issues, but I'd consider them non-blocking. Having a PR as an acceptable version of Alacritty would just encourage keeping them separated imho.

It's an interesting question of what kinds of features should be Cargo features. I'm not sure what @jwilm or @chrisduerr think about making scrollback a compile-time option, but I personally wouldn't mind it. It does make packaging the application more complex however.

There's no benefit in making Scrollback a compile-time feature. It's too complex to make it completely opt-in and there is no disadvantage to just setting the history size to 0 if the code is always present anyways.
So while compile time options might make sense for other things, for scrollback it seems pointless to me.

Ok! Adding this to master makes sense to me, especially if scrollback does
not impact performance for those wishing to opt-out.
Totally agree, a cargo feature for this would make the code much, much more
complex and a wee bit horrible.
I'll close out this issue.


Disable submit item when not verified

When a new user hasn't verified their account yet, they are allowed to click and fill in the submit new item modal. After submitting, it takes you to a screen saying the account isn't verified yet. This way you'll lose your item that you wanted to submit.

Similarly, when you are not logged in you can type a comment that will be lost once the system forces you to authenticate.


Include API routes for Tools table

add: basic skeleton of methods for tools endpoint
add: delete route for tools
add: some update paths for tools, tests on params to those
add: tests for some tool routes and operations
add(test): figure out pytest_asyncio fixtures and add more route tests
add(test): finalize tests for tool routes

lgtm


minDate & showTodayButton can't work together

Hi there,
I can't set the date to now when I'm using the minDate option, and the Today button works fine if I remove that option.
I'd like to know how to solve this, thank you!

:laughing:
I've checked you source code.
I found your Today means the start of today ( moment().startOf('d');),
and my minDate was set to moment(),
so...Today button has no use when setting 'minDate` option to today( if it's not the start of that day).
I think we shoud add some tips on the options doc in case someone else get confused.


Consider Using asdf

Is there an existing issue for this?

[X] I have searched the existing issues

Code improvement description
Dependabot internally installs Python using pyenv, which releases with support for new Python versions approximately monthly. There is roughly comparable turnaround time for Dependabot to bump to the latest pyenv and Python versions, and Python often issues a patch release every 1-2 months. Taken together, this means that Dependabot rarely supports the latest version of Python. This is inherently problematic and will inevitably exacerbate the impact of Python security issues throughout the ecosystem. Ideally Dependabot would support the latest version of Python instantaneously upon its release. Furthermore, it means that users of Dependabot cannot use the version of Python pre-cached in GitHub-hosted runners, which is updated weekly. asdf can install the latest version of Python immediately upon its release, and there are asdf plugins for virtually every package manager, so Dependabot would no longer have to use separate package managers for separate package ecosystems.

We could also investigate how Python is installed in the GitHub hosted runners... as they may have prior art we could copy.

@Kurt-von-Laven as you've driven at least a few python updates for us (many thanks!) wondering if you'd have an opinion or knowledge around the requirement for us to be running the same patch version of python as the given repo/project?
I'm working on #6079 and from the testing I've done it seems sufficient to match major.minor for the python version. This would allow us to both be more performant (as we'd not need to compile a new python just in time) and we'd get broader support with less work, as we would only need to update when a new major.minor is released. I'd love any feedback you might have on the approach on the above PR, especially around the concern raised by @deivid-rodriguez.

Thanks for reaching out; this sounds like a great change, and I shared my thoughts on #6079.


Exporting magento customers using customer.rb gives a raise_invalid_response_error

when trying to export magento customers using the customers.rb script, I get the following error:
response.rb:90:in raise_invalid_response_error!': Unable to parse response body: (Savon::InvalidResponseError)
It seems like the response is coming in as an entire string. I see all the customer information but it is not parsed correctly. Here's a screenshot:

It continues to print through every customer until it hits a timeout error:
from /Users/chrismark/.rvm/gems/ruby-2.4.0/gems/savon-2.12.0/lib/savon/response.rb:72:in `find'
	from /Users/chrismark/.rvm/gems/ruby-2.4.0/gems/savon-2.12.0/lib/savon/response.rb:37:in `body'
	from customers.rb:82:in `customer_list'
	from customers.rb:67:in `block in customers_starting_with'
	from /Users/chrismark/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/timeout.rb:93:in `block in timeout'
	from /Users/chrismark/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/timeout.rb:103:in `timeout'
	from customers.rb:65:in `customers_starting_with'
	from customers.rb:59:in `base_customers'
	from customers.rb:24:in `print_customers'
	from customers.rb:12:in `run'
	from customers.rb:97:in `<main>'

orders.rb worked fine and authentication seems to work.

I ran it from the start and there was never a successful customer. It runs for a bit and is just a huge string with customer data. It happens on every run. I don't know if my savon gem is messed up, but it seems to work fine with orders. When I try to export it to a json file, it is blank. I've also tried the export command on customers and it gives me the same result.

@chrismarkpd what version of Magento are you using? And do you have any extensions installed that might affect the soap output for customers?

We're using <IP_ADDRESS> . We do have an extension for customers where we extended the customer attributes. I can't remember the name of the extension though.

Closing this as it's a bit old. @chrismarkpd feel free to re-open or create a new issue if you're still running into this with the current gem version.


Update loofah due to CVE-2018-8048

Update loofah due to CVE-2018-8048. More here: https://github.com/flavorjones/loofah/issues/144

Thanks Andrew!

No problem!


pythonPackages.django_2_1: 2.1 -> 2.1.1

Motivation for this change
See https://docs.djangoproject.com/en/2.1/releases/2.1.1/ for release
notes
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python36Packages.django_2_1 python36Packages.django-raster

Success on x86_64-darwin (full log)
Attempted: python36Packages.django_2_1, python36Packages.django-raster
Partial log (click to expand)
Requirement already satisfied: python-dateutil<3.0.0,>=2.1 in /nix/store/wmy1ss494ds5z0a5qixnrrn0licvahin-python3.6-python-dateutil-2.7.3/lib/python3.6/site-packages (from botocore<1.11.0,>=1.10.84->boto3>=1.7.9->django-raster==0.6) (2.7.3)
Requirement already satisfied: vine>=1.1.3 in /nix/store/6bmafd7252sdc5wfmqi0wfgki1w5srqm-python3.6-vine-1.1.4/lib/python3.6/site-packages (from amqp<3.0,>=2.1.4->kombu<5.0,>=4.2.0->celery>=4.1.0->django-raster==0.6) (1.1.4)
Requirement already satisfied: six>=1.5 in /nix/store/0sxf5mnyyzdpvcb4549b8zznzly0ma1j-python3.6-six-1.11.0/lib/python3.6/site-packages (from python-dateutil<3.0.0,>=2.1->botocore<1.11.0,>=1.10.84->boto3>=1.7.9->django-raster==0.6) (1.11.0)
Installing collected packages: django-raster
Successfully installed django-raster-0.6
/private/tmp/nix-build-python3.6-django-raster-0.6.drv-0/django-raster-0.6
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gyycch2dxnj62x9r12k2hbd56a658xxr-python3.6-django-raster-0.6/lib
patching script interpreter paths in /nix/store/gyycch2dxnj62x9r12k2hbd56a658xxr-python3.6-django-raster-0.6

Success on x86_64-linux (full log)
Attempted: python36Packages.django_2_1, python36Packages.django-raster
Partial log (click to expand)
Requirement already satisfied: six>=1.5 in /nix/store/ihs73mm4b5czchb3vvrifr46m0vkb059-python3.6-six-1.11.0/lib/python3.6/site-packages (from python-dateutil<3.0.0,>=2.1->botocore<1.11.0,>=1.10.84->boto3>=1.7.9->django-raster==0.6) (1.11.0)
Installing collected packages: django-raster
Successfully installed django-raster-0.6
/build/django-raster-0.6
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w0xmlfs86v26b8pa2p6876mxf8zds5fw-python3.6-django-raster-0.6
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w0xmlfs86v26b8pa2p6876mxf8zds5fw-python3.6-django-raster-0.6/lib
patching script interpreter paths in /nix/store/w0xmlfs86v26b8pa2p6876mxf8zds5fw-python3.6-django-raster-0.6
checking for references to /build in /nix/store/w0xmlfs86v26b8pa2p6876mxf8zds5fw-python3.6-django-raster-0.6...

Success on aarch64-linux (full log)
Attempted: python36Packages.django_2_1, python36Packages.django-raster
Partial log (click to expand)
Requirement already satisfied: vine>=1.1.3 in /nix/store/2zmaaxlgwdha43vsry6lsg9mqscbfs2s-python3.6-vine-1.1.4/lib/python3.6/site-packages (from amqp<3.0,>=2.1.4->kombu<5.0,>=4.2.0->celery>=4.1.0->django-raster==0.6) (1.1.4)
Installing collected packages: django-raster
Successfully installed django-raster-0.6
/build/django-raster-0.6
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iy4wm6nycq7p6058xx7n9q4ar15sy2il-python3.6-django-raster-0.6
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iy4wm6nycq7p6058xx7n9q4ar15sy2il-python3.6-django-raster-0.6/lib
patching script interpreter paths in /nix/store/iy4wm6nycq7p6058xx7n9q4ar15sy2il-python3.6-django-raster-0.6
checking for references to /build in /nix/store/iy4wm6nycq7p6058xx7n9q4ar15sy2il-python3.6-django-raster-0.6...


Wait for preview site to be live

It's going to be difficult to make this work because we cannot track and detect the current status of the preview site reliably from one execution to the next.
We can detect if the preview site is not live at all, and wait for it to return other than 404 status (I guess)
But this doesn't help us ensure the next execution runs on a freshly updated deploy site. We might have to use the github token to read the job status.

Addressing this in ad280da for the v1-beta release


AsynchronousPaymentHandlerInterface::finalize has to throw unless payment was successful

Shopware expects a payment handler to throw an exception unless the payment was successfully completed.
https://github.com/shopware/platform/blob/c4abfdc17d4583d3efd76498be395f5ec376828d/src/Core/Checkout/Payment/Controller/PaymentController.php#L57-L71
https://github.com/shopware/platform/blob/76f02b4a332a244fd6dc29b01c658d1190572aad/src/Core/Checkout/Payment/PaymentService.php#L118-L160
Mollie currently only throws when the current payment status is either STATUS_CANCELED or STATUS_FAILED
https://github.com/mollie/Shopware6/blob/737261b14bbb6f93fa809409c6fa4f6893f3db43/src/Handler/PaymentHandler.php#L363-L366
It would be therefore better to always throw unless the status is STATUS_PAID.
        if (
            isset($paymentStatus) && $paymentStatus !== PaymentStatus::STATUS_PAID
        ) {

We can provide a patch for this, if you'd like.

Hi @TitanNano, it seems your feedback is about an old version. In the meantime, it is possible to enable or disable the standard failed payment redirect. If disabled, we use a custom route which triggers a retry before the payment gets a new status.


error: failed to run custom build command for v4l2-sys-mit v0.2.0

Hello, I'm sorry if the solution to this issue is obvious. I've looked up the error, but I couldn't find anything.
OS: Arch Linux
Rust Nightly
Installed via rustup from the official source
I have openvr, and nvidia-utils installed
I'm getting this error when trying to build index_camera_passthrough
error: failed to run custom build command for v4l2-sys-mit v0.2.0

Caused by:
  process didn't exit successfully: /tmp/cargo-installSET54P/release/build/v4l2-sys-mit-057ded0b20d221c6/build-script-build (exit status: 101)
  --- stderr
  thread 'main' panicked at /home/matrix/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.69/src/fallback.rs:817:9:
  "v4l2_pix_format_union_(anonymous_at_/usr/include/linux/videodev2_h_500_2)" is not a valid Ident
  note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile index_camera_passthrough v0.1.0, intermediate artifacts can be found at /tmp/cargo-installSET54P.

I'm getting this too on Arch, but compiling directly from the git repo worked

Probably the old version of v4l2-sys being incompatible with the v4l header. Since the git version works I am closing this.


Feature Request: Data Source Config File

Following this guide, I have been creating data source config files for all of my data sources.
https://grafana.com/docs/grafana/latest/administration/provisioning/#data-sources
This will allow me to quickly spin up another grafana instance as needed.
I am trying to make one for Zabbix, but I receive this error

Plugin module is missing DataSourcePlugin or Datasource constructor export

Which leads me to believe it is not currently supported in this plugin. Can this feature be added?

@c0nfus3d Please, refer to Zabbix datasource provisioning docs to configure it. Probably plugin is not installed properly.


2 bug fixes: print parameter inputs at the correct place, and removed…

… hard-coded numdesigns=2 used for testing; one feature: additional input to use beta model
What type of PR is this?
Remove the categories that do not apply

🎮 Feature: option to use beta model
🐛 Bug Fix: removed hard-coded num_design=2, and print input parameters at the right place

successfully tested on local stack an staging. note that I added the option to use the beta model. this is currently selected by giving a true/flase string as input.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/573 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target.git

Docs Build status updates of commit bc654f7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BackendEngineExceptionError] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in https://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


The description is too long

🚀 Feature
Reduce the initial description shown to users
Is your feature request related to a problem? Please describe.
Sometimes, the book description is really long, and if it isn't the book you are looking for, you might get thrown off.
Describe the solution you'd like
It's better to show some of the description and have an option to show the rest.

I'd like to work on this, also if possible can you add hacktoberfest tag on this issue?

I can't add any labels, I don't know why. I want to add hacktoberfest as well

I think the reason might be that you haven't added hacktoberfest in your repo. If you see there's a typo its hactoberfest instead of hacktoberfest

can I ask why you closed this?


Failure in crossenv

Describe the bug
https://github.com/freakboy3742/crossenv/commit/6d88cb8034d4aafb1ff0ce4f63f40f715cd83beb appears to have broken host arch lookup. The issue comes from the assignment of self.host_machine and self.host_is_simulator since, as noted at the top of that function, host_platform can be of the form ios-12.0-iphonesimulator-arm64 and hence host_info[3] is arm64 which isn't a key in the map.
crossenv isn't pinned to a specific commit in https://github.com/beeware/mobile-forge/blob/main/pyproject.toml#L34 so all builds are affected (pinning to crossenv @ git+https://github.com/freakboy3742/crossenv@b8a3a72d59b2cf484cc6b31bcd122d7a975ef314 "fixes" the issue locally).
Also note that _split_apple_os_version() is missing raise ValueError(...) in the else: case of that commit.
Steps to reproduce

Try to build forge iphoneos:arm64 libpng
Observe error message ERROR: 'arm64'

Expected behavior
The build should complete without error
Screenshots
No response
Environment

Operating System: macOS 14.6.1 (23G93)
Python version: 3.12

Logs
% forge iphoneos:arm64 libpng
================================================================================
Building libpng 1.6.34 for ios_12_0_iphoneos_arm64
================================================================================

[venv3.12-ios_12_0_iphoneos_arm64] Download package sources
Downloading https://download.sourceforge.net/libpng/libpng-1.6.34.tar.gz.... done.

[venv3.12-ios_12_0_iphoneos_arm64] Unpack sources
Unpacking downloads/libpng-1.6.34.tar.gz...

[venv3.12-ios_12_0_iphoneos_arm64] Apply patches
No patches to apply.

[venv3.12-ios_12_0_iphoneos_arm64] Create clean build environment
Creating venv3.12-ios_12_0_iphoneos_arm64...

ERROR: 'arm64'
********************************************************************************
Failed build: libpng 1.6.34 for iphoneos 12.0 on arm64
********************************************************************************

Additional context
No response

Thanks for the report. Unfortunately, you've found this project in a transition period. We've recently landed a bunch of changes to the iOS support packages reflecting the official PEP 730 changes adding iOS support to CPython itself; but those changes include some subtle incompatibilities with the Mobile Forge repository.
I'm in currently in the middle of restoring Mobile Forge to working status; #55 is my current work in progress toward that goal. I've pushed some updates to my fork of crossenv (late yesterday); I think those changes will address the host_is_simulator issues you're seeing.
As of right now, Mobile Forge is able to build Python 3.12 binaries; I'm hoping to get 3.9-3.11 working in the next day or so (possibly sooner); then look at updating the recipes to add Python 3.13 support.


Added ComposeCookBook: A jetpack compose demo UIs

A full collection of jetpack compose UI elements, widgets, animations and demo UIs with 1.2k stars just behind google samples.

Thank you!


IoT Question: how to get latest device shadow after it's changed by another client?

From the IoT Temperature sample I can see we need to call registerWithShadow then call getShadow but that will only give the device shadow once. I tried to change the device shadow in the IoT console but the app did not get the new device shadow automatically.
If the device shadow can be updated by another client, what's the recommended way to get the new device shadow? Are we supposed to call getShadow periodically? Is there  a way like subscribeToTopic which subscribes to a shadow?
@gkwicker Can you please have a look at this question?
------ Question 2: How to get thing shadow topic MQTT subscription work?
According to the API doc (http://docs.aws.amazon.com/iot/latest/developerguide/thing-shadow-mqtt.html),  I should be able to subscribe to the thing shadow update using its MQTT topic like '$aws/things/thingName/shadow/update', however when I tried to subscribe to a thing shadow update topic (e.g. [[AWSIoTDataManager defaultIoTDataManager] subscribeToTopic:@"$aws/things/KitchenLight/shadow/update" QoS:AWSIoTMQTTQoSMessageDeliveryAttemptedAtLeastOnce messageCallback:^(NSData *data) ) after the data manager connected successfully, I did not get any callback when I used the IoT console to update the thing shadow. I am quite sure my policy allows 'iot: *' and I don't have any problem to use getShadow.
Then I tried to publish to the topic using the IoT console's MQTT client and in that case my iOS code can get the messageCallback. So that means a thing's 'REST API endpoint' update is not associated with its 'MQTT topic update'? If that's the case, what's the point of having a MQTT topic update?
Thanks

Some updates:
Hi I have done some more tests and seems the MQTT subscription works but it only works in some cases.
Case 1 - not working

Client to subscribe to a topic (e.g. $aws/things/KitchenLight/shadow/update): IoT console MQTT client
Client to update a thing shadow: IoT console 'Update shadow' tool
Result: MQTT client does not get any message when the thing shadow is updated

Case 2 - working

Client to subscribe to a topic (e.g. $aws/things/KitchenLight/shadow/update): IoT console MQTT client
Client to update a thing shadow: the iOS SDK [AWSIoTDataManager updateShadow::] method
Result: Working. when I call the updateShadow:: method, the MQTT client gets a message

Case 3 - not working

Client to subscribe to a topic (e.g. $aws/things/KitchenLight/shadow/update): iOS SDK [AWSIoTDataManager subscribeToTopic:::] method
Client to update a thing shadow: IoT console 'Update shadow' tool
Result: the iOS SDK does not get any message when the thing shadow is updated

Case 4 - not working

Client to subscribe to a topic (e.g. $aws/things/KitchenLight/shadow/update): iOS SDK [AWSIoTDataManager subscribeToTopic:::] method
Client to update a thing shadow: the iOS SDK [AWSIoTDataManager updateShadow::] method
Result: not working. though case 2 works this case does not work

Hi @maxzou2015,
When you register with a device shadow in your iOS app (as in the example app here), the callback function you provide will be invoked whenever that device shadow receives an accepted, rejected, or delta event (in the sample app, this happens here.  The SDK subscribes to the device shadow MQTT topics for you, so that you don't have to keep track of these yourself.  The best way to see this in action is to run this sample application together with its counterpart in the AWS IoT Device SDK for JavaScript, and set a breakpoint on the callback function to observe how the SDK handles device shadow events.
Let us know if that information is helpful, and thanks for using AWS IoT.

No activity for a long time. Closing the issue. Feel free to re-open if there are follow-up questions.

Hi @gkwicker,
I was wondering if there is a way to register with device shadow updates in an Android app using the SDK, I don't see a function that can be used to register. Do I have to Subscribe to certain topics of does the SDK handle that automatically?


Unconditionally render non-form annotations in the annotation layer (bug 1851498)

The goal is to always have something which is focusable to let the user select
it with the keyboard.
It fixes the mentioned bug because, the annotation layer will now have a container
to attach the canvas for annotations having their own canvas.

Given the changes made here, let's run all tests before I attempt to review this.
/botio test

It fixes the mentioned bug because, the annotation layer will now have a container
to attach the canvas for annotations having their own canvas.

In the, perhaps rare, case that the Annotation is truly empty (and e.g. doesn't have it's own canvas) won't this mean that we'll now "render" pointless annotations (or at least "unnecessarily" add them to the DOM)?
Perhaps that's not a common occurrence nor really a problem, but being able to access (e.g. via the keyboard) completely empty annotations doesn't seem all that meaningful (at least to me).
However this might indeed be fine as-is, but given the scope of these changes I simply want to want to make sure to fully understand the changes (such that we hopefully avoid more regressions in this area).

It fixes the mentioned bug because, the annotation layer will now have a container
to attach the canvas for annotations having their own canvas.

In the, perhaps rare, case that the Annotation is truly empty (and e.g. doesn't have it's own canvas) won't this mean that we'll now "render" pointless annotations (or at least "unnecessarily" add them to the DOM)? Perhaps that's not a common occurrence nor really a problem, but being able to access (e.g. via the keyboard) completely empty annotations doesn't seem all that meaningful (at least to me).
However this might indeed be fine as-is, but given the scope of these changes I simply want to want to make sure to fully understand the changes (such that we hopefully avoid more regressions in this area).

We could remove those empty annotations in the worker.
For example an empty annotation could have the following properties:

no associated popup
no data which could be rendered in a popup (i.e. content, title or rich text)
no appearance or with a null bounding-box (i.e. one dimensions at least is zero)
no tag

That said, right now the annotations (the non-widget ones) with a popup are "visible" by a screen reader (with NVDA at least) because they're clickable, but for annotations without a popup they've to be focusable and in this case we really need to have a container for them.

We could remove those empty annotations in the worker.
For example an empty annotation could have the following properties:

Right, but it occurs to me that for the general API we probably don't want to do just "skip" any Annotations.

but for annotations without a popup they've to be focusable and in this case we really need to have a container for them.

Sure, this all seems reasonable as-is. (I'll do the final review tomorrow, since it's getting a bit late.)

/botio test

/botio test

/botio makeref


Text goes out of bounds in overlay mode

The text translated in overlay mode goes out of the screen's boundaries/borders. Can you add an option where there is a certain extent the text could go and go to the line below? The only solution right now is to make all the text smaller.

hello! If the current translation result is larger than the original area, the translation result area is automatically enlarged.
It's not perfect yet and still working on it.
If you select Advanced Option-> Translation window -> Overlay -> Automatic font size adjustment, the translation results will not be displayed.

I'm also facing this kind of issue while reading a Chinese manhua recently, where some of the merged text from automatic font size got cut off by the area boundaries.
May be add an option to scale down the translation result area to fit the original area/window?
Even though bilinear scaling/interpolation can makes some text looks blurry (or use xBRZ or other method for sharper result), but at least we can see all the text instead if being cut off by the area boundaries.

Currently, the translation result is only enlarged if it is larger than the area.
If you set the text size to automatic in the overlay options, it will be displayed within the area.
However, there is a problem that it is cut off if the text size is set to the minimum value.
The above issue is still being checked.


[feature request] helm: Add support for gotemplate comments

When working on helm templates, it would be amazing if the vscode's builtin comment toggle system was adjusted to support gotemplate comments, {{/* ... */}}.

It looks like there is already an attempt to support this, but it's broken. I don't know why no one has raised this before...
changing language-configuration.json's comment section to only read
    "comments": {
        // comments applicable to tpl files.
        "blockComment": [ "{{- /*", "*/ }}" ]
    },

fixes all the problems with toggling lines and blocks


s3scality sandbox method doesn't exist

s3scality sandbox method doesn't exist

there is no requirement for all methods to exist on a builder


[Bug]: A USSD Dialogue Appears For Each Transaction Instead of the Process Starting and Finishing on Stax

Description
All transactions: checking airtime balance, checking bank balance, checking MPesa balance, sending money from either bank or Mpesa fail every time and I end up getting a normal USSD dialogue and a failed status.
I recently upgraded my Oppo A53 from android 11 to android 12 not sure if that might be the cause. I have been having a

few issues with some other apps as well.
Airtime balance - I checked both Safaricom and Telkom. The process took longer like 2- 3 minutes . A USSD dialogue appeared instead and it was like I had just dialed *100#. Stax indicated a failed status in both cases.
Bank and Mpesa Balance - Took like a minute to get a response. A USSD dialogue appeared and a failed status.
Send Money (Mpesa to bank)- Took like 2 minutes to get a response. USSD dialogue appeared and a failed status.
Send Money(Bank to Mpesa)-Took like 2 minutes to get a response. A USSD dialogue appeared instead and a failed status.
Steps to reproduce
Airtime Balance

Open the Stax app
On the bottom navigation menu tap on sims, this opens a screen with your sim cards listed
Click the check balance button for the sim you want to check

Bank Balance

Open the Stax app
On the home page there is a section containing your linked accounts. Click on the refresh button for the bank account you wish to check.
Select the sim linked to the bank account to run the process
Enter and confirm the mobile banking pin to start the process

M-Pesa Balance

Open the Stax app
On the home page there is a section containing your linked accounts. Click on the refresh button for the Mpesa account you wish to check.
Enter and confirm your M-Pesa pin to start the process

Send Money -Bank to Mpesa

Open the Stax app
On the home page click on the send money button, and a screen appears with fields to fill
Select or add the bank account(Equity) you wish to transact from
Select the recipient network, in this case, MPesa
Enter the amount and recipient name and click the continue button
Select the sim linked to the bank account to run the process
Enter and confirm the mobile banking pin to start the process

Send Money- Mpesa to Bank

Open the Stax app
On the home page click on the send money button, and a screen appears with fields to fill
Select or  add the m-pesa account you wish to transact from
Select the recipient network, in this case, Bank account(Equity), and enter their account number
Enter the amount and click the continue button
Enter and confirm the M-pesa  pin to start the process

Expected result
That the processes carry on within the Stax app to completion instead of prompting external USSD dialogue.
Actual result
Airtime balance - I checked both Safaricom and Telkom. The process took longer like 2- 3 minutes . A USSD dialogue appeared instead and it was like I had just dialed *100#. Stax indicated a failed status in both cases.
Bank and Mpesa Balance - Took like a minute to get a response. A USSD dialogue appeared and a failed status.
Send Money (Mpesa to bank)- Took like 2 minutes to get a response. USSD dialogue appeared and a failed status.
Send Money(Bank to Mpesa)-Took like 2 minutes to get a response. A USSD dialogue appeared instead and a failed status.
https://user-images.githubusercontent.com/28391610/212406348-01ca4148-7fe3-45cf-98e9-c2fc741410e4.mp4
https://user-images.githubusercontent.com/28391610/212406493-d814318e-d56a-4116-ad4f-373c7c992c9b.mp4
https://user-images.githubusercontent.com/28391610/212409187-8f6462f7-15f2-4cb4-a1cb-b611108dd0c9.mp4
Link to screenshots/screen recordings
No response
Device name
Oppo A53
Android OS
12
App version
1.19.0
Config version
20230113130811
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
<EMAIL_ADDRESS>

@Mally13 please restart your device and let us know if the problem persists

I have restarted and the problem still persists
On Fri, 13 Jan 2023, 23:28 davkutalek, @.***> wrote:

@Mally13 https://github.com/Mally13 please restart your device and let
us know if the problem persists
—
Reply to this email directly, view it on GitHub
https://github.com/UseHover/Stax/issues/915#issuecomment-1382353741, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGYTROQSLCA7MIUW7VLATC3WSG3GLANCNFSM6AAAAAAT2YTLSA
.


wrong formulae for NAE and NASer (N-acyl amines)

Hello ChEBI team,
there are error in formula for N-acyl ethanolamine (see issue #4233) and for N-acyl serine

CHEBI:134166 N-acylserine 16:0

correct formula should be C19H37NO4, as this is correct in CHEBI:165558 N-Palmitoyl serine, a 2-star entry that still needs review, and merge
As a consequence, wrong formula in
CHEBI:134167 N-acylserine 16:1

CHEBI:134168 N-acylserine 18:0

correct formula should be C21H41NO4, as this is correct in CHEBI:165572 N-Stearoyl serine, a 2-star entry that still needs review, and merge
As a consequence, wrong formula in
CHEBI:134169 N-acylserine 18:1
CHEBI:134170 N-acylserine 18:2

CHEBI:134171  N-acylserine 20:4

correct formula should be C23H37NO4, as this is correct in CHEBI:143514 N-arachidonoyl-L-serine
As a consequence, wrong formula in
CHEBI:134172 N-acylserine 20:6 should be C23H33NO4

I have corrected the formula, mass and monoisotopic masses of these entries.
I haven't merged any of the entries as you suggested since they are separate entries. The correct way would be to fix the hierarchical structure of the ontology. For example N-Palmitoyl serine (CHEBI:165558) is_a N-acyl-L-serine 16:0 ( term currently missing in ChEBI) is_a N-acylserine 16:0 (CHEBI:134166) is_a N-acylserine (CHEBI:134123).


Fix issue #139 - do not stop resyncing

I am 90% confident in this fix, but have done no testing whatsoever. Until tests are available it must not be merged; it's here in case somebody else needs to do an emergency release of it.

The fix https://github.com/Metaswitch/calico-docker-prototype/pull/31 is a workaround for this fix.

This bug has been fixed elsewhere, in a way that actually involved testing it - so my proposal is withdrawn.


Doesn't wait for elastic to start

It looks like rummager doesn't wait for elastic indexes to be created.
If started immediately after 9200 port becomes available rake task fails with error:
RUMMAGER_INDEX=all bundle exec rake rummager:migrate_index
...
rummager_1   | http://elastic:9200/mainstream-2016-04-18t03%3A08%3A09z-bef48763-9753-4fa4-a5ca-8f71867dc510/_settings
rummager_1   | rake aborted!
rummager_1   | RestClient::ServiceUnavailable: 503 Service Unavailable

Elastic log:
elastic_1    | [2016-04-18 03:09:38,554][INFO ][http                     ] [Ultra-Marine] bound_address {inet[/0:0:0:0:0:0:0:0:9200]}, publish_address {inet[/<IP_ADDRESS>:9200]}
elastic_1    | [2016-04-18 03:09:38,557][INFO ][node                     ] [Ultra-Marine] started
elastic_1    | [2016-04-18 03:09:40,722][INFO ][gateway                  ] [Ultra-Marine] recovered [31] indices into cluster_state
elastic_1    | [2016-04-18 03:09:50,111][INFO ][cluster.metadata         ] [Ultra-Marine] [mainstream-2016-04-18t03:09:45z-a2e1746f-243a-47ad-9c4a-210cfa5c54a0] creating index, cause [api], templates [], shards [5]/[1], mappings [utaac_decision, medical_safety_alert, tax_tribunal_decision, service_manual_guide, vehicle_recalls_and_faults_alert, service_manual_topic, countryside_stewardship_grant, aaib_report, raib_report, edition, employment_tribunal_decision, manual, manual_section, asylum_support_decision, drug_safety_update, employment_appeal_tribunal_decision, cma_case, maib_report, contact, hmrc_manual, european_structural_investment_fund, hmrc_manual_section, international_development_fund, policy]
elastic_1    | [2016-04-18 03:09:53,123][DEBUG][action.search.type       ] [Ultra-Marine] All shards failed for phase: [init_scan]
elastic_1    | org.elasticsearch.indices.IndexMissingException: [mainstream-2016-04-18t03:08:09z-bef48763-9753-4fa4-a5ca-8f71867dc510] missing
elastic_1    | 	at org.elasticsearch.indices.IndicesService.indexServiceSafe(IndicesService.java:288)

I'm using elastic 1.7.1
Should using sidekiq help any way? Is there anything to be done for this not to fail?

Hi Vanuan,
I suspect rummager can't migrate indexes that don't exist. Have you tried running the following:
bundle exec rake rummager:switch_to_empty_index

This may create the databases if you don't have them.


Want to add create new item btn in lookup list

Hello Sir, i want to add create new item in the lookup dialog list. How can i do this

You can create your own dialog and set it's id in lookup's Dialog property.
public PeopleLookup()
{
    Dialog = "NewDialogId";
}


Use Table Name in Advanced search

Is your feature request related to a problem? Please describe.
I would like to include or exclude tables in my search based on a prefix in the Table Name  (eg. tmp_ or Bkup_)
Describe the solution you'd like
I would like to see the Table Name attribute as an option in the advanced search feature.
Describe alternatives you've considered

Additional context

Added the Display Name filter in #17829