Change controller.yml defaults to OCP 3 recommendations

The preferred approach for OCP 4 is to use OLM for installation as outlined at:
https://github.com/fusor/mig-operator#operator-installation-with-olm-on-openshift-4
Since the controller.yml is primarily intended as a means of installing components on OCP 3 it makes sense to change the controller.yml defaults to install only what we recommend on OCP 3.
This addresses https://github.com/fusor/mig-operator/issues/37

@jmontleon thoughts on providing a controller-3.yml and controller-4.yml? Each of these could have sane defaults for the respective version.

@pranavgaikwad any impact to agnosticd workloads if we change defaults of controller.yml?

@jmontleon @jwmatthews yes, workload expects controller.yml file. since the filenames have changed, i need to make changes in the workload

Let's wait fpr this to get merged : https://github.com/redhat-cop/agnosticd/pull/617

@jmontleon Good to merge now!


let user define newline character in text escape (also bugged?)

What improvement do you think would an existing feature or tool in DevToys?
When having a text with linebreaks like this
Hello
World

the escaped text will be
Hello\rWorld\r

now that I look at it again it's not even correct windows linebreaks (my platform), for windows it should be \r\n.
It would be great to have a toggle button to toggle between unix and windows line breaks.
Solution/Idea
A toggle button to switch between unix and windows linebreaks.
Comments
No response

now that I look at it again it's not even correct windows linebreaks (my platform), for windows it should be \r\n.
The reason for this is Windows text boxes use only carriage return even though carriage return + line feed is used for text files.

Duplicate with #468

Oh sorry somehow missed that there’s already one issue…


IOTEDGE-1083 dynamic secret handling for examples

Go test fails because *ecdsa.PrivateKey.Equal was only introduced in Golang 1.15. Either, I could upgrade Go to 1.15 or write a bespoke equal function for the unit tests. I am happy to do either?

Go test fails because *ecdsa.PrivateKey.Equal was only introduced in Golang 1.15. Either, I could upgrade Go to 1.15 or write a bespoke equal function for the unit tests. I am happy to do either?

My vote would be for updating to Go 1.15.

Go test fails because *ecdsa.PrivateKey.Equal was only introduced in Golang 1.15. Either, I could upgrade Go to 1.15 or write a bespoke equal function for the unit tests. I am happy to do either?

We'll have to update the docs with the new version as well. Can you create a story for this please?


Collection and Map are not updated correctly when refresh is triggered

Hi,
I'm facing an issue with /refresh when my @ConfigurationProperties bean has a typed Collection attribute.
I'm using spring-boot 1.5.19.RELEASE and spring-cloud Edgware.SR5.
Here is a way to reproduce :
I have an application.yml file which contains
example:
myList:
- A
- H
- P
This property is binding with my @ConfigurationProperties bean
 @ConfigurationProperties("example")
 @RefreshScope
 @Validated
 public class MyApplicationConfigurationProperties {

List<String> myList;

public List<String> getMyList() {
	return myList;
}

public void setMyList(List<String> myList) {
	this.myList = myList;
}
 }

I exposes a @RestController which return this list
 @SpringBootApplication
 @EnableConfigurationProperties(MyApplicationConfigurationProperties.class)
 @RestController
 @EnableAutoConfiguration
 public class SpringCloudConfigIssue421Application {

@Autowired
private MyApplicationConfigurationProperties configurationProperties;

public static void main(String[] args) {
	SpringApplication.run(SpringCloudConfigIssue421Application.class, args);
}

@GetMapping(produces="application/json", value="/mylist")
public List<String> getMyListe(){
	return configurationProperties.getMyList();
}
 }

I launch my app (mvn spring-boot:run) and invoke /mylist endpoint. So the application returns
 ["A","H","P"]

So then, I change my application.yml file with the following content
example:
myList:
- H
- P
... and call POST /refresh endpoint. Everything seems fine
["example.myList[0]","example.myList[2]","example.myList[1]"]
... finally a call again /mylist endpoint and the application returns
 ["H","P","P"]

The last item is not removed from the property.
Here is a repo from which you can reproduce the bug https://github.com/RaphC/spring-cloud-refresh

Can you try with Greenwich.RELEASE?

Hi @ryanjbaxter , I'll try it.

Hi @ryanjbaxter , I've just tested with Greenwich.RELEASE. It works ! Thank you

Would you mind trying Finchley.SR2?  I am wondering if this is really just a problem in Spring Boot.

Hi @ryanjbaxter , I've just tested with Finchley.SR2 and spring-boot 2.1.3.RELEASE. It works.

Finchley.SR2 and spring-boot 2.1.3.RELEASE

Finchley.X is not compatible with boot 2.1.x. Can you try Finchley.SR3 with boot 2.0.8?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


fix: 723 python cloud storage based templates should support all sparksql csv options

created function persist_streaming_dataframe_to_cloud_storage
edited templates kafkatogcs & pubsublitetogcs
updated readme
changed GCS to Cloud Storage wherever applicable

I don't see any changes to unit tests, is that correct?
Also, I just want to make it clear that I have not tested the code, I am unsure how to test a pub/sub source. So this is a code review only.

Yeah,
kafkatogcs doesn't seem to have unit tests
pubsublitetogcs doesn't test write options

The code changes look good to me. I wonder if you should raise a new issue for the missing tests (I'll leave that up to you)?

Discussed with @vanshaj-bhatia - this would be resolved through a new issue


Introduce PRESET_NONE for climate

Description:
The frontend used to automatically add PRESET_NONE to the preset dropdown. However, this is not something that all devices support. So it is dropped in the new frontend, and we need to be explicit about integrations that support PRESET_NONE.
I went through all integrations that allow changing preset, and looked into if they supported None as a value.

What is the purpose of PRESET_NONE? Should I add support for it on Daikin too (I don't think any Daikin devices have Home but it defaults to it when I select None)?

@fredrike if you are not sure if it supports None it likely doesn’t. What is the default mode the device is in?

@fredrike if you are not sure if it supports None it likely doesn’t. What is the default mode the device is in?

Not sure what you mean but Holiday-mode disables built-in schedules. Neither of powerful or eco is implemented as the API for those calls have not been discovered.
My comment is that I don't think that Home mode should be visible for Daikin.

I probably misunderstood that. In that case Home (and None) should be removed.

@fredrike can you open a new PR for that ?

Commit statuses are wrong, I reran the build and it looks fine: https://dev.azure.com/home-assistant/Home Assistant/_build/results?buildId=4411&view=logs&s=ff93f215-8e6d-5080-c57f-6d2854850283

@fredrike can you open a new PR for that ?

Yes, in a couple of days..

Seems something odd is going on here. https://github.com/home-assistant/home-assistant/issues/25424
A casual look tells me something is translating the "none" string into an actual None value. But the constant PRESET_NONE is the string "none".


Add ReactiveX deps, including JakeWharton's RxBinding and RxRelay

🚀 Description

Starting a draft PR to gather input on these dependencies, I will work on documentation in the meantime. There were a few things I wasn't sure about. Particularly the alias rules, I see some in txt files and some in the code, I wasn't sure what the recommended method was going forward. Also didn't really understand the removals and related generated things
Add ReactiveX dependencies:

RxJava, RxJava2, RxJava3
RxAndroid
RxKotlin

Add Rx libraries from Jake Wharton:

RxBinding3 and RxBinding4
RxRelay2 and RxRelay3

📄 Motivation and Context

These are widely used libraries, many could probably benefit
🧪 How Has This Been Tested?

Ran tests. They passed!
📦 Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

[x] I have read the guidelines for the development process
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

This should have an issue linked to it
Looks like you need to update the autogenerated README entry:
https://github.com/jmfayard/refreshVersions/pull/478/files#diff-6529a4773c61668cf023627f4d039779841ae14af791dd2770f7c3811efdc55eR266

Oops! Missed that requirement. Looks like there's an existing issue, I'll link it
I didn't really understand that autogenerated README entry. It's not really clear what I'm supposed to do with it?

@LouisCAD Closing to reopen in a new PR after rebase and refactor :)

I'd advise extracting a patch and apply select changes instead of rebasing, but maybe your plan will work just as well.

Hello Mike, if you still plan on getting these added, please take the time to open the new PR as you told, or tell me you'll not do it, so I or someone else know they can do it. :)


Fix schema name

Fix DATE default type
Add database dump

how should I use bash in vs code and how you opened SQL file in that please help !

I think you need to check lection 21 Import and Backup, could you?


how to use semantic searching with many conditions together

If I want to combine location, people and oraganization, how to transmit params in python, should I connect with "," or "&"
How to use 2 locations, if I want to limit the location for both "Austraila" and "Italy", is that possible to do so ?

You can comma separate them, e.g. entities=ORG:Tesla,PER:Elon Musk
You can only search for one location at once. You'd have to do two requests and merge them.

thx, I see


Cannot close all tabs

The current tab-group implementation does not allow closing of all tabs, the final tab will remain open and the X button does nothing.

I updated the tab group component. The code is completely new, therefore you'll find a 'dist-deprecated' folder with the old code. The new code is also a little bit smaller: But try it out: https://jsfiddle.net/Loo3pyuo/


Actions that I created find themselves in double in « Nautilus »...

I do not know why, but the specific actions that I created find themselves in double in  « Nautilus » :

Do you know what can I do to fix it ?

Check whether you json file contains also double entries
Funnily I just opened an issue (for the wiki) about pdf compression. Please have a look - your solution might look similar. It took we a while to find a combination of paramenters which seemed to work fine for diverse pdfs

This the 1st thing I have checked, and no, there is no double entries in my json file :
bigbob@bigbob-t480s:~$ cat ~/.local/share/actions-for-nautilus/config.json | jq | grep label
      "label": "Comparaison de 2 fichiers PDF's",
      "label": "Conversion de taille PDF's basse résolution (screen)",
      "label": "Conversion de taille PDF's moyenne résolution (ebook)",
      "label": "Conversion de taille PDF's haute résolution (printer)",
      "label": "Conversion de taille PDF's très haute résolution (prepress)",
      "label": "Conversion de fichier(s) mail (eml) en PDF(s)",
      "label": "Création d'une image ISO à partir d'un répertoire",
      "label": "Conversion résolution de fichiers Images vers 1024 points max",
bigbob@bigbob-t480s:~$

@biokomiker, here is the commands behind my actions for nautilus :
bigbob@bigbob-t480s:~$ cat ~/.local/share/actions-for-nautilus/config.json | jq
{
  "actions": [
    {
      "type": "command",
      "label": "Comparaison de 2 fichiers PDF's",
      "command_line": "diffpdf %F",
      "min_items": 2,
      "max_items": 2,
      "permissions": "read",
      "mimetypes": [
        "application/pdf"
      ]
    },
    {
      "type": "command",
      "label": "Conversion de taille PDF's basse résolution (screen)",
      "command_line": "gs -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dPDFSETTINGS=/screen -sOutputFile=%d/new-screen-%b %d/%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "application/pdf"
      ]
    },
    {
      "type": "command",
      "label": "Conversion de taille PDF's moyenne résolution (ebook)",
      "command_line": "gs -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dPDFSETTINGS=/ebook -sOutputFile=%d/new-ebook-%b %d/%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "application/pdf"
      ]
    },
    {
      "type": "command",
      "label": "Conversion de taille PDF's haute résolution (printer)",
      "command_line": "gs -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dPDFSETTINGS=/printer -sOutputFile=%d/new-printer-%b %d/%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "application/pdf"
      ]
    },
    {
      "type": "command",
      "label": "Conversion de taille PDF's très haute résolution (prepress)",
      "command_line": "gs -dNOPAUSE -dBATCH -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dPDFSETTINGS=/prepress -sOutputFile=%d/new-prepress-%b %d/%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "application/pdf"
      ]
    },
    {
      "type": "command",
      "label": "Conversion de fichier(s) mail (eml) en PDF(s)",
      "command_line": "java -jar /usr/local/bin/emailconverter.jar %d/%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "message/rfc822"
      ]
    },
    {
      "type": "command",
      "label": "Création d'une image ISO à partir d'un répertoire",
      "command_line": "mkisofs -lJR -o %f.iso %f",
      "min_items": 1,
      "max_items": 1,
      "permissions": "read",
      "mimetypes": [
        "inode/directory"
      ]
    },
    {
      "type": "command",
      "label": "Conversion résolution de fichiers Images vers 1024 points max",
      "command_line": "convert -resize 1024x1024 %d/%b %d/max-1024-%b",
      "min_items": 1,
      "permissions": "read",
      "mimetypes": [
        "image/*"
      ]
    }
  ],
  "debug": false
}
bigbob@bigbob-t480s:~$

Hey, @Creteil
I just copied your config into mine and this is what I get... (well, apparently I have screwed up my Print key mapping, so) ... I get one entry per item...
What WOULD explain this is if, somehow, in the Nautilus extensions directory you have TWO versions of the extension. Nautilus would start each up and they would both look at the same config file - I just proved that that would happen. You may have a local version (in /$HOME/.local/share/nautilus-python/extensions) and a "global" version installed with the .deb file?

@bassmanitram, thanks !!!
Fixed with :
bigbob@bigbob-ux31a:~$ rm -rf  ~/.local/share/nautilus-python
bigbob@bigbob-ux31a:~$

Excellent! Closing.


Refinement of object works and it doesn't

I created a few tiny examples, one per demo function:
Playground link
In particular, these two:
function demoV1(thing: unknown): void {
    if (thing === null || typeof thing !== 'object') {
        throw new Error('not an object');
    }

    // ERROR: thing is object || null
    const obj: object = thing;
}

function demoV2(thing: unknown): void {
    if (typeof thing !== 'object') {
        throw new Error('not an object');
    }

    if (thing === null) {
        throw new Error('not an object');
    }

    // WORKS
    const obj: object = thing;
}

So... TypeScript does not understand an or operator "||" to test twp things in the same if()?

Okay... so I found that the order of the individual tests matters, which is just as strange so I see no reason to close the issue.
function demoV1(thing: unknown): void {
    if (typeof thing !== 'object' || thing === null) {
        throw new Error('not an object');
    }

    // WORKS
    const obj: object = thing;
}

function demoV2(thing: unknown): void {
    if (thing === null) {
        throw new Error('not an object');
    }

    if (typeof thing !== 'object') {
        throw new Error('not an object');
    }

     // ERROR: thing is object || null
    const obj: object = thing;
}

Duplicate of #28131


Release azure-cli-storage 2.0.1

Codecov Report

Merging #2374 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   72.94%   72.94%
=======================================
  Files         425      425
  Lines       19310    19310
  Branches     2740     2740
=======================================
  Hits        14085    14085
+ Misses       4323     4321    -2
- Partials      902      904    +2

Impacted Files
Coverage Δ

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:white_check_mark:

src/azure-cli-core/azure/cli/core/_util.py
65.51% <0%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cae87...a7f81c8. Read the comment docs.

@tjprescott updated and includes your change now.


operator 3scale-community-operator (0.11.0)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Are you familiar with our operator pipeline?

[x] Have you considered whether you want to use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Your submission should not

[x] Add more than one operator bundle per PR
[x] Modify any operator
[x] Rename an operator
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

wrong image references
               - name: RELATED_IMAGE_APICAST
                  value: quay.io/3scale/3scale213:apicast-3scale-2.13.1-GA
                - name: RELATED_IMAGE_SYSTEM
                  value: quay.io/3scale/3scale213:porta-3scale-2.13.1-GA
                - name: RELATED_IMAGE_ZYNC
                  value: quay.io/3scale/3scale213:zync-3scale-2.13.1-GA

Thank you! Yes, it was draft. Now - updated.

/pipeline restart

3scale-2.13.1-GA

Updated. Thank you

RELATED_IMAGE_APICAST

Done

From the description, I see "New Submissions". This is not a new submission, this is a "Updates to existing Operators" kind of submit.
The metadata/annotations.yaml file is missing com.redhat.openshift.versions
It should be like this
annotations:
  operators.operatorframework.io.bundle.channel.default.v1: threescale-2.14
  operators.operatorframework.io.bundle.channels.v1: threescale-2.14
  operators.operatorframework.io.bundle.manifests.v1: manifests/
  operators.operatorframework.io.bundle.mediatype.v1: registry+v1
  operators.operatorframework.io.bundle.metadata.v1: metadata/
  operators.operatorframework.io.bundle.package.v1: 3scale-community-operator
  operators.operatorframework.io.metrics.builder: operator-sdk-v1.2.0
  operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
  operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v2
  operators.operatorframework.io.test.config.v1: tests/scorecard/
  operators.operatorframework.io.test.mediatype.v1: scorecard+v1
  com.redhat.openshift.versions: v4.11-v4.15

after applying the requested changes, make the PR ready for review

Changes done.

Hi @eguzki , following test failed evaluate-preflight-result. Could you please help. Log fragment is below. Thank you.
Not all preflight tests passed.
{
  "image": "quay.io/community-operator-pipeline-prod/3scale-community-operator:0.11.0",
  "passed": false,
  "certification_hash": "d41d8cd98f00b204e9800998ecf8427e",
  "test_library": {
    "name": "github.com/redhat-openshift-ecosystem/openshift-preflight",
    "version": "1.9.2",
    "commit": "4a0c6b9b74de9a4ac8a812f5e1f4aa9144755823"
  },
  "results": {
    "passed": [
      {
        "name": "ScorecardBasicSpecCheck",
        "elapsed_time": 11636,
        "description": "Check to make sure that all CRs have a spec block."
      },
      {
        "name": "ScorecardOlmSuiteCheck",
        "elapsed_time": 2606,
        "description": "Operator-sdk scorecard OLM Test Suite Check"
      }
    ],
    "failed": [],
    "errors": [
      {
        "name": "DeployableByOLM",
        "elapsed_time": 183260,
        "description": "Checking if the operator could be deployed by OLM",
        "help": "It is required that your operator could be deployed by OLM"
      }
    ]
  }
}
failure

content is correct. https://github.com/3scale/3scale-operator/pull/979 + patch
diff --git a/bundle/manifests/3scale-operator.clusterserviceversion.yaml b/bundle/manifests/3scale-operator.clusterserviceversion.yaml
index 0155950d..d451478d 100644
--- a/bundle/manifests/3scale-operator.clusterserviceversion.yaml
+++ b/bundle/manifests/3scale-operator.clusterserviceversion.yaml
@@ -217,7 +217,7 @@ metadata:
     operatorframework.io/arch.amd64: supported
     operatorframework.io/arch.ppc64le: supported
     operatorframework.io/arch.s390x: supported
-  name: 3scale-operator.v0.11.0
+  name: 3scale-community-operator.v0.11.0
   namespace: placeholder
 spec:
   apiservicedefinitions: {}
diff --git a/bundle/metadata/annotations.yaml b/bundle/metadata/annotations.yaml
index a4ab00c0..7ace76b5 100644
--- a/bundle/metadata/annotations.yaml
+++ b/bundle/metadata/annotations.yaml
@@ -4,9 +4,10 @@ annotations:
   operators.operatorframework.io.bundle.manifests.v1: manifests/
   operators.operatorframework.io.bundle.mediatype.v1: registry+v1
   operators.operatorframework.io.bundle.metadata.v1: metadata/
-  operators.operatorframework.io.bundle.package.v1: 3scale-operator
+  operators.operatorframework.io.bundle.package.v1: 3scale-community-operator
   operators.operatorframework.io.metrics.builder: operator-sdk-v1.2.0
   operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
   operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v2
   operators.operatorframework.io.test.config.v1: tests/scorecard/
   operators.operatorframework.io.test.mediatype.v1: scorecard+v1
+  com.redhat.openshift.versions: v4.11-v4.15

/lgtm

/pipeline restart operator-hosted-pipeline

It looks like the preflight test is using a package name for CatalogSource name when trying to install the operator on a cluster. @acornett21 would you have any suggestions to @eguzki on how to work around this issue? Can we start using a CatalogSource that doesn't use the package as a name to avoid these kinds of issues?

This is a K8s validation error, I'm not sure which version of K8s this went into, but since this operator hasn't been released in over a year, it would be really hard to track down where/when this was changed. I think the operator name and package name would have to change, so probably would have to be a new operator folder in this repo and treated as net new. Something like three-scale-operator

This is very inconvenient. But if there is no other way :shrug:

hey @acornett21 @Allda
It seems that the issue (as mentioned above) is caused directly by metadata.name of catalog source created is the same as the package name. (https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/53ba0b717599ec9c780df1c2ed31af9fef145467/internal/policy/operator/deployable_by_olm.go#L255)
Would it be possible to update the https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/53ba0b717599ec9c780df1c2ed31af9fef145467/internal/openshift/openshift.go#L240 to do some form of pre-validation of the catalog source name and add a prefix to it if it's not valid?
I might be missing something but the pre-flight repository purpose seems to be for verification purposes, if the bundle is accepted it will be part of catalog source "community-operators" therefore I think we could maybe consider changing the catalog source name to some static value instead of adding a prefix/having it the same as package name.

/pipeline restart operator-hosted-pipeline


Validate error code have correct format

Validate that the error codes have the correct format (start with an E/F/W ...)

Gramma:
error-identifier = severity "-" project-short-tag [ "-" module-short-tag ] "-" error-number
severity = ( "F" / "E" / "W" )
project-short-tag = ALPHA 1*4ALPHANUM
module-short-tag = ALPHA 1*4ALPHANUM
error-number = 1*5ALPHANUM


docs: generalize "edx-search" to "search" in pagination docstring

Description
When this code was extracted from edx-platform,
it was likely used to paginate search results
specifically from the "edx-search" library
(http://github.com/openedx/edx-search/).
Now that this is generic utility function,
it makes more sense to just say
"search results" instead of
"edx-search results", as the
result list can come from any backend.
Reviewers
@georgebabey , as the original author, do you mind reviewing this docs tweak?

Merging without requirements because this is such a trivial change.


chroe(package) Update dependencies

Update dependencies
replace deprecated sinon APIs

Hi. I would like you to review my code.
@dignifiedquire @maksimr
Thank you.


update scratch.md for issue #4068

closes #4068 [Updated by @zacharysarah, 7/23/17]
Issue #4068 details the dangers of recommending single etcd instance.
This will likely need to be expanded into better "highly available" cluster documentation

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

Comment to check cla/linuxfoundation

I updated the OP to automatically close the issue if the PR merges.

Deploy preview ready!
Built with commit c3d765463c94d83f15963a78bdfca338f77bd7c8
https://deploy-preview-4069--kubernetes-io-master-staging.netlify.com


Add 0.54.0 to feature search app

Adds 0.54.0 to the version selection drop down in the feature search app.

I'm looking at the new Rust nightly warnings.

I don't know why the lib test is failing though.


Unproper position on first load in popper.js v2

CodePen demo
https://codepen.io/mrpsiho/pen/VwYQxvw
Steps to reproduce the problem
The demo uses three elements: two refs and one pop.

Change the id from 'refid1' to 'refid2' (or vise versa) in this code:
const refId = document.getElementById('refid1');

Do no do any other actions, just wait until the main section is getting reloaded. It is clearly seen that pop is slightly displaced on the left.

Scroll the main section, even a bit, and pop is getting re-positioned and becomes perfectly centered.

What is the expected behavior?
Pop is perfectly centered on first page load.
What went wrong?
Pop is a bit displaced on the left.
Any other comments?
Nothing.

Poppers now require you add this CSS before load:
#popper {
  position: absolute;
  left: 0;
  top: 0;
}

@atomiks Indeed it solves the issue! Thanks! I must be was not attentive enough to this info in the docs!

It's not in the docs 🤓

You won't need to do that in alpha.4
🤓


Fix for KOQ comparison failure

@calebmshafer @ColinKerr. Arnoldas Vaicikauskas reported this issue earlier today.  Easy fix.  Can't believe it wasn't reported before this.

@Mergifyio update


Heading Colour Inconsistencies

We have noticed that the heading colours are inconistent across the site. Can we ensure all main heading (H1, H2) that are on white or light gray backgrounds are dark gray (vs. bright blue)?

@colinvlasak Can you please provide any sample url here in order to check.
Thanks

One thing we can do for now is handle the grey-background cases.

@jindaliiita can you confirm what changes were made? Did you just update the colours for the gray background text? Is there a way for us to manually change the text colours in the word docs?


Debugging session does not start

Hi,
I'm using the Modern Fortran extension for years, almost from the start. Now I can't debug FORTRAN programs, debugging session just can't start. It seems there is a conflict with other VSCode extensions. If the C++ extension pack is uninstalled, then Modern Fortran is uninstalled and reinstalled, debugging is OK as always. However, after reinstalling the C++ extension pack, the debug problem shows up.
I love Modern Fortran. Nothing left of FORTRAN IDEs, Modern Fortran extension is our only hope.
Thank you in advance

Could you try launching a debugger with only Modern Fortran and C++ extensions enabled.
Also could you post the versions of your Modern Fortran and C++ extensions.
Modern Fortran relies on C++ GCC debug adapter since they are virtually identical, so you always need C++ to use the Modern Fortran debugger.

Thank you for your reply.
After a few hours spent on the problem, looks like there is an issue with preLaunchTask configured in "launch.json". Seems like debug session is waiting for the task, which is "build for debug" using gfortran, to complete. And it never completed!
Having Modern Fortran disabled, the task completes very quickly, build for debug is successful, and debug session starts fast.
As you suggested, all extensions were disabled, except C/C++ v1.7.1. The Modern Fortran is v2.6.2. The files "launch.json" and "tasks.json" are attached.
vscode.zip

So you launch.json and tasks.json seem good to me.
From what I understood the following are true:

Using Run and Debug from VSCode to Compile your Fortran Code and then attach it to a Debugger does not work (i.e. it hangs)
Running the build task on its own works
Using a pre compiled binary to launch a Debugger works

I tried myself a simple example (on Linux) with the same extension versions and I can't replicate the problem.
If 3 points I made above are true I would start thinking that the issue is with C++ on Windows or with your version of VSCode on Windows.

All 3 points are true. Rolling back to C++ extension v1.7.0 and v1.6.0 did not solve the problem.
The build and debug (with the same launch and task files) using g++ work perfectly. It seems the problem is somewhere in file operations by VS Code. Trying to delete a file from the currently open folder (move to recycle bin) occasionally takes a long time with a warning message.
Thank you in advance.

Just to give you an idea with what I am working with
I am on Linux
VS Code Insiders build 1.64.0
C++ v.1.8.0.insiders2
and Modern Fortran v3.0.0 (but this shouldn't matter for you since the Debugger is from the C++ extension)
The other thing that I would try is to recreate the tasks and launch files (delete them and ask VSCode to create a build and debug file), maybe you are missing something crucial.
Mine, again for Linux, look like this:
tasks.json
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "Compile Fortran",
      "type": "shell",
      "command": "gfortran",
      "args": [
        "-g",
        "-Wall",
        "${file}",
        "-o${fileDirname}/${fileBasenameNoExtension}.o"
      ],
      "problemMatcher": [],
      "group": {
        "kind": "build",
        "isDefault": true
      }
    }
  ]
}

launch.json
{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "name": "(gdb) Launch Fortran",
      "type": "cppdbg",
      "request": "launch",
      "program": "${fileDirname}/${fileBasenameNoExtension}.o",
      "args": [],
      "stopAtEntry": false,
      "cwd": "${fileDirname}",
      "environment": [],
      "externalConsole": false,
      "MIMode": "gdb",
      "setupCommands": [
        {
          "description": "Enable pretty-printing for gdb",
          "text": "-enable-pretty-printing",
          "ignoreFailures": true
        },
        {
          "description": "Set Disassembly Flavor to Intel",
          "text": "-gdb-set disassembly-flavor intel",
          "ignoreFailures": true
        }
      ],
      "preLaunchTask": "Compile Fortran"
    }
  ]
}

I'm facing this issue in both Windows 10 (21H2) and Windows 11. VS Code' about dialog shows the following info:
Version: 1.63.2 (user setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19044
Sorry, I can't find the path where extension's json settings file exists, but I'm pretty sure that all settings were reset to default in VS Code settings tab.
The picture below is a screenshot of the message VS Code occasionally shows on file operations.

I think you should raise this with the VSCode dev team https://github.com/microsoft/vscode after you check their Issues for any similar reports.
Your settings can be found by pressing Ctrl + Shift + P and typing Preferences: Open settings JSON.
Then search Ctrl + F for any settings containing the string fortran. and paste only those.

The settings file contains a few lines:
{
"python.languageServer": "Pylance",
"debug.onTaskErrors": "showErrors"
}
I'm really confused about this issue. You're right, I have to check the VSCode issues.
Thank you in advance for your time and consideration.

How about this scenario?

Having Modern Fortran extension installed and enabled, syntax highlighting works and breakpoints could be set.
Disabling Modern Fortran extension, syntax highlight goes off, but breakpoints still remain in the open files in editor.
Now, all tasks including build and debug work perfectly! Variable values by mouse hover, Watch, step over, step into, and everything is fine in the debug session.
While debugging (e.g. stopped at a breakpoint), enabling the modern fortran extension brings back the syntax highlighting, but breaks the debug session completely, step over, and other actions are not possible.

The one and only way (for now) to debug fortran programs seems that.
It is worth mentioning that while disabling modern fortran, all file operations in VSCode are just fine. Enabling modern fortran, all trouble gets back.

Till now, Modern Fortran was enabled and I was hanging around, bothering you with non-relevant issues, sorry about that. It seems to disable it resolves all problems with VSCode. By the way, C++ extension updated to v1.8.0-insiders2. Nothing changed.
Rolling back modern fortran to v.2.2.2 (a year ago) solved the problems with VSCode in Windows 10 and 11. It seems problems exist in new versions.
8 updates for modern fortran have been released in 2 months. If it helps, I can find the first version which encounter problems.
Cheers

Another issue with modern fortran in Windows was that every time VSCode loaded, the message for installing fortran language server showed up. Hitting "Don't Show Again" didn't work. This message always showed up.
Actually, hitting "install now" button also did nothing!

The popup message issue I think was present in some older versions and has now been resolved.
If you can find the version where things broke I can have a look at the changes since I can't replicate the issue myself.
Also, when you disable the extension, do you restart VS Code?

I can confirm that popup message issue still exists in v2.6.2 in latest stable release of VSCode for Windows, i.e. 1.63.2 (user setup).
After disabling modern fortran, with or without restarting VSCode, I could debug fortran programs, provided that breakpoints are set in open files in editor (because after opening VSCode, the last work environment is reloaded).
I try to find the first version which causes the issues.

So I have no idea why the warning fix is not working on windows, but to fix it you should set this in your settings
"fortran.ignoreWarning.fortls": true

By the way, the last version of Modern Fortran which works perfectly on my machine is 2.6.0. The problems show up from 2.6.1.
Thanks for your suggestions. I'll share my experience.
Cheers

Yeah that is very strange, are you sure you don't have set any other Modern Fortran settings? Because the only difference between the 2 versions is about the log channel, which was a trivial bug, see changelog

2.6.1
Fixed
Fixes log channel not initialising when extension fails to activate (#286)
2.6.0

Today an option was available for Modern Fortran extension, the great "Switch to Pre-Release Version". Once I clicked it and extension updated to v3.0.20220119, everything is perfect in both my machines running Windows 10 and 11.
In order to verify the problem with version 2.6.2, again I switch to the "Release Version" and all problems with file operations and debugging came back. Switch back to pre-release, again everything is just fine (reloaded VSCode after switch operation).
Thank you for your time and consideration. It seems everything is fine with release 3 on both Windows 10 and 11.

Even the buttons in the popup message for installing FORTRAN language server are working now.

Awesome good to know, give the preRelease a go and if you have any feedback for missing features, or bugs please go ahead and Open an issue. I think that your issue might have been related to node.js actually. I seem to recall that I might have messed up the extension packaging in one of those releases, maybe I forgot to push the fix to the store and instead kept it only on the development branch.
Notes about the preRelease
We are not relying anymore on the fortran-language-server Python package for the Language Server functionality. Instead we are switching to a more updated and feature-rich project called fortls (which I am the author).
I would suggest you give that a go too, you will have to first uninstall, if installed, fortran-language-server.
pip uninstall fortran-language-server
pip install fortls

Let me know if you are able to get it to work. From some local testing yesterday I seemed to be unable to get hover working on Windows.

Great work. I've not installed the language server yet. I'll share my experience with fortls on Windows.

Okay I was being silly before. I got it to work on Windows, for fortls to start just make sure you have "fortran.ignoreWarning.fortls": false (which is set by default) AND that "fortran.fortls.path": "C:\\your\\path\\to\\fortls.exe" and it should work out as expected.

Also, an additional note, you won't be needing "FORTRAN Intellisense" anymore (if you ever had that installed)

Well, thank you very much. I've already noticed that Modern Fortran is the one and only extension (if we ignore the godfather C++) I need to develop Fortran code. Also, the new icon of the extension for v3 is very good.

Awesome, I am glad to hear this. I will be closing this issue now. Feel free to open a new one if more issues arise.


Update tracker api

@justscribe These are the changes I suggested in the other PR. This is an API break, but i think it's one of the final API updates I will be making since the old 0.9 release.

Looks good. No problem to change a little my project)


add the document for manually running the cronjob

This PR resolves: https://github.com/stolostron/multicluster-global-hub/issues/525
Once the enhancement is accomplished, The document about manually running the compliance job also needs to be updated

Please do not merge this. I very much like what you did @yanmxa . But would like to review it carefully tonight.

/hold

@clyang82 @yanmxa struck me while reviewing this - can we keep rolling 4~5 days of the materialized view. This will allow us to be able to get the view we need if we detect this failure 2 days later.

/cherry-pick release-2.8

/unhold


leetcode.nvim Not Working in NVChad

Description:
I've recently tried to set up leetcode.nvim in my nvchad environment following the instructions provided in the README file. However, I'm encountering issues and unable to get it working properly. Here are the details:
Steps to Reproduce:
Followed the installation instructions in the README file for integrating leetcode.nvim into my nvchad environment.
Enabled the necessary configurations as per the instructions.
Opened nvim and attempted to use the leetcode plugin.
nvim leetcode.nvim

Expected Behavior:
I expected leetcode.nvim to work seamlessly within my nvchad environment, allowing me to access and solve LeetCode problems directly from within nvim.
I expected nvim leetcode.nvim to open the leetcode.nvim plugin, not a file named leetcode.nvim.
Actual Behavior:
However, When I try to open leetcode.nvim using
nvim leetcode.nvim

it opens a file named leetcode.nvim instead of launching the leetcode.nvim plugin.
Additional Information:
Version of neovim: v9.0
Version of nvchad: v2.0
Operating System: Arch Linux.
I would appreciate any assistance or guidance on resolving this issue. Thank you!

This is how I added it to My config File.

Maybe you have lazy loading enabled by default.


Fix typos in Readme.md

Fixed typo maven plugin version 3.2.5
Fixed typo start-steady.sh vs setup-steady.sh

TODOs

[x] Tests on local machine
[ ] Documentation

Hello @anddann - Both scripts docker/start-steady.sh and docker/setup-steady.sh do exist, and the latter actually calls the former. Maybe we change the text to [...] triggered by setup-steady.shor directly usingstart-steady.sh -s ui``?

Sry, @henrikplate  you are absolutely right. I've just downloaded the setup-steady.sh file and did not find the start-steady.sh file in the folder, and thus assumed that it does not exist. However, I know found it in steady-3.2.5/start-steady.sh


Geometry importation

Add the VTK library in the Pipfile.lock
Create the geometry module:

load the geometry from an hdf5 file (containing a dataset 'geometry' as a 3d numpy array)
add the geometry to the state
preview the geometry after initialization (mainly for testing purpose now)

Another thing I forgot to mention, we should avoid committing large files to the repo.  A <10MB is borderline in terms of size, but the file included here is a grid specific input file.  I think you can provide a link to this file + a compatible config file in the readme to get people started, but ultimately we will need to provide a mechanism for generating this file procedurally.
To avoid keeping this file around in the repo forever, it would be best to amend this commit without the data file before merging.


Make each function configurable independently

This allows you to disable features you don't want

Might have issues with multiplayer (which i dont even know if it works)
but was planning on doing that.

I am a beginner and this was just a repo I made because I wanted to add a few things to 1.7.10 but I guess I'll start looking into it now. I have no idea how to create mod options though and YouTube just has 0 tutorials for these kinds of things, but I have free time so, if I can figure it out, you might see an update come out today.

What kind of features do you think should be toggleable?

i got it working btw

Figured out how categories work

Certain features like Custom Items and Blocks will be under simple toggles for now because there's not that many stuff that I have added yet. In the future there will be and they will all get their own individual toggles. This seems like it should be fine for now.


Updated Overlay configuration to work with new data

DISTAREA and NAME

this is bc we switched the admin areas schema....

Low Risk, this is just a datamodel change and Config.js change


Migrated categories from main site only

related #306

Not sure this is ready for QA. Should I wait for a new db migration?
Currently, both dev and beta still have categories from not-the-main-site.

E.g. "BERI open-source question set" is from ai.metaculus.com, not www. This is apparent in its id in the old db being 3/beri-open-source-question-set, starting with a 3 and not a 1.


No Authentication Key and Token

Hi
Midea-discover finds my appliance, but when I try to get an authentication key and token, I get:

Authentication Key: An unknown error occurred
Authentication Token: An unknown error occurred

The credentials work on the SmartHome App on my Android phone, but the App is now called SmartHome, not MSmartHome any more. Would appreciate a hint!

@jeburkha I simply solved this issue buy buying:

ESP8266 ESP-01S wifi module
ESP8266 adapter 3.3V to 5V for ESP-01
ESP-01 USB ESP8266 serial for programming (there are versions with programming switch and without - I got without and then followed instructions in this video to add jumpers: https://www.youtube.com/watch?v=6uaIWZCRSz8&t=187s)
Jumper cables to connect adapter with AC

⚠ Do not connect the ESP8266 to AC with the programmer USB module. You have to use the 3.3V to 5V adapter (I damaged one board by not doing this). The programmer is used only for flashing.

Yes, I know, I already implemented this workaround. But it doesn't solve the problem that it is not possible any more to get an authentication key and token from Smart Home.

I had another look at the code and I think I fixed the issue. Would be great if you can test.

Ok, great! I will do the test, but it will take some time, because i first have to change the interface...

You can just run the discover command to obtain token and key, no need to change anything on your side.

Does the discover comment work without an interface in my network? Because I changed the interface to the self built one...
If not, I first have to change the interface in my AC!

Yes

BTW in my experience a DIY dongle is far more table than the original dongle. The original dongle periodically loses its WiFi connection and needs to be power cycled to recover again.

Yes, I use the diy interface at the moment, but it's my request after all, so I'll do the test when I get the chance. But please be patient!

@jeburkha upgraded to 0.3.1 and unfortunately it does not work for me with same error as before.

Maybe the issue you experienced was due to a breaking change in node > 20.x where the dns lookup fails. Support for node version > 20.x has been added in version 0.3.3.


Suggestion: --recursive for modules

I think a --recursive flag could be useful in a couple of different commands e.g. instead of --list-submodules or in --groups to also include groups from modules.

I think --recursive is a much better name for the flag than --list-submodules. I would do this in two steps, first make --list-submodules work with --groups to display groups in submodules, and then change the name of --list-submodules to --recursive, and make --list-submodules an alias of --recursive, so that it doesn't break existing use.


Testrpc exits with an error

https://github.com/MetaMask/metamask-plugin/issues/1702
Steps:
Open metamask,
Select token's page
eth_getTransactionCount
eth_getCode
eth_getBalance
eth_getTransactionCount
eth_getCode
eth_getBalance
eth_getTransactionCount
eth_getCode
eth_getBalance
eth_getTransactionCount
eth_getCode
eth_getBlockByNumber
eth_getBlockByNumber
eth_getBalance
eth_getTransactionCount
eth_getBalance
eth_getTransactionCount
eth_getBalance
eth_getTransactionCount
eth_getBalance
eth_getTransactionCount
/Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:61262
    db.get(key, {
      ^

TypeError: Cannot read property 'get' of undefined
    at dbGet (/Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:61262:7)
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:17720:5
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:24532:20
    at iterate (/Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:24613:13)
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:24625:29
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:24395:16
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:17725:7
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:61267:9
    at dispatchError (/Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:31665:35)
    at /Users/rstorm/.nvm/versions/node/v7.10.0/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:23916:14

Version used: 4.0.1
Operating System and version: OSX

I am hitting this as well. Seems to be happening when: testrpc has a -b  set. I have observed that it seems to happen less or not at all without -b. Most likely an issue with testrpcs automatic mining parameter. -b or --blocktime: Specify blocktime in seconds for automatic mining. Default is 0 and no auto-mining.

eth_call
/usr/local/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:61262
    db.get(key, {
      ^
TypeError: Cannot read property 'get' of undefined
    at dbGet (/usr/local/lib/node_modules/ethereumjs-testrpc/build/cli.node.js:61262:7)

I'm getting the same error. It's a pain, having to constantly restart a crashed process

Having same issue.
@rstormsf did you ever figure out a workaround?

bumperooo   i want the -b but its annoying to restart every 20 min :|

Having same issue, also with -b flag on.
I'm running testrpc using forever so it will restart by without me needing to do it :)
Did anyone figure out a workaround for this?

I'm consolidating reports of this issue over on #417 - I'll make a note of interval mining being an aggravating factor over there.


minor: javadoc fixes

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Generated Compute SDK and fixed an error in generate.ps1

Description

Generated new Azure Stack Compute Admin SDK.
Accepted spec PR
https://github.com/Azure/azure-rest-api-specs/pull/2810

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] Please add REST spec PR link to the SDK PR
[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[X] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda All of the existing Azure Stack SDK folders use the RP.Admin folder structure.  Should I make this RP inconsistent with those?

@deathly809 disregard that comment you can leave the directory name as is, will finish rest of the review and revert


Patch for user login during auth process

feel like this one can probably get closed out now. cheers! 🥳


Feature/test 769 deployed vers

What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):

[ ] I have checked that no one else is working on similar changes.
[ ] I have read the latest README and understand the development workflow.
[ ] The name of this branch is: feature/<branch_name> (need to have cloned the repo not forked).
[ ] This branch is rebased/merged with the latest master.
[ ] There are no merge conflicts.
[ ] There are no console warnings and errors.
[ ] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

Guess it didn't work again. Weirdly enough the images are not being created for this PR.

As mentioned on the other PRs, I will ask Manny why the Review Github Action workflow doesn't trigger. I was only able to trigger it with the PR I first opened that was behind master. this one is ahead of master, maybe it has something to do why why the review  workflow was not exceuted? will check later as it would be nice to be able to review the changes on a deployed version of the big PR that BM has ready to merge.


Nested circle paths break on Android

I ran into this issue when trying to put social icons inside some circles, but found out the issue was generated when there was a path that had a circle cut out of another circle (cutting a rectangle out didn't seem to reproduce it).
Here is some simple svg that causes the issue (created with Sketch. I've used svgo to get rid of extraneous stuff but the issue occurs with or without the optimisation)
<svg width="50" height="50" viewBox="0 0 50 50" xmlns="http://www.w3.org/2000/svg">
    <title>facebook-logo</title>
    <desc>Created with Sketch.</desc>
    <g fill="none" fill-rule="evenodd">
        <g fill="#D8D8D8">
            <path d="M25 50c13.807 0 25-11.193 25-25S38.807 0 25 0 0 11.193 0 25s11.193 25 25 25zm0-6c10.493 0 19-8.507 19-19S35.493 6 25 6 6 14.507 6 25s8.507 19 19 19z"/>
        </g>
    </g>
</svg>

Expected output (Chrome in OSX):

Damaged output (Chrome in Android 5.0)

The really interesting thing is that this happens in every browser on Android. I tried Firefox and the default AOSP browser (in the emulator) and I got a similar result. I think this is a collision of an Android bug and an interesting handling of ttf files from Fontello.
I originally discovered this using gulp-fonticon, but I'm assuming that the error is happening here because the TTF and WOFF files are affected, and the same issue happens when using the Fontello website.
I'm just charging up an Android 4 device in the house to see if the same thing happens.

This did occur on Android 4 as well. Interestingly enough, the culprit SVG files rendered incorrectly in Illustrator as well - even though it was a compound path with one circle inside another.
Turns out its the path direction thats causing all of these issues. Sketch exports with the "evenodd" fill rule for path cutouts but it would seem that no matter what, the Android font renderer and Illustrator will interpret that as "nonzero". In evenodd, path direction doesn't matter but in nonzero it does - the paths need to be in alternating direction for the cutouts to be successful. I have no idea how these fill rules translate to the ttf spec.
In any case, reversing the path direction in Sketch manually fixes the issue. I would call this a bug with Illustrator/Android (and likely many other programs), but its a bug that Sketch should account for so I've filed a bug report.
I'm not sure what this library could do, maybe it can make sure paths are in alternating directions or just leave it to us? I feel like if the library took matters into its own hands, it would just cause more problems.

You have wrong path direction. Read help https://github.com/fontello/fontello/wiki/How-to-use-custom-images#importing-svg-images
That's not a bug.

I'd count it as a bug as the SVG spec says that path direction doesn't matter when fillrule="evenodd": http://www.w3.org/TR/SVG/painting.html#FillProperties
However, I wouldn't really count it as a bug with this library, and the fix is fairly easy.

If you think that's easy - do PR. I have no plans to process fill property.

@puzrin I don't mean the fix for the code, because I suspect that is fairly complex.
I mean the fix for a user, by just reversing the path direction.
By the way, thanks for making this open source instead of doing what all of the other cloud icon font generators do, because having to use an online service sits well out of my usual workflow.

@Pinpickle   Do you have a Sketch issue# to follow up?


frame_id include a "/" which cannot work in tf2

Hello guys,
I'm having problems with the nmea_navsat_driver under Indigo since it publishes a frame_id as /gps which includes a backslash which is not allowed in tf2 standard.
I tried to launch the driver with the " _frame_id:=gps" parameter but it still continues to add the backslash to the frame name.
Is it possible to change this, please? I cannot correctly run my ROS codes since I always get this error:
Could not obtain transform from /gps to base_link. Error was Invalid argument "/gps" passed to lookupTransform argument source_frame in tf2 frame_ids cannot start with a '/' like:
Thank you!

That does look like a bug.
If you submit a pull request with a fix for it, you're likely to get it done sooner. (I am not the maintainer of this package.)

This is a duplicate of #24


[Feature request] :Make awesome-ipfs more awesome by allowing users to add posts

Can you elaborate on your request? Are there any examples of other awesome-lists that support this, and if so, can you link to the ones that include the functionality you're requesting as well as an explanation for those of us that are unfamiliar with this feature?

PRs are always open!


Default value for renderFinalNewline on Linux is bad for conditioned users

https://github.com/Microsoft/vscode/pull/64667 introduced a new setting renderFinalNewline. The choice was made that on Linux, the default value for this setting is true which changes the behavior from versions of VS Code before the setting was introduced.
Without realizing the default behavior has been changed, I have been adding double newlines to the end of files since I have upgraded to v1.32 because I have become conditioned to the display of line numbers on all lines. I was quite surprised to find that I could put the cursor on a line without a line number! I suspect that I am not the only user that has developed such conditioning. Changing the default behavior was certainly not very nice for my UX.

You're not the only one to be surprised by this change – #69129.
It wasn't even (prominently) mentioned in the update notes, which is a surprise in itself.
Ideally, Linux users could have been prompted to make a choice when upgrading VS Code. Failing that, the only other reasonable option seems to be to default to true. It's unfortunate (since it's not really "correct"), but as you say, many users have been conditioned to expect this numbered empty line at the end of files.
I personally use Windows, but since I work on projects with Linux EOL characters and have the EditorConfig insert_final_newline setting enabled, I've actually set renderFinalNewline to false so that I no longer have this "blank line" at the end of files. It's going to take some getting used to, but I still believe that it is the correct behaviour.

A third option may be to display some kind of character/symbol to indicate that the last line ends with a \n.
Something like this:

I mentioned this here as well (with some alternatives).
In that way, you know that the last line is terminated, and where to place your cursor, without erroneously numbering that as a line.


[JSDoc] Add missing documentation for adaptive-expressions/builtinFuntions files 5/10

Addresses # 2602
Description
This PR adds the missing documentation in adaptive-expressions/builtinFunctions/ files.
Some documentation is ported and adapted from botbuilder-dotnet
Specific Changes

Added JSDoc comments in all public methods.
Added @private attribute to private methods.

Testing
The following image shows the ESLint Report with no JSDoc errors.

Promoted


Animsition and Wow Js

Hi everybody, I’m french Graphic/UX designer and new member on Github.
I’ve created a new version of my website to present a selection of my works but I have two problems with the final version.
www.gillesnolorgues.com
First problem:
To sum up, I use the Animsition plugin to start the CSS fade transition between pages and when I scroll, I use the Wow plugin and Animate CSS to start the CSS fadeup on my pictures.
My problem, when the page is loaded for the first time, the CSS fadeup have already started. It works perfectly when the page has already been loaded.
May be, is it a problem with the JS code? I don’t find the solution.
Second problem:
It’s about the image hover effects on iOS, I have to tape twice on the screen to start the image link and I would like to tape one.
Many thanks in advance for your assistance.

Hi, try to initialize wow.js after the "inStart" event of animsition.
 $(".animsition").animsition();
 $(".animsition").on('animsition.inStart', function(){
    new WOW().init();
  })

@diegoviola1 Thanks!


Use latex template information to improve PDF parsing of scientific publications

I'm trying to use PDFminer to perform textmining to scientific articles. One of the problems is that recovering the structure of the text is not trivial. Do you think that digging into the journal's latex template I would find useful information that would help me to identify the LTTextBox and improve the parsing I get when applying deni's example?
Thanks.

Possibly? I'm fairly sure that you can adjust the parameters used in parsing the sheet using the LAParams object, so if there's that type of information in the template, then yes. I'm actually doing something with scientific papers as well, and I've found that if you want to detect text regions vs. figure or tabular regions, you need to make an assumption about the number of columns. So I suppose a latex template might be useful in that sense.
Honestly though, unless you're up for a pretty major re-write of pdfminer, your best bet is to do your implementation on top of pdfminer, like Denis' example.

I was planning to build on top of pdfminer, would you like to give it ta try?


Support podAntiAffinityLabelSelector in new helm charts for istiod

Describe the feature request
It used to be possible to specify antiaffinity for pods based on hostname in the old helm charts for pilot (https://discuss.istio.io/t/istio-pilot-and-policy-anti-affinity/843/7).  This no longer appears to be an option in the new charts as it doesn't appear to have the necessary templating in 1.9.0 in https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/templates/deployment.yaml
Affected product area (please put an X in all that apply)
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Duplicated with https://github.com/istio/istio/issues/30655


Firefox unable to edit text string fields in a nested content

From the forum...

I'm having an issue with Firefox where the nested content item's Textstring fields don't allow any focus or editing in the browser. I can use content or media pickers, but the textstrings are un-editable.
Anyone else experiencing this?
I can edit in Chrome just fine.

https://our.umbraco.org/projects/backoffice-extensions/nested-content/nested-content-feedback/66853-firefox-unable-to-edit-text-string-fields-in-a-nested-content

Can't seem to replicate this.
Using Firefox v35.0 I've been able to modify text properties inside nested content without problem.
Do we have any additional replication steps? Are there any JS errors present?

@protherj - do you have any JS errors from Firefox?

Sadly no console errors.  I'll try it on some other machines and see if I can replicate it.
Thanks,
Jason

This has plagued Archetype: https://github.com/imulus/Archetype/issues/61
Tom Fulton traced it backed to possibly UI.sortable.

@kgiszewski Thanks for the heads up!

Ok, well, if the Archetype issue is correct, and it's to do with disableSelection() being called, it looks like that should be fixed in Umbraco 7.2.0 (https://github.com/umbraco/Umbraco-CMS/commit/ef6e181eb1fc61d70884680517ff4de2cfcb34eb). This could be why it's working for me as I'm testing in 7.2.6.
Rather than dotting our code with an ugly fix then, my suggestion would be to upgrade to at least 7.2.0.
Thanks for the heads up @kgiszewski, that would have been a nightmare to find.

Ah yes, this is a 7.1.x site.  I'll get an upgrade on the Backlog and verify that is the fix.
Thanks,
Jason


cupy.sign(NaN) == 0, unlike numpy

Description
numpy.sign(numpy.nan) returns NaN, but cupy.sign(cupy.nan) returns 0.
I expected either the behavior to be the same, or the difference to be documented. (Edit: I see now that the different behavior is documented, but not explicitly contrasted with numpy in the documentation. Apologies if this is better suited as a documentation enhancement, although I would prefer the matching behavior.)
To Reproduce
import numpy as np
import cupy as cp
# Second assertion fails
assert np.isnan(np.sign(np.nan))
assert cp.isnan(cp.sign(cp.nan))

Installation
Wheel (pip install cupy-***)
Environment
OS                           : Windows-10-10.0.19045-SP0
Python Version               : 3.11.6
CuPy Version                 : 13.0.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 1.24.0
SciPy Version                : 1.11.2
Cython Build Version         : 0.29.36
Cython Runtime Version       : 3.0.2
CUDA Root                    : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.2
nvcc PATH                    : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.2\bin\nvcc.EXE
CUDA Build Version           : 12020
CUDA Driver Version          : 12020
CUDA Runtime Version         : 12020 (linked to CuPy) / 12020 (locally installed)
cuBLAS Version               : (available)
cuFFT Version                : 11008
cuRAND Version               : 10303
cuSOLVER Version             : (11, 5, 0)
cuSPARSE Version             : (available)
NVRTC Version                : (12, 2)
Thrust Version               : 200200
CUB Build Version            : 200200
Jitify Build Version         : b0269c8
cuDNN Build Version          : (not loaded; try `import cupy.cuda.cudnn` first)
cuDNN Version                : (not loaded; try `import cupy.cuda.cudnn` first)
NCCL Build Version           : None
NCCL Runtime Version         : None
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : NVIDIA GeForce RTX 4090
Device 0 Compute Capability  : 89
Device 0 PCI Bus ID          : 0000:C1:00.0

Additional Information
No response

It looks like the kernel is defined as
((x > 0) - (x < 0))
numpy uses the expression in1 > 0 ? 1 : (in1 < 0 ? -1 : (in1 == 0 ? 0 : in1)) code here
Some brief testing in godbolt shows that with nvcc 11.7, the numpy expression compiles into the same number or fewer of PTX instructions, without any branches. (Even fewer with floating point if the (in1 == 0 ? 0 : in1) is replaced with the equivalent in1.)

@prutschman-iv Thanks for reporting this one and also checking the performance impact! Indeed it's better to fix this one. Would you be interested in submitting a pull request to address this bug?

I'll attempt to prepare a pull request with appropriate tests. For the tests, it looks like one approach would be adding something like this to test_misc.py. Does that seem right?
def test_sign_inf_nan(self):
    self.check_unary_inf_nan("sign")

(Also, I just realized that (in1 == 0 ? 0 : in1) isn't equivalent to in1 in the case of -0. So, the longer form of the expression is necessary to match numpy.)

I must be misunderstanding some aspect of the test suite. I tried adding the test_sign_inf_nan and running the test suite with python setup.py test without fixing the bug, but I didn't get a test failure. I defined the test as assert False and didn't get a failure. So, I think my new test isn't getting run.
(I'm currently using the v12 branch because I couldn't get the main branch to build due to a problem with dlpack)

Thanks @prutschman-iv! The test looks legitimate to me. To run the test please use python -m pytest tests/cupy_tests/math_tests/test_misc.py. As for the dlpack issue, since the git submodule path has been changed between these branches, I'd suggest starting over from the fresh clone.

I was successful in running the test suite for v12, thank you. From there I also observed a divergence between cupy and numpy for complex numbers, so I've fixed that as well. From the discussion linking to this one it sounds like there is maybe some controversy about the "correct" behavior? But my fix causes the behavior to match numpy's behavior as of 1.26.
The efficiency story isn't as rosy for the complex numbers case; it appears that the existing code was complicated enough to cause branches rather than predicated execution already and the extra test for nan does not improve the situation.
Unfortunately, I'm still having trouble building on main, even on a completely fresh clone into an new directory. For some reason the file cupy/_core/include\cupy/_dlpack/dlpack.h contains only the literal string ../../../../../third_party/dlpack/include/dlpack/dlpack.h I am hesitant to open the PR until I've verified correct operation on the main branch.

@prutschman-iv feel free to file a draft PR so that one of us can look at it and help you verify the issues :)

Unfortunately, I'm still having trouble building on main, even on a completely fresh clone into an new directory. For some reason the file cupy/_core/include\cupy/_dlpack/dlpack.h contains only the literal string ../../../../../third_party/dlpack/include/dlpack/dlpack.h I am hesitant to open the PR until I've verified correct operation on the main branch.

On Windows, symlink support needs to be enabled manually:
https://github.com/cupy/cupy/issues/7989#issuecomment-1826470128

I'm not trying to pester, but I wanted to point out that I've removed the draft status from my PR, just in case that notification isn't automatic.


Milestone 1 Feedback

Hi Group 23,
I like your examples of the types of people who would use the app and why!

Where will you put a legend for the map?
I wonder if your government official might like to be able to compare the data from their country with another country directly on a plot like the line plot at the bottom. Or be able to have their country’s values listed in the table/bar plot for comparison to the top countries. But maybe they would want to compare to countries most similar to their country (based on region or development level) to see what trends other countries in a similar situation have? Or to look at the values in the bar graph of a certain region.

Thanks for your feedback! We will try our best to address these issues.


2.0 Release

Current coverage is 72.34% (diff: 68.02%)

Merging #9 into master will decrease coverage by 6.95%

@@             master         #9   diff @@
==========================================
  Files             7         14     +7
  Lines           285        311    +26
  Methods          26         30     +4
  Messages          0          0
  Branches          0          0
==========================================
- Hits            226        225     -1
- Misses           59         86    +27
  Partials          0          0

Powered by Codecov. Last update ea6be0f...b23a7b9


L2 cache bypassing allocation hangs the system

In an attempt to get DMA access to Raspberry Pi 3 working from user space, ported the safe L2 cache bypassing allocation code from dma-gpio.c over to dma-example.c, the code is available at
https://github.com/juj/Raspberry-Pi-DMA-Example/commit/fcc8abef6705b54f3eaf592dc38498da2ea3f7c2#diff-7f20fb2096b20c653020741d0a12f09bR326
No matter what I try, I get the above code to hang the pi (requiring hard power off and on the device), usually printing out
pi@raspi:~/code/Raspberry-Pi-DMA-Example $ sudo ./dma-example
memfd: 3, pagemapfd: 4
mapped: 0x76f62000
destination was initially: ''
sleep

without ever getting over the sleep(1); command to print out the next sleep done message. I wonder if there is something in the above ported code you'd be able to catch out?
(as a sidenote, had to change the used DMA channel from default 5 to 8, since sniffing the DMA channels' CS registers showed that DMA channel 5 is infrequently in use on the system (one transfer per a few minutes), not sure by what though.

Reducing the test case further,
https://github.com/juj/Raspberry-Pi-DMA-Example/commit/4dd506b09f133a5828d2e2d41de55f631c4e0769
has an example that does an allocation of a single page, and then tries to create an uncached view to the page, and memset that page to zero. The result is
$ g++ -o uncached-memory-allocation uncached-memory-allocation.cpp
$ sudo ./uncached-memory-allocation
Allocating uncached memory
Created uncached memory view, memsetting it to zero
Sleep before memset done
Memset done

after which the Pi hangs, never printing out "Memset done and slept some".
It is as if it's crashing on the line that sleeps for one second, whereas the sleep before the memset worked just fine, which suggests some kind of asynchronous behavior in the memset that takes the system down. Commenting out the memset makes the test pass, so there's something bad about accessing that uncached page.
I wonder if this method of allocating uncached pages in user space could be fixed somehow? It'd have great potential to optimize the power consumption of my fbcp-ili9341 driver :)

Playing around, changing this line from
 return virtToPhys(virt, pagemapfd) | 0x40000000;

to
 return virtToPhys(virt, pagemapfd);

i.e. not taking the physical page over to uncached address range, the crash is avoided (although naturally also the memory will then not be uncached), so this suggests there is something going awry in the physical uncached address scheme, perhaps rather than the mmap() functions for example. Not sure if that's much helpful in finding a solution though.

@juj It looks to me like you've confirmed issue #2 for the RPi 3.
In the Pi 1, DMA was blind to the L1 cache, so I had to write to (and probably read from?) a separate bus address that's L2-coherent (0x4000_0000 - 0x6000_0000). These mappings come from here
It wouldn't surprise me if these bus mappings were changed between different RPi revisions - especially as the Pi3 has more ram. Specifically, I found this page - it looks like possibly the following line will work:
 return virtToPhys(virt, pagemapfd) | 0xc0000000; // or virtToPhys(virt, pagemapfd) bcm_host_get_sdram_address() if you can find which header declares this function.

I'm a little unsure of whether this is just bypassing the L1 cache or writing directly to SDRAM though (I'd guess the former, because if the L2-cache is visible to all bus devices, having a dedicated memory range for bypassing it doesn't seem very practical).


Add host info

This is nearly done but waiting on a couple of things:

[x] We are waiting on this PR on the datalab repo to be merged so we can reference that directly. This may not be necessary to wait for but installing with the current dependencies will cause issues.
[ ] There are currently no method to find and download X-ray data.
[ ] There are no test cases written for these classes.

We are waiting on https://github.com/astro-datalab/datalab/pull/72 to be merged so we can reference that directly. This may not
be necessary to wait for but installing with the current dependencies will cause issues.
It seems that we can merge without waiting on this, I got the dependencies to somewhat agree. But, now the python version is slightly more limiting unfortunately, hopefully they merge that PR so this is  fixed fully in the future!


Can't use RunnablePassthrough

System Info
Im trying to implement this in sagemaker with bedrock claude v2
https://github.com/langchain-ai/langchain/blob/master/templates/rag-aws-bedrock/rag_aws_bedrock/chain.py
Here is my code
`import os

from langchain.embeddings import BedrockEmbeddings
from langchain.llms.bedrock import Bedrock
from langchain.prompts import ChatPromptTemplate
from langchain.vectorstores import FAISS
from langchain_core.output_parsers import StrOutputParser
from langchain_core.pydantic_v1 import BaseModel
from langchain_core.runnables import RunnableParallel, RunnablePassthrough

region = "us-east-1"
model_id="anthropic.claude-v2"
# Set LLM and embeddings
model = Bedrock(
    model_id=model_id,
    region_name=region,
    model_kwargs={"max_tokens_to_sample": 200},
)
bedrock_embeddings = BedrockEmbeddings(model_id="amazon.titan-embed-text-v1")

# Add to vectorDB
vectorstore = FAISS.from_texts(
    ["harrison worked at kensho"], embedding=bedrock_embeddings
)
retriever = vectorstore.as_retriever()

# Get retriever from vectorstore
retriever = vectorstore.as_retriever()

# RAG prompt
template = """Answer the question based only on the following context:
{context}
Question: {question}
"""
prompt = ChatPromptTemplate.from_template(template)

# RAG
chain = (
    RunnableParallel({"context": retriever, "question": RunnablePassthrough()})
    | prompt
    | model
    | StrOutputParser()
)
`

got unexpected error:
TypeError                                 Traceback (most recent call last)
Cell In[47], line 40
35 prompt = ChatPromptTemplate.from_template(template)
38 # RAG
39 chain = (
---> 40     RunnableParallel({"context": retriever, "question": RunnablePassthrough()})
41     | prompt
42     | model
43     | StrOutputParser()
44 )
TypeError: Expected a Runnable, callable or dict.Instead got an unsupported type: <class 'langchain.schema.vectorstore.VectorStoreRetriever'>
Name: langchain
Version: 0.0.352
Name: langchain-core
Version: 0.1.2
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction

!pip install langchain==0.0.352

 import os

from langchain.embeddings import BedrockEmbeddings
from langchain.llms.bedrock import Bedrock
from langchain.prompts import ChatPromptTemplate
from langchain.vectorstores import FAISS
from langchain_core.output_parsers import StrOutputParser
from langchain_core.pydantic_v1 import BaseModel
from langchain_core.runnables import RunnableParallel, RunnablePassthrough

region = "us-east-1"
model_id="anthropic.claude-v2"
# Set LLM and embeddings
model = Bedrock(
    model_id=model_id,
    region_name=region,
    model_kwargs={"max_tokens_to_sample": 200},
)
bedrock_embeddings = BedrockEmbeddings(model_id="amazon.titan-embed-text-v1")

# Add to vectorDB
vectorstore = FAISS.from_texts(
    ["harrison worked at kensho"], embedding=bedrock_embeddings
)
retriever = vectorstore.as_retriever()

# Get retriever from vectorstore
retriever = vectorstore.as_retriever()

# RAG prompt
template = """Answer the question based only on the following context:
{context}
Question: {question}
"""
prompt = ChatPromptTemplate.from_template(template)

# RAG
chain = (
    RunnableParallel({"context": retriever, "question": RunnablePassthrough()})
    | prompt
    | model
    | StrOutputParser()
)

Expected behavior

TypeError                                 Traceback (most recent call last)
Cell In[47], line 40
35 prompt = ChatPromptTemplate.from_template(template)
38 # RAG
39 chain = (
---> 40     RunnableParallel({"context": retriever, "question": RunnablePassthrough()})
41     | prompt
42     | model
43     | StrOutputParser()
44 )
File /opt/conda/lib/python3.10/site-packages/langchain_core/runnables/base.py:1937, in RunnableParallel.init(self, _RunnableParallel__steps, kwargs)
1934 merged = {__steps} if __steps is not None else {}
1935 merged.update(kwargs)
1936 super().init(
-> 1937     steps={key: coerce_to_runnable(r) for key, r in merged.items()}
1938 )
File /opt/conda/lib/python3.10/site-packages/langchain_core/runnables/base.py:1937, in (.0)
1934 merged = {**__steps} if __steps is not None else {}
1935 merged.update(kwargs)
1936 super().init(
-> 1937     steps={key: coerce_to_runnable(r) for key, r in merged.items()}
1938 )
File /opt/conda/lib/python3.10/site-packages/langchain_core/runnables/base.py:3232, in coerce_to_runnable(thing)
3230     return cast(Runnable[Input, Output], RunnableParallel(thing))
3231 else:
-> 3232     raise TypeError(
3233         f"Expected a Runnable, callable or dict."
3234         f"Instead got an unsupported type: {type(thing)}"
3235     )
TypeError: Expected a Runnable, callable or dict.Instead got an unsupported type: <

🤖
Hey there, @HannaHUp! Good to see you again. Thanks for reaching out with your issue.
It seems like you're trying to use a VectorStoreRetriever instance as a Runnable in the RunnableParallel constructor, which is causing the TypeError. The RunnableParallel constructor expects a dictionary of Runnable instances, callables, or dictionaries. However, a VectorStoreRetriever is not a Runnable, callable, or dictionary, hence the error.
To fix this, you need to wrap your retriever in a Runnable that can handle it. LangChain provides a RunnableFromMethod class that can be used to create a Runnable from a method of an object. Here's how you can use it:
from langchain_core.runnables import RunnableFromMethod

# Create a Runnable from the retriever's retrieve method
retriever_runnable = RunnableFromMethod(retriever, "retrieve")

# Now use retriever_runnable in your chain
chain = (
    RunnableParallel({"context": retriever_runnable, "question": RunnablePassthrough()})
    | prompt
    | model
    | StrOutputParser()
)

In this code, RunnableFromMethod(retriever, "retrieve") creates a Runnable that, when invoked, calls the retrieve method of the retriever object. This Runnable can then be used in the RunnableParallel constructor.
Please try this solution and let me know if it works for you. If you encounter any other issues, feel free to ask.
For more information about RunnableFromMethod, you can refer to the LangChain documentation.
Sources

libs/core/langchain_core/runnables/passthrough.py
libs/core/langchain_core/runnables/base.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

Got new issue:
ImportError: cannot import name 'RunnableFromMethod' from 'langchain_core.runnables' (/opt/conda/lib/python3.10/site-packages/langchain_core/runnables/init.py)


Are we really going to have more than 1 layer of closures nested?

Harmonize this in prometheus_scrape so we don't need the horrible _recurse_call_chain thing.
Originally posted by @PietroPasotti in https://github.com/canonical/grafana-agent-k8s-operator/pull/95#discussion_r1127761141

Actually done! It just needs a rebuild of grafana-agent-k8s with the new lib.


[Question] Do I have to call GoogleAnalytics.setTrackerId everytime i require the module?

I am requiring the module in multiple files, do I need to set the tracker id multiple times?

Hi @ericraio!
No, this is not required. You only need to do it once, before you do any tracking calls.


Include master channel

I love using the web search interface for getting the TLDR regarding the state of packages in different channels. It'd be nice if the master channel was included to see what's going on in the bleeding edge

That seems like more of a developer use case than a user use case. As a developer, it's not hard to search for issues/PRs mentioning the package you're interested in, or just go to the nixos-unstable source and change the branch to master.
I suspect indexing master would cause unnecessary confusion, and it would fill up our Elasticsearch storage space much faster as it would be reindexed every hour instead of every few days.

Another blocker against following the master is that we don't know if master is actually evaluatable (if that is even word). That is what hydra.nixos.org is for. We just need to wait for successful evaluation there.


Is there a way to add custom properties to PDF

I have used the solution to add Author and Creator to the PDF, but now I need to add a custom property (or a custom metadata) to the document.
Can I do this with this solution ?
I have tried to do this:
const pdfDoc = await PDFDocument.load(pdfBytes, {
    updateMetadata: true
});

pdfDoc.setAuthor("My name");
pdfDoc.setCreator("My Company");

const key = PDFName.of('customName');
pdfDoc.context.obj({}).set(key, PDFHexString.fromText("customValue"));

return pdfDoc.saveAsBase64();

But only the Author and Creator were included to the document.
Thank you and congratulations for the amazing job!

I also checked the #55, but looks like this doesn´t work with the current version.

try
const key = PDFName.of('customName');
pdfDoc.getInfoDict().set(key, PDFString.of('' + value));

const key = PDFName.of('customName');
pdfDoc.getInfoDict().set(key, PDFString.of('' + value));

Thank you @BoLaMN, but with this approach I got the following issue:
Property 'getInfoDict' is private and only accessible within class 'PDFDocument'.
I suppose I have two options here:

Change the PDFDocument to make getInfoDict public
Create a method into PDFDocument to expose a new function to set the custom metadata

Any other suggestions?
Thank you.

try
    let info = pdfDoc.context.lookup(pdfDoc.context.trailerInfo.Info);

    if (!(info instanceof PDFDict)) {
      info = pdfDoc.context.obj({})
      pdfDoc.context.trailerInfo.Info = pdfDoc.context.register(info);
    }

    const key = PDFName.of('customName');
    info.set(key, PDFString.of('' + value));


refactor: make connected account button responsive for small sreens

re #641
Description
Make the connected account button responsive for small screens to prevent overlapping with bandada logo
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information
Small screens

Medium/large screens

Hi @vplasencia PR for #641
I noticed I’m not actually assigned to this one, but I went ahead and tackled it anyway :)

Hi @vplasencia! Let me know if it's okay now, thanks!


Update README.md with use cases Re #65

This is a barebones PR that starts to implement #65. I expect a lot of bikeshedding (Format, content, wording etc).
If there are any academical citation considerations that I need to be wary of, please point it out.
Otherwise I'll just aim to simply list use cases of text-dedup

I was wondering if we could provide more info regarding each use case, such as the data size, data type, method used, hardware, and additional details, if possible. Maybe in a table. This would help people find relevant research as well based on similar settings.

I made a new repository for a wider range of documentation on related topics: https://github.com/ChenghaoMou/awesome-data-deduplication

I will close this for now. Feel free to make PRs to https://github.com/ChenghaoMou/awesome-data-deduplication if needed.


[Idea Code Style] Parameter line wrap

When installing the idea code style, it seems that it does not reflect the parameter-list-wrapping rule. If I have
data class Test(
    private val one: String, private val two: Int,
    private val three: Int, private val four: Int
)

it should be auto formatted to
data class Test(
    private val one: String,
    private val two: Int,
    private val three: Int,
    private val four: Int
)

which is currently not the case.

I believe this was fixed.


--java-jar-compiler is undocumented

The option --java-jar-compiler is undocumented.
Is it intended to stay? Or should I not rely on it?

It should be reliable for the time being at least. It's hidden in --help-full at the moment but it shouldn't be. It should be easy to move it to infer capture --help too (one would need to add ~in_help:CLOpt.[Capture, manual_java] to this function call):
       --java-jar-compiler path
           Specifify the Java compiler jar used to generate the bytecode

Closed by 8c98bee


New Design

This PR makes perl6.org a Bootstrap3/jQuery-based, themable website.
Demo
The demo of what the site will look like, once merged, can be viewed at http://perl6.xtatik.org/

:+1:
If nobody raises any concerns or objects very soon, I'll merge this.

... but how will we attract 9 year old girl programmers without the bright colors?
Yeah, as much as it the word really needs yet another Bootstrap site, :+1:
Also the 6 is falling off the edge of the download button at smaller window widths.

I actually quite like it, but I shouldn't be considered anything like an authority on good web design.
I do think, however, that using a  fairly trendy CSS/Javascript framework like Bootstrap might encourage contributions :) Or has everyone moved on to Polymer or whatever is the new hotness ;-)

Also the 6 is falling off the edge of the download button at smaller window widths.

Fixed! Thanks :)

I like it. Please merge it.
We will not find a consensus based on personal taste.
So let's consider the technical view.
As already pointed out by jonathanstowe, this PR could encourage new contributions.
Regarding the question how to attract 9 year  old programmers without lollipop colors: as this specific target group is so big (irony), I guess a single landingpage will do.
Also, "yet another X" will match anything. Yet another fancy design. Yet another Dancer 2 web site. It boils down to personal taste.


Textual improvements and addition of codeowners

Generic markdown fixes, improvements and fixes
Addition (attempt) of Code Owners

Added MD linting (and forthcoming fixes) as well

Links in the user data README are still a todo, added #274 accordingly for later fixing


WIP Pulling out setup to a script

Current coverage is 36.23% (diff: 100%)

No coverage report found for master at 0410e8c.

Powered by Codecov. Last update 0410e8c...816ac4c

To clarify: this does not pull out the integration setup into its own script. It pulls the bash stuff from .travis.yml into a bin/ script. I needed this mostly in order to debug, but this seems to have some nice value - just not editing a giant YAML document for CI is nice.


Table is not coming across to Obsidian

Tried this multiple times, but the table will not output to Obsidian with or without additional text selected. Even a portion of the table (excluding headings etc) will not work either.
Eg. Site tested here
Latest versions as of 1st of April 2023 for Advanced Tables, Obisidian Clipper and Obsidian. Also using new bookmarklet.

Can you share the browser you are using. I was able to successfully select several tables on this website and have them added to Obsidian properly.

Browser was Chrome 111

I will get my Windows machine back in working order and test things out.

Thanks for posting. Tested on Windows yesterday and see that things are pretty broken. I have a pretty good idea why. I should be able to get a fix out in a few days.

I have some good news and some bad (neutral) news.
The good news is that I have code in test that should fix most of the problems you encountered in Chrome on Windows. I plan to get this finished up and deployed in the next couple of days.
The bad news is that I can't completely fix some of the issues you see in Chrome on Windows because Chrome-based browsers on Windows limit how long a URL can be (roughly 2000 characters), and this plugin sends the highlighted data as part of the URL. I verified that Firefox on Windows doesn't have this issue.

I will give Firefox a try then too :)
Thanks heaos for looking into this one :)

Should be fixed in 0.0.7 #24


Styleguide enforcements

Description of the change: Found some deviation across the repo in the documentation in terms of styling. Found that there was already an existing style guide and made changes accordingly.
Reason for the change: Styleguide.md is there for a reason.
Summary of Changes

Removing 2 spaces after periods [01d9637]
Changing instances of warm up to warmup [5c882d1]
Change stats to statistics [77783f2]
Updating e-mail to Email [20b23f9]
Fixing a when should have been an an [055be75]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @kstolte,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello @kstolte,Thanks again for the PR!                                         You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.                                         Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.                                         Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.                                         If you have any questions you can email us at<EMAIL_ADDRESS>                                        Thank you and Happy Hacktobering!                                         Team SendGrid