Crash on import

I'm trying to run some example code in pybullet, see https://github.com/bulletphysics/bullet3/issues/1234#issuecomment-316521093, that is using baselines but I'm getting an error on import, and they mentioned this is most likely an upstream issue.
I'm on python 2.7.13 on OS X. Perhaps this is a problem with baselines?
athundt at Andrews-2013-MacBook-Pro-2 in ~/src/bullet3/examples/pybullet/gym on master!
± python train_pybullet_racecar.py
pybullet build time: Jul 17 2017 18:59:54
Couldn't import dot_parser, loading of dot files will not be possible.
Traceback (most recent call last):
  File "train_pybullet_racecar.py", line 4, in <module>
    from baselines import deepq
  File "/usr/local/lib/python2.7/site-packages/baselines/deepq/__init__.py", line 2, in <module>
    from baselines.deepq.build_graph import build_act, build_train  # noqa
  File "/usr/local/lib/python2.7/site-packages/baselines/deepq/build_graph.py", line 71, in <module>
    import baselines.common.tf_util as U
  File "/usr/local/lib/python2.7/site-packages/baselines/common/tf_util.py", line 3, in <module>
    import builtins
ImportError: No module named builtins

train_kuka_grasping.py
± python train_kuka_grasping.py
pybullet build time: Jul 17 2017 18:59:54
Couldn't import dot_parser, loading of dot files will not be possible.
Traceback (most recent call last):
  File "train_kuka_grasping.py", line 4, in <module>
    from baselines import deepq
  File "/usr/local/lib/python2.7/site-packages/baselines/deepq/__init__.py", line 2, in <module>
    from baselines.deepq.build_graph import build_act, build_train  # noqa
  File "/usr/local/lib/python2.7/site-packages/baselines/deepq/build_graph.py", line 71, in <module>
    import baselines.common.tf_util as U
  File "/usr/local/lib/python2.7/site-packages/baselines/common/tf_util.py", line 3, in <module>
    import builtins
ImportError: No module named builtins

tf version:
± python -c 'import tensorflow as tf; print(tf.__version__)'
1.2.0

I installed by running pip install baselines, and a full list of installed packages is at https://github.com/bulletphysics/bullet3/issues/1234#issuecomment-316520945

Python 2.7 is not supported. Please use Python 3.0

Easier said than done...

@siemanko Also perhaps the python2 pip package should then be removed or somehow disabled, I installed the package via pip and the install succeeded.

Heck, I've been using my personal utility library for days and mid-day today with no change the mere import of openai in python crashes not just the python script, but the entire calling process.
I changed nothing.

And now it is working again. Go figure
On Tue, Jun 6, 2023 at 10:35 PM Claire CJS @.***> wrote:

Heck, I've been using my personal utility library for days and mid-day
today with no change the mere import of openai in python crashes not just
the python script, but the entire calling process.
I changed nothing.
—
Reply to this email directly, view it on GitHub
https://github.com/openai/baselines/issues/57#issuecomment-1579775769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGAYV4I5OU2RJNEVOBLDBLXJ7SFLANCNFSM4DTVLS6A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Cheers,
-Claire


Setup project directory for Kotlin Samples

This accomplishes the pom file setup for a Kotlin sample app directory in spring-cloud-gcp.
In reference to #1299.

Codecov Report

Merging #1300 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1300   +/-   ##
=========================================
  Coverage     67.76%   67.76%
  Complexity     1372     1372
=========================================
  Files           194      194
  Lines          5568     5568
  Branches        571      571
=========================================
  Hits           3773     3773
  Misses         1556     1556
  Partials        239      239

Flag
Coverage Δ
Complexity Δ

#integration
?
?

#unittests
67.76% <ø> (ø)
1372 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac30ab...950e827. Read the comment docs.


How to send a ephemeral message properly

Description
I'm trying to build this very simple proof of concept where I want to listen to a message, and send an ephemeral message back. The following doesn't seem to work, probably because the response_type is not supported for say():
app.message('hello', async ({ message, say }) => {
          say({
          "response_type": "ephemeral",
          "text": returnMessage
        });
});

But when I try using respond instead:
app.message('hello', async ({ message, respond}) => {
          respond({
          "response_type": "ephemeral",
          "text": returnMessage
        });
});

I get "respond is not function". How to go about this problem? I read the docs, and also found this question that looks related, but I don't really get the answer and how to proceed then... Any help is much appreciated 🙏
Update:
For now, I ended up using the following, but still wondering whether or not it's possible via bolt-js only.
app.message('hello', async ({ message}) => {
        app.client.chat.postEphemeral({
          token: process.env.SLACK_BOT_TOKEN,
          channel: message.channel,
          user: message.user,
          text: returnMessage
        });
});

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

@multispace88 - thanks for writing in, and for providing the code snippets you're using.

For now, I ended up using the following, but still wondering whether or not it's possible via bolt-js only.
app.message('hello', async ({ message}) => {
     app.client.chat.postEphemeral({
       token: process.env.SLACK_BOT_TOKEN,
       channel: message.channel,
       user: message.user,
       text: returnMessage
     });
});

The correct way to use the chat.postEphemeral Web API method in this case would be to access the function via the built-in client which is available as a client param passed to your handler. So that looks similar to what you have above with a slight difference.
app.message('hello', async ({ message, client }) => {          // <--- here
      client.chat.postEphemeral({                          // <--- and here
        token: process.env.SLACK_BOT_TOKEN,
        channel: message.channel,
        user: message.user,
        text: returnMessage
      });
});

Now for a bit more context onsay() - This is a built-in alias for the chat.postMessage function. I expect the original designers built this to make using this common app function a bit streamlined for the most common use case. In this case, say() can't be used to to post an ephemeral message (i.e. use the chat.postEphemeral API method).

Realized I forgot to also answer your question about respond().
"Respond is not a function" is an expected error, as in this case respond is not available to callbacks provided to app.message. Here's our documentation on when to use this function! (You'll notice there respond is used in cases where you're providing a callback function to a specific app.action)

👋 @multispace88, let us know if you need more help here! We'll close this issue after waiting for you response for a few more days.

Let us close this issue now but please feel free to write in whenever you have anything further to ask/discuss here!

Hi! @srajiang and @seratch! Nice to find this question. I have a follow-up question on this. When I was reading the docs, I found this client.postEphemeral method is not suitable to post a large chunk of message (in my case I want to post some analysis results which will be relatively large), and the docs recommend me to use files.upload instead.
For best results, limit the number of characters in the text field to a few thousand bytes at most. Ideally, messages should be short and human-readable, if you need to post longer messages, please consider uploading a snippet instead. (A single message should be no larger than 4,000 bytes.)

But I use chat.postEphemeral for its "only visible to one user" function, after switching to files.upload, I cannot find anywhere in the docs about how I could make this file ephemeral. Is that possible? How could I have "only visible to one user" function when I need to post a large chunk of data?
Thank you very much for your concern and help!

Hi @300LiterPropofol - That's an interesting use case you've described.
You need to send a very large message (file-size) but you're also looking to limit visibility to just the user (hence the postEphemeral). Have you thought about using the ephemeral message to direct the user to the DM with the app, and send a message with the analysis results in file form in there? This is fairly common pattern we use at Slack.
I've asked around to the other maintainers to see whether anyone knows of other workarounds / solutions, and will update if I hear anything else.

@srajiang Really appreciate your quick reply! What you proposed sounds a nice workaround, I will try something on that. Thank you very much!

@srajiang have you come across anything else? I am also coming across this in our app development. We are likely to need to make an update to our app that would add DM functionality, but we do not believe we have it built right today for that. So if there is a method in the short order to be able to support ephemeral posts with file upload, great. If not, then some work to do.


Added option to change IBM api url

I added a parameter api_url to the recognize_ibm function to set the IBM API url manually, since the default url may introduce higher latency.
The issue, i tried to fix, was mentioned here #275 .

Hi @Langhalsdino,
Thanks for the contribution! In the interests of keeping the API simple, I think this unfortunately wouldn't have enough use cases to justify the increase in complexity. I'd certainly be willing to be convinced otherwise, however.
An alternative: a local DNS CNAME or A entry will do the trick, and in my testing, doesn't seem to result in any HTTPS errors.

I understand your point and would fully supported. 👍


Show log(x).since combination in README

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Ensure all commits include DCO sign-off.
[x] Ensure that your contributions pass unit testing.
[x] Ensure that your contributions contain documentation if applicable.

Description

Adds some more detail to the README for the log function, specifically around combining with other filters.

.log.since respects the default count configuration which makes sense but isn't clear in the examples or the docs.
Perhaps naively I expected g.log.since('1 month ago') to return a whole month's worth of commits. Instead it consistently returned 30 which is the default for the count param.  To return a whole month you have to also specify a greater maximum i.e. g.log(1000).since('1 month ago') depending on the amount of activity in the repository.

The build failure for TruffleRuby and JRuby on Windows are expected to fail for the git-2.x gem.

The TruffleRuby build should be resolved with the release of TruffleRuby 24.0.0 and support for that version in the ruby-setup Github action.
JRuby on Windows is awaiting jruby/jruby#7515

You are merging to master which is the git-2.x pre-release branch. There is a 1.x branch for the 1.x release line.

Since you changed your base branch to 'v1' the documentation won't show on the default Github README.md since it is on the default branch of master. Sorry I just noticed that as I hit the merge button.

@mattsalt I merged this PR without realizing that when you changed the base, it pulled all the commits from master that were not also in v1.
Since I caught this issue within a few minutes of merging the change, I ended up force-pushing the v1 branch back to what it was before your PR. You will need to update your local repository to match.  Hopefully I caught this before it impacts anyone else.
Sorry for the mess up on my part for not catching this in my review. I'll add your change in a new PR in just a bit.
That said, since the change is to the README, I think you do want it on the master branch since that is what people see in the Github UI by default. But to atone for my sins, I'll add it in both branches.

Ok, your change has been merged on both master and v1.
Again, sorry for my mistake and the resulting confusion.

Thank you! Apologies, I changed the base branch after what you mentioned in the first comment. I saw the unit tests were still failing so was going to check on that but you're clearly far too quick for me.

Thank you for the contribution @mattsalt.
Approved.
I am thinking of changing the default to return all commits with the 2.x release.
@example Return all commits that meet the critieria
  git = Git.open('.')
  commits = git.log

@example Return at most 30 commits
  git = Git.open('.')
  commits = git.log

The thinking is that is the way that git itself works. I think that the (undocumented) principle of this gem is to provide an interface that adhears closely to the git CLI.
Comments welcome.

Personally that would have been easier to understand as a new user of the library. However once you do understand there is a limit it easy to use with the default.
That said matching the git CLI experience would definitely reduce the onboarding load. I imagine most people using this library for any log related activity would be looking at more than 30 items.


Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding

Description
Introduces AlertDialog.actionsPadding and AlertDialog.buttonPadding properties to allow for customization of the actions at the bottom of AlertDialog.
Discussion
Currently, there is no clean way to provide padding between buttons that does not interfere with the overall padding due to AlertDialog's dependency on ButtonBar. For example, if actionsPadding was set to 8.0 and buttonPadding to 10.0, there will be a total of 18.0 pixels of padding between the edge of the dialog and the start of the buttons, since they are added together. This means that setting padding for individual buttons forces additional padding along the edges of the ButtonBar
Related Issues
Fixes https://github.com/flutter/flutter/issues/47708
Tests

Tests for default actionsPadding and buttonPadding
Tests for custom actionsPadding and buttonPadding

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

Does it fix https://github.com/flutter/flutter/issues/40403?

@bernaferrari I don't believe it does. I took a quick glance at the source code and it appears that this might have something to do with how ButtonBar pads vertically. Do you think you would have some time to look into it?


Pinned pandas version

Newer version makes our build fail.
In general, I think I prefer pinning versions wherever possible, so that someone else upgrading their software doesn't break our code.  We can upgrade to a new pinned version when there's a compelling reason to do so.

Well, the issue with pinning versions is conflicting versions in transitive dependencies...  I guess the policy should be, if there's a version upgrade that breaks our build, we pin the version, then open an issue to remove the pin at some point?


Test issue -- Attempt to repro #6

This issue will be used to attempt to reproduce #6, where team member activity moves an issue back to the Needs Triage column after it's been triaged.

The issue repro'd with the following conditions:

Issue did not have untriaged label
Issue was in the "Triaged" column
A new label was added (but a user with write permissions)

The result was:

The issue was removed from the "Triaged" column (and the project)
The issue was added to the "Needs Triage" column

The issue also repro'd when:

Issue did not have untriaged label
Issue was in the "Triaged" column
A comment was added (by a user with write permissions)

The result was:

The issue was removed from the "Triaged" column (and the project)
The issue was added to the "Needs Triage" column

The issue does not repro when the card was in a team member's triage column.

a61ca53a858f9383358e03ce7f100cd8f4a43450 was committed directly to main to test a condition of only resurrecting if the actor does not have write permission.

c477933 was committed directly to main to test a fix where the resurrection logic is removed from the "Needs Triage" task

facb3b3cde9ccdc12135430088f5ca23bb0a9a93 was committed to main; the resurrection logic was removed from the "Needs Further Triage" task

Testing with "Needs Further Triage" resurrection in place

Testing with 476ed82da5b42791fb00cfda3d24c9483e295441

Testing with a513b20

Testing with 991280b

Testing with d93009d

Testing with 342f89f

👁

Testing somthing!

Testing!

Good day sir!

Hello!


Knex seeds update

Description
Updated migration tables and seed data
Fixes # (issue)
Type of change
Nonbreaking
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change Status

[ ] Complete, tested, ready to review and merge

How Has This Been Tested?

[ ] Test A

[ ] Test B

Checklist

[x ] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] My code has been reviewed by at least one peer
[ x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ x] There are no merge conflicts

Awesome job!! Great catch on the "recipes" migration.
I was able to run this series of commands successfully on my local pg install, no problem:
knex migrate:rollback; knex migrate:latest; knex migrate:rollback; knex migrate:latest; knex seed:run

Note: I have very little trust of Knex not to have weird errors pop up. Thus, doing 2x rollback/latest migrations, to make sure everything is working well. In case anyone was wondering.


Would it be possible to make Postgres bigint map to Go int64 by default?

Currently, it maps to int, which may not actually be 64 bits.
A workaround is for me to pass in --go-type bigint=*int64, but this converts all the non-null bigint columns into *int64s as well instead of int64. If I pass in --go-type bigint=int64, then I lose nullability altogether.
EDIT: Is it intended behavior that trying to map a bigint to an int64 means that all bigint columns (nullable and not-null) become int64 instead of nullable ones becoming *int64 and non-null ones becoming int64?

Would it be possible to make Postgres bigint map to Go int64 by default?

That's admittedly more correct, but less ergonomic (assuming the majority of platforms are 64 bit platforms). I happen to like int so I'm loathe to change it now.

Currently, it maps to int, which may not actually be 64 bits.

Gotcha, I'm used to beefy servers. What platforms does int map to something other than 64 bits?

Is it intended behavior that trying to map a bigint to an int64 means that all bigint columns (nullable and not-null) become int64 instead of nullable ones becoming *int64 and non-null ones becoming int64?

Yes, there's a couple problems with specifying nullability:

A minor concern is there's not a great way to support specifying a null and non-null type with a flag. I could use a comma delimited flag, e.g. --go-type bigint=*int64,int64

It's not possible to infer whether an output column is nullable in anything other than simple cases. Consider SELECT foo FROM some_black_box_function()? pggen can get the type of foo but Postgres doesn't report nullability, so pggen can't know whether foo is nullable or not. I did some incredibly basic null checking in pginfer/nullability  but it's hard to cover any advanced usecases. I think I'd need a real SQL parser and control-flow graph which sounds hard.

The nullability concerns make sense to me --- thanks for the explanation.

What platforms does int map to something other than 64 bits?

This would occur on a 32-bit system, for instance.

This ship has sailed; it's too late to switch from int to int64. A workaround is --go-type bigint=*int64. This would be improved by allowing the user to specify the nullable and non-nullable types.


Items often swap in counterintuitive ways

There should be a stronger connection between where the pointer is and where the placeholder shows. The current element positions shouldn'r really be an input - or at least, their role should be diminished.

Important note: while for most positions on the list the approach "position the item so that it's under the pointer or as close to it as possible" should work just fine, there is a caveat at the end of the list - inserting the element at the end of the list shouldn't require to hit exactly the margin of the container below the last item inside, but should also work over some significant portion of the last item (if any is there). There should probably be a fixed limit of how big that margin is, perhaps linked with placeholderHeight when it's sensible (it may be set to 0!) - so perhaps something like min(0.5*lastItemHeight, max(15, 0.6*placeholderHeight)).

So I expect the drop zones for different positions would look something like this:

but we might also want to ease the difference somewhat, and push the zone for inserting before last item a bit further up into the zone for inserting before last-but-1 item:


Default installation to bower_components

When setting a custom directory in .bowerrc, preen seems to ignore it:
{
  "directory": "/static/vendor"
}

Is there somewhere an additional setting or am I missing something in the documentation? The preen command only gets applied to the bower_components directory.
Referring to this line of code: https://github.com/BradDenver/Preen/blob/master/lib/preen.js#L48

Sorry I have taken so long to respond @FinalAngel I seem to have missed this issue.
I did some testing and could repeat your issue. For me removing the leading slash fixed the issue and didn't cause bower any problems:
{
  "directory": "static/vendor"
}

Let me know if that doesnt work for you.


Add support for automatic provision of SSL certs via Let's Encrypt

In theory, it should be possible to add support for Let's Encrypt inside a Docker container (such as Wordpress).
I've started experimenting with this, but I'm not all the way there yet. I posted up the first issue on ServerFault, which got me a bit further. This does however require a bit more work.

Done in previous commit.


Hive runner doesn't start with ruby 2.2

Hive Runner doesn't start with latest ruby Or default config
Just giving it a try from my own MacBook [Non-BBC]. I got ruby 2.2.1 and installed Hive Runner Gem
                             $ hive_setup my -hive

Used X to continue and exported HIVE_CONFIG to .zshrc
When I ran
                          $ hived start

I got following
                      shashi [workspace/bbc-hive-ci/shashi-hive] → hived start
                            /Users/shashi/.rvm/gems/ruby-2.2.1/gems/chamber-         2.8.0/lib/chamber/settings.rb:276:in `method_missing': undefined method `network' for #<Chamber::Settings:0x007f9af2159b38> (NoMethodError)
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/hive-runner-2.0.1/lib/hive.rb:34:in `block in <module:Hive>'
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/devicedb_comms-0.1.1/lib/devicedb_comms.rb:17:in `configure'
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/hive-runner-2.0.1/lib/hive.rb:33:in `<module:Hive>'
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/hive-runner-2.0.1/lib/hive.rb:9:in `<top (required)>'
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/hive-runner-2.0.1/bin/hived:16:in `require'
from /Users/shashi/.rvm/gems/ruby-2.2.1/gems/hive-runner-2.0.1/bin/hived:16:in `<top (required)>'
from /Users/shashi/.rvm/gems/ruby-2.2.1/bin/hived:23:in `load'
from /Users/shashi/.rvm/gems/ruby-2.2.1/bin/hived:23:in `<main>'
from /Users/shashi/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
from /Users/shashi/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `<main>'

My Config looks like this : I got rid of network level config
                    test:
                   daemon_name: HIVE

              controllers:
                 shell:
                  # Number of shell workers to allocate
                 workers: 5
                 # Queue for each shell worker
                 queues:
                 - bash
              # Number of ports to allocate to each shell worker
                port_range_size: 50
              name_stub: SHELL_WORKER

                 # Range of ports to be made available to workers
                 ports:
                 minimum: 4000
                   maximum: 5000

                 # Logging configuration
               logging:
                    directory: /Users/shashi/workspace/bbc-hive-ci/shashi-hive/log
                     pids: /Users/shashi/workspace/bbc-hive-ci/shashi-hive/pids
                    main_filename: hive.log
                   main_level: INFO
                    worker_level: INFO
                   home: /Users/shashi/workspace/bbc-hive-ci/shashi-hive/workspaces
                   homes_to_keep: 5

                     # Timing configuration
                      timings:
                     worker_loop_interval: 5
                      controller_loop_interval: 5

@jonpwilson Not sure if need network config like certs required when someone tries to install hive locally

Yeah -- you will need the network config or the runner will blow up. Add the following:
network:
scheduler: http://localhost:3000


Survey Data Processing

Survey result data processing

Disaggregate survey result data based on type of meter installed (Ex. Which neighborhoods have which type of meter installed (Kosko & A2EI))
What type of appliances are being used in which neighborhood (e.g. percolator, hot plate, cookstove, EPC, etc.) → 1 indicates yes, 0 indicates no in survey data
Who is electricity being paid to? (Kamyufu, Landlord, Neighbor, Umeme)
Type of Connection (A - Individual metered, B - unmetered, C - Dual metered, D - Collective metered, E - collective unmetered, F - Dual collective metered)

@ericbehling

done


vmss create: warn about the default size change

The first step to deal with #5970

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

Codecov Report

Merging #6526 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           dev   #6526   +/-   ##
===================================
  Coverage    0%      0%
===================================
  Files       11      11
  Lines      133     133
  Branches     9       9
===================================
  Misses     133     133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0023c7...067a8e6. Read the comment docs.


Override recipient email

Ticket Link
1334
List of squashed commits

Override recipient email
Add override to email recipient
Fix email unit test
Add property to properties skeleton
Add space

Test Checklist

[x] Unit Tests Passed:
[x] Jasmine Tests Passed:
[x] General Visual Inspection:

to is an odd variable name. Naming it for its contents is a better practice, which means it will be a noun.

I renamed it to email.send.recipient. I think it sounds better.


Add to brew

I want to install your screen saver but only with brew. Since the deposit has exceeded 50 stars, can you do it please ?
Thanks

@MrZyr0 I need to verify what I need to do to fix the project on M1. I had some kernel panics when using it.

Oh okay I see. Also I use an M1 MAX so for now I can't use this screen saver 😢

@Corkscrews? 🤔


Added Priority Queue .

Solve issue :#1203
Added Priority Queue
This project is a Priority Queue implementation in C using an array. The program creates a priority queue where elements are dequeued based on their priority, with higher-priority elements removed before lower-priority ones.
1.Key Features:

Data Structure: Uses an array to store elements, each with an integer value and a priority.

2.Core Functions:

Insert: Adds an element with a specified priority to the queue.
Remove Highest Priority: Removes and returns the element with the highest priority.
Display: Shows all elements in the queue along with their priorities.

3.User Interface:

A console-based menu allows users to interactively:
Insert new elements,
Remove elements with the highest priority,
Display the queue, or
Exit the program.

not assigned


remove SEH macro from s2ir.c

Ongoing program to remove preprocessor use with prejudice.

Auto-merge toggled on

Thanks!


add catalog deregister command

If you try to register a service like this, you can see that you cannot deregister it using the command "consul-cli service deregister redis1", but you can deregister it with the new command that I added.
cat >test <<EOF
{
  "Datacenter": "dc1",
  "Node": "foobar",
  "Address": "<IP_ADDRESS>",
  "Service": {
    "ID": "redis1",
    "Service": "redis",
    "Tags": [
      "master",
      "v1"
    ],
    "Address": "<IP_ADDRESS>",
    "TaggedAddresses": {
      "wan": "<IP_ADDRESS>"
    },
    "Port": 8000
  },
  "Check": {
    "Node": "foobar",
    "CheckID": "service:redis1",
    "Name": "Redis health check",
    "Notes": "Script based health check",
    "Status": "passing",
    "ServiceID": "redis1"
  }
}
EOF

curl -X PUT -d @test http://localhost:8500/v1/catalog/register
echo "This shows the service was registered"
consul-cli catalog service redis

echo "Try to deregister the service, and it does not work"
consul-cli service deregister redis1
consul-cli catalog service redis

echo "Use the catalog deregister command, and the service is gone"
~/git/godev/src/github.com/CiscoCloud/consul-cli/consul-cli catalog deregister redis1 foobar
consul-cli catalog service redis

I would like to see this along with a catalog register command to support registering external services.


Status is not updated when command is edited or removed

The dependency status of a PR is not updated when the comment with the original command is edited or deleted.
For example, when I write the command /depends on #123 then the status is updated to "blocked by #123". When I realize that I’ve made a typo and I edit the comment so it says /depends on #124 then the status is not updated to "blocked by #124".
The same is true for deleting the comment with the command. I would expect the dependency to be removed.

Closing this as it's no longer valid due to #11
Thanks!


Feat: Function calling and callables

'Callable' is a class that describes something in pychart that is "callable" (jeff() is a function call statement, jeff is callable, so the variable jeff is bound to a Callable instance). In other words, callable is a generic interface we can use to describe things that are callable in pychart like functions.
This means we can write native functions (subclasses of callable) and inject them into the variable environment (I do this with input).
To add grammar rules/new shit like this we need 3 things:

A node to represent this in the syntax tree (Call(Expr) Class, stores the Expr to get the function name + the Exprs used for the args)
A rule in the parser that returns that node (The functions call and finish_call)
An implementation of what to do when the node is encountered (Call.__call__ method)

I don't remember whether we agreed if functions are 1st-class citizens, if so should we enforce some kind of protection of re-assigning native functions?

I don't remember whether we agreed if functions are 1st-class citizens, if so should we enforce some kind of protection of re-assigning native functions?

Don't see why they shouldn't be first class, but we should (be able to) implement that


fix lnurlp and lnurlpayout mypy issue

Codecov Report

Merging #1286 (6437046) into main (268d101) will decrease coverage by 0.10%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   48.61%   48.50%   -0.11%
==========================================
  Files         270      270
  Lines       15674    15667       -7
==========================================
- Hits         7620     7600      -20
- Misses       8054     8067      +13

Impacted Files
Coverage Δ

lnbits/extensions/lnurlp/views_api.py
30.00% <25.00%> (-2.50%)
:arrow_down:

lnbits/extensions/lnurlp/tasks.py
50.00% <33.33%> (+5.55%)
:arrow_up:

lnbits/extensions/lnurlp/views.py
59.25% <100.00%> (-1.46%)
:arrow_down:

lnbits/db.py
81.20% <0.00%> (-10.07%)
:arrow_down:

lnbits/commands.py
73.61% <0.00%> (-1.39%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Include embedded code editor

while most prefer to work in their IDEs it'd be nice to have embedded code editor to have self contained experience in browser for quick changes

depends on https://github.com/hal9ai/hal9/issues/188


[WIP] python3Packages.setuptools: 47.3.1 -> 49.1.0

Motivation for this change
they just did a new release
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build requests

@GrahamcOfBorg build python3Packages.requests

There are some pretty big changes, especially https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v4800, so this needs more extensive testing.

@FRidh yea, that's fair. I wish python packaging wasn't a constantly shifting hot mess.

Also, they seemed to have disabled the disutils adoptions in 49.1 https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v4910

Well, there is no need to update everything all the time either. I mean, as long as things work and you have the features you need, why bother?

there may be sprinklings of small fixes which don't manifest on changelogs?

either way, I think this can wait, seeing at the current staging version is only a week old

going to close this and wait for setuptools to figure-out what they are doing. https://github.com/pypa/setuptools/blob/v49.2.0/CHANGES.rst


Add some structure

As the list is growing I think it would help to add some structure to group the projects. Will make navigating the list a little bit more easy

fixed by #12


Added GreenTeam labels

Hi Chris, first please excuse me the late reply.
The labels are looking good. I just need you to update the documentation so we can move forward with the Pull Reuquest. Thanks

Done. Sorry for the delay.

Hey Christian, sry for the late response. The contribution is good to go. Hope it can still help for the disciplines to come


Test fixture root is not correct for some tests

When running make test, the system will run ./src/bin/parser-test.rs. This tries to find the tests in FIXTURE_ROOT, but they are not present there. However, the tests in the gosub_html5 crate, do find these tests at the correct position, mainly because the FIXTURE_ROOT is a relative path.
We somehow must make this more consistent so we can run both make test, and have the CI pass

Hello everyone!
First time here, I would like to work on this to get familiar with the project.
I think there are a couple ways this could be done reliably that I can think of.

Change FIXTURE_ROOT variable to use env!("CARGO_MANIFEST_DIR") and concat the rest of the path
Find base project root (possibly the Cargo.lock) and use it as the base path and generate the FIXTURE_ROOT from there.

Both options seem reasonable. I would opt for the least amount of change for the enduser (so option 2),.. but having option 1 as a backup (so you can override if the system cannot find it for whatever reason) might be nice too.. I just don't know if that is a lot of work or not..

I'm just able to respond as I was away last week. Honestly the simplest change is the first one as it is basically changing the FIXTURE_ROOT variable.
Second one would be more robust way to do it but if we're not using it anywhere else I don't see the need to add the functionality.

I was reading the docs and I saw in the binaries docs parser-test, this issue is still listed. Should I remove it in this PR?


Code editor: improved search

Find and replace in all files
Improved search in docs
Show the difference between 3.0 and 3.1

Can I try this one? I used it quite a bit during the refactoring of Moon Cheeser :grin:

Sure! You can use moon cheeser for the video too

@NathanLovato what do you think about breaking this into 2 videos?
Godot 3.1 Improved Help System and Godot 3.1 New Find & Replace Project Wide
I just finished the review on the Improved Help System, i.e. docs, and it is quite self contained.

If you want, but is there enough content to do more than 2-3mn videos? If not, better have one 5-6mn video. This series should focus on improvements and new features, not cover the basics. IIRC when it comes to the docs, the main improvement is the search bar is now consistent with the script editor.

Final cut of the Help System is around 7min long, these are the topics I covered:

Quick show the 3.0 help system, for comparison purpose
The Class Search Menu and the Custom Search menu were merged into a single Search Menu
The Search Bar

Occurrences are niched in foldable classes
Search filters (class, method, property, etc...
Case Sensitive Search

Opening the docs through the SceneTree dock

I will record the Find&Replace to see if it can fit into a less than 12min video. The topics covered will be:

Find occurrences project-wide and its features, like defining a folder scope, match case, whole word, etc...
The Search Results tab and its features, like clicking on an occurrence to open it in the Script Editor
Replace and how to filter what will actually be replaced (checking off the marks so you can cherrypick occurrences, etc...)

It's good for 2 videos then! Can you create and self assign a second issue?

Video is done! So, closing it for now, we can reopen if there's something to fix.


Empty response for Assets on entry view route

Description
I use Runway.
I have Entry with Assets type field.
After updating the Runway my assets disappeared from runway entry view page.
I use antlers:
 {{ images }}{{ url }}{{ /images }}

instead of a list of images I get Statamic\Assets\OrderedQueryBuilder. And it returns empty array.
Only {{ image | raw }} returns a list of images.
Steps to reproduce

install the last version of Statamic 4.53.0
require the last version of Runway 6.6.0
create entry with Assets field (multiply items) with handle images
add assets via admin panel
set up runway route /test/{id}
create antlers template with {{ images }}{{ url }}{{ /images }}
open /test/{id} page
no image url is present

Environment
Environment
Application Name: Statamic
Laravel Version: 9.52.15
PHP Version: 8.2.11
Composer Version: 2.6-dev+d2bd9836a604f5b475013c077706e6dc6f420e35
Environment: local
Debug Mode: ENABLED
URL: milsport.localhost
Maintenance Mode: OFF
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: null
Cache: statamic
Database: mysql
Logs: stack / daily
Mail: log
Queue: sync
Session: file
Statamic
Addons: 3
Antlers: runtime
Sites: 4 (Deutsch, Français, Italiano, English)
Stache Watcher: Enabled
Static Caching: Disabled
Version: 4.53.0 PRO
Statamic Addons
appswithlove/statamic-one-click-content-translation: 4.62.0
statamic-rad-pack/runway: 6.6.0
statamic/seo-pro: 5.4.1

I'm unable to reproduce this on my local site, the Assets field is augmenting and returning correctly.
Can you ensure you've added the relevant cast to your model?
// app/Models/Product.php

protected $casts = [
    'images' => 'json',
];

I'm going to close this issue now. However, if you're still experiencing this issue after adding a cast to your model, leave a comment and I can re-open. Thanks!

Thank you!
With the $casts it works


Exclude tests from installs

Should not be desirable anyway, and especially when it installs a global top level package named tests.

Thanks @scop!


Change ValueAndUncertaintyPlot to use abs values for now, at least until we have a better way of showing negative values. (Before it would just error)
hasInvalid(item) fn, to distinguish relative value estimates that are invalid. This is useful to hide/remove these, otherwise they really mess with things. (like averages)
Adds mean to relativeValue, mainly now for development. I feel pretty sure we'll want it, at least for experimentation, and it's cheap to add to the cache for now.
Changes "db" to "om", meaning "orders of magnitude". Code for this is a bit intricate, but it seems to work better, mainly for negative and partially-negative values. Note that we kept "db" as a variable name, in large part because I'm not sure if this change will last, can modify later.

I'm sure some of this could be better organized and similar, happy to accept recommendations/changes.

Codecov Report

Merging #1664 (f34a093) into develop (51c8ecf) will decrease coverage by 2.81%.
The diff coverage is n/a.

:exclamation: Current head f34a093 differs from pull request most recent head afde52e. Consider uploading reports for the commit afde52e to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop    #1664      +/-   ##
===========================================
- Coverage    74.01%   71.21%   -2.81%
===========================================
  Files           93       92       -1
  Lines         5099     4648     -451
  Branches       856      860       +4
===========================================
- Hits          3774     3310     -464
- Misses        1300     1313      +13
  Partials        25       25

see 86 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix "Unexpected fields" in parameter examples

On path parameters with examples the document doesn't validate with ["Unexpected fields: value"]. This is due to probably a typo in Openapi3Parser::NodeFactory::ParameterLike#examples_factory, using NodeFactory::Schema instead of NodeFactory::Example. This PR fixes that.
Example from an OpenApi3 spec:
# openapi.yml
# ...
  '/titles/{title_id}/videos':
    parameters:
      - name: title_id
        in: path
        description: Title ID
        required: true
        schema:
          type: integer
        examples:
          post/201:
            value: 12345

This PR fixes Openapi3Parser.load_file('openapi.yaml').errors resulting in ["Unexpected fields: value"].

Same here, thanks for the quick fix, you spotted it faster than me !

Oh great - thanks for catching this. I'll get a new release made for it shortly.

I've released this as part of version 0.9.0 - thanks again.


custom data

Hi, I want to know if we can run this pipeline on the custom data.

I also have this question


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_4cy0ic5rci/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_4cy0ic5rci/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_4cy0ic5rci/clone/recipe/meta.yaml:29: missing_pip_check: For pypi packages, pip check should be present in the test commands
Errors were found


Hosted fields doesn't load customers' data

I create a Client token with the following c# code:
token = _gateway.ClientToken.generate(new ClientTokenRequest { CustomerId = customerId, MerchantAccountId = MerchantAccountId });

Drop-in form is filled with customer data if a card is assigned to the customer. But hosted fields form is empty
How do i initialize hosted fields form with previously saved customer data?

@denis-bondarenko unfortunately Hosted Fields does not work this way. They are intended to provide SAQ-A compliant entry of sensitive credit card data when creating new payment methods. If you would like to present vaulted card data to a customer in your UI without Drop-in you have to fetch that data server-side and then present it on the client in a manner of your choosing.
Here is the documentation to can find the Payment Methods associated with a customer: https://developers.braintreepayments.com/reference/response/customer/dotnet#payment_methods


multiple outputs

Are you planning to modify it to work even with multiple outputs ?

Hi @davdigioia ! You can use multiple outputs setting the parameter "n_classes" to the number of outputs you want. The minimum is 2.
`from onn.OnlineNeuralNetwork import ONN
#Starting a neural network with feature size of 2, hidden layers expansible until 5, number of neuron per hidden layer = 10 #and two classes (output).
onn_network = ONN(features_size=2, max_num_hidden_layers=5, qtd_neuron_per_hidden_layer=10, n_classes=2)`


compactor: configure via cluster settings

PR: https://github.com/cockroachdb/cockroach/pull/25397
From release notes:

The new compactor.threshold_bytes and max_record_age cluster settings can be used to configure the compactor. [#25397][#25397] {% comment %}doc{% endcomment %}

Resolved by https://github.com/cockroachdb/docs/pull/3363.


Twemoji not working properly when offline

Describe the bug
When Obsidian can't access Internet, Twemojis are not shown properly. Both in the icon selector and in the obsidian explorer, a generic thumnail and a similar Twemoji icon are shown.
To Reproduce
Steps to reproduce the behavior:

Put your PC offline
Try to add icon to a folder and search for a Twemoji icon

Expected behavior
Twemoji should be shown like other icons. Maybe Twemoji icon should be available offline.
Screenshots

Additional context
If Obsidian can access internet, there is no problem.
If I add icons to folder when internet connection is enabled, then the Twemoji icons in the obsidian explorer are shown properly even when offline.

Obsidian: 1.1.9
obsidian-icon-folder: 1.5.1

Thanks for reporting this issue. I am aware of this.
Twemoji is currently integrated into the plugin directly without any way of download this pack or something else. I'll try to search for a solution to download the Twemoji pack, the same like the icon packs.

@FlorianWoelki: On my side, today I have noticed such a Change icon menu:

In general, the previously added icons are still displayed, whereas the newly defined ones are producing simply a blank space (as next to 6_Sport):

If I wait for a while, I will get 2 icons, like the ones posted by the author of this issue: image placeholder icon + twemoji. I've tried restarting Obsidian, as well as using macOS and Windows but the same issue occurs on both systems.

@pyxelr That might be related to https://github.com/FlorianWoelki/obsidian-icon-folder/pull/145

@pyxelr should be fixed now in 1.6.0. Thanks to @dljsjr for the quick response.

Thanks a lot guys!
@FlorianWoelki: I can confirm that it is fixed now. Although, after updating the plugin, the Emoji Style field had been selected to None, so I had to modify it either to Native or Twemoji (which I prefer).

Thanks a lot guys!
@FlorianWoelki: I can confirm that it is fixed now. Although, after updating the plugin, the Emoji Style field had been selected to None, so I had to modify it either to Native or Twemoji (which I prefer).

Yes the default for the Emoji style is None. I'll write that in the release.


Debugging simple program no longer displaying as expected

Kode Studio Version: 16.8.0
OS Version: OS X 10.9.5

Since updating to this latest version of Kode Studio, I've noticed a very simple draw-a-triangle test program of mine no longer draws as expected when running from within Kode Studio.
Whereas previously the triangle would draw large and centered, it currently looks like this:

However, if I build and run the HTML5 target via the command line with the following commands:
node /Kode\ Studio.app/Contents/resources/app/extensions/kha/Kha/make html5
node /Kode\ Studio.app/Contents/resources/app/extensions/kha/Kha/make --server

When viewing it in Safari it looks exactly like I'd expect:

Please note, this is also exactly how it used to display via Kode Studio before the latest update.
Thanks!

Not sure why that happens, can you provide the sample?

Sure thing, I've just uploaded it here:
https://github.com/thoughton/kha-gl-01-triangle

You forgot to call begin/end - things can randomly work when you don't do that but usually they don't.
render should be
private function render(framebuffer: Framebuffer): Void
{
	var g = framebuffer.g4;
	g.begin();

	// Bind the state to draw with
	g.setPipeline(m_pipelineState);

	// Bind the data to be drawn
	g.setVertexBuffer(m_vbo);
	g.setIndexBuffer(m_ibo);

	// Draw
	g.drawIndexedVertices();

	g.end();
}
`

D'oh, that's embarrassing - thank you!
I guess I was caught out by the fact that it used to work before the recent update; but like you say, it seems like that was actually purely by chance...
Thanks again.

It's a common error. Catching it automatically (at least using some kind of debug mode) is on my todo list.


Upgrading from v0.0.20 to v0.1.4 crashes after upgrade

After the upgrade successfully completes, the flutter tool crashes.
e.g. https://gist.github.com/mit-mit/d594f13ee807ea63b08a674a406e20c8
The contents of the crash are https://gist.github.com/mit-mit/89d8cb58c1217f64bec1131d3ab4b319
The relevant lines of the crash are:
ArgumentError: Invalid argument(s): Cannot find executable for <flutter_root>/bin/cache/artifacts/engine/darwin-x64/dart-sdk/bin/dart.

This was fixed by @Hixie in https://github.com/flutter/flutter/pull/14353
See explanation in https://github.com/flutter/flutter/pull/14353#discussion_r170812774


Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature Enhancement - Feature
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?
Currently we have Ansible based CSI operator.
What is the new behavior?
With this change we will have Golang based CSI operator.
How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[x] Large, requires functional and regression testing - Large

Below files are repeated as these files are already there in operator/config dir already. config/ └── olm-catalog └── ibm-spectrum-scale-csi-operator ├── 2.3.0 │   └── ibm-spectrum-scale-csi-operator.v2.3.0.clusterserviceversion.yaml ├── 2.3.1 │   ├── csiscaleoperators.csi.ibm.com.crd.yaml │   └── ibm-spectrum-scale-csi-operator.v2.3.1.clusterserviceversion.yaml ├── 2.4.0 │   ├── csiscaleoperators.csi.ibm.com.crd.yaml │   └── ibm-spectrum-scale-csi-operator.v2.4.0.clusterserviceversion.yaml └── 2.5.0 ├── csiscaleoperators.csi.ibm.com.crd.yaml └── ibm-spectrum-scale-csi-operator.v2.5.0.clusterserviceversion.yaml

Removed duplicate directories and files.


[design] remove extrinsic detail screen in send process

get rid of the extrinsic detail confirmation screen.
when hitting send, the button shall be disabled and show "sending" with an activity indicator. that's it

WIP branch. Currently on ice due to more pressing issues: https://github.com/encointer/encointer-wallet-flutter/tree/cl/remove-tx-confirm-in-send-flow

#647 will almost finish this one. The only thing that is left, is the endorse newcomer extrinsic.


[Bug]: Dimensional Paintings don't teleport to Nether/End

General Info

[X] I am running a modpack
[X] I can reproduce this issue consistently in single-player
[ ] I can reproduce this issue consistently in multi-player
[X] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
[ ] I am crashing and can provide my crash report(s)
[X] I am using the latest version of the mod

Forge version
36.2.39
Mod version
Dimensional-Paintings-1.16.5-1.2.1.jar
Java version
Java 8 update 351
Issue Description
I was doing a playtest of my custom modpack when I tried to reach the Nether using the corresponding painting. The moment I jumped in the classic "Loading terrain..." appears but for some reason it doesn't load the Nether at all.
I haven't noticed this problem until this point because I did all major testing in a Superflat world and in that occasion everything work as intended. I tried to reproduce the bug on a Superflat world but nothing strange happened, but when I tried on another normal world the same issue happened again.
Another thing that I noticed was that the tips from the mod "Tips" weren't showing up during the "Loading terrain..." phase, if this can be of any help.
I can't provide any crash log because the game simply doesn't crash and stays stuck in eternal loading.
Additional Information
No response

I've just uploaded a new version, once it becomes available could you test it to see if the bug has been fixed?

Perfectly fixed!


InverseGamma prior broken

Calling GPy.priors.InverseGamma(1e-3, 1e-3) gives the following error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-23-49ffb5989b64> in <module>()
----> 1 GPy.priors.InverseGamma(1e-3, 1e-3)

/home/reinier/anaconda3/lib/python3.6/site-packages/GPy/core/parameterization/priors.py in __new__(cls, a, b)
    346                 if instance().a == a and instance().b == b:
    347                     return instance()
--> 348         o = super(Prior, cls).__new__(cls, a, b)
    349         cls._instances.append(weakref.ref(o))
    350         return cls._instances[-1]()

TypeError: object() takes no parameters

Probably this is because InvGamma inherits from Gamma

I get the same error running old code which ran fine using python 2.7, after switching to python 3.6.1 and now using GPy's latest release. Has the use of this class changed?

Hello! A bump for this issue, which I am also experiencing.

Hi, another bump for this issue, which is still occurring :)


Please

The FNPC Project branch ， add three functions.
First:Npcs can wear the equipments , you can use the command"/fnpc equipment " to make NPC put on your equipments,Includes enchant equipments.
Second:Npcs can be changed the scale , use the command"/fnpc scale  " to set NPC's scale;
Third: NPC's handheld items can be enchant;
The other:I've fixed some bug of commands.

Well,there's too much breaking update,I can't merge it,
Please keep the same code format and make sure you are modifing the newest version of code,and don't modify the readme.md and plugin.yml....= =

Well，Thanks to you suggestions. I'll follow your advices and fix it soon.


arm32v6 builds are failing

It looks like arm32v6/python:* hasn't been successfully built for four months.  Any ideas how to try to fix it from the console output of the last build?

I'm afraid this is along the same lines as https://github.com/docker-library/php/issues/648, https://github.com/nodejs/docker-node/issues/751, https://github.com/docker-library/golang/issues/196, etc. :disappointed:
(TL;DR: The hardware we're currently performing arm32v6 builds on doesn't support some esoteric instruction that Alpine is now using, which causes the builds to fail.  We have a workaround, but for things which need heavy compilation like Python does, it isn't scalable since it's an emulated VM, and the real arm32 hardware we have access to isn't really performant enough to even consider.)


fix: typechecking fixes for isinstance(whatever,list)

Background
When python global-unit-tests run, python base types ( str, list, dict) are generally used.
When panther_analysis_tool test tests are run, and when the detections-engine is processing events, the base classes of events do not answer to isinstance(whatever, list) or isinstance(whatever, dict). Instead objects answer to isinstance(whatever, collections.abc.Sequence) or collections.abc.Mapping in the case of dicts.
This can lead to scenarios where behavior that is codified in python unit tests do not have the expected result.
There had been a PR  in the past ( #435 )  to excise direct references to panther_core, which provides the PantherEvent types that subclass collections.abc.Mapping & Sequence.
Changes
Look for callers of isinstance(..., list) and isinstance(..., dict) and evaluate if they need updates or not.
No detections or unit tests needed changes as a result of this changeset. Ideally, this is due to isinstance(..., collections.abc.Sequence) being truthy everywhere that isinstance(..., list) is truthy.
Testing
make global-helpers-unit-test
and
make test

checking into another avenue


Download fails after initial sync

Visual Studio Code Version : 1.9.0
Code Sync Settings Version : 2.3.4
Operating System : Windows 10
Occurs On: Download
Proxy Enabled: No
After installing the extension and uploading for the first time the settings.json snippet is created like this
{
    "sync.gist": "some hash",
    "sync.lastUpload": "2017-02-03T09:38:55.389Z",
    "sync.autoDownload": false,
    "sync.autoUpload": false,
    "sync.lastDownload": null,
    "sync.version": 243,
    "sync.showSummary": true,
    "sync.forceDownload": false,
    "sync.workspaceSync": false,
    "sync.anonymousGist": false
}

VS puts squigglies on "sync.lastDownload": null, expecting a string.
When I try to download, the extension fails at let lastDownloadStr: string = syncSetting.lastDownload.toString(): Cannot read property toString of undefined.
Why am I reporting this?
My production VS Code instance doesn't download any changes, even when there is a newer version available. My json always has January, 1st 1970 as the last download date:
{
    "sync.gist": "c6a31b72704b476730646876caaa7140",
    "sync.lastUpload": "2017-02-03T01:41:59.676Z",
    "sync.autoDownload": true,
    "sync.autoUpload": true,
    "sync.lastDownload": "1970-01-01T00:00:00.000Z",
    "sync.version": 243,
    "sync.showSummary": true,
    "sync.forceDownload": false,
    "sync.workspaceSync": false,
    "sync.anonymousGist": false,
}

And I was trying to debug why it doesn't download.

After manually setting "sync.lastDownload": "1970-01-01T00:00:00.000Z", the next debug run shows that VS Settings Sync does indeed read the Gist as cloudSettGist, but it doesn't access its properties to check whether a newer version is online. A search for cloudSettGist at least doesn't yield any results in extension.ts.

So stat is always true because syncSetting.lastDownload 1.1.1970 === cloudSett.lastUpload 1.1.1970.

My next try was to manually set "sync.lastDownload": "2007-01-01T00:00:00.000Z". It downloaded / synced from GH, but after reset to "sync.lastDownload": "1970-01-01T00:00:00.000Z".

Thanks, you can search cloud setting in whole folder and see how its adding in the GIST.
Great to know you have debugged it
Send me a pull request once you solve the issue =)

Thanks, you can search cloud setting in whole folder and see how its adding in the GIST.

What do you mean by that?

Thanks, I will release this in newer version with other fixes.


Add actionable failure messaging to evaluate

While the failure messaging for evaluate is descriptive with the policy declaration, system, and rule that's being violated.
Current state:
root@fa175a43c077:/fides/fidesctl# fidesctl evaluate demo_resources
...
Executing evaluations...
{
  "status": "FAIL",
  "details": [
    "Declaration (Collect data for marketing) of System (demo_marketing_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy)"
  ],
  "message": null
}

Providing actionable/meaningful error and failure messaging helps an implementer clearly know next steps to take whether they

"broke" the build for first-time implementers
are maintaining a fides-annotated project and have now legitimately violated a policy

This issue is to add additional logging to the details node of the failure message here to understand what exactly was failing, for example:
root@fa175a43c077:/fides/fidesctl# fidesctl evaluate demo_resources
...
Executing evaluations...
{
  "status": "FAIL",
  "details": [
    "Declaration (Collect data for marketing) of System (demo_marketing_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy)" because system (demo_marketing_system) contains user.provided.identifiable.contact data
  ],
  "message": null
}

There are likely edge cases where this format might not work, but would like to explore the edges of this with the demo/quickstart repo.

discussed this with @earmenda , and @ThomasLaPiana need your eyes on the below proposal.
The purpose of this issue is to provide actionable failure messaging about why the evaluation failed, however, because the evaluation failure is due to a violating combination of privacy attributes (uses, subjects, category, qualifier) at run time, it doesn't make sense to just include any less than 4 of the attributes in the failure messaging.
So we tried putting all 4 attributes into a sentence in the "details" value in the json object, and it looks really long and unreadable.  As such, wanting to update the evaluate failure messaging to be something to this tune (gisty approximation, don't use this for actual requirements here 😉  )
root@fa175a43c077:/fides/fidesctl# fidesctl evaluate resources_folder
...
Executing evaluations...
{
  "status": "FAIL",
  "violations": [
  {
    "id":1
    "violating_attributes": {
      "data_category":"user.provided.identifiable.contact data",
      "data_qualifier": "aggregated.anonymized.unlinked_pseudonymized.pseudonymized.identified"
      "data_use": "advertising"
      "data_subject": "customer"
      }
    details: "Declaration (Collect data for marketing) of System (demo_marketing_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy) because it contains user.provided.identifiable.contact data for data_subject type customers and data_use advertising."
    },
  {
    "id":2
    "violating_attributes":{
      "data_category":"user.provided.identifiable.contact data",
      "data_qualifier": "aggregated.anonymized.unlinked_pseudonymized.pseudonymized.identified"
      "data_use": "advertising"
      "data_subject": "customer"
      }
    details: "Declaration (Analyze customer behavior) of System (demo_analytics_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy) because it contains user.provided.identifiable.contact data for data_subject type customers and data_use advertising."
    }
  ]
}

Aaaand maybe if the CLI user can include a flag to only make this for a human user using the CLI to be able to read without the json bloat (i know aws cli uses --summarize or eduardo was saying Unix uses-h / --human readable) , we could do something like this:
root@fa175a43c077:/fides/fidesctl# fidesctl evaluate demo_resources --summarize
Evaluation failed!
> Declaration (Collect data for marketing) of System (demo_marketing_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy) because it contains user.provided.identifiable.contact data for data_subject type customers and data_use advertising.
> Declaration (Analyze customer behavior) of System (demo_analytics_system) failed Rule (Reject Direct Marketing) from Policy (demo_privacy_policy) because it contains user.provided.identifiable.contact data for data_subject type customers and data_use advertising.

sidebar: it's worth mentioning that in the future, when/if we can support storing or comparing state of the past resource commits, we would be able to definitively point at a singular violating privacy attribute (ie: data category) within a declaration. For example, last week, a system was not using user.provided.identifiable.contact data, but after this commit, it will be; fides could then point to the exact place where the data category was declared as the reason for this evaluation's failure, where maybe no other privacy attributes changed.
I don't want to blow up the scope for this issue, but wanted to make sure we just get a few eyes on this proposal before proceeding.

Rather than include a --summarize option to condense the output, I would rather we print the condensed output by default. We can include a -v, --verbose option to print the JSON. This feels more aligned with what I've seen in other tools.
Separately, if we so desire, we can include a "fail fast" option, to only display the first violation for a given failed evaluation. It's hard for me to say off-hand if this would actually speed up the fidesctl evaluate run time, or if it would only serve to further condense the output. In general, I don't prefer to use "fail fast" options when they're available, but that doesn't mean it shouldn't be an option here (if there's agreement, demand, etc.).

I think people using the CLI can read JSON, so I don't see the need for another CLI flag. As long as the UI version is human-readable I think we're fine.
@iamkelllly I love the idea of having the violating attributes there!
Overall my suggestions here are:

make the details more verbose as described above. It might be long but it is still very readable to me. This will be useful in the UI view so we might as well store it like that.
Add the violating_attributes field

Rather than include a --summarize option to condense the output, I would rather we print the condensed output by default. We can include a -v, --verbose option to print the JSON. This feels more aligned with what I've seen in other tools.
Separately, if we so desire, we can include a "fail fast" option, to only display the first violation for a given failed evaluation. It's hard for me to say off-hand if this would actually speed up the fidesctl evaluate run time, or if it would only serve to further condense the output. In general, I don't prefer to use "fail fast" options when they're available, but that doesn't mean it shouldn't be an option here (if there's agreement, demand, etc.).

All of the rules and entities are fetched before doing the evaluation, so wouldn't make a difference from a computational standpoint. I don't really see the need for this flag right now, with that in mind


AutoCompleteBox loses selection when context menu opened

Describe the bug
Selection of text get lost when context menu opened.
Moreover, small part of selection (not empty) is expanded to full selection at first time and lost too.
To Reproduce

Write text in AutoCompleteBox
Select part of text (or not)
Right click on selection
Move pointer over context menu items
Cut, Copy items after 4. will be disabled with selection empty

Example styles:
<Styles.Resources>
...
<MenuFlyout x:Key="testTextBoxContextFlyout" Placement="Bottom">
 <MenuItem Header="Cut" Command="{Binding $parent[TextBox].Cut}" IsEnabled="{Binding $parent[TextBox].CanCut}" InputGesture="{x:Static TextBox.CutGesture}"/>
 <MenuItem Header="Copy" Command="{Binding $parent[TextBox].Copy}" IsEnabled="{Binding $parent[TextBox].CanCopy}" InputGesture="{x:Static TextBox.CopyGesture}"/>
 <MenuItem Header="Paste" Command="{Binding $parent[TextBox].Paste}" IsEnabled="{Binding $parent[TextBox].CanPaste}" InputGesture="{x:Static TextBox.PasteGesture}"/>
</MenuFlyout>
...
</Styles.Resources>

<Style Selector="TextBox">
 <Setter Property="ContextFlyout" Value="{StaticResource testTextBoxContextFlyout}"/>
</Style>

Expected behavior
Not lose selection.
Not expand not empty selection.
Avalonia version
11.2.0
OS
Windows, macOS, Linux
Additional context
The same problem with TextBox was solved:
https://github.com/AvaloniaUI/Avalonia/pull/4498

@isergvb if you want to apply a similar fix to that control, a PR is welcome.


Move fetching new tests into function, correct providers

What this PR does / why we need it:
Current script does not work as it returns an exit code of 1 in case of "no tests changed". This modification disables option e for the function in order to return 0 in case of no tests changed.
Furthermore it corrects the default providers that changed until recently.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @danielBelenky
Release note:

NONE

If this works, the flake test job should be successful: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3165/pull-kubevirt-check-tests-for-flakes/1239903439069122560

/lgtm

/retest

/test pull-kubevirt-e2e-k8s-1.16

/test pull-kubevirt-e2e-windows2016

/approve

/test pull-kubevirt-e2e-k8s-genie-1.11.1


SWARM-814: Exclude provided dependencies from package mojo

Quick verification

I'll review this once I am back from the conference. Closing in the meantime.


Web: #nobridge not working for jeromebertaux.be

jeromebertaux.be has #nobridge in its display name and bio, and we detected it, but didn't disable them. Not sure why yet.

https://fed.brid.gy/web/jeromebertaux.be
https://bsky.app/profile/jeromebertaux.be.web.brid.gy

cc @JBertaux

Looks like this was due to #974. We had multiple people with #nobot in their profile try to opt in and get confused when they couldn't.
I'll add some nuance here and make opt in override #nobot but not #nobridge.

Done!


Add port for DirectXMath

I'll try and create a pull request myself, but I don't know the process yet. I'm thinking this is an easy library someone else can create quicker then me.

DirectXMath is already included in MSVC, why should we add another port?

So it is. Guess it ships with DirectX installed with VS2017. Nice.


Support for DoH lookups

One issue I've run into when using zdns is that sometimes, the network firewall intercepts and rewrites DNS lookups (in my case, due to the domain being blocklisted). I don't have the ability to turn this off, so it would be useful if we could circumvent this firewall by leveraging DoH to do mass lookups.
I'd be interested in helping out with the implementation of this but am first wondering whether you all, as the primary maintainers, think that this is in-scope and useful for the zdns project, or if it would be better suited for a different project like zgrab.
Thanks

I'm interested in implementing DoH support for ZDNS. Are there any specific considerations I should keep in mind during the implementation?

Note:  only applicable for external lookups


fix: don't discard default transport settings when turning off TLS verification

Overview
This PR fixes the problem of proxy settings being ignored when TLS verification is disabled.
When REGISTRY_SKIP_VERIFY is set, http.Transport options are being overwritten which discards proxy settings applied previously.
Fixes #85

Thanks for resolving this @victor-tsykanov, much appreciated!


Use openfermion rather than our openfermion clone

Description
After discussing with @mstechly, we decided that it makes more sense to directly use openfermion rather than our clone for this repository.
Please verify that you have completed the following steps

[ ] I have self-reviewed my code.
[ ] I have included test cases validating introduced feature/fix.
[ ] I have updated documentation.

Codecov Report

Merging #22 (fe5b093) into main (81fa231) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   95.58%   95.57%   -0.02%
==========================================
  Files          22       22
  Lines        1315     1312       -3
==========================================
- Hits         1257     1254       -3
  Misses         58       58

Impacted Files
Coverage Δ

src/orquestra/vqa/ansatz/kbody.py
96.36% <100.00%> (ø)

src/orquestra/vqa/ansatz/qaoa_farhi.py
98.11% <100.00%> (-0.04%)
:arrow_down:

src/orquestra/vqa/ansatz/qaoa_warm_start.py
97.87% <100.00%> (-0.05%)
:arrow_down:

src/orquestra/vqa/ansatz/singlet_uccsd.py
100.00% <100.00%> (ø)

src/orquestra/vqa/cost_function/cost_function.py
100.00% <100.00%> (ø)

src/orquestra/vqa/estimation/context_selection.py
97.14% <100.00%> (ø)

src/orquestra/vqa/estimation/cvar.py
100.00% <100.00%> (ø)

src/orquestra/vqa/estimation/gibbs_objective.py
100.00% <100.00%> (ø)

src/orquestra/vqa/grouping/_grouping.py
78.08% <100.00%> (ø)

src/orquestra/vqa/opt/recursive_qaoa.py
100.00% <100.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


HDFS-15904 : De-flake TestBalancer#testBalancerWithSortTopNodes()

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 57s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
18m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 272 unchanged - 4 fixed = 272 total (was 276)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
18m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
342m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

435m 13s

Reason
Tests

Failed junit tests
hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.datanode.TestIncrementalBrVariations

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestNamenodeCapacityReport

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2785

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 702a01889d5f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cb6258690d8037c052628a6e7ab5b6272e83e93

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/1/testReport/

Max. process+thread count
2103 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 46s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
18m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 272 unchanged - 4 fixed = 272 total (was 276)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
19m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
363m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

457m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.TestViewDistributedFileSystem

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestViewDistributedFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2785

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux b3ba5e7aefcb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cb6258690d8037c052628a6e7ab5b6272e83e93

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/2/testReport/

Max. process+thread count
1972 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Could you please take a look @liuml07 @tasanuma ?

Will commit after a good QA. Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
5m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  4s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 31s

trunk passed

+1 :green_heart:
compile
1m 46s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 57s

trunk passed

+1 :green_heart:
shadedclient
21m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 272 unchanged - 4 fixed = 281 total (was 276)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 36s

the patch passed

+1 :green_heart:
shadedclient
21m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
388m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

499m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestDFSShell

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.server.namenode.TestNameNodeMXBean

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.TestStateAlignmentContextWithHA

hadoop.hdfs.TestViewDistributedFileSystem

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2785

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 91504c341942 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5dc3756df6ac30535ec83115dcdb81d091c7df7f

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/3/testReport/

Max. process+thread count
2223 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 30s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 54s

trunk passed

+1 :green_heart:
shadedclient
22m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
1m 35s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 35s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 272 unchanged - 4 fixed = 281 total (was 276)

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
4m  6s

the patch passed

+1 :green_heart:
shadedclient
22m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
258m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+0 :ok:
asflicense
0m 30s

ASF License check generated no output?

368m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot

hadoop.hdfs.TestFileAppend4

hadoop.hdfs.server.namenode.TestNestedEncryptionZones

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2785

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 88858f5b9e16 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5dc3756df6ac30535ec83115dcdb81d091c7df7f

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/5/testReport/

Max. process+thread count
1819 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2785/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

comments: failing tests were not related or due to testing machine out of memory error.
We have so many intermittent failures in HDFS tests. Glad to see bug fixes like this. Thank you!

Thank you for reviews @liuml07 @ayushtkn !


Regression - The entry point cannot be marked as external

Vite version: 2.0.0-beta.52
Node version: v15.3.0
Platform: OS X 11.1
This has only happened in the release since yesterday. Given the following config:
import { resolve } from 'path';
import { defineConfig } from 'vite';

export default defineConfig({
  server: {
    open: false,
  },
  clearScreen: false,
  build: {
    manifest: true,
    sourcemap: true,
    rollupOptions: {
      input: {
        home: resolve(__dirname, './src/home.ts'),
        about: resolve(__dirname, './src/about.ts'),
      },
    },
  },
  plugins: [],
});

When npm run dev is run, the following error occurs:
> error: The entry point "/path/to/wordpress/wp-content/themes/skeleton/src/home.ts" cannot be marked as external

 > error: The entry point "/path/to/wordpress/wp-content/themes/skeleton/src/about.ts" cannot be marked as external

error when starting dev server:
Error: Build failed with 1 error:
error: The entry point "/path/to/home.ts" cannot be marked as external
    at failureErrorWithLog (/path/to/wordpress/wp-content/themes/skeleton/node_modules/esbuild/lib/main.js:969:15)
    at buildResponseToResult (/path/to/wordpress/wp-content/themes/skeleton/node_modules/esbuild/lib/main.js:767:32)
    at /path/to/wordpress/wp-content/themes/skeleton/node_modules/esbuild/lib/main.js:819:20
    at handleIncomingPacket (/path/to/wordpress/wp-content/themes/skeleton/node_modules/esbuild/lib/main.js:566:9)
    at Socket.readFromStdout (/path/to/wordpress/wp-content/themes/skeleton/node_modules/esbuild/lib/main.js:482:7)
    at Socket.emit (node:events:376:20)
    at addChunk (node:internal/streams/readable:304:12)
    at readableAddChunk (node:internal/streams/readable:279:9)
    at Socket.Readable.push (node:internal/streams/readable:218:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:192:23)

npm run build works as expected.

I have replicated this error as well.
Reproduction 🐞
The issue can be replicated in this application, by running pnpm install and pnpm dev.
Notes ✏
build works as expected, so it's probably related to the scanning of dependencies for optimization.
Removing the non-HTML entrypoints, starting the dev server, and moving them back, works as before. This also suggests it's related with the initial esbuild scan.

I have replicated this error as well.
Reproduction 🐞
The issue can be replicated in this application, by running pnpm install and pnpm dev.
Notes ✏
build works as expected, so it's probably related to the scanning of dependencies for optimization.
Removing the non-HTML entrypoints, starting the dev server, and moving them back, works as before. This also suggests it's related with the initial esbuild scan.

I may have a problem with this library "@jamescoyle/vue-icon": "^0.1.0"
Will create a simple use case and see into this problem more

I may have a problem with this library "@jamescoyle/vue-icon": "^0.1.0"
Will create a simple use case and see into this problem more


Heimdall fails to fully flash a large image file

While heimdall technically does not support newer devices such as the GS6,7, etc, it does actually work, more or less. However, the only failure I've encountered is when you ask it to flash a image that is greater than (I'm assuming from previous issues) 2GB. A 1.8gb system.img.ext4 flashes fine, however a 4GB system.img.ext4 fails to flash, silently. It uploads inside of a few seconds, obviously too fast to be transferring 4GB, and the phone fails it for secure check fail. Obviously it didn't transfer the entire image. I've doublechecked that large file support is enabled, and I'm decently sure it is as I compiled the most recent sources myself.
Any ideas? My little project will work flawlessly if I can just convince it to flash these huge 4GB images from newer phones.

Which version of Heimdall are you using?
Precisely how big are the files?
If you're building from source then LFS (large file support) should be enabled. However, the protocol itself is 32-bit, so you can't flash anything larger than 4,294,967,296 bytes.
If Samsung are doing that now, then the protocol must have been updated somehow.

I'm using the latest source from master. I can check the exact byte count when I'm near the computer with the image tomorrow, but if I recall it was 4.1GB, so it should be within that limit. Heimdall doesn't produce any errors, using usb logging doesn't produce any warnings that aren't present all the time, even when it successfully flashes a smaller image. I know it's not the system images fault because I tried with multiple phones and the issue is reproducible. A smaller (1.8GB) system image from a combination file flashes perfectly fine.
It doesn't "fail" from heimdall's side, it uploads a 4GB image in a few seconds, which obviously isn't all 4GB. The phone fails it for security check because it obviously wasn't the full image, and then heimdall looses it's ability to communicate with the phone until it's been rebooted. Being as that no output changes between a working/not working flash, and the only thing different is the size of the file, I'm at a loss. Is there anything I can test to help either of us troubleshoot the issue?

In addition - it almost seems like heimdall is misreading the size of the image and only sending the first few mb, but I'm not sure how to test that theory.

I seem to have narrowed the issue. It's not related to the file size, but rather whether the image is system.img.ext4 versus system.img I believe. A 5GB system.img successfully flashed, but no system.img.ext4 images would flash.