BUG (?): Large changes to Code-Review scores between 4.10.2 and 4.10.5

Describe the bug
4.10.5 gives significantly lower scores for Code-Review than 4.10.2.
I am running Scorecard frequently for some 200 projects. I just upgraded from 4.10.2 to 4.10.5 and noticed that average Code-Review scores are drastically lower: of the 200 projects, 137 saw their score drop. And the average drop (looking only at those projects that dropped) was of ~5 points.

Δ score
# projects

-10
3

-9
6

-8
17

-7
14

-6
17

-5
17

-4
8

-3
21

-2
14

-1
20

0
61

1
2

Reproduction steps
Steps to reproduce the behavior:
Run Scorecard for the following sample projects with 4.10.2 and 4.10.5:

https://github.com/pandas-dev/pandas
https://github.com/systemd/systemd
https://github.com/protocolbuffers/protobuf

Results (trimmed):
# pandas @ 4.10.2
    {
      "score": 9,
      "reason": "28 out of last 30 changesets reviewed before merge -- score normalized to 9",
      "name": "Code-Review",
    },
# pandas @ 4.10.5
    {
      "score": 0,
      "reason": "found 2 unreviewed human changesets",
      "name": "Code-Review",
    },

# systemd/systemd @ 4.10.2
    {
      "score": 8,
      "reason": "18 out of last 21 changesets reviewed before merge -- score normalized to 8",
      "name": "Code-Review",
    },

# systemd/systemd @ 4.10.5
    {
      "score": 0,
      "reason": "found 3 unreviewed human changesets",
      "name": "Code-Review",
    },

# protocolbuffers/protobufs @ 4.10.2
    {
      "score": 9,
      "reason": "28 out of last 30 changesets reviewed before merge -- score normalized to 9",
      "name": "Code-Review",
    },

# protocolbuffers/protobufs @ 4.10.5
    {
      "score": 0,
      "reason": "found 2 unreviewed human changesets",
      "name": "Code-Review",
    },

Running the CLI with --raw and EXPERIMENTAL_V6=1, I took a look at how commits were handled by both versions.
Here are a few cases from pandas-dev/pandas:
https://github.com/pandas-dev/pandas/pull/52308 was merged without review (author was also merger, so it wasn't an implicit review), but 4.10.5 has a "review: APPROVED by mroeschke" result.
# https://github.com/pandas-dev/pandas/pull/52308 @ 4.10.2
{
   ...
    "results": {
        ...
        "defaultBranchChangesets": [
            ...,
            {
                "number": "52308",
                "reviews": [],
                "authors": [ {
                        "login": "mroeschke"
                    } ],
                "commits": [ {
                        "message": "TYP: Remove unneeded type ignore (#52308)",
                        "sha": "ceef0da443a7bbb608fb0e251f06ae43a809b472",
                        "committer": {
                            "login": "github"
                        }
                    } ]
            },

# https://github.com/pandas-dev/pandas/pull/52308 @ 4.10.5
            {
                "number": "52308",
                "reviews": [ {
                        "state": "APPROVED",
                        "reviewer": {
                            "login": "mroeschke",
                            "isBot": false
                        }
                    } ],
                "authors": [ {
                        "login": "mroeschke",
                        "isBot": false
                    } ],
                "commits": [ {
                        "message": "TYP: Remove unneeded type ignore (#52308)",
                        "sha": "ceef0da443a7bbb608fb0e251f06ae43a809b472",
                        "committer": {
                            "login": "github",
                            "isBot": false
                        }
                    }
                ]
            },

https://github.com/pandas-dev/pandas/pull/52316 was reviewed and approved by mroeschke, who then merged it. 4.10.2 presents this correctly, with a review array describing a few comments and then a single approval. 4.10.5, however, shows two approvals by mroeschke. This behavior can be found in a few other PRs.
# https://github.com/pandas-dev/pandas/pull/52316 @ 4.10.2
{
    "number": "52316",
    "platform": "GitHub",
    "reviews": [
        {
            "state": "COMMENTED",
            "reviewer": {
                "login": "mroeschke"
            }
        },
        {
            "state": "COMMENTED",
            "reviewer": {
                "login": "jbrockmendel"
            }
        },
        {
            "state": "APPROVED",
            "reviewer": {
                "login": "mroeschke"
            }
        }
    ],
    "authors": [
        {
            "login": "jbrockmendel"
        }
    ],
    "commits": [
        {
            "message": "PERF: concat_compat (#52316)",
            "sha": "9ba4ef86325abab6029436dcabbe3fab4a60f6ba",
            "committer": {
                "login": "github"
            }
        }
    ]
},

# https://github.com/pandas-dev/pandas/pull/52316 @ 4.10.5
{
    "number": "52316",
    "platform": "GitHub",
    "reviews": [
        {
            "state": "COMMENTED",
            "reviewer": {
                "login": "mroeschke",
                "isBot": false
            }
        },
        {
            "state": "COMMENTED",
            "reviewer": {
                "login": "jbrockmendel",
                "isBot": false
            }
        },
        {
            "state": "APPROVED",
            "reviewer": {
                "login": "mroeschke",
                "isBot": false
            }
        },
        {
            "state": "APPROVED",
            "reviewer": {
                "login": "mroeschke",
                "isBot": false
            }
        }
    ],
    "authors": [ {
            "login": "jbrockmendel",
            "isBot": false
        } ],
    "commits": [ {
            "message": "PERF: concat_compat (#52316)",
            "sha": "9ba4ef86325abab6029436dcabbe3fab4a60f6ba",
            "committer": {
                "login": "github",
                "isBot": false
            }
        } ]
},

I suspect that, in 4.10.5, merging a PR is always being considered an approval, even when the author is the same as the merger. However, somehow the Code-Review score in 4.10.5 is lower, not higher...
Expected behavior
Unclear? Given the dramatic shift in scores, it seems apparent one of the versions (4.10.2 or 4.10.5) is/was giving incorrect results. I intuitively suspect 4.10.2 is correct, but I could be wrong? 🤷♂
Additional context
#2798 would be useful here. Having information of how different PRs/commits are categorized would make debugging and comprehending this sort of thing much easier.
Shoutout to @gabibguti, who helped me do this initial exploration of this behavior.

Most likely due to https://github.com/ossf/scorecard/issues/2450. @raghavkaul fyi.
I strongly think this change was the wrong direction. Not just due to the scoring changes but also the fact that unreviewed bot PRs are an actual threat vector and shouldn't simply be ignored. My comment on the original thread has more details on the reasoning.
I vote that we undo this change. @ossf/scorecard-maintainers please vote so we can reach consensus here.

Yes, I think it makes sense to move back to proportional scoring for unreviewed changesets. The initial reasoning to leveled scoring was that even a single unreviewed PR introduces risk. However, it's way more frequent than we initially expected, even among large, well-maintained projects, that some code is unreviewed, so to bring them to 3/10 or 0/10 doesn't seem like a useful indicator of how seriously they take code review.
I do think we could answer the question of unreviewed PRs by bots with more data (since #2450 actually was more lenient on those, not less lenient, by deducting a constant value).

using proportional scoring is fine with me. But still considering unreviewed bot PRs as unreviewed. Hopefully configuration and support for more "known" bots will help in the long run for repos that use a different review system based on bots.


Do not wait for zmq ports to be used when starting kernels

When we start a kernel we wait for the zmq ports to be used by the kernel.
When the port is used, that tells us that the kernel has successfully started and is ready to receive messages.
However this is an unnecessary and slow step,

zmq protocol doesn't work this way, the messages are buffered until the ports area ready to receieve messages

Given that over 99% of the time things work, there's no need to add any delays in waiting for these ports to get used.
In fact it could break things, as the port finder code uses a port to see whether its free, in that moment its possible the kernel will see the port as being used,

Related issues

https://github.com/microsoft/vscode-jupyter/issues/14835

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/16307


url path is not encoded when deep quering

Bug Report
The url path is not encoded when deep quering. Somewhere there should be an encodeURI when building the url path.
Steps to Reproduce
`
const doc = await payload.findByID({
collection,
id: doc.id,
depth: 1,
showHiddenFields: true
})
doc.image.url == "http://localhost:3000/media/test image.jpg" //true
`
Other Details
Version 1.5.9

Hey @gubarez — we are not currently encoding URLs to media but we certainly could. We will slate this into our workload and get them encoded for you. That is a good call.
Is this preventing you from having something functional? AFAIK you could URL-encode in your frontend where necessary but I actually have never had to do that manually so I'm curious as to what you ran into.
I will convert this to a feature request and add it to our roadmap. Should be able to get to it fairly quickly!


The problem about index: REQUIRED or OPTIONAL?

I have noticed that we describe the index as an optional in here
https://github.com/opencontainers/image-spec/blob/f5f87016de46439ccf91b5381cf76faaae2bc28f/spec.md?plain=1#L5
But we describe that the index.json is REQUIRED in here
https://github.com/opencontainers/image-spec/blob/f5f87016de46439ccf91b5381cf76faaae2bc28f/image-layout.md?plain=1#L28
Is there a conflict description?
FYI I have noticed that the OPTIONAL is added in this PR https://github.com/opencontainers/image-spec/pull/455/files
cc @coolljt0725

The image-layout.md describes the way to organize an image as a directory structure. The index.json file described in the Image Layout spec is specific to the on-disk representation of an image and isn't the same as an "image index" described in the image-index.md file. Perhaps it's worth disambiguating the index.json file in the image-layout.md specification.

I'm closing this out due to a lack of activity. If there is more detail to add or if there are answers to the question above, feel free to follow up in the issue.


Add option to run bootstrap.Main, but not write the ninja file

So that everything is evaluated, but we don't actually write out the
ninja file. This is intended for use by tools to inspect modules that
have been fully created.
Change-Id: I7d1ac436a28ada7d4c1eb2311963aeb1f9df3d4c

Is passing -d on the command line to write a depFile not sufficient?

No, because that happens in bootstrap.Main after your new return statement.

Updated to use the -o parameter instead of adding an interface


unexpected fault address 0xb01dfacedebac1e

What version of Go are you using (go version)?
go version go1.6 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN="/Users/aleksi/Code/My/0xb01dfacedebac1e/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/aleksi/Code/My/0xb01dfacedebac1e"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.6/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.6/libexec/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
https://github.com/AlekSi/0xb01dfacedebac1e
What did you expect to see?
Test fails "normally".
What did you see instead?
=== RUN   TestCrash
unexpected fault address 0xb01dfacedebac1e
fatal error: fault
[signal 0xb code=0x1 addr=0xb01dfacedebac1e pc=0xe081f]

goroutine 5 [running]:
runtime.throw(0x40e958, 0x5)
	/usr/local/Cellar/go/1.6/libexec/src/runtime/panic.go:530 +0x90 fp=0xc82004cd18 sp=0xc82004cd00
runtime.sigpanic()
	/usr/local/Cellar/go/1.6/libexec/src/runtime/sigpanic_unix.go:27 +0x2ba fp=0xc82004cd68 sp=0xc82004cd18
unicode/utf8.DecodeRuneInString(0x35393538203a4449, 0x3237323439303133, 0x410280, 0x6)
	/usr/local/Cellar/go/1.6/libexec/src/unicode/utf8/utf8.go:206 +0x3f fp=0xc82004cd70 sp=0xc82004cd68
strconv.CanBackquote(0x35393538203a4449, 0x3237323439303133, 0x3237323439303133)
	/usr/local/Cellar/go/1.6/libexec/src/strconv/quote.go:177 +0x43 fp=0xc82004cd98 sp=0xc82004cd70
fmt.(*fmt).fmt_q(0xc820060e28, 0x35393538203a4449, 0x3237323439303133)
	/usr/local/Cellar/go/1.6/libexec/src/fmt/format.go:372 +0x8b fp=0xc82004ce18 sp=0xc82004cd98
fmt.(*pp).fmtString(0xc820060dd0, 0x35393538203a4449, 0x3237323439303133, 0xc800000071)
	/usr/local/Cellar/go/1.6/libexec/src/fmt/print.go:527 +0x9e fp=0xc82004ce48 sp=0xc82004ce18
fmt.(*pp).printArg(0xc820060dd0, 0x2fefc0, 0xc820011430, 0x71, 0x0, 0x0)
	/usr/local/Cellar/go/1.6/libexec/src/fmt/print.go:797 +0xd95 fp=0xc82004cfd0 sp=0xc82004ce48
fmt.(*pp).doPrintf(0xc820060dd0, 0x40be08, 0x3, 0xc82004d420, 0x1, 0x1)
	/usr/local/Cellar/go/1.6/libexec/src/fmt/print.go:1238 +0x1dcd fp=0xc82004d358 sp=0xc82004cfd0
fmt.Sprintf(0x40be08, 0x3, 0xc82004d420, 0x1, 0x1, 0x0, 0x0)
	/usr/local/Cellar/go/1.6/libexec/src/fmt/print.go:203 +0x6f fp=0xc82004d3a8 sp=0xc82004d358
github.com/AlekSi/0xb01dfacedebac1e.Inspect(0x2fefc0, 0xc820011420, 0xc820011400, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/inspect.go:11 +0x3e3 fp=0xc82004d4b0 sp=0xc82004d3a8
github.com/AlekSi/0xb01dfacedebac1e.Inspect(0x2e8540, 0xc8200ba980, 0x1, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/inspect.go:17 +0x278 fp=0xc82004d5b8 sp=0xc82004d4b0
github.com/AlekSi/0xb01dfacedebac1e.Person.String(0xc8200ba900, 0x99, 0x0, 0xc8200ba980, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/person.go:17 +0x23e fp=0xc82004d670 sp=0xc82004d5b8
github.com/AlekSi/0xb01dfacedebac1e.(*Person).String(0xc8200ba948, 0x0, 0x0)
	<autogenerated>:1 +0xa2 fp=0xc82004d6a8 sp=0xc82004d670
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.handleMethods(0x5ef8c0, 0x1214920, 0xc820056af0, 0x37b220, 0xc8200ba948, 0x16, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/common.go:137 +0x6e8 fp=0xc82004d780 sp=0xc82004d6a8
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.(*dumpState).dump(0xc82004dad0, 0x3bde80, 0xc8200ba900, 0x99)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:308 +0x496 fp=0xc82004da20 sp=0xc82004d780
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.fdump(0x5ef8c0, 0x1214920, 0xc820056af0, 0xc82004dc78, 0x1, 0x1)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:467 +0x2dc fp=0xc82004db08 sp=0xc82004da20
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.Sdump(0xc82004dc78, 0x1, 0x1, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:482 +0xaa fp=0xc82004db88 sp=0xc82004db08
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert.diff(0x3bde80, 0xc8200ba900, 0x3bde80, 0xc8200ba920, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert/assertions.go:990 +0x1de fp=0xc82004dd80 sp=0xc82004db88
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert.Equal(0x12148f8, 0xc820080090, 0x3bde80, 0xc8200ba900, 0x3bde80, 0xc8200ba920, 0x0, 0x0, 0x0, 0x0)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert/assertions.go:264 +0x9d fp=0xc82004de50 sp=0xc82004dd80
github.com/AlekSi/0xb01dfacedebac1e.TestCrash(0xc820080090)
	/Users/aleksi/Code/My/0xb01dfacedebac1e/src/github.com/AlekSi/0xb01dfacedebac1e/person_test.go:13 +0x1e0 fp=0xc82004df58 sp=0xc82004de50
testing.tRunner(0xc820080090, 0x5eedf0)
	/usr/local/Cellar/go/1.6/libexec/src/testing/testing.go:473 +0x98 fp=0xc82004df90 sp=0xc82004df58
runtime.goexit()
	/usr/local/Cellar/go/1.6/libexec/src/runtime/asm_amd64.s:1998 +0x1 fp=0xc82004df98 sp=0xc82004df90
created by testing.RunTests
	/usr/local/Cellar/go/1.6/libexec/src/testing/testing.go:582 +0x892

goroutine 1 [chan receive]:
testing.RunTests(0x4b7280, 0x5eedf0, 0x1, 0x1, 0x5f7a01)
	/usr/local/Cellar/go/1.6/libexec/src/testing/testing.go:583 +0x8d2
testing.(*M).Run(0xc82004bef8, 0x0)
	/usr/local/Cellar/go/1.6/libexec/src/testing/testing.go:515 +0x81
main.main()
	github.com/AlekSi/0xb01dfacedebac1e/_test/_testmain.go:54 +0x117

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	/usr/local/Cellar/go/1.6/libexec/src/runtime/asm_amd64.s:1998 +0x1
exit status 2
FAIL	github.com/AlekSi/0xb01dfacedebac1e	0.013s

I found this reference for 0xb01dfacedebac1e: https://golang.org/src/runtime/signal_amd64x.go#L53
This crash is originated in seemingly minor change in a large codebase. I spent a couple of hours trimming it down, removing database access, networking, etc. Unfortunately, I wasn't able to make it smaller: every change, even small logging statement seems to "fix" the issue.
It works with Go 1.5.3 on the same Mac.

Paging Mr. Signals, @ianlancetaylor

It's more like a compiler issue or runtime memory corruption.
The argument to strconv.CanBackquote makes no sense at all.
strconv.CanBackquote(0x35393538203a4449, 0x3237323439303133,
0x3237323439303133)

I get something different on OS X at tip:
ward5k:0xb01dfacedebac1e bradfitz$ go version
go version devel +ca56c59 Thu Mar 3 22:28:00 2016 +0000 darwin/amd64
ward5k:0xb01dfacedebac1e bradfitz$ go test -v
=== RUN   TestCrash
fatal error: bad pointer in write barrier

runtime stack:
runtime.throw(0x3b6d2d, 0x1c)
	/Users/bradfitz/go/src/runtime/panic.go:549 +0x8c
runtime.writebarrierptr_nostore.func1()
	/Users/bradfitz/go/src/runtime/mbarrier.go:157 +0x2c
runtime.systemstack(0xc82001e000)
	/Users/bradfitz/go/src/runtime/asm_amd64.s:291 +0x79
runtime.mstart()
	/Users/bradfitz/go/src/runtime/proc.go:1030

goroutine 20 [running]:
runtime.systemstack_switch()
	/Users/bradfitz/go/src/runtime/asm_amd64.s:245 fp=0xc820047880 sp=0xc820047878
runtime.writebarrierptr_nostore(0xc8204dc070, 0x99)
	/Users/bradfitz/go/src/runtime/mbarrier.go:157 +0x3e fp=0xc820047898 sp=0xc820047880
runtime.heapBitsBulkBarrier(0xc8204dc070, 0x10)
	/Users/bradfitz/go/src/runtime/mbitmap.go:439 +0x140 fp=0xc8200478e0 sp=0xc820047898
runtime.typedmemmove(0x29ff80, 0xc8204dc070, 0xc8200479a8)
	/Users/bradfitz/go/src/runtime/mbarrier.go:197 +0x5a fp=0xc820047910 sp=0xc8200478e0
runtime.convT2E(0x29ff80, 0xc8200479a8, 0xc8204dc070, 0x0, 0x0)
	/Users/bradfitz/go/src/runtime/iface.go:144 +0x62 fp=0xc820047930 sp=0xc820047910
github.com/AlekSi/0xb01dfacedebac1e.Person.String(0xc8200dc740, 0x99, 0x0, 0xc82007c200, 0xc8200479d8, 0xc8200479e8)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/person.go:16 +0xdf fp=0xc8200479a0 sp=0xc820047930
github.com/AlekSi/0xb01dfacedebac1e.(*Person).String(0xc82007c1c8, 0x40fb98, 0x6b38f8)
	<autogenerated>:1 +0x63 fp=0xc8200479d8 sp=0xc8200479a0
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.handleMethods(0x559680, 0x6b38f8, 0xc82006a070, 0x35c9c0, 0xc8200dc740, 0x99, 0x0)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/common.go:137 +0x57a fp=0xc820047a60 sp=0xc8200479d8
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.(*dumpState).dump(0xc820047c38, 0x35c9c0, 0xc8200dc740, 0x99)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:308 +0x152d fp=0xc820047be0 sp=0xc820047a60
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.fdump(0x559680, 0x6b38f8, 0xc82006a070, 0xc820047d88, 0x1, 0x1)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:467 +0x120 fp=0xc820047c70 sp=0xc820047be0
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew.Sdump(0xc820047d88, 0x1, 0x1, 0xc821c3e000, 0x7c249e)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/dump.go:482 +0x88 fp=0xc820047cb0 sp=0xc820047c70
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert.diff(0x35c9c0, 0xc8200dc720, 0x35c9c0, 0xc8200dc740, 0x0, 0x3a90d0)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert/assertions.go:991 +0x22e fp=0xc820047e38 sp=0xc820047cb0
github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert.Equal(0x6b38d0, 0xc8200a2120, 0x35c9c0, 0xc8200dc720, 0x35c9c0, 0xc8200dc740, 0x0, 0x0, 0x0, 0x0)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/vendor/github.com/stretchr/testify/assert/assertions.go:264 +0x97 fp=0xc820047ec0 sp=0xc820047e38
github.com/AlekSi/0xb01dfacedebac1e.TestCrash(0xc8200a2120)
	/Users/bradfitz/src/github.com/AlekSi/0xb01dfacedebac1e/person_test.go:13 +0x16b fp=0xc820047f70 sp=0xc820047ec0
testing.tRunner(0xc8200a2120, 0x558bb0)
	/Users/bradfitz/go/src/testing/testing.go:473 +0x7e fp=0xc820047f90 sp=0xc820047f70
runtime.goexit()
	/Users/bradfitz/go/src/runtime/asm_amd64.s:2006 +0x1 fp=0xc820047f98 sp=0xc820047f90
created by testing.RunTests
	/Users/bradfitz/go/src/testing/testing.go:581 +0x313

goroutine 1 [chan receive]:
testing.RunTests(0x40fbd0, 0x558bb0, 0x1, 0x1, 0x320c01)
	/Users/bradfitz/go/src/testing/testing.go:582 +0x359
testing.(*M).Run(0xc82003df08, 0x5bca)
	/Users/bradfitz/go/src/testing/testing.go:515 +0x79
main.main()
	github.com/AlekSi/0xb01dfacedebac1e/_test/_testmain.go:54 +0xb4

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	/Users/bradfitz/go/src/runtime/asm_amd64.s:2006 +0x1
exit status 2
FAIL	github.com/AlekSi/0xb01dfacedebac1e	0.073s

(And no difference if I use -race)

I believe the source of the problem is the vendored copy of https://github.com/davecgh/go-spew. It uses unsafe for some "advanced features". Recompilation with -tags disableunsafe fixed the issue.
I wonder if something can/should be done in Go, or this issue can be closed?

Oh, god, don't read spew/bypass.go.  It made my eyes bleed.
It knows more about the internals of reflect.Value than the reflect package does.

Okay, closing. I think we should make runtime crashes contain a warning at top saying "Warning: unsafe" if any untrusted unsafe code was linked in.

0xb01dfacedebac1e is a poison pointer cleverly designed so that if
0xb01dfacedebac1e is Googled one will get RSC's original CL. It is
probably the result of unsafe pointer abuse.
On Thu, Mar 3, 2016 at 7:34 PM, Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

Closed #14631 https://github.com/golang/go/issues/14631.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/14631#event-577098836.

What about a "Warning: outdated version of a package was used, do so at your own risk" message...
I feel bad because Dave worked hard to catch and fix that problem on Nov 5, 2015, which was days within the reflect change landing in tip, and well in advance of the next Go release that contained the breaking internal reflect changes. But his efforts were compromised by vendoring an outdated version for nearly a year.

@shurcooL when would this warning be printed, which part of the toolchain or runtime should be responsible for printing it ?

I didn't mean that literally. I just wanted to express my frustration with vendoring outdated dependencies that have bugs that have since been fixed in the current release, which is what caused this issue.

I just wanted to express my frustration with vendoring outdated dependencies that have bugs

Vendoring also allows one to vendor outdated dependencies that have no bugs and compatibility problems, unlike current versions. That's the whole point of vendoring.
I'm sure there are several tools to check and update vendored dependencies, one example is https://github.com/divan/gofresh. It's not runtime's responsibility.
And it's also not the right place to continue this discussion. :) Sorry.
For the record: github.com/stretchr/testify is fixed now.


Fixed/855

Report @ 2018/03/04 23:00
Application [COLLECTOR] The topology is incorrect

When entry span layer is MQ:

Use peer id in entry span to find the instance id and application id.
Make the instance id and application id to be the front instance id and front application id of the     reference metric.
Do not create the application mapping metric.

Add the segmentId into BasicTrace which belongs to trace query graphql protocol.

type BasicTrace {
   segmentId: String!
   operationName: String!
   duration: Int!
   start: String!
   isError: Boolean
   traceIds: [String!]!
}

Coverage remained the same at 19.428% when pulling 3d1acbc9ab29e5bc930aabd459337465e89844a1 on peng-yongsheng:fixed/855 into 101fc110277d8f86ab4b28ead251a929767a7fe0 on apache:master.


Initializes Celery app in CeleryEmitter.

Fixes #185

Coverage decreased (-0.6%) to 80.138% when pulling 0d87c2f74e827425de4fbc52b1dbdf389b962d24 on juliomenendez:dont-initialize-celery-in-module into 91da00a0549f05169b179c819028409d3d3f7401 on snowplow:master.

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I signed it!

Thanks! What should I do about the tests failing for Python 3.3? Remove that version entirely maybe?

Good question. For me Python 3.3 doesn't look outdated yet. Let's wait until we have a bandwidth for a new release and we'll decide what to do with 3.3 then.
Also, it looks like problem not in tracker, but in other our project - release-manager, which is a bit suspicious. Maybe we can stick with earlier version (e.g. 0.2.0)

Hi @juliomenendez , thanks for the contribution! It is cherry-picked to the release branch at #224 .


extract auth domain to settings

This extracts the auth domain from xmpp so that it isn't coupled to the window location.
Not sure if this is the correct destination branch. But it seemed that master was quite outdated.

I've been meaning to remove the old integration branch and rename integration-new to integration (basically gets rid of the rtcninja changes which aren't needed anymore) and it closed this PR.  I'll create a new PR for this branch


Update accelerate 0.26.1 -> 0.27.0

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[X] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[X] No, because I don't think it's needed

Have you updated all relevant documentation?

[ ] Yes
[ ] No

Description
This PR updates accelerate to the most recent version.
After some testing, no regressions have been found. This makes sure all deps are as up-to-date as they can be for the next release announced my @Millu on discord.
Greetings and have a nice week.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Actually 0.27.2 was released but it's not mentioned on the github page. Guess we should go with that?

I just saw that a few minutes ago too! Hehe. Updated :)


"The bug assignee didn't login in Bugzilla in the last months" message doesn't sound right

https://bugzilla.mozilla.org/show_bug.cgi?id=1769830#c9

The bug assignee didn't login in Bugzilla in the last months and this bug has severity 'S2'.

The assignee's last activity is from today (2022-07-25 17:02:47 JST).
What actual data does the bot use?
If it's looking the last comment, can the message be rephrased to make it clearer?

Looks like there was a known issue that's being rolled back / cleaned up, per https://bugzilla.mozilla.org/show_bug.cgi?id=1776206#c12 -- @suhaibmujahid said there "there was a problem with the detection of inactive users" and has been doing some bugzilla cleanup (restoring some needinfo's / assignees as in that bug and https://bugzilla.mozilla.org/show_bug.cgi?id=1781041#c1 ).

Exactly, this was a bug in the bot that has been fixed. Suhaib has been cleaning up bad actions from the bot (we stopped it early fortunately... so a lot of bugs to cleanup but not thousands like it could have been!).


use existing types on C# generated code

For instance in rust we have
#[ffi_type]
#[repr(C)]
pub struct Vec2 {
    pub x: f32,
    pub y: f32,
}

#[ffi_function]
#[no_mangle]
pub extern "C" fn my_function(input: Vec2) -> Vec2 {
    input
}

I'd like to use UnityEngine.Vector2 instead of generated Vec2 type.
        /// Function using the type.
        [DllImport(NativeLib, CallingConvention = CallingConvention.Cdecl, EntryPoint = "my_function")]
        public static extern UnityEngine.Vector2 my_function(UnityEngine.Vector2 input);

Is this currently possible?

This isn't supported out of the box. You might get away by setting name and namespace in ffi_type (see reference project), resolve the namespace to UnityEngine, and avoid emitting it in your Interoptopus C# config. I haven't tried this though. Please post results if you try.


Bug: Consecutive Blockquotes Merging

Describe the Bug
After updating to 1.11.0, consecutive blockquotes are merged, the empty lines in between not serving as separation anymore but replaced by ">".
Suspect due to https://github.com/platers/obsidian-linter/pull/658
How to Reproduce
Example to reproduce issue with
> [!quote] Title 1
> The quote 1

> [!quote] Title 2
> The quote 2

Expected Behavior
Keep empty lines between consecutive blockquotes.
Expected output: No change
What I got:
> [!quote] Title 1
> The quote 1
>
> [!quote] Title 2
> The quote 2

I should be able to just do a check if the type is a blockquote and if so a blank line then should not be allowed to go into any non-whitespace line after that.

I believe that I have a fix for this issue. It does not seem too bad to fix, but there may be some other lingering scenarios out there. I am going to double check that I don't see any other issues in my personal vault before continuing with this fix.

Everything looks good, so I will go ahead and get this on master. It should go out with the next release.

The changes should be on master and in the next release. Please let us know if that is not the case.


[bug](shared scan) Fix use-after-free when enable pipeline shared sca…

…nning (#26199)
When enable shared scan, all scanners will be created by one instance. When the main instance reach eos and quit, all states of it will be released. But other instances are still possible to get block from those scanners. So we must assure scanners will not be dependent on any states of the main instance after it quit.
Proposed changes
pick #26199

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Linux Console Odd Text

The odd text in linux console appears to be back. Example 323;1R2
Just type rr and press enter a couple times.

I believe this is related to backspace issues as well

On the latest binaries today. I've been seeing strange stuff come through not only right on the prompt as usual, but within messages that are printed. See:


Simplify Docker Compose Setup (single file)

I think it would be helpful for people just testing InvenTree if one could just download one docker-compose, run docker compose up and have a fully running instance. This would mean we would need to remove the need for a .env and a Caddyfile. I think the .env is simple, for the Caddyfile we would probably need to run publish a custom caddy container that already contains the default file. Thoughts @SchrodingersGat @wolflu05
Originally posted by @matmair in https://github.com/inventree/InvenTree/discussions/6591

Duplicate of https://github.com/inventree/InvenTree/issues/6920


Transmission Delay Calculator

Enter calculator name -
Transmission Delay Calculator
Describe calculator functionality -
The Transmission Delay Calculator takes the length of the message packet and the transmission rate from the Sender and the Receiver of the Signal, and as the name mentions, calculates the Transmission Delay for the Transmission.
Under which category you wish to place it -

[ ] Computer Science
[ ] Mathematics
[ ] Physics
[ ] Chemistry
[ ] Biology
[ ] Art
[ ] Finance
[ ] Scientific
[ ] Health
[ ] Sports
[x] Computer Networks
[x] Let project owner decide
[ ] Suggest a new category - (Answer here)

kindly assign it to me @SarthakKeshari

Hey @ravishrivas,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\computer_science\transmissionDelayCalc
Issue completion deadline - 23rd Oct 12:00:00 noon IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant


Show bounding box on detected object instantly

I am using yolov2tiny my own model i want to detect object from far and near distance but current project is not detecting from far distance and also it need to hold the phone for few seconds to detect from near distance. I want instance detection could you please guide which script do i need to modify. My same model is detecting well on tfunity below project it is detecting from far and near distance instantly with bounding box i need same behavior in this project.
https://github.com/shaqian/TF-Unity-ARFoundation
Thank you.

Hi @syedali1621. You can use a lower confidence threshold for your model at https://github.com/derenlei/Unity_Detection2AR/blob/main/Assets/Scripts/DetectorYolo2.cs#L30.


How can I configure amount of data kept in memory?

In version 1.8 there was a flag (storage.local.target-heap-size) which allowed to configure how much data is kept in memory.
To my understanding this was removed in version 2.0+ due to the use of TSDB storage format.
Where can I find documentation for configuring the amount of data kept in memory for the latest version (2.17)?

Thanks for your report.
In the 2.x relase, you can not configure this. Prometheus will use the RAM it needs, no more, no less.
It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

hi @roidelapluie , is there any reason why this change is not documented at all?
no mention in either https://github.com/prometheus/prometheus/blob/master/CHANGELOG.md or https://prometheus.io/docs/prometheus/latest/migration/

In the migration I see:
-storage.local.* Prometheus 2.0 introduces a new storage engine, as such all flags relating to the old engine have been removed. For information on the new engine, see Storage.


[Bug]: Button "save" not sizing to the longer word "Enregistrer"

Describe the bug
It should display "Enregistrer", but it cuts the end because it is too long and only display "Enregistr". I would suggest to make the size to fit its content or simply make it bigger. Alternatively, I could replace the word "Enregistrer" for something shorter if it is hard to fix.

Steps to Reproduce

Use my branch for the French translation or manually change "Save" variable in AllScreens for "Enregistrer"
In language, select "Français"
In streaming, click on a favorite to open the pop up
Notice the cut out word for the save button

What tracker version are you using?
v8.5.2
What operating system are you using?
Windows 11
What emulator(s) are you seeing the problem on?
Bizhawk 2.8
Relevant log output
No response
Additional Information
Other places where the save buttun is used also have the same issue, such as Edit attempts count or the welcoming message

This appears to be an issue with Bizhawk forms and Windows 11. I tested on Bizhawk 2.8 and 2.9.1 on my Win10 machine, and did not see the same problem.

Closing this as won't/can't fix


Fix zip filename encoding & switch to ZIP_DEFLATED

Closes #94 and #61

Hey @ninjabear - is this WIP or ready for review by @jorgebastida ?

Whoops! I was sure I changed that title. Yes it is ready for review - apologies for the confusion

Hey @jorgebastida - any thoughts on when this might be merged? This is the last dependency on our Kinesis Tee release.

Hi @jorgebastida! I'm guessing you're a bit pushed for time - is there anything I can do to help this PR along?

Thank you very much this! had no idea you where implementing tee using gordon! 👍

Thank you @jorgebastida!
Yes, we love Gordon. We're going to port this other project over in due course too: https://github.com/snowplow/snowplow-aws-lambda-source/issues/3


Checks for "VERIFIED" task status

reference #460
PATCH: tasks/self/:id

check whether task status is "VERIFIED" before, if yes then don't allow the request, if no then only allow the request
if status to be updated is "VERIFIED", then update the endsOn with the current time.

I would like to work on it


[Form output] container size, layout, footer

The mandatory elements include
🟡 typography (#2358),
🟡 container width (1140 px wide)
🟡 header (blue 4px line underscoring the FIP images, #2288)
✅ red underscore for the main header
🟡 footer (date modified)
Most of this can be tackled async, with the exception of the footer. I think the "date modified" would be based on when they publish their form.
This work is detailed out in GC Forms component library: Form output/Examples

This is merged --- typography will be handled in a follow-up PR cc @dsamojlenko

Will close this as the rest is covered under #2358


Refactor TIMDEX models

Why are these changes being introduced:

The timdex model was handling interactions for both search and
retrieve, which are separate interactions that don't intersect other
than the client setup

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/RDI-118

How does this address that need:

The shared timdex graphql client logic is moved to a timdex_base class
and timdex_search and timdex_record are created.

Side Effects:
There may be some confusion calling the new model timdex_record rather than timdex_retrieve. However, other parts of this app are already referring to a single record retrieval as record and not retrieve so for now I think this is the correct name.
Developer

[x] All new ENV is documented in README
[x] All new ENV has been added to Heroku Pipeline, Staging and Prod
[ ] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[x] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
NO
Includes new or updated dependencies?
NO

Pull Request Test Coverage Report for Build 5cd0e1b36d1ad10514d3bdb45d1b156e04db5793-PR-42

16 of 16 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 0a6e5fd0f5def867b481a3ca18270a33364ac8dc:
0.0%

Covered Lines:
132

Relevant Lines:
132

💛  - Coveralls


feat: remove the "graviti/" folder

The Portex based SDK is moved to a new github repo:
https://github.com/Graviti-AI/graviti-python-sdk

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.422%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7803

Relevant Lines:
9029

💛  - Coveralls


react_native_image_palette-Swift.h file not found

Trying to compile my app and it fails in Xcode with the following error:
@somesoap/react-native-image-palette/ios/ImagePalette.mm:3:9: 'react_native_image_palette-Swift.h' file not found
My environment:
RN: 0.76.1
iOS 18.2 simulator

@sohail-wayland hi, thanks for your PR, but it does not seems to be the universal solution.
The issues you've faced seems to relate to 👉 this issue 👈
Check if such import of bridging header works well in your case:
#if __has_include("react_native_image_palette-Swift.h")
#import "react_native_image_palette-Swift.h"
#else
#import <react_native_image_palette/react_native_image_palette-Swift.h>
#endif

Fixed in v1.1.0


Failed when using bug-mining

When I tried to execute the bug-mining process, I went to the step Analyzing the pre-fix and post-fix revisions of the candidate bugs , and when I executed the  initialize-revisions.pl command, I encountered the following error: Unknown layout for revision: 1c174ecb91c245fde68b10b7f5a9ac19b2014400 at /home/bitse/Desktop/D4jNew/defects4j/bug-mining1/framework/core/Project/DbUtils.pm line 101.
I don't know how to solve this error.
I chose DbUtils Component from the Apache Commons Codec project for implementation.
DbUtils
Below are the general properties of the project.
PROJECT_ID="DbUtils"
PROJECT_NAME="commons-dbutils"
REPOSITORY_URL="https://github.com/apache/commons-dbutils.git"

ISSUE_TRACKER_NAME="jira"
ISSUE_TRACKER_PROJECT_ID="DBUTILS"
BUG_FIX_REGEX="/(DBUTILS-\d+)/mi"

How can I solve this problem?
Thank you!

Hi @joonzzh,
Thanks for your question and interest in bug mining. The error implies that Defects4J lacks information on the layout (where the source and test code is) for a checked-out project version.
In the (project name).pm file in defects4j/framework/core/Project/, you need to define the method determine_layout. For an example to follow (Apache Commons Codec), see https://github.com/rjust/defects4j/blob/master/framework/core/Project/Codec.pm
I'd recommend familiarizing yourself with the (project name).pm files, as well as the (project name).build.xml (i.e., https://github.com/rjust/defects4j/blob/master/framework/projects/Codec/Codec.build.xml) files for some of the existing projects, as the offer some lessons that will be useful for new projects.
Hope this helps.

Feel free to open a new issue (or reopen this one) if you have additional questions.
Also, @zzhfocus please let us know what parts of the bug-mining documentation need improvements.

Feel free to open a new issue (or reopen this one) if you have additional questions.
Also, @zzhfocus please let us know what parts of the bug-mining documentation need improvements.


Implement telfhash for ELF import table

I've added tlsh https://github.com/trendmicro/tlsh code into the project and used it to calculate telfhash for ELF import tables.

Lets run TC tests.

Can you send me a file, where it produces some hash? I tried it on retdec-regression-tests/integration/ack/2018-09-13/ack.x64.gcc.O0.g.elf and I got newly added entries for SHA256, MD5, CRC32, but no TLSH. Is it working for you? M'I doing something wrong? This is exactly the thing that regression tests would solve automatically.

This one for example https://www.virustotal.com/gui/file/fb5b5659801beccc790444f5fecb6acc74c10469acf7554f8f1eeea033bbbfe8
I think the file you tested it on has too few symbols to generate the hash from. I am not sure what is the exact minimum input, from the tlsh source it seems to be this #define MIN_DATA_LENGTH              50, the binary you've tried has data length of only 6, as the only non-filtred import symbol is printf. Can be tested by the original telfhash implementation, which outputs tnull:
$ telfhash retdec-regression-tests/integration/ack/2018-09-13/ack.x64.gcc.O0.g.elf -d
ELFCLASS64
8 symbols found
1 symbols considered:
printf
retdec-regression-tests/integration/ack/2018-09-13/ack.x64.gcc.O0.g.elf  tnull

Lets run TC tests.

I've moved TLSH to deps and wrote a CMakeList for it inspired by existing ones, but it's the first time I used CMake so I am not sure if I did it correctly, especially with the cond_add  which I've set if RETDEC_ENABLE_FILEFORMAT is set.
I've added their license file content into the LICENSE-THIRD-PARTY file. But I am not sure what should I put into the license file and version file that I should put among the source files. I've used the latest tagged release https://github.com/trendmicro/tlsh/releases/tag/4.2.1 . The version values are in the CMakeList

After testing out the implementation on 464527 ELF binaries I've found few things about telfhash that I didn't really account for:

telfhash hashes also exported symbols, as in symbols that have value.
telfhash cares only about sections, if the binary has symbols in dynamic segments, telfhash doesn't use them even tho RetDec could because it's capable to extract them.

The first one results in a situation when we have a telfhash, but because there are no imported symbols, there is no import table in the output. Maybe use something else strictly for import table and use telfhash separately? That could also give ability to use symbols from the dynamic segments.

Lets run TC tests.

I moved the telfhash to the ElfFormat and kept the existing implementation in import table as a general import hash. I've also added TLSH hash to every import table, because I thought why not, but I can remove it.
I've tested it and seems to work well compared to original implementation, I think it's ready for re-review.


[Bug]: outline client for windows version 1.13.1 dose not install TAP driver

Application
Outline Client
Describe the bug
During of my 10 times try to install outline for windows version 1.13.1. TAP driver did not installed on windows 10 and 11.
Temp Solution:
1- Install version 1.10.1
2- update to 1.13.1
Steps to reproduce
1- Download Windows version
2- Install APP
3- During Installation you will face TAP installation error
What did you expect to happen?
No response
What actually happened?
No response
Outline Version
1.13.1
What operation system are you using?
Windows
Operating System Version
11
Screenshots and Videos
No response

Why 1.10.1
Because official release is available here:


Postmortem should collect all management Upgrade CR's on OCP/CP4I env

On an upgraded system, we usually generate new upgrade CR's while still keep the old ones around for debugging purposes.
For ex. oc get apic will list all the CR's for ManagementDBUpgrade.
NAME                                                                      STATUS     MESSAGE                                                     AGE
managementdbupgrade.management.apiconnect.ibm.com/minimum-mgmt-up-n4m68   Complete   Upgrade is Complete (DB Schema/data are up-to-date)         43m
managementdbupgrade.management.apiconnect.ibm.com/minimum-mgmt-up-n6f6x   Complete   Fresh install is Complete (DB Schema/data are up-to-date)   95m

I believe we capture this list in postmortem under /kubernetes/namespace/apic/clusters/ManagementDBUpgrade.out but we do not capture the yaml output of all the CR's or even the latest one.
/kubernetes/namespace/apic/clusters/ManagementDBUpgrade.out:
NAME                    STATUS     MESSAGE                                                     AGE
minimum-mgmt-up-n4m68   Complete   Upgrade is Complete (DB Schema/data are up-to-date)         12m
minimum-mgmt-up-n6f6x   Complete   Fresh install is Complete (DB Schema/data are up-to-date)   63m

These CR's will show the history of the management system upgrades.
Can we have these CR's included as part of the yaml collection when we take postmortem?

@ychetanreddy
Per following section of code:
    #grab cluster configuration, equivalent to "apiconnect-up.yml" which now resides in cluster
    CLUSTER_LIST=(apic ManagementCluster ManagementBackup ManagementRestore ManagamentDBUpgrade AnalyticsCluster PortalCluster GatewayCluster)
    for cluster in ${CLUSTER_LIST[@]}; do
        OUTPUT=`kubectl get -n $NAMESPACE $cluster 2>/dev/null`
        if [[ $? -eq 0 && ${#OUTPUT} -gt 0 ]]; then
            echo "${OUTPUT}" > "${K8S_NAMESPACES_CLUSTER_DATA}/${cluster}.out"

            kubectl describe $cluster -n $NAMESPACE &>"${K8S_NAMESPACES_CLUSTER_DESCRIBE_DATA}/${cluster}.out"
            [ $? -eq 0 ] || rm -f "${K8S_NAMESPACES_CLUSTER_DESCRIBE_DATA}/${cluster}.out"

            kubectl get $cluster -n $NAMESPACE -o yaml &>"${K8S_NAMESPACES_CLUSTER_YAML_OUTPUT}/${cluster}.yaml"
            [ $? -eq 0 ] || rm -f "${K8S_NAMESPACES_CLUSTER_YAML_OUTPUT}/${cluster}.yaml"
        fi
    done

the YAML output for the cluster is sent to the directory:
/kubernetes/namespace/${NAMESPACE}/clusters/yaml

In this case, the requested YAML for the requested CR would be in the file ManagamentDBUpgrade.yaml.
Do you have an example where this directory is either missing or not present?

@nitekon1 there can be multiple CR's, so we need to capture them all to /clusters/yaml directory.
For ex. in this instance
/kubernetes/namespace/apic/clusters/ManagementDBUpgrade.out
there are two CRs

minimum-mgmt-up-n4m68
minimum-mgmt-up-n6f6x
which we want to collect during postmortem

If I understand correctly, the following command:
kubectl get ManagementDBUpgrade -o yaml

should also capture these CRs.  Is this assumption incorrect?


Implemente Chromecast or VLNA

Hello, this player is awesome. But i have a doubt, how i send my video to my device Chromecast or VLNA?
Thanks

Does VLAN has API?
You can custom videoplayer by extends JZVideoPlayerStandard


Making scope reference from lazies and providers a weak reference

To avoid having lazies or providers that leaks the contexts after being closed.
So:
If you try to create the instance after the scope has been closed, we fail.

I am not so sure about this one. It will make it harder to detect leaks, it will make the lazies (& providers) differ from injected instances, it will allow to use objects injected within a scope when the scope is dead - which should not happen...
Can we prefer merging the boolean (invalidation of scopes when closed) first, and this one could be added to an internal release to see how it goes. I would say weak references do have a smell..

Coverage increased (+0.07%) to 94.656% when pulling 4203e90442915abc6d650ef21e6f765e18214763 on dmolinero/weak-lazies into 26dc4a0dbaf6e9808de25ebeef9d9947fde37b9e on master.

Ok, let's just merge it, you convinced me. :)

Awesome 💃🏻


The frontend project behaves differently across different environments.

The behavior of running the frontend project locally with npm run dev differs from running it in Docker.
In the Docker environment, all functionalities operate as expected, when running the frontend project locally, the following functionalities are not available:

The Query, Header, and Cookie fields of the TestCase.
Code generation functionality.

I encountered this issue on different operating systems, including Linux and Windows, which necessitated rebuilding the Dockerfile for debugging, I haven't worked with frontend before, so I haven't been able to pinpoint the issue yet.
On a side note, while running npm run dev on Windows, I encountered a "vite HTTP proxy error".

The solution was to modify the proxy rules in vite.config.ts. If the proxy rule is set to localhost, it should be changed to the local machine address (<IP_ADDRESS>), and vice versa. —— from https://github.com/vitejs/vite/discussions/7620

Running ./api-testing server without providing the necessary parameters caused some errors during YAML parsing on the server side. In any case, simply running make run-server directly will suffice. I hadn't noticed the Makefile file before.


CORE Engine issue #521

This PR is to address CORE Engine issue #521: https://github.com/cdisc-org/cdisc-rules-engine/issues/521

All comments were addressed and a PR was raised also on rules-engine

Code changes copied over and replaced by: https://github.com/cdisc-org/cdisc-rules-engine/pull/703


AST: Fix ValueDecl::isNativeMethodReplacement

When we want to figure out whether a @_dynamicReplacement(for:) decl
should use native method replacement we need to check whether the
replaced decl is objc dynamic in a generic class.
rdar://87428993

@swift-ci Please test


/services/horizon/ingest: captive core on-disk ingestion, optimize catchup times

What problem does your feature solve?
Long ingestion catchup times from captive core on-disk mode for pubnet observed during horizon start up.
These times were observed on the following environment:
stellar-core 19.0.1
horizon 2.17.1 with an already full ingested history db of pubnet
CPU - 3 cores
32GB ram
500GB disk, 3K IOPS
on-disk pubnet(1h15min for catchup, 1h25min total for latest ledger sync)
20:30:46 stellar-core new-db
20:30:46 stellar-core catchup 41746401/0
21:43:39 stellar-core run
21:45:52 horizon reports "Range prepared duration=4506.688054431 from=41746403"
... ledgers emitted on txmeta, horizon is logging ingested ledgers to history
21:55:10 stellar-core run reports "LM_CATCHING_UP_STATE -> LM_SYNCED_STATE"

on-disk logs
in-memory pubnet(2min total for catchup and latest ledger sync)
20:18:27 stellar-core run --in-memory --start-at-ledger 41746276 --start-at-hash xyz
20:20:44 horizon reports "Range prepared" duration=137.273946913 from=41746277"
... ledgers emitted on txmeta, horizon is logging ingested ledgers to history
20:20:54 stellar-core run reports "LM_CATCHING_UP_STATE -> LM_SYNCED_STATE"

in-mem logs
These on-disk times were observed on environment with faster SSD disk for comparison:
stellar-core 19.1.0
horizon 2.18.1 with an empty history db
CPU - 8 cores
16GB ram
500GB disk, 2G/s IOPS(avg rate read/write)
on-disk pubnet with faster disk(35min for catchup)
14:09:59 stellar-core new-db
14:09:59 stellar-core catchup 41746749/0
14:45:12 stellar-core run
14:46:44 horizon reports "Range prepared" duration=2206.337728458 from=41746751"
... ledgers emitted on txmeta, horizon is repeatedly logging
Processing ledger entry changes pid=4073 processed_entries=XXX progress="XX.XX%"
...
let it run for another 45min, stayed in this pattern of log output, didn't see LM_SYNCED_STATE emitted, stopped process at this point."

ssd on-disk logs
summary observations:

The stellar-core run --in-memory invocation takes a couple minutes at most for catch up and emitting latest ledgers on tx meta output.
The on disk mode to perform catchup was observed taking longer time, 35mins to over an hour.
The catchup times for on-disk vary and are dependent on the IOPS of the disk that stellar-core's stellar.db is located, fastest observed catchup time so far was 35min on SSD disk with 2Gb/s IOPS.

What would you like to see?
identify solutions to address the on-disk ingestion catch up time.

operator has a new optional horizon command line flag which can be set to force horizon to tell captive core to use an existing on-disk core db rather than init'ing empty at startup, could result in faster startup times as sync is only needed from youngest ledger in the db. Needs to be validated if a populated db from prior core process can be re-used from a new core process or does it ignore/wipe it or fail.
other ideas

What alternatives are there?
use older in-memory configuration for captive core, but that is running into limitations due to the 30+Gb of RAM required, on-disk mode of captive core is preferred.

@jacekn , I captured ingestion run times of in-memory and on-disk captive core using the  k8s horizon-dev horizon-pubnet-ingest-0 pod as the compute environment, measurements are in the description above, results show similar contrast in times between disk and memory modes as you reported.

@sreuland something to note is that with in-memory config core syncs almost instantly on restarts. This was one of the things we spent time optimising for when captive core was first introduced.

@jacekn , thanks for that context.
@bartekn , I wanted to check on ideas, I tested skipping of new-db locally by running stellar-core catchup <ledger_no>\0 with an existing db that already has some ledger state and an LCL(last closed ledger), core will run those invocations, but only if ledger_no is greater than it's internal LCL, it does not allow catchup going backwards in the db. That becomes an issue for ingesting horizon restart scenario, because in that mode, stellar-core run is active process and it's updating LCL to most recent from network pretty quickly, but horizon ingestion history is going to be a couple ledgers behind that since it has to receive each ledger from core's tx meta stream first, and run it through ingestion pipeline, which would mean on a restart, horizon tries to resume ingestion at <last_history_ledger> + 1, which likely will be a sequence that is behind core's LCL in it's db, and then horizon ingest state machine is just stuck, as it won't be able to get this captive core instance to rewind the LCL back to ledger sequence <last_history_ledger> + 1 and start emitting tx meta from there. This is why the stellar-core new-db is important, as it resets core's LCL to genesis(sequence=2), that way, the next catchup can fast-foward the core to any sequence.
Seems like options are steering towards looking into why stellar-core catchup <ledger_no>\0 on-disk is taking time, it has been observed in tests, that timing is proportional to disk IOPS, but even on 2Gb/s SSD disks am observing 30+mins on catchup times. Maybe there's other sqlite3 features that can be leveraged, like localhost mode, o/s pipe rather than over tcp/ip etc.

@sreuland great research! So the interesting bit is what you said about Stellar-Core only being able to close ledgers moving forward. This complicates the problem because, currently, in most cases Horizon ingestion is behind Stellar-Core. First because it keeps all new ledgers in a buffer (of 20 ledgers), and second when Horizon is up to date and new ledger is closed it can only ingest this ledger once Stellar-Core closes it.
I think there's another option that should work in many cases however it can still require occasional new-db call. If we remove the internal buffer of ledgers in Captive-Core (so Core will block until Horizon picks the ledger) it should help in most cases. The only exception is when Horizon crashes during ledger ingestion but this shouldn't normally happen because graceful shutdown allows ingesting the currently ingested ledger.
The only problem I can see with the solution above is that it can slow catchup in some cases because Stellar-Core will have to wait until Horizon ingests the ledgers. However it shouldn't be a problem in normal operations.

OK, I think the solution in my previous comment works and if an instance is fully synced we don't even need to remove the buffer! Here's what I did:

I started removed the code responsible for removing the storage dir on shutdown below:                // We also remove the storage path if there was an error terminating the
                // process (files can be corrupted).
                // We remove all files when reingesting to save disk space.
-               return os.RemoveAll(storagePath)
+               // return os.RemoveAll(storagePath)
        }

and started ingesting instance with CAPTIVE_CORE_USE_DB=true. Waited for it to catchup then I stopped it. Thanks to my code change, on-disk DB wasn't removed on shutdown.
Then in stellarCoreRunner.runFrom I removed entire if r.useDB ... else ... condition and left:	r.cmd = r.createCmd(
		"run",
		"--metadata-output-stream", r.getPipeName(),
	)

This will make Stellar-Core just start closing ledger where is left before shutdown which is exactly the range Horizon needs.

It works but there are several problems:

If Horizon was closed during catchup mode (so when catching up to latest ledger after some time of being offline) it's possible that buffered meta pipe would consume some ledgers which would make ingestion of older ledgers impossible. To solve this I think we can remove buffered meta pipe usage outside reingestion. Usually in such cases Horizon needs to ingest just a small number of ledgers.
To simplify things I changed the code between Horizon executions. If we decide to go with this solution we probably need to implement code that checks if there's a core DB in storage dir (and if possible check the latest ledger in this DB) and run a new flow only if the requested ledgers is exactly N+1 the ledger in core DB.

@bartekn @paulbellamy , per design chat in team mtg, and @bartekn 's second bullet on design idea, i checked core's offline-info response and it looks like it provides the LCL on the db:
stellar-core --conf stellar-core.conf offline-info
returns json, with:
"info": {
  "ledger" : {
         "age" :<PHONE_NUMBER>,
         "baseFee" : 100,
         "baseReserve" : 100000000,
         "closeTime" : 0,
         "hash" : "39c2a3cd4141b2853e70d84601faa44744660334b48f3228e0309342e3f4eb48",
         "maxTxSetSize" : 100,
         "num" : 1,
         "version" : 0
   }
}

I'm don't recall exact meaning of LCL, I think it refers to the internal state of what core has last processed and not latest network status or vice versa. if so, perhaps it can be used in horizon stellar-core-runner in conjunction with @bartekn's suggestion to dynamically figure out whether to run new-db or not.

PR ready: https://github.com/stellar/go/pull/4471.


nixd: 2.5.0 -> 2.5.1

Diff: https://github.com/nix-community/nixd/compare/2.5.0...2.5.1
Changelog: https://github.com/nix-community/nixd/releases/tag/2.5.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

already in master


Documentation update

In the "Getting Started", the script to generate the ssh key uses Linux/openssl. I wasn't able to make it work with Git Bash on Windows. Instead, I've used the code :
ssh-keygen -t rsa -b 4096 -f config/jwt/jwtkey
It would be worth to add it in the documentation to help people with my configuration.
Also, the pub file was generated under :
config/jwt/jwtkey.pub
Maybe something to mention too.

Hi again,
after some changes, it seems I couldn't make the JWT library work. This is because the LexikJWTAuthenticationBundle is dependent on the openssl library. I don't remember seeing that it was informed anywhere so I would recommend to either inform everyone about this or to fix this hard dependency. In the former, I would suggest to add a step by step tutorial on how to create openssl private keys from GitBash on Windows. This would greatly help.
Also, I've found in : CLASS : LcobucciJWSProvider LINE : 94 that the Exception was caught, but nothing was thrown. It would have greatly helped my investigation if it :

Had not been caught
Logic had been in place to warn the programmer of the error.

I managed to make the openssl commands in the Get Started documentation work. Simply use :
$ winpty openssl genrsa -out config/jwt/private.pem -aes256 4096
$ winpty openssl rsa -pubout -in config/jwt/private.pem -out config/jwt/public.pem

I hope this helps future developers like me. In any other case, I think it would be also nice to have the whole system not dependent on openssl, but to also allow ssh-keygen keys.
Good luck in your projects!

Now you may use php bin/console lexik:jwt:generate-keypair to generate key without worrying anything.


Adding support for HPC clusters

I have been searching, without success; for a solution that will support high performance computing clusters.  These consists of running 2- many computing clusters, each with multiple gpus.
Would need gpu metrics per server and combined per cluster.
There are numerous people looking for a solution for this.
I love this tool for one servers, but it won't work for clusters.  I have yet to find a solution for clusters.
Thank you
Andrea

AFAIK there are places doing exactly that, using this tool on production. Are we talking about Kubernetes clusters? If so, there's the Helm chart you can use: https://github.com/utkuozdemir/helm-charts/tree/master/nvidia-gpu-exporter
The regular setup of kube-prometheus-stack and this chart should work just fine, you need to enable serviceMonitor.enabled=true in the values and you should be good to go.
Even if we are not talking about Kubernetes clusters, you can simply install the exporter to each machine and configure Prometheus to scrape all of them. The exporter exposes metrics for all GPUs on the machine distinctly over their UUID. What is the issue you are facing when using this tool with multiple GPUs and multiple machines?

These are not Kubernetes clusters.  This are something similar to beowulf clusters.  Multiple servers with gpus with a common file system and a head node for submitting jobs with a tools like slurm scheduler.
This types of clusters are running generative AI and other applications requiring large amounts of computing power.


EBP: Improve Manual data fixes page styles

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] screenshots are included showing significant UI changes

Description of change
#1983

Removed indentation of p tags within manual data fix page
Added consistent top and bottom padding to the buttons on the page

Looks good. However it looks like it still needs more space between the radio buttons and the button. Maybe those radio buttons need a margin or padding?

@edalex-ian Added in the padding, sorry about that.

Increased the font size of the radio button labels to match the other labels, and made the radio buttons side-by-side.


Add new attack technique for Kubernetes persistence

What does this PR do?
Adds a new Attack technique which creates and approves a Kubernetes Client Certificate with a username of system:kube-controller-manager which is a standard high-privileged user account in Kubernetes.
As Kubernetes does not allow for certificate revocation, this is a good persistence technique for attackers who have gained access to Kubernetes clusters (similar to the Token Request API)
Motivation
There's two motivations for this technique. First is the standard of ensuring that cluster auditing are picking this up correctly. The second is with managed Kubernetes testing implementations to see if this feature works. For example in EKS it is not documented clearly whether general CSR process works.
Checklist

[X] The attack technique emulates a single attack step, not a full attack chain
[ ] We have factual evidence & references that the attack technique was used by real malware, pentesters, or attackers
[X] The attack technique makes no assumption about the state of the environment prior to warming it up

LGTM :)


window.isTerraExtensionAvailable is true but ext do not open

I'm trying to inject a wallet in terra dapps and i have debugged the wallet provider from where i check is looking for prop in window which is isTerraExtensionAvailable, I have mine setted to true but still my wallet is not recognized from the dapps any suggestions on that? Thanks in advance!

If you are using https://github.com/terra-money/wallet-provider could you post this issue there?

So basically i'm using Liquality Wallet and I'm trying to inject it in terra dapps


Remove dash, sort by ASCII to int

Release Note

Remove dash in export filenames, sort by ASCII to int

/assign @mikehelmick

/lgtm

/retest

/rest

/retest


Note that app[method] names are lowercase

It's mentioned in the API docs, but not here. It lacks clarity because the HTTP method names are uppercase, and these docs use a convention of representing placeholder values in uppercase (e.g. app.METHOD) .
And link to fragment about request methods.

Good clarification, thanks!


Standardise EXTNAMEs for HDUs

While EXTNAMEs for Event lists and GTIs are uniform in different data productions - it is always EVENTS and GTI, the same is not true for IRF components. For example, in the H.E.S.S. 1st data release they are in the abbreviated form AEFF, EDISP, while in the CTA 1DC data they are instead in the extended form EFFECTIVE AREA, ENERGY DISPERSION.
Would it be a problem to add to the specs a mandatory EXTNAME?
The only recommendation I found is this on the effective area and no other.
Any thoughts on this?
Thanks

It's mostly for science tools, If I want to load an IRF directly from a HDU I have to open the header and search in the specific HDUCLAS* keywords. But if the IRF component had a standardised EXTNAME then I could directly fetch it from the HDU list.

Actually,  there is no difference between looking for a specific extname and specific HDUCLAS keywords. You have to loop through the file until you find it.
A FITS file is not a mapping with random access, it's a sequence of HDUs.
I dont think we should prescribe extnames and science Tools should not rely on them.

Ok I see your point, but beside the specific structure of the files and how we read it, wouldn't it be good to provide also mandatory values for EXTNAME to the specs?
The specifications we provide go beyond science tools and if people were to explore the CTA and the H.E.S.S. data they would find different HDU names. Of course they would be able to figure out what an AEFF is, but still, why not to provide uniform HDU names?

@cosimoNigro I don't think it makes sense to prescribe EXTNAMEs, since extnames must be unique but people might want to store multiple effective areas (e.g. point-like and full-enclosure or for different cut values) in the same file.
There is already an issue about making the recommended extnames consistent: #165
However, I don't think there is no reason for science tools to rely on extnames.
If there is only one HDU per IRF component it is identifiable via the HDUCLAS header entries. If not, that's a case that is solvable by creating a hdu index table pointing to the one the science tools should use.

Hi @cosimoNigro and @maxnoe
This is something that was discussed in the past, and I believe the conclusion was we don't want to "impose" it. The issue was that looking at other instruments, each calls their IRFs with different EXTNAME (even if their meaning is identical), so if we added a fixed name to the specifications, then every single high-level IRF would not be GADF compliant.
I don't see any harm with suggesting one name, though. If in the future several effective areas are added to one FITS file, it will be easier for the user to understand their content if their name is descriptive, and will also guide the DL3 "producer". If several HDUs of the same type are added to a single file, they could have "*_N" labels.
I would perhaps add "recommended" EXTNAME values, different for each IRF component type (as I believe we have for the effective areas). But I don't have a strong opinion, as the HDUCLASn keyword family is the method we decided to use to identify HDUs.

@TarekHC exactly

If @cosimoNigro and others think it is ok to add recommendations, definitely close it. If others support Cosimo's suggestion of imposing the EXTNAME, feel free to re-open and farther justify the change.
My feeling is that following up on #165 would be easy, and a "good enough" solution.

Ok, then I am closing it and I will follow-up on #165.


Stripe Webhook Endpoint

So what's the Stripe webhook URL even supposed to be?

So what's the Stripe webhook URL even supposed to be?

What do you mean? the API endpoint?

The Stripe dashboard requires a webhook endpoint to make the requests to when an event is occurred. What should be the URL that we need to enter? (e.g. /api/..)

The Stripe dashboard requires a webhook endpoint to make the requests to when an event is occurred. What should be the URL that we need to enter? (e.g. mydomain.com/api/..)

 I set to /api/webhooks/stripe.

Thanks!


Inquiry about Dockerized Version of Copacetic

What is your question?
Hello Copacetic Team,
I hope this message finds you well. I am currently exploring the use of Copacetic in my projects and was wondering about its compatibility with Docker.
Is there an official Dockerized version of Copacetic available? If not, are there any plans to release it in the near future?
Having an Official Dockerized version would greatly enhance the ease of deployment and integration in various environments, and I believe it would be a valuable addition for users like myself who rely heavily on Docker for containerization.
Thank you for your time and effort in developing Copacetic. I look forward to your response and any updates on this matter.
Best regards,

hi @AshkanRafiee! we have an image that is used for the copa github action. https://github.com/project-copacetic/copacetic/pkgs/container/copa-action
we don't support this outside of GH Action at this time, so we don't have any docs around this.
@toddysm used this with success recently and might be able to share some learnings.


The app crash when i use image_picker package

E/osm     (23337): osm flutter plugin pause
E/osm     (23337): osm flutter plugin pause
E/osm     (23337): osm flutter plugin stopped
D/AndroidRuntime(23337): Shutting down VM
E/AndroidRuntime(23337): FATAL EXCEPTION: main
E/AndroidRuntime(23337): Process: com.jolitaxi.jolitaxichauffeur, PID: 23337
E/AndroidRuntime(23337): java.lang.RuntimeException: Unable to stop activity {com.jolitaxi.jolitaxichauffeur/com.joli.taxi_driver.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void org.osmdroid.api.IMapController.stopAnimation(boolean)' on a null object reference
E/AndroidRuntime(23337): 	at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4858)
E/AndroidRuntime(23337): 	at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4829)
E/AndroidRuntime(23337): 	at android.app.ActivityThread.handleStopActivity(ActivityThread.java:4903)
E/AndroidRuntime(23337): 	at android.app.servertransaction.StopActivityItem.execute(StopActivityItem.java:40)
E/AndroidRuntime(23337): 	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
E/AndroidRuntime(23337): 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
E/AndroidRuntime(23337): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
E/AndroidRuntime(23337): 	at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime(23337): 	at android.os.Looper.loop(Looper.java:223)
E/AndroidRuntime(23337): 	at android.app.ActivityThread.main(ActivityThread.java:7656)
E/AndroidRuntime(23337): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(23337): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
E/AndroidRuntime(23337): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
E/AndroidRuntime(23337): Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void org.osmdroid.api.IMapController.stopAnimation(boolean)' on a null object reference
E/AndroidRuntime(23337): 	at org.osmdroid.views.overlay.mylocation.MyLocationNewOverlay.disableFollowLocation(MyLocationNewOverlay.java:408)
E/AndroidRuntime(23337): 	at hamza.dali.flutter_osm_plugin.overlays.CustomLocationManager.disableFollowAndLocation(CustomLocation.kt:35)
E/AndroidRuntime(23337): 	at hamza.dali.flutter_osm_plugin.overlays.CustomLocationManager.onStopLocation(CustomLocation.kt:40)
E/AndroidRuntime(23337): 	at hamza.dali.flutter_osm_plugin.FlutterOsmView.onStop(FlutterOsmView.kt:2061)
E/AndroidRuntime(23337): 	at androidx.lifecycle.FullLifecycleObserverAdapter.onStateChanged(FullLifecycleObserverAdapter.java:48)
E/AndroidRuntime(23337): 	at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.java:354)
E/AndroidRuntime(23337): 	at androidx.lifecycle.LifecycleRegistry.backwardPass(LifecycleRegistry.java:284)
E/AndroidRuntime(23337): 	at androidx.lifecycle.LifecycleRegistry.sync(LifecycleRegistry.java:302)
E/AndroidRuntime(23337): 	at androidx.lifecycle.LifecycleRegistry.moveToState(LifecycleRegistry.java:148)
E/AndroidRuntime(23337): 	at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent(LifecycleRegistry.java:134)
E/AndroidRuntime(23337): 	at androidx.lifecycle.ReportFragment.dispatch(ReportFragment.java:68)
E/AndroidRuntime(23337): 	at androidx.lifecycle.ReportFragment$LifecycleCallbacks.onActivityPreStopped(ReportFragment.java:210)
E/AndroidRuntime(23337): 	at android.app.Activity.dispatchActivityPreStopped(Activity.java:1433)
E/AndroidRuntime(23337): 	at android.app.Activity.performStop(Activity.java:8194)
E/AndroidRuntime(23337): 	at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4850)
E/AndroidRuntime(23337): 	... 12 more
I/Process (23337): Sending signal. PID: 23337 SIG: 9
Lost connection to device.

you need provide how you're using picker with the map

so i have a home page where i have osm map and a button to go to test widget:
`
import 'dart:io';
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';
class TestWidget extends StatefulWidget {
const TestWidget({Key? key}) : super(key: key);
@override
State createState() => _TestWidgetState();
}
class _TestWidgetState extends State {
File? cameraFile;
File? galleryFile;
final ImagePicker _picker = ImagePicker();
@override
Widget build(BuildContext context) {
return Scaffold(
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
if (cameraFile != null) Expanded(child: Image.file(cameraFile!)),
const SizedBox(height: 10),
if (galleryFile != null) Expanded(child: Image.file(galleryFile!)),
],
),
floatingActionButton: Column(
mainAxisAlignment: MainAxisAlignment.end,
children: [
IconButton(
onPressed: () async {
final XFile? photo = await _picker.pickImage(
source: ImageSource.camera,
maxHeight: 500,
maxWidth: 500,
imageQuality: 85,
);
if (photo != null) cameraFile = File(photo.path);
setState(() {});
},
icon: const Icon(Icons.camera_alt_outlined),
),
const SizedBox(height: 20),
IconButton(
onPressed: () async {
final XFile? photo = await _picker.pickImage(
source: ImageSource.gallery,
maxHeight: 500,
maxWidth: 500,
imageQuality: 85,
);
if (photo != null) galleryFile = File(photo.path);
setState(() {});
},
icon: const Icon(Icons.photo_library_rounded),
),
],
),
);
}
}
`

when i use only test widget as a home page it's work but when the osm map is my home page the app crash

it's crash when you try to open the test page from home page
not when the app open ?

when i press to IconButton for camera or galley select and give me the first logs

can you provide  me the code of that button

it's in the test widget: https://github.com/liodali/osm_flutter/issues/325#issuecomment-1220998834
IconButton(             onPressed: () async {               final XFile? photo = await _picker.pickImage(                 source: ImageSource.camera,                 maxHeight: 500,                 maxWidth: 500,                 imageQuality: 85,               );               if (photo != null) cameraFile = File(photo.path);               setState(() {});             },             icon: const Icon(Icons.camera_alt_outlined),           ),

when i set  trackMyPosition to true and i call myLocation and go to test widget and try to picke un image  the app crash

don't use setState with map
replace cameraFile Type to ValueNotifier<File?> and use ValueListenableBuilder to show the image
if the map has no relation with camera picker
extract that part in seperate widget

the following code : https://github.com/liodali/osm_flutter/issues/325#issuecomment-1220998834 is in seperate widget as i told you and setState it's not the problem because the app crash in this line:
final XFile? photo = await _picker.pickImage( source: ImageSource.camera, maxHeight: 500, maxWidth: 500, imageQuality: 85, );

i create a repo (the same code in your example folder): https://github.com/h1amza/test_osm_flutter
and i add the test widget (with ValueNotifier) just run the code and click on mylocation button first then to gallery botton

ok i will check thanks

for now if you want try to make built in camera in your app
i need to make more investigation why the restard when app go to background and back again

is there a function to stop or pause the map?

thats done automatically inside the plugin
and in flutter we dont have the same lifecycle in android
try to use camera package instead of the picker

i need access to gallery to that's why i use image_picker

use this package https://pub.dev/packages/photo_gallery
to make built in gallery also
sorry for that i dont know why it behave like that
i tested that use case(make app go to background and back to forground  ane it didnt behave like open another app i will checked why

ok i will see

there is any update about this issue?

technicaly I found a solution but I have wierd behaviour I need to fixed and make some test to publish the solution

ok thanks for letting me know

hello there ,
I'm coming to open an issue here , but I found it already opened
the crash actually happens directly after the app goes for the background like when you tap on system home button or you launch another app from the flutter app

it wierd i testedthat case
the problem here that when you open other applicaton from current like @h1amza  did open camera app
force the map to rebuild
can you provide me more information about what you did and log error also if it possible

i have small solution that you can disable location when you open new page or that page that will open camera app
and when you return the map page re-activate again the track location

I will publish new version contain fix for this issue today

but take care that when openning a new page or remove the page that contain map with tracking activate should be disabled
because no need to keep the location activate
for now I added disable the user location when map disposed or go to background

check the new version 0.40.1


Use username and password for Authentication

Hi
I use the following example to connect to NATS server with ESP8266, but by adding a username and password, I can not connect to the server.
https://github.com/isobit/arduino-nats/blob/master/examples/blink/blink.ino
WiFiClient client;
NATS nats(
&client,
"iot-backend.isaan.ir", NATS_DEFAULT_PORT,
"emicro",
"xxxxxxxx"
);
I've added my username and password as above.
[2185] 2019/01/30 02:42:08.366138 [TRC] <IP_ADDRESS>:60204 - cid:254 - <<- [-ERR authorization timeout]
[2185] 2019/01/30 02:42:08.366242 [DBG] <IP_ADDRESS>:60204 - cid:254 - Authorization Timeout
[2185] 2019/01/30 02:42:08.366253 [DBG] <IP_ADDRESS>:60204 - cid:254 - Client connection closed

Hi
I have the same problem, it does not connect with authorization.
/************* connection successful /
EthernetClient client;
NATS nats(&client,"<IP_ADDRESS>",43210);
/************************************/

/************* connection failed /
EthernetClient client;
NATS nats(&client,"<IP_ADDRESS>",43210,"123","11111111");
/*********************************/
43210 - port
123 - login
11111111 - pass
11:06:31.100711 [ERR] <IP_ADDRESS>:59940 - cid:8 - Authorization Error


Evaluation Code

Thank you for your excellent work.
May I please request the evaluation code?
I'm interested in the specific evaluation processes for Dreambooth, Textual Inversion, Custom Diffusion, and VICO.
Thank you.

Hi, do you mean the quantitative evaluation? I will update this part soon. Thank you!


Socket disconnected toast fires on load sometimes

not sure why but seems worse in production  build

This seems to have gone away


HDDS-11357. Datanode Usageinfo Support Display Pipelines Count.

What changes were proposed in this pull request?
We can use ozone admin datanode usageinfo to display the usage information of a datanode. However, this information does not include Pipeline details, which are also crucial for the datanode. It would be useful to include Pipeline information in this display.
The information is displayed as follows:
UUID : dd1e5cf2-dtf5-6b35-ade5-ac8589d9eaf5
IP Address : <IP_ADDRESS>
Hostname : localhost-<IP_ADDRESS>
Capacity : 100 B (100 B)
Total Used : 20 B (20 B)
Total Used % : 20.00%
Ozone Used : 10 B (10 B)
Ozone Used % : 10.00%
Remaining : 80 B (80 B)
Remaining % : 80.00%
Pipeline(s) : 10
Container(s) : 5
Container Pre-allocated : 0 B (0 B)
Remaining Allocatable : 80 B (80 B)
Free Space To Spare : 0 B (0 B)

What is the link to the Apache JIRA
JIRA: HDDS-11357. Datanode Usageinfo Support Display Pipeline.
How was this patch tested?
Junit Test & Execute the command manually.

@fapifta Can you help review this PR? Thank you very much! The purpose of this PR is to output a pipeline count for a specific DN.


no matching function for call to 'CFastLED::addLeds<WS2812, 3, 4, BGR>(CRGB [144], int)'

Hello good day.
I am working on a TWANG, with my son, but compiling the arduino software gives me this error.
no matching function for call to 'CFastLED::addLeds<WS2812, 3, 4, BGR>(CRGB [144], int)'
It happens since I change these lines:
// Fast LED
FastLED.addLeds<APA102, DATA_PIN, CLOCK_PIN, LED_COLOR_ORDER>(leds, NUM_LEDS);
FastLED.setBrightness(BRIGHTNESS);
FastLED.setDither(1);
For this other line.
// Fast LED
FastLED.addLeds<WS2812, DATA_PIN, CLOCK_PIN, LED_COLOR_ORDER>(leds, NUM_LEDS);
FastLED.setBrightness(BRIGHTNESS);
FastLED.setDither(1);
Could you help me understand the problem?

Try removing CLOCK_PIN from the line with WS2812 as Neopixels don't have a clock pin.


Use babel and eslint instead of jsx and jsxhint, remove react-tools, clean tests

It is now recommended to use babel as a JSX compiler instead of jsx; react-tools will soon (React 0.14) be deprecated.
jsxhint is now deprecated in favor of eslint.
Tests run with plain mocha.
Two of the tests were faulty:

renders the title in specified format was missing a T between the date and the time, and so failed.
allows passing milliseconds from epoch was testing against a UTC date string, but moment (and hence Time) uses a local time date string.

By the way, this PR makes Time compatible with React 0.14.0-beta1.

I did this myself.


how many samples are needed for stable variant calling?

Dear ekg,
does one need to re-process all existing bam files every time new batch of sample data come to obtain the most reliable results? If not, what is the minimal recommended sample size?
Thanks a lot!

One sample is the minimum recommended size. Multiple will help with
sensitivity.
You can convert each sample into gVCF and merge post-hoc using another
tool. This preserves most of the information used by variant calling. This
is new territory, and I will be happy to support you by resolving any bugs
you find as this is a common use case.
On Sun, Jul 16, 2017, 09:20 calvin<EMAIL_ADDRESS>wrote:

Dear ekg,
does one need to re-process all existing bam files every time new batch of
sample data come to obtain the most reliable results? If not, what is the
minimal recommended sample size?
Thanks a lot!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/407, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI4EXNTfqlgRO1-DVwLTh4wwZ2vDuL1ks5sObnLgaJpZM4OZOP4
.

I see. Thanks for the quick reply!
Without involving gVCF, I think the calling results of one sample is not so reliable as I experienced. For some sites, if I recall it correctly, calling on one bam together with that of the mother or with that of both parents resulted in the same and more reasonable genotypes. So I guess 2 or more samples are needed for stable and reasonable genotyping at some sites. But I am not sure how much benefit would be brought with more samples. Is it practically enough to process, say, 10 or 20 bams together?


nixos/testing: add interactive serial stdout logs switch and dim them

Motivation for this change

Interactively running nixos vm tests
Brain overwhelmed by serial logs pouring in
Can't spot "driver" logs, even though they are prefixed with machine1: (as opposed to machine1 # serial logs)

Start of alleviation in the context of: https://discourse.nixos.org/t/nixos-vm-test-driver-filter-logs/13081
Things done

[x] manually tested on a downstream project with NIX_PATH="nixpkgs=/home/blaggacao/ghq/github.com/NixOS/nixpkgs" nix-build on this checkout
[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-vm-test-driver-filter-logs/13081/2

That looks already pretty fair.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/381

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/brainstorming-improve-nixos-test-vm-logging/13400/1


Update build tools

Sorry if any of the changes are out of scope.
CHANGELOG

Use rollup instead of webpack #225.
Remove unnecessary file eslintignore.
Move babel and eslint configurations to package.json.
Change scripts that use environment variables because windows doesn't work well with them.
Update deep-diff.
Remove open-url because http-server already has an option to open the browser after starting the server.
Remove babel-cli and others unused plugins and presets.
Expose files using ES2015 modules through the properties pkg.module and pkg.jsnext:main.

Codecov Report

Merging #227 into master will decrease coverage by 4.68%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   68.38%   63.69%   -4.69%
==========================================
  Files           5        6       +1
  Lines         136      146      +10
==========================================
  Hits           93       93
- Misses         43       53      +10

Impacted Files
Coverage Δ

rollup.config.js
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385f41c...fd20d30. Read the comment docs.

Abu thoughts @evgenyrodionov?

Looks good, but I need test it. On Monday, I guess.

I hope you don't mind @evgenyrodionov. I am taking advantage of this pull request to add some tests.

Thank you! It looks pretty awesome.

Thanks @evgenyrodionov!!!

Expose files using ES2015 modules through the properties pkg.module and pkg.jsnext:main.

As I mentioned above if you use a module bundler like webpack or rollup, it will get the code from the source files. That can cause problems like #229 when you don't use the babel plugin to handle the object spread operator. So I think that we can either explain that on readme and ask for people use the plugin or just expose the bundled file as was made before and prevent these problems. What do you think @evgenyrodionov?

Object spread operator already fixed in 3.0.3, it's stage 3 proposal (candidate), so it was my mistake.


fix config scope and tmp dir creation

See https://github.com/12rambau/pytest-copie/pull/89#issuecomment-2258593881

how will it continue to work at function scope if the config file fixture is session scoped ?

Setting the config scope to session means it's only generated once per session, i.e., the result is reused for all subsequent calls. This seems to work fine for pytest-cookies: https://github.com/hackebrot/pytest-cookies/blob/28492af5bba1da3a2bed19389f96584e51c1e08f/src/pytest_cookies/plugin.py#L119

@12rambau, are there any other questions you have about this, or is there anything else I can do?

I just need to find time to perform my OSS duties, I like this repository and use it a lot I'll let you know if anything is not working.


[Feature] Add: "auto-label" GitHub Workflow for Automated Labeling

Objective: Implement an "auto-label" GitHub workflow to automatically assign the "gssoc-ext" and "hacktoberfest-accepted" labels to relevant pull requests and issues.
Details:

This workflow will streamline the labeling process by automatically applying the "gssoc-ext" and the "hacktoberfest-accepted" label to Issues.
By automating these labels, we can ensure consistent tracking and visibility of contributions tied to these significant events.

Implementing this "auto-label" workflow will enhance project organization
hey @Yashgabani845  Please Assign it to me with label "gssoc-ext" , "hacktoberfest-accepted" and "level2"

@samyak-aditya work on it and give label of hactoberfest,hactoberfest-accepted, gssoc-ext as default

hey @Yashgabani845 I would highly appreciate if you label it level2

Hey @Yashgabani845 I have created the PR


GPII-4496: Updated dependencies and fixed options-munging issues.

See GPII-4496 for details.

Per discussion with @amb26, self-merging this small update.

Release cut and forward-facing version updated.


Test failure masks following failures

One failing test can make following tests appear to pass.  An example of this can be found here:
https://github.com/c1728p9/mbed-os/commit/3c38cc6b6290225bb0bf74588038f76ef9c1eae8
@PrzemekWirkus, @bridadan

@adbridge Anna, please have a look when you are back from training.

ARM Internal Ref: IOTSFW-2711

@c1728p9 Please provide more detailed summary of problem. In your example I just see 2 asserts in succession (which can't every pass anyway as discussed elsewhere) so what do you mean by 2 tests? Do you mean that the first assert in your example fails but the second then passes ? Please provide a link to the full test being run, which compiler and target was used and what platform you ran on as a bare minimum.

Aside from the above comment , having looked at the full source file for your supplied example you have a custom failure handler which is run at the end of each of your test cases if they fail. This handler has the following code
utest::v1::status_t greentea_failure_handler(const Case *const source, const failure_t reason) {
    greentea_case_failure_abort_handler(source, reason);
    return STATUS_CONTINUE;
}

By returning STATUS_CONTINUE you are instructing the test framework to run the next test case even if the previous one failed.

Try running the c string test on a K64F and you should see the problem.  Only one test fails and all subsequent tests within the file pass.

Are the subsequent tests supposed to fail ?

Yeah, I added the "TEST_ASSERT(0);" which should always fail, but in this case it passes.

Ah ok now I understand the problem, will investigate.

Sorry for any confusion.  Thanks for looking into it :smiley: