Themes

Thank you for a great engine! :grin: :beers:  As I dig deeper into the code, I am really impressed with the quality, and believe this has all the potential to do for Rails what phpbb did for PHP: i.e. an awesome, extensible, de-facto standard forum. I've dumped some thoughts below.

Themes
Themes should not override view files, instead they should be pure CSS and some configuration. The major advantage is zero-maintenance updates and ease of theming. Here is why this is possible:

Modern CSS allows complete control over layout. Even without flexbox, table-header/footer group and float tricks allow swapping top/bottom and left/right elements (like in my bootstrap theme).

simple_form allows complete control over form rendering with just configuration. #32

Hooks can be used for extension, paving a way for plugins.

One way to do this

[ ] Split the views need into many little partials, with classes on everything. Provide hooks for extension - I've done this in my rails_email_preview gem and it seems to work very well.
[ ] Move HTML generation out of helpers and into partials. E.g. move the timestamp helper to app/views/thredded/shared/_timestamp.html.slim.
[ ] Provide JavaScript, as it is an inseparable part of a modern webapp. #5
[ ] I18n everything. I wrote the i18n-tasks gem to make maintaining locale files super-easy.
[ ] Have 2 completely different themes to validate the "ease of theming" bit.

It would be awesome to get this out of the stealth mode sooner rather than later, as there are lots of potential contributors out there: forem is lacking in scope, and Discourse fills a different niche as it's not an engine but a full app, while Thredded hits the sweet :candy: spot :dart:. I can help spread the word  :loudspeaker:.
:sunrise_over_mountains: :sunrise: :sunny:

@glebm @kirantpatil starting on this in earnest. Step 1 is mostly working to get things split out into appropriate partials and adding a generator to copy all the partials to a parent app if it's so desired.


Reinstate iris_grib.

An attempt to get iris_grib back into Iris, and to remove iris.fileformats.grib altogether.
Outstanding : various tests still need porting, ditching or re-purposing.
See #2860 for that.

Just as a heads-up, there is a large degree of overlap with this and #2617.

@pelson  there is a large degree of overlap with this and #2617.

Dead right.
I thought it was worth a restart from scratch here, but unsurprisingly they are pretty similiar.

DO NOT MERGE (!)
I have now rebased this + will attempt to revive.
It needs to run with the changes proposed in https://github.com/SciTools/iris-grib/pull/87
I have also got a rebased version of #2617
Next-up, I will patch in any desirable changes from there to achieve a "best of both"

It appears that the spurious end-of-line-whitespace error is the only thing holding this back ...

Reviewed at fd36e9d98278f5d79b00d39e6905c4a79b725c7d. If you could add commits on top of that (rather than amending it), I'd appreciate it.


[GUI-162] Replace compose file with single image.

Description
The start up via docker-compose should be replaced into one docker image.
Related documentation should be updated.
Related JIRA's task: https://mongoose-issues.atlassian.net/browse/GUI-162

The image encapsulates both NodeJS server (with related front-end files) and Prometheus. It's being built in 3 stages using Docker multi-stage building feature.
Once I'll test it out, I'll release it into the Docker hub.

Found bugs related to Mongoose configuration and nodes list. Fixing it now.

Both Prometheus reloading & configuration changing are working now.
Fixing issues related to chart-drawing in deployment right now.

The chart are now displaying correctly. There's still some issues related to migration from docker-compose into a single docker-image. Will be fixed ASAP.

Major part of the issues are fixed, the image is now (at least) usable.
Still testing thought.


implement outcome to Capacitor Client

This PR will implement the missing outcome feature from sentry client
#skip-changelog
Sub-Task of #573

I am closing this PR since we'll not implement the Capacitor Client


Fixes to get it compiled using GCC9.x for RPI platform

There are some Cobalt patches in buildroot main for gcc8 & gcc9.
Is this change compatible with those patches?
I have not noticed the patches in the buildroot. I cross checked and my changes are almost aligned with gcc8 changes (but need some updates). Why we are keeping these changes as patches ? I think we can add at least the gcc options changes, since in the latest gcc all the warning goes to errors.

Closing this PR, since the patches already available in build repos


dark_theme_css: Fix border color for tables in message/chat.

Add a css rule in dark_theme.css for tables inside message/chat. This rule sets a brighter color for these type of tables so that it's more visible when the user is using dark theme.
Fixes zulip#29856
CZO

Screenshots and screen captures:

Before
After

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

That looks better to me! @terpimost do you have any feedback on this one?

@PieterCK To fully prepare the PR for review, you'll need to go through the self-review checklist.

Ah, thank you for pointing it out. I'll not forget to do that next time

I would decrease transparency of the white borders a bit (try 0.5)

Hello @terpimost, thanks for reviewing this PR. Here's what the table looks like on different scale of opacity including 0.5.
tables on different opacity scale:

0.4 Opacity
0.5 Opacity
1 Opacity

for completeness, I've also included several variation of the table in different format and with other element.

if matched with spoilers' css:

spoiler blocks' css= border-color: hsla(0, 0%, 50%)

table with border-color: hsla(0, 0%, 50%)

if rounded:

somehow border-radius effect is not symmetrical

with more data:

border-color: hsla(0, 0%, 50%)
0.5 Opacity

Update: included the new table border color css for the tables in preview message

0.4 is better, but I think we can even do 0.2

These colors and other values should be expressed as CSS variables; let's not go the route of adding more lines to dark_theme.css.
To do this, you'll likely need to make variables out of the comparable light-mode values, and express them and their dark-mode counterparts in app_variables.css.

These colors and other values should be expressed as CSS variables; let's not go the route of adding more lines to dark_theme.css.
To do this, you'll likely need to make variables out of the comparable light-mode values, and express them and their dark-mode counterparts in app_variables.css. (Those initial light-mode values being converted to variables will make for an excellent first commit.)

Oh I see, using only one variable name in the same file makes it easier to manage. I'll make a new commit for the light mode and the new table border variable in app_variables.css.

0.4 is better, but I think we can even do 0.2

Here's some screenshots with the 0.2 opacity!

on different opacity scale:

0.2 Opacity
0.4 Opacity
0.5 Opacity

inside preview:

inside spoiler:

@karlstolley If that's the case for the table border color, shouldn't the other parts of the table also be refactored in the same way? The obvious one would be the table header background color, what do you think?

Here's some screenshots with the 0.2 opacity!

This is super helpful! It's best to update screenshots directly in the PR description, so that it's easy for reviewers to see what's currently implemented in the PR.

You can just post a comment to note that the description has been updated.

You can just post a comment to note that the description has been updated.

Ahh, gotcha. I agree, this seems cleaner. Will do! :smiley:

@karlstolley If that's the case for the table border color, shouldn't the other parts of the table also be refactored in the same way? The obvious one I noticed is the table header background color. I can include it in this PR or open up a followup issue for a more thorough reporting if such an issue isn't already up, what do you think?

@PieterCK sure. Those kinds of fixes would be welcome as you're working in this area, yes. And this PR is still of a manageable size that I think you could do them without introducing a lot of churn here. I'd probably introduce them as prep commits to this PR before the border changes here, since presumably you would only be making variables out of the existing colors, not changing the colors. And make sure you update the PR description with both light- and dark-mode screenshots.

Update: Added new prep commit to refactor thead background color and raised a potential issue/ bug. All details are in the updated PR desc.

The screenshots all look reasonable to me, thanks! Marking for maintainer review, since the next step is for @karlstolley to a look at the latest set of changes.

A few code-organization nits. I'm not certain we won't see some regressions from striking those table-oriented element selectors in dark mode, but the fixes for those would be to use more specific selectors anyway. And because it's a border color, any regressions that might be discovered won't affect functionality.

A few code-organization nits. I'm not certain we won't see some regressions from striking those table-oriented element selectors in dark mode, but the fixes for those would be to use more specific selectors anyway. And because it's a border color, any regressions that might be discovered won't affect functionality.

Update: Reorganized the new css variables in app_variable.css.
Noted, I'll keep and eye out for regression related to this change.

Okay. I gave this another read-through and it looks good. Likewise in one final round of manual testing. Marking for integration review. Thanks, @PieterCK!

Thanks for reviewing!

Update: Resolved conflict at dark_theme.css.
Conflict:

The same CSS from changes in this PR still affects the table border and behaves correctly:

One comment, otherwise lgtm. It seems possible that removing that base table CSS reset might cause some unexpected regressions, but if you've audited to your satisfaction, removing it is certainly desired, as they tend to make the overall CSS more fragile and hard to reason about.

Hi Tim, sorry for the late reply. I've addressed your comment

Merged, thanks @PieterCK!


Filter iis startup log entries

Startup log entries causes parsing error failures.

Updated line_start_pattern to handle startup log entries
Added filter to drop startup log entries

PR is duplicated by another pr. Closing this PR as we will use  (PR110)


History bug with beforeEnter guards on Chrome 87

Version
4.0.1
Reproduction link
https://codesandbox.io/s/modest-nightingale-j7uzx
Steps to reproduce
https://github.com/AlexandreBonaventure/vue-router-history-bug
So I realized this bug only happens on my Chrome browser after putting up the repro.
The codesandbox link won't highlight the bug because of the sandbox environment.
So you need to clone the repo and run yarn && yarn dev to boot dev server.
You'll land on:

localhost:3000/organizations
Click on 'Go to Details'
URL should now be localhost:3000/organizations/0/settings
Click 'Back'

What is expected?
URL should be localhost:3000/organizations because we went back in the history.
What is actually happening?
On Chrome 87, 5. URL is stuck with localhost:3000/organizations/0/settings

Screen recording https://we.tl/t-o0WVJVIlet

The problem is your navigation guard also gets executed when going back in history, but the param isn't present, so it aborts going back and creates a new navigation, staying where you are. You need to ensure the param only on the routes that need it (there was also a typo on the param):
router.beforeEach((to, from) => {
  if (to.name === 'organization-settings' && !to.params.id) {
    const { name, path, query, params, fullPath } = to
    // console.log(to, from);
    console.log('Full Path', fullPath)
    return { name, query, params: { ...params, id: '1' } }
  }
})

That being said, since the param is required, such a guard doesn't make sense, I'm not sure what you are trying to achieve here...
The good thing is this helped me find a different bug that validates the navigation when going back even though it shouldn't, making from have an invalid value the second time you hit back. Thank you for that!


Book 1, Section <IP_ADDRESS> Probability of a conjunction of two events - inaccuracy

In the section we have the following example of independent events,

For example, suppose X and Y are chosen uniformly at random from the set $\mathcal{X} = {1, 2, 3, 4}$. Let
A be the event that $X \in {1,2}$ and B be the event that $Y \in {3}$. Then we have $Pr(A, B) = Pr(A) Pr(B) =\frac{1}{2} \cdot \frac{1}{4}$

This  is incorrect,  $Pr(A, B) = 0$ as A and B are mutually exclusive. Section <IP_ADDRESS> correctly asserts the disjoint nature of event A and B.

No, they are not mutually exclusive.
A is the event that $X\in {1, 2}$ and
B is the event that $Y\in {3}$
See, there are two random variables, $X$ and $Y$. Getting $X = 1$ doesn't imply that $Y = 1$. In this sense, they are both independent.
They would be mutually exclusive if
A is the event that $X\in {1, 2}$ and
B is the event that $X\in {3}$
Now $X = 1$ would imply $X = 1$. Hence, $X \ne 3$. Hence, they are mutually exclusive. This part is explained later in the section <IP_ADDRESS>.
@TronicLT


Proxy support for API installs

(This is related to Linux installs using the API - my systems require going through a proxy to get to the Internet.)
Code supports setting proxy configuration for the sensor to function with, but the actual API installation method does not use those same proxy settings during the installation.  I reviewed lib/puppet/puppet_x/falconapi.rb but ran into limitations with my Ruby programming knowledge in how to attach proxy configs to the Net::HTTP calls, so unfortunately could not attach a patch to assist.

Good find, let me think about this for a moment and confer with my team.

@maoneal It looks like Ruby Net::HTTP will respect the HTTP_PROXY environment variable route traffic through that value.
I'll continue to work on seeing how this will fit into the module, but in the meantime I wanted to throw that option out to you.

I saw that in the documentation as well - we have environmental variables set, but they aren't being used by the Puppet process, so unclear why that is.

Hey @maoneal #89 adds two new params to the module
sensor_dl_proxy_host
sensor_dl_proxy_port
The http_client in lib/puppet/puppet_x/falconapi.rb will use the host and port provided by these two new parameters.
The latest puppet module release v0.10.0 contains these changes.


No metrics in grafana with CNI enabled in istio 1.1.0-snapshot.5

I have installed istio as per the prelim install instructions with the following settings during the actual installtion of istio (not istio-init): --set grafana.enabled=true --set tracing.enabled=true --set kiali.enabled=true --set servicegraph.enabled=true --set istio_cni.enabled=true
In two namespaces, I installed various services like elasticsearch, consul, mysql etc., usually via their respective helm-charts. One of those namespaces (the default namespace) has sidecar auto-injection enabled. The service-configuration and istio-configuration allows for traffic between the services. I can verify that traffic exists and is handled correctly through sidecars.
In Grafana, only Mixer, Performance and Pilot Dashboard show any data - but nothing from any actual service is tracked. Not just specifically configured service metrics, but general traffic handled by istio doesn't seem to make it into metrics&monitoring. Explicitly, Mesh and Service Dashboards are entirely empty. How can I debug or fix this issue - are alternative configurations needed somewhere?

Have you tried troubleshooting with https://preliminary.istio.io/help/ops/telemetry/missing-metrics/?

Thank you for pointing me at that help page. Here are my results:
Verify Mixer is receiving Report calls
This fails - when I forward port 9093 for the telemetry container, I get a 404 response in the browser, so I was unable to complete any "search for" instructions. Or is there some other way I ought to access the endpoint. Here are my exact steps:
kubectl get pods -n istio-system

NAME                                      READY   STATUS      RESTARTS   AGE
grafana-f8467cc6-6bfpf                    1/1     Running     0          5d
istio-citadel-676c58584b-wcqgk            1/1     Running     0          5d
istio-cni-node-dwqnd                      1/1     Running     0          5d
istio-cni-node-vtwpf                      1/1     Running     0          5d
istio-cni-node-wllhj                      1/1     Running     0          5d
istio-egressgateway-54477c6569-vzkhf      1/1     Running     0          5d
istio-galley-58b7c6b6bb-rz7px             1/1     Running     0          5d
istio-ingressgateway-f6c4b779b-scfcn      1/1     Running     0          5d
istio-init-crd-10-mgbs6                   0/1     Completed   0          5d
istio-init-crd-11-67l7d                   0/1     Completed   0          5d
istio-init-crd-certmanager-10-x9k8z       0/1     Completed   0          5d
istio-pilot-7d586bdf7d-rcbwh              2/2     Running     0          5d
istio-policy-755cf49c4f-6rgxf             2/2     Running     3          5d
istio-sidecar-injector-6d7586f8cd-n5tqz   1/1     Running     0          5d
istio-telemetry-7c7ff645cf-xngx4          2/2     Running     3          5d
istio-tracing-6849759bc8-xhwt9            1/1     Running     0          5d
kiali-7766b75767-4twxk                    1/1     Running     0          5d
prometheus-849b9cddff-5gn7n               1/1     Running     0          5d
servicegraph-655755f6c9-dttq8             1/1     Running     0          5d

/some/directory/
❯ kubectl -n istio-system port-forward istio-telemetry-7c7ff645cf-xngx4 9093
Forwarding from <IP_ADDRESS>:9093 -> 9093
Forwarding from [::1]:9093 -> 9093
Handling connection for 9093

In a parallel window, after forwarding the port, I executed curl http://localhost:9093 and got 404 page not found (and the "Handling connection"-line in the other window)
Verify the Mixer rules exist
I can verify that the required rules exist:
kubectl get rules --all-namespaces
NAMESPACE      NAME                      CREATED AT
istio-system   kubeattrgenrulerule       5d
istio-system   promhttp                  5d
istio-system   promtcp                   5d
istio-system   promtcpconnectionclosed   5d
istio-system   promtcpconnectionopen     5d
istio-system   stdio                     5d
istio-system   stdiotcp                  5d
istio-system   tcpkubeattrgenrulerule    5d

Verify the Prometheus handler configuration exists
This configuration did not exist. Is there no default handler configuration during istio install with helm, oder is an alternative one needed? I looked at the helm template and found that various resources from that template were in fact created. What's more, various .Values-flags regarding telemetry are per default set to true, so shouldn't hinder creation of the required resources. I'm probably missing something basic here, but could you help me out with how to supply the missing configuration given that helm template?
Verify Mixer metrics instances configuration exists
The required configurations exist:
kubectl get metrics.config.istio.io --all-namespaces
NAMESPACE      NAME                   CREATED AT
istio-system   requestcount           5d
istio-system   requestduration        5d
istio-system   requestsize            5d
istio-system   responsesize           5d
istio-system   tcpbytereceived        5d
istio-system   tcpbytesent            5d
istio-system   tcpconnectionsclosed   5d
istio-system   tcpconnectionsopened   5d

Verify Mixer is sending metric instances to the Prometheus adapter
Impossible/unclear due to 404 mentioned above.
Verify Prometheus configuration
Istio-mesh shows as up. However, I noticed "kubernetes-apiservers" seemed to be down - could this be due to the nonstandard kube-api addresses in Azure AKS? In any case - other components use the kube-api successfully, so I suspect the problem doesn't originally lie there.
kubernetes-apiservers (0/1 up)
Endpoint 	State 	Labels 	Last Scrape 	Error
https://<IP_ADDRESS>:443/metrics
	down 	instance="<IP_ADDRESS>:443" 	11.747s ago 	context deadline exceeded

Additionally, the jaeger pod shows as down:
kubernetes-pods (2/3 up)
Endpoint 	State 	Labels 	Last Scrape 	Error
http://<IP_ADDRESS>:10055/metrics
	up 	instance="<IP_ADDRESS>:10055" k8s_app="kube-dns" kubernetes_io_cluster_service="true" namespace="kube-system" pod_name="kube-dns-v20-55b6db5d44-dxts2" pod_template_hash="1162861800" version="v20" 	10.404s ago
http://<IP_ADDRESS>:16686/metrics
	down 	app="jaeger" chart="tracing" heritage="Tiller" instance="<IP_ADDRESS>:16686" namespace="istio-system" pod_name="istio-tracing-6849759bc8-xhwt9" pod_template_hash="2405315674" release="istio" 	13.222s ago 	no token found
http://<IP_ADDRESS>:10055/metrics
	up 	instance="<IP_ADDRESS>:10055" k8s_app="kube-dns" kubernetes_io_cluster_service="true" namespace="kube-system" pod_name="kube-dns-v20-55b6db5d44-hngt9" pod_template_hash="1162861800" version="v20" 	4.872s ago

Looking into the prometheus-container log, I find this warning is consistently issued: level=warn ts=2019-02-11T20:15:16.139090873Z caller=scrape.go:713 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:16686/metrics msg="append failed" err="no token found". Always with the same url - could this be relevant? Should this happen with a helm install given the values specified?
Additionally, I grepd the logs of the mixer container in the telemetry pod for errors and found these kinds of entries from a couple of days ago, directly after the istio-installation, but not appearing since (potentially unrelated, but in case it might provide valuable info, I thought I'd include it:)
First, there were four errors of the following kind within a few milliseconds:
Unable to decode an event from the watch stream: http2: server sent GOAWAY and closed the connection; LastStreamID=1689, ErrCode=NO_ERROR, debug=""
Then, over the next minutes, there were a couple of these errors:
istio.io/istio/mixer/adapter/kubernetesenv/cache.go:101: Failed to list *v1.Pod: Get https://[Azure Kube-API Address]:443/api/v1/pods?limit=500&resourceVersion=0: net/http: TLS handshake timeout
A current --tail 10 gives:
scvg2997: inuse: 14, idle: 3, sys: 17, released: 1, consumed: 16 (MB)
GC forced
gc 3754 @449803.856s 0%: 0.010+3.2+3.9 ms clock, 0.042+0/3.1/9.2+15 ms cpu, 12->12->7 MB, 15 MB goal, 4 P
scvg2998: 0 MB released
scvg2998: inuse: 15, idle: 2, sys: 17, released: 1, consumed: 16 (MB)
GC forced
gc 3755 @449923.891s 0%: 0.46+5.3+4.3 ms clock, 1.8+0.38/5.3/13+17 ms cpu, 12->12->7 MB, 15 MB goal, 4 P
GC forced
gc 3756 @450043.956s 0%: 0.050+7.1+4.9 ms clock, 0.20+0/6.4/6.0+19 ms cpu, 12->12->7 MB, 15 MB goal, 4 P
scvg2999: inuse: 12, idle: 5, sys: 17, released: 1, consumed: 16 (MB)

Furthermore, this is the entire log for the istio-tracing container:
{"level":"info","ts":1549465823.0935159,"caller":"healthcheck/handler.go:99","msg":"Health Check server started","http-port":14269,"status":"unavailable"}
{"level":"info","ts":1549465823.093701,"caller":"memory/factory.go:55","msg":"Memory storage configuration","configuration":{"MaxTraces":50000}}
{"level":"info","ts":1549465823.0956464,"caller":"tchannel/builder.go:97","msg":"Enabling service discovery","service":"jaeger-collector"}
{"level":"info","ts":1549465823.0957007,"caller":"peerlistmgr/peer_list_mgr.go:111","msg":"Registering active peer","peer":"<IP_ADDRESS>:14267"}
{"level":"info","ts":1549465823.0964649,"caller":"all-in-one/main.go:209","msg":"Starting agent"}
{"level":"info","ts":1549465823.096726,"caller":"app/agent.go:68","msg":"Starting jaeger-agent HTTP server","http-port":5778}
{"level":"info","ts":1549465823.0974338,"caller":"all-in-one/main.go:271","msg":"Starting jaeger-collector TChannel server","port":14267}
{"level":"info","ts":1549465823.0975099,"caller":"grpcserver/grpc_server.go:64","msg":"Starting jaeger-collector gRPC server","grpc-port":"14250"}
{"level":"info","ts":1549465823.0975766,"caller":"all-in-one/main.go:289","msg":"Starting jaeger-collector HTTP server","http-port":14268}
{"level":"info","ts":1549465823.0975957,"caller":"all-in-one/main.go:417","msg":"Archive storage not created","reason":"Archive storage not supported"}
{"level":"info","ts":1549465823.1312747,"caller":"all-in-one/main.go:327","msg":"Listening for Zipkin HTTP traffic","zipkin.http-port":9411}
{"level":"info","ts":1549465823.2891572,"caller":"all-in-one/main.go:378","msg":"Registering metrics handler with jaeger-query HTTP server","route":"/metrics"}
{"level":"info","ts":1549465823.2892213,"caller":"all-in-one/main.go:384","msg":"Starting jaeger-query HTTP server","port":16686}
{"level":"info","ts":1549465823.2892416,"caller":"healthcheck/handler.go:133","msg":"Health Check state change","status":"ready"}
{"level":"info","ts":1549465824.095914,"caller":"peerlistmgr/peer_list_mgr.go:157","msg":"Not enough connected peers","connected":0,"required":1}
{"level":"info","ts":1549465824.096002,"caller":"peerlistmgr/peer_list_mgr.go:166","msg":"Trying to connect to peer","host:port":"<IP_ADDRESS>:14267"}
{"level":"info","ts":1549465824.0963626,"caller":"peerlistmgr/peer_list_mgr.go:176","msg":"Connected to peer","host:port":"[::]:14267"}

So, in a GKE cluster, I was able to enable NetworkPolicy, install istio with cni, generate traffic and see the traffic in prometheus. I forgot to install grafana, but being able to see these metrics via prometheus means that everything should work.
The jaeger metrics path was incorrect and since corrected in a PR for 1.1.
@MBauer83 the port in the (now updated) docs is 15014. It was moved from 9093 for reasons without the docs being updated originally.

Update: I'm actually only seeing traffic from source_workload_namespace=istio-system.

@MBauer83 you said that you can confirm that traffic is flowing through your proxies. May I ask how?
I just tried a fresh install of 1.1 on a GKE cluster with Network Policy (1.12.5-gke.5) enabled and istio_cni enabled. I can see traffic flowing to each of the sample pods, but it does NOT go through the proxies.
Install:
helm template $HOME/istio-fetch/istio --name istio --namespace istio-system --set istio_cni.enabled=true --set global.proxy.accessLogFile="/dev/stdout" --set istio-cni.cniBinDir=/home/kubernetes/bin --set tracing.enabled=true --set tracing.gateway.enabled=true | kubectl apply -f -

Counters from the productpage envoy proxy after sending several requests:
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::cx_active::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::cx_connect_fail::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::cx_total::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::rq_active::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::rq_error::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::rq_success::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::rq_timeout::0
inbound|9080|http|productpage.default.svc.cluster.local::<IP_ADDRESS>:9080::rq_total::0

@douglas-reid  -- with your new install of 1.1 on GKE do you see the istio-cni-node daemonset present?  In newer release-1.1 versions the istio and istio/cni helm charts are separate and the install of the CNI is a separate step helm template/install operation.

@douglas-reid : I was misreading the diagnostics - and probably assuming that successful traffic would have to go through the proxy-container if it works at all, because I've had connection problems when the proxy wasn't working before - but the cx_ and rq_ values are all zero.
I attempted to upgrade to 1.1.0-rc2, but even after manually applying the crd-files, the helm upgrade command (with the correct namespace, of course) surprisingly gives Error: UPGRADE FAILED: no ServiceAccount with the name "istio-multi" found  while kubectl get sa/istio-multi -n istio-system confirms its existence.
Best to throw away the  cluster and build a new one on rc2, or can this be salvaged?

@MBauer83 I created a WIP PR to check if the e2e tests will pass in a prow environment with CNI enabled.   If not I will try to trouble shoot the issue more in that environment or recreate locally.  The PR is: https://github.com/istio/istio/pull/12331

@MBauer83 The mixer e2e tests all seem to pass with the cni enabled.  I am not sure what is the best way to debug this in your local environment.  Is it still occurring?  Have you tried it with the latest 1.1 images. Can you confirm you followed the CNI install instructions as described here:  https://deploy-preview-3537--preliminary-istio.netlify.com/docs/setup/kubernetes/install/cni/
When you  initially saw teh issue was around the time the Istio and CNI helm charts were being decoupled.   It's entirely possible things were working properly on the install at that point

@douglas-reid -- with your new install of 1.1 on GKE do you see the istio-cni-node daemonset present? In newer release-1.1 versions the istio and istio/cni helm charts are separate and the install of the CNI is a separate step helm template/install operation.

Where is the installation address of a separate CNI template?

I have CNI running on 1.1.2 and it is working fine: http://grafana.v112-cni.qualistio.org.
@MBauer83 is this still an issue in latest releases? I suspect @john-a-joyce is right, that the CNI daemonset is not installed. Make sure you follow the docs here: https://istio.io/docs/setup/kubernetes/additional-setup/cni/
In particular, the helm install install/kubernetes/helm/istio-cni --name=istio-cni --namespace=istio-system step.

I think this is just a docs error that has since been resolved. If you are still seeing this please reopen (or you can open a new issue)


feat(core/services-s3): try load endpoint from config

Which issue does this PR close?

Close #5275
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

For S3 compatible service, try load endpoint_url from config file or environment

Manually tested with a config file


Update Github example to use json.net, and version number bump

@glennblock!

Will make another one, my commit got borked.


Expose LLM

Hi,
Great piece of work here, really well done.
It would be fantastic if we could any supported LLM from langchain to do the evaluation.
I have a number of use cases which require sovereignty, which means essentially either using on prem LLMs or Azure OpenAPI locked to a certain region.
Happy to help wherever I can!

hey, that for raising the issue and offering to help :)
We were a bit hesitant about adding langchain dependency because of how fast it keeps changing but if you could explain a bit more about your use cases that would help.
Basically, what are you trying to improve by bringing in other LLMs? reduce cost? easily try out other LLMs for evaluation? If you could explain a bit about our thought process that would be awesome!

No problem!
Yes exactly - for a given use case in the enterprise there needs to be multiple choices factoring in performance, cost and the quality of results. In addition Azure OpenAPI offers privacy and compliance for the enterprise which is a cut above openAPI, hence it will become the "go to" for at least the next 6 months - at the moment a lot of organizations have closed off ChatGPT / OpenAPI together due to privacy and IP concerns.

alrighty, I will start on a draft to address this shortly. Thank you for the input @HazK 🙂

That sounds great thank you

From: Jithin James @.>
Sent: Saturday, June 24, 2023 6:09:33 AM
To: explodinggradients/ragas @.>
Cc: HazK @.>; Mention @.>
Subject: Re: [explodinggradients/ragas] Expose LLM (Issue #46)
alrighty, I will start on a draft to address this shortly. Thank you for the input @HazKhttps://github.com/HazK 🙂
—
Reply to this email directly, view it on GitHubhttps://github.com/explodinggradients/ragas/issues/46#issuecomment-1605270542, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHYOU5UYESNF3N6ZLHXUWOTXMZZA3ANCNFSM6AAAAAAZRPS4TI.
You are receiving this because you were mentioned.Message ID: @.***>

hey @HazK this is fixed. Thanks for bringing this up and do let us know when you try it
here is the example notebook: https://github.com/explodinggradients/ragas/blob/main/docs/guides/llms.ipynb


Tracking with a mounted single Kinect v2

Hello,
I just installed OpenPtrack and it worked using single Kinect v2. However, the skeleton tracking is rendered properly in Rviz world when I put the Kinect on the floor. The result was not good when I mounted it on the wall. I already did calibration and manual ground plane selection.
Thank you for any response

Closing as we haven't been able to reproduce this issue. Please feel free to re-open if this issue persists using our most recent updates!


Ensure fallbacks in the error pages function correctly

Prior to this change:

the fallback of the unknown-service-provider had
a missing case: that for no idp name.  There was also a word missing
from the Dutch translation.
there was no fallback for the received an invalid signed response error
there was a missing fallback for no-idps-error
the name of the fallbacks for missing required fields was incorrect
the openconext theme had several missing fallbacks

This change adds the cases & fixes the translation.
Pivotal story at: https://www.pivotaltracker.com/story/show/176714319
Relevant comments at:

https://www.pivotaltracker.com/story/show/176714319/comments/224272628
https://www.pivotaltracker.com/story/show/176714319/comments/224272649

Looks solid! Have you considered adding some new visual regression tests for these scenarios? But that might be a slippery slope at this point?

I have, but seems like overkill to me.  Visual tests work best if we use them to check the major design points.  Not the intricacies of the messages itself.  If we test for that, adding cypress tests would be better imo.


cmsis_rtos_v1: add semaphore negative tests, replace an else case

Added couple of negative tests for osSemaphoreWait
and osSemaphoreRelease to increase code coverage.
Replaced an else if case in osSemaphoreWait with else
to account for both EBUSY and EAGAIN return values
from k_sem_take. The return value would be 0 for
osSemaphoreWait in both cases.

Codecov Report

Merging #9548 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9548      +/-   ##
==========================================
+ Coverage   52.17%   52.19%   +0.01%
==========================================
  Files         215      215
  Lines       26018    26016       -2
  Branches     5595     5594       -1
==========================================
+ Hits        13574    13578       +4
+ Misses      10186    10183       -3
+ Partials     2258     2255       -3

Impacted Files
Coverage Δ

lib/cmsis_rtos_v1/cmsis_semaphore.c
60% <ø> (+12.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411662d...c267d64. Read the comment docs.

Hi @rgundi addressed your review comments, thanks


Trace from a Bot does not show up in the Emulator

A bot built using the Node SDK has Trace / Log messages that show up in the emulator. This same scenario should work in the C# SDK.

Fix in #396 and related PRs around the implementation of type=Trace.


Loss become nan

I use train_nets_mgpu.py with batch size 64 to run on 2 gpu.The only change is the batch size.
But at step 88840, all the losses become nan.According to the code, at this iteration, the lr is 0.001, not a large lr problem. Also, the training accuracy is very weird.
should I change the initial lr from 0.001 to 0.0001, because the batch size is only 64
Here is the training log

epoch 0, total_step 88680, total loss: [16.43, 16.24], inference loss: [7.73, 7.54], weight deacy loss: [8.70, 8.70], training accuracy is 0.375000, time 92.323 samples/sec
epoch 0, total_step 88700, total loss: [17.05, 18.03], inference loss: [8.35, 9.33], weight deacy loss: [8.70, 8.70], training accuracy is 0.156250, time 92.043 samples/sec
epoch 0, total_step 88720, total loss: [16.25, 15.06], inference loss: [7.56, 6.36], weight deacy loss: [8.70, 8.70], training accuracy is 0.312500, time 93.241 samples/sec
epoch 0, total_step 88740, total loss: [18.12, 20.31], inference loss: [9.42, 11.62], weight deacy loss: [8.70, 8.70], training accuracy is 0.093750, time 93.002 samples/sec
epoch 0, total_step 88760, total loss: [16.82, 17.98], inference loss: [8.12, 9.29], weight deacy loss: [8.70, 8.70], training accuracy is 0.375000, time 92.508 samples/sec
epoch 0, total_step 88780, total loss: [17.50, 20.11], inference loss: [8.80, 11.41], weight deacy loss: [8.70, 8.70], training accuracy is 0.281250, time 92.468 samples/sec
epoch 0, total_step 88800, total loss: [17.24, 17.54], inference loss: [8.54, 8.85], weight deacy loss: [8.70, 8.70], training accuracy is 0.187500, time 93.764 samples/sec
epoch 0, total_step 88820, total loss: [14.16, 15.54], inference loss: [5.47, 6.84], weight deacy loss: [8.69, 8.69], training accuracy is 0.343750, time 93.311 samples/sec
epoch 0, total_step 88840, total loss: [nan, nan], inference loss: [nan, nan], weight deacy loss: [nan, nan], training accuracy is 0.000000, time 92.466 samples/sec
epoch 0, total_step 88860, total loss: [nan, nan], inference loss: [nan, nan], weight deacy loss: [nan, nan], training accuracy is 0.000000, time 92.594 samples/sec
epoch 0, total_step 88880, total loss: [nan, nan], inference loss: [nan, nan], weight deacy loss: [nan, nan], training accuracy is 0.000000, time 92.265 samples/sec
epoch 0, total_step 88900, total loss: [nan, nan], inference loss: [nan, nan], weight deacy loss: [nan, nan], training accuracy is 0.000000, time 92.653 samples/sec

Hi! Did you solve this problem?

@chaitanyasiva8
Yes, I download the MS1M-ArcFace (85K ids/5.8M images)  from https://github.com/deepinsight/insightface/wiki/Dataset-Zoo

Thanks! I hope it works!

Thanks so much! @ghost. However, how did you find the true reason is "num_output" not others?
I have tried different lr list , but it does not work...


[Remote Store] Using hash of node id in metadata file names

Description
Using hash of node id in remote segment and translog metadata file names
Related Issues
Resolves #10450
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The failing tests are not related to the above changes. These are failing in other gradle runs as well . Since this is a critical fix for Remote Store, I am going to get this one merged.
org.opensearch.script.expression.MoreExpressionIT.testSpecialValueVariable {p0={"search.concurrent_segment_search.enabled":"true"}}
org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException


Packages: containers supporting OCI, granular permissions, and anonymous downloads on GHES (Public Beta)

Summary
This feature tracks the GA release of containers improvements to Packages on GHES. GitHub Packages container support will be improved so you can more easily share containers in your organization, set granular access permissions, and anonymously access public container images. It will also implement the OCI standards for hosting Docker images.
Intended Outcome
Customers on GHES have access to the latest update of GitHub Packages. GitHub Packages encourages inner-sourcing by sharing containers across the organization, allows for better enforcement of access policies, and supports anonymously downloading public container images. Additionally, GitHub Packages container support is optimized for sharing layers between images across the entire organization making it faster and more cost-efficient.
How will it work?
For 3.5, we will enable these new capabilities with exposing a new package registry GitHub Container Registry for all customers with subdomain on. Going forward packages on GHES will align with the updates that rolled out on github.com customers will be migrated from current docker services.

this has shipped to GHES 3.5 🚢<EMAIL_ADDRESS>closing out this issue


Transfer times

I made a couple test transfers that went through quickly before starting to use the Wallet for mining. Yesterday at 2:50 PM (about 19 hours ago) my first mining transfer from ZenWallet to Cryptopia  has not registered as pending on CPIA yet, and shows as a NO on the wallet confirmation column. Is there some transmission time issue I should be aware of, or is this long a wait normal?

Deposit showed up about 22 hours after transfer.

To make a sure a transaction will be confirmed by the ZEN network, you can increase the transaction fee to be larger than the default 0.0001. Once you send out a transaction you can also track its status on the ZEN block explorer https://explorer.zensystem.io/

Ahh...thanks, adding something to the fee is a great idea. How do I know what block to search for on the block explorer though? All I have are the send and receive addresses.

You can search for block/transaction or address. Here is for instance the URL for an address:
https://explorer.zensystem.io/address/znkmhwKuEv4mWDBrWrV9dbAYQAYrL54QhQ7

Support case - no further information received.


Add a case to the valid check

https://github.com/jannicz/appointment-picker/blob/3289e99b3cbef900e85b8633e12cd40af7d41414/js/appointment-picker.js#L319

maxTime sets the maximum hour that can be picked, default is 24

it mean that e.g 9 is set that 9:15 cannot be picked or ?
if yes, add please this check (hour === opt.maxTime && minute) for the intervals, in the moment u can pick 9:00 as last maxTime is correct, but not the 9:[intervals].
     } else if(hour === opt.maxTime && minute > 0){

@Sw0rdiX indeed, you are right. Fix is on the way...


Eventually unable to delete components

Describe the bug
Unable to delete diagram components after deleting a few
Expected behavior
Expect to be able to delete as many components from the diagram as I want to
Environment

Platform: Desktop
OS: MacOS and Windows
Browser NA
Version 1.3.1

To Reproduce
Open a 'busy' diagram and start deleting components. Eventually undable to delete any more off the diagram
Any additional context, screenshots, etc
Workaround is to save the diagram, close it then reopen

Transferring this to upcoming version 2.0 - it will not be done in version 1.x. Version 1.6 is about to be released and this is the last version before 2.0

Confirmed that this is not a problem in version 2.x Threat Dragon, so it can be closed.
Versions 1.6.x is in maintenance mode, so it will not be fixed for 1.6.1


Update hubspot.yaml

Based on pricing available here : https://www.hubspot.com/pricing/marketing/enterprise?products=marketing-hub-professional_1&term=annual

Thank you for your contribution, @nikeshashar. I believe we need to adjust the base tier too. The Hubspot 20$/month option is more for single users, not for a team. Do we want to use the Professional tier for the base price then?

The pricing is actually showing for me in GBP so I've used a conversion. The Starter package they show can be used for small businesses so technically can be a starting point for a new company / startup looking at ssotax as a resource.

Ok, let's keep it like this then.


CSV: Set operator-type: non-standalone

This should hide the heat package/bundle in the OpenShift console as we only want the main OpenStack operator to show up there.

/test heat-operator-build-deploy-kuttl


[IOS] Flutter Web app can be swiped back using a drag gesture which rebuilds the web app

I have a flutter web app, when I open my web app in my iphone 7 , the starting html page is still behind the Route stack pages, I mean when I swipe horizontally(popping the pages in iphone => I mean like backbutton in android but swiping horizontally from left to right in iphone) the white screen(the started html page) shows and the web app rebuild itself and after that when I swipe horizontally again, it seems that the white screen is gone and everything works fine, but everytime that I close the web app and reopen it again, this senario repeats. here is the video of what I mean.
be careful, I don't mean that I want to omit the first white screen,my problem will be from the first screen(orange screen) and this senatio is not happening in android devices and browsers.
thanks a lot.

Hi @A-Eric-J, Thanks for filing the issue. Are you referring to this behavior where the page could be swiped back
(only once) and the web app rebuilds?
https://user-images.githubusercontent.com/31410839/157385307-31966c5d-bec8-44ee-a013-04c6d3e6121a.mov

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.10.3 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (20 hours ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 99.0.4844.51

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi, @maheshmnj thanks for your reply, yes exactly what you mean. the page could be swiped back
(only once) and the web app rebuilds. please tell me how to solve this problem. it has occupied my mind.

Thanks for the confirmation @A-Eric-J, I am able to reproduce the same behavior on stable and the master channel.

please tell me how to solve this problem. it has occupied my mind.

Not that I am aware of, I am labeling this issue for secondary triage who might have a better understanding of this issue.

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.10.3 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (20 hours ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 99.0.4844.51

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 2.11.0-0.0.pre.715, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.11.0-0.0.pre.715 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 8b95cd6f35 (7 hours ago), 2022-02-28 16:31:12 -0800
    • Engine revision 615a60512c
    • Dart version 2.17.0 (build 2.17.0-150.0.dev)
    • DevTools version 2.11.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on
        the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API 30)
    • iPhone 13 Pro (mobile) • CBEF6BFA-D3DC-4680-8900-E01C62A4B04C • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 98.0.4758.109

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

cc: @yjbanov

thank you so much for your attention @maheshmnj , if someone can solve this problem, helped me so much because I have found 2 questions in stackoverflow about this problem(one of questions is mine and another questions has not been answered for 10 months) maybe you can help lots of developers. @yjbanov

A related issue: https://github.com/flutter/flutter/issues/76478
We currently don't have a solid answer to this.

@yjbanov thank you so much, hope to find a solid answer as soon as possible because many developers have faced this problem and it is a bug for international productions in Flutter web and it is not good for Flutter web performance and quality.
please set high priority for this issue. we don't want any people think that because of this problem they should not use Flutter web.

Hi @yjbanov @maheshmnj , do you have any news to solve this problem??? it completely disrupted my project. I think it is an important issue.

still the same problem

@A-Eric-J As mentioned above the team still needs to investigate upon this issue to understand the root cause. If there are any updates you will see them on this issue.

any update

Hi A-Eric-J, Thanks for filing the issue. Are you referring to this behavior where the page could be swiped back (only once) and the web app rebuilds?
Screen.Recording.2022-03-09.at.11.59.13.AM.mov
flutter doctor -v (mac)

It's not just the first swipe back, this happens when any MaterialRoute is pushed as well, it will not go back one page, it will reload the entire app
Navigator.push(context,MaterialPageRoute( builder: (context) => Container()));

Any update on this ? This is basically a blocker for production usage of flutter web on mobile.
The swipe back is a crucial feature of iOS browsing on the web, offering iOS users this experience is a sure way to make sure they they never use your app again.

A workaround in https://github.com/flutter/flutter/issues/55913#issuecomment-1248816491

I am facing the same issue.  I created a one page flutter web app and if I swipe back, blank screen, then swipe forward I'm fine.  However, I have an additional issue.  The one page is a flutter syncfusion datagrid.  It is set for a singletap.  If I double tap on a cell, the app bar goes white (it's clear that the main html page is overlaying it).... if I swipe back then I get another version of the page and everything works again.   I tried the work around but for my current version, that exact code is in error.

I found a temporary fix for this problem - https://stackoverflow.com/questions/55120331/white-panel-arrives-on-double-tap-from-bottom-in-pwa-in-standalone-mode

@lynnyuhn where do you add the code in the fix you linked?

In the index.html.   However, this may not fix the swipe-back completely.  My issue was that when user double-tapped it totally messed with ALL swiping.   But still give it a try - it may solve some issues.  Here is snippet of code in index.html from my actual code.

same issue,any update?

Same issue, updates? When a stable fix

i have the same problem,its terrible.maybe i must spend more time to rewrite my application without flutter.this issue seem appear in many years ago.

Mar 3, 2021 — Today, we're announcing that Flutter's web support has hit the stable milestone

Complex...

any updates on this?

any updates?

Is there a plan for this issue?

Related to https://github.com/flutter/flutter/issues/114324
Consider customising the web initialisation by adding the following to web/index.html:
<body>
  ...
  <script>
    ...

    document.addEventListener('touchstart', (startEvent) => {
      if (startEvent.touches.length > 1) return;
      startEvent.preventDefault();
    }, { passive: false } );

  </script>
</body>

Credit goes to @cheymos via https://github.com/flutter/flutter/issues/114324#issuecomment-2183380482


nvim-cmp causes nvim to crash

Hi,
I spotted a special case where nvim-cmp causes nvim to crash (infinite freeze).
Take this simple snippet saved in a .lua file (I don't know if this is relevant though).
--[[ place your cursor just after the two closing brackets -> ]] --

Enter in insert mode and just press <cr>. The crash should occur.

I can't reproduce it.
https://user-images.githubusercontent.com/629908/131830278-f26585b6-7c32-41af-aaa2-ecfa281eea37.mp4

Ok I found it. It was one of my personal plugin, which maps <CR> in insert mode. Disabling this mapping simply resolve the issue.

@doums Could you provide the trouble mapping?

Of course yes,
    imap <expr> <CR> <SID>AutoBreak()

function s:AutoBreak()
  if pumvisible()
    return "\<CR>"
  endif
  for [open, close] in b:pairs
    if open != close && getline(line("."))[col(".") - 2] == open
      let [line, col] = searchpairpos(s:Escape(open),
            \ '',
            \ s:Escape(close),
            \ 'cnW',
            \ 's:IsString(line("."), col(".")) || s:IsComment(line("."), col("."))',
            \ s:GetLineBoundary('f'))
      if line == line(".") &&
            \ match(getline("."), '^'.s:Escape(open).'\s*'.s:Escape(close), col(".") - 2) > -1
        return "\<CR>\<CR>\<Up>\<C-f>"
      endif
    endif
  endfor
  return "\<CR>"
endfunction

In fact you could use it right with the plugin  doums/coBra.


Unable to use AllowAutomaticPstnFallback in SfBO

[The following parameters are not applicable to Skype for Business Online:] section has AllowAutomaticPstnFallback. However description of AllowAutomaticPstnFallback says the parameter applies to Skype for Business Online.
We confirmed AllowAutomaticPstnFallback did not work with SfB Online.  So I deleted SfB Online from "applies to" section.
We don't know if the parameter works with Onpremise server. If it works with OnPremise server, please add it to "applies to" section.

hi @naminakao - thank you for the PR. This is a known issue. The reason the applicable tag is showing up for SfBO is that these parameters are showing up when PlatyPS runs. The PlatyPS tool just sees whatever is available and reports it as available for the cmdlet. So if we remove the applicable like in PR then PlatyPS will just add it back and see it as a 'new' parameter next time it runs. We are looking into separating which cmdlets show for SfBO vs. SfB Server.


Display pending rows again

This was removed by #9473, but that breaks the "Start a chat" case.

r? @keybase/react-hackers, cc @zanderz . This still isn't perfect, since if you click "Start a chat" with someone new and don't actually chat, the pending row will hang around. But I don't think that was even working before...

I started doing as you suggested, @MarcoPolo, but I started having second thoughts. The first problem is that, although, it's nice that treating 'Start a chat' as a filled-in search gives most of the behavior we want, it's still a bit weird to be put into search mode when presumably the user just wants to start a one-on-one chat.
The second problem is that a new search puts the focus on the search bar, which is annoying in the 'Start a chat' case, since presumably the user just wants to start chatting right away. Fixing this would seem to require storing some state in the global state. (sigh)
However, the alternative isn't great either. We'd have to (re)add logic to display and un-display pending conversations so that they behave as expected.
Thoughts?

I think it's probably fine to put the user in search mode if we focus the text input first. But maybe we should first check if there is already an existing conversation and select that first, if not enter the search mode with the text input selected. But this is probably a design question?

https://github.com/keybase/client/pull/10015 is a better fix, I think.

Now obsolete.


deps里缺乏文件

您好，我是一名高校研究生，在安装wukong的时候，发现deps里缺少文件librdma-1.0.0.tar.gz

Wukong provides a script (deps.sh) to help install all deps, which will download files (incl. librdma-1.0.0.tar.gz) and install them in your deps/ directory. If you want to do it by yourself, you could download the file from "http://ipads.se.sjtu.edu.cn/wukong/librdma-1.0.0.tar.gz" and follow the steps listed in deps/INSTALL.md.

Thank you very much!

@realstolz The link to librdma now requires login. Could you please fix the link?

@realstolz Found a version from here https://github.com/Mogami95/RDMA-Playground/blob/master/WK-COMM/librdma-1.0.0.tar.gz

The library has been extracted to the source of Wukong and is no longer need to download. The standalone version of the library has been moved to: https://github.com/wxdwfc/rlibv2 .

@wxdwfc Thanks! Guess Wukong's doc deps/INSTALL.md should be updated.


Prepare 0.3.0 release

[x] Add prelude release note
[x] Merge #326
[x] Merge #285
[x] Deal with anything else relevant on 0.3 milestone
[x] Move all final notes to 0.3 directory
[ ] Merge this PR
[ ] Tag the release
[ ] Close the release milestone
[ ] Create the stable/0.3 branch.
[ ] Get docs to deploy from new stable branch

Previous release PR: #175

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.844%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2928

Relevant Lines:
3188

💛  - Coveralls


Update regular expression tests related to $ and strings ending with \n

Update tests and documentation now that https://github.com/rapidsai/cudf/issues/9620 is resolved.
The cuDF fix means that $ now correctly matches strings that end with \n but unfortunately, we still have an issue with strings that end with \r so the documentation is updated to refer to a new issue for that.

I am closing this because the cuDF change is being reverted. I have an alternate approach to fixing this via the transpiler and will open up another PR,


Created Readme with some base guidelines for Redux

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Loom Video
Added# (Readme)
Created README file within the state folder to provide guidelines on using Redux.
Contributors
@ST1414 (Sean Terry)
Please delete options that are not relevant.

[x] This change is a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] I have made corresponding changes to the documentation if necessary

I love to see more documentation being added - great work here!


setup does not work

Following these instructions from the README
Quick start
Clone this repo using $ git clone --depth=1 https://github.com/mxstbr/react-boilerplate.git
Run $ npm run setup to install dependencies and clean the git repo.
At this point you can run $ npm start to see the example app at http://localhost:3000.
Run $ npm run clean to delete the example app.
I get an error:
git clone --depth=1 https://github.com/mxstbr/react-boilerplate.git
cd react-boilerplate/
npm run setup

<EMAIL_ADDRESS>presetup /home/bcowgill/workspace/play/react-boilerplate
npm i chalk

<EMAIL_ADDRESS>/home/bcowgill/workspace/play/react-boilerplate
└─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>setup /home/bcowgill/workspace/play/react-boilerplate
node ./internals/scripts/setup.js

Cleaning old repository ✓
Installing dependencies.. ✓(This might take a while)Installing dependencies
Initialising new repository ✓

<EMAIL_ADDRESS>postsetup /home/bcowgill/workspace/play/react-boilerplate
npm run build:dll
<EMAIL_ADDRESS>build:dll /home/bcowgill/workspace/play/react-boilerplate
node ./internals/scripts/dependencies.js

module.js:341
throw err;
^
Error: Cannot find module 'shelljs/global'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at Object. (/home/bcowgill/workspace/play/react-boilerplate/internals/scripts/dependencies.js:8:1)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Function.Module.runMain (module.js:447:10)
npm ERR! Linux 3.19.0-43-generic
npm ERR! argv "/home/bcowgill/.nvm/versions/node/v5.10.1/bin/node" "/home/bcowgill/.nvm/versions/node/v5.10.1/bin/npm" "run" "build:dll"
npm ERR! node v5.10.1
npm ERR! npm  v3.8.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build:dll: node ./internals/scripts/dependencies.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:dll script 'node ./internals/scripts/dependencies.js'.
If I try the normal thing of just running npm install, I get
npm install
npm ERR! Linux 3.19.0-43-generic
npm ERR! argv "/home/bcowgill/.nvm/versions/node/v5.10.1/bin/node" "/home/bcowgill/.nvm/versions/node/v5.10.1/bin/
npm" "install"
npm ERR! node v5.10.1
npm ERR! npm  v3.8.3
npm ERR! No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! 2.1.0-beta.7, 2.1.0-beta.6, 2.1.0-beta.5,

Actually, looks like this was an issue with my local package cache.

How did you fix this @bcowgill? Thanks!

Yep, same thing here.

Sounds like a possible npm cache problem. try npm cache clean then npm install.

I have the same problem.

@everythingspirals Did you run npm cache clean then npm install?

I had
module.js:327     throw err;
Updatin npm version from 2.15.5 to 3.10.3 fixed the problem for me.

I am still facing this issue even after node-npm upgrade.

@skskumbharkar Have you tried npm cache clean?
Setup is self-deleting (to prevent later disasters), if you have already run it once, you may need to git clone a new copy of the repo.

I just removed my all installed node_modules.
And then used "npm run setup".
It is working fine now.

worked for me after upgrading to latest npm

Late to the party, but going off https://github.com/react-boilerplate/react-boilerplate/issues/544#issuecomment-230880439, why do people report success after updating npm / npm clean cache?
This happened to me after installing three.js via npm. I was able to repair by resetting package.json / package-lock.json to their default versions, npm clean cache, npm install, and npm run start.
I'm going to go back through the process of installing three.js and see if I can pinpoint what's causing it to break.


"wrangler generate my-app https://github.com/cloudflare/worker-template" fails with "Git Error: failed to clone into: ..."

sorry if this is not the right place to report this problem, I'm not sure where the problem lies and I don't know how to further debug it.
I followed the docs and did the following
npm install -g @cloudflare/wrangler
wrangler generate my-app https://github.com/cloudflare/worker-template

But it failed with the following error:
🔧   Creating project called `my-app`...
Error: ⛔   Git Error: failed to clone into: /Users/gregor/Projects/cloudflare-workers/my-appIrjVg4
Error: tried running command:
/Users/gregor/Library/Caches/.wrangler/cargo-generate-0.5.0/cargo-generate generate --git https://github.com/cloudflare/worker-template --name my-app --force
exited with exit code: 1

$ node -v
v14.15.1
$ npm -v
6.14.8
``

same problem as https://github.com/cloudflare/wrangler/issues/1168. This workaround worked for me: https://github.com/ashleygwilliams/cargo-generate/issues/168#issuecomment-520065102
the cause of the problem seems to be an upstream issue which maenwhile has been resolved: https://github.com/ashleygwilliams/cargo-generate/issues/168

I'm still experiencing this issue.
Node v15, npm v7.

Solved it with this: https://github.com/rust-lang/cargo/issues/3381#issuecomment-308460530


Fix typo in ReactServerNoResponseError message

Description
Fixed a typo in one of the error messages present in the quilt_rails package. The error is raised in the react_renderable file under the name of ReactServerNoResponseError. The initial message had a typo for "presists" which I would imagine is supposed to be "persists" (though it may be a term I'm not aware of :) )
Type of change
Spelling fix in quilt_rails

[x] quilt_rails Patch: Bug (non-breaking change which fixes an issue)

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@ismail-syed Sorry for the basic question, but, does this change require a changelog entry, and would it be considered a breaking change. This is a fairly small update, but I wouldn't want an external service that relies on the message of the error, for instance, to break.
Just want to better understand if this is good to merge into master 😄

@paarthmadan  as a typo it should be ok for it to be a patch

Thanks for the information, @TheMallen – that helps! I've added a changelog entry under the "Fixed" heading.


get_artist | Undefined property: stdClass::$musicImmersiveHeaderRenderer

Hi !
Thank you so much for you work ! It's an amazing wrapper !
But I'm encountering an issue, using it in Laravel v10.
Usage
dd($this->youtube->getYTMusicAPI()->get_artist('UCK3inMNRNAVUleEbpDU1k2g'));

Issue

Tell me if you need more informations.
Thanks for you help !
Best regards

Thanks for your report! I've verified this issue also occurs in the original Python version of the library. It looks like YouTube Music considers this to be a regular YouTube user rather than an artist, so it isn't returning the standard artist information. I've made some updates in v0.1.4 which should fix this issue. I'll leave this open until you can verify it is working.

Allright !
Now it works like a charm !
Before your fix, i've partially fixed with a try/catch....
Thanks for your reactivity ! You saved my week-end ! :D


Add prettier to template

Add prettier, husky, and lint-staged to the template's package.json

Close #43

@jaredpalmer How do we customize the prettier config? I tried .prettierrc but it's not being picked up


feat(datadog) allow adding tags to all Datadog metrics

Summary
Without this, the only way to add tags to every metric emitted by the Datadog plugin is to completely specify the entire metric list, which is tedious, error-prone, and not forward-compatible. This adds a feature that lets a user specify a list of tags to add to every metric emitted by the Datadog plugin.
Full changelog

Allow adding tags to all Datadog metrics emitted, not just per-metric.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Nice one. Mind renaming "tags" to something more self-describing? "common_tags" perhaps? Totally open to other better suggestions.

I'm really struggling to get the unit tests working locally, even in the docker-compose stack described in .devcontainer, but once I get that figured out I'll try to get this passing and updated.

I would love to, but the test suite has stubbornly refused my (considerable!) efforts to get it running locally. :sob:
I've tried a couple of different Docker containers and no Docker container at all, but I keep running up against (different) issues. I've read through various docs and example code, but no luck. Is there any other documentation I should read? Or is my best bet to hop on Gitter and see if anyone can help?

@stpierre Was this closed because of the test failure? Any chance of reviving it?

@dcarley Basically, yeah. I never was able to get the tests running locally, and don't have time to fuss with this. If you want to take it over, please do -- I'd still love to have the feature!


Updated notebook

Cleaned up the notebook, but I'm wondering you y'all think there should be some general redesigns of this notebook. Let me know.

Dont merge, I'm re-formatting this

You are welcome to merge now


Create social media graphic for AMA session

Story
No response
Description
Ideally we have a graphic that we can use on social media to promote the upcoming AMA session.  The graphic should include the following:
Title: Ask Me Anything about Node-RED
Date:  Februay 9 @ 17:00CET / 11:00AM ET
Meet the Experts
Nick O'Leary, co-founder Node-RED & CTO @ FlowForge
Rob Marcer, Developer Advocate @ FlowForge
Two headshot of Nick and Rob


Selecting a favourite asset should display a progress screen

When you select a favourite asset, the asset id is fetched then stored in state, however the user is directed to a next page temporarily whilst it loads, before being directed to the nft page.
Rather than have an irrelevant page show whilst we wait for the NFT page to load, an 'in progress' page should be shown instead.

With the latest client release, a progress screen is shown whilst a chosen favourite asset is loading.


Add in loading config from a JS file

Make it easier to configure CodeceptJS

Not include keys in config files / source control
Run on different browsers via env flags

RE Issue #59

Thank you!

Run on different browsers via env flags

Btw, could you explain how to use env flags?

@DavertMik your onto them quick today :smile:
For using env settings ... with this I can write my codecept.js config file like this ...
exports.config = {
  helpers: {
    WebDriverIO: {
      url: process.env.url,

... more configs ...

I can then run
url=https://beta.example.com codeceptjs run --steps
To control what url the tests run against, good for switching between localhost, test, prod ... same logic applies to the keys for things like sauce labs. Even going to use it to control running our test suite against multiple Browser/OS combinations.

Im lost as to why the build is breaking, my changes should have no effect if you don't have a codecept.js file sitting where the config lives

Im lost as to why the build is breaking, my changes should have no effect if you don't have a codecept.js file sitting where the config lives

Looks like it was Travis issue

To control what url the tests run against, good for switching between localhost, test, prod ... same logic applies to the keys for things like sauce labs. Even going to use it to control running our test suite against multiple Browser/OS combinations.

Ok, that makes sense. I think I should mention this in documentation


[Feat]: ADD more resources

What feature?
addition of more youtube resources for learning
Show us the magic with screenshots
No response
Agreement to Code of Conduct

[X] I agree to follow this project's Code of Conduct

@PiyushKalyanpy please assign me this issue under gssoc 23

Please explain more about this.

I just want to add more resources in the json file

@PiyushKalyanpy

We will not store our data in json file, we will store out data in firebase. If your questions is something else, please make a new issue and clearly specify the issue.


Capture GC log using jattach

Hi,
I am running one java application without turning on the GC logging. I cannot use jstat because I don't JDK. When I used jattach <PID> jcmd GC.class_stats > gc.log command, it returns data but as per my understanding, I think that is not a valid GC log format.
Is there any other way to capture a GC log from the running application?

I'm not sure what you mean by "capture GC log".
jattach does not implement any monitoring functionality itself; it only invokes diagnostic commands that the target JVM provides.

Thanks for your reply. I meant to say how can I collect garbage collection-related information from the target JVM. We can get GC information using the jstat tool. For example jstat -gc -t <PROCESS_ID> 10000 30. Similar to this is there any way to get GC information using jattach?

This question has been already answered in #36

Thank you @apangin


Not working

Hi,
I am trying to use the flexslider add-on but it just displays shortcodes, not generating the slides,
Font Awesome icons add-on, however works great.
Any ideas?
thanks!

sorry my bad :D


A way to list per-file-ignore rules for debugging

Hi!
Thank you for building this fantastic tool, I had a small request, or guidance on how to contribute a feature my self, is there a way to get debug output for the per-file-ignores rules, so i can understand exactly what the created globs were.
(for background: i couldn't figure out why no variant of **/test/**/* wasn't working and it turns out that per-file-ignores are calculated relative to the extended ruff.toml file, which was an issue in my case as my config file was in a sibling folder, rather than the parent, so the pattern would never be able to match files in the current directory).
I ended up adding a hack to debug this and finally figured out the issue, but it would be helpful if there was a verbosity level which printed this information:
        settings.per_file_ignores
            .iter()
            .for_each(|(absolute, basename, _)| {
                println!("ignoring: abs: {} basename: {}", absolute.glob(), basename.glob())
            });

example output:
ignoring: abs: /Users/me/Workspace/gitlab.eng.comp.com/something/server/**/test/**/* basename: **/test/**/*
...

Thanks.

Let me see what we include under the various CLI flags...

I'll add this to the -v logging.

In the meantime, though, if you just want to see the resolved regexes, you can do ruff foo --show-settings. Look at the per_file_ignores section, and take a look at the re. (All filenames are converted to absolute, so those are what get matched against the regexes.)

Oh, i hadn't realized those were in there, thank you!

No worries! It could be nice if we also told you when a pattern matched a file. We already do that for exclude (if you set --verbose).


Fixed errors in hello_world example

Fixes MADLIB-967 Hello World Example Errors

LGTM except the 4 commits need to be squashed and the commit message needs to be updated per the guidelines (Step 5 of contribution guide).


Add built-in search engine

Complement existing integration of Algolia search engine with option of built-in search engine based on Fuse.

Documentation: https://sourcethemes.com/academic/docs/search/

Hi,
Thanks for this feature! How does it works with multilingual?
For example, my website is in french (default) and english. So I copied search.md to content/home/search.md and content/home/search.en.md.
But when I use english, results are french posts?
Thanks!

After further investigation, hugo generate one search.json for each language:
public
├── en
│   ├── search.json
├── fr
│   ├── search.json

So we should load corresponding search.json file
I will open a new issue for this.


randomx: 1.1.7 -> 1.1.8

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/randomX/versions.
meta.description for randomx is: "Proof of work algorithm based on random code execution"
meta.homepage for randomx is: "https://github.com/tevador/RandomX"
meta.changelog for randomx is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/90a98cac237bc08a3e89c0f23e6817ab

du listing: https://gist.github.com/5236cb130141c41a00ac87cab2d46369

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
monero
monero-gui
randomx

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pggzr245qacdcxr23snhx4awcx6dm7wi-randomX-1.1.8 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A randomx https://github.com/r-ryantm/nixpkgs/archive/017f120e5042b7303b86d31110f242080856f9ef.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pggzr245qacdcxr23snhx4awcx6dm7wi-randomX-1.1.8
ls -la /nix/store/pggzr245qacdcxr23snhx4awcx6dm7wi-randomX-1.1.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

3 packages built:
- monero
- monero-gui
- randomx

Maintainer pings
cc @rnhmjoj for testing.

@GrahamcOfBorg build monero monero-gui


new block format pt2 -- remove specials

part 2 in a series of PRs addressing #246.

removes block.body.specials
move all specials to specific block objects contained in block.body
Create section "Block objects" in per-slot processing for all these body object types

stuck with "Operations" to describe handling the block.body
removed Record from the suffix of these data structures
addressed other PR comments
handled merge conflict from master

Let me know thoughts/further review

cc: @JustinDrake @hwwhww for another look

Highlight @JustinDrake 's changelog:
Casper cleanups and bug fixes

(cleanup) SpecialAttestationData => CasperVotes
(cleanup) vote_1, vote_2 => votes_1, votes_2
(bug fix) Place a bound on the number of votes with MAX_CASPER_VOTES
(bug fix) Supply state when calling verify_casper_votes


CAMEL-12685: fix xslt nested relative refs

If an XSLT A includes XSLT B which includes XSLT C using relative references, XSLT C is resolved relative to A instead of B.
An example is added in unit test XsltIncludeRelativeNestedTest.
This PR changes this behavior to the expected one, i.e. resolve relative references based on the location of the direct parent XSLT.

Please create an issue on https://issues.apache.org/jira/browse/CAMEL with details and reference it in the commit message.

Yes, but in the commit message too, that way we can track the change.

OK, I rebased and squashed the commits with a new commit message.

Great thanks.

Thanks. Merged on master.


Add support for loadbalancer interface

This adds support for the loadbalancer interface so that cloud-native LBs can be provided by the integrator charms. Additionally, it simplifies the confusing way the relations between the masters and workers change depending on whether kubeapi-load-balancer is being used or not by making that use the same lb-provider endpoint and always forwarding the API endpoint URLs via the kube-control relation.
Part of lp:1921776
Depends on:

https://github.com/juju-solutions/loadbalancer-interface/pull/13
https://github.com/juju-solutions/interface-kube-control/pull/33
https://github.com/charmed-kubernetes/charm-kubernetes-worker/pull/84
https://github.com/charmed-kubernetes/charm-kubeapi-load-balancer/pull/11

New manual integration test results after rebase from master.

I walked through the upgrade path for this. The port served by kubeapi-load-balancer changed from 443 to 6443, which meant I had to redownload the kubeconfig from kubernetes-master. Make sure to include that in the documentation upgrade notes.


Use updated version of left-arm/vdr-tools

removed cheqd & cosmos
removed unused deps

Signed-off-by: Artem Mironov<EMAIL_ADDRESS>

Codecov Report

Merging #596 (a9fba69) into main (804bd43) will decrease coverage by 11.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #596       +/-   ##
===========================================
- Coverage   59.10%   48.04%   -11.06%
===========================================
  Files         198      197        -1
  Lines       19047    14240     -4807
  Branches     4358     2752     -1606
===========================================
- Hits        11257     6842     -4415
- Misses       3458     5205     +1747
+ Partials     4332     2193     -2139

Flag
Coverage Δ

integration-aries-vcx
?

unittests-agency-client
29.33% <ø> (ø)

unittests-aries-vcx
47.58% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Some questions in model.py

Hello, I am very fond of your paper and work,but I have some problems when I try to understand your code.
In model.py:
def get_loss(self, batch, full_vocab=True, logits_key='pet_logits'):
# Compute Cross-Entropy loss for prompt verbalizers
assert logits_key in batch, 'logits should be pre-computed and stored in batch dict'
masked_logits = batch[logits_key][batch['pet_flags'] == -1]
labels = batch['pet_labels']
 if not full_vocab:
masked_logits = masked_logits[:, self.label_ids]
labels = batch['label_ids']
return self.loss_fn(masked_logits, labels)
The size of masked_logits is [batch_size,hidden_states] (I used batch_size=4 and bertmodel so the size is [4,768]), and the size of labels is [batch_size,] . However,when computing crossentropy loss,it always raises error that Index out of range. Is there lacking some layers that can transform the masked_logits's size ([4,768]) into [4,num_classes]?
Meanwhile, I also can't understand the meaning of "full_vocab":when to set it false and when to set it true?
Looking forward to your reply!

Hi humoxian, refering to the code https://github.com/zjunlp/DART/blob/d418ded8bd548ef25f2d030990e707a497e93483/src/model.py#L33 , the argument full_vocab means whether compute cross entropy loss on all tokens in vocabulary or only on target tokens (i.e., the verbalizer tokens).
FYI, pet_flags refers to different types of tokens' positions(not well documented but you can find it here, as 0 = sentence; 1 = special; 2 = prompt; -1 = <mask>).
Here we get the logits of  tokens, whose size by design should be [batch, vocab] or [batch, class] (if not full_vocab) for our AutoModelForMaskedLM model. If the size didn't match here, it is possible that you modified the model class to a base bertmodel whose output logit shape is [batch, hidden] like [4, 768] as your mentioned?
For the error Index out of range, it is typical when the target label index exceeds the logits' second dimension (i.e., the class dimension). As your logit shape is [4, 768] it is possible as the label index might be large (for bert the vocabulary size is ~30,000 tokens).
Hope that helps!


Stand alone docker for offline execution

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @vitalyshalumov - can you provide more details of what you want? There is a Dockerfile in the /docker folder - is that what you are after?

I want a stand-alone docker image with all the relevant libraries installed, which I can run with docker run - similar to: https://github.com/h2oai/h2ogpt/blob/main/docs/README_DOCKER.md

We have an image, you don't need to install anything - the only thing is that for now you do need to supply our lavague-files folder as a mounted volume so you need to git clone the repo or download that folder but I am going to update the image so that is not necessary in the future.
Instructions for using the docker image are here in the LaVague with docker section: https://docs.lavague.ai/en/latest/docs/get-started/setting-up-la-vague/

Thank you!


Not working with IE11

With Internet Explorer 11, off() function doesn't work.
Cause : the regular expression used can't work because IE returns a beautified value (a space is inserted after each ':') of style attribute when using doc.getAttribute('style').

Thanks for reporting the bug! It made me learn a better way of setting inline styles.

Released in 1.1.2. Let me know if anything else goes haywire.


Loading encrypted key file rather than using private key

To send transaction, ECDSA key is required and registerBLS command load ECDSA key from PRIVATE_KEY environment variable, which contains private key of the account.
In here, there are two issues.

Raw private key exposes on public. As always, no one wants to expose this for safety especially node operators.
eigenLayer CLI creates encrypted key file, so AVS operators are familiar with to handle this in general. To get the private key, some extra steps are required for AVS operators and we can reducing unnecessary steps.

If we agree with above, we could make it by,
Set ECDSA_KEY_FILE instead of raw private key, additionally, we should remove environment variable and use flags instead as mentioned at #15 .
If the command can get ECDSA Key file path, use Keystore.LoadECDSA() to load ECDSA Key from keyfile at keystore/keystore.go

Agreed :)


All strings matching current version are bumping up in setup.py file.

Here is the problem. My setup.py look like this (as below):
from setuptools import setup, find_packages

setup(
    name='my-pack',
    version='0.2.1',
    packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]),
    install_requires=[
        'someotherpackage==0.2.1',
    ],
)

After running bumpvesrion command bumpversion --current-version `python setup.py --version` patch setup.py> I got this output:
from setuptools import setup, find_packages

setup(
    name='my-pack',
    version='0.2.2',
    packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]),
    install_requires=[
        'someotherpackage==0.2.2',
    ],
)

The problem is the bumpversion should only bump the version of my-pack only instead it is bumping all the versions (or I can say strings) matching current version.
Is there any available solution for this issue?

Hey. Please have a look at the search and replace options.
Closing as duplicate of #178 #76 #46, but feel free to re-open.

Thanks for replying. I'd tried to add search and replace options but these don't work as expected.
Here is my .bumpversion.cfg file:
[bumpversion]
current_version = 0.2.2
[bumpversion:file:setup.py]
search = version='{current_version}',
replace = version='{new_version}',

And here is the setup.py when I run the bumpversion command:
from setuptools import setup, find_packages

setup(
    name='my-pack',
    version='0.2.3',
    packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]),
    install_requires=[
        'someotherpackage==version='0.2.3',',
    ],
)

It would be great if you can help me in this problem.


Fix typos and improve grammar in README

This pull request fixes a few typos in the README.

Thanks, I guess I wrote the readme a bit too quickly :)


missing mention of openssl dependency?

I don't see a reference to the dependency to openssl. Got a build error that these files were missing:
../../../addons/ofxLibwebsockets/libs/openssl/lib/osx/libcrypto.a
../../../addons/ofxLibwebsockets/libs/openssl/lib/osx/libssl.a

Had to get openssl, configure and build and then create that directory path and copy those generated files from /usr/local/ssl/macos-x86_64/lib. Hope I didn't miss something in your guide...

Ah! Is this in an example or from the project generator? OpenSSL is compiled into OF (which I didn't realize when I first built this lib!), so those links shouldn't be necessary. I've since removed the libs and links, but let me know where you're getting errors and I'll figure it out!

It's generated by Express Generator, which I always use to quickly fire up a working Node.JS project and I think many others too. Can't try my Myo at the moment but I'll test the new code hopefully tonight. Thanks!

Argh! This was the example project in the https://github.com/mattfelsen/ofxMyoWebSockets ofxaddon. I decided to get and compile openssl to comply with the dependencies of the project instead of blindly removing them. Did that now and it compiles fine. Nothing to do with your ofxLibwebsockets, yay! Thanks for the quick response.