Change RestClientConfiguration#connectionTimeout to Duration

Change RestClientConfiguration#connectionTimeout from Integer to Duration. Reflect the change also in DefaultRestClient.Builder#connectionTimeout.

can i look into it?

@ASDasd341 No need, but thank you.


Update the homeProjects Section

I would like to make some changes in the homeProjects Section.
It will make the section look more organised and complement to the body section.
This is the current homeProjects Section.

After the changes it'll look more like:

Please assign this issue to me.
Thankyou :)

@Vishal-raj-1
Sir, Please assign this issue to me.

@UJALA-TYAGI you can go ahead .

Thank you so much ma'am.

Ma'am done. Please check the code I've already made a PR.


[dvsim] Allow setting {tool}_build_opts and {tool}_run_opts

DVSim tool provides the ability to set built time and run time options via build_opts and run_opts keys in HJson. But what if the switches need to be set differently for each tool? We solve this by setting tool specific build / run modes and we enable those modes like this en_build_modes: ["{tool}_my_custom_mode"]. An example of this can be found here:
https://github.com/lowRISC/opentitan/blob/1a10750ef129f39eab9bde2b12fee62ad492ce4f/hw/ip/aes/model/aes_model_sim_opts.hjson#L12
A better alternative is the augment the DVSim Modes class to allow setting vcs_build_opts and vcs_run_opts directly which will be used to set the tool-specific options, rather the limit it to generic, tool-agnostic versions of these opts. The example above would then look like this:
  build_modes: [
    {
      name: aes_model_build_opts
      vcs_build_opts: ["-CFLAGS -I{build_dir}/src/{aes_mode_src_dir}", "-lcrypto"]
      xcelium_build_opts: ["-I{build_dir}/src/{aes_mode_src_dir}", "-lcrypto"]
    }
  ]

This makes it relatively easy and natural to add support for more tools.

I like this. Also what if a user wants to add a few options to run across a regression - typically run-time, such as:
+UVM_TIMEOUT=1000 +uvm_set_severity, +my_own_value_plusargs
While we can do inside the HJSON - hard to across tests (Maybe HJSON can allow this indeed), maybe we can add an env-var like:
setenv SIMV_OPTS <>
I have mixed feeling about that solution, maybe there are better ways, but the problem is real, I face it at many client projects.

I like this. Also what if a user wants to add a few options to run across a regression - typically run-time, such as:
+UVM_TIMEOUT=1000 +uvm_set_severity, +my_own_value_plusargs
While we can do inside the HJSON - hard to across tests (Maybe HJSON can allow this indeed), maybe we can add an env-var like:
setenv SIMV_OPTS <>
I have mixed feeling about that solution, maybe there are better ways, but the problem is real, I face it at many client projects.

That's exactly what the tool-agnostic run_opts is for, which can be set at various places - 'bare' in HJson (applies to all tests), within build_modes (collection of build options distilled into a single switch), run_modes (collection of runtime options distilled into a single switch), test specifications (applies to only that particular test entry), and regression entries (applies to all tests in that regression).


[Publisher] Add sample API deployment capability

Description:

When no APIs created in publisher , Provide option to create sample API and publisher it by single click
Same as what we had in APIM 2.x.x

Affected Product Version:

APIM 3.0.0-m11

OS, DB, other environment details and versions:

N/A
Steps to reproduce:
-N/A

Related Issues:

Fixed with https://github.com/wso2/carbon-apimgt/pull/4863


Fixed the behavior of validate_user function in validations.py.

Updated validations.py python script.
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!

@googlebot I signed it!


ReferenceError: google is not defined

I'm getting a ref. error if I define a class that extends google.maps.OverlayView, but works as expected if that code is commented out.
this repo is a MRE I created which demonstrates the issue. It's essentially a nextjs clone of the react code in googlemaps/samples
Environment details

using nextjs with react-wrapper
macOS 14
react-wrapper v1.1.35

Steps to reproduce

clone repo
run dev server
MapsComponents.tsx is where the overlay class is defined as well as the map component. The Wrapper component is defined in GoogleMapContext.tsx

Stack trace

Hi @shane806,
this is a very common problem with the google maps API.
Since the API loads in a separate request, it's exported symbols (google.maps.OverlayView in your case) are not available in the JS runtime at the time your class is loaded and the extends google.maps.OverlayView is evaluated.
There are two ways you could deal with this:

wait with loading your custom overlay until google maps is loaded (for example using const {CustomOverlay} = await import('...'), which should also work with most bundlers these days)
don't use extends for your custom overlay (this is what we've done a lot).

In the latter case, a skeleton implementation could look something like this:
class CustomOverlay {
  constructor() {
    this.overlay = new google.maps.OverlayView();
    this.overlay.onAdd = () => this.onAdd();
    this.overlay.onRemove = () => this.onRemove();
    this.overlay.draw = () => this.draw();
  }
  onAdd() { /* ... */ }
  onRemove() { /* ... */ }
  draw() {
    const p = this.overlay.getProjection();
    const pane = this.overlay.getPanes().floatPane;

    // [...]
  }

  setMap(map) { this.overlay.setMap(map); }
  getMap() { return this.overlay.getMap(); }
}

// ... somewhere else (when api is loaded):
const map = new google.maps.Map( /* ... */ );
const overlay = new CustomOverlay();
overlay.setMap(map);

@wangela it would be great if this detail (can't declare a subclass until after the maps api is loaded) was somehow mentioned in the documentation at https://developers.google.com/maps/documentation/javascript/customoverlays#subclass

Thanks @usefulthink, that second option will integrate with my current custom overlay implementation just fine.
I figured it was most likely some issue with the maps API not being loaded/available, but this interface extension:
interface MapProps extends google.maps.MapOptions {
	style: { [key: string]: string };
	onClick?: (e: google.maps.MapMouseEvent) => void;
	onIdle?: (map: google.maps.Map) => void;
	children?: ReactNode;
}

which is similarly defined in the file's global scope doesn't cause a reference error to be thrown. Is it because google.maps.OverlayView is a class or something?

Oh, this is different since it's just a typescript interface, and those don't actually exist in the JS runtime. The type-definitions for the Google Maps API are available in the @types/google.maps package from npm, but those are basically just to let your editor know what properties are available on which objects.

Oh right. makes total sense now that I'm thinking about it.
Thanks again!


Fix the order of arguments of symbolic dependent variables in tutorial

following https://github.com/SciML/MethodOfLines.jl/issues/165#issuecomment-1271813163

Thanks!


Removed warning in ViewImports integration test

Part of #1497
Get rid of warning for _ViewImports test.

Agreed. I'll move this comment to the issue so this doesn't get lost after the merge.


artifactory action Fails with 407 authenticationrequired

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

When using Action: artifactory seeing an issue:

With PROXY Settings

in fastlane's lane
in systems settings

Without PROXY Settings

in fastlane's lane
in systems settings

Command executed
bundle exec fastlane uploadAppBuildArtifactory --env DEVELOPMENT --verbose
Complete output when running fastlane, including the stack trace and command used

def artifactory_upload(file, repoPath)
    artifactory(
      username: ENV['ARTIFACTORY_USER'],
      password: Base64.decode64(ENV['ARTIFACTORY_PASSWORD']),
      endpoint: ENV['ARTIFACTORY_SERVER_URL'],
      repo: ENV['ARTIFACT_REPO'],
      ssl_verify: false,
      file: file,
      repo_path: repoPath
    )
end

file and repo are obtained in a different def.
[✔] 🚀
[20:32:58]: Loading from './fastlane/.env.DEVELOPMENT'
+------------------------------+---------+----------------------------------------+
|                                  Used plugins                                   |
+------------------------------+---------+----------------------------------------+
| Plugin                       | Version | Action                                 |
+------------------------------+---------+----------------------------------------+
| fastlane-plugin-versioning   | 0.4.3   | get_version_number_from_git_branch     |
|                              |         | increment_build_number_in_xcodeproj    |
|                              |         | get_version_number_from_plist          |
|                              |         | get_build_number_from_plist            |
|                              |         | ci_build_number                        |
|                              |         | get_version_number_from_xcodeproj      |
|                              |         | increment_version_number_in_xcodeproj  |
|                              |         | increment_version_number_in_plist      |
|                              |         | get_app_store_version_number           |
|                              |         | get_info_plist_path                    |
|                              |         | get_build_number_from_xcodeproj        |
|                              |         | increment_build_number_in_plist        |
| fastlane-plugin-lizard       | 1.3.2   | lizard                                 |
| fastlane-plugin-trainer      | 0.4.1   | trainer                                |
| fastlane-plugin-xcov_report  | 1.1.3   | xcov_report                            |
| fastlane-plugin-xchtmlreport | 0.1.1   | xchtmlreport                           |
+------------------------------+---------+----------------------------------------+

[20:32:59]: ------------------------------
[20:32:59]: --- Step: default_platform ---
[20:32:59]: ------------------------------
[20:32:59]: Driving the lane 'ios uploadAppBuildArtifactory' 🚀
[20:32:59]: ------------------------------
[20:32:59]: --- Step: get_build_number ---
[20:32:59]: ------------------------------
[20:32:59]: $ cd /Users/gitlabRUNNER/builds/Yhi_rQUe/0/app && agvtool what-version -terse
[20:32:59]: ▸ 1
[20:32:59]: --------------------------------
[20:32:59]: --- Step: get_version_number ---
[20:32:59]: --------------------------------
[20:33:00]: -------------------------
[20:33:00]: --- Step: artifactory ---
[20:33:00]: -------------------------
[20:33:00]: Uploading file:  /Users/gitlabRUNNER/builds/Yhi_rQUe/0/app/build/DEVELOPMENT.ipa ...
+------------------+-------------------------------+
|                   Lane Context                   |
+------------------+-------------------------------+
| ENVIRONMENT      | DEVELOPMENT                   |
| DEFAULT_PLATFORM | ios                           |
| PLATFORM_NAME    | ios                           |
| LANE_NAME        | ios uploadAppBuildArtifactory |
| BUILD_NUMBER     | 1                             |
| VERSION_NUMBER   | 0.4.0#150707909               |
+------------------+-------------------------------+
[20:33:01]: The Artifactory server responded with an HTTP Error 502: `<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>502 Bad Gateway</title>

Bad Gateway

The proxy server received an invalid
response from an upstream server.

'

+------+--------------------+-------------+
|            fastlane summary             |
+------+--------------------+-------------+
| Step | Action             | Time (in s) |
+------+--------------------+-------------+
| 1    | default_platform   | 0           |
| 2    | get_build_number   | 0           |
| 3    | get_version_number | 0           |
| 💥   | artifactory        | 1           |
+------+--------------------+-------------+

[20:33:01]: fastlane finished with errors

Environment

### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.148.1 | ✅ Up-To-Date  |

### Loaded fastlane plugins:

| Plugin                       | Version | Update-Status |
| ---------------------------- | ------- | ------------- |
| fastlane-plugin-versioning   | 0.4.3   | ✅ Up-To-Date  |
| fastlane-plugin-lizard       | 1.3.2   | ✅ Up-To-Date  |
| fastlane-plugin-trainer      | 0.4.1   | ✅ Up-To-Date  |
| fastlane-plugin-xcov_report  | 1.1.3   | ✅ Up-To-Date  |
| fastlane-plugin-xchtmlreport | 0.1.1   | ✅ Up-To-Date  |

Loaded gems

| Gem                          | Version      |
| ---------------------------- | ------------ |
| did_you_mean                 | 1.3.0        |
| slack-notifier               | 2.3.2        |
| rouge                        | 2.0.7        |
| xcpretty                     | 0.3.0        |
| terminal-notifier            | 2.0.0        |
| terminal-table               | 1.8.0        |
| plist                        | 3.5.0        |
| public_suffix                | 2.0.5        |
| addressable                  | 2.7.0        |
| multipart-post               | 2.0.0        |
| word_wrap                    | 1.0.0        |
| colored                      | 1.2          |
| highline                     | 1.7.10       |
| commander-fastlane           | 4.4.6        |
| unf                          | 0.1.4        |
| domain_name                  | 0.5.20190701 |
| http-cookie                  | 1.0.3        |
| faraday-cookie_jar           | 0.0.6        |
| fastimage                    | 2.1.7        |
| gh_inspector                 | 1.1.3        |
| multi_xml                    | 0.6.0        |
| rubyzip                      | 1.3.0        |
| security                     | 0.1.3        |
| xcpretty-travis-formatter    | 1.0.0        |
| dotenv                       | 2.7.5        |
| jwt                          | 2.1.0        |
| uber                         | 0.1.0        |
| declarative                  | 0.0.10       |
| declarative-option           | 0.1.0        |
| representable                | 3.0.4        |
| retriable                    | 3.1.2        |
| mini_mime                    | 1.0.2        |
| httpclient                   | 2.8.3        |
| google-api-client            | 0.38.0       |
| emoji_regex                  | 1.0.1        |
| jmespath                     | 1.4.0        |
| aws-partitions               | 1.320.0      |
| aws-eventstream              | 1.1.0        |
| aws-sigv4                    | 1.1.3        |
| aws-sdk-core                 | 3.96.1       |
| aws-sdk-kms                  | 1.31.0       |
| aws-sdk-s3                   | 1.66.0       |
| nanaimo                      | 0.2.6        |
| colored2                     | 3.1.2        |
| claide                       | 1.0.3        |
| CFPropertyList               | 3.0.2        |
| atomos                       | 0.1.3        |
| xcodeproj                    | 1.16.0       |
| unicode-display_width        | 1.7.0        |
| tty-screen                   | 0.7.1        |
| tty-cursor                   | 0.7.1        |
| tty-spinner                  | 0.9.3        |
| babosa                       | 1.0.3        |
| excon                        | 0.73.0       |
| faraday                      | 1.0.1        |
| unf_ext                      | <IP_ADDRESS>      |
| faraday_middleware           | 1.0.0        |
| json                         | 2.3.0        |
| mini_magick                  | 4.10.1       |
| bundler                      | 2.1.4        |
| naturally                    | 2.2.0        |
| simctl                       | 1.6.8        |
| multi_json                   | 1.14.1       |
| signet                       | 0.14.0       |
| os                           | 1.1.0        |
| memoist                      | 0.16.2       |
| googleauth                   | 0.12.0       |
| digest-crc                   | 0.5.1        |
| google-cloud-errors          | 1.0.0        |
| google-cloud-env             | 1.3.1        |
| google-cloud-core            | 1.5.0        |
| google-cloud-storage         | 1.26.1       |
| forwardable                  | 1.2.0        |
| logger                       | 1.3.0        |
| stringio                     | 0.0.2        |
| ipaddr                       | 1.2.2        |
| openssl                      | 2.1.2        |
| ostruct                      | 0.1.0        |
| strscan                      | 1.0.0        |
| date                         | 2.0.0        |
| fileutils                    | 1.1.0        |
| etc                          | 1.0.1        |
| io-console                   | 0.4.7        |
| zlib                         | 1.0.0        |
| mini_portile2                | 2.4.0        |
| nokogiri                     | 1.10.9       |
| rexml                        | 3.1.9        |
| psych                        | 3.1.0        |
| mutex_m                      | 0.1.0        |
| webrick                      | 1.4.2        |
| fastlane-plugin-versioning   | 0.4.3        |
| fastlane-plugin-lizard       | 1.3.2        |
| fastlane-plugin-trainer      | 0.4.1        |
| fastlane-plugin-xcov_report  | 1.1.3        |
| fastlane-plugin-xchtmlreport | 0.1.1        |

That sounds like a problem on their side, doesn't it?

@janpio I think the issue was with the special characters in the version.
Example: 1.0.0#123456 did not work but <IP_ADDRESS>456 did work

Interesting, that could either mean their API can not handle that or we/Fastlane need to encode that somehow.

The problem is if the path has # it doesn't like


Fix automation to update experimental json files in GitHub action

PR Summary
Create a GitHub action to run daily and create PR for updating json files for experimental features
PR Context

PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

for generating powershell.config.json

Why do we generate the file at all? If I understand correctly we need to explicitly turn on all experimental features in preview builds and turn off (that is default) all experimental features in release builds.
To implement this we have no needs so complicate and could implement the logic in C# code because PowerShell know whether it is preview or release version (see $PSVersionTable.PSVersion.PreReleaseLabel).
if "ExperimentalFeatures" presents in config file than process it
else if Release version than disable all experimental features
else it is preview version and we enable all all experimental features

I think @iSazonov has a good point. If we enforce this in code, then there is no need to manipulate the JSON files in our build.

There is no harm to use the pre-populated experimental feature list for now. If the code change is done in future, we can easily move away from it.

I also like the idea from @iSazonov for PS to make the decision to enable / disable. We could do that as followup. This work will unblock the issues on alpine for next preview.


Does this work with 2017 now?

If so, how to install it?

I'm wondering this too

Downloading and installing v1.5 from https://github.com/mjsabby/RoslynClrHeapAllocationAnalyzer/releases is working for me on VS 2017 (15.5)

I think this project is dead?

1.5 appears to work. This projects shouldn't really die as there is no free alternative (Resharper is the only alternative solution) and is quite fundamental for a coder who values optimizations.

+1

it has been confirmed that it still in progress by the author. Now I need https://github.com/segrived/Msiler view back as well!

@sebas77 where do you see it's still in progress by the author(s)?

He tweeted it https://twitter.com/mjsabby/status/944297432149508096
On Wed, 27 Dec 2017, 14:13 Blake Niemyjski<EMAIL_ADDRESS>wrote:

@sebas77 https://github.com/sebas77 where do you see it's still in
progress by the author(s)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/RoslynClrHeapAllocationAnalyzer/issues/33#issuecomment-354119548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5s49ngD-u7LEkntUp51o3F7aS4ZPGtks5tElCGgaJpZM4QzRna
.

Sorry for the lack of progress here, we're trying to find a team that can own this so we can make it better. But for now I'm going to power through and get an update out with fixes that have gone through.

@mjsabby i'm not a Roslyn expert yet, but as @jlennox i could help in my spare time, let me know.

Hey all, just wondering how the latest work has been going. Anyone have any updates on when to expect a new version? Nuget package is over 2 years old now :(

@phillijw I've considered making a fork of this project but I'm not sure what needs to be fixed. What are the main issues you're facing, or features you feel are missing?

I think what's missing, without which some of us cannot even use the product, is the fact that such a product assumes that you want to know about heap allocations all the time in every piece of code.
That is not the case.      Heap allocation is a normal thing in C#, so flagging it is kinda useless unless it's being allocated in an area of code that you care about.
What you want is to mark certain methods with an attribute and only check for heap allocations in those methods, and in those cases, actually mark the code with an error instead of a warning, so people don't ignore it.
Or, the attribute should indicate a count, the number of times allocations are expected to occur, and if the code is modified such that new allocations will occur, then it will trigger.   That way if you have code with a hot-spot that's taking say 50 allocations, and you work through to minimize it down to say 5, but that's all that you can do..  there's no way to reduce it further, or you are satisfied with the number, then you should be able to say "5 is the minimum for this method", and do so by indicating it in an attribute parameter above the method that this tool will check for.

@ArtGangsta I like those thoughts. No promises as I'm low on free time, but I'll keep this on my mental back burner and poke at it some weekend.

@ArtGangsta There is a working version in my fork for rougly what you want, here. It is tracked by the issue #7 in this repo, but is dependent on two other pull requests being accepted.
As I have not found any fitting attribute in class libraries, I think that the attribute needs to be configurable in some way. The alternative is that we create a new package with just the attribute which can then be referenced by the projects that needs it.
The branch does currently not solve the "count-allowed-per-method", but I think that could be quite trivial to solve.

@edespong I imagined it would be handled with a pragma or pragma-like comment (which is something Resharper does).
Example of a Resharper "pragma-like" hanging out with pragmas:
#pragma warning disable IDE0007 // Use implicit type
#pragma warning disable IDE1006 // Naming Styles
// ReSharper disable once CheckNamespace

Some thoughts:
Syntax to disable/enable checking in a file:
// AllocationAnalyzer disable
// AllocationAnalyzer enable

Syntax to set/remove a limit between two points:
// AllocationAnalyzer limit 10
// AllocationAnalyzer limit disable

I'm not sure how easy it would be to associate your current analysis between two comments.

I was thinking of combining a few things:

Have settings in VS for the developer experience
Provide code-level hints as alluded to in #7

For 2. I have the following idea:
    using System;

    [AttributeUsage(AttributeTargets.Constructor | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Field, AllowMultiple = true, Inherited = false)]
    public class PerformanceContractAttribute : Attribute
    {
        public DiagnosticType Diagnostic { get; set; }

        public AllocationKind AllowedAllocations { get; set; }
    }

    public enum DiagnosticType
    {
        Warning,
        Error,
        Notify
    }

    [Flags]
    public enum AllocationKind
    {
        None,
        Boxing,
        ImplicitArrayAllocation,
        Captures,
        Explicit,
        Enumerator,
        Delegate,
        All = Boxing | ImplicitArrayAllocation | Captures | Explicit | Enumerator | Delegate // useful when the analyzer setting is set to complain about everything and you still need an escape hatch
    }

    public class Foo
    {
        [PerformanceContract(AllowedAllocations = AllocationKind.Explicit | AllocationKind.Delegate)]
        public void RegularMethod()
        {
        }

        [PerformanceContract(AllowedAllocations = AllocationKind.None, Diagnostic = DiagnosticType.Error)]
        public void SuperHotMethod()
        {
        }

        [PerformanceContract(AllowedAllocations = AllocationKind.All)]
        public void InitializationOrStartupMethod()
        {
        }
    }

When coupled with @edespong's VS options feature we can basically let the user decide/override. However when an attribute on a method is present it could be used in VS AND in the build system as part of continuous integration.
So for example in a csproj, you would say:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <HeapAllocationAnalyzer>PerformanceContract</HeapAllocationAnalyzer>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="ClrHeapAllocationAnalyzer" / Version="1.*" />
  </ItemGroup>

</Project>

What do you all think?

I like the principle of your proposal, msjabby, better than jlennox's. It also solves one of my main issues with just having it in the options, and that is the ability to configure for use in a CI pipeline.
I do, however, think that there is a value in jlennox point about having an accepted baseline of x allocations, which could either be solved by an int on PerformanceContractAttribute, making it very explicit with an int for every allocation kind, or possibly some other way.
An alternative could be to not do anything and force the user to explicitly ignore all known allocations.
I do not know if it is desirable to be able to specify Diagnostic per AllocationKind, something that is not considered above, but I do not think that it is a dealbreaker.
I think that most of the code needed for the proposal is already scattered around a number of branches in my fork, so it should be relatively easy to get a working proposal up and running. If no one else grabs this, I will take a stab when I get back to a proper development environment in middle August.


DOC: Import Error while creating SelfQueryRetriever

Issue with current documentation:
Import Error while creating SelfQueryRetriever
retriever = SelfQueryRetriever.from_llm(     llm,     vectordb,     document_content_description,     metadata_field_info,     verbose=True)
The documentation mentions it requires lark but doesn't explicitly mention its version. I am getting an import error.

Idea or request for content:
The documentation should mention specifically that lark version greater then 1.1.5 is required.
pip install lark==1.1.5

But this also didn't solve the issue.

@dosu I'm having the same issue. Is there another issue in this repository that relates to this one? Or could tag a maintainer to bring this to their attention?
Thank you.

I had the same issue. I got the same import Error. I got this error with the latest version of lark 1.2.2. I resolved it by downgrading the version to 1.1.5.
I anyone could solve it with an alternative solution, please let the community know.


[Bug]: UI Inconsistent when navigating away from a failed post action with optimistic UI

Which Remix packages are impacted?

[X] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
v1
Steps to Reproduce

Create a component which posts some data from a form.
Add optimistic UI to that route so that the posted data is shown while the submission is in progress.
Throttle your network connection so that the response from the server is slow enough to continue.
Ensure that your server throws an error, or that the request in some way fails to update properly.
Submit the data, then navigate away from the route before the request completes.

Expected Behavior
The fact that the request failed should be clear to the end user, or the developer (depending on the implementation of the fix).
Actual Behavior
Not entirely sure, the route appears to alternate between the pre-optimistic UI version of the posting route / component, and the route that you've navigated to. @kentcdodds  may be able to elaborate a bit more, as this was done on his livestream.

Thanks for opening the issue @JoshuaPhillips!
I wouldn't call this one a bug (so I changed it to enhancement) because everything is working as designed. In any app in the world with or without optimistic UI the user can fire off the mutation and close their browser and they'll never know something went wrong. I'm not sure whether we can do anything about this in particular, but maybe the team will have an idea of how we could give you the right primitives to redirect the user back to the failed page (if those primitives don't exist). The UX I'm thinking is:

User submits invalid form
User navigates away before the action returns errors
Action returns errors
User is redirected from wherever they are to the form with the errors

I'm not sure whether Remix currently exposes the things you'd need to build this kind of user experience, so I'm going to assign this one to @ryanflorence to give it a look.

With no context of the underlying implementation, I think it would be ideal to bubble up an error to the nearest loaded CatchBoundary or ErrorBoundary.
so in the example from the livestream, behavior would be:

User: submits POST form to /jokes/new
User: Navigates to /jokes/{other_joke_id}
Remix: can't raise error in /routes/jokes/new.tsx CatchBoundary (or ErrorBoundary)
Remix: keeps going up the chain of CatchBoundaries similar to if it was never defined, so it would go to /routes/jokes/index.tsx CatchBoundary, /routes/index.tsx, or  /root.tsx`, depending on where user navigated to


Is MultiDataset a complete replacement for torch.utils.data.DataLoader?

When using webdataset with pytorch-lightning, I discovered that if I pass dataloaders to pytorch-lightning as instances of MultiDataset, training will stall on epoch 0. Once I changed the dataloaders to be instances of torch.utils.data.DataLoader instead, the pytorch-lightning trainer behaved as expected.
Is MultiDataset supposed to completely replace torch.utils.data.DataLoader? If so, is there a way to make it work with pytorch-lightning?

The DataLoader class is complex and has some problems, in particular when it comes to working with IterableDatasets. MultiDataset is an experimental class showing what DataLoader might be replaced with in the future.
Among other differences, MultiDataset handles splitting of samples among workers differently from DataLoader, and it also handles determining dataset length differently.
So, for now, you want to use DataLoader if your training framework requires it, but you will have to deal with the limitations in DataLoader for IterableDataset. On the other hand, MultiDataset is a good choice in containers (since it doesn't use shared memory) or if you want a simpler way of controlling the assignment of shards to processes.

Thanks for the explanation. That makes sense - So Multidataset is not currently intended to be a fully compatible drop-in replacement for torch.utils.data.DataLoader, but it rather provides an alternative that gets around the limitations of torch.utils.data.DataLoader.

Yes, they have different use cases. There is a strong desire to refactor DataLoader as well, but we have to take this one step at a time.
Another alternative to either DataLoader or MultiDatset that's in development is Tensorcom, which runs data loaders as explicit, separate processes, simplifying debugging and scaling; Tensorcom also supports RDMA and GPUdirect for very large scale, high performance training.


I can't download background

Hello
I can't download the background due to a missing button.
Browser google chrome 78.0.3904.97 version Windows 10

Hello
I can't download the background due to a missing button.
Browser google chrome 78.0.3904.97 version Windows 10

?? Please elaborate

There is no "Download zip" option

PEBCAK.


Importing Stackblitz Project - Keeps failing

Describe the bug
Importing Stackblitz Project
sb1-fvmzho
Unexpected token 'U', "Unexpected"... is not valid JSON
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-fvmzho
Steps to reproduce
Access the link and bolt.new is trying to import the project from stackblitz, but it keeps failing.
Expected behavior
It should be imported.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 123132584,
  "usedJSHeapSize": 109590044,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = smartguyio
Chat ID = 1dc0b3d8fa2c

Additional context
Importing Stackblitz Project
sb1-fvmzho
Unexpected token 'U', "Unexpected"... is not valid JSON

@smartguyio Thanks for the report and apologies for the frustrating experience! The fix is explained in #1471


Bug in footer section

unnecessary word displayed in footer of gallery section which needs to me removed.
Please assign me this bug under GSSOC'23 contribution.

I want to work on this issue ,kindly assign this issue to me under GSSoC'23.


dtail: init at 4.0.0

Description of changes
A distribuited tool for tailing, grepping and catting logs
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thanks @sikmir  for the suggestions :D
I've also disabled tests because there are some issues about ACL tests..

Result of nixpkgs-review pr 164152 run on x86_64-linux 1

1 package failed to build:

dtail

Thanks @sikmir for the suggestions :D I've also disabled tests because there are some issues about ACL tests..

Would be good if you could add a comment on why you have to disable the tests

@onny
Well there are some problems with the unit tests:
error: build of '/nix/store/rjlyyi2rxliz6kz316mnnanvxdhk6vp6-dtail-4.0.0.drv' on 'ssh://builder' failed: builder for '/nix/store/rjlyyi2rxliz6kz316mnnanvxdhk6vp6-dtail-4.0.0.drv' failed with exit code 1
error: builder for '/nix/store/rjlyyi2rxliz6kz316mnnanvxdhk6vp6-dtail-4.0.0.drv' failed with exit code 1;
       last 10 log lines:
       >     permission_test.go:84: Didn't expect permissions to read file!
       >     permission_test.go:88: /usr/bin/setfacl -m m::r-- /tmp/acltest -> fork/exec /usr/bin/setfacl: no such file or directory
       >     permission_test.go:94: /usr/bin/setfacl -b -m u::---,g:nixbld:r--,o::--- /tmp/acltest -> fork/exec /usr/bin/setfacl: no such file or directory
       >     permission_test.go:103: /usr/bin/setfacl -b -m u::---,g::---,o::--- /tmp/acltest -> fork/exec /usr/bin/setfacl: no such file or directory
       >     permission_test.go:107: /usr/bin/setfacl -m m::r-- /tmp/acltest -> fork/exec /usr/bin/setfacl: no such file or directory
       >     permission_test.go:110: Didn't expect permissions to read file!
       > --- FAIL: TestLinuxACL (0.00s)
       > FAIL
       > FAIL    github.com/mimecast/dtail/internal/io/fs/permissions    0.006s
       > FAIL
       For full logs, run 'nix log /nix/store/rjlyyi2rxliz6kz316mnnanvxdhk6vp6-dtail-4.0.0.drv'.

TestLinuxACL

Can we disable the specific failing test for example by deleting it in preCheck or something similar?

Result of nixpkgs-review pr 164152 run on x86_64-linux 1

1 package failed to build:

dtail


Added Game Tech Memory Block

PR Description 📜
Added Tech Memory Block Game
Fixes #4736

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you @somilyadav7 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

/assign

Please review @kunjgit @ishita-43

Thank you  @somilyadav7 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


[Bug]: [aforce] Memory leak issue in Appsmith's database integration causing website downtime.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
slack link
Steps To Reproduce
no clear reproduction steps
Public Sample App
No response
Environment
Production
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
Self hosted

The root cause of this issue is still unknown as we tried reproducing this issue by:

Creating MariaDB instance on AWS RDS and creating appsmith app that has multiple pages with multiple onload queries, observed memory usage on AWS dashboard, nothing suspicious when using the application, only thing observed was active memory trend was increasing even if the application was not in use, but this did not stop the app in any way or caused any lag.

For now, we have also raised a couple of questions with the user to understand their environment, awaiting user response to take further actions.

Memory leak happens in our prod app (this github issue is the result of my communication with support). Let me know if there is any additional information we can provide to troubleshoot.

we are not able to prioritise this issue immediately because of other higher priorities. Will post updates here.

@okletsov Thank you so much for your patience.
I have gone through the code to understand the potential causes of connections not being released and eventually causing memory leak, I wanted to understand the nature of datasources and queries you have in your application that are running on page load.
My hunch right now is that you may have multiple datasources (connecting to same db) having queries on page load, this can cause creation of multiple connection pools to same database and end up exhausting connections on that database. Hence If you can let me know if the 11 queries that running page load, do they belong to same datasource or they belong to different datasources (connecting to same db)?
Further more, I am creating action item here to add more logs to observe the nature of connection pool to understand active connections, connection pool size etc

Hello sneha,
I will have a chance to jump on it today. I believe we have one data source
(in appsmith interface). Can send you some screenshots later today.
Thank you,
Oleksii Kletsov
On Wed, Jul 24, 2024, 6:59 AM sneha122 @.***> wrote:

@okletsov https://github.com/okletsov Thank you so much for your
patience.
I have gone through the code to understand the potential causes of
connections not being released and eventually causing memory leak, I wanted
to understand the nature of datasources and queries you have in your
application that are running on page load.
My hunch right now is that you may have multiple datasources (connecting
to same db) having queries on page load, this can cause creation of
multiple connection pools to same database and end up exhausting
connections on that database. Hence If you can let me know if the 11
queries that running page load, do they belong to same datasource or they
belong to different datasources (connecting to same db)?
Further more, I am creating action item here
https://github.com/appsmithorg/appsmith/issues/35158 to add more logs
to observe the nature of connection pool to understand active connections,
connection pool size etc
—
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/34028#issuecomment-2247609356,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLX4ZAVBN3HZGLUPHSO4VTZN6CIJAVCNFSM6AAAAABI4OWC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGYYDSMZVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi Snrha,
Please see the datasource configuration attached.
The queries themselves are simple "select * from tableName" queries.
"tableName" for many of them is the View created on the DB server.
[image: image.png]
Thanks,
Oleksii Kletsov
On Sat, Jul 27, 2024 at 8:50 AM Oleksii Kletsov @.***>
wrote:

Hello sneha,
I will have a chance to jump on it today. I believe we have one data
source (in appsmith interface). Can send you some screenshots later today.
Thank you,
Oleksii Kletsov
On Wed, Jul 24, 2024, 6:59 AM sneha122 @.***> wrote:

@okletsov https://github.com/okletsov Thank you so much for your
patience.
I have gone through the code to understand the potential causes of
connections not being released and eventually causing memory leak, I wanted
to understand the nature of datasources and queries you have in your
application that are running on page load.
My hunch right now is that you may have multiple datasources (connecting
to same db) having queries on page load, this can cause creation of
multiple connection pools to same database and end up exhausting
connections on that database. Hence If you can let me know if the 11
queries that running page load, do they belong to same datasource or they
belong to different datasources (connecting to same db)?
Further more, I am creating action item here
https://github.com/appsmithorg/appsmith/issues/35158 to add more logs
to observe the nature of connection pool to understand active connections,
connection pool size etc
—
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/34028#issuecomment-2247609356,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLX4ZAVBN3HZGLUPHSO4VTZN6CIJAVCNFSM6AAAAABI4OWC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGYYDSMZVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello @okletsov
Thanks a lot for the information provided. Unfortunately, I am not able to see the image that you have attached, it would be great if you can schedule call using this link. This can quickly help us to analyse database connections.

Hi Sneha,
Done. Scheduled a call for Thursday. Talk to you then.
The screen shot was just trying to show the fact there is 1 data source in
our appsmith application. We can discuss more when we meet.
Thanks,
Oleksii Kletsov
On Mon, Jul 29, 2024 at 6:07 AM sneha122 @.***> wrote:

Hello @okletsov https://github.com/okletsov
Thanks a lot for the information provided. Unfortunately, I am not able to
see the image that you have attached, it would be great if you can schedule
call using this https://calendly.com/d/cktt-vjj-4gz/30min link. This
can quickly help us to analyse database connections.
—
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/34028#issuecomment-2255522748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLX4ZGSO5ELGUO7SFRJMQ3ZOYH5JAVCNFSM6AAAAABI4OWC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGUZDENZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello, appsmith team. Any updates on the issue? We are back to the busy season with this memory leak issue bringing our website down 2-3 times a week.

Hi @okletsov Thanks a lot for reaching out again! I deeply apologise that we haven't been able to follow up on this due to other priorities. If possible, could you please help us by sharing the application json (You can do this by exporting the app) with us and read only DB access as discussed in last call? You can share these details with us over email using<EMAIL_ADDRESS>For context on what we discussed during last call:

The application runs 11 queries on page load, based on views created in the MySQL database
When the queries run, Appsmith creates up to 5 connections to the DB, which get released after 5 mins (connection lifetime)
However, even after connections are released, the memory usage doesn't drop back to original levels
This leads to periodic reboots/restarts to free up memory when it reaches a set threshold
The issue seems specific to using Appsmith, as the application didn't face this issue earlier

Hello Sneha,
Couple clarifications/corrections:

we are using Mariadb (e.g. not MySQL)
Appsmith creates 55 (e.g. not 5) connections to the DB

Everything else is correct. I just sent the DB connection info as well as the app JSON to the email.

Thanks @okletsov Will update the details and check out the issue as well

@okletsov the fix for this issue has reached appsmith production (app.appsmith.com), can you please confirm if it is working for you?
cc: @rohan-arthur @pranavkanade @ame-appsmith @LagunaElectric

Hello Nilansh,
Unfortunately the fix didn't help. Memory consumption doesn't go down.
Thanks,
Oleksii Kletsov
On Thu, Oct 10, 2024 at 2:05 AM Nilansh Bansal @.***>
wrote:

@okletsov https://github.com/okletsov the fix for this issue has
reached appsmith production (app.appsmith.com), can you please confirm if
it is working for you?
cc: @rohan-arthur https://github.com/rohan-arthur @pranavkanade
https://github.com/pranavkanade @ame-appsmith
https://github.com/ame-appsmith @LagunaElectric
https://github.com/LagunaElectric
—
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/34028#issuecomment-2404112293,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLX4ZA7J75N776MRRIREHTZ2YKKZAVCNFSM6AAAAABI4OWC2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGEYTEMRZGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank You for the details @okletsov. I have reopened this issue to debug further.


Drop support for EOL Python 2.7

Fixes https://github.com/vimeo/vimeo.py/issues/140.
Example CI build: https://travis-ci.org/hugovk/vimeo.py/builds/566365592

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've signed the CLA, https://cla-assistant.io/vimeo/vimeo.py?pullRequest=147 shows me:

Thank you for testing!

@danimality @amrutadotorg I don't know if you have rights to merge PRs on this repo, but if you have: can we please get this merged? :open_hands:
https://pythonclock.org/

Title updated :)
Happy new year!

We use vimeo.py for checking duration for Vimeo videos and this version works perfectly for us.
LTGM

Thanks!


Subscribe after crash

Hello guys.
I have strange problem. I have simple textView (injected by ButterKnfie) and I have simple method subscribe like this:
 public void onPresenceChanged(final ChangeInPresenceEvent event) {
      getActivity().runOnUiThread(new Runnable() {
               @Override
               public void run() {
                        watchingIndicator.setText("How many");
               }
      });
 }

I recevied null pointer exeception for TextView. It look like app go crash but something post event and I received event in this method and it will try setText but watchingIndicator is null.

This is a usage problem, not an Otto bug. Sounds like you either need a null check or you need to unregister when the UI goes away (or defer registering until the UI is available).

If you have further problems, StackOverflow with the 'otto' tag is a much more appropriate place to ask usage questions. There's many more people there helping and it serves as an archive for future people searching for help.


[AKS] add ephemeral os functionality

Description

adds ephemeral os functionality for aks, port of https://github.com/Azure/azure-cli-extensions/pull/2344 from the extension
Testing Guide

samples included in PR
History Notes

[AKS] add ephemeral os functionality
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

AKS

last failure seems unrelated?

@arrownj seems like the ci agent is trying to use make on windows and failing?
File "setup.py", line 159, in run
      raise Exception("ERROR: The 'make' utility is missing from PATH")
  Exception: ERROR: The 'make' utility is missing from PATH

also looks like it's missing openssl?
this pr is code complete for me, just wanted to make sure you weren't waiting.

/azp run


chore: update typescript

Summary
https://devblogs.microsoft.com/typescript/announcing-typescript-4-6/

Test plan
Green CI

Hmm, for some reason this times out on mac - works on my mac 🙁


[Common][PyTorch] Fused apply_rotorary_pos_emb

This PR contains a fused apply_rotary_pos_emb implementation, which fuses the sin/cos calculation, the rotation, the elementwise multiplies, and the concats into one single kernel.
In addition, it supports writing the output tensor in a transposed layout to avoid the later .transpose(0, 1).contiguous(), i.e., the following line will do nothing but return. An example will be given later in MCore.
https://github.com/NVIDIA/TransformerEngine/blob/5debfdb356f6a6caaab070bd7e3f4052bb49df58/transformer_engine/pytorch/attention.py#L1282
And it also supports the thd format for sequence packing.

/te-ci

/te-ci

@timmoon10 Pushed a commit to address ci issues. Please trigger CI again.

/te-ci

Realized that test_fused_rope was not added into QA.
And it seems that the Jax/Paddle failures were not relevant to this PR? cc @timmoon10

/te-ci pytorch

/te-ci

@timmoon10 @sudhakarsingh27 Can I have another round of review? I merged PR #557 and checked via nsys that kernels are well fused for sbhd, bshd and thd formats.

/te-ci pytorch

/te-ci pytorch

I've made some changes so the outputs are contiguous in both the SBHD and BSHD cases. If there are no objections and no CI issues, I think this is good to go.

I intended to avoid the later x.transpose(0, 1).contiguous in FlashAttention. https://github.com/NVIDIA/TransformerEngine/blob/5debfdb356f6a6caaab070bd7e3f4052bb49df58/transformer_engine/pytorch/attention.py#L1282
But your changes are fine to me. We can use bshd format in this case.

Ah, I see the reasoning now. I'm unsure the best approach to handle the fact that Flash Attention expects BSHD tensors while the unfused backend and cuDNN fused attention expect SBHD. Pinging @cyanguwa. In any case, I'll merge this and we can optimize away the transpose in the future if needed.


git commands' aren't working?

On my Windows machine, at least, I see that the Alt+Ctrl+O copy command is partly working.  I end up getting output like the following, though:
/blob/C:/full/path/to/file.json#L3

If I modify this line to return the string "BANANA" instead of the variable stdout, I get this:
BANANA/blob/BANANAC:/Users/kevin/SLL/Validation/manifest.json#L19

So it's close, but not quite doing what it should be!  :sweat_smile:
Git is currently on my path like so:
C:\Users\kevin\SLL\Validation>where git
C:\Program Files\Git\cmd\git.exe

Not sure what the deal is.
That said, I like where you're going with this little plugin!  Very useful, @calebmeyer!!

Hey, thanks for the kind words. This is my first atom plugin.
Also, is your git repo initialized? More specifically, is there output to git config --get remote.origin.url?
The command runs three git commands, and it looks like we're not successfully capturing the output of any of them. One gets the origin url, one gets the commit hash, and one gets the absolute path to the root of your git directory. I use the absolute path to the root directory along with the absolute path to the file to get the relative path to the file ( manifest.json in your case).

Just a note, I'm also using windows, and also have git in that exact same location.

Okay, I was able to successfully reproduce this. The problem is that the git command is currently getting run wherever atom was started. If you use atom . and stay in that one project, everything works fine. If you remove the project/click the icon in your taskbar, I'm not actually sure where the git command is getting run. I'm going to do some testing so I can figure out how to have the proper working directory for git commands.

Example after adding in better error logging:

Good news. BufferedProcess passes along any options you send to Node's ChildProcess.spawn method, so I was able to set a current working directory for the git command.
I have no idea if it will work with submodules, but it should fix the issue you were seeing, @kevincantu.
Please note that I removed the default keybind and changed the command names slightly.

:beer:


Update named prop cache to use stl algorithm find_if

Plus get rid of new/delete of NamedPropCacheEntry.
You don't have to take this if you don't want :) - just thought I send you your first pull request.

I like the deleted functions and the .clear instead of my loop. But other than that, is there any benefit to the switch to find_if? Is it faster? The code doesn't appear to be any simpler - in fact it looks a bit more complex.
I would be interested in seeing g_lpNamedPropCache rewritten as a proper singleton (and maybe making a proper class of the cache instead of static functions laying about), or any work which could lead to eliminating ~NamedPropCacheEntry.

find_if isn't faster necessarily, it's just more expressive than a raw loop.  According to the lady who did the Beautiful STL algorithms course on PluralSight, "if you're writing a loop, you're doing something wrong." That is certainly more opinion than fact.


uninitialized constant ActionDispatch::RequestId on Rails 3.0.9

Hi, I am trying use this gem on my rails 3.0.9 rails project and a get this error:
``
/Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/request_store-1.0.7/lib/request_store/railtie.rb:4:in block in <class:Railtie>': uninitialized constant ActionDispatch::RequestId (NameError) 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/initializable.rb:25:in instance_exec'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/initializable.rb:25:in run' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/initializable.rb:50:in block in run_initializers'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/initializable.rb:49:in each' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/initializable.rb:49:in run_initializers'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/application.rb:134:in initialize!' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/application.rb:77:in method_missing'
from /Users/elf/tougg/orders/config/environment.rb:8:in <top (required)>' 	from /Users/elf/tougg/orders/config.ru:3:in block in '
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/builder.rb:46:in instance_eval' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/builder.rb:46:in initialize'
from /Users/elf/tougg/orders/config.ru:1:in new' 	from /Users/elf/tougg/orders/config.ru:1:in '
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/builder.rb:35:in eval' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/builder.rb:35:in parse_file'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/server.rb:162:in app' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/server.rb:253:in wrapped_app'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/rack-1.2.8/lib/rack/server.rb:204:in start' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/commands/server.rb:65:in start'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/commands.rb:30:in block in <top (required)>' 	from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/commands.rb:27:in tap'
from /Users/elf/.rvm/gems/ruby-1.9.3-p547/gems/railties-3.0.9/lib/rails/commands.rb:27:in <top (required)>' 	from script/rails:6:in require'
from script/rails:6:in `'```

Sorry, not supporting Rails 3.X.


[objc] Add support for NSString when mapping System.String

Right now strings are exposed as char* which is not ObjC friendly and requires quite a bit of code (and additional memory management).

PR #51 covers this


Client Crash with the Hoverlift

As I was writing the minor enhancement idea, my client crashed due to the Hoverlifts. I am using 1.19.2 Quilt, and 0.3.3 Oneironaut; and the modlist is the HexxyCraft++ pack. Here is the crashlog https://mclo.gs/PdfYrs9, and my testing area can be seen in the screenshots:

Was the crash while using the hoverlifts, or just them existing near you?

oops, didn't know that would automatically close this

So I couldn't reproduce the issue (I ran into a different issue when testing it, and didn't have a version that didn't already have the possible fix for this applied), but I was able to address the problem stated in the crash log. Hopefully fixed, not really sure.

I don't know what the player did to cause this, but this crash was reported by neruina: https://mclo.gs/HWVaM4t

I think that's a separate issue @candyCalc, the exception is different. I was about to report that separately since we keep having it on the server

This other bug has also been fixed in dev, but I haven't yet gotten around to putting out a release with the fixes for either of them


Slow responese on /assets/{asset}/addresses endpoint.

Problem Description
Querying  /assets/{asset}/addresses endpoint response time ranges form 7 to 35 seconds.
curl -w<EMAIL_ADDRESS>-o /dev/null -s "http://localhost:3000/assets/{$asset}/addresses"
     time_namelookup:  0.000014s
        time_connect:  0.032365s
     time_appconnect:  0.000000s
    time_pretransfer:  0.032393s
       time_redirect:  0.000000s
  time_starttransfer:  31.020171s
                     ----------
          time_total:  31.020421s

Environment
Hardware

Dedicated server
AMD ryzen 9 5950x
128gb ddr4 ecc
2x nmve ssd 3.4tb software RAID 1

Software

Debian 11.7
Docker version 23.0.5

Applications version

Cardano DB Sync <IP_ADDRESS>
Cardano Node 1.35.5
PostgresSQL 15.2
Blockfrost-backend-ryo 1.5.0

Applications specific settings

All running in docker.
Resource limits are in place
PostgresSQL is limited to 12 CPU and 64gb RAM
Blockfrost-backend-ryo is limited to 4 CPU and 8GB RAM
Cardano Node limited to 4 CPU 24gb RAM
Cardano DB Sync limited to 4 CPU 24gb RAM
PostgresSQL settings are:

shared_buffers = 16GB
effective_cache_size = 48GB
maintenance_work_mem = 2GB
checkpoint_completion_target = 0.9
wal_buffers = 16MB
default_statistics_target = 500
random_page_cost = 1.1
effective_io_concurrency = 200
work_mem = 2796kB
min_wal_size = 4GB
max_wal_size = 16GB
max_worker_processes = 12
max_parallel_workers_per_gather = 6
max_parallel_workers = 12
max_parallel_maintenance_workers = 4

Indices  mentioned in  README are added.

Troubleshooting steps taken

Directly executed query  form  source code  got same result.
Executed query using  EXPLAIN (ANALYZE, COSTS, VERBOSE, BUFFERS, FORMAT JSON) Can be viewed  here

Hi, thanks for the report!
Recent dbsync (13.1+) dropped some indices that affect our queries - you can (re)create these manually based on https://github.com/input-output-hk/cardano-db-sync/issues/1349#issuecomment-1416017488 and it should fix the sequential scan affecting this query.

Hello, thank you for your suggestion.
I created indices mentioned in linked comment. Somehow, it got worse. Now it can hover between 47 and 189 seconds.
Once again i executed query directly with EXPLAIN:

Worst case
Better case

in the meantime here some steps i took but without success:

Rebooting server
Running VACUUM ANALYZE and VACUUM
Running VACUUM FULL and  'REINDEX' on the tables involved in query.

This is almost certainly due to low resources for the database. The 64GB is the bare minimum, try to increase it and play with the postgresql settings, that query is on a pretty large dataset and is probably doing the best it can.
That being said, if you find a way to optimize it, a PR is most certainly welcome!

Hello, I actually did some additional testing.
@mmahut you where absolutely right about resource constrain.
It turns out asset used for testing indeed contains abnormally large amount addresses compared to other assets.
With other assets performance has increased dramatically, from 7sec to ~130ms.
Can I suggest adding those indices to README instructions? It could be a life-saver for some.
And about resource estimation it could come in useful to have recommanded hardware spec listed per component .
Thank you for your time.

Would it be possible to automate creation of these indexes on the Blockfrost side?

Would it be possible to automate creation of these indexes on the Blockfrost side?

Yes, that's a good idea. We should add it to blockfrost-bootstrap.


Is it possible to toggle cursor on all visual block selection?

First, thanks for the plugin, finally an awesome multi-cursor that actually works and does not freeze like other vim plugins do.
So, is it possible to add cursor to each line in a visual-block selection?
Expected behavior: start visual-block, select some lines (i.e, 5j), and then add invoke this plugin to add a cursor to each line, exiting the visual-block mode and entering the multi-cursor mode.

Yeah I can add a function for that, when I have time. You can also use a count in normal mode when adding a cursor up/down.


Added support for InSet predicate

Spark 1.1.1 introduced a new InSet expression which is generated by the optimizer for "IN" filters where the values are literals. This PR was originally made for Spark 1.1.1 but is valid for Spark 1.2 as well. I've tested this on both Spark 1.1.1 and Spark 1.2, using the most recent commits. I added a simple integration test to ensure the predicate is pushed down as part of the CassandraTableScan versus SparkSQL filter.

+1


ENH:force_ccw: generalized vectorized shapely.ops.orient; is_ccw: add fallback for GEOS < 3.7

Closes https://github.com/shapely/shapely/issues/1366
Closes https://github.com/shapely/shapely/issues/1684
Closes https://github.com/shapely/shapely/issues/1696 (mostly)

I'm wondering if I could generalize the decorator to work on any object type, not just on Geometry.
For this I need to replace isinstance(geoms, Geometry) in the decorators with a function like np.isscalar(geoms) but that works also for objects. np.isscalar returns False for Geometry or other objects. Any ideas ?

I'm wondering if I could generalize the decorator to work on any object type, not just on Geometry.

What would be the goal / use case of that?
In general, I am not sure if it is needed to already generalize this with a decorator, if we for now only have one place where we use this (and as long as we don't have plans to use it elsewhere as well).

Some other thoughts:

If we add a vectorized version, we should probably directly add this as a top-level function as well, to be consistent with all other vectorized functions.
If we add it as a new top-level function, we should discuss the naming, though. We are now using orient, but we generally try to follow the PostGIS naming (unless there is a good reason to deviate), in which case it would be something like force_ccw or force_polygon_ccw.
If we provide a vectorized version, it would be nice to directly do this as a fast function in C (ufunc.c). I think that should be doable (without anything being added to GEOS upstream) and could mimic what we have for force_2d (that is also a custom implementation on our side, and forcing (c)cw would actually be simpler). If you would be interested in looking at this as well, I am happy to give some more pointers.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 18 (77.78%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 87.038%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shapely/decorators.py
8
12
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2404

Relevant Lines:
2762

💛  - Coveralls

What would be the goal / use case of that?

No specific other use case at the moment, just thought it would be a cleaner solution.

In general, I am not sure if it is needed to already generalize this with a decorator, if we for now only have one place where we use this (and as long as we don't have plans to use it elsewhere as well).

I think that could be a nice, easy to implement vectorize method to other functions with a single geometry as the first argument. I could have used it for the old transform function, but ended up using something a bit more optimized for that use case.

If we add it as a new top-level function, we should discuss the naming, though. We are now using orient, but we generally try to follow the PostGIS naming (unless there is a good reason to deviate), in which case it would be something like force_ccw or force_polygon_ccw.

I don't have an opinion about the naming of the function. If you want to pick one I'd be happy to put as a top level function and put it also under the old name.module for backwards compatibility.

If you would be interested in looking at this as well, I am happy to give some more pointers.

Thanks! Unfortunately, currently I don't have the time to go into this.

Some other thoughts:

If we add a vectorized version, we should probably directly add this as a top-level function as well, to be consistent with all other vectorized functions.
If we add it as a new top-level function, we should discuss the naming, though. We are now using orient, but we generally try to follow the PostGIS naming (unless there is a good reason to deviate), in which case it would be something like force_ccw or force_polygon_ccw.

Done.
I could cleanup the commit history if you approve this.

I've further improved orient and force_ccw using added new functions reversed_conditioned and using is_ccw.
since reversed and is_ccw are only available with GEOS >= 3.7 and the original orient did not have a GEOS minimum version, I've added a fallback implementation to both reversed and is_ccw, now all the tests for these functions also pass with GEOS < 3.7.
The new orient/force_ccw also support LinearRing (before it retuned the geometry unchanged), thus the relevant test was updated.
If you approve these additions but require smaller PRs for review I could split this PR.

Thanks for further working on this!

since reversed and is_ccw are only available with GEOS >= 3.7 and the original orient did not have a GEOS minimum version, I've added a fallback implementation to both reversed and is_ccw, now all the tests for these functions also pass with GEOS < 3.7.

In general, I think we shouldn't bother too much with custom code to support such an old GEOS version. It's fine that some features just raise an error that the GEOS version is too old, and we are probably going to require GEOS 3.7 as a minimum version in the near future anyway (https://github.com/shapely/shapely/issues/1000)

I could cleanup the commit history if you approve this.

No need to clean up commit histories, we squash on merge anyway.

Thanks for further working on this!

Thanks for your review :)

since reversed and is_ccw are only available with GEOS >= 3.7 and the original orient did not have a GEOS minimum version, I've added a fallback implementation to both reversed and is_ccw, now all the tests for these functions also pass with GEOS < 3.7.

In general, I think we shouldn't bother too much with custom code to support such an old GEOS version. It's fine that some features just raise an error that the GEOS version is too old, and we are probably going to require GEOS 3.7 as a minimum version in the near future anyway (#1000)

OK, Would you suggest I'll remove the fallback implementations for reverse and is_ccw and mark force_ccw (and orient) for GEOS >= 3.7 ?
I think that till GEOS 3.7 is the minimum we could keep the reverse fallback/workaround and remove the weird is_ccw_impl workaround (I will make a separate PR, if you like this idea)

I could cleanup the commit history if you approve this.

No need to clean up commit histories, we squash on merge anyway.

Yes for simple PRs I agree that that's the way to go.
If the PR is a bit more complex and the commit history makes sense I'd advise to rebase and keep the history.

@jorisvandenbossche I think I've fixed everything as per your comments

@jorisvandenbossche @kylebarron @brendan-ward I think this is ready for review.

rebased to resolve conflicts with main

@jorisvandenbossche @kylebarron @brendan-ward
rebased to resolve conflicts with main
would you like to review?

@jorisvandenbossche any further thoughts about this PR?


[Fix] no-unused-modules: don't error out when running with flat config and an eslintrc isn't present

This change adjusts what we're doing if an error is thrown while attempting to enumerate lintable files in the no-used-modules rule, when users are running with flat config.  Now, if FileEnumerator throws due to a lack of eslintrc and the user is running with flat config, we catch the error and rethrow with a more informative message.
I also cleaned up the original aspects of the implementation that was using the proposed eslint context functions, since that proposal was walked back and the API was never introduced.
Note: This isn't an ideal state, since this rule still relies on the legacy api to understand what needs to be ignored.  Remaining tethered to the legacy config system is going to need to be solved at some point.
Fixes #3079

Addressed lint errors

Updated, based on feedback in #3079 to not attempt to avoid the error, but to instead rethrow with a more informative message.  I updated the PR description to reflect the new approach.

I suppose we could have a test make a temp dir (using tmp), copy an example into it, run npm install in it, and then invoke eslint inside it?

I suppose we could have a test make a temp dir (using tmp), copy an example into it, run npm install in it, and then invoke eslint inside it?

Added a test that does the following:

copies the v9 example folder
runs exec to install the plugin from cwd
run the lint command
catches the error and validates that the message includes our new verbiage

@ljharb I got this about where I want it, except for one question to you.  I added the test to the existing set of unit tests just because all the CI plumbing was already in place to add it there.  Though, it doesn't really feel right for it to be there, since it's more of an integration test.  Would you rather it be where I have it now, or add a new workflow to CI for doing this kind of integration testing?

I think that it's fine where it is to land this, but it might make sense to move it in a followup?

I think that it's fine where it is to land this, but it might make sense to move it in a followup?

Sounds good

… although i do see there's 2 uncovered lines in the diff

Do you mean the catch block?  If so, that's because the new test isn't really contributing to the coverage report, since it's building the plugin and running lint as a separate exec command.


Edit handler example not working for Leaflet.js 1.5.1

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.5.1
Leaflet Draw version I'm using: 1.0.3
Browser (with version) I'm using: Google Chrome Version 72.0.3626.121 (Official Build)
OS/Platform (with version) I'm using: Lubuntu 18.04
change leaflet.js include in the edit_handler example for version 1.0+ into using leaflet.js latest CDN link

What behaviour I'm expecting and which behaviour I'm seeing
When run, it encounter error
Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined
    at i.setStyle (leaflet.js:5)
    at i.addHooks (Edit.Poly.js:152)
    at Edit.Poly.js:42
    at i._eachVertexHandler (Edit.Poly.js:33)
    at i.addHooks (Edit.Poly.js:41)
    at i.<anonymous> (Edit.Poly.js:511)
    at i.fire (leaflet.js:5)
    at i._layerAdd (leaflet.js:5)
    at i.whenReady (leaflet.js:5)
    at i.addLayer (leaflet.js:5)

Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

<!DOCTYPE html>

	<title>Leaflet.draw vector editing handlers</title>

     <link rel="stylesheet"<EMAIL_ADDRESS>       integrity="sha512-xwE/Az9zrjBIphAcBb3F6JVqxf46+CDLwfLMHloNu6KEQCAWi6HcDUbeOfBIptF7tcCzusKFjFw2yuvEpDL9wQ=="
       crossorigin=""/>

i just having the same error similar conditions

I am having the same issue. I had to downgrade the Leaflet to 1.4.0 in order for the leaflet-draw  plugin to be worked without the error. It would be nice to see another workaround for this.

Seems that Leaflet has changed the logic in the Path.prototype.setStyle method (https://github.com/Leaflet/Leaflet/blob/master/src/layer/vector/Path.js#L108), so it causes the JavaScript error if you pass null or undefined in that method. Once I changed one line in the L.Edit.PolyVerticesEdit.addHooks method by this poly.setStyle(poly.options.editing || {}); and the same technique in L.Edit.SimpleShape.addHooks, the plugin was working as expected.

If you don't want to change the source files, you should enable edit mode this way
var polygon = new L.Polygon([
    [51.51, -0.1],
    [51.5, -0.06],
    [51.52, -0.03]
], {
    editing: {},
    original: {}
});

polygon.editing.enable();

map.addLayer(polygon);

var polyline = new L.Polyline([
    [51.50, -0.04],
    [51.49, -0.02],
    [51.51, 0],
    [51.52, -0.02]
], {
    editing: {},
    original: {}
});

polyline.editing.enable();

map.addLayer(polyline);

var circleMarker = L.circleMarker([51.50, -0.08], {
    editing: {},
    original: {}
});

circleMarker.editing.enable();

map.addLayer(circleMarker);

var circle = L.circle([51.53, -0.06], 600, {
    editing: {},
    original: {}
});

circle.editing.enable();

map.addLayer(circle);

var rectangle = L.rectangle([
    [51.49, -0.1],
    [51.48, -0.06]
], {
    editing: {},
    original: {}
});

rectangle.editing.enable();

var rectangle = L.rectangle([
    [51.49, -0.1],
    [51.48, -0.06]
], {
    editing: {},
    original: {}
});

rectangle.editing.enable();

Now everything works fine :)

Has anybody patched this and submitted a PR? I would like to use leaflet 1.5.1 so I need to patch leaflet draw 1.0.4 to work with it.

Have the same error, looks like Leaflet.draw repo died

I am having a similar problems, except with
shape.editing.disable()
Are the authors/contributors @jacobtoye @ddproxy still maintaining this? What are people planning to use instead? @destus90 @tinjaw

@joshkopecek I have got lots of things associated with Leaflet.Draw plugin. It now pains me to replace this. The best way for me to fork this plugin and maintain it by myself.

@destus90 I would have thought this project would be 'too big to fail'? There are 20k downloads per week recorded on npmjs, but no changes to the npm package in the last 9 months. Latest commit to the repo is 13/09/2018, which means there are some private commits sitting around somewhere for 1.0.4. @ddproxy is still active according to github - perhaps Leaflet.Draw needs a new maintainer? @jacobtoye

I don't want to see this rot. It is a good extension. I'd be willing to help on in any way I can.

@tinjaw @destus90 we're just a handful among many users for whom this is a critical tool.
@slurmalon @cimanzano seem to have been working on a more recent, popular fork here https://www.npmjs.com/package/@ceresimaging/leaflet-draw
but the core plugin really needs some love. It's certainly holding me back from updating to Leaflet > 1.3.0
Mapbox and Leaflet must have vested interests in this plugin. How can we generate some support?

sometimes shape.options.editing===undefine  , override L.Path.prototype.setStyle just check empty;
L.Path.prototype.setStyle = function (style) {     L.setOptions(this, style);     if (this._renderer) {         this._renderer._updateStyle(this);         if (this.options.stroke && typeof style === 'object' && style.hasOwnProperty('weight')) {             this._updateBounds();         }     }     return this; }; L.Circle.prototype.setStyle = function (style) {     L.setOptions(this, style);     if (this._renderer) {         this._renderer._updateStyle(this);         if (this.options.stroke && typeof style === 'object' && style.hasOwnProperty('weight')) {             this._updateBounds();         }     }     return this; };

@xxbld thanks for this, but overriding functions like that is not something I like doing. Seems very hacky.
I would prefer the Leaflet << ❤ solution

PLS forgive me @ddproxy for pinging you, but you seem to be the main maintainer of this code. Do you have time to work on this, or, if not, can you provide some guidance on what to fix and maybe one of us can work on it.

Solution by @destus90 really works!
https://github.com/Leaflet/Leaflet.draw/issues/943#issuecomment-503438437

With<EMAIL_ADDRESS>you don't need to enable editing mode with my comment above. They have changed setStyle method (https://github.com/Leaflet/Leaflet/pull/6728/files) so you can pass null to this method. Working demo can be found here https://stackblitz.com/edit/typescript-mzi9or?file=index.html

@destus90 is good example, but if you are using dynamic editing this it gonna help you:
map.on(L.Draw.Event.CREATED, (e) => {
    var type = e.layerType,
        layer = e.layer;

    layer.options.editing = {} // Line magic
    console.log(type, layer)
    drawnItems.addLayer(layer);
});


Use MessageId instead of Transaction_id for Rosetta Transaction Identifier

A Rosetta Transaction (https://www.rosetta-api.org/docs/models/Transaction.html) contains the field transaction_identifier.
Currently we populate this field with the bee_message::TransactionId.
Would it be possible to populate the field with the bee_message::MessageId?
Or would this have any bad implications?

Update: A disadvantage of using MessageId instead of TransactionId could be that if a constructed transaction (before it is confirmed) is replayed by an attacker, the message ID returned during construction/submit is invalid.

Since we can't return the MessageId for the above reason, I will close this issue.


chore(typo): fix typos in comment

Description
Fix typos in source code comments
This pull request is a part of #2841
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thank you for your reviews!
All changes were approved by code owners, but I cannot merge because I don't have write access.
Could you merge this pull request?

@soblin Thanks!!

@HansRobo Is this PR ready to merge?


Adding go template code to repo

Adding Prow and go template code to repo to start pushing to quay.io
Disabled make go-lint for now because of errors we got testing locally. Will reenable it after doing some troubleshooting with Ray.

/lgtm


Internal error, an invalid response was received from the ad server

Since yesterday this error occurs for me. I tried the proposed solutions from the issue #220 but I don't get it solved.
My code:
<AdMobBanner           adSize="mediumRectangle"           adUnitID="my ad unit id"           testDevices={[AdMobBanner.simulatorId]}           onAdFailedToLoad={error => console.error(error)}         />
The error:

Internal error, an invalid response was received from the ad server.
handleAdFailedToLoad
C:\Users\victo\Desktop\app1\node_modules\react-native-admob\RNAdMobBanner.js:45:59
proxiedMethod
C:\Users\victo\Desktop\app1\node_modules\react-proxy\modules\createPrototypeProxy.js:44:35
_invokeGuardedCallback
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:73:23
invokeGuardedCallback
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:47:40
invokeGuardedCallbackAndCatchFirstError
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:50:60
executeDispatch
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:125:132
executeDispatchesInOrder
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:130:283
executeDispatchesAndRelease
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3255:62
executeDispatchesAndReleaseTopLevel
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3259:43
forEachAccumulated
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3252:69
processEventQueue
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3309:147
runEventQueueInBatch
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3535:83
handleTopLevel
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3539:33

C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3560:55
batchedUpdates
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:2754:26
batchedUpdates
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:202:35
batchedUpdatesWithControlledComponents
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:209:34
_receiveRootNodeIDEvent
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3559:50
receiveEvent
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\Renderer\ReactNativeFiber-dev.js:3564:60
__callFunction
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:299:47

C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:111:26
__guard
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:262:6
callFunctionReturnFlushedQueue
C:\Users\victo\Desktop\app1\node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:110:17

Someone have a soluction for this? Thanks.

I'm tired of saying this, I have the same problem!

I still have the problem.

my problem is still going on, have you found a @victoorlucas solution?

I too have the same problem. Can someone please help us out?

Resolved when you approve the error on the AdMob homepage!

@hyorax can you please explain that in detail or provide a link?

1)Click Home page,

Your ad units are not displaying ads because you haven't provided your account payments information yet.

2)Click Fix It.
3)Click Select Payment,
4)And Submit.
Finish, solved for me!

I am glad you have finally solved the issue. However, there is no such warning on my account. Gotta find some other solution.

Glad that these solution worked for you @hyorax, but I still get the error.

Guys, Any fixes??

I created a new react native project and relinked the libraries. Everything worked after.

I am having the same problem @r0hit-gupta @victoorlucas did you find a solution?

@matheusrocha89 I created a new project from scratch. Installed admob and linked it. Then copy pasted the react code from my original project. I also created a new Ad Unit on Admob and used a real device to test the ads. Ads were not showing on the emulator for some reason.

I am trying on a real device and still getting this error on my console when I activate the debug mode on react native. When you were testing you used the release version or the test version of your app @r0hit-gupta ?

@hyorax After you confirm your informations took some time to start to work?

@r0hit-gupta after I confirm my informations took some minutes to start to work. Now The error is The ad request was successful, but no ad was returned due to lack of ad inventory. I guess I need to configure something on my AdMOB to put some ads on my inventory, I am not sure, I will make some research about that

@matheusrocha89 try changing the banner size.

I am using AdMobInterstitial don't have size.

@matheusrocha89 I suggest you wait for some more time. It usually takes some time for new ad units to show up.

I guess could be that too, BTW I will keep this issue updated If I have some success. Thanks for the help @r0hit-gupta

@matheusrocha89 I am also getting this error  "The ad request was successful, but no ad was returned due to lack of ad inventory.". How did you solve it?

I just waited a little bit so the afs started to appear, just that

Try this:
<AdMobBanner
     adSize="smartBannerPortrait"
     adUnitID="ca-app-pub-xxx/xxx"
     testDevices={[AdMobBanner.simulatorId]}
 />

I had the same issue with my app. first day I will try with my AdMob account its say "Internal error, an invalid response was received from the ad server." on next day try with run-android it's working fine for me. please wait for some time max 1 day after the create AdMob banner add after it's work.

thanks, guys, I waited for 1 day and now ads are showing for me.

thanks, guys. I waited for 1 day and now ads are showing for me.

I created the ad unit 1 week ago, still I got nothing. Any solution?

I have the same problem, I have created the ads for 3 days, and continue with the error.

Mine is already shown. Make sure your payment detail is filled. Admob will give you an email that your email has been verified but Admob wont tell you when your ads units are ready. You can check your ads unit on your test device

I have already set up my payment details when I created the account. On the homepage it appears that everything is right. But I keep getting the error.

Wai a little bit more, if everything is correct, you have all the requirements just wait and the ads will start to appear.


Update timescaledb to 2.13.0

TimescaleDB has released 2.13.0.  Getting started: https://docs.timescale.com/timescaledb/latest/getting-started
	 2. API reference documentation: https://docs.timescale.com/api/latest

Is this version backwards compatible with the current 2.10.1?

it seems that they have upgrade scripts: https://github.com/timescale/timescaledb/tree/main/sql/updates


Add javax.annotation as a dependency

Could not compile project without it locally (osx, oracle-jdk from homebrew)

Turned out it does not work with java11, and with the relevant version it probably compiles correctly. Feel free to decline, if that's the case.

We are cleaning up the JSR annotations in the core and other components: https://github.com/jenkinsci/jenkins/pull/4604 . I'd guess we will do the same for JFR, and then it won't  be a problem for Java 11 builds


Add support for StatefulSet and Headless service

@Akash-Nayak sir, can you please add the description to this issue?

Hello @KrishAryan, this feature has already been added to Move2Kube through https://github.com/konveyor/move2kube/pull/1088. So, I am closing this issue. I would encourage you to look at other open issues, and also please feel free to try out Move2Kube https://move2kube.konveyor.io/tutorials.


semantic bug when verifying certificate file

I found a potential semantic bug when verifying certificate file.
The results (exit status & output) are different between Libressl (3.1.0)  and openssl (commit 031c9bd3f3e9a02fa126c7dbc47f3d934678a195)
How to reproduce :
openssl x509 -in $PoC -text -noout
PoC
Here's log.
program : Libressl
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 0 (0x0)
    Signature Algorithm: md5WithRSAEncryption
        Issuer: C=CN, ST=PN, L=CN, O=ON, OU=UN, CN=Herong Yang
        Validity
            Not Before: Jul 15 21:19:47 2005 GMT
            Not After : Aug 14 21:19:47 2005 GMT
        Subject: C=CN, ST=PN, L=CN, O=ON, OU=UN, CN=Herong Yang
        Subject Public Key Info:
            Public Key Algorithm: 1.2.840.1136<IP_ADDRESS>
            Unable to load Public Key
140462724956608:error:06FFF09C:digital envelope routines:CRYPTO_internal:unsupported algorithm:evp/p_lib.c:245:
140462724956608:error:0BFFF06F:x509 certificate routines:CRYPTO_internal:unsupported algorithm:asn1/x_pubkey.c:197:
        X509v3 extensions:
            X509v3 Subject Key Identifier:
                55:C8:EF:49:2B:5D:E4:03:C5:98:1B:68:24:28:47:88:D4:0E:77:04
            X509v3 Authority Key Identifier:
                0v..U..I+].....h$(G...w..[.Y0W1.0...U....CN1.0...U....PN1.0...U....CN1.0...U.
..ON1.0...U....UN1.0...U....Herong Yang...
            X509v3 Basic Constraints:
                CA:TRUE
    Signature Algorithm: md5WithRSAEncryption
         3f:ba:0c:c1:ae:38:ca:f6:37:16:9c:35:5f:18:79:64:de:27:
         0d:46:ad:28:57:b4:62:df:6c:ff:f8:74:17:eb:b6:91:7e:06:
         6e:ec:a5:9d:23:e2:6e:5a:6e:c3:09:fa:cf:34:65:70:15:65:
         10:3a:6b:0f:b9:ef:6b:64:18:0e

exit status : 0

program : openssl (commit 031c9bd3f3e9a02fa126c7dbc47f3d934678a195)
unable to load certificate
40:B7:E2:82:0C:7F:00:00:error:asn1 encoding routines:c2i_ibuf:illegal zero content:crypto/asn1/a_int.c:154:
40:B7:E2:82:0C:7F:00:00:error:asn1 encoding routines:asn1_template_noexp_d2i:nested asn1 error:crypto/asn1/tasn_dec.c:629:Field=serialNumber, Type=X509_CINF
40:B7:E2:82:0C:7F:00:00:error:asn1 encoding routines:asn1_template_noexp_d2i:nested asn1 error:crypto/asn1/tasn_dec.c:629:Field=cert_info, Type=X509
40:B7:E2:82:0C:7F:00:00:error:PEM routines:PEM_ASN1_read_bio:ASN1 lib:crypto/pem/pem_oth.c:33:

exit status : 1

Environment :
Description: Ubuntu 18.04.1 LTS
Release: 18.04

md5WithRSAEncryption is that a joke?

Could you please add the certificate in question as a PEM format?

Sure. Here's the certificate.
-----BEGIN CERTIFICATE-----
MIICUTCCAfugAwIBAgKBADANBgkqhkiG9w0BAQQFADBXMQswCQYDVQQGEwJDTjEL
MAkGA1UECBMCUE4xCzAJBgNVBAcTAkNOMQswCQYDVQQKEwJPTjELMAkGA1UECxMC
VU4xFDASBgNVBAMTC0hlcm9uZyBZYW5nMB4XDTA1MDcxNTIxMTk0N1oXDTA1MDgx
NDIxMTk0N1owVzELMAkGA1UEBhMCQ04xCzAJBgNVBAgTAlBOMQswCQYDVQQHEwJD
TjELMAkGA1UEChMCT04xCzAJBgNVBAsTAlVOMRQwEgYDVQQDEwtIZXJvbmcgWWFu
ZzBcMA0GCSqGSIb3fQEBAQUAA0sAMEgCQJCp5hnG7ogBhtlynpOS21cBewKE/B7j
V14qey3lnr26xZUsSVko36ZnhiaO/zbMOoRcKK9vEcgMtcLFuQTWDN3RAgMBAAGj
gbEwga4wHQYDVR0OBBYEFFXI70krXeQDxZgbaCQoR4jUDncEMH8GA1UdIwR4MHaA
FFXI70krXeQDxZgbaCQoR4jUDncEoVukWTBXMQswCQYDVQQGEwJDTjELMAkGA1UE
CBMCUE4xCzAJBgNVBAcTAkNOMQswCQYDVQQKEwJPTjELMAkGA1UECxMCVU4xFDAF
BgNVBAMTC0hlcm9uZyBZYW5nggEAMAwGA1UdEwQFMAMBAf8wDQYJKoZIhvcNAQEE
BQADQQA/ugzBrjjK9jcWnDVfGHlk3icNRq0oV7Ri32z/+HQX67aRfgZu7KWdI+Ju
Wm7DCfrPNGVwFWUQOmsPue9rZBgO
-----END CERTIFICATE-----

I also uploaded the PEM file link on this issue.

I found a potential semantic bug when verifying certificate file.
The results (exit status & output) are different between Libressl (3.1.0) and openssl (commit 031c9bd)
How to reproduce :
openssl x509 -in $PoC -text -noout
PEM file

Thank you.

I never follow links from untrusted origin.

Is this a CA certificate ?
what is a public key algorithm of 1.2.840.1136<IP_ADDRESS> ?

Oh, even if it would be valid, you would need a time machine
and travel to these coordinates:                      ;-)
Validity
            Not Before: Jul 15 21:19:47 2005 GMT
            Not After : Aug 14 21:19:47 2005 GMT

In openssl-1.0.2t, the log is similar to Libressl.
Also, openssl-1.0.2t returns 0, but openssl (commit 031c9bd) returns 1.
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 0 (0x0)
    Signature Algorithm: md5WithRSAEncryption
        Issuer: C=CN, ST=PN, L=CN, O=ON, OU=UN, CN=Herong Yang
        Validity
            Not Before: Jul 15 21:19:47 2005 GMT
            Not After : Aug 14 21:19:47 2005 GMT
        Subject: C=CN, ST=PN, L=CN, O=ON, OU=UN, CN=Herong Yang
        Subject Public Key Info:
            Public Key Algorithm: 1.2.840.1136<IP_ADDRESS>
            Unable to load Public Key
139678236051136:error:0609E09C:digital envelope routines:PKEY_SET_TYPE:unsupported algorithm:p_lib.c:239:
139678236051136:error:0B07706F:x509 certificate routines:X509_PUBKEY_get:unsupported algorithm:x_pubkey.c:148:
        X509v3 extensions:
            X509v3 Subject Key Identifier:
                55:C8:EF:49:2B:5D:E4:03:C5:98:1B:68:24:28:47:88:D4:0E:77:04
            X509v3 Authority Key Identifier:
                0v..U..I+].....h$(G...w..[.Y0W1.0...U....CN1.0...U....PN1.0...U....CN1.0...U.
..ON1.0...U....UN1.0...U....Herong Yang...
            X509v3 Basic Constraints:
                CA:TRUE
    Signature Algorithm: md5WithRSAEncryption
         3f:ba:0c:c1:ae:38:ca:f6:37:16:9c:35:5f:18:79:64:de:27:
         0d:46:ad:28:57:b4:62:df:6c:ff:f8:74:17:eb:b6:91:7e:06:
         6e:ec:a5:9d:23:e2:6e:5a:6e:c3:09:fa:cf:34:65:70:15:65:
         10:3a:6b:0f:b9:ef:6b:64:18:0e

It seems that newer OpenSSL versions dislike a zero for serialNumber.  I don't know why that change was made...  but also, the CA that generated this certificate is non-conforming.  Here's what RFC 5280 has to say on the matter (from https://tools.ietf.org/html/rfc5280#section-<IP_ADDRESS>):

Note: Non-conforming CAs may issue certificates with serial numbers
that are negative or zero.  Certificate users SHOULD be prepared to
gracefully handle such certificates.


[Map] Pins don't cluster where there's only one LOI in a cluster

Instead the pin is shown unclustered at all zoom levels
@jcqli For triage

Can't repro

Tested with polygons only, need to test with pins


Changed the settings file name to settings-emails. Fix #609

This PR fixes the issue #609

thanks!


Dataset cannot be found

Hi, I was trying to use this project as a part of my university project. Unfortunately, I can't find the dataset. Can you help me with that?
I have a really limited time, I would really appreciate it if you can help me ASAP.

Hi, I mailed the people who made it and they said it is no longer available.

Hi, I mailed the people who made it and they said it is no longer available.

Oh ok, Thanks for your response, So I'm closing this issue.