More SILGen Helper Routines

This PR contains some fixes and some additional SILGen helper routines that I am going to use in subsequent commits.
Specifically:

c6b32ae: In this commit, I add APIs to SILGenFunction for creating managed buffers/rvalues whose lifetimes are tied to FormalEvaluationScopes instead of normal scopes. I need this to eliminate the +0 self cleanup hack.
bdb4195: I am standardizing on the name Formal Access for the values that are managed by a Formal Evaluation Scope. This is just a simple rename of the ManagedValue::formalEvaluationBorrow to match that since I am about to create a ManagedValue::formalAccessCopy as well.
0ae6c25: This makes SILGenBuilder::createCopyValue a complete replacement for SILGenFunction::emitManagedRetain except taking a ManagedValue. This is part of my attempts to create ownership endowed APIs that traffic in ManagedValues and just /do the right thing/ in terms of ownership.
6b05692: ManagedValue::copy made some incorrect assumptions around cleanups and triviality. This commit fixes those issues and rewrites parts of ManagedValue::copy() to use SILGenBuilder::createCopyValue().
5717eeb: This creates a new managed value API called ManagedValue::formalAccessCopy that performs the same operation as ManagedValue::copy, except using formalAccess methods to limit the lifetime of the ManagedValue to Formal Evaluation Scopes.

rdar://29791263

@swift-ci Please smoke test and merge


Allow users to select if they want to install the app for only one user or for all users

This should eliminate the need to keep the enterprise installer.
On update we can check the registry key to see what option was selected at first install.

Will be handled with #2955


Stanley added in aboutus

Coverage remained the same at 92.159% when pulling f9fd52df8505ddca50874bd3c1bc9a3b50d52e0c on stan789:stanley into e36caa9e906341b78c644b849a7bb8aa3c131057 on CS2103-AY1718S1-T17-B4:master.


Maven?

Hello, when will the play2.4 branch pushed to maven?

+1

There is a link in the doc "io.swagger" %% "swagger-play2" % "1.5.0", but this repo does not exist. Can you create it on maven and push the most recent (play 2.4 compatiple) version?

Hi, please use the 1.5.0-SNAPSHOT in sonatype snapshots for now

@fehguy is there any reason we don't push it to the releases repo? is there something else we need to do first?

Just wanted to get some miles on it first. Maybe we hold a day and push tomorrow?

There are a few PRs pending that'd be nice to get in. Other than that, I'm fine with releasing whenever you are

@benmccann @fehguy I think we'd be good to a new release now?

Yes, I believe so.  Just released 1.5.0 to maven central.


[Bug] TLS config missing from LOKI

Hi @petewall
I made a PR to add tls config to loki block https://github.com/grafana/k8s-monitoring-helm/pull/893 but
things are moving too fast I can't afford to spend time conflict merging, it would be simpler to juste copy past the missing block and pass it with a fix.
most project I work on are using remote cluster for logs so I think this bug should be on your resolved asap
Regards,

Dupe of #909


Unable to send from client.

I received coin i sent to the client, its fully synced and has connections, but every time i try sending coin out says  "Error transaction creation failed" if i do sendtoaddress from debug window I get "Error: Transaction creation failed (code -4)"
if i do validateaddress from debug to the address it says
{"isvalid" : true,"address" : "addressremoved","ismine" : false,"account" : "1"}

is your wallet locked/encrypted?

unlocked and not encrypted

can u try sending .5 to see if it does the same thing? this might be a leftover dust issue.

ahah, alright that did it! thank you!


removed duplicate declaration of csp_buffer_init(), fixed typos, ran …

…clang-format on whole file

Hi,
Thanks for the PR.  But please do not squash logical changes in one commit.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes
Here is some guidelines:
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
gitlint might help
https://github.com/jorisroovers/gitlint

FYI:

#516

Thanks @yashi , shall I open new PRs and close this one?

You don't have to close this PR.  What you have to do is to split the commit to three, and push it here.

Thanks!


Trigger rate stacked files

This PR is a follow-up of #801. It expands the tool with a new functionality (which was partially implemented before): stack files. It is now possible to pass a text file with a list of simtel files and stack the histograms together before estimating the trigger rate. This is especially useful when we have many simulation results in separate files but we are interested in increase the event statistics of the trigger rate estimates.

Thanks for the quick feedback @GernotMaier. I merged main and if tests pass I will merge.


Mockup of Release 3 Additional Features: QR Scanner

A subtask of #31.

Closing as task is completed -- image is placed in wiki.


No signature of method: myController.mutipart() is applicable for argument types: (java.lang.Boolean) values: [true]

Hi, I'm trying version 2.0.0 and Grails 3.3.1.
Using this code in myController I get the error in the subject:
mailService.sendMail {
   mutipart true
   to 'address'
   cc 'anotherAddress'
   subject 'Subject'
   html 'content'
   attach pdf.name, "application/pdf", pdf
}

Please help. Thank you very much in advance.

Sorry. Was a mispell of multipart.

This was actually a bug in the documentation.  In the examples it uses mutipart, instead of multipart.  I'm looking for the documentation now, to fix it.


Sonarcloud lab updated: more instruction added (for YAML option) and updated

attendees can either choose YAML or Visual pipelines

Hi @unaihuete93 ,
This PR has conflicts. Please have a look at it.
Thanks

Conflicts resolved, not sure what happened with the images...


Erro Csrf

Using Helper in the Scaffold auth of laravel 5.3 I had Csrf problems in the login form, I had to go back to version 2.2.1 to have some solution?

Sorry, the problem was your browser's cookies


osbuild: opts can't be empty in isolinux

If opts is empty osbuild stage fails:
Traceback (most recent call last):
  File "/run/osbuild/bin/org.osbuild.isolinux", line 243, in <module>
    ret = main(args["tree"], args["inputs"], args["options"])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/run/osbuild/bin/org.osbuild.isolinux", line 227, in main
    "cmdline": " ".join(kopts)
               ^^^^^^^^^^^^^^^
TypeError: can only join an iterable

Fix on the other side is here: https://github.com/osbuild/osbuild/pull/1309

manifest-diff is doing weird things here:
diff -Naur /tmp/tmp.4cAJbGx2qE/156c4118360e979d6bc426c730c94088e62a16a7/fedora_36-aarch64-iot_commit_with_container-boot.json /tmp/tmp.4cAJbGx2qE/PR/fedora_36-aarch64-iot_commit_with_container-boot.json
--- /tmp/tmp.4cAJbGx2qE/156c4118360e979d6bc426c730c94088e62a16a7/fedora_36-aarch64-iot_commit_with_container-boot.json  2023-05-15 10:22:42.885640129 +0000
+++ /tmp/tmp.4cAJbGx2qE/PR/fedora_36-aarch64-iot_commit_with_container-boot.json    2023-05-15 09:56:25.299292164 +0000
@@ -13446,20 +13446,20 @@
   },
   "containers": [
     {
-      "Source": "registry.gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/manifest-list-test",
-      "Digest": "sha256:1a19a94647b1379fed8c23eb7553327cb604ba546eb93f9f6c1e6d11911c8beb",
-      "TLSVerify": null,
-      "ImageID": "sha256:62d2a7b3bf9e0b4f3aba22553d6971227b5a39f7f408d46347b1ee74eb97cb20",
-      "LocalName": "manifest-list-test:v1",
-      "ListDigest": "sha256:58150862447d05feeb263ddb7257bf11d2ce2a697362ac117de2184d10f028fc"
-    },
-    {
       "Source": "registry.gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/fedora-minimal",
       "Digest": "sha256:4d76a7480ce1861c95975945633dc9d03807ffb45c64b664ef22e673798d414b",
       "TLSVerify": null,
       "ImageID": "sha256:d4ee87dab8193afad523b1042b9d3f5ec887555a704e5aaec2876798ebb585a6",
       "LocalName": "registry.gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/fedora-minimal:latest",
       "ListDigest": ""
+    },
+    {
+      "Source": "registry.gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/manifest-list-test",
+      "Digest": "sha256:1a19a94647b1379fed8c23eb7553327cb604ba546eb93f9f6c1e6d11911c8beb",
+      "TLSVerify": null,
+      "ImageID": "sha256:62d2a7b3bf9e0b4f3aba22553d6971227b5a39f7f408d46347b1ee74eb97cb20",
+      "LocalName": "manifest-list-test:v1",
+      "ListDigest": "sha256:58150862447d05feeb263ddb7257bf11d2ce2a697362ac117de2184d10f028fc"
     }
   ],
   "no-image-info": true

manifest-diff is doing weird things here:

Interesting and unexpected, but safe to ignore.

Clicked the Rebase.

Oh wait, I just realised.  We don't need this now given the change in the osbuild stage, right?

Oh wait, I just realised. We don't need this now given the change in the osbuild stage, right?

No we don't need it anymore but it probably also wouldn't hurt?

I mean the current state with opts being optional reflects the new stage schema correctly.

Right yes.


Hovering Over Status Value Will Crash A Client App

Hovering over status value will crash a client app. A popover is supposed to show but something is causing an error. This doesn't happen in the the local development version. Only in a client app.
Unable to find node on an unmounted component.
Could be caused by missing build components.

Duplicate of #27


MINOR: Ensure AlterIsr is forwarded to Controller in KRaft

More detailed description of your change
Ensure AlterIsr is forwarded to Controller in KRaft
Summary of testing strategy (including rationale)
I want to use some existing ITCase of AlterIsr but I can't find one, so I am working on this.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @cmccabe @jsancio to have a look first.


Icon: New icon for search by imae

Summary
New icon
What changed?
Added the search by image icon

Why?
Missing and requested by teams
Checklist

[x] Added unit and Flow Tests
[x] Added documentation + accessibility tests
[x] Verified accessibility: keyboard & screen reader interaction
[x] Checked dark mode, responsiveness, and right-to-left support
[x] Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

can we add it to the .ts file?


config.example.json not copied using installer script

The readme-file states under configuration:
"Copy TeleFrame/config/config.example.json to TeleFrame/config/config.json. \ Note: If you used the installer script. This step is already done for you."
The Note is not true! The installer script creates only the file config.json with one line which contains the token:
# Create config for start TeleFrame containing the token
echo -e "{\n  "botToken": "$token"\n}" > config/config.json
Please remove the note in readme-file and add additional information, that the token must be inserted as value for "botToken". Most convenient would be of course, to alter the installer script in such a way that config.example.json gets copied to config.json and the token is inserted automatically as the token is prompted and stored during installation anyway.


Compute dates in title template

I am trying to come up with a strategy for naming all my notes in a consistent way. What I have settled one is something that I don't know how to replicate or if it is possible.
When I create a weekly note, I want the name of the note to be something like [[Year - Month - date-of-the-monday-of-this-week - date-of-Sunday-of-this-week]. Sounds more complicated than it is, but as an example:
A weekly note created this week would be [2023-August-7-13] (Monday was the 7th of August and Sunday was 13th of August)
A weekly note created next week would be [2023-August-14-20]
etc
Is this possible?
The only thing that I could come up with was something like this, but I'm not really happy since "week 32" doesn't tell me much.

Your options are: w wo ww W Wo WW
Creating meta data (tags), I think you can insert the first day of that week with DD. Nothing for the title though.


error : note: ld: library not found for -lncursesw

hello
i am on macos how to install that library to my system
$ brew install ncurses
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> Updated Formulae
skinny
Warning: homebrew/dupes/ncurses-6.0_2 already installed

Is there a ncursesw package in homebrew?

Maybe related:
http://stackoverflow.com/questions/32955658/what-is-the-correct-way-to-use-wide-char-ncurses-on-debian-ubuntu
Looks like supporting macos might be a bit more complicated : /

I tried a target-specific Cargo.toml in the macos branch, can you have a try at it and see if it makes things better? Thanks!

You can specify the dependency in Cargo.toml:
[dependencies.cursive]
git = "https://github.com/gyscos/Cursive"
branch = "macos"

Hi there. I've had the same issue with ncursesw lib, and macos branch didn't solve the problem, unfortunately.
However, I've switched to termion backend, and everything looks to be working fine.

Looks like the reason the macos branch still fails is https://github.com/rust-lang/cargo/issues/1197
:(

This actually worked for me. I was having the WORST time trying to fix this. But this compiled and so far seems to work.

Some newer versions of cargo may have a better dependency resolving system? @mmiecz , could you try upgrading cargo and see if it changes anything?

Hi, I've updated cargo, and everything seems to be working fine now. Thanks!

Actually, I've run into some really weird problem. Whenever I try to compile example code without any changes, Cursive gets recompiled every time. Sometimes it gets recompiled without any error, and sometimes old error comes back:
MacBook-Air-Micha:terminal-tests mhl$ cargo run    Compiling cursive v0.3.5 (https://github.com/gyscos/Cursive?branch=macos#451d0522)    Compiling terminal-tests v0.1.0 (file:///Users/mhl/Sources/terminal-tests)     Finished debug [unoptimized + debuginfo] target(s) in 5.45 secs      Running target/debug/terminal-testsMacBook-Air-Micha:terminal-tests mhl$ cargo run    Compiling cursive v0.3.5 (https://github.com/gyscos/Cursive?branch=macos#451d0522)    Compiling terminal-tests v0.1.0 (file:///Users/mhl/Sources/terminal-tests) error: linking withccfailed: exit code: 1   |   = note: "cc" "-m64" "-L" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/terminal_tests-d163a702128509ba.0.o" "-o" "/Users/mhl/Sources/terminal-tests/target/debug/deps/terminal_tests-d163a702128509ba" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/mhl/Sources/terminal-tests/target/debug/deps" "-L" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libcursive-589ffaec46642e7b.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libunicode_segmentation-1400e9f38485b222.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libncurses-64b8ed169553261c.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libtoml-5130c1b472bb88f9.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libunicode_width-a8b627b65c290dac.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/liblibc-73c6422e7b19c2f3.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/librustc_serialize-03b62901d97343ea.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libodds-798c90752ba21e6f.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libstd-713ad88203512705.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind-8db31eff4f3f5d1c.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libunwind-9d903f075d9d1ed3.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/librand-15da1025aec585ac.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcollections-eba7f19f0aae5f37.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liballoc-0fa051c7d0594505.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liballoc_jemalloc-9dddbb08233542f3.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liblibc-72ccf8e77ba91924.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libstd_unicode-d3fcdc16d2a25b3a.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcore-407db9a296a50c43.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-dfc954c33c85abed.rlib" "-l" "ncursesw" "-l" "System" "-l" "pthread" "-l" "c" "-l" "m"   = note: ld: library not found for -lncursesw clang: error: linker command failed with exit code 1 (use -v to see invocation)

That's weird indeed. Maybe the cargo cache got messed up with an upgrade? cargo clean could help?

I've done cargo update and cargo clean and I still have this:
MacBook-Air-Micha:terminal-tests mhl$ cargo clean
MacBook-Air-Micha:terminal-tests mhl$ cargo build
   Compiling rustc-serialize v0.3.22
   Compiling odds v0.2.25
   Compiling unicode-segmentation v0.1.3
   Compiling cursive v0.3.5 (https://github.com/gyscos/Cursive?branch=macos#451d0522)
   Compiling unicode-width v0.1.3
   Compiling libc v0.2.18
   Compiling ncurses v5.84.0
   Compiling toml v0.2.1
   Compiling terminal-tests v0.1.0 (file:///Users/mhl/Sources/terminal-tests)
error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-m64" "-L" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/terminal_tests-d163a702128509ba.0.o" "-o" "/Users/mhl/Sources/terminal-tests/target/debug/deps/terminal_tests-d163a702128509ba" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/mhl/Sources/terminal-tests/target/debug/deps" "-L" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libcursive-589ffaec46642e7b.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libunicode_segmentation-1400e9f38485b222.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libncurses-64b8ed169553261c.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libtoml-5130c1b472bb88f9.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libunicode_width-a8b627b65c290dac.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/liblibc-73c6422e7b19c2f3.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/librustc_serialize-03b62901d97343ea.rlib" "/Users/mhl/Sources/terminal-tests/target/debug/deps/libodds-798c90752ba21e6f.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libstd-713ad88203512705.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind-8db31eff4f3f5d1c.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libunwind-9d903f075d9d1ed3.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/librand-15da1025aec585ac.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcollections-eba7f19f0aae5f37.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liballoc-0fa051c7d0594505.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liballoc_jemalloc-9dddbb08233542f3.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/liblibc-72ccf8e77ba91924.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libstd_unicode-d3fcdc16d2a25b3a.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcore-407db9a296a50c43.rlib" "/Users/mhl/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-dfc954c33c85abed.rlib" "-l" "ncursesw" "-l" "System" "-l" "pthread" "-l" "c" "-l" "m"
  = note: ld: library not found for -lncursesw
clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error

error: Could not compile `terminal-tests`.

To learn more, run the command again with --verbose.
MacBook-Air-Micha:terminal-tests mhl$ cargo build
   Compiling ncurses v5.84.0
   Compiling cursive v0.3.5 (https://github.com/gyscos/Cursive?branch=macos#451d0522)
   Compiling terminal-tests v0.1.0 (file:///Users/mhl/Sources/terminal-tests)
    Finished debug [unoptimized + debuginfo] target(s) in 6.47 secs
MacBook-Air-Micha:terminal-tests mhl$

Doh. Looks like cargo is not quite stable just yet.

Hopefully https://github.com/jeaye/ncurses-rs/pull/123 will make this easier.

You can try the latest master branch, it should fix this problem in a more stable way.

Yes, everything now is OK.

Great! :D


v1.6 backports 2019-09-30

#9201 -- Solve MTU issues by using table 200 post-encryption using output-mark (@lbernail)
#9299 -- bpf: fix cilium_host unroutable check (@borkmann)
#9296 -- policy: Fix selectorcache locking issue (@joestringer)

Once this PR is merged, you can update the PR labels via:
$ for pr in 9201 9299 9296; do contrib/backporting/set-labels.py $pr done 1.6; done

This change is

never-tell-me-the-odds

Hmm, looks like there was a change in the golang x/sys/unix library which breaks this backport:
# github.com/cilium/cilium/vendor/github.com/vishvananda/netlink
685../../vendor/github.com/vishvananda/netlink/route_linux.go:522:42: undefined: unix.RTA_NEWDST
686../../vendor/github.com/vishvananda/netlink/route_linux.go:528:42: undefined: unix.RTA_ENCAP_TYPE
687../../vendor/github.com/vishvananda/netlink/route_linux.go:533:42: undefined: unix.RTA_ENCAP
688../../vendor/github.com/vishvananda/netlink/route_linux.go:597:46: undefined: unix.RTA_NEWDST
689../../vendor/github.com/vishvananda/netlink/route_linux.go:602:44: undefined: unix.RTA_ENCAP_TYPE
690../../vendor/github.com/vishvananda/netlink/route_linux.go:607:46: undefined: unix.RTA_ENCAP
691../../vendor/github.com/vishvananda/netlink/route_linux.go:842:11: undefined: unix.RTA_NEWDST
692../../vendor/github.com/vishvananda/netlink/route_linux.go:852:11: undefined: unix.RTA_ENCAP_TYPE
693../../vendor/github.com/vishvananda/netlink/route_linux.go:854:11: undefined: unix.RTA_ENCAP
694../../vendor/github.com/vishvananda/netlink/route_linux.go:883:8: undefined: unix.RTA_NEWDST
695../../vendor/github.com/vishvananda/netlink/route_linux.go:883:8: too many errors
696make[1]: *** [perf-event-test] Error 2

@joestringer is the new code in x/sys/unix only in 1.13?
It would be great for us to get the MTU patch to the 1.6 branch

@lbernail No, it looks like it was already there in 1.11 or earlier but our vendor directory got out of sync somehow. I'm working through the issue with @aanm .

never-tell-me-the-odds

Thanks a lot!


update

Closes #
📝 Description

Add a brief description

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

merge new fixes and updates to main


[docs] Private docker-compose not available until a project has been started

Added a little note on finding the DDEV docker-compose file
The Issue
I searched and searched after installing DDEV. I thought I should be prepared well and already install the plugin and appointing the right docker-compose file. This was before I did a ddev start.
How This PR Solves The Issue
It might not solve, but maybe give someone like me a hint :-)
Manual Testing Instructions
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

I kind of think they should have started a project before trying to integrate with PhpStorm in the first place?

Well, maybe I am the only one then 😅 But it happened to me today.. I did a brew install first, read that there was a plugin and thought to myself: that might just be one handy thing to have before I start my project. And that's when I could not find the directory mentioned in the docs.

I imagine you're not the only one, but maybe the idea "Start one first" should go higher.

Ah thanks for the clarification, will do!

I now put it in the requirements :-)

Thanks @jeroenimpres !


Proposal: Create "feature/aws_load_balancer_policy" branch

...to receive PR when work is ready for review. Feature currently being implemented at:
https://github.com/jason-tyler/terrascan/tree/feature/aws_load_balancer_policy

Done


High availability tracking issue

If you're interested in high availability support for fck-nat, follow this issue. All PRs and subtasks will be linked here. This issue will not be closed until the 1.2 release of fck-nat launches.

Love the idea of this. Just curious if you have any kind of timeline in mind?

I'm targeting that high HA will be usable by mid-January. Documentation will be the long tail on this one.

Great - thanks for the reply

Mid-January target looking a bit optimistic. Whole family got COVID at the end of December and that's when I planned to do a good chunk of this. Still going to aim for end of January at the latest.

Thanks for the update @AndrewGuenther, it's really appreciated. Hope you're all safe and well.

A bit later than I'd hoped, but progress is being made on high availability. You can follow along on the ha-mode branch: https://github.com/AndrewGuenther/fck-nat/tree/ha-mode
The initial approach is to create a single instance autoscaling group with a static ENI that the currently active instance will attach at start. Initial implementation will be in CDK and both the deb and rpm packages will include support as well via a configuration option.
The CDK construct has been made and can be seen on the ha-mode branch. I'm currently working on adding attachment support to the fck-nat service. Once that is done, I'll be publishing the CDK construct to Construct Hub. After that, I'm open to feedback on where to prioritize publishing next.

Hi, this is great stuff and I appreciate your work on it! Any idea when you think ha-mode will be good enough? What's left to do?

Some additional progress info: I've made good progress on the script changes, but debugging iptables is a massive pain. I'm also weighing two different approaches:

In the first approach, I attach the ENI and then forward traffic to the default interface to handle the NAT. The benefit of this approach is that you don't need to muck with any of the default networking attachment settings, you're just adding a new interface and then forwarding to it.
The second approach is to allocate an EIP for the ENI and then NAT that interface directly. This requires blowing away some of the default networking config which can be difficult to get right across distros and (theoretically) takes longer if the instance needs to be replaced.

I strongly prefer the first approach, but I'm having a hell of a time getting the iptables to do what I want and I only have so much patience for messing with them in a single sitting :sweat_smile:. Approach 2 however is working end-to-end, but isn't hardy enough for me to qualify it as HA. So with both approaches I have successfully modified the script and associated CDK to grant permissions for ENI attachment and can attach the ENI, it's just down to some iptables debugging...

Alright. Got inspired this weekend to make some progress here. I'm going to stick with approach 2 as I've found a way to solve most of my concerns with it. I need to clean up the code for pushing, but the hard work here is done. I'm out a conference this week and I should have enough downtime there to button this up.
Thanks everyone for the patience, this has been a longer time coming than I had hoped.

Alright, the ha-mode branch has been updated with a version of the fck-nat service with ha-mode working on Amazon Linux. I'm currently using the ec2-net-utils to simplify editing the interfaces, but that doesn't work on Ubuntu. The scripts aren't terribly difficult, it's really some nitty gritty in ec2ifup I need to replicate which I'm working on now.
Once that's working on Ubuntu, I'll add some documentation and publish version 1.2. One of the goals for 1.2 was to publish CDK and Terraform modules. Given that it's a PITA to do all of that in a single repo, I'll be spinning off a fck-nat-cdk and fck-nat-terraform repository for those.

This is amazing! Thanks for all the hard work here. Looking forward to
trying this out soon!
On Tue, Jun 21, 2022 at 12:23 Andrew Guenther @.***>
wrote:

Alright, the ha-mode branch has been updated with a version of the
fck-nat service with ha-mode working on Amazon Linux. I'm currently using
the ec2-net-utils to simplify editing the interfaces, but that doesn't
work on Ubuntu. The scripts aren't terribly difficult, it's really some
nitty gritty in ec2ifup I need to replicate which I'm working on now.
Once that's working on Ubuntu, I'll add some documentation and publish
version 1.2. One of the goals for 1.2 was to publish CDK and Terraform
modules. Given that it's a PITA to do all of that in a single repo, I'll be
spinning off a fck-nat-cdk and fck-nat-terraform repository for those.
—
Reply to this email directly, view it on GitHub
https://github.com/AndrewGuenther/fck-nat/issues/8#issuecomment-1161977612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5KLKCJEGWGFZPCCZSMGLVQHT67ANCNFSM5JDEWEJQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I am happy to report that the ha-mode branch has now been merged into main! I've confirmed that the AMIs are working as expected in both single-node and ha-mode and will be publishing a release shortly.
I've also been working on migrating the CDK code out into a dedicated construct which will also be published soon.

CDK construct code in progress here: https://github.com/AndrewGuenther/cdk-fck-nat

Thank you for all your work on this @AndrewGuenther - really appreciated

The v1.2.0 AMI for fck-nat has been published in AWS and is available for use. The official cdk-fck-nat construct is being released as I write this as well which is the easiest way at the moment to get your hands on HA mode. As much as I want to resolve this issue, there's still some additional documentation I want to write, I'll close this as soon as that's done.

NPM CDK module: https://www.npmjs.com/package/cdk-fck-nat
Python CDK module: https://pypi.org/project/cdk-fck-nat/

Documentation for this feature is up, it is supported out-of-the-box by the CDK module, and the warning has been removed from the README. Resolving!


Add Cellular 0.0.8

Adding a new cask

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the token reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.

Suite is done, but which files am I supposed to deleting with zap? I can't find them on my computer.

@Numbermaniac, usually there are preference files which are created by the application. Try searching for "cellular" inside ~/Library and see if you can find something.

@reitermarkus Yeah, I searched and nothing showed up, other than a .sfl file for the program but I'm not sure if that's necessary to delete.

Please add the .sfl file. It's not necessary, but helpful if you want to reset an application or just keep your system clean.

@reitermarkus Done :)

Thank you for the contribution. It needed some fixes, so they were made in dd54e245b4eea54d2e50b5135b600d668c2f2b36. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


"Bookstore-React-Redux" fourth milestone

Improved layout of the app UI so that it matches the model provided by microverse in Zeplin.

All issues listed on the previous code review were addressed, however: "src/assets/user.png" was not deleted, as it contains an icon that displays in the app. The css variable that was created and applied throughout the app, as requested, is "css-package."


Playwright support

fixes #1029

As a I side note, ideally I resolve them comments, when I think the question asked has an answer that needs no answer. Otherwise this is useless to do, since email notifications would be the only thing informing me of there even being an answer, and even if I think it's not a good one, no way I can immediately react at all times, but email becomes unread.

I don't quite like code using plugins. I think it would be better if we allowed plugins to provide variable values (on demand) and have configuration instead. For something like _getPlaywrightRegistryDirectory maybe we don't have to have it all as Python, but somehow provide it. But for now it's good enough. I am sometimes on a mission to reduce the number of plugins, and this will be on my mind surely as one that I believe ought not to be one.


Move combining apps docs

Move Combining Apps into its own file, out of the Deployment docs. This came out of some discussions from the Campus Experts hackday, as documented in https://github.com/probot/friction/issues/13

I'm still iffy about this just because I don't think we wanna support combining apps so strongly to give it its own page. I think it's something we shouldn't recommend users to do in most scenarios. I see it as more of a side note or weird circumstance that shouldn't draw too much attention.
Thoughts @bkeepers?

I don't think we wanna support combining apps so strongly to give it its own page.

Based on all the questions I'm receiving about this, I 100% agree. However, I don't think that putting those docs in the wrong place (to me, keeping it under deployments is the wrong place) is the right solution to dissuading people from doing it.

In my mind, this is a deployment concern since the only difference is whether you deploy a bunch of small services or one monolithic one (and someday when there's the magical Probot cloud hosting service, these will all just become "skills" that Probot can do).
I definitely want to dissuade people from doing this, but don't want them to not use probot if the philosophy of many small isolated apps doesn't work for them.
So, I agree that moving it to a separate page gives it too much visibility. Is there another existing page that it makes more sense on?

Sorry, I just saw the conversation in https://github.com/probot/friction/issues/13. 🤷♂


feat(watch): support tsconfig flag

closes https://github.com/esbuild-kit/tsx/issues/57

:tada: This PR is included in version 3.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


vue inspect returns "Failed to locate @vue/cli-service." (fails to find global @vue/cli-service on Windows)

Version
3.0.0-rc.3
Reproduction link
https://cli.vuejs.org/guide/prototyping.html
Steps to reproduce
Just run vue inspect in the project directory.
What is expected?
It should return the config in the command line output.
What is actually happening?
Returns  ERROR  Failed to locate @vue/cli-service. Make sure you are in the right directory.
Also didn't work when I've explicitly installed @vue/cli-service globally (yarn global add @vue/cli-service)
It did work however when I installed @vue/cli-service locally (yarn add @vue/cli-service), but for my colleague who's using Mac it's working out of the box (without having to install cli-service locally). Perhaps it can be fixed on vue-cli side to find global cli-service? Maybe it's some path issue?

Node version: 10.6.0.
OS: Windows 10.
Command line: Cmder, cmd (with admin rights).

The error is raised here:
https://github.com/vuejs/vue-cli/blob/fd1c0d5b8ac6c571c82c67b5b9346f1eea6d1ea1/packages/%40vue/cli/lib/inspect.js#L9-L15
I think your colleague might have accidentally installed @vue/cli-service in an ancestor directory.

I've the same problem when copy the project folder from Mac to Windows.

I assume you are running vue inspect in a rapid prototyping project with no local deps - and this is expected because vue inspect is just an alias to vue-cli-service inspect and requires a locally installed @vue/cli-service.
We can try to make vue inspect work for the prototyping mode but I don't really see much value in this - in prototyping mode you can't tweak the webpack config anyway.


mkdocs2pandoc exits with error "ValueError: invalid width 0 (must be > 0)"

I'm on Ubuntu 15.04 with Python 2.7.10, mkdocs 0.15.3 and using a slightly modified mkdocs-material theme.
When I run the tool, it exits with this error:
Traceback (most recent call last):
  File "/usr/local/bin/mkdocs2pandoc", line 9, in <module>
    load_entry_point('mkdocs-pandoc==0.2.6', 'console_scripts', 'mkdocs2pandoc')()
  File "/home/maggus/.local/lib/python2.7/site-packages/mkdocs_pandoc/cli/mkdocs2pandoc.py", line 80, in main
    for line in pconv.convert():
  File "/home/maggus/.local/lib/python2.7/site-packages/mkdocs_pandoc/pandoc_converter.py", line 165, in convert
    lines = mkdocs_pandoc.filters.tables.TableFilter().run(lines)
  File "/home/maggus/.local/lib/python2.7/site-packages/mkdocs_pandoc/filters/tables.py", line 177, in run
    ret.extend(self.convert_table(block))
  File "/home/maggus/.local/lib/python2.7/site-packages/mkdocs_pandoc/filters/tables.py", line 163, in convert_table
    lines.extend(self.wrap_row(widths, row))
  File "/home/maggus/.local/lib/python2.7/site-packages/mkdocs_pandoc/filters/tables.py", line 208, in wrap_row
    row[i] = tw.wrap(textwrap.dedent(row[i]))
  File "/usr/lib/python2.7/textwrap.py", line 329, in wrap
    return self._wrap_chunks(chunks)
  File "/usr/lib/python2.7/textwrap.py", line 258, in _wrap_chunks
    raise ValueError("invalid width %r (must be > 0)" % self.width)
ValueError: invalid width 0 (must be > 0)

Any ideas?

First shot (not much time right now): it may be something I have introduced with the fix for https://github.com/jgrassler/mkdocs-pandoc/issues/11. If you like you can try it with mkdocs-pandoc 0.2.5 (git revision  0a0c6b2a6548e169dd4b93cf3ac9503097dca4b6) Can you share your documentation, or failing that, a minimum example to reproduce the problem? If it helps with building the minimum example: the problem occurs in one of your tables (I can tell as much from  the backtrace).

I did exclusion principle testing and found that it was some malformatted tables. The content originally came from DokuWiki and was converted using a converter script that produced "broken" tables.
The ones breaking the tool looked like this:
 | IAM Node                                                | Database Node | Engine Node |
 | ----------                                                | --------------- | ------------- |
 | RAM|8GB or higher|32GB or higher|16GB or higher|
 | CPUs/cores|2 or higher|4 or higher|4 or higher|
 | Hard Disk|50GB or higher|200GB* or higher|50GB or higher|

As you can see with some major whitespace. I removed that everything works fine for now. Will do more testing. Thanks.


x/tools/cmd/vet: mark interfaces to have the correct type for verb %p

Analyzing this program http://play.golang.org/p/aWILUB_GHi with vet, produces the
following problem

> arg i for printf verb %p of wrong type: main.Foo

This occurs because the variable i is an interface and the function matchArgTypeInternal
in go.tools/cmd/vet/types.go does not mark interfaces as OK for the verb %p. I would
like to propose that this usage is not marked as a problem, since the program executes
without errors and prints the address to the interface.
(Which is also the same address printed by the verbs %#v and %+v using the example
code.) I can send a CL if you like but I wanted to confirm first that this is not
intentional since I could not find any documentation about it.

$ go version
> go version go1.3.2 linux/amd64

@robpike, opinions on this?
I just got a CL to "fix" my formats from %p to %T to workaround this, but I had %p intentionally so I could line up interface values in my logs with leaked goroutine stack traces.
But I realize https://golang.org/pkg/fmt/ doesn't really define what %p means for an interface. Is it the second word of the interface value, assuming there's a pointer in there?

(the CL to fix my formats was https://go-review.googlesource.com/#/c/20002/)

This has been fixed by a flurry of recent changes. The playground example above now is silent when passed to vet.


Updated Dockerfile to target latest NuKeeper release.

Thanks, this will also require a update on docker hub. Which I will do!

Accidentally closed.. Sorry


Add deprecation notice for run_northstar.txt

related to #508
followed up by #512
run_northstar.txt is a relic of times gone by and is no longer needed.

Code seems to make sense, error code makes sense and gives a proper solution, and works in testing

HOWEVER, it should be noted that it only worked after deleting Northstar.dll, after having tried just replacing the files, which didn't make the error appear. While this (deleting the files and not simply replacing) is realistically the recommended solution, it should be noted that there could be people that miss the error message

When does it occur twice?
when launching with just -northstar or via NorthstarLauncher?

When does it occur twice?
when launching with just -northstar or via NorthstarLauncher?

launching Titanfall 2 via Steam using -windowed -noborder, with run_northstar.txt in the Titanfall2 directory with a 1 inside it, on windows 10


Cannot find lock-file when building rust-lib sysroot

Xargo fails to build the rust source due to it incorrectly getting a reference to the lockfile for the rust-lib.
Currently, we get the lockfile reference through the following code in sysroot.rs:118:
// rust-src comes with a lockfile for libstd. Use it.
let src_parent = src.path().parent().map(Path::to_path_buf).unwrap_or_else(|| src.path().join(".."));
let lockfile = src_parent.join("Cargo.lock");

From debugging, src_parent points to toolchain-path/lib/rustlib/src/rust/ and not the actual directory where we can find the correct lockfile for rust-lib, which would be: toolchain-path/lib/rustlib/src/rust/library/. Maybe this is just unique to my system. I remember this working a while ago. I have solved this locally by doing something like this:
let lockfile = src.path().join("Cargo.lock");

and fully circumventing the src_parent, since it's not needed anywhere else.

I got the same issue, glad it's not only me.

just fixed it in my fork, https://github.com/AverseABFun/xargo

made a PR, #348


Add queue cancellation on request cancellation

Fixes #18
Also started refactoring the main package into sub-pkgs.

Waiting for dockerhub to come back up...

Appears to fix the original issue, cancelled requests appear to be removed from the queue immediately after cancellation:
2023/11/11 22:52:23 Average for deployment: stapi-minilm-l6-v2: 573 (ceil: 6), current wait count: 754
2023/11/11 22:52:23 Average for deployment: kubernetes: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:23 Average for deployment: lingo: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:26 Average for deployment: stapi-minilm-l6-v2: 525.5 (ceil: 6), current wait count: 0
2023/11/11 22:52:26 Average for deployment: kubernetes: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:26 Average for deployment: lingo: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:29 Average for deployment: kubernetes: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:29 Average for deployment: lingo: 0 (ceil: 0), current wait count: 0
2023/11/11 22:52:29 Average for deployment: stapi-minilm-l6-v2: 480 (ceil: 5), current wait count: 0


fix engine init

Closes #16

superseeded by https://github.com/projectdiscovery/gozero/pull/18

Closing as per https://github.com/projectdiscovery/gozero/pull/17#issuecomment-2435133241


Cannot see current branch

I don't know the branch that i'm currently seeing. I can only see it when i'm about to change it.

Done

Perfect!


Error in keep_query_convert()

Ran the code with the prompt "python kim.py -b --all" to process all the notes but got the message:
Error in keep_query_convert()
Could not excute KIM
after a few notes. Not sure what the nature of the error, but if the code skipped the file causing the issue (while printing the name of the problem file), I could add those manually later.
Also previously I had the error/warning:
'Keep.resume' has been renamed to 'Keep.authenticate'. Please update your code
So I updated the kim.py accordingly (replacing 3 instances of resume with authenticate)

@ndilekli Thanks for submitting the issue. Is there any way to narrow down what note might have caused the error? It would be great to see what might have been the problem.
In the meantime I'll fix the other issues and do the skip over problem notes.

Strangest thing. I originally tried it on a Win10 machine. Just tried it on a Win11 machine, and everything went smoothly, converted over 600 notes. One other thing I did was to add titles to the top few notes in order to identify which one was causing the problem. But never had the error. Thanks for everything :)

I don't think so, since both of my Win installations have English and Turkish keyboards installed, but it is not an area I have much expertise on. If there are some lines that can help debug the error, I can check it out as well.

+1 maybe an issue with i18n. I also have a keep notes with multiple alphabets, tried an export on a win10, same issue. Works first try on a linux, everything was exported right.

@arha - do you know if the versions of Python were the same on Win10 and Linux?

I tried some turkish notes and was not able to get it to fail. I'm wondering about the missing titles possibly having something odd within them @ndilekli. Were the titles completely empty in the Win10 case where it failed?

@ndilekli - I'm going to close this one for now. If it pops up again - maybe you can figure out what caused it and we'll reopen the issue.


Testcases for the new functions in AminoJS

Hence there are a lot of new Features comming to AminoJS i would like to have all of them Testcased hence if there is a backend change from Narvii / Amino Inc. we can change up the Libary after that.

I didn’t made the testcases XD I’ll be working to add them!
From: Robin Möller<EMAIL_ADDRESS>Sent: Sunday, March 24, 2019 5:10 AM
To: AminoJS/Amino.JS
Cc: Subscribed
Subject: [AminoJS/Amino.JS] Testcases for the new functions in AminoJS (#58)
�
Hence there are a lot of new Features comming to AminoJS i would like to have all of them Testcased hence if there is a backend change from Narvii / Amino Inc. we can change up the Libary after that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/AminoJS/Amino.JS/issues/58 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aj7EwfJJ3OM0p_5B60ti1q4PYPp_jj67ks5vZzK9gaJpZM4cFXq- .  https://github.com/notifications/beacon/Aj7EwRFnrGMOZiSrZZyYb2sdEYHi43MTks5vZzK9gaJpZM4cFXq-.gif

Thx!
�
From: Robin Möller<EMAIL_ADDRESS>Sent: Sunday, March 24, 2019 5:10 AM
To: AminoJS/Amino.JS
Cc: Akatsuki Levi; Assign
Subject: Re: [AminoJS/Amino.JS] Testcases for the new functions in AminoJS (#58)
�
Assigned #58 https://github.com/AminoJS/Amino.JS/issues/58  to @akatsukilevi https://github.com/akatsukilevi .
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/AminoJS/Amino.JS/issues/58#event-2224729406 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aj7Ewblp5SHyol2hU5tgwFSjYTllSoHYks5vZzK-gaJpZM4cFXq- .  https://github.com/notifications/beacon/Aj7EwUY4MA497Y6PB73oxZgifyAgT241ks5vZzK-gaJpZM4cFXq-.gif

I've got a little free time today, going to make the testcases today


Ever Thought About Running Resharper Through The Code?

This project might quality for a free license to Resharper (https://www.jetbrains.com/buy/opensource/).  Is there any reason no one has thought to do this?  Its "Possible NULL Reference exception" code warning is worth its weight in gold for preventing problems down the road.

I can't properly function without resharper and DockPanel Suite already makes use of the open source licence generously provided by JetBrains.
Are there particular examples you think are at risk of null references?  Blindly performing null checks at every suggestion is not necessarily a productive exercise and can result in masking the root cause of issues.

As an example of null checks, it is more than just performing null checks, it is performing them and raising a suitable exception that should include debugging information where available, which capitalizes on the experience of the primary developers.
For example, getting the default NullReferenceException from deep within the code does not do much to help debug it.  But getting one that contains additional information such as "...this can happen in MDI scenarios when merging menu items if you did not set abc' first" would be more helpful, and might help a user figure out what they did wrong as opposed to assuming it is a bug in the library.
IMHO and experience, controlled exceptions are always better than uncontrolled ones. In the future, they could also hook into a logging system which could help end users even more when things go wrong.
At a minimum, if R# is already being used, it might be a good idea to annotate anything that would cause R# to light up.  This makes browsing the code much easier (at least, it would for me) when trying to figure out bug fixes or functionality/performance improvements.

I think it is more a challenge on WHO will perform the cleanup.
The status of such an old project with multiple technical debts to pay, without its original developer's love, is that current maintainers might not have deep understanding of every corner to perform various tasks such as the one you suggested with confidence.
R# is a good tool but to fix violations a dedicate person with adequate time is required. If you are willing to be the one, I think both @roken and I are more than happy to review and merge the changes submitted.

As mentioned above, time is not the issue - experience with the codebase is.  There is only so much that can be gleaned by walking through the code.  Even if I performed a thorough breakdown of the code, there would still be tacit knowledge that you and/or roken have that I would not.  Suggesting someone that is basically brand new to the code to make such wide-sweeping changes is risky at best, and negligent at worst.
So, the TL:DR version is that none of the current, more experienced maintainers have the ability/capacity/desire to put forth this effort?

It has already been said that this is a time (capacity) issue, not an ability or desire issue.  Having detailed exceptions for every possible scenario would be a great add, but time is a very limited commodity. Functional/behavioral issues take higher priority over nice-to-have-debugging-assistance on the triage chart, and not just with open source volunteer efforts but commercial products as well.
Those having trouble with debugging or implementation have multiple forums available to them: this github site, StackOverflow, etc.  Many open source projects also more explicitly drive individuals with support issues or problems during implementation towards paid consulting, which is also an option here.


Invalid JSON String: "{}[]{}[]{}[]{}[]{}"

What is the output link of /viaversion dump?
http://hastebin.com/ugemedalak.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please
BungeeCord (latest) with ServerListPlus (latest), SkinsRestorer (Shevchik's version) and NuVotifier (latest)
How does this error happen? login? Using an item?
Randomly from what I saw so far.
Is there an error in the console? Use pastebin.com. Is there a kick message?
Just this:
[01:50:14 INFO]: Invalid JSON String: "{}[]{}[]{}[]{}[]{}" Please report this issue to the ViaVersion Github: us.myles.viaversion.libs.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 4 path $
[01:50:14 INFO]: Invalid JSON String: "{}[]{}[]{}[]{}[]{}" Please report this issue to the ViaVersion Github: us.myles.viaversion.libs.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 4 path $

[01:58:54 INFO]: ViaVersion 0.9.10-SNAPSHOT

You're using a plugin that's sending this data. I'd suggest you work out what it is and remove it, we can't help if you're using a plugin sending bad data.

Any tips on how can I identify that plugin? The issue is somewhat random...

Remove plugins? Honestly can't really help other than the above.
Ensure they're up to date, ish?
The best idea is to try and work out when it happens or if there's anything useful before that error in the console like a player typing a command.


Admin panel ban notes

In gitlab by @1219693 on Jan 14, 2016, 09:00
If the notes of a ban are already open, when pressing to close, it will close then open again. It seems that it is unaware that it's already open.

In gitlab by @A-Lawrence on Jan 14, 2016, 21:17
This specifically relates to when you are sent to the URL containing the "default ban" view.  I.e. /mship/account/980234/bans/40
Ban 40 will be open by default.  The classes are incorrect for bootstrap accordion styling.

In gitlab by @A-Lawrence on Feb 6, 2016, 13:20
Milestone removed

In gitlab by @A-Lawrence on Aug 20, 2016, 19:39
Removed ~98471 label

Minor styling issue

Fixed by 7b30a85bec2d94c8bfa66296eb3eee9663db38bd


Alpine API

Context
There are significant speed improvements by switching to alpine, both for installing and managing packages on the container, and also due to a significantly reduced container size
This PR moves the main API to an alpine based image (The task API is already using alpine)

Blerg, sorry meant to PR against developmentseed/ml-enabler. (Though I hope to push this upstream at some point!)


Don't share the same object literal for prototypes when unspecified (#122)

Fixes #122.

Whoops, I labeled the branch and commit message with #121 when I meant #122.


Sming usage of I2C Port Expander

@jaretburkett :
Thanks for this library, it was a perfect starting point for my experiments in this.
I plan to use an updated version within the Sming Framework for ESP8266.
The work in progress is in my fork : https://github.com/hreintke/Arduino-I2C-Port-Expander.git
Branch Sming_Updates
Do you want me to PR when finished or keep your version as is.

@hreintke #2 have you any idea?


Scaling-prop and calculation

I have a use case where I am nesting a grid under a container that allows zooming and panning. To maintain the correct behaviour when dragging and resizing items, the zooming scale needs to be accounted for.
I've made a PR that implements a scale-property on the GridItem-component. On the resizing and dragging event-handlers the scale then gets applied.

I also have this use case and if it gets implemented then it would be a really nice feature.
Thanks @plc-dev for the commit.
cc: @gmsa

I have a use case where I am nesting a grid under a container that allows zooming and panning. To maintain the correct behaviour when dragging and resizing items, the zooming scale needs to be accounted for.
I've made a PR that implements a scale-property on the GridItem-component. On the resizing and dragging event-handlers the scale then gets applied.

Hi. does this scaling this works ??. I tried using it in my project and passed the scale argument to the widget but still the resizing is not working as it should. i cannot reduce width of widget.

passed the scale arguement to the grid item.


remote peer address is lost in ctx - always resolves to localhost

Since grpc-gateway creates a HTTP REST service that then subsequently calls a gRPC client, the loopback network hop causes all requests at the gRPC service to appear to originate from ::1 (localhost in IPv6).
Example gRPC service:
func (r *myService) MyRPCEndpoint(
	ctx context.Context, msg *grpcapi.Message) (*grpcapi.Message, error) {
 	p, _ := peer.FromContext(ctx)
	remoteAddr := p.Addr.String() // ALWAYS localhost when incoming from grp-gateway :(
        // ... etc
}

It would be nice if X-Forwarded-For (or the newer Forwarded RFC header) were populated with the original external address, but since gRPC is not another HTTP endpoint, we need some other context attribute set such as ProxyRemoteAddr (or whatever) in the forwarded gRPC request.
I may make a PR for this as it's something I need right away, and don't see an obvious workaround.

One way I've found is to inject the HTTP req.RemoteAddr into the ctx:
ctx = metadata.NewContext(ctx, metadata.Pairs("RemoteAddr", req.RemoteAddr))

Then, in the server side gRPC service method:
md, _ := metadata.FromContext(ctx)
remoteAddr := md["remoteaddr"] // this returns a IP string of "[<IP_ADDRESS>:5678]" - why the "[ ]" wrap?

So, it's doable, kind of ugly but not terrible on the gRPC server side. Any thoughts?

Pull request attached :boom:


Return JSON request.body as received?

Hello,
What I'm trying to achieve seemed pretty simple in theory but it has been giving me a big headache.
I want to return in the response the same exact JSON payload that I've received in the request.
Below is what I've been trying.
If I use "body": "{{request.body}}" I get an encoded xml representation of my input.
I've tried looking into handlebars and tried few variations of the following:
"body": "{{json context [view=\"request.body\"] [escapeHTML=false] [pretty=false]}}",
In this case I get a 500 response and Wiremock does not print anything in the logs (in verbose mode).
Is it possible to return whatever payload was sent in the request?
Thanks in advance!
Complete mapping file:
{
    "request": {
        "method": "POST",
        "urlPattern": "/v1/.*/configurations/",
        "bodyPatterns": [ {
            "matches" : "^((?!error).)*$"
        } ]
    },
    "response": {
        "status": 201,
        "body": "{{request.body}}",
		"transformers": ["response-template"],
        "headers": {
            "Content-Type": "application/json"
        }
    }
}

Hi, just had the same issue. Seems like wrapping request.body like this {{{request.body}}} works (no escaping). Haven't found any official documentation on this, but found this: https://groups.google.com/forum/#!topic/wiremock-user/2rD0e6kUdE0

The {{{ ... }}} non-escaping syntax is standard Handlebars: http://handlebarsjs.com/#html-escaping


Change trackpad hint name

Had an issue using the term "3D" without the editor creating whitespace between those characters. Used "Enable Trackpad" instead. Closes #5254.

Could you redo your commit in a clean branch? Twelve commits for a two lines fix is a bit too much :)

Whoops! Don't know how that happened. Will fix.

It got worse :D You should restart from a clean copy of the upstream master branch I think.

Doing that now.


Initial Demo

Refactors demo to adhere to Clean Architecture;
Removes UserProfile and Delete usecases that the demo initially had;
Now consists only of Signup and Login usecases and respective views;
Defines an interface and implements functionality for querying and saving users to a database --
Each new usecase should define its own interface to access the database (DBUserDataAccessObject), and make sure that the database file implements this functionality

Note for future PR comments:
When writing a description of what you have done try to use the filename of which the described changes refers to.
For instance in the following section list the file names for which there was an interface defined and so on, just as you did when you said "access the database (DBUserDataAccessObject),".

Defines an interface and implements functionality for querying and saving users to a database -- Each new usecase should define its own interface to access the database (DBUserDataAccessObject), and make sure that the database file implements this functionality

With reference to the last comment:
SignupUserDataAccessInterface.java and LoginUserDataAccessInterface.java both define interfaces to make use of DBUserDataAccessObject.java
Also, I meant to suggest that when making future usecases, those should also define their own interface for DBUserDataAccessObject.java (and make sure that their intended interface is implemented in DBUserDataAccessObject.java)


"@vite-pwa/nuxt": "^0.1.1" - manifest.webmanifest is 404

Hi, I'm following the instructions for Nuxt 3 on the docs and nuxt generate isn't creating a manifest.webmanifest file in .output/public.
Can you help me understand why?
Here is a minimal example built from the documentation.
nuxt.config.ts
// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
  devtools: { enabled: true },
  ssr: false,
  modules: ["@vite-pwa/nuxt"], // https://vite-pwa-org.netlify.app/frameworks/nuxt
  pwa: {
    /* your pwa options */
  },
  generate: {
    routes: ["/"],
  },
});

I run with npm run generate && npx serve .output/public and when Firefox loads the site, the web server 404's for the manifest.webmanifest
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> GET /200
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> Returned 200 in 1 ms
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> GET /404
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> Returned 200 in 1 ms
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> GET /
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> Returned 200 in 0 ms
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> GET /manifest.webmanifest
 HTTP  11/8/2023 10:16:54 AM <IP_ADDRESS> Returned 404 in 1 ms

These files are created:

I just noticed this is the docs repo...  I made an issue in the next repo here: https://github.com/vite-pwa/nuxt/issues/84  Sorry to whichever repo has the duplicate issue...


Support Poetry version syntax and optional dependencies

@marcelotrevisani Thank you for all of your contributions! This is a critical project to the Conda Forge ecosystem, and I noticed that you have been maintaining this for 3+ years. I figured I should pay back your generosity with my own. I would appreciate your review on this PR. 🤗 ❤
Description
This PR implements support for the most common Poetry projects by correctly handling Poetry version syntax and optional dependencies.

Closes #440
Closes #441

What this PR implements:

Correct encoding of Poetry dependency versions including support for the Poetry-exclusive ^ and ~ version operators
Fixes bug where Poetry dependency specification fields like optional were being included in the Conda recipe version specifiers
Support for Poetry optional dependencies declared via optional = true
Implements additional unit and snapshot tests for Poetry projects

What this PR does NOT implement:

Guaranteed correct handling of pre/post/dev release segments like 1.2.3a1
Support for Poetry Python restricted dependencies declared via python = "..."
Support for all other Poetry dependency fields like: git, path, url, source, markers

Strategy
Version specifiers
Poetry version operators are mostly compatible with Conda recipe version operators, with the exception of ^ and ~ which need to have custom encoding logic. The expected behavior is roughly:

^M.m.p⇒ >=M.m.p,<(M+1).0.0
~M.m.p⇒ >=M.m.p,<M.(m+1).0

(format: Poetry version syntax ⇒ Conda recipe version syntax)
As you might expect, this logic is a bit trickier because Poetry also allows non-semver version specifiers like ~1 or ^0, and has special edge cases for major version 0. Please see the implementation in py_toml.py for details.
Optional dependencies
Optional dependencies need to be listed under requirements.run_constrained in the recipe metadata.
Complete example
The Poetry dependency:
tensorflow-text = {version = "^2.11.0", optional = true, python = "^3.10, <3.12"}

Should be listed in the recipe metadata as:
requirements:
  run_constrained:
    tensorflow-text >=2.11.0,<3.0.0

We are implicitly ignoring all Poetry dependency specification fields aside from version and optional at the moment, as it’s not clear how to support them.
Suggested next steps

Review, iterate, and merge this PR.
Cut a new 2.3.0 release.
Investigate how to support Python restricted dependencies.

Initially I thought we could leverage Conda recipe preprocessing selectors, but there is too much ambiguity on how to handle Python 3.10+, and it seems to be on a deprecation path. See upstream issue: https://github.com/conda/conda-build/issues/4032

Perform a refactor of the code handling Conda recipe metadata synthesis. Let me explain my reasoning:

The source code is overly imperative, especially for the pyproject case. I had a lot of difficulty understanding the code because each metadata field was being determined manually through a long chain of dict lookups, dict merges, and conditional if statements. This style of code is brittle and prone to failure.
For example, the pyproject metadata gets merged manually with the setup.py/setup.cfg metadata, which then gets merged with PyPi metadata. This mysterious, Frankenstein "metadata" dictionary then finally gets transformed into Conda recipe metadata. This strategy will grow to be too difficult to maintain.
Eventually, I think the way forward is to have a CondaMetadata class that accepts a list of metadata sources and handles field resolution (i.e. “generate the list requirements.run, merging all dependencies together”) declaratively through a clean API.
@marcelotrevisani I can elaborate on this further in a future design document, if you are interested.

References

requirements.run_constrained in recipe metadata
Conda version syntax
Poetry version syntax
Conda preprocessing selectors

Hi @dlqqq , thanks a lot for your contribution! I am happy that you are enjoying grayskull.
I have a few suggestions that I will add later today, I am at my day job, so I don't have much time to review right now, but I will do it later. Thank you!
🚀

can you add semver to this file please?
https://github.com/conda/grayskull/blob/main/environment.yaml

@marcelotrevisani Done. 😎

I have one more suggestion; after that, it should be good to go! :)
Thanks a lot for your contribution!

Thanks for your contributions! 🚀

sure, let me cut a new release

@dlqqq, I really appreciate this work.  The lack of pyproject.toml was becoming an increasing problem for me because I use grayskull as part of my workflow in maintaining a lot fo feedstocks.


[Fix #9608] Fix a false positive for Layout/EmptyLineAfterGuardClause

Fixes #9608.
This PR fixes a false positive for Layout/EmptyLineAfterGuardClause when using guard clause is after rubocop:enable comment.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I'm assuming that's problem existing in other cops checking for a blank line after something.

I'm assuming that's problem existing in other cops checking for a blank line after something.

If it is a general behaviour, maybe we can add an extra helper class to check it?

Should this be specific to directive comments, or maybe generalized to any comment (or multiple lines of comment) after the clause?

@koic ping :-)

Thank you for reviews. I updated this PR and I will proceed separately for similar other cops.

Thanks!


ValueError: 'png' is unsupported format

There may be some png images in the article and when executing the script it prompts the following, has anyone encountered the same error?
ValueError: 'png' is unsupported format
My system environment is macOS, M1

thanks @nairoj, google colab can do this task
https://github.com/acl-org/aclpubcheck/issues/7#issuecomment-1066400475


CREATE SOURCE syntax

Hey, took a look, and looks like it still needs:

Test cases showing the CREATE SOURCE syntax in action
Protobuf AST that lets us access CREATE SOURCE from the Go side (so we can implement the connection)

Closing in favor of https://github.com/rilldata/rill-developer/pull/931


when I started atom,my own app started at the same time.

hi~
I got a problem about atom and my own app(developed by electron).
when I started atom,my own app started at the same time.
I was confused. Is there any relationship between them?
my atom  version:1.9.8
my electron version:1.1.3
my OSX version:10.11.2
THX!

Please completely fill out the provided issue template.


Fix broken OWNERS files

This member was removed from the org, so now any update to an OWNERS
file will trigger a check that will fail

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [howardjohn]
tests/e2e/tests/pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [howardjohn,nmittler]
tests/e2e/tests/pilot/OWNERS [howardjohn,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
65ce746c6aac8c3cff97a1b2156a2d13d9feae1d
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, howardjohn, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [geeknoid,howardjohn,nmittler]
tests/e2e/tests/pilot/OWNERS [geeknoid,howardjohn,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add crash monitoring tool

Crashlytics and Sentry Android are both seemingly good options, worth doing more research to decide

Implemented in #33


Symbol flickers on state change

Is this due to symbol being redrawn each time the state gets updated?
It sure feels like a bug

same here

@adewalegeorge do you know how to use symbols on CSS Background?

Hi @ourfamilygithub,
Any link or repo to see/reproduce this issue?
Never experienced this behaviour…
For SVG symbol and CSS background, you can use fragment identifier.
Cheers

I'm having the same issue on Google Chrome & Safari when the sprite is bigger dan 10kb. No issues on FireFox. Every state change the .svg file is loaded, always with a status of 304.

Never mind, I found the issue. Had a limit of 10kb in the webpack config rules, make it higher or delete it solved the problem.
{         test: /\.(png|jpe?g|gif|svg)(\?.*)?$/,         loader: 'url-loader',         options: {           limit: 10000,           name: utils.assetsPath('img/[name].[hash:7].[ext]'),         },       },


Unused parameter in C++ generated code

What version of gRPC and what language are you using?
master
What operating system (Linux, Windows, …) and version?
linux
What runtime / compiler are you using (e.g. python version or version of gcc)
clang 6.0.0
What did you do?
define a streaming method, try compiling C++ code with -Wextra
What did you expect to see?
code compiles
What did you see instead?
./port_fwd_service.grpc.pb.h:90:48: error: unused parameter 'context' [-Werror,-Wunused-parameter]
    ::grpc::Status Conn(::grpc::ServerContext* context, ::grpc::ServerReaderWriter< ::dw::PortFwdFrame, ::dw::PortFwdFrame>* stream) final override {

Anything else we should know about your project / environment?

C++ code generated for streaming methods contains functions with unused arguments that trip up compilcation with -Wunused-parameter (part of -Wextra).
In particular, the issue is with the stubs for synchronous versions of methods generated here and in a few other places - context and stream end up unused.
This is similar to https://github.com/grpc/grpc/issues/6518 but ina different place.
A simple C++ compile test with -Wextra would catch this.

hm. i don't see any added complexity, per se - just throw a bunch of (void) arg1; at the end.
it will increase the size, sure, but not complexity.
since this particular is in the generated header, it effectively prevents use of -Wunused-parameter on the entire project (if it only applied to c code i could've isolated it by applying only to generated sources).
so please, if you don't plan to address it systematically, at least fix this particular instance for now.

This is also effecting a project I am working on and it's not really possible to generated files from the gRPC compiler.  Right now we are doing:

Hi there,
i'd like to suggest a simple solution for this class of problems with the generated code.
As far as i can read the code, the problem stems from disabled methods like in:
https://github.com/grpc/grpc/blob/master/src/compiler/cpp_generator.cc : line 792
  if (method->NoStreaming()) {
    printer->Print(
        *vars,
        "// disable synchronous version of this method\n"
        "::grpc::Status $Method$("
        "::grpc::ServerContext* context, const $Request$* request, "
        "$Response$* response) override {\n"
        "  abort();\n"
        "  return ::grpc::Status(::grpc::StatusCode::UNIMPLEMENTED, \"\");\n"
        "}\n");

The compiler warns us, that we didnt use "context", "request" and "response" - understandable, but we dont want to change the method-signature and dont want to forget the variable name.
So we change the code by hiding the varable-names from the compiler (using comments /* and */):
  if (method->NoStreaming()) {
    printer->Print(
        *vars,
        "// disable synchronous version of this method\n"
        "::grpc::Status $Method$("
        "::grpc::ServerContext* /*context*/, const $Request$* /*request*/, "
        "$Response$* /*response*/) override {\n"
        "  abort();\n"
        "  return ::grpc::Status(::grpc::StatusCode::UNIMPLEMENTED, \"\");\n"
        "}\n");

This leads to the compiler not complaining (no warning anymore), the signature remains the same and the readability does not suffer.
As my company would like to change the existing communication infrastructure to grpc and we have a strict no-warning policy, i would offer to adapt the code in this way...
Is my reasoning correct?
Would you possibly accept merge requests?
Regards,
Christian

This should be closed, as it is already fixed at the master branch...


[Bug] Material 3 Theme User dialog tab wrong arrow direction

Describe the bug
User dialog tab wrong arrow direction
with Material 3 theme
Screenshots

What version you are running
Version 2024.3.23

is a well known issue, but ive been unable to fix it, the css in this app uses libraries so small changes can break other unrelated views.


Fix for using EC2 IAM credentials for S3 access

Continue without AWS env vars if the config doesn't exist
Possibly fixes #44 and #88

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

Jenkins, add to whitelist.

This certainly seems like a reasonable fix to me, LGTM; ping @bacongobbler @mboersma


Command 'Delete all Interactive Cells` available when a python file is in focus

Confusing command, this only applies to Interactive window, hence should be enabled only when an interactive window is in focus.

Not worried about this.


drop configmap in favor of distroless certs

Codecov Report

Merging #46 (8254497) into master (30d7005) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   85.17%   85.70%   +0.52%
==========================================
  Files           9        9
  Lines        1140     1140
==========================================
+ Hits          971      977       +6
+ Misses        111      107       -4
+ Partials       58       56       -2

Flag
Coverage Δ

unittests
85.70% <ø> (+0.52%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

collector/prometheus.go
92.92% <ø> (ø)

controllers/kokumetricsconfig_controller.go
71.42% <0.00%> (+2.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d7005...328077a. Read the comment docs.


add id field to the NodeTypeRequest for easier integration with Terraform's databricks_node_type data source

Codecov Report
Patch and project coverage have no change.

Comparison is base (31c3ddb) 41.20% compared to head (3f719f1) 41.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   41.20%   41.20%
=======================================
  Files          46       46
  Lines        2682     2682
=======================================
  Hits         1105     1105
  Misses       1487     1487
  Partials       90       90

Impacted Files
Coverage Δ

service/clusters/node_type.go
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Introduce JSX and Composition API

Demonstrating integration of these two features. I opted not to replicate slots/scoped slots in the Element UI table, instead re-implementing as a simple HTML table.
@LachlanStuart let's check if the config changes don't cause you any issues in Webstorm.

... it's breaking CI apparently

It's now failing on a snapshot, but I would say the new one looks more correct - it's actually rendering data. Would appreciate a second opinion.

Also, don't worry about the "codecov" test failing - we mostly use it for tracking the coverage trend and as a reminder when we should consider adding more tests. However, quite often it's a false alarm, because it sometimes compares against previous commits in the same PR instead of comparing against the coverage in the master branch.

@intsco there seem to be some commits from you in this PR, not sure if this is ok?

@richardgoater It looks like you based this branch off of the branch for PR #520, which has since been merged.  Ideally you'd rebase this branch off of those commits on to master. It's optional this time though - the files changed by those commits exactly match the files in master, so GitHub isn't complaining because it can merge without conflicts.


flutter/flutter] Flutter Bug Filing (Issue #129922)

Debug

@Hayourm Please stop leaving random comments and opening random bugs and PRs.


Alias "celocli releasegold" commands to also work for "celocli releasecelo"

Question from Tim on Slack:

can we alias celocli releasecelo commands to also work for celocli releasegold ?

to be clear: when I type celocli releasecelo ** i should receive same behavior as what currently happens for celocli releasegold **

to be clear: when I type celocli releasecelo ** i should receive same behavior as what currently happens for celocli releasegold **

Yes, that's my understanding.


Fix(mwpw:160737): Favicon fix for safar pinned tab

safari fav icons will display favicon-180.png as fallback for safari version 16.

Resolves: MWPW-160737
Test URLs:

Before: https://main--milo--adobecom.hlx.live/?martech=off
After: https://favicon--milosh--sharath-kannan.hlx.live/?martech=off
cc test url
https://mwpw-160737--cc--sharath-kannan.hlx.live/creativecloud?milolibs=favicon--milosh--sharath-kannan

Valdiation done in pr in safari browser in Mac safari version 16.6 and iphone safari, able to see favicon and new logo coming up when clicked on add to home screen

closed PR since this is not needed.


[Components] Triple representation of node groups

I’m seeing triplicates.
Slack Message

needs a Meshery release


Nested Objects (not arrays) break for loops

I'm having trouble using nested objects in for loops on 0.11.2.
I checked out https://github.com/paularmstrong/swig/issues/83, however it is using nested arrays, so i'm wondering if thats why it works and mine does not.
{% for role in roles %}

	{{ role.name }}

		{% for key in role.keyring %}
			{{ possiblekeys[loop.key].method }} {{ possiblekeys[loop.key].route }}
		{% endfor %}

{% endfor %}

This will create the first row and iterate through the first nested object, however every row after where the first nested object occurs has no data.
roles
[
	{
		id: "743h789n3gf439",
		name: "Moderator",
		keyring: {
			"5342nj5i23n63i4j643": true
		}
	}
]

possiblekeys
{
	"5342nj5i23n63i4j643": {
		id: "32b5i23b5i25",
		hash: "5342nj5i23n63i4j643",
		method: "GET",
		route: "/dashboard"
	}
}

thatz really awesome


Issue DSB; ISB after changing FPU status to ensure completion

This is necessary according to ARM, I suppose if some VFP op got scheduled right after an inlined FPU enable it would be trouble.

This is necessary according to ARM

Could you add a comment with a link to the documentation that states this?
Are these instructions also required when disabling the FPU? If so, shouldn't they be called before disabling the FPU? Wondering if the pipeline may execute the CPACR write while some floating point op is in progress or something like that.

Actually now that I look again, Cortex-M4 TRM does not say that DSB/ISB are required:


Typography component doesnt show its props

Usually in the other components you can see all its props and the values for each one of it, for example the next props: variant, color, etc, but in typography component you cant see that.

i have the same problem


Update image ghcr.io/zoriya/kyoo_transcoder to 6905d0d

This PR contains the following updates:

Package
Update
Change

ghcr.io/zoriya/kyoo_transcoder
digest
6ffff81 -> 6905d0d

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Unclear how to use spacing values

I went here looking for how to reference spacing values.
I expanded the "spacing" item, but nothing is there:

we're using MUI's spacing guidelines - https://mui.com/material-ui/customization/spacing/
let's make sure it's more apparent from our Varnish docs

done


$replace rules with escaped $ don't work

Rule: wikipedia.org^$replace=/\$100/test/
Link: https://en.m.wikipedia.org/wiki/United_States_one-hundred-dollar_bill
Checked in the latest AdGuards for Windows and Android, and in AdGuard for Android 3.7

@Alex-302, the rule should look like this:
wikipedia.org^$replace=/\\$100/test/

You escape the $ because it is reserved as a character that separates the modifiers from the pattern: \$.
Then you must escape the escaped $ because it has a special meaning in a regular expression: \\$.
Note that \\\$ would give incorrect results: \ itself doesn't have to be escaped in our rule's syntax.

@Alex-302 Update:
Although, we can probably reliably tell the $ inside a regex apart from the $ that's separating the pattern from the modifiers, so we can probably omit the requirement that a $ must be escaped in a regex. This needs more testing, though. I'll get back to you on that.

@Alex-302
Unfortunately, on closer inspection, it doesn't look possible. Since a URI can include $, = and = without percent encoding (https://datatracker.ietf.org/doc/html/rfc3986#appendix-A), we take the last $ not preceded by \ as the pattern/modifiers separator. Thus, a $ in a regex pattern in a rule must always be preceded by \ in order to not be confused with the pattern/modifiers separator. So, my earlier comment stands: https://github.com/AdguardTeam/CoreLibs/issues/1846#issuecomment-1932079508

thanks


part2: calcom-app-dir: generateMetadata

Current dependencies on/for this PR:

main

PR #456   👈

This stack of pull requests is managed by Graphite.


Force deletion of a project

Currently, when a project contains repositories, the deletion of a project will fail. Registryman shall provide a CLI flag that would enable the force deletion of the Project, i.e. registryman would delete the repositories before the project deletion.

#34


Support [@nobuiltin]

I'd expect the following to work
type unit = { x: int ; y: string } [@@deriving yojson]
type has_unit = { u: unit [@nobuiltin] } [@@deriving yojson]

I've run into this too -- I'd like to use ppx_deriving_yojson for nested data structures, but it blows up on anything that isn't a builtin type.


Integration hangs on loading screen even after having succesfully set MQTT bridge

Hi,
After launching the integration setup, and entering the TV MAC Address:

the TV Shows the 4 digits code, but the integration doesn't move from the following screen:

I tried already to change browser, (I tried Opera, Edge and Chrome) and also the mobile APP.
Any ideas?

I have the same problem, did you find a solution to this?

Unfortunately I can't reproduce your behaviour.
Is your screenshot from before you enter the code or after you submit it?
Have you checked your HA logs for any error?

The screenshot is from before I enter the code, it stops there, I have never been able to enter the code.
I did check HA logs and unfortunately I can't find any related error.

i dont know if i have the same issue but it looks kinda similar.
i enter all the required information an press the create button and than it hangs at the spinning animation.
i'm running home assistant on docker and have my mqtt server in a another docker container.
my guess is, that the integration tries to create the mqtt bridge which fails, because it doesnt have the ability to change the mqtt server.
it seems that i got the mqtt brigde going with manual config (atleast mosquitto said, it created a connection), but home assistant didnt discover the tv like im familiar which normally happens when i use other integrations.
maybe it just doesnt do that.
thb i'm just guessing here because neiter familiar with the structure of home assistant integrations nor python as a language.
if the "integration doesnt have ability to change mqtt server" theory is correct, than maybe a viable workaround for that could be, that the integration asks for all the information it does now, than it trys to create bridge and if it fails, it will print out the bridge config for mosquitto, so it can be added manually and the mosquitto docker be restared.
when the mqtt bridge is working, there shouldnt be anything stopping the integration from proceeding the configuartion as normal.

No, the integration does not modify and cannot create the MQTT bridge nor the broker. You have to set up the bridge yourself. Your Docker setup shouldn't be a problem. My setup is similar.
Auto-discover isn't implemented - if someone has experience with that I would appreciate support.
Do you see messages from your TV under the configured prefix on your mosquitto broker?

I got it running now.
Sorry for bothering you.

Awesome stuff you are doing, really made my day :).

I finally have it working, It was a browser problem, I was using Opera, I tried to set it up using Chrome and it worked at the first attempt.
Thank you @sehaas for all.


Measure rebroadcast time so we can check we're setting the slot time correctly

We should measure this on a handful of node types on a handful VPSs

Closing this issue as it is stale for a long time.


bug(mat-checkbox): detectChanges does not work in detached mode

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Running detectChanges()  for components with changeDetection: ChangeDetectionStrategy.OnPush does not work as expected
Reproduction
Here is a simple stackblitz to test the Problem (https://stackblitz.com/edit/angular-4csuvx?file=src/app/checkbox-reactive-forms-example.ts)
Expected Behavior
The checkbox should reflect the state of the model after a call to detectChanges()
Actual Behavior
The checkbox is out of sync with the model.
Environment

Angular:
CDK/Material:
Browser(s):
Operating System (e.g. Windows, macOS, Ubuntu):

I have updated the stackblitz with a hack to solve the problem: detectChanges() has to be called a second (in a setTimeput) to update the component correctly


Access the landing page

[ ]  Requirement 1: Landing page has a top navigation bar with the following menu items: ‘About’, ‘ Resources’, ‘Contact’
[ ] Requirement 2: Landing page has entry points to three different sections: Data, Narratives, Research
[ ] Requirement 3: Landing page has an inspirational hero image or video reflecting Black women in STEM

Note: Replace requirements above with canonical menu items and sections from final Figma mock.


WIP: Rewrite how arguments are passed

We're not passing all possible arguments to dear-imgui functions. This is my proposal of something lightweight.

I agree that we need something that emulates the functionality of named parameters, but I find this approach to be rather syntactically heavy.
How are optional fields handled? For instance we have:
DragFloat4(const char* label, float v[4], float v_speed = 1.0f, float v_min = 0.0f, float v_max = 0.0f, const char* format = "%.3f", ImGuiSliderFlags flags = 0);

with this approach we have a record
data DragFloat4 =
  DragFloat4
    { label :: String
    , value :: StateVar (Float, Float, Float, Float)
    , speed, minValue, maxValue :: Float
    , format :: String
    , flags :: ImGuiSliderFlags
    }

now format, speed, minValue, maxValue and flags all have default values, and the others don't.
Generally, I think I would prefer keeping the basic bindings as is (as you argued for in the past), and then provide various convenience wrappers that handle optional arguments and named arguments in extra modules.

Usually I would supply a default DragFloat4 record and use record updating. The problem is as we use duplicate record fields that won't infer with type annotations :/

But you'd want a type error if the user doesn't pass in one of the required arguments, no? I don't think that there are sensible default records in general, there are only defaults for a subset of the fields.

Oh, right, yes. I wouldn't supply defaults for required arguments. This leaves us with:

defDragFloat4 :: String -> StateVar ImVec4 -> DragFloat4, so you have to supply the required arguments but the rest are filled in with defaults. Record update is messy here, as you end up with (defDragFloat4 foo bar) { x = y, u = v }, which I find a mess. It also has all the type inference problems due to DuplicateRecordFields
All parameters that can have a default can be wrapped in Default a (isomorphic to Maybe a). Then we would have dragFloat4 DragFloat4{ label = "xyz", value = someStateVar, speed = Default, minValue = Default, maxValue = Default, format = Default, flags = Default }. This is quite heavy, though.

It's that, or we're going to have to have two versions of every function with defaults.

Generally, I think I would prefer keeping the basic bindings as is (as you argued for in the past), and then provide various convenience wrappers that handle optional arguments and named arguments in extra modules.

Or maybe you have something else in mind here? Could you sketch out what that would look like for dragFloat4, which seems to be particularly pathological?

Or maybe you have something else in mind here?

Well my point was more that I can imagine several ways to go about it: using extensible records, using type classes, using overloaded labels, etc. So I thought it would be best not to commit to any one approach, unless we can find a clearly superior solution.

Ok, but we certainly need to do something. Will have a think. I'm quite reluctant to introduce anything that I'd describe as "novel". How about we have dragFloat4 as is in main and dragFloat4Full :: Drag4Float -> m () which is what's in this PR? dragFloat4 essentially calls dragFloat4Full and fills in the extra fields with defaults. That does seem to give us everything without too much commitment to any particular approach. It's a bit of duplication, but I can live with that.

I'm trying to whip something up with generic-lens, basically a customised version of the Subtype lens that works with explicitly labelled types instead of record field names.
I've managed to set it up with decent error messages IMO:

data Label ( lbl :: Symbol ) = Label
instance ( lbl' ~ lbl ) => IsLabel lbl ( Label lbl' ) where
  fromLabel = Label
data ( lbl :: Symbol ) := ( a :: Type ) = Label lbl := a

-- | 'project' a smaller type out from a larger one, discarding the rest.
class Project big small where
  project :: big -> small

-- [ Omitted: instances with custom type errors using generic-lens machinery ]

-------------
-- Examples

projOK1 :: ( "b" := Float, "c" := Int, "a" := Double ) -> ( "a" := Double, "b" := Float )
projOK1 = project

projOK2 :: ( "b" := Int, "a" := Float )
projOK2 = project ( #a := 17.7, #b := 9 )

projErr1 :: ( "b" := Float, "a" := Bool, "c" := Double ) -> ( "c" := Double, "b" := Int )
projErr1 = project
-- * 'project': no instance for
--       Project
--         ("b" := Float, "a" := Bool, "c" := Double)
--         ("c" := Double, "b" := Int)
--   The type being projected down is missing the following fields:
--     - #b := Int

projErr2 :: ( "b" := Float, "c" := Int, "a" := Bool ) -> ( "a" := Bool, "b" := Float, "d" := Int )
projErr2 = project
--  * 'project': no instance for
--        Project
--          ("b" := Float, "c" := Int, "a" := Bool)
--          ("a" := Bool, "b" := Float, "d" := Int)
--    The type being projected down is missing the following fields:
--      - #d := Int

projErr3 :: ( "b" := Int, "a" := Int )
projErr3 = project ( #a := 17.7, #b := 9 )
-- * No instance for (Fractional Int) arising from the literal `17.7'

projErr4 :: ( "a" := Bool, "b" := Int, "b" := Int ) -> ( "b" := Int, "b" := Int )
projErr4 = project
--  * 'project': no instance for
--        Project
--          ("a" := Bool, "b" := Int, "b" := Int) ("b" := Int, "b" := Int)
--    The following duplicate fields cause a problem:
--      - [ Both] #b := Int

Unfortunately I couldn't directly re-use Subtype as the inference doesn't constrain fields of the same name to have the same type, which would prevent the projOK2 example above from type-checking (because numeric literals are polymorphic).
The above handles projecting down the collection of given arguments to extract the required arguments. To handle optional arguments, there's a similar setup with the following typeclass
-- | 'inject' a smaller type into a large one, overriding the fields
-- in the larger type with those from the smaller type.
class Inject small big where
  inject :: small -> big -> big

With this setup, the type signatures would look like
dragFloat4
  :: forall args m req opt
  .  ( MonadIO m, Project args req, Inject args opt
     , req ~ ( "label" := String, "speed" := Float, "value" := StateVar ( Float, Float, Float, Float ) )
     , opt ~ ( "minValue" := Float, "maxValue" := Float, "format" := String, "flags" := ImGuiSliderFlags )
     )
  => args
  -> m Bool

and the syntax is quite nice:
dragFloat4 ( #label := "hello", #speed := 3.4, #value := valueRef )
dragFloat4 ( #label := "hello", #flags := ImGuiSliderFlags_Logarithmic, #speed := 3.4, #value := valueRef )

Any thoughts? I'll try to polish up the functionality and put it up as a library.

RecordDotSyntax in GHC 9 enables nicest (and much anticipated) record access syntax. With it, the described approach is possible and very handy. Optional fields are usually handled through Maybe type (which is converted to null).

the described approach is possible and very hand

Do you mean the approach in my PR?

Do you mean the approach in my PR?

Yes, like that. Though, it suits better for low-level bindings (#61), and concise shortcuts are still in demand.


FR: Modal timeout

Please consider an automatic closure of any open modal after some period of inactivity.

https://github.com/matt8707/ha-fusion/pull/141

@matt8707 continuing here - is there any way now or a plan to have similar event to navigate directly to a certain view? The use case would be like with popups - when the screensaver kicks in, just move to the default view.

I think that with the fullykiosk integration you can set a url in same automation as close popup

Indeed, it works. Thanks!