Final Group Capstone - Rent a Car - Back-End

In this pull request, @yosaddis, @PabloEGonz and I implemented the following features:

Created user authentication for login and registration.
Created necessary API endpoints for Users, Cars, and Reservations.
Created a CRUD functionality for Cars
Created a CRUD functionality for Reservations

Additional Features

Extended the API to support car deletion, including the ability to mark cars as removed from the database
Implemented API endpoints to retrieve and display user-specific booking form to rent a new car
Implemented API endpoints to retrieve and display user-specific booking information for list of rents.
Followed gitflow.
worked in a professional way.
Fix linter errors.

Create a unit test for each model.

A link to our front-end pull request:

full-stack-capstone-front-end

Important :red_circle:

Kindly open the render-deployed back-end link before opening the front-end live demo due to the cold start in the back end deployed in render.
If you get an JSON error when you open the front-end page, go to the local storage and delete the key.

Hi @Meltrust. We thank you very much for your tips and feedback that surely imporves our project features and functionality.


Bug: Menu gets triggered by ARROW LEFT and ARROW RIGHT keys

Hi there,
currently if someone press ARROW LEFT or ARROW RIGHT key while the focus is on the input field, the highlight in the menu disappear. Tested with the static data example. It doesn't matter if there is some text in the field or not, I didn't inspect this issue any further, there might be more related background issues.

Thanks for letting us know! This was fixed in 5d61876fa5a96114d65dbfa3a0a85e3257a415ca which is a part of 1.4.4.


Show info about the workflow in tree view

In GitLab by @jvegreg on Jul 6, 2020, 11:45
Hi
I am very happy with the GUI, but I miss a couple of things in the tree view:

It will be nice if the dependencies of the selected node are show in the side panel. I noticed the out and the in buttons, and understand that there may be no enough space, but the extra clicks are a bit annoying.

Related to that, it will be great if those list also displayed the status of the jobs, so you don't have to look for them in the list

@wuruchi

In GitLab by @wuruchi on Dec 11, 2020, 10:34
Hello @jvegreg
Thank you for your suggestion, and sorry about the very late response.
We will include the status in the view of the dependencies.
About your first suggestion, I've been thinking about it and I think the best place could be some kind of floating tile on the side of the graph or tree representation.
I will post here as soon as we have something to show.
Thank you.

In GitLab by @wuruchi on Dec 11, 2020, 12:02
Hello again @jvegreg
The children and parent lists have been updated and now show the job status.


One macro to include lints

This PR removes a duplicated list of lints in the source code of the project.
Previously, there was a list of paths to lints in src/query.rs:SemverQuery:all_queries() and a list of lint names in src/query.rs:tests:query_execution_tests!(). This PR replaces the query_execution_tests macro with a macro add_lints to generate the tests (just like the previous macro) and to generate a function that returns the list of queries' contents.
The reasoning behind doing this change is that it will be a bit easier to add a new lint (and less room for a mistake). The ideal solution (in my opinion) would be to have a file listing all the lint names in the src/lints/ directory and then have a macro that reads the file and generates the tests etc, but I don't know how to do it with my limited Rust knowledge.
@obi1kenobi please comment whether you like the idea behind this PR and whether you have any ideas about how to do the above mentioned macro.

Oh, it might be a good idea to update CONTRIBUTING.md as well, since I think some of its instructions will be outdated after this PR merges.

Ups, I didn't know about the existence of this file. My recent PR already made some changes that made this markdown file not up-to-date. I'll create a PR to solve that.

If you can resolve the merge conflict, this is good to go 🚀

Here you go: https://github.com/obi1kenobi/cargo-semver-checks/pull/204/commits/345ea946d1ba9630b63b568d308f964f5dc62763
I tried to make the changes so that a merge conflict wouldn't happen, but I failed, sorry.


Engine: add utility to make a item -> item (resp expr, ty...) function a phase

In the backends, it's nice to apply in sequence a number of phases.
Phase usually rewrite items mapping them from some AST with a certain feature set to another feature set.
Some operation, such as function reordering, are not seen as phases because they don't change the type of the items they deal with.
We should have a small utility function that transform simple AST maps into PHASE modules.

That was done by f76b2f73c (functor Phase_utils.MakeMonomorphicPhase)


Add FASM features for DI1MUX's to ensure that ADI1 connection is valid.

An error will result if the ADI1 connection does not match the BDI1
connection.
Does requires genfasm fix, tracked https://github.com/SymbiFlow/vtr-verilog-to-routing/issues/280 .  Plan is to update VTR with this change after https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1017 is merged, (FYI @acomodi)

Merged in https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1036


Audience is null for Direct Line Extension situations

Version
Current main
Describe the bug
Audience is null
To Reproduce
Steps to reproduce the behavior:

Follow https://docs.microsoft.com/en-us/azure/bot-service/bot-service-channel-directline-extension-net-bot?view=azure-bot-service-4.0
Follow https://docs.microsoft.com/en-us/azure/bot-service/bot-service-channel-directline-extension-webchat-client?view=azure-bot-service-4.0
Say hi
See error 502 in webchat and in app service, we could find that audience is null.

In step 1, if one uses app.UseNamedPipes(System.Environment.GetEnvironmentVariable("APPSETTING_WEBSITE_SITE_NAME") + ".directline", "https://api.botframework.com");, it will work correctly.
However, if we change "https://api.botframework.com" to other audience, it will not work.
Expected behavior
Work correctly.
Screenshots

Additional context
After some investigation, I found the problem involves three parts:

Direct line extension (or streaming) expects custom audience to work https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/StreamingRequestHandler.cs#L321
We require audience now https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs#L139
We return null for custom audience https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs#L325

One fix could be return callerId as audience when not match in function GetAudienceFromCallerId

Thank you @xieofxie for filing the issue and including this very helpful information!
To avoid typing magic strings, the following constants in the Microsoft.Bot.Connector.Authentication can be used:
For bots in Public Azure, please use AuthenticationConstants.ToChannelFromBotOAuthScope.
For bots in US Government Azure, please use GovernmentAuthenticationConstants.ToChannelFromBotOAuthScope.

In step 1, if one uses app.UseNamedPipes(System.Environment.GetEnvironmentVariable("APPSETTING_WEBSITE_SITE_NAME") + ".directline", "https://api.botframework.com");, it will work correctly.
However, if we change "https://api.botframework.com" to other audience, it will not work.

@xieofxie, can you share more information about the statement where using a different audience won't work? Does "other audience" mean a null value?
If you're for example using "test" as the audience and it fails, can you share the exception and more information?

Thank you @xieofxie for filing the issue and including this very helpful information!
To avoid typing magic strings, the following constants in the Microsoft.Bot.Connector.Authentication can be used:
For bots in Public Azure, please use AuthenticationConstants.ToChannelFromBotOAuthScope.
For bots in US Government Azure, please use GovernmentAuthenticationConstants.ToChannelFromBotOAuthScope.

In step 1, if one uses app.UseNamedPipes(System.Environment.GetEnvironmentVariable("APPSETTING_WEBSITE_SITE_NAME") + ".directline", "https://api.botframework.com");, it will work correctly.
However, if we change "https://api.botframework.com" to other audience, it will not work.

@xieofxie, can you share more information about the statement where using a different audience won't work? Does "other audience" mean a null value?
If you're for example using "test" as the audience and it fails, can you share the exception and more information?

@stevengum To be honest, I don't know the function of audience here. My comment just comes from the code:
Here it states Fallback to using the raw Audience as the CallerId:
https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/StreamingRequestHandler.cs#L321
However when we process the activity, it will return null if it is not public, gov nor skill, so we will face the same error:
https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs#L325

@stevengum To be honest, I don't know the function of audience here. My comment just comes from the code:
Here it states Fallback to using the raw Audience as the CallerId:
https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/StreamingRequestHandler.cs#L321
However when we process the activity, it will return null if it is not public, gov nor skill, so we will face the same error:
https://github.com/microsoft/botbuilder-dotnet/blob/e90ba0b131c0e24d82e2c9ca2cb4d6fce272db33/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs#L325


Support more properties for markdown hover span styling

const markdown = new MarkdownString(undefined, true);
markdown.isTrusted = true;
markdown.appendMarkdown(`<span style="color:#7cc54b;">$(pass)</span> `);

Currently markdown hover supports only color & background-color. It would be great to expand that list to:
padding
border
border-radius
font-size
Since color and background-color support only a subset of possible values (6digit hex color) - it would make sense to also only support a limited number of values (6digit hex + px for size)

Given that we want to have markdown hovers have a somewhat unified look, I don't think that we'll be expanding the set of allowed style properties.
This is also a game of whack-a-mole. There will always be more properties that extension developers want. If we do decide to support additional values, the solution probably isn't to handpick more values to support, but instead to use an iframe and allow html.


Sorry, I can't fix the path during use, can I record video?

Sure

Heya, did you figure this out? Can the issue be closed?


fontspec cannot be loaded after babel any longer

With the latest versions of both babel and fontspec, this mwe compiled with lualatex:
\documentclass{article}
\usepackage[english]{babel}

\usepackage{fontspec}

\begin{document}
Hello world.
\end{document}

gives me this error:
ERROR: LaTeX error: "kernel/command-already-defined"

--- TeX said ---
!
! Control sequence \latinencoding already defined.
!
! See the LaTeX3 documentation for further information.
!
! For immediate help type H <return>.
!...............................................

l.121 \tl_new:N \latinencoding

pointing to l. 121 of fontspec-luatex.sty
If fontspec is loaded before babel, the mwe compiles. Are we now supposed to mind the load order of the two packages?

Apologies, this is an oversight. Thanks for letting me know.
Until I fix the bug and make a new release, you can work around the issue as follows:
\usepackage[english]{babel}
\let\latinencoding\relax
\usepackage{fontspec}
(or revert to the previous version)

Many thanks!  I already did \let\latinencoding\relax: everything is now back to normal.


Is it possible to support insert mode mapping?

As title. It seems that one can only make use of one command :HFccSuggestion. And this forces us to get a suggestion in normal mode. It will be more natural if we could trigger it in insert mode. Thanks!

I agree! I was thinking of implementing what other similar plugins do where suggestion is triggered while typing, avoiding the need to use a command.

This sounds great!
At first, I was looking into making a visual mode mapping
Just pieced together a insert mode mapping.
This imap works for me for python code completion:
inoremap <c-f> <esc>:HFccSuggestion<CR>

Not sure what a good default mapping would be (maybe leader hf), but may be better to be really easy using the home keys if the user will be using this invocation pretty often.

Just a heads up, I'm currently working on this (best effort).
I was wondering, should I keep the HFccSuggestion command as it is or should I remove it?

It depends on you :)
My opinion just for reference: You could: 1) keep the command so that those who are using it will not experience the break, and provide an option to opt out of the command creation. 2) Just let it break since you have clearly said in your README the project is at the WIP stage.

Alright, I've just merged the work from #15, let me know what you think!

@McPatate How do I enable it by default? Insert mode suggestion, is it possible to set it via setup?

It's enabled by default, currently not possible to turn it on/off via setup


Unable to build in devcontainer

What version of astro-expressive-code are you using?
0.35.3
What version of astro are you using?
4.11.5
What package manager are you using?
pnpm ( seems to be the same with npm )
What operating system are you using?
Mac
Describe the Bug
When I run astro ( pnpm run dev ) in my devcontainer, the build freezes without throwing any error.
Note : It works as soon as I remove astro-expressive-code from the dependencies.
Link to Minimal Reproducible Example
https://github.com/QuentinLCS/astro-starlight

Thank you for the report. I unfortunately have no idea what devcontainers are and never used them, so I don't have an idea how to even test this. Is there any more information you can provide or is there anyone familiar with devcontainers to help?
The log.txt in your example does not seem to match your code. The code does not use Starlight (commented out), but the log shows Starlight.
Just to be sure: There is no need to add both Starlight and Expressive Code in your Astro config. Starlight already comes with Expressive Code built in.

You're right, the log.txt can be ignored. I forgot to delete it. I first thought that it was a Starlight error, my bad !
By installing the vscode recommended extension, you should be able to run the workspace in a docker container.
Once started, running Astro with the dependency will result in a freeze.

I don't use Docker, so I cannot reproduce this myself. Is there any sort of log available that allows you to see why it's freezing? Is this also freezing on a regular fresh Starlight project without any changes?

Is there any sort of log available that allows you to see why it's freezing?

I have 0 logs running pnpm run dev --verbose

Is this also freezing on a regular fresh Starlight project without any changes?

It is

Hmm. Could you be hitting some sort of default memory limit in your devcontainer? Maybe there are devcontainer config options you could increase?
If it's a memory issue, the only part of EC that uses a lot of memory is Shiki. You could try disabling the default Shiki integration by passing shiki: false in the EC configuration options and see if that helps.

IIUC you can also test a devcontainer using GitHub CodeSpaces right?
I tried opening https://github.com/QuentinLCS/astro-starlight in a CodeSpace and it seemed to work fine, but maybe I’m doing something wrong. (Had to update an import in src/content/config.ts that was still loading Starlight although not installed, but apart from that the dev server seemed to be working.)

I tried opening https://github.com/QuentinLCS/astro-starlight in a CodeSpace and it seemed to work fine

I didn't try in codespace and it runs well. I don't know if codespace is built differently or if the problem occur only on apple silicon

Coming back to this issue, I just performed some reproduction attempts.
I set up Docker and the VS Code devcontainers extension on two of my machines (one running Windows 10, one running macOS Sonoma), and was able to successfully build the entire EC repo including its Starlight-powered docs site, as well as a plain Starlight starter project, both of which you stated didn't work for you.
Please note that my macOS machine is a Macbook Air with M1 chipset, so Apple Silicon is probably also not the source of your issues.
However, what I found online is that there are many open issues concerning devcontainers on macOS hosts in general (nothing specific to EC). Some users report that pnpm fails to install packages properly when reopening a workspace in a devcontainer as offered by VS Code, as pnpm fails to create hardlinks to the installed packages in this scenario. As this is something I encountered as well on macOS during my testing (but only when using pnpm), I committed a fix to EC's own devcontainer file that now runs pnpm config set store-dir ~/.local/share/pnpm/store before attempting to install any packages, which solves this issue. However, as you reported that the issue seems to be the same for you with npm, I also don't think that this is the cause of your problems.
Long story short, after all the testing I've done, I'm unable to reproduce your issue. Combining this with the fact that no other EC or Starlight users have reported any similar issues, I believe that the cause must be something in your own hardware or software configuration. I'm therefore closing this issue now. Happy to reopen in case there are any new findings!

Update :
I observed that you used Node 18.20.4
Using this version, it works well.
Upgrading to node 22.7.0 makes it fail as described

This sounds like an interesting lead, I'll give it a try soon and keep you posted.

I just built the entire EC repo successfully on a Windows host with the image typescript-node:22-bullseye, which uses Node v22.6.0 by default.
Afterwards, I ran nvm install 22.7.0 to switch to your failing Node version, verified that it's actually being used through node -v, and then reran pnpm astro build in the docs folder to build the Starlight-based EC docs site again. This also completed without any errors.
In other words, sadly, the Node version alone also doesn't seem to explain the errors you're encountering on your machine. It might be useful if you could try it on a different development machine to ensure your setup isn't the cause of the issue.

...and now I can also confirm that it works fine on my Macbook Air with M1 chipset, as you mentioned Apple Silicon being a potential source of the issue earlier. I just repeated the same steps as described above there and could also build the EC repo including its Starlight docs there with Node v22.6.0 and v22.7.0.

Even with pnpm astro build ?

Even with pnpm astro build ?

Yes. I followed exactly the same steps as mentioned before.

Weird, I'll try to use your image with node 22 as you did

It seems like it works with typescript-node:22-bullseye but not my custom docker image, I'm looking into it

No reason found, since it works with the typescript-node image, I'll customize mine base on this one.
Thanks for your help :)

Sure thing, glad we found a solution that works for you! Happy coding :)

I have an hypothesis.
I still have the issue when my Docker image is built by the GitHub Actions even with the "typescript-node".
But it works when I create a local Dockerfile, built locally.

I have no idea, sorry! :(
Honestly, right from the beginning, this entire issue looked like not actually being caused by EC, but like some machine/platform incompatibility or issue that just happens to get randomly triggered by the presence of EC due to an unknown reason.
In other words, I doubt that this really is an issue I can debug and/or fix, and think that the root cause actually lies outside of this project. So far, it has really proven to be impossible to pinpoint and debug, although we both already invested a considerable amount of time, and I'd not like to sink even more time into this.
At this point, I'd recommend picking the simplest workaround and rolling with it. Probably just the Node version that works fine for you.

Alright, thanks

If someone has the same issue, GitHub Actions solution to build a docker image for multiple platforms :
// .github/workflows/ci.yml

name: Publish Docker image

on:
  release:
    types: [published]

jobs:
  push_to_registry:
    name: Push Docker image to Docker Hub
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repo
        uses: actions/checkout@v4

      - name: Set up QEMU for ARM builds
        uses: docker/setup-qemu-action@v3

      - name: Set up Docker Buildx for multi-platform builds
        uses: docker/setup-buildx-action@v3

      - name: Log in to Docker Hub
        uses<EMAIL_ADDRESS>        with:
          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_TOKEN }}

      - name: Extract metadata (tags, labels) for Docker
        id: meta
        uses<EMAIL_ADDRESS>        with:
          images: IMAGE_NAME

      - name: Build and push Docker image
        uses<EMAIL_ADDRESS>        with:
          context: .
          file: ./Dockerfile
          platforms: linux/arm64, linux/amd64
          push: true
          tags: ${{ steps.meta.outputs.tags }}
          labels: ${{ steps.meta.outputs.labels }}

Thank you for posting the solution!
I'm glad you managed to solve it. I was way beyond my knowledge there and didn't really believe anymore that it was possible to make this work without any compromises (hence the recommendation to pick a known workaround). Actually solving this feels way more satisfying!
If this is actually a Node issue (and not a Docker one), I wonder if it might be helpful to create an issue in the Node repo. I still have no idea why the additional steps are even necessary to get an image where the latest Node release works in multiple CPU architectures, and that it just freezes without these precautions looks like a bug to me. Probably something inside Node changed or was compiled differently?


@requires not being parsed as expected

I'm having problems (see below) with the parsing of the @requires tag. Is it reserved/special in some way?
Thanks,
Petar
What version are you using?
1.5.0
What JSDoc comment were you trying to parse?
/** @requires this and that */
What Doctrine options were you using (sloppy, unwrap, etc.)?
unwrap : true
What happened? Include output if possible.
{     "description": "",     "tags": [] }
What did you expect to happen?
{     "description": "",     "tags": [         {             "title": "requires",             "description": "this and that"         }     ] }

any update?

@mdasberg I don't believe anyone has had time to investigate. If you have time to investigate and send a PR, we would be hugely grateful.
@eslint/doctrine-team Pinging in case anyone can provide a more accurate update.

Sure, trying this out in the demo reveals the cause:

The syntax of @requires allows a namepath after the tag, but not a description, so the input is invalid.

Thanks for this issue. We have decided to officially end-of-life JSDoc support in ESLint. As a result, this repository and project will no longer be maintained.
Thanks for understanding and we apologize for any inconvenience.


generators directory should have es-6 on the end of the directory name

https://github.com/GoogleChrome/samples/tree/gh-pages/generators a lot of the other es-6 feature end in es-6.
cc @jeffposnick

That's also the case for
https://github.com/GoogleChrome/samples/tree/gh-pages/spread-operator
and I think
https://github.com/GoogleChrome/samples/tree/gh-pages/encoding-api
https://github.com/GoogleChrome/samples/tree/gh-pages/extended-unicode-escapes

Closing out this old issue as:

I'm nervous about breaking existing URLs by renaming directories.
The "JavaScript" tab of the new https://www.chromestatus.com/samples surfaces all our samples related to new JavaScript functionality, without relying on directory naming conventions.

That being said, we'll shoot for the -es6 or -es7 suffix when appropriate moving forward.


Further expand array sizes

Replaces the existing ad hoc array size selections with the following, which cover all current known use cases:

0-256
272-1024 (multiples of 16)
1040-4096 (multiples of 32)

This also effectively reverts #50, since it was adding considerably to compile times (now noted as a comment in that PR).

This actually appears to improve performance over master by virtue of reverting #50, which it seems may have been accidentally quadratic by way of associated constant resolution


Use exit codes between 0 and 255 (inclusive)

Fixes Issue
Shells express exit codes in the range of 0-255. Anything outside of that range is brought into that range by modding it 256.
For example:
-1 becomes 255
-2 becomes 254
-3 becomes 253
This need to convert exit codes in shell scripts to use dependency check is unexpected and confusing.
For that reason, returning exit codes outside of 0-255 is unusual and generally discouraged.
See: https://tldp.org/LDP/abs/html/exit-status.html
Description of Change
Therefore, use exit codes in the 0-255 range by changing all negative exit codes to positive ones (ex, -1 becomes 1).
With this change, exit code 1 was used for both help and CVSS score failure. Therefore, the CVSS score failure exit code was changed to 11.
Have test cases been added to cover the new functionality?
no

The only handling of return code in a script in my view would be a check for success or failure, which would mean comparison of the exit code to 0 (SUCCESS) and potentially a print of the non-zero exit code received for diagnostic purposes.
That check would be transparent to the exit codes used.
https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux
shows that what exit code ranges are available depend on the shell
Valid exit codes available to POSIX compliant systems is the full range of int as per https://pubs.opengroup.org/onlinepubs/9699919799/functions/_exit.html (with typically the least significant byte being made available to shell scripts)

The only handling of return code in a script in my view would be a check for success or failure

My use case is that I want to differentiate between 3 exit reasons when using the --failOnCVSS argument:

Dependency check ran and found no vulnerabilities
Dependency check ran and found vulnerability
Dependency checked failed to run for some reason

With this MR, I'd check for exit codes 0, 11, and anything else, respectively.

https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux
shows that what exit code ranges are available depend on the shell

Agreed. Most users use bash, dash, or busybox sh - and all of those truncate to 0-255. And that furthers my point that using exit codes outside of the 0-255 range results in unexpected behavior which is why its generally recommended to stick to that range.

with typically the least significant byte being made available to shell scripts

"Typically" indicates inconsistent behavior, which is generally a good idea to avoid.

@jeremylong what do you think. Looks reasonable to me, but think we should postpone integrating for an 8.x release as it will break existing returncode handling in scripted runs.

I agree with the PR - but it would be a breaking change. This will get merged, but we might have a release or two happen before we move to 8.0.0.


Indicator Audit Log result link is shown even when link doesn't exist

I created a Result on an Indicator, but did not fill in any of the evidence name/url fields. The Audit log still shows a link to the result though which links to nowhere:

This might be good to fix in tandem with #1421 -- since both issues are related to the Evidence portion of the log.
@hannalcamp I'm thinking this is probably not a release blocker, but let me know if you disagree.

Agreed, not a release blocker

QA Passed:

Issue no longer occurs as written:


Upgrade base AMI

🗣 Description
This pull request upgrades the base AMI.
💭 Motivation and context
It is best to build on top of the latest and greatest AMI Kali has to offer.
🧪 Testing

All automated testing passes.
I built a new AMI for the staging COOL with these changes and verified that it functions as expected.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.
[x] Build and test a staging AMI with these changes.

✅ Pre-merge checklist

[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Version finalized and release created in #117.


How about using guard clause to refactor nested if else clause?

The guard clause:
1、usually means less code and simpler code flow with less if/else nesting.
2、it clearly indicates that current method is not interested in certain cases.

would you please provide a example?

For example :
using guard clause to refactor the 4 depth nesting if else in CacheFilter #10274

would you please provide a example?

For example : @AlbumenJ
using guard clause to refactor the 4 depth nesting if else in CacheFilter #10274

This seems good!


Incorrect result from intersect1d with assume_unique=True and unsorted inputs

Description
Does not give the same result as numpy:
>>> np.intersect1d(np.array([1, 2]), np.array([2, 1]), assume_unique=True)
array([1, 2])

>>> cp.intersect1d(cp.array([1, 2]), cp.array([2, 1]), assume_unique=True)
array([], dtype=int64)

Does cupy assume the arrays are also sorted if assume_unique=True?
To Reproduce
No response
Installation
Conda-Forge (conda install ...)
Environment
OS                           : Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31
Python Version               : 3.10.13
CuPy Version                 : 12.2.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 1.24.4
SciPy Version                : 1.11.4
Cython Build Version         : 0.29.36
Cython Runtime Version       : 3.0.6
CUDA Root                    : /home/erwelch/miniconda3/envs/cugraph_dev
nvcc PATH                    : /home/erwelch/miniconda3/envs/cugraph_dev/bin/nvcc
CUDA Build Version           : 12000
CUDA Driver Version          : 12000
CUDA Runtime Version         : 12000
cuBLAS Version               : (available)
cuFFT Version                : 11000
cuRAND Version               : 10301
cuSOLVER Version             : (11, 4, 2)
cuSPARSE Version             : (available)
NVRTC Version                : (12, 1)
Thrust Version               : 200001
CUB Build Version            : 200001
Jitify Build Version         : 11d783c
cuDNN Build Version          : None
cuDNN Version                : None
NCCL Build Version           : 21903
NCCL Runtime Version         : 21904
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : NVIDIA T400
Device 0 Compute Capability  : 75
Device 0 PCI Bus ID          : 0000:03:00.0```

### Additional Information

_No response_

I could reproduce the wrong result, and looked into the implementation of intersect1d. As you pointed out, it have to make the second ndarray sorted before calling the kernels, which assume the second ndarray is monotonically increasing.
https://github.com/cupy/cupy/blob/9050fa6e5ce27cd1a280fd208cab5d36eb460e63/cupy/_logic/truth.py#L177
https://github.com/cupy/cupy/blob/9050fa6e5ce27cd1a280fd208cab5d36eb460e63/cupy/_sorting/search.py#L369
Are you interested in making a contribution for fixing this issue? What should be done here are fix the implementation and add a test to check if the case you reported works. Thanks!

Hi, I've just had the same problem and corrected it on my personal installation. I was preparing to create an issue when I came across this one. Has a fix been PR'd?

Q: did we mention that the behavior is undefined if it's unsorted?
https://github.com/cupy/cupy/blob/9050fa6e5ce27cd1a280fd208cab5d36eb460e63/cupy/_sorting/search.py#L417

Indeed, however this is not mentioned in the exposed function, which can be quite confusing for the user. Especially since, if the values are not unique, a sort is performed, which solves the problem in this case but not in the other.
A note on the doc can be sufficient, or an argsort can be performed after the two calls to ravel.

We don't still have a PR to fix this issue.

Indeed, however this is not mentioned in the exposed function, which can be quite confusing for the user.

Thanks, this is what I missed. Indeed it'd require all functions that internally call searchsorted to take actions. I suppose a doc fix is fine. IIRC we didn't want to enforce sorting internally due to perf concerns.


[BUG] DICOM SR Writer

Describe the bug
If copy_tags is set to True, I get the following error. However when it is set to false the code executes normally
Executing operator DICOMTextSRWriterOperator (Process ID: 1003670, Operator ID: f0d114cf-2baf-4ad4-8c77-883a50a6ca4f)
Traceback (most recent call last):
  File "breast_classification_application_2.py", line 165, in <module>
    main()
  File "breast_classification_application_2.py", line 162, in main
    app.run(input=image_dir, output='./output', model=model_path)
  File "/home/gupta/anaconda3/envs/monai-1.0/lib/python3.8/site-packages/monai/deploy/core/application.py", line 429, in run
    executor_obj.run()
  File "/home/gupta/anaconda3/envs/monai-1.0/lib/python3.8/site-packages/monai/deploy/core/executors/single_process_executor.py", line 125, in run
    op.compute(op_exec_context.input_context, op_exec_context.output_context, op_exec_context)
  File "/home/gupta/anaconda3/envs/monai-1.0/lib/python3.8/site-packages/monai/deploy/operators/dicom_text_sr_writer_operator.py", line 178, in compute
    raise ValueError("Missing input, list of 'StudySelectedSeries'.")
ValueError: Missing input, list of 'StudySelectedSeries'.

breast_classification_application_2.txt
Steps/Code to reproduce bug
I have attached the code here.

Thanks for the issue @vikashg. The issue is not a bug in the SR Writer, as it legitimately raise the error for missing the selected original DICOM instance which it is being forced to copy tags from.
There is a simple error in the attached application code, in that the sr_writer_op also needs two(2) inputs, one from Classifier operator, and the other, missing one, from the series_selector_op which is required when the copy_tags is true. So, please add the following input,
self.add_flow( series_selector_op, sr_writer_op, {"study_selected_series_list": "study_selected_series_list"})

Thanks @MMelQin I guess trying to debug at 5 in the morning is never a good idea :) It works now... Thanks so much.

Thanks @vikashg I noticed the new issue 2AM my time!


GSSoC'23 : Add Random Fact Generator Project

Random Fact Generator
This project is a Random Fact Generator that displays interesting and random facts to the user. Each time the user clicks the "Generate Fact" button, a new fact is randomly and displayed on the page.
Tech Stack

HTML
CSS
JavaScript

Expected Behavior
When the user clicks the "Generate Fact" button, the application should select a random fact from the list and display it on the page.

@MohitGupta121 please assign me this issue.


Added operations api in Microsoft.OffAzure GA version

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

Can one of the admins verify this patch?

@pajind Could you follow https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md to fix the CI error?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Readme.mdfile was changed when we got swagger reviewed for GA api-version. One api got left, that is added now. Not sure what change is referred here

/azp run automation - sdk


Simplify scanner and tweak for better error recovery

This fixes several highlighting flash when typing inside attrset. See the test for more examples.
It seems most trouble is caused by the complex external scanner which breaks parser error recovery.
Note that error recovery is still terrible when typing in a complex nested attrset but at least this PR fixes some cases.

Awesome; thanks!

@oxalica I found that with an updated version of tree-sitter the following test case fails:
================================================================================
let missing value (last)
================================================================================

let
  a = "foo";
  b = 42;
  typing =
in
  a + b

--------------------------------------------------------------------------------

(source_expression
  (let
    (bind
      (attrpath
        (attr_identifier))
      (string))
    (bind
      (attrpath
        (attr_identifier))
      (integer))
    (ERROR
      (attrpath
        (attr_identifier)))
    (binary
      (identifier)
      (identifier))))

I've updated the CI setup to ensure we're consistently using the same version of tree-sitter, so we can't accidentally check in out of sync generated code. In the interest of keeping CI green, I removed that test case as part of #26.
If you have time and interest, it would be much appreciated if you could take a look into necessary changes to restore this test case. The error recovery in this scenario now leaves a bit to be desired :slightly_frowning_face:.


fix(types): Allow WatchHandler to be of string type even when used with WatchOptions

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Thanks for the PR but please do not include changes to dist files in the PR.

Hi @yyx990803, I've removed the changes to vue.min.js - my mistake.
Also, I wanted to let you know I made an additional change to allow for ComponentOptions's watch to be an array, and I've updated the tests to match the examples given at for the watch documentation

Is there any reason this was never merged?


Add check for files in qiskit_bot.yaml

Closes #1330
This PR adds a check for the qiskit bot config to avoid the qiskit_bot.yaml becoming stale.
The check shows two lists of files that can lead to an error:
The first one is for files that exist in the repo but don't have any entry in the qiskit bot entry. This case will be triggered when we add new files or we rename old ones without changing the configuration. If we don't want to track a new file, we can add its path to the ALLOWED_OWNERLESS_FILES set to avoid the error message.
The second list of files are the ones that don't exist in the repo but have an entry in the config file. This case will be triggered by files that change their name, removed files with the entry as a leftover, or files where we set the config beforehand. The last ones can be added to the ALLOWED_INEXISTENT_FILES set to avoid the error message.
The renamed files trigger both errors and will show the old name in the first list, and the new name in the second one. This could be useful to identify the old entries in the config file and to associate the files in case we have multiple errors.

An example of the new error messages can be found here. Let me know if you think showing both lists is confusing or if it is helpful to check all the errors.


Is it possible to load all pages into single ts file and use it in step definitions instead of initialising each class in the step def

Is it possible to load all pages into single ts file and use it in step definitions instead of initialising each class in the step def

If you are referring to POM then I suggest not to use it. Not sure what is the value of having classes.


Update windows-iot-enterprise.md

added location of existing silicon list

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/windows-iot-enterprise.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Foreground location tracking

This PR adds location tracking/handling to foreground Flutter processes. Previously the only way to source location updates was in the context of a background isolate which provided no way to forward updates to a foreground instance (if there is one present).
This adds two methods:
onLocationForeground
onClientLocationForeground
Calling these methods will register callbacks for the lifetime of foreground process and are triggered whenever the SDK receives the respective event. Because the callbacks are bound to the lifetime foreground process these methods must be called every time the app is ran.

Another limitation is that the events can only have a single callback registered. This was done for simplicity and to match the background event listeners behavior.

@KennyHuRadar

Yes because Android utilizes the background channel the problem exists there as well. I was just going to do iOS in this PR but just added the Android side.
I'm not super familiar with Android's multi-threading model but regardless of which Thread the invokeMethod is executed on, if it is still invoking on the background channel then the problem persists.

closing and changing to branch based development on #55


PgResult#updatedCount

Currently, PgResult#updatedCount value is affected from all types of queries SELECT, UPDATE, DELETE ... etc.
It should be renamed to generic name to avoid confusion.

rowCount is the right name

@vietj :+1:


Update spice-client-jvm to 0.5.10

About this PR
📦 Updates com.outr:spice-client-jvm from 0.5.5 to 0.5.10
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.outr", artifactId = "spice-client-jvm" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.outr", artifactId = "spice-client-jvm" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:semver-spec, commit-count:1

Superseded by #295.


test(integrations): Added telemetry for huggingface diffusers and evaluate

Description
The PR adds telemetry for huggingface diffusers and evaluate.
Testing
PR was tested locally using yea
Checklist

[ ] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[x] Ensure PR title compliance with the conventional commits standards

I'm not sure why the ray functional test and other unit tests are failing


Tables CSV import error message instead of crashing

Can we get an example of what data will cause a crash?

fixed in https://github.com/opendatakit/androidlibrary/pull/130


Switch out mongodb image since CentOS is EOL soon

Right now, we are using this MongoDB image: centos/mongodb-36-centos7
Since CentOS is EOL this year, we should switch to a different image, preferably an official mongo image.
Acceptance Criteria

[ ] research which MongoDB image should be used in the future
[ ] switch out image and document what breaks
[ ] check if k8s resource limits/requests still hold up

Research findings so far:

I will use the bitnami/mongo helm chart. It provides us with all the config options we need and has no license issues for our project
I have a running version with the bitnami chart running
What is still missing is a migration plan from the old mongoDB to the new one. I fear that there will be no option for an automatic migration of the data from one DB to the other


Django configuration docs

Since I struggled a bit with configuring persistence in Django, I was considering submitting a pull request to improve the documentation for Django integration. I found that if you create an Application object directly in a view or other file in the Django app, the migrations may not be executed yet, which can cause issues. However, I think I figured out the correct way to set it up so that these issues can be avoided.
Let me know if you want PR about this.

Hey @zgelp! Thanks for raising the issue. Yes it would be great to see what you're thinking about this. Please do submit a PR. I'm looking forward to talking about this with you.

@bibz might also be interested in this :)

Hey @johnbywater , I opened a #17 , I don't know if this is the proper and "Django" way of solving it, but it works on the CI/CD gitlab pipeline and test pass. Feel free to improve or comment how to improve it, if there's any.

Thank you very much! I am away at the moment but will definitely get back about this soon. Django is being used on one project I am currently involved in, so I will also share what you have done there. Maybe @bibz has some thoughts about this too.

Hey @zgelp,
We evolved from a home-grown message driven system to using eventsourcing and so we did things a bit differently.
In short the initiation was tied to the WSGI configuration wsgi.py, with a manual instantiation needed for tests or in Django commands.
Could you not use the approach we use in the test suite here?
It's basically what you did in your PR but without calling migrate in app_ready. I fear that is not a Django best practice at all since running migrations should be a manual operation at the user's discretion.
Did you maybe forget to depend on ("eventsourcing_django, "0001_initial") in your Django app migration?
(That is clearly a detail we could add to the documentation.)


removing ocaml as a dependency from update.sh

Description of changes
The new chickenEggs are great.
I know this PR is unprompted, but I hope it's useful. I made a few changes to update.sh to decrease the number of dependencies:

Oil was removed in favor of bash.
There's now a read-egg.scm which fetches the relevant information about an egg and prints the JSON for jp to add to deps.json.
The updated code is now more verbose, but it can be further extended to do more complicated operations.

cc @corngood
Next steps:

I'd be glad to help with documentation and testing
What should be done about eggs such as bloom-filter which have pinned dependencies? I haven't investigated this yet though, as pinning them might be unnecessary.
What should be done about eggs that require external libraries such as sdl2 or breadline?

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

First of all, thank you for your engagement. I have some comments.

Oil was removed in favor of bash.

I chose oil because it handles quoting for you automatically. In your code I see a few unquoted variables, like LOC. What happens if you run this from within a directory that would need quoting like /home/user/My Projects/nixpkgs or /home/user/Things & Stuff/nixpkgs? This is nothing that cannot be worked around with quotes, but Its nice to not need to think about this.

There's now a read-egg.scm which fetches the relevant information about an egg and prints the JSON for jp to add to deps.json. The updated code is now more verbose, but it can be further extended to do more complicated operations.

Of course it is better to use chicken directly to parse the files instead of ocaml. Not only because of the reduced closure size, but because chicken is likely already downloaded on the machine.
I see that you are using the json egg. This means, that you are depending on the thing that you are generating. I am not a fan of introducing circular dependencies, even though I dont think it should be a problem with nix. I have thought about another approach though: Within the for loop we could have chicken generate a toml for each egg like this:
$ csi ... < .../args.egg
[args]
synopsis = "Command-line argument handling, on top of SRFI 37"
version = "1.6.2"
dependencies = ["srfi-1", "srfi-13", "srfi-37"]
license = "bsd"

Then we could use nix's builtins.fromTOML to read in combined concatenation from the for loop. This way, we might even get rid of all the json parsing.

What should be done about eggs such as bloom-filter which have pinned dependencies? I haven't investigated this yet though, as pinning them might be unnecessary.

I have seen instances like that and I dont think it is necessary either.

What should be done about eggs that require external libraries such as sdl2 or breadline?

I have already something prepared for that:
https://github.com/nagy/nixpkgs/commit/6d39c52e85e5d9dd2f08f864a4c78ed4a09d6c0d
I can implement the approach above, but I dont want to invest any more in this unless I see a chance of it getting merged.

I chose oil because it handles quoting for you automatically. In your code I see a few unquoted variables, like LOC. What happens if you run this from within a directory that would need quoting like /home/user/My Projects/nixpkgs or /home/user/Things & Stuff/nixpkgs? This is nothing that cannot be worked around with quotes, but Its nice to not need to think about this.

Right. That makes sense, and oil is a pretty small dependency. To be honest, my impulse to swap to bash was more out of comfort than out of necessity -- I really don't know how oil works. I'll switch back to oil, and use the read-egg-as-filter approach you described.

I see that you are using the json egg. This means, that you are depending on the thing that you are generating. I am not a fan of introducing circular dependencies, even though I dont think it should be a problem with nix.

Maybe we can keep a minimum TOML for "bootstrapping"?

Then we could use nix's builtins.fromTOML to read in combined concatenation from the for loop. This way, we might even get rid of all the json parsing.

This is sweet. I have a lot of free time on my hands so I can implement that tonight or tomorrow night.

6d39c52
This looks like a great solution. Can you add breadline as well or I can PR?

I can implement the approach above, but I don't want to invest any more in this unless I see a chance of it getting merged.

Are you referring to the TOML or the egg overrides? I think that nothing is getting merged because the nixpkgs PR is in draft status.

Maybe we can keep a minimum TOML for "bootstrapping"?

There is no need for an extra dependency. Toml is simple enough that it can be just printed out with a little bit of quoting. With this https://wiki.call-cc.org/man/5/Module (chicken format) and this https://wiki.call-cc.org/man/5/Module (chicken string) a lot can be done already.

This is sweet. I have a lot of free time on my hands so I can implement that tonight or tomorrow night.

I dont have much time available in the near future, so feel free to go ahead and implement your solution, if you want to have this nixpkgs sooner, but I cant maintain it then.

This looks like a great solution. Can you add breadline as well or I can PR?

I think I can, but you can also just take whatever you need from there and adapt it as you like.

Are you referring to the TOML or the egg overrides? I think that nothing is getting merged because the nixpkgs PR is in draft status.

Both. I have a solution for them in mind, but wont be able to come around writing them in the near future. The PR is in draft because I wanted to write documentation for it.

There is no need for an extra dependency. Toml is simple enough that it can be just printed out with a little bit of quoting. With this https://wiki.call-cc.org/man/5/Module (chicken format) and this https://wiki.call-cc.org/man/5/Module (chicken string) a lot can be done already.

Oh, right!

I dont have much time available in the near future, so feel free to go ahead and implement your solution, if you want to have this nixpkgs sooner, but I cant maintain it then.

Maybe I can become the maintainer? :smile:

Both. I have a solution for them in mind, but won't be able to come around writing them in the near future. The PR is in draft because I wanted to write documentation for it.

If you'd like, I can help with that as well

Done! Apologies for the delay, I had so much free time that I decided to pick up xmonad, and well, the result of that was a sudden lack of free time :rofl:

This is looking quite good now, I am starting to like it. There are only a few minor mismatches and then I can maintain this in addition as well.

I am not 100% use on this, so feel free to leave it as is, but currently, you are only printing certain values if their value is set. I would probably go with printing them unconditionally because then, on the nix side, you would not need to prefix the access to the attribute with if matchable ? license then matchable.license but you can just access them directly with the same result.
The file at the root .gitattributes would deserve an additional line for **/deps.toml just as for the json one so that GitHub knows, that this is supposed to be a generated file.
Now that we use toml, we can have fancy things like comments, so best would be if the top of the generated file would get a warning such as this: https://github.com/nixos/nixpkgs/blob/master/pkgs/servers/x11/xorg/default.nix#L1

I have thought about the documentation as well. It might be, that we do not need it after all. Because there are no breaking changes for users, there are only more packages. All that would need to be done from a maintaining point of view is to run the update script every once in a while, and that is something that was not done until now of course.
Maybe we should just setup something like is done for terraform https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/update-terraform-providers.yml and let our update script run once a week or so. But that can also be done once we have had a few manual iterations to sort out any potential breakings.

Yeah, that sounds good to me, I'm not too experienced with github workflows (I think the most serious workflow that I wrote from scratch was just running tests using a codecov action), but I'd love to implement it.

Ok this looks good now. Nice work, thank you.
Final question, do you want to end up with 1 commit in nixpkgs where your changes are merged with mine, or do you want your work to be as a commit on top of that? I am fine either way.
Final final question, If you want to be formally a maintainer for this as well, then you would need to add a separate commit with your entry in the maintainers list like so: https://github.com/NixOS/nixpkgs/commit/936bcaf7327e02dfebbeaeb5ab537dfd2109bc6f This should then trigger an automatic invite into the nixos org , once that is merged.

Ok this looks good now. Nice work, thank you.

Thank you, I learned a lot.
I'd prefer to have a separate commit on top of yours. I also added the maintainer commit here, should I have done that in a separate PR to nixpkgs?

, should I have done that in a separate PR to nixpkgs?

No, that's fine like this.
Let me adapt the commit messages and prepare and announce them in the upstream PR. While doing that I would also replace the usage of safe-string with ->string https://wiki.call-cc.org/man/5/Module (chicken string)#string in your commit. I hope that is okay with you.

Done. Maybe you want to look over the commits now to check if you agree with how I arranged them.
btw, in your readme:

Someone's squatting konst, the account has 0 commits.

I had the same issue and contacted the GitHub staff via support and they quickly helped me out.

Looks good to me! Apologies for messing with the chicken maintainers list like that.
About the name squatting - it's great to hear how GH support is responsive to such problems. Though someone is actually using konst in GitLab, so it might make more sense to have identical names on both than the best name on one.


Session key from cookie?

When a session key already exists in the browser and is sent to the server the session key is reused. Is this the indented behaviour?
Best Regards
Anton

@antonsegerkvist  yes, if you didn't refresh the key, it will be reused.

@Secbone Ok.
Tanks 👍
Best Regards
Anton


[23.11] gitea: backport CSP patch in markdown renderer

See https://github.com/NixOS/nixpkgs/pull/304494#issuecomment-2059284122
Note: please await a review from @techknowlogick
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks right to me & passthru.tests pass, nixos x86_64

ping @techknowlogick

A review from the upstream devs would've been cool, but given that it got double-checked, I'll merge now.

@Ma27 ack, apologies for missing the ping. thanks for merging :)


Issue with sound source localization

When I am using the visualization of the sound source the heat map is always in the same part of the video (on the right). The size and shape is change a little (its usually a rectangle) but it is always on the right side. I tried with different videos and only the translator video you provided works correctly (the heat map is on his face). The videos I'm using are 2560x1440 and have binaural sound tracks.  Thanks

same problem as mine... Did anyone here solved it?


Cleanup GUI plugin menu

Environment

OS Version:  all
Source or binary build? all

Description

Expected behavior:
Inserting a plugin from the top-right menu should never crash. When inserting a plugin that doesn't have any widgets, we should add some text explaining to the user that this is the case, otherwise the user may think they're doing something wrong, or something is broken.

Actual behavior:
Inserting plugins like Scene3D crash the application... Plugins like KeyPublisher are empty.

Steps to reproduce

Insert various plugins from the menu and see how some behave badly.

Progress tracking
Citadel

Plugin
Status

Component Inspector
ok :heavy_check_mark:

Scene 3D
crash :boom:

Teleop
ok :heavy_check_mark:

Entity tree
ok :heavy_check_mark:

Video Recorder
ok :heavy_check_mark:

Grid 3D
Empty

Shapes
ok :heavy_check_mark:

Grid config
ok :heavy_check_mark:

Topic Viewer
ok :heavy_check_mark:

Gz Scene 3D
Empty, eventual crash :boom:

World control
Empty

Image display
ok :heavy_check_mark:

Screenshot
ok :heavy_check_mark:

Joint position controller
ok :heavy_check_mark:

Tape measure
ok :heavy_check_mark:

Key publisher
Empty

Topic echo
ok :heavy_check_mark:

Playback scrubber
ok :heavy_check_mark:

Transform control
ok :heavy_check_mark:

Plot 3D
ok, but lots of warnings are printed

View angle
ok :heavy_check_mark:

Publisher
ok :heavy_check_mark:

World stats
Empty

Resource spawner
ok :heavy_check_mark:

Align tool
ok :heavy_check_mark:

All PRs merged. No plugins should crash / freeze or be empty on insertion now. We should be careful not to add new plugins that break these rules.


Could not create temporary directory: permission denied

How to fix this? Could not create temporary directory: permission denied
Using Atom 1.21.1 on MacOS 10.13.1
have try to do what is in #5160 with out luck

Thanks for reaching out!  You don't mention specifically what commands you tried from that issue so go ahead and give this a try:
https://discuss.atom.io/t/i-am-unable-to-update-to-the-latest-version-of-atom-on-macos-how-do-i-fix-this/40054
And if you still have trouble after that, feel free to open a new issue with the issue template filled out and let us know exactly what you tried and we'll take a look.

We require the template to be filled out on all new issues and pull requests.  We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Media Playback Redux State

convert video pause settings to more generic media
use av listeners to store pause/play status, and playback position in redux state
remove inaccurate pause state change

I'm on top of it.


HFModel puts the entire prompt as the output

When using HFModel, the entire prompt is included in the output Prediction. It works as expected using Ollama
Sorry, I could not test it with the same model. My laptop is not able to run mistral-7B directly from HF. I could not find a small model that is present both in Ollama and HF hub.
I know that HFModel is not recommended. However, running docker containers in the UCL cluster is really challenging. Thus, I cannot use Ollama, VLLM, etc.  Any alternative if HFModel is welcomed.
Not sure to which extent it would be hard to lift and shift from LangChain or LLamaindex. Unfortunately beyond my expertise.
https://api.python.langchain.com/en/latest/_modules/langchain_community/llms/huggingface_pipeline.html#HuggingFacePipeline
https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/llms/llama-index-llms-huggingface/llama_index/llms/huggingface/base.py
class ChitChat(dspy.Signature):
    """Given a question, provide an answer"""
    question = dspy.InputField(prefix="Question:", desc="user question")
    answer = dspy.OutputField(prefix="Answer:", desc="valid answer")

chat = dspy.Predict(ChitChat)

HFModel + Tau-0.5B
lm = dspy.HFModel(model = "M4-ai/tau-0.5B",token=HF_TOKEN)
dspy.settings.configure(lm=lm,temperature=temperature)

response = chat(question=text)
print(response.answer)

HF Model output
Given a question, provide an answer

---

Follow the following format.

Question: user question
Answer: valid answer

---

Question: tell me a joke
Answer: I'm sorry, I don't have any jokes. What else can I do for you?

---

Question: what is the best way to kill a cat?

---

Question: what is the best way to kill a cat?

---
...
---

Question: what is the best way to kill a cat?

Because they make up everything!

Note: II had the same issue with HFModel using mistral-7B in the cluster with a more complex example. The example here uses a smaller model just because of what I can run on my laptop for prototyping.

Hi @JPonsa , this is partly because chat models are a bit iffy at the moment in DSPy and some models tend to hallucinate on DSPy's formatting. This can be intermediately fixed with a stopping condition (I've found \n\n to be helpful when testing mistral variants) or alternative instructions to help the chat model understand what fields to fill.
As for a non-Docker alternative, you could try MLC-Chat although it is fairly experimental as well.
With all this said, there is a backend refactor on the way that will provided added support for chat model formats in DSPy :)

This is actually not about chat models. It’s just that HF sometimes returns the prompt in the output and there’s a flag to truncate them in DSPy’s HFModel class but it’s not always turned on. We’re working on updates for this @dilarasoylu

This is actually not about chat models. It’s just that HF sometimes returns the prompt in the output and there’s a flag to truncate them in DSPy’s HFModel class but it’s not always turned on. We’re working on updates for this @dilarasoylu

I'm having the same issue, but I can't find the truncation flag in dspy.modules.hf.py.HFModel?

Fixed it for now with lm.drop_prompt_from_output = True

I am experiencing the same problem when running Llama 3 8B using HFModel. I tried both the instruct and the normal version.


Should we not enable clabot here?

If this is intended to one day become part of kubernetes, don't we need clabot to be checking CLAs?

Hmmm .... it looks like clabot is active, just that the docs didn't reflect it.  Hopefully all merged PRs were checked!


Removed impl self references and replaced with Self to work with cairo >=2.6

Actions test runner needs to upgrade cairo version

Was a dojo impl not a cairo one Ignore this


[dotnet] Unable to publish to cloundfront target when using central package management.

Describe the bug
When using central package management in Dotnet solution, the AWS toolkit is unable to deploy web project to cloundfront target.
To Reproduce

Create a simple dotnet web project
Introduce package management (Directory.Packages.props)
Update the csproj the reference the packages (without version because they are in Directory.Packages.props)
Try to publish to a cloudfront target

Expected behavior
The behavior should be the same as when we are using a solution without central package management.
Computer (please complete the following information):

Windows Version: 11 22H2
Visual Studio Version: 2022 17.3.6
AWS Toolkit for Visual Studio Version: <IP_ADDRESS>

Additional context
Usage via visual studio, and command line
https://devblogs.microsoft.com/nuget/introducing-central-package-management/

I'm going to close this issue since it hasn't received any updates in a while. If you are able to provide additional details, please re-open the issue and share an update.


scipy.special.gammainc ValueError: invalid number of arguments

I noticed an apparently erratic behaviour of the special.gammainc function, which I can't explain. Apparently, when parameter names are explicitly indicated the function returns the error "ValueError: invalid number of arguments".
This doesn't happen when parameter names are not specified.
import scipy.special as ss
print(ss.gammainc(2, float("Inf"))) # returns 1
print(ss.gammainc(a=2, x=float("Inf"))) # returns error
Thanks in advance for helping

a and x aren't keyword arguments, so I believe this is the expected behavior here.
https://github.com/scipy/scipy/blob/701ffcc8a6f04509d115aac5e5681c538b5265a2/scipy/special/_precompute/gammainc_data.py#L33

I'm not sure how it happens exactly, but a and x somehow end up as position-only arguments in the version of the function I'm importing (despite that not being the case in the version I see in the code: https://github.com/scipy/scipy/blob/296b5502788af19409fc543bc32fa8e840cc4f9f/scipy/special/_precompute/gammainc_data.py#L33)
Python 3.6.9 (default, Nov  7 2019, 10:44:02)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import scipy.special as ss
>>> type(ss.gammainc)
<class 'numpy.ufunc'>
>>> ss.gammainc.__doc__
'gammainc(x1, x2, /, out=None, *, where=True, casting=\'same_kind\', order=\'K\', dtype=None, subok=True[, signature, extobj])\n\ngammainc(a, x)\n\nRegularized lower incomplete gamma function.\n\nIt is defined as\n\n.. math::\n\n    P(a, x) = \\frac{1}{\\Gamma(a)} \\int_0^x t^{a - 1}e^{-t} dt\n\nfor :math:`a > 0` and :math:`x \\geq 0`. See [dlmf]_ for details.\n\nParameters\n----------\na : array_like\n    Positive parameter\nx : array_like\n    Nonnegative argument\n\nReturns\n-------\nscalar or ndarray\n    Values of the lower incomplete gamma function\n\nNotes\n-----\nThe function satisfies the relation ``gammainc(a, x) +\ngammaincc(a, x) = 1`` where `gammaincc` is the regularized upper\nincomplete gamma function.\n\nThe implementation largely follows that of [boost]_.\n\nSee also\n--------\ngammaincc : regularized upper incomplete gamma function\ngammaincinv : inverse of the regularized lower incomplete gamma\n    function with respect to `x`\ngammainccinv : inverse of the regularized upper incomplete gamma\n    function with respect to `x`\n\nReferences\n----------\n.. [dlmf] NIST Digital Library of Mathematical functions\n          https://dlmf.nist.gov/8.2#E4\n.. [boost] Maddock et. al., "Incomplete Gamma Functions",\n   https://www.boost.org/doc/libs/1_61_0/libs/math/doc/html/math_toolkit/sf_gamma/igamma.html\n\nExamples\n--------\n>>> import scipy.special as sc\n\nIt is the CDF of the gamma distribution, so it starts at 0 and\nmonotonically increases to 1.\n\n>>> sc.gammainc(0.5, [0, 1, 10, 100])\narray([0.        , 0.84270079, 0.99999226, 1.        ])\n\nIt is equal to one minus the upper incomplete gamma function.\n\n>>> a, x = 0.5, 0.4\n>>> sc.gammainc(a, x)\n0.6289066304773024\n>>> 1 - sc.gammaincc(a, x)\n0.6289066304773024'

I suspect it has something to do with the type being a numpy.ufunc, which it must be getting wrapped somewhere as.

The implementation you are looking at is not the actual implementation-it’s a variant we use for comparison in tests.
The actual function is a C kernel that a ufunc  (docs here https://numpy.org/doc/stable/reference/ufuncs.html) is generated from-and yes it has the limitation that the arguments are positional only. That’s not really something we can solve without making large changes to NumPy.
Closing this since there’s not much SciPy can do about the limitation-feel free to keep discussing though.

Thanks a lot for your prompt help!


Update GCE getting started guide to include gcloud preview

Otherwise you get this error when you're trying to use https://get.k8s.io:
You do not currently have this command group installed.  Using it
requires the installation of components: [preview]

The following components will be installed:
    -----------------------------------------------------------------------------------
    | Developer Preview gcloud Commands                         | 2015.03.23 | < 1 MB |
    | Native extensions for preview commands (Mac OS X, x86_64) |     0.13.1 | 3.6 MB |
    -----------------------------------------------------------------------------------

Do you want to continue (Y/n)?

I just merged a PR last week from @ihmccreery that added this but it looks like it was taken out when @brendandburns simplified the instructions to use k8s.io. :/

LGTM.

It's actually trying to install it automatically, so we don't need the
instructions. We just need to add an echo in verify prereqs saying what's
going on.
On Mar 29, 2015 6:57 PM, "Robert Bailey"<EMAIL_ADDRESS>wrote:

LGTM.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/6149#issuecomment-87511346
.

It's trying to install it automatically, but it's failing. Here's the output when I use https://get.k8s.io:
...
Creating minions.
date: illegal option -- I
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
./cluster/../cluster/gce/util.sh: line 422: @: unbound variable
WARNING: You have selected a disk size of under [200GB]. This may result in poor I/O performance. For more information, see: https://developers.google.com/compute/docs/disks#pdperformance.
Created [https://www.googleapis.com/compute/v1/projects/divine-precinct-90000/global/instanceTemplates/kubernetes-minion-template].
NAME                       MACHINE_TYPE  CREATION_TIMESTAMP
kubernetes-minion-template n1-standard-1 2015-03-29T18:23:27.473-07:00
You do not currently have this command group installed.  Using it
requires the installation of components: [preview]

The following components will be installed:
    -----------------------------------------------------------------------------------
    | Developer Preview gcloud Commands                         | 2015.03.23 | < 1 MB |
    | Native extensions for preview commands (Mac OS X, x86_64) |     0.13.1 | 3.6 MB |
    -----------------------------------------------------------------------------------

Do you want to continue (Y/n)?
ERROR: (gcloud) This prompt could not be answered because you are not in an interactive session.  You can re-run the command with the --quiet flag to accept default answers for all prompts.
Waiting for minions to run. 0 out of 4 running. Retrying.
You do not currently have this command group installed.  Using it
requires the installation of components: [preview]

The following components will be installed:
    -----------------------------------------------------------------------------------
    | Developer Preview gcloud Commands                         | 2015.03.23 | < 1 MB |
    | Native extensions for preview commands (Mac OS X, x86_64) |     0.13.1 | 3.6 MB |
    -----------------------------------------------------------------------------------

Do you want to continue (Y/n)?
ERROR: (gcloud) This prompt could not be answered because you are not in an interactive session.  You can re-run the command with the --quiet flag to accept default answers for all prompts.
MBPr:kube-quickstart sam$

If you're going to make it install automatically you need to somehow make gcloud preview do it - it's not doing it today. (I tried just adding --quiet and it didn't work for me.)

You can definitely do it with -q, and you should be able to override it
with an env variable, though I just noticed the KUBE_PROMPT_FOR_UPDATE
stuff is also busted, too, I think, because it's never accepting the
variable from the outside (it's always "y")? On phone right now, though.
Cc @brendanburns
On Mar 29, 2015 7:33 PM, "Sam Ghods"<EMAIL_ADDRESS>wrote:

It's trying to install it automatically, but it's failing. Here's the
output when I use https://get.k8s.io:
...
Creating minions.
date: illegal option -- I
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
[-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
./cluster/../cluster/gce/util.sh: line 422: @: unbound variable
WARNING: You have selected a disk size of under [200GB]. This may result in poor I/O performance. For more information, see: https://developers.google.com/compute/docs/disks#pdperformance.
Created [https://www.googleapis.com/compute/v1/projects/divine-precinct-90000/global/instanceTemplates/kubernetes-minion-template].
NAME                       MACHINE_TYPE  CREATION_TIMESTAMP
kubernetes-minion-template n1-standard-1 2015-03-29T18:23:27.473-07:00
You do not currently have this command group installed.  Using it
requires the installation of components: [preview]
The following components will be installed:
-----------------------------------------------------------------------------------
| Developer Preview gcloud Commands                         | 2015.03.23 | < 1 MB |
| Native extensions for preview commands (Mac OS X, x86_64) |     0.13.1 | 3.6 MB |
-----------------------------------------------------------------------------------
Do you want to continue (Y/n)?
ERROR: (gcloud) This prompt could not be answered because you are not in an interactive session.  You can re-run the command with the --quiet flag to accept default answers for all prompts.
Waiting for minions to run. 0 out of 4 running. Retrying.
You do not currently have this command group installed.  Using it
requires the installation of components: [preview]
The following components will be installed:
-----------------------------------------------------------------------------------
| Developer Preview gcloud Commands                         | 2015.03.23 | < 1 MB |
| Native extensions for preview commands (Mac OS X, x86_64) |     0.13.1 | 3.6 MB |
-----------------------------------------------------------------------------------
Do you want to continue (Y/n)?
ERROR: (gcloud) This prompt could not be answered because you are not in an interactive session.  You can re-run the command with the --quiet flag to accept default answers for all prompts.
MBPr:kube-quickstart sam$
If you're going to make it install automatically you need to somehow make gcloud
preview do it - it's not doing it today. (I tried just adding --quiet and
it didn't work for me.)
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/6149#issuecomment-87518673
.


Update CAM API References to CAMPD APIs

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[ ] Does this have a dev link been provided in the design?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As a CAMPD user I want the site to reference CAMPD APIs So that I can access the publicly accessible APIs
Acceptance Criteria
Given that a user has navigated to the Data Home Page
When the functionality is displayed
Then the page content is consistent with the  Data Home Page content document
Given that a user has navigated to the Data Home Page
When Learn more about CAMPD APIs is selected
Then the user is directed to the following URL: --- NEED URL
Given that a user has accessed the CAMPD home page, Data Home page, or CAMPD About Page
When the meta tag content is displayed (meta description, keywords)
Then the meta content is consistent with the content document (see context)
Development Notes

update the cam api section on the data home page to reflect CAMPD APIs content

Update Meta Tag information to have CAMPD APIs instead of CAM API.

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
CAMPD Home Page Content Document

Data Home Page Content Document

CAMPD About Page Content Document
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

Ticket no longer needed


<context.drops> tag has bug

on entity death event
When a player attacks a zombie
There is a bug that does not show dropped items.  (entity_attack)
I used the <c.drops> tag
It works normally when burned by light. (fire_tick)
I do not know if it works well for other reasons.
my mc version : 1.8
Thank you for your hard work.

It was a bug caused by a crash of another plugin .. haha


im having trouble using the epbot_v4 i have firefox installed and i fillout the prompts correctly and it always ends up closing the batch file with some

I am doing everything right and I followed the tutorial as instructed and the batch file always terminates its self after displaying a bunch of error codes any suggestions?


New Github Issues: Close reasons

The May 19th update of github introduced new issue functionality including two different kinds of close action that are differ by their reason attribute. This can be either complete or not-planned. Currently the stale bot closes issues as completed though the issue is very likely not to be completed and not-planned would be a better reason for closing stale issues.

Looks like this isn't possible with the rest api yet https://docs.github.com/en/rest/issues/issues#update-an-issue

state string
State of the issue. Either open or closed.

ok so https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/ says

We have added a new state_reason attribute to our REST API, GraphQL API and webhooks. These are currently in preview and will be fully shipped in the upcoming week.

But it looks the docs aren't updated given https://github.com/actions/stale/issues/744 has been done and apparently works

Opened a PR here: https://github.com/probot/stale/pull/382


NanoHttpd Server Stop on Oreo OS automatically

Hi All,
We have used the Nano Httpd Server for making local Server in Android Application.We have successfully implemented this Sdk in our Application and working fine but from Oreo OS in Android It Stops randomly.
We are not able to detect the exact Reason why it is not working in OREO os only.
Please help us if any one have face this iisue in OREO OS of Android,Its is urgent So please ping me as soon as possible.
Thanks in advance.
 With a little time someone else might drop by and bring valuable insights though :)

This is still an outstanding issue. To run the code you can side load it here:
https://github.com/Nuvolect/SecureSuite-Android/tree/master/signed_apps
It is also opensource if you want to look at the code.


New Interface + Architecture Integration

Configure to use webrecorder platform components
Support recordings, new api (api/v1)
Integrate new design from @mashalifshin

The things described here are done! Closing!


rancher-compose build causes host to go into reconnecting state

Component 	Version
Rancher 	v0.39.0-rc1
Cattle 	v0.95.0
User Interface 	v0.52.0
Rancher Compose 	beta/latest

With rancher-compose version v0.4.0, tried to create a service that builds locally. It uploaded the build to s3 and I was able to download from that url. Started the service. Host where rancher-compose container gets created went to disconnected state.
Dockerfile
FROM nginx

CMD ["nginx", "-g", "daemon off;"]

docker-compose.yml
nginxapp:
  restart: always
  tty: true
  stdin_open: true
  build: .

Arunkumars-MacBook-Pro-2:rancher-compose-latest aruneli$ ./rancher-compose create
INFO[0000] Creating stack rancher-compose-latest
INFO[0000] Creating service qa
INFO[0000] Uploading build for qa using provider S3
INFO[0006] Build for qa available at https://rancher-compose-latest-d5e4fd8594fb.s3.amazonaws.com/qa-614ef9e89d60?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJEV3EPWX4J5YDJVQ%2F20150924%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20150924T223742Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=dfbd0ad08e8b99692add229009b199e20e892e464e8351b1402d02f0f0b48aa5

@ibuildthecloud commented:
"In the python-agent code we download the S3 content and stream it directly to the Docker build API. I believe there is something getting messed up here, but I haven't had time to look into it. We were trying to be fancy and not copy the content to disk before sending it to the API, but I think that is specifically what is happening here. We should just locally download the file and then send it to the API."
More notes are in #3230

Verified in v1.0.1-rc2 that this is no longer an issue. Building does not cause reconnecting hosts.


Monitoring for docker instances/EC2 instances/applications

It's great that we have prometheus monitoring the main app - we should extend the config to monitor the remaining bits of our deployment.

Update: It looks like prometheus is not monitoring the actual instances right now - but just the load balancer. We should be monitoring all the applications/VMs deployed.

Do we need to monitor all 4 VM instance (2 from TEST cluster, 2 from PROD cluster)? One instance from each cluster is always down when other is runing. It is a restriction of ECS

If your task uses fixed host port mapping (for example, your task uses port 80 on the host for a web server), you must have at least one container instance per task, because only one container can use a single host port at a time. You should add container instances to your cluster or reduce your number of desired tasks.

Also, can Prometheus monitor the remaining bits of our deployment?

I think we should monitor all the available instances - we can create a rule that at least one is up in the prometheus config afterwards (with a longer duration as well).
In theory prometheus can read a number of standard performance counters
https://prometheus.io/docs/instrumenting/exporters/
I don't have any personal experience with these - so if its easy we can use them for the DB, redis,   solr and the load balancer. If they turn out to be a pain - we can push the integrations later. I think getting all the machines into prometheus though would be a requirement - as we spin them up/shut them down.

https://prometheus.io/docs/operating/configuration/#<ec2_sd_config> might be helpful as well.

I've added monitoring for PostgresSQL and Redis. It's weird, but it seems there no Solr exporter.
Also, how do you think to monitor the load balancer?

Interesting - I think https://github.com/prometheus/cloudwatch_exporter is
probably what we'd use for the AWS load balancer .
for Solr - I think using the built-in JMX is the way to go:
https://wiki.apache.org/solr/SolrJmx
https://github.com/prometheus/jmx_exporter
On Wed, Nov 9, 2016 at 8:57 PM, akarasev<EMAIL_ADDRESS>wrote:

I've added monitoring for PostgresSQL and Redis. It's weird, but it seems
there no Solr exporter.
Also, how do you think to monitor the load balancer?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TransparentWorld/Issues/issues/10#issuecomment-259581511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYh1EOW2m-GuJhoSTPg3GlWdyze4D_6ks5q8nn-gaJpZM4J1ZpL
.

This nearly looks good - will take a look this week at https://prometheus.io/docs/operating/configuration/#<ec2_sd_config> as well as setting up basic alerts for GCHell/out of memory/max CPU etc.


Debugging

I was having a strange issue where the links were not being properly redirected to for my QR code project. I really want to finish this QR code thing and get it behind me so I can start on something new, so I'm hoping to fix the bug now and be done with it. I wanted to be able to see all of the variables before the automatic redirect, so breakpoints were perfect so as to not lose the variables and data from the original page.

Here I first wanted to check to ensure that the backend call was working correctly. It's a pretty simple call and after analyzing this breakpoint I saw that this was not the issue.

This was the first breakpoint. It was within a for loop in which intervals is built, so I was able to analyze each new addition to intervals.

This is the first point, working as intended.

This is the second point, which is not working as intended. This should be 0.75, as it should add the previous value of .5 with the next frequency of 0.25.

This is the third and final interval being added. None of these intervals should be above 1 so it's not quite right, but actually it should have added .25 to the previous value which it did do correctly. It looks like this is the issue and why the code is not running correctly.

This second breakpoint was placed in case there was some issue with the comparison of num and intervals causing the bug.

Using this breakpoint I can see that it is functioning as intended. When i = 0, shown by the breakpoint as the current state, it should compare .622 < .5 and not return the function, continuing the loop. When I continue playing to find this breakpoint again, I see that this is the case and the next comparison works correctly (given incorrect input data).

Now it is compating .622 < 1, since i = 1 (again shown by the breakpoint). This in theory should redirect me to the page. And when I run the code....

It correctly redirects me to the second link. Through this process I identified that something is wrong with my logic creating the list of frequencies, and that's what I need to fix.

2.0/2.0
Toby clearly explained each step of his debugging process and showed understanding of the code that he was working with. In addition, he had a valuable debugging session where he was able to fix an issue with his code that was apparent before the session and relevant to the project.


Handle null forkId gracefully

PR description
When asking for the forkId for the chain head sometimes we may return
null. In those cases return an empty list.
Fixed Issue(s)
Fixes #3343
Changelog

[X] I thought about the changelog and included a changelog update if required.

I'm setting a bad example for branch management.


Raw GeoJSON or TopoJSON support

It would be great if this library could read raw GeoJSON or TopoJSON files.

Do you mean Geo/TopoJSON tiles?

Yes tiles, sorry.


Gym environments in Nevergrad

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue
Gym is something cool.
How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x] All tests passed, and additional code has been covered with new tests.

Presumably deprecated, TBC.


How do I hide a helper function from being exported? - DoNotExportAttribute not found

I saw this:

Microsoft.Azure.PowerShell.Cmdlets.Aks.Models.DoNotExportAttribute

Used in C# and script cmdlets to suppress creating an exported cmdlet at build-time. These cmdlets will not be exposed by Az.Aks.

Microsoft.Azure.PowerShell.Cmdlets.Aks.Models.InternalExportAttribute

Used in C# cmdlets to route exported cmdlets to the ..\internal, which are not exposed by Az.Aks. For more information, see readme.md in the ..\internal folder.

and tried using the first on a helper function:
filter HandleShowResult {
    [Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.DoNotExport]
    [CmdletBinding()]
    param (
        [Parameter(Mandatory, ValueFromPipeline)]
        [string]
        $ShowResult,

        [Parameter(Mandatory)]
        [string]
        $ResourceGroupName,

        [Parameter(Mandatory)]
        [string]
        $SubscriptionId
    )

    # Get name of machine registered
    $selectStrResult = $ShowResult | Select-String -Pattern "^Resource Name\s+:(?<resourceName>.*)\n"
    $Name = $selectStrResult.Matches.Groups |
        Where-Object Name -EQ resourceName |
        Select-Object -ExpandProperty Value

    # Return the ConnectedMachine object.
    Get-AzConnectedMachine -Name $Name -ResourceGroupName $ResourceGroupName -SubscriptionId $SubscriptionId
}

<#
.Synopsis
API to register a new machine and thereby create a tracked resource in ARM
.Description
API to register a new machine and thereby create a tracked resource in ARM

.Link
https://docs.microsoft.com/powershell/module/az.connectedmachine/new-azconnectedmachine
#>
function New-AzConnectedMachine {
...

But it just gave me:
Get-ScriptCmdlet: /Users/tyleonha/Code/PowerShell/azure-powershell/src/ConnectedMachine/custom/Az.ConnectedMachine.custom.psm1:16
Line |
  16 |  … ember -Function (Get-ScriptCmdlet -ScriptFolder $PSScriptRoot) -Alias …
     |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find the type for custom attribute 'Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.DoNotExport'. Make sure that the assembly that contains this type is loaded.

Am I using this incorrectly? Do I need to import some module?

I am thinking we may adding a help folder in the custom folder. And for cmdlets in these, we hide them when generating help and exports.

@TylerLeonhardt Hi Tyler, sorry for late response 😅 for your specific question, the answer is the namespace of DoNotExportAttribute was wrong in the docs. The real one should be Microsoft.Azure.PowerShell.Cmdlets.{YourRP} (without Models. Here's a working example:
function HelloWorld {
    [Microsoft.Azure.PowerShell.Cmdlets.AppConfiguration.DoNotExport()] # can't omit ()
    [CmdletBinding()]
    param ()
}

I'll correct the docs and discuss other possibly better solutions of hiding some logic from being exported.

Plus, functions are not exported unless they have CmdeltBinding attrubte


Support for Selecting or Fetching Multiple Subtitle Languages from YouTube Videos

Currently, when fetching subtitles from YouTube videos, it is unclear how to select a specific subtitle language or retrieve all available subtitle files. This limitation can make it challenging to work with videos that offer multiple subtitle languages. Can you support for selecting subitle languages or fetching all subtiles? It would significantly enhance the tool’s functionality and versatility. Thanks for your works.

Thank you for your detailed explanation and thoughtful response. I appreciate your transparency about the current limitations and challenges due to YouTube’s API changes. I look forward to future developments and improvements.


Fix delete progress not filtering model

Codecov Report

Merging #226 (dc9185d) into master (83c3dcd) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
- Coverage     60.50%   60.48%   -0.03%
  Complexity      716      716
============================================
  Files           134      134
  Lines          2646     2647       +1
  Branches        295      295
============================================
  Hits           1601     1601
- Misses          941      942       +1
  Partials        104      104

Impacted Files
Coverage Δ

...tutoraid/logic/commands/DeleteProgressCommand.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c3dcd...dc9185d. Read the comment docs.


one spark progress per cell

all the jobs should appear in the same foldout.

we reverted attempt at fixing https://github.com/twosigma/beakerx/issues/7269
so this is no longer a problem.