Rate limit per request method

I am working on implementing rate limiting with this library and ran into an issue when multiple endpoints share the same path but different methods. For example:
GET   /towns
POST  /towns

Using the pattern matching to set up limits would apply the same limit to both endpoints, but this is not desired.
...
config={
    r"^/towns": [Rule(second=10)],
}
...

A workaround I have found is in the auth function, getting the method and then using the method in the group name.
async def AUTH_FUNCTION(scope: Scope) -> Tuple[str, str]:
    ...
    method = scope['method'].lower()
    ...
    return user_unique_id, f"{method}-groupname"

Limits per method can then be set by
...
config={
    r"^/towns": [
        Rule(group="get-groupname", second=10),
        Rule(group="post-groupname", second=2),
    ],
}
...

Thoughts around improvements
In the rule.py, I see that the key in redis is
f"{path}:{user}:{name}": (limit, TTL[name])

Adding in the method to this key should take care of this on the backend
f"{path}:{method}:{user}:{name}": (limit, TTL[name])

And then in the Rule implementation, adding a field to specify method could look something like
Rule(group="groupname", method="get", second=10),
Rule(group="groupname", method="post", second=2),

Interested to hear some thoughts around this (and if i missed something obvious). Thanks

{
  'GET': {
    r"/path": [ Rule() ]
  },
  '*': {
    ......
  }
}

This seems to be fine too.

Interesting, I didn't see that in the README / examples. So the config could look like
{
  'GET': {
    r"/path": [ Rule(second=10) ]
  },
  'POST': {
    r"/path": [ Rule(second=2) ]
  }
}

and the different rate limits would be applied per http method?

I am testing this out right now and am not able to confirm this works
app.add_middleware(
    RateLimitMiddleware,
    authenticate=AUTH_FUNCTION,
    backend=RedisBackend(redis),
    config={
        'GET': {
            r"^/towns": [
                Rule(minute=1, block_time=10),
                Rule(group="authorized", minute=6),
                Rule(group="admin"),
            ]
        },
        'POST': {
            r"^/towns": [
                Rule(minute=1, block_time=100),
                Rule(group="authorized", minute=2),
                Rule(group="admin"),
            ]
        }
    }
)

I have logs in my auth function that are not showing up when i try this route. I am on version 0.9.0, is this feature on a different version?

Well, this is just another solution I thought of to this question you asked. It is not actually implemented in the code.
The question you have raised is good, and I think we should take the time to resolve it.

Ahh i see, i thought you were saying it was already implemented. I took some time and made a quick implementation PR, let me know what you think. I was not able to get the tests to run, I'm not familiar with the httpx library, but I added a test that should cover it. This implementation works in my testing

Hmm actually having an issue when setting two rules for different http methods, ill push a fix when i get something working
This is currently giving me issues:
config={
    r"/forests": [
        Rule(second=1),
        Rule(group="authorized", method="get",  minute=1),
        Rule(group="authorized", method="post",  minute=2),
        Rule(group="admin"),
    ]
}

If someone in the authorized group hits the limit for one HTTP method, it limits them for the other method. Thinking there is something wrong with either the key in redis, not sure yet.

Got it working locally using the RedisBackend, I had to update the keys used in redis. I updated the redis.py and slidingredis.py, haven't had a chance to dive into the simple.py backend, but will try to get something in that soon

I saw the actions failed, I just pushed another commit with some more docs. Let me know what you think, thanks

I saw the actions failed, I just pushed another commit with some more docs. Let me know what you think, thanks

https://github.com/abersheeran/asgi-ratelimit/actions/runs/3269652151/jobs/5379899654
Looks like it's because of code formatting issues. Just run the following code to format.
black .
isort .

Is there any way to re run a specific action job? Looks like only one failed and it was during the install dependencies Linux-Test (3.10, 4)

@abersheeran I see the tests are passing now. What are your thoughts on getting this PR merged and the feature released? We would love to use this feature in our use case. Thanks!

Sorry for the lateness, the PR has been merged. Soon I will release a new version.

@abersheeran just checking back in on the status of the new version release


Fix rustc version regression

This commit:

Pins the rustc version to 1.32
Rearranges the mutable iterator logic to pass older versions of the borrow checker (pre-1.36)

Fixes #31

I've pinned to 1.32 because its the most recent version that seems to work for me on https://github.com/yeslogic/ddl, but it might be compatible with earlier rustc versions too.


How to prepare the data for trainN.py?

Hi, thanks for this amazing repo. @JiaxiongQ
I'm trying to get trainN.py and nomalLoader.py to work in order to train the first NN.
This is what I understood so far that I need in order to train:

Download data_depth_velodyne which is the sparse Lidar dataset.
Download data_depth_annotated which is the ground-truth (Dense) Lidar dataset.
Use the second repo. in order to generate from the ground-truth Dense Lidar dataset the ground-truth normals.
Download ALL the RGB Kitti images from all the categories ( City | Residential | Road | Campus | Person | Calibration ), Is there a link to download all at once instead of downloading one by one?

Question 1: Do I need to extract all the RGB Images into the folders one by one into data_depth_velodyne/train/..*sync/ - I need to add image_02 and image_03 folders to each of the sync folders? (This is implied from your code)
Question 2: Is there a way to download all the RGB Images in one-shot instead of clicking one by one and extracting them one by one to all the folders?
In nomalLoader.py the function dataloader(filepath) returns 3 variables: left_train,normalS_train,normal_gts which are:
a. left_train -  the RGB Kitty Image folders 'data_depth_velodyne/train/..*sync/image02 & 03/data.
b. normalS_train - - the Sparse lidar folders 'data_depth_velodyne/train/..*sync/proj_depth/velodyne_raw/image02 & 03/.
c.  normal_gts is the folder which has all the normals I generated from dense gt: data_depth_annotated/*_sync/proj_depth/groundtruth/image_02 & image_03 -> gt/out/train/*_sync/image_02 & image_03 or should it be all in gt/out/train/*_sync/? Because in the code there isn't anything about concatinating the image_02 & image_03.
Question 3: please look at c., I asked there about the ground-truth normals.
Question 4: When and where the synthetic data is used? Do we use it also in trainN.py? Do we use it in all the 3 NNs?
Question 5: How many epochs is recommended to train on?
Other than that, thank you. It took me so many hours just to get to the point I understand how to get the data ready (and still trying), I'll definitely add a guide on how to prepare the data to train after this post, so others can save many hours to understand the process.

1: Yes, we used images from left camera and right camera.
2. Sorry, I don't know where this link exists.
3. I think it doesn't matter, you could just confirm that all the file names from different folders can be matched.
4. We just trained our surface normal model on the synthetic data firstly and then finetuned it on the KITTI to get better surface normal.
5. All 3 NNs are trained on 15 epochs, but the last one used lower learning rate.
Thanks for your good questions! I think they also can help others.

I see, thank you for the answers!
I'll update later with my progress and write a full step-by-step on how to do it for people who are confused in the beginning like me.

@JiaxiongQ
For training with Synthetic data:
I use RGBRight and RGBLeft folders,
Sparse Lidar dataset in the folder lidar
And finally, the ground-truth normals from dense depth lidar I take from the folder Normal_m right?

Yes, because we only generated surface normal from the depth of left camera.

Yes, because we only generated surface normal from the depth of left camera.

Thank you!

Hi, @JiaxiongQ
I've prepared the folders to train:
RGBLeft, Normal_m, and lidar which are located in ./TOWN11/SEQ0 to see that the training works.
And I'm getting an error in trainLodaerN.py:
  File "/home/unknown/depth_est/DeepLiDAR/dataloader/trainLoaderN.py", line 75, in __getitem__
    normal = self.normal[index]
IndexError: index 618 is out of bounds for axis 0 with size 495

Any ideas why this happens?

After I prepared the 3 folders: RGBLeft, lidar and Normals_m from /Town11/SEQ (to test that the training work), I'm getting the following error:
  File "/home/unknown/depth_est/DeepLiDAR/submodels/depthCompleNew.py", line 155, in forward
    inputS = torch.cat((sparse,mask),1)
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 1. Got 512 and 256 in dimension 2 at /pytorch/aten/src/THC/generic/THCTensorMath.cu:71

In our 'dataloader/trainLoaderN.py', there is:

So you should not need to do 'np.transpose'.

I see, but that still doesn't work, I attached an images of the bariables before exiting __getitem__ function in trainLoaderN.py:

Same error: (Haven't changed anything in the code except loading the images in nomalLoader.py:
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 1. Got 512 and 256 in dimension 2 at /pytorch/aten/src/THC/generic/THCTensorMath.cu:71

Sorry, I don't know why this would happen, but you can use ‘torch.permute()’ to change the dimension and make all the dimension of inputs like  (b, c, 256, 512).

Sorry, I don't know why this would happen, but you can use ‘torch.permute()’ to change the dimension and make all the dimension of inputs like (b, c, 256, 512).

Hi @JiaxiongQ ,
I'm out of ideas, any chances you could help me out with this any further?
Here's the code to prepare the 3 folders from Town11/SEQ0:
def dataloader_synthetic(filepath):
    imagesl = []
    normalS = []
    normal_gts = []
    temp = filepath

    filepathl = temp + 'Town11/SEQ0' #RGB dataset folder, Left and Right
    filepathgt = filepathl + '/Normal_m'
    #seqs = [seq for seq in os.listdir(filepathl) if seq.find('sync') > -1]
    left_fold = '/RGBLeft'
    right_fold = '/RGBright'
    lidar_foldl ='/lidar'
    #lidar_foldr = '/proj_depth/velodyne_raw/image_03'

    #for seq in seqs:
    left_path = filepathl + left_fold
    right_path= filepathl + right_fold
    lc= [os.path.join(left_path, img) for img in os.listdir(left_path)]
    lc.sort()

    #lc=lc[5:-5]
    rc= [os.path.join(right_path, img) for img in os.listdir(right_path)]
    rc.sort()
    #rc=rc[5:-5]
    imagesl = np.append(imagesl, lc)
    #imagesl = np.append(imagesl, rc)

    gt_path = filepathgt
    lids2l = filepathl
    lidar2l = [os.path.join(lids2l + lidar_foldl,lid) for lid in os.listdir(lids2l + lidar_foldl)]
    lidar2l.sort()
    normalS = np.append(normalS, lidar2l)
    #lids2r = os.path.join(filepathl, seq) + lidar_foldr
    #lidar2r = [os.path.join(lids2r, lid) for lid in os.listdir(temp)]
    #lidar2r.sort()
    #normalS = np.append(normalS, lidar2r)

    gt_imgs = [os.path.join(gt_path, norm) for norm in os.listdir(gt_path)]
    gt_imgs.sort()
    normal_gts= np.append(normal_gts, gt_imgs)
    #normal_gts= np.append(normal_gts, gt_imgs)

    left_train = imagesl
    normalS_train = normalS
    return left_train,normalS_train,normal_gts

Didn't change anything else.

This code is mainly for KITTI，you should modify it and just insure the file names can be matched.

This code is mainly for KITTI，you should modify it and just insure the file names can be matched.

Yes, I did, I modified it to work with the 3 folders with the synthetic, and it still doesn't work.

Regarding Q2, the raw KITTI data overview page provides a raw_data_downloader.sh script to download and extract all of the raw data zip files. A slightly modified version with cleaner status info output can be found here: https://gist.github.com/valgur/cb9da4d1370ccc13c7c6b7c8c632d3e2

Hi, thanks for this amazing repo. @JiaxiongQ
I'm trying to get trainN.py and nomalLoader.py to work in order to train the first NN.
This is what I understood so far that I need in order to train:

Download data_depth_velodyne which is the sparse Lidar dataset.
Download data_depth_annotated which is the ground-truth (Dense) Lidar dataset.
Use the second repo. in order to generate from the ground-truth Dense Lidar dataset the ground-truth normals.
Download ALL the RGB Kitti images from all the categories ( City | Residential | Road | Campus | Person | Calibration ), Is there a link to download all at once instead of downloading one by one?

Question 1: Do I need to extract all the RGB Images into the folders one by one into data_depth_velodyne/train/..*sync/ - I need to add image_02 and image_03 folders to each of the sync folders? (This is implied from your code)
Question 2: Is there a way to download all the RGB Images in one-shot instead of clicking one by one and extracting them one by one to all the folders?
In nomalLoader.py the function dataloader(filepath) returns 3 variables: left_train,normalS_train,normal_gts which are:
a. left_train - the RGB Kitty Image folders 'data_depth_velodyne/train/..*sync/image02 & 03/data.
b. normalS_train - - the Sparse lidar folders 'data_depth_velodyne/train/..*sync/proj_depth/velodyne_raw/image02 & 03/.
c. normal_gts is the folder which has all the normals I generated from dense gt: data_depth_annotated/*_sync/proj_depth/groundtruth/image_02 & image_03 -> gt/out/train/*_sync/image_02 & image_03 or should it be all in gt/out/train/*_sync/? Because in the code there isn't anything about concatinating the image_02 & image_03.
Question 3: please look at c., I asked there about the ground-truth normals.
Question 4: When and where the synthetic data is used? Do we use it also in trainN.py? Do we use it in all the 3 NNs?
Question 5: How many epochs is recommended to train on?
Other than that, thank you. It took me so many hours just to get to the point I understand how to get the data ready (and still trying), I'll definitely add a guide on how to prepare the data to train after this post, so others can save many hours to understand the process.

About Q2, You can find it in tool sets in KITTI homepage, someone support a script to download them all.

Hi @JiaxiongQ ,
After I prepared the 3 folders: RGBLeft, lidar and Normals_m from /Town11/SEQ (to test that the training work), I'm getting the following error:
  File "/home/unknown/depth_est/DeepLiDAR/submodels/depthCompleNew.py", line 155, in forward
    inputS = torch.cat((sparse,mask),1)
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 1. Got 512 and 256 in dimension 2 at /pytorch/aten/src/THC/generic/THCTensorMath.cu:71

sparse.shape
(4, 1, 256, 512)
mask.shape
(4, 256, 512, 1)
I probably need to change the 1 in mask to be after 4 and it will be fixed, I'll try that out and update. But why doesn't it work out of the box? I didn't see any posts about this when training the first NN, did I do something wrong in the process?
EDIT: When changing the shape with np.transpose so that mask will have (4,1,256,512), it gives me a new errors, also other errors happen if I change sprarse instead.. any ideas how to solve this? I'm out of ideas, also didn't see anyone here saying they got this error when training. I double and triple checked my paths and the images and len of images (495 images) is for every of the 3 folders, so the data itself should be fine.

I meet the same problem about dimension mismatch, I have change a lot to fit it on sythtic dataset, I you could debug the program step by step to change the dimension order to fix it. the recommend dimension order of PyTorch  is (B, C, H, W). May it help you

Q1:Yes, we use images from the left camera and the right camera;
Q2:We don't find this link, we just download the dataset one by one;
Q3:It is flexible to organize files, you just need to make sure that all
the images are corresponding;
Q4:No, you just need to use the one DCU to train surface normal. The
synthetic data is used to improve the quality of surface normal, the
download link is in README.md;
Q5:The whole training process takes 15 epochs on 3 GPUs(1080 ti).
On Thu, Apr 9, 2020 at 9:24 AM graycrown<EMAIL_ADDRESS>wrote:

Hi, thanks for this amazing repo. @JiaxiongQ
https://github.com/JiaxiongQ
I'm trying to get trainN.py and nomalLoader.py to work in order to train
the first NN.
This is what I understood so far that I need in order to train:

Download data_depth_velodyne which is the sparse Lidar dataset.
Download data_depth_annotated which is the ground-truth (Dense)
Lidar dataset.
Use the second repo. in order to generate from the ground-truth
Dense Lidar dataset the ground-truth normals.
Download ALL the RGB Kitti images from all the categories ( City |
Residential | Road | Campus | Person | Calibration ), Is there a link to
download all at once instead of downloading one by one?

Question 1: Do I need to extract all the RGB Images into the folders
one by one into data_depth_velodyne/train/..*sync/ - I need to add
image_02 and image_03 folders to each of the sync folders? (This is
implied from your code)
Question 2: Is there a way to download all the RGB Images in one-shot
instead of clicking one by one and extracting them one by one to all the
folders?
In nomalLoader.py the function dataloader(filepath) returns 3 variables:
left_train,normalS_train,normal_gts which are:
a. left_train - the RGB Kitty Image folders 'data_depth_velodyne/train/..sync/image02
& 03/data.
b. normalS_train - - the Sparse lidar folders 'data_depth_velodyne/train/..sync/proj_depth/velodyne_raw/image02
& 03/.
c. normal_gts is the folder which has all the normals I generated from
dense gt: data_depth_annotated/_sync/proj_depth/groundtruth/image_02 &
image_03 -> gt/out/train/_sync/image_02 & image_03 or should it be all
in gt/out/train/*_sync/? Because in the code there isn't anything about
concatinating the image_02 & image_03.
Question 3: please look at c., I asked there about the ground-truth
normals.
Question 4: When and where the synthetic data is used? Do we use it
also in trainN.py? Do we use it in all the 3 NNs?
Question 5: How many epochs is recommended to train on?
Other than that, thank you. It took me so many hours just to get to the
point I understand how to get the data ready (and still trying), I'll
definitely add a guide on how to prepare the data to train after this post,
so others can save many hours to understand the process.
About Q2, You can find it in tool sets in KITTI homepage, someone support
a script to download them all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JiaxiongQ/DeepLiDAR/issues/22#issuecomment-611276326,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJANJRATRINBRO3ODJPHKOTRLUPWHANCNFSM4KCWAYVA
.


Tunnel (CONNECT) also HTTP over proxy

A feature. It would be great if we had an option to tunnel also HTTP over a specified proxy. That is, first doing CONNECT, just as is done (and required) for getting HTTPS though a proxy. curl has this, and it is called --proxytunnel.

I've seen the feature here and there, but so far I still don't see any reason to use it. I'm curious why you feel it would be great :D

Ah yes, it would be useful for connecting to Tor's HttpTunnelPort which is a peculiar "http proxy" which only supports CONNECT. Admittedly, it is a bit of a kludge, just to get around another kludge. (Certainly, proper SOCKS supports would also solve this...). I'm going to have a look if I find time, it'll be a great exercise in Rust :)

Could this be why reqwest stops failing inside of telepresence? (They use torsocks to implement their features)


Feature/help

Added a 'help' command so you can get help from within sbt so you don't need to go to the sbt-groll page to know how to use it.
Note! The help info already contains info about the 'tag' support for the Initial command. See my other pull request.

Thanks!

Released 4.8.2


Similarity race condition patch

What changes are proposed in this pull request?
To reproduce (as of v2.1.3):

Load the quickstart dataset and compute similarity with CLIP
Create a view stage with Limit 200
Sort by text similarity against dogs

This error gets raised by the App:
To catch this error, launch the path with:
python /path/to/your/install/of/fiftyone/server/main.py

File "/home/eric/work/fiftyone/fiftyone-teams/fiftyone/utils/torch.py", line 580, in __exit__
    self._no_grad.__exit__(*args)
AttributeError: 'NoneType' object has no attribute '__exit__'

How is this patch tested? If it is not, please explain why.
TBD
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

Fixed a race condition when sorting by text similarity on a view in the App.
What areas of FiftyOne does this PR affect?

[X] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Summary by CodeRabbit

Bug Fixes

Improved error handling in the context management of the TorchImageModel to prevent potential exceptions.

Thanks Brian!


updateCustomODE[] duplicates ODEs

With the model MODEL1303260018, when doing the following:
newODE = model["CustomODE"] /.Toolboxspecies["ATP", "cell"][t] -> Toolboxspecies["ATP", "cell"];
updateCustomODE[model, newODE];
The ODEs that have changed in newODE are simply duplicated in the model, instead of being substituted.

Why should they be substituted? They are not the same. Use setCustomODE to overwrite the old ODEs.


Add ignoreError feature to dag task

This PR adds the optional attribute "ignoreError" to Argo's DAG task.
If this attribute is set to true the DAG tasks will proceed even if the tagged task fails.
This feature is useful if you want to execute all test and get a result from all of them without the need to depend on successful dependent steps.
This is necessary as some tests need to be run in parallel but we even want the result of serial task that run afterwards.
As the additional attribute is optional it does not break current workflows.
Here is an example workflow where the task B has "ignoreError: true" :

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@schrodit thanks for this. it has been a commonly requested feature. @edlee2121 how do you feel about the DSL syntax? One issue I see is that we actually already use the term error and failure separately. And they are meant to have different meanings (failures are under user control, errors happen during initializing/saving).
I think the we syntax should be clear which case it is handling, or if it is handling both. When thinking about this before, I had thought of the term bestEffort: true, but that syntax would also not distinguish errors vs. failures.
We may want to leave this open such as:
ignore:
  errors: true
  failures: true

Second thing is that we will want to additionally support this in steps, and not just DAGs, because these levels of control are supposed to have feature parity between steps/dags.

Yes, it would be great if this works for steps as well.
If we already distinguish between failures and errors then I think we should preserve the distinction.
What does everyone think of ignoreExitStatus
Trying to find the right balance between precision and conciseness :-)

I totally agree that it would make sense to distinguish between errors and failures.
We also have this use case and I think it would make a lot of sense to give the freedom of choice.
What do you think about about the term ContinueOn?
continueOn:
  error: true
  failure: true

@jessesuen I can also implement this behavior for steps.

This looks good to me. @jessesuen?

@jessesuen @edlee2121
I renamed the attribute to continueOn and implemented different behavior for NodePhase error and fafiled.
I also added the functionality to steps.
Can you please review?


[SPARK-46077][SQL] Consider the type generated by TimestampNTZConverter in JdbcDialect.compileValue.

What changes were proposed in this pull request?

Considering the following case
./bin/spark-shell --packages org.postgresql:postgresql:9.4.1211 --conf spark.sql.timestampType=TIMESTAMP_NTZ

spark.sql("create table tz3 using jdbc options('url' 'jdbc:postgresql://localhost:5432/postgres?user=postgres&password=postgres', 'dbtable' 'public.tz', 'driver' 'org.postgresql.Driver', 'preferTimestampNTZ' 'true') as select 1 as id, to_timestamp('2021-04-01 00:00:00', 'yyyy-MM-dd HH:mm:ss') as ts")

spark.sql("select * from tz3 where ts=to_timestamp('2021-04-01 00:00:00', 'yyyy-MM-dd HH:mm:ss')").show

The generated query is incorrect because the literal is not quoted
ERROR:  syntax error at or near "T00" at character 81
STATEMENT:  SELECT "id","ts" FROM public.tz  WHERE ("ts" IS NOT NULL) AND ("ts" = 2021-04-01T00:00)

TimestampNTZConverter generates a LocalDateTime value that we do not consider in JdbcDialect.compileValue
Why are the changes needed?

It solves the bug explained
Does this PR introduce any user-facing change?

No
How was this patch tested?

With unit tests and manually
Was this patch authored or co-authored using generative AI tooling?

No

Thanks @MaxGekk ! Done

Dear groups and respected programmers، I open bookmarks as fast as possible
in Linux or Windows America and the assets of servers are hacked whenever
possible and I have governments to cooperate fully to protect them
ShahrzadMahro
در تاریخ دوشنبه ۲۶ فوریه ۲۰۲۴، ۱۸:۴۱ Pablo Langa @.***>
نوشت:

What changes were proposed in this pull request?
Considering the following case
./bin/spark-shell --packages org.postgresql:postgresql:9.4.1211 --conf spark.sql.timestampType=TIMESTAMP_NTZ
spark.sql("create table tz3 using jdbc options('url' 'jdbc:postgresql://localhost:5432/postgres?user=postgres&password=postgres', 'dbtable' 'public.tz', 'driver' 'org.postgresql.Driver', 'preferTimestampNTZ' 'true') as select 1 as id, to_timestamp('2021-04-01 00:00:00', 'yyyy-MM-dd HH:mm:ss') as ts")
spark.sql("select * from tz3 where ts=to_timestamp('2021-04-01 00:00:00', 'yyyy-MM-dd HH:mm:ss')").show
The generated query is incorrect because the literal is not quoted
ERROR:  syntax error at or near "T00" at character 81
STATEMENT:  SELECT "id","ts" FROM public.tz  WHERE ("ts" IS NOT NULL) AND ("ts" = 2021-04-01T00:00)
TimestampNTZConverter generates a LocalDateTime value that we do not
consider in JdbcDialect.compileValue
Why are the changes needed?
It solves the bug explained
Does this PR introduce any user-facing change?
No
How was this patch tested?
With unit tests and manually
Was this patch authored or co-authored using generative AI tooling?
No
You can view, comment on, or merge this pull request online at:
https://github.com/apache/spark/pull/45261
Commit Summary

6b50407
https://github.com/apache/spark/pull/45261/commits/6b50407e892254c7353a3ac1b2d986f40d848e0d
add test
f8f6544
https://github.com/apache/spark/pull/45261/commits/f8f6544c5062d06a9f37be155e8fbe7c89c32e11
Fix

File Changes
(2 files https://github.com/apache/spark/pull/45261/files)

M
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
https://github.com/apache/spark/pull/45261/files#diff-1533255ad629a18e883f8186b303fdf4fae99043551ce20c5b5ea06d085e0b14
(1)
M sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
https://github.com/apache/spark/pull/45261/files#diff-f199a0c955304669dded23f71aabd41cd5e69680d91a007f5e3a37fb1d647c59
(2)

Patch Links:

https://github.com/apache/spark/pull/45261.patch
https://github.com/apache/spark/pull/45261.diff

—
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/45261, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANEZZRFMLBHCYJD6F5Q2GZ3YVSQZ5AVCNFSM6AAAAABD2MADD2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TINBRGAYTQNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Pass a preconfigured HttpSender to the trace exporter

There may be cases where you want to be able to configure aspects of the HttpSender, like adding headers or authentication.
This will allow the exporter to use a sender with those configurations when the default isn't enough

Can you run the Java formatter to format the code?
$ ./gradlew goJF

Apologies for the formatting and version issues. I believe I have fixed them :)

@bogdandrutu Thanks for the review. Just wanted to chime in to note that @achandras is working with me at SignalFx (so you know where this is coming from!).


Prevent SIGSEGV in SplitMolByPDBResidues

Reference Issue
Fixes #5599
What does this implement/fix? Explain your changes.
The SplitMolByPDB* functions dereference an Atom's MonomerInfo* that may be null if the molecule was not loaded from a PDB. This leads to a SEGFAULT in Python.
This change adds a check for non-null MonomerInfo* before dereferencing it to avoid this crash.
Any other comments?
Added a basic unit test that calls these functions as in #5599

The CI build failures are not due to anything in this PR.
Something has changed on the Mac CI machines, they don't seem to have conda installed any more, that is causing the problems. I will look into it.

Thanks for reviewing! I've pushed an update to remove the bare asserts


MRG: Fix cov

Fix a little bug introduced by #4808, with test to ensure we hit that code path in the future.

thx @larsoner


sites with missing coordinates

There are a handful of sites with missing coordinate data, which are included in ForC_sites, and also in this file. I do not see the purpose of the latter file, so I will delete it.

@Troger4 , it would be helpful if you could see whether you can find the coordinates for the sites with missing coordinates. If the original publications don't give coordinates, please copy the description of the site location into geography.notes.


test: Added unit tests for backend controllers using jest

Summary
This pull request (PR) aims to enhance the project by adding unit tests for the backend controllers and improving the overall test coverage.
Description
In this PR,

Improved project structure by moving controllers from the routes folder to a dedicated controllers folder. The existing controller functions have been moved from the routes folder to this new location. This change enhances the overall code organization and maintainability of the application.
created setup for tests using jest
Added unit tests for various backend controller functions

Images

Code Coverage

Issue(s) Addressed
Closes #5
Prerequisites

[x] Have you followed all the CONTRIBUTING GUIDELINES ?

Hi @hemant14050, Thank you for your efforts and time for writing the much needed test cases, greatly appreciated. One small request, can you kindly rebase your branch and commit, because we had recent changes merged in the posts api...

Hi @hemant14050, Thank you for your efforts and time for writing the much needed test cases, greatly appreciated. One small request, can you kindly rebase your branch and commit, because we had recent changes merged in the posts api...

Hello @krishnaacharyaa, I have rebased and added new changes to posts api. Please review and update me if any other changes need from my side :)

We can -

convert this PR into a draft PR and work on these issues.
OR
or merge this PR for now and add new tests when we're done working on those issues.

Hey @hemant14050, can I indulge you into something that bothers me about this PR? 😛
This can actually be split into two separate PRs, as there are two features being merged in this PR:

The test setup and the actual tests.
The API controllers (just the first commit of this PR: 349e0f29c667ef9a31731ae57a07253641064ea5)

The controllers are good to go, but, because the tests potentially need some work, the controllers are also being blocked along with tests.
Let's forget about it this time... or if you're up for it, I can help you with creating a separate PR for the controllers. Totally your choice :)

Hey @hemant14050, can I indulge you into something that bothers me about this PR? 😛 This can actually be split into two separate PRs, as there are two features being merged in this PR:

The test setup and the actual tests.
The API controllers (just the first commit of this PR: 349e0f2)

The controllers are good to go, but, because the tests potentially need some work, the controllers are also being blocked along with tests.
Let's forget about it this time... or if you're up for it, I can help you with creating a separate PR for the controllers. And that's totally your choice :)

That's seems very reasonable to me, @hemant14050 can we do it this way, so that your efforts are considered and pushed as a PR and you can then work on this test cases :) For setting up the PR from this kindly take help from @chinmaykunkikar, he would be happy to help you if you face any difficulties ...


lodash: signatures of the method _.takeRightWhile changed

https://lodash.com/docs#takeRightWhile
https://lodash.com/docs#_ (description of the chainable wrapper)

thanks mate!


Space between \begin or \end and the following brace

Issue Summary
If a space is included after \begin or \end and the following brace, the environment is not rendered.
Ex. \begin{equation} works, but \begin {equation} does not.
(I didn't see this addressed in the docs or in previous Github issues.)
Supporting information:
<!DOCTYPE html>

<meta charset="UTF-8" />

No spaces:

\begin{equation}
y=mx+b
\end{equation}

Space after begin:

\begin {equation}
y=mx+b
\end{equation}

Space after end:

\begin{equation}
y=mx+b
\end {equation}

You are correct, the search pattern for the \begin command doesn't include spaces.  I will look into fixing that.

I have made a PR to resolve the issue.  Thanks for the report!


[SUGGESTION] Add ability to add games from itch.io, indiegala

I'm impressed with the ability to add games from GOG and Epic (the latter doesn't work for me, however).  I'm making the suggestion to have Steam-Buddy be able to add games from itch.io and/or indiegala in a similar manner it can add games from Epic, GOG, or flathub.

Indie gala will likely never happen, so closing in favor of #241


Added perfect number check algorithm

Wrote a simple program that checks whether or not a number is perfect

Just updated the code, thanks for the notes

Hi faheel and aaboaf, I was looking at this commit, and i noticed that the complexity of displaying all of the perfect numbers less than N is O(sqrt(N) * N). However, it we were to use a sieve method this could be done in O(N * log(N)) time.
In particular, we could have a large int array (to eventually contain the sum of the divisors of each index) with index values up to N, and for each index i>=0 we could loop through all of the multiples of i in the array and add i to their value.
This sieve has space complexity of O(N), which might make it a less attractive option, as there are very few perfect numbers in the very large range of [1..(2^64) - 1]. However, this algorithm could be adapted to work as an efficient method to determine whether numbers are deficient or abundant as well.

@eskeype Your method would definitely be more efficient in finding perfect numbers but at a very high cost of memory space. To find out the perfect numbers between 1 and 227 only we would require about 1 GB of memory. That's a lot of memory for finding just 5 perfect numbers!

@aaboaf I now realise that keeping the program as simple as it originally was would be the best, because finding all perfect numbers within a large range would either require a lot of memory if done very efficiently, or a lot a processing time if done not so efficiently.
So just determining whether a given number is perfect or not in O(√N) time and O(1) space is feasible even for very large values of N (upto 264-1).

wILL DO

Thank you for your time and contribution @aaboaf! And congratulations on your first PR merge :smiley:


Building for mac catalyst

Hi I created a stackoverlfow post already: https://stackoverflow.com/questions/75473220/build-tensorflow-lite-for-mac-catalyst/75480973#75480973
But I thought I should have asked here first.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac mini M1 Ventura 13.1
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.10.0
Python version: 3.10.8
Bazel version (if compiling from source): 5.3.0
GCC/Compiler version (if compiling from source): clang 14.0.0
Exact command to reproduce: bazel build --config=catalyst //tensorflow/lite:tensorflowlite.framework

Describe the problem
So I'm trying to build tensorflow lite from source (github) with bazel for mac catalyst and I wanted to know if it is featured and if not if there is anyway I could build it.
Source code / logs
For now without modification of any sort I have this error: ERROR: Config value 'catalyst' is not defined in any .rc file

Hi, @pjpratik
Could you please look into this issue ? Thank you!

Hi @Nnevalti, as far as I know we don't especially support mac catalyst, can you try doing whatever you want to do with normal iOS/macOS workflows and see if you run into any trouble? If so, we can identify more specifically what is unsupported and possibly make a feature request.

Hello, so in the end I changed my code so I can use the MacOS library instead of catalyst. I did not succeed in compiling for Mac Catalyst, I lack knowledge for it !

Hi @Nnevalti, can you show me how you tried compiling (i.e. what commands you used) and the error you get? Thanks.

It's been a long time so I don't remember everything, all I know is that i tried using bazel but there is no rule for the catalyst build. I don't remember if I tried to build using Cmake (for catalyst at least), I just used it to build the regular MacOS M1 library.
Currently I'm still a beginner concerning compilation and cross compilation, so I'm not sure about what needs to be done for it to work.

Hi @Nnevalti, fair enough, if you can replicate the issue, please let us know.

It's not an issue, tensorflow just doesn't support catalyst build. I don't think it's an important feature, but I think it could help people in the future to look into it !

Hi @Nnevalti,
Thanks for raising this issue. Are you aware of the migration to LiteRT? This transition is aimed at enhancing our project's capabilities and providing improved support and focus for our users. As we believe this issue is still relevant to LiteRT we are moving your issue there. Please follow progress here.
Let us know if you have any questions. Thanks.


Dependabot doesn't notify about broken dependencies

Dependencies in my repo are not getting updated with new major versions.
Example: jest: ^24.7.1, latest is 25, no PR created by dependabot.
I think it started when I removed the lockfiles (I don't use them anymore) but I can't be sure.

@feelepxyz
We had a similar issue #4038 where a dependency that we release privately was not getting PRs to update because there was a new unmet peer dependency. There was no notification on GitHub, nor anything in the update logs saying that the update failed.
It would seem that you could open a PR to bump the dependency version and add the peer dependency. I get that CI might not catch errors, but if you opened it as a draft PR with a warning that it also adds a peer dependency, that would be great. At the very least, a GitHub notification saying that a PR could not be opened due to to a missing peer dependency would at least inform us that there is an issue that needs our attention, even if we have to manually intervene to add the peer dependency ourselves.

+1 one for opening a draft PR in such a case. The draft PR won't be merged automatically but the users will at least be aware that there's an issue.

We've shipped a lot of improvements to peer dependency support over the last few months, so we may be able to succeed in more of these cases: https://github.com/dependabot/dependabot-core/pulls?q=is%3Apr+is%3Aclosed+peer+dependency
But the overall theme of notifying when there's an error is still unresolved. That's already tracked in https://github.com/dependabot/dependabot-core/issues/3509 as a more generic issue beyond peer dependencies so I'm going to close this as a duplicate.


word wrapping for long lines

Mutually exclusive with horizontal scrolling #17

Given that horizontal scrolling has been implemented as of #20, this issue should probably be closed.

@aodhneine not really. The idea was to make an option that enables word wrapping and disables horizontal scrolling (since they are mutually exclusive).


mac m1 cannot use third

Thank you very much for developing this tool. However, it seems that it will only be available on windows, and the mac version of third is invalid and does not have the features described in the project.

mac shift + command + c 快捷键不生效


the mIOU on PASCALPerson- Part.

Can you tell me the mIOU and mAP on PASCAL Person- Part without  model aggregation
and label refinement ?Thanks.

@zrl4836
In this work, we only focus on the single person human parsing task.
Here is the result on Pascal Person Part (without test augmentation).
OrderedDict([('Background', 95.81902383435768), ('Head', 86.65342859445315), ('Torso', 70.68868908311313), ('Upper Arms', 61.14120935654282), ('Lower Arms', 60.57084355973503), ('Upper Legs', 53.81223502038692), ('Lower Legs', 51.45869139296766), ('Pixel accuracy', 94.43657830809342), ('Mean accuracy', 79.10083272671733), ('Mean IU', 68.59201726307948)])

OK,Thank you for your reply.


Move out AuthCtx type parameter from service layers, and have only Namespace

AuthCtx is the context required to create a Namespace (project-id, account-id). In other words, authorise if the context can access Namespace.
In many places the service traits takes this type parameter of AuthCtx which doesn't make much sense.
Service layer is simply concerned with working with the entities in the namespace, and not exactly the access to the namespace.
I think happens either due to the suboptimal usage or abuse of the idea of AuthCtx type parameterization in favor of some simplicity, or not understanding the whole idea. Or, may be it was a mistake from the beginning.
This ticket can also be used to review the code, and fix things across. If the idea of AuthCtx is suboptimal, may be we revisit.
I can also see Namespace being String in certain places with an argument that it largely simplifies the code. If this was done, then the decision of making it String should be applied to the whole in favor of consistency. In either ways, consistency should be maintained.  In my strong opinion, this String approach is deceivingly simple, and practically complex!

We have a recommended way to deal with these abstractions documented that we can use to shape our codebase as we move forward, but won't perform a "big refactoring" just for this, so closing this.


Saving a BREAD fails when one of the columns is named label

Laravel Version: 5.4.17
Voyager Version: 0.11.8
PHP Version: 7.0.5
Database Driver & Version: mysqlnd 5.0.12-dev - 20150407

Description:
Saving a BREAD fails with a foggy error when one of the database columns is named label
Steps To Reproduce:

Edit any existing table, add a column named label
Go to the BREAD editor of this table, try to submit
Changes are not saved, you are redirected to the BREAD again with the following error:

Update Failed Exception: Undefined index: field_required_`label`

This is a bug and will be fixed in the next update.


Support for elastic search syntax for unbounded RangeQuery

Is your feature request related to a problem? Please describe.
See #328
QUoting

I like this option from [ElasticSearch syntax]
(https://www.elastic.co/guide/en/elasticsearch/reference/6.3/query-dsl-query-string-query.html#_ranges):
field:>=5
field:>2
field:<3
field:<=12

Currently we  support foo:[* TO whatever] or foo:[whatever TO *]

Do we support this feature now?

No.

@dearsxx0918 I am working on the PR for this, which I hope to finalise and ship for the next release.
I would appreciate your feedback on the unit tests in my PR, in case you have use cases that I am currently not testing.


Entity synonyms fix

Proposed changes:

modified persist and load method to correctly handle the loading of the synonyms file

Status (please check what you already did):

[ x] made PR ready for code review
[x ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Edoardo Pedrotti:x: EPedrottiEdoardo Pedrotti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@EPedrotti woo first PR submitted, congrats! Can you sign the CLA please? looks like you used a different email for the first commit too, so might be good to add that to your github profile

Which mail do you see? I signed with the rasa mail but I wasn't aware that I used another for the first commit

It doesn't tell me which email but you can see there's two users in the CLA message right?

@EPedrotti looks like the build is still failing due to a pep8 error. Here's a screenshot of the relevant travis logs


Collection of (very) small changes

Change requests:

[x] distribute the nn blocks to the toolboxes. In the beginner toolbox: nn step, input and simple output neuron
[x] select a final name for the new nn plugin. Proposal: robot+NN
[x] select a colour for the NN blocks
[x] Name of the blocks, upper/lower case should be revised
[x] the nn input and output blocks should be default names (like variables) and functions
[x] Integration of a Boolean activation function
[x] After clicking on a neuron (status = yellow), you cannot return it to its original status by clicking on it again.
[ ] drop down menu in block change weight / bias for neuron names
[x] add get weight and get bias
[ ] xNN image for menu drop down
[ ] xNN image for start page
[x] xNN image for configuration background (will be the ev3 image)
[x] xNN image for the robot view in the simulation (will be the ev3 image)

This ticket can be open for some time and should assemble small requests (~4h time for implementation).
For new requests add comments. I (rbudde) will scan these comments and put them into the list

After clicking on a neuron (status = yellow), you cannot return it to its original status by clicking on it again. You have to click on another neuron or click on the drop-down "show values".

Bug?

wird ein NN Block deaktiviert, funktioniert das Program nicht

@rbudde
my a video explains more than i can with words..
https://user-images.githubusercontent.com/19221359/177318859-8d63518f-4a2b-41c7-b6b7-b88a1acd55d2.mov

@Thorlogy  I cannot reproduce this. On dev4 the robot works independant of activation/deactivation of the block

Categorie "Neuronal Network" has no german translation:

--------- add NO new change requests here -----------


Add proper border support for UI nodes

What problem does this solve or what need does it fill?
Adding borders to UI elements is a common need, both for design and debugging.
Currently, we can only set the width of the border, but not the color. So it doesn't have a real visual effect at the moment.
What solution would you like?
Ideally, we should be able to define the following properties:

Border color
Border width (this is already possible)
Border radius (i.e. round corners; both pixel and percent values should be possible here)

We could also think about supporting more complex styles, like dashed borders.
Once #5513 is merged, it probably makes sense to have all of these together in a style component.
Additionally, we could think about supporting outlines as well. These are essentially additional borders around the normal borders and can be used for accessibility features like visualizing keyboard focus.
What alternative(s) have you considered?
Currently it's sort of possible to make "borders" by wrapping the node in another node that is slightly larger and has a background color.
This approach is very limited and not ergonomic at all.
Additional context

Borders in CSS (MDN)
Outlines in CSS (MDN)

Previously attempted in #3991.

I'm willing to revisit this at some point when #5513 is merged. I think one big concern was the amount of changes that was necessary in the UI rendering to implement it.
#90 would offer a completely different and much more flexible approach to do this, but I think we would gain from having both be available since one is a simple way to define border properties while the other would be a full drawing API.

https://github.com/bevyengine/bevy/issues/90 would offer a completely different and much more flexible approach to do this, but I think we would gain from having both be available since one is a simple way to define border properties while the other would be a full drawing API.

Agreed, I'd be frustrated if the only way to draw simple borders was a canvas API.

Also, first https://github.com/DioxusLabs/taffy/issues/223 needs to be done, since it's not possible to differentiate between border and margin calculated values.

Also, first DioxusLabs/taffy#223 needs to be done, since it's not possible to differentiate between border and margin calculated values.

This could potentially be exposed by Taffy as an output, but it is possible to differentiate by referring to the input styles. Where the style is a pixel value this can be taken as-is. Where the style is a percentage, this can be resolved against the width of the parent node (as computed by Taffy)

@ickshonpe @JMS55 So, on the one hand I really want rounded corners. I want them NOW.
However, I also realize that rounded corners are only useful within the context of a particular visual style. Specifically, the style of a web app, where most UI elements are flat-shaded. Since the advent of Material UI, most web sites, and some productivity apps, have converged on a particular look that has rounded corners. The Bevy editor mockups make liberal use of rounded corners, because it's trying to look like Unity.
But many games will have a visual style that has no use for rounded corners (or shadows for that matter). A lot of games will use nine-patches, custom shaders, or other techniques to produce widgets that are novel and flashy.
Rather than building in support for rounded corners in Bevy, we could consider a different option: custom ui materials. Someone building an editor is likely going to rely on a widget library that has an opinionated look, and this library could include custom shaders that render rounded corners and shadows. This means extra work for the widget author, but not much if there are examples showing how to do it. It won't be extra work for people actually using the widgets in their apps.
If I had an example showing how to render rounded corners in a custom ui material, my problems would be solved :) And it wouldn't require a change to Bevy.
Also, adding rounded corners and shadows to Bevy UI nodes entails a number of web-centric assumptions. For example, it assumes that shadows are not separate entities, but are an extension of normal UI nodes. But for someone building a widget library, it's not especially burdensome to add an extra entity for the drop-shadow, which is ordered so that it renders beneath the element.
However, there's one aspect to all this that a custom material cannot easily provide: clipping. A custom material has no effect on child elements, so child elements can't be clipped to the rounded corners. However, I think the solution here is to allow custom clipping regions to be defined, because (again) not all games are going to use rounded corners, but some of them might want to use other shapes besides rectangles.

I'd like to note that Bevy already supports most of what you would want to use for "game" UIs:

Border with border color
Nine-Patch for custom image-based borders
Custom UI Materials, so you can do whatever you want in a shader

The only notable thing missing, out of all the things mentioned in this issue, are rounded corners. To me, they seem unimportant, given that Nine-Patch is supported. You can draw your own rounded corners and make them look how you like. Bevy already gives you everything to have fully-themable / skinnable UIs.
I do agree with the previous comment that having a CSS-like rounded corner property feels needlessly web-centric, making assumptions about visual style that do not necessarily hold for most games. If you are making a quick and dirty UI, you don't need round corners. If you are making a pretty-looking UI, might as well go all the way and create Nine-Patch assets.
Should we close this issue?

The only notable thing missing, out of all the things mentioned in this issue, are rounded corners.

I believe rounded corners are actually already supported as of https://github.com/bevyengine/bevy/pull/12500

Agreed, the important parts of this issue have already been tackled, I'll close it out.
If we see the need for more advanced features like shadows or outlines, they probably warrant a separate issue as they are more controversial.

I just want to add my agreement to closing this issue. I don't think Bevy should support shadows as a built-in feature, because:

Drop-shadows in game or editor UIs aren't common. For example, the editor mocks I have seen don't use any shadows.
It's relatively easy to implement with an auxiliary absolute-positioned rectangle, possibly with a custom UiMaterial to handle the blur.
It adds additional complexity to the UI rendering pipeline for an extremely rare use case.


An exception occurred during a WebClient request.

First, THANKS for doing this. You are awesome.
I'm using ePO 5.9.0.  Got the module imported. Set up ePOwerShellServer via the Quickstart instructions and get this error below. Is there any other easy setup that I'm missing?
PS C:> Find-ePOwerShellComputerSystem $env:ComputerName
Failed with unknown error: Exception calling "DownloadString" with "1" argument(s): "An exception occurred during a WebClient request."
At C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\ePOwerShell\Private\Invoke-ePOwerShellWebClient.ps1:36 char:9

    Throw ('Failed with unknown error: {0}' -f $_.Exception.Messa ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Failed with unk...lient request.":String) [], RuntimeException
FullyQualifiedErrorId : Failed with unknown error: Exception calling "DownloadString" with "1" argument(s): "An exception occurred during a WebClient request."

Umm... nevermind. I figured it out.

Glad you were able to figure it out! Let us know if there's anything else you'd like help with.

I am having same issue and not using a domain in my username


[REQ] Font size

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
I want to make the font size smaller than 1 because of the font.

not possible


[SPARK-33515][SQL] Improve exception messages while handling UnresolvedTable

What changes were proposed in this pull request?

This PR proposes to improve the exception messages while UnresolvedTable is handled based on this suggestion: https://github.com/apache/spark/pull/30321#discussion_r521127001.
Currently, when an identifier is resolved to a view when a table is expected, the following exception message is displayed (e.g., for COMMENT ON TABLE):
v is a temp view not table.

After this PR, the message will be:
v is a temp view. 'COMMENT ON TABLE' expects a table.

Also, if an identifier is not resolved, the following exception message is currently used:
Table not found: t

After this PR, the message will be:
Table not found for 'COMMENT ON TABLE': t

Why are the changes needed?

To improve the exception message.
Does this PR introduce any user-facing change?

Yes, the exception message will be changed as described above.
How was this patch tested?

Updated existing tests.

Test build #131518 has started for PR 30461 at commit 7ad0ee2.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36122/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36122/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36122/
Test PASSed.

Test build #131518 has finished for PR 30461 at commit 7ad0ee2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131518/
Test FAILed.

Test build #131528 has started for PR 30461 at commit 45223a8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36130/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36130/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36130/
Test PASSed.

@cloud-fan Please check if the new exception messages make sense. Thanks!

Test build #131528 has finished for PR 30461 at commit 45223a8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131528/
Test FAILed.

GA passed, merging to master, thanks!


Update nodejs version of appveyor to LTS

I was overwhelmed by the amount of PR by bot, I did not even notice my PRs. Close.


small changes in blog

Description
changes required

edit blog feature should be only admin for now
search functionality is not working

Screenshots
No response

@muhammadgalhoum  do this in one PR
and make one more PR for adding feature to comment on post by normal users

Description
changes required

edit blog feature should be only admin for now
search functionality is not working

Screenshots
No response

Search functionality is working successfully, you can search by title or content of any post

Do you want the admin only the person who can edit blog features using the Django admin panel? @arpit456jain

Description
changes required

edit blog feature should be only admin for now
search functionality is not working

Screenshots
No response

Search functionality is working successfully, you can search by title or content of any post

if that things is not present then it should show nothing to show

Do you want the admin only the person who can edit blog features using the Django admin panel? @arpit456jain

my plan is to provide a role of staff only staff members should be able to edit blog

but since there is not staff role right now if u can add that role well and good otherwise make it for admins only
i mean if there are 2 or more admins
they can edit all posts

role
In this case, the following result will appear and there are no any links will appear on that page.

Do you want to change that message?
Do you want to change that message?

The admin can edit any post from the Django admin pannel
@arpit456jain

Description
changes required

edit blog feature should be only admin for now
search functionality is not working

Screenshots
No response

Search functionality is working successfully, you can search by title or content of any post

if that things is not present then it should show nothing to show

In this case, the following result will appear and there are no any links will appear on that page.
Do you want to change that message? @arpit456jain
Do you want to change that message?

ok got it @muhammadgalhoum
can u do one thing on result page show the post
instead of

show this

and a button also for search like this
https://codesmashersblog.herokuapp.com/myblog/

The admin can edit any post from the Django admin pannel @arpit456jain

yes i know that but currently any user is able to edit update or delete  the post with logged in
please check

the

I will try

and a button also for search like this https://codesmashersblog.herokuapp.com/myblog/

I will try

The admin can edit any post from the Django admin pannel @arpit456jain

yes i know that but currently any user is able to edit update or delete the post with logged in
please check

No, Only the post or Category owner can  edit or delete his/her own posts or category

In this issue, I will improve the search result and the search form and please put level 2  or level 3 on it
And the issue for determining the roles of admin and users will be in a separate PR and put level 3 on it
Are you agree @arpit456jain?

The admin can edit any post from the Django admin pannel @arpit456jain

yes i know that but currently any user is able to edit update or delete the post with logged in
please check

No, Only the post or Category owner can edit or delete his/her own posts or category

when i tried i was not logged in and it allows me to to it

In this issue, I will improve the search result and the search form and please put level 3 on it And the issue for determining the roles of admin and users will be in a separate PR and put level 3 on it Are you agree @arpit456jain?

ok

when i tried i was not logged

Impossible, Make a short video to show me

In this issue, I will improve the search result and the search form and please put level 3 on it And the issue for determining the roles of admin and users will be in a separate PR and put level 3 on it Are you agree @arpit456jain?

ok

Please, edit the description of this issue

And assign this issue to me after updating the issue description @arpit456jain

when i tried i was not logged

Impossible, Make a short video to show me

this page should not open by any normal user

@muhammadgalhoum  i had updates the PR description
if its not clear yet let me know we will discuss it on meet
otherwise if its clear
do this changes after the PR gets merged which is opened now of another user

@muhammadgalhoum i had updates the PR description if its not clear yet let me know we will discuss it on meet otherwise if its clear

As I mentioned earlier, and you agreed to that, I will do 2 PR. The first PR will be to solve the second problem in the description of this issue, which is to modify the search form, as well as the result of the search and the other PR will be in which the role will be determined for both the normal user and the admin, and you will put level 3 on each
Is that true and do you agree with it? @arpit456jain

in 2. u just have to write one line
if user is admin
show that button for going to edit page
else
don't show
in 1.
u have to add a button
the main things is to display the search result as the blog page which should be of lvl2 but i am giving lvl3 on this PR and will give suitable labels on next Prs of urs

in 2. u just have to write one line if user is admin show that button for going to edit page else don't show

Why do you hesitate in your words? Didn't you earlier agree that I would do 2 PR?
The solution to this part of this issue will not be one line?
If you know a way to solve this issue in one line, please put it here in a comment and I will make one PR otherwise I will make 2 PR because I work hard and diligently, and no one changes my code after writing it, as I do in other people's codes

Ok make 2 PRs lvl 2 on both

Ok make 2 PRs lvl 3 for improving search feature and lvl2 on for role

Ok


Showing statusbar even it's hidden in navigation

Hi there. I've react-native-navigation installed and my login page's statusBar is hidden for immersive look. When the Spinner shows up (while waiting response from my webservice), the status bar becomes visible with a white background. How can I avoid this happening?

Since this spinner use  to pop up the loading, consider taking a look at the following discussion
https://github.com/facebook/react-native/issues/7474
status bar issue is not fixing yet.

Check solution proposed by @Traviskn on https://github.com/facebook/react-native/issues/7474 Working for me like a charm!

Seems like setting styles.xml as
<style name="AppTheme" parent="Theme.ReactNative.AppCompat.Light.NoActionBar.FullScreen">       </style>
fixes it for as @Traviskn have mentiones. Thanks @Daky & @husnainafzal86


chore: reuse NoopTracer in ProxyTracer

Create a single NoopTracer and reuse it in ProxyTracer to avoid creation of a new NoopTracer on every startSpan() call in case no SDK is present.

ping @dyladan @obecny


Error when the VM do not exists

OS: Darwin updated.local 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64
azk version: 0.13.0-beta1
Environment details: Using VirtualBox 4.3.28
Steps to Reproduce:
$ /Applications/VirtualBox.app/Contents/Resources/VirtualBoxVM.app/Contents/MacOS/VBoxManage list vms
"boot2docker-vm" {d45b91dc-5e05-4efb-a472-511df75165bf}
$ azk vm status
azk: Error
azk:     at new RequiredError (/azk:0.13.0-beta1/src/cmds/vm.js:11:20)
azk:     at VmCmd.require_installed (/azk:0.13.0-beta1/src/cmds/vm.js:21:13)
azk:     at VmCmd.require_running (/azk:0.13.0-beta1/src/cmds/vm.js:26:10)
azk:     at VmCmd.action_status (/azk:0.13.0-beta1/src/cmds/vm.js:89:10)
azk:     at VmCmd.callee$2$0$ (/azk:0.13.0-beta1/src/cmds/vm.js:43:45)
azk:     at tryCatch (/usr/local/Cellar/azk/v0.13.0-beta1/node_modules/babel-runtime/regenerator/runtime.js:60:40)
azk:     at GeneratorFunctionPrototype.invoke (/usr/local/Cellar/azk/v0.13.0-beta1/node_modules/babel-runtime/regenerator/runtime.js:205:22)
azk: From previous event:
azk:     at Object._onImmediate (/azk:0.13.0-beta1/src/utils/index.js:96:18)
azk:     at processImmediate [as _immediateCallback] (timers.js:354:15)

This command is in error. What has been fixed in the PR #412, does not yet finalized.
your agent is starting normally?

Steps to reproduce the error. Maybe after the azk vm remove should stop the agent.
$ azk agent status
azk: Agent is running...
$ azk vm status
azk: Virtual machine running.
$ azk vm remove
azk: Stopping virtual machine...
azk: Virtual machine has been successfully stopped.
azk: Removing virtual machine...
azk: Virtual machine has been successfully removed.
$ azk agent status
azk: Agent is running...
$ azk vm status
azk: Error
azk:     at new RequiredError (/azk:0.12.1/src/cmds/vm.js:10:20)
azk:     at VmCmd.require_installed (/azk:0.12.1/src/cmds/vm.js:20:13)
azk:     at VmCmd.require_running (/azk:0.12.1/src/cmds/vm.js:25:10)
azk:     at VmCmd.action_status (/azk:0.12.1/src/cmds/vm.js:89:10)
azk:     at VmCmd.callee$2$0$ (/azk:0.12.1/src/cmds/vm.js:42:45)
azk:     at tryCatch (/usr/local/Cellar/azk/0.12.1/node_modules/babel-runtime/regenerator/runtime.js:60:40)
azk:     at GeneratorFunctionPrototype.invoke (/usr/local/Cellar/azk/0.12.1/node_modules/babel-runtime/regenerator/runtime.js:205:22)
azk: From previous event:
azk:     at Object._onImmediate (/azk:0.12.1/src/utils/index.js:97:18)
azk:     at processImmediate [as _immediateCallback] (timers.js:354:15)

It's what I imagined it. The command azk vm status was logical error. It was resolved in PR # 412.
Miha concern was that it was in the way you start the agent.
Thanks for the report @robsonpeixoto .


Arrows to change moth

Hello i need to set arrows to change the moth insteat of scroll the calendar. Its possible to do this?

Same here. Any solution ? Thanks !


feat: server side compiler

This solution solves server side rendering

[x] Add types for compiler
[x] Compile basic vue files
[x] Compile templates with script setup
[ ] Compile files with other formats (js, ts)
[ ] Add compiler function with options to handle compiled files
[ ] Add tests
[ ] Update usage docs
[ ] Add example demo

Close #16, #10

Any news on a release for this? Be great to be able to render this in a node environment.

@Saganic please do upgrade to 0.6.0 and let us know if u find any issues with it!


1.24.0 release

cc @nodejs/node-core-utils anyone with publish perm to node-core-utils on npm available to publish the latest release?

done


Convert "_" to "-" in tower-cli missing field error message

Issue #56 brought up a confusing behavior displayed by tower-cli, where sometimes its language would use underscores in variables names, and other times it would use dashes instead.
We hold to our previous design decision to use dashes, being consistent with Ansible core and general good practice for command-line based programs. However, there are some small things we can do to clean up error messages that confusingly display underscores. There is no changing the fact that underscores and used in the API, but the user of tower-cli should not have to think about this, or be exposed to variables with underscores in them. For this one particular scenario, I suggest that we just show the user the variable name with dashes.
This fixes the error message when you don't give a required field - as defined by tower-cli. However, there are many special case scenarios where a field is only required if another field is given a certain value. In those cases, the user will be shown an error response from the Tower server, and those will contain underscores. Patching up these responses would be more complicated because you would have to parse it as JSON first. I will leave that work for the future.

@AlanCoding I like the spirit of the change, however I worry a semi-random replace will just move/add confusion elsewhere.  Are we certain that the parameters will always use -?  Is that enforced by the click library.

@AlanCoding I'm luke warm on this change.  What you proposed is a nice low-risk answer.  I'd prefer a tighter coupling between the tower-cli parameter names and the tower API.  However, that's beyond the scope of this PR.  Thanks!  Merge if happy.

Is that enforced by the click library.

This is tricky to answer, but my best understanding is that yes, click does this on its own. Give it extra_vars, and the option becomes --extra-vars automatically. (I hope I'm correct on this point)
There are numerous places where tower-cli does a replace on a string for purposes of producing help text with the correct _ vs -. An error message is similar to help text, that's my thinking here. Ideally we would like to get rid of all of those calls to replace except for one, but I don't have a concrete proposal to do that right now.


docs: add doc for kubernetes-service-api

Fixes: #[Add issue number here]
Changes:

Screenshots of the change:

once I deployed, I will update here.


feat!: add no-restricted-globals rule

Starting with a small list for now, containing only "event". The full list of globals that ESLint assumes in the "browser" environment is here:
https://github.com/sindresorhus/globals/blob/master/globals.json
We may want to consider adding others to this list over time.
Closes: https://github.com/liferay/eslint-config-liferay/issues/109

@jbalsas: are there any other browser globals on this list that you think we should add?

It is a very long list... but yeah, I can only think of event for now...


KAFKA-5940: Throw exception if the JSON file is invalid

Throw an exception when the JSON file with topics/partitions and offsets is incorrect (= when Json.parseFull(...) returns None).

@scholzj I see that your PR is overlapping with this one from me (https://github.com/apache/kafka/pull/3887) because while adding some checks on the "version" field, I have started to add a more fine grained check on the JSON file. Sorry for that. Is it worth having this PR still opened ?

@ppatierno Sure, if your PR fixes this I can close it. We should also deal with the KAFKA-5940 issues once your PR is merged.


Allow separation of MPD's %elapsed% and %total%

The Problem
I use 3 mpd modules to create a layout like this:
modules-center = mpd-elapsedtime mpd-bar mpd-totaltime

...

[module/mpd-bar]
inherit = module/mpd

format-online = [<bar-progress>]

[module/mpd-elapsedtime]
inherit = module/mpd

label-time = %elapsed%

format-online = <label-time>

[module/mpd-totaltime]
inherit = module/mpd

label-time =%total%

format-online = <label-time>

polybar supports retrieving both the elapsed time and total time for the current mpd song. Why is it that I have to use two modules to get all this information, simply because I want to separate the information with a progress bar?
Describe the solution you'd like
I want to be able to combine these 3 modules I've created into only 1 module. This should be possible, considering they are all mpd modules and are located right next to each other.
There are two solutions that come to my mind:
Solution 1: Create label-time-1 and label-time-2
Currently, label-time is the only label within format-online that allows the use of %total%/%elapsed% etc. If there were more than one label that allowed those variables, the following would be possible:
[module/mpd-everything]
inherit = module/mpd

label-time-1 = %elapsed%
label-time-2 = %total%

format-online = <label-time-1> [<bar-progress>] <label-time-2>

Solution 2: Allow custom label names
If I could just create my own label names and refer to them in format-online, this whole problem goes away and allows for a ton of customization:
[module/mpd-everything]
inherit = module/mpd

label-whatever-I-want = %elapsed%
label-time17 = %total%

format-online = <label-whatever-I-want> [<bar-progress>] <label-time17>

Describe alternatives you've considered
I realize it is possible to get all 3 pieces of data inside 1 module like this:
modules-center = mpd-everything

[module/mpd-everything]
inherit = module/mpd

label-time = %elapsed% / %total%

format-online = <label-time> <bar-progress>

However, this layout is not what I want. The previous code gives:
1:32 / 2:41 [---------|-----]

While I want:
1:32 [---------|-----] 2:41

Hi,
I also think it is kind of arbitrary that you only get to use one label in a format. I have proposed your second solution in #1752. I will close this as a duplicate and we can continue discussion in #1752. If you have any comments, feel free to add them over there.


Demonize NOOP processing for #1410

Send a random command from { "NOOP", "PWD", "TYPE I", "TYPE A" } when the control connection is idle and no transfer is in progres every NOOPINTERVAL seconds. Use only "NOOP" if a data transfer is running on the data connection.
Use a daemon (task) for this.
Start it on Connect/Authorization ok, stop it when control connection is disposed. Handle reconnects correctly, don't start more than one daemon.
Tell it when GetReply is beginning and when it ends.
Tell it a transfer is running by monitoring SocketStream for Connect/Disconnect of data connection.
It uses NoopInterval
ref. #1410

@FanDjango:
Just started an 18 hour long test using the troublesome Pure-FTPd server I have access to, using your forked code in the THREAD branch, as of commit fa40f13.
I'll let you know how it goes, and paste in the logs.

I was going to do a release now before this daemon, should I or should I wait?

@robinrodricks

I was going to do a release now before this daemon, should I or should I wait?

Just performing a multi-hour test on the daemon at the moment, and it seems to be working very well.
As a user (and as a user that'll use it in production as soon as possible!) I'd suggest waiting a couple of days extra and aiming to include the new daemon code in the next release.

Ok sounds good. I'll wait.

Ok, I am going to close this PR and reopen a clean one.


[Editor] Model importing scale

FBX files and some others seem to import with drastically weird scales
Seems to be related to: https://github.com/assimp/assimp/issues/2166

Ill look into this one, hopefully it goes a bit more smoothly than the other bug 😅

Awesome thanks!
It seems Assimp provides some sort of Unit Scale modifier we can use to scale the models on import.
It would be done inside ModelImporter.cs
Probably on the RootNode/Gameobject which is created around 258, just do
rootNode.Scale = something
Im not sure how exactly to extract the unit scale from assimp though or how it works.

Let me know if you need a some models to test

Awesome thanks! It seems Assimp provides some sort of Unit Scale modifier we can use to scale the models on import.
It would be done inside ModelImporter.cs Probably on the RootNode/Gameobject which is created around 258, just do rootNode.Scale = something Im not sure how exactly to extract the unit scale from assimp though or how it works.
Reading the issue i linked above it might be something like: scene.Metadata["UnitScaleFactor"].Data;

I tried adding the rootnode stuff but im not sure it worked. I'll have to look more into it tomorrow, I'm a little in over my head here but ill figure it out.
How have you been importing the objects? I've just been putting it in the folder and going into the editor and dragging and dropping. Is there another way to import?

That is the correct way, for now, you might have to restart the editor for it to properly import the model.

Might be more to this then I initially thought.

Added a GlobalScale flag for ModelImporter which may help some cases
Also added a UnitScale modifier value like unity has, this doesn't solve the issue entirely, but it provides a decent enough solution.


#1403 #1457 #1478 #1487 #1491 #1494  #1501

#1457 Shortcuts for commands are not enabled on startup
#1487 REPL is not visible by default in Data Science profile
#1491 PM search results should sort by exact match
#1403 Data import dialog: Encoding dropdown's default is empty
#1501 Switch to Installed second time take forever
#1494 VE: when i double click on a row for a dataframe, it should show the DF
#1478 Package Manager: Don't show "uninstall" icon for system package

:+1:


Cannot set setuptools version in Pipfile

Issue description
I have the following Pipfile:
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[dev-packages]

[packages]
jupyterhub = "==1.0.0"
jupyterlab = "==0.35.6"
setuptools = "==42.0.0"

[requires]
python_version = "3.6"

Unfortunately pipenv always installs the latest setuptools (atm is 46.0.0). Tried pipenv graph but setuptools 46.0.0 is not a dependency and choosing a version for this package definitely does not work
Expected result
I expect to see the proper version using pip list.
Actual result
Output from pipenv graph | grep setuptools:
- setuptools [required: Any, installed: 46.0.0]
          - setuptools [required: >=18.5, installed: 46.0.0]
            - setuptools [required: Any, installed: 46.0.0]
          - setuptools [required: Any, installed: 46.0.0]
        - setuptools [required: >=18.5, installed: 46.0.0]
          - setuptools [required: Any, installed: 46.0.0]
        - setuptools [required: Any, installed: 46.0.0]

Steps to replicate
Run pipenv install using the Pipfile in the description in any venv or virtualenv environment.
I uploaded a video as well (forgot to update lock file though, but same thing happens with updated lock file): https://drive.google.com/open?id=11b2XTU_lhBW_QTk0SOz1M-yI-atdjPrI

I see the same; with given Pipfile running pipenv install --python 3.6 gives me setuptools 46.
Contrary to what I would expect, there is no setuptools mentioned in the generated Pipfile.lock.
I can force the specified setuptools 42, with either of

pipenv install --python 3.6
pipenv install "setuptools==42"

or

pipenv install --skip-lock --python 3.6

I'm using https://github.com/pypa/pipenv/commit/d10b2a216a25623ba9b3e3c4ce4573e0d764c1e4.

Same issue as #2364.

Close for duplicate


DAP-988: Added progress to workers

🎯 Summary

DAP-988

Now sends a message back to the processFolder function on the progress percentage.
Reminder to build the out directory again to see worker file changes reflected.
🔰 Checklist

[x] I have read and agree with the following checklist.

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation where required.
I have tested my changes to the best of my ability.
I have consulted with the team if introducing a new dependency.
My changes generate no new warnings.

Hitting the following error even after rebuilding
[91326:1112/141735.922475:ERROR:CONSOLE(1)] "Request Autofill.enable failed. {"code":-32601,"message":"'Autofill.enable' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)
[91326:1112/141735.922542:ERROR:CONSOLE(1)] "Request Autofill.setAddresses failed. {"code":-32601,"message":"'Autofill.setAddresses' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)
Beginning "process-folder" of main process.
Failed to process folder /Volumes/Digital-Archives/test-folders/100: Error: Cannot find module '/Users/tafriese/Documents/code/citz-grs-dats/desktop/out/es-workers/copyWorker.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:17025)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:189:12)
    at MessagePort.<anonymous> (node:internal/main/worker_thread:186:26)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:825:20)
    at MessagePort.<anonymous> (node:internal/per_context/messageport:23:28) {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

This thread has lots of people hitting this error even if they don't use webContents.openDevTools()
It may also only be a Mac issue?
I have tried a few fixes but haven't found anything yet.


Build Fails With 2015-03-21 Nightly

C:\Users\excaliburhissheath\.cargo\git\checkouts\gl-rs-5020f97825182d66\master\gl\build.rs:10:26: 10:56 error: mismatched types:
 expected `&_`,
    found `collections::string::String`
(expected &-ptr,
    found struct `collections::string::String`) [E0308]
C:\Users\excaliburhissheath\.cargo\git\checkouts\gl-rs-5020f97825182d66\master\gl\build.rs:10     let dest = Path::new(os::getenv("OUT_DIR").unwrap());
                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Could not compile `gl`.

It looks like the Path api changed a bit, I can have a pull request to fix it up in the morning if no one beats me to it.

Fixed by #328


[EPROD-668] Get chunks number from UnboundedMap

https://infinityswap.atlassian.net/browse/EPROD-668

Waiting for the changes we discussed offline to be implemented

Already done. There is the total_chunks_number() method.
I'll keep the chunks_number_of() method too. It could be useful in another task.

I'll keep the chunks_number_of() method too. It could be useful in another task.

@F3kilo I would not keep it instead, it has hidden performance implications which are the reason why we implemented the alternative solution.

@F3kilo I would not keep it instead, it has hidden performance implications which are the reason why we implemented the alternative solution.

Done


[Feature Request] Array Element Overrides from dotlist via getitem syntax

Currently, OmegaConf supports overriding as training_parameters.lr_steps.1=500 for overriding a specific element of an array. This is not intuitive and we should support proper getitem syntax for array element overrides.
training_parameters.lr_steps[1]=500 should be supported.

Blocked on #445

If I am not mistaken, this issue is resolved:
>>> training_parameters = OmegaConf.create({"lr_steps": [1000,800,100,75]})
>>> training_parameters
{'lr_steps': [1000, 800, 100, 75]}
>>> training_parameters.lr_steps[1]
800
>>> training_parameters.lr_steps[1] = 500
>>> training_parameters
{'lr_steps': [1000, 500, 100, 75]}

If I am not mistaken, this issue is resolved:

No, that's because the way it's phrased can be misleading. training_parameters.lr_steps[1]=500 is not meant to be read as a Python statement, but as a command line override as would be used in Hydra for instance. In OmegaConf, it's actually more about the select / update functions that assume the key is dot-separated (search for split(".") in the code)

In [3]: cfg = OmegaConf.create({"a" : {"b": [1,2,3]}})

In [4]: cfg
Out[4]: {'a': {'b': [1, 2, 3]}}

In [5]: OmegaConf.select(cfg, "")
Out[5]: {'a': {'b': [1, 2, 3]}}

In [6]: OmegaConf.select(cfg, "a")
Out[6]: {'b': [1, 2, 3]}

In [7]: OmegaConf.select(cfg, "a.b")
Out[7]: [1, 2, 3]

In [8]: OmegaConf.select(cfg, "a.b.0")
Out[8]: 1

What would be good is to support:
OmegaConf.select(cfg, "a.b[0]")

In fact, we can support it for regular dict access as well:
OmegaConf.select(cfg, "[a][b][0]")

This should probably cover the interpolation syntax as well, so it can be too much for 2.1:
list:
 - a
 - b
item0: ${list.0} # a, current syntax
item1: ${list[1]} # b, new syntax

Hi, I found this issue when trying to figure out how to do just that.  Can you point me to documentation I missed or, can I request documentation of this feature?

Hi @dasturge,
Take a look at the docs on Config node interpolation.
Also, there are usage examples in the OmegaConf.select docs and the OmegaConf.update docs.


Ability to change rate-limit policy inside the confugration YAML , per environment

Please describe the feature.
to put it simply, I need a rate-limit policy value for QA and a different for PROD.
So I was thinking can I just change the the configuration.QA.yaml to (for the apis part):
apis:
  - name: myApi
    policies:
      inbound:
        rate-limit:
          calls: 100
          renewal-period: 60

I've tried this but it didnt work. is there any other way to achieve this ?

Why don't you use namedvalues inside your policies and simply override them across environments? Please search some of our closed issues which has similar questions in the past to give you an idea on how to achieve that.

got it. that worked. I had to define the variable as a namedvalue and the rest was just following conventional apiops. Thanks


Guys! PLS! This problem really means a lot for me!

PLS Give me Osiris Discord! I deleted it yesterday from my list, and now I need it a lot! PLS!

I can't find it ANYWHERE

I also think Daniel should leave the link for it on github main page

Official Osiris discord? Scammers are increasingly sophisticated.

@caiocinel thats kinda sad, people sell open source software

@caiocinel thats kinda sad, people sell open source software

no. It's just official Discord named "Osiris & GOESP team". They don't sell anything there, you can download the latest release there. Also, if ya know, where can I download the latest without ccompiling?

lmfao u probably goy ratted

danielkrupinski is the only coder and theres no "team". you can only download the source from github

no. It's just official Discord named "Osiris & GOESP team". They don't sell anything there, you can download the latest release there. Also, if ya know, where can I download the latest without ccompiling?

@playday3008 he is talking about your dc

hi @notgoodusename !

hi @notgoodusename !

hi

bruh, https://discord.gg/xWEtQAn

Official Osiris discord? Scammers are increasingly sophisticated.

I never said and nowhere is it written that my server is official, and I don't sell anything

Just compiling with GitHub Actions and pushing to Discord using webhooks

sooo, close this pr

youre violating discord tos
this is free and open source software
people think its official because u made it look like it is
you can rat almost 2k people by just simply sending a malicious dll

youre violating discord tos
this is free and open source software
people think its official because u made it to look like it is
you can rat almost 2k people by just simply sending a malicious dll

i know
and?
these are their problems
all compilation and sending script are public

its free software not because it doesnt cost money but because its free to modify

posting compiled dlls is defeating the whole purpose and is really unsafe

sadly daniel cant do anything about it

mb 2% of 2k users from my server know what is C++, I just compile and publish dll to discord and some forums, who want to modify source can do it, bcoz under each publication there is a link to the repository
and why its unsafe?

osiris uses mit license and youre not violating it. im just saying that posting binaries is pointless and unsafe

mb pointless bcoz its free, but why unsafe?

cheating software usually triggers antivirus software so people are used to disabling it while cheating. that is a problem though because your binaries can be modified in a malicious way. im not saying youre doing it but maybe some staff member is, you will never know.

cheating software usually triggers antivirus software so people are used to disabling it while cheating. that is a problem though because your binaries can be modified in a malicious way. im not saying youre doing it but maybe some staff member is, you will never know.

"but maybe some staff member is", sounds reasonable, but anybody can go to GitHub and download any zip from GitHub
Actions and check dll checksum, also the archives that are published on the server have checksum files that can be compared with files included into GitHub Actions artifacts and vice versa

youre right but people who download compiled binaries dont even know what checksums are

True, but if you're paranoid then you can check every archive on the server, and by the way, only I have access to webhooks

Better way, it's using link to GitHub Actions artifact instead of uploading archive, but I don't know how to do this

Also, I have commits channel and GitHub reports to channel CI status, so publication and successes compilation message are synced


When https://nodejs.org/dist/ is unreachable, nvm should indicate this to user

Currently, if https://nodejs.org/dist/ is unreachable, nvm install fails with a misleading message:
$ nvm install 0.10
Version '0.10' not found - try `nvm ls-remote` to browse available versions.

The reason for this failure should be properly identified and relayed to the user.

In order to test this, I'll need a domain name that has as long a timeout as possible, and ideally never resolves.

@ljharb we'd be happy to setup a DNS record and point it something we run on heroku, with a very timeout if that would help with testing and making this a possibility

Related to #673.


Can you support to add icon?

Thanks a lot for the great work. I successfully packed a full .NET Framework executable and it runs flawlessly, and even though it packde a .config file inside. When the app changes the .config file, the next run it get the changes without issue, which means warp does not re-unpack it. It also makes my exe not readable by ILDASM which is another good feature.
Can I request another feature?
I need to add an icon to the executable file, but this maybe windows specific thing and different OS needs different implementation too, but it will be great to have it.
You can close this if you think you don't want to do that.
Thanks again for the great work.

It would be great if this is supported by nature.
But, in the mean time, you can use Resource Hacker to achieve this.
http://www.angusj.com/resourcehacker/
If you prefer to automate the ICON adding process, you can also use the command line:
rh.exe -open old.exe -save new.exe -action addskip -res my.ico -mask ICONGROUP,MAINICON,

It would be great if this is supported by nature.
But, in the mean time, you can use Resource Hacker to achieve this.
http://www.angusj.com/resourcehacker/
If you prefer to automate the ICON adding process, you can also use the command line:
rh.exe -open old.exe -save new.exe -action addskip -res my.ico -mask ICONGROUP,MAINICON,

Yea, but's thats not an option if u working on a mac or linux system. Or (in my case) builded and packed from a unix based CI.

In my experience, macOS and Linux executables DO NOT have an ICON by nature.

On macOS, you will have icons when you get a "app", which is called "Package Bundles", it ends with .app extension, which basically a directory which contains the whole files of your application, such as executables / pictures / icons and othere resources you may need.
You can define your icon file for macOS app like this in Info.plist file:
    <key>CFBundleIconFile</key>
    <string>iconfile</string>

and put the iconfile.icns into you-application.app/Contents/Resources/ directory, then you'll get it.

On Linux, application icon is usually provide through a.desktop file, which you can read about it here.
If you prefer to ship your application as one single file like Windows, you may be interested in AppImage which may do you a good job.

That's what in my mind, maybe it's wrong, I don't know.
If you find something else, I'm glad to learn.
Have fun, btw.

It would be great if this is supported by nature.
But, in the mean time, you can use Resource Hacker to achieve this.
http://www.angusj.com/resourcehacker/
If you prefer to automate the ICON adding process, you can also use the command line:
rh.exe -open old.exe -save new.exe -action addskip -res my.ico -mask ICONGROUP,MAINICON,

Yea, but's thats not an option if u working on a mac or linux system. Or (in my case) builded and packed from a unix based CI.

Or, do you mean you wanna compile Windows binary through a Unix based CI?
If you do mean that, I think it's out of the capability of Warp, since you need a windows-x64.warp-packer.exe won't run on Unix.

If you do mean that, I think it's out of the capability of Warp, since you need a windows-x64.warp-packer.exe won't run on Unix.

True, you can't run the exe on Unix, but you can run the platform specific packer and just pass in --arch windows-x64 to create a packed windows executable. I have been using that way myself to create windows binary on linux using warp.

If you do mean that, I think it's out of the capability of Warp, since you need a windows-x64.warp-packer.exe won't run on Unix.

True, you can't run the exe on Unix, but you can run the platform specific packer and just pass in --arch windows-x64 to create a packed windows executable. I have been using that way myself to create windows binary on linux using warp.

Oh, I think that's what @Ruffo324 really mean, I totally missed the point.
Like on Linux using something like --arch windows-x64 --icon iconfile.ico to create a packed Windows executable with icon.

There is a go package for this: rsrc. I guess it is a good resource for learning how to implement this feature in warp.

It would be nice if it just picked up the original app's icon by default...

Ping. Just to bring up this feature on warp4j.
All construction is made on linux, difficult to change the icon manually. Would be great to have syntax for specifying an .ico file. Thanks.


Release/v4.0.0

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (ec53ec8) compared to base (aefb794).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          523       523
=========================================
  Hits           523       523

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Aktuelle Probleme:

GridView.builder

in Kombination mit lockedIndices und scrollen testen
Device drehen und checken, ob sich drag and drop noch richtig verhält


Fix to run kpng-local-up.sh from source root

This PR has a small fix to kpng-local-up.sh so it can be run from the source root without issues importing the utils.sh

/lgtm
/approve


added steam punk game

Description
I would like to see the implementation of a minimap in the HUD (Heads-Up Display) that shows the player’s current location, nearby points of interest, and quest markers.
Fixes:  #1868

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy please review the PR and add labels

@Sulagna-Dutta-Roy Changes done...