Unable to patch network policies after Calico 3.29.0 upgrade

After upgrading to Calico 3.29.0, we noticed that all caliconetworkpolices and globalnetworkpolices were renamed to be prefixed with default. and found the documentation related to the new tier functionality that explains why.
Despite the policy resources being renamed, it does appear that it is generally possible to perform kubernetes API operations against them using the original, non-prefixed names. For example:
 $ kubectl get gnp testpol

NAME              CREATED AT
default.testpol   2024-11-04T20:44:22Z

 $ kubectl delete gnp testpol
globalnetworkpolicy.projectcalico.org "testpol" deleted

However, if you attempt to perform a patch using its original, non-prefixed name, you get an error. For example:
 $ kubectl patch gnp testpol -p '{"metadata":{"labels":{"testlabel":"value"}}}'
Error from server (BadRequest): the name of the object (default.testpol) does not match the name on the URL (testpol)

 $ kubectl label gnp testpol testlabel=value
Error from server (BadRequest): the name of the object (default.testpol) does not match the name on the URL (testpol)

This also affects any helm chart that contains networkpolicy/globalnetworkpolicy resources. An example from one of the helm releases we deploy in our cluster:
Error: UPGRADE FAILED: cannot patch "egress-athens-proxy-http" with kind GlobalNetworkPolicy: the name of the object (default.egress-athens-proxy-http) does not match the name on the URL (egress-athens-proxy-http) && cannot patch "athens-proxy" with kind NetworkPolicy: the name of the object (default.athens-proxy) does not match the name on the URL (athens-proxy)

Because of this, all our helm charts, or anything else that attempts to patch polices are broken until they are updated to include the default. prefix on the name.
Is this intended behavior? I didn't see a breaking change mentioned in the release notes. The fact that you can perform other operations (such as get and delete) without the prefix makes me hope that this is maybe just a bug and that we won't have to modify all of our helm charts to add the prefix on all the network policies.

@kashook thanks for raising this - will take a look. I don't think this is intended behavior.

+1 We've seen the same behaviour and rolled back. I also asked on slack: https://calicousers.slack.com/archives/C0BCA117T/p1730716035332589 and seems that this is a behaviour "promoted" from enterprise versions to open source. The issue for us is that our CD is constantly fighting this back and wants to create resources as named in our committed manifests. Based on the change that introduced this: https://github.com/projectcalico/calico/pull/9166/files it seems like there is no way around it atm, as canonicalizePolicyName func will rename resources before admitting.

https://github.com/projectcalico/calico/pull/9166/files it seems like there is no way around it atm, as canonicalizePolicyName func will rename resources before admitting.

canonicalizePolicyName is meant to fix this particular issue. Specifically, without canonicaliePolicyName we'd be seeing this issue for Update requests in addition to Patch requests. That PR even introduced FV tests to verify this.
I think the problem here is that PATCH operations are handled differently from updates, and are running into this checkName function before the Calico storage layer can even call canonicalizePolicyName.

we have also encountered this problem upgrading to 3.29.0.
@caseydavenport  Given that this is quite the breaking change for end-users with any form of GitOps tooling, I think a stronger stance should be taken than just trying to fix the patch issue.
It would be nice to either:

Prevent renaming of projectcalico.org/v3 resources as was the case before OR
Keep the renaming, but update the documentation to make this explicitly clear. That is:

mention explicitly that projectcalico.org/v3  applied resources will be renamed to have a tier prefix, if not present
change documentation examples of network policy to always include the tier prefix

Personally, I would much prefer if the renaming was not happening. It is not a behaviour that Kubernetes users are accustomed to. It is definitely not intuitive for the end-user, and does feel significantly more brittle if you have to implement multiple workarounds to allow the end-user to interact with the original name (e.g. patch, upgrade operations). Overall, I believe most end-users would much prefer not having to deal with the renaming.

@jemag yes, I agree.
@MichalFupso is looking into this one - I believe the current plan is to fix this in v3.29.2 with the following:

By default, assume the old-style naming (i.e., without the tier prefix)
Return the exactly name on Get / List as was originally used to create the policy.


TOBJ: Serialization shows diffs on an HANA database #6546

Order internal tables by key before serializing

welcome to abapGit as a contributor 🎉


crate missing dependency when compiled on its own with std

This doesn't compile on its own as it needs Debug and that's
in the extra-traits syn feature.

bot merge force

bot merge force


nRF52840 DK halts with FULL_LOGS since #6243

Describe the bug
nRF52840 DK halts soon after thread start since #6243.
To Reproduce
git checkout db1b980e57ada62f6ef2002fcaddff37d55a356d
git clean -xfd
./bootstrap
make -f examples/Makefile-nrf52840 BORDER_ROUTER=1 SERVICE=1 REFERENCE_DEVICE=1 COMMISSIONER=1 DHCP6_CLIENT=1 DHCP6_SERVER=1 JOINER=1 MAC_FILTER=1 THREAD_VERSION=1.2 DUA=1 MLR=1 CSL_RECEIVER=1 FULL_LOGS=1
arm-none-eabi-objcopy -O ihex ./output/nrf52840/bin/ot-cli-ftd ot-cli-ftd.hex
nrfjprog -f nrf52 --chiperase --program ot-cli-ftd.hex --reset

> ifconfig up
Done
> thread start
Done
... Halt

Git commit id: db1b980e57ada62f6ef2002fcaddff37d55a356d
IEEE 802.15.4 hardware platform: nRF52840 DK

Expected behavior
Halt not.
Additional context

Any commit before db1b980e57ada62f6ef2002fcaddff37d55a356d does not halt.
nRF52840 Dongle seems not halt. Update: Dongle also halt.
OT CLI simulation do not halt
FULL_LOGS=0 does not halt
THREAD_VERSION=1.1 also halts

Hello,
The issue you have reported is related to the implementation of the 'cli_uart.cpp' file. The static function named CliUartOutput causes the faulty behavior because of the following line:
error = otPlatUartFlush();
Since nRF52 do not implement otPlatUartFlush function they return OT_ERROR_NOT_IMPLEMENTED error code, this causes execution of else block which indicates an error with a log:
otLogWarnPlat("Failed to output CLI: %s", otThreadErrorToString(error));
This causes the recursion with the same failure and exhausts the stack (I did not check exactly but debugger shows a few dozen stack frames). Another problem that I've spotted in this implementation is that this function tries to transmit bytes synchronously with while (sTxLength != 0), but the nRF52 UART driver works asynchronously, so even if we handle lack of otPlatUartFlush() this code most probably will not work properly. The bytes will be transmitted but sTxLength will not reach 0 value, because successful transmission is reported by UART driver from nrf5UartProcess() function that is handled from main loop context.

I have proposed a fix: https://github.com/openthread/ot-nrf528xx/pull/51

I have proposed a fix: openthread/ot-nrf528xx#51

Thanks for the fix.
BTW, I verified that the fix works. @jwhui


Keep track of all analysis pipeline parameter

We should keep track of all parameters that were used to run a given experiment, e.g. QC parameter, thresholds, etc.
These should go into:

the logs
the hdf5 (probably into an extra table)
the database

On the implementation side, I would gather all into a subgroup of the configparser parameter,
so that we can easily dump all this into the logs / tables.

cc @imagirom @tischi @wolny

Will be implemented in #99

@wolny once #99 is merged we can also have a look into how we write this to the DB.

@wolny I reassigned this to you, because the only thing left is writing this to the db.
The analysis params are stored in the table plate/analysis_paramter.

Thanks for info @constantinpape. If this is another table, then it's already stored in the db (db job parses all the tables and adds it to the results document). However we might want to treat this object differently and pull it as a top level attribute in the results document. I'll make a draft PR to discuss this.

Yes, I've double checked: it's already stored in the DB, e.g. for plate plateT3rep1_20200509_152617_891:
{
			"table_name" : "plate/analysis_parameter",
			"results" : [
				{
					"plate_name" : "plateT3rep1_20200509_152617_891_table.hdf5",
					"marker_denoise_radius" : 0,
					"dont_ignore_nuclei" : "False",
					"infected_detection_threshold" : 6.2,
					"scale_infected_detection_with_mad" : "True",
					"qc_cells_max_size_threshold" : 10000,
					"qc_cells_min_size_threshold" : 1000,
					"qc_images_max_number_cells" : 1000,
					"qc_images_min_number_cells" : 10,
					"qc_wells_max_number_cells_per_image" : 1000,
					"qc_wells_min_number_cells_per_image" : 10,
					"qc_wells_min_number_control_cells_per_image" : 5,
					"qc_wells_min_fraction_of_control_cells" : 0.05,
					"qc_wells_check_ratios" : "True",
					"fixed_background" : "True",
					"background_serum_IgG_corrected" : 1300,
					"background_serum_IgA_corrected" : 1800,
					"background_marker_corrected" : "plate/backgrounds"
				}
			]
		}

however IMO it doesn't belong there and should be saved as a top level attribute of the result object.


Corrected cubical cover computation

The cubical cover computation is implemented incorrectly. It starts with the tests having the wrong expected behavior here:
https://github.com/scikit-tda/kepler-mapper/blob/05adb8f1c14d6f0951c280d83b695a971144dd3c/test/test_coverer.py#L61-L66
If you cover the interval [0,1] with 2 cubes with 50% overlape the cover you should get is [0,2/3] and [1/3, 1]. The cover [0, .75] [0.25, 1] has a percent overlap of (0.75 - 0.25)/0.75 = 0.5/0.75 = 1/3.  It is worth noting that this test actually generates the cover [-0.25, 0.75] [0.25, 1.25] which does have the correct overlap but has increased the range of the cover.
The source of the error is this line:
https://github.com/scikit-tda/kepler-mapper/blob/05adb8f1c14d6f0951c280d83b695a971144dd3c/kmapper/cover.py#L190-L192
There is an off-by-one error causing kmapper to count an intersection which doesn't exist. The computation should be ranges / ( 2 * (n _cubes - (n_cubes - 1) * perc_overlap).
There are other tests which enforce this incorrect behavior as well.
https://github.com/scikit-tda/kepler-mapper/blob/05adb8f1c14d6f0951c280d83b695a971144dd3c/test/test_coverer.py#L124-L133
This test in particular asserts that the cover should behave strangely. The first two test cases imply that a single element cover should be impacted by the overlap percentage chosen. While the last test is basically catching the fact that the current implementation has a division by 0.
This pull request updates the tests to check for the correct behavior and updates the implementation to pass those tests. It also skips this test
https://github.com/scikit-tda/kepler-mapper/blob/05adb8f1c14d6f0951c280d83b695a971144dd3c/test/test_coverer.py#L143-L171
as what it is expecting doesn't always happen with a correct implementation.  I skip it instead of deleting the test outright as the core idea behind the test may be salvageable.

If you cover the interval [0,1] with 2 cubes with 50% overlape the cover you should get is [0,2/3] and [1/3, 1].

I am not a smart man, let alone an expert with TDA. So this question comes from ignorance -- is your definition/expected outcome literature-based? As far as I can tell, kmapper's implementation does work, given its approach to calculating perc_overlap and the like. Whether its approach is contrary to the field's definition is worth discussing though.
The kmapper approach -- roughly bc I'm on mobile but I worked this out again on a napkin just now -- is to first lay out centers without regard to any cube overlap. The centers initially have radii from them that make them completely cover the range, without overlap, and up to the range bounds. After the radius is calculated, perc_overlap is applied to the diameter to see how much further to extend each radius. The idea being, "a perc_overlap of .50 means that the radius of cube_1 extends halfway into the next (unextended) cube." That may be the crux of the problem you are calling out -- that the approach should consider that the other cubes are also being extended. Is that right?
But that's why the cube in that test extends into -.25 -- because the cube starts at center .25 with an unexpected radius of .25, and 50% overlap applied to its diameter means it gets another .25 on each end. That it goes beyond the bound is ignored, since centers never move w.r.t overlap, as kmapper does it.
But @sauln will have better insight.

Thank you for the very, detailed, well-reasoned, and well-sourced answer! I'll let @sauln respond next.
And I don't think we have a formal policy yet about "open an issue first, and then a PR."


Fix PSModuleInfo.CaptureLocals to not do ValidateAttribute check when capturing variables from the caller's scope

fix #3144

I added a comment in test per requested by @dantraMSFT


Update SAP_System_Service_Provider_892114c.md

Line number 92:
Original: If you're using a nontrial account, make sure that you have the Business_Application_Studio_Administrator[Manage Authorizations]
Proposed: If you're using a non-trial account, make sure that you have the Business_Application_Studio_Administrator [Manage Authorizations]
Justification:
"non-trial" might be appropriate than "nontrial".
Also, added a space between the "Business_Application_Studio_Administrator" and "Manage Authorizations".

Thanks for the feedback. I have updated both issues and the fixes will be part of the next release.


Saw you changed ResNet to ConvNext

I recently was thinking of doing the same but was wondering if you have tried it and seen any actual benefit?
I am currently using the UNet architecture from OpenAI improved/guided diffusion as well
Thanks

@Mut1nyJD it seems to work! im just tired of batchnorm or groupnorms - layernorms all the way from now on :D

@lucidrains Thanks for your honest answer. I see friends do not let friends use Batchnorm ;)
Just wondering if you saw any improvements in image quality, convergence or sampling time


Add json mode for openai type models

Support json_mode which forces model to respond with valid json
https://platform.openai.com/docs/guides/json-mode?lang=curl
https://console.groq.com/docs/api-reference#chat-create

Did a quick 15-second look at the commit, and it looks great. I will do a more thorough check, but this seems good to go. Thanks a lot.

actually, why are we checking the user message content? It should just be a json_output kind of property in the ChatOptions
			let json_in_context = messages.iter().any(|msg| {
				msg["content"]
					.as_str()
					.map_or(false, |content| content.to_lowercase().contains("json"))
			});

For now, I'm just trying to make sure I fully understand the behavior and purpose.
This check is for the list of messages before they are sent, right?
So, the goal of this behavior is to enforce that at least one of the messages has the word "json" in it to allow for a JSON call?

Yeah, I don't think there's anything magic going on on their side either. As far as I understand json_mode just adds a validation check at the end of their ai response that verifies the response is valid json.
It will often fail if without proper prompting as well.
checking for the word "json" is just their way of ensuring the user is doing the bare minimum of prompting to ensure the model is guided to return json

Ok, got it. However, I think this should be the responsibility of the caller to do this check, and it should be optional and independent of the json_mode (if/when we decide to implement this check).

But thanks, this is something I wanted to add sooner rather than later because I have the checkbox "JSON" in my AwesomeApp, but it was not wired to anything. So, good timing!

Btw, I see why you did the check "json" in messages:
(from the openai doc)

Important: when using JSON mode, you must also instruct the model to produce JSON yourself via a system or user message. Without this, the model may generate an unending stream of whitespace until the generation reaches the token limit, resulting in a long-running and seemingly "stuck" request. Also note that the message content may be partially cut off if finish_reason="length", which indicates the generation exceeded max_tokens or the conversation exceeded the max context length.

So, as I said before, we might have a json_mode_check or something similar at some point. It's just tricky to do it correctly. It can only be a best effort (unless we assume we have a specialized agent to check it, which is out of scope).
That being said, for now, let's have this responsibility lie with the library user. I will put a doc note on the json_mode property about the need to do this check.

Yes, that sounds reasonable

I removed the extra logic and added a doc warning. Feel free to directly modify this PR further

@stargazing-dino Ho, I already merged your commits, remove the json check. So, call good. This PR can be closed.


Redirect docs/v0* to docs/*

I think at this point, we can probably drop the pre-1.0 docs redirect. The docs on the API now are way different from those of v0.1.1, I think a redirect for docs that outdated is more misleading than a 404. Thoughts on this @zeke?

This redirect is only temporary. We will develop multi-version of docs for the website then this navigation will return as before.


chore: jx-go-http to 0.0.1

chore: Promote jx-go-http to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix MultiLevelProcess's progress output to console to reflect step names

It prints Step 10/0 stepFn done. instead if Step 10/0 <stepName> done.

Fixing this with #13.


python311Packages.greeneye-monitor: 4.0 -> 4.0.1

Diff: https://github.com/jkeljo/greeneye-monitor/compare/refs/tags/v4.0...v4.0.1
Changelog: https://github.com/jkeljo/greeneye-monitor/blob/v4.0.1/CHANGELOG.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 247701 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.greeneye_monitor
python310Packages.greeneye-monitor
python310Packages.greeneye-monitor.dist
python311Packages.greeneye-monitor
python311Packages.greeneye-monitor.dist


Is there a way to get keyboard return event to pick top choice in dropdown?

Like your geo-coder, but it would be nice for a user to just type in a name (including in auto-complete mode) and hit keyboard return/enter in the input box and have the address default to the top one in the dropdown list rather than having to click.
Is there currently a way to do this using options?  Have played around w/out success so thinking not.  If not, any chance this could be an enhancement?

For sure, this a great feature to be done. Just can't tell about a schedule ok?

You could consider making the ul result list a datalist instead and get the keyboard support out-of-box. Biggest downside is the styling of it.

Closed in v4.3.1
Use option limit: 1,


kie-server tests: test coverage for timer functionality

+1 to merge
feel free to back port to 6.4.x


Fix spellcheck

Fixes
Spellcheck
What is the current behavior?
Spell check does not work in comment area or post advanced editor:

What is the new behavior?
Spell check works:

Other information
The textarea spellcheck issue was due to some default props being passed in from mui.  The markdown editor issue was due to the installed version of react-simplemde-editor rolling in easymde v2.13.0 which contained this bug and was fixed with this PR and released in v2.14.0:
This PR upgraded the yarn.lock file.  But there is also a package-lock present which has not been updated.  Not sure if I should also include a parallel update for that or if the package-lock will eventually need to be removed.
PR Checklist

Toggle...
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

There is also the minor annoyance for the Advanced Editor that the spellcheck highlights while you type (before you press space to end the word).  Just noting.  Probably no need to address unless super easy.

highlighting while typing seems annoying - can we try to fix that?
We can put it up on a dev server to give it a more thorough round of testing.

Yeah, the spell check behavior in easymde seems odd.  They have an open issue which mentions this: https://github.com/Ionaru/easy-markdown-editor/issues/157
A fix might involve a commit to that repo, which would involve an upgrade for react-simplemde-editor to 5+ where easymde is now a peer dependency.
If the current behavior is too weird, the correct short-term fix might be to roll back the package updates and disable spell check in the react-simplemde-editor.

Sounds good.  Let just keep the MUI changes (comments text field) and roll back the easymde/react-simplemde-editor changes for now.

Side quest
I tried to find a hack with css ...

override the highlight with simple dotted underline
delay the visibility until idle

Close, but the because the entire line is re-rendered when typing, the squiggly for the entire line blinks.
@keyframes fadeIn {
  from {
    border-bottom: none;
  }
  to {
    border-bottom: 1px dotted var(--color-text-error);
  }
}

[dir] .CodeMirror .cm-spell-error:not(.cm-url):not(.cm-comment):not(.cm-tag):not(.cm-word) {
  background: unset;

  animation: fadeIn 250ms;
  animation-delay: 250ms;
  animation-fill-mode: forwards;
}

https://user-images.githubusercontent.com/64950861/162199042-c45fe842-b972-4508-bf65-80dcfc0b1b6d.mp4

Reverted.
Re side quest. Nice work.  If only there were some sort of css selector based on text cursor proximity or something.


feat: optimized performance for http still image sources

When sources are marked as still images via
type: image
source: http***
AVSourceElement use the lightweight python requests library to fetch the next image
snapshot from the camera instead of using gstreamer.
That saves resources from creating separate process for gstreamer with its own threads and overhead.
Gsteramer is still used for all other media sources.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @ivelin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/ambianic/pipeline/avsource/av_element.py:

Line 36:34: W291 trailing whitespace
Line 101:12: E225 missing whitespace around operator
Line 110:52: W291 trailing whitespace
Line 114:80: E501 line too long (81 > 79 characters)
Line 115:29: E128 continuation line under-indented for visual indent
Line 117:13: E722 do not use bare 'except'
Line 119:64: W291 trailing whitespace
Line 123:80: E501 line too long (90 > 79 characters)
Line 250:13: E125 continuation line with same indent as next logical line
Line 257:46: W291 trailing whitespace
Line 272:29: E128 continuation line under-indented for visual indent

In the file tests/pipeline/avsource/test_avsource_http.py:

Line 50:1: E302 expected 2 blank lines, found 1
Line 63:80: E501 line too long (111 > 79 characters)
Line 111:80: E501 line too long (111 > 79 characters)
Line 156:1: E302 expected 2 blank lines, found 1
Line 188:80: E501 line too long (111 > 79 characters)
Line 230:28: W292 no newline at end of file

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update README.md

Not sure of the intended meaning here but I thought support adds more clarity. How about A project that compensates for our average annual emissions. ?

I guess so, thanks for PR!

Feel free to contribute more to KodaDot!
https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md


Introduce creation of FElements from WebElement

Summary
As of now, there is no direct way to create FElements directly from WebElements. Together with the missing ability to obtain FElements from a shadow root, we can not test the majority of our GUI.
Motivation
We want to test the GUI; this requires accessing the shadow root.
Describe alternatives you've considered
Directly using Selenium's WebElement accessed by JS code leads to the expected result.
Additional context
final WebElement shadowRoot = (WebElement) webDriver.executeScript("return arguments[0].shadowRoot", outerTable);

We will switch to playwright.


[BUG] Analysis fails for OpenMRS Core app

Is there an existing issue for this?

[X] I have searched the existing issues

Konveyor version
latest
Priority
Critical
Current Behavior
Analysis fails with a panic for https://github.com/openmrs/openmrs-core
Expected Behavior
Analysis should not fail
How Reproducible
Always (Default)
Steps To Reproduce

Run analysis for https://github.com/openmrs/openmrs-core
Choose OpenJDK as target
Choose Source + Dependencies mode (this is equivalent to default "full" mode in kantra)

Environment
- **Analyzer Image SHA** latest
- **JDTLS  base image SHA**
- **Provider Settings JSON**

Anything else?
No response

Fixed in https://github.com/konveyor/analyzer-lsp/pull/425, I think this can be closed now

Closing based on previous comment.


fix LoggingLevelSwitch

closes #128

👋 thanks for this!
I'm actually updating how logging works a bit in the next release which will make this moot, so I'm going to close this PR, but thanks again for the contribution.

@pdevito3 thanks for the feedback.
Have a nice day!


Create a grid agnostic Horizontal Flow Barrier class

In GitLab by @JoerivanEngelen on Feb 6, 2023, 17:20

In GitLab by @JoerivanEngelen on Mar 17, 2023, 15:43
Fixed in !189 (merged)


NATIVE_WRITE_FAILED Error on Windows 10

On Windows 10 (Surface Pro), I'm getting a NATIVE_WRITE_FAILED error from the following code:
NativeStorage.setItem('foo', 'bar', function() {
    console.log('success');
},
function(err) {
    console.log('error', err); // err = { code: 1, exception: null, source: "Native" }
});

In the "Output" tab of Visual Studio, I see the following when I run this:
The maximum number of credentials that may be stored has been exceeded
WinRT information: The maximum number of credentials that may be stored has been exceeded

I don't have much experience developing for Windows, but I see that NativeStorage is saving to Windows.Security.Credentials.PasswordVault() on Windows (see #38), which seems too limited to me. Is this expected? Perhaps the plugin should use something like Windows.Storage.ApplicationData?
Does anyone have any further ideas how to fix this? (cc @3h3c)

@davidofwatkins Thank you very much for bringing this into notice.
I am going to re-write the windows implementation usingWindows.Storage.ApplicationData.current.localSettings.

@alokrajiv I don't know how to use github but I've got the code to replace the Windows.Security.Credentials.PasswordVault functionality with Windows.Storage.ApplicationData.current.localSettings:
var NativeStorageProxy = {
    getItem: function (win, fail, args) {
        try {
            var key = args[0];
            var value = Windows.Storage.ApplicationData.current.localSettings.values[key];
            // A value of undefined will throw a JSON error during the win() callback
            if (value === undefined) {
                fail(2);
            }
            else {
                win(value);
            }
        } catch (e) {
            fail(2);
        }
    },
    setItem: function (win, fail, args) {
        try {
            var key = args[0],
                value = args[1];
            // A value of undefined will throw a JSON error during the win() callback
            if (value === undefined) {
                fail(3);
            }
            else {
                Windows.Storage.ApplicationData.current.localSettings.values[key] = value;
                win(value);
            }
        } catch (e) {
            fail(1);
        }
    },
    remove: function (win, fail, args) {
        try {
            var values = Windows.Storage.ApplicationData.current.localSettings.values,
                key = args[0];
            if (values.hasKey(key)) {
                values.remove(key);
                win(key);
            }
            else {
                fail(2);
            }
        } catch (e) {
            fail(1);
        }
    },
    clear: function (win, fail, args) {
        try {
            Windows.Storage.ApplicationData.current.localSettings.values.clear();
            win();
        } catch (e) {
            fail(1);
        }
    },
    keys: function (win, fail) {
        try {
            var values = Windows.Storage.ApplicationData.current.localSettings.values,
                keys = [];
            for (var p in values) {
                if (values.hasOwnProperty(p)) {
                    keys.push(p);
                }
            }
            win(keys);
        } catch (e) {
            fail(2);
        }
    },
    putString: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getString: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putBoolean: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getBoolean: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putInt: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getInt: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putDouble: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getDouble: function (win, fail, args) {
        this.getItem(win, fail, args);
    }
};

require("cordova/exec/proxy").add("NativeStorage", NativeStorageProxy);

Has this been looked into at all, or has @julesongithub's code been reviewed? We just got bit by the same NATIVE_WRITE_FAILED error on a Windows 10 Surface Pro.

Unfortunately, something I missed along the way. Maybe someone can contribute here?


HTML TAG Support

This extension is fantastic! Do you plan on extending support for HTML tags?

I took a look at the extension files and got an idea, saw that Regex is already in use.
With this in mind, if we treat html tags as regular expressions (Regex), we can easily identify them as opening and closing HTML tags.
For example:
Opening HTML Tag -> <[^> \ /] *>
Closing the HTML Tag -> <\ / [^>] *>
Do you believe that with this idea it would be possible to identify HTML tags?


Retrieving Historical 'Financials' Data (e.g. quarterly earnings) with Yahoo Finance Premium Subscription?

Hello, is there any functionality in place to leverage Yahoo Finance premium subscription features via yfinance? I have a gold membership and would like to access the additional data via yfinance. Thanks! Awesome project by the way.

Quick follow up, did you ever find a solution to this?


[FEATURE] Nanocl inspect cargo with yaml output

- What I did
Added inspect command  and yaml output formatting
- How I did it
With help of Leo of course
- How to verify it
Run commands for test
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
UwU

Thx


Mickledore dev

fixes #69
Items are now separates into packages using PACKAGECONFIG which I think is a bit more elegant than trying to put thing into separate packages.
Also cleaned out non-functional recipes since chances that they still work is 0%.

I'm not convinced that the PACKAGECONFIG way is a good solution here.
It is less flexible than packaging individual packages and it should mainly be used if the package requires conditional compilation. In our case here it's only splitting python files and dependencies.
But I think the structure is fine and only requires minor adaption to work with packages:

Convert every packge config in to an entry in PACKAGES. E.g PACKAGES += "${PN}-backup ${PN}-cast ...".
Add a the dependencies for each package RDEPENDS:${PN}-backup = "${PYTHON_PN}-securetar (=2022.2.0)"
Add the required packages to RDEPENDS:${PN} += "${PN}-backup ..."
Add the optional packages to RRECOMMENDS:${PN} += "${PN}-cast ...

I see your point on the packages. I am not completely sure if I agree with your point on the long run. Since now every single package will need the ALLOW_EMPTY since a package is nothing more than a RDEPENDS, hence the FILES:${PN} are being created by those recipes. Hence I believe using PACKAGECONFIG is also a valid alternative.
What for me was the tipping point was the RRECOMMENDS which is nice.

Done, I have moved everything from PACKAGECONFIG to PACKAGES


Fix: BedAssignment Date fields should be DateTime

Short description

Re-added the time information that was lost when originally importing the patient data into our DB.
Proposed changes

Side effects

I hope these are all correct. If you could check one or two random entries from the data.csv on moodle and this one, that would be fantastic.

Resolved issues

Fixes: #75

So checked for 3 patients and the data in our Db matches with Moodle data for admission/discharge date and time.


/model/metadata returns unexpected results

{
  "id": "sentiment_bert_base_uncased_tensorflow",
  "name": "Bert Base Uncased TensorFlow Model",
  "description": "BERT Base finetuned on the IBM Project Debater Claim Sentiment dataset.",
  "type": "Text Classification",
  "source": "https://developer.ibm.com/exchanges/models",
  "license": "ApacheV2"
}

Issues:

source URL is incorrect (should point to https://developer.ibm.com/exchanges/models/all/max-text-sentiment-classifier/)
license name doesn't meet standard
id naming convention doesn't meet standard

Fixed in https://github.com/IBM/MAX-Text-Sentiment-Classifier/commit/c76cfa9fe09f5cf28a55645b73efd3057030bc5b
Thanks @ptitzler!


openwayback: implement log retention policy

Nicholas and I agree that the log retention policy should be thirty days

filed SAR-3342

updated docs sul-dlss/DevOpsDocs/pull/118

Kam says this is being done.  @tallenaz needs to be sure the logs are also rotating for new machines

Tomcat logs rotate to afs


fix(ControllerReference): check null references

I tested my PR #1132 (support for gear vr) with your PR #1129 and I found some problems
(I did it by mistake, to be honest, I rebased to the wrong commit...).
Whit your PR I got an exception:
NullReferenceException: Object reference not set to an instance of an object
VRTK.VRTK_Pointer.PointerEnter (RaycastHit givenHit) (at Assets/VRTK/Scripts/Pointers/VRTK_Pointer.cs:157)

The same holds for PointerExit().
Furthermore in VRTK_BaseGrabAttach.ForceReleaseGrab() grabbingObject.GetComponent<VRTK_InteractGrab>() fails with this exeception:
NullReferenceException: Object reference not set to an instance of an object
VRTK.GrabAttachMechanics.VRTK_BaseGrabAttach.ForceReleaseGrab () (at Assets/VRTK/Scripts/Interactions/GrabAttachMechanics/VRTK_BaseGrabAttach.cs:175)

An exception occurs also in VRTK_BaseGrabAttach.ThrowReleasedObject when grabbingObjectScript is null (the Git comparison with the previous version cuold be a bit confusing, there I just added an if(grabbingObjectScript) and its square brackets).
After adding some pointer checks in those methods everything works again.

Do you have any steps to recreate those errors you were encountering?

To recreate those errors you can:

Get the project from my branch, see PR #1143
Import the Assets/VRTK/SDK/GearVR folder to your "controller-reference" version
Open example scene 034_Controls_InteractingWithUnityUI
Delete [CameraRig] and replace them with empty game object named [CameraRig]
Select the empty [CameraRig] and create a new camera, named Camera (attached to it)
Set the Tag of Camera game object to MainCamera
To move the camera even if you have not a GearVR you can attach to the Camera game object the EditorLikeCameraController script (Assets/VRTK_GearVR_Test/Scripts)
Select [VRTK] game object
From Quick select SDK select GearVR
Remove Script Alias Left/Right Controller references
Remove LeftController and RightController from [VRTK] game object
Remove ##Scene Changer## from [VRTK] game object
Set Actual Boundaries to [CameraRig]
Set Actual Headset to Camera
Select Headset and

set Game Object To Follow in VRTK_TransformFollow script to Camera game object
check Activate On Enable in VRTK_Pointer
Set Cursor Visibility in VRTK_StraightPointerRenderer to Always On
Set Selection Button in VRTK_UI_Pointer to Touchpad Press
Add a VRTK_ControllerEvents component

Play
Use the mouse to move the camera like you do in Editor's Scene View
Use the mouse left button to interact with UI elements
You will get some of the above exceptions.
To see all the exceptions you can enable the grabbing on the pointer (e.g. changing the scene 005_Controller_BasicObjectGrabbing)
or you can import also the VRTK_GearVR_Test from my branch to your project and test the included scenes in a similar way.

I've updated the other PR now to take into consideration the things you've found that were causing errors:
https://github.com/thestonefox/VRTK/pull/1129
Try rebasing the PR again you shouldn't get those errors again.

Maybe it's late, but I confirm: with your PR #1129 no exception is thrown also in my GearVR test project.


Add git to kyma image

Changed

add git to kyma image

Added https://github.com/SAP/xsk/pull/1439


🌱 Update hcloudmachine_types.go

What this PR does / why we need it:
Added descriptions
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squash commits
[x] include documentation
[ ] add unit tests

thanks, you can squash

Updating a few more descriptions in line with our reference docs. Then will squash all the commits together.

there is an empty introduction.md file in this commit! You should remove it

Done


OpenAPI 3.* has the body name 'requestBody' which Connexion resolves …

…to the argument tag "request_body" so this line of code is not standards compliant, thus non-object JSON request bodies are not captured as arguments (on line 263) without the artificial use of an explicit  'x-body-name' with value 'request_body'
Fixes # .
Changes proposed in this pull request:

this line of code is not standards compliant
Which standards do you refer to?

From what I understand, OpenAPI specification does not mandate which variable names can be used by the implementing frameworks.

Hi @pbasista ,
See https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#requestBodyObject
Note the use of the specification field tag "requestBody" for the POST operation.  The Connexion framework translates this into a "request_body" parameter to the generated handler. This is not recognized by the above code, thus, even though the POST body contents (e.g. JSON data value) makes its way to this level of the code, it is not captured and sent back as a parameter to the caller, thus, does not get propagated to the handler. When one imposes the artificial "x-body-name" == to "request_body", this "fixes" the problem; however, this begs the question: should the Connexion code not automatically default to this (as per the OpenAPI standard).
Try it yourself: create a small stub spec which has the requestBody POST body tag, generate the Python code then single step down to this level of the code where you see all of this happen!

The Connexion framework translates this into a "request_body" parameter to the generated handler.

Which handler do you refer to? Connexion by default does not use the name request_body for that parameter. It uses the name body.

should the Connexion code not automatically default to this (as per the OpenAPI standard).

The OpenAPI Specification, to the best of my knowledge, does not specify the names for the parameters used in web handlers.
In the last paragraph of you message, you refer to some kind of Python code generation. Can you explain what specifically you mean by that? Connexion itself does not generate any code. If you want to use it, you need to write the code yourself.

Sorry.. yes... I fully understand your confusion now (and mine as well).  You are absolutely correct... Connexion doesn't do code generation. mea culpa for saying that. Thanks for continued kind patience with this issue.
Here's the actual scenario: perhaps you can help me figure out the point of intervention:

I am standardising on the OpenAPI 3.0 specification (published by https://www.openapis.org/). I am using a code generator related to the Swagger code generator (specifically, the independent spin-off of the SmartBear team, https://openapi-generator.tech/) to generate Python Flask code. It is actually the code generator which ties Connexion to Flask for this purpose, so when one follows the stack trace, it is Flask app.py calling the Connexion via the "EndOfRequestLifecycleDecorator in the Connexiondecorator.py, which ultimately hits the wrapper method of the parameter.py module, which attempts to process the request, including the reported capture of the requestBody contents.

All I know is that the request.body and request.json values come in the door intact at that point, but , the request_body gets set to the request_json, then when the kwargs.update() function is called with operations.get_arguments, then this latter method calls self._get_body_arguments. this final method fails to pic up the request body unless the x-body-name is set to 'request_body'.
Quick question at this point: what is the self.body_schema assumed at this point? Is Connection assuming a Swagger 2.0 or OpenAPI 3.* or no particular web request encoding standard at this point? Which authority, in effect, has globally defined the body_schema attribute you are using at this point? Somehow, I don't imagine that it is the Connexion package developer(?). As a corollary, which authority dictates the existence and meaning of the "x-body-name" attribute, which defaults to value "body" in the Connexion code base?
Please do kindly let me know who I should contact to enforce the actual standard in play here. As far as I can tell, the OpenAPI code generators are just passing the OpenAPI specification through their code, translating "requestBody" into "request_body". Is Flask going to specifically be OpenAPI aware for this? I simply do not know.

Hi @RichardBruskiewich - the name "body" was chosen for connexion and is unrelated to the openapi specifciation. My guess is that your problems are related to code generation from a different project.
Even if 'request_body' were a better name to use, it would cause major breakage to change it now, so I'm going to close this PR.
Maybe follow up with openapi-generator?


Log better message when connection was evicted or dead

This minor change in the logging lets us know which condition (was evicted or is dead) caused the connection to be closed.  The "dead" condition is interesting to us because that means the JDBC4 connection.isValid() failed and we can better pin the blame on the network or database server.

Coverage increased (+0.03%) to 77.27% when pulling e228e2e3d87cbed994f5119b4d2b1afd997aebc6 on wvuong:evicted_or_dead into 03630dbf8ece843525ffa266b5e375d2e9a6937c on brettwooldridge:dev.

Good point.  Definintely do not want to call isConnectionAlive() unless absolutely necessary.  Evictions/dead connections are rare enough that paying the cost of re-evaluation inside the original conditional would be better.

@brettwooldridge while I am not as experienced as you with byte code optimisation could I trouble you to explain why there are two try blocks? I was thinking something like this might be "ideal"
public Connection getConnection(final long hardTimeout) throws SQLException
{
   suspendResumeLock.acquire();
   final long startTime = currentTime();
   PoolEntry poolEntry = null;
   try {
      long timeout = hardTimeout;
      do {
         poolEntry = connectionBag.borrow(timeout, MILLISECONDS);
         if (poolEntry == null) {
            break; // We timed out... break and throw exception
         }

         final long now = currentTime();
         if (poolEntry.isMarkedEvicted() || (elapsedMillis(poolEntry.lastAccessed, now) > ALIVE_BYPASS_WINDOW_MS && !isConnectionAlive(poolEntry.connection))) {
            closeConnection(poolEntry, poolEntry.isMarkedEvicted() ? EVICTED_CONNECTION_MESSAGE : DEAD_CONNECTION_MESSAGE); // Throw away the dead connection (passed max age or failed alive test)
            timeout = hardTimeout - elapsedMillis(startTime);
         }
         else {
            metricsTracker.recordBorrowStats(poolEntry, startTime);
            return poolEntry.createProxyConnection(leakTask.schedule(poolEntry), now);
         }
      } while (timeout > 0L);

      metricsTracker.recordBorrowTimeoutStats(startTime);
   }
   catch (InterruptedException e) {
      if (poolEntry != null) {
         poolEntry.recycle(startTime);
      }
      Thread.currentThread().interrupt();
      throw new SQLException(poolName + " - Interrupted during connection acquisition", e);
   }
   finally {
      suspendResumeLock.release();
   }

   throw createTimeoutException(startTime);
}

@brettwooldridge as there has not been further contact from wvuong I went ahead and made the changes as per our discussion https://github.com/brettwooldridge/HikariCP/pull/977

Hey, sorry for ghosting this - closing mine because #977 is doing it better.


[BUG]Added task instance criteria

Added task instance criteria
#12114

Codecov Report

Merging #12115 (93899fe) into dev (a86f4e2) will increase coverage by 0.34%.
The diff coverage is 68.23%.

@@             Coverage Diff              @@
##                dev   #12115      +/-   ##
============================================
+ Coverage     38.70%   39.04%   +0.34%
- Complexity     4011     4079      +68
============================================
  Files          1001     1010       +9
  Lines         37422    37692     +270
  Branches       4262     4315      +53
============================================
+ Hits          14484    14718     +234
+ Misses        21292    21289       -3
- Partials       1646     1685      +39

Impacted Files
Coverage Δ

...eduler/api/dto/schedule/ScheduleFilterRequest.java
0.00% <0.00%> (ø)

...scheduler/api/controller/ScheduleV2Controller.java
9.09% <9.09%> (ø)

...eduler/api/dto/workflow/WorkflowFilterRequest.java
33.33% <33.33%> (ø)

...cheduler/api/service/impl/ExecutorServiceImpl.java
43.73% <37.50%> (+0.39%)
:arrow_up:

...eduler/api/dto/schedule/ScheduleUpdateRequest.java
41.66% <41.66%> (ø)

...er/api/controller/ProcessDefinitionController.java
51.04% <50.00%> (+1.53%)
:arrow_up:

...eduler/api/dto/workflow/WorkflowUpdateRequest.java
50.00% <50.00%> (ø)

...api/service/impl/ProcessDefinitionServiceImpl.java
33.81% <61.90%> (+2.43%)
:arrow_up:

...heduler/api/service/impl/SchedulerServiceImpl.java
26.84% <71.57%> (+17.96%)
:arrow_up:

...scheduler/api/controller/WorkflowV2Controller.java
85.71% <85.71%> (ø)

... and 35 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

related pr #12129
Hi @DarkAssassinator do you have time to review this pr?

@jackfanwan Please use the correct title.

Added task instance criteria

The pr logic and issue is abort taskInstance check when worker group delete, Added task instance criteria is not clear.

@jackfanwan Please use the correct title.

Is that right？

Added task instance criteria is not clear, this pr and issue is abort check task instance when delete worker group

related pr #12129
Hi @DarkAssassinator do you have time to review this pr?

Sure, sorry but it has closed? sorry for push a same PR


Japanese input docs fleshed out and added mozc

Second PR, first one isnt even done, on a roll (if it isnt terrible)

@brandonpollack23 I messed around with a mozc module a while back, and a significant issue was the fact that the mozc repo was like half a gig so cloning it took forever (and almost all of it is irrelevant to emacs). Did you experience this too?

It is about half a gig, 200M of which are the git repo.  I'm not super familiar with straight, but I'm sure we can --depth 1 checkout the commit we want or put this whole feature behind a + guard?


Update android namespace for database module

The namespace name was the same, and that is causing a collision!

Pull Request Test Coverage Report for Build #65
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #64:
0.0%

Covered Lines:
249

Relevant Lines:
249

💛  - Coveralls


Game crashing when accessing to a reactor when it's not created in the same session

When I create a reactor or turbine, I can access to the control system like normal, but when I restart the game, I have to destroy and rebuild at least one block of the structure, otherwise the game will crash.
Some Crash reports:
http://pastebin.com/raw.php?i=0B0Fi9Bj
http://pastebin.com/raw.php?i=HUgYwjzs
http://pastebin.com/raw.php?i=hMpBqLLD
Installed mods:
http://pastebin.com/raw.php?i=zTjEg44a
EDIT:
It seems to happen randomly when working with the mod; Sometimes I can do the things described without crashing, sometimes it happens at any other point.

I'll close this as inactive and probably not reproducible.


Fix IME activation in subviewports.

Fixes https://github.com/godotengine/godot/issues/92713

Thanks!


[no ci] chore: Update Discord invite link

Description

Updates Discord invitation link in issue template

Testing required outside of automated testing?

[X] Not Applicable

Screenshots (if appropriate):

[X] Not Applicable

Rollback / Rollforward Procedure

[X] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release

Your semantic-release bot :package::rocket:


Update JWT Library

Makes this example compatible with the latest version of  firebase/php-jwt.
Also fixes #4 by updating the expiration date in the JWT and adding the decrypted JWT to the committed code.
This PR includes several different commits - I can cherry-pick some of them if you want to keep parts of the changes but not others.

Updated! I amended the original commits so they no longer include the "real" data in the token.


Feat: Add Style to the Clipboard Copy Element Website

current behaviour
there is no style on the website

Kindly add Styles to make the UI more attracting to new Users

i can fix this if i get assigned to it

Thanks for the issue @dev-phantom.
We intentionally have not styled the example pages. Styles and such are available on https://primer.style where these components are used. The example page is merely intended to show only the behaviour.
I'll close this, as I do not think we want to add styles to this page. We can continue discussing it though!


chore(switch): remove old css label styles

fixes https://github.com/patternfly/patternfly-next/issues/1581

Deploy preview for pf-next ready!
Built with commit b22cf630c0e82f22053063f9fd4af8b983d2e008
https://deploy-preview-1626--pf-next.netlify.com

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Exclude generated asset data from bundle

Overview
A large portion of web's bundle size comes from the generated asset data, namely:

generatedAssetData
relatedAssetIndex.json
color-map.json

We can instead load these on app boot using a tool such as GitHack.
References and additional details
Spawned from https://github.com/shapeshift/web/issues/7768
See https://raw.githack.com/
Acceptance Criteria
The generated asset data is still included in the web repo, but is not included in the app bundle.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

consider using compression to assist with network transfer

Color map excluded in https://github.com/shapeshift/web/pull/7897


[keyboard shortcuts] can't use assigned ctrl-shift-[ / ctrl-shift-]

Prerequisites

[x] Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[x] Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
[x] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[x] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[x] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
keyboard shortcuts: can't use assigned ctrl-shift-[ / ctrl-shift-]
Steps to Reproduce

in keymap.cson put

'body':
  'cmd-shift-[': 'pane:show-previous-item'
  'cmd-shift-]': 'pane:show-next-item'
  'ctrl-shift-[': 'pane:show-previous-item'
  'ctrl-shift-]': 'pane:show-next-item'

try to use any of those

Expected behavior:
assigned shortcuts work as intended
Actual behavior:

ctrl-shift-[ -- nothing happens
cmd-shift-[ -- outputs {

Reproduces how often: always
Versions
OS:

Ubuntu 16.10

Atom:

Atom    : 1.15.0
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

APM:

apm:  1.15.3
npm:  3.10.5
node: 4.4.5 x64
python: 2.7.12
git: 2.7.4

Additional information:
tried assign ctrl-shift-{ -- same thing

Thanks for reaching out!
Because we treat our issues list as the Atom team's backlog, we close issues that are questions or if they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

The Atom Flight Manual
The Atom FAQ on Discuss
Discuss, the official Atom and Electron message board
Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.
In particular, this post might be helpful https://discuss.atom.io/t/key-binding-ctrl-shift-not-working/12645.

I had this exact same problem. For those discovering it in the future the correct binding is:
'body':
  'ctrl-}': 'pane:show-next-item'
  'ctrl-{': 'pane:show-previous-item'

You can check what buttons atom thinks you're pressing down with the keybinding resolver.

ctrl-}
pffff hahahaha


useSEOMeta or useHead,  og tag dynamic assigned by requests can't not be fetch by FB or LINE sharing

Environment
Operating System: Darwin
Node Version: v18.14.0
Nuxt Version: 3.11.2
CLI Version: 3.11.1
Nitro Version: 2.9.6
Package Manager<EMAIL_ADDRESS>Builder: -
User Config: devServer, runtimeConfig, modules, gtag, pinia, piniaPersistedstate, i18n, elementPlus, vant, app, css, alias, vite, nitro, imports
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules: -
Reproduction
http://ec-ssr-stage.pqhealthy.com/goods/goods-detail?id=212&goodsChoiceType=0
in LINE tool: https://poker.line.naver.jp/
in FB tool: https://developers.facebook.com/tools/debug/
Both of tools above can not get the ob:title, og:image for assigned value by useSeoMeta or useHead
reproduction code: https://github.com/withgogo/ec-ssr
Describe the bug
http://ec-ssr-stage.pqhealthy.com/goods/goods-detail?id=212&goodsChoiceType=0
Above URL in LINE tool: "https://poker.line.naver.jp/" or in FB tool: "https://developers.facebook.com/tools/debug/" for sharing.
Both of tools above can not get the ob:title, og:image for assigned value by useSeoMeta or useHead

Additional context
No response
Logs
No response

Would you raise this instead at https://github.com/nuxt-modules/og-image ? 🙏

Would you raise this instead at https://github.com/nuxt-modules/og-image ? 🙏
@danielroe
Hi,
It is not only about og-image, also og-title,og-description.  all dynamic assigned value can not be caught by FB or LINE.

It is because you are only setting that data after the page is mounted (on the client):
https://github.com/withgogo/ec-ssr/blob/a9d2528c9b436845ecc157a0bc417225ca9bfc91/pages/goods/mb/goodsDetail.vue#L987

It is because you are only setting that data after the page is mounted (on the client):
https://github.com/withgogo/ec-ssr/blob/a9d2528c9b436845ecc157a0bc417225ca9bfc91/pages/goods/mb/goodsDetail.vue#L987

@danielroe Hi, thank you for your advice. I do that because I have to assign useSeoMeta() the value I got from onMounted functions such as goodsName,goodsImage, etc.
Sure, I can make useSeoMeta() under

The solution is:

seo crawlers need the tags to be rendered in the initial HTML
the initial HTML is rendered before mounted event fires
so you need to fetch the data before the mounted event fires

The solution is:

seo crawlers need the tags to be rendered in the initial HTML
the initial HTML is rendered before mounted event fires
so you need to fetch the data before the mounted event fires

@danielroe Thank you very much, it helps a lot. It seems fine by using "useAsyncData". Please see code below.
However when I  refresh the page, I met another problem with error "".
I am sure it is caused by "useAsyncData", because if I delete the code below, it works fine.
Even if I add the "watch:[params],cache:false", it is not working as well.
So would you please provide any solution for this kind of error?
`const { data } = await useAsyncData(()=>{
state.goodsChoiceType = route.query.goodsChoiceType
console.log("goodsChoiceType",state.goodsChoiceType)
if (state.goodsChoiceType == 7) {
return packageItems(params).then(response=>{
return response.data
})
}
else{
return goodsItems(params).then(response=>{
return response.data.obj
})
}
},
{
watch: [params],
cache: false
},
)
useSeoMeta({
title:  data.value.goodsName,
ogTitle:  data.value.goodsName,
description:  data.value.seoDescription,
ogDescription: data.value.seoDescription,
ogImage:  data.value?.goodsMainPhoto?.fullPath,
twitterCard: 'summary_large_image',
})`

@danielroe I think dynamic seo tag,  which data is from api,  is a very common requirement. Is there any demo or simple way to achieve it?

Here's a simple demo of the concept:
const { data } = await useAsyncData() // whatever async requests you have

useSeoMeta({
  title: data.value.title // or otherwise derive the seo metadat from the data you fetch
})


Doesnt show error if auth is enabled

I just noticed that if dumping TO a cluster with AUTH enabled, and NOT specifying the auth password in the "connection string", rump will not show any error, leading the user to believe that a dump has been performed (when it in fact has not)

Hi,
We just released Rump 1.0.0 with support for Redis URIs with auth.
If you still see this happening feel free to reopen.
Thanks!


[Impeller] Support impeller::MipFilter::kBase for sampling from the base mip level.

SkMipmapMode::kNone is denotes sampling from the base mip level. Impeller today can either sample from the nearest or use trilinear filtering. To support what Skia does, Impeller must add a new mip filter mode for sampling from the base.
In terms of implementation, Metal supports this via MTLSamplerMipFilterNotMipmapped and Vulkan supports this via VkSamplerCreateInfo::maxLod set to 0.

Apparently, even Metal has [MTLSamplerDescriptor lodMaxClamp]. So the same technique can be used in both backends.

I am going to take a shot at fixing/implementing this after a little debrief from @jonahwilliams.
Breadcrumbs:

https://api.flutter.dev/flutter/widgets/Image/Image.html
https://api.flutter.dev/flutter/dart-ui/FilterQuality.html
https://github.com/flutter/engine/pull/40491

For transparency, I'm OOO Th-Fr and most of Monday, but I'll try to get out an early PR and/or updates on this bug.

I'm finally back after a few weeks of totally unconnected PTO and sick-time, and everything else is cleared off my plate. I plan to pick this up starting tomorrow morning.

I spent most of the this afternoon restoring my ability to compile the engine after the RBE transition.
As a starting point, so I can iterate/observe how this works, I'm planning to add the following tests:
// testing/dart/image_filter_test.dart

group('ImageFilter|FilterQuality', () async {
  final ImageComparer comparer = await ImageComparer.create();

  Future<Image> makeImage(FilterQuality quality) async {
    final PictureRecorder recorder = PictureRecorder();
    final Canvas recorderCanvas = Canvas(recorder);
    recorderCanvas.drawRect(const Rect.fromLTRB(1.0, 1.0, 2.0, 2.0), Paint()
      ..color = green
      ..imageFilter = makeBlur(1.0, 1.0, TileMode.decal)
      ..filterQuality = quality
    );
    final Picture picture = recorder.endRecording();
    return picture.toImage(3, 3);
  }

  test('FilterQuality.low', () async {
    final Image image = await makeImage(FilterQuality.low);
    await comparer.addGoldenImage(image, 'FilterQuality.low');
  });

  test('FilterQuality.medium', () async {
    final Image image = await makeImage(FilterQuality.medium);
    await comparer.addGoldenImage(image, 'FilterQuality.medium');
  });

  test('FilterQuality.high', () async {
    final Image image = await makeImage(FilterQuality.high);
    await comparer.addGoldenImage(image, 'FilterQuality.high');
  });

  test('FilterQuality.none', () async {
    final Image image = await makeImage(FilterQuality.none);
    await comparer.addGoldenImage(image, 'FilterQuality.none');
  });
});

I might need to play around a bit with the generated picture & sizing to see the filter quality, but as a starting point.

Initial golden-file test landed (^), I'll work on the actual Impeller implementation next.


UI fix

Fix the com.fibaro.multiLevelSwitch decrease level button action.

Ok, looks good!

I notice little typos and such and wanted to help. I'm kinda new to this collaboration working and wanted to figure out how to use GitHub in vs code. I wanted something that wouldn't cause you more headaches. I am emboldened to fix a few more things.

From: Jan Gabrielsson @.>
Sent: Sunday, July 30, 2023 3:10 PM
To: jangabrielsson/fibemu @.>
Cc: Peter R. Vermilye @.>; Author @.>
Subject: Re: [jangabrielsson/fibemu] UI fix (PR #2)
Ok, looks good!
—
Reply to this email directly, view it on GitHubhttps://github.com/jangabrielsson/fibemu/pull/2#issuecomment-1657255825, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASAXT2R7QD2BZEZMDLZFBXTXS25VBANCNFSM6AAAAAA25FIYHU.
You are receiving this because you authored the thread.Message ID: @.***>

Well, that was easy, wasn't it? :-)
Looking forward to more patches...


Uninstall must leave no traces

msi leaves some files.

duplicate  https://github.com/markuskramerIgitt/salt-windows-msi/issues/2


Handling Persistent Storage Overflow with TanStack Query and persister

Describe the bug
I'm opening this because I think this is a very important issue without a final solution.
@hirbod opened https://github.com/TanStack/query/discussions/6788 and proposed https://github.com/TanStack/query/discussions/6788#discussioncomment-8718145.
But I think we need more discussion on this.
How often does this bug happen?
Every time
TanStack Query version
5

Thanks @frederikhors - I agree this needs more visibility.
For anybody looking for an idea/solution for now, this is what I call on every app start (native; or reload in terms of our SPA for web)
const buildKey = process.env.CODEBUILD_BUILD_ID
const buster = `whatever-your-like-${buildKey}`
const prefix = 'your-prefix-entry'

export const clearStalePersistedReactQueryData = () => {
  // this is needed to avoid issues with SSR rendering
  // prevents metro from build failing
  if (typeof window === 'undefined') return

  const persistentStoreTime = Date.now() - 1 * 24 * 60 * 60 * 1000 // Timestamp of 1 day

  storage.getAllKeys().forEach((entry) => {
    // we only want to clear the data for react-query with the prefix defined above
    if (!entry.startsWith(prefix)) {
      return
    }

    const rawValue = storage.getString(entry)
    if (!rawValue) return

    try {
      const value = JSON.parse(rawValue)

      // Check if the entry contains "buster" and if it matches the current buster
      // otherwise delete the entry
      if (value?.buster !== buster) {
        storage.delete(entry)
        return
      }

      if (value?.state?.dataUpdatedAt && value.state.dataUpdatedAt < persistentStoreTime) {
        // Delete the stale entry
        storage.delete(entry)
      } else {
        // Check if the entry contains "pages" and "pageParams"
        if (value.state.data && value.state.data.pages && value.state.data.pageParams) {
          const { pages, pageParams } = value.state.data

          // Check if the length of "pages" and "pageParams" is greater than 1
          if (pages.length > 1 && pageParams.length > 1) {
            // Slice "pages" and "pageParams" to keep only the first entry
            value.state.data.pages = pages.slice(0, 1)
            value.state.data.pageParams = pageParams.slice(0, 1)

            // Update the stored value with the modified data
            storage.set(entry, JSON.stringify(value))
          }
        }
      }
    } catch (error) {
      console.error(`Error parsing JSON for key ${entry}:`, error)
    }
  })
}

In case you're confused about the "pages" part. We just want to persist one page. maxPages is not working well (both problems with react native and the persister)

we already have an issue for this:

#7049


docs(oidc-use-case): italicize identity provider

I require approval from my company before I can merge this PR. I should receive it within a day or two.

@anthony-telljohann

I require approval from my company before I can merge this PR. I should receive it within a day or two.

@anthony-telljohann did you still need approval from your company? I can merge this PR for you.

Should be good to go now. Thanks guys!


update urara screenshot

🤔 It looks better now

Thanks, I agree the new screenshot looks better. The problem is, all the screenshots are auto-generated by site/scripts/takeScreenshots.js and auto-updated every 3 months by the GitHub action in .github/workflows/updateScreenshots.yml. So if we merge this now, it would be reverted in a month or so.
What did you do to get the better screenshot? Zoom in on the page? Make the window smaller? Perhaps we could store metadata with each site that specifies the values for clip in Puppeteer's page.screenshot() options.

Thanks, I agree the new screenshot looks better. The problem is, all the screenshots are auto-generated by site/scripts/takeScreenshots.js and auto-updated every 3 months by the GitHub action in .github/workflows/updateScreenshots.yml. So if we merge this now, it would be reverted in a month or so.
What did you do to get the better screenshot? Zoom in on the page? Make the window smaller? Perhaps we could store metadata with each site that specifies the values for clip in Puppeteer's page.screenshot() options.

The demo site defaults to light or dark theme, but I manually set it to valentine theme. That is: <html data-theme="valentine">

Thanks, I agree the new screenshot looks better. The problem is, all the screenshots are auto-generated by site/scripts/takeScreenshots.js and auto-updated every 3 months by the GitHub action in .github/workflows/updateScreenshots.yml. So if we merge this now, it would be reverted in a month or so.
What did you do to get the better screenshot? Zoom in on the page? Make the window smaller? Perhaps we could store metadata with each site that specifies the values for clip in Puppeteer's page.screenshot() options.

The demo site defaults to light or dark theme, but I manually set it to valentine theme. That is: <html data-theme="valentine">

🤔 So if want auto-generated screenshots to use the valentine theme by default, need localStorage.setItem('theme','valentine') ...

I guess it would be a lot of work for not much gain to apply specific options for a site when taking the screenshot. Perhaps you could just change urara's default theme to valentine?

I guess it would be a lot of work for not much gain to apply specific options for a site when taking the screenshot. Perhaps you could just change urara's default theme to valentine?

u're right. mainly the valentine theme is more eye-catching (in preview), but as a template, it needs a more neutral theme;
so be it. (btw, for the design of awesome-svelte-kit.netlify.app, I think DaisyUI can be used as a reference)


Merge checkout e2e tests fix to release/1.2.x branch

commits:
623e809418b34782738c2c75a738e3cd6f4f51db
2ce56a01d1e36ebfed434798234fc5ee0084bcc0

PR https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/4873


cardano-tracer: configurable addition of prefixes for metrics

We are removing the Cardano.Node namespace prefix from all traces in cardano-node.
This will impact metric names.
We'd like to allow users to continue using old metric names: https://github.com/input-output-hk/cardano-node/issues/3978
An easy way for this would be to append a configurable fixed string prefix for Prometheus exports.

Resolved with #5905. The optional node config value TraceOptionMetricsPrefix (String) has been added for that purpose.


How to download a video from YouTube AS an mp3?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.11.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.11.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.11.18
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
(I know there's a lot of stuff in the README.md) But I am not exactly sure how to use those commands so I thought I would just ask a question
So all I want to do and I assume it's simple but I am not exactly sure how to do it is to download a YouTube video but as an mp3

What is my post a duplicate of and how do i solve this


Updated README

I rewrote the README file as we discussed. Please tell me of anything needs to be changed.
Cheers! Nathan.

It is great! Thank you.


Minimal Guardrails as a Service Implementation

Pull Request Type

[ ] Breaking Change
[x] Feature
[ ] Bug Fix

Link to Notion Task or Github Issue
https://www.notion.so/guardrailsai/Merge-main-GaaS-4c764274407e440abacb986ac9bc0e8b?pvs=4
Summary of Feature(s)

Adds API Client and serialization methods to allow running select Guards on the Guardrails as a Service API
Patch structures to get back and forth between OSS and API to work "as-is"

We'll need to make the api client repo public before we merge/release this

Codecov Report
Attention: Patch coverage is 42.06897% with 84 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@33bd89d). Click here to learn what that means.

Files
Patch %
Lines

guardrails/guard.py
39.43%
43 Missing :warning:

guardrails/llm_providers.py
46.42%
15 Missing :warning:

guardrails/rail.py
20.00%
8 Missing :warning:

guardrails/api_client.py
70.00%
6 Missing :warning:

guardrails/schema/string_schema.py
16.66%
5 Missing :warning:

guardrails/datatypes.py
20.00%
4 Missing :warning:

guardrails/schema/schema.py
33.33%
2 Missing :warning:

guardrails/prompt/base_prompt.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage        ?   80.96%
=======================================
  Files           ?      119
  Lines           ?     6860
  Branches        ?        0
=======================================
  Hits            ?     5554
  Misses          ?     1306
  Partials        ?        0

Flag
Coverage Δ

unittests
80.96% <42.06%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(theme): Add poimandres theme

Added a poimandres inspired theme.

Thanks a lot!

@Myles-J Sorry tag you is it possible for me to put your github link in the file?
# Poimandres
# Theme create by: https://github.com/Myles-J
# Update by(sort by time):
#
# Thanks for all contributor!!
// ...

@Myles-J Sorry tag you is it possible for me to put your github link in the file?
# Poimandres
# Theme create by: https://github.com/Myles-J
# Update by(sort by time):
#
# Thanks for all contributor!!
# ...

Of course