HADOOP-17432. [JDK 16] KerberosUtil#getOidInstance is broken by JEP 396

JIRA: https://issues.apache.org/jira/browse/HADOOP-17432

Removed the use of JDK internal APIs
Deprecated KerberosUtil#getOidInstance
Use the default OID in Hadoop

TestAltKerberosAuthenticationHandler passed in JDK 16-ea+28.
[INFO] Running org.apache.hadoop.security.authentication.server.TestAltKerberosAuthenticationHandler
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.761 s - in org.apache.hadoop.security.authentication.server.TestAltKerberosAuthenticationHandler

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 15s

trunk passed

+1 :green_heart:
compile
20m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 22s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 40s

trunk passed

+1 :green_heart:
mvnsite
2m 22s

trunk passed

+1 :green_heart:
shadedclient
20m 52s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m  1s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  9s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  3s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
19m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

-1 :x:
javac
19m 17s
/diff-compile-javac-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 2 new + 2043 unchanged - 0 fixed = 2045 total (was 2043)

+1 :green_heart:
compile
21m 15s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

-1 :x:
javac
21m 15s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 2 new + 1939 unchanged - 0 fixed = 1941 total (was 1939)

-0 :warning:
checkstyle
3m 13s
/diff-checkstyle-root.txt
root: The patch generated 12 new + 3 unchanged - 0 fixed = 15 total (was 3)

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

-1 :x:
shadedclient
17m 26s

patch has errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-auth in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
javadoc
0m 37s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-yarn-client in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
javadoc
0m 38s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-yarn-services-core in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
javadoc
0m 38s
/patch-javadoc-hadoop-common-project_hadoop-auth-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-auth in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.

-1 :x:
javadoc
0m 38s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-yarn-client in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-yarn-services-core in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.

-1 :x:
findbugs
0m 37s
/patch-findbugs-hadoop-common-project_hadoop-auth.txt
hadoop-auth in the patch failed.

-1 :x:
findbugs
0m 37s
/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

-1 :x:
findbugs
0m 37s
/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt
hadoop-yarn-services-core in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 39s
/patch-unit-hadoop-common-project_hadoop-auth.txt
hadoop-auth in the patch failed.

-1 :x:
unit
0m 38s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

-1 :x:
unit
0m 39s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt
hadoop-yarn-services-core in the patch failed.

+0 :ok:
asflicense
0m 41s

ASF License check generated no output?

180m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 141445d893dd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3234e5eaf36

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/testReport/

Max. process+thread count
538 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  1s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  9s

trunk passed

+1 :green_heart:
compile
24m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 31s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 40s

trunk passed

+1 :green_heart:
mvnsite
2m  8s

trunk passed

+1 :green_heart:
shadedclient
20m  0s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 51s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  8s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
19m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 26s

the patch passed

+1 :green_heart:
compile
17m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 21s

the patch passed

+1 :green_heart:
checkstyle
2m 31s

the patch passed

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 45s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
3m 19s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 14s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
26m 43s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
19m 38s

hadoop-yarn-services-core in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

231m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4ae34bfa5b8a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3234e5eaf36

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/testReport/

Max. process+thread count
836 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Have you tried that if
export YARN_OPTS="--illegal-access=permit"
export YARN_OPTS="--illegal-access=permit"

could solve the problem as a workaround?
@aajisaka

@theRealELiu
I think the workaround works. However, it will force users/admins to set the --illegal-access=permit option to all the Hadoop applications, which is not ideal.

Thanks for your explanation.
Do you know the release date of 3.3.1 or 3.4? And is there any plan to support java-17, it's a LTS version.

Do you know the release date of 3.3.1 or 3.4?

3.3.1 will be released soon. I don't know when 3.4 will be released.
https://lists.apache.org/thread.html/r7257d55d909dceced11203bf9519917f2ec43aa443d343199eed7f56%40<common-dev.hadoop.apache.org>

And is there any plan to support java-17, it's a LTS version.

I want to support Java 17 by September 2021, when Java 17 will be released.

Thanks, that's really a good news.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  2s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m  3s

trunk passed

+1 :green_heart:
compile
22m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 10s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
3m 56s

trunk passed

+1 :green_heart:
mvnsite
2m  0s

trunk passed

+1 :green_heart:
shadedclient
19m 46s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
1m  9s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
22m 19s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
22m 19s

the patch passed

+1 :green_heart:
compile
19m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
19m 28s

the patch passed

+1 :green_heart:
checkstyle
3m 47s

the patch passed

+1 :green_heart:
mvnsite
2m  8s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 52s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m 20s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 20s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
27m 34s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
19m 55s

hadoop-yarn-services-core in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

230m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2546

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e7a3e84e5c7c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b99dba38b99

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/testReport/

Max. process+thread count
836 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Vidya reddy pretty code

Code consistency using Prettier and its workflow

Looks like you've got a merge conflict


No results

Working suggestions workflow

Actually, I'm gonna move the all the persistence code the Thanks instead of Home


Connection

If i wanted to connect to my server via ip, outside my wifi network do i need to set my specific port and ip address in the config? Thanks

It does not exist a complete copy of the server! so that will have to wait


Import errors for ESM

I'm having trouble importing the ESM export for this module in ethereumjs code when I run our client in nodeJS (not with ts-node/tsx).
If I import using:
import trustedSetup from `@paulmillr/trusted-setups`
...
const kzg = new KZG(trustedSetup.trustedSetup)

I get this error

If I import as a named export:
import { trustedSetup } from `@paulmillr/trusted-setups`

I get this error:

I'm not sure why node isn't interpreting the exports map correctly in package.json but I've tried every trick I know.
It works fine when we use tsx so not sure why node is having trouble here.
You can see what I mean in this branch
If you look at our CI, the client cli tests (which use tsx to invoke the client) have no issues but our Docker build job fails since it uses node ./dist/esm/bin/cli.js to run our client in native javascipt.
Any suggestions?

https://github.com/paulmillr/trusted-setups/releases/tag/0.1.1

Thanks for the quick fix here. Looks like maybe you didn't include the types in the new release?  I'm not seeing them when I upgrade to 0.1.1 from npm.

https://github.com/paulmillr/trusted-setups/releases/tag/0.1.2


Deformable Convolutional Op Support

System information

TensorFlow version (you are using):2.0 alpha
TensorFlow Addons version:0,21
Is it in the tf.contrib (if so, where):no
Are you willing to contribute it (yes/no):yes,if i know how to do that
Are you willing to maintain it going forward? (yes/no):yes

Describe the feature and the current behavior/state.
Deformable Convolutional Network(https://arxiv.org/pdf/1703.06211.pdf,https://arxiv.org/pdf/1703.06211.pdf) has achieved good results in the du detection task.But the current version of Tensorflow does not seem to implement deformable convolution operations.The efficiency of some third-party implementations of deformable convolution operations is lower than that of the mxnet version(https://github.com/msracver/Deformable-ConvNets).I hope that Tensorflow can add native deformable convolution operations in future versions.
Thanks.
Will this change the current api? How?
Yes,Add a new op
Who will benefit with this feature?
Any one want to use tensorflow for object detection.
Any Other info.

Here's a python only implementation of v1 for Keras which can be ported to TF-Keras. This repository is the official implementation with CUDA code; it's written using MXNet but it can be ported over to TensorFlow.
Here are the papers:

Deformable Convolutional Networks
Deformable ConvNets v2

I can start working on this if needed. I'll get the python implementation for v2 up and running first, followed by the proper CUDA/C++ implementation.

Here's a python only implementation of v1 for Keras which can be ported to TF-Keras. This repository is the official implementation with CUDA code; it's written using MXNet but it can be ported over to TensorFlow.
Here are the papers:
Deformable Convolutional Networks
Deformable ConvNets v2
I can start working on this if needed. I'll get the python implementation for v2 up and running first, followed by the proper CUDA/C++ implementation.

Thanks for reply.And here is a Mask RCNN implemented by Tensorflow that may help test.

@rootkitchao Welcome, William. I think you can go first because you seems willing to contribute the codes, right?

Are you willing to contribute it (yes/no):yes,if i know how to do that

@rootkitchao Any update? I can work on this if you aren't.

Using native CUDA for deform conv is dependant on #118 .

Any update on this ? It would be nice to have deformable convolution available

I tried to look into it, but it is too hard for me to do as I don't have experience in CUDA.
I wonder how hard would it be to port this implementation (tf1.4) to tf2.0 :
https://github.com/Zardinality/TF-deformable-conv
This is the first version of the paper, but ideally it would be nice to have deformable-conv V2 :
https://arxiv.org/abs/1811.11168
For which there is an implementation for pytorch, as cited by @Squadrick
Thank you

@Squadrick  you mentioned you'd implement DCN v2 in TF 2 : is this something you're having progress with ?

@vlordier Nope, haven't found the time to get around to this. Feel free to open a PR if you decide to work on this.

/cc @smallsunsun1

/cc @smallsunsun1

I  implemented a Deformable Conv2D V2 And DeformablePsROIAlign operation In both cpu and gpu according to mmdetection https://github.com/open-mmlab/mmdetection. My implenmentation is https://github.com/smallsunsun1/custom_ops/tree/master/deformable_conv2d_ops_new , which  support tf2.0 and built by CMake.

@smallsunsun1 Do you want to officially PR you impl on TF addons?

@bhack Maybe I can have a try, but I haven't PR before, it may task some time==

@bhack Maybe I can have a try, but I haven't PR before, it may task some time==

Please let us know if there is anyway we can help. We have some documentation to get you started.
TFA pull requests: https://github.com/tensorflow/addons/blob/master/CONTRIBUTING.md#pull-requests
Getting started with contributions: https://github.com/gabrieldemarmiesse/getting_started_open_source

@seanpmorgan I clone the addons repo, tested my deformable_conv2d impl in local, building passed in tensorflow2.0 and cuda10.0,  noticed the lastest branch is target in tensorflow2.1 and cuda10.1. But I can't have a cuda10.1 environment to test the code. Is there any problem if I push a request

@seanpmorgan I clone the addons repo, tested my deformable_conv2d impl in local, building passed in tensorflow2.0 and cuda10.0, noticed the lastest branch is target in tensorflow2.1 and cuda10.1. But I can't have a cuda10.1 environment to test the code. Is there any problem if I push a request

Not at all. We have CI testing that will run it on GPU for you (So even if you didn't have a GPU you could still test it.) We welcome WIP PRs so feel free to start the PR and we can go from there.

already open a PR  https://github.com/tensorflow/addons/pull/1129, support DeformableConv2d ，DeformablepsROIalign and EquiConv

March of 2020 year, much of networks uses Deform, but TF still ignores it.

Do you have any news about the progress of this PR and deformable convolutions in TensorFlow?

I've created new PR since the previous PR is stale and contains the unknown license code. I'd like to make this PR reviewed before it gets stale ;-).
https://github.com/tensorflow/addons/issues/179

Hello. I hope you are good. There is no implementation of deformable convolution in tensorflow2. Could someone please help me?
There is a deform conv class where you can use it in tensorflow2 but you can not use it in tensorflow model?
How can I make this class to be usable in models?

@aAmohammadrezaaA  The state of deformable convolution in tensorflow 2 is tearful. There were several different merge requests with different implementations. I tried in the past some of them and all were quite good and working. However both tensorflow team and tf-addons team have little time to do good PR and integration it to the framework. The best advice right now is to try different framework if you want to have a good support of deformable convolutions.

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Use with_retries and load_current_value in DockerImage

Had to revert this... it was exploding test-kitchen.
https://gist.github.com/someara/f4de54614165a5681ea7
PS: The specs on this cookbook are only ChefSpec against the test recipes.
That's just enough to make sure that the resource collection contains the correct resources with the correct properties set. The specs aren't high enough resolution to catch this kind of thing, so actually performing the chef-client run is the only way to be sure.
-s


feat: #1365 Add first, last name and email columns to fam user table

refs: #1365

Hi Ian, I wonder should we add some description to these columns? I saw some of the columns in the table have description, but some don't. Maybe these three are self-explainable?

Hi Ian, I wonder should we add some description to these columns? I saw some of the columns in the table have description, but some don't. Maybe these three are self-explainable?

Good point, I forgot about that, although they are very obvious. I think in the past the team starts adding comments as a best practice. Thanks.


Propagation not working when model changes from a component

Hi guys,
I'm facing a very simple use I think. My model has only one property and I have two Ractive components that show the message in different ways, the first one using a h1 tag and the second using a p. That's all, nothing else is added just to make this PoC.
Both of them show the message in the right way as I expected. Now, I added a button to the second component that changes the message property when clicking it. I used this.set('message', 'Changed from P component'); and works fine but only for the second component. The first one still has the same old text.
model = { message: 'Hello Ractive World!!!' };

var h1 = Ractive({
	append: true,
  data: model,
	target: document.body,
  template: '
{{ message }}
',
  observe: {
  	'message': function() {
    	alert(this.get('message'));
    }
  }
});

var p = Ractive({
	append: true,
  data: model,
	target: document.body,
  template: '
{{ message }}
<button on-click="[\'change\']">Change message property</button>',
  on: {
  	change: function() {
    	this.set('message', 'Changed from P component')
    }
  }
});

I thought that using observer methods in the first component would be a workaround to be notified when the model property changes but nothing happens.
So, here my question, is there a way to let components be notified when model changes?
Ractive versions I'm using are 1.2.0 and 1.3.0
I'm using Express over Nodejs and express-handlebars as the view engine.
Here you can find the jsFiddle with the example.
Thanks in advance.

Ractive doesn't automatically track changes outside of its own scope because js doesn't really offer a good way to do so. When you have two instances pointing at the same data like that, changing the data from one is not visible from the other even though the same data changed. You can either tell the other instance that the data has changed with h1.update() or you can tell ractive that the data should be kept in sync by doing p.link('message', 'message', { instance: h1 }), which says "p should use the internal 'message' model from h1 at its own keypath 'message'". It's kinda like a symlink in fs terms: https://jsfiddle.net/sqyxLn8k/

Thanks for your help. It does really work with the update method but seems to be pretty manual to have a semi-real propagation. link method allows creating a better component architecture and creating some kind of useful patterns.
@evs-chris, thanks for your answer and your code.


NullPointerException at TaskServiceImpl.findByProject(TaskServiceImpl.java:38)

Logged in as another User.... created Project ... clicked on Project...

The Projects are created with Area=All


Factory balance

for a competitive hoi game, faction power should be (roughly) adjusted, so it's not completely one-sided.
eg: how should we make this v3 factory ratio (v3 column) convert?
Name    | V3 | v1 |Ratio| /3 |$/9|
England |1450| 415| 3.5 | 138|161|
Bohemia |1250| 455| 2.7 | 152|139|
Algeria | 545| 130| 4.2 |  43| 61|
Iberia  | 515| 121| 4.3 |  40| 57|
Ukraine | 497| 143| 3.5 |  48| 55|
Novgorod| 455| 136| 3.3 |  45| 51|
Rijnland| 395| 110| 3.6 |  37| 44|
Italy   | 317|  68| 4.7 |  23| 35|
India   | 205|  50| 4.1 |  17| 23|
Croatia |  74|  20| 3.7 |   7|  8|
Greece  |  25|   8| 3.1 |   3|  3|
Korea   |   7|   3| 2.3 |   1|  1|

combine 2 formulas: (a) to minimize large power discrepancies, and (b) to keep nations of roughly even powers together.
(a) could be max_hoi4power(n) = hoi4_power(n-1)+hoi4_power(n-2)
(b) could be max_hoi4power(n) = (vic3power(n)/vic3power(n-1)*max_hoipower(n-1)

hmm taht would still leave bhoemia and england with >1k v3 factory equivalent.
max_hoi4power(n) = 4/3 * log2(hoi4_power(n-1)-0.5) + 1
Playing around in desmos, this gives approximately linear growth for 100% - 120% power, and then decreasing after that. 2.0 => 1.6, 3.0 =>1.9. 2x power is reached when initial power is 3.3x.


Fix spelling of IntelliSense

Fix spelling of IntelliSense to be consistent across the document

@pascalberger : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Correct style update verified.


On switching to a different session, created Objects do not show up

On switching sessions after connected to a session already with objects, objects from switched to Session do not show up. Using AutoJoinSession to switch sessions. After a session is entered with objects, no objects works, but if you are in a session with created objects and then you switch to another session the objects in the switched to session do not show up.

I'm a little confused on your explanation.
Btw, did you try my latest PR for sharing service updates?

No I haven't tried yours but I will, fixes?

This could be a combination of a few things:

You could be spawning sync objects that are owned by a specific player, so when they leave a session their objects are also destroyed.
You are spawning objects that are owned by the server but when all the users leave the room is destroyed.

PR https://github.com/Microsoft/HoloToolkit-Unity/pull/513 added a few nice things for easier/faster testing in editor.

So are the spawned objects connected to a session or a room? Because changing the room seemed to do nothing.

No worries. Pretty sure that it depends on your setup and how you're doing the sync object spawning. They attach themselves to the root object of the room.

Thanks, Hmmm, I must be missing something as switching rooms does nothing but sessions does. And there is pretty much no explanation from Microsoft. The code in the videos is old and has changed.
What is the proper way to setup a room and switch? Thanks.

Good question. I think the Room and Anchor test scene is good, but only works in the editor, but doesn't also show synced objects.  A bunch of this stuff has been on my todo list to make a bit better.

I kind of got the idea that the rooms were just for the anchor position if people were in different rooms and that the objects were attached to the session. That's what I got from reading the descriptions in GitHub repeatedly.

Yeah that sounds correct.

The sessions seem to if the session is kept alive. It's just the switching from one with objects to the other with objects that isn't.
Would you know if there is a way I can attach a String or Bool Value on a session/room?

No you can only create new sync variables on the sync root object.

Hmmmm maybe the sync root is what I need to reset when switching sessions.

Sync System Docs

Ownership

Each element has an 'owner'
Owner is either user in the session or the Invalid user, which is used to represent unowned elements
When a system leaves a session

The server removes elements owned by the user that left, forward changes to remaining systems
The system that left deletes all elements except his/her own and global data

Check out https://github.com/Microsoft/HoloToolkit/pull/42.
It seems to address the persistent session data functionality you're looking for.

Going to close this.  I did push a update to recreate synced objects if needed.


DEPS.xwalk: Roll chromium-crosswalk (05bf17->1021d6)

1021d6 [Backport] Rather than dropping stale navigations, resurrect the navigation entry.
f19d78 [Backport] Don't discard navigations.
BUG=XWALK-4378

Please update your Crosswalk checkout; the old hash you're replacing is wrong.

@rakuco  Any detail about this?

@rakuco

When can we use this fixed function and on which version can we use?

+1

It is going to be part of the next canary (15.44.382.0).

when will 15.44.382.0 be stable? a month or so?

.382 was just the first canary to contain this commit. We branched Crosswalk 15 to the beta channel at 15.44.384.0, so all further betas and stable releases will come from that one.
You can already test v15 beta, and I guess the first stable should come in maybe a month.

@rakuco  Time flies, it's already mid-October now. :smiley:


genomeassembly usage

Hi There,
I'm so happy that this pipeline has been released, I was looking forward to using it.
But while trying it on my data, I realized that the HiC dataset needs to be in .CRAM but I have it as paired .FASTQ (F and R).

you could convert your fastq file to cram using samtools import, eg.
samtools import -@88 -r ID:${prefix} -r CN:${hic_kit} -r PU:${prefix} -r SM:${sample_name} $r1.fastq.gz $r2.fastq.gz -o ${prefix}.cram
samtool index ${prefix}.cram

Thanks so much, @yumisims,
i follow your suggestions, and the pipeline works handsomely on the yeast sequencing test data.


add linkcheck CI for docs

Proposed changes:

add linkcheck to make sure any links in the docs don't throw 404s

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@akelad had the idea to add this to all of our docs. the only edge case i could think of where it wouldn't pass is if we were trying to add docs to rasa and rasa x at the same time that both refer to each other (and those pages didn't originally exist). Otherwise it makes sense if you add one that references the second, to make sure the second is live before merging the first. What do you think?

omg yes please, there's so many broken links in the docs. Will review

Only 3 or so 404s in these docs, but I think Rasa X docs may be way worse 🙈 we definitely need something like this for the Rasa X frontend as well tbh 😄

@erohmensing whats up with this PR?


oidc.gov.bc.ca SSL Cert update

Describe the issue
SSL Cert for oidc.gov.bc.ca is expiring in a month. Let's get an iStore order in place and update it.
Definition of done
Identify what will need to happen/be delivered for this to be completely done

[ ] istore order created
[ ] tech contact updated
[ ] ssl cert updated and installed

@brycereid73 Looks like this needs to be groomed and prioritized -- just making sure you see it in the backlog.

@ShellyXueHan Shelly, I have an IDIR now and I can submit a ServiceNow ticket and they'll create an iStore ticket for me.
I roughly know what the URL is used for, but could you provide a small description of what it is and why it's important? I think it'll help ensure we get the SSL cert renewed without too much hassle.
thx!! Bryce

The SSL Cert for oidc.gov.bc.ca is expiring at Saturday, April 3, 2021 at 10:58:00 AM Pacific. That's the URL for production SSO service, so it's important.... not sure if that explains it?
The cert is renewed every year, so it's better to point the contact list to Conrad or Niran.
Once you get the updated SSL cert, the team can then install it on the SSO route.

I've submitted a ticket in ServiceNow. Once I get the ticket/response, I'll provide an update.

@brycereid73 Please point the contact list to yourself or another dedicated team member. I'm 50% so it's better to leave me off critical path if it can be avoided. Thanks!

@nvunnamm @ConradBoydElliottGustafson
Hi Guys, we need a CSR in order to complete the iStore request.
The following are the instructions for getting a CSR from non-IIS servers.
https://www.entrust.com/knowledgebase/ssl/ssl-tls-certificate-installation-help
##For future reference, here are the instructions and FAQs.
Ordering Process and Best Practices for the Issuance of Trusted
SSL Certificates
SSL Certificates FAQ

@brycereid73 I have attached the csr and key in email.

I've sent an email to IMB with the CSR and key.
I have an IMB ticket, not an iStore ticket yet.
http://imbsd.gov.bc.ca/Ticket/60652


Routing sucks, moving back to express.

This seems to be a problem in your package.json file as yarn doesn't like the semver formatting (notice space) ^12.0. 1.
$ npm i @koa/router@12

added 12 packages, and audited 13 packages in 353ms

found 0 vulnerabilities


Ability to select a unit

Acceptance criteria:

[x] left mouse button click on unit
[x] unit appears selected
[x] right mouse button click deselects unit

Basic functionality is in, but I've added a few TODO's which should be solved first.


Wrong kind of whitespace

'NO-BREAK SPACE' (U+00A0) should be just a normal space for the heading for format correctly.

LGTM 😢


Document procedure and migrate existing Azure AKS based hubs from k8s 1.22+ to 1.24+

This is the current status of Azure AKS clusters.

[x] utoronto, k8s v1.26.3

Upgraded from v1.22.11 to v1.26.3 by Yuvi 2023-06-07 - freshdesk discussion, initiative from Yuvi

Action points

[x] Upgrade all AKS clusters to k8s 1.24+ (1.26+ now)

Planned by Yuvi in https://github.com/2i2c-org/infrastructure/issues/2594#issuecomment-1577057030

[ ] Document a upgrade procedure for AKS clusters (Equivalent of #2142)
EDIT: This issue is closed in favor of #3251

Related

#2057
#2157

Closing as I've extracted #3251 from this now


Add simple buttons test for Nexys Video board.

Used for debugging A200T bring-up.

@mithro @HackerFoo buttons for Nexys Video is working (with VTR @ http://github.com/litghost/vtr-verilog-to-routing/commits/85ea49173b99f3b8dde3c6d06573691e063ef5b9)

There has been a bit collision on the zynq run:
Checking aggregate dir...
ERROR: 1 collisions
  0042179a_022_27: had CLBLL_R_X47Y11.CLBLL_R.SLICEL_X1.BLUT.INIT[16], got INT_R_X47Y11.INT_R.IMUX25.LOGIC_OUTS18
Traceback (most recent call last):

There has been a bit collision on the zynq run:
Checking aggregate dir...
ERROR: 1 collisions
  0042179a_022_27: had CLBLL_R_X47Y11.CLBLL_R.SLICEL_X1.BLUT.INIT[16], got INT_R_X47Y11.INT_R.IMUX25.LOGIC_OUTS18
Traceback (most recent call last):

I'm relatively sure that is unrelated :/

I'm relatively sure that is unrelated :/

Yep, only thing is that this is has happened already and there is some sort of instability. we should keep track of this. I will open an issue


WIP: Enabling AQE on [databricks]

Fixes #1059
This branch fixes a couple of issues with enabling Spark Adaptive Query Execution (AQE) on the Databricks Spark environment.  Currently this is marked as WIP since I'm still investigating whether there are any more obvious ongoing issues with enabling adaptive execution in Databricks systems. Here are the issues fixed so far:

implementing certain method calls that are currently required by the Databricks environment

implementing handling of a logical plan window optimization that happens in Databricks distributions but not currently in Apache Spark.

Fixed the Databricks shim for GpuShuffleExchangeExec for 10.4 to fix the issue with a duplicate submission of the map stage which causes a missing job id reference.

Added to the AQEUtils shim to handle 9.1 so that ShuffleExchangeExec will fallback to CPU when AQE is enabled.

build

This is actually an in issue in GpuShuffleExchangeExec sending an incorrect job id (maybe stage id?) to the scheduler.  Current workaround is to fallback ShuffleExchangeExec to CPU when using Databricks and AQE.

Looks like I found a new failure when using SQL UNION, seems to crash the system:

build

Fixed the issue in GpuShuffleExchangeExec on Databricks 10.4. For Databricks 9.1, ShuffleExchangeExec will fallback to CPU when AQE is enabled in that environment, due to the complexities of how it handles the submission of the map stage. Updated the lead comment to reflect updates.

Fixed the issue in GpuShuffleExchangeExec on Databricks 10.4. For Databricks 9.1, ShuffleExchangeExec will fallback to CPU when AQE is enabled in that environment, due to the complexities of how it handles the submission of the map stage. Updated the lead comment to reflect updates.

Have we measured the performance impact of this?  In many cases AQE is not that big of a performance win, but sending the data to the CPU and back again is a really big performance hit.

Note that it is still on the GPU in Databricks 10.4. We can measure the performance impact for the older version which has this fallback if that makes sense.
On Sep 2, 2022, at 7:55 AM, Robert (Bobby) Evans @.***> wrote:

Fixed the issue in GpuShuffleExchangeExec on Databricks 10.4. For Databricks 9.1, ShuffleExchangeExec will fallback to CPU when AQE is enabled in that environment, due to the complexities of how it handles the submission of the map stage. Updated the lead comment to reflect updates.
Have we measured the performance impact of this? In many cases AQE is not that big of a performance win, but sending the data to the CPU and back again is a really big performance hit.
—
Reply to this email directly, view it on GitHubhttps://github.com/NVIDIA/spark-rapids/pull/6461#issuecomment-1235600115, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXFDIM3CFV2WRLAYCW33BADV4IIMXANCNFSM6AAAAAAQA4JWIA.
You are receiving this because you were assigned.Message ID: @.***>

overall seems fine, I thought at one point you had mentioned implementing computeStats per exec and trying to get a realistic size, did that not work out?

If we wanted to do it correctly and most accurately, it is a bit an undertaking to implement the PlanVisitor for not just the leaf exec's but also some of the operations. In particular, we have to implement potentially our own Join estimation. Also, when I started looking into it, I got some strangely different numbers in our Parquet reading exec's vs what Databricks is reporting. I figure that can be done separately as potentially a task in the future (if there is any upside to the computation).

Fixed the issue in GpuShuffleExchangeExec on Databricks 10.4. For Databricks 9.1, ShuffleExchangeExec will fallback to CPU when AQE is enabled in that environment, due to the complexities of how it handles the submission of the map stage. Updated the lead comment to reflect updates.

Have we measured the performance impact of this? In many cases AQE is not that big of a performance win, but sending the data to the CPU and back again is a really big performance hit.

Actually figured out how to get GPU Shuffle back in 9.1, will push an update shortly

build

build

build

build

build

build


Test ssl off

Tested with ssl off.

@kltm
Fixed ssl and pushed geneontology/go-devops-base:tools-jammy-0.4.1 that allows "apt-get dist-upgrade" using jammy 22:10 instead of 22:04. Please pull this image ...


Add Phlat Theme by Nic Raboy

Add the Phlat theme which is a flat bootstrap theme.  A live example can be seen on my site https://www.owntheweb.net

Hello @nraboy,
your theme looks great. Thanks for sharing it with the community :+1:
I've merged your theme as cbfae7d365eb01735a15da27e9caab32237da9d7.
Regards,
Digitalcraftsman

You might want to use an absolute path to the thumbnail in the README of your theme. The theme site uses your README as well but the relative file path doesn't work.

Want to submit a PR and get the credit for the fix?

I submitted a PR.


Selectively enable some LLVM loop unrolling options

In https://github.com/openxla/iree/pull/16092 we disabled LLVM loop unrolling, because at the level at which we are currently controlling that, llvm::PipelineTuningOptions, that's an all-or-nothing boolean switch, LoopUnrolling, and it was overall an improvement to disable it.
But the benchmarks on that PR showed that some models had a latency regression when we disabled loop unrolling. They are typically vision segmentation/detection models: DeepLabv3, PoseNet, PersonDetect. Without having looked at the actual code this time and only speaking out of distant memories, these are the models that tend to have the matmuls with the smallest accumulation depths (K). So they are the ones that could potentially benefit from full loop unrolling up to a certain limit, while other models only ever got partial loop unrolling and that never helped.
To get deeper here, we need more fine-grained control over loop optimizations. The boolean llvm::PipelineTuningOptions::LoopUnrolling has the effect of enabling LoopUnrollPass: https://github.com/llvm/llvm-project/blob/badf0ee80c2b53bbc227f5d12c74819c01ceaf3c/llvm/lib/Passes/PassBuilderPipelines.cpp#L1180-L1181 , https://github.com/llvm/llvm-project/blob/badf0ee80c2b53bbc227f5d12c74819c01ceaf3c/llvm/lib/Passes/PassBuilderPipelines.cpp#L1272-L1273 . If we look at the code of that LoopUnrollPass, it actually has options that look like the control that we need: https://github.com/llvm/llvm-project/blob/badf0ee80c2b53bbc227f5d12c74819c01ceaf3c/llvm/include/llvm/Transforms/Scalar/LoopUnrollPass.h#L61-L67 .
So a first step here is to play with these options, trigger benchmarks and see which ones help. Since we did see a regression in https://github.com/openxla/iree/pull/16092 on DeepLabv3/PoseNet/PersonDetect, it seems guaranteed that one of these pass options at least will have an impact.
Actually,besides the above two places where it conditionally adds LoopUnrollPass, there is also this place where it conditionally adds LoopFullUnrollPass: https://github.com/llvm/llvm-project/blob/badf0ee80c2b53bbc227f5d12c74819c01ceaf3c/llvm/lib/Passes/PassBuilderPipelines.cpp#L465-L467 . LoopFullUnrollPass seems like a specialization of LoopUnrollPass that only does full loop unrolling (which is what seems to be potentially useful) and not more general partial unrollings (which we wanted to get rid of). So an even simpler first step is to just enable that LoopFullUnrollPass  there.
Once the desirable loop unrolling flavor is identified, we need to design a way to allow controlling it from llvm::PipelineTuningOptions, which will be an upstream LLVM PR.
Tagging some people who might help :-) @dcaballe @mariecwhite @pzread

The priority of this just increased after later comments on #16092, so i'll work on this tomorrow.


space optimization possible? struct{} takes up space when it is listed last in a struct

I have a use case where it would be useful to have a field inside of a struct that gets changed in type from something to type struct{} -- and then no longer takes up space (I want to use golang structs like protobuf message definitions).
When I checked my assumption however, I find a surprise: when the struct{} field is alone, it doesn't take up any space, as expected. But when the struct{} field is with another member, then it takes up 8 bytes. Ouch!  It seems like an opportunity for optimization has been missed.
package main

// run on : go version go1.7 darwin/amd64  (osx 10.11.6)

import (
	"fmt"
	"unsafe"
)

// A is size 0
type A struct {
	NotAMystery struct{} // takes up 0 bytes, as expected
}

// B is size 8
type B struct {
	Hithere int64 // takes up 8 bytes, as expected.
}

// C is size 16
type C struct {
	Hithere int64
	Mystery struct{} // takes up 8 bytes, HUH??
}

func main() {
	var a A
	var b B
	var c C
	fmt.Printf("size of A is '%v'\n", unsafe.Sizeof(a))
	fmt.Printf("size of B is '%v'\n", unsafe.Sizeof(b))
	fmt.Printf("size of C is '%v'\n", unsafe.Sizeof(c))
}

/*output

$ go run meas.go
size of A is '0'
size of B is '8'
size of C is '16'

*/

So strange... if I move the struct{} field to the top, it again no longer takes up space!
// D is size 8
type D struct {
        MoreMystery struct{} // takes up 0 bytes, now that it is at top.
        Hithere     int64
}

func main() {
        var a A
        var b B
        var c C
        var d D

        fmt.Printf("size of A is '%v'\n", unsafe.Sizeof(a))
        fmt.Printf("size of B is '%v'\n", unsafe.Sizeof(b))
        fmt.Printf("size of C is '%v'\n", unsafe.Sizeof(c))
        fmt.Printf("size of D is '%v'\n", unsafe.Sizeof(d))
}

/*output

$ go run meas.go
size of A is '0'
size of B is '8'
size of C is '16'
size of D is '8'

*/

The space loss seems happen only when the struct{} is the very last member of the struct.
// G is size 16
type G struct {
        Starter int64
        Dep6    struct{} // takes up 0
        Hithere int64
}

// H is size 24
type H struct {
        Starter int64
        Dep6    struct{} // takes up 0
        Hithere int64
        Dep7    struct{} // takes up 8
}

// I is size 24
type I struct {
        Starter int64
        Hithere int64
        Dep6    struct{} // takes up 0
        Dep7    struct{} // takes up 8
}

This is due to the fix for #9401.


Feature/cjm 62503 move the xdm:trackingToken from option-detail.schema.json to decisionitem.schema.json

#1828

I updated the trackingToken path to be consistent with all other attributes in the schema and also removed the "_" prefix from the trackingToken attribute name.


ciao-cli: Add Cinder support

Cinder is a block storage service for OpenStack
Added commands are:
ciao-cli volume [add list show update delete]
Signed-off-by: Alberto Murillo<EMAIL_ADDRESS>

Coverage remained the same at 64.735% when pulling 8d7ff28bc86a40b67f9fe41a631269f574fda2bc on sameo/topic/cinder into 117331aae2178ba4d72265a3615016fbd30463f4 on master.


Provide proxy setting instruction for more compatibility.

Provide proxy setting instruction for more compatibility.
Describe the pull request

What does your PR fix?
Fixes #15434

Which triplets are supported/not supported? Have you updated the CI baseline?
Not related

Does your PR follow the maintainer guide?
Yes, but not related

Acceptable.

Acceptable.

/azp run

/azp run

open62541's regression is not related to this PR.

open62541's regression is not related to this PR.


Automate builds for arm64 (Apple Silicon) devices

The current publish workflow builds x64_86 Mac applications. These will run on M1/M2 devices, but with noticeable slowdown. Github does not currently support Apple Silicon runners though they are roadmapped for Q4 2023.
Short term solution: Manual build and upload on Apple Silicon devices when releasing new versions.
Intermediate solution: Self-hosted runners.
Long-term solution: Migrate to GitHub runners when they are supported.

Github runners are available for M1 on Sonoma (MacOS 14): https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Also interesting for cross-platform builds: https://github.com/marketplace/actions/run-on-architecture


ROX-25454: Add image ID/name(s) to scan logs

Description
Adds additional details to logs to help troubleshoot image scan caching issues.
The workflows that were updated include:

Sensor requesting Central Scans (ImageService.ScanImageInternal)
Sensor requesting Central Match Vulnerabilities, a.k.a delegated scanning (ImageService.EnrichLocalImageInternal)

Changes include:

Add image id to logs

the presence of an image id is required for caching to be considered

Add image name from request in addition to image name from DB to various logs

The name used for scanning may not be the same name that was from the request IF an image existed in cache

Add the request ID to delegated scanning warn logs

So that can determine if the warning was from a sensor event or scan request from central that was delegated

Add debug logs for cache misses for both delegated and non-delegated scans

Debug since these may be verbose.

User-facing documentation

[x] CHANGELOG update is not needed
[x] Documentation is not needed

Testing

[x] inspected CI results

Automated testing

[x] contributed no automated tests

Logging changes.
How I validated my change
Deployed to an infra cluster, and created various deployments to trigger logs:
ImageService.ScanImageInternal
oc run nginx --image=nginx:1.27.0

Central:
pkg/images/enricher: 2024/07/25 19:26:36.558486 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:1.27.0" (id "")
pkg/images/enricher: 2024/07/25 19:26:37.389749 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.27.0" (id "")

pkg/images/enricher: 2024/07/25 19:26:37.822965 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:1.27.0" (id "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c")
pkg/images/enricher: 2024/07/25 19:26:38.404277 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.27.0" (id "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c")

Notice the new logging of id
Scanning an image with the same id but different name should trigger cache miss logs:
oc run nginx-latest --image=nginx:latest

Central:
pkg/images/enricher: 2024/07/25 19:28:21.976224 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:latest" (id "")
pkg/images/enricher: 2024/07/25 19:28:22.834342 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:latest" (id "")

image/service: 2024/07/25 19:28:24.208989 service_impl.go:269: Debug: Scan cache miss enriching image {"image": "docker.io/library/nginx:1.27.0", "image_id": "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c", "request_image": "docker.io/library/nginx:latest"}
image/service: 2024/07/25 19:28:24.209327 service_impl.go:269: Debug: Scan cache miss enriching image {"image": "docker.io/library/nginx:1.27.0", "image_id": "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c", "request_image": "docker.io/library/nginx:latest"}

Notice in the cache miss logs the image and request_image names differ - indicating which image name was 'actually' used during enrichment.
Next we force an error by scaling down indexer and scanning a new name:
oc scale deploy/scanner-v4-indexer --replicas=0
oc run nginx --image=nginx:1.26
oc run nginx-a --image=nginx:1.26.1

pkg/images/enricher: 2024/07/25 19:37:25.993096 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:1.26" (id "")
pkg/images/enricher: 2024/07/25 19:37:26.794861 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.26" (id "")
pkg/images/enricher: 2024/07/25 19:37:31.182837 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:1.26" (id "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e")
pkg/images/enricher: 2024/07/25 19:37:31.781587 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.26" (id "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e")

image/service: 2024/07/25 19:37:38.441802 service_impl.go:366: Error: error enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "", "error": "image enrichment error: error scanning image: docker.io/library/nginx:1.26 error: scanning \"docker.io/library/nginx:1.26\" with scanner \"Scanner V4\": index and scan image report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): get or create index: create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: connect: connection refused\"; last resolver error: produced zero addresses", "request_image": "docker.io/library/nginx:1.26"}
image/service: 2024/07/25 19:37:43.468561 service_impl.go:366: Error: error enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: error scanning image: docker.io/library/nginx:1.26 error: scanning \"docker.io/library/nginx:1.26\" with scanner \"Scanner V4\": index and scan image report (reference: \"index.docker.io/library/nginx@sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e\"): get or create index: create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: connect: connection refused\"; last resolver error: produced zero addresses", "request_image": "docker.io/library/nginx:1.26"}

---
pkg/images/enricher: 2024/07/25 19:40:02.595175 enricher_impl.go:372: Info: Getting metadata for image "docker.io/library/nginx:1.26.1" (id "")
pkg/images/enricher: 2024/07/25 19:40:03.399455 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.26.1" (id "")
image/service: 2024/07/25 19:40:04.728694 service_impl.go:269: Debug: Scan cache miss enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "request_image": "docker.io/library/nginx:1.26.1"}
image/service: 2024/07/25 19:40:04.729986 service_impl.go:269: Debug: Scan cache miss enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "request_image": "docker.io/library/nginx:1.26.1"}
pkg/images/enricher: 2024/07/25 19:40:04.731398 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.26" (id "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e")
pkg/images/enricher: 2024/07/25 19:40:04.732924 enricher_impl.go:591: Debug: Scanning image "docker.io/library/nginx:1.26" (id "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e")

image/service: 2024/07/25 19:40:16.761704 service_impl.go:366: Error: error enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: error scanning image: docker.io/library/nginx:1.26 error: scanning \"docker.io/library/nginx:1.26\" with scanner \"Scanner V4\": index and scan image report (reference: \"index.docker.io/library/nginx@sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e\"): get or create index: create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: connect: connection refused\"; last resolver error: produced zero addresses", "request_image": "docker.io/library/nginx:1.26.1"}
image/service: 2024/07/25 19:40:17.705672 service_impl.go:366: Error: error enriching image {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: error scanning image: docker.io/library/nginx:1.26 error: scanning \"docker.io/library/nginx:1.26\" with scanner \"Scanner V4\": index and scan image report (reference: \"index.docker.io/library/nginx@sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e\"): get or create index: create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: connect: connection refused\"; last resolver error: produced zero addresses", "request_image": "docker.io/library/nginx:1.26.1"}

The same test repeated with delegated scanning enabled
oc run nginx --image=nginx:1.27.0
oc run nginx-latest --image=nginx:latest

image/service: 2024/07/25 21:32:03.438131 service_impl.go:537: Debug: Scan cache miss enriching image with vulnerabilities {"image": "docker.io/library/nginx:1.27.0", "image_id": "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c", "request_image": "docker.io/library/nginx:latest"}
image/service: 2024/07/25 21:32:03.478859 service_impl.go:537: Debug: Scan cache miss enriching image with vulnerabilities {"image": "docker.io/library/nginx:latest", "image_id": "sha256:6af79ae5de407283dcea8b00d5c37ace95441fd58a8b1d2aa1ed93f5511bb18c", "request_image": "docker.io/library/nginx:latest"}

oc scale deploy/scanner-v4-indexer --replicas=0
oc run nginx-b --image=nginx:1.26
oc run nginx-c --image=nginx:1.26.1

image/service: 2024/07/25 21:33:43.018029 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.26", "image_id": "", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.26\\\" full_name:\\\"docker.io/library/nginx:1.26\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"", "request_id": ""}
image/service: 2024/07/25 21:33:47.674610 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.26\\\" full_name:\\\"docker.io/library/nginx:1.26\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"", "request_id": ""}

---

image/service: 2024/07/25 21:34:34.003686 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.26.1", "image_id": "", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.26.1\\\" full_name:\\\"docker.io/library/nginx:1.26.1\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"; last resolver error: produced zero addresses", "request_id": ""}
image/service: 2024/07/25 21:34:35.522124 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.26.1", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.26.1\\\" full_name:\\\"docker.io/library/nginx:1.26.1\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"; last resolver error: produced zero addresses", "request_id": ""}
image/service: 2024/07/25 21:34:35.526990 service_impl.go:537: Debug: Scan cache miss enriching image with vulnerabilities {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "request_image": "docker.io/library/nginx:1.26.1"}
image/service: 2024/07/25 21:34:35.590471 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.26.1", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.26.1\\\" full_name:\\\"docker.io/library/nginx:1.26.1\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:ab111dd9ce57ba8f7e8414ff1cacec7c43f694d1057af0f2e69e08f429097bfb\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"; last resolver error: produced zero addresses", "request_id": ""}
image/service: 2024/07/25 21:34:35.593621 service_impl.go:537: Debug: Scan cache miss enriching image with vulnerabilities {"image": "docker.io/library/nginx:1.26", "image_id": "sha256:3683b9aca292c84809ca60fb2c267a56d41879df91f6b0657694b992e1f3ee6e", "request_image": "docker.io/library/nginx:1.26.1"}

Lastly showing the request ID logged for the roxctl use case:
rctl image scan --image=nginx:1.23.0 --cluster=remote

image/service: 2024/07/25 21:36:15.012048 service_impl.go:495: Warn: Received image enrichment request with errors {"image": "docker.io/library/nginx:1.23.0", "image_id": "", "error": "image enrichment error: scanning image \"registry:\\\"docker.io\\\" remote:\\\"library/nginx\\\" tag:\\\"1.23.0\\\" full_name:\\\"docker.io/library/nginx:1.23.0\\\" \" locally: get or create index report (reference: \"index.docker.io/library/nginx@sha256:33cef86aae4e8487ff23a6ca16012fac28ff9e7a5e9759d291a7da06e36ac958\"): create index: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8443: i/o timeout\"; last resolver error: produced zero addresses", "request_id": "d77b6df9-23c8-4906-8999-840d2b29ea78"}

/retest

/test ocp-4-16-operator-e2e-tests

/test ocp-4-12-qa-e2e-tests

/retest


added stylus loader reference

Hi, I have created a simple loader for stylus and stylus with modules, here is the change in readme to list it among the others.

<EMAIL_ADDRESS>


Bot deployed in teams

We've set up a bot, deployed it on Kubernetes, which contains our backend and the bot image. We've registered the bot on Azure Portal, and then connected our bot to the Teams client by using the link that was provided on Azure Portal.
The bot is reachable, but doesn't respond as expected. For one person in the team, all commands and buttons seems to work, but only for his desktop client on Windows. On mobile and his web-client with teams, he can still press some buttons and get responses, but not use our "reset-user-ID" command.
I'm not really sure what the issue is here, and therefore this issue might be in the wrong place. On places where he gets responses, the others in the project either get no response at all (we can still see the request coming in to our Kubernetes pod), or "An invalid request URI was provided. The request URI must either be an absolute URI or BaseAddress must be set." in the chat. We can however get some output from our "Cancel" dialog, with our greeting card being displayed, but no further than this.
We've edited the buttons to send "msteams" objects as data. We've reverted to an older commit, and the reset-user-ID still doesn't work for other than this one person in the team, but we can get further into the dialog without getting the same error as before.
We've tried restarting the backend and using another client first, but that doesn't seem to help. We don't have authentication for the bot yet, if that could be an issue.
Any suggestions on how to fix this?
I'm using MacOS, but we've had others with Windows which have came to the same result.

Hi @Laktos This does sound very odd. It makes me want to assume that is due to Kubernetes , but I can't say for sure.
A few questions:

What state store are you using?

Default memory state or have you configured CosmosDB or Blob storage?

Is this in production or development?
If prod, do you have the option to create another bot for testing/troubleshooting?

We have default memory state, we assume, since we haven't made any changes there. We noticed that there's a trial for cosmos db which we could try to see if that works better. We're reverting back to working commits of the bot, and trying baby-steps to see what seems to break the bot.
The bot is in production, but we don't have the resources to create another bot for testing. But I guess you could say the reverted branch now is a testing bot. Will update with progress!

Thanks! Yes, memory state is great for development, but is horrible for production. This would completely explains erratic behavior like you are seeing.
Cosmos works well, and there is also a new server less Cosmos, but beware; that is in preview (additionally, you'll need to make sure the container is created already with partition key \id

@Laktos Any updates?

We believe the issue was that we either had empty "sendactivities" lying around. Like:
SendActivity12345()
Either that, or it was that we resolved a merge conflict incorrectly. But it still seems strange that it would work for some, but not others.
Could be that we just got lucky and it worked long enough to see that the bot crashed and re-deployed. This happened when running reset. This was fixed by increasing the available RAM on kubernetes. Now it seems to work as intended!

Ok, thanks. I'm going to go ahead and close this one. Feel free to open another if you are able to identify any specific and reproducible bugs. Thanks!

@dmvtech We figured out what was causing the first set of issues. It was that we when deploying the bot to teams, or elsewhere in the process of starting the bot, generated two sets of language generation files, where only the .en-us.lg files were changed when editing in composer. This caused the people using teams with Swedish to not get the correct responses.


Sign in via HA doesn't work

Hi guys, I'm trying to sing in via integration, but it doesn't work for me. Skoda connect App via browser or mobile forks fine. Is there currently any issue?
Thanks

Have you reviewed this section in the readme?

If you encounter a problem where the integration can't be setup or if you receive an error that there's unaccepted terms or eula, it might be because of your mobile app platform. The underlying library is built by reverse engineering the Android App behavious and thus it use the same client configurations as an Adnroid device. If you only use the app on iPhone/iOS devices it might cause issues with this integration. A workaround is to open the MySkoda app on an android device and it should present an EULA or new terms and condititions to be accepted. If this does not work for you and the particular problem you are facing, please open an issue and provide as detailed problem description as possible and relevant debug logs.

Seems that all the vw services (VW, Skoda and Seat/Cupra) are having problems logging in and no eula or terms and conditions to accept. From app you can access regularly.

Yeas, I tried it Yesterday one more time, reinstalled mobile app too, but no message to accept in app by attempt to login in HA

I can confirm that I also experience this issue. The logs give this error message,
Missing consent for client "technical" scopes: profile
To me this indicates some missing consent/EULA etc, but nothing shows up in neither the iOS nor Android app upon login.

@strandlie @michaldobrotka @matrevis Just login on the "old" application "MySkoda essentials", not the new "MySkoda", and then it will work in HA!

Fantastic, that works. Thanks.
I feel like that should be in the documentation somewhere.

Thanks @iamslan , works for me too!!

Partial Solution is to use older app Skoda Essentials - solved for now :)


Question for features dont searched

Issue Template Requirements
Issue must be of the specified template and follow these requirements or it will be ignored.

Please do not post screenshots of code output
Wrap code in a codeblock
exhibiting spam behavior or "evil" behavior will have the issue ignored
Please make sure your issue hasn't been asked before
Please complete the checklist below (mark boxes [ ] with [x])

Pre-Checklist
I made sure...

[x] I read the README.md
[x] I looked over the examples and wiki
[x] my issue hasn't been asked or solved before

Question
Hi Guys, this lib really exists some feature for post on interaction?
For examples: Send order frindship, like a posts, like a hashtags, search users that like a hashtag, comment in post, comment in hashtah, some this type?
I m see wiki, readme, download by maven in my application but don't search this features, sorry my script i have little english
Thanks,

Have a look at EasyInsta library and let me know if it solved your problem.


AllocSpeedTest_no fails performance on upgraded Kesch

The check is not meeting the reference performance:
FAILURE INFO for AllocSpeedTest_no (for the last of 2 retries)
  * System partition: kesch:pn
  * Environment: PrgEnv-gnu
  * Stage directory: /scratch/jenscscs/regression/production/stage/2019-09-04_17-00-31/kesch/pn/PrgEnv-gnu/AllocSpeedTest_no_retry2
  * Job type: batch job (id=1851968)
  * Maintainers: ['AK', 'VH']
  * Failing phase: performance
  * Reason: performance error: failed to meet reference: time=0.663936, expected 0.55 (l=-inf, u=0.6050000000000001)
------------------------------------------------------------------------------
FAILURE INFO for AllocSpeedTest_no (for the last of 2 retries)
  * System partition: kesch:cn
  * Environment: PrgEnv-gnu
  * Stage directory: /scratch/jenscscs/regression/production/stage/2019-09-04_17-00-31/kesch/cn/PrgEnv-gnu/AllocSpeedTest_no_retry2
  * Job type: batch job (id=1851970)
  * Maintainers: ['AK', 'VH']
  * Failing phase: performance
  * Reason: performance error: failed to meet reference: time=1.62605, expected 1.25 (l=-inf, u=1.375)

See https://jenkins.cscs.ch/blue/organizations/jenkins/reframe-kesch-production-daily/detail/reframe-kesch-production-daily/165/pipeline/

I'm closing the issue, we will follow it in https://jira.cscs.ch/browse/UES-518


Restore timestamps for duplicate binplace files

For files that are written multiple times, make sure to restore the timestamp so that SkipUnchangedFiles works.
Unfortunately, timestamps and hard-links don't play well.

I chatted with @dfederm and this won't work.  The better option is to explicitly note copies in the cache entry and then replay the copies on cache hits.


Add Local Model Support for "Paste with AI" Functionality

Description of the new feature / enhancement
Extend the "Paste with AI" feature to allow users to utilize their locally hosted models by providing an option to input the localhost address, port number, and route. This would enable users to use custom trained models for tasks like prompt-based translation without relying solely on OpenAI's models.
Scenario when this would be used?
Power users who have trained their own language models using tools such as LM-Studio can benefit from this feature. They can paste copied text into the "Paste with AI" functionality, and instead of using an OpenAI API key, they can input the address of their locally hosted model. This would allow for more customized and specialized outputs based on the user's specific training data.
Supporting information
Having this feature would be particularly useful in scenarios where OpenAI models may not have sufficient knowledge about certain domains or terminology. It would also enable users to develop and test their own AI applications locally, without the need for external API keys or services.

/dup #32960


Description field and metadata

Add a description field to the TF browser, so that when you save results as a pdf, you can enter an explanation.
I can also add some metadata (time of running the query) and some statistics (the amount of nodes in the total results, split out per node type, compared with the totals in the whole corpus).
That way the PDF becomes a "proof of work".

Done


In reverse mode, keep_host_header option invalidates proxyauth option

Problem Description
proxy always return 401 when keep_host_header is enabled in reverse mode
Steps to reproduce the behavior:

set mode to be reverse, requests are proxyed as expected
set proxy auth, http auth prompted and can login with the user/pass defined
turn on keep_host_header, host is kept, but http auth does not validate with the correct user/pass

System Information
Mitmproxy: 8.1.0
Python:    3.10.4
OpenSSL:   OpenSSL 3.0.3 3 May 2022
Platform:  Linux-4.14.276-211.499.amzn2.x86_64-x86_64-with-glibc2.31

Could you please post a single mitmproxy/mitmdump + cURL (or Chrome/Firefox) invocation that shows the issue?


🚀 ADR: Support for MermaidJS diagrams

Plugin Name
adr
🔖 Feature description
Support mermaidjs diagram rendering from code fences in ADRs.
🎤 Context
Allow teams to include diagrams, architectural or flow, to help illustrate proposed changes or implementation details of their ADRs. Examples could include;

Logical Flow Diagrams
Class diagrams (C4)
Architectural diagrams

✌ Possible Implementation
Create a custom marked extension to pick up code fence tokens indicating mermaid as the language type.
Marked Code Preview and Marked JSX Renderer are pretty close to what I'm thinking, but for mermaid.
parseMadrWithFrontmatter would implement the extension when parsing, marked.use(mermaidExtension).
Not sure what the implementation would look like, but a nice way to make the plugin more extensible would be to allow consumers of the plugin to provide their own extensions through the <EntityAdrContent /> component or register them in the adr-backend.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Looking at this again. Could this be done with a custom content decorator?


Center document widget and top bar title together

Update: as of 95c5527, PR is now "complete", but of course open for requested changes.
Just two commits so far, with commentary in each: first to clean up a tad; second to get centering math in agreement for both the DocumentWidget and the top bar title.
There is an issue, existing before this patch, of duplication of the logic for positioning the Hermes' DocumentWidget; addressing that remains for a further commit.
I wanted to open this PR now both for feedback on the centering changes and, to be open to advice on how to address the duplicated code.
Will add some test images in a further comment.

Added two further commits:

eb36683 for edits that shouldn't have "escaped" the previous commit, my bad.
95c5527 for consolidating duplicated content area calculations.

Further details in those commits' messages.

After conflict is fixed it can be merged 👍

Fixed.


merge changes in from branch created for PR #104

merged those changes into the master branch

Okay, let's see what happens.

I see them - thanks!


Problem with material icons

Hello,
Only on chrome I've a problem with material icons.
When i choose icon the render is only text

And on my console log :
localhost/:1 Failed to decode downloaded font: https://fonts.gstatic.com/s/materialicons/v18/2fcrYFNaTjcS6g4U3t-Y5UEw0lE80llgEseQY3FEmqw.woff2```

Any suggestion ?

Best regards,

Maybe a temporary error with Chrome? If you still have it, try to fill an issue on Chrome, but unfortunately it doesn't see related to react-mdl.


https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

Request type

[] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details
The embeded example for the thresholds section when opened in CodePen or JSFiddle has an incorrect title. This is due to the code for the example on the Wiki being hidden in a div with an id threshold-example.
When the buttons are created with createSampleButtons the section argument is used to create the title of the CodePen/JSFiddle:
var title = doc.getElementById(section);
title = title ? title.textContent : '';

This is expecting a heading like
Threshold example
 to extract the textContext from, but as I said above on this page the id with threshold-example is a div containing the hidden code and the CodePen/JSFiddle is created with a title of this embeded code.

I'm sure this can be done another way with the wiki to ensure this issue doesn't happen. I didn't have time to figure it out though sorry.

This sure looks ugly; thanks for pointing it out!
So, I've fixed this by putting  the id for the example section on a hidden heading inside the hidden
, rather than on the hidden
 itself.


[docs] consolidate all docs into sub folder

👋 goodness, that was a lot of typing! this is the first step of many for #5026.
the only section that isn't complete with these changes is RELEASING.md, which is in progress in #5252 (those changes will be moved into the proper location if this PR goes in first).
i made a few minor tweaks to the project's README to support this organization. i also left the code of conduct in the root.
one thing i am concerned about is that our little "guidelines for contributing" warning message on PRs is going to disappear after this gets merged because CONTRIBUTING.md is no longer in the root:

should i put a file in the root called CONTRIBUTING.md that links to the docs for contributing? 🤔  i'm not 100% sure on how the github integration for that works so y'all let me know.

Awesome! 😁
I believe we can use either docs/CONTRIBUTING.md or .github/CONTRIBUTING.md. Needs more research.

OMG I looked through this and it is soooooo good. Now I am going to have to deal with what to do about the fact that I have been linking to https://github.com/bundler/bundler/blob/master/ISSUES.md for literally five years. Maybe I can make git.io shortlinks.

CONTRIBUTING.md needs to stay at the root of the repo or in a .github folder to show up when people open PRs/issues

@segiddins i will move the overview document to the root 👌
thanks @indirect!!

ok! the integration definitely requires it to be in the project root. i created a file CONTRIBUTING.md in the root, and used it as kind of a "quick start" guide to contributions with a link to the comprehensive documentation!

woo @bundlerbot r+

@bundlerbot retry


[Renderer] Poor performance on AMD GPU

i got around 150-180 fps when alone
and 30-60fps when 8+ players in the server
and sometimes even crash
and bloom seem to be still broken

my system information

i already has -nobindless launch parameter


There's no build subdir nor CMakeList in FDPutils directory

cannot find /FDPutils/build/,make process is interrupted.So saddly.

Hello, thanks for reporting. Should be fixed in b63f949, could you confirm?

It works,Nice.Thanks.


Page fails if no viewController

{#if firebaseReady}
	{#if loggedIn}
		<page xmlns="tns">
			<label text="logged in"/>
		</page>
	{:else}
		<page xmlns="tns">
			<label text="not logged in"/>
		</page>
	{/if}
{:else}
	<Loading/>
{/if}

<page xmlns="tns">
	<label text="firebase is surely loading loading loading"/>
</page>

I actually think this is expected behavior, but it's probably worth a discussion. I get
** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Error: Required page does not have a viewController created.
From the above.

Navigation to a page requires a page instance, having multiple page instances or a page instance that isn't a top level child will cause issues. Hopefully when navigation support lands this wont be an issue


3.0 Performance for creating Schemas, properties, vertexes and indexes is very slow.

OrientDB Version: 3.0.0 RC1
Java Version: 1.8
OS: Centos
In 3.0 performance for creating is much slower during a database initialize procedure, what used to be a couple of seconds is now over a minute.
In total I create:
82 Vertexes
59 edges
127 Indexes.
hundreds of properties.
I have a wrapper around the code but essentially it's this repeated many times.
checks if class is not null and drops it using
db.getMetadata().getSchema().dropClass(name);
creates a class with
OClass result = db.getMetadata().getSchema().getOrCreateClass(name,
db.getMetadata().getSchema().getClass(inheritFrom));
result.setStrictMode(true);
Create a property with this syntax after checking for existsProperty(var1)
oClass.createProperty(var1, var2);
the only exception is that create index is executed as SQL.  I'm not sure if there was limitations in earlier version.  I create indexes with "FULL TEXT ENGINE LUCENE", others wiht "SPATIAL ENGINE LUCENE METADATA", with  "UNIQUE" and "NOTUNIQUE"
Regards,
Safwan

Hi @ShakAttacked
I think it's related to a refactoring we made, so that schema/index changes are pushed to the client. This fixes a lot of problems with un-aligned schema, but of course it has some cost
Thanks
Luigi

Hi @luigidellaquila,
Ok. It's really heavy but fortunately we only have to deal with that at reset of database in development.  On a similar topic, I see in 3.0 a way to create a schema without going through the metadata() but not for deleting.  It would be nice if there is a direct way from db instance.
Thanks,
Safwan


Support i pv6

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 9 committers have signed the CLA.:white_check_mark: li-xiao-shuang:white_check_mark: steverao:white_check_mark: Sorieee:white_check_mark: likeyoukang:white_check_mark: complone:white_check_mark: DanielLiu1123:white_check_mark: HHoflittlefish777:white_check_mark: YunWZ:x: snaper1You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature] Add possibility to create contact/group for a specific account

For now contact are created on first account found
Add possiblity to select on which account the contact wil be created
Same for group

Good idea. Will add soon.


Fixes #6

Add null check for registrar.activity()
As well as dependencies updates and minor changes

@cmarsh940 will this be merged so we can use for flutter 3.0.5?


Help Installation

I'm a bit confused in the installation.
This error shows up when I do the following:

DL and paste the zip file of this under DIR>vendor>magento-japan folder

Run the following command:
composer config repositories.veriteworksartifacts artifact \vendor\magento-japan
composer require magento-japan/m2-jplocalize
php bin/magento setup:upgrade

Then this error shows up:
Module 'Veriteworks_Region' from '\vendor\magento-japan\m2-jplocalize/region' has been already defined in '/vendor/veriteworks/m2-region'.

Where did I go wrong? Can you please help me. I'm a newbie in magento and still don't know the way around.

You completely misunderstood.
This repository is not same as archived version modules. This is development & for developers repository. If you're not familiar with M2 architecture and composer, please use zip archived version from our website.


UI and database for data-feed-service

Signed-off-by: Martin Scott<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
New settings UI page ( feature flagged ) for the data-feed-service. This is backed by a new DB for the data-feed-service which holds destination configurations for the data-feed.
:white_check_mark: Checklist

[x] Tests added/updated?
[ ] Docs added/updated?

No docs yet. Doc to be finalised once the feature is complete and ready to remove the feature flag.
:camera: Screenshots, if applicable

The UX team will review. we are meeting tomorrow and can discuss this. There may be parallel  design patterns we are working on that may help out with this.


Core Concepts PR follow-up

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)
Changes to the docs site code

Description
I hadn’t realised #893 was so close to being merged, so failed to prioritise getting a review in — sorry about that! This PR is a follow-up, mainly taking care of infrastructural details and some i18n stuff that was overlooked. I also spotted a few typos. Obviously, not being a review, I’ve had to just jump in and do stuff, hope that’s OK — I’m happy to revert anything that doesn’t make sense.

Remove changes to our slug checker in favour of moving translated partial-hydration pages into our old-translations archive directory for reference when translators come to translate the new islands page. I also made redirects for that page work across languages.
Restore some list styling that got lost in the shuffle.

Reinstate the credit for the islands diagram to acknowledge Jason Miller.
Fix a couple typos

While I was there I also took the liberty to:

Get the package manager tab component working on Getting Started (A copy-paste job thanks to @Yan-Thomas’s review in #893 — thank you, Yan!)

One little text comment @delucis , but otherwise, LGTM! Thanks for tackling this!


RSS feed for releases?

Would it be possible to provide an RSS feed for when releases come out?

https://github.com/open-telemetry/opentelemetry-js/releases.atom


--ema in model_zoo eval

Is --ema required on evaluation of model zoo  checkpoints?

If you want to reproduce the results, "--ema" is necessary. But if you only want to infer a model loaded from our checkpoints, "--ema" is useless and will not affect the results.


Steam icon is broken and huge with gnome-shell

Describe the bug
The steam icon is broken and makes the systray huge.
To Reproduce
Steps to reproduce the behavior:

install steam system wide (environment.systemPackages)
run Steam with gnome

Expected behavior
Screenshots
The flameshot icon will return to the normal size if I close steam.
The Steam icon is the first ugly one on the left.

Additional context
Resolution: 1920x1080
Notify maintainers
@jagajaga
Metadata

system: "x86_64-linux"
host os: Linux 5.4.39, NixOS, 20.09pre225264.683c68232e9 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.4
channels(bbigras): "home-manager, unstable-20.09pre225264.683c68232e9"
channels(root): "nixos-20.09pre225264.683c68232e9, nixos-hardware"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Not sure if it's the same bug, but my Steam icon is also broken (same placeholder icon as you have in your screenshot, although not huge) with openbox + tint2 (also tried with another tray). Using NixOS with nixpkgs master.

My awesomewm setup has had a borked steam icon for some time, as well.  Hmm.. does the icon work for any environment, such as KDE perhaps?

I faced a similar issue with the steam icon in stalonetray, where the icon was displayed correctly, but way too big. I was able to fix it by specifying the "force_icons_size" kludge.
i.e. in home-manager:
  services.stalonetray = {
    enable = true;
    config = {
      icon_size = 16;
      slot_size = 24;
      kludges = "force_icons_size";
    };
  };

Might be a problem of steam not providing a correct icon, rather than the tray program displaying it incorrectly?

I still have the broken icon but it's small now. I wonder if something changed in the distro or if it's because I changed my config and probably imported some themes.

+1 from my awesomewm setup, running everything at unstable here.

I get the broken icon as well on Xfce4.

I don't have the broken icon anymore on Gnome and it's the right size. I probably just installed a theme while stealing borrowing stuff from someone else config. I'll try to find which theme did that.

I tried to remove all my themes but the icon is still working. Maybe there's something cached on my side.
Here's what I use for gnome:
https://github.com/bbigras/nix-config/blob/1fab839e92f0170d988fee8c10b9fd9f010cdeda/gnome.nix#L4-L11
The Steam icon also works for sway on my laptop.

Hmm, still broken here :(

Same with awesome

snixembed might be able to fix this https://github.com/NixOS/nixpkgs/pull/131361

My Steam icon is also broken with polybar's tray. Correct size, but missing icon.
Interestingly, running steam from a terminal fixes it. Probably has something to do with how I configure my theming stuff with home-manager?
snixembed does make it show properly, but using it makes all tray icons always show (some programs e.g. udiskie can hide its tray icon on certain conditions).

Related: https://github.com/NixOS/nixpkgs/issues/124965#issuecomment-904020549
That workaround fixes the icon in the systray, but breaks the icons in rofi.
I'm guessing the root issue is with launchers that use gdk-pixbuf.

Is this still relevant?

Not for me.


Shiny Heroku Push Rejected After Running a Few Days

Hi I had a Shiny app running on Heroku the past few days.  Everything was working fine.
Today I went to update the app and it failed to deploy.
It seems to fail at the chroot.tar.gz download step and says push rejected.  It happens even when I rebuild it all from scratch.
Do you know if this is a buildpack issue or if I am doing something wrong?
Thanks!
git push heroku master
Enumerating objects: 104, done.
Counting objects: 100% (104/104), done.
Delta compression using up to 8 threads
Compressing objects: 100% (103/103), done.
Writing objects: 100% (104/104), 2.82 MiB | 1.36 MiB/s, done.
Total 104 (delta 52), reused 0 (delta 0), pack-reused 0
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> R (shiny) app detected
remote: -----> Installing R
remote:        Version 3.6.3 will be installed.
remote: -----> Downloading buildpack archives from AWS S3
remote:        Downloading https://heroku-buildpack-r.s3.amazonaws.com/latest/he
roku-buildpack-r-18-3.6.3-deploy.tar.gz
remote:        Downloading https://heroku-buildpack-r.s3.amazonaws.com/latest/he
roku-buildpack-r-18-3.6.3-shiny.tar.gz
remote:        Setting up build environment
remote:        Downloading https://heroku-buildpack-r.s3.amazonaws.com/latest/he
roku-buildpack-r-18-3.6.3-chroot.tar.gz
remote:  !     Push rejected, failed to compile R (shiny) app.
remote:
remote:  !     Push failed
remote: Verifying deploy...
remote:
remote: !       Push rejected to testswc.
remote:
To https://git.heroku.com/testswc.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.heroku.com/testswc.git'

I'll take a look and try to replicate the issue.

I managed to replicate the issue on my first attempt. I enabled script debugging on the second attempt but the issue mysteriously went away. I made a third attempt, without script debugging (same as the first) and it worked as expected.
Would you mind trying again to see whether it is still failing for you. You can enable script debugging as follows before pushing:
heroku config:set BUILDPACK_DEBUG=1

haha its working now.  interesting.   Thanks!


feat: example contracts in aztec.js

Fixes #1306
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

I fear we may end up with these example contracts out of date, which is a problem considering how fast noir is shipping breaking changes. Maybe we should tweak copy_output in Noir compiler so it copies these artifacts to aztec.js as well? We're already doing so for the account contract ABIs IIRC. Now, if we do that, the tricky thing will be to do it without committing the built artifacts, so we don't start hitting conflicts again, but perhaps we can gloss over that for now.
An alternative could be to ship the examples separately, and just make them easier to import via path remappings or something, but it's true that it's not what the issue asked for in the first place.


Listeners: add error handling & minor other updates

https://jenkins.code.rdkcentral.com/job/github-triggered/726/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/728/ started


Publisher not providing Comixology version anymore

Some publisher does not provide Comixology version anymore so that means no CMX covers too as far as I know.
Some of them are:

[x] Seven Seas Entertainment (2024-07 Week 3 stopped providing to Comixology)

Kodansha USA
some release on 2024-07-30 stopped providing Comixology version with I think all release starting next week only available in Kindle?


fix: single config for single build

Description
Alternative to #17786. We don't need to use sharedConfigDuringBuild after this refactor.

Ah, yes, I wanted to do that and forgot about it. Thanks for the heads up!


Could not build Objective-C module 'GoogleAPIClient'

@dqhieu Could you attach a sample project? I got following errors. Thanks.
Pods/GoogleAPIClient/Source/Objects/GTLService.h:58:13: Include of non-modular header inside framework module 'GoogleAPIClient.GTLService'

Pods/GoogleAPIClient/Source/Objects/GTLService.h:59:13: Include of non-modular header inside framework module 'GoogleAPIClient.GTLService'

Pods/HDPhoneMonitor/HDPhoneMonitor/HDPhoneMonitor/HDPhoneMonitor.swift:11:8: Could not build Objective-C module 'GoogleAPIClient'

My Pod
pod 'HDPhoneMonitor', :git => 'https://github.com/dqhieu/HDPhoneMonitor.git'
pod 'GoogleAPIClient/Core', '~> 1.0.2'
pod 'GTMOAuth2', '~> 1.1.0'
pod 'SVProgressHUD'

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['ENABLE_BITCODE'] = 'NO'
            config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', 'GTM_USE_SESSION_FETCHER=1']
            config.build_settings['CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES'] = 'YES'
        end
    end
end

Can you try remove these lines:
pod 'GoogleAPIClient/Core', '~> 1.0.2'
pod 'GTMOAuth2', '~> 1.1.0'
pod 'SVProgressHUD'