Directly using a stream as input to Speech SDK (from NAudio), speaker recognition cancels

Describe the bug
I get cancellation from either Enroll as well as from the RecognizeOnceAsync when using a PushAudioInputStream object to feed data to the sdk (data got from NAudio WasapiLoopbackCapture object).
Cancellation Details are: Bailed out due to wait more than 1 minutes for the result of enrollment or speaker recognition
Same tecnique will work when used for STT service. Saving the corresponding stream to a file and using that file as input to the SpeechRecognizer will work as well, no cancellation results.
To Reproduce
Steps to reproduce the behavior:
Full repro repo can be shared. Please IM over Teams
Expected behavior
SpeakerRecognition should be able to work with audio coming from outside pushed to the underdlying stream.
Version of the Cognitive Services Speech SDK
1.16
Platform, Operating System, and Programming Language

OS: Windows 10 21H1
Hardware - x64
Programming language: C#
NAudio package: 1.10.0

Closed as fixed in the Speech SDK 1.18.0 release.


Wireless keyboard mishandles non-printable keys

Using the latest git code as of today 2016-12-26, the wireless keyboard adds garbage text for all non-printable keys (running on Mac at least). I fixed the problem locally by adding a switch statement to GuiCapture:handleKeyboardInput().  The switch catches these keys and sets ch to zero which appears to work . This was just the first thing I tried, I don't know if there is a better way to fix it.
Let me know if I should submit a CL (haven't done that before for external projects).
Thanks,
Erik.

What characters(codes) exactly? Can you post contents of few glasses_key_down events?
That sounds like lwjgl/keyboard issue and I don't want to block valid data on all configurations.

Here is my proposed fix (git diff):
http://pastebin.com/7fw660TG
Here is the CC program I used to collect key and char codes (run using multiglass):
http://pastebin.com/Hg8vCQKk
--- The follow is results from hitting they keys:
Here is the output using current shipping OpenPeripheral:
http://pastebin.com/csUQFQae
Here is the output using my proposed fix (also includes 'a' to show that char message still work):
http://pastebin.com/yQ8acYdt
Let me know if I can do anything else useful.
Erik.

Since it's (probably) not possible to open both CC computer and keyboard GUIs, I'm guessing you are using some extra code that translates glasses events to standard key and char events? If so, can you post it?
Also, contents of char event are bit jumbled, but my best guess is that contents of ch are -1 == 0xFFFF, which encodes in UTF-8 to '0xEF 0xBF 0xBF', which, when encoded in ISO-8859-1, gives us ï¿¿. Best guess since last two chars are 'replacement characters' �.
But quick look into LWJGL shows that 0xFFFF (KeyEvent.CHAR_UNDEFINED) is replaced with 0x00, so I'm not sure if I'm guessing correctly.
Anyway, without rambling, can you print contents of 'ch' instead of already converted value on Lua side? Or print contents of char event after converting with string.byte?

The chars (16-bit values) all appear to start with $f7, such as the arrow keys:
$f700 up
$f701 down
$f702 left
$f703 right
$f704 F1
... and so on
A quick Google search found these values mapping to the same keys (in a Python project mind you), and it shows different values for different platforms (Linux different from Mac).
The bottom line, is that these keys are being assigned char values, but ComputerCraft does not want char values for these non-printable keys. My change is tied to the keycode value and clears out the char value, so it sounds safe to me.

Found doc about Mac behaviour.
Since all Mac chars are from private use area, I will just block that block. It will still be less restrictive than CC char event (if ((ch >= ' ') && (ch <= '~'))), but compatible with OC unicode capabilities.
On Linux side it seems to use XLookupString and Xutf8LookupString which seem safe, i.e. don't return anything for arrow keys (verified with xev).

Thanks for the reference.  So it looks like Apple being Apple as usual
(always doing things a little different just to annoy developers).
My local change works fine for me in the meantime.  Should I code-review a
change you make? (or should I make the change)
Either way it looks like you found a solution.  Thanks!
Erik.
On Thu, Dec 29, 2016 at 1:06 AM, Bartek Bok<EMAIL_ADDRESS>wrote:

Found doc about Mac behaviour
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/EventOverview/HandlingKeyEvents/HandlingKeyEvents.html#//apple_ref/doc/uid/10000060i-CH7-SW16
.
Since all Mac chars are from private use area, I will just block that
block. It will still be less restrictive than CC char event (if ((ch >= '
') && (ch <= '~'))), but compatible with OC unicode capabilities.
On Linux side it seems to use XLookupString and Xutf8LookupString which
seem safe, i.e. don't return anything for arrow keys (verified with xev).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenMods/OpenPeripheral-Addons/issues/92#issuecomment-269600937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXoyqqHQ6P3Sfz7l66uZ_4D2vlCzmS7eks5rM3f_gaJpZM4LWAeZ
.

Blocked private use block. Leaving control block as-is for now, since it's mostly consistent between platforms (though Windows does not return any char for 'delete', while Linux does). So for full compatibility with char event from CC values < 0x20 still have to be filtered on Lua side.


Set computer name for VCD VMs

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>What this PR does / why we need it:
Set computer name for VCD VMs.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Optional Release Note:

NONE

/lgtm
/approve

/retest


Resolve Gfx mode missing surface updates from cache.

In the android client library.
We found that while using Gfx mode, some screen updates (usually when not much is changing) were being missed, for example when viewing a clock running seconds.
I did some really deep digging and had to compare against the X11 version which the updates would show correctly.
I found that some of the android_end_paint callbacks had no regions to update, and it appeared that the reason was that sometimes the android_begin_paint callback was returning false.
The windows and X11 clients don't implement the begin_paint callback, so in removing all code from the android_begin_paint and just returning TRUE, the android_end_paint would have regions to update and we would no-longer miss surface updates which were in the cache.

@freerdp-bot test


Fix crash when getting EGL function proc address

Unable to load EGL functions while launching a Vulkan desktop application and it causes the local capture to crash on Linux.

Yes indeed, when GLES is disabled it works fine. I have modified my commit, this smaller change might be a better solution to avoid the crash.

I'm in the middle of the refactor I mentioned which will invalidate any change in this area, but I'll check to make sure this case doesn't crash with my changes (it should be much less entangled and more stable).

The refactor is now merged. I'm going to close this PR as I believe the bug you mentioned was fixed - linux now builds GLES by default and I tested capturing vulkan which worked fine.


error using ghc821 in nix shell

Issue description
When I try to use the ghc821 compiler in a nix shell with nixpkgs master ( cadb42f ) it does not successfully make a shell.
Steps to reproduce
nix-shell -I ~/p/nixpkgs -p haskell.packages.ghc821.ghc --show-trace

error: while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘shell’ at /nix/store/3ldh2mcz8c9vq1g14xvyxr2f2ldyqp4g-nixos-17.09pre105622.f0fac3b578/nixos/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating ‘getOutput’ at /nix/store/3ldh2mcz8c9vq1g14xvyxr2f2ldyqp4g-nixos-17.09pre105622.f0fac3b578/nixos/lib/attrsets.nix:453:23, called from undefined position:
while evaluating ‘getCrossDrv’ at /nix/store/3ldh2mcz8c9vq1g14xvyxr2f2ldyqp4g-nixos-17.09pre105622.f0fac3b578/nixos/pkgs/stdenv/generic/default.nix:133:21, called from undefined position:
while evaluating the attribute ‘packages.ghc821.ghc’ at /nix/store/3ldh2mcz8c9vq1g14xvyxr2f2ldyqp4g-nixos-17.09pre105622.f0fac3b578/nixos/pkgs/top-level/haskell-packages.nix:111:3:
attribute ‘ghc821’ missing, at (string):1:66

tagging @shlevy @k0001

This works with the same nixpkgs checkout:
nix-shell -I ~/p/nixpkgs -p haskell.packages.ghc801.ghc

@Ericson2314 any insights?

It worked for me :O

make sure ~/p/nixpkgs exists, and try -I "nixpkgs=..." too

I was trying it on a NixOS machine before. Here it is on my ubuntu-1604 machine, trying @Ericson2314's suggestions:
ryantm@ryantm-1604 ~/p/nixpkgs (master)$ git log -1
commit d82fa7f915cfaa5300763208ac7b4d39afa6f347
Author: Cray Elliott<EMAIL_ADDRESS>Date:   Wed Jul 26 15:36:49 2017 -0700

    wineUnstable: 2.12 -> 2.13
ryantm@ryantm-1604 ~/p/nixpkgs (master)$ nix-shell -I . -p haskell.packages.ghc812.ghc --show-trace
error: while evaluating the attribute ‘buildInputs’ of the derivation ‘shell’ at /nix/store/6w9826g176ja0jkp4q1g03xwyr3qnlw4-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating ‘getOutput’ at /nix/store/6w9826g176ja0jkp4q1g03xwyr3qnlw4-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/lib/attrsets.nix:450:23, called from undefined position:
while evaluating ‘getCrossDrv’ at /nix/store/6w9826g176ja0jkp4q1g03xwyr3qnlw4-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/pkgs/stdenv/generic/default.nix:151:21, called from undefined position:
while evaluating the attribute ‘packages.ghc812.ghc’ at /nix/store/6w9826g176ja0jkp4q1g03xwyr3qnlw4-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/pkgs/top-level/haskell-packages.nix:111:3:
attribute ‘ghc812’ missing, at (string):1:66
ryantm@ryantm-1604 ~/p/nixpkgs (master)$ nix-shell -I "nixpkgs=/home/ryantm/p/nixpkgs" -p haskell.packages.ghc812.ghc --show-trace
error: while evaluating the attribute ‘buildInputs’ of the derivation ‘shell’ at /home/ryantm/p/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating ‘getOutput’ at /home/ryantm/p/nixpkgs/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /home/ryantm/p/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:38:15, called from undefined position:
while evaluating the attribute ‘packages.ghc812.ghc’ at /home/ryantm/p/nixpkgs/pkgs/top-level/haskell-packages.nix:118:3:
attribute ‘ghc812’ missing, at (string):1:66
ryantm@ryantm-1604 ~/p/nixpkgs (master)$ nix-env --version
nix-env (Nix) 1.11.10

I upgraded nix to version 1.11.13, but the problem still exists.

You can't use .; you need an absolute path I think.

To be clear I mean try exactly nix-shell -I "nixpkgs=$pkg" -p haskell.packages.ghc821.ghc --show-trace for best results. I'm sorry this command is so brittle.

That worked. $pkg is an undefined bash variable so it expands to
nix-shell -I "nixpkgs=" -p haskell.packages.ghc821.ghc --show-trace

which works if I am in the ~/p/nixpkgs directory.

@ryantm Oh sorry I mean $PWD, to get the full path of the current directory.

maybe it has to do with what version of nixpkgs I'm actually referencing by mistake.

Yes, it has everything to do with that.
-I appends an entry to NIX_PATH, which is, most orthodoxly, a :-separated list of key=value pairs, where the keys are used in <foo> <bar> <baz>. If there is no value, I guess as you found it defaults to the current working directory. If there is no key there is some back compat logic but it's flaky, as you found.

man nix-instantiate and look for NIX_PATH to see a proper description.


Update doesn't seem to respect cross-versions, tries to resolve snapshot

[x] I've read the CONTRIBUTING guidelines

steps
Have the following build.sbt:
val root = project.in(file(".")).aggregate(a, b)

lazy val a = project.in(file("a")).settings(
  scalaVersion := "2.12.6",
  crossScalaVersions := Seq("2.11.12", "2.12.6")
)

lazy val b = project.in(file("b")).settings(
  scalaVersion := "2.12.6",
  crossScalaVersions := Seq("2.12.6")
).dependsOn(a)

And a project/build.properties using a 1.x version (I've tried 1.1.6 and 1.0.5).
problem
Running sbt update with ++2.11.12 blows up:
update-repro sbt ++2.11.12 update
[info] Loading settings from gpg.sbt ...
[info] Loading global plugins from /Users/travisbrown/.sbt/1.0/plugins
[info] Loading project definition from /Users/travisbrown/tmp/update-repro/project
[info] Loading settings from build.sbt ...
[info] Set current project to root (in build file:/Users/travisbrown/tmp/update-repro/)
[info] Setting Scala version to 2.11.12 on 1 projects.
[info] Excluded 2 projects, run ++ 2.11.12 -v for more details.
[info] Reapplying settings...
[info] Set current project to root (in build file:/Users/travisbrown/tmp/update-repro/)
[info] Updating a...
[info] Updating ...
[info] Done updating.
[info] Updating b...
[info] Done updating.
[warn] 	module not found: a#a_2.12;0.1.0-SNAPSHOT
[warn] ==== local: tried
[warn]   /Users/travisbrown/.ivy2/local/a/a_2.12/0.1.0-SNAPSHOT/ivys/ivy.xml
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/a/a_2.12/0.1.0-SNAPSHOT/a_2.12-0.1.0-SNAPSHOT.pom
[warn] ==== local-preloaded-ivy: tried
[warn]   /Users/travisbrown/.sbt/preloaded/a/a_2.12/0.1.0-SNAPSHOT/ivys/ivy.xml
[warn] ==== local-preloaded: tried
[warn]   file:////Users/travisbrown/.sbt/preloaded/a/a_2.12/0.1.0-SNAPSHOT/a_2.12-0.1.0-SNAPSHOT.pom
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: a#a_2.12;0.1.0-SNAPSHOT: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		a:a_2.12:0.1.0-SNAPSHOT
[warn] 		  +- b:b_2.12:0.1.0-SNAPSHOT
[error] sbt.librarymanagement.ResolveException: unresolved dependency: a#a_2.12;0.1.0-SNAPSHOT: not found
[error] 	at sbt.internal.librarymanagement.IvyActions$.resolveAndRetrieve(IvyActions.scala:334)
[error] 	at sbt.internal.librarymanagement.IvyActions$.$anonfun$updateEither$1(IvyActions.scala:208)
...
[error] (b / update) sbt.librarymanagement.ResolveException: unresolved dependency: a#a_2.12;0.1.0-SNAPSHOT: not found
[error] Total time: 2 s, completed Jun 2, 2018 3:57:46 PM

expectation
update shouldn't try to resolve a snapshot and should just work.
notes
When I asked about this on Gitter, @dwijnand said it looked like a bug. I did a quick search and wasn't able to find it, but there are 749 open issues so ¯_(ツ)_/¯.
sbt version: 1.1.6, 1.0.5.

@travisbrown Thanks for the report! I think we've all ran into something similar where part of the subproject is in one scalaVersion, and the other subproject depending on it still thinks its in 2.12.6, so it blows up. The fact that it's reported now is good, because I already have a proposal for something like this. Check out https://discuss.lightbend.com/t/spatial-representation-of-cross-building/1277/2
Using projectMatrix, we should be able to address this because aJVM2_11 and aJVM2_12 would just be different subprojects.

@eed3si9n I had the same issue when cross building projects for multiple Scala versions: An example build failure: https://travis-ci.org/wvlet/airframe/jobs/392496005

I think this is a duplicate of https://github.com/sbt/sbt/issues/3465
The workaround is:
val root = project.in(file("."))
  .aggregate(a, b)
  .settings(crossScalaVersions := List()) // add this line


Constraint docstring tweaks

While doing a post-hoc review of #152 (sorry about not doing that sooner, @bmorris3), I noticed that a number of the constraint docstrings were in "question-form".  That's not PEP8 compliant, but more importantly, I think it's a bit confusing, because it's not clear that the goal of the function is to answer that question.  So this just re-words those docstrings to be descriptive rather than "question-form".
This also removes a "to do" section that I think @bmorris3 added in #152 - my justification for that is that in my experience "todo's" can live a long time, so it's better to leave them as hints for those perusing the code rather than the documentation... But if there was a particular reason you really wanted that one in there, I can certainly remove that commit.

Looks good.
I'm happy with the TODO move. I am still thinking about whether or not it would be simple to add a switch somewhere in the constraints API to use the trigonometric altitude calculations. I could imagine a user computing observability with trigonometric altitude approximations first for a few iterations, then double-checking their schedule with the "full" or "precise" constraints.


When copying over dynamic bones, values need to be divided by 100

Values for radius of colliders and some other things for some reason need to be divded by 100 in order to be the correct size whenever transfer occurs.

It could be that your armature scale is 100. It was a common issue with older avatars.
I haven't quite figured out how to fix it since scaling up it down also offsets the position of things

Is there any way to fix this without CATS? Can you provide any more information on the cause? Is there something I can look at in blender?

I'm not entirely sure myself. Need to investigate after the next update

after next pumpkin tools update or some other update? unity? blender?

After the next pumkin tools update

apparently exporting with cats fixes the issue

Fixed in next update


hasStyle does not work for CSS variables

The bug
Consider this element:
<div style="--my-var:123" />

The following assertion does not work:
assert.dom('div').hasStyle({ '--my-var': 123 });

Since hasStyle is implemented with getComputedStyle and getComputedStyle returns styles after computations are resolved, variable styles are not present on the CSSDeclaration object.
In order to get the variable styles from an element you must use element.style.getPropertyValue('--my-var').
Motivation to have this behavior
An emerging pattern now that CSS variables have broad adoption is to dynamically set variables in JS/HTML and then read the variables in static CSS.
For instance:
div {
  --my-var: 100; /* default value */
  height: var(--my-var); /* overridable from JS without hardcoding height */
  max-height: var(--my-var); /* implementation detail not the concern of JS */
}

Proposed solution
I think the API for hasStyle can remain unchanged. The keys for the expected object can be divided into variables (start with --) and declarations. Then the two sets can be iterated over using style.getPropertyValue and getComputedStyle respectively.

I came upon this feature request while looking for the same functionality. If this is something wanted in the proposed form I can take a stab at implementing this and opening a PR.

We would love to see support added for this.
An attempt to implement this already exist in #1972. Anything I can do to get this merged?

3.1.0 has been released https://www.npmjs.com/package/qunit-dom/v/3.1.0
See if it works for you

Closing this since we've released the 3.1.0 version, if the issue is still present, feel free to reopen.


Error from server (BadRequest): container "cilium-agent" in pod "cilium-hf7zn" is waiting to start: PodInitializing

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I'm getting an error in all clium agents
Cilium Version
1.15.5
Kernel Version
6.6.30-talos
Kubernetes Version
v1.30.1
Regression
No response
Sysdump
No response
Relevant log output
Error from server (BadRequest): container "cilium-agent" in pod "cilium-hf7zn" is waiting to start: PodInitializing

Anything else?
 Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

That error is just saying that something is stopping that Cilium agent from starting. Cilium requires one cilium-agent per node, along with a cilium-operator deployment. If those pods are not running, then Cilium is not working.
Without more information, we are unable to help. I recommend reading through the Troubleshooting page at https://docs.cilium.io/en/stable/operations/troubleshooting/, particularly the process of collecting a sysdump.
At the very least, we'd need a kubectl describe pod -n kube-system cilium-hf7zn, which will show the reason why the Pod is still Initialising in the Events section.

I managed to deploy the application v1.14.0 Deployed, but v1.15.5 something's wrong.

Thanks for the extra feedback @chanyshev, but without further information, as I suggested above, it will be difficult for anyone to investigate.

I have the same issue on a different setup.
This installation method worked well in the past, now the cilium-operator pods are running, but the cilium-agent pods just hang.
Also @chanyshev workaround didn't work for me (on v1.14.0 the cilium-agent pods  still hang)
Cilium Version
1.16.0, 1.15.7, 1.14.13
OS:
Rocky Linux 9.4
Kernel Version
5.14.0-427.13.1.el9_4.x86_64
Kubernetes Version
v1.30.3
Cilium install method
helm + ipam.mode=kubernetes, k8s.requireIPv4PodCIDR=true

I just solved the issue by using the solution from here -> https://github.com/cilium/cilium/issues/23838
The /opt/cni/bin directory needs to be owned by root. Unbelievable, I wasted so much time reinstalling and testing different versions.

Thanks for that @Ji993. I'm going to close this issue for now, but @chanyshev should feel free to comment with more info and I'll reopen.


Typo in Content (Page Title)

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 700c487a-6048-5ed1-d3b3-f15756f0f953
Version Independent ID: 35502302-bdf4-6a02-11cb-dea21d9fa7ff
Content: Import components into model-driven apps in Microsoft Dataverse - Power Apps
Content Source: powerapps-docs/developer/component-framework/import-custom-controls.md
Service: powerapps
Sub-service: pcf
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

Thanks for contacting us. We have updated the docs and pushed it live. Closing the issue. If you need further help, please reopen or create a new issue.


add ability to set max resolution

Currently, we have hardcoded limit for 11000 data points per query.
I think we should make it configurable. For some cases, we need to limit it to less than 4096, sometimes we need higher resolution more than 11000.
https://github.com/prometheus/prometheus/blob/30af47535d4d7c0a7566df78e63e77515ba26863/web/api/v1/api.go#L202
	// For safety, limit the number of returned points per timeseries.
	// This is sufficient for 60s resolution for a week or 1h resolution for a year.
	if end.Sub(start)/step > 11000 {
		err := errors.New("exceeded maximum resolution of 11,000 points per timeseries. Try decreasing the query resolution (?step=XX)")
		return nil, &apiError{errorBadData, err}
	}

Can you explain in what cases you need more than 11k points, and why you can't handle it in multiple requests?

Hi Brian,
We use Prometheus for system, application and business metrics and provide access for system engineers, developers, QA and even non IT guys.
Since many associate can build dashboards in Grafana it follows that some of them are performing slowly and one of the reason is the non optimal resolution.
In the office I did not find any person who has wider screen than 4096 pixel, but I find many dashboards try to represent few thousands data points in a small graph, what causes unintended overload.
To keep Prometheus responsive we decreased max response time, but we would also like to decreased max resolution as I prefer a die quick approach.

Hi Brian,
I am new to machine learning and monitoring servers and using Prometheus 2.0.0 on ubuntu 16.04 and monitoring stats over a period of time.
My scraping cycle is 1s that means for getting stats overtime for 1 day i need to process 86400 datapoints (24 × 60 × 60) (which is pretty reasonable) i have to call query range api about 8 times as per current limit 11000.
When i start monitoring datapoints for a month (assuming 31 days) value of datapoints jumps to 2678400 datapoints ( (24 × 60 × 60) * 31 ), which as per current limit of 11000 becomes query range api call of about 243 times.
It would be great if this setting could be introduced for user to decide how much datapoints they need at a time.

*Assuming this setting will be added in future, doing this might take time ... Can you please guide me on how and where can i change this on my Ubuntu source code ? As it only shows me binary code which is not human readable.

You probably want the query endpoint there to get raw data, not query range which is evaluating promql.
That sort of massive query is why we have this limit :)

Thanks for a quick reply!!
True, datapoints for a month will result in a very big data set ... How can i achieve query endpoint for raw data ? Can you share a tutorial or a guide ?

Brian, this query provides data for a single instance in time (current or at a single point), not a solution to what i am looking for, i am evaluating data for a month ... Let me explain -
Lets say i want to check how many times my server was down over a month (i.e up == 0). Now if i use instant queries it will give me record of a single instance in time that means for a month i will end up fetching data from 2678400 api calls. Query range however provides data for 11000 datapoints at once only.
I have build a code in NodeJS (which at my end is very much optimized) that divides 2 dates ranges into intervals as per maximum limit (which in this case is 11000) and make api calls to fetch data.
When i process data for a month i hit api call 243 times (asynchronous parallel calls using async module) which is taking overall time 70 - 80 seconds to fetch data for a month (for a single instance i am monitoring 24*7).
Now if the query was to status code of my application 200, 400 etc.. This single api time increases to 3 to 5 seconds which makes overall process exceed limit.
So i can now see 2 ways to get faster results for getting data for a month -

Limit of 11000 datapoints is increased at Prometheus end.
I create my own data parser on location Prometheus is storing its datapoints.

Considering option 2 : As i have not looked at source code of Prometheus it will be a little tricky for me to perform this in a short time frame. If i can get a guide on how your query engine works / stores datapoints i might end up creating / enhancing my own logic in it or externally.
Considering option 1 : If increasing datapoint limit at Prometheus end is not that of a big deal in terms of performance, as it's query engine must be very much optimized by you guys ... I would like to know how can i do that in Ubuntu 16.04 setup of Prometheus or change in source code and build a new setup from current updated source.
Please let me know which option would you suggest. Thanks in advance!!!

@Daemon-Knoppix Append the time range to the end of the query string. Ex: http://localhost:9090/api/v1/query?query=up[10h]&time=1511347941.586
Also, please ask further queries like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

I don't think limit 11k is a good idea especially that I'm trying to get all data points for machine learning by http api, so can you tell me how can I do this? Like this issue's title, I think that's necessary. That's unecessary for UI but not http api.

I'm also running into this problem. While I can split the queries up and then recombine the data, it seems like pointless extra work. I'm getting data on each node of a 60 node cluster with start/step/end set to give 1000 time steps. Each node with have its own line on the graph, so I don't want to lower the resolution based on the number of nodes to sample. I also plan to run the same queries on larger clusters in the future, so the downsampling required to achieve only 11k samples would increase.
Why is the 11k limit needed? Considering I have a script gathering the data, I don't mind waiting a significant period of time for the query to complete. Making this configurable (with the existing 11k limit as the default) would make my work easier without harming the default use-case.

After 4 years noone has presented a use case for graphing with more than this many steps. On the other hand we have more protections for PromQL memory these days - but part of their implementation tradeoffs includes that this limit is in here. Given all that this limit seems appropriate. If people start getting wider monitors that require a higher limit we can bump this, but there doesn't seem to be a need to make it configurable so I'm going to close this off.

I am also looking for an option to configure and change the maximum resolution limit.
Let me just comment some of your points, @brian-brazil :

Can you explain in what cases you need more than 11k points, and why you can't handle it in multiple requests?

One example: You want to make an experiment with a long execution time and a short resolution. At the end, all collected data points should be exported. There are still cases where it isn't possible to time and export every X days. Even if it's possible, it yields to much more work to connect the results of the multiple requests.
Another example: If you have got one machine and you want to make scientific experiments on it, you don't want to start and query an export in the middle of the experiment. This could lead to some adulterations of the results caused by the request in the middle of the experiment.

Given all that this limit seems appropriate. If people start getting wider monitors that require a higher limit we can bump this, but there doesn't seem to be a need to make it configurable so I'm going to close this off.

Currently, there are 10 thumps up for this issue. This means that there is already interest in the implementation and that use cases exists.
Just remember: No one wants to increase the default limit for all prometheus projects to an extremely high value. People want to have an option to increase or decrease the value without building the whole project from source. The default value of 11000 might be okay for 99 % of the users. But to give the other small amount of users the ability to satisfy their use cases, a config option would be great.

This is a very advanced move that is in almost every case a mistake and the default limit of 11000 on query_range should not be configurable.
Advanced users can use [] selectors in the query endpoint (not query_range) if they want to extract more data. You can do: metric[1w] (to get raw data) or rate(foo[5m])[1w:1h] (to get eval every 1h for 1 week) using the instant query endpoint. This is not something we want to document or advertise, but if you really want to use this workaround, it might work for you.


Text Improvements

There's a couple issues with text that would be nice to resolve:

Text should have the ability to be two-sided; it would be nice to duplicate the geometry on both sides so the text can be read regardless of its rotation (with(two_sided()) or similar).
It would be really nice to be able to center the generated mesh so that text is aligned correctly to the object that it's following. Might be nice to implement this via a helper (centered_text("Centered")) and a component with(alignment(), TextAlignment::Center).

Considering that the existing text is mostly intended for use with UI; I suspect it's unlikely I'll get both of these for the time being so I'll bodge it using width() + duplicating the entity for now.

I would like this for Flowerpot so I'm bumping this.


disable ShareDeleteRetentionPolicy for standard file share doe not work

Bug Report

import path of package in question: services/storage/mgmt/2021-09-01/storage
SDK version: v67.0.0

Specify the exact commit if possible; one way to get this is the REVISION
column output by dep status "github.com/Azure/azure-sdk-for-go.

output of go version

go version go1.18.3 linux/amd64

What happened?

We are trying to use go sdk to disable ShareDeleteRetentionPolicy for standard file share. The following code only works with premium file share, while it does not work with standard file share:
Error is like this:
storage.FileServicesClient#SetServiceProperties: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidXmlDocument" Message="XML specified is not syntactically valid.\nRequestId:34a1905c-a01a-0076-4534-daa16d000000\nTime:2022-10-07T10:06:15.7468662Z"

Go code snippet to disable ShareDeleteRetentionPolicy

            prop, err := az.FileClient.GetServiceProperties(resourceGroup, accountName)
            if err != nil {
                return "", "", err
            }
            if prop.FileServicePropertiesProperties == nil {
                return "", "", fmt.Errorf("FileServicePropertiesProperties of account(%s), resource group(%s) is nil", accountName, resourceGroup)
            }
            prop.FileServicePropertiesProperties.ShareDeleteRetentionPolicy = &storage.DeleteRetentionPolicy{Enabled: to.BoolPtr(false)}
            if _, err := az.FileClient.SetServiceProperties(resourceGroup, accountName, prop); err != nil {
                return "", "", err
            }

following workaround works
by setting

			prop.FileServicePropertiesProperties.ProtocolSettings = nil
			prop.FileServicePropertiesProperties.Cors = nil

			prop, err := az.FileClient.WithSubscriptionID(subsID).GetServiceProperties(ctx, resourceGroup, accountName)
			if err != nil {
				return "", "", err
			}
			if prop.FileServicePropertiesProperties == nil {
				return "", "", fmt.Errorf("FileServicePropertiesProperties of account(%s), subscription(%s), resource group(%s) is nil", accountName, subsID, resourceGroup)
			}
			prop.FileServicePropertiesProperties.ProtocolSettings = nil
			prop.FileServicePropertiesProperties.Cors = nil
			if accountOptions.DisableFileServiceDeleteRetentionPolicy {
				klog.V(2).Infof("disable FileServiceDeleteRetentionPolicy on account(%s), subscription(%s), resource group(%s)", accountName, subsID, resourceGroup)
				prop.FileServicePropertiesProperties.ShareDeleteRetentionPolicy = &storage.DeleteRetentionPolicy{Enabled: to.BoolPtr(false)}
			}

Root cause

It's due to an improper translation of an absent property between the call from the sdk to the srp layer and then srp making the call with that incorrect xml to the data plane.

As a workaround, try setting “multichannel”  property when you disable “ShareDeleteRetentionPolicy” using Go SDK.  Check if it is null or not present, then add it is “false” into the request.
You can also try removing “multichannel”  property from the request.
Alternatively, you can also skip sending the whole “protocolSettings” element if those settings are not being updated.
The problem is with translation from JSON to XML at SRP side.  “Enabled” is a nullable bool in SRP data schema, so  instead of skipping it, it is translated into    <Multichannel><Enabled d5p1:nil="true" xmlns:d5p1=[http://www.w3.org/2001/XMLSchema-instance](https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.w3.org%2F2001%2FXMLSchema-instance&data=05%7C01%7Cxiazhang%40microsoft.com%7Cd5658f19080546a83c8d08daad6132d0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638012930360410511%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=930n1QKTJlRRORgPM5mUUs8RFNKqAiv8bvC4pxKaEDs%3D&reserved=0) /></Multichannel> by default.
<Multichannel> can be absent in the request, but if it is present, DataPlane only expects that it must be either “true” or “false”, so request from SRP to DataPlane fails.

Works:

{
  "protocolSettings": {
    "smb": {
      "multichannel": {
        "enabled": false
      },
      "versions": null,
      "authenticationMethods": null,
      "kerberosTicketEncryption": null,
      "channelEncryption": null
    }
  },
  "cors": {
    "corsRules": []
  },
  "shareDeleteRetentionPolicy": {
    "enabled": false
  }
}

Fails:

{
  "protocolSettings": {
    "smb": {
      "multichannel": null,
      "versions": null,
      "authenticationMethods": null,
      "kerberosTicketEncryption": null,
      "channelEncryption": null
    }
  },
  "cors": {
    "corsRules": []
  },
  "shareDeleteRetentionPolicy": {
    "enabled": false
  }
}

Also works:

{
  "properties": {
    "shareDeleteRetentionPolicy": {
      "enabled":false
    }
  },
  "cors": {
    "corsRules": []
  }
}

What did you expect or want to happen?

disable ShareDeleteRetentionPolicy for standard file share works

How can we reproduce it?
Anything we should know about your environment.

It should be a service problem. When calling GetServiceProperties, the response does return an empty smb without any default value. When doing update, we have no context how to handle the property not going to change and SDK will marshal them as it received.
{"sku":{"name":"Standard_RAGRS","tier":"Standard"},"id":"/subscriptions/subid/resourceGroups/chenjieshitest/providers/Microsoft.Storage/storageAccounts/chenjieshistorage/fileServices/default","name":"default","type":"Microsoft.Storage/storageAccounts/fileServices","properties":{"protocolSettings":{"smb":{}},"cors":{"corsRules":[]},"shareDeleteRetentionPolicy":{"enabled":true,"days":7}}}

Non customer-reported issue.
@xgithubtriage Could you please look into this once you get a chance ?

We have retired support for Azure SDK for Golang libraries which do not conform to our current Azure SDK guidelines (see announcement). Please migrate to the latest version according to the migration guide. If you could still repo this problem, please submit a support ticket in Azure directly.


Make settings customizable

Hey,
I have my poetry project in a subdirectory in the git repository. Running poetry run githooks setup fails with This is not a Git repository. Run 'git init' first. It would be nice to have the ability to overwrite GIT_DIR in settings in such cases.

Hej, good idea. Would you be interested in doing a PR?

If you have some general guidelines on how to implement this then yeah, sure. Simply reading from environment variables with a fallback to current implementation sounds ok?

yes, that sounds perfect


Change voice dynamically

It is need to be able to change the voice (e.g., "anna", "aleksandr", etc.) as option when generating each individual message.

https://github.com/definitio/ha-rhvoice/releases/tag/1.3


Bring external markdown files into this repo (as html)

Previously at build various mardown files were pulled in from different github repos, converted from markdown to html and used to generate the site.
This is a nice feature but it's making client side rendering a bit more difficult to implement.
I've left ./lib/markdown.js in place as in theory it can be used on the client and server. I'd like to bring back the markdown step at some point but want to get the client side rendering nailed first.
fixes #112

Once this is merged Im going to replace the following markdown files with a link to the appropriate page on the website:
/lnug/speakers/master/README.md
/lnug/resources/master/sponsors.md
/lnug/feedback/master/ORGANISERS.md
/lnug/related-meetups/master/README.md


Extend layout placeholder params for filesystem destinations

This PR addresses https://github.com/dlt-hub/dlt/issues/930
Requirements:

[x] Make sure you can place something after the extension,
Should be able to pass custom placeholders dictionary to fs and merge w/ existing placeholders,

[ ] if placeholder is not known then show a warning and skip,
[x] add validation for placeholders if they are defined with user friendly messages,
[x] support custom current date formatting placeholders (interpolation options on top of pendulum or ISO standard)

[x] Placeholders in dictionary can be values or callbacks,
[x] Make configurable via config toml,
[x] We would like to have overridable current date to filesystem arguments

@sh-rp recommends to test with staging destination
you’ll have to test it, write a test where you run the destination settings that use staging and add a map function for the filename
TODO

[ ] Tests,
[ ] Docs update

Closing this in favor of https://github.com/dlt-hub/dlt/pull/1182


Convert empty values

@murtyjones This has been published to v1.1.1

@mckalexee cheers mate. now get back to vacation!

@mckalexee cheers mate. now get back to vacation!

I'm on vacation! This isn't a work thing. This is our open source project.


Created login/user registration interface

Finally got everything working and should be ready to be deployed, I am very tired so apologies if any code or comments make no sense. But a person can create a simple account with their name, email, username, and password, then log in with their username and password as you would expect. Please provide all the feedback you can, the styling and stuff like the timeout after pressing a button can be modified as we decide.

So I went in and resolved all the merge conflicts and then realized that a person reviewing has to do that, if anyone wants to hop on a call and go through each conflict, I can help with resolving them.


Expansion I/O mechanically interferes with SDCARD/MIPI jacks

I want to make a shield like PCB for the side expansion I/O. Unfortunately the pins would interfere with the SDCARD/MIPI jacks.
I don't care so much about the MIPI jack, but I imagine I'll be inserting/removing the SDCARD a bunch. Unfortunately the 3 pins that interfere on the SD side are I2C. I'd like to use those guys for sensor integration.
In V2 (if you keep the 0.1" I/O), slide the headers down a little so this interference is avoided.

This is what I want to do with the expansion:

Or maybe

Here's what I ended up with mechanically to work around this:

Here's the populated board running on the beepberry.
IMU, BARO, MAG, GPS, buzzer


fix broken link from Path Clarity to Macro Changes

Thanks! The lack of absolute paths makes me unhappy :(

Insert joke about uniform paths here.
On Wed, Aug 15, 2018 at 11:43 PM Mazdak Farrokhzad<EMAIL_ADDRESS>wrote:

Merged #94 https://github.com/rust-lang-nursery/edition-guide/pull/94
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/edition-guide/pull/94#event-1791448024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC3nzgLMBor-E5ZcqC6OByR9Kox6uBxks5uROpNgaJpZM4V_JDh
.


Failed to load resources

I also used https://www.jsdelivr.com/unpkg but it also says error:

It is down from many days I guess

Yep, it really is down

but why jsdelivr is also not working?

jsDelivr is working, the issue is not the CDN but the code you're loading. Check the error

How can I fix it ?

unpkg working now


Customisation not working when using combobox form helper

Describe the bug
Hi, first of all I want to say a big thanks a lot for all the effort and your work on this gem.
I have started using the gem with mostly async comboboxes. I am using the new feature that enables us to customise the attributes we pass on the components of the combobox. Everything works great when I use the combobox_tag helper. But when I use the form helper (i.e f.combobox) the customization block is being ignored. I believe that a possible fix may be to pass a block on the form helper too.
https://github.com/josefarias/hotwire_combobox/blob/366bbfc60e2b2ad28429d135705a7dfa0e384c53/lib/hotwire_combobox/engine.rb#L12
There the args and kwargs are forwarded to the hw_combobox_tag helper. Maybe if we also capture and pass a block it will work in the same way.
Here is how I use it and the result.
    <%= combobox_tag :name, autocomplete_proposals_path, placeholder: "Choose title", name_when_new: "proposal[name]" do |combobox| %>
      <% combobox.customize_input class: "w-full rounded-md border border-gray-300 bg-white py-2 pl-3 pr-12 shadow-sm focus:border-indigo-500 focus:outline-none focus:ring-1 focus:ring-indigo-500 sm:text-sm", data: {customized_input: ""} %>
      <% combobox.customize_main_wrapper class: "!w-full mt-1" %>
      <% combobox.customize_listbox class: "mt-1" %>
    <% end %>

    <%= f.combobox :client_id, organizations_path, value: f.object.client_id, placeholder: "Choose organization" do |combobox| %>
      <% combobox.customize_input class: "w-full rounded-md border border-gray-300 bg-white py-2 pl-3 pr-12 shadow-sm focus:border-indigo-500 focus:outline-none focus:ring-1 focus:ring-indigo-500 sm:text-sm", data: {customized_input: ""} %>
      <% combobox.customize_main_wrapper class: "!w-full mt-1" %>
      <% combobox.customize_listbox class: "mt-1" %>
    <% end %>

I can provide a dummy app if you need more information to reproduce the issue.
Also another question/sidenote can we also customize the wrapper of an option in a similar way? I followed the original discussion about the customisation but I couldn't find a way to pass some attributes to it (classes or data attributes to the rendered options).

@thanosbellos great catch! Thanks!
Form support added in https://github.com/josefarias/hotwire_combobox/pull/105, please point your gem to main until the next release to get it. Although that release should happen soon anyway.
Re: customizing options, I'm not sure how to implement that in a straightforward way since options can be loaded inline or asynchronously. It's possible, of course. But it's important to me that the code be simple.
One thing you could to is use :render_in to render the options. That way you're free to include any markup you like in the option – albeit not in the wrapping <li>. Would that work for you?
Thanks!

Hi and sorry for the late reply.
Everything works greatly now using the form helper. Thanks a lot for the immediate fix!!
About the render_in:
I already use that to customize the view. That is great. The need to pass some custom class to the li that wraps the custom content comes from using tailwindcss. I wanted to add a group class (that unfortunately cannot be done using apply) in order to do some styling based on whether the li has a group class and aria-selected attribute using tailwind modifiers, i.e show a checkmark.
Tbf if i just had some way to have access to whether the list item is selected inside the custom view that i use in the render_in, i could make it work. Maybe that information would come handy in general as well.
Anyway i totally understand that this use case may be too much to ask  and tbf the restrictions i have are mostly due to using only tailwind modifiers. I will find a way by writing some plain old css :)
Thanks a lot for your time and your efforts!!


Missing make

We recently upgraded to Meteor 1.7 and now this image is failing to run our bundle: https://unee-t-media.s3-accelerate.amazonaws.com/frontend/commit/15be07e.tar.gz
Tbh I assumed that a bundle was ready to go, so I was surprised to see npm at work in the logs... and failing.
Checking Meteor version...
Installing NPM prerequisites...
><EMAIL_ADDRESS>install /home/meteor/www/bundle/programs/server/node_modules/fibers
> node build.js || nodejs build.js
gyp ERR! build error
gyp ERR! stack Error: not found: make
gyp ERR! stack at getNotFoundError (/usr/lib/node_modules/npm/node_modules/which/which.js:14:12)
gyp ERR! stack at F (/usr/lib/node_modules/npm/node_modules/which/which.js:69:19)
gyp ERR! stack at E (/usr/lib/node_modules/npm/node_modules/which/which.js:81:29)
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/which/which.js:90:16
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/which/node_modules/isexe/index.js:44:5
gyp ERR! stack at /usr/lib/node_modules/npm/node_modules/which/node_modules/isexe/access.js:8:5
gyp ERR! stack at FSReqWrap.oncomplete (fs.js:82:15)
gyp ERR! System Linux 4.14.51-60.38.amzn1.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /home/meteor/www/bundle/programs/server/node_modules/fibers
gyp ERR! node -v v4.8.6
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
node-gyp exited with code: 1

So what's the path forward here? Add build-essential to https://github.com/CyCoreSystems/docker-meteor/blob/master/Dockerfile ?

There is a :build tag which contains build-essential.    If there is something new with 1.7 which requires it, I can add it back in; it's just a pretty large addition.

Thanks, ulexus/meteor:build gets further, but then chokes with:
Starting Meteor Application...
/home/meteor/www/bundle/programs/server/boot.js:49
    const { pause } = require("./debug.js");
          ^
SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/meteor/www/bundle/main.js:4:1)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)

I think it's something to do with nodejs binary is running the app. Why don't you use meteor run here?
https://github.com/CyCoreSystems/docker-meteor/blob/master/entrypoint.sh#L200


Working Branch investigation possible upstream changes

This branch is a workspace for testing out a change that requires upstream modification that allow access to non-encoded values of rho and the ntt vector. This allows us to encode those values ourselves without manually decoding, and re-encoding, the values ourselves when working with the ml_kem library.
Also adds some tests that ensure both methods would work

The real result of this branch is that using a direct method is not worth it for now. It makes the most sense to just do the transcoding through the FIPS representation which makes this more flexible wrt. mlkem libraries.
It is not worth it for performance / complexity trade-off  to get access to the direct byte representation of the NTTVector by trying to use some unsafe transmute unholiness or modifying the upstream library.
This all goes back to the original reason this is a separate crate in the first place, 1) interoperability, potentially beyond the ml_kem crate, and 2) hybrid_array doesn't support weird custom lengths --- none of our kemeleon encoded key sizes were supported.

I am considering this branch as complete so that I can start breaking off smaller individual features rather than making broad pushes like this. Also, the EncapsulationKey encode/decode seems to be complete.


ehance ui of signup sign in page  background

Is your feature request related to a problem? Please describe.
The current UI of the signup and sign-in pages feels outdated and lacks modern design principles. Users find it frustrating as the forms are too basic, not responsive, and don’t provide a smooth, visually appealing experience. The user journey can feel unengaging and may lead to drop-offs during the signup or login process.
Describe the solution you'd like
want to make background slighly fade or blur

like this background become lightly fade
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@ANSHIKA-26 please review and assign this to me


nexe errors when run

I can't get my application to work with nexe, so tried 'express-test' that was installed with nexe.  I copied the 'express-test' folder into my 'home' directory and ran nexe.  I got the following error:
$ cd express-test
$ nexe -i ./index.js
....> ERROR: option nodeConfigureArgs was empty

If I 'cd' into my project's directory and run nexe, I get this:
pm@T110:~/Projects/express/twTest$ ls
app.js  node_modules  package.json  public
pm@T110:~/Projects/express/twTest$ nexe -i ./app.js -o/ttt -v 4.2.2
1.0.3

nexe just comes back with '1.0.3', but no file is generated.  Running on Ubuntu 14.04

Hi, same here
nexe -i webServer.js -o webServer.bin -r 4.2.1
....> ERROR: option nodeConfigureArgs was empty
I get the same error with
var nexe = require('/usr/local/lib/node_modules/nexe');
nexe.compile({
input: 'webServer.js',
output: '/home/pi/myProject/bin',
nodeVersion: '4.2.1',
nodeTempDir: '/home/pi/myProject/tmp',
python: '/usr/lib/python2.7',
flags: true,
framework: "nodejs"
}, function(err) {
console.log(err);
});

if you add the following key to the compile options, it seems to work:
nexe.compile({
...
nodeConfigureArgs: [],
nodeMakeArgs: []
}, ...

Yes. Its a mistake of making them required
On Sun, Jan 24, 2016 at 2:01 AM, ftwang <<EMAIL_ADDRESS><EMAIL_ADDRESS>> wrote:
if you add the following key to the compile options, it seems to work:
nexe.compile({
...
nodeConfigureArgs: [],
nodeMakeArgs: []
}, ...
—
Reply to this email directly or view it on GitHub
[https://github.com/jaredallard/nexe/issues/163#issuecomment-174274354] .[https://github.com/notifications/beacon/ACR9NcUCg4kb0wP6yShM7wf6tqe0dC3Kks5pdJiBgaJpZM4HKywG.gif]

Fixed in 1.0.4 :)


Add ktor descriptor

Closed by @ark-1 in https://github.com/Kotlin/kotlin-jupyter-libraries/commit/a3b7059bcb5b02f80067ac2fcc7c3ac12a771f23


Run apt::update before installing package

https://github.com/gds-operations/puppet-aptly/issues/48

every time I ran Puppet for the 1st time, it fails to install aptly

This is because apt::source schedules apt::update to happen at the end of the Puppet run, but by that time we've already attempted to install the package.
This commit introduces a dependency between apt::update and the package resource.

Looks fine. Merge away.

Hello! Do you guys have any idea when the next release including the fix for https://github.com/gds-operations/puppet-aptly/issues/48 will be available? Thanks!

@roccatgaming: Sorry for the delay! We've just released this 0.6.0.


Test system with more than 1 custom launch phases

System behaviour should be tested with more than one custom launch phase.

Domain create is missing phase name to select more than 1 type. Take from New Application. Still testing is needed after that.


xarray and GeoTiffDataset

Description

Added GeoTiffDataset to read and write geotiff files with rioxarray and work with xarray in kedro. This is also related to issue #165

Development notes
Added kedro_datasets/xarray/geotiff_dataset.py and a very basic framework for testing in /kedro-datasets/tests/xarray/test_geotiff_dataset.py using a sample file from rioxarray. I could not run the test suit locally or on github due to the complex environment. So more tests are certainly needed.
I think it would also be easy to make a preview method.
Checklist

[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[x] Updated the documentation to reflect the code changes
[x] Added a description of this change in the relevant RELEASE.md file
[x] Added tests to cover my changes

Thanks @tgoelles for this pull request 🚀

I could not run the test suit locally or on github due to the complex environment.

What instructions did you follow? Would love to understand how can we make the process easier. It's definitely a challenge to install all the dependencies of all datasets, but we could try to make running the tests of only 1 dataset easier.

Thanks @tgoelles for this pull request 🚀

I could not run the test suit locally or on github due to the complex environment.

What instructions did you follow? Would love to understand how can we make the process easier. It's definitely a challenge to install all the dependencies of all datasets, but we could try to make running the tests of only 1 dataset easier.

I did not follow any instruction. Is there one? Yes It would be great to just test one dataset and not on windows at the moment with the github actions. VS code debugging does not work for some reason: discovery error. Also if I want to run it in the terminal I get this:
"no tests ran" even when I runnning yaml for example

A basic test suite now works. There I need help, but the basic functionality works and  I guess the rest can be added by someone who knows kedro better

I did not follow any instruction. Is there one? Yes It would be great to just test one dataset and not on windows at the moment with the github actions. VS code debugging does not work for some reason: discovery error. Also if I want to run it in the terminal I get this:

After you commented this I realized that this plugin didn't have a dedicated CONTRIBUTING.md (https://github.com/kedro-org/kedro-plugins/issues/364) and that's fixed now: https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/CONTRIBUTING.md#unit-tests-100-coverage-pytest-pytest-cov
This however runs all the tests. You can try pytest -k xarray to only run those related to xarray. Let me know if that helps.

Just one broad question: are there any parts of this dataset that are GeoTIFF-specific, and that prevent it to work on generic n-dimensional labeled arrays from xarray?

It uses rioxarray to handle GeoTiffs: https://corteva.github.io/rioxarray/stable/getting_started/getting_started.html

Hello @tgoelles! We'd love to get this PR in. How can we help?

Hello @tgoelles! We'd love to get this PR in. How can we help?

I am currently super busy with other things. But I think its ready and someone needs to see that all the checks are Ok. I might have time in 2 weeks again for this.

I've resolved the merge conflicts for this PR and done some small cleanups, but there's still more things to do:

The doctest is failing for the example provided in GeoTiffDataset. This is the python example inside the docstring.
Test coverage is not at 100% for GeoTiffDataset:

Name                                                         Stmts   Miss  Cover   Missing
------------------------------------------------------------------------------------------
kedro_datasets/xarray/geotiff_dataset.py     42      6    86%   100, 103, 117-118, 132-133

@tgoelles Can you finish this or do you want someone to take over?

I've been doing some small bits fixing the doc string and added some missing tests, but while doing this I also realised I'm probably not the right person to finish the implementation. I'm not familiar at all with GeoTiff and its purpose. I noticed the dataset as it stands now doesn't have the credentials argument and is maybe missing some other bits when I compare it to e.g. NetCDFDataset that was merged yesterday.
Either someone with more knowledge about this data type should finish this PR or we can take this as our first "experimental" contribution (see #517) and get it in that way. WDYT @astrojuanlu?

Hello! just a note: I think the name GeoTiffDataset is a bit misleading because rioxarray wraps rastertio.open() which can open any kind of raster dataset. It can open any format supported by gdal raster drivers.  So maybe something in the line of RasterDataset would be more strict and avoid possible confusions.

Hi @tgoelles, I'm aware that this PR has been open for quite a while and has had a lot of comments. I'm not sure the Kedro team can help at this point to get the dataset to a full ready state. However, we're about to launch our new experimental dataset contribution model, which basically means you can contribute datasets that are more experimental and don't have to have full test coverage etc here https://github.com/kedro-org/kedro-plugins/tree/main/kedro-datasets/kedro_datasets_experimental.
I think the GeoTiffDataset might be a good candidate to get contributed in that way. What do you think?

I think the GeoTiffDataset might be a good candidate to get contributed in that way. What do you think?

Yes I think that would be a possible way. Also as @BielStela pointed out it is for geospatial raster data. So there is also an overlap with the already now existing netcdf format.
I could be like this. RasterDataset  => rioxarray.
Then we could also think about enforcing that a coordinate reference system (CRS) is used. Or at least make an option for this. Also this needs to work well together with other geospatial datasets like netcdf and geopandas.
Yes this needs more experimenting, but it would introduce a huge list of new file formats which can be used.
Will you move it to the experimental folder? I could then rework it with the new concept of dealing with raster data in general and not just GeoTiff. I also gained a lot of experience working with these kind of data recently.

@tgoelles I've moved it! There's some issues with the docs, which I'll continue to fix, but you should be able to work on the code 🙂

Hello! just a note: I think the name GeoTiffDataset is a bit misleading because rioxarray wraps rastertio.open() which can open any kind of raster dataset. It can open any format supported by gdal raster drivers. So maybe something in the line of RasterDataset would be more strict and avoid possible confusions.

GeoRasterDataset? 😇
(I'm looking forward to seeing this merged by the way!)

@tgoelles I've moved it! There's some issues with the docs, which I'll continue to fix, but you should be able to work on the code 🙂

All docs issues are now resolved as well.

Rendered version: https://kedro--355.org.readthedocs.build/projects/kedro-datasets/en/355/api/kedro_datasets_experimental.xarray.GeoTiffDataset.html

I renamed everything to get startet. I think rioxarray.RasterDataset makes sense. This indicates what library is actually used and that it is raster data. GeoRasterDataset would be too much IMO because rioxarray implies that it is geospatial data and the geoscience community knows what raster data is.
Now the tests of the experimental datasets do not run in the github action. Also for the tests we need the same conftest.py as from the "normal" datasets. I guess you need a strategy for that. Locally the existing tests run on my macbook if I make a symlink to the conftest.py.
Maybe have the experimental dataset tests in the same tests folder as the other ones?

Now the tests of the experimental datasets do not run in the github action.

Yes this is on purpose, because we don't require experimental datasets to have tests to make it easier to contribute. Additionally, ensuring all tests pass and unblocking builds is quite a heavy burden for the maintenance team. For the "regular" datasets like CSVDataset debugging isn't too hard, but more niche datasets like this one can be hard for us to fix when broken. If a dataset gets a lot of traction and the Kedro TSC feels like we can start maintaining it fully, tests will become mandatory.

@tgoelles Feel free to address the conflicts of the release notes, signoff any remaining commits for the DCO check to pass, and we'll be happy to merge soon :)

I decided to name it now GeotiffDataset again. This way it would be possible to have different datasets in the future based on rioxarray similar to pandas. It can only read and write geotiffs currently, because it would have been a nightmare to support everything gdal can read and write. Also I enforced the use of a coordinate reference system.
The versioning and S3 stuff might be quite straight forward to implement now. I need to test it a bit more on my current project and might implement that soonish.

I decided to name it now GeotiffDataset again. This way it would be possible to have different datasets in the future based on rioxarray similar to pandas. It can only read and write geotiffs currently, because it would have been a nightmare to support everything gdal can read and write. Also I enforced the use of a coordinate reference system.

Fair enough!

The versioning and S3 stuff might be quite straight forward to implement now. I need to test it a bit more on my current project and might implement that soonish.

Do you want to do it in this PR, or should we review what's in here already?

Do you want to do it in this PR, or should we review what's in here already?

Please review what is there. Then I want to test it a bit further in real world code and then make a new PR and it could then be in the official datasets maybe.

Liberally re-requesting a review from @RobertoPalomares and @riley-brady if you have the time 🙏🏼

I don't know why this pandas check failed. it is the same code as in the main branch. I tried to solve the DCO, following the instructions of it with git rebase HEAD~228 --signoff, but this than leads to a huge amount of conflicts. there must be an easier way out of this. Also I am afraid to make mistakes there.

I tried to solve the DCO, following the instructions of it with git rebase HEAD~228 --signoff, but this than leads to a huge amount of conflicts. there must be an easier way out of this. Also I am afraid to make mistakes there.

You're not the first one...
I see maintainers are allowed to push to this branch, so I'll try to get you some help from the team.

CI failure is unrelated https://github.com/kedro-org/kedro-plugins/issues/740#issuecomment-2207612753

This is merged :shipit: thanks again everyone for your patience!


Code Inspection: npm audit on trees

marked:>=0.3.14 <0.6.2

(warn) Regular Expression Denial of Service Upgrade to version 0.6.2 or later.

marked:0.4.0:

typedoc>marked

[atomist:code-inspection:trees=@atomist/atomist-sdm]

Issue closed because branch trees was deleted.

Issue closed because branch trees was deleted.


PhantomJS2

does the phantomjs2 branch run? I am trying to run it and getting numerous issues. I was hoping it's just my machine acting up, but I don't know if that's the case.

Yes it runs just fine. What issues are you having?

While researching the 'EventConstructor is not a constructor' issue, I found the phantomjs2 branch. I grabbed it and tried to run npm install on Ubuntu 14.04. The installation failed with the messages show below. I realize this is technically a PhantomJS v2 issue, but do you have any suggestions on how to proceed? Thanks!
npm ERR! Linux 3.13.0-58-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node install.js'.
npm ERR! This is most likely a problem with the phantomjs package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls phantomjs
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/dan/projects/prerender-phantomjs2/npm-debug.log

I also have a problem with running the PhantomJS2 branch.
I noticed the node_modules/phantomjs/bin/ exec is showing as 1kb once you run npm install. If I download the binary from http://phantomjs.org/ it shows as 14.6mb. Is this right?

@dstringvc you have to compile your own PhantomJS 2 if that's what you plan on using until the official builds are released. What error were you seeing before with PhantomJS 1.9.8?
@thedistricts Did you compile PhantomJS2 yourself to get the 1kb binary? Or where are you getting that binary from?

Hi - No, the 1kb binary was just through running npm install. I'm I missing a step? Do I need to compile my own binary? I figured your phantom wrapper was there to download a local version to the node_module folder.

I've also forced it to download a new phantomjs 2 binary by deleting the 'var/folders/l0/24m7ff7x62z8yb09rph6fsbh0000gn/T/phantomjs/phantomjs-2.0.0-macosx.zip', running npm cache clean and deleting the node_modules folder. Same behaviour phantom crashes straight after running node server.js and the phantomjs binary is 1kb

Hmm, my local executable is 1kb so that seems correct.
Also, I'm not sure if our phantomjs2 branch works with the currently deployed version of phantomjsn2 by the phantomjs team. I know they were having some issues with builds on linux and that's why we compiled our own. So, right now, the phantomjs2 branch only supports compiling phantomjs 2 yourself

@thoop With PhantomJS 1.9.8, I was getting the error shown here:
TypeError: '[object EventConstructor]' is not a constructor (evaluating 'new Event('fb.load')')
Here is the code that caused the error:
$window.dispatchEvent(new Event('fb.load'));
While researching that error, I stumbled across the PrerenderIO phantom2 branch. Trying to install that branch by cloning the repo then running "npm install ...", I got the errors noted in my original post.
In the mean time, our Angular developer replaced the original code with:
$window.dispatchEvent(new CustomEvent('fb.load'));
I'm not getting the error any more so upgrading to PhantomJS v2 isn't such a high priority.

Ah ok great! Glad it's working. PhantomJS 1.9.8 is on an older version of webkit so it might run into issues with certain JS.

For anyone who wants to use the phantomjs2 branch (which my team has found is far more stable than using phantomjs1) but avoid the compilation required, I suggest using a fork of the npm phantomjs downloader.  The reason that @thoop's phantomjs fork works if you compile a phantomjs2 binary first is that it checks to see if phantomjs 2 is installed, and if it is then it skips the download.  IMO a better approach (although still a hacky one) is to have a fork of npm phantomjs that actually does downloading on your target systems.
Here is the fork of prerender that my team is planning on using in production: https://github.com/Lochlan/prerender
The only difference is that I'm using my own fork of npm phantomjs, in package.json, that does successfully download on Ubuntu 14.04 and OS X (which are my only target systems right now).  To use, just use this line in package.json:
"prerender": "git://github.com/Lochlan/prerender.git#phantomjs2",

(And if you want this in Travis I have some travis config lines in the readme that you can use.)
Anyone needing to support other systems (e.g. Windows) can use a similar approach for whatever their needs are.  As I have mentioned elsewhere I think this is the best approach for now, while the phantomjs project is in this weird state.

Cool! And just a note, we host our compiled phantomjs2 binaries in our own s3 bucket and set our PHANTOMJS_CDNURL to point to it. My phantomjs fork checks for 2.0 and downloads it instead of requiring a local compilation. So you can do that to install on OSX, linux, and windows by just setting PHANTOMJS_CDNURL.

Ah, my mistake!  Thanks for clarifying, I will have our team try it out as-is!

OK, I see: you're referring to an environment variable.  Not an unreasonable solution, but IMO adding a configuration detail to deployment is a little worse than just forking the project.  (Definitely a matter of personal taste!)  Thanks for the response!

PhantomJS 2.1 is now enabled and running in the latest Prerender version (4.0.3). Please feel free to try it out!


Add missing classifier for paddle, dlr and tflite in bom

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #785 (d3f2bf3) into master (d075028) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #785      +/-   ##
============================================
- Coverage     70.17%   70.09%   -0.09%
+ Complexity     4931     4921      -10
============================================
  Files           483      483
  Lines         21711    21711
  Branches       2258     2258
============================================
- Hits          15236    15218      -18
- Misses         5275     5292      +17
- Partials       1200     1201       +1

Impacted Files
Coverage Δ
Complexity Δ

...djl/training/listener/LoggingTrainingListener.java
83.18% <0.00%> (-5.31%)
22.00% <0.00%> (-6.00%)

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
4.00% <0.00%> (ø%)

api/src/main/java/ai/djl/training/Trainer.java
91.83% <0.00%> (-3.07%)
33.00% <0.00%> (-1.00%)

api/src/main/java/ai/djl/util/Platform.java
46.51% <0.00%> (-2.33%)
8.00% <0.00%> (ø%)

api/src/main/java/ai/djl/repository/Artifact.java
89.65% <0.00%> (-1.73%)
36.00% <0.00%> (-1.00%)

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
21.00% <0.00%> (ø%)

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
44.73% <0.00%> (-1.32%)
15.00% <0.00%> (ø%)

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
77.17% <0.00%> (-1.09%)
43.00% <0.00%> (-1.00%)

...ne/src/main/java/ai/djl/mxnet/jna/StringArray.java
92.85% <0.00%> (ø)
9.00% <0.00%> (-1.00%)

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
51.14% <0.00%> (ø)
14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d075028...d3f2bf3. Read the comment docs.


[HMR] StyledComponent (styled.div) causes react-hot-loader error

System:

OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-3720QM CPU @ 2.60GHz
Memory: 92.44 MB / 8.00 GB
Shell: 5.3 - /bin/zsh

Binaries:

Node: 7.2.1 - /usr/local/bin/node
Yarn: 1.5.1 - /usr/local/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm

npmPackages:

babel-plugin-styled-components: 1.5.1 => 1.5.1
styled-components: 3.4.2 => 3.4.2

Reproduction
https://github.com/rgrwkmn/styled-components-hmr-bug
Steps to reproduce
$ git clone git@github.com:rgrwkmn/styled-components-hmr-bug.git
$ cd styled-components-hmr-bug
$ yarn install
$ yarn start
$ open http://localhost:8080

Open App.js, modify the file, and save it. This should trigger the hot module reload and show this error in the console:
React-hot-loader: fatal error caused by  ƒ StyledComponent() {
        classCallCheck(this, StyledComponent);
        return possibleConstructorReturn(this, _ParentComponent.apply(this, arguments));
      }  - no instrumentation found.  Please require react-hot-loader before React. More in troubleshooting.

Remove StyledDiv from the App.js render function, refresh the browser, modify the file, and save it again. The error should not be shown in the console this time.
Expected Behavior
HMR via react-hot-loader functions normally, hot loading components without creating errors.
Actual Behavior
HMR via react-hot-loader shows errors in the console if styled components are used created via styled.div or other such methods.
Possibly important information
In my example project, HMR continues to work, but I found this in a larger private project where HMR stops working after this error is displayed in the console. This started happening after dependency upgrades, so hopefully I'm just in a weird state and someone can quickly see that by looking through my configs.

I think it has something to do with your setup. I've used HMR successfully with s-c on many projects.

@probablyup thanks for looking, I had success too until I started upgrading dependencies. It could even be a problem with webpack, babel, or react-hot-loader because they are all so interconnected to make this HMR work. It makes me think that some project is able to load its own version of react, even though I have the alias setup in webpack. My larger project also has HMR issues with react-router, and code splitting too! This is just the one that threw an error I could isolate.
I'll probably just remove react-hot-loader from the project and use the webpack HMR until I can upgrade to webpack 4 and maybe then things will start working.

Yeah, very highly likely to be an issue with dependencies or maybe a missed upgrade/migration step from one of the libraries involved. I'm going to close this though because it's almost certainly not styled-components.

Were you able to solve this one?  I'm running into the same exact issue.

@andrewkfiedler were you using webpack aliases?


Children load with AJAX

I am trying to set children to true, just for displaying that which parent have children and then on selection of node creating the children. But the problem is when setting children to true the selection is returning the objects but the parent is not expanding. And if removing the children part it's just working fine. Any solution?

I have no idea what you mean. lazy loading (children : true) works when a node is expanded not selected. And it has worked for thousands of users. I can help you debug, but at least post your config, you can also use the discussion group for such how-to questions.


Multiple baseline problem

Currently determining baseline for interaction effects relies on the heuristic of checking out what the baseline is for the other contrasts. However, in a case like this: https://gemma.msl.ubc.ca/expressionExperiment/showExpressionExperiment.html?id=6234, we can see that both male and female were used as baseline for different contrasts. The gemma website still seems to be able to figure out what the real baseline is but I am currently unable to using the API

fixed by cb089bd7e4950dded6bd810ee5219ff7bbca4d14


macOS 11: SF symbols for preference pane / use the right toolbar styles

Use SF symbols (only for macOS 11+ / Big Sur) for preference pane's toolbar to be consistent with rest of OS. Set toolbar style to be "preference" as otherwise it defaults to "unified" which is not correct for a preference pane.
Set toolbar style for main MacVim window to be "unified compact", as the default "unified" is too larger and not useful for text editing. For example, Xcode also uses this.

Preference pane finally looks right:

And toolbar (future PR should fix up the default toolbar icons to at least use SF Symbols to make them not look so outdated and out of place in Big Sur):


List resources as a stream

Resource.list_stream/1 returns a stream of resources matching the given query. Pagination is handled withing the stream generator using Stream.unfold/2.

I close this, I can re-open it in the future if you want @gerbal :)


Unit tests timeout on CI has been detected

{"level":"error","error":"the parameters contains invalid characters and cannot be used","time":"2020-08-04T07:33:24Z","message":"handleServerError()"}

{"level":"error","error":"listen tcp: address 99999: invalid port","time":"2020-08-04T07:33:24Z","message":"Unable to start HTTP/S server"}

--- FAIL: TestHTTPServer_ReportEndpoint (10.00s)

    timeout.go:39: Test ran out of time

{"level":"error","time":"2020-08-04T07:33:34Z","message":"This organization is not allowed to access this recommendation"}

{"level":"error","error":"This organization is not allowed to access this recommendation","time":"2020-08-04T07:33:34Z","message":"handleServerError()"}

{"level":"error","time":"2020-08-04T07:33:34Z","message":"Invalid/Malformed auth token"}

{"level":"error","error":"Invalid/Malformed auth token","time":"2020-08-04T07:33:34Z","message":"handleServerError()"}

{"level":"error","time":"2020-08-04T07:33:34Z","message":"This organization is not allowed to access this recommendation"}

Does it happen each time or just randomly?

How do you reproduce the issue? I can't do it on my local machine

Closing because it's not reproducible.


how to handle builder?

error: getting status of '/home/daniel/dev/obs-cli/builder': No such file or directory

Can you provide some more context?


packages should be able to specify minimum version of pxt / target

If we have breaking changes, we need to specify minimum requirements on packages.

Added minTargetVersion. There is no reason to specify pxt version, as it is tied to target version.


Combine extensions to the same dir.

把 extension 放在同一個資料夾
並且更新中文版 README

Thanks for the contribution
I would like to keep the file structure intact
I will consider a Chinese version of readme later
Since the extension has been published, there's no reason to add such extension pack. I will consider add the crx file later.

Okay, no problem.
Thanks!


Document new Git workflow in CHANGELOG.md

Issue Summary
We want to update our git workflow to function more like Gitflow. We need to update the CONTRIBUTING.md file and PULL_REQUEST_TEMPLATE to direct contributors to fork/branch off the development branch and to merge their PRs with the development branch. Once this issue is complete, we will be creating the development branch and making that branch the default. This is part of a larger strategy to execute releases for this SDK on a predictable cadence.
Acceptance Criteria

Update CONTRIBUTING.md documentation, explaining the process of forking and branching off the development branch and submitting PRs agains the development branch.
Update PULL_REQUEST_TEMPLATE with the same addition to the CONTRIBUTING.md documentation.

@thinkingserious May you assign it to me?

Hi all, I am working on this issue.

Hey @susantruong ! You need to manually create a PR through sendgrid's repo on GitHub. Pull Request is a feature of GitHub :D

Hey @susantruong ! Looks like you've created a PR on your fork. Create a PR on sendgrid's workspace :D

Closing as we're no longer going with this change of workflow.


Incorrect nested webUI when submitting an empty inline review within a PR

Gitea Version
1.15.8/1.16
Can you reproduce the bug on the Gitea demo site?
Yes
Description
When you start a review associated with a PR, if you select a line-number and "start review" the vast majority of the Gitea WebUI is reproduced causing layout issues. The key point is "submitting an empty comment" (or trigger some other errors).
https://try.gitea.io/eeyrjmr/test_issues/pulls/2/files
Steps to reproduce

Start a PR
view PR
View PR files
click blue + on one of the  lines
keep content empty, click green start review UI button
error message:  "Content cannot be empty."

This of course shouldn't be happening, I know that this HTML(the review panel) is provided and rendered from a network request on-demand. So... do you have any extension, proxies, firewall that could cause interference.

This of course shouldn't be happening, I know that this HTML(the review panel) is provided and rendered from a network request on-demand. So... do you have any extension, proxies, firewall that could cause interference.

I do have some extensions so I'll retry with all disabled to see if it can be narrowed down

I do have some extensions so I'll retry with all disabled to see if it can be narrowed down

so...
Chrome-98 and used incognito mode - issue exists
Chrome-98 and all extensions disabled - issue exists
Firefox-95 - issue exists

Just tried it on my mobile on 4G, same thing

What is the message here?

The error message is "Content cannot be empty."
The problem occurs when a user tries to submit a empty form, then backend&frontend can not handle it gracefully.

The error message is "Content cannot be empty."
The problem occurs when a user tries to submit a empty form, then backend&frontend can not handle it gracefully.

Can reproduce now. Thanks @wxiaoguang 😄

I updated the original comment also. It's important to report/describe a bug clearly. 😂

I updated the original comment also. It's important to report/describe a bug clearly. joy
At the time I didn't know this was the cause, adding "something" doesn't cause this. Also once the "review has started" you don't get this ui option anymore only comments

That's fine and already helps Gitea a lot 👍  (ps: if the screenshot could be more clear, then the problem could be more obvious at first glance 😊)
The updating of the original comment is to make new readers can know how the bug appends and hopefully the bug can be fixed soon.

I guess the simplest fix is to disable the comments when their is no content? Because otherwise the patch will become quite lengthy in order for the JS to see redirects and then replace the whole DOM(Performance does ouch).

There  was a PR  to make the edit area on  Wiki pages  can be requried. I am not sure whether it could help this problem:

#17415

If the empty content is the only reason to trigger this bug,  it could be fixed by the required attribute.
Otherwise maybe we should re-design the AJAX requests.


new README section

To make Cycle.js more approachable to a larger number of users—from informed developers to curious passersby and new and interested visitors—I have added a new section to the Cycle.js README. The section is entitled What to Use Cycle.js for and When to Use It. As the name suggests, the new section, a brief paragraph, explains in plain and straightforward language what technologyRepo is used for and when one should use it.
Other repositories may begin to use this new informative and catchy section soon, as my colleagues contact open-source technologies in an effort to make them more accessible to the tens of thousands of new users learning to code and thousands joining GitHub every day.

Thanks @escorponox for the initiative, but our README in this repo is not the channel for communicating these things. We have cycle.js.org for that, and we put on the frontpage already this story for "What and When".
This README is for information about this repository, which is just one piece of the Cycle.js framework.
Sorry


Flaky Test: TestScalability/CommandStats

What happened:
Flaky test for TestScalability/CommandStats.
{Failed  === RUN   TestScalability/CommandStats
    checker_test.go:87: Average CPU usage 516mCpu is greater than maximum expected 515mCPU
--- FAIL: TestScalability/CommandStats (0.00s)
}

What you expected to happen:
It never happened.
How to reproduce it (as minimally and precisely as possible):
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-kueue-test-scheduling-perf-main/1819194281240301568

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign
/kinf flake

/kind flake


Selecting text with blinking cursor

I believe the title says it all. Selecting text with the "Cursor Blink" option enabled is impossible as the text becomes unselected when a "blink" occurs.
This is troublesome when attempting to copy text from the terminal, for instance.

@nunocastromartins I'm assuming you mean when trying to copy text from where the prompt is. This issue is a side effect of my dependency trying to animate within HTML.
The dependency animates the cursor blink by editing the HTML at that line to remove and add the cursor. When that happens, text selected at that region is deselected because the text disappeared for a moment in time.
I might be able to fix this. I'll edit the dependency and try a different way of animating that could solve this issue.

You can do this with CSS only. :smile:
Give me a moment and I'll send you something to work with.

I figured I could just set up a blinking animation in CSS. If you could help me with that, that would save me some time with piecing something together.

I simply added this to my styles.less
.terminal-cursor {
  -webkit-animation: blink 1s linear infinite;
  @-webkit-keyframes blink {
    50% {
      opacity:0.0;
    }
  }
}

Or, with no animation:
.terminal-cursor {
  -webkit-animation: blink steps(1) 1s infinite;
  @-webkit-keyframes blink {
    0% {visibility: visible;}
    50% {visibility: hidden;}
    100% {visibility: visible;}
  }
}

With a bit of "hacking" I made it work in a way that blinks without animation, doesn't hide the character in the position of the cursor and depends on the background-color of .terminal-cursor:
.terminal-cursor {
  position: relative;
  visibility: hidden;
  z-index: 1;
  &:after {
    content: '';
    position: absolute;
    top: 0;
    display: block;
    width: 100%;
    height: 100%;
    background-color: inherit;
    z-index: -1;
    -webkit-animation: blink steps(1) 1s infinite;
    @-webkit-keyframes blink {
      0%   {visibility: visible;}
      50%  {visibility: hidden; }
      100% {visibility: visible;}
    }
  }
}

I like the animation. However I see the character as hidden when I implement this. Copying that region results in a missing character.

Copying results in: "helo" rather than "hello"

I'm sorry, I edited the comment with the animation too. Forgot to say I edited it, though.
Use background-color: transparent and it should work.

I personally prefer the "non-animated" version, as it seems to be the default behaviour in the Atom editor. As a further bonus, changing the width in .terminal-cursor:after (to, say, 1px or 2px) makes it possible to have an "I-beam" cursor, instead of the "block" one, with no issues (changing the width in .terminal-cursor causes problems, apparently).

Yes, it works now with your updated animation. I added a animation delay to make it blink less often. I could see the cursor being customizable at some point. The only problem with this is that it breaks any theming that people have done in their own stylesheets. I need to make this rely on .terminal-cursor's background color somehow.

Turns out, it was a lot simpler than we though:
.terminal-cursor {
        -webkit-animation: blink 1s step-start 0s infinite;
        -webkit-animation-delay: 1s;
        @-webkit-keyframes blink {
          50%  {background: transparent; }
        }
      }

This works.

Ah, nice! I'm not an expert on CSS animations. :stuck_out_tongue:
Just note that animation-delay is the time until the animation starts, it won't make the animation blink less ofter, I don't think. To make it blink less often just change the time value in the animation property.

Ah, nice! I'm not an expert on CSS animations. :stuck_out_tongue:
Neither am I haha.

I should rephrase that. I added the animation-delay so the cursor would not consistently blink. The delay will keep the cursor solid during output and while moving the cursor. Then when there is no movement, the cursor will blink. That resembles what most terminal emulators do.

Fixed as of v0.12.4. Please give it a try. If you still think this is still an issue, let me know. Otherwise please close this issue if it has been resolved.


Allow duplicate permissions - merge values

Allows duplicate declerations, e.g.
permission(:tcp, 22..22){ip_ranges("<IP_ADDRESS>/0")}
permission(:tcp, 22..22){ip_ranges("<IP_ADDRESS>/32")}

v0.2.7.beta2 has been released.
Please try it out :-)


Add dependencies to readme - closes #1

Add some info to the readme about the required dependencies for highlighting.

Thanks!