Bug: ApiException on RolesApi.GetPermission and RolesApi.GetPermissionAsync

Prerequisites

[X] I have searched the repository’s issues and Kinde community to ensure my issue isn’t a duplicate
[X] I have checked the latest version of the library to replicate my issue
[X] I have read the contributing guidelines
[X] I agree to the terms within the code of conduct

Describe the issue
Kinde.Api.Client.ApiException: 'Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'System.Collections.Generic.List`1[Kinde.Api.Model.RolesPermissionResponseInner]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.
To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List<T>) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object.
Path 'code', line 1, position 8.'

Also, the naming of this end point should be GetRolePermissionsAsync (plural).
Library URL
https://github.com/kinde-oss/kinde-dotnet-sdk
Library version
1.2.8
Operating system(s)
Windows
Operating system version(s)
Wwindows 11 v10.0.22635
Further environment details
No response
Reproducible test case URL
No response
Additional information
No response

Thank you for raising this, I will look into it.

Hi @infolabnz , we just released a new version 1.2.9, can you update and see if these are resolved?

Great, thank you. Yes, that has been resolved. Thanks for changing the method name, too. That makes much more sense.


Problem with set.php

Required Information

PHP version: 5.5.9
PHP Telegram Bot version: latest I think
Using MySQL database: no
Update Method: Webhook
Self-signed certificate: yes

Actual behaviour

What IS happening?
when I open set.php on my browser he return http error 500, but the webhook is correctly set.

I've tried to add
$result = Longman\TelegramBot\Request::sendMessage(['chat_id' => 'myid', 'text' => 'sample message']); 	//echo json_encode($result);
after
$telegram = new Longman\TelegramBot\Telegram($API_KEY, $BOT_NAME);
and the message is correcly sent.
the apache error.log say:
PHP Fatal error: Call to a member function isOk() on a non-object in /var/www/html/set.php on line 21

Then, if I broswe directly to hook.php he return
exception 'Longman\TelegramBot\Exception\TelegramException' with message 'Input is empty!' in /var/www/html/phptelebot/vendor/longman/telegram-bot/src/Telegram.php:252 Stack trace: #0 /var/www/html/hook.php(52): Longman\TelegramBot\Telegram->handle() #1 {main}
What can I try to make it work? Thank you

The code is fine.
I don't understand why you get 500. Could be that the telegram server are in down did you check it?
Then input is empty is correct because with your browser you are not sending a json payload

Is it possible that my server miss something? Is an ubuntu 14 set by me on cloudatcost, what can I check?

I see you are using a custom certificate.
Are the permissions for the certificate file correct? It must be readable by the Apache user, probably www-data.

I know becouse if I browse to https://api.telegram.org/botMYAPI/getUpdates I get {"ok":false,"error_code":409,"description":"Conflict: can't use getUpdates method while webhook is active"}
about the custom certificate, I tried to set www-data as group, but nothing changes, che error is still on line 21

well, figured out the errors:
first, I had an old version of longman telegram-bot (don't know why, did a composer update couple times).
 Thank you all

Great that you figured it out and that it's working now 🎉


Modified ChannelEdit to accept a ChannelParams object

Modified ChannelEdit to accept a ChannelParams object.
This allows for management such as topics to be updated using ChannelEdit.

The way this has usually been done is to add a new ChannelEditComplex method, that takes a channel object.
We should aim to not break the API for existing users.
You're changing the encoding of all the files so please make sure that isn't done.
Also please make PR's into the develop branch.


Modified image not uploaded?

Hello,
I've been trying to incorporate this code into a website I'm working on.  I'm not sure if I've encountered a bug or if I'm doing something wrong though.  I've been able to incorporate the files fine and I can select a image from my computer.  If I submit the page at that point, everything seems to work as expected.

However, if I select and file and then rotate it say counter clockwise, the image is not sent to the server.  I've done a print_r on the $_FILES array to see what is posted and the array is completely empty.  In the case where I don't modify the image above, I do see the original and new image in the $_FILES array.

In terms of my environment, I'm using PHP and IE11.

Thanks!
Neal

Hello again,
I've done a bit more testing and I think this issue is related to IE11.  If I use Firefox, it seems to work fine after rotating the image.

Any suggestions on how to resolve the issue in IE11?

Thanks,
Neal

Hello again,
I think I figured out what happened.  I believe there's an upload limit in PHP that was affecting some of my images.  smaller sized images work fine.

Neal

Any luck getting the images to upload?  I can't get the plugin to upload the edited images.  I am trying to tweak the plugin but want to specify different folders to upload it to: https://github.com/betheredge/Image-editor-save-2-file


Can you provide an example of a Dockerfile

Example of a Dockerfile

Let's track in https://github.com/unjs/nitro/issues/54.


Posts Not Apearing On index.md

Hello, I just started using this theme and I was wondering why my post is not appearing on the home page of my GitHub pages website. I can still access the post through url/YYYY/MM/DD/TITLE, but I was wondering how I can get that post (and all future posts in the _post directory) to automatically show. Is that possible with cayman?
Thank you.

Hi! This theme does not natively support posts. If you would like to add them to your site, you're welcome to follow the tutorial here: https://jekyllrb.com/docs/step-by-step/08-blogging/#list-posts


Consume current golang-version

The current release is not up-to-date. However the golang-versions prior to 1.18.2 and 1.17.10 have CWE 284. Could you publish soon the next release to fix this, please?

@joergdw cut a new release https://github.com/cloudfoundry/loggregator-agent-release/releases/tag/v6.4.1


Implement missing hashcode()s.

Summary of the changes / Why this improves CrateDB
Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed

retest this please


before_filter is deprecated in 4.2

Rails 4.2 deprecates before_filter and skip_before_filter. We can't switch to before_action and skip_before_action in 1.x because we support Rails 3.
So... we likely need to define a method on Clearance::BaseController that can be called instead and dispatches the proper method based on whats defined.

Can you do something like:
if defined?(:skip_before_action)
  skip_before_action :require_login
else
  skip_before_filter :require_login
end

Also, it might be worth dropping support for Rails 3 soon (or at least deprecating it). There have been three minor releases (4.0, 4.1, 4.2) since Rails 3, so people have had plenty of time to switch (since June, 2013 according to rubygems.org).

Can you do something like:

Yes. But I need to do that 6 different times. So I was going to wrap that in a method on Clearance::BaseController

Yes. But I need to do that 6 different times. So I was going to wrap that in a method on Clearance::BaseController

Sounds good to me.

Also, it might be worth dropping support for Rails 3 soon (or at least deprecating it). There have been three minor releases (4.0, 4.1, 4.2) since Rails 3, so people have had plenty of time to switch (since June, 2013 according to rubygems.org).

Yup. The problem is I'm in the midst of one bunch of deprecations already and I'd like to get those done before bumping the major version. 2.0 will clear those deprecations and also require Ruby 2.1+ and Rails 4.2+

4.2 might be a bit strict. Might have to let in 4.1 or even 4.0

I'm not sure we need to do this, actually. The _filter methods are not deprecated they are just no longer documented. The release notes say:

If your application currently depends on these methods, you should use the replacement *_action methods instead. These methods will be deprecated in the future and will eventually be removed from Rails.

I feel like we should be good until Rails 5, at which point we'll hopefully have a new major version of clearance that supports Rails 4+ (and 5).

Closing as I don't think we should do anything yet. We should just switch over to _action in Clearance 2


No completion appears for a Set type in vscode

IntelliCode Branch: VSCode-release
VSCode Build: 1.26.0
IntelliCode for VSCode: #1.0.1
Python Extension: 2018.7.1 vscode-python dev builds
Affected Project Type: Python
Repro Rate: 100%
Repro on current published extension #1.0.1: Yes
Operation System Information: Win10
Steps to reproduce:

Type Code:

parame = {'apple', 'swsws', "deef"}
parame.
Expected:
There should be completions for a Set Type.
Actual:
No completions appear after typing 'parame.'

Tested with the latest python extension, it's working now.


Create a script to deploy test infra from scratch based on documentation

Everything is documented in the Readme. We might want to create options for depoying kubernetes, persistent disk and hazelcast.

Let 's reopen if this is a problem


docs: langchain-ai21 update ai21 docs

Thank you for contributing to LangChain!
Update docs to match latest langchain-ai21 release.

@efriis Sure, no objection from my end to leave them and add a redirect.
I've added to the provider page a section for the deprecated endpoints.
LMK what you think


New Alma location firestone$tech

See https://github.com/PrincetonUniversityLibrary/alma-config/issues/780
The location should never have any items sent to bibdata. In this case, does the location need to be added to bibdata?

@mzelesky do you mean that the publishing job will never publish items that are in location: 'firestone$tech'? Which would mean that we will not index these items.
If that's the case, then we don't need to add firestone$tech in bibdata.

Yes, that is what I mean. Thank you for that feedback, I will only create tickets in the future when the new location is expected to appear in bibdata. Please close if appropriate.

The understanding was incorrect about this location. See https://github.com/PrincetonUniversityLibrary/alma-config/issues/780 for the information needed for the location in bibdata.

I didn't understand that the record would be indexed to the catalog. I thought they were suppressed. I will add the location.


Support graphql-config type

I'm using this plugin with https://the-guild.dev/graphql/config/docs. although the type causes TS error, it works:
error
Argument of type 'IGraphQLConfig' is not assignable to parameter of type 'Options | undefined'.
  Type 'IGraphQLProject' has no properties in common with type 'Options'.ts(2345)

sample of graphql-config
import type { IGraphQLConfig } from "graphql-config";

const codegenConfig: IGraphQLConfig = {
  schema,
  documents: ["src/**/!(*.generated).{tsx,ts,graphql,gql}", "!src/sdk/**/*", "!node_modules"],
  extensions: {
    languageService: {
      cacheSchemaFileForLookup: true,
    },
    codegen: {
      overwrite: true,
      watch: CODEGEN_WATCH === "true",
      ignoreFieldConflicts: true,
      generates: {
        "src/sdk/gql/types.ts": {
          config: {
            ...config,
          },
          plugins: [
            "typescript",
          ],
        },
        "src/": {
          preset: "near-operation-file",
          presetConfig: {
            extension: ".generated.ts",
            baseTypesPath: "sdk/gql/types.ts",
          },
          plugins: [
            "typescript-operations",
            "typed-document-node",
            {
              add: {
                content: `/* eslint-disable */`,
              },
            },
          ],
        },
      },
    },
  },
};

export default codegenConfig;

Ah, that's interesting! I think it's because the type for the plugin only expects a codegen config type, but doesn't also allow the more generic graphql config type.
I can look into adding the option to pass a more generic graphql config as well! I'm not sure if there are consequences in doing that, but I'll try it out and see what I can find.
If it works in the meantime, are you able to restructure your config so that the schema/documents are inside of the codegen config itself instead, sorta like this? Then maybe there's another way to actually set languageService.cacheSchemaFileForLookup like you are doing.
import type { CodegenConfig } from '@graphql-codegen/cli';

const codegenConfig: CodegenConfig = {
  overwrite: true,
  schema,
  documents: [
    'src/**/!(*.generated).{tsx,ts,graphql,gql}',
    '!src/sdk/**/*',
    '!node_modules',
  ],
  watch: CODEGEN_WATCH === 'true',
  ignoreFieldConflicts: true,
  generates: {
    'src/sdk/gql/types.ts': {
      config: {
        ...config,
      },
      plugins: ['typescript'],
    },
    'src/': {
      preset: 'near-operation-file',
      presetConfig: {
        extension: '.generated.ts',
        baseTypesPath: 'sdk/gql/types.ts',
      },
      plugins: [
        'typescript-operations',
        'typed-document-node',
        {
          add: {
            content: `/* eslint-disable */`,
          },
        },
      ],
    },
  },
};

export default codegenConfig;

Another option may be using a dedicated file for the graphql config, and referencing that file instead in the plugin options like this:
import codegen from 'vite-plugin-graphql-codegen';

codegen({ configFilePathOverride: 'path/to/graphql.config.yml' })

Not sure what you meant with option 1 but I'm using option 2 anyways due to some schema overrides that only works with codegen but not vscode and it works great except I have to load the config fire myself.


added all the requirements in the same PR

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 5 🔵🔵🔵🔵🔵
🧪 No relevant tests
🔒 Security concerns
Sensitive Information Exposure: The server's error messages might expose sensitive details about its internal mechanisms, which could help an attacker craft further attacks. Additionally, the Google client ID is hardcoded in the source, which should be secured using environment variables.
⚡ Key issues to review
Security ConcernThe error messages returned from the server might expose sensitive information about the server's internal state or configuration. For example, returning specific error messages such as 'Token used too late' or 'Invalid token' in the Google login route could help an attacker gain insights into the authentication process.
Hardcoded SecretThe Google client ID is hardcoded directly in the source code. This should be extracted into environment variables to avoid exposure in public repositories and to adhere to the twelve-factor app methodology.
Error HandlingThe error handling in the '/signup' and '/login' routes logs errors to the console but does not send a proper response to the client, potentially leaving the client hanging if an error occurs.
Inconsistent CommentingThe file contains large blocks of commented-out code which can lead to confusion and clutter in the codebase. It's important to keep the codebase clean and only include active code or necessary comments.
API Endpoint ExposureThe client-side code exposes the backend API endpoint directly. This could be abstracted by using environment variables or a configuration file to enhance security and flexibility in changing the API URL without code changes.


Portainer ignores restart policy

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
When restart: "no" is added to a docker compose file it does not convey it to the related service, when the stack is started
Expected Behavior
The container does not get restarted after expected or unexepcted exit
Actual Behavior
The container policy gets adapted:

but the service policy not:

which actually overrides the restart policy
Steps to Reproduce
docker composef file
version: '3.9'

services:
 <arbitrary service>:
    image: <arbitrary image>:1.0
    restart: "no"

Portainer logs or screenshots
No response
Portainer version
2.19.4
Portainer Edition
Business Edition (BE/EE) with 5NF / 3NF license
Platform and Version

OS and Architecture

Browser
No response
What command did you use to deploy Portainer?
No response
Additional Information
No response

Running into this issue as well.  We have a one-shot container in our stack (does DB migrations- need to run once, exit, and not restart) and it is continually restarting to spite the restart policy being "no" in the compose file.
It looks like overriding this in the service definition area of the UI is a workaround until this is fixed although I'm not sure how "sticky" that setting is across redeployments and whatnot.


Add support for tornado version 6

Adds CI for tornado 6.
Replaces deprecated API calls.
The new gen.sleep was added in 4.1, so that is the new lower requirement for the tornado dependency.

This will be merged after 0.6.0 is released, c.f. #45.

I'll give the current master a little exercise on one of my projects, and if it works well, I'll push an 0.7 release with these changes.

@vidartf I did the same for one of my projects and current master worked fine for me.
One thing I did however notice is that it seems to be a bit slower in comparison. Not sure if this is due to changes in tornado or in pytest-tornado.

@okin Thanks for the feedback. I can't really see anything on the side of pytest-tornado that would make things slower, but I'll keep it in mind for the future.


Make useFetch() return properly-parsed output based on Content-Type response header

Instead of just returning all res.blob(), res.text(), res.json() alternative outputs from useFetch() at once, you could just return a single output, properly parsed based on the value of Content-Type response header:

if it's application/json, return res.json()
if it's another text-based MIME type, return res.text()
if it's a binary MIME type, return res.blob()

I agree, this is more useful than raw responses.


Bump xdita from 0.3.1 to 0.3.2

Description
Bump lwdita package to latest
Motivation and Context
Updates dependency to latest, fixes https://github.com/dita-ot/dita-ot/issues/4233
How Has This Been Tested?
unit tests

@robander The https://github.com/oasis-tcs/dita-lwdita/releases page shows v<IP_ADDRESS> as the tag, but 0.3.2 in the title there (and here).
Assuming we should use the latter in our Release Notes, right?

(sigh) should have been 0.3.2, yes


Provide documentation and examples for running localnode as a shared resource

Problem
A localnode on my machine is not a shareable resource. Localnode needs to become a shareable resource for stakeholders, other developers, and beta users to use my dapp.
Solution

Deploy localnode to a cloud provider
Deploy hashscan to a cloud provider and configure hashscan to point to localnode's mirror node
Configure firewall rules in cloud provider
Configure hashgraph/sdk to connect to localnode
Provide documentation and examples for doing the above
Make this process easy to deploy and configure localnode, hashscan, and hashgraph/sdk

Alternatives
No response

I love this issue.
In our own testing, we use a tool called FST for "full stack test". We're rebuilding it from its first version (which was known as JRS). The FST comes in several parts:

A library for lifecycle management of a cluster. It comes with GCP support out of the box. You give it some credentials to your GPC and it will create all the nodes and install all the software, then you can run all your tests or leave it up indefinitely, and use FST to take it down when you're done. Or perform an upgrade. We're adding in everything into this -- hashscan, hashio, mirror node, consensus node, proxies, uploaders, etc. And you can integrate it with a running grafana / loki instance to get all the metrics information. You get to choose how many nodes, you get to choose what kind of nodes (cheap, or mainnet like). Anybody in the world can use this to spin up a network at any time they want, and tear it down again at the end.
A library integrated with JUnit for running tests. This is extremely useful for us, because we're in Java.

We use this tool on every build (for example, see #9103. You can see the "JRS" build at the bottom).
Local node is much less expensive to operate and good for single-node deployment. But FST might be a better fit for creating nodes. You can see the project here: https://github.com/hashgraph/full-stack-testing

Local node is much less expensive to operate and good for single-node deployment.

Not only single-node, it supports multi-node with up to 4 nodes.

Thanks @pwoosam
Great suggestion and in line with ideas we've had.
In addition to the above some initial steps we feel that will help will come from efforts such as https://github.com/hashgraph/hedera-local-node/issues/189
In this case users could easily deploy local node to k8s envs in any cloud provider and share it as needed as well as configure many of the items you noted.

You can achieve this by running the repo in codespace/gitpod integration.
After the local node is up you should, in order to make Hedera Explorer accessible, make ports 8080 and 5551 public via the web interface:

for codespace: https://docs.github.com/en/codespaces/developing-in-a-codespace/forwarding-ports-in-your-codespace#sharing-a-port
for gitpod: https://www.gitpod.io/docs/configure/workspaces/ports#default-port-behaviors

After that edit in the .env file the variable DOCKER_LOCAL_MIRROR_NODE_URL to point to the URL address showed in codespace/gitpod. It is usually in the following format:

for codespace: https://${CODESPACE_NAME}-5551.app.github.dev
for gitpod: https://5551-${HOSTNAME}.${GITPOD_WORKSPACE_CLUSTER_HOST}

and restart the local node with hedera restart -d.
You can also consider making public the following exposed ports:

Type
Endpoint

Consensus Node Endpoint
http://localhost:50211

Mirror Node GRPC Endpoint
http://localhost:5600

Mirror Node REST API Endpoint
http://localhost:5551

JSON RPC Relay Endpoint
http://localhost:7546

JSON RPC Relay Websocket Endpoint
http://localhost:8546

Mirror Node Explorer
http://localhost:8080

Grafana UI
http://localhost:3000

Prometheus UI
http://localhost:9090

Please review also the following project: Solo


no_file_data error when using fileData with no filename

Issue Type

[x] Bug
[ ] Enhancement / Feature request
[ ] Question
[ ] Documentation

Description
I'm trying to upload an image in a Spring Boot + kotlin application using the slack-jdk but unfortunately it fails to upload the file content. I'm almost sure that something is wrong with building a multipart message since sending a file with text content works fine. Might be worth checking RequestFormBuilder.java#1128.
The issue is reproducible in:

Module Version: 1.1.0
Openjdk version "14.0.2" 2020-07-14
OpenJDK Runtime Environment (build 14.0.2+12-46),
OpenJDK 64-Bit Server VM (build 14.0.2+12-46, mixed mode, sharing)
OS Version etc: macOS Catalina 10.15.5

The steps to reproduce are:
val filepath = File("path/to/local/file.png")
val fileUploadRequest = FilesUploadRequest.builder().fileData(filepath.readBytes()).filetype("png").build()
println(methods.filesUpload(fileUploadRequest))
The expected result is:
Upload a file and get FilesUploadResponse with ok=true :)
The actual result is:
FilesUploadResponse(ok=false, warning=null, error=no_file_data, needed=null, provided=null, file=null)

Requirements

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

@sikorski-as Thanks for taking the time to report this!
When you use the fileData setter method instead of file, giving filename at the same time is the way to use the method in the latest version. Here are some test cases reproducing the behaviors. https://github.com/seratch/java-slack-sdk/commit/8ec78c5eaba462b8ba08fb7f56839642a7ccfb9b
That being said, I do understand this is confusing. I will be improving the error message or changing the behavior to set a random name if absent. Thanks again for reporting this.

Well, this is surprising 😄
I added a filename and it fixed the issue, file uploads appropriately.
Thanks for a quick response!

Hey, I found the same issue while using file upload. The file only got uploaded to the slack channel after adding the filename
    FilesUploadResponse response = slack.methods(token).filesUpload(req -> req
               .channels(Collections.singletonList("xxxxxx"))
               .file(new File("target/site/serenity/index.html")).filename("index.html"));


Enable the coverage test

#212

Fix the coveralls test by adjusting the setting of CXX flags.
Enable coveralls test in travis ci.

Coverage increased (+2.4%) to 47.746% when pulling 5f8281b8505fef83bd87210a726ad797489f8aa4 on jessesleeping:master into eb5098281188cc8668e0ffebdb8aa63d25076764 on cmu-db:master.


Add LICENSE (copy of docker/docker's Apache-2.0 file)

This repository was missing a license, but since it's been created mostly from bits of github.com/docker/docker, I figured that license was probably appropriate for this top-level (since the individual vendored directories should have their LICENSE files intact anyhow).
A quick diff to show that it's 100% identical:
$ diff -u \
  <(curl -fsSL 'https://github.com/docker/docker/raw/master/LICENSE') \
  <(curl -fsSL 'https://github.com/tianon/docker-ce/raw/license/LICENSE')
$

Interesting;
17:46:12 [init] Removing components/engine/docs/reference/commandline/export.md
17:46:12 [init] Removing components/engine/docs/reference/commandline/exec.md
17:46:12 [init] Removing components/engine/docs/reference/commandline/events.md
17:46:12 [init] CONFLICT (modify/delete): components/engine/docs/reference/commandline/dockerd.md deleted in origin/pr/103 and modified in HEAD. Version HEAD of components/engine/docs/reference/commandline/dockerd.md left in tree.
17:46:12 [init] Removing components/engine/docs/reference/commandline/diff.md
17:46:12 [init] Removing components/engine/docs/reference/commandline/deploy.md
17:46:12 [init] Removing components/engine/docs/reference/commandline/create.md

@andrewhsu this also needs to go into the 17.06.x branch

Reposting my response from packaging issue:

Thanks for sending this PR. I don't think we should add a permissive license to this repo, however. The code in this repo is meant for the sole use of Docker Inc. to build packages for the Docker Community Edition products.

If this code had a permissive license, that might be misunderstood to mean that it's ok for others to build and distribute "Docker" packages (it's not ok, "Docker" is protected by a trademark owned by Docker Inc.).

Anyone interested in building something out of the open source components that go into Docker should use the Moby project, not this code: https://github.com/moby/moby

This packaging code is made available to provide transparency for Docker CE users, and to help them troubleshoot and report issues with Docker CE packages.

https://github.com/docker/docker-ce-packaging/pull/30

If this code had a permissive license, that might be misunderstood to mean that it's ok for others to build and distribute "Docker" packages (it's not ok, "Docker" is protected by a trademark owned by Docker Inc.).

Isn't that where this item in the license is included for?
   6. Trademarks. This License does not grant permission to use the trade
      names, trademarks, service marks, or product names of the Licensor,
      except as required for reasonable and customary use in describing the
      origin of the Work and reproducing the content of the NOTICE file.

Wondering though, given that some components are taken from other repositories,
that are Apache licenced;
You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

...

      (b) You must cause any modified files to carry prominent notices
          stating that You changed the files; and

Reading that, does that imply that any file that has been modified (due to
cherry-picks/backports in this repository) must carry a comment stating what's
modified?

The Windows community is blocked having no newer Docker CLI binary than 17.10 available for months. The chocolatey package "docker" using direct downloads from download.docker.com/win/static suffers from it. People ask me to update, but I cannot help.
There are people with enterprise Windows machines using other Hypervisors than VirtualBox (Docker Toolbox) and Hyper-V (Docker 4 Windows). Installing Toolbox where you only need the Docker CLI is a big overhead.
I looked for a way to compile docker.exe for a specific release version, but it's not possible to share such binary. The docker/cli repo has no tags and branches, so it's unusable. Only source of truth is this repo's components/cli subfolder. But without a license it's impossible to distribute such binary for the Chocolatey community.

There’s a license inside the components/cli directory, so I wonder if that’s enough to build just the cli.

Any chance of this being revisited?

Its called a ethereal domain owner you dinosauruses.
The internet now days is a first party to ping download at realtime.

wait with merging of this one; I got approval for the docker/docker-ce-packaging repo, but this one was not yet discussed
(FWIW, we're moving away from using this mono-repo in our build/packaging pipelines, so it will be obsolete in the near future)


Uncaught Exception. Crashing the entire Node-RED!!!

1|node-red | 29 Mar 18:55:30 - [red] Uncaught Exception:
1|node-red | 29 Mar 18:55:30 - TypeError: First argument must be a string or Buffer
1|node-red |     at ServerResponse.end (_http_outgoing.js:742:13)
1|node-red |     at handleError (/root/.node-red/node_modules/node-red-contrib-http-proxy/http_proxy.js:27:13)
1|node-red |     at ProxyServer. (/root/.node-red/node_modules/node-red-contrib-http-proxy/http_proxy.js:38:13)
1|node-red |     at ProxyServer.emit (/root/.node-red/node_modules/eventemitter3/index.js:210:27)
1|node-red |     at ClientRequest.proxyError (/root/.node-red/node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js:163:18)
1|node-red |     at emitOne (events.js:121:20)
1|node-red |     at ClientRequest.emit (events.js:211:7)
1|node-red |     at Socket.socketErrorListener (_http_client.js:387:9)
1|node-red |     at emitOne (events.js:116:13)
1|node-red |     at Socket.emit (events.js:211:7)
1|node-red |     at emitErrorNT (internal/streams/destroy.js:64:8)
1|node-red |     at _combinedTickCallback (internal/process/next_tick.js:138:11)
1|node-red |     at process._tickDomainCallback (internal/process/next_tick.js:218:9)

Line 27: http_proxy.js
err object may not be a String or Buffer. That's the problem.


Send multiple job report to dashboard with the same object

I found out some agents spending several minutes to send information to dashboard. One of them was actually even failing to resolve the name into an ip address from time to time (since we get a new instance for each report).
This patch solves that problem by passing a list of jobs to report to the same method that retrieves the apmon instance. I also tried to get rid of some of those standalone functions and make it all in the DashboardAPI  class (so I had to update the WMRuntime report as well).
I still want to a) make it report a group of jobs in handleSteps instead of one by one, b) run a larger test to make sure it behaves Ok and c) test the ReqMgr report
@ticoann @ericvaandering please review
@mmascher @juztas @emaszs I noticed there is a 'copy' of the apmon code in the CRABServer repo. Is CRAB completing relying on the WMCore code for the dashboard report. There are several different functions/reports here that I don't really know if they are used at all (certainly not by WMAgent)

@ericvaandering please have a look at the third commit, it should have fixed both of your comments.
I took me some reading on context managers, hopefully I got it right and didn't overcoded :)
I still need to test it in real life.

Ok, I'm done with my changes and I'd like to have it in the next tag for the next production candidate release.
Hopefully I ran all the tests this time, including performance wise. I also x-checked this info with the Dashboard team.
I kept the 3rd commit alone because it has the context manager usage and it touches both srv and test code, so squashing is going to be tricky.
@ticoann please merge if @ericvaandering has no additional comments

Thanks, Eric. I updated the enter() method to make it more clear.


pexpect error after reboot

After the LinuxTarget object is recreated after a reboot we get this error after several commands are executed. Not sure how to give more information, but maybe the error output below is already informative per-se? :-)
04:04:37  DEBUG   : sudo -- sh -c 'echo pippo'
Failure: EOF (End Of File (EOF). Exception style platform.
<pexpect.pxssh.pxssh object at 0x4af25d0>
command: /usr/bin/ssh
args: [u'/usr/bin/ssh', u'-q', u'-l', u'root', u'<IP_ADDRESS>']
searcher: None
buffer (last 100 chars): ''
before (last 100 chars): '\r\n'
after: <class 'pexpect.exceptions.EOF'>
match: None
match_index: None
exitstatus: 255
flag_eof: True
pid: 25597
child_fd: 5
closed: False
timeout: 30
delimiter: <class 'pexpect.exceptions.EOF'>
logfile: None
logfile_read: None
logfile_send: None
maxread: 2000
ignorecase: False
searchwindowsize: None
delaybeforesend: 0.05
delayafterclose: 0.1
delayafterterminate: 0.1) ... ERROR

======================================================================
ERROR: Failure: EOF (End Of File (EOF). Exception style platform.
<pexpect.pxssh.pxssh object at 0x4af25d0>
command: /usr/bin/ssh
args: [u'/usr/bin/ssh', u'-q', u'-l', u'root', u'<IP_ADDRESS>']
searcher: None
buffer (last 100 chars): ''
before (last 100 chars): '\r\n'
after: <class 'pexpect.exceptions.EOF'>
match: None
match_index: None
exitstatus: 255
flag_eof: True
pid: 25597
child_fd: 5
closed: False
timeout: 30
delimiter: <class 'pexpect.exceptions.EOF'>
logfile: None
logfile_read: None
logfile_send: None
maxread: 2000
ignorecase: False
searchwindowsize: None
delaybeforesend: 0.05
delayafterclose: 0.1
delayafterterminate: 0.1)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/nose/loader.py", line 519, in makeTest
    return self._makeTest(obj, parent)
  File "/usr/local/lib/python2.7/dist-packages/nose/loader.py", line 566, in _makeTest
    return self.loadTestsFromTestCase(obj)
  File "/usr/local/lib/python2.7/dist-packages/nose/loader.py", line 490, in loadTestsFromTestCase
    return super(TestLoader, self).loadTestsFromTestCase(testCaseClass)
  File "/usr/lib/python2.7/unittest/loader.py", line 56, in loadTestsFromTestCase
    loaded_suite = self.suiteClass(map(testCaseClass, testCaseNames))
  File "/media/hdd1tb/work/lisa/tests/eas/rfc.py", line 30, in __init__
    super(RFC, self).__init__(TESTS_CONF, *args, **kwargs)
  File "/home/juri/work/lisa/libs/utils/test.py", line 55, in __init__
    self._runExperiments()
  File "/home/juri/work/lisa/libs/utils/test.py", line 73, in _runExperiments
    self.executor.run()
  File "/home/juri/work/lisa/libs/utils/executor.py", line 136, in run
    if not self._target_configure(tc):
  File "/home/juri/work/lisa/libs/utils/executor.py", line 290, in _target_configure
    self._setup_kernel(tc)
  File "/home/juri/work/lisa/libs/utils/executor.py", line 178, in _setup_kernel
    self._setup_rootfs(tc)
  File "/home/juri/work/lisa/libs/utils/executor.py", line 198, in _setup_rootfs
    , as_root=True)
  File "/home/juri/work/lisa/libs/devlib/devlib/target.py", line 251, in execute
    return self.conn.execute(command, timeout, check_exit_code, as_root)
  File "/home/juri/work/lisa/libs/devlib/devlib/utils/ssh.py", line 155, in execute
    output = self._execute_and_wait_for_prompt(command, timeout, as_root, strip_colors)
  File "/home/juri/work/lisa/libs/devlib/devlib/utils/ssh.py", line 204, in _execute_and_wait_for_prompt
    timed_out = self._wait_for_prompt(timeout)
  File "/home/juri/work/lisa/libs/devlib/devlib/utils/ssh.py", line 222, in _wait_for_prompt
    while not self.conn.prompt(1):
  File "/usr/local/lib/python2.7/dist-packages/pexpect/pxssh.py", line 375, in prompt
    i = self.expect([self.PROMPT, TIMEOUT], timeout=timeout)
  File "/usr/local/lib/python2.7/dist-packages/pexpect/spawnbase.py", line 315, in expect
    timeout, searchwindowsize, async)
  File "/usr/local/lib/python2.7/dist-packages/pexpect/spawnbase.py", line 339, in expect_list
    return exp.expect_loop(timeout)
  File "/usr/local/lib/python2.7/dist-packages/pexpect/expect.py", line 102, in expect_loop
    return self.eof(e)
  File "/usr/local/lib/python2.7/dist-packages/pexpect/expect.py", line 49, in eof
    raise EOF(msg)
EOF: End Of File (EOF). Exception style platform.
<pexpect.pxssh.pxssh object at 0x4af25d0>
command: /usr/bin/ssh
args: [u'/usr/bin/ssh', u'-q', u'-l', u'root', u'<IP_ADDRESS>']
searcher: None
buffer (last 100 chars): ''
before (last 100 chars): '\r\n'
after: <class 'pexpect.exceptions.EOF'>
match: None
match_index: None
exitstatus: 255
flag_eof: True
pid: 25597
child_fd: 5
closed: False
timeout: 30
delimiter: <class 'pexpect.exceptions.EOF'>
logfile: None
logfile_read: None
logfile_send: None
maxread: 2000
ignorecase: False
searchwindowsize: None
delaybeforesend: 0.05
delayafterclose: 0.1
delayafterterminate: 0.1

----------------------------------------------------------------------
Ran 1 test in 0.002s

FAILED (errors=1)

I just pushed a fix for this. Please let me know if you're still having this issue after updating.

Issue is gone. Thanks a lot!


aarch64: qemu: update from 3.1.0-rc2 to full 3.1.0 ?

In the verisons.yaml, for the aarch64 qemu we have v3.1.0-rc2 listed. I believe v3.1.0 full is now available. Any reason to not update that @teawater ?
   qemu:
      description: "VMM that uses KVM"
      url: "https://github.com/qemu/qemu"
      version: "stable-2.11"
      architecture:
        aarch64:
          branch: "master"
          tag: "v3.1.0-rc2"
          commit: "47c1cc30e440860aa695358f7c2dd0b9d7b53d16"

3.1.0 came after this commit.

sure, 3.1.0-rc2 matches that 47c1cc commit, and was made 2018-11-20. 3.1.0 release is at 32a1a9, made at 2018-12-11
So, let's try to update to the release version/commit ?

+1


Promise.promisify(functionReturningAPromise) returns a function which will not resolve

Test case:
'use strict';

const Promise = require('bluebird');

const func = Promise.method(function() {
});

describe('Promise.promisify()', () => {
  it('should return a function which eventually resolves', () => {
    return Promise.promisify(func)();
  });
});

Output:
$ mocha bluebird-test.js

  Promise.promisify()
    1) should return a function which eventually resolves

  0 passing (2s)
  1 failing

  1) Promise.promisify() should return a function which eventually resolves:
     Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
      at null.<anonymous> (/Volumes/alien/projects/boneskull/mocha/lib/runnable.js:189:19)

The behavior if Promise.promisify() is misused in this manner seems to be undefined.  Anecdotally, Promise.promisify(function() {}) also results in a non-resolving function.
I'm not sure of how the internals work here, but perhaps something like this could save users from themselves:

When the promisified function (the result of Promise.promisify()) is called, note the final argument.
~~If the final argument is not a function: ~~

after returning from the wrapped function, but before returning from the promisified function, if the return value is not a Promise:

throw some appropriate exception, explaining to the user how they called a function expecting a callback without a callback (or otherwise directing them to appropriate documentation).

else:

cast the Promise to a bluebird Promise and return it.

else:

no change in behavior.

EDIT: I didn't think this through, so I'm not sure how to solve this.  Again; not a big issue.
Not a big deal, but might be more user-friendly.  I may be missing something in the solution that would make this sort of check impossible; if so, I apologize.

ugh, I realize this doesn't make sense, hold on.

yeah, so, promisify passes the function itself, and it has no idea what the wrapped function does with it, or when it will be called, so I imagine this is not solvable.

I suppose, however, if the function actually returned a promise, one may be able to safely return it, but maybe not.

From the first paragraph in the docs:

Returns a function that will wrap the given nodeFunction. Instead of taking a callback, the returned function will return a promise whose fate is decided by the callback behavior of the given node function. The node function should conform to node.js convention of accepting a callback as last argument and calling that callback with error as the first argument and success value on the second argument.

Neither function(){} nor Promise.method(function(){}) are "node functions"

@petkaantonov I understand how the function is intended to be used, what I was hoping for was a safeguard.

Yes if there was a way to detect misuse it would be implemented in a heartbeat :)


More basic gates

I'm going to split these up into independent PRs, but

controlled global phase gate gives you a Z
Controlled Hadamard
Controlled Z
Controlled Y
make cirq_gate_as_bloq a public function

Do you want me to leave comments on this or wait for the individual PRs?
Also, while we are at it, we should also add basic gates for CRz, CRx, CRy, CXPow, CYPow, CCZ, CCY, ZZPow, XXPow, YYPow,

Please leave high-level comments on this PR if you have them

I split this up into individual prs


Fix an off-by-one error in the query limit exceeded CLI logic.

Prevents output such as the following:
LIMIT EXCEEDED: resultset contains more items not displayed (limit=20)

20 item(s) found. Query executed in 0.015 sec(s).

Note how the CLI mentions that the limit of 20 was exceeded by the 20 items found to match the query.

The failing test has nothing to do with my change -- I only touched the CLI and the failing test is on the DB write-ahead log.

Hey guys, any thoughts on this PR, or why the CI tests failed on an entirely unrelated test?

Thanks for your PR. I preferred to fix the problem in another part: https://github.com/orientechnologies/orientdb/commit/3671eba1e58b235fe59a00de2d933fb0be93d7d2.

I might be missing something obvious here, but I don't see how the commit you referenced fixes this -- this resolves an off-by-one error in the CLI, while the commit you linked to fixes an NPE in the database.

Sorry was this: https://github.com/orientechnologies/orientdb/commit/2c4a08deea11d34596f9ccd42d53e0db19cd6f67

Looks good, thanks!


Document our stance on local runners

We often get questions like "is the direct runner suitable for production"? and the answer is usually no. We should document our recommendations for small (one machine) pipelines somewhere on the website.
Imported from Jira BEAM-13989. Original Jira may contain additional context.
Reported by: ibzib.

.take-issue

.close-issue


Update build.yml

The failure is because of an exit 1 I added when there are no images being changed so that it doesn't go on to run the PR status update steps after this one. There's probably a better way here to return success and stop execution but I didn't think it was very relevant for the demos we'll show here.


Spyder won't launch from an environment transfered with conda-pack

I am using Anaconda on Windows 10.
I have a conda environment with Spyder 5.1.5 installed (and also other python packages).
In this environment I can launch Spyder from the conda prompt and it works.
I want to transfer my environment to a machine which has no internet connection (for security reasons).
I pack my environment with conda-pack and install it on the target machine (conda-unpack)
I launch a conda prompt and activate this environment (conda activate).
 From the docs it seems the environment should be activated with source my_env/bin/activate prior to unpacking. See https://conda.github.io/conda-pack/#commandline-usage. From your error it seems there are some problems with prefix cleanup for Qt.
Also, have you tried cloning the broken environment on the target machine as per the suggestion here: https://stackoverflow.com/a/65119053/752092 ? Although that is not a proper solution (which I guess it more related to conda-pack than spyder), perhaps its a work-around for now.
Probably something like this, after activating and unpacking:
conda create --name spyder_env_clone --clone spyder_env
conda activate spyder_env_clone
spyder

Thank you for your answer and sorry for beeing unclear in my descrption. Of course, I activated the environment before runing conda-unpack.
I tried the work-around you suggested and it seems to work : Spyder can be launched in the cloned environment.
Since you thought the problem was related to conda-pack, I looked in the conda-pack issues and I found it (https://github.com/conda/conda-pack/issues/181). The solutions to fix tghe problem are to edit and fix the qt.conf file or to clone the environement, just as you said.
Thank you very much for your help !

Thanks @rhkarls for your help!
Closing since this seems to be solved.


[5.8] Add migrate option to session:table command

Almost every time you generate the session table you are going to be migrating it, so adding the ability to generate and migrate the table with one command is a better workflow.
This PR adds an option to the php artisan session:table command and can be used like this:
php artisan session:table -m
php artisan session:table --migrate

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Revert "Bump actions/deploy-pages from 3 to 4"

Reverts athackst/jekyll-theme-profile#187

This PR doesn't deploy.  Reverting until issue can be diagnosed.


when drag the map show grid

Description
when drag the map show grid
And if the div is inside other div. it cant drag.
Expected behavior
load the map
Current behavior
dont load the map
Screenshots

Environment

Platform: cordova
Kit: map
Kit Version 5.2.300
OS Version android 10

Hello @alextapia007,
Can you please make sure your App is successfully configured and you have internet connection?
To configure the App information in AppGallery Connect, you can follow the document below:
https://developer.huawei.com/consumer/en/doc/development/HMS-Plugin-Guides/config-agc-0000001050202026
If your problem continues, can you share logs so we can examine the problem in detail?


fix: remove nonReentrant from execute

Use case:
Call from zetachain to evm chain reaches gatewayEVM.execute function which is calling arbitrary function on provided contract. That arbitrary function can call back gateway, eg: gatewayEVM.call gatewayEVM.depositAndCall. Because both execute and call/depositAndCall have nonReentrant modifier, this is not possible currently.
Solution can be to remove nonReentrant from either of those - in this PR for illustration its removed from execute and executeWithERC20 since same applies for this one as well.
Qs:

is it ok, or better to remove from call/depositAndCall since these don't call any other contract? seems like effect is the same
can arbitrary call use delegatecall for gatewayEVM.call/depositAndCall with some edge cases? idea is that gateway dont hold assets so that part should be fine, but might be something else
what about executeRevert and revertWithERC20? these also have nonReentrant but theoretically onRevert might want to call back gatewayEVM - should we allow these type of interactions or be more restrictive in these cases?

Note:
Same issue would apply the other way around when going from connected chain to zetachain, but currently execute functions on GatewayZEVM don't have this modifier, don't remember if it was intentional or just by mistake

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.95%. Comparing base (f29829e) to head (17d9590).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   84.95%   84.95%
=======================================
  Files           8        8
  Lines         412      412
  Branches      138      138
=======================================
  Hits          350      350
  Misses         62       62

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make Gen[Calendar] deterministic.

Previously it was possible for the "current system time" to leak
through into generated Calendar instance (and by extention Date
instances). This was especially painful for generated functions (such
as A => Date) where the function is likely to be evaluated at multiple
different system times.
This PR restructures Gen.calendar to ensure that all instances are
initialized from a generated time (in milliseconds). The code is
cleaned up a bit and a test was added to ensure generation is
deterministic.
Fixes #295.

Looks great!


Error in Cluster Analysis with scratch workspace

When running the Cluster Analysis tool in Incident Analysis toolbox, the following error is returned:
ERROR: Executing: ClusterAnalysis "C:\Data\Defense Solutions\solutions-geoproces
sing-toolbox\utils\test\patterns_tests\data\IncidentAnalysis.gdb\Incidents" "500
 Unknown" "C:\Data\Defense Solutions\solutions-geoprocessing-toolbox\utils\test\
patterns_tests\data\scratch.gdb\outputClusters"
Start Time: Tue Dec 22 13:11:43 2015
Executing (Copy Features): CopyFeatures "C:\Data\Defense Solutions\solutions-geo
processing-toolbox\utils\test\patterns_tests\data\IncidentAnalysis.gdb\Incidents
" C:\Users\juds5059\AppData\Local\Temp\\copy_cluster # 0 0 0
Start Time: Tue Dec 22 13:11:46 2015
ERROR 000210: Cannot create output C:\Users\juds5059\AppData\Local\Temp\\copy_cl
uster
Failed to execute (Copy Features).
Failed at Tue Dec 22 13:11:48 2015 (Elapsed Time: 1.76 seconds)

In the model for Cluster Features, the Output Workspace parameter for the Copy Features tool that is run in the model is hard-coded with %scratchworkspace%\copy_cluster

The error only occurs when running the Cluster Analysis tool in the Incident Analysis Tools.tbx in ArcGIS Pro 1.2. Running Cluster Analysis in the Incident Analysis Tools_10.4.tbx in ArcMap 10.4 works.
Note that changing the Output Feature Class parameter in the Copy Features tool to %scratchGDB%\copy_cluster will make it work.

Verified fixed.


Huge file size in angular build

Bug Report
Current Behavior
Source Map Explorer shows huge rxjs file size if polyfills are commented in angular project.
Before commenting polyfills

After commenting polyfills

Environment

Additional context/Screenshots
Angular polyfill.ts commented

As mentioned in some places modules is already set to es6 in tsconfig.json -> compilerOptions

We don't have pre-build-optimizer.js for argumentoutofrangeerror. This seems bundler / or ng config affects to downlevel rxjs modules.

@kwonoj
Yes pre-build-optimizer.js might be being added by bundler. As I can see it to be present in all of the external(library) js files. But there is also difference in size if polyfills are added back

I feel like this is bundler config specific issue, not an issue of library itself: any specific reason you think this is rx side issues need to be resolved?

closing as lacks of additional info. As stated above, I believe this should belong bundler config issue. Feel free to reopen / create new issue if you have details related with rx core.


Scenario Calculation change

Now for mu, using the weighted average.
For 16th and 84th, using the following formula for getting variance.
Standard deviation from that and 1 above and below is shown for 16th and 84th.

Before: (Different faults, but you get the idea)

After: (Different faults, but you get the idea)

https://github.com/ucgmsim/gmhazard/pull/74#discussion_r885124226
This makes sense. It means that the IM values would be consistent with what we do in the hazard curves.
Joel and I looked at whether the hazard branch combining used ln mean or not and it appeared to not but if the IM_values were already in log space that would make sense.


The column type for LocalDate with the hibernate data addon is generated incorrectly

Reproducing the problem:

Connect io.mix.data:jmix-hibernate-starter
Create a JPA Entity with an attribute of the LocalDate type

Based on the entity, create an editing screen Backoffice -> New -> Screen
Launch the application, a preview of the generated liquibase scripts will open before launching

ER: The field type is equal to the TIME type
AR: The field type is equal to the DATETIME type

There is a similar problem with the LocalDate type, but this type does not cause a problem in runtime.
Problem description:
When generating changesets for liquibase, the _getJavaType method is called
com.haulmont.jpb.db.dll.AbstractLiquibaseGenerator#_getJavaType
Within it, there is an attempt to get a converter for the attribute.

If eclipselink is used, the system does not find the converter and returns null. If hibernate is used, the system finds a converter
https://docs.spring.io/spring-data/data-jpa/docs/current/api/org/springframework/data/jpa/convert/threeten/Jsr310JpaConverters.LocalTimeConverter.html

Then, when using this converter in the com.haulmont.spb.db.dll.AbstractLiquibaseGenerator#getJavaType method, the java.util.Date type is returned

Based on it, the system generates the DATETIME field type in changeset
If eclipselink is used, the converter returns null and the Time type is returned in the com.haulmont.spb.db.dll.AbstractLiquibaseGenerator#getJavaType method.
If you make a stub for checking LocalDate and LocalTime, then script generation occurs in the same way as when using eclipselink.

Jmix framework doesn't support Hibernate.


left menu expand error

Issue type:

[ ] Feature request
[x] Bug report
[ ] Documentation
[ ]  License Compliancy

Environment:
AdminLTE Version: 2.4.2  and  2.4.3
Operating System: All
Browser (Version): All
Description:
if i activate the fixed layout and click the left menu "Multilevel" and it's sub menu severl times, then the error occurred.   The menu expanded above the others.

@almasaeed2010


[BUG] error at package.json

I'm using the github version of Baileys, but it produces errors
node:internal/modules/cjs/loader:453
      throw err;
      ^

Error: Cannot find module<EMAIL_ADDRESS>Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:445:19)
    at Module._findPath (node:internal/modules/cjs/loader:716:18)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1131:27)
    at Module._load (node:internal/modules/cjs/loader:986:27)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/root/jsTools-Bot/lib/myfunc.js:1:19)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32) {
  code: 'MODULE_NOT_FOUND',
  path<EMAIL_ADDRESS>  requestPath: '@whiskeysockets/baileys'
}

Node.js v20.15.1

Baileys, especially when installed from GitHub, doesn't expose the lib/index.js file as its primary entry point. The library uses a different structure for its source files.
1: If you are using the makeWASocket function to create a WhatsApp connection, then you should use the following import statement:
import { makeWASocket } from '@whiskeysockets/baileys';

2: Clear Cache and Reinstall:

Delete your node_modules folder and the package-lock.json file (or yarn.lock if you're using Yarn).
Reinstall the Baileys package using either npm install yourprname (for npm) or yarn add github:yourprname (for Yarn).

Work


Feature: Thank URLs on wiki articles

We want to encourage campers to create wiki articles, and to expand and improve them.
We also want it to be as easy as possible for campers to thank other campers after they read a helpful wiki article.

To this end, I propose that we create a username/thank path, or a /thank/username&username&username path. This way we could put URLs to directly thank campers. The thankor would be the currently authenticated user.
An alternative - if we wanted this to be more visible - would be to create a chatroom called gitter.im/thanks, enable camperbot there, and create URLs to Gitter that pre-populate the message "thank @Rafase282 and @abhisekp".
Now let's talk about abuse. Such a system could be easily abused by a simple chron job. So we would need to place strict limits on how frequently one camper could thank another, or even a global max number of times one camper could thank another (though a crafty abuser could just create brand new accounts every time). One approach might be to make it so, after 5 thanks, only 25% of that user's total thanks could be directed at any given one user - otherwise they wouldn't be persisted.
There may be other avenues for abuse that we need to head off. But I am for making thanking people for their contributions to the wiki as frictionless as possible.

I agree this is ripe for abuse.  We currently have a timeout of 1 thanks per 60 minutes per giver/reciever pair on the Camperbot.  I'm thinking this should have a much longer half-life.  Maybe 24 hours?
My secondary concern is:  How does someone know they've been thanked?  With Camperbot it's really obvious and public, but with this you could be thanked 10 times a day and never know it.  Which is actually kind of a problem on the news as well - you can get upvotes galore but you don't really SEE that.
Maybe a pop-up or a toast when you visit the site:  "You have received XX points from your news article YY since your last visit" or "Camper @BlahBlah thanked you for 'message here'".
Actually, along these lines, it might make sense to have a "Brownie Point History" page linked off the profile page.  Something that displayed a pie-chart of how your got your brownie points as well as a reverse chronological list of recently received points.
Thinking more about this:
This could be an automatically generated link from the new Wiki.  There could be a meta-data section of the file which has "contributors" which the site could parse to generate the link.  Then it could append a &for=Wiki Page Blah Blah to the URL?

Closing as we have moved to the forum and have removed the credits.


Could not copy file name

Description
While trying to copy the file name, it reports an error then shutdown.
Steps To Reproduce

Choose any file.
Press F2 to edit the file name.
Encounter error.

Expected behavior
After copy/edit the file name, click somethere else or press ESC to leave edit mode.
Files Version
Version： <IP_ADDRESS> OS Version: 10.0.19044.1503
Windows Version
Windows 10 Enterprise 21H2 120.2212.4170.0
Relevant Assets/Logs
debug.log
debug_fulltrust.log

Merging with #7996

Could you confirm it only happens in Tiles view?

@gave92 ys, it seems to be.


Delete dashboard should ask for confirmation

Right now deleting a dashboard does not ask for a confirmation. It would be really helpful if there is a confirmation for delete dashboard. I accidentally clicked on the delete button and I couldn't get the dashboard back.

Good point, will have a look and put it to fix.

PR #1608

@Sbrenthughes : can you close this issue

@Sbrenthughes :  we can close this issue


[ncs] bump submodules and update configs

USB support in ncs was changed and requires differen config and build
parameters
Signed-off-by: Marek Porwisz<EMAIL_ADDRESS>

@MarekPorwisz , when this is ready for merge, please change from draft to "ready for review".

couple of certification tests were run on this PR and passed so I think it is ready to be merged. - "undrafted" the PR


Anyway to turn off the top-right size label when resizing

When resizing the window, chrome shows the size on top right corner.  is there anyway to turn it off

Closing the dev tools will turn it off.

work like a charm. lol.


Privileged run does not allow mounting shm tmpfs

/kind bug
Description/Steps to reproduce the issue
If I run a container in privileged mode, then I am not able to do something like this:
> sudo ./bin/podman run --privileged -it saschagrunert/crio-playground
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
5456fb2c96ff:~ # crictl runp sandbox.yml
FATA[0002] run pod sandbox failed: rpc error: code = Unknown desc = error creating pod sandbox with name "k8s_sandbox_default__0": Error committing the finished image: error adding layer with blob "sha256:67ddbfb20a22d7c0ea0df568069e7ffc42378467402d04f28ecfa244e78c5eb8": ApplyLayer exit status 1 stdout:  stderr: permission denied

Describe the results you received:
The image saschagrunert/crio-playground contains a running crio instance in a background tmux session, whereas the session can be attached via tmux at. There we see now:
ERRO[2019-05-24 09:41:07.408490952Z] Error while applying layer: ApplyLayer exit status 1 stdout:  stderr: permission denied
DEBU[2019-05-24 09:41:07.408486735Z] received signal                               signal=broken pipe

Describe the results you expected:
It should work in privileged mode, like with docker:
> docker run --privileged -it saschagrunert/crio-playground
1185702fbcca:~ # crictl runp sandbox.yml
35dca868509a81793feeda06cf668953f93063cd583fdda392facd65e596915a

Output of podman version:
> sudo ./bin/podman version
Version:            1.3.1
RemoteAPI Version:  1
Go Version:         go1.12.5
Git Commit:         7210727e205c333af9a2d0ed0bb66adcf92a6369
Built:              Fri May 24 11:30:31 2019
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: 7210727e205c333af9a2d0ed0bb66adcf92a6369
  go version: go1.12.5
  podman version: 1.3.1
host:
  BuildahVersion: 1.8.2
  Conmon:
    package: podman-1.2.0-1.1.x86_64
    path: /usr/lib/podman/bin/conmon
    version: 'conmon version 1.14.0, commit: '
  Distribution:
    distribution: '"opensuse-tumbleweed"'
    version: "20190521"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>4
  OCIRuntime:
    package: runc-1.0.0~rc8-1.1.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc8
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>8
  SwapTotal:<PHONE_NUMBER>4
  arch: amd64
  cpus: 8
  hostname: nb
  kernel: 5.1.3-1-default
  os: linux
  rootless: false
  uptime: 3h 10m 34.77s (Approximately 0.12 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - quay.io
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 2
  GraphDriverName: btrfs
  GraphOptions: null
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Build Version: 'Btrfs v4.20.1 '
    Library Version: "102"
  ImageStore:
    number: 2
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Must be something different in the way we are setting up /dev versus Docker?
If you volume mount in /dev does it work?
-v /dev:/dev

Must be something different in the way we are setting up /dev versus Docker?
If you volume mount in /dev does it work?
-v /dev:/dev

Hm, no this does not work either:
> sudo podman run --privileged -v /dev:/dev -it saschagrunert/crio-playground
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
WARNING: The same type, major and minor should not be used for multiple devices.
119d46a94f7a:~ # crictl runp sandbox.yml
FATA[0002] run pod sandbox failed: rpc error: code = Unknown desc = error creating pod sandbox with name "k8s_sandbox_default__0": Error committing the finished image: error adding layer with blob "sha256:67ddbfb20a22d7c0ea0df568069e7ffc42378467402d04f28ecfa244e78c5eb8": ApplyLayer exit status 1 stdout:  stderr: permission denied

Although, the warnings should not happen at all, right? Can this be the problem here?
They seem to originate from:
https://github.com/opencontainers/runtime-tools/blob/095789df6c2bc53a9dd4464cda8c22616d66e0d6/generate/generate.go#L1490-L1504

Worked for me on Fedora 30
# podman run --privileged -it saschagrunert/crio-playground
Trying to pull docker.io/saschagrunert/crio-playground...Getting image source signatures
Copying blob 4a7b8e0a5b23 done
Copying blob 70823703d6b7 done
Copying blob 3ce75c405591 done
Copying blob 241c1ade42a5 done
Copying blob 4b3fbce106c6 done
Copying blob d74d3269eed7 done
Copying config ae25b00e57 done
Writing manifest to image destination
Storing signatures
3e410cab4ec6:~ # crictl runp sandbox.yml
266e1208e3fb34369b67a293f2d0afbafd92b34c8b050350b5e7f68c54eba357
3e410cab4ec6:~ #

# podman version
Version:            1.3.1
RemoteAPI Version:  1
Go Version:         go1.12.2
OS/Arch:            linux/amd64

# podman info
host:
  BuildahVersion: 1.8.2
  Conmon:
    package: podman-1.3.1-1.git7210727.fc30.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: c9a4c48d1bff85033b7fc9b62d25961dd5048689'
  Distribution:
    distribution: fedora
    version: "30"
  MemFree: 460554240
  MemTotal:<PHONE_NUMBER>8
  OCIRuntime:
    package: runc-1.0.0-92.dev.gitc1b8c57.fc30.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc7+dev
      commit: d38f8a2d00ff444e52d16ab1ea5bbe5c1cb471e8
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 8
  hostname: localhost.localdomain
  kernel: 5.0.16-300.fc30.x86_64
  os: linux
  rootless: false
  uptime: 144h 19m 56.8s (Approximately 6.00 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 67
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mountopt=nodev,metacopy=on
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "true"
  ImageStore:
    number: 22
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Thanks for trying it out on fedora. I think it could be related to btrfs, but I have to dig deeper into the code now.

@saschagrunert, can you try it out with the latest podman? I assume your're running on openSUSE and we just recently fixed a bug where podman applied the apparmor profile despite the --privileged flag.

So this is Overlayfs running on a BTRFS disk?

I opened up a new issue about the warning: https://github.com/opencontainers/runtime-tools/issues/695


🛠 Tooling: use Remix prerender feature

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Right now, we're doing something a little silly to create static assets for this site:  we use wget and crawl the site, then stick those assets in a separate repo.  This workflow can now use the new prerender feature in Remix instead:  https://github.com/remix-run/react-router/pull/11539
Additional Info
No response

FWIW, the prerender feature isn't released anywhere official yet so this issue probably has to chill for a bit.  Hopefully soon!

@brophdawg11 I'm totally happy to use an experimental preview if one becomes available! :-)

lol this isn’t even experimental territory yet.  This is like pre-alpha of an eventual react router v7 (which is what remix v3 is becoming - pay attention to react conf next week).
There is something that can be used and I’d get a kick out of the Philly JS site being the first one to use this in production….so maybe I’ll take a stab at it.  The steps to upgrade are not yet documented and exist only in our heads haha

YYYYYYYAAAAAAASSSSSSSS thank you @brophdawg11!! 🙌
I also love the idea of us being an early alpha tester kind of project to see how this goes. Marking as accepting prs. Let's see what happens!


subtests (added in Go 1.7) are misparsed as panics

Relevant: https://github.com/tebeka/go2xunit/pull/28
Also, there are no tests in this repo :+1:

@tamird ok, i'll check is soon


CopyFileAsync permission issue

Describe the bug
When I use CopyFileAsync, the created file has -rw------- permissions. But when I use docker cp manually, it's setting permissions to -rwxr-xr-x
To Reproduce
Steps to reproduce the behavior:
var content = File.ReadAllBytes("BackupForDockerImage.bak");
await testcontainer.CopyFileAsync("/var/opt/mssql/backup/BackupForDockerImage.bak", content);

Then open your favorite terminal, attach the docker container, and run ls -l in the copied folder.
You will see -rw------- 1 root root 403886080 Jan  1  1970 BackupForDockerImage.bak
Expected behavior
-rwxr-xr-x 1 root root 403886080 Jul 29 10:09 BackupForDockerImage.bak
Desktop (please complete the following information):

DotNet.Testcontainers version: 1.6.0-beta.1955
.NET Version: v4.7.2

Additional context
Also the file date resetting to 1970 if I use CopyFileAsync
By the way thanks for the library, It's very useful.

CopyFileAsync is an overloaded method. Use the accessMode parameter.
https://github.com/HofmeisterAn/dotnet-testcontainers/blob/8b3860c0bb27d8f82f747fdba07870ef33a18bad/src/DotNet.Testcontainers/Containers/IDockerContainer.cs#L125
rwxr-xr-x should be 493. You need to calculate the integer value from the binary form. Here is an example.

Hi @HofmeisterAn,
Thank you for your quick response, 493 was worked!
Before creating this issue, I've tried with 777 but interestingly 777 is still not working. By the way, I've used this site: https://chmod-calculator.com

but interestingly 777 is still not working

As I said, you need to convert the value (Chmod). The attached link I missleading - sorry.

777 in bit representation is 111 111 111, thats 511 in decimal.
755 in bit representation is 111 101 101, thats 493 in decimal.
644 in bit representation is 110 100 100, thats 420 in decimal.
etc.


dd on SQHresult should delete row

Hi!
I've been tinkering a bit on this issue and found a simple enough way to do it.
The basic idea was to save the current window number(SQHResult buffer) and then jump to the previous one(SQHTable buffer), get the table and database name and return to the result buffer.
But that relays on the user not jumping around the opened windows or closing them.
So I would like to get your input on the matter, if its fine or should I find another way to do it?

Hey jbyte,
I say go for it, the implementation can always be improved as we go on.
I'm interested in how you're going to construct the DELETE query though as not all table will necessarily have primary keys.
Either way, excited to see the result!

I added a explanation in the PR #25.

https://github.com/joereynolds/SQHell.vim/commit/1252fd5249d8439db83b1301fe64fc9b07d33976


Unexpected titlebar behavior on Ubuntu 22.04

I ran into some strange behavior on a fresh install of Ubuntu 22.04.
As you can see from the image, the titlebar decoration does not use the
system default decoration and the title name is not displayed even with the following code:
let mut console = rltk::RltkBuilder::simple(width, height)
            .ok()
            .unwrap()
            .with_title("Rustrl")
            .with_dimensions(width, height)
            .with_tile_dimensions(16, 16)
            .with_advanced_input(true)
            .with_font(term, 8, 8)
            .with_font(vga, 8, 16)
            .with_font(rogueyun, 16, 16)
            .with_font(rogueyunggfx, 16, 16)
            .with_simple_console(width, height, rogueyun) // Tile layer
            .with_sparse_console(width, height, rogueyun) // Feature layer
            .with_sparse_console(width, height, rogueyun) // Item layer
            .with_fancy_console(width, height, rogueyun) // Effect layer
            .with_fancy_console(width, height, rogueyun) // Creature layer
            .with_fancy_console(width, height, rogueyun) // Projectile layer
            .with_fancy_console(width, height, rogueyun) // Gui layer
            .build()
            .ok()
            .unwrap();

I'm assuming that this has to do with the way Bracket-lib is working with a dependency like winit.
I was not able to reproduce the issue on another machine running Ubuntu 20.04.
In addition when running the executable either directly or from a rustrl.desktop file, the name of the application that shows on the top bar says "unknown".
I'm not sure if this is somehow related to the first issue of the name not appearing in the titlebar.

After a little further investigation, it looks like this is an issue with winit.
Ubuntu 22.04 defaults to using wayland and most likely winit has not been
updated to work with it 100%.
This looks like it could be used as a temporary workaround.

You can force xwayland usage with env var WINIT_UNIX_BACKEND=x11, see docs.
#rust-windowing/winit/issues/1967

Is this something that would need to be done with Bracket-lib's cargo.toml or mine?


#708 broke Org recipe on Mac with ZSH

FYI, the change in #708 has broken my ability to build org on emacs on a mac with ZSH as my shell because of how ZSH handles globbing.
Perhaps straight-recipes-org-elpa--build could be a windows-only operation?
Core issue:
(let ((shell-file-name "/bin/zsh")
      (default-directory "~/.emacs.d/straight/repos/org"))
  (prin1 (shell-command-to-string "git describe --match release\* --abbrev=0 HEAD"))
  (prin1 (shell-command-to-string "noglob git describe --match release\* --abbrev=0 HEAD"))
  (setq shell-file-name "/bin/bash")
  (prin1 (shell-command-to-string "git describe --match release\* --abbrev=0 HEAD"))
  nil
  )
"zsh:1: no matches found: release*
""release_9.4.4
""release_9.4.4

Originally posted by @cwhatley in https://github.com/raxod502/straight.el/issues/707#issuecomment-792812751

@cwhatley: Thanks for bringing this to my attention. I will look into it ASAP.

Perhaps straight-recipes-org-elpa--build could be a windows-only operation?

If the issue is with ZSH and globbing, Windows users may still be affected by this same bug.
I may have made an error when translating that command over from Org's makefiles.
I'll do some testing and see if I can work out a solution that is operating system independent and works with bash/zsh.
In the meantime, you can override the :pre-build steps in your init with the previous steps as a workaround:
(straight-use-package
 '(org-plus-contrib
   :type git
   :repo "https://code.orgmode.org/bzg/org-mode.git"
   :local-repo "org"
   ;; `org-version' depends on repository tags
   :depth 'full
   :pre-build ("make" "autoloads")
   ;; Org's make autoloads generates org-version.el
   :build '(:not autoloads)
   :files ( :defaults
            "lisp/*.el"
            ("etc/styles/" "etc/styles/*")
            "contrib/lisp/*.el")
   :includes org))

I think you copied the command over just fine. Since building org by hand creates org-version just fine with the same command, I think the core difference is that GNU make uses /bin/sh unless you define a SHELL in your makefile.
https://www.gnu.org/software/make/manual/make.html#Recipes

Also, durr on my part... just single-quote the pattern: 'release*'
(let ((shell-file-name "/bin/zsh")
      (default-directory "~/.emacs.d/straight/repos/org"))
  (prin1 (shell-command-to-string "git describe --match release\* --abbrev=0 HEAD"))
  (prin1 (shell-command-to-string "noglob git describe --match release\* --abbrev=0 HEAD"))
  (prin1 (shell-command-to-string "git describe --match 'release*' --abbrev=0 HEAD"))
  (setq shell-file-name "/bin/bash")
  (prin1 (shell-command-to-string "git describe --match release\* --abbrev=0 HEAD"))
  (prin1 (shell-command-to-string "git describe --match 'release*' --abbrev=0 HEAD"))
  nil
  )
"zsh:1: no matches found: release*
""release_9.4.4
""release_9.4.4
""release_9.4.4
""release_9.4.4
"nil


Multiple commands do not work

Looks like commands from Command Palette Plus that call promptPathAndCallback break.
from slack
eg:

Open Page in Sidebar (ops)
Move Block Commands
Send Commands
etc

The dialog shows up

Then
Console Error
instrument.ts:132 Error: Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at Bg (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:372:1)
    at ff (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:321:126)
    at setValue (FormDialog.tsx:255:21)
    at AutocompleteInput.tsx:110:16
    at Gl (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:396:450)
    at main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:210:257
    at rh (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:279:286)
    at Kk (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:395:380)
    at Jg (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:377:257)
    at main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:280:14
    at main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:210:257
    at rh (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:279:286)
    at gi (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:279:468)
    at Sh (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:279:401)
    at Gl (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:397:143)
    at main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:210:257
    at rh (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:279:286)
    at Kk (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:395:380)
    at main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:395:284
    at h (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:205:79)
    at MessagePort.<anonymous> (main.js?__WB_REVISION__=a483756fb07b148177a1ff2101901681:208:334)

ah this is related to the AutocompleteInput changes probable. Remind me tomorrow "on stream" so we could patch it then

I think this might be due to an older version of roamjs-components - I've upgraded the dependency, let's recheck whether or not this is an issue


CodeClimate asks for more permissions than it probably needs

While working on GlobaLeaks i've found that CodeClimate would be a valuable tool to be integrated within the set of our on-commit CI and code quality metrics, but what from i'm viewing right know CodeClimate is asking really for too much permissions and this prevents our adoption (https://github.com/globaleaks/GlobaLeaks/issues/1265).

Landscape.io that makes the same work using a python linter require really less and more precise permissions:

Hi @evilaliv3, sorry for the delayed response here. We recently re-worked how and when we ask for the OAuth scopes we need. In doing so, I believe this issue is addressed. Feel free to re-open if that's not the case.

This seems to have been closed incorrectly.
Code climate still needs for write access to repositories.
github's roadmap lists granular access permissions, so it seems that it will be possible to properly fix this soon: https://developer.github.com/early-access/platform-roadmap/

I agree with @nallar; i still consider this as an important improvement to be applied.


gds_image replacement/workaround?

I noticed that there was a function "gds_image" where you could take the images created from the cells in the "LayoutViewer" and export them as images. Is this still possible through gdspy? Or is there a solution better than what there was before?

@McCrearyD This function was removed because it was not the main purpose of gdspy to create images.
There's currently no replacement for it, but you can either take a screenshot from LayoutViewer or take a look into the draw function in makeimages.py (this is a helper for generating the docs that creates images using PIL). It probably contains all the code you need to write your own version of gds_image.

I actually ended up making my own script to do so. It just generates a numpy array of a specific width, height, & depth and fills the slots in with their data types etc.

If anyone is interested, here is that script: https://gist.github.com/McCrearyD/f0d156ae7b14ee2bb8c51587e2c7adad


Make the Datepicker component more reusable

Problem
The NewDatePicker component has went trhough couple of iterations and its time to refactor it and mainly make it easier to reuse in other flows and pages of the app. Some context in this thread
Why is it important?
We are adding more flows which require a date picker component, however, the current implementation is hard to just take and plug into some other form with different routes so it just works. For example in this PR we need to make it easy to implement a date picker to a request details page
Solution
Explore how we can simplify this component so we keep the current functionality and design ideally while improving the DX.
cc @Beamanator @burczu @WoLewicki @adamgrzybowski @s77rt @luacmartins

Asking Bartek if he wants to tackle this one tomorrow as they originally worked on this issue

Hi I'm Bartek from Callstack - expert contributor group - I would like to work on this issue.

I would gladly review the part with subscribing to navigation and the information flow in those components 😅

Nice, I will assign you too, its important issue to get done right

@burczu previously, we wanted the Year page to be its own route with the psuh-to-page design which is quite complicated.
Could we potentially make this page "internal" to the datepicker route so it looks same as a new page in the stack. This might introduce issues with the navigation tho to keep the browser back and in-app Up actions consistent.
Maybe we could also disallow deeplinking to the year page which could help with some edge cases so that when you try to access the year page by using deeplink it would redirect to the date picker first.
Not sure whats the best way but lets brainstorm our options

not overdue

In my opinion, it's a great decision to eliminate the persistence of the calendar state upon reloading. The current implementation relies on having a separate route for the list of years in the calendar because it uses navigation.
However, in most common websites that utilize a calendar picker, there is no state persistence. Removing it would make the code more reusable and much easier to maintain

Thanks for chiming in @ArekChr. I agree this will make the Datepicker better component from the developer perspective and there is questionable benefit from having the state persistance. Its in theory nice for users that the state is not lost but we dont really have any data or proves users would be running to this issue, they will most likely "get it".

Yes @mountiny, I will work on that.

Proposal
Proposal
Problem Statement
The New Date Picker component has gone through several iterations, and refactoring is necessary to improve reusability across various flows and pages within the application.
Root Cause
The main issue lies in implementing the year list picker as a separate screen using react-navigation. This approach introduces additional complexity when navigating between the calendar and the year picker, resulting in various problems and regressions.
Proposed Solution
To address the problem effectively, I propose the following changes:

Refactor the push-to-page screen to be a view within the calendar component. Integrating the year list picker directly into the calendar can eliminate complex navigation logic and simplify the overall implementation. This step includes:

Removing all related navigation logic in YearPickerPage and value selectedYear that comes from route props in DateOfBirthPage
Implementing a new logic to pass states between the list and calendar through props. Since navigation is removed, the following props in CalendarPicker will be removed: selectedMonth, selectedYear and onYearPickerOpen function. These props will be handled inside the CalendarPicker. Managing the state through props simplifies the use case, improves readability, and provides better testing possibilities for the year list picker.
Implementing an animation replicating the push-to-page screen's behaviour using reanimated. This ensures a seamless transition between the calendar and the year list, enhancing the overall usability of the component.

Refactor the folder structure to improve component readability. Move the CalendarPicker folder into the NewDatePicker folder to ensure better organization and eliminate unused components.
Refactor prop types as suggested in the discussion https://github.com/Expensify/App/pull/15343#discussion_r1162163822. Move all prop types from the new date picker to its component since they are not exported elsewhere.
Improve test coverage by utilizing the react-native-testing-library (RNTL). Add specific tests for selecting a year using the year picker within the calendar. This will facilitate easier testing of the year picker functionality and increase confidence in its behaviour.
Introduce regression tests using RNTL and reassure to measure render counts and execution time when selecting a year and month and switching between months using arrow buttons. Monitoring these metrics will ensure optimal component performance and help identify potential regressions.

Implementing these proposed changes will enhance the reusability, maintainability, and overall quality of the NewDatePicker component. It will simplify the implementation, improve user experience, and increase test coverage, resulting in a more robust and reliable solution.

@ArekChr Thanks for the proposal, I think the plan looks good. I think the regression tests might not be that necessary at first they can come in a separate PRs for sure.
Lets ensure the UI of the page and animation using reanimated looks same as other page transitions.
Additionally I will ping @JmillsExpensify and @shawnborton here as they have been part of the previous discussions about the NewDatePicker component.
Do you have any concerns about the Year selector not being its own page anymore? It will simplify the code drastically, make it easy to reuse and understand which we both lack now. We doubt that the UX will be degraded. In case of Expense created date, users rarely even have to change year of the created date.

Great, so the regression tests from point 5 will be excluded.

If the year picker is no longer push to page, how will it work exactly?

From a UX perspective, I am going to implement the same animation of pushing the page, so the user will not notice any UI difference.
From a DX perspective, the screen will be removed from the navigation stack.

Ah got it, that seems fine to me.

Makes sense to me too, there will be no more tricky behaviors connected to navigation and parsing of URLs.

The main difference from user perspective is that if user navigated to the year picker and they refresh, the year picker is closed as its not its own page and similarly they cannot deeplink to it. I think honestly its better since there is many edge cases we had to be considering before with the ability to deeplink etc.

Yeah, seems like there are only upsides of this new approach if it is implemented correctly 🚀

Hi there,
Just to give you an update: I've removed the YearPickerPage from the navigation. At the moment, I'm focused on implementing the animation. I'm utilizing the Layout Animation API from Reanimated, but I've encountered an issue with the exiting animation.
The problem is that the exiting animation doesn't seem to work at all after the component unmounts. I've set the entering animation to SlideInRight and the exiting animation to SlideOutLeft. However, while the component is unmounting, I receive a warning message:
Warning: Overriding previous layout animation with new one before the first began: <RCTLayoutAnimationGroup: 0x60000148f060; creatingLayoutAnimation: (null); updatingLayoutAnimation: <RCTLayoutAnimation: 0x6000001b8900; duration: 0.250000; delay: 0.000000; property: (null); springDamping: 0.000000; initialVelocity: 0.000000; animationType: 5;>; deletingLayoutAnimation: (null)> -> (null).
@WoLewicki, do you happen to know any potential solutions for this issue? If not, I'll implement own animation logic of sliding the container from right to left when mounting and right to left when unmounting.
The current implementation is below:
{this.state.isYearPickerVisible && (
    <Portal hostName="RightModalNavigator">
        <ScreenSlideAnimation>
            <YearPickerPage
                onClose={() => this.setState({isYearPickerVisible: false})}
                min={moment(this.props.minDate).year()}
                max={moment(this.props.maxDate).year()}
                currentYear={parseInt(this.state.selectedYear, 10)}
            />
        </ScreenSlideAnimation>
    </Portal>
)}

And here is the function ScreenSlideAnimation:
function ScreenSlideAnimation({children}) {
    return (
        <Animated.View
            key="yearPicker"
            entering={SlideInRight}
            exiting={SlideOutLeft}
            style={StyleSheet.absoluteFillObject}
        >
            {children}
        </Animated.View>
    );
}

Does it only happen on the last screen? Or for the one with calendar also?

I have asked SWM for help on this one

Also, how will it work on web? IIRC, LayoutAnimations are not supported there. I can see that the App uses react-native-animatable in some of similar flows.

Does it only happen on the last screen? Or for the one with calendar also?

This happen only in the Year Picker

Hello, I wanted to share my update. The refactoring is complete, and the only missing step is animation. I have rewritten the animation using a basic reanimated API. It works well on mobile devices, but I am encountering issues on the web where the entire window moves when the animation starts. This screen is nested near RigthModalNavigator using Portal. @WoLewicki, do you know why this is happening on the web or how to fix that?
The location where the YearPicker component is sent is within the RigthModalNavigator function, specifically inside the PortalHost component.
function RigthModalNavigator() {
    return (
        <>
            <Stack.Navigator>
                {/* other screens */}
            </Stack.Navigator>
            <PortalHost name="RigthModalNavigator" />
        </>
    );
}

Year Picker Animation
const height = Dimensions.get('window').height;

const ScreenSlideAnimation = React.forwardRef(({children, testID}, ref) => {
    const [visible, setVisible] = React.useState(false);
    const translateX = useSharedValue(height);

    React.useImperativeHandle(
        ref,
        () => ({
            close: () => {
                translateX.value = withTiming(height, {duration: 500}, (finished) => {
                    if (!finished) {
                        return;
                    }
                    runOnJS(setVisible)(false);
                });
            },
            open: () => setVisible(true),
        }),
        [],
    );

    React.useEffect(() => {
        if (!visible) {
            return;
        }
        translateX.value = withTiming(0, {duration: 500});
    }, [visible]);

    const animatedStyle = useAnimatedStyle(() => ({transform: [{translateX: translateX.value}]}), [translateX.value]);

    if (!visible) return null;

    return (
        <Portal hostName="RigthModalNavigator">
            <Animated.View
                testID={testID}
                style={[StyleSheet.absoluteFillObject, animatedStyle]}
            >
                {children}
            </Animated.View>
        </Portal>
    );
});

https://github.com/Expensify/App/assets/24796318/2f1f7540-6591-487c-a236-9d38f5be13ac
https://github.com/Expensify/App/assets/24796318/641ad55e-3274-4c44-826f-98f4b8635a44

Assinging Fedi as a C+ from the PR.
Arek is ooo for two weeks so someone else from Callstack will take over
SWM was not able to reproduce the issue with the animation on the year picker

Hey! I'm Thiago from Callstack - expert contributor group - and I will be taking this over from Arek while he is OOO
I'm somewhat familiar with the work done here, but let me read through everything and take a closer look at the PR changes before answering further 🙇🏻

Sending updates in the PR

More updates in the PR :)

No

@kevinksullivan this should be $1000 to @fedirjh for review and testing. thank you 🙇

@kevinksullivan this is ready to be paid

Just labeling to get the upwork job set up.

Offer sent @fedirjh ^^ . Let me know when you accept!

Woo! Awesome work on this one. Excited to have it in the wild.

@kevinksullivan All done here, can we close this?

All set / paid


This guide is brilliant!

Clear and concise - I hope this guide can serve as best practice for other Power BI related guides!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf55ca48-9d24-4a87-0f90-b660d3d0ca50
Version Independent ID: 09e9b1e9-82b6-3efd-7b77-040c284b917b
Content: Use shared datasets in Power BI Paginated Report Builder - Power BI
Content Source: powerbi-docs/report-builder-shared-datasets.md
Service: powerbi
Sub-service: report-builder
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @Mholsen . Your feedback has been passed along to the doc author for review.

Thanks so much, @Mholsen! Glad it helped. I have to say it's one of my favorites, too.


Occasional large delays when connecting to multiple peripherals

Using Bluetoothctl I can connect to 3 peripherals in parallel without additional delays. So one connection takes 3-6 seconds (we have some really constrained connection parameters on our peripherals) and for 3 peripherals it still takes 3-6 seconds per connection.
With gatt-python we're seeing extreme large delays but not always... . For instance on an average of 10 connect/disconnect cycles with 3 peripherals: Average total connection duration 135.988185 seconds with a min/max value of 8/263.836915 seconds. So sometimes it only takes 8 seconds but it can also take 263 seconds. Very inconsistent and hard to debug.
I presume it's rather D-Bus related or perhaps gatt-python performs some additional load on D-bus?
I'm struggling really hard to debug this because when waiting for 200+ seconds on an connect_xxx callback there are no entries in bluetoothd and dbus-monitor logs. So the system hangs and there is not a single indication of why this is happening.

I can't really tell by looking at the gatt-python source code, but could this be related?
https://github.com/adafruit/Adafruit_Python_BluefruitLE/issues/11

Hi, any update in this issue? I'm struggling with the same problem.