Pre-compiled aarch64 binaries for Linux

Currently all builds are only for AMD64 platforms. It would be nice to have aarch64 builds.

For which platform?
If it's for Mac M1 then it's supported and the build should work as described in INSTALL.md. There are no pre-compiled binaries yet since GitHub doesn't provide an M1 machine in GitHub Actions.

For which platform?
If it's for Mac M1 then it's supported and the build should work as described in INSTALL.md. There are no pre-compiled binaries yet since GitHub doesn't provide an M1 machine in GitHub Actions.

For Linux. Manually compiling worked but it took some time.

2nd the request for prebuilt linux arm64. I got it to compile, but yeah took a while.
BTW, successfully using the libcurl .so files with node-libcurl's build-from-source option for Node (using the LD_PRELOAD trick), which is sweet.

For Linux. Manually compiling worked but it took some time.

Alright, I'll edit the title to make it clearer.

BTW, successfully using the libcurl-impersonate .so files with node-libcurl's build-from-source option for Node (using the LD_PRELOAD trick), which is sweet.

@A-Posthuman I think this information would be of use to other devs as well. If you want to write a manual detailing the steps I could then add it to the repo.

The steps I followed to install node-libcurl, using npm, on ubuntu 20.04:

first get curl-impersonate compiled/installed
install node-libcurl building dependencies: sudo apt-get install python libcurl4-openssl-dev build-essential
make a libcurl.so symbolic link to use during compilation (I linked to the chrome.so, haven't tested this with the ff one): sudo ln -s /usr/local/lib/libcurl-impersonate-chrome.so.4.7.0 /usr/local/lib/libcurl.so
export LD_PRELOAD=/usr/local/lib/libcurl.so
export CURL_IMPERSONATE=chrome101
node-libcurl's build instructions explain you can override the linker's flags during the build using "--curl-libraries", so the command to build and install it that worked for me: npm install node-libcurl --build-from-source --curl_libraries='-Wl,-rpath /usr/local/lib -lcurl'

Check the node-libcurl build instructions and its source code for more details on how to adjust this for other platforms.

@jlarmstrongiv Do you mean you want the curl-impersonate Docker image on DockerHub to support arm64?
Regarding the pre-compiled binaries, I'm going to try and cross-compile from Ubuntu, hopefully it will be a simple addition to the CI scripts. Updates soon.

@lwthiker

Regarding the pre-compiled binaries, I'm going to try and cross-compile from Ubuntu, hopefully it will be a simple addition to the CI scripts. Updates soon.

Awesome 🚀 looking forward to it

Do you mean you want the curl-impersonate Docker image on DockerHub to support arm64

Oh yes, the docker/setup-qemu-action@v2 lets you build docker images for multiple architectures

Pre-compiled arm64/aarch64 binaries are now available here:
https://github.com/lwthiker/curl-impersonate/releases/tag/v0.5.1
and will be built automatically for each new release in the future.
Docker images are still not built for arm64 though, so I'm going to leave this issue open.

The steps I followed to install node-libcurl, using npm, on ubuntu 20.04:
* first get curl-impersonate compiled/installed

* install node-libcurl building dependencies: sudo apt-get install python libcurl4-openssl-dev build-essential

* make a libcurl.so symbolic link to use during compilation (I linked to the chrome.so, haven't tested this with the ff one): sudo ln -s /usr/local/lib/libcurl-impersonate-chrome.so.4.7.0 /usr/local/lib/libcurl.so

* export LD_PRELOAD=/usr/local/lib/libcurl.so

* export CURL_IMPERSONATE=chrome101

* node-libcurl's build instructions explain you can override the linker's flags during the build using "--curl-libraries", so the command to build and install it that worked for me: npm install node-libcurl --build-from-source --curl_libraries='-Wl,-rpath /usr/local/lib -lcurl'

Check the node-libcurl build instructions and its source code for more details on how to adjust this for other platforms.

have someone tried it? I installed all, it works in terminal, but i cant access same website in node libcurl

node-libcurl with curl-impersonate's libcurl works for me, yes.

node-libcurl with curl-impersonate's libcurl works for me, yes.

You got discord or telegram brother? i need your help willing to pay you.

The steps I followed to install node-libcurl, using npm, on ubuntu 20.04:

first get curl-impersonate compiled/installed
install node-libcurl building dependencies: sudo apt-get install python libcurl4-openssl-dev build-essential
make a libcurl.so symbolic link to use during compilation (I linked to the chrome.so, haven't tested this with the ff one): sudo ln -s /usr/local/lib/libcurl-impersonate-chrome.so.4.7.0 /usr/local/lib/libcurl.so
export LD_PRELOAD=/usr/local/lib/libcurl.so
export CURL_IMPERSONATE=chrome101
node-libcurl's build instructions explain you can override the linker's flags during the build using "--curl-libraries", so the command to build and install it that worked for me: npm install node-libcurl --build-from-source --curl_libraries='-Wl,-rpath /usr/local/lib -lcurl'

Check the node-libcurl build instructions and its source code for more details on how to adjust this for other platforms.

Just after you done all of this, can you send any example of JS to run actually the code?

I set some env vars, then just use it similarly to how you can normally use node-libcurl:
process.env.LD_PRELOAD = '/usr/local/lib/libcurl.so';
process.env.CURL_IMPERSONATE = 'chrome107';
process.env.CURL_IMPERSONATE_HEADERS = "no"; // use our own headers, or comment this line out to use curl-impersonate's default headers

// this is for allowing use of the old "require"-style module imports
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { curly } = require('node-libcurl');
import fs from "fs/promises";

// I have some basic session management where I create more than one node-libcurl curly object, but to simplify:
let cookieJarFile = `/home/ubuntu/some/path/to/file.txt`;
let fd = await fs.open(cookieJarFile, 'w'); // wipe the cookie jar file from previous run
await fd.close();
sessionCurl = curly.create({ cookieFile: cookieJarFile, cookieJar: cookieJarFile, cookieList: 'ALL', followLocation: true })
// I have my own array of header strings I use instead of the curl-impersonate default
response = await sessionCurl.get('https://www.somewebsite.com/', { cookieList: 'ALL', HTTPHEADER: headers }); // on very first request, make sure to start with empty cookies
if (response.statusCode === 200) {
   content = response.data;
   // process data as desired
}

I set some env vars, then just use it similarly to how you can normally use node-libcurl:
process.env.LD_PRELOAD = '/usr/local/lib/libcurl.so';
process.env.CURL_IMPERSONATE = 'chrome107';
process.env.CURL_IMPERSONATE_HEADERS = "no"; // use our own headers, or comment this line out to use curl-impersonate's default headers

// this is for allowing use of the old "require"-style module imports
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { curly } = require('node-libcurl');
import fs from "fs/promises";

// I have some basic session management where I create more than one node-libcurl curly object, but to simplify:
let cookieJarFile = `/home/ubuntu/some/path/to/file.txt`;
let fd = await fs.open(cookieJarFile, 'w'); // wipe the cookie jar file from previous run
await fd.close();
let sessionCurl = curly.create({ cookieFile: cookieJarFile, cookieJar: cookieJarFile, cookieList: 'ALL', followLocation: true })
// I have my own array of header strings I use instead of the curl-impersonate default
response = await sessionCurl.get('https://www.somewebsite.com/', { cookieList: 'ALL', HTTPHEADER: headers }); // on very first request, make sure to start with empty cookies
if (response.statusCode === 200) {
   let content = response.data;
   // process data as desired
}

sadly i get
Segmentation fault (core dumped)
:( i dont know what to do for real.

One thing I thought of is in my example I am using the most recent curl-impersonate source which supports chrome107, but if you happen to be using the precompiled binaries (version 0.5.3 was the last release of those), those only would support up to chrome104. Trying to pass chrome107 to that older version might cause a core dump. If you aren't sure what version you have, see if you have the curl_chrome107 script installed: whereis curl_chrome107
Does running the curl_chrome104 script work to fetch a URL? Or does that also segfault?
Also I don't know if it matters, but in addition to setting the env vars in my program, I also set them in the shell beforehand:
export LD_PRELOAD=/usr/local/lib/libcurl.so
export CURL_IMPERSONATE=chrome107
Node version may also matter? Not sure, but I've read somewhere that for best compatibility and least core dumps, you want node/node-libcurl/curl-impersonate all to be using the same or similar OpenSSL version?
I'm using Node 18.12.1 on ubuntu 20.04 if that helps. Running the command "openssl version" reports: OpenSSL 1.1.1f  31 Mar 2020
And of course be sure you have that symlink setup properly where /usr/local/lib/libcurl.so points to the latest curl-impersonate chrome library. On my system that points to: /usr/local/lib/libcurl-impersonate-chrome.so.4.8.0
If any of those ideas solves your issue, please report back.

Nope this is not really using curl impersonate, and after a deep research i found out its not possible to bind curl impersonate with NodeJS.

And of course be sure you have that symlink setup properly where /usr/local/lib/libcurl.so points to the latest curl-impersonate chrome library. On my system that points to: /usr/local/lib/libcurl-impersonate-chrome.so.4.8.0

@A-Posthuman  can you please elaborate more?
I mean where can I actually find this libcurl-impersonate-chrome.so.4.8.0 particular file in linux.
I've followed your above steps to install node-libcurl in linux. But I'm facing issue during swapping of curl bins. Maybe due to symlink is not been configured properly.

Hi I'm interested in this, did anyone got it works? or not possible?


Move to @shelljs.

Hi @IvantheDugtrio!
I was wondering if you'd consider allowing us to move this project in to the shelljs org? I've been trying to put more of an emphasis on performance in shelljs, and this tool looks really useful.
We would of course love for you to continue working on the project, and you would have full control of it.
Thank you for your consideration
cc @nfischer.

Hi @ariporad
I'd be happy to move the project to shelljs org. I'll get around that sometime this weekend.

@IvantheDugtrio: Thanks so much!
I invited you to the shelljs org, and I think that should be ok for transferring it, if not, let me know.

@ariporad I had @IvantheDugtrio transfer it to me, so I should be able to then transfer it to the org right now.

@nfischer: Fantastic! Can you give @shelljs/bench admin perms?

Done :+1:

Fantastic! Thanks!


Improved compatibility with future non/algebra traits.

Follow-up of #353
Correcting also Action syntax that was lost in the merge.

Wow, either I'm messing up my trees, or GitHub does not like so much overlapping PRs.
Can you please merge this correction as soon as possible, and I will restart #357 from scratch ?

Looks great, thanks!


[GAIA Compiler] Build algebra layer structures for filter and project in GraphBuilder

What do these changes do?

Related issue number

Fixes

Codecov Report

Merging #2482 (013f8d6) into main (d6bde76) will decrease coverage by 32.54%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2482       +/-   ##
===========================================
- Coverage   72.48%   39.95%   -32.54%
===========================================
  Files          88       88
  Lines        9769     9769
===========================================
- Hits         7081     3903     -3178
- Misses       2688     5866     +3178

Impacted Files
Coverage Δ

...ython/graphscope/tests/unittest/test_cython_ast.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_serailaize.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

python/graphscope/tests/unittest/test_app.py
0.00% <0.00%> (-96.32%)
:arrow_down:

python/graphscope/tests/unittest/test_lazy.py
0.00% <0.00%> (-96.22%)
:arrow_down:

...thon/graphscope/tests/unittest/test_scalability.py
0.00% <0.00%> (-96.16%)
:arrow_down:

...hon/graphscope/tests/unittest/test_create_graph.py
0.00% <0.00%> (-92.89%)
:arrow_down:

python/graphscope/tests/unittest/test_graph.py
0.00% <0.00%> (-85.92%)
:arrow_down:

python/graphscope/tests/unittest/test_context.py
0.00% <0.00%> (-81.36%)
:arrow_down:

python/graphscope/analytical/udf/wrapper.py
27.27% <0.00%> (-72.73%)
:arrow_down:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c074dd6...013f8d6. Read the comment docs.


Typescript server repetitively "initializing language features" causing high CPU usage at idle

Type: Bug
Description
When working in a Svelte repository with a TS and Svelte file open, VSCode begins rapidly flashing the "initializing JS/TS language features" notification in the bottom LH bar. I also notice the notification bell in the bottom RH bar flickering on and off with a new notification.  This drives high CPU usage and noticeably slows down intellisense in my repo.
This behavior doesn't appear to be linked to any user input other than opening both *.svelte and *.ts files concurrently, and it will continue indefinitely until the VSCode instance is restarted. Running the "Typescript: Restart Language Server" command will temporarily halt the behavior, but it resumes within 30s afterward. If TS logging is turned on, the logs will grow indefinitely in size (in one instance I had a 2GB log file in <5 minutes).
Would anyone be able to suggest a potential next troubleshooting step?
Troubleshooting Attempts

Restart TS Language Server
Restart VSCode
Clean Install of VSCode
Update to latest nightly version of TS

Versioning
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T16:59:02.252Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
TypeScript: 4.9.4 and 5.0.0-dev (observed behavior in both versions)
Logs
tsserver.log

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.71GB (16.00GB free)

Process Argv
--folder-uri file:///c%3A/Users/65166/Documents/Code/peg-python-data-automation --crash-reporter-id c471dd02-b8fc-45d0-b70a-bf8322916dc3

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

svelte-vscode
sve
107.0.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1:30587005
3biah626:30602489
f6dab269:30613381
fim-prod:30623723

If this only happens with the svelte extension enabled, please start by filing this issue against them


cluster

Hi,
Thanks for your impressive work, but I just wonder why you set cluster number to 5 for instance segmentation, and what does this value mean? Thanks a lot.
net_ins = tf_util.conv1d(net_ins, 5, 1, padding='VALID', activation_fn=None, scope='ins_fc4')
Best Regards
Frank

Hi, here the 5 is the dimention of instance embeddings, not cluster number. It means that each point is represented by a 5-dim vector, as its instance embedding.


New (updated) Docker container for slack-irc

Hi, I've took a peek at existing slackbridge Docker container https://github.com/caktux/slackbridge and found out it's ancient to say at least (Ubuntu Willy, NodeJS 5.x, runs slack-irc as root, doesn't use Compose etc.). I've forked and updated the project accordingly here:
https://github.com/dkorunic/slackbridge
I would appreciate if you could link to that project too. Thanks!

@dkorunic Your fork appears to be deleted now. Maybe close this issue?

Absolutely.


ci: reinstate the passwd tests for the no-cached-fetch run.

By selectively skipping the high round test cases, the out of memory problem
can be avoided.
partially fixes #16127

[ ] documentation is added or updated
[x] tests are added or updated

reinstate is probably the wrong word in the title.

Are you sure?  It's the word I was looking back: to put back.
What alternative would you suggest?

Ahh the '-' means exclude it... my mistake

Yep, it was excluded and is now mostly back :)

does it make sense to only limit the search during this one problematic test run, perhaps via an env var?

I would have said "restore" fwiw.

Isn't that exactly that is happening with the if disabled("cached-fetch") part?

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged, thanks for the reviews.


appsignal-agent memory leak

We are noticing an issue where it appears the the Appsignal agent has a memory leak.
Our devops team notified us that one of our pods our Kubernetes cluster was infinitely growing in memory until it would restart. This has been consistently happening through multiple restarts.
We have other pods that are also running the Appsignal agent that are not having this error. There is no obvious difference in how this is being ran.
When investigating, the found a process with name: appsignal-agent was using about 4gb of ram.
This is running on ARM.
I'm wondering if this is something that anyone has ran into before? Or if there is an obvious answer to why this is happening?

Hi @sethbuff,
That should definitely not happen. Could you reach out over at<EMAIL_ADDRESS>We'd be interested in taking a look at the contents of the /tmp/appsignal.log file in the affected pod.
To confirm, is the affected pod using the AppSignal for Python integration, a different AppSignal integration, or the AppSignal stand-alone agent? And are the unaffected pods also using the AppSignal for Python integration?

I can do that!
All pods are using the AppSignal for python integration. We are also starting it the same way in all the pods using appsignal.start()

https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/4356044/conversation/16410700367607?view=List (private link)

Just following up...
This issue was caused by us instrumenting a long running process. We accidentally instrumented the entry point function of one of our workers which would never close. That caused the memory to grow indefinitely.
We solved the issue be removing the instrumentation of that function.

I followed up on Intercom. Let's close the issue here for now. If this is an issue in the agent, let's create a new issue in that (private) repository.

Issue resolved in our support chat. The thing that caused the perceived memory leak was a trace that never closed. The trace's root span was started at the time the process started and would only close if the process ended. The process did not have a predicatable life time, it would just keep running until a new version would be deployed or god forbid it crashed. Instead of instrumenting the entire lifetime of the process, the solution was to start a new trace per tick or item processed.
Code example:
class Worker:
    def process_queued_items():
        # Start new trace here

    def run():
        # Do not start a trace here
        while True:
            self.process_queued_items()


Apollo

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):

系统信息Linux Ubuntu 18.04）：
阿波罗版本：5.5
具体问题：
再执行官方教程中的显卡驱动安装时，执行完cat /proc/driver/nvidia/version，显示有430.50的字样；但是接着执行sudo dpkg --list | grep nvidia*，却没有任何输出，且在终端输入nvidia-smi，最下面一行出现出现No running processes found的相关字样，且输入nvidia-settings也无法调出显卡驱动安装界面。我已经反复试过很多次了，一直如此，希望大家能帮助我。谢谢~

您参考的是Apollo开发套件产品文档，如果您购买了该产品，可以通过以下入口获取技术支持 http://ufo.baidu.com/listen/myhistory?type=commonQA&product_line=90965&appid=240308#?qid=186


1.15.3 "Import Cycle Not Allowed" on convnet example w/ Cuda

Hello,
I get the following error when trying to run the convnet cuda example.
package command-line-arguments
	imports gorgonia.org/gorgonia
	imports gorgonia.org/gorgonia: import cycle not allowed

My file structure is as below;
├── project
│ ├── convnet.go
│ └── cudamodules.go

Note that if I roll back Go to 1.13.9 (Which is fine so by no means urgent), this error does not present itself.
However...
Without piggybacking too much of this issue for another, when I run the following command in the project directory, on version 1.13.9, I get the following output which indefinitely hangs.
>>>/usr/local/go-1.13/bin/go run -tags='cuda' .
2020/10/21 10:03:07 Using CUDA build
2020/10/21 10:03:07 gorgonia. true
2020/10/21 10:03:08 p0 (100, 32, 14, 14)
2020/10/21 10:03:08 p2 shape (100, 128, 3, 3)
2020/10/21 10:03:08 r2 shape (100, 1152)
2020/10/21 10:03:08 l2 shape (100, 1152) | (1152, 625)
2020/10/21 10:03:08 l3 name Dropout 0.55(%15) :: Matrix float64 | a3 name ReLU(%14) :: Matrix float64
2020/10/21 10:03:08 DONE
2020/10/21 10:03:08 m.out.Shape (100, 10), y.Shape (100, 10)
2020/10/21 10:03:08 Batches 600
Epoch 0 0 / 600 [------------------------------------------------------]   0.00%

Running nvidia-smi I can see it has allocated memory to it, but seems to just hang
0      6477      C   /tmp/go-build071137485/b001/exe/goHide       470MiB

It could be that i'm doing something wrong, but I build the cudamodules using the cudagen tool. The only strange thing is that I have to remove //+build cuda from the top of convnet.go prior to running the cudagen tool otherwise I get the following
2020/10/21 10:07:50 failed to get name of package in working directory. Error: exit status 1. go list error: package .: build constraints exclude all Go files in /path/to/project. I then add it back in afterwards and it runs, but hangs as mentioned.

Yes. CUDA is somewhat broken between CUDA10 and CUDA11, leading to that hang. It's a known issue, hence the cu package is being upgraded to CUDA11

The fix to CUDA11 is a few days away.

Fantastic, thank you :smile:
The issue with  the import cycle not allowed, is that a simple fix for later versions, or something i'm doing incorrectly when using the cudamodules file on latter versions of Go?

What is the package name on top of cudamodules.go

main

Wondering if you could send me the code? chewxy [at] gmail.com

Just have done. Subject Gorgonia #445 & #341.

I have just removed and updated Gorgonia and CU packages and now it works fine... Could've been that in combination with cleaning the cache was enough to sort it out so thank you :+1:
@chewxy, when re-basing on the latest commit, I get the following when running anything with the cuda build tag;
# gorgonia.org/gorgonia
../../../go/src/gorgonia.org/gorgonia/cuda.go:293:6: calcBlocks redeclared in this block
	previous declaration at ../../../go/src/gorgonia.org/gorgonia/concurrency.go:22:37

I see you added concurrency.go in your fix for #448. Commenting out the declaration obviously gets around the above. Might be worth a refactor. Happy to close this issue unless you'd prefer to leave it open w.r.t the upcoming CUDA fixes.

embarassingly, that's also fixed in an upcoming commit (found when running test for this)

fixed now in master


add heroku-deflater

A simple rack middleware that enables compressing of your assets and application responses on Heroku, while not wasting CPU cycles on pointlessly compressing images and other binary responses. https://github.com/romanbsd/heroku-deflater

waiting #662 to be merged would be better idea💡


Private members are listed in the toc

ciao, thanks for implementing and publishing this extension!
i have this config in the conf.py:
autodoc_default_options = {
    "inherited-members": True,
    "members": True,
}

and within the autoclass directives in my docs, there's only the autoclasstoc directive. however, unlike i expected, private members of a class and its ancestors are appearing in the toc, not in the detailed list of members. am i missing something or does this qualify as a bug?

It's not a bug, but it's understandably confusing behavior.  What's happening is that autoclasstoc doesn't read the same configuration values as autodoc.  In other words, autodoc_default_options doesn't affect autoclasstoc at all.  What you need to do is configure autoclasstoc_sections:
autoclasstoc_sections = ['public-methods']

The default is ['public-methods', 'private-methods'], so the above will change that to only show public methods.
Thinking about it more, though, it would be good to make the default behavior consistent with autodoc_default_options.  I'll have to think about the best way to do it, but it shouldn't be too hard.


Why Wouldn't SDK work after adding scope permissions for an API call ?

I was trying to use the conversations_list API and I keep getting the error message :
SlackApiError: The request to the Slack API failed.
The server responded with: {'ok': False, 'error': 'not_allowed_token_type'}

I have the following permission in my manifest :
scopes:
    bot:
      - app_mentions:read
      - channels:history
      - channels:read
      - chat:write
      - groups:read
      - im:read
      - links:read
      - users:read
      - mpim:read

The scopes align with the ones needed by the API as given here.
What can be the problem?
Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The Slack SDK version
slack-sdk==3.7.0
slackeventsapi==2.2.1
Python runtime version
Python 3.7.2
OS info
ProductName:    Mac OS X
ProductVersion: 10.15.5
BuildVersion:   19F101
Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64

Closing this was a bug on my side; I used the APP_TOKEN instead of the BOT_TOKEN.


STG93 Added ACL response headers and x-ms-upn request header

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-storage-blob


Add aling property to Space layout

I'm new to Thaw, so may be there is another way already. Also something like flex-grow would be nice.

Later, I'll implement the functionality in the image.

Also something like flex-grow would be nice.

It doesn't feel like implementing something like flex-grow is easy.


Move config to external file

After I tried #120 I also tried this myself and this is the result...
I think what we want is a config file that has all the configuration we want (api keys, but also host and maybe later a flag for 'enable mvt' etc.). But since we do not want to keep the api keys in VCS it has to be possible to replace the config file. I am now using webpack's resolve/alias feature which allows redirecting import statements to a given path, and this path can be set conditionally in the webpack config. The condition I use is the existence of a config-local.js file which is in .gitignore. If this file exists it will be included in the bundle by webpack. If it does not exist the default config.js file is used, which is included in VCS. Anywhere in our code we can import the config like import config from 'config' where 'config' is an alias for whatever config file we include in the webpack configuration (it might be config-local.js or config.js).
So what this means for development is that unless we create a config-local.js file the default config.js file is used and we can setup our own api keys in config-local.js.

I fixed the config.js for travis but it seems the "config" import in Api.ts cannot be found when running the tests.

I fixed the config.js for travis but it seems the "config" import in Api.ts cannot be found when running the tests.

Oh yes, we have to define such an alias for 'config' also for the test (jest) config. I did this in the last commit. I also had to remove the ES6 export in config.js, so you need to adjust this for the travis variable also (use module.exports =  instead of export default). jest cannot handle ES6 modules apparently. Another option would probably be to include config.js in the typescript compilation but I did not know how to do this and since it is working now I think it's fine.

Thanks, have adapted the CONFIG_CONTENT now in travis accordingly and triggered the last build again.


Add persistance

Adds a PVC

Hi @armandleopold , thanks for this pull request.
We usually don't want to use a PVC for Postgresql data because we're only using it for testing in clusters that don't always support PVCs. So we would need it to be disabled by default and created only if it's enabled by some value. I'm thinking something like .Values.keycloak.database.createPVC or .Values.keycloak.database.pvc.enabled...
The PR also includes changes in the argocd_application repo_urls to point to your repository which doesn't make sense for us.

Done the modifications @ckaenzig

@armandleopold I made a few code suggestions in my code review. Let me know if you have any issues using the commit suggestions feature of GitHub. You can also apply the changes manually on your code and the conversations should be closed automatically.
(If you are already familiar with these GitHub functionalities, kindly ignore this comment :wink:)

@armandleopold as we do not received any feedback on our review, we will close the PR. Please feel free to reactivate it.


Add IBM i platform (and misc bugfixes)

Adding IBM i platform
Some notes:

For all intents and purposes, IBM i is always 64bit
System.mapLibraryName() on IBM i is stupid (for compatibility reasons) and its return value is effectively junk
On IBM i, system libffi must be used as IBM shipped a version without all patches upstreamed and the bundled version won't compile
This PR includes two bugfixes not particularly related to IBM i, but encountered while porting the package. I can split them into a separate PR if needed:

Build referencing LIBFFI_LIBS (compile/link options) as build object
unset jffiExtractName variable in the StubLoader

Linking for reference https://github.com/jnr/jnr-ffi/issues/230

This seems good so far. Do you have more work to do?

Thanks! This is great!


Support for Emoji

Markdown for github has support for emojis see here http://www.webpagefx.com/tools/emoji-cheat-sheet/
Also here https://github.com/github/gemoji
So : + 1 : is converted to :+1:
Would love to see this or something along those lines in the app.
-Thanks

Wanted to add the same suggestion.
I am using :question: :mag: :e-mail: and :calling:

Stands on the Todo - I just have to come to :+1:

This would be great. I was using ✅  and ❌  in a table to say whether or not the feature was supported. Looking for a work around now with some images

Hello, sorry, but I will no longer maintain the project.
This project is archived because the owner no longer uses the Atom Editor.
It would be very good to find a new owner for this project, who will take care of updating and expanding the Atom package. A new version based on Chrome Headless has already been prepared in a feature branch.


SUGGESTION: Make bonus damage only show up for attacks & saving throw action types

Make bonus damage only show up for attacks & saving throw action types.
This way bonus damage is not shown on the card when using a healing or utility ability.

This won't be fixed, only update for mess that will be coming (regarding rolling issues) is removing them.
My replacement is now submitted and waits for approval. Meanwhile you can download the module and look at its features from its repository:
https://github.com/Moerill/fvtt-mars-5e
Manifest: https://raw.githubusercontent.com/Moerill/fvtt-mars-5e/master/module.json
(I'm currently going through all rolling related issues, pasting this as information and closing them)


Switch to triage-* labels for platform package triage

Currently the ecosystem team triages all PRs in the packages repository, but the platform teams also triage all PRs with their platform label. Due to the way PRs in packages work, however, it's relatively common for a PR to not be relevant to all the teams' triages at all times. Common examples:

One platform team may LGTM a multi-platform PR for their platform's portion, while another platform goes through review for several more weeks.
A cross-platform PR may not have high-level design approval from the ecosystem owner, at which point platform implementation review is premature.

To avoid PRs showing up repeatedly in a platform team's triage when it's not relevant, this adjusts the triage structure:

Queries for PRs in platform teams query triage-<platform name> rather than platform-<platform name>
Ecosystem triage will add the triage-<platform name> label during triage when a PR is ready for that platform team's consideration.
Platform teams can remove the label when it's not relevant to them (e..g, after it's been LGTM'd for that platform).

This also adds a desktop PR query, since there wasn't one, covering the separate platforms. They are separated to allow for more triage flexibility in the future.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

This is based on discussion with @jmagman. @reidbaker and @cbracken please let me know if you have any concerns with this approach; I expect it to make things easier for Android triage as well.


When does prestart.sh run and where is defined?

When does prestart.sh run and where is defined? Any recommendation for development purposes on how to create the super-admin?

I was also trying to understand this magically called prestart script, and after some digging, I found that it is defined in the base docker image tiangolo/uvicorn-gunicorn-fastapi:python3.7 used by the backend Dockerfile,  base image defined at  https://github.com/tiangolo/meinheld-gunicorn-docker/blob/master/docker-images/

Just tracing the origin.
https://github.com/tiangolo/uvicorn-gunicorn-docker/blob/49d3538121828a20f22b609c8278246e94a71d82/docker-images/start.sh#L23C1-L31C3
Sweet script code.


Build dldt 2020 with OMP on macOS Error

export<EMAIL_ADDRESS>export<EMAIL_ADDRESS>cmake -DCMAKE_BUILD_TYPE=Release -DTHREADING=OMP ..

macOS Catalina Version 10.15.3

[ 87%] Building CXX object inference-engine/src/vpu/graph_transformer/CMakeFiles/vpu_graph_transformer.dir/src/stages/post_op_stage.cpp.o
[ 87%] Linking CXX shared library ../../../../bin/intel64/Release/lib/libMKLDNNPlugin.dylib
Undefined symbols for architecture x86_64:
  "MKLDNNPlugin::cpu::getAvailableNUMANodes()", referenced from:
      MKLDNNPlugin::Config::readProperties(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > > const&) in config.cpp.o
      MKLDNNPlugin::MKLDNNExecNetwork::MKLDNNExecNetwork(InferenceEngine::ICNNNetwork const&, MKLDNNPlugin::Config const&, std::__1::shared_ptr<MKLDNNPlugin::MKLDNNExtensionManager> const&) in mkldnn_exec_network.cpp.o
      create_shared_weights_per_socket() in mkldnn_plugin.cpp.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [../bin/intel64/Release/lib/libMKLDNNPlugin.dylib] Error 1
make[1]: *** [inference-engine/src/mkldnn_plugin/CMakeFiles/MKLDNNPlugin.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 87%] Building CXX object ngraph/test/CMakeFiles/unit-test.dir/convert_u1_to_string.cpp.o
[ 87%] Building CXX object ngraph/test/CMakeFiles/unit-test.dir/coordinate.cpp.o

This error makes building stop at 98% without libMKLDNNPlugin.dylib.

Hi @qiyuangong
I am currently going through the build process, I will let you know if I succeed. In the meantime,
could you try updating your clang version? The build instructions, list Clang compiler from Xcode 10.1 or higher as a software requirement.
Regards,
Jesus

Hi @jgespino
I have tried with higher Clang with latest Xcode. It encountered -fopenmp problem.
Here is the error message:
clang: error: unsupported option '-fopenmp'
make[2]: *** [inference-engine/src/preprocessing/CMakeFiles/inference_engine_preproc_obj.dir/cpu_x86_sse42/ie_preprocess_data_sse42.cpp.o] Error 1
make[1]: *** [inference-engine/src/preprocessing/CMakeFiles/inference_engine_preproc_obj.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  1%] Building CXX object inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/source/assert.cpp.o
[  1%] Performing download step (git clone) for 'ext_gtest'
Cloning into 'ext_gtest'...
[  1%] Building CXX object inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/source/check_cycles.cpp.o
[  1%] Building CXX object inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/source/edge.cpp.o
[  1%] Building CXX object inference-engine/src/inference_engine/CMakeFiles/inference_engine_obj.dir/blob_factory.cpp.o
clang: error: unsupported option '-fopenmp'
make[2]: *** [inference-engine/src/inference_engine/CMakeFiles/inference_engine_obj.dir/blob_factory.cpp.o] Error 1
make[1]: *** [inference-engine/src/inference_engine/CMakeFiles/inference_engine_obj.dir/all] Error 2
[  1%] Building CXX object inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/source/execution_engine.cpp.o
[  2%] Building CXX object inference-engine/thirdparty/CMakeFiles/mkldnn.dir/mkl-dnn/src/common/batch_normalization.cpp.o
clang: error: unsupported option '-fopenmp'
make[2]: *** [inference-engine/thirdparty/CMakeFiles/mkldnn.dir/mkl-dnn/src/common/batch_normalization.cpp.o] Error 1
make[1]: *** [inference-engine/thirdparty/CMakeFiles/mkldnn.dir/all] Error 2

Hi @qiyuangong
I ran into the same clang: error: unsupported option '-fopenmp' using the clang version included in xcode. However, I was able to get a successful build using the following steps. Could you give this a try and let me know if it works for you?
brew install llvm
export CC=/usr/local/Cellar/llvm/9.0.1/bin/clang
export  CXX=/usr/local/Cellar/llvm/9.0.1/bin/clang++
git clone https://github.com/opencv/dldt.git
cd dldt
git submodule update --init --recursive
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release -DTHREADING=OMG -DENABLE_OPENCV=OFF ..
make -j 4
Regards,
Jesus

Hi @jgespino
I used your configuration. It still doesn't work for me. :(
Here is the error message in verbose build mode:
cmake -DCMAKE_BUILD_TYPE=Release -DTHREADING=OMP -DENABLE_OPENCV=OFF -DVERBOSE_BUILD=ON ..
[ 87%] Building CXX object ngraph/test/CMakeFiles/unit-test.dir/convert_u1_to_string.cpp.o
cd /Users/qiyuangong/Develop/dldt/build/ngraph/test && /usr/local/Cellar/llvm/9.0.1/bin/clang++  -DCURDIR=\"/Users/qiyuangong/Develop/dldt/ngraph/test\" -DENABLE_NGRAPH -DIE_BUILD_POSTFIX=\"\" -DJSON_INCLUDES=\"\" -DNGRAPH_JSON_DISABLE -DNGRAPH_UNIT_TEST_OPENVINO_ENABLE -DNGRAPH_VERSION=\"0.27.1-rc.0+b0bb801\" -DNGRAPH_VERSION_LABEL=\"v0.27.1-rc.0+b0bb801\" -DPROJECT_ROOT_DIR=\"/Users/qiyuangong/Develop/dldt/ngraph\" -DSERIALIZED_ZOO=\"/Users/qiyuangong/Develop/dldt/ngraph/test/models\" -DTEST_FILES=\"/Users/qiyuangong/Develop/dldt/ngraph/test/files\" -I/Users/qiyuangong/Develop/dldt/ngraph/test/. -I/Users/qiyuangong/Develop/dldt/inference-engine/include -I/Users/qiyuangong/Develop/dldt/ngraph/src -isystem /Users/qiyuangong/Develop/dldt/build/ngraph/gtest/src/ext_gtest/googletest/include -isystem /Users/qiyuangong/Develop/dldt/build/ngraph/gtest/src/ext_gtest/googlemock/include  -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -fstack-protector-all -fsigned-char -Werror -ffunction-sections -fdata-sections -fvisibility=hidden -fdiagnostics-show-option -Wundef -fvisibility-inlines-hidden -Wuninitialized -Winit-self -Wno-error=switch -Wno-error=uninitialized -Wno-error=literal-conversion -Wno-error=return-type -Wno-undef -fvisibility=default -DEIGEN_MPL2_ONLY -DTBB_USE_THREADING_TOOLS -O2 -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -fstack-protector-all -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -fPIE   -Wno-zero-as-null-pointer-constant -Wno-undef -Wno-reserved-id-macro -std=c++11 -o CMakeFiles/unit-test.dir/convert_u1_to_string.cpp.o -c /Users/qiyuangong/Develop/dldt/ngraph/test/convert_u1_to_string.cpp
Undefined symbols for architecture x86_64:
  "MKLDNNPlugin::cpu::getAvailableNUMANodes()", referenced from:
      MKLDNNPlugin::Config::readProperties(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > > const&) in config.cpp.o
      MKLDNNPlugin::MKLDNNExecNetwork::MKLDNNExecNetwork(InferenceEngine::ICNNNetwork const&, MKLDNNPlugin::Config const&, std::__1::shared_ptr<MKLDNNPlugin::MKLDNNExtensionManager> const&) in mkldnn_exec_network.cpp.o
      create_shared_weights_per_socket() in mkldnn_plugin.cpp.o
ld: symbol(s) not found for architecture x86_64
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [../bin/intel64/Release/lib/libMKLDNNPlugin.dylib] Error 1
make[1]: *** [inference-engine/src/mkldnn_plugin/CMakeFiles/MKLDNNPlugin.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

It seems that building [ 87%] Building CXX object ngraph/test/CMakeFiles/unit-test.dir/convert_u1_to_string.cpp.o encountered a problem.
Have a nice day!
Qiyuan

Hi @jgespino
Which macOS version are you using? 10.14 or 10.15?

Hi @qiyuangong
I tested on MacOS Catalina (10.15.3). When you followed by previous steps, did you start with a fresh build directory?
The MKLDNNPlugin.dir error was solved for me by adding the -DENABLE_OPENCV=OFF to my cmake command.
Regards,
Jesus

Hi @jgespino
I tried with fresh build directory (on both macOS 10.15 and macOS 10.12). They both works with TBB, but failed with OMP on the same place. :(
I'm trying to build with OMP on macOS 10.14 (fresh environment on my old macbook).
Regards,
Qiyuan

New update:
Fresh dir with fresh build macOS 10.14 also doesn't work for OMP. :(

Hi @qiyuangong
I am re-installing macOS to try on a fresh build, I will let you know how it goes.
Regards,
Jesus

Thanks, Jesus. :)

Hi @qiyuangong
I was able to successfully build dldt with a fresh macOS and installing the software versions listed below. Could you try to match my setup and give it another try?
Software versions:
macOS Mojave (10.14.6)
Python 3.6.5
CMake 3.16.5
Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)
libusb: stable 1.0.23
Commands:
git clone https://github.com/opencv/dldt.git
cd dldt/
git submodule update --init --recursive
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DTHREADING=OMG -DENABLE_OPENCV=OFF ..
make -j 4
If you built fails again, please provide the full output of make command and the output of the following commands.
clang --version
python3 --version
cmake --version
git show -s (from the dldt directory)
sw_vers
Regards,
Jesus

@jgespino Please double check for typos, there is no "OMG" threading mode.

Hi @alalek Ah yes good catch, I was typing too fast here!

Hi @qiyuangong,
Turns out I had a typo in my cmake command as well, I re-started the rebuilt process and it failed with the same message you are seeing. I'm still looking into it as I may be missing some pre-requisites and the ./install_dependencies.sh doesn't work for macOS (probably a bug).
@alalek Have you had a successful built on MacOS with OMP?
Regards,
Jesus

Thanks @jgespino !
Hi @alalek
According to my building tests, TBB option passed on all platform. But, for OMP, there are still some small problems, such as OpenCV on CentOS, and this macOS building issue etc.
Is there any hot-fix for this problem?
Regards,
Qiyuan

Hi @jgespino
I found the reason in https://github.com/opencv/dldt/blob/2020/inference-engine/src/mkldnn_plugin/mkldnn/system_conf.cpp#L46.
getAvailableNUMANodes is only defined in for TBB on macOS.
That's why this issue only happened on macOS with OMP. :(

Fix build by adding these lines to system_conf.cpp fix this problem.
#if !((IE_THREAD == IE_THREAD_TBB || IE_THREAD == IE_THREAD_TBB_AUTO))
 std::vector<int> getAvailableNUMANodes() {
        std::vector<int> numa_indexes;
        numa_indexes.push_back(0);
        return numa_indexes;
    }
#endif

Because recent mac products only have one CPU. That makes it possible to hard code 0 for return value.  :)
Regards,
Qiyuan

Problem solved. Issue closed.
Thank you @jgespino ! :)


Update docs for 'Creating a pipeline template'

We recently modified the user flow for creating a Pipeline template so we need docs to reflect this change. We no longer immediately create a template, we now follow a more standard creation flow: click create > fill out a form > click save.

weird, I've pushed a commit to revert the explicit list numbering but it's not shown up here yet 🤔

I'm gonna close/recreate the PR and see if that resolves things...


tests/www/views/test_views_home.py ~ 4 Failed tests

There are still 4 unit tests failing. One of the prominent errors we see in this group of tests is
AttributeError: 'FlaskApp' object has no attribute 'appbuilder'

I think the problem lies in, how these test users are created. This method of creating test users might not be correct after Connexion v3 upgrade.
https://github.com/sudiptob2/airflow/blob/588b8453afa1c35c0dd5b803757b50e3ebd13888/tests/test_utils/api_connexion_utils.py#L52-L72

This seems fine if you pass app.app instead of app on line 118.

Yes. many of those errors can be solved by using  app.app to get to the actual FlaskApplication that is handling the views.


1.17.1 - Filter does not work correctly with upper case letter in test name

Steps to reproduce:

Open http://jsfiddle.net/nxrLcppq/
Type "Test Name" in "Filter" input and click "Go"
No any tests will be run

Compare results with "test name" filter string.
Seems, this issue was appeared after https://github.com/jquery/qunit/commit/1d44eb38052d25d97a631b9711e481303fc472b6 , where
filter = config.filter && config.filter.toLowerCase(),
was replaced by
filter = config.filter,

:+1: This one caused lots of headaches for us since we use capitals in all of our constructor names.


Question: vscode auto formatting

How can i use volar formatting <style> section , but use eslint (without prettier) formatting <template> and <script> in SFC.
    "[vue]": {
        "editor.defaultFormatter": "johnsoncodehk.volar"
    },

when i setting it, volar will formatting whole SFC .

Looks like a very exotic config 👀
Could you explain why you need such a complex setup and don't just use formatting and linting for whole vue file?

Looks like a very exotic config 👀
Could you explain why you need such a complex setup and don't just use formatting and linting for whole vue file?

// .eslintrc
{
  "extends": "@my-team",
}

we have custom eslint config (without prettier),so we  want to follow this specification when formatting.
But when i change default formatter (disable volar format), we missing the style section formatting

I'm using stylelint in my current project, but we have e.g. <style lang="scss" src="./App.scss"></style> ... so... don't know if it can also lint vue sfc 🤔

@Shinigami92 Thanks !

Maybe I can simply provide these VSCode settings to resolve this requirement:

volar.format.template.enabled
volar.format.script.enabled
volar.format.style.enabled

But I'm not sure if we really need it.

Maybe I can simply provide these VSCode settings to resolve this requirement:

volar.format.template.enabled
volar.format.script.enabled
volar.format.style.enabled

But I'm not sure if we really need it.

it’s very useful for me, maybe we can support it (more flexible ? ), enabled all by default.

@webfansplz was following finally added? In VSCode it is grayed out as unknown options. How https://github.com/vuejs/language-tools/pull/1028 solves closes this please?
volar.format.template.enabled
volar.format.script.enabled
volar.format.style.enabled

@nolimitdev we don't have these options, please open a feature request if you think it should have.


Roll Flutter Engine from 280491d4cc21 to 00a70deb7e93 (1 revision)

https://github.com/flutter/engine/compare/280491d4cc21...00a70deb7e93
2023-06-19<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from BuzniDS9u_hd to gX0QkT_dMBCT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[Home] Currently broken

Seems like the __id field of the fair rail is null.

Ok, check this out, I had some fun reproducing this bug. Given this template:
$ curl -s -H 'X-Xapp-Token: sPH1d_f1p92S_DD8Chuvww4ifNgPNmCQOeiOruRXzG397h_YrIK6csylfl8PCrLhdPjgAR0MIi6Zpa-taKRkMv_dZzAzD4ctaL5by2BDtSJcd30Kzl0-OwVNG1vHakoT_Dd67-Cg2NtRqa_Os8ey0NomXwSqlxYRnlFpYdKDlGbObgmuEFt1NHMG56Zw6qGb4KRi8BWzZ-KoJ9wijRbHJgxqpNoKnu-i0dSX1TdZq8U=' 'https://stagingapi.artsy.net/api/v1/fairs?QUERY' | ruby -rjson -e 'p JSON.parse(ARGF.read).map { |fair| fair["id"] }'

(Replace QUERY with one of the queries below.)
These all work as expected:

has_homepage_section=true&active=true&size=5: ["cosmoscow-2016"]
active=true&has_homepage_section=true: ["cosmoscow-2016"]
has_homepage_section=true&size=5: ["frieze-london-2016", "frieze-masters-2016", "expo-chicago-2016", "cosmoscow-2016", "art-basel-2016"]

But, if you reverse the order on the active and has_homepage_section flags and include the size flag then suddenly no results are found.

active=true&has_homepage_section=true&size=5: []

Here’s a gist with the full commands: https://gist.github.com/alloy/31df9d40346df1b537058be9f100cffa

Filed a Gravity ticket: https://github.com/artsy/gravity/issues/10347
And made a stopgap PR for Metaphysics: https://github.com/artsy/metaphysics/pull/397


Feature/geode 3977

Cleanup of QueryService variable declaration.

@mhansonp why is there a commit for GEODE-3571 on this pull?

I accidentally put the wrong bug number in the checking. Let me see if I can change it.


feat: [M3-7035] - Add DC-specific pricing to Linode backups

Description 📝
Pricing for backups is now Region-dependent. This PR uses the mocked API response for the linode/types endpoint to get the correct price for a backup add-on with region_prices data.
Major Changes 🔄
With the dcSpecificPricing feature flag on and MSW on:

In the Linode Create flow, adding Backups as an Add-On displays DC-specific backup pricing based on the selected Region in the Add-Ons panel and the checkout summary.
On the Linode Details -> Backups tab:

The enable backups empty state copy displays DC-specific backup pricing based on the Linode's region.
On the Enable Backups confirmation dialog, copy displays correctly calculated DC-specific backup pricing based on the Linode's region.

On the Enable All Backups drawer:

Total cost of backups, and each Linode's DC-specific backup price, is displayed and calculated correctly.
Minor copy updates  (removed "Confirm to add backups to N Linode(s)" and prefixed the total with "Total for N Linodes:")
A Region column exists in the table with populated region data for each Linode
Modal is widened to fit all four columns (existing + new Regions column)

Updated unit tests

Preview 📷

Flow/Component
Before
After

Linode Create

Linode Details -> Backups

Enable Backups Dialog

Backups Drawer

How to test 🧪

How to setup test environment?

Ensure the dcSpecificPricing feature flag is toggled on.
Turn the MSW on.

How to verify changes?

Make the changes described below to the mocks.
Test that this mocked linode in Jakarta has DC-specific backups pricing (should use mocked region_price) in all the locations mentioned in the table above.
Toggle the dcSpecificPricing flag off and confirm the mocked linode in Jakarta does not have any increases in its backup price (should use mocked base price).
Remove the region you added earlier from the mocked requestrest.get('*/linode/instances/:id' and confirm that a linode not in Jakarta or Sao Paulo does not have any increases in its backup price (should use mocked base price).
Ensure no new regressions in unit and e2e tests.

Update the MSW mocked requestrest.get('*/linode/instances/:id' to include region: 'id-cgk' in the mocked linode created with the factory.
To test Backups Drawer:
Recommend modifying rest.get('*/linode/instances' to use a shorter list of linodes:
      linodeFactory.build({
        backups: { enabled: false },
        label: 'eu-linode',
        region: 'eu-west',
      }),
      linodeFactory.build({
        backups: { enabled: false },
        label: 'DC-Specific Pricing Linode',
        region: 'id-cgk',
      }),

How to run Unit or E2E tests?

yarn test BackupLinodeRow utils AddOnsPanel linodes

@abailly-akamai I'll merge now so you can rebase -- thank you for taking care of moving the util!


WIP Issue 354: Deploy Polyaxon

Issues Resolved by this Pull Request
Please be sure to associate your pull request with one or more open issues. Use the word Fixes as well as a hashtag (#) prior to the issue number in order to automatically resolve associated issues (e.g., Fixes #100).
Fixes #354
Description of the Solution
Created polyaxon playbook and role
Suggested Reviewers
@lwilson

@Franklin-Johnson, I need you to fix a few issues:

You need to be sure you sign all commits. You can do this by using the --signoff option with git commit:
git commit --signoff
Can you go back and sign your previous commits? To do this, run the following commands:
git rebase HEAD~11 --signoff
git push --force-with-lease origin issue-354

Thanks, @Franklin-Johnson. Please remove the "WIP" from the title of this PR so that we can finish the review/merge.

Alrighty, @lwilson I took off the WIP. Let me know if you need anything else done.


Inconsistent routing behavior while rebalancing?

Background
To start I am able to complete a cicular rebalance of 100k sats through the route my node -> Node A -> Node B -> my node successfully. If I increase the amount to 200k it not longer routes successfully and will attempt other routes. If I try 100k again it will again be successful and I can repeat for multiple calls which will be much greater than the 200k in the failed attempt. I have done this multiple times over the last month or so.
Your environment

version of lnd - 14.1
which operating system (uname -a on *Nix) - Linux raspibolt2 5.10.63-v8+ #1488 SMP PREEMPT Thu Nov 18 16:16:16 GMT 2021 aarch64 GNU/Linux
version of btcd, bitcoind, or other backend - Bitcoin Core version v22.0.0
any other relevant environment details

Steps to reproduce

Perform a circular rebalance
Increase the amount using the same route for the next attempt
if that fails try again with the initial amount
repeat with the initial amount until you have gone well above the amount in step 2

Expected behaviour
If the route can support the larger amount over the same route (as determined by subsequent calls) then it should complete successfully
Actual behaviour
The specified route with the greater amount fails and it attempts to discover alternate routes. Returning to the original amount succeeds again and can be repeated multiple times.

Maybe there is a max HTLC size or the routing node involved is otherwise rejecting too-large HTLCs or themselves opportunistically rebalancing to support the routing you are doing

It's possible but I've hit the same issue on multiple occasions. I'll see if I hit it again and I'll capture logs and see if I can make heads or tails of what is going on.


Add fix for BSD stat

Current implementation assumes GNU coreutils version of stat, which fails on BSD.
Try BSD format if GNU coreutils version fails.
fixes #501

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

I've verified the commit author as being me with github


Reporting Missing imports

reportMissingModuleSource
pylance is not supporting the basic imports

This message means that you don't have django installed in the Python environment that is currently selected. If you look in the bottom left corner of the window, you should see which environment is selected. Make sure that matches what you expect.

Hello , if you seeing this.. this is the same as me I tried to reportMissingImports it is not supported in pylance in flask.. and I looked at the bottom left corner of the window, what do I should do with it? Do I need to make environment to my python file? then trying again if it still works to import the flask.

I suggest using "open folder" and refer to this guide on selecting your environment. https://code.visualstudio.com/docs/python/environments#_select-and-activate-an-environment

This message means that you don't have django installed in the Python environment that is currently selected. If you look in the bottom left corner of the window, you should see which environment is selected. Make sure that matches what you expect.

Thanks! I was able to resolve it.


TypeError: string indices must be integers

I get the mentioned error when trying to execute your notebook examples:
perturbations = pj.perturb(text)
perturbations

Hi there! Sorry for my late response, but if you pull from main, this should be fixed. Looks like the latest transformer version made the API not compatible anymore. For more discussions, please see: https://github.com/tongshuangwu/polyjuice/issues/7


Ninja builder cleanup

We're in the process of switching to the latest gftools using the Ninja-based builder. However, when I build a simple .ufo family, the build leaves behind an instance_ttf directory in the root of the directory and a .designspace file alongside the UFO sources.
My expectation is that temporary files are removed after the build and the source directory is not modified. Is this an intentional change?

Sorry for the late reply. We'll have this solved once we're all happy with #726. I suggest the Type Founders test this pr out since it will replace the current builder.


Request to add to the docs, what shortcut or options

Hi
Looks a great plugin, but can you to add to the docs, what shortcut or options to click to make it work?
I have the plugin, but see nothing in the action menu or sidebar.
Thank you

The only "entry-point" currently (so to speak) is through the dataveiw code block (as described in the README). Would be happy to improve it though if it's not clear enough currently.

I do have a request for your README. Would you be able to include a more complex, nested example and a null example? An example of what I mean: I have a list of tasks files in a folder "tasks". The front matter has fields: goal, dueDate, scheduledDate, completed.
At the beginning of the week, I want to know: Of the tasks that have not been completed (completed = N or null), which are the ones that I have not yet scheduled in my workplan (scheduledDate = null).
I have tried all kinds of things based on the README, but I can't figure out the syntax for the query. Can you help?

I'm in the process of setting up much more detailed reference documentation to aid in this. As for your specific question, perhaps
list from "tasks"
where (!completed or completed = "N") and !scheduledDate

Super. That works great.
Your plugin is taking Obsidian to an entirely different level. Thank you.

Happy that it's helpful. I'll be dramatically improving the documentation with more examples in future releases so that these queries are more discoverable / easier to write.

@blacksmithgu Thank you, I'll give it another look, I couldn't tell if I just needed better front matter or something in the query was wrong.

@blacksmithgu Thank you, I'll give it another look, I couldn't tell if I just needed better front matter or something in the query was wrong.

Looking great, data feeding in now for documents before front matter set up and now can add it selectively (I have now 0.1.10 on Obsidian 0.11.5)


pull request for e2e test at 12/06/2016 21:45:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Upgrade Leaderboard to manage large number of participants

source: https://blog.upsidelearning.com/2020/09/09/the-overly-abused-and-rarely-understood-world-of-leaderboards/
Relative Leaderboards

This design [Basic Leaderboards] has a slight drawback, it’s just that if you’re the person at position 173, you might feel like competing with the best just impossible and you might lose the motivation to continue working towards being in the standings. So we have a slight variation called the relative leaderboard that addresses those moments when the number of people are too many and climbing over them seems a herculean or even an impossible task.

The relative leaderboards only showcase the participants and their scores near you or relative to a variable so that you don’t feel totally lost and start hunting for meaning and purpose of life after witnessing and assessing your position. It’s a simple hack that doesn’t overwhelm the players.

Both options are great tactical options; however, their lack of depth doesn’t make them versatile and purposeful.

Tiered Leaderboard
I think a tiered leaderboard is just a better version of a relative leaderboard.

The more we get into the types of leaderboards the more complex the leaderboards get. Tiered leaderboards essentially are a better way to manage a large number of participants. The participants usually have to earn their way to the top tier by scoring desired goals. The basic tiered leaderboard is a linear journey towards the top tiers, where the top tiers can be never ending or could have a finite end. Tiered leaderboards can be supported with ranking and one key variable. I haven’t seen a lot of examples of a linear journey where the only way to go is towards the top of the tier.

However, on the other hand I have two interesting examples on the Promotion & Relegation Variation. Duolingo and FUT (FIFA Ultimate Team). Duolingo has multiple leagues that you can get promoted/relegated to depending on your score for the week. FUT has divisions and sub-tiers within the division that you can be a part of. The subdivisions of tiered league are also possible if you want to limit/control the number of players per league/division/tier.

The weekly scores determine the status of promotion/relegation. However, that can be customized depending on the context/purpose.

Quant Leaderboards/Multi-Variable/Multivariate Leaderboards
IDK if this makes sense, it's quite difficult for people to comprehend. Although later on this could add great depth to the sport.

This is where the leaderboards start getting interesting. With the amount of data we’re generating daily, there is another way in which the motivators of a leaderboard can be triggered – it’s through the Quant/Multi-Variable/Multivariate Leaderboards. I’ll explain this with an example of football, since it’s something that is close to me.

This looks like a normal table with some match stats, but if you look at it from the point of view of a leaderboard, this style of leaderboards will start making sense to you. This table shows the goal opportunities created by Everton & Southampton, two premier league football clubs in their league encounter.

Here the main variable is xG – goal opportunities, which is listed under total. However, you can see the breakdown of that variable into two halves, like how the sport is played. The team xG & players xG is mentioned as well.

Multi-Variable/Multivariate Leaderboards will have multiple data points that make a key variable tick. It could be an index of sorts, but leaderboards will have coefficient-based calculations that will add dynamism that is sorely missing in the basic and tiered versions.

The depth that is offered in these leaderboards will be full of insights. It might get difficult to read at first, but once you get a hang of it, this will explode.

You could also add a time-based variation to these and evaluate variables on a granular level.


Task.WaitAll(taskList.ToArray()) never fisnishes

Dear all
As always, thank you for your hard work
Maybe I'm doing something wrong, but I think I have found an issue.
Launching several tasks to Create several tweets in parallel and using Task.WaiAll() does not work correctly
I have been using the latest 0.40 version with Core NET 8.0
SurrealDB (latest version 1.3.1) is the table tweets with no records.
This is the test code I have prepared.

private static async Task Main(string[] args)
{
    DataBaseParams dbParams = new DataBaseParams()
    {
        ipAddress = "<IP_ADDRESS>",
        port = 8000,
        username = "root",
        password = "root",
        database = "testdb",
        dataBaseEngine = DataBaseEngine.SurrealDB
    };

    var surrealDBClient = new SurrealDbClient(
                    SurrealDbOptions
                        .Create()
                        .WithEndpoint($"ws://{dbParams.ipAddress}:{dbParams.port}/rpc")
                        .WithUsername(dbParams.username)
                        .WithPassword(dbParams.password)
                        .WithNamespace(dbParams.database)
                        .WithDatabase(dbParams.database)
                        .Build(),
                    null,
                    (_options) =>
                    {
                        _options.IncludeFields = true;
                    }
    );

    List<Tweet> tweets = new List<Tweet>();
    for (int iCount = 0; iCount < 5; iCount++)
    {
        tweets.Add(new Tweet()
        {
            id = $"ID{iCount}",
            username = $"user{iCount}",
        });
    }

    List<Task<Tweet>> list = new List<Task<Tweet>>();
    tweets.ForEach(tweet =>
    {
        var task = surrealDBClient.Create("tweets2", tweet);
        //var task = dummyTask();
        list.Add(task);
    });

    Task.WaitAll(list.ToArray());
}

Please notice there are 2 methods. One is the basic SurrealDB Create method
var task = surrealDBClient.Create("tweets2", tweet);

The other is a dummy method used to compare the execution.
var task = dummyTask();

private static async Task<Tweet> dummyTask()
{
   await Task.Delay(2000);
   return new Tweet()
   {
       id = "dummy",
       username = "pepito"
   };
}

When I use the code with the Create the execution is stuck on the Task.WaitAll() forever, but checking the DB with Surrealist I can see that the 5 records were inserted.
When I use the code with the DummyTask the execution continues and the program finishes.
I have not tested the code with HTTP instead of WS, but it could have the same behaviour.

Hello Odonno
As you said, by modifying my code from
Task.WaitAll(list.ToArray());

to
await Task.WhenAll(list.ToArray());

it works.  For now I think I can work with it.
Unfortunately, I just tested the parallelization of several Create method calls, i.e.:
var tasks = tweets.Select(tweet => surrealDBClient.Create("tweets2", tweet));
await Task.WhenAll(tasks);

against
tweets.ForEach(async tweet => await surrealDBClient.Create("tweets2", tweet));

And the ForEach one is faster for Lists below 5000 records.
Really thank you for your help and fast answer.
I will continue bench-working and testing the API.
Best Regards

Yes. It depends on what you need once again. :)
Small article that explains the difference: https://blog.nimblepros.com/blogs/task-whenall-vs-parallel-foreach/


STM32 hardware random number generator

Driver that uses the hardware random number generator on the STM32.
Tested on the olimex_stm32_e407 board with the sample/drivers/random.
Some small updates to the used example.

The clearing of the buffer could probably left away, I used it to make sure I was really getting random data back in the whole buffer, the 0x00's were easy to spot.

@galak I changed the driver from HAL to LL and enhanced the example to check for buffer overflows.

LGTM.
Though, I tried to activate and test on L4 boards (disco_l475_iot1, nucleo_l476rg) and sample did not work. Status register says: CECS /CEIS. According to ref manual the RNG_CLK was not correctly detected (if  f RNG_CLK < f HCLK /16). I don't see any means to set RNG_CLK though.
Any idea how I can get this working?

@erwango  I'll look into it, but I only have F407 and F417 hardware to test.

@erwango the RNG_CLK is the 48MHz PLL48CLK clock. I added some extra checks and reset logic to the driver, could you try again on a L4 ?

@lowlander: ok couldn't find the info. I see it now. Thanks.
By the way, I also saw that on L4, it is required to set RNG clock source (LL_RCC_SetRNGClockSource).
Doing it nicely would require adding a config option. And ideally to extend clock control API.
So I managed to get it working with Clock control tweaking, which would require some work to get it clean. Let's keep it on hold for L4.

@galak do you have anymore change requests ?


refactor % code for echo server

to share common logic, add support to probability % for header etc...

dup of #145


Fixed compilation error in concrete_factory_test

Includes a compilation error fix as well as some go fmt output.

This was resolved in #291


feat: host-based scaffolded function runner

:gift: host-based scaffolded function runner

/kind enhancement

Thanks for the review @lance.  Your improvements to the PR have been made

/lgtm


feat: Added support to set and get null in closedCaptions style fields

:tada: This PR is included in version 0.14.0-next.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.15.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mitigate typetests issue in next by adding fallback to root package.json

Description
Some recent changes to typetests result in them not correctly generating on feature branches. This mitigates the issue by adding a fallback configuration. We will want a better solution long-term though (hopefully in the tool itself), as this is a per-branch cost.
Reviewer Guidance
I verified this results in typetests generating correctly again on a feature branch, and also verified that the logic to select from this config runs through the options in order (iterates Object.entries(branchReleaseTypes)) so this shouldn't affect other config. Open to further suggestions to validate this fix doesn't break other behavior.

not clear why this doesn't work in next. am not looking into it at this time, since this was a mitigation anyway and we probably want something else longer-term.


Select your own best pictures

Hey,
I really appreciate your work ! Congralutation !
I would like to know if there is an issue to select your best picture to make your profil attractive ?

Thanks a lot for this feedback!
Have a look at this article, you will love it: http://karpathy.github.io/2015/10/25/selfie/
It will answer your question :)

Thank your for your answer. The Twitter bot is not working. Do you have another tool to "rate" selfies ?

@soufiane8096 I'm not aware of any tools. I think you'll have to make your own model.
Try to scrape data on Instagram with the number of likes related to the number of followers, and use NVIDIA DIGITS with exactly the same methodology like the one @karpathy and I used (in Deep Learning Tinder)


Lasso for maps

Hi again. I am trying to use your plugin now to select elements inside a map graph. I have assumed from the beginning that the type of graph was not important for the lasso to work. Just by specifying the lassoItems correctly I expected it to work.
So it seems that the lasso gets initialized correctly the lasso items are correctly specified. I am able to see the elements when I check lasso.items(), but the selection is not working properly. When doing a lasso the elements inside it don't get selected. I need to draw the lasso on top of an specific element in order to make it selected. The code still works perfectly when used in scatterplots. Do the  lasso.items need to be on the top layer of the svg or that does not matter? Can you think or do you know why this is not working?
I can send you a small code so that you can test this issue if you are willing to. Please let me know.
Thank you for your help again! :)

Hey, if you can post some sample code that would be great. You are right - there should be no issue with the type of graph that the lasso is used with; it is designed to work with any d3 element.

I will try to extract a simple code to show this issue today with this to show it to you.
Thank you :)

Sorry for the delay. I made a simple setup that plots a map of the Hawaiian islands and implements a lasso. The selected array in the lasso function is always empty.
One file is the map in topojson format and the other is the main html.
Let me know.
Thank you so much for your time!
This is the code for test.html (link to your lasso library I have a local link)

#################################################################
code for topojson object:
{"type":"Topology","objects":{"filterMap":{"type":"GeometryCollection","geometries":[{"type":"MultiPolygon","properties":{"name":"Hawaii"},"id":"USH","arcs":[[[0]],[[1]],[[2]],[[3]],[[4]],[[5]],[[6]],[[7]],[[8]],[[9]],[[10]],[[11]],[[12]],[[13]]]}]},"hawaiiPlaces":{"type":"GeometryCollection","geometries":[{"type":"Point","properties":{"name":"Lihue"},"coordinates":[8059,3238]},{"type":"Point","properties":{"name":"Wahiawa"},"coordinates":[8633,2735]},{"type":"Point","properties":{"name":"Wailuku"},"coordinates":[9279,2091]},{"type":"Point","properties":{"name":"Kailua-Kona"},"coordinates":[9501,786]},{"type":"Point","properties":{"name":"Hilo"},"coordinates":[9882,836]},{"type":"Point","properties":{"name":"Honolulu"},"coordinates":[8702,2530]}]}},"arcs":[[[9662,1297],[8,-16],[10,6],[15,-2],[16,-14],[30,-24],[37,-46],[50,-75],[20,-30],[23,-53],[12,-38],[0,-42],[-1,-55],[2,-43],[11,1],[17,18],[12,-20],[6,-22],[-2,-45],[6,-28],[7,-26],[22,-47],[22,-23],[9,-19],[5,-22],[-1,-28],[-6,-16],[-19,-54],[-19,-17],[-27,-61],[-18,-12],[0,-12],[-16,-9],[-13,-23],[-25,-18],[-22,-14],[-17,10],[-11,1],[-9,-7],[-10,-14],[-13,-22],[-8,-23],[-9,-3],[-6,-7],[-10,-14],[-6,-11],[-22,-29],[-6,-5],[-19,-42],[-3,-17],[1,-38],[-8,-20],[-13,-31],[-7,-44],[-7,-16],[-7,-15],[-10,-21],[-4,5],[0,23],[-9,17],[-17,22],[-20,29],[-11,17],[-18,11],[-8,5],[-2,20],[-3,19],[-6,4],[-3,28],[-4,45],[5,53],[10,153],[-1,26],[-6,25],[-5,33],[-7,50],[-3,21],[-4,13],[-4,21],[1,23],[-5,22],[-3,24],[-4,30],[-8,26],[-6,11],[-9,26],[-10,67],[4,30],[5,25],[9,18],[9,14],[4,11],[2,20],[6,11],[18,16],[8,35],[5,12],[9,40],[10,25],[6,0],[3,33],[2,14],[-3,20],[-7,16],[-15,53],[-6,47],[-1,37],[0,34],[8,37],[6,12],[15,0],[28,-15],[12,-5],[2,-6],[1,-8],[1,-10],[7,-27],[16,-15],[11,-14],[7,-21],[11,-11]],[[9267,1712],[-5,-20],[-12,0],[-11,5],[-8,-4],[-12,-6],[-14,-4],[-9,22],[5,16],[9,18],[12,19],[13,16],[11,10],[9,-2],[11,-29],[-6,-31],[7,-10]],[[9105,1926],[-20,-3],[-9,29],[-2,24],[-1,20],[0,25],[-1,22],[-7,10],[-18,16],[-5,20],[3,23],[10,12],[18,5],[41,-15],[19,-39],[7,-17],[7,-20],[4,-17],[1,-13],[-2,-18],[-10,-34],[-19,-20],[-16,-10]],[[9243,2234],[4,-10],[4,-2],[7,-8],[5,-6],[2,-13],[5,-3],[2,-14],[0,-13],[5,-12],[4,-14],[3,-16],[5,-19],[8,2],[4,12],[9,0],[6,3],[12,1],[5,3],[14,23],[6,6],[7,1],[7,0],[7,-2],[6,-6],[2,-1],[1,0],[1,-3],[1,-4],[6,4],[7,-10],[2,-12],[3,-6],[3,-8],[4,-13],[8,-12],[5,-12],[1,-10],[5,-1],[2,0],[2,6],[5,-10],[3,-14],[2,-9],[15,-5],[14,-16],[21,-16],[10,-46],[-2,-41],[-8,-34],[-11,-7],[-8,-30],[-12,0],[-23,-28],[-15,1],[-9,2],[-8,-1],[-21,-23],[-13,-16],[-8,-8],[-10,6],[-4,1],[-7,5],[-5,-4],[-18,-2],[-12,26],[-1,11],[-6,14],[4,8],[0,18],[-4,70],[-3,19],[0,21],[-2,18],[-2,3],[-3,7],[-5,6],[-6,-1],[-6,-6],[-3,-15],[-5,-2],[-6,8],[-6,11],[-10,4],[-9,13],[-6,-1],[-5,17],[-10,25],[-12,37],[-1,23],[-4,12],[2,22],[2,29],[4,25],[5,17],[5,1],[3,9],[1,8],[4,6],[3,-1],[5,-1],[4,3],[1,5],[3,0],[3,-5]],[[8963,2438],[6,-2],[10,1],[6,-4],[3,-12],[7,0],[40,-14],[22,-8],[16,-2],[3,12],[1,10],[2,8],[4,3],[6,-18],[2,-20],[9,-7],[12,-6],[22,1],[9,3],[6,5],[5,4],[3,-2],[8,2],[6,-5],[4,-2],[5,2],[2,-4],[-1,-5],[3,-4],[7,1],[3,-5],[-8,-35],[-13,-30],[-17,-20],[-16,-16],[-16,-8],[-17,4],[-16,8],[-33,20],[-20,17],[-29,-6],[-20,-2],[-15,-6],[-12,2],[-10,-1],[-8,8],[-5,15],[0,20],[3,16],[5,13],[8,7],[7,19],[2,20],[-6,16],[0,8],[5,-1]],[[8688,2835],[3,-18],[4,-6],[2,-7],[1,-12],[3,2],[4,-3],[3,-9],[4,-15],[1,-16],[0,-8],[-4,0],[-2,-6],[1,-18],[1,-11],[1,-18],[4,-3],[5,-5],[4,-12],[4,-13],[6,-5],[1,-8],[4,-4],[3,8],[4,13],[-6,10],[0,12],[5,5],[10,-3],[6,3],[1,-8],[-6,-14],[-2,-19],[1,-15],[7,-10],[6,-13],[1,-9],[-2,-12],[2,-12],[4,-17],[9,-14],[9,-11],[3,-6],[-5,-14],[-11,-22],[-4,-10],[-4,-4],[-2,7],[1,9],[-4,8],[-11,-7],[-10,-3],[-7,-8],[-6,-11],[-7,0],[-3,3],[-2,9],[-3,12],[-14,14],[-7,8],[-5,15],[-1,10],[0,10],[-3,-3],[-6,-13],[4,-11],[-18,-3],[1,5],[2,3],[-3,7],[-7,-1],[0,11],[-1,8],[1,7],[-2,7],[5,5],[4,5],[5,6],[2,9],[-5,10],[-5,4],[-3,4],[-1,-4],[-2,-13],[-4,4],[-3,9],[-2,7],[0,-14],[2,-17],[-2,-3],[-9,18],[-4,8],[3,-18],[7,-17],[5,-10],[4,-8],[-2,-16],[-8,-7],[-10,-4],[-15,-8],[-8,-2],[-7,-5],[-2,2],[-2,4],[-5,6],[-4,36],[-4,28],[-6,16],[-4,14],[-8,10],[-2,28],[-3,15],[-7,15],[-5,7],[-5,19],[0,21],[-1,31],[-3,9],[-18,36],[3,3],[15,7],[18,2],[12,-1],[7,0],[6,3],[6,-3],[2,13],[2,6],[8,10],[8,16],[4,7],[-1,6],[3,12],[4,20],[7,13],[9,19],[13,8],[6,0],[3,-5],[2,-6],[3,-9],[7,-13],[0,-12],[4,-4],[0,-9],[4,-9],[-2,-19],[5,-18],[6,-13]],[[7707,3030],[-5,-4],[-6,10],[-5,4],[-5,37],[1,24],[5,25],[16,39],[14,24],[17,23],[3,14],[2,13],[-1,19],[8,8],[7,-1],[8,-6],[4,-19],[-4,-9],[-5,-16],[-3,-22],[3,-29],[-6,-18],[-7,-8],[-6,-8],[-9,-6],[-9,-14],[-6,-11],[-3,-16],[-5,-31],[-3,-22]],[[8052,3499],[6,-7],[7,0],[8,-10],[3,-16],[6,-12],[2,-2],[2,-14],[2,-10],[1,-11],[4,-5],[0,-11],[-1,-30],[-4,-12],[-6,-40],[-7,-9],[0,-29],[1,-19],[0,-20],[0,-20],[-1,-8],[-6,0],[-5,-6],[4,-8],[1,-9],[-2,-7],[-5,1],[-8,-14],[-3,-13],[-3,-7],[-7,-11],[-1,-8],[-5,-1],[-2,-6],[-2,-5],[-19,15],[-12,3],[-8,0],[-16,7],[-7,2],[-3,7],[-2,-1],[-1,-7],[-3,-2],[-2,8],[-6,6],[-5,9],[-3,10],[-2,9],[-2,9],[-5,2],[-1,9],[-5,5],[-8,3],[-7,6],[-5,6],[-8,4],[-7,5],[-4,18],[-1,10],[-4,5],[-3,10],[0,15],[1,12],[0,13],[-1,9],[5,4],[11,30],[6,18],[1,11],[0,9],[0,7],[3,3],[1,3],[3,12],[10,6],[11,6],[12,17],[8,16],[10,11],[3,11],[6,5],[4,0],[3,7],[5,-2],[3,-6],[1,-7],[4,-1],[5,-4],[4,-6],[4,1],[-2,8],[2,7],[7,7],[8,-3],[10,1],[5,-8],[4,2],[5,7],[3,7],[5,-7]],[[6964,4353],[-2,-2],[1,4],[0,3],[1,2],[2,-1],[-1,-4],[0,-1],[-1,-1]],[[5789,4921],[2,-9],[-3,2],[-1,2],[1,2],[1,3]],[[4388,6422],[0,-4],[-3,15],[1,1],[2,-5],[0,-4],[0,-3]],[[2802,7231],[-3,-22],[-4,4],[-1,14],[8,4]],[[1850,7533],[-1,-5],[-2,4],[0,3],[0,5],[0,5],[1,-5],[1,-4],[1,-3]],[[3,9984],[-2,-1],[-1,2],[3,3],[1,4],[1,3],[1,4],[1,-9],[-2,-3],[-2,-3]]],"transform":{"scale":[0.002349265186218617,0.00094965110831083],"translate":[-178.30436616299988,18.906117143000117]}}

This is the code for test.html (link to your lasso library I have a local link)

##########################################################################################################
code for topojson object:
{"type":"Topology","objects":{"filterMap":{"type":"GeometryCollection","geometries":[{"type":"MultiPolygon","properties":{"name":"Hawaii"},"id":"USH","arcs":[[[0]],[[1]],[[2]],[[3]],[[4]],[[5]],[[6]],[[7]],[[8]],[[9]],[[10]],[[11]],[[12]],[[13]]]}]},"hawaiiPlaces":{"type":"GeometryCollection","geometries":[{"type":"Point","properties":{"name":"Lihue"},"coordinates":[8059,3238]},{"type":"Point","properties":{"name":"Wahiawa"},"coordinates":[8633,2735]},{"type":"Point","properties":{"name":"Wailuku"},"coordinates":[9279,2091]},{"type":"Point","properties":{"name":"Kailua-Kona"},"coordinates":[9501,786]},{"type":"Point","properties":{"name":"Hilo"},"coordinates":[9882,836]},{"type":"Point","properties":{"name":"Honolulu"},"coordinates":[8702,2530]}]}},"arcs":[[[9662,1297],[8,-16],[10,6],[15,-2],[16,-14],[30,-24],[37,-46],[50,-75],[20,-30],[23,-53],[12,-38],[0,-42],[-1,-55],[2,-43],[11,1],[17,18],[12,-20],[6,-22],[-2,-45],[6,-28],[7,-26],[22,-47],[22,-23],[9,-19],[5,-22],[-1,-28],[-6,-16],[-19,-54],[-19,-17],[-27,-61],[-18,-12],[0,-12],[-16,-9],[-13,-23],[-25,-18],[-22,-14],[-17,10],[-11,1],[-9,-7],[-10,-14],[-13,-22],[-8,-23],[-9,-3],[-6,-7],[-10,-14],[-6,-11],[-22,-29],[-6,-5],[-19,-42],[-3,-17],[1,-38],[-8,-20],[-13,-31],[-7,-44],[-7,-16],[-7,-15],[-10,-21],[-4,5],[0,23],[-9,17],[-17,22],[-20,29],[-11,17],[-18,11],[-8,5],[-2,20],[-3,19],[-6,4],[-3,28],[-4,45],[5,53],[10,153],[-1,26],[-6,25],[-5,33],[-7,50],[-3,21],[-4,13],[-4,21],[1,23],[-5,22],[-3,24],[-4,30],[-8,26],[-6,11],[-9,26],[-10,67],[4,30],[5,25],[9,18],[9,14],[4,11],[2,20],[6,11],[18,16],[8,35],[5,12],[9,40],[10,25],[6,0],[3,33],[2,14],[-3,20],[-7,16],[-15,53],[-6,47],[-1,37],[0,34],[8,37],[6,12],[15,0],[28,-15],[12,-5],[2,-6],[1,-8],[1,-10],[7,-27],[16,-15],[11,-14],[7,-21],[11,-11]],[[9267,1712],[-5,-20],[-12,0],[-11,5],[-8,-4],[-12,-6],[-14,-4],[-9,22],[5,16],[9,18],[12,19],[13,16],[11,10],[9,-2],[11,-29],[-6,-31],[7,-10]],[[9105,1926],[-20,-3],[-9,29],[-2,24],[-1,20],[0,25],[-1,22],[-7,10],[-18,16],[-5,20],[3,23],[10,12],[18,5],[41,-15],[19,-39],[7,-17],[7,-20],[4,-17],[1,-13],[-2,-18],[-10,-34],[-19,-20],[-16,-10]],[[9243,2234],[4,-10],[4,-2],[7,-8],[5,-6],[2,-13],[5,-3],[2,-14],[0,-13],[5,-12],[4,-14],[3,-16],[5,-19],[8,2],[4,12],[9,0],[6,3],[12,1],[5,3],[14,23],[6,6],[7,1],[7,0],[7,-2],[6,-6],[2,-1],[1,0],[1,-3],[1,-4],[6,4],[7,-10],[2,-12],[3,-6],[3,-8],[4,-13],[8,-12],[5,-12],[1,-10],[5,-1],[2,0],[2,6],[5,-10],[3,-14],[2,-9],[15,-5],[14,-16],[21,-16],[10,-46],[-2,-41],[-8,-34],[-11,-7],[-8,-30],[-12,0],[-23,-28],[-15,1],[-9,2],[-8,-1],[-21,-23],[-13,-16],[-8,-8],[-10,6],[-4,1],[-7,5],[-5,-4],[-18,-2],[-12,26],[-1,11],[-6,14],[4,8],[0,18],[-4,70],[-3,19],[0,21],[-2,18],[-2,3],[-3,7],[-5,6],[-6,-1],[-6,-6],[-3,-15],[-5,-2],[-6,8],[-6,11],[-10,4],[-9,13],[-6,-1],[-5,17],[-10,25],[-12,37],[-1,23],[-4,12],[2,22],[2,29],[4,25],[5,17],[5,1],[3,9],[1,8],[4,6],[3,-1],[5,-1],[4,3],[1,5],[3,0],[3,-5]],[[8963,2438],[6,-2],[10,1],[6,-4],[3,-12],[7,0],[40,-14],[22,-8],[16,-2],[3,12],[1,10],[2,8],[4,3],[6,-18],[2,-20],[9,-7],[12,-6],[22,1],[9,3],[6,5],[5,4],[3,-2],[8,2],[6,-5],[4,-2],[5,2],[2,-4],[-1,-5],[3,-4],[7,1],[3,-5],[-8,-35],[-13,-30],[-17,-20],[-16,-16],[-16,-8],[-17,4],[-16,8],[-33,20],[-20,17],[-29,-6],[-20,-2],[-15,-6],[-12,2],[-10,-1],[-8,8],[-5,15],[0,20],[3,16],[5,13],[8,7],[7,19],[2,20],[-6,16],[0,8],[5,-1]],[[8688,2835],[3,-18],[4,-6],[2,-7],[1,-12],[3,2],[4,-3],[3,-9],[4,-15],[1,-16],[0,-8],[-4,0],[-2,-6],[1,-18],[1,-11],[1,-18],[4,-3],[5,-5],[4,-12],[4,-13],[6,-5],[1,-8],[4,-4],[3,8],[4,13],[-6,10],[0,12],[5,5],[10,-3],[6,3],[1,-8],[-6,-14],[-2,-19],[1,-15],[7,-10],[6,-13],[1,-9],[-2,-12],[2,-12],[4,-17],[9,-14],[9,-11],[3,-6],[-5,-14],[-11,-22],[-4,-10],[-4,-4],[-2,7],[1,9],[-4,8],[-11,-7],[-10,-3],[-7,-8],[-6,-11],[-7,0],[-3,3],[-2,9],[-3,12],[-14,14],[-7,8],[-5,15],[-1,10],[0,10],[-3,-3],[-6,-13],[4,-11],[-18,-3],[1,5],[2,3],[-3,7],[-7,-1],[0,11],[-1,8],[1,7],[-2,7],[5,5],[4,5],[5,6],[2,9],[-5,10],[-5,4],[-3,4],[-1,-4],[-2,-13],[-4,4],[-3,9],[-2,7],[0,-14],[2,-17],[-2,-3],[-9,18],[-4,8],[3,-18],[7,-17],[5,-10],[4,-8],[-2,-16],[-8,-7],[-10,-4],[-15,-8],[-8,-2],[-7,-5],[-2,2],[-2,4],[-5,6],[-4,36],[-4,28],[-6,16],[-4,14],[-8,10],[-2,28],[-3,15],[-7,15],[-5,7],[-5,19],[0,21],[-1,31],[-3,9],[-18,36],[3,3],[15,7],[18,2],[12,-1],[7,0],[6,3],[6,-3],[2,13],[2,6],[8,10],[8,16],[4,7],[-1,6],[3,12],[4,20],[7,13],[9,19],[13,8],[6,0],[3,-5],[2,-6],[3,-9],[7,-13],[0,-12],[4,-4],[0,-9],[4,-9],[-2,-19],[5,-18],[6,-13]],[[7707,3030],[-5,-4],[-6,10],[-5,4],[-5,37],[1,24],[5,25],[16,39],[14,24],[17,23],[3,14],[2,13],[-1,19],[8,8],[7,-1],[8,-6],[4,-19],[-4,-9],[-5,-16],[-3,-22],[3,-29],[-6,-18],[-7,-8],[-6,-8],[-9,-6],[-9,-14],[-6,-11],[-3,-16],[-5,-31],[-3,-22]],[[8052,3499],[6,-7],[7,0],[8,-10],[3,-16],[6,-12],[2,-2],[2,-14],[2,-10],[1,-11],[4,-5],[0,-11],[-1,-30],[-4,-12],[-6,-40],[-7,-9],[0,-29],[1,-19],[0,-20],[0,-20],[-1,-8],[-6,0],[-5,-6],[4,-8],[1,-9],[-2,-7],[-5,1],[-8,-14],[-3,-13],[-3,-7],[-7,-11],[-1,-8],[-5,-1],[-2,-6],[-2,-5],[-19,15],[-12,3],[-8,0],[-16,7],[-7,2],[-3,7],[-2,-1],[-1,-7],[-3,-2],[-2,8],[-6,6],[-5,9],[-3,10],[-2,9],[-2,9],[-5,2],[-1,9],[-5,5],[-8,3],[-7,6],[-5,6],[-8,4],[-7,5],[-4,18],[-1,10],[-4,5],[-3,10],[0,15],[1,12],[0,13],[-1,9],[5,4],[11,30],[6,18],[1,11],[0,9],[0,7],[3,3],[1,3],[3,12],[10,6],[11,6],[12,17],[8,16],[10,11],[3,11],[6,5],[4,0],[3,7],[5,-2],[3,-6],[1,-7],[4,-1],[5,-4],[4,-6],[4,1],[-2,8],[2,7],[7,7],[8,-3],[10,1],[5,-8],[4,2],[5,7],[3,7],[5,-7]],[[6964,4353],[-2,-2],[1,4],[0,3],[1,2],[2,-1],[-1,-4],[0,-1],[-1,-1]],[[5789,4921],[2,-9],[-3,2],[-1,2],[1,2],[1,3]],[[4388,6422],[0,-4],[-3,15],[1,1],[2,-5],[0,-4],[0,-3]],[[2802,7231],[-3,-22],[-4,4],[-1,14],[8,4]],[[1850,7533],[-1,-5],[-2,4],[0,3],[0,5],[0,5],[1,-5],[1,-4],[1,-3]],[[3,9984],[-2,-1],[-1,2],[3,3],[1,4],[1,3],[1,4],[1,-9],[-2,-3],[-2,-3]]],"transform":{"scale":[0.002349265186218617,0.00094965110831083],"translate":[-178.30436616299988,18.906117143000117]}}
Alberto González Martínez
<EMAIL_ADDRESS>
On Mar 31, 2015, at 2:08 AM, Speros Kokenes<EMAIL_ADDRESS>wrote:
Hey, if you can post some sample code that would be great. You are right - there should be no issue with the type of graph that the lasso is used with; it is designed to work with any d3 element.
—
Reply to this email directly or view it on GitHub https://github.com/skokenes/D3-Lasso-Plugin/issues/2#issuecomment-88062712.

Did you receive the email I sent you?

Hey Alberto, sorry for the delay. I have been making some updates of my own
to the lasso to fix some bugs. I am going to upload this latest version
today. Can you test your solution with the latest version when it is
available, then let me know if your problem still exists?
Thanks
Speros
On Friday, April 17, 2015, Alberto Gonzalez<EMAIL_ADDRESS>wrote:

Reopened #2 https://github.com/skokenes/D3-Lasso-Plugin/issues/2.
—
Reply to this email directly or view it on GitHub
https://github.com/skokenes/D3-Lasso-Plugin/issues/2#event-283818737.

Hey Alberto,
This is an issue with your code and not the library, so I am going to close this item.
I did work with your code and produced a working version based on what you sent me:
http://bl.ocks.org/skokenes/498a150f94cd21e2270f
The two issues that I fixed:

The pins were not being properly classed to ".pin". I am not sure I have seen d3's append() method take a second parameter. Regardless, I set the class attr to "pin" instead so that the dots would be properly classed for selection.
You are passing the selection of pins into the lasso item list before the pins are created. The pins are created via an asynchronous function that runs after you have loaded your data. Your lasso.items() declaration was outside of this asynchronous statement and was being executed before the data ever loaded, meaning that the pins did not exist yet. I moved the lasso.items() declaration inside the asynchronous function, after the pins have been created.

I also added some CSS for the lasso just so you could see that it's working.
Thanks
Speros

Thank you!
I am sorry it was my mistake. I am looking at the code now and it seems I confused when copy pasting to send you the test file. In my code I pass the lasso items inside the asynchronous call as you did. I changed the class of the elements in my code as “.dot” instead of “.pin", but I assume it does not matter, if you send the correct objects to the lasso is it? It works for scatterplots where I have the same setup, with the elements declared as “.dot”.
In my complete setup I have multiple graphs so the elements for the lasso have 2 different classes, one to address all the elements in each graph and the other to address each of the individual elements inside a determined graph.
For example: “graphArea1 dot1” —> element 1 of graph 1
So I create the elements with a selectAll(“graphArea1”) and lasso.items(d3.selectAll(“.graphArea1"));
With the new version the selection does not work on the scatterplot unless I hover over the dots, but if you where able to do it, it has to be some typo in my code, I will continue debugging the issue and see if I find whats wrong.
thank you so much.
Alberto González Martínez
<EMAIL_ADDRESS>
On Apr 23, 2015, at 7:26 AM, Speros Kokenes<EMAIL_ADDRESS>wrote:
Closed #2 https://github.com/skokenes/D3-Lasso-Plugin/issues/2.
—
Reply to this email directly or view it on GitHub https://github.com/skokenes/D3-Lasso-Plugin/issues/2#event-288539279.


Is EndToEndSpec.kt executed during build process?

Hey guys!
I've just tried to break the specification locally, unfortunately maven is still reporting build success.
Looking into the specification itself I didn't find a test class in, rather a script. So the question is whether there's a special way to execute this specification or is it simply ignored?

Looks like EndToEndSpec.groovy calls EndToEndSpecKt.createSchema() to create the schema as defined in the Kotlin file. So it looks like the Kotlin file is used to define the actual test schema with the types and resolver classes which is uses by the Groovy test specifiction.


Proposed alternative to trash can in radial menu (make "delete" harder to hit).

This is a proposal to make deleting a feature harder with iD.  Or, put another way, to make delete prominent at the "right level" compared to expected editing patterns.  First the proposal:

Remove the Trash Can from the radial menu.  This means when clicking on a POI no radial menu will come up at all.  iD would become a bit more opinionated : encouraging the user to first scan the feature's associated tags.  Thus the feature removal trash can moves to the bottom of the "Edit feature" pane.

Remove the shortcut binding to Backspace.  Just because P2 and JOSM have this, does not make it right for iD.

Retain the Trash Can in the radial menu, but only for nodes that are part of a way.  The trash can removes only the node.  When you hover over a way node with tags, it would say "This node has (X) tags, and is part of a larger feature with (X) tags, and (Y) relations".  This will help keep people from deleting barrier=toll_both or highway=turnnig_circle, if all they really wanted to do was adjust the geometry of the way.  And help new users understand that every node can have tags, even if it is part of something larger.

In general this will allow the radial menu to control only geometry, rather than geometry plus existence.
One downside is on features with a lot of tags, since you'll often need to scroll to find the trash can.  But I think this is good: if someone took the trouble to add that many tags, perhaps it is only courtesy to force the user to read the tags prior to deleting the entire thing ;-).

I think this issue can finally be closed

I'm in favour of keeping it as it is - there's always the 'undo' function for erroneous deletions.
Unfortunately, iD is difficult to use with complex objects and deleting and starting again is an easier solution despite some data loss.


The units on the heat map hardcoded to CPM

We created a duplicate ticket that we put into our current sprint: Make experiment unit adaptable not hard-coded in marker gene heatmap, so I am closing this one.


Add Qwertycoin (QWC) Icon

Hi there,
Can you please add a logo for Qwertycoin?
It has recently been listed on CoinLib.io, Delta App & Crex24.
Original logo:
https://qwertycoin.org/wp-content/uploads/2018/05/QWC-Alt-Light-Transparent.png
Thank you.

Hi Christopher,
Unfortunately we don’t have one available at the moment (issues with the machine I had it on).
Please let me know if it’ll be an issue - thanks for your help.
Cheers,
Jordan.

On 21 May 2018, at 8:25 pm, Christopher Downer<EMAIL_ADDRESS>wrote:
Is it possible you have a vector SVG? If not, I'll re-draw it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/cjdowner/cryptocurrency-icons/issues/102#issuecomment-390639362, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6qSOsP2_hcvAsmX-Ur0ZEoKO9UugKtks5t0rI-gaJpZM4T12Mz.

Hi Christopher,
Sorry for the delay - please find attached 500x500 SVG.
Let me know if you need anything else.
Thanks.

On 21 May 2018, at 8:25 pm, Christopher Downer<EMAIL_ADDRESS>wrote:
Is it possible you have a vector SVG? If not, I'll re-draw it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/cjdowner/cryptocurrency-icons/issues/102#issuecomment-390639362, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6qSOsP2_hcvAsmX-Ur0ZEoKO9UugKtks5t0rI-gaJpZM4T12Mz.

@jordanlovelle Replying with attachments doesn't work with GitHub. Can you comment with the file through the GitHub UI instead?

@sindresorhus - sorry for that, I didn't realise. Thanks for the heads up.
Please find the .svg for Qwertycoin's current logo attached.
Please let me know if there's anything else.
Thanks,
Jordan.
QWC Vector.svg.zip

@jordanlovelle The SVG you have provided is just a PNG embedded in an SVG file. We will need a proper vectorized version of the logo.

@sindresorhus please find attached.
Thanks,
Jordan.
QWC Logo v3.svg.zip

@jordanlovelle Still not a valid vector file.

@sindresorhus - I'm not sure what you're after.
Have you opened the file? Is it the background throwing you off?
Attached is the above SVG file (as requested) opened within Illustrator, showing all vectorised paths and with the background switched off.
If you can provide anymore insight as to what's wrong that'd be great.

@jordanlovelle Creating the file in Illustrator doesn't automatically make it vector. As you can see on the right sidebar, you have many layers called Image. Those are bitmap images and are embedded as bitmap (not vector) in the SVG. The SVG size is 636 kb, it should be around 2 kb.
From the SVG source:

@jordanlovelle Not sure if this will help but here's the link to the wiki which shows how to create an icon: https://github.com/atomiclabs/cryptocurrency-icons/wiki
Granted, this is just one way to do it, but it could be a good guide to understanding the requirements.