Pytorch 1.0 branch ImportError: torch.utils.ffi is deprecated

I followed the instructions for Pytorch 1.0: switched to pytorch-1.0 branch, went to lib and ran python setup.py build develop. Install succeeded with no errors.
However, when I try to import roi_pool in the Python prompt, I get "torch.utils.ffi is deprecated" error. Isn't this supposed to be fixed in the pytorch-1.0 branch?
Python 3.7.2 (default, Dec 29 2018, 06:19:36)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from model.roi_pooling.modules import roi_pool
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/remoteuser/faster-rcnn.pytorch/lib/model/roi_pooling/modules/roi_pool.py", line 2, in <module>
    from ..functions.roi_pool import RoIPoolFunction
  File "/home/remoteuser/faster-rcnn.pytorch/lib/model/roi_pooling/functions/roi_pool.py", line 3, in <module>
    from .._ext import roi_pooling
  File "/home/remoteuser/faster-rcnn.pytorch/lib/model/roi_pooling/_ext/roi_pooling/__init__.py", line 2, in <module>
    from torch.utils.ffi import _wrap_function
  File "/home/remoteuser/.miniconda3/envs/outfit/lib/python3.7/site-packages/torch/utils/ffi/__init__.py", line 1, in <module>
    raise ImportError("torch.utils.ffi is deprecated. Please use cpp extensions instead.")
ImportError: torch.utils.ffi is deprecated. Please use cpp extensions instead.

Thank you!

I encountered the same problem. It is because the version of pytorch isn't  compatible with the repo. You could change the pytorch to 0.4.0. I solve the problem in this way.

Thanks @ericsqxd , but the README says "Good news! This repo supports pytorch-1.0 now!!! We borrowed some code and techniques from maskrcnn-benchmark. Just go to pytorch-1.0 branch!"
1.0 should be supported right?

@andrewjong @ericsqxd You need to checkout the pytorch-1.0 branch. The master branch supports Pytorch 0.4.

@odellus If you look at the setup script lib/setup.py, it does not call the said file you mentioned. The ROI and NMS files that are used now reside here, source for the same are here. The files you pointed are required for PyTorch < 0.4.1 and have not been deleted from PyTorch 1.0 branch.

But, how to solve the error?

@zcunyi After cloning the repo, you need to switch to the Pytorch-1.0 branch via git checkout pytorch-1.0. Then you can proceed with the installation instructions given in the README of pytorch-1.0 branch.

@lzxzy Hi, I got the same problem as you mentioned, did you solve the problem ?

I figured it out! My goal was to import the roi_layers for my project. The problem was I had the wrong import statement.
Before I had:
from model.roi_pooling.modules import roi_pool
It should be:
from model.roi_layers import ROIPool
Then it works with no problems.

I clone the code from branch pytorch-1.0. But I still have this problem.

This problem still exists when one wants to use the demo file.

copy the following code to torch.utils.ffi.init.py,these codes are copied from torch.utils.ffi.init.py of pytorch 0.4.1,and then the raise ImportError can be solved.But I don't whether the change will influence the next process.
#raise ImportError("torch.utils.ffi is deprecated. Please use cpp extensions instead.")
from functools import wraps
def _wrap_function(function, ffi):
@wraps(function)
def safe_call(args, **kwargs):
args = tuple(ffi.cast(_torch_to_cffi.get(arg.type(), 'void') + '', arg._cdata)
if isinstance(arg, torch.Tensor) or torch.is_storage(arg)
else arg
for arg in args)
args = (function,) + args
result = torch._C._safe_call(*args, **kwargs)
if isinstance(result, ffi.CData):
typeof = ffi.typeof(result)
if typeof.kind == 'pointer':
cdata = int(ffi.cast('uintptr_t', result))
cname = typeof.item.cname
if cname in _cffi_to_torch:
# TODO: Maybe there is a less janky way to eval
# off of this
return eval(_cffi_to_torch[cname])(cdata=cdata)
return result
return safe_call

Does this program work in pytorch1.0, how to fix the error or replace the error reporting module????

@zcunyi After cloning the repo, you need to switch to the Pytorch-1.0 branch via git checkout pytorch-1.0. Then you can proceed with the installation instructions given in the README of pytorch-1.0 branch.

Awesome! Shall we add it specifically in the readme.md?

If you look here you can see the ffi tools are still used on the pytorch-1.0 branch.

For my case, ffi is already deprecated in PyTorch 1.0.0

check git branch to pytorch-1.0 worked for me

I solved by adding the source code of torch.utils.ffi to my project without changing my pytorch version.(I use torch 1.4.0).
for example, save the following code to ffiext.py, then you can replace from  torch.utils.ffi import _wrap_function with from  ffiext import _wrap_function.
import os
import glob
import tempfile
import shutil
from functools import wraps, reduce
from string import Template
import torch
import torch.cuda
from torch._utils import _accumulate

try:
	import cffi
except ImportError:
	raise ImportError("torch.utils.ffi requires the cffi package")

if cffi.__version_info__ < (1, 4, 0):
	raise ImportError("torch.utils.ffi requires cffi version >= 1.4, but "
					  "got " + '.'.join(map(str, cffi.__version_info__)))

def _generate_typedefs():
	typedefs = []
	for t in ['Double', 'Float', 'Long', 'Int', 'Short', 'Char', 'Byte']:
		for lib in ['TH', 'THCuda']:
			for kind in ['Tensor', 'Storage']:
				python_name = t + kind
				if t == 'Float' and lib == 'THCuda':
					th_name = 'THCuda' + kind
				else:
					th_name = lib + t + kind
				th_struct = 'struct ' + th_name

				typedefs += ['typedef {} {};'.format(th_struct, th_name)]
				# We have to assemble a string here, because we're going to
				# do this lookup based on tensor.type(), which returns a
				# string (not a type object, as this code was before)
				python_module = 'torch.cuda' if lib == 'THCuda' else 'torch'
				python_class = python_module + '.' + python_name
				_cffi_to_torch[th_struct] = python_class
				_torch_to_cffi[python_class] = th_struct
	return '\n'.join(typedefs) + '\n'
_cffi_to_torch = {}
_torch_to_cffi = {}
_typedefs = _generate_typedefs()

PY_MODULE_TEMPLATE = Template("""
from torch.utils.ffi import _wrap_function
from .$cffi_wrapper_name import lib as _lib, ffi as _ffi

__all__ = []
def _import_symbols(locals):
	for symbol in dir(_lib):
		fn = getattr(_lib, symbol)
		if callable(fn):
			locals[symbol] = _wrap_function(fn, _ffi)
		else:
			locals[symbol] = fn
		__all__.append(symbol)

_import_symbols(locals())
""")

def _setup_wrapper(with_cuda):
	here = os.path.abspath(os.path.dirname(__file__))
	lib_dir = os.path.join(here, '..', '..', 'lib')
	include_dirs = [
		os.path.join(lib_dir, 'include'),
		os.path.join(lib_dir, 'include', 'TH'),
	]

	wrapper_source = '#include <TH/TH.h>\n'
	if with_cuda:
		import torch.cuda
		wrapper_source += '#include <THC/THC.h>\n'
		if os.sys.platform == 'win32':
			cuda_include_dirs = glob.glob(os.getenv('CUDA_PATH', '') + '/include')
			cuda_include_dirs += glob.glob(os.getenv('NVTOOLSEXT_PATH', '') + '/include')
		else:
			cuda_include_dirs = glob.glob('/usr/local/cuda/include')
			cuda_include_dirs += glob.glob('/Developer/NVIDIA/CUDA-*/include')
		include_dirs.append(os.path.join(lib_dir, 'include', 'THC'))
		include_dirs.extend(cuda_include_dirs)
	return wrapper_source, include_dirs

def _create_module_dir(base_path, fullname):
	module, _, name = fullname.rpartition('.')
	if not module:
		target_dir = name
	else:
		target_dir = reduce(os.path.join, fullname.split('.'))
	target_dir = os.path.join(base_path, target_dir)
	try:
		os.makedirs(target_dir)
	except os.error:
		pass
	for dirname in _accumulate(fullname.split('.'), os.path.join):
		init_file = os.path.join(base_path, dirname, '__init__.py')
		open(init_file, 'a').close()  # Create file if it doesn't exist yet
	return name, target_dir

def _build_extension(ffi, cffi_wrapper_name, target_dir, verbose):
	try:
		tmpdir = tempfile.mkdtemp()
		ext_suf = '.pyd' if os.sys.platform == 'win32' else '.so'
		libname = cffi_wrapper_name + ext_suf
		outfile = ffi.compile(tmpdir=tmpdir, verbose=verbose, target=libname)
		shutil.copy(outfile, os.path.join(target_dir, libname))
	finally:
		shutil.rmtree(tmpdir)

def _make_python_wrapper(name, cffi_wrapper_name, target_dir):
	py_source = PY_MODULE_TEMPLATE.substitute(name=name,
											  cffi_wrapper_name=cffi_wrapper_name)
	with open(os.path.join(target_dir, '__init__.py'), 'w') as f:
		f.write(py_source)

def create_extension(name, headers, sources, verbose=True, with_cuda=False,
					 package=False, relative_to='.', **kwargs):
	base_path = os.path.abspath(os.path.dirname(relative_to))
	name_suffix, target_dir = _create_module_dir(base_path, name)
	if not package:
		cffi_wrapper_name = '_' + name_suffix
	else:
		cffi_wrapper_name = (name.rpartition('.')[0] +
							 '.{0}._{0}'.format(name_suffix))

	wrapper_source, include_dirs = _setup_wrapper(with_cuda)
	include_dirs.extend(kwargs.pop('include_dirs', []))

	if os.sys.platform == 'win32':
		library_dirs = glob.glob(os.getenv('CUDA_PATH', '') + '/lib/x64')
		library_dirs += glob.glob(os.getenv('NVTOOLSEXT_PATH', '') + '/lib/x64')

		here = os.path.abspath(os.path.dirname(__file__))
		lib_dir = os.path.join(here, '..', '..', 'lib')

		library_dirs.append(os.path.join(lib_dir))
	else:
		library_dirs = []
	library_dirs.extend(kwargs.pop('library_dirs', []))

	if isinstance(headers, str):
		headers = [headers]
	all_headers_source = ''
	for header in headers:
		with open(os.path.join(base_path, header), 'r') as f:
			all_headers_source += f.read() + '\n\n'

	ffi = cffi.FFI()
	sources = [os.path.join(base_path, src) for src in sources]
	# NB: TH headers are C99 now
	kwargs['extra_compile_args'] = ['-std=c99'] + kwargs.get('extra_compile_args', [])
	ffi.set_source(cffi_wrapper_name, wrapper_source + all_headers_source,
				   sources=sources,
				   include_dirs=include_dirs,
				   library_dirs=library_dirs, **kwargs)
	ffi.cdef(_typedefs + all_headers_source)

	_make_python_wrapper(name_suffix, '_' + name_suffix, target_dir)

	def build():
		_build_extension(ffi, cffi_wrapper_name, target_dir, verbose)
	ffi.build = build
	return ffi

def _wrap_function(function, ffi):
	@wraps(function)
	def safe_call(*args, **kwargs):
		args = tuple(ffi.cast(_torch_to_cffi.get(arg.type(), 'void') + '*', arg._cdata)
					 if isinstance(arg, torch.Tensor) or torch.is_storage(arg)
					 else arg
					 for arg in args)
		args = (function,) + args
		result = torch._C._safe_call(*args, **kwargs)
		if isinstance(result, ffi.CData):
			typeof = ffi.typeof(result)
			if typeof.kind == 'pointer':
				cdata = int(ffi.cast('uintptr_t', result))
				cname = typeof.item.cname
				if cname in _cffi_to_torch:
					# TODO: Maybe there is a less janky way to eval
					# off of this
					return eval(_cffi_to_torch[cname])(cdata=cdata)
		return result
	return safe_call


code39 have error in barcode

barcode function, code39 Spelling mistakes。

Can I provide a method of barcode 128
barcode2(value, height) {
let bytes = iconv.encode(value, 'ascii');
 this._queue([
 	0x1d, 0x68, height,
 	0x1d, 0x77, 0x03,
 	0x1d, 0x6b, 0x49,
 	value.length,
 	bytes,

 ]);

 return this;

}

If included some of the changes from this PR in the upcoming release. Thanks!


Fix apiVersions should be recent error

Updating Microsoft.KeyVault/vaults and Microsoft.KeyVault/vaults/secretsto2023-07-01` to fix  apiVersions should be recent error.
Signed-off-by: Jianguo Ma<EMAIL_ADDRESS>

Please notice that I haven't bumped version as we can bump version later once updating to the new released twas-nd and ihs vm images.


TorchPoints3d

Dear All,
I am one of the main contributor of TorchPoints3d: https://github.com/nicolas-chaulet/torch-points3d
Your framework has lot of synergies with ours and I was wondering if you would have any interest in collaboration ?
We also have a Slack Channel with lot of experts in pointcloud field and would love for you guys to join in.
My email address is thomas . chaton . ai @ gmail . com. Without the spaces
Best regards,
Thomas Chaton

Hi @tchaton ，
Thanks for your invitation. torch-points3d is definitely a good project. Currently, we are still focusing on 3D detection and there are lots of things to do. So maybe in the future when MMDetection3D is more complete we may contact you.

Hi @ZwwWayne,
Yes definitely. I guess I will start to work on integrating MMDetection3D directly with TorchPoints3d and merge both codebase together. I think it could be very beneficial for the community.
Best regards,
Thomas Chaton.


docker windows - time sync does not noticed docker host timezone

hi,
on my windows dev mashine with new docker version 1.13 the host sync time now - yeah! thx for this update. but it only sync date & time - numbers, not the host timezone.
Example:
I operate from Europe/Berlin Timezone, it is now 16:45 in local time (utc 15:45) and docker containers are sync time to 16:45 - but - UTC not UTC+1
When change the timezone in windows to utc - time and zone is in sync - if i switch back to utc+1 timezone is not in sync.

Timezone inside a container is separate from the host's timezone. There's some earlier discussions around this for linux containers; https://github.com/docker/docker/issues/3359, https://github.com/docker/docker/issues/12084, https://github.com/docker/docker/issues/27488, but I'm not sure what the equivalent is on a Windows container
/cc @johnstep ^^

Are you talking about Docker for Windows running Linux containers or Windows containers?
How are you determining what is going on? How are your containers configured?

i have no special configuration for my containers:
#windows time is now 16:30 (utc+1 europe/berlin)
#create example container
docker run --name some-nginx -d nginx
#get time of the container
docker exec some-nginx date
i get 16:30 utc
change windows timezone to utc (15:30)
restart docker service via guid
docker start some-nginx
docker exec some-nginx date
i get 15:30 utc

Ok, in that case can you open the issue here instead https://github.com/docker/for-win/issues as it is specific to Docker for Windows.

Closing here as docker for Windows specific, please open as above.


Update logic to process domain data

Added support to process domain data parsed from XML in both formats: <domain>General</domain> (current format) and <domain name="General"/>
The plan to update ZAP XMLs using Alchemy will require this change, as domain definitions will be updated to the format <domain name="General">

Plans of updating CHIP XMLs changed we do not need to support the new domain format anymore.


Delcaring license

Type: Incomplete
Summary:
Delcaring license
Details:
Followed source link to license file
Resolution:
MIT
Affected definitions:

jsoncpp 645250b6690785be60ab6780ce4b58698d884d11

@ariel11, correct me if I am wrong since I've been out of this a while, but should it be NO ASSERTION OR MIT OR NO ASSERTION AND MIT? I could be reading the jurisdiction parts incorrectly.

@capfei - we have added "NONE" and "OTHER" as curation options.  We have been doing "OTHER" for public domain.  Looking at the https://github.com/open-source-parsers/jsoncpp/blob/645250b6690785be60ab6780ce4b58698d884d11/LICENSE file again, I don't think we can do "MIT AND/OR OTHER," which would most closely match the three licensing options in the license file.  I suppose I would recommend putting "MIT OR OTHER" as the curation here.  Thoughts?  Good catch

Ok, I will update the PR to MIT OR OTHER. Thanks!


locking dependencies of editable vcs requirements

When we pip install then pip freeze an editable vcs requirement, the frozen requirements include all dependencies.
With pipenv the dependencies of editable vcs requirements do not appear in Pipfile.lock.
Example:
$ pipenv install -e git+https://github.com/sbidoul/subdirtest.git#egg=subdirtest\&subdirectory=setup
...
$ cat Pipfile.lock
...
    "default": {
        "subdirtest": {
            "editable": true,
            "git": "https://github.com/sbidoul/subdirtest.git",
            "subdirectory": "setup",
            "ref": "7b18afe980a42bfe8d1a96b5ed52e05f58d9ef6c"
        }
    },
...
$ pipenv run pip freeze
click==6.7
pkg-resources==0.0.0
-e git+https://github.com/sbidoul/subdirtest.git@7b18afe980a42bfe8d1a96b5ed52e05f58d9ef6c#egg=subdirtest&subdirectory=setup

Since the installed package depends on click I expect to see it in the locked dependencies.
pip-tools lacks this capability (https://github.com/kennethreitz/pipenv/issues/508#issuecomment-328345816)

This is definately out of scope for now — until pip-tools grows this ability — I'd raise the issue over there.

is there an issue in pip-tools for this that I can follow? if not, can you make one @sbidoul?

Problem is that I don't know pip-tools so I can't create a meaningful issue in that project. I'd need to do some research on the pip-tools api and how it is used by pipenv.

Issue title: "Resolve dependencies for editable requirements, required by pipenv"
contents: the contents of this issue.

pip-tools is poorly maintained, so i doubt it'll happen.

I'm committer on it though, so if you write a patch to get this to work, I'll merge it!

@kennethreitz is it supposed to be implemented in 7.3.2?

yep!

Hm, looks like its not working for me with 7.3.5 (the command in the description above).

oh i dont' know if it works for subdirectories, i know it works for VCSs in general now though.

I just tried pipenv install -e git+https://github.com/kennethreitz/requests#egg=requests and I don't get the dependencies in the lockfile.

ah, it works with the other form.

v7.6.3 released, which has this confirmed working!

Almost there:
$ pipenv install -e git+https://github.com/kennethreitz/requests#egg=requests                                                                                Installing -e git+https://github.com/kennethreitz/requests#egg=requests…
Obtaining requests from git+https://github.com/kennethreitz/requests#egg=requests
  Updating /home/sbi-local/.local/share/virtualenvs/pipenvtest-egFzzt6y/src/requests clone
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in /home/sbi-local/.local/share/virtualenvs/pipenvtest-egFzzt6y/lib/python2.7/site-packages (from requests)
Requirement already satisfied: idna<2.7,>=2.5 in /home/sbi-local/.local/share/virtualenvs/pipenvtest-egFzzt6y/lib/python2.7/site-packages (from requests)
Requirement already satisfied: urllib3<1.23,>=1.21.1 in /home/sbi-local/.local/share/virtualenvs/pipenvtest-egFzzt6y/lib/python2.7/site-packages (from requests)
Requirement already satisfied: certifi>=2017.4.17 in /home/sbi-local/.local/share/virtualenvs/pipenvtest-egFzzt6y/lib/python2.7/site-packages (from requests)
Installing collected packages: requests
  Running setup.py develop for requests
Successfully installed requests

Adding -e git+https://github.com/kennethreitz/requests#egg=requests to Pipfile's [packages]…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Traceback (most recent call last):
  File "/home/sbi-local/.local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/home/sbi-local/.local/venvs/pipenv/lib/python2.7/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/sbi-local/.local/venvs/pipenv/lib/python2.7/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/sbi-local/.local/venvs/pipenv/lib/python2.7/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/sbi-local/.local/venvs/pipenv/lib/python2.7/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/sbi-local/.local/venvs/pipenv/lib/python2.7/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/sbi-local/.local/venvs/pipenv/local/lib/python2.7/site-packages/pipenv/cli.py", line 1500, in install
    do_lock(system=system)
  File "/home/sbi-local/.local/venvs/pipenv/local/lib/python2.7/site-packages/pipenv/cli.py", line 942, in do_lock
    project=project
  File "/home/sbi-local/.local/venvs/pipenv/local/lib/python2.7/site-packages/pipenv/utils.py", line 133, in resolve_deps
    extra_constraints = best_matches_from(dep[len('-e '):], which=which, which_pip=which_pip, project=project)
  File "/home/sbi-local/.local/venvs/pipenv/local/lib/python2.7/site-packages/pipenv/utils.py", line 106, in best_matches_from
    setup_py_path = os.path.abspath(os.sep.join([result, 'setup.py']))
TypeError: sequence item 0: expected string, NoneType found

Ugh, in Python 3 this doesn't result in a type error.


Update index to reflect recent merged PRs

This PR updates the generated index file.  Can someone please merge?  @TelegramSam @dhh1128 @kdenhartog @llorllale


Homepage Articles

@johnlewissims
Just wondering how we can simplify the feature for the homepage articles underneath the "resources" header.
The way I think about lowering the amount of dev time on this section is

to allow for this section to be populated by 4 chosen articles. So we can create a decent composition with highlighted articles.
Make the "load more" button just say "view more" and swap the icon for the arrow and have it link to the readings page.

Example below

What's the concern with the current functionality? Where we just load the most recent 15-20 posts? @brendon-avalos

My concern with the current functionality is doing the css to "unhide the remaining post" and curating the 15-20 posts that we want.
I feel like we need some way to curate whats on the homepage that is not by most recent but rather selected.
I was also just trying to see if not doing the "load more" would save you time if its not already built.

Ok. I'm going to change this functionality to where you select them by which ones have the "Featured" tag. Does that sound good?

@johnlewissims
Currently the "view more" button expands the drawer but still obscures some articles once the drawer is technically open.
View More Solutions

Should we have the "view more button" just be a link that sends you to the "readings" page?

"View more" button expands the entire div and loses the gradient effect to showcase "all articles" within the drawer.
In this case we should also remove the entire "view more" button and surrounding rules once the drawer is clicked as well.

The “load more” feature works. I think we just need to add more content so
you can see it running.
We can set it to where we select all posts with a certain tag. That would
make these selectable.
On Mon, Sep 5, 2022 at 8:17 PM brendon-avalos @.***>
wrote:

My concern with the current functionality is doing the css to "unhide the
remaining post" and curating the 15-20 posts that we want.
I feel like we need some way to curate whats on the homepage that is not
by most recent but rather selected.
I was also just trying to see if not doing the "load more" would save you
time if its not already built.
—
Reply to this email directly, view it on GitHub
https://github.com/johnlewissims/symbiosis/issues/39#issuecomment-1237586816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKPAU4WTODQTGNNCCFJ35TTV42SU5ANCNFSM6AAAAAAQDMLV3Q
.
You are receiving this because you were assigned.Message ID:
@.***>


🧪SPIKE uniformity across containers

What: We do not currently have identical container images across testing and production. This could cause unknown issues between test and prod. e.g. a newer version of a library could be pulled down.
We want the containers promoted per environment rather than built per environment.
We need to look into building this on GitHub actions.
DoD:

[ ] Reuse reusable workflows where possible
[ ] move existing code onto GitHub actions off of CodeBuilder
[ ] Rebuild pipeline to
[ ] James to update this ticket with previous related work
[ ] Look into a centralised ECR repository design
[ ] Feedback findings to team about best way to approach this task

https://dsdmoj.atlassian.net/jira/software/c/projects/ND/boards/1430/backlog?epics=visible&selectedIssue=ND-84


Introduce possibility to bind an unbinder.

Introduces a ButterKnife.Unbinder interface.
Introduces a @BindUnbinder annotation.
BindingClass creates an internal implementation (UnbinderImpl :) ) inside the *$$ViewBinder class.
Closes #211

I actually want to get rid of the ButterKnife.reset call altogether and force use of the unbinder. That said, let's ignore that until this gets merged and then that can be done as a follow-up.
This looks awesome. I commented all over as there's a few critical things that need changed and a few minor things.

I mean ButterKnife.unbind... old habits...

:smile: I know what you mean

I mean ButterKnife.unbind... old habits...

Seam like an reasonable idea. If you don't mind, I can follow up this such a PR.
And that being said: @JakeWharton what if I remove the newly introduced @BindUnbinder and tie the Unbinder binding to @Bind?

I actually want to get rid of the ButterKnife.reset call altogether and force use of the unbinder. That said, let's ignore that until this gets merged and then that can be done as a follow-up.

Yeah I'm not a huge fan of @BindUnbinder, but I'm not sure how @Bind would be re-used as it requires an ID. It could be @Unbind or @Unbinder.

Brilliant! I'll change the annotation to @Unbinder for now (@Unbind sounds more like an action, and I would use that for a method scoped annotation).

It could be @Unbind or @Unbinder.

If you don't have any other comments regarding the code, I can remove the #unbind() method form ViewBinder and change the scope of the PR. This way it will be all in one place (and one commit ;)).
How that does this sound?

Just got through reviewing and everything looks good. So if you want to
continue down the path of removing the 'unbind' method please do!
On Fri, Oct 9, 2015 at 10:48 AM Serj Lotutovici<EMAIL_ADDRESS>wrote:

Brilliant! I'll change the annotation to @Unbinder for now (@Unbind
sounds more like an action, and I would use that for a method scoped
annotation).
It could be @Unbind https://github.com/Unbind or @Unbinder
https://github.com/Unbinder.
If you don't have any other comments regarding the code, I can remove the
#unbind() method form ViewBinder and change the scope of the PR. This way
it will be all in one place (and one commit ;)).
How that does this sound?
—
Reply to this email directly or view it on GitHub
https://github.com/JakeWharton/butterknife/pull/378#issuecomment-146893106
.

On it. Don't merge yet!

Just got through reviewing and everything looks good. So if you want to
continue down the path of removing the 'unbind' method please do!

I would also like to pass the target class instance into the unbinder constructor and remove the argument to the unbind method. This makes it more clear that it's a one-shot deal per instance and doesn't require you passing in 'this' or anything.

Did I mention how I "love" big pull requests? :smiley:
@JakeWharton Applied all the comments, and requests. Please have a look, when you have time.

This is so great. Thanks for all the work!


Two addresses

Hello,
Two days ago I created a myetherwallet. I copied the address, private key and downloaded the UTC file.
I transfered ethereum from my coinbase account using the address provides to me during the MEW setup. Once I transfered the ethereum i opened my wallet using the pricate key I saved during setup.
Once in the wallet I noticed that it dis not contain the ethereum I had transferred and that the address I had saved did not match the address being displayed.
I used the UTC file to log in, and again it took me to the wallet that was empty.
Can someone please advise what I can do. I have the addresses for both wallets. I dont understand why two addresses were generated, as I followed the instructions as provided.
I would really like to be able to access the ethereum I sent from coinbase to the myetherwallet again, or at least an explanation as to why this has occurred.
Thanks
Infinite

Please read: https://myetherwallet.github.io/knowledge-base/private-keys-passwords/accessing-different-address-same-private-key-ether.html
Especially this part:

...at the very bottom of https://www.myetherwallet.com/helpers.html, scroll allllll the way to the bottom, and enter your private key and address and see if that resolves.

@tayvano
Thank you for your response.
When trying to resolve the private key and address, I presented with a sad face :(
I presume this advises that the private key does not match the given address, which is the primary issue.
Is there anything else than can be done? At present due to this discrepancy I have sent money to what I can only imagine is a wallet that no one has access too.
Thanks
Infinite

Yes aku mau uang


[Feature Request] Activity bar Icon

It would be awesome to have it a click away

I'll work on it.


Job without reports

Hello,
I am discovering the tool and it is very interesting.
Would run the tool without generating reports?
I would just need the data and indexes.
I launch the exe with the options -j & -o
Thanks in advance for the reply.
Cedric

You need to adjust https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Job-File
Specify what you need in https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Job-File#input-section
Turn off report creation in https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Job-File#output-section by setting all reports to False.
This will create all the indexed CSVs but skip the Excel creation.


tetra: Add CEL filter to the CLI

Fixes https://github.com/cilium/tetragon/issues/3112
Description
Integrate the existing CEL filtering capability into the CLI
Changelog

Hi,
Thanks for the PR!
It seems to me that this PR attempts to add support for CEL filters in the export filters rather than the CLI (tetra). Could you please add more details about what the PR attempts to do? An example of how it works in the commit message would be very helpful in that regard.

Sorry, my mistake.  I picked this up at the Contribfest, found that these filters were missing the CEL integration and submitted the fix.  I'll tidy this up, and fix the CLI issue, some time over the next few days.
In the meantime I've converted this to a draft

It seems to me that this PR attempts to add support for CEL filters in the export filters rather than the CLI (tetra). Could you please add more details about what the PR attempts to do? An example of how it works in the commit message would be very helpful in that regard.

@kkourt I've updated the PR to also include the CLI integration, the tetra getevents command will now accept --cel-expression arguments to enable filtering of events by CEL expressions.

Can you please add an example usage in the commit message?
Also, can you put the "Fixes: " in the PR message" rather than the commit title?

Commit message should now be updated


Create a database table to store the settings preferences of the user

This issue has been dropped for now


apt_update resource looks like it fails on 12.1.0

https://gist.github.com/tas50/b3bf1d1f7344ebdadbdd93ae2855a981
need to:

add a test that uses apt_update

i suspect it fails on chef 12.1.0 through 12.5.1

i suspect the fix is that we need to backport the NodeMap, ProviderResolver, and ResourceResolver changes to 12.1.0

this will be complicated by the fact that we need to do something like dump out the NodeMap from 12.1.0 that has been populated at class loading time with all the core resources, then we need to upgrade all the classes to the new code, then we need to refill the new NodeMap with the prepopulated information.

fixed in #125 #126 #127


Added doc for InvenTree PR#1400

See https://github.com/inventree/InvenTree/pull/1400
When merged, closes #82

Thanks


[5.1] queue:listen no longer logs exceptions

Laravel Version: 5.1.44
PHP Version: 7.0.10
Database Driver & Version: mysql 5.6

Description:
Running artisan queue:listen without --daemon no longer logs exceptions.
Steps To Reproduce:

Create a failing job, throw any old \Exception inside the handle()
Push your job to a non-sync queue, run the job with artisan queue:listen
Expected: laravel.log should log your exception
Actual: Nothing is logged
if you have a Queue::failing() that logs in your AppServiceProvider, that log shows up, if you have --tries=x set.

Thoughts
This seems to have been introduced by: https://github.com/laravel/framework/commit/5858edc5a776760b51e8cac1cc2759d7fd34d1ff. The poll() method now adds it's own try/catch which is catching the exception, rather than the try/catch in \Illuminate\Foundation\Console\Kernel::handle().
The issue is that the new poll() try/catch will only log exceptions if $this->exception is set. When the Worker::poll() is run, the only time it is provided an exception handler is if the user has passed --daemon to the queue:listen command:
https://github.com/laravel/framework/blob/5.1/src/Illuminate/Queue/Console/WorkCommand.php#L96-L98
The fix should be quite simple, passing the exception handler in regardless of --daemon, but I'm not sure if there is another reason that this was previously not provided if not in --daemon that I could be overlooking.

Hello @michaeldyrynda :)
Do you think your PR https://github.com/laravel/framework/pull/15167 might have caused the behaviour stated in this issue?

Updated the issue to properly reflect that the error occurs on artisan queue:listen. I had made multiple references to artisan queue:work incorrectly.

Hey @themsaid, yeah, that'd be me.
As per the PR, the fact an exception fell through the excecution at all is probably broken behaviour, given that it causes retries to never be fired.
I'm not sure why the exception handler isn't passed in (or if it is in 5.2 when the try/catch was added), but I agree it's probably the simplest way to resolve, though I'm not sure if/why this was omitted.

@michaeldyrynda is it possible that you give it a shot and attempt to introduce a fix?

Is there any temp fix I can do for this? I'm trying to troubleshoot a problem and it's very difficult without any error logs.

@wyred I reverted to 5.1.43, as it does not suffer from this issue.

We should just pass the exception handler in all the time.

I've tagged 5.1.45 to address this. Can you confirm that fixes your problem?

@taylorotwell 5.1.45 resolves this issue. Thanks!! 👍


Update Kubermatic Product Logos

Hi there,
We have rebranded our product portfolio. Unfortunately, I was not able to upload the new logos to the hosted logo folders.
Here come the logos concerned
Kubermatic Kubernetes Platform: https://drive.google.com/file/d/1bFpYs30i0wC8uYARqV2jLrMiW6UKJtER/view?usp=sharing
Kubermatic KubeOne: https://drive.google.com/file/d/1UD89p4ewaROQ1e-oDo8PVkio9LiBM_uh/view?usp=sharing
Kubermatic KubeCarrier: https://drive.google.com/file/d/1Wl3f9sC0S2Wsb5DuTgB2nC8meO99MNk5/view?usp=sharing
Best,
Kristin
Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

/lgtm

Build failed because of:
No cached entry, and Kubermatic KubeOne has issues with logo: Kubermatic-Kubeone.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/Kubermatic-Kubeone.svg'
No cached entry, and Kubermatic Kubernetes Platform has issues with logo: Kubermatic-Kubernetes-Platform.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/Kubermatic-Kubernetes-Platform.svg'
No cached entry, and KubeCarrier has issues with logo: Kubermatic-Kubecarrier.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/Kubermatic-Kubecarrier.svg'
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
Empty twitter for EMQ Technologies (member): https://twitter.com/emqtt
Empty twitter for EMQ Technologies: https://twitter.com/emqtt
Item KubeCarrier has no image_data
Item Kubermatic Kubernetes Platform has no image_data
Item Kubermatic KubeOne has no image_data

Deploy preview for landscape failed.
Built with commit db1159fd933fcf93c2ba6c650b4be4c111f07f7a
https://app.netlify.com/sites/landscape/deploys/60817fd82a46a90008a3b9f6

@taylorwaggoner : I think I did this wrong. Could you advise?

@taylorwaggoner is currently out on maternity leave. The problem is that you didn't add the new logos to the host logos folder so it is pulling nothing. You can add them in your branch https://github.com/cncf/landscape/tree/master/hosted_logos then make a PR with the logos and the updates


[Network] Fix #26248: az network dns record-set cname set-record: Declare TTL as integer type

Related command

Description

Fix: https://github.com/Azure/azure-cli/issues/26248
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network

Bump - when will this be merged?  Critical impact on services.

Bump - when will this be merged? Critical impact on services.

It'll be involved in 2.49.0 around 05/23. Workarounds can be found at https://github.com/Azure/azure-cli/issues/26274#issuecomment-1527066849.


Operation is not supported on this platform.

When the code hits JwtWriter.WriteTokenString() on a Windows Server 2012 R2, I get the following error but no other information.
Operation is not supported on this platform.
Stack trace doesn't seam to be much help,
The code is running fine on a number of other servers, all server have the "Microsoft .NET Core 5.00 Windows Server Hosting" installed all other functions appear to working fine.
Other Windows server including a 2012 R2 , 2016 and 2019 appear to be fine, any ideas how to narrow this problem down?

It might be probably on cryptography methods, but I do not have Windows 2012 available for reproducing the issue.
The stack trace may help to identify the part that cause this exception.
Your application is targeting net5?

Also what signature algorithm and/or encryption algorithm are you using?

It might be probably on cryptography methods, but I do not have Windows 2012 available for reproducing the issue.
The stack trace may help to identify the part that cause this exception.
Your application is targeting net5?

I though it might be the cryptography, I have been forcing updates to machine in questions thinking it might be an outdated cipher suite. I have wrapped some more logging around it, the reason the original stack trace was making no sense was because it was blowing out with an object reference error, as below.
Error
 Operation is not supported on this platform.
Stack
at System.Runtime.Intrinsics.X86.Aes.KeygenAssist(Vector128`1 value, Byte control)
   at JsonWebToken.Internal.Aes128EncryptionKeys..ctor(ReadOnlySpan`1 key)
   at JsonWebToken.Internal.Aes128BlockEncryptor..ctor(ReadOnlySpan`1 key)
   at JsonWebToken.Internal.AesKeyWrapper..ctor(SymmetricJwk key, EncryptionAlgorithm encryptionAlgorithm, KeyManagementAlgorithm algorithm)
   at JsonWebToken.SymmetricJwk.CreateKeyWrapper(EncryptionAlgorithm encryptionAlgorithm, KeyManagementAlgorithm algorithm)
   at JsonWebToken.Jwk.TryGetKeyWrapper(EncryptionAlgorithm encryptionAlgorithm, KeyManagementAlgorithm algorithm, KeyWrapper& keyWrapper)
   at JsonWebToken.EncryptedJwtDescriptor`1.EncryptToken(ReadOnlySpan`1 payload, IBufferWriter`1 output)
   at JsonWebToken.JweDescriptor`1.Encode(EncodingContext context)
   at JsonWebToken.JwtWriter.WriteToken(JwtDescriptor descriptor, IBufferWriter`1 output)
   at JsonWebToken.JwtWriter.WriteTokenString(JwtDescriptor descriptor)
   at LicensingAuthToken.Controllers.AuthController.Get(String token)

Also what signature algorithm and/or encryption algorithm are you using?

Signature Algorithm is HmacSha256
Encryption Algorithm is Aes128CbcHmacSha256
Key Management Algorithm is Aes128KW

OK I see the problem, but not the root cause.
Windows 2012 may not support AES instruction set.
However there is a check before using this feature, and it should fallback to the AES Cng implementation, which is available on Windows platforms since Windows 2008.
There is way to force the feature flag via this environment variable:
SET COMPlus_EnableAES=0
Can you give try ?
I suspect a bug with System.Runtime.Intrinsics.X86.Aes.IsSupported. I will look on this side and in parallel if we can provide an hotfix.

There is way to force the feature flag via this environment variable:
SET COMPlus_EnableAES=0
Can you give try ?

Tried setting it as an environment system variable in Windows still the same.

Thanks !
The bug is identified, the hotfix should be ready soon.

Fix available on NuGet:
https://www.nuget.org/packages/JsonWebToken/

Pulled it down earlier, working perfectly now, thank you for the very prompt fix.


Can't get original sorted state on dragging end

I would like to retrieve the final state of my draggable list, only on drag end.
I managed to call my own function like this,
setList={() => {}}
onEnd={this.props.onBundleDragAndDrop}
But I need here to check if my indexes are different, and then splice my state element twice (once to remove, and once to insert). But even when I do this, there is a "chosen" attribute inserted in my original state
So I need then to clean my state out of the "chosen" attribute.
As I customly find the end index, and then I customly clean my response, this library don't really do what I need, but isn't it supposed just to sort element and return the final state ? Can I get rid of those new indexes inserted in my state, and is there another way just to retrieve it on drag end without tweaking "setList" ?

For some context, I sync some JSON files with dropbox only when a list is updated. So I mustn't update dropbox if order didn't changed, and I also can't insert new indexes into those files.

Check out what each on[Xxxx] event reacts to. Sounds like you're looking for onUpdated https://github.com/SortableJS/Sortable.
onUpdate on fires when the the list changes after a drop.

onEnd work as fine as onUpdate, it doesn't seems possible but I wanted to retrieve my original prop list I gave as an input, without any new attribute inserted inside..
In the end I had to do this:
onEnd={this.onBundleDragAndDrop}
and my function:
onBundleDragAndDrop = (evt) => {
    if(evt.oldIndex !== evt.newIndex) {
        let bundles = [...this.props.bundles];
        bundles.splice(evt.newIndex, 0, bundles.splice(evt.oldIndex, 1)[0]);
        // do what I need with my updated clean list
    }
}

It's just that I loose almost all the interesting features of this library..


No InfiniteScroll/Pagination on user-management pages users/groups

Describe the bug
When number of entries is longer than the window can display no scroll or pagination occurs.
Steps to reproduce
Steps to reproduce the behavior:

Create a lot of users.
Create a lot of groups.

Expected behavior
Scrolling or pagination should occur to view all users.
Actual behavior
Only the usernames on the 'current page' are visible. Zooming browser window will display more users.
Setup
https://owncloud.dev/ocis/deployment/ocis_traefik/
firefox or chrome on ubuntu

Lovely, good find. Moving to the web repo where this needs to be resolved in the user management app :)


ignore certain modules not pinned to version

Is it possible to ignore certain modules not pinned to a release version. For example. I have a data only module for tags and I don't want to pin it so if tag standards change. The next deployment will pick up the latest changes from tags without a code commit.
There are other modules in the same terraform project but I want them to be version specific cause they are actual resources. I thought ignore-module would work but that doesn't seem to do it.

Hi @bondezbond

Do you found an answer to this question anywhere?
If not - can you describe more details and how it related to the pre-commit-terraform repo, please?

As I understand, you just need to not specify a module version
source = git::https://github.com/ORG/REPO.git
# or
source = git::https://github.com/ORG/REPO.git?ref=main_branch

we can close this. This is more of an issue with tflint. With flexible style source = git::https://github.com/ORG/REPO.git you would get this error so that doesn't work.
The only workaround is to do another non-default tag that's always pointing to latest commit.


Add Persian translations

Add Persian translations
Make sure that you've checked the boxes below before you submit PR:

[x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Coverage decreased (-0.6%) to 75.378% when pulling c1c416e2e529a1c71b22d40dd2f5b0e5dbfb293c on amir9480:add_persian into af8b8d1c883dad78144658e4cdf7304da07210d7 on go-playground:master.


Don't ignore hidden files in du example

This makes it more realistic as the du program itself also doesn't
skip hidden files.
cargo-fmt was applied automatically, hence the additional changes I think.

Thanks!


Fix a couple of minor typos and grammar in README

Hey man, these are super minor but because it's a very publicly facing document, AND because my mum is an English teacher who has made me very anal, I've made a few very minor typo/grammar fixes.
In particular, "allows to", while being 100% understandable is not technically correct english grammar because "allows" is a transitive verb (so for example you could say "allows ONE to:). So I've fixed the places where I've found that :) make sure you're happy with the changes

Hey @fwbrasil, your documentation is freaking awesome!! You were right I really gained a lot from reading the Internals section. I'm sorry it took me this long to get around to reading it

@williamboxhall thanks for reviewing the readme. I liked the summary section!

@fwbrasil something strange went wrong with the merge, it's merged my original changes not my force-pushed changes

Oh I see, you made some changes. They look fine but they have a bug :P

Ouch! what bug?

```scala

val goodTracks: Clump[List[CreatorTrack]] =
Clump.traverse(trackIds) { trackId =>
for {
track <- tracks.get(trackId) if (track.rating >= 4)
user <- users.get(track.creatorId)
} yield {
CreatorTrack(track, user)
}
}
val efficientlyFetched: Future[List[CreatorTrack]] = goodTracks.list

You didnt put track. in front of creatorId, also you were yielding EnrichedTrack instead of CreatorTrack.
Here's the fixed version, maybe you can commit and squash it in with your edit

Fixed on master


autocomplete tag

I would care and I would need <Form> to support the autocomplete tag.

autocomplete - MDN
So, your code don't wrap inputs in html <form> tag. What is a cause of it?
Currently i must wrap your form in html form:
<form autoComplete="off">
<Form defaultFields={shema} renderer={renderer} onChange={this.onChange}/>
</form>

I think your code should wrap inputs in HTML <form> tag and should hand on some props to HTML <form> tag

First of all thanks for your feedback - it's much appreciated. I think that you're completely correct that a <form> tag should be rendered by the Form component - that's a complete oversight on my part and I will rectify this.


Don't leak epoll/kqueue fd on error

Close the previously created epoll/kqueue fd in case of a successive
error in NewReader.

Good catch, @tklauser!


Simplify civil legal aid landscape diagram

What does this pull request do?
Rewrites the diagram to focus only on these two systems: "Civil Legal Aid" and "Find a Legal Adviser".

Removes all connections and nodes that are indirectly used by the Legal Aid Agency; only direct connections remain.
Changes the colour scheme to have a "focused" element and "boundary" elements which look paler.
Provides more detailed descriptions on the edges between nodes.
Adds the previously omitted "Ordnance Survey API" external system (we use it for finding full addresses).

Why make these changes?
When I last talked about this diagram I felt that I am going into too much detail and I am not following the "zoom in" methodology described in https://c4model.com.
Civil Legal Aid and Find a Legal Adviser are "conceptual" systems; in reality, they contain half a dozen applications. There will be follow-up pull requests which zoom into these systems in detail.
Show me the image
Before

After

cc @ministryofjustice/laa-get-access

I feel that the before diagram provided a good context of the external systems. As I first came across OBIEE, CWA, Hub from the before diagram and when OBIEE, CWA, Hub was mentioned outside of our team I was aware it's an external system that we interact with directly or indirectly.
Perhaps having a zoomed out diagram to start with, showing these external dependencies and then another zoomed in with the after diagram will provide this context.

@said-moj Good question! I plan to introduce those connections on new diagrams focusing on business processes.
For example, the "Updating the legal provider address" flow will mention all systems involved in the process. Additionally, it should also capture the initiator of those changes, which is currently invisible on the previous version of this diagram.
I feel this approach works better because we can support multiple questions:

What integrates directly with this system? (this pull request)
What are the moving parts of this system? (#12, #13)
Which business flows use this system? (business process diagrams, searching for the system name)

If we wanted to have an overview, I would prepare this new diagram and the business flows; if we were going to discuss integration to a new system, I would show the "containers" (moving parts) and the related business process.
Every discussion mentioned above would have enough context as they would show the entire scope, whereas the old version here shows an arbitrary segment.
I hope this makes sense?

After offline conversations with the @ministryofjustice/laa-get-access team, the following changes will be made:

[ ] Add a line between members of the public (Citizen) and the "Find a Legal Adviser" system: they search for providers themselves.
[ ] Add "Direct Services Team" and a line between them and the "Civil Legal Aid" system: they download reports, view cases on an ad-hoc review basis and propagate data extracts to management information systems.

👍


fix: support android

Make changes to build.rs to support android builds.

glad we have gh rules that protected from mistakes like that


long text in btn in justified button group overflows while clicking/:active

Why this is happening?
http://jsfiddle.net/ETe8V/show/

@MrGeneric how exactly is it possible to get the buttons of equal height like in your example?
I've tried an obvious .btn { white-space: normal; } (see a fiddle) but found it's not enough.

Hi @Mithgol!
You appear to have posted a live example (http://fiddle.jshell.net/ETe8V/4/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

W005: Unable to locate jQuery, which is required for Bootstrap's JavaScript plugins to work

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

(The fiddle that I mentioned does not use any Bootstrap's JavaScript plugins.)

Using <a> instead of <button> seems to be a solution: http://jsfiddle.net/ETe8V/5/


Double version information ?

I have code like this ...
ApplicationVersion = Version.Plugin.CrossVersion.Current.Version;
ApplicationVersion gets populated with the value "<IP_ADDRESS>"
Any ideas ?

I also have this issue, occurring only on iOS.
@mtrinder any solutions?


[Proposal] Performance Checking Tests

To build a performance test framework, we should use oha.
It is a binary, so we could either wrap around it from rust or write shell scripts to test individual endpoints.
I suppose we would also need different data to accomplish such a goal.
It may be cleaner to consider moving each Mentat implementation to different repositories so data for each isn't cluttering this repo.
We could add onto the readme or maybe a separate markdown file the list of repos who use Mentat. People could make PR"s to add their service to it.

Services have since moved to their own repos.


"React does not recognize the staticContext prop on a DOM element"

Version
4.2.2
Test Case
https://codesandbox.io/s/2vp8w3rx1r
Click the link to "Course 1" and open browser console. See React-thrown error.
Steps to reproduce

Apply withRouter to a <Link /> element
Inspect console

Expected Behavior
The staticContext prop is not passed to the  element, but is caught similar to match, history, etc
Actual Behavior
The staticContext prop is passed to the  element causing a console error

You should do what NavLink does and wrap it in a Route inside CourseLink: https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/NavLink.js

@timdorr the documentation give this code as a sample:
  <Router>

          <Link to="/">Home</Link>

          <Link to="/about">About</Link>

          <Link to="/topics">Topics</Link>

      <Route exact path="/" component={Home} />
      <Route path="/about" component={About} />
      <Route path="/topics" component={Topics} />

  </Router>

Does your answer indicate it's wrong? That this code will throw a React does not recognize the computedMatch prop on a DOM element?
May you precisely indicate what wrapping of NavLink you're referring to?
Pointing the entire file make it hard to properly understand what you're talking about.
Thanks.


Order lines for refunds

What I'm trying to achieve
Some payment providers like Klarna / Affirm / Oney require order lines of items that were refunded in order to send the refund to the customer (See Adyen docs, Mollie docs).
I want to be able to refund payments in those payment methods by using Saleor.
Describe a proposed solution
Add orderLines to orderGrantRefundCreate mutation
AND / OR
Add orderLines to transactionRequestAction(actionType: REFUND) mutation.
Other solutions I've tried and won't work
Using metadata - this won't work because we create refunds in Saleor Dashboard and that would require forking the dashboard or creating Dashboard Extensions by each payment provider app. This is a pattern found in pretty much every payment provider that provides BNPL payment method.

To clarify: in case of full refunds we can just send all line items and that'll work.
The problem occurs when a partial refund needs to be issued – we need the way to specify which items specifically are refunded.


Remove unused simplified_type method

Method hasn't been part of ActiveRecord since commit
https://github.com/rails/rails/commit/0b682e4b05c8f58c77c655650af6638c483ac903
(May 2014)

👍

Updated version in https://github.com/jruby/activerecord-jdbc-adapter/pull/1039


Migrate proxmox tf code to terraform-provider-proxmox

Details
Try out https://github.com/bpg/terraform-provider-proxmox. The current one is nothing but problems

Done in #1229


implement sets.Count

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 12.584%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
243

Relevant Lines:
1931

💛  - Coveralls


Update to 2.5.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@HanatoK This is pretty wired. The log file shows RuntimeError: Could not download https://pypi.io/packages/source/B/BFEE2/BFEE2-2.5.0.tar.gz.
But I can download BFEE 2.4.1 through https://pypi.io/packages/source/B/BFEE2/BFEE2-2.4.1.tar.gz

@HanatoK So both pip and conda-forge requires lower name now?


constructive review of provisioning

fixed some typos
fixes asciidoc structure (was the text written with word and converted to asciidoc?)
fixed broken image
aligned namings and writing conventions (avoid numbering (1) that are not unique or get referenced nowhere, use asciidoc bullet or numbered lists, etc.)

I only included formal changes (layout, etc.) no real content changes.
This pattern is really a great contribution and very valuable. Big thanks to @AlbrechtSchoenfeldGitHub for it 👍
It might still need some simplification. It is partially written like a book (now we will observer A, B, C and D. blabla, A. ..., B ..., C..., D... - why not just omitting to redundantly name A,B,C,D first if the document structure already tells this?). It think we reach people better if we create smaller chunks of documentation and patterns that can be digested by the reader. I fear that we loose the reader before the end of this article as it is very long... However, please do not see this as a criticism to your contribution. We love to get input like this and if we would have more people link @AlbrechtSchoenfeldGitHub contributing such great assets, we would skyrocket with devonfw :)

@AlbrechtSchoenfeldGitHub have you included or even merged my changes from this PR? Can we close this PR?

80% of your review have been reworked in #54 by @AlbrechtSchoenfeldGitHub.
For remaining / new comments please open a new one.


Feature: First pass at an alternative approach to handling "null conditional" ops

Following on from the discussion on #7 at the last meeting this is a draft PR adding the null conditional operations into the grammar at the same level as their respective unconditional siblings.
Some of this is guesswork/invention...
On the invention side in particular note that three terminals: ?., ?( and ?[; have been added to Operator_Or_Punctuator.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Nigel-Ecma sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Nigel to have a look at whether this PR's approach makes sense, after we had more discussion about why the grammar in #7 was expressed that way.

Nigel to have a look at whether this PR's approach makes sense, after we had more discussion about why the grammar in #7 was expressed that way.

Before I look into this properly can I just confirm my understanding of our meeting conversation:

Both PR #7 and #251 accept the same language
They may (that is part of the question to resolve) have equivalent semantics.
PR #7 may allow constructs which are disallowed for the non-conditional sibling operators, which might be an issue (part of the question to resolve)
PR #7 produces a parse tree which is easier/more logical/ for the compiler writer
PR #251 aims at producing a description more logical to the programmer, if such is possible (part of the question to resolve)

Note: In the second bullet I don't say the "same" as #251 might be described as "null propagating" where a null-conditional operator supplies a null to another null-conditional operator, etc., which by-description results in multiple "is this null" tests but any compiler would likely short circuit. So the semantics might not the same but be equivalent – just a different way of describing the same result.
If that summary is either correct, or once it is corrected, I'll look into whether the approach in #7 is required and if not which of #7 & #251 might be more desirable.

Withdrawing Draft PR
To handle null conditional operators correctly the operators ., ?., [] and ?[] need to combine similarly to the way the operators &, &&, | and || do. The approach in this draft does not achieve that as it lacks the priority stratification enforced by the productions for these existing operators.
Unfortunately this still leaves the concerns with PR #7, including the more recently noted differences in what is permitted on the LHS of ?[] compared to [] and whether they are significant.
Are they addressable? More work to do...

The grammar has been extended so that null-conditional access operations "capture" any immediately following unconditional access operations. This should match the desired semantics, keep the description of these operators in the same part of the grammar as their unconditional siblings, and avoid changes to statement expressions nessitated by placing these operators at a different level of the grammar. @MadsTorgersen is this the intended semantics?

A summary of the key differences & changes compared to the original MS:

The null conditional operators were added to unary_expression rather than alongside their non-conditional siblings in primary_expression in the MS approach. Here they are added to primary_expression.
The MS approach captured all member/element accesses including conditional ones which follow an initial null conditional operation. Here only non-conditional ones are captured, this simplifies the description of the semantics. The overall semantics remains the same.

As part of the simplification a null_conditional_invocation_expression is introduced which syntactically is a struct subset of null_conditional_member/element_access – those that end in an invocation.
The null_conditional_member/element_access descriptions have the semantic restriction that the expressions must not be of type void/classified as nothing and reference null_conditional_invocation_expression for those that are void. This separates out the semantics for value producing expressions, defined as having the same meaning as a if/then/else, and non-value producing ones, defined using an if/then, into different clauses rather than a longer set of nested bullets. (The meanings follow the same code as in previous approach.)
Note: In doing this PR I noticed that in  the Standard there is sometimes reference to use of something in a "statement expression" and in others "statement expression or lambda body". I wonder whether some/all of the former should be the latter... I haven't checked, but I have included null_conditional_invocation_expression in anonymous_method_body.

Also added a null_conditional_projection_initializer, a subset of *null-conditional-member-access", which does not include capturing adjacent accesses/invocations. As the name suggests it is a projection initializer for anonymous objects.

To test the grammar is parsing as expected I use a simple test file, nullConditional.cs. (Note: the grammar does take advantage of ANTLR's top-to-bottom rule ordering so the above mentioned subset productions get picked over the full set productions.) This file along with the graphic output of TestRig/grun as nullConditional.png is attached as a ZIP (sorry, Github barfed on the PNG and suggested I ZIP it). (Note: the grammar fed to ANTLR has undergone mutual left recursion removal in primary_expression so you might spot "missing" nodes in the PNG due to this.)
This is hopefully #251 pretty much done, please comment & compare with #7.
nullConditional.zip

Assigned to @MadsTorgersen as his "second item" to focus on.

“Captured” works I think… partly as it doesn’t try to give the detail and leaves the reader to figure it out from the grammar and prose :-)

I'm still uncomfortable with captured given that it has a very specific (and entirely different) meaning elsewhere. I think this we should discuss in the meeting.

In current meeting: "dependent" has the most backing. (Somewhat reluctantly from all, but better than alternatives.)


fix: use yarn in size limit action

This change: (check at least one)

[ ] Adds a new feature
[x] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[ ] Changeset added?

What does this change address?
Fixes #337 (maybe)
How does this change work?
The size limit action checks if Yarn is available and uses it if so. I see it's using npm when it runs, though, so Yarn is not available. Installing it prior to the action running might make things happier.

I was mistaken, has-yarn makes a check to see if the current directory has a yarn.lock file, but we are telling it to use packages/pharos as the path, and there isn't a yarn.lock file there—only in the repo root.

We expect that the size-limit action will pass after merging this into the mainline, because the fix will then be available for both the baseline and current branches whenever it runs.


Add Calendly

What is the vendor's name?
Calendly
What is the vendor's pricing site?
https://calendly.com/pages/pricing
What is the base pricing? Use the lowest tier that looks sane for a small business customer, not free or personal tiers.
$8/user/month
What is the minimum pricing for SSO support?
"Call us" (Enterprise only tier)
Does this pricing info come from a quote or other non-public source?
No, straight from website.
Are there any caveats we should list in the footnotes?

There's a PR up for this #234


Evaluate use of multi-threading in execute_mdx_dataframe, execute_mdx_csv

As a TM1py user of the  write_async function, I can specify how many threads should be used for writing.
This allows to speed up the write operation significantly, in an almost linear fashion.
Can we accomplish similar results for data retrieval by parallelizing MDX execution?
With release 1.11 the execute_mdx_dataframe, and execute_mdx_csv functions accept a mdxpy query object instead of the raw query string.
It should be feasible to break the mdxpy query into smaller sub-queries and execute them in parallel.

Solved with #935


uuu 1.2.135 missing FBK: 0x066F:0x37FF

Hi,
I'm trying to upload custom Linux image (buildroot) to i.MX6ULL SOM and it appears that  uuu is missing VID:PID 0x066F:0x37FF for usb gadget device.

0x066F:0x37FF is old mfgtools. You need update initramfs


Will you consider replacing bootstrap&jquery with react?

Sorry, I'm not saying current webssh is not good. It's beautiful and powerful enough. I really like it especially in vim.
I have a selfish reason for asking this，I'm using ant design, now I have to use an iframe to nest webssh in my small project then adjust iframe height and handle cors problem.
I don't think using webssh via browser is a good idea, because we usually open too many tabs. We cannot use alt+tab to switch apps either. So many people use electron to pack web apps, Electron with React looks like more fashionable.React would be a better choice, because we're not good at css. It seems that React fetch is better than ajax. Please think about it.

Sounds a cool idea.
But I have no experience of working with React.

Me too. I think someone else will ask this question again because we really need an open source cross-platform ssh desktop app. Once use electron, we prefer React sounds reasonable.
You're good at javascript, don't you? It's easy for you to replace jquery-xterm with react-xterm.
I know rewrite it will take you much time, maybe it's even NOT meaningful to you.
But it's meaningful to us.

I am a Python developer.
Hope you can find someone who is interested in doing it.


Add some css to search bar and make it more cool

hey @VG-1 I can try this . Please assign this to me.

sure go ahead


WFLY-7025 Fix WeldDeployment.loadBeanDeploymentArchive()

https://issues.jboss.org/browse/WFLY-7025

Downstream issue and PR will follow.

downstream issue: https://issues.jboss.org/browse/JBEAP-8850


Jan31.2023 Patch Fix > Security Update > New Features

Jan31.2023 Patch Fix ✅

[x] Added Payment System
[x] Fixed Secuirty Bugs
[x] Update dependecies to latest
[x] New Features
[x] Added Responsive view
[x] New assets (images, animations, icons)
[x] faster experience
[x] Update unsupported UI
[x] Update checkout UI slight change

Fixed a lot of bothering bugs. 👏🏻 @creative-tutorials


Delete unused blocks.go file (fixes #291)

Coverage increased (+0.1%) to 65.493% when pulling 117701ca8f40886aaa4ecdc18b4269291ad411b1 on JustinDrake:patch-26 into cc1cf0c2d42b431652b583a5f4115072ffa0e9a3 on OpenBazaar:master.


qml_ros2_plugin: 1.0.1-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository qml_ros2_plugin to 1.0.1-1:

upstream repository: https://github.com/StefanFabian/qml_ros2_plugin.git
release repository: https://github.com/ros2-gbp/qml_ros2_plugin-release.git
distro file: rolling/distribution.yaml
bloom version: 0.12.0
previous version for package: null

qml_ros2_plugin
* Added missing dependencies.
* Contributors: Stefan Fabian

Package already released in jazzy: https://github.com/ros/rosdistro/blob/3c39b6aa289b2f4b098ec9efb71043f0cd929192/jazzy/distribution.yaml#L5228-L5242


The output of convert_ids_to_tokens cannot be assembled into the output of batch_decode

Hi，when I run helm on other data sets, I find that the output of convert_ids_to_tokens(all_tokens)cannot be assembled into the output of batch_decode(all_decoded_text ). Is this normal?
And what does this TD above mean and is it related to this？
https://github.com/stanford-crfm/helm/blob/ad0ac3ee6ca8e66cb318f2936a1191a964687384/src/helm/proxy/clients/huggingface_client.py#L90-L92
These are the values of some relevant variables：
sequences：[tensor([198], device='cuda:0')]
all_decoded_text：['\n']
all_tokens：[['Ċ']]
This is a multiple-choice scenario, maybe the model wants the output to be C?
Thank you！

Sorry, I may have misunderstood, the fact that the token looks like a C may just be a coincidence.


Move std::function in constructor.

Recent gcc 12 emits warnings when copying functions (which looks like some result if a standard library implementation detail). This doesn't happen if we simply std::move the function, so let's do that.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report
Base: 92.94% // Head: 92.94% // No change to project coverage :thumbsup:

Coverage data is based on head (655df1a) compared to base (d7d3259).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   92.94%   92.94%
=======================================
  Files         342      342
  Lines       24158    24158
=======================================
  Hits        22453    22453
  Misses       1705     1705

Impacted Files
Coverage Δ

common/lsp/json-rpc-dispatcher.h
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Error occurred on getting Application gateway

I tried to migrate WAF configuration to policy, but get error below:
Get-AzApplicationGateway: C:\works\migrateWafConfigToPolicy.ps1:43
Line |
  43 |  …    $appgw = Get-AzApplicationGateway -Name $applicationGatewayName -R …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | GenericArguments[0], 'Microsoft.Azure.Management.Network.Models.SecurityRule', on 'T MaxInteger[T](System.Collections.Generic.IEnumerable`1[T])' violates the constraint of type 'T'.

Found a similar issue: https://github.com/Azure/azure-powershell/issues/18721, seems there is no solution for it yet.
AZ CLI version:
az --version
azure-cli                         2.43.0

core                              2.43.0
telemetry                          1.0.8

Extensions:
azure-devops                      0.25.0

Dependencies:
msal                              1.20.0
azure-mgmt-resource             21.1.0b1

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\xinfeng.li\.azure\cliextensions'

Python (Windows) 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:37:59) [MSC v.1933 32 bit (Intel)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Powershell version:
$PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.0
PSEdition                      Core
GitCommitId                    7.3.0
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a9906cba-acc2-5978-1380-2b2f445a00da
Version Independent ID: a547cc17-92ce-e889-ed78-8fc294cca01b
Content: Migrate WAF policies for Azure Application Gateway
Content Source: articles/web-application-firewall/ag/migrate-policy.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@xinfli
Thanks for your feedback! We will investigate and update as appropriate.

There is solution for bug #18721, and it works for me too: https://github.com/Azure/azure-powershell/issues/18721#issuecomment-1314864891


Better reporting when Class-initClassTree fails on startup

Atom 1.7.3
OSX 10.10.5
SC 3.7.0-beta1
When trying to compile in Atom this error message shows up:
`config
sclang:	/Applications/SuperCollider/SuperCollider.app/Contents/MacOS/sclang
sclang:	/Applications/SuperCollider/SuperCollider.app/Contents/MacOS/sclang
booting
init_OSC
empty
compiling class library...
...
NumPrimitives = 710
compiling dir: '/Applications/SuperCollider/SuperCollider.app/Contents/Resources/SCClassLibrary'
compiling dir: '/Users/tatecarson/Library/Application Support/SuperCollider/Extensions'
Open ended string ... started on line 66 in file '/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/sc-lib-master/couchdb.sc'
Open ended string ... started on line 230 in file '/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/sc-lib-master/gepLoader.sc'
compiling dir: '/Users/tatecarson/.atom/packages/supercollider/node_modules/supercolliderjs/lib/sc-classes'
pass 1 done
ERROR: Class extension for nonexistent class 'Document'
In file:'/deprecated/3.7/deprecated-3.7.sc'
ERROR: Class extension for nonexistent class 'Spherical'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/3Dj-master/supercollider/Extensions/plus/plusSpherical_SS.sc'
ERROR: Class extension for nonexistent class 'Cartesian'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/3Dj-master/supercollider/Extensions/plus/plusSpherical_SS.sc'
ERROR: Class extension for nonexistent class 'RealVector'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/quarks/DissonanceLib/classes/HarmonicVector.sc'
ERROR: Class extension for nonexistent class 'Document'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/quarks/lfsaw.de/wordBins.sc'
ERROR: Class extension for nonexistent class 'Rational'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/sc_utils-master/JustIntonationTools.sc'
ERROR: Class extension for nonexistent class 'Rational'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/sc_utils-master/SternBrocotTree.sc'
ERROR: Class extension for nonexistent class 'Matrix'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/sc_utils-master/SternBrocotTree.sc'
ERROR: Class extension for nonexistent class 'TuningRatios'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/tuningClasses/extTuningRatios.sc'
numentries = 2859968 / 102303464 = 0.028
14887 method selectors, 6872 classes
method table size 71302312 bytes, big table size 818427712
Number of Symbols 38009
Byte Code Size 1758999
compiled 1521 files in 3.24 seconds
Info: 26 methods are currently overwritten by extensions.  Not sure about the yaml file or where I would put it.
thanks

It looks like the problem is that you have various things in your extensions folders but you don't have the quarks installed that those extensions refer to. Also you probably have some quarks installed that depend on other ones that aren't installed.
You manually moved these files into your Extensions folder:
ERROR: Class extension for nonexistent class 'TuningRatios'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/tuningClasses/extTuningRatios.sc'

Which would be fine, this is just a warning. The compiler ignores those class extensions and just moves on.
But then:
Execution warning: Class 'Document' not found
compiling tunings
Execution warning: Class 'CV' not found

This was an error that happened while supercollider was running its startup. After it compiles the library (which succeeds) it then calls *initClass on every class. (supercollider should post that it is starting initClass and then finishing. that would make it more obvious to people)
Something you have in there failed, so supercollider threw an error and stopped. Because class initialization failed, SuperColliderJS didn't get to initialize itself (it failed before it got to SuperColliderJS.initClass) and it's not set up to communicate with atom.
That's why you got a messy raw error dump here.
I can figure out how to get around this failure on startup.
You will get the exact same errors on startup if you use the standard SC IDE.
What you should probably do is remove those files from Extensions and remove all Quarks. Then reinstall just the ones you need. SuperCollider is not very good at handling these conflicts and it falls over dead far too easily. That's something I can probably handle better with atom-supercollider to at least inform people what the state of their system is and what the problem might be.
Never mind about the yaml file, its only important if you have SuperCollider installed in some strange place.

If you've installed SuperCollider in a non-standard place or have a development build, then create a .supercollider.yaml file to specify the path where sclang can be found.

I did a full reinstall and it works now. I’ve been meaning to do this for a while but finally was able to with the summer. Thanks for your help, excited to get into Atom.
--
Tate Carson
Sent with Airmail
On May 10, 2016 at 1:12:04 AM, Chris Sattinger<EMAIL_ADDRESS>wrote:
It looks like the problem is that you have various things in your extensions folders but you don't have the quarks installed that those extensions refer to. Also you probably have some quarks installed that depend on other ones that aren't installed.
You manually moved these files into your Extensions folder:
ERROR: Class extension for nonexistent class 'TuningRatios'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/tuningClasses/extTuningRatios.sc'
Which would be fine, this is just a warning. The compiler ignores those class extensions and just moves on.
But then:
Execution warning: Class 'Document' not found
compiling tunings
Execution warning: Class 'CV' not found
This was an error that happened while supercollider was running its startup. After it compiles the library (which succeeds) it then calls *initClass on every class. (supercollider should post that it is starting initClass and then finishing. that would make it more obvious to people)
Something you have in there failed, so supercollider threw an error and stopped. Because class initialization failed, SuperColliderJS didn't get to initialize itself (it failed before it got to SuperColliderJS.initClass) and it's not set up to communicate with atom.
That's why you got a messy raw error dump here.
I can figure out how to get around this failure on startup.
You will get the exact same errors on startup if you use the standard SC IDE.
What you should probably do is remove those files from Extensions and remove all Quarks. Then reinstall just the ones you need. SuperCollider is not very good at handling these conflicts and it falls over dead far too easily. That's something I can probably handle better with atom-supercollider to at least inform people what the state of their system is and what the problem might be.
Never mind about the yaml file, its only important if you have SuperCollider installed in some strange place.
If you've installed SuperCollider in a non-standard place or have a development build, then create a .supercollider.yaml file to specify the path where sclang can be found.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Trying to get the class lookup going and having trouble following your directions. I have ctags. Here are a few questions:

When you say make the file named ~/.ctags what exactly does that mean? is that a txt file that should then contain that text?

I sort of know what a symlink is but what’s the best way to make one? Also, when you say “project directory” what exactly do you mean? The atom directory? The supercollider directory? Where I keep my scds? Will I have to do this if I put projects into different folders?

thanks,
--
Tate Carson
Sent with Airmail
On May 10, 2016 at 3:12:25 PM, Tate Carson<EMAIL_ADDRESS>wrote:
I did a full reinstall and it works now. I’ve been meaning to do this for a while but finally was able to with the summer. Thanks for your help, excited to get into Atom.
--
Tate Carson
Sent with Airmail
On May 10, 2016 at 1:12:04 AM, Chris Sattinger<EMAIL_ADDRESS>wrote:
It looks like the problem is that you have various things in your extensions folders but you don't have the quarks installed that those extensions refer to. Also you probably have some quarks installed that depend on other ones that aren't installed.
You manually moved these files into your Extensions folder:
ERROR: Class extension for nonexistent class 'TuningRatios'
In file:'/Users/tatecarson/Library/Application Support/SuperCollider/Extensions/tuningClasses/extTuningRatios.sc'
Which would be fine, this is just a warning. The compiler ignores those class extensions and just moves on.
But then:
Execution warning: Class 'Document' not found
compiling tunings
Execution warning: Class 'CV' not found
This was an error that happened while supercollider was running its startup. After it compiles the library (which succeeds) it then calls *initClass on every class. (supercollider should post that it is starting initClass and then finishing. that would make it more obvious to people)
Something you have in there failed, so supercollider threw an error and stopped. Because class initialization failed, SuperColliderJS didn't get to initialize itself (it failed before it got to SuperColliderJS.initClass) and it's not set up to communicate with atom.
That's why you got a messy raw error dump here.
I can figure out how to get around this failure on startup.
You will get the exact same errors on startup if you use the standard SC IDE.
What you should probably do is remove those files from Extensions and remove all Quarks. Then reinstall just the ones you need. SuperCollider is not very good at handling these conflicts and it falls over dead far too easily. That's something I can probably handle better with atom-supercollider to at least inform people what the state of their system is and what the problem might be.
Never mind about the yaml file, its only important if you have SuperCollider installed in some strange place.
If you've installed SuperCollider in a non-standard place or have a development build, then create a .supercollider.yaml file to specify the path where sclang can be found.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Yes, a text file in your home directory called .ctags with that text inside it.

Don't mess with symlinks unless you are familiar with them. Project directory means the directory where you are working - where your .scd files are. The folder that Atom opened up and shows the files in the tree view on the left side. That is your project.

Ok, this worked when I removed the commented out text from your example ctags file and symlinked the others into the project folder. alt-cmd-down_arrow doesn’t seem to do anything but that’s ok.
--
Tate Carson
Sent with Airmail
On May 11, 2016 at 3:58:10 AM, Chris Sattinger<EMAIL_ADDRESS>wrote:
Yes, a text file in your home directory called .ctags with that text inside it.
Don't mess with symlinks unless you are familiar with them. Project directory means the directory where you are working - where your .scd files are. The folder that Atom opened up and shows the files in the tree view on the left side. That is your project.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

I am now using atom-ctags with autocomplete-plus
https://atom.io/packages/atom-ctags
use Atom ctags: Rebuild to regenerate the index if it needs it.
I need to update atom-supercollider docs for this. I had problems with symbol-gen and the standard autocomplete where it often did not go to the symbol and didn't report any problem. very annoying.
use Key Binding Resolver: Toggle to see what your alt-cmd-down-arrow is triggering.

Oh good, got that working. The only thing i’m really missing from the IDE now is method reminders. I could add them as snippets I guess for things I use often but it’s usually more necessary for ugens that I don’t remember what their methods are. Just want to thank you again, atom is a much better experience than the IDE, night and day.
--
Tate Carson
Sent with Airmail
On May 12, 2016 at 1:11:11 AM, Chris Sattinger<EMAIL_ADDRESS>wrote:
I am now using atom-ctags with autocomplete-plus
https://atom.io/packages/atom-ctags
use Atom ctags: Rebuild to regenerate the index if it needs it.
I need to update atom-supercollider docs for this. I had problems with symbol-gen and the standard autocomplete where it often did not go to the symbol and didn't report any problem. very annoying.
use Key Binding Resolver: Toggle to see what your alt-cmd-down-arrow is triggering.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Great to hear !
I'd like to eventually hook into the help docs and some introspection on
the class/methods. That would provide inline docs.
Even if I can just get a pane that displays the help files.
On Fri, May 13, 2016 at 9:07 AM tatecarson<EMAIL_ADDRESS>wrote:

Oh good, got that working. The only thing i’m really missing from the IDE
now is method reminders. I could add them as snippets I guess for things I
use often but it’s usually more necessary for ugens that I don’t remember
what their methods are. Just want to thank you again, atom is a much better
experience than the IDE, night and day.
--
Tate Carson
Sent with Airmail
On May 12, 2016 at 1:11:11 AM, Chris Sattinger<EMAIL_ADDRESS>wrote:
I am now using atom-ctags with autocomplete-plus
https://atom.io/packages/atom-ctags
use Atom ctags: Rebuild to regenerate the index if it needs it.
I need to update atom-supercollider docs for this. I had problems with
symbol-gen and the standard autocomplete where it often did not go to the
symbol and didn't report any problem. very annoying.
use Key Binding Resolver: Toggle to see what your alt-cmd-down-arrow is
triggering.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/crucialfelix/atom-supercollider/issues/58#issuecomment-218967618

--
https://twitter.com/crucialfelix
https://medium.com/@crucialfelix
http://www.mattermind.com/


[WIP] Add HyperGeometric distribution

Description
Here's the problematic one @aloctavodia
Checklist

[x] Code style is correct (follows pylint and black guidelines)
[x] New features are properly documented (with an example if appropriate)
[x] Includes a sample plot to visually illustrate the changes (only for plot-related functions)

Codecov Report

Merging #215 (cc16ce8) into main (98e17c0) will decrease coverage by 0.04%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   83.82%   83.78%   -0.04%
==========================================
  Files          26       26
  Lines        3042     3078      +36
==========================================
+ Hits         2550     2579      +29
- Misses        492      499       +7

Impacted Files
Coverage Δ

preliz/distributions/__init__.py
100.00% <ø> (ø)

preliz/internal/distribution_helper.py
95.65% <ø> (ø)

preliz/internal/optimization.py
98.73% <66.66%> (-0.63%)
:arrow_down:

preliz/distributions/discrete.py
92.36% <82.35%> (-0.86%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Group Challenge sign

The idea is to allow many people join a course and for everyone to start at the same time as a race, similar to "/pa challenge".
When a player joins a timed Challenge, a timer is initiated to allow for all the players that want to join in, once the time threshold is met (for example 10 seconds)
Then the course join countdown will start down and the join course functionality will start.
Not quite sure of the specifics yet, but it sounds fun.

Challenge signs will act like a usual Challenge. However a Player may be allocated as the host of the Challenge if a Challenge for that Course doesn't already exist. Any subsequent Players that join the Challenge using the Sign will be added as participants to the existing Challenge. The host of the Challenge must then start the Challenge using "/pa challenge start".


Memory Leak in TExpectedPromiseState

Firstly, thanks for creating this library! It's made working with promises in Unreal so much more ergonomic.
While investigating a linear memory leak in our dedicated server, I found what appears to be a memory leak in TExpectedPromiseState, where the CompletionTask is seemingly never freed, meaning every future we create results in an unfreed allocation. The task is created here:
https://github.com/splash-damage/future-extensions/blob/1ef3fb0b6905666fbb886fc212013e60af396804/Source/SDFutureExtensions/Public/ExpectedFuture.h#L394
One can validate it is never destroyed by substituting FNullGraphTask with a derived class that faults the process upon destruction of the task:
	class FFailingNullGraphTask : public FNullGraphTask
	{
	public:
		FFailingNullGraphTask(const TStatId& StatId, ENamedThreads::Type InDesiredThread)
			: FNullGraphTask(StatId, InDesiredThread)
		{
		}

		~FFailingNullGraphTask()
		{
			*(int*)nullptr = 0;
		}
	};

The destructor is never run, nor is the task ever freed which results in the prepared task residing in memory forever. The allocation is fairly small, however over time it very quickly adds up to several megabytes (we make use of promises for all of our HTTP requests).
It can be indepedently verified using the MALLOC_LEAKDETECTION=1 flag, as referenced here.
Unfortunately, I'm not familiar enough with the internals of the library to propose a fix, despite my best efforts 😄
If it's useful, here is the unit test I wrote to identify the leak:
struct FAsyncCommandHelper
{
	bool bDispatched = false;
	int CompletePromises = 0;
	int NumPromises = 0;
};

DEFINE_LATENT_AUTOMATION_COMMAND_ONE_PARAMETER(FPromiseLeakTest, FAsyncCommandHelper, AsyncHelper);

bool FPromiseLeakTest::Update()
{
	if (!AsyncHelper.bDispatched)
	{
		FMallocLeakReporter::Get().Start();

		for (int i = 0; i < 256; i++)
		{
			SD::Async([this]
			{
				AsyncHelper.CompletePromises++;
			});

			AsyncHelper.NumPromises++;
		}

		AsyncHelper.bDispatched = true;
	}

	bool bIsDone = AsyncHelper.CompletePromises == AsyncHelper.NumPromises;
	if (bIsDone)
	{
		FMallocLeakReporter::Get().Stop();
		FMallocLeakReporter::Get().WriteReports();
	}

	return bIsDone;
}

Hi @trixnz , thanks for the report! I am taking a look and should hopefully have a fix for that soon.

Thanks for the fix! I've verified it on our end, looking great now 🎉


docs(contributing): add podling status report guide

Hi, everyone! I have written a simple guide on Podling Status Report.
Fixes: #2911

cc @tisonkun, would you like to help review this doc?

Thanks!


Update en_US

The changes reflect the official terms for the different story/event types for EN.

Great thanks


Contribution Doc Update

add CONTRIBUTING.md
set up gulp and jshint for linting
add CODE_OF_CONDUCT.md
remove unused config dependency

Just curious, why not use ESLint? You don't need to gulp for that, and ESLint is the de facto JS/ES6 linter used today especially in open source.

:+1: sure we can move to ESLint.


Slack integration

It would be really cool to get PowerfulSeal to notify about errors on Slack.

Love the idea :)
But I think that having some kind of AbstractNotification interface might be useful here (similar to the metrics one).
Useful in case someone wants to receive notifications in Mattermost, Zulip, Rocket, Discord...

Love the idea :)
But I think that having some kind of AbstractNotification interface might be useful here (similar to the metrics one).
In case someone wants to receive notifications in Mattermost, Zulip, Rocket, Discord...

Definitely. Slack is all the rage now, but we'll see what's cool in a year or so :)

Apprise would likely be a good candidate for this.

Apprise looks awesome, just like what we'd want here. Thanks! @simskij

And it could make for a fun PR for Hacktoberfest too.

For sure, shouldn't be too much work to get it going.