Tighten Campaign level denormalization and saving

Before saving the campaign, load all missing levels and achievements so rewards are properly set
Have individually loaded levels save and report changes properly
Do not propagate campaignIndex from non-course campaigns to levels
Do not set level properties to 'undefined', making it seem like they have local changes
Update campaign indexes before saving the campaign
Have fetching achievements by campaign handle odd level original values
When a level is edited, propagate those changes to campaigns immediately

Coverage decreased (-38.6%) to 17.225% when pulling 19e95305d701efd342190ceebe6937c346ccafea on campaign-editor into 3eddd4392787bbcdd361842af0f513f3fb8eb061 on master.

Coverage increased (+0.008%) to 55.811% when pulling 1b0b319e4e938d96d3bad6f29064dbbafb6f0c8c on campaign-editor into 3eddd4392787bbcdd361842af0f513f3fb8eb061 on master.

Coverage increased (+0.001%) to 55.804% when pulling 1b0b319e4e938d96d3bad6f29064dbbafb6f0c8c on campaign-editor into 3eddd4392787bbcdd361842af0f513f3fb8eb061 on master.

Coverage increased (+0.04%) to 55.846% when pulling 060640e51d4175962e9a9ddc3d641655a6e02097 on campaign-editor into 3eddd4392787bbcdd361842af0f513f3fb8eb061 on master.

Coverage increased (+0.05%) to 55.853% when pulling 060640e51d4175962e9a9ddc3d641655a6e02097 on campaign-editor into 3eddd4392787bbcdd361842af0f513f3fb8eb061 on master.

Coverage increased (+0.04%) to 55.846% when pulling 43bf457a7bbcaedae27f58e56b92609a9dff63cd on campaign-editor into 9abf9dcc53c930734745372c6e7c1780150c082e on master.

Coverage increased (+0.04%) to 55.846% when pulling 43bf457a7bbcaedae27f58e56b92609a9dff63cd on campaign-editor into 9abf9dcc53c930734745372c6e7c1780150c082e on master.

Coverage increased (+0.04%) to 55.846% when pulling 43bf457a7bbcaedae27f58e56b92609a9dff63cd on campaign-editor into 9abf9dcc53c930734745372c6e7c1780150c082e on master.


[HOLD for payment 2024-08-01] [$125] [HIGH] [API Reliability] Opening the Wallet page calls the OpenPaymentsPage twice

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721384323190839
Action Performed:
Break down in numbered steps

Open Console > Networks tab
Open Profile
Open the Wallet page

Expected Result:
Describe what you think should've happened
The OpenPaymentsPage read call is made only once
Actual Result:
Describe what actually happened
The API was called twice
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015c4debdbfd2eca47
Upwork Job ID:<PHONE_NUMBER>623728799
Last Price Increase: 2024-07-19
Automatic offers:

nyomanjyotisa | Contributor | 103183901

Issue OwnerCurrent Issue Owner: @mallenexpensify

This is a simple change, @nyomanjyotisa proposal is looking good, assigning

@nyomanjyotisa what is your ETA for the PR?

Contributor: @nyomanjyotisa  paid $125 via Upwork
Contributor+: @thesahindia owed $125 via NewDot
@thesahindia plz complete the BZ checklist above.

@thesahindia if you propose we don't want a regression test case, can you provide reasoning why you think we don't need one?  For this, I'm assuming it's because The OpenPaymentsPage read call is made only once is more of a backend thing that just needed to be updated and checking for that each time isn't necessary.

$125 approved for @thesahindia


TruePeak: Replace FFT with filter

Removing the humongous FFT for interpolation and using a filter instead.

Will merge now. Just another note on the overshoot for that particular EBU test file. I went back and tested the original library I'd based this on, and my original unit test, both of which run across the whole file with no intervening framing, and both report results very much within the EBU tolerances for that file (-5.985 dBTP), but that SC code still reports -5.1.
So, I think there may be some artefact in the framing or something that warrants investigation.


Apostrophes and brackets cause script to fail.

This script works great and has been really handy, thanks!
It won't run if a directory name has an apostrophe:
'
And the script abruptly ends if it encounters brackets:
[]
I've just been renaming directories and renaming them back after. For chapter directories with brackets, it'll fail on the rename step for changing ZIP to a CBZ, so not a huge deal to do those stragglers manually. Series directories with a bracket the script will display the message that it's finished without running, however.

I don't see the problem with the apostrophes. If your encounter this bug again please screen the error message and the rendered folder (if there is any)

Seems like it's okay (though I can't be sure for the apostrophes because I don't have this problem).


MCP:0 in bottom right corner of Minecraft game main menu rather than MCP:10000?

Hi! The trouble that I'm having is the one specified under this FAQ:
https://github.com/Microsoft/malmo/wiki/FAQ#why-do-i-get-failed-to-find-an-available-client-for-mission-when-i-try-to-run-a-tutorial
Failed to find an available client for this mission - tried all the clients in the supplied client pool
The solution suggests ensuring that the MCP says 10000 in the bottom right corner; however, mine says MCP:0 and I can't seem to change this in any way. For instance, I tried running launchClient.bat -port 10000 -env, and this starts up successfully except it still says MCP:0 in the bottom right corner of the main menu. Also tried launchClient.bat -port 10001 -env and same outcome. Also tried from the Minecraft game main menu: Mods > Microsoft Malmo Mod > Config and then in green below the toggle buttons it says that MCP: 0 as well. However, if I try to change anything at all on this toggle page, none of it affects the fact that it stays MCP:0.
For context, the MCP:0 I am referring to on the main menu is the blue text in the following image:

Thank you so much!

Hi @Russell-Tran, sorry for taking so long to respond. Did you manage to fix this in the end?
If not, what OS are you using? And do you have the same behaviour if you omit the "-env" from the command line?


Trying to build without w3m

I am starting some tests to clean botbrew

w3m is being removed in order to check if we really need it
please don't merge now

I think that the busybox upgrade should be moved away from here, feel free to apply that commit into the master branch ( git cherry-pick it ).
The build script is wrong. It should run make for every package, but unexpectedly it run make once with all the package as target.
Fix this to to have a good idea of what is failing.
Thank you for your great work and help <3

Hey @tux_mind, I agree with you but there is still some errors (in
busybox), so, I will merge it later
2016-04-19 17:03 GMT+02:00 tux-mind<EMAIL_ADDRESS>
I think that the busybox upgrade should be moved away from here, feel free
to apply that commit into the master branch ( git cherry-pick it ).
The build script is wrong. It should run make for every package, but
unexpectedly it run make once with all the package as target.
Fix this to to have a good idea of what is failing.
Thank you for your great work and help <3
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cSploit/botbrew/pull/2#issuecomment-211967999


test(WMG): 5050 Conditionally run WMG e2e tests based on API URL

Reason for Change

#5050
If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
"Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Notes for Reviewer

Thanks for the quick review, @atarashansky 🎉 !

Ah the test is failing for real, because we've updated the WMG cubes, and since the test selects the first dataset, which is now 22 integrated samples, it doesn't narrow down the options.
I'll update the test to select disease acute kidney failure on Tuesday, so our test is more predictable and not dependent on datasets order, which changes more frequently 👌

Fixed the test 👍


fix: Patch bad reference to clone key variable in dockerfile/cosmos

Also tagging @boojamya and @johnletey for visibility (want to make sure this was the intention).

@pharr117 Good catch, yes this was a mistake on our end!

oops , Accidently review  on my part .
I had two PRs open and reviewed the wrong one* .
Please wait for someone else to review.


Enforce a single sort order for tests by setting the locale

Possibly we could do this in the test directory makefile ;)
In any case it sorts out the issue!


Long running then return an empty list (Python version)

Describe the bug
The straw python package can't fetch data correctly, when running:
result = matrixObj.getDataFromBinRegion(4000000,6000000,4000000,6000000)

It will be blocked for a monment, then return an empty list.
To Reproduce
see the Screenshot. My test data can be downloaded from here.
Expected behavior
Return list with readed values.
Screenshots

Desktop (please complete the following information):

OS: Windows 10, WSL2, Ubuntu 20.10
Python version: 3.9.5

The Bin coordinates (in getDataFromBinRegion) are defined as genomic_position/resolution, so the issue here will likely be resolved after fixing those coordinates. Alternatively, you may want to use strawC, which is faster, can be installed from the pybind11 folder, and supports the old usage syntax.

Thanks for your reply. I will try to use strawC.


Inconsistent statements about hebrew support

In the Readme, it both says that Hebrew shaping is supported and unsupported. Maybe you've added Hebrew support in the past and added it to the list of supported fonts, but forgot to remove it from the limitations?

Oops! That should probably say Khmer is unsupported. :nerd_face:

Thanks for that @est31. It's been updated, and will be merged in the coming days.


setPresenter should dettachView on the previous presenter and attach to the new if the view is attached

I have noticed that if we update the presenter of an MvpFragment/MvpActivity/MvpLinearLayout... the setPresenter method does not have any logic to attach the view to the new presenter if the view is currently visible.
The reason for this is that I was considering switching the presenter to a different class (implementing the same interface) when entering into "edit" mode in a given screen.
However, I would need to handle the attach/dettach view manually which is something that feels error prone, and that could potentially be done by the MvpFragment and similar classes.

hi,
I'm sorry but I'm not sure if I have understood you correctly.
What do you mean with "update the presenter"? You mean you have a View and change the "presenter" dynamically but the view still remains the same?

Sorry not to make it clear enough.
My point is that I have a view I want to switch to an "edit" mode. I could do with a single presenter, but I'd have to keep several conditions like "if state is edit, do this, else, do that".
I was wondering if I could set a different presenter when the view enters edit mode, that wait instead of having several conditions I'd just have two smaller independent presenters that could be unit tested separately.
Upon inspecting the setPresenter code given by MvpFragment amongst other, I noticed there's no logic to dettach the view from the previous presenter, and attach it to the new one. Hence this issue.

I see, that makes sense.
However, from my point of view that would change the View as well? In my opinion an entirely new EditView with his own EditPresenter should be visible on screen.
Otherwise your "single" view will have all that "if state is edit, do this, else, do that" (instead of the presenter).

I think we could avoid the if's by having the presenter notify an entirely different method.
PS: I'll be busy this days on a business trip so I'm not sure If I'll manage to provide much more feedback :/

I think this is not the default use case (and I still think a separated View and Presenter for edit mode is the cleaner approach), so I will not add support for that kind of feature you are asking for (setPresenter should dettachView() of previous Presenter and automatically bind the new presenter), because it will blow up the internal code and as already said, I think it's not the way things should be implemented.
However, there is another solution (already existing solution) which should work (not tested yet) that comes close to what you try to achieve.
Mosby provides an ActivityMvpDelegate, FragmentMvpDelegate and ViewGroupMvpDelegate and a corresponding MvpDelegateCallback you have to implement.
So what you can do is create two "ActivityMvpDelegate" container objects like this (imagine that there are View interfaces NormalView  and EditView):
class MyActivity extends AppCompatActivity implements EditView, NormalView {

      private NormalViewDelegate normalViewDelegate;
      private EditViewDelegate editViewDelegate;

     void onCreate(Bundle b){
            super.onCreate(b);
            setContentView(R.layout.my_view_with_normal_and_edit_mode);
            normalViewDelegate = new NormalViewDelegate(this);
            editViewDelegate = new EditViewDelegate(this);

          normalViewDelegate.onCreate(b);
          editViewDelegate.onCreate(b);
      }

     void onDestroy(){
          super.onDestroy();
          normalViewDelegate.onDestroy();
          editViewDelegate.onDestroy();
     }

     ...  // also forward all other lifecycle callbacks like onResume() etc.
}

Then EditViewDelegate look like this:
class EditViewDelegate implements <EditView, EditPresenter>, MvpDelegateCallback<EditView, EditPresenter> {
   ActivityMvpDelegate mosbyDelegate = new ActivityMvpDelegate<>(this);
   EditView editView;

   EditViewDelegate(EditView editView){
       this.editView = editView;
   }

  void onCreate(Bundle b){
        mobsyDelegate.onCreate(b);
   }

  void onDestroy(){
        mobsyDelegate.onDestroy();
   }

   ... // also forward other lifecycle events

   @Override   // MvpDelegateCallback method
   EditView getMvpView(){
       return editView;
    }

   @Override // MvpDelegateCallback method
   EditPresenter createPresenter() {
         return new EditPresenter();
    }

   ... // other MvpDelegateCallback methods
}

You also have to do the same for NormalViewDelegate. The trick here is that  getMvpView() is actually pointing to the parent activity, because the activity is implementing EditView and NormalView interface. The containers NormalViewDelegate and EditViewDelegate are just there to separate mosby's internal methods which otherwise would cause conflicts (because of generics) if they would be implemented directly in your Activity.
With this aproach you will have two decoupled Presenter, "living" at the same time, programming agains a dedicated MvpView interface each, but still having one single layout file containig the components of both, NormalView and EditView.
Hope that helps!


Incompatible with Lumen 6 under PHP 7.2

I try to use the package with Lumen 6 and PHP 7.2 and this not work.
The request does not pass the values.
// I try
$this->json('POST', 'my-route', ['value1' => 1, 'value2' => 2]);

// And receive
$request->all() // []

I think this is the same as Issue #13


xpath-expressions

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: xpath-expressions
Document link: xpath-expressions.md
My Issue/Suggestion
Please include more information on performance cost when using XPath queries

Hi @JesperVerschoor,
Thank you for your feedback.
We currently have XPath best practices for app performance, Xpath best practices for app developement, and some recommendations from our Best Practice bot that are related to XPath (you can search in the doc for any XPath-related recommendations).
Are these docs relevant to your question? Please specify a bit more on what aspect of performance cost you want to know about in terms of using XPath queries. Thank you!
Kind regards,
Yiyun

@JesperVerschoor
Can you please let me know whether the docs provided above have the information you are looking for?
I will wait for another week. If I haven't received a reply then, I will close this issue.
Kind regards,
Yiyun

@JesperVerschoor
I haven't received a reply yet, so I am closing this issue for now. Please let us know in the future if you have more feedback.
Kind regards,
Yiyun


BluetoothThermalPrinter is dead ?

i am wait for update
seems it is not been update for long time is it dead ?
please update the plugin

I hope the owner does merge the pull requests, especially the Gradle plugin version update


Illegal back-to-back write error with libwebsockets 3.0

https://github.com/tsl0922/ttyd/issues/83#issuecomment-356353617

[2018/01/09 19:18:37:7941] ERR: ** 0x6aaaf0: vh: default, prot: http-only, Illegal back-to-back write of 492019 detected...

https://libwebsockets.org/lws-api-doc-v3.0-stable/html/md_READMEs_README_8coding.html#oneper

Heads up: libwebsockets 3.0.0 has been released.

Same issue. Any idea of how long it will take to this bug to get fixed? Is there a temporary solution I can try meanwhile?

Same here. Last version of libwebsockets which works for me is v2.4.2 (built from source).

Resolved by 0f97a694465df94f93609adb6ebae05e94554d2e

问题依然存在呀
日志等级为7，刷新一会儿之后报错

0xb6fa7a60: vh: default, prot: http-only, role h1: Illegal back-to-back write of 293984 detected
以下是loglevel=6的信息
root@openwrt:~# /usr/bin/ttyd -i br-lan -p 4200 -u root -s SIGKILL -d 6 login [2018/08/22 21:27:12:8644] NOTICE: ttyd 1.4.0 (libwebsockets 3.0.0) [2018/08/22 21:27:12:8646] NOTICE: tty configuration: [2018/08/22 21:27:12:8647] NOTICE:   start command: login [2018/08/22 21:27:12:8647] NOTICE:   reconnect timeout: 10s [2018/08/22 21:27:12:8648] NOTICE:   close signal: SIGKILL (9) [2018/08/22 21:27:12:8652] NOTICE: Creating Vhost 'default' port 4200, 2 protocols, IPv6 on [2018/08/22 21:27:20:0425] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:27:20:1610] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:27:25:1729] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:27:55:1937] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:28:01:3985] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:28:03:1570] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan) [2018/08/22 21:28:04:0673] NOTICE: HTTP / - <IP_ADDRESS> (R7800.lan)

@monokoo 请发新的 issue，并附重现步骤和上日志。


Fixes #100

Location data can be updated via csv upload.  Also contains a test for csv audit file name.

poop
This commit isn't actually this large.  I merged master into it (and rebased) which is why I think it is showing so much.  Only need to review the files in  region/src/main/java/org/motechproject/nms/region/csv/impl and the tests.  Or just take my word for it that it's good.

I'll take your word for it.
 I merged master into it (and rebased) which is why I think it is showing so much. Only need to review the files in region/src/main/java/org/motechproject/nms/region/csv/impl and the tests. Or just take my word for it that it's good.
—
Reply to this email directly or view it on GitHub.

Well then you'd be mistaken, because it's not just good ...


AttributeError: 'Schema' object has no attribute 'pre_load'

Using the List type on a schema within another schema returns the following error AttributeError: 'Schema' object has no attribute 'pre_load'. I see from the last MR, this was supposed to make it work, but it's failing for me.
Using lupin v1.3.6 and python 3.7
cve_schema = Schema({ "id": f.String(), "updated": f.String() })

recent_cve = Schema({ "cve": f.List(cve_schema) })

Wrapping the cve_schema in an Object type does the trick f.List(f.Object(cve_schema))

Wrapping the cve_schema in an Object type does the trick f.List(f.Object(cve_schema))


Implement return type and parameter type on the Rewrite file

In this case, when implementing this extension on the latest magento version 2.3.6-p1 and with PHP 7.3 the rewrite function does return the CookieMetadata as the parent function does: vendor/magento/framework/Stdlib/Cookie/CookieMetadata.php:157
In this commit the correct parameter type is added as well as the correct return type
Ideally this needs to be a new bump from 2.3.1 to 2.3.2
Please edit my target branch if it's incorrect.

Bump 👍🏻

@cstergianos Thx!


Bump cert-manager version strings v0.9.0 -> v0.10.0

NONE

/assign @munnerz

These should be v0.10.0-alpha.0, and you also need to replace all occurrences of release-0.9 with release-0.10 😄

These should be v0.10.0-alpha.0, and you also need to replace all occurrences of release-0.9 with release-0.10

Whoops!

/lgtm


[4.0 RC2+] - HTML5 Builds - Detect Game Controller On 1st Press Of Controller Button...

Godot version
v4.0.rc2.official [d2699dc7a]
System information
HTML5 Builds(Windows/Linux/macOS? PC Internet Browsers)
Issue description
Hi,
I've seen the above used somewhere on the Internet.
It was a game controller test web application.
If the user pressed a button on the controller, the test app would detect it.
Jesse
Steps to reproduce
N.A.
Minimal reproduction project
N.A.

https://gamepad-tester.com/

So what is this issue about? The tool is already known and was linked in multiple issues (and I think in the documentation).

Closing due to lack of response. Please comment if you can still reproduce this bug on the latest Godot version.
PS: If no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.


Log out link is not working for me

Hi!
Thank you for making the library,
I'm trying to use the following for log out:
<%= link "Sign out", to: Routes.pow_session_path(@conn, :delete), method: :delete %>
but is not working, it says route /session GET doesn't exist when I click it

It should generate something like:
Sign out

It may be the javascript that's not working. The docs Phoenix.HTML explains that javascript has to be enabled for it to work: https://hexdocs.pm/phoenix_html/Phoenix.HTML.Link.html#link/2-javascript-dependency
There's a javascript file in Phoenix.HTML that has to be added to the JS build. The other way of dealing with it is to have it as a form:
<%= form_for @conn, Routes.pow_session_path(@conn, :delete), [method: :delete, as: :user], fn _ -> %>
  <%= submit "Sign out" %>
<% end %>

Thank you for the prompt answer, I didn't have javascript imported so that must be why it didnt work


v0.28.2 // Site will not load after upgrade...

Describe the bug
Try to load the site after upgrade from v0.27.x, presented with the following error when debug set to true in .env file.
"Declaration of BookStack\Http\Middleware\TrustProxies::handle(Illuminate\Http\Request $request, Closure $next) should be compatible with Fideloper\Proxy\TrustProxies::handle($request, Closure $next) ◀"

Steps To Reproduce
Steps to reproduce the behavior:

Open site URL.

Expected behavior
Either be presented with the login screen, or content if already logged in.
Screenshots
...with debug true.

Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): 0.28.2
PHP Version: 7.4.3
Hosting Method (Nginx/Apache/Docker):  Apache2

Additional context
Initially had the issue wth php 7.2.x, upgraded to 7.4.x per the bookstack upgrade page just to be on latest and issue persists.

Hmm, Just checked and the classes appear to be compatible. In fact I remember there was even a pull request to update this to make it compatible. Can I confirm you've definitely ran composer install at this point and the version file in the root of your BookStack instance install directory shows v0.28.2?

/var/www/bookstack$ cat version
v0.28.2


Fix unbounded ray depth in PathTracer

I tried to tackle #1467 as well. I am aware that my solution can increase the variance a little, but it touches the existing code minimally and improves performance.


java program memory keeps growing without reclaiming the problem

MacOs arm64
Java 17

Hello
Whenever I process a pdf file, java's memory grows by a few MB. i thought there would be a memory reclaim, but in fact the memory is not reduced.
I am looking for your help, thanks!

The JDK maximum amount of memory is usually capped, so it cannot go above a certain level. The JVM is designed to reclaim memory only when needed, without a policy to force the garbage collector running unnecessary computation.
Over time the memory will flatten out to the maximum allowed to the JVM.

The JDK maximum amount of memory is usually capped, so it cannot go above a certain level. The JVM is designed to reclaim memory only when needed, without a policy to force the garbage collector running unnecessary computation. Over time the memory will flatten out to the maximum allowed to the JVM.

i know，thank you very much!


cabal exec -- ghc *\fourier.hs

reanimate-master\examples\fourier.hs:36:12: error:
? Variable not in scope:
signal :: Integer -> Double -> Frame Double
? Perhaps you meant ‘signum’ (imported from Prelude)
|
36 | phi <- signal 0 (2*pi)
| ^^^^^^

Hi Tridu33,
The example has been updated to reflect the API changes.


runtime: Consistent indent for "However, some actions..."

The shorter-than-normal (for the rest of this list) indent landed with
the line in be594153 (Split create and start, 2016-04-01, #384).

LGTM

Needs rebase.

On Tue, May 31, 2016 at 09:42:04AM -0700, Mrunal Patel wrote:

Needs rebase.

Rebased with ad803e5 → 7b28a16, although I see no changes (besides the
commit date and hash) with:
$ diff -u <(git show ad803e5) <(git show 7b28a16)
I think GitHub just has some buggy conflict-detection code out
recently.

LGTM


AbstractController::ActionNotFound: The action ' ' could not be found for

When trying to write controller tests(RSpec) i Have this error:
AbstractController::ActionNotFound: The action ' ' could not be found for <Controller Name>
routes.rb
Rails.application.routes.draw do
  scope :api do
    scope :v1 do
        resources :<controller_name>, except: [:new, :edit]
    end
  end
end

class <Controller Name> < ApplicationController
  before_action :set_<model name>, only: [:show, :update, :destroy]

  def create
    ## create method works in application crashes only in test
  end
end

RSpec.describe <Controller Name>, type: :controller do
  describe "POST #create" do
    context "with valid params" do
      it "creates a new <Model Name>" do
        expect {
          post :create, { <Model Name>: valid_attributes } ## Starting post crashes tests
        }.to change(<Model Name>, :count).by(1)
      end
    end
  end
end

gem 'rails', '4.2.5'

gem 'rails-api'

Ok I found what couses this issue:
there is method in ActionController::Base called _find_action_name
and its implementation is:
def _find_action_name(action_name)
        _valid_action_name?(action_name) && method_for_action(action_name)
end

the problem is in method_for_action part it look for templates (html or erb):
  def method_for_action(action_name)
      super || if template_exists?(action_name.to_s, _prefixes)
        "default_render"
      end
    end

but in rails-api html templates dont exists so to remove this issue we should probably override this method in ActionController::Api to something like this:
def _find_action_name(action_name)
        _valid_action_name?(action_name)
end

I will fix this issue and provide merge request :D

I was still getting nils in process method, after more carefull debug I found:
gems/actionpack-4.2.6/lib/action_controller/test_case.rb:636
name = @request.parameters[:action]
# when i changed to this tests started working fine
name = @request.parameters["action"]

Thats strange, can any one have idea why i am facing this strange issue?
Any One used rspec with rails-api gem before?

I succeed test creation of a resource with rspec without problems.
Are you organizing directories according to namespaces?

im too facing the same problem

Is there any update on this?


chore: Update conformance tests submodule

(This is prior to fixing a Firestore conformance test.)
Entirely autogenerated by running updateconformancetests.sh.

Will look into the storage test failure.

The failing Storage conformance test is due to the test harness being sensitive to query parameter ordering. I'm looking into updating the conformance test to be consistent with the other tests.

Closing as I'll have a new PR with an update and the Firestore change.


Android Studio compile failed

I'm wonder. Why is newest version from development branch in Android studio compile failed?

We're getting ready to announce 3.2 today, so if you could figure it out I would be grateful. :)

This should be fixed in PR #312. Enjoy!

Thanks. I can not wait to try this :+1:

Resolved.

Oh, great! I have tested this already, and everything work realy fine!
Only, I decreased SDK version from 22 to 19:
compileSdkVersion 19
minSdkVersion 19
targetSdkVersion 19
And it works great


Counterfactual app compatibilities

Describe the bug
The solidity compiler version and the app imports for our apps and the counterfactual apps seem to have fallen out of sync. This definitely effects the Unidirectional Transfer App and the Unidirectional Linked Transfer App, but we should probably update + redeploy all for consistency.
Expected behavior
These should definitely be in sync to avoid any unanticipated and hard to debug weirdness.
Additional context
We will have to redeploy our apps to rinkeby and mainnet. Ideally there would be some type of automated check here before deployments, but that's just an extra gold star. Would be nice to remove the legacy dependency on @counterfactual/contracts if possible as well

This should be done now, right @bohendo ?


eshoplite project dotnet publish error:

C:\Program Files\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: D:\cupertino\aspire-samples\samples\eShopLite\eShopLite.CatalogDb\appsettings.De
velopment.json, D:\cupertino\aspire-samples\samples\eShopLite\eShopLite.CatalogService\appsettings.Development.json, D:\cupertino\aspire-samples\samples\eShopLite\eShopLite.CatalogDb\appsettings.json, D:\cupertino\aspire-samples\samples\eShopLite\eShopLite.CatalogService\appsett
ings.json. [D:\cupertino\aspire-samples\samples\eShopLite\eShopLite.CatalogService\eShopLite.CatalogService.csproj]
It seems that both db and service project have appetting file. and output to the same folder/

What project did you publish?

I just dotnet publish under the folder contains sln follow the guide:
Publish the solution projects to ACR using the dotnet publish command in the solution directory:
In the solution directory
dotnet publish -r linux-x64 --self-contained -p:PublishProfile=DefaultContainer -p:ContainerRegistry=$loginServer

I also see a proj about catalogdb. In guide, I do not see the deployment step about that proj.

@DamianEdwards this project errors when you deploy

Hmm I remember hitting this and can't recall how I fixed it or why it's not fixed here. I know the cause, will have to investigate. Odd that we haven't hit this earlier as part of the AZD development.


Individual article links at 'admin/content-dashboard' not routed right

To enact the bug: at 'admin/new-story', enter a story and submit.
I expect: the links upon clicking take me to 'articles/:id' page
What happened: Got a 404 land message.

Yes, I have asked @adai183 to work on finishing this.

I have to hack megadraft to accept markdown to load content into the editor.
It needs json to load and save article content.
But I thinks we can do a little hack and make it accept markdown.
I might need some time because I will be at a wedding this weekend. :-)
I made an example using json to load the article content on individual_article_links branch for now.

Awesome!  Thanks for the update.


Change sub_network_head_size and query_groups to positional arguments

Small issue that came up while working on https://github.com/whittle-org/whittle/issues/146
Since we moved the computation of sub_network_head_size and sub_network_query_groups to model.py, they should be positional arguments in causal_self_attention.py (and transformer_block.py):
https://github.com/whittle-org/whittle/blob/a07ee5afef0f23b309a3a089cdf09ee3f75b359a/whittle/models/gpt/blocks/causal_self_attention.py#L48
Calling the function without any arguments causes set_sub_network() to crash:
 def set_sub_network(
        self,
        sub_network_n_embd: int,
        sub_network_n_head: int,
        sub_network_query_groups=None,
        sub_network_head_size=None,
    ):
        self.sub_network_n_embd = sub_network_n_embd
        self.sub_network_n_head = sub_network_n_head
        self.sub_network_query_groups = sub_network_query_groups
        self.sub_network_head_size = sub_network_head_size

        self.sub_network_qkv_shape = (
            self.sub_network_n_head + 2 * self.sub_network_query_groups   # this crashes
        ) * self.sub_network_head_size

It's not affecting anything right now, as we always call it with arguments that are not None. I suggest fixing it to avoid hidden errors in the future.
 def set_sub_network(
        self,
        sub_network_n_embd: int,
        sub_network_n_head: int,
        sub_network_query_groups: int,
        sub_network_head_size: int
    ):

@gabikadlecova can I work on this?


Replace packr with go embed

Description
Replaces packr with go embed.
Note: was necessary to track the ui/build/ dir in git because with go embed, it becomes a compile-time dependency.

LGTM! Different from how I approached it. I think I even like your implementation better. Following this idea would be nice to improve the "dependency injection" so to say. Some high-level services are being instantiated very nested, e.g. the PID.


Fix protocol arguments missing group name

Caused protocol arguments to be grouped under logging.
Signed-off-by: Daniel Bluhm<EMAIL_ADDRESS>

Codecov Report

Merging #217 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   72.68%   72.68%   +<.01%
==========================================
  Files         219      219
  Lines       10136    10137       +1
==========================================
+ Hits         7367     7368       +1
  Misses       2769     2769


New expressions

Hi @martinaxgloria
Could you please update the expressions we have with the latest ones we received from the designers, which are better centered with respect to the whole face?
Here's the latest delivery: expressions.zip.
Be careful, the correct tag for one expression is alert and not angry[^1]. Thus, you'd need to update the config.ini file too.
cc @Nicogene @maggia80
[^1]: The attached archive already contains the correct tags.

Hi @pattacini,
yes, I'm already doing all the necessary changes to the module

PR here:

https://github.com/icub-tech-iit/ergocub-software/pull/105

cc @pattacini @Nicogene

Reopening just because we'd need a video of the latest expressions running on the robot for comparison purposes, as we aim to get the final @maggia80's approval on that.

Today, during the demo session, I took this video in order to check the last version of the facial expressions:
https://github.com/icub-tech-iit/ergocub-software/assets/114698424/3f407843-ac58-4574-a0be-9b8d7a599486
Talking with @maggia80 and @pattacini, we noticed that the videos are not exactly centered on the OLED and maybe we can ask to move up the expressions a little bit more. For the first issue, I will check it more in detail by using one of the expressions with a centered line and then we can send the request to the designers.

As expected and as you can see from the photo below, the expressions are not centered at all (the white line is not aligned with the "middle" of the mask)

cc @pattacini @maggia80 @Nicogene

Well done @martinaxgloria 👍🏻
We need a way to convey the following info to the designers:

We need to move the expressions even further up.
We need to center the expressions in the middle of the face.Well done @martinaxgloria 👍🏻
We need a way to convey the following info to the designers:
We need to move the expressions even further up.
We need to center the expressions in the middle of the face.

To achieve 1 and 2, one possibility is that we stick to one particular expression (the one above is the best, is it alert?) and:

Draw a horizontal line that meets our requirements: i.e., identify on the robot where the biggest eye should be tangential to that line.
Draw a vertical line that meets the center of the face. With trial and error, you could move the bar further right until the point it is aligned with the groove in the cover.

After a quick internal review, the designer will receive this expression with the two bars and will adjust all the expressions accordingly.
To achieve 1 and 2, one possibility is that we stick to one particular expression (the one above is the best, is it alert?) and:

Draw a horizontal line that meets our requirements: i.e., identify on the robot where the biggest eye should be tangential to that line.
Draw a vertical line that meets the center of the face. With trial and error, you could move the bar further right until the point it is aligned with the groove in the cover.

After a quick internal review, the designer will receive this expression with the two bars and will adjust all the expressions accordingly.

Lovely!
I think we can proceed indeed!
The horizontal bar should be the limit of the right eye's shade.

The horizontal bar should be the limit of the right eye's shade.

Yes, we ask to take this expression as reference and then to adapt the others

Here's the reference image:

@martinaxgloria sent out the email 📧
We can close this!


Implement model combining various algorithm scores

An obvious idea to try is to see whether we can combine the scores of 2 or maybe even 3 algorithms to gain additional insights.

This is done with #16


Upgrade versions

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7287627623

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7287627623
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7291407032

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7291407032
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7296352873

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7296352873
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7296393228

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7296393228
Status: success


Roll Flutter Engine from da71729651d8 to 10ba73406e0e (1 revision)

https://github.com/flutter/engine/compare/da71729651d8...10ba73406e0e
2024-11-27<EMAIL_ADDRESS>[Impeller] make sampler use string_view instead of std::string. (flutter/engine#56821)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix time conversion in cpp camera driver

The timestamp of the image and diagnostic messages from the cpp driver of the
camera contains "random" data.
The Aldebaran doc [1,2] states that element 4 contains seconds and element 5
contains microseconds. In the code these are swapped. Also see the python
node where the conversion is done correctly.
[1] http://doc.aldebaran.com/2-1/naoqi/vision/alvideodevice-api.html#image
[2] http://doc.aldebaran.com/1-14/naoqi/vision/alvideodevice-api.html#image

bad bug. Can you please use that constructor to make it easier to read, thx.
http://docs.ros.org/api/rostime/html/classros_1_1TimeBase.html#a7078d355a0386221674e888a92534a77

Done


Future of this project

@sapessi - am running express lambda in production using this library. Considering that this project has not been update in a while & with issues open and no one looking into them. I would like to know if this library is going to be update by awslabs and maintained ?

Hi @Muthuveerappanv - we'll have an update for you over the next couple of weeks.

Agreed, it's hard enough trying to convince teams to move to serverless.

Would love to see that promised update! Was having great progress porting an Express app over to Lambda, then I hit #134 and its game over. AWS seemingly dropping support for this repo gives me cold feet.

Apologies for the delay all. We have just updated the main README of the project with our plan for the future - spoiler alert, @brettstack is back!
Message below:

AWS Serverless Express is moving
On 11/30, the AWS Serverless Express library is moving to Vendia and will be rebranded to serverless-express. Similarly, the aws-serverless-express NPM package will be deprecated in favor of a new serverless-express package.
Brett, the original creator of the Serverless Express library, will continue maintaining the repository and give it the attention and care it deserves. At the same time, we will be looking for additional contributors to participate in the development and stewardship of the Serverless Express library. AWS and the SAM team will remain involved in an administrative role alongside Vendia, Brett, and the new maintainers that will join the project.
We believe this is the best course of action to ensure that customers using this library get the best possible support in the future. To learn more about this move or become a maintainer of the new Serverless Express library, reach out to us through a GitHub issue on this repository.
Best,
The AWS Serverless team, Brett & the Vendia team

Thanks for the update, there is already a serverless-express package this may cause some confusion.

Sigh, thanks for letting us know. We'll figure out a name and update the message.

The serverless-http package is a pretty good alternative with less footprint:
https://github.com/dougmoscrop/serverless-http


Normal Behavior?

Hello,
So I'm just starting out, can't say I completely understand everything, but... we learn as we go right?
Anyways, I've setup the config file as given in the wiki (For deluge) and Issue 58.
When I run cross-seed search I get:
Validating your configuration...
Your configuration is valid!
Found 55 torrents, 9 suitable to search for matches
.
.
.
Done! Found 0 cross seeds from 9 original torrents

That is ahhh... less than ideal.
So is there something I'm doing incorrectly? Shouldn't it scan more torrents and at least find a few? How should I proceed?

You could try changing searchAll to "true", as it will search for more torrents for a possible match. Not all torrents have a matching torrent across trackers; some are archived, some are unpacked, have different names, etc..

This is most likely normal behavior, especially if you're not searching very many trackers.

Hmm, I'll take these into consideration, I using roughly 15 trackers right now (given the type of torrent), and it seems to only scan torrents that are movies.

Changing searchAll to "true" seems to have fixed it, scanned all of them now.
I got a couple of hits, and Unsupported: magnet link detected which from the issues I understand isn't yet supported correct?

Magnet links will never be supported because they don't contain enough information to verify a match


sort articles by last modified

Test URLs:

Before: https://main--upm--hlxsites.hlx.page/
After: https://sort-index--upm--hlxsites.hlx.page/

sorted in excel, no code required


Add a -Recurse switch to Measure-Object to support input objects / properties that are collections themselves

Currently, Measure-Object treats each input object / input object's property as a scalar; e.g.:
PS> ((1, 2), (3, 4) | Measure-Object).Count
2 # The input arrays each counted as *1* object - their elements weren't counted.

PS> ([pscustomobject] @{ prop = 1, 2 }, [pscustomobject] @{ prop = 3, 4 } |
      Measure-Object -Property prop).Count
2  # The arrays stored in .prop each counted as *1* object - their elements weren't counted.

Note that if you also specified a switch such as -Sum, the commands would break, because an attempt is made to interpret the array as a number, which fails: Measure-Object : Input object "System.Object[]" is not numeric.
It would be handy if a -Recurse switch would allow opting into recursing into array-valued input objects / properties:
PS> ((1, 2), (3, 4) | Measure-Object -Recurse).Count  # WISHFUL THINKING
4   # The input arrays' elements were counted individually

PS> ([pscustomobject] @{ prop = 1, 2 }, [pscustomobject] @{ prop = 3, 4 } |
      Measure-Object -Recurse -Property prop).Count  # WISHFUL THINKING
4 # The elements of the arrays stored in .prop were counted individually

Environment data
Written as of:
PowerShell Core v6.1.0-preview.3

Note that there are already many ways to achieve the same effect : (1, 2), (3, 4) | write | Measure-Object or $objList.prop | write | Measure-Object or $objList | select Expand prop | Measure-Object  or $objList | foreach prop | Measure-Object

Thanks for the examples, @BrucePay.
While the problem can definitely be solved with the current features, as you demonstrate, my motivation for suggesting  -Recurse is the desire for convenience and concision (and greater efficiency, to a lesser degree).
If backward compatibility weren't a concern, I would have have suggested the inverse logic: enumeration by default, with an opt-out via -NoEnumerate.


kubectl debug: image debugging

What would you like to be added?
Currently, in order to use kubectl debug, user has to pass resource name which should already exist and that might prevent users, if they want to debug just any built image without creating manually.
From kubectl debug ephemeral containers perspective(whose they are running inside the existed pods), this has no meaning. However, from kubectl debug --copy-to perspective, user simply can debug an image by executing;
kubectl debug -it --image=busybox --copy-to=my-debugger
Why is this needed?
In order to debug the built images without relying on any existed resources.

/triage accepted


Simplify simplify test cases, support ^, &, |, << and >> operators for building exprs

Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/5423
Rationale for this change
as @izveigor pointed out on https://github.com/apache/arrow-datafusion/pull/5423/files#r1125686357, the tests in expr simplifier used a more verbose style that he followed, which makes sense.
However, I would like to keep the codebase easier to maintain and thus use less ceremony for creating Exprs.
What changes are included in this PR?

Support ^, &, |, << and >> opertors for building exprs
Simplify expression simply test cases

Are there any user-facing changes?
You can now create exprs like
let expr = lit(0) & lit(45)

If this syntax is not deprecated, it should probably be tested as well?

I agree it should be tested. I will review our existing coverage and see if anything else is neede

If this syntax is not deprecated, it should probably be tested as well?

I agree it should be tested. I will review our existing coverage and see if anything else is needed

I reviewed the use of binary_expr and I think there is plenty of other coverage (see https://github.com/search?q=repo%3Aapache%2Farrow-datafusion binary_expr&type=code)
I didn't see much focused testing for the functions defined in in https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr_fn.rs
https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr_fn.rs
Thus I conclude this PR doesn't impact the test coverage for expression creation functions.
If we want to cover the functions in expr_fn.rs more deliberately or in a more structured way, I think we could do it as a follow on PR / add tests specifically for that coverage, rather than rely on tests for other functionality (simplification) covering somewhat unrelated functionality (expr creation)


Find My Mouse should be able to set opacity of overlay and highlight separately

Description of the new feature / enhancement
Today, we can adjust the opacity of the entire Find My Mouse overlay as a whole. I would like to be able to set the highlight of the "light" region around the mouse and the "dark" region separately.
Scenario when this would be used?
I would use this to set the highlight opacity to 0. This would make "Find my Mouse" useful as a gesture enhancer when sharing screens via a conferencing software or recording screen capture videos.
Supporting information
No response

/dup #15512


review summary view of dataplane

Description
The view is not great. For example it's all broken with long dataplane names or with a lot of tags.
There's probably something that can be done to have this view be a lot simpler.

We're not doing this right now we'll open a new issue once we reintroduce the "drawer" view


Building Gadgets Leaves Ghost Blocks on Undo

Issue:
When using Building Gadgets on a claim, if you build and then undo the build, it leaves behind ghost blocks.
Steps to reproduce:
Set Building Gadgets to Vertical wall
Stand in any claim (that you can build in)
Place 3x3 wall
Undo
Ghost blocks are left.
GPDebug:
https://griefprevention.github.io/debug/?y8QOwmU9rt
Versions:
griefprevention-1.12.2-<IP_ADDRESS>6
spongeforge-1.12.2-2768-7.1.6-RC3568
LuckPerms-Sponge-4.3.80
BuildingGadgets-2.4.6

Confirmed, I could reproduce this on Building Gadgets 2.4.6 as well as 2.6.3, on latest SF/LP/GP as of writing this reply.
Using the gadget to make a wall in the wilderness, and then using the Undo key resulted in no ghost blocks.
Doing the same in a claim resulted in ghost blocks that had to be broken by hand.

What I found odd though, was I went to record things so I could show it happening, and I stopped being able to reproduce it.

After more testing, for some reason the tool is coming across as no user in debug sometimes, and others as my user. The mod only works in creative mode, so setting the following flag in the wilderness should work.
/cf block-break buildinggadgets:lasergunentity true override

The mod works in survival too? As long as you have the blocks on your person that you are trying to build with

That flag should still be safe to use in that case anyway, as the only way for that source to be doing block-break, is by the user using the Undo key. I can't see any way it could be abused.

I get this when trying the suggested command

Update to latest SF/GP.


Not able to access the "i" value inside the condition task which is used in for loop of decision case.

Hi,
I was trying to access the "i" value which used in for loop of decision case. Trying to access it inside the descision case task.
"caseExpression": "for (var i=0; i<$.hits_array.length; i++) {if($.hits_array  !=  null) {'true';} else{'default';}}",
"scriptExpression": null,
"decisionCases": {
"true": [
{
"name": "some_task",
"taskReferenceName": "simpleDecisionMerge",
"inputParameters": {
"i_value": "i",
but "i_value" not getting populated with the integer value used inside the forloop is there a way to access the "i" value inside the decision task?

Same as #1652, the keys are not available for JSONPath evaluation.


ui.R calls shinyThings which is not declared in deps.yaml

- Package: shinyThings
  GithubUsername: gadenbuie
  GithubRepo: shinyThings
  GithubRef: master
  GithubSHA1: 585a40f4015cac4e89851898e20ab4c7547c620c

seems to work

I think it is 😄 ... maybe it's pointing to the wrong commit though
Branch: self-contained https://github.com/gadenbuie/tweet-conf-dash/blob/ec3784286e4e53a9c401af0276ab14d21c50a731/deps.yaml#L9-L13
Branch: master https://github.com/gadenbuie/tweet-conf-dash/blob/0317ac6e8f803c732380571037b5430acfea47cd/deps.yaml#L9-L13

27433295... is relatively old, but I don't think tweet-conf-dash relies on anything added or modified after that commit. Does this version work for you?
remotes::install_github("gadenbuie/shinyThings@2743329525c5a76d4798ff3acedb70db9562b64f")


Tony/39_input_required

Pull Request Details
What issue does this PR address

Expanded the functionality of the button widget to allow specifying which questions are mandatory, and check whether these questions have been completed before submitting or saving the data.

Link to associated issue: #39

Checklist
Complete the check-list below to ensure your branch is ready for PR.
Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

[x] Screenshots included in linked issue
[x] Changes adhere to the team style and coding guideline
[x] No confidential information
[x] No duplicated content
[x] No lint check errors related to your changes (make prep or flutter analyze lib)
[ ] Pre-exisiting lint errors noted: [HERE]
[x] Tested on at least one device

[ ] Android Phone
[ ] Android Emulator
[ ] Chrome on Android
[ ] Chrome
[ ] iOS
[ ] Linux
[x] MacOS
[ ] Windows

[x] Added 2 reviewers (or 1 for private repositories then they add another)

Finalising
Once PR discussion is complete and 2 reviewers have approved:

[ ] Merge dev into the branch
[ ] Resolve any conflicts
[ ] Add one line summary into CHANGELOG.md
[ ] Bump appropriate version number in pubspec.yaml
[ ] Push to git repository and review
[ ] Merge PR into dev

I wanted to add another required question to Survey 1. So I added (Required) label under question 3 in sample_markdown.md. But that does not seem to work. When I press the submit button it still says the required questions are only questions 1 and 4.

I wanted to add another required question to Survey 1. So I added (Required) label under question 3 in sample_markdown.md. But that does not seem to work. When I press the submit button it still says the required questions are only questions 1 and 4.

Hi Anushka, there is a required question id list between the %%Button-Begin and %%Button-End label. You can add the question id (Question 3) here.


"Chat with Rider" Button Hidden by "Live Chat" Button on Enatega Multivendor Website

Issue: "Chat with Rider" Button Hidden by "Live Chat" Button on Enatega Multivendor Website
Description:
A significant issue has been identified on the Enatega Multivendor website, where the "Chat with Rider" button is obscured by the "Live Chat" button, making it difficult for users to access this specific feature.
Impact:
User Frustration: Users may experience frustration when they cannot find or access the "Chat with Rider" button due to the overlapping "Live Chat" button.
Communication Breakdown: The issue can result in difficulties in communicating with the rider for order-related updates or queries.
Steps to Reproduce:

Visit the Enatega Multivendor website.
Place an order or access the order tracking section.
Attempt to locate the "Chat with Rider" button.
Observe that it is hidden or obstructed by the "Live Chat" button.

Expected Resolution:
The website should be adjusted to ensure that the "Chat with Rider" button is easily accessible and not obscured by other buttons or elements. This is crucial for providing users with a smooth and hassle-free experience when communicating with the rider for order-related matters. Addressing this issue promptly is essential for user satisfaction and efficient order management.

Issue Resolved: This issue has been successfully fixed.


App Suggestion: [READECK]

Please tell us what app you'd like to see on CapRover as a one-click app.
Readeck:

Readeck is a simple web application that lets you save the precious readable content of web pages you like and want to keep forever

Do you know if there is any official Docker image for the app?
Here are the instructions: https://codeberg.org/readeck/readeck#container

Thank you for suggesting this useful app!


Performance degradation when using compact instances

We tried to decrease the memory footprint of the FleCSI applications by using the Legion compact instances. This resulted in a huge slowdown (e.g. some of our applications have become 3 times slower).
If needed, I can potentially provide some profiling data.

I think it would be helpful to describe the number of rectangles in your compact sparse instances and the access patterns (e.g. random access, linear walk, etc.).
I would also describe what kind of accessors you're using. I'm presuming MultiAffineAccessor which at the moment does not support spatial search to discover which piece is needed to access for a random access entry. Therefore unless you hit in the cache, access time looks more like O(N) instead of O(log N).

I presume legion implements it's own spatial data structure somewhere? Realm I think builds a form of a kd-tree to optimize intersection testing. That should probably be packaged into some form of public data structure and used everywhere including accessors.

This issue looks relevant:

https://github.com/StanfordLegion/legion/issues/629

I presume legion implements it's own spatial data structure somewhere? Realm I think builds a form of a kd-tree to optimize intersection testing. That should probably be packaged into some form of public data structure and used everywhere including accessors.

Yes, #629 is somewhat relevant, but I don't think we need to expose the acceleration data structure here though. We just need to leverage it in this case for the multi-affine accessor class inside Realm. It would be good to use Realm's existing spatial acceleration data structure rather than rolling a new one. Although, really we should only be doing this if the number of rectangular pieces in the instance is "large" and a linear search over the pieces would be inefficient. It's unclear where that threshold is but it shouldn't be too hard to measure as it should be a property of the number of rectangles and not their shapes.
For now I've encouraged @MoraruMaxim to use Realm's compute covering utility to try to coarsen up his compact sparse instances into fewer pieces that still doesn't waste much memory.


Fix false positive when modifying other users profiles

This PR is similar to https://github.com/coreruleset/wordpress-rule-exclusions-plugin/pull/12, it fixes a few additonal false positives under /wp-admin/user-edit.php.
I noticed that /wp-admin/user-edit.php page is identical to /wp-admin/profile.php and is missing a few exclusions, I've copied the missing exclusion from 9507520 and pasted it to 9507530.

Looks good, thank you, merging!


Can't execute JUnit Test

I added a java  directory in src/test and wrote a JUnit Test,like this:
- src
  - test
     + groovy
     - java
         + HelloTest.java

then execute the mvn command:  mvn clean && mvn test
but in the result, I can't find the HelloTest
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running account.fb.manager.HelloSpockSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.134 s - in account.fb.manager.HelloSpockSpec
[INFO] Running DatabaseDrivenSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.043 s - in DatabaseDrivenSpec
[INFO] Running DataDrivenSpec
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s - in DataDrivenSpec
[INFO] Running DerivedSpec
base setupSpec()
derived setupSpec()
base field initializer
derived field initializer
base setup()
derived setup()
base spec method
derived cleanup()
base cleanup()
base field initializer
derived field initializer
base setup()
derived setup()
derived spec method
derived cleanup()
base cleanup()
derived cleanupSpec()
base cleanupSpec()
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 s - in DerivedSpec
[INFO] Running EmptyStackSpec
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 s - in EmptyStackSpec
[INFO] Running HamcrestMatchersSpec
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 s - in HamcrestMatchersSpec
[INFO] Running IncludeExcludeExtensionSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s - in IncludeExcludeExtensionSpec
[INFO] Running OrderedInteractionsSpec
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 s - in OrderedInteractionsSpec
[INFO] Running PublisherSpec
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 s - in PublisherSpec
[INFO] Running StackWithOneElementSpec
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s - in StackWithOneElementSpec
[INFO] Running StackWithThreeElementsSpec
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 s - in StackWithThreeElementsSpec
[INFO] Running StepwiseExtensionSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s - in StepwiseExtensionSpec
[INFO] Running UsingJUnitRulesSpec
entering 'retrieve test name at runtime'
leaving 'retrieve test name at runtime'
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 s - in UsingJUnitRulesSpec
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 39, Failures: 0, Errors: 0, Skipped: 0

then I try to remove the Spec from pom.xml
<includes>
     <include>**/*Test.java</include>
      <!--  <include>**/*Spec.java</include>-->
</includes>

and execute:
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (default-test) @ spock-example ---
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.473 s
[INFO] Finished at: 2020-07-27T15:10:59+08:00
[INFO] ------------------------------------------------------------------------

Is that something wrong?
Thanks for answer

There has HelloTest in the target/test-classes


[Enhancement] add metrics for user connections

Why I'm doing:
Now the connections are for all users, and we currently have a limit on the number of connections that can be made at user granularity, so add the user label
What I'm doing:
Add label user for connections.

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

Should manager and templates of Prometheus also be changed?

Should manager and templates of Prometheus also be changed?

Yes,I will update the templates of Prometheus and Manager.

@mergifyio rebase

@Mergify rebase


Telegram - Waiting for Network ...

https://i.imgur.com/M0fYsz7.png
Please refer to image. I think this is very common especially if you're running multiple telegrams.
Please advice.

:)

https://i.vgy.me/imQz1c.jpg
Same here especially between 4am-6am UTC


Discrepancy between data availability checks, data reads, and size calculations

From https://github.com/libbpf/blazesym/blob/50408a3b55c341ef954465a678ee334956c6399c/src/dwarf/debug_info.rs#L257-261
DW_FORM_block4 => {
    if 2 <= data.len() {                                             // Wrong length check
        let bytes = decode_uword(data);                              // Correct read on insufficiently sized data can cause panics
        let fullsize = bytes as usize + 2;                           // Wrong size calculation
        if fullsize <= data.len() {
            Some((AttrValue::Bytes(&data[2..fullsize]), fullsize))   // Wrong buffer inference causing data corruption here and down the line because of wrong reported length
        } else {
            None
        }
    } else {
        None
    }
}

Picture book example of why I have been pushing for fixing this mess that is having one function read a bunch of bytes and then having the caller adjust pointer and offsets and sizes based on implicit knowledge. Three times we hard code the number 2 here. All of them wrong. It should be in exactly a single line of code (either explicit or implicit). If it was copied and pasted wrongly there that would be noticed by a test and it would be clear that there is a single problem and not land mines scattered all over the place. Here some stuff blows up on some of the inputs, if at all, others only down the line with a data corruption, if it gets noticed at all. Such unnecessary bugs couldn't happen had we spared a thought on proper API design.

Here is a somewhat similar problem: https://github.com/libbpf/blazesym/blob/50408a3b55c341ef954465a678ee334956c6399c/src/dwarf/debug_info.rs#L420-L424
The bounds are unchecked and we can end up with a panic when subslicing.


Really bad SEO

This site (https://wiki.nixos.org/) has really bad SEO in comparison to the old site (https://nixos.wiki/).
The following search: zfs nixos wiki has zero results from wiki.nixos.org. Even changing it to zfs nixos wiki wiki.nixos.org does not do much: and the page in question, https://wiki.nixos.org/wiki/ZFS, is nowhere to be seen.
I do not know much about SEO, but this seems possibly due to wiki.nixos.org lacking a robots.txt. It might be prudent to copy https://nixos.wiki/robots.txt directly.

I went through backlink search machines and fixes nixos.wiki links in the most obvious places. https://discourse.nixos.org/t/help-wanted-updating-links-to-point-to-the-new-nixos-wiki/45185
But there is maybe some opportunity to automate this further.

Nice, I heard someone had been doing that! But that's been going on for a while, right? Weirdly poor SEO still suggests to me that there's something else wrong: the line Allow: /wiki/Special:AllPages line in nixos.wiki's robots.txt does seem like it is SEO related.

Now finally deployed. I am open to other SEO tipps.


Added Mattermost to Collaboration Tools

Checklist

[x] I made something good today 💐.
[x ] I put links in the correct format: [Tool](link) — description.
[x ] My description starts with the lower-case letter and ends with the full stop.
[x ] I put the tool in the alphabetical order.

Optional

[ ] I added the appropriate labels: free, open-source or mac.
[x ] I put the tool only to one category.
[x] I followed Contribution Guidelines.

@sitetune thanks for adding Mattermost to our list :)


update envoyproxy SHA

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ldemailly
Assign the PR to them by writing /assign @ldemailly in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a3113ac797f78e1e1f594969e8e17076abd438f5
link
/test istio-unit-tests

prow/istio-presubmit.sh
a3113ac797f78e1e1f594969e8e17076abd438f5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a3113ac797f78e1e1f594969e8e17076abd438f5
link
/test istio-presubmit

prow/istio-unit-tests.sh
441d2baa7c8131b0eb267562e9df49ee471ab8b6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
6ab1a653aa404447e02e2f03c1090bf961a17988
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
6ab1a653aa404447e02e2f03c1090bf961a17988
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6ab1a653aa404447e02e2f03c1090bf961a17988
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Inaccurate instructions in cross-report drillthrough doc

Text probably wrong in section Enable cross-report drillthrough.

To enable a report to be the target of a cross-report drillthrough, you must enable the feature for that report in the Options window.

Shouldn't the highlighted option be enabled in the source report, not in the target report? Option text "Allow visuals in this report to use drillthrough targets from other reports" implies this. (Also did some local tests, which confirmed my suspicions.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70cc0df0-14a7-079d-c32c-78fff8aef03f
Version Independent ID: ff23bd8e-3901-3010-af39-19fb69f2fa6c
Content: Use cross-report drillthrough in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-cross-report-drill-through.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @smith-erik . We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

I don't even see the option in my Options dialog.  I have Persistent filters, Visual options and Export Data sections only...

Thanks for the feedback, this has been corrected in an article update.


Performance improvements with PixelAccess?

Investigate whether using PixelAccess would lead to better performance than the current method which does:
pix = list(im.getdata())

Reading the docs, this is probably a non-starter:

Accessing individual pixels is fairly slow. If you are looping over all of the pixels in an image, there is likely a faster way using other parts of the Pillow API.


Team 15 VnV Plan Review LF1 Req and NFR-T1

NFR-T1 specifies functional interaction to test but LF-1 is purely non functional and does not specify any functionality. Consider adding in another functional requirement to specify this functionality or alter the NFR-T1 appropriately.
TA: @Lyuyang0130

resolved in: ed7d3ea9de2c8ecd01221f43b2461f2fbd82e2d2


Java 11 - Illegal Reflection Access Operations

TCPShield v2.4 seems to be executing illegal reflection access operations on java 11.
The server is running Java 11
openjdk version "<IP_ADDRESS>" 2020-11-04 OpenJDK Runtime Environment 18.9 (build <IP_ADDRESS>+1) OpenJDK 64-Bit Server VM 18.9 (build <IP_ADDRESS>+1, mixed mode)
The following error shows up. Just thought I'd make an issue about it.
Running Waterfall 1.16 build 389. (Latest at time of writing), This did not occur running on java8
WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by net.tcpshield.tcpshield.ReflectionUtils (file:/home/container/plugins/TCPShield-2.4.jar) to field java.lang.reflect.Field.modifiers WARNING: Please consider reporting this to the maintainers of net.tcpshield.tcpshield.ReflectionUtils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release

That's something we're unable to fix and is a message that can be safely ignored.

That's something we're unable to fix and is a message that can be safely ignored.


Headline should have a text-transform variable

Currently setting headings to uppercase requires custom style for h1-h6 and .h1-.h6

Which release of Bootstrap do you use ?

v4.0.0-alpha.6

@MickL so you would like a default class for heading uppercase? something that .text-uppercase does?

A variable like $headings-font-family

Currently setting headings to uppercase requires custom style

Makes sense to me. No plans to provide an empty class or variable for this.


Dark mode

Wolfram, Pjotr en Maarten van den Breemer wanted a dark mode toggle on the website.
Should be easy to implement as this article suggests: https://jfelix.info/blog/dynamic-themes-in-ant-design-how-to-change-between-light-and-dark-theme

#35 Resolves this


Make sqsh_error_str thread safe, and document that the value may be overwritten

POSIX does not require strerror to be thread safe. Instead, use strerror_r to write into our own thread-local buffer.

You're right about that. To fix compilation on Linux, you also need to #define _DEFAULT_SOURCE before #includeing the first header in the .c file.

Codecov Report
Patch coverage: 66.66% and no project coverage change.

Comparison is base (8203ac9) 57.39% compared to head (09114b3) 57.40%.
Report is 2 commits behind head on main.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   57.39%   57.40%
=======================================
  Files          58       58
  Lines        4704     4705    +1
  Branches      703      703
=======================================
+ Hits         2700     2701    +1
  Misses       1611     1611
  Partials      393      393

Files Changed
Coverage Δ

lib/utils/error.c
10.75% <66.66%> (+0.97%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Will there be video processing?

From what I've read there is also video processing in the original GPUImage Framework. Is / Will this be possible with this implementation too?
What I ultimatly want to do is, take different videos, trim them, concat them and apply a filter. Are some of this features inside of the scope of this repo?
Thank you!

Sorry for replying a little later.

gl-react-native v2 which this repo based on, do not support to apply filter on video. Pls see #https://github.com/ProjectSeptemberInc/gl-react-native/issues/141

As the author of gl-react-native said, v3 may support this feature. So, when v3 launched, I'll try my best on this feature.

@CubeSugar @CaptAhak Any suggestions on what to use for applying filters to video in react-native?

Any update on gl-react-native to support videos?


"cargo publish" should error if there are path overrides

This might result in builds that succeed on the local machine, but fail when someone else tries to build the crate.

Indeed! Or it should just ignore them.

Triage:  I tested this scenario today and it seems like path dependencies are ignored during publish (meaning cargo will pull that dependency from the registry, not from the path in Cargo.toml).  Same with patch overrides.   I wasn't able to immeditally find the commit that implemented this, though.

@eminence I believe this is referring to paths overrides, which are defined in config.toml. The package verification step still uses those overrides, when it probably shouldn't.

Ahyes, I see.  Thank you @ehuss for that clarification.

@weihanglo Is this issue S-accepted ? It looks interesting. Can I pick it up and try to improve it?

It is S-needs-mentor, which means we may or may not have time mentoring and reviewing it. It might be okay as you're already familiar with the codebase.


Data slice mutation support (#11939)

Explanation:
Mutation of Data slices had issues when it comes to re-indexing to the base slice region. Previously when a slice of Data was mutated the re-calculation of the slice region was incorrectly assigned to a relative region to the previous backing. Now the slice region will copy the specific region out creating a new data upon CoW semantics and offset the index region upon access. Mutating a non CoW slice will retain the previous region backing but adjust the remaining allocation buffer accordingly. To validate this I have added tests for combinations that should approximate all possible combinations of mutations, backing storages and CoW scenarios.
Scope:
This change applies to Data in all cases for the fix. It modifies all codes paths that handle mutation and re-works the slice region calculations.
Radar (and possibly SR Issue):
rdar://problem/34206043
SR-5887
SR-5873
SR-5810
Risk:
This has medium to high risk (for Data itself) since it is a critical path for the manipulation and mutation of Data. However mitigating funnel points were used to reduce overall impact as well as a large swath of tests covering the changes.
Reviewed by:
Itai Ferber, Michael LeHew Jr, and Tony Parker
Testing:
240+ new tests were added to cover all possible permutations of mutations and backing storage of Data while sliced.

@swift-ci test


Update ISystemOperations.cs to give proper warning for MonitorEventsAsync

Changed Obselete warning to read out the correct shape of the MonitorEventsAsync Task.

@galvesribeiro Can we merge this, please?

The build is failing. Can you fix this first?

The build is failing. Can you fix this first?

I do not think the change and the failing build belongs together. The change only updates the description of an already obsolete method. There is another issue.

@HofmeisterAn from my experience with tests running on CI/CD pipeline, from time to time docker fails.
I suggest to push an empty commit to trigger the tests again, and they may work this time.

Yep, I agree. Although, an empty commit is not necessary IMO. The PR does not change anything expect documentation. Some tests are flaky, I noticed that too. I can take a look at that one.

@MagnusMat my suggestion about pushing a new empty commit to trigger the CI/CD pipeline was meant for you, I made a mistake when tagging the author


Incremental backoff and jitter

Closes #1431
There is an unresolved conversation in the reference implementation for channel - https://github.com/ably/ably-js/pull/1008#discussion_r925971338 I've decided to take state check from Owen's implementation.

I guess most of all other failing/flaky tests were reported like that, but
I agree we should stop this practice and try to fix it in place.
чт, 17 нояб. 2022 г. в 14:50, Lawrence Forooghian @.***

:

@.**** commented on this pull request.
Will review the content of the PR next, but re the skipped tests, I think
ideally we should investigate and fix this here, and not leave it for
#1526 https://github.com/ably/ably-cocoa/issues/1526 and #1527
https://github.com/ably/ably-cocoa/issues/1527. The newly-skipped tests
are tests that were passing before, and have only started to fail after we
added these new tests. Is there something that makes you think that the
problem lies with the existing tests, and not the new ones that we've added?
—
Reply to this email directly, view it on GitHub
https://github.com/ably/ably-cocoa/pull/1520#pullrequestreview-1184347383,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK3CNHMGW7LY7QSXDN2Q7F3WIYZZZANCNFSM6AAAAAARYTEWZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Are the tests that you've marked as skipped failing consistently after adding the new tests?

I just tried (locally) un-skipping the tests mentioned in #1526 and #1527, and I didn't see them failing. But what I did see was some other failures:

RealtimeClientConnectionTests.swift:2193 test__058__Connection__connection_request_fails__connection_attempt_should_fail_if_not_connected_within_the_default_realtime_request_timeout(): Waited more than 20.0 seconds
RealtimeClientConnectionTests.swift:2206 test__058__Connection__connection_request_fails__connection_attempt_should_fail_if_not_connected_within_the_default_realtime_request_timeout(): Start date or end date are empty
RealtimeClientConnectionTests.swift:2246 test__059__Connection__connection_request_fails__if_connection_attempt_fails_connection_state_will_transition_to_DISCONNECTED_with_periodic_connection_attempts_with_incremental_backoff_and_jitter_until_SUSPENDED(): expected to be close to <1.0933> (within 0.2187), got <1.3333>

Are the tests that you've marked as skipped failing consistently after adding the new tests?

Failures are gone now, fix here

There are some newly skipped tests here which shouldn't be the case - is there a particular reason why these tests can't be fixed?

It might be worth considering using a seed for random number generation in the tests here to make retry intervals deterministic (this wasn't possible in ably-js because Math.random() doesn't take a seed argument).

Both fixed now @owenpearson

one of the ARTUtils tests seems to be failing in CI.

expected to be close to <22.5> (within 2.5), got <25>
I've just used calc to check whether it should work, but it doesn't 😅

@maratal I've been reworking this PR to make it more testable. I’m going split it into a sequence of smaller PRs. First one is #1589.

I'm going to close this PR — I intend to land the remainder of this work in #1611, #1612, #1613.


add MAINTAINERS.md

part of governance follow up:
https://github.com/fermyon/spin/issues/2629
cc/ @sealmove @radu-matei

@sealmove are you comfortable being listed as maintainer for this repo?
https://github.com/fermyon/spin/blob/main/GOVERNANCE.md


Syntaxt issue

Hello,
First of all, thank you for all this! Your work looks great!
I have a problem though:
It seems you forgot a comma in README.md, after settings=card_settings,.
Have a nice day

oh thanks for pointing that out!


fix #2333

This definitely wasn't an easy fix: @adswafford.
Displaying the parent's processing name beside the artifacts was already implemented. However, the implementation assumed that each default_parameter_set was unique, which is not true (lots of 'Defaults') and the code was "getting confused" between them. This is solved in these code changes. I also made the search/match of parameters per command so that steps happens faster.
Additionally, we realized that for some reason (still looking into this) there is a difference between the trimming version in Qiita. The difference is that the length is being stored as string/int - this is the only command in the full database that has this problem (checked several times, this morning again). Thus, we need to discuss this during tomorrow's meeting.

Codecov Report

Merging #2356 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2356      +/-   ##
==========================================
+ Coverage   93.77%   93.77%   +<.01%
==========================================
  Files         163      163
  Lines       18593    18597       +4
==========================================
+ Hits        17436    17440       +4
  Misses       1157     1157

Impacted Files
Coverage Δ

qiita_db/test/test_util.py
99.63% <ø> (ø)
:arrow_up:

...pet/handlers/study_handlers/tests/test_artifact.py
97.19% <ø> (ø)
:arrow_up:

...iita_pet/handlers/api_proxy/tests/test_artifact.py
98.22% <ø> (ø)
:arrow_up:

qiita_db/util.py
96.91% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5b61f...c37188f. Read the comment docs.


Startup script is not running when gcp instance comes up

Description
I'm creating a custom image using a base image of windows-2019. I'm using the images/win/windows2019.json script to run the installations on a GCP instance. Once the image is created and I create a vm with it, The startup script isn't running.
Although with the base image, it's working fine.
Through trial and error, I found out that After I remove Finalize-VM.ps1 step and following step
        {             "type": "powershell",             "inline": [                 "if( Test-Path $Env:SystemRoot\\System32\\Sysprep\\unattend.xml ){ rm $Env:SystemRoot\\System32\\Sysprep\\unattend.xml -Force}",                 "& $env:SystemRoot\\System32\\Sysprep\\Sysprep.exe /oobe /generalize /quiet /quit",                 "while($true) { $imageState = Get-ItemProperty HKLM:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Setup\\State | Select ImageState; if($imageState.ImageState -ne 'IMAGE_STATE_GENERALIZE_RESEAL_TO_OOBE') { Write-Output $imageState.ImageState; Start-Sleep -s 10  } else { break } }"             ]         } in the packer script json, the startup script is running, but it then runs into some issue related to HKLM keys.
I understand that this script is written for azure platform and not gcp. But can you please help me understanding what changes do I need to make it work on gcp?
Platforms affected

[ ] Azure DevOps
[x] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Build is passing.
Is it regression?
Not sure as your script is provided for azure platform.
Expected behavior
The startup script should run.
Actual behavior
The startup script is not running. Although In the instance created I can see it in custom-metadata section but it's not running.
Here is a screenshot of gcp logs.

Repro steps
Use Google cloud to build an image using windows-2019 base image.
Create an instance with startup script.
The startup script won't run automatically.

We support only azure as a primary building platform, other cloud providers are out of our scope.


refactor(css--body): apply styles to body element

Relates to: https://github.com/carbon-design-system/carbon-components/issues/71
Setting $css--body: true should apply styles directly to body, while
.bx--body class is now moved to css--helpers

:+1:

Merging


Why it's not loading?

When I start surviv.io and press singleplayer or other mode it's like it's not loading! I don't know what to do but please fix. Can you help?

Make sure you are using Google Chrome, and last version of extension. Make sure no other extensions interfering. If it not helping check console (F12) for errors and send it to me, please.


Failed to run e2e ossf-tests/scorecard-action

Repo: https://github.com/ossf-tests/scorecard-action/tree/main \n Run: https://github.com/ossf-tests/scorecard-action/actions/runs/2432209862 \n Workflow name: Scorecards-with-default-GH-Token-golang-staging \n Workflow file: https://github.com/ossf-tests/scorecard-action/tree/main/.github/workflows/Scorecards-with-default-GH-Token-golang-staging.yml \n Trigger: schedule \n Branch: main \n Date: Fri Jun  3 03:14:53 UTC 2022

Happening due to recent updates to Scorecard API.


Added  ES2019 to demo

could you please add it in the parser demo, or put it in a shared config?

can you specify which parser demo or shared config?

emm, seems it has been added:
https://github.com/eslint/eslint.github.io/blob/bff9433e3797fe5ae0cdbd20729619b0d9caa98b/js/app/parser/parser.config.js#L11-L18


Add support for preprocessing cell values.

Adds support for an optional prop renderCell as a function that will be called
with each cells value before rendering, allowing for preprocessing the values in
the csv.

Thank you @torgeir

Do you mind releasing a new version to npm? @marudhupandiyang


npm  run start-dev fails with error missing script: start-dev.  Please update README.md.

Expected Behavior
npm  run start-dev should not fail because
README.md#adding-new-features-in-csgjs-or-other-modules
states

if desired, start dev server: npm run start-dev

Actual Behavior
Fails with error missing script: start-dev.
See attached 2018-10-21T05_05_00_264Z-debug.log
Suggested Fix
It appears that start-dev was removed from package.json with commit refactor(): switch to monorepo + lerna (#348) .
Suggest that README.md#adding-new-features-in-csgjs-or-other-modules should be updated to reflect how new features are added in CSG.js or other modules in the monorepo + lerna world.
Steps to Reproduce the Problem

create a base directory
clone this repository git clone https://github.com/jscad/OpenJSCAD.org.git
go into OpenJSCAD.org folder cd OpenJSCAD.org
install dependencies npm install
make the openjscad command refer to the code in this folder: npm link
start dev server: npm run start-dev

Specifications

Version: refactor(): switch to monorepo + lerna (#348)
Platform: macOS
Environment: node 8.9.2

I submitted as an accidental dupe of #405, because I was confused by the inconsistent state of GitHub during the October 21 incident.
So I am closing #406.  Please refer to #404.


[FR] respect manifest setting

I am having a setup, where the entry point is not a static index.html but a server generated file. (Craft CMS).
To make that work, I am using the manifest setting of Vite
    build: {
        emptyOutDir: true,
        manifest: true,
        outDir: '../web/static/',
    },

That generated a file like this:
{
  "index.html": {
    "file": "assets/index.c18ecf21.js",
    "src": "index.html",
    "isEntry": true,
    "css": [
      "assets/index.079e947d.css"
    ]
  }
}

I would love to see the generated webfont.css in the css-index too, like:
{
  "index.html": {
    "file": "assets/index.c18ecf21.js",
    "src": "index.html",
    "isEntry": true,
    "css": [
      "assets/index.079e947d.css",
      "assets/webfonts.e0bb4bd3.css"
    ]
  }
}

Is that somehow already possible? If not, I would like to submit a feature request for it.

Hi @vandres!
We've managed to resolve this issue by releasing v3.0.0.

Thank you very much! Already using it :)