HADOOP-16819 Possible inconsistent state of AbstractDelegationTokenSecretManager

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
25m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 31s
trunk passed

+1 :green_heart:
compile
16m 46s
trunk passed

+1 :green_heart:
checkstyle
0m 49s
trunk passed

+1 :green_heart:
mvnsite
1m 27s
trunk passed

+1 :green_heart:
shadedclient
16m 53s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
trunk passed

+0 :ok:
spotbugs
2m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s
the patch passed

+1 :green_heart:
compile
16m 17s
the patch passed

+1 :green_heart:
javac
16m 17s
the patch passed

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
mvnsite
1m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  8s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

-1 :x:
findbugs
2m 15s
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
9m 39s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

132m 27s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.currentKey; locked 88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:[line 366]

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1894/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1894

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux bdfd99a28b6c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0b931f3

Default Java
1.8.0_242

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1894/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1894/1/testReport/

Max. process+thread count
3205 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1894/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
24m 25s
trunk passed

+1 :green_heart:
compile
22m  9s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
20m 30s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 46s
trunk passed

+1 :green_heart:
mvnsite
1m 33s
trunk passed

+1 :green_heart:
shadedclient
18m 52s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 38s
hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 59s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
2m 35s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 32s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s
the patch passed

+1 :green_heart:
compile
22m  1s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
22m  1s
the patch passed

+1 :green_heart:
compile
19m  5s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
19m  5s
the patch passed

+1 :green_heart:
checkstyle
0m 49s
the patch passed

+1 :green_heart:
mvnsite
1m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 14s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 36s
hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 58s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
2m 26s
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m 14s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

172m 49s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.currentKey; locked 88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:[line 379]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1894

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 71f762727e41 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/testReport/

Max. process+thread count
2394 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

looking at this with a goal of getting it in to 3.3.1.
Is the race condition in generating the key IDs? If so, isn't that enough to sync and we can leave the rest alone?

No, the problem is that key id generation and store happens in distinct synchronized blocks so between the two blocks other threads can access currentKeyId which doesn't correspond to any key because it's not stored yet.

OK., now I understand why we need this and why the PR does the right thing,
Can you do  rebase and forced push of the PR to kick off yetus again?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m  6s

trunk passed

+1 :green_heart:
compile
27m 10s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
23m 18s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 46s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 44s

trunk passed

+1 :green_heart:
shadedclient
20m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
26m 18s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
26m 18s

the patch passed

+1 :green_heart:
compile
22m 50s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
22m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 12s

the patch passed

+1 :green_heart:
mvnsite
1m 58s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
2m 48s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 58s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

217m 18s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.currentKey; locked 88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:88% of time  Unsynchronized access at AbstractDelegationTokenSecretManager.java:[line 379]

Failed junit tests
hadoop.security.TestRaceWhenRelogin

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1894

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0e96f88fb06a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 759aa2b89fcaeee15340f05a02af9ff0db855eb5

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/6/testReport/

Max. process+thread count
3134 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1894/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


[Cosmos] Update readmes with missing headers

Build failed because of the missing headers in test/readme
sdk/cosmosdb/cosmos/test/readme.md is missing headers with patterns:

 * ^Azure (.+ client library for (JS|AMQP operations)|Smoke Test for JS)

 * ^Getting started$

 * ^Key concepts$

 * ^Examples$

 * ^Troubleshooting$

 * ^Next steps$

 * ^Contributing$

#4798 Ignores this check.
Update Readme.md files by adding the missing headers.

This got fixed somewhere along the line...


[BugFix] fix csv reader on uncompressed and compressed file

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #

https://github.com/StarRocks/starrocks/issues/11271
https://github.com/StarRocks/StarRocksTest/issues/1092

Problem Summary(Required) ：

This PR:

explicity call reset for every scan range intitializaiton
fix code to avoid integer overflow on remain_length (size_t type)
accept zst suffix for zstd compression

And I change the code to tell if we have crossed scan range. Instead of tracing in fill_buffer, we could trace it in next_record. If parsed bytes have exceedd remain length, we take it as sign of across scan range.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_be_unittest

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_admit_test

run starrocks_be_unittest

run starrocks_be_unittest

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@MergifyIO backport branch-2.4

hive with Parquet file format use zstd compression  Support or not ？@dirtysalt

thanks, I will verify it.

The result of my verification：
1.Hive catalog  support  hive table store as Parquet format use ZSTD/UNCOMPRESSED/SNAPPY compression
2.External tables  for hive also support  Parquet format use ZSTD/UNCOMPRESSED/SNAPPY compression
We use these compression formats, so I only tested these compression algorithms


deprecate cert-mgr-mode option of yurthub

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
We've removed kubelet certmanager mode in #573, and now we only support hubself mode. There's no need to expose the option --cert-mgr-mode which can only be hubself.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

yurthub will not have the option "--cert-mgr-mode".

other Note

/lgtm
/approve


More secure implementation for Islands Architecture

Hello, I'd like to share the following security considerations (which I don't think are vulnerabilities of Fresh) to make Fresh more secure.

Props Manipulation for Islands Architecture
Prototype Pollution in deserialization

This issue is long and some information may be missing. If you have any questions, feel free to ask me.
Props Manipulation for Islands Architecture
Fresh uses Islands Architecture, and the following article introduces how islands work in Fresh:

A Gentle Introduction to Islands - Deno

An example of generated client-side scripts is as follows (formatted):

Fresh renders island components with a JSON value of document.getElementById("__FRSH_STATE").textContent. So, if users can inject an HTML element with id="__FRSH_STATE", it is possible to manipulate the rendering process and potentially change the behavior of the application.
For some applications, there are cases where such an assumption is valid. For example, consider an application that allows users to write markdown text freely.
The following documentation introduces how to render markdown and this example uses deno-gfm:

https://fresh.deno.dev/docs/examples/rendering-markdown

deno-gfm prevents XSS attacks with sanitize-html, but allows adding id attributes to HTML elements:

ref. https://github.com/denoland/deno-gfm/blob/0.2.5/mod.ts#L214-L219

If the following island is defined,
import type { Signal } from "@preact/signals";
import { render } from "$gfm";

interface PreviewProps {
  text: Signal<string>;
}

export default function Preview(props: PreviewProps) {
  return (

  );
}

the following text parameter is valid as a markdown text and it overwrites the island state:

{"v":{"0":[{"text":{"_f":"s","v":"some text"}}]}

Prototype Pollution in deserialization
Fresh deserializes a JSON value of __FRSH_STATE with:

deserialize: https://github.com/denoland/fresh/blob/1.6.2/src/runtime/deserializer.ts#L21-L63

export function deserialize(
  str: string,
  signal?: <T>(a: T) => Signal<T>,
): unknown {
  /* ...snip... */

  const { v, r } = JSON.parse(str, reviver);
  const references = (r ?? []) as [string[], ...string[][]][];
  for (const [targetPath, ...refPaths] of references) {
    const target = targetPath.reduce((o, k) => k === null ? o : o[k], v);
    for (const refPath of refPaths) {
      if (refPath.length === 0) throw new Error("Invalid reference");
      // set the reference to the target object
      const parent = refPath.slice(0, -1).reduce(
        (o, k) => k === null ? o : o[k],
        v,
      );
      parent[refPath[refPath.length - 1]!] = target;
    }
  }
  return v;
}

It is assumed that users cannot directly specify the str parameter of this function. However, this assumption is invalid if users can overwrite the JSON value as described above. Then it is vulnerable to Prototype Pollution attacks because the deserialize function has no check for the attacks.
Suggestions
Similar security risks may exist in other web frameworks using Islands Architecture. However, some of the frameworks I checked seemed realistically difficult to attack for some reasons:

Astro

Astro defines custom elements <astro-island> and renders island components using them.

<EMAIL_ADDRESS>

There are very few cases where users can insert a custom element if the application prevents XSS attacks (e.g. HTML sanitization).

Qwik

Qwik parses JSON values of  and renders island components using it.

https://qwik.builder.io/docs/advanced/qrl/#rendered-html
https://github.com/BuilderIO/qwik/blob/v1.2.14/packages/qwik/src/qwikloader.ts#L31-L45

There are very few cases where users can insert a script element with an arbitrary id attribute if the application prevents XSS attacks (e.g. HTML sanitization).

To make Fresh more secure, I suggest the two measures:

Change the method to get a JSON of __FRSH_STATE,  from document.getElementById("__FRSH_STATE").textContent.

The above framework implementation may be helpful.

Add prototype pollution checks to deserialize.

FYI: Prototype Pollution Prevention - OWASP Cheat Sheet Series

Notes
I created a CTF challenge LemonMD focused on the above considerations. There is a vulnerable application and attackers can perform XSS.
Reproduction steps for the XSS:

Download the source code:

https://github.com/arkark/my-ctf-challenges/tree/main/challenges/202312_SECCON_CTF_2023_Finals/web/lemonmd/build/web

Launch the web server:

docker run -it --rm -p 3000:3000 (docker build -q .)

Access the service (http://localhost:3000).
Render the following markdown text:

{
  "v": {
    "0": [{
      "text":{
        "_f": "s",
        "v": "<img src=0 onerror=\"alert(1)\">"
      }
    }],
    "*": ["onerror"]
  },
  "r": [
    [["*"], ["constructor", "prototype", "*"]]
  ]
}

The alert(1) will be executed by the XSS.

I wrote the description for the challenge and the steps in detail:

https://blog.arkark.dev/2023/12/28/seccon-finals/#web-LemonMD

Thanks for the report. We're looking into this.

Thanks for reporting these issues and the detailed description. We resolved the points with #2256 and #2255 and published a new Fresh patch release.

Thanks for the quick fix and the release!


Aye/Yes Nay/No

Depending on the bill, the senators who voted for it are sometimes given the key 'Yea' and other times 'Aye.' Similarly, 'Nay' and 'No' are both used to indicate the senators who voted against the bill.
It would be nice if this could be standardized, since I would have to put less exceptions in my code, and that would make it more readable. Alternatively, it takes only a few lines to go through the data and do this by hand; but the less data processing done on the users end the better. So, this is low priority but an easy and possibly helpful fix if you think it's appropriate.
(I assume that these don't have some subtle legal difference that would be lost if they were standardized?)

There is a subtle legal difference, in so far as sometimes it's a yea/nay vote and sometimes it's an aye/no vote, but the difference has no practical meaning.
I would be fine with a normalization in the JSON output so long as the XML output is unchanged. See https://github.com/unitedstates/congress/blob/master/tasks/vote_info.py#L130 which performs normalization already in the XML output.


Add method to clear overlay data

At the moment it's possible to clear the overlay data of a slicer by passing an array or zeros but it would be faster to return a list of None. This occurred to me when updating the chest X-ray app where I had to use this mask of zeros to clear the overlay data.

Good point! Would slicer.create_overlay_data(None) work for an API?

Yes, this would be a good solution I think.


input-remapper - ERROR: Request to autoload ... before a user told the service about their session using set_config_dir

Describe the bug
I'm using input-remapper to remap a key combination on my xbox controller (L3 + R3) to ALT-F4 in order to more easily close applications on my HTPC.
Defined input-remapper in my nixos configuration:
  # Enable input-remapper
  services.input-remapper = {
    enable = true;

    ## Enable built-in udev rules for when Xbox Controller is plugged in/connected through sunshine
    enableUdevRules = true;
  };

And set up the rules through the input-remapper-gtk graphical UI. This was working.
However, when rebooting the machine, the rules do not load in and systemctl status input-remapper says that it cannot autoload the rules:
[root@gamer:/home/gamer]# systemctl status input-remapper
● input-remapper.service - Service to inject keycodes without the GUI application
     Loaded: loaded (/etc/systemd/system/input-remapper.service; enabled; preset: enabled)
    Drop-In: /nix/store/nw5zirqqw9kiq03djnkfgdkkxx3i97jx-system-units/input-remapper.service.d
             └─overrides.conf
     Active: active (running) since Sun 2024-04-14 13:05:29 CEST; 38s ago
   Main PID: 1110 (.input-remapper)
         IP: 0B in, 0B out
         IO: 2.5M read, 0B written
      Tasks: 5 (limit: 38257)
     Memory: 31.8M (peak: 32.3M)
        CPU: 215ms
     CGroup: /system.slice/input-remapper.service
             ├─1110 /nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/bin/python3 /nix/store/lfkk1vqblrg36saaa6chivl0w4j7709c-input-remapper-2.0.1/bin/.input-remapper-service-wrapped
             └─1277 /nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/bin/python3 /nix/store/lfkk1vqblrg36saaa6chivl0w4j7709c-input-remapper-2.0.1/bin/.input-remapper-service-wrapped

Apr 14 13:05:29 gamer input-remapper-service[1110]: python-evdev 1.7.0
Apr 14 13:05:29 gamer systemd[1]: Started Service to inject keycodes without the GUI application.
Apr 14 13:05:32 gamer input-remapper-service[1110]: Request to autoload for "Mouse passthrough"
Apr 14 13:05:32 gamer input-remapper-service[1110]: ERROR: Request to autoload "Mouse passthrough" before a user told the service about their session using set_config_dir
Apr 14 13:05:32 gamer input-remapper-service[1110]: Request to autoload for "Mouse passthrough"
Apr 14 13:05:32 gamer input-remapper-service[1110]: ERROR: Request to autoload "Mouse passthrough" before a user told the service about their session using set_config_dir
Apr 14 13:05:32 gamer input-remapper-service[1110]: Request to autoload for "Logitech Wireless Mouse PID:4038"
Apr 14 13:05:32 gamer input-remapper-service[1110]: ERROR: Request to autoload "Logitech Wireless Mouse PID:4038" before a user told the service about their session using set_config_dir
Apr 14 13:05:54 gamer input-remapper-service[1110]: Request to autoload for "Microsoft X-Box 360 pad"
Apr 14 13:05:54 gamer input-remapper-service[1110]: ERROR: Request to autoload "Microsoft X-Box 360 pad" before a user told the service about their session using set_config_dir

If I try to stop and start the input-remapper service, it still gives me the same error. HOWEVER, when I stop the input-remapper service (systemctl stop input-remapper.service) and then start the program manually (with input-remapper-service) then the rules do load in when I connect my controller
[root@gamer:/home/gamer]# input-remapper-service
input-remapper-service 2.0.1 2.0.1 https://github.com/sezanzeb/input-remapper
python-evdev 1.7.0
Loaded config from "/home/gamer/.config/input-remapper-2/config.json"
Request to autoload for "Microsoft X-Box 360 pad"
Found "Sleep Button", "Microsoft Microsoft® Nano Transceiver v2.0", "ASRock LED Controller", "Logitech Wireless Mouse PID:4038", "Mouse passthrough", "Microsoft X-Box 360 pad"
Autoloading for "Microsoft X-Box 360 pad"
Request to start injecting for "Microsoft X-Box 360 pad"
Loading preset from "/home/gamer/.config/input-remapper-2/presets/Microsoft X-Box 360 pad/Quit Application.json"
Starting injecting the preset for "Microsoft X-Box 360 pad"

I am autologging into my gamer account (using services.autologin.user = "gamer"), don't know if that could be the cause of this? However, I find it strange that stopping and starting the service after I've logged in doesn't work, but manually starting the program does...
Steps To Reproduce
Steps to reproduce the behavior:

Set up user autologin with option services.autologin.user = ""; (don't know if this is required to trigger the error)
Set up input-remapper service with services.input-remapper.enable = true; and use udevrules with enableUdevRules = true;
Set up a rule through input-remapper-gtk
Reboot the machine

Expected behavior
I would expect the systemd service to autoload the rules just as it does when I manually start input-remapper-service from the command line
Screenshots
If applicable, add screenshots to help explain your problem.
Notify maintainers

@LunNova
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[root@gamer:/home/gamer]# nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.5, NixOS, 24.05 (Uakari), 24.05.20240410.1042fd8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/r1g09wfd968168f6drdl7agfaf3msik4-source`

Add a :+1: reaction to issues you find important.

The input-remapper remapper service that's part of the system doesn't know which config to use until a user logs in and sets a config folder to use. As far as I can tell this is an intentional design decision for input-remapper, it wants to be multi-user and when you log out and log in as a different user a different config can be loaded.
If you use home-manager something like this works to automate launching the user part of input-remapper on login, assuming your desktop environment supports xdg autostart. This is the upstream supported way to set it up.
  xdg.configFile."autostart/input-mapper-autoload.desktop" = lib.mkIf nixosConfig.services.input-remapper.enable {
    source = "${nixosConfig.services.input-remapper.package}/share/applications/input-remapper-autoload.desktop";
  };

Otherwise, launching the input remapper GUI or adding a systemd user service that loads the user config when you log in should also work.

Thanks @LunNova for the quick response! I've used home-manager in order to run the input-remapper-autoload.desktop file to solve my issue.
I also tried to create an user systemd service that would load the config but there I encountered the same issue as mentioned in my first post, maybe it had to do with autologin... But anyway: doing it through home manager worked.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/input-remapper-not-working-as-expected/44459/2


Improve pagination controls

In the list of deposits for collections, there can often be hundreds of deposits. The list view of all the deposits is paginated. The current UI is confusing because it has an ellipsis that is linked. However, when you click the ellipsis, it takes you to the top of the page, which is unexpected behavior.

A more typical UI pattern is to use the double and single carats. For example:
<<    <   1    2    3   4    5 ... 51   >   >>
Clicking the double carat allows the user to jump forward or backward 10 pages at a time. Clicking the single carat allows the user to jump forward/backward one page. The ellipsis is not linked. Could we consider using this pagination UI pattern? Thank you.

I'm not seeing the linking of the ellipsis, but agree the single and double carats would be helpful.


Remove text on send screen "The receiver pays fees."

https://zpl.io/2yn1MBo
remove from here

Checked


Add jest-abq package.

The jest-abq package will patch various upstream jest packages. We'll need to generate patch sets for every specific version of Jest we want to support. This adds a patch for the latest version of Jest, 29.3.1. I'll follow up by trying to apply to previous Jest versions (that have seen ~1M downloads/week or more in the last week).

Did you try to install jest-abq with yarn and other package managers to see if the postinstall script works with those?

I've tested against npm 8.15.0, yarn 1.22.19, and yarn 3.3.0.


Support list of string values for choiceProperty

Its typical for users to not have values in memory that is not of choice type. e.g. i have a string[] of user.todos in memory but cannot use this list in a choiceprompt directly via choiceProperty because it expects either a List or a string.
We should add support for List to choiceProperty and automatically create a choices list based on that.
if (!string.IsNullOrEmpty(this.ChoicesProperty))
                {
                    if (dc.State.TryGetValue<object>(this.ChoicesProperty, out var choiceValue))
                    {
                        try
                        {
                            if (choiceValue is string)
                            {
                                choices = JsonConvert.DeserializeObject<List<Choice>>(choiceValue.ToString());
                            }
                            else if (choiceValue is List<Choice>)
                            {
                                choices = (List<Choice>)choiceValue;
                            }
                        }
                        catch
                        {

                        }
                    }
                }

@luhan2017, this should be fixed via the input work. Can you please verify and close?


[WIP] update(docs): add overview and versioning sections to falco release.md

Co-authored-by: Leonardo Grasso<EMAIL_ADDRESS>Signed-off-by: Melissa Kilby<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Add more technical clarity to the release doc, see https://github.com/falcosecurity/falco/issues/2195
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
@leogr - started with adding an overview section and as discussed more information around versioning of Falco components. Perhaps we should adjust the old sections to the new style you started for libs https://github.com/falcosecurity/libs/pull/580? Would you want to take care of the next commit and I can then help polish things afterwards? Please feel free to overwrite and improve anything I wrote so far :)
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incertum
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval by writing /assign @fededp in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr - started with adding an overview section and as discussed more information around versioning of Falco components. Perhaps we should adjust the old sections to the new style you started for libs falcosecurity/libs#580? Would you want to take care of the next commit and I can then help polish things afterwards? Please feel free to overwrite and improve anything I wrote so far :)

:+1:
I plan to do that once we have released libs (so we at least can say we have tried it :smile_cat: )

@leogr Added additional details into the doc as suggested. Ok to ask for more polishing commit. After that we can merge and you can edit the rest in a follow up PR.

I guess this PR will remain in WIP until the release, so
/milestone 0.34.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ca63aa90226bca08b492025a4739d6a860d41830

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Program is not compatible with 32 bit systems

Program does not work on 32 bit systems when compiled into an exe via pyinstaller.  Not an issue related to pyinstaller just a compatibility issue that needs addressed with this program.

After gaining more experience and understanding of Python and programming in general, I was able to narrow down a fix.
I recreated the program in a virtual environment using Python 3.8 instead of 3.9/3.10.  I chose 3.8 because it was compatible with Windows 7 Service Pack 1 and the target computers are running that version at the very minimum.  I used a Windows 7 SP1 virtual machine to test the fix it and it worked better than anticipated!


Single source

And I also renamed the redshift distribution to delta_nz to follow the names of the other redshift disrtibutions.

Many many thanks for this PR! I only did a i

Hi @EiffL , I've checked your modifications and optimization, they look great (a lot to learn :) ). But I can't merge the branch, I'm not authorized !

^^' thanks Denise, I'll click the button :-)

@all-contributors please add @dlanzieri for code


Redesign navbar of website to visible it clear

Update Navbar from Transparent to Visible
fixes #10
Updates the navbar from a transparent background to a visible one, improving the overall user experience and readability of the navigation menu.
Changes:
Modified the navbar background from transparent to a visible color, making it more prominent and easier to use.

@Anjaliavv51, I've just  blurred the nav bar to make it more subtle and blend in with the background of the website. I believe this design choice is suitable for the website's overall aesthetic.


TypeError: init() got an unexpected keyword argument 'default_cfg'

When i try to run inference with, for example, Detic_LCOCOI21k_CLIP_R5021k_640b32_4x_ft4x_max-size model i have next error:
TypeError: __init__() got an unexpected keyword argument 'default_cfg'

With Detic_LCOCOI21k_CLIP_SwinB_896b32_4x_ft4x_max-size it works well.
What should i change to run other models?

I think this is because the version of timm is wrong, you can install 0.5.4. I met the same mistake, I  changed the version and it worked.

I think this is because the version of timm is wrong, you can install 0.5.4. I met the same mistake, I changed the version and it worked.

Thank you! It also works for me!


Deprecated gcloud parameter + Typo

gcloud has deprecated the --mode parameter and now the advise is to use --subnet-mode instead.
As per the gcloud documentation (gcloud compute networks create --help):
-mode=NETWORK_TYPE
    (DEPRECATED) The network type.

    mode is deprecated. Please use subnet-mode instead. NETWORK_TYPE must
    be one of:

  auto
    Subnets are created automatically. This is the recommended selection.
  custom
    Create subnets manually.
  legacy
    Create an old style network that has a range and cannot have subnets.
    This is not recommended for new networks.

I also noticed that --mode is deprecated, tried --subnet-mode custom instead but then got prompted with:
Did you mean [global] for network: [kubernetes-the-hard-way] (Y/n)?
What is the answer to this and should the --mode still be specified as well as --bgp-routing-mode ?


Can't override "g d" from godef-jump

I'm not sure if this is a go mode issue, an evil issue, or some issue with how C-c C-j is being translated to evil-mode keybindings, but I'm unable to rebind "g d" to evil-goto-definition or lsp-find-definition.
I've tried local-set-key, bind-key, making my own minor mode and trying to override "g d".
I have godef installed (apparently the latest version), but for some reason I can't get it to work for anything, e.g.:
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104feb5e4]

goroutine 172 [running]:
go/types.(*Checker).handleBailout(0x1400060c400, 0x140002b9c38)
        /opt/homebrew/Cellar/go/1.22.1/libexec/src/go/types/check.go:367 +0x9c
...

This is on OSX but I get the same thing on Arch.
So, I either need to fix godef or rebind "g d" to use the lsp find definition.
I should note, I can bind evil-goto-definition to other stuff like "g D", but this isn't ideal since all other languages use g d to jump to definition.

I've found a workaround: override godef-jump in the go mode hook. I.e., in the hook, redefine godef-jump:
(defun godef-jump ()
    (interactive)
    (lsp-find-definition))


MultipartFormDataParser adds an extra newline to every value.

What steps will reproduce the problem?
Send in a multipart/form-data request using PUT or PATCH (so that MultipartFormDataParser parses it.)
What is the expected result?
The parsed body should be identical to how PHP parses it if you use POST.
What do you get instead?
Every value has an extra newline at the end.
Additional info

Q
A

Yii version
2.0.10

PHP version
5.6

Operating system
Debian 7

Resolved by commit c73de31a9029d8352eeb7344c8cc6c0ffef35a75


Build on Centos7 with Cuda

I'm trying to build from source on Centos 7, gcc 7, conda 4.5, python 3.6, cuda 9.2.
After successfully building and installing as per the readme, I end up getting
ImportError: /n/holylfs/LABS/rush_lab/jc/code/jax/build/jaxlib/_pywrap_xla.so: undefined symbol: _ZNSaIPKN3xla14HloInstructionEEC1Ev
after importing jax, which seems to indicate that that the ffi can't find the xla symbols. I'm new to bazel, so is there something I need to add to my LD_LIBRARY_PATH? Or did I miss a step?

I'm also a newbie at build stuff, but I'm wondering: can you build TF on that setup? We build XLA as part of TF, and TF has a minimum system requirements that might not include this setup.

I'm going to close this issue as inactive, but for anyone who wants to re-open it and follow up: a good first step would be to make sure TF itself can build and run from source on the platform (from googling, it looks like there are discussions on how to build TF on CentOS 7). If that doesn't work, then we likely can't get XLA (or JAX) to build either, since XLA has the same build requirements as TF.
Contributions here are welcome!


Editor crashes while trying to generate docs for a GDExtension class

Tested versions
v4.2.1.stable.official
System information
Godot v4.2.1.stable - Debian GNU/Linux 12 (bookworm) 12 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 580 Series (RADV POLARIS10) () - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
Issue description
The editor crashes on startup while DocTools try to generate information about a property inside custom GDExtension class (if I haven't misinterpreted the backtrace). If the project is started explicitly (with the --path option) then everything works perfectly well and gdscript interprets the property.
The weirdest part is that this very property was handled fine previously. But after I made this GDExtension dependent on another one, it started crashing, and commenting out dependent code did not help.
Steps to reproduce
A simple GraphEdit property added to a godot::Object-derived class that's registered with ClassDB.

void Generator::_bind_methods()
    {
    godot::ClassDB::bind_method(godot::D_METHOD( "set_graph", "graph"), &Generator::set_graph);
    godot::ClassDB::bind_method(godot::D_METHOD( "get_graph"), &Generator::get_graph);
    //ADD_PROPERTY macro is the problem, setget methods work fine on their own and cause no editor crashes
    ADD_PROPERTY(godot::PropertyInfo(godot::Variant::OBJECT, "graph", godot::PROPERTY_HINT_NODE_TYPE, "GraphEdit"), "set_graph", "get_graph");
    }

Minimal reproduction project (MRP)
Verbose log of an appropriate version with the debug symbols enabled.
EditorSettings: Save OK!
Regenerating editor help cache
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.1.stable.custom_build (b09f793f564a6c95dc76acc654b390e68441bd01)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x3c050) [0x7fdf2a7c4050] (??:0)
[2] Variant::Variant(Object const*) (/home/gappy/gamedev/gtext/godot/core/variant/variant.cpp:2612)
[3] VariantTypeConstructor<Object*>::variant_from_type(void*, void*) (/home/gappy/gamedev/gtext/godot/./core/variant/variant_internal.h:1539)
[4] godot::Variant::Variant(godot::Object const*) at /home/gappy/gamedev/gtext/godot-cpp/src/variant/variant.cpp:189 //derived from gdextension library via 'addr2line'
[5] void godot::call_with_variant_args_ret_helper<godot::_gde_UnexistingClass, godot::GraphEdit*>(godot::_gde_UnexistingClass*, godot::GraphEdit* (godot::_gde_UnexistingClass::*)(), godot::Variant const**, godot::Variant&, GDExtensionCallError&, IndexSequence<>) (??:0)
[6] void godot::call_with_variant_args_ret_dv<godot::_gde_UnexistingClass, godot::GraphEdit*>(godot::_gde_UnexistingClass*, godot::GraphEdit* (godot::_gde_UnexistingClass::*)(), void const* const*, int, godot::Variant&, GDExtensionCallError&, std::vector<godot::Variant, std::allocator<godot::Variant> > const&) (??:0)
[7] godot::MethodBindTR<godot::GraphEdit*>::call(void*, void const* const*, long, GDExtensionCallError&) const (??:0)
[8] godot::MethodBind::bind_call(void*, void*, void const* const*, long, void*, GDExtensionCallError*) at /home/gappy/gamedev/gtext/godot-cpp/src/core/method_bind.cpp:99 //derived from gdextension library via 'addr2line'
[9] GDExtensionMethodBind::call(Object*, Variant const**, int, Callable::CallError&) const (/home/gappy/gamedev/gtext/godot/core/extension/gdextension.cpp:213)
[10] ClassDB::get_property(Object*, StringName const&, Variant&) (/home/gappy/gamedev/gtext/godot/core/object/class_db.cpp:1275)
[11] Object::get(StringName const&, bool*) const (/home/gappy/gamedev/gtext/godot/core/object/object.cpp:345)
[12] ClassDB::class_get_default_property_value(StringName const&, StringName const&, bool*) (/home/gappy/gamedev/gtext/godot/core/object/class_db.cpp:1700)
[13] /home/gappy/gamedev/gtext/godot/bin/godot.linuxbsd.editor.dev.x86_64.llvm(+0x6032182) [0x5574c971d182] (/home/gappy/gamedev/gtext/godot/editor/doc_tools.cpp:340)
[14] DocTools::generate(BitField<DocTools::GenerateFlags>) (/home/gappy/gamedev/gtext/godot/editor/doc_tools.cpp:497)
[15] EditorHelp::generate_doc(bool) (/home/gappy/gamedev/gtext/godot/editor/editor_help.cpp:2445)
[16] void call_with_variant_args_static<bool, 0ul>(void (*)(bool), Variant const**, Callable::CallError&, IndexSequence<0ul>) (/home/gappy/gamedev/gtext/godot/./core/variant/binder_common.h:781)
[17] void call_with_variant_args_static_ret<bool>(void (*)(bool), Variant const**, int, Variant&, Callable::CallError&) (/home/gappy/gamedev/gtext/godot/./core/variant/binder_common.h:847)
[18] CallableCustomStaticMethodPointerRet<void, bool>::call(Variant const**, int, Variant&, Callable::CallError&) const (/home/gappy/gamedev/gtext/godot/./core/object/callable_method_pointer.h:285)
[19] Callable::callp(Variant const**, int, Variant&, Callable::CallError&) const (/home/gappy/gamedev/gtext/godot/core/variant/callable.cpp:58)
[20] CallableCustomBind::call(Variant const**, int, Variant&, Callable::CallError&) const (/home/gappy/gamedev/gtext/godot/core/variant/callable_bind.cpp:145)
[21] Callable::callp(Variant const**, int, Variant&, Callable::CallError&) const (/home/gappy/gamedev/gtext/godot/core/variant/callable.cpp:58)
[22] CallQueue::_call_function(Callable const&, Variant const*, int, bool) (/home/gappy/gamedev/gtext/godot/core/object/message_queue.cpp:222)
[23] CallQueue::flush() (/home/gappy/gamedev/gtext/godot/core/object/message_queue.cpp:328)
[24] SceneTree::physics_process(double) (/home/gappy/gamedev/gtext/godot/scene/main/scene_tree.cpp:471)
[25] Main::iteration() (/home/gappy/gamedev/gtext/godot/main/main.cpp:3596)
[26] OS_LinuxBSD::run() (/home/gappy/gamedev/gtext/godot/platform/linuxbsd/os_linuxbsd.cpp:933)
[27] /home/gappy/gamedev/gtext/godot/bin/godot.linuxbsd.editor.dev.x86_64.llvm(main+0x1a0) [0x5574c8330010] (/home/gappy/gamedev/gtext/godot/platform/linuxbsd/godot_linuxbsd.cpp:76)
[28] /lib/x86_64-linux-gnu/libc.so.6(+0x2724a) [0x7fdf2a7af24a] (??:0)
[29] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85) [0x7fdf2a7af305] (??:0)
[30] /home/gappy/gamedev/gtext/godot/bin/godot.linuxbsd.editor.dev.x86_64.llvm(_start+0x21) [0x5574c832fda1] (??:?)
-- END OF BACKTRACE --
================================================================

Can you pleytry this on 4.2.2? Also what version of godot-cpp are you using?

Adding custom classes as member objects to any other custom class crashes the editor on startup. This only happens in the GDExtension library that depends on another, even if the member is defined in the same extension.
class Generator : public godot::Resource
{
    GDCLASS( Generator, godot::Resource )

    godot::Node valid_godot_member_object;
    custom::Editor* valid_gdextension_member_pointer;

    custom::Editor invalid_member_object;
}

Those GDExtensions are compiled and linked with CMake.
target_link_libraries( generator_target
    PUBLIC
    godot-cpp
    antlr4-runtime
    grammar_target
    core_target
)

Is the other library built with the same exact version?

Closing due to lack of response, if you provide the requested information this can be reopened


Fix w3 validation in docs

What are you trying to achieve?
Fix w3 validation
What do you get instead?
https://validator.w3.org/nu/?showsource=yes&doc=https%3A%2F%2Fcodecept.io%2Fui%2F
I will correct

done


Emmet não funciona!

Type: Feature Request
Ao iniciar meu documento HTML 5 quando aperto tab não aparece o formato padrão
<meta...
VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

The "meta" abbreviation works fine for me. Have you changed any Emmet settings?

\gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!


egress.toCIDRSet identities lost causing Policy Drop after Cilium restart

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
After a restart of Cilium, we see egress policy drops for traffic destined to the public internet on a large portion of nodes (>50%).  Comparing cilium bpf policy list dumps from before and after the restart I observe essentially all the cidr entries are missing from the policy.  I'm able to restore the functionality by nudging Cilium to reload the CiliumClusterWideNetworkPolicy from Kubernetes by updating an annotation on the resource (no substantive change; just the annotation -- ex. kubectl annotate ciliumclusterwidenetworkpolicy/default-firewall nudge=true).
I've not been able to reproduce this outside of production which leads me to believe scale is a relevant factor.  I have collected the following info before restart, after restart, and after mitigation. These captures include proprietary info, so please reach out to @ Cody Baker on Cilium slack to request more details or a screenshare.
    cilium debuginfo > $(hostname)-debuginfo
    cilium bpf endpoint list > $(hostname)-bpf-endpoint-list
    cilium bpf ipcache list > $(hostname)-bpf-ipcache-list
    cilium bpf policy list > $(hostname)-bpf-policy-list
    cilium identity list > $(hostname)-identity-list
    (timeout 5s cilium monitor || true) > $(hostname)-cilium-monitor

We see cilium monitor entries referencing the missing identities.
xx drop (Policy denied) flow 0x0 to endpoint 0, ifindex 221, file bpf_lxc.c:1272, , identity 22808->16777699: <IP_ADDRESS>:27124 -> <IP_ADDRESS>:443 tcp SYN
Policy verdict log: flow 0x0 local EP ID 2731, remote ID 16777625, proto 6, egress, action deny, auth: disabled, match none, <IP_ADDRESS>:57070 -> <IP_ADDRESS>:443 tcp SYN
xx drop (Policy denied) flow 0x0 to endpoint 0, ifindex 221, file bpf_lxc.c:1272, , identity 22808->16777625: <IP_ADDRESS>:57070 -> <IP_ADDRESS>:443 tcp SYN
Policy verdict log: flow 0x0 local EP ID 2731, remote ID 16777625, proto 6, egress, action deny, auth: disabled, match none, <IP_ADDRESS>:42491 -> <IP_ADDRESS>:443 tcp SYN

Cilium Version
We've observed this in v1.14.3, v1.14.4, v1.14.5
Kernel Version
6.1.52 Debian Bookworm
Kubernetes Version
v1.28.2
Sysdump
These logs contain proprietary information.  Please reach out to @ Cody Baker in Cilium slack to arrange a screenshare or with a more detailed request so we can sanitize.
Relevant log output
No response
Anything else?
Here's the policy in question.
---
apiVersion: "cilium.io/v2"
kind: CiliumClusterwideNetworkPolicy
metadata:
  name: "apps"
  labels:
    apps-infra: "true"
specs:
- endpointSelector: {} # Default deny for everything
  ingress:
  - {}
  egress:
  - {}
- endpointSelector:
    matchLabels:
      k8s:io.cilium.k8s.namespace.labels.workload: "true"
  ingress:
  - fromEndpoints:
    - matchLabels:
        "k8s:io.kubernetes.pod.namespace": kube-system
        "k8s:k8s-app": kube-dns
  - fromEndpoints:
    - matchLabels:
        "k8s:io.kubernetes.pod.namespace": coredns
        "k8s:app": apps-coredns
  - fromEndpoints:
    - matchLabels:
        "k8s:io.kubernetes.pod.namespace": istio-system
        "k8s:app": istio-ingressgateway
  egress:
  - toEndpoints:
    - matchLabels:
        "k8s:io.kubernetes.pod.namespace": kube-system
        "k8s:k8s-app": kube-dns # The CoreDNS pods have this label for legacy reasons.
    toPorts:
    - ports:
      - port: "53"
  - toEndpoints:
    - matchLabels:
        "k8s:io.kubernetes.pod.namespace": coredns
        "k8s:app": apps-coredns
    toPorts:
    - ports:
      - port: "53"
  - toCIDRSet:
    - cidr: <IP_ADDRESS>/0
      except:
      # https://en.wikipedia.org/wiki/Reserved_IP_addresses
      - <IP_ADDRESS>/12 # RFC 1918
      - <IP_ADDRESS>/8 # RFC 1918
      - <IP_ADDRESS>/16 # RFC 1918
      - <IP_ADDRESS>/16 # Link local - RFC 3927
      - <IP_ADDRESS>/10 # CGN
      - <IP_ADDRESS>/32 # Broadcast
      - <IP_ADDRESS>/24 # https://tools.ietf.org/html/rfc6890
      - <IP_ADDRESS>/24 # https://tools.ietf.org/html/rfc5737
      - <IP_ADDRESS>/15 # https://tools.ietf.org/html/rfc2544

Code of Conduct

[X] I agree to follow this project's Code of Conduct

keep alive

This issue is still very much problematic to us at DigitalOcean. Can we please keep it open? We're happy to collaborate to get a better handle on this one.
/cc @ti-mo


Workaround for https://github.com/FasterXML/jackson-databind/issues/696

Ran across this one when working on Query-time Lookups.
Basically any @JacksonInject annotated items that are part of the query code path will NOT properly inject without this fix.

On second thought, this might better be handled through injection of the GuiceInjectableValues and using that directly instead of resorting to reflection.

Opening new PR with different fix approach


Support for container status

Add support for container status.
@runcom PTAL.

LGTM (just a nit, feel free to merge as is we'll refactor later if needed)


Audit Log Solution does not delete

Describe the bug
Hi @JeneferM-MSFT
I am trying to import a new version of the Audit Log solution in my tenant. The previous version I had was <IP_ADDRESS> and trying to update it to 1.3.5 current version. When I imported the new solution after that it throws the error which is pasted below. In the newer version of the Audit Log solution, there is no custom connector included in the solution.
Component (please tell us which flow or app you are experiencing issues with):

Solution - Audit Logs
Version - 1.3.5

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
Failed deleting solution. Solution dependencies exist, cannot uninstall. DependencyCount : 2 RequiredComponentObject details: Type: connector, ObjectName: Office 365 Management API, Id: de4da0c8-bd02-41df-b0da-bbe0290e8fb4, ParentObjectName: , ParentId: 00000000-0000-0000-0000-000000000000, DependentComponentObject details: Type: Workflow, ObjectName: [Child] Admin | Sync Logs, Id: 751183fc-db68-ea11-a811-000d3a31cf04, ParentObjectName: , ParentId: 00000000-0000-0000-0000-000000000000 RequiredComponentObject details: Type: connector, ObjectName: Office 365 Management API, Id: de4da0c8-bd02-41df-b0da-bbe0290e8fb4, ParentObjectName: , ParentId: 00000000-0000-0000-0000-000000000000, DependentComponentObject details: Type: connectionreference, ObjectName: admin_sharedadmin5foffice2036520management20api5f691c36f6fa56d15c_a4b81, Id: f6af52b4-b07f-465d-b6bc-8b46905b6d58, ParentObjectName: , ParentId: 00000000-0000-0000-0000-000000000000

hello, the custom connector is in the Core components solution.
You will need to upgrade your version of core and then audit log

I have updated my core solution to 1.88 already

I'm afraid I've tested both clean install and upgrade and the custom connector is there for me. You seem to have gotten into a strange state. You may need to re-install into a clean envt to get to a good state.
Sorry that we cannot be of more assistance.


[#875] support latest version of Spark 3.2.0

Purpose of this pull request
Updated spark version to 3.2.0
Close #875
Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] Change does not need document change, or I will submit document change to https://github.com/apache/incubator-seatunnel-website later

PTAL @garyelephant

PTAL @garyelephant @CalvinKirs

HI, we'd better discuss in #875. In #875, I have the same questions as you.

no updates, if you have any updates, you can leave a message, and I will reopen it.


[StdLib] Refactor ObjC dependencies in ArrayTraps test

This change moves functionality that requires ObjC interop into a new file and removes the XFAIL on Linux. Partially resolves SR-216.
--
This is tested on Ubuntu 14.04 and OS X 10.10.
As an aside, I've moved any tests that use array downcasting into the ObjC file because it's only supported there. Attempting to downcast an array crashes the compiler on Linux. SR-236 covers the compiler crash and rdar://problem/18881196 covers getting the array functions for downcasting ported to non-objc platforms.
(Edited to reflect new understanding)

I've updated the code so that all the tests requiring the Objective-C runtime has been moved to a separate file. I've also removed the XFAIL on linux and edited the commentary above because I better understand why array downcasting fails.
This PR is ready for merging or for new feedback.

Good. Thanks!


bump-formula-pr: return to starting branch

After branching, bumping, pushing, and pr-ing; return to whatever branch
was originally checked out.
In most cases, I'd imagine users to want to continue receiving tap
updates from master. However, after using bump-formula-pr, the tap in
which the formula was bumped is left on the working branch that was
doing the bumping and pull-request. After opening the PR, we should
return to whatever branch the user originally had checked out – most
likely master. (But git allows us to just say "previous branch" by using
-)

This makes a lot of sense to me, but would prefer @ilovezfs as the most prominent user of this developer command to chime in and comment on this, too.

e9da9f0d (ilovezfs         2016-07-06 05:00:45 -0700 218)         safe_system "git", "checkout", "-"

Thanks for your contribution and this tweak to the bump-formula-pr command, @jasonkarns! :tada:


Handle Incomplete Sequence numbers in missing transmission report

If the MTU size(-headers) is less than 183, there is a chance of incomplete sequence number in the transmission report in case of higher failure of chunks. In such scenario ignore any incomplete sequence number.
Scenario:
MTU negotiated: 185 [182 (-3 for headers)]
No of missed chunks: 95
Transfer Report Packet:
First Byte: Success/ Failure
Next 2 bytes: page numbers
No of bytes needed for representing each sequence number: 2 bytes
Remaining bytes: 179 bytes which can hold max of 89 sequence numbers
Current implementation will write first 90 sequence numbers in the characteristics which is 180 bytes. The last byte will get dropped as max available space is 179 bytes.
When the wallet tries to convert the bytes into Transfer Report back, the last sequence number will not be converted and throw an exception.
Example:
Data to be written by verifier:
00 | 00 95 | 00 01 | 00 34 | ....................... | 00 68 | 00 99
Data received by the wallet :
00 | 00 95 | 00 01 | 00 34 | ....................... | 00 68 | 00
Since the last sequence number is incomplete, it will cause error.
To be done:
Drop the entire last sequence number and then process the request:
00 | 00 95 | 00 01 | 00 34 | ....................... | 00 68

The following PRs implements handling of incomplete sequence number in the transmission report. It ignores the last sequence nuber if it is incomplete.
PR for mosip/tuvali: #28
PR for mosip/inji: #595, #597
The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee8200


drkit instructions

hi
i'm really interested in using drkit. i realize the repo is in the labs section, which comes with caveats. is it possible to get a set of minimal reproducible steps? the demo of the paper is really fascinating and it'd be great to be able to try using the codebase on a virtual kb.

Yeah would love to know this too. Is there a pre-trained model we could use? If not, would love steps to reproduce.

commenting for visibility - same here

https://open-csr.github.io//methods/


FABB-73: Add error handling for Jira getIssue 404

Suppose you do not have permissions to access a particular Jira issue. Then, the Jira getIssue request gives you a 404.
Right now, we're mapping this to 500 errors in associateEntity. However, since this is an expected case, this PR tweaks the error handling to map these to 404 errors in the endpoint.
Ticket: https://figlassian.atlassian.net/browse/FABB-73

@elainefigma , we have investigated the root cause of this issue. I've added more detail on our finding in Slack and created another PR with the fix:
https://github.com/atlassian-labs/figma-for-jira/pull/218


Can't create new Reference to Model DataType

Description
When creating a Reference to Model DataType, no model selection box/menu appears.
Steps to reproduce

Create a new DataType in a DataModel and select 'Reference to Model'
No option to select a referenced Model appears

Screenshots

Environment
Latest develop of mdm-ui and mdm-core
Desktop
macOS Safari

Was also present on develop before PR#836, but appeared slightly differently.


Ros1 manager bt create basic trees

As discussed, changes and detailed review of shutdown_host_node will be a part of another task and PR


Prototype DevWorkspace as dependency for WTO and CRW

This is about prototyping DevWorkspace Operator as a dependency for WTO and CRW(Che).
In the scope of this issue it's needed to:

prepare scripts to generate manifests where DWO is a dependency for WTO and CRW;
prepare script to generate newer versions for DWO, CRW, WTO to test updating;
Move web-terminal stuff out from DWO;

More details about plan can be found at https://docs.google.com/document/d/1-6B1qdizqu-fI8SDwZ0sZslmepN7zQWw7fxrU4Ug35Y/edit#heading=h.778lsysexnzr

Prototyping is actually done.
DWO got OLM changes, WTO got changes to depend on DWO as olm dependency.
Polishing and figuring out answers to open questions should be done in dedicated issues:

[ ] Productize DWO (devworkspace-controller) wrapped with its own operator + metadata & publish to RHEC https://issues.redhat.com/browse/CRW-1730
[ ] Adapt WTO to depends on DWO as olm dependency https://issues.redhat.com/browse/WTO-101


Cookie-like functionality for plugins

Plugins may have a need to obtain and make use of information that is external to octant, for example, a database connection, or the location of a particular directory or some other configuration information. It is wasteful and potentially problematic for each plugin to separately derive this information, especially if the information takes a while to calculate or needs to change and be shared among plugins.
One possible way to handle this situation is to handle this like browser cookies. Namely, permit a plugin to provide (and return) a small blob of data (say, 4K or less) to octant , which then supplies back to the plugin when it is called.  Like browser cookies, the data in this blob could probably be restricted to text or json, and not have to be parsed or processed in any way by octant, but just passed back and forth.
For security and separation between plugins, normally octant would only supply a particular blob back to the same plugin that supplied it. To permit sharing between plugins, a simple CORS-like field could be added to indicate which other plugins are permitted to receive the data

I am leaning towards solving this with convention. I think it is not unreasonable to have users copy a plugin.conf.json file (or what ever conf file) to the same folder they must copy/install the plugin in to. Or to have plugins expect an extra set of environment variables to be set.
Also, the data in Octant is currently ephemeral and does not get persisted between restarts. Octant having to manage and persist a cookie file / object store for plugin data as well as maintain a list of what plugins are allowed to access that data,  and then do that across versions of Octant is something that we probably want to avoid. That is adding an entirely new API for plugins around data storage that would need to be versioned an maintained.
An example of how you might do this now:

Plugin supports IsModule
Add a * handler initPlugin method that looks for and verifies a file on disk
If found, pass the request to the normal route handler
If not found, create a content response that provides a user with setup forms / actions.
Have the setup action handler create the configuration file.


orange-book:0.3.0

I am submitting

[ ] a new package
[x] an update for a package

Migrate template to Typst 0.12.0 and minor fixes.

[X] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thanks!


Added feature to run Maistra web site in a local container.

Extended make file to run Maistra website in a local container, so that contributors don't need to install Hugo and its dependencies on their computer.

/ok-to-test

Hi @olaf-meyer! Thanks for the contribution, makes a lot of sense. We already have an image you can use though, it's the one that our CI uses: quay.io/maistra-dev/maistra-builder:2.0 - so you don't have to include a Dockerfile in your PR

Hi @dgn, do you know where I can find the source code for the quay.io/maistra-dev/maistra-builder:2.0? I would like to add a link to this project in the make file, so that it is clear what the content of the docker file is.

Hi @dgn, do you know where I can find the source code for the quay.io/maistra-dev/maistra-builder:2.0? I would like to add a link to this project in the make file, so that it is clear what the content of the docker file is.

Sure, it's here: https://github.com/maistra/test-infra/blob/main/docker/maistra-builder_2.0.Dockerfile

Hello, I tried to fix the problems with the check-links and the linting. When I try to run the images quay.io/maistra-dev/maistra-builder:2.1 or quay.io/maistra-dev/maistra-builder:2.0. I get this error message ./tools/checkLinks.sh: line 7: yq: command not found. Is the ci build that is using these images working for you?

Hello, I tried to fix the problems with the check-links and the linting. When I try to run the images quay.io/maistra-dev/maistra-builder:2.1 or quay.io/maistra-dev/maistra-builder:2.0. I get this error message ./tools/checkLinks.sh: line 7: yq: command not found. Is the ci build that is using these images working for you?

hey @olaf-meyer, those problems should have been resolved by https://github.com/maistra/maistra.github.io/pull/174 - you just have to rebase. Sorry for the churn

hey @olaf-meyer, those problems should have been resolved by https://github.com/maistra/maistra.github.io/pull/174 - you just have to rebase. Sorry for the churn

Okay, I clicked the button and let GitHub merge the maistra-2.0 branch into yours again. It should pass now

Okay, I clicked the button and let GitHub merge the maistra-2.0 branch into yours again. It should pass now

Sorry for the delay. I was quite busy the last weeks.

Sorry for the delay. I was quite busy the last weeks.

Sorry for the delay. I was quite busy the last weeks.

No worries at all. Thank you for your perseverance :slightly_smiling_face:

Sorry for the delay. I was quite busy the last weeks.

No worries at all. Thank you for your perseverance :slightly_smiling_face:


gtk.TreeStore: Unable to store gdk.Pixbuf objects

The attempt to store (and view) gdk.Pixbuf objects in a gtk.TreeStore leads to warning messages from the GTK library: Gtk-WARNING **: /build/buildd/gtk+3.0-3.14.13/./gtk/gtktreestore.c:856: Unable to convert from gpointer to GObject, and the icons are not drawn. Note: using a gtk.ListStore does not have this issue.
I will provide a (almost trivial) fix.

sorry for you merge request, I'm just gone linear through RP and someone was faster.


Deploy --remote unable to read Harbor registry when given Administrator Credentials

I'm trying to perform an on-cluster build for a brand new function using:
kn func deploy --remote --registry=harbor-core.harbor.svc.cluster.local/repository Username=admin Password=<admin password>
The initial credential check of the registry succeeds.  During the build, I receive the following error:
ERROR: failed to initialize analyzer: validating registry read access: ensure registry read access to harbor-core.harbor.svc.cluster.local/project/function:latest
What I have tried so far:

Adding registry credentials for Tekton using the 'tekton.dev/docker-0: https://harbor-core.harbor.svc.cluster.local' annotation as well as 'tekton.dev/docker-0: https://harbor-core.harbor.svc.cluster.local/project'.  Still receiving the same error.
Using a different administrator account.  Still receiving the same error.
Using the external domain name for reaching the repository from outside the cluster.  Still receiving the same error.
Creating CoreDNS rewrites to ensure that the internal cluster requests are going to the correct Kubernetes service
Creating an Istio VirtualService to ensure traffic is routed to the appropriate service based on the URI

Additional Info:
I was looking at the Tekton Pipeline to make sure it was using the proper credentials that are provided.  When looking at the Kubernetes Secret that the pipeline creates I noticed that the server does not include the project directory:
{   "auths":     {       "harbor-core.harbor.svc.cluster.local":  {         "username" : "admin",         "password":"<password>",         "auth":"<auth>"       }     }  }
When using busybox to curl the harbor registry I'm able to retrieve a list of the project/repositories:
curl -X GET -u "admin:<password>" http://harbor-core.harbor.svc.cluster.local/v2/_catalog
returns
{"repositories":["public/function"]}
Any sort of help or additional things to look at in order to get this working would be highly appreciated.
Thanks!
Edit:
I also wanted to mention that I am able to use "kn func build --push --registry=harbor.domain/project" to locally build the function and push to the repository with the Harbor admin credentials.
Edit 2:
I noticed that the Tekton PipelineRuns template that is created also Creates a secret "function-pack-git-pipeline-secret" and is an Opaque type.  I'm wondering if the problem might be that it is not of type "kubernetes.io/dockerconfigjson" per https://tekton.dev/docs/pipelines/auth/#basic-auth-for-docker?

@HanBrol0 is this reproducible with some other registry?

I noticed that the server does not include the project directory.

I believe this is expected: docker config has credentials per registry not per repository/namespace.

Did you use s2i or pack builder?

Do you use podman or docker?

@HanBrol0 is this reproducible with some other registry?

I noticed that the server does not include the project directory.

I believe this is expected: docker config has credentials per registry not per repository/namespace.

Ok, thank you for the clarification. I've been at this for a while and I think I've just started grasping at straws.

Do you use podman or docker?

When using my local builds, it's docker.  The remote builds are the default templates created by the 'knative func' command which I believe is Kaniko.

Did you use s2i or pack builder?

I see you are using pack builder. Could you please try s2i build strategy --builder=s2i?

So at the moment, it's been as many defaults as possible to help improve my understanding of a lot of things.
I just ran the build with the --builder=s2i command and received the following:
Getting image source signatures
Checking if image destination supports signatures
Copying blob sha256:834f52236467e6bec0d40ab7f867f4fd18f3be8087ba8caa06823c6d7f1f28f2
Copying blob sha256:8ee5f1e863ab9d2a5c9741aa4954fd8be5fa515465efdc38cb4e15808b58010e
Copying blob sha256:c2650fe947f606317fadb11c65aae44ee7b8ebd7c245a639d3521ce7a8d4544f
Copying blob sha256:50ccdb01751aeb08fdb4bb077afe0f302149e1fb82242159e5787372a750d3c1
time="2024-02-01T20:00:40Z" level=error msg="While applying layer: ApplyLayer stdout:  stderr: remount /, flags: 0x44000: permission denied exit status 1"
Error: creating build container: copying system image from manifest list: writing blob: adding layer with blob "sha256:c2650fe947f606317fadb11c65aae44ee7b8ebd7c245a639d3521ce7a8d4544f": ApplyLayer stdout:  stderr: remount /, flags: 0x44000: permission denied exit status 1

Step failed

@HanBrol0 this is weird, does docker push work all right?

@matejvasek
Yes, docker push can push to both a new and existing repository.

what if you try using pack CLI directly
pack build harbor-core.harbor.svc.cluster.local/project/function:latest -Bghcr.io/knative/builder-jammy-tiny:latest --trust-builder --publish

https://github.com/buildpacks/pack

And what about func local build func deploy does that work?

@matejvasek
The following did not work:
pack build harbor-core.harbor.svc.cluster.local/project/function:latest -Bghcr.io/knative/builder-jammy-tiny:latest --trust-builder --publish
However, it did work once I changed the domain to the external address, which make sense since the build is outside the cluster:
pack build harbor.domain/project/function:latest -Bghcr.io/knative/builder-jammy-tiny:latest --trust-builder --publish
Both of the following pass the analyzing stage and successfully pushes the function to the registry:
func deploy --builder=[s2i|pack]

@HanBrol0 did you debug this yourself any further, any results? It's hard for me to fix this since I cannot reproduce this.

@matejvasek I'm still working on it.  Based on the last set of commands, I'm thinking it might be related to some sort of service resolution within the cluster.  I'm just looking for ways to prove that at the moment.

@matejvasek
Just wanted to give you a heads up:
Last night, I changed my infrastructure so that my Harbor registry is running on a separate machine, and not as a Kubernetes services within the cluster.  After doing this, the analyze stage was able to complete successfully, though it did require retrieving a valid certificate for the deployment to succeed.
I will go back eventually to attempt to utilize Harbor within my cluster, but for now I am satisfied and look forward to building Knative functions.
Thanks for your assistance!


How to install containerd with alpine-lima

It's not fully clear how to add containerd to alpine, since the scripts require systemd:
ERRO[0018] [1 error occurred:
	* failed to satisfy the optional requirement 1 of 2 "systemd must be available": systemd is required to run containerd, but does not seem to be available.
Make sure that you use an image that supports systemd. If you do not want to run
containerd, please make sure that both 'container.system' and 'containerd.user'
are set to 'false' in the config file.

Installing containerd is quite simple, but packages for "nerdctl" and "buildkit" are missing...
provision:
  - mode: system
    script: |
      #!/bin/bash
      set -eux -o pipefail
      command -v containerd >/dev/null 2>&1 && exit 0
      apk add runc containerd cni-plugins
      sudo rc-update add containerd default
      sudo service containerd start

They can be added from the tarballs, but there doesn't seem to be any support available ?
That is, the current support is for nerdctl-full only (and not for nerdctl and buildkit archives)

Would it be better to make custom aports, or perhaps to add support for extra archives ?
containerd

https://github.com/containerd/containerd/archive/v1.5.8.tar.gz
https://github.com/alpinelinux/aports/tree/3.14-stable/community/containerd

nerdctl

nerdctl-0.15.0-linux-amd64.tar.gz
nerdctl-0.15.0-linux-arm64.tar.gz

buildkit

buildkit-v0.9.3.linux-amd64.tar.gz
buildkit-v0.9.3.linux-arm64.tar.gz
buildkit.confd
buildkit.initd

Both lima sudo nerdctl run and lima sudo nerdctl build seem to be doing just fine...
init-+-acpid
     |-7*[getty]
     |-sshd.pam---sshd.pam---sshd.pam-+-pstree
     |                                `-2*[sshfs---3*[{sshfs}]]
     |-supervise-daemo---lima-guestagent---7*[{lima-guestagent}]
     |-supervise-daemo---containerd---10*[{containerd}]
     |-supervise-daemo---buildkitd---8*[{buildkitd}]
     |-syslogd
     |-udevd
     `-udhcpc

There is some minimal support for adding nerdctl and buildkit from the nerdctl-full tarball in the image builder. It is used by the rd edition (Rancher Desktop), but does not include the openrc script to run buildkitd. It is trivial to define additional "editions" by creating a config file in the edition/ subdirectory.

Forgot to add: the rd edition does not include containerd because we use the version bundled with k3s.

Okay, so the same tarballs as above would work (or the full download) - just have to be done in the image builder.
I couldn't find any existing APKBUILD, but then again there doesn't seem to be any .deb or .rpm available either...

I guess it needs some kind of "nerdctl" edition then, and then use that in the example instead of the "std" edition ?
https://github.com/lima-vm/alpine-lima#editions

Added issue:

https://github.com/lima-vm/alpine-lima/issues/34

If that is done, there is no need to make packages.

I guess it needs some kind of "nerdctl" edition then, and then use that in the example instead of the "std" edition ?

It is not clear to me why this shouldn't just go into the std edition, which is the version that examples/lima.yaml is supposed to use. Is there a reason we need a separate edition for this?

Is there a reason we need a separate edition for this?

I thought you wanted to avoid having containerd in std, so that it can be installed by lima or k3s ?

I thought you wanted to avoid having containerd in std, so that it can be installed by lima (at runtime) or k3s ?

I don't want it to run automatically, but I think having it pre-installed, together with the required initd scripts would be fine.
I'll reserve final judgement when I know how much it adds to the size of the ISO. 😄
A long time ago I was contemplating to extend the rootless setup script to be able to create openrc scripts in addition to systemd units. But I didn't really needed it, so it is kind of low on my todo pile...

I'll reserve final judgement when I know how much it adds to the size of the ISO. smile

It seems the ISO is around 100 MB, so that makes it 1500 MB smaller than the "default"

But from what I can tell, the previous build was 50 MB so maybe worth leaving out then ?

Maybe, but what is the use case for the std edition if it is no longer the standard version for Lima?

Also not having to include nerdctl-full does make the cidata.iso a lot smaller, if that counts.

Maybe; I'll have to think about this some more. IIRC @AkihiroSuda was somewhat opposed to bundling nerdctl with the ISO image, and prefers that it is always installed by lima. Which has the advantage of being able to update nerdctl without releasing a new iso. (The use case is different for Rancher Desktop, where you cannot upgrade lima, qemu, nerdctl etc. independent of RD anyways).

Well, it does work - as long as you don't want to run containers on it ? Then it needs more software.

A long time ago I was contemplating to extend the rootless setup script to be able to create openrc scripts in addition to systemd units. But I didn't really needed it, so it is kind of low on my todo pile...

It would be perfectly fine if rootless continued to fail, it was just for installing the daemons for use with sudo.
And installing from nerdctl/buildkit instead of nerdctl-full would be a nice feature, but it is not required either.
9,7M	nerdctl-0.15.0-linux-amd64.tar.gz
46M	buildkit-v0.9.3.linux-amd64.tar.gz

193M	nerdctl-full-0.15.0-linux-amd64.tar.gz

Since alpine uses a different C library, only static binaries will work. The dynamic ones have glibc dependencies.

The buildkitd binary doesn't have glibc dependencies; we use the version from the nerdctl-full tarball (installed in the rd edition of the ISO) with Rancher Desktop, and it seems to work fine: https://github.com/rancher-sandbox/rancher-desktop/pull/1182

Forgot to add: the rd edition does not include containerd because we use the version bundled with k3s.

This is actually not correct; the apk version of containerd is pulled in by docker-engine, but we don't actually use it (so far, it will be handy to run containerd/nerdctl without k3s in the future).

There could be other reasons too, like the static tarball also bundles runc and qemu (already present in alpine)

There could be other reasons too, like the static tarball also bundles runc and qemu (already present in alpine)

Not sure what you are trying to say; buildctl and buildkitd as well as a subset of the CNI plugins are all that we copy right now: https://github.com/lima-vm/alpine-lima/blob/v0.2.3/genapkovl-lima.sh#L214-L222

I mean there could be other reasons from installing buildkit from an apk, sorry for being vague.

This is kind of off-topic here, but the nerdctl-full distribution could be shrunk down a lot by stripping binaries and converting them to multi-call binaries, like busybox. Compare the k3s cni plugins:
lrwxrwxrwx 1 0 0    3 Aug 19 19:10 bridge -> cni
-rwxr-xr-x 1 0 0 3.1M Aug 19 19:09 cni
lrwxrwxrwx 1 0 0    3 Aug 19 19:10 flannel -> cni
lrwxrwxrwx 1 0 0    3 Aug 19 19:10 host-local -> cni
lrwxrwxrwx 1 0 0    3 Aug 19 19:10 loopback -> cni
lrwxrwxrwx 1 0 0    3 Aug 19 19:10 portmap -> cni

with the versions from (an older) nerdctl-full tarball (which was missing flannel):
-rwxr-xr-x  1 jan  staff   4.2M 11 Aug 08:46 bridge
-rwxr-xr-x  1 jan  staff   3.2M 11 Aug 08:46 host-local
-rwxr-xr-x  1 jan  staff   3.3M 11 Aug 08:46 loopback
-rwxr-xr-x  1 jan  staff   3.7M 11 Aug 08:46 portmap

There are a lot more cni plugins in the tarball, so the savings would add up, but I'm not sure if it is worth the effort.

I divided the CNI plugins into different packages, but I'm not sure it was worth the hassle.
Seemed like a good idea at first, and then I had to redo the split when things changed...

And the nerdctl-full download is fine (I wish that Podman had it, makes adoption much easier), just that it is also nice to be able to use apk add (or apt install) to install BuildKit instead of mucking about with architectures and versions and such.

They are available as packages now, and a year has passed. The "alpine" image will still be bare bones.


separate topology and federation testing from main test script

The topology and federation options were cluttering up the main test file and did not allow for as much flexibility as may be needed in the future for these types of tests which would further diverge the different code paths.

i like it all.

Right on


switch GCR -> Artifact-Registry

GCR has been deprecated [0] in favour of Artifact-Registry.
Thus, change push-targets for OCI-Images:

europe-docker.pkg.dev/gardener-project/snapshots for snapshots
europe-docker.pkg.dev/gardener-project/releases for releases
europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

Note that I did not adjust mentionings of .*gcr.io.* in what looked to me like mostly test-modules (pkg/.*), assuming such changes are not required for the changing publishing-targets.
[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
Release note:
Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

related to https://github.com/gardener/ci-infra/pull/1067

bump


ValidationSupport to throw specific Exceptions

I think I can store the validation class name in the field attribute

Why do you need the validation class name?

I thought of using the name of the class instead of using random strings, but given that the vaadin module does not have dependency of business-impl and cannot see the validators classes, I will use the following strings:

creation
deletion
update

Originally posted by @ngonzalezpazFC in https://github.com/AppJars/commons-backend/issues/37#issuecomment-889075848
The comment quoted is related to this issue. I was thinking that each kind of CRUD validation could throw a specific exception, i.e CreationValidationException, UpdateValidationException, so as the presentation layer can display a more specific  message, or in my case to configure ErrorWindowAddon to show a specific message once it catches each Exception type, instead of a generic ValidationException message.

It seems a good idea. There are not many places in commons-backend where we throw that exception.


Modify TODO to NOTE on Makefile

'# TODO: see 'install' target.' (line 655) should be a note rather than something
to do.

@catmanl Thanks for the review!


react-router-redux: (v5) action CALL_HISTORY_METHOD does not called when  clicked

Version
react-router latest
react-router-redux next
Steps to reproduce
Click onto react-router Link
Expected Behavior
I expect {type: CALL_HISTORY_METHOD, method: 'push'} action will be fired

It's not code error

Link doesn't use the action creators. This is expected behavior.

Thank you,
I know it's expected now by code. But what is it operate like this?
My position, react-router-redux should provide <Link/> with implicit action creator and dispatch runner.

Because the action creators are optional and just a convenience to get access to the history instance. You shouldn't be relying on that action type for any reason, as it's imperative. Instead, rely on the declarative nature of state and react to changes to the state tree when the location changes.


feat: add method for blocking until shutdown is complete

This feature introduces a Program.Done() method which will block until a Program has completely exited. This is useful when you want to wait until Bubble Tea has completely restored the terminal before printing output elsewhere in your Go application.
In particular, this feature can help prevent race conditions where Bubble Tea and other output are attempting to print to the terminal at the same time.
Consider the following:
// Draw a spinner
go func() {
	if _, err := p.Run(); err != nil {
		fmt.Println("Uh oh:", err)
		return
	}
}()

result := someLongRunningOperation()

p.Quit()   // stop the spinner
<-p.Done() // wait for cleanup

// Print safely.
fmt.Println("Okay, so the results are in:", result)

It may also make sense to include a convenience function which combines Program.Quit and Program.Done. Potentially named Program.Shutdown()?

Closing in favor of #722, which has a much nicer API!


Phenograph supporting Leiden clustering

An updated new release of PhenoGraph package now supports Leiden algorithm for community detection. The suggested changes in scanpy/external/tl/_phenograph.py will make the new updates visible in Scanpy as well. Also, the suggested changes include a testing function in scanpy/tests/external/test_phenograph.py, and updated docs.

Hi @flying-sheep ,
Please review and let me know if anything needs to be done here.
Thank you

@awnimo , for me test_phenograph.py fails with E   TypeError: Expected list, got numpy.ndarray.
Could you check please?
This is certainly related to scipy 1.5. With scipy 1.4 the test works fine.

@awnimo , for me test_phenograph.py fails with E TypeError: Expected list, got numpy.ndarray.
Could you check please?
This is certainly related to scipy 1.5. With scipy 1.4 the test works fine.

Indeed, this error is related to scipy, and we have fixed that in Phenograph new release 1.5.7.
The test_phenograph.py does not fail with the new Phenograph release (pip install -U phenograph)

@awnimo ok, i see, thanks.
Also for some reason this pr deletes docs/api/scanpy.external.rst

@Koncopd
This is weird never noticed. How can I restore it??
I only built the docs for me to test the outputs. Could be that building the docs affected somehow docs/api/scanpy.external.rst??

@awnimo i'm not sure how to restore it, there were so many commits so git reset won't help.
Hm, you can try copying this file back and commiting.

@Koncopd
I added back docs/api/scanpy.external.rst.


I can't run codes anymore.

Type: Bug
The problem is:
I can't run any Python code. Ctrl+f5 doesn't work, the run button doesn't do anything. The terminal just won't show anything.
I have tried:
Reinstalling Python, resetting and reinstalling Visual Studio Code, restarting windows. VSC
worked until yesterday, I still have the extensions installed. Also, the code runs on the standard Python IDLE.

VS Code version: Code 1.70.2 (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:35:13.448Z)
OS version: Windows_NT x64 10.0.19044
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 2400G with Radeon Vega Graphics     (8 x 3593)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
13.93GB (10.46GB free)

Process Argv
--crash-reporter-id bfceb29d-1952-483e-8e83-637cb1848015

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

c-cpp-runner
fra
4.0.3

vscode-language-pack-it
MS-
1.70.8170916

python
ms-
2022.12.1

vscode-pylance
ms-
2022.8.30

jupyter
ms-
2022.7.1102252217

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.9

cmake-tools
ms-
1.11.26

cpptools
ms-
1.11.5

cpptools-extension-pack
ms-
1.2.0

cmake
twx
0.0.17

vscode-lldb
vad
1.7.4

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
wslgetstarted:30449410
cppdebug:30492333
pylanb8912:30545647
vsclangdf:30486550
c4g48928:30535728
hb751961:30543456
dsvsc012cf:30540253
azure-dev_surveyone:30548225

Could you please provide the information about what you did before VSCode stopped working?
Maybe this will help to narrow down the issue.

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Fixed #201

…IELDSETS

Added validation check to fix #201

What about this?? What is the version of django-constance with these fixes?? I don't see any new release since February 17....

Thank you.


Packaging for apps

Package Format
A psibase package is a zip archive which contains the following files:

meta.json
service/<service>.wasm
service/<service>.json
data/<service>/*
script/postinstall.json

All files except meta.json are optional. A package may contain more than one service.
I chose zip over tar for 2 reasons:

jszip appears more complete and better maintained than any of javascript tar readers
zip compresses files separately, which makes it easier to extract just meta.json for the UI

Features in this PR

[x] Build packages with cmake
[x] Packages are installed in the correct location in the build directory
[x] Packages are installed in the correct location in the install tree
[x] psibase boot <packages> uses packaged services from <prefix>/share/psibase/services
[x] Meta-package Default that has no content but depends on all services that should be installed by default
[x] psibase boot with no packages specified uses Default rather than trying to boot with nothing
[x] Packages available from admin-sys
[x] Admin panel boot loads services over HTTP
[ ] Admin panel boot can upload packages from the local filesystem
[ ] psibase option to specify one or more package repositories
[ ] psibase can take package files on the command line
[ ] psibase deploy (or perhaps a new subcommand) can accept a package to install or update a package on a running chain
[x] Add scripts to build and submit arbitrary transactions, so that the initial token users can be defined in a package
[ ] C++ psidk can build packages
[ ] cargo psibase can build packages

If there are any actions that need to be called on or by a service after installation, then an init action should be used. Therefore at first I was thinking that a post-install script is redundant. But I think a post-install script could still be useful for an optional post-install procedure? So different people could use a different post-install procedure for the same package, and you could know (via comparing the hash of the service in each case) that the service was identical and only the post-install script has changed... I guess that's useful? Am I missing another reason why post-install is helpful?

Also, I think that you should add something to the specification docs as part of this PR

If there are any actions that need to be called on or by a service after installation, then an init action should be used. Therefore at first I was thinking that a post-install script is redundant. But I think a post-install script could still be useful for an optional post-install procedure? So different people could use a different post-install procedure for the same package, and you could know (via comparing the hash of the service in each case) that the service was identical and only the post-install script has changed... I guess that's useful? Am I missing another reason why post-install is helpful?

There are a few reasons why an init action is insufficient:

Additional authorization beyond the service account may be needed
The account might not have a wasm at all


Adds dotnet Stocks Update Notification Bot sample

Merging the PR will add a dotnet variant of the Stocks Update Notification Bot sample.

Thank you for your comments @HuihuiWu-Microsoft and @JerryYangKai, also apologies for the delay in getting back to you. I have resolved the comments, this PR is ready for a second review.


Read XML Missing Coupon Description

I added the following in order to get it to work:
                case "description":
                    HostedDescription = reader.ReadElementContentAsString();
                    break;

Took care of this in https://github.com/recurly/recurly-client-net/pull/111


Prevent Thread.Abort tryout3: event

@304NotModified I here is what I was thinking for the removal of the Thread.Abort.
I had to call fileTarget.Dispose in 2 of the unit tests to so that the file handle would be freed up. I don't know if this is an issue or not.
fixes #1415

superseded by https://github.com/NLog/NLog/pull/1444


lower case epithets on import

Reptile DB example with capital epithets:
https://dev.col.plus/dataset/1008/name/Rep-S-23146
They are like that originally:
http://reptile-database.reptarium.cz/species?genus=Potamites&species=strangulatus
but get lower cased in the current CoL:
http://www.catalogueoflife.org/col/details/species/id/424b977fc847e5b36cd0c65ef3dd00f1/synonym/847fb499e33b08284f932fdcf22de0b5
Desired for both accepted names and synonyms would be to lower case all single word epithets without brackets and raise an issue that the names epithet was lower cased.
Editorial reviewed decision can then be applied to verify the correct behavior and to check that it's not a subgenus (without parentheses
and missing a species epithet).

https://github.com/Sp2000/colplus-backend/commit/f233bc9fc5d72a56082776b2f755efd090445226


Fix a few typos

Please describe the changes this PR makes and why it should be merged:
Fix a few typos in the readme
Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[x] This PR only includes non-code changes, like changes to documentation, README, etc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make the download button point to a downloadable document or else

After a few complains about that, I think it's time to make it more clear.
The idea would be to link the "download" button to a plain text file ( raw file ? ) or just directly starting a download on the user's computer. ( using a download attribute )

Fixed in 6e86c844bb2a755658aa44818aca0535f46bcdb0