Reject queries when out of date

Description
This changeset adds a flag to helper.go which tracks whether consensus believes the state to be valid or not.  When consensus believes state is no longer valid, it calls InvalidateState(), once it believe the replica has caught up, it calls ValidateState().  When the peer receives a query, it first checks whether the helper believes the state is valid or not, and it not, rejects the query because the state may be inconsistent.
Note, presently, the state is assumed to be good at startup, and is only invalidated by consensus at a later time.  We may wish to flip this assumption at some point in the future, but for now it is still an improvement.
Note also that this change intentionally does nothing to change the processing of transaction submission.  Even though a peer is out of date, it does not mean that it cannot submit new transactions to the network.
Motivation and Context
Before this change, clients would receive old state with no indication that there was a problem, even if the peer knew it was thousands of blocks out of date.  After discussions with @binhn and @jeffgarratt it was concluded that queries should be rejected in this scenario.
This is intended to partially address issue #1091.
How Has This Been Tested?
This has been tested locally with behave test issue_680 and with a new behave test tagged as issue_1091.
For the new test, it gets a peer (vp3) into an inconsistent state, then queries, and verifies that an error is returned.  The test for issue_680 covers that once state transfer has completed that the 'invalid' flag is unset, and queries are replied to properly once more.
Relying on CI to execute the other tests.
Checklist:

[X] I have added a Signed-off-by
[X] Either no new documentation is required by this change, OR I added new documentation
[X] Either no new tests are required by this change, OR I added new tests
[X] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Jason Yellick<EMAIL_ADDRESS>

@jyellick I am going to poke at the checkbox that says no new documentation is required. This seems like a major change to the semantics of the network that would require a significant documentation effort. What will this rejected query look like from a user's perspective? (I'm thinking a low-level user like me who is calling the REST API directly). How do we distinguish this failure from any other?  Is there a parameter to control "how far out of date" a query has to be to be rejected? I also assume it now opens the can of worms that queries on a node may never work, which also needs to be documented.

Having just reviewed the code for this PR, I'll venture a couple of answers before @jyellick chimes in.

What will this rejected query look like from a user's perspective? (I'm thinking a low-level user like me who is calling the REST API directly).

The user will get the following message: Error: state may be inconsistent, cannot query

How do we distinguish this failure from any other?

This error message is unique to this case.

Is there a parameter to control "how far out of date" a query has to be to be rejected?

It's not an issue of "how far out of date"; it's an issue of whether the node realizes it has fallen behind, which happens when it hears about f+1 checkpoints above its high watermark. I assume that a smaller checkpoint period means that, in theory, the chances of you finding out that you're falling behind are higher. (Of course, a checkpoint period of 1 if you're partitioned won't help you.)

@kchristidis Thanks - but what I was suggesting is that those answers need to be added at least to the core API document before this PR should be accepted.

@bcbrock I'm by no means opposed to adding, as a future enhancement to the message format, something to indicate that a replica is behind.  This changeset uses the generic "Error" response, and I disagree that this PR is incomplete without a more sophisticated reporting mechanism.
Although @kchristidis is correct when he says you can distinguish this error from the others by that string, pattern matching against an English language arbitrary string does not seem like the sort of thing we want defined in our API. It may be fine for code correctness testing, but to actually make this consumable from an API perspective, I think we would need to introduce some broader concept or error codes, or at the very least classification (say, transient, or fatal).
As I see it, the only existing contract we have for the query interface is the binary "OK and here is your value" or "ERROR and here is an English string as to why we could not get you your value".  Today, a replica which knows that it is out of date replies to queries with "OK" and that is a bug.  It needs to reply with "ERROR" and that is what this changeset does.  Since this does not modify the existing query contract, I'm not sure what documentation would be modified.  To my knowledge, we do not enumerate all of the possible error strings that could be returned by a query, if I'm mistaken, please correct me, and I'll happily document this there.

@bcbrock: I get you, point taken.
To the committers: @bcbrock's documentation comment aside, the code on this one looks good to go.

Shouldn't state transfer set this flag, instead of the consensus plugin?  I.e. when state transfer gets triggered, state transfer signals this fact with the ledger; when state transfer is done (with all outstanding transfer requests), it removes the flag from the ledger.  This has the advantage of keeping the staleness metadata where the data lives, and other routines that may query the ledger (other code paths, local code querying ledger) will receive the same information about staleness.
Also, although I like the simplicity of this solution, I wonder whether it is the right one.  We're trying to build a highly available system - we should not have to reject queries just because we are bulk transferring blocks from elsewhere.
Multiple solutions come to my mind:

block query until state transfer finishes (not much better)
return local state, together with metadata on how stale it is (local block height, known block height)
forward query to other, more up to date peer (either locally, or return a "redirect")

This PR is not ready to be committed. As @corecode points out, this should be part of a comprehensive architecture for the semantics of queries. What is the urgency behind adding this one piece of that architecture now?
@jyellick has drawn attention to the fact that the chaincode APIs and documentation need to be improved. I agree with him that it not his responsibility to rearchitect and redocument the chaincode APIs. However an improvement in API error reporting needs to be implemented before this change should be accepted. What is being proposed here is that a syntactically valid query, targeting a deployed and fully functional chaincode will be rejected, under the assumption  that it might the incorrect answer. This is a bug, not a feature, unless the APIs allow the caller to definitively interpret this rejection as a recoverable error, with options on how to recover (e.g., @corecode suggestions).
Finally, based on @kchristidis explanation, this behavior is triggered as a function of a "watermark". The word "watermark" does not appear in any file in the fabric/docs directory. How is a user supposed to understand and interpret this behavior? So I still believe there is a documentation component missing here.

@corecode With regards to state transfer setting this flag, I did consider this as an option, but ultimately, decided this needed to be done from consensus for a number of reasons.  First off, state transfer being complete, does not indicate that the replica is up to date, it simply means that state transfer has reached a target consensus has supplied to it.  Only consensus knows whether this target is correct or not.  That is why it is the consensus's responsibility to validate the state as current, and you can see in the PBFT code, that this is done after state transfer completes.  I did not include it in this changeset, but my intention is to add code to PBFT to track minimum acceptable block heights, so that it does not incorrectly mark the state as valid, simply because state transfer has completed.
With regards to the solutions you outlined:

Blocking until state transfer completes : This is simply not practical, there is no upper bound on the amount of time a replica takes to become current.
return local state with a flag indicating how stale it is : This was my first inclination, but after more thought, I realized this too is simply no good.  It is possible that the state is not only stale, it could be completely incorrect (anytime we must drop state and retrieve a full state snapshot).  Perhaps these conditions could be differentiated, and there's no reason this could not be modified in the future, but it is a significantly more complex solution.
Forward the query to another more up to date peer : This is yet another solution that was considered, and I wouldn't rule out doing it in a later PR.  It would be simple to plug in here, simply instead of replying with an error, forward the request.  The key to this PR is simply the framework to recognize when we should not be replying.

@bcbrock I suppose the 'urgency' is simply attempts to address the confusion caused by the current behavior, as seen in issues like #1091 and #1331 .
As I pointed out to @corecode, this is not merely an issue of stale data, the data might be complete gibberish, and in fact, your query might fail today because we simply don't realize your chaincode even exists.  I would argue, we are simply making the behavior more predictable.
With the APIs defined as they are today, we have two options.

When we know we are out of date, pretend that nothing's wrong, and reply with sometimes correct, sometimes arbitrarily old, sometimes incorrect, and sometimes error.
When we know we are out of date, acknowledge that we can make no promises about our reply, and consistently return error.

You say it's a bug to return an error when our answer might be correct.  I can certainly see the validity of this argument, however, I would say it's a much more grievous bug to return success when our answer might be wrong.
If it would be a compromise that would allow this PR to be processed, I'd be willing to implement the "forward to another peer" behavior, rather than replying with error.  I'd have preferred to have done that in a separate PR, to minimize the diff and make review easier, but I will do what is needed.

I don't think we should fix something we haven't even decided whether it is broken.
We're facing two separate issues:

stale data.  we need to define what is means to be stale, and how to deal with it, both for queries, and for internal use.
incorrect data or incorrect replies (#1092).  incorrect data must never happen.

This work was originally undertaken with urging from @binhn, maybe he can be more articulate than I as to why this is broken.

@corecode This is to address part of #1331, where inconsistent state was observed from querying different peers.
This solution is a stopgap, and I think a better solution and more time could be had. For example, we could add another status code to the Response object (similar to HTTP codes) to give more detail than just 500 or 200. Checking the error code would be much easier for the application than the error msg.
message Response {
    enum StatusCode {
        UNDEFINED = 0;
        SUCCESS = 200;
        FAILURE = 500;
    }
    StatusCode status = 1;
    bytes msg = 2;
}

Someone could help defining and documenting all potential error codes and messages. This is certainly the work of a protocol, which I am working on setting that up.

Even as a stopgap, I don't like the solution.  I think this should be fixed in the ledger.

@corecode I'm not sure what you mean by 'fixed in the ledger', whether the peer is up to date or not is something only consensus can be aware of.

Yes, but #1331 is because the ledger returns invalid blocks.  This is something the ledger needs to handle correctly.

@corecode I think you've got it backwards, #1091 is because the ledger returns invalid blocks, and this should be fixed separately.  #1331 is because clients expect all replicas to return the same data, and one is behind, and returns old data.  This is more appropriately framed in the context of #1331, absolutely, the #1091 ledger bug should be fixed additionally.

If we say "old data", we need to define what "old data" means.
I don't think that returning an error is preferable over returning old data.

@corecode Today, there is no promise that the data returned will be 'old', there are state transfer scenarios where the data could be 'wrong'.  Returning 'wrong' data, and reporting it as successful is a serious bug, and I think it's worth overzealously returning error for 'stale' data as well.

Incorrect data must not returned.  In this case, we need to return a 5xx HTTP error code, and not an inline error.
Before we start returning errors for old data, we should decide what "old" means.  Peer performing state transfer?  Peer not caught up to weak checkpoint?  Peer not done executing most recent block?  Peer not done executing most recently proposed request?  Where is the line, and why?
I think staleness is a fundamental issue and needs to be addressed conceptually first.

As noted in #1566 I would also want to see at least a dozen or so 5XX codes defined so that I could differentiate what happened to better help the user understand what to do next in the event of an error.

I've opened #1608 which describes the scenario in which the queries can return inconsistent or wrong data.  With some ledger enhancements, we should be able to eliminate that scenario, but I believe this PR is necessary as a stopgap measure.
I've opened #1607 above to continue this discussion for a more complete handling of the 'stale data' issue.
My vote is to merge this as it stands.  Without it, we risk returning wrong data, which is in my opinion serious enough to warrant a stopgap measure.

@bcbrock @corecode do you agree with @jyellick that this is ready to merge or are you still debating? Wasn't sure based on your last comments. Thanks.

@srderson @corecode @jyellick I understand better from a conversation with Jason today why this change is required. I agree that without this or other fixes there is a chance of a query returning an answer that never was, is or could be correct in any state. In an ideal world this and related issues would be addressed at once along with a better error reporting mechanism. But here we are...
Bottom line: I am OK with merging this.

code LGTM.
can we add an try to the FAQ to describe the drror message and the issue ?

@tuand27613 Did you have a particular part of the FAQ this should go in? Don't currently see any reference to queries there.

I copy-edited my original comment ... must learn to type and read.
Usage FAQ seems like a good spot.

@tuand27613 Could you verify you're happy with the doc change in e3f1cfb?

Thanks, LGTM


slycot dependecy

We should probably either fetch it on dolo install or generate our own exception with slycot install instructions.

Yes, the problem used to be that Slycot was not easy to install on all platform. The situation has a bit improved after it was forked, since it is now pip-installable.
I have no idea whether it is pip-installable on windows though. Which platform are you using ?

I'm on Ubuntu. By the way, Slycot pip installed for pip2 but failed for pip3. I was actually a bit amazed that all that fortran actually complied. I think it may be a bit smarter to issue a sensible exception when we need it plus a notice on the install page rather then pull it in on install. Install for me was a pain as it is due to the Nubma dependency. I mean, the typical user should be an academic economist which cannot be expected to know how to apt-get llvm-3.5-dev from an upstream repository, nor understand what is JIT compiling. Ideally, and I am not saying this is a high priority at this point, but ideally, hard-to-install stuff like Numba and Slycot should be optional, and users should get to see dolo in action before they are asked to go through installing it.

As for Slycot I completely agree. It is part of the optional dependencies and I agree that error messages should be more helpful.
I'm not sure that numba should be regarded as a difficult dependency though : to me, it is part of the scientific stack and is distributed with all scientific python distributions (especially anaconda). Lately, I have tended to favour it rather than Cython, mainly for portability reasons (numba makes dolo a source only package). Without it, several parts would be way to slow.
When dealing with typical with typical academic economists, it just seems easier to assume that they can install anaconda python. For linux users, it works very well in user-space. Any reason, you don't want to use it ?

You are right. Anaconda makes this very easy for that case. So strike my rant please. I have some reasons why I prefer system Python, but I am not sure they are good ones. If conda was better documented for the system wide install case I would probably not mind it at all. As it was I believe the last straw was that some packages kept getting installed into system python even though I was using the Anaconda pip.

@yaniv256, I'm reopening this one:

we are not providing a good error message when Slycot is not found (when you do approximate_controls(model, order=2) without it
I'd like to make some tests to see if the situation on python 3 can be improved or not
Let's wait a bit before putting a wontfix flag on it.

Slycot is now installable via conda or pip with Python 3


nixos/no-x-libs: add fastfetch

Description of changes
Add override fastfetch package.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The title of this PR is a bit misleading. Why not
fastfetch: add x11Support option

?

Result of nixpkgs-review pr 286341 run on aarch64-darwin 1

1 package marked as broken and skipped:

fastfetch

The title of this PR is a bit misleading. Why not

I forgot to update file nixos/modules/config/no-x-libs.nix.

Update PR.

Rpm support is disabled by default. It is used to count installed packages in other operating systems.

Result of nixpkgs-review pr 286341 run on aarch64-darwin 1

1 package failed to build:

fastfetch

https://gist.github.com/khaneliman/36c51594ba30b429153b8a2eca732b3a is build log for me on aarch64-darwin.

@khaneliman without these changes, it's building in aarch64-darwin?

@khaneliman without these changes, it's building in aarch64-darwin?

Gonna try building on master real quick

@khaneliman without these changes, it's building in aarch64-darwin?

Gonna try building on master real quick

Builds for me on master. @reckenrode thinks it's a header definition clashing with util-linux.

I poked around the upstream repo, and it appears fastfetch needs lscpu from util-linux but not any headers. You might need to wrap it to make sure lscpu is available at runtime or patch src/detection/cpu/cpu_linux.c with the full path.
https://github.com/fastfetch-cli/fastfetch/blob/736d5316cc680eae82e60873fd03a1e51e9d2cc2/src/detection/cpu/cpu_linux.c#L173C63-L173C68

I poked around the upstream repo, and it appears fastfetch needs lscpu from util-linux but not any headers. You might need to wrap it to make sure lscpu is available at runtime or patch src/detection/cpu/cpu_linux.c with the full path.
https://github.com/fastfetch-cli/fastfetch/blob/736d5316cc680eae82e60873fd03a1e51e9d2cc2/src/detection/cpu/cpu_linux.c#L173

Since they separate their detection by linux/mac etc. I think we could get away with just moving util-linux to the linux section of buildInputs and wouldn't have the clash on darwin.

Since they separate their detection by linux/mac etc. I think we could get away with just moving util-linux to the linux section of buildInputs and wouldn't have the clash on darwin.

Fixed.

Result of nixpkgs-review pr 286341 run on aarch64-darwin 1

2 packages built:

fastfetch
fastfetch.man

Result of nixpkgs-review pr 286341 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

2 packages built:

fastfetch
fastfetch.man

Not sure what the blacklisted is. But fastfetch is working for me on both linux and darwin.

IIRC that changes when the nixos/ directory changes. Can be ignored.


[PIO-30] Spark 2 support on sbt way

The goal of this PR is:

Define the versions of Scala to build against in the crossScalaVersions setting

Scala 2.10 and 2.11

At the project, run make-distribution.sh. Then, create all versions gzs

PredictionIO_2.10-0.11.0-$VERSION.tar.gz <- This is intended for Spark 1 users
PredictionIO_2.11-0.11.0-$VERSION.tar.gz <- This is intended for Spark 2 users

SQLContext maintain the status quo

I wish support for Scala 2.10 is deprecated as of next release

Versions of Hadoop are 2.6+, which has something to do with storage hdfs

2.6 is in lib/spark(default)
2.7 is in lib/extra

@chanlee514 @dszeto
I did #345.
TODO
Currently, only the traditional version of the test works. It needs to be added new version (Spark 2) tests.

@shimamoto I realized the original build system was quite inflexible, so I went ahead and did this in the last couple days: https://travis-ci.org/apache/incubator-predictionio/builds/212014483. It's very close to working with tests across different dependencies. My apologies without syncing up with you.
The build system on that branch basically allows you to do this:
./make-distribution.sh -Dscala.version=2.10.6 -Dspark.version=2.1.0 -Dhadoop.version=2.7.3 -Delasticsearch.version=5.2.2

The script does not cross build, but crossScalaVersions in build.sbt is already defined, so it's possible to cross build and cross publish artifacts. make-distribution.sh could possibly be extended to produce more than one tarballs as well.
Also, before docker-compose becomes available on Apache Jenkins, I am using that as a multi-build just to make sure things compile across versions: https://builds.apache.org/job/incubator-predictionio-multibuild/
Could you take a look at this branch and see how it looks to you? It would be great to converge our changes.

@chanlee514 I looked over the branch :)
I would like to confirm couple of things.

Which versions are you going to make prebuilt packages?
Do you mean that predictionio also supports versions that require users to build Spark(ex. Scala 2.10 & Spark 2.10)? This is just my personal opinion but, .....my impression is that 2.10 is intended for Spark 1 users and 2.11 is intended for Spark 2 users.
ES5 has elasticsearch-spark-13 dependency. We need to use elasticsearch-spark-20 for Spark 2.

@shimamoto We can't really release binary packages on Apache yet until we have reviewed all packaged transitive dependencies comply with Apache policies. It will be a non-trivial exercise. Many people want to ship 0.11 as soon as possible, so it would probably be the next release. We will still require users to build their own package, so cross building everything in one shot would take too much time for them.
The goal is mostly about being flexible to use different dependencies instead of enforcing a set. We probably will only officially test Scala 2.10 + Spark 1.6, and Scala 2.11 + Spark 2. I tried other combos but haven't been able to make them work yet.
Agree the ES dep need to be fixed.

@dszeto I understand your situation.
This PR is put EoM (Ease of Maintenance) before flexible because this leads to Easy of Extension in future. But as you say that the most important thing is flexible right now, this PR probably won't be able to achieve that goal. I think I will close this.
The goal of us is that users can use the standard sets without building by themselves (i.e. without run make-distribution.sh), which is preferable that the latest. Otherwise users need to build, and this was going to be the next step. But I think that's a very hard thing to do right now.
Please continue your good work.

I would still like to merge some of your changes if you are okay with that. Thanks!


feat: shim in a metric for ipconfigstatus state transition durations

Signed-off-by: Evan Baker<EMAIL_ADDRESS>
Reason for Change:

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run

CI green


[JAV-583] Pojo consumer return completable future

Coverage increased (+0.03%) to 87.41% when pulling 7bf2a8bd841f4576a60a6a6ff2e0506cef95eec0 on wujimin:pojo-consumer-return-completableFuture into 288ca9ba91e53f8a9264507c4d88167aa068a8c0 on apache:master.

Coverage increased (+0.04%) to 87.41% when pulling e12e4e996a6b6a451eb6b55faafa206949129c32 on wujimin:pojo-consumer-return-completableFuture into 7cf73d65ed1294ea8f3a13d4865843e4af6f7a9e on apache:master.


[Rector] Enable Skipped NewlineAfterStatementRector

It already solved in latest rector.

ref https://github.com/rectorphp/rector-src/pull/1003

I'm currently cleaning up bunch of rules in rector.php in https://github.com/symplify/symplify/pull/3714
This one included, so I'll merge it there! Good collision :)


python310Packages.casa-formats-io: 0.1 -> 0.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.casa-formats-io is: "Dask-based reader for CASA data"
meta.homepage for python310Packages.casa-formats-io is: "https://casa-formats-io.readthedocs.io/"
meta.changelog for python310Packages.casa-formats-io is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.2.1 with grep in /nix/store/73bak7yy6d2jbkjjgag2af7jlgrbbxcp-python3.10-casa-formats-io-0.2.1
found 0.2.1 in filename of file in /nix/store/73bak7yy6d2jbkjjgag2af7jlgrbbxcp-python3.10-casa-formats-io-0.2.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.casa-formats-io
python310Packages.spectral-cube
python39Packages.casa-formats-io
python39Packages.spectral-cube

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/73bak7yy6d2jbkjjgag2af7jlgrbbxcp-python3.10-casa-formats-io-0.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.casa-formats-io https://github.com/r-ryantm/nixpkgs/archive/3be72d9ca19fbf0abeb8099f13a8b675021c4d26.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/73bak7yy6d2jbkjjgag2af7jlgrbbxcp-python3.10-casa-formats-io-0.2.1
ls -la /nix/store/73bak7yy6d2jbkjjgag2af7jlgrbbxcp-python3.10-casa-formats-io-0.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

python310Packages.spectral-cube
python39Packages.spectral-cube

2 packages built:

python310Packages.casa-formats-io
python39Packages.casa-formats-io

Maintainer pings
cc @smaret for testing.

Superseded by #193910.


Merge master into release for next version

Merge master into release for next version

@bot-gradle test and merge

@bot-gradle merge


Need systemd in the unit test docker

I have a problem that I write a new unit test for bmcweb but this test cannot run via the current CI flow. My unit test focuses on the subscription part of Event Service, so it runs bmcweb app partially and mimics a client to check on the broadcasted test events. However, the HTTP part of bmcweb needs systemd-resolved.service to resolve hostnames and thus further depends on systemd while systemd is not supported in the unit test docker, so is it possible to add systemd in the unit test docker?

You should mock out the dbus calls that bmcweb would interact with.  There should be other examples of creating a dummy dbus end-point.


support mPLUG-Owl3 241101

PR type

[ ] Bug Fix
[x] New Feature
[ ] Document Updates
[ ] More Models or Datasets Support

PR information
We include the support for the mPLUG-Owl3 241101, which changes the definition of media_offset.

https://github.com/modelscope/ms-swift/blob/main/CONTRIBUTING_CN.md#代码规范和开发方式
Please pass the lint test. 😊


executables for 2.21.0 (64bit only)

Been using this to provide the executables for my guild. Feel free to merge it in so that others can use it as well. If you do choose to merge it in, please remove these files whenever the source code changes to avoid confusion. I will submit a new pull request once i have regenerated the executables with the newest code. Thanks.

Sorry, but I can't accept this request because of binaries (exe files). The adding any compiled binaries to the VCS is a bad practice in development. You can keep those files in your repository on github for your guild members or even for everyone or move it to another dev resource/service designed for uploading that ones (for example: sourceforge.net).


Properly implement remove autocorrelations

We punted on the autocorrelation removal in #6. We should get that working again.

@adampbeardsley - @ctaylor-physics is interested in doing image comparisons between EPIC and Orville.  It would be nice to have the auto-correlation removal working for this.

Wait, is this issue fixed in #20?


Fix parameters on Snapdragon

This fixes the parameter download for Snapdragon. The reason that not all parameters did arrive before was that the param index was set to -1 if they hadn't been "used" before, however we ignore the "used" flag for now on that platform.
Additionally, the mavlink stream of PARAM_VALUE is sped up if the connection is made over UDP.
@LorenzMeier please comment on 3ded0e3, not sure if this is the correct way, and not sure if we'll see nasty effects over suboptimal wifi connections.

@julianoes This works, I get all params on snapdragon!

Please rebase and merge, looking good to me. @tumbili please test on Pixhawk ASAP

Rebased and applied to master.


pred_contrib value doesn't add up to prediction in lightgbm regression

I'm using SHAP with LightGBM for regression.
The problem is that SHAP values don't sum up the predicted value.
Predicted values are all in the 0 - 10000 range. I have ~9000 features.

Now the expected value is 60.774, while the sum of shap values is -4040, there is no way it could add up 2291
How is that possible? Thank you very much

@yolimonsta
Hi!
Are you using linear_tree param?
Please provide more details for the issue.
It will be great to have fully reproducible example (MCVE) so that we will be able to help.

Hi! I am not using linear_tree = True. My model is really complex, and have a lot of missing value in feature. Could that be the reason?

Please provide either reproducible example or your model.

@yolimonsta Thanks for using LightGBM, what objective function are you using? It is Quantile Regression / L1 Regression / MAPE Regression?

I bumped into the same problem today. The problem seems to be related to the choice of the objective function for a regression model, in particular affected are poisson, gamma and tweedie.
Example:
import lightgbm as lgb
import pandas as pd
from sklearn.datasets import load_boston

data = load_boston()
X = pd.DataFrame(data.data, columns=data.feature_names)
# scale the target to make the difference more pronounced
y = data.target * 1000

# try out different objective functions and for each compare prediction with the sum of feature contributions
for obj in ["l2", "l1", "huber", "fair", "poisson", "mape", "gamma", "tweedie"]:
    model = lgb.LGBMRegressor(objective=obj).fit(X, y)
    preds = model.predict(X)

    shap_values = model.predict(X, pred_contrib=True)
    sum_of_shap = shap_values.sum(axis=1)

    diff = preds - sum_of_shap
    print(
        f"{obj}: Difference= {diff[0] / preds[0]:.1%}.    Prediction = {preds[0]:.1f}, sum of shap values = {sum_of_shap[0]:.1f}"
    )

Output:
l2: Difference= -0.0%.    Prediction = 24274.4, sum of shap values = 24274.4
l1: Difference= -0.0%.    Prediction = 25055.9, sum of shap values = 25055.9
huber: Difference= 0.0%.    Prediction = 22541.8, sum of shap values = 22541.8
fair: Difference= 0.0%.    Prediction = 57641.8, sum of shap values = 57641.8
poisson: Difference= 100.0%.    Prediction = 24978.1, sum of shap values = 10.1
mape: Difference= -0.0%.    Prediction = 25148.8, sum of shap values = 25148.8
gamma: Difference= 100.0%.    Prediction = 24221.7, sum of shap values = 10.1
tweedie: Difference= 100.0%.    Prediction = 24475.2, sum of shap values = 10.1

lightgbm version: 3.3.3

Is there a way to reopen the issue? It is not reopened upon a new comment and I do not see any button to do it...

Thanks for the example @mlisovyi and for being willing to work with us on this. This issue was previously automatically closed because the people posting in it didn't respond to requests for more information.
I'll re-open this.


Can't confirm rulesets are applied

Can you provide steps to confirm that the new rulesets have been applied?
EdgeRouter PoE v1.9.7+hotfix.3

I'm not sure exactly to which part this is referring.  You would create the needed firewall rules yourself via EdgeOS configuration so checking that configuration will confirm the rules are in place.
To verify if the actual lists are being populated you would use 'ipset' via CLI on the router:
sudo ipset -L Nets4-BlackList | wc -l and sudo ipset -L Nets6-BlackList | wc -l for the IPv4 and IPv6 lists, respectively.  That will show the count of entries in each list, +7.  You can view the actual contents by omiting the | wc -l but the lists are typically very long.

Do they ever appear in the GUI? sudo ipset... returns the count, but the GUI says 0.

No the count of members will never show in the GUI as it is not aware of the actual ipset contents.  The GUI is based on the edgeos configuration.


Relay outputs are not visible under configuration

Tested on Unipi 1.1. Relay outputs are not visible under configuration, can't assign aliases, etc.:

Tested, works.


Establish if value in passing image/height to dita IMAGE

We have the user-provided height and width values for img files.
The DITA image element also takes height and width.  We could move them over to DITA.  Verify if they bring any benefit.
Pass params over, if they do bring benefit in real data.

Yes, this is of value - since the analyst has scaled some of the images to fit in a neat line.

Done.


Updated dependencies, notably mapnik to v4.2.1. Testing on node.js v8 and 10 too.

Is the goal to disable Windows/Appveyor stuff? I just removed it, seemed like that was no longer supported.

This should fix #40

👋 @four43 Going to close because I did a similar update through https://github.com/mapbox/abaculus/pull/42.

Rock on my dude. Thanks!
On Thu, Jun 27, 2019 at 8:33 PM Manohar Erikipati<EMAIL_ADDRESS>wrote:

Closed #41 https://github.com/mapbox/abaculus/pull/41.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mapbox/abaculus/pull/41?email_source=notifications&email_token=AAD6HDQL2FTFP37R2EFPBSLP4VTADA5CNFSM4GUGSUJ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSHFN2VI#event-2445991253,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD6HDVMEL3BZGMO75HMMY3P4VTADANCNFSM4GUGSUJQ
.

--
-Seth


Concurrently modified dictionary not thread-safe

https://github.com/hardkoded/puppeteer-sharp/blob/984fdc06a564e8ded3071a703f83d5dce1627696/lib/PuppeteerSharp/Page.cs#L43

Does it need to be?

It's modified by OnAttachedToTargetAsync and OnDetachedFromTarget, both of which may be called concurrently for multiple workers

https://stackoverflow.com/a/9301533

Can we close this @Androbin ?

@kblok See #1696


remove spaces from .MD filenames

mostly just because i dislike urls with encoded spaces.  if everyone else agrees, i can tackle making the necessary changes to the filenames and hyperlinks.

you want something like: import-data.md?

yeah, or an underscore.

Done #54.


Update the docs with new template docs

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Are these changes also present in istio/api ? Because the next time we regenerate these docs, all these changes will get blown away.

@rshriram Yes. These changed are generated from mixer repo protos, and they are already checked in.

Just edit by hand. Next release, tools will be open source and we can re-evaluate, but atm lets just hand edit to get the docs where we need them to be for 0.2 release.
There's no regular process that regenerates the docs or anything, so there's no risk of manual edits being overwritten.

Jenkins job istio.github.io/presubmit passed


Make use of jest .toMatchSnapshot in library unit tests

Describe the issue
Currently there are a lot of cases where it makes sense to use .toMatchSnapshot instead of .toEqual.
Expected
In tests such as this example of graph.builder.spec.js, replace usages of super verbose and gigantic toEqual for toMatchSnapshot.
Example:
expect(props).toEqual({
    ...that.node,
    className: "node",
    cursor: "pointer",
    cx: 1,
    cy: 2,
    dx: 15.5,
    fill: "red",
    fontSize: 12,
    fontWeight: "bold",
    fontColor: "black",
    id: "id",
    label: "id",
    onClickNode: undefined,
    onRightClickNode: undefined,
    onMouseOut: undefined,
    onMouseOverNode: undefined,
    opacity: 1,
    renderLabel: true,
    size: 200,
    stroke: "yellow",
    strokeWidth: 2,
    svg: "file.svg",
    type: "circle",
    viewGenerator: null,
    overrideGlobalViewGenerator: undefined,
});

Files that should be tackled

graph.builder.spec.js
graph.helper.spec.js

Feel free to look around for other use cases that might make sense.

I would like to take this issue 👍🏻

Go for it @nguyenami :muscle:

Closing this with https://github.com/danielcaldas/react-d3-graph/pull/243


sandbox issues on osx

there are two annoying sandboxing issues on macosx:

when you input the h264 file name without extension (e.g. just "my-movie") there is no write permission to my-movie.mp4, and oscilloscope will crash
syphon is extremely confused, and it seems there is no workaround

Suggestion: Ask for full disk access whenever the operation is attempted perhaps?

yes and no. there's no real way to ask for full disk access.
i can do this when a read/write files:
	ofxNative::openUrl("x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles");

this will show system preferences with the "Full disk access" tab open, i still have two issues:

the oscilloscope app is not there. as if i hadn't requested a file access that failed
it doesn't change a think. even after restarting the app i don't seem to have access

idk, this is my code for now if anyone wants to play around:
void check_sandbox(const std::string & absolute_path, bool wants_write, std::function<void()> on_ok){
#ifndef TARGET_OSX
on_ok();
return;
#endif
	globals.player.stop();

	ofFile file(absolute_path, ofFile::Reference);
	std::string dir = file.getEnclosingDirectory();

	bool have_access = true;
	if(file.exists()){
		ifstream in(absolute_path,std::ifstream::binary);
		if(!in) have_access = false;
	}

	if(have_access && (wants_write && file.canWrite())){
		on_ok();
		return;
	}

	Dialog * d = new Dialog();
	d->addLabel("Cannot access " + file.getFileName() + ".");
	d->addLabel("");
	d->addLabel("Oscilloscope needs permissions to the directory");
	d->addLabel(dir);
	d->addLabel("");
	d->addButton("Allow Folder", [dir,on_ok](){
		ofFileDialogResult res = ofSystemLoadDialog("Pick " + dir, true, dir);
		if(res.bSuccess){
			on_ok();
		}
		else{
			show_ok_dialog("It didn't work :(", [](){} );
		}
	});
	d->addButton("Allow full disk access", [dir,on_ok](){
		ofxNative::openUrl("x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles");
		show_ok_dialog("Please finish the full-disk privilege in system prefs, then restart this app", [](){} );
	});
	d->addButton("Cancel", [](){});
	d->show();

}

@kritzikratzi I'm just guessing out of the blue here, but maybe you need to add some details about your request to Info.plist (e.g. a "app supports optional Full-disk access" capability?)

just opening sys prefs isnt going to cut it, there's a way to tell the os that the app needs the feature as it was said above

just found this information, from three years ago:

the main executable of a whitelisted .app, although it is OK for this whitelisted app to be a helper/child of another app, located in the parent app's Contents/Library.
not attached to by a debugger.
located within /Applications

found here: https://developer.apple.com/forums/thread/107546
i just tested, and that still doesn't help (even if my app is listed as having access). we'll see, happy about any concrete information.


feat: only have standard fuels and credit prices enabled by default

fixes #82

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.55%. Comparing base (ee24801) to head (fb015e7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   77.48%   77.55%   +0.06%
==========================================
  Files           6        6
  Lines         342      343       +1
==========================================
+ Hits          265      266       +1
  Misses         77       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Coverity 1267857: Null return value check in check_request_validity.

Fixed coverity issue 1267857

Is it possible that incoming_hdr->presence() returns true and field_find() returns nullptr?
Maybe we should add assert too, the change seems fine though.


Automatically refresh scripture weekly

Currently, the scripture memorization is manual. It goes through the 7 days and until you click Mark as Done on the 7th day, a new scripture isn't loaded. If you miss doing this on the that day, the memorization starts on the next week. This can be confusing and doesn't match the behavior of Malachi Daily.
Describe the solution you'd like
Automatically, update to the next scripture whenever the new week rolls around (Sunday). Also automatically add these to the Completed tab. Potentially rename that tab to Review or History or something to show these are previous scriptures.
The current Mark as Done flow can be removed or the button be simply used to visually show those that have been memorized in the updated Review tab.
In the future, this flow can be enhanced to have scripture be displayed on a calendar schedule.

Resolved with #10


remove SymbolToInputVisitor

it just implemented visitReference to throw an error but the
BaseImplementationVisitor already throws an error for any unhandled symbol
implementations so that is unnecessary.

ack


bug (mat-button-toggle-group and mat-button-toggle): styling issue with border gaps when zoomed in

Steps to Reproduce
Use Google Chrome or Microsoft Edge

Navigate to Button Toggle Overview Page - https://material.angular.io/components/button-toggle/overview

Select Bold, Italic or Underline button under Basic button-toggles.

Zoom to 125%, 150 or 175%.

Gaps exist between the edges of the selected button and the border of the group button.

Expected Behaviour
There should be no gaps between the edges of the selected button and the border.
Actual Behaviour
Gaps exist between the edges of the selected button and the border of the group button.
Behaviour is seen on Chrome and Edge, but the expected behaviour occurs on Firefox.
Environment

Angular: 12, 8
Browser(s): Chrome, Edge
Operating System: Windows

Screenshots
Microsoft Edge at zoom 150%

Google Chrome at zoom 125%

Firefox at zoom 150% (Expected behaviour)

I can reproduce it too and I've spent some time trying to fix it, but the only way seems to be to move the border from the button group to the individual toggles which makes the styles much messier.


Use with other trackers

Is it possible for you to add support with using other SteamVR trackers (Vive trackers, Thundra, etc) as a position reference for slimeVR?
An example is I'm reusing my old Vive wands as flashed trackers, but I want to use SlimeVR for feet, would it be possible for you to add support for SlimeVR to use my trackers as a positional reference for the feet trackers. I'm using the vive wands as knee trackers for context.

duplicate of https://github.com/SlimeVR/SlimeVR-Server/issues/142


added custom model data support on UI

yes, I finished the test on the server

A lot of conflict occurred because I stopped developing for a long time.
Apart from that, I don't want to change the function name. (I want it to be unified starting with a capital letter)
I will try to resolve the conflickt when I have time.


Make libraries to avoid compiling files multiple times

I noticed some packages are compiling files multiple times - usually test files. This PR makes libraries for the pointcloud_messages.cpp and point_cloud_common_page_object.cpp files because the are compiled 8 times each.

CI (build:  --packages-up-to rviz_default_plugins test: --packages-select rviz_default_plugins)

Linux
Linux-aarch64
macOS
Windows


Added LESS to compile CSS

Was able to add in less and a clean css plugin that minifies all of the css. Color variables are at the top of each less file. I just left them for now, but you can easily split those into a different file and in your styles.less file just make sure you call the variables file before the other less files.
Let me know if you have any questions.

Thanks for this PR!

No problem @yann300 That file has been removed.

please rebase

I have made these changes at (just to try it myself out): https://github.com/ethereum/browser-solidity/tree/use-less
@jcbrmn if you want you can base any future work off that branch.

Had a busy week and will take a look at these changes this weekend. Will probably just create a new PR to keep things cleaner if thats alright.

@jcbrmn replaced this by #312. You can open pull requests aginst that branch (use-less). Thank you for the work so far!


First class support for Cocapods

Experimenting with https://github.com/wojciech-kulik/Swift-MVVMC-Demo
Status:

[x] Build/Run works fine
[ ] LSP features

Issues:

pod install needs to be ran manually for build/run to work
Fails to generate compile commands. xcworkspace is totally ignored.

Todos:

[ ] Generate compile commands based on project schema (see tuist.rs support)
[ ]  Automatically run pod install on Podfile and no Pods directory, as well as when Podfile is updated.

cc @wojciech-kulik

I think at first approach you don't have to worry about running pod install automatically and detecting changes there. Usually people call it manually when working on the project.


multioutput uoping infra

since all outbufs are the same shape opts and dimensions are valid. UOping needs a small refactor.
I'm leaving out multioutput FLOPS and mem from this refactor, it can't yet be tested e2e.
I think we could still use the first lb for the cache key

Maybe we just remove LazyOp info?


Crash in ImageryLayer._createTileImagerySkeletons

I'm getting a crash with the following callstack when using a custom terrain and imagery together.  (Both terrain and imagery work fine independently.)
DeveloperError: Expected rectangle to be typeof object, actual typeof was undefined
Error
    at new DeveloperError (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:540:19)
    at Object.Check.typeOf.object (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:727:19)
    at Function.Rectangle.southwest (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:6816:30)
    at WebMercatorTilingScheme.rectangleToNativeRectangle (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:85259:54)
    at ImageryLayer._createTileImagerySkeletons (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:208363:33)
    at prepareNewTile (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:207141:23)
    at Function.GlobeSurfaceTile.processStateMachine (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:207045:13)
    at GlobeSurfaceTileProvider.loadTile (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:209507:26)
    at processSinglePriorityLoadQueue (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:212341:26)
    at processTileLoadQueue (https://cesiumjs.org/Cesium/Build/CesiumUnminified/Cesium.js:212332:9)

And here's the code to reproduce this (I can't share the data publicly, so I didn't provide the access token or ids.  Contact me directly for the data.
var viewer = new Cesium.Viewer('cesiumContainer',{
    terrainProvider : new Cesium.CesiumTerrainProvider({
        url: Cesium.IonResource.fromAssetId('See me')
    }),
    imageryProvider: false,
    baseLayerPicker: false
});

var imageryLayer = viewer.imageryLayers.addImageryProvider(
    new Cesium.IonImageryProvider({ assetId: 'See me' })
);

viewer.zoomTo(imageryLayer)
    .otherwise(function (error) {
        console.log(error);
    });

The problem does not happen if I enable a global imagery base layer (as long as that layer is turned on).  Adding a global imagery base layer with show = false still reproduces the issue.

This was pre-imagery/terrain overhaul (and for some reason I didn't include enough info to try and reproduce this).


runtime error: slice bounds out of range

When I run sudo./pingdns, it displays:
anic: runtime error: slice bounds out of range [16:0]
goroutine 1 [running]:
github.com/jamespwilliams/dns-over-ping.Server.handleICMPEcho({0x640, {0x5bcfb8, 0x8}, {0x5bc9a6, 0x7}, 0xc0000cc0e0}, 0xc0000f6000?)
/root/dns-over-ping/pingdns.go:106 +0x605
github.com/jamespwilliams/dns-over-ping.Server.handleBytes({0x640, {0x5bcfb8, 0x8}, {0x5bc9a6, 0x7}, 0xc0000cc0e0}, {0xc0000f6000?, 0x1?, 0x0?})
/root/dns-over-ping/pingdns.go:97 +0x10c
github.com/jamespwilliams/dns-over-ping.Server.Serve({0x640, {0x5bcfb8, 0x8}, {0x5bc9a6, 0x7}, 0xc0000cc0e0})
/root/dns-over-ping/pingdns.go:64 +0x1ec
main.main()
/root/dns-over-ping/cmd/pingdns/main.go:25 +0x245

Me too
panic: runtime error: slice bounds out of range [16:0]
goroutine 1 [running]:
github.com/jamespwilliams/dns-over-ping.Server.handleICMPEcho({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0}, 0xc000120000)
/root/dns-over-ping-main/pingdns.go:106 +0x268
github.com/jamespwilliams/dns-over-ping.Server.handleBytes({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0}, {0xc000120000, 0x1, 0x0})
/root/dns-over-ping-main/pingdns.go:97 +0x10c
github.com/jamespwilliams/dns-over-ping.Server.Serve({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0})
/root/dns-over-ping-main/pingdns.go:64 +0x1ec
main.main()
/root/dns-over-ping-main/cmd/pingdns/main.go:25 +0x24c
[root@iZ2vc79qc6ja2gvnerg92gZ dns-over-ping-main]# ./pingdns
panic: runtime error: slice bounds out of range [16:0]
goroutine 1 [running]:
github.com/jamespwilliams/dns-over-ping.Server.handleICMPEcho({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0}, 0xc000120000)
/root/dns-over-ping-main/pingdns.go:106 +0x268
github.com/jamespwilliams/dns-over-ping.Server.handleBytes({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0}, {0xc000120000, 0x1, 0x0})
/root/dns-over-ping-main/pingdns.go:97 +0x10c
github.com/jamespwilliams/dns-over-ping.Server.Serve({0x640, {0x5a0ad8, 0x8}, {0x5a04dc, 0x7}, 0xc0000f60e0})
/root/dns-over-ping-main/pingdns.go:64 +0x1ec
main.main()
/root/dns-over-ping-main/cmd/pingdns/main.go:25 +0x24c

Interesting, looks like the server is receiving an ICMP echo request packet with a short body on your machines - I don't know why that would be happening. Anyway, https://github.com/jamespwilliams/dns-over-ping/commit/523dc546cf40374e492b832d0c9bb19fa59cae24 should stop it happening, let me know if it works for you now.

I re-git clone, compile and execute, and it says:
[root@VM-20-8-centos dns-over-ping]# sudo ./pingdns
2022-11-15T10:33:04.150+0800    WARN    dns-over-ping/pingdns.go:66     failed to handle request        {"error": "icmp echo data was too short? got 0 bytes, expected at least 16"}
github.com/jamespwilliams/dns-over-ping.Server.Serve
/root/webank/dns-over-ping/pingdns.go:66
main.main
/root/webank/dns-over-ping/cmd/pingdns/main.go:25
runtime.main
/usr/local/go/src/runtime/proc.go:255
2022-11-15T10:33:05.172+0800    WARN    dns-over-ping/pingdns.go:66     failed to handle request        {"error": "icmp echo data was too short? got 0 bytes, expected at least 16"}
github.com/jamespwilliams/dns-over-ping.Server.Serve
/root/webank/dns-over-ping/pingdns.go:66
main.main
/root/webank/dns-over-ping/cmd/pingdns/main.go:25
runtime.main


Added mean_wind_speed @the-louie suggest

I added a new PR that replaces #1 . It was easier to do that cause of changes that makes merges difficult. Only difference is that I kept the old wind_speed for backwards compability and added the mean_wind_speed as @the-louie suggested in that PR.
@the-louie would you mind check the code that it seems like you intended please?

Thanks! Now i just have to remember why I needed it :)

closing this since interests of adding feature is not present


allow_click_label has issues when using poltergeist

allow_click_label won't actually click the label if the radio button/checkbox is "hidden" by being shifted off the page to a negative location.  This occurs because both poltergeist and capybara-webkit (would have the issue if it supported Capybara 2.8+) both consider elements shifted off the page with negative positions to be visible whereas selenium-webdriver does not.

Fixed via 272a052f68c6079ae90940910b5da0bc197faf07


Squiggle start line is off by 1

Try any error in TS and you'll see that squiggles start 1 line early. Very confusing.
**

**

Completly destroys the JS editing experience IMO.

I'll take a look today


Q: when count eq zero

Would it be safe to wrap the render in a conditional so it won't output when nothing is added?
https://github.com/kaliber5/ember-stargate/blob/master/addon/components/portal-target.hbs
{{#if this.count}}

<div
  {{did-insert this.register}}
  {{will-destroy this.unregister}}
  ...attributes
>
  {{yield this.count}}
</div>

{{/if}

Hm, I don't think this would work right now, as rendering into the portal target using in-element happens before the portal is registered (so count is still 0). See https://github.com/kaliber5/ember-stargate/blob/master/addon/components/portal.js#L11


query fontconfig to determine if Noto Color Emoji is installed

Fontconfig allows fonts to be installed in many places.
This PR queries fontconfig to see if it knows about a Noto Color Emoji font to decide whether to install the font instead of just checking ~/.fonts.
I didn't create an issue because this is literally a one line change and the PR is self explanatory imo.

thanks for this!

@all-contributors add @tritoke for code


Please confirm and add the integration with Exchange 2019.

Please confirm and add the integration with Exchange 2019. Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5033cf14-8912-471d-66b7-61ca7e29d752
Version Independent ID: a7c05a79-cd65-1717-d4a4-0dde3c368263
Content: Connect to Exchange Server (on-premises) - Power Platform
Content Source: power-platform/admin/connect-exchange-server-on-premises.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@MichaelWeberMSFT
Thanks for your feedback. Confirmed Exchange Server 2019 is supported and added to the list.


[Bug] Can't produce report from Grafana with credentials

I try to produce a report from my local grafana server. Installed reporter on the same machine as grafana (runs on port 3000).
When I try to generate the report, I get the following message in the log:
GET /api/dashboards/db/call-cluster HTTP/1.1" 401 Unauthorized 26 bytes in 289u
It doesn't matter if the dashboard exists or not.
This is because I need to somehow provide the reporter with credentials (in postman I get the same result until I provide basic authentication).

This is a shorcoming; I have been very lax with authentication.
I run my Grafana with anonymous auth enabled in the grafana.ini to avoid dealing with it in API calls.
[auth.anonymous]
# enable anonymous access
enabled = true

# specify organization name that should be used for unauthenticated users
;org_name = Main Org.

# specify role for unauthenticated users
org_role = Admin

You can try with these settings.
I would be open to a PR that adds proper authentication support.

I have opened this PR to allow auth.
You have to pass an API key as a parameter in the URL.

#3  Fixes this..


Installing issue by pod

Hi @shamatar
Im using this pod 'web3swift' for installing but I will get error while I'm building the project we didn't get error when we were using BANKEX/web3swift
look at this image:
Link Here
thanks

Hello Mahdi!
Original authors of web3swift has left the bankex and continue the development in this repository, so pods are not compatible.
From your attached screenshot it looks like a problem of Xcode version, Swift version and Cocoapods. What are versions of Xcode, Swift and Cocoapods that you use? Please do run clean && clean derived data && pod update and check if a problem persists.
Sincerely, Alexander

From: Mahdi Mahjoobe<EMAIL_ADDRESS>Sent: Monday, October 29, 2018 1:01:09 PM
To: matterinc/web3swift
Cc: Alexander; Mention
Subject: [matterinc/web3swift] Installing issue by pod (#76)
Hi @shamatarhttps://github.com/shamatar
Im using this pod 'web3swift' for installing but I will get error while I'm building the project we didn't get error when we were using BANKEX/web3swift
look at this image:
Link Herehttps://imgur.com/a/HQ01bQv
thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/matterinc/web3swift/issues/76, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGKv9wVa5ocmTYsrD5mjxf1NJpLMU_Rzks5uptHlgaJpZM4X-0pz.

Hi @shamatar
Xcode 10, swift 4.2, Cocoapods 1.5.3
thanks

I think you need to upgrade to Cocoapods 1.6 beta for Xcode 10

From: Mahdi Mahjoobe<EMAIL_ADDRESS>Sent: Monday, October 29, 2018 3:46:23 PM
To: matterinc/web3swift
Cc: Alexander; Mention
Subject: Re: [matterinc/web3swift] Installing issue by pod (#76)
Hi @shamatarhttps://github.com/shamatar
Xcode 10, swift 4.2, Cocoapods 1.5.3
I did everything you said but we get same error
thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/matterinc/web3swift/issues/76#issuecomment-433896398, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGKv90DRHe_vH5GDSDI3N2OHxYYR7K-Aks5upviegaJpZM4X-0pz.

@Mahdimm I have the same error but I use  pod 'web3swift', '~> 2.0', If u solved this problem, please write me.

I’ll check the scrypt pod, but this was fixed some one ago for Swift 4.2 compatibility

@Mahdimm Is the problem relevant now?


How can I use the functions those control windows

such like  activate window and move window
autohotkey has these methods ,
WinActivate, [ WinTitle, WinText, ExcludeTitle, ExcludeText]
WinWait, WinTitle, WinText, Seconds [, ExcludeTitle, ExcludeText]
can pyautogui support background operation？

There isn't a way to do it currently, though AutoHotkey's set of features is stuff I'd like to see in PyAutoGUI. Currently, you can activate a window by simulating a click on it.


Alfoa/constants samplers optimizers

Pull Requeset Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Issue #19
What are the significant changes in functionality due to this change request?
This Pull Request (MR) is intended to allow the user to input "constant" values in any Sampler/Optimizer. This capability, even if quite simple, can allow the user to perform, for example, ROM evaluations keeping some of the features to a constant values. This could be achieved creating a dummy grid with almost coincident lower and upper bounds, but it was resulting into a cumbersome way to proceed. This change was supposed to impact the Sampler.py and Optimizer.py classes, but, considering how different are the DET-based samplers, the change was needed to be propagated in DynamicEventTree.py and AdaptiveDynamicEventTree.py. I will open an issue restructure the input creations in the DET-based samplers in order to avoid unneeded redundancies.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

Dumb question, but why can't we just use a constant distribution?  We already have BasicConstantDistribution in Crow, it just needs to be added to the python distribution list.

Because using the Constant Distribution would consider the constant variables as part of the sampling strategy or optimization strategy. Even if for most sampling strategy this will not be a problem, for those that are "learning driven", the fact that the "constant" variables are part of the "uncertain input space" can create more problems than advantages. For example, in the gradient based optimizer, the partial derivative will be infinite.

addressed Paul's comments

Checklist performed and changes approved; when tests pass this is cleared for merge.

All changes have been reviewed and the tests have passed.  Squashing and merging.


CNV-22086: Converting upstream/downstream terms and comments

Signed-off-by: Avital Pinnick<EMAIL_ADDRESS>

@sradco @nunnatsa
Ready for review


Hermes Engine now supports Proxy

🙋♂ Question
Hermes Engine has finally implemented Proxy. Is there anything else preventing Immer from running on Hermes without enableES5? If now, this could be awesome!

Give it a try?
On Mon, 7 Dec 2020, 00:44 Luis Durão<EMAIL_ADDRESS>wrote:

🙋♂ Question
Hermes Engine has finally implemented Proxy
https://github.com/facebook/hermes/issues/33#issuecomment-696493411. Is
there anything else preventing Immer from running on Hermes without
enableES5? If now, this could be awesome!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/717, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBFQL6TH6N4LXPVTGO3STQQQXANCNFSM4UPXHEUQ
.


Realm creation page: short name description should also say all lowercase

The description for the field where you create your realm says "A short, unique name for your organization, with no spaces."
It also can't include capital letters, it would be helpful to also mention that. Something like "A short, unique name for your organization, lowercase, with no spaces."
(Are there other restrictions? Unicode? Punctuation? Numbers?)

@zulipbot claim


error

can u help me ?
Message: 'chromedriver' executable needs to be in PATH. Please see https://chromedriver.chromium.org/home

Hi Francoa,
I think if you used the code from my GH repo, you would not that get an
error as the chrome driver is installed in the given directory when the
code is run. Hope this helps.
The code:self.driver = ChromeDriverManager().install()
Regards,
Areeb Shafqat
On Sun, 24 Apr 2022 at 22:09, francoa.taffarel @.***>
wrote:

can u help me ?
Message: 'chromedriver' executable needs to be in PATH. Please see
https://chromedriver.chromium.org/home
—
Reply to this email directly, view it on GitHub
https://github.com/Areeb297/Data-Collection-Pipeline/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMFKWTCS67KLC337Y52EGPDVGWL7PANCNFSM5UGUWK4A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The issue is closed as either the ChromeDriverManager needs to be in the correct directory, or we can use ChromeDriverManager().install() directly in our script without worrying about this issue


Not working

It's not working in ff latest beta(125.0b9),no image dimensions are shown
win10 22h2(19045.3155)

Confirmed. Google changed quite a lot on its side.
But I already found a workaround, and an update will be rolled out this weekend.


Your Code Has been Helpful

Your code has been extremely helpful

thanks! I wrote this so long ago, I am glad people still look at it.


Show good / bad examples in documentation

From @Hammarn on March 22, 2017 8:19
It would be useful to supply examples of a good/expected output for all our supported programs. Or we should at least specify wether the supplied results are of a good or bad experiment. FeatureCount is currently shows a library with rather low annotation amounts.
Copied from original issue: SciLifeLab/NGI-RNAseq#93

I don't have example for all the tools on hand, especially those I never used (i.e. previously cited FeatureCount for example) but I'll try to tackle at least past of this. I'd like to at least include a few links to helpful resources like QCfail that can help to sort out the results. If you have examples on hand I'd be happy to add them to the doc as well.

After half an hour of pondering on this problem I'm starting to realise how hard it is to say if examples are good or bad without context. (i.e. are FastQC plots before or after trimming? Is SortMeRNA plot from a rRNA-depleted library? and so on)
At this rate it'll be really hard to provide examples of good/bad output. I think warnings for specific tools would be more appropriate for this pipeline at least. Any thoughts on that?

Adding links where appropriate would definitely be a good start. Yep, it's not trivial to do this sort of thing without maybe having a bad dataset to compare to..

I contemplated working on this issue again yesterday, like maybe launching a few runs of the pipeline on minimal public datasets to generate example plots. However, even if I add good examples only for every step that produces plots, it would amount to a really large number of images on this page, and writing guidelines for all of them seems like a daunting task.
Still, some of the plots currently present in the output docs are showing results that would be worrying in an actual analysis.
What do you think we should do about that @drpatelh @maxulysse ?

I'm thinking let's start just by replacing the bad plots with ones that looks good.
Can we point towards the results in tower to show what good results should look like?

I'm thinking let's start just by replacing the bad plots with ones that looks good. Can we point towards the results from the megatests to show what good results should look like?

I have no idea when to find those megatests, but if you tell me where to find them I can do that!


addCue() does not return a number/Id. It returns NaN

From @wktdev on June 18, 2018 5:24
I don't know if I am misreading the documentation or if this is an error. addCue does not return a number or "ID".  It returns NaN.
https://p5js.org/reference/#/p5.SoundFile/addCue
Documentation quote:

Returns
Number: id ID of this cue, useful for removeCue(id)

Example
  mySound.play();
  let id = mySound.addCue(3, console.log,"we are the world");
  console.log(id)  //  NaN

How does removeCue(id) work?
Ultimatley I am trying to understand how to use the removeCue(id) function and the documentation does not give a clear cut example.
Can someone please show me and clear this up ? The documentation is very poor.
Copied from original issue: processing/p5.js#3030

From @EsdrasXavier on June 20, 2018 14:49
Hello, I tried do the same thing and I also get the same error, so I looked at the source code 'p5.sound.js' and searched where this method is called... On line 2098:
  p5.SoundFile.prototype.addCue = function (time, callback, val) {     var id = this._cueIDCounter++;     var cue = new Cue(callback, time, id, val);     this._cues.push(cue);     // if (!this.elt.ontimeupdate) {     //   this.elt.ontimeupdate = this._onTimeUpdate.bind(this);     // }     return id;   };
But this._cueIDCounter has not been set, maybe just in version: 2018-01-19 v0.3.7 ... So I added this code in line 815:
this._cueIDCounter = 0;
Look works fine now, maybe a bug or just forgot to declare. Also I tried to use removeCue, which has a bug too on line 2119 the property is wrong, you need change this:
this.cues.splice(i, 1);
to
this._cues.splice(i, 1);
When you call the function mySound.removeCue(id), you will be able to delete the callback based on id passed by param returned by mySound.addCue().
Look this example:
`
  function setup() {
    textSize(32);

    background(0);
    noStroke();
    fill(255);
    textAlign(CENTER);
    let mySound = loadSound('/teste_linhas/sound.mp3');
    mySound.play();
    let id = mySound.addCue(0.50, changeText, "a       a" );
    console.log(id);
    mySound.removeCue(id);
    id = mySound.addCue(1.0, changeText , " b     b" );
    console.log(id);
    id = mySound.addCue(3.0, changeText , "  c c" );
    console.log(id);
  }
  function changeText(val) {
    text(val, width/2, height/2);
  }

`
You probably not will be able to see the "a      a" string on canvas

From @limzykenneth on June 24, 2018 6:3
Hi, can this issue be moved to the p5.sound repo? As the source code for sound are hosted separately there. Thanks!

fixed with https://github.com/processing/p5.js-sound/pull/298


Fix pass through of arguments that include spaces

Not expected but I’ve take the time to fix #7 since I’ve found another issue for which I’ve had no workaround : Arguments that contain spaces where not correctly transmitted.
Instead of being send as a single argument they were send as multiple arguments since they were not encapsulated into double quotes.
NB : There is probably still some issues if an argument include spaces, and ends with a backslash or contains a backslash followed by a double quotes, because there is an awkward logic in command line parsing based on the parity of backslashes before a double quote that has always be hard to manage and understand for me (see :
https://web.archive.org/web/20220604063845/https://docs.microsoft.com/en-us/previous-versions//17w5ykft(v=vs.85)?redirectedfrom=MSDN)

For the two fixes included in that PR, #9 is equivalent, and #11 is better, so I close this one.


NFT screen , add teh id number close to the name of teh NFT

It is difficult to identiitfy which NFT it is if we do not have the if number


Add description to the home page

Fixes

Fixes #1756 by @panchovm
Description

This PR adds the text changes from the linked issue to the homepage.
@panchovm, I've noticed that the font sizes are not multiples of 16 here, as they normally are.
I've also changed the font sizes on the md breakpoint, not on the lg breakpoint as it was previously. Is that correct, or should I change it back to lg?
Testing Instructions

Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I updated the width and this is ready for review again, @panchovm. Here is a gif:


invalid_records_* doesn't ignore psycopg2 encoding errors

I'm getting the following error:
target_postgres.exceptions.PostgresError: ('Exception writing records', QueryCanceled("COPY from stdin failed: error in .read() call: UnicodeEncodeError 'utf-8' codec can't encode character '\\udc81' in position 184: surrogates not allowed\nCONTEXT:  COPY tmp_b02cfd05_c98b_477c_950e_cb03ed693bab, line 23990\n")) cmd_type=elb consumer=True name=target-postgres producer=False stdio=stderr string_id=target-postgres
I was hoping that the invalid_records_* settings would help with this kind of problem, but that doesn't seem to be the case.
Is it supposed to help?
If not, do you have any suggestions for avoiding this kind of problem?

This looks like postgres itself is rejecting your data because it contains an invalid character \\udc81. I don't think the target's validation checks cover this type of issue, which might be why they don't seem to help.
Maybe check your data source and the tap to validate that you're not sending invalid data over?


Make a scuffed ECS

The Inheriting-Based System that I use now is good enough, but a "proper" ECS system would be much more useful and better

Switched to a node based system like Godot


Driver wasn't found.

The tool looks for the string "Device\Nal" in all loaded drivers. This must mean, that the string either is not included or the driver is not loaded. Please post the loaded driver binary that is causing the issue.


Test Next Minor, Test Next Major, CI/CD are failing when appDependencyProbingPaths is defined

I am currently using the preview version of AL-Go and last night all builds started failing with the error message that an app can't be downloaded when trying to download symbols. The app that can't be downloaded is defined in the appDependencyProbingPaths - referencing another repo in the same organization.
Did anything change within the process recently? It seems like it doesn't install the apps anymore that are referenced this way.

I'm experiencing similar issue related to appDependencyProbingPaths. In my case, I'm using release status="include", but pipeline fails with an error:
Error: Invalid release status 'include' is encountered.
my al go settings files looks like this:
{
    "country":  "it",
    "appFolders":  [
    ],
    "testFolders":  [
    ],
    "appDependencyProbingPaths":  [
        {
            "repo":  ".",
            "release_status":  "include",
            "projects":  "SRS.core"
        }
    ]
}

@gntpet I think your issue is different. The valid release statuses - according to documentation are:
release_status = latestBuild/release/prerelease/draft (default release)
So, I am assuming that this is why yours is failing with the error you are getting.

That's undocummeted 'feature', which is used when when you have multiple projects within the same repository. So, instead of downloading dependencies from releases, it just look at 'dependecy' folder within same repo. It was working fine 5 days ago.
Anyhow, I'm creating new ticket #270 for it.

BTW - for multiple projects - the next preview will have a new setting called useProjectDependencies, which will build projects in the right order and use the output from the other build.
= like it should be:-)
You can see here: https://github.com/businesscentralapps/buildorder how this works.
Set UseProjectDependencies to true and run Update AL-Go System Files - then your pipelines will build things in layers.

I can confirm that it's working now. Not sure, if you want to close the issues or if you want me to, in an instance like this. Leaving it open for you :)

Thanks for the confirmation, I will close this.


cannot load exported torchscript model with pytorch_mobile (in flutter)

1-I exported "faster_rcnn_fbnetv3a_dsmask_C4" model with the code provided here : https://github.com/pytorch/android-demo-app/blob/master/D2Go/create_d2go.py
with torch==1.8.0 torchvision==0.9.0 torchaudio=0.8.0.
So finally got "d2go.pt" file.

Then in flutter I tried to load d2go.pt model with package pytorch_mobile. But when I reach the line
PyTorchMobile.loadModel('assets/models/d2go.pt');
I get the following errors in my Log:

E/PyTorchMobile(17944): assets/models/d2go.pt is not a proper model
E/PyTorchMobile(17944): com.facebook.jni.CppException:
E/PyTorchMobile(17944): Unknown builtin op: torchvision::nms.
E/PyTorchMobile(17944): Could not find any similar ops to torchvision::nms. This op may not exist or may not be currently supported in TorchScript.
E/PyTorchMobile(17944): :
E/PyTorchMobile(17944):   File "/content/drive/MyDrive/detection/env/lib/python3.7/site-packages/torchvision/ops/boxes.py", line 36
E/PyTorchMobile(17944):     """
E/PyTorchMobile(17944):     _assert_has_ops()
E/PyTorchMobile(17944):     return torch.ops.torchvision.nms(boxes, scores, iou_threshold)
E/PyTorchMobile(17944):            ~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
E/PyTorchMobile(17944): Serialized   File "code/torch/torchvision/ops/boxes.py", line 26
E/PyTorchMobile(17944):   _8 = torch.torchvision.extension._assert_has_ops
E/PyTorchMobile(17944):   _9 = _8()
E/PyTorchMobile(17944):   _10 = ops.torchvision.nms(boxes, scores, iou_threshold)
E/PyTorchMobile(17944):         ~~~~~~~~~~~~~~~~~~~ <--- HERE
E/PyTorchMobile(17944):   return _10
E/PyTorchMobile(17944):
E/PyTorchMobile(17944): 	at org.pytorch.NativePeer.initHybrid(Native Method)
E/PyTorchMobile(17944): 	at org.pytorch.NativePeer.(NativePeer.java:24)
E/PyTorchMobile(17944): 	at org.pytorch.Module.load(Module.java:23)
E/PyTorchMobile(17944): 	at io.fynn.pytorch_mobile.PyTorchMobilePlugin.onMethodCall(PyTorchMobilePlugin.java:46)
E/PyTorchMobile(17944): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/PyTorchMobile(17944): 	at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85)
E/PyTorchMobile(17944): 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:818)
E/PyTorchMobile(17944): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/PyTorchMobile(17944): 	at android.os.MessageQueue.next(MessageQueue.java:325)
E/PyTorchMobile(17944): 	at android.os.Looper.loop(Looper.java:142)
E/PyTorchMobile(17944): 	at android.app.ActivityThread.main(ActivityThread.java:6944)
E/PyTorchMobile(17944): 	at java.lang.reflect.Method.invoke(Native Method)
E/PyTorchMobile(17944): 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
E/PyTorchMobile(17944): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
Expected behavior:
loading the model.
Is there anyone who knows what is happening?!

I am not familiar with pytorch mobile. Could you report this issue to the android demo repo as well? https://github.com/pytorch/android-demo-app/issues

I am not familiar with pytorch mobile. Could you report this issue to the android demo repo as well? https://github.com/pytorch/android-demo-app/issues

OK. I just did.

@sadegh16 if you are using pytorch_mobile package, I solved this problem only for android in this fork

So, can we use the exported model in flutter application? Any implementation doing that is available?

So, can we use the exported model in flutter application? Any implementation doing that is available?

Try using this repo

Thanks!
On Wed, 8 Sep, 2021, 11:19 pm Elbek Khoshimjonov, @.***>
wrote:

So, can we use the exported model in flutter application? Any
implementation doing that is available?
Try using this repo https://github.com/elb3k/flutter_pytorch_mobile
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/d2go/issues/31#issuecomment-915444642,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK4GSXO5N73XOGWWWOEMHMLUA6OZXANCNFSM4Z6MXRSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@sadegh16
Did you solve the problem?
I'm facing the same

Hi @elb3k,
I tried using your repo but I still not able to load the model.
Abort message: 'terminating with uncaught exception of type c10::Error: isTuple() INTERNAL ASSERT FAILED at "../../../../src/main/cpp/libtorch_include/x86_64/ATen/core/ivalue_inl.h":1101, please report a bug to PyTorch. Expected Tuple but got String
Exception raised from toTuple at ../../../../src/main/cpp/libtorch_include/x86_64/ATen/core/ivalue_inl.h:1101 (most recent call first):
(no backtrace available)'


Decouple Exporter creation with the Reentrant processor

Changes
Nit fix, to enable exporter creation separately to the Reenterant processor, to make it consistent with the approach used with SimpleLogProcessor and BatchLogProcessor. No changes in functionality as such, though it is a breaking change for customers.
Merge requirement checklist

[x] CONTRIBUTING guidelines followed
[ ] Unit tests added/updated (if applicable)
[x] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
[x] Changes in public API reviewed (if applicable)

Please callout the changes in changelog too.

Done.


Fix: Improper parameterizing of variables without values

Description

Ignore parameterization of undefined value.SELECT {{ context.params.somethingUndefined }} -- output nothing

Add void filter{% set someArr = [] %}
{{ someArr.push(1) |  void }}

select {{ someArr[0] }} as a;

Document
https://vulcan-sql-document-git-fix-avoid-pa-8e149a-vulcan-sql-document.vercel.app/docs/api-building/sql-syntax#void-filter
Issue ticket number
closes #112
Additional Context

Codecov Report
Base: 93.02% // Head: 93.04% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (458016f) compared to base (120eec7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    93.02%   93.04%   +0.02%
===========================================
  Files          275      277       +2
  Lines         4157     4171      +14
  Branches       548      549       +1
===========================================
+ Hits          3867     3881      +14
  Misses         192      192
  Partials        98       98

Flag
Coverage Δ

build
95.18% <ø> (ø)

core
93.71% <100.00%> (+0.04%)
:arrow_up:

extension-dbt
97.43% <ø> (ø)

extension-debug-tools
98.11% <ø> (ø)

extension-driver-duckdb
100.00% <ø> (ø)

extension-driver-pg
96.11% <ø> (ø)

extension-driver-snowflake
94.59% <ø> (ø)

integration-testing
96.15% <ø> (ø)

serve
90.03% <ø> (ø)

test-utility
∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/core/src/lib/data-query/parameterizer.ts
100.00% <100.00%> (ø)

...ine/built-in-extensions/query-builder/constants.ts
100.00% <100.00%> (ø)

...-engine/built-in-extensions/query-builder/index.ts
100.00% <100.00%> (ø)

...lt-in-extensions/query-builder/voidFIlterRunner.ts
100.00% <100.00%> (ø)

...t-in-extensions/query-builder/voidFilterBuilder.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Badge for CLA assistant

Would it be helpful to have a badge which indicates how many contributors already signed a CLA?
It shows how big of a community is working on the repo.
@thojansen @KharitonOff @dfarr - what do you think?

i think something like

would be pretty cool :+1:

:+1:

:+1:

I think relying on shields.io would be a good idea. For instance using @thojansen’s example: https://img.shields.io/badge/CLAs signed-137-blue.svg

Thank you @KharitonOff!


Explorer Practice: use other smileys

Just use the smiling and sad smileys for small win/loss values.

done in v2.1.3


Uncaught TypeError: Cannot read property '_' of undefined

When I try to import the library into my ReactJS app, I get this error:

underscore.js:15  Uncaught TypeError: Cannot read property '_' of undefined

The error is thrown here. root is undefined.
(function() {

  // Baseline setup
  // --------------

  // Establish the root object, `window` in the browser, or `exports` on the server.
  var root = this;

  // Save the previous value of the `_` variable.
  var previousUnderscore = root._; // <==  !!! HERE !!!

  // Save bytes in the minified (but not gzipped) version:
  var ArrayProto = Array.prototype, ObjProto = Object.prototype, FuncProto = Function.prototype;

Why does it happen? How to solve?

If you're transpiling with babel, or using "use strict", the value of this will always be set to undefined, which is why root is undefined.  You need to do this differently.  This is not a problem with underscore.

@nestoremgi The problem might be present only with particular combinations of versions of openpay and underscore, so as a first stop, you could check whether you are using the same version in both projects. If not, try the version from the Astro project.
Otherwise, your best bet is a question on stack overflow, because this problem is probably not inherent to underscore but rather due to a bad interplay between multiple libraries and tools. If you go that route, make sure to include a reproducible example.


adding vulnerabilities from tinymce

snyk test failed, reviewed in snyk ui, decided the change is OK regardless, marked SCM test as pass


Basic support for docker 1.7 and 1.8

Docker 1.8 only has backwards support back to version 1.12.   As a result having /v1.7 and /v1.10 hard coded into the docker_via_api breaks centurion for newer versions of docker.  I upgraded the Centurion::DockerViaApi class to take another optional parameters api_version.  As of right now all the only place that initializes the class will pass a nil value into it and it will get set to v1.12. In the future it would be easily possible to allow specifying the api version via the cli ( I will leave that for a future todo)
Docker 1.7 also supports api version 1.2, so this changes allows support for 1.7 in addition to 1.8. I noticed in some of the issues that new relic uses 1.5 (? not 100% about that), which also supports the v1.12.  As a result this change should not break backwards support.
This PR also fixes https://github.com/newrelic/centurion/issues/131

This is really great! I'm going to test it a bit further with Docker 1.5 and get back to you.

Merged - thanks for the contribution!

:+1:


Create custom WalletConnect modal

Why
The default WalletConnect modal is not looking very good and caused some issues on Android sometimes. Having our own modal will also let us add Coinbase Wallet
How

Created a custom modal based on our design system

Test Plan
Run the native apps and try to connect your wallet
Screenshots

The native bottom actionsheet behaviour seen here too. https://www.rainbowkit.com/ (also checked it's source code). I think android doesn't support wallet connect URI with schema URLs. I'll open a discussion in rainbowkit.

Vercel build failed, I had this issue before too, maybe you need to move @walletconnect/react-native-dapp package to root, or fork this lib.


[Bug]: Evaluation errors don't show up when a page with existing evaluation errors is reloaded

Is there an existing issue for this?

[X] I have searched the existing issues

Description
__evaluations__ property doesn't have evaluation errors populated in it if a page with existing evaluation errors is reloaded.
Steps To Reproduce

Go to this DP https://appsmith-rl2cnfsls-get-appsmith.vercel.app/applications and DnD chart widget v2
In the Chart Dataset field, remove any comma from the json values and introduce a syntax error in that property.
Put a debugger in componentDidUpdate and check the props for evaluation key and notice that errors are present.
Refresh the page with the syntax errors and check the props again when the breakpoint is hit.
Observed behavior : Validation errors are not present in __evaluations__ field.
They are actually present in '__evaluations__ key.
Expected behavior : The evaluation errors should be present in __evaluations__ key

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

I think there is another scenario which is happening because of this bug.

Make validation errors on chart widget in the property pane.
Reload the page.
Click on the property pane input field which had the validation errors.
Observed Behavior : The red border on the property input field is missing and the pop up that shows the error message is missing.

Expected behavior : The red border and the error pop up should show up.

Please add your planning poker estimate with Zenhub @arunvjn

verified on page refresh -


Allow forwarding arguments to build_runner

There is currently no way to pass in extra arguments to build_runner like --symlink, --delete-conflicting-outputs and so on.
Adding a way for cached_build_runner to inherit the options of build_runner would be great to make it a drop in replacement

Good idea. Thanks for all of the suggestions!


Create gitlab pipeline to provision AKS cluster

Create gitlab pipeline to create AKS cluster and post provisioning steps

Upload kubeconfig artifact
Passing input variables on runtime.
Conditional execution of steps for create/destroy
Executing post provisioning steps such as installing nginx ingress controller and rancher.

Acceptance Criteria:-
Use existing AKS terraform files to provision AKS cluster.
Post provisioning steps to install Nginx Ingress controller and Rancher

Uploaded kubeconfig artifact - As a environment variable not able to access it, because in every stage new base image is creating, Instead of downloading kubeconfig in every stage, I need to come up with better approach.
Conditional execution - done
Executing post provisioning - few are in progress
Passing input variables on runtime - in progress

Facing an issue while installing post provision steps, looking in to those


[Speculative decoding] [Multi-Step] decouple should_modify_greedy_probs_inplace

Preparation PR for multi step. Not a blocker, but will make MS PR smaller and improve perf.
Decouple should_modify_greedy_probs_inplace from include_gpu_probs_tensor so that multi-step can set include_gpu_probs_tensor without also setting should_modify_greedy_probs_inplace and incurring the overhead of the probs modification (causes a GPU<>CPU sync). Not a blocker for multi-step, but does add ~1ms of GPU bubble between each step on A10G, will be a much bigger slow down on H100.
@cadedaniel This may be a perf bug for spec decode as well? I also can't seem to get spec_decode tests to all consistently pass locally?
Torch Profile with multi-step and without decoupling (should_modify_greedy_probs_inplace == True)

cc @WoosukKwon @zhuohan123 @Yard1 @comaniac @rkooo567

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Will take a look tomorrow.

By the way, what model is running in the profile ?

This is llama 8B, but the profile is with multi-step, which has removed all the other sources of CPU syncs (CPU prepare_input, GPU<>CPU transfer for sampled token)

Just added test for the inplace modification, let me know if there's anything else.