⚠ SceneTime has degraded performance

In cf41e07, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3199 ms

Resolved: SceneTime performance has improved in ff18604 after 6 minutes.


DOCS: improving documentation of add mesh link

@anur7 please update the branch and reply to the discussion.


Parameters - First Release

Main Story: https://github.com/Azure/bicep/issues/7301
First Release - Plans
Here are the features we're proposing for the first official release (combination of the "Summer" & "MVP" section - with some MVP pieces cut out). Most of the "Summer" work has already been completed, which is why it's not included here.
Basic Language Features
Code Completion and Navigation

[x] #9568 Add support for parameter names refactoring
[x] #9574 Add descriptions to parameter symbol completions
[x] #9575 Add support for displaying symbol type and description when hovering
[x] I can see an outline of all the parameters I have declared in the outline view of the explorer in VS Code
[x] I can get errors if set values are of the wrong type or do not follow constraints set by decorators as described in the Bicep template
[x] I can see the allowed values for parameters that utilize the @Allowed decorator
[x] I can use Go To Definition to jump to the location in the Bicep file where the parameter is defined
[x] I can use Find Ref to pull up a VS Code window that shows all references to a parameter (right click - find all references)

Environment Variables

[ ] #9576 Add support for environment variable values

Bicep Parameter File Generation

[ ] #10164 Add VS Code action to generate a Bicep parameter file
[ ] #10165 Create decompile functionality for params file

Compatibility with Current Tooling

[x] #9582 Add bicep parameter file support for Az CLI
[x] #9583 Add bicep parameter file support for Powershell
[ ] #9584 Enable current Deploy file action to read parameters file
[ ] #10386 Support all parameters for User-Defined Types with intellisense

Other

[x] Ensure we have icons available for the Bicep param files
[ ] Remove the feature flag once this is feature complete
[x] Update grammar libraries

If time permits

[x] Expression support (POC: https://github.com/Azure/bicep/pull/10248)

Was lead here from the docs on experimental features, but was a little hard to find an example of how to use the feature.
var storageAccountName = 'store${uniqueString(resourceGroup().id)}'

param location string

param kind string

resource sa 'Microsoft.Storage/storageAccounts@2019-04-01' = {
  name: storageAccountName
  location: location
  sku: {
    name: 'Standard_LRS'
  }
  kind: kind
  properties: {}
}

Just tried out this feature and while I obviously prefer the new syntax, I did run into a problem that I hope will be addressed.
Thing is, I have a few use cases where I pass some parameters inline with the Azure CLI instead of hard-coded in the param file.
This was working fine with JSON param files, since the parameter validation doesn't take place until the actual deployment, but with the new Bicep param files I now get an error that a required parameter is missing, which of course technically is true.
I realize I could simply add a dummy default value as a workaround, but that would also change the behavior of my template, since the parameter won't be mandatory anymore.
Is there or will there be an official way of supporting this?

@mattiasholm - I think #10454 captures the same problem, do you agree?

@alex-frankel
Yeah, a warning instead of an error would certainly make it less restrictive, without losing the validation entirely!
However, after testing some more I also noticed that the Azure CLI is currently blocking using --parameters repeatedly whenever a Bicep param file is used:
Can not use --parameters argument more than once when using a .bicepparam file

@mattiasholm, it is actually by design that we don't support inline parameters with bicepparam to allow for a simpler experience, but considering that it seems like several users have inline parameters as part of their deployment experience, we'll discuss supporting it by the first release! Thanks for letting us know

It's probably late to be asking this, however given the depreciation of inline parameters, would it be feasible to scope in the usage of the loadtextcontent|loadjsoncontent as part of the first release, along with the environment variable capability?
That would open up or unblock so many use cases for the bicepparam. Anyone could just transition code from inline/dynamic params to loadjsoncontent.

I can see use cases for allowing both inline params and environment variables in addition to param files.
This would also align well with Terraform, for those of us who are using both! 😊

It's probably late to be asking this, however given the depreciation of inline parameters, would it be feasible to scope in the usage of the loadtextcontent|loadjsoncontent as part of the first release, along with the environment variable capability?

doing more testing today and this does work already.

default.bicepparam 🟩
param Global = loadJsonContent('Global-Config.json')

Then also ...
build or just deploy already works 🟩
# works with 'loadJsonContent'
bicep build-params ".\default.bicepparam"

# no need to build (as above) since AZ 9.7.0 which includes az.resources 6.6.1, also works with `loadJsonContent`
New-AzResourceGroupDeployment -TemplateParameterFile ".\default.bicepparam"

I am sure I was using the same version 4 days ago and it wasn't working, however I am thankful for this 🥳🙏
for me below will be useful to replace dynamic params passed to New-AzResourceGroupDeployment
param Global = {
  global: loadJsonContent('Global-Config.json')
  regional: loadJsonContent('Global-AEU1.json')
}

I did some extra review of my dynamic param usage and I cannot move ALL of my dynamic params into the bicepparam file.
I am expressing interest to continue to allow usage of dynamic params along with the new bicepparam capabilities.

I did some extra review of my dynamic param usage and I cannot move ALL of my dynamic params into the bicepparam file.

Same. We are using common parameters like project and environmentName on out templates:

project is injected from common ADO variable group
environment is injected from environment-specific ADO variable group

For some templates we need to query existing properties of the resources and pass them as template parameters to avoid loosing state on re-deployment.
For some templates we need to query objects ids from AAD to pass them as template parameters.
For our projects current first release is a cool tech demo  but is not usable for production templates. At some point environment variable support will make things easier.

@jikuja

At some point environment variable support will make things easier.

I believe this is still scheduled in the first release.

It will be interesting to test once it's available, It's hard to say until then, all use cases that it might unblock.
Perhaps can set ENV var values dynamically, instead of passing params dynamically.

I believe Ben's goal is to do the following:
az deployment * create -f main.bicep --parameters params.bicepparam otherParam=foo

If otherParam exists in params.bicepparam, then what is passed on the command line would override it.

Thank you @stephaniezyen and confirming @alex-frankel example covers the scenario.
This is the current behavior in AZ cli and AZ powershell.
We are aware that this dynamic parameter pattern was not in scope for the first release of bicepparam, however a few people included myself do rely on this feature, so would welcome it back.
We will gain environment var ref in params, however I am not sure if it's a replacement for all dynamic param use cases.

I think personally think that support for
az deployment * create -f main.bicep --parameters params.bicepparam otherParam=foo

should be put on hold because same should be workarounded with
bicep build-params params.bicepparam --outfile otherParams.json
az deployment * create -f main.bicep --parameters otherParams.json otherParam=foo

Reasoning:

https://github.com/Azure/bicep/issues/10454 should be handled first. looks like it was triagad and unassigned. What was the decision?
the workflow with BCP258: Adding placeholder values on .bicepparams and then overriding then on command-line tooling requires extra work and I personally would like to avoid using placeholder values that might be masking missing required parameters

@jikuja
I believe the two ideas are directly related, just looking at it from a different perspective.

since if you want to provide param values dynamically on cli you wouldn't have them in the param file.

so that directly relates to the error, that we are looking to work around.

Given we don't actually have loadEnvVar() yet, it's harder to test ideas.
What if we had...
otherParams.bicepparam
using 'main.bicep'

param prefix = loadEnvVar('prefix')
param global = json(loadEnvVar('global'))

Then in your deployment, you can pass in those values and they override or get bound to ENV vars on the cli?
# az cli
az deployment * create -f main.bicep --parameters otherParams.bicepparam prefix=ACU1 global='[{"abc":123}]'

# powershell
$splatParams=@{
   prefix = 'ACU1'
   global = '[{"abc":123}]'
}

New-AzResourceGroupDeployment -TemplateFile main.bicep  -TemplateParameterFile otherParams.bicepparam @splatParams

Would it be functionally equivalent to what we have now i.e. what we have both asked for in this thread?
Not saying this specific syntax, just the general idea.

Has anyone been doing any testing with bicepparam ?
bicepparam file
using '../../bicep/01-ALL-RG.bicep'

param Prefix = 'AWU3'

param Environment = 'P'

param DeploymentID = '0'

param Global = {}

I am using PowerShell - Az.Resources Module - 6.7.0
Dynamic parameters and also overriding Global above appears to be working for me ?

This is the format that I currently use, that works... I tested some other formats that do not appear to work, however I haven't tested extensively.
example template - aaaas.bicep
param abc string
param global object

output abc string = abc
output global object = global

example bicepparam file - aaaas.bicepparam
using 'aaaas.bicep'

param abc = '123'
param global = {}

The way I do my powershell for dynamic parameters
$ResourceGroupName = 'AWU3-PE-AD-RG-P0'
$DeploymentName = 'mytest'
$TemplateParametersFile = 'D:\repos\ADF\ADF\bicep\demos\aaaas.bicepparam'
$TemplateFile = 'D:\repos\ADF\ADF\bicep\demos\aaaas.bicep'

$TemplateArgs = @{ }
$TemplateArgs.Add('TemplateParameterFile', $TemplateParametersFile)
$TemplateArgs.Add('TemplateFile', $TemplateFile)

$Global = @{ }
$Global.Add('test', 678)

$OptionalParameters = @{ }
$OptionalParameters['Global'] = $Global

$Common = @{
    Name          = $DeploymentName
    Location      = $ResourceGroupLocation
    Verbose       = $true
    ErrorAction   = 'Continue'
    ErrorVariable = 'e'
}

$Common.Remove('Location')
$Common['ResourceGroupName'] = $ResourceGroupName

New-AzResourceGroupDeployment @Common @TemplateArgs @OptionalParameters

DeploymentName          : mytest
ResourceGroupName       : AWU3-PE-AD-RG-P0
ProvisioningState       : Succeeded
Timestamp               : 6/19/2023 8:17:36 PM
Mode                    : Incremental
TemplateLink            :
Parameters              :
                          Name             Type                       Value
                          ===============  =========================  ==========
                          abc              String                     "123"
                          global           Object                     {"test":678}

Outputs                 :
                          Name             Type                       Value
                          ===============  =========================  ==========
                          abc              String                     "123"
                          global           Object                     {"test":678}


Add rule to check for dead links

Especially in areas like documentation this can happen as content gets reorganized, but can be difficult to spot. A rule which loads links listed on a page and flags if any of them returns a 404 could help.

@antross See https://github.com/sonarwhal/sonarwhal/pull/1104.

Thanks. Awesome to see there's already a PR in progress!


better reason for Y074

change for issue #316

About this, I don't understand why it's a good practice to use elements AND attributes directives.
I only use attributes, mainly for compatibility between Angular 1.2 and IE 8 and also because I think it's better not to mix custom elements and attributes for a coherent code.

@tomahim, so all of your directives work with all possible tags and they always alter them in some way? Sometimes you just need a whole other kind of tag, and then you use an element directive.

@dietergeerts yeah I see what you mean. No problem with attributes as I'm using my own directive, but I agree it's not perfect if other people should use it.
Still have no choice for IE issue :)

i dont think they are easier to identify. i think they are more useful. elements represent an element that may be used and attributes are ideal when a directive enhances an existing element.

I'm not sure why a directive should serve both in element and attribute position. If the directive acts like a web component (e.g, as a semantic tag or a substitute for an HTML element), I'd mark it for use exclusively as an element and it would likely have isolate scope. If it modifies behavior, I'd make it an attribute directive and would be unlikely to give it isolate scope
I haven't found the need for a class or a comment directive. I could see writing a class directive if it served a styling purpose and seemed more natural to apply as one would a CSS class.
The comment directive was useful before they added -start and -end to ngRepeat. These features enable HTML scenarios that could only be implemented with the comment directive previously.
This is how I roll.


MTLloader conflict?

Hi.
After installing drag-controls and reloading, my scene starts throwing this error:

ERROR TypeError: Cannot read property 'elements' of undefined

I am able to load simple objects and apply textures to them but loading mtl throws this error

Hello @johnywind
I'm not sure what could be causing the error, because in the drag-controls source there is no reference to a property elements. It's possible the issue is not in the drag-controls module but in the combined use with MTLloader.
Could you please provide some more context (e.g. a code sample, or a description of what you are trying to accomplish)?

This is the full error:

core.es5.js:

1020 ERROR TypeError: Cannot read property 'elements' of undefined
at Matrix3.copy (three.module.js:3279)
at refreshUniformsCommon (three.module.js:23167)
at setProgram (three.module.js:22943)
at WebGLRenderer.renderBufferDirect (three.module.js:21783)
at renderObject (three.module.js:22544)
at renderObjects (three.module.js:22514)
at WebGLRenderer.render (three.module.js:22276)
at render (app.component.ts:635)
at ZoneDelegate.invokeTask (zone.js:424)
at Object.onInvokeTask (core.es5.js:3881)
I just installed drag-controls via npm, didn't even have the chance to import it into my object.
However, after install I notice a change in package-lock.json on all modules:
"integrity" changed from sha512 to sha1.
So in all fairness, it might have something to do with my npm version / settings. I will look into it more and get back to you

So in all fairness, it might have something to do with my npm version / settings. I will look into it more and get back to you

Please do.
From the stack trace it doesn't look like the problem is in the module, but I'll take some time at the end of the week and write a simple app that uses drag-controls and MTLloader to see if I can reproduce the error.


[Feature Request] Support a special "cancellation" throw inside useEffect

Simple as that, could see it like this:
import { useEffect, CancellationError } from 'react'

const App = () => {

  useEffect(() => {
     throw new CancellationError('Valid cancellation')
  }, [])

  return null
}

This would then not propagate the error, and it would also allow you to see the cancellations using a debug flag or in the React devtools.
Upside would be allowing the common invariant or assert pattern inside effects, which would make for much nicer early-returns that include messages for debugging exactly why an effect returned early.
Perhaps this exists already internally?

Hi, thanks for your suggestion. RFCs should be submitted as pull requests, not issues. I will close this issue but feel free to resubmit in the PR format.


Configure printing during test_package

Hey there!
Now that I use JET for testing my packages, my overall happiness has increased. However, most of my test output now consists of
[toplevel-info] analyzing from top-level definitions (839/1681)

Is there a way to get rid of that?

You can give toplevel_logger = nothing configuration. It probably should be default for test_package though.

Thanks!


NSLocationAlwaysUsageDescription issue due to dependencies

What's happening?
When submitting to app store, I am getting a NSLocationAlwaysUsageDescription error.
How can it be reproduced?
n/a
Build details?
seeing this in 1.0.1
My suggestion would be to either build a camera-permissions only package and depend on that, OR handle camera permissions in your code directly

Looking at the code it seems like the author invoked only the camera permission from that package. Does your app uses GPS? Maybe you're mixing the problems.
PS: I just downloaded the lib and was looking about the issues in this repo, don't take my word for experience with this lib, I'm just trying to help :D

Accepting PRs to fix this issue :)

I was also looking into this, as I got all the permission errors on app store submission, and found this thread.
Looking into the react-native-permissions package, they seem to be aware of this issue and explain it a bit more in the README stating that these permissions won't actually be shown to the users unless you really require them in your app:
https://github.com/react-native-community/react-native-permissions#app-store-submission-disclaimer
There is also an issue about this exact problem over there, with some proposed solutions, although nothing was done about it and it seems like no further plans to address it:
https://github.com/react-native-community/react-native-permissions/issues/46
I know this isn't a solution to this thread, but at least I can relax a bit knowing that users won't have the impression we're requiring all these permissions we're not actually using. I think that is enough for me for now

thank you for this disclaimer about this issue @poltak, it really helps!

First of all, this is not an issue in react-native-qrcode-scanner because it's totally related to the react-native-permissions package as the
@poltak told it above and as he shared with us, you can take a look in the following thread to take some help with this problem https://github.com/react-native-community/react-native-permissions/issues/46
By the way, it was a really good disclaimer about it, so thanks for that @poltak.
But anyway, I took a deeper look into it to understand better the thread around this issue related to this one and what was going on over there to work or maybe share a workaround for that in our side. But I realized that it's a problem already solved since version >2.0.0 as described in the following comment https://github.com/react-native-community/react-native-permissions/issues/46#issuecomment-532990603.
So, using the latest version of react-native-permissions, or just since the v2.0.0 version, everything should be working fine.
Then, no more reasons to keep this issue open, so I'll be closing it!
In the case of face a related problem, where the permissions are not working properly well as expected on using this package, please, open an issue in the https://github.com/react-native-community/react-native-permissions instead.


Interactive Elements

Focused on improving some of the interactive elements. Style changes are as follows:
Nav bar:

hover and active state on avatar
hover on notifications
dropdown fixes
increased height of bar slightly
changed default avatar color (included 1kb .png version) needs to be set as default

Reading:

Widen reading area, we can get away with 12 words per line on average

Editing:

repositioned image icon and added hover state

Stylesheet efficiency:

Added Mixin for box-shadow
Created variables for radius and applied through all stylesheets

Awesome! I especially liked the hover and active state on avatar image in the header. I started working on the Editor to add more features. Current implementation is a bit hacky but I'm planning on improving it incrementally. Anyways thanks for this pull request! Awesome work :+1:


[Feature request] ANSI and Syntax coloring

Can you add ANSI and Syntax coloring (Normal, C++, Java, etc.)??

I want that , too
This is a beautiful editor

Not in my plan for the very near future.


Document flogo environment variables

Document environment variables used in the flogo engine

Yes @vijaynalawade you are right, I am changing them to _ instead


Support bezier and quadratic curves

can this be closed? https://pursuit.purescript.org/packages/purescript-canvas/3.0.0/docs/Graphics.Canvas#t:BezierCurve

Yes, thanks!


no data uploaded

Hi all,
I am just experimenting cpp-coveralls with a Fortran project.
On my local Linux box it works great, but when it has been used on travis-ci no data are uploaded to the coveralls.io server.
Project details:
home: https://github.com/szaghi/BeFoR64
travis.yml:  https://github.com/szaghi/BeFoR64/blob/master/.travis.yml
travis log: https://travis-ci.org/szaghi/BeFoR64/builds/52415236
coveralls log: https://coveralls.io/r/szaghi/BeFoR64
As you can see, some previous uploads to coveralls have been done correctly (e.g. the one with 89% coverage), but these have been done directly from my box with the token passed explicitly with -t.
I suppose that the problem is related to the use of -b switch. Can anyone help me to fix this problem?
Thank you very much for your great cpp-coveralls.

@szaghi I think the issue is that gcov will segfault if it’s version doesn’t match that of gfortran. In your .travis.yml add sudo apt-get install binutils somewhere after you add the toolchain-r/test PPA to upgrade gov and then after that another line like: sudo ln -fs /usr/bin/gcov-4.9 /usr/bin/gcov
I think that might fix your issue. I just got this working myself for the json-fortran project and that was my issue, although I explicitly call gcov because I only want coverage for one file and then pass the -n flag to coveralls

@szaghi and @zbeekman  coveralls also have a parameter --gcov to specify the gcov you are using.
So you can run coveralls --gcov /usr/bin/gcov-4.9 directly without making the links to mass up your system.

ah yes, that’s right… but in my case “my system” is just “travis-ci” which is a virtual machine that gets thrown away after the build, so i don’t care about adding symlinks like that… @eddyxu btw I was having trouble with the exclude flags… which is why I just run gcov directly and then coveralls -n … so that coveralls doesn’t run gcov for me anyway


Does not support Pylint's Parallel execution

False possitives will appear when pylint's jobs setting is != 1.
https://pylint.readthedocs.io/en/latest/user_guide/run.html#parallel-execution
This happens when running against a project rather than a single file.

What version of pylint are you using? I've tried reproducing this on some of my larger projects with different values set for the number of pylint jobs and haven't been able to get any false positives to show up. Are you using a non-default config for pylint-quotes? (all my testing was done using the default config)

I'm using:
pylint==1.8.2
pylint-quotes==0.1.9

Let me try to put a simple example together.


Selector not working anymore

google-search version: 1.1.1
Python version: 3.8
Operating System: Ubuntu

Description
For a couple of days now, search has not been working, this is due to a failing selector:

It would be nice if we could be able to override the constants. Currently, they are bound to GoogleSearch class. So if we try to extend the class, it still doesn't change the functionality since the class attributes are accessed using GoogleSearch. instead of self.

This happens to me as well. Can you also fix the selector so the example will work?


[AVM Module Issue]: Data Factory module should support tenantId parameter in git configuration

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
Module Name
avm/res/data-factory/factory
(Optional) Module Version
No response
Description
It's not possible to use an Azure DevOps organization that's in a different Entra ID tenant from the Data Factory for git integration.
A new parameter, gitTenantId should be defined that allows specifying the tenant ID for the Azure DevOps organization.
Default value could be the tenant ID of the current deployment scope.
The value can then be used in the optional tenantId property of the FactoryVstsConfiguration object:
https://learn.microsoft.com/en-us/azure/templates/microsoft.datafactory/factories?pivots=deployment-language-bicep#factoryvstsconfiguration
(Optional) Correlation Id
No response

I have reached out to our product group. I will await to now hear back from them. Give this a week please. Thank you

I just want to add my experience to the issue @MarkFarkas addresses here, because I have had a (vaguely) similar issue before with Synapse workspace deployment (see #1679 ).
In my experience, there are a few different issues:
1 the current parameter set do not provide full control of setting the repo config: the tenantId and lastCommitId parameters are missing. when not provided, it just randomly redirects to an MFA login (i am a guest user on multiple organizations) whenever trying to open the data factory studio.
2 using the default settings of the template (leaving out the repository config), the manually configured repository config is overwritten (thus, the config is removed, and you have to reconfigure the repo config after each data factory infrastructure deployment)
3 (suggestion) the parameter set should be a user defined (object) type and the gitConfigureLater parameter should be removed.
Adding to the suggestion, currently, this is how I have the git related parameters configured. This is based on the same structure as Synapse workspace repoconfig in the AVM. (for your information: I create a module on top of the AVM which uses a user defined type to provide values for the git related parameters):
    gitAccountName: repoConfiguration.?accountName
    gitProjectName: repoConfiguration.?projectName
    gitRootFolder: empty(any(repoConfiguration.?rootFolder)) ? '/ADF': repoConfiguration.?rootFolder
    gitRepositoryName: empty(any(repoConfiguration.?repositoryName)) ? 'ADF' : repoConfiguration.?repositoryName
    gitCollaborationBranch: empty(any(repoConfiguration.?collaborationBranch)) ? 'development' : repoConfiguration.?collaborationBranch
    gitRepoType: empty(any(repoConfiguration.?type)) ? 'FactoryVSTSConfiguration' : repoConfiguration.?type```

I agree with Kathedra about providing more control over the git configuration of the workspace.
Because this issue was blocking me (and because the AVM module overwrites the git configuration when the parameter is not provided), I created the following module that I deploy after the AVM module deployment as a workaround:

param adfName string
param gitAccountName string
param gitProjectName string
param gitBranchName string
param gitDisablePublish bool
param gitRepositoryName string
param gitRootFolder string
param gitTenantId string
param resourceTags object
param resourceLocation string = resourceGroup().location

resource adfGitConfig 'Microsoft.DataFactory/factories@2018-06-01' = {
  name: adfName
  tags: resourceTags
  location: resourceLocation
  properties:{
    repoConfiguration: {
      type: 'FactoryVSTSConfiguration'
      accountName: gitAccountName
      projectName: gitProjectName
      repositoryName: gitRepositoryName
      collaborationBranch: gitBranchName
      disablePublish: gitDisablePublish
      rootFolder: gitRootFolder
      tenantId: gitTenantId
    }
  }
}

I'm using this module because I really wanted to avoid forking the AVM repo or creating a custom module myself.

@Kathedra , I was actually not aware of the importance of the lastCommitId parameter. My workspace has publishing from ADF Studio disabled and this parameter is not used for anything else as far as I am aware.
I'm using an Azure DevOps pipeline to redeploy the workspace when a change is made to the template so if I had to use the parameter, I would run an Az Powershell task to retrieve the current value from the workspace and provide the value to the bicep template.

Hey guys. I am looking to add lastCommitID to the parameters. I will add this fix soon. This may go some way in helping.

personally I prefer a solution that also gives us the ability to manually configure the repository settings, as mentioned in my 2nd issue. This way, Bicep does not handle the config and doesn't overwrite it. Any quick fixes for that @clintgrove?


METRON-2294: [UI] Fixing Stale mode issue in Alert UI Manual Query Mode

Contributor Comments
Problem
Go to
/alert-list
Switch to Manual Query
Switch to Query builder, and switch back to Manual Query
Type something in the timestamp filter textbox.
No StaleMode warning appears.
Cause
In alert-list.component
manualQueryInputEl needs to be undefined to indirectly fire addManualQueryFieldChangeStream() which is responsible to change the staleDataState.
But It's already defined when we switch from the Query Builder to Manual Query mode
Solution
I have removed the condition of manualQueryInputEl being undefined. And it works fine.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[X] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[X] Have you included steps or a guide to how the change may be verified and tested manually?

[X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

[ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Looks good to me too. +1. Tested with full dev. Thanks for fixing this bug, @subhashjha35!


chore: move controllers to separate packages

This PR

moves controllers to separate packages
moves common functions/constants into separate common package
migrates ginkgo controller tests to basic unit tests
migrates featureflagconfiguration admission webhook ginkgo tests to basic unit tests
additional unit tests for controllers

Related Issues

Fixes #393 #394

Can you tell us why this is a good idea perhaps? I've not touched this code in a few months and the delta seems large.

This PR is going to be split into 2 due to the size

Split of the PR completed, the follow-up PR with additional refactoring and unit tests will follow up

I like the splitting of the controllers package, nice

Thank you!

I'll give this a thorough review tomorrow!

Thank you!


Create custom page or content block for "Training"

Currently, the gray background color of the training units is realized with custom HTML entered in the editor:

The result looks like so:

The custom HTML is not visible in the WYSIWYG view of the editor, with the risk of being deleted by mistake. This leads to missing background.

A custom Content block that allows you to easily set the background color would be handy.

So, something like this?
Editor:

Result:

Btw. There is an Emoji database which also includes symbols/icons: https://emojidb.org/
These emojis can be copied and inserted in the content editor


FT-M for batch edit?

I have tried editor.edit  for FT-M, and got excellent results. But when using editor.batch_edit ( batch size = 100), I got poor results. Is this method not adapted for batch edit, or does it require configuration changes (except batch size) compared to single edit?

The code doesn't support batch editing. We're trying to enhance it and will let you know when we finish.

Our code does support batch processing for FT-M. I suspect that the results you observed may be due to either using a batch size that is too large or not setting the objective_optimization field to 'prompt_last.' You could try reducing the batch size and adjusting the setting to see if that improves performance. If you need further assistance, feel free to share your FT hyperparameter configuration, and we would be happy to help.

Our code has supported batch processing for FT-M. I suspect that the results you observed may be due to either using a batch size that is too large or not setting the objective_optimization field to 'prompt_last.' You could try reducing the batch size and adjusting the setting to see if that improves performance. If you need further assistance, feel free to share your FT hyperparameter configuration, and we would be happy to help.

But 'prompt_last.' is not for FT-M,
# "prompt_last" corresponds to the results of FT-L.
# "target_new" corresponds to the results of FT-M.

Our code has supported batch processing for FT-M. I suspect that the results you observed may be due to either using a batch size that is too large or not setting the objective_optimization field to 'target_new'. You could try reducing the batch size and adjusting the setting to see if that improves performance. If you need further assistance, feel free to share your FT hyperparameter configuration, and we would be happy to help.

I have already sloved the promble by myself, thanks for you reply


app produces invalid YAML

Hey! I noticed that the frontmatter that is produced by the app is actually invalid, because @ is a special character in YAML and text that starts with an @ must be quoted (see here).
For example:
---
author: Josh ✨
handle: @JoshWComeau <-- should be "@JoshWComeau"
---

That's great to know! Let me get a fix out for this.

@biowaffeln I've published version 1.4.2 to resolve this issue. Thanks for the feedback!


error with logs

Hello! I recently installed this datapack and when tried the crimson wood would give me both the warped and crimson, and when tried the warped didn't show any, probably just a little mistake, but it would be great if you could fix it.
Thank you
Edit: I'm pretty sure the problem is stripped_warped_stem_from_warped_stem_stonecutting.json

Sorry for that extremely long wait for such a simple fix - this has been very low on my todo list. New version should be out now, along with a 1.20 update to support bamboo/cherry wood!


Archive search not working by year

No results when searching by year on archive page. No errors

This is not implemented and not very important so just removing it


[ci] update docker image from ubuntu 18.04 to 20.04

Motivate of the pull request

[x] To address an existing issue. If so, please provide a link to the issue: #832
[ ] Breaking new feature. If so, please describe details in the description part.

Describe the technical details
What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[ ] OpenFPGA libraries
[ ] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[ ] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

Merge now as base docker image requires an update. Will debug if failed on master.


Add CI to validate index.json

This PR adds a script and some CI workflow files to automatically validate the data/index.json file. It does this for pull requests and on merging to main. It also runs the workflow on a weekly basis to catch errors caused by the schema changing in the main HealthGPS repo (while published schemas shouldn't change, we might change things while things are under development).
Once I've added JSON schemas for the config files, hopefully we can reuse some of this infrastructure to check the files in the examples repo too.
Closes #3.

Superseded by #5


Allow configuration of built in source transformers.

Hey,
We needed the ability to configure the istanbul transformer, specifically so we could tell it to use of ES6 modules when requiring (by passing through esModules: true).
I thought this might the best and most backwards compatible way of doing it - you can now specify configuration when registering a built-in transformer, and calling register for the same transformer after that will simply override the previous configuration. For the coffee transform, this configuration is passed straight into the compile call, and for istanbul this configuration is copied, then used to help detect if coverage is running (in case a custom coverageVariable is specified), then passed into the instrumentation call.
You can see I've not added any unit tests - I'll be honest, I wasn't sure the best way to test this. At least for the istanbul transformer, the instrumentation doesn't appear to be mocked, so there's not a nice way to check whether config is passed on. If you would like tests to be added I'd be happy to, with a little guidance.
Cheers!

I see the failure, I'll try to get that sorted.

Tests fixed. If you can offer any guidance on whether/how you want to test config being passed down, that would be great, but either way I will try to find time to write some.

I don't have much time to review these patches these days, and it seems like the other maintainers don't either. In the past @felixge has been willing to add new collaborators for cases like this; would that work for you?

I'd be happy to add @mickylad as a collaborator.

Super slow response, sorry! I'm happy to be added as a contributor if you want - anything you need from me?

@mickylad slow reply from me too :). I need your npm user name so I can add you as an owner.

@felixge itsmickylad - just signed up! :)

@mickylad added you on GH and NPM.


[cordova-res] /opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/lib/constructor.js:34 throw new Error(error); ^ Error: Something went wrong installing the "sharp" module

Running on Macbook M1, Ionic 5, when I run "ionic cordova resources"
Did you see the documentation relating to installation? Yes
Have you ensured the architecture and platform of Node.js used for npm install is the same as the architecture and platform of Node.js used at runtime? Yes
Are you using the latest version? Is the version currently in use as reported by npm ls sharp the same as the latest version as reported by npm view sharp dist-tags.latest? Yes
If you are using npm v6 or earlier and installing as a root or sudo user, have you tried with the npm install --unsafe-perm flag? Yes
If you are using npm v7, does the user running npm install own the directory it is run in? Yes
If you are using the ignore-scripts feature of npm, have you tried with the npm install --ignore-scripts=false flag? Yes
What is the complete output of running npm install --verbose sharp? Have you checked this output for useful error messages?
> cordova-res
[cordova-res] /opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/lib/constructor.js:34
[cordova-res]   throw new Error(error);
[cordova-res]   ^
[cordova-res]
[cordova-res] Error:
[cordova-res] Something went wrong installing the "sharp" module
[cordova-res]
[cordova-res] dlopen(/opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/build/Release/sharp.node, 1): Symbol not found: __ZTVN4vips7VOptionE
[cordova-res]   Referenced from: /opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/build/Release/sharp.node
[cordova-res]   Expected in: flat namespace
[cordova-res]  in /opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/build/Release/sharp.node
[cordova-res]
[cordova-res] - Remove the "node_modules/sharp" directory then run
[cordova-res]   "npm install --ignore-scripts=false --verbose" and look for errors
[cordova-res] - Consult the installation documentation at https://sharp.pixelplumbing.com/install
[cordova-res] - Search for this error at https://github.com/lovell/sharp/issues
[cordova-res]
[cordova-res]     at Object.<anonymous> (/opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/lib/constructor.js:34:9)
[cordova-res]     at Module._compile (internal/modules/cjs/loader.js:1063:30)
[cordova-res]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
[cordova-res]     at Module.load (internal/modules/cjs/loader.js:928:32)
[cordova-res]     at Function.Module._load (internal/modules/cjs/loader.js:769:14)
[cordova-res]     at Module.require (internal/modules/cjs/loader.js:952:19)
[cordova-res]     at require (internal/modules/cjs/helpers.js:88:18)
[cordova-res]     at Object.<anonymous> (/opt/homebrew/lib/node_modules/cordova-res/node_modules/sharp/lib/index.js:3:15)
[cordova-res]     at Module._compile (internal/modules/cjs/loader.js:1063:30)
[cordova-res]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)

What is the output of running npx envinfo --binaries --system?
internal/bootstrap/switches/does_own_process_state.js:129
    cachedCwd = rawMethods.cwd();
                           ^

Error: ENOENT: no such file or directory, uv_cwd
    at process.wrappedCwd (internal/bootstrap/switches/does_own_process_state.js:129:28)
    at process.cwd (/opt/homebrew/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:10:19)
    at new Config (/opt/homebrew/lib/node_modules/npm/node_modules/@npmcli/config/lib/index.js:90:19)
    at new <anonymous> (/opt/homebrew/lib/node_modules/npm/lib/npm.js:74:19)
    at Object.<anonymous> (/opt/homebrew/lib/node_modules/npm/lib/npm.js:59:30)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'uv_cwd'
}

Please see https://sharp.pixelplumbing.com/install#apple-m1 and #2460. You may also need to run brew update && brew upgrade.

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

Hello,
I am running on Macbook M1, Ionic 5 and tried to install cordova-res but I was having this same exact problem.
I was able to solve this error by following the links mentioned by @lovell and then running brew install vips
Hope this helps.


"" tag seems to have been already abolished.

at page http://www.openfl.org/documentation/projects/project-files/xml-format/

use this
<set name="ANDROID_INSTALL_LOCATION" value="auto" if="android" />

referece:
https://github.com/openfl/lime/blob/ef86c425b1f6d01f7b016fc5e1f4df5260a35766/lime/project/ProjectXMLParser.hx#L774

Does this work?
<config:android install-location="auto" />

@jgranick yes both your code and mine worked

Okay, good :smile:
The <config:android /> or <config:ios /> tags are to replace the <android /> and <ios /> tags (which I never liked), though for backward compatibility, this should be fixed.
It's not perfect yet, but <config /> can hold custom unstructured data, which could help us config a lot more things in the future :smile:

I've updated the page:
http://www.openfl.org/learn/resources/command-line-tools/project-files/xml-format/
We need to set up redirects, though, from the older "/documentation" links


Saving timezone in My Profile should save the timezone into localStorage

Currently the timezone is only saved to localStorage upon login, in OAuth.js as "authentication/timezone".  This should be saved when save is clicked for the timezone update.

I am going to handle this in PR #1837


Milestone v1.4

Coverage decreased (-0.04%) to 88.84% when pulling b68138a7d08dce30d5c3e33816f337ee17103231 on jasonvank:milestone-v1.4 into 553f10458dcc5d26c67329f4783994f0065e39fc on CS2103-AY1819S1-T12-4:milestone-v1.4.


Required Deovi improvements to enhance usefulness

Django Deovi should avoid to introduce fields that are only edited from the admin instead of Deovi dump.
The most relevant example is that dump cannot reflect directories/files movements and deletion. This will probably painful to manage when changing these things on device and also in the admin each time.
So it seems that the Deovi dump should be the most recommended way to manage all changes, so the user can simply flush all data and just import an up-to-date dump.
So we should list some improvements in Deovi that Django Deovi could then implement.
Here is a starting list:

[x] The "device" concept, currently Deovi does not have any, it just collect directory with files from a given basepath;
[x] Discovery of directory manifest. Manifest will be a "manifest.json" file inside the directory where we can store informations to collect and store in django deovi database, like a real title, tags, etc.. Just to start the title will be enough;
[x] Directory thumbnail discovery, by default it will search for a "cover.jpg" or "cover.png" file, manifest may be able to specify another filename or path to search for;

When Deovi will create a dump, it will have to base64 the image content to store it in JSON. This will be nasty to read in JSON and will produce bigger dumps but at least the dump will self sufficient and no image file will have to be transported.

Video file metadata collecting has been moved in its own Deovi issue here: sveetch/deovi#6


Remove workflow Snapshot generated table files

The generated table was not fully removed after removing the snapshot feature in #1695. I simply rerun codegen with the current DDL.

what is the reason we remove those files? please specify in the PR description, and link to related PRs/issues if there are any.

Updated the description.

Updated the description.

Thanks!

The generated table was not fully removed after removing the snapshot feature in #1695. I simply rerun codegen with the current DDL.

Ok got it. So the #1695 should actually do this code gen (whenever the ddl is being changed).
The PR DID do the code gen to remove the tables (please refer the the PR). However, for some reason the update was done on only the execution table and not the snapshot table.


Guide to running showcase locally is missing a step

The steps provided are:

Clone this Git repository.
Run gradle build wicked-charts-showcase-wicket7:bootRun inside the showcase directory (change wicket7 to wicket14, wicket15, wicket6 or wicket8 for the different versions).
Go to localhost:8080

but if you follow these steps diligently it can't work because it needs another step in between 1 - 2, (step 1.5 :) ) which is this:

5  At the base directory of the project build the entire project using
gralew build

Without first building the project from the base directory the showcase will be missing most of its core dependencies.
I also suggest using gradlew instead of gradle because the project seems to specify Gradle 4.10 and people with later versions may not have much luck unless gradle wrapper is used to run the older version.
BTW - Great library - I'm achieving great things with it in a very small amount of time!

Thank you for the positive feedback and for pointing out the mistake. I've updated the guide now.

Thank you for the positive feedback and for pointing out the mistake. I've updated the guide now.

No problem. Thanks for providing this Wicket wrapper for Charts.js and making it so easy to use.


Remove allow_auto_merge from ignored fields

I tried applying allow_auto_merge using safe-settings though nothing happened. I then issue https://github.com/github/safe-settings/issues/318 and tried to change the code myself.
Removing it from ignoredFields make the allow_auto_merge setting to be applied properly.
I have to admit that I don't understand how the code works, but this change solves our issue. It is also possible that more things should be removed from the ignored list.

@gylph-se thank you for raising this PR, it looks like we can remove a few more items from the ignorable fields list. I'll need to test these and so will take me a few more days to merge this.


Create Azure Function with SQL Binding does not quote paths when adding project reference

Repro Steps:

Create a folder on Windows with a space in the name i.e. "Bindings Test"
Create an Azure Function project in that directory using the "Azure Functions: Create Function..." palette command.
Open a connection to a SQL server, then right click on a table to create an Azure Function with SQL Binding.
An error like the one below will be thrown, which has a project path that isn't quoted, causing the associated dotnet command to fail.

Error creating new Azure Function: Command failed: dotnet add \Users\corivera\Downloads\Bindings Test\Bindings Test.csproj package Microsoft.Azure.WebJobs.Extensions.Sql --prerelease
Unrecognized command or argument 'Test\Bindings'
Unrecognized command or argument 'Test.csproj'

It also doesn't include the drive letter in the path on Windows, which might cause problems if you're trying to reference a project on a different drive from vscode.


There isn't an appropriate role to list all the catalog services in group but list only owned services

As a user I want to list/use all the service catalogs in my group but only want to see only the services deployed by me. Rightnow there isn't a way achieve this flow.
Matrix discussion link - https://matrix.to/#/!fNWKLobuKKpFTwgXzO:gitter.im/$NXWkd1YY_tzWWvyt9dGtowOtkerfIbB6K1NANtD79XM?via=gitter.im&via=matrix.org&via=grare.com

The scenario is that user A and B are part of group G and I have shared set of service catalogs for that group and both users ordered the services, e.g: user A ordered a service S1 and user B ordered a service S2 and per current setting what I see is that both user A and B sees service S1 and S2, can operate(retire) other's service as well. So my use case is user A and B should list all the catalogs in group G but user A should see only S1, user B should see only S2.
I tried setting the option as user created scope which solved partial problem where I was able see only what user created but user was not able to see the catalogs which are created by the admin.

The newly created resource will get the group of the requester or the service.
If the catalog is owned by the group of A and B, then yes, this will be assigned the shared group. And yes, this sounds different from what you want.
If the service catalog is owned by a parent tenant, does the service get the parent tenant's default group, and get you what you want?

@kbrock

If the service catalog is owned by a parent tenant, does the service get the parent tenant's default group, and get you what you want?

Is it possible to set the catalog owner to a tenant? Looks like ownership can only be set to a user and/or group:

I was pretty sure catalog could be set to tenants, but apparently not.  @kbrock ?

You need to set it to a group from the desired tenant. Then it will get the tenant from the group.
But that drop down does not show the tenant's default groups. (This could be a bug)
If you create a group in your desired tenant, will it show up in the drop down?

@kbrock I think I'm getting a bit closer, but am not quite there yet. I'm running on an manageiq-libvirt-oparin-1.1.qc2 appliance. Here's my config:
I created a "child-tenant", which is a child of the default "My Company" tenant:

Then I created "child-tenant-group" and assigned a couple of test users:

The group is using the out-of-box "EvmRole-user_self_service" role:

Now I've created a service catalog item that is owned by the "EvmGroup-user_self_service" group (which is one of the groups that comes under the default top level tenant). I also check the "child-tenant" box under the "Additional Tenants" section. I'm not sure if this is correct since my test users don't belong to this group. The problem is that Tenant seems to be set by the group ownership, so if I set the service catalog item is owned by "child-tenant-group" group it is also owned by the "child-tenant" tenant.

With things setup as shown in the screenshots above the test users don't have access to the service catalog item.
Any ideas? This test env is still up - I'm happy to provide connection info privately if you want to go play around @kbrock.

@mkumatag I discussed this with @Fryguy and team earlier this week. Since there is a single role access restriction set for catalog items and vms (among other things) we don't think it's possible to assign catalog items to a group but restrict the created VMs to a single user 😞:

So I think the next step will be coming up with an enhancement/refactor to allow finer access restriction settings. @Fryguy: was there anything else from our discussion that I missed?

So I think the next step will be coming up with an enhancement/refactor to allow finer access restriction settings. @Fryguy: was there anything else from our discussion that I missed?

:( Is there any stopgap solution at the moment to workaround the issue, because enhancement/refactor will take more time sure.

Maybe something like this could work:

Assign users to a role with Access Restriction = Only User Owned
Create a service catalog item to use as a template from which to make copies
For each user, create a copy of the service catalog item with ownership set to the user (instead of group)

If you have too many users to manage this through the GUI, perhaps we could script automation through the Service Management API

Maybe something like this could work:

Assign users to a role with Access Restriction = Only User Owned

Create a service catalog item to use as a template from which to make copies

For each user, create a copy of the service catalog item with ownership set to the user (instead of group)

If you have too many users to manage this through the GUI, perhaps we could script automation through the Service Management API

hmm.. This is a tedious job sure, I may need to have a script always looks for a new user and keep doing this for newly onboarded user.. Users being managed via keycloak will create scenario even more complicated!

@jaywcarman Wondering who can help us creating that enhancement to enable this feature?

So I think the next step will be coming up with an enhancement/refactor to allow finer access restriction settings. @Fryguy: was there anything else from our discussion that I missed?

The fundamental problem is that the Access Restriction encompasses multiple types of objects

Access Restriction for Catalog Items, ... , VMs, and Templates

The way to enable this type of change would be to split this setting apart, either into related groups or perhaps individually.  However, this is a deeper enhancement and will take some time to fix.  Changed this from bug to enhancement.

Reopening this issue because the change in https://github.com/ManageIQ/manageiq/pull/22573  is backend only, but there's no way to change that value in the UI as of yet.

@jaywcarman Will you also be working on the frontend changes?

@jaywcarman Will you also be working on the frontend changes?

Yes: https://github.com/ManageIQ/manageiq-ui-classic/pull/8833

closed via https://github.com/ManageIQ/manageiq-ui-classic/pull/8833


SSO Login - wrong account or email selected

Describe the problem
netbird up - I selected the wrong email this morning and cannot connect to netbird because I cannot figure out how to force netbird to allow me to select the email again.
To Reproduce
Steps to reproduce the behavior:

have 2 linked gmail accounts, one previously associated and logged into with netbird and one not.
Go to command prompt
netbird up
website opens in browser
Select the email not associated with netbird
I sat on the next screen wondering what to do.  No option to reselect email or go back.  I finally did something I am no longer sure what action I took.

Now when I run "netbird up"
results:
SSO Website:
Login successful
Your device is now registered and logged in to NetBird.
You can now close this window.
command prompt:
Error: waiting sso login failed with: rpc error: code = PermissionDenied desc = invalid user

I would really like to know what command I can run - or what file to update - to force netbird up to ask me to select the email again.

The website should not say "Login successful" when the terminal response is: "Error: waiting sso login failed with: rpc error: code = PermissionDenied desc = invalid user"

I have hunted across pages of https://docs.netbird.io/how-to but I am unable to find how to force a reselection of the email.
tags I would add if I knew how:
login
email
account

hello, can you delete your peer and then logout from the dashboard before issuing netbird up please? This will cause the peer to be deleted from that account and after the dashboard logout, it will no longer use the session information to login automatically again; can you give it a go and report back?

How do I delete the peer?
I have only ever used command prompts for this.  How do I access the dashboard?

While I am good, I do believe this behavior is inconsistent, misleading and possibly unhelpful.
results:
SSO Website:
Login successful
Your device is now registered and logged in to NetBird.
You can now close this window.
command prompt:
Error: waiting sso login failed with: rpc error: code = PermissionDenied desc = invalid user


updating to new behaviour syntax

I've made the commits a few weeks ago, related to the credential store so I could use plug_auth on my project. Since we are updating elixir's version on our project, i thought that it might be interesting for you as well, if it is here it goes the PR!

Thanks, I will review it soon!


Use Unity Tweak Tool instead of Ubuntu Tweak

Fix #108.

@anmoljagetia Yeah, I have been using Unity Tweak Tool to manage themes, including Flatabulous, and it definitely works.

Thanks (Y)


migrate to standard protocol-buffer-matchers.h when available

This is blocked on https://github.com/google/googletest/issues/1761 - opening this issue to remind us to use it if/when that gets resolved.
While discussing a PR today, we had a potential need for IgnoringRepeatedFieldOrdering, and there are a number of nice features in there we could use, plus we can delete our own IsProtoEqual, etc.
At least one project has already externalized this; we could also just copy that to our tree. see https://github.com/google/nucleus/blob/master/nucleus/testing/protocol-buffer-matchers.h (and .cc)

Looks like it won't happen any time soon. If it does one day, we can use them then.


Stored XSS via SVG file Vulnerability on Bludit v3.14.1

Description:
I found Stored Cross-site scripting (XSS) vulnerability in your Bludit - Flat-File CMS (v3.14.1) on "General" settings to "Logo" field. When I send malicious code use svg file after then the browser give me result.
CMS Version:
v3.14.1
Affected URL:
http://<IP_ADDRESS>/bludit/admin/settings
Steps to Reproduce:

First login your admin panel.
then go to General settings and click logo section.

Now open notepad and save this code with xss.svg name with extension

Now upload this xss.svg file on logo section. So your request data will be:

POST /bludit/admin/ajax/logo-upload HTTP/1.1
Host: <IP_ADDRESS>
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0
Content-Type: multipart/form-data; boundary=---------------------------15560729415644048492005010998
Referer: http://<IP_ADDRESS>/bludit/admin/settings
Cookie: BLUDITREMEMBERUSERNAME=admin; BLUDITREMEMBERTOKEN=139167a80807781336bc7484552bc985; BLUDIT-KEY=tmap19d0m813e8rqfft8rsl74i
Content-Length: 651
-----------------------------15560729415644048492005010998
Content-Disposition: form-data; name="tokenCSRF"
626c201693546f472cdfc11bed0938aab8c6e480
-----------------------------15560729415644048492005010998
Content-Disposition: form-data; name="inputFile"; filename="xss.svg"
Content-Type: image/svg+xml

-----------------------------15560729415644048492005010998--

Now open logo image link that you upload. You will see XSS pop up.

Proof of Concept:
You can see the Proof of Concept. Which I've attached screenshots and video to confirm the vulnerability.
https://user-images.githubusercontent.com/41516016/232166257-eb768ab3-d49e-462c-8874-c30fe0127ff3.mp4
Impact:
Attackers can make use of this to conduct attacks like phishing, steal sessions etc.
Let me know if any further info is required.
Thanks & Regards
Rahad Chowdhury
Cyber Security Specialist
https://www.linkedin.com/in/rahadchowdhury/

is it legal to apply for a cve id before the authority fix that bug?

You need to have access to the admin panel to change configurations and store XSS. Feel free to provide a solution via PR. Thank you for reporting the issue.


[ECO-4839] Refactored transition to CONNECTED and channels attaching/detaching

Closes #1936

Closed in favor of https://github.com/ably/ably-cocoa/pull/1941


Type 'string' is not assignable to type 'SortOrder' when orderBy defined in a variable

Bug description
A TS error is thrown when orderBy clause is defined as a variable and passed into findMany arguments instead of placed inline with other args:
    Type '{ email: string; }' is not assignable to type 'UserOrderByInput'.
      Types of property 'email' are incompatible.
        Type 'string' is not assignable to type 'SortOrder | undefined'.

How to reproduce
Reproduction repo can be found here: https://github.com/wyrd-code/prisma-orderby-ts-bug-reproduction
To reproduce manually, simply, instead of a regular query where the orderBy is passed inline
// This works
await prisma.user.findMany({
    orderBy: [
      {
        email: 'desc',
      },
    ],
  })

Define the orderBy clause as a variable and include it in the query
// This throws a TS Error
const orderBy = [
  {
    email: 'desc',
  },
]

await prisma.user.findMany({
    orderBy,
  })

Expected behavior
No TS errors would be thrown and the query would be executed.
Prisma information
model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
  posts Post[]
}

Environment & setup

OS: Ubuntu 21
Database: any (PostgreSQL, SQLite both throw)
Node.js version: 14.17

Prisma Version
Issue is present in both `2.30.3` and `3.0.2`

For anyone else that happens upon this, you can also use the enum value Prisma.SortOrder. in TS


docker-enter issue for ssh tunnelling

I have been trying to setup a "utiliy" container to upload files to docker volumes through rsync / scp.
In the end it works fine with but I just wanted to share that docker exec cannot yet fully replace nsenter because it does not completey exit in some cases.
See docker/docker#13052 for more details
/B

docker enter or docker exec?

sorry docker exec (just edited the original text)

OK, thanks! That makes sense. I'll leave this ticket open as a reminder to add a little section to the README maybe...

+1.
I finally got a rsync transport to work with nsenter.
It's strange that nsenter works where docker exec [-t] [-i] stucks. Here's Docker-1.8.3.  Thanks a lot.

Cleaning up some older issues :-)
For future reference: the trick is to use rsync's --blocking-io option when using docker exec -i as a transport.