Shims like Scoop

Description of the new feature/enhancement
Like how Scoop has. For example without adding anything to path, we can just type gpu-z to launch GPU-Z or use mpv.net from commandline with mpvnet <url>. UWP apps also have this, notepads for Notepads, wt for Windows Terminal etc.

I'm using scoop instead of choco just because it adds the essential apps to the path automagically.

@bog-dan-ro Scoop does not add anything to the path. It adds their Shims directory to path and adds shims to that path. Same as UWP's 'WindowApps' directory.

Just to be clear, Chocolatey has this functionality as well, and has for a long time.

To follow up on what Gary mentioned and make sure the credit is in the proper place, I just wanted to note that Chocolatey brought about the idea of shims not to clutter your PATH - it existed long before Scoop was created as a concept called batch redirects. Later we moved to shim exes. Luke thought shimming was great and added it to Scoop. Just want to make sure the credit is in the proper place on shims.
References:

November 2013 - Issue for Shim Exes for Chocolatey w/commits in November 2013 - https://github.com/chocolatey-archive/chocolatey/issues/372
January 2014 - Added to Scoop - https://github.com/lukesampson/scoop/commit/5c52166fcd813aaee0865e50f516b09d696bf9c7#diff-6102f557c61df6fb4e37e4e68d8899348e48b633871262f5fd1c27ed42caf4dd

I think your confusion might be in that Chocolatey defers to an installer as well, which might put things on PATH. Scoop doesn't use the installer at all, it just unpacks, so the shims are much more necessary. Chocolatey's docs on this - https://docs.chocolatey.org/en-us/features/shim
(NOTE: This is a repost of what I noted on a different issue).

Windows already has some kind of shim in windowsapp folder. Like wt.exe for windows terminal; wsl.exe for the lixus sub system

I think the manifest need someway to specify which to shim from final install folder

@denelon as taking about shim, I wonder if we could request open version of windows store shim for like wt.exe, wsl.exe to use in personal project

If an app depends on some .dll file within its directory, symbolic links do not work. Also, symbolic links require admin permission.

Not every Windows executable supports command line usage. We should be able to list the ones that do in the app manifest and then the shims for them would be created automatically in an existing directory that's already in PATH.

restart the terminal session to get any potential path entries that have been made by an installer

That's what we want to avoid having to do 😉. Both the restarting of terminal and the pollution of PATH with new directories are bad.
FWIW, Homebrew also creates shims (or rather it permits maintainers to do so in the app manifests). See https://github.com/Homebrew/homebrew-cask/issues/18809: "Everyone agrees shim scripts are desirable, so lets allow them."

Not every Windows executable supports command line usage. We should be able to list the ones that do in the app manifest and then the shims for them would be created automatically in an existing directory that's already in PATH.

restart the terminal session to get any potential path entries that have been made by an installer

That's what we want to avoid having to do 😉. Both the restarting of terminal and the pollution of PATH with new directories are bad.
FWIW, Homebrew also creates shims (or rather it permits maintainers to do so in the app manifests). See https://github.com/Homebrew/homebrew-cask/issues/18809: "Everyone agrees shim scripts are desirable, so lets allow them."
Winget is more modern and IMO more elegant than the other package managers, but this pain point is a major inconvenience that makes it difficult to recommend right now.

Another software that will benefit from this https://github.com/microsoft/winget-pkgs/pull/91422, right now to use this software you need to type lychee-v0.10.3-windows-x86_64.exe, which is way longer than just lychee.


Latest update breaks conditional [slug] routes

Describe the bug
On @sveltejs/kit version 1.0.0-next.147, trying to access routes such as [id].svelte results in
error loading dynamically imported module

This did not happen on version 1.0.0-next.146.
Reproduction

npm update to the latest version (1.0.0-next.147)
try to access a relative route such as [id].svelte
Status code 500: error loading dynamically imported module

Logs
No response
System Info
Need to install the following packages:
  envinfo
Ok to proceed? (y)
  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (2) x64 Intel(R) Xeon(R) Silver 4214 CPU @ 2.20GHz
    Memory: 2.91 GB / 7.78 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.6.1 - ~/.nvm/versions/node/v16.6.1/bin/node
    npm: 7.20.3 - ~/.nvm/versions/node/v16.6.1/bin/npm
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.33 => 1.0.0-next.40
    @sveltejs/kit: next => 1.0.0-next.147
    svelte: ^3.34.0 => 3.42.1

Severity
blocking some usage of SvelteKit
Additional Information
If it helps, here is the (working) system info prior to npm update
  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (2) x64 Intel(R) Xeon(R) Silver 4214 CPU @ 2.20GHz
    Memory: 2.92 GB / 7.78 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.6.1 - ~/.nvm/versions/node/v16.6.1/bin/node
    npm: 7.20.3 - ~/.nvm/versions/node/v16.6.1/bin/npm
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.33 => 1.0.0-next.39
    @sveltejs/kit: next => 1.0.0-next.146
    svelte: ^3.34.0 => 3.42.1

vite-plugin-svelte was upgraded from 1.0.0-next.14 to 1.0.0-next.16. I wonder if that's it. If you have a repo that reproduces this, that would help

After a bit of testing, I realised the issue actually has to do with how SvelteKit handles the paths config in svelte.config.js:
/** @type {import('@sveltejs/kit').Config} */
import node from "@sveltejs/adapter-node";
import preprocess from "svelte-preprocess";

const config = {
    preprocess: preprocess({
        scss: {
            renderSync: true,
        },
    }),
    kit: {
        target: "#svelte",
        adapter: node({
            env: {
                port: "PORT",
            },
        }),
        paths: {
            base: "/somebasepath",
        },
    },
};

export default config;

A bit of context: the app is currently deployed at mywebsite.com/somebasepath. In my src folder, I have the following:
src/
  routes/
    list/
      [id].svelte
      index.svelte

I also have a convenience script: npm run serve, which is defined as:
"serve": "npm run build && PORT=8000 node build/index.js",

After running npm run serve, the app is deployed at localhost:8000, which is then forwarded to mywebsite.com/somebasepath. Here is what I found:

localhost:8000/somebasepath/list: 404
localhost:8000/list: OK
localhost:8000/list/1: OK
mywebsite.com/somebasepath/list: OK
mywebsite.com/somebasepath/list/1: 500: Failed to fetch dynamically imported module

vite-plugin-svelte was upgraded from 1.0.0-next.14 to 1.0.0-next.16. I wonder if that's it. If you have a repo that reproduces this, that would help

I made a repro for this issue
https://github.com/noahsalvi/kit-path-broken-repro

A repo is always helpful. Otherwise we have to setup an app with those routes ourselves to see what is happening, which takes up a lot of time when we have to do it across hundreds of issues


Update Android gradle plugin version to 2.1.2.

Can I merge?

Sorry! I miss this PR.
LGTM!!

Thanks!

🙇


Recurring Donation: Refresh Opportunities button - Opportunity Naming {!Amount} does not constrain consistently to 2 decimals when recalculating 'Divide By' record

Steps to repeat:

Opportunity Naming rule formula that includes {!Amount} (example: {!Account.Name} {!Amount} {!RecordType.Name} {!CloseDate})
Create Recurring Donation record. Open Ended Status = None; Schedule Type  = Divide By; Installments = 10; Amount = 1000; Installment Period = Monthly (doesn't matter)
Edit first Opportunity and change Amount to a different, higher value such as $175.50, Stage = Closed Won. Use case: first payment higher than anticipated installment.
Click Refresh Opportunities button

Note: this behavior only happens with Refresh Opportunities button. Standard Rollups Recurring Donation batch does not appear to recalculate installments on fixed-length.
Expected: Remaining Opportunities would have Amount in Name rounded to 2 decimal points (with any remainder added to final opportunity) to match Amount field on Opportunity.
Actual: Waaaay too many decimal points in Amount value in Name.

**lurch: add

Tracking W-025175

Affecting additional customers: https://powerofus.force.com/0D51E00004aH7Cp

We are closing this issue because we will not be updating the old Recurring Donations functionality. We will be making all updates to our new Recurring Donations functionality. We recommend that customers evaluate the new features and upgrade when it makes sense for their organization. https://powerofus.force.com/s/article/NPSP-Enhanced-RD-Upgrade-Guide


CollectingEvent - Geographic area intersection priority calculation

@LordFlashmeow If you can can you detail what we discussed for this issue?

There is a SQL CASE statement that needs to be adapted for perhaps multiple uses in different scenarios (e.g. exporting to DwC vs. validation).

Code at the heart of the issue is in geographic_area_geographic_item.rb
  def self.origin_order_clause(table_alias = nil)
    t = arel_table
    t = t.alias(table_alias) if !table_alias.blank?

    c = Arel::Nodes::Case.new(t[:data_origin])
    c.when('ne_country').then(1)
    c.when('ne_state').then(2)
    c.when('gadm').then(3)
    c.else(4)
    c
  end

Closing as complete (in 0.29.4).


Can't download Aurora Update

Description
Newly installed Aurora from the GitHub Nightly Build Link. Opened Preferences, switched to Update and a new update is displayed. Then I click on Update Now, but nothing is happening. Change no setting, just the fresh install.

To Reproduce
Install Aurora
Open Prefrences
Switch to Update
And Update should be displayed
Click on Update now
now, nothing is happening
Expected behavior
The Update should download and install
Version information
Aurora Editor: 1.0①
Commit: a66d72d7291812b6259f22b7df524bf9baf1f0c5
MacOS: Ventura 13.0
Xcode: 14.1
Additional context
No response

I still meed to find a way to validate the hash and install patches instead of the whole program over.


Port constraint_sampler_manager_loader to ROS2

CI failed @anasarrak, can you review please? @ahcorde can you help?

Linux is passing but OSX is failing

OSX is failing because of this line on geoetric_shapes


Call EconML estimate and shap_values methods in a way consistent with built-in estimators

Allow to call effect, effect_inference, and shap_values methods of wrapped EconML estimators by just passing in the whole dataframe, like you can with built-in estimators.
Makes it easier to use all estimators in a consistent fashion.
Took me a while to figure out that _effect_modifier_names is the only list of column names to use for this that will also work with metalearners, so would like to spare future users that effort

thanks @EgorKraevTransferwise. this is a very useful contribution. Merging it in.

Thanks for the kind words!
When will this make it into the latest pypi version of dowhy?

We are aiming for a monthly release cycle. So this should be updated in Feb end/early March.


Resolve crash with custom device statistics

Fixes #1423
Add a null coalescing operator and test for null or empty string.

@tigert Can you please test this build and see if it resolves the crash you saw?

Oddly latest beta doesnt crash either, but this is not yet merged. I will check again to make sure.


feat: upgrade trappist to polkadot-v1.3.0

Please note that pallet-dex has been removed, as it was causing several problems very difficult to track, even after migrating it to 1.3.0. Instead, we will soon incorporate the asset conversion pallet.


fix url in INSTALL.md

the git clone url was still for the repo's old location

Travis CI is a passing error in repositories. Ignore


What is the new application?
CrystalDiskMark is a simple disk benchmark software.
Vendor site
https://crystalmark.info/en/download/#CrystalDiskMark
Have you reviewed the list of supported applications?

[X] Supported apps at: https://stealthpuppy.com/evergreen/apps/

As far as I can tell there's no URL or API to find the latest version number.


Just wanted to say thanks!

Not an issue to report. Just wanted to say thank you for making this project public. It has been a great frame of reference for me in so many ways when building my own large scale meteor project. Cheers!

Reading stuff like that makes my day! Feel free to let me know if there's anything you'd like clarified or documented.

Will do. Cheers!


minimal vcpkg modifications

According to very usefull suggestions of Michael, I have completely rebuild the feat-vcpkg branch, by removing it completey and creating new branch in order to free from old crap , which was there from unknown persons before me and unknown date. In addition I have also wrapped find-package calls of PNG, GTest , DBOw2 and TinyXML2 to vcpkg. Everything is installed properly over install call of cmake so there is no need to additional copying the files. All four versions of compilation are generated: Release, Debug, RelWithDbgInfo, RelMinSize. Release-like versions are working . Debug version starts but it crashes in about middle of scanning. Dorian DLib is compiled over FetchContents call , like Michael suggested.

addressed in https://github.com/CADstarGmbH/CSBadSlam/pull/9


Update request: monado 2024-01-02 → 2024-06-07

Package name: monado
Latest released version: 2024-06-07 (24.0.0)

Current version on the unstable channel: 2024-01-02
Current version on the stable/release channel: 2024-01-02

[x] Checked the nixpkgs pull requests

Notify maintainers
@Scrumplex
@expipiplus1
@prusnak

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

PR in #318203

Thank you!


2 menus appear instead of one

I don't know if this is intentional, but the bot sends 2 embeds instead of one.
My client.help_command: client.help_command = PrettyHelp(ending_note="George Floyd Gaming", show_index=False, no_category="Misc")

Generally that means you have two instances of your bot running.

Apparantly it fixed itself after a bit. Thanks for responding!


AdderNet Upsample

Hello, I want to realize the Transposed Adder layer according to the relationship between convolution and transposed convolution, but from the result I found that the image it generates has very obvious checkerboard artifacts. I think that it is because the variance of the output of AdderNet is much larger than CNN. So I want to know if you could give me some suggestions to solve it? Thanks very much!!!

We add BN layer after adder layer to solve this problem in our paper.

I also add BN layer after each Transposed Adder layer what I mentioned above and the feature maps it generated also has obvious checkerboard artifacts. Could you help me solve it? Thanks a lot!

How if you use the transposed conv layer?

When I use transposed convolution, it also have a little checkerboard artifacts, but it is not very obvious if you do not observe it carefully.

I think this may caused by some optimization problems. Maybe you can try to adjust the hyper-parameters such as learning rate.


DOC: add interp example

[NA] Closes #xxxx (remove if there is no corresponding issue, which should only be the case for minor changes)
[NA] Tests added (for all bug fixes or enhancements)
[NA] Tests passed (for all non-documentation changes)
[NA] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

I wanted to add an example as googling 'xarray interp' takes me to http://xarray.pydata.org/en/stable/generated/xarray.Dataset.interp.html.
However, there lots of great examples in http://xarray.pydata.org/en/stable/interpolation.html
Perhaps I should edit it to:
Examples
--------
See http://xarray.pydata.org/en/stable/interpolation.html

I was also thinking about adding a note about interpolating time as it came up in https://github.com/pydata/xarray/issues/2284 but not sure what would be the best way to do so.

Thanks for adding this to doc.
It is very welcome if you could add an example for interp with datetime.
To do so, it would be best place to put it in here
https://github.com/pydata/xarray/blob/master/doc/interpolation.rst

@fujiisoup I would like to add another example on how to update a DataArray with the interpolated data. I looked in http://xarray.pydata.org/en/stable/combining.html but couldn't work out how best to do it.
I tried using merge but it requires the DataArray's to be named.
I used concat in this example but it is not correct as I would like the coordinates to be in order (in-place may be the right word).
import xarray as xr
import pandas as pd
import numpy as np

da_dt64 = xr.DataArray([1, 3], [('time', pd.date_range('1/1/2000', '1/3/2000', periods=2))])
a = da_dt64.interp(time=np.datetime64('2000-01-02'))
xr.concat([da_dt64, a], dim='time')
#<xarray.DataArray (time: 3)>
#array([ 1.,  3.,  2.])
#Coordinates:
#  * time     (time) datetime64[ns] 2000-01-01 2000-01-03 2000-01-02

Thanks.
I think you can do
da_dt64.interp(time=pd.date_range('1/1/2000', '1/3/2000', periods=3))

Thanks, @raybellwaves.


Create Figures and Figure supplements page

[x] Create page
[x] Add description of what is being covered
[x] Add description of checks required on this content, compiled from current protocol documents
[x] Add examples covering correct and incorrect scenarios, as required to support checks
[x] Add guidance about multi-page figures (and add AQ)
[x] Add guidance about permissions https://docs.google.com/document/d/1nx9ljuxR2dc0Ur4ZkVm3-bkr5UbelOVFtReus3RlLes/edit#
[x] Populate with schematron messages
[x] Provide explanations for how to fix schematron errors and warnings
[ ] Review house style document to ensure all requirements are covered by GitBook and schematron
[ ] Review schematron messages related to this topic to ensure they are user friendly
[ ] Becky approved page
[ ] Melissa approved page
[ ] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Share page with Exeter and invite feedback
[ ] Revise with Exeter's suggestions

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?
[ ] Assign Fred to update the Schematron

@JGilbert-eLife @Melissa37 @FAtherden-eLife @bcollins14
Figures and figure supplements is available to review at long last!
However I still have many questions:

I haven't included fig-data or fig-code tests, assuming these can go in the source data/code pages respectively.
I wasn't sure whether these should be covered in this page: figurefigure-presence, supplementalfigure-presence so I haven't...but now I'm thinking I maybe should?
For figures going over multiple pages, do we want Exeter to leave author queries or query us via Slack so we can email the authors for these?
You'll notice a few '???'s in the schematron tests - I'm afraid I had no idea what the action should be for those >.<
Should label-fig-group-conformance-2 be on the videos page?
Should distinct-label-conformance be on the general content page? It seems to apply to anything with a label.
What’s the difference between fig-sup-test-4 and fig-sup-test-5?
pre-ar-fig-position-test and final-ar-fig-position-test – is the action correct or would we want to check with editorial/double-check the decision letter first?
For reply-fig-test,-2 box-fig-test-1, app-fig-test-1, fig-label-test-1, fig-id-test-1, fig-id-test-2, fig-sup-id-test, box-fig-id-1, app-fig-id-test-1 – can we make the formatting of these consistent – X instead of 0?
For fig-title-test-1 – the spelling of 'beginning' needs to be fixed in the message
For resp-fig-id-test and resp-fig-sup-id-test the spelling of 'response' needs to be fixed in the message
I'm not sure of the difference between fig-xref-conformity-2 and fig-xref-conformity-3
I'm not sure if the actions for fig-xref-test-2 and fig-xref-test-3 are correct

Whew. That's all I think!

I haven't included fig-data or fig-code tests, assuming these can go in the source data/code pages respectively.

:+1: from me

I wasn't sure whether these should be covered in this page: figurefigure-presence, supplementalfigure-presence so I haven't...but now I'm thinking I maybe should?

My opinion would be that these are best placed on a general page instead (since they fire on various different elements, but mostly just normal text).

You'll notice a few '???'s in the schematron tests - I'm afraid I had no idea what the action should be for those >.<

fig-xref-target-test

Suggest placing this in the XML structure checks section with the following action:
Action: This means that the ref-type attribute on the xref is not correct with respect to what the link points to. If it is meant to point to a figure, then the ref-type attribute value must be 'fig'. If the link it meant to point to something else, which is not a figure, then the link points to the incorrect location and will need to be updated. Exeter will need to correct the link in either case.

You'll notice a few '???'s in the schematron tests - I'm afraid I had no idea what the action should be for those >.<

fig-group-child-test-1

Suggest the following action:
Action: The only elements allowed as a child of <fig-group> are <fig> or <media>. This test will fire at all stages for an element which is not one of those in a <fig-group>. The XXXXXX will be the name of the offending element. This likely means that either this element is placed incorrectly in the XML, or there is an unnecessary element in the XML. Exeter will need to correct this.

You'll notice a few '???'s in the schematron tests - I'm afraid I had no idea what the action should be for those >.<

fig-group-child-test-2

'XXXXXX' is missing from the start of the message.
Suggest the following action:
Action: This will fire for any <media> element, which is a child of <fig-group>, that does not have a mimetype="video" attribute, meaning that it is a not a video. If it is a video, then the mimetype="video" attribute needs to be added by Exeter. If it is not a video, then it is likely that this is placed incorrectly in the XML, and this will need to be fixed by Exeter.

You'll notice a few '???'s in the schematron tests - I'm afraid I had no idea what the action should be for those >.<

fig-xref-test-18

Suggest the following action:
Action: This will fire at all stages for any figure citation which is immediately followed by a hyphen (or variant such as en dash or em dash), and a letter or number. For example in this case Figure 1a-ai, where the bolded text (in this example) is linked. If this fires, check whether the text following the link should instead be included in the link text. This can be done, for example, by checking the panel indicators in the image itself being linked to.

Should label-fig-group-conformance-2 be on the videos page?

This will fire for numerous different objects so would be best suited in a general page (IMO).

Should distinct-label-conformance be on the general content page? It seems to apply to anything with a label.

Yup - general page IMO

What’s the difference between fig-sup-test-4 and fig-sup-test-5?

'fig-sup-test-4' checks the position of a figure supplement based on its id (id attribute).
'fig-sup-test-5' checks the position of a figure supplement based on the number after 'supplement' in its label.

pre-ar-fig-position-test and final-ar-fig-position-test – is the action correct or would we want to check with editorial/double-check the decision letter first?

Check the original file. It's likely to be caused by adding a citation during proofing. If it's still unclear after checking the original file, then check w/ editorial.

For reply-fig-test,-2 box-fig-test-1, app-fig-test-1, fig-label-test-1, fig-id-test-1, fig-id-test-2, fig-sup-id-test, box-fig-id-1, app-fig-id-test-1 – can we make the formatting of these consistent – X instead of 0?

There are various 'in the format' type messages, some relating to ids and some to messages, and it looks like 0 os more commonly used rather than X. IMO 0 is better since whoever sees it is then aware that the character has to be a digit rather than a letter (or unknown).

For fig-title-test-1 – the spelling of 'beginning' needs to be fixed in the message
For resp-fig-id-test and resp-fig-sup-id-test the spelling of 'response' needs to be fixed in the message

I fixed these today.

For reproduce-test-5 – the message should say ‘reprinted with permission from’

Thanks going to change to 'reprinted with permission'

I'm not sure of the difference between fig-xref-conformity-2 and fig-xref-conformity-3

fig-xref-conformity-2 will fire for any link which points to a figure (not a figure supplement for example), and the link text does not contain the number in the id of the link that it points to.
fig-xref-conformity-3 is a little complicated. It will only fire for links which point to a figure (not a figure supplement for example). The test strips anything that isn't a number from the link text and compares this number (or numbers) with the relevant number in the id of the figure it points to.
Here's an example where it wouldn't fire:
Link-text: Figure 2
Figure id: fig2
Here's an example where it would fire:
Link-text: Figure 2i3
Figure id: fig2

Why are fig-xref-test-6 and 7 warnings? When is this ok to leave?

I can't think of an example off the top of my head. Happy to upgrade to error if appropriate. Nice spot

@FAtherden-eLife I think I noticed a couple of mistakes in the pass/fail cases. For fig-xref-test-11, the label says has ‘video supplement 1’ but we don’t use this label, we just use ‘video 1’ right? Also, for fig-xref-test-13 the xref has 'Figure 5 supplement' but I think it should be 'Figure 5 - figure supplement 1'.

For fig-xref-test-11, you are correct with respect to our style, however this is a fail case, meaning that it's an example of what we might want this test to fire on. If an author has referred to their videos in a way which isn't our style, and this hasn't been processed correctly (i.e. as Figure 1-video supplement 1, as in the example), then we would want it flagged, and this is a case demonstrating that the Schematron does under those conditions.
For fig-xref-test-13, what you say is true, but it's not an error for the purposes of unit testing. The cases are only written with respect to what each specific test is checking. Since this specific test is checking whether the link is followed by 'supplement' text or similar, and since this doesn't occur in the pass case then it's fine for a 'pass' case. There will be many other similar cases elsewhere, I'm sure, where our style isn't followed exactly (this is because there are many tests and making each snippet perfect would have taken much more time). In other words it's not an error with respect to it's purpose (checking whether this test acts as expected). If you could like to correct it, feel free to edit in a separate branch and create a PR. Each test can be validated against a smaller version of the Schematron (a Schemalet), and this can be done automatically in oXygen using cmd + shit + v.

I'm not sure if the actions for fig-xref-test-2 and fig-xref-test-3 are correct

The actions look good to me :+1:

The reproduce tests (e.g. reproduce-test-1) fire for both figures and videos. Would it therefore be more suitable to place them in a general content page?

Looks like there are some examples missing in the 'XML structure' section. Let me know if you need any help finding any.

Is it worth clarifying somewhere the relationship between figure citations and figure placement? And similarly which figure citations are (most) important with respect to figure placement (for example citations in captions should not be used to determine figure placement).

I can see some references to label where hyphens instead of em dashes are used (e.g. Figure 1 - source data 1) - can we update to use our style instead (em dash with no space), where appropriate?

Figures and figure supplements (or panels within these) may be 'adapted' from previously published content. This usually means that the authors are not reproducing anything directly but are instead redrawing a figure or simply using the same data to create new content. As long as the authors provide a suitable citation and state clearly, for example, that “Panel A in Figure 2 has been adapted from Smith and Jones, 2015”, no further action is required.

No, the term adapted is used inconsistently by authors with respect to whether an image, or parts of an image, has been reproduced or whether it has been redrawn. Therefore, we cannot simply assume that if the authors have used this term, that the image is redrawn.
We (Production) need to determine whether it has been redrawn or reproduced, either by comparing the image to the original, or by confirmation with the author(s).

Should we mention what filetypes for figures we permit, or will that be covered in a separate page?

Should we refer to the common types of figure queries we get from authors, and how to deal with them?

Author response figures

It's rare, but there can also be decision letter figures (example). Can we refer to these - either in this section or in a different one? Obviously no author queries would ever be required.

fig-test-2

Suggest putting this one in the XML structure section. All it does is check whether a figure has a position attribute, which is unrelated to where it is placed in the XML. This attribute is used in PDF generation to determine whether the figure can float (like a figure can), or whether it's inline in the text (like a Scheme or Chemical structure). The values are float and anchor respectively.

Is it worth including a list of all the different figure labels which are allowed?

Apropos my comments above (here and here), would it be worth also including which figures float and which ones do not in the 'PDF version' section.

Is it worth including the feature specific figure tests (such as feat-fig-test-3) be included in the feature page instead?

That's it from me :sweat_smile:. Nice job Naushin!

Most scientific articles include figures and figure supplements to present data. eLife figures can also have various assets related to them. All figures and figure supplements must have titles, and usually also have captions (although this is not mandatory).

Could you change this to something like:

Most scientific articles include figures. eLife figures can also have figure supplements (‘child’ figures less central to the narrative of the paper but which provide, for example, additional examples of analyses or data shown in a primary figure) to present data and can have various other assets related to them (such as source data and code. All figures and figure supplements must have titles, and usually also have captions (although this is not mandatory).

eLife is pretty unique in having figure supplements

If the authors have provided a table as a figure, the production team will need to be queried to ask the authors to provide this information as a table in Word or Excel format

Could we simplify this to:

If the authors have provided a table as a figure, the authors should be asked to provide this information as a table in Word or Excel format

This could be an AQ added in pre-editing?

Most scientific articles include figures and figure supplements to present data. eLife figures can also have various assets related to them. All figures and figure supplements must have titles, and usually also have captions (although this is not mandatory).

Maybe add:

All main figures must be cited in the text, but figure supplements do not have to be. Figure supplements can be cited in the text but it is not mandatory

If an author provides a PDF file over multiple pages we cannot process this as a single figure. The production team will need to be queried to ask the authors for single-page figures.

This can be an AQ, no need to ask production to query the author.

If the authors have included unlabelled images in their article file that do not correspond to the main figures, the production team should be queried to determine how to treat these images. In most cases, these images will need to be treated as chemical structures or schemes.

It would be useful to provide a screenshot of an example here

PDF version

heading. I wonder whether we could make this clearer as figures can be provided as PDFs.
Perhaps Article PDF?

If the image is particularly tall, this may result in there being more whitespace on the right.

Suggest add:

If the image is particularly tall, this may result in there being more whitespace on the right because to increase the size of the image would make it too big for a PDF proof page

If the author has only provided a legend that begins with a description of panel A (e.g. “(a) The high-resolution MS/MS spectrum of the H4K31ac peptide generated from . . .”), the same query as above will need to be left to ask the authors to add an overall title.

Consistency, suggest either "panel A (e.g. “(A)" OR "panel a (e.g. “(a)"

Part labels
Could you define what a part label is at the start of this section?

Part labels should be captured as such in Kriya (by right-clicking and selecting 'part label'). Please match the figure file when adding part labels in terms of upper/lowercase.

please add example

If the source data or code is linked to multiple figures and figure supplements however, no further action is required. See more about source data and source code (links to be added).

Should this become source data/code to the whole article instead?

If the legend for a figure or figure supplement states that the image is ‘reprinted from’ or ‘reproduced from’, we may need to add licensing information for the reproduced elements. This will usually apply to panels within images, not whole images.

The authors will need to have permission to do this, most importantly!

Can we change the URL so that it isn't 'untitled' please?

https://app.gitbook.com/@elifesciences/s/productionhowto/article-details/content/allowed-assets/untitled

Also I think it placing this page (and the other pages) in 'allowed-assets' makes it much less discoverable, but that's just my opinion :smile:

Would it make sense to include Chemical structures/Schemas in the Figures page, rather than their own? They are figures, and while some of the tests do not apply to them, some do e.g. fig-label-test-1, box-fig-test-1 etc.

For the figure resolution, it's probably worth giving guidance on WHERE we want this to be checked. Kriya scales down the images and reduces the resolution to save time on loading the article and memory space. So those aren't representative of the final version that'll appear online. Checking the PDF is often a better indication of the final resolution.

Do we have queries for tables-as-figures, multi-page figures and so on? They should probably go in the relevant sections.

For smaller figures, these can be left the size they are:
I don't like this example. That to me looks like a figure that should either be fully across the column-width, or set as a half-column figure.

For part-labels, is it worth covering cases that look exactly like part labels but aren't? E.g. if the author has included abbreviations that are outside the range of panels in the figure, so you have A-D and then (I) or something in the legend.

Figure supplements do not have to be cited in the text though it is preferable that they are

I wouldn't say it's preferable. We've no official stance on the matter.

Actually, the citation stuff really belongs in an 'asset citations' page . . .

Please provide the image file for this figure (do we need to add this in AQ list?)
Please provide the image file for this figure supplement.
These are nothing to do with citations and refer to cases where a title/legend has been provided but an image has not. They'll need their own section, I think, for the case where the figure has a title/legend in the article file but no accompanying image.

I second what Fred said about licensing, and I also think we probably need to give Exeter a direct map of how to go from the production note to the tagging.

I also agree with Fred that included Chemical structures and Schema here is a good idea.

fig-test-6 - I wonder if these needs expanding, but I'm not quite sure how. Do we have an example where it wasn't supposed to be just a title with no legend?

I think we need to have a breakdown of the parts of a figure - image, label, title, legend - for reference purposes.

pre-fig-specific-test-2 - unlink the citation and move the figure down to the right place!

fig-specific-test-3 - this needs an exception for when a figure is appearing in an equation heavy section.

fig-specific-test-5 - I think this is best illustrated with a content view or Continuum view screenshot. The PDF will likely end up broken by figures anyway and there's not much we can do about that.

final-ar-fig-position-test - I think the appropriate query is missing here

fig-title-test-3 - surely checking against the original submission should be unnecessary since the rest of the title will be part of the legend?

There's a lot of 'Exeter will need to fix this' but not much explanation for them of what they should do . . .

fig-xref-conformity-2, fig-xref-conformity-3 - I think there are certain cases that break this without being wrong, e.g. particular strings along the lines of Figure 2Bii-iv . . . has anyone else encountered that? Presumably it's something that would ideally be fixed at the test level.

Is there any reason other than avoiding fig-xref-test-4 firing that we need to change a citation of a figure in its own legend to a part label?

The tests about figure citations should probably be moved to a different page anyhow!

Should the license rules, or at least some of them, go under content when they're about, well, the content of the legend or the permissions statement?

Thanks for handling this mammoth topic, @naushinthomson!

I've just realised that placing these pages in an Allowed assets wrapper has changed the URL. This means that the Tables page links in the Schematron no longer point to the correct location (it still resolves to the page, but not to the specific rule).
Let me know if this needs changing in the Schematron, and if moving a page in the future, please let me know so that I can update the links.

Is there a use-case for a test which checks whether a figure is only cited in a table or caption (not in the main text), and if so what would we expect here? The figure to appear directly after that object? Or for the authors to be queried for a main text citation?

fig-specific-test-3 I think we need to cover what do in the case where the first citation for a Figure is in an appendix. i.e. Figure 3 is placed after Figure 2 in, say, the results but it's first/only citation is in the appendix.

For reply-fig-test,-2 box-fig-test-1, app-fig-test-1, fig-label-test-1, fig-id-test-1, fig-id-test-2, fig-sup-id-test, box-fig-id-1, app-fig-id-test-1 – can we make the formatting of these consistent – X instead of 0?

There are various 'in the format' type messages, some relating to ids and some to messages, and it looks like 0 os more commonly used rather than X. IMO 0 is better since whoever sees it is then aware that the character has to be a digit rather than a letter (or unknown).

Cool, in that case should the text of fig-sup-test-2 be changed to 'Figure 0—figure supplement 0.' (where 0 is one or more digits)'?

Can we change the URL so that it isn't 'untitled' please?

https://app.gitbook.com/@elifesciences/s/productionhowto/article-details/content/allowed-assets/untitled

This has now been updated (untitled has been changed to figures)

this would become Figure 0—Source data 0 (where 0 is one or more digits)

I don't feel this makes sense. I feel this could be worded differently or at least an example given.

this would become Figure 0—Source data 0 (where 0 is one or more digits)

I don't feel this makes sense. I feel this could be worded differently or at least an example given.

Suggestions welcome for how to improve the message :smile:

I'm not overly sure, I guess its because it would never be 0 so would X be more appropriate?

For author response images you say

'It is preferred, but not necessary for these to have titles. If these are missing at pre-author stages, the following query should be added'

I thought we only queried authors for titles if there was a legend present, otherwise we just leave this as is?

Not sure if this has been mentioned but in the following...

fig-title-test-2
Error: title for XXXXXX must end with a full stop.
Action: This error will appear if a figure has a title that does not end with a full stop. Make sure this is added.

I know I used to get confused when there was a full stop but also a space after and unless you clicked on that space, you didn't know it was there!

I think everyone else has covered everything (joys of being late to the party!). Thank you for climbing Everest! 🥇

From your list of questions:

For figures going over multiple pages, do we want Exeter to leave author queries or query us via Slack so we can email the authors for these?

I prefer AQ - reduced the back and forth between the stages in the workflow. It's the same end - ask the author for it!

but '(A) shows the results of . . . is fine to leave as is.

Does it not depend on whether the previous statement is closed with a full stop or this is a continuation of the same statement?
I'd rephrase this to include the end of the previous statement/sentence and also give an example of a scientific term that starts with a lower case letter.

Action: This error will appear if a figure or figure supplement does not have a position in the XML. This may be because the figure has not been cited in the text. Check the article for any unlinked citations of the figure and link these (unless the citations are to figures from another paper - see here for more information). If the figure has not been cited in the text at all, please leave the following query:

I think we've been using the term "this error will fire" (not appear?)

Error: fig must have a @position.

I am confused by this as @position is not an XML attribute we use
So I am also confused by the action:

Action: This error will appear if a figure or figure supplement does not have a position in the XML
The context of the action seems to indicate it's not been cited, not that it does not exist in the XML

Action: All figures and figure supplements in research content should have the label 'Figure 0' or 'Figure supplement 0' (where 0 is one or more digits). This error will appear if a figure does not have a label and will need to be corrected by Exeter.

Suggested change:

Action: All figures and figure supplements in research content should be numbered sequentially and thus have a label 'Figure X' or 'Figure supplement X' (where X is the number of the figure). This error will appear if a figure does not have a label and this will need to be corrected by Exeter support.

Action: This will appear in Feature content if a figure does not have the label 'Figure 0' (where 0 is one or more digits). Check the original submitted document to see whether there should be a label. If so, this will need to be added by Exeter. If the original version does not have a label, this is ok to leave. For example, in 58965:

Suggest changing to:

Action: Feature content figures do not always require labels. However, there is a warning if a figure does not have the label 'Figure X' (where X is one or more digits, based on the sequence of the numbered figure). Check the original submitted document to see whether there was a label. If so, this will need to be added by Exeter support. If the original version does not have a label, this is ok to leave. For example, in 58965:

Action: This warning will appear at the pre-author stages if a figure has no title or caption element. Double-check the submitted manuscript for the figure title. If this has not been provided, the following author query should be left:
Please provide the title for this figure.
If the caption element is missing in the XML, compare with the original submitted document to see what is missing. Exeter will need to fix this.

Suggest changing last sentence to:

Compare with the original submitted document - If the caption element was present in the figure file or original manuscript submitted but missing in the XML this will need to be added. Exeter will need to fix this.

final-fig-test-4
Error: XXXXXX has no title or caption (caption element).
Action: This warning will appear at the post-author stages if a figure has no title or caption element. Double-check the submitted manuscript for the figure title. If this has not been provided, the authors will need to be asked for this.
If the caption element is missing in the XML, compare with the original submitted document to see what is missing. Exeter will need to fix this.

The previous test (pre-fig-test-4) indicates the cross-checking with the original submission has been done already so I'd suggest not asking for this to be done again. You could say

Action: This warning will appear at the post-author stages if a figure has no title or caption element. Check whether an author query was added at pre-editing requesting this from the author. If this author query was not present, check the submitted manuscript file or figure file for the figure title. If this was not provided, the authors will need to be asked for this.
Exeter will need to fix this when the information is provided.

pre-fig-test-5
Warning: XXXXXX does not have a title.
Action: This warning will appear at the pre-author stages if a figure has no title. Double-check the submitted manuscript for the figure title. If this has not been provided, the following author query should be left:
Please provide the title for this figure.

Suggest changing "Double-check the submitted manuscript for the figure title." to:
Compare with the original submission on EJP - If the caption element was present in the figure file or original manuscript submitted but missing in the XML this will need to be added. Exeter will need to fix this.

final-fig-test-5
Error: fig caption must have a title.
Action: This warning will appear at the post-author stages if a figure has no title. Double-check the submitted manuscript for the figure title. If this has not been provided, the authors will need to be asked for this.

Same issue as identified in https://github.com/elifesciences/schematron-gitbook/issues/37#issuecomment-670004356

pre-fig-test-7
Warning: fig does not have graphic. Ensure author query is added asking for file.
Action: This warning will appear at the pre-author stages if no file has been provided for a figure or figure supplement. Leave one of the following author queries as relevant:
Please provide the image file for this figure. (need to add this query?)
Please provide the image file for this figure supplement.

I am confused by "(need to add this query?)" - is this about adding it to the canned AQ list?

final-fig-test-7
Error: fig must have a graphic.
Action: This warning will appear at the post-author stages if no file has been provided for a figure or figure supplement. The authors will need to be asked for the file.

Do you need to check it has not been lost during the processing before contacting the author?

pre-fig-specific-test-2

Is it worth providing a screenshot example of this?

This check doesn't take into account 'Figure 1-3' type links, so if the warning is linked to this type of figure citation, it can be ignored.

Can this be more specific - it would refer correctly to figure 1 wouldn't it, but not figure 3?

final-fig-specific-test-4
Warning: There is no citation to XXXXXX Ensure this is added.
Action: This will appear at the post-author stages if a main figure has no in-text citations. Email the authors to ask for this.

Is it worth suggesting checking previous versions to see whether it was accidentally deleted at some stage before querying the author?

fig-specific-test-5
Warning: XXXXXX is immediately followed by a display formula, and preceded by a paragraph which does not end with punctuation. Should it should be moved after the display formula or after the para following the display formula?

Thank you!!! Brilliant explanation and helpful screenshot :-)

Action: All figure supplements in research content should have the label 'Figure 0—figure supplement 0.' This error will appear if a figure supplement does not have this label. Exeter will need to fix this.

Suggest adding something about the sequential numbering of figures aka https://github.com/elifesciences/schematron-gitbook/issues/37#issuecomment-670000214

Action: All figure supplements in research content should have the label 'Figure 0—figure supplement 0.' This error will appear if a figure supplement has a label which doesn't begin with the figure number it is associated with. Exeter will need to fix this.

Maybe add an example? eg figure supplement 1, which should have been Figure 1—figure supplement 1

pre-ar-fig-test-3

This is a perfect example of why we should suggest Exeter run the schematron again before sending to author.
@FAtherden-eLife could we hook out the DL/AR and Digest schematrons into another schematron and ask Exeter to run that? An idea?

box-fig-test-1
Error: label for fig inside boxed-text must be in the format 'Box 1—figure 1.', or 'Chemical structure 1.', or 'Scheme 1'.
Action: This error will appear if a figure in a box has a label other than 'Box 0—figure 0.', 'Chemical structure 0.' or 'Scheme 0.'.This will need to be corrected by Exeter.

This might be a question for @FAtherden-eLife or @JGilbert-eLife
Why are 'Chemical structure 1.', or 'Scheme 1' within a box not expected to follow the same format of Box 1—chemical structure 1.', or Box 1—scheme 1'.?

app-fig-sup-test-1
Error: label for fig inside appendix must be in the format 'Appendix 1—figure 1—figure supplement 1.'.
Action: This error will appear if a figure supplement in an appendix has a label other than 'Appendix 0—figure 0—figure supplement 0.' (following this capitalisation exactly i.e. 'Appendix 0—Figure 0—Figure Supplement 0.' is incorrect). This will need to be corrected by Exeter.

Does this also pick up on the missing fullstop at the end of the label and does this need to be mentioned in the action?

fig-title-test-6
Warning: title for XXXXXX begins with 'XXXXXX' - XXXXXX. It is very likely that this requires an overall title instead.
Action: This warning will appear if a title begins with 'Panel' e.g. 'Panel (A) shows a scatter plot of primate ECV and body mass data.' Compare with the submission to see whether this should actually be in the caption and move the text there if so. Additionally, if no title has been provided for the figure in the submission, leave the following query:

The action indicates only Panel is picked up - what other scenarios are picked up by this test? Could we add them too?

fig-group-test-1
Error: fig-group must have one and only one main figure.
Action: In the XML, the fig-group element contains a figure and its figure supplement(s) and/or figure video(s). This element will only be present if the figure has figure supplement(s) and/or figure video(s). This error will appear if a fig-group element has more than one or no main figures. Double check which main figure should be present in this fig-group and correct accordingly (Exeter will need to fix this).

Why are videos mentioned but not source data? Are videos part of this issue or should we not mention videos here?

Action: In the XML, the fig-group element contains a figure and its figure supplement(s) and/or figure video(s). This element will only be present if the figure has figure supplement(s) and/or figure video(s). This error will appear if a fig-group element has no figure supplements or figure-level videos. Double check whether the figure does indeed have no linked figure supplements or videos - if so this element should be removed by Exeter. If the figure should have figure supplements or videos, Exeter will need to add these to the fig-group.

I wonder whether we could make it clearer that the fig-group element is a wrapper that is used if there is more than one figure in a group, so this wrapper is not required if there is just 1 figure.
However, again, source data/code is not mentioned - are they contained within the fig wrapper and that's why?

Action: The only elements allowed as a child of  are  or . This test will fire at all stages for an element which is not one of those in a . The XXXXXX will be the name of the offending element. This likely means that either this element is placed incorrectly in the XML, or there is an unnecessary element in the XML. Exeter will need to correct this.

Would it be more accurate to say "This test will fire at all stages for an element contained directly under fig-group that is not  or .
?

Action: This error will appear if a figure has an ID in a format other than fig0, C0 or S0 (where 0 is a number). Exeter will need to fix this.

could we give some examples of what's a wrong one?

Action: This error will appear if a figure has a label 'Figure 0' and an ID in a format other than fig0 (where 0 is a number). Exeter will need to fix this.

Again, maybe an example of how we've seen this go wrong?

resp-fig-id-test
Error: fig in decision letter/author response must have @id in the format respfig0, or sa0fig0. XXXXXX does not conform to this.
Action: This error will appear if a figure in the decision letter or author response section has an ID in a format other than respfig0 or sa0fig0 (where 0 is one or more digits). Exeter will need to fix this.

It would be good to explain a bit more about the difference between respfig0 and sa0fig0 and give dates for when the change was made so the user knows what content is allowed which?

resp-fig-sup-id-test
Error: figure supplement in decision letter/author response must have @id in the format respfig0s0 or sa0fig0s0. XXXXXX does not conform to this.
Action: This error will appear if a figure supplement in the decision letter or author response section has an ID in a format other than respfig0s0 or sa0fig0s0  (where 0 is one or more digits). Exeter will need to fix this.

Same as above

fig-xref-conformity-2
Error: XXXXXX - figure citation does not appear to link to the same place as the content of the citation suggests it should.
Action: This error will appear if a figure citation links to a different figure from the citation text e.g. if Figure 2 links to Figure 3. Try to add the citation again through Kriya - if this doesn't work, Exeter will need to fix this.
fig-xref-conformity-3
Warning: XXXXXX - figure citation does not appear to link to the same place as the content of the citation suggests it should.
Action: This error will appear if a figure citation links to a different figure from the citation text e.g. if Figure 2 links to Figure 3. Try to add the citation again through Kriya - if this doesn't work, Exeter will need to fix this.

What's the difference between these 2 tests?

fig-xref-test-2
Warning: There is no space between citation and the preceding text - XXXXXX - Is this correct?
Action: This error will appear if there is no space between a figure citation and the text before it, for example 'SeeFigure 2.' Add a space between the citation and the preceding text. However, if the text is 'See Figures 2,3' this is ok to leave.

This test specifically mentions the preceding text so the example of what's OK would not be picked up by this test?

fig-xref-test-14
Warning: citation is preceded by 'XXXXXX'. The 'cf.' is unnecessary and should be removed.
Action: This warning will appear if a figure citation is preceded by 'cf.'  The 'cf.' can be deleted.

Might be helpful to give more context, cf means compare with and it's not house style to keep this?

Warning: XXXXXX permissions - the  for all rights reserved type permissions should usually end with 'further reproduction of this panel/figure would need permission from the copyright holder.', but XXXXXX's doesn't. Is this correct? (There is no 'https://creativecommons.org/' type link so presumed ARR.)

There is a double space between the and for

Action: This warning will appear if a figure caption includes the text 'reproduced from' but there is no permissions information in the XML. If no notes have been left about permissions information to add, query the Production team who will check this with the Editorial team. See more about this here.

Suggested change:

Action: This warning will appear if a figure caption includes the text 'reproduced from' but there is no permissions information tagged in the XML. If no notes have been left about permissions information to add, query the Production team. See more about this here.

reproduce-test-1 to reproduce-test-8
I'd rather delete the text "who will check this with the Editorial team" from all of these.
I don't mind changing it to consult with or discuss with, but it indicates they are in charge of this decision and we have as much right to make the decision of whether this is needed or not, as we've got the experience in another context :-)

Figure with linked video:
Figure with source data:
Figure with source code:
Figure with permissions:
Figure with attributions:

Are these XML examples still to be added?

Amazing, thanks @naushinthomson !

Error: fig must have a @position.

I am confused by this as @position is not an XML attribute we use

So I am also confused by the action:

Action: This error will appear if a figure or figure supplement does not have a position in the XML
The context of the action seems to indicate it's not been cited, not that it does not exist in the XML

It's in the XML, see my comment above https://github.com/elifesciences/schematron-gitbook/issues/37#issuecomment-665860509

pre-ar-fig-test-3

This is a perfect example of why we should suggest Exeter run the schematron again before sending to author.
@FAtherden-eLife could we hook out the DL/AR and Digest schematrons into another schematron and ask Exeter to run that? An idea?

Yeah, it's definitely an option. A more preferable scenario would be that nothing else errors before author (it may of course mean that I have to change some of the other tests because there are still a handful that error pre-author and could be warnings I think), then we don't need to have a DL/Digest specific one.

box-fig-test-1
Error: label for fig inside boxed-text must be in the format 'Box 1—figure 1.', or 'Chemical structure 1.', or 'Scheme 1'.
Action: This error will appear if a figure in a box has a label other than 'Box 0—figure 0.', 'Chemical structure 0.' or 'Scheme 0.'.This will need to be corrected by Exeter.

This might be a question for @FAtherden-eLife or @JGilbert-eLife

Why are 'Chemical structure 1.', or 'Scheme 1' within a box not expected to follow the same format of Box 1—chemical structure 1.', or Box 1—scheme 1'.?

We've not published any Schemas or Chemical structures in boxes. As far as I recall, I think there was one case where might have (presumably it was moved elsewhere in the article during proofing), and doing so would have required development work for Exeter, and so instead we permitted the standard labelling.
Maybe something to broach post-Kriya 2.

I'd like to suggest that the second sentence be reworded to something like
"eLife also allows authors to include figure supplements ('child' figures appended to main figures) to present additional results and analyses, and to associate source data or source code directly with their figures."
I'd also suggest using 'legend' rather than 'caption' in the next sentence - technically, the title and legend are both parts of the caption.

Suggest changing
"If an image has especially poor resolution or the text is illegible,"
to
"If an image has especially poor resolution such that the text or graphics are illegible,"

Suggest changing
"We strongly discourage authors from providing tables represented as figures or figure supplements because figures are flat images and the contents of them cannot be mined or re-used without the need to rekey the content."
to
"We strongly discourage authors from providing tables represented as figures or figure supplements as data presented in flat images cannot be mined or re-used without being manually rekeyed."

Sorry, I got carried away and wrote out queries for the tables as images in the content processing page! There are two variants of this situation, one for main figures and one for figure supplements - these have different solutions, so I drafted the following:

We noticed that this figure only contains a table. eLife’s policy is to avoid including these as flat images wherever possible. Given this, please could you provide this table as an editable Word or Excel file so that we can include it as a main table.
We noticed that this figure supplement only contains a table. eLife’s policy is to avoid including these as flat images wherever possible. Given this, please could you provide this table as a Word, Excel or PDF file so that we can include it as source data for the related figure.

What do you think?

For Multi-page files, is it worth covering Word or Powerpoint files as well? I'm not sure if these have led us into this problem in the past, but it is possible.

"the legend should be the same width as the image block" - when isn't it? I don't think we've ever had an issue with the legend, only the images not being the full width.

"For smaller figures, these can be left the size they are:" - I wonder if we need some more comprehensive guidance on this. For example, the image you've shown could easily be made a half-column width and that probably would be OK due to the simplicity of the image. But we might have a case where a more complex image is provided and it should be placed at the full-page width, but the resolution of the image isn't high enough to support that.

Suggest changing ". . . of panel a (e.g. “(a) The high-resolution . . ." to ". . . of panel A (e.g. “(A) The high-resolution . . ." for clarity of reading.

"Part labels should be captured as such in Kriya (by right-clicking and selecting 'part label')."
So . . . is it worth explaining why we do this? Because it's mostly just to ensure they end up in bold font. Nominally, the style tagging is supposed to allow us to cite individual panels but that's never worked. Should we clarify as "should be styled as such so that they appear in bold in the final article (by right-clicking and selecting 'part label' in Kriya)." ?

Also, do we need to have explicit instructions to update the X and Y in the queries to the appropriate values?

". . . labelled Figure 1—source data 1 but the title makes it clear that the data is linked to a figure supplement . . ." - might not be the title - the citation that conflicts with the hierarchy could be in the legend. Replace 'title' with 'caption'?

I wonder whether we could make it clearer that the fig-group element is a wrapper that is used if there is more than one figure in a group, so this wrapper is not required if there is just 1 figure.
However, again, source data/code is not mentioned - are they contained within the fig wrapper and that's why?

Source data/code is within the fig wrapper, yeah - a figure with source data won't have a fig-group unless it also has fig-supplements or a related video.

For fig-title-test-6 and possibly other points discussing missing overall titles, we should make sure to cover examples where the current title is OK because it covers all panels e.g. "Results from experiment 1 (A) and experiment 2 (B)." I'd assume this wouldn't fire that test, but it's definitely something Exeter will need to know about.

Also, for fig-title-test-3, isn't our style to have vs without the fullstop?


[ITensors] [BUG] #1006

Fix autompo unit tests when pwd!=ITensors/test.  Use a calculated absolute path, as suggest by Matt.

Codecov Report

Merging #1008 (a5afa7f) into main (ddb4da7) will decrease coverage by 0.12%.
The diff coverage is n/a.

:exclamation: Current head a5afa7f differs from pull request most recent head 014f60a. Consider uploading reports for the commit 014f60a to get more accurate results

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   65.02%   64.90%   -0.13%
==========================================
  Files          97       97
  Lines       10170    10169       -1
==========================================
- Hits         6613     6600      -13
- Misses       3557     3569      +12

Impacted Files
Coverage Δ

src/ITensorChainRules/ITensorChainRules.jl
84.61% <0.00%> (-7.70%)
:arrow_down:

src/tensor_operations/matrix_algebra.jl
93.02% <0.00%> (-2.33%)
:arrow_down:

src/physics/lattices.jl
95.65% <0.00%> (-2.18%)
:arrow_down:

src/mps/sweeps.jl
90.69% <0.00%> (-1.17%)
:arrow_down:

src/tagset.jl
86.95% <0.00%> (-1.09%)
:arrow_down:

src/ITensorChainRules/mps/abstractmps.jl
88.17% <0.00%> (-1.08%)
:arrow_down:

src/qn/qn.jl
88.51% <0.00%> (-0.86%)
:arrow_down:

src/LazyApply/LazyApply.jl
80.10% <0.00%> (-0.52%)
:arrow_down:

src/physics/sitetype.jl
90.78% <0.00%> (-0.44%)
:arrow_down:

src/mps/abstractmps.jl
86.51% <0.00%> (-0.26%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks!


[bug]: Uninstall/reinstall requires reconfiguring dependents

Steps to reproduce:

Install LND and RTL
Configure and run both services
Stop LND
Uninstall LND (optionally back it up somewhere)
Reinstall LND
Configure LND
Visit RTL in the browser
RTL refuses to connect to LND

If I then stop RTL and reconfigure it, it starts working again.

The fix for this is twofold:

If a pointer is pointing to a resource that no longer exists, dereferencing it should yield the null value. This is supposedly already true for ConfigPointers but needs to be true for pointers of other types.
If a resource is restored, the pointers that have references to it should have the values updated to reflect the new values.

CC @dr-bonez

/current-dependents/<id>/pointers is an array of all pointers that need to be updated in dependents.

Before someone reopens this aggressively saying that dependent services still need to be restarted. This is a broader issue with how to handle the dynamism of pointer volumes. Further work on this is captured in #1073. For now, we no longer require reconfiguring the dependent to ingest those changes, but we do require restarting it if the service depends on pointer volume data for essential function. In the mean time, if you depend on critical data in a pointer volume and it isn't available on service startup, the current recommendation is to exit with a ZERO exit code. This WILL put your service into a crash loop while it waits for those volumes to be available. This is palatable assuming that this broken state is transient while you reinstall/reconfigure/restart the dependency.


fix: code snippet

:tada: This PR is included in version 0.8.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add "About thoughtbot" to README

ping @georgebrock

@jferris Sorry for the slow reply, I've been on vacation without any Internet access. This looks good to me.


[stable/postgresql] postgresql.conf conversion fails to quote values

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug report

Version of Helm and Kubernetes:
k8s 1.9.3
helm 2.9.1
Which chart:
postgresql
What happened:
I converted my config file from postgres to yaml. When the pod initialized, it failed to start, because option values are not quoted.
What you expected to happen:
I would expect the configuration file to be parse by postgres and the server to start.
How to reproduce it (as minimally and precisely as possible):
cat <<EOT > /tmp/yaml
persistent:
  enabled: false
postgresqlConfiguration:
  maxConnections: '100'
  unixSocketDirectories: '/run/postgresql,/tmp'
  sharedBuffers: '128MB'
  dynamicSharedMemoryType: 'posix'
  sharedPreloadLibraries: 'pg_stat_statements'
  logTimezone: 'UTC'
  datestyle: 'iso, mdy'
  timezone: 'UTC'
  defaultTextSearchConfig: 'pg_catalog.english'
EOT

helm install --name pg -f /tmp/yaml stable/postgresql

The pod will fail, because of a syntax errors in the postgresql.conf

kubectl exec -ti pg-postgresql-0 /bin/bash

I have no name!@pg-postgresql-0:/$ cat -n /opt/bitnami/postgresql/conf/postgresql.conf
    1 datestyle=iso, mdy
    2 default_text_search_config=pg_catalog.english
    3 dynamic_shared_memory_type=posix
    4 log_timezone=UTC
    5 max_connections=100
    6 shared_buffers=128MB
    7 shared_preload_libraries=pg_stat_statements
    8 timezone=UTC
    9 unix_socket_directories=/run/postgresql,/tmp

I have no name!@pg-postgresql-0:/$ postgres --config-file=/opt/bitnami/postgresql/conf/postgresql.conf
2018-12-03 17:17:30.582 GMT [67] LOG:  syntax error in file "/opt/bitnami/postgresql/conf/postgresql.conf" line 1, near token ","
2018-12-03 17:17:30.582 GMT [67] LOG:  syntax error in file "/opt/bitnami/postgresql/conf/postgresql.conf" line 2, near token "pg_catalog.english"
2018-12-03 17:17:30.582 GMT [67] LOG:  syntax error in file "/opt/bitnami/postgresql/conf/postgresql.conf" line 9, near token "/"
2018-12-03 17:17:30.582 GMT [67] FATAL:  configuration file "/opt/bitnami/postgresql/conf/postgresql.conf" contains errors

Anything else we need to know:
Converting an exiting config file from postgres to yaml is cumbersome. The quoting issue could be easily resolved if the postgresqlConfiguration was a string, rather than a YAML data structure.

@prydonius @juan131
Dunno how issues are bubbled up, thought I'd give you a ping.

I encounter the same issue and the template miss the quota, I use the following config as workaround
postgresqlConfiguration:     "sharedBuffers": "'1GB'"     "maxConnections": 1000     "listenAddresses": "'*'"

Hi @flah00 @KeZhang
As you may find in the README.md below:
https://github.com/helm/charts/blob/master/stable/postgresql/files/README.md
You can put your postgresql.conf under the files/ directory. That'll be much easier than trying to pass your configuration through the values.yaml.

But how can I add the files if I use the remote repo to deploy?

Hi @KeZhang
You can clone the repo locally (or just clone the stable/postgresql directory).
Another alternative would be using the workaround you suggested to "scape" the single quotes as you mentioned.

This will work for newer configurations
postgresqlConfiguration: {"maxConnections": "300", "sharedBuffers": "500MB", "listenAddresses": "'*'"}


Lazy load connectors

Instead of injecting the connector riot tags directly in the process manager riot tag collection, each connector should provide the link to its process manager module. The module can then be lazy loaded and added to the process manager.

Sub task of #25


undefined method checksum' for class TTFunk::Subset::Base' (NameError)

asciidoctor-pdf fails on my system with the following traceback:
$ bundle exec asciidoctor-pdf -v
Traceback (most recent call last):
	11: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/.bundle/gems/ruby/2.5.0/bin/ruby_executable_hooks:24:in `<main>'
	10: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/.bundle/gems/ruby/2.5.0/bin/ruby_executable_hooks:24:in `eval'
	 9: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/.bundle/gems/ruby/2.5.0/bin/asciidoctor-pdf:23:in `<main>'
	 8: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/.bundle/gems/ruby/2.5.0/bin/asciidoctor-pdf:23:in `load'
	 7: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/bin/asciidoctor-pdf:5:in `<top (required)>'
	 6: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/bin/asciidoctor-pdf:5:in `require'
	 5: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf.rb:6:in `<top (required)>'
	 4: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf.rb:6:in `require_relative'
	 3: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf/converter.rb:5:in `<top (required)>'
	 2: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf/converter.rb:5:in `require_relative'
	 1: from /home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf/ext/ttfunk.rb:4:in `<top (required)>'
/home/andre/repos/github/asciidoctor/asciidoctor-pdf/lib/asciidoctor/pdf/ext/ttfunk.rb:5:in `<class:Base>': undefined method `checksum' for class `TTFunk::Subset::Base' (NameError)

$ ruby --version
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]

This happens also with other ruby versions, e.g. 2.7.0, and released versions of asciidoctor-pdf, e.g. asciidoctor-pdf-1.5.0.beta.8.
$ ruby --version
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]

How can i fix this?

Having the same issue here. Trying to run asciidoctor-pdf on Github Actions.
/opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf/ext/ttfunk.rb:4:in `<class:Base>': undefined method `checksum' for class `TTFunk::Subset::Base' (NameError)
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf/ext/ttfunk.rb:3:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf/converter.rb:4:in `require_relative'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf/converter.rb:4:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf.rb:5:in `require_relative'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/lib/asciidoctor/pdf.rb:5:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/asciidoctor-pdf-1.5.0.beta.8/bin/asciidoctor-pdf:5:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/bin/asciidoctor-pdf:23:in `load'
	from /opt/hostedtoolcache/Ruby/2.6.3/x64/bin/asciidoctor-pdf:23:in `<main>'
##[error]Process completed with exit code 1.

A new version of ttfunk was released today and it broke the API that Asciidoctor PDF uses. While we work out a solution, you can downgrade the version of ttfunk to 1.5.1.

This affects the patch for https://github.com/prawnpdf/ttfunk/issues/39, which we may no longer need.

Thank you, downgrade the version of ttfunk to 1.5.1 helped.


Prove that caught up event is emitted more than once

Hey @damianh, can you work with this?
 Previous -1
2017-08-25 09:28:56.344 +02:00 [Verbose] Polling head position 29. Previous 29
2017-08-25 09:28:56.380 +02:00 [Debug] GetStreamMetadata "stream-1".
2017-08-25 09:28:56.404 +02:00 [Debug] Page.IsEnd [False]
2017-08-25 09:28:56.404 +02:00 [Debug] lastHasCaughtUp []
2017-08-25 09:28:56.405 +02:00 [Debug] page.Messages.Length [10]
2017-08-25 09:28:56.405 +02:00 [Debug] ReadAllForwards from position 10 with max count 10.
2017-08-25 09:28:56.407 +02:00 [Debug] ReadAllForwards from position 20 with max count 10.
2017-08-25 09:28:56.408 +02:00 [Debug] Page.IsEnd [True]
2017-08-25 09:28:56.408 +02:00 [Debug] lastHasCaughtUp [False]
2017-08-25 09:28:56.408 +02:00 [Debug] page.Messages.Length [10]
2017-08-25 09:28:56.408 +02:00 [Debug] ReadAllForwards from position 30 with max count 10.
2017-08-25 09:28:56.409 +02:00 [Debug] ReadAllForwards from position 30 with max count 10.
2017-08-25 09:28:56.410 +02:00 [Debug] Page.IsEnd [True]
2017-08-25 09:28:56.410 +02:00 [Debug] lastHasCaughtUp []
2017-08-25 09:28:56.410 +02:00 [Debug] page.Messages.Length [0]
2017-08-25 09:28:56.449 +02:00 [Information] All stream subscription dropped 65d35bd5-b89c-4974-818f-f4dd8e34d0f6. Reason: Disposed

Not sure what to make of this: the page is at its end, but still has messages left. Is that desired behavior?
Anyways, HTH.

Thanks, @koenmetsu ! Will have a look at the weekend.


Windows. Failed build on the mounted network disk.

Nuitka is running on the Windows 10 in VirtualBox.
Linux host directory "dd" shared to the virtual PC as a network disk "\VBOXSVR\dd", which is automatically mounted as disk "Z:".
This is a standard way to share directories in VirtualBox with the guest Windows.
Building inside shared disk makes possible using of the host utilities and editors to edit source files.
Python installed from the official site, nuitka installed via pip.

python -m nuitka --version

2.0.5
Commercial: None
Python: 3.11.8 (tags/v3.11.8:db85d51, Feb  6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)]
Flavor: CPython Official
Executable: C:\Program Files\Python311\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: ~\AppData\Local\Nuitka\Nuitka\Cache\downloads\gcc\x86_64\13.2.0-16.0.6-11.0.1-msvcrt-r1\mingw64\bin\gcc.exe (gcc 13.2.0).

cat 1.py

print("Hello world!")

PS Z:> python.exe -m nuitka 1.py

Nuitka-Options: Used command line options: 1.py
Nuitka-Options:WARNING: You did not specify to follow or include anything but main program. Check options and make sure
Nuitka-Options:WARNING: that is intended.
Nuitka: Starting Python compilation with Nuitka '2.0.5' on Python '3.11' commercial grade 'not installed'.
Nuitka: Completed Python level compilation and optimization.
Nuitka: Generating source code for C backend compiler.
Nuitka: Running data composer tool for optimal constant value handling.
Nuitka: Running C compilation via Scons.
Nuitka-Reports: Compilation report written to file 'nuitka-crash-report.xml'.
Traceback (most recent call last):
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\__main__.py", line 175, in <module>
    main()
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\__main__.py", line 161, in main
    MainControl.main()
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\MainControl.py", line 1131, in main
    _main()
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\MainControl.py", line 989, in _main
    result, scons_options = compileTree()
                            ^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\MainControl.py", line 906, in compileTree
    result, scons_options = runSconsBackend()
                            ^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\MainControl.py", line 757, in runSconsBackend
    runScons(
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\build\SconsInterface.py", line 276, in runScons
    options["result_name"] = getExternalUsePath(
                             ^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\utils\FileOperations.py", line 1182, in getExternalUsePath
    dirname = getWindowsShortPathName(os.path.dirname(filename))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\utils\FileOperations.py", line 1107, in getWindowsShortPathName
    raiseWindowsError("getWindowsShortPathName for %s" % filename)
  File "C:\Program Files\Python311\Lib\site-packages\nuitka\utils\Utils.py", line 416, in raiseWindowsError
    raise WindowsError(
ProcessLookupError: [Errno 3] getWindowsShortPathName for \\VBoxSvr\dd\VBoxSvr\dd (The system cannot find the path specified.)
Nuitka-Reports: Compilation crash report written to file 'nuitka-crash-report.xml'. Please include it in your bug
Nuitka-Reports: report.

Crash report renamed to the txt-file is attached.
nuitka-crash-report.txt

Ah, we had a solution for this and compiled programs at runtime, but that's of course different. I am not confident all the tools are working with the network paths rather than filenames, there is a reason we want to use short paths there, and MinGW64 is among those tools if I recall correctly. Not sure if it's possible (easily) to turn a network path into a drive letter using path.

The report hides cwd and so it's hard to tell, but you were not using Z: as the current working directory, but the server mount path, right?

The report hides cwd and so it's hard to tell, but you were not using Z: as the current working directory, but the server mount path, right?

Not sure I understand your question. Current path is namely disk "Z:" :
PS Z:\> pwd

Path
----
Z:\

PS Z:\> get-variable pwd

Name                           Value
----                           -----
PWD                            Z:\

Ok, so it seems the \\VBoxSvr comes from some realpath call then, so compiling on netdrives is broken entirely then.

I added a fix for that and it's going to be in 2.1, right now it's on the develop branch. I am closing this early, with the release being immanent.


[feature request] macOS support

one thing shader competitors such as roshade is lacking is support for macOS -- if you were to implement this, i'm sure it would substantially grow bloxshade's userbase.

oh


Enables UnboundedSource wrapped SDF Kafka source by default for Python x-lang

This is done temporarily due to #21730.
We can change back to using pure SDF Kafka source (by removing the usage of experiment 'use_unbounded_sdf_wrapper') when we are confident about the stability of the pure SDF Kafka source.
Also, adds support for appending args when starting up the expansion service and adds some missing pydocs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @johnjcasey

LGTM


Add typing-extensions to the list of dependencies?

typing_extensions is imported in xarray/core/npcompat.py and xarray/core/utils.py.
However, typing-extensions is not a dependency in setup.cfg, and I get the following error when I install with pip install git+https://github.com/pydata/xarray using python 3.9:
import xarray

ModuleNotFoundError: No module named 'typing_extensions'

Great spot! We should definitely add that.
I wonder how CI passes, then?

Looks like there isn't an action that only installs xarray using pip, but dependencies are installed first using conda. Must be in the conda recipe of one of the packages specified in the CI environments?

Yes, good point.
Would you be up for another PR @malmans2 ?

Can we consider making typing-extensions a fully optional dependency instead?
In particular, typing-extensions 3.10 is a very new version, only from May 2021. This seems overly restrictive, particularly for a dependency that isn't really needed at all at runtime and that we only use for a few type annotations.

@shoyer I added typing-extensions in the docs too, so you'd have to remove it from there as well: https://github.com/shoyer/xarray/blob/typing-extensions-optional/doc/getting-started-guide/installing.rst

I made an attempt at making the use of TypeGuard optional, but it doesn't pass mypy yet: https://github.com/pydata/xarray/pull/5624

Using typing_extensions seems to be a nice way to get backwards compatibility with older python versions.
I can see some typing bugs slipping through rather easily onsidering how picky mypy is and the CI doesn't do mypy checks on all python versions.

As soon as libraries like Beam allow installing later versions, I would vote to add this back.


Cropping map fragment removes more than needed

Hi,
Found your project looking for something to crop my Google map to a rounded corners shape. Nothing worked so far. I tried yours and it seems to remove too much. Somehow all the map content is removed, while the minimal Google Map UI can notice is cropped off to the shape I used.
Left side using the maskable_layout, right side plain map fragment. https://drive.google.com/file/d/16aivbVtTkgFm7eOSF6BWaYlagUwTkFO_/view?usp=sharing
Any idea what is happening and why the entire map layer is disappearing?
Thanks.

Hey George,
I cant see the image but I assume the google maps view is completely black.
Chances are high that the porterduff mode you are using only supports software rendering, and since google maps is highly optimized I wouldn't be surprised if it was rendered with hardware acceleration.
Setting the layer to software will probably not be a solution. You can apply masking and other effects using shaders, but this library only supports software layers, not hardware.
Some modes should work like PorterDuff.Mode.SRC_IN in hardware layers.
I would suggest trying it with hardware supported modes, else you will have to use shaders.

Appreciate the quick reply. I tried the SRC_IN mode. I am getting the same result.  Can click the image url again. I made sure it is public.
Will have to get informed about shaders. I don't know how to use them yet.

Romain guy had some great info about this subject.
His blog seems to be offline: https://web.archive.org/web/20140318001921/http://www.curious-creature.org/2012/12/11/android-recipe-1-image-with-rounded-corners/
Anyway, I'm gonna close this as it only supports software layers and I think the hardware rendering of google maps is the problem.
I suggest adding a background to the google maps container instead of making it 'float'. Then you can overlay rounded corners. Its not as clean tho.
If you found a way, I'd love to hear the solution.
Good luck!


Update Freeze transaction to use instant in time

Problem
Use startTime of Instant to specify freeze transaction start.
Solution
Need to make the following change of the FreezeTransactionBody:
message FreezeTransactionBody {
    int32 startHour = 1 [deprecated = true]; // The start hour (in UTC time), a value between 0 and 23
    int32 startMin = 2 [deprecated = true]; // The start minute (in UTC time), a value between 0 and 59
    int32 endHour = 3 [deprecated = true]; // The end hour (in UTC time), a value between 0 and 23
    int32 endMin = 4 [deprecated = true]; // The end minute (in UTC time), a value between 0 and 59
    FileID updateFile = 5; // The ID of the file needs to be updated during a freeze transaction
    bytes fileHash = 6; // The hash value of the file, used to verify file content before performing freeze and update
    Timestamp startTime = 7; // the freeze start Timestamp
 }

Alternatives
No response

Stale.  Please reopen if still needed.


Unit Test for k8s/events

Closes: RHOAIENG-2154
Description
Unit test case for: frontend/src/api/k8s/events.ts
How Has This Been Tested?
'npm run test'
Test Impact
Coverage:

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve


Add Collection[nth:] subscript for getting element with negative index.

It allows you to access elements in a more intuitive way.
let arr = [1, 2, 3, 4, 5]
arr[-1] // -> 5
arr[-2] // -> 4

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 528 tests, with 0 failures (0 unexpected) in 11.904 (17.136) seconds

:book:
tvOS: Executed 497 tests, with 0 failures (0 unexpected) in 4.098 (5.323) seconds

:book:
macOS: Executed 362 tests, with 0 failures (0 unexpected) in 1.159 (1.456) seconds

  Generated by :no_entry_sign: Danger

You can kind of make this generic by doing it like this:
extension Collection {
    public subscript(nth offset: Int) -> Element {
        let index = offset >= 0 ? startIndex : endIndex
        return self[indices.index(index, offsetBy: offset)]
    }
}

@guykogus Hi, this feature is very common in other languages(ruby, python). It allows you to access elements in a more intuitive way. For example, if you want to get the third element from the end, you can write arr[-3] instead of arr[length - 3].

You can kind of make this generic by doing it like this:
extension Collection {
    public subscript(nth offset: Int) -> Element {
        let index = offset >= 0 ? startIndex : endIndex
        return self[indices.index(index, offsetBy: offset)]
    }
}

Unless it's BidirectionalCollection

cc @SD10 @omaralbeik
Pinging for your review :))


Sort out the issue with API documentation

Some pages in the Api documentation can not be browsed from GitHub as the http server mangles them:
https://github.com/apple/swift-docc-plugin/issues/66

Fixed by adding a .nojekyll file in the root and docs directory, not sure which one is right.


adding "mood chart" tooling content under stand-ups folder

why to use it? how to use it? why is it critical in agile debugging?

@gldnblgty - is this issue still relevant, and active or ok to close?