Trouble with hyper-parameters and additional features

Hi, I'm having some trouble tuning my model (Deep AR), and deciding whether to add or remove some features.
This is because I've noticed training the model repeatedly on the same input data and with the same parameters will result in slightly different forecasts and therefore different error metrics. (I'm assuming this is due to the random nature of the sampling)
Given this, how would one go about performing hyper-parameter tuning, or adding features and checking if they're improving the performance? I considered training the model 5 times with each hyper-parameter and feature configuration and averaging the metrics, is that standard practice?

@mariosantosprivate How big is the difference? For hyperparameter tuning I usually use only a singlerun since the difference in the error metric is often large enough to select a set of hyperparameters.

@mariosantosprivate How big is the difference? For hyperparameter tuning I usually use only a single run since the difference in the error metric is often large enough to select a set of hyperparameters.

I ran it twice with the same data and parameters and got these results:
1st run
MASE	0.357692
MAPE	0.139326
sMAPE	0.277678
MSIS	2.481089
RMSE	1,581.499704
NRMSE	0.260639
MRMSSE	0.152469
ND	0.168609
2nd run
MASE	0.442053
MAPE	0.172011
sMAPE	0.291773
MSIS	2.623137
RMSE	1,876.670623
NRMSE	0.309285
MRMSSE	0.213165
ND	0.209158
Do you think the differences are significant?
Code:
train_ds = ListDataset([
    {
        FieldName.TARGET: target,
        FieldName.START: start,
        FieldName.FEAT_DYNAMIC_REAL: fdr,
        FieldName.FEAT_STATIC_CAT: fsc
    }
    for (target, start, fdr, fsc) in zip(train_target_values,
                                         dates,
                                         train_dynamic_features_list,
                                         stat_cat)
], freq="D")

test_ds = ListDataset([
    {
        FieldName.TARGET: target,
        FieldName.START: start,
        FieldName.FEAT_DYNAMIC_REAL: fdr,
        FieldName.FEAT_STATIC_CAT: fsc
    }
    for (target, start, fdr, fsc) in zip(test_target_values,
                                         dates,
                                         test_dynamic_features_list,
                                         stat_cat)
], freq="D")

deepAR_estimator = DeepAREstimator(
    prediction_length=prediction_length,
    context_length=2*prediction_length,
    freq="D",
    num_layers=5,
    num_cells=40,
    distr_output = NegativeBinomialOutput(),
    use_feat_dynamic_real=True,
    use_feat_static_cat=True,
    cardinality=stat_cat_cardinalities,
    dropout_rate=0.1,
    trainer=Trainer(
        learning_rate=1e-3,
        epochs=15,
        num_batches_per_epoch=500,
        batch_size=32
    )
)

@mariosantosprivate How big is your dataset? I think just 15 epochs for training are not much.

@kaijennissen the dataset consists of 934 time series each with 942 time points (daily sales)
I'm using 30 features (weather, promotion etc) as feat_dynamic_real, and 4 features as feat_static_cat (store_id, store_type, city)

@mariosantosprivate What is your prediction_length? For daily sales I would try to use at least 7 days as context_length.
I usually use 200 epochs in combination with early_stopping (which is achived by supplying an additional dataset like this 'estimator.train(training_data=train_ds, validation_data=val_ds)). In addition I would increase the batch_sizeand decrease thenum_batches_per_epoch`.
Of couse all these parameters can be fined tuned, but the early_stopping ensures that you stop training as soon as you are not getting better but also not to early, which I guess is the case with your current number pf epochs.

@mariosantosprivate What is your prediction_length? For daily sales I would try to use at least 7 days as context_length.
I usually use 200 epochs in combination with early_stopping (which is achived by supplying an additional dataset like this 'estimator.train(training_data=train_ds, validation_data=val_ds)). In addition I would increase the batch_sizeand decrease thenum_batches_per_epoch`.
Of couse all these parameters can be fined tuned, but the early_stopping ensures that you stop training as soon as you are not getting better but also not to early, which I guess is the case with your current number pf epochs.

@kaijennissen My prediction length is 48 days, so context length is 96 in this case. I thought that early stopping didn't need the validation set, as I've witnessed it stop before achieving the total number of epochs previously (at the time tried with 100 epochs, and training stopped by itself around epoch 80, no validation set supplied)
I'm already performing validation by not using the last prediction_length in training while tuning hyper-parameters, would it still make sense to use the validation_data you mentioned? And if so what data should that validation set contain?

@mariosantosprivate Yes, early_stopping does not need a validation set but without the validation set, the model trains as long as the training loss decreases. Using a validation set training stops as soon as the loss on the validation set (and therefore on unseen data) does not decrease any further.
My recommendation would be to have three datasets (train, validation, test).
Where validation as well as test contains observations which were not used for training. F.e. 2018 as training set,the first half of 2019 as validation set and the second half of 2019 as test.

@mariosantosprivate Yes, early_stopping does not need a validation set but without the validation set, the model trains as long as the training loss decreases. Using a validation set training stops as soon as the loss on the validation set (and therefore on unseen data) does not decrease any further.
My recommendation would be to have three datasets (train, validation, test).
Where validation as well as test contains observations which were not used for training. F.e. 2018 as training set, the first half of 2019 as validation set and the second half of 2019 as test.

Thank you very much I will try that!
Just to close the original question and make sure I understood correctly, given enough epochs there should be no significant differences in metrics when training a model with the same input and parameters?

@mariosantosprivate Given enough data, I would hope that a global minimum is reached and therefore results from different runs are comparable. See for example my results (code below) from two runs with DeepAR on the electricity dataset.
Run 1:

MASE: 0.8078506007638229
MAPE: 0.09673023279096417
sMAPE: 0.11191548997159273

Run 2:

MASE: 0.8161786940956743
MAPE: 0.09720666821452344
sMAPE: 0.11201153361129423

from gluonts.dataset.repository.datasets import get_dataset
from gluonts.evaluation import Evaluator
from gluonts.evaluation.backtest import make_evaluation_predictions
from gluonts.model.deep_factor import DeepFactorEstimator
from gluonts.model.deepar import DeepAREstimator
from gluonts.trainer import Trainer
from gluonts.mx.distribution import StudentTOutput

dataset = get_dataset("electricity")
metadata = dataset.metadata

deepar = DeepAREstimator(
    freq=metadata.freq,
    prediction_length=72,
    context_length=168,
    num_layers=1,
    num_cells=50,
    cell_type="lstm",
    dropout_rate=0.1,
    scaling=True,
    distr_output=StudentTOutput(),
    trainer=Trainer(),
)

deepfactor = DeepFactorEstimator(
    freq=metadata.freq,
    prediction_length=72,
    context_length=168,
    num_layers_global=1,
    num_hidden_global=50,
    num_factors=10,
    num_layers_local=1,
    num_hidden_local=5,
    cell_type="lstm",
    distr_output=StudentTOutput(),
    trainer=Trainer(),
)

def main(estimator):

    predictor = estimator.train(
        training_data=dataset.train, num_workers=8)

    QUANTILES = [0.1, 0.9]
    evaluator = Evaluator(
        quantiles=QUANTILES,
        num_workers=8
    )

    forecast_it, ts_it = make_evaluation_predictions(
        dataset=dataset.test,
        num_samples=200,
        predictor=predictor,
    )

    forecasts = list(forecast_it)
    tss = list(ts_it)
    agg_metrics, item_metrics = evaluator(tss, forecasts)

    metrics = [
        "MASE",
        "MAPE",
        "sMAPE",
    ] + \
        [
        f"QuantileLoss[{QUANTILES[i]}]" for i in range(len(QUANTILES))] + \
        [
        f"Coverage[{QUANTILES[i]}]" for i in range(len(QUANTILES))
    ]

    for metric in metrics:
        print(f"{metric}: {agg_metrics[metric]}")

if __name__ == "__main__":

    main(deepar)

Solved, thank you!

I'm new to gluton, and the estimator's train is not like pytorch, the training and validation phase are separate. such as,
    predictor = estimator.train(
        training_data=dataset.train, num_workers=8)

    QUANTILES = [0.1, 0.9]
    evaluator = Evaluator(
        quantiles=QUANTILES,
        num_workers=8
    )

    forecast_it, ts_it = make_evaluation_predictions(
        dataset=dataset.test,
        num_samples=200,
        predictor=predictor,
    )

It's not like pytorch,
for epoch in range(num_epoches):
    train()
    eval()

I want to know how to apply early_stopping to estimator? Thanks so much! @kaijennissen

I'm new to gluton, and the estimator's train is not like pytorch, the training and validation phase are separate. such as,
    predictor = estimator.train(
        training_data=dataset.train, num_workers=8)

    QUANTILES = [0.1, 0.9]
    evaluator = Evaluator(
        quantiles=QUANTILES,
        num_workers=8
    )

    forecast_it, ts_it = make_evaluation_predictions(
        dataset=dataset.test,
        num_samples=200,
        predictor=predictor,
    )

It's not like pytorch,
for epoch in range(num_epoches):
    train()
    eval()

I want to know how to apply early_stopping to estimator? Thanks so much! @kaijennissen

Hello @bugsuse, if I understood correctly, as @kaijennissen mentioned you supply the estimator with a validation dataset, as follows:

(...) I usually use 200 epochs in combination with early_stopping (which is achived by supplying an additional dataset like this 'estimator.train(training_data=train_ds, validation_data=val_ds)`) (...).

So for your example:
predictor = estimator.train(training_data=dataset.train, validation_data = dataset.val, num_workers=8)

Say your dataset.train has 90 days of data, split it so that dataset.train has 70 days and dataset.val has 90 days for example (including the 70 days in dataset.train)
I hope that helps!

I'm new to gluton, and the estimator's train is not like pytorch, the training and validation phase are separate. such as,
    predictor = estimator.train(
        training_data=dataset.train, num_workers=8)

    QUANTILES = [0.1, 0.9]
    evaluator = Evaluator(
        quantiles=QUANTILES,
        num_workers=8
    )

    forecast_it, ts_it = make_evaluation_predictions(
        dataset=dataset.test,
        num_samples=200,
        predictor=predictor,
    )

It's not like pytorch,
for epoch in range(num_epoches):
    train()
    eval()

I want to know how to apply early_stopping to estimator? Thanks so much! @kaijennissen

Hello @bugsuse, if I understood correctly, as @kaijennissen mentioned you supply the estimator with a validation dataset, as follows:

(...) I usually use 200 epochs in combination with early_stopping (which is achived by supplying an additional dataset like this 'estimator.train(training_data=train_ds, validation_data=val_ds)`) (...).

So for your example:
predictor = estimator.train(training_data=dataset.train, validation_data = dataset.val, num_workers=8)

Say your dataset.train has 90 days of data, split it so that dataset.train has 70 days and dataset.val has 90 days for example (including the 70 days in dataset.train)
I hope that helps!

Sorry for I ignored the information! Thanks a lot! @mariosantosprivate


showing white blank screen when app is idle for some time

app is created with create-react-app. so problem is the app shows white blank screen when idle for some time with no console errors, and it doesn't happen frequently or every time, but has faced this issue when not expected. i had open duplicate tabs with same route and for same time, but saw that the tab which i was working got blank screen after getting idle and other tab on which i was not working was not effected.

Does refreshing the page make it work again?

Yes, on refresh it does work.

Happens to me as well

I am also experiencing this phenomenon. After some (very random) time the app disappears into thin air without any error in the console. Very strange...

I am also experiencing this phenomenon. After some (very random) time the app disappears into thin air without any error in the console. Very strange...

Hi. Have you found the solution. I am facing the same issue

Happens to me as well

Have you found the solution. I am facing the same issue

app is created with create-react-app. so problem is the app shows white blank screen when idle for some time with no console errors, and it doesn't happen frequently or every time, but has faced this issue when not expected. i had open duplicate tabs with same route and for same time, but saw that the tab which i was working got blank screen after getting idle and other tab on which i was not working was not effected.

Have you found any solution for this?

I am also experiencing this phenomenon. After some (very random) time the app disappears into thin air without any error in the console. Very strange...

Have you found any solution for this?

Happens to me as well

Have you found any solution for this?

@Kamaldeep-j No solution found. But i can tell you that this is not happening in production environment / build. This error with local/dev environment. kindly share details if issue found in production env/build.

@Kamaldeep-j No solution found. But i can tell you that this is not happening in production environment / build. This error with local/dev environment. kindly share details if issue found in production env/build.

We are also facing this issue. +1

We are facing exactly the same issue. Can anyone suggest some work around?

We are facing similar issue.
Device: iPad
Browser: Chrome 87
ReactJs Web application is showing blank white page when application left idle for few seconds (within a minute).
This is happening only in Production.
Has anyone found the solution on this issue?

This is happening only in Production.

Using the built/minified files? Are there any console logs for it?

same issue

Same issue here too.

Same issue. Any updates?

Same issue here.

same issue

We are experiencing a similar issue without a clear reproducible pattern.
Have anyone dug deeper to understand the root cause? Memory leak/High CPU?
Thank you.

Only thing I was able to spot during debugging is that the react DOM does not seem to be mounted. If you check the Elements tab in your browser you'll notice that react did not load at all. The root div is empty. Why it does not load... no clue.

Same issue here. The same error message showed in the console after ide for 3 hours.

Same issue here. (production build)  If I leave a react app open in mobile chrome browser tab overnight, when I activate that tab in the morning, I get a blank white page.  However if I refresh the page, the app loads and works properly.  This behavior is not seen on other apps I developed in Angular

Facing the same issue. Any way to solve this?

I see the same error as well - also in production.

My issue was a low internet connection caused by strip. i solved this issue with error boundaries. so whenever a strip error occurs it shows the error boundary's fallback that where I place the refresh button.

I've experienced the same issue. You may try to put setInterval function setInterval(() => { console.log("hello")}, 1000) The purpose of doing that is to keep the react application awake. It may not be a proper way to fix this issue, but it works for me. I hope this will help

I've experienced the same issue. You may try to put setInterval function setInterval(() => { console.log("hello")}, 1000) The purpose of doing that is to keep the react application awake. It may not be a proper way to fix this issue, but it works for me. I hope this will help

Doesn't it consume memory?

Facing the same issue, only happening on chrome for me. Works perfectly on firefox.

I'm facing the same issue for the past 2 weeks too.... Only happen in production/build.... Not in development... Please has anyone find a solution?

I am also facing the same issue. Clearly this issue is still not closed. Can someone re-open this issue?

I am also facing the same issue when i run the reactjs project build locally.

I am also seeing this issue with a react based Zendesk app, it loads fine but when I navigate away from that chrome tab and come back to it for almost any amount of time (I can be off tab for as little as ~2s and come back to it) it will be blank for some time and then load in, the amount of time it is blank is often between 10 to 45s but can be longer. I am using Vite.

I am also seeing this issue with an Electron + Vite + React app. Please re-open the issue.

I am experiencing the same issue in production, it's happening every time on mobile when the mobile browser is exited and then reopened multiple hours later.

Maybe this will help someone.
When deploying webpack app the js bundle name changes (in order to bust caching and forcing the browser to load the file).
When a user goes back to an inactive tab of our app, the browser tries to "revive" it.
However the index.html is not reloaded, only re-executed.
The browser thus tries to load a js script which is no longer there (because the bundle js has a new file name).
The server responds with a 404 HTML file - causing the JS syntax error you see in the console.
What can you do?
Add this event handler directly in a script block in your index.html
 var unhandledErrorDefaultHandler = function (event) {
        console.log("UNHANDLED ERROR:" + event.message);
        if (event.message === "Uncaught SyntaxError: Unexpected token '<'") {
          var lastreload = localStorage.getItem("error_reload");
          if(lastreload && (+lastreload + 10000) > new Date().valueOf() ) {
            console.log("Error loop detected");
          } else {
            localStorage.setItem("error_reload", new Date().valueOf());
            alert("Application was updated, and will be reloaded.");
            window.location.reload();
          }
        }
        return false;
     };
     window.addEventListener("error", unhandledErrorDefaultHandler);

Vite + React Project. it is happening for me

Maybe this will help someone.
When deploying webpack app the js bundle name changes (in order to bust caching and forcing the browser to load the file). When a user goes back to an inactive tab of our app, the browser tries to "revive" it.
However the index.html is not reloaded, only re-executed.
The browser thus tries to load a js script which is no longer there (because the bundle js has a new file name). The server responds with a 404 HTML file - causing the JS syntax error you see in the console.
What can you do? Add this event handler directly in a script block in your index.html
 var unhandledErrorDefaultHandler = function (event) {
        console.log("UNHANDLED ERROR:" + event.message);
        if (event.message === "Uncaught SyntaxError: Unexpected token '<'") {
          var lastreload = localStorage.getItem("error_reload");
          if(lastreload && (+lastreload + 10000) > new Date().valueOf() ) {
            console.log("Error loop detected");
          } else {
            localStorage.setItem("error_reload", new Date().valueOf());
            alert("Application was updated, and will be reloaded.");
            window.location.reload();
          }
        }
        return false;
     };
     window.addEventListener("error", unhandledErrorDefaultHandler);

THIS is the solution everyone is looking for

Hey there,
I have the same issue and the above solution is not a good one because it will reset all the current states.
Does anyone find out the root cause ?


Layers DiContainers

In my application I have three layers:

Data (Entities and Data Access Objects)
Model (Managers)
Presentation (Views)

I decided that SubContainers is my choice.
In the root GameInstaller I create every container and manually install them with LayerInstallers:
    public class GameInstaller : MonoInstaller
    {

        public GameDataLayerInstaller DataLayerInstaller;
        public GameModelLayerInstaller ModelLayerInstaller;
        public GamePresentationLayerInstaller PresentationLayerInstaller;

        public override void InstallBindings()
        {
            var dataContainer = Container.CreateSubContainer();
            dataContainer.Inject(DataLayerInstaller);
            DataLayerInstaller.InstallBindings();

            var modelContainer = dataContainer.CreateSubContainer();
            modelContainer.Inject(ModelLayerInstaller);
            ModelLayerInstaller.InstallBindings();

            var presentationContainer = modelContainer.CreateSubContainer();
            presentationContainer.Inject(PresentationLayerInstaller);
            PresentationLayerInstaller.InstallBindings();
        }
    }

Inside of Model-Installer I add GameAppManager into the graph.
    public class GameModelLayerInstaller : MonoInstaller
    {

        public GameAppManager GameAppManager;

        public override void InstallBindings()
        {
            Container.QueueForInject(GameAppManager);
        }
    }

Inside of Presentation-Installer I add GameApp into the graph.
    public class GamePresentationLayerInstaller : MonoInstaller
    {

        public GameApp GameApp;

        public override void InstallBindings()
        {
            _logger.Debug("installing bindings");
            Container.QueueForInject(GameApp);
        }
    }

Then I trying to resolve it from  GameApp.InjectDependencies(...) method:
    public class GameApp : MonoBehaviour
    {

        private GameAppManager _appManager;
        [Inject]
        public void InjectDependencies(GameAppManager appManager)
        {
            _appManager = appManager;
        }
    }

But Zenject throws this exception:
ZenjectException: Unable to resolve type 'RsQuest.Game.Model.App.GameAppManager' while building object with type 'RsQuest.Game.Presentation.App.GameApp'.
Object graph:
GameApp

How can I manage this case?

I realized that this question is more suitable to be posted on StackOverflow.
There it is: https://stackoverflow.com/questions/46932959/layers-dicontainers :)

Yes, thank you


add "Compile and link dynamically to an external C library" example

Use cc crate to compile and link dynamically to an external/system C library from a build.rs file.
Please note that it will be important to mention that this is a build time crate.
Most likely we will dedicate a separate (last) chapter like "build_time.md"
cc https://github.com/rust-lang-nursery/rust-cookbook/issues/236

I have a minimal working example here. I am currently verifying that the library produced is indeed dynamic.

I'm starting to get into the weeds on this and before I go too deep I thought I should get some clarification here... What is the overall goal of this issue? Are we trying to create library that is dynamically linked to or are we simply creating a dynamic object which is then statically compiled into the executable? Specifically, there is a subtle difference between a shared object and a shared library -- the former can be statically linked into an executable, while the latter is linked at runtime.
To expand upon this, the example from the cc crate docs would lead one to come up with the following code example:
cc::Build::new()
        .file("src/foo.c")
        .shared_flag(true)
        .pic(true)
        .compiler("gcc")
        .compile("foo.so");

However, as far as I can tell, this does not actually produce a shared library. Instead, it produces foo.so.a, which does not appear to be a shared library. I'm guessing the object foo.o is created using the -shared flag, but a shared library is not actually created. Additionally, on macOS, where gcc is an alias for clang, the -shared flag is actually ignored.
To return to the original question, what do we want to do with this recipe? It seems we have two options. The more complex option:

Create libfoo.so
Link libfoo.so with our executable
It would be great if we could verify libfoo.so is a shared library. I am trying to get _init() and _fini() to work with a standalone C shared lib but no luck so far...

The alternative:

Create libfoo.a as we have in prior examples, the only difference being we use .shared(true) and .pic(true) options

As an aside, is there an easy way to create an executable binary in rust? Cargo does not seem to offer this functionality so I imagine this is done via rustc -- I'll read the docs. Ideally I'd like to get option 1 working with a compiled binary, then delete the shared lib and watch the binary give me an error when it is subsequently run.

What is the overall goal of this issue? Are we trying to create library that is dynamically linked to or are we simply creating a dynamic object which is then statically compiled into the executable?

We would be interested in linking to a full blown external shared library (probably the title could be more descriptive). So we just assume existence of some *.so file with given symbols.
As you have noticed the cc crate does not seam to provide a way to create a *.so file (although we might drop a note about it in their bugtracker as the feature would be desirable and their docs are not perfectly clear on it imho)

As an aside, is there an easy way to create an executable binary in rust? Cargo does not seem to offer this functionality

Please see information under "Configuring a target" you are probably looming for [[bin]] clause. If you need more control (very unlikely) you can loom into "The profile.* section"

Thanks for the links @budziq ! Very useful info. I'll follow-up with the cc team.

See this issue from the cc crate. Alex mentions it wasn't the intention of the cc crate to build shared libraries.  Given this info, it seems we should close this issue and remove this as a recipe for the cookbook. What are your thoughts @budziq ?

Given this info, it seems we should close this issue and remove this as a recipe for the cookbook.

Not necessarily. We can still:

build a static  library whose only contents are link against *.so using object - it might be a little contrived
link directly with *.so without cc crate, using only the facilities given by cargo cargo:rustc-link-lib=dylib=foo

Then it still might an interesting example.

Great points. I think the latter might be more interesting. To that end, it might be worth having a separate section for cargo with various recipes that show what you can do with cargo (e.g., linking to a shared lib). The main takeaways I got from the book with regards to cargo were creating binary and library projects, and the commands cargo run, cargo build, and cargo test. Looking through the docs you linked there is obviously a lot more tooling available :smile:

@j-haj I feel that this example is stepping (possibly neck deep) into a FFI territory that is quite scattered in the rust landscape. For now I've marked this as "needs clarification" and created an issue to gather some opinions here before we proceed here.


Excel Functions implementation

Github 107 Add AREAS function
POI 61063 Use of arrays of values leads to non empty stack
POI 63984 AND / OR should treat missing parameters as FALSE
POI 62254 OFFSET function fails when 2nd or 3rd arguments are missing
POI 63819 Support DateValue function
POI 62857 DOLLAR function not implemented entirely
POI 65606 Bug in evaluating WEEKNUM
POI 65846 Add support for NUMBERVALUE function
POI 65879 Add support for WORKDAY.INTL functions
POI 65871 Add support for DOLLARDE and DOLLARFR functions
POI 65870 Add support for BESSELJ function
POI 49202 add support for the function 'PERCENTRANK'
POI 64258 Provide implementation for TDIST function
POI 65850 Add support for Normal Distribution functions
POI 60029 Fix problem with Days360 method for the month of february
POI Github 69 Numeric Array Formula and Matrix Function Patch
POI 64238 Make LOOKUP functions deal with empty last arg correctly
POI 64393 Handle MissingArgEval in relational operators
POI 62373 Support FREQUENCY function

POI 66047 Fix rounding issue in MROUND function
POI 65988 RATE function fails in some cases
POI Github 330 Support AVERAGEIF function
POI 66083 Support CEILING.MATH and FLOOR.MATH functions
POI 66090 add support for DCOUNT, DCOUNTA, DAVERAGE, DSTDEV, DSTDEVP, DVAR, DVARP and DPRODUCT functions
POI 66093 add support for unimplemented subfunctions to SUBTOTAL function
POI 66094 add support for STDEV.S, STDEV.P, VAR.S and VAR.P functions

Move the rest to #1023


Nuget Package Manager

When downloading the package from NuGet, and trying to run exemplar code under 'Usage', an error is returned that there is no 'FileSystem' in ipfs. I suspect this is because NuGet has a test release, but nevertheless, I am uncertain how to install on windows. Is NuGet going to be updated, or am I missing something really obvious?

Issue resolved. For anyone with the same problem (of getting started!) download the repo and open in the latest Visual Studio installation (VS 2017) with C# 7 installed, and Net 2.0 Core installed. Then, if you want DLL's, build Ipfs.Engine to a class library and use however you please. (BEWARE: There are a LOT of DLL's due to the dependencies).


Controller / Target Configuration Issue

Bug Report
System Information

Ubuntu 18.04.2 LTS
v<IP_ADDRESS>, built 11/04/2019 13:12
Mainline

I confirm:

[x]  that I am using the latest available version of AMP.
[x]  that my operating system is up-to-date.

Symptoms
Controller cannot issue instance management commands, as the target seems to think that the request is coming from <IP_ADDRESS> instead of the actual source IP, as depicted in the original configuration setup, and further attempts to edit AMPConfig.conf in all ADS01 instance folders.
Reproduction
Setup one VPS as Controller.
Setup a second VPS as target.
Appropriate login credentials and IP Addresses provided where needed.
switch target via CONF file to:
Security.EnablePassthruAuth=true

Attempt to manage an existing instance on remote build
(in my case, all login credentials for user and system passwords were kept the same, I am unsure if this would cause an issue)
Attachments

Most Recent Log on Target
Most Recent Log on Controller

Targets should not have passthru auth enabled.

Targets should not have passthru auth enabled. Instances that are created by targets should have their auth server set to the controllers URL.

After disabling passthru auth on the target using:
Security.EnablePassthruAuth=False

and ensuring the login auth is controlled by the controller:
Login.AuthServerURL=http://<IP_ADDRESS>:8080/

I now get the following error when attempting to manage anything on the target from the controller:

Full Config file Target
Full Config file Controller

Make sure the individual instances also have the controller as their auth server URL.

Make sure the individual instances also have the controller as their auth server URL.

That did it.
Question: Why did it not take on the IP/Controller URL? The "Minecraft01" instance was created by the remote controller. Wouldn't it be told to use this URL in the future, considering it was the authcontroller that spawned the new instance?

It means the target was misconfigured during its initial setup. You should check the default auth server specified in the targets configuration.

It means the target was misconfigured during its initial setup. You should check the default auth server specified in the targets configuration.

The target host VPS/Primary ADS01 instance? Like, when the install script was created?

Correct. During installation it registers itself with the controller, and then uses that same URL as the default auth server for newly created instances.

Alright, so tested again. Reinstalled on a fresh copy of Ubuntu 18.04.02, etc. Used the "Quick Install" script command.
When using the web browser to finish setup, I modified the entries there to the correct controller URL. The ADS01 AMPConfig.conf has the correct controller URL Passed to it.
However, the ADSModule.kvp file shows the "targets" (the one I just installed a fresh install to) public hostname/URL as the "Defaults.DefaultAuthServerURL"
Should that not also have been set to the provided Controller URL as had been provided during the final stage of the Web Browser Setup?

It should have been, I'll check what's going on there.

Next "mainline" build should have a fix? or is this something more long-term that needs more data gathering?
Happy to provide any logs or steps of reproduction needed, etc.

Its a simple fix that I've already rolled out. Next nightly and next releases will have it.


Prevent Logic from connecting to itself

Describe the bug
Logic can be connected to itself, which is rather odd.
To Reproduce
import 'package:rohd/rohd.dart';

void main() {
  final a = Logic();
  final b = Logic();

  a <= a;
  a <= b; // exception
}

Expected behavior
Connecting Logic to itself is not allowed.
Actual behavior
Connecting Logic to itself is allowed.
Additional: Dart SDK info
No response
Additional: pubspec.yaml
No response
Additional: Context
ROHD v0.4.2

This represents a trivial case of a combinational loop.  It should be quite easy to detect statically, especially given _Wires are shared among connected Logics.  I am having trouble thinking of any valid use-case where a ring of wires connected directly to each other (including one to itself) would ever be valuable, so throwing an exception immediately seems fair to me.
Thank you for filing!


Setup

In this branch of the project, I have implemented the following;

Set up the project alongside linters.
I have created the UI for the project.
I have added the various components of the project.

Hi @Divinity-dev
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a descriptive readme, kindly add content to description & show your support sections and delete all the template text, this is just a placeholder telling you what to add in a section.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Corrections noted and thank you.
Sent from Yahoo Mail on Android
On Fri, Mar 3, 2023 at 9:22 AM, Oni Olajumoke @.***> wrote:
Hi @Divinity-dev
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a descriptive readme, kindly add content to description & show your support sections and delete all the template text, this is just a placeholder telling you what to add in a section.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks for the reply. For now, I don't quite understand this explanation. I thought I already created a method in the books component and rendering it in the app.js file. @Nemwel-Boniface
Sent from Yahoo Mail on Android
On Fri, Mar 3, 2023 at 1:54 PM, Nemwel @.***> wrote:
@Nemwel-Boniface commented on this pull request.
Hello @Divinity-dev 👋 ,
I am Nemwel your reviewer.
This is an additional review as a result of the second opinion request.
I have gone through the project requirements and checked what the reviewer @DammyShittu mentioned and found that the changes he requested are actually valid. Below I will summarize them for you providing more explanation for you.

For this comment, the project requirements ask you to create two components for the Book resource. One called  and the other called . What @DammyShittu means is that you need to create a component called  which will host all the code that you currently have in your Books component.

This means that the  will act as a "container" for all your books and the  will act as a "container" for a single book.
Also, to implement the above, you will need to loop through all the books inside the Books component rendering each Book that exist. You could do so by having something like this in your Books component:

<ul>
  {books.map((book) => (
    <Book key={book.id} book={book} />
  ))}
  <AddBook />
</ul>

In my case above, I have an array of objects in my  component and I am passing the books as props to the  component when rendering it. I will include a screenshot of the project requirements for you.

For this comment, what the reviewer @DammyShittu means is that this  component should be rendered inside  component. This means that you will have to place it after the  so that the form is rendered as the last thing (after all the books, you see the add book form). The reason for asking this change is that currently the form is visible in both your books page and the categories page. Below I will screenshot for you the whole section from the project requirements.

BTW in the code I gave you above shows exactly what I mean and you can see that the  component is inside the . Hope it is clear now.

For this comment, the point raised by @DammyShittu is actually very valid. While using the  works perfectly fine, it leads to re-loading of your page as mentioned by the reviewer. We recommend using the react-router Link element for this instead of the anchor tag.. Kindly check out this awesome resource by W3schools teaching you how to use the React router 🚀

I hope everything is clear now for you @Divinity-dev . Kindly implement all the changes requested by @DammyShittu and when you are done kindly request another review in your dashboard 🚀
In case anything is not 100% clear tag me @Nemwel-Boniface so that I get the notification.
Keep rocking 🚀 !
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @Divinity-dev  yes you are right that you have it. However, we have to make sure that we stick to the project requirements as much as possible.
Here is a situation where a client has given you specifications for their application and you decide to do the application in your own way. While it still serves the purpose, the client might not be really happy with you for not following the project requirements.
Does the analogy make sense?


Add automated manifestgen version checker

Adds an automated workflow to create a PR when a new release of the manifestget dependency is create.

We need to add two secrets to the repository before we can merge. BOT_GITHUB_TOKEN and ASSIGNEES.


Move Session#exnted_feature into Session class

Currently, exnted_feature method is defined outside of Session class. This PR fixes it.

@ono-max  @ko1  There is a typo here and in changelog: #extend_feature
good that it is correct in code :D


Add Bose Framework to Python Scrapers

Could you add Add Bose Framework to Python Scrapers. It is a web scraping framework.

feel free to open a pull request


Problem: No diagrams of transactions in docs

Solution: Put some simple diagrams of BigchainDB transactions in the docs
We used to have some diagrams showing BigchainDB transactions, inputs, outputs, etc. in the docs, but somehow they all went away without us noticing. Last week, someone asked me on Gitter if there is any standard pictoral way to illustrate transactions. There is, but there were no examples in the docs!
I put two simple diagrams in the Transaction Concepts section of the root docs. They're very simple diagrams, but I think that they're enough for someone to figure out how to diagram even the most complicated set of transactions.

It looks fine to me.


Simplify input file collection

This patch simplifies the code that create the vector with the input files:

matches.values_of("files") returns an iterator, so we don’t have to call into_iter().
input_files already has an explicit type annotation, so we don’t have to add a type annotation to the collect() calls.

Thank you!


Suggestion to export as .srt subtitle file

Hello, I would like to make a suggestion for your app, it would be interesting to add an option to export as an .srt file, this other repository offers an option to export srt https://github.com/ahmetoner/whisper-asr-webservice another thing would be nice to integrate cuda, for gpu acceleration for a faster inference, and as a last suggestion add an option of "dark theme" is everything, thank you.

Hey, thanks for all the suggestions. I have plans to add SRT export support in the next few days (https://github.com/chidiwilliams/buzz/pull/98#issuecomment-1283582795). I'll also have a look at integrating Cuda for faster inference. On dark theme, what OS are you using? I believe the app should support dark theme based on your system's theme.


Change credentials create test vectors

Currently the test vector uses .fromJson and only works in kotlin.
Need to change the test vector input so it's the input of VerifiableCredential.create() and works across all sdks
public fun <T> create(
  type: String,
  issuer: String,
  subject: String,
  data: T,
  credentialStatus: CredentialStatus? = null,
  issuanceDate: Date = Date(),
  expirationDate: Date? = null
): VerifiableCredential {

https://github.com/TBD54566975/web5-spec/pull/149

related to #168


I suggest use Echart for charting。

Take a look at this guide https://github.com/akveo/ng2-admin/issues/234#issuecomment-245867517


Unnecessary .jshintrc and .jshintignore files are generated during installation process

Bug Report
What is the current behavior?
Currently, running yarn immediately after cloning will generate .jshintrc and .jshintignore, which are not checked in to source control.
What is the expected behavior?
.jshintignore and .jshintrc shouldn't be created. If it's impossible to avoid, they should be excluded from the repository via .gitignore additions.
What steps did you take to get this behavior?
After a clean clone, you should notice that .jshintignore and .jshintrc are created and not in source control
Additional Info
Operating System
MacOS 10.12.6
Browser
n/a
Screenshots
n/a

I'd like to reorient this issue to preventing those files from event being created in the first place.
Are we certain yarn is the cause of those files?

Running yarn to install the dependencies is what created the files. Why move them away from source control?
Ensuring that the codebase is properly linted seems to be a precommit hook, shouldn't the linting controls be included in the source control to guarantee that everyone is following the same coding guidelines?

@mduleone Yes, we want to ensure that the codebase is properly linted, but we're currently using ESLint for that (w/ .eslintrc and .eslintignore files), which are checked into source control.
We haven't made the decision to use JSHint, which is why those files were deemed as unnecessary.

@kylemh It looks like these .jshintrc and .jshintignore are being added by the NPM precommit-hook package that was added ~ 10 days ago.  Per the docs:
'When you install this project, by default it will create sane .jshintignore and .jshintrc files for you if they do not already exist.'
I say we just add it to the .gitignore and call it a day.

Addressed in #720.
I'd love to contribute to the bigger issues here - just cleaning up some of the little things while I browse this repo. Thanks for this great project/org!


Are you a maintainer, or core-contributor, to the project?

[X] Yes

We already have a Pulumi.com account?

[X] Yes, we have created an account

Do you agree to regular check-ins, no more than once every 90 days, with a Developer Advocate from the Pulumi team?

[X] Yes

What's your Open Source project called?
Postman.gov.sg
Where is the GitHub repo where your organization's infra code is located?
https://github.com/opengovsg/postmangovsg-infra
What's Pulumi.com team ID?
postmansg
Do/would you like any assistance with your Pulumi adoption from the DevRel team?

[ ] Yes

The github repo 404s. Is that a private repo?

apologies, have made it public


fix: revert .env.test to mainnet

Maybe also revert the changes inside ingestor
https://github.com/snapshot-labs/snapshot-sequencer/blob/bda8b9d735cf8e0605dc73c2e1e4d1fa673508db/src/ingestor.ts#L29
To have everything other than mainnet to be testnet, like on the hub

i think we can leave it like this, we are checking testnet everywhere


Make a distinction between errors and warnings in config

Something I like about Neomake is that it makes a distinction between different kinds of issues like errors, warnings and style errors.
Unfortunately when using flake8, many stylistic issues (flake8 gives them errorcode E) are marked the same as code errors.
I want to configure it such that only flake8 output with code F is marked as an error. Everything else should be marked as warning, info or message.
I apologize if it's already possible to configure it like this, but I wasn't able to figure out how from reading the docs and the source code.
If this is not yet possible, then perhaps it could use the following syntax:
function! neomake#makers#ft#python#flake8()
    return {
        \ 'errorformat':   '%A%f:%l:%c: F%n %m' .
        \ 'warningformat': '%A%f:%l:%c: W%n %m' .
        \ 'msgformat': '%A%f:%l:%c: %t%n %m' .
        \ }
endfunction

I found a way to configure it the way I want using postprocess. A configuration to my personal liking, can be found at https://github.com/benekastah/neomake/pull/268.


set handler param kubelet-pods-dir with operator

Is your feature request related to a problem? Please describe:
when my kubelet --root-dir param is not /var/lib/kubelet, i should set param kubelet-pods-dir and volume mount in handler, when i use operator, the handler DaemonSet will be auto update  by operator...
Describe the solution you'd like:
A clear and concise description of what you want to happen.
Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.
Additional context:
Add any other context or screenshots about the feature request here.

I want to work on this

/assign @octonawish-akcodes

/remove-lifecycle stal

/remove-lifecycle stale

@alicefr i'd like to work on this issue && we have the requirement and testing environment to work on this case.

/assign @qiutingjun

/remove-lifecycle stale

/remove-lifecycle rotten

/reopen


Stale commit operations overwrite remote updates

Originally reported by @sbatten
Here is approximately what happened:

@sbatten made some uncommitted changes last week with RemoteHub on desktop and did not commit
This Monday he committed and pushed (so a few days passed)
He saw no warnings about potential merge conflicts etc. The commit went through, but ended up reverting changes that others had made since then

I was able to track down a repro which I think is what happened:

Have uncommitted changes
Commit from elsewhere, you should see the pending incoming changes indicator
Reload the page
:bug: The uncommitted changes are still there, but now you no longer see the incoming changes indicator

Verification:

Go to a RemoteHub repo in insiders.vscode.dev, e.g. insiders.vscode.dev/github/microsoft/vscode-internalbacklog
Make a change but do not commit
Open the same repo in github.dev
Make a change and commit
Go back to insiders.vscode.dev and run the Remote Repositories: Fetch command
You should see an incoming changes indicator
Reload the page
Fix: the incoming changes indicator should still be there


chore: remove release notes from README and add unreleased changes to CHANGELOG

Removes release notes from README to remove clutter
Adds unreleased changes to changelog

This only includes changes that would be relevant to SDK users, but I am open to updating any format or including all changes

Adds date to releases.

this can be useful for users to easily check what has changed since they last used it or know how mature a release is

Please share any options on how this should be structured, as it would be best if this has a format we're all happy with to keep this up to date. I considered having crate level CHANGELOGs but decided against it because there wasn't a need for that granular of changes it seems.

I dig this approach. Let's keep the README as simple as possible.
I like the way Rust has it laid out here, if we're talking about structure:
https://github.com/rust-lang/rust/blob/master/RELEASES.md
I'd say having the dates is also great (Rust RELEASES file does that, too) and if we can give examples of old way vs. new way, that would be extra credit.

I dig this approach. Let's keep the README as simple as possible.
I like the way Rust has it laid out here, if we're talking about structure:
https://github.com/rust-lang/rust/blob/master/RELEASES.md
I'd say having the dates is also great (Rust RELEASES file does that, too) and if we can give examples of old way vs. new way, that would be extra credit.

Yeah it's very subjective, so I didn't change anything major. Do you think there is any information or format that should be changed/added?


Replace FAQ with neo/docs one

The neo/docs FAQ has been updated and merged with the FAQ in awesome-neo in neo-project/docs#899. It'd be possible to also update the one in this repo but that would mean a duplication of effort, so I have removed the one here and pointed it to neo/docs.

Waiting for the resolution on the broken CoZ image to fix the failing CI.


php artisan elastic:update-mapping App\Models\Us

Elasticsearch\Common\Exceptions\BadRequest400Exception  : {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"request [/users_write/_mapping/us] contains unrecognized parameter: [inc
lude_type_name]"}],"type":"illegal_argument_exception","reason":"request [/users_write/_mapping/us] contains unrecognized parameter: [include_type_name]"},"status":400
 [
            'username' => 'text'
        ]
    ];
}

Please, update your scout-elasticsearch-driver to version 3.12.

@ahxiaowu
This was a known issue caused by the 7.0 compatibility introduced on 3.11, but since it causes an break change, we reverted it on 3.12 and released the 7.0 support on 4.0.
As suggested by @mathmarques update you dependencies to have scout-elasticsearch-driver v3.12.
I'm closing this issue since it's already fixed.
If you still have problems, please leave a comment here asking for re-open.

@ahxiaowu
This was a known issue caused by the 7.0 compatibility introduced on 3.11, but since it causes an break change, we reverted it on 3.12 and released the 7.0 support on 4.0.
As suggested by @mathmarques update you dependencies to have scout-elasticsearch-driver v3.12.
I'm closing this issue since it's already fixed.
If you still have problems, please leave a comment here asking for re-open.

I am on "babenkoivan/scout-elasticsearch-driver": "^4.0" and I am still having this issue. Do I need to revert to 3.12?

@raymondtri Yes, you should use v3 for ES 6.X

My elasticsearch is 7.2 though

any solution u found @raymondtri because i have the same problem and its not the issu of compatibility as i have checked that and my ES is 7.1 too


Update overview.md

This PR fixes obvious typos.

Sorry I've fixed one more typo and force-pushed.


Feature request: mermaid diagram rendering

Presumably a limitation of the /markdown api but grip doesn't render the newly supported mermaid diagrams in markdown.   Hoping that gets added at some point 🤞

I've been poking around this issue, I think a way to conveniently view mermaid diagrams in markdown is great.
For anyone wondering, turns out this is explicitly disabled by GitHub
"clients requesting content with embedded Mermaid in a non-JavaScript environment (such as an API request) will see the original Markdown code"

And there does not seem to be a way around this in the API docs
Here's hoping this will be implemented in the grip offline renderer

It seems that one could have grip call mermaid-cli to generate an svg and include that via a simple <img src....


Concurrency: support draining the main queue in single threaded mode

When built in single threaded mode, the runtime does not use dispatch to
queue the tasks.  As a result, pumping the dispatch main queue will
simply wait indefinitely.  In the single threaded mode, simply halt
execution and drain all pending tasks before returning.  This allows
forward progress in the single threaded mode.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@etcwilde not sure if this is the best way to handle this; perhaps in single-threaded mode, we should never arrive at this point and we should be changing the Swift path itself?

@etcwilde not sure if this is the best way to handle this; perhaps in single-threaded mode, we should never arrive at this point and we should be changing the Swift path itself?

@swift-ci please test

@swift-ci please test

Yeah, I meant having a different end point coming in from the Swift side.  Sounds like this approach is reasonable enough for now, so lets go with that.

Yeah, I meant having a different end point coming in from the Swift side.  Sounds like this approach is reasonable enough for now, so lets go with that.

Build failed
Swift Test OS X Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

Build failed
Swift Test OS X Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

Build failed
Swift Test Linux Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

Build failed
Swift Test Linux Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

@swift-ci please smoke test Linux platform

@swift-ci please smoke test Linux platform

@swift-ci please test macOS platform

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

Build failed
Swift Test OS X Platform
Git Sha - 4f740a4784586484bf16fc69c1d742daa71520f6

@swift-ci please smoke test macOS platform

@swift-ci please smoke test macOS platform


include keys for each layer

Adds a keys property to each feature returned, which is an Array of strings.
refs #10
cc @springmeyer @GretaCB

Current coverage is 97.10% (diff: 100%)

Merging #13 into master will increase coverage by 0.27%

@@             master        #13   diff @@
==========================================
  Files             1          1
  Lines            63         69     +6
  Methods           3          3
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             61         67     +6
  Misses            2          2
  Partials          0          0

Powered by Codecov. Last update 9d26d7f...c9e472d

Tests look good - forgot to publish binary after changing the version. Will do that from master.


Problem when used Inside jquery dialog

I'm using a Jquery UI dialog, in which I'm using spin.js which works perfectly.
No matter whether or not I have closeOnEscape set to true or false with the dialog, When the ESCAPE key is pressed, the spinner stops spinning and hangs all further jquery or .NET processing.
BTW - this is used in an ASP.Net 4.0 webforms application

dasf

Please reopen with a reproducible example if this is still an issue with spin.js v3.0.


Support for probes for ovs cni marker

We have a requirement where we want to monitor ovs-cni-marker for liveness so that it can restarted in case of process hangs/failures.

kind/enhancement

/kind enhancement

One simple approach that can be pursued is to have a simple http endpoint for replying to liveness probe.
Is there any alternative way that can be used here?

Hello @rthakur-est, HTTP server would be ok. Or even a simple file-based liveness probe.
Would you be willing to extend the deployment manifest with it, and add a one of the probes?

Hi @phoracek
I will work on it.


nodejs_npm not idempotent?

I'm installing sinopia using https://github.com/BarthV/sinopia-cookbook/blob/master/recipes/sinopia.rb#L9-L12, but no matter what I do, the chef decides to install sinopia on each run, even though i'm specifying the version.
From what I can tell this should be idempotent. I can't seem to figure out what's wrong.

I've done some debug :
* execute[install NPM package sinopia] action run

== STARTING DEBUG ==
new_resource.package = sinopia
npm_package_installed?(new_resource.package, new_resource.version, new_resource.path, new_resource.npm_token) = false

(!list.nil?) = true
list.key?(package) = true
version_valid?(list, package, version) = true
url_valid?(list, package) = false

npm_package_installed? false
== END ==

It seems that url_valid? is not working properly.
I'll see what's wrong here.

bug confirmed.
We're working on a fix (better way to detect and compare installed version)

I'm running into this bug too.   A fix would be hugely appreciated.
I'm happy to help out if you'd be open to a PR with a quick fix that just checks if the url is valid (though, to be honest, I'm not entirely sure how or why an invalid URL would get into this "resolved" field in the first place; so maybe there's more than just generic url =~ URI::regexp validity checking that the function is supposed to perform).

Curiously we see this problem when chef-client runs as a daemon but if you call chef-client at the CLI the issue does not occur.
Any update on when we can expect to see this fixed?

@kemra102 Also seeing this on manual runs (bower in my case)
  * nodejs_npm[bower] action install
    * execute[install NPM package bower] action run
      - execute npm install  -global bower

Here's the commit which introduced the bug: https://github.com/redguide/nodejs/commit/2b1c055c01cc46ea8cf928464d09b74c5de065cf
Basically, before it would just check that the version matched, but that commit also has it checking that the "url" is valid for the package. I'm not sure why the check was added, but with npm 2.15.9 and 3.10.8 my output structure doesn't match what url_valid? is looking for. Specifically they're looking for a 'resolved' property's value to include 'url'. I don't know if they're assuming that the resolved property would be an array holding an 'url' string entry, or it's looking for a child 'url' property? In any case, for my npm output it gives a string value for 'resolved' property, the value being a String URL.
I think the easiest fix would be to simply remove the url_valid? call altogether since it's not really doing anything other than introducing this bug. The more correct fix may be to check the resolved URL value from he JSON output against the URL of the package about to be installed to see if it's changed at all, and if it has to then assume the package/version the user wants isn't installed (and to re-install).

New release will fix this


Find a new home for EF MVC code in Code Gallery

Given the way Microsoft is moving toward using GitHub for code samples,  we should move our top sample off MSDN Code Gallery. The top download on the site is EF MVC for EF 6 and MVC 5, and these versions are still relevant, so we should consider moving the sample:

Update the project for VS 2017, and if time permits update package versions as well.
Find a place for the project in the ASP.NET docs repository and put it there.
Update the Code Gallery page to send people to the new location.

@tdykstra 	is P1 correct?

Given the high number of downloads this sample gets, #1 on codeplex, P1 is correct.


Escape enum values which are python keywords

resolves #220

@mat-sop any way this could be merged soon?

@mat-sop any way this could be merged soon?

@Kade-Powell I merged it, but I'm not sure when we will release a new version with these changes included.

No worries I'll use the git source as dependency for now. Thank you!


This repo needs CI

Now that there is code and deployment logic in this repo, it needs to make sure it keeps working and therefore needs a CI.
I advise to do this first before accepting any new changes.

Sure thing. What'd be the best way to go about that? Being a system-level components integration project, I'm not sure which CI system to use or how to setup the test environment.

The project can benefit from a lot of the functional tests from Heketi and use the same centos-ci system

I'll look into getting a test included in the gluster-patch-acceptance-tests repository.

@jarrpa @obnoxxx , the job should be available for you guys to test. Please leave a ok to test comment in one of the next PRs. #436 would have had a chance for testing (it has the @centos-ci request), but it's been merged already.
If testing works, please close this issue.


Production build: Unexpected token: name (QueryOperatorDirective):

While building the build via webpacker, this error is thrown.
Here is the error
Unexpected token: name (QueryOperatorDirective) [./node_modules/angular2-query-builder/dist/components/query-builder/query-operator.directive.js:2,0]

I have fixed this issue, by upgrading the webpacker, which in turn updated the uglifyjs-webpack-plugin to version "^1.1.8".
Hope it will be useful !!


Add option to exclude specific topics for Kafka plugin

description
Application can use Kafka to receive messages using multiple topics.
If it is a topic that does not need to be traced, This option can prevent it.

I think you guys have thought this is  an unnecessary feature, so I'll close this issue. :)


Chore/update readme 1.39

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@5d98887). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage        ?   22.39%
=======================================
  Files           ?       54
  Lines           ?     4514
  Branches        ?        0
=======================================
  Hits            ?     1011
  Misses          ?     3403
  Partials        ?      100

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


iPhone 14 Frames

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.
[x] I've added or updated relevant unit tests.

Motivation and Context

As other pull request this fixes 'frameit' for the iPhone 14 Devices.
Unlike other pull requests it uses the correct devices size for iPhone 14 Pro.
Before framing the screenshots it applies a corner radius to the screenshot to fix the following issues
#20703
#20917
To merge this pull-request the following pull-request of 'frameit-frames' is required, because it provides the correct frame size for the iPhone14 Pro
Depends on: https://github.com/fastlane/frameit-frames/pull/33

Thanks @getaaron 🥳
It would be awesome if you could also merge the corresponding frameit-frames pull request. This contains the fixed frame size in the offset definition
https://github.com/fastlane/frameit-frames/pull/33


Hyprland 0.33.0 crashes when sharing a single window

Hyprland Version
Hyprland, built from branch  at commit 3bb9c7c5cf4f2ee30bf821501499f2308d616f94
Bug or Regression?
Bug
Description

NixOS unstable
flake.nix:

    hyprland = {
      url = "github:hyprwm/Hyprland/v0.33.0";
      inputs.nixpkgs.follows = "nixpkgs";
    };

Been on 0.32.3 for a while where pretty much everything worked as expected.
With 0.33.0 sharing individual windows makes Hyprland crash hard.
How to reproduce

Head to https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing
Start screen sharing
In the picker select a window (sharing an entire output works fine)

Crash reports, logs, images, videos
Logs:
[LOG] Instance Signature: 3bb9c7c5cf4f2ee30bf821501499f2308d616f94_1701880446
[LOG] Hyprland PID: 2794
[LOG] ===== SYSTEM INFO: =====
[LOG] System name: Linux
[LOG] Node name: ge2
[LOG] Release: 6.6.3
[LOG] Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue Nov 28 17:20:18 UTC 2023

[LOG] GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation Raptor Lake-P [Iris Xe Graphics] [8086:a7a0] (rev 04) (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA107GLM [RTX A1000 6GB Laptop GPU] [10de:25bc] (rev a1) (prog-if 00 [VGA controller])

[WARN] Warning: you're using an NVIDIA GPU. Make sure you follow the instructions on the wiki if anything is amiss.

[LOG] os-release:
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20231201.91050ea"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

[LOG] ========================

[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/

[LOG]
Current splash: Súbeme la radio que esta es mi canción

[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] [hookSystem] New hook event registered: configReloaded
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 25.68µs. Estimated average calc time: 0.08µs.
[LOG] Creating the ConfigManager!
[LOG] NOTE: further logs to stdout / logfile are disabled by default. Use debug:disable_logs and debug:enable_stdout_logs to override this.

Crash report:
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
Calm down, it was a misinput! MISINPUT!

Hyprland received signal 11 (Segmentation fault)

Version: 3bb9c7c5cf4f2ee30bf821501499f2308d616f94
Tag:

System info:
	System name: Linux
	Node name: ge2
	Release: 6.6.3
	Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue Nov 28 17:20:18 UTC 2023

GPU:
	00:02.0 VGA compatible controller [0300]: Intel Corporation Raptor Lake-P [Iris Xe Graphics] [8086:a7a0] (rev 04) (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA107GLM [RTX A1000 6GB Laptop GPU] [10de:25bc] (rev a1) (prog-if 00 [VGA controller])

os-release:
	BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
	BUILD_ID="24.05.20231201.91050ea"
	DOCUMENTATION_URL="https://nixos.org/learn.html"
	HOME_URL="https://nixos.org/"
	ID=nixos
	LOGO="nix-snowflake"
	NAME=NixOS
	PRETTY_NAME="NixOS 24.05 (Uakari)"
	SUPPORT_URL="https://nixos.org/community.html"
	VERSION="24.05 (Uakari)"
	VERSION_CODENAME=uakari
	VERSION_ID="24.05"

Backtrace:
	#0 | /run/current-system/sw/bin/Hyprland(_Z12getBacktracev+0x48) [0x572fd8]
		_Z12getBacktracev
		??:?
	#1 | /run/current-system/sw/bin/Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x58b) [0x52cb5b]
		_ZN13CrashReporter18createAndSaveCrashEi
		??:?
	#2 | /run/current-system/sw/bin/Hyprland(_Z25handleUnrecoverableSignali+0x3f) [0x4a15ff]
		_Z25handleUnrecoverableSignali
		??:?
	#3 | /nix/store/qn3ggz5sf3hkjs2c797xf7nan3amdxmp-glibc-2.38-27/lib/libc.so.6(+0x3da70) [0x7fe6a9175a70]
		??
		??:0
	#4 | /run/current-system/sw/bin/Hyprland(_ZN15CHyprOpenGLImpl22getPreferredReadFormatEP8CMonitor+0xc0) [0x62bcc0]
		_ZN15CHyprOpenGLImpl22getPreferredReadFormatEP8CMonitor
		??:?
	#5 | /run/current-system/sw/bin/Hyprland(_ZN30CToplevelExportProtocolManager15captureToplevelEP9wl_clientP11wl_resourcejiP7CWindow+0x16a) [0x6212ea]
		_ZN30CToplevelExportProtocolManager15captureToplevelEP9wl_clientP11wl_resourcejiP7CWindow
		??:?
	#6 | /nix/store/9kd4bc8fpclpvf1vdwlbila71svyb6w1-libffi-3.4.4/lib/libffi.so.8(+0xa052) [0x7fe6a969e052]
		??
		??:0
	#7 | /nix/store/9kd4bc8fpclpvf1vdwlbila71svyb6w1-libffi-3.4.4/lib/libffi.so.8(+0x7e95) [0x7fe6a969be95]
		??
		??:0
	#8 | /nix/store/9kd4bc8fpclpvf1vdwlbila71svyb6w1-libffi-3.4.4/lib/libffi.so.8(ffi_call+0xd8) [0x7fe6a969ca78]
		??
		??:0
	#9 | /nix/store/nrkv4q1gpi8qfvrj06ip5lg72rpqq3jb-wayland-1.22.0/lib/libwayland-server.so.0(+0xd886) [0x7fe6a9e46886]
		??
		??:0
	#10 | /nix/store/nrkv4q1gpi8qfvrj06ip5lg72rpqq3jb-wayland-1.22.0/lib/libwayland-server.so.0(+0x8c4b) [0x7fe6a9e41c4b]
		??
		??:0
	#11 | /nix/store/nrkv4q1gpi8qfvrj06ip5lg72rpqq3jb-wayland-1.22.0/lib/libwayland-server.so.0(wl_event_loop_dispatch+0xa2) [0x7fe6a9e448f2]
		??
		??:0
	#12 | /nix/store/nrkv4q1gpi8qfvrj06ip5lg72rpqq3jb-wayland-1.22.0/lib/libwayland-server.so.0(wl_display_run+0x25) [0x7fe6a9e42455]
		??
		??:0
	#13 | /run/current-system/sw/bin/Hyprland(main+0x4df) [0x48c42f]
		main
		??:?
	#14 | /nix/store/qn3ggz5sf3hkjs2c797xf7nan3amdxmp-glibc-2.38-27/lib/libc.so.6(+0x27fce) [0x7fe6a915ffce]
		??
		??:0
	#15 | /nix/store/qn3ggz5sf3hkjs2c797xf7nan3amdxmp-glibc-2.38-27/lib/libc.so.6(__libc_start_main+0x89) [0x7fe6a9160089]
		??
		??:0
	#16 | /run/current-system/sw/bin/Hyprland(_start+0x25) [0x4a1465]
		_start
		??:?

Log tail:
 signal for owner 4fc5020: 4fdca08 -> 4fc5290 (owner: XDG Window Late)
[LOG] Registered signal for owner 4fc5020: 4f87568 -> 4fc5840 (owner: XDG Window Late)
[LOG] Registered signal for owner 4fbbc50: 4fc4ad0 -> 4fbbcd8 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 4fbbc50: 4fc4aa0 -> 4fbbd40 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 4fbbc50: 4fc4ae0 -> 4fbbda8 (owner: SurfaceTreeNode)
[LOG] Creating a surfaceTree Root! [Window 4fc5020: title: "MainPicker"]
[LOG] Map request dispatched, monitor DP-5, window pos: [3390.00000, 575.00000], window size: [500.00000, 290.00000]
[LOG] Set keyboard focus to surface 4fb9780, with [Window 4f6bbc0: title: "WebRTC Screen Sharing | Plugin-free — Mozilla Firefox"]
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Callback 248d798 -> 248d790, CWLSurface removed.
[LOG] CWLSurface 248d758 called destroy()
[LOG] Registered signal for owner 248d758: 4f9f880 -> 248d770 (owner: CWLSurface)
[LOG] CWLSurface 248d758 called init()
[LOG] Set keyboard focus to surface 4fc47d0, with [Window 4fc5020: title: "MainPicker"]
[LOG] [Window 4fc5020: title: "MainPicker", class: ] unmapped
[LOG] Unregistered late callbacks XDG
[LOG] Callback 4fc5048 -> 4fc5040, XDG Window Late removed.
[LOG] Callback 4fc51e8 -> 4fc51e0, XDG Window Late removed.
[LOG] Callback 4fc5320 -> 4fc5318, XDG Window Late removed.
[LOG] Callback 4fc5458 -> 4fc5450, XDG Window Late removed.
[LOG] Callback 4fc53f0 -> 4fc53e8, XDG Window Late removed.
[LOG] Callback 4fc5388 -> 4fc5380, XDG Window Late removed.
[LOG] Callback 4fc54c0 -> 4fc54b8, XDG Window Late removed.
[LOG] Callback 4fc52b8 -> 4fc52b0, XDG Window Late removed.
[LOG] Callback 4fc5868 -> 4fc5860, XDG Window Late removed.
[LOG] Framebuffer created, status 36053
[LOG] On closed window, new focused candidate is [Window 4f6bbc0: title: "WebRTC Screen Sharing | Plugin-free — Mozilla Firefox"]
[LOG] Set keyboard focus to surface 4fb9780, with [Window 4f6bbc0: title: "WebRTC Screen Sharing | Plugin-free — Mozilla Firefox"]
[LOG] Destroying the SubSurface tree of unmapped window [Window 4fc5020: title: "MainPicker"]
[LOG] Callback 4fbbd68 -> 4fbbd60, SurfaceTreeNode removed.
[LOG] Callback 4fbbdd0 -> 4fbbdc8, SurfaceTreeNode removed.
[LOG] Callback 4fbbd00 -> 4fbbcf8, SurfaceTreeNode removed.
[LOG] SurfaceTree Node removed
[LOG] Callback 4fc5660 -> 4fc5658, Toplevel removed.
[LOG] Callback 4fc55f8 -> 4fc55f0, Toplevel removed.
[LOG] Callback 4fc56c8 -> 4fc56c0, Toplevel removed.
[LOG] Callback 4fc58e8 -> 4fc58e0, CWLSurface removed.
[LOG] CWLSurface 4fc58a8 called destroy()
[LOG] Callback 4fc5118 -> 4fc5110, CWindow removed.
[LOG] [Window 4fc5020: title: "MainPicker", class: ] destroyed, queueing.
[LOG] Callback 4fc50b0 -> 4fc50a8, XDG Window removed.
[LOG] Callback 4fc5180 -> 4fc5178, XDG Window removed.
[LOG] Callback 4f884e8 -> 4f884e0, textInput removed.
[LOG] Callback 4f88480 -> 4f88478, textInput removed.
[LOG] Callback 4f88418 -> 4f88410, textInput removed.
[LOG] Callback 4f883b0 -> 4f883a8, textInput removed.
[GLES2] GL_INVALID_OPERATION in glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_FORMAT: no GL_READ_BUFFER)
[GLES2] GL_INVALID_OPERATION in glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_TYPE: no GL_READ_BUFFER)

Damn, I didn't see that issue while searching.
Will do straight to main then, thanks!


Adding a few images for the Celestial bodies

It'd be nice to have a few selected, maybe four or five images for celestial objects that the user can see.

[ ] Sun
[x] Mercury
[x] Venus
[x] Earth
[x] Mars
[x] Jupiter
[x] Saturn
[x] Uranus
[x] Neptune
[ ] Pluto

Update the list as more celestial objects are added to it, see #8

Sun: 0
Mercury: 5
Venus: 7
Earth: 5
Mars: 5
Jupiter: 7
Saturn: 8
Uranus: 4
Neptune: 4
Pluto: 0


Team 2- Module 2

Module 2 RefSeq transcript to genomic HGVS and genome coordinates.
Really not sure I'm on the right path, but let us know what you think. Thanks

Hi, sorry guys I am currently still working on module 4 so I leave it to Linda to sort things out for module 2 . it seem like there is a conflict which need resolving.


Add release tag and sed script to autobump extension

Fixes https://github.com/kairos-io/kairos/issues/1934

adds tests for the autobump functionality using golden files
extend autobump to use a specific release tag
extend autobump to use a specific sed script instead of multiple keys and replace, since this breaks with fancy scripts like \+k3s :p

cc @mudler


fix incorrect output of Qwen2-7B-Instruct-GPTQ-Int4 and Qwen2-7B-Inst…

…ruct-AWQ
ipex kernel provide func like add_bias, so no need add it outside
What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil please help review and merge it. thanks

Looks good, thanks for the fix!


require tests to pass on windows before we trigger an edge release

At the moment, we can trigger an edge release even if the tests fail on windows.
Here's what the agent pipeline looked like pre-DAG:

It may have been intentional to move the windows tests off the critical path,so opening this for discussion

Here's basically what we have now, with green being the fast path, red being slow tests, orange being things waiting on those slow tests:

We could make the build-binary-windows-* steps depend on test-windows, which would be more logical, but that puts a fair bit of extra stuff on the orange critical path:

Your proposal looks more like:

I think I like that best; chances are the linux tests will catch common issues, but this change gives us the safety net of not proceeding to release an agent that hasn't passed windows tests.

There's actually one other detail that I omitted from these diagrams; the :hammer: bk cli step is essentially an integration test that uses https://github.com/buildkite/cli to run a sample pipeline using the buildkite-agent from this build, against the fake buildkite API that buildkite/cli provides.
I think that should also happen before the release steps; so it would look like this:

graphviz source for posterity
digraph G {
rankdir=LR
"build-binary-linux-"   [color=green]
"build-binary-other-"   [color=green]
"build-binary-windows-" [color=green]
"build-docker-linux-"   [color=green]
"build-github-release"   [color=green]
"build-package-linux-*"  [color=green]
"junit-annotate"         [color=orange]
"test-bk-cli"            [color=green]
"test-linux"             [color=green]
"test-windows"           [color=red]
"upload-release-steps"   [color=orange]
"test-linux"             -> "junit-annotate"
"test-windows"           -> "junit-annotate"
"test-linux"             -> "build-binary-linux-"
"test-linux"             -> "build-binary-other-"
"test-linux"             -> "build-binary-windows-*"
"build-binary-linux-"   -> "test-bk-cli"
"build-binary-linux-"   -> "build-docker-linux-"
"build-binary-linux-"   -> "build-package-linux-"
"build-binary-linux-"   -> "build-github-release"
"build-binary-other-"   -> "build-github-release"
"build-binary-windows-" -> "build-github-release"
"test-windows"           -> "upload-release-steps"
"test-bk-cli"            -> "upload-release-steps"
"build-docker-linux-"   -> "upload-release-steps"
"build-package-linux-"  -> "upload-release-steps"
"build-github-release"   -> "upload-release-steps"
}


Copying text can be frustrating

Illustrated by the animation below:

When attempting to highlight text in a response, the expanded node is collapsed after releasing the mouse click.

+1. This is so annoying.


Details on MFA for users

Please add details on MFA settings for users

how often will they be prompted?
What actions will cause prompts?
Are there any options for trusted IPs or trusted devices?
Methods available for MFA (it makes it sound like you can't use SMS, which is needed at least as a backup).  You can't have people setup with only a single MFA option.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfac0ecf-e5a9-c5ff-f8c2-ce27789708f5
Version Independent ID: 0f5e0cc9-a54f-a5c8-192d-d60a6a4db3ff
Content: Azure Active Directory security defaults
Content Source: articles/active-directory/fundamentals/concept-fundamentals-security-defaults.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@danmyhre
Thanks for your feedback! I have assigned this issue to the author who will investigate and update as appropriate.

As mentioned in the doc security defaults is not intended as a method for customers who need customization. It is designed for customers who need an easy button to enable MFA and don't want to configure anything.
If you need the ability to customize MFA settings you will need to enable Conditional Access based Azure AD Multi-Factor Authentication.

As mentioned in the doc security defaults is not intended as a method for customers who need customization. It is designed for customers who need an easy button to enable MFA and don't want to configure anything.
If you need the ability to customize MFA settings you will need to enable Conditional Access based Azure AD Multi-Factor Authentication.

Understood, but I think the details I asked about should still be added to the article as it is too vague.  Need more details on what exactly these defaults are.

Understood, but I think the details I asked about should still be added to the article as it is too vague.  Need more details on what exactly these defaults are.

I will forward your question to the Program Manager who owns the feature. Have documented as much information as they have given me.

I will forward your question to the Program Manager who owns the feature. Have documented as much information as they have given me.

Email out to PG for followup.

Email out to PG for followup.

Thanks @MicrosoftGuyJFlo !

Thanks @MicrosoftGuyJFlo !

@danmyhre The only addition the PM is prepared to add regarding normal user sign in is... "consistent/normal sign-in behavior will not require MFA" Does that help clear it up at all for you?

@danmyhre The only addition the PM is prepared to add regarding normal user sign in is... "consistent/normal sign-in behavior will not require MFA" Does that help clear it up at all for you?

Bummer, not really.  When working with clients to implement and train on this, more details would be better.

Bummer, not really.  When working with clients to implement and train on this, more details would be better.

Sorry. There really isn't much more to it than that.

Sorry. There really isn't much more to it than that.

#please-close

#please-close


Current .desktop file doesn't work well with GNOME 3; proposed suggestion follows

First off, it tries to fetch an icon from /opt/, and there's nothing there, so no icon shows up. On my end, since I use Numix icons, I just directed the path to /usr/share/icons/Numix-Circle/48/apps/chromium.svg
Secondly, the .desktop file needs this additional field: StartupWMClass=chromium-browser. This makes it possible to favorite the browser into the GNOME dash.

What build of ungoogled-chromium are you using?
The .desktop file generated by chrome-wrapper is from Google's own code. This project doesn't touch that at all.
The .desktop file that is part of the Debian and Ubuntu packages is from Debian and work fine on GNOME 3 for me.

I'm using this one: https://aur.archlinux.org/packages/ungoogled-chromium-bin/

That package isn't maintained by me or affiliated with this project. You should post the issue on that page.
I don't know what that maintainer did, but the .desktop file that is part of the Debian packaging scripts of this project works correctly with GNOME 3. Maybe that can be used as a reference.

Does this project maintain ainy binaries/PKGBUILDs for Arch-like distros?

There is #44, which is to add a PKGBuild generator to utilikit (but it has not gotten anywhere). Otherwise, there is an archlinux configuration type in utilikit to produce GN flags and patches to use.


Add icon field to tab

Enhancement
Add an icon to a tab.  This could use the icon property like tabarray or an htmlClass property on the tab item itself.
@json-schema-form/angular-schema-form-lead

@chargrove Agree, would be a nice feature.

Would be a great add in conjunction with #336


Update config.yaml

Config changes proposed in this pull request
For new organization members
I acknowledge that

[x] I have read and understood the Open Source Guidelines
[x] I agree to act accordingly (with due dilligence) to our guidelines
[x] I have no open questions regarding the topics covered

Found during review: https://github.com/baloise/org/issues/4

Found during review: https://github.com/baloise/org/issues/4

Replaced by #5

Replaced by #5


Separate diagnostic edmf precomputed quants int 4 funcs

Thanks! I prefer to keep Fields to be consistent with the rest of the code base. But I'm fine with this change if @Sbozzolo thinks it's a good idea.

Fields would make search-and-replace operations easier, but I can see that it is highly redundant, so I don't have strong opinions.

bors r+


support custom socket factory

Summary
Support custom socket factory as requested in #1391.
Checklist
Delete items not relevant to your PR:

[x] Unit and integration tests covering the common scenarios were added
[x] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@zhicwu do we have associated issue for this PR

@zhicwu can you provide a code sample so we could add it to documentation

@zhicwu can you provide a complete code sample so we could add it to documentation

There's test(example) as well as default implementation. Do we still need complete code sample? I didn't see that happening in the server repo :)
Anyway, this was requested by @mayankvadariya, so let's wait for his comments before merging the PR.

@mzitnik, can we merge this PR to close the issue?

Thank you @zhicwu for this effort. It slipped as I had been busy lately.

Thank you @zhicwu for this effort. It slipped as I had been busy lately.

No problem. Let us know if it fits your need.

Yes, I tested the changes locally. 🙌  Please let me know when can we release these changes.


How to get caption results on the COCO test dataset

Hi. Thanks for your work on Attention on Attention for Image Captioning.
May I ask how can I get results on COCO test images (not karpathy split) given that I've extracted the bottom up features of all the 40k images in the COCO test dataset. Because the dataloader.py can only load the karpathy split images (train, val and test) which are all from the official training and validation COCO images, but not the official COCO testing images.

Sorry for the delay.
Please refer to https://github.com/husthuaan/AoANet/issues/9. It's similar.

You can use this code. I've wrote it a few days ago for my own experiments. I have adjusted it for you to fit for this repository. First download the COCO test 2014 images and rename the folder to 'test_images', then run this code to create the cocotalk file for test images:
from PIL import Image
import json
import os

cocotalk_dir = 'data/cocotalk.json'
with open(cocotalk_dir, 'r') as c:
    cocotalk = json.load(c)
test_images = os.listdir('test_images')
images = []
for img in test_images:
    tmp = {}
    tmp["split"] = "test"
    tmp["file_path"] = "test2014\\" + str(img)
    image_id = img.split('_')[2]
    image_id = int(image_id.lstrip("0").split('.')[0])
    tmp["id"] = image_id
    with Image.open(os.path.join('test_images', img)) as im:
        tmp['width'], tmp['height'] = im.size
    images.append(tmp)

cocotalk_test = {}
cocotalk_test["ix_to_word"] = cocotalk['ix_to_word']
cocotalk_test["images"] = images

with open('data/cocotalk_test', 'w') as w:
    json.dump(cocotalk_test, w)

Hope this helps!


Block Todos with no text to get added

Hi @vaishnav-sh , I've noticed that we can add the todo item without specifying any text. Ideally this should not happen in the application.
If you allow me then I can work on fixing this issue.

Hi @vaishnav-sh, I want to work on this issue, please assign it to me :)

@vaishnav-sh - also please add the hactoberfest label to this issue. 👍

Issue is solved here is my pull request!
https://github.com/vaishnav-sh/todo-app/pull/7#issue-1016391412
Happy hacking!

Hi @vaishnav-sh , I've raised the PR #8 . please review it and merge it .


underscore version needs update

Describe the bug
The package underscore from 1.13.0-0 and before 1.13.0-2, from 1.3.2 and before 1.12.1 are vulnerable to Arbitrary Code Injection via the template function, particularly when a variable property is passed as an argument as it is not sanitized.
To Reproduce
Steps to reproduce the behavior:

npm install, installs "underscore": "1.9.1". Please help in updating the version of underscore to 1.13.6

This project is dead. You will need to use react-table and customize everything yourself. Sorry. I was using this table about a year ago and built a project with it only to have serious bugs and needed to scrap it all and rebuild all my tables with react-table.

Since this repository seems to be no longer maintained, a version fix is unlikely. There have been efforts to fork the repository and maintain the fork (or at least bump the versions of dependencies as needed). The most active one I have found yet is: https://github.com/BonnierNews/react-bootstrap-table2
The maintainer provides a short summary on how to replace the dependency for react-bootstrap-table-next in your package.json making this viable for use with npm as well.


update lodash package

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Update lodash dependency, to resolve prototype pollution.

Hey @AlexJanss
I think you forgot to update the yarn.lock file as well 😉
Can you upgrade it again? or close the PR if your problem is solved

Ah yes sure! I will upgrade the yarn.locl file as :)

closed since yarn.lock was not updated


Pagination not working

Hi, I'm trying to implement pagination in my site but it just won't work in chrome. It appears, but it doesn't call the function defined in pagination-action (it does work on firefox). The worst thing is, I took a look at the sample code in your page and that sample is supposed to create toasts but they don't appear either (no toast is working in the sample page in fact). Could you take a look at it please?

Cannot explain the pagination for now.
But toast is broken because i didn't test it when i updated the materialize JavaScript (where the global toast function changed to Materialize.toast).
I'll fix the toast later today.
If that doesn't fix your issue, then I'll need a link or something so we can see your particular issue.

Okay, i fixed the toast thing.
But I don't know what to do with pagination. Just tried our example page in Chrome, Firefox and IE. Seems to be working.

Thanks for fixing the toast, and sorry about the pagination, it turned out to be my problem (chrome was reloading from cache and not showing last changes I did).
BTW, unrelated issue, but is it necessary to have ui.materialize in the module as a dependency for pagination to work? the sample wasn't clear about it.

Yes it is.
ui.materialize includes all the directives, if you don't include the ui.materialize module, Angular won't know how to resolve the materialize directives in your app.


feat: txmanager, feat: hb

Related Issue
resolve: #(Write down your issue number)
Description

implement tx manager
implement honeybadger

Checklist
Thank you for your contribution.
Before submitting this PR, please make sure:

[x] Applying goimports
[x] Test case
[x] End of Work

We need network package?


[conversations] Drop python 3.6

Description
closes https://github.com/Azure/azure-sdk-for-python/issues/25166
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Hello @syso-jxx, I have sent a PR that will resolve the review from the Azure team. May you please check it out? Thanks!


Pawn takes unnecessarily long path

https://i.imgur.com/lFGqJVT.png
The pawn could get to its destination through either "hate" space. It chooses the longer path. Replace both red squares with orange and the problem goes away.

This is out of scope of this mod, that's a problem with the game's path finding.
TBH the better path is probably the longer one since the shorter one will force the pawn to go through a light and a chair with wool on top of it (tiles with more than one item on it slow the pawn more) OR a light + mending table.
You could also try to adjust this mod's settings in Settings->Mod Settings->Path Avoid->Advanced to make the 'strong' less powerful and see if that makes any difference.