[MacOS Electron Popup] allow deeplink popup for all routes on mac

Details

With this PR, we allow all routes to new expensify to show the option to show the "Open link in New Expensify?" desktop app popup.
Specifically, these changes were brought forward to support the desktop app popup when transitioning from old expensify to new expensify via the concierge button on old expensify.
Fixed Issues

$ https://github.com/Expensify/App/issues/16083
PROPOSAL: https://github.com/Expensify/App/issues/16083#issuecomment-1479940390
Tests

We need to check for the deeplink popup when transitioning from old expensify to new expensify via the concierge button on old expensify.
It is slightly complicated to test this functionality locally since we disable the popups in dev environment. To setup the development environment, please do the following:

Checkout this PR locally.
Change the following lines to remove the environment check:

https://github.com/Expensify/App/blob/8b9ad23e7e7c033544c0eac88079e6730813cf99/src/components/DeeplinkWrapper/index.website.js#L19
https://github.com/Expensify/App/blob/8b9ad23e7e7c033544c0eac88079e6730813cf99/src/components/DeeplinkWrapper/index.website.js#L25

Run npm run web.
Download the production Desktop App from new.expensify.com.

To continue testing the PR,

Open expensify.com, login with account A.
Run app on localhost and login with same account.
Open the Desktop and login with account A. You can close the app now.
Click on the concierge button at bottom right on expensify.com/inbox
Now, the thing here is that it'll redirect to new.expensify.com, which is not where we want to test. As soon as you click on the button, you'll be redirected. Try to copy the link as soon as possible. It'll be of the format:

https://new.expensify.com/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Once you copy the link, change the scheme and host to:

http://localhost:8080/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Ensure that you are shown the "Open app in "New Expensify" popup.

[x] Verify that no errors appear in the JS console

Offline tests

N/A.
QA Steps

Since the concierge button on old dot redirects to new expensify, we need to change the URL to test on staging.

Open expensify.com, login with account A.
Open staging.expensify.com and login with same account.
Open the Desktop and login with account A. You can close the app now.
Click on the concierge button at bottom right on expensify.com/inbox
Now, the thing here is that it'll redirect to new.expensify.com, which is not where we want to test. As soon as you click on the button, you'll be redirected. Try to copy the link as soon as possible. It'll be of the format:

https://new.expensify.com/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Once you copy the link, change the host to:

https://staging.new.expensify.com/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Ensure that you are shown the "Open app in "New Expensify" popup.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Haven't uploaded videos for platform other than MacOS Web because:

The desktop app popup is available only for MacOS.
You cannot open Old dot on desktop app.

Do bring this up if you disagree.

MacOS [Web]
https://user-images.githubusercontent.com/54077356/229527263-04bd714d-a763-410e-a7d6-a8e8fd5785b0.mp4

@iwiznia @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Prince-Mendiratta the test steps on dev could be simplified as well.

Make sure you have the desktop app installed
Open links like [localhost:8080, localhost:8080/settings, localhost:8080/iou/request etc] in a new browser.
Verify that you see a opne in desktop app popup

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


new folder for "environment" variables

As discussed here, this PR renames the water folder to environment and moves nutrients and biodiversity variables from sdg-indicators to the new environment folder.
Moreover, Nitrogen|Cropland Budget|Input is renamed and simplified to Fertilizer Use|Nitrogen
Biodiversity indicators are copy-paste from sdg-indicators.

Great!
Some comments:
I guess we need a tag for Electricity Source which is used in water.yaml.

Fertilizer Use|Nitrogen:
Fertilizer Use|Nitrogen|Synthetic:
Fertilizer Use|Nitrogen|Organic:
Unit should be Tg N/yr, not Tg P/yr.

Great! Some comments: I guess we need a tag for Electricity Source which is used in water.yaml.

Fertilizer Use|Nitrogen:
Fertilizer Use|Nitrogen|Synthetic:
Fertilizer Use|Nitrogen|Organic:
Unit should be Tg N/yr, not Tg P/yr.

Thanks for spotting my copy-paste mistake. Fixed now.
Tags also work if defined in other folders. So, no need to move them to the environment folder.


gluster: fix tcmu_get_attribute error check

This fixes the wce tcmu_get_attribute() error check, which currently has
a cut-n-paste bug.
Signed-off-by: David Disseldorp<EMAIL_ADDRESS>

thanks! :+1:


Refactoring the action API handler

This pr refactors the action API handler and the entitlement provider:

the action activation bits are factored into their own traits and enable mock testing of the "invoke action" functionality. It also makes invoking an action accessible from other API handlers that need to post activations.
the entitlement checks to permit checking of quotas independent of resources.

pg2/737 has landed.

pg2/745 approved.
going to rebase and squash.

Going to close since #1600 is a superset.


Parent subfolder misssing

if you have an structure like

assets/images/instruction/file1.png
assets/images/file2.png

following happens
you create only  - assets/images/instruction/
the parent folder  - assets/images/ is missing in assets catalog

There is a really important issue! Thanks a lot! Fixed in https://github.com/L3odr0id/asset_fill/commit/6032321d94b834411339e892ac10df0933cbd782


Using too many  leader lines makes the browser laggy

i am using the database structure to create a web structure of connection between database and also all are drag-gable if there are 10 tables connected to each other all the connections are redrawn again on drag change and the lag is only happening in chrome browser.

Hi @AshutoshViramgama, thank you for the comment.
How many lines did you add to the page?

Around 20 lines are drawn each time on drag

There are 116 lines in https://anseki.github.io/leader-line/ .
If this page works fine in your computer, it seems that your code has a bug.
If so, to reproduce that, could you show an example by using e.g. https://jsfiddle.net/ ?

@anseki i got your point but they are not changing or redrawing lines on each event.
I mean to say that on drag event on each mouse pointer changes each time 20 lines are removed and redrawn. for eg there are 20 lines at present on the page and if i change the mouse cursor on screen then at each mouse changing postion 20 lines are removed and redrawn again.
did you got my point?

Your report means that the code that removes and redraws lines has a bug. The example page that I indicated also has draggable lines. Therefore your code may have a bug.
Nobody can find a bug in your code without reading your code.

hi @ahmedshaaban00
I can't reproduce your problem. I'm using more then 3 arrows and its still good.
Is your code working fine with only one arrow? Because if you call position only every 350ms this can't be smooth as it results in about 3 updates per second. You need much more I think. Normally your Browser updates with 60 frames per second.
Anseki has 2 nice repositories that might help you.
https://github.com/anseki/anim-event ...to add event listener with better perfomance by using requestAnimationFrame.
https://github.com/anseki/plain-draggable ...create draggable elements with onMove event and more. I think these events are also optimized by  requestAnimationFrame

@christian-iron60, thank you for your help. :smile:
@ahmedshaaban00, I also can't reproduce that problem.
Your code maybe have a bug. But we didn't read your code, i.e. the example that you shew is not enough. Nobody can find a bug in your code without reading your code.
Also, try to use AnimEvent.

https://jsfiddle.net/

i meet same questions， please tell me how to fix。thanks

No reply came from @yuleiQ but the issue seems to have been already solved by solving of @yuleiQ's another issue. :smile:


Added String Fibonacci

This programme uses String Addition to find Nth fibonacci.

@hegdenaveen1  You can remove that std:: because you use using namespace std

done.


When having more than two tabs opened, the OidcProvider stops producing events after 2 errors

Issue and Steps to Reproduce
Unrelated but the react demo is down
With service worker
Note that we are NOT using offline_access so no refresh tokens
We are currently encountering an issue where when you have more than 2 tabs opened, if 2  of them errors, the third tab stop emitting events.
We are using silent login with a SSOLifetime. When the SSO expires and the silent login tries to renew the tokens, it errors, requiring login. It's working as expected with 2 tabs.
When you have more than 2 tabs, the 3rd one isn't receiving anymore events (from onEvent in OidcProvider) once the first 2 have both received refreshTokensAsync_error.
This causes an issue because on the first 2 tabs we are seeing the SessionLost page as expected, but on the 3rd one, it stays inside the app but all the calls are returning 401.
To reproduce:

Set UserSsoLifetime to 300 seconds (5 minutes)
Set AccessTokenLifetime to 120 seconds (2 minutes)
Wait for the silent login to try and fetch new tokens once the SSO has expired.
First 2 tabs will receive errors, but the 3rd one will stop during the lock.

Versions
latest
Screenshots

Expected
The 3rd tab receives the errors allowing the SessionLost page to show
Actual
The 3rd tab doesn't receive the error, staying inside the app and all fetch calls are returning 401.
Additional Details

Thank you @dpcodes for your issue.
I am on it. It will help me a lot !

hi @dpcodes which version are you using?

I tried with 7.13.14 and latest, and it was happening on both

Quick tests with 7.15.4-alpha.1309: the issue appears to be fixed.
Merci beaucoup Guillaume!

Hi @dpcodes , you can use mainlatest version now.


Problem with blogdown::new_site using starter-hugo-academic

Discussed in https://github.com/wowchemy/wowchemy-hugo-modules/discussions/2367

Originally posted by juniperover July  3, 2021
I'm trying to use blogdown (v. 1.3.2) in RStudio (v. 1.4.1717/R version 4.1.0) on Mac Big Sur.
When invoking the new_site command, I get the following error message:
> new_site(theme = "wowchemy/starter-hugo-academic")

― Creating your new site
| Installing the theme wowchemy/starter-hugo-academic from github.com
trying URL 'https://github.com/wowchemy/starter-hugo-academic/archive/master.tar.gz'
downloaded 7.1 MB

trying URL 'https://github.com/wowchemy/wowchemy-hugo-modules/archive/v5.3.0.tar.gz'
downloaded 504 KB

Error: module "github.com/wowchemy/wowchemy-hugo-modules/wowchemy/v5" not found; either add it as a Hugo Module or store it in "/Users/[path-info]/themes".: module does not exist
Error in new_content(f2, open = FALSE) :
  Failed to create the file 'post/2020-12-01-r-rmarkdown/index.en.Rmd'.
In addition: Warning message:
In system2(find_hugo(), ...) :
  running command ''/Users/[path]/Library/Application Support/Hugo/0.84.4/hugo' new 'post/2020-12-01-r-rmarkdown/index.en.md' --themesDir themes -t starter-hugo-academic' had status 255
>

It appears that the site contents have been moved around so that a path is broken? Any advice or hope for a fix? TIA.

Blogdown does not form part of this Github project. Blogdown has its own dedicated Github repo and issue tracker, maintained by RStudio: https://github.com/rstudio/blogdown/issues


Seperate Environment deploy details from main CF file

This PR does a couple of things:

Creates a DeployEnvironmentInput which contains the fields
which are needed to create an environment.
Separates the Tags/Parameter/Template/StackName generation
into a seperate env.go file so cloudformation.go can focus on
deployment logic. I think this will make adding applicaiton/pipeline
deployments much easier.
Stores the ECR URL for the environment into the env struct.

Fixes #191
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nit: typo as usual in the commit message: separate


vi-translate for add-react-to-a-website document

@ThinhNu @ltmylinh Hi guys, I have translated add-react-to-a-website document, anyone can review its content for me? Many thanks.


Python interop client

I'm currently writing this code.

This is now awaiting test results that will be available tomorrow morning.

This was mostly-done a while ago but I've just checked with @donnadionne and there are no more lingering outstanding tasks left to do here.


OLS-379: Remove dev_config global in favor of using it from the main Config class

Description
Remove dev_config global in favor of using it from the main Config class.
Type of change

[x] Refactor

/approve
@tisnik any more concerns on this one?  it lgtm

Closed in favor of https://github.com/openshift/lightspeed-service/pull/943
See comment: https://github.com/openshift/lightspeed-service/pull/932#discussion_r1606912049


Show estimated delivery time on the listing

Not sure where it should go, but probably the order modal.

Good call. Should probably be on the contract detail screen too as this helps a user determine if they want to purchase or not.

Great!

This was done.


Add criticism to the prompt template.

I'm not sure how useful this will be, but it seems like more complex plans or do_nothing stages may benefit from the AI generating criticism of its own plan, and it doesn't seem to harm performance judging from a few tests (though feel free to check yourselves, of course!).

Hey @swapneils! Thanks for the PR! We actually did have criticisms at first, but decided to remove it to keep things simpler. So let's hold off on this until we're sure it gives noticeably better results.


datetime picker missing?

Hello is the datetime picker component missing? or I can't find it?

You may want to take a look at form_advanced.html

thank you!


added title-missing

Nice! Is there an exception for "include" files? I don't usually see those with titles

@nschonni Yes, validation for included files is out of scope for the current feature, but will eventually include a subset of metadata rules.


Build Output Folder reorganization

Summary

:exclamation: WARNING! This PR changes the structure of the out directory, adds extensions to the database files, and in general moves things around. BACKUP your out directory before testing.

This PR aims to reorganized the build output folder, as it was getting unruly. It creates some helper methods in Settings.cpp to handle finding the root folder regardless of what application is calling settings.
Also I did some minor code cleanup here and there.
Please TEST TEST TEST @Segs/testers
Issues closed
Closes #556
Additions/modifications proposed in this pull request:

Organize the output of the out folder, and standardize our path names
Give the db files an extension, so it's clear to the end user where to look if they need to edit manually (aka, reduce support question "where is my database file?")

Proposed File Structure
Proposed file structure

:open_file_folder: compile output folder

:open_file_folder: data
:open_file_folder: default_setup

:open_file_folder: mysql
:open_file_folder: pgsql
:open_file_folder: sqlite
settings_template.cfg

:open_file_folder: logs

output.log

:open_file_folder: maps
:open_file_folder: scripts
:open_file_folder: utilities

:open_file_folder: mapviewer_data
:open_file_folder: unit-tests

AuthDBEventRegistry
AuthEventRegistry
CommonEventRegistry
CRUDPEventRegistry
event_gen
FriendshipEventRegistry
FriendshipServiceFunctions
GameDBEventRegistry
GameEventRegistry
ManifestBuilder
MapEventRegistry

AuthExerciser
binConverter
dbtool
mapviewer
piggtool
SEGS.exe
slav
texConverter

segs_server
SEGSAdmin
segs.db
segs_game.db
settings.cfg
README.md

Notes
This was broken out of my original DBTool PR #778, which will remain focused on dbtool-v5

A positive side effect of this PR is that you can actually name your database files whatever you want. segs_accounts.sql or segs_game_info.db etc

Not sure why this took 19min to build =(
https://travis-ci.com/Segs/Segs/builds/107024079

Latest commit should fail due to:
undefined reference to Settings::getSettingsPath() etc in SEGSAdmin
Not sure why :man_shrugging: because we're including COMPONENTS and the correct header (Settings.h)

Herald did a lot of testing of this for me and we ran into some issues:
Win7 & Manjaro:
Checking for existing databases...
Setting arguments...
Failed to start DBTool Add User... **Please ensure you are NOT running as an administrator or sudo user**
Checking for existing databases...
WARNING: Not all databases were found. Please use the server setup to your left

With the following workflow
1. Setup CoH Data Files button not working properly in either environment
2. Extracting pigg Files progress bar fills up
3. Creating Default Directories just sits there at zero progress
a popup is saying
Stop Process?
This process is taking longer than expected, do you want to wait?

Every time I click No it adds 10%
WARNING: We couldn't find the correct data and/or maps directories. Please use the server setup to your left

These results are odd because I have no issues locally on Fedora.

Latest commit resolves pathing issues in testing.
However there is a new issue that has come to light: windepolyqt doesn't correctly output the required libraries needed for SEGSAdmin and some of the utilities in utilities subfolder. If the user already has QT installed with components, then it appears as though the OS will find the required files and run properly.
Since we don't really want everyone to have to download QT, we need to correct the windeployqt issue and (preferably) stick all the required libraries in one location where they are easy to find /libs or something.

With enormous thanks to @miles200 @mobbyg and @HeraldOfOmega for testing. This should be ready for merge.


Feature request: allow manual formatting of CHANGELOG before committing

In our projects we need to do some manual editing of our generated changelog before committing and tagging. We use this tool right now with --skip.tag, then format manually, git commit amend and then perform a manual git tag vx.y.z to achieve this.
Previously we used a tool that just generated the changelog and then paused to allow edits, waiting for an IO prompt to continue committing.
I was wondering if we could add something similar to commit-and-tag-version or if anyone has ideas how we can already achieve this with a postchangelog script for example (I tried but didn't get anything to work).
I would be happy to contribute to the project but just want to know beforehand if this is something that, when done properly, would get merged.
Example of the suggestion:
> npx commit-and-tag-version --manualChangelog
bumping version in package.json from 5.0.0 to 6.0.0
✔ bumping version in package-lock.json from 5.0.0 to 6.0.0
✔ outputting changes to CHANGELOG.md
⌛  Manually edit CHANGELOG.md, press any key to finalize...
✔ committing package-lock.json and package.json and CHANGELOG.md
✔ tagging release v6.0.0

So, I think this might work for you - https://github.com/conventional-changelog/standard-version/pull/530 - it changes the way that the lifecycle hooks are invoked so that you could run an interactive editing session during the release.
I didn't merge that PR when I reviewed the open PRs to standard-version, because:

I think it needs to remove the old runExec.js as part of the change as it would be no longer be used (there's a duplicate in runExecFile.js, which seem to differ only in the variable names? That one would still be used, I guess? Not sure if they can all be replaced with the same strategy)
I wasn't sure what the other implications were of that change, if any. For example, is security more of a concern?

Since it seemed like a niche use case to me and the PR wasn't ready, I didn't look into it further - but if you're happy to do the investigation, I'd be happy to merge it (or an alternative solution to the same problem). I think it is on-topic and it seems like you're not the only person who wants it.

I like the $EDITOR CHANGELOG.md idea, but unfortunately I don't think it would work for windows users. As far as I know, Windows has no equivalent of EDITOR or any other way to easily invoke an editor.
If anyone wants to clean up the above PR and submit it, I'd happily accept it.

One option to fill in the gap for people that don't have it set is to use git var GIT_EDITOR. This is a relatively new function but available in current stable Git releases. It abstracts the logic Git does to find some workable editor from $VISUAL, $EDITOR, Git configs or system discovery. Since we know we're in a Git environment anyway we could just use that.

Sounds like a nice solution to me - it would make no assumptions about what shell people were using, so would even work for any (probably hypothetical) shells without EDITOR.
Stackoverflow seems to suggest that windows users will get an error message if they don't do some extra config, but I guess we could detect failure and hint that GIT_EDITOR is missing - which would work for all.

Hello, I was looking for the same feature for our project as generated changelogs sometimes need a little rectification.
A more general solution might be to add a flag the same as we have --skip to allow pausing whatever lifecycle we need, and allow the user to make any manual needed changes before continuing.
for example : --pause.changelog


When using non-stream mode, the client is blocking.

When I run the Yi-6B model inference service using the command cargo run --release -- --port 2000 --weight-path /home/yi-6b/ yi --repeat-last-n 32 and then execute python examples/llama.py as a client test, the client program keeps blocking. After pressing Ctrl+C, the following output can be seen on the server:
Prompt "<|im_start|>user\n Explain how to best learn Rust. <|im_end|>"
Request cmpl-8f264377-117d-4e63-87b3-41621869c188 with length 13 added to sequence group.
Send stream response error!
Request cmpl-8f264377-117d-4e63-87b3-41621869c188 decoding finished in 0 seconds

 [1 requests] Prefilling: 13 prompt tokens processed in 289 seconds

 [1 requests] Decoding: 0 tokens processed in 0 seconds (0 tokens/s)

However, running python examples/benchmark.py works successfully.  The following curl test command also gets stuck.
curl -X POST "http://<IP_ADDRESS>:2000/v1/chat/completions" \
     -H "Content-Type: application/json" \
     -H "Authorization: Bearer YOUR_API_KEY" \
     -d '{
           "model": "llama7b",
           "messages": [
               {"role": "user", "content": "Explain how to best learn Rust."}
           ],
           "temperature": 0.7,
          "max_tokens": 128,
          "stop": {"Single":"</s>"}
       }'

When I run the Yi-6B model inference service using the command cargo run --release -- --port 2000 --weight-path /home/yi-6b/ yi --repeat-last-n 32 and then execute python examples/llama.py as a client test, the client program keeps blocking. After pressing Ctrl+C, the following output can be seen on the server:
Prompt "<|im_start|>user\n Explain how to best learn Rust. <|im_end|>"
Request cmpl-8f264377-117d-4e63-87b3-41621869c188 with length 13 added to sequence group.
Send stream response error!
Request cmpl-8f264377-117d-4e63-87b3-41621869c188 decoding finished in 0 seconds

 [1 requests] Prefilling: 13 prompt tokens processed in 289 seconds

 [1 requests] Decoding: 0 tokens processed in 0 seconds (0 tokens/s)

However, running python examples/benchmark.py works successfully. The following curl test command also gets stuck.
curl -X POST "http://<IP_ADDRESS>:2000/v1/chat/completions" \
     -H "Content-Type: application/json" \
     -H "Authorization: Bearer YOUR_API_KEY" \
     -d '{
           "model": "llama7b",
           "messages": [
               {"role": "user", "content": "Explain how to best learn Rust."}
           ],
           "temperature": 0.7,
          "max_tokens": 128,
          "stop": {"Single":"</s>"}
       }'

Which type of GPU device you have used? The non-stream mode is designed to block the caller, I'm not sure if it blocks the calling thread without any response in the end (bug) or it just takes a long time for response (depend on the GPU capability).

This issue has been addressed in #80 , please use the latest update.


Task: fix formatting for markdown files in PRs

Task Description
When online editing a markdown file in Github there is often a problem that the format check fails which makes it necessary to check out the file locally to fix formatting. We should turn off md formatting in PRs.
Sub-tasks

[ ] Review ci-test workflow

Related Issues
Link to related issues or tasks, if any.
Additional Context
Add any other context or information here.

Solution was provided by Taimoor:

Override the Default HTML Formatter with Prettier in Workspace Settings JSON:

"[html]": { "editor.defaultFormatter": "esbenp.prettier-vscode"},

We resolve the issue of markdown files being excluded from CI checks by overriding the --check argument of the Prettier command in the workflow.


Support DO SDK on Windows & Mac

There have been no new check-ins to github's feature/xplat-sdk. However there have been checkins to the private AZDO branch. feature/merge_sdk is a fork of the private feature/xplat-sdk branch, merged with the public github main.
All merge conflicts resolved, and building on windows/mac/linux.

Before checking in, we must verify that the MIT license is still the correct one to distribute with.
@cmknox

Pipeline to build DO Agent using docker to target non-native OS and/or architecture.

Should we move these under a 'du' folder instead of 'linux'?

Refers to: azure-pipelines/build/linux/doclient-lite-docker.yml:1 in e6793ee. [](commit_id = e6793eeb02bb05917ac3860815d45f9cc644cae6, deletion_comment = False)

Pipeline to build DO Agent using docker to target non-native OS and/or architecture.

Can move them into linux/du - I'll adjust the pipelines to point to the new location afterwards.

In reply to: 918661335

Refers to: azure-pipelines/build/doclient-lite-docker.yml:1 in e6793ee. [](commit_id = e6793eeb02bb05917ac3860815d45f9cc644cae6, deletion_comment = False)

Pipeline to build DO Agent using docker to target non-native OS and/or architecture.

Which remidns me, the existing windows/mac pipelines were created from the ADO source, I'll need to recreate those pipelines targeting the github repo.

In reply to: 919353043

Refers to: azure-pipelines/build/doclient-lite-docker.yml:1 in e6793ee. [](commit_id = e6793eeb02bb05917ac3860815d45f9cc644cae6, deletion_comment = False)


frontend coverage html report

Describe the bug
Can we do a html coverage report now?
Related:

#1282

@skoeva has added this locally and will make a PR.


feat(ros2_tracing): add API to get node name from callback group address based on Ros2DataModel.

Signed-off-by: atsushi421<EMAIL_ADDRESS>This PR adds the  API to get the node name from callback group address based on Ros2DataModel.
Related thread: https://emb4hq.slack.com/archives/C03TE75R9C0/p1661140765913979?thread_ts=1661127490.661349&cid=C03TE75R9C0

Thanks for checking.
I have corrected the points raised, could you please review again?


Deploy script failing for me

I tried to deploy this a few times and failed, though deploy has worked for me in the distant past (2+ years ago).
In this case, I even blew away all my local code and started fresh from scratch following our README https://github.com/GreenInfo-Network/seattle-building-dashboard?tab=readme-ov-file#how-do-i-install-it instructions for install and deploy.
Each time I get the same error at the bottom of the output below. Not sure yet what the cause is.
% nvm use
...
Now using node v18.12.1 (npm v8.19.2)
% npm install
...
added 1152 packages, and audited 1153 packages in 26s

% bower install
...

% npm run deploy

><EMAIL_ADDRESS>deploy
> npm run dist && gulp deploy

><EMAIL_ADDRESS>dist
> npm run clean && gulp

><EMAIL_ADDRESS>clean
> rm -rf dist/

[10:52:50] Using gulpfile ~/Documents/GINlocalcode/seattle-building-dashboard/gulpfile.js
[10:52:50] Starting 'default'...
[10:52:50] Starting 'clean'...
[10:52:50] Finished 'clean' after 4.3 ms
[10:52:50] Starting 'fileinclude'...
[10:52:50] Finished 'fileinclude' after 27 ms
[10:52:50] Starting 'styles'...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
[10:52:51] gulp-autoprefixer:
  autoprefixer: /Users/danrademacher/Documents/GINlocalcode/seattle-building-dashboard/src/styles/main.css:4730:5: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.
[10:52:51] Finished 'styles' after 1.11 s
[10:52:51] Starting 'scripts'...
[10:52:53] Finished 'scripts' after 1.74 s
[10:52:53] Starting 'images'...
[10:52:53] Finished 'images' after 93 ms
[10:52:53] Starting 'data'...
[10:52:53] Finished 'data' after 7.14 ms
[10:52:53] Starting 'templates'...
[10:52:53] Finished 'templates' after 46 ms
[10:52:53] Starting 'cities_config'...
[10:52:53] Finished 'cities_config' after 15 ms
[10:52:53] Starting 'copy-lib'...
[10:52:53] Finished 'copy-lib' after 31 ms
[10:52:53] Finished 'default' after 3.08 s
[10:52:55] Using gulpfile ~/Documents/GINlocalcode/seattle-building-dashboard/gulpfile.js
[10:52:55] Starting 'deploy'...
[10:52:57] 'deploy' errored after 1.15 s
[10:52:57] TypeError: Cannot read properties of null (reading '0')
    at module.exports.Commit.actor (/Users/danrademacher/Documents/GINlocalcode/seattle-building-dashboard/node_modules/gift/lib/commit.js:145:56)
    at module.exports.Commit.parse_commits (/Users/danrademacher/Documents/GINlocalcode/seattle-building-dashboard/node_modules/gift/lib/commit.js:111:21)
    at /Users/danrademacher/Documents/GINlocalcode/seattle-building-dashboard/node_modules/gift/lib/commit.js:71:39
    at ChildProcess.exithandler (node:child_process:404:7)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:552:15)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket.<anonymous> (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28)
    at Socket.emit (node:domain:552:15)

┆Issue is synchronized with this Asana task

it has worked fine for me recently on a fresh install from ~6 mo ago.
Unfortunately, this is an error stemming from a 13 year old node package...
Looks similar to this:
https://stackoverflow.com/questions/47211594/gulp-gh-pages-not-working
And to some extent this: https://github.com/shower/shower/issues/318 (we are also using gulp-gh-pages here)
In package-lock.json I see that we have gift version 0.6.1, so possibly that "resolutions" block fix from SO would help get a more recent version


[stable/cockroachdb] Option to choose the schedulerName

What this PR does / why we need it:
On some kubernetes installation we can have different schedulers. This PR allows to set this parameter.
Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/retest

/retest

@Smana I need this functionality now too and am happy to pick your PR up and try to get it merged. By any chance, do you remember why the tests failed? I was trying to look at the details and they seem to have vanished. Thanks!

@Smana I need this functionality now too and am happy to pick your PR up and try to get it merged. By any chance, do you remember why the tests failed? I was trying to look at the details and they seem to have vanished. Thanks!

Sorry for the delay @CoreyLoose. Actually I really don't know why the tests failed :/


fix #33188 MSAA depth buffer not used for external texture

When rendering to an external texture and MSAA was active (as happened
in the Oculus Mobile ARVR plugin) no MSAA was rendered as the correct
depth buffer and multisample texture target was not used.
This also fixes https://github.com/GodotVR/godot_oculus_mobile/issues/54

I changed the PR to execute the new code only when #ifdef ANDROID_ENABLED

@BastiaanOlij Is there any chance that a desktop platform or iOS may use an external_texture?

@clayjohn the Oculus desktop driver uses the same approach and from what I know of OpenXR it also will require this logic.
The way these systems work is that they require a texture chain to be created into which the images are rendered. So instead of using the render target Godot creates we provide the target and it changes for every eye and every frame we render. The SDK takes the chain of images to do timewarp logic as I understand it and keep the framerate up by reprojecting the images.
You can always do a copy from what Godot renders to these texture chains (that is how I did the original Oculus plugin) but that is very wasteful and a definite bottleneck on mobile hardware so we came up with this approach.

I now changed the PR to mirror the checks found in the function void RasterizerStorageGLES2::_render_target_allocate(RenderTarget *rt). But I can't test if it works for Oculus Desktop and OpenXR .

I agree with the comments in https://github.com/godotengine/godot/issues/33188#issuecomment-551227035 that we can already merge this to fix MSAA on mobile VR.
Desktop VR apparently needs to be handled partly in the plugins themselves, so we should open issue(s) to make sure to handle this before 3.2 in the various desktop VR plugins @BastiaanOlij @NeoSpark314.

Thanks!


Custom view hovers: Email addresses get auto-linked, but to a broken link

The tooltip is being provided as a string (not a markdown string), and you can see that the auto-link is bogus

@eamodio Can you share what you set as the tooltip? I'm not sure how to get the auto-link to happen

@RMacfarlane I can verify this


Schematics: Unit testing a rule that uses mergeWith/apply fails due to missing context

Addendum
In creating the test case I've realised that I'm not passing a partialContext to callRule, so it is definitely missing context, however, it is not at all clear what context is necessary for mergeWith to succeed and the error does not indicate that context is actually missing.
Happy for this to be marked as a question instead. Guidance on how to provide the context and what context to provide would be amazingly useful.
🐞 Bug report
Description
Using callRule to unit test rules within a schematic fails when it comes to rules which return mergeWith
🔬 Minimal Reproduction
See: https://github.com/jdpearce/schematics-apply-problem
Given a rule which applies template files to the tree, this unit test will fail with TypeError: Cannot read property 'path' of undefined:
describe('applyTemplateFiles Rule', () => {
  let tree: UnitTestTree;

  beforeEach(async () => {
    tree = new UnitTestTree(Tree.empty());
  });

  it('should apply the files to the tree', async () => {
    const schema = {};

    tree = (await callRule(applyTemplateFiles(schema), tree)) as UnitTestTree;

    expect(tree.files).toEqual(jasmine.arrayContaining(['/libs/destination/test.txt']));
  });
});

🔥 Exception or Error
Failures:
1) applyTemplateFiles Rule should apply the files to the tree
  Message:
    TypeError: Cannot read property 'path' of undefined
  Stack:
        at <Jasmine>
        at ./apply-problem/node_modules/@angular-devkit/schematics/tools/file-system-engine-host-base.js:216:96
        at ./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/url.js:13:73
        at Object.callSource (./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/call.js:55:20)
        at ./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/base.js:45:60
        at Object.callSource (./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/call.js:55:20)
        at ./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/base.js:53:23
        at MergeMapSubscriber.project (./tmp/apply-problem/node_modules/@angular-devkit/schematics/src/rules/call.js:74:24)
        at MergeMapSubscriber._tryNext (./tmp/apply-problem/node_modules/rxjs/internal/operators/mergeMap.js:69:27)
        at MergeMapSubscriber._next (./tmp/apply-problem/node_modules/rxjs/internal/operators/mergeMap.js:59:18)
        at MergeMapSubscriber.Subscriber.next (./tmp/apply-problem/node_modules/rxjs/internal/Subscriber.js:66:18)

2 specs, 1 failure

🌍 Your Environment
"@angular-devkit/core": "^9.0.6",
"@angular-devkit/schematics": "^9.0.6",
"@types/jasmine": "^3.3.9",
"@types/node": "^8.0.31",
"jasmine": "^3.3.1",
"typescript": "~3.5.3"

Hi, I think the problem here is that the destination folder (libs) doesn't exist.

@alan-agius4 If you check the linked repo, running the schematic fully succeeds. The problem is in the missing context when using callRule. It's not clear what that missing context should be in the case of a unit test.

Having hit the same issue with a rule I'm working on and from digging in, it looks like it is due to the fact that the callRule method in the test runner doesn't create a real Schematic, but just passes in an empty object:
https://github.com/angular/angular-cli/blob/37a06a7c37f5b4286d58b475e6e12c86f00fac5b/packages/angular_devkit/schematics/testing/schematic-test-runner.ts#L113
Eventually that empty schematic wends its way here:
https://github.com/angular/angular-cli/blob/37a06a7c37f5b4286d58b475e6e12c86f00fac5b/packages/angular_devkit/schematics/src/engine/engine.ts#L254-L265
Finally, when the file system engine tries to get the path from the schematic, it blows up, as description is not defined:
https://github.com/angular/angular-cli/blob/c1512e42742c17ace82e783e8e9c919ae925d269/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts#L288
I think the callRule method would need to provide a way to override or extend that empty schematic object to make this work.


.Net 4.5.1

Upgrade to .net 4.5.1?
http://msdn.microsoft.com/en-us/library/hh925568(v=vs.110).aspx

All projects were upgraded to .NET 4.5.1


📖 Improve getting started guide and tilt dev guide

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #80
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squash commits
[ ] include documentation

TODO: There should be some information about tearing down the workload cluster


Speed Up people_controller#index and fix spec suite

Addresses #111
I used SqlLite EXPLAIN to determine that a few tables included by
with_associations and found a few missing indexes on news_people and
events_people join tables.
There doesn't seem to be a CI server set up (like Travis), so running
the tests locally included upgrading a few gems, upgrading the Ruby
version and changing some specs.

@yez thanks for the contribution! This looks great, and I'm excited to have tests working again.
Upgrading the version of Devise and Rails is causing some problems. Is that something you'd like to look into and fix?

Actually, it was a simple enough fix for that issue, but I found a few more once that was resolved.
The date picker for Event start and stop times and the Tags field is completely gone.

The date picker for Event start and stop times and the Tags field is completely gone.

@kentonh I'm afraid I have no idea why this might be happening. My changes were limited to a migration and some spec fixes. It might have something to do with the upgrades but without real data I'm not sure how I'd diagnose that. Do you have a staging server you can put this branch up on or something to help debug?

@yez Yeah, I can push it up to a new instance and share it with you there. Probs will be tomorrow, however.
I think it's the Rails upgrade to 2.4.0 that causes errors with the acts_as_taggable and however the jQuery date picker.


3.2.0 Breaking Change: Drag Callbacks

It appears there was an inadvertent breaking change in 3.2.0 relating to https://github.com/mzabriskie/react-draggable/pull/361.
Prior to 3.2.0, if a defaultPosition were present, it became the x and y present in the callback on the initial drag and subsequent to that.
In 3.2.0, the x and y received in the callback is relative to the defaultPosition already passed. So if you pass a defaultPosition of x: 100, y:100and initiateonDragStart, the callback will contain {x: 0, y: 0}in the data. This makes sense if you considerdefaultPositionto be something more likeinitialOffset, and is required if your offset is something like, for example, {x: '10%', y: '10%'}.
Ref: https://github.com/bokuweb/react-rnd/issues/437 and a broken build at https://circleci.com/gh/bokuweb/react-rnd/1340.
Next Steps
Our choices:

Is there a way to keep the old "absolute" offsets in callbacks from <= 3.1.1?

Percentage offsets will make this very difficult

Release a major version instead?
Drop the feature? A percentage-based default position can also be achieved by wrapping the <Draggable> in a div with a transform: translate(10%, 10%).

Ping @tnrich.
I've pulled 3.2.0 from npm and will be releasing a 3.2.1 with just the TS export fix.

A couple ideas @STRML to "keep the old "absolute" offsets in callbacks from <= 3.1.1?":

It seems like we could check to see if a percentage is being passed and only then do something more like an initial offset (this might be the most seamless as it would already work with existing packages)

could we introduce a new param, defaultPercentagePosition (or initialPosition). This would allow us to keep the current defaultPosition functionality the way it is. Only if you added a new property initialPosition would you get what the new functionality

If neither of the above ideas seem like viable solutions, then I think a major version would be most useful to my needs.

I think a new param works, perhaps positionOffset - makes it clear that you're not pre-setting the state to something like {x: 100, y: 100}, you're offsetting the whole thing by some number or percentage and it doesn't actually affect the internal state and doesn't show up in callbacks.

@strml I think that is a great plan! Do you need help implementing it?

Yeah, that would be great if you have the time!

I've PR'd a first pass at doing this: https://github.com/mzabriskie/react-draggable/pull/393

I think this can now be closed @STRML ?


Add dotnet-template tag to repo

I have created a "dotnet-template" tag in github, can you add the tag to this repository so it shows up in the dotnet-template search result?

Sure, there you go!


Fix CI on Node.js v23.0.0

Errored at: https://github.com/mryhryki/simple-encryption/actions/runs/11399943778/job/31719820940#step:6:31
Related Issue: https://github.com/nodejs/node/issues/55410

Fixed PR: https://github.com/nodejs/node/pull/55414

v23.1.0 released 🎉
https://github.com/nodejs/node/releases/tag/v23.1.0

I have confirmed that the tests have passed, so I will close this issue.
https://github.com/mryhryki/simple-encryption/actions/runs/11526495559


Adds getColor

This PR proposes the addition of a color getter into the Highlighter class.

Sorry for late reply, but why you need that?

I can't remember. 😅


Can't create symlink

I'm following an example about creating symlink and got this error.
[khoi@ansible-01 tmp]$ ansible multi -m file -a "dest=/src/test mode=644 state=directory"
[DEPRECATION WARNING]: DEFAULT_SUDO_EXE option, In favor of Ansible Become, which is a generic framework. See become_exe. , use become instead. This feature will be
removed in version 2.8. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: DEFAULT_ASK_SUDO_PASS option, In favor of Ansible Become, which is a generic framework. See become_ask_pass. , use become instead. This feature
will be removed in version 2.8. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
SUDO password:
ansible-02 | FAILED! => {
"changed": false,
"msg": "There was an issue creating /src as requested: [Errno 13] Permission denied: '/src'",
"path": "/src/test",
"state": "absent"
}
ansible-03 | FAILED! => {
"changed": false,
"msg": "There was an issue creating /src as requested: [Errno 13] Permission denied: '/src'",
"path": "/src/test",
"state": "absent"
}
localhost | FAILED! => {
"changed": false,
"msg": "There was an issue creating /src as requested: [Errno 13] Permission denied: '/src'",
"path": "/src/test",
"state": "absent"
}

The error that Ansible is reporting:
There was an issue creating /src as requested: [Errno 13] Permission denied: '/src'

is a generic one regarding the permissions your user has on that system.  In short, the Ansible playbook is attempting to make the /src directory, but your user lacks the permissions to create that in the root directory.
The version of the file I have shows this example:
ansible multi -m file -a "dest=/tmp/test mode=644 state=directory"

In most Unix systems the /tmp directory exists and lets all users create files and directories there.  Assuming the /tmp/test directory doesn't already exist, this example should work for you.

Thank you.


Fix theme bug: Can't inflate MaterialCardView

Even when I build the layouts and implement the adapter. I still can't run the app without these fixings.
This is my first pull request so if any improvements are needed, please tell me.

Other fixes of the problem:

Change parent theme to AppCompat.
Or use a bridge variant.

But both these change look and feel of the UI.
@OwenScott-GDS check it out.


QTs: add solution for SJ and CA test creation

As an admin I want to specify the correct solution for my question so responses can be automatically graded.

This will make changes to the test builder and review pages on the admin QT creation process.
For Critical Analysis:

A required drop down within the QualifyingTestQuestion component allowing selection of one of the supplied options as the correct answer
Require at least one option per question

For Situational Judgement:

Two required drop downs allowing selection of one option as "most appropriate" and another as "least appropriate"
Require at least two options per question

On the review pages we need to highlight the answer supplied.
This will be stored in the data model thus:
{
  "type": "situational-judgement",
  "details": "I am the first question"
  "options: [
     0: "I am the first option",
     1: "I am the second option",
     2: "I am the third option",
     3: "I am the fourth option",
   ],
  "solution": {
    "mostAppropriate": 0,
    "leastAppropriate": 2,
  }
 }

{
  "type": "critical-analysis",
  "details": "I am the first question"
  "options: [
     0: "I am the first option",
     1: "I am the second option",
     2: "I am the third option",
     3: "I am the fourth option",
   ],
  "solution": {
    "correct": 0,
  }
 }

Can just do solution: 0 for critical analysis.

I wondered, but I thought keeping the structure consistent might be better in case we want to make changes later? (ie. variable value scoring or something)


Inverse Laplace ∇⁻²! via kernel in ∇²!

fixes #141

Don't worry, I'll resolve that, just don't merge it yet. Enjoy your vacation 🌴

Also @maximilian-gelbrecht, a little change I made in ∇²! and ∇⁻²! is that previously it excluded the the last row = highest degree l. This is because scalar quantities have lmax==mmax, but vector quantities use one more degree due to the recursion in the meridional gradient. I changed this to include all degrees and orders, to have a generally valid (inverse) Laplace operator (the higest degree l otherwise wouldn't be touched, and values may carry over which I don't like). I believe this does not have any unforeseen consequences but in case it does, let me know.

Great, thanks @milankl


Separate out traits for Err and Ok result cases

The error-chain crate does not implement PartialEq for its Error
struct, so it is impossible to use the old ContainingResultAssertions
because of its where clauses.
In general, though, we shouldn't need PartialEq on the result variants
that we aren't comparing against.
This is, unfortunately, a breaking change, since if people weren't using
the use prelude::* idiom their trait imports will need to change.

I completely agree with the idea with the change (as you've mentioned, you shouldn't need PartialEq on something you aren't comparing) -- but rather than splitting the trait, can we achieve the same goal by placing the bounds on the methods themselves and dropping it from the trait?
That'll make it backwards compatible, and also means that it's one less trait to remember if someone doesn't want to import everything via the prelude.

Oooh, I'll try that.

Awesome, thanks for updating this, and for the pull request as well. I've just merged it in.
I want to see if I can complete issue #6 and then I'll most likely release a new minor version.


Page refresh and nav bar

Nav bar options display briefly / disappear in an interesting manner on page refresh

Happens whether or not I'm currently logged in


Fixes

This should fix some of the issues: #99 and #98

I haven't tested this code yet.
@cribeiro84, can you please test it somehow?

I haven't tested this code yet.
@cribeiro84, can you please test it somehow?

For sure, I will checkout the code and test it locally to ensure it's working fine. It seems to be everything fine.

For sure, I will checkout the code and test it locally to ensure it's working fine. It seems to be everything fine.

Hope everything is fine. Looking forward to fetch the updated version. Thank you.


Testing uptodate with registry image config check

we mostly need to ensure that there are labels, and that the container output includes the registry since we have provided the argument. It might also be needed to add quotes around the labels. Right now there is debugging info with the branch, and hopefully I'll update this to be prettier at some point!
Signed-off-by: vsoch<EMAIL_ADDRESS>

okay! So @davidbeckingsale this branch will be something other than main until I've finished developing the other end of this functionality, which is checking the image config against what is latest. I'm going to merge this so we get this one container build deployed to test, and I'll switch it back to main when the other one is merged.


Acknowledging the status quo and more examples of the benefits.

https://github.com/agency-fund/r-workshop/blob/b1e9982ec1b0227da467989b01477dc96e0734d3/slides/version-control-long.Rmd#L372
I think sometimes this type of presentation misses because organizations feel like they have a good alternative to version control, reversions, parallel work streams, etc.
It almost always makes sense when working on large multi-person software systems but it's not as clear when it comes to one-to-few person analyses.
Maybe worth showing a good example of git blame which visualizes who is responsible for which lines of codes.
Also ensure to highlight the use of commit messages to get a textual history of what happened with the file.

Thanks! I added two screenshots on commit history and the blame view on GitHub. See updated slides here.


Topiary cannot open files when invoked outside of its repository

Describe the bug
I tried to run topiary on the tezos codebase, and realized that when I tried to invoke topiary outside of its repository directory, it would fail with
Error: Writing error
  Caused by: No such file or directory (os error 2)

To Reproduce
At the root of topiary's repository, run the following:
nicolas@elwood:~/tweag/topiary$ touch ../testfile.ml
nicolas@elwood:~/tweag/topiary$ topiary --input-file ../testfile.ml

nicolas@elwood:~/tweag/topiary$ cd ..
nicolas@elwood:~/tweag$ topiary --input-file testfile.ml
Error: Writing error
  Caused by: No such file or directory (os error 2)

Expected behavior
I would expect topiary's invocation to work regardless of the working directory
Environment

Ubuntu 22.04.1 LTS
main on 2022-12-13 (https://github.com/tweag/topiary/commit/b0267bb3aefdb95fda75a057ca3d4eb73f79c3ac)

Additional context

Rust debug log gives no additional information:

nicolas@elwood:~/tweag$ RUST_LOG=debug topiary --input-file ../testfile.ml
Error: Writing error
  Caused by: No such file or directory (os error 2)

Renaming the test file from testfile.ml to testfile yields an expected behaviour:

nicolas@elwood:~/tweag$ RUST_LOG=debug topiary --input-file testfile
Error: Cannot detect language of file 'testfile'. Try specifying language explicitly.

The problem persists with non-empty input files

A little investigation tells me that the issue is that the path to the query file is languages/ocaml.scm even outside of the topiary folder. Adding a print of the query path in line 90 of main.rs:
    print!("Query path is {query_path:?}\n");
    let mut query = BufReader::new(File::open(query_path)?);

always displays "languages/ocaml.scm
Remains the question of why this is a writing error and not a reading one.

The query path is hardcoded to be languages/<language>.scm. Rust must interpret this to mean "relative to the CWD", rather than "relative to the binary's directory" -- which makes sense, tbh.
This is not a fix, but a workaround is to set the TOPIARY_LANGUAGE_DIR environment variable.

Remains the question of why this is a writing error and not a reading one.

I suppose this one is too cheeky:
impl From<io::Error> for FormatterError {
    fn from(e: io::Error) -> Self {
        FormatterError::Writing(WritingError::Io(e))
    }
}

For the record, this was the subject of #107 .
Now, there is a bit of discussion to have on what we would like the solution to be like.
Maybe the answer is auto-detected languages or --language map to the installed directory, whereas --query-file (I'm not sure I'm remembering this option's name right) reads in pwd by default?

This is not a fix, but a workaround to unblock you is to set the TOPIARY_LANGUAGE_DIR environment variable.

The workaround works, but it took me a little while to figure out that the variable had to be set at compile time, not at runtime. Thanks!


Forcing this drawer to always display on Top ?

I am using this plugin https://github.com/brentvatne/react-native-scrollable-tab-view . I was happy with both of the plugin only till I find that how scroll-tab work by hiding it self on the left.
So the problem happen when I open drawer I see that my hidden scrolled tab are over the drawer.
Is there any suggestion how I can force this scroll-tab to be under or force the drawer to be always on top ?

can you paste the code in question, specifically the render method that includes both the drawer and the scroll tabs?

Its very much like the example
This is the main View.
return (
  <View>
    <Drawer
        ref="drawer"
        type={this.state.drawerType}
        animation={this.state.animation}
        openDrawerOffset={100}
        closedDrawerOffset={this.state.closedDrawerOffset}
        panOpenMask={this.state.panOpenMask}
        panCloseMask={this.state.panCloseMask}
        relativeDrag={this.state.relativeDrag}
        panStartCompensation={this.state.panStartCompensation}
        openDrawerThreshold={this.state.openDrawerThreshold}
        content={controlPanel}
        styles={drawerStyles}
        disabled={this.state.disabled}
        tweenHandler={this.tweenHandler}
        tweenDuration={this.state.tweenDuration}
        tweenEasing={this.state.tweenEasing}
        acceptDoubleTap={this.state.acceptDoubleTap}
        acceptTap={this.state.acceptTap}
        acceptPan={this.state.acceptPan}
        changeVal={this.state.changeVal}
        side={this.state.rightSide ? 'right' : 'left'}
        onOpen={this.onOpen}
        onClose={this.onClose}>

          <View style={styles.topBar}>
              <Text style={styles.topBarMenu} onPress={this.openDrawer}>☰</Text>
              <Text style={styles.topBarTitle}>{title}</Text>
              <Text style={styles.topBarRight}></Text>
          </View>

           <Portfolio />
      </Drawer>
  </View>
);

While Portfolio view is
return (

);

Ok what is happening is the main view is rendered after the drawer view, hence the overlapping issue.
Its a bit of a hack, but the easiest way to fix this would be to set type="overlay" and then put on a custom tween handler something like:
tweenHandler={(ratio) => {
    return {
      main: {
        left: React.NativeModules.UIManager.Dimensions.window.width*ratio
      },
    }
  }}

Let me know if that works. I will have to think a bit more about how this could be solved more elegantly.

Thanks man it works, just a small number was required in your code to perfectly work in my case  ratio0.65   (I have right offset , otherwise it was pushing all content to the right off the screen).  Now not sure will it work as expected when encountering different screen size :S

Ok forgot that simulator have for different screen size and as expected , it does coz small issue
Above was for iphone 4 , below is iphone 6 .
May be I should do some checking with screen size and multiply with ratio accordingly.

@cjmling is your openDrawerOffset an integer? Try setting the openDrawerOffset=.35 which will treat it as a ratio. This I suspect will give you consistent behaivor across screen sizes.


Passing App Name using .env file

New Issue Checklist

[x] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I am trying to upload multilple apps from single code base using targets. I am using .env files to upload different builds. This is my sample .env file
SCHEME_NAME=scheme1 BUNDLE_IDENTIFIER=target1 APP_NAME=“FirstTarget”
I am able to upload build correctly but name is displayed as ENV['APP_NAME']. Following is my deliver file
app_identifier ENV[‘BUNDLE_IDENTIFIER’] username "*****" name ENV[‘APP_NAME’]
Am i doing something wrong? Do we need to add name to someother file as well?

You can't use env variables for this, you have to create some arrays or other form of structure in the Fastfile and use deliver in a loop, something like this:
$apps = {
	app1: { scheme: 'scheme1' },
	app2: { scheme: 'scheme2' },
	app3: { scheme: 'scheme3' }
}

platform :ios do
	lane :deploy do
		$apps.each do |app|
			scheme = $apps[app][:scheme]

			gym(scheme: scheme)
			deliver()
		end
	end
end

Should you close the ticket, we shall still be able to view the ticket and
its details, am I correct?
Thanks!
On Wed, Mar 14, 2018 at 1:34 PM, fastlane bot<EMAIL_ADDRESS>wrote:

There hasn't been any activity on this issue recently. Due to the high
number of incoming GitHub notifications, we have to clean some of the old
issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest fastlane version and check if
that solves the issue. Let us know if that works for you by adding a
comment 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/10933#issuecomment-373109530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADu6puxHOM8IsD6MchbyPMRE9dzg8kOAks5teVS8gaJpZM4Qh9u-
.

--
With Regards,
Ronak

I was hoping that @bharathreddy-97 would confirm it, but yes, I can close it and if sometimes comes up, anyone can add a reply or open another issue 👍


style: Improve label selection

Summary

When clicking out from the dropdown, pencil icon will not have a outline, instead, we change its color when focused
when mouse over a label, we should show a tooltip with the description (if available)
Entire Labels div is clickable to open dropdown

Closes: https://github.com/snapshot-labs/sx-monorepo/issues/873
How to test

Go to a proposal creation page
try above fixes

Long description is overflowing the tooltip, and forcing an horizontal scroll on the page

See this proposal http://localhost:8080/#/s:test.wa0x6e.eth/proposal/0x186a822de1c93255b2cb88fb2979951936b06b67237ef45ddcaced08873a68de


Create a realistic example of "acme" vendor with "blog" service.

We need a more real world example of messages that will cover all field types and rules.  It will make it easier to follow how the schemas should be used/designed.

that current compiler is throwing an exception on the "article" entity when I add a "tags" field:
<field name="tags" type="string" rule="a-set" />, message Fatal error: Uncaught exception 'InvalidArgumentException' with message 'Field [tags] with type [string] cannot be used in a set.' in /Users/greg/www/gdbots/pbjc-php/src/Field.php:182

Note: string type doesn't support ASet (allowedInSet() is true) - this was taken from gdbots/pbj-php repo (line 174)

string type definitely supports it.  line 174 in what file?
we're using strings in sets in many places currently.

Ya, I fixed that. see my last commit.


Commits have wrong author

I have committed two times today, and both times my commit was created using a different author.
How is this possible?
https://github.com/LivelyKernel/active-expressions/commit/eb8613e25488e642014bcfdc9ad558d5c2235339
https://github.com/LivelyKernel/lively4-core/commit/d4342c196d5a4ff62ce5ff2a75257e6ccd09fcdf
An automatic sync after one of the commits was then created under my name:
https://github.com/LivelyKernel/active-expressions/commit/0807545d42b22ffa1d4b5bef4e1d41052894365c

Wrong repository


Return readable error back to client

Currently if theres an error its returning [Object object] back to the client, this would return stingified error. e.g
[{"message":"Schema must be an instance of GraphQLSchema. Also ensure that there are not multiple versions of GraphQL installed in your node_modules directory."}]
I'm sure where else utilises this error though 👎

@Urigo

@farzd Preferably the error is also formatted properly. JSON.stringify(error, null, 2) would multi-line the text according to GraphiQL's default presentation.
Any feedback to getting this merged?

@julienvincent yeah cool, don't mind updating it but not sure if anyones maintaining this?

Agreed it does seem a bit stale. But it is on the Apollo org so someone will probably get around to looking at this PR eventually.
Assuming it does get merged, it might be nice to namespace the errors to follow the GraphQL response convention:
JSON.stringify({
  errors: error
}, null, 2)

Then again, subscriptions don't return events in a data namespace so perhaps that isn't necessary


Updating charts & application version

I had to change the repository to quay.io/oauth2-proxy/oauth2-proxy to make it work. Maybe we can change that as well in this PR?

Looks good to me.
Although I think we need some discussion as to whether we point the container image at :latest or we publish a new version of the chart with every release to keep updated with the released version.
@JoelSpeed do you have any preference?

I think we should use versioned images, otherwise if we ever make breaking changes this will break users who are running the existing releases.
In general, it's not advised to use moving tags in deployments in production so yeah, versioned tags would be my vote

I think the image repository (https://github.com/oauth2-proxy/manifests/pull/18/files#diff-d544394dd398e3408293c2dc14fe88bd77396bb56175e2c24798aa62f219125aR32) needs to be quay.io/oauth2-proxy/oauth2-proxy instead of quay.io/oauth2-proxy/oauth2_proxy.
➜ podman pull quay.io/oauth2-proxy/oauth2_proxy
Trying to pull quay.io/oauth2-proxy/oauth2_proxy:latest...
  unauthorized: access to the requested resource is not authorized
Error: Error initializing source docker://quay.io/oauth2-proxy/oauth2_proxy:latest: Error reading manifest latest in quay.io/oauth2-proxy/oauth2_proxy: unauthorized: access to the requested resource is not authorized

➜ podman pull quay.io/oauth2-proxy/oauth2-proxy
Trying to pull quay.io/oauth2-proxy/oauth2-proxy:latest...
Getting image source signatures
Copying blob 4c0d98bf9879 skipped: already exists
Copying blob 96c61c2c0d21 [==================================>---] 9.8MiB / 10.6MiB

Actually there's been a new version today: v7.1.0

I think the image repository (#18 (files)) needs to be quay.io/oauth2-proxy/oauth2-proxy instead of quay.io/oauth2-proxy/oauth2_proxy.

I confirm.

@pollier could you please take a look?

@pollier could you please rebase?

Would be great it chart used latest - thanks guys was just about to fork and do my own PR for this.

@morganchristiansson Pinning the version to a specific tag by default makes the chart more predictable and therefore testable.
If you prefer running latest you can set .image.tag in your values.yaml as you see fit.

Of course - I meant to pin to latest versioned tag.. Maybe I should submit new PR for this as @pollier hasn't responded

@pollier a rebase is needed again. 😭

@erkannt @desaintmartin is there any way to move forward this PR?

I can raise a new PR?

LGTM

Build failed
==> Logs of container oauth2-proxy-wlm5zkorjm-9fcf68786-xwp6p
------------------------------------------------------------------------------------------------------------------------
[2021/05/13 09:47:14] [main.go:54] invalid configuration:
  cookie_secret must be 16, 24, or 32 bytes to create an AES cipher, but is 10 bytes
------------------------------------------------------------------------------------------------------------------------
<== Logs of container oauth2-proxy-wlm5zkorjm-9fcf68786-xwp6p

Closing and re-creating so that I can use my fork.


 QAQ

Required Info

Camera Model
L515

Firmware Version
<IP_ADDRESS>

Operating System & Version
{Win (10)

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.50.0

Language
Python

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Hello, I'm currently developing a function to obtain the depth values of keypoints using the L515 and OpenPose. I've noticed that although the coordinates are correct, my program often gives me depth values of 0, and these frequent 0 values prevent me from proceeding with the next steps.
I’ve carefully reviewed the part of the code where OpenPose captures the keypoints, and it seems correct. However, the L515 frequently returns a depth value of 0.
I would like to ask for advice: Is there something wrong with my code or L515?
Here is the output
PersonID 0: Depth value at coordinates (x=291, y=253): 0.0000 m
PersonID 0: Depth value at coordinates (x=374, y=231): 0.0000 m
PersonID 0: Depth value at coordinates (x=381, y=231): 0.0000 m
PersonID 0: Depth value at coordinates (x=384, y=236): 0.0000 m
PersonID 0: Depth value at coordinates (x=374, y=236): 0.0000 m
PersonID 0: Depth value at coordinates (x=376, y=243): 3.2178 m
PersonID 0: Depth value at coordinates (x=376, y=243): 0.0000 m
PersonID 0: Depth value at coordinates (x=376, y=241): 3.1893 m
PersonID 0: Depth value at coordinates (x=374, y=238): 0.0000 m
PersonID 0: Depth value at coordinates (x=371, y=236): 0.0000 m
PersonID 0: Depth value at coordinates (x=371, y=233): 0.0000 m
PersonID 0: Depth value at coordinates (x=371, y=231): 0.0000 m
PersonID 0: Depth value at coordinates (x=369, y=231): 0.0000 m
PersonID 0: Depth value at coordinates (x=366, y=231): 0.0000 m
import cv2
import sys
import os
import pyrealsense2 as rs
import numpy as np
import bin.pyopenpose as op

def get_depth_value(depth_frame, x, y, personid):
    if not depth_frame:
        print("No depth frame available")
        return None

    depth_value = depth_frame.get_distance(int(x), int(y))
    print("PersonID {}: Depth value at coordinates (x={}, y={}): {:.4f} m".format(personid ,int(x), int(y), depth_value))
    return depth_value

def main():
    try:
        # Openpose參數
        params = dict()
        params["model_folder"] = "./models/"
        params["net_resolution"] = "256x256"  # 以準確率為代價提升處理速度
        params["model_pose"] = "BODY_25"

        # 初始化OpenPose
        opWrapper = op.WrapperPython()
        opWrapper.configure(params)
        opWrapper.start()

        # 打開相機，連接L515
        cap = cv2.VideoCapture(0,cv2.CAP_DSHOW)
        if not cap.isOpened():
            print("Error: Unable to open camera")
            return

        # 初始化RealSense pipeline
        # 做一次就好
        pipeline = rs.pipeline()
        config = rs.config()
        config.enable_stream(rs.stream.depth)
        # config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30)

        pipeline.start(config)

        # device = profile.get_device()
        # depth_sensor = device.first_depth_sensor()
        # device.hardware_reset()

        while True:
            ret, frame = cap.read()
            if not ret:
                break

            #L515拿深度
            frames = pipeline.wait_for_frames()
            depth_frame = frames.get_depth_frame()

            #openpose開始處理
            datum = op.Datum()
            datum.cvInputData = frame #cvInputData 是 OpenPose 用於接收輸入影像的屬性。
            datums = op.VectorDatum([datum])
            opWrapper.emplaceAndPop(datums)

            keypoints = datum.poseKeypoints #取得姿態估計的結果，即關鍵點資訊。
            if keypoints is not None:
                for person_id, person in enumerate(keypoints):
                    i = 8  #髖關節
                    x, y, confidence = person[i]
                    if confidence > 0.1:
                        #output_point(i, person_id, x, y, frame)
                        get_depth_value(depth_frame, x, y,person_id)

            pose_frame = datum.cvOutputData
            frame = cv2.addWeighted(frame, 0.7, pose_frame, 0.3, 0)
            #顯示
            cv2.imshow("OpenPose Camera", frame)

            if cv2.waitKey(1) & 0xFF == ord('q'):
                break

        #release
        cap.release()
        pipeline.stop()
        cv2.destroyAllWindows()

    except Exception as e:
        print(f"Error: {e}")
        sys.exit(-1)

if __name__ == "__main__":
    main()

Sometimes it can detect the depth value, but most of the time it fails to detect it.

Hi @CCCCCCCT  Would it be possible to provide an RGB color image of the scene that the L515 camera is observing in order to see what elements in the scene could be making it difficult for the camera to read depth information from surfaces?
For example, if the surface that is being analyzed is the color black then it will be seen as an area of empty depth (zeroes) unless a strong light source is cast onto that area, as described at https://github.com/IntelRealSense/librealsense/issues/6757

The results below the image are generated by my code, and it should have captured my coordinates correctly.

Sometimes it detects the coordinates, but sometimes it doesn't."

The RGB color images in the situations where the depth is detected and when it is not detected are very similar, so it does not seem to be a case of the detection being disrupted by elements in the scene.
It also appears that the body's skeleton landmark joints are being detected correctly even on the image where depth is not detected.
I notice that in the image where distance detection is successful you are standing near to the center of the camera view, whilst in the image where distance values are zero you are standing at the far side of the camera view.  Being off to the side could make depth detection more difficult for the camera.  I recommend trying again whilst in the center of the camera view and see if you have consistent success.

Thank you for your help. I'll try again.

Hello, I followed your suggestion and changed that line of code to the one you specified. However, I was already using that line when running my code until I came across some articles and changed it to config_rs.enable_stream(rs.stream.depth). But even after changing it back to what you specified, I'm still encountering the issue where the depth value shows up as 0. Perhaps I can try modifying my code to avoid this problem.

When I use config.enable_stream(rs.stream.depth, 1024, 768, rs.format.z16, 30), I notice that the distance in front of the camera always remains around 4.7 meters, whether I move forward or backward, it stays around 4.6 to 4.7 meters. However, when I move to the left side of the screen, the distance starts to decrease, but when I move to the right side, the distance still remains around 4.6 to 4.7 meters. This is clearly incorrect.

I also noticed that with config.enable_stream(rs.stream.depth, 1024, 768, rs.format.z16, 30) and config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30), at the same position, I can get depth values in some cases, but not in others.
In the bottom right corner of the screen, I can't get depth values with 640x480, but with 1024x768, I can get them, although they are incorrect. However, they are detected.

Although the L515 camera can depth-sense up to 9 meters, it is best suited to use at 4 meters distance and below.
Are you able to test the camera in the RealSense Viewer tool?  If you enable the Stereo Module (the depth stream) and move the mouse cursor over a coordinate on the pointcloud, the distance of that point in meters is displayed at the bottom of the Viewer window.  If depth is measured correctly in the Viewer then that will validate whether or not the depth problem is in your project rather than an issue with the camera.

I tried using the RealSense Viewer tool with the resolution set to 640x480, and it was able to detect the depth. Maybe there is an issue with my code. QAQ

It will be difficult to diagnose the code, given the few number of RealSense OpenPose projects to refer to.
It may be worth focusing on the depth value printing line first.
print("PersonID {}: Depth value at coordinates (x={}, y={}): {:.4f} m".format(personid ,int(x), int(y), depth_value))
What function does the {:.4f} part of the above line perform, please?  Might it be preventing the depth value from updating correctly?
You could also try disabling the code that deals with zeroes to see whether it could be breaking something.

It is a function to output depth values, and it only takes four decimal places.

I discovered a new issue: I found that the coordinates from the images detected by OpenPose do not align with those detected by the L515. So, I want to try aligning them before performing detection.
Additionally, I found that there is an error when I try to specify the size of my color_frame.
config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30)
"Error: frame didn't arrive within 5000"

I found out that the issue was indeed because my depth image and RGB image were not properly aligned. I've successfully resolved it. Thank you! ╰(°▽°)╯
import cv2
import sys
import os
import pyrealsense2 as rs
import numpy as np
import bin.pyopenpose as op

def get_depth_value(depth_image, x, y,person_id):
    #座標在圖像裡面
    if x < 0 or y < 0 or x >= depth_image.shape[1] or y >= depth_image.shape[0]:
        print("Coordinates out of bounds")
        return None

    depth_value = depth_image[y, x]

    if depth_value == 0:
        print(f"Person_id:{person_id},Depth value at coordinates (x={x}, y={y}): 0 m (no depth information)")
    else:
        depth_in_meters = depth_value * 0.00025  #轉成公尺
        print(f"Person_id:{person_id},Depth value at coordinates (x={x}, y={y}): {depth_in_meters:.4f} m")

    return depth_value

def main():
    try:

        # 初始化RealSense pipeline
        pipeline = rs.pipeline()
        config = rs.config()
        config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 30)
        config.enable_stream(rs.stream.color, 640, 480, rs.format.bgr8, 30)

        align_to = rs.stream.color
        align = rs.align(align_to)

        pipeline.start(config)
        #datum = op.Datum()

        # 初始化OpenPose
        params = dict()
        params["model_folder"] = "./models/"
        params["net_resolution"] = "256x256"
        params["model_pose"] = "BODY_25"

        opWrapper = op.WrapperPython()
        opWrapper.configure(params)
        opWrapper.start()

        while True:

            # L515拿深度
            frames = pipeline.wait_for_frames()

            aligned_frames = align.process(frames)

            aligned_depth_frame = aligned_frames.get_depth_frame()
            aligned_color_frame = aligned_frames.get_color_frame()

            if not aligned_depth_frame or not aligned_color_frame:
                continue

            color_image = np.asanyarray(aligned_color_frame.get_data())
            depth_image = np.asanyarray(aligned_depth_frame.get_data())

            #depth_image = cv2.applyColorMap(cv2.convertScaleAbs(depth_image,alpha=0.03),cv2.COLORMAP_JET)

            datum = op.Datum()
            datum.cvInputData = color_image
            datums = op.VectorDatum([datum])
            opWrapper.emplaceAndPop(datums)

            keypoints = datum.poseKeypoints

            if keypoints is not None:
                #for person in keypoints:
                for person_id, person in enumerate(keypoints):
                    #i = 0
                    nose_x, nose_y = int(person[8][0]), int(person[8][1])
                    #x,y,confidence = person[i][0]
                    #print("x:",nose_x,",y:",nose_y)
                    get_depth_value(depth_image, nose_x, nose_y,person_id)

            #blend_image = cv2.addWeighted(color_image,0.7,depth_image,0.5,0)

            #images = np.hstack((color_image,depth_image))

            pose_frame = datum.cvOutputData
            frame = cv2.addWeighted(color_image, 0.7, pose_frame, 0.3, 0)

            cv2.imshow('window',frame)
            if cv2.waitKey(1) & 0xFF == ord('q'):
                break

            cv2.waitKey(1)

        # Release resources

    finally:
        pipeline.stop()

if __name__ == "__main__":
    main()

It's great to hear that you succeeded.  Thanks very much for the update and for sharing your solution!

Hello, I would like to test longer distances now. I want to ask, why can't it capture the far end of the wall even though the distance isn't very far?

The RealSense Viewer has a post-processing filter called Threshold Filter enabled by default that limits the depth image to 4 meters.  If you go to 'Stereo Module > Post' Processing, expand open the list of filters and click on the blue icon (On) beside Threshold Filter to turn the icon to black (Off) then the camera will be able to display depth to its full distance range.

As you have light entering the room through the windows, please try changing the Preset at the top of the Viewer side-panel from 'Max Range' to 'Low Ambient Light' to see if it makes a difference.

I would like to ask if it's possible to use Python to enable this mode?

To set the preset in your Python project, you could try the L515 script provided at https://github.com/IntelRealSense/librealsense/issues/8619 which sets the built-in preset to the Low Ambient Light preset.
depth_sensor.set_option(rs.option.visual_preset, 3) # 5 is short range, 3 is low ambient light

Thank you very much for your assistance. I will try again.

Hi @CCCCCCCT  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


IronSendMotion broken on Mac OS X

When using iron.nvim on a Mac OS X system, I have a similar problem as described here: https://github.com/Vigemus/iron.nvim/pull/85#issuecomment-412952997
I tried both using the Python-based
autocmd Filetype python nmap <buffer> \l <Plug>(iron-send-motion)
as well as the lua-based
autocmd Filetype python nmap <buffer> \l :lua require("iron").core.send_motion("line")<CR>
way of sending code to my Python REPL. In both cases, it sends incomplete text to the REPL. Using the exact same mappings on a Linux machine works fine.
Later in the same thread, it was stated that the escape characters might be the issue and it should be fixed (https://github.com/Vigemus/iron.nvim/pull/85#issuecomment-416865046). I am testing the newest commit and still have the same issues.
Is there any update on this?

It's really difficult for me to test this on OS X as I only have a linux laptop.
Is it still happening? Maybe it was a neovim->terminal issue.
Nonetheless, I'm really sorry for not following-up in for such a long time.
Lately it's been really hard for me to keep up w/ my open source projects, so I'm taking a look at everything whenever I can.

Hi @hkupty,
I am sorry, I took me a while to come back to you. The good news is that it now works when I either use require("iron").core.send_line() to send a line or require("iron").core.visual_send() to send the current selected text over. require("iron").core.send_motion("visual") doesn't work though, but send the whole file to the REPL.
However, after spending some time digging through the lua code of iron.nvim, I think I can get work for me. I think the project would benefit from some additional documentation, e.g. a small tutorial with some explanations, that is available outside of NeoVim directly on the GitHub page, too.
I know it takes a lot of time and effort to keep these side projects running, so your effort is highly appreciated! Thank you very much.


PHP Warning because missing parameter 'timestamp'

Symfony Flex sometimes call http://flex.server/p/foo,bar,i4.0.0, that is, omitting the timestamp part, then a warning is dispatched because the array index 3 not exists for $timestamp variable assign.
https://github.com/moay/symfony-flex-server/blob/5dc19cea8215a56ad1fc0ef73ddaf38427cc0dd1/src/Service/Provider/PackagesProvider.php#L150

Thanks. :+1:


Fix go version in README

1.3? :rofl: Surely not.

No this was actually Go 1.3. It's a bit dated 😬
I hope to do another round soon.


Got warning for toRefs(attrs)

Version
3.0.0-rc.4
Reproduction link
https://jsbin.com/binitemowo/edit?html,output
Steps to reproduce
Call toRefs(attrs)
What is expected?
No warning
What is actually happening?
Got warning:
toRefs() expects a reactive object but received a plain one.

https://v3.vuejs.org/guide/composition-api-setup.html#context
says attributes & slots are reactive properties,
but isReactive(attrs) & isReactive(slots) are false

The WIP docs is wrong and needs to be updated. attrs and slots are not reactive.

See https://github.com/vuejs/docs-next/commit/1aa17921ddcf5cfb57fbeca73bfceb8fcdd61f70


H2 test with traffic -replay

This patch :

Uses traffic replay as h2 client for sending multiple requests
removes unnecessary imports
fixes config to make it usable with autest

[approve ci autest]

[approve ci autest]

[approve ci autest]


Add Custom Vision in Fairfax Virginia region

@joyhui : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hello @jglixon - Would you review the proposed updates and indicate whether the PR can be merged? Thanks!

#sign-off

@jglixon, @jglixon, this added link...
https://virginia.api.cognitive.microsoft.us/customvision/v3.0/
Returns the following is that correct or is the link broken?
{"error":{"code":"404","message": "Resource not found"}}
The other "endpont URL" instances in the article also return this error.

@joyhui @jglixon - can you sign off again after you've resolved the broken link issue that @jborsecnik mentioned in https://github.com/MicrosoftDocs/azure-docs/pull/37378#issuecomment-566131290 ?
thanks.

@smichelotti @yujhongmicrosoft please provide assistance on the mismatched links - sorry, don't have enough time to work through. Let me know when you need my sign-off

#sign-off

The "broken" link is an endpoint. I don't think it will resolve as a regular webpage on the internet, so it's not an error. Merging.


Short-hand assignment in Go is missing a dataflow from its "initialiser"

If you have an expression like x := 5, we implicitly convert this into a combination of a variable declaration and assignment expression. However, the dataflow here seems broken.

It seems this issue is more complex than I thought. In fact when looking at this code:
package p

func assign() {
    x := 5

    _ = x
}

We can see two disconnected data-flow graphs. One from the last x to the implicit variable declaration (which is created as part of the short assignment):
flowchart TD
620149273["x
(Reference)
short_assign.go(6:6-6:7)"]-->|"DFG (full)"|-210215270["_
(Reference)
short_assign.go(6:2-6:3)"]
647995815["x
(VariableDeclaration)
short_assign.go(4:2-4:3)"]-->|"DFG (full)"|620149273["x
(Reference)
short_assign.go(6:6-6:7)"]

and one from the literal to the reference of the short assignment.
flowchart TD
-482861964["
(Literal)
short_assign.go(4:7-4:8)"]-->|"DFG (full)"|479231344["x
(Reference)
short_assign.go(4:2-4:3)"]

Both of these flows should somehow be connected.


Scrape faster large amount of content with Puppeteer

Hello,
I'd like to know how to scrape data faster, I run a similar code in an async function and use a for loop to go through an array of over 10000 links with similar content to scrape but it takes ages even if I've disabled css, font and images load ... Is there a way to run multiple pages at once and if so can I get a snippet.
const browser = await puppeteer.launch()
    const page = await browser.newPage()
    await page.setRequestInterception(true)
    await page.goto('https://mypage.com')
    await page.evaluate(() =>{
...
})

Thanks a lot !

You can open multiple pages per browser, and you can disable JavaScript! That might make it faster for you

@ntzm Thanks ! Is there a way to loop through all the existing pages and divide the links to visit between them ?

Questions like this are more appropriate on SO or the Slack channel.

I'm wondering the same time. I want to hit maybe 5 pages simultaneously.

const pMap = require('p-map');

async function getParallelAnalysis(sites) {
    const results = pMap(sites, getAnalysis, {concurrency: 5});

    return results;
}

I still have problems in headless mode where it doesn't finish. Basically the process just hangs. If I turn off headless mode it works fine, just slower.


Added hover effects on issues to grab section cards

As I have generate an Issue

Done

Generated another one