[top-test] Test plan updates

Move some test points to V3 based to reflect prioritization discussions.
Update test target references to reflect a couple of test renames.

And CI did its job hehe:
* `xmsim: *E,ASRTST (/azp/agent/_work/*/s/scratch/HEAD/chip_earlgrey_asic-sim-xcelium/default/src/lowrisc_ip_rv_core_ibex_*/rtl/rv_core_ibex.sv,990): Assertion FpvSecCmIbexLoadRespIntgErrCheck_A has failed (* cycles, starting * PS)` has 1 failures:
    * Test chip_sw_sram_ctrl_scrambled_access has 1 failures.
        * 0.chip_sw_sram_ctrl_scrambled_access.1\
          Line 966, in log /azp/agent/_work/1/s/scratch/HEAD/chip_earlgrey_asic-sim-xcelium/0.chip_sw_sram_ctrl_scrambled_access/latest/run.log

                xmsim: *E,ASRTST (/azp/agent/_work/1/s/scratch/HEAD/chip_earlgrey_asic-sim-xcelium/default/src/lowrisc_ip_rv_core_ibex_0.1/rtl/rv_core_ibex.sv,990): (time<PHONE_NUMBER> PS) Assertion tb.dut.top_earlgrey.u_rv_core_ibex.FpvSecCmIbexLoadRespIntgErrCheck_A has failed (8 cycles, starting<PHONE_NUMBER> PS)
                UVM_ERROR @ 2114.178596 us: (rv_core_ibex.sv:990) [ASSERT FAILED] FpvSecCmIbexLoadRespIntgErrCheck_A
                UVM_INFO @ 2114.178596 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
                --- UVM Report catcher Summary ---

You did not change any code here, so it seems like there is some flakiness?
This error seems concerning. It basically means a response intg error deep within the ibex hierarchy should have caused the fatal alert to fire at the rv_core_ibex top level module, but it didn't (somehow got masked). This is worth investigating further.
https://github.com/lowRISC/opentitan/blob/4a1202bd4ac38772c10af742502e22b0428f0d9a/hw/ip/rv_core_ibex/rtl/rv_core_ibex.sv#L989

@sriyerg thanks for taking a look, I will open a triaging issue to track this failure.

This signature actually popped up in the nightlies also today:
Test chip_sw_data_integrity_escalation has 1 failures.

0.chip_sw_data_integrity_escalation.4054969747
Line 503, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_data_integrity_escalation/latest/run.log

      Offending 'alert_tx_o[2].alert_p'
  UVM_ERROR @ 3279.393376 us: (rv_core_ibex.sv:993) [ASSERT FAILED] FpvSecCmIbexInstrIntgErrCheck_A
  UVM_INFO @ 3279.393376 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---
Test chip_sw_otbn_mem_scramble has 3 failures.

0.chip_sw_otbn_mem_scramble.71168331
Line 489, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_otbn_mem_scramble/latest/run.log

      Offending 'alert_tx_o[2].alert_p'
  UVM_ERROR @ 3845.293040 us: (rv_core_ibex.sv:989) [ASSERT FAILED] FpvSecCmIbexLoadRespIntgErrCheck_A
  UVM_INFO @ 3845.293040 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

1.chip_sw_otbn_mem_scramble.575997993
Line 485, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/1.chip_sw_otbn_mem_scramble/latest/run.log

      Offending 'alert_tx_o[2].alert_p'
  UVM_ERROR @ 3499.178950 us: (rv_core_ibex.sv:989) [ASSERT FAILED] FpvSecCmIbexLoadRespIntgErrCheck_A
  UVM_INFO @ 3499.178950 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

This may be due to a recent FPV assertion update by @GregAC.

@sriyerg thanks for taking a look, I will open a triaging issue to track this failure.

I opened an issue https://github.com/lowRISC/opentitan/issues/16416


Harden Promise code against OOM after catching exception

JavascriptExceptionObject::GetThrownObject returns nullptr if it hits OOM.
We previously did not check for this case which caused assert or AV in
retail builds when a JavascriptError object fails to allocate with OOM.
Made our implementation more robust by catching the case wehre we hit an
OOM and pass undefined to the promise reject handler instead of nullptr in
that case. This avoids potential AV or assert but does ignore the OOM.

@abchatra, @ianwjhalliday  Can you take a look at this?

:+1:


This error keeps coming up

I was curious what this means:
[12:06:37] Error placing bid on Sakho
{
  "futApiStatusCode": 500
}
[12:06:37] Something happened when trying to bid on Sakho
[12:06:45] Error placing bid on Sakho
{
  "futApiStatusCode": 500
}
[12:06:45] Something happened when trying to bid on Sakho
[12:06:53] Error placing bid on Sakho
{
  "futApiStatusCode": 500
}
[12:06:53] Something happened when trying to bid on Sakho

https://github.com/hunterjm/fifa-autobuyer/issues/26
Don't forget to check already posted issues before posting one :)

Thanks, sorry I completely forgot :)


Misplaced space(s) around '++' sign and Wrong Tabulation in Makefile

Hello,
When i make nb++ for example, but NormEZ tells me that I have misplaced space(s) around '++' sign, but only there aren't misplaced space(s) around this with this code as for example:
if (test_neg1 == 1) {
my_putchar('-');
nb1++;
nb2++;
}
And in Makefile, there are tabulation, but NormEZ wait for spaces

Indentation check in Makefile fixed in #24

Thanks for the fix! I merged it with the master branch 👍


Various minor nitpicks

Please pull: contains various minor, trivial fixes.

Thanks a lot for your help!


insert fallen out div to end of 3.3

Following the proposal from the ODD-Meeting 11/2024, see https://github.com/music-encoding/music-encoding/pull/1353/files#r1863530669

@bwbohl @musicEnfanthen I hadn't the possibility to test it, but should work. Willing to work on it, if necessary!

@riedde can you change the target branch to develop, please?

Oh, damn. I used the webinterface and didn't care about the target branch. How can I change it without opening a new PR?

@riedde Ah, sorry, this will not work. It now includes all the changes from the former target branch as well :(

@musicEnfanthen So I'll close this and open a new PR

Superseded by #1567


Update text + add tooltip to some components

All the components that were brought in (Heading, TextButton, TextLink, etc.) will be moved to the Stellar Design System. It's easier to polish them here and then move to the design system to publish.

Preview is available here:http://stellar-demo-wallet-pr124.previews.kube001.services.stellar-ops.com/

Preview is available here:http://stellar-demo-wallet-pr124.previews.kube001.services.stellar-ops.com/


#379: Updating language for including date in submission

Closes #379

Removed the file. If that seems like that fixes the issue, I can merge when you give the greenlight. @WrathfulSpatula


New Design

I have been working a lot with the app and have worked on refactoring code and completing a new design. Here is what I have come up with so far.

Looks good, but can we make this themable instead of changing the UI altogether. Personally I prefer current ui

I am just showing what I have done with it. I am not sure if I will release a theme right now as I am making a lot of changes. That being said, I might look into adding an admin settings page to allow theme uploads.

Some more updates.
Departments

Showing the collapsible side menu items

All of the teams and departments can be color coded. The form was modified to look like the following

Nice work, I hope you will release this theme.
By the way, is this project still alive is there kind of roadmap ? Look awesome :)


Ranger didn't jump folder at first under a specific situation.

Ranger didn't jump folder at first under the case below.
folder0
    |--file0.txt
folder1
    |--file1.txt

Enter folder0 and use nvim to open file0.txt.
cd folder0
nvim file0.txt

Open file1.txt directly in nvim.
# In neovim command below:
:e ../folder1/file1.txt

Open ranger, and the folder is folder0 but folder1 is expected.

Reopen ranger, it will jump to folder1.

Can't reproduce it, please use github template.


"Copy Address" button not working

In the notification for Citrine, there is a button that says "Copy Address", which I assume should copy the relay URL to my clipboard. This unfortunately isnt happening: when I click the button, nothing is copied.

Citrine v0.2.7
GrapheneOS

Fixed in https://github.com/greenart7c3/Citrine/commit/e82d0a176df3df2e41866216054256bb282400d1


Error saving to/accessing GitHub tree

The new interface looks great!
Unfortunately, I'm getting an error when the GitHub tree is accessed (see image).  I tried logging out, using an incognito window, revoking access token... but nothing seemed to fix the bug.  Same experience on Firefox and Chrome.
Any idea what's going on?  The error is being thrown here.

I am still getting an error when I try to save a opened file from Github. Though my error looks differrent


[feat] Respect excluded file list

Current functionality is great, but somewhat hindered by my use of a changelog file -- I have this set as an excluded file in Obsidian, but it doesn't appear that list is respected by this plugin. Would it be possible to exclude those files (a plugin that does so is Omnisearch, e.g.)?

interesting idea. can you explain how the changelog file and what do you mean by "hindered"? I am thinking about some of these types of details these days, so good timing with your feedback.

Great to hear! Basically, I have a couple files that get automatically updated, so the block ref counts are inaccurate --

With 1.0.5 it is now possible to mark files in the frontmatter so they won't be included in the Index. Check this out:
https://github.com/TfTHacker/obsidian42-strange-new-worlds#snw-frontmatter-directives
I am still debating about folder exclusion. So I am going to close this out for now, since I will have this in mind for the future.


fix: select widget validation issue

Description
PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/24905
Testing
How Has This Been Tested?

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=00c8220

@Rishabh-Rathod - Merge latest release & trigger new oktotest. Cancelling the re-run since its past 12 hours from initial attempt.

/ok-to-test sha=5b7ab5f

/ok-to-test sha=5b7ab5f


Sui Node seed peers from validators info not working

When I look at to validators on suiscan for example Mysten 1: https://suiscan.xyz/mainnet/validator/0x4fffd0005522be4bc029724c7f0f6ed7093a6bf3a09b90e62f61dc15181e1a3e/info
I can see that address is /dns/mysten-1.mainnet.sui.io/udp/8084 and Network Public Key Bytes is 0Mfg9FEcDkWBRgl8KNgKNG0EZvwbUgXJjGyNPCk3dBE=, when I convert it to bytes and then hex it should be ed54176cb93ed30aeaa48b3741d76c754295b76e55a510c5a338d41e37934002 right?
But when I try to input that configuration my node just fails to sync, am I converting it wrong? Also how would I find mel-00. or ewr-00.?
My test configuration that I filled from validator informations:
p2p-config:
  seed-peers:
    - address: /dns/mysten-2.mainnet.sui.io/udp/8084
      peer-id: 9e4c25566d1a25fbfad56883d7a04177a6e38bef4d7378f75d65b96d50f8296f
    - address: /dns/mysten-1.mainnet.sui.io/udp/8084
      peer-id: d0c7e0f4511c0e458146097c28d80a346d0466fc1b5205c98c6c8d3c29377411
    - address: /dns/bd-sui-main-validator-01.bdnodes.net/udp/8084
      peer-id: 2aead29218c797593036eae814ffd2920540b64a17ea354f1a458080134d52a9
    - address: /dns/sui-mainnet.chorus.one/udp/8084
      peer-id: 28afe60b560f3fadb38158ddcbb451b7f78ee14ac8b1282a0891ad9c1edfa192
    - address: /dns/sui-mainnet.overclock.run/udp/8084
      peer-id: 0fafd9a6ad162e9fc82e3c56b5f71f1510454e8a13e26e86f95fa74ff3601d87
    - address: /dns/validator-01.sui.dsrvlabs.net/udp/8084
      peer-id: cac0e7ae6f85b11c4e261ee071a71be84e98a57df9499a8254f3b0f37341530c
    - address: /dns/sui-mainnet.nodes.lgns.xyz/udp/8084
      peer-id: edc0c0ece84ab3befbd3d4c806d25b44d0f32048426a8e8f031f5012e859a546
    - address: /dns/validator.mainnet.sui.rpcpool.com/udp/8084
      peer-id: 8d7439595d60348d3c3ebb651ae539f2819856f1ba3f15502093f1dda3767822
    - address: /dns/sui-mainnet-figment.staking.production.figment.io/udp/8084
      peer-id: ed54176cb93ed30aeaa48b3741d76c754295b76e55a510c5a338d41e37934002

fullnode-1  | 2024-11-24T19:07:53.250774Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified
fullnode-1  | 2024-11-24T19:07:54.434203Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified
fullnode-1  | 2024-11-24T19:07:55.459241Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified
fullnode-1  | 2024-11-24T19:07:56.983884Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified
fullnode-1  | 2024-11-24T19:07:57.777986Z  WARN sui_core::checkpoints::checkpoint_executor: Received no new synced checkpoints for 5s. Next checkpoint to be scheduled: 83347517
fullnode-1  | 2024-11-24T19:07:58.883054Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified
fullnode-1  | 2024-11-24T19:08:01.805363Z ERROR sui_storage::object_store::util: Failed to read file from object store with error: Failed to get header
fullnode-1  |
fullnode-1  | Caused by:
fullnode-1  |     Missing last modified

Am I doing something wrong?
Also where would I find for example mel-00. or ewr-00. regional subdomains for such nodes?

@Duoquote what docs are you looking at for syncing a fullnode? Take a look at https://docs.sui.io/guides/operator/sui-full-node#setting-up-a-full-node for a list of state sync fullnodes you can use as seed peers.
We discourage peering directly with validators as a large number of fullnodes paired to a validator can impact performance

Sorry if I misinterpreted at first, yes I am currently using the peer configuration you mentioned, I put together that list from what I looked up on suiscan. My fullnode is working but I wanted faster and low latency sync so I thought I could use whatever close to my server, turns out it is not working that way. Now to my understanding on what you said, on validator side they host additional nodes and we use them instead of validator node right? What else can I do to improve latency? Also I don't understand how multiple validators work in this scenario, we all sending requests to the same rpc servers, then who is validating it? Is it distributed across all of them or what?

Now to my understanding on what you said, on validator side they host additional nodes and we use them instead of validator node right?

Yes, the mainnet State Sync Full Nodes (SSFNs) are run by validators. And you connect to the SSFNs instead of directly to the validators to reduce bandwidth constraints on validators.

What else can I do to improve latency?

The improvement offered by pairing directly with a validator is actually quite small (~50ms). The majority of latency has to do with the fact that fullnodes are executing and verifying the checkpoints they receive via state sync. We don't have any existing options for large latency reductions, the general advice is to run with high performance disks and cpu.

Also I don't understand how multiple validators work in this scenario, we all sending requests to the same rpc servers, then who is validating it? Is it distributed across all of them or what?

Sorry, I don't understand what you're asking

Thanks for the response, I think I am going to go with as you suggested high performance server and I come accross with custom indexer solution instead of polling local RPC (turns out JSON serialization/deserialization takes quite time), I think it will work better than polling local RPC? Next question was quite unrelated, no need to discuss how validation happens here. Thanks!

I come across with custom indexer solution instead of polling local RPC (turns out JSON serialization/deserialization takes quite time), I think it will work better than polling local RPC?

I guess it depends what latencies you're concerned about. If you create a custom indexer you could have the response latencies be much lower than json rpc (as you mentioned serialization/deserialization takes time and it's a more expressive data format). but the sync latencies will be slower. The custom indexer needs to read checkpoints from somewhere, by default its from a s3/gcs bucket which adds latency when reading the checkpoints & waiting for them to be written by the upstream.

If you create a custom indexer you could have the response latencies be much lower...

As I can't cut down on network latency that's most I can do I guess.

but the sync latencies will be slower. The custom indexer needs to read checkpoints from somewhere, by default its from a s3/gcs bucket which adds latency when reading the checkpoints & waiting for them to be written by the upstream.

What do you mean, I enabled this setting on my fullnode to read from my local node;
checkpoint-executor-config:
  checkpoint-execution-max-concurrency: 200
  local-execution-timeout-sec: 30
  data-ingestion-dir: /opt/sui/ingest

by default its from a s3/gcs bucket which adds latency when reading the checkpoints & waiting for them to be written by the upstream.

Does that apply for full node as well, do my full node sync from s3/gcs by default too? I thought p2p config was made to sync checkpoints.

No full node does not sync from s3/gcs

Oh, is there a way I can fetch instead of running full node and syncing to disk?
Also I tried this after local reader failing;
use anyhow::Result;
use async_trait::async_trait;
use sui_data_ingestion_core::{setup_single_workflow, Worker};
use sui_types::full_checkpoint_content::CheckpointData;

struct CustomWorker;

#[async_trait]
impl Worker for CustomWorker {
    type Result = ();
    async fn process_checkpoint(&self, checkpoint: &CheckpointData) -> Result<()> {
        // custom processing logic
        // print out the checkpoint number
        println!(
            "Processing checkpoint: {}",
            checkpoint.checkpoint_summary.to_string()
        );
        Ok(())
    }
}

#[tokio::main]
async fn main() -> Result<()> {
    let (executor, term_sender) = setup_single_workflow(
        CustomWorker,
        "https://checkpoints.mainnet.sui.io".to_string(),
        83728623, /* initial checkpoint number */
        5,        /* concurrency */
        None,     /* extra reader options */
    )
    .await?;
    executor.await?;
    Ok(())
}

Which I observed it is behind 2 checkpoints compared to my full node, I tried local reader but it gives me Error: EOF while parsing a value at line 1 column 0 error, not sure why is that. I confirmed that the folder is correct, maybe because my node is not full sync I started it from epoch 590.
Also thank you so much for taking your precious time!

cc @phoenix-o on the custom indexer


⚠ DDoS-Relay EU-C-fsn1-3 has degraded performance

In f0ead03, DDoS-Relay EU-C-fsn1-3 (http://<IP_ADDRESS>:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 188 ms

Resolved: DDoS-Relay EU-C-fsn1-3 performance has improved in 3ea175c after 18 minutes.


Add async function support in initialData prop

What would you like to be added:
When I use other libraries like Formik, I have some trouble about async data, double loading (page loading using dynamic imports and data loading) is not a good approach for UX. Why not use a Promise resolve to get initialData?
Why is this needed:
I think about a simple function inside initialData prop like this:
async function fetchProfileInformation(){
    const res =  await fetch("/somelink");
    return res.data;
}

<Form initialData={fetchProfileInformation} >
    {...}
</Form>

Additional context
In typescript, a simple enhancement in prop verification is:
initialData: {} | () => Promise<{}>

Thank's for the attention.

@SorEduard It would not be a use case with state, as the example below:
export function Component() {
  const [initialData, setInitialData] = useState({});

  async function getInitialData() {
    const res = await api.get("/somelink");
    setInitialData(res.data);
  }

  return (
    <Form initialData={initialData}>
      {/** ... */}
    </Form>
  )
}

@italoiz Yes this approach work's, but cause flash in UI, why not solve data before render the form? I do not know if this is really necessary because there are innumerable methods to get data before route resolve, but in some libraries like apollo-graphql, this give a lot of difficulty to make, using prefetch before history.push, in SSR to. Thanks for reply.

@SorEduard I understand your thoughts but i don't think it's unform responsability wait for data to load, as the user may use many different types of loading like shimmer placeholders (like this) or a loading indicator.
Maybe you should wrap the form with a conditional to render it only when you finish loading the data.
What do you think?

I think @diego3g is saying you could do something like this:
export function Component() {
  const [initialData, setInitialData] = useState(null);

  async function getInitialData() {
    const res = await api.get("/somelink");
    setInitialData(res.data);
  }

  // display loading here...
  // example: {!initialData && <Loading />}

  return (
    {initialData && (
      <Form initialData={initialData}>
        {/** ... */}
      </Form>
    )}
  )
}

@diego3g makes sense, was just a suggestion, the different approaches suggested would solve the issue well, thank you, closing.


Provide Shortcode param Interface at Page Level

So, we have .HasShortcode to tell us, at a page level, if a shortcode is used.  It would be useful to be able to access the shortcodes' params at this point, too, to allow for some finer grain control .

I don't see how. Params are per shortcode used, and you can use the same shortcode multiple times per content file.

true, but if the content has been parsed to find the shortcodes, i would assume that it could have access at that point to each shortcode's param values?  My use case is:
I wand to have multiple canvases one one page (using a {{< canvas >}} shortcode that references the JS script that codes the canvas). All canvases react and style the same way, but each may use different dependencies.
Currently there is no way to indicate at a page level these different dependencies. Of course I could have differently named shortcodes to indicate this -- this wouldn't be very DRY.

true, but if the content has been parsed to find the shortcodes, i would assume that it could have access at that point to each shortcode's param values?

That's true, I guess. But I need to think some about this.


Building mpfr breaks on x64-windows

I'm not sure where to find any other log files if they exist

It is because mpfr 4.0.0 is released. I will do a PR shortly to update and fix your problem.

thank you very much

I got an unresolved external symbol error when building mpfr 4.0.0. According to the website now mpfr depends on a newer version of gmp, but the gmp equivalent on windows mpir is still not updated. I am not sure how to solve this. Maybe @xoviat can help.
@justinjk007 The error message said download failed, hence the first thing I do is go to my browser to check what's going on, then I realized mpfr 4.0.0 is released. For some reason mpfr doesn't keep older versions on their website.

Note: a generic C target is available for MPIR here: https://github.com/chfast/mpir/blob/47910ac631c599774577b155a33fa3a372155c1d/CMakeLists.txt
If this issue is important to you, please down vote this post: https://github.com/wbhart/mpir/pull/215#issuecomment-353179717
It may change minds.

@xoviat Even if they refuse to support cmake, doesn't at least the cmake patch in vcpkg kind of work around the problem? I think we need to try building mpir with vcpkg_from_github (doesn't look trivial to me at the moment) and use the --head flag and see whether it will make mpfr 4.0.0 build. If it builds then we can request for a new release to mpir.

No. The correct way to build MPIR is to use the MSBUILD files in the repository. What's practically possible is to build directly from the fork I linked.

@xoviat I looked more carefully in the mpir portfile and you are right, it's currently build with msbuild, but still it's worth a try to see whether the --head version of mpir actually makes mpfr 4.0.0 to build.
Another thing is for some reason the git release tags on the mpir repo is only up to 2.7.0 instead of 3.0.0, so before we make the transition to vcpkg_fron_github this has to be solved first. I already filed an issue and hopefully they will respond soon.

I will close this as soon as the PRs gets merged and I can install the package


[SUPPORT] Support Apache Spark 3.x

Support Apache Spark 3.x

可以支持

working on it~

completed by @Nicole00 🎉


No logs after switching to GUI (wxWidgets) Windows-only

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
Yes
OS Platform and Distribution
Windows 10
Mobile device if the issue happens on mobile device
No response
Browser and version if the issue happens on browser
No response
Programming Language and version
C++
MediaPipe version
2021-04-10
Bazel version
5.0
Solution
HandLandmark
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
No response
Describe the actual behavior
std::cout & LOG(INFO) display messages on the console
Describe the expected behaviour
std::cout & LOG(INFO) do NOT display messages on the console
Standalone code/steps you may have used to try to get what you need
After we

switched from console to GUI (-SUBSYSTEM:WINDOWS flag in bazel linkopts) with wxWidgets as the backend and
switched to unicode suport

, we no longer see any logs, including our custom std::cout.
The issue is reproduced only on Windows and we do see all logs running the same code on Ubuntu 22/20.
We don't know if it's a

Bazel
wxWidgets
mediapipe
our custom code

issue.
Some important changes to WORKSPACE and BUILD:
new_local_repository(
  name="wx_windows",
  path="third_party/windows/wxwidgets",
  build_file_content = """
cc_library(
    name = "wx",
    visibility = ["//visibility:public"],
    hdrs = ["lib/mswu/wx/setup.h"],
    includes = ["include"],
    srcs = glob([
        "lib/*.lib",
        "bin/*.dll"
    ]),
    defines = [
        "_FILE_OFFSET_BITS=64",
        "__WXMSW__",
        "UNICODE",
        "_UNICODE",
    ],
    linkstatic = 0,
)
"""
)

alias(
    name = "wxwidgets",
    actual = select({
        "//mediapipe:windows": "@wx_windows//:wx",
        "//conditions:default": "@wx_linux//:wx",
    }),
)

cc_library(
    name = ":our_common",
    srcs = ["our_common.cpp"],
    hdrs = ["our_common.h"],
    # need to define unicode in order to be consistent with wxWidgets
    defines = [
        "UNICODE",
        "_UNICODE",
    ],
)

cc_library(
    name = "wx_airtouch",
    srcs = glob([
        "wx_airtouch/*.cpp"
    ]),
    hdrs = glob([
        "wx_airtouch/*.h"
    ]),
    deps = [
        ":wxwidgets",
    ],
    linkopts = select({
        "//mediapipe:windows": [
            "-DEFAULTLIB:user32.lib",
            "-SUBSYSTEM:WINDOWS",
        ],
        "//conditions:default": [
            "-lX11",
            "-lXtst",
            "-lpthread",
        ],
    }),
)

cc_library(
    name = "main",
    ...
    deps = [
	":our_common",
        ":wx_airtouch",
    ],
    linkopts = select({
        "//mediapipe:windows": [
            "-DEFAULTLIB:user32.lib",
            "-SUBSYSTEM:WINDOWS",
            "-DEFAULTLIB:OleAut32.Lib",
            "-DEFAULTLIB:Ole32.lib",
        ],
        "//conditions:default": [
            "-lX11",
            "-lXtst",
            "-lpthread",
        ],
    }),
)

Example
std::cout << "print\n"

does not display the message.

I can spawn a new console with AllocateConsole.


Add support for ReadOnly in TALEdit / TALMemo

Hi
Is possibile Add support for ReadOnly in TALEdit / TALMemo ?
Like Enabled False but not gray....
Thank you.

Hello, TALEdit and TALMemo are simply wrappers for the native OS edit/memo components (like EditText on Android, UITextField on iOS, NSTextField on macOS, and Edit on Windows). The issue is that ReadOnly is not natively supported by all platforms. For example, on Android, you must set the enabled property to false, as there is no ReadOnly property. Personally, I always find it a bit confusing to have an edit control that looks exactly like a regular one but doesn’t allow editing. It feels more intuitive to have the edit field grayed out to indicate that input is disabled.
However, if you want this ReadOnly feature, you can implement it in the master branch and submit a pull request (PR). I'll approve it, but before doing so, consider if setting enabled = false might be a better alternative than introducing ReadOnly = false.


Problems with adding tedious

Hi!
Just installed dependency using yarn add tedious and yarn add @types/tedious , then tried to do simply connection, but looks like it's not possible cause I got following error:
Uncaught ReferenceError: require is not defined
    at Object.events (index.js:140122)
    at __webpack_require__ (index.js:790)
    at fn (index.js:101)
    at Object../node_modules/tedious/lib/bulk-load.js (index.js:99091)
    at __webpack_require__ (index.js:790)
    at fn (index.js:101)
    at Object../node_modules/tedious/lib/tedious.js (index.js:110052)
    at __webpack_require__ (index.js:790)
    at fn (index.js:101)
    at Module../src/app/database/sqlService.ts (index.js:139762)

looks like it comes from module.exports = require("events"); from tedious. There are a lot of answers in google about similar problems, that I should enable nodeIntegration. I don't think so thats it in this case, but anyway I've tried and it didn't work either.
Code:
export const connectToDb = (): Promise<Connection> => {
  return new Promise((resolve, reject) => {
    const config = {
      authentication: {
        options: {
          userName: "sa", // update me
          password: "" // update me
        },
        type: "default"
      },
      server: "test_gt_db@localhost", // update me
      options: {
        database: "test", //update me
        encrypt: true
      }
    }
    const connection = new Connection(config) // it breaks here
  })
}

Hello ulou,

looks like it comes from module.exports = require("events"); from tedious. There are a lot of answers in google about similar problems, that I should enable nodeIntegration. I don't think so thats it in this case, but anyway I've tried and it didn't work either.

Can you try the same process with following WebPreference configuration in main.ts file for Electron Window.
    webPreferences: {
      nodeIntegration: true, // Changed
      enableRemoteModule: false,
      contextIsolation: false, // Changed
      nodeIntegrationInWorker: false,
      nodeIntegrationInSubFrames: false,
      preload: MAIN_WINDOW_PRELOAD_WEBPACK_ENTRY,
    },

Following is the console.log output of Connection when having the configuration updated and using the source code you mentioned above:

Lemme know if you still face the same issue
Cheers!

Hey @codesbiome,
thanks for the answer, I forgot to answer here. Your suggestion is correct, that's exactly how I fixed this.
My question and answer:
https://stackoverflow.com/questions/64706829/electron-tedious-requireevents-is-not-defined

Hello @ulou
Good to know its working fine.
Thanks for confirmation,
Cheers!


Feature Request:  Add ADER template for exposure response data

Feature Idea
Wondering if it would be appropriate to add exposure response data.  These are usually based on ADRS and/or ADTTE endpoints.
Relevant Input
No response
Relevant Output
No response
Reproducible Example/Pseudo Code
No response

Hi @bundfussr can you add me as contributor?  Thanks!

Hi @jeffreyad , would you like to create a vignette and a template for the ADER dataset?
Could you provide more information (specs, workflow, ...) regarding the dataset? I have never seen or implemented it.
I've added you to the repo.

Hi @bundfussr yes, that would be the idea.  Thanks for adding me.  I can add some more information.  Here is a link that has some information:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4625861/

Hi @jeffreyad , what is the status of this issue?
The next release is in January 2025. Do you think ADER could be included or should we move it to the July 2025 release?


Ok, so now I can't see other user's log files at all.  this is going to make debugging hard.

I'm trying to help a user debug their tarball workflow and now I can't:
 jobsub_fetchlog -G minerva<EMAIL_ADDRESS>Traceback (most recent call last):
File "/opt/jobsub_lite/bin/jobsub_fetchlog", line 164, in
main()
File "/opt/jobsub_lite/bin/jobsub_fetchlog", line 111, in main
os.stat(iwd)
PermissionError: [Errno 13] Permission denied: '/nashome/s/sultana/.cache/jobsub_lite/js_2023_02_21_115244_3d07afd4-c43f-435d-b859-8afd376b2623'

This will be fixed when all of the monitoring bits are put in place.  The jobsub_lite portion of it (#255) will be released in 1.1, on Thursday (I'm about to send out an announcement email about it), and the landscape side will be rolled out over the next few days.

Assigning to @retzkek so he can let @hschellman know when to test this access.
Note that the following works in ITB (requires FNAL VPN access):
<EMAIL_ADDRESS>But as Kevin tweaks things, it may not STAY working while he finalizes the rollout plan to production.

Web logs are now fully in production, logs for jobs submitted with v1.1 or later are now available in landscape, e.g. for a recent dune user job<EMAIL_ADDRESS>There's also a token-friendly endpoint, if you hate web browsers and would rather use the command line (while we work on getting jobsub_fetchlog changed to use it):
$ htgettoken -a htvaultprod.fnal.gov -i dune
...
Storing bearer token in /run/user/50216/bt_u50216

$ curl -s -H "Authorization: Bearer $(cat /run/user/50216/bt_u50216)" \
<EMAIL_ADDRESS>| head
Mon Feb 27 17:37:32 UTC 2023<EMAIL_ADDRESS>BEGIN EXECUTION sub_dirFit9.sh 0 PROD21
...


Deprecate const sampling in favour of probability = 0/1

The current const sampling is redundant because probabilistic with param: 0/1 does the same.

From the gitter channel (too bad I can't link the convo :/):
Reasons for keeping const:

probabilistic sampler calls rand(), which is not needed when you do Always/Never
It's more explicit

My usecase was to support const=1 via the sampler strategies, but because it's not supported, I'm settling for probabilistic=1.
Now, point 1 above can be mitigated by adding checks for param == 1/0 and for point 2, if it's being kept, I think it should be supported everywhere. Supporting it only in someplaces causes confusion.

I don't really believe it makes sense to add a check just in order to delete the const sampler. I like the idea of a simple sampler for testing. To quote something I heard recently "splitters can be lumped more easily than lumpers can be split." (Wikipedia). By lumping both strategies into the probabilistic sampler, we make it harder to split if necessary down the line. Keeping them separate always leaves this path open for exploration.


[BUG] Add Repository validations for Clusters which use Remote state for durability

Describe the bug
As a follow-up to https://github.com/opensearch-project/OpenSearch/pull/15471, include validation for nodes which might have only cluster-state set in node attributes.
Related component
Cluster Manager
To Reproduce

Create a cluster with only remote cluster-state enabled
Create a node which has remote-state repository different than the active cluster-manager.

Expected behavior
Node Join should be rejected if repository attributes are different.
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Catch All Triage - 1, 2, 3]


[T3A3][T01-T1]Richard Goh Chang Rui

Ready for review

@richardgohcr

Some functionality can be moved to the parent class constructor.
Some comments added. Please close the PR after reading them.


Allow navigation to the full "Digest" email from an individual MailPiece

As a user, I want to be able to quickly see the full original Digest view that contains a Mail Piece I am looking at.
Acceptance Criteria

User can navigate to the Digest email view containing a particular MailPiece from:

The search results view?
A notification?
The individual mail view?

Document any relevant content in the Programmer guide (draft thoughts of usage and importantly the "Why")
Updates SRS and STP (and other docs if necessary)
Add/Update relevant unit tests

Not enough time


Question: Is there a way to specify the height of the popup items list from ComboBox ?

Hi, thanks for this awesome library! I've been using it for a while.
So I'm using the ComboBox for a font selector, and there are a lot of fonts installed on the system, the popup list seems very long, even longer than the settings page. As the title says, I want to control the height of the popup list.

There currently is no way to do that :/
You may want to use a drop down button, though. It is smaller and doesn't take the entire screen

Still no luck with a drop down button


Winget-AutoUpdate takes a lot of time to check if winget is installed

Two minutes to check this is too much.

I found why this is happening, it's because i've installed powershell from msstore, running install with powershell instead of pwsh makes checking very fast.

https://github.com/PowerShell/PowerShell/issues/17232

ok, nice. Thanks for feedback


rest-client version and Windows

Before rest-client 1.7.0 rest-client is broken on Windows. It creates Tempfile without setting binmode (see https://github.com/rest-client/rest-client/blob/v1.7.0/lib/restclient/request.rb#L456). This breaks anything using rest-client on Windows and expecting unaltered content.

chef 12 removed the rest-client dep entirely.


fix: bump edge-runtime to 1.45.2

What kind of change does this PR introduce?
Update edge-runtime to 1.45.2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 58.196%

Files with Coverage Reduction
New Missed Lines
%

internal/storage/rm/rm.go
2
92.86%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6511

Relevant Lines:
11188

💛  - Coveralls


Don't leave dangling DOM nodes when the type of a keyed element changed

When the type of a keyed element changed:

HTML.reconcile creates a new DOM node
but reconcileChildren still expects that insertBefore of the new DOM node will remove the previous DOM node from the tree

This results into dangling nodes still being in the tree after render.

Sounds plausible, I'll try and find some time to review.

@pdf There is a test in there. The difference between before and after the fix is literally just:
@@ -39,6 +39,4 @@ global.Get("document").Call("createElement", "tag2").Get("classList")
 global.Get("document").Call("createElement", "tag2").Get("dataset")
 global.Get("document").Call("createElement", "tag2").Get("style")
 global.Get("document").Call("createElement", "body").Call("appendChild", jsObject(global.Get("document").Call("createElement", "tag2")))
+global.Get("document").Call("createElement", "tag1").Get("parentNode")
+global.Get("document").Call("createElement", "tag1").Get("parentNode").Call("removeChild", jsObject(global.Get("document").Call("createElement", "tag1")))
 global.Call("requestAnimationFrame", func(float64))

Codecov Report

Merging #203 into master will increase coverage by 5.42%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   52.22%   57.64%   +5.42%
==========================================
  Files           3        3
  Lines         653      654       +1
==========================================
+ Hits          341      377      +36
+ Misses        258      219      -39
- Partials       54       58       +4

Impacted Files
Coverage Δ

dom.go
55.29% <100%> (+5.65%)
:arrow_up:

markup.go
70.96% <0%> (+4.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f625a...e7bba9c. Read the comment docs.

@pdf This is now green if you still want to review.

@damz Apologies for the (very) delayed review. This change LGTM. @pdf do you still want to review this before I merge it?

I'm afraid I've just had no time to look at it for any edge-cases.  If you're happy though, I'm happy @slimsag


Missing documentation for some rule template variables

The documentation page for template reference has some function missing that we provide:

strvalue
~stripPort~ (ignore this, documented but yet to be released)
pathPrefix

They can be found here https://github.com/prometheus/prometheus/blob/fe06f16c116a109330cce0bcb61c2c6728ab7227/template/template.go#L145-L321
We need to add docs for that.

stripPort is documented but not yet released.

This function was added in 2014, I don't have the context. I don't think we should document it.

pathPrefix was also added 7 years ago, maybe don't need to document that as well. I think we can close this issue then, the only remaining function has been documented (hence, pathPrefix and strvalue will also be left out from compliance).

This function was added in 2014, I don't have the context. I don't think we should document it.

It's for string values, this is how the templates handle them. It'll only come up if the expression is a string literal, so it's probably safe to remove in the next major version. At the time I added it I was very new to Prometheus and was covering all my bases.

pathPrefix was also added 7 years ago, maybe don't need to document that as well.

This one is so console templates can know about any reverse proxy setup, so it has real uses.

Then we need to document pathPrefix

I took a look at this and noticed the documentation for console templates already states "The URL path is available in .Path" and $path. So, I wanted to make sure the pathPrefix function is still actually needed.

pathPrefix is used by the example consoles templates included with Prometheus, so probably needs to be kept around as users likely copy&pasted it into their own consoles.

Fixed in #10222


directory for output as last argument

(This is a great little utility BTW, so thanks for it!)
I think it would be nice to be able to do something like
bash literate_run_nbconvert.sh demo/ODEIntroduction.ipynb another_output_folder

to specify another_output_folder 🙂

I would accept a PR to add this feature.
The julia version basically has this
https://github.com/oxinabox/ipynb2LiterateJulia/blob/master/literate_run_nbconvert.jl
Maybe the Julia version should be made callable on the commandline


config/500-controller.yaml Container is running without root user control

This issue is...
Container is running without root user control
The impact of this is...
Container could be running with full administrative privileges
You can resolve it by...
Set securityContext.runAsNonRoot to true

ko defaults to nonroot for the base image, therefore we don't need to explicitly define the default runtime user.

Thank you!

With that being said, it doesn't hurt to add it as an extra protection.

I just ran our repo through Snyk and got these. I thought It would not hurt to bring them up .

I figured someone else looking at the product might do the same.

reopening in favor of "it cant hurt"


Trailing tags idea

I think it'd be nice to have trailing option for tags, so comments could be more syntactically correct.
e.g.
instead of
// ! don't do it
it will be
// don't do it!

// ? question
to
// question?

and in config:
tag: "!",
trailing: true,

Looks good.

But is it necessary?

will cause additional reg matching loop.
can only use in the line mode of line comment
will be strange to write together with other tags, like:

// # some title
// the question?
// * bold comment
// TODO: this is the block comment in line mode
//       no.2 line
//       no.3 line

it will cause additional reg matching loop.
Could you point me to the following code please? I thought the matching is a simple combination of trimming and slicing.

it can only use in the line mode of line comment
Indeed with this feature it's convenient to match only a single line ending

// don't use it!
// @note ...explanation
// continue explanation

so essentially first line is colored one way and the rest is the other

it will be strange to write together with other tags

I didn't quite understand the example, what I meant is to check if comment's content ends with a tag rather than starting. It shouldn't trigger if it appears inside of the string. Basically the logic is if there's no starting tag, check for ending.
Also the option may be more generalized "allowTrailing": true, so it will still match both the beginning and the ending

Could you point me to the following code please? I thought the matching is a simple combination of trimming and slicing.

This code is for single line mode of line comment, if you want to use trailing mode, should add another RegExp match loop before this
https://github.com/edwinhuish/better-comments-next/blob/6b18ac33759a074dd13c7c2ece06c75cea3104da/src/handler/langs/common.ts#L141-L167

it will be strange to write together with other tags

means something like below, some tags in the begining, others at the end.
// # some title
// don't use it!
// * bold comment
// ~ custom tag decoration

You could use in this way. And you could
// # some title
// ! don't use it! (Here is the reason why, this sentence will also be highlighted)
// * bold comment
// ~ custom tag decoration

Also the option may be more generalized "allowTrailing": true, so it will still match both the beginning and the ending

It will cause the reg more complicate or conflict with the vscode decoration. For example as blow:
// ! don't use it! (Here is the reason why, this sentence will also be highlighted)

The first ! will mark all line as highlight, but the second ! will mark ! don't use it! as highlight, it will cause conflict
At the end, I think it's not worth to do this, bacause:

Just make the sentence more humane. However, you can consider the tag name as part of the annotation
Will cause performance loss
Will cause more conflict/bug at vscode decoration

It will cause the reg more complicate or conflict with the vscode decoration

Ah, what I meant is that config can be simpler so it will match both
// ! don't
and
// don't !

In case of prefix presence it'd take the charge no matter the ending, so there can't be any conflicts.
And trailing can't be somewhere in the middle, only at the end as I noted in the initial example. That's why I consider it easy to implement. Haven't looked at the code yet though. I'll do it later.

For any new feature added, it is necessary to consider its necessity, the benefits it brings,
and most importantly, the potential problems it may cause.
You just said how will you use it. But I'm thinking about how will the people use.
If there more people needs it, I will think about it.


Automation: Incorrect favicon shown during setup

Based on work done in https://github.com/rancher/dashboard/issues/8794, let's write an automated test to avoid this regression so that the correct favicon appears during setup.
To Reproduce:

Bring up a new rancher
Nav to UI

Expected Result:
In default setups this should be the blue rancher bull
Details:
Problem was caused by <link rel="shortcut icon" type="image/x-icon" href="/public/favicon.png"> in template; this should just be /favicon.png from shell/public/index.html

Suggested test approach (e2e):

Load the UI
Look in the document head and find the link for the shortcut icon
Download the link (check for failure to download)
Compare the file downloaded to the icon in the code tree (use MD5 or some other simple hash algorithm)


Draft: Proposal for Conditions Support

👋 Want to propose adding Conditions to the data available per resort. A lot of the resort websites offer this and its really helpful to know, along with the existing open lifts and weather forecasts.
Obviously this is a very sloppy test implementation, just wanted to get something basic working to show the idea off.
After working a bit with the domutil function I think it would make sense to standardize a bit more of the logic for it, and split off the per resort/condition logic to its own files.
The other big question mark for me is how to structure the parsing files. Personally I think it would be best to re-organize them to make it cleaner and make it easy to allow other data points in the future. Something like:
module.exports = {
  lifts: {
    selector: '[id^=conditions_lifts_] div.breakInsideAvoid',
    parse: {
      name: {
        child: '1'
      },
      status: {
        child: '0/0',
        attribute: 'alt'
      }
    }
  },
  conditions: {
    base: '[id^=conditions_area_] li:nth-child(5) .js-measurement[data-metric]',
    season: '[id^=conditions_area_] li:nth-child(4) .js-measurement[data-metric]',
    twentyfour_hours: '[id^=conditions_area_] li:nth-child(1) .js-measurement[data-metric]',
    fortyeight_hours: '[id^=conditions_area_] li:nth-child(2) .js-measurement[data-metric]',
    seven_days: {
      selector: '[id^=conditions_area_] li:nth-child(3) .js-measurement[data-metric]',
      attribute: 'data-whatever'
    },
  }
};

@pirxpilot just wanted to followup and see if this is a feature you'd be open to having added to Liftie or not

It would be great to have Liftie display snow conditions data. It used to do that before but all the APIs that we were using are now defunct.
Liftie actually still have a remnant UI for displaying snow conditions - check out snow mixin in resort.jade.
Using resort data (as opposed to using 3rd party API) for snow totals is not a bad idea. What I am worrying about is a uniform and useful data format. For that reason I would like to see it some kind of analysis or even implementation for several distinct resorts so that we know more about what kind of data we can expect in the wild.
What I feel strongly about is that we do not send any extra requests for websites that are already providing that data along with the lift status. Obviously we would need to send requests if conditions are available on other pages (or other APIs) and that would mean we need extra entries in the resort.json descriptor.
What I am less worried about is the specific format of the resort parser.  Whatever we do I would keep the existing parser format working so that adding the conditions does not look like a big rewrite.


pull request for e2e test at 11/23/2016 18:56:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Intercom API keys deprecated

They're moving to an Access Token model.

hi

ok thanks

where can I find it?


Updated Mesos/Marathon/UI for pods.

This PR is also still missing the latest Marathon. @aquamatthias it sounds like we have a bugfix in flight for a config issue in snap26, can we bump Marathon here also when snap27 is available?

@greggomann Thanks for the hint. The config problem is fixed and  1.4.0-snap27 is released.
Not sure how I can update this branch - but if you don't mind, please update the marathon part with:
   "marathon": {
      "kind": "url_extract",
      "url": "http://downloads.mesosphere.io/marathon/v1.4.0-snap27/marathon-1.4.0-snap27.tgz",
      "sha1": "524c03b9dee1f9c0efce26fc068d08728d3f5d21"
    },

Thanks.

@aquamatthias sure no problem, I just bumped to snap27. Thanks for the build! Just for future reference, this branch is in the mesosphere fork so you should be able to push to it if necessary.

@cmaloney thanks for the helpful comments! I've addressed them, let me know what you think.

I removed the dcos-ui update, hopefully the current dcos-ui SHA is sufficient. @mlunoe @orlandohohmeier: could you let us know if there are any new changes in dcos-ui master that we should pull in for pods?

@greggomann https://teamcity.mesosphere.io/viewLog.html?buildId=487443&buildTypeId=DcosIo_Dcos_VagrantIntegrationTests_ProvisioningTestGenconfBashPr&guest=1 one test failure to investigate so far


[FLOC-3185] Reset reconnection delay upon succesful connection

Before this the reconnect delay would grow on every reconnect and never go back down.

LGTM. Please merge when green.


[WIP] Add support for CIS benchmarking of Platform9 Managed Kubernetes clusters in kube-bench

Closing this one in favour of https://github.com/platform9/kube-bench/pull/5


Implement LLVM function multiversioning along with LTO

Related to enabling LTO (#3736). LLVM has the ability to add a per-function attribute that denotes particular target information (arch/etc). This enables the LTO code generator to create multiple versions to either match link-time options (so emit one bitcode file and then actually specify the arch options during linking) or persist to runtime (embedding multiple versions of the function, such as with/without certain instructions being used).
This would allow us to have an MLIR attribute similar the Vulkan env that we attach per hal.executable.target that specifies which LLVM archs to target instead of having one hal.executable.target per LLVM architecture. Deferring the actual selection to link-time lets us reap benefits on caching/deduping/tuning/etc.

original landing in LLVM https://reviews.llvm.org/D40819
old talk introducing https://llvm.org/devmtg/2014-10/Slides/Christopher-Function Multiversioning Talk.pdf
clang attributes for reference https://clang.llvm.org/docs/AttributeReference.html#target

Major work:

[ ] first land #3736 so we can do link-time code generation
[ ] manually verify how the attribute works in the linking pipeline
[ ] add MLIR attribute for hal.executable.target (#iree.llvm.targets or something) for specifying LLVM target features
[ ] plumb through option to allow top-level platform archs to fan out to all the variants we may benefit from (no need for generating special versions that support random AES encryption instructions and stuff)

This was solved with hal.executable.variant conditional enablement.


[Animated] Animated.sequence used for scale transform leads to null values in transformMatrix.

I'm running v0.0.11. In this version, I'm attempting an animation like this:
_loopScaleAnimation() {
    if (!this.scaling) {
      var sequenceArray = [];
      for (var i = 0; i < 1000; i++) {
        sequenceArray.push(Animated.timing(
                            this.state.bounceValue,
                            {
                              toValue: 0.895,
                              duration: 600,
                              easing: Easing.inOut(Easing.ease),
                            }));
        sequenceArray.push(Animated.timing(
                            this.state.bounceValue,
                            {
                              toValue: 1.0,
                              duration: 600,
                              easing: Easing.inOut(Easing.ease),
                            }));
      }

      var scaling = Animated.sequence(sequenceArray);
      scaling.start();
      this.scaling = scaling;
    }
  }

It's attached to a view like this:
  <Animated.View style={{transform:[{scale: this.state.bounceValue}]}}
                     ref={(view) => this.cell = view}>
    <...>
  </Animated.View>

After a variable amount of time, sometimes after 5-10 seconds, sometimes almost instantly, sometimes never, it collapses. It spits out never ending dialog of the same line:
2015-10-20 18:13:43.126 [error][tid:main][RCTConvert.m:55] Error setting property 'transformMatrix' of RCTView with tag #299: JSON value '<null>' of type NSNull cannot be converted to NSNumber
2015-10-20 18:13:43.130 [error][tid:main][RCTConvert.m:55] Error setting property 'transformMatrix' of RCTView with tag #299: JSON value '<null>' of type NSNull cannot be converted to NSNumber
2015-10-20 18:13:43.133 [error][tid:main][RCTConvert.m:55] Error setting property 'transformMatrix' of RCTView with tag #299: JSON value '<null>' of type NSNull cannot be converted to NSNumber
2015-10-20 18:13:43.137 [error][tid:main][RCTConvert.m:55] Error setting property 'transformMatrix' of RCTView with tag #299: JSON value '<null>' of type NSNull cannot be converted to NSNumber
2015-10-20 18:13:43.140 [error][tid:main][RCTConvert.m:55] Error setting property 'transformMatrix' of RCTView with tag #299: JSON value '<null>' of type NSNull cannot be converted to NSNumber

I've tracked this down to null values being passed to RCTConvert CATransform3D. I'm not sure why this happens. I create the bounceValue object in the constructor() and in componentWillReceiveProps(), like so:
setState({bounceValue: new Animated.Value(1),})
Any ideas? Is this something that is fixed in the latest version?

A bit more information, if I remove the easing: Easing.inOut(Easing.ease), call, the issue doesn't happen. Possibly an issue with how that Easing object interpolates values?
A similar issue happens if I instead do an opacity transform with that easing function. Rather than crashing however, the animation just stops running after about a second.

Can confirm this is still an issue as of 0.15rc

I have the same issue in React Native 0.18.1. This currently happens on iOS (haven't tested Android). This error comes up only when I bundle the app. Using the dev server it works fine. It is happening when I'm pressing a TouchableHighlight which just toggles a boolean variable of the state. Any ideas?

+1

Can confirm that this is still an issue as of RN 0.20.0. For me, this was limited to iOS only, being run on device (both bundled and dev server). I wasn't using any custom animations where this would break - just route transition animations - fix seems to be to remove a Navigator.replace call before the call to Navigator.push that this break would occur.
I suspect that the route transition animations are using Easing.inOut under the hood causing the break in this case.

Hmm, I feel bad that nobody got to this before now, but since all of these comments are pretty old, refer to slightly different things, and there has been a decent amount of work on animation since then, it's hard for me to see how to make progress on this issue from here. I think the thing to do is to close out this issue but if tehre is a similar issue with nulls in animations on a recent version of RN with a small repro then that would be helpful and I suggest people with that info to open a new issue. So on that theory I am closing this issue.


'adopt' is ambigous

Description:
Distribution name 'adopt' is ambigous.
There are two VM implementations available under this name, Hotspot and OpenJ9.
Task version:
v2
Platform:

[X] Ubuntu
[X] macOS
[X] Windows

Runner type:

[X] Hosted
[ ] Self-hosted

Repro steps:
distribution: adopt
Expected behavior:
Expected adopt-hotspot and adopt-openj9 instead.
Actual behavior:
One of them is chosen, I do not know which one – probably hotspot?

Hello @bmarwell. Currently the action supports only hotspot releases and "adopt" references hotspot binaries. We have an active pull request to add support for openj9 implementation.

Merged PR and released version v2.1.0 Link. No need to bump major version since there are no breaking changes.
Going to update v2 tag to point to v2.1.0 tomorrow. Will be appreciate for any testing and confirmation that it works as expected.

Hello @bmarwell, pull request was merged and v2 tag was also updated. I'm closing the issue. If you have any concerns feel free to reopen the issue.


0.8.1 Edge - too much recursion

Here is the fiddle: http://jsfiddle.net/rn6e9Lr0/16/
Open the console and press the "Update" button.
I think that there is something related with {{yield}} but I'm not sure.
This works as expected with 0.8.0-edge-c0fd077dcbf14872da9f3a84dbc07a6b599e2118
(http://jsfiddle.net/g3L56tjf/1/)
Seems that something changed after that build.

This was an issue related to linking linked arrays and then shuffling from the link. I added some guards to keep nested links from triggering shuffles on themselves while they shuffle, and it looks as though that's got it fixed. Thanks for the report!

Also, I published 0.8.1-build-5 with this change :smile:


Fix link to Activity Streams 2.0

The old link wasn't working - this seems to be the correct link, currently.

Thanks @rhencke!


Add magic words support

Should resolve T6.

@nisargjhaveri does not want Felicity specific config to go into our code.


Fix up documentation to work with this version of toolbox.

We probably want to make a seperate set of pages for now and make sure the questionmark from settings leads to there.

Adding "help wanted" as documenting is something more people can help with as it doesn't require coding knowledge.

https://www.reddit.com/r/tb_redesign/wiki/pages Updated most docs to at least be correct with how things work now. Might not have all features documented yet but it should be complete enough for now.


What is the fs3 for the original SG2 models like stylegan cat (not AFHQ)?

Or how do I calculate it?

run
$ python global_direction/SingleChannel.py
for style layers that are not 'TORGB' layers

I tried this on the stylegan2-car-config-f and the cat and I am getting
weirdly generated image.
Also, it seems like it is generating 512x512 even though those datasets are
512x384 and 256x256 respectively.
On Fri, Nov 19, 2021, 16:16 soushirou @.***> wrote:

run
$ python global_direction/SingleChannel.py
for style layers that are not 'TORGB' layers
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/orpatashnik/StyleCLIP/issues/78#issuecomment-973853331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACDL237CG2CGBMRHEECOKLTUMYBUPANCNFSM5IBZB7EA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The print layers output something like this for the stylegan2-car-config-f and stylegan2-cat.
Gs                            Params    OutputShape         WeightShape
---                           ---       ---                 ---
latents_in                    -         (?, 512)            -
labels_in                     -         (?, 0)              -
lod                           -         ()                  -
dlatent_avg                   -         (512,)              -
G_mapping/Normalize           -         (?, 512)            -
G_mapping/Dense0              262656    (?, 512)            (512, 512)
G_mapping/Dense1              262656    (?, 512)            (512, 512)
G_mapping/Dense2              262656    (?, 512)            (512, 512)
G_mapping/Dense3              262656    (?, 512)            (512, 512)
G_mapping/Dense4              262656    (?, 512)            (512, 512)
G_mapping/Dense5              262656    (?, 512)            (512, 512)
G_mapping/Dense6              262656    (?, 512)            (512, 512)
G_mapping/Dense7              262656    (?, 512)            (512, 512)
G_mapping/Broadcast           -         (?, 16, 512)        -
Truncation/Lerp               -         (?, 16, 512)        -
G_synthesis/4x4/Const         8192      (?, 512, 4, 4)      (1, 512, 4, 4)
G_synthesis/4x4/Conv          2622465   (?, 512, 4, 4)      (3, 3, 512, 512)
G_synthesis/4x4/ToRGB         264195    (?, 3, 4, 4)        (1, 1, 512, 3)
G_synthesis/8x8/Conv0_up      2622465   (?, 512, 8, 8)      (3, 3, 512, 512)
G_synthesis/8x8/Conv1         2622465   (?, 512, 8, 8)      (3, 3, 512, 512)
G_synthesis/8x8/Upsample      -         (?, 3, 8, 8)        -
G_synthesis/8x8/ToRGB         264195    (?, 3, 8, 8)        (1, 1, 512, 3)
G_synthesis/16x16/Conv0_up    2622465   (?, 512, 16, 16)    (3, 3, 512, 512)
G_synthesis/16x16/Conv1       2622465   (?, 512, 16, 16)    (3, 3, 512, 512)
G_synthesis/16x16/Upsample    -         (?, 3, 16, 16)      -
G_synthesis/16x16/ToRGB       264195    (?, 3, 16, 16)      (1, 1, 512, 3)
G_synthesis/32x32/Conv0_up    2622465   (?, 512, 32, 32)    (3, 3, 512, 512)
G_synthesis/32x32/Conv1       2622465   (?, 512, 32, 32)    (3, 3, 512, 512)
G_synthesis/32x32/Upsample    -         (?, 3, 32, 32)      -
G_synthesis/32x32/ToRGB       264195    (?, 3, 32, 32)      (1, 1, 512, 3)
G_synthesis/64x64/Conv0_up    2622465   (?, 512, 64, 64)    (3, 3, 512, 512)
G_synthesis/64x64/Conv1       2622465   (?, 512, 64, 64)    (3, 3, 512, 512)
G_synthesis/64x64/Upsample    -         (?, 3, 64, 64)      -
G_synthesis/64x64/ToRGB       264195    (?, 3, 64, 64)      (1, 1, 512, 3)
G_synthesis/128x128/Conv0_up  1442561   (?, 256, 128, 128)  (3, 3, 512, 256)
G_synthesis/128x128/Conv1     721409    (?, 256, 128, 128)  (3, 3, 256, 256)
G_synthesis/128x128/Upsample  -         (?, 3, 128, 128)    -
G_synthesis/128x128/ToRGB     132099    (?, 3, 128, 128)    (1, 1, 256, 3)
G_synthesis/256x256/Conv0_up  426369    (?, 128, 256, 256)  (3, 3, 256, 128)
G_synthesis/256x256/Conv1     213249    (?, 128, 256, 256)  (3, 3, 128, 128)
G_synthesis/256x256/Upsample  -         (?, 3, 256, 256)    -
G_synthesis/256x256/ToRGB     66051     (?, 3, 256, 256)    (1, 1, 128, 3)
G_synthesis/512x512/Conv0_up  139457    (?, 64, 512, 512)   (3, 3, 128, 64)
G_synthesis/512x512/Conv1     69761     (?, 64, 512, 512)   (3, 3, 64, 64)
G_synthesis/512x512/Upsample  -         (?, 3, 512, 512)    -
G_synthesis/512x512/ToRGB     33027     (?, 3, 512, 512)    (1, 1, 64, 3)


[SPARK-30786] [BLOCK MANAGER] Fix Block replication failure propogation issue in BlockManager

What changes were proposed in this pull request?
Currently the uploadBlockSync api in BlockTransferService always succeeds irrespective of whether the BlockManager was able to successfully replicate a block on peer block manager or not. This PR makes sure that the NettyBlockRpcServer invokes onFailure callback when it is not able to replicate the block to itself because of any reason. The onFailure callback makes sure that the BlockTransferService on client side gets the failure and retry replication the Block on some other BlockManager.
Why are the changes needed?
Currently the Spark Block replication retry logic is not working correctly. It doesn't retry on other Block managers even when replication fails on 1 of the peers.
A user can cache an DataFrame with different replication factor. Ex - df.persist(StorageLevel.MEMORY_ONLY_2) - This will cache each partition at two different BlockManagers. When a DataFrame partition is computed first time, it is firstly stored locally on the local BlockManager and then it is replicated to other block managers based on replication factor config. The replication of block to other block managers might fail because of memory/network etc issues and so there is already provision to retry the replication on some other peer based on "spark.storage.maxReplicationFailures" config, Currently when this replication fails, the client does not know about the failure and so it doesn't retry on other peers. This PR fixes this issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added Unit Test.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

also cc @cloud-fan @jiangxb1987

ok to test

Test build #118226 has started for PR 27539 at commit ee8a823.

BTW, please change the tag [BLOCK MANAGER] to [CORE].

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22986/
Test PASSed.

Test build #118228 has started for PR 27539 at commit cc28bc3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22988/
Test PASSed.

Test build #118228 has finished for PR 27539 at commit cc28bc3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118228/
Test FAILed.

Test build #118226 has finished for PR 27539 at commit ee8a823.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118226/
Test FAILed.

Test build #118236 has started for PR 27539 at commit 2df9ac4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22996/
Test PASSed.

Test build #118236 has finished for PR 27539 at commit 2df9ac4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118236/
Test PASSed.

Test build #118256 has started for PR 27539 at commit b0231a1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23015/
Test PASSed.

Test build #118257 has started for PR 27539 at commit 9c1905b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23016/
Test PASSed.

Test build #118259 has started for PR 27539 at commit 8db35f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23018/
Test PASSed.

Test build #118256 has finished for PR 27539 at commit b0231a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118256/
Test FAILed.

Test build #118257 has finished for PR 27539 at commit 9c1905b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118257/
Test FAILed.

Test build #118259 has finished for PR 27539 at commit 8db35f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118259/
Test FAILed.

Test build #118281 has started for PR 27539 at commit 893d813.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23040/
Test PASSed.

Test build #118281 has finished for PR 27539 at commit 893d813.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118281/
Test FAILed.

Jenkins, retest this please

retest this please

Test build #118284 has started for PR 27539 at commit 893d813.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23043/
Test PASSed.

Test build #118285 has started for PR 27539 at commit 893d813.

Test build #118284 has finished for PR 27539 at commit 893d813.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118284/
Test FAILed.

retest this please.

Test build #118286 has started for PR 27539 at commit 893d813.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23044/
Test PASSed.

Test build #118286 has finished for PR 27539 at commit 893d813.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118286/
Test FAILed.

Test build #118285 has finished for PR 27539 at commit 893d813.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118285/
Test FAILed.

Test build #118316 has started for PR 27539 at commit 6f102e9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23074/
Test PASSed.

Test build #118316 has finished for PR 27539 at commit 6f102e9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118316/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23111/
Test PASSed.

Test build #118354 has started for PR 27539 at commit 339a8ab.

Test build #118354 has finished for PR 27539 at commit 339a8ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118354/
Test PASSed.

Test build #118367 has started for PR 27539 at commit efbee12.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23124/
Test PASSed.

Test build #118367 has finished for PR 27539 at commit efbee12.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118367/
Test FAILed.

@cloud-fan @Ngone51 Thanks for reviewing the PR.
The UT added in this PR always passes on my machine but on jenkins machine - it sometimes passes and sometimes fails. Could you please help take a look on the intermittent failure.
Parallely I am also trying to replace the low memory BlockManagers in my test with some mocked objects to avoid flakiness.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23165/
Test PASSed.

Test build #118409 has started for PR 27539 at commit a75be4b.

Test build #118409 has finished for PR 27539 at commit a75be4b.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118409/
Test FAILed.

Test build #118418 has started for PR 27539 at commit 90e0050.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23175/
Test PASSed.

Test build #118418 has finished for PR 27539 at commit 90e0050.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118418/
Test FAILed.

Test build #118428 has started for PR 27539 at commit 72d4353.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23185/
Test PASSed.

Test build #118428 has finished for PR 27539 at commit 72d4353.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118428/
Test FAILed.

Test build #118530 has started for PR 27539 at commit 4857401.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23285/
Test PASSed.

Test build #118530 has finished for PR 27539 at commit 4857401.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118530/
Test FAILed.

@Ngone51 @cloud-fan I have fixed the flaky test. In the last 2-3 test builds, failures are not due to changes in this PR.
Can you please review the new test.

Jenkins, retest this please.

Test build #118566 has started for PR 27539 at commit 4857401.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23322/
Test PASSed.

Test build #118566 has finished for PR 27539 at commit 4857401.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118566/
Test FAILed.

Test build #118566 has finished for PR 27539 at commit 4857401.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@Ngone51 Test failures unrelated to this change.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23348/
Test PASSed.

Test build #118594 has started for PR 27539 at commit 4857401.

Test build #118594 has finished for PR 27539 at commit 4857401.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118594/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23363/
Test PASSed.

Test build #118610 has started for PR 27539 at commit 91e3a36.

Test build #118610 has finished for PR 27539 at commit 91e3a36.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118610/
Test FAILed.

Test build #118610 has finished for PR 27539 at commit 91e3a36.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Looks like some different intermittent failure - not a test failure.

@prakharjain09 actually, you could also try "Jenkins, retest this please" when you want to re-trigger the test.

Jenkins, retest this please.

Test build #118635 has started for PR 27539 at commit 91e3a36.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23388/
Test PASSed.

Test build #118635 has finished for PR 27539 at commit 91e3a36.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118635/
Test FAILed.

Jenkins, retest this please.

Test build #118638 has started for PR 27539 at commit 91e3a36.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23392/
Test PASSed.

Test build #118638 has finished for PR 27539 at commit 91e3a36.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118638/
Test PASSed.

@prakharjain09 actually, you could also try "Jenkins, retest this please" when you want to re-trigger the test.

As per https://spark.apache.org/contributing.html page, a Committer has to add me to whitelist using "Jenkins, add to whitelist" :)

@Ngone51 @cloud-fan Can you please review and merge the changes if everything looks good.

LGTM

This is not a serious bug: 1) by default RDD cache doesn't have replication. 2) even if replication fails, job can still run. And it touches a critical code path, I'm merging to master only, thanks!


Is it necessary to enter User email id and Password to login?

When i install my app,my app loads,then it ask the user to login via Google.When user clicks on Login button,It opens a window using inappbrowser plugin displaying user to enter User google credential and then google permission page and all.
So, I want to implement that user will directly shown google permission page as it happens in all other apps.
how can be this done?

This plugin uses web oauth, not native login.  If you want to automatically log in based on the users available accounts, you'll have to find a different plugin.  Otherwise, the user will have to sign in using the web flow with this plugin.
Regards,


[1.20.1-Forge] EMI not properly showing up. Stuck at "Baking Recipes". (JEI is installed.)

What happened:
Since 1.0.13 update and above EMI is stuck at "Experiencing delay, is everything alright?. Baking Recipes. EMI Reloading..."
(JEI is installed.)

Versions 1.0.12 and below work fine. No longer stuck / experiencing delays.
Versions:
MC: 1.20.1
Forge: 47.1.3
EMI: from 1.0.13 & 1.0.14 and up.
JEI: <IP_ADDRESS>
Logs:
If needed: https://gist.githubusercontent.com/Gbergz/9b3dc2ceb0102b7960e02ac9f2cff330/raw/d5140048ebd2716f8096678be46b0113e8fc9efa/gistfile1.txt

Based on the log ending on baking the index, this was fixed with the latest update, 1.0.15

I still have this problem in the latest version for 1.19.2
MC: 1.19.2
Forge: 43.2.21
EMI: 1.0.15
After a few minutes it loads
https://mclo.gs/w2H5gsE

I originally closed this too early conflating it with another issue. After further testing I was able to discover the problem and resolve it properly in 1.0.16


transforms v2 rotate can create different sizes between tensors and PIL with expand=True

import torch
from torchvision.transforms.v2 import functional as F

input_tensor = torch.rand(3, 17, 11)
input_pil = F.to_pil_image(input_tensor)

kwargs = dict(angle=-10.9, center=(1.2, 4.9), expand=True)

output_tensor = F.rotate(input_tensor, **kwargs)
output_pil = F.rotate(input_pil, **kwargs)

shape_tensor = F.get_image_size(output_tensor)
shape_pil = F.get_image_size(output_pil)

assert shape_tensor == shape_pil, f"{shape_tensor} != {shape_pil}"

AssertionError: [15, 20] != [15, 19]

Replacing the import with from torchvision.transforms import functional as F, i.e. using transforms v1, does not have this problem.

We had some subtle issues here before, which supposedly should have been fixed by #7271.

PIL kernel is the culprit:
import torch
from torchvision.transforms.v2 import functional as F

input_tensor = torch.rand(3, 17, 11)
input_pil = F.to_pil_image(input_tensor)

kwargs = dict(angle=-10.9, expand=True)

output_w_center = F.rotate(input_tensor, **kwargs, center=(1.2, 4.9))
output_wo_center = F.rotate(input_pil, **kwargs, center=None)

shape_w_center = F.get_image_size(output_w_center)
shape_wo_center = F.get_image_size(output_wo_center)

assert shape_w_center == shape_wo_center, f"{shape_w_center} != {shape_wo_center}"

AssertionError: [15, 20] != [15, 19]

Meaning, #7271 did its job, but we need to expand it to the PIL kernel as well.
The issue is that center theoretically should have no effect on the output size if expand=True is given. Practically, rounding effects take place which lead the off-by-one errors. The difference between v1 and v2 is that we not only warn users about setting both parameters
https://github.com/pytorch/vision/blob/71968bc4afb8892284844a7c4cbd772696f42a88/torchvision/transforms/v2/functional/_geometry.py#L922-L923
we also explicitly unset center in this case
https://github.com/pytorch/vision/blob/71968bc4afb8892284844a7c4cbd772696f42a88/torchvision/transforms/v2/functional/_geometry.py#L924


Option to disable RPROMPT

Having RPROMPT when running a subshell in midnight commander produces all kind of weirdness. I used to disable it completely under such condition. All I need is an option in geometry to do so. Probably I can hack it around without changing the geometry, but messing with precmd hooks isn't a sane way to maintain it.

So, you're saying you want to disable RPROMPT at all or just mitigate the effects of running commands in a subshell?

The RPROMPT itself, potentially this means skipping git info virtualenv info calls for saving cycles. Basically mc messes with it that much that is stops being the right prompt.

Probably just branch off the following lines.

Unless anybody else wants to take up this task I'm gonna start it.


Allow specification of annotations for the smbshare service

Adding annotations to the created servcie would allow for additional configuration of the created service. For example, with metallb you could specify the requested address pool to use. Another use case could be specifying the hostname to use with external-dns for registering the load balancer assigned IP address with an external DNS provider (which would address #147).
I would propose that the SmbCommonConfig resource should contain an annotations key either under network or under a new different key. Perhaps serviceSettings could be a sibling of podSettings and it could contain additional settings for the service (e.g. loadBalancerIP).

Sounds generally reasonable to me. Having an annotations under network sounds fine to me. To be super clear we could also consider serviceAnnotations (also under network).
Please note that I have very little time for samba-operator myself these days, so depending on how strongly you want this you may want to look into implementing it yourself or finding someone. I am, of course, happy to review PRs and offer advice.


Forward for Accept header #2815

[] Provides fair header processing
[] Provide Accept: header of your choice
[] Default response content is text/html
[] None

Excellent. Please merge with master once and resolve conflicts so we can proceed. Thank you.

Have you had a chance to merge this with master once and resolve conflicts?

Conflict is too complex to resolve. I better provide brand new forward port.

Great. Thanks.

Have you had a chance to provide a patch for master?


Fix Bulk Copy Async deadlock with custom IDataReader using SqlDataReader internally.

Fix for issue #755
User-scenario:

Using 1 SqlConnection, perform Bulk Copy Async with datasource an instance of an implementation of IDataReader (internally calls SqlDataReader.ExecuteScalarAsync).

Currently, entire driver's async operations are single threaded when it comes to "parser" activity, and every Async operation is done with lock acquired from "SqlInternalConnectionTds._parserLock".
Pseudo scenario:
SqlConnection (I allow only 1 async operation to use parser) {
    SqlBulkCopy.WriteToServerAsync (parser lock acquired) {
        ReadFromRowSourceAsync (
            SimpleDataReader.enumerator => SqlCommand.ExecuteScalarAsync (I also need parser lock - Waits for lock forever!!!!!)
        )
        WriteToServerInternalRestAsync ( << parser lock is needed here)
    }
}

This PR fixes this behavior as under:
SqlConnection (I allow only 1 async operation to use parser) {
    SqlBulkCopy.WriteToServerAsync (parser lock acquired) {
        ReadFromRowSourceAsync (**release lock for reader) (
            SimpleDataReader.enumerator => SqlCommand.ExecuteScalarAsync (parser lock acquired - data read successfully)
        (**acquire lock again) )
        WriteToServerInternalRestAsync ( << parser lock is needed here)
    }
}

cc @karinazhou

The diff is a bit noisy because the IDE has fixed a lot of comments. It looks like the only change is in the bulk copy and that it saves a property releases the parser lock and then in a finally block waits, should it not re-acquire per your description?

After debugging this more, here is what I find for general scenarios where we use connection A for SqlBulkCopy instance and connection B for the data source (associated with SqlCommand). The _parserLock is associated with each connection. The lock behavior before the change is like this:
SqlBulkCopy.WriteToServerAsync() --> WriteRowSourceToServerAsync() -->  require lock on _parserLockA of connectionA
    SqlBulkCopy.ReadFromRowSourceAsync
    (
            SimpleDataReader.enumerator => SqlCommand.ExecuteScalarAsync -->  **require lock on _parserLockB of connectionB**
    )
      SqlBulkCopy.WriteToServerInternalRestAsync()  -->  need the lock on _parserLockA of connectionA

The lock behavior after the change is like this:
SqlBulkCopy.WriteToServerAsync() -->  WriteRowSourceToServerAsync()   -->  require lock on _parserLockA of connectionA
    SqlBulkCopy.ReadFromRowSourceAsync
    (
         ** release lock on _parserLockA of connectionA
        SimpleDataReader.enumerator => SqlCommand.ExecuteScalarAsync -->  **require lock on _parserLockB of connectionB**
         ** require lock on _parserLockA of connectionA
    )
      SqlBulkCopy.WriteToServerInternalRestAsync()  -->  need the lock on _parserLockA of connectionA

It looks like the original design of SqlBulkCopy doesn't expect the same connection to be used for both data source and SqlBulkCopy instance. So far, it looks OK to release the semaphore if we don't actually need it at this point to avoid the deadlock in the single connection edge case.

The diff is a bit noisy because the IDE has fixed a lot of comments. It looks like the only change is in the bulk copy and that it saves a property releases the parser lock and then in a finally block waits, should it not re-acquire per your description?

It's a weird design but that's how it is.
ParserLock semaphore is of size 1, when a thread calls 'Wait' it decrements the parserlock size to 0, blocking all other 'Wait' calls till the same thread calls 'Release'. That's how we reacquire lock by calling 'Wait'.


properly update settings in rtsp devices

Previously, upon changing framerate and jovision profiles, the camera was configured and the gstreamer pipeline was restarted.
However, the new pipeline did not actually make use of the new parameter and used the ones set during initialization of the RtspDevice instance.
This PR should fix this.
It also abstracts the settings interface away, so there will be some conflicts with #160 which should be resolved by asserting only that device is not None

[x] Make sure that jovision_profile is always set before anything else

This should be done but I will have to test it with a real device on Monday

This is ready to merge from my side

ready to merge from my side


How to make a carousel with vue-material?

Anybody have some idea?
Thanks!!

There isn't a carousel component at the moment. You can look forward to it though through here: #549

I'm going to close this. You can track the carousel component in #549, or ask for advice on making your own on our slack channel:
https://join.slack.com/vuematerial/shared_invite/MTgzMzU2NDQ5ODkwLTE0OTQ4MDI3MDAtNWYyZjhkNzEzMA