long delay getting onGeoQueryReady callback

Am regularly seeing relatively long delay (e.g. 5-10s....but in some cases significantly longer) before onGeoQueryReady callback is invoked.  This is I believe causing issue when moving quickly around map for example i.e. where another query is made before previous one completes.....what is the recommended approach in general for handling new query while one is still in progress?

The other issue I'm seeing are that other firebase queries are blocked until onGeoQueryReady() is called (e.g. if I try to make query in response to clicking on map marker)

It looks like the delay might be due to large amount of GC activity:
08-27 18:54:19.214  3979  3979 D PRETTYLOGGER: ╔════════════════════════════════════════════════════════════════════════════════════════
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ║ Thread: main
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ╟────────────────────────────────────────────────────────────────────────────────────────
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ║ GeoQuery$4.run  (GeoQuery.java:144)
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ║    ArtworkLocationActivity.onKeyExited  (ArtworkLocationActivity.java:397)
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ╟────────────────────────────────────────────────────────────────────────────────────────
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ║ Key ChIJIzUPEdBv5kcRbIE2RvFTOTo is no longer in the search area
08-27 18:54:19.215  3979  3979 D PRETTYLOGGER: ╚════════════════════════════════════════════════════════════════════════════════════════
08-27 18:54:23.355  3979  3991 I art     : Background partial concurrent mark sweep GC freed 467577(16MB) AllocSpace objects, 15(7MB) LOS objects, 26% free, 43MB/59MB, paused 2.138ms total 138.304ms
08-27 18:54:24.096  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 439482(16MB) AllocSpace objects, 1(208KB) LOS objects, 24% free, 45MB/59MB, paused 2.195ms total 124.700ms
08-27 18:54:24.822  3979  3991 I art     : Background partial concurrent mark sweep GC freed 453144(16MB) AllocSpace objects, 3(548KB) LOS objects, 26% free, 44MB/60MB, paused 2.652ms total 146ms
08-27 18:54:25.598  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 433460(16MB) AllocSpace objects, 0(0B) LOS objects, 22% free, 46MB/60MB, paused 2.320ms total 133.296ms
08-27 18:54:26.295  3979  3991 I art     : Background partial concurrent mark sweep GC freed 461305(16MB) AllocSpace objects, 1(468KB) LOS objects, 25% free, 47MB/63MB, paused 2.565ms total 142.552ms
08-27 18:54:27.070  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 445731(16MB) AllocSpace objects, 0(0B) LOS objects, 22% free, 48MB/63MB, paused 2.278ms total 128.798ms
08-27 18:54:27.798  3979  3991 I art     : Background partial concurrent mark sweep GC freed 539106(16MB) AllocSpace objects, 17(4MB) LOS objects, 26% free, 44MB/60MB, paused 1.574ms total 138.389ms
08-27 18:54:28.255  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 482094(17MB) AllocSpace objects, 80(1504KB) LOS objects, 24% free, 45MB/60MB, paused 1.504ms total 101.790ms
08-27 18:54:28.715  3979  3991 I art     : Background partial concurrent mark sweep GC freed 484361(18MB) AllocSpace objects, 90(1680KB) LOS objects, 26% free, 45MB/61MB, paused 1.420ms total 124.530ms
08-27 18:54:28.857   915   924 I art     : Background partial concurrent mark sweep GC freed 29987(1932KB) AllocSpace objects, 0(0B) LOS objects, 24% free, 49MB/65MB, paused 1.603ms total 161.349ms
08-27 18:54:29.635  3979  3991 I art     : Background partial concurrent mark sweep GC freed 500111(19MB) AllocSpace objects, 101(1884KB) LOS objects, 26% free, 45MB/61MB, paused 1.525ms total 133.642ms
08-27 18:54:31.134  3979  3991 I art     : Background partial concurrent mark sweep GC freed 422658(14MB) AllocSpace objects, 2(36KB) LOS objects, 24% free, 50MB/66MB, paused 1.413ms total 135.253ms
08-27 18:54:31.862  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 452789(15MB) AllocSpace objects, 0(0B) LOS objects, 19% free, 53MB/66MB, paused 1.509ms total 125.751ms
08-27 18:54:32.806  3979  3991 I art     : Background partial concurrent mark sweep GC freed 531391(17MB) AllocSpace objects, 2(48KB) LOS objects, 24% free, 50MB/66MB, paused 2.370ms total 155.513ms
08-27 18:54:36.656  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 595273(16MB) AllocSpace objects, 0(0B) LOS objects, 24% free, 50MB/66MB, paused 1.382ms total 117.751ms
08-27 18:54:40.391  3979  3991 I art     : Background partial concurrent mark sweep GC freed 806127(23MB) AllocSpace objects, 0(0B) LOS objects, 26% free, 43MB/59MB, paused 1.331ms total 152.355ms
08-27 18:54:43.926  3979  3991 I art     : Background sticky concurrent mark sweep GC freed 563650(16MB) AllocSpace objects, 0(0B) LOS objects, 26% free, 43MB/59MB, paused 1.245ms total 118.144ms
08-27 18:54:47.389  3979  3991 I art     : Background partial concurrent mark sweep GC freed 608763(16MB) AllocSpace objects, 0(0B) LOS objects, 26% free, 43MB/59MB, paused 1.266ms total 124.058ms
08-27 18:54:53.434  3979  3991 I art     : Background partial concurrent mark sweep GC freed 569641(16MB) AllocSpace objects, 0(0B) LOS objects, 26% free, 43MB/59MB, paused 1.274ms total 126.691ms
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ╔════════════════════════════════════════════════════════════════════════════════════════
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ║ Thread: main
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ╟────────────────────────────────────────────────────────────────────────────────────────
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ║ GeoQuery$5.run  (GeoQuery.java:189)
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ║    ArtworkLocationActivity.onGeoQueryReady  (ArtworkLocationActivity.java:413)
08-27 18:54:54.031  3979  3979 D PRETTYLOGGER: ╟────────────────────────────────────────────────────────────────────────────────────────
08-27 18:54:54.032  3979  3979 D PRETTYLOGGER: ║ All initial data has been loaded and events have been fired!
08-27 18:54:54.032  3979  3979 D PRETTYLOGGER: ╚════════════════════════════════════════════════════════════════════════════════════════

Can you give us an idea of the amount of total data stored in your GeoFire index as well as how much data your GeoQuery matches?
Also, what versions of Firebase, GeoFire, and Android / Java are you using?

Will get data on number of matches but was seeing these delays I believe when even small amount of data was being returned.
Versions:
Firebase: 9.4.0
GeoFire: 2.0.0
Android: 6.0.1

@jwngr also, what is the recommended approach in general for handling new query while one is still in progress?

If there are no indexes defined on the server, the filtering will happen client-side which can be very inefficient. Can you double check you have the right index defined (and there is no warning displayed in the logs).

Yes, index is defined (had got "Using an unspecified index. Consider adding '".indexOn": "g"' at ...." before this was added).

Is there working sample that I can try here and see if I can reproduce issue with that?

We're blocked right now from using this library due to these performance issues......what would really help, as mentioned, was if there was working sample we could try to at least help isolate where the performance issues are occurring?

We also git bitten by this and what helped was not using the persistence enabled flag on the FirebaseReference. Ideally we should go and take some time to investigate this further.


Skip travis jobs if pr only touches docs.

Exclude travis jobs if a PR only touches documentation. Only scan code will run.
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[x] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

@dgrove-oss wdyt about merging this PR.
I will test it out on #4880. The intent is to skip tests for md related changes and only run scancode.
I left perf tests enabled in this PR intentionally to see if it works as designed.

If we want to optimize for quick merge of documentation-only PRs, we should probably short-circuit the step of the build that compiles & deploys openwhisk too.

Can we merge this to see if this approach will actually work? It will already be an improvement. Some of the earlier steps will need to be moved into bash scripts - there's no way that i found to exclude travis steps/jobs because it doesn't evaluate true conditions.

don't object to merging; just observing that as-is it creates 7 jobs, each of which will run for about 8 minutes (mainly due to the setup script).

Not working as intended - the build should have been normal but all the tests are being skipped.


FEAT: Add support for CLIP model

Fixes #2628 .
Add support for jina-clip-v2, a general-purpose multilingual multimodal embedding model for text & images.

Really appreciate that you submit the PR so quickly.
Could you add the jina clip model to
https://github.com/xorbitsai/inference/blob/main/xinference/model/embedding/model_spec.json
and
https://github.com/xorbitsai/inference/blob/main/xinference/model/embedding/model_spec_modelscope.json

https://github.com/xorbitsai/inference/blob/main/xinference/model/embedding/tests/test_integrated_embedding.py
Integrated tests for embedding is added, could you add a test to test the CLIP model?

funasr released a new version 1 hour ago which caused the failure of CI.
https://github.com/xinference/xinference-prod/blob/ba8deed489805a1597c5342ae76f858ab51ed260/.github/workflows/python.yaml#L188
You need to add a line
${{ env.SELF_HOST_PYTHON }} -m pip install -U onnx

Crap, funasr is annoying. another library required onnxconverter-common.

I have one question, since we are using sentence-transformers for the clip task, can we just reuse current encode method inside create_embedding apart from we preprocessing the dict object and turned into text or PIL.Image in adavance?

Need some time to review the encode function carefully.

I have one question, since we are using sentence-transformers for the clip task, can we just reuse current encode method inside create_embedding apart from we preprocessing the dict object and turned into text or PIL.Image in adavance?

Need some time to review the encode function carefully.

IIRC, the encode is copied from sentence-transformers to just extract the num tokens information which is inside the encode.


Unable to send custom emails

Following the example on the docs, I have a collection called "users", trying to send custom emails after creation of new records:
app.OnRecordAfterCreateRequest("users").Add(func(e *core.RecordCreateEvent) error {
        message := &mailer.Message{
            From: mail.Address{
                Address: app.Settings().Meta.SenderAddress,
                Name:    app.Settings().Meta.SenderName,
            },
            To:      mail.Address{Address: e.Record.Email()},
            Subject: "YOUR_SUBJECT...",
            HTML:    "YOUR_HTML_BODY...",
            // bcc, cc, attachments and custom headers are also supported...
        }

        return app.NewMailClient().Send(message)
    })

However when I do
go run main.go serve
I get the following error:
./main.go:24:13: cannot use mail.Address{…} (value of type mail.Address) as []mail.Address value in struct literal
Is it my fault or the docs are outdated?
Can someone help me correct the code?
Thanks

To docs are incorrect. I'll update the examples sometime later today.
To, Bcc and Cc should be slice of mail.Address values, aka. you can try:
app.OnRecordAfterCreateRequest("users").Add(func(e *core.RecordCreateEvent) error {
	message := &mailer.Message{
		From: mail.Address{
			Address: app.Settings().Meta.SenderAddress,
			Name:    app.Settings().Meta.SenderName,
		},
		To:      []mail.Address{{Address: e.Record.Email()}},
		Subject: "YOUR_SUBJECT...",
		HTML:    "YOUR_HTML_BODY...",
		// bcc, cc, attachments and custom headers are also supported...
	}

	return app.NewMailClient().Send(message)
})

(you can also check the godoc for a list with all available Message fields and types -<EMAIL_ADDRESS>

Holy c**p, that was fast!
Thanks a lot it works perferctly
F
On Thu, May 11, 2023 at 5:19 PM Gani Georgiev @.***>
wrote:

To docs are incorrect. I'll update the examples sometime later today.
To, Bcc and Cc should be slice of mail.Address values, aka. you can try:
app.OnRecordAfterCreateRequest("users").Add(func(e *core.RecordCreateEvent) error {
message := &mailer.Message{
From: mail.Address{
Address: app.Settings().Meta.SenderAddress,
Name:    app.Settings().Meta.SenderName,
},
To:      []mail.Address{{Address: e.Record.Email()}},
Subject: "YOUR_SUBJECT...",
HTML:    "YOUR_HTML_BODY...",
// bcc, cc, attachments and custom headers are also supported...
}
return app.NewMailClient().Send(message)
})
(you can also check the godoc for a list with all available Message
fields and types -
@./tools/mailer#Message
@./tools/mailer#Message>
)
—
Reply to this email directly, view it on GitHub
https://github.com/pocketbase/pocketbase/issues/2460#issuecomment-1544185820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOR3G5QMF2Z46UJOJ73GTXFT7PXANCNFSM6AAAAAAX6I2RRY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Error with appscript Cannot find method JSON.parse

So I have this small function that fetches JSON from our companys API and pushes it to Google sheets, everything was working ok yesterday but now when I run the script I get the error
"Cannot find function parse in [object Object] I have no idea where this is coming from since if I try to
write JSON. TAB it shows there is a parse function. Any thoughts? Is this a bug?
`function pullJSON() {
options = {muteHttpExceptions: true};
var ss = SpreadsheetApp.getActiveSpreadsheet();
var sheets = ss.getSheets();
var sheet = ss.getActiveSheet();
var url="API PATH"; // Paste your JSON URL here
var response = UrlFetchApp.fetch(url, options); // get feed
var dataAll = JSON.parse(response.getContentText()); //
var dataSet = dataAll;
var rows = [],
data;
for (i = 0; i < dataSet.length; i++) {
data = dataSet[i];
rows.push([data.title,new Date(data.promotionStartDate),new Date(data.promotionDateEnd)]); //your JSON entities here
}
dataRange = sheet.getRange(1, 1, rows.length, 3); // 3 Denotes total number of entites
dataRange.setValues(rows);
}
`

FYI, this GitHub issue tracker should be used to report bugs with our samples and is not a forum for general Apps Script questions. See the Apps Script Support page for information on how to get help.
My guess is that you have a variable defined somewhere called "JSON", and so when you call JSON.parse() it's looking at that object instead and not finding the method.


Back action does not clear the states of the unmounted component

Version
react-native-router-flux v3.37.0,
react-native: v0.40.0
so I realized this code unmounts the current component then returns back to your last component:

Actions.pop({type: 'back'});

the problem is that the unmounted component doesn't loose its states when I route back to that component.  I was hoping the states for that component resets because the component was unmounted. But it was exactly as i had left it. Any Idea on this guys?? thanks in advance

I'm having the same problem. I think my issue is related to my state management Apollo Client (Redux). Perhaps Apollo Client does not auto cleanup state when a component which uses that state unmounts. I guess that's reasonable for Apollo Client. Then, when component which uses that state is mounted again Apollo Client connects all the old/cached state to that component.
I could manually clean up state when component is unmounted, or it turns out Apollo Client has some forceFetch=true option which will cause it to ignore any cached state, and will refetch the data when component mounts again.
What state management tool are you using? Or is it just component level state? If it's just component level state I feel like it should automatically get cleaned up when component unmounts.
Also, how sure are you that the component is getting unmounted? I was looking at the reducer for this routing library, and it seems that popping the component will result in "from" getting set with what I think is the "popped from" component. If that's true, then there is still a reference to the popped component in memory, so wouldn't that prevent the component from getting unmounted, or at least prevent it from getting cleaned up in memory? According to RN docs it seems that component is destroyed when it is unmounted.

@joshg111 the component does get unmounted. I just simple checked it by logging using componentWillUnmount. I kind of found out the problem but I still can't figure out how it was happening.
I'm using Feathers client (redux), the problem is with the redux state. Since the i get data of my react component's state from A Redux state using componentWillMount, every changes from my react components state somehow gets reflected to my Redux state without triggering or dispatching actions from my reducers. I really don't know how it was happening. Somehow the memory location of that data from my react components state is pointing to my redux state.
So what I did is that everytime I load that component, I just simply fetch new fresh data from my server then store it to my redux state then load it to my component using componentWillMount so i could be sure that i have fresh data when i load the component. Then another option is that everytime I unmount from that component i fetch another new data from the server to be stored on my redux state to clear any changes that happened during that time. Hope this helps.

I am using 'react-native-router-flux' to implement navigation between pages in my app.
There are some scenes (sort, filter) that I would like to remove from the back stack.
Is it possible to skip adding some pages to the stack  or  remove the page from back stack ?

The issue with removing a scene from the back stack was resolved by using popAndReplace' type in the the custom actions:
Actions.products({   ...this.props.product,   type: 'popAndReplace' });


using identityserver in mvc WITH  .net core 2.0

UseOpenIdConnectAuthentication is changed in core 2.0. would you please change the example and upgrade them to 2.0 ?

We will update the samples at some point - for now please refer to Microsoft docs on how to do this mechanical change.

I did it but there is an exception
 Error from RemoteAuthentication: Cannot cast Newtonsoft.Json.Linq.JArray to Newtonsoft.Json.Linq.JToken.. fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[0]       An unhandled exception has occurred while executing the request System.InvalidCastException: Cannot cast Newtonsoft.Json.Linq.JArray to Newtonsoft.Json.Linq.JToken.    at Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler1.d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__7.MoveNext()
My configuration
` public void ConfigureServices(IServiceCollection services)
{
services.AddAuthentication(sharedOptions =>
{
sharedOptions.DefaultScheme = CookieAuthenticationDefaults.AuthenticationScheme;
sharedOptions.DefaultChallengeScheme = OpenIdConnectDefaults.AuthenticationScheme;
}).AddOpenIdConnect(options =>
{
options.ClientId = "";
options.ClientSecret = "";
options.Authority = Configuration["IdentityServerAddress"];
options.SignedOutRedirectUri = Configuration["clientAddress"];
options.ResponseType = "code id_token";
options.Scope.Add("openid");
options.Scope.Add("roles");
options.Scope.Add("profile");
options.Scope.Add("offline_access");
options.Scope.Add("phone_number");
options.SignInScheme = "Cookies";
options.GetClaimsFromUserInfoEndpoint = true;
options.SaveTokens = true;
options.TokenValidationParameters = new TokenValidationParameters
{
NameClaimType = "name",
RoleClaimType = "role"
};
        });

}
public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
{
app.UseAuthentication();
}
`

I know there are a lot of changes - but at this point you need to raise them with Microsoft. This is not our middleware.
We will update the samples when we think the time is ready - until then - welcome to the bleeding edge ;)


Cloud Native Apps

The link provided for "tightly coupled" in the Cloud Native Apps page does not seem to be focusing correctly. The correct link for tightly coupled architecture articles is https://glossary.cncf.io/tightly-coupled-architecture/.
link: https://glossary.cncf.io/cloud-native-apps/

issue verified .

I would like to take on this issue, if it is still open

@ibrahimkedir10  I guess no one is working on this issue  , you can go ahead .

Go ahead and work on this issue @ibrahimkedir10

@Mohiit70 nice catch :) thanks. Will assign @ibrahimkedir10

okay will do. @kumarankit999 @asem-hamid


[Enh]: enable sum_horizontal to work for boolean (or non-numeric) values in pandas, pyarrow etc

Describe the bug
sum_horizontal works for boolean values only in polars and not in pandas and pyarrow.
Steps or code to reproduce the bug
For pyarrow
import pyarrow as pa
import narwhals as nw
df_pa = pa.table({"a":[True, True, False], "b":[False, False, False]})
df_nw = nw.from_native(df_pa)
nw.to_native(df_nw.select(nw.sum_horizontal(nw.all())))

>>>ArrowInvalid: Could not convert 0 with type int: tried to convert to boolean

For pandas
import pandas as pd
import narwhals as nw
df_pd = pd.DataFrame({"a":[True, True, False], "b":[False, False, False]})
df_nw = nw.from_native(df_pd)
nw.to_native(df_nw.select(nw.sum_horizontal(nw.all())))
	a
0	True
1	True
2	False

Expected results
Just as it works in polars:
import polars as pl
import narwhals as nw
df_pl = pl.DataFrame({"a":[True, True, False], "b":[False, False, False]})
df_nw = nw.from_native(df_pl)
nw.to_native(df_nw.select(nw.sum_horizontal(nw.all())))
sum
u32
1
1
0

Actual results
Either error in pyarrow: >>>ArrowInvalid: Could not convert 0 with type int: tried to convert to boolean
or this in pandas
	a
0	True
1	True
2	False

Please run narwhals.show_version() and enter the output below.
System:
    python: 3.10.12 (main, Sep 11 2024, 15:47:36) [GCC 11.4.0]
executable: /usr/bin/python3
   machine: Linux-6.8.0-45-generic-x86_64-with-glibc2.35

Python dependencies:
     narwhals: 1.9.0
       pandas: 2.2.1
       polars: 0.20.31
         cudf:
        modin:
      pyarrow: 16.1.0
        numpy: 1.26.4

Relevant log output
No response

I would aim to avoid doing implicit casting for the user and from our side add a warning that sum_horizontal is for numeric datatypes (e.g. in polars that works for strings as well, but not in narwhals).
The user can always explicitly cast to a numeric datatype before summing:
@nw.narwhalify
def func(df):
    return df.select(
-         nw.sum_horizontal(nw.all())
+         nw.sum_horizontal(nw.all().cast(nw.UInt8()))  # Or whatever datatype
    )

I would not have a problem with having a subset of polars in this particular case

Yeah, let's unify the output and add the warning. Anyways, I think it's a handy feature to sum booleans. Could you explain in more detail why would you like to avoid it (asking  because I'm curious)?

Yeah, let's unify the output and add the warning. Anyways, I think it's a handy feature to sum booleans. Could you explain in more detail why would you like to avoid it (asking because I'm curious)?

Maybe it is simpler than expected and we could get away with it with:
def cast_if_boolean(s: PandasLikeSeries) -> PandasLikeSeries:
    return (
        s.cast(self._dtype.UInt8())
        if s.dtype == self._dtype.Boolean()
        else s
    )

and then
def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
-    series = (s.fill_null(0) for _expr in parsed_exprs for s in _expr._call(df))
+    series = (s for _expr in parsed_exprs for s in _expr._call(df))
+    series = (s.pipe(cast_if_boolean).fill_null(0) for s in series)
    return [reduce(lambda x, y: x + y, series)]

Thoughts on this?

I think implicit casting is fine, so long as the rules are well-defined and documented and are applied consistently - for example, what happens when summing two Boolean series? (Can't check right now as I'm on my phone)

If you mean in polars, then nulls are propagated on series, but considered as zero in sum_horizontal - so I think the approach above is relevant:
import polars as pl

s1 = pl.Series([True, True, True, False, False, False,  None, None, None])
s2 = pl.Series([True, False, None, True, False, None, True, False, None])

s1 + s2

shape: (9,)
Series: '' [u32]
[
        2
        1
        null
        1
        0
        null
        null
        null
        null
]

df = pl.DataFrame({"s1": s1, "s2": s2})
df.select(pl.sum_horizontal("s1", "s2"))

shape: (9, 1)
┌─────┐
│ s1  │
│ --- │
│ u32 │
╞═════╡
│ 2   │
│ 1   │
│ 1   │
│ 1   │
│ 0   │
│ 0   │
│ 1   │
│ 0   │
│ 0   │
└─────┘

thanks! i think we should take our time with this one and have a broader discussion about upcasting in other operations, i'm not sure we're totally consistent at the moment


Vaadin 24.4 support

This add-on doesn't appear to be compatible with Vaadin version 24.4+.

Could be related to this error:
There seems to be an error in Vaadin Combo Box: comboBox2.clearCache is not a function


Update pybabel files and localizations.

@atalyaalon - can we merge this one after rebase?

@idosavion sure, do you want to resolve conflicts?


[Test enhancement] Correlate integration test nodes with log output files

Background
If integration tests are run with the -logoutput flag (this happens automatically during make itest) then each node that is created during the tests is adding its log output to a file named outputX.log, where X is the node's node ID.
The number of nodes used during integration tests are starting to become very numerous, and it is hard to know for sure which file corresponds to which node.
Steps to completion

[ ] Make the NewNode method take a name string parameter. (E.g. we would pass "Carol" here: https://github.com/lightningnetwork/lnd/blob/c54a91f44dc4717d2be0c210ab0e4a1a2a1cfb79/lnd_test.go#L537:20)
[ ] When the log file is created (https://github.com/lightningnetwork/lnd/blob/c54a91f44dc4717d2be0c210ab0e4a1a2a1cfb79/lntest/node.go#L257), print the name of the node, the public key and the filename to stdout.

Taking a crack at this for my first issue.

@tyzbit see the linked PRs above.

Sorry, @tyzbit, I should have commented here that I was working on that...

Fixed by #1139.


[COOK-2581] database cookbook mysql libraries are not using my.cnf settings

https://tickets.opscode.com/browse/COOK-2581

That's a great patch. I also would like support of my.cnf files in this cookbook.
If CLA is the only problem, I can open same pull request from myself, because I have signed it.
What do you think? Maybe @jesseadams have signed it in a meanwhile?


Support logprobs for ChatCompletionRequest in openai api server?

This would be great to have, if possible.
E.g. python -m vllm.entrypoints.openai.api_server --model meta-llama/Llama-2-7b-hf  and
from openai import OpenAI

# Modify OpenAI's API key and API base to use vLLM's API server.
openai_api_key = "EMPTY"
openai_api_base = "http://localhost:8000/v1"
client = OpenAI(
    api_key=openai_api_key,
    base_url=openai_api_base,
)
completion = client.completions.create(model="meta-llama/Llama-2-7b-hf",
                                      prompt="Hello!",
                                      logprobs=5)
print("Completion result:", completion)

works but python -m vllm.entrypoints.openai.api_server --model meta-llama/Llama-2-7b-chat-hf
from openai import OpenAI

# Modify OpenAI's API key and API base to use vLLM's API server.
openai_api_key = "EMPTY"
openai_api_base = "http://localhost:8000/v1"
client = OpenAI(
    api_key=openai_api_key,
    base_url=openai_api_base,
)
completion = client.completions.create(model="meta-llama/Llama-2-7b-chat-hf",
                                      messages= [{'role' : 'user', 'content': "Hello!"}],
                                      logprobs=5)
print("Completion result:", completion)

does not.
For some reason log probs are currently only set up for completions end points, not chat end points. I think the fix would simply entail changing serving_chat.py link to incorporate log probs like serving_completion.py does link.
Thanks!

Closed by https://github.com/vllm-project/vllm/pull/2918


added template path in compile result

Twig.Template.prototype.importFile uses current template's path to include sub-templates.
There was a bug when loading a sub-template while not in a browser context.

:+1:

/cc @dane-harnett


Add setup.py

Add setup script to make jenkins-cli an installable python package with commandline entrypoint.
Update readme with install steps.

Resolves #7 and progresses #8 :)

I missed this PR somehow. I will merge it tomorrow.

Thank you for your PR, everything looks great.
But why do you think we need to rename console command to "jenkins-cli"? "jenkins" is shorter and i didn't found any conflicts.

True, there doesn't seem to be any conflicts using just "jenkins"; I've pushed a commit reverting the change.

I will fix import issue on the master branch


Add a helper for nonconflicting, multihost-safe filenames

Since we entered the realms of multihost and parallel executions of phases, we need filenames that, when used by a phase on multiple guests or by one plugin executed multiple times, would allow for now race conditions. We cannot afford a phase overwriting a script wrapper or guest topology.
There are already two places where such files are constructed, two more are in pending pull requests, one is clearly missing, and more will be needed when we start exposing guest facts to guest-setup playbooks. Or to prepare/feature plugin.
So, to avoid confusion about how such a file should be called, there's a helper function. If we ever get Pyright, together with a NewType we might be able to prevent using non-unique filenames where safe ones are needed.
Patch requires a bit of refactoring of guest topology saving, but nothing serious.
Pull Request Checklist

[x] implement the feature
[x] write the documentation

Thanks for the cleanup! @happz, anything else from the check list you still keep as a todo item or everything done?

Not really, no. Rebased, fixed the conflict, and we're good to go. I believe we will cover this once we start moving tmt-generated files - test wrapper, AVC logs, guest logs, etc. - into a directory as we discussed recently, that will offer plenty of opportunities to verify all files are named correctly.


Added the code of Spiral Display in Gfg implement in Java

Description
This is the code of the Spiral display in Java. With required comment
Fixes #(211)
The java implementation is done by me.
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas

@Amit366 @Ayush7614 Please review the code.

@Amit366 Can you tell me? What is wrong?

@Amit366 @Ayush7614 Please review the code.


fix: remove pointless function

fullCommitMessageText just repeats the commit message in a convoluted way for no reason

/cc ankitm123 tomhobson babadofar


[Doc] update docs navigation & loading chapter

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[X] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test


Validation error for custom validation is not working

Custom validation message is not being rendered if we apply multiple validations to the same field and specify error messages using validationErrors property object. To overcome the issue we have to provide default error message using validationError property.
Reference of bug filed against the formsy repo: https://github.com/formsy/formsy-react/issues/21

Deployed on dev and verified.


Fix typos: "persistant" should be spelled "persistent"

The names of the config values "persistant_froglins_lay_persistant_froglin_eggs" and "players_place_persistant_froglin_eggs" shouldn't be touched until 1.17 though as changing them would reset the configs of existing saves

Fixed in 1.17.1-<IP_ADDRESS>


api: documentation with Open API 3.0

provide the necessary API documentation for the REST-Endpoints
getting started: https://www.baeldung.com/spring-rest-openapi-documentation
URL zur HTML-Seite der API-Documentation: http://localhost:8080/api/swagger-ui
Der Endpoint /api/domain ist vollständig annotiert
TODO alle /api  und /info Endpoints enstprechend mit Annotationen beschreiben.

Hi are you still looking for documentation help? I would like to contribute to this project.

Hello. Do you still need documentation help?

Thank you for your help offerings. We are nearly done with the API documentation. We wanted to do it ourselves to learn how to use and parameterize OpenAPI / Swagger.

Well done.
On Wed, Oct 5, 2022 at 6:40 AM Robert Stephan @.***>
wrote:

Thank you for your help offerings. We are nearly done with the API
documentation. We wanted to do it ourselves to learn how to use and
parameterize OpenAPI / Swagger.
—
Reply to this email directly, view it on GitHub
https://github.com/ubrostock/purl_server/issues/35#issuecomment-1268259685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3CNBP6YBLCEJ4PRWPAV5XLWBVLLLANCNFSM56P2EG2Q
.
You are receiving this because you commented.Message ID:
@.***>


Common names

I'm guessing the names used are the game's internal monster code names, however it's quite inconvenient for a modder to have to guess or go in and test every spawn--is there any chance you can atleast add the official aliases in the mod e,g, Crawler -> aka Thumper
This would make things more user-friendly imho.

This is a good idea, these will added in the future.

It is currently a bit difficult to use the player friendly names, since they don't get loaded until the player is in the ship, at which point it is a bit too late to capture the default config values to save. For now, here is a dictionary for each vanilla enemy type:

BaboonHawk -> Baboon Hawk
Blob -> Hygrodere
Centipede -> Snare Flea
Crawler -> Thumper
DocileLocustBees, RedLocustBees -> Roaming Locusts
DoubleWing -> Manticoil
DressGirl -> Ghost Girl
Flowerman -> Bracken
ForestGiant -> Forest Keeper
HoarderBug -> Hoarding Bug
Jester -> Jester
LassoMan -> Lasso Man
MaskedEnemyPlayer -> Masked
MouthDog -> Eyeless Dog
Nutcracker -> Nutcracker
Puffer -> Spore LIzard
SandSpider -> Bunker Spider
SandWorm -> Earth Leviathan
SpringMan -> Coil-Head

Hopefully it is not too inconvenient to memorize each enemy type.


Add Swaps Metrics ✨

We can leverage the new starknet.events API to display enhanced on-chain analytics
I've simply added a basic use case of this displaying the total number of swaps done on the testnet.
What could be added from there :

[ ] Number of NFTs minted
[ ] Number of bridgooors
[ ] Project/domain specific analytics
[ ] Display evolution as graphs

Close for now but may be useful later and reopened if that's the case.


cos -> cosd + unit test

@gostevehoward @rcthomas
So now I think that the distance formula with cos changed to cosd is correct. Pixel-scale must only refer to the scale of the pixels at declination 0. It isn't constant across declinations. I'd appreciate you two look over my unit test to confirm my latest thinking.

Good point, I reordered the commits--first unit test, then bug fix--to show it fails without the bug fix.
Btw, there may be some other places where we're converting from arc seconds to pixel scale without accounting for the declination. For computing gal_scale, for example, in Stripe82Score.jl. Because Stripe 82 is near the equator (where cos(dec) is about 1) we've probably been able to get away with it so far.


using yoda condition for consistencies

github seems doesn't show PR as merged, seems because of merge --no-ff with add "Close #PRnumber", probably change with "Merge #PRnumber" so it will shown as merged ?

@weierophinney continue my previous comment, it seems merge --no-ff with message "Close #PRnumber" not the reason why PR shown as closed (not merged ) as other PRs by you that shown as merged. not sure if related with rebase

I didn't rebase. No clue why it's not showing properly.
On Aug 10, 2015 6:34 PM, "Abdul Malik Ikhsan"<EMAIL_ADDRESS>wrote:

@weierophinney https://github.com/weierophinney continue my previous
comment, it seems merge --no-ff with message "Close #PRnumber" not the
reason why PR shown as closed (not merged ) as other PRs by you that shown
as merged. not sure if related with rebase
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-expressive/pull/41#issuecomment-129646805
.


Tech story [M3-6795]: Consolidate Link & ExternalLink

Description 📝
One component to rule them all! 💍
This PR refactors the Link component so it can be used for all three use cases:

a relative URL, which will render a Link component from React Router.
an absolute, same domain/subdomain URL (ex: linode.com, akamai.com) that will render an a tag with target="_blank".
an absolute URL with the external prop, which will render an a tag with target="_blank" and an external link icon.

Preview 📷
Visual changes should only pertain to the presence (or not) of some external links. Remember that links opening in a new tab but directing a user to an Akamai or Linode domain/subdomain should not feature an external link icon
How to test 🧪
I can ask for reviewers to verify every link modified by this PR, however the areas to look for visual regressions or bad links should be:

Empty state landing pages
Docs Links on create pages (next to create buttons) (note - they are closer to the button now, which is intentional)
Help & Support area pages
Profile area
Storybook Link stories

@bnussman-akamai @mjac0bs thanks so much for the reviews!
I addressed all feedback and also fixed the wrong markup on the search result page


Improve mobile support

It would be great to see improved support for smaller devices. I'd suggest adding the META viewport tag like so:
<meta name="viewport" content="width=device-width, initial-scale=1">
This tag is copied straight from the Bootstrap getting started file.

Thanks. I agree. Expect it in next update.

And how could I now activate a responcive desgin already?

Hi AirJordan6811,
While waiting for a fix, you can use below code in your json file. It'll update viewport meta tag for the client and bootstrap will work as it should be.
"client_startup_code":"var viewPortTag=document.createElement('meta'); viewPortTag.id='viewport'; viewPortTag.name = 'viewport'; viewPortTag.content = 'initial-scale=1 maximum-scale=1 user-scalable=0'; document.getElementsByTagName('head')[0].appendChild(viewPortTag);",

Fixed. Enjoy! :)

Just update meteor-kitchen to latest version.
P.S. I reopened this issue, please close it if it works correctly. Thanks.

It's not working. I have updated meteor-kitchen and it's 0.9.30 now.

Strange, it adds <meta name="viewport" content="width=device-width, initial-scale=1">. Are you sure it doesn't work? (works for me).

is 0.9.30 the latest version? if yes it's not working for me, i dont see any meta tag at the inspector.
I am using mac os x btw.

Ooops, I didn't upload latest version. OK, I'l upload latest one in few hours...

@kadirerdogan fixed. Please close this issue if it's OK now. Thanks!


Script is not compatible with your computer

I have installed Industrial IoT solution before, but on a new tenant I want to install the environment with the standard deployment script.  But when the registration of AAD begins, I get this error:

The user is owner of the subscription and is global administrator of AAD. I am running on Windows 11, latest bits and running AZ CLI 2.34.1

@karok2m do you have an idea what can be the reason for this issue? @rploeg which version of the deployment script have you used.

The version of two days ago --> main. I have tried it on another Windows 11 machine and there it was working. So it looks like a problem on one of my machines.


Support Node.js 7.x

Added the options for version 7.
All tests passed.

Looks like AppVeyor doesn't support it yet, so well need to wait. Thanks for the effort, though!


append the --no-sandbox when running with root user

Description
The latest electron requires --no-sandbox argument if running with root user
Additional context
N/A

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@cnjack
Thank you for your contribution.
I think this is a bad choice because development with or without sandbox enabled makes a big difference. Developers are not clear about this setting, which will lead to some unknown problems after packaging. It should be up to the developer to clearly enable or disable it through code settings.


bad code style

https://github.com/apache/incubator-apisix/pull/1167/files#diff-62edadffc237f13dc28a694080d293a8R543
we need a better style, here is an example:
local function system_dns_resolver()
    local file, err = io.open("/etc/resolv.conf")
    if err then
        return nil, err
    end

    local dns_addrs = {}
    ... ...

    file:close()
    return dns_addrs
end

Hi, @membphis  I would like to work on this issue. Is it only the function that you pointed or the whole file we have to refactor?

Hi, @membphis I would like to work on this issue. Is it only the function that you pointed or the whole file we have to refactor?

Fix this function first.
If you can find more other similar points, welcome to fix them together.
I have assigned this issue to you. ^_^

@membphis  quick question am new to lua is there a starting guide for developers to set up dev environment. I wanted to test the modified function.


Disassembly Protocol Does Not Preserve Vertical Slab Orientation

Mod Name
Quark + Vertical Slabs Compat
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

[X] I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version
1.19
Mod Loader
Forge
Issue description
Just an issue of compatibility, game does not break. It would be great if vertical slab orientation was checked for and preserved. It seems like endemic Quark v-slabs stay as they should be, only compat slabs break.
Issue reproduction
Place V-Slab-Compat slabs on ship, assemble, turn 90 degrees, disassemble.
Logs
No response

I think this might be a duplicate of #185


Remove iframe borders on Vimeo embed

Vimeo embed has border around iframe. It should be removed.
https://busy.org/design/@design-guy/graffiti-house-branding

Fixed in https://github.com/busyorg/busy/pull/1052


Create HelloWorld.ex

For issue  #249

This code is not in Euphoria programming language.
Can you fix or explain it ?

This code is not in Euphoria programming language.
Can you fix or explain it ?

Okey , I am fixing this .

Hey @agnilondapakou ,
The code I provided is  "Hello world" program in Euphoria programming language.
Please check --> https://www.educative.io/answers/getting-started-in-the-euphoria-programing-language resource . You can check the code here too.
Thank you .


Conditional logging?

Hi there!
Awesome work, this is a super useful library. I was wondering how you'd feel about making it so this library only generates logs when prompted by a config? Using it programmatically is hard right now b/c it dumps info into process.write, which makes writing a CLI tool that uses this tool internally extra noisy.
I can probably find time to contribute if you think this is a decent idea.
Thanks for your time,
Brekk

process.write notifies the user that the program is executing (kind of progress bar).
"\r" rewrites the console. I doubt, it floods the user's console. (you may correct me).
Presently, "--verbose" dumps the log into console. it might be a good idea to dump them into a file.


Integration tests for Kubeflow Bundling with ACK and KFP Components

Description of your changes:
Added two integration tests for Kubeflow Bundling -

A Simple ACK test which creates a profile, spins up a notebook and checks that the trainingjob CRD is installed
A KFP test which runs the sample SageMaker training pipeline and makes sure it is successful - also uses profile.

TODO:
Permissions are broader than they need to be at the moment. The SageMaker and S3 accesses are added to both Roles, can be streamlined.
Testing:

[ ] Unit tests pass
[ ] e2e tests pass
Details about new tests (If this PR adds a new feature)
Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this PR, creating a new one since there have been significant changes and needed a new branch.


Sensor dimensions should be in microns

The model specifies sensor dimensions in mm with two decimal places.
This is problematic since decimal numbers cannot be represented exactly in binary floating point arithmetic.
Suggest changing the model to encode sensor dimensions in whole microns.
https://smpte.sharepoint.com/:x:/s/RISOSVP/EeSIPlCOJjZCkoju3jjAu74BjcAqazHYkbx-rMXcv6wV-w?e=PJLs3D

Specification updated to use microns.


Crash to desktop after removing headset

Anytime I remove my Quest Pro and then put it back on to return to DCS the game will crash to desktop with Meta Foveated installed. My headset should be set to not pause on removal and my power down is set for 15 minutes instead of the default 15 seconds.
dcs.log

I haven't gotten any other report of this issue, so I'm inclined to think that it's very specific to your set up.
I suspect this might be a side effect of developer mode (aka a Meta bug?).
Try sending me the Meta-Foveated log file instead.
And you might have better luck posting on this thread:
https://forum.dcs.world/topic/318095-foveated-rendering-support-for-dcs/page/8/#comments

Thanks, I will post on the DCS forum thread, I must have missed that.

You actually did the right thing opening an issue here, but missed attaching the correct log. Per the discussion on the forum (and your log over there) it looks like you are not alone.
I'll take a closer week mid-July when some time opens up for me.

Per DCS forum - was this issue resolved after you re-enabled the guardian?

I'll give this a try soon, I've been away most of the month.

I'm happy to report that there are no more crashes after taking the Quest Pro off and putting it back on again when using version 1.0.1. I have tried with Guardian enabled and disabled, as well as Turbo Mode in the settings.cfg on and off.

This was fixed in 96aa408f1f30fbb05ba2976000d7a612a3d609c1.


Command failed: ninja;-v when building FreeImage

CMakeOutput.log
config-x64-windows-out.log
Emmm.. my building system is MSBuild (VS2017) latest version.
Operating System: Windows 10 Pro 1809 (17763.475)
Vcpkg version: 2018.11.23 (keep sync with the repo)

[1/2] cmd /c "cd ../../x64-windows-dbg && "C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe" "C:/Tools/vcpkg/buildtrees/freeglut/src/freeglut-3-38e9d76ee2" "-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Visual Studio 15 2017 Win64" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Tools/vcpkg/packages/freeglut_x64-windows/debug""
FAILED: ../../x64-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x64-windows-dbg && "C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe" "C:/Tools/vcpkg/buildtrees/freeglut/src/freeglut-3-38e9d76ee2" "-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Visual Studio 15 2017 Win64" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Tools/vcpkg/packages/freeglut_x64-windows/debug""
CMake Error at C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake:133 (file):
Syntax error in cmake code at
C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake:133

when parsing string
$ENV{PROGRAMFILES\(x86\)}

syntax error, unexpected cal_SYMBOL, expecting } (19)
Call Stack (most recent call first):
C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/share/cmake-3.14/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:2 (PROJECT)
-- Configuring incomplete, errors occurred!
[2/2] cmd /c "cd .. && "C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe" "C:/Tools/vcpkg/buildtrees/freeglut/src/freeglut-3-38e9d76ee2" "-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Visual Studio 15 2017 Win64" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Tools/vcpkg/packages/freeglut_x64-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe" "C:/Tools/vcpkg/buildtrees/freeglut/src/freeglut-3-38e9d76ee2" "-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Visual Studio 15 2017 Win64" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Tools/vcpkg/packages/freeglut_x64-windows""
CMake Error at C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake:133 (file):
Syntax error in cmake code at
C:/Tools/vcpkg/scripts/buildsystems/vcpkg.cmake:133

when parsing string
$ENV{PROGRAMFILES\(x86\)}

syntax error, unexpected cal_SYMBOL, expecting } (19)
Call Stack (most recent call first):
C:/Tools/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/share/cmake-3.14/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:2 (PROJECT)
-- Configuring incomplete, errors occurred!
ninja: build stopped: subcommand failed.

You seem to have a complete mess, with a dynamic and static library
"-DVCPKG_CRT_LINKAGE=dynamic"
"-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON"
x64-windows- static-md /debug/lib/lzma.lib
syntax error, unexpected cal_SYMBOL, expecting } (19)
CMakeLists.txt:2 (PROJECT)

#6416

You seem to have a complete mess, with a dynamic and static library
"-DVCPKG_CRT_LINKAGE=dynamic"
"-DFREEGLUT_BUILD_STATIC_LIBS=OFF" "-DFREEGLUT_BUILD_SHARED_LIBS=ON" "-DFREEGLUT_BUILD_DEMOS=OFF" "-DINSTALL_PDB=OFF" "-DBUILD_SHARED_LIBS=ON"
x64-windows- static-md /debug/lib/lzma.lib
syntax error, unexpected cal_SYMBOL, expecting } (19)
CMakeLists.txt:2 (PROJECT)
there is already a patch, but a mix with libraries ...
#6420

Thanks a lot!! Emmm.. sorry but the mess is my fault. I set the triplet to my DIY incorrect x64-windows-static-md and this is not the thing.  Yeah, the issue I have encountered is the "PROGRAMFILES(x86)" environment variable as you mention above.

#6416

Thanks for your reply. I'm trying the merged solution.

Hi @mingyu92, PR #6420 has been merged, does the issue still occur? I installed freeImage successfully with VS2017 and VCPKG latest source.

@mingyu92, thanks for posting this issue! Currently freeImage build successfully now, please reopen it if it still be an issue for you.


Delphi XE3 build failed [Pascaloin Wallet GUI-Classic]

Trying to build the GUI-Classic in Delphi XE3 fails because of the "Decimalseparator" and "ThousandSeparator"  in UAccounts.pas
Changed to "formatsettings.ThousandSeparator" and "formatsettings.Decimalseparator" solved the problem.

@CFTechno ,
Thanks for the report.
currently the codebase is being managed with Delphi 2010 and Lazarus.
Whether the codebase will be moved fully to Lazarus or Improved to compile both on Modern Delphi and Lazarus is Undecided at the moment.

This issue is fixed in this commit:
https://github.com/SkybuckFlying/PascalCoin/commit/90b91f3adffeb5d58404d4dd7b62471075b118e0
Doesn't get any more exact then that ! ;)
Check the Delphi docs ! ;)


[bst-1] checks for push in a pull only remote

bst 1 tries to check whether the remote supports asset push even if the remote is not configured for push. This combined with a grpcio bug (that produces weird errors when getting http 404) means that initializing remotes fails with an error like
[--:--:--][][] WARNING Failed to initialize remote https://cache.freedesktop-sdk.io:11001: Stream removed

This is surprising, you'd think we would notice this sooner, since pull-only remotes are used with great frequency.
Can you check if this is fixed by #1725 ?
I'm curious where the message "Stream removed" comes from.

Ok, something I forgot to mention here: it only happens with grpcio >= 1.46 and that's why I think it's a bug in grpcio that exposes it.

This is apparently fixed by #1725


Course has all shifts incorrectly shown as being lectured all in the same campus

Description of the issue:
Picked course shows all lectures and labs as being lectured on one of the campus, despite some of them being lectured on the other campus.
Additional details:

Initially I found only one course,ADSI/AOBD,exhibiting this specific behavior so I didn't know for sure if the problem extended to others, but there is at least another one where the same behavior is shown,SEC/HDS/SDTF.
All the testing was done on Firefox (version 122.0.1) on private and normal tabs with both showing the same behavior

Reproduction steps:

Pick a degree that has one of the affected courses, for ADSI/AOBD lets pick MEIC-T as an example
Pick the course ADSI/AOBD
All possible lectures and labs are displayed and we can see that every shift shown is supposedly being lectured at campus Alameda which is incorrect as some of them are lectured on the campus Tagus Park

Problem:
Fenix's v2 api does not return the TopLevelSpace (campus) as opposed to v1. As such, the campus is assumed to be the one from the first degree associated with the class. This assumption is incorrect.
Possible Solution:
To keep using v2, another api query must be made, in order to retrieve the campus where the lecture is held.
I'm working on a fix using this approach

Looking into this!


Memory leaks that occurs on hot-reloads

Link to reproduction
No response
Describe the Bug
When working on a development in Next.js + PayloadCMS, after some hot-reloads I'm getting error about exceeding maximum allocated memory for Heap. It is currently set to 4GB. When monitoring a process using HTOP - you can clearly see that RAM usage is increasing until it crashes.
This bug started affecting my workflow right after upgrading PayloadCMS to the latest version(from 1.14 to 2.0)
To Reproduce
Simply start the development server and make some changes in code and/or create a page in PayloadCMS and keep editing/saving this page.
Payload Version
2.0.12
Adapters and Plugins
bundler-webpack, db-mongodb, s3Adapter, cloudstorage, seo, redirects,

@rafalnawojczyk I am unable to reproduce. If you are able to share a reproducible repo I will gladly check it out. For now I am going to close this issue. Please let me know if you can provide a reproduction though!


Use 'proposal' label to identify proposals that are for voting

This avoids pollution of the proposal list (and blocking build statuses) for things like dependency updates, design changes, etc.

The label should be auto-created by the app, not by hand.

In progress, the app now auto adds labels, just need to filter anything without it out of proposal process next.

The label is created, but not added to PRs at the moment, so something is wrong...


Azure Devops - Unable to update hosted agent from v2.202.0 to v2.204.0

Updating the agent though DevOps page in the Agent Pool section does not update the agent to the latest version. It results in following error during the update and settles on the current version without any update.
C:\agent_work_update\bin\Agent.Listener.dll does not have a valid MS signature.
at Microsoft.VisualStudio.Services.Agent.Listener.InstallerVerifier.VerifyFileSignedByMicrosoft(String filePath, Tracing trace, String expectedEKU)
Event viewer shows this error
An error occurred: Authenticode validation of agent assemblies failed.
Agent and Worker's Diagnostic Logs
Agent Version and Platform
Installed version of hosted agent ? 2.202.0
OS of the machine running the agent? Windows Server 2008 R2
Azure DevOps Type and Version : dev.azure.com
[2022-07-19 14:46:23Z INFO RSAEncryptedFileKeyManager] Loading RSA key parameters from file C:\agent.credentials_rsaparams
[2022-07-19 14:46:23Z INFO RSAEncryptedFileKeyManager] Loading RSA key parameters from file C:\agent.credentials_rsaparams
[2022-07-19 14:46:23Z INFO VisualStudioServices] AAD Correlation ID for this token request: Unknown
[2022-07-19 14:46:23Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2022-07-19 14:46:23Z INFO AgentServer] Establish connection with 60 seconds timeout.
[2022-07-19 14:46:23Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2022-07-19 14:46:23Z INFO AgentServer] Establish connection with 60 seconds timeout.
[2022-07-19 14:46:23Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2022-07-19 14:46:23Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2022-07-19 14:46:23Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2022-07-19 14:46:23Z INFO MessageListener] VssConnection created
[2022-07-19 14:46:24Z INFO MessageListener] Session created.
[2022-07-19 14:46:24Z INFO Terminal] WRITE LINE: 2022-07-19 14:46:24Z: Listening for Jobs
[2022-07-19 14:46:24Z INFO JobDispatcher] Set agent/worker IPC timeout to 30 seconds.
[2022-07-19 14:49:42Z INFO RSAEncryptedFileKeyManager] Loading RSA key parameters from file C:\agent.credentials_rsaparams
[2022-07-19 14:49:42Z INFO MessageListener] Message '753' received from session '3e611466-0279-43bf-926e-aa53d94d240e'.
[2022-07-19 14:49:42Z INFO ConfigurationStore] HasCredentials()
[2022-07-19 14:49:42Z INFO ConfigurationStore] stored True
[2022-07-19 14:49:42Z INFO CredentialManager] GetCredentialProvider
[2022-07-19 14:49:42Z INFO CredentialManager] Creating type OAuth
[2022-07-19 14:49:42Z INFO CredentialManager] Creating credential type: OAuth
[2022-07-19 14:49:42Z INFO RSAEncryptedFileKeyManager] Loading RSA key parameters from file C:\agent.credentials_rsaparams
[2022-07-19 14:49:42Z INFO Agent] Refresh message received, kick-off selfupdate background process.
[2022-07-19 14:49:42Z INFO SelfUpdater] Version '2.204.0' of 'agent' package available in server.
[2022-07-19 14:49:42Z INFO SelfUpdater] Current running agent version is 2.202.0
[2022-07-19 14:49:42Z INFO SelfUpdater] An update is available.
[2022-07-19 14:49:42Z INFO Terminal] WRITE LINE: Agent update in progress, do not shutdown agent.
[2022-07-19 14:49:42Z INFO Terminal] WRITE LINE: Downloading 2.204.0 agent
[2022-07-19 14:49:42Z INFO HostContext] Well known directory 'Bin': 'C:\agent\bin'
[2022-07-19 14:49:42Z INFO HostContext] Well known directory 'Root': 'C:\agent'
[2022-07-19 14:49:42Z INFO HostContext] Well known directory 'Work': 'C:\agent_work'
[2022-07-19 14:49:42Z INFO SelfUpdater] Attempt 1: save latest agent into C:\agent_work_update\agent1.zip.
[2022-07-19 14:49:42Z INFO SelfUpdater] Download agent: begin download
[2022-07-19 14:49:44Z INFO SelfUpdater] Download agent: finished download
[2022-07-19 14:49:46Z INFO SelfUpdater] Checksum validation succeeded
[2022-07-19 14:49:48Z INFO SelfUpdater] Finished getting latest agent package at: C:\agent_work_update.
[2022-07-19 14:49:48Z INFO SelfUpdater] File C:\agent_work_update\bin\Agent.Listener.dll has a valid authenticode signature.
[2022-07-19 14:49:48Z ERR  SelfUpdater] Microsoft.VisualStudio.Services.Agent.Listener.VerificationException: File C:\agent_work_update\bin\Agent.Listener.dll does not have a valid MS signature.
at Microsoft.VisualStudio.Services.Agent.Listener.InstallerVerifier.VerifyFileSignedByMicrosoft(String filePath, Tracing trace, String expectedEKU)
at Microsoft.VisualStudio.Services.Agent.Listener.SelfUpdater.VerifyAgentAuthenticode(String agentFolderPath)
[2022-07-19 14:49:48Z INFO JobDispatcher] Shutting down JobDispatcher. Make sure all WorkerDispatcher has finished.
[2022-07-19 14:49:48Z ERR  Terminal] WRITE ERROR: An error occurred: Authenticode validation of agent assemblies failed.
[2022-07-19 14:49:48Z ERR  AgentProcess] System.Exception: Authenticode validation of agent assemblies failed.
at Microsoft.VisualStudio.Services.Agent.Listener.SelfUpdater.DownloadLatestAgent(CancellationToken token)
at Microsoft.VisualStudio.Services.Agent.Listener.SelfUpdater.SelfUpdate(AgentRefreshMessage updateMessage, IJobDispatcher jobDispatcher, Boolean restartInteractiveAgent, CancellationToken token)
at Microsoft.VisualStudio.Services.Agent.Listener.Agent.RunAsync(AgentSettings settings, Boolean runOnce)
at Microsoft.VisualStudio.Services.Agent.Listener.Agent.RunAsync(AgentSettings settings, Boolean runOnce)
at Microsoft.VisualStudio.Services.Agent.Listener.Agent.RunAsync(AgentSettings settings, Boolean runOnce)
at Microsoft.VisualStudio.Services.Agent.Listener.Agent.ExecuteCommand(CommandSettings command)
at Microsoft.VisualStudio.Services.Agent.Listener.Program.MainAsync(IHostContext context, String[] args)

Hi @deal0f49-21!
We support Windows Server starting from version 2012
We are not supporting Windows Server 2008.
This problem is not reproduced on newer operating systems.
Is it possible in your case to upgrade to a newer version of Windows Server to meet our requirements?
Thank you

@deal0f49-21 let me close this issue as we are not supporting Windows Server 2008.
Please let us know if you have any questions.
Thanks


HL-154: data model for applicant terms

Description :sparkles:
Data model for applicant terms.
In order to implement approval of Terms of service later on, common functionality is in AbstractTermsApproval.
API with validation and more tests coming in another pull request.
Issues :bug:
HL-154
Testing :alembic:
backend/benefit/terms/tests/test_models.py
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #268 (85d6a2c) into develop (af112dc) will decrease coverage by 1.47%.
The diff coverage is 94.70%.

@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
- Coverage    95.63%   94.16%   -1.48%
===========================================
  Files          139      107      -32
  Lines         4720     3597    -1123
===========================================
- Hits          4514     3387    -1127
- Misses         206      210       +4

Impacted Files
Coverage Δ

backend/benefit/helsinkibenefit/settings.py
94.05% <ø> (ø)

backend/benefit/terms/tests/factories.py
87.17% <87.17%> (ø)

backend/benefit/terms/tests/conftest.py
92.30% <92.30%> (ø)

backend/benefit/terms/models.py
93.87% <93.87%> (ø)

backend/benefit/terms/admin.py
100.00% <100.00%> (ø)

backend/benefit/terms/apps.py
100.00% <100.00%> (ø)

backend/benefit/terms/enums.py
100.00% <100.00%> (ø)

backend/benefit/terms/migrations/0001_initial.py
100.00% <100.00%> (ø)

backend/benefit/terms/tests/test_models.py
100.00% <100.00%> (ø)

backend/shared/shared/audit_log/viewsets.py
46.96% <0.00%> (-43.94%)
:arrow_down:

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af112dc...85d6a2c. Read the comment docs.


redirect issue

when I click on facebook icone, a window open with this
Sorry, something went wrong.
We're working on getting this fixed as soon as we can.

the url seems to be the problem
https://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fveux-veux-pas.fr%2Ffr%2Fpetites-annonces-nord-pas-de-calais%2F-NOR1195919&display=popup&quote=** **
if I remove manually %20 it is working fine
i notice same problem with other network :
https://www.linkedin.com/shareArticle?mini=true&url=https%3A%2F%2Fveux-veux-pas.fr%2Ffr%2Fpetites-annonces-nord-pas-de-calais%2F-NOR1195919&title=Citroen C1&summary=** **

it seems it happens when data-desc is empty
data-desc=""


Updated .env.example file

Describe the bug
I'm trying to load up a localnet stack, but the env files are outdated. So far, I've noticed the PSQL_CONNECTIONS and ARCHIVAL_CHAINS are missing.
Also, aws creds are required. What do we need them for?

After providing these credentials (mocked the aws creds), the gateway server was able to load up..

I've updated these, thanks for reporting!


Mat4.rotate{x,y,z} SIMD implementation

SIMD implementation for mat4.rotate{x,y,z} functions.

Sorry for the delayed review. LGTM!

Thanks for the review :)


Focus event is triggered in Safari if React Cleave field is rendered after some action

I have an issue with triggering focus event on React Cleave field only in Safari if Cleave field is rendered async. In Chrome && FF works as expected.
Here is a quick demo with 5 Cleave fields and one regular text input:
https://jsfiddle.net/d49nmtvp/3/
Bug:
Browser: Safari 10.1.2 && Safari Technology Preview
Reproduce: go to https://jsfiddle.net/d49nmtvp/3/ with Safari and click show
Expected results: no focus triggered (all values .should be 0)
Actual result: focus is triggered for React Cleave fields (values are 1 for all fields expect plain input field)
It seems that setSelectionRange from https://github.com/nosir/cleave.js/blob/master/src/Cleave.react.js#L348 is triggering focus in Safari

This is also the case in IE11, so when you render many input fields they all get rapid focus in succession until the last one. If the last one is at the bottom of the page, the page ends up scrolled down to that element.

Any news on this?

I am facing the same issue. We are doing some validations onBlur , and since cleave triggers onFocus event of all fields , it also triggers the corresponding onBlur event , hence displaying error messages even before the user interaction.

A possible workaround would be to integrate the jQuery library instead of using the pre-built React component. Doing so, you can avoid triggering setSelectionRange in the offending handler.

Fix merged, and published in v1.0.2.
Could anyone please check if this issue still exists?

@nosir thank you very much :)
I just checked in Safari and it works as expected.

Awesome, big thanks to @bitionaire


NJ - ELR File Issues

Name: Mike Firkser
Email<EMAIL_ADDRESS>Please note the ELR errors in the attached emails.  Many ordering facility phone numbers are missing.  Please correct and resubmit.

Duplicate to 5537


Cannot read property 'get' of undefined

Issue Id: e85259db-8e69-737a-f9e6-fc52ba53838dVersions - 1.46.0Stack TypeError: Cannot read property 'get' of undefined/vs/workbench/contrib/extensions/browser/extensionsViews.ts#162:39 (call)/vs/base/common/event.ts#587:15 (fire)/vs/base/common/event.ts#152:14 (call)/vs/base/common/event.ts#587:15 (call)/vs/base/common/event.ts#74:96 (call)/vs/base/common/event.ts#587:15 (fire)/vs/platform/list/browser/listService.ts#542:26 (open)/vs/platform/list/browser/listService.ts#537:8 (onSelection)/vs/platform/list/browser/listService.ts#498:65 (call)/vs/base/common/event.ts#587:15 (call)/vs/base/common/event.ts#56:83 (call)/vs/base/common/event.ts#587:15 (call)/vs/base/common/event.ts#56:83 (call)/vs/base/common/event.ts#810:14    at e.fire (out/vs/workbench/workbench.desktop.mai

Dupe of https://github.com/microsoft/vscode/issues/93308


initial workflow for testing python

Creating github action to automatically run python tests on PRs

Test workflows are working


[Git workflow] - Stash all time (better for the new algo)

While debugging, you mentioned it would be good to perform stashing changes all the time so the new algorithm gets applied. This is a placeholder issue for that so we don't forget to fix it. Please take over and fill in details as you have a better idea of how it should go. 👍

Thanks man! Yeah the general idea is that if some commands change the formatting of the source code and then abort the commit (or user aborts it by terminating commands) it should remove the formatting. This isn’t possible unless the stashing and restoring runs every time.

I'm going to close for now since I can't decide if it's a good idea or not. Will evaluate over time.


Price Import reference resolution

Resolve references in price:

customerGroup
channel

@hajoeichler @emmenko @butenkor @salander please have a look.


Change annotation dependency scope to provided

Currently we are packaging in the annotation dependencies which conflict with Espresso. This is an issue tracking the change from compile to provided

Maybe I'm being silly but I couldn't find provided in java only projects as a dependency type.  I had to go with compileOnly https://blog.gradle.org/introducing-compile-only-dependencies
"In the Gradle model we consider tests to be a “consumer” of the production code. With this in mind, compile-only dependencies are not inherited by the test classpath. The intention is that tests, like any other runtime environment, should provide their own implementation, either in the form of mocks or some other dependency."
I think this should work

yeah compileOnly is the same as provided AFAIK

@digitalbuddha is this ticket still valid?

not sure will check

I think it's fine keeping them with a compile scope.
In theory, any androidTestCompile dependency can bring in a dependency with a version that conflicts with one of the dependencies we package in apollo.
So it's better to leave it to the user to fix through:
androidTestCompile ('.....'){
    exclude module: '...'
}

is it still valid?

Is this still a problem? @digitalbuddha You closed your own PR.

Not sure tbh. I never was able to get CI to pass after changing scope. Feel free to take a look at it.


Custom field Resolver when using Type Language.

I am planning to integrate GraphQL in the DirectUs which is a Headless CMS.
DirectUs allows users to manage their Database table from DirectUs App.
As the table schema can be modified on the fly (from the DirectUs App), I am using the Type language to define the GraphQL schema. We autogenerate the schema when any DB changes happen.
We already have REST API. So I am planning to warp the REST API with GraphQL.
For that, I need Custom field Resolver for each field in the type definition.
Kindly guide me, How to use the Custom field Resolver for each field, query, and mutation or how to extend the default field resolver while using Type Language.
Thanks.

Not sure it that's what you're looking for. You can set custom default resolver using fieldResolver config option, see http://webonyx.github.io/graphql-php/executing-queries/
And also custom resolver per field http://webonyx.github.io/graphql-php/type-system/object-types/#field-resolution

Hi @simPod
Thanks a lot for quick reply.
For the http://webonyx.github.io/graphql-php/executing-queries/ can you guide me on how to define the $fieldResolver in the below-suggested code?
use GraphQL\GraphQL;

$result = GraphQL::executeQuery(
 	$schema,
    $queryString,
    $rootValue = null,
    $context = null,
    $variableValues = null,
    $operationName = null,
    $fieldResolver = null, //Custom field Resolver when using **Type Language** to define the schema
    $validationRules = null
);

For the http://webonyx.github.io/graphql-php/type-system/object-types/#field-resolution, I am creating the GraphQL schema dynamically. I don't have the individual PHP class for each type in the schema where I can write the logic for data fetching as mentation on http://webonyx.github.io/graphql-php/data-fetching/.

@hemratna see this http://webonyx.github.io/graphql-php/data-fetching/#default-field-resolver
Just copy paste it into ur class and then you can start tweaking it for your needs.
class MyCustomResolver {

public function __invokable($source, $args, $context, \GraphQL\Type\Definition\ResolveInfo $info)
{
    $fieldName = $info->fieldName;
    $property = null;

    if (is_array($source) || $source instanceof \ArrayAccess) {
        if (isset($source[$fieldName])) {
            $property = $source[$fieldName];
        }
    } else if (is_object($source)) {
        if (isset($source->{$fieldName})) {
            $property = $source->{$fieldName};
        }
    }

    return $property instanceof Closure ? $property($source, $args, $context, $info) : $property;
}
}

then
$result = GraphQL::executeQuery(
 	$schema,
    $queryString,
    $rootValue = null,
    $context = null,
    $variableValues = null,
    $operationName = null,
    $fieldResolver = new MyCustomResolver(), // Rather inject it through DI, though
    $validationRules = null
);

Quickly typed it here on github but should work. You get the idea.

Is there any way not to use DI?
How can I pass the arguments to the
public function __invokable($source, $args, $context, \GraphQL\Type\Definition\ResolveInfo $info) from $fieldResolver = new MyCustomResolver()
Thanks a lot for such a quick response. 👍

@hemratna my example was without DI :)
Just pass anything that's invokable for $fieldResolver. It gets invoked by executor so those args are passed there by executor as well.

$result = GraphQL::executeQuery(
    $schema,
    $queryString,
    $rootValue = null,
    $context = null,
    $variableValues = null,
    $operationName = null,
    ANYTHING INVOKABLE HERE, preferable with following arguments: $source, $args, $context, \GraphQL\Type\Definition\ResolveInfo $info
    $validationRules = null
);```

Oh my bad.
I have to change the __invokable to __invoke on your refrence code.

Yes my bad, sorry. Will edit it.


error in 'make -c infer'?

when i make infer, there is an error message,can anyone help me?
infer# make -C infer
make: Entering directory '/home/rgos/infer/infer/infer'
make -C src clang
make[1]: Entering directory '/home/rgos/infer/infer/infer/src'
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
sed -e 's/@MAJOR@/0/g'
-e 's/@MINOR@/2/g'
-e 's/@PATCH@/0/g'
-e 's/@GIT_COMMIT@//g'
-e 's/@GIT_BRANCH@//g'
-e 's/@GIT_TAG@//g'
backend/version.ml.in > backend/version.ml
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
/home/rgos/infer/infer/scripts/check_clang_plugin_version.sh /home/rgos/infer/infer/../facebook-clang-plugin
SKIPPING the facebook-clang-plugins version check since
/home/rgos/infer/infer/../facebook-clang-plugin is NOT a Git repository
make[1]: *** No rule to make target '/home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd', needed by 'clang/clang_ast_t.ml'.  Stop.
make[1]: Leaving directory '/home/rgos/infer/infer/infer/src'
Makefile:19: recipe for target 'clang' failed
make: *** [clang] Error 2
make: Leaving directory '/home/rgos/infer/infer/infer'

Hi b0207191,
Could you try running make clean and then ./update-fcp.sh && ../facebook-clang-plugin/clang/setup.sh && ./compile-fcp.sh? Sounds like your clang plugin may be out of date.

thanks,
i retry 'running make clean and then ./update-fcp.sh && ../facebook-clang-plugin/clang/setup.sh && ./compile-fcp.sh'
it still failed on the step'make -c infer' with the following log:
make -C infer
make: Entering directory '/home/rgos/infer/infer/infer'
make -C src clang
make[1]: Entering directory '/home/rgos/infer/infer/infer/src'
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
sed -e 's/@MAJOR@/0/g'
-e 's/@MINOR@/2/g'
-e 's/@PATCH@/0/g'
-e 's/@GIT_COMMIT@//g'
-e 's/@GIT_BRANCH@//g'
-e 's/@GIT_TAG@//g'
backend/version.ml.in > backend/version.ml
mkdir -p ../_build-infer
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
/home/rgos/infer/infer/scripts/check_clang_plugin_version.sh /home/rgos/infer/infer/../facebook-clang-plugin
SKIPPING the facebook-clang-plugins version check since
/home/rgos/infer/infer/../facebook-clang-plugin is NOT a Git repository
atdgen -rec -t /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
atdgen -rec -j /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
atdgen -rec -v /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
cp -f -p /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast_proj.ml clang
cp -f -p /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast_proj.mli clang
cp -f -p /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/clang_ast_cache.ml clang
cp -f -p /home/rgos/infer/infer/../facebook-clang-plugin/clang-ocaml/clang_ast_main.ml clang
ocamlbuild -build-dir ../_build-infer -j 0 -I backend -I checkers -I facebook/checkers -I facebook/checkers/graphql -I facebook/scripts -I harness -I opensource -lflags -annot -cflags "-bin-annot -warn-error @5@8@10..12@20@26@39" -lib unix -lib str -cflags -annot -lflags -I,/root/.opam/4.01.0/lib/easy-format,-I,/root/.opam/4.01.0/lib/biniou,-I,/root/.opam/4.01.0/lib/yojson,-I,/root/.opam/4.01.0/lib/atdgen -cflags -I,/root/.opam/4.01.0/lib/easy-format,-I,/root/.opam/4.01.0/lib/biniou,-I,/root/.opam/4.01.0/lib/yojson,-I,/root/.opam/4.01.0/lib/atdgen -lib biniou -lib atdgen -mod easy_format -mod yojson -mod ag_oj_run -mod ag_util  -cflags -annot -lflags -I,/root/.opam/4.01.0/lib/extlib,-I,/root/.opam/4.01.0/lib/camlzip/../zip,-I,/root/.opam/4.01.0/lib/ptrees,-I,/root/.opam/4.01.0/lib/javalib,-I,/root/.opam/4.01.0/lib/sawja -cflags -I,/root/.opam/4.01.0/lib/extlib,-I,/root/.opam/4.01.0/lib/camlzip/../zip,-I,/root/.opam/4.01.0/lib/ptrees,-I,/root/.opam/4.01.0/lib/javalib,-I,/root/.opam/4.01.0/lib/sawja -lib zip -lib extLib -lib ptrees -lib javalib -lib sawja backend/inferanalyze.native backend/inferprint.native clang/cMain.native

/root/.opam/4.01.0/bin/ocamlyacc clang/cTypes_parser.mly
22 rules never reduced
51 shift/reduce conflicts, 1 reduce/reduce conflict.
/root/.opam/4.01.0/bin/ocamlopt.opt -c -bin-annot -warn-error @5@8@10..12@20@26@39 -annot -I /root/.opam/4.01.0/lib/easy-format -I /root/.opam/4.01.0/lib/biniou -I /root/.opam/4.01.0/lib/yojson -I /root/.opam/4.01.0/lib/atdgen -annot -I /root/.opam/4.01.0/lib/extlib -I /root/.opam/4.01.0/lib/camlzip/../zip -I /root/.opam/4.01.0/lib/ptrees -I /root/.opam/4.01.0/lib/javalib -I /root/.opam/4.01.0/lib/sawja -I clang -I harness -I opensource -I checkers -I backend -o clang/cTypes.cmx clang/cTypes.ml
File "clang/cTypes.ml", line 78, characters 57-74:
Error: This pattern matches values of type 'a * 'b * 'c
but a pattern was expected which matches values of type
Clang_ast_t.stmt_info * Clang_ast_t.stmt list *
Clang_ast_t.expr_info * Clang_ast_t.cxx_delete_expr_info
Command exited with code 2.
Compilation unsuccessful after building 412 targets (0 cached) in 00:00:25.
Makefile:142: recipe for target 'build_clang' failed
make[1]: *** [build_clang] Error 10
make[1]: Leaving directory '/home/rgos/infer/infer/infer/src'
Makefile:19: recipe for target 'clang' failed
make: *** [clang] Error 2
make: Leaving directory '/home/rgos/infer/infer/infer'
root@rgos-All-Series:/home/rgos/infer/infer#

btw: infer.zip and facebook-clang-plugin.zip  are downloaded today.i think they are update.

Hmm, the only other oddity I see is that your have stored infer inside a directory called infer (leading to the triple "infer/infer/infer" in your path). Could you try unzipping infer.zip in the top level of your home directory and following the instructions from scratch? It should work regardless of what the top-level path is, but there may be some script that is relying on being in the home directory.

well, i upgrade both the 'infer dir' and 'facebook-clang-plugin dir' to /home directory.
the result is same,
root@rgos-All-Series:/home/infer# make -C infer
make: Entering directory '/home/infer/infer'
make -C src clang
make[1]: Entering directory '/home/infer/infer/src'
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
sed -e 's/@MAJOR@/0/g'
-e 's/@MINOR@/2/g'
-e 's/@PATCH@/0/g'
-e 's/@GIT_COMMIT@//g'
-e 's/@GIT_BRANCH@//g'
-e 's/@GIT_TAG@//g'
backend/version.ml.in > backend/version.ml
mkdir -p ../_build-infer
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
/home/infer/scripts/check_clang_plugin_version.sh /home/infer/../facebook-clang-plugin
SKIPPING the facebook-clang-plugins version check since
/home/infer/../facebook-clang-plugin is NOT a Git repository
atdgen -rec -t /home/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
atdgen -rec -j /home/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
atdgen -rec -v /home/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast.atd -o clang/clang_ast
cp -f -p /home/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast_proj.ml clang
cp -f -p /home/infer/../facebook-clang-plugin/clang-ocaml/build/clang_ast_proj.mli clang
cp -f -p /home/infer/../facebook-clang-plugin/clang-ocaml/clang_ast_cache.ml clang
cp -f -p /home/infer/../facebook-clang-plugin/clang-ocaml/clang_ast_main.ml clang
ocamlbuild -build-dir ../_build-infer -j 0 -I backend -I checkers -I facebook/checkers -I facebook/checkers/graphql -I facebook/scripts -I harness -I opensource -lflags -annot -cflags "-bin-annot -warn-error @5@8@10..12@20@26@39" -lib unix -lib str -cflags -annot -lflags -I,/root/.opam/4.01.0/lib/easy-format,-I,/root/.opam/4.01.0/lib/biniou,-I,/root/.opam/4.01.0/lib/yojson,-I,/root/.opam/4.01.0/lib/atdgen -cflags -I,/root/.opam/4.01.0/lib/easy-format,-I,/root/.opam/4.01.0/lib/biniou,-I,/root/.opam/4.01.0/lib/yojson,-I,/root/.opam/4.01.0/lib/atdgen -lib biniou -lib atdgen -mod easy_format -mod yojson -mod ag_oj_run -mod ag_util  -cflags -annot -lflags -I,/root/.opam/4.01.0/lib/extlib,-I,/root/.opam/4.01.0/lib/camlzip/../zip,-I,/root/.opam/4.01.0/lib/ptrees,-I,/root/.opam/4.01.0/lib/javalib,-I,/root/.opam/4.01.0/lib/sawja -cflags -I,/root/.opam/4.01.0/lib/extlib,-I,/root/.opam/4.01.0/lib/camlzip/../zip,-I,/root/.opam/4.01.0/lib/ptrees,-I,/root/.opam/4.01.0/lib/javalib,-I,/root/.opam/4.01.0/lib/sawja -lib zip -lib extLib -lib ptrees -lib javalib -lib sawja backend/inferanalyze.native backend/inferprint.native clang/cMain.native

/root/.opam/4.01.0/bin/ocamlyacc clang/cTypes_parser.mly
22 rules never reduced
51 shift/reduce conflicts, 1 reduce/reduce conflict.
/root/.opam/4.01.0/bin/ocamlopt.opt -c -bin-annot -warn-error @5@8@10..12@20@26@39 -annot -I /root/.opam/4.01.0/lib/easy-format -I /root/.opam/4.01.0/lib/biniou -I /root/.opam/4.01.0/lib/yojson -I /root/.opam/4.01.0/lib/atdgen -annot -I /root/.opam/4.01.0/lib/extlib -I /root/.opam/4.01.0/lib/camlzip/../zip -I /root/.opam/4.01.0/lib/ptrees -I /root/.opam/4.01.0/lib/javalib -I /root/.opam/4.01.0/lib/sawja -I clang -I harness -I opensource -I checkers -I backend -o clang/cTypes.cmx clang/cTypes.ml
File "clang/cTypes.ml", line 78, characters 57-74:
Error: This pattern matches values of type 'a * 'b * 'c
but a pattern was expected which matches values of type
Clang_ast_t.stmt_info * Clang_ast_t.stmt list *
Clang_ast_t.expr_info * Clang_ast_t.cxx_delete_expr_info
Command exited with code 2.
Compilation unsuccessful after building 412 targets (0 cached) in 00:00:25.
Makefile:142: recipe for target 'build_clang' failed
make[1]: *** [build_clang] Error 10
make[1]: Leaving directory '/home/infer/infer/src'
Makefile:19: recipe for target 'clang' failed
make: *** [clang] Error 2
make: Leaving directory '/home/infer/infer'

i noticed last of compile log is
"File "clang/cTypes.ml", line 78, characters 57-74:
Error: This pattern matches values of type 'a * 'b * 'c
but a pattern was expected which matches values of type
Clang_ast_t.stmt_info * Clang_ast_t.stmt list *
Clang_ast_t.expr_info * Clang_ast_t.cxx_delete_expr_info
Command exited with code 2."
can the file clang/cTypes.ml be the reason?

Hi @b0207191, which version of infer and the facebook-clang-plugins are you using? Can you try with the latest git master of infer?

hi jvillard,
infer.zip and facebook-clang-plugin.zip are downloaded in 2015-8-7. i think they are new.

Did you get these from GitHub?
You need a specific version of facebook-clang-plugins to compile infer. Usually the latest version of the plugin does not work with infer. You can find which version of the facebook-clang-plugins you need in dependencies/clang-plugin/clang-plugin-version.config.
For instance, to compile the current infer master, you need https://github.com/facebook/facebook-clang-plugins/archive/3a4b470518da7251f2dc296444c4d616fef5dc2c.zip.
The easiest way to get the right version of the plugin is to simply remove your current facebook-clang-plugins/ directory and run ./update-fcp.sh from inside infer, which will get the right version for you.

hi @jvillard
thanks for your advice, i replace the facebook.zip with the version you mentinoed, it compiled correctly now!

good to hear!


[MINOR][DOCS] Fix [[...]] to ... and ... in documentation

What changes were proposed in this pull request?
Before:

After:

Why are the changes needed?
To render the code block properly in the documentation
Does this PR introduce any user-facing change?
Yes, code rendering in documentation.
How was this patch tested?
Manually built the doc via SKIP_API=1 jekyll build.

Test build #119743 has started for PR 27899 at commit a855ece.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24472/
Test PASSed.

Test build #119743 has finished for PR 27899 at commit a855ece.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119743/
Test PASSed.


Support 1024 bit seed

If it's even possible to crack a 1024-bit seed, and you do, that would be very cool.
Villain: https://www.curseforge.com/minecraft/mc-mods/secureseed

Possible yes, Feasable no


Clean up the boxed UserCallback properly.

Failing on travis' osx due to script problems, but built fine on linux. Merging.


Test empty values with typed tables

Jira: CT-843
KBC: XXX
Before asking for review make sure that:
Checklist

[x] New client method(s) has tests
[x] Apiary file is updated

Release

[x] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

@jirkasemmler este keby ta mozem poprosit, ked uz si dal approvek na tu connection :)


PickerIOS Documentation

It is currently empty:
http://facebook.github.io/react-native/releases/next/docs/pickerios.html

For the next release it's empty. For the documentation of 0.44 not: http://facebook.github.io/react-native/releases/0.44/docs/pickerios.html


Add contour extraction function and notebook

Contour extraction function which is used to extract NIDEM waterline contours... might be useful for other things too. Function has doctests
Also added a notebook demoing functionality with examples for DEMs and waterline extraction

Sorry about the messy commit history! TThe latest version of the notebook is at 119d6ae

Nice work, note the ability to create contours from non-elevation based data. Could make it easier to grok some complex datasets.


Change inheritance order for chain_class_without_seal_validation

What was wrong?
Previously the order in which chain_class_without_seal_validation would cause MRO errors when called on an instance of NoChainSealValidationMixin class. (Because chain_class is superset of NoChainSealValidationMixin class)
How was it fixed?
The order was changed so that the superset class is added in the front. This prevents the MRO errors.
Cute Animal Picture

@pipermerriam could you please review this? This came up when I was trying to reset the Genesis multiple times using evm_resetToGenesisFixture.

Is there a test we could add that would have exposed this under the chain builder test suite?

@pipermerriam ready to be merged.


refactor: move transformer model loading to post_init

According to BaseExecutor documentation, model loading should be done in post_init:

Initialize class attributes/members that can/should not be (de)serialized in standard way.
Examples:
- deep learning models
- index files
- numpy arrays

So I moved the loading of model/tokenizer for Transformer Encoders to post_init.
This also makes sense since jina logs the time taken in post_init and warns the user that this might take some time - while no such logging/warning is given for model loading outside of post_init, as it is done now

@JoanFM there's one mysterious error in CI with config not saving properly for TF (not related to anything changed in this PR) - any idea what to do about it?

I see the exact same error appears here, and also locally these tests fail for me. Should I file an issue about it with more details?

I see the exact same error appears here, and also locally these tests fail for me. Should I file an issue about it with more details?

that would be good

@JoanFM there's one mysterious error in CI with config not saving properly for TF (not related to anything changed in this PR) - any idea what to do about it?

It is indeed very weird failure

@JoanFM do you think we could move forward with merging this PR (if other tests pass) despite that strage bug? It seems not be related with anything changed in this PR (as it also happens on the automatic update bot PRs...)

@JoanFM do you think we could move forward with merging this PR (if other tests pass) despite that strange bug? It seems not be related with anything changed in this PR (as it also happens on the automatic update bot PRs...)

Hey @tadejsv ,
Sorry but it can't be merged, I recommend you split it in 2 PRs one for each executor. Merging this would mean there is no alignment between the images in jinahub and the code in the repository. I will try to dig deeper in the root cause

@JoanFM, okay, I can do that. Btw, related to images - it doesn't seem like any of the hub images have been updated in the last few months

@JoanFM, okay, I can do that. Btw, related to images - it doesn't seem like any of the hub images have been updated in the last few months

No, they are built constantly https://hub.docker.com/u/jinahub

@JoanFM, okay, I can do that. Btw, related to images - it doesn't seem like any of the hub images have been updated in the last few months

No, they are built constantly https://hub.docker.com/u/jinahub

Oh okay, then docs need to be updated

@JoanFM, okay, I can do that. Btw, related to images - it doesn't seem like any of the hub images have been updated in the last few months

No, they are built constantly https://hub.docker.com/u/jinahub

Oh okay, then docs need to be updated

Sure, can you point where the link was found?

@JoanFM yes, for example here: https://docs.jina.ai/chapters/hub/publish-your-pod-image.html and here: https://docs.jina.ai/chapters/hub/use-your-pod.html
But there are some other pages in the documentation with the wrong link too, just search for jinaai/hub. and you'll fine them.
The first page (about publishing your pod) actually needs a more thorough update, as the structure of manifest.yml doesn't correspond to the actual one, and neither does the structure of the files inside jina-hub.

Hey @tadejsv ,
TransformerTFEncoder can be updated now!