Arrow keys and backspace not working in bash after recent update

Today I ran pacman -Syu which upgraded the following packages (from the end of /var/log/pacman.log):
[2018-01-30 11:56] [ALPM] upgraded mpfr (<IP_ADDRESS>-3 -> <IP_ADDRESS>-3)
[2018-01-30 11:56] [ALPM] upgraded gcc-libs (6.4.0-1 -> 6.4.0-2)
[2018-01-30 11:56] [ALPM] upgraded ncurses (6.0.20170708-2 -> 6.1.20180127-1)
[2018-01-30 11:56] [ALPM] upgraded gawk (4.1.4-2 -> 4.2.0-1)
[2018-01-30 11:56] [ALPM] upgraded isl (0.16.1-1 -> 0.18-1)
[2018-01-30 11:56] [ALPM] upgraded mpc (1.0.3-1 -> 1.1.0-1)
[2018-01-30 11:56] [ALPM] upgraded msys2-w32api-headers (<IP_ADDRESS>61.e09dd4ca-1 -> <IP_ADDRESS>97.36d7b92b-1)
[2018-01-30 11:56] [ALPM] upgraded msys2-w32api-runtime (<IP_ADDRESS>61.e09dd4ca-1 -> <IP_ADDRESS>97.36d7b92b-1)
[2018-01-30 11:56] [ALPM] upgraded gcc (6.4.0-1 -> 6.4.0-2)
[2018-01-30 11:56] [ALPM] upgraded ncurses-devel (6.0.20170708-2 -> 6.1.20180127-1)
[2018-01-30 11:56] [ALPM] upgraded wget (1.19.2-1 -> 1.19.3-1)

After this update the arrow keys and backspace don't work correctly at the shell input line, in a weird way.
I tried the following with and without a ~/.bashrc file:
Pressing few chars and then a backspace seems to print a space. Up arrow works but then the shell doesn't clean up the line with history inputs and just appends the history items to the line.
Left and right arrows at the shell prompt don't skip chars as expected, but ctrl-v and then pressing an arrow key does print a correct (I think) string, e.g. ctrl-v and then right arrow prints ^[[C but the shell doesn't seem to re-render the line correctly when used without it.
Up/down/left/right arrows while in less (/usr/bin/less) does seem to work correctly.
It's like the shell reads the keys correctly but not able to re-render the input line correctly. Maybe the ncurses update is at fault?

Deleting ~/.minttyrc helped here (or I was just lucky and that was unrelated..)

Deleting ~/.minttyrc helped here (or I was just lucky and that was unrelated..)

It's because the default mintty TERM is xterm, and the issue appears to be related to TERM being xterm-256color - which is required for some programs to display more than 8 colors.

Rebuild bash can fix the problem. Thank you for the information.
You could try the rebuilded bash at
https://ci.appveyor.com/project/zklhp/msys2-packages/build/1.0.16/artifacts

#1128

#1128

Assuming ncurses 6.1 may break binary compatibility, it would need a rebuild of all packages which use ncurses. Bash is just the most visible of those (assuming there are more packages depending on ncurses).

maybe related: https://bugs.archlinux.org/task/57300?project=1&string=ncurses

Possibly interesting development: https://github.com/mintty/mintty/issues/738#issuecomment-364402557
--
David Macek

Possibly interesting development: mintty/mintty#738 (comment)

That link lacks info, but void linux appears to have had a similar issue: https://forum.voidlinux.eu/t/solved-problems-after-todays-update/4553 . Apparently it was fixed for them after bash was updated, but I don't know it it was just rebuilt or maybe something else.
Additionally, I now can't build bash with makepkg, there's some compile error with an unknown type IIRC - this is after the msys2 runtime was updated to cygwin 2.10 .

Also, there appear to be two issues:

(fixed after rebuilding bash): editing keys don't work in CLI in bash with TERM=xterm-256color .
(NOT fixed after rebuilding bash): bash aborts after setting TERM to some dummy name, e.g. TERM=blahblah .

I just rebuilt bash from current msys2-packages and installed it and the issue seems gone.

Would you mind sharing your build procedure? I cd to the bash dir of the msys2 packages repo and issued makepkg --skippgpchec -sCLf and it stopped/errored after some time with IIRC undefined type or something.

(NOT fixed after rebuilding bash): bash aborts after setting TERM to some dummy name, e.g. |TERM=blahblah| .

Okay, yeah, I didn't know of this issue. My rebuilt bash still does this.

Would you mind sharing your build procedure? I cd to the bash dir of the msys2 packages repo and issued |makepkg --skippgpchec -sCLf| and it stopped/errored after some time with IIRC undefined type or something.

I did nothing special.  Just updated the repo and simple makepkg in the bash directory.
--
David Macek

Just to chime in the new ssp changes break building ncurses, undefined references to FILE in ssp/stdio.h and ssp/whar.h.
So guess it might need some patches to get around this.

Uh oh new msys2-runtime breaks windows cmake, it cannot find itself after update.
Reinstalling does not work either and i cannot recompile it either because the bootstrapped version also cannot find itself. Something tells me we should hold off on this version untill it becomes more stable.

for the actual error ill post it below.
´´´
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: C:/Msys64/mingw64/bin/gcc.exe
-- Check for working C compiler: C:/Msys64/mingw64/bin/gcc.exe -- broken
CMake Error at Modules/CMakeTestCCompiler.cmake:52 (message):
The C compiler
"C:/Msys64/mingw64/bin/gcc.exe"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: C:/Msys64/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp

Run Build Command:"C:/Msys64/usr/bin/make.exe" "cmTC_20e2c/fast"
gmake -f CMakeFiles/cmTC_20e2c.dir/build.make CMakeFiles/cmTC_20e2c.dir/build
gmake[1]: G+▒r til katalog "/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp"
/bin/sh: /C/Msys64/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/Bootstrap.cmk/cmake.exe: No such file or directory
CMakeFiles/cmTC_20e2c.dir/build.make:64: *** [CMakeFiles/cmTC_20e2c.dir/testCCompiler.c.obj] Error 127
CMakeFiles/cmTC_20e2c.dir/build.make:65: recipe for target 'CMakeFiles/cmTC_20e2c.dir/testCCompiler.c.obj' failed

#0  CMakeFiles/cmTC_20e2c.dir/testCCompiler.c.obj at /src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_20e2c.dir/build.make:64
#1  cmTC_20e2c.exe at /src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_20e2c.dir/build.make:95
#2  CMakeFiles/cmTC_20e2c.dir/build at /src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_20e2c.dir/build.make:102
gmake[1]: Forlader katalog "/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeTmp"
make: *** [Makefile:126: cmTC_20e2c/fast] Error 2

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:5 (project)
-- Configuring incomplete, errors occurred!
See also "C:/Msys64/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeOutput.log".
See also "C:/Msys64/src/MINGW-packages/mingw-w64-cmake/src/build-x86_64-w64-mingw32/CMakeFiles/CMakeError.log".
Error when bootstrapping CMake:
Problem while running initial CMake
´´´

Hmm ok scratch that, for some reason one of the updates had deleted the fstab file, after recreating it it worked again. I noticed few missing files in msys2 filesystem package like the one that autoregenerates fstab, what was the reason this one was removed ? i newer had any problem with it so im curious.

I start my mintty session with xterm-256color, and I can reproduce the backspace problem as stated. When I enter TERM=xterm, the problem disappears, even after I set TERM=xterm-256color again.
I'll wait patiently for a release to get to pacman.

The update for bash to version 4.4.019-1 fixed the shell history for me.

Yep! Fixed it for me too.

Bash <IP_ADDRESS> fixes the editing key issues for me with xterm-256color, but this new issue remains (both with <IP_ADDRESS> after a rebuild and also with the pre-built <IP_ADDRESS> after the update):

(Only after rebuilding bash): bash aborts after setting TERM to some dummy name, e.g. TERM=blahblah

Fixed it for me rebuilding ncurses against the new cygwin ssp allthough i had to hack about it a bit because the cygwin ssp bailed out with an error to find struct FILE.  It works in other packages though so id say this is something that needs to be looked at upstream by the ncurses devs.
One way to get around it is by including stdio.h before any of the ssp headers in ncurses.

Problem with finding FILE strict is solved yesterday. You need remove -D_FORTIFY_SOURCE=2 from CPPFLAGS in makepkg.conf file

Ok thats a bit simpler, but wont it affect other sources to remove the hardening ?

I solved the problem by using ash.exe and run pacman -Syu bash in it.

The PR linked just above should work around the crash, I hope.

The PR linked just above should work around the crash, I hope.

Confirm it fixes the crash for me, thanks. The cursor keys work too since the bash <IP_ADDRESS>-1 and still with <IP_ADDRESS>-2 .

@avih, good.
@Alexpux, what's wrong with _FORTIFY_SOURCE=2?  Isn't there a better fix for struct FILE?

@elieux there are conflicts in cygwin headers


Fix issue #29: I have made the email functionality work in the contact form.

Description
I have added a new file called contact.php and updated index.html. Currently the mail is set to be written from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>. You can change it by reading below.
Notice
Please note in contact.php file under line 24 and 25, those creds are my email's creds. If you want yours to be added then add your creds (i.e ur email  and app password , not email password).

Also make sure the path of Exception.php, SMTP.php and PHPMailer.php is proper in line 3, 4 and 5. Suppose if you create another folder in htdocs of Xampp folder.

I have set the mail to be sent in very simple form, you can edit it as you want.

Also last, once when the user sends the contact form, the URL gets updated as index.html?success=true
This is how the mail will look like:

This looks good, @BlitzIQ-Coder. I've assigned a level 2 label to this. Thank you for contributing! If you'd like to make more backend fixes to the site, feel free to open new issues.
Closes #29

Also i forgot about another thing:
Suppose if it still fails to work, you will have to download cacert.pem from this link.
Then copy paste the cacert.pem to xampp > apache > bin

Cool, Thanks for heads up 👍


CLI option year is required

Update year as a required parameter

Coverage remained the same at 37.432% when pulling 413ca9d630a309557d6bb44a495f70020434fb01 on santoshamohan:fix-year-doc into 1b60e4b26f6ca5c17c87e3cc8d66bbdb231a13fe on GeoscienceAustralia:master.

I don't think we want to make --year required.
Why do you think we should?
Not specifying --year means finding anything that needs processing, which is a very useful case.

I missed this before -- @santoshamohan  found that the cli is currently broken when you don't specify a year, as it's not checking for None.
https://github.com/GeoscienceAustralia/fc/blob/8a2c208da18ba19c6f759bee941b4a78ea3b01c3/fc/fc_app.py#L311
I agree with @omad that it would be better to fix it than to make year a required property.


Not incrementing versions in AndroidManifest

android:versionCode and android:versionName fields

Hey @olegdizus. I think RN updates these values in memory during build time. Looking at RN projects I've worked on, I see that they always stay at their default values:
<manifest
	android:versionCode="1"
	android:versionName="1.0"

Why do you need them to be updated?

It seems to me that they are mandatory for the play store, aren't they?

@jsdario I don't dispute that. I'm just saying that I've never seen this file updated since doing react-native init, therefore I don't think RNV should update them either.
When you're building an APK for the Play Store, they should be updated during the build process. Or am I missing something?

I think React Native's behaviour in this case is indeed weird, but it makes sense to update the values only in the Gradle file. Or vice versa, but definately not in two places.

But I would still like to know if there's any interesting use case that would warrant updating AndroidManifest.xml because we could then make an extra option for it :)

@stovmascript @jsdario Updating AndroidManifest.xml will not have any effect since the ones written in build.gradle will replace the ones in AndroidManifest.xml during build.
But it might be a good idea to also update the values in AndroidManifest.xml to clear any confusion created by different values of versionCode and versionName in build.gradle and AndroidManifest.xml

The PR above is just a draft on how it was implemented under the organisation I work in. Feel free to copy / paste, improve or close it.
Hope it helps.

@jsdario Ok, thanks. Will have a deeper look at it later.

I think updating AndroidManifest.xml is out of the scope of this package. RNV's job should be to update the topmost values, which you'd otherwise have to update manually in a RN app. Android manifest files get updated dynamically during build, which is what RN users expect, so updating them with RNV would actually create confusion.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Neha Koppikar

Discord Username(if exists): Neha#4129

Additional Context:

 I met Eddie at Local Hack Day: Build
 I like this community's inclusive nature. I met so many awesome people who are really inspirational. I am here to learn and share as much as I can!
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Include GorillaStack Logo In Services / Tools Infographic

Per my discussion with @QuinnyPig  we would love to have the GorillaStack logo included in the infographic. While GorillaStack covers a number of automation scenarios, Cost Management would probably be the most appropriate section.
Thank you

Hi @Ollibe13, thank you for your submission and for your interest in the Open Guide to AWS. We are trying to keep the graphic of services and tools to the most well known and significant set in a given space in order to keep the graphic manageable and the guide navigable, and I don't think that GorillaStack (yet) qualifies as being significant enough to squeeze out the others.
If you disagree with my (quick) assessment of significance of GorillaStack relative to the others in the graphic, I'd be happy to review any information that you submit to support that.
I'm closing this issue, but will will reopen for discussion if new information is added.
Thanks again.


[Model Serving]: UI Enhancements

Feature description

[ ] Inferenceservice loading status icon should be spinner rather than an hourglass.

[ ] Display a tooltip message when the model fails.

[ ] Adding headers to tokens row

[ ] In the "Deploy model" modal, change "Configure" button text to "Deploy"

[ ] Calculate witdh based on the ? icon

[ ] Route itself doen’t refresh with changes automatically

[ ] HIde the link from the Model names until metrics are enabled

[ ] When inference service is disabled, just change the text to "Internal Service" rather than displaying a route

Inferenceservice loading status icon should be spinner rather than an hourglass.

PF spinner component on small probably is enough (check the size of the icon to the spinner -- we shouldn't decrease the height of the row when it flips)

Display a tooltip message when the model fails.

I'd like to see a tooltip for each one. Checkmark should say "deployed" or whatever. No need to make users guess at state of things. But definitely this is needed for the error flow to show the error that it is informing us about.

Calculate witdh based on the ? icon

If you absolutely need to make them align no matter what... don't calculate, set the layout. Your options are two fold:

Use something like Split from PF, it's a block element and will manage truncating cells things if it runs out of space (might want to use the Truncate component on the name in that case)
Use white-space: nowrap CSS (MDN) on the cell that has everything in it. If this is in a table cell, the table will adjust the column to fit the whole content (if it can).


controllerAs with vm, and this

see this section
I wonder what the reason is behind to advise var vm = this; opposed  to var vm = {} ... return vm;
In the JS community there is a lot of use of this without an apparent reason. A lot of issues disappear when you don't use it. (ask Crockford if you don't believe me ;))  Usually when a controller is defined with ngController, this will be an empty object anyhow. If we need something, we use the injector and inject it.
For directive controllers with bindToController:true the isolate scope is attached to this but that always felt wrong to me. It should be injected along with other dependencies. In most other cases this is also bound to an empty object.
EDIT: there is an actionable issue here. this section should be adapted to promoting var vm = {};...return vm;

When using controllerAs, this is what gets bound to the View.

@johnpapa My demo plunk shows, that whatever is returned gets bound to the view. This is a subtle yet important difference.

And then you are also replacing the way constructor objects work in JavaScript. The Controller gets instantiated and this is the instance that is returned, so you'd be replacing that.
controllerAs is syntactic sugar over $scope. Simply replacing it with { } is not going to add any value.

John, I read the words, I understand were it is coming from.
However, I seem to fail to understand the added value of using ‘this’ over
an clean object.
When using var vm= {}; it is an small step to var vm = angular.extend({},
someDefaults()). I know I can do the same with ‘this’, but then there is a
change that I overwrite some internals I don’t know off (well, that could
be, there is no way for me knowing looking at that code, right?)
So, my question stay’s. what is the added value of this?
function someController() {
var vm = this;
vm.something = 'someotherthing'
vm.someFunc = doSomething
return;
///
function doSomething() {}
}
over this:
function someController() {
var vm = {};
vm.something = 'someotherthing'
vm.someFunc = doSomething
return vm;
///
function doSomething() {}
}
Good, I need to type a few letters extra, but that can’t be the point?

John, I read the words, I understand were it is coming from.
However, I seem to fail to understand the added value of using ‘this’ over
an clean object.
When using var vm= {}; it is an small step to var vm = angular.extend({},
someDefaults()). I know I can do the same with ‘this’, but then there is a
change that I overwrite some internals I don’t know off (well, that could
be, there is no way for me knowing looking at that code, right?)
So, my question stay’s. what is the added value of this?
  function someController() {
   var vm = this;
   vm.something = 'someotherthing'
   vm.someFunc = doSomething
   return;
   ///
   function doSomething() {}
   }

over this:
  function someController() {
   var vm = {};
   vm.something = 'someotherthing'
   vm.someFunc = doSomething
   return vm;
   ///
   function doSomething() {}
   }

Good, I need to type a few letters extra, but that can’t be the point?

This is the way constructor objects work in JavaScript. You dont need to return anything as this is the object you are creating. So you'd be replacing that with your own. I think it is overly clear that this is the object as that is how all JavaScript constructors work, and that making a new object and overriding it is not as clear. It's a JavaScript convention.
here is another option
		angular
			.module('app', [])
			.controller('Shell', Shell)
			.controller('Customer', Customer);

		Shell.$inject = ['$scope', 'msgservice'];
		function Shell($scope, msgservice) {
			$scope.vm = this;
			$scope.vm.title = 'shell title';
		}

		Customer.$inject = ['$scope'];
		function Customer($scope) {
			$scope.vm = this;
			$scope.vm.name = 'customer name';
		}

This is what is happening under the covers when you setup controllerAs.
If you go the route you suggest, which I wouldn't, you;d have to make sure all use cases for $scope still work too, such as watches (tho I avoid those, but sometimes they are necessary).
I don't see any value in deviating as its clear what the object is as JavaScript knows this is the object. it is also more consistent to where Angular 2 is heading with the class structure and this being the object.
Its fun to explore new ideas, and you have an interesting take on it.

I know it's a JS convention.  I can live with this tough ;) Have been for living with this for over 2 decades.
Helping other developers, I found out that for a lot of them this this is confusing as .
Frankly, I can't blame them.
I know how ng1 hooks up the controllerAs to the scope. I see no problem there.
In that light. do you really think this is adding confusion:?
angular
            .module('app', [])
            .controller('Shell', Shell)
            .controller('Customer', Customer);

        Shell.$inject = ['$scope', 'msgservice'];
        function Shell($scope, msgservice) {
            $scope.vm = {};
            $scope.vm.title = 'shell title';
        }

        Customer.$inject = ['$scope'];
        function Customer($scope) {
            $scope.vm = {};
            $scope.vm.name = 'customer name';
        }

Or that there will be other issues doing this without this?
NG2 will be using ES6 classes. Those are just syntactic sugar over what we have already. Both way's of doing this or not this, will still be available.
And thank you, I try to keep my view fresh. Helping starters is a good way to maintain that.


add service role and anon keys to config.toml, use these keys throughout whole environment

Feature request
Is your feature request related to a problem? Please describe.
It is related to another feature request, but not a problem. Was asked in #451 to create a new issue, so I am doing so.
Describe the solution you'd like
It would be great to be able to specify your own service role, anon keys, and JWT keys in the config.toml file. I see that the keys that are displayed via supabase status are hardcoded and periodically change. I don't see where these keys are coming from, so they're possibly built in to the docker images that the cli tool sets up?
https://github.com/supabase/cli/blob/a02d2ff3426e0c70c25591cc7a94083cf5d0e7a1/internal/utils/misc.go#L70-L71
It would be great to have something like the following toml structure, perhaps with some randomly generated defaults provided on supabase init.
[auth]
anon_key = 'sldfkjsldkjfsldkjfdlskjlkjldkfj'
service_role_key = 'lsdkfjlsksjfdlksjfldskjslfkdj'

Describe alternatives you've considered
Without knowing where these keys come from, some alternatives might be:

passing environment variables to supabase init or supabase start that sets up the environment with anon and service role keys
exposing a docker-config.yml that describes the structure created by supabase init (but I see eject was removed, so guessing this is off the table)

Opened a PR for this here:
https://github.com/supabase/cli/pull/938

@sweatybridge Thanks for the update! This is great!


PP 20231011:There are performance issues might be caused by custom_checkpoint or TqdmCallback in CBC

There are performance issues that might be caused by custom_checkpoint or TqdmCallback.

done in other repo


Add support for favorite

Add favorite in login model and should be saved in DB as well, user should be able to favorite, unfavorite the login from login details screen.

If you haven't implemented this yet, I can take a look at this!

If you haven't implemented this yet, I can take a look at this!

Sure, go ahead, see the implementation of category


Fix MolFile Atom Line List Writer

Only the first element in the atom one was being
written correctly, the remainder were not being
padded correctly and could not be round tripped.

Astonishing that this one has remained un-caught for so long. Thanks for that Brian.


Support of Node 14

Hello,
Is there any plans to support node 14 ?
https://github.com/sindresorhus/active-win/issues/71 had an issue with v14 too.
No rush, just to know if it was planned 😊

Anyone know what would be required for it to work in Node v14? Since this is the new LTS version I would prefer to jump on 14 for my new project, which require to have accedd to the active-windows title and other information :)

I got the same issue.

Yes, this would be appreciated.

This package now targets Node.js 18.


Declare queue when publish

I can declare queue when publish?

+1

No, and the reason is fairly simple - the intention is to publish to routing keys, not queues.

Hello, AMQP lib permit this, may an option can be added ?

I'm actually unaware of that feature - could you provide an example?
From their docs:
Most other broker clients publish to queues, but in AMQP, clients publish Exchanges instead. AMQP is programmable, meaning that both the producers and consumers agree on the configuration of the broker, instead of requiring an operator or system configuration that declares the logical topology in the broker. The routing between producers and consumer queues is via Bindings. These bindings form the logical topology of the broker.


Repo scan quits Aider

Issue
I've read #1587 but this is different.  Aider quits completely for this repo.
To reproduce:
git clone git@github.com:bytedeco/javacpp-presets.git
cd javacpp-presets/
aider
/add .github/
update modsecurity.yml to latest base images like scipy.yml has been

You'll be back at the command line, Aider having quit
I read https://it.slashdot.org/story/24/09/19/1721236/1-in-10-orgs-dumping-their-security-vendors-after-crowdstrike-outage and thought I'd have another go at more methodically upgrading the modsecurity within this excellent technoloy
Version and model info
aider 0.56.0
(using OpenAI remotely)

Thanks for trying aider and filing this issue.
Can you share a screenshot of the problem, so I can see any output associated with the crash?
This looks like a very large repo. This doc may be helpful:
https://aider.chat/docs/faq.html#can-i-use-aider-in-a-large-mono-repo

I tried a --depth 10 clone, in case it was the weight of history Aider was choking on, but no.

Launching again with --subtree-only .github/
Aider command: /add .github/ only
Aider Command upgrade the modsecurity.yml to be like was recently done for pytorch.yml

To work in a subtree you change directories into the subtree before launching aider, then add the --subtree-only switch. It does not take a dirname as an argument.
Some file in that repo is probably crashing tree-sitter.
If you cd into .github and run aider --subtree-only you can probably work around this problem.

I think the problem was simply that you ran out of memory processing this repo with 12k files! I cloned it and my aider isn't quitting, but is struggling with memory use.
Use --subtree-only as described above when working with such large repos.
I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


perf(agg/foldable): use next_set_bit in apply_batch_concrete()

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title

Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

benchmark (unit: ns/iter)

case
baseline
current
diff

bench_foldable_count_agg_vis_rate_0_05
189,442
109,640
-42.11%

bench_foldable_count_agg_vis_rate_0_25
209,099
116,076
-44.48%

bench_foldable_count_agg_vis_rate_0_5
236,969
128,720
-45.71%

bench_foldable_count_agg_vis_rate_0_75
271,424
149,379
-44.96%

bench_foldable_count_agg_without_vis
129,485
129,543
+0.04%

bench_foldable_max_agg_vis_rate_0_05
219,781
123,960
-43.59%

bench_foldable_max_agg_vis_rate_0_25
232,116
163,363
-29.63%

bench_foldable_max_agg_vis_rate_0_5
267,885
225,948
-15.66%

bench_foldable_max_agg_vis_rate_0_75
288,743
292,059
+1.15%

bench_foldable_max_agg_without_vis
257,916
229,167
-11.14%

bench_foldable_min_agg_vis_rate_0_05
220,225
113,004
-48.68%

bench_foldable_min_agg_vis_rate_0_25
235,350
153,464
-34.80%

bench_foldable_min_agg_vis_rate_0_5
261,232
215,088
-17.67%

bench_foldable_min_agg_vis_rate_0_75
289,783
279,184
-3.66%

bench_foldable_min_agg_without_vis
229,307
229,463
+0.07%

bench_foldable_sum_agg_vis_rate_0_05
235,178
116,834
-50.32%

bench_foldable_sum_agg_vis_rate_0_25
301,981
208,167
-31.07%

bench_foldable_sum_agg_vis_rate_0_5
405,590
341,602
-15.76%

bench_foldable_sum_agg_vis_rate_0_75
538,044
477,629
-11.23%

bench_foldable_sum_agg_without_vis
609,232
640,490
+5.13%

I guess we should instead refactor the implementation of iter? 🤔 It's not elegant to expand the iteration everywhere.

I guess we should instead refactor the implementation of iter? 🤔 It's not elegant to expand the iteration everywhere.

I think the problem here is that using enumerate() after using iter_ones() can't get the original index, so it can't meet the needs of this part of the code. There may be other solutions to this problem.


[bug] Development Server Do Not Killed After Window Exited

Describe the bug
When I exited the window, the app window was exited and terminated. But the development server didn't stop and continuously running on background until I manually kill the process.
Confirm that it exists on official cli create-react-app template.
Reproduction

Create a testing repo with create-tauri-app [select create-react-app template]
Run yarn tauri dev
Close the window
Repeat step 2 or check ports with netstat -nlpn

Expected behavior
No response
Platform and versions
$ tauri info

Environment
  › OS: Linux Soaring X64
  › Node.js: 16.15.0
  › npm: 8.5.5
  › pnpm: Not installed!
  › yarn: 1.22.18
  › rustup: 1.24.3
  › rustc: 1.61.0
  › cargo: 1.61.0
  › Rust toolchain: stable-x86_64-unknown-linux-gnu

Packages
  › @tauri-apps/cli [NPM]: 1.0.0-rc.13
  › @tauri-apps/api [NPM]: 1.0.0-rc.6
  › tauri [RUST]: 1.0.0-rc.14,
  › tauri-build [RUST]: 1.0.0-rc.12,
  › tao [RUST]: 0.9.1,
  › wry [RUST]: 0.17.0,

Stack trace
No response
Additional context
No response

I think we will never get read of all variations of this issue 😭
Thanks for the report.

I'm having this same problem too, using Yarn with Vite+Svelte on Ubuntu.

Same on Fedora with NPM, Vite, React+TypeScript (just the template created using npx create-tauri-app).
One unfortunate twist is that the development server stays partially attached to my terminal; I can go back to my terminal prompt and run commands, but then if I save a .tsx file my whole terminal is overwritten with 7:33:51 p.m. [vite] hmr update /src/App.tsx or similar.
Environment
  › OS: Fedora 36.0.0 X64
  › Node.js: 16.15.1
  › npm: 8.8.0
  › pnpm: Not installed!
  › yarn: 1.22.19
  › rustup: 1.24.3
  › rustc: 1.61.0
  › cargo: 1.61.0
  › Rust toolchain: stable-x86_64-unknown-linux-gnu

Packages
  › @tauri-apps/cli [NPM]: 1.0.0
  › @tauri-apps/api [NPM]: 1.0.1
  › tauri [RUST]: 1.0.0,
  › tauri-build [RUST]: 1.0.0,
  › tao [RUST]: 0.11.2,
  › wry [RUST]: 0.18.3,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:3000/
  › framework: React

App directory structure
  ├─ src
  ├─ node_modules
  └─ src-tauri

Hello,
I'm experiencing the same issue when running a bundler from a Node script : it never receives SIGTERM when quitting the app by closing its main window, although it exits successfully when pressing Ctrl+C in terminal.

beforeDevCommand : node ./start.js
./start.js : from KaKi87/template-tauri1-vue3-parcel2

I'll eventually create another reproduction repo with a Node script that runs a simple HTTP server with no bundler.
Thanks

I still have this issue on the current version of the Tauri CLI (v1.0.3). As others have also noted, the issue only happens when you close the app window; using Ctrl-C in the terminal does not cause the issue.
tauri info

$ tauri info

Environment
  › OS: Linux 16 X64
  › Node.js: 16.15.1
  › npm: 8.13.2
  › pnpm: Not installed!
  › yarn: 1.22.19
  › rustup: 1.24.3
  › rustc: 1.64.0-nightly
  › cargo: 1.64.0-nightly
  › Rust toolchain: nightly-x86_64-unknown-linux-gnu

Packages
  › @tauri-apps/cli [NPM]: 1.0.3
  › @tauri-apps/api [NPM]: 1.0.2
  › tauri [RUST]: 1.0.3,
  › tauri-build [RUST]: 1.0.3,
  › tao [RUST]: 0.12.1,
  › wry [RUST]: 0.19.0,

App
  › build-type: bundle
  › CSP: default-src 'self' https://asset.localhost; img-src 'self'; img-src https://* asset: https://asset.localhost
  › distDir: ../build
  › devPath: http://localhost:3000/
  › framework: React

App directory structure
  ├─ src-tauri
  ├─ src
  ├─ .idea
  ├─ docs
  ├─ public
  ├─ node_modules
  ├─ .vscode
  └─ .git


New inputs and textareas

Moved our old input and textarea macros into the new format. I also applied the new styles from @sonnakim and @cfarm's work on forms here.

I am currently working on the form-l layout grid and submit buttons
If I missed anything that needs to be converted let me know.
Changes

Changed styling of microtext to Design Manual specs
Converted more forms to global_dict
Converted common-form-fields.html into atoms
Fixed various spacing issues

Review

@anselmbradford
@sebworks
@cfarm

Can this get a review today?

@anselmbradford
@sebworks
@jimmynotjim

All the feedback is addressed.

:+1:

:+1: , other than the minor issues noted.

:+1:


Homekit With Wyze Cam Pan - only still image no stream in HomeKit

hello
I'm using the Wyze cam pan with HomeKit and RTSP and I can see in HomeKit the photo from the camera but when I press into the photo in HomeKit I can only see the image and there's no video "it says No Response the camera is not responding" - the stream in Wyze app is working fine.
when I close HomeKit and turn it back on I see the photo with time counter . it seems it takes only snap shot .
what can be wrong

These are my settings and they working fine on IOS 13
{
"name": "Front Yard",
"videoConfig": {
"source": "-rtsp_transport tcp -i<EMAIL_ADDRESS>"stillImageSource": "-rtsp_transport tcp -i<EMAIL_ADDRESS>"maxStreams": 2,
"manufacturer": "Wyze",
"model": "Pan",
"serialNumber": "1234567890",
"firmwareRevision": "1.0",
"motion": true,
"maxWidth": 1280,
"maxHeight": 720,
"maxFPS": 15,
"audio": false,
"debug": false
}
},


[ARM]:  Support resource with multiple paths

Create a canonical pattern for an ARM resource that can be hosted under multiple paths

Resources at each of these paths have the same resource schema and may have the same or different operations
example: PolicyDefinition (subscription, resource group)
Resources may also have recursive parentage (ManagementGroups)

We have several (maybe we can say many) RPs in which a same resource model defined is used in different clients. For example, this client and this client share the same resource model Site.

/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}

The only way we could write its TypeSpec now seems like this.

https://github.com/Azure/typespec-azure/issues/1282 should be handled simultaneously.

Design is here: https://gist.github.com/markcowl/825f8827d1e280a1c5ffeb57eb968677


Provide ability to use INTENT ACTION to simulate zebra device

Since I don't own a zebra device and need to test what I'm working on, it would be good if we could use similar API provided by Zebra via https://developer.zebra.com/blog/test-your-zebra-scanning-application-emulator
They provide a test app that has an INTENT we can call with ADB: https://github.com/darryncampbell/DataWedge-API-Exerciser/blob/darryncampbell_repo_backup/app/src/main/AndroidManifest.xml

You should be able to use intents with the library as well. E.g. we testing with a command similar to:
adb -s your-device \
    shell am broadcast \
        -a com.circuskitchens.x.SCAN_EVENT \
        -e com.symbol.datawedge.source scanner \
        -e com.symbol.datawedge.label_type LABEL-TYPE-QRCODE \
        -e com.symbol.datawedge.data_string https://x.circuskitchens.com/y/z


Missing file problem

When importing TransformerWithDiffPoolLayer from .components.diff_encoder, you will find that the file diff_encoder is missing.

Resolved by 9af3a57

Solved by 9af3a57ee24ac732e99bf4ec1c3213ac0f0d1623


Count performance [e.g., GROUP BY vs. COUNT(*)]

I have several ORC tables stored in HDFS on a 3-node cluster (accessed from an edge node -- can provide more connection details if that helps).
When I run a simple count against either the entire table or a selected single column, the query takes about 50 times longer to come back than a query that groups and then counts.
When I run a simple SELECT count(*) FROM sameTable in Hive (CLI or Web UI) the results come back almost instantaneously.
Is this normal? Is there a better way to code the total counts? (For what it's worth, we want to use SparklyR in order to avoid having to craft our own SQL and pass it through [although the select count is obviously simple].)
Some samples are included below.
Sample code and results for the long running total count

someTable_tbl <- tbl(sc,"someTable")
someTable_tbl_ref <- someTable_tbl %>% select(someField) %>% count
someTable_tbl_ref

Source:   query [1 x 1]
Database: spark connection master=yarn-client app=sparklyr local=FALSE
   n
 <dbl>
1 31443593

 user  system elapsed
1.021   1.253 588.105

Sample code and results for the faster running count by grouped column

someTable_tbl <- tbl(sc,"someTable")
someTable_tbl_cntbySomeField <- someTable_tbl %>% group_by(someField) %>% summarize(count = n())
someTable_tbl_cntbySomeField_d <- collect(someTable_tbl_cntbySomeField)
someTable_tbl_cntbySomeField_d

    user  system elapsed
   0.152   0.049  13.959

someTable_tbl_cnttot_d <- someTable_tbl_cntbySomeField_d %>% ungroup() %>%  summarize(SomeFieldDistinct = n(), cntrows = sum(count))
someTable_tbl_cnttot_d

SomeFieldDistinct
cntrows

<int>
<dbl>

11085
31443593

Sample code and results in Hive CLI

hive> select count(*) from someTable_tbl;

OK
31443593
Time taken: 1.058 seconds, Fetched: 1 row(s)

@GaryWMN Consider the following code:
>library(sparklyr)
>library(dplyr)

>sc <- spark_connect(master = "local", version = "2.0.1")
>iris_tbl <- copy_to(sc, iris)

>iris_tbl %>% select(Petal_Width) %>% count %>% sql_render
<SQL> SELECT count(*) AS `n`
FROM (SELECT `Petal_Width` AS `Petal_Width`
FROM `iris`) `qyggirrgrp`

>iris_tbl %>% count %>% sql_render
<SQL> SELECT count(*) AS `n`
FROM `iris`

As you can see, selecting the Petal_Width field is creating a nested query that is increasing execution times as you correctly point out. We could consider optimizing queries in dplyr or sparklyr; however, for correctness, it should be the Spark project the ones that take this task since there might be cases where the optimization is not performant or possible at all.
Bottomline, we should try to write dplyr and SQL statements that are as concise as possible to reduce overhead.

Thanks for the feedback and patience with a learner.


Update cacerts for debian 13 & ubuntu 24

Add updates for new distros...

I'll need to republish the JDK8, JDK11 , JDK17 packages with a spec bump for the April release after this is merged.


fix(deps): update helm release sysdig-deploy to v1.67.4

This PR contains the following updates:

Package
Type
Update
Change

sysdig-deploy (source)
helm_release
patch
1.67.2 -> 1.67.4

Release Notes

sysdiglabs/charts (sysdig-deploy)
v1.67.4
Compare Source
What's Changed
Chores

kspm-collector,node-analyzer 5189fe6b: release kspm-collector & node-analyzer (#2020)

Full diff: https://github.com/sysdiglabs/charts/compare/sysdig-deploy-1.67.3...sysdig-deploy-1.67.4
v1.67.3
Compare Source
What's Changed
Chores

cluster-shield,sysdig-deploy 0b00754b: bump cluster-shield to version 1.5.0 (#2015)

Full diff: https://github.com/sysdiglabs/charts/compare/sysdig-deploy-1.67.2...sysdig-deploy-1.67.3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.3.14 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


LibraryParams

Added file to List the Parameters in a Library Object -- Note previous files may not be uptodate

Please add your command to the code base of the Add-On in the archicad-addon folder so it will be available in the Tapir Add-On. See some instructions here, and let me know if I can help with the implementation.
(The current PR duplicates the entire Add-On in a separate folder, and I can't find anywhere the implementation of the new command. The implementation of the class LibraryParamsCommand is the same as the ReloadLibrariesCommand class).

GitHub pul request are very conflusing as to what is submitted and what is under review I think this inconsistency is beyond me.


Translation of "Library" into Spanish

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

First things first: great documentation!
However, I have seen on many pages that "Library" has been translated into Spanish as "Librería". This is what in Spanish is known as an "anglicismo" or anglicism: a word from the English language used in another. I understand that the correct translation should be "Biblioteca", like in "biblioteca de clases" o "biblioteca de funciones". WIthout further ado, I congratulate you on the work done.

Thanks for filing this issue! The MDN team doesn't maintain the translations, feel free to update the wiki pages for the Spanish translation yourself.


0.5.2 Suggestions

What feature do you want to get added on the base engine?

A Settings Option where you can change the Maximum size of the icons when they zoom in, change the speed of the icons, or change the icon's offset for the zooming in
Mic'd Up's Settings such as: Hue, Brightness, Gamma, Filters, Hitsounds (Can be customized to use a custom Hitsound)
New Modifier for the Song Modifier Menu: Song Speed (Will adjust the speed and pitch of the song)

No
Filters exist for your notes, and hitsounds you can literally make them with lua
No


WIP: MAISTRA-2051 fixes for maistra install

Signed-off-by: rcernich<EMAIL_ADDRESS>Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@bison, @dgn FYI.  These are the changes I've had to make so far to get pilot working with maistra.  For whatever reason, it doesn't appear that endpoint/pod watch is working for namespaces outside the system namespace (e.g. istio-system).

/retest

/test unit


feat: Add elevation API & tests

feat: Add elevation API & tests
fix: Reduce numebr of calls made to the open-meteo API in the tests so that they pass

@AlienDwarf any chance you can take a look?
I'll probably have more features coming to support paid customers via an API key, & maybe a way to log (or throw) API errors returned by the OpenMeteo API.


Added convenience functionality to 2D analysis code.  -MW

can I merge it with https://github.com/BBN-Q/Qlab/pull/62?

Sure!  Looks good to me.

@matthewware can you change your PR target to the branch in  #62 ? So that I merge them with each other before develop

@dieris is this what you were thinking?  I had to merge the two PR's since they were both upstream.

That was nice how GitHub figured out to close this PR.


[MINOR][DOC] Add two migration tips for Hive

What changes were proposed in this pull request?

2 migration tips:

different string representation of decimal when use TRANSFORM syntax

local file system has changed from org.apache.hadoop.fs.LocalFileSystem to org.apache.hadoop.hive.ql.io.ProxyLocalFileSystem

Why are the changes needed?

Let user be aware of behavior changes when they upgrade to Spark3.0
Does this PR introduce any user-facing change?

No, new doc for Spark 3.0.
How was this patch tested?

N/A.

cc @cloud-fan @gatorsmile

Test build #118796 has started for PR 27670 at commit 5474b74.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23547/
Test PASSed.

Test build #118796 has finished for PR 27670 at commit 5474b74.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118796/
Test PASSed.

Thanks for the review, updated. @srowen @yhuai

Test build #118838 has started for PR 27670 at commit a2a6e1b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23587/
Test PASSed.

Test build #118840 has started for PR 27670 at commit c310e67.

Test build #118838 has finished for PR 27670 at commit a2a6e1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118838/
Test PASSed.

Test build #118840 has finished for PR 27670 at commit c310e67.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118840/
Test PASSed.

Test build #118903 has started for PR 27670 at commit 679497c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23652/
Test PASSed.

Test build #118904 has started for PR 27670 at commit 0910a4c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23653/
Test PASSed.

Test build #118904 has finished for PR 27670 at commit 0910a4c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 - In Spark 3.0, the deprecatedHiveContextclass has been removed. UseSparkSession.builder.enableHiveSupport() instead.

Test build #118903 has finished for PR 27670 at commit 679497c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118904/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118903/
Test FAILed.

retest this please.

Test build #118908 has started for PR 27670 at commit 0910a4c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23657/
Test PASSed.

Test build #118917 has started for PR 27670 at commit f5f8928.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23666/
Test PASSed.

Test build #118918 has started for PR 27670 at commit 6c6e7ff.

Test build #118908 has finished for PR 27670 at commit 0910a4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 - In Spark 3.0, the deprecatedHiveContextclass has been removed. UseSparkSession.builder.enableHiveSupport() instead.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118908/
Test PASSed.

Test build #118918 has finished for PR 27670 at commit 6c6e7ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118918/
Test PASSed.

Test build #118917 has finished for PR 27670 at commit f5f8928.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118917/
Test PASSed.

Test build #119014 has started for PR 27670 at commit b7e04b7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23761/
Test PASSed.

Test build #119014 has finished for PR 27670 at commit b7e04b7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119014/
Test FAILed.

Jenkins, retest this please.

Test build #119024 has started for PR 27670 at commit b7e04b7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23771/
Test PASSed.

Test build #119024 has finished for PR 27670 at commit b7e04b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119024/
Test PASSed.

thanks, merging to master/3.0!

thanks all!!


Gifv not downloading

created by thomas694: TumblThreeApp/TumblThree#197
Hi, I have similar problem.
blog: multiboot2.tumblr.com
After I added blog and select to download everything it doesn't download first post with 2 gifs. Maybe something else also but there is a lot posts and didn't check everything.
Also I get wrong name with video in different post it has default name.
Reblogged both posts so you can find which ones are wrong: https://www.tumblr.com/blog/dajotim937
Originally posted by @dajotim937 in https://github.com/TumblThreeApp/TumblThree/issues/196#issuecomment-995436719

created by @thomas694 at 2021-12-17T19:38:39Z:
It seems like gifv files aren't downloaded properly.
What do you mean by video gets wrong name? At least the video from that blog gets the correct name, or not?

created by @dajotim937 at 2021-12-17T22:11:28Z:

What do you mean by video gets wrong name? At least the video from that blog gets the correct name, or not?

So first post that I repost (second now third from top in my blog) there is photo and video. I setup some filename template. But video gets default name tumblr_quiv5jcFTf1xg8h61 instead my template.
Also gifv are downloading when I'm using SVC downloader instead of API. And for multiboot2.tumblr.com API downloader download only 71 content files and SVC 277. Should I use SVC for all blogs?

created by @thomas694 at 2021-12-17T22:55:47Z:

Also gifv are downloading when I'm using SVC downloader instead of API. And for multiboot2.tumblr.com API downloader download only 71 content files and SVC 277. Should I use SVC for all blogs?

Normally when adding a blog the crawler type is automatically chosen. This one is a hidden/dashboard blog, so only the SVC crawler is the correct one, although the API crawler can still download a few posts.

created by @thomas694 at 2021-12-18T14:35:07Z:
The background for the behavior you have seen is the following. I'm neither saying wrong or correct, that depends.
You download a "new" blog into an existing folder and expect that nothing new is downloaded as the media files are already there. I haven't tested if changing the crawler/downloader type really changes the outcome, but changing the input parameters (settings) might not produce the same output.
One reason is you did the tests on two different days. The link was not downloaded before (deleted index folder), but then the filename got the current date (%d argument which should be post date normally). In normal cases the link is recognized as duplicate and no download is done in the first place.
Another reason is that the second post has the format of a "regular" (text) post, yes, it's a reblog, but the "source" has the same style/type. The images and video are placed as html inside a "regular body" field. In that case the properties of the post are not totally/correctly inherited therefore taking the current date. I think we should change something there.

created by @dajotim937 at 2021-12-17T23:01:31Z:
Tested a bit more:
Gifv not downloading on my https://www.tumblr.com/blog/dajotim937 blog with SVC and downloading with API. So reverse situation compared to multiboot2 blog.
Also there some date offset problem I guess.

Download https://dajotim937.tumblr.com/ with first downloader (any of both).
Close program, delete Index folder (where data for blog are saved)
Open program, add blog again, change download folder from *\dajotim937_2 to *\dajotim937
Select second downloader and start download.
Got 2 files that both have copies.
With template %b_%d_%i_%f for first reblogged post (second in blog from top) I got:
dajotim937_20211215_670700556366626816_d1c856d5d8e62d9445a20ec7faf2a0a98866cd84.jpg and
dajotim937_20211216_670700556366626816_d1c856d5d8e62d9445a20ec7faf2a0a98866cd84.jpg for pics;
And
dajotim937_20211215_670700556366626816_tumblr_quiv5jcFTf1xg8h61_frame1.jpg
dajotim937_20211216_670700556366626816_tumblr_quiv5jcFTf1xg8h61_frame1.jpg for pic of first video frame.

Normally when adding a blog the crawler type is automatically chosen. This one is a hidden/dashboard blog, so only the SVC crawler is the correct one, although the API crawler can still download a few posts.

Okay, got it. Thank you.

created by @dajotim937 at 2021-12-18T17:18:57Z:

but changing the input parameters (settings) might not produce the same output.

What input parameters do you mean? I changed only type downloader for same 2 posts. %d shouldn't be changed because post date doesn't change.

One reason is you did the tests on two different days.

My blog for tests is small, so tested almost in same minute.
Looks like crawlers are using different response date field.
This is text.txt output from API:
Post id:<PHONE_NUMBER>66626816
Date: Wed, 15 Dec 2021 23:44:54
Post url: https://dajotim937.tumblr.com/post/670700556366626816
Slug:
Reblog key: 8gby3HUo
Reblog url: https://multiboot2.tumblr.com/post/655913565144907776
Reblog name: multiboot2
Title:

celeb-mix2-and-germans:

<figure class="tmblr-full" data-orig-height="932" data-orig-width="586" data-npf='{"type":"video","provider":"tumblr","url":"https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4","media":{"url":"https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4","type":"video/mp4","width":586,"height":932},"poster":[{"url":"https://64.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61_frame1.jpg","type":"image/jpeg","width":586,"height":932}],"filmstrip":{"url":"https://64.media.tumblr.com/previews/tumblr_quiv5jcFTf1xg8h61_filmstrip.jpg","type":"image/jpeg","width":2000,"height":317}}'><video controls="controls" autoplay="autoplay" muted="muted" poster="https://64.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61_frame1.jpg"><source src="https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4" type="video/mp4"></source></video>

Tags:

And this is from SVC:
Post id:<PHONE_NUMBER>66626816
Date: 2021-12-16 04:44:54 GMT
Post url: https://dajotim937.tumblr.com/post/670700556366626816
Slug:
Reblog key: 8gby3HUo
Reblog url: https://multiboot2.tumblr.com/post/655913565144907776
Reblog name: multiboot2
Summary:
Title:

celeb-mix2-and-germans:

<figure class="tmblr-full" data-orig-height="932" data-orig-width="586" data-npf='{"type":"video","provider":"tumblr","url":"https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4","media":{"url":"https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4","type":"video/mp4","width":586,"height":932},"poster":[{"url":"https://64.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61_frame1.jpg","type":"image/jpeg","width":586,"height":932}],"filmstrip":{"url":"https://64.media.tumblr.com/previews/tumblr_quiv5jcFTf1xg8h61_filmstrip.jpg","type":"image/jpeg","width":2000,"height":317}}'><video controls="controls" autoplay="autoplay" muted="muted" poster="https://64.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61_frame1.jpg"><source src="https://va.media.tumblr.com/tumblr_quiv5jcFTf1xg8h61.mp4" type="video/mp4"></source></video>

Tags:

And there https://dajotim937.tumblr.com/api/read is several fields for post. I guess one downloader is using date-gmt/timestamp and other is using regular date field.
date-gmt="2021-12-16 04:44:54 GMT" date="Wed, 15 Dec 2021 23:44:54" unix-timestamp="1639629894"
So i rebloged one more post and for my current time zone +2 date-gmt/timestamp are correct ones for post date in current blog.

created by @thomas694 at 2021-12-18T19:55:59Z:
Thanks for your additional tests and information.

created by @thomas694 at 2021-12-23T20:49:22Z:
The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.

created by @AlexFundorin at 2022-01-02T13:56:09Z:
Sorry for offtopic, but how do I convert gifv, which seems to be mp4 video in webp format, to a regular mp4? Batch convert, preferably, or automatically, by TumblThree, when downloading.

created by @thomas694 at 2022-01-02T21:31:12Z:
The question would be, what gifv file are you talking about? One downloaded by TumblThree and served from their servers, one served from external link, or one saved from browser?
Afaik, the first is already the original gif, only with 'wrong' file extension. So, any tool that can rename from gifv to gif would be suitable. But as you speak of webp it's either 2 or 3.
If necessary and you have a safe example post, you can post it here.

created by @dajotim937 at 2022-01-07T12:43:13Z:

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.

@thomas694
Hi. Still get this error, last build version. Api response is "date-gmt": "2021-12-26 23:58:26 GMT","date": "Sun, 26 Dec 2021 18:58:26" but some how %d in filename 20211227.

created by @thomas694 at 2022-01-07T18:13:07Z:
@dajotim937
That means the poster is living in respectively the blog's time zone is set to US east coast time, while you are living east of GMT, isn't it?
If you are living west of GMT, you can expect this file to be shown on 26, east of GMT on 27. If you change the time zone of your PC to GMT-5 your file should show the date like Sun, 26 Dec 2021 18:58:26.

created by @dajotim937 at 2022-01-07T19:35:12Z:

That means the poster is living in respectively the blog's time zone is set to US east coast time, while you are living east of GMT, isn't it?

Well maybe, but that doesn't answer why filename contain 20211227 date, if it should use GTM date and GMT is 2021-12-27.
Doesn't this commit says that Now always GMT time is used.? I posted both dates because they both doesn't contain 2012-12-27 date, but somehow it is in template.

created by @thomas694 at 2022-01-07T23:03:55Z:
Ok, maybe now I understand what you expect. You would expect that the filename uses GMT and the file time in explorer is shown in local time (as that's the way windows handles it), right?
No, that commit uses now the GMT time field as original value (before sometimes GMT, sometimes local) and it's used for setting the file's time and creating the filename part, at the end both showing in local time.
I think that's a tricky question. Should the filenames be in GMT, so that everyone on the world creates the same names, even so the majority of the time the filename and the displayed file time differ, or should the filenames be in local time, so that they are 'equal' to this single user.
Before the filename template, there was only the file time and windows (by design) shows it in local time. I think I just kept this pattern without thinking to much on GMT standardization.
Whoever has an opinion might throw it in.

created by @dajotim937 at 2022-01-08T03:23:59Z:

You would expect that the filename uses GMT and the file time in explorer is shown in local time (as that's the way windows handles it), right?

Don't really understand about the file time in explorer. I talk about only date in filename, where template for name with %d key should replaced by GMT time. Reread your sentence. The file time part confused me, because as for me, it doesn't really matter which time is using in file time attribute. Didn't even think about it. Well, I think yes, that behavior I would expect.

at the end both showing in local time.

Oh, okay. Didn't understand that.

Should the filenames be in GMT, so that everyone on the world creates the same names, even so the majority of the time the filename and the displayed file time differ, or should the filenames be in local time, so that they are 'equal' to this single user.

I prefer GMT in filenames. You could add new key in filename template and specify that %d is using converted time to current timezone and other is using GMT without converting.
Maybe you or I should create new issue, because for new users who check issues it isn't clear that this one ended with time\timezone question. Don't know if you can move some posts to other issue thread.

Hi,
no worries! It might come in the next version.
Tumblr is literally using "GMT" in one of their textual time representations, Twitter is omitting that term. Both using small changes from standard patterns.
Out of "UTC" only letter C would be left, while for "GMT" letters G and M are left.
So, we should go for the token %g as it's also the first letter of the word.

Okay. Thank you.=)

Users had different expectations about which time zone and whether date and time or date only should be used.
So we added three new filename template tokens %e, %g, %h for date and time in local/GMT and short/long format.
  %d  post date (yyyyMMdd)
  %e  post date and time (yyyyMMddHHmmss)
  %g  post date in GMT (yyyyMMdd)
  %h  post date and time in GMT (yyyyMMddHHmmss)

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.


[unity] Fix links

Follow up to #1760, but use anchor refs.

same for 2018

Was EOL already so didn't bother correcting those.

got it thx 👍


How to change 'Turn LED on' word to Something

Hi, i would like to control (Turn on/off) GPIO , and the example from here :- https://developers.google.com/assistant/sdk/guides/library/python/extend/handle-device-commands worked perfectly , i would like to on/off the GPIO using a custome Word .
Thanks

Then you will want to set up custom device actions

Thanks @Fleker  i'll check that .


rgw: Add default quota configs

Add user max size and user max objects and bucket max size quota config to ceph conf
Signed-off-by: Seena Fallah<EMAIL_ADDRESS>

Hi @clwluvw
please, take a look at the documentation [1].

We will no longer accept pull requests that modify the ceph.conf template unless it helps the deployment. For simple configuration tweaks please use the ceph_conf_overrides variable.

[1] https://github.com/ceph/ceph-ansible/blob/master/docs/source/index.rst#cephconf-configuration-file

@guits But why the max_objects is defined and max_size isn't defined? Isn't that inconsistency?

this was added before we decided to stop modifying ceph.conf.j2 and was probably kept for backward compatibility concerns.

@guits Makes sense but if we could add these too the quota default section for ansible would be complete :)

@guits Makes sense but if we could add these too the quota default section for ansible would be complete :)
Now the ansible config gets dirty because one of is in ceph_conf_overrides the other isn't.

@guits Makes sense but if we could add these too the quota default section for ansible would be complete :)
Now the ansible config gets dirty because one of is in ceph_conf_overrides the other isn't.

In fact, I would do the opposite: I would deprecate and remove what we've left in the ceph.conf.j2 so we keep consistency.

@guits Makes sense but if we could add these too the quota default section for ansible would be complete :)
Now the ansible config gets dirty because one of is in ceph_conf_overrides the other isn't.

In fact, I would do the opposite: I would deprecate and remove what we've left in the ceph.conf.j2 so we keep consistency.

Yes it fully depends on you. I think if we keep consistency here it would be so better in our ansible config.


Add MIT license

Summary of changes
Changes introduced in this pull request:

License needs to be changed to be a dual Apache-2.0 and MIT
Moved the license header file to the scripts folder to not confuse with actual license

Reference issue to close (if applicable)

Closes
Other information and links

License needs to be changed to be a dual Apache-2.0 and MIT

Under what circumstances would this be required?

I will defer this to @ansermino and/or @GregTheGreek.

I got the answer on Discord, sorry for the ping ❤


Problem when saving/loading keras model with '.tf' extension and stateful ConvLSTM2D as a layer

System information

WSL Win10 Ubuntu 18.04 (it also happens in a real ubuntu 18)
tf-nightly-gpu-2.0-preview==2.0.0.dev20190802 (happens in cpu and gpu)
python3.7

Describe the current behavior
I have a simple test to serialized and deserialize a model which has a stateful LSTM. The 'tf' version returns an error, the 'h5' version works ok.
Describe the expected behavior
Correct serialization and deserialization of the code in both cases.
Code  to reproduce the issue
import tensorflow as tf
from tensorflow.keras import layers, models

model = models.Sequential()
model.add(layers.ConvLSTM2D(32, (3, 3), activation='relu', batch_size=32, input_shape=(1, 28, 28, 1), padding='same', strides=2,
                            stateful=True))
model.add(layers.Conv2DTranspose(64, (3, 3), strides=2, padding='same'))
model.add(layers.Conv2D(1, (3, 3), activation='sigmoid', padding='same'))
model.compile(optimizer='adam', loss=['mse'])
model.save('teste.tf')
model = tf.keras.models.load_model('teste.tf')
print(model)

2019-08-03 04:32:09.606349: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2019-08-03 04:32:09.606533: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: UNKNOWN ERROR (303)
2019-08-03 04:32:09.606718: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (DESKTOP-GUERINJR): /proc/driver/nvidia/version does not exist
2019-08-03 04:32:09.607091: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-08-03 04:32:09.616262: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-08-03 04:32:09.617989: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7ffff2cf88d0 executing computations on platform Host. Devices:
2019-08-03 04:32:09.618144: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default Version
WARNING: Logging before flag parsing goes to stderr.
W0803 04:32:10.136887<PHONE_NUMBER>52448 save.py:130] Skipping full serialization of object <tensorflow.python.keras.layers.convolutional_recurrent.ConvLSTM2D object at 0x7f69f49960f0>, because an error occurred while tracing layer functions. Error message: Expected Operation, Variable, or Tensor, got None
2019-08-03 04:32:10.714903: W tensorflow/python/util/util.cc:288] Sets are not currently considered sequences, but this may change in the future, so consider avoiding using them.
W0803 04:32:10.904490<PHONE_NUMBER>52448 deprecation.py:506] From /home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/ops/resource_variable_ops.py:1784: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass *_constraint arguments to layers.
Traceback (most recent call last):
  File "/home/nguerinjr/Documents/deep_coding_project/img_common/teste.py", line 21, in <module>
    model.save('teste.tf')
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/network.py", line 1164, in save
    saving.save_model(self, filepath, overwrite, include_optimizer, save_format)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/keras/saving/save.py", line 107, in save_model
    saved_model_save.save(model, filepath, overwrite, include_optimizer)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/keras/saving/saved_model/save.py", line 86, in save
    save_lib.save(model, filepath)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/saved_model/save.py", line 855, in save
    meta_graph_def, saveable_view, signatures)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/saved_model/save.py", line 585, in _fill_meta_graph_def
    signatures = _generate_signatures(signature_functions, resource_map)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/saved_model/save.py", line 459, in _generate_signatures
    function, mapped_inputs, resource_map)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/saved_model/save.py", line 411, in _call_function_with_mapped_captures
    function.graph.captures, resource_map)
  File "/home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/saved_model/save.py", line 333, in _map_captures_to_created_tensors
    .format(interior))
AssertionError: Tried to export a function which references untracked object Tensor("StatefulPartitionedCall/args_4:0", shape=(), dtype=resource).TensorFlow objects (e.g. tf.Variable) captured by functions must be tracked by assigning them to an attribute of a tracked object or assigned to an attribute of the main object directly.

Process finished with exit code 1

Working code  for comparisons
When not stateful, the code works ok
import tensorflow as tf
from tensorflow.keras import layers, models

model = models.Sequential()
model.add(layers.ConvLSTM2D(32, (3, 3), activation='relu', batch_size=32, input_shape=(1, 28, 28, 1), padding='same', strides=2))
model.add(layers.Conv2DTranspose(64, (3, 3), strides=2, padding='same'))
model.add(layers.Conv2D(1, (3, 3), activation='sigmoid', padding='same'))
model.compile(optimizer='adam', loss=['mse'])
model.save('teste.tf')
model = tf.keras.models.load_model('teste.tf')
print(model)

2019-08-03 04:36:08.915912: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2019-08-03 04:36:08.916094: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: UNKNOWN ERROR (303)
2019-08-03 04:36:08.916278: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (DESKTOP-GUERINJR): /proc/driver/nvidia/version does not exist
2019-08-03 04:36:08.916617: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-08-03 04:36:08.925594: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-08-03 04:36:08.927217: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fffe038cb10 executing computations on platform Host. Devices:
2019-08-03 04:36:08.927361: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default Version
2019-08-03 04:36:10.081493: W tensorflow/python/util/util.cc:288] Sets are not currently considered sequences, but this may change in the future, so consider avoiding using them.
WARNING: Logging before flag parsing goes to stderr.
W0803 04:36:10.614284<PHONE_NUMBER>00320 deprecation.py:506] From /home/nguerinjr/Documents/deep_coding_project/venv/lib/python3.7/site-packages/tensorflow_core/python/ops/resource_variable_ops.py:1784: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass *_constraint arguments to layers.
<tensorflow.python.keras.saving.saved_model.load.Sequential object at 0x7f56a80c2cf8>

Process finished with exit code 0

** Working code 2 for comparisons**
When 'h5' works ok in both cases
import tensorflow as tf
from tensorflow.keras import layers, models

model = models.Sequential()
model.add(layers.ConvLSTM2D(32, (3, 3), activation='relu', batch_size=32, input_shape=(1, 28, 28, 1), padding='same', strides=2))
model.add(layers.Conv2DTranspose(64, (3, 3), strides=2, padding='same'))
model.add(layers.Conv2D(1, (3, 3), activation='sigmoid', padding='same'))
model.compile(optimizer='adam', loss=['mse'])
model.save('teste.h5')
model = tf.keras.models.load_model('teste.h5')
print(model)

2019-08-03 04:37:27.733190: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2019-08-03 04:37:27.733380: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: UNKNOWN ERROR (303)
2019-08-03 04:37:27.733531: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (DESKTOP-GUERINJR): /proc/driver/nvidia/version does not exist
2019-08-03 04:37:27.733891: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-08-03 04:37:27.743100: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-08-03 04:37:27.745015: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fffd380cc50 executing computations on platform Host. Devices:
2019-08-03 04:37:27.745198: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default Version
<tensorflow.python.keras.engine.sequential.Sequential object at 0x7f32b028f550>

Process finished with exit code 0

import tensorflow as tf
from tensorflow.keras import layers, models

model = models.Sequential()
model.add(layers.ConvLSTM2D(32, (3, 3), activation='relu', batch_size=32, input_shape=(1, 28, 28, 1), padding='same', strides=2,
                            stateful=True))
model.add(layers.Conv2DTranspose(64, (3, 3), strides=2, padding='same'))
model.add(layers.Conv2D(1, (3, 3), activation='sigmoid', padding='same'))
model.compile(optimizer='adam', loss=['mse'])
model.save('teste.h5')
model = tf.keras.models.load_model('teste.h5')
print(model)

2019-08-03 04:37:48.546310: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2019-08-03 04:37:48.546554: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: UNKNOWN ERROR (303)
2019-08-03 04:37:48.546700: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (DESKTOP-GUERINJR): /proc/driver/nvidia/version does not exist
2019-08-03 04:37:48.547055: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-08-03 04:37:48.556123: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-08-03 04:37:48.557773: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fffcde1a9a0 executing computations on platform Host. Devices:
2019-08-03 04:37:48.557917: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default Version
<tensorflow.python.keras.engine.sequential.Sequential object at 0x7f091c0ac860>

Process finished with exit code 0

I am able to reproduce the issue on Colab with tf-nightly-gpu-2.0-preview==2.0.0.dev20190802. Please take a look at Colab. Thanks!

Assign to Kathy who works on save model.

@nguerinjr  Looks like this was resolved in recent tf-nightly. I was not able to reproduce the issue. Please check the gist here.
Please close the issue if it was resolved for you. Thanks!

Closing this as this issue has been fixed.

I have noticed the same problem on stable tensorflow 2.1.
Is there a regression test for this ? Does it pass ?
Maybe we need to reopen this issue.

I also have a similar issue on 2.2 with saving/loading models with stateful GRU layers in TF format.
I think the issue should be reopened.


Encoding problem under lastest padrino

Hi  @ujifgc  , As issue #2143  mentioned ,I have a project using padrino version <IP_ADDRESS> and upgrade to lastest version <IP_ADDRESS>, Some encoding problem occured , as following:
E:\aocproject>padrino g admin -e erb
d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/padrino-admin-<IP_ADDRESS>/lib/padrino-admin/generators/actions.rb:75:in `scan': invalid byte sequence in GBK (ArgumentError)
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/padrino-admin-<IP_ADDRESS>/lib/padrino-admin/generators/actions.rb:75:in `fetch_app_name'
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/padrino-admin-<IP_ADDRESS>/lib/padrino-admin/generators/admin_app.rb:57:in `create_admin'
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/invocation.rb:133:in `block in invoke_all'
        from d:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/invocation.rb:133:in `each'

Is there any solutions?  Thanks.

I do not have this problem with <IP_ADDRESS> on Windows using 2.2.6.
actions.rb:75 (or somewhere close to there) tries to read your app.rb file. It's likely this file's encoding does not match Ruby's default external encoding (Encoding.default_external) (Mine is IBM437 --I'm in the USA).
In the short-term, I'd try to figure out what that file's encoding is and set it via:
set rubyopt="-E Windows-1252"

Then try running padrino g admin -e erb again.
Note that the argument to -E must match what Ruby supports. For this list see the results of Encoding.list.

Since 6609b907579ec1b560c978a462ff2ed350a2ea35 0.14.0 Padrino does not manage your project encoding.
If you use in your files encoding other than your system encoding you could set this in your config/boot.rb:
Encoding.default_external = Encoding::UTF_8 # or whatever encoding you use in your files

Hi @sshaw , Thanks for your help, I try those instructions and get error message like this:
E:\aocproject>set rubyopt="-E'Windows-1252'"
E:\aocproject>padrino g admin -e erb
d:\RailsInstaller\Ruby2.2.0\bin\ruby.exe: invalid option -"  (-h will show valid options) (RuntimeError)

use this style will work fine.
set rubyopt=-E Windows-1252


Read from buffer?

I cannot seem to parse utf8 encoded string (from buffer) using plist.readFileSync. Is this currently possible?

Sorry for the exceptionally delayed reply, but as I'm sure you've already discovered, the answer is no. Under the hood, readFileSync is passing the argument into fs.readFileSync (see here) which wouldn't take a buffer either. However, you can pass descriptor representing an already open file if you'd like.
The parse function is probably what you're after since that is designed to accept a buffer, though the encoding still might throw you off.


[3.5] Fix TileMap texture offset for navigationmesh and collisionshapes

[3.5] Fix TileMap texture offset for navigationmesh and collisionshapes.
The texture offset was not added to naypolygons or collisionshapes and their debugs.

Fixes #43214
... tbh no idea if this fixes everything ... the old 3.x tilemap code is big headache ... but the MRP works.

Thanks!

For the records, this broke compatibility in my project. However, I'm not opening an issue since I don't know for sure which behavior is more correct than the other.
I had the following in my tiles.tscn that I convert to a TIleSet via Scene-> Convert To (old style, I know):
[node name="gothic_block_1x1_thin_lh" type="Sprite" parent="."]
modulate = Color( 0.730469, 0.730469, 0.730469, 1 )
material = ExtResource( 2 )
position = Vector2( 2004, 992 )
texture = ExtResource( 4 )
offset = Vector2( 0, 76 )
region_enabled = true
region_rect = Rect2( 1536, 1024, 128, 52 )

[node name="StaticBody2D" type="StaticBody2D" parent="gothic_block_1x1_thin_lh"]
position = Vector2( 0, 76 )

[node name="CollisionShape2D" type="CollisionShape2D" parent="gothic_block_1x1_thin_lh/StaticBody2D"]
shape = SubResource( 12 )

Runtime (in a TileMap with debug collisions):

After updating to a more recent Godot 3.x, this is how the collision shape is positioned at runtime:

I've roughly tracked the issue down to this PR.
I can fix the runtime issue it by setting StaticBody2D's position to (0, 0), but then it looks like this in the tiles scene in the editor:

Again, I'm not sure if the problem is just that the workflow of editing tile sets in a scene is not expected to be WYSIWYG and the current situation is the good one. However, I believed I had to warn about the compat breakage.

This also broke one of my projects. I'm going to hold off changing anything because I'm not sure if I should change all my tiles (a long, tedious task) or wait for this possible regression to be possibly fixed? Perhaps another offset field can be added so that we can keep the original behavior?

It could be part of the compatibility_mode property or a new one.

Here is what happens to my tiles from 3.4.4 to 3.5.0 (release build):

Oddly, they look identical in both Godot editors... it's at runtime when they change

It could be part of the compatibility_mode property or a new one. Feel free to open an issue.

I'm not sure the status of this issue. I see this is merged, does that mean it's fixed? Or is this merge the cause of the issue? Does a new issue need to be opened?

This PR fixed another issue, but according to the recent comments, it introduced an incompatibility. A new issue can be opened about the new problem, which will make it easier to track there than in a merged PR. Not many people will read the comments here, so chances of resolving this are lower.

This pr only fixed the offset, the other compatibility problems with the navpoly are related to another pr that fixed the broken tileset navpoly format.
The incompatibility is the pre Godot 3.5. tileset that created and stored navpolygon resources in a way that is hot garbage for a navpoly resource (vertex in wrong order, resource format wrong, ...) which was fixed for Godot 3.5. because otherwise 2D tileset couldn't work with the new navigation system and NavigationServer that required the correct navpoly format.
While the annoyance is understandable for the individual project the Godot 3.5 release had navigation compatibility breaking in the announcement so I don't understand why we should create new issues for broken compatibility with pre 3.5. created projects, especially cause the incompatibility happended due to to glaring, yearold navigation bugs being fixed in Godot 3.5.

This pr only fixed the offset, the other compatibility problems with the navpoly are related to another pr that fixed the broken tileset navpoly format.
The incompatibility is the pre Godot 3.5. tileset that created and stored navpolygon resources in a way that is hot garbage for a navpoly resource (vertex in wrong order, resource format wrong, ...) which was fixed for Godot 3.5. because otherwise 2D tileset couldn't work with the new navigation system and NavigationServer that required the correct navpoly format.
While the annoyance is understandable for the individual project the Godot 3.5 release had navigation compatibility breaking in the announcement so I don't understand why we should create new issues for broken compatibility with pre 3.5. created projects, especially cause the incompatibility happended due to to glaring, yearold navigation bugs being fixed in Godot 3.5.

I have a question, if you know (or someone else knows). Let's say I spend the time to redo my tiles from Godot 3.4 to 3.5. Will I need to do that again for Godot 4, or will tiles be compatible from 3.5 to 4.0?

Tiles in 4.0 use completely different format, so if you plan to upgrade to 4.0 eventually, it's better to do it directly.

Thanks for the speedy response! I'll hold off until 4.0 then :)
FWIW I mitigated this issue by using Capsule shape for characters feet instead of Rectangle shape. So I could ugprade to 3.5 if necessary, although my tiles would look 1 pixel off

I am porting a game that was built in Godot 3.3. It uses collisions in tiles.
When I ported it to Godot 3.5, all collisions had a vertical offset.
I rebuilt the engine by reverting the changes in this PR and it worked again as expected.
It might be good to have a compatibility option in "Project settings" instead of forcing the users to fix every collision if they want to update the engine.
In my case, I just rebuilt it without the "+ offset"


It can't work normally when the inputs is an array of object.

Hi, I'm glad to use the amazing tool. But I find that it seems that it can't work normally when the inputs is an array of object. And  I don't know if my operating as following is wrong, could you pls give me some advice, thx.

Hi @Kenscofield, thanks for your feedback!
This is one of the things that we are aware of and plan to build upon in future with additional nodes (similar to loop/repeater). The best approach when using array of outputs (COLLECT) in the meantime is through a function. See more information in the following discussion:
https://github.com/gorules/zen/discussions/90

Hi @stefan-gorules, thanks for your reply.
The disussion #90 is that the output is an array of obj, but waht I'm asking is the input is an array of obj. Is the way of solving the two cases same?

By the way, if I use the function node as one of the input column of the decision table, is there any difference from filter something  without the goRules? I'm looking forword for your reply.
Thx

I see what you mean @Kenscofield, it seems that this issue stems from using https://editor.gorules.io which doesn't have the most recent version. When running it on latest zen-engine I get the following:
isolate.inject_env(&json!({ "activeEvents": [{ "id": 1 }, { "txt": 2 }] })); // this is our ENV

We will try to update our https://editor.gorules.io when we get some time.
Regarding your 2nd comment, you can use filter in either your code or within GoRules, it is up to you to decide. Usually this decision depends on what you want to be controlled within Rules Engine, and what you want outside. Performance wise it's better to filter outside of GoRules as JavaScript isolates have a small start-up time.
Below I'm attaching JSON file of how I would achieve what you're describing, and some code for Node.JS on how you can run it (Python and Rust have similar approach). Best place to preview it is on storybook until we update editor. https://gorules.github.io/jdm-editor/?path=/story/decision-graph--controlled
zen-issue-96.json
import { ZenEngine } from '@gorules/zen-engine';
import * as fs from 'fs';

(async () => {
  const engine = new ZenEngine();
  const decisionData = fs.readFileSync('zen-issue-96.json');

  const decision = engine.createDecision(decisionData);
  const response = await decision.evaluate({ activeEvents: [{ id: 1 }, { txt: 2 }] });
  console.log(response);
})();

That's so great. I will try it again. And I'm waiting for your team updating on the editor.
Thanks for your patience

hi @stefan-gorules, could you please help check the case. It seems soemthing wrong.

Hi @Kenscofield,
Based on what you're trying to achieve, I'd approach it in the following way:

Hello @stefan-gorules

This is one of the things that we are aware of and plan to build upon in future with additional nodes (similar to loop/repeater).

Any update on this feature? It would be great enhancement. I was looking for a way to handle an array of objects in the input context but I did not find any, other than doing everything in the JavaScript lambda component.
We are building settlement system and those rules are quite complicated billing rules (pricing). In my use case non-technical people would be using JDM Editor to update the decision table values, so I can't really ask them to edit JavaScript code.
So far the solution we choose is to launch rule evaluation on each item separately from app code (so input is just one object)

Hi, this has been addressed in the new version of GoRules. Please refer to:
https://gorules.io/docs/user-manual/decision-modeling/data-flow and https://gorules.io/docs/user-manual/decision-modeling/loops


[otbn] P-256 optimization

This finishes #5334 and adds some tests I missed in the last PR.

This PR currently fails CI with "sw/otbn/code-snippets/meson.build:5:0: ERROR: File p256_curve_point_test.s does not exist." Do you think you can figure out how to fix that, or should I have a look? (Likely only a file rename in the meson build config.)

otbn_ecdsa_p256_test is failing now when executed on CW310, which seems very related to this PR. (But I'd expect you can reproduce the issue in Verilator as well.)
DEBUG    root:utils.py:363 I00014 boot_rom.c:66] Boot ROM initialisation has completed, jump into flash!
DEBUG    root:utils.py:363 I00000 otbn_ecdsa_p256_test.c:117] Initialization took 95499 cycles or 954 us @ 100 MHz.
DEBUG    root:utils.py:363 I00001 otbn_ecdsa_p256_test.c:257] Signing
DEBUG    root:utils.py:363 I00002 otbn_ecdsa_p256_test.c:117] Sign took 759131 cycles or 7591 us @ 100 MHz.
DEBUG    root:utils.py:363 E00003 otbn_ecdsa_p256_test.c:91] CHECK-fail: signature_r: mismatch at byte 0: 0x0 (actual) != 0xb2 (expected)
DEBUG    root:utils.py:363 I00004 test_status.c:34] FAIL!

I had a closer look at the test failure now, and it comes from the restructuring of the p256.s file and the associated calling conventions. Before, the dptr_ symbols, as well as the corresponding symbols containing the referenced values were part of the DMEM image (global symbols in ecdsa_p256.s). After the [otbn] rework P-256 lib commit, the dptr symbols are part of another file, but not initialized any more. This is something the software now needs to do. I updated the relevant commit to include the necessary changes as well.
I'll give the rest of the code a closer review tomorrow.

@felixmiller It looks like your latest push did address the review comments, but did apply them to the original version that you pushed. In the meantime, I had pushed to this PR an updated version which fixed CI. This version was overwritten by your changes.  I'm sorry that I confused you in your own branch. I rebased the changes now to bring back the changes that fixed CI.
Before you do any further work on this PR please do a fetch from your fork and reset your local branch with those changes. (But we're probably done with this PR and won't need any of that, let's see what CI has to say.)


Missing IMU_Class::getTemp() function declaration

IMU_Class::getTemp() is defined in IMU_Class.hpp, but not implemented in IMU_Class.cpp which leads to a link error when attempting to leverage the function.
Here is a possible implementation for IMU_Class.cpp:
bool IMU_Class::getTemp(float *t) {
  bool res = false;

  switch (_imu) {
    case imu_t::imu_sh200q:
      res = Sh200q.getTemp(t);
      break;
    case imu_t::imu_mpu6050:
    case imu_t::imu_mpu9250:
    case imu_t::imu_mpu6886:
      res = Mpu6886.getTemp(t);
      break;
    case imu_t::imu_unknown:
    default:
      break;
  }

  return res;
}

I hope this helps!
PS: Working on an ESPHome wrapper for m5unified.

BTW Happy to turn this into a pull request if that helps.

PS: Working on an ESPHome wrapper for m5unified.

Oh I'm very interested in this, if it means I'd be able to use my Core2 with ESPHome!

Hello, @fxstein  .
Thanks for letting me know! It was very helpful.
A new update release will be prepared this weekend.

Glad I could help! Looking forward to the new release. Thanks!

Hello, @fxstein
v0.1.3 has been released.
Please try this Issue as it has been resolved.

Confirmed. This is resolved.


Add covsbom paper - issre 2024

Description:
This pull request is intended to upload the ISSRE 2024 paper about CovSBOM. The following changes have been made:

Updated the data.yml file.
Added CovSBOM paper pdf file to the papers folder.

No other files were modified.

@yzhang71 can you take a look at the yaml issue?

@yzhang71 can you take a look at the yaml issue?

Yeah, thanks for pointing that out! The new commit should fix the indentation issue.