Leading Hyphens in EAB Values Don't Work via CLI

Describe the bug
When the value for either the EAB Key Identifier or EAB HMAC Key begins with a leading hyphen, errors are encountered as they're interpreted as command line parameters rather than parameter values.
To Reproduce

Run with command line & 'C:\Program Files\win-acme\wacs.exe' --register --account "TestAccount1" --eab-key-identifier "-BrokenKid" --eab-key "FakeHmacKey"
Run with command line & 'C:\Program Files\win-acme\wacs.exe' --register --account "TestAccount1" --eab-key-identifier "FakeKid" --eab-key "-BrokenHmacKey"

Expected behavior
The parameter values should be interpreted as such instead of being interpreted as parameter names.
Log
PS C:\windows\system32> & 'C:\Program Files\win-acme\wacs.exe' --register --account "TestAccount1" --eab-key-identifier "ThisOneIsFine" --eab-key "FakeHmacKey"
A simple Windows ACMEv2 client (WACS)
Software version <IP_ADDRESS>1 (release, pluggable, standalone, 64-bit)
Connecting to https://acme.digicert.com/v2/acme/directory/...
Connection OK!
Scheduled task not configured yet
Please report issues at https://github.com/win-acme/win-acme
(AcmeProtocolException): the field 'kid' references an unknown key
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32> & 'C:\Program Files\win-acme\wacs.exe' --register --account "TestAccount1" --eab-key-identifier "-BrokenKid" --eab-key "FakeHmacKey"
Unknown argument --B, use --help to get a list of possible arguments
Error in main function: An exception was thrown while activating PKISharp.WACS.Host.Wacs -> PKISharp.WACS.RenewalManager -> PKISharp.WACS.RenewalRevoker -> PKISharp.WACS.Clients.Acme.OrderManager.
Press  to close
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32>
PS C:\windows\system32> & 'C:\Program Files\win-acme\wacs.exe' --register --account "TestAccount1" --eab-key-identifier "ThisOneIsFine" --eab-key "-BrokenFakeHmacKey"
Unknown argument --B, use --help to get a list of possible arguments
Error in main function: An exception was thrown while activating PKISharp.WACS.Host.Wacs -> PKISharp.WACS.RenewalManager -> PKISharp.WACS.RenewalRevoker -> PKISharp.WACS.Clients.Acme.OrderManager.
Press  to close
PS C:\windows\system32>
Platform:

OS: Windows Server 2019
Version: <IP_ADDRESS>1, 64-bit, pluggable

Additional context
Add any other context about the problem here, for example possible network issues (firewalls, proxies, NAT) that might play a role.

As far as I know and can tell there nothing that I can do to fix this, the command shell removes the quotes so from the .NET world there's no way to simple way know whether the next token is intended to be a new parameter or the value for the previous parameter.
In theory one could probably make good guesses based on semantic heuristics, but the command line library that we use (https://github.com/fclp/fluent-command-line-parser) is not that clever, nor actively maintained anymore.
The workaround is to add extra escaped quotes so that they'll get to .NET: --eab-key "\"-BrokenFakeHmacKey\"". I'll make sure to update the documentation for this, because it also applies to the script plugins.


Support all package sources in "pub global activate"

This issue was originally filed by @seaneagan

Currently we have:
    pub global activate <package> [<version>]
which is limited to binaries from "hosted" packages.  "path" and "git" packages are needed as well:
    https://www.dartlang.org/tools/pub/dependencies.html#dependency-sources
Seems like the most extensible way to do this would be to mimic how they are specified in pubspec.yaml:
    pub global activate <package> [<yaml snippet>]
Examples:
    pub global activate foo ">=1.0 <2.0"
    pub global activate foo "path: /path/to/foo"
    pub global activate foo "git: {url: 'git://...', ref: '...'}"
Suggesting yaml since there is no standard way to specify deep object literals via command line args.  Alternatively just add dedicated args for each package source type:
    pub global activate foo --path /path/to/foo
    pub global activate foo --git.url git://... --git.ref ...
    pub global activate foo --version ">=1.0 <2.0"
    pub global activate foo --hosted.url http://... --hosted.name foo --version ">=1.0 <2.0"
Presumably the same command-line interface would be used for issue #18911.

This issue has been moved to dart-lang/pub#1044.


Comma in ID3 tag cause unexpected database entries.

What version of Music Assistant has the issue?
2022.7.0   (also 6b10)
The problem
Punctuation marks in folder names and/or MP3 metadata cause unexpected database entries.
Example 1:  Commas
Folder name:  “Blood, Sweat & Tears”
MP3 Album Artist metatdata:  “Blood, Sweat & Tears”

Results in two Artist folders:  “Blood” and “Sweat & “Tears”

Example 2:  Ampersand
Two folders created by MusicBrainz:
Two different MP3 Album Artists in metatdata:

Shows up as one folder in MA “Browse” and one Artist.

How to reproduce
Create folders and metadata as in examples above
Relevant log output
No response
Additional information
The previous Ampersand fix seems to have caused this new condition.
Note that I entirely deleted the database file and let MA build a new one. The behaviour is the same.
What version of Home Assistant Core are your running
2022.7.6
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Hmmm, I did not realize there exist album names with a comma in there. For now just edit the Id3 tag and remove the comma please. I will provide a fix later.

Not sure if that is a bug perse.... The browse feature just shows the directory listing so you most probably only have one folder there. As for the artist being merged into one: In that case you probably have set the musicbrainz artist id to the same for both entries ?

I absolutely can edit the ID3 tag.   Just be aware that this punctuation
came directly out of MusicBrainz/Picard, so I am pretty certain it will
affect other people. Blood, Sweat and Tears is not the only band out
there with commas. You might want to consider it as a low priority bug
to be fixed at a later time when you get MA where you want it.
And...  Actually the two folders ARE in the file system.  The image
where I should the two folders is via samba directly to the media/music
folder. It is only the MA browse/filesystem feature that doesn't show
the two folders.
I certainly can live with these issues but wanted to report them.  It is
really strange that MA's browse filesystem doesn't see the above as two
different folders! Strange as it is, it is true.
fj
On 7/23/2022 9:37 AM, Marcel van der Veldt wrote:

Hmmm, I did not realize there exist album names with a comma in
there. For now just edit the Id3 tag and remove the comma please.
I will provide a fix later.

Not sure if that is a bug perse.... The browse feature just shows
the directory listing so you most probably only have one folder
there. As for the artist being merged into one: In that case you
probably have set the musicbrainz artist id to the same for both
entries ?

—
Reply to this email directly, view it on GitHub
https://github.com/music-assistant/hass-music-assistant/issues/711#issuecomment-1193127019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5E4DTU3TZ3E5WOGIAQCR3VVPYRJANCNFSM54OAKLOA.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the well the well documented report.

@FrankJaco sure these need fixing. My point about editing the tag for now was just temporary until I release a fix.
I've decided to remove all that splitter logic and only accept the splitter used by Musicbrainz Picard, which is the semicolon.
That also seems to be the common standard for multi-item fields in ID3.
Huh it is really strange that you don't see 2 folders because MA is literally iterating over the folders in the browse view.
I'll see if I can reproduce that one, thanks!

Hey Marcel,
The missing folder issue appears to be my error.  I made the assumption
that the folders would be listed in alphabetical order. For example
"Buckethead" would be listed directly above "Buckethead and Friends".
But on closer examination both folders were present in MA's Browse
feature.  Strange order though.  Why is is roughly in alphabetical
order, but not?  I think this should be changed to a feature request.
Some kind of sort features for the Browse/Filesystem or at least make it
alphabetical.
fj
On 7/23/2022 6:47 PM, Marcel van der Veldt wrote:

@FrankJaco https://github.com/FrankJaco sure these need fixing. My
point about editing the tag for now was just temporary until I release
a fix.
I've decided to remove all that splitter logic and only accept the
splitter used by Musicbrainz Picard, which is the semicolon.
That also seems to be the common standard for multi-item fields in ID3.
Huh it is really strange that you don't see 2 folders because MA is
literally iterating over the folders in the browse view.
I'll see if I can reproduce that one, thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/music-assistant/hass-music-assistant/issues/711#issuecomment-1193199378,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5E4DXV3HZYL3EVKOSITODVVRZAFANCNFSM54OAKLOA.
You are receiving this because you were mentioned.Message ID:
@.***>

How strange, there is a "sort" on the directory listing because the OS itself returns a really strange order. I'll double check that.
Fix for the comma issue will be in the 2022.7.1 patch release!

I've just released patch version 2022.7.1 which should fix both issues (the comma and the sort order).
If you still experience any issues after updating to 2022.7.1 please let us know, thanks!


command not found: screengif

Hi,
I've installed screengif gem :
gem install screengif
Fetching: screengif-0.0.3.gem (100%)
Successfully installed screengif-0.0.3
Parsing documentation for screengif-0.0.3
Installing ri documentation for screengif-0.0.3
Done installing documentation for screengif after 0 seconds
1 gem installed

But when i try to execute command in terminal
screengif -i Autocomplete_slowlyness.mov -o slow_autocomplete.gif

I get command not found: screengif
My ruby version is ruby 2.0.0p645 (2015-04-13 revision 50299) [universal.x86_64-darwin15] and i'm on the latest Mac OSX version

I guess you have a borked gem installation, maybe?
Or perhaps you installed it without sudo (not globally), but don't have the path setup?
Either figure out how to do that, or try sudo gem install screengif.

I did both sudo and no sudo - it was a same result

I did both sudo and no sudo - it was a same result
 ~  sudo gem install screengif
Fetching: screengif-0.0.3.gem (100%)
Successfully installed screengif-0.0.3
Parsing documentation for screengif-0.0.3
Installing ri documentation for screengif-0.0.3
Done installing documentation for screengif after 0 seconds
1 gem installed
➜  ~  gem install screengif
Fetching: screengif-0.0.3.gem (100%)
Successfully installed screengif-0.0.3
Parsing documentation for screengif-0.0.3
Installing ri documentation for screengif-0.0.3
Done installing documentation for screengif after 0 seconds
1 gem installed

Actually, it looks like i had to reload my zsh console to make it work. Weird, but good that it's working. Thanks for the script

:+1:


Added unit tests and skaffold

:tada: This PR is included in version 1.1.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


J7 Not connecting

I have been able to get my Serial, BLID, and password nor problem. Hoobs still says it can't connect. This is a J7 Roomba. I will share screenshots.

@DanLysk please try the latest version.

Hey! Thanks for the heads up on 1.3.1... I got the plug-in updated in HOOBS... Here is what I get now.

I just updated to 1.3.1 and am having the same problem with my J7. My 980 runs perfectly though. I've been using v1.2.2 for the last month or so and it had been working perfectly.

You need to update the local.js file to use TLS_AES_256_GCM_SHA384 for the ROBOT_CIPHERS variable for it to work on a J7.  This was the fix found in https://github.com/karlvr/homebridge-roomba2/issues/81, though it seems that updating to the latest version of the plugin resets the variable to the old cipher.  I'm running the homebridge official image, and my local.js file is at /usr/local/lib/node_modules/homebridge-roomba2/node_modules/dorita980/lib/v2/local.js
Mine's working flawlessly after fixing that.

I’ve done that and got it working. I run a HOOBS system, so the local.js file was in a different place and took me awhile to find. The problem is that I also run a 980, which didn’t work with the new cipher. So, I had to install two bridges, one with the new one, and one with the old one. It seems to be working now, but for some reason, the Roombas tend to have trouble docking more than without the plugin. I figured it was because of frequent connections with my device by the plugin, so I reduced the devices down to just the start trigger and disabled the rest. It worked better but still will occasionally fail to dock or run out of batteries. Any thoughts on this?

On Mar 24, 2022, at 8:10 AM, mpreissner @.***> wrote:
You need to update the local.js file to use TLS_AES_256_GCM_SHA384 for the ROBOT_CIPHERS variable for it to work on a J7. This was the fix found in #81 https://github.com/karlvr/homebridge-roomba2/issues/81, though it seems that updating to the latest version of the plugin resets the variable to the old cipher. I'm running the homebridge official image, and my local.js file is at /usr/local/lib/node_modules/homebridge-roomba2/node_modules/dorita980/lib/v2/local.js
Mine's working flawlessly after fixing that.
—
Reply to this email directly, view it on GitHub https://github.com/karlvr/homebridge-roomba2/issues/106#issuecomment-1077611287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXP34QNLV457TEIE4NDQ75TVBRSV3ANCNFSM5QSEJWMQ.
You are receiving this because you commented.

No clue.  I've had no issues with my J7 ever since I got it working.
You shouldn't have to run separate bridges for the two Roomba types.  You could run the Dorita980 plugin and the roomba2 plugin on the same bridge, as the Roomba2 uses a localized copy of the 980 modules within its folder structure - should just have to modify the local.js in that one to get the j7 working.  Although, running separate bridges is a good idea anyway...if any issues crop up with one of them, it could affect the other if they're on the same bridge, so probably not worth changing the config since you've got it running already.

Really, we’re having more trouble with the 980 than the J7. It’s gotten stuck 5 out of the last 8 days. However, a couple of those times were due to things getting in the way, so I’m not ready to blame the Roomba2 plugin. It had been working fine for months before the latest update. I don’t have the Dorita980 plugin and have just used the one that’s built into yours. Thank you for your responses. I had struggled for months with the homebridge-irobot app, but I could never get both the J7 and the 980 working at the same time. Yours has seemed to fix that.

On Mar 24, 2022, at 10:48 AM, mpreissner @.***> wrote:
No clue. I've had no issues with my J7 ever since I got it working.
You shouldn't have to run separate bridges for the two Roomba types. You could run the Dorita980 plugin and the roomba2 plugin on the same bridge, as the Roomba2 uses a localized copy of the 980 modules within its folder structure - should just have to modify the local.js in that one to get the j7 working. Although, running separate bridges is a good idea anyway...if any issues crop up with one of them, it could affect the other if they're on the same bridge, so probably not worth changing the config since you've got it running already.
—
Reply to this email directly, view it on GitHub https://github.com/karlvr/homebridge-roomba2/issues/106#issuecomment-1077775231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXP34QJKKSCOUOXLENJANX3VBSFERANCNFSM5QSEJWMQ.
You are receiving this because you commented.

I’ve done that and got it working. I run a HOOBS system, so the local.js file was in a different place and took me awhile to find. The problem is that I also run a 980, which didn’t work with the new cipher. So, I had to install two bridges, one with the new one, and one with the old one. It seems to be working now, but for some reason, the Roombas tend to have trouble docking more than without the plugin. I figured it was because of frequent connections with my device by the plugin, so I reduced the devices down to just the start trigger and disabled the rest. It worked better but still will occasionally fail to dock or run out of batteries. Any thoughts on this?
…

Can you share where this file was located on HOOBS? I'm coming up empty and traversing the hierarchy by hand isn't easy with all of the instanced plugins.

Nevermind, found it: /var/lib/hoobs/roomba2bridge

I updated my Cypher… .Still no worky for my J7
Daniel Lysk
501-804-7542 | @.*** @.>
www.CentralArkansasVegan.org http://www.centralarkansasvegan.org/
-------- __@      __@       __@       __@      __~@
----- \<,_    _<, \<,_     _<, `<,
---- ()/ ()  ()/ ()  ()/ ()  ()/ ()  ()/ (*)

> On Mar 24, 2022, at 11:51 AM, Drewbacca2<EMAIL_ADDRESS>wrote:
>
>
> Really, we’re having more trouble with the 980 than the J7. It’s gotten stuck 5 out of the last 8 days. However, a couple of those times were due to things getting in the way, so I’m not ready to blame the Roomba2 plugin. It had been working fine for months before the latest update. I don’t have the Dorita980 plugin and have just used the one that’s built into yours. Thank you for your responses. I had struggled for months with the homebridge-irobot app, but I could never get both the J7 and the 980 working at the same time. Yours has seemed to fix that.
>
> > On Mar 24, 2022, at 10:48 AM, mpreissner<EMAIL_ADDRESS>wrote:
> >
> >
> > No clue. I've had no issues with my J7 ever since I got it working.
> >
> > You shouldn't have to run separate bridges for the two Roomba types. You could run the Dorita980 plugin and the roomba2 plugin on the same bridge, as the Roomba2 uses a localized copy of the 980 modules within its folder structure - should just have to modify the local.js in that one to get the j7 working. Although, running separate bridges is a good idea anyway...if any issues crop up with one of them, it could affect the other if they're on the same bridge, so probably not worth changing the config since you've got it running already.
> >
> > —
> > Reply to this email directly, view it on GitHub <https://github.com/karlvr/homebridge-roomba2/issues/106#issuecomment-1077775231>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXP34QJKKSCOUOXLENJANX3VBSFERANCNFSM5QSEJWMQ>.
> > You are receiving this because you commented.
> >
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/karlvr/homebridge-roomba2/issues/106#issuecomment-1077831984>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AX3GDPFZHBDBUBRDYMI54PDVBSMRZANCNFSM5QSEJWMQ>.
> You are receiving this because you were assigned.
>

@DanLysk this may also be related to an issue with Node 18. Can you confirm which version of node your Homebridge is running on? On the Homebridge UI status page it's listed in the System Information panel.

Looks like I am on Node 16.18.1. I got Roomba working with a full Hoobs reload. Thank you for the follow up.
Daniel Lysk
501-804-7542 | @.***
www.CentralArkansasVegan.org
-------- __@      __@       __@       __@      __~@
----- \<,_    _<, \<,_     _<, `<,
---- ()/ ()  ()/ ()  ()/ ()  ()/ ()  ()/ ()

> On Nov 18, 2022, at 10:21 PM, Karl von Randow<EMAIL_ADDRESS>wrote:
>
>
> @DanLysk <https://github.com/DanLysk> this may also be related to an issue with Node 18. Can you confirm which version of node your Homebridge is running on? On the Homebridge UI status page it's listed in the System Information panel.
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/karlvr/homebridge-roomba2/issues/106#issuecomment-1320792903>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AX3GDPDOPOHCFBGMFC3AQW3WJBITBANCNFSM5QSEJWMQ>.
> You are receiving this because you were mentioned.
>

I hope this is resolved once and for all with version 1.3.2-beta.1. Please try it out and let me know.


API: fallback to pipette_config when json config values fail to load

overview
This PR allows pipette configs loaded from JSON to not completely fail if a single value fails to load. For each value expected to find in the loaded JSON, if it is not there, it will be loaded from the pipette_config namedtuple.

⚽ pending CI


URLOperations in SDWebImageDownloader visit by multithread without lock cause crash

#URLOperations in SDWebImageDownloader visit by multithread without lock cause crash
New Issue Checklist

[ √ ] I have read and understood the CONTRIBUTING guide
[ √ ] I have read the Documentation
[ √ ] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
ios

Platform Version
8.0

SDWebImage Version
4.0.0

Integration Method
cocoapods

Xcode Version
Xcode 8.2

Repro rate
sometimes

Repro with our demo prj
none

Demo project link
none

Issue Description and Steps

Fixed by #1911


Error at placement phase

Description
Hi
I'm trying to run my rtl code through OpenLane flow interactively. "run_synthesis" and "run_floorplan" phases were successful. But at
"run_placement" phase getting this error :

(My rtl code is in Verilog HDL which is about 2k rows. Im not sure about whether this effect this or running interactively.)
Environment
Python: v3.6.9
Kernel: Linux v5.4.0-91-generic
Distribution: ubuntu 18.04
Container Engine: docker v20.10.11
OpenLane Git Version: 2021.12.16_04.46.54
---
PDK Version Verification Status: OK
---
Git Log (Last 3 Commits)

commit ec570990c76a65b9bf23d89a161dbe075ed8fa15
Author: Donn<EMAIL_ADDRESS>Date:   Thu Dec 16 19:44:52 2021 +0200

    Remove All Unused Scripts + More Consistent Script Naming (#765)

    * Remove Unusued Scripts

    ```rb
    scripts = `find ./scripts -type f -maxdepth 1`.chomp.split("\n")

    unused_files = []

    for script in scripts
        basename = File.basename(script)
        STDERR.puts "Searching for #{basename}..."
        ag_files = `ag --count #{basename}`.chomp.split("\n")
        if ag_files.count > 0
            STDERR.puts "Found #{basename} in #{ag_files.count} files:"
            for file in ag_files
                STDERR.puts "\t-#{file}"
            end
        else
            STDERR.puts "Could not find #{basename} in any files!"
            unused_files << script
        end
    end

    STDERR.puts "Unused files: #{unused_files}"
    puts "#{unused_files.map { |f| "'#{f}'" }.join(" ")}"
    ```

    * Rename all `camelCase` scripts to `snake_case` for consistency (except mergeLef.py)

    ```rb
    scripts = `find ./scripts -type f -maxdepth 1`.chomp.split("\n")

    unused_files = []

    for script in scripts
        if script.downcase != script
            puts script
        end
    end
    ```

    * More naming consistency, folded useless scripts

commit c1083b591020938d54726a32f0dd5adc0136ab2d
Author: Donn<EMAIL_ADDRESS>Date:   Thu Dec 16 18:35:04 2021 +0200

    Centralize Calling OpenROAD + Automatic Reproducibles (#764)

    All OpenROAD scripts are now called with `run_openroad_script`, a variant of `try_catch`, that upon detecting a failure will automatically invoke ./scripts/or_issue.py and create a reproducible within the run directory.

    Also tweaks to how yosys is invoked.

commit c481f38c441183857a0361e9d376331eb6860e74
Author: Donn<EMAIL_ADDRESS>Date:   Wed Dec 15 19:37:51 2021 +0200

    Update OpenROAD to e9d88df, update OpenROAD boost to 1.76 (#762)

Reproduction Material

Reproducible issue tarball :
https://github.com/ufukyill/Issue-submit/blob/main/openroad_issue_reproducible.tar.xz
edit: https://github.com/ufukyill/Issue-submit/blob/main/V2openroad_issue_reproducible.tar.xz

comands:
run_placement

Expected behavior
Expecting to succesful floorplan phase.
Logs
###############################################################################
# Design Rules
###############################################################################
set_max_fanout 5.0000 [current_design]
[INFO]: Setting RC values...
[INFO RSZ-0027] Inserted 3 input buffers.
[INFO RSZ-0028] Inserted 2 output buffers.
[INFO RSZ-0058] Using max wire length 2319um.
[INFO RSZ-0034] Found 15537 slew violations.
[INFO RSZ-0036] Found 807 capacitance violations.
[INFO RSZ-0037] Found 1 long wires.
[INFO RSZ-0038] Inserted 2428 buffers in 15535 nets.
[INFO RSZ-0039] Resized 55104 instances.
[ERROR DPL-0019] detailed placement failed on decryptAES/genVarLoopDecrypt\[14\].SubByte/subByte\[8\].subValue/_1034_
Error: resizer.tcl, 76 DPL-0019
[ERROR]: during executing openroad script /openlane/scripts/openroad/resizer.tcl
[ERROR]: Exit code: 1
[ERROR]: Last 10 lines:
child process exited abnormally

[INFO]: Creating reproducible...
[INFO]: Saving runtime environment...

or_issue.py OpenROAD Issue Packager

EFABLESS CORPORATION AND ALL AUTHORS OF THE OPENLANE PROJECT SHALL NOT BE HELD
LIABLE FOR ANY LEAKS THAT MAY OCCUR TO ANY PROPRIETARY DATA AS A RESULT OF USING
THIS SCRIPT.

Parsing config file(s)…
Setting up /openlane/designs/top_level/runs/run27_12/openroad_issue_reproducible…
⚠ /openlane/designs/top_level/runs/run27_12/tmp/placement/8-resizer.sdc was not found, might be a product. Skipping
⭕ Done.
[INFO]: Reproducible packaged: Please tarball and upload designs/top_level/runs/run27_12/openroad_issue_reproducible if you're going to submit an issue.
[INFO]: Calculating Runtime From the Start...
[INFO]: Generating Final Summary Report...
[INFO]: Design Name: top_level
Run Directory: /openlane/designs/top_level/runs/run27_12
Source not found.
----------------------------------------

LVS Summary:
Source: /openlane/designs/top_level/runs/run27_12/logs/finishing/top_level.lvs.lef.log
Source not found.
----------------------------------------

Antenna Summary:
No antenna report found.
[INFO]: check full report here: /openlane/designs/top_level/runs/run27_12/reports/final_summary_report.csv
[INFO]: Saving runtime environment...
[ERROR]: Flow failed.

%

You need to upload the issue reproducer.  @donn what is the path to the generated file?

What do you mean by saying issue reproducer? Do you mean netlist file by saying generated file ? I'm new to all of these so don't mind me please.

I mean https://github.com/The-OpenROAD-Project/OpenLane/blob/master/docs/source/using_or_issue.md but I think it is autogenerated now but I don't recall where.

Your run should have issued this message:
"Reproducible packaged: Please tarball and upload $reproducible_dir_relative if you're going to submit an issue."
with the path in it.   If you look for openroad_issue_reproducible I think you'll find it.

Thanks. Editted by adding tarball.

@donn I see scripts/openroad/opendp.tcl:
set_placement_padding -global -right $::env(CELL_PAD)
but not in scripts/openroad/replace.tcl.  I makes no sense to apply padding during detailed placement that wasn't applied during global placement.

#811. Do you believe this is the only issue here? @maliberty

@donn I suspect so but I can't tell until the change goes through.

Well, the relevant change has gone through. I'm going to close this for now and if it resurfaces, @ufukyill please feel free to reopen.

Should i update the OpenLane or smth?

Yup, you should.

Please provide an updated testcase

https://github.com/ufukyill/Issue-submit/blob/main/V2openroad_issue_reproducible.tar.xz

Any suggestions ?

I just opened it and the design still looks very dense.  Are you sure this is with padding in global placement?

are you using the default density?

I exported  CELL_PAD=0 in openlane after "make mount" in last case but density was default. I have already tried as everything is default then i did some changes on config.tcl. Here have a look : https://github.com/ufukyill/Issue-submit/blob/main/config.tcl
Source RTL :  https://github.com/ufukyill/Issue-submit/blob/main/top_level.v
On the other hand, the reason that i run flow interactively is that virtual machine stucks at some point on flow (5.20.smth) so i decided to run flow interactively. I may not be aware of things that i should set or change if there are.

Is there a reason you need PAD=0?
In the test case provided you have: export CELL_PAD='4';

If I use CELL_PAD='1';  it goes through with no problem.  I suspect you ran global placement with 0 padding and detailed placement with 4 padding which won't work.

I exported CELL_PAD='1' and changed it in the config.tcl too. Using config.tcl given below and as i increased my VM RAM to about 11 gb, i passed placement phase without problem.
Thanks a lot for assistance to @maliberty @donn .
config :
`set ::env(DESIGN_NAME) top_level
set ::env(VERILOG_FILES) "$::env(DESIGN_DIR)/src/top_level.v"
set ::env(CLOCK_PERIOD) "10.0"
set ::env(CLOCK_PORT) "clock50MHz"
set ::env(FP_CORE_UTIL) {30}
set ::env(CELL_PAD) {1}
set ::env(PL_TARGET_DENSITY) {0.35}
set ::env(GLB_RESIZER_HOLD_MAX_BUFFER_PERCENT) {60}
set ::env(CLOCK_NET) $::env(CLOCK_PORT)
set filename $::env(DESIGN_DIR)/$::env(PDK)_$::env(STD_CELL_LIBRARY)_config.tcl
if { [file exists $filename] == 1} {
source $filename
}`


Gateway enhancements for improved extensibility

Updates for https://github.com/kaazing/gateway/pull/303

Other thing I mentioned to Chris was, ResultAwareLoginContext becomes public API. May be that dependency can be removed. Perhaps, spi's LoginResult was good enough. He thought that might be possible as HttpRevalidateHandler doesn't have to send 403.

@jitsni, I took a look (crack at doing it).  Taking a break now but it seems doable but I hit two problem spots, both in AbstractWsBridgeSession.
One is without the login ctx the getSubject is not available.  I'm unclear on the reasoning here on why the call to getSubject was added in the PR.  I will need to investigate further, if it is required could we add the subject to the login Result?
Two, the cleanup in logout().  It looks like there was a way solved for this before the pull request but it seems a little hacky.

@jitsni, I attempted to pull out ResultAwareLoginContext and instead rely on LoginResult.  However, this has downstream impact.  Suggest merging this for now and revisiting.  Here is branch to attempt.   Essentially, ResultAwareLoginContext is still needed for downstream testing


refactor(SourceMapDevToolPlugin): upgrade to ES6

What kind of change does this PR introduce?
ES5 => ES6 refactor
Did you add tests for your changes?
refactor, all existing tests pass
If relevant, link to documentation update:
N/A
Summary
Helping in part of the ES6 refactor
Does this PR introduce a breaking change?
Nope
Ping @sokra @TheLarkInn

Thanks


Method to remove specific rule or all rules for specific fields

Describe
I'm struggling to find a way to programmatically remove specific rules for specific fields or to disable validation totally for specific field.

Maybe ref to: #245

Yaaap, passing prop to required did the trick...

v-validate="{ rules: { required: this.isRequired} }"


Option to save a shared calendar into user account

When a calendar is shared to the user, we want to give the option to add to their saved calendars, or save it as a local calendar, so, with this, the shared calendar can be saved/edited to the user needs.
Does this Task depends of another one to be done?
Yes. #41
Use case covered with this Task

Users can share calendars

What needs to be done?

[ ] Give the option when a calendar is shared and it is not from the user to save it.
[ ] When selected to sabe, a copy of the calendar needs to be sent to the API to be stored.

If more sub-task needs to be added, do it freely

A suggestion for this is to check if the calendar uuid that you are viewing on the URL or on the calendar, is included into the calendarApi array from storage


[FLINK-11126][YARN][security] Filter out AMRMToken in the TaskManager credentials

What is the purpose of the change
Currently, Flink JobManager propagates its storage tokens to TaskManager to meet the requirement of YARN log aggregation (see FLINK-6376). But in this way the AMRMToken is also included in the TaskManager credentials, which could be potentially insecure.
The PR filters out AMRMToken before setting the tokens to TaskManager's container launch context, and adds checks for delegation tokens that JobManager prepares for TaskManagers.
Brief change log

Filter out AMRMToken before setting the tokens to the TaskManager container context.

Verifying this change
This change added tests and can be verified as follows:

Extended YarnApplicationMasterRunnerTest to check delegation tokens in the TaskManager executor context.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented?

The build failed with some network issues. I'll close and reopen the PR to trigger a rebuild.

@zentol @tzulitai Please have a look. ✋


New runoff method for single column

Purpose

This PR adds a method of runoff specifically for single site runs, which assumes that water at the top of the soil column (from precipitation or snow melt) which is in excess relative to infiltration capacity is runoff.
To-do

[x] Method functions, BC conditions (! need docstring for abstractrunoffmodel)
[x] Unit tests (! WIP)
[ ] Add runoff method in atmospheric drivers (? is this needed ?)
[ ] Call that method in experiments
[ ] Add docs

Content

[x] I have read and checked the items on the review checklist.

@juliasloan25
Hey Julia,
This PR should be pretty simple, we are just adding an AsbtractRunoffModel, but we get an error:
ERROR: The following 1 direct dependency failed to precompile:

ClimaLand [08f4d4ce-cf43-44bb-ad95-9d2d5f413532]

Failed to precompile ClimaLand [08f4d4ce-cf43-44bb-ad95-9d2d5f413532] to "/home/runner/.julia/compiled/v1.10/ClimaLand/jl_xbjQuI".
ERROR: LoadError: TypeError: in Type{...} expression, expected UnionAll, got Type{ClimaLand.Soil.Runoff.InfiltrationExcess}
Stacktrace:
  [1] top-level scope
    @ ~/work/ClimaLand.jl/ClimaLand.jl/src/standalone/Soil/boundary_conditions.jl:1001

and I am not sure why it happens... (very similar code just above in boundary_conditions.jl to define the TOPMODELRunoff methods do not have this error).
Note I am also surprised the error is at line 1001, which is the beginning of a docstring

@juliasloan25 Hey Julia, This PR should be pretty simple, we are just adding an AsbtractRunoffModel, but we get an error:
ERROR: The following 1 direct dependency failed to precompile:

ClimaLand [08f4d4ce-cf43-44bb-ad95-9d2d5f413532]

Failed to precompile ClimaLand [08f4d4ce-cf43-44bb-ad95-9d2d5f413532] to "/home/runner/.julia/compiled/v1.10/ClimaLand/jl_xbjQuI".
ERROR: LoadError: TypeError: in Type{...} expression, expected UnionAll, got Type{ClimaLand.Soil.Runoff.InfiltrationExcess}
Stacktrace:
  [1] top-level scope
    @ ~/work/ClimaLand.jl/ClimaLand.jl/src/standalone/Soil/boundary_conditions.jl:1001

and I am not sure why it happens... (very similar code just above in boundary_conditions.jl to define the TOPMODELRunoff methods do not have this error). Note I am also surprised the error is at line 1001, which is the beginning of a docstring

Hi Alexis! Usually when the error points to the start of a docstring, the error is actually in the line of code immediately after that docstring. In this case, the error is coming up because you dispatch on <: InfiltrationExcess{FT} (here), but InfiltrationExcess isn't defined to take a type parameter FT. Locally, I removed {FT} from the dispatch and it precompiles fine :)

@braghiere @kmdeck Do we still want to do this? Or should we close this PR?

Well, we need the runoff term for site level runs. Can we quickly finish it and merge it?

completed following this PR's approach in PR #702


pin fsspec to prevent conflict with Dask

Could you please provide more context and/or example code to reproduce the conflict? Looking at past build logs, I don't see fsspec being installed

@jdblischak there was a failure to install Dask with a newer version being pulled in

Await TileDB-VCF 0.23 release before considering this patch; if it's necessary, CI will fail on bumping the version, as import tiledbvcf will be unable to import Dask.

If you want to specify a maximum version of a package that isn't a direct dependency, you can use run_constrained. If I understand the problem correctly, adding fsspec to the host requirements isn't going to achieve what you want. You could add it to the run requirements, but I still think run_constrained is the better option

CI will fail on bumping the version, as import tiledbvcf will be unable to import Dask

I'm confused. My understanding is that dask is an optional dependency of tiledbvcf. Unless you update the conda recipe to run the tests in test_dask.py, I don't think it will fail. Just running import tiledbvcf shouldn't be affected by the presence or absence of any version of dask.
mamba create --yes -n test-fsspec \
  --override-channels -c conda-forge -c tiledb \
 tiledbvcf-py
mamba activate test-fsspec
# dask and fsspec are not installed
mamba list dask
mamba list fsspec
python -c "import tiledbvcf"
mamba install --yes --override-channels -c conda-forge -c tiledb dask
mamba list dask
## # Name                    Version                   Build  Channel
## dask                      2023.3.0           pyhd8ed1ab_0    conda-forge
## dask-core                 2023.3.0           pyhd8ed1ab_0    conda-forge
mamba list fsspec
## # Name                    Version                   Build  Channel
## fsspec                    2023.3.0           pyhd8ed1ab_1    conda-forge
python -c "import tiledbvcf"
# no errors

closing again; this appears unnecessary for now. Will force-push using run_constrained if this pops up again
The problem manifested when the Python package located Dask but could not load it, due to some unknown reason, but that pin fixed it.


[Python] Update AttributeRead command for wildcard read

Problem
The Python API cannot read wildcard paths
Change overview

Update the API
Use ReadClient::Callback instead of old API for attribute read

Testing

The wildcard support on server will be added by #11304
The test only covers the basic API tests, will add wildcard read test after server change

Fast tracking, given this adds test functionality.

/rebase


added support for elasticsearch mapper-attachments (v 1.7 and 2.x)

to full-text index PDFs and such, one can now just install
ElasticSearch's mapper-attachment (https://www.elastic.co/guide/en/elasticsearch/plugins/master/mapper-attachments.html)
Wagtail should use it automatically once it is installed.

I know this isn't pretty yet; I'm actually hoping for a discussion how to implement this nicely.
Also: mapper-attachments has a bunch of different keys that can in theory be filled 1, like:
"my_attachment" : {
        "_content_type" : "application/pdf",
        "_name" : "resource/name/of/my.pdf",
        "_language" : "en",
        "_content" : "... base64 encoded attachment ..."
    }

but I feel that that makes only sense once we have the basis implemented pretty.

Thanks @nutztherookie. This looks like it could be quite useful!
I think we can just assume the mapper-enhancements is installed, instead of having to check for it. If a user attempts to index a file into an ES instance without the plugin, we can raise an error instructing them what to do.

if you think that that's smarter, sure :)  maybe we ought to backport it to ES1 then too. mapper-attachments is available there as well.
if the wagtail-community / torchbox is interested in such a feature and it has the chance to be upstreamt, i can look into it :)

woa. apparently i still don't exactly know now to manage/deal with github pull requests.

since i kinda wracked this pull request here, i moved to another patch-branch and ticket #3028


Does not work on windows

it does not work on windows as it is signal based. Please mention that.

Thank you for your feedback. I've added a notice to the README.
I have opened an issue (#6) to investigate a Windows solution. Would you like to be contacted for beta-testing ?

yes, I would like to contribute for beta-testing.


Sqlllll

Replaces https://github.com/github/linguist/pull/2082

I think this is looking in pretty good shape now. / cc @bkeepers for a review.

There are a lot of submodule changes that look unrelated. Was that intentional?
Everything else looks good to me. :+1:

Looks like I accidentally merged in the updates grammars here. Any objection to merging as-is?

great.. cant wait to see this live on github.. :)


Confirm caching backend is working as expected

Might be using dummycache instead

Yep, caching wasn't enabled. We've got db caching set up in staging now, and it's much faster


Add helper to format text ProperCase

Please describe your feature request:
It would be useful to add the following helpers:
to_proper(input string) string | Transforms the input into ProperCase characters | to_proper("hello") | Hello
Describe the use case of this feature:
Would be Useful for Fuzzing filenames/Usernames

It's no to_proper but this may help u.


Scanning with Yarn Package Manager

Hi,
I'm new to ODC and would like understand the the correct command line parameters I should be using.
Version: Command Line / 6.0.2
The project is built using Yarn package manager. I read that ODC requires a package-lock.json file. The commands I'm running are:
npm install --package-lock-only --production
dependency-check.sh -s "[root folder]" --disableNodeJS --disableRetireJS --nodeAuditSkipDevDependencies
This only reports scanning 27 dependencies when the package.json has 52 dependencies. And the report doesn't make sense in respect to the vulnerable packages listed are not in the package.json
So, my question is, what commands should I be running in order to scan correctly?
Many thanks

Yarn is not a supported package manager. Those that are using Yarn have used https://github.com/imsnif/synp to generate a package-lock.json.

Thank you @jeremylong. I'll give that a try.
Do you think the ODC parameters I'm passing are correct once I have the package-lock.json?

Yes, I think they look okay for now. In the future retireJs should not be disabled though... but the updates have not been made yet so for node projects you likely want to disable it.  You may need to specify -o (the output directory -o . works).

Thanks. I do appreciate your time. I think I must be missing something!!
Steps (locally for now):

yarn
synp --source-file .\yarn.lock
scan...

If I run with -s "[root folder]" --disableNodeJS --disableRetireJS --nodeAuditSkipDevDependencies the scan is fast but the report doesn't look right.
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (0 seconds)
[INFO] Finished Central Analyzer (0 seconds)
[INFO] Finished Assembly Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[WARN] The Node Package Analyzer has been disabled; the resulting report will only contain the known vulnerable dependency - not a bill of materials for the node project.
[INFO] Finished Node Audit Analyzer (0 seconds)
[WARN] Unable to determine Package-URL identifiers for 22 dependencies
[INFO] Finished Sonatype OSS Index Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Analysis Complete (3 seconds)

If I run with -s "[root folder]" --disableNodeJS --nodeAuditSkipDevDependencies it takes around 20 minutes to complete the analysis (running locally), is this expected? This would add considerably time when integrated with our CI.
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (0 seconds)
[INFO] Finished Central Analyzer (0 seconds)
[INFO] Finished Assembly Analyzer (1 seconds)
[INFO] Finished Dependency Merging Analyzer (551 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[WARN] The Node Package Analyzer has been disabled; the resulting report will only contain the known vulnerable dependency - not a bill of materials for the node project.
[INFO] Finished Node Audit Analyzer (0 seconds)
00:11  INFO: Vulnerability found: jquery below 3.5.0
00:11  INFO: Vulnerability found: jquery below 3.5.0
00:14  INFO: Vulnerability found: react below 16.0.1
00:20  INFO: Vulnerability found: jquery below 3.4.0
00:20  INFO: Vulnerability found: jquery below 3.5.0
00:20  INFO: Vulnerability found: jquery below 3.5.0
00:29  INFO: Vulnerability found: react below 16.0.1
00:30  INFO: Vulnerability found: react below 16.0.1
[INFO] Finished RetireJS Analyzer (59 seconds)
[INFO] Finished Sonatype OSS Index Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (1 seconds)
[INFO] Finished Dependency Bundling Analyzer (577 seconds)
[INFO] Analysis Complete (1195 seconds)

The Retire.JS analyzer is really more intended to identify client side JS - such that might be included in a JEE project and is not recommended to be used with a Node project. Yes, RetireJS itself does have support for Node.js - but we are not yet using the data store. By including the RetireJS analyzer today you will end up adding every single JS file as a dependency - which isn't exactly what you want.

Actually, this is a Javascript SPA project.
I've gone with -s "[root folder]" --disableNodeJS --nodeAuditSkipDevDependencies but it does take 15+m to compete a scan (which doesn't include downloading the updates).
So I'm still not sure if I have the correct command line parameters!

@AndrewJWaite beware of synp, version before 1.9.4 have a bug, there's no "dev" flag in package-lock.json avec converting yarn.lock. it has been fixed in 1.9.4.
Also DependencyCheck is still bugged on --nodeAuditSkipDevDependencies, so it always analyse all dependencies.
It will be fixed in 6.0.3 coming soon.
So you will have to use synp 1.9.5+ and dep-check 6.0.3+

Thanks @sebastienroux
RE: SYNP, the fix is in 1.9.4 (latest version), correct?

beware of synp, version before 1.9.4 have a bug, there's no "dev" flag in package-lock.json avec converting yarn.lock. it has been fixed in 1.9.4.

So this:

So you will have to use synp 1.9.5+ and dep-check 6.0.3+

becomes this:

So you will have to use synp 1.9.4+ and dep-check 6.0.3+

Hopefully this will reduce the scan time!

Yes sorry 1.9.4 is the latest version with the fix of missing dev flag.
Normally it will reduce the scan time, i'm waiting for 6.0.3 release to test this too ;)

Thanks @sebastienroux
I'll keep a lookout.
Would there be an additional parameter when invoking synp for this missing dev flag?
https://github.com/imsnif/synp


Issue on/with the new website UI & documentation section

Website:

The header is many things that have good faith meanings behind them but don't help.
Simply the header isn't about flowbite-react and get's you thinking in many places. (If you're curious like me and like to learn what this thing is about - In this case Flowbite react, you will click on it, deviating from why you actually visited the site in the first place - at least objectively)
Objectively it is not helpful given I probably didn't visit the flowbite-react page to read the blog in the first place. (I am not saying it's bad, just the inspiration to spread your focus as a visitor to the site is a net negative)

It will be a real superpower to have all the components just there and easy to jump to right when you visit flowbite-react.
Flowbite is after all a frontend components tooling and that speed of being able to jump right to the core of its offering will be/is a superpower.
Alot of people who will continuously visit flowbite-react.com are power users after their 2nd and 3rd focused visits.
If I can quickly get to the components set, I would highly appreciate it.

Documentation:

It looks better when things are bold and smaller  (code examples too, more polished)
When I could see the full code example without having to scroll, I loved it, because I am able to move from one example to another in strong single visual focuses.
The New visual structure needs you to scroll to see everything and to recheck, you need to scroll up and down to recheck things.

Icons and other visual markers are everything
I know an accordion when I think about it for 2 minutes, but when I see the logo/icon indicator, I am able to quickly jump to it.
The old documentation site, along with its content/component label spacing and bold font did this really well.
A clutter-free scroll will always be appreciated as well.

I have just seen this change and as I use it some more, I will report/add everything else I see here.
Thank you for spending your precious time on building us this great component tooling, just know it is highly appreciated ❤

Hello @ha-sante,
Thanks for your valuable feedback and for using Flowbite React!
Your suggestion gives me a pretty nice idea which would be to offer two versions of the docs: Flowbite React and Flowbite React Lite (which would be much more similar to what we had before). You would be able to choose this via accessing the https://flowbite-react.com/lite/**/* URL pattern.
Now to give you a bit more context of why we are doing this redesign is because:

we need to give Flowbite React a bit more identity (why we also used cyan instead of blue)
the new layout gives us a lot of room to include features like search, better text, code previews
the homepage now explains what the library is about while also keeping the list of components with those icons
we also switched from Create React App to Next.js 13 to align with community standards
and quite a few more (as a reference you can check the main Flowbite website and docs)

Now to get back to your suggestion:

The header is many things that have good faith meanings behind them but don't help.
Simply the header isn't about flowbite-react and get's you thinking in many places. (If you're curious like me and like to learn what this thing is about - In this case Flowbite react, you will click on it, deviating from why you actually visited the site in the first place - at least objectively)
Objectively it is not helpful given I probably didn't visit the flowbite-react page to read the blog in the first place. (I am not saying it's bad, just the inspiration to spread your focus as a visitor to the site is a net negative)

The links in the header will be revisited - we're still not done with the revamp. One problem is that I see that the quickstart link goes to flowbite.com which should not be the case - we'll probably keep a link to Figma still but as I've said, we'll revisited the header rather soon.

It will be a real superpower to have all the components just there and easy to jump to right when you visit flowbite-react.
Flowbite is after all a frontend components tooling and that speed of being able to jump right to the core of its offering will be/is a superpower.
Alot of people who will continuously visit flowbite-react.com are power users after their 2nd and 3rd focused visits.
If I can quickly get to the components set, I would highly appreciate it.

Agreed - there are two things here:

we'll integrate search which will allow you to cmd + k for components
currently you have the list on the homepage, but we'll add it to the introduction page too

It looks better when things are bold and smaller (code examples too, more polished)
When I could see the full code example without having to scroll, I loved it, because I am able to move from one example to another in strong single visual focuses.
The New visual structure needs you to scroll to see everything and to recheck, you need to scroll up and down to recheck things.

The component and code previews will be massively changed - currently we are aware the fonts and colors are not optimised at all - check out the main Flowbite or Flowbite Svelte docs as a reference as to how we plan to make it look and then build on top of that.

Icons and other visual markers are everything
I know an accordion when I think about it for 2 minutes, but when I see the logo/icon indicator, I am able to quickly jump to it.
The old documentation site, along with its content/component label spacing and bold font did this really well.
A clutter-free scroll will always be appreciated as well.

We had the icons in the sidebar - is that what you're referring to? Or is it the list of SVG thumbnails that we still have on the homepage? We are planning to add that to the introduction page back again.
Thank you for the valuable feedback <3
Zoltan

Well, this is actually a very nice feedback indeed.

Your suggestion gives me a pretty nice idea which would be to offer two versions of the docs: Flowbite React and Flowbite React Lite (which would be much more similar to what we had before). You would be able to choose this via accessing the https://flowbite-react.com/lite/**/* URL pattern.

May I said that I didn’t liked this idea? 😅 I think that by doing it we will have two docs to maintain. If we are looking for adding an extra documentation for the library to complement and not duplicate the one that we have I would say to have an low level documentation that would be autogenerated by comments in the code.
Just to have a lite documentation version that would duplicate the standard documentation doesn’t seems to be adding much value. Maybe we get learn something from Godoy documentation, in their getting started they have some tutorial where you learn how to create your first game. So, in our case she could add an tutorial to create the first app using flowbite? Nothing fancy, something like a TODO app, or just to build the first page structure.

We had the icons in the sidebar - is that what you're referring to? Or is it the list of SVG thumbnails that we still have on the homepage? We are planning to add that to the introduction page back again.

I think that here what it means is that in the previous sidebar we had some Icons before the name of the component that was adding some visual helpers to the users that are not very familiar with the component’s name to find them.

Well, this is actually a very nice feedback indeed.

Your suggestion gives me a pretty nice idea which would be to offer two versions of the docs: Flowbite React and Flowbite React Lite (which would be much more similar to what we had before). You would be able to choose this via accessing the https://flowbite-react.com/lite/**/* URL pattern.

May I said that I didn’t liked this idea? 😅 I think that by doing it we will have two docs to maintain. If we are looking for adding an extra documentation for the library to complement and not duplicate the one that we have I would say to have an low level documentation that would be autogenerated by comments in the code.
Just to have a lite documentation version that would duplicate the standard documentation doesn’t seems to be adding much value. Maybe we get learn something from Godoy documentation, in their getting started they have some tutorial where you learn how to create your first game. So, in our case she could add an tutorial to create the first app using flowbite? Nothing fancy, something like a TODO app, or just to build the first page structure.

We had the icons in the sidebar - is that what you're referring to? Or is it the list of SVG thumbnails that we still have on the homepage? We are planning to add that to the introduction page back again.

I think that here what it means is that in the previous sidebar we had some Icons before the name of the component that was adding some visual helpers to the users that are not very familiar with the component’s name to find them.

The development implications of the lite versions would be indeed a hassle, unless we find a way of using the same content but applying it to a different layout :P
Either way, let's wait until we finish with the new docs as it's clearly not finished just yet, and then we can see how we can improve the content and the way users navigate throughout the website.


Feature request: Direct P2P connection using Hotspot

Is your feature request related to a problem? Please describe.
Useful if no AP/Router for sharing with friends in public/outdoor.
Describe the solution you'd like
Just use Hotspot for receiving the file.
Then the sender connect to Hotspot and send the file.
Describe alternatives you've considered

Add button "Generate QR" in receive page menu, then generate QR  with syntax...

WIFI:S:<SSID Name>;T:WPS|WPA;P:<password>;H:true|false;;
H = Hidden network

In sender page menu, add  scan QR code button to proceed Direct P2P Hotspot file transfer.

Additional context
I know it will be very complicated to do (require permission API, etc).
But it's very useful feature, and will speed up transfer rate, because no other client in the Hotspot

I think that this could work on android but not on the ios because of the ios limitations.

I think that this could work on android but not on the ios because of the ios limitations.

I see, iOS app not allowed to auto connect Wi-Fi network.

Can just have this on android and pc then and tell the user on IOS that Apple doesnt allow for this feature to work properly.

Maybe Wi-Fi direct could be utilised for this?

AFAIK Wi-Fi Direct doesn't use HTTPS, is P2P protocol used to mirror display, transfer media, DLNA etc
LocalSend use HTTPS protocol to send any file.


Add ability to provide options in OpenAI compatibility endpoints

It seems one can only set system prompt and hyperparameters like temperature as part of model config file.  I'm using the OpenAI API, and ollama ignores system prompt or such hyperparaemters.  AFAIK there's no good reason for this.
Am I missing something?

Somehow I thought this was already a thing and have been spending quite the hours trying different models, prompt finetuning etc. instead. Turns out things are just being clipped still defaulting to 2048 window with models supporting 16K+ as request options are left ignored. Hoping it'll be a quick feature to resolve since it's already on other endpoints.

Don't mean to be pushy, but is there any news on this?

Would be increadibly usefull to find a way to deal with this. I found the ollama hosting of llama3.1 to be way better than running it natively via h2ogpt. But they lack of adjustment to system / query prompts is annoying


Function :row is in the docs but doesn't exist.

Sorry for the (huge) wait, and thanks for reporting. This was fixed in e693c41. Apparently in the spec, the function is called "IMPLICIT_VAR" and I didn't rename this accordingly (to row) when releasing the rebuilt driver.


Update threat model for adaptive authentication feature

$subject to align with the new threat modeling process defined.
Fix issues if identified.
Fix https://github.com/wso2/product-is/issues/9842
Effort BE::30

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Get.mediaquery causes constant objects of getxcontroller to be created repeatedly

Flutter SDK 2.2.1
Getx 4.1.4
Get.mediaquery causes constant objects of getxcontroller to be created repeatedly
[GETX] Instance "GetMaterialController" has been created
[GETX] Instance "GetMaterialController" has been initialized
[GETX] GOING TO ROUTE /
[GETX] Instance "LaunchLogic" has been created
[GETX] Instance "LaunchLogic" has been initialized
[GETX] GOING TO ROUTE /problem
[GETX] Instance "HttpTool" has been created with tag "-Problem-2ce1dc60c68d11ebbede834a0a5b8ef8"
[GETX] Instance "HttpTool" with tag "-Problem-2ce1dc60c68d11ebbede834a0a5b8ef8" has been initialized
[GETX] Instance "ProblemLogic" has been created
[GETX] Instance "ProblemLogic" has been initialized
[GETX] Instance "HttpTool" has been created with tag "-Problem-2d07b3e0c68d11ebbede834a0a5b8ef8"
[GETX] Instance "HttpTool" with tag "-Problem-2d07b3e0c68d11ebbede834a0a5b8ef8" has been initialized
Looking at the log, you can see that httptool is created repeatedly
I created an example to see the usage and log.
Is it the wrong way I use it?
getx_examples.zip

See the TODO comment of the code.
routes.dart
    GetPage(
      name: problem,
      page: () => ProblemPage(),
      binding: BindingsBuilder.put(
        // TODO: bindings will be called many times during this page's lifecycle
        () => ProblemLogic(),
      ),
    ),

problem.dart
class ProblemLogic extends GetxController {
  static ProblemLogic get logic => Get.find();
  // TODO: Each time bindings being called, it will put a new HttpTool in getHttp method
  final HttpTool _http = HttpTool.getHttp("Problem");

http_tool.dart
class HttpTool {
  static HttpTool getHttp(String begin) {
    // TODO: So here to avoid the issue you described, I just
    // make a temp solution here:
    // just put one without tag, and thus it will not created repeatly,
    // so if you want to put with tag, try to re-structure your code here,
   // and Get.find() the tagged one accordingly.
    HttpTool _httpTool;
    try {
      _httpTool = Get.find();
    } catch (e) {
      _httpTool = Get.put(
        HttpTool(),
        // tag: "-$begin-${Tool.getUUId()}",
      );
    }

    return _httpTool;
  }

I should know what you mean.
Because most of my pages use httptool. So if I want to use tag, I need to change it to a constant value instead of UUID. Is that what you mean?

@KevinZhang19870314
Do you know why get.mediaquery causes the object of getxcontroller to be created repeatedly?
Is there a solution to the conflict?

Waiting for reply...
The document has the same usage scenario!
https://github.com/jonataslaw/getx/blob/master/documentation/en_US/dependency_management.md#getput
Get.lazyPut
It is possible to lazyLoad a dependency so that it will be instantiated only when is used. Very useful for computational expensive classes or if you want to instantiate several classes in just one place (like in a Bindings class) and you know you will not gonna use that class at that time.
/// ApiMock will only be called when someone uses Get.find<ApiMock> for the first time
Get.lazyPut<ApiMock>(() => ApiMock());

Get.lazyPut<FirebaseAuth>(
  () {
    // ... some logic if needed
    return FirebaseAuth();
  },
  tag: Math.random().toString(),
  fenix: true
)

Get.lazyPut<Controller>( () => Controller() )

This problem has been fixed.


[Card component] React:  Add tags to the bottom of card components

User Story

As a [user role below]:
Carbon for ibm.com developer

I need to:
create/change the Card

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Story within Storybook with corresponding knobs
Utilize Carbon
See the Epic (#7281 ) for the Design and Functional specs information
React Visual QA testing issue (TBD)
Prod QA testing issue (TBD)

Acceptance criteria

[ ] Built as a pure React component/variant
[ ] Include README for the react component and corresponding styles
[ ] Add any necessary stable selectors
[ ] Create codesandbox example under /packages/react/examples/codesandbox and include in README
[ ] Minimum 80% unit test coverage
[ ] Update the Carbon for ibm.com website component data file to be sure the web site Component Status and Storybook links are correct
[ ] Use the Visual QA checklist to verify design quality
[ ] If a design is provided, the Designer is included as a Reviewer in the Pull Request
[ ] Provide a direct link to the deploy preview for the designer in the Pull Request description
[ ] A comment is posted in the Prod QA issue, tagging Praveen when development is finished

Hey team! Please add your planning poker estimate with ZenHub @andysherman2121 @annawen1 @emyarod

Please add your planning poker estimate with ZenHub @jeffchew

Please add your planning poker estimate with ZenHub @ariellalgilmore

Please add your planning poker estimate with ZenHub @BrunnoM7

Please add your planning poker estimate with ZenHub @guilhermelMoraes

Please add your planning poker estimate with ZenHub @IgnacioBecerra

Please add your planning poker estimate with ZenHub @kennylam


Is this plugin still maintained?

Hi, is this plugin still maintained? If so, when can we expect a new release?

Hi, I have left the company and I created new fork https://github.com/kmoco2am/sonar-r-plugin/ which I would like to use for further development.


Issue running as system

When running the install as system context with intune the logs show "winget not found"
if ran as user context the app attempts to install and requests admin permissions.
powershell.exe -Executionpolicy Bypass -File winget-install.ps1 -AppIDs "Google.Chrome --override "/qn""

The version is 1.3.1741
As for the quotes the script doesn’t appear to even make it to that step since it fails to find winget, the same commands also work when not run with Intune.
Terry Meyers
Systems Administrator
RBC Medical Innovation’s

On Jul 7, 2022, at 4:37 PM, Romain @.***> wrote:

Hi,
What is the winget version installed ?
Not sure your quotes are good as well.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

When adding the win32 app should the script be run in user or system context ? When i run in user context the user is being prompted with admin credentials but works fine if credential's are given, when run as system it fails to locate winget

I appended your script to start-transcript to see what was going on and it appears that intune runs in 32 bit system context and fails to find the path as shown below, any advice ?
`PSVersion: 5.1.19041.1682
PSEdition: Desktop
PSCompatibleVersions: 1.0, 2.0, 3.0, 4.0, 5.0, 5.1.19041.1682
BuildVersion: 10.0.19041.1682
CLRVersion: 4.0.30319.42000
WSManStackVersion: 3.0
PSRemotingProtocolVersion: 2.3
SerializationVersion: <IP_ADDRESS>

        888       888 d8b  .d8888b.           d8b
        888   o   888 Y8P d88P  Y88b          Y8P
        888  d8b  888     888    888
        888 d888b 888 888 888        888  888 888
        888d88888b888 888 888  88888 888  888 888
        88888P Y88888 888 888    888 888  888 888
        8888P   Y8888 888 Y88b  d88P Y88b 888 888
        888P     Y888 888  "Y8888P88  "Y88888 888
       https://github.com/Romanitho/Winget-Install
     https://github.com/Romanitho/Winget-Install-GUI
_________________________________________________________

18:29:24 - ###   7/7/2022 - NEW INSTALL REQUEST   ###
Resolve-Path : Cannot find path 'C:\Program Files (x86)\WindowsApps' because it does not exist.
At C:\Windows\IMECache\0a664599-7448-47db-a890-cd1dfe5c9240_4\winget-install.ps1:104 char:26

... ingetPath = Resolve-Path "$env:ProgramFiles\WindowsApps\Microsoft.Des ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (C:\Program Files (x86)\WindowsApps:String) [Resolve-Path],
ItemNotFoundException
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.ResolvePathCommand
Resolve-Path : Cannot find path 'C:\Program Files (x86)\WindowsApps' because it does not exist.
At C:\Windows\IMECache\0a664599-7448-47db-a890-cd1dfe5c9240_4\winget-install.ps1:104 char:26

... ingetPath = Resolve-Path "$env:ProgramFiles\WindowsApps\Microsoft.Des ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (C:\Program Files (x86)\WindowsApps:String) [Resolve-Path], ItemNotFound
Exception
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.ResolvePathCommand
18:29:25 - Winget not installed !
PS>TerminatingError(): "System error."

$global:?
True`

I modified this line from $env: and added a space to program files and this appears to have resolved the resolver issue.
$ResolveWingetPath = Resolve-Path "C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_*_x64__8wekyb3d8bbwe"

Hi. It light be something similar to WAU when running win32 package. It calls 32 bits process and we want it to be 64. Here is the WAU explanation https://github.com/Romanitho/Winget-AutoUpdate/discussions/88#discussioncomment-2849475

Can you try to run it like this:
"%systemroot%\sysnative\WindowsPowerShell\v1.0\powershell.exe" -noprofile -executionpolicy bypass -file winget-install.ps1 -AppIDs Google.Chrome

Yessir that did it, sorry i didnt realize this i appreciate you !


Prepare to register

I added GitHub actions CI and badges to the README, setup the docs infra, fixed the Project.toml file and refactored the tests slightly. I also updated the license file to include contributors to the project.

There seems to be some test failures in CI. Will look into it later.


fixed documentation (WIP)

minor markdown syntax fixup

No modification for AutorestCI/azure-sdk-for-python

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-ruby

just make sure CI passes :)

thanks! CI doesn't pass for because some jobs can't deal with PRs originating from Azure/azure-rest-api-specs itself... will merged since I only touched docs.


Docs polish suggestions

This review is based on commit https://github.com/zeppelinos/zos/commit/542ba321f535608f672453b9418e9362041c6ca7.
General comments

[x] Avoid NODE_EVN=test statements (#335)
[x] Note that zos.local.json is no longer true since we are using the dev-# for local nodes, consider using sth like zos.dev-*.json instead (https://github.com/zeppelinos/zos/pull/348)
[x] Typos, wording and minor fixes proposal (https://github.com/zeppelinos/zos/pull/346)
[x] Confusing random bold words in code-blocks (#340)
[ ] Improve Solidity syntax highlighting for code-blocks (#341)

Questions

[ ] Many links point to an advanced section that seems to be removed, we should either add it or fix the links that are still pointing to it
[ ] Do we want to introduce the session command to avoid the --network local in every example?
[ ] I'm still wondering the result of upgrade vs update discussion (https://github.com/zeppelinos/zos-cli/issues/338)

Overview section
Features

Upgrades: deploy new versions of packages to the blockchain.

[ ] Consider being more explicit about smart contracts upgrades

Changes to your contracts

When it comes to Solidity code, there is nothing special you need to consider when using ZeppelinOS 2.x other than using initializers instead of constructors. For more info on this, see the "Initializers vs constructors" section of the documentation.

[x] Fix initializers vs constructors link, it's broken

Quickstart section
Adding a contract

This is required by ZeppelinOS if you want to upgrade your contract later, which we'll see in more detail in the next guide.

[ ] Rewrite the initializers clarifying sentence to make clear that this is they way constructors should be tackled now in ZeppelinOS to make them upgradeable. Note that this is different from saying that is required if you want to upgrade your contract later

pragma solidity ^0.4.24

[ ] Should we add a note saying that the current version of ZeppelinOS works with 0.4.24 by default. Otherwise, users should use the --skip-compile option providing their own build files.

Notice that our sample contract has an initialize function instead of the standard Solidity constructor. This is required by ZeppelinOS if you want to upgrade your contract later, which we'll see in more detail in the next guide.

[ ] Consider adding at least a small sentence explaining what problem is the Initializable contract solving

This contract imports another contract from the zos-lib package.

[ ] Consider adding a line to clarify what is zos-lib. It is the first time it's mentioned

Deploying your contract

For this example, let's use Truffle's local development network. To start it, open a separate terminal and run

[x] Consider adding a note to clarify that since zOS is using Truffle, there is no need to install it (https://github.com/zeppelinos/zos/pull/370)

Note: When calling an initializer with many variables, these should be passed as a comma-separated list, with no spaces in between.

[x] Consider adding an example (https://github.com/zeppelinos/zos/pull/371)

This section ends without testing the created instance

[ ] Consider adding a simple test with the Truffle console testing that MyContract.at(..).x() === 42

Upgrading a contract (https://github.com/zeppelinos/zos/pull/370)

Do not stop the truffle develop command that we ran before, or you will lose your previous deployment!

[x] Consider adding a link to the section where that command was run

The upgrade test does not work since we are requesting the user to use the same Truffle console opened before, but given that the contract was changed, it should be loaded again, otherwise, users will face a TypeError: myContract.increment is not a function error

To try the new function we just added, jump to the terminal where the Truffle command is running and execute the following instructions:

[x] Consider running a ganache instance instead of a truffle develop console at the beginning of the guide, and then opening a truffle console against it every time we want the user to check something. Bear in mind that this will impact the blueprint we are using for the truffle-config.js on init, we will need either change the default port to be 8545 or make the user run ganache-cli with the --port 9545 option

Linking to EVM packages

// TODO link to difference between openzeppelin-eth and openzeppelin-solidity. //

[x] Solve that todo

Guides
Writing upgradeable libraries

You can use your Solidity contracts in ZeppelinOS without any modifications, except for their constructors. Due to a requirement of the proxy-based upgradeability system, no constructors can be used in upgradeable contracts. You can read in-depth about the reasons behind this restriction in the advanced topics section.

[ ] Fix the in the advanced topics section link, it's broken

Using the ZeppelinOS programmatic library

And now, let's write our upgrading script in index.js:

[ ] Consider splitting this script into at least 2 or 3 steps

As you can see on the code, this script was prepared to be executed with Truffle. So let's start a Truffle local development network and console:

[x] No need to run a truffle console to run a script with truffle, we can use truffle exec script.js instead (https://github.com/zeppelinos/zos/pull/370)

Advanced Topics
Contracts architecture

The following diagram illustrates the interface of the contracts of published EVM packages:

[ ] Fix link, it's broken

#378 adds the link with the difference between openzeppelin-solidity and openzeppelin-eth

RE "Do we want to introduce the session command to avoid the --network local in every example?"
-1
I'm against this.
I would document that you can use session but things are easier to understand with --network in the examples. The session command is one of those things you start using in a CLI when you get used to it and want to stop doing repetitive things. It's like using npm i instead of npm install.

Closing this issue since the remaining items are either questions or issues we can solve later


ObjectRepository autogenerated id

Helo,
I had some trouble using the Object repository. I want to use auto generated Id-s (anyway) but i can't.
I tryed:

@id long id; -> id will allways null and allways updates the first insert (with upsert)
@Id Long id; -> id can not be null exception
@Id NitriteId id; -> id field can not be null
@Id NitriteId id = NitriteId.createNew() -> Id field isn't saved
No id at all -> Object must have an id field exception.

I'm out of ideas. What is the preferred way to achive auto generated id-s using Object repository?
Thanks, David

Please have a look at this test class NitriteIdAsIdTest


README improvements

Hi there,
The README talks about smartvmi being "Virtual Machine Introspection (VMI) for memory forensics and machine-learning." and it consists of VmiCore and certain plugins.
Unfortunately, this says surprisingly little about this project. Don't get me wrong, but VMI is a niche with a lot of small, often hacky, solutions out there, most relying on patchsets, as the KVM-VMI project.
So, I'd like to ask for the answer to some questions, ideally baked into the README.

What problems does smartvmi solve that KVM/VMI doesn't solve? (I absolutly know about the pain and sharp edges of the KVM/VMI stack)

How does it compare to KVM/VMI stack and what does it solve better/differently?

What's happening inside the userspace, what's happening in the kernelspace (compared to kvm/vmi)?
With which Linux versions is smartvmi compatible? Does it has special pre-requisites, i.e. components requiring special patchsets?

I recently started getting into VMI, also based on a publicly funded research project. VMI is a niche, often frustrating because of the patchsets and overall low engagement. I think if we together put resources into better documentation of what solutions currently exists in VMI space, what the limitatios and features are, we have a better chance in making VMI more main-stream - and eventually upstream something useful to Linux.
Thank you and schöne Grüße aus Dresden 👍🏻

Hi @phip1611,
Originally we had planned to put a lot of effort into writing a thorough documentation because we feel the same way. The documentation around most VMI-related projects is usually lacking, so it is generally quite hard to get a foothold into VMI as a topic. Unfortunately, we did not get around to it because we got pulled off to other projects right after the research project. I'll try to answer your questions and perhaps I can extend our readme if time permits.
VMICore is a high level introspection tool and as such would be more comparable to e.g. DRAKVUF than to KVM-VMI. DRAKVUF is much more mature and has got a lot more features compared to VMICore. However, unlike DRAKVUF, VMICore is designed to be a hypervisor agnostic platform for plugins. This means that you can write your own VMI application without having to re-implement the logic for setting hidden breakpoints, for example. Your plugin should also be able to run on KVM-VMI and Xen without any modifications. Since we use libvmi to talk to the hypervisor API, we support everything libvmi supports (which is mainly Xen and KVM-VMI at the moment).
Regarding prerequisites: Since VMICore leverages libvmi it also inherits all its prerequisites (package dependencies, KVM-VMI...). VMICore itself has very few external dependencies. They are specified in the VMICore Readme.
I think I also saw your efforts on slack to get the ball rolling regarding KVMi upstream patches. Since our team tried this as well, let me share some insights:

As far as I am aware the BitDefender team has basically given up on getting those patches merged and moved on.
I think they don't require KVM for any of their products. It was more of a "nice to have" rather than something they would actively use. As a result the patches still have quite a few bugs. We have fixed some, but there are still some that we are aware of but haven't had the time to fix.
The patches for kvmi-v7 (which is the most feature complete version) are based on version 5.4 of the linux kernel. Rebasing those to a recent kernel would require a lot of effort which is probably why no one has done it yet. However, this would probably be the most important thing in order to prevent the community from dying out.

I hope this helps at least a little bit. Feel free to ping me on slack if you still have questions.


Feature/summary

Description
For this I added the provided summary of each Doc on both the List view and grid view. On the List view I used a collapse to allow the summary shrink and expand.
On the Grid view, with the Idea and help of Sarah I used a Modal technique, that uses an Icon to open the Modal  and there is a X on the Modal or just clicking out of the modal closes it.
Sarah got the Great Icon that is being used instead of the button.
video
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] I have made corresponding changes to the documentation if necessary (optional)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

really love the way it populates on both. in thumbnail/grid view, you made good use of the modal feature. in list, the change of state makes a smooth transition. I especially like the fact that you renamed the icon as Summary for any future developer


T5 text encoder inference: graph and pynative mode

What does this PR do?

Adds # T5 text encoder inference, supporting both pynative and graph mode.
Readme includes:

[x] how to convert the checkpoint of t5-v1_1-xxl;
[x] how to use the text encoder to extract text embedding and mask;
[ ] how to use text decoder (todo).

After the discussion with Yufei, the T5 encoder will reuse the modules in mindone.transformers, please refer to  #440


How to use trained Resnet classification model in python code

Hi there,
I have trained a classification model using this: https://github.com/PaddlePaddle/PaddleClas/blob/release/2.3/docs/zh_CN/quick_start/quick_start_classification_new_user.md
However, I do not know how to call the trained model in python code as I wanted to use this model in my existing code.
I do not want to run inference on an image using terminal.
Does anyone know how to do this?

Hello, you can use the command here to train. https://github.com/PaddlePaddle/PaddleClas/blob/release/2.3/docs/zh_CN/quick_start/quick_start_classification_new_user.md#412-使用预训练模型

I have trained finished the model. However, how do I use this trained model for inference and how do I integrate this model into my existing codespace?
Is there a function (for example, model.predict(img_array)) in paddle that I can call my trained model using python code?

you can refer to "4.3 使用本地模型文件预测" in https://github.com/PaddlePaddle/PaddleClas/blob/release/2.5/docs/zh_CN/deployment/image_classification/whl.md

Yes. You can refer to here(https://github.com/PaddlePaddle/PaddleClas/blob/release/2.3/ppcls/engine/engine.py#L362) to code.

thank you! the code works


Decoder: Null accepted for non-nullable types

The decoder logic accepts/ignores null values in JSON for fields that cannot accept nil values. For example, generated code looks like this:
  /* handler: uj.SchemaID type=int32 kind=int32 quoted=false*/

    {
        if tok != fflib.FFTok_integer && tok != fflib.FFTok_null {
            return fs.WrapErr(fmt.Errorf("cannot unmarshal %s into Go value for int32", tok))
        }
    }
...

Ideally, fflib.FFTok_null should result in an error unless the SchemaID field was itself for *int rather than int. The builtin encoding/json unmarshaller returns an error in this case, so this prevents using ffjson as a drop-in replacement when validation is relevant.

yes, this is a bug.

looking at decoder_tpl.go, I see what appears to be relevant lines such as
    if tok == fflib.FFTok_null {
        {{if eq .TakeAddr true}}
        {{.Name}} = nil
        {{end}}
    }

I want to say that the fix would just be adding an {{else}} that returns an error in the event that takeaddr is false to the relevant blocks - is this close to correct?


Cannot get ManagedIdentity from a VM within Azure ML

Azure Identity:
1.15.0:
Linux:
3.8.5:

Describe the bug
This is more a question than a bug as it works for other users but not for this specific one and I am a bit desperate.
We are not able to retrieve Azure Managed Identity from a notebook running on a VM inside Azure ML workspace.
The user gets the following error:

ClientAuthenticationError: ChainedTokenCredential failed to retrieve a token from the included credentials. Attempted credentials: EnvironmentCredential: EnvironmentCredential authentication unavailable. Environment variables are not fully configured. Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot this issue. ManagedIdentityCredential: Unexpected content type "text/plain; charset=utf-8" Content: SSO failure: unable to retrieve a token. Error Token service plemaitre-cpu2. Token not found To mitigate this issue, please refer to the troubleshooting guidelines here at https://aka.ms/azsdk/python/identity/defaultazurecredential/troubleshoot.

We tried to get the token manually using this piece of code:
import os
import requests
msi_endpoint = os.environ.get("MSI_ENDPOINT", None)
msi_secret = os.environ.get("MSI_SECRET", None)
client_id = os.environ.get("UAI_CLIENT_ID", None)

print(msi_endpoint)
print(msi_secret)
print(client_id)

token_url = msi_endpoint + "?resource=https://management.azure.com"
headers = {"secret": msi_secret, "Metadata": "true"}
resp = requests.get(token_url, headers=headers)
resp.raise_for_status()
access_token = resp.json()["access_token"]

print(access_token)

It works for every user except for this one. He is getting a 404 error.
MSI_ENDPOINT is set to http://<IP_ADDRESS>:46808/MSI/auth and MSI_SECRET is correctly set
All the VM have been created using the same configurations, and every users have Owner permissions on the tenant.
The Azure ML Workspace uses a User Assigned Identity that has Contributor role on the tenant
Any help would be appreciated
Expected behavior
User is able to retrieve the ManagedIdentity

Thanks for reaching out.
Could you share the information how you configured/enabled the managed identity on the VM?
Did you use system-assigned managed identity or user-assigned managed identity?

If you use user-assigned managed identity, you need to include the client id information in your request.
https://learn.microsoft.com/en-us/azure/machine-learning/how-to-identity-based-service-authentication?view=azureml-api-2&tabs=cli#compute-cluster
Can you try it again?

Thanks @xiangyan99
So we tried on a machine with user-assigned-identity this piece of code
from azure.identity import ManagedIdentityCredential
import os

client_id = os.environ.get('DEFAULT_IDENTITY_CLIENT_ID')
credential = ManagedIdentityCredential(client_id=client_id)
token = credential.get_token('https://management.azure.com')

The user is able to retrieve correctly a token, however the call that he is doing is a call to retrieve artifacts from Azure MLFlow and the authentication is implicit and thus still fails as it is not using the token we managed to get with this method.
We tried setting the MLFLOW_TRACKING_TOKEN env var with the token we got but without success.

If you don't mind, could you share the code snippet how you use Azure MLFlow?

Hi @xiangyan99,
We simply do a run = mlflow.get_run(run_id=run_id)
Turns out it works now, but we didn't do anything more so I am a bit puzzled.


Add weekly challenge review week #013

Feel free to edit it. Thanks.

My bad, I've fixed the missing content.
Please check again. Thank you.

Thanks @kianmeng as always. Much appreciated your efforts.
https://perlweeklychallenge.org/blog/review-challenge-013/


Updated german localization

I know the localization is already updated but i checked though the file and fixed some things like rewording or even adding missing translations.
Because my internet is so bad it would take a long time to download and send it as a pull request, i uploaded it to pastebin: http://pastebin.com/raw.php?i=Fh6gqx95

I believe github has a feature to do basic edits by directly going to the file (https://github.com/Khroki/MCEdit-Unified/tree/master/lang), hitting the little edit icon, and using that to submit a pull request, so you don't even have to download the whole repo. Am not positive on that.

Merged :D


Feature suggestion: couple per-domain configuration with domains.txt

Need to dig into the oneliner for parsing domains.txt; but I'd like to add a way to set per-domain specific configuration bundled as part of the same source (instead of having it stored with the certificates). This way, things like #354 would be very powerful -- one can read it from a database or whatever source.
The idea is to do something in style with bash env variables;
CHALLENGETYPE=dns-01 foo.com bar.foo.com
bar.com foo.bar.com
...

Thoughts?

I'd like this too but I didn't really find a nice way to do this. It would be possible to split the line at a predefined marker (like bar.com foo.bar.com | CHALLENGETYPE=dns-01) and just execute that, but I really don't want to add even more ugly config parsing code... the current "parser" is ugly enough for one bash script...
For now you can partly solve this with a small wrapper script which sets the parameters, like this one:
#!/bin/sh
dehydrated -c -d 'foo.com bar.foo.com' -t dns-01
dehydrated -c -d 'bar.com foo.bar.com'

You could easily make a few helper functions to make it a bit more readable, maybe something like this (untested):
#!/bin/sh
HTTP() { dehydrated -c -d "${@}" }
DNS() { dehydrated -c -d "${@}" -t dns-01 }

DNS foo.com bar.foo.com
HTTP bar.com foo.bar.com

I want to put a bit more work into command line options since they make the script really powerful, especially in combination with automation tools like Ansible and Puppet, but even with small wrapper scripts like the examples above.

Thanks for your quick reply. I agree with all you said and are personally fighting with arguments against why two different configs is a better solution.
I guess a major version bump could introduce a new config format making things like this easier.

Going to close this. Splitting domains up in your cronjob is clearly a better approach.


⚠ ClamAV has degraded performance

In bbb5d69, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 231 ms

Resolved: ClamAV performance has improved in 2e3dd08.


PHP 7 - Base.php not compatible with react LoopInterface

PHP 7 fails with Base.php not being compatible with React\EventLoop\LoopInterface. In many declarations the word "callable" is needed before the parameter.
Furthermore the following functions are missing:

public function removeStream($stream)
public function isTimerActive(TimerInterface $timer)
public function nextTick(callable $listener)
public function tick()

Additionally it is calling functions in the React StreamSelectLoop that are not present:
return $this->_eventLoop->addSignal($signal, $listener);     (Line 235)
return $this->_eventLoop->removeSignal($signal, $listener);    (Line 244)
Finally the TimerInterface now lies in the namespace "React\EventLoop\Timer\TimerInterface" in the same file

Thank you for your post.
react/event-loop released new version which changed something.
Please try the version 0.5.3 for react/event-loop.


RDE management updates for CAPVCD

Changes:

Logic to add worker count, control plane count, template name, sizing class
Added capi-quickstart.yaml
Fixed empty string for cluster id

Testing:
TBD
@arunmk @sahithi @ltimothy7

This change is

main.go, line 191 at r3 (raw file):
Previously, sahithi (Sahithi Ayloo) wrote…
Remove os.Exit(1)
Just log the error and proceed. Rename the method to be  - SetIsManagementClusterInRDE

Done.


Use regular expression

Thanks for this tool!
It would be even more powerful to allow users to use regular expressions and backreferences. For example:

FileNameA.java
FileNameB.java
FileNameC.java

Rename using (.+)\.(.+) as Prefix$1.$2:

PrefixFileNameA.java
PrefixFileNameB.java
PrefixFileNameC.java

I have released version 1.0.9 with regular expression support. Please wait a few days for Plugin approval.


WIP: POC of MavenReference

@sergey-tihon
This is solved now with 4.6.0
https://github.com/NightOwl888/lucenenet-opennlp-mavenreference-demo/issues/1#issuecomment-1971460883


Centralized location for exit codes

We're using a bunch of different exit codes when the daemon exits with an error. Currently, those codes are inlined at the point of use, making them hard to find when they're triggered.
Suggest that the error codes be given symbolic, meaningful names, and placed in a single location, a la Posix errno.h.

Superseded by #7997.


Why i'm getting frequent Nlog not found error ?

I have an class library project name "Infrastructure", when I do restore nuget packages in visual studio I get error for Nlog only - not found, the details can be found on attached png file. I tried using different version of Nuget, but no luck. Thank you all.

Not sure which version you are trying to install, but there isn't a 2.0.0 of nlog. See versions on https://www.nuget.org/packages/NLog

I assume your question has been answered, if not, let us know!

Didn't got rid of error. During restore nuget packages, I get error for
Nlog 2.0.0 frequently, although I tried latest versions too.
On Dec 3, 2017 6:39 AM, "Julian Verdurmen"<EMAIL_ADDRESS>wrote:

I assume your question has been answered, if not, let us know!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NLog/NLog/issues/2424#issuecomment-348731861, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AeCmzMskmAKmRII99IB-jsd3vkx078T0ks5s8fFOgaJpZM4QrYN4
.

What package and version are you trying to install?
I see common.logging.nlog in your screenshot?
We need more info to help you with this

Thank you sir, I got it solved. The problem was with nuget package manager.
I used the old version of nuget package manager and did clean restore and
got it solved. Thank you again for replying.
On Dec 3, 2017 6:26 PM, "Julian Verdurmen"<EMAIL_ADDRESS>wrote:

What package and version are you trying to install?
I see common.logging.nlog in your screenshot?
We need more info to help you with this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NLog/NLog/issues/2424#issuecomment-348763169, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AeCmzJjEDpHLIobuhwMVpuy_ROVsR4OHks5s8pcAgaJpZM4QrYN4
.

Glad it has been resolved :+1:


FirebaseObjectObservable snapshots are not being unwrapped

The new docs mention that FirebaseObjectObservable emissions should be unwrapped by default containing a $key and a $value where relevant.
The unwrapping only seems to be happening on FirebaseListObservable emissions though.
See: https://github.com/angular/angularfire2/blob/master/src/utils/firebase_object_factory.ts#L18

Could this be related to: http://stackoverflow.com/questions/37060067/nested-observables-in-angular2-using-angularfire2-not-rendering-in-view/37060217
Or is something else going on?

@rosslavery Thanks for flagging this! I have a fix locally, I'll get it pushed soon.


Enable artifact request for maven executor

Is your feature request related to a problem? Please describe.
We want to use the maven-executor and publish the results to minio, this seems to be not possible in the current version, as no artifact is uploaded afterwards.
Describe the solution you'd like
Activate the artifact feature in the maven-executor and define artifactRequest in the test leads to for example uploading of the surefire test reports into minio or mongodb and visible/accessible in the dashboard via the artifact tab.

Hey @vsukhin, thanks for your quick reply. I understand and we will check which option would be more suitable for us.


fix: prevent clippy lints from occuring in the generated file

Fixes baoyachi/shadow-rs#151

Thx @thecaralice


Improve CI and Fix Warnings and Errors

The main purpose of this PR is to enable CI on every push to the plugins branch. Hopefully this will make it easier to keep in an "always green" state going forward.
It also fixes everything that is currently red in CI.

There is something about the way this is fitting together that I don't understand.
I thought I exercised all the generated code with my with my top-level Rhai test. Yet somehow, I'm getting more and different import errors on my codegen library with no_std than I did before.
I will fix those too. But it does not bode well for the future.

CI is now green, and it's ready to merge!


A script that will comment or make posts in communities

@TimaxLacs the script that makes posts in communities already exists: https://github.com/Konard/vk-bot/blob/c26d2175ab441e82cf3be54d520a4e4097ddd6a3/triggers/send-invitation-posts-for-friends.js#L29-L66 does that meet your expectations?


Generate Random Color

I am running a forEach() loop, and I need to console.log(). But I want to get a different color for each iteration. I went trhough docs, but couldn't find anything. Is there any way possible to achieve the same?
let arr = ["a", "ab, "abc"]
arr.forEach(arr, e => {
  console.log(chalk.red(e)) //maybe something like - chalk.randColor()
})

Duplicate of #353


fix: prevent the native context menu from appearing when right-clicking on a measurement or angle (https://github.com/OHIF/Viewers/issues/1406)

Hi.
This PR prevents the native context menu from appearing when right-clicking on a measurement or angle (https://github.com/OHIF/Viewers/issues/1406).
@dannyrb, can you review, please?
PR Checklist

[x] Brief description of changes
[x] Links to any relevant issues
[ ] Required status checks are passing
[x] User cases if changes impact the user's experience
[x] @mention a maintainer to request a review

This looks straightforward. Thanks for the fix! I'll give the preview a quick test on my desktop here soon and merge if it works as expected!


feature request: List topics in alphabetical order

Hi Team,
Currently, the topics are listed in unknown order. It would be great if they would be listed in alphabetical order.
Thanks,
Andor Markus

Thank you for your issue, this feature was applied in PR-172.