allow to use UNLICENSED for license

I would like to create private apps using this tool, especially with vivliostyle/create-book.
In documents of npm, we can use { "license": "UNLICENSED" } for private packages.  So I think it would be a good idea to support this specification in create-create-app as well.
Consideration:

Should we support this feature in default, or using extra arguments in create()?
When choosing UNLICENSED, should we also add {"private": true} in package.json?

See also #23.

Should we support this feature in default?
Yes, as long as npm officially supports it.

should we also add {"private": true} in package.json?
I feel like it beyond our project scope. Whether publish unlicensed package or not is up to users.

Having said that, adding UNLICENSED to the license list is a good idea!

OK, I made a PR #25.


Feature request: support for GitHub Registry

GitHub is currently building their own registry: https://github.com/features/package-registry
I expect some projects to move from npmjs.com to using the new github feature, so it would be nice to be prepared by supporting the github registry as well for searching available plugins.

I expect some projects to move from npmjs.com to using the new github feature

Why would they do that, especially when homebridge itself is on npm?  What does the GitHub registry offer me (as a plugin developer) that npm doesn't?

I see these potential reasons to use GitHub Registry:
a) Using two services also needs you to maintain password etc for both.
b) Ease of publishing. Imagine a team of multiple developers on a single github projects. Per default, only the project owner can upload a new version to npmjs. I expect this to be way easier in what github is building.
c) As a NEW developer, why would I care about learning how to use npm registry, if github already has a registry?

Note: GitHub Package Registry only supports scoped NPM packages. Scoped packages have names with the format of @owner/name. Scoped packages always begin with an @ symbol. You may need to update the name in your package.json to use the scoped name. For example, "name": "@codertocat/hello-world-npm".

https://help.github.com/en/articles/configuring-npm-for-use-with-github-package-registry
Homebridge does not support scoped packages presently.

Thanks for your suggestion @cbrandlehner - due to the above comment I'll close this until Homebridge has support for scoped repos. I would be happy to implement this feature in the future should GitHub's NPM Package Repo turn out to be popular.


Resolve non-responding thread in EoP pattern

This issue doesn't pop up with usecase/vivek branch of the RP. It does with master of RP.

Also works with split_module_2!

Vivek,
I would suggest to continue work on the feature/split_module_2 branch then.  State and notification races in the devel and master branches are notoriously hard to debug -- that is why we have the split branches in the first place, really.  All changes from devel are merged into split at the moment, FWIW.
Would that work out for you?  We should discuss how to proceed with the partitioning scheduler, that one is not yet merged.  Any opinion?

Yes, I think that works for me for now. The idea is to have a release of entk in the near future since: (i) There have been quite a few changes since the last release (ii) Release of a new repex version is expected (this version would use entk and hence requires entk's release)
I might have missed this in the earlier meetings but could you remind me when is the split_module2 planned to be released?

We should discuss how to proceed with the partitioning scheduler, that one is not yet merged. Any opinion?

I think if you feel it is stable, we can go ahead and merge as appropriate. For me, this is a useful feature to support (although currently not critical).

Note that the current RP devel now contains the split_module (and split_termination) branches.  Please test as this may resolve this issue.  Note that the partitioned scheduler will not be in the RP 0.46 release, although could make it into the next one.

Thanks @ibethune . Will test this against devel.


Improvements to poll app

Hello!
We have a few ideas to improve poll app.

Separate lines between vote variants

Add translation to other languages
Show poll settings (single, multiple) in header or differ them by poll color
Highlight vote button in multiple choice votes

Some apps implement it internally but I will be discussing with Doug about somehow tying the internal translation system to apps. Have it under my radar.
Can you elaborate this one please?
Do you mean if it is a multiple choice, for example, blue button, else, the generic one?

Doable.


Wireshark : There is no device named "packetflix"

Hi guys !
First of all , thanks for this awesomeness piece of code !
I followed the instructions on my Mac M1 Pro:

Downloaded cshargextcap_0.10.6_linux_arm64.tar.gz, unzipped it and coppied over /Applications/Wireshark.app/Contents/MacOS/extcap
download the packetflix-handler.zip archive.
run the CLI command xattr -d com.apple.quarantine packetflix-handler.zip.
unpack packetflix-handler.zip by double clicking it in Finder.
copy packetflix-handler(.app) to your Applications folder, /Applications.
go to "System Preferences" > "Security and Privacy" > tab "General" or "Security" section. Allow the packetflix-handler. In case you don't see anything here, try to start a capture from the web UI first, and as this will be blocked, you should now see here a notice with a button to enable the packetflix-handler.

When I launch a capture using the GUI, Packetflix-handler launch with Wireshark.
Wireshark immediately popup with an error message saying that the packetflix device does not exists
I tried to launch Wireshark natively and still no sign of this packetflix or ghostwire device.
Thanks a ton !

It took me a while to spot, so in case this is not a typing error, then you seem to have downloaded the Linux binary instead of the macos version. The error message would fit in, as it indicates that Wireshark cannot load the extcap binary. If this is the case, can you please give it a try with the arm64 macos package?

Rofl ! you are right ! I feel bad about it ! :) It works flawlessly ! what you guys did is awesome !

No need to feel bad, you're in good company! Thank you for the details that were really instrumental here, and glad to hear you're a happy camper.


Removed WORK.OUT output; Removed CSCER_CSCRP_CSCAS folder

Removed WORK.OUT output file from CSCER_Wheat_Barley, CROPSIM, CANEGRO-Sugarcane and CASUPRO-Sugarcane;
Removed CSCER_CSCRP_CSCAS folder;

I'm a little concerned about removing the Canegro output because that model is still maintained at SASRI.
@matthewjones0001 - @thiagoferreira53 is removing the Work.OUT output files, mostly for CSCER and CSCRP (wheat and barley). But it looks like this also affects CaneGro. The code is still there, but commented out. The rationale is to speed up execution time for large simulations. If you want to keep them, we could instead try to control the quantity of output with the verbose switch or send everything to INFO.OUT which is already controlled by the verbose switch.

@thiagoferreira53 Please, remove the compiler warnings for Intel Fortran. Check the latest code that Cheryl send in the dssat-csm-os repository and then add your changes in the top for No_Work_Output_branch. It seems you did this before Cheryl merge this warning changes. You need to compile with Intel Fortran and them check the warnings that are coming out from the compiler. Please check them one by one.
Thank you!

Done!

@thiagoferreira53 Please update your branch and resolve the conflicts. These conflicts were generated because of water table merge.

Solved and tested. There were 2 small conflicts related to the WORK.OUT lines I commented and the change from ModuleDefs to ModuleData in the CRP_SeasInit.for.


Go to reference/implementation using Ctrl + mouse

Issue Type: Feature Request
Hello,
In Eclipse there was a nice feature that when you hover the mouse over a function/variable name and you hold Ctrl key then it would be underlined and become a link, so that when you click on it would go to the implementation/reference. It would be much easier than pressing F12.
Best regards,
David.
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:30:02.622Z)
OS version: Windows_NT x64 10.0.17134

Ctrl + Click functionality is already implemented and works for me on Windows.
https://code.visualstudio.com/docs/editor/editingevolved#_go-to-definition

That's correct, thanks @IllusionMH

Then it's not working well, it doesn't find references in other files in the workspace, only in the same file.

It should do exactly the same thing as pressing F12, are you saying that it works with F12 but not ctrl+click?

Doesn't work with F12 either.

Oh so you are just saying that it doesn't work at all, what language is this and are you using a language extension for it?

I'm using it with Python extension.

Ok please file an issue on the python extension's repo or see their docs

will do, thank you.


Segmentation fault when consulting source from stdin which has include/1

For following script, a segmentation fault will be triggered:
!/bin/sh

tpl -q --consult <<EOF

:- include('non-exists-file.pro').

EOF

Backtrace:
Core was generated by `tpl -q --consult'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  __strcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S:296
296     ../sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S: No such file or directory.
(gdb) bt
#0  __strcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S:296
#1  0x000000000040d17a in dir_include (l=0x7ffe1631bf80, n=0x57e5c70) at src/parser.c:914
#2  0x000000000040d2d5 in directive (l=0x7ffe1631bf80, n=0x57e5c20) at src/parser.c:943
#3  0x00000000004103d1 in lexer_finalize (self=0x7ffe1631bf80) at src/parser.c:1944
#4  0x00000000004122e1 in lexer_parse (self=0x7ffe1631bf80, term=0x57da450, src=0x57e3b92 "", line=0x7ffe1631bf38) at src/parser.c:2370
#5  0x0000000000412561 in lexer_consult_fp (self=0x7ffe1631bf80, fp=0x7f283cb924e0 <_IO_2_1_stdin_>) at src/parser.c:2423
#6  0x0000000000409255 in trealla_consult_fp (self=0x57d7010, fp=0x7f283cb924e0 <_IO_2_1_stdin_>) at src/trealla.c:1250
#7  0x0000000000404fb2 in main (ac=3, av=0x7ffe1631cd08) at tpl.c:370
(gdb)

Fix confirmed, thanks.


MP+ logging to Splunk

Use internal Splunk image because our image

will reach End of Support on January 1, 2024
tries to send the logs to http-inputs-rhcorporate.splunkcloud.com which is blocked by the firewall. The firewall allows http-inputs-osdsecuritylogs.splunkcloud.com which I tried, but our token doesn't work with it.

IIRC the ESS requires logging, am I to naïve, if I expect them to have some logging in-place within the cluster?

The SEC-MON-REQ-1 (Logging & Monitoring) is only for RH Internal/Restricted classified data (not our case) and the SEC-NET-REQ-5 (Monitor Egress - outgoing internet traffic) is about logging outgoing network connections (i.e. logging on the infra/networking level, not application level, AFAIK).
Yes, I was also expecting something more streamlined than "build your own splunk forwarder image from our Dockerfile and run it as a sidecar container in each pod".

The SEC-MON-REQ-1 (Logging & Monitoring) is only for RH Internal/Restricted classified data (not our case) and the SEC-NET-REQ-5 (Monitor Egress - outgoing internet traffic) is about logging outgoing network connections (i.e. logging on the infra/networking level, not application level, AFAIK), so we're not required to do that.
Yes, I was also expecting something more streamlined than "build your own splunk forwarder image from our Dockerfile and run it as a sidecar container in each pod".

Please, ask if you need any help when working on that.

I was either blind or reading too hastily because the docs is quite clear that we just need to log to stdout to see the logs in Splunk. I updated the description above.

Wait for both stg and prod instances be in MP+ before merging PR.

We're actually using it for some time already, I just need to clean up my branch and merge it, so I think that we can close this as done. :)


Docs are no longer responsive

For some reason, the latest version of the docs isn't responsive and doesn't look correct on small screens.

Looks like this is actually a bug in Vuepress;

https://github.com/vuejs/vuepress/issues/2369
https://github.com/vuejs/vuepress/issues/2607

It's been around for a while, but a fix hasn't been released yet.
It looks like there is a workaround of adding the correct meta tags to the config file:
https://github.com/vuejs/vuepress/issues/2369#issuecomment-655223066

This has been resolved using the info above!


Bring v0.2.1 to surmise main

Uploading and publishing to PyPI is now automatic.  The .whl's available on PyPI will minimize problems in user installation (i.e., building surmise from source.)
In v0.2.1, the installation guide and testing guide is mildly updated to reflect some of the testing bugs discovered.

I suggest adding a brief entry to the CHANGELOG

4f81bdd has an update on CHANGELOG. But it should have showed up in this PR. no actions were triggered with a push to develop.


fix(Turborepo): Handle directory moves in package discovery

Description

Update timeout on package discovery RPC to be a little more lenient
Handle entire directory moves in and out of the workspaces globs

Testing Instructions
Update package discovery test to handle an entire workspace moving.
Also did some manual verification.
Closes TURBO-2595

#7700  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gsoltis and the rest of your teammates on  Graphite


Python comments not highlighted as such when not preceded by a space

<script src="https://cdn.rawgit.com/google/code-prettify/master/loader/run_prettify.js"></script>
<pre class="prettyprint lang-python">
if a > b: # This is a comment
    pass

if a > b:# This is a comment
    pass
</pre>

results in

I can confirm too: https://jsfiddle.net/amroamroamro/ge8b6ycf/

I use code-prettify in Anki (spaced repetition software) for Python code. I experienced this bug with full line comments when there were divs inside the  tags, because Anki uses a WYSIWYG editor.
The solution I found (if anybody wants the same thing): https://ankiweb.net/shared/info/1114708966
Example: https://jsfiddle.net/nvc45f0d/

Just noticed the same thing on Stack Overflow.


Use Binary Heap for A* Pathfinding

I'm sorry to post this here without knowing exactly the topic but since the initial reporter doesn't want to open a ticket so I will try to do my best to get this info to you guys. You might close if you think it is useless.
Godot reached the top in HN (https://news.ycombinator.com/item?id=15309989) and a reader said this:

I hope the quality of their pathfinding code is not indicative of the overall quality of this engine: https://github.com/godotengine/godot/blob/master/core/math/a...
They scan the entire open list and recompute the heuristic value for every node all so they can find the min. Yikes! Seriously guys, implement a binary heap. It's easy and your pathfinder will be much faster for it!

Thread here: https://news.ycombinator.com/item?id=15310645
Hope it helps. Cheers!

Thanks for submitting the issue, the comment is not useless.

Some reference I believe: https://www.policyalmanac.org/games/binaryHeaps.htm

The post in HN references this part of the code:
https://github.com/godotengine/godot/blob/master/core/math/a_star.cpp#L234
I already put a comment in there mentioning that it could be optimized but,
honestly, in general given A* is pretty efficient in practical cases, this
is not too bad anyway. There are also many existing optimizations depending
on different topologies, but current implementation is meant to be more
general use case.
On Fri, Sep 22, 2017 at 12:05 PM, kubecz3k<EMAIL_ADDRESS>wrote:

Some reference I believe: https://www.policyalmanac.org/
games/binaryHeaps.htm
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/11492#issuecomment-331473301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2_C66iJdLjtslXu4c3Y7g1tAKS9xks5sk8zTgaJpZM4PgmDV
.

is this a case of premature optimization is the root of all evil ?

is this a case of premature optimization is the root of all evil ?

No. It's just a case of low priority optimization as it's already pretty fast, and as @reduz mentioned, needing some research to find out what kind of optimization can be done without compromising the generic nature of our A* implementation. But if someone wants to work on such optimization, it's welcome.

I agree this is low priority. The good thing it that from the user's end there are ways to optimize pathfinding on several agents such as by offsetting their calculations by a frame or two. If you need them to all move at once you wait for all calculations to finish and then start moving them. It's not ideal in some cases, but unless you're moving 200+ agents at once, or you're trying to move them across a dense navmesh, it really shouldn't be too much of an immediate problem :)

I think its fixed in https://github.com/godotengine/godot/pull/28925 Closed by bugsquad.


Improve syslog parser

Which issue(s) this PR fixes:
None
What this PR does / why we need it:
Improve the syslog parser code

bit faster with match? for auto mode
make code clean and remove unnecessary condition

Docs Changes:
No change.
Release Note:
Improve syslog parser and add new parser for rfc5424
Merge #3015 and this into 1 release note.

creating classes

Yeah, it is one approach.


How can I install kpn style in my docker file?

I am preparing a web-based app for our group (one of the kpn group), I use a docker as my development part which I need to make it a kpn style. I need to install it inside the docker and how can I do that? thanks.

Hi Adeljoo,
What type of docker container are you creating? What programs or tools are already installed?
In some cases, e.g. nodejs, you can just do a simple npm install like you should do in a local dev. env.
For a quick response, maybe you can send your question to our internal slack channel #kpn-style


navigation to native implementations

Currently, navigation to anything native takes me to the native header. Just like in Eclipse, I should be presented with the option of navigating to native implementations. It looks like this is easy: it appears to me that CeylonResolvable just needs to override PsiElementBase.getReferences().

Well, this was supposed be be easy, except ... AbstractNavigation.gotoDeclaration() doesn't do the right thing if its argument is not a native header!

Or is it nodes.getReferencedNodeInUnit() that is broken?

I think we need a PsiPolyVariantReference or something like that, that can resolve to more than one declaration.

Alright, I don't get this at all:

on the Eclipse platform, nodes.getReferencedNode() returns the correct node for the native backends of the given declaration, but.
in IntelliJ, it always returns the header.

Now, neither nodes, nor its argument Declaration, is something that changes between Eclipse and IntelliJ, so WTF!?

@bjansen No, I don't think so.

That might be because in IntelliJ the model loader resolution uses the source files when available (the CeylonFile.getClasses() you spoke to me once @bjansen ). wdyt @bjansen ?

Oh I see it is because in IntelliJ, the given Declaration has an IdeaCeylonBinaryUnit. Which sends it down a totally different path at line 486. (The file extension isn't ceylon.)

In Eclipse I have an ExternalSourceFile.

we should copy on the Hyper link detectors of the eclipse plugin

You ca get from one to the other afaik

So unit.filename.lowercased.endsWith(".ceylon") is a totally bullshit way of determining if this is a Ceylon declaration.

 If we are given a rootNode, why don't we use it?!

I don't see the code path you're speaking of, sorry, I was not in front of my laptop just before.

Can I just delete lines 485-527, please?

FYI I don't think I wrote AbstractNavigation ;-)

I didn't write nodes.getReferencedNodeInUnit() either :-)

However I don't really see why you want to remove all this.
If the model is not a ceylon source file,then we test if it is a CeylonBinaryUnit, in this case we get back the ExternalSourceFile (at least we try to). So we should arrive to the same result no ?

I've spent all day cleaning up the mess we had in this area, and deleted a fair amount of code. This issue is done.


add a section to build CLI executables to README

I'm a beginner of digdag and not sure how to make the digdag CLI in development.
Adding this section to README makes newbies happy, I believe.

👍  Welcome, happy newbies


Date on filename

Output filename without month.
https://wickshopbot.com/2021_0_2.png
Many thanks

I'm just using the getMonth function in JavaScript, it's zero-indexed. The second number (0) is the month, 0 just means January.

I'm just using the getMonth function in JavaScript, it's zero-indexed. The second number (0) is the month, 0 just means January.


Mapping EF child collection of entities with Identity

I am having root entity in EF that has a few children. Some children have explicit keys and they mapped/populated as expected.
One child has Identity primary key, and it is not mapped and cause errors:
The database operation was expected to affect 1 row(s), but actually affected 0 row(s); data may have been modified or deleted since entities were loaded.
My code is just
var entity = await dataContext.MapAsync<RootEntity>(dataModel);
In dataModel I have fields populated
"ChildrenWithIdentity": [
{
"Id": 0,
"ItineraryId": 73551,
"PopulatedProperty": "EzgybP6Y4qApGZYyA0Hqvw==",
}
]
but in mapped entity key is also 0 ,but properties are not copied
"ChildrenWithIdentity": [
{
"Id": 0,
"ItineraryId": 0,
//Properties are null
}
]
Do you support  child entities with GeneratedOption.Identity?
If yes, can you suggest what else can be wrong with my ChildrenWithIdentity ?
Is any tracing can be enabled that explain why mapping for this child doesn't work ?
Tor now, I've excluded ChildrenWithIdentity property by calling entity.ChildrenWithIdentity .Clear(),and  process the children manually. Can you suggest other way to exclude children properties from map?
Example of my schema
public class RootEntity
{
[Key, DatabaseGenerated(DatabaseGeneratedOption.None)]
public int ItineraryId { get; set; }
    //Navigation Properties
    public List<WorkingChild> WorkingChildren{ get; set; }

    public List<ChildWithIdentity> ChildrenWithIdentity{ get; set; }

}
For children that have known keys MapAsync works ok,
But for table with autogenrated ID it creates object with no properties
public class WorkingChild
{
[Key, Required, DatabaseGenerated(DatabaseGeneratedOption.None)]//No IDENTITY
public int ComponentId { get; set; }
public int ItineraryId { get; set; }
//other properties
}
public class ChildWithIdentity
{
  [Key, Required,DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public int Id{ get; set; }

public int ItineraryId { get; set; }
//other properties
}

Hi @michael-freidgeim-webjet,
thanks for trying the library and for the feedback
this sample works for me, could you please edit it to reproduce your  scenario?
// See https://aka.ms/new-console-template for more information
using System.ComponentModel.DataAnnotations.Schema;
using System.ComponentModel.DataAnnotations;
using Microsoft.EntityFrameworkCore;
using Detached.Annotations;
using Detached.Mappers.EntityFramework;
using System.Diagnostics;

using (AppDbContext dbContext = new AppDbContext())
{
    dbContext.Map<RootEntity>(new RootEntity
    {
        WorkingChildren = new List<WorkingChild>
        {
            new WorkingChild { ComponentId = 1 },
            new WorkingChild { ComponentId = 2 }
        },
            ChildrenWithIdentity = new List<ChildWithIdentity>
        {
            new ChildWithIdentity { ItineraryId = 3 },
            new ChildWithIdentity { ItineraryId = 4 }
        }
    });

    dbContext.Database.EnsureDeleted();
    dbContext.Database.EnsureCreated();
    dbContext.SaveChanges();
}

using (AppDbContext dbContext = new AppDbContext())
{
    RootEntity? rootentity = dbContext
        .RootEntities
        .Include(r => r.ChildrenWithIdentity)
        .Include(r => r.WorkingChildren)
        .FirstOrDefault();

    Debug.Assert(rootentity.ChildrenWithIdentity != null && rootentity.ChildrenWithIdentity.Count == 2);
    Debug.Assert(rootentity.WorkingChildren != null && rootentity.WorkingChildren.Count == 2);
}

Console.WriteLine("Hello, World!");

public class RootEntity
{
    [Key, DatabaseGenerated(DatabaseGeneratedOption.None)]
    public int ItineraryId { get; set; }

    [Composition]
    public List<WorkingChild> WorkingChildren { get; set; }

    [Composition]
    public List<ChildWithIdentity> ChildrenWithIdentity { get; set; }
}

public class WorkingChild
{
    [Key, Required, DatabaseGenerated(DatabaseGeneratedOption.None)]//No IDENTITY
    public int ComponentId { get; set; }

    public int ItineraryId { get; set; }
    //other properties
}
public class ChildWithIdentity
{

    [Key, Required, DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public int Id { get; set; }
    public int ItineraryId { get; set; }
    //other properties
}

public class AppDbContext : DbContext
{
    public DbSet<RootEntity> RootEntities { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
        optionsBuilder.UseSqlServer(@"Data Source=.;Initial Catalog=myDataBase;User ID=sa;Password=ThisIsMyPassword2023;Trust Server Certificate=true;")
                      .UseMapping();
    }
}

I wasn’t able to make MapAsync working for  my model. If child model is new, MapAsync creates new entity with all default fields(nulls or 0) instead of copy properties.
My child entity has composed key ItineraryId+  PassengerId
Example that doesn’t work:
New model child, where PassengerId  1 exists and PassengerId  2 doesn’t exist in the database.
"Passengers": [
{
"PassengerId": 1,
"ItineraryId": 73551,
"Salutation": "MRS",
"FirstMiddleName": "Janet",
"PassengerSequence": 0
},
{
"PassengerId": 2,
"ItineraryId": 73551,
"Salutation": "MR",
"FirstMiddleName": "Micheal",
"PassengerSequence": 0
}
],
MappedEntity  "Passengers": [
{
"PassengerId": 1,
"ItineraryId": 73551,
"Salutation": "MRS",
"FirstMiddleName": "Janet",
"PassengerSequence": 0,
"ItineraryListRow": {
"$ref": "1"
}
},
{
"PassengerId": 2,
"ItineraryId": 0,
"PassengerSequence": 0
}
],
Unfortunately, I don’t have time now to create minimal working example to reproduce the problem for you.
I was able to make my model working using different package
https://github.com/WahidBitar/EF-Core-Simple-Graph-Update

Have you tested the sample I sent?
Did you add [Composition] attribute to the props containing the children you want to update?
That Json is a bit confusing...  You just need to send the classes, not an entire working (or not working) example.

Hi @MNF
Good that you was able to make it work with EF-Core-Simple-Graph-Update.
Sorry, there is 0 budget for this project and it is out of my possibilities to reconstruct issues from narratives or pieces of code.
If you are interested in trying again, please send me your model classes and I will gladly make it work for you.
For models under any NDA you may send it directly to me by email.
Closing, for the moment...


Use sockaddr length from fuzzer

Commit 6814cb6a0 made major changes and introduced the
"HonggfuzzNetDriverServerAddress" function which can be defined by
a fuzzer. Unfortunately the connection attempt didn't use the
fuzzer-provided length and thus truncated longer socket address
structures such as "sockaddr_un".

Thanks for spotting this. Thanks!


Template Screen :: Adjust deleting action to be right to left

Per User Testing: Deleting design studios goes from left to right. Instead of right to left like most apps. Would want to change this to prevent accidents.

@younglisa @sshaar08 we had left to right deleting, but I guess they wanted right to left swipe action :) Switched the desc. and title to match what I've done.

working


Android Java: 2.19 Expandable RecyclerView in Android

Description
All about Expandable RecyclerView
Expandable RecyclerView in Nested RecyclerView
Domain
Android Dev (Java)
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

@VikasPandey121 Sir please assign this issue to me.

PR #8134
@VikasPandey121 Sir review this PR please.


Cannot use date range select for feedback overview table

When checking feedback for my various channels, I usually use the date range filter so I do not overlook any new feedback.
The date range selector no longer works since I upgraded to version 5.2414.51. It appears that it instantly reverts back to "Today-Today".
https://github.com/line/abc-user-feedback/assets/24491035/9d6df350-fe27-490c-bf21-887976f38e0e
I have tested this with Firefox 125.0.2 and Chrome 122.0.6261.111.
Also, another small inconvenience I wanted to report: If you switch through the channels on the top left, the date filter always resets. Which is a bit confusing if one wants to check feedback of the last week for multiple channels.

@zaanposni
Can you check your web container environement variable named NEXT_PUBLIC_MAX_DAYS?
It might be set as zero.
For the suggestion you gave us, we would work on it.
Thanks for your great suggestion!

@h4l-yup
I have tested this both without setting NEXT_PUBLIC_MAX_DAYS and by setting it to NEXT_PUBLIC_MAX_DAYS=90.
According to your documentation it defaults to 90 regardless. However, the issue remains.

Seems like this value was cached locally. Works now with setting explicitly NEXT_PUBLIC_MAX_DAYS=90 and clearing the browser cache :)
One thing I am confused about is the documentation that claims it defaults to 90. Might this be a bug because I upgraded from an earlier version before?


Publish on npm

Hello, I'm not sure if you're interested but I've published your code on npm under leaflet-maskcanvas
This is the code that enables it. If you want to merge it I can transfer ownership of the package to you.
For publishing new versions to npm just run npm run production
Btw I tested with leaflet 1.3.1 and works just fine

I went back to version 0.4 and merged. Can you add me as a collaborator on npm?
If you want, I can add you as a maintainer to this repo. Let me know.

Sure, can you send me your npm user, maybe by private email? You'll find my contact details on my GitHub profile.

My profile is pretty public anyway: https://www.npmjs.com/~domoritz. Thanks for the help!


Error displayed during startup. Do you know how to solve it?

M11H motherboard of the same model, 8700k processor

@JasmineYong It seems that you didn't change {{MACADDRESS}} (and most likely other fields) to your specific values.
See, https://github.com/vovinacci/OpenCore-ASUS-ROG-MAXIMUS-XI-HERO#download-efi-folder-archive-from-repository-releases-page


Do not ignore pubspec.lock in project templates

In https://github.com/flutter/flutter/pull/14768, it has been decided to inlucde pubspec.lock into git. But it looks like the project created by flutter create <projectname> still ignore this file. This PR fixes this.

Could you also remove it from packages/flutter_tools/templates/plugin/.gitignore.tmpl

Will land once the build is green again.

Thanks for the PR!


StackOverflowException for constraint involving a large sum

I have a bigger sum that I am creating when building the model. It consists of more than 30000 products of a variable and a constant. I add them to a big linear expression as in the following example (using C#):
Variable[][][][] x;
double[] someconst;
// initialization of x and someconst
var someVariable = model.MakeNumVar(0, double.PositiveInfinity, "s");
var sum = new LinearExpr();
foreach (var dim1 in dimension1) /* ... */ foreach (var dim4 in dimension4) {
  sum += x[dim1]/*...*/[dim4] * someconst[dim1];
}
model.Add(someVariable == sum);

I receive a StackOverflowException when executing model.Add(...), but probably emerging from C++ code - it can't be caught with VS 2019. It's a .NET Core 2.1 project.

Please use the constraint API.
MakeConstraint, SetCoefficient.
In the meantime, if you can send me a fill model to reproduce, please do.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le lun. 9 déc. 2019 à 14:17, Andreas Beham<EMAIL_ADDRESS>a
écrit :

I have a bigger sum that I am creating when building the model. It
consists of more than 30000 products of a variable and a constant. I add
them to a big linear expression as in the following example (using C#):
Variable[][][][] x;double[] someconst;// initialization of x and someconstvar someVariable = model.MakeNumVar(0, double.PositiveInfinity, "s");var sum = new LinearExpr();foreach (var dim1 in dimension1) /* ... / foreach (var dim4 in dimension4) {
sum += x[dim1]/...*/[dim4] * someconst[dim1];
}model.Add(someVariable == sum);
I receive a StackOverflowException when executing model.Add(...), but
probably emerging from C++ code - it can't be caught with VS 2019. It's a
.NET Core 2.1 project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1773?email_source=notifications&email_token=ACUPL3PJU5HVXU3Y4FW5VQTQXZAPFA5CNFSM4JYJAINKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7CJYBQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3OCPDWYYX7B5NRIJ3LQXZAPFANCNFSM4JYJAINA
.

Thanks that solves the problem!


Could you teach me about usage of sleet?

multi-line comment etc.

It's not possible now, only each line like this:
{# if this.auth.loggedIn()  #}
    {# this.auth.getUser().get('username')  #}
{# endif #}

In the next version it'll be possible to use tags in a multi-line, eg.
{# if this.auth.loggedIn()  %}
    {{ this.auth.getUser().get('username')  }}
{% endif #}

{% set
    i = 0;
    j = 1;
    k = 2
%}


Allow refreshing credentials from shared credentials file if file is modified

Is your feature request related to a problem? Please describe.
I am using cli toolling that generates shared credential files to refresh user credentials. These tools cannot be used for credential_process out of the box, but would have to be wrapped (and an expiry timestamp added as well).
Describe the solution you'd like
It would be nice for boto3 (and other AWS SDK-s as well) to notice if the shared credential file changes instead so changes to the file are automatically picked up without having to shell out to a credential process, or having to restart the process using the SDK.

Hi @reegnz,
Thanks for opening. This is a duplicate of this issue:
https://github.com/boto/botocore/issues/704
This is by design and is not recommended. You can refer to this comment for an example of how to add your own refreshable credential to the provider chain instead of using credential_process.
https://github.com/boto/botocore/issues/704#issuecomment-151943324
That issue is still open so I'm going to close this and follow up on it there too. Thanks!


[backport] Fix docstring of discriminative loss

Backport of #5423

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit a8ad9a38516089fe6f323c42fc519bf50c605310, target branch v5) succeeded!


Centralized AFQ-Browser data repository

In line with neurovault, we need to develop a centralized repository that agregates data from published instances of AFQ-Browser. This should be done automatically (with user approval) in the afqbrowser-publish function. @akeshavan had ideas for a simple database system. This database should also include fields for imaging parameters that are stored alongside the data. We can use a similar form as neurovalut but with specific fields for diffusion MRI sequences (e.g., storing b-vecs table). Ideally, there would be an option to populate these fields by parsing a DICOM file.

Resolved at github.com/afqvault/afqvault
Remaining work captured in #170.


Fix changes on master-da0bbfa

What kind of PR is this?:

/kind fix
/kind chore

Since list vault and get vault return different data interface, we should separate out the iteratces


Confusing questions about building with Intel compiler

I can't understand why I get this error, this should be the correct syntax.
'make' '-j16' '-s' 'CC=/public/home/zhangyp_hx/sortware/spack/lib/spack/env/intel/icc' 'FC=/public/home/zhangyp_hx/sortware/spack/lib/spack/env/intel/ifort' 'MAKE_NB_JOBS=0' 'ARCH=x86_64' 'DYNAMIC_ARCH=1' 'DYNAMIC_OLDER=1' 'TARGET=GENERIC' 'USE_LOCKING=1' 'USE_OPENMP=0' 'USE_THREAD=0' 'RANLIB=ranlib' 'all'

13 errors found in build log:
     293    icc: command line warning #10121: overriding '-march=core-avx2' with '-march=skylake-avx512'
     294    icc: command line warning #10121: overriding '-march=skylake-avx512' with '-march=skylake-avx512'
     295    icc: command line warning #10121: overriding '-march=core-avx2' with '-march=skylake-avx512'
     296    icc: command line warning #10121: overriding '-march=skylake-avx512' with '-march=skylake-avx512'
     297    icc: command line warning #10121: overriding '-march=core-avx2' with '-march=skylake-avx512'
     298    icc: command line warning #10121: overriding '-march=skylake-avx512' with '-march=skylake-avx512'
  >> 299    ../kernel/x86_64/sgemm_small_kernel_nt_skylakex.c(385): error: expected an expression
     300                for (int ii = 0; ii < 16; ii++) {
     301                     ^
     302
  >> 303    ../kernel/x86_64/sgemm_small_kernel_nt_skylakex.c(385): error: identifier "ii" is undefined
     304                for (int ii = 0; ii < 16; ii++) {
     305                                 ^
     306
     307    compilation aborted for ../kernel/x86_64/sgemm_small_kernel_nt_skylakex.c (code 2)
  >> 308    make[1]: *** [Makefile.L3:4730: sgemm_small_kernel_nt_SKYLAKEX.o] Error 2

Thanks for your reading.

Is this a very old version of icc ? It looks as if it is not C99-compliant and wants to see the int ii; declaration outside the loop, like int ii; for (ii=0;ii <16; ii++) ...

You can check https://www.intel.com/content/www/us/en/developer/articles/technical/c99-support-in-intel-c-compiler.html for C99 support for icc.

@jokervTv  what is your icc version and operating system ? From the path names and command line options in your message I woud assume Linux  but the Linux version of icc has -std=c99 as its default for years.

Thanks for all your help.
I installed in CentOS 7 with Intel compiler 2021.3 using SPACK. If I add cflag=-std=c99 to spack it works fine.
For everything else, just download it from github realease and everything will be fine.
So, there seems to be some issues with SPACK.
Thanks again for the help.

CentOS7 may be the decisive difference as it came with gcc4 - the icc manpage mentions that when a gcc version earlier than 5.0 is present on the system, the default for the C standard changes to -std=c11 . Now one would expect a C11-compliant compiler to support the same flexibility of variable declarations as in the earlier C99, but I guess there may have been bugs in whatever part of gcc4 backend icc ties into.


fix #113 : Users FlowChart Data Save

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
close #113
Description
[Please include a brief description of the changes or features added]
fix user flowchart data will be store into the data convex database
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
video link
Checklist:

[ ] I have performed a self-review of my code
[ ] I have read and followed the Contribution Guidelines.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@CoderSwarup  please check Contributing.md file

@subhadeeproy3902 check now


Update power-go-client to v1.1.0

dependabot tried updating to the mentioned version via https://github.com/ppc64le-cloud/ibm-powervs-block-csi-driver/pull/87 but there are breaking changes that need manual intervention.

@dharaneeshvrd can you please take a look at it?
cc @Madhan-SWE


Remove obsolete initialize_pool() function from enclave #367

Please add a description to you PRs. In general, references to github issues can be made in the description, which will automatically close them, e.g.
Closes #367


Remove fee calculations in text on distribute reserved tokens modal

What does this PR do and why?
Closes https://github.com/jbx-protocol/juice-interface/issues/3010
I just got one question, we are not issuing fees when distributing reserved tokens, right?
Additionally, I'm passing the showFees prop to determine if the splitValue will be displayed with or without fees. I'm not sure whether we need to add a unique property in SplitProps in this situation, but this feels cool to me, wdyt?
Screenshots or screen recordings

Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Looks good @NakedFool just a few comments!

Looks good @NakedFool just a few comments!

Thank you ser, i agreed with most of it but raised 2 questions above, let me know what you think!

As we can't manipulate the state solely on showFees which will corrupt other components like payouts and cause it to display amounts with fees there, I've added the isReservedTokensSplit prop to SplitProps.
Let me know what you think of the latest approach and if there is a way to do this without passing additional props! 🍻


For a 0.1.15 release

#147

Codecov Report

Merging #148 (497605b) into master (b18dc40) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   92.01%   92.01%
=======================================
  Files           6        6
  Lines         263      263
=======================================
  Hits          242      242
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18dc40...497605b. Read the comment docs.


How to use binary safe data with redis set?

Hi,
I want to store some numbers into redis SET in binary safe mode and retrieve using SMEMBERS. Can someone give me an example how it has to be done considering belowo sample code.
void func(uint16_t value)
{
string key = "TEST";
redisReply* reply = (redisReply*)redisCommand(ctxt, "SADD %b %b",
Key, strlen(Key), &value, sizeof(value));
Is this correct way of using SADD? do we need to pass pointer to value?
}
Also how to retrieve the value using SMEMBERS and compare if a particular value is available?
Thanks for the support.

Here's a small example program that does this:
https://gist.github.com/michael-grunder/54ee26173b619f1546c60b0141bb675b
It stores binary data (emojis) in a redis set, and then prints them back, along with the hex encoded binary representation of the members.

Hi Michael,
Thanks for the example, currently we are using it in different way and i fill that it might have some bug. Trying to explain it with sample code( not putting complete code).
This is how we add data to redis SET. It takes integer as an input and uses address of operator to store it in binary format. Is this correct way of doing it?
void func(uint16_t value)
{
string key = "TEST";
redisReply reply = (redisReply)redisCommand(ctxt, "SADD %b %b",
Key, strlen(Key), &value, sizeof(value));**
Is this correct way of using SADD? do we need to pass pointer to value?
}
Now when we are reading the members we are doing it something like below.
redisReply* reply_elements = (redisReply*)redisCommand(ctxt, "SMEMBERS %b",
Key.c_str(), key.c_str()));
And than check if particular value is present in the SET using below code:
if(reply_elements->elements > 0) {
for(size_t element_index = 0; element_index < reply_elements->elements;
element_index++) {
if(value == (uint16_t)reply_elements->element[element_index]->str){
free_redis_reply_object(reply_elements);
free_redis_context(ctxt);
return true;
}
}
}
In some cases we see that this check for checking if a value is present in SET always returns true, even though value is not added. So i am doubting the way we are inserting it to the SET is having issues.

This is how we add data to redis SET. It takes integer as an input and uses address of operator to store it in binary format. Is this correct way of doing it?

No, this is not how I would do this.  :smile:
Just for education purposes, you could do this like so:
uint16_t intval = 1337;

/* Write the data in it's binary representation */
reply = redisCommand(c, "SADD %s %b", "intset", &intval, sizeof(intval));
freeReplyObject(reply);

/* Read the data back and verify everything is good. */
reply = redisCommand(c, "SMEMBERS %s", "intset");
assert(reply != NULL && reply->elements == 1 &&
            reply->element[0]->type == REDIS_REPLY_STRING &&
            reply->element[0]->len == sizeof(uint16_t));

/* A uint16_t container to store the read value */
uint16_t decoded;

/* Copy the bytes into our destination container. */
memcpy(&decoded, reply->element[0]->str, reply->element[0]->len);
printf("decoded: %u\n", decoded);

This isn't portable though and will return incorrect results if you for example wrote data on a machine with a little-endian CPU and attempted to read it on a big-endian machine.
If you are only storing numbers I would just send them to Redis as strings (e.g. "12345") and then when reading them back simply use something like number = atoi(reply->str) to get them back as a number.  Redis actually has special encoding logic when a set contains only numbers (it is called an intset internally).

Going to close this, since it's not actually a bug in hiredis.
Happy to answer any other questions you may have however.


handle could not find card/board errors

If an ID is bad, Trello seems to return 404 errors with a plaintext response indicating the issue. For a missing card:
GET https://api.trello.com/1/boards/61166a47d22de30904a7b6b5/cards/6132b966d6aa0a1696621cd3
404
Could not find the card

For a missing board (or card if it's the root resource requested):
GET https://api.trello.com/1/boards/61166a47a22de30904a7b6b5
404
The requested resource was not found.

Handling 404s is an easy win, even if it's just a generic 404 message. Right now I'm only displaying the generic "Could not reach Trello" message, which encourages a new token/trying again later. Those definitely don't help in this scenario.

It also seems to be getting stuck on the error view after a 404. Likely I missed handling an error somewhere.

 handle could not find card/board errors

 Issue #21: handle could not find card/board errors


auto build and upload images to Dockerhub

I don't know what this looks like yet, but we really need to do this. Right now images can fall out of date, and the drift between this repo and the images causes confusion. I can take on the dev work, but just want to make sure I don't make any mistakes.
I need to look for prior art with other projects, maybe we can always auto-push latest. But then we should setup something to tag+build for us?

@tarrencev any opinions?

I agree this would be super helpful. Seems like dockerhub supports building from source https://docs.docker.com/docker-hub/builds/. Maybe that is straightforward to get up and running?

Added docker build/push travis job for latest tags when pushing to master in #197

Done!


[Cosmos] disable api version check for new pylint requirements

From https://azure.github.io/azure-sdk/python_design.html#python-client-constructor-api-version-argument-1
These guidelines will now begin to be enforced starting 04/15, so making this PR pre-emptively to unblock Cosmos once this check goes out (since it will block our pylint check in the pipelines). Can't merge this until those changes are out but wanted to get ahead of it.

API change check for azure-cosmos
API changes have been detected in azure-cosmos. You can review API changes here

/azp run python - cosmos - ci

Date on this got pushed to next week

/azp run python - cosmos - ci


feat(notify): add more config for webhook

What this PR does / why we need it:

[ ] Smoke testing completed

Does this PR need to be backport to the previous release branch?:
If no, just write "NONE".
If don't know, write "UNKNOWN", and let the reviewer decide.
If yes, write the release branches name in the below format and submit the related cherry-pick PR:

release/3.10

/cc @ioito @zexi @swordqiu

/lgtm


Add new type for sequence

#1082
Created a new type for txin sequence field with methods to create sequences with relative time locks from block height or time units.
Marked as draft as I expect to make changes

I also thought about having a type for a relative time locks which a sequence can be created with, but thought it would be better to add it after #994.
pub enum RelativeTimeLock {
    BlockBased(u16),
    TimeBased(u16)
}

impl Sequence {
    // ...

    pub fn from_timelock(timelock: RelativeTimeLock) -> Self {
        //...
    }

    pub fn timelock(&self) -> Option<RelativeTimeLock> {
        //...
    }

}

Sweet mate, cheers. We can probably learn a thing or two by using this patch in miniscript like I do in https://github.com/rust-bitcoin/rust-miniscript/pull/408, I can have a go but I'll wait for you first so as not to tread on your toes.

Sweet mate, cheers. We can probably learn a thing or two by using this patch in miniscript like I do in rust-bitcoin/rust-miniscript#408, I can have a go but I'll wait for you first so as not to tread on your toes.

Sounds like a good way to figure out what APIs are useful and not but I'm not familiar with mini-script so happy for you to have a go at it.

Also maybe Sequence::ZERO? Even if zero isn't popular, the constant is common on these kinds of newtypes.

Thanks all, looking a lot cleaner now.
I've made Sequence::RBF_SIGNAL public so it can be used in the PSBT tests, but now that it is public, naming seems a little off. Any ideas?

Could you add #[inline] on all public functions?

You've got a bunch of trailing whitespace issues in this PR @nlanson, we have a git pre-commit hook to help catch that (it does make committing slower though). Check out the Githooks section of the readme if you want to use it.

Hi @nlanson, I've hacked around in miniscript on top of this PR and the LockTime PR (#994). Its all working and is pretty nice if I don't say so myself. I've pushed a draft PR demonstrating use of both PRs (including some additions to the Sequence API): https://github.com/rust-bitcoin/rust-miniscript/pull/446
The Sequence improvements are in comit 3b4fb42e WIP: sequence suggestions on a branch called WIP-sequence-and-lock-time on my tree. I'll paste a diff here for folks to see without checking out the branch. By no means do you have to use my suggestions verbatim :)
diff --git a/src/blockdata/transaction.rs b/src/blockdata/transaction.rs
index b990744a..dace0958 100644
--- a/src/blockdata/transaction.rs
+++ b/src/blockdata/transaction.rs
@@ -243,10 +243,13 @@ impl Sequence {
pub const RBF_SIGNAL: Self = Sequence(0xFFFFFFFE);
/// Zero value sequence
pub const ZERO: Self = Sequence(0);
+
/// BIP-68 relative time lock disable flag mask
const DISABLE_FLAG_MASK: u32 = 0x80000000;
/// BIP-68 relative time lock type flag mask
const LOCK_TYPE_MASK: u32 = 0x00400000;
+    /// Allows getting the least significant 16 bits representing the CSV value.
+    const VALUE_MASK: u32 = 0x0000FFFF;

/// Retuns `true` if the sequence number is 0xffffffff.
#[inline]
@@ -279,6 +282,19 @@ impl Sequence {
self.is_relative_lock_time() & (self.0 & Sequence::LOCK_TYPE_MASK > 0)
}

+    /// Returns true if both sequence numbers are timelocks (i.e. enabled) and both are the same
+    /// type i.e., both height based or both time based.
+    pub fn is_same_type_locked(&self, other: Sequence) -> bool {
+        if self.is_time_locked() && other.is_time_locked() {
+            return true;
+        }
+        if self.is_height_locked() && other.is_height_locked() {
+            return true;
+        }
+        // Either one is disabled or they are different lock types.
+        false
+    }
+
/// Create a relative lock-time using block height.
#[inline]
pub fn from_height(height: u16) -> Self {
@@ -297,6 +313,24 @@ impl Sequence {
!self.is_final()
}

+    /// Returns the sixteen least significant bits representing a timelock value.
+    ///
+    /// # Errors
+    ///
+    /// Returns an error if [`Sequence`] is disabled.
+    pub fn value(&self) -> Result<u16, SequenceError> {
+        if !self.is_relative_lock_time() {
+            return Err(SequenceError::Disabled);
+        }
+        Ok(self.value_unchecked())
+    }
+
+    /// Returns the sixteen least significant bits representing a timelock value. Caller is expected
+    /// to have checked that the values are comparable by first calling [`is_same_unit_timelock`].
+    pub fn value_unchecked(&self) -> u16 {
+        (self.0 & Sequence::VALUE_MASK) as u16
+    }
+
/// Create a sequence from a u32 value.
#[inline]
pub fn from_consensus(n: u32) -> Self {
@@ -322,6 +356,42 @@ impl From<Sequence> for u32 {
}
}

+impl fmt::Display for Sequence {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        write!(f, "{}", self.0)
+    }
+}
+
+/// Catchall type for errors that relate to sequences.
+#[derive(Debug, Clone, PartialEq, Eq)]
+#[non_exhaustive]
+pub enum SequenceError {
+    /// Attempted to use sequence but it is disabled.
+    Disabled,
+}
+
+impl fmt::Display for SequenceError {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        use self::SequenceError::*;
+
+        match *self {
+            Disabled => write!(f, "attempted to use sequence but it is disabled"),
+        }
+    }
+}
+
+#[cfg(feature = "std")]
+#[cfg_attr(docsrs, doc(cfg(feature = "std")))]
+impl std::error::Error for SequenceError {
+    fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
+        use self::SequenceError::*;
+
+        match *self {
+            Disabled => None,
+        }
+    }
+}
+
/// Bitcoin transaction output.
///
/// Defines new coins to be created as a result of the transaction,
diff --git a/src/lib.rs b/src/lib.rs
index 2bb103fa..a67af7b0 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -102,6 +102,7 @@ pub use crate::blockdata::block::Block;
pub use crate::blockdata::block::BlockHeader;
pub use crate::blockdata::locktime::{self, LockTime, PackedLockTime};
pub use crate::blockdata::script::Script;
+pub use crate::blockdata::transaction::Sequence;
pub use crate::blockdata::transaction::Transaction;
pub use crate::blockdata::transaction::TxIn;
pub use crate::blockdata::transaction::TxOut;

(The error could be a struct instead of an enum?)

accidentally closed on force push

Thanks @tcharding. Good to hear it's working all well.
I was missing impl Display for Sequence so I've nicked the one from your diff.
I think the other methods are great but would be better if there was a RelativeLockTime enum.
It'll make creating relative lock-times less confusing and wouldn't be too hard to add.
pub fn from_locktime(locktime: RelativeLockTime) -> Self {
    //...
}

pub fn locktime(&self) -> Option<RelativeLockTime> {
    if self.is_height_locked() {
        Some(RelativeLockTime::Height(self.0 & Self::VALUE_MASK))
    } else if self.is_time_locked() {
        Some(RelativeLockTime::Time(self.0 & Self::VALUE_MASK))
    } else {
        None
    }
}

I'm happy to add the enum in this PR or leave it for another one.

I'd prefer doing RelativeLockTime in a separate PR. This change is already taking quite longer than I expected.

RE: Sequence::ENABLE_RBF_NO_LOCKTIME and Sequence::ENABLE_LOCKTIME_NO_RBF:
I'm finding the names misleading because Sequence::ENABLE_RBF_NO_LOCKTIME has absolute lock-time enabled and Sequence::ENABLE_LOCKTIME_NO_RBF has relative lock-time disabled.
I have got what is enabled/disabled written in both docs but still not sure if this is enough.
However, I think the confusion will be lessened by the RelativeLockTime enum that will be added later on.

What! Confusion surrounding timelock terminology - outrageous :)

added absolute and relative prefixes in docs where they were missing

This is really great! I have been ignoring this PR because there's been a ton of active discussion. Now that I look at the result, it's really ambitious and (I think) correct.
I had previously argued that we couldn't newtype Sequence since it does so many things that it's basically a raw u32 ... but I guess I've been proven wrong :)

fixed nits.


Add isPublic attribute to habits

As per the updated project problem description, 1.1 has been updated to include a way to state if it is public or private.
Implement a boolean, and methods:
Ex. makePublic(), makePrivate(), isPublic(), isPrivate()

Fixed with merge


wip Overload

missing checks to make sure we can use that overload; but some UI and update is there.

closes #4


family/meta/resource names

Given the set of breaking changes to (mostly low level) interfaces in the Meta trait in #385. We should reconsider some of the sketchier names before releasing a minor:
In particular, see this comment: https://github.com/clux/kube-rs/pull/385#discussion_r565568241:

rename Meta to Resource
rename Resource to RequestBuilder/QueryBuilder
rename Family to RuntimeTypeInformation (long name, but anyway users will rarely interact with it)

My personal opinions here:

Meta to Resource is a nice suggestion, albeit an annoying rename for every user of it (and people use it for grabbing stuff out of metadata). It would map nicely onto k8s_openapi::Resource, but that said, our trait kind of does both k8s_openapi::{Resource, Metadata} now, so it's not a huge deal to not be aligned. I am OK with keeping Meta, no real preference.

Kind of dependent on whether we go for 1, the Resource to RequestBuilder does feel sensible, and it frees up the Resource name, but again a huge breaking change for people using Resource directly (and people still do)

(There's also the practicality of swapping Resource from an object to a trait in one release, it might have to be a multi-part change.)

Family otoh, is definitely not the right name. The suggested RuntimeTypeInformation or RTI is a lot more descriptive (and less fear-inducing for people; most people will encounter it as an empty type), and there's also some precedence for the abbreviation (RTTI in C++). It's long, but it's not many places people have to specify it. But maybe there are better suggestions. The Family instance for dynamic types kind of replaces the type-erased object kind. RuntimeExtension? Perhaps maps a little bit onto the dynamic types in apimachinery

Sorry to tag you both in more bike-shed. Feel free to abstain if you are low on time.

cc @MikailBag

Haven't really read up on what Family does, so can't comment there (although it seems like users will need to get one to make a Controller?).
IMO one of the really sore spots of kube ATM is the confusion between kube::Meta, kube::Resource, k8s_openapi::Metadata, and k8s_openapi::Resource. Especially clearing up the Resource conflict is definitely worth doing..

Some comments from a user only. I don't know the implementation details very well so take it with a grain of salt.

I'm in favor of Meta to Resource. Yes, it's a bit annoying but it's much clearer and consistent with k8s_openapi
I have to be honest: As a user I never even saw the kube::Resource up until this issue so while I wasn't confused before I definitely am now :)
If I understand correctly it's the thing used by Api under the hood? Is there a reason for users to interact with this directly?

I'd be in favor of switching in one release but that's just me. It's changing anyway and I'd much rather have one breaking release than multiple.
And a bit of kinda related feedback about 3.:
3.I did look at the new Meta and I saw Family but I'm afraid I don't understand the comment above it at all. It might be I'm alone with this but I'm going to assume others have the same issue. RuntimeTypeInformation doesn't help me personally either. For me it's mostly a documentation thing at the moment before I would even be able to comment on a name.

Haven't really read up on what Family does, so can't comment there (although it seems like users will need to get one to make a Controller?).

The TL;DR on Family: it's an "optional" associated type parameter for the updated Meta trait to allow dynamic types to use it (without implementing k8s_openapi traits). There are two blanket implementations of Meta with two different Families:

impl Meta<K> for K where K: k8s_openapi::Metadata<..> and Family = ()
impl Meta for DynamicObject where Family = GroupVersionKind (the type information we need to fill the gap)

Most Controller usages won't need it. Type parameter fall away kube_runtime generally so should not show up much in user code. Here is hte one exception i've seen.

I don't have suggestions for Family at the moment, but I agree we need a better name.
Renaming Resource is definitely worth doing.

but again a huge breaking change for people using Resource directly (and people still do)

The search result shows 8.

2 are from https://github.com/slinkydeveloper/extending-kubernetes-api-in-process-poc that uses a hacked kube according to their README.
2 are comments from vendored kube-rs
1 is invalid match for kube_resource parameter from https://github.com/flodiebold/cautious-tribble that doesn't use kube.
1 is https://github.com/nikitavbv/my-k8s-dashboard which is pretty new and WIP. They're still learning kube. kube::Resource::all::<Pod>()
1 is https://github.com/stephenc/k8s-gcr-auth-helper and has kube::Resource::all::<k8s_openapi::api::core::v1::Event>()
1 is a comment in https://github.com/babylonhealth/shipcat/blob/ded1a2fe6f30fb9640b068639514f63d848d1869/shipcat_cli/src/kubeapi.rs#L112 by @clux. But this does import kube::Resource and uses it.

(It's difficult to find usage with GitHub search because this misses imports like kube::{Api, Resource} and kube Resource is too noisy.)

Yeah, it was a quick search, and while there are probably more if we can search for wildcard imports, the scope of the breakage might not be that big.
At any rate, it seems like all of you so far are pro renaming Resource, so maybe we should just do it. There's no time like semver < 1.

Going to start with the obvious thing to rename; Family in #472.

Onto part two: Resource -> RequestBuilder. PR coming up.

Not sure about RequestBuilder as a new name for Resource as it currently stands. It currently doesn't just build requests, has a bunch of state between calls, has a separate builder DynamicResource to fill in this state (effectively making it a ResourceBuilderBuilder if we were to rename).
It's possible we can instead take advantage Meta more, and instead rename Resource to Request, and pull out all its state. Then maybe we could get something like Request::create<Type>(params);, where the Type implements Meta and pull the data either out of its GroupVersionKind or the k8s_openapi::Resource associated constants at Request call time.
Might be a little iffy with namespace vars (we probably have to make it required for a Namespace scoped resource, and make separate getters/watchers for --all), but might make the struct a little more focused, which is ultimately why the naming never felt right; it's hard to define what it does singularly.
Anyway, will experiment a bit in a separate PR.

Now that we have tower (decoupling us from reqwest/hyper) and dynamic-aware Api, is it worth keeping Resource around (as part of the public API) at all?

Now that we have tower (decoupling us from reqwest/hyper) and dynamic-aware Api, is it worth keeping Resource around (as part of the public API) at all?

Very possible. But something needs to at the very least do the http::Request making logic, focusing on making that nice first.
I have renamed Resource to Request in #474 along with some other changes to make this possibly more palatable, and have less state carrying. I think this PR has a little more potential than the previous one (though it needs some work still).

Final PR continuing after #474 in #478. Planning merging both tomorrow.
The big improvements;  the new Request (old Resource) now being basically not stateful + the lifting of the url_path method into the new Resource trait (old Meta) are kind of the key changes, the rest is just fallout from those restructurings and renames.
I don't think it looks bad, but it will almost certainly be a bit annoying to do the upgrade when kube::api::Resource changes meaning in the next version, so will have to write a bigger disclaimer in the CHANGELOG.


Optimize gemv for small M, large N only if it can be done in a threadsafe manner

commit 8e5a108 tried to improve the performance of #532 but introduced a static array in the process, breaking programs like numpy that call into OpenBLAS from several concurrent threads. Supersedes the simple revert from #1852 with the intention to fix #1844 without sacrificing performance where possible.

Sorry, I did not get the comment ? (Unfortunately I cannot test this on my hexacore system this weekend, but I had tested the general idea outlined in the comments on #1852 earlier)

It looks that it enables gemv optimisation for OMP only.
Does not fail with Android UserLAnd (sort of debian chroot, atom CPU) in OMP or pthread builds, though I cannot tell if it ever failed before in this cimbination.

The intention is that it enables the optimization only when the static buffer can be made thread safe, that is either under OMP or when the compiler is capable of assigning C11-like TLS.

Patches do the trick most likely just that android tablet chroot is not always multiprocessor like a normal computer....

Merged after successful local tests

Thanks. Since this is a critical bug for NumPy, will it be part of a bugfix release?

Guess 0.3.4 is overdue in any case, will see if I can do it next weekend or at least by the end of this month. Need to try to get a decent handle on the equally ugly #1851 as well.


Crashes when the automatic "Sign in to Among Us with your Apple ID" pop up appears

Launch Among Key (1.5)
Launch iOS version of Among Us (v2021.4.12o) on M1 MBP (11.2.3)
Among Us prompts to sign in to account with Touch ID
Among Key crashes

I found a way to fix it, I removed windowDic["kCGWindowAlpha"] as! Int == 1 from line 135 in AmongKeyApp.swift that seems to have solved the problem, i know that it is for window opacity. My question is, is there a reason it needs to be there?

same here


Possible extension virus and reporting security isssues ?

Where do I report possible security issues regarding 3rd party extensions that Microsoft promote in your marketplace ?
Specificly, I have installed vscode with the gitlens extension and get this error:
Scan type: Auto-Protect Scan
Event: Risk Found!
Security risk detected: VBS.Downloader.Trojan
File: C:\Users\xxx.vscode\extensions\eamodio.gitlens-4.4.2\node_modules\copy-paste\platform\fallbacks\paste.vbs
Location: C:\Users\xxx.vscode\extensions\eamodio.gitlens-4.4.2\node_modules\copy-paste\platform\fallbacks

Thanks, this is the right place. We will investigate.

Thanks for looking at this quickly. It would properly be good if the vscode team published on your page how to deal with urgent secruity issues like this (I was looking but could find nothing about security).

BTW: Issue was found by Symantec Endpoint Protection v. 12.1.6

Seems like this file is triggering the AV alert:
https://github.com/xavi-/node-copy-paste/blob/master/platform/fallbacks/paste.vbs
As far as I can tell, the script is perfectly benign, and this is just a false positive from Symantec. According to Virustotal, Symantec is the only AV that triggers from this file:
https://virustotal.com/#/file/142020fff889cbaff71795ce8e3e8649576dfed6ca57ead6f208fb58edef782d/detection
This npm module seems to be relatively widely used in VSCode extensions, I got the detections from "donjayamanne.python-0.7.0" and "humao.rest-client-0.15.1".

@jrieken I am a bit disappointed that there is no answer yet from MS. I would have thought issues like this had a very high priority ?

Hi,
I met this issue too. Could you please fix this issue in a high priority?

To add some voice, I got the same issue with the Paste.vbs and Symantec (And sure more and more will get it).
For the record detected into donjayamanne.python-0.7.0 and ms-mssql.mssql-1.1.0
But not sure it's really an issue with vscode itself.
It looks like the Paste.vbs is not new.(https://github.com/xavi-/node-copy-paste/blob/master/platform/fallbacks/paste.vbs)
Symantec update his definition, few hours ago for me, it might coming from them.

Yeah I'm getting the same thing. Virus detected with Symantec Endpoint Protection for Mac v12.1.6
Infection name: VBS.Downloader.Trojan located in:
~/.vscode/extensions/donjayamanne.python-0.7.0/node_modules/copy-paste/platform/fallbacks/paste.vbs

Same thing here with Symantec Endpoint Protection 12.1.5.
%USERPROFILE%.vscode\extensions\ms-sql.mssql-1.1.0\node_modules\copy-paste\platform\fallbacks\paste.vbs

I don't think "me too" comments are too useful here. I'm not even sure if VScode can do anything here; I'd take this discussion first to your AV vendor, it is their false positive afterall. Has anyone succeeded at reporting this at https://submit.symantec.com/false_positive/? I tried, but I was continuously blocked by the AV so that didn't work
Then if that is not effective then maybe go to the individual extensions or even the upstream node module and try to get it changed so that it doesn't trigger the alert.

Hi,
I reported the issue to Symantec yesterday.
They replied me: We have been unable to reproduce the detection issue described in your submission.
In the meantime i just restored the file from Symantec and rescan it again. And didn't have the issue.
I think it can be closed.

Hi,
We were discussing this yesterday at work and one of our compliance engineers sent the paste.vbs file to be analyzed by Symantec. They confirmed it to be an actual trojan. However, like @gyzmau said, it seems it got fixed at some point?

@BlackyWolf same here. The current download doesn't appear to be infected. Perhaps it was infected for a short period of time. Maybe the npm account was hacked?

Hmm. Still radio silence from the Microsoft VS team. Guess we have to report this to somebody else at Microsoft that takes such matters seriously.

I caught the same situation as @xnnkmd encountered 3days ago.
In my case, file is D:\Application\VSCode-win32-x64-1.16.0-insider\resources\app\extensions\azure-account\node_modules\copy-paste\platform\fallbacks\paste.vbs
Result of analysis by virustotal was the same as the link below : Symantec was the only AV that triggers from this file
https://virustotal.com/#/file/142020fff889cbaff71795ce8e3e8649576dfed6ca57ead6f208fb58edef782d/detection
So the speculation by @BlackyWolf and @jbeanky might be doubtful.  If they are right, Microsoft should take this issue more seriously as @xnnkmd said.  I think this phenomenon might be due to false positive by Symantec as @cg-atorste speculates.

Hi All,
Apologies for the delay here - @xnnkmd I had a response ready yesterday and forgot to post it 👎
We take issue like this very seriously and I think this has pointed out a few gaps in our process - there should be an easier way to get to the marketplace team for any issue such as this - we have an alias that is for this purpose<EMAIL_ADDRESS>I've added this to our documentation and I'm working with the marketplace to make this more prominent.
A mail to that alias would key off a quick investigation to see if the extension in question included a virus and if so it would be taken out of the marketplace.  The marketplace team are always looking to improve their process and this is actually something they are actively working on.  they use tools much like the one @Jimmy0987 pointed out above.
So we should do a better job of making an escalation route visible.  I'll be adding a FAQ item for this today.
Now at the same time @cg-atorste is correct in that the only real recourse in a situation like this is to report the (in this case) false positive to Symantec.  This needs to come from one of their customers unfortunately (not the VS Code team).
False positives are unfortunately more common than you would suspect - for instance this has happened several times to VS Code itself.  In all cases these have been false positives and we have had to work with the reporting users to get them to contact their AV Vendor.
Net, net sorry for the delay in coming back - we are listening and items like this are very important so thanks for bringing it to our attention.  I'll ensure we update out FAQ with some improved guidance as well.
Closing this issue for now - but if we need to re-open LMK
Sean
VS Code Team member


--reverseproxy-port and --rewrite-host-header option are not working

Starting the paddler load balancer listening in the 8080 port with the following command:
paddler balancer --management-dashboard-enable true --management-port 8085 --reverseproxy-port 8080 --rewrite-host-header true
Generates the following debugging info:
2024-10-11T22:16:56.722+0200 [DEBUG] paddler.Balancer: rewrite-host-header: enabled=false

2024-10-11T22:16:56.723+0200 [DEBUG] paddler.Balancer.reverseproxy: listen: host=<IP_ADDRESS>:8086

2024-10-11T22:16:56.723+0200 [DEBUG] paddler.Balancer.management: listen: host=<IP_ADDRESS>:8085

2024-10-11T22:16:56.723+0200 [DEBUG] paddler.Balancer.management: dashboard: enabled=true

2024-10-11T22:16:57.111+0200 [DEBUG] paddler.Balancer: registering target: host=<IP_ADDRESS>:8083

2024-10-11T22:16:57.875+0200 [DEBUG] paddler.Balancer: registering target: host=<IP_ADDRESS>:8081

2024-10-11T22:16:58.644+0200 [DEBUG] paddler.Balancer: registering target: host=<IP_ADDRESS>:8082

The load balancer is listening effectively on port 8086 (the default port) and not in 8080, the port I configured. Besides, the rewrite-host-header seems to be the default option and not the one I configured via the command line

It is because --management-dashboard-enable true instead of --management-dashboard-enable=true.
See also: https://github.com/distantmagic/paddler/issues/20#issuecomment-2352718215

What about the reverseproxy port, that was the main point of the issue? Am I doing something wrong there?


Repo development instructions incomplete

need git submodule update --init or similar

sigh... I dislike hugo.

I prefer something simpler... built on github pages directly... like this: https://github.com/transmute-industries/respec-github-pages
I don't want to "build tool"... in my way.

@OR13, do you want to close this out as we've confirmed the move from hugo to github pages?

Yes


Link Pie and Bar Charts to Table for Autosearch

Request to add linking Pie and Bar charts to an HTML Table, similar to how Diagrams can be linked to HTML Tables with the -ID and -ColumnID parameters...
The intent is to be able to click on a chart and quickly narrow down the HTML Table to the desired data.
Example 1: If one pie showed process data memory utilization for a single computer, when you clicked on the slice with the largest section, it would show you the process in the HTML Table.
Example 2: If a bar chart show X number of computers that had process names running, clicking on each bar would filter the HTML Table to show just the computers that were represented within that bar/process name.
This would be an amazing and useful feature. Thank you for all your efforts!
Source Example:
New-HTMLTable -DataTable $DataTable -DataTableID $TableID
New-DiagramEvent -ID $TableID -ColumnID 1
Request Example:
New-HTMLTable -DataTable $DataTable -DataTableID $TableID
New-ChartPieEvent -ID $TableID -ColumnID 1
New-ChartBarEvent -ID $TableID -ColumnID 1
New-ChartBarEvent -ID $TableID -ColumnID 2
Best Regards,
high101bro

This will be available in next version
# Define data
$DataTable = @(
    [PSCustomObject] @{
        Name  = 'My Object 1'
        Time  = 1
        Money = 5
        Taxes = 20
    }
    [PSCustomObject] @{
        Name  = 'My Object 2'
        Time  = 3
        Money = 1
        Taxes = 5
    }
    [PSCustomObject] @{
        Name  = 'My Object 3'
        Time  = 12
        Money = 5
        Taxes = 1
    }
)

# Define HTML
New-HTML {
    New-HTMLTable -DataTable $DataTable -DataTableID 'NewIDtoSearchInChart'
    New-HTMLChart {
        New-ChartToolbar -Download
        foreach ($Object in $DataTable) {
            New-ChartPie -Name $Object.Name -Value $Object.Time
        }
        # Define event
        New-ChartEvent -DataTableID 'NewIDtoSearchInChart' -ColumnID 0
    }
} -ShowHTML -FilePath $PSScriptRoot\Example-ChartsWithTablesPie.html -Online #-Format

Seems to mostly work.


About the pre-trained Re-ID model in DeepSORT.

Hi,
I didn't find the link to store the pre-trained Re-ID model,  does anyone know? Also what data was used to train this pre-trained model?
Thanks.

https://github.com/ZQPei/deep_sort_pytorch


Impose 1000 character limit for search terms

Pull Request Check List

[ ] Unit Tests & Regression Tests Added (Optional)
[x] Removed Unnecessary Logs/System.Outs/Comments/TODOs
[ ] Added enough Logging to monitor expected behaviour change
[ ] Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
[x] Security - Data Exposure - PII is not stored or sent unencrypted
[ ] Security - Data Exposure - Test any altered or created endpoints using swagger
[ ] Security - Access Control - Check authorisation on every new endpoint
[ ] Security - New dependency - configured sensibly not relying on defaults
[ ] Security - New dependency - Searched for any know vulnerabilities
[ ] Security - New dependency - Signed up team to mailing list
[ ] Security - New dependency - Added to dependency list
[ ] DB schema changes - postgres-rutherford-create-script updated
[ ] DB schema changes - upgrade script created matching create script
[ ] Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
[ ] Peer-Reviewed

I've added a front end PR with a search box max length of 255 characters. The returned toast seems clear enough to me


Article for Codrops

We need a wlakthrough of toddle

@cullophid  send video to Vakis

Still not in print @Vakisr to ping Manoela

In review...


bump FSharp.Compiler.Tools to 4.1.2

ref #96

@mmitche hi, i am trying to run msbuild, and in current build workers is not in PATH.
how can i add that? is ok if is only for windows workers.

@enricosada It's not supposed to be on the path for these machines.  If you're looking for the VS version, then you should emulate the developer experience and launch the vs developer command line environment prior to starting the build in the CI file, or integrate that logic into your build script.  That ensures you get the version of VS you want.

Thx @mmitche , need to think about what the best thing to do

or integrate that logic into your build script

i fear pain maintaining env var to set,  so as last option.

or you should emulate the developer experience and launch the vs developer command line environment prior to starting the build in the CI file

so running "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\Tools\VsDevCmd.bat" .
I think i need to steal from https://github.com/dotnet/roslyn-project-system/blob/adf311612a2531b4078500d711915610da2e7d45/netci.groovy#L20-L27 so.
@davkean may i ask what do you think is the best thing to do (or who to ask about it?):

i'd like to run msbuild,exe myconsole.fsproj /t:Build (to test the f# sdk and projects works the same with msbuild.exe (.net full) like dotnet msbuild  myconsole.fsproj /t:Build )
minimal conf if possible, best if just some env var (so i can add to Process.Start in tests)

Adding also @livarcocc if you have some ideas about previous Q in https://github.com/dotnet/netcorecli-fsc/pull/100#issuecomment-290154839 about testing msbuild.exe (full) projects in test suite and CI

As a note for everyone, locally already works ok, if i enter in VS cmd promt, so:

dotnet msbuild myapp.fsproj /t:Build
msbuild.exe myapp.fsproj /t:Build

works the same (the former using f# compiler netcore as dotnet fsc.dll, the latter using f# compiler net45 as fsc.exe).
mono will follow in the same way

Ok merging this.
CI doesnt enable msbuild host full (msbuild.exe) yet.
It's possibile to test it from command line (using VS Command Prompt)
set TEST_SUITE_MSBUILD_HOST_TYPES=MSBUILD
build

this will run both msbuild host Core (dotnet msbuild) and .NET Full (msbuild.exe)


How to pass parameters to use-case correctly?

I just want to clarify what is the right way to pass parameters into use-case. In current example we pass 'userId' via constructor and we know it before we create 'UserComponent'. In case we have another situation i.e. 'Login', we know login/password only after user clicks login button so we can't pass them in such way. So what is best option to do it?

Check out https://github.com/android10/Android-CleanArchitecture/issues/32

Thank you very much!


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/docsite ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   86.12%   86.12%
=======================================
  Files           7        7
  Lines         245      245
=======================================
  Hits          211      211
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f6ea9...0e49275. Read the comment docs.


get_shape() method does not work proper

Hi everyone,
I’ve encountered a simple issue using pydot and I’ve not found any reference for the solution.
Suppose I have the following .dot file:
digraph MONA_DFA {
rankdir=LR;
center=true;
size="7.5,10.5";
edge [fontname=Courier];
node [height=".5", width=".5"];
node [shape=doublecircle];
3;
node [shape=circle];
1;
2;
node [shape=box];
init [shape=plaintext, label=""];
1 -> 2  [label="0"];
1 -> 3  [label="1"];
2 -> 2  [label="X"];
3 -> 2  [label="0"];
3 -> 3  [label="1"];
init -> 1;
}

Corresponding to the following automaton:

I would like to retrieve the accepting state (state 3), so I check the shape of each node as follows:
dot = pydot.graph_from_dot_file("path/to/automa.dot")[0]
n = dot.get_nodes()
n[6].get_shape() # returns 'doublecircle' --> correct!
n[7].get_shape() # returns 'doublecircle' --> wrong!
n[8].get_shape() # returns 'doublecircle' --> wrong!

I suppose that the get_shape() method does not retrieve the right information. How can I solve?
Thank you in advance for your help.

Hi @francescofuggitti, I agree this is a bug. Still reproducible with pydot 1.4.1.
The problem is in Common.__get_attribute__(). When the DOT element (e.g. node) for which the DOT attribute (e.g. shape) is requested does not have this attribute set, the code will look for a default value by going over the default nodes in the graph. The problem is that it returns the first one it finds, without regard for the relative sequence of the nodes. A sequence number is stored in the pydot object model that could be used for this purpose, as described in issue https://github.com/pydot/pydot/issues/80#issuecomment-356370791 for example. This sequence number is already used when writing out a raw DOT string for example. It should be possible to also rewrite the code of __get_attribute__() to consider that sequence number and then work back through preceding default nodes.
Before pydot 1.0.3, it was assumed there was only one default node. Commit b125c5d7 (pydot 1.0.3, 2010-11-02) introduced the current code that returns the DOT attribute from the first default node that has it. The code comments there also describe this, but still I doubt that it was a very deliberate choice (@erocarrera?). Perhaps it was simply not expected that the multiple default nodes would be used to repeatedly change the same DOT attribute. Or perhaps there were performance considerations for graphs with many nodes (e.g. we cannot count on obj_dict['nodes']['node'] to always be in the order of sequence, so it would need sorting). Comments welcome.
Anyway, I am setting the milestone for this to pydot 2.0.0, not pydot 1.4.2, because even if we rewrite that part of Common.__get_attribute__(), it may be difficult to get correct in one time and may cost quite a lot of time.
I do not immediately see a workaround. You could use get('shape'), which does not consider default node values at all and just returns None for nodes that do not have that DOT attribute set, but that is probably not what you are looking for. (The difference between the get() and get_*() methods in considering default values merits a separate discussion, btw.) I do not immediately know any other way to retrieve a DOT attribute that will fall back to a default value. If possible, you could of course set the desired DOT attribute on the nodes themselves and not depend on default nodes, but that is merely avoiding the problem.
Side note on the example code: n[8].get_shape() yields a different result in Python versions that keep dictionary order (Python 3.6/3.7). This is because n is a list populated from the obj_dict dictionary. I see it return doublecircle under Python 2.7.16, but plaintext under Python 3.7.3. Maybe it is better to just use a node retrieved by name as an example:
dot.get_node('2')[0].get_shape()  # returns 'doublecircle' --> wrong! should be 'circle'

Hi @francescofuggitti, I agree this is a bug. Still reproducible with pydot 1.4.1.
The problem is in Common.__get_attribute__(). When the DOT element (e.g. node) for which the DOT attribute (e.g. shape) is requested does not have this attribute set, the code will look for a default value by going over the default nodes in the graph. The problem is that it returns the first one it finds, without regard for the relative sequence of the nodes. A sequence number is stored in the pydot object model that could be used for this purpose, as described in issue https://github.com/pydot/pydot/issues/80#issuecomment-356370791 for example. This sequence number is already used when writing out a raw DOT string for example. It should be possible to also rewrite the code of __get_attribute__() to consider that sequence number and then work back through preceding default nodes.
Before pydot 1.0.3, it was assumed there was only one default node. Commit b125c5d7 (pydot 1.0.3, 2010-11-02) introduced the current code that returns the DOT attribute from the first default node that has it. The code comments there also describe this, but still I doubt that it was a very deliberate choice (@erocarrera?). Perhaps it was simply not expected that the multiple default nodes would be used to repeatedly change the same DOT attribute. Or perhaps there were performance considerations for graphs with many nodes (e.g. we cannot count on obj_dict['nodes']['node'] to always be in the order of sequence, so it would need sorting). Comments welcome.
Anyway, I am setting the milestone for this to pydot 2.0.0, not pydot 1.4.2, because even if we rewrite that part of Common.__get_attribute__(), it may be difficult to get correct in one time and may cost quite a lot of time.
I do not immediately see a workaround. You could use get('shape'), which does not consider default node values at all and just returns None for nodes that do not have that DOT attribute set, but that is probably not what you are looking for. (The difference between the get() and get_*() methods in considering default values merits a separate discussion, btw.) I do not immediately know any other way to retrieve a DOT attribute that will fall back to a default value. If possible, you could of course set the desired DOT attribute on the nodes themselves and not depend on default nodes, but that is merely avoiding the problem.
Side note on the example code: n[8].get_shape() yields a different result in Python versions that keep dictionary order (Python 3.6/3.7). This is because n is a list populated from the obj_dict dictionary. I see it return doublecircle under Python 2.7.16, but plaintext under Python 3.7.3. Maybe it is better to just use a node retrieved by name as an example:
dot.get_node('2')[0].get_shape()  # returns 'doublecircle' --> wrong! should be 'circle'

Hi @peternowee,
Thanks so much for your feedback and for considering this as a milestone for the pydot 2.0.0.
As you might have seen, I opened the issue back in 2018, and since then, I've managed to solve it by preprocessing the DOT directly. However, I'm still interested in the tool so I'll look forward to the newer versions.

Hi @peternowee,
Thanks so much for your feedback and for considering this as a milestone for the pydot 2.0.0.
As you might have seen, I opened the issue back in 2018, and since then, I've managed to solve it by preprocessing the DOT directly. However, I'm still interested in the tool so I'll look forward to the newer versions.


gql-tag-operations - preset generates sources with \r\n new lines, which don't match the source

Describe the bug
On windows the preset parses the gql documents and generates a map with \r\n newlines. This would be fine (though the source doesn't contain \r new lines, so not sure why this is happen), but because the source strings don't exactly match the input strings at runtime (especially after bundling), javascript fails to match the query to the compiled source.
For now, I am switching to augmentedModuleName which will solve this issue for me, however I thought this was worth flagging.
To Reproduce
Steps to reproduce the behavior:
On windows, run codegen with the gql-tag-operations preset. The documents map will looks something like this:
const documents = {
    "\r\n      subscription OnConnectionChanged($connection: ID!) {\r\n        onConnectionChanged(connectionId: $connection)\r\n      }\r\n    ": graphql.OnConnectionChangedDocument,
    "\r\n      mutation Disconnect($connection: ID!) {\r\n        close(connectionId: $connection)\r\n      }\r\n    ": graphql.DisconnectDocument,
    "\r\n      mutation DisableArming($connection: ID!) {\r\n        deviceSetArming(\r\n          connectionId: $connection\r\n          armingDisabled: true\r\n          runawayTakeoffPreventionDisabled: false\r\n        )\r\n      }\r\n    ": graphql.DisableArmingDocument,
   ...
}

Expected behavior

I would expect the generated source to match the input source new line characters
const documents = {
    "\n      subscription OnConnectionChanged($connection: ID!) {\n        onConnectionChanged(connectionId: $connection)\n      }\n    ": graphql.OnConnectionChangedDocument,
    "\n      mutation Disconnect($connection: ID!) {\n        close(connectionId: $connection)\n      }\n    ": graphql.DisconnectDocument,
    "\n      mutation DisableArming($connection: ID!) {\n        deviceSetArming(\n          connectionId: $connection\n          armingDisabled: true\n          runawayTakeoffPreventionDisabled: false\n        )\n      }\n    ": graphql.DisableArmingDocument,
   ...
}

Environment:

OS: Windows 10
<EMAIL_ADDRESS>NodeJS: 16

Additional context

Can you provide a full reproduction?

Hi @n1ru4l
I'll try and get you a simple one soon.
Alternatively, this commit in my open source application will fail to compile on windows but compiles fine on macos and linux (workflow)

This commit fixed the issue by patching the codegen plugin to replace \r\n lines with \n

@freshollie Do you check out files with different line-endings on windows? Ideally, you use the same line endings on each platform and let you editor take care of converting from and to your platform line endings while you edit code.
I have no issues on my Mac and Windows machines using the preset.

I'm using whatever default settings github uses for windows boxes. When I cloned on a windows machine locally (with git-bash) to diagnose I had the same issue. I write all my stuff on linux and MacOS, so none of the files should have \r\n line endings.

Ok, so the solution is to have .gitattributes to ensure that line endings are not replaced with CRLF
# Fix line endings on windows
src/**/*.ts text eol=lf
src/**/*.tsx text eol=lf

I think this threw me because it's the first time I've encountered Codegen plugin which doesn't work on windows if the line endings change.

@freshollie Should we add this to the docs?

Might be good so others don't get caught by this

@freshollie it would be awesome if you could  contribute this 😇


No tooltips for subcoordinate ridge plots

The ridge plots in the hvPlot 0.11 release blog post have invalid tooltips
https://blog.holoviz.org/posts/hvplot_release_0.11/

My request is to add valid tooltips. But if that is difficult and removing them is easy, then that could be a first step. Tooltips with ??? is a worse user experience than no tooltips.

Duplicate of https://github.com/holoviz/holoviews/issues/5375. I'm going to update the blog post to hide the tooltips. Thanks for raising that.


Add stable audio open

Paper: https://arxiv.org/abs/2407.14358
Model: https://huggingface.co/stabilityai/stable-audio-open-1.0

Thanks for the suggestion.
Currently stable audio is available within gradio interface for generation and inpainting:

Would you like it to be added to React UI or for functionality other than generation/inpainting?

Stable audio has been added, closing this issue.


Fixes NPE for Drag and Drop feature in Contentfinder

Fixes NPE in cases where resource.adaptTo(ValueMap.class) returns null value (i.e. when underlying resource is a SyntheticResource).
We had this NPE issue when using the drag and drop feature in the (classic) Contentfinder and were dragging images to DropTargets in our page.

Thanks for this contribution. I'll review and merge it soon.

Please note that this fix also fixes a nasty Stacktrace when logging in in Touch UI Startpage (/projects.html) with user "admin".


Replace footer timestamp with embed timestamp

Let discord handle the timestamp by using embed.timestamp = datetime.datetime.utcnow()

closed in commit c84dc5e76d4613868971cf8c5222b07ca85ee833

closed in commit c84dc5e76d4613868971cf8c5222b07ca85ee833


Make ()[]"' as word boundaries between each other

This produces more natural diffs in situations like () -> (word)

@kpdecker any feedback?


[Question] Why is problemTypes.descriptions an array of objects?

According to the problemTypes description:

This is problem type information (e.g. CWE identifier). Must contain: At least one entry, can be text, OWASP, CWE, please note that while only one is required you can use more than one (or indeed all three) as long as they are correct). (CNA requirement: [PROBLEMTYPE])

This makes sense, for the most part. But what we don't understand is why problemTypes.descriptions is also an array of objects? Why would it be necessary to specify multiple problemTypes items which each have multiple descriptions items? It seems that it would make more sense to have one descriptions item per problemTypes item, since we already have the ability to specify multiple problemTypes items.

That is for the same description in different languages.

So would the following be a correct example of the intended use case?
"problemTypes": [
  {
    "descriptions": [
      {
        "lang": "en",
        "description": "Improperly Implemented Security Check for Standard",
        "cweId": "CWE-358",
        "type": "CWE"
      },
     {
        "lang": "de",
        "description": "Nicht ordnungsgemäß implementierte Sicherheitsüberprüfung für Standard",
        "cweId": "CWE-358",
        "type": "CWE"
      }
    ]
  },
  {
    "descriptions": [
      {
        "lang": "en",
        "description": "BOB-881",
        "type": "Bob's rating system"
      },
    ]
  }
]

It's not exactly clear that separate problem types should be specified in unique descriptions containers. I assume if you put BOB-881 into the same descriptions object with the CWE IDs that would be valid as well but the relationship between translated entities would be gone.
Also, this once again highlights duplicity between arbitrary problem types and the taxonomy object in https://github.com/CVEProject/cve-schema/pull/6.

Your example is correct. Yes, taxonomy object may make this redundant and we may deprecate this field later.