No response for Bad URI requests

Previously bmp used to provide responses for requests with malformed URIs:
{
  "request" : { "bodySize" : 0,
    "comment" : "",
    "cookies" : [  ],
    "headers" : [  ],
    "headersSize" : 0,
    "httpVersion" : "HTTP/1.1",
    "method" : "GET",
    "queryString" : [  ],
    "url" : "http://:/"
  },
  "response" : { "bodySize" : 0,
    "comment" : "",
    "content" : { "comment" : "",
        "mimeType" : "",
        "size" : 0
      },
    "cookies" : [  ],
    "headers" : [  ],
    "headersSize" : 0,
    "httpVersion" : "HTTP/1.1",
    "redirectURL" : "",
    "status" : -998,
    "statusText" : "Bad URI"
  },
  ...
}

This doesn't seem to be the case any more with LittleProxy.

This bad request behavior is not actually covered in the HAR 1.2 spec. Do you know how chrome, firefox, or other tools record bad requests in the HARs they generate?

Looks like the problem here is twofold; certain URLs not being proxied as expected and responses not being generated for failed requests.
Main issue here seems to be that browsers generally don't care much about URLs to be RFC2396 compliant, while BMP does. So generally in browser generated HARs we would see an actual server response no matter how invalid the URL is (well it least when it comes to the query part. authority with invalid characters is treated slightly differently, but let's ignore that for now).
Take these two requests for example:
http://host/%;
http://google.com/%%

Browser would make actual requests and return real server responses - 404, 400, or something similar depending on server configuration.
However when proxied through BMP both of these will fail.
As far as I remember the issue stems simply from java.net.URI failing on everything that is not strictly RFC2396 compliant. This leads to all sort of problems when URLs which work in browsers stop working when proxied with BMP.
It's arguable whether browsers should even support such URLs but it is what is, and unfortunately a lot of websites abuse this: %uHHHH style of unicode encoding in the query string example link, or just forbidden unescaped characters which happens a lot with miscellaneous badly written AJAX requests example link
I am not sure if the underlying reason could be easily fixed or even needs to be fixed? But the Bad URI response workaround was rather useful as it gave at least some indication about what's going on.
As far as I can see, completely omitting responses leads to two problems

It breaks most HAR viewers. http://www.softwareishard.com/har/viewer/ won't even display the page if one of the entries doesn't have a response.

Essential error related information is being discarded thus making things very hard to debug.
We just ran a few browser automation tests, and I see a lot of requests with missing responses in the HAR. From past tests I remember that one of those had to do with Bad URI, but what about the rest? Do they fail due to domain resolution, internal proxy problem, something else? (actually except of one Bad URI request those tests are not supposed to have any other issues, so the high number of requests with missing response is rather suspicious...)

Thanks for the detailed analysis. I just tested www.google.com/% and www.google.com/%u20AC using the LittleProxy implementation, and both worked as expected and the HAR was correct (Google returns a 404). The legacy implementation has many limitations, and you ran into one of them.
With HAR capture disabled, the two example links you provided do work with BMP+LittleProxy, but the maccabi4u.co.il link fails when HAR capture is turned on. It looks like the netty QueryStringDecoder is throwing an exception:
java.lang.IllegalArgumentException: invalid escape sequence `%u0' at index 0 of: %u05DE
	at io.netty.handler.codec.http.QueryStringDecoder.decodeComponent(QueryStringDecoder.java:345) ~[netty-all-4.0.23.Final.jar:4.0.23.Final]

As you note, netty is "correct" in that it is not a valid URL. Nevertheless, the HAR (and BMP in general) shouldn't care whether the URL is valid. The HAR does need to decode the query parameters to capture them, but if it cannot decode them, it should handle the error gracefully.
In this specific case, perhaps there is some sort of relaxed query parameter capture would fix the issue and provide sufficient information to the HAR. At the very least, if the query param decode fails, it should still capture the URL as-is along with the rest of the request.
In general, if the HAR capture filter throws an exception for some reason (indicating a code defect), it should not abort the entire request.
Regarding the second part of your issue, when there is an error condition and HAR capture is turned on, there should be some defined behavior. Unfortunately the HAR spec provides no guidance here. A good example would be when an upstream host is unreachable. I'm open to suggestions, but I'd like BMP to follow an established pattern if one exists. Do you have any error examples from Chrome, Firefox, or other HAR capture utilities?

Do you have any error examples from Chrome, Firefox, or other HAR capture utilities?

Firefox (with Firebug) - discards failed requests.
webpagetest.org - discards failed requests.
Internet Explorer - exports a non compliant HAR... in an XML format no less!
Chrome - saves failed requests. Uses custom fields (names starting with underscore) in the response object for error data.
Charles Proxy - same as Chrome except error description is saved in the comment field.

I haven't tested other tools but my guess would be that those tools which do record failed requests   probably also use custom fields.
Custom fields sound like the safest approach imo - HAR viewers/parsers would simply ignore them according to the spec, yet the error details still can be extracted if necessary.
Here are some snippets (cleaned up everything but request/response) from Chrome and Charles Proxy.
Chrome - network timeout:
{
    "request": {
      "method": "GET",
      "url": "http://<IP_ADDRESS>/cb-multiplex.js",
      "httpVersion": "unknown",
      "headers": [
        {
          "name": "Accept",
          "value": "*/*"
        },
        {
          "name": "Referer",
          "value": "http://web.cloudbeat/monitor/8?location=5"
        },
        {
          "name": "User-Agent",
          "value": "Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.90 Safari/537.36"
        }
      ],
      "queryString": [],
      "cookies": [],
      "headersSize": -1,
      "bodySize": 0
    },
    "response": {
      "status": 0,
      "statusText": "",
      "httpVersion": "unknown",
      "headers": [],
      "cookies": [],
      "content": {
        "size": 0,
        "mimeType": "x-unknown"
      },
      "redirectURL": "",
      "headersSize": -1,
      "bodySize": -1,
      "_transferSize": 0,
      "_error": "net::ERR_CONNECTION_TIMED_OUT"
    },
    "timings": {
      "blocked": -1,
      "dns": -1,
      "connect": -1,
      "send": 0,
      "wait": 0,
      "receive": 0,
      "ssl": -1
   }
},

Chrome - DNS failure
      {
        "request": {
          "method": "GET",
          "url": "http://portalstage.hot.net.il/UploadedImages//01_2013/existing_client_banner.png",
          "httpVersion": "unknown",
          "headers": [
            {
              "name": "Accept",
              "value": "image/webp,*/*;q=0.8"
            },
            {
              "name": "Referer",
              "value": "http://www.hot.net.il/Static/1037_1484740438.css"
            },
            {
              "name": "User-Agent",
              "value": "Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.90 Safari/537.36"
            }
          ],
          "queryString": [],
          "cookies": [],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 0,
          "statusText": "",
          "httpVersion": "unknown",
          "headers": [],
          "cookies": [],
          "content": {
            "size": 0,
            "mimeType": "x-unknown"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 0,
          "_error": "net::ERR_NAME_NOT_RESOLVED"
        }
      }

Charles Proxy - network timeout
{
  "request" : {
      "bodySize" : 0,
      "cookies" : [  ],
      "headers" : [ {
			"name" : "Host",
            "value" : "<IP_ADDRESS>"
          },
          { "name" : "User-Agent",
            "value" : "Mozilla/5.0 (Windows NT 6.1; rv:37.0) Gecko/20100101 Firefox/37.0"
          },
          { "name" : "Accept",
            "value" : "*/*"
          },
          { "name" : "Accept-Language",
            "value" : "en-US,en;q=0.5"
          },
          { "name" : "Accept-Encoding",
            "value" : "gzip, deflate"
          },
          { "name" : "Referer",
            "value" : "http://web.cloudbeat/monitor/8?location=5"
          },
          { "name" : "Connection",
            "value" : "keep-alive"
          }
        ],
      "headersSize" : 304,
      "httpVersion" : "HTTP/1.1",
      "method" : "GET",
      "queryString" : [  ],
      "url" : "http://<IP_ADDRESS>/cb-multiplex.js"
    },
  "response" : {
	  "_charlesStatus" : "Failed",
      "bodySize" : 0,
      "comment" : "Connect: Connection timed out: connect",
      "content" : {
		  "mimeType" : "",
          "size" : 0
        },
      "cookies" : [  ],
      "headers" : [  ],
      "headersSize" : 0,
      "httpVersion" : "",
      "redirectURL" : "",
      "status" : 0,
      "statusText" : ""
    }
}

Charles Proxy - DNS failure:
{
  "request" : {
	  "bodySize" : 0,
      "cookies" : [ ],
      "headers" : [ { "name" : "Host",
            "value" : "portalstage.hot.net.il"
          },
          { "name" : "User-Agent",
            "value" : "Mozilla/5.0 (Windows NT 6.1; rv:37.0) Gecko/20100101 Firefox/37.0"
          },
          { "name" : "Accept",
            "value" : "image/png,image/*;q=0.8,*/*;q=0.5"
          },
          { "name" : "Accept-Language",
            "value" : "en-US,en;q=0.5"
          },
          { "name" : "Accept-Encoding",
            "value" : "gzip, deflate"
          },
          { "name" : "Referer",
            "value" : "http://www.hot.net.il/Static/1037_1484740438.css"
          },
          { "name" : "Cookie",
            "value" : "__utma=262333715.1009848784.1420231726.1420231726.1430422952.2; __utmz=262333715.1420231726.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); __utmv=262333715.|1=unique_users=1420231725131=1; __CT_Data=gpv=5&apv_9890_www08=5&cpv_9890_www08=4; WRUID=584958560.745084182; __utmb=2623337<IP_ADDRESS>0422954329; __utmc=262333715; WRIgnore=true"
          },
          { "name" : "Connection",
            "value" : "keep-alive"
          },
          { "name" : "Pragma",
            "value" : "no-cache"
          },
          { "name" : "Cache-Control",
            "value" : "no-cache"
          }
        ],
      "headersSize" : 788,
      "httpVersion" : "HTTP/1.1",
      "method" : "GET",
      "queryString" : [  ],
      "url" : "http://portalstage.hot.net.il/UploadedImages//01_2013/existing_client_banner.png"
    },
  "response" : {
	  "_charlesStatus" : "Failed",
      "bodySize" : 0,
      "comment" : "UnknownHost: portalstage.hot.net.il",
      "content" : {
		  "mimeType" : "",
          "size" : 0
        },
      "cookies" : [  ],
      "headers" : [  ],
      "headersSize" : 0,
      "httpVersion" : "",
      "redirectURL" : "",
      "status" : 0,
      "statusText" : ""
    },
}

This is fantastic, thank you. I think the approach you suggest, using custom fields, is an excellent one. My preference would be to mirror Chrome's behavior. Given the other issues, it's unlikely I'll be able to add this feature before the beta-1 release to Central, but if anybody else in the community would like to take it on, that would be fantastic!

Hi @romovs -- this is finally fixed! The code in master has been updated to include requests/responses that error out in the HAR. The _error field will be set with the relevant error message.
Would you mind testing this with your use case? If it works for you, and you see the right error information, I'm going to go ahead and release beta-2.

Hi,
Just tested with a few sites and it seems to work perfectly fine so far. Errors are present where expected and HAR is viewable once again!
Although I think I might have stumbled upon that never loading page issue again.
will elaborate about it in another topic...

Thanks @romovs -- very glad this issue seems to be fixed, but sad that the old issue is back again. I'll close this one and reopen the other.


Generated implementation

Current coverage is 92.81% (diff: 96.26%)

Merging #17 into master will decrease coverage by 5.67%

@@             master        #17   diff @@
==========================================
  Files            11         14     +3
  Lines           396        320    -76
  Methods           0          0
  Messages          0          0
  Branches         17         17
==========================================
- Hits            390        297    -93
- Misses            4         21    +17
  Partials          2          2

Powered by Codecov. Last update 1dc0c0c...070b8b8


Badge styles break when refreshing with sidebar entry active

What version of starlight are you using?
0.21.5
What version of astro are you using?
4.3.5
What package manager are you using?
npm
What operating system are you using?
Linux
What browser are you using?
Firefox and chromium
Describe the Bug

using tailwind set up according to the docs
Create a page that displays a badge in the sidebar
Go to the page
Refresh
The badge style is broken
Navigate to a different page without a badge
Refresh
The badge styling is fixed

live demo https://starlight-lovat.vercel.app/
Link to Minimal Reproducible Example
https://github.com/tgoHQ/knowledgebase
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for your report. I think in this case there are multiple issues.
First, in your steps, you mention styles being broken in step 5 after a refresh. I think the style are actually broken after the step 3:

The badge style is not updated and it should be to match Starlight default behavior when navigating to a page with a badge and get an outlined style:

This first issue seems to be related to view transitions and the usage of astro-vtbot so maybe an issue should be opened in the Bag of Tricks repository.
Commenting out the component override using astro-vtbot in the Astro configuration seems to fix this issue and navigation to a page with a badge will correctly display the outlined style.

However, I think there is a second issue with the outlined badge style with Tailwind as we can see in the 2 previous screenshots. The badge outline with Tailwind is way thicker than the default Starlight one.
The issue in this case seems to be that we internally use the .outline CSS class to apply the outline style to the badge. However, this class is also used in Tailwind to apply outline-style: solid;.
Without this extra style, the style looks closer to the default Starlight one:

Hi @kevin8181, I'm sorry that astro-vtbot is the source of trouble here!
Thank you very much, @HiDeoo, for the initial analyzes and opening an issue.
I will look into that now!

I'm sorry that astro-vtbot is the source of trouble here!

To clarify, I think this issue also spotted a Starlight issue too so definitely not just a potential astro-vtbot issue. Thanks a lot for jumping in to help! 🙌

Haha, I didn't take it that way either! I'm happy when we can help fix bugs. And it's even more motivating when you know that people are using the things you make, so I don't want to keep you waiting too long ;-)

Here is my preliminary analysis:
I assumed, Starlight's styling of active sidebar entries solely depends on aria-current="page".
This is not true. As HiDeoo already wrote, badges on the current page get an outline class instead of the variant class (.note, .danger, ...).
The Starlight support of astro-vtbot currently only handles aria-current="page", but it doesn't a) replace the variant class with the outline class when navigating to a page with a badge. And it
b) doesn't replace .outline with whatever variant got lost when .outline was set ;-) when navigating away from the page.
The fix for the bag would be to just do a) and b). But if Starlight changes the content class due to the overlap with tailwind, it would be good to know what the future Starlight solution looks like.

Of course, I would also be happy if Starlight would not set the .outline class at all, keep the variant class on all entries and overrides the current page badge like this:
<style is:global>
  [aria-current="page"] .sl-badge {
    --sl-color-bg-badge: transparent;
    --sl-color-border-badge: currentColor;
    color: inherit;
}
</style>

But I understand if there are concerns, as <Badge> as the inner component now makes assumptions about its use in the sidebar.

@hippotastic can't someone ;-) add Expressive Code to GitHub, PLEASE!

Of course, I would also be happy if Starlight would not set the .outline class at all, keep the variant class on all entries and overrides the current page badge styling

If you want to go that route, I offer to do a PR for it.

Edited: After having a second look I would say it would fit very well to the other aria-current='page' styling in SidebarSublist.astro, there even without is:global

This could indeed be a solution to use a selector like [aria-current='page'] :global(.sl-badge) but we would first need to confirm that #1530 does not expose the outline variant. I edited the description of #1765 to mention your idea as an alternative solution until we decide which one to go with. :thumbsup:

Saw that, thank you! Love #1530, @kevinzunigacuellar already did all the work. That PR would reestablish my earlier assumption that sidebar current entry styling only depends on aria-current='page' 😀

I found a thread mentioning that the outline variant is meant to be internal and not exposed even with the <Badges> component so I closed #1765 and #1530 will indeed be the proper fix to both issues 🎉

Starlight version 0.24.0 just got released today and includes #1530.
If I'm not mistaken this issue should now be resolved? Not sure there is even anything extra to do on the astro-vtbot side, right? cc @martrapp

Hi @HiDeoo!
I closed https://github.com/martrapp/astro-vtbot/issues/77 as the badges in deed work now as expected, see https://events-3bg.pages.dev/jotter/history-of-changes/. Updating to the current starlight version was the only change required.

Lovely stuff! Will close this issue then. Feel free to reopen or post a new issue if you spot anything we need to address 🙌


Recipe for accurate preprocessor dependencies

In the same spirit as #367, and provoked by @ndmitchell's bug here: https://ghc.haskell.org/trac/ghc/ticket/12135, how does one go about getting accurate preprocessor dependencies from the C preprocessor?
The manual (http://shakebuild.com/manual) suggests that needMakefileDependencies will give the information that you need. However, it is clear that inspecting the output of -M that it does not report every file in the search path: just the file that is found:
ezyang@sabre:~$ cpp -M A.h -I/tmp  -I.
A.o: A.h /usr/include/stdc-predef.h B.h
ezyang@sabre:~$ cpp -M A.h -Itmp  -I.
A.o: A.h /usr/include/stdc-predef.h tmp/B.h
ezyang@sabre:~$ cpp -M A.h -Itmp
A.o: A.h /usr/include/stdc-predef.h tmp/B.h
ezyang@sabre:~$ cpp -M A.h -I/tmp
A.h:1:15: fatal error: B.h: No such file or directory
compilation terminated.

Thus, if a file gets added somewhere in the search path, we will incorrectly fail to recompile. So what is the recipe for getting the file paths that were actually probed from the preprocessor?
As in #367, a few of the suggestions are directly applicable: we could use some sort of file tracing or turn up the verbosity of cpp to try to get this information. This ticket is a request for some runnable code which will actually do this correctly.

The closest available code right now is the usedHeaders snippet in the FAQ. But it doesn't solve the issue of includes moving around in the search path (it assumes that all files are in the same directory).

I know how to do it if you implement things yourself, and I've done it that way - just add some doesFileExist rules. I have no idea how to do it using the existing CPP toolchain as a black box, short of some kind of tracing library.

Extending usedHeaders to deal with include paths isn't too hard, but it also isn't too correct - it's already ignoring things like #ifdef. In many commercial code bases where you control all the details that's just fine (we do it at $WORK), but in those circumstances you can usually be a bit more aggressive and use #include <file> vs #include "file" to give you precise locations without any of the include pieces.


L10n update 4.8 20160422

@swill the good PR for 4.8 branch.

Can you squash the commits for me?  I will get this merged and then forward merged to master and then we can rebase the other ones to to make sure we don't have merge conflicts.  Thanks...

@swill It's done.

@milamberspace sorry to do this to you again.  :(  Can you force push again so we can try to get travis green.  Thanks...

@swill re-push force done.

@milamberspace and again.  :P sorry...

@swill re-done.

Well Jenkins just does not like us today.  Can you review the error and see if it is a valid error and try again?

I see another PR with the same error, so I doubt it is your PR.

@swill Now the Jenkins build works, but the Travis failed with:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
...

@swill after a new push to start a new Travis build, Travis and Jenkins are now green! You can merge the PR! :-)

awesome, thank you sir.  i will get this merged today...

LGTM
tag:mergeready

Please rebase this PR to fix the merge conflicts.  Thanks...  #1527 has been merged into 4.7 and then forward merged to 4.8 and then master.  Once the merge conflicts are fixed in this PR, I will merge this one next and then I will check if #1376 has conflicts (which it currently does).

@swill conflicts fixed. Push with force done, ready to merge.


Add checks to ensure valid atb technology and tech_detail

Anywhere that users need to type an ATB technology and tech detail (eia_atb_tech_map, atb_multipliers, atb_new_gen, etc) the code should check to see if the names are valid. It's too easy to slightly mistype and get a confusing ValueError.

Fixed in commit 661e2e39dffa77a0e9d94b63678911b2cd87f65a


Support building with time-1.10

time-1.10 removes several deprecated functions that time-compat reexports:
[ 4 of 17] Compiling Data.Time.Format.Compat ( src/Data/Time/Format/Compat.hs, dist/build/Data/Time/Format/Compat.o )

src/Data/Time/Format/Compat.hs:10:5: error:
    Not in scope: ‘parseTime’
    Perhaps you meant ‘parseTimeM’ (imported from Data.Time.Format)
   |
10 |     parseTime, readTime, readsTime,
   |     ^^^^^^^^^

src/Data/Time/Format/Compat.hs:10:16: error:
    Not in scope: ‘readTime’
    Perhaps you meant one of these:
      ‘readSTime’ (imported from Data.Time.Format),
      ‘readPTime’ (imported from Data.Time.Format),
      ‘readFile’ (imported from Prelude)
   |
10 |     parseTime, readTime, readsTime,
   |                ^^^^^^^^

src/Data/Time/Format/Compat.hs:10:26: error:
    Not in scope: ‘readsTime’
    Perhaps you meant one of these:
      ‘readSTime’ (imported from Data.Time.Format),
      ‘readPTime’ (imported from Data.Time.Format)
   |
10 |     parseTime, readTime, readsTime,
   |                          ^^^^^^^^^

It's not clear to me whether time-compat should:

Define forward-compatible versions of these functions for newer releases of time,
Stop exporting these functions, or
Something else.

I think we should do 1 + 2, i.e both.

make time-compat-<IP_ADDRESS> which would compile with time-1.10 (important)
and time-compat-1.10 which would make interface as in time-1.10 i.e. drop the re-exports (not so important, can be done later)

Note, we probably should have 1.9.3 adding pastMidnight and sinceMidnignt

Released in Released in https://hackage.haskell.org/package/time-compat-1.9.3

The time-compat-1.10 can wait, I don't see any urgency to make major release


recordType could be wrong

Hello,
First, your project is great, go on : it really helps to understand the Amz adv API. On my side, I am trying to use it for reporting (only).
However, I am encountering some issue with Sponsored Brands report request :
Are these recordType options corrects ? Sounds like undefined to me when trying...
https://github.com/ScaleLeap/amazon-advertising-api-sdk/blob/f519825f2fb513a75f5bd6af99116d44ebc9efc3/src/operations/reports/report-types.ts#L23-L25
I have error message like :

Could not find resource for full path: https://advertising-api-eu.amazon.com/v2/hsa/headlineSearch/report

Hi, @guillim
I confirmed your issue with headlineSearch and searchTerms report type (resolved in https://github.com/ScaleLeap/amazon-advertising-api-sdk/pull/689).
But, I couldn't reproduce with targets from sandbox API.
Could you please to show more info?

Hi, @guillim
I confirmed your issue with headlineSearch and searchTerms report type (resolved in https://github.com/ScaleLeap/amazon-advertising-api-sdk/pull/689).
But, I couldn't reproduce with targets from sandbox API.
Could you please to show more info?


Switch to slf4j instead of commons-logging

Enhancement
Remove dependency on commons-logging and use slf4j instead. We have a spring boot application that now outputs uncaught exceptions to console, because the ExceptionLoggingFilter https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/ExceptionLoggingFilter.java is logging uncaught exceptions to a commons-logging Log.
We can circumvent commons-logging, but why use it in the first place?

Spring Framework standardized on commons logging a long time ago

Hi, you are right but I think we only have a problem with ExceptionLoggingFilter.java because the actual Log class in provided by another jar spring-jcl https://github.com/spring-projects/spring-framework/tree/master/spring-jcl/src/main/java/org/apache/commons/logging which delegates to SLF4J while Sleuth is actually using the "true" apache commons https://github.com/spring-cloud/spring-cloud-sleuth/blob/4fcd0d59504640a94b405c7b7720794b5aed94ff/pom.xml#L219

I don't understand the problem. What would you like us do for that matter?

Hi, I let it open as to me it makes sense to rather reference spring-jcl instead of commons-logging in the pom.xml.
Since projects using spring cloud already have spring modules, bringing commons-logging as a transient dependency besides spring-jcl might cause not so evident problems.
If you don't think it's worth it, the issue can be closed from my perspective.
Thanks!


Electrocardiogram's(ecg's) qrs peak and heart rate detection using dwt using matlab

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #4829

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Hi @collince777
Upon running your article through our 3rd party plagiarism checker it seemed to raise a few flags and the % was higher than we typically accept. Please see attached PDF - and revisit the article to ensure we are contributing wholly unique and original content. Be sure to see our resources page to see more info on plagiarism and what is considered as such.
Electrocardiogram's(ecg's) qrs peak and heart rate detection using dwt using matlab #5145 Copyleaks Report.pdf

@collince777
Good afternoon and thank you for submitting your topic suggestion.
Not a problem - it seems this PR is still quite a bit aways from being completed.
As a rule of thumb - please only submit articles (pull requests) with a complete and fully polished article - ready to be published.
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue).
We will be closing this and please re-submit when it is ready to be published as a new PR (and you can add the duplicate label) and ping the reviewer and myself.
Closing a PR does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
👍
cc @LinusMuema @M0nicah

@M0nicah
I may have confused this pr with another one when I closed it.
Is there anything being done to this PR or is it ready for a final review?
Not sure what stage this is in?
cc @collince777

@LinusMuema plagarism issue fixed.
cc @M0nicah

Great article @collince777
Thank you for the review @M0nicah.


Assure that the length is an integer

The current version will cause a bug when using --num_training_epochs instead of --num_training_steps, because the argument  num_training_steps may be a float number here by args.num_training_steps = args.num_training_epochs * len(training_features) / train_batch_size Line 113 in run_seq2seq.py file.

@yuchenlin Thanks! I've merged the PR. I also add a fix at https://github.com/microsoft/unilm/commit/9948e3b9c9f8e1eae78658effd726c2a8a5488a7 .


Replayer, no checkpoint file when finished

The replayer was generating a checkpoint file when it finished, if no target epoch ledger hash was provided.
But the last commands replayed may not be all the commands in a block, so the checkpoint file is not a valid state. So don't generate that file.
The checkpoint files generated with --checkpoint-interval do represent valid states.

!ci-build-me

!ci-build-me

!ci-build-me


Update Emscripten support

https://github.com/emscripten-core/emscripten/issues/10148 is a report from a cargo-web user whose Emscripten installation is managed by cargo-web but is invalid. I took a look at the cargo-web source, and noticed a few issues:

The help messages with instructions for installing Emscripten should probably recommend using emsdk regardless of the platform, since that's the only distribution method maintained by the Emscripten team and will make getting the latest bugfixes much easier.

The instructions for installing emsdk are out of date. The current recommended method is to clone from GitHub. The mozilla-games s3 bucket is not being updated any more.

It looks like cargo-web is trying to use Emscripten's fastcomp backend, but recent versions of Rust have switched to using Emscripten with Rust's LLVM rather than the separate fastcomp LLVM. Recent emsdk versions install the upstream-LLVM version of Emscripten by default.

It looks like cargo-web is trying to use Emscripten's fastcomp backend

yepp
https://github.com/koute/cargo-web/blob/2ddd9bbb567b8d4893e923cba8ad03806d383d80/src/emscripten.rs#L14
$ emsdk list --old | grep 1.38.19
         sdk-fastcomp-tag-1.38.19-64bit
           emscripten-1.38.19

recent versions of Rust have switched to using Emscripten with Rust's LLVM

so .. are there alternatives to cargo-web? (compatible with recent version of emscripten)
or .. how to fix cargo-web?

I would recommend just using cargo itself without additional tools. Details here: https://blog.therocode.net/2020/10/a-guide-to-rust-sdl2-emscripten.


ant themes: should not use a fixed output path

Motivation for this change
Fixes https://github.com/NixOS/nixpkgs/issues/82833.
See also https://discourse.nixos.org/t/using-fixed-output-paths-for-a-derivation/6338.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I just copied what was already there when I did this so if this builds it should be good


WIP: Add a hidden "-quiet" directive

This is for discussion regarding #201

If we make the verbose flag depend on how doctest is being invoked then we will also need a flag to override the default in the other direction. Not sure about the appropriate name. Since we already use -nonrecursive, perhaps we should go for -(non)quiet or -(non)verbose?

This PR adds -quiet and -verbose, setting an internal verbose setting to true or false.  Without either input, the default depends on the number of output arguments.
This deliberately does not document this.  We can tweak the names, or just leave it undocumented for a while and decide later...

I will merge this: further tweaking to happen elsewhere.


Update MissingH1.md

PRMerger Results

Issue
Description

File Change Percent
This PR contains file(s) with more than 20% file change.


[DO_NOT_MERGE]create new propery visiabily predicate

address: https://nanopay.atlassian.net/browse/NP-2802
nanoside: https://github.com/nanoPayinc/NANOPAY/pull/11184
note: create new PredicateProperty for Capability called visibilityPredicate. this is use to decide if we want this capability card visible or not base on a predicate

You could use PropertyEqValue predicate

Please pull foam master into this branch.


no-unused-prop-types doesn't support Props defined in Flow TypedArguments

This syntax is not supported. Additionally, this code is already available for the prop-types rule, but we should extract this code to detect the existing prop-types to some shared utility so it can be shared between rules.
// Flow <0.53
class extends React.Component<DefaultProps, Props, State> {}
class extends React.Component<DefaultProps, Props, State> { props: Props; }

// Flow >=0.53
class extends React.Component<Props> {}
class extends React.Component<Props, State> {}

class extends React.Component { props: Props; }
class extends React.Component<Props> { props: Props; }
class extends React.Component<Props, State> { props: Props; }

FYI I'm working on this: https://github.com/jseminck/eslint-plugin-react/tree/prop-types-util - just to make sure we don't do double work!

Just an update on this and also for myself to keep track of all the changes:

Added support to no-unused-prop-types for Flow 0.53 syntax: Component<Props, State>
Added support to all other lifecycle methods for prop-types rule. Previously it only supported componentWillReceiveProps and constructor
Added support for prevProps variable name for prop-types rule.
Added support for destructuring in lifecycle methods for prop-types rule. e.g. componentDidUpdate({myProp}) { ... }

This is far from done. My biggest issue to tackle is how to make Component.detect() and this new PropTypes.detect() work together.

Is there more to do that hasn't been merged into the release candidate?

Currently using the Flow TypedArgument syntax should work:
React.Component<void, Props, void>

or
React.Component<Props>

There's some work to complete as I would like to eliminate ALL shared code between the two rules (prop-types and no-unused-prop-types) so that both cover the same use-cases. Currently there's still a bit of a difference between the two.
But in general I'd expect the Flow syntax to work. Did you encounter any issues?

Nope! Just curious if this issue should be closed or open after I noticed the PR getting merged.

hi @jseminck
I am still encountering troubles with this kind of code :
type Props = {
    loggedUser: User,
    logout: () => void,
}
[...]
    render() {
        const {state, props} = this
[...]
<SomeComponent user={props.loggedUser} logout={props.logout} />

I shows me the ESLint error
ESLint: 'logout' PropType is defined but prop is never used (react/no-unused-prop-types)
Having theses version number:
    "eslint": "5.3.0",
    "eslint-config-airbnb": "17.1.0",
    "eslint-plugin-flowtype": "2.50.0",
    "eslint-plugin-import": "2.14.0",
    "eslint-plugin-jest": "21.21.0",
    "eslint-plugin-jsx-a11y": "6.1.1",
    "eslint-plugin-react": "7.11.0",
    "flow": "0.2.3",
    "flow-bin": "0.78.0",
[...]
    "react": "16.4.2",

@bastoune it’s not used in any of the code you showed; please show the entire component instead of eliding parts of it.

This seems all fixed.
If not, please file a new issue.


Issue with Address example (arpitapatnaik-address-out)

Referring to the (arpitapatnaik-address-out) file:
In the output file, Harvard is considered as an address. However, it is not an address if it is not Harvard University or an actual postal address that includes Harvard as the street name, lane name, etc.
It can also be considered as a name, but not an address.

Updated


Missing Models Files?

I'm trying to retrain and rebuild the FaceDetector. The following files are missing from GoogleDrive and the Repository

yolov5s-face
age_efficientnet_b2
gender_efficientnet_b2

(Which place Google Drive or .rar is the correct place to get the models?)

... ooh right; it looks like the

<IP_ADDRESS> https://github.com/FaceONNX/FaceONNX

... points here ...

https://github.com/FaceONNX/FaceONNX.Models/tree/5f89e44f574195a8ae10d4a565ab5969a8a3f09e

... and not to the "head" ...

https://github.com/FaceONNX/FaceONNX.Models/

... so ... i'll submit a pull request with that ...

https://github.com/FaceONNX/FaceONNX/pull/18


Undefined variable: "$line-height-computed"

I just install your extension and I'm having this error, does anyone may help?
Undefined variable: "$line-height-computed".
  (in /Users/steven/workspace/ruby/foot-cardigan-store/app/assets/stylesheets/spree/frontend/bootstrap_frontend.css.scss:10)

I'm pointing to the 2-2-stable branch.
Gemfile.lock
  remote: git://github.com/200Creative/spree_bootstrap_frontend.git
  revision: b438fee221aea44d4389b219c9da4c0a3ce8ae58
  branch: 2-2-stable
  specs:
    spree_bootstrap_frontend (2.2.0)
      bootstrap-kaminari-views (~> 0.0.3)
      bootstrap-sass (~> 3.1.0)
      spree_core (~> 2.2.0)

Getting this same issue. Am using Bootstrap 3 in the app but have not added files to vendor/stylesheets, vendor/javascripts, vendor/fonts

Using spree 3-0-0-stable branch.

@sfkaos if you're using spree 3 then spree_bootstrap_frontend is already merged into spree, so no need to use this gem! :smiley:


Incorrect error about the global namespace referencing types from a versioned namespace

Another weird one for you @timotheeguerin:
I found a particular combination of factors that causes this interesting error:
error @cadl-lang/versioning/using-versioned-library: Namespace '' is referencing types from versioned namespace 'Contoso.WidgetManager' but didn't specify which versions with @versionedDependency.

Here is a playground sanple that reproduces the issue.
The problem goes away if you do one of two things:

Change the type of result?: TResource to not use TResource (or remove the property entirely)
Remove the & Cadl.Http.AcceptedResponse on line 49

I'm not sure how this combination causes the global namespace to be affected by versioning checks!

Smaller repro without azure core https://cadlplayground.z22.web.core.windows.net/?c=aW1wb3J0ICJAY2FkbC1sYW5nL3Jlc3QiOwrTGnZlcnNpb25pbmciOwoKdXNpbmcgQ2FkbC5IdHRwO8wRUmVzdM0RVsk7OwoKQMdJZWQoxxhzKQpuYW1lc3BhY2UgTXlMaWIgewogIGVudW0gyCPFEiAgdjEsxggyxAh9CiAgbW9kZWwgUmVzb3VyY2VPcGVyYXRpb25TdGF0dXM8VMgZPsdBLy8gUkVQUk86IENvbW1lbnQgdGhpcyBvdXQgYW5kIHRoZSBwcm9ibGVtIGdvZXMgYXdhec85TWFrZcY2YW55IG90aGVyIHR5cGXfQXJlc3VsdD86IOkAlDvlAMN9CgpAc2VydmljZVRpdGxlKCJDb250b3NvIFdpZGdldCBNYW5hZ2VyIinsATvHJC7GJMcj6AFpc8wrRGVwZW5kZW5jeSgKICBbW946LnYyMDIyXzA4XzMxLOYBjcscMV1dCuwBrdVMIHsgICD4AcDKXjogIsQNLTA4LTMxIuYBz%2BkB0EZvbyB7xRBpbnRlcmbEbcZlyEp0ZXN0KCk65wCj%2BAIARm9vPiAm6gKoLkFjY2VwdGVkUmVzcG9uc%2BgBhA%3D%3D


Eventual consistency memory leak

When performing a 90/10 get/put test using an eventually consistent clustered store with two or more clients, we have a memory leak in the "clientsWaitingForInvalidation" map in the "org.ehcache.clustered.server.EhcacheActiveEntity" object.  We do not run into this problem with only one client or when using a strongly consistent clustered store with any number of clients; it appears that the client may not be sending invalidation acks in an eventually consistent store which means that their entries are never removed from the "clientsWaitingForInvalidation" map.
The cache consisted of 16gb of clustered storage, Eventual consistency.  The server ran with 2gb min and max ram and the ConcurrentMarkSweep collector.  Contact me for test code / server config as well as a heap dump - github isn't allowing me to attach files.

Good catch - this is a consequence of the work for #1211 done in #1512 where we account for invalidation tracking on the server side for eventual caches.
But indeed the EventualServerStoreProxy was never modified to send the invalidation ack message.
@AbfrmBlr Can you look into that?


Closing menu subItem

Hi @oguzbilgener
i implement your CircularFloatingActionMenu code it's working fine, a little issue on when i click on open menu item it will not close subitem. is it possible, then how ? please guide me,
Thanks.

@GauravCreed : If you want to close the subitem after clicking on it, you can use
 leftCenterMenu.close(true);

@Ruchita7 Hi, is it possible to close the menu if I touch everything on my screen outside the circular menu button? I have tried to using onFocusChangeListener but it doesn't work.

@Keda87, i have tried closing the circular  menu on clicking the parent menu item and that closes the sub menus. I didn't try closing it by clicking elsewhere. I also assumed that onFocusChangeListener would work in this scenario.But as you said that doesn't work, I would need to check on this..


Fix C4244 from MSVC in sort.

The issue goes away in MSVC 19.16.27030.1, should I leave this P/R open?

@zhihaoy, hrm, your call. This probably isn't the right fix; instead of casting, we should change the type of the variable. @griwes, thoughts?

It's a safe fix because "log2 round to integer" can't overflow any type.  Raising num_passes to Size looks pedantic... I will leave it open for a while because someone else seems to encounter the same issue https://devtalk.nvidia.com/default/topic/1064002/b/t/post/5387873/

This patch looks reasonable to me -- we wouldn't be running more than 2^32 passes so just casting to an int should be ok. @brycelelbach @griwes if you have any objections to this let me know, but I'll start moving towards integrating this in case folks are still using older MSVC 2017 builds.

Started internal CI: 28483968

Tests pass -- I'll merge this soon.


Icon conditions

Hello Marco
First, thank you for this card, it looks very promising!
I'm trying to customize my icons based on conditions but I can't get it to work. Is it a bug? or it is only me?
This is my code:
`type: custom:room-card
title: Garage
entities:

entity: sensor.rotary_encoder_1
show_icon: true
icon:
conditions:
- icon: mdi:car
condition: below
value: 5
- icon: mdi:car-2-plus
condition: above
value: 5`
The value of my sensor is 0. I tried several sensors, different values, I'm just getting the default icon.
Thanks!

  - entity: sensor.motion_sensor_overloop_illuminance_2
    show_icon: true
    icon:
      conditions:
        - icon: mdi:car
          condition: below
          value: 5
        - icon: mdi:car-2-plus
          condition: above
          value: 5

I tried your config wiht a sensor of mine and this is working. Is the output of the sensor by any chance a string value in stead of an integer?

Thanks for helping.
I checked the value in the developer tools / template, it's reported as a number

Your welcome, always nice to help people make their life a little better


Add support for open and read timeouts

This is an alternative take on #316 using Python's time.time().

I have made a significant change : after the open / read operation completes, we clear the timeout. There may be other places where the AVIOInterruptCb is used and we don't want to cause breakage.

@mikeboers if we set the defaults to "0" (no timeout) would you be comfortable with merging this?

I've not read it, and don't think I can today, but I'm happy with it with no changes to default behavior if you're ready to merge it.
takes a second to read it anyways
I'm a little iffy on overloading options for it, but I'm game. If we hate it later we can support it for a couple major versions. NBD.
Ship it!

Actually I think I agree with you @mikeboers, "options" is already confusing enough as it is. Maybe explicit open_timeout and read_timeout defaulting to None would be better?

That would be better. Maybe it is confusing, but Requests' request.request timeout is interesting.
(It is a float in which case it is used for both, or a 2-tuple for connect and read timeouts.)

The requests example is indeed interesting. Regardless of whether we use a tuple or two values I think using seconds (and not milliseconds) like requests is more pythonic.

It should absolutely be seconds.

The timeouts are now in seconds. I'd still like to add some unit tests, but I haven't come up with a good testcase yet. I'll try spinning up an HTTP server in a child process and make it reply slooowly.

FYI I'm totally sold on the requests model. Most of the time you just want a timeout, and don't care to set them separately.

OK I have changed the API to take a single timeout argument as requested.
I have also managed to add a test for the "open timeout", which led me to realize my code was badly broken: storing a time as a C float is useless, we need a double.

I've restarted the two failed Travis builds. AppVeyor doesn't like it at all.
CI may not like it, but I do.

The Travis failure looks like flakiness, which I can probably work on.
The AppVeyor failure on the other hand looks like something else altogether. The test which is failing doesn't use timeouts at all, opening the file should just work.
What's this error?
copying build\lib.win32-2.7\av\buffer.pyd -> av
error: could not delete 'av\buffer.pyd': Access is denied

CI is in a very weird state right now:

on Travis, random unrelated tests are hanging

on AppVeyor, switching from "multiprocessing" to "threading" has eliminated the "Access is denied" failure but the new tests are hanging

This is passing having been rebased onto develop and using the new testing infrastructure (which is still missing PyPy).

I take it back. It failed on one of the windows machines. LOL


file

Output of docker version:
(paste your output here)

Output of docker info:
(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):
Steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):

Sorry, I have no idea how this got submitted!  My apologies.

Heh, no worries; I suspect you tried "search" and the "create issue" is easy to click :smile:


Update partner packages to consume the latest version of our packages

This is the work we need to do near the end of preview4 so that we don't leave NSwag and Swashbuckle broken.

@mkArtakMSFT near the end or after we have released preview 4 to NuGet?

@dougbu - is this a preview5 thing or later?

It's both. I'll be sending a PR for the NSwag repo later today referencing the preview 5 daily builds. Expect that PR won't close 'til I update it to reference the then-public packages.

RicoSuter/NSwag@4439cf2ec6aa


feature: Allow InvokeCommand to use IReactiveCommand<T, TResult>

What kind of change does this PR introduce?
Use interface intead of implementation.
What is the current behavior?
InvokeCommand cannot be used with instances of IReactiveCommand<T, TResult>
What is the new behavior?
InvokeCommand can be used with instances of IReactiveCommand<T, TResult>
What might this PR break?
Nothing.
Please check if the PR fulfills these requirements

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

Other information:
Minor change. Should be fine.

Oh, build failures kicked in. I'll take a look later.

Was just discussing this one between myself and @ChrisPulman
I think this one might have to be a reject, due to the nature of C#
If the parameters only change based on having two interfaces, C# can't handle it and will cause ambiguity
The solutions you could potentially do is create a new method InvokeReactiveCommand( but that gets away from the point we don't want users if possible ICommand except when required by their UI framework.
Also then there is a argument why aren't you using ReactiveCommandBase if you're using a IReactiveCommand
I think it was definitely a nice to have one if the compiler could handle the two interface declarations and would of supported it going in, but unfortunately in this case I don't want to have method name changes imposed on existing code base etc.
Seemed simple but unfortunately not.


Quwstion

Removed

https://github.com/expressjs/express/blob/master/Security.md

@Osslack your ask is not possible to do right now because of issues in the underlying dep. You've put us in a real bind now my broadcasting this to 1,788 people. Your profile does not have your email address. Please contact me.

@dougwilson I sent you an email.


Add support for Smart Battery Protect

I tried to port https://github.com/keshavdv/victron-ble/pull/48 to this fork. Please doublecheck if everything is correct, because I have no Python experience and did not test it.
Summary 📝
This adds support for the Smart Battery Protect; implemented using the Victron extra manufacturer data PDF and tested locally. Added tests and confirmed the linters passed.
Details - I had originally implemented Smart Lithium as part of this branch, but I see there is already a pull request for that, so I limited this just to Smart Battery Protect.

This change is missing checks for N/A values described in the Victron documentation.  I will merge it then add those checks.  Unfortunately I don't own one of these devices to test it myself.


Added default values for the shemaphore and the shared memory

Fixes #1008
These can be overridden by setting envvars.

@chingor13 Thanks for the review. PTAL


remove certs

bug 1100841

This will break the sample apps ...
https://github.com/dotnet/AspNetCore.Docs/blob/master/aspnetcore/fundamentals/url-rewriting/samples/3.x/SampleApp/Program.cs#L31


MWPW-160511: badge & switch to AEM Prod

This PR will have to go to stage after https://github.com/adobecom/milo/pull/3063, so for now it's based on the Axels feature branch

add badge
fix fonts
switch to Odin prod

Resolves: MWPW-160511
CCD test page is not yet ready, waiting for the Prod publish of CFs:
MWPW-160511-badge--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://MWPW-160511-badge--milo--adobecom.hlx.page/?martech=off

@3ch023 Do you know what exactly size the badge font should be?
On stage it is 14px, on your branch 16px and in figma when i inspect i see it 12px.
stage:

this PR:

Approving the PR to unblock the work. As agreed created the follow-up jira for the above observations. https://jira.corp.adobe.com/browse/MWPW-161357
cc: @3ch023 @Roycethan


Pass path as environment variable in /1.0/containers//exec

I'm making a script that creates LxC containers with Laravel 5.1 installed in the image template.
Everything works fine except when I try to run composer dump-autoload using the exec functionality doing a post to LxD API. The other commands work fine.
The problem is that the command is running in the root path and I need composer running in /home/vms/public_html/edge/
Is there any way to pass a path as parameter with the environment variable?
Thank you.

lxc exec --env HOME=/tmp zerotier pwd
/tmp

Tthanks , it worked perfectly.

Is it possible to pass more than one environment variable?

Yep, you can use --env multiple times.
stgraber@dakara:~$ lxc exec --env a=b --env b=c zerotier env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
container=lxc
a=b
b=c
HOME=/root
TERM=xterm
USER=root

Thank you. I was going to add an api example, but went wrong someplace:
I was going off of your post on using the api and also the exec api endpoint reference and ran
lxc exec $CONTAINER --debug -- touch newfile
to try to get the posting format correct, which I copied into the curl command below:
curl -s --unix-socket /var/lib/lxd/unix.socket a/1.0/containers/$CONTAINER/exec -X POST -d '{"command":["touch newfile"],"environment":{"HOME":"/root","TERM":"xterm-256color","USER":"root"},"height":48,"interactive":true,"wait-for-websocket":true,"width":135}' | jq .
{
  "type": "async",
  "status": "Operation created",
  "status_code": 100,
  "metadata": {
    "id": "dd3adfda-4935-4a42-a837-03b0a61d668f",
    "class": "websocket",
    "created_at": "2016-04-29T15:42:25.546856192-04:00",
    "updated_at": "2016-04-29T15:42:25.546856192-04:00",
    "status": "Running",
    "status_code": 103,
    "resources": {
      "containers": [
        "/1.0/containers/csedev"
      ]
    },
    "metadata": {
      "fds": {
        "0": "1af02991b559306d3455a22430ced208154bf1e7b19903a810ed81e5d1e26ce6",
        "control": "0fba5aa1bfd8d509dff89ab4370383f03b6eb205ee6e52a8e74aabfe0fd7becd"
      }
    },
    "may_cancel": false,
    "err": ""
  },
  "operation": "/1.0/operations/dd3adfda-4935-4a42-a837-03b0a61d668f"
}

but I must have gotten something wrong because that didn't create the file and the status of the process is "Running"
curl -s --unix-socket /var/lib/lxd/unix.socket a/1.0/operations/dd3adfda-4935-4a42-a837-03b0a61d668f | jq .
{
  "type": "sync",
  "status": "Success",
  "status_code": 200,
  "metadata": {
    "id": "dd3adfda-4935-4a42-a837-03b0a61d668f",
    "class": "websocket",
    "created_at": "2016-04-29T15:42:25.546856192-04:00",
    "updated_at": "2016-04-29T15:42:25.546856192-04:00",
    "status": "Running",
    "status_code": 103,
    "resources": {
      "containers": [
        "/1.0/containers/csedev"
      ]
    },
    "metadata": {
      "fds": {
        "0": "1af02991b559306d3455a22430ced208154bf1e7b19903a810ed81e5d1e26ce6",
        "control": "0fba5aa1bfd8d509dff89ab4370383f03b6eb205ee6e52a8e74aabfe0fd7becd"
      }
    },
    "may_cancel": false,
    "err": ""
  }
}

I'm probably missing something basic here, but if you could point me in the right direction on how to achieve the command line functionality (including the output to the terminal), that would be great.

@CalebEverett do you have both wait-for-websocket set to false in your request?
If not, then the command itself will not be executed until after you've attached to the two returned websockets ("0" and "control" in what you pasted above).

I just tried that and queried the operation which returned not found, but the file still isn't there
curl -s --unix-socket /var/lib/lxd/unix.socket a/1.0/containers/$CONTAINER/exec -X POST -d '{"command":["/bin/bash touch newfile"],"environment":{"HOME":"/root","TERM":"xterm-256color","USER":"root"},"height":48,"interactive":false,"wait-for-websocket":false,"width":135}' | jq .
{
  "type": "async",
  "status": "Operation created",
  "status_code": 100,
  "metadata": {
    "id": "3b0df707-1397-460c-9422-7f8a7b7700dc",
    "class": "task",
    "created_at": "2016-04-29T16:24:58.165953918-04:00",
    "updated_at": "2016-04-29T16:24:58.165953918-04:00",
    "status": "Running",
    "status_code": 103,
    "resources": {
      "containers": [
        "/1.0/containers/csedev"
      ]
    },
    "metadata": null,
    "may_cancel": false,
    "err": ""
  },
  "operation": "/1.0/operations/3b0df707-1397-460c-9422-7f8a7b7700dc"
}

your command is invalid, try "command": ["touch", "newfile"]

stgraber@dakara:~$ curl -s --unix-socket /var/lib/lxd/unix.socket a/1.0/containers/zerotier/exec -X POST -d '{"command": ["touch", "/root/newfile"]}' | jq .
{
  "type": "async",
  "status": "Operation created",
  "status_code": 100,
  "metadata": {
    "id": "803ec931-4da3-4b7a-88e3-5c9dabd230c7",
    "class": "task",
    "created_at": "2016-04-29T16:32:45.969030794-04:00",
    "updated_at": "2016-04-29T16:32:45.969030794-04:00",
    "status": "Running",
    "status_code": 103,
    "resources": {
      "containers": [
        "/1.0/containers/zerotier"
      ]
    },
    "metadata": null,
    "may_cancel": false,
    "err": ""
  },
  "operation": "/1.0/operations/803ec931-4da3-4b7a-88e3-5c9dabd230c7"
}

stgraber@dakara:~$ lxc exec zerotier -- ls -lh /root/newfile
-rw-r--r-- 1 root root 0 Apr 29 20:32 /root/newfile
stgraber@dakara:~$

that did it, sorry about that, but thank you. I'll look into attaching to the websockets on my own. Thanks again.


Prevent high server and client (browser) load when showing diffs

Originally reported on Google Code with ID 349
What steps will reproduce the problem?
1. View a comparison of two refs ("compare" view) or view a commit comparison to the
parent commit ("commitdiff" view).
2. If a ref or the diff itself have modifications of lots of files and content (I can
already see problems with modifications of around 100 files) as a user you find your
browser stumbling (long loading time, high load an memory usage). On the server side
I also detected OOMEs one time.

What is the expected output? What do you see instead?
I surely want to see the diffs between all files regarded. But instead of loading all
files and diff contents at once it would probably be a good solution to first load
only part of files and contents. For example only first ten files and content. the
others should be expandable and therefore be loaded when manually triggered.

What version of the product are you using? On what operating system?
1.3.1; debian; on client side problems seen with chrome and firefox in different versions.

Me as a developer am of the opinion that one should not compare hundreds and more files
an their contents and complain that my tool is breaking. There are definitely limits
of ressource processing products. But in GitBlit and its very user friendly GUI I would
like to have the certainty that the server won't let himself be distracted by such
a request.

Maybe there has already been a change in v1.4?

Reported by stephan.krull.ecg on 2013-12-05 11:09:54

Covered by PR #226.


SignalR IHubContext via Middleware Suggestion

The example which shows how to get an IHubContext instance from the middleware pipeline doesn't show the required call to next.Invoke(). Using the documentation as is results in portions of aspnetcore silently failing.
The example currently shows:
app.Use(async (context, next) =>
{
    var hubContext = context.RequestServices
                            .GetRequiredService<IHubContext<MyHub>>();
    //...
});

Changing it to the following might save some other users a few hours of debugging:
app.Use(async (context, next) =>
{
    var hubContext = context.RequestServices
                            .GetRequiredService<IHubContext<MyHub>>();
    if (next != null) {
        await next.Invoke();
    }
});

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bf6fefc-557e-114a-a37c-90939e06b083
Version Independent ID: 92da23e0-6dc5-170e-b489-2ad8bbd46dff
Content: SignalR HubContext
Content Source: aspnetcore/signalr/hubcontext.md
Product: aspnet-core
Technology: aspnetcore-signalr
GitHub Login: @bradygaster
Microsoft Alias: bradyg

Good catch, @caseymarquis. Bringing in @BrennanConroy from our dev team here. Brennan - this looks like we may have cut the sample off too early. This look good to you? If so I'll either request @caseymarquis submit a pull request, or i'll do it. :)

:+1:

It should be constructor injected...

@davidfowl mmhmm. agreed and will alter the example with that in mind should I be the one to do the editing. (cloning the repo again now in preparation for this very thing)

Sounds like you're suggesting something like this?
var hostBuilder = Host.CreateDefaultBuilder();
var host = hostBuilder.ConfigureWebHostDefaults(webBuilder => {
    //Configure the webservice...
}).Build();

var hubContext = host.Services.GetService(typeof(IHubContext<THub, THubClient>));
//inject hubContext into other DI system

If so, I like that much better! Aside from not adding overhead to every request, it makes the host object the source of all web dependencies, and keeps pulling out web dependencies away from the nitty gritty configuration code.
Thanks guys! Let me know if there's a better way to do this, otherwise I'll watch for the change in the docs.

Oh wait this inline I just realized this was inline middleware carry on 😁

@caseymarquis based on @davidfowl's comment, i'd be open to you submitting a PR on the doc for us to review that reflects your ideas. If you've not submitted a PR to docs before I could help with the process if you need it. Or just tell us to do it and i'll jump on it. 👍

Hey, why not. I feel like this is a slippery slope that leads toward community contributions.
That said, having never done a github PR, is the procedure:

Fork?
Create a branch for changes?
Make purposeful commits?
Press some magic button which opens a PR form?

I'll see how far I get. I figure step four is the only mysterious part.

At the top right of the article, select the Edit pen icon:

Select the pen icon again. Save.


Quick fix for use_string_in_part_of_directives - switch library name to URI

https://dart-review.googlesource.com/c/sdk/+/305143


Can I use the version of Objective-C?

I have the same error as this problem.
https://github.com/flutter/flutter/issues/9694
https://github.com/flutter/flutter/issues/20045
https://github.com/apptreesoftware/flutter_google_map_view/issues/82#issuecomment-408303979

Hello @yy1300326388
Did you add use_frameworks! on your pod file of your app ? If you're under a framework, you can't use this plugin because of limitation on cocoa pods that doesn't get the transitive dependancies on nested frameworks.

@jaumard
If I add use_frameworks!, there will be other errors. And I saw that it could not be solved. I am not very familiar with iOS, if you can come to an Objective-C version, thank you very much.

Same here. Enabling use_framework! Breaks google maps and other things.
Objective C version would be really nice.
El 7 sep. 2018 03:32, "Sean"<EMAIL_ADDRESS>escribió:
@jaumard https://github.com/jaumard
If I add use_frameworks!, there will be other errors. And I saw that it
could not be solved. I am not very familiar with iOS, if you can come to an
Objective-C version, thank you very much.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kiwi-bop/flutter_crashlytics/issues/3#issuecomment-419337530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAc_2vL4kDqXhBN-dcO2vBfmWPazOKLiks5uYhMVgaJpZM4WcnH2
.

I'll not have the time to transpose the plugin in ObjC, but PR are welcome if you're sure it will fix your problem.

I have the same problem (build error on ios). Its sad cause its working so great on android.

I'm using this plugin with firebase_analytics google_sign_in and just try to add google_maps_flutter on my pub spec and I'm still able to build and launch the app... That's strange

Even with a new project with flutter_crashlytics as the only depencency, build still fails.
See build-output.
When switching to geolocator (also a swift plugin) the build succeeds.
pubspec.yml
name: ft
description: A new Flutter project.

version: 1.0.0+1

environment:
  sdk: ">=2.0.0-dev.68.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  flutter_crashlytics: ^0.0.6
  # geolocator: ^2.0.1

Podfile
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

def parse_KV_file(file, separator='=')
  file_abs_path = File.expand_path(file)
  if !File.exists? file_abs_path
    return [];
  end
  pods_ary = []
  skip_line_start_symbols = ["#", "/"]
  File.foreach(file_abs_path) { |line|
      next if skip_line_start_symbols.any? { |symbol| line =~ /^\s*#{symbol}/ }
      plugin = line.split(pattern=separator)
      if plugin.length == 2
        podname = plugin[0].strip()
        path = plugin[1].strip()
        podpath = File.expand_path("#{path}", file_abs_path)
        pods_ary.push({:name => podname, :path => podpath});
      else
        puts "Invalid plugin specification: #{line}"
      end
  }
  return pods_ary
end

target 'Runner' do
  use_frameworks!

  # Prepare symlinks folder. We use symlinks to avoid having Podfile.lock
  # referring to absolute paths on developers' machines.
  system('rm -rf .symlinks')
  system('mkdir -p .symlinks/plugins')

  # Flutter Pods
  generated_xcode_build_settings = parse_KV_file('./Flutter/Generated.xcconfig')
  if generated_xcode_build_settings.empty?
    puts "Generated.xcconfig must exist. If you're running pod install manually, make sure flutter packages get is executed first."
  end
  generated_xcode_build_settings.map { |p|
    if p[:name] == 'FLUTTER_FRAMEWORK_DIR'
      symlink = File.join('.symlinks', 'flutter')
      File.symlink(File.dirname(p[:path]), symlink)
      pod 'Flutter', :path => File.join(symlink, File.basename(p[:path]))
    end
  }

  # Plugin Pods
  plugin_pods = parse_KV_file('../.flutter-plugins')
  plugin_pods.map { |p|
    symlink = File.join('.symlinks', 'plugins', p[:name])
    File.symlink(p[:path], symlink)
    pod p[:name], :path => File.join(symlink, 'ios')
  }
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
      config.build_settings['SWIFT_VERSION'] = '4.2' # 3.0, 4.0, 4.2
    end
  end
end

because you miss use_frameworks! on PodFile, the use_frameworks! is mandatory for this library to works because of bundle static libraries.

@bjon
I just encountered this problem last week, I spent 2 days to solve it, I am a new iOS, this problem appears in the Object-C and Swift plug-in hybrid project, just need to create a new in the Runner directory of the Xcode project Just a Swift file.

CMD+N

Or create a project with Swift support from the start. Adding a swift file on existing project enable the swift support that's why it's working. But use_framework! still need to be added :)
I'm closing this issue as it works as expected on project with Swift enabled. If an objective C version is really needed PR are welcome :)

because you miss use_frameworks! on PodFile, the use_frameworks! is mandatory for this library to works because of bundle static libraries.

Its in the Podfile
target 'Runner' do
  use_frameworks!

Do you mean it has to be in the top of the file?

I put it at the top of the file personally

@bjon
I just encountered this problem last week, I spent 2 days to solve it, I am a new iOS, this problem appears in the Object-C and Swift plug-in hybrid project, just need to create a new in the Runner directory of the Xcode project Just a Swift file.

CMD+N

Now it works! Thanks alot!!


question

I have some things I wanted to ask if you could add and some other questions related to the miner (I will pay), do you have a discord or telegram I can contact you on more easily?

You can add me on Discord: Unam Sanctam#3135

cool, added


nuxt3.7.1 $fetch has no result on some browsers

Environment
QQ Browser - <IP_ADDRESS>47
UC Browser
Reproduction
https://github.com/xjccc/useAsyncData-example
Describe the bug
on QQ Browser and UC Browser has no result
on safari chrome quark firefox works fine
to add this QQ and UC works fine
"pnpm": {
  "overrides": {
    "ofetch": "1.2.1"
  }
}

is this has something affect in v1.3.3?
Additional context
its the right

on QQ and UC

Logs
No response

Please reopen this issue in nuxt repo to track. i guess issue is not related to ofetch core.

Reopening, but please do close if you think this is not something we should track here @pi0.
The result of user testing is that this is reproducible without Nuxt: https://github.com/nuxt/nuxt/issues/23972#issuecomment-1782435349.
However, my instinct tells me this is likely a matter of browser support rather than a bug per se, so we might decide to close this in any event. What do you think?

Yeah, it seems browser issue so same as nuxt if there is no way to reproduce cross platform, i think we shall close this too unless there is a minimal ofetch reproduction (that weoks well with native fetch)

I have cloned this and running latest with latest ofetch (1.3.3) in chrome 118, seems to work fine: (as well as in safari)

@xjccc i don't trust QQ browser to download and test it but it is likely an issue with your browser. Can you please also try on latest chrome and confirm if this also fails in chrome too?
1.3.0/1.3.1/1.3.2/1.3.3 changelogs, i also don't see any suspicious changes btw.

In my mobile browsers, has the problem, not in the computer.
i will try other version in my phone

i have some record and its show some different
v1.2.1 works well
https://github.com/unjs/ofetch/assets/16478776/ad06f38d-0f37-4843-b93d-970dc004d270
> v1.3.0
https://github.com/unjs/ofetch/assets/16478776/4456758a-9474-4246-89fa-69524845569a
QQ\UC\SouGou browsers return [Object Blob]
is the browsers supports something lower?

I have the same problem
<EMAIL_ADDRESS>is normal
<EMAIL_ADDRESS>no result in useFetch

https://github.com/unjs/ofetch/compare/v1.2.1...v1.3.0#diff-39f1e030815f30ed52f7f86a69761ef60e22bbfd1521ac8d065e6d86a4bc8337R38
Make sure to transform "node_modules/ofetch" into ES5 because of the for..of.

v1.2.1...v1.3.0#diff-39f1e030815f30ed52f7f86a69761ef60e22bbfd1521ac8d065e6d86a4bc8337R38
Make sure to transform "node_modules/ofetch" into ES5 because of the for..of.

I try to change for of as before, but it's not usefull

If someone doesn't have high stability requirements, they can use this module → markthree/nuxt-fix-ofetch

now..
QQ version: <IP_ADDRESS>25
UC version: <IP_ADDRESS>1
works fine


Use CT_MARK by bit rather than entire mark

Signed-off-by: Hongliang Liu<EMAIL_ADDRESS>

Codecov Report

Merging #2800 (66286ed) into main (e32664e) will decrease coverage by 20.18%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #2800       +/-   ##
===========================================
- Coverage   61.26%   41.08%   -20.19%
===========================================
  Files         284      157      -127
  Lines       23562    19562     -4000
===========================================
- Hits        14436     8037     -6399
- Misses       7564    10762     +3198
+ Partials     1562      763      -799

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.08% <0.00%> (+0.21%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ovs/openflow/ofctrl_builder.go
18.18% <0.00%> (-41.46%)
:arrow_down:

pkg/ovs/openflow/ofctrl_flow.go
36.36% <0.00%> (-3.64%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-83.88%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-80.00%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

... and 231 more

/test-all

Code LGTM, but the title is incorrect. ct_mark is not register. "Use CT_MARK by bit rather than entire mark"

@tnqn Thanks for reviewing, the title is corrected.

/test-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e
/test-windows-e2e
/test-flexible-ipam-e2e

/test-all

I meant commit title too, which is more important as it will be in the git history. But anyway I can update it when merging. Please update both PR title and commit title in future PRs.

I meant commit title too, which is more important as it will be in the git history. But anyway I can update it when merging. Please update both PR title and commit title in future PRs.

Thanks, I'll update it.

/test-all

/test-all-features-conformance
/test-conformance
/test-e2e
/test-flexible-ipam-e2e
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy
/test-multicluster-e2e
/test-networkpolicy
/test-windows-conformance
/test-windows-e2e to trigger.
/test-windows-networkpolicy
/test-windows-proxyall-e2e

/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy

Thanks for reviewing and merging this PR. @tnqn @wenyingd


[SPARK-16124][SQL] fix getHiveFile return file url in jar that cannot be load in SQL

What changes were proposed in this pull request?
I create a temp file from output stream of the file in jar and return that file
How was this patch tested?
manual tests

Can one of the admins verify this patch?

Thanks for working on it. This does not sound an issue to Spark SQL users. Cloud we close this PR now?

+1 for closing.


migrate Mock contracts with devel flag

Issue Type
[ ] bug report
[ x] feature request

Current Behavior
Currently npx truffle migrate only deploys essential (root chain) contracts.
Expected Behavior
Because contracts are also used in development, we would like to have access to contracts in
./plasma_framework/contracts/mocks/, specifically plasma-contracts/plasma_framework/contracts/mocks/transactions/eip712Libs/PaymentEip712LibMock.sol.
Steps to Reproduce
Suggested Fix
npx truffle migrate --network remote command should accept a --devel flag that deploys mock contract above as well, and expose them in outputs.json so that they're able to be served ...
Motivation for Change
Support development on elixir-omg side (this allows us to delete some of the helper code that used to do the deployment)

The currently identified contracts we would need are PaymentEip712LibMock and ERC20Mintable (openzeppelin_solidity)

slight suggestion to avoid using the word "mock" in this context (and rename the contracts that fall into this category). Would proxy work for the PaymentEip712Lib... thing? I think currently this is the only contract that does, but not sure.

I don't have an opinion on this. As long as it's evident it's not what we're shipping to production...
As per discussion on Slack,  git SHA1 of length 7 should be stored in the contracts so relevant parties are able to retrieve that (similarly to how we retrieve MIN_EXIT_PERIOD)


guestbook v2

we already have this https://github.com/IBM/guestbook/blob/master/v2/guestbook-deployment.yaml

@szihai can we close this?

In istio101 there is a plan dir


consumer: shut down on OffsetOutOfRange

The old behaviour was to redispatch it (so it would go to another broker if
necessary) and then retry with the same offset, which was a rather useless thing
to do unless the offset had somehow ended up slightly ahead of the available
messages (which is unlikely - it is far more likely to fall behind).
Instead, simply shut down the PartitionConsumer so the user gets an error (if
they're subscribed) and their messages channel closes. They then get to choose
whether to give up and switch to a different offset, yell for a human, or
whatever.
@Shopify/kafka make sense?

@wvanbergen I'm particularly curious what this behavioural change will do to the consumergroup code you're maintaining. I imagine you must already be detecting/handling this case from the Errors() channel and shutting down on it may cause problems?

In general :+1: from me.

How can the user detect that the consumer has stopped, or is going to stop, besides from knowing that this particular error is handled that way?
There's a theoretical case where this error will eventually go away: when the offset you're requesting is too high. This can only happen during the initial Fetch request, and should be resolved by #378
I think the godoc will need updating, because somewhere we say that the consumer never closes.

W.r.t. the consumergroup library: I don't think this is handled at all right now, so this will not make it any worse :)

How can the user detect that the consumer has stopped

Their message channel closes and they'll get an error if Return.Errors is true. I'm not sure what you mean?

I think the godoc will need updating, because somewhere we say that the consumer never closes.

Good catch, done.


Hotspot report -> which packages need refactoring/have the most code smells

how many smells lead to a hotspot?
how many hotspot to show in the report? just one, the biggest?

FileBasedFindingsReport does in my opinion work exactly like that.
Is that what you had in mind when creating this issue?

I'm not sure anymore actually.
As of now, I think hotspot analysis needs repository mining.
FileBasedFindingsReport + #modifications -> refactoring opportunities


Turn environment variables into config file

The procfile now triggers a conf file build prior to running the app.

:D :D :D :D

:D :D :D :D


Word taskpane add-in loaded but scripts don't run

I created my Word add-in using Yeoman generator and VS Code. The add-in works well on my local computer. Then I published the add-in to an Azure app service.
Now I need to load the add-in on a different computer. So on that computer, I set up a network share, put the manifest.xml in, update the resource URLs in the manifest.xml to use the app service URL, configure the network share as a trusted add-in catalog in Word.
When Word on that computer starts, the add-in loaded successfully. However, all the functionalities are missing, like buttons don't work. As I narrow down the issue, I found even Office.onReady() doesn't run. I installed Node.js on the computer, restarted the computer, and problem persistsed. Can anyone help?

Thanks for your interest in Office add-ins and sorry to find that you're having a difficulty. We use the issues of this repo to track problems with the documentation. For a technical problem like this, we recommend that you raise it on Stack Overflow and tag the question office-js.


fix calico_version wrong get

the ':' makes wrong return of calico_version after the calicoctl downloaded && before the cluster is up
fixes #3238 , @Atoms

check CLA

/lgtm
/approve

ci check this


Target for .NET Standard Library

I'd love to get a version of Bot Builder that targets the .NET Standard Library.
I've forked and started some work to bring over as much functionality as possible.

Related discussion on https://github.com/Microsoft/BotBuilder/issues/904.

Having read through #572 and put some effort into digging through the project I think this work is a bit out of scope for me right now so I'm closing it.


Problem running NuGetPackageExplorer on Chocolatey Test Environment

Following a conversation with Oren on Twitter:
https://twitter.com/onovotny/status/1056553141573951490
I took the latest Chocolatey Package for NuGet Package Explorer for a spin on the Chocolatey Test Environment.  While the installation went fine, running the application resulted in the following:

The Stack Trace in Event Viewer shows the following:

As a test, I went ahead and installed the .Net Framework 4.7.2, just to make sure that it wasn't a runtime issue (choco install dotnet4.7.2), however, that still resulted in the same.
However, doing choco install vcredist140) made the application work:

Looks like the self contained publish is missing something to make it work in all scenarios.

@gep13 Can you please test https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=1402&view=results
I added the vcredist140 as a temporary workaround.

@onovotny said...
What do you mean by this?

Last time we spoke about this, you mentioned that you thought there was something "missing" in the generated standalone package.  I was wondering if you had been following up with the relevant Microsoft Team (via GitHub issues) to try to narrow down what is wrong, or whether a dependency on vcredist is "working as expected".

It's being looked at separately. I put this workaround in since I want to make this the default in master and published once .NET Core 3 preview 1 hits.
I'll close this out for now, but I'll add another issue to track removing the dependency.


Added picker and field tokens

Description
New Picker specific token:

picker-end-edge-to-disclosure-icon-quiet

New layout tokens:

field-top-to-disclosure-icon-75
field-top-to-disclosure-icon-100
field-top-to-disclosure-icon-200
field-top-to-disclosure-icon-300
field-end-edge-to-disclosure-icon-75
field-end-edge-to-disclosure-icon-100
field-end-edge-to-disclosure-icon-200
field-end-edge-to-disclosure-icon-300

Related Issue
DNA-1273
Motivation and Context
Frank has identified an area that needed some adjustments – the spacing around the disclosure icon inside the Picker. The summary is that the field-end-edge-to-disclosure-icon-size token can't be applied to the edge spacing in the quiet Picker like the non-quiet version. So instead, we'll define the top/bottom differently than the end edge.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

:tada: This PR is included in version 12.2.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

Tokens added (9):

field-end-edge-to-disclosure-icon-100
field-end-edge-to-disclosure-icon-200
field-end-edge-to-disclosure-icon-300
field-end-edge-to-disclosure-icon-75
field-top-to-disclosure-icon-100
field-top-to-disclosure-icon-200
field-top-to-disclosure-icon-300
field-top-to-disclosure-icon-75
picker-end-edge-to-disclousure-icon-quiet


Add webhook support for models created and used within plugins

Proposed Functionality
Trigger webhooks for models that are created and used within plugins (non-core models).
Use Case
As a developer, if I create a model to store network ACLs or VXLAN, I need the ability to trigger webhooks on CRUD operations of those models.
Database Changes
None.
External Dependencies
None.

"If you decorate a plugin model with extras_features("webhooks") does it behave as expected?"
"What happens when the plugin is uninstalled?"


codegen/string_escapes_test doesn't work with CFE

The dart2js unittest codegen/string_escapes_test doesn't work with CFE.

Not sure if dart2js or front-end issue. Why not both?

Good call - we need to coordinate the solution.

One of the errors is a source string containing \u2080\u2029. This shows up in the generated code as (), which is U+0028 U+0029.
So it seems that the code units are being truncated to the low byte somewhere, perhaps by storing code units into a Uint8List.
If the input is changed to \u2028\u2029\u20c1 then the output becomes ()\ufffd. This indicates that the low 8 bits are being interpreted as UTF-8, with 0xc1 being mapped to the error replacement character U+FFFD.

If you look in source_file_helper, requesting a binary file for something supplied as a string to the memory source files does:
case InputKind.binary:
        if (source is String) {
          utf8SourceFiles[resourceUri] =
              new StringSourceFile.fromUri(resourceUri, source);
          source = source.codeUnits;
        }
        input =
            binarySourceFiles[resourceUri] = new Binary(resourceUri, source);
        break;

If the string is not Latin-1, this puts 16-bit integers into the Binary input. I'm guessing it's being truncated when read from that.


first design stab at API refactor

this splits up the way to interact with endpoints into a simple and an
advanced usage way. The simple way mostly corresponds to the old API. The new
way is via a connection object that can be configured with different
properties.
related to #27, #31, #33

@mheffner if you have any feedback on the API design, I'd super appreciate it :)

Hmm maybe the underlying semantics are better conveyed with an API like
conn = new Connection("http://example.com")
conn->get("/resource")

ok this should be the first draft implementation of the new API. I punted on the request builder functionality as I think repeating something like conn->get("/foo") is easy enough and the builder would make it more confusing. Gonna let this sit here for a bit and then merge it to master.


fix(package.json): set 'publishConfig.access' to 'public'

This PR sets publishConfig.access to public in the package.json file to prevent the following NPM error that occurs when semantic-release attempts to publish to the package registry:

npm error 402 Payment Required - You must sign up for private packages.

:tada: This PR is included in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add MiddleboxCompat option to SSL_CONF_cmd man page

Checklist

[x] documentation is added or updated
[ ] tests are added or updated

Follow on from #5237

So I have this feeling of deja-vu reading this and the other manpage :)  Maybe we should make this one just cross-ref to the SSL options page for most of the description?  I know, separate PR but I  wonder what you think (and more importantly, if I can goad you to doing it:)

So I have this feeling of deja-vu reading this and the other manpage :) Maybe we should make this one just cross-ref to the SSL options page for most of the description?

Maybe.

I know, separate PR but I wonder what you think (and more importantly, if I can goad you to doing it:)

I don't feel strongly about it either way.
Anyway - thanks for the review. Pushed.


Fix PMD file locking issue

Ignore select tests on older versions of PMD since PMD fails to close files it was analyzing
(Mostly) Passing build (Except for the OOM-related errors):
https://builds.gradle.org/buildConfiguration/Gradle_Master_Check_AllVersionsIntegMultiVersion_34_bucket9/55103783?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true
Previously failing build:
https://builds.gradle.org/viewType.html?buildTypeId=Gradle_Master_Check_AllVersionsIntegMultiVersion_34_bucket9&tab=buildTypeHistoryList&branch_Gradle_Master_Check_AllVersionsIntegMultiVersion_34=<default>

@bog-gradle test RFN

@bot-gradle test RFN

OK, I've already triggered the following builds for you:

ReadyForNightly build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Pass decorators to anonymous struct generators

Closes #149.

Hi @czocher, it looks like the core underlying change from this PR was actually already added in #170, so I believe this should be working with the next release!


Increased json schema support

Edit:
Implement a json schema metadata object to assign to parameters of glz::object.
Concerns:

Default value of objects or arrays, it would be nice if glz::write_json could be used but I think it is too much of an effort and or not possible. So users will need to write the json as string_view for those variables.

Nice to haves:

With the new glz::merge it would be nice to implement the glz::meta<glz::schema> as object for its variables and within schema_ref do something like glz::object("$ref", &T::ref, glz::merge<glz::schema>(&T::attributes)); But I am not sure this is any better than the current implementation

Original description:
This pull request is not complete and I would like to get feedback from you before continuing. I will begin with describing the problem:
We are using glaze to publish json schema to frontend such as https://github.com/ui-schema/ui-schema/ to make configuration UI based on json for the backend. By doing so we need to be able to specify more metadata than the comment/description string_view is.
This pull request suggests a way to inject a metadata struct into the glz::Object by declaring a constexpr value within the struct to get passed the filter of make_group construction.
Please share your thoughts on this.
Reference: https://www.learnjsonschema.com/

I really like this and I think this is the proper place to pass in schema parameters, replacing the comment.
I do think glz::schema::property_attributes class should be named more succinctly, because it is user facing.
I would prefer to just remove the schema namespace and turn glz::schema::property_attributes into glz::schema.
This would change: glz::schema::property_attributes{.minimum = 2} to glz::schema{.minimum = 2}
Also, I would rather not have member names that begin with an underscore, as these are best reserved for user defined literals. Instead change _const to something like const_ or constant.

I do want to make functions like glz::write_json constexpr someday. However, we need better support for constexpr std::string and std::vector before it really makes sense. And, static constexpr in functions via C++23 will also be immensely helpful for cleaner code. So, for now we need to wait until these features are more broadly implemented.

I'm planning to look into this in more detail soon. I'll probably improve merge first to see if it is useful here.

@jbbjarnason
I solved the merge problem by just making schema hold ref.
I pushed some other minor cleanup.
Let me know if you have any concerns. I'll probably merge soon.

Looks good 👍

I've enabled using constexpr std::vector if supported by the compiler


chore: Move pino-pretty to devDependencies

Description
This PR moves pino-pretty to devDependencies and changes the defaultLoggerOptions to only use pino-pretty when NODE_ENV is not production.
Prettifying logs is not ideal for production since it adds overhead while not being as useful as it is in development. Even the pino-pretty docs recommend against using it in production. This changes the default to a more sensible one while still giving flexibility for users to use pino-pretty in production if they wish to do so.
Removing pino-pretty from dependencies also allow multi-stage builds or anything that uses npm install --production to strip out pino-pretty from the final node_modules therefore reducing size which could help in some deployment targets like serverless which have certain limitations in terms of the final bundle.
Please see this discussion for a more in-depth explanation.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Chore (non-breaking change which does not add functionality)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Hey @mplibunao, thanks for the PR!
I completely understand where you're coming from on this one. However, having everyone's production logging all of a sudden start logging in JSON would be completely unexpected.
Any users concerned about using pino-pretty in production can easily override the logging configuration, which I think is an acceptable compromise for now.


cmd.Env de-dup's differently as of Go 1.9

I tried running gorepoman fetch ... after updating to Go 1.9, and it failed.
It fails because the go get command it uses internally has the wrong environment, due to a change in the os/exec package. This fixes it.

nice


minecraft-server: build against jre_headless

Motivation for this change
minecraft-server, as its name implies, is a server, and therefore isn't run with a GUI. Therefore, we can use jre_headless and avoid installing GTK.
(Actually, that's not quite true: the minecraft server does have an optional GUI, which is little more than a window with stdin/stdout and some CPU/memory stats. However, our wrapper script turns off the GUI with nogui anyway, so I don't think it matters.)
Tested by running the NixOS minecraft-server service and successfully connecting to the game.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Oh. Oops, I left nixfmt on. Might as well keep it, I guess.


Update Resume.md

👷 Deploy Preview for fancy-puffpuff-df775f processing.

Name
Link

🔨 Latest commit
cac80e0da98d04170a51ca997f4ef6963a1a3b77

🔍 Latest deploy log
https://app.netlify.com/sites/fancy-puffpuff-df775f/deploys/6685a1b5cc820a00089ccc34


Fix guild id issue

The question is wy should it be anything if its not in a guild? If it is in a Privat Xhannel, then there is no guild_id so wy should it be 0 instead of None?

The question is wy should it be anything if its not in a guild? If it is in a Privat Xhannel, then there is no guild_id so wy should it be 0 instead of None?

basically you are using int function on output and passing None as Default. that break the application in private channel interaction.


Question about push and pull of each layer.

In the backward process, as long as layer n generates the gradient, it can be immediately pushed. Once the update of the layer n is complete, it can be pulled, regardless of whether the push and pull of layer n-1, n-2...have completed.
I wonder if the statement above is correct.

@wanderingpj thank you for your question, @sandeep-krishnamurthy requesting this to labeled under questions.

@wanderingpj can you expand a bit on your use-case? Without testing it myself I would say your assumption is correct.
@sandeep-krishnamurthy can you add [Pending Requester Info] tag?

@yzhliu can we please close this issue due to lack of reply from author, thanks.
@wanderingpj is you're still interested in this, please follow up and we can reopen.