Add deployment script for Timelock governance

Code Change Checklist
To be completed before internal review begins:

[ ]  The contract code is complete
[ ]  Executable deployment file
[ ]  Fork tests that test after the deployment file runs
[ ]  Unit tests *if needed
[ ]  The owner has done a full checklist review of the code + tests

Internal review:

[ ] Two approvals by internal reviewers

Deploy checklist
Two reviewers complete the following checklist:
- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

LGTM

[X] No contracts deployed
[x] Governance proposal matches the deploy script
[x] Smoke tests pass after fork test execution of the governance proposal


Adding Documentation for Introduction

Preview: https://github.com/Jij-Inc/JijModeling-Tutorials/blob/337d52b620378ad57af53c28d7d12286fe2d0595/docs/releases/jijmodeling-1.9.0.ipynb


[TACHYON-1582] Restructure POM: move servers/client/common into core

https://tachyon.atlassian.net/browse/TACHYON-1582
This is the followup PR to achieve what proposed in https://tachyon.atlassian.net/secure/attachment/14000/POMstructurechangeproposal.pdf
NOTE that, this PR has touched a large number of files and hitting the github limitation, but most of the files are simply renamed. There is a small amount of code change into POM files. If you want to see the whole change, please check out the branch.

An alternative way of reviewing this PR is to review it by commits, keeping in mind that the first commit simply move files. Most pom changes happen in https://github.com/apc999/tachyon/commit/815df11b0de3da6455716ae7476cd6af7601c3a0

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8238/Failed Tests: 3org.tachyonproject:tachyon-tests: 3tachyon.master.ServiceSocketBindIntegrationTest.listenSameAddressTesttachyon.master.ServiceSocketBindIntegrationTest.listenEmptyTesttachyon.master.ServiceSocketBindIntegrationTest.listenWildcardTest
Test FAILed.

I think we should rename tachyon-client-core and tachyon-client-keyvalue to tachyon-core-client and tachyon-keyvalue-client, and I left a comment about some comments, but otherwise LGTM. Thanks for this reorganization, I like the new structure much better!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8259/
Test PASSed.

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8261/
Test PASSed.

LGTM

@apc999 Left two comments.

@uronce-cc  your comments are addressed. Thanks!

LGTM ++

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8264/
Test FAILed.

Jenkins, test this please

Jenkins, test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8271/
Test PASSed.


NO SSL, slow driver execution

Hey! First of all wanna say thanks for this awesome framework looks like Selenide on Java!
My issue is that when i use my test_method(py) my test is actually super slow,  but my internet connection is good. I find one possible issue like i see no SSL cert while executing tests. Might be reason here im not sure.
My project is fully clear: install selenium, pytest and pylenium, nothing more. Used guidline pylenium getting started aswell.
There is no SSL cert any site, even on qap.dev while executing.

Pylenium comes with pytest and selenium already, so no need to install them
separately.
Could you post a snippet of your code along with the test duration? It
would also be helpful to see the speed you're looking for and how you're
checking for the SSL.
Basically, the more details you can share the better I can debug and solve
the problem.
Thank you!
On Wed, Nov 2, 2022, 1:40 AM vrapsa @.***> wrote:

Hey! First of all wanna say thanks for this awesome framework looks like
Selenide on Java!
My issue is that when i use my test_method(py) my test is actually super
slow, but my internet connection is good. I find one possible issue like i
see no SSL cert while executing tests. Might be reason here im not sure.
My project is fully clear: install selenium, pytest and pylenium, nothing
more. Used guidline pylenium getting started aswell.
There is no SSL cert any site, even on qap.dev while executing.
—
Reply to this email directly, view it on GitHub
https://github.com/ElSnoMan/pyleniumio/issues/294, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFQDCPKOI6GUET2JUPZVG4DWGILGRANCNFSM6AAAAAARUY7XYE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

def test_try(py):
py.visit("https://www.dns-shop.ru/")
py.getx("//a[@class='ui-link menu-desktop__root-title' and text()='Компьютеры']").click()
17 seconds to pass the test with Pylenium, but if i go to my chrome locally to check loading speed its highly fast with SSL.

I've run into this now as well, running it, and the screen is full of the certificate issues.  Has Seleniumwire changed what they do, or is this something else?

I'm also experiencing slowness. I'll take a look and see if it's SeleniumWire. If so, which it seems to be, then I'll add a flag to use Selenium or SeleniumWire

https://github.com/ElSnoMan/pyleniumio/releases/tag/v1.18.0


Opening emote menu crashes.

To Reproduce
Steps to reproduce the behavior:

Click the emote menu.
Either wait / click the BTTV Icon.
Crash

Error
Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at uc (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:797855)
    at hs (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:811096)
    at t.unstable_runWithPriority (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:831852)
    at Uo (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:755980)
    at ps (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:808954)
    at Jc (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:805085)
    at https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:756271
    at t.unstable_runWithPriority (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:831852)
    at Uo (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:755980)
    at qo (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:756216)
    at Ko (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:756151)
    at N (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:825818)
    at V (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:713013)
    at Zt (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:734599)
    at Qt (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:733816)
    at t.unstable_runWithPriority (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:831852)
    at Xt (https://yata.now.sh/static/js/2.4342c5d4.chunk.js:2:733686)

Environment

Software
Version

YaTA
1.14.0

Browser
Chrome 84.0.4147.89

Operating System
Windows NT 10.0

Hi, thanks for the report.
Does this happen on all channels or only a specific one? If only one, would it be possible to share the channel as I tested in a few channels using Bttv but didn't manage to repro.

It happened in my channel, mmattbtw

Hmmm, interesting, even in your channel I cannot repro. I'll investigate and try to find a repro based on the error you provided 👍

Works fine now, I believe the problem is the "Global Twitch Emotes" extension.
Yep that's the problem, if you have this extension installed, https://chrome.google.com/webstore/detail/global-twitch-emotes/pgniedifoejifjkndekolimjeclnokkb?hl=en, the emote menu crashes.
issue closed.

Thanks for the investigations and follow-up. From a quick read of the description of the extension, I can see why this could lead to this error if they modify some DOM nodes to do some replacements, which the app do not expect.
I'll still check when I have some free time if I can somehow prevent this.


Share button should also be controlled via roles

Is your feature request related to a problem? Please describe.
Share button such as dashboard or share chart should be optional
Describe the solution you'd like
A role for showing the share button would be sufficient
Describe alternatives you've considered
Adding CSS class specific for share button so custom CSS could be written to remove the element if not required
Additional context
We made a dashboard and want to share it externally. Problem is that there is a share button in charts as well which is not required and there is no way of removing it

some efforts have been made towards this goal.
[SIP-51] Dashboard Level Access
https://github.com/apache/superset/pull/13108
cc @amitmiran137

All other option on chart menu(explore /export and etc') are controlled via a permission that been been given to a role.
I think that share chart should also behave the same in the form of ' share chart permission that can be linked to any role.
Wdyt?

@saurabnigam if you'll create a PR with the new permission for share chart I'll support you


Issue #473: Upgrade Spark to 3.5.2 [v0.7.1]

Description
Upgrade Minor Version of Spark to 3.5.2 for 0.7.1 version.
Type of change
Upgrade.
Checklist:
Here is the list of things you should do before submitting this pull request:

[x] Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)
Tested locally.

I would cherry pick the commit instead. Sorry for the inconvenience!


[cherry-pick] vendor: Ensure service images get default tag and print familiar strings

Cherry picking https://github.com/moby/moby/pull/33279 into components/cli/vendor/github.com/docker/docker.
This is related to the changes in https://github.com/docker/docker-ce/pull/13
cc @andrewhsu @mlaventure @thaJeztah

This should be done against the 17.06 branch.


sale_amount is missing in the admin theme

It came up in a discord discussion that a property of sale_amount exists on a product/variant which can be used to have a sale price.
Seems that property is missing in the admin theme.
Relevant discord link: https://discord.com/channels/876835651130097704/877195433649258536/969675223274225664

@chemicalkosek sale_amount has been removed in the latest version of Medusa. Going forward, you will define sales using the new PriceList entity: https://github.com/medusajs/medusa/blob/master/packages/medusa/src/models/price-list.ts. We are working on adding a new Prices section to the admin where you will manage this from, which will be released soon 😄


Refactor the "Theme properties applied correctly" integration test

There should be a Unit test that tests the logic of themeClassName().
There should be an Integration test that asserts that the theme property works as expected (but should not  test all possible permutations).
The setting of the theme property value in the Integration test should be done via the use of the exported Enum value from the component and not a literal string value as currently is.

Once started working on this issue realized 3rd bullet is not necessary so used test value instead.


CSRF tests

COUCHDB-2762

There are some missing tests and we need to be able to clear cookies between tests (and at the end!) so this can't be merged yet.

CSRF cookie cleared at the end, we can add more tests as we go. would like to merge.

+1


sendRedirect() in /server/middleware causing error: [nuxt] [request error] [unhandled] [500] Cannot set headers after they are sent to the client

Environment

Operating System: Darwin
Node Version:     v16.14.2
Nuxt Version:     3.7.3
CLI Version:      3.8.4
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      modules, typescript, app, css, vite, prismic, i18n, image, devtools, experimental
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-nduq6u?file=pages%2Findex.vue,pages%2F[[slug]]%2Findex.vue,server%2Fmiddleware%2Fredirects.ts
Using the reproduction link above:

visit /old-page

You get an error in the console.
Describe the bug
The console gives me an error when I go to /old-page (which redirects to /new-page).
The redirect seems to work, but I get the following error:
[nuxt] [request error] [unhandled] [500] Cannot set headers after they are sent to the client
  at __node_internal_captureLargerStackTrace (node:internal/errors:464:5)
  at new NodeError (node:internal/errors:371:5)
  at ServerResponse.setHeader (node:_http_outgoing:576:11)
  at setResponseHeaders (./node_modules/h3/dist/index.mjs:711:20)
  at null.<anonymous> (./node_modules/nitropack/dist/runtime/renderer.mjs:31:7)
  at processTicksAndRejections (node:internal/process/task_queues:96:5)
  at async Object.handler (./node_modules/h3/dist/index.mjs:1630:19)
  at async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:1840:7)

Additional context
The file that is causing the error is /server/middleware/redirects.ts and the code looks like this:
export default defineEventHandler((event) => {
  const urlObj = getRequestURL(event)

  if (urlObj.pathname === '/old-page') {
    sendRedirect(event, '/new-page')
  }
})

Logs
No response

sendRedirect returns a promise and should be awaited

sendRedirect returns a promise and should be awaited

To keep this issue as helpful as possible. I was coming from @hecktarzuli's blog about Nuxt redirects (thanks 👏).
https://deltener.com/blog/creating-redirects-with-nuxt/
By adding async/await everything starts working as expected:
export default defineEventHandler(async (event) => {
  const urlObj = getRequestURL(event)

  if (urlObj.pathname.includes('/__nuxt_error') || urlObj.pathname.includes('/__nuxt_island')) {
    return
  }

  if (urlObj.pathname === '/old-page') {
    await sendRedirect(event, '/new-page')
  }
})

Interesting, that's not what's in the doc examples.  And I tested this code myself.  I wonder if something changed.

Weird, I know I tested this code as I wrote it.  Out of tens of thousands of people that have viewed that post, nobody has ever mentioned they had problems.  I'll update it thanks!

Post: Updated! Also, I've submitted a pull to update the Nuxt example too. https://github.com/nuxt/nuxt/pull/23345/files

Perfect, good catch with the docs!

I got the same problem, and i had tried await, but still no work

I got the same problem, and i had tried await, but still no work

Did you add both keywords (async and await)?

I got the same problem, and i had tried await, but still no work

Did you add both keywords (async and await)?
Certainly i did. The only difference is: i do this in plugins.

The code above only happen in server side.

For future people ending up here with this problem, if you add async/await and the problem remains, make sure every function in between is also awaited, like here:
export default defineEventHandler(async (event) => {
  const shouldAuth = !event.path.startsWith('/api/auth')
  if (shouldAuth) {
    const sessionCookie = $getCookie(event, consts.authSessionCookieName)
    await sessionCookie.match({ // If you forget to await functions in the body like this, it'll error
      some: (val) => {
        event.context.auth = {
          sessionToken: val,
        }
      },
      none: async () => { // async here
        await sendRedirect(event, '/auth/signin', 401) // awaiting only here is not enough
      },
    })
  }
})


InfluxDB user authorization permissions does not work as expected

Steps to reproduce:

Create new user with no permissions:

CREATE USER "mynewuser" WITH PASSWORD 'mynewpassword'

Grant specific permissions for the created user:

GRANT READ ON "telegraf" TO "mynewuser"
GRANT READ ON "database1" TO "mynewuser"
GRANT READ ON "database2" TO "mynewuser"

Double check the created user's authorization permissions:

> SHOW USERS
user            admin
----            -----
...
mynewuser     false
> SHOW GRANTS FOR mynewuser
database     privilege
--------     ---------
telegraf     READ
database1    READ
database2    READ

User is able to SELECT data from other databases, where no grants were given. User is also able to see other databases measurements and other databases.

Expected behavior:
User must not be able to SELECT data from databases where no permission was granted. Also user must not be able to see other databases where no permission is granted.
Actual behavior:
User is able to SELECT data from databases where no permission was granted. Also user can see other databases where no permission is granted.
Environment info:

System info: Linux 4.9.0-11-amd64 x86_64 (Debian 9)
InfluxDB version: InfluxDB v1.7.9 (git: 1.7 23bc63d43a8dc05f53afa46e3526ebb5578f3d88)

With latest version this issue is no longer present.


flutter_country_picker does not specify a Swift version

flutter_country_picker does not specify a Swift version and none of the targets (Runner) integrating it have the SWIFT_VERSION attribute set. Please
contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.
Error when i run pod install on my flutter project. Flutter 1.7.8+hotfix.4 CocoaPods : 1.6.1

Same for me Alessandro.
Otherwise this package works like a charm and cannot be without it.

The same problem happened to me. I followed those steps to solve it.

Following the instructions from @AhmedAlYousif link helps to solve the issue. I'll update usage guide to point that.


Thapar University added

College added- Thapar Institute of Engineering & Technology (TIET), Patiala

Commit
College Website
Course page
Email page

bc714a8215003603018117a03de5306f18e8f221
https://www.thapar.edu/
https://www.thapar.edu/academics
https://www.thapar.edu/pages/contactus

Signed-off-by- swastik<EMAIL_ADDRESS>

@swastkk First stage of verification passed, official domain is thapar.edu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@swastkk Pull request merged. Thank you.


Proportions are off..

Im a little weirded out at how for some reason im only 1 block tall - expecially because Im not <1 meter tall IRL and 1block == 1meter. so the proportions are way off, making everything look way larger than they should be.
Now im not sure if its a result of minecraft or openxr-monado, and considering that unlike steamVR theres no option that I can find to calibrate floor level in openXR-monado's config (or lack thereof),  i'm even more unsure.
Is there any way we can fix this, maybe add some options for adjusting head height while standing?
System specs
Arch Linux
kernel 5.18.5-262-tkg-cfs
HMD: HTC Vive
MCXR version - xanthousm's fork for basic vive controller support
XR Runtime Version - Monado 21.0.0-2334-gc4a290aa9
XR Loader Version - 1.0.25

It's possible it could be an issue wiht monado. You can check that by testing OpenVR games with OpenComposite installed.
In the meantime you can click the right thumbstick to set your height to the player entity's eye height.


[FEA] Rework GpuSubstringIndex to use cudf::slice_strings

When GpuSubstringIndex, cudf didn't have support for something like this. We filed https://github.com/rapidsai/cudf/issues/5158 and it got implemented in cuDF a long time ago, but we haven't gone back to GpuSubstringIndex and used the new api :(
The current implementation in the plugin relies on a regular expression that takes into account delim and count, but it doesn't work for delimiters that are multi character for example, and we throw in this case (which is good). That said, it would be great to move to the cuDF version of this.
Note that we need to make sure have unit and integration tests for this, especially showing that we could support multi character delimiters after the change to cudf::slice_strings.

A Spark UT failed related to substring_index:
'Rapids - string substring_index function' offload to RAPIDS
- Rapids - string substring_index function *** FAILED ***
  org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 705.0 failed 1 times, most recent failure: Lost task 1.0 in stage 705.0 (TID 1411) (spark-haoyang executor driver): java.lang.AssertionError:  value at 0 is null
	at ai.rapids.cudf.HostColumnVectorCore.assertsForGet(HostColumnVectorCore.java:230)
	at ai.rapids.cudf.HostColumnVectorCore.getUTF8(HostColumnVectorCore.java:364)
	at com.nvidia.spark.rapids.RapidsHostColumnVectorCore.getUTF8String(RapidsHostColumnVectorCore.java:183)
	at org.apache.spark.sql.vectorized.ColumnarBatchRow.getUTF8String(ColumnarBatchRow.java:126)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
	at scala.collection.Iterator$$anon$10.next(Iterator.scala:461)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:365)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:890)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:890)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:365)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:329)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:136)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

Driver stacktrace:
  at org.apache.spark.scheduler.DAGScheduler.failJobAndIndependentStages(DAGScheduler.scala:2672)
  at org.apache.spark.scheduler.DAGScheduler.$anonfun$abortStage$2(DAGScheduler.scala:2608)
  at org.apache.spark.scheduler.DAGScheduler.$anonfun$abortStage$2$adapted(DAGScheduler.scala:2607)
  at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
  at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
  at org.apache.spark.scheduler.DAGScheduler.abortStage(DAGScheduler.scala:2607)
  at org.apache.spark.scheduler.DAGScheduler.$anonfun$handleTaskSetFailed$1(DAGScheduler.scala:1182)
  at org.apache.spark.scheduler.DAGScheduler.$anonfun$handleTaskSetFailed$1$adapted(DAGScheduler.scala:1182)
  at scala.Option.foreach(Option.scala:407)
  ...
  Cause: java.lang.AssertionError: value at 0 is null
  at ai.rapids.cudf.HostColumnVectorCore.assertsForGet(HostColumnVectorCore.java:230)
  at ai.rapids.cudf.HostColumnVectorCore.getUTF8(HostColumnVectorCore.java:364)
  at com.nvidia.spark.rapids.RapidsHostColumnVectorCore.getUTF8String(RapidsHostColumnVectorCore.java:183)
  at org.apache.spark.sql.vectorized.ColumnarBatchRow.getUTF8String(ColumnarBatchRow.java:126)
  at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
  at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
  at scala.collection.Iterator$$anon$10.next(Iterator.scala:461)
  at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:365)
  at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:890)
  at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:890)

It is from following case:
SubstringIndex(Literal(""), Literal("."), Literal(-2))

Since GpuSubstringIndex needs reworking, I think we can fix this Spark UT by reworking instead of fixing on the original way.

https://github.com/rapidsai/cudf/pull/13373 cudf::strings::slice_strings has been depracated here.
To fix this issue, we can either re-enable cudf::strings::slice_strings, or enhence the current regex-dependent way.

https://github.com/rapidsai/cudf/pull/13373#issuecomment-2168287320

cudf::strings::find()/rfind() is supposed to be called multiple times in order to find the right position. Now I prefer to write a kernel substringIndex.

closed by
https://github.com/NVIDIA/spark-rapids/pull/11149
and
https://github.com/NVIDIA/spark-rapids-jni/pull/2205


fix(demo): update target Angular version to 14

Updated the target Angular version to 14 in the migration instructions. The Intranet Header is not compatible with older versions.

Preview environments are getting posted here, as soon as they are ready!


fixed #87

When I was created pull request it  was not showing any conflict. I think pull request needs to merge asap.
Other chances are to conflict that is when we go to commit new changes "husky" hooks is not allowing us to commit before lint:fix and when we try to lint:fix it ask to remove unused variables and we do the same and commit it.
Here is the husky hooks which is located in package.json file
"husky": {     "hooks": {       "pre-commit": "CI=true npm run lint"     }   },

@sanjeevkkansal that is correct, eslint was installed to allow us to have some coding standard.Once you fix eslint issues husky will not prevent you

Thanks @huskywhale Yes, I understand and we make sure we run lint before opening a PR. But It shows unused variables in other files which are not changed so wondering how existing code in repo has unused variables. Anyways now we have dev branch protected hope this would resolve the inconsistency issue.


[WIP] Include InnerDetails in TaskFailureDetails

As in title,work-in-progress.

I'll be publishing a PR that has a more complete fix of this, so we can go ahead and close out this one.


Feature request: option to warn instead of failing build

It would be very useful to put this plugin in a mode where type errors are treated as equivalent to lint warnings, instead of failing the build. Maybe something like maximumSeverity: 'warn'?

What would the use case of that be?

I'm currently working on a major refactor of my codebase and certain parts of it I know are not working and certainly are not type-correct at the moment. I'm OK with that and I really just need to test to
And in general, my team's mental model of TypeScript is that of a lint tool / test suite, and we are more often annoyed by type errors preventing us from testing the app on the local dev server than helped (most of our lint rules are also set to Warn for this reason). My ideal set up would be one that warns of type errors in the console but does not stop the app from working locally. (obviously, type errors should still cause CI build failures!)

I'll have to admit to being appalled by your attitude towards static typing 😁
That said, there's room in the world for multiple opinions. If you'd like to consider a PR to that end I'll certainly look at it.

I also would like this. here's my use case:

with incremental flag turned on, it happens really fast, so 👍
however, with this on, you may want to set async to be false again, as it is fast so no worries, and it integrates with plugins better
but now you have to fix all TS errors first before you see/test your code. when refactoring/doing a new feature it's nice to be able to see it working while you're going and clean up as you go.

Cool - if someone wants to submit a PR we'll take a look. 😊

@dallonf , @kelly-tock
Please try fork-ts-checker-webpack-plugin@alpha - I've published a new version which allows you to filter out issues using predicates (issues options) 🚀
I will close this issue to clean-up the backlog :)

@piotr-oles As i understand the issues option doesn't show errors from TypeScript. Is it possible to show errors from TS but as warnings (yellow) and don't break webpack. Just for soft migration to from js to ts.

To do that, you can use issues hook. The most convenient way to do that is to create a custom plugin. I wrote this pseudo-code to show you an idea:
import webpack from 'webpack';
import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';

class ForkTsCheckerWarningWebpackPlugin implements webpack.Plugin {
  apply(compiler: webpack.Compiler) {
    const hooks = ForkTsCheckerWebpackPlugin.getCompilerHooks(compiler);

    hooks.issues.tap(
      'ForkTsCheckerWarningWebpackPlugin',
      (issues) => issues.map(issue => ({ ...issue, severity: 'warning' }))
    );
  }
}

export { ForkTsCheckerWarningWebpackPlugin }

Thank you @piotr-oles. Here is a solution that I adapted from your example for webpack 5:
typescript-warn-only-webpack-plugin.js
const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin");

class TypeScriptWarnOnlyWebpackPlugin {
  apply(compiler) {
    const hooks = ForkTsCheckerWebpackPlugin.getCompilerHooks(compiler);

    hooks.issues.tap("TypeScriptWarnOnlyWebpackPlugin", (issues) =>
      issues.map((issue) => ({ ...issue, severity: "warning" }))
    );
  }
}

module.exports = TypeScriptWarnOnlyWebpackPlugin;

webpack.config.js
const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin");
const TypeScriptWarnOnlyWebpackPlugin = require("./typescript-warn-only-webpack-plugin");

module.exports = {
  plugins: [
    new ForkTsCheckerWebpackPlugin(),
    new TypeScriptWarnOnlyWebpackPlugin(),
  ],
  ignoreWarnings: [/warning from compiler/, (warning) => true],
};


MM-12587 Complete migration of job_actions to redux actions

Summary
Remove job actions from webapp as we can use redux actions for this.
Ticket Link
MM-12587
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

Waiting for https://github.com/mattermost/mattermost-webapp/pull/1999 to rebase


Single responsibility violations

logger should not call exit and panic in any case, because this will violate singe responsibility pattern.
I want to use logger.Fatal to mark some messages in log as critical, but I do not expected that my application will exit after this call.
The same behaviour is applicable for panic.
IMO: this should be only severity of log message, not more.

In Go, if you call a method with the name Panic, you should expect your application to panic.

This is a convention of the standard library and I wouldn't expect this to change.

Ok, What about moving this behaviour to hooks and allow for clients to disable this behaviour if they want it?
Or at least introduce one additional severity 'CRITICAL', to mark messages which is critical for system, but without exiting from application.

@bgaifullin This issue seems "religious" in nature. Fatal and Panic follow the Go standard library conventions. Use Error to report critical issues.


Support Java 17 for packaging

Recently, we (AWS EMR) decided to run Spark RAPIDS with Java 17 runtimes. To do so, we also want to make sure that Spark RAPIDS can be compiled and packaged successfully with Java 17 SDK.
During this work, we got the following error
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (main-spark332) on project rapids-4-spark-aggregator_2.12: Error creating shaded jar: Problem shading JAR /codebuild/output/src676065641/src/build/spark-rapids/rpm/BUILD/spark-rapids-23.02.0.amzn.0.SNAPSHOT/sql-plugin/target/spark332/rapids-4-spark-sql_2.12-23.02.0-amzn-1-SNAPSHOT-spark332.jar entry com/nvidia/spark/rapids/shims/ShimSupportsRuntimeFiltering.class: java.lang.IllegalArgumentException: Unsupported class file major version 61 -> [Help 1]

After searching, I found this JIRA issue: https://issues.apache.org/jira/browse/MSHADE-407. And this issue has been fixed in maven-shade-plugin:3.3.0.
After changing the version to 3.3.0, the build was successful on my side.

build

This change loos fine. Is that really the only change that is needed?

Yes, it is. At least on my side. We have successfully compiled & run Spark RAPIDS with Java 17.


Move polygon

Is it possible to move (shift) a polygon?
I wonder if polygons can be entirely shift  without having to edit each single point. For instance, for many applications it is very useful to propagate polygons from one frame to another (if frames comes from video) and then shift the whole polygons.

@edumotya , it is possible. Just unlock it. By default it is locked.

@edumotya hi, This question has nothing to do with whether it is locked or not. I would also like to ask this question. Have you solved it?

No, I have not. I am sorry I did not reply because I thought it was my fault...
I still have to move the polygon point by point even if the polygon is unlocked.

I just found out why. When using polygon annotations, the property "Switch pinned property" is automatically selected, and the polygon can be moved by unchecking this property in the sidebar on the right.

Like this, to cancel the selected

Perfect! it is just as @nmanovic pointed out

I just found out why. When using polygon annotations, the property "Switch pinned property" is automatically selected, and the polygon can be moved by unchecking this property in the sidebar on the right.  Like this, to cancel the selected

This one works for me.


use std python image instead of alpine due to build issues

the build is 1.9g  but to be fair 0.9 of that is dependencies that are installed.
lots of research & time, little change.  how it should be :)

@hotpocket
Sorry for the delay. Tested on my local, works great.
However, python slim works as well and is only 1.02 gb. Is there any particular reason you'd like to use the stock python image instead of this? We were using slim before alpine.

@all-contributors please add @hotpocket for infra

@hotpocket
Sorry for the delay. Tested on my local, works great.
However, python slim works as well and is only 1.02 gb. Is there any particular reason you'd like to use the stock python image instead of this? We were using slim before alpine.
Edit: Apologies, just saw your comment. I agree, we can make the slim conversion another ticket so we can get Docker working asap. Would you like to be assigned this one?
Merging this PR now

Sure, add me for the next ticket.  I've not done my homework yet on it, but from what I remember reading - docker-slim is a tool to modify an existing image to shrink it, not an image proper?   I'll find out as the ticket progresses.  Do we maybe want to host it at docker hub for a one stop shop pull & run ?

@hotpocket
Sorry for the delay. Tested on my local, works great.
However, python slim works as well and is only 1.02 gb. Is there any particular reason you'd like to use the stock python image instead of this? We were using slim before alpine.
Edit: Apologies, just saw your comment. I agree, we can make the slim conversion another ticket so we can get Docker working asap. Would you like to be assigned this one?
Merging this PR now

Sure, add me for the next ticket. I've not done my homework yet on it, but from what I remember reading - docker-slim is a tool to modify an existing image to shrink it, not an image proper? I'll find out as the ticket progresses. Do we maybe want to host it at docker hub for a one stop shop pull & run ?

I wasn't referring to docker-slim (altough I suppose we can look into this aswell), but rather python-slim, which doesn't shrink the image but instead skips the installation a good amount of packages that the stock python image ships with.
Docker hub seems like a good idea


Add candle-lora transformers to readme?

Hi @LaurentMazare,
I have recently added LoRA support to many models in candle-transformers. These "LoRA transformers" are in candle-lora. However, I think that it would be helpful to add a link for these into the README as it would increase discoverability for developers who want to fine-tune models. Currently, one would need to go to the candle-lora repository to find these models, and while that may be intuitive I think making their location explicit would be better.
What do you think about this addition?

That seems a bit long to me and the readme is already overlong. I think we should stick to roughly a line per item and interested readers can click on the link to get more details.

I just shortened my addition to be a single line, hopefully this is better?

Yeah looks reasonable thanks.

Thanks!


[Translation zh-tw] _common-links.md

Check out a review request at GitLocalize

Reviewed by @limhenry translated by @kennith

Comparing to the original, it's missing
[service-worker-primer]: /web/fundamentals/getting-started/primers/service-workers "Service Workers: An Introduction"

Why is that?

@agektmr weird, that line is not showing in gitlocalize: https://gitlocalize.com/repo/107/zh-TW/src/content/en/_common-links.md

I think it's GitLocalize issue cc: @sotayamashita @chikathreesix

@agektmr I have create a pull request to solve issue temporary. https://github.com/agektmr/WebFundamentals/pull/1

@sotayamashita Thanks. The PR is merged.
We still have to sort CLA issue. Can you explain what is going on?


To-Do Sample is Broken

Description
To-Do Sample broken, checkboxes resetting
CodeSandBox/Snack link
https://docs.nativebase.io/todo-list
Steps to reproduce

Go to Docs Site
Click the to-do list, and check a few things
Clicking one checkbox will uncheck others

NativeBase Version
3.3.1
Platform

[ ] Android
[ ] CRA
[X] Expo
[X] iOS
[ ] Next

Other Platform
Web
Additional Information
After some investigation, I found that in the handleStatusChange function, the list state variable is getting reset to the initial state.
It seems that the onChange handler for the checkbox isn't somehow getting binded to latest version of the list state. I tested this by adding a Button and the onPress handler, and the behavior worked as expected.
 <HStack
  w="100%"
   justifyContent="space-between"
   alignItems="center"
   key={itemI}
 >
                <Button
                  onPress={() => {
                  // calling this in the OnPress Handler works as expected, but seems like onChange handler in the Checkbox doesn't work
                  handleStatusChange(itemI)
                  }
                  bg={"white"}
                  color={item.isCompleted ? "black" : "red"}
                >
                  {item.title}
                </Button>
                <Checkbox
                  isChecked={item.isCompleted}
                  onChange={(isChecked) => handleStatusChange(itemI)}
                  value={item.title}
                ></Checkbox>
</HStack>

Can you please confirm the Checkbox handler is working as expected?

@rlingineni Thanks for reporting! The To-Do sample is fixed in version 3.3.5.


Fix Total Experience Value processor

Currently, when offering a "Total Experience" value to a player, the processor is incorrectly calculating the level that the player should be at.
I have written a small test plugin that provides commands to offer experience data to the player who runs the command - see https://gist.github.com/dualspiral/fcf31718d3aa17f6d1b3. When running this test plugin, I run /explvl 15 then /expset 315, which should give level 15 in both cases. However, as can be seen in the screenshot below, /expset 315 gives an incorrect result.

This PR fixes that so the experience level is set correctly - offering level 15 or 315 experience will return identical results.
The processor was also always returning false, when it should have actually been returning true (data was set, but the overall DataTransactionResult returns "REJECTED".) This has been fixed.

Does the same fix need to be applied to the data processor?

Agh, no, not as far as I can see. I just got muddled up between "Data" and "Value" processors - forgive me, it's late here! This should be sufficent as far as I can see.

@dualspiral mind squashing into 1 tidy commit? Then I'll merge it in cleanly (otherwise github doesn't notice this as merged and I have to just close it otherwise).

@gabizou Not a problem - it's squashed.


Add option to ignore comments

Initial support will be added in next release 0.3

Initial support in 0.3
#16 filed to enhance using logic from CASTLE


Bump gradle version to 8.1.1

Description
Upgrades gradle to 8.1.1 to be in sync with core OpenSearch (original change in core https://github.com/opensearch-project/OpenSearch/pull/7270)
Check List

[X] All tests pass
[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Shouldn't we add change log?

Shouldn't we add change log?

ack


Feature/60 use same collection with different patterns

What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.94%. Comparing base (e9d8c8d) to head (e9f53c4).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   38.14%   37.94%   -0.20%
==========================================
  Files           4        4
  Lines         839      867      +28
  Branches      181      188       +7
==========================================
+ Hits          320      329       +9
- Misses        419      437      +18
- Partials      100      101       +1

Flag
Coverage Δ

unit
37.94% <ø> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GET /data/list/{filters}

The data_status table features the status enum column with possible values active and deactivated.
The constraints of the table means there can only be one of each entry per dataset id, which means that a deactivated dataset can not be re-activated again. It seems this is by design, and it's actively (ab)used in the query:
LEFT JOIN (SELECT `did`, MAX(`status`) AS `status` FROM `dataset_status` GROUP BY `did`) s ON d.did = s.did

where MAX('status') is the alphabetical maximum of the status (i.e., relies on active always being before deactivated). It seems brittle, but I guess it would be more efficient than the self-join required if you only rely on most-recent update:
SELECT ds1.`did` as `did`, ds1.`status` as `status`
FROM dataset_status as ds1
WHERE ds1.`status_date`=(
      SELECT MAX(ds2.`status_date`)
      FROM dataset_status as ds2
      WHERE ds1.`did`=ds2.`did`
)

Jan agrees the design of the dataset_status table is questionable and does not recall why it was made this way.
The administrator bug is confirmed as oversight.


Allow unix sockets to be used, fixes #151

We can probably add a FixedSocketPool or something like that to amphp/socket.

👍 for the fixed socket pool but can be done later, patch to the local address is on the contrary mandatory for this.
Also forget you already told me about this, my bad :/

@rdlowrey @bwoebi @trowski Opinions for the value to use here? I think "" is reasonable.

Should this be fixed here or perhaps return "unix-socket" in amphp/socket?

In this case the local adress is the same as the remote adress (both are the socket file) ?

That sounds reasonable as well!

Closing, as this will be fixed in amphp/socket instead.


Design Report Section: Constraints

Closes #53.

@nchareunsouk @narvcharv are 2.3.5 and 2.3.10 the same?? If so can we merge them?

are 2.3.5 and 2.3.10 the same?? If so can we merge them?

@JLefebvre55 I think they're similar enough to merge but there could be a benefit to leaving them separate if there's a 300 char limit per constraint. Having them separate would potentially allow for more detail about the computer vision and connectivity infrastructure.

@JLefebvre55 I think they're similar enough to merge but there could be a benefit to leaving them separate if there's a 300 char limit per constraint.

I mean, are they filling in the same "data connection" constraint?

I'm merging them.


External devices currently not supported

[ ] External device is created or planned
[ ] External device communication protocol is established
[ ] External device communication protocol is documented
[ ] External device communication is implemented
[ ] External device communication is binded to backend
[ ] External device selection is implemented in the UI

Existing implementation has been testedly confirmed to partially work. Embedded Mono under Linux does not like loading default config, and thus System.Native is unreferenced. It's quite trivial to make Mono load this config in code, but making it not hacky is still being investigated


Remove complexity of storing a function in state and passing through function calls.

By using meck in tests, we simplify production code, debugging, and replace
a pattern we don't use in Riak with a well-known testing methodology.

Corresponding riak_test, verify_removed_capability passes

:+1: 48c2635

@borshop merge


Implement proper timing

Can't rely on VSync to do the work, especially in virtualized environments that lack hardware graphics acceleration, e.g., Linux VMs.

cd5d790


Adverse Weather Synthetic Segmentation

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Adverse Weather Synthetic Segmentation
:red_circle: Aim : Create a DL model for segmenting the adverse weather synthetic condition.
:red_circle: Dataset : https://www.kaggle.com/datasets/abdulrahmankerim/semantic-segmentation-under-adverse-conditions
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Email ID :
Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full Name: Rohan Kurien Thomas
GitHub Profile Link: https://github.com/rohankthomas801
Email ID<EMAIL_ADDRESS>Participant ID: SSOC Season 2
Approach for this Project:

Data Collection- Download the given dataset
Data Preprocessing- I will first confirm that the images are of a consistent size. Then I will normalize pixel values and split
the images into training, validation, and test sets. Then I will check that the distribution of different weather conditions is
balanced across the sets to avoid bias.
Data Augmentation- I can also apply data augmentation techniques to increase the diversity of the training dataset. This
can involve random transformations such as rotation, scaling, and flipping the images.
Model Selection- This project requires semantic segmentation. Models like U-Net, DeepLabV3+, or FCN which
are commonly used for image segmentation will be used and compared.
Model Training- Loss functions used for semantic segmentation include Binary Cross-Entropy loss, and Dice Loss, both
of which can be used for training the model.
Model Evaluation-  Many types of metrics are considered. For example the Intersection over Union (IoU) and dice score
metrics.

Participant Role: Social Summer of Code 2023- Contributor

Issue assigned to you @rohankthomas801

Hey can I get this issue?
I have experience in segmentation so I will be using unet,unet++(depends on dataset and my machine),deeplab,segnet,enet

Assigned @CoderOMaster

This dataset is made specifically for a research paper.Will it work if I implement that ?

@abhisheks008 i just checked and found they have used another dataset which is quite huge and idts it will be possible to run on our machines,in that case what should i do

can i use cityscape dataset for segmentation..i did not find any suitable dataset for weather

https://www.kaggle.com/datasets/vijaygiitk/multiclass-weather-dataset or i can use this weather dataset for perform weather classfication

Go ahead.


Unable to configure with steps in readme

➜  cppecho git:(master) echo $BOOST_HOME
/home/alex/pro/boost-bin/build
➜  cppecho git:(master) ls /home/alex/pro/boost-bin/build
include  lib
➜  cppecho git:(master) ./waf configure build
Setting top to                           : /home/alex/pro/cppecho
Setting out to                           : /home/alex/pro/cppecho/build
Checking for 'clang++' (C++ compiler)    : /usr/bin/clang++
sed -i "s/touch configure/touch configure && sync/" ./scripts/fix-timestamps.sh
sed: can't read ./scripts/fix-timestamps.sh: No such file or directory
Command failed with exit code 2
(complete log in /home/alex/pro/cppecho/build/config.log)

Just add to README that this repo contains submodules and it should be inited and updated.

@alexkutsan, did you run waf configure? this command should be executed first and it will do git submodule --init --recursive if logger is not found

Resolved by #10


[SPARK-18171][MESOS] Show correct framework address in mesos master web ui when the advertised address is used

What changes were proposed in this pull request?
In SPARK-4563 we added the support for the driver to advertise a different hostname/ip (spark.driver.host to the executors other than the hostname/ip the driver actually binds to (spark.driver.bindAddress). But in the mesos webui's frameworks page, it still shows the driver's binds hostname/ip (though the web ui link is correct). We should fix it to make them consistent.
Before:

After:

This PR doesn't affect the behavior on the spark side, only makes the display on the mesos master side more consistent.
How was this patch tested?
Manual test.

Test build #67778 has finished for PR 15684 at commit 19a4261.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67778/
Test PASSed.

/cc @zsxwing who worked on SPARK-4563 and @mgummelt .

@zsxwing @mgummelt could you help review this PR?

LGTM, @srowen can you help on this?

Merged to master


VCL namespace networking

Coverage increased (+0.2%) to 52.665% when pulling 60ce06598f38b5cd10c37e759af617cac8e6909e on rastislavszabo:lukasmacko-master into ac3e479035edaef5e69771867cd466052d089d7b on contiv:master.

Coverage increased (+0.2%) to 53.157% when pulling b95de45da34aafdda607c4ddfd30d9a4790b7368 on rastislavszabo:lukasmacko-master into b72dafa1e8fed6d9f56d14505f78e481b033fccf on contiv:master.

Coverage increased (+0.09%) to 53.095% when pulling 7f88e4a6c72eaf62fdc8a37dd1ea877782b50ae8 on rastislavszabo:lukasmacko-master into b72dafa1e8fed6d9f56d14505f78e481b033fccf on contiv:master.

Coverage increased (+0.2%) to 53.157% when pulling b3dd35c494659208268295fd3ebd410c6c9d001a on rastislavszabo:lukasmacko-master into b72dafa1e8fed6d9f56d14505f78e481b033fccf on contiv:master.

Coverage increased (+0.09%) to 53.095% when pulling f54f19f0051f4a6d47a246e010b58813a2f9380c on rastislavszabo:lukasmacko-master into b72dafa1e8fed6d9f56d14505f78e481b033fccf on contiv:master.


Same problem as others - used DFI bridge and was not able to complete. DFI lost?

So, as a test, I sent 3 DFI from my DFI desktop wallet to the DFI bridge and DFI (BSC) were supposed to be deposited in my Metamask. The DFI were sent but nothing happened after I clicked the button to send to BSC chain. No window popped up from Metamask asking for BNB as gas. Tried the Restore method and same result - click the button and no Metamask window.
Here is the Tx ID from my DFI wallet: d5f2ae77e38d6e91456ed8c75089c357e157db6af2545f00aebc66b52f39d986.
Any help would be appreciated.

Can you let me know the binance chain target address ... or try the recovery function again yourself. We have fixed a couple of things lately.


Make Volumetric Gas Pump overclocking activatable or remove it

Description

Volumetric Gas Pumps have a feature called "Overclocking": If activated they can operate at basically indefinite high pressures as long as the difference between input and output is not too extreme. Drawback is that in this state they leak gasses into the environment.
However, this feature is currently not available in the game since the only way to activate it is to set the corresponding component variable as admin.
Two ideas to implement this: either

a toggle button (with warning text) in the Volumetric pump UI (easy to find, clear indication, maybe a bit too on-the-nose?)
de/activate by screwdrivering the pump ("hidden" mechanic, less clear, but feels more immersive)

Alternatively overclocking can just be removed since it is currently just dead code. But I would prefer to make it usable since it extends Atmos mechanics options, especially considering high-pressure TEG setups.
Additional context

Overclocking was implemented in #3833

That feature should just be how pumps work minus the gas leaking imo

From a real life mechanical viewpoint it makes sense that there are limits on how high a pump can get because it has to compress the gasses somehow and that compression strength is limited by the parts of the pump, not the pressure delta.
I like the overclock mechanism with some leakage since it gives you a option for pumping high pressure gasses but with drawbacks.
But maybe this could be more gradual:

Normal operations: VolPump works normal up until output pressure exceeds a value, then it gradually gets more slow with rising output side pressure until there is a limit where it can't go higher
Overclocked operations: Leak nothing at low pressures and gradually more after input pressure exceeds a certain limit

If a discussion is labeled, here are some arguments:
Pro making this available:

Enables high-pressure pumping at a cost
More possibilities for Atmos to do stuff
Examples: Insane hot-loops on TEG, putting even larger amounts of gas into a canister, resolve deadlocks in atmos-setups that started to internally burn, make entire setups with ultra high pressures/hot temps

Pro removing the dead code:

It did not seem to be missed in the past
keep Atmos techs using their brains
high damage potential, especially when pipe rupturing gets merged
drawback of leaking gas easily circumvented by building a spaced box around the pump, leaving only some gas loss as drawback
dead code bad

Pro keeping it as dead code:

Admins could still enable this when needed (I can't think of a scenario where that would happen tough, starting with that probably none of them knows about this checkbox)

After some consideration I'm not sure anymore if I want this in the game since it would make TEG-setups dumb easy (fill the loop with burn mix, heat till ignition, build directional windows around volpump, done).
and @keronshb - I don't understand why this is labeled "Difficulty 3-hard". The logic is already present in the game. It just needs an UI button to set an already existing variable. Thats like 20 LOC


Javascript/CSS cache on already rendered page

We are using scrapy in conjection with Splash and trying to scrap an entire website. What we noticed was that  , there was huge time of 5 to 9 seconds to render each page. We were wondering if we could cache all repeated HTML/CSS/JS files so that we need not download it again and again.
Kindly let me know if this is possible in current feature set. If not , please point me in the right way on its implementation.

Something you can do at the moment is to write a Lua script that causes those files not to be downloaded at all. Unless you need a nice-looking screenshot, that is probably a better approach.

Say I want to cache all of the assets loaded by the time, say, 10 seconds elapses. Would the current recommendation be to use something like Squid as an external caching solution? Is there a way to do this in Splash itself?


name 'light_rain' is not defined

getting the following error:
$ wwy -c kolkata
Traceback (most recent call last):
  File "/usr/local/bin/wwy", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/wwy/__main__.py", line 92, in main
    get_ascii(info)
  File "/usr/local/lib/python3.8/dist-packages/wwy/__main__.py", line 69, in get_ascii
    for i in range(len(light_rain)):
NameError: name 'light_rain' is not defined

Please fix.

Also can you please make the place name the default positional parameter? So that -c is not required?

Thank you for reporting the error. I have now fixed the error. I will also be working on making the place name as the default parameter.

Awesome! Neat software. All the best!

Would it be possible to include wind speed and the local time as well?

I will try to implement that. I also wanted wwy to display the local time.


The querying quote identifier bug for postgredb

Environment:

eKuiper version (e.g. 1.8.0):
Hardware configuration (e.g. lscpu): Intel(R) Xeon(R) Silver 4310 CPU @ 2.10GHz
OS (e.g. cat /etc/os-release): PRETTY_NAME="Ubuntu 23.04"
Others:

What happened and what you expected to happen:
When I use ekuiper to acquire data from postgredb, I find there is a bug in the sql statement.

You can see, there is a quota around ts, like 'ts' and  because the ekuiper  uses quotes around 'ts' in the ORDER BY clause, causing the database system to interpret it as a string constant instead of a column name.
the error log like the picture below:

and when I use the db client to run the sql statement, it also occurs error

How to reproduce it (as minimally and precisely as possible):
If u wanna reproduce it, u can use ekuiper to connect postgredb and set both indexField and indexValue. After u have done, u can see the sql statement in the log:
ekuiper stream configuration:

log:
select * from ts_kv where ts > '1697010531464' order by 'ts' ASC limit 1

Anything else we need to know?:
the right statement is select * from ts_kv where ts > '1697010531464' order by ts ASC limit 1.  the main point is that the quote identifier around ts should be removed.

the code position is below

func (q *CommonQueryGenerator) getOrderby() string {
	if q.IndexField != "" {
		return "order by " + q.quoteIdentifier(q.IndexField) + " ASC "
	}
	return ""
}

func (q *CommonQueryGenerator) quoteIdentifier(identifier string) string {
	return "'" + identifier + "'"
}

In postgredb, it doesn't support sinlge quote for the field ts. U can use double quote to replace it (single quote for ts) or remove the q.quoteIdentifier()
By the way, it's ok for mysql.

Thanks for the super detailed description! Since you have identify the problem, would you like to submit a PR?


[SPARK-14343][SQL] Proper column pruning for text data source

What changes were proposed in this pull request?
Text data source ignores requested schema, and may give wrong result when the only data column is not requested. This may happen when only partitioning column(s) are requested for a partitioned text table.
How was this patch tested?
New test case added in TextSuite.

Test build #59718 has started for PR 13431 at commit 1074fa6.

LGTM

Test build #59719 has started for PR 13431 at commit d0fda2d.

Test build #59719 has finished for PR 13431 at commit d0fda2d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59719/
Test FAILed.

Test build #59718 has finished for PR 13431 at commit 1074fa6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59718/
Test FAILed.

Test build #59731 has started for PR 13431 at commit 7555a4e.

Test build #59731 has finished for PR 13431 at commit 7555a4e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59731/
Test PASSed.

Thanks for the review! Merging to master and branch-2.0.


feat(Topology/Profinite): define the (light) profinite space corresponding to the one point compactification of N

Incorporated into #11755


⚠ Jenkins Plugins Artifactory has degraded performance

In 53eda80, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1396 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 1ae2c2c after 57 minutes.


[Bugfix] Fix bug in LANS optimizer with float16 model

Description
Fixed the bug in LANS optimizer with float16 model.
Checklist

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

cc @awslabs/raf-reviewer

Thanks @whbldhwj


404 Not found

The url pointed in README returns a 404 error.
https://giorgis.io/cgo-examples

It would be nice to learn cgo by example. Can you consider reviving this ?

Just shortening the search time for a working snapshot of the blog: web.archive.org.


terminal.app open new tab, windows got resize as if new window is created

terminal.app open new tab, windows got resize as if new window is created
big sur - latest yabai release 3.1.4

Duplicate of #68


Fix text regarding accessibility of debug CSRs

https://github.com/riscv/riscv-isa-manual/blob/5f111da2fadf82865af018e473ce728ebfc20622/src/priv-csrs.tex#L109-L111
Debug CSRs in the range 0x7A0-0x7AF are accessible from machine mode.  Only 0x7B0-0x7BF should trap when accessed in machine mode.

Whoops, looks like we got this right in Table 2.5, but wrong in the text.


Use a flat play icon instead of the blue emoji with test code lens

@lnicola
Restores this commit:
https://github.com/rust-analyzer/rust-analyzer/commit/55e914a2a179aba63bd9948d6e0cf3e2a4bf5960
That was effectively wiped out by this code formatting commit:
https://github.com/rust-analyzer/rust-analyzer/commit/dc217bdf90d555eaa1780041fc3a14e64173994d
https://github.com/rust-analyzer/rust-analyzer/commit/3d445256fe56f4a7ead64514fb57b79079973d84

Looks like a bad rebase or merge because it also removed the space. If auto-formatting did insert the emoji we should use an escape for the play icon too.
CC @vsrs

I've checked cargo fmt does not affect the emoji.
So it seems like this is my mistake, sorry.

bors r+


Log out button in API Center Portal

Is it possible to add a log out button in the API Center Portal? And is it possible to provide additional information, like the logged in user's display name via the portal? It's a little confusing.

@georgeollis :
To provide more flexibility and better control to our customers, we decommissioned the integrated managed APIC portal and instead focus on providing a reference implementation for APIC portal with one click deployment model - so customers can bring up this portal in their subscription and have more flexibility around e.g. custom domain.
Please take a look and let me know if this solution will help with your requirement: https://github.com/Azure/APICenter-Portal-Starter
thanks


v1.0.0 beta.5 release

name: Release Checklist Template
about: Checklist of versioning to create a taggable commit for Zebra
title: ''
labels:
assignees: ''

Versioning
Which Crates to Increment
To check if any of the top-level crates need version increments, go to the zebra GitHub code page: https://github.com/ZcashFoundation/zebra and use the last modified dates of each crate. Alternatively you can use the github compare tool and check the main branch against the last tag (Example). git diff --stat <previous-release-tag> origin/main is also useful to see what's changed.

[x] Increment the crates that have new commits since the last version update
[x] Increment any crates that depend on crates that have changed
[x] Use the zebrad crate version in the zebra-network user agent string
(currently the constant USER_AGENT in zebra-network/src/constants.rs)
[x] Use the latest git tag in README.md
[x] Use the latest git tag in book/src/user/install.md

How to Increment Versions
Zebra follows semantic versioning.
Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]
Pre-Release Crates
Pre-Release versions have a TAG like "alpha" or "beta". For example: 1.0.0-alpha.0

Increment the PRE-RELEASE version for the crate.

Optionally, if a MINOR feature pre-release breaks MAJOR API compatibility:

Increment the MAJOR version, and reset all the other versions to zero

Unstable Crates
Unstable versions have a MAJOR version of zero. For example: 0.1.0

Follow stable crate versioning, but increment the MINOR version for breaking changes

Stable Crates
For example: 1.0.0
Increment the first version component in this list, and reset the other components to zero:

MAJOR versions for breaking public API changes and removals

check for types from dependencies that appear in the public API

MINOR versions for new features
PATCH versions for bug fixes

includes dependency updates that don't impact the public API

Version Locations
Once you know which versions you want to increment, you can find them in the:

[x] zebra* Cargo.tomls
[x] tower-* Cargo.tomls
[x] zebra-network protocol user agent: https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/constants.rs
[x] README.md
[x] book/src/user/install.md
[x] Cargo.lock: automatically generated by cargo build

Version Tooling
You can use fastmod to interactively find and replace versions.
For example, you can do something like:
fastmod --extensions rs,toml,md --fixed-strings '1.0.0-alpha.12' '1.0.0-alpha.13'
fastmod --extensions rs,toml,md --fixed-strings '0.2.9' '0.2.10' tower-batch
fastmod --extensions rs,toml,md --fixed-strings '0.2.8' '0.2.9' tower-fallback

Reviewing Version Bumps
Check for missed changes by going to:
https://github.com/ZcashFoundation/zebra/tree/<commit-hash>/
Where <commit-hash> is the hash of the last commit in the version bump PR.
If any Zebra or Tower crates have commit messages that are not a version bump, we have missed an update.
Also check for crates that depend on crates that have changed. They should get a version bump as well.
Initial Testing

[x] After any changes, test that the cargo install command in works. Use
e.g. cargo install --locked --path zebrad.

README
As we resolve various outstanding known issues and implement new functionality with each release, we should double check the README for any necessary updates.
We should check and update if necessary:

[x] The "Beta Release" section
[x] The "Known Issues" section

to ensure that any items that are resolved in the latest release are no longer listed in the README.
Change Log
Important: Any merge into main deletes any edits to the draft changelog. Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.
We follow the Keep a Changelog format.
We use the Release Drafter workflow to automatically create a draft changelog.
To create the final change log:

[x] Copy the draft changelog into CHANGELOG.md
[x] Delete any trivial changes
[x] Combine duplicate changes
[x] Edit change descriptions so they are consistent, and make sense to non-developers
[x] Check the category for each change

prefer the "Fix" category if you're not sure

Change Categories
From "Keep a Changelog":

Added for new features.
Changed for changes in existing functionality.
Deprecated for soon-to-be removed features.
Removed for now removed features.
Fixed for any bug fixes.
Security in case of vulnerabilities.

Create the release PR
After you have the version increments and the updated changelog,

[x] Push the version increments and the updated changelog into a branch
(name suggestion, example: v1.0.0-alpha.0-release)
[x] Create a release PR by adding &template=release-checklist.md to the
comparing url (Example).
[ ] While the PR is being reviewed, keep track of any PRs that have been merged
since you created the PR to update CHANGELOG.md and push any updates if necessary
[ ] Once the release PR has been approved and merged, create a new release
using the draft release as a base, by clicking the Edit icon
in the draft release.
[ ] Set the release title to Zebra  followed by the version tag, for example:
Zebra 1.0.0-alpha.0
[ ] Copy the final changelog of this release to the release description
(starting just after the title ## [Zebra ...)
[ ] Set the tag name to the version tag, for example: v1.0.0-alpha.0
[ ] Set the release to target the main branch
[ ] Mark the release as 'pre-release' (until we are no longer alpha/beta)
[ ] Publish the release

Final Testing

[ ] After tagging the release, test that the exact cargo install command in
README.md works (--git behaves a bit differently to --path)

If the build fails after tagging:

fix the build
check if the fixes changed any extra crates, and do the required version increments
update README.md with a new git tag
update CHANGELOG.md with details about the fix
tag a new release

I've excluded these PRs:

Thank you for writing this list out, it's very helpful for reviewing!

Here's a list of crates the versions of which I didn't increment:

zebra-client
zebra-rpc.

I incremented the versions of all other crates.

I'll try to keep updating this PR until it gets merged. If that doesn't work, I'll stop updating it, wait until it is merged, and then fix the changelog.

I tested that the exact cargo install command in README.md works smoothly with the new release. All should be done now.

Here's a list of crates the versions of which I didn't increment:

zebra-client
zebra-rpc.

I incremented the versions of all other crates.

Yep we'll do zebra-rpc and the new sync crate at the next release.

Sure, I posted that to make the review even easier. I'll post both lists by default if I'm doing another release. It doesn't take almost any extra time to create the lists and I think it's beneficial for the review.


Prevent result.stdout and result.stderr error

I had to change the code locally because it was failing due to result.stdout being undefined.
I am unaware of the underlying source of the issue, but these changes fixed it.

@alexpanov Are you using Yarn for your package installs?  I ran into this issue and tracked it down to Yarn.
Yarn creates a separate node_modules directory under serverless-babel-plugin that contains the .bin/babel binary that is being called.  You can correct the error without modifying the source by installing babel-cli for your project:
yarn add -D babel-cli

@atomaka
I do use yarn, yes. Thanks for the tip.

Hello I had the same problem, and can solve with npm similar by obviously installing the babel-cli.
Thing is though, I was just wondering why the plugin doesn't use its babel-cli that is included instead of looking for it in the parent package? The sub node_modules referenced above is expected with npm or I assume yarn because it contains the dependencies for this package, the serverless-babel-plugin.
Second question, why do this change because then what happens it just silently fails? Seems like it would be better to raise an error, in this case, babel-cli is required in the project.

@lteacher
I totally agree. I did not have all the information at the time, hence the sub-optimal fix.
I won't submit a new PR though, because I don't feel like the feedback loop is quick enough.
I can close this one.

hey @alexpanov, sorry for the late reply. Interested to create a new PR? I try to get back over the next couple days …


Over-use/High performance of CPU, RAM and Disk

This is my laptop status when it runs the Real-ESRGAN execution.
My laptop configuration:

Any idea to solve this issue? :((

did you ever solve this?


Add 3D print files for Simple Duck Case

Add .STL files to 3d Print your own Duck Case

How's this look @knouse1344 and @nfeuer?

Looks fantastic, thanks @TimoWielink


OpEntryPoint needs cleanup of unused inputs with multiple entry points

I’m running into an odd issue going from HLSL-> SPV through DXC, and I’m curious if I could get some help or advice..
If I have code like this:
[shader("compute")]
[numthreads(1, 1, 1)]
void computeShader( uint3 DTid : SV_DispatchThreadID )
{
  printf(“Hello from compute shader\n”);
}

[shader(“closesthit”)]
void closestHit()
{
  printf(“%f\n, WorldDirection().x);
}

Then dxc adds the WorldDirection call to the interface list of the entry point for the compute shader. This causes AMD’s driver to crash, because WorldDirection is an invalid intrinsic to call from a compute shader… (with DXC, seems like all entry point interface lists are identical unfortunately, regardless of entry point type…)
Ideally there would be some sort of pass to to eliminate unused interface variables, especially those like WorldDirection which isn’t a valid compute shader intrinsic and causes drivers to crash. Issue #1337 seems relevant, though for us this is more of a “game stopping” issue, while for them it’s more of an optimization.
For some background, in a ray tracing workflow, I need compute shaders to generate bounding boxes and instance transforms in parallel. We’re trying to reproduce an OptiX 7 like workflow with HLSL -> SPIRV, and so we’re trying to follow a “multiple entry points, one file” setup, with a mix of ray tracing and compute kernels)
Sounds like #1337 already has a pass implemented that does this cleanup, but the issue was closed without resolving the issue due to some ambiguities with the spec in 2018… hopefully that’s resolved by now?
I have a parallel issue on dxc here https://github.com/microsoft/DirectXShaderCompiler/issues/4621

Reviewing prior issues a bit more, (vhttps://github.com/KhronosGroup/Vulkan-Docs/issues/666) it seems like it is supported in the spec to remove unused/dead inputs:
https://registry.khronos.org/vulkan/specs/1.2-extensions/html/chap15.html#interfaces-iointerfaces-matching
And it seems like this test enforces this requirement actually.
https://github.com/KhronosGroup/SPIRV-Tools/blob/master/test/opt/aggressive_dead_code_elim_test.cpp
Perhaps using  --eliminate-dead-code-aggressive will fix this?

Can you provide the DXC command you use to generate the code? My guess is that the use of the builtin adds an extension that cause ADCE to not run. It will need to be added to the allow list.
See https://github.com/KhronosGroup/SPIRV-Tools/blob/f5ff7ae4a184dc406ca8292614d19af632d48a3f/source/opt/aggressive_dead_code_elim_pass.cpp#L938


[PATTERN] Add a star pattern in Python, Pattern38

Description
Task:
for the given input n the following pattern should print (n=5 for the below pattern):
Pattern Image

Filename
Pattern38.py

Hi @Vishal21121, Can you assign this to me??

ok, @johnweslee I am assigning this issue to you.

Hi @Vishal21121,
Created a PR #76 for this issue. Kindly take a look into it.


User consent popup not showing

In our effort to start using SSO in out teams bot, we figured out that whenever we request a new Token using an oauthCard, we run into the following UX issue:
We see the following consent request in teams:

When clicking on "Weiter", the button gets disabled but nothing else happens and the user is lost. So there is no popup (as we see when using the web version).
I'm using the following Teams-Desktop client: 23320.3027.2591.1505.
Client-Version: 49/23113028720

Hello @sschoeb - Thanks for raising your query.
We will look into it and let you know the updates.

Apologies for the delay, we checked this at our end using https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js. By clicking on continue button, the login is successful.

Could you please let us know if you are still facing this issue?

@Meghana-MSFT yes we do still face this issue. Do you need a video or any other information to work on this issue? make sure you do not try it only once but multiple times.
Could you reopen this issue?

We did check this multiple times, could you please share video of this.

Could you please share video of this issue.


[2.5][Forwardport] Force use local state file

Original PR:

https://github.com/rancher/kontainer-engine/pull/236

Actually merged in rancher/rancher: https://github.com/rancher/rancher/pull/28224


Improve unflatten | feat(atenlib)

Remove If subgraph

@justinchuby The fails are expected?

Do you see any new ones other than #539 ?


Files are not uploaded (CodeSleeve/laravel-stapler)

Hi my friends. I have the same problem Files are not uploaded #10, and I do not understand how to solve it

I fixed it this way:
If I add a user session objects
$ user = User :: find (1);
Session :: put ('user', $ user);
all attempts to make
   static :: saved (function ($ instance) {
             foreach ($ instance-> attachedFiles as $ attachedFile) {
                 $ attachedFile-> afterSave ($ instance);
             }
         });
lead to failure. Since the function
protected static function registerModelEvent ($ event, $ callback)
{
if (isset (static :: $ dispatcher))
{
$ name = get_called_class ();
static :: $ dispatcher-> listen ("eloquent. {$ event}: {$ name}", $ callback);
}
}
check if (isset (static :: $ dispatcher)) always returns false
I just stopped to save objects to the session.

Are you still having an issue here?  I guess I'm not quite understanding what it is you're trying to do here?

I tried to upload a photo to the user model. When I add an instance of the model in the user session, this model did not work events such as 'saving' and 'saved'.


chore(build): remove PropTypes from builds

PropTypes were still mostly present in the bundles (both UMD and ES/CJS) despite the usage of the plugin babel-plugin-transform-react-remove-prop-types. As opposed to React InstantSearch, there's no reasons to expose PropTypes in our bundles. This PR aims at removing those.

For the UMD bundle, I introduced the ignore Rollup plugin to ignore the prop-types package.
For the ES/CJS bundle, I added { removeImport: true }, which defaults to false, to remove all traces of prop-types imports (see documentation).

This should result in a few kilobytes saved.

Although the UMD is a bit smaller, the GZIP version seems to be a be bigger according to Bundlesize.

Did you look at the bundles themselves? It might just be decreased repetition. When looking with @tkrugg earlier I saw some more unexpected dependencies in the bundle

Yes, the bundles look fine regarding PropTypes. From what I understand, the only remaining PropTypes are the ones part of Preact internals.

It looks like the propTypes are part of the build because of Rheostat. We might want to also remove them from it to actually save some space.

@samouss You mean in preact-rheostat itself, right? That would be in a future PR.

@francoischalifour Yes. You want to merge even with the size increase?

I'm not exactly sure of the Bundlesize report but this is the actual result: after this PR, the bundle is slightly lighter.
Before the change
┌────────────────────────────────────────────────────┐
│                                                    │
│   Destination: dist/instantsearch.development.js   │
│   Bundle Size:  1.03 MB                            │
│   Gzipped Size:  79.8 KB                           │
│                                                    │
└────────────────────────────────────────────────────┘

┌───────────────────────────────────────────────────────┐
│                                                       │
│   Destination: dist/instantsearch.production.min.js   │
│   Bundle Size:  284.36 KB                             │
│   Gzipped Size:  78.96 KB                             │
│                                                       │
└───────────────────────────────────────────────────────┘

After the change
┌────────────────────────────────────────────────────┐
│                                                    │
│   Destination: dist/instantsearch.development.js   │
│   Bundle Size:  1.02 MB                            │
│   Gzipped Size:  78.52 KB                          │
│                                                    │
└────────────────────────────────────────────────────┘

┌───────────────────────────────────────────────────────┐
│                                                       │
│   Destination: dist/instantsearch.production.min.js   │
│   Bundle Size:  280.44 KB                             │
│   Gzipped Size:  77.67 KB                             │
│                                                       │
└───────────────────────────────────────────────────────┘

@samouss I updated the branch and this time, we can notice the bundle size decrease.


feat(design): add ability to theme the @daffodil/design library

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Currently, the colors and palettes of the design library are based on colors and styles that we've built out for the demo.
Issue Numbers
Fixes: #68
Fixes: #113
Fixes:  #151
Touches On: #111 #114 #146
What is the new behavior?
This is an initial attempt at refactoring out those styles into a consistent pattern where we can swap colors and styles as we'd like for different daffodil implementations.
Does this PR introduce a breaking change?
[x] Yes
[ ] No

I've moved the @section-divider and @cart-total mixins out of @daffodil/design into @daffodil/demo.
Additionally, I've added a few scss files under daffio/src/scss and foundation-demo/src/scss to help mediate the import layer between design and the two different projects. This is where you can add additional helper utilities and choose your theme colors/import them into components.
Dependent users will have to follow the same pattern, as I've removed the $primary $secondary and other related variables that were previously defined in @daffodil/design and used in @daffodil/foundation-demo / @daffodil/daffio.
Other information

@lderrickable @xelaint this is ready for review. I'm aware of a few minor edge cases that I have to resolve, but generally speaking, as this PR is large, I want to open it up for review early so that we can get some good feedback.

It's pretty complicated on the inside, but seems pretty straightforward from the outside, which I like. I think it definitely needs docs though

Could you put a WIP on this if it's still a WIP?

Could you put a WIP on this if it's still a WIP?

I don't think this is still WIP, I'd like to merge as is. If there are changes that need to be made, please let me know if there's something that's confusing/you don't like/needs changed.

I am also aware that this definitely needs a squash, so just in case, please do NOT merge until squashed.

I still feel like there should be more general documentation with how to use themeable. For someone just picking up @daffodil/design, I think it would be difficult to figure out how themeable should be used

@lderrickable I think the README for theming can wait until The Big Docs Update milestone? I think at this point, we have enough docs to cover the basics. This PR is getting too large, especially if I'm making additional style updates or creating new components, I'll have to redo theming for them if this PR is still WIP.

Ok that's fine. Though I think that all the docs are written except for the basics. In the future, especially for such a large feature, I'd really prefer that the basics were written so I can review the actual code better. It's helpful for me to understand what went through the coder's mind as he/she wrote it. Right now, it's pretty difficult to take a step back and understand how everything works

lgtm

@lderrickable @xelaint squashed, needs approval.


fix: create renamed template without reporting error

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes https://github.com/kubeclipper-labs/kubeclipper/issues/171
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Codecov Report

Merging #182 (c87ceef) into master (f4273e0) will decrease coverage by 0.04%.
The diff coverage is 0.00%.


[Qbittorrent] random ovpn is NOT used as advertised in changelog

Description
4.6.2_29 states in the changelog
Feat : if no ovpn is referred in the option, it will use a random one from the openvpn folder (from https://github.com/Trigus42/alpine-qbittorrentvpn)
but that's not the case

In fact it doesn't work even with config.ovpn in the addons_config folder. Apparently due to the log the file is now expected in /etc/openvpn? Has it moved again?
Reproduction steps
1) have ovpn file with different name than config.ovpn

Addon Logs
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn
Use --help for more information.
Options error: In [CMD-LINE]:1: Error opening configuration file: /etc/openvpn/config.ovpn

Architecture
No response
OS
No response

Hi, thanks! Indeed it seems there was an issue in the code checking if the folder contained *.ovpn files. I've fixed it.
Regarding your second point, the "/etc/openvpn/config.ovpn" is a relicate from an old way of working : the ovpn file is copied from its location to /etc/openvpn before it is modified so it doesn't affect the initial file... Actually I'll probably change that as it can be confusing for the users

Duplicate of https://github.com/alexbelgium/hassio-addons/issues/1150#issuecomment-1872550737


Fetch container status and stats summary metrics for init containers

What does this PR do?
This PR collects pod spec metrics and /stats/summary metrics for init containers and for pods that are still in a pending phase (likely because they have a running init container)
Motivation
https://datadoghq.atlassian.net/browse/CONS-6169
Additional Notes
See also https://github.com/DataDog/integrations-core/pull/17035
I have tested both with and without this change using the following pod:
apiVersion: v1
kind: Pod
metadata:
  name: kubelet-metrics
  namespace: default
  labels:
    admission.datadoghq.com/enabled: 'true'
spec:
  initContainers:
  - name: init
    image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 2m" ]
    imagePullPolicy: IfNotPresent
    resources:
      requests:
        memory: "10Mi"
        cpu: "20m"
      limits:
        memory: "12Mi"
        cpu: "30m"
  - name: init-longer
    image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 5m" ]
    imagePullPolicy: IfNotPresent
    resources:
      requests:
        memory: "15Mi"
        cpu: "10m"
      limits:
        memory: "20Mi"
        cpu: "15m"

  containers:
  - image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 60m" ]
    imagePullPolicy: IfNotPresent
    name: main
    resources:
      requests:
        memory: "30Mi"
        cpu: "35m"
      limits:
        memory: "35Mi"
        cpu: "40m"
  restartPolicy: Always

Timeline of test:
Rc 7, core (kubelet-metrics-core-before)
Deployed agent: 9:07am 3/14
Confirmed core check is running: 9:09am 3/14
Deployed pod: 9:10am 3/14
Deleted pod: 9:24am 3/14

After, core (kubelet-metrics-core-after)
Deployed agent: 9:42am 3/14
Confirmed core check is running: 9:43am 3/14
Deployed pod: 9:45am 3/14
Deleted pod: 9:59am 3/14

And I have collected the following metrics which represent a subset of metrics from the /pods, /stats/summary, and /metrics/cadvisor:

Before the change: Link

Here, no /pods or /stats/summary show up until 9:17am, which corresponds with the main container starting / init containers finishing. However, unlike the python version, /metrics/cadvisor metrics show up for the init containers already. This is because we already store tagger info for init containers, and the /metrics endpoints do not know that the container in question is an init container, they are just looking for tags by container id.
(note, the last 2 graphs in the image show a solid line, but that is an interpolation issue in the graph, they have the same gap in data. The window is also too close to other tests, which result in more data points showing up on the legend than are on the graph)
After the change: Link

Here, we see /pods and /stats/summary metrics showing up in addition to the other metrics. We also see data points show up for pending pods, and metrics that are not scoped to containers show up when the pod starts, instead of when the pod becomes ready
(same note as above, the last 2 graphs in the image show a solid line, but that is an interpolation issue in the graph, they have the same gap in data. The window is also too close to other tests, which result in more data points showing up on the legend than are on the graph)
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

deploy the agent to your local cluster, with the kubelet corecheck enabled:

datadog:
  confd:
    kubelet.yaml: |
      init_config:
        loader: core
      instances:
        - min_collection_interval: 20

deploy the test pod:

apiVersion: v1
kind: Pod
metadata:
  name: kubelet-metrics
  namespace: default
  labels:
    admission.datadoghq.com/enabled: 'true'
spec:
  initContainers:
  - name: init
    image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 2m" ]
    imagePullPolicy: IfNotPresent
    resources:
      requests:
        memory: "10Mi"
        cpu: "20m"
      limits:
        memory: "12Mi"
        cpu: "30m"
  - name: init-longer
    image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 5m" ]
    imagePullPolicy: IfNotPresent
    resources:
      requests:
        memory: "15Mi"
        cpu: "10m"
      limits:
        memory: "20Mi"
        cpu: "15m"

  containers:
  - image: alpine:latest
    command: [ "/bin/sh", "-c", "sleep 60m" ]
    imagePullPolicy: IfNotPresent
    name: main
    resources:
      requests:
        memory: "30Mi"
        cpu: "35m"
      limits:
        memory: "35Mi"
        cpu: "40m"
  restartPolicy: Always

Validate that:

kubernetes.ephemeral_storage.usage shows up when the pod starts up
kubernetes.memory.requests shows up for the 2 init containers
kubernetes.pods.running has a datapoint tagged with pod_phase:pending which corresponds to when the init containers are running
kubernetes.containers.running show up for the init containers

/merge


RustyCI managing itself

I should make a rusty-ci for rusty-ci

Rusty-CI now manages itself, and updates itself when a new release is pushed to the repository


Feature request: Consider making a Postgres 16 docker image

What's wrong?
and maybe deprecate v13

dup of #148 and #149


hotgluexyz taps have catalog capability, not properties

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2773
Originally created by @DouweM on 2021-05-31 15:32:58

This prevents stream selection on these taps from working because the tap won't recognize the provided catalog.

View 3 previous comments from the original issue on GitLab


Rename project

Wincrementor is a bad name as it implies something windows related.
We should rename it to something better.
Best suggestion right now is:

Vincrementor

Change involves:

Rename repo on github
change filename of ruby file in the repository

plusbump :P


[WFRP4e System] Morrslieb button in light controls not working

Just updated to V10 and was trying out the system for an upcoming game. I noticed that Morrslieb button in the light controls no longer changes the scene green. I am not sure if it did anything else in the pas but nothing appears to happen currently. From: Joseph#8010foundry: 10.284wfrp4e: 6.1.2

Curiously, in my tests it worked if the FX Master module is activated, but not without the module.


TrackJS, "config.trackAjaxFail: property not supported."

 config.trackAjaxFail: property not supported. is output in the console in production, which is set here.
Looking at TrackJS docs there is no such setting (and none mentioned in the changelog either), but there is a network setting that seems to be something on similar lines:

Whether TrackJS should wrap and watch AJAX calls. If disabled, network events will not appear in your Telemetry Timeline.

This is enabled by default, do we want this to be set to false then?

@CartoDB/frontend what is the "correct" setting we should have here?

...or if you prefer we could tackle this as part of #2658 ?

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.