Fix #513: Exclude properties with reserved names.

Instructs the fuzzer to treat properties with reserved names as properties instead of meta keywords that guide test generation. For example, a property called 'required' should be seen as a property and not the list of required properties on an object.

Sure. #513 actually has some reproductions in there to show what the problem is.
Let's say you have an object that looks like this:
{
  "passwordRules": {
    "maxLength": 40
  }
}

When you create the OpenAPI schema for that object, you end up with
{
  "type": "object",
  "properties": {
    "maxLength": {
      "type": "number"
    }
  }
}

That sort of thing.
The fuzzer was looking at the property name maxLength and interpreting that as a restriction maxLength. Then it'd try to read the info about the max length of properties (which doesn't make sense) and explode because that's not what it's for.
What this does is it tells the fuzzer, "If what we're looking at is a property name, don't treat it like a restriction to fuzz against."
For a crazy test, maybe you have an object like this:
{
  "passwordRules": {
    "maxLength": "forty"
  }
}

Then your schema would look like:
{
  "type": "object",
  "properties": {
    "maxLength": {
      "maxLength": 10,
      "type": "string"
    }
  }
}

The outer maxLength is the name of the property, the inner maxLength is the constraint to fuzz against.
Anyway, this PR fixes that - it disambiguates the constraints from property names.
Does that help?


in need of a tip to get login working for me.

Hello,
i installed and started react-portal and react-portal-server as described.
on the first request:
http://localhost:3090/api/actions?project=all&language=en
i get a 401 (Unauthorized).
i did not change index.js or config.js.
i also did not create any database (just started mongod)
could you give me a hint where to look for further reading / a tip to resolve this.
(answer could also help others that try to get it running the first time :-) )
Thx in advance

I will complete the documentation tonight to be sure that everything is still working when you starts with an empty database.

try to test the API without the UI with Chrome PostMan. It's the best way to debug things like that with an REST API

every request to the API needs a token. The token is retrieve when you "signup" the first time and when you "signin" after that.

probably that you have to create somes tables to setup the user security. see the react-portal-server / controllers / action.js flle (Right and Role), but I don't think that the error is coming from there.

I will send you more information later.
Thanks

I did the test and It worked for me with an empty database.

I added into the documentation to create the folder c:\data\db, because mongodb is putting the database there
you don't have to create tables for security, because the security for actions is not activated by default

=> Don't forget to : 'signup' the first time. After that you use "signin"
When you signed up :

create a new Dashboard
add widgets to the current Dashboard
add todo
etc.

I hope it will help you
Thanks

Note: the widget "todo" is broken, use the 'helps' widget, this one is a test with ag-grid and it's working.

i tested with a simple mongod and with mongod --config /usr/local/etc/mongod.conf
the first 2 requests i get are:
[nodemon] starting node index.js
Server listening on: 3090
::1 - - [14/Jun/2016:20:50:32 +0000] "OPTIONS /api/actions?project=all&language=en HTTP/1.1" 204 - "http://localhost:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36"
::1 - - [14/Jun/2016:20:50:32 +0000] "GET /api/actions?project=all&language=en HTTP/1.1" 500 2164 "http://localhost:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36"
/api/actions check for authorisation and gives the Unauthorized
i am not getting the UI to do a signup, client console is:
bundle.js:29676[mobx] Deprecated: extras.SimpleEventEmitter is deprecated and will be removed in the next major releasedeprecated @ bundle.js:29676SimpleEventEmitter @ bundle.js:29636mrFactory @ bundle.js:30861(anonymous function) @ bundle.js:31051(anonymous function) @ bundle.js:31057__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:30730__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:30092__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:27374__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:27327__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:27178__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:25917__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:25787__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:59__webpack_require__ @ bundle.js:20(anonymous function) @ bundle.js:40(anonymous function) @ bundle.js:43
bundle.js:27312action auth_check_token Object {type: "auth_check_token"}
bundle.js:27312action auth_set_authorizations Object {type: "auth_set_authorizations"}
:3090/api/actions?project=all&language=en:1 GET http://localhost:3090/api/actions?project=all&language=en 401 (Unauthorized)
bundle.js:27312 action auth_error Object {type: "auth_error", payload: "Unauthorized"}
(looking further into this, (took a look at the Udemy course to get more jwt knowledge))

patched auth_store.js:
const token = localStorage.getItem('token')
if (false/token/) {
const name = localStorage.getItem('name')
transaction( ()
gives me an initial screen
seems localstore return a token somehow
its late for me i'm getting some sleep

Thank you for your patience and to have found the problem. I have actually tested only on Windows. In the future I will do some test with a mac environment to catch this kind of bug.
.

from my view you may close this issue.


ERROR: ON CONFLICT DO UPDATE command cannot affect row a second time (SQLSTATE 21000)

Hi guys, today I am testing gorm (gorm.io/gorm v1.23.8 // indirect) upsert and getting this error below. Is this fixed already? How can avoid it?
ERROR: ON CONFLICT DO UPDATE command cannot affect row a second time (SQLSTATE 21000)
My code
	err := database.db.Clauses(clause.OnConflict{ 		Columns:   []clause.Column{{Name: "sku"}, {Name: "country"}}, 		DoUpdates: clause.AssignmentColumns([]string{"quantity"}), 	}).CreateInBatches(&products, 5000).Error
type Product struct { 	gorm.Model 	Sku      string gorm:"index:,unique,composite:myname"	Country  stringgorm:"index:,unique,composite:myname" 	Name     string 	Quantity int }

Never mind, just removed duplicated values from array

@jolienai How did you end up removing the duplicate values?

I just write the deduplicated method here  https://github.com/jolienai/go-products-api/blob/main/cmd/app/jobs/product_bulk_job.go#L60


Paste image in clipboard to an image file

Description of the new feature / enhancement
Add a tool to export clipboard images to image files. Available in File Explorer or Open dialog. Having a quick shortcut would be better.
Scenario when this would be used?
When I open the Open dialog to select an image file, I may need to choose an image from the clipboard. It would be nice to have a way to export the clipboard image to a file so that I can select it faster.

Supporting information
No response

/dup #3098


[Chart] Adding manila helm chart

What is the purpose of this pull request?:
Adding manila service support for openstack-helm.
What issue does this pull request address?:
Issue#178
Notes for reviewers to consider:
None
Specific reviewers for pull request:
@intlabs @alanmeadows @v1k0d3n @larryrensing

Thanks for this work @stannum-l.  We'll file a blueprint once we're in OpenStack to track this work going forward.  Until then, we'll leave this PR open for you to reference after that point.

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm


Allow user to reveal their seed phrase

Story
As a user
I want to be able to retrieve my seed phrase after creating a wallet
So that I can easily import my wallet elsewhere or recover the phrase if I've lost access to other backups
Acceptance Criteria

[ ] I can click a button/menu item to recover the seed phrase for any of my wallet stored in Vega Wallet for Browsers
[ ] I must enter my password before the seed phrase is shown to me
[ ] I can click to copy the seed phrase

Tasks

[ ] Detailed sketch
[ ] Visual design
[ ] Frontend tasks:

[ ] Implement UI
[ ] Integrate with backend
[ ] Write unit tests

[ ] Backend tasks:

[ ] TBC
[ ] Write unit tests

[ ] Write end to end tests
[ ] Code review
[ ] Team verify acceptance criteria met
[ ] Exploratory QA testing
[ ] Capture bugs and new edge cases in tickets (this one or new TBD)
[ ] Write automated regression tests for the A/Cs (expanding on A/Cs where possible)
[ ] Add story and A/Cs to spec doc
[ ] Review with stakeholders
[ ] Release

Sketch
Notes

We can export the private key now ... do we also need the seed phrase?


Details and implementation steps needed to try out in a sandbox environment

Need details and Implementation Blue prints to try out in a sandbox environment.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f6e327d-b280-a35c-2588-87a19ac2a4ba
Version Independent ID: fa9b0713-771f-4792-979a-2f7a4f4445a2
Content: Microservices with AKS - Azure Solution Ideas
Content Source: docs/solution-ideas/articles/microservices-with-aks.md
Service: architecture-center
Sub-service: solution-idea
GitHub Login: @adamboeglin
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#223210

@vikramdarade a slight variant of this Solution Idea is at https://docs.microsoft.com/en-us/azure/architecture/reference-architectures/microservices/aks.  This Reference architecture has the Reference Implementation at https://github.com/mspnp/microservices-reference-implementation.  Closing this issue and will keep the internal DevOps bug open to ensure your request feedback is captured.


Add null check for customer password

Signed-off-by: Jelle Deneweth<EMAIL_ADDRESS>1. Why is this change necessary?
The customer password is null or string. The password_verify requires a string as second parameter so errors can occur while checking the customer password. If it is null there is an Uncaught PHP Exception possible.
2. What does this change do, exactly?
Add extra check before the call to the password_verify
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

:thinking:
only guest customers should have no password. how could it happen, that there is a normal customer without a password?

:thinking:
only guest customers should have no password. how could it happen, that there is a normal customer without a password?


Improvement request - play music via stream URL

Me again.... I wonder if this is possible, or something that could be added?
According to https://developer.amazon.com/blogs/post/Tx1DSINBM8LUNHY/new-alexa-skills-kit-ask-feature-audio-streaming-in-alexa-skills,
It's possible to get Alexa to stream from a URL - intended for skills, but as your routine exposes a lot of the internal of skills, I wondered whether it a possibility to get Node Red to play a URL stream.
Wouldn't that be nifty?

That would be great, but i don't see a way to access this feature.
Whatever is accessible in the Alexa web interface or app could be added but this is not.
Note that SSML should already be able to do this (#17) but it is not enabled by Amazon for the way we use it.

Shame!
Thanks anyway!
On Fri, 10 Apr 2020 at 20:25, 586837r<EMAIL_ADDRESS>wrote:

That would be great, but i don't see a way to access this feature.
Whatever is accessible in the Alexa web interface or app could be added
but this is not.
Note that SSML should already be able to do this (#17
https://github.com/586837r/node-red-contrib-alexa-remote2/issues/17)
but it is not enabled by Amazon for the way we use it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/586837r/node-red-contrib-alexa-remote2/issues/119#issuecomment-612181864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENIQ2LUFK2V6235AOQZJTLRL5XEFANCNFSM4MFQ56KA
.

FYI  This link seems to explain the limitations  on audio.  It mentions
that you can stream as long as the audio meets the limitations, but the
limitations are certainly limited....
https://developer.amazon.com/en-US/docs/alexa/custom-skills/speech-synthesis-markup-language-ssml-reference.html#audio-specs
On Fri, 10 Apr 2020 at 20:25, 586837r<EMAIL_ADDRESS>wrote:

That would be great, but i don't see a way to access this feature.
Whatever is accessible in the Alexa web interface or app could be added
but this is not.
Note that SSML should already be able to do this (#17
https://github.com/586837r/node-red-contrib-alexa-remote2/issues/17)
but it is not enabled by Amazon for the way we use it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/586837r/node-red-contrib-alexa-remote2/issues/119#issuecomment-612181864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENIQ2LUFK2V6235AOQZJTLRL5XEFANCNFSM4MFQ56KA
.


Chunked downloading is broken in >1.12

Try this code snippet:
import urllib3

http = urllib3.PoolManager()
r = http.request('GET', 'http://www.nyaa.se/?page=download&tid=818605')
for chunk in r.stream():
    print len(chunk)

on urllib 1.12, the output is:
(r)~  Δ python t.py
3862
5535
4150
3813

on urllib 1.13 and newer releases (every release, also master):
(r)~  Δ python t.py
Traceback (most recent call last):
  File "t.py", line 7, in <module>
    for chunk in r.stream():
  File "/Users/ibrahim/.virtualenvs/r/lib/python2.7/site-packages/urllib3/response.py", line 353, in stream
    for line in self.read_chunked(amt, decode_content=decode_content):
  File "/Users/ibrahim/.virtualenvs/r/lib/python2.7/site-packages/urllib3/response.py", line 502, in read_chunked
    self._update_chunk_length()
  File "/Users/ibrahim/.virtualenvs/r/lib/python2.7/site-packages/urllib3/response.py", line 448, in _update_chunk_length
    line = self._fp.fp.readline()
AttributeError: 'NoneType' object has no attribute 'readline'

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35457528-chunked-downloading-is-broken-in-1-12?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github).

Woot thanks for the great reproduction case. So we're releasing the connection in urllib3.connectionpool because you're not specifying preload_content=False. I wonder what changed in 1.12 that caused that to fail like this.

I bet we're preloading the content, but since we only check if the response is chunked, we don't ever expect the case where preload_content=True.

And I bet this is all my fault. :(

So we really do expect you to specify preload_content=False to stream a chunked response. That said, we can fix this, I'm just not sure we either should or will want to. A POC is up on #908.

Alright, thanks for the quick reply and the suggestion. I've been bitten by this on a production code, which uses python-requests module (2.10.0), and it uses urlllib3 (1.15.1).
I guess it's fair to mention @kennethreitz about the issue. Should I file a bug for requests as well @kennethreitz ?

@igungor requests should be immune to this. Also 2 of the cores here (@Lukasa and me) are also maintainers of requests, so no need to file a bug there. What code do you have on requests that reproduces this?

Woah.
Your bug @igungor comes from initializing two separate iterators over the body. Do not do that. Use one, and repeatedly call next on it. The generator that produces the body includes quite a lot of internal state, and if you create two of them they will absolutely step on each others' toes.

@sigmavirus24 i edited my previous comment.
@Lukasa you're right, it was my bad. the code I sent is not actually on production. The production code was calling iter_content(1000000).next() once, and assuming the downloaded chunk was <=1000000 bytes.
Thanks for the quick replies guys.

So there is a bug in urllib3 in a very narrow corner case, but it's not the source of your problem with urllib3 @igungor


Upgrading ESLint Peer Dependency

We are now using ESLint 5 regularly.  Anything preventing you from upgrading or at the very least upgrading the peer dependency to include both?

done @RyanMulready

Nice.

I am still having an issue since<EMAIL_ADDRESS>only supports<EMAIL_ADDRESS>|| ^4.0.0. Can we upgrade to<EMAIL_ADDRESS>


This is not responsive

It is not mobile friendly but it works like a charm on PC .
Check this link for demo : https://sroze.github.io/ngInfiniteScroll/demo_async.html

This issue is too vague


Fix uniqueName generation problem

Fix issues: https://github.com/alibaba/lowcode-engine/issues/459

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.周炜 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Documentation/0 11

What this PR does / why we need it:
Document how Syna works and how to use it
Which issue this PR fixes:
fixes #125, #126, #128
Release note:
Documentation

@stp-ip I finally did the requested changes and also added some more stuff in contribution guide.


Skips docker's interfaces

The valid IP can be used for communicating w/ docker and w/ the outside, which is probably what you want when developing

@dsyer @adriancole @marcingrzejszczak This pains me that I wrote this as a static method. I'd like to make the interfaces to skip configurable. Should I add a parameter that takes a configuration properties object, or move this to a bean? As I type the question, the answer seems to me to move it to a bean if I'm going to make it configurable.

Yep. It's not too late for 1.1.0. The ship has sailed on Brixton.M4 I think (so please don't change the architecture in anything that depends on commons till after that).

@dsyer will do.

Closing in favor of #75. Thanks for getting the ball rolling on this.

So this won't go into Brixton at all?


Can you load a local file video without an input?

Hello,
I'm trying to make a component where the video has been preloaded and will automatically show the video. The video is stored locally in the project under a folder called assets. The only way I've seen to use local files so far is by using a  with type = file. I do not want to do this and would rather have the video be there on page load. Is there a way to do this? My current code is below:
App.js related code:
//Route to where the video is
<PrivateRoute path="/sample_video" render={(props) => (<Video videoFilePath="../assets/videoplayback.mp4" {...props} />)} />
Actual component code:
const Video = (props) => {
    //useState for video to be converted to URL
    const [videoFilePath, setVideoFileURL] = useState(props.videoFilePath ? props.videoFilePath: null);

    return(

            {/*If video loads correctly, show video. Else, display error message*/}
            {videoFilePath && <ReactPlayer url={videoFilePath} controls="true" />}
            {!videoFilePath &&
Video failed to load. Please try again.
}

    )
}

Any advice on this would be greatly appreciated

Your video has to load from somewhere. It can be "stored locally in the project" but needs to exist on a web server somewhere when deployed. If your current route is https://example.com/sample_video and you are rendering url='../assets/videoplayback.mp4' (as per your example) then the video needs to be at https://example.com/assets/videoplayback.mp4.


Add support for define 2.0

AC

Version of define.xml is extracted from the define.xml file. This will come from:
/ODM/Study/MetaDataVersion/def:DefineVersion
Define ODM components will be loaded according to the version. At a minimum, we should support define versions 2.0 and 2.1

Implementation details
There should be an abstract base class for the common define.xml components.
Each version of the define.xml should have its own concrete class that overrides version-specific functionality.
Add following test cases to test_define_xml_reader.py test_define_variable_is_collected:
test_define_2_0_file_path: str = (
    f"{os.path.dirname(__file__)}/../resources/test_defineV20-SDTM.xml"
)

        (
            test_define_2_0_file_path,
            "AE",
            "AEACN",
            True,
        ),
        (
            test_define_2_0_file_path,
            "AE",
            "AEBODSYS",
            False,
        ),
        (
            test_define_2_0_file_path,
            "LB",
            "LBCAT",
            False,
        ),

The review for this issue is over. The changes are according to the Acceptance Criteria. The code gets the define xml version from /ODM/Study/MetaDataVersion/def:DefineVersion and ODM components are loaded according to the version. We have separate concrete class for each version and one common abstract base class. This meets with the AC hence passing from QA review.
Following screenshot shows the successful test runs for the changes.

Validation Summary
Validation Methodology:
The validation process incorporated rigorous testing methodologies to ensure the accuracy and reliability of the system. This included:
Unit Testing:
Unit Testing was done to verify the implementation of the Acceptance criteria. All those tests were then run using pytest to verify compliance with acceptance criteria.
Code Review:
The code changes in the code files were reviewed and were found to be in accordance with the Acceptance criteria. Also, the code was reviewed for following:

Code Quality Evaluation
Logic and Functionality Review
Error Handling and Exception Handling Assessment
Security Considerations

Regression Testing:
Regression tests were run to validate that the changes did not affect any functionality of the overall system.
Test Execution:
Following Tests cases were checked against the updated code

Test Name
Description
Expected Result
Status

test_init_from_filename
Verify if DefineXMLReader can be initialized from a filename
Instance of BaseDefineXMLReader
Passed

test_init_from_file_contents
Verify if DefineXMLReader can be initialized from file contents
Instance of BaseDefineXMLReader
Passed

test_read_define_xml
Verify if DefineXMLReader can read define.xml contents
List of dictionaries containing metadata
Passed

test_extract_domain_metadata
Verify if DefineXMLReader can extract domain metadata
Dictionary containing domain metadata
Passed

test_extract_variable_metadata
Verify if DefineXMLReader can extract variable metadata
List of dictionaries containing variable metadata
Passed

test_extract_variable_metadata_with_has_no_data
Verify if DefineXMLReader can correctly handle variables with no data
Variable metadata indicates no data
Passed

test_define_variable_is_collected
Verify if DefineXMLReader can determine if a variable is collected
Boolean value indicating if variable is collected
Passed

test_extract_value_level_metadata
Verify if DefineXMLReader can extract value level metadata
List of dictionaries containing value level metadata
Passed

test_extract_domain_metadata_not_found
Verify if DefineXMLReader raises an exception for a missing domain
DomainNotFoundInDefineXMLError exception is raised
Passed

test_validate_schema
Verify if DefineXMLReader can validate the schema of define.xml
True if schema validation passes
Passed

test_extract_variable_metadata_not_found
Verify if DefineXMLReader raises an exception for a missing domain in variable metadata
DomainNotFoundInDefineXMLError exception is raised
Passed

’
’
Results:
After successful running of unit, manual and regression tests and careful validation, the issue was found to be good to close as the Acceptance criteria was fulfilled and all validations passed.
Deviations and Non-conformances:
No deviations or non-conformances were observed.
Summary of Findings:
Test Results: All tests conducted during the validation process passed successfully, indicating that the system functions as intended and meets the specified requirements. The tests covered various scenarios and edge cases, providing confidence in the system's reliability and correctness.
Unit Regression: The unit regression tests were executed, and no regressions or issues were identified. This indicates that the changes made during the development or modification of the system did not introduce any unintended side effects or break existing functionality.
Code Reviews: The code reviews conducted by both development and QA teams were completed, and no major issues or concerns were identified. The code adheres to coding standards and best practices, demonstrating good code quality, readability, and maintainability.


Merge refs/heads/fix/body-errors into alpha

Merge refs/heads/fix/body-errors into alpha

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

This PR has not been merged into alpha. Please fix the issues and re-open the PR.


FacetSet::build incompatible with parent build function

Hey
I am seeing the following issue after updating Solarium from git today:
Runtime Notice: Declaration of Solarium_Client_RequestBuilder_Select_Component_FacetSet::build() should be compatible with that of Solarium_Client_RequestBuilder::build() in /Users/Punk/Sites/github/Sought/Symfony/vendor/solarium/library/Solarium/Client/RequestBuilder/Select/Component/FacetSet.php line 0
As far as I can tell the FacetSet::build takes a second arg $request, but the parent RequestBuilder::build does not.
Is this a regression?
Cheers

Hm, it seems my project, despite pulling from https://github.com/basdenooijer/solarium.git is getting the nextgen/feature branch.

Ok, the feature/nextgen branch isn't stable yet, but I'll fix this one asap.

I couldn't reproduce this in the feature/nextgen branch. Lookup at the non-namespaced classnames in your error I think you might be using the develop branch. This branch did have an issue. I've added a fix.

Thanks I was on the wrong branch


stellar clients get_balance shows accounts where being a cosigner as an escrow account

Locked balances:
     - Free to be claimed on escrow account GA47YZA3PKFUZMPLQ3B5F2E3CJIB57TGGU7SPCQT2WAEYKN766PWIMB3
        - 9991.9990600 XLM

whats the status of this @xmonader @robvanmieghem  is it sill valid? I'm doing a clean up. thank you

@sasha-astiadi yes, this is still valid


Fix notebooks

Coverage remained the same at 90.159% when pulling 18d7d6c15e0c6f14504aef79c15ec2ba9c51d275 on develop into 7aef8a34d82911635ebc8893828bc5de1a49a565 on master.


Add unique test id's to C binding tests

Signed-off-by: Simon Hoinkis<EMAIL_ADDRESS>Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Notes for Reviewer

Add unique test id's to C binding tests

Checklist for the PR Reviewer

[x] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior

[x] Each unit test case has a unique UUID

[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #988

@mossmaurice I am back from vacation and did not catch up on all the stuff you accomplished in the last two weeks. So as a naive question. How can I add test ids as a standard open source contributor?

@elfenpiff

I am back from vacation and did not catch up on all the stuff you accomplished in the last two weeks. So as a naive question. How can I add test ids as a standard open source contributor?

That's described in a new section in the CONTRIBUTING.md. We can see in future if we need more automation for that. For sure we should implement #1020 to check for duplicate UUIDs.
cc @dkroenke


Add main field specifier on CLI

changes:

We can define main field when generating content from CLI by adding * before the field name.
Update method to parse field, name, and json tag. Now handle * prefix for defining main field.
Update content template to dynamically change the field used on String() methos

Hey @junnotantra I'll have chance to look at this towards the end of this week.

Thanks @olliephillips - I will take a look through this one before it goes to master. I don't like the use of * as a possible risk of expansion when the shell interprets is (though we just take this as a string in Go), I'm just not sure about the behavior.
Maybe another character would be acceptable.. I'll do some testing

@nilslice no problem, that's why we have this workflow I guess :)
Keep me in the loop - I can test further if needs be, as I have the ponzu built on this feature at the moment.


Accidentally deleted my publisher

From @stoneC0der

I was having issue when trying to upload my extension, the error was the JSON output below
{"$id":"1","customProperties":{"Descriptor":null,"IdentityDisplayName":null,"Token":null,"RequestedPermissions":0,"NamespaceId":"00000000-0000-0000-0000-000000000000"},"innerException":null,"message":"Access Denied: The Personal Access Token used has expired.","typeName":"Microsoft.VisualStudio.Services.Security.AccessCheckException, Microsoft.VisualStudio.Services.WebApi","typeKey":"AccessCheckException","errorCode":0,"eventId":3000}
After some googling I decided to look at vsce help from the terminal to found additional command I was not familiar with, one of these was to list all publisher, logout and delete
I mistakenly created several publishers but the issue was that the original theme was StoneC0der but I at some point created a PAT using the wrong spelling instead of StoneC0der I had Stonec0der & stoneCoder.
Since I couldn't not figure out the correct publisher ID (which I did later on but too).
I decided to logout all publishers and then was tempted to delete them since I was now getting error like this:
Error: Access Denied: <sometoken was here> needs the following permission(s) on the resource /StoneC0der to perform this action: View user permissions on a resource
Unfortunately (did not expected it but feel natural) my extension was gone from the market place.
I created a publisher with the same ID and had to republish the extension
My question is, is everything really lost?
I notice that after publishing the extension et searching for it from vscode show me the install button and all the metrics are gone.
Basically it seams that those who using it will not see this update, site like vscodethemes still show the theme with their own metric but point to the newly published theme.
I guess what I want to know if it possible to get the metrics back (really don't think it possible but just hope) and how to notify users about this unexpected change.
Thanks and sorry I sound confusing

Accidently deleted my published extension, is there anyway to recover it?

Looks like no, I had to create a new one with the same info and republish my extension, the issue with this is that the stats are lost and the current users of the extension won't see any update unless they manually check.

Yes. Maketplace team helped us to unlock the id, and we could update the new one with same ID as well.
Thank all guys.

No action planned here. Best is to always contact marketplace


Minor Documentation Issue

It states in networking lab (Step 4: Test the network) that after we ran two services and ping one from another there is 100% packet loss. The output of ping command is shown after words "Now, lets ping <IP_ADDRESS>.".
I believe the output should be opposite, something like "5 packets transmitted, 5 received, 0% packet loss, time 3997ms".

Can you please open this issue here: https://github.com/play-with-docker/play-with-docker.github.io. This repo is for the PWD code, it doesn't hold the interactive tutorials.

Ok, thanks.


Nested lists

I tried to implement a nested list by example and found that it does not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d1ba3c8-db60-fcd0-7bff-2801091ca0cb
Version Independent ID: 01991ce1-d2db-3c90-3d04-ac0895b4ff55
Content: Markdown format - QnA Maker - Azure Cognitive Services
Content Source: articles/cognitive-services/QnAMaker/reference-markdown-format.md
Service: cognitive-services
Sub-service: qna-maker
GitHub Login: @diberry
Microsoft Alias: diberry

Specifically does not work Example markdown (incorrectly displayed) but the Format works.

Understood, this format does not work if the bot is deployed for Telegram.
Is there any other option for forming a nested list so that it works for the mentioned channel?

@sokiable we will review your feedback and get back to you shortly. Thanks.

@sokiable I don't clearly understand the issue you are describing. Can you please clarify the issue and provide examples (screenshots would be helpful). Thanks.

@sokiable since this isn't a dog bug, I recommend you use one of these avenues to get the answers you need. Feel free to consult BotBuilder issues in GitHub for information about known issues with the Bot Framework SDK, or to report a new issue.  I will now proceed to close this thread. Thanks.


Improve todo detekt rule

What does this PR do?
Improve our detekt rule around TODO comments:

Ensure we catch all TODO comments
Ensure we don't use the TODO RUM-0000 trick to not create a ticket in our backlog
Update the old referenced tickets (RUMM and REPLAY) with the new RUM prefix

Codecov Report

Merging #1955 (03d8d4e) into develop (5e76858) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1955      +/-   ##
===========================================
- Coverage    83.26%   83.21%   -0.05%
===========================================
  Files          486      483       -3
  Lines        17586    17572      -14
  Branches      2605     2605
===========================================
- Hits         14642    14622      -20
- Misses        2248     2252       +4
- Partials       696      698       +2

Files
Coverage Δ

.../main/kotlin/com/datadog/android/_InternalProxy.kt
63.64% <ø> (ø)

...ain/kotlin/com/datadog/android/core/DatadogCore.kt
83.85% <ø> (ø)

...n/com/datadog/android/core/internal/CoreFeature.kt
86.69% <ø> (ø)

...tadog/android/core/internal/NoOpContextProvider.kt
3.45% <ø> (ø)

...in/com/datadog/android/core/internal/SdkFeature.kt
91.55% <ø> (ø)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
93.94% <100.00%> (+0.06%)
:arrow_up:

...e/internal/net/info/CallbackNetworkInfoProvider.kt
95.24% <ø> (ø)

...droid/core/internal/persistence/AbstractStorage.kt
100.00% <ø> (ø)

...al/persistence/file/batch/BatchFileOrchestrator.kt
94.94% <ø> (ø)

...roid/core/internal/user/DatadogUserInfoProvider.kt
100.00% <ø> (ø)

... and 34 more

... and 15 files with indirect coverage changes


Fix gen proto script for proto/v2.2 pkg

fix script does not rectify service package name and missing new proto replacement

/kind improvement


Remove unnecessary Write as _fmtWrite

We can bring the Write trait into scope, no need to underscore it.
Done as part of the MSRV checklist.

Is {Write as _} not available in this Rust version? I mean just importing is possibly better, but I wonder why just _ was not used originally.

@dpc _ is not allowed in 1.29 but is in 1.41.1, no idea about the exact version where it was introduced.

At first I had the intention of doing use Write as _ but the code builds without as _ so I went with that. Is there any technical reason to us as _ if the code builds without it i.e., there is no namespace clash?


Design and implement About Page.

References :

Flowbite-react
Figma Cummunity
React icons
Tailwind CSS

#12
I hope this be enough for now ....

#24


what's UnrealPerson.tar in the data provided?

It contains all other tar files, simply a combination. Hope it brings convenience to you.

Thanks for your reply.


Pictures with high resolution looks ugly ....

Well, when i upload pictures with high resolution and see it through Lychee Interface the pictures looks ugly like you can see it here http://photo.dos-developers.com/#0/14593840738824
But when you open the file directly its more clear and everything which can be seen here : http://photo.dos-developers.com/uploads/big/206694900275cea8684e4f68a353c7a6.jpeg
Its like tooo sharp when seeing it through lychee ...
I dont know how to say (sorry my first language is german lol )
I hope you got me :')

It seems that the will-change CSS property is messing with the image. Removing it solve the bug but the image is still too sharp during transitions, the rendering is optimized for speed and not for quality.

What do you think what can fix it?

Fact: It depends on the browser and how it scales down the image. It looks much better in Safari and Firefox.
Chrome seems to do some magic when adding a composited layer around the image (that's what happens when using will-change). Removing will-change looks better in Chrome as @qligier said, but it still adds a composited layer during transitions. I wonder if there's another way to influence how the browser scales images down.
@Droidwall Fun fact: Ich stand ebenfalls an diesem Tag in Köln an der gleichen Stelle. Die Welt ist klein ;)

image-rendering sounds like a solution, but makes no difference in Chrome as optimizeQuality isn't supported, yet.

will-change cases Chrome to show rough edges all the time. Even during transitions.

Removing will-change cases Chrome to show rough edges during transitions only.

will-change hides all rough edges in Safari.

Removing will-change cases Safari to show rough edges during transitions only.

Weired i tested it on Firefox an the Image is perfect lol. Hmm changing it to will-change: initial; seems to fix that problem on Google Chrome weiired what  google is doing O.o. It seems even Chrome on Android has also same problem but changing will-change transform to initial fixes the problem weired.....
@electerious Ja die welt ist klein ich mache immer dort bilder ;)

The only problem is while the animation is working the image looks ugly then 1 Second after its perfect..

The initial value has the same effect as deleting the property.
In this article, it's recommended to add the property at the beginning of the animation and to remove it at the end with JS.
I think it's OK if the image looks more "crisp" during the animation, it helps the browser with processing load (it's a browser, not Photoshop). Looks like the best solution to me.
Let's hope the optimizeQuality value will be implemented (it's not standardized yet).

So i found a fix well its better to set the will-change:transform; After the animation which removes the ugly look...

In this article, it's recommended to add the property at the beginning of the animation and to remove it at the end with JS.

I don't think that makes a difference. Chrome seems to create a composited layer during the animation automatically (even without will-change: transform). Removing the property after the animation would have the same effect.
The best solution is to remove will-change: transform.

Fixed. Will be part of the next release.


Add information on linked list and complexity

This PR adds information on linked list and algorithm complexity
Fixes #7

Do not add direct explanations from Geeks for Geeks. Plagiarism counts as invalid/spam Provide a detailed explanation in your own words

Ok I will rephrase this.

Ok changes have been made, could you please review again and remove the invalid label. Thanks.


12197 geocoder rake saves to redis

Fixes #12197
I also reviewed all usages of Carto::Organization and Carto::User in all clouds, but I found no other affected rakes (all other uses are just getting a count of users, a list of ids or something similar, that does not save using the model).

I can do the acceptance, yes

CR and review
It works like a charm. I've tried 3 consecutive google geocoder private key updates and the value was properly updated in redis :ok:
$ /opt/carto/builder-tools/embedded/bin/carto-builder-ds-providers.sh google -c pepito -k pepito_key100 -yg

... Currently working on setting [geocoder] provider ...
[OK]: Successfully set [google] as [geocoder] provider

... Currently working on restarting builder service ...
[OK]: successfully restarted builder service

$ redis-cli -n 5 hgetall rails:orgs:organization
 1) "id"
 2) "94da1160-c0dd-4d50-adee-98e15c2edb77"
 3) "geocoding_quota"
 4) "0"
 5) "here_isolines_quota"
 6) "0"
 7) "obs_snapshot_quota"
 8) "0"
 9) "obs_general_quota"
10) "0"
11) "mapzen_routing_quota"
12) ""
13) "google_maps_client_id"
14) "client=pepito"
15) "google_maps_api_key"
16) "pepito_key100"
17) "period_end_date"
18) "2017-05-25 11:48:02 +0000"
19) "geocoder_provider"
20) "google"
21) "isolines_provider"
22) ""
23) "routing_provider"
24) ""

$ /opt/carto/builder-tools/embedded/bin/carto-builder-ds-providers.sh google -c pepito -k pepito_key101 -yg

... Currently working on setting [geocoder] provider ...
[OK]: Successfully set [google] as [geocoder] provider

... Currently working on restarting builder service ...
[OK]: successfully restarted builder service

$ redis-cli -n 5 hgetall rails:orgs:organization
 1) "id"
 2) "94da1160-c0dd-4d50-adee-98e15c2edb77"
 3) "geocoding_quota"
 4) "0"
 5) "here_isolines_quota"
 6) "0"
 7) "obs_snapshot_quota"
 8) "0"
 9) "obs_general_quota"
10) "0"
11) "mapzen_routing_quota"
12) ""
13) "google_maps_client_id"
14) "client=pepito"
15) "google_maps_api_key"
16) "pepito_key101"
17) "period_end_date"
18) "2017-05-25 11:48:02 +0000"
19) "geocoder_provider"
20) "google"
21) "isolines_provider"
22) ""
23) "routing_provider"
24) ""

$ /opt/carto/builder-tools/embedded/bin/carto-builder-ds-providers.sh google -c pepito -k pepito_key102 -yg

... Currently working on setting [geocoder] provider ...
[OK]: Successfully set [google] as [geocoder] provider

... Currently working on restarting builder service ...
[OK]: successfully restarted builder service

$ redis-cli -n 5 hgetall rails:orgs:organization
 1) "id"
 2) "94da1160-c0dd-4d50-adee-98e15c2edb77"
 3) "geocoding_quota"
 4) "0"
 5) "here_isolines_quota"
 6) "0"
 7) "obs_snapshot_quota"
 8) "0"
 9) "obs_general_quota"
10) "0"
11) "mapzen_routing_quota"
12) ""
13) "google_maps_client_id"
14) "client=pepito"
15) "google_maps_api_key"
16) "pepito_key102"
17) "period_end_date"
18) "2017-05-25 11:48:02 +0000"
19) "geocoder_provider"
20) "google"
21) "isolines_provider"
22) ""
23) "routing_provider"
24) ""

Merging it then, thanks! 🤗


Move sklearn to end of requirements.txt

drain version: Installed 2017-11-07
Python version: 2.7
Operating System: Old CentOS

Description
Install requirements.txt
What I Did
Installed each requirement one at a time, but did sklearn last

@geneorama what does this fix? is it still necessary in light of the success you had last week?

If python installs the dependencies in the order that they are presented, I would move sklearn to the end of the requirements.txt.
I think that was the main key to how we got the requirements installed, but I'm not 100% sure that it wasn't something else.

Changed in  af5bbec


[Feature]: Expose more information in JSON results when there is a suite-level error

🚀 Feature Proposal
Currently, when there are errors at the test suite (file) level the CLI prints something friendly and helpful like:
> jest --json --outputFile=tmp/jest.json --testLocationInResults --verbose

 FAIL  ./sum.test.js
  ● Test suite failed to run

    Cannot find module 'foobar' from 'sum.js'

    Require stack:
      sum.js
      sum.test.js

    > 1 | require("foobar");
        |                  ^
      2 |
      3 | function sum(a, b) {
      4 |   return a + b;

      at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:487:11)
      at Object.<anonymous> (sum.js:1:18)
      at Object.<anonymous> (sum.test.js:1:29)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.167 s
Ran all test suites.
Test results written to: tmp/jest.json

This is quite helpful while debugging what went wrong in the test, but when looking at the JSON results, I only see:
{
  "assertionResults": [],
  "coverage": {},
  "endTime":<PHONE_NUMBER>453,
  "message": "  \u001b[1m● \u001b[22mTest suite failed to run\n\n    Cannot find module 'foobar' from 'sum.js'\n\n    Require stack:\n      sum.js\n      sum.test.js\n\n    \u001b[0m\u001b[31m\u001b[1m>\u001b[22m\u001b[39m\u001b[90m 1 |\u001b[39m require(\u001b[32m\"foobar\"\u001b[39m)\u001b[33m;\u001b[39m\u001b[0m\n    \u001b[0m \u001b[90m   |\u001b[39m                  \u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[0m\n    \u001b[0m \u001b[90m 2 |\u001b[39m\u001b[0m\n    \u001b[0m \u001b[90m 3 |\u001b[39m \u001b[36mfunction\u001b[39m sum(a\u001b[33m,\u001b[39m b) {\u001b[0m\n    \u001b[0m \u001b[90m 4 |\u001b[39m   \u001b[36mreturn\u001b[39m a \u001b[33m+\u001b[39m b\u001b[33m;\u001b[39m\u001b[0m\n\n      \u001b[2mat Resolver._throwModNotFoundError (\u001b[22mnode_modules/jest-resolve/build/resolver.js\u001b[2m:487:11)\u001b[22m\n      \u001b[2mat Object.<anonymous> (\u001b[22msum.js\u001b[2m:1:18)\u001b[22m\n      \u001b[2mat Object.<anonymous> (\u001b[22m\u001b[0m\u001b[36msum.test.js\u001b[39m\u001b[0m\u001b[2m:1:29)\u001b[22m\n",
  "name": "[REDACTED PATH TO TEST FILE]",
  "startTime":<PHONE_NUMBER>453,
  "status": "failed",
  "summary": ""
}

Is there any interest in exposing more of the helpful text/context from the CLI message in the JSON payload? I might be able to spare some time to do this if so (it doesn't seem like a massively large undertaking - I believe we'd just have to expose a little more info in formatTestResult).
Motivation
We wrote a library which consumes Jest JSON and summarizes the information in the JSON results into a friendly message to help ease some of the pain of scrolling through CI logs to figure out what went wrong. This, however, is important information we'd like to show which we currently have no access to.
Example
No response
Pitch
While it's likely possible to expose a custom reporter to do this, it'd be challenging to otherwise maintain a 1:1 API with the existing JSON report as it's not implemented as a reporter today. If it was, we could likely call the original and augment with additional information.

Bump


Fix compilations errors and miscellaneous other cleanup.

The cdap-apps repo had gone outdated. Even though methods were deprecated in a previous release, the relevant code in these apps were not updated.
So, when the deprecated APIs got removed, these apps' test cases no longer compiled.
This Pull Request updates these apps to use the newer APIs and also does additional cleanup.

LGTM

This should first be merged to the release/cdap-3.2-compatible branch, and then merged to develop...
NLGTM....
:-1:

I've created a replacement PR for this: https://github.com/caskdata/cdap-apps/pull/98

:+1: Based on Ali's email, I thought that he was referring to changes that had gone in to 3.2.0. But that was not the case, as the changes were made in 3.3.0 (develop) and so this should go into develop.
If anything should happen, it's that the default branch for these repos should change from develop to the current release, so people don't start by building the wrong version...

Agreed. With @awholegunch 's last comment.


4:35

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/TinaLiuGirl/TinaTest, working directory: W:\3elo-s, target branch: master, target branch commit: 606fae235ceed8982d69b7b58223fbd519200ea6, source branch: Local4, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Docset4/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: PRMerger: Sign off requires successful build

You signed off, but the build has not completed or there are outstanding validation warnings. Please wait for the build to complete, and address any outstanding validation warnings. Then, you can sign off on the pull request.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Criterion
Description

Index File
This PR contains a change to the index file.

PRMerger Results

Issue
Resolution

Index File
This PR contains a change to the index file.


SwitchListTile Supports setting the switch size

Use case
SwitchListTile Supports setting the switch size
i can wrap SwitchListTile with Transform.scale, but the scale would be applied to entire widget, ie, to the text as well, that messes up the size of entire SwitchListTile widget,
This will affect the layout of the entire SwitchListTile. How can I only change the switch size
Proposal
SwitchListTile Supports setting the switch size

@laterdayi
Can you take a look at this issue and specially see Fixed Switch Size Example Code section in it to check if it helps in your case or not.
Also, see https://stackoverflow.com/a/74516693 to check if it helps or not.

@laterdayi Can you take a look at this issue and specially see Fixed Switch Size Example Code section in it to check if it helps in your case or not. Also, see https://stackoverflow.com/a/74516693 to check if it helps or not.

This is to set the size of the switch, but the switch icon size in switchListTile cannot be used this way

but the switch icon size in switchListTile cannot be used this way

See if this helps ?

This way I see it, but it doesn't solve the switch size problem, it only scales overall

Thanks for the update. Can you provide us a runnable code sample that shows current behavior / limitation and what change you would like to see in terms of expected behavior with proposed feature ?

import 'package:flutter/material.dart';

/// Flutter code sample for [AnimatedSize].

void main() => runApp(const AnimatedSizeExampleApp());

class AnimatedSizeExampleApp extends StatelessWidget {
  const AnimatedSizeExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ListView(children: [
          Transform.scale(
            scale: 0.6,
            child: Switch(
              onChanged: (value) {},
              value: true,
            ),
          ),
          SwitchListTile(
            title: Text('Test'),
            onChanged: (value) {},
            value: true,
          ),
          Transform.scale(
            scale: 0.6,
            child: SwitchListTile(
              title: Text('Test'),
              onChanged: (value) {},
              value: true,
            ),
          ),
        ]),
      ),
    );
  }
}

As shown in the image, I can make the 2 switch the same size as the 1 and keep the text from shrinking
@darshankawar

Thanks for the update.
I updated the code sample as below which made both switchListTile of same size:
body: ListView(children: [
          Transform.scale(
            scale: 1,
            child: Switch(

Thanks for the update.
I updated the code sample as below which made both switchListTile of same size:
body: ListView(children: [
          Transform.scale(
            scale: 1,
            child: Switch(

Thank you for your reply. You may misunderstand my meaning. What I expect is that the switch in SwitchListTile can be scaled to 0.8 like 1


Perform a challenge game test

Once #1000 is fixed, we need to

[ ] start mainnet agents again
[ ] for each of mainnet [Boba, Optimism]:

[ ] make a transfer request
[ ] make sure the request is filled by one of the agents
[ ] challenge the corresponding claim
[ ] check whether the agent responds to the challenge
[ ] make another challenge (within the same challenge game)
[ ] check whether the agent responds to the challenge
[ ] do not respond further, making the agent win the game eventually
[ ] wait for the results to appear on the source chain
[ ] check that the agent was able to withdraw

additionally we should test that the agent protect the protocol by challenging false claims

[ ] create a false.claim for existing request I'd
[ ] confirm that one agent challenged
[ ] after termination confirm that agent withdrew
(most likely the agent should already be able to withdraw once the tokens are withdrawn by the real filler)

testing non fill proof

[ ] shut down one agent
[ ] drain agents funds on boba roll up so that he is out of funds on boba
[ ] create a request he cannot fill
[ ] claim the request
[ ] confirm that agent created non fill proof
[ ] confirm that agent challenged claim

optionally

[ ] counter challenge until enough funds are raised
[ ] wait 7 days
[ ] confirm that agent resolved on L1
[ ] confirm that agent resolved claim
[ ] original user withdraws tokens from expired request

additionally we should test that the agent protect the protocol by challenging false claims

[ ]  create a false.claim for existing request I'd
[ ]  confirm that one agent challenged
[ ]  after termination confirm that agent withdrew
(most likely the agent should already be able to withdraw once the tokens are withdrawn by the real filler)

BOBA

[x] Request with id 48
[x] False claim
[x] Challenged by 0xf6bb6190f48dadf6b25f8d2b7a24ecb9b10c5abd
[ ] Termination of challenge - Fri Sep 16 2022 11:10:31 GMT+0200 (CEST)<PHONE_NUMBER>)
[ ] Confirm that agent withdrew

Optimism

[x] Request with id 32
[x] False claim
[x] Challenged by 0x61e01a8d1942b0efeaa4b52f06b7bf3a672478d899f16c9ae0cdaaf7ed4ec726
[ ] Termination of challenge - Fri Sep 16 2022 11:20:15 GMT+0200 (CEST)<PHONE_NUMBER>)
[ ] Confirm that agent withdrew

Before finalizing the tests we need to:

wait for #1037
update agents
start agents
investigate challenge issue between the agents

closed in favor of #1077


README doesn't make sense

Our current README file has no information and doesn't make sense

Solved!


Authentication / Authorization

How do I add authentication/authorization/permissions to queries and mutations?
example, User can view all users but can only edit his user account.
User who is admin of a business can add/remove users from the business and can make/receive payments
User who is an employee of a business can view payments made to/from the business

It is easier if you provide your code.
First off you need to get user ID and pass it into GraphQL if authenticated.
server.js
app.use('/graphql',
  graphqlHTTP(req => ({
    schema: Schema,
    graphiql: true,
    context: {
      userId: req.user._id,
    },
  }))
)

Users.js
var UserSchema = new mongoose.Schema({
  email : { type: String },
  firstName : { type: String },
  lastName : { type: String },
})
export const Users = mongoose.model('Users', UserSchema)
export const UsersTC = composeMongoose(Users)

schema.js
export const RootQueryTC = GQC.rootQuery()
export const RootMutationTC = GQC.rootMutation()

RootQueryTC.addFields({
  users: UsersTC.get('$findMany')
})

RootMutationTC.addFields({
  userUpdate: UsersTC.get('$updateById')
    .wrapResolve( next => req => {
      if(req.context.userId != req.args.input.record._id)
        throw new Error ('Not allowed')
      return next(req)
    }),

  addUserToBusiness: BusinessTC.get('$updateById')
    .wrapResolve( next => req => {
        UsersTC.find({_id: req.context.userId}).exec( user => {
          //if not owner throw Error
          //if owner and you want to parse data, change the req data
        })
      return next(req)
    }),
})

export default = GQC.buildSchema()

Other beauty way how to restrict access is
import { GQC } from 'graphql-compose';
import { MailTC } from './mail';
import { CompanyTC } from './company';
import { NoteTC } from './note';
import { UserTC } from './user';

export const RootMutationTC = GQC.rootMutation();

RootMutationTC.addFields({
  companyCreate: CompanyTC.get('$createOne'), // may anybody
  noteCreate: NoteTC.get('$createOne'),  // may anybody

  ...adminAccess({
    userCreate: UserTC.get('$createOne'),
    userUpdate: UserTC.get('$updateById'),
    userRemove: UserTC.get('$removeById'),
    sendMail: MailTC.get('$sendMail'),
  }),
});

function adminAccess(resolvers) {
  Object.keys(resolvers).forEach((k) => {
    resolvers[k] = resolvers[k].wrapResolve(next => (rp) => {
      if (!rp.context.admin) {
        throw new Error('You should be admin, to have access to this action.');
      }
      return next(rp);
    });
  });
  return resolvers;
}

Perfect! The above looks like it will work great! Thank you
Here's another question with regards to field access:
var UserSchema = new mongoose.Schema({
  email : { type: String },
  firstName : { type: String },
  lastName : { type: String },
  role: { type: String },
  businessRole: { type: String },
  businessId: { type: ObjecId, ref: 'Business' },
  isAdminLocked: { type: Boolean },  // only a super user can change this value, (outside of business)
  isLocked: { type: Boolean } // only a business admin from the same business can change/view this
})
export const Users = mongoose.model('Users', UserSchema)
export const UsersTC = composeMongoose(Users)

How about field permissions for viewing and changing.  The above fields, I want it hidden and non-writeable from non-admin users.  The first one, is the application admin, and the second is just a business admin who is from the same business as the user.
Thank you!

Permission for changing is covered in the two posts in top.
Permission for viewing can be solved using projections..
ViewerTC.addRelation(
  'currentUser',
  () => ({
    resolver: UsersTC.getResolver('findById'),
    args: {
       _id: (source, args, context, info) => context.userId,
    },
  })
)

ViewerTC.addRelation(
  'userSearch',
  () => ({
    resolver: UsersTC.getResolver('findMany'),
    args: {
      filter: (source) => ({ email: source.email }),
      sort: null,
    },
    projection: { businessRole: false, businessId: false },
  })
)

Thanks @stoffern
To add to the above use case, what if I want the viewing of that field is dependent on the user context?
Example:  user with admin role can see businessRole.  How do I make projections dynamic based upon the context?

@stoffern @atalebagha  I will not connect projections with context. Let's keep it simple.
To solve your case better will be to use standard graphql resolve method for fields.
Right now published new package<EMAIL_ADDRESS>with TC.extendField(name, fieldConfig) method.
You may add your logic to schema in such way:
UsersTC.extendField('businessRole', {
  description: 'May see only admins',
  resolve: (source, args, context) => (context.isAdmin ? source.businessRole : null),
});

thanks @nodkz


CASMTRIAGE-6546 add actionable error message for password complexity

Summary and Scope

[ ] I have added new tests to cover the new code
[ ] If adding a new file, I have updated pyinstaller.py
[ ] I have added entries in CHANGELOG.md for the changes in this PR

Issues and Related PRs

Testing

Not a bug, per comments in JIRA from @spillerc-hpe.  I think I had this ticket temporarily and started attempting a fix


Fetching Server TLS Certificate from Client Side

hi! I'm trying to do some custom TLS certificate verification using tonic on the client side. This requires me to access the server TLS certificate when I make a connection, but I wasn't able to find a solution in the API docs. What's the best way to access the TLS certificate chain of the server?
what I've tried:

I saw that there's a get_peer_certificates (https://docs.rs/tonic/latest/tonic/struct.Request.html#method.peer_certs) function in Request, but this seems to be giving client certs
I found ways to access certs through rusTLS, but I can't figure out whether tonic exposes these. https://docs.rs/rustls/latest/rustls/struct.ClientConnection.html#method.peer_certificates
I saw there's a peer_certs function in TlsConnectInfo (https://docs.rs/tonic/latest/tonic/transport/server/struct.TlsConnectInfo.html#method.peer_certs), but I'm not able to access TlsConnectInfo through extensions (is it supposed to be included by default? do I need to write an interceptor?)

What did you end up doing? I used an interceptor but still never get any peer certificates even when using TLS. The same code does give me the client's certs when running server side


rulebase "pre-rulebase" requires a specific device group, not "shared"

Describe the bug
terraform provider 1.8.3 was allowed to deploy the pre-rulebase and post-rulebase inside "shared" device group but as soon as upgrade 1.9.0 the terraform reported the following error.

Expected behavior
Terraform provider 1.9.0 should allow deploying the rulebase in the "shared" device group
Current behavior
Only allowed to deploy the rulebase in the user-defined device group
Possible solution
Only allowed to deploy the rulebase in the user-defined device group

Well, I just logged in to a 10.1 Panorama to verify and it looks like /config/shared/pre-rulebase and /config/shared/post-rulebase both exist, while /config/shared/rulebase (which used to be the only option) does not......  So I guess this changed at some point..?
I'll put out a new release today, but I have to track down when this changed.

I am using 10.1.3 and checked xpath too and seems its allow to use .
Thank you for quick resolve

I checked as far back as 7.1, and it seems like /config/shared/rulebase never existed, it's always been /config/shared/pre-rulebase and /config/shared/post-rulebase...
So I'm just unconditionally lifting this restriction, new release should be out in 10-15min or so.

Fixed in v1.9.1

worked like a charm . Thank you


Azure : Increase retry count and time for restarting resources

Logs :
03/13/2019 16:43:59 : [ERROR] Restart-receiver failed with error: Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : b898d1d3-e5bb-4680-a6e0-2f569296a0d7 Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : b7870849-1cfe-42de-b824-b6adbc0518c8 Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-TwoVM2NIC-XXXXX' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : 6f907ffa-46ab-4857-8ea1-ca934471124e Failed to restart Azure VM receiver
Fix :
Increased retry count in case API responds after more time has passed

This didn't resolve the issue, happen in latest upstream pipeline.


Documentation 2.0.0

Update documentation for 2.0.0

This issue is done, see: https://ryos.io and Github wiki pages.


AppImage for version 1.6.0 doesn't run

The AppImage available for version 1.60 doesn't run.
To Reproduce
Steps to reproduce the behavior:

Download AppImage for version 1.6.0
Change execution bit flag: chmod a+x Monokle-linux-1.6.0-x86_64.AppImage
execute ./Monokle-linux-1.6.0-x86_64.AppImage
See error

Expected behavior
Should run.
Screenshots
Squashfs image uses (null) compression, this version supports only xz, zlib.

Cannot mount AppImage, please check your FUSE setup.
You might still be able to extract the contents of this AppImage
if you run it with the --appimage-extract option.
See https://github.com/AppImage/AppImageKit/wiki/FUSE
for more information
open dir error: No such file or directory

Desktop (please complete the following information):

OS: Fedora
Version 35 with all updates.

It seems to be a problem in the electron-builder, the package should be updated according to https://github.com/electron-userland/electron-builder/issues/6678., it seems to be fixed in version 23.0.2

Hi @jpralves, thanks a lot for reporting the bug and the solution! Im sorry for the delayed answer. I will check it with the team and update the issue accordingly.

Glad to be helpful. Your tool is very good.

@jpralves thank you!  may I ask you:

What do you find our tool the most useful for?
What would you like to see?

Thank you!
Christian

Hi @jpravles , thank you for reporting this bug!
We've released the 1.6.1 version today where we have updated electron and electron-builder, please let us know if you still have the problem in the new version.

It works as expected.
Many thanks!
João
On Fri, 25 Mar 2022 at 14:39, Catalin @.***> wrote:

Hi @jpravles , thank you for reporting this bug!
We've released the 1.6.1 version today where we have updated electron and
electron-builder, please let us know if you still have the problem in the
new version.
—
Reply to this email directly, view it on GitHub
https://github.com/kubeshop/monokle/issues/1503#issuecomment-1079092798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFCKSF3FOUOBNCYHRALQ7DVBXF3VANCNFSM5RQ5OYTA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
https://about.me/jpralves?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=edit_panel&utm_content=thumb
João Alves
about.me/jpralves
https://about.me/jpralves?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=edit_panel&utm_content=thumb


Build from source rather than from release

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

The patches are no longer compatible, so maybe it is easier to stay with the release:
--------------------------
|
|diff -Nur flux-core-0.49.0/src/common/libeventlog/Makefile.in flux-core-0.49.0.new/src/common/libeventlog/Makefile.in
|--- flux-core-0.49.0/src/common/libeventlog/Makefile.in	2023-04-05 16:24:09.982692163 +0000
|+++ flux-core-0.49.0.new/src/common/libeventlog/Makefile.in	2023-04-12 03:49:02.262611471 +0000
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
checking file src/modules/resource/exclude.c
can't find file to patch at input line 307
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Nur flux-core-0.49.0/src/shell/Makefile.in flux-core-0.49.0.new/src/shell/Makefile.in
|--- flux-core-0.49.0/src/shell/Makefile.in	2023-04-05 16:24:12.798689648 +0000
|+++ flux-core-0.49.0.new/src/shell/Makefile.in	2023-04-12 02:50:11.579942667 +0000
--------------------------

@grondo What do you think? The advantage of using the source code would be that when the license is changed this is included directly and creating patches based on the repository would be easier. But I am open for both suggestions. For flux-sched everything works out of the box https://github.com/conda-forge/flux-sched-feedstock/pull/1 but I guess it is important to keep both consistent.

I may be confused, but the difference between the release tarball and the source generated by github is that make dist has been run on the release tarball. I think we'd prefer packaging systems use the release tarballs to remove any gotchas from regenerating the autotools stuff with ./autogen.sh, however there is likely a low risk there.
It would indeed be easier to generate patches though, the existing patches that fix Makefiles would have to be modified to patch the Makefile.am files instead of Makefile.in -- but upstream patches to build files could be pulled in directly.
Does building from source also allow us to build directly from current master instead of a tag?
I could help regenerate the patch I think.

I may be confused, but the difference between the release tarball and the source generated by github is that make dist has been run on the release tarball. I think we'd prefer packaging systems use the release tarballs to remove any gotchas from regenerating the autotools stuff with ./autogen.sh, however there is likely a low risk there.

Somehow the LICENSE file is not included in the distribution, which conda requires to make sure we only publish open source packages.

It would indeed be easier to generate patches though, the existing patches that fix Makefiles would have to be modified to patch the Makefile.am files instead of Makefile.in -- but upstream patches to build files could be pulled in directly.

That is the advantage I see.

Does building from source also allow us to build directly from current master instead of a tag?

While technically it is possible to build directly from the master branch, it is generally preferred to build from specific tags to have reproducibility.

Somehow the LICENSE file is not included in the distribution, which conda requires to make sure we only publish open source packages.

Oh my, that is a mistake. Let me add this to EXTRA_DIST so it appears in the next release.

Oh my, that is a mistake. Let me add this to EXTRA_DIST so it appears in the next release.

Can you do the same for flux-sched ?

Ok, @jan-janssen we merged the PRs for flux-sched and flux-core to distribute the license files, so that should be fixed in the next release(s).

Ok, @jan-janssen we merged the PRs for flux-sched and flux-core to distribute the license files, so that should be fixed in the next release(s).

Perfect - thanks a lot. I added two issues as a reminder for us to update the recipe https://github.com/conda-forge/flux-sched-feedstock/issues/4 and https://github.com/conda-forge/flux-core-feedstock/issues/15

I forgot that the other reason we want people to use the release tarball is because the version is obtained from git during autogen.sh. So the automatic source tarball generated by github can't be used without setting FLUX_VERSION.
It is probably better to use the release tarball for now. Hopefully after v0.50.0 we won't have to provide much of a patch so the point about pulling in patches from upstream will not be an issue.
Or, you could use the following in meta.yaml:
diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index 7984eb6..8e16977 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -18,6 +18,8 @@ build:
   skip: true  # [not linux]
   run_exports:
      - {{ pin_subpackage('flux-core', max_pin='x.x') }}
+  script_env:
+     - FLUX_VERSION={{ version }}

 requirements:
   build:

Oh, and here's a modified patch that replaces the modification of Makefile.in files with Makefile.am:
diff --git a/src/broker/state_machine.c b/src/broker/state_machine.c
index 57e727fea..b02a3b144 100644
--- a/src/broker/state_machine.c
+++ b/src/broker/state_machine.c
@@ -11,6 +11,8 @@
 #if HAVE_CONFIG_H
 #include "config.h"
 #endif
+#include <signal.h>
+
 #include <flux/core.h>

 #include "src/common/libczmqcontainers/czmq_containers.h"
diff --git a/src/cmd/builtin/proxy.c b/src/cmd/builtin/proxy.c
index feff795b9..655df262a 100644
--- a/src/cmd/builtin/proxy.c
+++ b/src/cmd/builtin/proxy.c
@@ -18,6 +18,7 @@
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <stdio.h>
+#include <signal.h>
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
diff --git a/src/common/libsubprocess/server.c b/src/common/libsubprocess/server.c
index 2c164646c..275aa3443 100644
--- a/src/common/libsubprocess/server.c
+++ b/src/common/libsubprocess/server.c
@@ -13,6 +13,7 @@
 #endif

 #include <unistd.h> // defines environ
+#include <signal.h>
 #include <errno.h>
 #include <flux/core.h>

diff --git a/src/common/libterminus/pty.c b/src/common/libterminus/pty.c
index a1dbf6788..a3c6f4c7b 100644
--- a/src/common/libterminus/pty.c
+++ b/src/common/libterminus/pty.c
@@ -208,8 +208,10 @@ int flux_pty_kill (struct flux_pty *pty, int sig)
         pty->wait_for_client = false;
         pty->wait_on_close = false;
     }
+#if defined(TIOCSIG)
     if (ioctl (pty->leader, TIOCSIG, sig) >= 0)
         return 0;
+#endif
     llog_debug (pty, "ioctl (TIOCSIG): %s", strerror (errno));
     if (ioctl (pty->leader, TIOCGPGRP, &pgrp) >= 0
         && pgrp > 0
diff --git a/src/common/libutil/fileref.c b/src/common/libutil/fileref.c
index 69213b0f0..22a4d3359 100644
--- a/src/common/libutil/fileref.c
+++ b/src/common/libutil/fileref.c
@@ -57,8 +57,10 @@ static int blobvec_append (json_t *blobvec,

 static bool file_has_no_data (int fd)
 {
+#if defined(SEEK_DATA)
     if (lseek (fd, 0, SEEK_DATA) == (off_t)-1 && errno == ENXIO)
         return true;
+#endif
     return false;
 }

@@ -83,19 +85,25 @@ static json_t *blobvec_create (int fd,
         goto error;
     }
     while (offset < size) {
+#if defined(SEEK_DATA)
         // N.B. fails with ENXIO if there is no more data
         if ((offset = lseek (fd, offset, SEEK_DATA)) == (off_t)-1) {
             if (errno == ENXIO)
                 break;
             goto error;
         }
+#endif
         if (offset < size) {
             off_t notdata;
             int blobsize;

+#if defined(SEEK_HOLE)
             // N.B. returns size if there are no more holes
             if ((notdata = lseek (fd, offset, SEEK_HOLE)) == (off_t)-1)
                 goto error;
+#else
+	    notdata = size;
+#endif
             blobsize = notdata - offset;
             if (blobsize > chunksize)
                 blobsize = chunksize;
diff --git a/src/common/libutil/test/fileref.c b/src/common/libutil/test/fileref.c
index 61cb0bdfe..6fbd84d9b 100644
--- a/src/common/libutil/test/fileref.c
+++ b/src/common/libutil/test/fileref.c
@@ -87,9 +87,11 @@ void rmfile (const char *name)
  */
 bool test_sparse (void)
 {
+    bool result = false;
+
+#if defined(SEEK_DATA)
     int fd;
     struct stat sb;
-    bool result = false;

     fd = open (mkpath ("testhole"), O_WRONLY | O_CREAT | O_TRUNC, 0600);
     if (fd < 0)
@@ -104,6 +106,7 @@ bool test_sparse (void)
         result = true;
     close (fd);
     rmfile ("testhole");
+#endif
     return result;
 }

@@ -709,7 +712,8 @@ int main (int argc, char *argv[])
     test_dir ();
     test_link ();
     test_small ();
-    test_empty ();
+    if (have_sparse)
+        test_empty ();
     test_expfail ();
     test_pretty_print ();

diff --git a/src/modules/job-exec/job-exec.c b/src/modules/job-exec/job-exec.c
index d29aba68a..c6b76fb92 100644
--- a/src/modules/job-exec/job-exec.c
+++ b/src/modules/job-exec/job-exec.c
@@ -89,6 +89,7 @@
 #endif
 #include <assert.h>
 #include <unistd.h>
+#include <signal.h>
 #include <flux/core.h>

 #include "src/common/libczmqcontainers/czmq_containers.h"
diff --git a/src/shell/rlimit.c b/src/shell/rlimit.c
index 25a19d936..f83904525 100644
--- a/src/shell/rlimit.c
+++ b/src/shell/rlimit.c
@@ -60,8 +60,10 @@ static int rlimit_name_to_string (const char *name)
         return RLIMIT_NICE;
     if (streq (name, "rtprio"))
         return RLIMIT_RTPRIO;
+#ifdef RLIMIT_RTTTIME
     if (streq (name, "rttime"))
         return RLIMIT_RTTIME;
+#endif
     if (streq (name, "sigpending"))
         return RLIMIT_SIGPENDING;
     return -1;
diff --git a/src/cmd/flux-exec.c b/src/cmd/flux-exec.c
index eeeb2c581..79747091d 100644
--- a/src/cmd/flux-exec.c
+++ b/src/cmd/flux-exec.c
@@ -190,9 +190,12 @@ void output_cb (flux_subprocess_t *p, const char *stream)
         log_err_exit ("flux_subprocess_getline");

     if (lenp) {
+        int rc;
         if (optparse_getopt (opts, "label-io", NULL) > 0)
             fprintf (fstream, "%d: ", flux_subprocess_rank (p));
-        fwrite (ptr, lenp, 1, fstream);
+        rc = fwrite (ptr, lenp, 1, fstream);
+        (void) rc;
+
     }
 }

diff --git a/src/cmd/flux-job.c b/src/cmd/flux-job.c
index 979c7fbf7..2eb7c7a8b 100644
--- a/src/cmd/flux-job.c
+++ b/src/cmd/flux-job.c
@@ -1672,9 +1672,12 @@ static void handle_output_data (struct attach_ctx *ctx, json_t *context)
     else
         fp = stderr;
     if (len > 0) {
+        int rc;
         if (optparse_hasopt (ctx->p, "label-io"))
             fprintf (fp, "%s: ", rank);
-        fwrite (data, len, 1, fp);
+        rc = fwrite (data, len, 1, fp);
+        (void) rc;
+
         fflush (fp);
     }
     free (data);
@@ -2205,7 +2208,9 @@ void handle_exec_log_msg (struct attach_ctx *ctx, double ts, json_t *context)
                  rank,
                  stream);
     }
-    fwrite (data, len, 1, stderr);
+    int rc = fwrite (data, len, 1, stderr);
+    (void) rc;
+
 }

 static struct idset *all_taskids (const struct taskmap *map)
diff --git a/src/common/libsubprocess/subprocess.c b/src/common/libsubprocess/subprocess.c
index da068b3d3..72cb6cca6 100644
--- a/src/common/libsubprocess/subprocess.c
+++ b/src/common/libsubprocess/subprocess.c
@@ -262,8 +262,11 @@ void flux_standard_output (flux_subprocess_t *p, const char *stream)
         }
     }

-    if (lenp)
-        fwrite (ptr, lenp, 1, fstream);
+    if (lenp) {
+        int rc = fwrite (ptr, lenp, 1, fstream);
+        (void) rc;
+
+    }
 }

 /*
diff --git a/src/shell/output.c b/src/shell/output.c
index 8ebf07365..6e3422605 100644
--- a/src/shell/output.c
+++ b/src/shell/output.c
@@ -173,8 +173,11 @@ static int shell_output_term (struct shell_output *out)
                 f = stderr;
             }
             if ((output_type == FLUX_OUTPUT_TYPE_TERM) && len > 0) {
+                int rc;
                 fprintf (f, "%s: ", rank);
-                fwrite (data, len, 1, f);
+                rc = fwrite (data, len, 1, f);
+                (void) rc;
+
             }
             free (data);
         }
diff --git a/t/rexec/rexec_count_stdout.c b/t/rexec/rexec_count_stdout.c
index 8cb9ff932..f5e1985f8 100644
--- a/t/rexec/rexec_count_stdout.c
+++ b/t/rexec/rexec_count_stdout.c
@@ -69,8 +69,10 @@ void output_cb (flux_subprocess_t *p, const char *stream)
         }
     }

-    if (lenp)
-        fwrite (ptr, lenp, 1, fstream);
+    if (lenp) {
+        int rc = fwrite (ptr, lenp, 1, fstream);
+        (void) rc;
+    }

     if (!strcasecmp (stream, "stdout"))
         stdout_count++;
diff --git a/t/rexec/rexec_getline.c b/t/rexec/rexec_getline.c
index b4a17c3ea..55fd57ffd 100644
--- a/t/rexec/rexec_getline.c
+++ b/t/rexec/rexec_getline.c
@@ -76,8 +76,10 @@ void output_cb (flux_subprocess_t *p, const char *stream)

     if (!(ptr = flux_subprocess_getline (p, stream, &lenp)))
         log_err_exit ("flux_subprocess_getline");
-    if (lenp)
-        fwrite (ptr, lenp, 1, fstream);
+    if (lenp) {
+        int rc = fwrite (ptr, lenp, 1, fstream);
+        (void) (rc);
+    }
     else
         fprintf (fstream, "EOF\n");
 }

diff --git a/src/modules/resource/exclude.c b/src/modules/resource/exclude.c
index 62326abf6..ea0f46581 100644
--- a/src/modules/resource/exclude.c
+++ b/src/modules/resource/exclude.c
@@ -83,13 +83,13 @@ int exclude_update (struct exclude *exclude,
                                         add_s) < 0) {
             flux_log_error (h, "error posting exclude event");
         }
-        free (add_s);
         /*  Added exclude ranks can no longer be drained:
          */
         if (undrain_ranks (exclude->ctx->drain, add) < 0)
             flux_log_error (h,
                             "exclude: failed to undrain ranks in %s",
                             add_s);
+        free (add_s);
         idset_destroy (add);
     }
     if (del) {
--- a/t/t0001-basic.t	2023-04-05 16:22:48.910745814 +0000
+++ b/t/t0001-basic.t	2023-04-13 13:45:26.201487673 +0000
@@ -613,7 +613,8 @@
 	grep "^test two commands" help2.out &&
 	grep "a test two" help2.out
 '
-test_expect_success 'flux-help command can display manpages for subcommands' '
+command -v man >/dev/null && test_set_prereq HAVE_MAN
+test_expect_success HAVE_MAN 'flux-help command can display manpages for subcommands' '
 	PWD=$(pwd) &&
 	mkdir -p man/man1 &&
 	cat <<-EOF > man/man1/flux-foo.1 &&
@@ -623,7 +624,7 @@
 	EOF
 	MANPATH=${PWD}/man FLUX_IGNORE_NO_DOCS=y flux help foo | grep "^FOO(1)"
 '
-test_expect_success 'flux-help command can display manpages for api calls' '
+test_expect_success HAVE_MAN 'flux-help command can display manpages for api calls' '
 	PWD=$(pwd) &&
 	mkdir -p man/man3 &&
 	cat <<-EOF > man/man3/flux_foo.3 &&
@@ -638,7 +639,7 @@
 	man notacommand >/dev/null 2>&1
 	echo $?
 }
-test_expect_success 'flux-help returns nonzero exit code from man(1)' '
+test_expect_success HAVE_MAN 'flux-help returns nonzero exit code from man(1)' '
 	test_expect_code $(missing_man_code) \
 		eval FLUX_IGNORE_NO_DOCS=y flux help notacommand
 '
diff --git a/t/sharness.d/01-setup.sh b/t/sharness.d/01-setup.sh
index 84b02f97f..fd9387ed5 100644
--- a/t/sharness.d/01-setup.sh
+++ b/t/sharness.d/01-setup.sh
@@ -57,6 +57,7 @@ else # normal case, use ${top_builddir}/src/cmd/flux
     #
     export LD_LIBRARY_PATH="${FLUX_BUILD_DIR}/src/common/.libs:$LD_LIBRARY_PATH"
 fi
+PATH=$(flux python -c 'import os,sys; print(os.path.dirname(sys.executable))'):$PATH
 export PATH

 if ! test -x ${fluxbin}; then

diff --git a/src/shell/Makefile.am b/src/shell/Makefile.am
index 51463f78d..077030db5 100644
--- a/src/shell/Makefile.am
+++ b/src/shell/Makefile.am
@@ -99,13 +99,14 @@ flux_shell_LDADD = \
 	$(top_builddir)/src/bindings/lua/libfluxlua.la \
 	$(top_builddir)/src/common/libflux-core.la \
 	$(top_builddir)/src/common/libflux-taskmap.la \
+	$(top_builddir)/src/common/libflux-idset.la \
 	$(top_builddir)/src/common/libpmi/libpmi_server.la \
 	$(top_builddir)/src/common/libpmi/libpmi_common.la \
 	$(top_builddir)/src/common/libczmqcontainers/libczmqcontainers.la \
-	$(top_builddir)/src/common/libflux-internal.la \
 	$(top_builddir)/src/common/libflux-optparse.la \
 	$(top_builddir)/src/common/libterminus/libterminus.la \
 	$(top_builddir)/src/common/libutil/libutil.la \
+	$(top_builddir)/src/common/libflux-internal.la \
 	$(LUA_LIB) \
 	$(HWLOC_LIBS) \
 	$(JANSSON_LIBS) \
diff --git a/src/common/libeventlog/Makefile.am b/src/common/libeventlog/Makefile.am
index fdd2cde56..7430825d3 100644
--- a/src/common/libeventlog/Makefile.am
+++ b/src/common/libeventlog/Makefile.am
@@ -37,4 +37,5 @@ test_eventlog_t_LDADD = \
 	$(top_builddir)/src/common/libtap/libtap.la \
 	$(top_builddir)/src/common/libeventlog/libeventlog.la \
 	$(top_builddir)/src/common/libutil/libutil.la \
-	$(JANSSON_LIBS)
+	$(JANSSON_LIBS) \
+	$(LIBRT)

I forgot that the other reason we want people to use the release tarball is because the version is obtained from git during autogen.sh. So the automatic source tarball generated by github can't be used without setting FLUX_VERSION.

Does this also apply to flux-sched ? https://github.com/conda-forge/flux-sched-feedstock/pull/1

Does this also apply to flux-sched ?

Yes, note that the version in the successful build of the flux-sched recipe is incorrect:
  flux-sched version 457bdc0
  Prefix...........: $PREFIX
  Debug Build......:
  C Compiler.......: $BUILD_PREFIX/bin/x86_64-conda-linux-gnu-cc
  C++ Compiler.....: $BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++

And flux-sched doesn't have the FLUX_VERSION workaround...

Seeing all these issues, it is maybe better we stay with the releases for now. Having the right version number is more important.

Yes, by the next release we may no longer need a patch anyway :+1:


order by bug?

TypeError: Cannot read property 'owner' of undefined
order by  table_kpi.owner->name asc (It leads to error)
order by  owner->name asc (all right)

http://jsfiddle.net/8mobrL3o/3/

Here ORDER BY is the last clause in the sequence and it performs after the SELECT clause performed, so it sorts data from the final table, where we do not have original table names (like table_kpi).

Got it, thanks for the reply


Fix segmentation fault on submit by update prettytable-rs

Updates prettytable-rs to 0.10.0
Segmentation fault occurs on cargo compete submit.
prettytable-rs causes this error, fix it by updating.
The following is my console this error occurred.
$ cargo compete submit practice-a
     Running `/Users/yosuke/.cargo/bin/cargo-compete compete t --src /Users/yosuke/study/procon/atcoder/abs/src/bin/practice-a.rs --display-limit '4 KiB' --manifest-path /Users/yosuke/study/procon/atcoder/abs/Cargo.toml --color auto`
     Running `/Users/yosuke/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo build --bin abs-practice-a --manifest-path /Users/yosuke/study/procon/atcoder/abs/Cargo.toml`
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
1/2 ("sample1") Accepted (2 ms)
2/2 ("sample2") Accepted (2 ms)

1/2 ("sample1") Accepted (2 ms)
stdin:
1
2 3
test
expected:
6 test
actual:
6 test

2/2 ("sample2") Accepted (2 ms)
stdin:
72
128 256
myonmyon
expected:
456 myonmyon
actual:
456 myonmyon
fish: Job 1, 'cargo compete submit practice-a' terminated by signal SIGSEGV (Address boundary error)

Environment
M1 Mac (macOS: 13.1)
$ cargo --version
cargo 1.67.1 (8ecd4f20a 2023-01-10)

A tentative segfault workaround might be to build with 1.66.1.
rustup install 1.66.1
cargo +1.66.1 install cargo-compete --locked --force

Note that 1.67.1 will cause a segfault.
rustup install 1.67.1
cargo +1.67.1 install cargo-compete --locked --force

I met the same error, and here is the backtrace:
#0  0x0000555fe2e06af0 in prettytable::TableSlice::get_all_column_width::hf643685f428da65c ()
#1  0x0000555fe2e0719f in <prettytable::TableSlice as core::fmt::Display>::fmt::hbb990547bd587e0e ()
#2  0x0000555fe32e8a2e in core::fmt::write () at library/core/src/fmt/mod.rs:1232
#3  0x0000555fe2c47205 in std::io::Write::write_fmt::hd8d4ef6e1f600e97 ()
#4  0x0000555fe2c5914a in cargo_compete::commands::submit::print_status::h6b8dadaf3c0018b0 ()
#5  0x0000555fe2c57c22 in cargo_compete::commands::submit::run::haeb8ea3df6498a76 ()
#6  0x0000555fe2a87c76 in cargo_compete::run::ha50f05372f69dd39 ()
#7  0x0000555fe2a62509 in cargo_compete::main::h7f89b54875f6d7ce ()

My environment is zsh 5.9 on archlinux.
I can confirm updating prettytable-rs to 0.10.0 fixed the issue for me.

Same problem

Merging. Thank you.


Add CompositeCallCredentials

#12556

Thanks much. Maybe a little test? You could add something in end2end_test.cc if it proves difficult to unit-test this one.

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.counters.old: 1

[microbenchmarks] No significant performance differences

Sorry for the delay. PTAL
Thanks!

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_InProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.counters.old: 1
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.counters.old: 1

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Test failures: #12428 #12510


Fix Issue 13971

https://issues.dlang.org/show_bug.cgi?id=13971

Otherwise LGTM assuming the issue is valid... I'm wary about any change that conflates containers and ranges, as it cannot be taken to its ultimate conclusion. I'm inclined to think that stringification of the container should print its identity (ala SList!int@0xDEADBEEF) - it's really easy for the user to do myContainer[] when printing the elements is desired. The user has to learn about the opSlice operator anyway for the vast majority of container use cases.

TL;DR
I am opposed to this change, because printing the output as well is easy with the current API but printing only type and identity becomes impossible with this PR and current API.
First I agree with jakob about conflating containers and ranges. This will just move the problem (the misunderstanding of how containers and ranges are different) to the next place where a container behaves different from a range. The correct thing to do is to require the user to use opSlice if he needs a range over the container.
Second the question is, what should toString be used for and what is the most convenient thing for the developer. If you print something pretty for your users, you'll usually have to write your own function anyway since phobos cannot anticipate all desired formats. This makes toString more of a tool for the developer, to print the contents inside a debugger or during println-debugging. Having identity and type information is useful here, however
Array!int(RefCounted!(Payload, cast(RefCountedAutoInitialize)0 (RefCountedStore(20D9590)))

Is much to verbose and contains useless information. I think
Array!int@20D9590

would be a good compromise, if 20D9590 identifies the payload uniquely, like Jakob suggested. Printing the contents alongside with this is often not what I want, because the container might just be to big for an output of all it's contents to be meaningful.
And if I want to print the output as well, it's as hard as:
writefln("%s%s", myArray, myArray[])

I am opposed to this change, because printing the output as well is easy with the current API but printing only type and identity becomes impossible with this PR and current API.

@Panke @JakobOvrum
You convinced me that this is not a good solution, maybe we can just improve doc with some example so it would much more clear how to print containers.

So close this?

Huh, I don't know why I didn't read this fully before. I have some comments:

because printing the output as well is easy with the current API but printing only type and identity becomes impossible with this PR and current API.

This can be fixed, the code is in std.format, we can expose it, this is not a problem that should hinder this change.
In general, I think writeln(somearray) should print the array contents. It makes no sense that it would print the type. AA's and builtin arrays do not work this way, so I think we should fix this. In general, I think writeln(typeid(x)) should print the type, but in this case, the format function goes further, writeln(typeid(arr)) prints for the above example std.container.array.Array!int.Array (maybe that could also be fixed).
I agree that the toString function should use the sink version. If you don't want to do this work still, understood, I may open my own PR and do this.

It makes no sense that it would print the type.

I think it should print the container's identity.

AA's and builtin arrays do not work this way, so I think we should fix this.

Neither AA's nor builtin slices abide by the Phobos container concept, they're not even close. I think builtin slices in particular are not a good argument as they are ranges.
I stand by my argument from before. We need to improve documentation so the user understands the container/range separation; ad-hoc conflation of the two concepts in Phobos does not solve the underlying problem, it just makes it worse.
Containers have historically had really poor documentation, and indeed the concept is not completely fleshed out yet. It's too late to change inbuilt types (T[new], anyone?), but we can do containers right. We have to weigh consistency with the design of inbuilt but arguably suboptimal types against good design. I also think it is a possibility that idiomatic D in the future will strongly favour library containers and ranges over in-built types considering the inherent performance difficulties of AAs and dynamic arrays, so I would really like to see strong arguments that don't depend on the behaviour of inbuilt types.

We need to improve documentation so the user understands the container/range separation; ad-hoc conflation of the two concepts in Phobos does not solve the underlying problem, it just makes it worse.

Documentation doesn't fix this. 9 times out of 10, a user will want to print a container and find the current output useless. It doesn't make a whole lot of sense to say RTFM at that point.
I think printing a container should do the most expected thing, and leave the obtuse thing for a specialized function.

Containers have historically had really poor documentation, and indeed the concept is not completely fleshed out yet.

Yes, I agree, we should document that printing a container prints its elements.


Use the iOS 9 API for loading views

Use the iOS 9 API for loading views
sut.loadViewIfNeeded()

Hi @Philip-M-Bacchi, thanks!
That means we can't support iOS 8 anymore, but I guess we shouldn't have to support it :)
Merging!