[WIP] Gateway Implementation

Hey All,
This is a combination of @ZackButcher and our work to get an initial gateway wired up. We are going to end up writing a few more tests from this but would love feedback now.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
32fac43c0d9ca3c9e79f8094fb87be2188fd061b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
e6c5ef8df8e365093e2faaf526b65bc1d056124c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
61408280839033407ef9e3122b9921ebdae00cd0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d42b4dc9cd83f4809214219c3c2629cd89c2502e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f1f0d762070e158bf684fb40b86030022c9193a1
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
9a628278ba7ff7b9de427e40c6ce8dfc5adaeb72
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a3d3f178dccece56597637a51bea52b97c705393
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c88ad2e7619f93e0d00e48ed9f6118441b2836a6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
98d63fe658042579fe96ba5d982ec40d55c024c7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram / @ZackButcher all the tests pass (we've even gone ahead and re-written our cloudfoundry integration test to take advantage of the gateway).
Would love feedback so we can get this merged earlier in the week here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-presubmit.sh
907d7a55004f626b8483a4fe6ff364fa8b639f11
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-presubmit.sh
907d7a55004f626b8483a4fe6ff364fa8b639f11
link
/test istio-presubmit

prow/istio-unit-tests.sh
6e0ad751104177f479ff2cae194290ea7c35f6dc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-unit-tests.sh
6e0ad751104177f479ff2cae194290ea7c35f6dc
link
/test istio-unit-tests

prow/istio-presubmit.sh
6e0ad751104177f479ff2cae194290ea7c35f6dc
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-unit-tests.sh
6e0ad751104177f479ff2cae194290ea7c35f6dc
link
/test istio-unit-tests

prow/istio-presubmit.sh
7013d847b9c957c60630c54183469b0100e306e3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-presubmit.sh
7013d847b9c957c60630c54183469b0100e306e3
link
/test istio-presubmit

prow/istio-unit-tests.sh
7013d847b9c957c60630c54183469b0100e306e3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6396f84c024d35b18bc348774c2045bce3119a6a
link
/test e2e-smoke

prow/istio-presubmit.sh
7013d847b9c957c60630c54183469b0100e306e3
link
/test istio-presubmit

prow/istio-unit-tests.sh
b036d54b3ee10f70c8cf1d34dd40c632ab1c8f5b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b036d54b3ee10f70c8cf1d34dd40c632ab1c8f5b
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
b036d54b3ee10f70c8cf1d34dd40c632ab1c8f5b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b036d54b3ee10f70c8cf1d34dd40c632ab1c8f5b
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
ac4dd95ae56b53c6289c33e8ef90c21193b58a28
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ok, we're reworking this design (again 😄  )
a new-new plan

One listener per gateway.server, listener port == gateway.server.port

no attempt to support different gateways listening on same ports on the same workload

Listener points at an RDS named for the external port of that listener
RDS makes one virtual_host for each combination of: gateway.name, gateway.hosts[i], gateway.servers[j].port.
we consider any route rule where rule.hosts[k] == gateway.hosts[i] and rule.gateways[m] == gateway.name

an example
Gateway
apiVersion: config.istio.io/v1alpha2
kind: Gateway
metadata:
  name: some-gateway
spec:
  servers:
  - port:
      number: 8080
      protocol: http
      name: public-http
    hosts:
    - example.com
    - example.net
    - example.org
    tls:
      httpsRedirect: true
  - port:
      number: 8443
      protocol: https
      name: public-https
    hosts:
    - example.com
    tls:
      mode: SIMPLE
      serverCertificate: /etc/certs/server.pem
      privateKey: /etc/certs/key.pem

apiVersion: config.istio.io/v1alpha2
kind: RouteRule
metadata:
  name: bookinfo-rule
spec:
  hosts:
  - example.com
  - example.org
  gateways:
  - some-gateway
  http:
  - route:
    - destination:
        name: world
        subset: v0
      weight: 75
    - destination:
        name: world
        subset: v1
      weight: 25

RDS response for the listener on external port 8443:
{
  "virtual_hosts": [
   {
    "name": "some-gateway|example.com|8443",
    "domains": [
     "example.com:8443",
     "example.com"
    ],
    "routes": [
     {
      "prefix": "/",
      "weighted_clusters": {
       "clusters": [
        {
         "name": "out.world.default.svc.cluster.local|http|version=v0",
         "weight": 75
        },
        {
         "name": "out.world.default.svc.cluster.local|http|version=v1",
         "weight": 25
        }
       ]
      },
      "timeout_ms": 0,
      "decorator": {
       "operation": "weighted"
      }
     }
    ]
   },
   {
    "name": "some-gateway|example.org|8443",
    "domains": [
     "example.org:8443",
     "example.org"
    ],
    "routes": [
     {
      "prefix": "/",
      "weighted_clusters": {
       "clusters": [
        {
         "name": "out.world.default.svc.cluster.local|http|version=v0",
         "weight": 75
        },
        {
         "name": "out.world.default.svc.cluster.local|http|version=v1",
         "weight": 25
        }
       ]
      },
      "timeout_ms": 0,
      "decorator": {
       "operation": "weighted"
      }
     }
    ]
   }
  ]
}

does this make sense?   what are we missing?

Why do you have example.org for the 8443 route?

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ac4dd95ae56b53c6289c33e8ef90c21193b58a28
link
/test istio-unit-tests

prow/istio-presubmit.sh
a8a1ca9745f75960e6bc033dc15eb87bbfda2fdb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a8a1ca9745f75960e6bc033dc15eb87bbfda2fdb
link
/test istio-presubmit

prow/istio-unit-tests.sh
a8a1ca9745f75960e6bc033dc15eb87bbfda2fdb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zachgersh: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fd3b603c3eb58c0a1704f648115258bcd95fc016
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@rshriram @ZackButcher updated, please take another look.
status: tests are all passing (including CF integration using gateway)
possibly for a follow-up PR, three new tests are needed to drive out missing features:

when the backing service has more than one port.
when the route rule applies to a particular ingress port
when the route and/or gateway have wildcard hostnames, so they don’t have exact string-matching semantics.

i think workload-selectors will need a conversation before we can make it work right. also, i think non-HTTP listeners and merging gateways with different TLS config will both require features only available in Envoy V2 APIs. so we should explicitly defer those until a follow-on PR

Let me know if it’s ready to merge

Addressed most of the nits.  I think it's ready to merge once it passes these last tests.

also, we need the human-approved CLA tag


Create binarysearch.go

binary search in golang

Hi @gkshri , Please create a corresponding issue for better tracking. Follow the directory structure  Algo>language>file. Add comments & readme as well to explain the algorithm


⚠ Bofrost.be has degraded performance

In ae42017, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1871 ms

Resolved: Bofrost.be performance has improved in 011b07c after 9 minutes.


Cordova platform add android doesn't work??

Please assist??

Nevermind, finally found the solution.


fix: mission not available so no check for runs on cluster.

Selected mission not available for the specific runtime we'll show another not availble sign. So we return true in this case.
fixes: https://github.com/fabric8-launcher/launcher-frontend/issues/359

[test]


[EasyCodingStandard] NewClassSniff: anonymous class

Hi at code like this
return new class implements SomeInterface {

	/**
	 * {@inheritdoc}
	 */
	public function getName(): string
	{
		return 'Some name';
	}

	/**
	 * {@inheritdoc}
	 */
	public function getDescription(): Type
	{
		return 'some description';
	}

};

i get this warning by Symplify\CodingStandard\Sniffs\ControlStructures\NewClassSniff)
New class statement should not have empty parentheses. and after automatic fix my code looks like this
return new class implements SomeInterface {

	/**
	 * {@inheritdoc}
	 */
	public function getName: string
	{
		return 'Some name';
	}

	/**
	 * {@inheritdoc}
	 */
	public function getDescription(): Type
	{
		return 'some description';
	}

};

which is incorrect.

This is already resolved in Symplify 3.0, where the sniff was dropped for duplicated Fixer.


[Bug report]  Gravitino UI when creating a new fileset catalog it seems to be missing location property

Version
main branch
Describe what's wrong
When creating a new fileset there are no properties. Is this expected?

Error message and/or stacktrace
N/A
How to reproduce
Using the 0.5 release, create a new fileset catalog in the Gravitino UI.
Additional context
No response

+1; Although the location property is optional, it is better to be there for ease of use.

@jerryshao Is the location property equate to storageLocation property of api request body?


Navigation menu accessible in "Artist Invites" tab even though I'm logged out

Much appreciated!  I'll get this repaired ASAP.

Fixed in 02cdb92


Eliminate hardcoded exceptions for kube-system or make it optional

@kyessenov commented on Tue Aug 29 2017
Currently, the service controller is excluding kube-system without a way to change it. This will cause problems when istio runs in kube-system.
See https://github.com/istio/pilot/commit/720d751f5a82dcd746e3b36d8dadee96647c1d17#diff-9b493b4288200b30b3d0953052d6abdaR425

@ldemailly commented on Tue Aug 29 2017
istio managing kube-system without breaking it seems like a much bigger task than just making the excluded namespace configurable
this being said I think we should have a whitelist/blacklist and selector based setup instead of the current 1 namespace vs all namespaces (minus kube-system) setup. but none of that is for 0.2

This is still valid.


I cannot build it on VS 2017 15.6

I cannot build this application on VS 2017 15.6.
I've tried to upgrade the NuGet packages but with no success.

same here. Tried in VS 2015 too with no success.


Symbol lookup opens an editor documentation at wrong position

Godot version
ebac430445ade41301e65508366217827cfc3574
System information
Windows 10
Issue description

Steps to reproduce
^^
Minimal reproduction project
Too easy to reproduce

This is likely the same cause as https://github.com/godotengine/godot/issues/52124.


Bug fixes and performance improves

Hi,
Tianzheng and I have made some changes to improve the overall performance and added more features so other projects can easily use this library.
Major changes:

Refactor the build system so that users can optionally use Google Framework
Fixed some bugs and improved the performance.
Corrected the header inclusion and removed the necessary dependencies.

Thanks!
Xiangpeng

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: HaoPatrick sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Revise subclass] autosomal dominant nonsyndromic hearing loss (MONDO:0019587)

Mondo term (ID and Label)
I noticed that
autosomal dominant nonsyndromic hearing loss (MONDO:0019587)
seems to have a logical inconsistency .

It is broader than its 2 parents
prelingual non-syndromic genetic hearing loss
postlingual non-syndromic genetic hearing loss
(if these are both autosomal, they should be subclasses, not superclasses)
The logical conclusion of this organization is that  we have exact overlap between annotations:

where I would expect them to be mutually exclusive?
Suggested revision and reasons
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Dear @ValWood,
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team

Hi @ValWood,
We agree with your finding above and have removed all instances where the concept is a child of both pre and post-lingual non-syndromic genetic hearing loss.
Thank you,
Yousif

We also made "prelingual non-syndromic genetic hearing loss" and "postlingual non-syndromic genetic hearing loss" Mondo terms disjointed as we think that a disease cannot be both pre and post lingual non-syndromic hearing loss at the same time.
If (or when) we find an example of a disease can can be both, we will remove the disjointness.


maintainers/team-list: add cloudposse team for atmos

Description of changes

To allow for additional maintainers for the atmos package, we can use the official cloudposse team to keep it maintained.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc: @dudymas @osterman

cc: @dotlambda please review once more

cc: @dotlambda friendly ping
@osterman @dudymas please weigh in if this looks appropriate from slack discussions

Why do we need a team if it's only used in one package?

Please squash the last two commits and change the order of the then remaining ones.

This looks good to me. I mentioned in slack that @mcalhoun might want to also be added to the team.

cc: @dotlambda can we merge this first and then the rest of the cloudposse team can add additional users when needed?

cc: @dotlambda @LeSuisse @roberth

Thank you for your commitment to help out with package maintenance! :heart:


Will fix in a sec.


Added LUKSO and LUKSO Testnet

This PR adds LUKSO Mainnet and Testnet to the Ethereum ledger app.
Note that LUKSO mainnet uses "42", the chain ID of the deprecated/dead Kovan testnet.
This chain ID and network has also been updated in the official chain list repository:
https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-42.json
As a note to reusing "42" as chain ID: The LUKSO mainnet has a strong relation to 42. It has 42M total supply chosen by the people and started fully decentralised with the LUKSO team not running a single validator. It was started at 4:20 UTC and is also the answer to the universe and everything ;)
We are ware of that issue of transaction replays from Kovan, but we see this as minimal as no-one should reuse testnet addresses on mainnets. Additionally the main way for people to hold assets and interact on LUKSO, is through universal profile smart contract, which are not repayable using koran addresses.

LGTM.
Indeed Kovan is considered "dead", plus it was a testnet anyway.
@vforgeoux-ledger can you please ensure this gets merged please.

I think these changes have been included in this PR:
https://github.com/vforgeoux-ledger/app-ethereum/pull/1

Closing because it has been merged
https://t.co/4z9lwyeCw9


Verify Task partitions on GCE

We have ATs running on GKE and a partitioned job was verified on k8s explicitly, too.


Added option to use pre-existing network resources

Description of changes:

Update CloudFormation template to allow users to use a pre-existing VPC. By providing VPC ID, Private Subnets IDs, and Route Table ID.
Update Automatic Installation script to support pre-existing VPCs.
Remove unused public IPs for EC2 instances inside private subnets
Remove unneeded TerraformAutoscalingGroup’s AvailabilityZones

+1


Context Menu Slow to Open

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When I right click on a file item the right click context menu takes at least a few seconds, which is considerably slower than native File Explorer and frequently interrupts my flow of using this app, making it unusable for me.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I want it to show context menu as soon as possible, and if need be, load additional context menu items asynchronously, that way items that should be readily available  (cut, copy paste) don't need to wait for context items that need more time to load in.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Using native file explorer.
Additional context
Add any other context or screenshots about the feature request here. Ex: What device type/UI layout and app version?
This is my context menu for reference

Basically if we can have an instant access to these items on right click and load in the rest as they come in, that would improve UX by a lot

How about using a CommandBarFlyout instead of a MenuFlyout?
Would that cause any problems?

I can reproduce it. But IMHO it is more a bug or misbehaviour than a new feature.

Some findings on this.
I've added a stopwatch in a couple of checkpoints to see what is taking the longest:

QueryContextMenu, 1 line
LoadContextMenu function in fulltrust process, which includes [1]
SetShellContextMenu function, which includes [1] and [2] and is the total time taken to show the menu items

QueryContextMenu [ms]
LoadContextMenu [ms]
SetShellContextmenu [ms]

57
70
93

334
368
420

1576
1609
1681

2208
2232
2285

More than 80% of the time is taken by the single line QueryContextMenu and the time taken by it varies greatly from a few milliseconds to more that two seconds. Anything above ~800ms is perceivable as a delay.
QueryContextMenu is pretty much a single Win32 API call so I'm not really sure on how to improve this.
One possibility is to call this without passing the CMF_SYNCCASCADEMENU option (synchronously load submenus), need to check if there are any unwanted side effects.

If I can assist with solving this issue by any means please let me know.
The project looks very promising, but almost 2 sec to open a context menu is just too much for most people.
I have some c# skills to utilize.

If I can assist with solving this issue by any means please let me know.
The project looks very promising, but almost 2 sec to open a context menu is just too much for most people.
I have some c# skills to utilize.

This should be included in work done in #4180

Can't we improve performance by hiding no-needed items?
I think it'll be better if the editor of right-click menu which valid only for Files available.

I think this just make sense when you select a file. In the normal explorer we have different entries for File, Folder and nothing is selected.

This issue should be resolved in main.


[Bug] Resolution of captured images is extremely low

First of all, the app looks great so far! Thank you for all the work you've put into it.
It's fast, easy to use with a nice tutorial, and the edge detection works great.
I'd like to switch, but there's a problem with the image resolution:
It's always extremely low, as if only a thumbnail was used. This is both when adding pages using normal scan, and importing from gallery.
I'm using a Samsung Galaxy S20 (Android 11) and the OpenScan version currenly on Google Play.

Unsure why this happens. We received two other similar reports.  By default, the image is compressed only by 10% to reduce storage occupied.

Unsure why this happens. We received two other similar reports.  By default, the image is compressed only by 10% to reduce storage occupied.

Ok, let me know if there's anything I can do to help.

Ok, let me know if there's anything I can do to help.

I'm getting the same issue. My image file in the openscan/files folder is 400x300 pixels, when the input image was 2560x1920 (taken by net.sourceforge.opencamera).
This is happening on OpenScan version from play store, on Samsung S3 Mini, running lineageos (not quite sure which version from top of my head).

I'm getting the same issue. My image file in the openscan/files folder is 400x300 pixels, when the input image was 2560x1920 (taken by net.sourceforge.opencamera).
This is happening on OpenScan version from play store, on Samsung S3 Mini, running lineageos (not quite sure which version from top of my head).

Unsure why this happens. We received two other similar reports. By default, the image is compressed only by 10% to reduce storage occupied.

Hmm.. I also have same problem, after cropped the image, I feel like quality worst.
My device's resolution is 720x1280 (Set low for battery saver), I load photo from gallery (High quality), after cropped I can see the photo not very sharp.
Is it related to device's screen resolution? If the device's resolution high, app will keep more details, else quality will lost.

Yeah, currently the way the image is being saved is weird. The resolution of the image being cropped is reduced to what is visible on the screen. If the original resolution of the image is preserved, the app crashes. We are working on a solution which should hopefully fix this bug.

@veejayts and @vikram0230
The app is great, especially the auto-cropping feature.
On a Samsung S10 there is the same issue with low resolution after cropping. This issue makes the whole app more or less useless.

I found a solution!
At function setBitmap in file ScanFragment.java, just change this:
    this.original = scaledBitmap;

to
this.original = original;
should look like this:
   private void setBitmap(Bitmap original) {         Bitmap scaledBitmap = scaledBitmap(original, sourceFrame.getWidth(), sourceFrame.getHeight());         this.original = original;         sourceImageView.setImageBitmap(scaledBitmap);         Bitmap tempBitmap = ((BitmapDrawable) sourceImageView.getDrawable()).getBitmap();         Map<Integer, PointF> pointFs = getEdgePoints(tempBitmap);         polygonView.setPoints(pointFs);         polygonView.setVisibility(View.VISIBLE);         int padding = (int) getResources().getDimension(R.dimen.scanPadding);         FrameLayout.LayoutParams layoutParams = new FrameLayout.LayoutParams(tempBitmap.getWidth() + 2 * padding, tempBitmap.getHeight() + 2 * padding);         layoutParams.gravity = Gravity.CENTER;         polygonView.setLayoutParams(layoutParams);     }

If you want a better quality for B&W filter, just change from:
Mat mbgra(info.height, info.width, CV_8UC4, pixels);
// init our output image
Mat dst = mbgra.clone();

cvtColor(mbgra, dst, CV_BGR2GRAY);

//    float alpha = 2.2;
//    float beta = 0;
//    dst.convertTo(dst, -1, alpha, beta);
threshold(dst,dst,0,255,THRESH_BINARY | THRESH_OTSU);

to:
Mat mbgra(info.height, info, CV_8UC4, pixels);
// init our output image
Mat dst = mbgra.clone();

cvtColor(mbgra, dst, CV_BGR2GRAY);
float alpha = 1.8;
float beta = -80;
dst.convertTo(dst, -1, alpha, beta);

//threshold(dst,dst,50,255,THRESH_BINARY | CV_THRESH_TRIANGLE);

//threshold(mbgra,dst,100,255,THRESH_BINARY | THRESH_OTSU);

threshold(mbgra,dst,100,255, THRESH_OTSU| CV_THRESH_BINARY);

@tiagoclc Could you create a PR implementing this fix in dev_v2.2.0 branch?


[docs-infra] Show props in the table of content

Works on material
For @mui/base, the pipeline work but is not rendered because the ToC does not display at that depth (see here). The additional depth comes from the fact one page can contain multiple components
Could be nice to also add slots and CSS

does not display at that depth (see here).

The value of one page per API 😁


Please add compatibility matrix in readme.md

Everytime I want to add Vuetify to a Nuxt project, I have to check both @nuxtjs/vuetify and vuetify-nuxt-module to see if one of them is compatible with my project.
But there is no simple indicators nor introductions which Vuetify and Nuxt is supported, so I have to check the package.json mannually.
Please try add one, thanks.
Example:

https://docs.gradle.org/current/userguide/compatibility.html
https://kotlinlang.org/docs/multiplatform-compatibility-guide.html

This module should be compatible with any Nuxt 3.6.5+ and Vuetify 3., rn I only need to include support for 3.12..
I'll try to add a custom page to the docs...

Good to hear that .

@DevDengChao I do my best with older versions checking tags and commits, I'll keep the new page updated for new releases.


Perform an a11y/WCAG review

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?

We've got a decent userbase and haven't holistically looked at accessibility for our case management corps. Disability and accommodation are a reproductive justice issue so we should take the time to step back and make sure our software matches our values on this.

What feature or behavior is this required for?

Making sure anyone who wants to case manage can do so without fighting with our system.

How could we solve this issue? (Not knowing is okay!)

We should use this ticket to go thru the a11y and WCAG lists and see what they recommend doing, what linters we can set up, etc. I suspect there are easy wins to be had.

Anything else?

Hold on implementing or breaking tickets out until the case management team has had a chance to add an accessibility question to their own case management materials.

@colinxfleming I'd like to tackle this. Here's what I'm thinking:

Generate reports on a subset of pages
Assess and prioritize fixes
Potentially add a11y linting step to CI process

@valeriecodes I think that's a wonderful game plan, and consistent with how we've done reviews on this project. (Personally, I take it to be a good sign that our approach matches yours!) I also think that this can be done independently of case management feedback, so no need to wait on that if you've got the energy to tackle this.
in short, thumbs up, this is a great plan. Is there a way I can be helpful on any of the parts you've identified?

@colinxfleming I'm gonna take a run at generating some reports and then I'll loop you in. ✨

@colinxfleming Here's what I came up with: https://docs.google.com/spreadsheets/d/1qh08MwZhg6ILWrzx-rMKJK3hbNv4RI8Z4s1k0osNieE/edit?usp=sharing
These are generated using axe and axe-reports, with a Selenium script that I wrote and ran locally. There's certainly more surface area to cover.
I ran the report on a handful of pages and sorted by severity of issue. There are a lot of duplicates for items that are shared between pages. The critical issues all seem to be: images missing alt text or form fields missing labels. In the serious category are a few color contrast issues and lack of link label/text.

honestly I think if we get the main stuff that CMs interact with (login page, main dashboard, patient edit page) that gets us pretty far! and it seems that this does, so I think this is a wonderful list that makes a significant stride toward making DARIA much more accessible for CMs. (I think doing it for the other views is awesome too but the bulk of our users are case managers.)
It also looks like these are all pretty squashable -- I think either we can spin them up as small scope individual hacknight issues (which I'm happy to write) or @valeriecodes you are more than welcome to do the honor of knocking them out if you're so inclined. Which approach would you prefer to take?
If you still have the script handy, having that checked in would be dreamy, but NBD if you don't anymore or don't want to check it in for whatever reason.

I'll knock 'em out! The script is here: https://gist.github.com/valeriecodes/459cf5e4039cc5b0ec3034cd0236b4c3
I did it semi-manually and would require some additional work to turn into something that could be run and have it spit out something useful on any computer, but with that caveat I'm happy to check it in still if you'd like.

I def don't think it's necessary to make it reproducible, but I do think it's good news to have some reference to what happened in case we do decide we need to look at it again someday. thank you very much for checking that into a gist!

@valeriecodes feels like the meat of this got resolved in #1704, but I'm curious about the a11y linting step - would you recommend we implement that (and if so, can you recommend a strategy?), or does that feel like more trouble than it's worth?

not to minimize the importance of this but I think at this point we won't be doing much on this further unless a fund specifically asks for it and IDs specific problems. Not sure we have the expertise to do this properly independently (to say nothing of the engineering headroom). Closing as a wontfix for the time being, and big thanks to @valeriecodes for doing some wonderful  work on this.

I can pick this up now. Will create separate issues for the findings and add the appropriate "Beginner-friendly" label so that Code for DC folks can pick them up.


Figure out how to handle/ensure data de-identification

Is the onus on us or them to ensure it is de-identified? If us, what can we do about it? We want no-one in the loop when performing the assessment+solution, if possible.

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing.  If non-deidentified data is accidentally transmitted, OCP will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute.  Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

mm spent 3 months of his life dealing with a student losing a laptop with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray<EMAIL_ADDRESS>wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute. Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

Right. But if someone screws up we should be clear that we aren't responsible for fixing?
On Thu, Jul 2, 2015 at 5:03 PM, joshua vogelstein
<EMAIL_ADDRESS>wrote:

mm spent 3 months of his life dealing with a student losing a laptop with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray<EMAIL_ADDRESS>wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute. Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York
Reply to this email directly or view it on GitHub:
https://github.com/openconnectome/m2g/issues/100#issuecomment-118167521

I'm a grad student and I accidentally uploaded the wrong version of the images....oppose. Can you please remove all traces of the pii?
On Thu, Jul 2, 2015 at 5:03 PM, joshua vogelstein
<EMAIL_ADDRESS>wrote:

mm spent 3 months of his life dealing with a student losing a laptop with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray<EMAIL_ADDRESS>wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute. Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York
Reply to this email directly or view it on GitHub:
https://github.com/openconnectome/m2g/issues/100#issuecomment-118167521

i'm not sure whether that works, i'm unwilling to take a risk.
On Thu, Jul 2, 2015 at 5:28 PM, William Gray<EMAIL_ADDRESS>wrote:

I'm a grad student and I accidentally uploaded the wrong version of the
images....oppose. Can you please remove all traces of the pii?
On Thu, Jul 2, 2015 at 5:03 PM, joshua vogelstein
<EMAIL_ADDRESS>wrote:

mm spent 3 months of his life dealing with a student losing a laptop with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray<EMAIL_ADDRESS>wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute.
Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what
can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
<
https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798>.

--
the glass is all full: half water, half air.
openconnecto.me, jovo.me, office hours
<
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

Reply to this email directly or view it on GitHub:
https://github.com/openconnectome/m2g/issues/100#issuecomment-118167521

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118172849.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

I wondered about that.  The problem is that if you have a webservice that
anyone can use, how do you prevent accidents?  People are notoriously bad
at stuff like this...
Best,
Will
On Thu, Jul 2, 2015 at 7:57 PM, joshua vogelstein<EMAIL_ADDRESS>wrote:

i'm not sure whether that works, i'm unwilling to take a risk.
On Thu, Jul 2, 2015 at 5:28 PM, William Gray<EMAIL_ADDRESS>wrote:

I'm a grad student and I accidentally uploaded the wrong version of the
images....oppose. Can you please remove all traces of the pii?
On Thu, Jul 2, 2015 at 5:03 PM, joshua vogelstein
<EMAIL_ADDRESS>wrote:

mm spent 3 months of his life dealing with a student losing a laptop
with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray<EMAIL_ADDRESS>

wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP
will
make a best-effort to scrub the offending information, but can make no
guarantees that it is completely or securely wiped from our systems in
compliance with the IRB or PII policy of the collecting institute.
Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>wrote:

Is the onus on us or them to ensure it is de-identified? If us, what
can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
<
https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798
.

--
the glass is all full: half water, half air.
openconnecto.me, jovo.me, office hours
<

https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

Reply to this email directly or view it on GitHub:

https://github.com/openconnectome/m2g/issues/100#issuecomment-118167521

—
Reply to this email directly or view it on GitHub
<https://github.com/openconnectome/m2g/issues/100#issuecomment-118172849
.

--
the glass is all full: half water, half air.
openconnecto.me, jovo.me, office hours
<
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118196840.

we de-identify everything, possibly forcing them to go through a HIPPA
certified location, S3 is working on this.
On Thu, Jul 2, 2015 at 8:00 PM, William Gray<EMAIL_ADDRESS>wrote:

I wondered about that. The problem is that if you have a webservice that
anyone can use, how do you prevent accidents? People are notoriously bad
at stuff like this...
Best,
Will
On Thu, Jul 2, 2015 at 7:57 PM, joshua vogelstein <
<EMAIL_ADDRESS>wrote:

i'm not sure whether that works, i'm unwilling to take a risk.
On Thu, Jul 2, 2015 at 5:28 PM, William Gray<EMAIL_ADDRESS>wrote:

I'm a grad student and I accidentally uploaded the wrong version of the
images....oppose. Can you please remove all traces of the pii?
On Thu, Jul 2, 2015 at 5:03 PM, joshua vogelstein
<EMAIL_ADDRESS>wrote:

mm spent 3 months of his life dealing with a student losing a laptop
with
PHI.
i'm not taking any data that is not DID, no matter what.
On Thu, Jul 2, 2015 at 4:11 PM, William Gray <
<EMAIL_ADDRESS>

wrote:

Maybe a partial solution is to have a disclaimer like:
OCP only accepts de-identified data, unless expressly permitted in
writing. If non-deidentified data is accidentally transmitted, OCP
will
make a best-effort to scrub the offending information, but can make
no
guarantees that it is completely or securely wiped from our systems
in
compliance with the IRB or PII policy of the collecting institute.
Because
OCP handles deidentified data only, we do not have an IRB in place
ourselves.
Best,
Will
On Thu, Jul 2, 2015 at 4:07 PM, Greg Kiar<EMAIL_ADDRESS>

wrote:

Is the onus on us or them to ensure it is de-identified? If us,
what
can
we do about it? We want no-one in the loop when performing the
assessment+solution, if possible.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100.

—
Reply to this email directly or view it on GitHub
<

https://github.com/openconnectome/m2g/issues/100#issuecomment-118152798

.

--
the glass is all full: half water, half air.
openconnecto.me, jovo.me, office hours
<

https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

Reply to this email directly or view it on GitHub:

https://github.com/openconnectome/m2g/issues/100#issuecomment-118167521

—
Reply to this email directly or view it on GitHub
<
https://github.com/openconnectome/m2g/issues/100#issuecomment-118172849
.

--
the glass is all full: half water, half air.
openconnecto.me, jovo.me, office hours
<

https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

—
Reply to this email directly or view it on GitHub
<https://github.com/openconnectome/m2g/issues/100#issuecomment-118196840
.

—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/100#issuecomment-118197225.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

migrated and linked


feat: Include Correlation ID in Logs

closes: #4852

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.30%. Comparing base (ec96e72) to head (f1ea895).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4857   +/-   ##
=======================================
  Coverage   39.30%   39.30%
=======================================
  Files         116      116
  Lines       10898    10898
=======================================
  Hits         4284     4284
  Misses       6242     6242
  Partials      372      372

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Want to add a back-to-top feature

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Scrollbars cannot return to their original state when switching content
Describe the solution you'd like
A clear and concise description of what you want to happen.
Let the scroll area go back to the top when clicking on the toggle
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I think back to top is a feature that is not related to the lib. You can implement your own button.


perf: Text fixes

We will have 2 physical cores at our disposal, not 4...

Aren't the VM images going to be replicated on 16 core instances?

Yes, but I'm assuming that my display will be projected somewhere, so the attendees will see that we have 2 cores, and 2 cores will be used. The idea was to explicitly tell them to replace 2 with whatever they see, and if they can't get it right, we'll fix it. Also because we don't know whether those are 16 cores on a single socket, or 8+8, or whatever...

I thought we were going to sit on the same 16-core nodes? But maybe not, mhhh... :thinking:
In any case, this is fine, as long as you explain in the talk what to do.

Ok, then. Merging...


Make mr-fusion public

Make mr-fusion accessible to tutorial participants and external collaborators
Install PBSPro

Related to #642, #737

First phase of setup will include slurm as the only RM. PBSPro will be installed post-SC for collaboration w/ Altair.


How to train wake-up words on Android

Make sure you have read the documentation, and have put forth a reasonable effort to find an existing answer.
Expected behaviour
Train wake-up words on the Android platform
Actual behaviour
Train wake-up words only for Linx, MacOS and Windows platforms
Steps to reproduce the behaviour
(Include enough details so that the issue can be reproduced independently.)
I can only choose to train the wake-up words on Linux platform. Can I use them on Android platform

@laves

Custom wake words are not available with personal accounts outside of Linux, Mac, and Windows.


Type issue with global use

Hi!
I'm trying to use global middleware like this:
import { QueryClient } from "@tanstack/react-query";

const queryClientService = new QueryClient({
  defaultOptions: {
    queries: {
      use: [],
    },
  },
  queryCache: QueryCacheService,
  mutationCache: MutationCacheService,
});

But I have an error here:
Object literal may only specify known properties, and 'use' does not exist in type 'OmitKeyof<QueryObserverOptions<unknown, Error, unknown, unknown, QueryKey, never>, "suspense" | "queryKey", "strictly">'.

I'm trying to extend DefaultOptions interface, but nothing helps...

declare module "@tanstack/react-query" {
  // Add meta options to queries and mutations
  interface Register {
    queryMeta: QueryMeta;
    mutationMeta: MutationMeta;
  }

  // Extend DefaultOptions to add middleware for queries and mutations
  export interface DefaultOptions<TError = DefaultError>
    extends OriginalDefaultOptions<TError> {
    queries?: OmitKeyof<
      QueryObserverOptions<unknown, TError>,
      "suspense" | "queryKey"
    > & {
      use?: Middleware<QueryHook>[];
    };
    mutations?: MutationObserverOptions<unknown, TError, unknown, unknown> & {
      use?: Middleware<MutationHook>[];
    };
    use?: Middleware<QueryHook>[];
  }
}

try to pass any type to QueryHook
 export interface DefaultOptions<TError = DefaultError>
    extends OriginalDefaultOptions<TError> {
    queries?: OmitKeyof<
      QueryObserverOptions<unknown, TError>,
      "suspense" | "queryKey"
    > & {
      use?: Middleware<QueryHook<any,any,any>>[];
    };
    mutations?: MutationObserverOptions<unknown, TError, unknown, unknown> & {
      use?: Middleware<MutationHook<any,any,any>>[];
    };
  }

@liaoliao666 Thanks for advice, unfortunately it doesn't work...
I don't now why, because as I mentioned above - the line with simple use (not in the queries object) - works fine.
Maybe it would be useful to add this instruction to the documentation?

if you do not put use in the queries or mutations object of defautOptions it wont work.

@vlanemcev @liaoliao666 any advancements regarding the use of "use" in global react query options?

@SGeri I just ignored TS error, because it works well


Improve the tests in the homebrew formula

They aren't very good at the moment and don't really properly test if the application is working.

You can find the tests in the template


[QualifiedName] Adding hash method

This PR adds the __hash__ method to the QualifiedName type so that,
>>> a = QualifiedName(('foo', 'bar'))
>>> b = QualifiedName(('foo', 'bar'))
>>> hash(a) == hash(b)
True

which will allow a QualifiedName object to uniquely represent a dictionary key or item in a set.

Looks good!


Add basic Realm panel

[ ] add the panel on the left - can be empty for now
[ ] make sure it is scrollable
[ ] make sure top and bottom whitespace is correct
[ ] make sure it is displayed correctly when user selects the realm

Resolved by https://github.com/tahowallet/dapp/pull/774


optimize: remote configuration reading

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes #3798
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #4146 (82312ab) into develop (ea89cec) will decrease coverage by 0.07%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             develop    #4146      +/-   ##
=============================================
- Coverage      49.77%   49.70%   -0.08%
- Complexity      3768     3770       +2
=============================================
  Files            700      700
  Lines          23608    23623      +15
  Branches        2912     2884      -28
=============================================
- Hits           11751    11741      -10
+ Misses         10663    10662       -1
- Partials        1194     1220      +26

Impacted Files
Coverage Δ

.../main/java/io/seata/config/ConfigurationCache.java
76.06% <83.33%> (+2.80%)
:arrow_up:

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
:arrow_down:

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
:arrow_down:

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
:arrow_down:

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
:arrow_down:

...otobuf/convertor/BranchReportRequestConvertor.java
95.45% <0.00%> (-4.55%)
:arrow_down:

...tobuf/convertor/BranchReportResponseConvertor.java
95.45% <0.00%> (-4.55%)
:arrow_down:

... and 15 more

I think the troubleshooting path will be increased. It is not clear whether the configuration center configuration or local configuration is used.
This situation is mainly to fix several dataid configuration problems. If the client has only one dataid, the probability of occurrence will be greatly reduced.
Therefore, I still suggest the fail-fast solution. When the key configuration is missing and there is no default value, an error will be throwed directly.

I think the troubleshooting path will be increased. It is not clear whether the configuration center configuration or local configuration is used.
This situation is mainly to fix several dataid configuration problems. If the client has only one dataid, the probability of occurrence will be greatly reduced.
Therefore, I still suggest the fail-fast solution. When the key configuration is missing and there is no default value, an error will be throwed directly.

fast failure will bring some unnecessary troubles. For example, when I want to debug a configuration item locally and put it in the configuration center after the desired effect, this will not be possible. Unless you switch back and forth between file and other configuration centers, this will be cumbersome and redundant. We should not have file mode, but a way of combining file with other configuration centers.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: a364176773:x: slievrly:x: xingfudeshiYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix #83 JSON node equal to true|false|null aware

Thank you @bystro I'm going to tag a bugfix release right now.


Sik-Ho Tang | Review: Shake-Shake Regularization (Image Classification).

Sik-Ho Tang. Review: Shake-Shake Regularization (Image Classification).

Overview
In this story, Shake-Shake Regularization (Shake-Shake), by Xavier Gastaldi from London Business School, is briefly reviewed. The motivation of this paper is that data augmentation is applied at the input image,

data augmentation might be also possible to apply data augmentation techniques to internal representations.

It is found in prior art that adding noise to the gradient during training helps training and generalization of complicated neural networks. And

Shake-Shake regularization can be seen as an extension of this concept where gradient noise is replaced by a form of gradient augmentation.

This is a paper in 2017 ICLR Workshop with over 10 citations. And the long version in 2017 arXiv has got over 100 citations.

Shake-Shake Regularization

Left: Forward training pass. Center: Backward training pass. Right: At test time.

In particular, 3-branch ResNet is studied in this paper as in the above figure, with the equation as below:

With Shake-Shake Regularization, $\alpha$ is added:

$\alpha$ is set to $0.5$ during test time, just like Dropout.

Experimental Results
CIFAR-10
26 2×32d ResNet (i.e. the network has a depth of 26, 2 residual branches and the first residual block has a width of 32) is used.

Forward & Backward:

Shake: All scaling coefficients are overwritten with new random numbers before the pass.
Even: All scaling coefficients are set to 0.5 before the pass.
Keep: For the backward pass, keep the scaling coefficients used during the forward pass.

Level:

Batch: For each residual block $i$, the same scaling coefficient is applied for all the images in the mini-batch.
Image: For each residual block $i$, a different scaling coefficient is applied for each image in the mini-batch.

Error Rates of CIFAR-10.

Using Shake at forward pass has better performance.

And Shake-Shake-Image (S-S-I) obtains the best result for 26 2×64d ResNet and 26 2×96d ResNet.

CIFAR-100

Error Rates of CIFAR-100.
Using Shake at forward pass again improves the performance.
Particularly, Shake-Even-Image (S-E-I) is the best.

Comparison with State-of-the-art Approaches

Test error (%) and Model Size on CIFAR.
On CIFAR-10, S-S-I outperforms WRN, ResNeXt and DenseNet.
On CIFAR-100, S-E-I outperforms WRN, ResNeXt and DenseNet as well.

Further Evaluation
Correlation Between Residual Branches

To calculate the correlation, first forward the mini-batch, through the residual branch 1 and store the output tensor in $y_{i}(1)$. Similar for residual branch 2 and store it in $y_{i}(2)$.
Then flatten $y_{i}(1)$ and $y_{i}(2)$ as $flat_{i}(1)$ and $flat_{i}(2)$ respectively. And calculate the covariance between each corresponding item in 2 vectors.
Calculate the variances of $flat_{i}(1)$ and $flat_{i}(2)$.
Repeat until all images in the test set. Use the resulting covariance and variances to calculate the correlation.

Correlation results on E-E-B and S-S-I models.

First of all, the correlation between the output tensors of the 2 residual branches seems to be reduced by the regularization. This would support the assumption that the regularization forces the branches to learn something different.

Layer-wise correlation between the first 3 layers of each residual block.
The summation at the end of the residual blocks forces an alignment of the layers on the left and right residual branches.
The correlation is reduced by the regularization.

Regularization Strength

Update Rules for $\beta$.

Left: Training curves (dark) and test curves (light) of models M1 to M5. Right: Illustration of the different methods in the above Table.
The further away $\beta$ is from $\alpha$, the stronger the regularization effect.

Removing Skip Connection / Batch Normalization

Architecture A is 26 2×32d but without skip connection.
Architecture B is the same as A but with only 1 convolutional layer per branch and twice the number of blocks.
Architecture C is the same as A but without batch normalization.

Error Rates of CIFAR-10.

The results of architecture A clearly show that shake-shake regularization can work even without a skip connection.
The results of architecture B show that regularization no longer works.
Architecture C makes the model difficult to converge, makes the model a lot more sensitive. It is also really easy to make the model diverge.

With the simple yet novel idea and of course the positive results, it is published in 2017 ICLR Workshop which is very encouraging.

References

[2017 arXiv] [Shake-Shake] Shake-Shake Regularization.
[2017 ICLR Workshop] [Shake-Shake] Shake-Shake Regularization of 3-Branch Residual Networks.


Transcribe result extraction too time consuming

Hi, sorry for interrupting. And thanks for this great work!
I am trying to combine this faster whisper with Pyannote speaker diarization following the code here:
https://github.com/yinruiqing/pyannote-whisper/blob/main/pyannote_whisper/utils.py
According to my experiment,
It took  0.5442 second(s) to Whisper transcribe using this faster whisper.
It took  11.9825 second(s) to Pyannote diarize.
It took  19.0851 second(s) to merge results.
So in the merging part, most of the time is spent on the transcribe result extraction function:
It took  19.0565 second(s) to extract from whisper result.
It took  0.0284 second(s) to add spk info to text.
It took  0.0002 second(s) to merge sentences.
The transcribe extraction function (modified a little bit based on your format here) is creating a list of sentence timestamps and text contents:
def get_text_with_timestamp_fromsegments(transcribe_segments):
   timestamp_texts = []
   for item in transcribe_segments:
       start = item.start
       end = item.end
       text = item.text
       timestamp_texts.append((Segment(start, end), text))
   return timestamp_texts

So basically, this function takes most of the execution time. Wondering if you can give some suggestions on how to extract transcribe results faster here? Thank you!

Hi,
See issue #67.
Basically the model returns a generator over segments. So the transcription only starts when you iterate over the segments.
If you don't like this behavior, you can get all segments in a list:
segments, _ = model.transcribe("audio.mp3")
segments = list(segments)  # The transcription will run in this line.

Oh, thanks for your fast reply!
Sorry for my misunderstanding.


add configuration for body parse and proxy body parse to skip some endpoints

Some users are using base64 to upload the files and we don't want to parse the body and do the validation.

This has been fixed in the config to filter only certain endpoints


[NFR]: Add StartsWith trait

Add StartsWith trait to check whether a string ends with a particular string

Resolved in 6dc0dff4bfeb0b5c39a03745d599096b957f3d7d


Wrong childnode selected for Content

Hi,
I was trying your code in a svelte project using the demo code
html:

Header

Content

  import { CupertinoPane } from "cupertino-pane";
I had to change the esm bundle line 184 to select childNode 2 instead of 1 for content in order for the code to work.
 // Content
 this.contentEl = this.el.childNodes[1];

into this.el.childNodes[2]
Otherwise it would say it tries to set transition on undefined in the following line:
 this.contentEl.style.transition = "opacity " + this.settings.animationDuration + "ms " + this.settings.animationType + " 0s";        this.contentEl.style.overflowX = 'hidden';
Given the html, this.el.childNodes[1] is a text element, where is [2] is a div it needs to attach to.
Not sure if this is typical svelte thing, but I do guess svelte does not add extra dom elements (its not known for it). So this may be an error in your code?
My code: https://github.com/Tommertom/svelte-ionic-app/blob/master/src/pages/ionic/Pane.svelte
And demo: https://ionicsvelte.firebaseapp.com/pane

@Tommertom Thanks for your attention!
I will use your link in readme for temporary demonstration.
https://ionicsvelte.firebaseapp.com/pane
Regarding to your issue
I found that svetle add additional Element text to nodeList after each div
<ion-content>
...

</ion-content>

Outputs

That's reason of incorrect DOM assigment.
Solution
i did some enhancements to prevent similar cases.
No required for now to specify entries inside common container:

  Any content can placed here

  ...

hide-on-bottom attribute will set opacity:0 for element if bottom breakpoint reached
In your case you can just update package and it should works without errors!

Yup. seems to work like a charm. Sorry to see svelte doing the additional element.
Thx for updating.


docs: update fswatch example to use dune exec -w

Since fswatch isn't used anymore, I've renamed the example to w-watch-mode. It's now just a nice little tip for anyone getting started with dune and dream.
R esolves https://github.com/aantron/dream/issues/81

Thank you!
I undid the directory move to help git understand the history. When one combines a massive rewrite (like the README in this PR) together with a renaming, git thinks that a file was deleted and a new one was created. I left the rewriting in this PR, and I'll do the renaming in a separate commit after this PR, and also update all the links to the example from the README and the example index.

Awesome. I’ll do the git mv manually next time then. 😂 high bar for git cleanliness here.

great catch on the links.

Awesome. I’ll do the git mv manually next time then. 😂 high bar for git cleanliness here.

Yeah I too often have to dig in git history and the cleaner it is the easier it is in the future, git history is like a form of documentation, especially when you eventually are able to reach the various PRs that caused something. There is often a lack of comments in the code but plenty of discussion in the PR. So it helps the archaelogy to keep the history clear :)


Is it possible to determine file type to search or folder to exclude (node_modules f.e)

Describe your question
I want the project to ignore searching through node_modules.
Additional context
I mentioned it as part of the instructions and as part of the repo's readme. But still, sometimes I keep getting it to search through all the node_modules and get stuck.

We could probably add an option to sandbox so that all files under .gitignore are invisible to the agent.
Could you please try prompting the agent to respect .gitignore (assuming your project is under git control)?

Yeah, I can try. What will change from what I did when prompting and requesting specifically not to search within node_modules?

Didn't work

I am not too surprised about that. I think we should allow users to let agent skip everything defined in .gitignore.

Yeah some kind of prompt wrapper that will be enforced with every action

Good for both relevancy and security

@4tal the latest on main hides special folders like .git and node_modules. This isn't exactly the same as respecting the .gitignore but let us know if this helps with your node_modules issue.

I was looking at a fix similar to this, but saw it was reverted.
@yufansong Can you provide some context as to why this was removed, and/or where the fix should for ignoring certain files should be made.  Is this something just do at the prompt level?

What was reverted, were changes of mine to deprecated classes.
The net changes for the server-side filtering of paths is here:
https://github.com/OpenDevin/OpenDevin/blob/a97d0767e90934d0dcc82e281e8da76af220a937/opendevin/server/listen.py#L256
Personally, I'd be against using .gitignore as the source for filtering as that file can be hundreds of lines.

Is there a way for a prompt to include information the contents of a file, or specifically, to include the contents of the .gitignore?
After experimenting with the system prompt, I found that if I explicitly listed the files to ignore (eg. "ignore the main.py and index.py files as they are in the .gitignore", the agent would consistently ignore them.  However, instructions for the agent to first read the .gitignore and then ignore all files listed there was unsuccessful.
Specifically, adding this to the minimal_system_prompt did not work:
When issuing any commands or viewing any files or folders, first make sure these files are not in the .gitignore, and if they are in the .gitignore please ignore them.

So your first step should be to see if there is a .gitignore file, and if there is a .gitignore file read the file so that you know what files to ignore.

If you believe any action should be taken with a file or folder in the .gitignore file or you should search these files, instead indicate you are skipping them because they are in the .gitignore file.

But if I specified the file names it was fine, and had a nice UX of saying when it found a match but was ignoring it.  So I am looking for a way to read this content into a prompt.  Can someone point me in the right direction?  I couldn't find a similar example of incorporating workspace info in the prompt.
For the curious, here are some other things I tried but did not work:

Telling the system prompt to ignore contents of .gitignore, then separately, as a user asking opendevin to read the .gitignore.  It read the contents, but kept answering questions about the .gitignore listed files.
Then as a user, sent another reminder to ignore contents of the .gitignore.  This didn't work.

Because of these experiments, I don't think sending OpenDevin a sequence of messages through code would work (like read the .gitignore, and then ignore those files).  It seems like the files need to be explicitly listed.

I experimented with updating the search_dir(search_term, dir_path='./') skill so that it took an exclude_files argument.  This sometimes worked, but other times, it would use the /api/list-files to find the file.

Is there a way for a prompt to include information the contents of a file, or specifically, to include the contents of the .gitignore?
After experimenting with the system prompt, I found that if I explicitly listed the files to ignore (eg. "ignore the main.py and index.py files as they are in the .gitignore", the agent would consistently ignore them. However, instructions for the agent to first read the .gitignore and then ignore all files listed there was unsuccessful.
Specifically, adding this to the minimal_system_prompt did not work:
When issuing any commands or viewing any files or folders, first make sure these files are not in the .gitignore, and if they are in the .gitignore please ignore them.

So your first step should be to see if there is a .gitignore file, and if there is a .gitignore file read the file so that you know what files to ignore.

If you believe any action should be taken with a file or folder in the .gitignore file or you should search these files, instead indicate you are skipping them because they are in the .gitignore file.

But if I specified the file names it was fine, and had a nice UX of saying when it found a match but was ignoring it. So I am looking for a way to read this content into a prompt. Can someone point me in the right direction? I couldn't find a similar example of incorporating workspace info in the prompt.
For the curious, here are some other things I tried but did not work:

Telling the system prompt to ignore contents of .gitignore, then separately, as a user asking opendevin to read the .gitignore. It read the contents, but kept answering questions about the .gitignore listed files.
Then as a user, sent another reminder to ignore contents of the .gitignore. This didn't work.

Because of these experiments, I don't think sending OpenDevin a sequence of messages through code would work (like read the .gitignore, and then ignore those files). It seems like the files need to be explicitly listed.

I experimented with updating the search_dir(search_term, dir_path='./') skill so that it took an exclude_files argument. This sometimes worked, but other times, it would use the /api/list-files to find the file.

I was looking at a fix similar to this, but saw it was reverted.

This commit was about GUI - whether we should display hidden folders on frontend.
@JeffKatzy I believe you are asking about the backend - how to make agent ignore everything recorded on .gitignore. I believe it is doable despite tedious. We should add a new config that says "respect .gitignore", and intercept the results from ls (and its variants).

@tobitege this can be closed due to this PR merging right?
https://github.com/OpenDevin/OpenDevin/pull/2621

@tobitege this can be closed due to this PR merging right? #2621

Yes, we can close this now. 👍


Try dagger.io instead of native github actions

Tried in branch.

The documentation is incomplete
its "hard to use", especially when you can't find any info in doc
when its working, its fast and nice
on zsh/osx it doesnt show output from steps, or its buggy ( rewrited lines from different steps )


Can Retain Some Terminal when close Atom?

Retain some terminal when closed Atom,and open it on launch Atom.
(Color ,Name)

@susautw! Thank you for reaching out to us with this question. Or is it a feature request... Its unclear.
If its a question, the answer is no.
if its a feature request, this project now relies solely on community contributed fixes, features and other additions, meaning its the users, like you/me/others that now must develop the plugin if they want x,y,z implemented/fixed or done.
Thank you in advance for understanding.
Fell free to Submit a PR or clarify what you want exactly, help others to help you better.

@the-j0k3r
yeah,It is a feature request.
I will try , if time allow.

Im not sure you can keep the platformio-ide-terminal open once you closed Atom, especially since this terminal needs Atom to be visible as its rendered inside.

Im not sure you can keep the platformio-ide-terminal open once you closed Atom, especially since this terminal needs Atom to be visible as its rendered inside.
There is an internal setting to keep terminal open When closing Atom, Try that.

You wont Get any terminals from inside Atom because its closed, and platformio-ide-terminal requires Atom to display the terminal.
If anyone knows a way to this, please submit a PR.
thanks


MSID: 101974 Version: 1 DOI: 10.1101/2<IP_ADDRESS>8067

MSID: 101974
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>8067
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=101974
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8067

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/101974v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>8067
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/101974/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Incorrect DOIs in DocMap - this needs to be fixed before publication

Above issue is captured in https://github.com/elifesciences/data-hub-issues/issues/987

(DOI issue resolved)

(Emailed author asking for bioRender links)


[CT-3391] [Regression] dbt clean fails with "directories outside the project" error

Is this a regression in a recent version of dbt-core?

[X] I believe this is a regression in dbt-core functionality
[X] I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior
After upgrading to dbt-core v1.7.1, dbt clean fails with a runtime error. (See log output below.)
Expected/Previous Behavior
In dbt-core v1.6.8, dbt clean executed smoothly, and I expected v1.7.1 to behave the same way.
19:02:25  Running with dbt=1.6.8
19:02:25  Checking target/*
19:02:25  Cleaned target/*
19:02:25  Checking dbt_packages/*
19:02:25  Cleaned dbt_packages/*
19:02:25  Finished cleaning all paths.

Steps To Reproduce

Install dbt-core v1.7.1.
Initialize a dbt project in the dbt directory of a GitHub repository.
Set the DBT_PROJECT_DIR environment variable to "dbt"
Add packages to a packages.yml file (see example below).
From the root of the GitHub repo, execute dbt deps to install them.
From the root of the GitHub repo, execute dbt clean to generate the runtime error.

packages:
  - package: dbt-labs/dbt_project_evaluator
    version: [">=0.8.0", "<0.9.0"]

Relevant log output
19:02:51  Running with dbt=1.7.1
19:02:51  Encountered an error:
Runtime Error
  dbt will not clean the following directories outside the project: ['/Users/katie.claiborne/github-repos/cbh-member-appts/dbt/target', '/Users/katie.claiborne/github-repos/cbh-member-appts/dbt/dbt_packages']

Environment
- OS: macOS-13.6.1-arm64-arm-64bit
- Python: 3.9.10
- dbt (working version): 1.6.8
- dbt (regression version): 1.7.1

Which database adapter are you using with dbt?
bigquery
Additional Context
Our project uses the default clean-targets config.
clean-targets:
  - "target"
  - "dbt_packages"

Thank you for opening this issue! I think this may have been intentionally introduced by https://github.com/dbt-labs/dbt-core/pull/8469.
A workaround may be to run dbt clean --no-clean-project-files-only. Could you please give that a try @katieclaiborne?

Oh yes, that works!
(venv) CBM-FVFGRAA9Q05N:cbh-member-appts katie.claiborne$ dbt clean --no-clean-project-files-only
21:38:44  Running with dbt=1.7.1
21:38:44  Checking /Users/katie.claiborne/github-repos/cbh-member-appts/dbt/target/*
21:38:44  Cleaned /Users/katie.claiborne/github-repos/cbh-member-appts/dbt/target/*
21:38:44  Checking /Users/katie.claiborne/github-repos/cbh-member-appts/dbt/dbt_packages/*
21:38:44  Cleaned /Users/katie.claiborne/github-repos/cbh-member-appts/dbt/dbt_packages/*
21:38:44  Finished cleaning all paths.

Nice! We should probably add this to the 1.7 upgrade guide

Nice! We should probably add this to the 1.7 upgrade guide

Per @MichelleArk's comment, closing this in favor of adding this to the upgrade guide: https://github.com/dbt-labs/docs.getdbt.com/issues/4482
Thanks again @katieclaiborne 🏆


Unexpected id column in the result

Query
PUT /nested_employees/
{"mappings":{"properties":{"comments":{"type":"nested","properties":{"date":{"type":"date"},"likes":{"type":"long"},"message":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}}}},"id":{"type":"long"},"name":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"projects":{"type":"nested","properties":{"address":{"type":"nested","properties":{"city":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"state":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}}}},"name":{"type":"text","fields":{"keyword":{"type":"keyword"}},"fielddata":true},"started_year":{"type":"long"}}},"title":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}}}}}

PUT /nested_employees/_doc/1
{"id":3,"name":"Bob Smith","title":null,"projects":[{"name":"AWS Redshift Spectrum querying","started_year":1990,"address":[{"city":"Seattle","state":"WA"},{"city":"Boston","state":"MA"}]},{"name":"AWS Redshift security","started_year":1999,"address":[{"city":"Chicago","state":"IL"}]},{"name":"AWS Aurora security","started_year":2015}],"comments":[{"date":"2018-06-23","message":"I love New york","likes":56},{"date":"2017-10-25","message":"Today is good weather","likes":22}]}

SELECT e.id, p.name FROM nested_employees e, e.projects as p WHERE p.started_year = 1990

Result
There are two id columns in the result set.

Fixed in https://github.com/opendistro-for-elasticsearch/sql/pull/890

Fixed in https://github.com/opendistro-for-elasticsearch/sql/pull/890


Implement CNI plugin

Fixes #1991 and #1992.
CNI expects to call an executable, which you name in your /etc/cni/net.d/somenetwork.conf file.  For the Weave plugin this executable is the same executable as the Weave Docker Network plugin, renamed.
If you name it weave it acts as a CNI network plugin.
If you name it weave-ipam it acts as a CNI IPAM plugin.
For the purposes of trying it out, you can install and launch Weave, and then do:
docker cp weaveplugin:/home/weave/plugin <cni bin directory>/weave

If you do not configure an IPAM "type", the Weave CNI network plugin will call Weave IPAM directly.

Note that 'gateway' and 'ipmasq' functionality are not yet implemented.

What's the plan for a) release artifacts, and b) docs? I am happy for these to be done in separate PRs, but we should at least have issues for them (plus anything else we can think of to consider this work reasonably complete).

Could we just have weave setup do the docker cp to /opt/cni/bin? No additional release artifacts are required then.

Alternatively, could we have specially named symlinks in /opt/cni/bin (again perhaps installed by weave setup or weave launch) that point to the weave script itself, which could detect how it has been invoked and docker run the CNI plugin executable from one of our containers?

@awh it's an interesting idea.  Requires write access to that directory.
Also we discussed having the 'plugin' (the entry in /opt/cni/bin) be a symlink to the weave script, which would docker run the plugin binary.  This has the advantage of restricting the number of separately-managed artefacts, also makes subsequent upgrades simpler.

When used with Kubernetes, the pod's ethernet device is named eth0, which defeats the logic of weave ps.  I.e. weave ps will not report the containers as attached to the weave network.

Looking good @bboreham

I've trying to do this for my kubelet container:
ADD https://storage.googleapis.com/kubernetes-release/network-plugins/cni-09214926.tar.gz /tmp/cni.tgz
ADD https://raw.githubusercontent.com/weaveworks/weave/issues/1992-cni-plugin/weave /usr/bin/weave
ADD https://get.docker.com/builds/Linux/x86_64/docker-1.10.3 /usr/bin/docker

RUN mkdir -p /opt/cni/bin && tar xzf /tmp/cni.tgz -C /opt/cni/ && rm -f /tmp/cni.tgz && chmod +x /usr/bin/weave && ln -s /usr/bin/weave /opt/cni/bin/weave-net && ln -s /usr/bin/weave /opt/cni/bin/weave-ipam && mkdir -p /etc/cni/net.d && echo '{ "name": "weave", "type": "weave-net" }' > /etc/cni/net.d/10-weave.conf && chmod +x /usr/bin/docker
ENV WEAVE_VERSION=git-f18f10bac090

Weave script symlinks seem to work, i.e. execing weave-ipam inside of this container returns an error about missing env vars... However, kubelet still spits out complains like this:
NetworkPlugin cni failed on the status hook for pod 'redis-master-clm1t' - invalid CIDR address: Device "eth0" does not exist.

Not sure what else I'm missing in the containerised situation, please let me know if you have any ideas.

@errordeveloper you need to set a bunch of env vars to run the ipam plugins manually. Here are some docs https://github.com/appc/cni/tree/master/plugins/ipam/host-local

@achanda thanks! I sort of figured that, and recall even reading the original spec... I was just testing that containerised plugin is executable and does something close to what's desired (i.e. makes calls to the weave router container etc).

Ah, I've had Weave proxy socket mounted into this, looks like all is working with proper docker socket now!

I believe I got the last thing to fix, which is due to kube-proxy defaulting to iptables mode, which I discovered doesn't work with Weave as is. Any thoughts on this part? @bboreham did you test end-to-end agains Kubernetes v1.2 or it was v1.1? (The proxy mode change in v1.2).

I think I paused my 1.2 testing to make sure it worked with the current release (1.1).
But I also thought I tested in iptables mode. What exactly is the symptom you had?
PS: I think my symlink setup needs fixing for the case where weave runs in a container (which is the default)

PS: I think my symlink setup needs fixing for the case where weave runs in a container (which is the default)

Yes, it symlinks to /home/weave/weave...

But I also thought I tested in iptables mode. What exactly is the symptom you had?

Services are unreachable on their service IPs.
Well, actually, looks like it doesn't work in the old mode either, while it did before I started testing the plugin.

You did weave expose ?
Check the pods are wired up with weave ps.
Basically, just trace through the route then through iptables. If the plugin ran, all the things that are likely to go wrong are on the outside.  I had endless trouble with VirtualBox disabling networks.

Ok, looks SkyDNS keeps dies and restarts. I ran kubectl get events --watch and spotted this:
2016-03-15 22:02:48 +0000 UTC   2016-03-15 22:03:15 +0000 UTC   4         kube-dns-v10-f1xju   Pod                 Normal    InfraChanged   {kubelet kubedev}   Pod infrastructure changed, it will be killed and re-created.

You did weave expose ?

Oh, actually I forgot this time, as I diverged from the usual startup sequence! But I did have it in my usual test, so I don't think that's that made it fail last time, will go and verify later, as I'd like the proxy to work in iptables mode (ideally). Now I'll go and see if weave expose somehow resolves the current problem...

Turns out all my pods are restarting with reason InfraChanged, sounds like fun...

OK, I've tried creating a single replication controller and it's still complaining about status hook, which causes InfraChanged event.
 NetworkPlugin cni failed on the status hook for pod 'redis-master-r2kkt' - invalid CIDR address: Device "eth0" does not exist.

This status call comes with an exciting TODO note, by the way.

I am completely puzzled where this error comes from, not able to find any combination of similar string anywhere, I mean the invalid CIDR address: Device "eth0" does not exist portion of the error message.

invalid CIDR address comes from golang's net.ParseCIDR.

Looks like https://github.com/kubernetes/kubernetes/issues/22932 is what my issue is.

Looking good!

I addressed all comments except the consecutive-link-number one.  Cherry-picked your ARP function and rebased.

except the consecutive-link-number one

Good news - link.Attrs().ParentIndex corresponds to the IFLA_LINK attribute which is the peer ifindex for veths!

$ cat pif.go
package main

import "fmt"
import "os"
import "github.com/vishvananda/netlink"

func main() {
	link, err := netlink.LinkByName(os.Args[1])
	if err == nil {
		fmt.Println("Index", link.Attrs().Index)
		fmt.Println("Master", link.Attrs().MasterIndex)
		fmt.Println("Peer Index", link.Attrs().ParentIndex)
	}
}

6: datapath: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc noqueue state UNKNOWN mode DEFAULT group default
    link/ether 82:6f:90:62:11:76 brd ff:ff:ff:ff:ff:ff
7: weave: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc noqueue state UP mode DEFAULT group default
    link/ether aa:e7:41:ba:ed:ca brd ff:ff:ff:ff:ff:ff
8: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default
    link/ether f2:42:3f:0a:ab:48 brd ff:ff:ff:ff:ff:ff
10: vethwe-datapath@vethwe-bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc pfifo_fast master datapath state UP mode DEFAULT group default qlen 1000
    link/ether f6:4a:eb:69:2e:53 brd ff:ff:ff:ff:ff:ff
11: vethwe-bridge@vethwe-datapath: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc pfifo_fast master weave state UP mode DEFAULT group default qlen 1000
    link/ether 0e:0a:2c:06:61:26 brd ff:ff:ff:ff:ff:ff
13: veth7a26e0e@if12: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master docker0 state UP mode DEFAULT group default
    link/ether 7e:3a:42:13:cb:7d brd ff:ff:ff:ff:ff:ff link-netnsid 0
15: vethwepl2468@if14: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc pfifo_fast master weave state UP mode DEFAULT group default qlen 1000
    link/ether ae:d5:a3:fd:c9:f8 brd ff:ff:ff:ff:ff:ff link-netnsid 0

$ ./pif vethwepl2468
Index 15
Master 7
Peer Index 14

$ sudo nsenter --target=2468 --net ip link show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
12: eth0@if13: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 02:42:ac:11:00:02 brd ff:ff:ff:ff:ff:ff link-netnsid 0
14: ethwe@if15: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 3a:71:8a:cd:2d:96 brd ff:ff:ff:ff:ff:ff link-netnsid 0

Can we smoke test this without installing kubernetes?

Also
$ sudo nsenter --target=2468 --net ./pif ethwe
Index 14
Master 0
Peer Index 15