Have you consider a yeoman based setup?

Hi!
When I started trying out octopod I was not sure about what it was and what it did.
Based on my experience so far I reached the understanding it does mainly two things for you:

Scafolding - octopod setup created a project for you to generate the website
jekyll plugin - handy Liquid Filters to support the project that was created in the first step

I was wondering if 1. could not be replaced by a yeoman generator, which would also provide some parametrization for the generated project.
I don't have a lot of experience with yeoman, aside from using it, but in the future I could try to implement this.

Fancy a bit of background story?
I found jekyll-octopod (named octopod in those days) when I was searching for a podcast hosting plugin for Jekyll. It was pretty much abandoned in those days, just a scaffold, not a gem. I spoke with the former developer, long story short, he handed the project over to me and I update dependencies, fixed bugs, made it a bit more modern looking till it fully served my needs and transformed it into a gem. That was appox. 4 years a ago. Using it for 5 or so podcasts myself up to now.
I neither liked the code style, nor the structure, but it was good enough and a lot less work than starting over from stretch. In those days I was pretty much migrated from Ruby to Elixir already, but I still liked Ruby (and still like it today).
In October '18 I did a bit of recap and wrote sg. down on the state of the project: https://github.com/jekyll-octopod/jekyll-octopod/blob/master/ROADMAP.md
ad 1) it is a bit of a zombie: the scaffolding (that I reduced as much as I could) vs. the gem aspect of it (and extracting of the theming).
ad 2) that was the main benefit, that is probably still 90% of the original developer's work.
Every now and then I'm thinking of doing something from scratch (maybe even a data base backed solution, as most of the potential users shied away because of the command line). E.g. we had commenting with Disqus (a privacy nightmare) and they are really missing. Self hosting comments with (an option) isn't an option for most of the potential user.
I would probably do it in Dart right now (that's my main language, currently) or in Elixir and Phoenix (the combo I am best in). Ruby would be only third choice, because of sentimental reasons.
But it I am several other interesting projects right and and jekyll-octopod still works well enough for me, creates the static site, that is responsive. The rss Feed works with iTunes and all Podcatchers. That's enough for now. Maybe, when I retire ;-)
I did never use yeoman, to be honest, so no strong feelings there.
So maybe - take a step back - think about the whole thing. Maybe you want to

take it over (the whole project)
fork it away
just pick up some ideas and do something completely different: You could have me as a friendly user, as soon, as your thingy does it as good as jekyll-octopod

What are your thoughts?

Fancy a bit of background story?
I love some background history 😍

Thanks a lot.
Some unorganized thoughts on my side, but I will come back when the hurricane is a little bit more under control.
I think I see a beautiful tech friendship being built here 😉
By the way, soon I will be able to show the results of my work using jekyll-octopod, I think you will gonna like it.

Interested in your thoughts, but let them ... what's the word .. mature, breed. Give them time.
Always happy in friendly conversations. Your issue report was definitely in the top ten percent of friendliness.
 Give them time.
Very wise words.

As promised, here is the result of my work based on jekyll-octopod: https://coronablogbr.org/
I teamed up with a public health researcher in the epidemic spread field to produce a podcast in portuguese (out native language), and  blog.
Our objective is to help bring non-alarmistic and curated information to the population.
I managed to put it up in through the weekend, also using your website as reference for some tips on how to customize it after generation.
Thanks! ❤

So, so awesome!
I am super happy to see, that you mitigated the issues yourself.
(Currently debugging and fixing and almost done, but now some issues compiling...)


fixing the loss syntax for l02c01

Replacing the magic string constant with the canonical class name.
The previous format would cause incorrect code to compile but fail at runtime. The updated version checks the syntax on the compilation phase.
The exact class string code is an implementation detail and may change in the future making the example invalid.

@googlebot I signed it!

@googlebot I fixed it.


That "Powered by Fue" part on screen is weird and unnecessary.

Describe the bug
-- That part is not good for user experience I never see this thing on the main game screen.
To Reproduce
I tried to remove it but the space between barriers is becoming wide.
-- Tested on Android 9 device.

Sure, any UI enhancement is always welcome. If you have more suggestions, I would be happy to hear them. I will edit it as soon as possible.

Sure, any UI enhancement is always welcome. If you have more suggestions, I would be happy to hear them. I will edit it as soon as possible.

Sure, I will let you know.

u can reopen it once you have a new design


longclick still triggering normal click

Hi,
Thanks for this plugin, its just what I am looking for but I noticed that when I run the example.html you've provided I still get the normal click event triggering after the long click. I'm trying on windows vista in firefox and chrome.
Thanks

is this fixed or what? I tried the plugin but doesn't work.


bump sparkle to 0.2.137

Description
Bump sparkle for https://github.com/dust-tt/dust/pull/4662
Risk
N/A
Deploy Plan

deploy front

PMRR


Dr2 1906 remove asset checks from workflow monitor

The README is accurate now I think. It was never updated to say that we were getting the assets from the messages.


Showing only for one time

Like i added slide up animation for deletion of cart product.. First time its showing the animation but on the deletion of second product its not sliding up.. Just hide the view as it is. Please help me how to do it.
PropertyAction green = PropertyAction.newPropertyAction(custom_items).
                            translationY(custom_items.getChildAt(Integer.parseInt(delete.getTag().toString())).getHeight()).
                            alpha(1f).
                            duration(500).
                            build();

                    Player.init()
                            .animate(green)
                            .play();

Your library is seriously amazing.. And yah one more question is that if i want to translate my view from current position 0 to 1000 view alpha 1.0f to 0.0f then how can i achieve with your library.
Thank You.

@babulpatel1309 You can do it simultaneously by calling multiple times animate(action) or one after the other by calling then().
For example
animate(action).
then().
animate(otherAction)
That way they will wait for each other.
It is possible to animate everything with Player but don't do it.
The library is intended for post entering activity/fragment animations.

I solved the issue by using Loop function... Thank You... :+1:  :) keep Smiling

:) Nice.


Deprecate physics component

Removes the by now deprecated physics component completely. Note that triggers as used from scripts have been replaced by rigid bodies, which is expected to be cleaned up when the trigger system that makes use of trigger volumes is built.
Resolves #384

SonarQube analysis reported 14 issues

 14 minor

Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 PhysicsManager.cpp#L271: The function 'GetPhysicsComponents' is never used.
 RenderManager.cpp#L366: Variable 'name' is assigned a value that is never used.
 RenderManager.cpp#L376: The function 'GetAnimations' is never used.
 RenderManager.cpp#L394: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L433: The function 'GetMaterials' is never used.
 RenderManager.cpp#L451: The function 'GetMeshes' is never used.
 RenderManager.cpp#L471: The function 'GetPointLights' is never used.
 RenderManager.cpp#L492: The function 'GetSpotLights' is never used.
 ScriptManager.cpp#L559: The function 'GetScripts' is never used.

SonarQube analysis reported 14 issues

 14 minor

Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 PhysicsManager.cpp#L271: The function 'GetPhysicsComponents' is never used.
 RenderManager.cpp#L366: Variable 'name' is assigned a value that is never used.
 RenderManager.cpp#L376: The function 'GetAnimations' is never used.
 RenderManager.cpp#L394: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L433: The function 'GetMaterials' is never used.
 RenderManager.cpp#L451: The function 'GetMeshes' is never used.
 RenderManager.cpp#L471: The function 'GetPointLights' is never used.
 RenderManager.cpp#L492: The function 'GetSpotLights' is never used.
 ScriptManager.cpp#L559: The function 'GetScripts' is never used.


Failed to connect to bus: No medium found

Hi
I use manjaro linux and install package via arch linux steps using pacaur. After installation i run systemctl and get this error message.
Failed to connect to bus: No medium found
What`s i should do?

and I tried paru result same

Do you use sudo to run that command? It should be run as a normal user. Please remove sudo and retry to see if it works. Thanks.

yeah its work
thanks
sorry)


Add test (and fix) to ensure idempotent response when confirm after tx

@oxade discovered an interesting issue in the distributed benchmarking where we are seeing lock errors when confirmation tx arrived out of order after the tx.
If an authority processes a certificate before seeing the transaction, it shouldn't error out but should be able to return the response that contains the known effect.
This PR adds a test to exercise it, and also a fix?

LGTM, I need to enlist all scenarios, but cannot think of any critical issue atm

Thanks for giving feedback @kchalkias

@gdanezis I am going to merge this, but would love to hear you thought when you see it.


Electron.NET serves webpages over network

From the console window that shows when you run electronize start:
Now listening on: http://<IP_ADDRESS>:8001
ASP.NET should be configured to listen on <IP_ADDRESS>, not <IP_ADDRESS>, as the latter allows for external computers to connect, which is not desired for Electron.

Correct, so don't expose all IPs like that in your dotnet code.
Just add .UseUrls() in program.cs, or add a JSON config to setup your kestrel or whatever other way you want to configure it.

I think I ended up with <IP_ADDRESS> just following the README quickstart so I assume that is the ASP.NET default? Perhaps .UseElectron should call .UseUrls for you? (Not like you need to know the url anyway, it's all internal.)

 I have to call it AFTER .UseElectron. I think .UseElectron is trying to force <IP_ADDRESS>. I think this should be considered a potential security vulnerability since even if the developer indicates <IP_ADDRESS> should not be used, it is still used.
Edit 2: I was correct, I went looking for the function in the code and found this:
2fb3062

Thank you @The-MAZZTer. This comment was a life saver! \o/


Python Ignores content-type Additions

Copied from https://stackoverflow.com/questions/66179134/content-type-not-being-set-properly
I am working on implementing the gRPC generated code for the flatbuffers library, and I've noticed that the python gRPC library doesn't use the user set content-type. According to the documentation the user can set whatever type they want in the Content-Type → "content-type" "application/grpc" [("+proto" / "+json" / {custom})] section. I've been trying to add simply send a +flatbuffers which breaks the go server and the python client (trying to make sure that all the languages can work well without any issues between them).
example:
Go lang to Go lang
:method POST
:scheme http
:path /models.Greeter/SayHello
:authority localhost:3000
content-type application/grpc+flatbuffers
user-agent grpc-go/1.35.0
te trailers
grpc-timeout 9997779u

As you can see if its being called from go lang it doesn't have issues however when I call the server from the python client it clearly doesn't append the +flatbuffers suffix
python to Go lang
:scheme http
:method POST
:authority localhost:3000
:path /models.Greeter/SayHello
te trailers
content-type application/grpc
user-agent grpc-python/1.35.0 grpc-c/14.0.0 (osx; chttp2)

steps taken:
1- I've tried adding options to the channel:
with grpc.insecure_channel('localhost:' + args.port, options=[('content-type', 'application/grpc+flatbuffers')]) as channel:

2- I've tried adding it on to the with_call according to https://github.com/grpc/grpc/blob/v1.35.0/examples/python/metadata/metadata_client.py
with_call(hello_request, metadata=[('content-type', 'application/grpc+flatbuffers')], compression=None)

however both options fail.
am I missing something here?

Thanks! well, after more research I found out that all the languages except (Go) ignores the suffix that should've been appended into the content-type header. So I would believe the issue is actually in the core lib, that actually removes custom types. Libs I tried, Python, JS, Swift. I mentioned this issue on the grpc group there was a response that the suffix is only appended on the go lang implementation, and another comment referred to the content-type not being set properly. I was wondering if this is a bug? Or is content-type is always supposed to be application/grpc? If its a bug, we can move forward with the PR in the grpc-swift library and have to close the issue open on the grpc-go.
go: https://github.com/grpc/grpc-go/issues/4213
swift: https://github.com/grpc/grpc-swift/pull/1141


Create Obs: new create location flow

The create obs form should now either

find an MO Location from a lat/lng (either manually entered, or from an image exif data), but if it does not find one that fits, it should
populate the autocompleter with options from Google's matching locations, in ascending area.
offer to "Create location" with the bounding box data autofilled in hidden fields, and an interactive box in the map that the user can alter, updating the hidden fields.

On save, the Location should be created before the Observation, and the Observation attached to the Location. Problems with the Location should throw flash errors in the Obs form and prevent validation.

[ ] To test: Trying to create a Location with the name of an existing MO Location should block form submission.

coverage: 94.438% (-0.02%) from 94.459%
when pulling bf19a9e49b49d36031aacd171cc2bdf10a5067b9 on create-location-modal
into 5145bf8ab4dc44e20ec04c39a414de57b6eee90a on main.

if this is possible *and easy modify new location names as follows.
(If not eay (but possible) do it in the future.)

With the above input, it correctly found the boundaries of Costilla County, Colorado. (The photo did not have location info.)
But it doesn't get the location name perfect.
Since it figured out the bounding box, it seems like there should be enough information to get the name MO style. (Costilla Co., Colorado, USA.)

I also don't understand why the CI tests aren't running.

Thanks @JoeCohen - i didn't even check that, since it's using the same foramatter as the lat/lng matcher, which does format locations correctly for MO.
It's very unexpected that the country component is missing - it's assembling the string from separate address components that are assumed to be in the object returned. Will check.

Another "nice to have if easy" and seeming bug.
Update the Locality window after this sequence: enter something in that window, Create Location, bounding box found.
Example:

Create Observation
Fill in Locality with "Harrietsburg, New York, USA"
Click Create Location
Result: It finds a box for the Harrietstown (there's no such place as Harrietsburg), but does not update the Locality window.

It would be nice to automatically update that window.

Click in the Locality window
Result: double municipality: "Harrietstown, Harrietstown, Franklin Co., New York, USA"
Maybe one is due to the township, the other to the cemetery?

Bug: The changes to Observation break the /location/new Find on Map button.
Ex:

On this branch

Click Create Location (or goto http://localhost:3000/locations/new)
Enter "Slater, Iowa, USA" in the Locality field
Click Find on Map
Result: Radio silence: No bounding box, default geolocation fields unchanged.

Same thing on the webserver.
Result: It finds and displays a bounding box, fills in geolocation.

@JoeCohen Thank you for all these! Very helpful. I'm checking what I think is fixed here, feel free to un-check and this will serve as the TODO list:

[x] Location form "Find on map" working
[x] Updates "Locality" name field on Google place match
[x] County abbreviated


Split up config of consensus's db and app's db

It is a step to Tendermint implementation.

Codecov Report

Merging #452 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #452      +/-   ##
===========================================
- Coverage    44.36%   44.35%   -0.02%
===========================================
  Files          168      168
  Lines        11637    11632       -5
===========================================
- Hits          5163     5159       -4
+ Misses        6063     6062       -1
  Partials       411      411

Impacted Files
Coverage Δ

gossip/config.go
100.00% <ø> (ø)

integration/assembly.go
59.52% <100.00%> (-4.31%)
:arrow_down:

evmcore/tx_pool.go
76.16% <0.00%> (-0.83%)
:arrow_down:

cmd/lachesis/config.go
17.07% <0.00%> (+4.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6145da3...1350a5b. Read the comment docs.


 Don't need PiHole just the monitoring.
Tried installing this on my Ubuntu NAS server following your instructions but could not get it to work. See below.
pip3 install ansible
Collecting ansible
  Using cached https://files.pythonhosted.org/packages/18/c0/b56fb443ce4261cf15927674d462a07090c63938e2e44e558847e18578a5/ansible-4.5.0.tar.gz
Collecting ansible-core<2.12,>=2.11.4 (from ansible)
  Using cached https://files.pythonhosted.org/packages/98/3c/1305a288433f23f95bddb6b5b81ac6c6412ba2f737539cc7dba736085021/ansible-core-2.11.4.tar.gz
Collecting PyYAML (from ansible-core<2.12,>=2.11.4->ansible)
  Using cached https://files.pythonhosted.org/packages/7a/5b/bc0b5ab38247bba158504a410112b6c03f153c652734ece1849749e5f518/PyYAML-5.4.1-cp36-cp36m-manylinux1_x86_64.whl
Collecting cryptography (from ansible-core<2.12,>=2.11.4->ansible)
  Using cached https://files.pythonhosted.org/packages/cc/98/8a258ab4787e6f835d350639792527d2eb7946ff9fc0caca9c3f4cf5dcfe/cryptography-3.4.8.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-5r5l158c/cryptography/setup.py", line 14, in <module>
        from setuptools_rust import RustExtension
    ModuleNotFoundError: No module named 'setuptools_rust'

            =============================DEBUG ASSISTANCE==========================
            If you are seeing an error here please try the following to
            successfully install cryptography:

            Upgrade to the latest pip and try again. This will fix errors for most
            users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
            =============================DEBUG ASSISTANCE==========================

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-5r5l158c/cryptography/

Tried installing the missing module:
sudo apt install python-setuptools_rust
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package python-setuptools_rust

Does this only work on ARM based machines. My NAS server is running Ubuntu 18.04.5 and is on 24x7 connected directly into the main switch.
Any help appreciated.
Cheers
Tony

You'll need to upgrade Pip—see the debug message in the error list: https://pip.pypa.io/en/stable/installing/#upgrading-pip

Thanks for the prompt reply.
Yes, I followed that link and upgraded pip to the latest I can see from Ubuntu 18.04 but the error persists.
I reverted to your older internet monitoring git page and that installed perfectly following the instructions.
As I only want to monitor the internet connection then this may work for me. I will have to wait for a bit of data to build up to have anything to look at it seems.
Is there any kind of uninstallation guide for all of the stuff docker-compose installs if I do want to build a pi to do this full time rather than use my NAS server? I could not see any uninstall info.
Cheers
Tony

Kinda;  #206 we have an initial draft for deprecating the containers:
cd ~/internet-monitoring
docker-compose down -v    #Shuts down internet-monitoring container(s)
cd ~/pi-hole
docker-compose down -v   #Shuts down pi-hole container(s)
docker system prune -f#Clean up docker
From there if you need to uninstall Docker itself, you'll need to follow the removal method for however you install Docker in the first place (e.g. apt, pip, etc)

Many thanks for this. That makes sense.
I have it running now and it is already proving useful.
I think I will build a pi and dedicate it to this task.
Cheers
Tony


fix: Added a close button to the tooltip in Onboarding

What

A close button is added to the tooltip top-right corner in the onboarding flow.
Now the user can tap on the close icon to close the tooltip instead of tapping on all of the tooltip.

Screenshots

Before
After

Fixes bug(s)

Fixes: #4235

Part of

#4230

Codecov Report

Merging #4619 (ca1494f) into develop (0a64d60) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4619      +/-   ##
===========================================
- Coverage    10.13%   10.13%   -0.01%
===========================================
  Files          299      299
  Lines        15692    15696       +4
===========================================
  Hits          1591     1591
- Misses       14101    14105       +4

Files Changed
Coverage Δ

...ages/onboarding/knowledge_panel_page_template.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @monsieurtanuki,

We still need the whole tooltip to be closable by click. The cross icon is just to tell the user "btw you can close this tooltip" (but you can click anywhere). Besides if you want an icon to be clickable, you're supposed to make it "big enough" (something like 48) and it would be too big for the tooltip.

I have updated my code according to your comment.

@monsieurtanuki Thank you! I think it looks the same in the dark mode too.


[Connectivity] wifi removal

Description
This PR removes all the wifi related APIs in the connectivity plugin. It is a breaking change. Since 0.4.y is compatible with 1.0.0 we're bumping the version straight to 2.0.0
We introduced wifi_info_flutter and all the wifi related APIs are moved to wifi_info_flutter.
We will keep the connectivity_platform_interface as is until the desktop plugin and web plugin are migrated to wifi_info_flutter as well.
We should land this after wifi_info_flutter has published
Related Issues
Fixes https://github.com/flutter/flutter/issues/40418
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

Offline discussion: This change will be merged to the nnbd branch, so there's no need for 2.0.0, then 3.0.0-nullsafety.
@cyanglaz what about closing this PR, and reopening one for the nnbd branch?

@cyanglaz - thanks for landing this. I think going to v2.0.0 makes sense. I'll start making use of it.


Add telemetry for package deprecation

I have discovered that we need to add a new event to the ITelemetryService for deprecation to appear on the PackageEvents dashboard.

Can't verify on PROD due to feature flag.


[pylint E1101] [E] Module 'falcon' has no 'HTTP_200' member (no-member)

pylint is not recognizing falcon status codes. e.g HTTP_201
import falcon

class ObjectRequestClass:
    def on_get(self, req, resp):
        resp.status = falcon.HTTP_201

Hi @zubairakram !
And thanks for reporting this issue!
However, I do believe it is already tracked in our system: https://github.com/falconry/falcon/issues/1553
Closing this one as duplicate, but don't hesitate to provide more information if you believe this is a separate problem!


DAV report search finds users personal space

The report search endpoint returns the users own personal space eg “admin” if the search term contains for example "admin" and the username is "admin".
This might be implemented as designed but showing this result in the Web search confuses the user and has no use case.
Unfortunately filter this from the search result in Web is not enough as we still get the number of the found results in the response headers.
I appreciate if we can omit this from the search report

I agree - for me it's confusing to have the personal space root itself among the search results.

@micbar and @tbsbdr what's you take on this? If you agree with the expected behaviour, what's the prio? I think it's a prio 3 bug...

I'd say it depends on the effort. If <= 1h i'd fix it soonish. If more i'd track it as known issue, p4

@kulmann after talking to @ScharfViktor and @kobergj the best approach would be to filter that out in web, since you have to iterate over that in web anyway to display it. Filtering that in the backend would be a waste of resources since we have to iterate over the whole resultset, which in 99% of all cases does not contain a personal space.

Understood, transferring to web and sort that out by myself


improve calendar

[ ] support multiple calendars in one widget
[ ] support multiday events
[ ] support events without times

closed in e7a5c39


[MXNET-347] Logical Operators AND, XOR, OR

Description
Adds Logical AND, XOR, OR operator.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] AND, OR, XOR operator.

Comments

@haojin2 @eric-haibin-lin @cjolivier01

@piiswrong @cjolivier01 could please take a look. I have addressed your comments.

@eric-haibin-lin should I update these under Comparison or should I create a new Logical category? I think even this - https://github.com/apache/incubator-mxnet/pull/10639 needs to be updated in the doc API.


VS Code AutoComplete does not include some functions of 3rd Party Modules like (NumPy, Pandas, Matplotlib,...)

Issue Type: Bug

Behaviour
Expected vs. Actual
Functions like df.plot.area() (The area part of it)
Or like df.plot.bar() (The bar part of it)
Or attributes like plt.fill_between(x, y, color="skyblue") (The color part of it)
are not recognized as valid so not AutoCompleted
Steps to reproduce:

make an IPython .ipynb (or even a Python .py) file
import pandas as pd
import matplotlib.pyplot as plt
make a df (E.G. df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6], "C": [7, 8, 9]}))
Write the pieces of code I wrote before

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.2
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

insidersChannel: "off"

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.2.1924087327
VS Code version: Code 1.65.2 (c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1, 2022-03-10T14:33:55.248Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

Same issue in python -m venv:
{   "python.languageServer": "Pylance",   "python.analysis.indexing": true,   "python.analysis.autoImportCompletions": true, }
Doesn't autoimport any 3rd party modules.
Version: 1.65.2 (user setup) - Windows x64 10.0.19044.1586
WSL: Yes

@galmirpr your issue seems to be a different issue. please open new issue with repro steps.

2 different issues.

Functions like df.plot.area() (The area part of it) Or like df.plot.bar() (The bar part of it)

the issue is plot is defined in frame.py but not defined in frame.pyi. frame.pyi only have plot() defined. in frame.py, plot point to cached data. pandas stub needs to be updated with plot.

Or attributes like plt.fill_between(x, y, color="skyblue") (The color part of it)
fill_between is defined as

def fill_between(
        x, y1, y2=0, where=None, interpolate=False, step=None, *,
        data=None, **kwargs): ...

we won't know what key is available to kwargs statically.


Revert "[interop] Configure libstdc++ module map at runtime"

Reverts apple/swift#64177

@swift-ci please smoke test

CC: @meg-gupta

Trying a speculative fix at https://github.com/apple/swift/pull/64241

Seems that https://github.com/apple/swift/pull/64241 should repair the issue.


Adds a Chart for Selenium.

Adapting the Kubernetes Selenium example to a Chart.

This looks great!
We're trying to add the label heritage: helm to all of the Kubernetes manifests so that it's easy to query all of the helm-installed things. Would you mind adding those to your YAML files?

Labels/selectors updated, good call.

@elsonrodriguez Thanks for making those changes so quickly! We've finished reviewing and I'll merge shortly. Really appreciate the time you spent on the README. Internally we're using it as a guide for how these things ought to be done.
If you have a chance, I'd really like your feedback on this new chart developer's guide we're working on: https://github.com/deis/helm/pull/208


how can i get live duration of song

Normally to get the duration of song is
const player = client.music.players.get(message.guild.id);
const { title, author, duration, thumbnail } = player.queue[0];

this line will simply give me total  duration of current song but how can i get current duration of the song
example 1:12/4:24 here what i want to get is 1:12 which i will edit the last massage and edit the massage every 5 sec

You simply can't get the duration of live song getting played, you might never know when the stream is gonna end , all you can do is (if possible), get the time escaped in that stream and convert it into total time. but i am not sure if that information is given.

then i have a bot called Jmusic bot they made it possible
here is their source code
https://github.com/jagrosh/MusicBot

You simply can't get the duration of live song getting played, you might never know when the stream is gonna end , all you can do is (if possible), get the time escaped in that stream and convert it into total time. but i am not sure if that information is given.

also as far as live stream goes no one asked for end duration just the time the bot started playing

i got it


refactor(backend): optimize txn log

Change-Id: I50051e02eac47fc8ba6ed907d45829e5798750c6
What type of PR is this?

enhancements
What this PR does / why we need it:
optimize format and output condition of txn log
Which issue(s) this PR fixes:
None
Special notes for your reviewer:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e763695). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   56.93%
=======================================
  Files           ?       58
  Lines           ?     4716
  Branches        ?        0
=======================================
  Hits            ?     2685
  Misses          ?     1888
  Partials        ?      143

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Poor performance with large amounts of text

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
<EMAIL_ADDRESS>Link to runnable example
https://github.com/charliematters/gfm-speed-bug
Steps to reproduce
We noticed a slow-down when trying to render large amounts of plain text as Markdown when using the GFM tables plugin. I've written a simple reproduction which should show the differences between performance with the plugin both enabled and disabled. I ran it using node 18 and npm 8.
The input text is the bee movie script (as it's large and contains no complicated syntax), and on my M1 MacBook Pro, adding the plugin takes the time from 30ms to 10,000ms.
This is obviously more noticeable on the end-users computers where we're seeing times in excess of 90s to render mostly plain-text markdown content.
I don't want to disable the plugin, but if there is an obvious fix for this then that would be great!
Expected behavior
Rendering (parsing?) tables shouldn't add a noticeable overhead to execution time
Actual behavior
Rendering time increases greatly when using the micromark-extension-gfm-table plugin
Runtime
Other (please specify in steps to reproduce)
Package manager
Other (please specify in steps to reproduce)
OS
macOS
Build and bundle tools
Other (please specify in steps to reproduce)

Duplicate of https://github.com/remarkjs/remark/discussions/978
To quote that discussion:

Hey! GFM tables are tough to parse, they are different than other markdown constructs and require looking ahead further.
That being said, there are likely things to improve where they are parsed: https://github.com/micromark/micromark-extension-gfm-table. Perhaps you can profile and help there?

You can for example try different versions of micromark-extension-gfm-table and micromark to understand if this is something that was introduced at some point or if it was already present from the start.
You can also try different markdown input, to see if the problem might be lines or columns or long cells or what.
You can change states to switch to the nok state, to see if that magically solves everything (of course, nok stops parsing, so it also breaks everything).

You can read in particular the Architecture section in the micromark readme for more on how the project works.

source: https://github.com/remarkjs/remark/discussions/978#discussioncomment-2467934


Improved isolation of GPU and non-GPU functionality in utils and headers

I have been working on some more unit tests for DSSTNE. One of the issues that I have run into is how to structure the test suite so that parts of the code that do not depend on CUDA could be executed in a CI environment such as Travis CI.
The approach I'm exploring at the moment is to make more aggressive use of forward declarations in the header files, such that the test suite could be built without a full CUDA installation. I wanted to raise an issue to get the DSSTNE team's thoughts before diving too deep, or submitting a PR.
I've also noticed a few other things that could be improved, such as moving 'using namespace x' declarations from header files to source files. These are all minor changes, but will help with isolation between 'utils' and 'engine'.

For what it's worth, I have successfully built and run the current 'unittest' test suite on Travis CI. So that could definitely provide a good foundation for expanding the unit tests to cover a larger portion of DSSTNE's non-GPU functionality.

Keeping the build of DSSTNE simple is a key goal.  I'd need more detail
describing the changes you propose before deciding on it.  If it's
non-invasive to building DSSTNE for training/inference, I'm probably all
for it.
On Tue, Aug 9, 2016 at 12:19 AM, Tristan Penman<EMAIL_ADDRESS>wrote:

For what it's worth, I have successfully built and run the current
'unittest' test suite on Travis CI. So that could definitely provide a good
foundation for expanding the unit tests to cover a larger portion of
DSSTNE's non-GPU functionality.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amznlabs/amazon-dsstne/issues/54#issuecomment-238456149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARNK9rSIY6ZfpwjzvzkOgdyp91nk8qGjks5qeA3SgaJpZM4JelRZ
.

The changes to support Travis CI are pretty non-invasive. I haven't opened a PR for that yet, but you can see the progress here:
https://github.com/amznlabs/amazon-dsstne/compare/master...tristanpenman:travis-ci
This branch adds a .travis.yml file for Travis CI, and includes the changes necessary to build the unit tests using CMake.
The CMakeLists file currently lives in the tst/unittests directory, since that is the only place where it currently provides value. And given that CMake builds can be hierarchical, it will be relatively easy to work back towards the root as the build is more complete.

As for the header files, I'm still experimenting with some different approaches on a local branch, but two initial changes that seem appropriate to me are:

in any headers that are shared between builds/binaries, use the std:: prefix instead of using namespace std
and add using namespace std to source files, where necessary

Then it would be a matter of identifying any classes/typedefs that need to be shared between tests and engine code and deciding how to split those up while keeping everything nice and lean.

Closing this issue for now as the initial Travis CI changes have been merged as part of PR https://github.com/amznlabs/amazon-dsstne/pull/57 with additional changes in later PRs.
As for refactoring header files, this was discussed offline and it is clear that this can be tackled as a continuous improvement effort. The changes made as part of PR https://github.com/amznlabs/amazon-dsstne/pull/60 serve as a good example for how we can approach these improvements going forward.


Images flickering on resize

Some images flicker and shift rapidly between full size and thumbnail if they are at the top or bottom of the page when they are resized. The current hover feature should probably be replaced by click to open full size in a lightbox.

Fixed in latest commit


NotRenderableError when passing non-string values

I've noticed that if I attempt to pass non-strings to an add_row() Table call (int, float, etc) it throws an exception:
rich.errors.NotRenderableError: unable to render 187; str or object with a console method is required
Is there a reason for this requirement?  Can it implicitly cast everything to string?
Also, unable to render 187 is cryptic.  I have no clue what 187 refers to.  Can this error be improved?

In my experience APIs that try to be helpful like this can hide errors. It's rare to need to pass a value in without processing it somehow. Floats would likely need to be formatted to a given number of decimal places, and you would rarely want the text 'None', 'True', and 'False'. Ints may be an exception, but even then you might want comma separators for thousands.
Rich uses type annotations, so you can catch this error before you run the code if you have Mypy set up.
I would like to make error messages as clear as possible. How would you improve it?

I don't know what 187 refers to or means.  The error should refer to the actual value that cannot be rendered, instead of an internal identifier.

187 is the value that can not be rendered. You must have called add_row
with the integer 187.
On Tue, 19 May 2020 at 14:43, Lonni J Friedman<EMAIL_ADDRESS>wrote:

I don't know what 187 refers to or means. The error should refer to the
actual value that cannot be rendered, instead of an internal identifier.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/willmcgugan/rich/issues/83#issuecomment-630827351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEHLALWOJOGKEGKC2DST2TRSKEGJANCNFSM4NELHSGA
.

--
Will McGugan
https://www.willmcgugan.com http://www.willmcgugan.com

ok, thanks


[Feature Request] Let's turn on dependabot and stay up to date

🚀 Feature Request
Turn on dependabot to open prs to attempt to keep us up to date:
https://app.dependabot.com/
Motivation
Now that we've done some automated/manual dependency updating it's the perfect time to turn on dependabot.   I expect us to only see 5 prs openned.
https://github.com/rexhoffman/libra/pulls
Pitch
Prs to keep libra up to date and exercise our ci/audit capability.    Plus ability to navigate prs that break to owning teams.
The alternative is that we let our deps slowly rot until someone decides to update them.
This must be done via a team member in the dependabot ui.
Additional context

I've added libra/libra.

We also need to whitelist the bot in the CLA checking tool.

This is all done (including whitelisting) except for posting out the update to internal/external groups.  Closing the feature request.   Waiting on feedback from @ericnakagawa and @davidiw before posting - and seeing if Eric has a good public place to post the update.


flow control should be message based instead of transfer frame based

Problem: The service bus service would keep sending messages of large size while the client side there's no credit on the link.

issue: https://github.com/Azure/azure-sdk-for-python/issues/16703, https://github.com/Azure/azure-sdk-for-python/issues/16934

Root cause:

the current_link_credit and delivery_count on a c link instance are not calculated correctly when messages of large size are received which leads to an inconsistent state between the client and the service.
currently current_link_credit decreases and delivery_count increases on each transfer received, this is wrong, according to the AMQP spec, those two variables should be updated when a message is received instead of a single frame

How to fix:
current_link_credit decreasing and delivery_count increasing should be updated after the whole message is received instead of immediately after a transfer frame is received, see code.

I have no opinions, trust you :p


update irmaq_magic to use MagIC 3

also make sure you update the irmaq_magic example in the cookbook and _PmagPy.ipynb

Done -- but this program is now a little more awkward because sample/site/location information is no longer present in a measurements file.  I've updated irmaq_magic so that it tries to grab that data from the working directory if possible and propagate it down.  I've updated the cookbook and _PmagPy.ipynb as well.


Standardize thumbnails for items

Standardize the look of thumbnails for items. Supporting items could have text overlaid on the same thumbnail to indicate it is a csv file, service definition file, etc.

@lfunkhouser the Utilities team has a script to do this. We might want to look into this for the next release. The thumbnails look really nice.


Fix indentation of list and code snippet for kms-provider

closes: #19337

/lgtm

Page preview:
https://deploy-preview-22316--kubernetes-io-master-staging.netlify.app/docs/tasks/administer-cluster/kms-provider/

I think the formatting is improved.
Thanks @tengqm .
/approve


FR: Toggle and/or frontmatter key for permanent highlights

Like, my use case for permanent highlights would be support for writing. However, when I am not writing, but just doing "normal" note-taking, I prefer to turn the writing-related permanent highlights off again.

One solution would be a command to toggle permanent highlights on/off.
a more fine-grained solution could be to have toggles for specific rules
a different approach could be to have a yaml-key to turn off/on permanent highlights. That way, you could simply add "permanent-highlight: true" to your writing notes.

Dupe of #14 but we'll leave this one up and close the other


How to train on the NeRF synthetic dataset

Thanks for your great work! I want to train your work using  the NeRF synthetic dataset, but I don't know how to convert the NeRF synthetic dataset to the form like the thin_cube, could you tell me how to do it, thanks!

Hi! Thanks for your kind words. Regarding your query, I'm not familiar with the term "thin_cube." Could you provide more details or clarify what you mean by "thin_cube"? This will help me understand your needs better and assist you more effectively. Thanks!

Thanks for your reply. I have found the code to convert the dataset successfully.


switch from port 3000 to 9926

This isn't working yet; something is causing it to still run on 3000.


Forwarded ports still available after disconnecting from codespaces (web)

Testing #133889
Steps to repro

Open github codespaces & open a repo
Start a server
Open browser and confirm it works
Close github codespaces browser, the port is still open

Based on the test plan item https://github.com/microsoft/vscode/issues/133889, when we close the window the port should no longer be exposed.
Not sure whether we're supposed to stop exposing ports in this scneario or not, but thats the scenario we're attempting to resolve in the test plan item.
Note: In the above scenario, I'm not using VS Code insiders desktop (everything is in the browser).
Also note, I've test the same scenario with desktop vscode insiders & it works as expected.

Codespaces doesn't use the port forwarding mechanism from https://github.com/microsoft/vscode/issues/133889. I will forward this to the Codespaces folks.


Update bindgen to 0.37

Fixes #191

Thanks for bumping this up! I'll cut a new version of the crate today that includes this change, as well as some of your other PR's that I'm about to check out :)


Option to retry after hsi get failure

Retrieval of tar files from HPSS on NERSC has been less reliable lately. hsi get occasionally fails for unknown reasons, but retrying works. We should consider adding an option to retry after a failed hsi operation.

@forsyth2 The issue described in #217 seems crippled a few users..I think we may need to prioritize this feature...

@chengzhuzhang Thanks for looking into #217. I've marked this issue as high priority (for the December 2022) release -- or do you mean such high priority we should have an emergency release?

Hi @forsyth2 Thank you for labeling this as high priority. I think it would be nice to have the new feature implemented and have a new release. If there will be an emergency release of e3sm-unified, we can add the new version of zstash.


ensure required arrays always exists

Small cleanup: This data is always sent from the service and set by the CLI so we can remove some TODOs.

D'oh looks like the integration tests don't have the key. I'll have to add them.

I'll do this some other time. It's currently working, why mess with it?


Exception: get_class() expects parameter 1 to be object, null given

I'm using the Laravel IDE Helper package.
I get the exception in the issue title when I run artisan ide-helper:generate
It can be fixed in Stancl\Tenancy\Facades\TenantFacade doing this:
class TenantFacade extends Facade
{
    protected static function getFacadeAccessor()
    {
        // return Tenant::class;

        // return hardcoded string instead of getting the name from the class
        return '\Stancl\Tenancy\Tenant';
    }
    // ...
}

But I'm not sure whats going on...
Setup

Laravel version: 7.5.2
stancl/tenancy version: 2.3.4
Storage driver: MySQL

Can I see the exception?

The exception is thrown by Barryvdh\LaravelIdeHelper\Alias and the stacktrace doesn't contain any reference to the Tenancy package, but while debugging I see that it occurs when get_class() is called in Stancl\Tenancy\Facades\TenantFacade.
ErrorException(code: 0): get_class() expects parameter 1 to be object, null given at /xxx/vendor/barryvdh/laravel-ide-helper/src/Alias.php:274
# 0 [internal function]: Illuminate\\Foundation\\Bootstrap\\HandleExceptions->handleError()
# 1 /xxx/vendor/barryvdh/laravel-ide-helper/src/Alias.php(274): get_class()
# 2 /xxx/vendor/barryvdh/laravel-ide-helper/src/Alias.php(61): Barryvdh\\LaravelIdeHelper\\Alias->detectRoot()
# 3 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(207): Barryvdh\\LaravelIdeHelper\\Alias->__construct()
# 4 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(228): Barryvdh\\LaravelIdeHelper\\Generator->getValidAliases()
# 5 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(84): Barryvdh\\LaravelIdeHelper\\Generator->getAliasesByExtendsNamespace()
# 6 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(74): Barryvdh\\LaravelIdeHelper\\Generator->generatePhpHelper()
# 7 /xxx/vendor/barryvdh/laravel-ide-helper/src/Console/GeneratorCommand.php(113): Barryvdh\\LaravelIdeHelper\\Generator->generate()
# 8 [internal function]: Barryvdh\\LaravelIdeHelper\\Console\\GeneratorCommand->handle()
# 9 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(32): call_user_func_array()
# 10 /xxx/vendor/laravel/framework/src/Illuminate/Container/Util.php(36): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
# 11 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(90): Illuminate\\Container\\Util::unwrapIfClosure()
# 12 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(34): Illuminate\\Container\\BoundMethod::callBoundMethod()
# 13 /xxx/vendor/laravel/framework/src/Illuminate/Container/Container.php(592): Illuminate\\Container\\BoundMethod::call()
# 14 /xxx/vendor/laravel/framework/src/Illuminate/Console/Command.php(134): Illuminate\\Container\\Container->call()
# 15 /xxx/vendor/symfony/console/Command/Command.php(255): Illuminate\\Console\\Command->execute()
# 16 /xxx/vendor/laravel/framework/src/Illuminate/Console/Command.php(121): Symfony\\Component\\Console\\Command\\Command->run()
# 17 /xxx/vendor/symfony/console/Application.php(912): Illuminate\\Console\\Command->run()
# 18 /xxx/vendor/symfony/console/Application.php(264): Symfony\\Component\\Console\\Application->doRunCommand()
# 19 /xxx/vendor/symfony/console/Application.php(140): Symfony\\Component\\Console\\Application->doRun()
# 20 /xxx/vendor/laravel/framework/src/Illuminate/Console/Application.php(93): Symfony\\Component\\Console\\Application->run()
# 21 /xxx/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(129): Illuminate\\Console\\Application->run()
# 22 /xxx/artisan(37): Illuminate\\Foundation\\Console\\Kernel->handle()
# 23 {main}

@jonagoldman I think the cause of that is that Tenant sometimes resolves to null. You can inject it as a dependency to get the current tenant, but when tenancy is not initialized, it's null. But I wonder why changing it to string helps, it should be literally the same. PHP should change Tenant::class to 'Stancl\Tenancy\Tenant'.

Yes, the difference is in the \ global namespace.
Tenant::class resolves to 'Stancl\Tenancy\Tenant' but I changed to '\Stancl\Tenancy\Tenant'.

That shouldn't matter though. \ is only necessary with the ::class syntax. Strings are automatically considered to be in the global namespace.

Yes, I find that strange, but lots of different  packages use facades so I'm trying to find out why it fails here but not in others.
In general I found that most facades just return simple strings like 'sentry' or 'event-sourcing' or 'cache'. And also don't add additional functionality like the create() method I see.
I guess I'm just asking myself if there is something I'm not understanding or if the facade implementation should be different.

A string is a string, it shouldn't make a difference. The reason I go with the fully namespaced Tenant class is that I don't want to bind it twice into the container, and when we use a class name, we can inject it.
Would you be so kind to test this in a fresh Laravel app? I don't use ide-helper. If not, I can just install it myself I guess.
Should be quick:
laravel new test
cd test
nano .env # comment DB_CONNECTION
touch database/database.sqlite
composer require stancl/tenancy
php artisan tenancy:install
# ... whatever are the installation steps for installing ide-helper
php artisan ide-helper:generate

Sure I will do it. Im not giving it too much importance is just to generate an ide helper file at the end of the day. I will give it a try.

Right. It's a weird bug though. And if the package improves the experience of developers using this package, I'll do my best to fix it.

Ok, so I can confirm this issue is happening on a clean Laravel installation:

Exception and stacktrace are the same.
By the way, I was also going report the bug in the IDE Helper repo, but they have more than 300 open issues so I will post it there only if we find that the problem is related to that package.

I'd like to resolve this so I'll leave this open, but I'm removing the bug label as it doesn't break anything and isn't really that high priority.

Sure, I'll try to dig deeper if I can. I just don't have enough knowledge of how both packages work.

If you want to do that, sure would be helpful.
Some suggestions from my side would be trying some verbose mode for the ide helper command, then doing some dd()ing in the place of the exception.
With regards to my package, the only "weird" thing is that the Tenant object sometimes resolves to null and not an object, and it seems like the ide helper is executing the facade for some reason. Might be because it tries to generate @method annotations based on what's available on the object, except there's no Tenant object available?
You could try creating a tenant and doing php artisan tenants:run ide-helper:generate, to see if running the command with initialized tenancy would help.

So the problem is that TenantFacade::getFacadeRoot() returns null so get_class(null) throws the exception.
From what I see, this is because the root instance name is "Stancl\Tenancy\TenantManager" but TenantFacade::getFacadeAccessor() returns "Stancl\Tenancy\Tenant" instead,  so the instance can't be found.
I think the issue comes from the binding in Stancl\Tenancy\TenancyServiceProvider
$this->app->bind(Tenant::class, function ($app) {
   return $app[TenantManager::class]->getTenant();
});

This is the flow when IDE Helper tries to get the facade root:

In Barryvdh\LaravelIdeHelper\Alias

protected function detectRoot()
{
    // "\Stancl\Tenancy\Facades\TenantFacade"
    $facade = $this->facade;

    try {
        if (method_exists($facade, 'getFacadeRoot')) {
            $root = get_class($facade::getFacadeRoot());
        }
        // ....
    }
    // ....
}

In Illuminate\Support\Facades\Facade:

public static function getFacadeRoot()
{
    return static::resolveFacadeInstance(static::getFacadeAccessor());
}

public static function getFacadeAccessor()
{
    return "Stancl\Tenancy\Tenant";
}

protected static function resolveFacadeInstance($name)
{
    // false
    if (is_object($name)) {
        return $name;
    }
    // false
    if (isset(static::$resolvedInstance[$name])) {
        return static::$resolvedInstance[$name];
    }
    // true
    if (static::$app) {
        // static::$app["Stancl\Tenancy\Tenant"] doesn't exist
        return static::$resolvedInstance[$name] = static::$app[$name];
    }
}

Thanks for the detailed write-up, appreciate it!
Seems like it's not really a bug with either package.
IDE helpers should take the class name from getFacadeAccessor() in my case, but it uses get_class() on the resolved object because facades can use non-class strings as keys for the underlying objects.
And the way I use the facade is probably not fully "correct", since there are cases when the facade root resolves to null.
The only solution I see would be ide-helper skipping the instance resolution & get_class() if getFacadeAccessor() returns a class string. I think is_class($facade::getFacadeAccessor()) would work.

They have a ton of open PRs, but I submitted the fix anyway: https://github.com/barryvdh/laravel-ide-helper/pull/916

Just tried https://github.com/barryvdh/laravel-ide-helper/pull/916/commits/9817b95511190b7f34b35195e6ecb288e31ade8d and I'm getting a different exception now:
RuntimeException(code: 0):
A facade root has not been set. at /xxx/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:258)
# 0 /xxx/vendor/barryvdh/laravel-ide-helper/src/Alias.php(276): Illuminate\\Support\\Facades\\Facade::__callStatic()
# 1 /xxx/vendor/barryvdh/laravel-ide-helper/src/Alias.php(61): Barryvdh\\LaravelIdeHelper\\Alias->detectRoot()
# 2 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(207): Barryvdh\\LaravelIdeHelper\\Alias->__construct()
# 3 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(228): Barryvdh\\LaravelIdeHelper\\Generator->getValidAliases()
# 4 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(84): Barryvdh\\LaravelIdeHelper\\Generator->getAliasesByExtendsNamespace()
# 5 /xxx/vendor/barryvdh/laravel-ide-helper/src/Generator.php(74): Barryvdh\\LaravelIdeHelper\\Generator->generatePhpHelper()
# 6 /xxx/vendor/barryvdh/laravel-ide-helper/src/Console/GeneratorCommand.php(113): Barryvdh\\LaravelIdeHelper\\Generator->generate()
# 7 [internal function]: Barryvdh\\LaravelIdeHelper\\Console\\GeneratorCommand->handle()
# 8 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(32): call_user_func_array()
# 9 /xxx/vendor/laravel/framework/src/Illuminate/Container/Util.php(36): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
# 10 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(90): Illuminate\\Container\\Util::unwrapIfClosure()
# 11 /xxx/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(34): Illuminate\\Container\\BoundMethod::callBoundMethod()
# 12 /xxx/vendor/laravel/framework/src/Illuminate/Container/Container.php(592): Illuminate\\Container\\BoundMethod::call()
# 13 /xxx/vendor/laravel/framework/src/Illuminate/Console/Command.php(134): Illuminate\\Container\\Container->call()
# 14 /xxx/vendor/symfony/console/Command/Command.php(255): Illuminate\\Console\\Command->execute()
# 15 /xxx/vendor/laravel/framework/src/Illuminate/Console/Command.php(121): Symfony\\Component\\Console\\Command\\Command->run()
# 16 /xxx/vendor/symfony/console/Application.php(912): Illuminate\\Console\\Command->run()
# 17 /xxx/vendor/symfony/console/Application.php(264): Symfony\\Component\\Console\\Application->doRunCommand()
# 18 /xxx/vendor/symfony/console/Application.php(140): Symfony\\Component\\Console\\Application->doRun()
# 19 /xxx/vendor/laravel/framework/src/Illuminate/Console/Application.php(93): Symfony\\Component\\Console\\Application->run()
# 20 /xxx/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(129): Illuminate\\Console\\Application->run()
# 21 /xxx/artisan(37): Illuminate\\Foundation\\Console\\Kernel->handle()
# 22 {main}

The tenant facade is removed in v3. Little use case for it anyway.


Openssl mingw fix

Motivation for this change
Corrected cross-compilation to Windows for OpenSSL 1.1.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

You removed openssl from inputs and the function there still calls it with openssl. I think you need to remove openssl there but I am not sure if your PR is correct otherwise.

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

You removed openssl from inputs and the function there still calls it with openssl. I think you need to remove openssl there but I am not sure if your PR is correct otherwise.

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

You removed openssl from inputs and the function there still calls it with openssl. I think you need to remove openssl there but I am not sure if your PR is correct otherwise.

Thank you for the explanation. I will need to correct the commit so that it can take both coreutils and perl as input parameters while still using buildPackages for mingw build.

Hello community,
I see that my fix is breaking this line https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L395. I am not that advanced in Nix. Could you please help on correcting that part?

You removed openssl from inputs and the function there still calls it with openssl. I think you need to remove openssl there but I am not sure if your PR is correct otherwise.

Thank you for the explanation. I will need to correct the commit so that it can take both coreutils and perl as input parameters while still using buildPackages for mingw build.

Succcessfuly tested builds:

native
lib.systems.examples.mingwW64
lib.systems.examples.armv7a-android-prebuilt
aarch64-android-prebuilt

Succcessfuly tested builds:

native
lib.systems.examples.mingwW64
lib.systems.examples.armv7a-android-prebuilt
aarch64-android-prebuilt

Result of nixpkgs-review pr 108170 1

Result of nixpkgs-review pr 108170 1

@SuperSandro2000: I am having trouble to add @peti as reviewer. There is no option for me to add any user as reviewer. Could you please help me?

@SuperSandro2000: I am having trouble to add @peti as reviewer. There is no option for me to add any user as reviewer. Could you please help me?

I tried building this locally, but there seems to be a patch gone missing:
❯ nix-build -A pkgs.pkgsCross.mingwW64.openssl_1_1
these derivations will be built:
  /nix/store/a12yra4nkkgcmigsq9h6qnx8ydi74ad9-stdenv-linux.drv
  /nix/store/3iw31akfh9h4455dhs6snmdz2k2l827f-mingw-w64-6.0.0-x86_64-w64-mingw32-headers.drv
  /nix/store/43l438jsccs6v3z31jjyzdyqyq8a4j9j-x86_64-w64-mingw32-binutils-2.34.drv
  /nix/store/jq4xbnxrip310cbj2hxazh96xmlf2p5q-x86_64-w64-mingw32-binutils-wrapper-2.34.drv
  /nix/store/k4spm1bmj8cwxg3hnz2yil3hncw95ghh-x86_64-w64-mingw32-stage-static-gcc-debug-10.2.0.drv
  /nix/store/wc8g0a8n3di1ybn898bmf956k30y94gm-x86_64-w64-mingw32-stage-static-gcc-debug-wrapper-10.2.0.drv
  /nix/store/gq1dix827kik7m81vqflz09wv3m4m42m-stdenv-linux.drv
  /nix/store/sym3i6lb0gk3w8zdh97p574vkb76gcis-mingw-w64-6.0.0-x86_64-w64-mingw32.drv
  /nix/store/q1n84n2g1h7vg5pxzw9bjb0mwk5zgwn8-x86_64-w64-mingw32-binutils-wrapper-2.34.drv
  /nix/store/0n81lj0ypj4afr6ciml7jh6h2hb5gkv8-x86_64-w64-mingw32-stage-static-gcc-debug-wrapper-10.2.0.drv
  /nix/store/cf9i2f70dwipk6mx3gscgv7drnswbkhk-stdenv-linux.drv
  /nix/store/1hmw26bphrsh5xw17hykxz10abif5k3y-mcfgthreads-git-x86_64-w64-mingw32.drv
  /nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv
  /nix/store/m4xaqmy5g4xd71dbxqmp4qz37q7a894q-x86_64-w64-mingw32-stage-final-gcc-debug-10.2.0.drv
  /nix/store/sh4dw58v41f2nzi6s0ylwj60i2lglx8z-x86_64-w64-mingw32-stage-final-gcc-debug-wrapper-10.2.0.drv
  /nix/store/n5jsh4xymd8qrmciinqkxxkpq9jsvgvg-stdenv-linux.drv
  /nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv
building '/nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv'...
building '/nix/store/43l438jsccs6v3z31jjyzdyqyq8a4j9j-x86_64-w64-mingw32-binutils-2.34.drv'...
building '/nix/store/a12yra4nkkgcmigsq9h6qnx8ydi74ad9-stdenv-linux.drv'...
building '/nix/store/3iw31akfh9h4455dhs6snmdz2k2l827f-mingw-w64-6.0.0-x86_64-w64-mingw32-headers.drv'...
unpacking sources
unpacking source archive /nix/store/3n4i0m7s953lh0si9j9zl10i2xy8cmka-mingw-w64-v6.0.0.tar.bz2
unpacking sources
unpacking source archive /nix/store/pp6qa6cd4scy76dinpgic0g6vfz6g472-binutils-2.34.tar.bz2

trying https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch from any mirror
builder for '/nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/m4xaqmy5g4xd71dbxqmp4qz37q7a894q-x86_64-w64-mingw32-stage-final-gcc-debug-10.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sh4dw58v41f2nzi6s0ylwj60i2lglx8z-x86_64-w64-mingw32-stage-final-gcc-debug-wrapper-10.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n5jsh4xymd8qrmciinqkxxkpq9jsvgvg-stdenv-linux.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv' failed

Also, it's probably easier to not nixpkgs-fmt openssl/default.nix, given this is a minor edit.

I tried building this locally, but there seems to be a patch gone missing:
❯ nix-build -A pkgs.pkgsCross.mingwW64.openssl_1_1
these derivations will be built:
  /nix/store/a12yra4nkkgcmigsq9h6qnx8ydi74ad9-stdenv-linux.drv
  /nix/store/3iw31akfh9h4455dhs6snmdz2k2l827f-mingw-w64-6.0.0-x86_64-w64-mingw32-headers.drv
  /nix/store/43l438jsccs6v3z31jjyzdyqyq8a4j9j-x86_64-w64-mingw32-binutils-2.34.drv
  /nix/store/jq4xbnxrip310cbj2hxazh96xmlf2p5q-x86_64-w64-mingw32-binutils-wrapper-2.34.drv
  /nix/store/k4spm1bmj8cwxg3hnz2yil3hncw95ghh-x86_64-w64-mingw32-stage-static-gcc-debug-10.2.0.drv
  /nix/store/wc8g0a8n3di1ybn898bmf956k30y94gm-x86_64-w64-mingw32-stage-static-gcc-debug-wrapper-10.2.0.drv
  /nix/store/gq1dix827kik7m81vqflz09wv3m4m42m-stdenv-linux.drv
  /nix/store/sym3i6lb0gk3w8zdh97p574vkb76gcis-mingw-w64-6.0.0-x86_64-w64-mingw32.drv
  /nix/store/q1n84n2g1h7vg5pxzw9bjb0mwk5zgwn8-x86_64-w64-mingw32-binutils-wrapper-2.34.drv
  /nix/store/0n81lj0ypj4afr6ciml7jh6h2hb5gkv8-x86_64-w64-mingw32-stage-static-gcc-debug-wrapper-10.2.0.drv
  /nix/store/cf9i2f70dwipk6mx3gscgv7drnswbkhk-stdenv-linux.drv
  /nix/store/1hmw26bphrsh5xw17hykxz10abif5k3y-mcfgthreads-git-x86_64-w64-mingw32.drv
  /nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv
  /nix/store/m4xaqmy5g4xd71dbxqmp4qz37q7a894q-x86_64-w64-mingw32-stage-final-gcc-debug-10.2.0.drv
  /nix/store/sh4dw58v41f2nzi6s0ylwj60i2lglx8z-x86_64-w64-mingw32-stage-final-gcc-debug-wrapper-10.2.0.drv
  /nix/store/n5jsh4xymd8qrmciinqkxxkpq9jsvgvg-stdenv-linux.drv
  /nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv
building '/nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv'...
building '/nix/store/43l438jsccs6v3z31jjyzdyqyq8a4j9j-x86_64-w64-mingw32-binutils-2.34.drv'...
building '/nix/store/a12yra4nkkgcmigsq9h6qnx8ydi74ad9-stdenv-linux.drv'...
building '/nix/store/3iw31akfh9h4455dhs6snmdz2k2l827f-mingw-w64-6.0.0-x86_64-w64-mingw32-headers.drv'...
unpacking sources
unpacking source archive /nix/store/3n4i0m7s953lh0si9j9zl10i2xy8cmka-mingw-w64-v6.0.0.tar.bz2
unpacking sources
unpacking source archive /nix/store/pp6qa6cd4scy76dinpgic0g6vfz6g472-binutils-2.34.tar.bz2

trying https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch from any mirror
builder for '/nix/store/v6ahf53lbv7zgxdxh6lwwnif4i7934rc-9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/m4xaqmy5g4xd71dbxqmp4qz37q7a894q-x86_64-w64-mingw32-stage-final-gcc-debug-10.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sh4dw58v41f2nzi6s0ylwj60i2lglx8z-x86_64-w64-mingw32-stage-final-gcc-debug-wrapper-10.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n5jsh4xymd8qrmciinqkxxkpq9jsvgvg-stdenv-linux.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pr4g43p07pcj49ldcqimnwnnbc6q0bb9-openssl-1.1.1i-x86_64-w64-mingw32.drv' failed

Also, it's probably easier to not nixpkgs-fmt openssl/default.nix, given this is a minor edit.

Hello Florian,
I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.
 "nixpkgs": {
        "branch": "nixpkgs-unstable",
        "description": "Nix Packages collection",
        "homepage": "",
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "2080afd039999a58d60596d04cefb32ef5fcc2a2",
        "sha256": "0i677swvj8fxfwg3jibd0xl33rn0rq0adnniim8jnp384whnh8ry",
        "type": "tarball",
        "url": "https://github.com/NixOS/nixpkgs/archive/2080afd039999a58d60596d04cefb32ef5fcc2a2.tar.gz",
        "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
    }

Hello Florian,
I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.
 "nixpkgs": {
        "branch": "nixpkgs-unstable",
        "description": "Nix Packages collection",
        "homepage": "",
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "2080afd039999a58d60596d04cefb32ef5fcc2a2",
        "sha256": "0i677swvj8fxfwg3jibd0xl33rn0rq0adnniim8jnp384whnh8ry",
        "type": "tarball",
        "url": "https://github.com/NixOS/nixpkgs/archive/2080afd039999a58d60596d04cefb32ef5fcc2a2.tar.gz",
        "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
    }

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving https://github.com/NixOS/nixpkgs/issues/82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving https://github.com/NixOS/nixpkgs/issues/82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving #82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I wasn't able to build this, because the cross-gcc to mingw referred to a non-existent patch file (https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch), which seems to have disappeared
This has been solved in the meantime, by inlining the patches (see https://github.com/NixOS/nixpkgs/pull/107978).
Please rebase this PR to master, and as requested by @peti, don't reformat unrelated things.

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving #82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I wasn't able to build this, because the cross-gcc to mingw referred to a non-existent patch file (https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch), which seems to have disappeared
This has been solved in the meantime, by inlining the patches (see https://github.com/NixOS/nixpkgs/pull/107978).
Please rebase this PR to master, and as requested by @peti, don't reformat unrelated things.

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving #82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I wasn't able to build this, because the cross-gcc to mingw referred to a non-existent patch file (https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch), which seems to have disappeared from the internet.
This has been solved in the meantime, by inlining the patches (see #107978).
Please rebase this PR to master, and as requested by @peti, don't reformat unrelated things.

I have cleaned up the commit and resolved the merge conflict with commit https://github.com/NixOS/nixpkgs/commit/f52263ced0937e72453e7fbce9fefb5f425f650b

I am unable to reproduce the issue you are having. I have tested my changes against latest nixpkgs-unstable branch.

You have the patch locally but we do not so we can't fetch it.

I am confused a little. I wanted to contribute to solving #82924 for Windows. The only change I did was to openssl default.nix file. I didn't add any other files locally.
What do I need to do then so you guys can merge the fix?

I wasn't able to build this, because the cross-gcc to mingw referred to a non-existent patch file (https://raw.githubusercontent.com/lhmouse/MINGW-packages/740f233da00c4fb5bcc225b2e29768824bcecc58/mingw-w64-gcc-git/9000-gcc-10-branch-Added-mcf-thread-model-support-from-mcfgthread.patch), which seems to have disappeared from the internet.
This has been solved in the meantime, by inlining the patches (see #107978).
Please rebase this PR to master, and as requested by @peti, don't reformat unrelated things.

I have cleaned up the commit and resolved the merge conflict with commit https://github.com/NixOS/nixpkgs/commit/f52263ced0937e72453e7fbce9fefb5f425f650b

Where is this config thing installed, `dev?

Where is this config thing installed, `dev?

Adding buildPackages as argument to common is actually not required.

I have added the changes.

Adding buildPackages as argument to common is actually not required.

I have added the changes.

If config goes in $dev this is fine with me, but please add a comment saying so.

If config goes in $dev this is fine with me, but please add a comment saying so.

Adding buildPackages as argument to common is actually not required.

It seems that removing these makes tests unhappy.
attribute 'coreutils' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-3/pkgs/development/libraries/openssl/default.nix:37:60

Adding buildPackages as argument to common is actually not required.

It seems that removing these makes tests unhappy.
attribute 'coreutils' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-3/pkgs/development/libraries/openssl/default.nix:37:60

But how would it work before? It's the same buildPackages that is used.

But how would it work before? It's the same buildPackages that is used.

I'm also getting attribute 'coreutils' missing when I just apply this patch and try to cross-compile openssl_1_1. Presumably this is because openssl is part of the bootstrapping process, and at the point where it's supposed to work, buildPackages.coreutils doesn't exist yet?
We could do something like
if buildPackages ? coreutils then buildPackages.coreutils else coreutils
but maybe that's too kludgy. It did fix the issue for me.

I fixed it; the bootstrapping issue was just because of the fetchurl overrides in all-packages.nix being quite delicate.

Can confirm that this fixed it for me.
When I compile pkgsStatic.openssl, the tests fail to build, and I need to add "no-tests" to the configureFlags, and then it works. Can we add that in this PR, or should I open a new one after this is merged for "openssl: fix static compile"

@Radvendii Let's just do that separately.


[GHSA-5c5f-7vfq-3732] JMESPath for Ruby using JSON.load instead of JSON.parse

Updates

CWEs

As of the time of writing this comment, there is no CWE on the NVD page for this issue. After reviewing the issue described on the JMESPath for Ruby repository, I believe CWE-502 is consistent with the issue described in the reference links.


Refactor login form into a single component

Details
Before, the LoginForm component had narrow and wide counterparts (sub-components), which made the logic confusing.
In lieu of the changes in https://github.com/Expensify/Expensify.cash/pull/2196, we can now refactor this into a single component without these counterparts and clean up the code.
Fixed Issues
Expensify/Expensify#157816
Tests

Navigate to the sign in page.
Verify it renders the same as it does on production.

QA Steps

Navigate to the sign in page.
Verify the welcome text everything renders correctly.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

🚀 Deployed to staging 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[authority store] replace struct used for storing individual objects

Currently, objects are stored in rocksdb as mapping objects: DBMap<ObjectKey, Object>.
There are a lot of duplicates in db because different versions of an object with the exactly same content are stored separately.
In the devnet-prod environment such duplicated objects consume >42% of the disk space.
Even with a new pruning job, it can take a while before rocksdb frees the storage, because of the way compaction works.
This PR introduces the StoreObject struct, which is a slightly forked version of the original object struct.
It adds additional value into the underlying Data enum that allows referencing object value by its digest instead of directly embedding it. For external call sites interface remains the same.
Each indirect object carries reference count field that represents how many object versions share the same value. Value gets automatically updated by rocksdb merge operator. Once it hits 0, compaction job will GC it.
Notes:

PR is not backward compatible. Requires wipe of the state
heuristic for deciding to store objects directly or indirectly is still TBD

Pointers for code review:

crates/sui-core/src/authority/authority_store_types.rs contains type definitions for new object representation
crates/typed-store/src/rocks/util.rs contains merge operator and compaction filter for rocksdb used to implement reference count column

It would make sense to skip the changes in authority_store_pruner altogether (since we are not enabling the feature yet in this PR and we have to change the pruning approach almost completely) and integrate indirect table with the new checkpoint tailer based pruning.

ok, I stashed major pruner changes. We can probably still run the experiment, but can't fully enable indirect setup until pruner is fixed


new(tests): add fibonacci and factorial tests for CALLF

🗒 Description
Add tests implementing fibonacci sequance and factorial using recursive CALLF instructions.
They were originally contributed to ethereum/tests by @hugo-dc in https://github.com/ethereum/tests/commit/89c2147b9b7495421eecb4443012da0fc7d5a3a4.
I'm migrating the tests separately because they are nice examples.
✅ Checklist

[x] All: Set appropriate labels for the changes.
[ ] All: Considered squashing commits to improve commit history.
[ ] All: Added an entry to CHANGELOG.md.
[ ] All: Considered updating the online docs in the ./docs/ directory.
[ ] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
[ ] Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
[ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases:  e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
[ ] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Do we have the rest of CALLF_RETF_Execution cases covered with this?

Not this one, I have one more commit to be sent.


AudioItem artwork with URL

Hi,
Actually every artwork of my tracks are remote images, so I want to fetch this artwork when the track start to play. What's the best way to load AudioItem image from URL ?
Sorry, maybe this is trivial but I don't have any example of implementation ...
Thanks !

Hey Francois,
You can create your AudioItem instance, ask for the player to play, download your image on a background thread or read from any cache you might have and update the AudioItem instance you created before. AudioPlayer will be notified for that change and will update what is necessary.
Let me know if you have any more question!


Not able to read Numeric data from Sheet

Hello,
I can not read the numeric value from sheet through sharedStrings. Could you please check this ? i attached the screenshot of example sheet. ( Here, i m not getting the values 1,2,3.. from "No" column. )

Hi @sunilk5893, would you be able to attach the file here or send it to<EMAIL_ADDRESS>so that I could check what the issue is? Thanks!

let sharedStrings = try file.parseSharedStrings()
        for path in try file.parseWorksheetPaths()
        {
            let ws = try file.parseWorksheet(at: path)

            // parse columns
            for alphabt in alphaArr
            {
                let cells = ws.cells(atColumns: [ColumnReference(alphabt)!])
                let columnCStrings = cells.compactMap{ $0.value }.compactMap { Int($0) }.compactMap {sharedStrings.items[$0].text }
                print(columnCStrings)
            }
        }

Above is my code in swift. If you see the "print(columnCStrings)" in xcode consol, then it is not printing numeric values like 1,2,3 ( rather than this, all data will print from xls file.
Let me know the solution if i m doing something wrong.
Thanks.

Hello,
is there any update on above issue? Sorry, but i m in hurry to execute next tasks. Request you to check the issue asap and let me know. Thanks.

Hi @sunilk5893, sorry for the delay. I had a closer look at your file and I'm able to get the values of those cells. To clarify, parseSharedString only gives you values of strings cells that are stored separately from cell values internally in the format. You can get determine if a cell value references a shared string by looking at its type property, where "s" stands for "shared", I've updated the corresponding example in README.md to clarify this:
let columnCStrings = ws.cells(atColumns: [ColumnReference("C")!])
  // in format internals "s" stands for "shared"
  .filter { $0.type == "s" }
  .compactMap { $0.value }
  .compactMap { Int($0) }
  .compactMap { sharedStrings.items[$0].text }

For the rest of the cells you can get the value directly from value property of the cell. Does this resolve your issue?


next-css: Support passing orderWarning option to ExtractCssChunks webpack plugin

https://github.com/faceyspacey/extract-css-chunks-webpack-plugin supports an extra orderWarning option but the next-css plugin currently (tested on 0.2.1-canary4) doesn't offer any way of passing a value to this parameter.
Just dropping this here for the record. The ExtractCssChunks is pretty clear, I might open a PR next week.

Hi, thanks for creating an issue. We currently recommend using https://nextjs.org/docs/basic-features/built-in-css-support as the plugins have been deprecated in favor of the built-in support.


Converting GPUParticles3D to CPUParticles3D (or vice versa) doesn't preserve ring emission shape properties

Tested versions

Reproducible in: 4.4.dev7

System information
Godot v4.4.dev7 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; <IP_ADDRESS>36) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Issue description
Converting GPUParticles3D to CPUParticles3D (or vice versa) doesn't preserve ring emission shape properties. In comparison, most other emission shape properties (point, box, sphere, sphere surface) are preserved both ways.
This should be straightforward to resolve by modifying gpu_particles_3d.cpp and cpu_particles3D.cpp's convert_from_particles() methods. Read the properties from the source node and apply them to the newly created node.
GPUParticles3D
Before converting to CPUParticles3D

After converting to CPUParticles3D

CPUParticles3D
Before converting to GPUParticles3D

After converting to GPUParticles3D

Steps to reproduce

Create a CPUParticles3D node with a ring emission shape and non-default values for the height, inner radius, outer radius and angle.
Convert it to GPUParticles3D using the menu at the top of the 3D editor viewport.
Notice how the ring reverts to its default cylinder-like appearance.
Change the properties in ParticleProcessMaterial, then convert it back to CPUParticles3D.
Notice how the shape reverts to its default cylinder-like appearance again.

Minimal reproduction project (MRP)
test_particles_ring_conversion.zip

Hi is this ticket available?

Godot Engine repo does not practice assigning issues. Since this is tagged as good first issue, just go ahead


Recipe for making non-Sendable, mutable, properties be Sendable and immutable

I am quite new to Swift concurrency so I greatly appreciate the wisdom of others in this project to help me determine if this is a valid recipe or not. Any feedback is welcome!
A Xcode compiler warning that I receive a lot is:

Stored property '' of 'Sendable'-conforming class '' is mutable

Example of code that would give me this warning:
final class Foo: Sendable {
  var bar: String = "" <--- property would receive this warning

  // To make things even more interesting, I may have a non-Sendable type that can
  // give this warning as well as other warnings.
  var bar2: NonSendableType = ....
}

// Structs give this warning, too.
struct FooStruct: Sendable {
  var bar: String = "" <-- also gives this warning
}

Because I saw this warning so much in my project, I wanted to see if there was a way that I could resolve all these warnings using a common design pattern while not having to use @unchecked Sendable for my data structure.
This is the "recipe" that I came up with.
First, create this class that acts as a wrapper around a generic data type:
public final class MutableSendable<DataType: Any>: @unchecked Sendable {

    private var value: DataType

    init(_ value: DataType) {
        self.value = value
    }

    private let _lock = NSRecursiveLock()

    func get() -> DataType {
        _lock.lock()

        let returnValue = value

        _lock.unlock()

        return returnValue
    }

    func set(_ modifyBlock: (DataType) -> DataType) {
        _lock.lock()
        defer { _lock.unlock() }

        self.value = modifyBlock(value)
    }

    func set(_ newValue: DataType) {
        _lock.lock()
        defer { _lock.unlock() }

        self.value = newValue
    }
}

Then, taking the code I gave earlier in this issue, I can apply this refactor:
final class Foo: Sendable {
  let bar = MutableSendable<String>(value: "") <-- no more warning!

  // No warning for non-Sendable either!
  let bar2 = MutableSendable<NonSendableType>(...)
}

// No more warning for structs, too.
struct FooStruct: Sendable {
  let bar = MutableSendable<String>(value: "") <-- also gives this warning
}

The warnings are gone, yes, but at a cost. You have to change the way you get/set the property in your class:
final class Foo: Sendable {
  let bar = MutableSendable<String>(value: "") <-- no more warning!

  func modifyBar(newValue: String) {
    // I want to use:
    bar = newValue

    // But I have to use:
    bar.set(newValue)
  }
}

I would love to use something like a property wrapper to bring back the get/set syntax but the original xcode warning would still exist:
final class Foo: Sendable {
  @MutableSendable var bar: String = "" <-- 😞 warning comes back, property wrappers must use 'var'

  func modifyBar(newValue: String) {
    // But, I can use the nice get/set syntax!
    bar = newValue
  }
}

I think recipes to resolve this compiler warning is missing from this project. Any interest in contributions for recipes for this warning?

It is really common to try to use locked wrappers for these kinds of problems.
https://mastodon.social/@cocoaphony/112134000958953244
I think it may be worthwhile to include something like this. However, in my own code I have migrated towards other approaches. Here's what I wrote in response to that post:

I think it is correct.
On my journey, I did stuff like this. And over time, I began to focus more on minimizing the need to cross boundaries, instead of making it easier. It can be a lot easier said than done though.

So while I am very into suggesting this as an option, I think the default for many is "I just want this to be Sendable" and I think that can be a trap. Now, like I said, just because I think it is a bad idea, doesn't make it any easier to do something else. Expanding actor boundaries can require redesigning your system, and that is often just infeasible.


Wrong component ID

Universal Windows Platform build tools for component C++ (v143) Universal Windows Platform tools has wrong ID and can't be installed from command line: Microsoft.VisualStudio.ComponentGroup.UWP.VC.BuildTools.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1e062363-94e9-f776-650f-a0723ab713a3
Version Independent ID: 9181db12-cbdf-6f95-27f1-833930d6d323
Content: Visual Studio Build Tools workload and component IDs
Content Source: docs/install/workload-component-id-vs-build-tools.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@miler-code -- Bohdan, thank you for catching this.  The correct ID may be Microsoft.VisualStudio.ComponentGroup.UWP.VC.v143.BuildTools; I don't have the setup to test this theory.
@anandmeg -- Megha, please look into this issue.

@miler-code, thanks for your feedback. "Microsoft.VisualStudio.ComponentGroup.UWP.VC.BuildTools" is the component id for component "C++ (v143) Universal Windows Platform tools".
Can you please share more details on your environment/scenario? Thanks!
Alternatively, you can consider installing the workload Universal Windows Platform build tools to get all the components.

@miler-code, thanks again for the feedback. Closing this issue now.
Please reopen with additional details on your scenario to enable us to better assist you. Thanks!


Fix build warning spelling mistake

I just switched to mini_racer and noticed this spelling mistake in our Travis CI build. I figured it would help if I submitted a pull request to fix it.

Hello,
Thank you for taking the time to submit a PR!


[Linux] Fatal error on build

Failure to build on Linux after running npm run build, tried the git and source code
https://transfer.sh/6bP9t/tsc-p..txt
https://transfer.sh/qWTHK/npm-debug.log
Any requested or related information will be delivered upon request

You forgot to install modules:
https://github.com/Nicklason/tf2-automatic/wiki/Installation#installing-modules

Thought the building of modules was installing, my mistake.  When building the modules it gives the provided errors

Actually after running this, it isn't the same error.  My mistake (its 5 am over here, not in the soundest of minds right now).   Its an error with npm itself not working with the latest Linux kernal.  Sorry for the waste of time.