Where do I view output of logs?

I have created a Producer application and this is how the producer is configured.
var config = new Dictionary<string, object>()
{
                    {"bootstrap.servers", _brokerUrl},
                    {"client.id", "TEST.001"},
                    {"debug", "protocol"}
}
var producer = new Producer<string, string>(config, new StringSerializer(Encoding.UTF8), new StringSerializer(Encoding.UTF8));

var producerTask = _producer.ProduceAsync("TEST.Topic.001", "100", "500");
var result = producerTask.Result;

When I set the {"debug", "protocol"}, I was expecting to see some log outputs from Confluent.Kafka .net client / librdkafka. My test producer application is a standard windows .net console app. I can see the output from my own statements such as Console.WriteLine and if I am using a debug viewer, I can view output of my own Debug.WriteLine statements.
Just wondering, when I set {"debug", "protocol"}, where is the log output from Confluent.Kafka .net client / librdkafka recorded on the client machine? My test producer client console application is running on Windows 7, where as the Kafka server is running on a remote Linux server.
I am trying to create a test producer using c#, .NET 4.6.1 and I am using Confluent.Kafka 0.9.4, librdkafka.redist 0.9.4.

There is a bug with the serializing producer (see #134), you have to register to the OnLog event to see the logs (producer.OnLog += Loggers.ConsoleLogger should work to log to onsole, you can write your own mplementation)

That did the trick. Thank you for the suggestion. Both options worked.
producer.OnLog += Loggers.ConsoleLogger;

OR

producer.OnLog += OnProducerLog;

private void OnProducerLog(object sender, LogMessage e)
{
            //log4net
            Log.Debug($"ConfluentKafka : [{e.Name}] [{e.Facility}] [{ e.Level}] [{e.Message}]");
}

Every time I enable debug = protocol, I am now able to capture the logs except that at the end, I see following error "Unhandled Exception: System.AppDomainUnloadedException: Attempted to access an unloaded AppDomain.", is this the bug you are referring to?

The AppDomainUnloadedException here is something I haven't seen before.
I believe the bug @treziac was referring to is the need to register a log handler to see the messages (changed in master).

Are you disposing the Producer before exiting?

I was referring to the logging only, ever saw this error neither.
Could you post your complete code?

Sure, I will gather the important parts and post it soon.

I found the issue, it was on my side. I was prematurely disposing the Producer. As this issue was occurring only when {"debug", "protocol"} is used, I thought it may have to do something with OnLog. I now identified the source of that error and it is working without any issues.

perhaps it's possible to do something better with throwing exceptions here, but I'll close this as too low priority to worry about for now. If we see this repeatedly come up again we might re-consider.


Crash on startup - Garnished 1.0

Minecraft just crashes instantly. Using latest Create, Garnished and Forge 47.2.0
I don't know if this may be the main culprit, but it does not look right (Got this error by accidentally only launching Garnished)
[main/ERROR] [ne.mi.fm.lo.ModSorter/LOADING]: Missing or unsupported mandatory dependencies: 	Mod ID: 'create', Requested by: 'garnished', Expected range: '[0.5.0.i,)', Actual version: '[MISSING]'
https://mclo.gs/iaQM7lH

Try downgrading to anything below Create 0.5.1e, as there is a known incompatibility between Garnished and this version of Create. It will be fixed once the Fabric version of Create updates to 0.5.1e.


top overshoot sinks the whole glyph down

For glyphs with overshooting top diacritics, the diacritics are drawn successfully but the entire glyph is shifted down to compensate.
Can be seen in the screenshot https://github.com/agarick/agave/blob/master/img/lit.png
(in the greek section, the "E" in Eleates - screenshot taken in kitty on voidlinux, size 11, dpi 120)
Guessing that this began occurring when bounds were explicitly set, https://github.com/agarick/agave/releases/tag/v22
See also: cormullion / juliamono, issue 17

The juliamono issue mentioned above suggests that this behavior is due to kitty terminal's rendering and the issue is not present in xterm for example.
As the only "fix" I can think of is to increase the glyph box (but https://github.com/agarick/agave/issues/15) or squash the diacritical capitals even further, I will not fix this and pretend that it's a terminal issue rather than a font issue.

Actually, I'll try to squash the diacritical capitals even further, probably by moving the diacritics around somehow so there are no overshoots whatsoever.

Fixed in https://github.com/agarick/agave/releases/tag/v26
Some of the resulting diacritical glyphs are ugly and possibly typographically wrong, but this is the best I can do, given space constraints and reluctance to globally increase line-height.


Not able to use IntelliJ IDE+Remote-Robot framework with github actions

Several attempts were made to get the IntelliJ IDE+Remote-Robot work with github actions, the IDE does not start on any OS (LINUX, WIN, OS X) - tested on localhost, the run of the UI tests works on localhost, but not in github actions.
PR drafts to create new github actions to run the UI tests:

https://github.com/redhat-developer/intellij-quarkus/pull/258
https://github.com/redhat-developer/intellij-quarkus/pull/301
https://github.com/redhat-developer/intellij-quarkus/pull/304

Could you please check if the IDE can start with runIde task?

Sorry, I don't have experience with github actions, I've looked at logs:
on linux
  Test executionError FAILED

  com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT2S) for condition function (Failed to find 'Welcome To IntelliJ IDEA Dialog' by 'FlatWelcomeFrame type' in 2s)

that could mean that Ide started, robot-sever-plugin was able to receive the the request to find a welcome frame but was not success finding it in 2 sec. If the Ide hadn't started there would be a some timeout exception. Is there any logs left from the Ide? Seems like the Ide failed to be rendered on the screen.
on windows:
Run ./gradlew runIdeForUiTests -PideaVersion=2020.1 &
ParserError: D:\a\_temp\a1507db0-0323-4483-b4f3-e9de5b12e2ff.ps1:7
Line |
   7 |  while [ $started -ne 0 ]; do
     |       ~
     | Missing opening '(' after keyword 'while'.

Error: Process completed with exit code 1.

seems that in powershell it should be () instead of [] in the while expression
and on mac it's hard to say as it was just Error: The operation was canceled.
Or maybe I watch it wrong place?

@nizienko I have updated the windows PR for PowerShell. The syntax issues are gone. Now it has the same behavior as the OS X version and I do know what happened. Both OS X and windows PRs starts first process (./gradlew runIdeForUiTests) and after that it waits in the loop until the Idea started and shows its UI (= it checks whether the localhost:8082 is available using curl). After that the loop ends and the ./gradlew integrationTest starts.
The issue is (and the reason for this github issue is), that the IDE never starts, the localhost:8082 is never available and the loop never ends (everything is terminated after a long long time - thats the reason you see the Error: The operation was canceled)
The linux PR is little bit trickier - I have created this issue in the time the linux PR has exactly the same issue as the OS X (and windows after the PowerShell fixes). Since then there has been sever commits pushed to the PR and now it looks like the Ide starts and everything fails because of issue in my UI test (that I will resolve by myself). The question is, why does the linux PR starts the IntelliJ (I am not an author of the PR, probably I will have to write the author).

The problem is that the task runIdeForUiTest or runIde is not provided with a graphical user interface when executed in Github Actions and therefore does not start.
The solution to this problem is to run the application headless. This can be done with e.g. xvfb.
xvfb-run gradle runUiTests (on linux)
This solved the problem of the missing graphical user interface but after that I had the problem that I could not connect to the IDE running in runIDEforUITest, which resulted in an infinite pause for the IDE.

Hello,
I think I need to clarify something here.
The problem is that when you try tasks like runIde or runIdeForUiTests in an environment without a graphical user interface, they don't start with the error no graphical user interface.
This problem can be solved by using (under Linux) a program like xvfb, which simulates a display. If you now start tasks like runIde or runIdeForUiTests with xvfb, they execute but the ide does not start.
Because when the Ide is starting for the first time, the terms and conditions must be accepted and the sharing of data must be allowed or prohibited. Only then does the Ide start normally.
Under linux this can be done with the following commands:
Disable IntelliJ data sharing
RUN set -x \
  && dir=/root/.local/share/JetBrains/consentOptions \
  && mkdir -p "$dir" \
  && echo -n "rsch.send.usage.stat:1.1:0:$(date +%s)000" > "$dir/accepted"

Accept End User Agreement/privacy policy
RUN set -x \
  && dir="/root/.java/.userPrefs/jetbrains/_!(!!cg\"p!(}!}@\"j!(k!|w\"w!'8!b!\"p!':!e@==" \
  && mkdir -p "$dir" \
  && echo '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n\
<!DOCTYPE map SYSTEM "http://java.sun.com/dtd/preferences.dtd">\n\
<map MAP_XML_VERSION="1.0">\n\
  <entry key="accepted_version" value="2.1"/>\n\
  <entry key="eua_accepted_version" value="1.1"/>\n\
  <entry key="privacyeap_accepted_version" value="2.1"/>\n\
</map>' > "$dir/prefs.xml" \
  && cat "$dir/prefs.xml"

Feel free to optimise these commands :)
If the commands have now been executed and a task is now started with xvfb, it will start normally and function properly!
Unfortunately, this cannot be implemented directly in Github Actions, as the commands (access on /root/...) cannot be executed.
However, this can be implemented using a separate docker container.
For an example, see CodeTester-IDEA.
Perhaps this can be added to the documentation of the ui test robot.

Hello,
I think I need to clarify something here.
The problem is that when you try tasks like runIde or runIdeForUiTests in an environment without a graphical user interface, they don't start with the error no graphical user interface.
This problem can be solved by using (under Linux) a program like xvfb, which simulates a display. If you now start tasks like runIde or runIdeForUiTests with xvfb, they execute but the ide does not start.
Because when the Ide is starting for the first time, the terms and conditions must be accepted and the sharing of data must be allowed or prohibited. Only then does the Ide start normally.
Under linux this can be done with the following commands:
Disable IntelliJ data sharing
RUN set -x \
  && dir=/root/.local/share/JetBrains/consentOptions \
  && mkdir -p "$dir" \
  && echo -n "rsch.send.usage.stat:1.1:0:$(date +%s)000" > "$dir/accepted"

Accept End User Agreement/privacy policy
RUN set -x \
  && dir="/root/.java/.userPrefs/jetbrains/_!(!!cg\"p!(}!}@\"j!(k!|w\"w!'8!b!\"p!':!e@==" \
  && mkdir -p "$dir" \
  && echo '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n\
<!DOCTYPE map SYSTEM "http://java.sun.com/dtd/preferences.dtd">\n\
<map MAP_XML_VERSION="1.0">\n\
  <entry key="accepted_version" value="2.1"/>\n\
  <entry key="eua_accepted_version" value="1.1"/>\n\
  <entry key="privacyeap_accepted_version" value="2.1"/>\n\
</map>' > "$dir/prefs.xml" \
  && cat "$dir/prefs.xml"

Feel free to optimise these commands :)
If the commands have now been executed and a task is now started with xvfb, it will start normally and function properly!
Unfortunately, this cannot be implemented directly in Github Actions, as the commands (access on /root/...) cannot be executed.
However, this can be implemented using a separate docker container.
For an example, see CodeTester-IDEA.
Perhaps this can be added to the documentation of the ui test robot.

Hello,
I think I need to clarify something here.
The problem is that when you try tasks like runIde or runIdeForUiTests in an environment without a graphical user interface, they don't start with the error no graphical user interface.
This problem can be solved by using (under Linux) a program like xvfb, which simulates a display. If you now start tasks like runIde or runIdeForUiTests with xvfb, they execute but the ide does not start.
Because when the Ide is starting for the first time, the terms and conditions must be accepted and the sharing of data must be allowed or prohibited. Only then does the Ide start normally.
Under linux this can be done with the following commands:
Disable IntelliJ data sharing
RUN set -x \
  && dir=/root/.local/share/JetBrains/consentOptions \
  && mkdir -p "$dir" \
  && echo -n "rsch.send.usage.stat:1.1:0:$(date +%s)000" > "$dir/accepted"

Accept End User Agreement/privacy policy
RUN set -x \
  && dir="/root/.java/.userPrefs/jetbrains/_!(!!cg\"p!(}!}@\"j!(k!|w\"w!'8!b!\"p!':!e@==" \
  && mkdir -p "$dir" \
  && echo '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n\
<!DOCTYPE map SYSTEM "http://java.sun.com/dtd/preferences.dtd">\n\
<map MAP_XML_VERSION="1.0">\n\
  <entry key="accepted_version" value="2.1"/>\n\
  <entry key="eua_accepted_version" value="1.1"/>\n\
  <entry key="privacyeap_accepted_version" value="2.1"/>\n\
</map>' > "$dir/prefs.xml" \
  && cat "$dir/prefs.xml"

Feel free to optimise these commands :)
If the commands have now been executed and a task is now started with xvfb, it will start normally and function properly!
Unfortunately, this cannot be implemented directly in Github Actions, as the commands (access on /root/...) cannot be executed.
However, this can be implemented using a separate docker container.
For an example, see CodeTester-IDEA.
Perhaps this can be added to the documentation of the ui test robot.

Hello,
I think I need to clarify something here.
The problem is that when you try tasks like runIde or runIdeForUiTests in an environment without a graphical user interface, they don't start with the error no graphical user interface.
This problem can be solved by using (under Linux) a program like xvfb, which simulates a display. If you now start tasks like runIde or runIdeForUiTests with xvfb, they execute but the ide does not start.
Because when the Ide is starting for the first time, the terms and conditions must be accepted and the sharing of data must be allowed or prohibited. Only then does the Ide start normally.
Under linux this can be done with the following commands:
Disable IntelliJ data sharing
RUN set -x \
  && dir=/root/.local/share/JetBrains/consentOptions \
  && mkdir -p "$dir" \
  && echo -n "rsch.send.usage.stat:1.1:0:$(date +%s)000" > "$dir/accepted"

Accept End User Agreement/privacy policy
RUN set -x \
  && dir="/root/.java/.userPrefs/jetbrains/_!(!!cg\"p!(}!}@\"j!(k!|w\"w!'8!b!\"p!':!e@==" \
  && mkdir -p "$dir" \
  && echo '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n\
<!DOCTYPE map SYSTEM "http://java.sun.com/dtd/preferences.dtd">\n\
<map MAP_XML_VERSION="1.0">\n\
  <entry key="accepted_version" value="2.1"/>\n\
  <entry key="eua_accepted_version" value="1.1"/>\n\
  <entry key="privacyeap_accepted_version" value="2.1"/>\n\
</map>' > "$dir/prefs.xml" \
  && cat "$dir/prefs.xml"

Feel free to optimise these commands :)
If the commands have now been executed and a task is now started with xvfb, it will start normally and function properly!
Unfortunately, this cannot be implemented directly in Github Actions, as the commands (access on /root/...) cannot be executed.
However, this can be implemented using a separate docker container.
For an example, see CodeTester-IDEA.
Perhaps this can be added to the documentation of the ui test robot.

Try:
systemProperty("jb.privacy.policy.text", "<!--999.999-->")

https://github.com/JetBrains/intellij-community/blob/0c2a12b254102e25093117f7b8d273cd986c150e/platform/platform-impl/src/com/intellij/ide/gdpr/EndUserAgreement.java#L218

Try:
systemProperty("jb.privacy.policy.text", "<!--999.999-->")

https://github.com/JetBrains/intellij-community/blob/0c2a12b254102e25093117f7b8d273cd986c150e/platform/platform-impl/src/com/intellij/ide/gdpr/EndUserAgreement.java#L218

@fxnm, @abrooksv thank you for helping here! I've added your answer to the FAQ

@fxnm, @abrooksv thank you for helping here! I've added your answer to the FAQ

Hello, I've managed to launch our test examples on all 3 OSs using Github Actions.
https://github.com/JetBrains/intellij-ui-test-robot/blob/master/.github/workflows/runTest.yml


Follow up question for npm scan

This is a follow-up question mentioned in https://github.com/jeremylong/DependencyCheck/issues/3429
Since the report is not showing what are the files scanned, so when I compare with npm audit report - I saw lot of discrepancies. So, wanted to ask that dependency check report filtering the report from npm audit ? if so, is there any common condition/schema for that ?

How did you run ODC - what options were configured?

Below is the command I used:
dependency-check core --format ALL --project "PROJ_NAME" --scan "PROJ_PATH" --nodeAuditSkipDevDependencies

@jeremylong can you please let me know the IDC command is fine that I used and guide me on the skipped vulnerabilities from npm audit ? (skipped package is not a dev one, though)

@asamkamalesan I would need to see the lock file.


x/tools/go/analysis/passes/fieldalignment: suggested fix producing garbled output

What version of Go are you using (go version)?

$ go version
go version go1.15.5 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOENV="/Users/user/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/user/work/go/pkg/mod"
GOOS="darwin"
GOPATH="/Users/user/work/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.5/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.5/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/tmp/test-gopls/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vh/853pkypj3tnd78rgvfhgc9kr0000gn/T/go-build258818279=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
enabled the following analysis after upgrading to gopls 0.6.0
"analyses": {
"fieldalignment": true
}
What did you expect to see?
Following sample code to demonstrate the issue:
package main

import "fmt"

type Settings struct {
	AllowedEvents []*string // allowed events
	BlockedEvents []*string // blocked events
	APIVersion    string    `mapstructure:"api_version"`
	BaseURL       string    `mapstructure:"base_url"`
	AccessToken   string    `mapstructure:"access_token"`
}
func main() {
	s := &Settings{
		APIVersion:    "",
		BaseURL:       "",
		AccessToken:   "",
		AllowedEvents: []*string{},
		BlockedEvents: []*string{},
	}
	fmt.Println(s)
}

applied fieldalignment codelens in vscode
What did you see instead?
type Settings struct {
	APIVersion    string    `mapstructure:"api_version"`
	BaseURL       string    `mapstructure:"base_url"`
	AccessToken   string    `mapstructure:"access_token"`
	AllowedEvents []*string
	BlockedEvents [ // allowed events
	]*string      // blocked events
}

initially I thought that I made a mistake with the comments so I tried the following struct
type Settings struct {
	// test1
	AllowedEvents []*string
	// test2
	BlockedEvents []*string
	APIVersion    string `mapstructure:"api_version"`
	BaseURL       string `mapstructure:"base_url"`
	AccessToken   string `mapstructure:"access_token"`
}

after applying fieldanalysis codelens to above struct it became garbled too
type Settings struct {
	APIVersion    string `mapstructure:"api_version"`
	BaseURL       string `mapstructure:"base_url"`
	AccessToken   string `mapstructure:"access_token"`
	AllowedEvents [ // test1
	]*string
	BlockedEvents [ // test2
	]*string
}

/cc @leitzler

@shreyaskarnik could you try to reproduce it with the latest version of gopls? It shouldn't produce garbled output, and CL 278872 should solve that issue. However, due to how AST parsing works right now it is solved by removing comments.

@shreyaskarnik could you try to reproduce it with the latest version of gopls? It shouldn't produce garbled output, and CL 278872 should solve that issue. However, due to how AST parsing works right now it is solved by removing comments.

@leitzler Thanks for fixing this, it is working as described.

@leitzler Thanks for fixing this, it is working as described.


DOC-4618 clarify datadog charges

Addresses: DOC-4618

Adds mention to the CC monitoring page indicating, early on, that Datadog integration adds to DD bill, but does not affect CC bill
Adds monitoring item to CC FAQ directing to above, which includes brief mention of billing.

monitoring-page.md | frequently-asked-questions.md

Thanks @thtruo agreed & changed made.

TYFRs both!!


Corrupt ZIP: end of central directory record signature not found

We have written the needed data into your clipboard because it was to
Issue Type: Bug
Trying to install the Python extension and received this error:
[renderer1] [error] Corrupt ZIP: end of central directory record signature not found: Invalid: Corrupt ZIP: end of central directory record signature not found
    at te.downloadExtension (vscode-file://vscode-app/c:/Users/Ben/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:78:215651)
    at async te.doRun (vscode-file://vscode-app/c:/Users/Ben/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:78:214593)

Manually installing the extension with a vsix file resulted in the same error.
the C/C++ extension installed fine.
I found a number of pages reporting the same issue, but none seemed to provide the answer.
I'm not working on a remote server.
VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:52.460Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 5 5600X 6-Core Processor              (12 x 3700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (24.71GB free)

Process Argv
--crash-reporter-id e0884329-143a-4018-b350-ddb247faac93

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

cpptools
ms-
1.11.4

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30525689
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912cf:30529770
vsclangdc:30486549
c4g48928:30535728

o large to send. Please paste.

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Unit test for pallet-staking unsorted bags feature (targets #9081)

target branch: prgn-nominator-unsorted-bags
target pr:  #9081
cc @kianenigma

@kianenigma   I updated rebond and ubond to do_rebag (which addreses your comments on this pr and my comment on the feature pr) in this commit 887035169fabb7778e806c8a6f36fa6c092fe5e2
However rebond weights looks strange to me:
			Ok(Some(
				35 * WEIGHT_PER_MICROS +
					50 * WEIGHT_PER_NANOS * (ledger.unlocking.len() as Weight) +
					T::DbWeight::get().reads_writes(3, 2),
			)

and I am not sure how we should update it to account for rebag-ing? Should we update the benchmarks to force a rebag and then just use that weight? (I imagine we should update benchmarks for any extrinsic that does a rebag, or have rebag return a weight and use that)

@kianenigma https://github.com/paritytech/substrate/pull/9422/commits/ec7b7cc223ffeb634ae7cd357a1500fdcfd4a1e7 adds in a check to prevent the a scenario we know that could lead to infinite loop:
fn insert_node(&mut self, mut node: Node<T>) {
		if let Some(tail) = &self.tail {
			if *tail == node.voter.id {
				// this should never happen, but this check prevents a worst case infinite loop
				debug_assert!(false, "system logic error: inserting a node who has the id of tail");
				crate::log!(warn, "system logic error: inserting a node who has the id of tail");
				return
			};
		}
...
}

I think the argument against this would be that this should never happen. But considering that this check is 1) easy & cheap and 2) it would prevent the major issue of the runtime getting stuck on a loop it seems worth it from my PoV

and I am not sure how we should update it to account for rebag-ing? Should we update the benchmarks to force a rebag and then just use that weight?

Yes the benchmark need to be update to the worse case, which means doing a rebag as well.
Once this is fixed, then we can merge this into the base branch


"Create and copy public link to clipboard" generates an invalid link

"Create and copy public link to clipboard" generates an invalid link
Describe the bug
Using the Windows desktop app pointed to an OCIS instance, when I right-click on a synced file in Windows and select "Create and copy public link to clipboard" a link is generated and copied to the clipboard but when browsing to that link an "Unknown error" is returned.
Steps to reproduce
Steps to reproduce the behavior:

Set up ownCloud Desktop App (Windows) pointed to an OCIS server
In Windows Explorer navigate to any file in ownCloud and right-click on it
In the context menu, select ownCloud-->Create and copy public link to clipboard
Open a web browser (I used Chrome) and paste/navigate to the URL that was copied to your clipboard.

Expected behavior
The browser should load a page where you can view/download the file
Actual behavior
Although a link gets generated and copied to the clipboard, when I view the file's properties I can see that no link was actually associated with this file and when I try to navigate to the URL a page is show that says "Unknown error"

Here is a video showing this behavior:

Setup
Installed/Started OCIS 2.0.0-beta.5 using the quick start guide here: https://doc.owncloud.com/ocis/next/quickguide/quickguide.html
Installed ownCloud Desktop App 2.10.1 (build 7187) and configured it to sync as virtual files to my OCIS instance.
Created a folder with some pictures in it.
Additional context
I can generate a valid link using the dialog that opens when I select ownCloud-->Share. After clicking that option I select the "Public Links" tab, click on the "Create new..." option and then click the "Create" button. I then click the "..." next to the newly created Public Link and select "Copy Link to Clipboard" and then paste/navigate to that link in a browser, This successfully allows me to access the file.
Here is a video showing this working successfully.

@michaelstingl can you have a look into this as well. We're unsure if it's desktop or backend.

We're unsure if it's desktop or backend.

Maybe desktop. Something's 🐟 -y. I'll have a look tomorrow…

What kind of permissions does the public link have? We've introduced so called Internal links, which have a permission bitmask of 0. Those are supposed to resolve into the correct shared location in the authenticated context of the user.
If the created link has permissions 0 then I'd have an explanation for the issue described above: Resolving internal links is not yet supported in ownCloud Web - support is coming with https://github.com/owncloud/web/pull/7405 which is close to being merged.
If it's a link with permissions > 0 then I have no idea, yet.

Because of https://github.com/owncloud/ocis/issues/4445 , Desktop sync client 2.11 tries to create a link with todays expiration date, and because https://github.com/owncloud/ocis/issues/4446 , the link creation fails silently.

No idea why both ways behave different in the desktop sync client. I opened an issue for further investigation: https://github.com/owncloud/client/issues/10057

@michaelstingl, can you still reproduce this? I can't but I'm testing it on Linux since I don't have Windows.

Should have been fixed with https://github.com/owncloud/ocis/pull/4475

Cool so I can close this issue?

yes 😁 @algihu please re-open if the issue is not fixed for you with ocis v2.0.0-beta.8

I just tested it again with v2.0.0-beta.8 and this feature now works correctly.

I just tested it again with v2.0.0-beta.8 and this feature now works correctly.

Thanks for investing the time :heart: Glad to hear that it's fixed 👍


Selecting first image attachment selects the last one

ANOMALY
When many images have been dropped to attachments Panel, clicking on the first image highlights the last one.
ANALYZE
In setAttachments(), only one AttachmentVisitor is created, which therefore store only the last added image
SOLUTION
In setAttachments(), create a new visitor for each attachment

Done in commit 6e19286b0e2dd634bfccbedadfdf052269b22000


k8s: managed service identity

This adds support for kubernetesConfig -> useManagedIdentity. This will activate an implicit identity for the k8s CRP VMs. This will enable the MSI VM Extension, and make the CSE depend on it.
This also now means that the agents will only get "Reader" permissions, lessening an attack surface in k8s clusters.
Ultimately, this removes the need for the user to specify SP credentials. As you can see below, the user can now just pass msi/msi as the credentials when using useManagedIdentity to get a working cluster.
Here's the caveats:

MSI is not GA'd. Not sure what regions it's available in.

The deployer must be "Owner", not just "Contributor".

This uses a somewhat silly hack rbacgenerator to generate the RBAC assignment resources. This is because ARM lacks a uniqueGUID function at the moment.

This requires a custom build of Kubernetes.

This is rebased on top of a 1.6 PR for ACS-Engine because my custom build of k8s is on HEAD

To test, the easiest thing to do is, modify test/user.env to set the SP creds that k8s will use, and to use my custom build of kubernetes.
export INSTANCE_NAME_PREFIX=colemick
export LOCATION=westus2

export TENANT_ID=d-e-f
export SUBSCRIPTION_ID=a-b-c
export SERVICE_PRINCIPAL_CLIENT_ID=clientid
export SERVICE_PRINCIPAL_CLIENT_SECRET=supersecret

#msi
export CLUSTER_SERVICE_PRINCIPAL_CLIENT_ID=msi
export CLUSTER_SERVICE_PRINCIPAL_CLIENT_SECRET=msi
export CUSTOM_HYPERKUBE_SPEC=docker.io/colemickens/hyperkube-amd64:master-msi

Then run ./test/deploy.sh examples/managed-identity/kubernetes.json.
The custom build of Kubernetes comes from this branch: https://github.com/colemickens/kubernetes/tree/msi
And note that that branch is currently using a non-master version of go-autorest. So there are a number of things still in motion here to some degree... but I wanted to get this out there so we can start getting tests running on it for longer term plans.

This change is

@colemickens,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@acs-bot test this please

One more caveat: I've not been able to test the Windows side of things yet because of the other blocking issues affecting Kubernetes 1.6 + Windows (+kubenet, it looks like...)

Is this ready for review ?

Based on my experience using MSI, I think we need to also automate adding MSI to the KeyVault. With cross resource group template deployment, we should include KV access policy in data model.
Also, I'd like to have master and agents accessing different Keyvault. So it seems more sensible to me to put MSI options under Master and AgentPoolProfiles.
Thoughts?

Sorry @weinong I don't quite follow. This is for the cloudprovider integration in Kubernetes, not for getting assets from MSI necessarily (although it could do both). This change doesn't require that the identity be shared or any such thing (I don't think we can handle those more advanced scenarios well until explicit identities come in).
It would be cool to start having ACS-Engine stash the PKI assets, etc into KeyVault and retrieving them, but that's not in scope for this PR. This just does the SP + RBACing so that K8s can call ARM APIs.

This is ready to review and merge hopefully. PR text has also been re-written to be more up-to-date and accurate.
cc: @dmitsh for reviewing the test config changes
cc: @weinong for reviewing the MSI change in general
cc: @seanknox for release/project management side of things - hopefully this one can be allowed... it's a new feature in isolation and pre-dates our new precedent for having an open issue.
I've tested this manually. I have a Jenkins job that has been running it.
From a cluster deployed via Jenkins, we see /etc/kubernetes/azure.json:
{
   "cloud":"AzurePublicCloud",
   "tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47",
   "subscriptionId": "8ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8",
   "aadClientId": "msi",
   "aadClientSecret": "msi",
   "resourceGroup": "x-managed-identity-kubernetes-msi-westus-27-2-0",
   "location": "westus",
   "subnetName": "k8s-subnet",
   "securityGroupName": "k8s-master-25273340-nsg",
   "vnetName": "k8s-vnet-25273340",
   "routeTableName": "k8s-master-25273340-routetable",
   "primaryAvailabilitySetName": "linuxpool1-availabilitySet-25273340",
   "cloudProviderBackoff": false,
   "cloudProviderBackoffRetries": 6,
   "cloudProviderBackoffExponent": 1.5,
   "cloudProviderBackoffDuration": 5,
   "cloudProviderBackoffJitter": 1,
   "cloudProviderRatelimit": false,
   "cloudProviderRateLimitQPS": 1,
   "cloudProviderRateLimitBucket": 5,
   "useManagedIdentityExtension": true
}

LOOK MA! No scary credentials!
And in sudo journalctl -u kubelet | grep azure | grep "access token":
azure.go:159] azure: using managed identity extension to retrieve access token

And in kubectl get nodes:
2017-07-13 10:42:47.364600 I | proto: duplicate proto type registered: google.protobuf.Any
2017-07-13 10:42:47.364650 I | proto: duplicate proto type registered: google.protobuf.Duration
2017-07-13 10:42:47.364679 I | proto: duplicate proto type registered: google.protobuf.Timestamp
NAME                        STATUS                     AGE       VERSION
25273acs9010                Ready                      2m        v1.6.4-beta.0.147+2b3fc68910b4dd
25273acs9011                Ready                      2m        v1.6.4-beta.0.147+2b3fc68910b4dd
k8s-linuxpool1-25273340-0   Ready                      2m        v1.8.0-alpha.2.85+531664519485fd-dirty
k8s-linuxpool1-25273340-1   Ready                      1m        v1.8.0-alpha.2.85+531664519485fd-dirty
k8s-master-25273340-0       Ready,SchedulingDisabled   3m        v1.8.0-alpha.2.85+531664519485fd-dirty

There is one small quirk that make this less than 100% ideal and would keep us from using MSI immediately:

An MSI-powered cluster is mutually exclusive with automatic ACR integration. As far as I can tell, ACR doesn't offer a way to authenticate via access tokens, only static credentials, so it's sort of fundamentally incompatible with MSI for the time being. As a result, it's also hard to test Windows given that it doesn't use the cloudprovider integration and we can't test with ACR. But I've made the necessary changes such that it should work.

That having been said, I'd strongly prefer if we can review and merge this. I've spent a pretty serious amount of time rebasing this over the past 6.5 months. It'd be great to get it in, get a soak test going, etc.

Note: The PR is only failing because it runs in a different sub with a different SP than I was testing with. And I don't have access to the subscription, so I can't do anything about this. Hopefully @dmitsh  or someone else with access to that subscription can either add me or the relevant SP Application ID to unblock this. In the meantime, here's a build with the same git hash that is live now (<jenkins_url>/job/colemick-jobs/job/colemick-acs-engine-msi2/29/)

@acs-bot test this please

For scaling down, do we need to remove principalIDs from role assignment?

Reviewed 1 of 32 files at r2, 16 of 51 files at r3, 4 of 4 files at r4, 4 of 4 files at r5, 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

examples/managed-identity/kubernetes-msi.json, line 46 at r6 (raw file):

    "servicePrincipalProfile": {
      "servicePrincipalClientID": "",
      "servicePrincipalClientSecret": ""

do we still need spn secret with msi enabled?

parts/kubernetesagentresourcesvmas.t, line 133 at r6 (raw file):

      "location": "[variables('location')]",
      "name": "[concat(variables('{{.Name}}VMNamePrefix'), copyIndex(variables('{{.Name}}Offset')))]",
      {{if UseManagedIdentity}}

should we enable msi on agent pool separately?

Comments from Reviewable

thanks for clarifying offlien. LGTM

Review status: 23 of 24 files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

examples/managed-identity/kubernetes-msi.json, line 46 at r6 (raw file):
Previously, weinong (Weinong Wang) wrote…
do we still need spn secret with msi enabled?

It becomes optional. For now, it happens to still be usable in that the ACR integration will keep working, even in some scenario where user activates MSI and still supplies creds.
I've chosen not to omit it because of the refactoring changes required that I mentioned in reply to Jingtao.

examples/managed-identity/kubernetes-msi.json, line 46 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
This is an example apimodel that activates MSI. I don't want to remove the SPP yet. It will require refactoring the validation code to be aware of what mode it's running in, plus this section will likely still be used for either ACR scenario or for AAD-kubectl scenarios.

Done.

examples/managed-identity/kubernetes-msi.json.env, line 4 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
sure, I'll add a couple

Done.

parts/kubernetesagentresourcesvmas.t, line 133 at r6 (raw file):
Previously, weinong (Weinong Wang) wrote…
should we enable msi on agent pool separately?

IMO, no. The ServicePrincipalProfile applies uniformly today, this seems consistent.

parts/kubernetesagentresourcesvmas.t, line 205 at r6 (raw file):
Previously, seanknox (Sean Knox) wrote…
 Is it at all possible to extract this into another file? Looking for opportunities to make all the parts (literally and figuratively) a bit more visible.

I'm not sure actually. I don't know if go tmpl has a generic include function or if we use it anywhere. I'd selfishly say I'd prefer to punt on it given my lack of immediate knowledge.

parts/kubernetesmaster-kube-apiserver.yaml, line 51 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…

It's used for SSH key propagation (it's a GKE thing I think). apiserver also parses the config file and passes it to admission controllers so they can use it. (Not sure of any that do).
We don't use SSH key stuff and we don't use any admission controllers that need to talk to ARM so it didn't hit on this.

Still, will fix, of course.

Done.

examples/managed-identity/kubernetes.json, line 7 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
@shrutir25  I think it's going to stay here a while longer. There's no need to rush it and I have a better solution than the hack/ stuff with the Azure function coming in ~3 weeks via ARM templates.

Done.

hack/rbacgenerator/function.js, line 1 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Hm, maybe, sure. I'm open to suggestions. It's not totally unprecedented, kubernetes has a hack/ dir for temp/dev type things.

This no longer applies since I've removed hack/ and everything in lieu of guid().

hack/rbacgenerator/raw.js, line 1 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
No idea why it's called that. It's package.json in reality. Will rename. Thanks.

No longer applies. It's all been removed.

Comments from Reviewable

Review status: 14 of 24 files reviewed at latest revision, 9 unresolved discussions.

examples/managed-identity/kubernetes-msi.json, line 46 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
It becomes optional. For now, it happens to still be usable in that the ACR integration will keep working, even in some scenario where user activates MSI and still supplies creds.
I've chosen not to omit it because of the refactoring changes required that I mentioned in reply to Jingtao.

Done.

examples/managed-identity/kubernetes-msi.json, line 46 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Done.

Done.

examples/managed-identity/kubernetes-msi.json.env, line 4 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Done.

Done.

parts/kubernetesagentresourcesvmas.t, line 133 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
IMO, no. The ServicePrincipalProfile applies uniformly today, this seems consistent.

Done.

parts/kubernetesagentresourcesvmas.t, line 205 at r6 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Dunno why this showed in Reviewable for me to comment on but didn't post back here. Anyway, what I wrote:

I'm not sure actually. I don't know if go tmpl has a generic include function or if we use it anywhere. I'd selfishly say I'd prefer to punt on it given my lack of immediate knowledge.

Done.

parts/kubernetesmaster-kube-apiserver.yaml, line 51 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Done.

Done.

examples/managed-identity/kubernetes.json, line 7 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
Done.

Done.

hack/rbacgenerator/function.js, line 1 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
This no longer applies since I've removed hack/ and everything in lieu of guid().

Done.

hack/rbacgenerator/raw.js, line 1 at r2 (raw file):
Previously, colemickens (Cole Mickens) wrote…
No longer applies. It's all been removed.

Done.

Comments from Reviewable

Any documentation for that? Also, is there support for containers authorization? e.g. granting access only to specific container to a given KeyVault?


[QE][SPOG] On SBOM detail information page Qualifier column is not visible under Packages tab

When the package versions loaded with sha256 value, sha values of different arch loaded without delimiters which causes all the sha256 values concatenated. Due to this, Qualifier column is not visible.
Tested versions - v0.1.0-nightly.2f825aca-dirty
Expected Result:
Expecting fixed column width and sha256 values loaded with delimiters
All columns to be visible on Packages tab

@carlosthe19916 I think it makes sense going back to fixed with columns. This would also prevent columns from jumping when paging.


Sensor "Allow open" option should not be disabled when "Immediate" option is on

Today you can enable the "Allow open" sensor option only if you first disable the "Immediate" option. This should not be the case IMHO.
I have a corridor with motion sensor which is leading me to my entry area. If I walk out fast it could be that I will fail to arm the alarm as the sensor is still active. The way to allow me to ignore it is to set the "Allow open" option (which is I love) but then I have the side effect that I also need to mark it not immediate which is not accurate. I want the alarm to trigger immediately if someone get to the hallway without first disabling the alarm.
So, I think these 2 options should get separated and allow me to set "Allow open" to sensors even if I do want them to trigger the alert immediately if they turn on later.

Lucky for you I have no intentions of being a dictator 🙂
I just thought the combination would be contradictive, but I get your point.
Will revert it in a next release.

Lucky me :). Thanks. You are doing excellent work with this project. I wonder how you can get it to replace the really broken built in manual alarm.

Glad you like it.

I wonder how you can get it to replace the really broken built in manual alarm.

What do you mean with this?
You mean the BWalarm that’s broken?

BWalarm is somehow ok. Main problem with that that it forked too many times as the original maintainer left it.
But what I referred as really broken is: https://www.home-assistant.io/integrations/manual/

I just released v1.3.0 which should remove this limitation.


Add Monero

Monero is a private, secure, untraceable, decentralised cryptocurrency.

The bin property only requires multidimensional arrays when you want to rename files (like start-low-graphics-mode.bat) or add parameters.
If you use checkver.github then you can omit the /releases/latest part at the end.
Hash extraction provides the filename via the $basename variable.
See: https://github.com/lukesampson/scoop/wiki/App-Manifest-Autoupdate


Builder is failing when using just local builder

mrsk always failing if builder has just one local architecture. The issue was introduced with v0.14.0, downgrading to v0.13.2 helps.
Identical ticket was opened and closed instantly for some reason :)
I'm running M1 and cross-compiling to amd64
Error:
ERROR (ArgumentError): You must specify both local and remote builder config for remote multiarch builds
builder part of the config.
builder:
  local:
    arch: amd64

Hey @cleanbit, I switched to remote option as it was much faster to build the image.
In addition to that the server network speed is up to 1gb and was much faster to upload to the registry.

I think this regression was introduced in https://github.com/mrsked/mrsk/pull/337 - cc @igor-alexandrov.

Yes, it is my fault. Will prepare a fix ASAP.


Cython line profiling does not work on the last function defined

I haven't explored all the possible ways this could fail yet, but I'm finding that line_profiler fails when used on the last cpdef that I define. For a minimal working example:
setup.py:
from distutils.extension import Extension
from distutils.core import setup
from Cython.Build import cythonize

setup(
    ext_modules = cythonize([Extension("demo", ["demo.pyx"],
                             define_macros=[('CYTHON_TRACE', '1')])])
)

test_profile.py:
import line_profiler

from demo import cp_func
profile = line_profiler.LineProfiler(cp_func)
profile.runcall(cp_func, 20)
profile.print_stats()

demo.pyx:
# cython: linetrace=True
cimport cython

@cython.binding(True)
cpdef cp_func(n):
    n = n + 1
    return n

def d_func(n):
    n = n + 1
    return n

With this configuration:
$ python3 setup.py bdist_ext --inplace > /dev/null
$ python3 test_profile
Timer unit: 1e-06 s

Total time: 2e-06 s
File: demo.pyx
Function: cp_func at line 5

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
     5                                           cpdef cp_func(n):
     6         1            1      1.0     50.0      n = n + 1
     7         1            1      1.0     50.0      return n
     8
     9                                           def d_func(n):
    10                                               n = n + 1
    11                                               return n

So far so good. But now if I go into demo.pyx and remove d_func (which should theoretically have no bearing on how the profiling works, AFAIK), here's what I get:
$ python3 setup.py bdist_ext --inplace > /dev/null
$ python3 test_profile
Timer unit: 1e-06 s

Total time: 2e-06 s
File: demo.pyx
Function: cp_func at line 5

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
     5                                           cpdef cp_func(n):

All the line information is gone! I've tested this with Python 3.6 on Arch Linux and Ubuntu 16. Cython versions 0.27.2 and 0.25.2, respectively.

If one looks closely at the output of the test_profile.py for the collatz tests you would see something odd that I see in your output here, too:
bash-4.2$ python test_profile.py
Timer unit: 1e-06 s

Total time: 1.6e-05 s
File: /home/broot/Programs/tools/foobar/collatz.pyx
Function: collatz at line 6

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
     6                                           def collatz(n):
     7         1            2      2.0     12.5      while n > 1:
     8        20            6      0.3     37.5          if n % 2 == 0:
     9        14            5      0.4     31.2              n //= 2
    10                                                   else:
    11         6            3      0.5     18.8              n = 3*n+1

Timer unit: 1e-06 s

Total time: 9e-06 s
File: /home/broot/Programs/tools/foobar/collatz.pyx
Function: cp_collatz at line 15

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    15                                           cpdef cp_collatz(n):
    16         1            1      1.0     11.1      while n > 1:
    17        20            6      0.3     66.7          if n % 2 == 0:
    18        14            2      0.1     22.2              n //= 2
    19                                                   else:
    20         6            0      0.0      0.0              n = 3*n+1
    21
    22
    23                                           @cython.binding(True)
    24                                           class PyClass(object):
    25                                               def py_pymethod(self):
    26                                                   x = 1
    27                                                   for i in range(10):
    28                                                       a = x + 2
    29                                                   return a * 3

Timer unit: 1e-06 s

Total time: 4e-06 s
File: /home/broot/Programs/tools/foobar/collatz.pyx
Function: py_pymethod at line 25

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    25                                               def py_pymethod(self):
    26         1            1      1.0     25.0          x = 1
    27         1            0      0.0      0.0          for i in range(10):
    28        10            2      0.2     50.0              a = x + 2
    29         1            1      1.0     25.0          return a * 3

<snip>

For the output for the cpdef cp_collatz, you also see the lines for the next def, PyClass.py_pymethod, but, in this particular case, the stats for py_pymethod does show up in the subsequent profile stat output. Don't know if it is related to the problem here... like a symptom of a deeper problem or not.

@scoder, any thoughts on this one?

Definitely a bug, probably in Cython.Coverage.

This SO answer seems relevant.

Based on this SO answer, it seems this has something to do with how inspect.getblock works on cpdefd functions. There's another example in issue ( https://github.com/pyutils/line_profiler/issues/13 ).

Thanks for investigating. We could try to improve this in CPython, but it doesn't seem the best place to do it. Why should inspect support Cython specific source code?
I don't really see what we could change in Cython to get this to work, so fixing this in line_profiler seems most appropriate.


[Bug] Bound input widgets don't update their value if edited, when the resulting value has not changed

This issue is best demonstrated with a video:
https://user-images.githubusercontent.com/120119/110352149-92e82a00-805b-11eb-9c42-b4d89e07e898.mov
In words,

Drop a table and an input widget.
Bind the input widget's default value to {{Table1.selectedRow.email}} (assuming email is a valid column in the table, and at least two rows have the same value for email.
Now select a row with the duplicated email.
Edit the text inside the input widget.
Now select a row with a different email. Notice that the email is updated in the input widget.
Now select the email from point 3 again.
Edit the text inside the input widget, like point 4 again.
Now select a row with the same email. Notice that the email is not updated in the input widget.

The inconsistency in behavior in points 5 and 8 is unexpected.

@hetunandu looks like we regressed on this. Can we please add a test case on this

hi @Nikhil-Nandagopal is there any update to this? It does make the user confused when the previous value still exist after selecting new row 😕

Hey @ashrafaa, this seems to be an odd case. I'll debug this further and get a good solution. Today we seem to be doing the overwrite of default values by value comparison but maybe we should change that looking at this issue. Ill pick this up on priority

Hey @ashrafaa, we have fixed this issue and it should be included in the next release 😄

Nice one @hetunandu 👍  I'm looking forward for the release 😄

@hetunandu has this fix been included in release 1.4.5?

Hey @ashrafaa, yes, it is included in the release. Is it not working for you?

ok cool I have not yet updated to latest; just reviewed the release note and could not find reference to this ticket. Thanks @hetunandu

Oops. Sorry, it looks like we missed out on mentioning this issue. Your on-prem installation must have auto-updated. Can you confirm if it is working for you?


Add template for dnsmasq settings

Switches the static dnsmasq file for a dynamic template.
Added some extra variables for managing te settings in the template.

Looks good, thanks!


Extracted table is returning contents for empty cells

Hi,
I am having an issue where in if i have a row having only the first column(cell) populated but all the remaining columns of the same row are empty, the first col cell's value is being returned for all the empty cells as well. Here is my code -
ocr = EasyOCR(lang=["en"])
img = Image2(src=img_path)
tables = img.extract_tables(ocr=ocr, implicit_rows=True)
table=tables.pop()
table.df

Is it possible to not have this behaviour? I want the empty cells to return empty(no) value.
I have attached both the source image and output screenshot.

Thank you for this useful library!

Hello,
This is most likely because the vertical lines in the second row failed to be detected.
Are you able to provide the original document so that I can take a look at what is going wrong ?

Hi @xavctn ,
Sure.
Here it is.
source.pdf
Thanks for having a look!

Hello,
I have created a new release that fixes the issue, it should be good now.
Xavier


Incorrect link in About window

In the "Help -> About SuperPutty" incorrectly refers to the repository. It must be github, and is google.code.

Thanks for the report, I've already made the change and it will be included in the next commit I make.


Using --number with lines greater than 3 does not change context

Using --number with lines less than 3 will correctly trim output. For example:
bandit -r --number 1 glances/glances/

Issue: Try, Except, Pass detected.
Severity: Low   Confidence: High
Location: glances/glances/plugins/glances_sensors.py:26
26	except ImportError:

Issue: Try, Except, Pass detected.
Severity: Low   Confidence: High
Location: glances/glances/plugins/glances_uptime.py:76
76	            except Exception:

However, using --number greater than 3 does not adjust the output. It still uses only 3 lines maximum.
bandit -r --number 10  glances/glances/

Issue: Try, Except, Pass detected.
Severity: Low   Confidence: High
Location: glances/glances/plugins/glances_uptime.py:76
75	                self.stats = str(timedelta(seconds=int(uptime) / 100))
76	            except Exception:
77	                pass

Launchpad bug to Github issue import error


fix privileged mode

Hi,
i would like to install docker ui on my minions, but i could not run the pods with your setup. The allow_privileged flag must be set on the api-server as well.
Regards
Bernd

Nice catch @zutherb, thank you :+1:


Fix Postgresql migration script for non-admin users

The original file was dumped from a Postgres install on a developer machine (mine) that was created with a user having admin rights. This resulted in some statements being included that require admin capabilities to execute. This would fail for uses running on shared posgresql instances as non-admin users. We've known about this but avoided fixing it for fear of breaking existing users who had already installed and had flyway_schema_history tables with values.
At this point this is affecting more users than not so fixing it has value going forward.
For users that have already installed there are two options:

Set spring.flyway.baseline-version=3.3.0 which will cause the system to skip evaluating the initial migration state
Update flyway schema history to have the new correct checksum: update flyway_schema_history set checksum = -1400680873 where installed_rank = 1;

Both of these options have been tested and work.
This should unblock new users from adopting Genie with non-admin installs of postgres.
New migration script tested against non-admin user on Postgres 12.
Should fix #767

Coverage decreased (-0.007%) to 92.845% when pulling 7ca2d84638f5a55e7f8e77605a11a19c0ec930d0 on tgianos:767 into 5f61bf23293c68005c8797a3c251dca23f0b5bab on Netflix:master.


Update APIBinding documentation

The process to bind to an APIExport now requires the right RBAC to be
granted to the user(s).
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

@bnallapeta Please have a look and merge if you're OK with the changes.

In my opinion when we create the workspace for the registration of the workload clusters we should create the clusterrole and clusterrolebinding you have documented here. In the documentation (should also be in the operational manual) we should instruct users how they can use kustomize and overlays to restrict access to the workload clusters to a smaller group than system:authenticated

I agree that it would make the UX better. However, I'm a bit wary about having the default security setting be "opened to all".

I agree that it would make the UX better. However, I'm a bit wary about having the default security setting be "opened to all".

Obfuscation is usually not seen as security.
Moreover this gives the opportunity to get feedback on how security can get improved, which is not possible when things are hidden.

@Roming22

There's a conflict currently.
I don't remember seeing so many files earlier. Is there another commit here by mistake?

@bnallapeta

Fixed
Originally, I was just updating the docs. Frederic suggested automating the process. This required some changes to make it customizable. I've updated the commit message accordingly.

@bnallapeta I've processed your latest comment, let me know if that's not what you were expecting to see.

@fgiloux @bnallapeta Is there anything holding the merge of this PR?

Is there anything holding the merge of this PR?

@Roming22, we would have quicker iterations if we keep the PR scope focused on 1 thing.
As a result I have changed the title of the PR. Feel free to amend if you think that it could be better described.


add version field to composer.json

Kirby 3.8 uses the "version" field in composer.json to check whether installed plugins are up-to-date, so it would be great if kirby-fingerprint could increment it alongside the git tags.
https://getkirby.com/releases/3.8/migration-plugins#add-compatibility-with-the-update-check

Sorry, I'm not the best composer user...
Should be fixed in 2.2.5

That was fast! Thanks! 😊


Error trying to install

Release Type: Official Release/GitHub (please choose appropriate option)
Release
Version: Version number and/or git branch
<IP_ADDRESS>
Platform(s): Does the problem occur on Windows, Android...?
Windows 10, 64
Describe the bug
A clear and concise description of what the bug is.
Cannot install Stride, aparently because of the Visual Studio extension
To Reproduce
Steps to reproduce the behavior:

Standard installation

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (use GitHub drag & drop)
Log and callstacks
If any, please attach here any log or callstack (preferably in a .txt file using GitHub drag and drop)
log1.txt
Additional context
Add any other context about the problem here.

Duplicate of #653


Maximized window is always resized (restored) when calling set_focus()

Reported on StackOverflow

vasily-v-ryabov,
Found the root cause or fixed it already?
Thanks!
Clock ZHONG

Hi @clockzhong
It's already fixed in my fork, only left to write regression test and to merge into master branch. Planning to release 0.6.2 with recent fixes till March, 1.

Cool!!!!


Fix some interaction issues

Fixes #3844 - memory leak on touch end.
Fixes another component of #3790, #3851 - tracking that an interactive child was hit was forgotten more than one level up.
Adds unit tests for both of these fixes.

Great work @andrewstart! Thanks for tackling these interaction bugs.

I think its wrong to pass this kind of thing through processInteractive. Can we make an array of all things that were hit and then calculate which one was actually hit?

I understand how algorithm works but I'm afraid that it became to complicated to be changed in future. We'll have to rewrite it at some point. I approved to move things forward.

I think this one is very important and we should do a release asap 👍


Bump framework version

Note $subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/759006884

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/759006884
Status: success


Feature/grafana node tolerations

/cc @zanhsieh

/ok-to-test

LGTM.

Please bump the chart version.

Done!

/retest


Custom keybindings not reflected in macOS menu bar

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it

Add a custom key binding
See that the menu bar entry shortcut has not changed to reflect the custom key binding.

Notes:

This is probably true for context menus too.

Environment
M1 Pro, 32GB RAM, Zed 0.77.3
If applicable, add mockups / screenshots to help explain present your vision of the feature

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

That should be fixed in Zed 0.96


javax replaced with jakarta

javax.ws.rs was moved to jakarta.ws.rs therefore replaced javax dependency with latest jakarta version

Many thanks for providing this PR. However, it seems like only updating the dependency is not enough. Can you double-check what exactly is going wrong?

CI looks good now! Just one small remark, the changeset includes a lot of changes on the pom.xml file. However, most of it looks like changes by an auto-formatter. Would it be possible to update the pom so that only the relevant changes are contained?

Unfortunately, I have to revert this change as well as the change to basyx-java-components due to issues of BaSyx users with the change. In combination with Spring, the change from javax to jakarta is creating manual migration efforts from them, thus being a breaking change.


Add version: Codemao.TurtleEditor.1 version 1.4.1

Pull request has been created with komac v2.8.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

=== manifests\c\Codemao\TurtleEditor\1\1.4.1 === Missing Properties value based on version 1.8.2: Icons

This entry was not in the previous manifest.


Adaptive.Teams package doesn't contain uischema

This package doesn't seem to contain any uischema to organize the actions / triggers it adds, so they are getting dropped into the default "Custom Actions" / "Action Triggers" sections.
I think we have two options:

Single "Teams" menu
Break it down to

Teams - Get Info
Teams - Messages
Messaging Extension
Task Modules & Tabs

Less is more so personally I'd create a "Microsoft Teams" menu that contains everything teams... If anything, add sub menus under the "Microsoft Teams" menu.

If submenus are possible, combing the above into:

Microsoft Teams

Send messages
Messaging Extensions
Task Modules & Tabs
Get Teams Info


Added furniture page

Fixes #11
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Deploy your changes to github page or netlify and mention deployment link:
Add the deployment link here.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[ ] I have mentioned related issue number in PR description.
[ ] I have added screenshots and related demo links of my changes..
[ ] The title of my pull request is a short description of the requested changes.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

https://tjanhvi.github.io/Apni-Dukaan/

Still the same @tjanhvi.
The same mistakes, you have not made the suggested corrections.
But since the event is ending within an hour I am accepting this PR.

Fill the google form.

Fill the google form.
Fill it ASAP it might be closed soon.

where is the form

Are you part of DCP?


Joins in queries are not respecting a schema's prefix, fix listed

Precheck
As troubleshot here:  https://elixirforum.com/t/ecto-cross-schema-join/3611/4
Environment

Elixir version (elixir -v):
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.):
Ecto version (mix deps):
Database adapter and version (mix deps):
Operating system:

$ elixir -v
Erlang/OTP 19 [erts-8.2] [64-bit] [smp:8:8] [async-threads:10]

Elixir 1.4.0

$ psql --version
PostgreSQL 9.5.3, compiled by Visual C++ build 1800, 64-bit

$ mix deps | grep ' ecto '
* ecto 2.1.3 (Hex package) (mix)

$ mix deps | grep ' postgrex '
* postgrex 0.13.0 (Hex package) (mix)

$ uname -a
MINGW64_NT-10.0 <User> 2.5.0(0.295/5/3) 2016-03-31 18:47 x86_64 Msys

Current behavior
Right now if you have, say, two tables, that have two different @schema_prefix "blah" set, they are not honored in the PostgreSQL system (unsure about others) because of the create_names/4 function at:
https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/adapters/postgres/connection.ex#L570-L572
          {table, schema} ->
            name = [String.first(table) | Integer.to_string(pos)]
            {quote_table(prefix, table), name, schema}

Specifically that case branch is entirely ignoring the schema's @schema_prefix and using the global one, regardless of how entirely wrong it may be considering it is set to the value of the one in the first schema.
Expected behavior
For joins to not get their prefix corrupted and to actually work so the PostgreSQL connection does not throw an error back.
Simple fix
A simple fix that works in my quite large codebase is to just add a single line at the start of that case branch, to make the above code become this:
          {table, schema} ->
            prefix = schema.__schema__(:prefix)
            name = [String.first(table) | Integer.to_string(pos)]
            {quote_table(prefix, table), name, schema}

However, this breaks the ability to override the prefix globally, which honestly I prefer, however a more proper fix (and why this is not a PR when I already have the code ready, though I can PR this if you prefer...) would be to eradicate the :prefix option for Repo.all and its kin and instead come up with some way to override the prefix on a per-schema basis, of which two methods come immediately to mind.
Assuming you have a schema called Post and one called Author and each have a different @schema_prefix set, and if you have this query:
query = from p in Post,
  join: a in Author, on: p.author_id = a.id

Method 1
I prefer this best.
You could override it like this:
query = from p in Post,
  join: a in {"newprefix", Author}, on: p.author_id = a.id

Or some variation of 'tagging' the module some-how.
Method 2
You could override it by passing a list of schema's to the action:
Repo.all(query, prefix: [Author: "newprefix", Post: "yetanotherprefix"])

This gives the ability to override it at the call site instead of the generation site, however it would not allow you to, for example, have 2 Post schema's in the same query in two different prefix's (not a case I've ever needed but it is supported by SQL and I've seen the occasional odd system do it).
Note
Either method could still be used with a :prefix key option on the action that could override them 'all' if that is really really wanted for whatever reason, but regardless, the default should be to obey the settings of the schema itself.

The prefix feature is meant primarily as a way to support multi-tenancy in ecto, and thus providing isolation between different prefixes is highly desired. It is fully intentional that a prefix is global for a query.
Changing how prefixes work, especially the fact that a prefix of the primary source of the query is considered a prefix for the whole query is definitely not a backwards compatible change and would need to be scheduled for Ecto 3.0 if we decide to go with that.
The {"source", Schema} notation is not appropriate for specifying prefix, as it's already used in other places for specifying an alternative database source (table) name for the schema.
Extending the prefix option to be more extensible (by accepting a map) might be an acceptable solution, but a good API needs to be designed.

Yeah I was not sure about a replacement API, hence why there is no PR as of yet, but the simple fix is enough if anyone else needs to join across schemas so that alone may be useful of an immediate use for people in the future until the issue is resolved.  :-)
If curious about my use-case:
We have PostgreSQL with the different applications in different schema's, however we are making a server that can access all the data via a web interface, and to prevent duplication of data we are joining across schemas, which works fine with no issue, just it is impossible to do in Ecto's queries it seems because of this issue, thankfully it was a simple work-around since we do not ever override schema's, they are set-in-stone so to say.

The simple fix you provided is not backwards compatible, so unfortunately, however I may feel about it, it's not acceptable currently.
If you have tables in different schemas, but they don't change: an acceptable solution might be to set a proper search_path, which would allow you accessing tables from different schemas in the cross-schema application.

Changing how prefixes work, especially the fact that a prefix of the primary source of the query is considered a prefix for the whole query is definitely not a backwards compatible change and would need to be scheduled for Ecto 3.0 if we decide to go with that.

It could be if an option was given to specify that on the Repo or so via the original use Ecto.Repo, otp_app: :my_server, say, something like use Ecto.Repo, otp_app: :my_server, multi_prefix: true or so.  That would then be backwards compatible.
My main curiosity, it makes sense for the :prefix key on something like Repo.all to override the default nil prefix on a schema, but is there ever a reason for it to override a @schema_prefix that is not nil because if a schema has a prefix set like that then it should be well known that it only works in that context.  Perhaps that might be a better change?

The simple fix you provided is not backwards compatible, so unfortunately, however I may feel about it, it's not acceptable currently.

Oh it absolute is not and should not be taken as stated in the first message.  ^.^
A proper API should be developed for sure.

If you have tables in different schemas, but they don't change: an acceptable solution might be to set a proper search_path, which would allow you accessing tables from different schemas in the cross-schema application.

If I could I would, but I do not have the access to do that, big government managed databases take years to make changes especially with FERPA and HIPAA requirements both in the mix...  >.>

My main curiosity, it makes sense for the :prefix key on something like Repo.all to override the default nil prefix on a schema, but is there ever a reason for it to override a @schema_prefix that is not nil because if a schema has a prefix set like that then it should be well known that it only works in that context.

The rule with prefixes is that it goes from generic to localized:
global > schema > :prefix option

It would be inconsistent to not allow the developer to override at the callsite something that has been set in a module.

Extending the prefix option to be more extensible (by accepting a map) might be an acceptable solution, but a good API needs to be designed.

Yes, that's likely the best way to go. Until then, you have to run separate queries or raw SQL, since cross-prefix queries are forbidden pretty much by design.

It would be inconsistent to not allow the developer to override at the callsite something that has been set in a module.

Very true, but that is not what is happening here.  I am not specifying a :prefix key on the all call and yet the joins are still being overridden by the 'first listed' schema's prefix, whatever the first may be.  For example, swapping the aboves:
Repo.all(from(p in Post,
  join: a in Author, on: p.author_id = a.id))

To become:
Repo.all(from(a in Author,
  join: p in Post, on: p.author_id = a.id))

Also swaps the prefix's used, which is entirely an unexpected outcome.  However I would expect:
Repo.all(from(a in Author,
  join: p in Post, on: p.author_id = a.id), prefix: "blah")

To override both regardless.

Yes, that's likely the best way to go. Until then, you have to run separate queries or raw SQL, since cross-prefix queries are forbidden pretty much by design.

What was the reasoning behind this design as I've not found it documented anywhere yet?  It makes entirely valid (and often used, at least both at my current job and at my last job in two entirely different sectors, one government, the other 'big business') queries categorically impossible.

What was the reasoning behind this design as I've not found it documented anywhere yet?

It was the use case we designed the feature for. We would need to extend the feature to support other use cases.

It was the use case we designed the feature for. We would need to extend the feature to support other use cases.

Ah, so just a case of 'Its not been needed yet'.  :-)

I am still curious, if a :prefix key is not defined, why do the join prefix's get ignored though?  That still seems like a major and surprising bug...

Because in multi-tenancy you don't want to perform queries across tenants. It is a documented behaviour and not a bug (albeit I agree 100% it is a limitation).

I'm curious, would anyone really do multi-tenancy with Postgres Schemas instead of via Postgres Users?  That seems... exceptionally odd and highly unsafe as it could potentially give one tenant view over all tenant's potentially private information if they found any kind of exploit.

Just to weigh in on this, I'm currently also working on an application where I will need to be able to query across schemas. My use case is a multi-tenant CMS of sorts, however the separation of data is not at tenant boundaries, but rather at site boundaries. One organization may own many sites, and conversely multiple organizations/users within them could have permissions to access/edit a single site. A single user may also belong to multiple organizations.
Therefore my organizations, users, and other similar concerns are in the public schema while each separate site has a schema of its own (as the common case is end-users viewing sites, which greatly benefits from this).
As regards this feature—this is perhaps not as clean, but here are another two ideas for this syntax:
Option 3
query = from p in Post,
  join: a in {Author, prefix: "newprefix"}, on: p.author_id = a.id

I can immediately see the potential disadvantage here, though I'm not familiar enough with the performance of Erlang guards to evaluate how bad it would be: namely, in the logic which currently may accept a 2-tuple for the use-case already mentioned, one would have to check if the second element is a keyword list or not.
###Option 4
query = from p in Post,
  join: a in {:prefixed, "newprefix", Author}, on: p.author_id = a.id

This might be a clean solution as it would be very easy to pattern-match on, and though it is lengthy, as noted this is a rare-enough use case that I think it would be ok. The Author in the example could then be another tuple in the case where we are pulling from another table (the current use for tuples as data sources).
I'd be happy to work on a proposal/PR for this if it seems reasonable.

Can always have a prefix call as well, kind of like:
query = from p in Post,
  join: a in prefix("newprefix", Author), on: p.author_id = a.id

As that would fit the style of the rest of the query helpers as well.
As long the default is for the @schema_prefix "blah" not to be ignored (unless a prefix: key is set on the repo function, which should rightly override it) that would be best.  :-)

Out of all the proposals here, I like the additional prefix/2 syntax the most appealing (I was actually intending to propose something similar).
The only issue is that the right side of in in from p in Post is evaluated outside of the query syntax context, so it wouldn't be possible to do from p in prefixed("prefix", Post). That's the same issue we're facing with using fragment as the main query source.

@OvermindDL1 unfortunately changing how @schema_prefix works is not an option until Ecto 3.0

Hmm, you have any other work-around for this?  I have no control over the schema layout in this database and I really do not fancy messing with raw SQL (much as I know it, it is still not safe).

@michalmuskala we could probably introduce a helper prefix/2 macro which would expand to the syntax in my Option 4.

Please revisit this, I've faced this issue when trying to migrate and old rails app to phoenix.


Add holmescc

added Holmes Community College

@guri073 I am sorry, the domain holmescc.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


small typo in README.md file

@watz0n There are some few minor typos in the README.md file. Do you want me to correct them?

Hi @Arna-Maity , thanks your review. Welcome to correct these typos, because I'm not native speaker and still learning how to express in English.

Hi @watz0n, i have made the necessary changes and opened a PR. Could you please review it?

Hi Arna,
I have urgent task from current employer, I may review it in this weekend.
Sorry about my late reply, and thank you for your help.
Many thanks,
Watson
On Wed, Nov 27, 2019 at 7:53 PM Arna Maity<EMAIL_ADDRESS>wrote:

Hi @watz0n https://github.com/watz0n, i have made the necessary changes
and opened a PR. Could you please review it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/watz0n/learn-rv32i-asap/issues/1?email_source=notifications&email_token=AFALTHR5IKOLBTOIHEHITJDQVZNVHA5CNFSM4FLJVBWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJIM2I#issuecomment-559056489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFALTHQAATAUY5IAITDT3ITQVZNVHANCNFSM4FLJVBWA
.

Closing this issue


Replace to arkana to save APIKey

https://github.com/rogerluan/arkana

arkane is simple Code Generator Project that is written in Ruby.
I decided to create arkane written in Swift(Swift Package Manager)


asserts with pytest.raises should be outside the with block

I've been using Flask's test suite to evaluate our Slipcover coverage tool and noticed likely bugs in the Flask tests.  For example, in tests/test_basic.py, you have
def test_response_type_errors():
    [...]

    with pytest.raises(TypeError) as e:
        c.get("/none")
        assert "returned None" in str(e.value)
        assert "from_none" in str(e.value)

    with pytest.raises(TypeError) as e:
        c.get("/small_tuple")
        assert "tuple must have the form" in str(e.value)

    [...]

    with pytest.raises(TypeError) as e:
        c.get("/bad_type")
        assert "it was a bool" in str(e.value)

You probably don't want the assert statements checking e indented, as they won't execute when the exception is thrown.

seems like https://github.com/pallets/flask/commit/b05a685a03a2a186cd7ffb45a6cb8a7a4fbc49de introduced a lot of these

Always happy to review PRs to improve tests.

Just give an idea. Note part of pytest-raises mentioned this hazard.

Always happy to review PRs to improve tests.


Add #[data(eq)] shorthand attribute for Data derive macro

In my opinion it'd be common to use PartialEq::eq as a shorthand implementation of Data::same.  Currently we can already easily derive it with #[data(same_fn="PartialEq::Eq")], but it may be more user-friendly if it provides with some shorthand attribute like #[data(eq)].  Do you think it's a good idea?

I like this idea!

Thank you for implementing it!  @Maan2003 @cmyr


Garbage Collect IngestAPI queues

Implements the ingest API queue garbage collector
How was this PR tested?

unittest

Closes https://github.com/quickwit-oss/quickwit/issues/1229

@fmassot @fulmicoton  Another thing is RocksDB has a default queue that cannot be deleted. if an index is named default, the queue will be there all the time. we should guard against this.

As discussed, a restart is always needed on deletion with the CLI with the file-backed metastore.
To avoid the clash with the default queue, I would always use queue_{index-id} as the name of the queue, but I really don't know if it can cause some issues. If it's too risky, we can just forbid the index name default for the 0.3 and remove that constraint later.

I think it's safe to internally prefix our queues so I went with .queue_{index_id}


Integrating Contentful CMS to SML Portal Web App

I have successfully integrated Contentful headless CMS into the SML Portal Web App.
Users will be able to add, delete & edit content for the following pages:

Home page
Methods Catalogue page
Methods table within method catalogue page
Individual method pages
About page

This is a demo branch, to show how this CMS system works.

Regenerated SPACE_ID & Content Delivery API (CDA) Keys, and put them in environment variables. Data that can be retrieved using the keys is fake/ test data.


ATB

Description
Initial pull request for dev-audit, containing the implementation of the AionTokenBridge contract. As it stands this PR does not yet have the changes suggested by the Audits. I will update this as the situation changes.
This PR does include:

Initial implementation for ATB (6-1)
Williams ATB tests

Type of change
Insert x into the following checkboxes to confirm (eg. [x]):

[ ] Bug fix.
[x] New feature.
[x] Enhancement.
[x] Unit test.
[x] Breaking change (a fix or feature that causes existing functionality to not work as expected).
[x] Requires documentation update.

Testing
Testing was done by implementer (myself), it was also done by William and two external parties we engaged for audits.

@AlexandraRoatis hey Alex, included you because you would be a fresh pair of eyes on this. Let me know if you're too busy to review.

I added boundary checking inside parseMeta, where we were hitting out of bounds problems, and removed the now unnecessary check before entering this block here -> 19436dd


Pressing the enter key

Hey there,
I've been wondering how you are supposed to use the enter key. It seemingly has no key name, and I can't press keycodes it seems.
How do you do this?
Thanks!

Try return
$ wtype "echo -e \"foo" -P return "bar\"" -P return
$ echo -e "foo
bar"
foo
bar

oooh thank you so much, that works perfectly!
I feel like Return is quite a dated name for the Enter key but whatever


The discord link is not working.

Wish to have more communication with you. I like your open-source work

fixed
On Mon, Sep 4, 2023 at 5:42 AM 冯涌 @.***> wrote:

Wish to have more communication with you. I like your open-source work
—
Reply to this email directly, view it on GitHub
https://github.com/mluogh/eastworld/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5ZC2Z2AKLVCNTCVA3WVWDXYXEDVANCNFSM6AAAAAA4KLYGLU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Manually updating OpenEVSE data too often once car is charging

Through logging, I've noticed there's a request every second once the car starts charging.

What version are you running?

2.1.7-b9

Looks like some kind of connectivity issue. The integration only does a refresh after 60 seconds AND if there's no data coming in from the web socket.
What firmware is your OpenEVSE on?

Actually it looks like this message:
2022-11-05 22:51:51.268 DEBUG (MainThread) [custom_components.openevse] Manually updated OpenEVSE (openevse) data
happens when the websocket information updates the device data, looks like they may have changed the code in Home Assistant core as I don't recall this message showing up before.

I’m on 2011.11.0 which could have introduced this issue.

Technically not an issue.

From the component’s perspective, doing thousands of requests during the charging period could result in crashing OpenEVSE’s webserver. Needs investigation around why Home Assistant is requesting that on each websocket update. I’ll see what I can dig.

The integration doesn't request anything from the OpenEVSE, web socket data is pushed to Home Assistant, not polled.

Ah! I thought the "manually updated" log was from the component (and now from Home Assistant itself) requesting an API update from OpenEVSE in response to the event. In that case it's probably just the frequency of websocket updates resulting in some kind of update_entity call inside Home Assistant.
Apologies for the confusion.


Convolution (gaussian+decay) function

Added a function to TGRSIFunctions that is the convolution of a gaussian and an exponential decay. This is useful, for example, when you have a TAC with a long half-life. I have already succesfully fitted the 1.4 ns lifetime in Eu-152 with this function

Looks good!

Just for future reference, with a nice description like you have of what the function is doing, this should use three '/' instead of the normal two for the comment, so that it shows up in our documentation.


python310Packages.irc: 19.0.1 -> 20.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.irc is: "IRC (Internet Relay Chat) protocol library for Python"
meta.homepage for python310Packages.irc is: "https://github.com/jaraco/irc"
meta.changelog for python310Packages.irc is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 20.0.0 with grep in /nix/store/sr70h0ljpyrycccalym7g9fij3805mcd-python3.10-irc-20.0.0

found 20.0.0 in filename of file in /nix/store/sr70h0ljpyrycccalym7g9fij3805mcd-python3.10-irc-20.0.0

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
4 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
errbot
heisenbridge
python310Packages.irc
python39Packages.irc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sr70h0ljpyrycccalym7g9fij3805mcd-python3.10-irc-20.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.irc https://github.com/r-ryantm/nixpkgs/archive/515d7c02da7710d23c059a03bdf5dc0cb083e711.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sr70h0ljpyrycccalym7g9fij3805mcd-python3.10-irc-20.0.0
ls -la /nix/store/sr70h0ljpyrycccalym7g9fij3805mcd-python3.10-irc-20.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

heisenbridge

3 packages built:

errbot
python310Packages.irc
python39Packages.irc

Maintainer pings

This was done in https://github.com/NixOS/nixpkgs/pull/153179 ?


Create 2020-06-24-end-of-cycle-exploratory-research.md

A research entry to act as a template for future research posts into the Design History - first iteration
Other sections that we could include (but that don't fit for this particular entry):

Hypotheses
Summary of findings (where easily summarised into less than 10 bullet points probably)

This is great @billwessel-dfe. I'm wondering whether we might want to capture how the research fits into team workflow. I think it'd be helpful for further setting the scene? Maya's helpfully broken this down on candidate UR card template https://trello.com/c/ybA54EPd. We might not need an explicit subsection for it, but worth bearing in mind when writing the context section?

This is great @billwessel-dfe. I'm wondering whether we might want to capture how the research fits into team workflow. I think it'd be helpful for further setting the scene? Maya's helpfully broken this down on candidate UR card template https://trello.com/c/ybA54EPd. We might not need an explicit subsection for it, but worth bearing in mind when writing the context section?

@KaharHus It might even be helpful to have a separate entry on how research fits into the team workflow that we could reference in future research entries

Most definitely! I don't see why not.


[Bug] It is possible the underlying files have been updated

Bug
Describe the problem
I have this setup: A AWS Glue Job kinesis_consumer that consumes a kinesis stream and stores the data in s3 bucket kinesis_data.
kinesis = (
            spark.readStream.format("kinesis")
            .option("streamName", stream_name)
            .option("endpointUrl", x)
            .option("region", region)
            .option("startingPosition", position)
            .option("minOffsetPerTrigger", tim)
            .load()

stream_data.writeStream \
                .format("delta") \
                .outputMode("append") \
                .trigger(processingTime="200 seconds") \
                .option("checkpointLocation", checkpoint_location) \
                .start(s3_target)
        spark.streams.awaitAnyTermination()

Another Glue Job data_exposer is supposed to read the data from the s3 bucket kinesis_data and store it in a different s3 bucket exposed_data:
df = spark.readStream \
                    .format("delta") \
                    .option("ignoreDeletes", "true") \
                    .option("startingVersion", "latest") \
                    .load(s3_target)
df.writeStream \
        .format("delta") \
        .outputMode("append") \
        .option("ignoreChanges","true") \
        .option("checkpointLocation", s3_chckp) \
        .start(s3_path)

When I try to read from the kinesis_data with Glue Job data_exposer I am getting this error:
java.io.FileNotFoundException: No such file or directory 's3://kinesis-data/kinesis/_delta_log/00000000000000000016.json'
It is possible the underlying files have been updated. You can explicitly invalidate the cache in Spark by running 'REFRESH TABLE tableName' command in SQL or by recreating the Dataset/DataFrame involved

I am assume I must have misunderstood something. Could you please tell me what am I doing wrong?
Environment information

Delta Lake version: 1.0.0
Spark version: 3.1.1.
Scala version: 2.12

Willingness to contribute
The Delta Lake Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Delta Lake code base?

[ ] Yes. I can contribute a fix for this bug independently.
[ ] Yes. I would be willing to contribute a fix for this bug with guidance from the Delta Lake community.
[ ] No. I cannot contribute a bug fix at this time.

@gegiannos Looking into the issue, will get back to you soon.

@gegiannos Could you provide the entire stack trace of FileNotFoundException? This would help us investigate the issue.

@zsxwing Sorry for the late response. I got my answers via the slack channel #deltalake-oss  thanks to Dominique! Apparently, it is a rare case of hiting a weird condition in S3 where a file took too long to show up in a listing.
Thanks for your support, I think the thread can be closed (I leave it up to you).

a file took too long to show up in a listing

Could you provide the slack link? I'm curious about this because S3 is strong consistent and this should not happen.


Extra / in CURL when deploying options

Similar Issue to dvankevich - all the options are getting filtered with a / before the option is set.
Line 528:
"$curl" "${curl_options[@]}" --request GET --url "$url/api/$endpoint${id:+/}$id${target:+/}$target"
should be:
"$curl" "${curl_options[@]}" --request GET --url "$url/api/$endpoint${id:+}$id${target:+/}$target"
Once corrected, I'm able to properly set options like count and offset.

This doesn't quite work.  If you run bs under bash -x, you'll see that specifying any options causes those options to be incorrectly assigned to the id parameter:
...
+ getopts c:o:s:f: OPTION
+ case "$OPTION" in
+ query='?offset=100'
+ getopts c:o:s:f: OPTION
+ get users '?offset=100'
+ endpoint=users
+ id='?offset=100'
+ target=
+ shift 3
+ curl -s --http1.1 --header 'Authorization: Token aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' --request GET --url 'https://my.bookstack/api/users/?offset=100'

Indeed, your fix breaks specifying id with -i for read, update, etc requests.
I'm not quite sure what the proper fix is here as of yet - I'm still thinking it over.

I've fixed this in my fork, and created a PR in this repo to have it merged.  It looks like this repo might be abandoned, so I'm not holding my breath for it to be applied, but perhaps I'll be surprised.
https://github.com/Yetangitu/bs/pull/6


[BUG] Top Metrics Aggregation Exists in Java Client But Not Supported

What is the bug?
Top Metrics Aggregation Exists in the Java Client, but is not supported by OpenSearch
How can one reproduce the bug?
Create an aggregation query with top metrics aggregation
What is the expected behavior?
Preferably support for this aggregation would be added and results would return
What is your host/environment?
Do you have any screenshots?
none
Do you have any additional context?
Opensearch-java version: 2.11
Opensearch cluster version: 2.11
Error: [parsing_exception] Unknown aggregation type [top_metrics] did you mean [top_hits]?

related: https://github.com/opensearch-project/opensearch-java/issues/420


oci-containers: consolidate capabilities interface

capAdd and capDrop were consolidated into a single capabilities option.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I was initially opposed to this approach but now that I see it implemented it actually looks pretty reasonable.  Let's see what others might have to say about it.

@benley Can we backport this to 24.11?

@benley @roberth Can we backport this to 24.11?

It's a grey area, but I'd support it for these reasons

these two PRs are low risk
backporting these changes makes future backports of fixes easier