Aspect ratio lost in settings

There is some inconsistency in resulted image aspect ratio.
I have played the demo for a while with rectangular images, canvas and rectangular cropped area.
So, actually resulted image sizes have a wrong aspect ratio and it seems like it's value has the sum of the aspect ratio of the crop area and the canvas in general.
(i'll show you plunker later)
Finally, I mean, if I ignore default sizes with similar sizes on each width/height, i will be confused about getting right values on actual result, Settings should be more intuitive and simple.
BTW, i just finished with uploader cropped area via XHR.
It's very simple. we can include this function in future releases if u don't mind,

Any updates? Is this still going on?

Any updates?

Personally, I think that's bad design to make things from based on a canvas design.

cropWidth:*number - actual cropped image width
cropHeight:*number - actual cropped image height

Added ^^^ in order to know the actual cropped image width/height on settings - updated test app as well - will be released today


Updater broken? 1.1.77 release

https://forums.factorio.com/105436
I don't see any pull requests... is the update process broken @Fank and team?

docker build . --build-arg VERSION="1.1.77" --build-arg SHA256="4653b023364653a417769b99ec64572e616f683c127bb9ec4ff4dc6544a6fff9"
the above command will build newest version - this can be used as a workaround

docker build . --build-arg VERSION="1.1.77" --build-arg SHA256="4653b023364653a417769b99ec64572e616f683c127bb9ec4ff4dc6544a6fff9"
the above command will build newest version - this can be used as a workaround

Sure, but maybe I just need to run my own watchdog and do my own builds .... it's been pretty stable for a while but every once in a while we fail to get a build.

No idea how to manually update using this, took me long enough to get it working first time :(

I am setting up my own watchdog and building images from a fork of this repo. People can point at it until this one gets back on track. https://hub.docker.com/repository/docker/bplein/factorio/general.  just change your image to (assuming you trust me!) bplein/factorio

I am also pushing image builds to ghcr.io/bplein/factorio-docker:, i.e. ghcr.io/bplein/factorio-docker:1.1.77
https://github.com/bplein/factorio-docker/pkgs/container/factorio-docker
I hope @Fank and @SuperSandro2000 are just taking some time off and nothing worse!

I am also pushing image builds to ghcr.io/bplein/factorio-docker:, i.e. ghcr.io/bplein/factorio-docker:1.1.77
https://github.com/bplein/factorio-docker/pkgs/container/factorio-docker
I hope @Fank and @SuperSandro2000 are just taking some time off and nothing worse!

Ty!
And I am sending good thoughts also, hope everyone is doing OK

I am just doing NixOS. Maybe I'll add a action that pushes the container image to ghcr.io.

Unbelievably, my watchdog worked on my fork... so my upgrade to 1.1.78 went flawlessy.
you can look at the action I created at bplein/factorio-docker ... seems to work.

So if anyone is coming to this later, I believe the simplest way to keep your existing docker server up and running with minimal issues is to pull the @bplein image and overwrite the factoriotools one with it:
docker pull bplein/factorio
docker tag bplein/factorio:latest factoriotools/factorio:latest

Then you can just run your normal run commands.

I am just doing NixOS. Maybe I'll add a action that pushes the container image to ghcr.io.

Sandro, I got ahold of @Fank and he said that you run the watchdog?  If you want, I can point the watchdog I am running over at this system, if you'll allow me to push the updates. Or if you can just check your watchdog and make sure it's running.

I haven't had it running for a good amount of time because it kept breaking and pushing nonsense commits.

I haven't had it running for a good amount of time because it kept breaking and pushing nonsense commits.

So the repo is abandoneware?
I am running a copy of @Fank 's watchdog against a fork of this repo and its working since 1.1.77. Read the thread above.
Let me know if you'd like me to point the watchdog at the org repo and let's work permissions and I'll run it for now.

There is still a bug which sometimes generated nonsense commits you can see here https://github.com/factoriotools/factorio-docker/commits/master?after=d90480712d356d9662d5115ca2d005759251cce0+69&branch=master&qualified_name=refs%2Fheads%2Fmaster
I don't think anyone fixed that in the meantime.

I don't think anyone fixed that in the meantime.
I didn't but it looked like it just worked when I was running it (still can't remember).

@bplein i send you an invite for the team, so you should have access to the repository.

I didn't but it looked like it just worked when I was running it (still can't remember).

It is not happening immediately and only after some time that the watchdog goes into some undefined state.

I have been given sufficient permissions to connect my copy of the watchdog to this repository. I've got other pressing personal things that will mean I will get to this later in the week.

This would actually be a very good way of handling it... an on: schedule to check for a change, and if it does, to do the repo change for version and SHA256. There's also the building of the buildinfo.json, a bit beyond me.
Thanks for this, maybe I can take it on. I had to figure out a lot to do builds for both GH as well as Docker Hub... I'll look at it this weekend.

FYI, @Fank 1.1.80 became stable today and I'm not seeing the tag for it created yet.

Scroll up. I am building these from a fork. Later we will point my watchdog here and start building these again but for now you can use my repo.

Thanks to @KagurazakaNyaa the new version is now available, and should be more reliable in the future.


out of memory issue: garbage collection ?

Recently we ran into out of memory issues (in node) when executing our tests via mocha.
We are running about 5000 tests/specs and are guessing it has something to do with closures and garbage collection.
For now we have logically splitted our runs into multiple ones, but it is just a matter of time before we encounter the same problems.
I am certain this issue will affect other teams also.
Can someone tell me how we can pinpoint/analyze/solve the problem?
Thank you very much in advance.

As reference https://github.com/mochajs/mocha/pull/2037/files#diff-b3b53682a18f203ac8d29b0e277cad26R749
Would it be possible that this handling should be done after each root describe block not only after a bunch of files which get threated as a single suite (as far as i can see) gets done ?
So multiple describe blocks in multiple files should be the right way of testing this

anyone ?

bump :-)

I'm not sure of the best way to diagnose memory leaks in Node (would love some assistance here), but otherwise I can't be of too much help without seeing your test(s).

Thank you for the feedback.
The problem is that as soon as the memory problems arise, a random test fails.
Therefore it is not possible to give you one "failing" test :-/
Since we believe our test setup is in line with the common approach, there must be other teams that face these kind of memory problems?

FWIW, I am running into a similar symptom, not sure if the cause is the same. I'm converting a nodeunit test suite to mocha.

@TomVanHaver I've found out what is retaining memory in my particular case, sharing it here in case its something that might help you:
Our application builds out a large graph object with nodes. In each of our tests, we build out a new graph. I found out that a few of these nodes were calling the js setInterval, which caused the memory of the entire graph to stick around even when each test case was over. Clearing these intervals fixed my problem for me.
The direction of approach that finally got me here was this:

Create a 2 mocha test files with your standard setup/teardowns
Add a lot (hundreds) of empty test cases like it('test', () => {assert(true)}) in each test file
Create a before  and after in each file and use heapdump to take heapsnapshots
Compare the sizes of the snapshots, and perhaps zoom into beforeEach/afterEach snapshots
Start commenting out code in your setup/teardowns and observe if the snapshot sizes change significantly.

Hopefully that helps you track down your memory retainment.

I'm going to close this; if someone can find a leak in Mocha itself, please create a new issue!

Anyone encountering this should be aware of leakage to track down memory leaks in their code.

i agree, but we are still looking how to track leaks in specs or to isolate suites.

@TomVanHaver I might be missing something, but isn't this exactly what leakage is for?
The following will throw if the spec is leaking. It does require you to actually modify the test code by wrapping the function, though, which is a bit of a pain (tool idea: use a codemod to dynamically create a version of your test suite where each test is wrapped in a leakage block, cleaning up after finish).
describe('myLib', () => {
  it('does not leak when doing stuff', () => {
    iterate(() => {
      const instance = myLib.createInstance()
      instance.doStuff('foo', 'bar')
    })
  })
})

@fatso83 That might work be can also give false positives due the fact your describe  can be still holding on to stuff see https://github.com/mochajs/mocha/blob/51212115c8f46d47b57ce9e65f054f83bc7a0acc/lib/suite.js#L524


Cross origin issues

Getting 2 cross origin request issues when running this locally:
three.min.js:386 XMLHttpRequest cannot load file:///Users/mac/_DEV/_LAB/threejs-animation-workflow/textures/ground.png. Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https, chrome-extension-resource.
three.min.js:386 XMLHttpRequest cannot load file:///Users/mac/_DEV/_LAB/threejs-animation-workflow/models/eva-animated.json. Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https, chrome-extension-resource.

This is a common issue with threejs. Modern day browsers block scripts from accessing local files as a security features. The two ways to fix it are to host all files on a web server.  Or launch chrome from cmd with the --allow-file-acess-from-files flag.  The latter is somewhat dangerous tho


[build] amend search path for Cmake modules

Since we are not using symlinks anymore, we need to point to the correct
directory with LLVM cmake modules.
Fixes rdar://problem/57294763

@swift-ci please test Windows

This is related to #28296

@swift-ci please test Windows

@swift-ci please test Windows

@swift-ci please test Windows

@swift-ci please test Windows

@swift-ci please test Windows

Can you please try with "please clean test Windows platform" if the last one fails? Thanks!

Thanks for the tip!
This time the build started fine, but I will remember this for the future.

@swift-ci please smoke test


Fix formatting of Selection object documentation

Docs Build status updates of commit de147a7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/PowerPoint.Selection.md
:bulb:Suggestion
View
Details

api/PowerPoint.Selection.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


3D image page

I got this request. "We now have the 360° image. But we would also love to have a page for 3D images. So you can walk around a 3D figure and see it from all sides can view. And then on with options for adding hotspots, audio, interactions (go to page)."
Is this something we can do?

Online 3D Viewer allows you to embed 3D models (e.g. embed in Xerte page). It's open source so might be possible to properly integrate into a new Xerte page with hotspots etc.

Can I create a free account?


markdown render incorrectly in operation_semantics#batchnormgrad

URL(s) with the issue:
https://www.tensorflow.org/xla/operation_semantics#batchnormgrad
Description of issue (what needs changing):
the brachnormgrad table render incorrectly
Clear description

Correct links
no find yet
markdown to html used google internel doc system.

@mingting This is the link https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/g3doc/operation_semantics.md you may want to fix.

@ymodak yes.
I tried to contribute for this markdown file, but I don't know which table syntax this markdown used.
I discussed with community,
https://discuss.tensorflow.org/t/question-about-markdown-table-format/2492
I get know, because of the markdown used a google syntax,  developer out of google cannot change this markdown file.
the markdown to html should take care google syntax well.
but for this issue, theere is problem in html file. I think this should be bug of markdown to html system.

cc: @8bitmp3

This is now fixed.
https://www.tensorflow.org/xla/operation_semantics#batchnormgrad
Thanks!


Chat function have disappeared

I re-installed fully my computer.
I always download the latest version of Xenontrade.
But, before, like 2 weeks ago, I had a version of Xenontrade that would ask for the path of poe, and would allow chat command, like reply / thanks / sold
On this version. it is not present anymore.
What do i have to do to get the chat function back ???

Are you using the alpha version?

I was not ! that s why.
Thanks :)


Use globals if defined on exports

it helps when we bundle an application using browsefiry or a different bundler and we have defined global values jQuery and moment.

Per the contrib doc, please make your PRs to the development branch. PRs to the master will be closed.


Config option to escape required fields check when in draft stage of editorial workflow

Is your feature request related to a problem? Please describe.
Using the editorial workflow while working on pieces of long-form content with many required fields may warrant multiple iterations of work to be done on a single entry in order for all of those required fields to be entered in. Currently, I'm not aware of a way to save a draft without all the required fields being filled out.
That's frequently been a pain point I've encountered on a WIP entry and usually just leads me to leave the editor up for multiple days until I can fill everything out and finally be able to save - a very dicey practice if your computer crashes and you somehow lose the localforage backup of all that work, which has unfortunately happened to me a couple times. The dirty workaround is to add dummy data to those fields, but then that can easily sneak its way into production and is therefore bad practice in my opinion.
Describe the solution you'd like
I would like an editorial_workflow config option allowing required field validation to be turned off for content currently in/going into draft status. This would then allow a new entry to be saved as a draft without adding in all of the required fields. Then, content going into the ready or in_review statuses could run the required field validation hook to ensure nothing publish-ready is missing any required fields.

Example config:
publish_mode: editorial_workflow
required_fields:
  - status: draft
    enforced: false
  - status: pending_review
    enforced: false
  - status: pending_publish
    enforced: true

This schema allows future extension of the editorial workflow, such as a feature where users could define additional entry statuses.

I'm taking a stab at this & it'll be my first contribution here!
So far I've got the new config options schema and state set up in my fork:
feat(core): add requiredFields config schema (netlify#5013)
feat(core): add requiredFields config state (netlify#5013)
Though I'm now a bit stuck on how to approach the next part while adhering to best practices.

Should I just access the state.config in actions/editorialWorkflow.ts to grab the required_fields config?
What would be a robust way to bypass persistence validation in the entry saving pipeline?

I'm thinking of creating a function that'll accept an entry's newStatus then compare that against the status' setting in required_fields to see if the pipeline should bypass presence validation. Though I'm honestly not sure on the best place to put that logic.
@erezrokah do you have a recommendation on how to approach that next part? Thanks for all you do in maintaining this project by the way!

Hi @tonyketcham, thank you for looking into this!
A few questions:

Do we want this config to be per collection or affect all collections?
In your proposal the configuration is at the root level - should we think of a way to make it clear it's only for editorial workflow mode?
Validation code runs for each widget here https://github.com/netlify/netlify-cms/blob/36608f8d7560649f3a6475da2603b206d1db6b55/packages/netlify-cms-core/src/components/Editor/EditorControlPane/Widget.js#L115
That code is invoked when a users clicks the save button here https://github.com/netlify/netlify-cms/blob/36608f8d7560649f3a6475da2603b206d1db6b55/packages/netlify-cms-core/src/components/Editor/EditorInterface.js#L170 and some other cases too.

The errors are propagated to the redux store here:
https://github.com/netlify/netlify-cms/blob/36608f8d7560649f3a6475da2603b206d1db6b55/packages/netlify-cms-core/src/reducers/entryDraft.js#L118
If you change this action https://github.com/netlify/netlify-cms/blob/36608f8d7560649f3a6475da2603b206d1db6b55/packages/netlify-cms-core/src/actions/entries.ts#L424 to a function you should be able to access the redux state and configuration.
Also, we should find a way to re-rerun validation when a user changes the workflow entry status (e.g. from draft to ready) and prevent publishing when it fails.

@erezrokah wow, those references are all really helpful and will save me a ton of time, thank you! You've raised some really good questions that I'm going to think over for a couple of days as I get more familiarized with the codebase.
I had originally thought about including the config within the publish mode but saw that as a bit more of an uphill battle refactoring-wise, as opposed to creating a new set of config, but I agree it would be better to clearly relate those config options together somehow.
I also really like the idea of being able to configure per-collection as well as at the root level. This could allow a global set of defaults which could be optionally overridden for specific collections.


Have "dist plan" with mismatched versions explain what different tags would announce

Here's what it looks like as of the last time I edited this comment (~3:30pm ET on November 14th):

If everything in a workspace has the same version, everything works as it did before this PR:

TODO: Figure out what to do with JSON output. Right now, it prints the JSON representation of each report individually, which means if you have mismatched versions the JSON output is invalid.
This should be resolved somehow before this is merged.

@ashleygwilliams here's my understanding of everything related to this PR.
dist plan on main intentionally fails when projects in the same workspaces have mismatched version numbers and --tag isn't specified. However, when the generated workflow is running in a PR, there is no tag to specify — so it just runs dist plan --output-format=json > plan-dist-manifest.json.
This was encountered in the real-world here: https://github.com/mitre/hipcheck/actions/runs/11808204242/job/32896362439
It resulted in this error:
  × There are too many unrelated apps in your workspace to coherently Announce!
  help: Please either specify --tag, or give them all the same version

        Here are some options:

        --tag=v0.1.0 will Announce: activity, affiliation, binary, churn, entropy, fuzz, git, github, identity,
        linguist, npm, review, typo
        --tag=v3.7.0 will Announce: hipcheck

        you can also request any single package with --tag=activity-v0.1.0

Error: Process completed with exit code 255.

Making dist plan provide a human-readable output for multiple things is relatively straightforward -- you get a list of all known versions and iterate over them, generating the usual dist plan --output-format=human output for each one.
But if you do that for the JSON output, it falls on its face: it tries to print multiple JSON documents in a row, which aren't valid.
The obvious solution is to put them in a JSON array. That looks something like:
[
    {
        "dist_version": "...",
        "announcement_tag": "v0.1.0",
        ...
    },
    {
        "dist_version": "...",
        "announcement_tag": "v0.3.1",
        ...
    }
]

But, everything in dist appears to be built under the assumption that the JSON output for dist plan, dist manifest, and dist build would always be a single map. This change broke over 50 tests, all parsing the output of dist plan --output-format=json.
I determined that if you change PlanResult::parse so that it returns Result<Vec<cargo_dist_schema::DistManifest>> instead of Result<cargo_dist_schema::DistManifest>, it'll fix all 50-something tests... but breaks another one.
https://github.com/axodotdev/cargo-dist/blob/b487ee9c61681f4532b2d4bd1d09ca32484bffb9/cargo-dist/tests/gallery/dist.rs#L500-L505
The one that is broken by changing this is parsing the output of dist build --output-format=json -- which, prior to the work in this PR, has been identically structured to dist plan, which has been identically structured to dist manifest.
It is also unclear to me if the code in the generated workflows would work, even if we get the entire test suite passing. Fixing the tests may just mean we're no longer testing real-world usage.
I think the manifest is used by receipts, so it might break upgrades.
It also doesn't make sense for dist manifest or dist build to return an array, because they both are currently designed to only return a single manifest — and returning a single-item array is kind of misleading.
Basically: This functionality is at odds with what may be the most common assumption in this codebase.

revised plan for this:

add a command (or flag for dist plan) that prints a JSON representation of all possible tags
in the generated workflow, use that new command to determine what tags there are, and run dist plan --output-format=json --tag=${TAG} > plan-dist-manifest-${TAG}.json for each one

Closing in favor of #1595.


[Bug] batch describe lists batches instead of describing a batch

These 2 commands have identical output:
$ temporal batch list --env sdk-ci
  State                 JobId                   StartTime
  Failed  WorkflowWithSingleNoopActivity:abc  4 minutes ago

$ temporal batch describe --job-id  WorkflowWithSingleNoopActivity:abc --env sdk-ci
  State                 JobId                   StartTime
  Failed  WorkflowWithSingleNoopActivity:abc  4 minutes ago

Testing on the CLI rewrite this is resolved
➜  temporal git:(cli-rewrite) ✗ ./temporal batch list
                 JobId                    State      StartTime       CloseTime
  8a021703-bb20-4379-87c2-f997b92fc05a  Completed  6 seconds ago   6 seconds ago
  346cc111-35f6-41e2-9959-0784a93a6ca9  Completed  10 seconds ago  10 seconds ago
➜  temporal git:(cli-rewrite) ✗ ./temporal batch describe --job-id 8a021703-bb20-4379-87c2-f997b92fc05a
  State           Completed
  Type            Terminate
  StartTime       56 seconds ago
  CloseTime       56 seconds ago
  CompletedCount  1/1
  FailureCount    0/1


[hotfix] [docs] Document union list metadata gotcha

What is the purpose of the change
Document that union list metadata is O(N) in the length of the list and may lead to unexpectedly large metadata files and/or RPCs.
Brief change log

Document union list metadata.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@rmetzger 'test_ci misc' job of Azure build failed. Do I need to retrigger it, as the change is just a documentation fix. Please point


[ko] replaced {{< codenew ... >}} with {{% codenew ... %}}

This is a continuation of PR https://github.com/kubernetes/website/pull/42180 (Replace {{< codenew ... >}} with {{% codenew ... %}})
Fixes https://github.com/kubernetes/website/issues/42179 (Copy To Clipboard breaks YAML format)

@andreygoran please re-push commit for the build to pass
Unfortunately this happens from time to time.

Done

Hi @andreygoran
Thank you for the contribution!
Korean localization team accepts PRs to sync Korean content with English content, but please note that our current Korean localization is on a separate development branch (current Korean localization dev branch is: dev-1.27-ko.1). Submitting a PR directly to the main branch may cause merge conflicts later on.
Could you update this PR to target the correct target branch, or open a new PR targeting the Korean localization development branch.
Thank you.

Hi @seokho-son
I created new PR https://github.com/kubernetes/website/pull/42278 based on branch dev-1.27-ko.1

The merged PR #42278 supercedes this one.
/close


filterOptions doesnt work for filters with include block

If i define filter's options in filterOptions  section it merged in pure filters, but doesnt into filters with include block. E.g.:
let compile = pug.renderFile(path.join(inputDir, `${file}.pug`), {
    pretty: true,
    plugins: [cssModules],
    filterOptions: {
        "scss": {
            modules: true,
            includePaths: ['../app/styles', '../app/styles/images'],
            outputStyle: 'compressed',
        },
    }
});

works fine:
        style
            :scss
                body {
                    background-color: #989898;
                }

doesn't work:
style
    include:scss ./styles-pug.scss

Fixed in e4a8200


Train for an unconditional model

Hi !
I'm currently trying to train a ControlNet for a different model from StableDiffusion (unconditionnal model, originally trained on ImageNet, finetuned on a specific dataset. The architecture is the one used in the guided diffusion repo ). However it appears that my ControlNet doesn't show any sign of convergence. I have already trained for 50k iterations. It seems the condition is simply ignored.
Do you have an intuition/insight on this ? Have you tried to train on a model lighter than stable diffusion ? In term of architecture of the controlnet, my model operates directly in the pixel space so the input_hint_block is a simple zero conv.
Of course i don't rule out a mistake in my code.
Thank you for your help

I have the same confusion, the loss on the custom dataset has been oscillating. @LouisRouss How did you solve it?

After multiple attempts i decided to train a model directly with the condition i needed without using a hypernetwork. The issue isn't really solved


(WIP) Add meta info to cards in editorial workflow

- Summary
Adds meta information to the cards in the editorial workflow. Currently this includes the following:

Which collection an entry is part of
Whether an entry is new or an update to an already published entry

In order to retrieve the new/update info, it adds the field state.editorialWorkflow.entities[i].isModification, which is retrieved using the GitHub API whenever unpublished entries are loaded.

- Test plan
TODO

- Description for the changelog
TODO

- A picture of a cute animal (not mandatory but encouraged)

@erquhart I've added the resolvePromiseProperties code to this branch. How do you want the history to look? I'm thinking about merging the last two.

@erquhart I've addressed your change requests - how does this look now?


fix: capitalize react concept (Action)

This PR fixes capitalization of word Actions for issue #6713

Can we go for Trademark request ? (if possible)

Will look at it and update it soon.


[TASK] Improved TEAL search error message

Pull Request Description
What issue does this change request address?
Closes #13
What are the significant changes in functionality due to this change request?

Adds a more intelligent error if TEAL is not found during HERON initial run
Adds docstrings and formatting fixes, especially for the template_driver.py
Adds unused <Optimizer> template to RAVEN outer.xml, which will be used in the future but is passive for now

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

How did you get the automated tests to run (item 4 on the checklist)?


FmuResource::getResourcePath() returns wrong path?

When using the current master of omc to generate an FMU, the file <model>_info.json is put directly into the resources folder inside the FMU. However, FMI4cpp looks for it in the folder "resources" + getOs() + "/" + getLibExt(), which for me is resources/linux64/.so and thus cannot find the file.
Is this a bug? When I remove adding getOs() and getLibExt() everything works as expected.

Yes, this is a bug I discovered recently. It was fixed 4 days ago.
https://github.com/NTNU-IHB/FMI4cpp/blob/master/src/fmu_resource.cpp

Which version of FMI4cpp are you using btw, and how are you getting it?
This fix will be in 0.7.0 which will be a pretty major release as far as breaking changes are concerned.

Closing since this fix is present on the master branch


Mystem process doesn't terminate after Main thread quits

I have a code, similar to that in example:
public class LemmatizationAnnotator implements edu.stanford.nlp.pipeline.Annotator {

  private static final Option<String> NULL_OPTION = scala.Option.apply(null);
  private static final MyStem mystemAnalyzer =
          new Factory("-ld --format json").newMyStem("3.0", Option.<File>empty()).get();

The issue that when I run mvn clean package for my App, which uses this class like
new LemmatizationAnnotator(),  the test phase also runs and test environment is built every time, which means MystemAnalyzer is created every time, as well as  mystem.exe process runs every time (I'm working on Windows). The issue that Surefire waits for every non-daemon process for my app to finish, and mystem.exe doesn't finish after main thread exits.  So my mvn clean package just hangs and waits for MyStem to exit.  Is this an issue for wrapper or should I figure it out somehow by myself?

Hi, thanks for reporting.
Gut feeling tells me this does have something to do with the wrapper. Unfortunately, I don't have the resources to investigate this in the nearest weeks, so I'd be very grateful if you tried to figure it out yourself and maybe explained what the trouble was and how to fix it.

Sorry for not responding for quite a while.

Hi, I've faced the same problem. I've made a simple token filter for elasticsearch/lucene, that calls mystem. Could you advise the way how to investigate that?


Training script

Hey, since you don't have GPU resources to train, can you provide your training script? I will train based on yours and open source it.

same question, will training scripts be released?

嘿，既然你没有 GPU 资源来训练，你能提供你的训练脚本吗？我会根据你的进行训练并将其开源。

same

Or atleast share the training hyperparameters so that we can write training script ourself


About the visualzation of edge map

Could you release the code of visualization in the paper?

I also need it! Could you solve it or write?


Implement profiling extensibility points in fortune

At Victor we use New Relic to allow us to get a deep understanding of how our code is performing in our deployed environments.
We want to use New Relics custom tracer functionality within our fortune instances to log a detailed breakdown of where time is being spent within a transaction, without embedding new relic as a dependency of fortune.
https://docs.newrelic.com/docs/agents/nodejs-agent/supported-features/nodejs-custom-instrumentation#expanding-instrumentation
To achieve this we'll provide extension points at critical times within the lifecycle:

Fortune request start & end
Request parse start & end
Database call start & end
Connection open start & end
Response preparation parse start & end
Include resource processing start & end
Anything else?

Continuing the list:

hooks start & end totals
distinct hooks start & end (they run sequentially)


Contributing Comment

Let's add a contributing file so we can work  better togther.

This is a great project.


Initial code

As we are reviving this JSlib, we want to make sure we are properly set up from a legal point of view. To do so, we need our contributors to sign our CLA. Thus, we have wiped the main branch history, and intend to merge back the commits into it, to trigger the cla-assistant.
This PR does not add anything thing to the previously existing code, but does just that: re-import that existing code and git history, to trigger a cla-assistant request.
We would really appreciate it if you could sign the CLA @alanbrent so that we can keep building upon your contributions to this JSlib (and make sure you remain mentioned as a contributor of the project on the Github repo). Please let us know as soon as possible if you are unable to for any reasons, so we can adapt our plan forward 🙇🏻

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: MStoykov:x: alanbrentYou have signed the CLA already but the status is still pending? Let us recheck it.

Gently reminder @alanbrent, we could really use your signature 😸

Heads-up, we ended up rewriting the code, and your CLA signature won't be necessary anymore @alanbrent. Thanks a lot for your past contributions 🎉
Closing this as a result.


write a test to evaluate UI conformance before release

this will take a bit of work, but we should also be checking that the generated schema is conformant with the VJSF editor.

I wonder how that could even be done without some selenium or alike, since IIRC for anyOf it just wouldn't render what we expect it to render, instead of giving some warning/error (or does it?)

indeed we would have to use selenium or cypress or some such tool. not an easy task, but we would have to write that all these fields are expected to be in the display, but we could break the test into each of the schema components, not the overall schema.


visualMap piecewise.categories dataValue typo correction

small typo found here: https://echarts.apache.org/en/option.html#visualMap-piecewise.categories
previously: "...from dataVale to visual channels"

@sjcobb Thanks for the help! :)


⚠ Bofrost.at has degraded performance

In b48ffb1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1134 ms

Resolved: Bofrost.at performance has improved in 9959175 after 7 minutes.


chore: update avatar demo

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[x] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue
https://github.com/Tencent/tdesign-vue/issues/1281

💡 需求背景和解决方案

📝 更新日志

chore: avatar 组件示例代码的 Space 组件优化

[x] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1350 (d4d77a4) into develop (492d477) will increase coverage by 0.22%.
The diff coverage is 68.62%.

@@             Coverage Diff             @@
##           develop    #1350      +/-   ##
===========================================
+ Coverage    57.94%   58.17%   +0.22%
===========================================
  Files          407      412       +5
  Lines        15371    15439      +68
  Branches      2931     2917      -14
===========================================
+ Hits          8907     8981      +74
- Misses        6187     6188       +1
+ Partials       277      270       -7

Impacted Files
Coverage Δ

src/anchor/anchor-target.tsx
100.00% <ø> (ø)

src/calendar/const.ts
100.00% <ø> (ø)

src/cascader/cascader.tsx
64.00% <ø> (ø)

src/color-picker/color-picker.tsx
81.25% <ø> (ø)

src/date-picker/base/Header.tsx
7.57% <0.00%> (-0.37%)
:arrow_down:

src/date-picker/date-picker-panel-props.ts
100.00% <ø> (+90.00%)
:arrow_up:

src/date-picker/date-range-picker-panel-props.ts
100.00% <ø> (+90.90%)
:arrow_up:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/date-picker/hooks/useRange.ts
35.89% <ø> (ø)

src/date-picker/hooks/useSingle.ts
37.28% <ø> (ø)

... and 208 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Create XmlParameter

Related Problem or Business Case
New parameter should unify xml, domdoc and node types.
Node is no longer possible? See #3934 we need to verify this and remove the functionality/implementation.
Needs to be backwards compatible (type setter should set domdoc and give a config warning).
Describe the Feature
Cleanup AbstractParameter
Collaboration with External Companies
No, community resolution only
Anything else?
No response

In the larva, it should also support the different parameter types.

Tracked by #6802


Javamerge does not merge annotations

Currently, the java merger does not merge annotations.
This might be a tricky task as well as we might have to implement some kind of "matching" heuristik in case of annotation arrays as annotation parameter values.
@hohwille any existing implementation available in mmm? :D

closed in favor of  #1053

The problem still exists

Input EmployeeEntity.java
package com.example.domain.myapp.employeemanagement.dataaccess.api;

import javax.persistence.Column;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;

public class EmployeeEntity {

  @Column(name = "EMPLOYEEID")
  @GeneratedValue(strategy = GenerationType.IDENTITY)
  private Long employeeId;

  @Column(name = "NAME")
  private String name;

  @Column(name = "SURNAME")
  private String surname;

  @Column(name = "EMAIL")
  private String email;

  /**
   * @return employeeId
   */
  public Long getEmployeeId() {

    return this.employeeId;
  }

  /**
   * @param employeeId new value of {@link #getemployeeId}.
   */
  public void setEmployeeId(Long employeeId) {

    this.employeeId = employeeId;
  }

  /**
   * @return name
   */
  public String getName() {

    return this.name;
  }

  /**
   * @param name new value of {@link #getname}.
   */
  public void setName(String name) {

    this.name = name;
  }

  /**
   * @return surname
   */
  public String getSurname() {

    return this.surname;
  }

  /**
   * @param surname new value of {@link #getsurname}.
   */
  public void setSurname(String surname) {

    this.surname = surname;
  }

  /**
   * @return email
   */
  public String getEmail() {

    return this.email;
  }

  /**
   * @param email new value of {@link #getemail}.
   */
  public void setEmail(String email) {

    this.email = email;
  }

}

Result after GobiGen EmployeeEntity.java
package com.example.domain.myapp.employeemanagement.dataaccess.api;

import javax.persistence.Column;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;

import com.example.domain.myapp.employeemanagement.common.api.Employee;
import com.example.domain.myapp.general.dataaccess.api.ApplicationPersistenceEntity;

public class EmployeeEntity extends ApplicationPersistenceEntity implements Employee {

  @Column(name = "EMPLOYEEID")
  @GeneratedValue(strategy = GenerationType.IDENTITY)
  private Long employeeId;

  @Column(name = "NAME")
  private String name;

  @Column(name = "SURNAME")
  private String surname;

  @Column(name = "EMAIL")
  private String email;

  private static final long serialVersionUID = 1L;

  /**
   * @return employeeId
   */
  public Long getEmployeeId() {

    return this.employeeId;
  }

  /**
   * @param employeeId new value of {@link #getemployeeId}.
   */
  public void setEmployeeId(Long employeeId) {

    this.employeeId = employeeId;
  }

  /**
   * @return name
   */
  public String getName() {

    return this.name;
  }

  /**
   * @param name new value of {@link #getname}.
   */
  public void setName(String name) {

    this.name = name;
  }

  /**
   * @return surname
   */
  public String getSurname() {

    return this.surname;
  }

  /**
   * @param surname new value of {@link #getsurname}.
   */
  public void setSurname(String surname) {

    this.surname = surname;
  }

  /**
   * @return email
   */
  public String getEmail() {

    return this.email;
  }

  /**
   * @param email new value of {@link #getemail}.
   */
  public void setEmail(String email) {

    this.email = email;
  }

}

@Entity
@javax.persistence.Table(name = "Entity")

is missing in the merged file

current behaviour:

If the merge strategy is javamerge_override, property annotations of the patchfile are used.
If the merge strategy is javamerge, property annotations of the basefile are used.
The class annotations aren't changed at all, no matter whether javamerge_override or javamerge is used.
the expected behaviour
Obviously it doesn't make sense, to ignore the class annotation of the patchfile if javamerge_override is used as strategy.

Besides the previous point it becomes more complicated to define the expected behaviour. You might expect the merged file to contain all annotations, if the basefile has one annotation and the patchfile has another. For example:

basefile annotation: @Entity
patchfile annotation: @javax.persistence.Table(name = "vehicle")

that would cause problems for some annotations though. For example:

basefile annotation: @Entity(tableName = "vehicles")
patchfile annotation: @Entity(tableName = "vehicle", primaryKey = "id")

To solve these merging problems cobigen needs to know the semantics of the annotation and would therefore require the templates to offer mergestrategies for specific annotations.

Hey team! Please add your planning poker estimate with ZenHub @EduardKrieger @GuentherJulian @jan-vcapgemini @LarsReinken @mdukhan @MikeSchumacherCapgemini


Beatport plugin

According to http://beets.readthedocs.org/en/v1.3.10/plugins/beatport.html?highlight=beatport Beatport shut down their API. I'm not sure if you may have done this already, however they have an early sign up for their new API. A beatport plugin would be incredible as I have a lot of EDM tracks, oddball remixes and so on that only Beatport recognizes or has proper tags for.
The sign up is: http://developers.beatport.com/
There is also some interesting information about using the old API here: https://groups.google.com/forum/#!topic/beatport-api/zntW_B00_CM
I can imagine this is a pretty dead plugin that most don't care about, however if you have some free time to look into this, that would be great.
I apologize that this is not an issue, and you can by all means delete this after you've read it - I just wasn't sure where else to ask.

Thanks for the heads-up! I hadn't seen the new sign-up yet. I've now requested access. If I hear anything back, I'll reopen this ticket or create a new one and we can revive the plugin.

I've make Python functions that gets informations from Beatport search. But I fail to implement correctly in a beets plugin.
What can I do ?

How far have you gotten? Perhaps if you make your work public, we can pitch in and help.
Maybe the code for the old Beatport plugin would be a good starting point?

Yes I have read the old Beatport plugin and make a repository with my code :
https://github.com/tux-00/beets-beatport-plugin

OK! Can you let us know when this seems ready to merge back into beets mainline?

It seems to run but I need some informations.
How MusicBrainz can be disabled ? (When beets run in verbose mode I can't see if beets receives data from my plugin but he displays only MusicBrainz data)
Have I to display some text ? (For choices, data, ...)

You could consider logging some debug information (with self.log.debug('hello') in your plugin) to make sure it's working.
Your plugin does not need to print anything itself; the existing UI components take care of that.

Ok nice.
Must I use AlbumInfo class ? Because actually the plugin parse only track informations.
I can't see bpm, key or genre tags in TrackInfo or AlbumInfo. Is it normal ?

Must I use AlbumInfo class ? Because actually the plugin parse only track informations.

If you only match per-track information, then beets will only be able to tag individual tracks (i.e., in the importer's --singletons mode). That's probably fine for a 1.0 effort, but eventually it would be great to match entire albums.

I can't see bpm, key or genre tags in TrackInfo or AlbumInfo. Is it normal ?

Yes, you're right—at the moment, no source can provide that information, so we haven't added it to TrackInfo and AlbumInfo. But we could definitely do that if Beatport can provide that data.

Ok, thanks!
It works. But where can I get the query ? Because beatport founds the exact track but beets doesn't display the corresponding tracks.
Example:
File: Ben Sims - The Afterparty (Original Mix)
Item search terms: Ben Sims - The Afterparty (Original Mix)
My plugin search query: Ben Sims The Afterparty (Original Mix)
My plugin search function return: title: The Afterparty (Original Mix) artist: Ben Sims
Search URL: http://classic.beatport.com/search?query=Ben+Sims+-+The+Afterparty+(Original+Mix)
The first track that beets displays is a track from MusicBrainz with 94% of similarity.
If I want more results there is only one entry from beatport:
Simon Shaw - Ushuaia Ibiza Summer Edition 2014 - The Afterparty Mix (Original Mix) (47.6%) (title, artist, source) (Beatport)

Hmm, it's a little hard to tell what's going wrong without doing some debugging. Is the plugin at https://github.com/tux-00/beets-beatport-plugin in a state that I can try installing it and running this query in my own import?

Yes, I have updated the plugin and normally it can be run.

Awesome. I'll take a look soon.

I think I found the problem: beets tries to de-duplciate matches with the same ID. That means that, if two TrackInfo object have the same track_id field, only one will show up as a final match. So this problem should go away if you provide a unique value for track_id when constructing your TrackInfo objects.
Woohoo!

Ok I will take a look as soon as possible!

Ok, it works (test with a variable incremented by 1).
But what track_id should I send ?
When I look at beets/autotag/hooks.py, I can see:
"- track_id: MusicBrainz ID; UUID fragment only"
Should I send the ISRC of the track ?
Why beets founds 90.6% for Benjamin Damage - 010x while the search is Benjamin Damage - 010x (Original Mix):
Finding tags for track "Benjamin Damage - 010x (Original Mix)".
Candidates:
1. Benjamin Damage - 010x (90.6%) (title)
2. Benjamin Damage - 010x (Original Mix) (85.7%) (source) (Beatport)

Awesome!

But what track_id should I send ?

Good question—is there some Beatport-specific ID, perhaps a URL fragment, that one could (hypothetically) use to look up the track again later?

Why beets founds 90.6% for Benjamin Damage - 010x while the search is Benjamin Damage - 010x (Original Mix) ? :

I'm not totally sure, but some of it is probably from the source penalty, i.e., this line: https://github.com/tux-00/beets-beatport-plugin/blob/master/beatport.py#L22

Good question—is there some Beatport-specific ID, perhaps a URL fragment, that one could (hypothetically) use to look up the track again later?

Maybe the track URL ? Else there is nothing except numbers like "285282" but when I search on beatport he returns nothing.

I'm not totally sure, but some of it is probably from the source penalty, i.e., this line: https://github.com/tux-00/beets-beatport-plugin/blob/master/beatport.py#L22

Yes, I have removed this line and now beets send 100%. Nice! I need to add some options.
Is there a way to disable MusicBrainz ?
Can I send tags informations to beets after the user choice or before the process of tagging ? Maybe with this: https://github.com/sampsyo/beets/blob/master/docs/dev/plugins.rst#listen-for-events ?
Because I can't load 2 web pages by track result due to performance.

I'm not 100% sure! but can we find out somehow what ID is used in the API?

Is there a way to disable MusicBrainz ?

Not currently, no.

Can I send tags informations to beets after the user choice or before the process of tagging ?

No, beets needs the full information about each track before it performs the weighting and then presents data to the user. Sorry!
Perhaps we should actually open a new issue for the new plugin!

@tux-00 any recent updates on this? This would be an amazing plugin.

I have some informations from Beatport. The API is actually closed but it will be open soon. I don't know if this API will be open to anyone..


⚠ Lychee has degraded performance

In 0d2502c, Lychee ($SERVER_BASE/lychee/) experienced degraded performance:

HTTP code: 200
Response time: 10028 ms

Resolved: Lychee performance has improved in 5a655ed after 2 hours, 19 minutes.


Type Behavior needed for 'color' and 'texture' types

@codestar12  Possibly change spatial vectors to read vector(x, y, z) and the color vector to read vector(r, g, b) in the drop down so that it is clear that it is a vector but it is a different kind of data in the vector, and then the block changes color to be the same color as a color block, but you still attach a vector to it.


Bug fixes and speedup in the TV

bugfix: complex TV along 1 dimensions was wrongly assumed equivalent to real TV along real and imaginary part
bugfix: iterationsTV are passed from constructor to prox function
speedup in the iterative prox

@tknopp: should be fine to merge, just wanted a quick thumbs up from you.


Add OS2 table.

I don't see any resources/raw_tables/os2.txt in here, only a resources/codegen_inputs/os2.rs... I thought one was supposed to write the plain-text version by hand and the latter would be generated from that, not in turn hand-written. Am I missing something basic?

The intention is to start with the raw text version and then hand edit the generated file with the appropriate attributes. It’s probably best to think of the text files as a one time seed.

uh oh did I mess it up?
On Wed, Oct 19, 2022 at 8:57 AM Cosimo Lupo @.***>
wrote:

I don't see any resources/raw_tables/os2.txt in here, only a
resources/codegen_inputs/os2.rs... I thought one was supposed to write the
plain-text version by hand and the latter would be generated from that, not
in turn hand-written. Am I missing something basic?
—
Reply to this email directly, view it on GitHub
https://github.com/cmyr/fontations/pull/56#issuecomment-1284238888, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AK5GJQSEUJZIAUGIUJCZPB3WEALALANCNFSM6AAAAAARHQO4M4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Andrew John, Google Fonts

You can think of the preprocessor as an optional step, that saves time in many cases. The only other argument for it is that, by working directly from the text of the spec, it makes it difficult to accidentally overlook fields.

panose_10 should just be panose. The _10 seems to be a result of parsing the [10] array declarator


[Push Notifications] Mobile iOS Set Home Icon screen is missing

Describe the bug
For iOS devices only, we wan to show this Add to Home Screen UI This is a modal which should appear before the Enable Push Notifications Modal.

@charleslavon What is this task about? I just need to add an icon? Is this related to this PR?


Better formatting in sidebar search

See screenshot.
It's quite difficult to make out the lines of code from the filenames, would appreciate if the whole filename line was in bold or had background colour, so I can more easily skim the results.

This would be a huge help - I'm currently scanning some .eex results which have a generic low-contrast icon, making it even harder to distinguish which lines are filenames and which lines are code.

Yes! The filename row should be bold. Currently, this significantly reduces the usability of search.

If you do "Open in editor", it displays the results beautifully formatted in a text editor.
Would be great if there were an option for this to be the default search results format.

Yes, I have been looking for this feature as well

@jpike88 Hey there! Completely share your sentiment. I searched for this issue and found it. The search panel is broken, you can't make sense of the results by skimming through it!
But could you make the title more precise, reflecting the main problem with the sidebar? Like "Snippets in sidebar search results visually blend with filenames". "This specific thing is broken" kinds of issues receive more attention than "Make this thing better" kinds of issues.


Dead Repository

is this currently being updated, is there some more active fork for users to pull from?
what's the deal?

Hi @Giovani-Brady,
This is not being updated anymore -- you should use one of the other Stripe .NET libraries available on NuGet. We're still using this library internally, but have not had time to update it for new Stripe API features.
Best,
Bojan


⚠ Bofrost.fr has degraded performance

In 0e44293, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2290 ms

Resolved: Bofrost.fr performance has improved in 6984024.


Normalization of answer coalesce output clears out some result data

there is a value that is being blanked out during the normalization process.
the two files were created using answer coalesce. one run had normalization enabled, the other didnt.
in the file "ac_out_no_node_norm" search for "extra_qn_3" in the results/node_bindings data and note that is an array that has a value ({"id": "CHEBI:50858"}). in the file "ac_out_with_node_norm" look for the same item above and note that it is an empty array.
ac_out_no_node_norm.json.txt
ac_out_with_node_norm.json.txt

Is this complete? Can it be closed?

yes, this can be closed


New client-side retry design

Implements connection retries at the socket level, making it easier to do authentication & re-authentication.
Closes #51
Closes #52

Current dependencies on/for this PR:

main

PR #59   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 19, 9:46 AM: @mempirate started a stack merge that includes this pull request via Graphite.


add Sylva to ADOPTERS

Metal3 is a core building blocks of Sylva, and we would like this to be visible in Metal3 community.
Many thanks.

/ok-to-test

/lgtm


Test-DbaSpn returns wrong result from Azure IAAS SQL Server

Is this a feature OR bug:
bug
System Details

Operating system name and version:
Windows 10 Enterprise 10.0.14393

Output from $PSVersionTable:
PSVersion                      5.1.14393.693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Output of dbatools version:
0.8.707

SQL Server version for source/target
all SQL2016

Steps to Reproduce
Test-DbaSpn -ComputerName SQLOnAzure
Action Results
[InstanceServiceAccount] returns "NT Service\MSSQLSERVER"
which is wrong, the service definitely runs under a domain account
[RequiredSPN] is empty
which results in an error from Set-DbaSpn when piped through
This happens on all 3 SQL Servers in Azure IAAS,
and on none of 16 SQL Servers on premise, 2 physical + 14 on VMWare
Expected Results
[InstanceServiceAccount] should return the correct Account
[RequiredSpn] should return an SPN

@drewfurgiuele any news on this?

Sorry @PowerDBAKlaas I was out sick yesterday; I will be working on this in the coming weekend.

SPNs in Azure SQL are not treated the same as on-premise because Azure manages the DNS objects, and you are using AzureAD. So I don't think we can fully support this using setspn unless there is code available in Azure's API that can be used. Which will cause external resources.

how should we handle this knowing what @wsmelton has told us?

I think it should warn or return $null or 'unknown', but never return wrong results.

Is this still an issue? I was able to run this with no issue in 0.9.197.

I can't test this anymore. don't have access to those servers any longer.

My test scenario was an IaaS VM in Azure, installing SQL Server, and joining to a traditional AD domain. Does that match up with what you were doing?

Yes, that must be quite the situation I had.


Recommend coordinate format for current location

[ ] Indicate which coordinate format(s) are used in the current region

Not going to implement.

Frequency of use (ex. edge case) vs effort to implement


Gradle: cleanup dependencies between subproject

In #1350 we introduced a subproject configuration for Gradle.
There appear to be some dependencies in dungeon to resources in game. Do we want to keep it that way or should we resolve this so that each subproject uses its own resources?
(In the JAR, all resources are packaged together.)
see comments https://github.com/Dungeon-CampusMinden/Dungeon/pull/1350#pullrequestreview-1883478138 and https://github.com/Dungeon-CampusMinden/Dungeon/pull/1350#pullrequestreview-1883480491

Überwiegend in #1350 erledigt, follow-up Issue ist #1426: Der Zugriff auf die Assets ist noch nicht sauber (genug).


[Wait for #1964] [Wait for #1993] [unittest] generate transformer unittest

 - Generate transformer encoder layer unittest
 - Generate transformer decoder layer unittest
 - Generate transformer unittest

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1996. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Fix various issues with hostname and client id

For some reason, the determination of whether to send the Hostname option on
Discover and Request mesages was based on whether
config.use_host_name_as_client_id was set.  However, using the hostname as
the client id has nothing to do with whether the Hostname option should be
sent or not.  We now always send the Hostname option if it was set.

Added a check to use_host_name_as_client_id() to make sure we don't set
client_id to just [0] if hostname hasn't been set.

Added a new set_client_id(client_id_type: u8, client_id: &[u8]) function
to explicitly set the client id.

Updated integ_tests/env.rs to parameterize the creation of the dnsmasq
options.

Updated test_dhcpv4_manual_client_id to check that set_client_id() set
config.client_id correctly.

Updated test_dhcpv4_async to check that use_host_name_as_client_id() doesn't
set config.client_id if set_host_name() hasn't been called yet and to check
that set config.client_id correctly when set_host_name() and
use_host_name_as_client_id() are called in the proper order.

Resolves: #37
Resolves: #38
Signed-off-by: George Joseph<EMAIL_ADDRESS>

FYI... I have a PR open at containers/netavark (containers/netavark#1130) that needs this PR.

Is there some trick to getting the tests to run successfully?  I always get ....
$ sudo cargo test test_dhcpv4_manual_client_id -- --test-threads=1 --show-output
...
dnsmasq-dhcp:<PHONE_NUMBER> sent size:  2 option: 26 mtu  1492
dnsmasq-dhcp:<PHONE_NUMBER> sent size:  8 option:  6 dns-server  <IP_ADDRESS>, <IP_ADDRESS>
fatal runtime error: IO Safety violation: owned file descriptor already closed
error: test failed, to rerun pass `--lib`

Caused by:
  process didn't exit successfully: `sudo -E /usr/src/podman/mozim/target/debug/deps/mozim-a3fbee7a78c34c8c test_dhcpv4_manual_client_id --test-threads=1 --show-output` (signal: 6, SIGABRT: process abort signal)

Since I can now get the tests to run without crashing, I discovered an issue with the tests when all 3 are run together.  The last force-push fixed that and also parameterized the creation of the dnsmasq options to reduce the chance of typos in various places where some of the constants were used.

@cathay4t I believe you are the maintainer yes?  Any idea when you might be able to look at this PR?  I have a PR open at containers/netavark (https://github.com/containers/netavark/pull/1130) that needs this PR.
Thanks.

@gtjoseph The fix has been shipped in mozim 0.2.5. Thanks for the help!


hasActionInput always resolves to true because INPUT_ is set from Action meta

Unfortunately INPUT_ is set by merging the Action inputs with the step inputs, using an empty string as the default.
https://github.com/actions/runner/blob/be9632302ceef50bfb36ea998cea9c94c75e5d4d/src/Runner.Worker/ActionRunner.cs#L189-L202
// Merge the default inputs from the definition
if (definition.Data?.Inputs != null)
{
    var manifestManager = HostContext.GetService<IActionManifestManager>();
    foreach (var input in definition.Data.Inputs)
    {
        string key = input.Key.AssertString("action input name").Value;
        validInputs.Add(key);
        if (!inputs.ContainsKey(key))
        {
            inputs[key] = manifestManager.EvaluateDefaultInput(ExecutionContext, key, input.Value);
        }
    }
}

I think the only option is to treat an empty string as null by default with an option (like allow-empty-strings: false or empty-to-null: true) that controls the behaviour for the rare circumstance in which someone needs to specify an empty string.

Closed by #58


Add notes, fix typos in 02_pytorch_classification

Thank you for this!
As for notes, do you mind putting them directly in the issue? That way we're not adding extra files to the repo.

In the plot_decision_boundary function, why use X = X.to("cpu") instead of X.cpu()?

No reason for this, will change.

Since softmax maps large numbers to large probabilities and small numbers to small probabilities, to my understanding, it is better to predict directly using torch.argmax without going through softmax, as softmax is a relatively costly operation. Of course, if we're interested in the probabilities (to show confidence or top-k predictions), softmax should be used.

You're right here too, torch.softmax used for showcasing probabilities as a use case, going to show just torch.argmax as well for inference.

No problem, future PRs will have the notes inside the description 👍

Thank you!

Update on .to("cpu"), with regards to:

In the plot_decision_boundary function, why use X = X.to("cpu") instead of X.cpu()?

Decided to keep X = X.to("cpu"), it's more verbose but keeps it inline with the use of .to() previously.
Can use .cpu() in future.


fix: 🐞 readme theme fix and move correct folder

Looks good: https://github.com/OpenTRFoundation :D


Breaking out of setup leaves you in a limbo state

installed desktop client
did not complete setup (hit back button)
tried to login again to complete it later
Error: "There was an error provisioning" "Unknown error: Provision transaction already in progress"

my log id: bd6369aaed3ff1f4a95ebe1c

Cc: @patrickxb


A+C: add sbinet

added the little blurb to doc.go.
it's silent about all the changes that happened between v1.1.0 (aka 7a63cd7) and now.
you probably have a better idea about what needs to be mentioned there?

BTW, seems I've actually used tags before, just forgot about it completely. Or I'm confused by releases vs tags.

Or I'm confused by releases vs tags.

Github creates a tag on that commit when you make a release.

yeah, github will do that for you (creating a tarball with the vX.Y.Z tag).
I don't have commit privileges to directly commit this to origin/master (so I don't think I can tag and push that tag to origin either) but I can push the "Merge pull request" button if you want :)

(Strike that, I can...)


need assistance with pausing instead of stopping

I'm setting up kodi to use in a nursing home for people with dementia. All the videos I'm playing are youtube playlists, because addon timers doesn't work directly with the youtube plugin, I add the media link into the timers.json
The system is configured to be used with a very simple remote control. The power button controls play/pause, and the tv automatically turns off when idle.
I'm trying to set timers so that there are playlists set for certain times, but I also want residents to be able to decide when to watch. For example: -playlist starts at 8:30 after breakfast. I want to be able to set times where playback pauses for lunch, snack breaks, afternoon nap, dinner, and bed. I can set it so that the youtube playlist stops at those times, and set a timer for another playlist to pick up, but then the video is stopped, and the resident has no way of reactivating it until the next playlist starts. Is there a way to set pause as the end state of a playlist? Can I set a 'pause' timer that overlaps with a playlist that otherwise goes through the day? Under 'media_action' in timers.json can I set a function to press a key?

Hi @siennamediatest,
I'm glad to hear that my addon is used for such senseful use cases.
I've understood that you want to pause a playlist for a certain period, resume it after some time. Have you already thought about using another timer that plays something that is silent and or a gong sound.
Timer 1      |>>>>>>>>------------------->>>>>>>>>>>>|              Timer with youtube playlist
Timer 2               |>>>>--------------|                          Timer with another playlist or single title (maybe just silence)
      t |----t1-------t2-----------------t3----------t4-------->

Global setting
Misc > Seek to correct time if timer starts belately -> on
Settings of Timer 1

end after -> time or duration
media action --> play at start and stop at end
resume -> on

Settings of Timer 2

end after -> time or duration
media action --> play at start and stop at end
resume -> on
repeat -> on

I have tried this solution. I works at least for normal media. I was not able to test it for youtube playlists.
Maybe you can send me the URL of the youtube media that you want to play.
BTW: In order to see the resume setting you must change to advanced mode in settings dialog.
Best regards,
Heckie

Thanks a lot for your response! I hadn't considered playing different material, and that actually opens up some interesting possibilities of displaying landscapes/weather info/clock information/family albums.

Fine, I'm waiting for your feedback if this works for you finally.

I found a different method, and have implemented gpio buttons on the device to trigger a timed break. I'm having another issue and I think you might know what I'm doing wrong. I'm trying to set up a gpio button that triggers a youtube playlist through the youtube addon. I'm got the button working and have it trigger xbmc.executebuiltin("RunPlugin(youtubepluginplaylistpath)"). It works sometimes, but mostly crashes kodi.
With your plugin, youtube playlist is triggered perfectly if I put plugin://plugin.video.youtube/play/?playlist_id=PLopMpzJBXsBRXEqODSoiDxCI2QvEPR1mB&order=shuffle&play=1 in the timers.json file under path. Looking through your addon, it looks like you have an external player set up?

I think that the Timer addon calls YouTube like this:
PlayMedia("plugin://plugin.video.youtube/play/?playlist_id=PLopMpzJBXsBRXEqODSoiDxCI2QvEPR1mB&order=shuffle&play=1")
Instead of utilizing RunPlugin
see also Line 62ff in https://github.com/Heckie75/kodi-addon-timers/blob/master/script.timers/resources/lib/player/player_utils.py


support using failpoints from unit tests without requiring serial test execution

Is your feature request related to a problem? Please describe.
Currently failpoints cannot be used from tests without requiring all the tests that hit failpoints to be executed serially. This essentially prevents us from using failpoints from our unit tests without forcing tests to run with a single testing thread. The suggested approach is to place failpoint tests under the tests tree so that they are executed as rust integration tests. However, this means that the tests cannot use any interfaces that are not exposed by the crate, which makes it difficult to write most of our test cases.
Describe the solution you'd like
The reason for this restriction is that failpoints uses a global failpoint registry to control fault injections. It would be nice if there were a way to set up failpoints so that they could use a test-specific registry. One approach to doing this is to support specifying the failpoint registry in calls to the fail_point! macros, e.g.
let registry = <construct or accept a passed in failpoint registry>
fail_point!(&registry, "fail-a-thing", |_| std::io::Error::new(...))

Describe alternatives you've considered
We considered running tests serially and moving our fault tests to tests. Running tests serially might work for now, but could lead to longer build times later. The bigger problem is that it causes tests to fail by default, so developers in our project would always need to remember to run tests with a single thread and configure their ide to do the same, which is painful. Putting tests in tests is not ideal because it requires us to expose a lot of interfaces from our crate that we don't want to to write the tests we want to write.

See also #51. In TiKV, we solve this by splitting test cases into different groups and launch the multiple process to run those test group concurrently. Test case in the same test group is run sequentially.

@BusyJay I see #51 is still open. Two questions:

Any docs or pointers on how to split into groups?
Will this work for module unit tests in the same .rs file, not just integration tests in tests?

The reason I ask (2) is because we have some APIs we want to test but not expose publicly.

Any docs or pointers on how to split into groups?

No, it's just some scripts.

Will this work for module unit tests in the same .rs file, not just integration tests in tests?

Yes. We used to manually collecting built test binaries and list all available cases. Now we use cargo neatest to make the process more maintainable. You can find all the steps in https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Fpull_unit_test/detail/pull_unit_test/995/pipeline/71, build step and test step specifically.

Any interest in taking a PR that allows users to pass a failpoint registry in rather than use the global?

Here is our forked repo, for reference:

https://github.com/slatedb/fail-parallel

And here's the actual commit that adds registry parameter support:

https://github.com/slatedb/fail-parallel/commit/f7f020aceecf3eff6794a149ba7297de4010d1e3

Now users may supply a registry when the call various fail_point/cfg/etc methods. Doing so will use the supplied registry instead of the static REGISTRY.


installation: upgrade problem with invenio_2012_11_27_new_selfcite_tables

Originally on 2013-01-16
While running the upgrader in Inveniocfg on invenio_2012_11_27_new_selfcite_tables, the following error happens if the tables are already created:
$ inveniocfg --upgrade --yes-i-know
>>> Following upgrade(s) will be applied:
>>>  * invenio_2012_11_27_new_selfcite_tables (New selfcite tables)
>>>  * invenio_2012_10_31_tablesorter_location (Standardisation of the jQuery tablesorter location)
>>>  * invenio_2012_12_11_new_citation_errors_table (New rnkCITATIONDATAERR table)
>>> Running pre-upgrade checks...
>>> pre_check_bibsched: Checking bibsched process...
>>> Calculating estimated upgrade time...
>>> Applying invenio_2012_11_27_new_selfcite_tables (New selfcite tables)
Traceback (most recent call last):
  File "/home/jlavik/envs/inspire/bin/inveniocfg", line 33, in <module>
    main()
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/invenio/inveniocfg.py", line 1564, in main
    cli_cmd_upgrade(conf)
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/invenio/inveniocfg.py", line 1292, in cli_cmd_upgrade
    cmd_upgrade(conf)
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/invenio/inveniocfg_upgrader.py", line 900, in cmd_upgrade
    upgrader.apply_upgrade(u)
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/invenio/inveniocfg_upgrader.py", line 488, in apply_upgrade
    upgrade['do_upgrade']()
  File "/home/jlavik/envs/inspire/lib/python/invenio/upgrades/invenio_2012_11_27_new_selfcite_tables.py", line 50, in do_upgrade
    """)
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/invenio/dbquery.py", line 202, in run_sql
    rc = cur.execute(sql, param)
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/MySQLdb/cursors.py", line 176, in execute
    if not self._defer_warnings: self._warning_check()
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/MySQLdb/cursors.py", line 85, in _warning_check
    warnings = self._get_db().show_warnings()
  File "/home/jlavik/envs/inspire/local/lib/python2.7/site-packages/MySQLdb/connections.py", line 317, in show_warnings
    self.query("SHOW WARNINGS")
_mysql_exceptions.ProgrammingError: (2014, "Commands out of sync; you can't run this command now")
Exception _mysql_exceptions.ProgrammingError: (2014, "Commands out of sync; you can't run this command now") in <bound method Cursor.__del__ of <MySQLdb.cursors.Cursor object at 0x232a9d0>> ignored

I'd suggest to update the upgrading script to first check if the tables are created. Removing or copying the tables fixed the problem locally on my DEV-box, but it is perhaps not a nice alternative on production machines.

It looks like it was addressed as part of 92c42da899d0d9fc706b5df8b090fe397e85eb06.
--
cc @inveniosoftware/triagers


[SR SQL Planner Summer Camp]  Support ShowTransactionStmt for new parser

Could you use the PR template, and it will be more clearly about the PR. Thanks


Created SPI for allowing SDK users to apply initialization steps

This will fail:
seahorse-workflow-executor$ sbt -DSPARK_VERSION=2.0.0 test
SqlTransformationIntegSpec.scala:66: value getFunction is not a member of org.apache.spark.sql.catalog.Catalog
[error]       val fun = sparkSQLSession.getSparkSession.catalog.getFunction("myOp")


Different emails notification

Questions
Answers

Description?
Differentiate admin receivers for the different options in the module (new order, out of stock, and new return opened). With this PR you can specify different e-mails for each option.

Type?
improvement / new feature

BC breaks?
no

Deprecations?
yes (MA_MERCHANT_MAILS configuration)

Fixed ticket?
Fixes PrestaShop/Prestashop#23745.

How to test?
Release test?

This improvement/new feature needs new hook, I've added an upgrade file and I supposed a 2.4.0 version due the behavior changes and different Configuration(s) fields.
Let me know if we need to split this in two PRs, or if is a simple patch version 🤔
Small preview:

@kpodemski @atomiix Thanks guys for your tips, I've applied your suggestion and cleaned the commits 😊

Hello @marsaldev
Is there any missing informations in how to test block, because I can't see the new emails input for every option 😞 Check my screen record below:
pr_109.mp4
Waiting for your feedback. Thanks!

Hi @hibatallahAouadni, sorry, but the last suggested change by @atomiix broke the functionality of js (showing and hiding the inputs) 😊
Now it's fine, but I think need a recheck from maintainers.

@marsaldev thanks for your quick fix :rocket:

Sorry, gently reminder @hibatallahAouadni
Because I see the label waiting for author 😊

Hello @hibatallahAouadni
I think this tag design is only on pages using PrestaShop UI component which is not the cause for this module
To be confirmed by @NeOMakinG

This Fix Work Fine, but how to have different quantity Threshold for all products ?

Hi @micka-fdz

You missed several references to MA_MERCHANT_MAILS and $this->merchant_mails. Can you please remove them?

Yep, I'll do another PR to clean up some code (they're irrelevant for the future functionality) 👍🏻

I think we can also hide "Threshold" field when previous checkbox isn't checked. What do you think?

Agree 👍🏻

Hello @marsaldev

Except for the tag issue (we can improve it later)

It seems we have the PM @MatShir approval, to add the feature that I asked for it in another PR :tada:
So if you didn't add any other commit to this PR, it's good to me :wink:
PS: ping me to add the QA :heavy_check_mark: label or to restest the PR again :pray:
Thanks!

Hi @hibatallahAouadni,
no other commits, and I wont add any more for this PR 😊
I'll open a new issue, and a PR, to refactor this module

Thanks @marsaldev & @hibatallahAouadni & @MatShir


Feature Request - Command Line Option to Only Connect if Cert is OK

Right now, if there is an unknown cert, there is a prompt to add it (y/n).
This is problematic for scripting, because freerdp gets stuck here.
I would request that we define a new error level for "Unknown Signer" or something and also a command line option --require-trusted-cert.
If --require-trusted-cert is there, then freerdp should not prompt, and instead just exit with the errorlevel for "Unknown Signer".
... if there are other error conditions I'm not thinking about that would be better error levels, that is fine too.

The option switch for this exists now, closing the issue.


Open source contribution feature

Why this feature is required ?
This feature will help the open source contributors to browse the projects of Algo phantoms directly from features section. This will greatly help  Those students who not only wants to improve their DSA skills but also want to contribute to the project.
HI, I am a GSSOC21 Participant and i have already implemented this feature in my local machine  , Please assign this issue to me so that i can create a PR.
Thank You

Someone already raised issue on this.
You can work on different issues @nasir-khan01


Respect the maxBatchSize setting of queue consumers

Previously we'd send along arbitrarily large batches to the consumer.
Fixes https://github.com/cloudflare/wrangler2/issues/2295
@OilyLime @jbw1991

Thanks @OilyLime! cc @mrbbot for review as well


Check for recently uploaded backups before upgrades

I saw in the comments an old reference to look at sensor.backup_state, so I checked it out. Provided by the Google Drive Backup addon, and I thought it was pretty valuable. I have the backup addon configured to backup daily with Google Drive uploads, and figured a "best case" scenario is actually to check the recency of the latest backup in Google Drive! The sensor only seems to expose the latest backup from the backup addon itself, from what I can tell, and doesn't specify what type of backup is performed, both of which are flaws I'd say, but this still provides some excellent value.

My challenge here is the fact that this sensor is only available for Google Backup add on. I know the Samba backup also have a sensor like this (with a different name, etc.), but there's no universal solution for that.
Maybe we can have an input of users to select which backup solution they want to monitor and we adapt the routine based on that...


plugin not working every file is returning undefined

please use the latest version of the plugin
make sure you can open this page (http://www.javascriptobfuscator.com/Javascript-Obfuscator.aspx) in your web browser
check your JS code
if the problem still exists, it might be the javascriptobfuscator.com server was down for a moment (so service was unavailable)

I have tested the plugin and it still works:
./bin/jsobfuscate gruntfile.js

I am using the latest version of plugin.
File contains very basic js code same as in readme file.
I can access the above link in my browser but still it it retrunng undefined.
in your function getResult i can access the body.but after resolving the complete res.body is not there.

If getResult returns undefined, that means javascriptobfuscator.com does not respond with a web page containing textarea named ctl00$breadcrumbs$TextBox2 (that textarea is expected to contain the obfuscated JS code).
I have never seen this before. The code currently does not handle this situation. If you can, please submit your code to http://www.javascriptobfuscator.com/Javascript-Obfuscator.aspx and then post the HTML code of the result page.

I have the same issue today. I am running the toll via a shell script.
jsobfuscate -o replaceNames=false src.js > dst.js
I can reach the  (http://www.javascriptobfuscator.com/Javascript-Obfuscator.aspx) in my web browser and can ping it as well.
There is no log information to find out whats happening. How can I debug the issue?

Have you tried the latest version? The plugin was just updated to 0.1.2.

The issue is resolved now. It was because the latest version also requires a newer version of Node. Mine was 8.1.4, upgraded it to 8.6.0 and it started working again.


Fix for matplotlib 3.3

This PR:

master (from the rendered notebook in the repo assuming it is enough up-to-date)

and the CI passes, so merging this one.


fix tooltip language in subflow

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
Because the tooltip language in customUI of subflow was "en-US","ja","de"...,
I modified them to become "English", "Japanese", "German".
I also changed the width 50px to 120px, because "Chinese(Simplified)" overwrapped with Label area.

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Hi - thanks for raising this.
The choice of using the language codes was intentional to keep it compact, so this is a design change rather than a bug-fix.
Can you explain why you think it should have the full language name?

Because User Setting and the bottom of the properties  are written  by the full language name,
I think it is better that this tooltip is also written by the full language name,
I think the same expression is good for user experience.
(I signed CLA yesterday after PR, I’m sorry.)

I think that beginner Node-RED users aren't familiar with language code. In my opinion, the compact tooltip looks good but it's better to use full language names which are same as bottom menu.

I signed CLA but email address was diffrent from when I commited. I fixed it.


CAMEL-10679

Producer does not populate attachments from response.
I would think of refactoring the whole part of the response handling.
In my opinion it would be best to handle this the same way as the BasicMessageFilter does this for the request message.
This way anyone could implement custom behaviour if neccessary.
I would have done it, but i didnt want to break anybodys code, so i just implemented it the same way the headers are populated.
Feel free to contact me about the change.

Hello @marcusmesserkewill ,
Can you please open an PR against master and not 2.18.x? We'll eventually backport the fix, but since this is a new option, first we need to merge on master.
Thanks.

Yes sure, no problem.
I will close this one and make a new PR.


html tags in email text

@Didayolo
we need to test this on test server. I think this change should fix the issue
How to test:
Send an email to a participant with text:
**bold** [link](https://codabench.org)

Participant should receive:
bold link
Participant should not receive:
bold link

Why I think this is fixed?
Before the fix, I see the following in the django logs:

<strong>bold</strong> <a href="https://codabench.org">link</a>

after the fix I see this:

bold link

If this fixes the problem, then I will cleanup and add some comments

The mail service from the test server seems to have a problem.

I sent an email from codabench.org it worked
I sent an email from codabench-test.lri.fr it did not work

Linked issue:

#930

@ihsaan-ullah
With<EMAIL_ADDRESS>it does not work:

I think we need to create this email<EMAIL_ADDRESS>associated with the domain codabench-test...
But we can still test this fix right?

Yes, we can still test the fix. I'll do it. The mailing problem is simply a configuration problem of the test server.

Tested on production and it works!

Tested on production and it works!

nice. I am closing the related issue


Ordering of IndexLocation within MultiIndexLocation

Within the ARMI framework and ARMI ecosystem it is unclear if we have actually set a requirement for the ordering of locations in the grid system competely. I think that getRingPosFromIndices on the HexGrid class attempts to do this though for at least the treatment of hex cores and pin layouts (not sure about Cartesian)
The reason for this ticket is to communicate that a HexBlocks method for auto generating a spatial grid (for pins) does not appear to function the same (i.e., provide the same ordering) as if a user was to implement their own lattice map within the blueprints.
This can be impactful because we have pin-level data that lives as an array or a list on the block parameter system. The order of data of these arrays assumes consistency with the block's pinLocation parameter and this pinLocation parameter when filled out appears to just be a list of integers that go from [0, ..., N].
0 is typically considered the central pin and would correspond to the IndexLocation(0, 0, 0). When we access the MultiIndexLocation class on a block (i.e. b.spatialLocator), some code has the expectation. That index 0 of the pinLocation array would give an integer such that the integer it provides can the index in the MultiIndexLocation, which returns the correct IndexLocation and is therefore associated with the correct local/global coordinates (i.e., an X, Y, Z point in the core)
I think that fixing the ordering of the _locations attribute on the MultiIndexLocation class would be the cleanest solution. We don't want to force all the code, in my opinion, to create and add IndexLocation objects to the MultiIndexLocation, but on retrieval if these were sorted based on the grid (like HexGrid).
I'm not sure exactly how pinLocation is populated without starring at the code a bit more, but I think that this should be consistent with the underlying grid system too. We don't often to this yet, but the entire pin rotational functionalities should probably be looked at very carefully and see if we can bridge the gap between how it current works with the pinLocation array and how it could work if we used the underlying grid system to do this work.
What are your thoughts @john-science and @ntouran? This might be causing a bug in pin power assignments and more eyes on it would help I think.

An example of the correct ordering:

An example of the incorrect ordering:


What limitation on AsyncStorage?

I try to load the large volume of data, but AsyncStorage throws warning what database or disk is full.
Have Any ideas?

6MB on Android, indefinite on iOS: https://stackoverflow.com/questions/32875726/how-large-is-asyncstorage-in-react-native/

What to do in this case with Android?

You could write your own storage implementation. That's one of the features of React Native.

What is the motivation for the size limitation on Android?


File size limit exemption (tensorflow-rocm)

Hi,
We would like to host the ROCm-targeted port of TensorFlow on PyPI.  However, we hit the 60MB limit when trying to upload to test.pypi.org.  In the meantime, we have created placeholder 0.0.1-versioned projects for tensorflow-rocm on both Test PyPI and PyPI.
Details:

Project name:  tensorflow-rocm
Size:  114 MB initially, but could eventually be more
Indexes:  both Test PyPI and PyPI

For some context, the builds for tensorflow derivatives tend to be reasonably large.  For example, the tensorflow-gpu package is in the range of 100-200+ MB.
Please let us know how to move forward.
Best,
Jeff

I've increased the limit for tensorflow-rocm on both PyPI and TestPyPI to 200MB.
Please try to be conservative with how often you make new releases (i.e., don't push nightlies).

Sure, no prob.  Many thanks.


Acer X34P Sound Volume change does nothing, while contrast and Brightness work well

Checklist

[x] I have searched for existing issues
[x] I have looked through the Monitor Troubleshooting wiki
[x] I have updated MonitorControl to the latest version

Describe the issue
Acer X34P Sound Volume change does nothing, while contrast and Brightness work well.
Expected behavior
Changing volume should control the monitor volume
Additional context
Connected using Thunderbotlt 3 to Display Port adapter
Environment Information (please complete the following information):

macOS version: Latest released Catalina 10.15.6
MonitorControl version: Latest released 2.0.0
Monitor(s): X34P
Mac model: Mac Book Pro 2018
Monitor Cable(s)/Connection(s): (e.g. DisplayPort) Thunderbotlt 3 to Display Port adapter

I believe this is monitor firmware bug, reported it as well in acer communities:
https://community.acer.com/en/discussion/620010/control-sound-volume-in-monitor-x34p-from-windows-mac-via-ddc-with-tool-such-as-monitorcontrol#latest

Any fix available?

Hi,Please open case directly with Acer support, we need enough votes/pressure to fix this.Cheers!On Jul 30, 2021 12:08 PM, Vincent Cox @.***> wrote:
Any fix available?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for the advice, but they’ll never going to update firmware of an 5+ years old monitor (in my case the acer X34a).
https://eqmac.app/ Worked for me.
I prefer this project and app (ui and design), but the other app can be used as free as well and has it working for me.
No hard feelings towards this, I love this project but in my very specific case that other app is my only working solution.

On 30 Jul 2021, at 13:08, wojciechczyz @.***> wrote:

Hi,Please open case directly with Acer support, we need enough votes/pressure to fix this.Cheers!On Jul 30, 2021 12:08 PM, Vincent Cox @.***> wrote:
Any fix available?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Were you able to control audio volume on Mac with this other app?Thanks!On Jul 30, 2021 1:19 PM, Vincent Cox @.***> wrote:
Thanks for the advice, but they’ll never going to update firmware of an 5+ years old monitor (in my case the acer X34a).
https://eqmac.app/ Worked for me.
I prefer this project and app (ui and design), but the other app can be used as free as well and has it working for me.
No hard feelings towards this, I love this project but in my very specific case that other app is my only working solution.

On 30 Jul 2021, at 13:08, wojciechczyz @.***> wrote:

Hi,Please open case directly with Acer support, we need enough votes/pressure to fix this.Cheers!On Jul 30, 2021 12:08 PM, Vincent Cox @.***> wrote:

Any fix available?

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

—

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or unsubscribe.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

@wojciechczyz it's not adjusting the volume on the screen itself, but the master out volume to the screen. Entirely different things, i know, but in my case it was sufficient. I just put the volume of my screen on 60% and adjust the master out to the screen if needed.

Hi, with displays that has problems with volume control, I recommend eqMac or SoundSource (these are software solutions and do not control the amplifier inside the display). Since there is no much we can do with this on MonitorControl's side, I'll close this issue for now. Please feel free to comment anyway if you feel that we can be of any help with this! Thank you!


Compute morphing on GPU #4999 breaks bones

hi,
#4999 breaks renderables with bones
samplerBindings has nullptr entries, which crashes when accessed later:
https://github.com/google/filament/blob/8d1402d37b0b87cc64ef64550b1f000b9b0a16fd/filament/backend/src/opengl/OpenGLProgram.cpp#L274
I can reproduce it with opengl backend on windows with unmodified gltf_viewer and an animated model from gltf sample repro, such as BrainStem.gltf

Hi it will be fixed by #5036.

Hi it will be fixed by #5036.

Can we make a separate fix? I think #5036 might take some time to be merged.

Hi it will be fixed by #5036.

Can we make a separate fix? I think #5036 might take some time to be merged.

No problem. #5060 is created.


Marriage Pact + Valar

When I Valar and have a Marriage Pact on my char (who then dies to the Valar), the opponent is prompted to sacrifice a character only after Valar has resolved. I have been told it should be timed such that they can sacrifice something that is going to die to Valar for the Marriage Pact?

Thanks for the report. Per the FAQ for Marriage Pact on ThronesDB and the general rules about kill, that ruling is correct - the owner of Marriage Pact should sacrifice a card before the simultaneous kills take place since it's a forced interrupt to leaving play and the thing triggering the leave play hasn't fully occurred yet (i.e. the kill).
This bug would also extend to if the character with Marriage Pact were sacrificed (e.g. Fallen from Favor), or discarded from play (e.g. Marched to the Wall). It just happens to matter a lot more during Valar since it allows the Stark player to avoid a kill.


Add connect to rainbow button

Describe the solution you'd like
Add a new wallet option in the wallet select model for the Rainbow wallet. When the button is clicked just use WalletConnect.
Some inspiration for how to style it:
https://christianbaroni.github.io/rainbow-buttons
https://github.com/rainbow-me/rainbow-button
Additional context
Mike Demarais from https://rainbow.me requested this feature. They've been a huge supporter of the coop and show the DPI prominently on the dashboard of their wallet.
Rainbow wallet connects via WalletConnect. They've been trying to get dapps to create a special "connect to rainbow" button which is just WalletConnect under the hood with their logo slapped on it.

I would like to take this.
Discord name: Don | ETH to 10k#3452


0.10.2 unreleased

The 0.10.2 release fixes quite an important bug related to working with the latest Grape, but it's not yet on Rubygems.
Would you please push the gem when you got time?

There's some discussion in https://github.com/tim-vandecasteele/grape-swagger/pull/280 that I'd like to clear before cutting this release. Maybe you want to pitch in?

I've released 0.10.2.

yay, thanks!


Add capabilities using parsing methods

This change adds a few capabilities to the skewer that are either not possible or difficult to extract from ARM ResourceSKU API. It uses parsing method on sku.size as described here - https://learn.microsoft.com/en-us/azure/virtual-machines/vm-naming-conventions

vmsize.go contains these methods
hack/generate_vmsize_data.go is a go gen script used to generate skus and saved in vmsize_generated.go. This testdata is used to the test the parsing method - only validates if parsing does the job. We do not validate the results or values.
vmsize_test contains tests for parsing method and other getVMSize() defined. Results are validated here.

Note:

[In progress] Parsing fails for 31 skus at the moment. Working on improvement.

    vmsize_test.go:31: Passed SKUs: 774, Failed SKUs: 31
--- FAIL: TestParseVMSize (0.02s)

testdata is not always generated at the time of test. Data is generated using a sub and eastus region.

go run generate_vmsize_data.go

[In progress]

Add tests for failure cases in vmsize_test.go
Better parse regex
NP handling

Codecov Report

Merging #19 (ef35bbc) into main (a3821e6) will increase coverage by 1.69%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   70.03%   71.72%   +1.69%
==========================================
  Files           5        6       +1
  Lines         297      336      +39
==========================================
+ Hits          208      241      +33
- Misses         89       95       +6

Files Changed
Coverage Δ

sku.go
70.58% <0.00%> (-1.71%)
:arrow_down:

vmsize.go
94.28% <94.28%> (ø)