Failure to get JToken when working with dynamic

Given the following two test cases:
    [TestFixture]
    public class DynamicBehaviorShouldMimicNormal
    {
        [Test]
        public void DynamicAccess_ToJToken_ShouldNotFail()
        {
            dynamic json = JObject.FromObject(new { uid = Guid.NewGuid() });
            Assert.That(() => { JToken token = json.uid; }, Throws.Nothing);
            // Fail
        }

        [Test]
        public void DynamicAccess_ToJTokenExplicit_ShouldNotFail()
        {
            dynamic json = JObject.FromObject(new { uid = Guid.NewGuid() });
            Assert.That(() => { JToken token = (JToken)json.uid; }, Throws.Nothing);
            // Fail
        }

        [Test]
        public void DynamicAccess_ToJTokenSafeCast_ShouldNotFail()
        {
            dynamic json = JObject.FromObject(new { uid = Guid.NewGuid() });
            Assert.That(() => { JToken token = json.uid as JToken; Assert.That(token, Is.Not.Null);}, Throws.Nothing);
            // Pass
        }

        [Test]
        public void IndexAccess_ToJToken_ShouldNotFail()
        {
            JObject json = JObject.FromObject(new { uid = Guid.NewGuid() });
            Assert.That(() => { JToken token = json["uid"]; }, Throws.Nothing);
            // Pass
        }
    }

I would expect none of them to fail, after all they are from an outside perspective, essentially doing the same thing.
However one of them fails with: Target type Newtonsoft.Json.Linq.JToken is not a value type or a non-abstract class.
After all, json.uid.GetType() == JValue which is assignable to JToken. It seems like it attempts to convert something that never needed conversion in the first place, as it hits:
   at Newtonsoft.Json.Utilities.ConvertUtils.Convert(Object initialValue, CultureInfo culture, Type targetType)
   at Newtonsoft.Json.Linq.JValue.JValueDynamicProxy.TryConvert(JValue instance, ConvertBinder binder, Object& result)

At this point: https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Utilities/ConvertUtils.cs#L410
Wouldn't it be more appropriate to say if (targetType.IsAssignableFrom(initialType)) ??
Edit: further more... Safe casting works, yet regular cast does not... Added test case examples.

Fixed https://github.com/JamesNK/Newtonsoft.Json/commit/4c256e7afd46197a6e40127f77dff18e8f044b8c

Cheers!


Replace button class

Replace "button-disabled" class with "button-default"
Fixes #1283

Verified fix.


Performance improvement need for GRPC storage plugin

In our project we have written grpc storage plugin. When we perform load test, grpc plugin performance is very poor compare to ES Storage type. And we even tested with binary built by adding plugin code as a new storage type in jaeger codebase , its performance is par with ES storage type.
Attaching here screenshots of load test metrics with collector+grpc plugin and collector binary built by adding grpc plugin code as a new datastore in jaeger codebase.
collector+grpc
80% spans received are dropped

collector binary built by adding plugin code as a new datastore in jaeger codebase.
no spans drops

Is there any way we can improve grpc plugin performance?

Even though the grpc plugin architecture introduces an extra RPC roundtrip and proto serialization, I am quite skeptical that it would result in 100ms latency since the communication happens over local unix pipe. The absolutely flat 100ms latency line is also highly suspicious, looks like saturation of throttling of some kind.
I don't know why this is, but I don't think this behavior is purely to how the plugin is architected, there seems to be something else going on here. Try to investigate further. Add additional metrics to the plugin itself, e.g. what is the latency of actual storage operations, how many concurrent saves are being processed, etc.

Yes 100 ms is what we worry about, We even tested with returning nil from WriteSpan() method at plugin side without any operations going on still we see the same performance with grpc plugin.
Hardaware Details:
4 CPU's
8 GB RAM


Loading datacenter config contains a hidden nextTick even though all config loading is synchronous.

https://github.com/uber/zero-config/blob/master/index.js#L30-L34
        // throw error async. this allows for breaking a
        // circular dependency between config & logger.
        process.nextTick(function () {
            config.emit('error', err);
        });

All config loading is synchrnonous. fetchConfig() returns a result, and THEN throws an error, which is undesirable and confusing. For example:
test('Non-existent dc test', function assert(t) {
  t.throws(function shouldThrow() {
    var config = zc({
      dc: '/does/not/exist',
    });
  }, /MissingDatacenterFileError/);

  t.end();
});

^ This tests will fail, and THEN the test suite will crash.

I guess I can register on error event, but this just undoes the synchronous nature of config initialization.

As mentioned; errors need to throw async because production. There are examples on how to write the tests.

errors need to throw async because production.

I agree that If an error occurs during runtime, after the things are configured, it should of course log. If config is not initialized with all the required parameters, the process should crash.
Things that are synchronous should stay synchronous. If async operations are being performed in the background, it should do zeroConfig(..., function onConfigLoad(err, config) { ... });. Or, following the existing EE pattern: zeroConfig.on('load', function onConfigLoad(err, config) { ... })

Why do other things throw in this case? Like:
https://github.com/uber/zero-config/blob/master/index.js#L15

Because one is a programmer error and one is an operational error.
The programmer errors are thrown and the operational errors are emitted with the standard node event emitter interface


KeyError: 'input_size_load'

Hi there, thanks for sharing your script. I am having some trouble with eval.py, as it seems mdlParams['input_size_load'] has neither been defined nor has a value been assigned to it. What does this stands for ? Could you help me please?

Hi, sorry for the late response, I am cleaning up old issues. That key is unused, you should be able to remove it without consequences.

Given eval.py has references to input_size_load so either update eval.py and replace all references of input_size_load with input_size (which is defined in the configuration file under cfg/2019 folder) or define mdlParams['input_size_load'] = mdlParams['input_size'] in the configuration file.


DesignSpaceDocument.defaultLoc needs to be updated

defaultLoc is used in findDefault(), but it is not updated after first read. So any axes that are added after reading the doc or creating the object are ignored.

Lgtm. We should also add a test for this.

This will fail if axes are removed or switched out completely (designspace.axes = [...]).  Maybe get rid of defaultLoc and always iterate over axes in findDefault or make it a property that always iterates over all axes.

Yeah, a property is a good idea for this.

actually, no need for a new property, as newDefaultLocation method already does that. I simply got rid of defaultLoc attribute

https://github.com/fonttools/fonttools/commit/b327287f977f45de52ce956787d4e33c441c657d


Add border-radius mixin into prefixer.scss

Add mixin border-radius, that exist in the docs http://materializecss.com/sass.html , but missed in the _prefixer.scss

border-radius do not need any prefixe on recent browsers (see Can I Use).
As far as I'm concerned, I don't use prefixer mixins anymore since I've discover Autoprefixer ; available for Gulp ou Grunt. It's really worth a try ;)

@gnicol-bzh , You right.
So, in this case should remove border-radius mixin from the docs, and other similars.

It is removed and will be update when the release comes


Fix code scanning alert - Inefficient regular expression

Tracking issue for:

[ ] https://github.com/nihilor/flgs/security/code-scanning/1

Regular expression changed.


Remove unused roles

@jonmv
FYI @tokle @smorgrav

The whole InstanceRole is also unused, and can be deleted.

PTAL


Two new integration tests for query post endpoint

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] New integration tests

Description
Two new integration tests for query post endpoint
Related Tickets & Documents

Related Issue #OLS-158

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] Unit tests passed locally.
[ ] If it is a core feature, I have added thorough tests.

Testing

Just make test-integration

/test unit

/test unit

/lgtm
/approve


Umlauts are not properly inserted into built in :terminal (gvim)

Describe the bug
When using a German keyboard layout including umlauts (äöü), these characters are not properly inserted into the gvim built in terminal mode. Instead, some other bash commands are executed.
To Reproduce
Detailed steps to reproduce the behavior:
This assumes the OS is linux.

Run setxkbmap de
Run export LC_ALL=de_DE.UTF-8
Run gvim --clean
Run :terminal
Type ä (which is on the quote/doublequote key on the US layout). Nothing happens.
Type ä again. An Ã gets inserted.

Expected behavior
An ä should be inserted instead.
Environment (please complete the following information):

Vim version

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 23 2020 22:02:57)
Included patches: 1-814
Compiled by Arch Linux
Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl               -farsi             +mouse_sgr         +tag_binary
+arabic            +file_in_path      -mouse_sysmouse    -tag_old_static
+autocmd           +find_in_path      +mouse_urxvt       -tag_any_white
+autochdir         +float             +mouse_xterm       +tcl/dyn
-autoservername    +folding           +multi_byte        +termguicolors
+balloon_eval      -footer            +multi_lang        +terminal
+balloon_eval_term +fork()            -mzscheme          +terminfo
+browse            +gettext           +netbeans_intg     +termresponse
++builtin_terms    -hangul_input      +num64             +textobjects
+byte_offset       +iconv             +packages          +textprop
+channel           +insert_expand     +path_extra        +timers
+cindent           +ipv6              +perl/dyn          +title
+clientserver      +job               +persistent_undo   +toolbar
+clipboard         +jumplist          +popupwin          +user_commands
+cmdline_compl     +keymap            +postscript        +vartabs
+cmdline_hist      +lambda            +printer           +vertsplit
+cmdline_info      +langmap           +profile           +virtualedit
+comments          +libcall           +python/dyn        +visual
+conceal           +linebreak         +python3/dyn       +visualextra
+cryptv            +lispindent        +quickfix          +viminfo
+cscope            +listcmds          +reltime           +vreplace
+cursorbind        +localmap          +rightleft         +wildignore
+cursorshape       +lua/dyn           +ruby/dyn          +wildmenu
+dialog_con_gui    +menu              +scrollbind        +windows
+diff              +mksession         +signs             +writebackup
+digraphs          +modify_fname      +smartindent       +X11
+dnd               +mouse             +sound             -xfontset
-ebcdic            +mouseshape        +spell             +xim
+emacs_tags        +mouse_dec         +startuptime       -xpm
+eval              +mouse_gpm         +statusline        +xsmp_interact
+ex_extra          -mouse_jsbterm     -sun_workshop      +xterm_clipboard
+extra_search      +mouse_netterm     +syntax            -xterm_save
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "/etc/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -pthread    -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -D_REENTRANT  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -fstack-protector-strong -rdynamic -Wl,-export-dynamic -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.30/core_perl/CORE  -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -L/usr/local/lib -Wl,--as-needed -o vim   -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0  -lSM -lICE -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo -lelf    -lcanberra  -lacl -lattr -lgpm -ldl   -Wl,-E -Wl,-rpath,/usr/lib/perl5/5.30/core_perl/CORE -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -fstack-protector-strong -L/usr/local/lib  -L/usr/lib/perl5/5.30/core_perl/CORE -lperl -lpthread -ldl -lm -lcrypt -lutil -lc   -L/usr/lib -ltclstub8.6 -ldl -lz -lpthread -lm

OS: Archlinux, with up-to-date dependencies for the above vim version
Terminal: GUI

Additional context
This problem does not appear in a regular buffer.
If LC_ALL=C is set, the behavior is different, but also wrong. In this case, the ä key capitalizes the letter under the cursor and moves one word forward, so it seems like <M-c> is issued instead.
Moreover, the problem it is not present in the last version of gvim that I have access to, which is 8.2.0510-2, when using an UTF-8 locale. But I get the same undesired behavior when LC_ALL=C.

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 23 2020 22:02:57)
Included patches: 1-814

Can you reproduce on master?  In particular make sure you have the patch 8.2.0851.

Can you reproduce on master? In particular make sure you have the patch 8.2.0851.

I just checked on the current master, that is:
Included patches: 1-1023

I get the same behavior. Also note that the problem is exclusive to gvim, terminal vim is fine.

Does it help if you press a chord using the control modifier (e.g. <C-L>) at least once before opening :terminal?  I ask because of the issue https://github.com/vim/vim/issues/5951.

Can you check whether an input method option has an influence on the issue?
You can find a list of them by executing the command :opt.  It should open a window with all Vim options.  In particular, have a look at the section 24 language specific; it contains these options:
imdisable       when set never use IM; overrules following IM options
iminsert        in Insert mode: 1: use :lmap; 2: use IM; 0: neither
imstyle         input method style, 0: on-the-spot, 1: over-the-spot
imsearch        entering a search pattern: 1: use :lmap; 2: use IM; 0: neither
imcmdline       when set always use IM when starting to edit a command line
imstatusfunc    function to obtain IME status
imactivatefunc  function to enable/disable IME

I think the most interesting ones are 'imdisable', 'iminsert', 'imstyle' and maybe 'imcmdline'.  Note that the window is interactive; its usage is documented at the top:
" Each "set" line shows the current value of an option (on the left).
" Hit <CR> on a "set" line to execute it.
"            A boolean option will be toggled.
"            For other options you can edit the value before hitting <CR>.
" Hit <CR> on a help line to open a help window on this option.
" Hit <CR> on an index line to jump there.
" Hit <Space> on a "set" line to refresh it.

If you want to be exhaustive, and try all possible combinations, source this code in Vim:
let counter = 0
for imdisable in ['imdisable', 'noimdisable']
    for iminsert in ['iminsert=0', 'iminsert=1', 'iminsert=2']
        for imstyle in ['imstyle=0', 'imstyle=1']
            for imcmdline in ['imcmdline', 'noimcmdline']
                let counter += 1
                call writefile([printf('set %s %s %s %s', imdisable, iminsert, imstyle, imcmdline)],
                   \ '/tmp/.test.'..printf('%02d', counter)..'.vim')
            endfor
        endfor
    endfor
endfor

It should create 24 minimal vimrc files with all possible combinations of values for the options 'imdisable', 'iminsert', 'imstyle' and 'imcmdline'.
Then, run this shell command:
for f in /tmp/.test.*.vim; do vim -gf -Nu NONE -U NONE -i NONE --cmd "so $f" +term; done

It should start gVim 24 times (consecutively, not simultaneously), one for each possible combination of settings.

Does it help if you press a chord using the control modifier (e.g. ) at least once before opening :terminal? I ask because of the issue #5951.

It should start gVim 24 times (consecutively, not simultaneously), one for each possible combination of settings.

Thanks for the script! I tried both, no change on either.

I can't fix the issue, but it's probably caused by https://github.com/vim/vim/commit/fd615a3c901f59abddca27c6a09940be552c0f4d.
This patch, combined with https://github.com/vim/vim/commit/f4ae6b245a54f11dd967d06b80f30e5abf55fb82, allows you to map something to a meta chord (e.g. <M-a>, <M-b>, ...) in the GUI, without losing the ability to insert some accented characters.
The purpose was to fix this kind of issue.

Good to know, thanks for checking this so quickly! For now, I can just downgrade. Happy to help with testing some patches once someone gets there.

It has nothing to do with modifyOtherKeys.  In a terminal XIM is off, which causes typed keys to go through another path, where multi-byte characters are not handled properly.  Must have been a problem for a very long time.


Error: on add

discorki_1    | 23-02-2023 14:02:50.903  INFO 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Received slash command: /add
discorki_1    | 23-02-2023 14:02:50.909 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Obtaining server for guild Pepe hub
discorki_1    | 23-02-2023 14:02:50.915 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Looking for player named Jennifer and server Pepe hub
discorki_1    | 23-02-2023 14:02:51.066 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Fetching rank for summoner Jennifer
discorki_1    | 23-02-2023 14:02:51.178  INFO 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Sending response for /add discord-username: @Jennifer league-username: Jennifer to TextChannel:discorki-testrun(id=1078305064420130937) in server Pepe hub
discorki_1    | 23-02-2023 14:03:02.386  INFO 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Received slash command: /leaderboard
discorki_1    | 23-02-2023 14:03:02.392 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Obtaining server for guild Pepe hub
discorki_1    | 23-02-2023 14:03:02.398 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Looking for ranks of all summoners in server Pepe hub
discorki_1    | 23-02-2023 14:03:02.416 ERROR 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Error running command leaderboard: Cannot invoke "com.alistats.discorki.model.QueueType.equals(Object)" because the return value of "com.alistats.discorki.model.Rank.getQueueType()" is null

discorki_1    | 23-02-2023 14:03:02.386  INFO 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Received slash command: /leaderboard
discorki_1    | 23-02-2023 14:03:02.392 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Obtaining server for guild Pepe hub
discorki_1    | 23-02-2023 14:03:02.398 DEBUG 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Looking for ranks of all summoners in server Pepe hub
discorki_1    | 23-02-2023 14:03:02.416 ERROR 1 --- [inWS-ReadThread] c.a.d.discord.SlashCommandController     : Error running command leaderboard: Cannot invoke "com.alistats.discorki.model.QueueType.equals(Object)" because the return value of "com.alistats.discorki.model.Rank.getQueueType()" is null


turkish contribution.md

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@ilkayDevran Please take note of the 5th checkbox above.  PRs should not have files with more than one language.


Optional transaction tip.

Follow up on #2799 #2854.

Allows all three types of UnchckedExtrinsic to have a generic a tip enum field.
Optionally decoded to the tip upon receiving a tx. Default value if non-existent.
Visible to runtime/executive via a Tippable trait.

TODO:

[x] Actually, use the tip value in validate_transaction to increase priority.
[x] Check tip in the signature.
[x] A dual node testnet fails now upon receiving a transaction in block_builder.rs due to an incorrect hash but all tests seem to pass which is kinda very bad. @tomusdrw @bkchr

WIP but pushed to get some initial feedback.

@tomusdrw two questions, one important and one more of a nit:

unimportant: Just some design decision:

Tip can actually be a field in a Signature tuple or SignatureContent struct. I'd say it works better as a separate field (as it is now). I've also added tip to chekc() and will push it soon.
Pass the tip also to CheckedExtrinsic (after check()) or not? I initially did this, then removed it. Functional-wise, it is not needed at all. Intuitive-wise, I think the clean approach is to have the tip a field in UncheckedExtrinsic (preferably non pub to depict that it is not checked with the sig yet) and then pass it to CheckedExtrinsic and implement Tippable for CheckedExtrinsic. Again, all of it seems to be optional and works fine as-is. (I will probably do this anyhow, my argument seems reasonable :p)

Important: The current situation forces all unsigned extrinsics to also have the tip field. Given your concerns of the tip to always be checked with the signature, Is that okay? The same new_unsigned() for UncheckedMortalCompactExtrinsic is also used somewhere related to inherents. I've so far ignored these details to get going faster but if you have some initial feedback, would be great.

Tip can actually be a field in a Signature tuple or SignatureContent struct. I'd say it works better as a separate field (as it is now). I've also added tip to chekc() and will push it soon.

I don't think it semantically fits the signature. Also note that to produce the Signature you need the Tip to be part of signing payload, which complicates it even further.

Pass the tip also to CheckedExtrinsic (after check()) or not? I initially did this, then removed it. Functional-wise, it is not needed at all. Intuitive-wise, I think the clean approach is to have the tip a field in UncheckedExtrinsic (preferably non pub to depict that it is not checked with the sig yet) and then pass it to CheckedExtrinsic and implement Tippable for CheckedExtrinsic. Again, all of it seems to be optional and works fine as-is. (I will probably do this anyhow, my argument seems reasonable :p)

I think we should do that yes. Tip should be validated (aka checked) if it's valid and only then it can actually be used for anything.
I think we shouldn't really be using anything from Unchecked* structs, since you never know if they are sound before you check them.

Important: The current situation forces all unsigned extrinsics to also have the tip field. Given your concerns of the tip to always be checked with the signature, Is that okay?

So with the current values of Tip enum (None, Sender) the validation part should make sure that if Signature is missing the Tip can't be Sender. If we ever decide to introduce a different type, i.e. Tip::PayedBy(Signature) then we can have an unsigned transaction with Tip containing a signature and that's totally valid. The question is if we want to support something like that.

This can now be reviewed in more depth. There might still be some work on how the generic balance is handled but I consider that minor detail.
Once #2854 is stable and merged in with this I would like to add as many e2e tests as possible.
For now, my only manual, cumbersome testing method I had is broken due to this issue https://github.com/paritytech/substrate/issues/2943. I think it is an important one actually.

This is almost done but won't fix the priority calculation until https://github.com/paritytech/substrate/pull/2854 is merged.

New TODO to update https://wiki.polkadot.network/en/latest/polkadot/build/extrinsic-format/

Sorry, have not checked in depth, on mobile till the weekend.
However since the extrinsic has a version as part of the sign encoding, bumping this could allow detection for old vs new. So new may require non-useless (if specified) and older version will never allow. This could help on some of the comments.
Apologies again for not checking in-depth if the version was bumped.

@rphmeier the road map would be that this will be included in substrate and soonish we can try out replacing the type UncheckedExtrinic = <unchecked_mortal_compact_tipped_extrinsic> in polkadot's runtime directly.

To wrap things up a bit more:

This officially throws TransactionBaseFee() and byte fee out of the window.
Yet, since all transactions are assigned a weight at the moment equal to their size, we are basically still capable of having the same old update mechanism.
The WeightMultiplierUpdate implementation that is currently used (looking at the previous block weight, slow adjusting, etc etc) might want to be actually moved to polkadot later on and revert substrate node to simply have a constant multiplier that never changes?

is Tip<Balance> compact encoded?

will be closed by #3102


Memory leak get-or-create'ing with a proxy tag

curl -d '{"require": ["and", [["browser_name", "chrome"], ["proxy", ["tag", "example"]]]]}' -XPOST http://localhost:5000/sessions/ --header "Content-Type:application/json"

Eventually killed shale with an OOME

I can't reproduce this.. closing for now.


ROX-11111: Fix inability to scan internal images with SHA specified in name

Description
Sensor did not identify images with explicitly set SHAs as cluster-local. For example, any of the sample OpenShift applications. When deployed to a namespace testdev, an example image is: image-registry.openshift-image-registry.svc:5000/testdev/nodejs-basic@sha256:31734e0a1e52996cde63a67c18eafebeb99149d0b3d0b56e1c5f31b0583ec44b. In sensor/kubernetes/listener/resources/convert.go, we did not bother setting the image's ID nor NotPullable fields if the image's ID was already set (happens in a case like this where it is explicit). Therefore, setting IsClusterLocal was also skipped. This PR sets both NotPullable and IsClusterLocal even when the ID is already known.
Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
Unit tests as well as running an OpenShift 4.x cluster and deploying a sample application (these all specify the tag explicitly in the image name)

@RTann I must confess I'm confused: what exactly was the root cause of the issue described in the ticket, and how does this code solve it? Would be great if you could update the PR description with a more detailed explanation. 🙂

@viswajithiii I updated the description. Let me know if it still isn't clear


It's unfortunate that Response.close() tries to read all remaining information; buggy too

Response.close() seems to try to read all remaining data out of the socket in order to work around a flaw or limitation in the ESP32SPI socket implementation.
There are two problems with this:

A client may want / need to close an ongoing request before reading all information in it
as implemented it's not necessarily exhausting all content, but at most one chunk in the chunked-encoding

this may not be possible, the stream could be infinite

handling of chunked mode is wrong and can lead to errors during close()

As far as the last point, I did experience it 'going wrong' with the chunked mode length being part of the http stream, but there's also the case where the exact content is carefully read (runs on desktop linux):
import socket
import ssl
import adafruit_requests

session = adafruit_requests.Session(socket, ssl.create_default_context())
with session.get('https://github.com') as response:
    assert response._chunked
    buf = bytearray(1)
    response._readinto(buf)
    print(buf)
    while response._remaining:
        print(response._remaining)
        response._readinto(buf)
        print(buf)
    assert response._cached is None
    assert response.socket

if there's a limitation of ESP32SPI that a socket has to be fully read before it's closed, can't we push that down into ESP32SPI (or better yet fix the limitation in nina-fw) and get rid of this trouble-causing block?

@jepler or @dhalbert can this be closed with my cleanup on response.close()

Fixed by #159.


Fixes for get_policy and get_policy_version with AWS managed policies

When get_policy and get_policy_version was called with an AWS managed policy, moto did not return any results. This has been fixed now.

Coverage remained the same at 93.012% when pulling f4f662374c19d245edd9494c33cf1f01e80d38d1 on acsbendi:get-policy-version-fix into d25a7ff9363967a713599b7b0b974b4c6be2e708 on spulec:master.


Add CookieManager and middleware

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
#4

I like https://github.com/yiisoft/cookies/pull/21 approach more but it totally lacks anything about adding signed/encrypted cookies.


fixing broken videos and images on 19 and below

what, why, how
TLS 1.0 and 1.1 is no longer supported on our image host starting 5/18/18.  https://blog.imgix.com/2018/05/18/tls-deprecation.html
Android versions 19 and below don't have TLS 1.2 enabled by default :neutral_face: So videos and images are currently broken for all users on 19 and below 😢
This change uses Google Play Services to patch Android's security provider, it's lit 👏
Shout out to this StackOverflow answer: https://stackoverflow.com/questions/29916962/javax-net-ssl-sslhandshakeexception-javax-net-ssl-sslprotocolexception-ssl-han/36892715#36892715
I'm removing the work Lisa did to enable TLS on 19 > devices because it was only on Retrofit, we have external dependencies that make network calls including Picasso (I think uses Okhttp) and ExoPlayer. This needs to be a global change.
before & after

 [ZD] [Android] App not loading pictures or videos when browsing projects


⚠ Bofrost.at has degraded performance

In 9288ff6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1202 ms

Resolved: Bofrost.at performance has improved in a749057.


License

Hi, node-twitter is pretty popular.
However just so all the users are safe, do you intend on adding a license (MIT or Apache etc.)?

+1 to MIT


Add default host header

I'm getting the following error when I do an sbt clean or sbt assembly:
java.lang.ClassCastException: Cannot cast com.typesafe.sbt.SbtScalariform$ to sbt.Plugin

Any thoughts?  Everything seems to be setup correctly according to https://github.com/sbt/sbt-scalariform.  Perhaps something cached in sbt-land?

Hmmm. One quick thought, go to your sbt config folder ~/.sbt/0.13 and delete everything under the staging directory. I suspect this is a mismatch with hmda-geo project configuration, you may have an older version and it is not being refreshed.

Thanks!  I blew away everything under ~/.ivy2/cache and ~/.sbt/0.13/staging.  Everything is back to working again.


Added right click context menu, refactored and modularized, updated settings form

updated a few things to close out the issue previously reported.

Thanks for the PR.
And it's really a nice job to write logic in single function.

Thanks for the merge! This is a great program, nice work. Also, I might move all the logic to its own class(saw your comment in the original code)

Merry Christmas! (I know this could be a little too early for you,but whatever)
EarthLive# 2.0 was released thanks to your contribution.

I just downloaded 2.0. It looks great!
also, I saw the issue about bandwidth. I have a VPS you can use if you like, unlimited bandwidth.

That is so nice of you.
But i think we shouldnt build the buffer on our own host. As you know, whart we are building is an Software. It should not be our responsiblity to offer a Free image feeds service(espicially when we dont hold the copyright of those images). Also i have clarified this to those users in Chinese.
Finally, so sorry for my poor English and I wish i'm not writing something wrong/impolite...

no worries. I think a possible future feature would be the ability to pull images to an ftp and then pull from ftp. Or possibly rotate to different satellite images so the load is spread to multiple sources. May tinker around and let you know what I find.


Can't start or stop CHE instances

When I try to start op stop a CHE machine i'm constantly prompted to login, the login screen appears blank for a few seconds but nothing happens and the machine doesn't change state. Other functions like Deploy a package are working fine. Encontered in versions .30 and the latest .43.
Thanks,
Torben

We observe the same behavior :-(

Thanks for reporting, I can reproduce a similar issue with version 0.43.0. For me, when trying to stop a CHE, I first get a dialog "Please login to LCS again. Your cookie probably expired". After I confirm with OK, the blank login form appears for a few seconds, then vanishes and the "Choose LCS project" form is shown instead.
I also tried logging out and in again, but that did not resolve the issue.

The error occurs here (line 713):
https://github.com/microsoft/2LCS/blob/cfe5671fb211a03d255c350daf1554aa4ab55054/2LCS/HttpClientHelper.cs#L706-L717
What happens is that the call to the LCS API returns a 500 status code (internal server error). /DeploymentPortal/StartStopDeployment is not part of the official LCS API to start/stop environments. This part of 2LCS was probably written before that API was available. It is also possible that the official API would not work with the 2LCS approach of authentication. My guess would be that Microsoft made changes to the /DeploymentPortal/StartStopDeployment part of the API.
@TomekMelissa This is a bit out of my wheel house. Do you know if /DeploymentPortal/StartStopDeployment can still be used and what changes we would have to make?

I checked what parameters LCS currently sends on start/stop and compared to 2LCS and there is an extra parameter EnvironmentId. I did a quick test and after adding the EnvironmentId parameter, the start/stop action is already performed correctly.
internal async Task<bool> StartStopDeployment(CloudHostedInstance instance, string action)
{
    var parameters = $"{action}=&ActivityId={instance.ActivityId}&ProductName={WebUtility.UrlEncode(instance.ProductName)}&TopologyName={instance.TopologyName}&TopologyInstanceId={instance.InstanceId}&AzureSubscriptionId={instance.AzureSubscriptionId}&EnvironmentGroup=0&EnvironmentId={instance.EnvironmentId}";
    using (_stringContent = new StringContent(parameters, Encoding.UTF8, "application/x-www-form-urlencoded"))
    {
        SetRequestVerificationToken($"{LcsUrl}/V2");
        var result = await _httpClient.PostAsync($"{LcsUrl}/DeploymentPortal/StartStopDeployment/{LcsProjectId}", _stringContent);
        result.EnsureSuccessStatusCode();
        var responseBody = result.Content.ReadAsStringAsync().Result;
        return responseBody == "true";
    }
}

Awesome, thank you @petrjanikac . A new version with the fix is available in https://github.com/microsoft/2LCS/releases/tag/v.0.44.0.

Awesome indeed, thank you @petrjanikac for a fast fix. Verified that it works :)


improve the css of questions

Need to improve the questions display CSS - currently the color scheme is not consistent with the environment

done.


tic marks inside the axes are overplotted by a FILL plot, not by a SHADE

Reported by Ansley B Manke on 7 Oct 2002 16:02 UTC
! pplus tics bug
! Andrew Wittenberg, 3 Oct 2002
use coads_climatology
ppl tics ,,,,0,0
shade/l=1/x=150e:110w/y=40s:40n sst; pause
fill/l=1/x=150e:110w/y=40s:40n sst
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/462

Comment by<EMAIL_ADDRESS>on 13 Nov 2002 22:08 UTC
fixed in pltit.F, 10/11/2002

Comment by<EMAIL_ADDRESS>on 21 Oct 2003 20:16 UTC
Moving from the<EMAIL_ADDRESS>user to the<EMAIL_ADDRESS>user.

Comment by ansley.b.manke on 4 Nov 2008 19:50 UTC
Adding Andrew to the CC list where he is mentioned in the ticket comments.


Make exec run be detected as WoodpeckerCI

and exclude docs/docs/40-cli.md from git as it will be generated by CI
e.g. checkout to https://github.com/adamdecaf/cidetails/pull/3 and exec woodpecker-cli exec --build-event push --backend-engine docker will fail atm

if we build docs/docs/40-cli.md in pipeline anyway befor publishing, we might just exclude it from git?

ok will start with docs for now

1sec I need to update the when filter a bit

NOW it should be fine


Add webpack cache-loader for improved build performance

Submit a feature request or bug report

[x] I've read the guidelines for Contributing to Roots Projects
[x] This is a feature request
[ ] This is a bug report
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse forums

Feature Request
Please provide use cases for changing the current behavior:
Using the new webpack cache loader provides significant performance improvements on subsequent builds. By caching the buble and extracttext rules I get these results:

command
before
after

yarn run build
16s
10s

yarn run build:production
29s
17s

source: https://gist.github.com/oxyc/f9c28d7f84e8c3c31dbf8da4015beec2
diff --git a/resources/assets/build/webpack.config.js b/resources/assets/build/webpack.config.js
index 1cb7f5a..4c63f0c 100644
--- a/resources/assets/build/webpack.config.js
+++ b/resources/assets/build/webpack.config.js
@@ -51,8 +51,10 @@ let webpackConfig = {
       {
         test: /\.js$/,
         exclude: [/(node_modules|bower_components)(?![/|\\](bootstrap|foundation-sites))/],
-        loader: 'buble',
-        options: { objectAssign: 'Object.assign' },
+        use: [
+          'cache',
+          { loader: 'buble', options: { objectAssign: 'Object.assign' } },
+        ],
       },
       {
         test: /\.css$/,
@@ -60,6 +62,7 @@ let webpackConfig = {
         use: ExtractTextPlugin.extract({
           fallback: 'style',
           use: [
+            'cache',
             { loader: 'css', options: { sourceMap: config.enabled.sourceMaps } },
             {
               loader: 'postcss', options: {
@@ -76,6 +79,7 @@ let webpackConfig = {
         use: ExtractTextPlugin.extract({
           fallback: 'style',
           use: [
+            'cache',
             { loader: 'css', options: { sourceMap: config.enabled.sourceMaps } },
             {
               loader: 'postcss', options: {

Other relevant information:
Cache invalidation is an issue. Some improvements in https://github.com/webpack-contrib/cache-loader/pull/9 but still not all that is needed.

Went ahead and added it.
https://github.com/roots/sage/pull/1919/commits/48dd684b1014a47d1dfc9137c809bb31530cf17b
Thanks for the suggestion.


[Please Comment] References for New Serenity Web Site

Hello All,
I'm currently preparing a web site for Serenity. I want to add a references section with information and links about "who uses Serenity".
If you / your company would like to be listed in this section, please post here with information below:

User / Company Name
Product Name
Company / Product Logo if any
Company / Product Site URL if any
A short description of what product does
At least one screenshot from your application, with details blurred for security purposes if required.
A link to your application if possible. I understand Serenity apps are usually administrative so this may not be ok for you, but a link to login page only for users to confirm that Serenity is actually used would be appreciated.
Any comments you'd like to add. How Serenity helped you, did it have a positive effect on release time, what were challanges etc.

There will be another section on landing page about "what our users say". If you'd like to be shown there need information listed below:

Full Name / Nickname
Company Name, if any
Your small photo (face)
Your review, how you use Serenity, how it helped etc.

I'm planning to add some reviews from VSGallery and user comments collected from issues here, so if you had a review there please add your username shown in VSGallery.
Thanks to all.

Who uses Serenity
User / Company Name : Knowtulus Technologies Private Limited.
Product Name: KoFees  - Fees Management System for School and Institutes
Company / Product Logo if any
Company / Product Site URL if any: kofees.com
A short description of what product does: Easy Fees and Student Invoice Management with various
options for creating payment plans per course
At least one screenshot from your application, with details blurred for security purposes if required.
A link to your application if possible. I understand Serenity apps are usually administrative so this may not be ok for you, but a link to login page only for users to confirm that Serenity is actually used would be appreciated.
http://fees.azurewebsites.net
Any comments you'd like to add. How Serenity helped you, did it have a positive effect on release time, what were challanges etc.
Lightning fast development for this project
what our users say
Full Name / Nickname: Dilip Kalantri
Company Name, if any: Knowtulus Technologies Private Limited.
Your small photo (face):

Your review, how you use Serenity, how it helped etc.
Selecting serenity framework has drastically reduced time to market for this app and this framework is well thought framework in terms of design, architecture and user experience

I'm on vacation, I return to the office in september and I will send you the data. Good summer to all!

Great idea! I will have all this in here before the weekend!

Me too,
I'll try to post my projects this weekend !
I would like to add a question in original list (for developers)
"Which enhancement you did in your Serenity project? "
The goal is who done more differents features than listed and explained in Serenity tutorials and wiki.
I think that a good way to improve the Serenity project, and then became a new tutorials or samples for news developers!

I'll get his to you asap! Our website is internally hosted on our systems intranet, so the URL wont work but I can give screenshots :+1:

Who uses Serenity
User / Company Name: Antargyan CloudWorks LLP
Product Name: RecordShield
Company Logo if any:

Product Logo if any:

Company / Product Site URL if any: www.antargyan.com / www.recordshield.net
A short description of what product does: RecordShield is Video Encryption and Distribution Platform for anyone to share their content securely with other people
At least one screenshot from your application, with details blurred for security purposes if required.

A link to your application if possible. I understand Serenity apps are usually administrative so this may not be OK for you, but a link to login page only for users to confirm that Serenity is actually used would be appreciated.
Any comments you'd like to add. How Serenity helped you, did it have a positive effect on release time, what were challenges etc.
We faced challenges with Forms Authentication working with Mobile Apps
RecordShield Content Activation done through Serenity Framework Over Email, SMS and Internet Channels
Serenity is very robust and powerful framework in creating multi-tenant enterprise applications

Collecting this information sound good for Serenity. I have limited availability for checking email, So i am not able to help on the issue reported in github but glad to know that people are helping each other and sharing knowledge base.
I am sharing my demo version of the product build using Serenity.
url : http://demo.tranzol.in/TranzolERP/Account/Login
username: admin
pass: demo@123
Here are more details asked -
User / Company Name - CIYA Technologies
Product Name - Tranzol
Company / Product Logo if any -  http://demo.tranzol.in/CIYALogo.png
Company / Product Site URL if any - www.ciyatech.com
A short description of what product does
Tranzol is a single-platform software solution designed for logistics industries to increase your productivity and improve integration, and communication with the supply chain. It integrates and automate your business with your customers and partners, streamlining processes and increasing the efficiency, visibility, and profitability of your operations.
There will be another section on landing page about "what our users say". If you'd like to be shown there need information listed below:
Full Name / Nickname : Ram
Company Name, if any : CIYA Technologies
Your small photo (face):  http://demo.tranzol.in/MyPic.jpg
Your review, how you use Serenity, how it helped etc:
The Serenity framework is awesome which decrease development time drastically  and developer can focus on business logics only. UI, Security, Auditing etc and lot of other thing are taken care by Serenity.
This is an amazing framework and it does not have any comparison (at least in my knowledge).
The best part is that this framework is an open source with an excellent support.

Hi @volkanceylan !
Here my company information
•User / Company Name: Speed Informatica S.r.l.
•Product Name: The name of the project has not yet been defined. Speed Web Edition (temporary name)
•Company / Product Logo if any:

•Company / Product Site URL if any: http://www.speed-informatica.it/
•A short description of what product does: HR Product
•At least one screenshot from your application: later
•A link to your application if possible: later
•Any comments you'd like to add: Serenity is a great framework that has accelerated very much our transition to a web application. It is stable and fast, customizable and easy to learn. Plus the fact that you use C # to server side language is very important for us.

Thanks to everyone who shared details so far. I've put a summary of them on front page, but page with details will come later. Let me know if i missed any. Thanks again.


Remove unnessary overloading forward

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #696 (b56babd) into master (6ac46a8) will decrease coverage by 0.08%.
The diff coverage is 6.25%.

@@             Coverage Diff              @@
##             master     #696      +/-   ##
============================================
- Coverage     68.84%   68.76%   -0.09%
+ Complexity     3982     3969      -13
============================================
  Files           464      464
  Lines         18506    18496      -10
  Branches       1987     1987
============================================
- Hits          12740    12718      -22
- Misses         4739     4750      +11
- Partials       1027     1028       +1

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/ai/djl/nn/transformer/BertBlock.java
43.79% <0.00%> (ø)
8.00 <0.00> (ø)

...l/nn/transformer/BertMaskedLanguageModelBlock.java
38.59% <0.00%> (+2.53%)
3.00 <0.00> (ø)

...va/ai/djl/nn/transformer/BertPretrainingBlock.java
48.78% <0.00%> (-1.22%)
3.00 <0.00> (ø)

...c/main/java/ai/djl/nn/transformer/IdEmbedding.java
40.54% <0.00%> (+1.06%)
3.00 <0.00> (ø)

...ai/djl/nn/transformer/TransformerEncoderBlock.java
62.85% <ø> (+1.74%)
3.00 <0.00> (ø)

...a/ai/djl/nn/transformer/BertNextSentenceBlock.java
90.00% <50.00%> (+30.00%)
3.00 <1.00> (ø)

...djl/training/listener/LoggingTrainingListener.java
83.18% <0.00%> (-5.31%)
22.00% <0.00%> (-6.00%)

api/src/main/java/ai/djl/nn/Parameter.java
74.60% <0.00%> (-3.18%)
21.00% <0.00%> (-1.00%)

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
4.00% <0.00%> (ø%)

api/src/main/java/ai/djl/training/Trainer.java
92.85% <0.00%> (-3.07%)
34.00% <0.00%> (-1.00%)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac46a8...3b29cb3. Read the comment docs.


Add new locations to the randomization pool

Eight new locations

Potential item locations (in case they are not included in your eight new locations):

Winning the dagger throwing mini game with the maximum possible bet. (I could be wrong but I think the AI is stronger the higher you bet)
The crumpled piece of paper underneath the bar stool
Reward for helping the fox
Reward for defeating a Saurus Rex
Reward for defeating eight goblins in a row at the goblins training grounds

These are good suggestions! Some of them are indeed on my list of eight.


Vulkan Extensions missing for supported Graphics Card

info:  Required Vulkan extension VK_KHR_get_physical_device_properties2 not supported
info:  Required Vulkan extension VK_KHR_surface not supported
info:  Required Vulkan extension VK_KHR_win32_surface not supported

Seems maybe it is not always this case for other DXVK apps. Some other people seem to have this too for example: https://forums.lutris.net/t/eso-poe-dxvk-missing-vulkan-extensions-which-are-actually-supported/4437 or #774
I was not sure if this is a Vulkan bug or a DXVK bug or neither, so I posted it for both. Also I installed everything listed here: https://github.com/lutris/lutris/wiki/Installing-drivers#installing-vulkan
etc.
Also set radeon.si_support=0 amdgpu.si_support=1 from https://wiki.archlinux.org/index.php/AMDGPU#Enable_Southern_Islands_(SI)and_Sea_Islands(CIK)_support
for my Southern Islands graphics card.
Software information
League of Legends D9VK AppImage (Lutris)
System information

GPU: AMD RX 570
Driver: Mesa and vulkan-radeon 19.1.3-1
Wine version: wine-staging 4.12.1-1
DXVK version: from D9VK 0.12

You're missing some packages (most likely the 32-bit vulkan loader or driver).

sudo pacman -S vulkan-radeon lib32-vulkan-radeon vulkan-icd-loader lib32-vulkan-icd-loader
installed every package from https://github.com/lutris/lutris/wiki/How-to:-DXVK needed for my AMDGPU

This isn't a bug, this is a setup issue on your end. Maybe Lutris screws with your environment variables or something; I can't really help you with that since it's not my issue.

Can you help me figure out if this is rather a Vulkan bug or Mesa bug?
Because I am sure this can't be a setup issue on my end. For example this guy has the same issue:
https://bugs.launchpad.net/ubuntu/+source/dxvk/+bug/1835980

The bug report you linked says The hardware this is running on is a Mac Pro 1,1, graphics card Nvidia 7300 GT.. That GPU doesn't even support Vulkan.

true but RX 570 does so what can be the error? Pls help

Try setting up the game manually inside Wine without Lutris.

yes tried that already (this guy tried help me: https://github.com/mmtrt/Wine-AppImage/issues/6#issuecomment-515263908).
But I am gonna try again. Thanks.
Maybe my card really doesn't support those three extensions or something.

Try without the AppImage then.

Oh, without AppImage it works. Ok seems to not be my error then, thank you very much I thought since about 40 hours I do something wrong...
Thank you very much :)

@phaitonican Can you share more about your solution?

The solution is to set up Wine and DXVK like you normally would. Install normal Wine, make sure you have Vulkan drivers and loaders (dont forget 32bit) and then use the install script that comes with dxvk releases.

I meet this problem too,the log is same as you.
My GPU is AMD HD4350

I meet this problem too,the log is same as you. My GPU is AMD HD4350

yjacks this is not a dxvk issue. I was wrong. This was because I installed a AppImage which has missing DXVK drivers for my graphics card. If you don't use a AppImage and install ALL requirements it should work.


feat: Added Dropdown and supporting Components

Added Popper
Added WithLabel, an internal component to help render labels around dropdowns
Added DropdownButtonBase, the button component that lies inside the Dropdown (and future selectors)
Added Dropdown

@alank-encoura I'm going to close this PR (for now) since we haven't heard from ACT teams whether or not these components are actually needed. And per our conversations, they might be a bit too opinionated to live long-term in the DLS.
We can always revisit this in the future!


Fix broken TravisCI build

This PR fixes two issues

oraclejdk7 is currently broken on Travis
docker-engine deb seems to only be available via the Docker PPA

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #805   +/-   ##
=========================================
  Coverage     66.04%   66.04%
  Complexity      713      713
=========================================
  Files           162      162
  Lines          3060     3060
  Branches        350      350
=========================================
  Hits           2021     2021
  Misses          884      884
  Partials        155      155

Merging since the oraclejdk7 seems like it won't be supported going forward. See https://github.com/travis-ci/travis-ci/issues/7884#issuecomment-308451879

New Trusty images don't install oraclejdk7. https://github.com/travis-ci/build-environment-updates/blob/master/2017Q2/gce/sugilite-trusty/dpkg-manifest.diff#L982-L983


Drop Admin attribute based on LDAP when login (continue #1743)

continue #1743
Currently setting an admin in ldap stay forever, this fix it.
It will close #1359

Codecov Report

Merging #8849 into master will increase coverage by <.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #8849      +/-   ##
==========================================
+ Coverage   41.23%   41.23%   +<.01%
==========================================
  Files         543      543
  Lines       69785    69799      +14
==========================================
+ Hits        28777    28783       +6
- Misses      37321    37322       +1
- Partials     3687     3694       +7

Impacted Files
Coverage Δ

models/login_source.go
27.38% <60%> (+1.08%)
:arrow_up:

modules/migrations/migrate.go
21.22% <0%> (-1.68%)
:arrow_down:

modules/migrations/gitea.go
10.16% <0%> (-1.49%)
:arrow_down:

models/repo.go
48.57% <0%> (-0.06%)
:arrow_down:

models/error.go
32.98% <0%> (+1.23%)
:arrow_up:

modules/task/migrate.go
28.2% <0%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b8c08...f434972. Read the comment docs.

@techknowlogick @lunny can you look throu it was lgtm/done before and its a smal chage :)

I have some comments:

I think that this behavior should be selectable (enable/disable); admins might want the users to customize their info if they want to. Especially their e-mail.
I'm not sure this is the right place to update the user info (it's the easiest, no doubt). After this function there's at least one more check before letting the user in, an that's prohibit_login. No updates should be made if the user is not accepted into the system.

@guillep2k a admin access should be reviced imidiatly so if LDAP dont inform gitea to dorp this right (wich it cant) we should check this at login ... and udate
for the "full_name", "email" we could create background tasks wich in gerneral sync metha infos from external sources ...

And yes sync username&email should be optional

@guillep2k a admin access should be reviced imidiatly so if LDAP dont inform gitea to dorp this right (wich it cant) we should check this at login ... and udate

prohibit_login should be checked first, even if admin changes from false to true IMHO.

@guillep2k updated ... to
"User sync is implemented at #1478 - so only make sure that admin access is droped if changed"

I'm sorry, @6543 . Although the added condition is relevant (it shouldn't sync anything if sync is disabled), I meant to add a new option in app.ini specifically for updating the is_admin value.

I'm sorry, @6543 . Although the added condition is relevant (it shouldn't sync anything if sync is disabled), I meant to add a new option in app.ini specifically for updating the is_admin value.
I didn't @guillep2k it exists already for ldap syncing

@lafriks wait ... I'll dig into later ...

@guillep2k need your review ...

@lafriks can you look throu again THX

@lafriks any other complains ...?

@lafriks any other complains ...?

@6543 Sorry for nit'picking :)

@techknowlogick I think this PR is ready :)


Cursor placed at wrong level of indentation after add a newline in the child content of a QuickGrid component in a .razor file

This issue has been moved from a ticket on Developer Community.

I added a QuickGrid to my Blazor app using .NET 8 Preview 6. When I try to add a newline in the QuickGrid child content the cursor is indented one indent too much. The cursor should be even with the existing PropertyColumns, but it's one indent further.

Original Comments
Feedback Bot on 7/2/2023, 11:31 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Looks like this is caused by having a lambda in an attribute


Windows 友好的编译脚本

不依赖GNUMake，自动编译脚本

@OnceMore2020  Thank you. Could you:

Add instructions in README.md, decribing how to use this script in Windows.
Meger all your changes into one commit then send a new PR.


[BUG] CLI test failed for validate policy

Software version numbers
State the version numbers of applications involved in the bug.

Kubernetes version:
Kubernetes platform (if applicable; ex., EKS, GKE, OpenShift):
Kyverno version: 1.4.3

Describe the bug
CLI test for the new validate policy failed in kyverno/kyverno CI, test set https://github.com/kyverno/policies/tree/main/other/restrict_ingress_host.
Failure log https://github.com/kyverno/kyverno/runs/3733154812.
The issue is the rule names in the test.yaml and value.yaml do not match the names in the policy. I fixed the rule names locally but struggled with defining the value for var {{ request.object.spec.rules[].host | length(@)}}.
@NoSkillGirl @viveksahu26 @vyankyGH How should I specify the variable in value.yaml?

And if I don't define that var in value.yaml, the rule would fail because the variable is not defined:
✗ go run ./cmd/cli/kubectl-kyverno/main.go test ../../kyverno/policies/other/restrict_ingress_host

Executing unique-ingress-host...
applying 1 policy to 2 resources...
test skipped for policy  unique-ingress-host  (as required variables are not provided by the users)

│───│─────────────────────│─────────────────────│──────────────────────│────────│
│ # │ POLICY              │ RULE                │ RESOURCE             │ RESULT │
│───│─────────────────────│─────────────────────│──────────────────────│────────│
│ 1 │ unique-ingress-host │ check-single-host   │ ingress-kyverno-host │ Pass   │
│ 2 │ unique-ingress-host │ deny-multiple-hosts │ ingress-foo-host     │ Fail   │
│───│─────────────────────│─────────────────────│──────────────────────│────────│

hey @realshuting , For variable I raised an issue and it is resolved now. There was mistake in test.yaml and values.yaml file. I have fixed it locally and also asked @NoSkillGirl  to cross check it.

Are these two tests passed in your local test? Can you please submit your local fix? We need it for all tests in kyverno/kyverno.

Can you check with this, and policy will be same.
resource.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-kyverno-host
spec:
  rules:
  - host: www.kyverno.com
    http:
      paths:
      - pathType: Prefix
        path: "/kyverno"
        backend:
          service:
            name: service1
            port:
              number: 80

---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-foo-host
spec:
  rules:
  - host: www.foo.com
    http:
      paths:
      - pathType: Prefix
        path: "/foo"
        backend:
          service:
            name: service2
            port:
              number: 80

test.yaml
name: unique-ingress-host
policies:
  - restrict_ingress_host.yaml
resources:
  - resource.yaml
variables: values.yaml
results:
  - policy: unique-ingress-host
    rule: check-single-host
    resource: ingress-kyverno-host
    kind: Ingress
    result: fail
  - policy: unique-ingress-host
    rule: check-single-host
    resource: ingress-foo-host
    kind: Ingress
    result: skip
  - policy: unique-ingress-host
    rule: deny-multiple-hosts
    resource: ingress-kyverno-host
    kind: Ingress
    result: skip
  - policy: unique-ingress-host
    rule: deny-multiple-hosts
    resource: ingress-foo-host
    kind: Ingress
    result: skip

values.yaml
- name: unique-ingress-host
  rules:
  - name: check-single-host
    values:
      hosts: "[\"www.github.com\", \"www.kyverno.com\", \"www.nirmata.com\"]"
  resources:
  - name: ingress-kyverno-host
    values:
      request.operation: CREATE
  - name: ingress-foo-host
    values:
      request.operation: UPDATE

Yes it passes for me. Can you submit the changes so we can merge pending PRs in kyverno/kyverno?
I don't think we want to specify skip for those three rules, it does not validate policies in this case. We still need to figure out how to define a var with length(@) or other JMESPath operations. @NoSkillGirl

yes, I will make PR.

Do, I have to also include those skip cases or not.

Yes please.


Add dcos node metrics command

This PR adds a command to obtain metrics from a specified node. Currently the command simply prints the name and value of each data frame in a table. It is a work in progress.
Next steps:

[x] Expand integration tests to show that the correct data is returned
[x] Improve the formatting of the non-json output

[x] Show disk/cpu/memory by default (both absolute and percentage values)
[x] Make numbers human-readable
[x] Add units

[x] --json flag
[x] --filter flag

Example output:
$ dcos node metrics
Command not recognized

Usage:
    ...
    dcos node metrics (--mesos-id=<mesos-id>) [--field=<name>... | --json]
    ...

$ dcos node metrics --mesos-id=SOME_SAMPLE_ID
CPU            MEM               DISK
1.01 (25.46%)  2.39GiB (16.28%)  0.05GiB (0.13%)

$ dcos node metrics --mesos-id=SOME_SAMPLE_ID --json
[
  {
    "name": "uptime",
    "timestamp": "2017-02-16T21:59:33Z",
    "unit": "",
    "value": 14270
  },
  {
    "name": "processes",
    "timestamp": "2017-02-16T21:59:33Z",
    "unit": "",
    "value": 178
  },
  ...
]

$ dcos node metrics --mesos-id=SOME_SAMPLE_ID --filter memory.total --filter swap.total
NAME          VALUE        UNIT
memory.total<PHONE_NUMBER>8  bytes
swap.total    0            bytes

@tamarrow thanks for your patience, I think this is ready for review 👍

Thanks for the speedy review! I think all your feedback is now addressed.

OK, we now have a --json flag for both dcos node metrics summary and dcos node metrics details, and I've addressed all the rest of your feedback @tamarrow .

@philipnrmn just the pydocs and then LGTM. @malnick can you take a quick look too?

thanks @philipnrmn. You have a few syntax errors
[07:01:39][Step 4/5] dcoscli/metrics.py:92:1: W293 blank line contains whitespace
[07:01:39][Step 4/5] tests/unit/test_tables.py:18:1: I100 Import statements are in the wrong order.from ..fixtures.metrics should be before from ..fixtures.node
[07:01:39][Step 4/5] tests/integrations/test_node.py:12:1: I101 Imported names are in the wrong order. Should be assert_command, assert_lines, exec_command, fetch_valid_json, ssh_output

Oops 🔨

💥


Evaluation Code

Great work！Could you release the evaluation code?

The idea is great, I also would like to have a reference on the evaluation code.


Update docker-image.yml

fixed task dependency (only run tests after the Dockerfile was successfully built)

issue: the test task cannot access the docker image from the build task
-> make the docker image available as shared artifact

It's very difficult to make GitHub actions run concurrent tasks in the same context, so just put all commands as one task and use sub-tasks to identify the different sub-tasks.

test still do not work -> test if the docker image is named differently than expected

try to separate the build and test tasks and run them as concurrent jobs


isomorphic

I saw you are creating a v. 6.0. Excelent work!
Time to consider isomorphic? Very easy to do that with webpack.
If not support right out of the box, add it as a option flag maybe?

Hey there, @kflash. Thanks for the suggestion!
Isomorphic JavaScript seems cool, but I don't use it myself. Since it's easy enough to set up, maybe this is one of those features that individuals should set up after scaffolding a new project with the boilerplate?
One of the things I like about this boilerplate is that it's the bare minimum of what I want in every project, be it a little library, or a webapp, or whatever. Sometimes I need to tweak it after I clone it, but that's okay. It still provides me with a good foundation. I'm thinking this is one of those things that can be added to the solid foundation in the projects you want to use it on.
What do you think?

@jmeas Just mention it in the readme maybe?

If I mentioned everything that Webpack can do in the README, then I'd just be recreating the docs of webpack, right? I don't think isomorphic support stands out as a particularly special thing.
If you wanted, I could just add that it's built with Webpack, and that should be enough?

I think it should be enough. Basicly its all about index.js and server.js


Added a brief description and bullet points.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

added description and bullet points.


Test discovery hanging with Pester 5.2.0

Hi.  I tried to debug the extension, but couldn't see anything obvious - other than an error that Reset-TestSuiteState was not a recognised function.  This was shown in the Pester Explorer log.  When I reverted back to Pester 5.1.1, this error wasn't seen in the log.  Debugging the extension I could see the promise for pesterTestRunner.loadPesterTests() being resolved - so maybe the exception is caught by the Test Explorer extension before it gets the load promise result.
The symptom is the Test Explorer in VSCode shows no tests - clicking on the Test Explorer: Reload tests icon results in the icon spinning forever.
I suspect you've been caught by a breaking change in pester.  Some of my tests using modules fail in 5.2.0, so I'm happy to continue with 5.1.1 for now.
If I can provide any more details to assist you, let me know.
Thanks for this extension - attempting to debug it was my first exposure to VS Code extensions, so thanks for this experience and the instructions on your readme, even if I didn't actually manage to find the bug for you I learned how to step through a VS Code extension.  :)
Thanks,
Darryl

It hangs for me even with 5.1.1.
https://github.com/TylerLeonhardt/vscode-pester-test-adapter/blob/master/src/adapter.ts#L63  Here you have what looks like a correct set of tests in both 5.1.1 and 5.2.0. So probably issue with firing the event and receiving it by the test explorer?

Same problem here. Updated Pester from 5.0.4 (everything ok) to 5.2.0 -> test explorer doesn't show anything.

I, too, was experiencing the same issue after upgrading to Pester 5.2.0.  I made some progress, though, to "fix" the Pester Test Explorer VS code plugin.  I'm going to post my findings here so that others may weigh in on the changes before I (or anyone) submit a formal Pull Request.
The issue seems to be with the "Discovery Script",  ~/.vscode/extensions/tylerleonhardt.vscode-pester-test-adapter-0.0.23/powershellScripts.js, due to some of the improvements made in Pester 5.2.0.
Here are the modifications I made:

At line 30, I commented (removed) the call to Reset-TestSuiteState, as this function no longer appears necessary with Pester 5.2.0 due to the new session handling methods (New-PesterSession).
Lines 102-104, I removed the .BlockContainer. property from each of the $file references, as there is no BlockContainer property of $file, which was resulting in NULL "suites" being added as children to the root $testSuiteInfo object. The resultant reference(s) now look like this: $file.Item.FullName

The only other change that I made which seemed to help, was updating the VS Code setting for pesterExplorer.testRootDirectory to a single period (current directory) as this is the default for Pester.  (See  ([PesterConfiguration]::Default).Run.Path.Value)
Before submitting a Pull Request, I think it would be best to also add some logic to determine the version of Pester and then execute Pester version dependent code (e.g. Reset-TestSuiteState) based on said version.  Either that or require Pester v5.2.0 for a future version(s) of the Pester Test Explorer VS code extension.

Ah I remember, this is using the internal hack I wrote some time ago for Tyler when he was starting this up. IIRC this was to enable running just discovery? That is built-in now in Pester 5.2.0, you just need .Run.SkipRun = $true, and via PassThru you will get the result object with all the tests.

I would like to try and push people to use 5.2 since this is an official API instead of the hacky script @nohwnd gave me :)
In this work we should notify the user that Pester 5.0 & 5.1 support  will be removed in the future.

Thanks @nohwnd and @TylerLeonhardt , this helps provide the direction I need. I will take a 'stab' at updating the code and submitting a P.R.

If you have trouble, just let me know! Also if you can't figure out the notification part, that's ok. I can do it/provide my thoughts on that.


Amethyst fails installation on Android

Describe the bug:
Installing Amethyst through Androids Package Manager or SAI does not work. SAI says "DISPLAY_NAME column is missing."
Amethyst Details:

1.9.12

To Reproduce
Steps to reproduce the behavior:

Use Android 13
Download amethyst-v1.9.12.apk
Try installing it (for more error info use SAI)

Additional context
I found something on StackOverflow describing this bug: https://stackoverflow.com/questions/70770717/app-crash-when-installed-on-a-physical-device-error-display-name-column-is-null

Thanks, I'll check it out once I'm back home.

Well... I kinda forgot about this issue. Anyway, it worked. Thank you :)


Translation platform

Hello, maybe you could register this at Hosted Weblate to get some crowdsourced translations for the app? It is available here https://weblate.org/hosting/ :)

Hi Allan, thanks a lot for the tip :)


Redact secrets when debugging

Description
When using --debug, the secrets provided are output into the logs. They should be redacted. Which fields should be redacted is determined by which properties are airbyte_secret in the source/destination spec

Type of change

[ ] Bug fix
[X] New feature
[ ] Breaking change

Hmm actually one of my assumptions here is wrong. That assumption being that the source config is flat. let me get this to work with nested configs for the source and the destination.

This is awesome!!

Trying to figure out why this works locally but then the config key ordering is different when it is executed in the CI GitHub Action...


Bug Fix: S3 path becoming a link

Fix for #157
When opening Foundry's FilePicker, the target directory for S3 files incorrectly used the root of their full URL instead of their relative location within the bucket.
Removing the target directory does not break anything, as Foundry automatically retrieves the location of the current image.

Thankyou for this, it was not clear from your initial issue that this was happening during the filepicker bypass.


Add toolchain to gradle config file

This could probably be improved, but it looks to me like it might be needed to persuade the JDT Language Server (used by Eclipse and VSCode) to build the project cleanly.
In VSCode you have to import one of the test projects into the workspace (probably the same in Eclipse). If you do that before this change the build will fail and you won't be able to use the Java language features in the IDE.
With this change if you run with Java 17, but not the GraalVM edition:
$ ./gradlew clean test -Pcoordinates=io.netty:netty-common:4.1.80.Final

> Configure project :
GraalVM Reachability Metadata TCK
---------------------------------

> Task :test-io.netty-netty-common-4.1.80.Final
====================
Testing library: io.netty:netty-common:4.1.80.Final
Command: `/workspaces/graalvm-reachability-metadata/gradlew nativeTest`
Executing test...
-------
Command: [/workspaces/graalvm-reachability-metadata/gradlew, nativeTest]
Starting a Gradle Daemon, 4 busy and 4 incompatible and 6 stopped Daemons could not be reused, use --status for details
> Task :tck-build-logic:extractPluginRequests UP-TO-DATE
> Task :tck-build-logic:generatePluginAdapters UP-TO-DATE
> Task :tck-build-logic:compileJava UP-TO-DATE
> Task :tck-build-logic:compileGroovy UP-TO-DATE
> Task :tck-build-logic:compileGroovyPlugins UP-TO-DATE
> Task :tck-build-logic:pluginDescriptors UP-TO-DATE
> Task :tck-build-logic:processResources UP-TO-DATE
> Task :tck-build-logic:classes UP-TO-DATE
> Task :tck-build-logic:jar UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :processResources NO-SOURCE
> Task :classes UP-TO-DATE

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Error while evaluating property 'javaCompiler' of task ':compileTestJava'
   > Failed to calculate the value of task ':compileTestJava' property 'javaCompiler'.
      > No compatible toolchains found for request filter: {languageVersion=17, vendor=GRAAL_VM, implementation=vendor-specific} (auto-detect true, auto-download true)
...

Without this change it just fails with no indication of how to fix it.

Fixes #147

Unfortunately I think this PR may become the root of other strange issues for users. In particular, using vendor=GRAAL_VM will only work for GraalVM Community Edition. So it means builds would start to fail locally for those using GraalVM EE (or potentially other VMs like Liberica). This is caused by a limitation in Gradle. I'm not quite sure how to reconcile the needs in Eclipse JDT and this :/

It actually doesn’t work with the Liberica build already. That was one of the reasons I added the vendor label.

It actually doesn’t work with the Liberica build already. That was one of the reasons I added the vendor label.

Indeed it seems it works because the vendor reported by Liberica is GraalVM.

So we can merge this, but it means that folks trying to make it work with EE will have to manually tweak the build.

CC @dnestoro


Provide an option to disable the hero animation

Use case
Now if I want to disable the hero animation of one widget dynamically, I can only remove the Hero widget from the widget tree (or set a new unique tag for the Hero widget, but I think it's a tricky solution).
But for the performance of widget rebuilding, I want to keep it in the widget tree.
Proposal
Provide an option in Hero widget to disable the animation.

See the following gif:

When I remove the Hero widget from tree, it makes the image (the child of the hero widget) flash.


Import transpilation?

Is it possible to hack the Python import system to import Bython code, just like how we could do register hooks on Node? I don't want to transpile it all the time beforehand you know...
There's a proposal of adding a new import hook in Python, but it has been staggered for like 16 years. I don't know it that's relevant. Maybe we should exploit ImportError and then get the transpiled code injected there...
But I don't know Python at all, anyway.

I have just read about sys.path_hooks and it should be relevant, it allows file specific hooks to be added.

I suspect using bython modules in python would require some nasty hacking to make working, you may be onto something with sys.path_hooks, but I'm not sure how to change python to do this.
I originally included the -c flag for exactly this issue, so for now I would advise you to compile all bython files to python, and then run the python file:
$ bython -c *.by
$ python yourfile.py


[Feature Request] useQuery for POST request

Senario
For my experience, it quite often to use a POST request for searching resource or pagination.
For example:
POST /users/search HTTP/1.1
Accept: application/json
Content-Type: application/json

{
  "gender": "female",
  "limit": 20
}

Proposal
Maybe it could be
export const Request = z.object({
  gender: z.enum(["male", "female"]),
  limit: z.number().min(0).max(200),
});

export const Response = z.object({});

export type User = z.infer<typeof Request>;

export const userApi = makeApi([
  {
    method: "post",
    mutation: false, // <-- explicitly make it useQuery-able
    path: "users/search",
    parameters: [
      {
        name: "body",
        type: "Body",
        schema: Request,
      },
    ],
    response: Response,
  },
]);

I'll try to come with a solution that don't need to add mutation: false in endpoint description.
If not possible, your approach should be doable.

@QzCurious after trying. i settle to use your suggestion. just a minor change. the property will be named immutable: true

@QzCurious this functionality is now available in @zodios/core and @zodios/react v9.3.0.
Check documentation on how to use it.
new hooks:

https://www.zodios.org/docs/client/react#zodiosuseimmutablequery
https://www.zodios.org/docs/client/react#zodiosuseimmutableinfinitequery
new immutable api flag:
https://www.zodios.org/docs/api/api-definition

You don't need to set the immutable flag if you use useImmutableQuery, only if you also want to use your aliased version.
For example without immutable flag, your alias useSearchUser will by default resolve to use useMutation, and when setting it, it will resolve to useImmutableQuery.
There is for the same purpose a useImmutableInfiniteQuery to allow you to do infinite queries.
Note there is no alias for infinite queries.

What happend
At my first try (as I'm experienced with zodios and just take a quick view of this new feature), things are not going smoothly. I'm trying to do useQuery('users/search') with and without immutable: true. Neither one is working. Finally, I figure out that maybe I should do useImmutableQuery or use aliased version (but I'm not a fan of it).
@ecyrbe, I have you a advice:
useImmutableQuery is too flexible. It make team members confused when it should be used. And it's not intuitive.
Instead of introduce useImmutableQuery, immutable: true should produce useQuery with POST request without doubt.
Binding (or defaulting) GET to useQuery and POST, PUT, DELETE, PATCH to useMutation is Great. But I thought useQuery and useMutation should not know what the underlying http method it used (even it's not a http request). So it's okey to have a useQuery doing a POST request and even useMutation doing GET request.

Thank you for the feedback,
I understand the confusion, but the implementation was not done without trying to implement it with useQuery. Be assured of it.
Also take a look at the documentation, it can help you dissipate any confusion.
Anyway, one way of not needing to remember which one to use (useMutation, useQuery, useImmutableQuery), is to use Zodios aliases.
When setting immutable to true, you have correct overload with aliases for example. you should give it a try, and use aliases whenever possible.
As a reminder, GET should never be used for mutaions, it's not HTTP cache compliant to do so and will confuse your browser, your proxy, etc...Zodios will not add support for mutations on GET requests. Post is OK, as per HTTP spec, it can be idempotent. That's why i added this feature.

Tried with alias. I notice that I need to explicitly defind parameters for imutable aliased hook. Or typescript will throw an unfriendly error.
Though have empty body for a POST request is another uncommon senario.

Why are you using post requests without a body? If no body, use GET requests.

I get it. Thank you again for explaining.

@ecyrbe, I just want tell you I've integrate zodios with my new project successfully. And it works very well, especially the alias system without needing to manage cache keys!
There's another problem that @zodios/react seems not to be working if my typescript version were at 4.5.4 (4.8.3 works fine). I'll try detect the version it needs and open another issue.

Thank you, i'll track this down in an issue


Loop for vkGetQueryPoolResults is suspicious

A timeout loop was put in for vkGetQueryPoolResults in https://github.com/LunarG/gfxreconstruct/commit/75bc5b32da36cb172d57ef28f55d14458279c6f1 . I think 75bc5b3 may have a logic error.
I suspect that original commit erroneously causes kMaxQueryPoolResultsRetries runs through the loop if the capture was NOT_READY but replay is SUCCESS.  I think the loop needs to be skipped or exited early if capture was NOT_READY and replay is SUCCESS, but the loop should be honored if capture was SUCCESS and replay is NOT_READY until kMaxQueryPoolResultsRetries.

#1800 was drafted to resolve an issue seen in this code but removes the loop in the case of replay NOT_READY.  If we can resolve the logic instead, then maybe we don't need #1800 .


Add tests for flame_texturepacker

What could be improved
Add tests for flame_texturepacker.
Why should this be improved
Because we should have a well tested codebase.
Any risks?
No.
More information
https://github.com/flame-engine/flame/tree/main/packages/flame_texturepacker

i use the flame_texturepacker , Paired with SpriteAnimationGroupComponent， but can't work.
the code
  @override   Future<void> prepareAnimations() async {     for (var action in PlayerState.values) {       animations = {};       final sprites = atlas.findSpritesByName(action.name);       if (sprites.isNotEmpty) {         SpriteAnimation animation = SpriteAnimation.spriteList(           sprites,           stepTime: 0.2,           loop: true,         );         animations!.addAll({action: animation});       }     }     current = PlayerState.idle_down;     size = Vector2.all(60);     //         add(     //   SpriteAnimationComponent(scale: Vector2.all(0.5), animation: animation),     // );   }
help plz！

i use the flame_texturepacker , Paired with SpriteAnimationGroupComponent， but can't work.
the code
  @override   Future<void> prepareAnimations() async {     for (var action in PlayerState.values) {       animations = {};       final sprites = atlas.findSpritesByName(action.name);       if (sprites.isNotEmpty) {         SpriteAnimation animation = SpriteAnimation.spriteList(           sprites,           stepTime: 0.2,           loop: true,         );         animations!.addAll({action: animation});       }     }     current = PlayerState.idle_down;     size = Vector2.all(60);     //         add(     //   SpriteAnimationComponent(scale: Vector2.all(0.5), animation: animation),     // );   }
help plz！

@ycfay this is not related to the issue you posted in, please open a new one (and make sure to format your code properly).

@spydon im looking into this one, you can assign it to me :) gonna raise it too 100 💪

Awesome @ryzizub! :blue_heart:

@spydon im going to tackle this in hacktoberfest can I ask for adding a tag ❤ ?

@spydon im going to tackle this in hacktoberfest can I ask for adding a tag ❤ ?

The tag is already on the whole repo which is enough, but I'll add the tag here too! :)

@ryzizub not hacktober anymore, but are you still planning to tackle this? :innocent:

@spydon yep, had 0 time in October and until this month. During holidays till end of the year I should tackle that 😇


cargo-mobile2: 0.9.0 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tauri-apps/cargo-mobile2/releases.
meta.description for cargo-mobile2 is: Rust on mobile made easy!
meta.homepage for cargo-mobile2 is: https://tauri.app/
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.1 with grep in /nix/store/629z1i93mdk7kqilg38id9aqym0ppi1v-cargo-mobile2-0.9.1
found 0.9.1 in filename of file in /nix/store/629z1i93mdk7kqilg38id9aqym0ppi1v-cargo-mobile2-0.9.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-mobile2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/629z1i93mdk7kqilg38id9aqym0ppi1v-cargo-mobile2-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-mobile2 https://github.com/r-ryantm/nixpkgs/archive/aaa37c5df3f963a808722d519bbf93d7db15fbfa.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/aaa37c5df3f963a808722d519bbf93d7db15fbfa#cargo-mobile2

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/629z1i93mdk7kqilg38id9aqym0ppi1v-cargo-mobile2-0.9.1
ls -la /nix/store/629z1i93mdk7kqilg38id9aqym0ppi1v-cargo-mobile2-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-mobile2

Maintainer pings
cc @happysalada for testing.

Result of nixpkgs-review pr 277280 run on x86_64-linux 1

1 package built:

cargo-mobile2


Made the respective changes for Cisco Meraki Solution Installation Ex…

…perience for Playbooks, Custom Connector and CreateSolution Tool

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for Cisco Meraki Playbooks and Custom Connector files

Reason for Change(s):

Improving Customer Installation Experience for Cisco Meraki

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes

Note: If updating a detection, you must update the version field.

After the submission has been made, please look at the Validation Checks.

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@anki-narravula Please have a look on playbooks. Thanks


fix typo in /dfget/core/uploader/

Ⅰ. Describe what this PR did
fix typo in /dfget/core/uploader/
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   46.65%   46.65%
=======================================
  Files         111      111
  Lines        6602     6602
=======================================
  Hits         3080     3080
  Misses       3278     3278
  Partials      244      244

Impacted Files
Coverage Δ

dfget/core/uploader/uploader.go
88.07% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28e8f8...c9c259a. Read the comment docs.


Perform a performance pass on each action

There are several places the code is bloated and runs slower than it could/should. Should run over each action and profile to see if there's anything we can touch up. Some of the util functions are bloated.
This isn't super important, but would be nice to optimise where possible.

Covered in https://github.com/zackehh/cachex/commit/3ccbee25a9b36ca8994bdd27bafbf405df240c7a.


confirmSetupIntent always return Card details not complete

Describe the bug
When I try to call confirmSetupIntent with the given params in the documentation I always get the same response:
´Card details not complete´
To Reproduce
Follow the documentation here https://stripe.com/docs/payments/save-and-reuse?platform=react-native#react-native-collect-card-details
Expected behavior
The card is saved on stripe
Example of my code
      const billingDetails: PaymentMethods.BillingDetails = {
        email,
      };
      const { setupIntent, error } = await confirmSetupIntent(
        setupIntentResponse.data?.client_secret as string,
        {
          type: 'Card',
          billingDetails,
        },
      );

How do I send the card data to the setupIntent?

The card details are extracted from the CardField component. It needs to be in the same view that you're calling confirmSetupIntent. Here and example: https://github.com/stripe/stripe-react-native/blob/master/example/src/screens/SetupFuturePaymentScreen.tsx

@thorsten-stripe sorry to bother you again, it is in the same view
return (
    <StripeProvider publishableKey="my_test_key">
      <CardField
        postalCodeEnabled={true}
        placeholder={{
          number: '4242 4242 4242 4242',
          expiration: '10/24',
          cvc: '123',
          postalCode: 'C.P.',
        }}
        cardStyle={{
          backgroundColor: '#FFFFFF',
          textColor: '#000000',
          borderWidth: 1,
          borderColor: COLOR.gray_100,
        }}
        style={{
          width: '100%',
          height: 50,
          marginVertical: SIZES.MD,
          borderRadius: SIZES.MD,
          ...STYLE_SHADOW,
        }}
        onCardChange={inputCard => {
          setCardDetails(inputCard);
        }}
        onFocus={focusedField => {
          setInputField(
            focusedField ? INPUT_FIELD[focusedField.toString()] : '',
          );
        }}
      />
      <Text>{inputField}</Text>
      <Button
        disabled={!cardDetails?.complete}
        onPress={submit}
        style={{
          marginTop: SIZES.MD,
          borderRadius: SIZES.MD,
          ...STYLE_SHADOW,
        }}>
        Guardar
      </Button>
    </StripeProvider>
  );

The submit function does something like
      const setupIntentResponse = await createSetupIntent();
      const billingDetails: PaymentMethods.BillingDetails = {
        email,
      };
      const { setupIntent, error } = await confirmSetupIntent(
        setupIntentResponse.data?.stripeSetUpIntent?.client_secret as string,
        {
          type: 'Card',
          billingDetails,
        },
      );
      console.log('LOG: error ', JSON.stringify(error, null, 2));
      console.log('LOG: setupIntent ', JSON.stringify(setupIntent, null, 2));

I verified that client_secret and billingDetails are correct.
I debugged a bit on the kotlin code from android and in this code I found that instance is always null
    val instance = cardFieldManager.getCardViewInstance()
    val cardParams = instance?.cardParams

@thorsten-stripe did you have a chance to check my reply?

Any luck here @fdelacruzsoto ?

I'm also experiencing the same issue

Same here, when I call
const {confirmPayment} = useStripe();
confirmPayment(clientSecret, {type: 'Card'})

then in StripeSdk.swift, cardFieldView.cardParams is nil
let cardFieldView = cardFieldUIManager?.getCardFieldReference(id: CARD_FIELD_INSTANCE_ID) as? CardFieldView

Same issue, any workaround? This issue should be opened

I had to go back to v0.1.2 to make it works.


fix: only debug level logging includes access log

Description
This fix will log access on HTTP endpoints unless the log level is set below info.
This avoid excessive logging on readiness and liveness probe.
Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[x] If it is a core feature, I have added thorough tests.

Testing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.72%. Comparing base (fccd088) to head (409ee1a).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   94.72%   94.72%
=======================================
  Files          53       53
  Lines        1896     1896
=======================================
  Hits         1796     1796
  Misses        100      100

/cc @xrajesh @vbelouso

/lgtm
/approve


feat: improve fnn layer and model performance and remove some bugs

Closes #610
Summary of Changes
Fixed some bugs and improved the performance of some methods, there are still some changes to be made but it is helpful to merge this now as @Marsmaennchen221 and @Gerhardsa0 partly depend on it

I just wanna start a discussion here, so mby we should start an extra discssion thread.
Should there be an abstract Layer class, which contains all signatures of the Layer class, so the User gets better Feedback on the function calls.
We cant let the FNNLayer stay everwhere, because a neural network does not only exist out of fnn layers.
Aswell I question myself, do we want the user to change the activation function by himself?, or do we keep only internal handle.
And why do we use the softmax function for outputlayers greater 2 and sigmoid else?

I just wanna start a discussion here, so mby we should start an extra discssion thread.
Should there be an abstract Layer class, which contains all signatures of the Layer class, so the User gets better Feedback on the function calls. We cant let the FNNLayer stay everwhere, because a neural network does not only exist out of fnn layers.
Aswell I question myself, do we want the user to change the activation function by himself?, or do we keep only internal handle. And why do we use the softmax function for outputlayers greater 2 and sigmoid else?

Yes, i have already added an abstract layer class. For my use-cases setting the activation functions is rather simple and can be done automatically, altough I am not against implementing the option to let the user customize them as well, it might be worth it to provide the ability to do some experimenting. Softmax and Sigmoid are only set in the Classification use-case, since we need multiple probabilitys (1 for each class) when the outputlayersize is greater than 2 and only one otherwise.

:tada: This PR is included in version 0.21.0 :tada:
The release is available on:

v0.21.0
GitHub release

Your semantic-release bot :package::rocket:

@Safe-DS/library For future PRs, please separate renamings of public API elements from internal changes. One is a minor version bump (later even a major version bump once we have a 1.x.x release), the other is a patch version bump.


Add a note about the Spring Boot BOM

I wonder if we should add a similar note about maven. Most users use the parent project and that seems to work fine

The issue was observed with Maven and would probably also happen with Gradle. For clarity, I have just moved the position of the note.


⚠ Bofrost.lu has degraded performance

In 79ba46b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1104 ms

Resolved: Bofrost.lu performance has improved in 291a407 after 40 minutes.


ENH: add transformer from paired end to single end

This allows paired-end data to be used in contexts in which the reverse
reads can be ignored for the purposes of a method. This effectively
"downcasts" the paired-end sequences into single-end sequences.
@gregcaporaso this is what we discussed earlier on Friday, and it will allow us to use q2-demux:summarize on paired-end data without changing anything other than the semantic type annotation. It will also make it easy to compare dada2:denoise-single and dada2:denoise-paired on the same EMPPairedEndSequences artifact. This transformer basically just discards the reverse reads in the directory and MANIFEST.

Thanks @gregcaporaso!