Enable FiltersConfig and ScientificConditions on the BE

This one is to resolve #604

[x] extend UserSettings document schema: add filters and conditions
[x] add tests
[x] add default  endpoints

Sure, what is the current convention?
On Wed, Aug 7, 2024, 11:37 Jay @.***> wrote:

@.**** commented on this pull request.
In src/users/schemas/user-settings.schema.ts
https://github.com/SciCatProject/scicat-backend-next/pull/1337#discussion_r1706700980
:

| "TextFilterComponent";

+// Define the Filter interface
+export interface FilterConfig {

type: FilterComponentType;
visible: boolean;
+}

+// Define the Condition interface
+export interface ScientificCondition {

field: string;
value: string;
operator: string;
+}

+export const kDefaultFilters: FilterConfig[] = [
Generally it would be more appreciated if the naming is consistent with
existing naming convention within the application scope.
—
Reply to this email directly, view it on GitHub
https://github.com/SciCatProject/scicat-backend-next/pull/1337#discussion_r1706700980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZDFHGS2EAP2XA66NMUSGTZQHTE7AVCNFSM6AAAAABLUIVO5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRTG4ZTANZSGU
.
You are receiving this because you were assigned.Message ID:
@.***>

resolves #604

@Junjiequan how can I fix that PR check? Thanks

@Ingvord
feat: enable filters config and scientific conditions on the backend
The rules for PR title can be found in https://github.com/SciCatProject/scicat-backend-next/blob/master/.github/pr-title-checker-config.json

Cool! That worked. Thanks!
Also the whole thing looks a bit encryptic to me. Why do we need this? Is it possible to provide more descriptive error message?
Thanks again for the help

@Ingvord
It helps with mainly two things:

PR title prefix makes it easy to understand what kind of changes will be included in the PR.
Helps with complete & well organized release notes.

I believe the error messages won't matter too much, it just takes a little time to accommodate the title rules.

That's true if you do the project on a daily basis. Although if one only
rarely contributes something, they will have to accommodate with rules
every time 😆
On Wed, Aug 21, 2024, 13:32 Jay @.***> wrote:

@Ingvord https://github.com/Ingvord
It helps with mainly two things:

PR title prefix makes it easy to understand what kind of changes
will be included in the PR.
Helps with complete & well organized release notes.

I believe the error messages won't matter too much, it just takes a little
time to accommodate the title rules.
—
Reply to this email directly, view it on GitHub
https://github.com/SciCatProject/scicat-backend-next/pull/1337#issuecomment-2301829915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZDFHGKBJTVNGMOXETE3A3ZSR3GHAVCNFSM6AAAAABLUIVO5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRHAZDSOJRGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix issue with uploaded package not being wrapped properly

Previous 0.3.0 change failed to catch problem with upload routine
if user had extracted into a subdirectory.  This resulted in the
files in the "execution" directory being uploaded, not in the
app dir.  The only time that is different is when the user runs
extract("some_dir")

@zquestz Found that although it was designed to accommodate both methods, the upload routine was not modified to properly account for it.  We should run a manual test here too, but I added unit tests to inspect the archive to be uploaded so we don't revert on this.

LGTM but we need to figure out why 1.9.3 broke.

ruby 1.9.2 broke, not 1.9.3;
Gem::InstallError: rake requires Ruby version >= 1.9.3.

I can add lock the version of rake at a compatible version.

Manually verified that this works; used the mono-sample that tipped me off about this problem to verify.  Reran with/without the exacted directory provided and confirmed the nesting behavior.
Merging; leaving both commits rather than squashing since they are logically distinct.


python3Packages.cot: disable failing test

Motivation for this change
Fix build (https://hydra.nixos.org/build/164496381)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 155425 run on x86_64-linux 1

2 packages built:

cot (python39Packages.cot)
python310Packages.cot


Clickbench query 28 29 43 failed on SQLite accelerator

Running clickbench queries using DuckDB as connector and SQLite as accelerator, the following queries fail:
Query 28
Query Error Unable to query arrow: ConnectionError Rusqlite("no such function: character_length in SELECT `hits`.`CounterID`, avg(CAST(character_length(`hits`.`URL`) AS DOUBLE)) AS `l`, count(1) AS `c` FROM `hits` WHERE (`hits`.`URL` <> '') GROUP BY `hits`.`CounterID` HAVING (count(1) > 100000) ORDER BY `l` DESC NULLS FIRST LIMIT 25 at offset 36")

Query 29
Query Error Unable to query arrow: ConnectionError Rusqlite("no such function: regexp_replace in SELECT regexp_replace(`hits`.`Referer`, '^https?://(?:www\.)?([^/]+)/.*$', '\1') AS `k`, avg(CAST(character_length(`hits`.`Referer`) AS DOUBLE)) AS `l`, count(1) AS `c`, min(`hits`.`Referer`) FROM `hits` WHERE (`hits`.`Referer` <> '') GROUP BY regexp_replace(`hits`.`Referer`, '^https?://(?:www\.)?([^/]+)/.*$', '\1') HAVING (count(1) > 100000) ORDER BY `l` DESC NULLS FIRST LIMIT 25 at offset 7")

Query 43
Query Error Unable to query arrow: ConnectionError Rusqlite("no such function: date_trunc in SELECT `m`, `pageviews` FROM (SELECT date_trunc('minute', `hits`.`EventTime`) AS `m`, count(1) AS `pageviews`, date_trunc('minute', `hits`.`EventTime`) FROM `hits` WHERE (((((CAST(`hits`.`CounterID` AS BIGINT) = 62) AND (`hits`.`EventDate` >= CAST('2013-07-14' AS TEXT))) AND (`hits`.`EventDate` <= CAST('2013-07-15' AS TEXT))) AND (CAST(`hits`.`IsRefresh` AS BIGINT) = 0)) AND (CAST(`hits`.`DontCountHits` AS BIGINT) = 0)) GROUP BY date_trunc('minute', `hits`.`EventTime`) ORDER BY `date_trunc(Utf8("minute"),hits.EventTime)` ASC NULLS LAST) LIMIT 10 at offset 37")

DuckDB also fails with the same queries, for the same errors:
Q28:
Query Error Unable to query arrow: Unable to get schema: Catalog Error: Scalar Function with name character_length does not exist!

Q29:
Query Error Unable to query arrow: Unable to get schema: Catalog Error: Scalar Function with name character_length does not exist!

Q43:
Query Error Unable to query arrow: Unable to get schema: Binder Error: Referenced column "date_trunc(Utf8("minute"),hits.EventTime)" not found in FROM clause!


Fix close reflection stream

Signed-off-by: Marcos Candeia<EMAIL_ADDRESS>Description
Reset protoreflect client before closing gRPC connection
Issue reference
Please reference the issue this PR will close: #5291
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test


Revert "Dockerfile: run as user: linuxbrew"

This reverts commit 77afe94446e78e688ebde7a5e2b1249fc0a4afcd.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This broke CI in the test-bot repo: https://github.com/Homebrew/homebrew-test-bot/pull/653#issuecomment-900950998

Review period skipped due to critical label.

The better fix was https://github.com/Homebrew/homebrew-test-bot/pull/654


Is onetun production ready

RT, include boringtun and smoltcp.
Thanks

I would not use this in a mission-critical environment just yet.
In terms of stability: I haven't battle-tested onetun much beyond flooding it with requests (which it handled fine), and using it to forward a couple public services from a Kubernetes cluster to my homelab. I wrote a small Helm chart for it: https://github.com/aramperes/momoperes.ca/tree/master/onetun
In terms of completeness: I just finished the proof-of-concept last night, so there are some features I still want to add that are listed in the GitHub issues. If you have ideas, please open more issues!
WRT boringtun and smoltcp, they are currently still on 0.x versions, so make of that what you will. They also haven't been publishing releases in a while, and I'm depending on their bleeding edge features.


supervisor server in custom image run failed

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
custom image include the supervisor service,  when deploy this image, this error is occured:
Error: The directory named as part of the path /var/log/supervisor/supervisord.log does not exist.
For help, use /usr/bin/supervisord -h

I found that the user-container  mount the /var/log from knative
Mounts:
      /var/log from knative-var-log (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-q7dh2 (ro)

how to fix it?

looks like it is related to this issue https://github.com/knative/serving/issues/3809.

This is not KFServing issue, better to follow up with knative/serving#3809.
/close


Installation and Usage

Hello, I have read your paper and am interested in using ApproxASP. Are there instructions on installation and usage I can follow to run your code? Thanks!

Yes, please read the README, here:
https://github.com/meelgroup/ApproxASP2
It has links for downloading & installation.
Mate

@AdamIshay
ApproxASP is in branch approxsmc. I added a README in the branch.


Context as kwarg

If context were to be passed as a keyword argument instead of a positional one it would be easier to have functions that can be called regularly and also be queued.
For example:

async def get_pokemon_data(pokemon_name: str):
    url = f"https://pokeapi.co/api/v2/pokemon/{pokemon_name}"
    async with httpx.AsyncClient() as client:
        response = await client.get(url)
        if response.status_code == 200:
            return response.json()
        else:
            return f"Error: {response.status_code}"

If I wanted to keep this function callable AND queueable currently, I'd have to modify the function like so:
async def get_pokemon_data(ctx: Context = None, pokemon_name: str = None):
The undesirable behavior here is having to set a default value for pokemon_name, because otherwise I'd get a syntax error:
SyntaxError: non-default argument follows default argumentFlake8(E999)
If context was passed in as a kwarg, it could easily be modified to:
async def get_pokemon_data(pokemon_name: str, context: Context = None):
This makes even more sense if the function has a larger number of arguments
The only small drawback I see is that functions need to accept the same kwarg that it's being passed in by Worker.process:
task = asyncio.create_task(function(context=context, **(job.kwargs or {})))

you can just pass in a null context, or wrap the function, this is too big of an api change


Create skeleton of documentation

This is a very messy, very basic skeleton of what Masonry documentation will eventually look like.
Main points are:

Dedicated documentation modules.
Re-using most of the language from the RFCs.

Next steps are:

Flesh out the Widget documentation.
Rewrite all those docs in a less placeholder-y way.
Add chapter about the widget arena.
Spread out that pass documentation to the respective pass files.
Rewrite ARCHITECTURE.md.
Add screenshots.

Fixes #376 and #389.

I'm marking this as ready for review despite the TODOs because I think this is a stark improvement over the previous state of our documentation.
The next be steps would be:

Writing the "Testing widgets" chapters.
Rewriting doc in the rest of the crate to reference this tutorial (and especially the "Concepts and definitions" chapter).

This is a very welcome addition. I've been watching from the peanut gallery for the longest time, waiting for something like this. Thanks a lot for taking the time, I know how hard writing documentation is. <3

Thanks a lot for taking the time, I know how hard writing documentation is. <3

It's so much harder than it sounds.
You have to put your brain in a certain mode and pull things from it that it really doesn't want to give you by default.


Is this compatible with VR/AR??

I have some clients that want nothing at all, but they want it on VR/AR. Is your projet compatible with VR/AR? That would be/not be so sweet!!!

You can run it on VR. Just buy some VR hardware to test the blank image in VR!!!

But how do I implement it on VR?

No need to implement: It supports all platforms, including VR: write   once, -- run everywhere.
The output should be nothing, as advertised.
Is there any bug that I don't see maybe?..

Hummmm, let me check. Because I don't see anything on my VR headset. So it is working. But I am a bit afraid that the "nothingness" is because a bad SDK implementation and that would ruin my relationship with the clients...

I'm not sure, but it could be possible to give them white screen by turning on VR set and push some standard boilerplate there, but would it be pure nothingness anymore?

That is the main question. What is really nothingness? A blank screen is a blank screen it is something therefore it is not nothing...

I've heard that blind people see nothing, and this nothing isn't our black.
It is a topic for philosophical treatise, but what is programming in a whole perspective?
All this is about philosophy, so what philosophy better fits your clients?..

I think they are quite nihilistic. Any advice for that?


Allow setting impersonation extras

Problem
When an aks cluster is setup with EntraId Auth and Azure RBAC you need to pass "extra:oid" in order for impersonation to work. This means weave gitops' impersonation will not work. Example:
kubectl get GitRepository -A --as<EMAIL_ADDRESS>
Results in
Error from server (Forbidden): gitrepositories.source.toolkit.fluxcd.io is forbidden: User<EMAIL_ADDRESS>cannot list resource "gitrepositories" in API group "source.toolkit.fluxcd.io" at the cluster scope: Azure does not have opinion for this non AAD user. If you are an AAD user, please set Extra:oid parameter for impersonated user in the kubeconfig

If you create a user in your kubeconfig with
  user:
    as<EMAIL_ADDRESS>    as-user-extra:
      oid:
      - 00000000-0000-0000-0000-000000000000

along with the normal user config and use it the (via a new context) it works
Solution
I'd like a feature to be able to map oidc claims to impersonation extras
Workaround
I added oidcGroupsPrefix: "weave:" to my issuer secret then manually configured RBAC for specific groups using things like the following yaml. Not ideal since the whole point of using Azure RBAC is to centralize this sort of thing
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: weave-global-admin
subjects:
- kind: Group
  name: weave:00000000-0000-0000-0000-000000000000
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: cluster-admin

Additional context

Simple implementation could accept a set of keys to lookup in the OIDC ID Token and store these on the UserPrincipal as a map.
It's a bit tricky because the values for the the Extra data are slices of strings, so, similar to the existing code, you'd need to parse these as strings or slices of strings, and convert the string to a slice when necessary.
Then inject these here https://github.com/weaveworks/weave-gitops/blob/2af6d1133a5717fc3b0f367734443557074b1548/pkg/kube/config_getter.go#L61 into the ImpersonationConfig.


Linux is not Unix-based

Documentation claims: " It's commonly used in Unix-based systems such as Linux. " But Linux shares no history with Unix. See: https://i.redd.it/kgv4ckmz3zb51.jpg

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bbc788cf-2460-3a99-a770-796471df0293
Version Independent ID: b84f1579-fd1b-f0e4-a46a-27ba15a58baa
Content: SSH authentication with Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/fundamentals/auth-ssh.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @janicericketts
Microsoft Alias: jricketts

@michael-o
Thanks for your feedback! We will investigate and update as appropriate.

Corrected in PR Correct Unix reference #230440

#please-close

#please-close


HTTPTileDataSource headers not used

Apparently the headers are not used even if set:
https://github.com/CartoDB/mobile-sdk/blob/9f69d558b1b1f7c29b932cb3beb47880d160720f/all/native/datasources/HTTPTileDataSource.cpp#L102
That's an issue with some we tile providers like IGN (France) which require the "User-Agent" header

Thanks for reporting this. We will have the fix in 4.1.1 release.


Integration test

Describe the pull request:

[ ] Bug fix
[ ] Functional change
[X] New feature
[ ] Code cleanup
[ ] Build system change
[ ] Documentation change
[ ] Language translation

Pull request long description:

Adds an docker-compose based integration test to be run on each PR.
Pipline images are set to latest from the GitHub Container repository.
Checks are made at the following point in the ingestion workflow:

on shoveling to files.inbox
on shoveling to files.verified
on shoveling to files.completed
DB check in the end to ensure the data set ID is correct in the end.

Changes made:

fixed the entrypoint script to create the shovels correctly
whitespace and shellsheck fixes to the entrypoint script
added an gitignore file so we don't commit test files by misstake
added a bunch of helper scripts
added the integration test

Related issues:

Fixes #24
Additional information:

Release note:

Documentation change:

Mentions:

Looks good to me. I saw some SE specific Cert req (req_distinguished_name Section in setup/ssI.cnf file) that I'm unsure of should be included ?

That is not SE specific, it can be needed if the container is running under a different name than the SAN in the certificate.
Like if you run this in docker with public certificates then the public hostname will not match the name in the docker environment.

req_distinguished_name

Needs to be there, for the test suit it doesn't matter what the values are really


Add to Packagist.org

Hi. Would you consider adding this lib to packagist.org please? That way it can be downloaded & managed via Composer.
It's just a matter of creating a composer.json file and then submitting the repo to https://packagist.org

Looks like someone already has
https://packagist.org/packages/prawnsalad/nexmo
You'll need to contact Packagist at<EMAIL_ADDRESS>to get it corrected to your own account.
Also, just so everyone knows, you don't have to ask a package maintainer to add their package to packagist, you can simply specify the repository:
https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

Closing. I don't know the status on this. Nor do I use PHP anymore.


Fix variant start position for Insertions

Issue: [reported by the GENIE site]
If the alleles share a common prefix then the script removes the common prefix and adjusts the start/end positions accordingly.
For example:

In INS,  17 37880981 A AGCATACGTGATG, the tool outputs 17 37880982 - GCATACGTGATG
In SNP, 17 37880981 AG AT, the tool outputs 17 37880982 G T
In DEL, 17 37880981 AG A, the tool outputs 17 37880982 G -

Although, this is correct for SNPs and DELs, the start position cannot be fixed for INS's by removing the common prefix "A". For insertions, the listed position always correspond to the position of the last base in the reference sequence and the position immediately preceding the first inserted base.
Fix made:
If the variant_type is resolved to INS, the start_pos is not updated. And end position also gets resolved correctly.
After fix, the tool outputs 17 37880981 - GCATACGTGATG for INS.

Thanks @leexgh, @inodb. I did a test run with Genome Nexus and it seems to be updating the positions and alleles correctly.
Here's a test file if you would like to check :
test_ins.txt


docs(proxy-cache-advanced): add ignore_uri_case

Description
Add ignore_uri_case configuration parameter to proxy-cache-advanced, similar to https://github.com/Kong/docs.konghq.com/pull/5270/files (for proxy-cache).
Testing instructions
Netlify link:
Checklist

[X] Review label added
[X] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

all done @lena-larionova, thank you!


Client will allow ID_UNCONNECTED_PONG from non-local address

This isn't a major exploit or anything, however it can be annoying if something like this were to happen where an external server was exploiting an open port.

Fixed in version 2.3!


Fix compiler warnings and types

These changes were made to remove warnings while making polipo compile under mingw64.
Most changes are regarding pointer type portability issues.

Fix pointer warnings: rejected.  I don't understand why this is needed.
Fix socklen_t warning: applied, thanks.
Fix compiler warnings: rejected, since it adds new #ifdefs and therefore makes the code even more unreadable than it already is.  If you find a better way of achieving this, please submit a new pull request.
Fix pid_t redefinition error: applied, thanks.
Add Makefile.mingw: rejected, I'm not going to maintain two almost identical makefiles.  Please add any variables that you need to the makefile, and update the README.

Pointer warnings IS needed because inttypes.h provides us the way not to hardcode, but to use library-provided types, pointer to types macro and makes it really integrated into system. The warning fixed by that patch are 'short-hand' warnings : of course they are OK when you're testing something, but even in beta code they are blckers of bad-style. Please approove that patch. Thanks

inttypes.h was introduced in C99.  Polipo is supposed to be written in C86, and is portable to things like SVR4.
Of course, it might make sense to rely on C99 now, but that should be a conscious decision, not the side-effect of an incidental patch.  (And there are better reasons to use C99 than avoiding a warning on a proprietary platform — VLAs are the big one.)

Thanks for the review.
The Makefile was not supposed to be in the pull request, I pushed it to my repo after creating this PR and forgot it would be added.
Fix Pointer warnings is not strictly needed as unsigned long should be fine for most architectures, just that using intptr_t will match the actual pointer size for the architecture without wasting space. The print format becomes that ugly mess though.
Fix Compiler warnings adds the ifdefs to remove unused definitions when S_ISLNK is not defined. Since there are blocks already conditional to it, it makes sense to remove everything related to the define explicitly. I agree a better solution would be to avoid these conditionals, which I think would mean adding a compatibility feature using WinAPI calls (use CreateSymbolicLink, then check with GetFileAttributes if  FILE_ATTRIBUTE_REPARSE_POINT flag equals IO_REPARSE_TAG_SYMLINK).

About C99 and C86 - ifndef directive was introduced initially, so if you REALLY need C86 compatibility - use the ifndef+define workaround


Omit less important details in diagram

Omit details so that the text size in the diagram matches the text size of the main text in DG.

Codecov Report
Base: 62.28% // Head: 63.04% // Increases project coverage by +0.76% :tada:

Coverage data is based on head (f5be792) compared to base (4348890).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
+ Coverage     62.28%   63.04%   +0.76%
+ Complexity     1681      854     -827
============================================
  Files           312      156     -156
  Lines          6462     3242    -3220
  Branches        828      418     -410
============================================
- Hits           4025     2044    -1981
+ Misses         2087     1020    -1067
+ Partials        350      178     -172

Impacted Files
Coverage Δ

...ava/seedu/modquik/logic/commands/ClearCommand.java

...ent/predicates/ModuleContainsKeywordPredicate.java

...a/seedu/modquik/logic/parser/ArgumentMultimap.java

...edu/modquik/model/tutorial/UniqueTutorialList.java

...logic/commands/reminder/UnmarkReminderCommand.java

.../main/java/seedu/modquik/ui/ReminderListPanel.java

.../seedu/modquik/logic/parser/ArgumentTokenizer.java

...in/java/seedu/modquik/model/datetime/Datetime.java

...logic/commands/tutorial/DeleteTutorialCommand.java

.../predicates/StudentIdContainsKeywordPredicate.java

... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Merge pull request #1 from apache/master

test

PR seems to be temporary, closing. Feel free to reopen if needed.


Update package.json

Updated Deployment Tracker client dependency to pick up latest version. Delivers #2

Merging the change.

Closing the issue.


Add buffered reading of binary data to JsonTextReader

I have a JSON containing a binary property with a very large value:
{
    "NormalStringValue" : "test",
    "NormalIntValue" : 1,
    "LargeBinaryValueInBase64": "AQB...."
}

The standard JsonTextReader.ReadAsBytes reads the value of a LargeBinaryProperty at once so a large byte array is allocated. I want to avoid this. For XmlTextReader there is a ReadContentAsBase64(byte[] buffer, int offset, int count) method which can perform buffered reading of a BASE64 content.
Is it possible to implement such a functionality for JsonTextReader?

Hello!
Maybe someone could give a hint on how to implement it myself?
I don't see any extension points in JsonTextReader which are suitable for this.

I have the same need. I don't know what developers who create such APIs (which return blobs in JSON) have in their minds, but I have to work with that, so streamed property value reading is a must have. I would advocate for a Stream-typed read result instead of reading in chunks into a buffer.


Dotnomad/unknown type creation

This PR fixes two things:

When an type="unknown" deployment is created the entrypoint could be blank when we reach normalizeConfig, which would cause the entrypoint field to be missing from the Configuration and the files array to only contain a /
When we create a new deployment / configuration combo, if the Configuration we create is invalid (read type="unknown") the API calls to update the file lists with the Posit deployment record / configuration file were failing

Why were the APIs failing?
The API calls were failing because when we get a Config from a file we validate said file before decoding it:
https://github.com/posit-dev/publisher/blob/fa07fcf2c8ce07083676118228a02597dbcecd01/internal/config/config.go#L63
This makes sense, we have to have a valid file to get a valid Config, but the strict nature of not allowing type: "unknown" means our config creation here https://github.com/posit-dev/publisher/blob/66fdddbfdf991354e01e4a0d35aa28e9d98ba98e/internal/inspect/detectors/all.go#L79 causes the following API call to fail.
We have some ways we get around this in others parts of the code: https://github.com/posit-dev/publisher/blob/8b382dec983fd0bfbc3f0d9c7cae2902b1f28421/internal/services/api/put_configuration.go#L80
It would be ideal, when we don't care about the type, to be able to ignore that part of our validation. Or even better allow the unknown type completely until it matters.
Intent
Resolves #2419
Type of Change

[x] Bug Fix

[ ] New Feature

[ ] Breaking Change

[ ] Documentation

[ ] Refactor

[ ] Tooling

Approach
The approach here was two fold.
The backend now produces a more correct configuration in cases where type = 'unknown'.
The frontend also handles the API calls when creating a new deployment separately, only bailing out when absolutely necessary - like when a file fails to be created.
The tradeoff here is that type = 'unknown' configurations will not have the .posit files listed in their files field - at least with the way it is currently implemented.
Automated Tests
I will add an automated test. For now the PR is in draft until this is done.

The tradeoff here is that type = 'unknown' configurations will not have the .posit files listed in their files field - at least with the way it is currently implemented.

Could you say more about this + what the practical impact is on users who fall into this circumstance? I think it's ok / an improvement, but I want to make sure we think about that and confirm it.

Could you say more about this + what the practical impact is on users who fall into this circumstance? I think it's ok / an improvement, but I want to make sure we think about that and confirm it.

Absolutely. The impact is deployments initially made with the unknown type won't have the generated config with .posit files.
This is due to the API calls to include the files failing because type: 'unknown' makes the file fail validation prior to decoding.
To the point @marcosnav made we can change this avoid this tradeoff.
Part of the reason I mentioned it as happening "in this current state" was to avoid going down a rabbit hole of fixing several bugs / weird behaviors at once without opening it up to some discussion.

Could you say more about this + what the practical impact is on users who fall into this circumstance? I think it's ok / an improvement, but I want to make sure we think about that and confirm it.

Absolutely. The impact is deployments initially made with the unknown type won't have the generated config with .posit files.
This is due to the API calls to include the files failing because type: 'unknown' makes the file fail validation prior to decoding.
To the point @marcosnav made we can change the behavior and avoid this tradeoff.
Part of the reason I mentioned it as happening "in this current state" was to avoid going down a rabbit hole of fixing several bugs / weird behaviors at once without opening it up to some discussion.

Sorry, I meant this from the perspective of our users. Correct me if I'm wrong on anything here, but I was hoping for something like: we want to encourage folks to include their config + deployment files in what they publish to connect so we include them in the files section of the config (but folks can decide not to if they want). But in this situation, for whatever reason these files aren't being included. This makes it so that the deployment is still possible (to be attempted at least), we just degrade the behavior where the config + deployment files aren't included in the bundle. That's less good for us (we believe people should ~always include those files), but it's not blockingly detrimental to our users since they are able to proceed with their deployment (likely see that it fails, and then fix the issue and then actually proceed).

we want to encourage folks to include their config + deployment files in what they publish to connect so we include them in the files section of the config (but folks can decide not to if they want). But in this situation, for whatever reason these files aren't being included. This makes it so that the deployment is still possible (to be attempted at least), we just degrade the behavior where the config + deployment files aren't included in the bundle. That's less good for us (we believe people should ~always include those files), but it's not blockingly detrimental to our users since they are able to proceed with their deployment (likely see that it fails, and then fix the issue and then actually proceed).

This is all correct. The extra bits I would emphasize are:

the type = 'unknown`` config is invalid so while it doesn't stop deploying it does mean the sidebar views aren't visible so to fix the .posit` files missing the user would have to

fix the config by choosing a valid type
manually edit the config to include the .posit files

To be clear this PR is the most minimal fix to #2419. My hope is to either add to this PR, or follow it up and fix this so .posit files are always included.
See this conversation in Slack for a bit more: https://positpbc.slack.com/archives/C05D7NZD52S/p1731025235725539

the type = 'unknown' config is invalid so while it doesn't stop deploying it does mean the sidebar views aren't visible so to fix the .posit files missing the user would have to

Ah yes, that's definitely good to highlight / would appear as an at least semi-broken / weird state for most users.

To be clear this PR is the most minimal fix to https://github.com/posit-dev/publisher/issues/2419. My hope is to either add to this PR, or follow it up and fix this so .posit files are always included.

nods yeah, minimal is great! And I'm not trying to push us to not do that — just wanted to confirm that we are doing a minimal thing that also doesn't make our user's end experience worse (and be explicit about that + what those things are).


How to prevent generation of strings, or get the token ID in sequence_generator from a string (with BPE)

I want to prevent the generation of some arbitrary strings.
I.e. I want to take a token like "hello" or "line_break" and prevent the model from generating it.
This seems pretty easy to fit in here where the sequence_generator code sets the logprobs of banned_tokens (which here are previously used ngrams but could be whatever) to -math.inf.
However, I'm having trouble finding an elegant way to find out the string mapping to decoder token as it is here?
I printed out a generated string and list of tokens, and found that the mapping doesn't match what I get if I call "encode" or directly query the encoder and decoder dictionaries. Or what I get from looking at encoder.json + dict.txt that I initialised the model with.
I took the token IDs that I got from printing them during generation and literally hardcoded them in as banned_tokens, and it worked fine, but I'm hoping there's a more elegant way of doing this? Since apart from it being hacky, if I change to a model with a different vocab I have to change the hardcoding :p.
I am using bart (though this is not a bart specific issue) and fairseq cloned and pip installed from master and pytorch 1.4.

Ah never mind - I realised that calling encode does work to get me the IDs, it was just a weird thing with mapping the same string to multiple IDs based on whether it had a space in front, for some reason.
So I presume I just need to use both the space and non-space versions and that will work fine.


Doesn't build on windows 10

Build fails with
..\src\win\tasklist.cpp(17): fatal error C1083: Cannot open include file: 'atlbase.h': No such file or directory [C:\Users\I\Documents\habitinstaller\leaf\node_modules\process-list\build\processlist.vcxproj]
  win_delay_load_hook.cc

Unfortunately, i can't repeat this issue in my windows 10. This file is the part of Microsoft ATL (Active Template Library).
The main problem is skipping prebuild version 😞

I try to build it on the fresh installation with python and node-gyp installed.
For sure I need .Net Framework or something that contains missing headers.
Or maybe you can create a prebuilded binary with node-pre-gyp?

@w01fgang This module already used prebuilded binaries. Which version of nodejs are you using?

@reklatsmasters Thanks for the speedy reply!
I tried with 9.3.0 and 8.9.3

@w01fgang It's a bug in prebuild/prebuild-install#15. There are 2 fixes:

install Microsoft ATL (Active Template Library) as I said above
use this module as dependecy from npm, see couchbase/couchnode#74

I'll try it! Thanks!


Update docfx.json contrib to exclude

Add aliases to contrib to exclude:
"AngelaMotherofDragons",
"dstrome",
"v-dihans",

Docs Build status updates of commit 443746f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Draw shapes on iOS

Hi @liodali,
Are you considering working on draw shapes on iOS? If yes, when it will be available? if not, do you have an approach to work in this behavior? I can help with that.
BR.

sorry for late reply
Im planning to add but not now since in ios sdk use MapData to draw so i need to understand more how we can draw with it

Hello @liodali,
Is there any update regarding this issue?

yeah, check our 1.0.0-rc-2 we added support for shapes


Optimize upgrade CI, and use the self-built image in the release branch

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

ci failed because there was no corresponding v0.9.4 chart, because 0.9.4 release failed.


Volunteering - Polish translation

Hi, I've just started translating your text into the Polish language. Do I have your agreement to continue?

Translations are welcome, just link to this repo in there somewhere and then we can add a link to your repo.

Okay, I've added the link "Link do oryginału (wersja angielska)", which redirects to the original repo

I've finished the translation and added link to this repo. Only corrections left. Here is URL to my repo:https://github.com/Deloryn/functional-programming-jargon

Sorry, I haven't been paying attention to this project but I just added the link to your translation to the main doc. Thanks!


Incorrect nested error wrapped to ArrowError:External variant for joins

Describe the bug
This line of code makes impossible to get real reason of error.
.map_err(|e| ArrowError::ExternalError(e.to_string().into())),

It could produce such error: External error: Arrow error: External error: Arrow error: External error: Arrow error: External error: Arrow error: Csv error: ... as a string-message, not a type
That's actually really bad, because under Csv error it could be useful info. But instead of this I receive text error with too many nested External variants.
To Reproduce
Occurrence depends on execution plan and my data that caused this is rather large.
I believe it should be possible to cover with simple test of error type:
    #[tokio::test]
    async fn check_error_nesting() {
        let once_fut = OnceFut::<()>::new(async {
            Err(DataFusionError::ArrowError(ArrowError::CsvError("some error".to_string())))
        });

        struct TestFut(OnceFut<()>);
        impl Future for TestFut {
            type Output = ArrowResult<()>;

            fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
                match ready!((&mut self.0).get(cx)) {
                    Ok(()) => Poll::Ready(Ok(())),
                    Err(e) => Poll::Ready(Err(e)),
                }
            }
        }

        let res = TestFut(once_fut).await;
        let err = res.expect_err("future always return err");
        // ... some checks of error type

    }

Expected behavior
I expect to be able to take error type instead of message in string format.
However, I see that it's reference and need to figure out right way to handle this case. But current one breaks error handling system for datafustion.
Additional context
I would like to fix this behavior
And it probably make sense to request implementing find_root for arrow (like exists for datafusion error) - but that's out of scope

Possibly related https://github.com/apache/arrow-datafusion/issues/4991 and https://github.com/apache/arrow-rs/pull/3567

@alamb don't think so, check #4983, I made a fix. It had to_string() usage, so it was impossible to downcast error to relevant error type


Dead project ??

Dont see much activity and having problems running.. ???
is this a maintainer missing ??

@pedromorgan what problem are you having?


Make the type case insensitive

Currently, type is sensitive, which is not convenient.
For example, the following example does not work:
@InProceedings{Foo,
  author    = {Tom and the gang},
  booktitle = {Something amazing},
  title     = {An awesome research},
  year      = {2022},
  month     = {jun},
}

But with type all lowercase, it works:
@inproceedings{Foo,
  author    = {Tom and the gang},
  booktitle = {Something amazing},
  title     = {An awesome research},
  year      = {2022},
  month     = {jun},
}

Thanks for your attention. This will be fixed in the next version.

The case-insensitive entry type support has been included in the version 1.1.6.
Thank you for your feature suggestion. @Heziode


Task query results don't display on Obsidian Mobile when description starts with the tag

Expected Behavior
Task query result should display on Obsidian Mobile when description starts with #task tag.
Or #task tag should be moved to the end of the line after saving.
-[] My task description. #task 🔁 every day 📅 2022-09-01
Current behaviour
Task query result displays 0 tasks when description starts with #task tag.
-[] #task My task description .🔁 every day 📅 2022-09-01
Steps to reproduce
Desktop

Create or edit existing task on Obsidian Desktop.
After saving the task it automaticaly adds #task to the START of the task line.
On Obsidian Mobile such task doesn't display in task query.

Mobile

Create or edit existing task on Obsidian Mobile.
After saving the task it automaticaly adds #task to the END of the task description.
On Obsidian Mobile such task display correctly in task query.

Some task queries I use that shows the behavior:
not done
due today
sort by description

not done
due before today
sort by due

Which Operating Systems are you using?

[X] Android
[ ] iPhone/iPad
[X] Linux
[ ] macOS
[ ] Windows

Obsidian Version
0.15.9
Tasks Plugin Version
1.12.0
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
When saving task on Obsidian mobile move/add #task tag to the end of the line (before metadata).
Should be -[] My task description. #task 🔁 every day 📅 2022-09-01
Not -[] #task My task description .🔁 every day 📅 2022-09-01

Hi @kovtunos,
I am really struggling to understand what is going on here. I can't see any reason why Tasks would put the tag at the end of the line on mobile - we have had numerous requests for this behaviour, so it's not something that others generally see.

Please confirm that you have fully restarted Obsidian since updating the plugin.
Please attach screenshots of your Tasks settings on both Desktop on Mobile. Thank you.
If at all possible, please supply a video of the behaviour on both platforms.

Thank you all for the tips. It was really configuration out of sync on both devices.

Now everything is working fine. Issue can be closed.


Faucet not working

Go to Discord, navigate to testnet-faucet channel
Type: !faucet client agoric1kj8hmeca3rw2cndj6zu98hfqmcqwgpxhq8l4ay
It should top wallet with funds, but error occurs:
@EmiT | RBF, Sorry, the faucet failed

@michaelfig is it clear to you what's going on?
in #bot-control I see:
Error: rpc error: code = NotFound desc = rpc error: code = NotFound desc = egress not found: key not found

https://discord.com/channels/585576150827532298/755903970907652291/879395866752979014

@michaelfig is it clear to you what's going on?

Argh.  I switched a condition, and was getting things exactly backward (only provision if already provisioned)!  This is fixed now.

I updated the title to indicate the root cause.

@dckc I am still having issues with the faucet, can't get tokens to be delivered to this address. I am feeling hopeless already, I have tried many times, but still none worked for me: https://testnet.explorer.agoric.net/account/agoric1qr2s775y7umrm90ykjtfnhyk76zsrapx3z2xm8


chore: bdd-spring-1576278063 to 0.0.1

chore: Promote bdd-spring-1576278063 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


About the pretrained model on sceneflow dataset

Thank for your codes!
In your paper, you have mentioned that experiments on kitt12 and kitt15 are finetuned using the pre-trained model on scene flow. HIt is very slow when I download the scene flow dataset. So I want to train the network on kitti12 directly.
However I didn't find the pre-trained model on scene flow, could you please provide that pre-trained model, thank you very much!

Updated.


upload/merge page

The script for the upload function on the Upload/Merge page should be able to discern whether the file being uploaded is either CSV or Excel format. The need for two separate buttons to handle the two formats seems redundant. Could be reduced to a single 'upload/merge' button and potentially reduce some user confusion.

The data requested for these two actions are different:

If a file is a CSV file, there is a possibility of specifying a number of lines to skip at the top and at the bottom. This is very useful when processing csv dumps produced by third party applications that have some prelude on top (stating the type of report) or some additional lines at the bottom. The form that appears after clicking in this link allows to enter these numbers. This option is not available if the format is XSL.

If a file is a XSL file, there is a possibility of specifying the sheet of the spreadsheet to read. This option is not available if the file is CSV.

So, for this reason I think it makes sense to keep both options, otherwise, an alternative would be to increase the number of steps by 1. The first step only requests the file and a second (new) step would request either the lines at the top/bottom to ignore (if CSV) or the name of the sheet (if excel). Then the rest of the steps would follow. I think this solution complicates the sequence of steps by one, while the double link solution seems a good tradeoff.
Happy to reopen if needed.


Added Azure SQL database Import/Export operations to Sql Client

The change include new generated classed for Azure SQL database import/export operations and the scenario tests.

Can one of the admins verify this patch?

Hi @llali, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (llali). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci add to whitelist


New Azure Repository

Start of pipeline jfrog artifactoty

Thank you @hunksd6 - what is the purpose and context of this issue? Is it missing details? Thanks.


Support for AMD module loader

I'm not a webpack user currently so having difficulty loading react-big-calendar into my project which uses AMD modules.
Could there be a build output which would support UMD?

Hi there, we aren't going to add a UMD build unfortunately. This project is intentionally forward looking in what it supports such asnot trying to work on browsers without flexbox or, now legacy formats like AMD and monolithic umd browser builds. I do realize folks may be stuck on older projects and tooling, but the cost to maintainers her to support these different things is significant especially since we don't need them so we've chosen to not support them here. Thanks!


Update OWNERS

Signed-off-by: Dale Haiducek<EMAIL_ADDRESS>open-cluster-management/backlog#14277

/cc @ChunxiAlexLuo


Test and Enable OMNITRACE_BUILD_DYNINST, if needed

Test find_package(Dyninst) and if it is not found, then enable OMNITRACE_BUILD_DYNINST and
DYNINST_BUILD_{TBB,BOOST,ELFUTILS,LIBIBERTY}.

I know this seems like a good idea but it isn’t. I used to deploy this strategy and it becomes really problematic when you have an external package installed and CMake isn’t finding it (or one of the external deps) for some reason. I’d highly advise against it.


fix: temporarily switch to our own nerdctl-full bundle with patched runc and buildkit

Issue #, if available:
Description of changes:

Temporarily deviate from nerdctl's default nerdctl-full bundle in order to patch runc and buildkit (for more info see)

Testing done:

Verified new versions locally

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Had a few flaky tests fail, but most passed, especially those related to these changes. Merging.


feat: Add Support for UUIDs

Adds support for UUIDs. They are represented as a String on the dart side, and as an uuid in the database.
Fix #635
I decided to introduce _uuid as a 'virtual' type.
Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[x] I added new tests to check the change I am making.
[x] All existing and new tests are passing.
[x] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.
Breaking changes
none
(In theory, someone could have used _uuid as a type before, but since the name starts with an underscore, this is more then unlikely)

@fischerscode, perhaps it would be nicer to use the https://pub.dev/packages/uuid package to do this proper?

So, you would use UuidValue instead of String?
The downside is that we would need an additional dependency.

@fischerscode, perhaps it would be nicer to use the https://pub.dev/packages/uuid package to do this proper?

Implemented in #641 as an alternative to this PR.

This PR now includes c2672e5. I'm not sure, why the change occurred while regenerating...

I'm closing this one. The one with Uuid objects feels more correct to me.


add immuds port

This PR adds a new port: immuds, a header-only immutable data structures library.

[x] Changes comply with the maintainer guide.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed library includes a "copyright" file that matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Notes

immuds is a header-only library, so no linking is required. It provides immutable data structures for C++ developers.
The library is compatible with all major platforms supported by vcpkg and has no optional dependencies.

Available Headers
The library provides the following immutable data structure implementations:

immutable/Stack.h: A stack implementation that returns new instances upon modification.
immutable/PriorityQueue.h: A priority queue implementation.
immutable/Queue.h: A queue implementation.
immutable/Set.h: A set implementation.
immutable/HashMap.h: A hash map implementation.

Usage Instructions
After installing via vcpkg:
./vcpkg install immuds

To use it in your CMake project, follow these steps:

Include the vcpkg toolchain in your project configuration:
set(CMAKE_TOOLCHAIN_FILE "/path/to/vcpkg/scripts/buildsystems/vcpkg.cmake")

Find and include the immuds headers:
find_path(IMMUDS_INCLUDE_DIRS "immutable/HashMap.h")
target_include_directories(main PRIVATE ${IMMUDS_INCLUDE_DIRS})

Write a C++ program that uses the library:
#include <immutable/HashMap.h>

int main() {

     immutable::Stack<int> stack;
     stack = stack.push(3);
     stack = stack.push(11);
     std::cout<<stack.top();
     stack = stack.pop();
    return 0;
}

@microsoft-github-policy-service agree

I converted this to draft because it looks like the build is broken. Please feel free to fix and un-draft.


Use recommended analytics tracking

Closes https://github.com/dart-lang/angular_components_example/issues/63

Closing this out – it has issues. See original bug.


Add the new kmm.node.kubernetes.io/gc-delay finalizer to all new jobs.
Only clear the finalizer after deletionTimestamp+gcDelay.
Fixes #1075
Also fixes MGMT-16641.
/cc @yevgeny-shnaidman

/test all

Codecov Report
Attention: Patch coverage is 60.97561% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 75.38%. Comparing base (2ae391e) to head (01846ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   75.56%   75.38%   -0.18%
==========================================
  Files          66       66
  Lines        5909     5928      +19
==========================================
+ Hits         4465     4469       +4
- Misses       1216     1229      +13
- Partials      228      230       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm


Fix deprecation and do a few tweaks

Just wanted to make sure there were no deprecations and tweak things a bit. I'd like to further work on this to get the setup actually running in the initializer, instead of manually run before it, but this is functioning for now.

@diogomafra would you potentially be interested in becoming a part of Ship Shape and maintaining this addon together at https://github.com/shipshapecode ?

@diogomafra please let me know. I need to use this on my website, so I'd like to have this merged in and the new version published to npm. I'd be glad to maintain this with you as a part of Ship Shape, if you'd like. We need more addon developers to join up and create cool things.

@rwwagner90 Thank you, but I will keep this project here for now.
I just publish the version "0.1.2" with this fix.


Python crashed every time I try to use xgboost

I used to have working XGBoost in December, but recently it started to crash every time I try to call any function from XGBoost package. I reinstalled package using this binaries. It has installed successfully, but anyway each time I try to run it it crashes my python.
Environment info
Operating System: Win10 64

Package used (python):
xgboost version used: 0.6
I got the following message when I try to run XGBoost under PyCharm IDE:

`"D:\Program Files\Python\python.exe" "D:/PythonProjects/Coursera/Algorithmic_Toolbox/RecycleBin/XGBOOST TEST.py"
[09:03:58] c:\dev\libs\xgboost\dmlc-core\include\dmlc./logging.h:235: [09:03:58] C:\dev\libs\xgboost\dmlc-core\src\io\local_filesys.cc:109: LocalFileSystem.ListDirectory ../data error: No such process
Process finished with exit code -1073740791 (0xC0000409)`

Actually, I have no idea why is it looking for xgboost in c:\dev\libs\ since I don't have such location and local copy of repository is placed in another folder. Prior to this I had version from here and it was looking for xgboost package in another place. Maybe something wrong with Windows Registry?
I also noticed, that using import xgboost I get no DeprecationWarning. When XGBoost worked in Dec, I got such message regarding model_selection and sklearn\cross_validation.

I reinstalled xgboost using whl from here. I got following error trying to launch some basics of xgboots:
`"D:\Program Files\Python\python.exe" "D:/PythonProjects/Coursera/Algorithmic_Toolbox/RecycleBin/XGBOOST TEST.py"
D:\Program Files\Python\lib\site-packages\sklearn\cross_validation.py:44: DeprecationWarning: This module was deprecated in version 0.18 in favor of the model_selection module into which all the refactored classes and functions are moved. Also note that the interface of the new CV iterators are different from that of this module. This module will be removed in 0.20.
"This module will be removed in 0.20.", DeprecationWarning)
[23:55:36] d:\build\xgboost\xgboost-git\dmlc-core\include\dmlc./logging.h:235: [23:55:36] D:\Build\xgboost\xgboost-git\dmlc-core\src\io\local_filesys.cc:104: LocalFileSystem.ListDirectory ../data error: No such process
Process finished with exit code -1073740791 (0xC0000409)`
The error is the same, but differrent locations. What can it be?

Looks like it's visiting some local file system but ../data directory doesn't exist. Can you verify if it is because of path? The DeprecationWarning is very fine from scikit-learn

Same issue. The module can't deal with relative path properly. If I replace the ../data with absolute path, then it works fine. Nevertheless, whenever it encounter a wrong path, it crashes the python kernel complete.


Peek of a change hides its beginning

When I use Go > Next/Previous change from the main menu, the peek view is shown over the editor. The change in question is shown above the peek window and if it’s a bit longer, its beginning is hidden. I usually want to see (and sometimes also edit) the beginning of the change. When I try editing directly in the peek view (which usually shows the beginning I am looking for), it says “Cannot edit in read-only editor”.

Note: Just one line is hidden in the screenshot but I hope you get the idea…
Expected behavior
Either of the following:

The beginning of the found change should be shown when using Go > Next/Previous change.
The peek view should be editable.

Enabled extensions

Extension
Author (truncated)
Version

svn-scm
joh
2.10.6

My system information

CPUs
Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz (4 x 2294)

GPU Status
2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled

Load (avg)
undefined

Memory (System)
7.89GB (0.70GB free)

Process Argv

Screen Reader
no

VM
0%

VS Code version
Version: 1.45.0-insider (system setup)
Commit: ec0d19789f89d4c25895f4a0cf364276cfb0c6ed
Date: 2020-04-20T06:08:30.812Z
Electron: 7.2.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 6.1.7601
Note: I’m reporting this on Windows with SVN (using an extension) but I’ve also experienced the problem on macOS using the built-in Git support.

Why not making the editor editable?


Fixed adobe-air-sdk SHA256 mismatch.

Fixed adobe-air-sdk SHA256 mismatch.

Please update the version as well (<IP_ADDRESS>).

Updated build number.

The checksum of this download has changed once again.
The current checksum for the version <IP_ADDRESS> download is:
6ce96ce97f2a88ccbc06838f30c743c81e05eb8ab0a82216a1da45cbe30f626e

The version and build number remain unchanged: <IP_ADDRESS> (taken from the air-sdk-description.xml file from within the archive).
There's however a newer version, <IP_ADDRESS> available at this URL:
http://airdownload.adobe.com/air/mac/download/19.0/AdobeAIRSDK.tbz2

Its SHA256 is as follows:
c449ed15cd7722d53cd178c4095e0ce2f815b8f544bd40780a652e382156a1b4

When updated, this PR should resolve #265 and obsolete #266.

This pull request can be closed as it has been superseded by commit 59c590e.


Job: add support for partial updates

In order to flag jobs as started/finished, the start_time/end_time fields require updating
A partial_update endpoint allows doing this

I'll have another think about it, for a more holistic apptoach. ;-)


Updated agents that did not have create handlers

If there was no create handler specified, the create handler was set to the the modify function.

Some code has been lost as part of these changes, so that needs to be fixed.
And adding explicit nil checks for status means we get log.Fatal instead of panic from the runtime. which is much easier to debug.
Finally, I don't see the benefit of adding an identical create and modify handler in the agents. Doesn't simplify nor clarify the code. What is the motivation for those changes?

In PubSub module, we currently do:
if create {
if sub.createHandler != nil {
// invoke create handler
sub.createHandler(....)
} else {
// Invoke Modify handler which is the default
sub.modifyHandler(....)
}
} else {
// Modify
sub.modifyHandler(....)
This was put in to transition into these changes easily. But it is always better to make the application explicitly register a create handler than assume if it is not registered, modify handler is the one to use. Hence the changes,,.

This was put in to transition into these changes easily. But it is always better to make the application explicitly register a create handler than assume if it is not registered, modify handler is the one to use. Hence the changes,,.

If that's how you want to proceed I suggest two things (in addition to the naming and comment issues I just flagged):

either rename all of the Modify functions which handle create and modify to CreateOrModify, or (better in my opinion) add a comment before each one of them saying "This handles bot\h create and modify events.)
replace the conditional in pubsub with log.Fatal if a handler is not present.
(Note that this is still somewhat inconsistent since we don't require handles for the Initialized/Synchronized events, nor Delete. So I don't know which set of handlers we should require.)

@archishou can you do
git fetch upstream master
git rebase -i upstream/master
and resolve the conflicts?

@archishou I still need you to do the rebase to be able to pull this to master

I've done it twice and I don't see any merge conflicts

I've done it twice and I don't see any merge conflicts

You've merged master into your branch. But you need to rebase and ideally squash your 31 commits into one. There should be no commits in your branch history with "Merge branch master ...".
I'll slack the error which prevents me from pulling this into master.


chore: avoid hash key monomorphization in debug build [WIP]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

All e2e tests failed. 🤣

#9659


Bug | CMP for applications are incorrect

Describe the bug
CMP of application is 19 of complaint is 103 and ST number 51
Issue in generation of numbers.

Issue - CMP number was generating different ? it should be matching?    Cross check cmp numbers in application doc and the actual case.  cmp no should be same for all docs  @manimaarans @Hemadri-Chinna

Hi @devarajd94 this is working as per PRD, Please share the more information if required any changes


just a test

do not merge
just a test for mattermod

Build Mobile Apps label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Build Mobile Apps label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Build Mobile Apps label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Android build App: https://releases.mattermost.com/mattermost-mobile-pr/PR-2251/PR-2251.apk
iOS build App: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2251/PR-2251.plist

test link

itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2251/PR-2251.plist

itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2251/PR-2251.plist

iOS build link

https://tinyurl.com/y7qyq3bh


Move tests from jest to karma

Jest just hasn't been moving very quickly development-wise. I wonder if we should move our tests to karma. We can use karma-commonjs-plus for mocking and isparta-loader to get proper code coverage reports again. Also, our tiny test suite takes ~2.5 seconds to run, which seems like way too long.

I'd be for this. Jest is cool but doesn't seem to have much traction. This would let us not have the weird "stuck on node 0.10" thing anymore too.


icu4c 74.2<EMAIL_ADDRESS>

Update<EMAIL_ADDRESS>

:beers: @BrewTestBot has triggered a merge.


global: refactoring

@lnielsen it looks good. After fixing tiny issues we can :shipit:

Ready :rocket:


ripple on top

related to #5 as ImageView can only make use of a ripple drawn on top of an image

done


[openssl.org #4513] BIO socket connect failure was not handled correctly

Given that BIO_connect  (crypto/bio/b_sock2.c) returns 1 on success or 0 on failure.
This call can produces the wrong result (openssl/crypto/bio/bss_conn.c)
case BIO_CONN_S_CONNECT:
	BIO_clear_retry_flags(b);
	ret = BIO_connect(b->num, BIO_ADDRINFO_address(c->addr_iter),
					  BIO_SOCK_KEEPALIVE | c->connect_mode);
	b->retry_reason = 0;
	if (ret < 0) {    // <-------------------- corrected to ret == 0
            // handle connect error, but was never executed
        }

Regards,
Davide

+1

Cheers

Ping?  Second reviewer needed

+1

Merged!


chore: add new fields to artist achievements [WIP]

The type of this PR is: chore
This PR solves GRO-1564
Description
We need to reveal data about residencies, awards, and private collections in the Career Highlights section of the artist page, so that users can learn more relevant context about the artists.
Related PRs:
https://github.com/artsy/gravity/pull/16085
https://github.com/artsy/torque/pull/1329
https://github.com/artsy/metaphysics/pull/4815
Where it is supposed to go:

What it looks like with data:
https://user-images.githubusercontent.com/15628617/221579932-46c06d05-bff7-4017-8d2c-7646b6c74a2e.mov

Still waiting for that MP PR to be deployed: https://github.com/artsy/metaphysics/pull/4829


[0.7] Incorrect Vec in Suspend or For

Describe the bug
I has server fn load data from D1, try run cargo leptos build. But leptos always got as non-vec.
Leptos Dependencies
leptos = { version = "0.7.0-rc1", features = ["experimental-islands"] }
leptos_axum = { version = "0.7.0-rc1", default-features = false, features = [
  "wasm",
], optional = true }
leptos_meta = "0.7.0-rc1"
leptos_router = { version = "0.7.0-rc1" }
leptos_dom = "0.7.0-rc1"
leptos_config = "0.7.0-rc1"

I found a problem in my code. I has 2 fn same name for server(ssr) and non-server.
And, new question. In big project, need abstraction #[server] and how to make it work with simply code.
Currently, my solusion is create a controller module for server and  non-server:
#[cfg_attr(feature = "ssr", path = "controller/ssr.rs")]
#[cfg_attr(not(feature = "ssr"), path = "controller/todo.rs")]
mod controller;

In ssr.rs and todo.rs, I public 2 fn same name for fix problem with non-server.

I do not understand your second post, and I don't see a description of a bug that I can identify or a way to reproduce it in what you have provided. How would you like to proceed with this issue?

Sorry for not detail.
In my case has multi server fn and duplicate use like in server fn
use std::sync::Arc;
use axum::Extension;
use leptos_axum::extract;

I want to simply it, and found example https://github.com/leptos-rs/leptos/blob/main/examples/counter_isomorphic/src/counters.rs, it not best but work


docs: Updating Python installation section

cc @BewareMyPower @shibd @RobertIndie @Demogorgon314 @Anonymitaet
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[ ] doc-not-needed
(Please explain why)

[x] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

Matching PR in forked repository
N/A

Preview should be almost the same (except style) with the render md version:

@Anonymitaet comments resolved. Could you give this patch another turn?


during a machine pool update, the nodes are tear down without draining

This is probably the root cause for https://github.com/giantswarm/roadmap/issues/1993

I did a bit of research on the topic. Draining of worker nodes when using AWSMachinePools is not currnetly implemented in CAPA. This feature is blocked by this Graduation of EventBridge Feature. And this is the ADR explaining the proposal.
There was a PR to implement the feature but it was closed because of the mentioned "Graduation of EventBridge Feature".
I believe the final implementation would involve deploying this component in our clusters https://github.com/aws/aws-node-termination-handler

There is also https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2023

There is a k8s built-in mechanism that we could try https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/

Regarding the above ShutdownGracePeriod. Kubeadm allows patching the Kubelet config (see here) but this was added in 1.25. I'll see if this can be done with a pre/post kubeadm command.


Death screen from void damage does not show player name

When using a "default" server as from here, if a player falls into the void, they are presented with a death screen that simply states "fell into the void." In the chat, however, the correct message, "Username fell into the void" is displayed. I wasn't sure if this constituted a bug or if it was up to the developers using Minestom to handle, but I was told to report it, so here we are.

Void damage is not done by Minestom anymore as of #1937


HARP-10478: Apply text POIs margin to collision box and text offset.

Additional text margin (used as padding between icon and text) was not
applied to the text position, resulting in growing collision box, but
without effect on relative distance between label icon and text.
This path fixes it and adds support to bounding box measurement via
TextCanvas that are not 0, 0 anchored. This means that change will work
even without margin applied.
Signed-off-by: Krystian Kostecki<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

:exclamation: No coverage uploaded for pull request head (harp-10478@aed02ac). Click here to learn what that means.
The diff coverage is n/a.


Turn this majestic piece of script into a module

BrettMillerIT: turn it into a powershell module and load the module in your profile
RyannosaurusRex: Yea, that makes sense, @BrettMillerIT
RyannosaurusRex: Nice
BrettMillerIT: PSGallery
BrettMillerIT: nuget repo effectively
BrettMillerIT: then it's just a case of Install-Module ps-alias


Worker bundle contains first level deep dependencies

When the worker code imports modules (first level) which import other modules (second level), then modules from second level are not included in the output worker bundle file.
Here's an illustration:
Worker.js -> import moduleA -> import moduleB
The moduleA will be included in the worker.bundle.js, while moduleB will not be included.
Is this the expected behaviour or an I doing something wrong?

@knee-cola I guess it's a bug. Would like to provide a test case?

While trying to reproduce the issue I discovered that it works as expected. I misdiagnosed the problem.


devbox: sirepo connection refused

I can't connect using LocalForward

I can. Just needed the right configuration


Added fields to collecting event, ability to sort by added field

Feature or enhancement
When I database a specimen and parse out all information for the collecting event, it is necessary to have a waterBody field and PublicLand/Property field.
Currently these do not exist in the Collecting Event section. For an aquatic entomologist, waterbody is an important criterion to search by, as well as Public Land for writing up reports.
I have exported data from TaxonWorks and the waterBody field exists in the DwC & CSV exports but there is no way to enter that information into the system when databasing, so waterBody always comes back blank.
Location
Task-CSD or New Collecting Event
Screenshot, napkin sketch of interface, or conceptual description
It would be helpful to have PublicLand after locality and waterBody after habitat.

Your role
Aquatic entomology lab assistant

Ping @tmcelrath.
@lvhart2 thanks. Several bits:
1 - If you are a project manager then you can make the fields appear.  I've add the one attribute (BodyOfWater) you requested, there are many attributes in the INHS collection not being shown Comprehensive. However, I can not see the other one, "Public Land" maybe it's under a different attribute name?
2- You can use the DwC exportor to chose which additional fields to export.

3- In the INHS project I mapped BodyOfWater to the DwC export by filling in the Uri with the data for the TDWG field waterBody: http://rs.tdwg.org/dwc/terms/waterBody (partially hidden below)

When we regenerate the index this will populate the column and you'll be able to at least order by page within Filter collection objects by clicking on the column header.


Changed collectd.conf location definition

Collectd methods are based on systemctl calls.
Thus it is logical to retrieve collectd.conf file
location from collectd.service file of DUT.
It is defined using collectd option "-C ".
Test run setup_file (JSON) key "collectd_conf_path"
gets obsoleted.
Added "cat" command to service_lib.py.
Updated collectd object definition in linux_host_bash.py.
Signed-off-by: Orest Voznyy<EMAIL_ADDRESS>

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Features/stats card

Finished stats card for dashboard and fixed a few bugs for admin page

merging to wrong branch


Implement no connectivity screen on next steps

Description:
This PR implements connectivity check and displays a warning if there is no connectivity on the next steps page.
This needs design rework which can be easily implemented since we have all checks we need in place!
Screenshots:

With the new Exposure History flow, you are probably going to have to rework this a bit. Sorry!

@zhaccc There was a change made to the build checks so you'll have to merge the latest from develop and push to this branch so the build_debug_android passes.  Sorry for the hassle!

@zhaccc I think you might want this on the ExposureDetails screen, but now it's on the NoExposures screen…


Failed Migration Log file output moved to ~/prisma folder

When a migration fails it creates a file in the root directory (failed-applyMigraion_2019-702115724.md), my preference would be to see this in the prisma/migrations folder.

Scheduling for removal this cycle.


No way to validate a Time format string

In 0.1 era srtftime used to return an error when format string is not valid, which is removed in the current Time::format. This makes it hard to get a format string from the user (context: https://github.com/osa1/tiny/pull/163).
It'd be good to either return an error (instead of panicking) or provide a validation function for format strings.

I could provide a function that returns a boolean indicating if a formatting string is valid. In almost all cases, though, an incorrect formatting string is a programmer error, which is why I opted for a panic.
Look for this being on master within a couple days!

boolean indicating if a formatting string is valid

Could you return a string describing the problem, instead of a bool? It seems like you already have a string (shown in the panic message).

Sure, that's doable as well. If you're using the standard library, you could actually capture the panic message now. That's obviously far from ideal, though.

Implemented on master. There's a method with the signature fn validate_format_string(s: &str) -> Result<(), String>.
Is this for a private binary, or is this a crate that would need a new release on crates.io? If the latter, I can definitely do so.


IntelliSense for Object Literal Properties

In both the TypeScript Playground as well as VS Code, code hints don't appear complete for properties of object literals, and the goto definition doesn't seem to work:
interface Item {

    /** Doc-comment. */
    alpha: number;
}

let item: Item = {

    alpha: 10
//    ^
//     \---- Goto definition not working?
//      ---- Code hint doesn't display doc-comment?
};

item.alpha = 10;
//     ^
//      \---- Goto definition works :)
//       ---- Code hint shows doc-comment :)

// Since `alpha` is a required property,
// I am obliged to declare it upfront in object literal form..
//  ..I am forced to miss out on intellisense features?

Note, the property's type is displayed in the code hint, and the refactor/rename function does work -- so it's not all missing.
I was hoping to fully leverage intellisense features in TS files that I am using like JSON files to declare data structured in accordance with TS interfaces. Am I going about this the wrong way, or is this currently a lacking TypeScript/IntelliSense capability?
Loving TypeScript with VS Code,
Thanks!

It'd be nice if this worked.
For anyone looking to implement this, the fix would be (in services.ts) to use the contextual type of the object literal (the same way we do to establish the completion list for the property names) to remap the property names inside the literal to their corresponding symbols in the contextual type. Once that's hooked up, everything should just work.

Anyone should make sure that the following case works correctly, in that go-to-definition at /*use*/ jumps to /*declaration*/
interface I {
    xyz: number;
}

/*declaration*/let xyz = 10;
let obj: I = {
    xyz/*use*/
}

Would be really nice if this worked. It makes object literals much harder to use without it.

I've just run into this as well on a conversion from js -> ts with property heavy objects. I'm almost wondering if using simple classes is the way to go, that way the intellisense works and makes life much easier...

This works now


Doc: update documentation contents

Explain how events are generated from composite requests
Add application guide section.

@Kappuccino111 I moved the contents of the introduction.rst into index.rst in my last commit. This makes the documentation landing page less empty and improves the separation of chapters in the pdf.


Compare benchmarks checksum to reduce execution time and noise

Not sure if this has been tried already but would it make sense to compute some sort of checksum of the benchmark binaries in CI and compare them against the ones from the baseline? We could avoid running benchmarks when the checksum doesn't change. That should reduce the turnaround of the benchmark pipelines and help with the interpretation of noisy results.

Yes this is the high-level caching we'd want to do. Although note that we'd need to check both the compilation artifacts and the runtime ones. Bazel would give us the correct dependency analysis, but we'll need to hack something together ourselves for CMake :-/

Besides the checksums on compilation and runtime artifacts, we also need to consider the benchmark configuration.


add adjustment of the topographic layout parameters

When using the mne.preprocessing.corrmap method, it is not convenient to modify the number of columns and drawing parameters of the topographic map, as shown in the following two pictures:
The result displayed by the original code:

Add results for column parameters only:

So I added parameter fig_adjuct to corrmap and _plot_corrmap function, which makes it easy for us to adjust the parameters freely. The example results are as follows:
example 1: When set fig_adjust = dict(ncols=3, top=0.8, hspace=0.3)

example 2: When set fig_adjust = dict(ncols=2, left=0.1, hspace=0.3, wspace=0.8)

Nice! I will try to take a look at this tomorrow!

Nice! I will try to take a look at this tomorrow!

Thanks for your look!

It looks like you have a bit of a problem with your branch and rebasing. If you look in the files changed tab at the top, you'll see some changes that you don't intend to make to MNE like deleting the find_muscle_components function which is from a PR that I wrote recently. Thus, you need to have the latest updates in the development branch before you can make changes. To do that you should do the following before you make a new branch.
git checkout main
git pull upstream main
git checkout -b my_feature_branch

Since you've already made a new branch and it's now out-of-date, you can do (in the future it would probably be a good idea to name your branch something like topo-params that has to do with the particular PR FYI)
git checkout mne-python-snail
git rebase -i upstream/main

That might work but I'm not exactly sure what you did so that you didn't have what's called a merge conflict where the MNE main branch has some code and your branch has conflicting code (starting from an earlier history shared point and trying to change the same lines as have been changed in main). You might want to just do
git checkout mne-python-snail
git checkout -b saved
git checkout main
git pull upstream main
git branch -D mne-python-snail
git checkout -b mne-python-snail

Then copy paste in your changes again (I know that's a pain, maybe someone else knows an easier way) then
git add -A
git commit -m "fix conflicts"
git push origin mne-python-snail --force

Where the force will push to your branch even though you started a new history.
I know those are a lot of instructions but the first step in a PR is getting the files changed tab to just show the things you actually want changed, that's what will eventually become part of the main MNE code. Hope that helps!

Nice! I will try to take a look at this tomorrow!

I took a quick look, hope I didn't steal your thunder!

Nice! I will try to take a look at this tomorrow!

I took a quick look, hope I didn't steal your thunder!

Thank you for your guidance. I will revise and resubmit it.

Thank you for your guidance. I will revise and resubmit it.

I think it would be useful to split it into two separate issues / PRs:

controlling number of columns and rows
changing other options in grid layout

I suggest this so that we stay consistent for example with plot_topomap method of Evoked that has ncols and nrows argument. Controlling the number of columns and rows should be done using the same arguments here.
Wrt controlling the grid layout - we can figure out in a separate PR/issue if the mne defaults could be improved (there was a similar issue about IC labels overlapping topomaps some time ago which could be solved too). If not - we could maybe add a gridspec_kw argument that is passed to matplotlib when laying out the grid.


DockerFile

Description
SmartRedis should have a base Dockerfile that users can look at and use as a template for including with their containerized jobs.
Justification
Any user wanting to run a containerized workload with SmartRedis will be able to use the Dockerfile to build an image and include that image in their container.
Implementation Strategy
Write a DockerFile for SmartRedis that

Installs dependencies
builds the static lib into /usr/local/lib
build the python client and installs it into python environment.

I have reviewed the PR. Thanks for the contribution! make lib actually builds the Python client too it just doesn't install it. usually we have users run pip install . or pip install -e . for editable installs.
Typing this out now I am thinking it might be better to just pip install the Python client directly. (i.e. pip install smartredis), but this wouldn't be good if we wanted to use this image for testing (we would need to build).


[Feature Request] Support for remote-related extensions to VSCode

Thank you so much for creating such a wonderful extension.
Can you support remote-related extensions to VSCode?

Remote - SSH
Dev Containers
WSL

I have checked that the yamafiler.useRecommendedKeybindings setting does not seem to be respected for remote-extension related cases.
I was able to confirm that it works to some extent by explicitly adding the following settings to the VSCode keybindings.json.

https://github.com/artakase/vscode-yamafiler/blob/880f40a405ac3eb0395d916bb4af8b145db21c5a/package.json#L162-L324

Also, Unfortunately, the yamafiler.delete command for the delete function does not work correctly in remote extension environments. There may be other functions that do not work as well. :(
The following are the environments I tested the feature in:

Mac (Remote - SSH)
Windows (WSL)

Thank you for your report. I would like to support remote extensions.
Please apply this workaround to keybindings.json:
{
    "key": "d",
    "command": "yamafiler.delete",
    "args": {
        "useTrash": false
    },
    "when": "resourceScheme == yamafiler && editorTextFocus"
},

Hi, Thank you for checking the issue.
I have added the args setting for the yamafiler.delete command in the keybindings.json file and confirmed that it works correctly.


[MM-23784] Removed unnecessary code for focusing the mattermost view

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
On Windows, when creating a new server using the + button or the 'Sign into another Server' menu item, a second webContents would be created for that server and would cause some events to be received by the wrong webContents.
I'm not 100% sure why this is happening, but it would appear that while calling focusOnWebView() on the MattermostView, a call to webview.getWebContents() is made and removing that call causes this issue to disappear. It would appear that focusing is still working without this call, so I have removed it. My thoughts are that getWebContents is returning a new WebContents object other than the one created, but I cannot confirm for sure. This feels like an Electron issue that we've happened to stumble across.
Tested on Windows 10 and macOS Catalina.
Issue link
https://mattermost.atlassian.net/browse/MM-23784
Test Cases

Open Mattermost Desktop on Windows, and make sure some text is on your clipboard
Press the '+' tab to create a new server
Fill out the details and press Add.
Ctrl+V to paste the text into the new server
The text should paste successfully.

@devinbinnie Could this be cherry-picked to v4.4 or is this risky?

@devinbinnie Could this be cherry-picked to v4.4 or is this risky?

I think it's fine to cherry-pick to v4.4.


I want to add floyd warshall algorithm in Java in dynamic algorithms

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

sorry this algo. has been in all four languages


v3.1.1 version is raising Module parse failed: Unexpected token in index.mjs

I've added this component via npm and when i compile my code I get this exception when using v3.1.1 of this component. It does work correctly with version 2.2.0
ERROR in ./node_modules/stale-while-revalidate-cache/dist/index.mjs 516:41
Module parse failed: Unexpected token (516:41)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See Concepts | webpack
Node v16
Typescript 4.5

Hi, thanks for reporting the issue. I can see the error is thrown because of the Nullish coalescing operator (??) characters in the dist file. According to Node.green, it has been supported since at least Node.js v14.5.0
Can you double-check the Node.js version that you're using when the build is running?

I'm using Node v16.14.0

Thanks for the link. I'll take a look at releasing a version without nullish coalescing.

Hey Marco, v3.1.2 should now not contain any nullish coalescing operators.

Thanks!


Gulp sub task names are truncated

Gulp sub task names are truncated

Are you using 0.1.0 or master? Can you show me a screenshot?

I have un-installed Gulp app, so I can't deliver a screen shot, basically, the problem is that I have several tasks that have prefixes like "compress-css-', for example "compress-css-main', "compress-css-mobile' e.t.c, these all show up in the list as "compress-css'

Oh, yeah. I'm seeing that too. Just tried master, and it's fixed there.


[SPARK-31753][SQL][DOCS][FOLLOW-UP] Add missing keywords in the SQL docs

What changes were proposed in this pull request?
update sql-ref docs, the following key words will be added in this PR.
CLUSTERED BY
SORTED BY
INTO num_buckets BUCKETS
Why are the changes needed?
let more users know the sql key words usage
Does this PR introduce any user-facing change?
No
How was this patch tested?
No

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #129159 has started for PR 29883 at commit 5a8cba7.

Test build #129159 has finished for PR 29883 at commit 5a8cba7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129159/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33774/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33774/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33774/
Test FAILed.

Test build #129161 has started for PR 29883 at commit ceba14b.

Test build #129161 has finished for PR 29883 at commit ceba14b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129161/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33776/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33776/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33776/
Test PASSed.

Could you add the screenshots of the updated docs in the PR description? LGTM otherwise.

Could you add the screenshots of the updated docs in the PR description? LGTM otherwise.
@maropu Have updated the html screenshots :)

Thanks@maropu @huaxingao ,have updated :)

Test build #129208 has started for PR 29883 at commit 0f76d27.

Test build #129208 has finished for PR 29883 at commit 0f76d27.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129208/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33823/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33823/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33823/
Test PASSed.

Thanks! Merged to master/3.0.