Correct output names

These edits allow all of the pytests to pass. I tweaked the constructed output filenames (for some reason I had all filenames prior to ramp-fitting ending in "_ramp.fits". I removed that. Hopefully I didn't put that there to deal with the pipeline's rules for stripping and replacing suffix pieces.)

Note that at the moment, our pipeline output files do not follow the default behavior for names.
For a file where dq_init, saturation, and superbias subtraction is done, the pipeline by default would create:
filename_superbias.fits
In calib_prep.py we instead save the file as:
filename_dq_init_saturation_superbias.fits
This is so that we can easily tell what pipeline steps have been run on a given file without opening it. It also gives us a way to differentiate between files that have been run up to the same point in the pipeline, but in one case certain steps were skipped. With the default pipeline naming convention, the filenames would be identical in that example.

I also added output_dir information to the pipeline calls.

@aliciacanipe, there's not much of a review needed here I don't think. Could you just give it a quick glance and make sure there's nothing obviously wrong?

I started to look at your code and then went down a rabbit hole of how the pipeline decides what the suffix is for output files that get saved. It seems like the strun method and the ipython methods attach a different default suffix? For instance, sometimes "dq_init" gets added and sometimes "dqinitstep" gets added. If you are specifying the suffix in the code though, I guess this isn't really an issue for mkrefs. Anyway, I'll review the code real quick.

I'm not sure if the suffixes to depend on calling method. They might. What bothers me is that if your file happens to end in one of the magic suffixes, the pipeline will strip that suffix off your file and replace it when running the next pipeline step.
That's why these days I like to use the suffix keyword, so that I can specify exactly what the output filename will be.

Ah yes. I forgot to update the test. I'll do that in a bit.

Looks all good!

Something very strange happened to this PR. @arminrest, Close is different than Merge. :) I reopened the PR, but there were missing commits. I updated, but now Travis is failing because the tests go more than 10 minutes with no response. One of them also fails because nbsphinx is not installed, which it was yesterday.
Others reported problems with jupyter notebooks on github this morning. I wonder if this is related.

lol, oh boy, looks like I messed things up. I was in a hurry to get
home, and I just wanted to get the latest version on my laptop... let me
know when you have fixed it....
On 11/1/18 9:12 PM, Bryan Hilbert wrote:

Something very strange happened to this PR. @arminrest
https://github.com/arminrest, |Close| is different than |Merge|. :)
I reopened the PR, but there were missing commits. I updated, but now
Travis is failing because the tests go more than 10 minutes with no
response. One of them also fails because |nbsphinx| is not installed,
which it was yesterday.
Others reported problems with jupyter notebooks on github this
morning. I wonder if this is related.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spacetelescope/jwst_reffiles/pull/25#issuecomment-435239168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWd302S6ua11prU5acdQrc8AlaJoMa0Qks5uq5wCgaJpZM4YE2no.

Ok, I added nbsphinx to the dependency list in the .travis.yml file, and all tests are now passing. Turns out the setup test had been failing all along when it couldn't find nbsphinx, but was reporting that it had passed for some reason.
Anyway, the tests are now all passing for real, and the code updates look to be behaving well, so I'm going to merge this.
@arminrest be sure to pull this version of the code before starting any tests.


Frontend code refactored after redux store implemented

New tasks created in the following sprint backlogs. Closed here.


Windows: font detection issue

Looks like fontist can't detect bold, italic, bold/italic system fonts.
OS: Windows7 64-bit.
In the folder C:\Windows\Fonts\ there are system fonts files:

arial.ttf
arialbd.ttf
arialbi.ttf
ariali.ttf

File arial.install.yml:
Arial:
  - Regular
  - Bold
  - Italic
  - Bold Italic

Command: fontist manifest-install --confirm-license arial.install.yml
Output:
Downloading font "arial_black" from https://gitlab.com/fontmirror/archive/-/raw/master/arialb32.exe
Downloads: 0MB/0MB (100.00%) (cache)
Installing font "arial_black".
Fonts installed at:
- C:/Users/User/.fontist/fonts/AriBlk.TTF
Downloading font "arial_black" from https://gitlab.com/fontmirror/archive/-/raw/master/arialb32.exe
Downloads: 0MB/0MB (100.00%) (cache)
Installing font "arial_black".
Fonts installed at:
- C:/Users/User/.fontist/fonts/AriBlk.TTF
Downloading font "arial_black" from https://gitlab.com/fontmirror/archive/-/raw/master/arialb32.exe
Downloads: 0MB/0MB (100.00%) (cache)
Installing font "arial_black".
Fonts installed at:
- C:/Users/User/.fontist/fonts/AriBlk.TTF
---
Arial:
  Regular:
  - C:/Windows/Fonts/arial.ttf
  - C:/Windows/Fonts/arialbd.ttf
  - C:/Windows/Fonts/arialbi.ttf
  - C:/Windows/Fonts/ariali.ttf
  - C:/Windows/Fonts/ARIALN.TTF
  - C:/Windows/Fonts/ARIALNB.TTF
  - C:/Windows/Fonts/ARIALNBI.TTF
  - C:/Windows/Fonts/ARIALNI.TTF
  Bold: []
  Italic: []
  Bold Italic: []

Questions:

Why Arial Black font installed?
arialbd.ttf - is bold, but placed in Regular array, arialbi.ttf - is italic, but placed in Regular array, etc.

Why Arial Black font installed?

This is a case of wrong matching, a Fontist bug.

arialbd.ttf - is bold, but placed in Regular array, arialbi.ttf - is italic, but placed in Regular array, etc.

Fontist bug.
Ping @alexeymorozov

Seems it's time to deal with matching in system directories. I will need some time to research why exactly this happens.

The font name mismatch issue moved to #177.

To keep in mind: we have usage of an undocumented feature in metanorma-cc. It requests fonts without any style. May be just need to document it and cover with specs.
https://github.com/metanorma/metanorma-cc/blob/v1.6.1/lib/metanorma/cc/fonts_manifest.yaml

@ronaldtse Do we need to support search by filename?
Fontist::Font.find("DejaVuSerif.ttf")

instead of
Fontist::Font.find("DejaVu Serif")

@alexeymorozov yes that would be a good feature, but instead of "find" maybe "find_by_filename"?

Released detection fix in v1.7.1 🚀
Will continue work in #177


[Provider-Maven] Build now fails if there is no pact to verify

I've recently upgraded pact to 3.5.18 (for features I needed) and noticed that now the build fails if there is no pact to verify.
"No pact files were found for provider XXXX"
I find this problematic as provider may not know when new contracts will be published by consumer to be verified, so having the provider pact-verify always active, regardless if there is contract to verify at this stage, is preferable (than commenting the verify until contracts are published). I don't really believe it should be a build failure condition.
What is the reasoning behind this? is it possible to change this back to previous behavior ?
Thanks ! :)

Are you running the verification tests with Gradle, Maven or JUnit?

Using Maven plugin.

That was by accident, not design. The reason that the default behaviour is to fail when there are no pacts to verify is to avoid any false positives. If the project is mis-configured (say the provider name is misspelt or the pact directory name is incorrect) and no pacts are found, then if the build passes everyone could assume that the provider has been verified, when it has not.
But I will add an option to explicitly turn off this behaviour.

3.5.19 has been released with this fix

Thanks !


Fix: style is not updated correctly when using camelCase in style attr

refs: #1374

Coverage remained the same at 100.0% when pulling ae0ddf1131c9a55b2494e3c7fb9dbcec1e552a16 on mochiya98:m98-fix-1374 into 4f671e7fb99425f84434c0c8b56d830ade4ea792 on developit:master.

thank you for your help! 👍


Handling of cerebellum in some new parcellations

Some of the new parcellations in dev do not include cerebellar parcellation. Some also require a greater radial search distance due to incomplete GM coverage. Combining these two would mean that streamlines terminating in the cerebellum may be erroneously assigned to the most proximal cortical parcel.
This could be fixed by explicitly adding the cerebellar hemispheres into the parcellation, generating the connectome, then erasing the corresponding rows / columns from the matrix.

Required for:

brainnetome246fs
brainnetome246mni
perry512
yeo17mni
yeo7mni


*: hotfix panic from tokio-timer

Signed-off-by: you06<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #11940
What's Changed:

*: hotfix panic from tokio-timer by enlarging the length of the level vector

tokio-timer 0.2.13's time wheel works when the elapsed time since the process starting is less than 2^36 ms(about 795 days), otherwise, it may panic. This PR switch tokio-timer to a patch version which enlarges the length of the level vector. In this patch, it supports the elapsed time less than 2^42 ms(about 139 years), which should be long enough.
The changes can be found here: https://github.com/you06/tokio-timer-0.2.13/compare/0c5fb54...35090cc
Related changes

Need to cherry-pick to the release branch

release-4.0
release-5.0
release-5.1
release-5.2
release-5.3
release-5.4

Check List
Tests

Manual test (add detailed scripts or steps below)

The test steps are in #11940 which is based on chaos mesh. I did the following test for this PR.
sudo ./watchmaker -pid {pid_of_tikv} -sec_delta 68719436 -clk_ids=CLOCK_MONOTONIC # simulate time drift +795 days, tikv works fine
sudo ./watchmaker -pid {pid_of_tikv} -sec_delta<PHONE_NUMBER> -clk_ids=CLOCK_MONOTONIC # simulate time drift +138 years, tikv works fine
sudo ./watchmaker -pid {pid_of_tikv} -sec_delta<PHONE_NUMBER> -clk_ids=CLOCK_MONOTONIC # simulate time drift +139 years, tikv panics

Side effects
Release note
Fixes the bug that TiKV keep running over 2 years may panic.

/run-all-tests

/run-all-tests

/merge


Cut version 3.0 release

Significant outstanding changes including major GUI changes, GRBL support, jog support, and config file changes. Think it justifies a major revision in total
MVP for release:

LIP-A1 support (https://github.com/Labsmore/pyuscope/issues/38)
GRBL working as integrated solution, even if unstable (https://github.com/Labsmore/pyuscope/issues/33)
Related, jogging in GUI to support GRBL (https://github.com/Labsmore/pyuscope/issues/5)
Ideally pr0nscope continues to run on existing LinuxCNC flow (might be broken / needs testing). Although could freeze that software if needed for now and fix in 3.1 release
Decide if changing config format more drastically (https://github.com/Labsmore/pyuscope/issues/36)

We are at MVP to cut release as of 1a2a9e8. Probably work off of main for now though to let things stabilize until we have a reason to cut release

Done. I'm sure there will be fixes but it seems somewhat stable and I'd like to establish a baseline


[R]Command 'mingw32-make.exe' not found @win/processx.c:994

Summary:
Please provide a short couple sentence summary.
Description:
Describe the issue as clearly as possible.
Reproducible Steps:
Please report steps to reproduce the issue. If it's not possible to reproduce, please include a description of how you discovered the issue.
If you have a reproducible example, please include it.
Current Output:
The current output. Knowing what is the current behavior is useful.
Expected Output:
Describe what you expect the output to be. Knowing the correct behavior is also very useful.
Additional Information:
Provide any additional information here.
Current Version:
v2.25.0

I see you are using cmdstan via cmdstanr. Install the latest version with remotes::install_github("stan-dev/cmdstanr") and run check_cmdstan_toolchain()


Problem (with bison) building clingo on Apple (M1) silicon

Thanks for Potassco and clingo, the whole project is very impressive (and stable!) and I'm enjoying it on Linux.
However, I have troubles setting up cmake correctly for building clingo on an Apple Air with Apple M1 chip running Big Sur. Main problem seems to be to point it to the right version of bison.
I have installed needed libs/requirements using Homebrew 2.7.7 and in the recommended dir/path for Apple M1. Homebrew has partial support for Apple M1 since version 2.6.0 but all requirements that clingo needs are indicated as already supported/checked/fixed and I have added the bison bin and lib flags as recommended:
% brew --version
Homebrew 2.7.7
% which brew
/opt/homebrew/bin/brew
% bison --version
bison (GNU Bison) 3.7.5
...
% which bison
/opt/homebrew/opt/bison/bin/bison
% grep bison ~/.bashrc
export PATH="/opt/homebrew/opt/bison/bin:$PATH";
export LDFLAGS="-L/opt/homebrew/opt/bison/lib";

However, cmake for clingo still finds the default Apple bison version (which is too old for clingo) and bails out:
cmake -H. -B/Users/feldt/lib/clingo -DCMAKE_BUILD_TYPE=Release
-- Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR)
-- Could NOT find BISON: Found unsuitable version "2.3", but required is at least "2.5" (found /usr/bin/bison)
-- Potassco is not installed - using local copy
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
CMake Error at cmake/clingo_functions.cmake:21 (message):
  bison parser generator required but not found
Call Stack (most recent call first):
  libgringo/CMakeLists.txt:70 (bison_target_or_gen)

Any advice?

If I remember correctly, setting the bison path via cmake option -DCMAKE_EXECUTABLE=/opt/homebrew/opt/bison/bin/bison should do the trick. If you build a release, then you also don't need bison because the generated parsers are bundled.
https://cmake.org/cmake/help/latest/module/FindBISON.html

Thanks, that does seem to handle bison. I still have problems with building on the M1 Mac so if someone has pointers what they had to do please share:
% cmake -H. -B/Users/feldt/lib/clingo -DCMAKE_BUILD_TYPE=Release
-- Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR)
-- Potassco is not installed - using local copy
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/feldt/lib/clingo

% cmake --build /Users/feldt/lib/clingo
[  1%] Building CXX object clasp/libpotassco/src/CMakeFiles/libpotassco.dir/application.cpp.o
In file included from /Users/feldt/tmp/clingo/clingo/clasp/libpotassco/src/application.cpp:26:
In file included from /Users/feldt/tmp/clingo/clingo/clasp/libpotassco/potassco/application.h:26:
In file included from /Users/feldt/tmp/clingo/clingo/clasp/libpotassco/potassco/program_opts/program_options.h:28:
In file included from /Users/feldt/tmp/clingo/clingo/clasp/libpotassco/potassco/program_opts/value.h:32:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:504:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string_view:175:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/__string:57:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:641:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/cstring:60:
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string.h:60:15: fatal error: 'string.h' file not found
#include_next <string.h>
              ^~~~~~~~~~
1 error generated.
make[2]: *** [clasp/libpotassco/src/CMakeFiles/libpotassco.dir/application.cpp.o] Error 1
make[1]: *** [clasp/libpotassco/src/CMakeFiles/libpotassco.dir/all] Error 2
make: *** [all] Error 2

It seems I just had to clear the cmake caches to get past the problems above. Will report back if everything builds ok.

It now builds ok but seems not to link correctly to Python:
% bin/clingo --version
dyld: Library not loaded: @rpath/Python3.framework/Versions/3.8/Python3
  Referenced from: /Users/feldt/lib/clingo/bin/clingo
  Reason: image not found

I will investigate more and report in this thread in the hope that it can help others. Comments/advice welcome.

It now builds ok but seems not to link correctly to Python:
% bin/clingo --version
dyld: Library not loaded: @rpath/Python3.framework/Versions/3.8/Python3
  Referenced from: /Users/feldt/lib/clingo/bin/clingo
  Reason: image not found

I will investigate more and report in this thread in the hope that it can help others. Comments/advice welcome.

I think you are almost there. This can probably be resolved by setting the rpath properly. Unfortunately, I cannot help you with this because I do not have access to an ARM Mac. On Intel Macs it seems to build just fine.

I might actually be able to help if you send the output of
cmake --build build/release --verbose

Just make sure to run
cmake --build build/release --target clean

before.

I did run otool on the clingo binary and can see that the Python path seems ok further down the list, i.e.:
% otool -l bin/clingo
bin/clingo:
...
Load command 14
          cmd LC_LOAD_DYLIB
      cmdsize 72
         name @rpath/Python3.framework/Versions/3.8/Python3 (offset 24)
   time stamp 2 Thu Jan  1 01:00:02 1970
      current version 3.8.0
compatibility version 3.8.0
...
Load command 18
          cmd LC_RPATH
      cmdsize 112
         path /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib (offset 12)
...
```

The latter part is a valid one so maybe I need to point also the path in the "Load command 14" part to a similar, absolute path?

Yes, this did the trick:
install_name_tool -change @rpath/Python3.framework/Versions/3.8/Python3 /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/libpython3.8.dylib bin/clingo
% bin/clingo --version
clingo version 5.5.0
Address model: 64-bit

libclingo version 5.5.0
Configuration: with Python 3.8.2, without Lua

libclasp version 3.3.5 (libpotassco version 1.1.0)
Configuration: WITH_THREADS=1
Copyright (C) Benjamin Kaufmann

License: The MIT License <https://opensource.org/licenses/MIT>

To get a sense of the speed of clingo on Apple M1 MacBook Air with 16GB here are some runs on the solitaire example in clingo/examples/clingo/solitaire with different num threads:
% time clingo solitaire.lp instance.lp
Time         : 5.750s (Solving: 5.69s 1st Model: 0.79s Unsat: 4.91s)

% time clingo solitaire.lp instance.lp -t 2
Time         : 3.975s (Solving: 3.91s 1st Model: 0.21s Unsat: 3.70s)

% time clingo solitaire.lp instance.lp -t 4
Time         : 1.912s (Solving: 1.85s 1st Model: 0.13s Unsat: 1.72s)

% time clingo solitaire.lp instance.lp -t 6
Time         : 2.004s (Solving: 1.94s 1st Model: 0.49s Unsat: 1.45s)

% time clingo solitaire.lp instance.lp -t 8
Time         : 2.081s (Solving: 2.02s 1st Model: 0.37s Unsat: 1.65s)

Hi @robertfeldt, the numbers are  are only partly comparable since each thread runs - by default - a different configuration of clasp.
Hence the more threads the more "oracles" at your disposal. It could be that the best "oracle" is already among the first four configs.
FWIW, you can configure this, first, the solver setups, and also use search space splitting - enjoy! :smile:

Thanks for the tip @tortinator so something like:
% time clingo solitaire.lp instance.lp -t 2,split
Time         : 3.091s (Solving: 3.05s 1st Model: 0.37s Unsat: 2.68s)

% time clingo solitaire.lp instance.lp -t 4,split
Time         : 1.823s (Solving: 1.76s 1st Model: 0.28s Unsat: 1.48s)

time clingo solitaire.lp instance.lp -t 8,split
Time         : 1.223s (Solving: 1.15s 1st Model: 0.06s Unsat: 1.10s)

is more comparable then?

I also head a look at the compiler output you send me. It looks right to me because it is linking against the Python library and sets the proper RPATH. Maybe linking the Python frameworks version requires different options.
From the otool output, it looks like the RPATH should be set to /Applications/Xcode.app/Contents/Developer/Library/Frameworks instead of /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib. At some point the magic @rpath gets inserted. I do not have enough knowledge about linking on MacOS to know where this is from, though. Since I am using cmake's FindPython module, this issue might fix itself at some point with a newer cmake version.
If you use the Homebrew Python maybe it would work out of the box. If you want to give this a shot, you could try to use this version. Passing -DPython_EXECUTABLE=<path-to-homebrew-python-executable> should do the trick; just delete the old build or cache before.
 Another could be to fix the configuration of the solver; this could work by entering a singe one through a config portfolio file, but there may be a direct option that I had to look up myself, check out --help=3

Thanks to you both.
Yes @rkaminsk that did the trick, I installed python3 via Homebrew and then did a fresh:
cmake -H. -B/Users/feldt/lib/clingo -DCMAKE_BUILD_TYPE=Release -DBISON_EXECUTABLE=/opt/homebrew/opt/bison/bin/bison -DPython_EXECUTABLE=/opt/homebrew/bin/python3
cmake --build /Users/feldt/lib/clingo
% /Users/feldt/lib/clingo/bin/clingo --version
clingo version 5.5.0
Address model: 64-bit

libclingo version 5.5.0
Configuration: with Python 3.9.1, without Lua

libclasp version 3.3.5 (libpotassco version 1.1.0)
Configuration: WITH_THREADS=1
Copyright (C) Benjamin Kaufmann

License: The MIT License <https://opensource.org/licenses/MIT>

Ok, I'm closing this now. All good. :)

Thanks to you both.
Yes @rkaminsk that did the trick, I installed python3 via Homebrew and then did a fresh:
cmake -H. -B/Users/feldt/lib/clingo -DCMAKE_BUILD_TYPE=Release -DBISON_EXECUTABLE=/opt/homebrew/opt/bison/bin/bison -DPython_EXECUTABLE=/opt/homebrew/bin/python3
cmake --build /Users/feldt/lib/clingo
% /Users/feldt/lib/clingo/bin/clingo --version
clingo version 5.5.0
Address model: 64-bit

libclingo version 5.5.0
Configuration: with Python 3.9.1, without Lua

libclasp version 3.3.5 (libpotassco version 1.1.0)
Configuration: WITH_THREADS=1
Copyright (C) Benjamin Kaufmann

License: The MIT License <https://opensource.org/licenses/MIT>

Ok, I'm closing this now. All good. :)

If you are using Homebrew anyway, then you can as well take this route. There is also a clingo formula on homebrew.

Thanks, yes, installing via the clingo formula also works but it is good to be able to build from source and get latest version. But I can confirm the clingo install via Homebrew formula works also on Apple M1. Currently at 5.4.0 with Python 3.9.1 and Lua 5.4.2.

Thanks, yes, installing via the clingo formula also works but it is good to be able to build from source and get latest version. But I can confirm the clingo install via Homebrew formula works also on Apple M1. Currently at 5.4.0 with Python 3.9.1 and Lua 5.4.2.

To install the latest master version with brew, you can use brew install clingo --HEAD. (Make sure to brew unlink clingo before).

Ok, fantastic. Big thanks.


Include details for preventing add-in from disappearing in ReadMe

Evaluate options described in link below to determine if the disappearing add-in problem can be resolved. If one or more, include appropriate instructions in ReadMe.
https://professor-excel.com/prevent-excel-add-in-disappear/

Items 2 and 3 in link appear to be relevant fixes and should be described.

Addressed with commit a230e0c.


WebSocket Compression

Which versions of this library support the recently announced change to enable websocket compression ?
Will my app continue to function if I am using this library? If I am using an old version of this library?
What protocols does this library support?

Hello, I have the same question. Is v8.0.0 still supported?

this library supports the correct protocols. We have now completed the deprecation activity.


fix 2d stop_on_slope  (issue #21595)

Bugsquad edit: Fixes #21595

Rebased and squashed myself as 8d84da0.

Amended to remove unused variable.


az aks create needed --node-vm-size   for westus region

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/deploy-microservice-tutorial/azure-resources
Operating System: windows
Below command worked after recieved default value is not supported for westus region.
az aks create --resource-group myMicroserviceResources --name myMicroserviceCluster --node-count 1 --enable-addons http_application_routing --node-vm-size Standard_D2s_v3 --generate-ssh-keys

Duplicate of #4111


HSEARCH-2152 Bulk requests per list of Lucene works

Cuts the build time for the elasticsearch module by one third on my machine :)

very nice! merged


enable optional dependencies to stay optional

Objective

Optional dependencies were enabled by some features as a side effect. for example, enabling the webgl feature enables the bevy_pbr optional dependency

Solution

Use the syntax introduced in rust 1.60 to specify weak dependency features: https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html#new-syntax-for-cargo-features

Weak dependency features tackle the second issue where the "optional-dependency/feature-name" syntax would always enable optional-dependency. However, often you want to enable the feature on the optional dependency only if some other feature has enabled the optional dependency. Starting in 1.60, you can add a ? as in "package-name?/feature-name" which will only enable the given feature if something else has enabled the optional dependency.

not that I know of... that PR was on my backlog since rust 1.60 was out, it always bothered me that bevy_pbr was compiled for a 2d game in wasm

bors r+


Added duplicate code pre-commit-config patch

@evaherrada Why are we blanket disabling duplicate code on the library code check?

@kattni I'm not entirely sure. It was disabled in this commit https://github.com/adafruit/cookiecutter-adafruit-circuitpython/commit/9eec9be1b3b262b508c345b895ae7c41e80d5c4c
@tekktrik You probably know more about this decision than I do

Hmm. I'm not sure I intended for that to happen. @tekktrik Do you recall the discussion around that decision? I'm not remembering it.

I don't think we talked specifically about it, it probably was in one and got patched to all of them.  We could honestly remove it and see what pops out, too, most likely don't have duplicate code (probably 😄)

@kattni is everything else ok with the patch? As in should I just remove the bit about duplicate-code and then run it after it gets merged?

FWIW I think when we initially discussed this last year or earlier we decided not to disable duplicate-code, I haven't been able to find the discussion.

Oh wait lol that's the only change in this patch. Closing this


Job notification subscription feature

User should be able to specify filter parameters

keywords
location
salary

Notify daily?

Notification medium

web push
email
app push (our own standalone app or something like pushover?)

[ ] Create database schema

[ ] Create system architecture

[ ] Create sequence diagram

[ ] Implement

Database

notif_subscription

id
user_id
medium (1=email, 2=webpush)
filters (json) - can include salary ranges, location, etc in the future

keywords
provider

frequency (1=daily, 2=weekly, 3=monthly) - use daily only to start with?

notif_queue

id
notif_subscription_id
job_id
medium
status (0=new, 1=sent)

notif_log

id
user_id
sent_time
status (1=success, 2=failed)
notes

General flow

User sets filters and subscribes to new job notifications
New batch program checks db for newly added jobs and add to notif_queue if job matches filters
Another batch that runs daily checks subscriptions and log for jobs that are due to run. Gets the list of jobs to notify about and include in notification.

User should be able to view the notif_queue in the web app so that they can see the list of jobs that they were notified for?

sequenceDiagram
    Participant User
    Participant Jobbuzz
    Participant FCM

    User->>Jobbuzz: Subscribe to push/email notification
    Jobbuzz-->>User: OK
    loop Every hour
    Jobbuzz->>DB: Check for new jobs since last processed
    DB -->> Jobbuzz: Found new matching user's filters
    Jobbuzz->>SMTP: Send emails if subscribed
    SMTP-->>Jobbuzz: OK
    Jobbuzz->>FCM: Send webpush if subscribed
    FCM-->>Jobbuzz: OK
    Jobbuzz-->>DB: Log results
    DB-->>Jobbuzz: OK
    end


Backward- and forward-compatibility

Hello,
I would like to inquire about the possibility to increase backward- and forward-compatibility in pandoc-types. For example, in pandoc-types 1.21, changes to the AST has broken the way a few filters work. The new Table block element is not crucial for many filters (e.g. pandoc-plot or pandoc-include-code), so the breakage is artificial.
I propose that the next time the AST is changed, a new block element, Unknown, be added. Then, the function toJSONFilter could be changed so that instead of throwing an error on incompatible pandoc-types version, the Unknown block element could be used as a placeholder for AST blocks that are not decoded appropriately.
This would allow for filters to be compatible with a wider range of pandoc-types and pandoc versions.
Let me know what you think.

Interesting idea. I don't really know what I think.  Probably this should be raised for discussion on pandoc-discuss.

This topic is visible here.

Orthogonal to the solution proposed here, but aiming to solve the same problem: ast-migrator.


Fix timeout logic to be back how it was before native editor fix

Timeout logic wasn't working for idle session. Go back to old way of checking in a loop

All the failures here are the debugger failures on linux/mac

Codecov Report

Merging #7295 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7295      +/-   ##
==========================================
+ Coverage      58%   58.29%   +0.29%
==========================================
  Files         493      493
  Lines       21661    21661
  Branches     3481     3486       +5
==========================================
+ Hits        12564    12628      +64
+ Misses       8314     8255      -59
+ Partials      783      778       -5

Impacted Files
Coverage Δ

src/client/common/logger.ts
68.55% <0%> (-4.41%)
:arrow_down:

src/client/language/characters.ts
33.33% <0%> (+2.56%)
:arrow_up:

src/client/common/utils/version.ts
81.48% <0%> (+3.7%)
:arrow_up:

src/client/providers/providerUtilities.ts
88.88% <0%> (+5.55%)
:arrow_up:

src/client/datascience/cellFactory.ts
89.65% <0%> (+13.79%)
:arrow_up:

src/client/common/utils/icons.ts
100% <0%> (+16.66%)
:arrow_up:

src/client/formatters/serviceRegistry.ts
100% <0%> (+25%)
:arrow_up:

src/client/api.ts
87.5% <0%> (+25%)
:arrow_up:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
100% <0%> (+33.33%)
:arrow_up:

src/client/testing/codeLenses/main.ts
77.77% <0%> (+33.33%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02617a5...8e5e349. Read the comment docs.


feat: extensions support and add path parameters to operation params

Extensions support in all supported objects
Add global path parameters to operation

@manchenkoff

Hey @khizunov, thanks a lot for the contribution! 🔥 Left one code-related minor comment, but there are some build issues. Could you also add some unit tests as well? At least to check more complicated logic like passing extensions to each oauth flow and path parameters inheritance.

Hey @manchenkoff sure not problem at all, will do 👍

Closes #42

@manchenkoff good catch on Oauth flows 💯
Fixed the build, working on tests

@manchenkoff added test cases for extensions
for the path parameters inheritance the cases are already there in path builder test and runner test.
LMK if you want me to add some other cases

I will publish new version later today, thanks @khizunov!

published as v1.1.17


hb_rf_eth module missing

Describe the issue you are experiencing
hb_rf_eth not working after update to RaspberryMatic <IP_ADDRESS>11218.
Seems that driver module is missing, since also directories like /sys/module/hb_rf_eth/parameters/connect are not available.
Describe the behavior you expected
Connection to hb_rf_eth should work like before.
Steps to reproduce the issue

Update to newest version
try to connect hb_rf_eth

What is the version this bug report is based on?
<IP_ADDRESS>11218
Which base platform are you running?
oci (Open Container Infrastructure)
Which HomeMatic/homematicIP radio module are you using?
n/a
Anything in the logs that might be useful for us?
modprobe: can't load module hb_rf_eth (updates/dkms/hb_rf_eth.ko): Invalid argument
/etc/init.d/S47InitRFHardware: line 58: can't create /sys/module/hb_rf_eth/parameters/connect: nonexistent directory

Additional information
No response

As you are using a docker/oci environment: the kernel drivers for the hb_rf_eth and others are not included in RaspberryMatic itself, but are part of the pivccu  dkms kernel packages you have to install separately (or which deploy.sh will install upon execution). So please make sure to have all necessary dependencies installed on your hist system and check the documentation here: https://github.com/jens-maus/RaspberryMatic/wiki/Installation-Docker-OCI

Well, I was using it successfully since a few month, until I have updated to the new release this morning.
pivccu-modules-dkms is installed in version 1.0.68.
Have you been able to test it successfully before releasing the new version?

Figured out that my system also has updated pivccu-modules-dkms. The connection works again, after reverting back to 1.0.64.


Update default deploy-config for ConfigMap in Job

So that ConfigMaps can be used in batch/v1/Job

@aashah Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@aashah Thank you for signing the Contributor License Agreement!

i think we should add Job to builtinAppsControllers (though builtinAppsControllers alias should probably be renamed to something else).

I can see that, I wasn't comfortable validating the change to add it to that collection since it was used in a lot more places. For the CAPI team, this is slightly blocking a story #171394866 to extract database migrations from an initContainer -> Job.


feat: added alliance module into app, implement ictest for the flow

1. Overview
Implemented x/alliance intergration according to https://docs.alliance.money/guides/get-started
Note: this uses our fork with compat changes
2. Implementation details
Alliance module is on v3.4.x branch as it is compatible with Cosmos SDK 0.47.x. Branch on v4.x.x expects Cosmos SDK >= 0.50.
3. How to test/use
make local-image && make ictest-alliance
Test scenario TestAllianceBasic description:

create 2 chains - using persistenceCore and gaiad, 1 validator each
patch genesis so governance is fast, also alliance module doens't have a 7-day delay on rewards
setup IBC connection, channel between persistence and gaia, relayer
create user account on both chains
IBC-transfer 1000 ATOM from gaia to persistence
obtain IBC denom for ATOM on persistence
check all delegated tokes sum on persistence<PHONE_NUMBER>000uxprt)
create an alliance on persistence using a governance proposal, denom is IBC denom of ATOM
weight is 1:1 ATOM - XPRT in that proposal
delegate alliance-enabled tokens to a validator on persistence (1000 IBC ATOM)
check that no IBC uatom left in user's wallet
check all delegated tokes sum on persistence including minted by alliance<PHONE_NUMBER>0000uxprt)
wait 5 blocks & query the rewards
claim all rewards from a delegation
check that uxprt balance on persistence chain increased after rewards claim

🥹


Update linux install instructions

Thanks for catching this and taking the time to submit this patch. Just added you to the acknowledgements section.


Triton wenet_client error

Hi, My name is Nathan.
I tried to check performance based on triton server.
In my case, I works at closed network env.
So avoiding this issue, I Built server(and client) docker at open network env and move images to closed env.
Finally I started server on one gpu.
[asr@k-atc12 ~]$ docker ps
CONTAINER ID   IMAGE                 COMMAND                  CREATED        STATUS          PORTS                                                           NAMES
ae14c456f950   wenet_server:latest   "/opt/nvidia/nvidia_…"   15 hours ago   Up 15 hours     <IP_ADDRESS>:8000-8002->8000-8002/tcp, :::8000-8002->8000-8002/tcp   tender_murdock
[asr@k-atc12 ~]$ nvidia-smi
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A    259800      C   tritonserver                     1389MiB |
+-----------------------------------------------------------------------------+
After checking triton-server works properly, I  started client and tried to run as follows
$ python3 client.py --audio_file=/ws/test_data/41_0511_760_0_09479_01.wav --model_name=streaming_wenet --streaming
root@k-atc12:/ws/client# file /ws/test_data/41_0511_760_0_09479_01.wav
/ws/test_data/41_0511_760_0_09479_01.wav: RIFF (little-endian) data, WAVE audio, Microsoft PCM, 16 bit, mono 8000 Hz
But I got errors as follows
root@k-atc12:/ws/client# python3 client.py --audio_file=/ws/test_data/41_0511_760_0_09479_01.wav --url=localhost:8001 --model_name=streaming_wenet --streaming
Exception in thread Thread-3:
Traceback (most recent call last):
File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
self.run()
File "/usr/lib/python3.8/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib/python3.8/multiprocessing/pool.py", line 576, in _handle_results
task = get()
File "/usr/lib/python3.8/multiprocessing/connection.py", line 251, in recv
return _ForkingPickler.loads(buf.getbuffer())
TypeError: init() missing 1 required positional argument: 'msg'
Please check this issue.
Thank you

@yuekaizhang please follow the PR.

Did you set the sampling rate here https://github.com/wenet-e2e/wenet/blob/main/runtime/gpu/model_repo_stateful/feature_extractor/config_template.pbtxt#L30? Looks like you are using 8k audios for test. Also, could you try test it with perf_analyzer (see https://github.com/wenet-e2e/wenet/tree/main/runtime/gpu perf test part)?

Oh i see. I made mistake that i didn't change sampling rate information on 'train.yaml' even though i trained 8k model.
Thank you so much for your help.
It works fine. Thank you!


Merge JS's changes in

Corrected forcing term (d3q15.c)
Fixed inconsistecy between forces and force densities (d3q15.c)
Included forcing in initialization (Lattice.i)
Fixed indexing error in PBCs (bc_pbc.c)

Hi Rupe,
Is this something I need to act on? I can't find any button for
accepting the pull request... Or is it just for information?
Cheers,
Joakim
On 2016-11-15 15:30, Rupert Nash wrote:

Corrected forcing term (d3q15.c)
Fixed inconsistecy between forces and force densities (d3q15.c)
Included forcing in initialization (Lattice.i)
Fixed indexing error in PBCs (bc_pbc.c)

    You can view, comment on, or merge this pull request online at:

https://github.com/rupertnash/subgrid/pull/3
    Commit Summary

Fixed some bugs:
File Changes

M libd3q15/Makefile
https://github.com/rupertnash/subgrid/pull/3/files#diff-0 (4)

M libd3q15/bc_pbc.c
https://github.com/rupertnash/subgrid/pull/3/files#diff-1 (2)

M libd3q15/d3q15.c
https://github.com/rupertnash/subgrid/pull/3/files#diff-2 (55)

M python/d3q15/Lattice.i
https://github.com/rupertnash/subgrid/pull/3/files#diff-3 (6)

M python/dqTools/Controller.py
https://github.com/rupertnash/subgrid/pull/3/files#diff-4 (1)
Patch Links:

https://github.com/rupertnash/subgrid/pull/3.patch

https://github.com/rupertnash/subgrid/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rupertnash/subgrid/pull/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjjniHXSQqOokR6CxaygLlGWO_yeiAYks5q-cIZgaJpZM4KyluG.

This is really just for a logical place to discuss this.
I've done a preliminary test and if you set up your lattice with rho = 1, u = 0 and a non-zero force, then call initFromHydroVars() and updateHydroVars() you do not get zero velocity where the force != 0. I'm going to look at this more

But neither should we - right? Is there not a correction term of
f/(2*\Delta t) that should be added to the velocity where f != 0? The
problem in my test was that this correction seems to end up in the wrong
lattice point... /Joakim
On 2016-11-15 16:30, Rupert Nash wrote:

This is really just for a logical place to discuss this.
I've done a preliminary test and if you set up your lattice with rho =
1, u = 0 and a non-zero force, then call initFromHydroVars() and
updateHydroVars() you do not get zero velocity where the force != 0.
I'm going to look at this more
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rupertnash/subgrid/pull/3#issuecomment-260672775,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjjnnVh8DS5x8066JoEJbcX6Xct0yS0ks5q-dAvgaJpZM4KyluG.

If you have rho and u, compute the equilibrium f, then compute rho and u from that, you MUST get back the same inputs up to machine precision.

I am reasonably confident that my calc_hydro_site is correct (given that the "force" array stores a force density)

In that case, yes, but in that case all the other routines should be
changed accordingly (phi and f_0). The latter two are currently
identical to your PRE equations, where F is treated as a force rather
than a force density (although you say differently in the introduction)

do you agree?

On 2016-11-15 17:20, Rupert Nash wrote:

I am reasonably confident that my calc_hydro_site is correct (given
that the "force" array stores a force density)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rupertnash/subgrid/pull/3#issuecomment-260688029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjjnkD-XozNYaYUH-h3b6DairayZNmnks5q-dvAgaJpZM4KyluG.

Did you find any further leads? /J
On 15/11/16 17:20, Rupert Nash wrote:

I am reasonably confident that my calc_hydro_site is correct (given
that the "force" array stores a force density)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rupertnash/subgrid/pull/3#issuecomment-260688029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjjnkD-XozNYaYUH-h3b6DairayZNmnks5q-dvAgaJpZM4KyluG.


Unable to retrieve Primary Group from Active Directory

Laravel Version: 5.7.28
Adldap2-Laravel Version: 10.0.3
PHP Version: 7.2.11
LDAP Type: ActiveDirectory

Description:
I want to get Primary Group for the users using the script below:-
$groups = $users->getPrimaryGroup();
but unfortunately it return nothing. I try to find the root cause by looking at getPrimaryGroup() method in User.php. When I put this script print_r($this->getConvertedSid()); , the SID is different from the SID in Active Directory.
The SID display on the screen is "S-1-5-21-26790432-3878837506-1146548017-1344" but the actual SID in Active Directory is "S-1-5-21-26790432-3878837506-1146548017-2503".
Anyone can help on this issue?

Hi @rizalkadis,
Can you post your whole script? Will help to debug easier.

Hi @rizalkadis,
Can you post your whole script? Will help to debug easier.

Hi @stevebauman
Sorry, my mistake because I echo wrong variable. The framework can retrieve the SID correctly which is "S-1-5-21-26790432-3878837506-1146548017-2503". However, when I try to retrieve the primary group from UserController.php, no groups were display on the screen. Below is the code:
user = $userRepository;
		$this->role = $roleRepository;
		$this->ldap = $ldap;
    }
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if ($request->wantsJson()) {
            return $this->user->jsGrid($request);
        }

		$users = $this->ldap->search()->users()->findBy('samaccountname', 'farhana');

		if ($users) {
			$groups = $users->getPrimaryGroup();
		}

        return view('users.index', compact('users','groups'));
    }
}

Just to add more information, I edit vendor\adldap2\adldap2\src\Models\User.php as give below:
public function getPrimaryGroup()
  {

       $groupSid = preg_replace('/\d+$/', $this->getPrimaryGroupId(), $this->getConvertedSid());
   echo "SID : ".$groupSid;
   echo "<br>";
   echo "Result : ";
   var_dump($this->query->newInstance()->findBySid($groupSid));

   exit();
       return $this->query->newInstance()->findBySid($groupSid);
   }

The ouput if given below:
SID : S-1-5-21-26790432-3878837506-1146548017-2503
Result : bool(false)
Seem like it can't retrieve the primary group by the SID given.

Hmmm strange... What is your base_dn set to in your configuration?

It's possible that your primary group isn't being located if you set your base_dn to something higher than the actual base DN of your directory.
Usually the default primary group resides in CN=Users,DC=corp,DC=acme,DC=org, so if you set your base_dn to OU=Users,DC=corp,DC=acme,DC=org, then a primary group won't be located due to it being located outside the scope the base DN you have given.
Let me know and we can continue debugging :smile:

Hi @stevebauman ,
My ldap configuration is
'base_dn' => env('LDAP_BASE_DN', 'ou=user directory,dc=corp,dc=acme,dc=org'),
So I took your advice and change it to
'base_dn' => env('LDAP_BASE_DN', 'dc=corp,dc=acme,dc=org'),
Now, it works like a charm. I can see the group
CN=server,OU=group directory,dc=corp,dc=acme,dc=org
Thank you so much!

Awesome @rizalkadis! Glad you were able to resolve it. No problem at all :smile:


[LANG-1543] Implemented feature of writing Maps into JSON

Implemented the feature of navigating through Maps to write in JSON format.
Looking forward to your feedback.
The issue is described at https://issues.apache.org/jira/browse/LANG-1543

Coverage increased (+0.0007%) to 94.679% when pulling a60bd7a9686c2bbc37d249d9faaa5b9c41f03efa on rwanderc:LANG-1543 into 062bc6fe7d48d4eb4cdf3abec09e7547a0a9aed7 on apache:master.

I applied a different version of the PR. Thank you for your help.


[WIP] Move to Github CI

Migrated tests from TravisCI over to Github CI.
Based on configuration from https://github.com/twilio/authy-ruby/pull/69

[ ] Fix failing issue on Ruby Head (see https://github.com/juliancheal/authy-devise/runs/1456657775?check_suite_focus=true)

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[X] I acknowledge that all my contributions will be made under the project's license.

@philnash sorry I've not had a chance to look at this since I created it.

OK, I took time to take a look at this and I found out what was going on. The original failure comes from Webmock, so updating that to the latest lets the tests run at least. Following that, there are then I18n issues that are covered in #155.
I'll get this merged once #155 is fully approved.
Thanks again for doing this!

OK, I took time to take a look at this and I found out what was going on. The original failure comes from Webmock, so updating that to the latest lets the tests run at least. Following that, there are then I18n issues that are covered in #155.
I'll get this merged once #155 is fully approved.
Thanks again for doing this!

It's alive!

It's alive!


SyntaxHighlighter fails to color the code on atomOneDark and Docco, possibly other themes

I have a problem regarding the styles of the  component where it doesn't color the code for some themes at least.
If I add no theme, hence:
const MarkdownText = ({ markdown }: { markdown: string }) => {
  return (
    <Markdown
      children={markdown}
      components={{
        code(props) {
          const { children, className, node, ...rest } = props;
          const match = /language-(\w+)/.exec(className || "");
          return match ? (
            <SyntaxHighlighter
              PreTag="div"
              children={String(children).replace(/\n$/, "")}
              language={match[1]}
            />
          ) : (

              {children}

          );
        },
      }}
    />
  );
};

The code looks like this:

However, when adding atomOneDark theme from react-syntax-highlighter/dist/esm/styles/hljs, so adding the style={atomOneDark} prop to the <SyntaxHighlighter /> components, background seems to change:

I have observed in the DOM, the html code of the highlighter when there's no theme is like this: function for each word of the code snippet provided. When adding the atomOneDark theme though, there is no inline style with the color, so there seems to be a bug when adding the styles. Tried the docco theme and it also fails.
Also, that's my component usage in the code:
<MarkdownText
      markdown={"```javascript\nfunction createStyleObject(classNames, style) {\n return classNames.reduce((styleObject,
                            className) => {\nreturn {...styleObject, ...style[className]};\n}, {});\n}\n```"}
/>

I have to add that I am using the latest version of NextJS - v14.0.3 and I have tailwind. I have also tried deleting my global css but didn't change anything.
Desktop (please complete the following information):

OS: MacOS
Browser: Chrome, Opera

Same issue here, the default styles seem to be working fine but when changing to any other theme, the background changes but none of the code is highlighted

I have the same issue, but even the default styling doesn't work for me and was only able to make things work when using this solution from 2020 and not setting the language on SyntaxHighlighter. As soon as I set a language things would stop working. I tried various SyntaxHighlighter imports & styles.
import {Light as SyntaxHighlighter} from 'react-syntax-highlighter';

import typescript from 'react-syntax-highlighter/dist/cjs/languages/hljs/typescript';
import xml from 'react-syntax-highlighter/dist/cjs/languages/hljs/xml';
import {tomorrow} from 'react-syntax-highlighter/dist/esm/styles/hljs';

export const CodeBlock = () => {
    SyntaxHighlighter.registerLanguage('xml', xml);
    SyntaxHighlighter.registerLanguage('typescript', typescript);
    return (
        <SyntaxHighlighter style={tomorrow}>
            {`function App() {return true;}`}
        </SyntaxHighlighter>
    );
};

I am using Mantine for my front end, and if I put SyntaxHighlighter outside of the top level MantineProvider things work. So I suspect there is some interaction going on there between my react framework and this library...


Quick edit percentage complete

It would be great to quickly change the percentage complete (manually) when viewing a task rather than having to opening the edit view and scrolling to the bottom much like how you can add new items to the checklist

indeed. But we'll probably disable that if there is a non-empty checklist, since the progress is determined by the checklist if there is any.


README.md extension inclusion is not right

If I do
var markdowner goldmark.Markdown = goldmark.New(
	goldmark.WithExtensions(
		embed.Embed,
	),
)

embed.Embed gives an error, because .Embed doesn't exist or isn't public ?

Is it supposed to be?...
var markdowner goldmark.Markdown = goldmark.New(
	goldmark.WithExtensions(
		embed.New(),
	),
)


Tidy & fix deprecation warnings

Fixes #23031
To preview these changes, check out locally, eg:
git fetch upstream pull/22565/head:pr-22032
git checkout pr-22032

then set deprecated = true inside config.toml and preview, eg: make container-serve.

/priority important-soon
/sig release

Quick fix for the issue description:
git fetch upstream pull/22565/head:pr-23032
git checkout pr-23032

Local tests show no deprecation banner.
I also had to add a couple of files to resolve build errors related to the impending Persian localization:

content/fa/_common-resources/index.md
content/fa/case-studies/_index.md

I added a simple front matter to both:
---
headless: true
---

When I pull the branch down, I intend to test this by:

Changeconfig.toml's deprecated setting to true.
Build using make container-serve
Ensure that the deprecation warning shows up on all pages that use the different layouts covered in the PR.

If at all possible, I think the most thorough way to test this would be to (if possible) test out this PR with whatever docs snapshotting process takes place when we version.

I think the two most important areas to test are:

The main landing page says THESE ARE OLD DOCS
Any sub-doc pages (pick a few) have the THESE ARE OLD DOCS warning

It might be worth checking a few other areas, but those two are the ones we really should focus on incase somebody lands on an old doc from a google search or toggles versions and forgets.

Based on the above comments, and run from the container image:
The deprecation warning..

Does load on /_index.html (the site homepage)
Does not load on /docs
Does not load on individual docs pages, i.e. /docs/setup
Does not load on /blog
Does not load on individual blog pages, i.e. /blog/2020/08/03/physics-politics-and-pull-requests-the-kubernetes-1.18-release-interview/
Does not load on /case-studies
Does not load on individual case study pages, i.e. /case-studies/denso

** Note:** when I say "does not load", I mean "Does not load or is not visible, i.e covered by another element"

@sftim: I would like someone else to confirm these results before you spend time going in to fix them. @onlydole @jimangel – could one of you pull down this branch, run using the instructions above and confirm/deny?

Looking now.

Hi @sftim
I tried both branches -- went with the second 23032 and removed the fa directory.
The changes were not pulled down.
Anyway, I added the  content-page, docs/baseof, and deprecation-warning template modifications.
The warning appears on the docs pages. I'll add in the new styling too.
Can you provide details as to what changed (theme updates)?
I'd like to know what worked in the past.

Here is more feedback:
The deprecation warning has a yellow background and does not fill in the width of the page. To me, it looks a bit like
a sticky note applied to a web page.
I have not looked at the css for the partial. May want to check if the left margin is the same as the content margin.
The warning appears on docs and blog pages in addition to case studies pages. The deprecation warning only appears on the case studies home page, /case-studies/.
On my screen, the "edit" or "pencil" icon overlaps with the deprecated div.
The warning appears on section-index pages (the edit button does not).
Question: Do you want the deprecation warning to display as a banner in the header instead of in specific pages?

Overall, my aim for this PR is to have at least minimum-viable deprecation warnings in place before the v1.19 release.
I'm worried that the perfect may be the enemy of the good enough to merge.
I'm very happy to see iterative improvements beyond that.
If any of these changes introduce regressions or require amendments before a merge, I can pick up those fixes.

Overall, my aim for this PR is to have at least minimum-viable deprecation warnings in place before the v1.19 release.
I'm worried that the perfect may be the enemy of the good enough to merge.
I'm very happy to see iterative improvements beyond that.
If any of these changes introduce regressions or require amendments before a merge, I can pick up those fixes.

Hi @sftim. Thanks for working on fixing the deprecation warnings for the release.
My comments are intended to help not push for "perfection". Getting this fixed is very important.
I tried a few experiments, locally. What do you think about changing three baseof files (instead of the content-page), config.toml, and the style updates. Afterwards, the .css file could be removed.
I updated the header sections in the baseof.html files, adding the deprecated-warning partial into the header.
I added a check for the Case studies in the _default baseof. I did not fully test these changes, but the warning displays.
layouts/blog/baseof.html

      {{ partial "navbar.html" . }}
      {{ partial "announcement.html" . }}

          {{ $sectionHeading := .Site.GetPage "section" .Section }}
          {{ with $sectionHeading }}
            {{ .Title }}
          {{ end }}

      {{ block "deprecated" . }}
      {{ partial "deprecation-warning.html" . }}
      {{ end }}

layouts/docs/baseof.html

      {{ partial "navbar.html" . }}
      {{ partial "announcement.html" . }}

          {{ $sectionHeading := .Site.GetPage "section" .Section }}
          {{ with $sectionHeading }}
            {{ .Title }}
          {{ end }}

      {{ block "deprecated" . }}
      {{ partial "deprecation-warning.html" . }}
      {{ end }}

layouts/_defaults/baseof.html
{{ block "hero" . }}

{{ block "hero-title" . }}{{ .Params.bigheader | default .Title }}{{ end }}

{{ .Params.abstract }}

				{{ block "hero-more" . }}{{ end }}

		{{ block "post-hero" . }}
      {{ block "deprecated" . }}
        {{ if .IsHome }}
          {{ partial "deprecation-warning.html" . }}
        {{ else if eq .Params.cid "caseStudies" }}
        {{ partial "deprecation-warning.html" . }}
        {{ end }}
      {{ end }}
    {{ end }}
		{{ end }}

Here are two pics from testing:

Putting the deprecation warning in the header detaches the sidebar border from the box it's supposed to meet at the top, so I'm not keen on that approach.
How about this? The CSS is a bit nasty - happy to tidy that up (might have to get some Sass practice in first).

@sftim I can jump in on the SCSS if you like :)

Is this OK to merge now and tidy later?

/approve
/lgtm


Syntax error when used with genesis theme

When generating a new site I get this error.
/home/admorgan/.gem/ruby/1.9.1/gems/octopress-social-1.4.2/lib/octopress-social.rb:39:in `<top (required)>': /home/admorgan/.gem/ruby/1.9.1/gems/octopress-social-1.4.2/lib/octopress-social/twitter.rb:108: invalid multibyte char (US-ASCII) (SyntaxError)
/home/admorgan/.gem/ruby/1.9.1/gems/octopress-social-1.4.2/lib/octopress-social/twitter.rb:104: invalid multibyte char (US-ASCII)
/home/admorgan/.gem/ruby/1.9.1/gems/octopress-social-1.4.2/lib/octopress-social/twitter.rb:104: syntax error, unexpected $end, expecting keyword_end
 — #{user}
^
I don't see a problem with the code. This happens even when I don't include twitter in the share options.

Ah, you're on ruby 1.9. I may need to be explicit about a uff-8 encoding. Thanks. I'll work on getting a fix out.

I've just released Octopress Social 1.4.3 which should prevent the US-ASCII issue you're experiencing. Please run bundle update and let me know if that helps.

That fixed my issue.

Excellent! Thanks for the report!


Position the camera to keep the whole motion in the field of view

Hi, this is a feature suggestion.
The headless rendering is convenient, but often the subject gets out of the camera field of view during the motion sequences.
It would be great to have the option to automatically position the camera such that the whole motion stays in the camera field.
Thanks for the great work :).

Thank you and thanks for the suggestion - I can see how this is useful and we'll take a look. Could you may be shed some more light on your use case? If there is an automatic way to position the camera, what would be the preferred way (or ways) of doing this? For example, would you like the camera to follow a certain (SMPL) vertex with a certain distance? Or would you like that in each frame the camera is re-positioned and re-oriented such that it looks at the center of the scene? In this case the resulting video will not be smooth, but depending on the use case that might not be important.
In the meantime, you could already do achieve this with the latest release using the newly introduced camera paths. You would have to compute the trajectory of the camera yourself though, such that the motion stays in the camera view. This example should demonstrate all you need for this.

This is now available via viewer.lock_to_node(...), cf. the headless rendering example for a reference how to use it. Feel free to open this issue again if anything comes up.


The adapter has not been updated when updating otherOptions in useEdgeRuntime

When using useEdgeRuntime, if parameters like the body are changed, the adapter does not update.
Code：packages/react/src/runtimes/edge/useEdgeRuntime.ts

fixed in #1034
thanks!


Maple

Please add Maple
province.gg

rename to logo.png

Fixed.

u have 2 files here pls resubmit a fresh PR


Avoid a weird name collision between HRW and tscore

There's weird interactions here, a better solution (as discussed and proposed by @bryancall and @randall) is to change parameters to dlopen(). However, I'm running into different issues with that, and it's late in the game to make a change to the core that could break a lot of plugins (maybe).
See also #6445

Cherry-picked to v9.0.x branch.


Create button/script to pre-load User Testing data

See doc for details: https://docs.google.com/document/d/1rI78y_9Q73ELl3XwyjNxTeRqydXI0ntZhlo37-gtZw0/edit

[ ] add admin button
[ ] test categorical histograms

Most of the work is done and merged via #663


bos telegram

I wanted to connect bos with telegram.
I get the following message:
bos@raspberrypi:~ $ bos telegram
err:
  message: Network request for 'getMe' failed!
  stack:
    - HttpError: Network request for 'getMe' failed!
    -     at /home/bos/.npm-global/lib/node_modules/balanceofsatoshis/node_modules/grammy/out/core/client.js:180:16
    -     at processTicksAndRejections (node:internal/process/task_queues:96:5)

What can I do?

check networking? it has to be able to connect to telegram


#17 Allow offline installation with Connect

Superseeded by #48

Tested and verified in the PR #48 successfully.


Vector Store File CreateAndPoll with empty file, last_error.code returned is "invalid_file" but TS say not exist.

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
I try to manage the "invalid_file" error, generated when you upload to a vector store an empy file (Pdf, docx, other) and Typescript say me the "invalid_file" code not exist.

To Reproduce
Try to attach an empty vector store file to a  vector store for reproduce the error.
Response is:
last_error.code = "invalid_file"
last_error.message = "The file could not be parsed because it is empty."
Code snippets
const myVectorStoreFile = await openai.beta.vectorStores.files.createAndPoll(
       store_id
        {
          file_id:file_id
        }
      );

console.log('Openai Error code:',myVectorStoreFile.last_error.code);

OS
macOS
Node version
v18.20.1
Library version
^4.52.1

Thank you!


Decouple hint_processor and cairo_runner

In order to have a Python version of the CairoRunner in cairo-rs-py, things are a lot easier if the CairoRunner and the HintProcessor are decoupled.

Codecov Report

Merging #493 (61dce81) into main (237755a) will increase coverage by 0.40%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   91.58%   91.99%   +0.40%
==========================================
  Files          47       47
  Lines        3150     3136      -14
==========================================
  Hits         2885     2885
+ Misses        265      251      -14

Impacted Files
Coverage Δ

src/main.rs
5.26% <ø> (+0.26%)
:arrow_up:

src/cairo_run.rs
78.84% <66.66%> (+0.41%)
:arrow_up:

src/vm/runners/cairo_runner.rs
94.35% <100.00%> (+5.84%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Author app upload is working fine. Tried to upload the user app getting error something went wrong

Author app upload is working fine. Tried to upload the user app getting error something went wrong. Tried from Teams admin center and Teams client as well same issue.

Checked the global setting upload a custom app option is also enabled.
company-communicator-users.zip.zip

Hi Naveen-bot-creator
I have v4.1 and it works fine.
I found 2 difference between your users mainfest and mine.

line 29
yours: "personal"     without ","(comma)
mine: "personal",

line 40
yours:  "api://..."
mine:  no "api://"  domain name only

I hope the above information helps you.

Hi Naveen-bot-creator
I have v4.1 and it works fine.
I found 2 difference between your users mainfest and mine.

line 29
yours: "personal"     without ","(comma)
mine: "personal",
line 40
yours:  "api://..."
mine:  no "api://"  domain name only

I hope the above information helps you.

Thanks for the help it worked

One more issue i am facing can i add the URL of SharePoint image in the author. I tried the SharePoint image link, image is not getting displayed in the author message. Does it takes the URL of image which is based on internet?

SharePoint images will not work. Image URL should be publicly accessible without authentication like blob image URL with public access.


Testing & Copywriting & Translations

Please test front end of data registry at https://data-registry.datlab.eu/
Do the copywriting and also please prepare Spanish versions of texts

translations done in transifex, commited and deployed


[azservicebus] Updating to handle disposition hang fix

Applying patch from https://github.com/Azure/go-amqp/pull/171
The disposition functions, which we use for message settlement, can hang if the link is closed. The issue here is message disposition's initial send is done through the session and connection, which means a dead link won't be detected.
When this happens we end up blocking on a channel that won't be closed since the disposition response will never come back.

/azp run go - azservicebus

Hello Richard, would you tag a release, this bug you cloud is critical for us, we hit this several times already


Ensure greater consistency between php extensions

Use php::params::config_root_ini for ini files path :

imap
ldap
memcache
memcached

Add default settings for all extension
Remove unnecessary settings and comments

this is legit, but should be done differently imo ~_~
we shouldn't be having a params class for each php extension to begin with.
i'll merge this for now, thank you very much @Vincent-- !

I totally agree with you, Igor ;-)
Happy to help when you'll have chosen the correct implementation for doing that :-)

What about https://github.com/ripienaar/puppet-module-data/ ?

@Vincent-- i don't really think that'll be necessary…

@igalic however since in early January @ripienaar maintainer of the project @Vincent-- suggested announced :

There is now native support for this feature in Puppet 4 and this repo is now officially deprecated and moving to unmaintained.

once we officially declare Puppet 4 support (unofficially I am using my fork on v 4.* for a few months though not yet in production)  implementing module data pattern might bring improvements. :smile:

I really don't spend much time maintaining this any more - if any of you guys want commit-bit to the repo, let me know and id happily give it :)

Could we do better than Mayflower?
Mayflower module diverted far away. They have wider support across OS-es, they simplified API and put hiera usage forward. However, I am not sure if they made right design decisions.
Usage of the module is dramatically down since the last release was almost two years ago.
What do you think @igalic?

@schkovich just a heads up that I'm personally only using my module with hiera - its just poorly documented atm :)

im using it with hiera as well. :smile:
yes, this module is still placed well and used widely. we need to reach decision quickly otherwise the module might sink into oblivion since it is not maintained and there are no new releases.

@jippi, @igalic I am willing to dedicate more time to maintaining the module. Could we discuss how shall we proceed and what will be my responsibilites?

@schkovich sure thing! do you hang out in hangops slack?

nope. i guess that that i would need invitation to join hangops slack @jippi. :smile:

@schkovich here you go ! https://signup.hangops.com/ :)


Add a table of contents to readme.md

I believe this would make navigating the readme much easier.

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

I have no idea why this failed. It was forked from master and the PR is against master. I can't imagine what could have changed in the ten minutes it took me to make a change to a single markdown file.

I have no idea why this failed. It was forked from master and the PR is against master. I can't imagine what could have changed in the ten minutes it took me to make a change to a single markdown file.

Thanks for submitting this @Programazing. Sorry it's taken me so long to get to this review. Don't worry about the tests, those are unrelated. This change makes sense to me. I'm gonna pull it in!

Thanks for submitting this @Programazing. Sorry it's taken me so long to get to this review. Don't worry about the tests, those are unrelated. This change makes sense to me. I'm gonna pull it in!


Add list selector to TodoEditor

This issue was moved from the issue tracker at GitLab.

Now that we support multiple vdirs, we need the editor to support picking one for new todos (and possibly existing ones too).

Hi, I am new I would like to take up this issue.
In my opinion, I would have to make changes in the code here.
Am I wrong?

Hi @AnubhaAgrawal,
Sorry but no, this file has nothing to do with that. When running the interactive editor using todo edit ..., we want to show something that allows the user to move the task to a different task list. Please note this is a more difficult issue.
The entire editor interface is built up in TodoEditor.__init__. The outermost widget is created on line 89, which chains all previous widgets (text fields, buttons) together.

We would have to create a new variable self.current_list which is initialized with todo.list.

urwid.RadioButton can do this, so you would have to create one radiobutton for each value in self.lists. If the radio button changes, self.current_list is changed to the new value

In _save_inner, todo.list is set to self.current_list

Looks like @untitaker beat me and replied while I was still typing. Still, here goes.
Hi there! Thanks for your interest in todoman.
That's actually not right. Briefly:

cli.py contains all the code involved in parsing commands/options and processing that. This is the starting point when running the app (and, admittedly, the more complex part, IMHO).
models.py contains all the code involved in reading/writing/processing data (todos, lists, etc).
ui.py has all the code for the User Interface, including the TodoEditor class.

This issue is, mostly in ui.py, and the above comments cover most of the relevant details.

ok. I think firstly I'll try for some other issue

sorry, for negative comment now I want to work on this issue.
can anyone tell that if  I want to print the values in self.lists then how to I get them?

Hi, sorry for the slow response, if you want to find a different issue to work on that's fine of course.
I'm not sure if I understand your question. For this task you wouldn't have to print anything, but if you want to print the lists for debugging, print(self.lists) should be enough.

No, as you(@untitaker) say that you would have to create one radiobutton for each value in .self.lists. but I don't find the values in self.lists.

It appears self.lists is a generator, but for list in self.lists should still work. If you replace line 33 in ui.py with self.lists = list(lists), you should see the values.
If you have time we can discuss this over IRC because this allows for faster back-and-forth communication.


Split the core and models/extensions into different repos

Pretty straightforward. Depends on #8.
The reason for doing this is that DisCatPy itself is a more higher level Discord API wrapper but it has a core API that's accessible to users. It would make more sense if they were split. DisCatCore would be the name of the lower level API and the higher level API would keep its current name, DisCatPy.
This will most likely be done when I make a separate organization for DisCatPy.

Done, core is available at https://github.com/discatpy-dev/core


Trials of mana crashes when calling flammie (changing to the flying open world)

Hi, everytime I call flammie the game crashes in the loading screen.
I'm not using a dxvk.conf file:
Also, I'm using dxvk 2.0 if I use 1.10.3 it plays fine, so the error is with the latest version only.
my specs
Win 10 21H2
Ryzen 7 5800x 3D
RX 6800

Please make an apitrace.

Ok, besides being an extremely slow process (the game played like at 2fps) it didn't crash where the dxvk 2.0 would a 100% of the times. The game loaded the open world just fine, I used the win64 11.1 apitrace files.
In any case, here is the apitrace maybe it helps in finding a problem anyway.
https://drive.google.com/file/d/1RxJDsYqJ87hxRziusN-bWCOQBhaI3YYV/view?usp=sharing

it didn't crash where the dxvk 2.0 would a 100% of the times. The game loaded the open world just fine, I used the win64 11.1 apitrace files.

That is fine and normal as apitrace doesn't go through dxvk on Windows by default.
Sadly it doesn't crash for me when replayed toget with dxvk on Linux (R9 380).
I will try to test it ingame

got it, if you want to reproduce the errorit is like this, right now I'm in the second story (after completing the game once and a witch appears)
1- appear in any dungeon/town
2- select the item to call flammie
3- screen changes to loading screen with yellow bar
4- yellow bar won't complete and the music keeps going as usual
4a- sometime when alt-tabbing you can see a dialog box saying the game crashed, but not always.
I tried in my laptop when you can clearly hear the fans slowing when the game crashes and my desktop.

I have not been able to make it crash on my Linux setup with a AMD R9 380 and the mesa drivers. Sadly my GPU is not supported by AMD anymore so i can't try dxvk 2.0 with their drivers on either Windows or Linux.

Screenshot

But I'm also going to give it a shot on my Steam Deck

weird error, let's hope something can be found using the apitrace.

Didn't experience a crash on the Deck either. Could be a driver issue.
Can you post dxvk logs from a time it crashed? They should appear in the games base folder or next to the exe.

that's weird also, there are no logs, I'm using 22.10.3, right now I'm out, I will try again later

well, I updated to drivers 22.11.2 and the error persists, here are the logs:
https://drive.google.com/file/d/1WiBPsAiBoB6BAo6E8-3BbE7H0Lsl0wsy/view?usp=share_link
could it be that we need gpl support on windows for dxvk 2.0 to work correctly on some games?

could it be that we need gpl support on windows for dxvk 2.0 to work correctly on some games?

No, RADV doesn't support it either at the moment.

oks, well I will just keep using 1.10.3 for the moment

You could try to make a bug report to AMD and see if anything comes out of it.

Hello. Could you give it a try again with latest master?
You can grab it from here https://github.com/doitsujin/dxvk/actions/runs/3736849094

sure! just downloaded the build gonna finish something and try it, I'll report back later.

OK! I just tried the latest master you suggested and everything worked as expected, no lockups with music on the background or anything, tried moving to different villages and calling flammie multiple times and everytime the loading screen passed with no issues or crashes just the usual stuttering as shaders are being cached and still the no gpl support in the log, besides from that I'm keeping this versions xD

Awesome good to hear. Doitsujin just worked around a amd driver issue. Read here if interested https://github.com/doitsujin/dxvk/issues/3138#issuecomment-1358748842

oh.. thanks for the info, I saw the issue when it opened but didn't know it was solved, great work Doitsujin, is bothersome when your work is fine and bugs like this keep appearing.


Set up Kanban board issue

In this project's repository, we are 2 of us as a group. This is the projects link:
- https://github.com/HERMON-1995/Module-2-capstone-project.

Hi Team,
Good job so far!
To Highlight! :clap:  :green_circle:
:heavy_check_mark:  Good with issue summary
There are some issues that you still need to work on to get this project approved, but you are almost there!

Status: Requires Changes ♻
Check the comments under the review.

[ ] Please make sure you update the link to your kanban board to 👉 this, so that it takes you directly to the Kanban Board.
[ ] Make sure all cards are assigned to team members. There should be a circle with the user's avatar on each card. All cards with group task in the title should be assigned to someone.  See the image below

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack  using this handle @mihndim.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thanks for the review but we want to know what you mean when you say "Please make sure you update the link to your kanban board" @Mihndim2020.

Approved ✔
Hi @HERMON-1995 and @preciousbetine
Great job, Your project is complete!  There is nothing else to say other than... it's time to close this issue and start working on the project :shipit:
GOOD LUCK 🤞

(Changes Required) Aspects to improve: ♻

N/A

[Optional] suggestions:

N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
**Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


New package: BLISBLAS v0.1.0

Registering package: BLISBLAS
Repository: https://github.com/JuliaLinearAlgebra/BLISBLAS.jl
Created by: @carstenbauer
Version: v0.1.0
Commit: ee0fcce598109344b128f47b419985d06decb301
Reviewed by: @carstenbauer
Reference: https://github.com/JuliaLinearAlgebra/BLISBLAS.jl/commit/ee0fcce598109344b128f47b419985d06decb301#commitcomment-88390560
Description: BLIS-pendant of MKL.jl

The name of the package (all uppercase letters) makes sense here because both BLIS and BLAS are the original spellings. Also, this package is a cousin of https://github.com/JuliaLinearAlgebra/MKL.jl (and, in some sense, also https://github.com/JuliaLinearAlgebra/BLIS.jl) which both are all upper case as well. Can someone please merge this manually?

It would be nice to have this merged (I see labelled to make it happen by now). I do though see "blis_jll" and maybe it too should be upper-cased "BLIS_jll" (that probably needs to be registered first). I don't know of a policy for or against.
[noblock[

@carstenbauer happy with the name?

@fredrikekre I'm definitely happy with the name of this package here, yes. Please merge :)
As for blis_jll.jl, I guess the name had been chosen because the source github repo is named https://github.com/flame/blis. However, in their own README, they also refer to it as BLIS. I'm not sure it is worth to change blis_jll.jl -> BLIS_jll.jl. I don't have a strong opinion. In any case, this matter should probably be discussed in a separate issue over in the Yggdrasil repo. I can switch to a differently named dependency in BLISBLAS.jl in the future.


Memory Corruption when running tests

I just checked out this project and it seems like there's a memory corruption happening when running the tests. I'm not sure you are aware of that, so I'm just letting you know in case.
Critical error detected c0000374
Exception thrown at 0x00007FFC01204D1B (ntdll.dll) in basic-66257f80e6d12447.exe: 0xC0000374: Ein Heap wurde beschädigt (parameters: 0x00007FFC012697B0).

It seems to be happen fairly late, so I'd say it's happening in the some Drop implementation.

oh that's good to know, I'll try it on windows and see.  It pretty much has to be a bug in the gc-arena code, that should be fun to debug.

Oh, I bet I know what it is without looking, this is an easy one.

It was hopefully just the drop order on arena types, which I actually something I remember acknowledging that I had to do I just managed somehow to forget to do it.

In any case thanks for looking at my very very very very early project.

Actually I take that back what I said, I need to debug the garbage collection system some more, clearly something is causing heap corruption for me now as well and causing jemalloc operations to hang.

Okay NOW this should definitely be fixed, whichever one of the 3 or 4 ridiculous bugs was causing it.

It seems to work now :D