fix: Fetch report from API if needed

Details
On the withReportOrNotFound wrapper, execute an OpenReport API call if the report is missing.
Fixed Issues
$ https://github.com/Expensify/App/issues/34414
PROPOSAL: https://github.com/Expensify/App/issues/34414#issuecomment-1888769280
Tests
Same as QA
Offline tests
Same as QA
QA Steps

Login with User A and open User B's chat
Login with User B from another browser and open User A's chat
As User A, create a Task and share it with User B
Click on the created task -> "Title" and copy the URL
As User B, navigate to this URL

[ ] Verify the task title page is loaded correctly

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/c343b627-f359-4c56-91f7-2e911103f308

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/99abe8a3-167b-4c67-938f-590398b95076

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/6f5bfc8f-6fbb-447a-975c-e9d712b0db9a

MacOS: Desktop

The TypeScript check should stop failing after https://github.com/Expensify/App/pull/33715 – it's not related to this PR.

@allroundexperts a friendly bump on the review here, thanks 🤝

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@paultsimura I'm still getting the following on mobile devices:
https://github.com/Expensify/App/assets/30054992/b95bf282-b4fd-4e76-a584-37d31475b3f9

@paultsimura I'm still getting the following on mobile devices:

Could you please double-check if you have access to the task itself (removing the /title from the URL)?

Could you please double-check if you have access to the task itself (removing the /title from the URL)?

https://github.com/Expensify/App/assets/30054992/44b3e14d-381a-4134-a099-bd4e8f47f98b
Yes, I have access to the task.

That is weird because neither did I open the task on my recordings, and everything worked well 🤔 . I will try to reproduce tomorrow

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

The QA team reports here that this is not resolving the issue, I'm going to edit the PR description to remove the $ so it doesn't close the linked issue. Please double-check if something still needs to be fixed, thanks!

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

The QA team reports here that this is not resolving the issue, I'm going to edit the PR description to remove the $ so it doesn't close the linked issue. Please double-check if something still needs to be fixed, thanks!

This is weird, getting back to it now 🤔

@allroundexperts seems like I found the issue.
Do you know if we can test the true deep links on the native apps? Meaning that clicking a link in the app will lead to another page in the app without opening the browser first


Feature/mucmtoolkit

Adds a roughly working version of the MUCM toolkit to the documentation. All of the toolkit pages have been added, though the conversions from the original HTML files to RST have a few bugs (particularly in the equations). These unforunately have to be corrected by humans, and since there are a couple of hundred pages, this may take some time to complete. However, all of the pages should be in place, along with the images. I will continue to post updates to the documentation over the next few weeks.
Fixes issue #24

Codecov Report

Merging #54 into devel will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel      #54   +/-   ##
=======================================
  Coverage   84.61%   84.61%
=======================================
  Files          26       26
  Lines        4733     4733
=======================================
  Hits         4005     4005
  Misses        728      728

Impacted Files
Coverage Δ

setup.py
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47743ab...97ebf0d. Read the comment docs.


Template Translations IV

Changes in stream-feed and users.
ToDo List:
*application/auth-onboarding/...
*application/user-notification/item.hbs
*dashboard/unread-groups.hbs
*stream-feed/items/library-entry/activity.hbs
*users/edit-profile/footer.hbs

branch error


[FEATURE] Allow the word invalid

Description
The word invalid is flagged by EddieBot, but it is an actual word used in JavaScript errors. I would change the wording but it would make describing the issue ambiguous.
Screenshots
No response
Additional information
No response

I had a go at this. Please ignore if changing the banned words list is frowned upon. Getting my feet wet with the whole open source contribution world. Thanks!

There is only one way to find out.


Mint URL QR Share

added new QRShareModalComponent
added share option to selectedMint modal
added share when tapping mint url in MintInfoScreen

Importing a mint by QR code works as well
closes #89

Thanks! As I made in parallel a lot of smaller changes to MintInfoScreen, I rather copied most of your code into my changeset - was easier then going through merge conflicts.


iothub readme.python package version change

https://github.com/Azure/sdk-release-request/issues/1451

/azp run


DDP hang when using vector-quantize-pytorch within torchrun

Hi, I've noticed that there is some distributed.all_reduce code in vector-quantize-pytorch. If I use this package in some ddp wraped code, for example, I run torchrun train.py, and train.py contains vector-quantize-pytorch code, the ddp will hang forever.
Same problem has been observed in this issue #30
I wonder if in torchrun mode, can I just simply remove all the distributed.all_reduce and let self.kmeans_all_reduce_fn=noop, self.all_reduce_fn=noop.
Currently this is my solution and I can let the model continue training in torchrun. But I worrry that this might leads to incorrect result. Hope to know the correct way to let this package work in torchrun.
Thanks!

@aluminumbox hi Xiang
you can actually force ddp all reduce to be turned off by setting sync_codebook = False
that's interesting it hangs though, is fairseq being used, as in the other issue? i'm not familiar with torchrun

Thanks for the advice. I tried sync_codebook = False and everything is okay now. Yes when I run torch train.py that contains this package, the ddp hangs for 30mins then timeout. I am using another toolkit named wenet. Basically it is some code wrapped by torch.distributed and run in torchrun mode. Actually I tried to solve the problem by setting sync_kmeans = False earilier but it does not help. It maybe helpful to add this tip in annotation to help others who might also be stuck with torchrun.

@aluminumbox are you using gloo or nccl?

@aluminumbox are you using gloo or nccl?

I am using nccl in torchrun mutli node mode and it hangs for 30mins.
If I use gloo, it gives error information.
terminate called after throwing an instance of 'gloo::EnforceNotMet'   what():  [enforce fail at ../third_party/gloo/gloo/transport/tcp/pair.cc:446] op.preamble.length <= op.nbytes. 971396 vs 256

@aluminumbox what happens if you set sync_codebook = True with nccl?

@aluminumbox what happens if you set sync_codebook = True with nccl?

Sorry for the late reply. If i use nccl, it will hang for like 30mins than timeout, no detail error log. If I use gloo, it gives above error information op.preamble.length <= op.nbytes. 971396 vs 256

I get the same issue when i train with FSQ. It just hangs like forever. Do we know what is the problem here?

@xiaonengmiao could you give more information on the context? is it hanging on training or eval? what version
also, try setting quantize_dropout to False and see what happens. that will help me narrow it down

@xiaonengmiao could you give more information on the context? is it hanging on training or eval? what version of vq-pytorch are you on and how you are using it
also, try setting quantize_dropout to False and see what happens. that will help me narrow it down

Thank you for your reply. When i tried to test the ddp training again on ResFSQ, this time it just works! I can not reproduce the result yesterday. Sorry for the inconvenience. I will keep testing. Right now FSQ works extremly fine. Thanks for this wonderful work!

 Is it because you turned off the quantize dropout this time?

@xiaonengmiao anyhow do let me know if the problems comes up again and let's try a few things
FSQ is a fine quantizer, have a great time training


redirection after code validation

Hello,
I had my configuration working perfectly on apache 2.4.46, but once I updated the config to 2.4.53, I noticed an issue that is linked to the last redirection after code validation. https://example.com/?code... : code validation is OK.
The user got redirected to https://example.com:8080/app instead of https://example:443/app the external route (exposed via openshift). OIDC Module is forcing the use of virtual host port instead of the ServerName.
Normally we expect after all the authentication is good that the user should be redirected to /app without any dns. I tried modifying the location header for the last redirection but without success. Do you have a fix?
my configuration :
<VirtualHost *:8080>
ServerName  example.com
ServerAlias example.com
SSLEngine on
SSLCertificateFile
SSLCertificateKeyFile
SSLCertificateChainFile
OIDCProviderMetadataURL
OIDCClientID <client_id>
OIDCClientSecret <client_secret>
OIDCCryptoPassphrase
OIDCRedirectURI https:///
<Location "/">
AuthType openid-connect
Require valid-user

https://github.com/zmartzone/mod_auth_openidc/wiki#20-why-is-my-ticket-closed-as-invalid


[microNPU] Add relu6 relu_n1_to_1 test cases for Ethos-U

Tests are extended with cases with activations relu6 and relu_n1_to_1.
Does not fuse min and max operations with requantize if there are different scales as it is not supported on NPU. Since there is a hardware limitation, we cannot perform min or max operation fused with requantize (please look at NPU_SET_OFM_SCALE register description https://developer.arm.com/documentation/102420/0200/Programmers-model/Command-stream/cmd1-commands-) when we have different scales.
cc @leandron, @ekalda, @lhutton1

(1) We should still check whether TFLite's RELU6 is correctly executed on NPU, some basic conv2d + RELU6 tests should do

in my opinion it will be enough to add separate tests for RELU6 and RELU_N1_TO_1 since RELU, RELU6, RELU_N1_TO_1
activations are converted to clip operation in the tflite frontend https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tflite.py#L534 and other cases with basic operations will be covered by cases with relu activation or is it necessary to add tests for RELU6, RELU_N1_TO_1 with other operations?

(2) I'm confused about the min/max changes - is it an unrelated bugfix or necessary for RELU_N1_TO_1 implementation?

this is adding restrictions according to the hardware

so I suspect that if the graph consists only RELU and nothing else, it doesn't get offloaded to NPU at all.

in this case requantize operation can be offloaded to NPU

I think so far the approach has been to match all the variations of the operator and then output the right combination of Ethos-U ops, e.g. Resize2d. If there is a reason it can't be done that way, it would be good to document it there since it is not immediately obvious from the code why we need two patterns.

reason that two patterns are used is that we can understand whether this pattern is suitable after checking scales match that are performed in function is_valid

To me this looks like fixing what was an oversight in the initial implementation of binary elementwise and is not related to adding support to two new activation functions (which is what the title of this PR claims) and in general should be a separate PR, but I don't think it worth the trouble to split up this PR since it is quite small.

I left in this PR only adding tests for RELU6 and RELU_N1_TO_1 and I'm going to create another PR with changes to binary elementwise implementation


Going on a small vacation

Will be gone for a few days on a trip to west Norway to visit relatives. Currently, I've been learning more about computer assisted theorem proving this week, stepping down a bit on the pace of Piston, as I work best when focusing on a single project at a time. This will also save some duplicate work, since Gfx and Conrod are under redesign. Plans are ready for texture filtering in the piston-graphics backends, but since the Gfx design might require some redesigning in piston-graphics, it is not high priority (sorry to those who need nearest texture filtering to make pixelart games!).
Good news: I figured out a backward propagation mechanism in path semantics that allows expressions to use "normal programming". (path semantics is the investigation of an alternative paradigm to dependently types)
@mitchmindtree and @nwin have ownership, there are plenty of people in the admin group, so I expect things to run smoothly when I am gone.

Have a great journey chap :smile_cat: wish I was visiting Norway!

It was great!


Is there any bug that causes a lower performance

Test Performance are not as good as claimed
For example:
train on sta test on stb, claimed performace is: mae=11.4 and mse=19.7, but following the script yeilds mae=11.375 and mse=386.8510
key difference is the mse
Is there any bug when test mse?

The "mse" reported in most crowd counting papers is actually "rmse", r standing for rooted. In the repo I only calculated raw mse, so that's the difference.

Test Performance are not as good as claimed For example: train on sta test on stb, claimed performace is: mae=11.4 and mse=19.7, but following the script yeilds mae=11.375 and mse=386.8510 key difference is the mse Is there any bug when test mse?

Hello, could you provide the details of your training environment? For example, the GPU model, memory, epochs, batch size, and most importantly, the random seed.

The "mse" reported in most crowd counting papers is actually "rmse", r standing for rooted. In the repo I only calculated raw mse, so that's the difference.

Thanks A Lot!

Test Performance are not as good as claimed For example: train on sta test on stb, claimed performace is: mae=11.4 and mse=19.7, but following the script yeilds mae=11.375 and mse=386.8510 key difference is the mse Is there any bug when test mse?

Hello, could you provide the details of your training environment? For example, the GPU model, memory, epochs, batch size, and most importantly, the random seed.

GPU is 2080, other environment settings are the same as this project.

Test Performance are not as good as claimed For example: train on sta test on stb, claimed performace is: mae=11.4 and mse=19.7, but following the script yeilds mae=11.375 and mse=386.8510 key difference is the mse Is there any bug when test mse?

Hello, could you provide the details of your training environment? For example, the GPU model, memory, epochs, batch size, and most importantly, the random seed.

GPU is 2080, other environment settings are the same as this project.

Thank you for your response! May I ask if you only used the author's checkpoint for testing or if you retrained the model yourself before testing? I have run it a few times myself, but the metrics still differ from those in the paper, which is quite troubling!

The hardware is RTX3090, and hyperparameters should be the same as in the config file. It is awkward that the model is not fully deterministic even if the seed is fixed, and a crash of the cluster ruined all of my files so I cannot check the log. Sorry for the inconvenience.

entation. In DG the results can differ greatly, especially in crowd counting where datas

I tested the offical models provided by author, it can produce results close to the claimed mae but much bigger mse. The author just explained why mse values are different in this page.
I also reproduced the training part. The mae and mse are a little bit high than the models provided by author.
I didn't change a lot on the code, just change data part. I use only one gpu.

Test Performance are not as good as claimed For example: train on sta test on stb, claimed performace is: mae=11.4 and mse=19.7, but following the script yeilds mae=11.375 and mse=386.8510 key difference is the mse Is there any bug when test mse?

Hello, could you provide the details of your training environment? For example, the GPU model, memory, epochs, batch size, and most importantly, the random seed.

GPU is 2080, other environment settings are the same as this project.

Thank you for your response! May I ask if you only used the author's checkpoint for testing or if you retrained the model yourself before testing? I have run it a few times myself, but the metrics still differ from those in the paper, which is quite troubling!

The hardware is RTX3090, and hyperparameters should be the same as in the config file. It is awkward that the model is not fully deterministic even if the seed is fixed, and a crash of the cluster ruined all of my files so I cannot check the log. Sorry for the inconvenience.
I searched a little bit and the problem seems to be that F.interpolate is not deterministic. I didn't realize this in my implementation. In DG the results can differ greatly, especially in crowd counting where datasets are quite small.

Alright, thank you very much for your work!!!

I tested the offical models provided by author, it can produce results close to the claimed mae but much bigger mse. The author just explained why mse values are different in this page. I also reproduced the training part. The mae and mse are a little bit higher than the models provided by author. I didn't change a lot on the code, just change data part. I use only one gpu.

Alright, thank you for your response!

作者你好，我在复现你的代码时发现结果并不能达到论文中所写的那样。例如在测试sta->stb时，您的结果是MAE：11.4，MSE：19.7，但是我运行你的代码所得到的结果只能得到MAE：13多，MSE：25左右，在测试qnrf数据集时也是如此。我的使用的GPU是3090，其他超参数都没有变，还是用的你代码中所给出的。我想问问作者大大，我哪一步需要调整，希望能够得到作者大大的解答。

作者你好，我在复现你的代码时发现结果并不能达到论文中所写的那样。例如在测试sta->stb时，您的结果是MAE：11.4，MSE：19.7，但是我运行你的代码所得到的结果只能得到MAE：13多，MSE：25左右，在测试qnrf数据集时也是如此。我的使用的GPU是3090，其他超参数都没有变，还是用的你代码中所给出的。我想问问作者大大，我哪一步需要调整，希望能够得到作者大大的解答。

本楼有回答

你好作者原文的batch_size设置为16，我的笔记本是4060显卡显存不够，我把batch_size调整为8训练出来的模型只能得到mae:14多。用你提供的模型可以达到论文水平。请问是因为我没有同步调整其他参数的原因吗？其他参数因该做什么调整呢需要更改num_epochs和lr吗？

你好作者原文的batch_size设置为16，我的笔记本是4060显卡显存不够，我把batch_size调整为8训练出来的模型只能得到mae:14多。用你提供的模型可以达到论文水平。请问是因为我没有同步调整其他参数的原因吗？其他参数因该做什么调整呢需要更改num_epochs和lr吗？

lr 要改成一半，steps_per_epoch 要改成两倍。即使更改后也可能会和论文水平有差距，一方面是 batch size有影响，另一方面是 code 中的失误导致 model 并非完全 deterministic，参见本楼上面的讨论。

Hi, can anyone here provide me with the preprocessed dataset along with the density map (dmap_gen). for all three data sets sta,stb, qnrf ? Basically ready for training state. Actually my system is facing heating issues while running the algorithm and it is taking too much of time. This would be of a great help.
Thanking you in advance.

作者你好，我运行你的cls模型跑出来的sta_test_stb结果是mae：18.8，mse开根号后接近30。为什么mae与你论文上的14.4相差这么大呢？跑final模型出来的mae也是在13到14之间。这也和你论文中声称的11.4相差比较远。那我应该如何去弥补这个缺失的值？硬件是单块4090，其余超参数与你的yaml文件保持一致。如果是上采样具有不确定性，那么你的论文里面的指标是否应该考虑将最好的值换成平均值呢？

作者你好，我运行你的cls模型跑出来的sta_test_stb结果是mae：18.8，mse开根号后接近30。为什么mae与你论文上的14.4相差这么大呢？跑final模型出来的mae也是在13到14之间。这也和你论文中声称的11.4相差比较远。那我应该如何去弥补这个缺失的值？硬件是单块4090，其余超参数与你的yaml文件保持一致。如果是上采样具有不确定性，那么你的论文里面的指标是否应该考虑将最好的值换成平均值呢？

论文中的指标和相关工作保持一致选择了最佳值，有空之后我会修改模型并重新训练保证结果可以复现。

好的，谢谢作者大大的工作。此外，我还有一个问题，运行结果的不稳定是否主要归结于分类PC插件呢？

作者你好，请问能提供训练q的checkpoint文件吗？

好的，谢谢作者大大的工作。此外，我还有一个问题，运行结果的不稳定是否主要归结于分类PC插件呢？

并非如此

作者你好，请问能提供训练q的checkpoint文件吗？

暂时还不行，过段时间我会重新训练所有的模型

I searched a little bit and the problem seems to be that F.interpolate is not deterministic. I didn't realize this in my implementation. In DG the results can differ greatly, especially in crowd counting where datasets are quite small.

fixed by the latest commit


Claim functionality not delivered in Governance v0.9.10.

11/5/22 List of Claim functionality described in "Claim Points" user story that were not delivered in freeosgov2 v0.9.10.

Users will not be able to claim after exceeding their maximum lifetime allowance.
Mint an additional of 3% for Partners (Mint +3%)
Mint an additional 7% for FreeDAO (Mint +7%).
Calculate Lock Points using the same logic as in AIrClaim.
Allocate the amount locked and unlocked to users.

Tom | freeos.io | freedao.io — Yesterday at 13:03
Sure, I'll have a look now
No, we're not currently paying 7% to freedao
I'd advise failing the claim story until that is done
...unless we can spin that off into a separate story
Actually, I've thought about it, let's keep the claim story in one piece. Can you create an issue for the fact that the 7% and 3% to partners is not being done?

21/6/22 Claim functionality delivered and tested. Close.


[Performance Issue] High CPU Usage when using CD Extension

Describe the bug

Problem solved.

hi @djhahe , please help to link the related commit / PR

update keep sw alive in v.1.5.0


When using seeder and migrate:fresh, ID still incrementing instead of starting from 1.

Hi Ryan, great package! I am using this to do some specific tasks, but when trying to fresh seed, the id of the markdown keeps incrementing instead of starting from 1. Is this intentional or... a bug? Thank you

The issue will be that the SQLite database that is used for caching results isn't being removed. You can try to run orbit:clear which will remove the file and essentially clear any history of increments.

That makes sense. Should we add that to the readme?

@sawirricardo Feel free to make a PR. I'm in the process of planning a big refactor before v1.0 anyway.


Workflow to fetch board name and use it to run the trello create board script

Changed the workflow to run on workflow_dispatch
Using board_name as a parameter to run the Trello script

@shivahari I removed the commented line


add support for subscriptions

Ticket Link

Related Links

Description

Steps to Reproduce / Test

Request

Response

Codecov Report

Merging #81 (3578de1) into master (5975e02) will decrease coverage by 0.24%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   82.80%   82.56%   -0.25%
==========================================
  Files          27       27
  Lines         954      958       +4
==========================================
+ Hits          790      791       +1
- Misses        124      126       +2
- Partials       40       41       +1

Impacted Files
Coverage Δ

pkg/api/api.go
76.92% <0.00%> (-2.81%)
:arrow_down:

pkg/utl/result_wrapper/error.go
94.39% <100.00%> (+0.05%)
:arrow_up:

resolver/subscriptions.resolvers.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd73493...3578de1. Read the comment docs.


Update index.mdx

Added reference to fabform as a form backend service
Summary

Screenshots (optional)

Documentation checklist

[ ] The documentation style guide has been adhered to.
[ ] If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
[ ] Files which have changed name or location have been allocated redirects.

Howdy @fabforms, more of the point of those related resources is to direct folks to other resources w/in our ecosystem.
Going to close out this PR... but if you wanted to submit something around integrating fab forms with a Pages project in terms of content to our repo, definitely open to having that as part of our resources.


feat: add database backup

This PR was generated using Autosynth. :rainbow:
Log from Synthtool
{synth_log}

@skuruppu is this clear to merge?

@skuruppu is this clear to merge?

I think it looks good (the tests pass). If we can hold off for the day, that would be great. I apparently didn't do something right to configure the legacy GAPIC generator for backups so the Ruby code gen is breaking. I think PHP is also using the legacy generator so I wanted to make sure that we're doing the right thing.

No problem! Could you let me know once the issue is resolved? I’ll need to update the pull request.

No problem! Could you let me know once the issue is resolved? I’ll need to update the pull request.

Done. googleapis now has the fixes.


feat: compatibility with Mercure 0.10

Thanks for this library! This PR adds support for Mercure version 0.10.

Thanks!


ENH: Add cross-compiled support

Add cross-compiled Python support

Add python, cross-python_{{ target_platform }}, and cmake to build requirements
when the build platform is not the target platform.

c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#details-about-cross-compiled-python-packages

Remove skip of macOS.
Bump build number.

Squash and merge commit message
* Add cross-compiled Python support
   - Add 'python', 'cross-python_{{ target_platform }}', and 'cmake' to build
     requirements when the build platform is not the target platform.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#details-about-cross-compiled-python-packages
* Remove skip of macOS.
* Bump build number.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[N/A] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@henryiii, following PR #8, do you have any thoughts on why macOS builds are failing?

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Fix qgroundcontrol configure stage

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I've been trying to use qgroundcontrol, but couldn't install it due to
an error in the configure stage:
~ $ nix-shell --pure -p qgroundcontrol
these derivations will be built:
  /nix/store/ah0hfb91hyg22ls10nnf9k4s0vnwkq7c-qgroundcontrol-2.9.4.drv
building path(s) ‘/nix/store/hqshfrdwpknbgh8cv2rjhw702wk236v0-qgroundcontrol-2.9.4’
qmake: File exists
_makeQtWrapperSetup
unpacking sources
unpacking source archive /nix/store/2rwixfzm7fj3gbqj1rs2c9p965jfxiw4-qgroundcontrol
source root is qgroundcontrol
patching sources
applying patch /nix/store/9jxhwhkw7j2751wwx75g9hjx23hwhmnm-0001-fix-gcc-cmath-namespace-issues.patch
patching file src/Vehicle/Vehicle.cc
patching file src/comm/QGCFlightGearLink.cc
patching file src/comm/QGCJSBSimLink.cc
patching file src/uas/UAS.cc
patching file src/ui/QGCDataPlot2D.cc
configuring
Project ERROR: You must use shadow build.
builder for ‘/nix/store/ah0hfb91hyg22ls10nnf9k4s0vnwkq7c-qgroundcontrol-2.9.4.drv’ failed with exit code 3
error: build of ‘/nix/store/ah0hfb91hyg22ls10nnf9k4s0vnwkq7c-qgroundcontrol-2.9.4.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies

This solution probably isn't the best or cleanest, but applying this
patch makes it build successfully for me.

Actually, this appears to be effectively a revert of fb2c651647a6de71d4ab036215b1cf1758addcc2

Try doing this:
  preConfigure = "cd build";
  qmakeFlags = [ "../qgroundcontrol.pro" ];
  installPhase = ''
    cd ..
    ...

I've fixed it in https://github.com/NixOS/nixpkgs/commit/51f479465c22de490fe0e55ae6ae41cade6f771a.


Compositing barrels somtimes "stuck" after loading world

In single player (haven't tested it on a server) sometimes after loading the world compositing barrels are stuck. They display the dirt texture (as I'm using TOP I can't see it's internal state) but you can't remove the dirt (by right clicking with an empty hand) or add other things to it.
I don't know if I left the world while it was still composting or if it was already finished. Breaking the barrel seems to be the only fix for that.
I'm using exnihiloadscensio-1.10.2-0.1.11.jar together with ExCompressum_1.10.2-2.0.68.jar

This now also happened with a stone barrel connected via EIO conduits to lava producing crucibles with water on top. I have this setup so that I can make obsidian by right clicking the barrel when I need it - and I logged out with obsidian ready in the barrel - but now the barrel is stuck too.

FWIW I think I fixed this in 5c4ce92384b72761d3d6494310048d5498c8c69e
Please re-open if it persists.


[FEATURE] Daily Time Slot for sending mails

It would be great if you can define a daily time span where emails could be sent between date x and y.
E.g. 08:00 am to 05:00 pm.

Adding this one to the v0.2.0-beta.

something like this:

This feature should be implemented with another merge request.
Because the old one, doesn't implements it the right way.
Trying to find another implementation of this feature implementation.


PR against issue #291 || Revamp Contact Page

@nilisha-jais Please check this.

Hey @RahulBansal0502 are'nt you updating your fork before pushing the changes?

I have updated but before I push the changes you made changes in the repo.

Check this on how to resolve merge conflicts

And you need to use command line to solve the conflict because it in your case it is too complex for the web editor to solve

ok I will check Thanks!

I have not access to write.

Thats what I meant it's  too complex for a web editor to solve it....you need to use command line

Do one thing I'll close both the pr you first pull the changes and then make the pr....conflicts would not occur then. But remember do pull the changes

Heyy @nilisha-jais can u please help me with how can I resolve this? Because if I will pull the changes then the changes that I have made will also changed so any idea how will I proceed?

You won't loose the code you changed much I guess.....If you fear this thing then you need to solve the merge conflicts.
Take help from the video of How to solve conflicts and solve it using command line


Implement recast service

GitHub Issue: Islandora-CLAW/CLAW/issues/800
Depends on: https://github.com/Islandora-CLAW/Crayfish-Commons/pull/16
What does this Pull Request do?
This PR implements a new API-X extension service inside of Crayfish. The service binds to resources of rdf:type ldp:RdfSource and rewrites the request to add Fedora URIs for Drupal URIs it finds in the Gemini DB.
What's new?

Moves the GeminiClient out of Milliner and into Crayfish-Commons to use it in Recast as well.
Adds a new findUrls service to UrlMapper in Gemini.
Adds a new /by_uri endpoint with a getByUri function which uses the above search.
Adds the new Recast service, the service is normally accessible at the svc:recast uri via API-X
Adds/updates tests as necessary

Does this change require documentation to be updated? maybe
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no

How should this be tested?
Testing is not fun. So I have made a shell script to automated most of it but only on Ubuntu.

Bring up a claw-playbook.
vagrant ssh into the machine.
Download/copy paste this shell script to your home directory. Make it executable.
Execute the shell script using sudo.

The script should:

Move the old Crayfish
Clone the new branch in place.
Copy the old config files back over.
Download and patch all the composer.json files to use the associated Crayfish-Commons PR.
Run composer update on all the crayfish services.
Download a new Apache configuration for Recast into /etc/apache2/conf-enabled/
Restarts Apache
Configures the API-X loader to use port 8111
Waits 5 seconds and tries to register the recast service.

If all that goes well then if you go to http://localhost:8080/fcrepo/rest/apix/services one of the children should be something like "http://localhost:8080/fcrepo/rest/apix/services/CLAW-RecastService"
If so, go to Drupal and make some objects.
Then to see the service in action, you view a Fedora object through API-X.
Goto http://localhost:8081/fcrepo/rest (yes 8081, not 8080).
Choose any of your object that is a member of another object (ie. if you have an image inside a collection, choose that).
The URI will be something like http://localhost:8081/fcrepo/rest/b4/39/49/d3/b43949d3-3b1f-457d-8ae6-c57bb3b925ee
You replace /fcrepo/rest with /services and add /svc:recast onto the end.
Using CURL try
curl -i -H"Accept: text/turtle" -G "http://localhost:8081/services/b4/39/49/d3/b43949d3-3b1f-457d-8ae6-c57bb3b925ee/svc:recast"

You should get back the triples but with the addition of fedora ones.
You can also do
curl -i -H"Accept: text/turtle" -G "http://localhost:8081/services/b4/39/49/d3/b43949d3-3b1f-457d-8ae6-c57bb3b925ee/svc:recast/replace"

This will remove the Drupal URI when it adds the Fedora URI.
Example (regular):
[
    {
        "@id": "http://localhost:8081/fcrepo/rest/5f/8c/5d/80/5f8c5d80-b442-4212-9752-1cb2ce182dfd",
        "http://fedora.info/definitions/v4/repository#created": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#createdBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://purl.org/dc/terms/description": [
            {
                "@value": "This collection is inside another one"
            }
        ],
        "@type": [
            "http://pcdm.org/models#Collection",
            "http://fedora.info/definitions/v4/repository#Container",
            "http://www.w3.org/ns/ldp#RDFSource",
            "http://schema.org/CollectionPage",
            "http://www.w3.org/ns/ldp#Container",
            "http://fedora.info/definitions/v4/repository#Resource"
        ],
        "http://schema.org/dateModified": [
            {
                "@value": "2018-03-13T20:35:17+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#lastModified": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#lastModifiedBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://fedora.info/definitions/v4/repository#writable": [
            {
                "@value": true
            }
        ],
        "http://pcdm.org/models#memberOf": [
            {
                "@id": "http://localhost:8000/node/1?_format=jsonld"
            }
        ],
        "http://fedora.info/definitions/v4/repository#hasParent": [
            {
                "@id": "http://localhost:8081/fcrepo/rest/"
            }
        ],
        "http://purl.org/dc/terms/title": [
            {
                "@value": "A sub-collection"
            }
        ],
        "http://schema.org/author": [
            {
                "@id": "http://localhost:8000/user/1?_format=jsonld"
            }
        ],
        "http://schema.org/dateCreated": [
            {
                "@value": "2018-03-13T20:34:47+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ]
    }
]

Example (add):
[
    {
        "@id": "http://localhost:8080/fcrepo/rest/5f/8c/5d/80/5f8c5d80-b442-4212-9752-1cb2ce182dfd",
        "@type": [
            "http://pcdm.org/models#Collection",
            "http://fedora.info/definitions/v4/repository#Container",
            "http://schema.org/CollectionPage",
            "http://fedora.info/definitions/v4/repository#Resource",
            "http://www.w3.org/ns/ldp#RDFSource",
            "http://www.w3.org/ns/ldp#Container"
        ],
        "http://fedora.info/definitions/v4/repository#lastModifiedBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://schema.org/dateModified": [
            {
                "@value": "2018-03-13T20:35:17+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://schema.org/author": [
            {
                "@id": "http://localhost:8000/user/1?_format=jsonld"
            }
        ],
        "http://schema.org/dateCreated": [
            {
                "@value": "2018-03-13T20:34:47+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#createdBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://fedora.info/definitions/v4/repository#lastModified": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#created": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://pcdm.org/models#memberOf": [
            {
                "@id": "http://localhost:8000/node/1?_format=jsonld"
            },
            {
                "@id": "http://localhost:8080/fcrepo/rest/b4/39/49/d3/b43949d3-3b1f-457d-8ae6-c57bb3b925ee"
            }
        ],
        "http://purl.org/dc/terms/description": [
            {
                "@value": "This collection is inside another one"
            }
        ],
        "http://purl.org/dc/terms/title": [
            {
                "@value": "A sub-collection"
            }
        ],
        "http://fedora.info/definitions/v4/repository#writable": [
            {
                "@value": true
            }
        ],
        "http://fedora.info/definitions/v4/repository#hasParent": [
            {
                "@id": "http://localhost:8080/fcrepo/rest/"
            }
        ]
    }
]

Example (replace):
[
    {
        "@id": "http://localhost:8080/fcrepo/rest/5f/8c/5d/80/5f8c5d80-b442-4212-9752-1cb2ce182dfd",
        "@type": [
            "http://pcdm.org/models#Collection",
            "http://fedora.info/definitions/v4/repository#Container",
            "http://schema.org/CollectionPage",
            "http://fedora.info/definitions/v4/repository#Resource",
            "http://www.w3.org/ns/ldp#RDFSource",
            "http://www.w3.org/ns/ldp#Container"
        ],
        "http://fedora.info/definitions/v4/repository#lastModifiedBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://schema.org/dateModified": [
            {
                "@value": "2018-03-13T20:35:17+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://schema.org/author": [
            {
                "@id": "http://localhost:8000/user/1?_format=jsonld"
            }
        ],
        "http://schema.org/dateCreated": [
            {
                "@value": "2018-03-13T20:34:47+00:00",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#createdBy": [
            {
                "@value": "bypassAdmin"
            }
        ],
        "http://fedora.info/definitions/v4/repository#lastModified": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://fedora.info/definitions/v4/repository#created": [
            {
                "@value": "2018-03-13T20:35:17.645Z",
                "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
            }
        ],
        "http://pcdm.org/models#memberOf": [
            {
                "@id": "http://localhost:8080/fcrepo/rest/b4/39/49/d3/b43949d3-3b1f-457d-8ae6-c57bb3b925ee"
            }
        ],
        "http://purl.org/dc/terms/description": [
            {
                "@value": "This collection is inside another one"
            }
        ],
        "http://purl.org/dc/terms/title": [
            {
                "@value": "A sub-collection"
            }
        ],
        "http://fedora.info/definitions/v4/repository#writable": [
            {
                "@value": true
            }
        ],
        "http://fedora.info/definitions/v4/repository#hasParent": [
            {
                "@id": "http://localhost:8080/fcrepo/rest/"
            }
        ]
    }
]

Additional Notes:
Interested parties
@Islandora-CLAW/committers

@whikloj Just a guess from Travis's output, but maybe try generating a composer.json using PHP 5.6? https://github.com/Islandora-CLAW/Crayfish/pull/42#issuecomment-331491440

@dannylamb This should "work" now, but the Gemini and Recast tests will fail as they rely on the Crayfish-Commons PR. So once that is merged, then these tests could be restarted.

@whikloj
Ran the script and getting an exception thrown.  The service is not being registered.
phpunit/phpunit suggests installing ext-xdebug (*)
Writing lock file
Generating autoload files
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   252  100   252    0     0    806      0 --:--:-- --:--:-- --:--:--   805
 * Reloading Apache httpd web server apache2                                                                                *
Sleep for 5 while apix-loader reloads
HTTP/1.1 500 Server Error
Content-Type: text/plain; charset=ISO-8859-1
Transfer-Encoding: chunked

org.apache.camel.http.common.HttpOperationFailedException: HTTP operation failed invoking http://localhost:8000/recast/ with statusCode: 500
	at org.apache.camel.component.http4.HttpProducer.populateHttpOperationFailedException(HttpProducer.java:312)
	at org.apache.camel.component.http4.HttpProducer.process(HttpProducer.java:207)
	at org.apache.camel.util.AsyncProcessorConverterHelper$ProcessorToAsyncProcessorBridge.process(AsyncProcessorConverterHelper.java:61)
	at org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)
	at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
	at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
	at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
	at org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)
	at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
	at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.processor.ChoiceProcessor.process(ChoiceProcessor.java:117)
	at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
	at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
	at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
	at org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)
	at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
	at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.processor.ChoiceProcessor.process(ChoiceProcessor.java:117)
	at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
	at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
	at org.apache.camel.component.jetty.CamelContinuationServlet.doService(CamelContinuationServlet.java:206)
	at org.apache.camel.http.common.CamelServlet.service(CamelServlet.java:74)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
	at org.eclipse.jetty.servlets.MultiPartFilter.doFilter(MultiPartFilter.java:146)
	at org.apache.camel.component.jetty.CamelFilterWrapper.doFilter(CamelFilterWrapper.java:43)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
	at org.eclipse.jetty.server.Server.handle(Server.java:499)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
	at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
	at java.lang.Thread.run(Thread.java:748)

@dannylamb so in the Crayfish config.yaml files ../syn-settings.xml means move up from the cfg directory to the microservice root (ie. Houdini) so you need to go ../../syn-settings.xml to have it in the Crayfish directory 🤦♂
Couple changes to match up with the changes in Crayfish but this still works, though for those things not in Gemini I can't do anything so we might want to consider whether more things should be mapped using it.

well this has become completely screwed. I'll see if I can get all the pieces together again, but don't bother trying this one.

@dannylamb Codecov is kicking me for boosting it to 100% previously 🤦♂ but otherwise this is good. I updated the testing instructions above.

You flew too close to the :sun_with_face: @whikloj
I can give this a whirl then :+1:

@whikloj Both add and replace work out just fine.  JSONLD looks good:
[
   {
      "@id":"http:\/\/localhost:8080\/fcrepo\/rest\/47\/f9\/8e\/82\/47f98e82-6b49-49d9-9d5e-1574a12e6ab6",
      "@type":[
         "http:\/\/fedora.info\/definitions\/v4\/repository#Container",
         "http:\/\/pcdm.org\/models#File",
         "http:\/\/fedora.info\/definitions\/v4\/repository#Resource",
         "http:\/\/www.w3.org\/ns\/ldp#RDFSource",
         "http:\/\/www.w3.org\/ns\/ldp#Container"
      ],
      "http:\/\/fedora.info\/definitions\/v4\/repository#lastModifiedBy":[
         {
            "@value":"bypassAdmin"
         }
      ],
      "http:\/\/schema.org\/dateModified":[
         {
            "@value":"2019-02-08T14:33:46+00:00",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"
         }
      ],
      "http:\/\/schema.org\/author":[
         {
            "@id":"http:\/\/localhost:8000\/user\/1?_format=jsonld"
         }
      ],
      "http:\/\/schema.org\/sameAs":[
         {
            "@value":"http:\/\/localhost:8000\/sites\/default\/files\/2019-02\/2-Service%20File.jpg"
         }
      ],
      "http:\/\/schema.org\/dateCreated":[
         {
            "@value":"2019-02-08T14:33:46+00:00",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"
         }
      ],
      "http:\/\/www.ebu.ch\/metadata\/ontologies\/ebucore\/ebucore#width":[
         {
            "@value":"1494",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#int"
         }
      ],
      "http:\/\/www.ebu.ch\/metadata\/ontologies\/ebucore\/ebucore#hasMimeType":[
         {
            "@value":"image\/jpeg"
         }
      ],
      "http:\/\/fedora.info\/definitions\/v4\/repository#createdBy":[
         {
            "@value":"bypassAdmin"
         }
      ],
      "http:\/\/fedora.info\/definitions\/v4\/repository#lastModified":[
         {
            "@value":"2019-02-08T14:33:49.092Z",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"
         }
      ],
      "http:\/\/fedora.info\/definitions\/v4\/repository#created":[
         {
            "@value":"2019-02-08T14:33:49.092Z",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#dateTime"
         }
      ],
      "http:\/\/www.ebu.ch\/metadata\/ontologies\/ebucore\/ebucore#height":[
         {
            "@value":"1074",
            "@type":"http:\/\/www.w3.org\/2001\/XMLSchema#int"
         }
      ],
      "http:\/\/www.w3.org\/1999\/02\/22-rdf-syntax-ns#label":[
         {
            "@value":"2-Service File.jpg",
            "@language":"en"
         }
      ],
      "http:\/\/pcdm.org\/models#fileOf":[
         {
            "@id":"http:\/\/localhost:8000\/node\/2?_format=jsonld"
         },
         {
            "@id":"http:\/\/localhost:8080\/fcrepo\/rest\/e5\/e2\/05\/1a\/e5e2051a-4df7-4dfb-bd5f-499089dea7b3"
         }
      ],
      "http:\/\/purl.org\/dc\/terms\/title":[
         {
            "@value":"2-Service File.jpg",
            "@language":"en"
         }
      ]
   }
]

But turtle is re-writing namespaces to ns01, ns02, etc...  Since it's the default return format, it'd be nice to sort that out.  EasyRDF is always a pain in the arse, but I'm guessing you could stash the namespaces from what you receive and re-use them when serializing out.  If that turns out to be an ordeal we can spool off another ticket, because what you have works just fine with jsonld.

@dannylamb could we put this in and then I'll work on the serialization issue after. Just to get this in and available.


Enhancement add FE config to prohibit create date and decimalv2 type

Proposed changes
Issue Number: close #xxx
Problem summary
FE config

disable_decimalv2, default is true.
disable_datev1, default is true.

Afterwards, Doris prohibits creating tables containing the DATE and DECIMAL type by default.
Because of intending to delete these types in the future. At this stage, If you need to use these types, you need to add disable_datev1 = false or disable_decimalv2 = false in the FE's config and restart the FE.
On regression pipeline, these parameters in FE config is set false.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.69 seconds
stream load tsv:          430 seconds loaded<PHONE_NUMBER>9 Bytes, about 165 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230426025952_clickbench_pr_135280.html

run buildall


add log table types

Fixes https://github.com/newrelic/terraform-provider-newrelic/issues/1831 .
See https://github.com/newrelic/terraform-provider-newrelic/pull/1832

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

this wasn't needed after all!


update contributing.md

taking an opinionated approach and provided documentation on how best to catch up forks with upstream master.

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   95.39%   95.39%
=======================================
  Files          28       28
  Lines         391      391
  Branches       36       36
=======================================
  Hits          373      373
  Misses         15       15
  Partials        3        3

Flag
Coverage Δ

#api
97.12% <ø> (ø)
:arrow_up:

#ui
94% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e1799...0294008. Read the comment docs.


Code Quality: Fixed null warnings in MainPage.xaml.cs

Resolved / Related Issues

[ ] Were these changes approved in an issue or discussion with the project maintainers? -sort of
Addresses #9895

Fixed some NRT warnings in MainPage.xaml.cs while working on #14144
Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots (optional)
Add screenshots here.

Fixed the styling issues, thanks for feedback!

It failed again on the tests with this message:
"Windows Application Driver listening for requests at: http://<IP_ADDRESS>:4723/
Address 'http://<IP_ADDRESS>:4723/' is already in use
Failed to initialize: 0x80004005"
Is it an issue with the CI pipeline?

Did you launched with this branch on your end?

Should be all good now, made a mistake with one of the fixes. Compiler thought it was null-safe, but, well, it wasn't. I instead made the field nullable since it was being assigned null already


preserve order of JSONPath elements (when using wildcard)

Hello Mr Ohler!
first i would like to thank you for your amazing work on this parser, my team is very surprised with all the advantages we got by adopting this lib!
I would like to comment that we observed a point in the code where the order of the elements (in an array) is not being preserved, but I cannot say whether this behavior is correct or unexpected.
I saw that a few days ago you published a new release (v1.17.3) with a similar fix, but correcting the Filter, so I thought it was worth opening a ticket to comment on the same problem in Wildcard.
The section that seems unexpected to me is in file jp/get.go, on line 206 (tag v1.17.3). There, the x.reflectGetWild(tv) function is called and returns an inverted list of elements (inside it there is a comment saying that this is the desired behavior). It seems to me that that function is correct, it just needs to change the direction that the loop of the 206 line is traversed, in a similar way to the fix made in the Filter case.
Does what I'm proposing make sense?

Items are placed on the stack in reverse order because they are popped in reverse order from how they are pushed. That being said, if the order is not correct it should be fixed so I'll take a look at it tonight.

Thanks for the quick response and attention!
The code below (or on the playground) demonstrates my question in a practical way:
package main

import (
	"fmt"

	"github.com/ohler55/ojg/jp"
)

type Root struct {
	Elements []Element
}

type Element struct {
	Value string
}

func main() {
	data := Root{
		Elements: []Element{
			{Value: "el_1"},
			{Value: "el_2"},
			{Value: "el_3"},
		},
	}

	fmt.Println("Original data:")
	for i, el := range data.Elements {
		fmt.Println("index:", i, "value:", el.Value)
	}

	path, _ := jp.ParseString("$.elements[*]")
	var reversed = path.Get(data)

	fmt.Println("Reversed data:")
	for i, el := range reversed {
		fmt.Println("index:", i, "value:", el.(Element).Value)
	}
}

Here is the console output:
Original data:
index: 0 value: el_1
index: 1 value: el_2
index: 2 value: el_3
Reversed data:
index: 0 value: el_3
index: 1 value: el_2
index: 2 value: el_1

Thanks for the test case.

Please try the wild-reflect-order branch.

It worked perfectly in the real scenarios I have with me, both with slices of structs and pointers! ✅🟢
(I think) it's valid to promote this branch in a new release 🚀
I would like to thank you very much for the speed with which you resolved the issue.
Thanks so much for sharing your knowledge and time with the community.
I leave here my sincere feeling of gratitude!

Released v1.17.4!


Generalize test results service

For #4796

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
~[ ] Has sufficient logging.~
~[ ] Has telemetry for enhancements.~
~[ ] Unit tests & system/integration tests are added/updated~
~[ ] Test plan is updated as appropriate~
~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)~
~[ ] The wiki is updated with any design decisions/details.~

No tests have been updated, please update or add tests

This is already an unplanned voluntary work. Will add tests when there is no other work to done.


SVR not running on windows 10

Hi Akondas, am having trouble running SVR SVC. Even the basic prediction does not work. With error as shown in the image. After downloading php-ml via composer, KNearestNeighbor works fine but SVC is not working
<?php require_once __DIR__ . '/vendor/autoload.php'; use Phpml\Classification\SVC; use Phpml\SupportVectorMachine\Kernel; $samples = [[1, 3], [1, 4], [2, 4], [3, 1], [4, 1], [4, 2]]; $labels = ['a', 'a', 'a', 'b', 'b', 'b']; $classifier = new SVC(Kernel::LINEAR, $cost = 1000); $classifier->train($samples, $labels); echo $classifier->predict([3, 2]); ?>

Am currently using windows 10 with Xampp server installed. I have tried checking on dev-master but it does not seem to work too... If you can create a single file for me i would appreciate. Am currently running a project based on phpml and SVR is so important for me. Am unable to proceed with my project without it working

dev-master does not come with php-ai folder which has the phpml files
so something like "use Phpml\Classification\SVC;" wont work.
See below image for dev-master i installed using composer

Please copy and paste the error it is too small.


⚠ Bofrost.de has degraded performance

In 7bda13b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1487 ms

Resolved: Bofrost.de performance has improved in f353d0a.


Apps: allow no data toggle with computed variables?

Consider ranked abundance scatter

Does it make sense to have the no data toggle here? We could possibly end up with a "No data" group for the computed var, which is sort of odd since we're in the app in order to see the outputs of the computation.
@dpbisme and @d-callan what do you think?

We could have a rule that any viz with a computed var won't have the no data toggle. That's maybe aggressive because sometimes the computed var is a strata var but other times is an axis var, but as a rule is not too complicated

Note in plot.data we have a rule that we can't have the no data toggle on and have a collection var. We'll need to replicate this rule at least in web-eda to prevent users getting lots of errors

@asizemore @moontrip can we move this out of "this cycle" as it has a milestone of b59 and we are in crunch time for b58? thanks!

The work for this is already done, it's just in final review. It'll be simpler and faster to just approve/merge the PR then to try to hold off and have to maintain the branch. I'll finish the review today so it'll be ready for @moontrip on Monday.

Assigning to @dpbisme for qa


Getting NaN loss values while training PatchCore model on custom dataset

Describe the bug

I am training the patchcore model on a custom dataset. During training, loss value in the progress bar is shown as NaN. Why would this happen?

Screenshots
Epoch 0:   2%|█▋              Aggregating the embedding extracted from the training set.5/218 [00:06<04:30,  1.27s/it, loss=nan]
Creating CoreSet Sampler via k-Center Greedy
Getting the coreset from the main embedding.
Assigning the coreset as the memory bank.
Epoch 1:   2%|███▏            Aggregating the embedding extracted from the training set.                                                                | 5/218 [01:34<1:07:23, 18.98s/it, loss=nan]
Creating CoreSet Sampler via k-Center Greedy
Getting the coreset from the main embedding.
Assigning the coreset as the memory bank.
Epoch 2:   2%|███▏            Aggregating the embedding extracted from the training set.                                                                | 5/218 [06:39<4:43:55, 79.98s/it, loss=nan]

This is because you do not update any weights during the "training" of patchcore but only save features while inferencing your training data (https://arxiv.org/pdf/2106.08265.pdf). Doing this for multiple epochs will not improve the model unless you apply random image augmentations in each epoch (which is why the default number of training epochs is 1 and you shouldn't change this parameter unless for any obvious reasons)

@RahaviSelvarajan, as @alexriedel1 pointed out, the reason is because the CNN is only used for feature extraction, which doesn't produce a loss value. If this looks confusing, we could consider removing it.

@samet-akcay so in this situation. Train 1 epoch is the same result compared to multiple epochs?

@nguyenanhtuan1008, yes. Training single vs multiple epoch would yield the same result for all models that use CNN for feature extraction.

hi regarding this, how to do augmentation in patchcore. Seems like patchcore need heavy augmentation right?


Add EntityType on CaptureLog

Hi everyone!
Any idea to get this?

What do you mean? Your capture log is defined in your entity class. You decorate the class declaration with the [CaptureLog(typeof(MyEntityCaptureLogRow))]. You have to create a migration to create the capture log tables fields that you want captured. Thus, your EntityType is in the name of the capture log table.

Thanks for the answer and your colaboration jsbUSMC.....
In my app, i have some tables with the same structure (Id, Name) and i want make only one class CaptureLog to all this, i need some way to differentiate every one of the registers and i suppose this is the way... if any one have other idea please let me know

You need to write your own capture log for this, copy, paste, modify


Add StateSender, StateListener mixins

A StateSender would just override the emit method and after super.emit it'd call send function.
This is currently achieved by overriding emit manually and adding mixin Sender<SomeState>:
@override
  void emit(SomeState state) {
    super.emit(state);
    send(state);
  }

There should also be a specific mixin for listening to state changes of some bloc.
This is currently achieved by mixing in Listener<SomeState> and using onMessage for states


Highlighting for PHP breaks when using a namespaced trait

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:22:50.650Z)
OS Version: Darwin x64 16.6.0
Extensions: N/A

Steps to Reproduce:

Open/Create PHP file with content as follows:

<?php

class ExampleClass {
     // Referencing a trait without namespace works as expected:
    use ExampleTrait;
    $foo = "SUCCESS: This line will highlight properly.";

    // Referencing a trait with a namespace will break highlighting:
    use ExampleNamespace\ExampleTrait;
    $bar = "ERROR: This line will NOT highlight properly.";

    /* Highlighting remains broken across multiple lines,
        and will color ignore things like keywords, comments or quotation marks.
        However, highlighting appears to reset the moment it scans a closing brace, as such: }

        Note that while highlighting has been reset, this line is still broken because VS code did not register the start of this comment block. */

    $baz = "SUCCESS: This line, and subsequent lines, will highlight properly again.";
}

Compare VS Code highlighting to Markdown highlighting as presented above. After referencing a namespaced trait, syntax highlighting remains broken until the first brace, even if additional content is inserted before or after the $bar.

The issue might be caused by highlighting rules set up for the "use" keyword for importing/aliases or the "use" keyword for delegates, which are two different syntaxes.
Reproduces without extensions: Yes

This should be fixed in the Insiders build, try it out there if you get a chance. #30448


FEATURE make cookies optional

Is your feature request related to a problem? Please describe.
Some violators or popups may need to stay visible after the first load.
Describe the solution you'd like
Possibly just adding a checkbox to PopUps and Violators to allow turning cookies off for each individual instance. Default would be on.

@korthjp17 if this is still valid let's revisit in the next week or two.

I don't know if we have run into a good use-case for this, but I could see it as a nice feature. Open to thoughts though??


[CL4 port | Latest] Moderation audit log

Is your feature request related to a problem? Please describe.
Yes, recently there has been a number of inappropriate inbox messages sent to certain users by moderators. Under the current system, it is impossible to know who these moderators were.
Describe the solution you'd like
An audit log detailing all moderator actions, including information such as the time of the action and the moderator responsible, as well as details of the action itself.
Describe alternatives you've considered
N/A
Additional context
N/A

Agreed. Only MeowyMod has an audit log, having native support would be beneficial.

Easy to add to current server Too

Easy to add to current server Too

Oh yeah definitely.

This is the reason why I started CL3 rewritten, to add an audit log lmao.
The branch was originally named "tnix-audit-log".
Anyway, audit log is implemented in cl3 rewritten which will hopefully be released soon.

This now exists in 1.8 server.


Add some benchmarks

I'd love to see some benchmarks against other template engines. I don't want to claim that Maud is fast without hard data.
Ideally we'd focus on real-world use cases, such as the docs.rs front page. In this case docs.rs uses Handlebars already, so that's half of the work done.

I've done some preliminary benchmarks.
Also, according to cloc:

Maud is 708 SLoC
Handlebars is 2411 SLoC

db64a576569d47a8d04a7fcf5b3287058cd0be5a

Both are measured without tests -- I removed all items marked #[cfg(test)] and #[test] from Handlebars before running the line count.

I've published the benchmark code as 30e1071c05067a7ce7133e84a52efa580cbacc57, but as mentioned above they can be improved.

Closed in favor of #49


test: autouse app_context in unit tests

SUMMARY
I have yet to see a test case where having an app_context is troublesome. Since it's fairly cheap to create a new context, we can just autouse the app_context fixture to save some boilerplate code.
Doing this for integration tests may have more complications. Will try it in another PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@john-bodley I didn't find any more imports of AppContext in unit_tests so merged the PR as is. Will do another sweep to see if autouse AppContext is possible on integration tests in another PR.


feat(cli): add walkthrough for adding a device location tracking resource

Description of changes

Add CLI walkthrough for adding a device location tracking resource
Does not include advanced workflow for now (plan to put in a separate pr to limit the scope of this pr)
Update/Delete workflow will also have separate PR's to limit the scope of the change
Doc: https://quip-amazon.com/gTQSApaTCoew/Amplify-Geo-CLI-Devices-and-Trackers-2022

Issue #, if available

Description of how you validated changes
Locally build with yarn setup-dev and run amplify-dev add geo to test walkthrough for adding a device location tracking resource.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added (and PR referenced)
[x] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[x] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11274 (b45eb2b) into category-geo/device-location-tracking (3939d41) will increase coverage by 0.11%.
The diff coverage is 67.63%.

@@                            Coverage Diff                            @@
##           category-geo/device-location-tracking   #11274      +/-   ##
=========================================================================
+ Coverage                                  49.60%   49.71%   +0.11%
=========================================================================
  Files                                        683      689       +6
  Lines                                      32840    33042     +202
  Branches                                    6700     6723      +23
=========================================================================
+ Hits                                       16290    16428     +138
- Misses                                     15070    15131      +61
- Partials                                    1480     1483       +3

Impacted Files
Coverage Δ

...ages/amplify-category-geo/src/supportedServices.ts
100.00% <ø> (ø)

.../src/service-utils/deviceLocationTrackingParams.ts
30.76% <30.76%> (ø)

...o/src/service-utils/deviceLocationTrackingUtils.ts
31.57% <31.57%> (ø)

...src/provider-controllers/deviceLocationTracking.ts
42.10% <42.10%> (ø)

...ify-category-geo/src/provider-controllers/index.ts
25.45% <60.00%> (+0.45%)
:arrow_up:

...-walkthroughs/deviceLocationTrackingWalkthrough.ts
93.87% <93.87%> (ø)

.../src/service-stacks/deviceLocationTrackingStack.ts
94.82% <94.82%> (ø)

...mplify-category-geo/src/service-utils/constants.ts
100.00% <100.00%> (ø)

...c/service-utils/deviceLocationTrackingConstants.ts
100.00% <100.00%> (ø)

...fy-category-geo/src/service-utils/resourceUtils.ts
60.21% <100.00%> (ø)

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Discussed with @sobolk will do the CDKv2 branch separately once we have the create, read, and update flows pushed to the staging branch. Already updated this PR to include the e2e tests so should be good to review


(PDB-2159) Augment the command processed message

... so we can do better cache invalidation by observing response-mult.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/340/
Test PASSed.

:+1:


(AzureCXP) fix for the permissions description

(AzureCXP) fix for the permissions parameters description
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@navba-MSFT, CI is still failing due to trailing whitespace.  I cannot approve until CI is passing.

@seanmcc-msft Removed the whitespaces. Please review this and approve once you get a chance and merge it with the main branch.


Reapp new Error: Command failed: Too many arguments.

Running 'reapp new ...' I got this from the terminal:
$ reapp new myapp
Creating new reapp folder for: myapp...
Running git clone --depth=1 https://github.com/reapp/starter-default /my-app-path...

 Error
{ [Error: Command failed: Too many arguments.

usage: git clone [options] [--] <repo>
....
] killed: false, code: 129, signal: null }

Resolved with new version of reapp.
Do:
npm uninstall -g reapp
npm install -g reapp
reapp new test-reapp
cd test-reapp
reapp run


Fail to send several alerts triggered at the same time

A clear and concise description of what the bug is.
How to reproduce the bug

Go to 'Alerts and reports'.
Set two or more slack alerts with the same time and make sure they will be triggered at the same time.

Expected results
All of the screenshots should be sent, but only one is sent.
Actual results
One screenshot is taken and sent, another fails.
Screenshots
If applicable, add screenshots to help explain your problem.
[2023-04-21 02:07:00,177: INFO/ForkPoolWorker-16] Init selenium driver
Init selenium driver
[2023-04-21 02:07:00,183: INFO/ForkPoolWorker-1] Init selenium driver
[2023-04-21 02:07:01,324: INFO/ForkPoolWorker-1] Task reports.execute[32f9e0dd-9773-4f77-b2b7-e05f5cdb8066] succeeded in 1.2880826219916344s: None
Taking a PNG screenshot of url http://superset:8088/explore/?form_data=%7B%22slice_id%22%3A%2015%7D&force=true&standalone=true as user admin
[2023-04-21 02:07:11,077: INFO/ForkPoolWorker-16] Taking a PNG screenshot of url http://superset:8088/explore/?form_data=%7B%22slice_id%22%3A%2015%7D&force=true&standalone=true as user admin
Report sent to slack
[2023-04-21 02:07:13,268: INFO/ForkPoolWorker-16] Report sent to slack

Environment
(please complete the following information):

browser type and version: not related to browser
superset version: 2.1.0
python version: 3.8.16
node.js version: node -v(unable to get it)
google-chrome version: Google Chrome 112.0.5615.165
ChromeDriver 112.0.5615.49 (bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936})
any feature flags active:

WEBDRIVER_TYPE = 'chrome'
WEBDRIVER_OPTION_ARGS = [
    "--no-sandbox",
    "--force-device-scale-factor=2.0",
    "--high-dpi-support=2.0",
    "--headless",
    "--disable-gpu",
    "--disable-setuid-sandbox",
    "--disable-extensions",
    "--disable-dev-shm-usage",
    "--remote-debugging-port=9222"
]

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Sometimes the error is different:
Failed taking a screenshot Message: disconnected: not connected to DevTools (failed to check if window was closed: disconnected: not connected to DevTools) (Session info: headless chrome=112.0.5615.49)

I'm not sure if this is still an issue in current versions of Superset (3.x). If it is, we can re-open this, or feel free to open a new issue with updated context and a reproducible case using example data. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale.


NPC Drop Tables

Add ability to set the drop table for any NPC.

Issue already exists https://github.com/Tomm0017/rsmod/issues/8


CLI[Setup]: Init command should setup helm repository

During init we need to do the following:

setup helm repository for FST charts
update helm chart dependencies

https://hashgraph.github.io/full-stack-testing/charts/index.yaml

:tada: This issue has been resolved in version 0.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bounty Board + Bounty Card

https://github.com/Bebop-Bounty/bebop-bounty/blob/77e95a3dd7304a11bd01065980c962eee03cb003/client/src/components/BountyPage/BountyBoard.jsx#L9
The Bounty Card is currently pass the full Context.
Don't we want to parse Context and call .map() on an array of bounties to pass bounty data to Bounty Card one-at-a-time?
Asking because I need to import the Bounty Card component to use.

yes, i will be updating this once we have a context. i didn't want to map over an empty array in the meantime... thanks for asking!


Build failed while building test cases

Describe the bug
Build failed while building test cases in SwifterSwift.xcodeproj.
The error message as follows.
Cycle inside SwifterSwift-iOS; building could produce unreliable results. This usually can be resolved by moving the target's Headers build phase before Compile Sources.
Cycle details:
→ Target 'SwifterSwift-iOS' has link command with output '/Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/SwifterSwift'
○ Target 'SwifterSwift-iOS' has compile command for Swift source files
○ Target 'SwifterSwift-iOS' has copy command from '/Users/shiva/Project/github/SwifterSwift/Sources/SwifterSwift.h' to '/Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/Headers/SwifterSwift.h'

Raw dependency cycle trace:

target:  ->

node: <all> ->

command: <all> ->

node: /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/SwifterSwift ->

command: target-SwifterSwift-iOS-51965990a9a124c29bb3ed953766efc7c183dc8690a59c97a584fdbb969f8966-:Debug:Ld /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/SwifterSwift normal ->

CYCLE POINT ->

node: /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Intermediates.noindex/SwifterSwift.build/Debug-iphonesimulator/SwifterSwift-iOS.build/Objects-normal/x86_64/CLVisitExtensions.o ->

command: target-SwifterSwift-iOS-51965990a9a124c29bb3ed953766efc7c183dc8690a59c97a584fdbb969f8966-:Debug:CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler ->

node: /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/Headers/SwifterSwift.h ->

command: target-SwifterSwift-iOS-51965990a9a124c29bb3ed953766efc7c183dc8690a59c97a584fdbb969f8966-:Debug:CpHeader /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Products/Debug-iphonesimulator/SwifterSwift.framework/Headers/SwifterSwift.h /Users/shiva/Project/github/SwifterSwift/Sources/SwifterSwift.h ->

node: <target-SwifterSwift-iOS-51965990a9a124c29bb3ed953766efc7c183dc8690a59c97a584fdbb969f8966--phase0-compile-sources> ->

command: Gate target-SwifterSwift-iOS-51965990a9a124c29bb3ed953766efc7c183dc8690a59c97a584fdbb969f8966--phase0-compile-sources ->

node: /Users/shiva/Library/Developer/Xcode/DerivedData/SwifterSwift-cmkdweqpyruimtdfgbapvcolopgt/Build/Intermediates.noindex/SwifterSwift.build/Debug-iphonesimulator/SwifterSwift-iOS.build/Objects-normal/x86_64/CLVisitExtensions.o

To Reproduce
Steps to reproduce the behavior:

Go to any test cases files.
Run any test case.
See error

Expected behavior
The build should success and run the test cases.
Screenshots

Desktop (please complete the following information):

OS: macOS
Version 12.5.1
Xcode: 13.4.1 (13F100)

Additional context
I followed the suggestion to rearrange the build phase as follows:
original:

modified:

and the problem solved. If this modification makes no harm, I'll create a PR for this.

[x] I've read, understood, and done my best to follow the Contributing guidelines before opening this issue.

I tried it again with
Xcode 14.0 (14A309) on macOS 12.6
and it works without any modification now.
So I'm going to close this issue. If anyone encounter the same issue, feel free to reopen this issue.


Error: using deprecated function

While trying to run the picker I got the following error.
E5108: Error executing lua ...cker/start/telescope.nvim/lua/telescope/actions/init.lua:26: `goto_file_selection_edit` is removed and no l
onger usable. Use `require('telescope.actions').select_` instead. Take a look at developers.md for more Information.

which picker is this? I thought these kind of issues had been fixed


Feature/addwebhook netatmo

Remove netatmo module
Import axios module
Import express module
Import qs module
Create Netatmo class

@sylvainnicolet  I would reduce the indentation to 2 spaces and, more generally, would be good to integrate https://eslint.org/ into the project so that CS and linting is automatically taken care.

It would be nice to add the command to run the app in the README.md file


Node-Red example

Hi!
My coding skills are terrible, but I'm getting there, slowly. I was wondering if someone can help me make this API into a node in Node-Red, for use in my home automation system. Anyone out there use node-red?

Hi,
@samuelcardillo is the one ported the code into Node.JS he might help you.
anything regarding python - comes to me :)
Samuel, do you think you could give the guy hand in this one?

Hey, the Node module is already written and ready to use. The commented section on the top is displaying an example of how to use. Nonetheless, I will commit few updates to it as soon as I can to fix few issues I have noticed.