Placeholders not showing up in structure mode sidebar

Summary
Static placeholders and placeholders attached to a model via a PlaceholderField and rendered using render_placeholder stopped showing up in the structure mode sidebar after upgrading to v3.5. Placeholders on regular cms pages still work as expected.
This issue only manifests on url endpoints which have a page node attached, but are served by a view other than cms.views.details. After some investigation it turns out that this is because the toolbar wrongly selects the ContentRenderer instead of the LegacyRenderer in such cases. It does so on the assumption (in BaseToolbar.uses_legacy_structure_mode) that a truthy value of the request.current_page attribute signals that the current request is being serviced by the built-in cms.views.details view, which supports the non-legacy structure mode.
We managed to work around the issue by replacing the CurrentPageMiddleware with a middleware that sets request.current_page = None instead as some of the built-in cms toolbars rely on the attribute being present when they're being populated.
Expected behaviour
Placeholders available for editing are shown in the sidebar.
Actual behaviour
The structure mode sidebar is empty even though there are placeholders in the template being rendered.
Environment

Python version: 3.5.6
Django version: 1.11.16
django CMS version: 3.5.3

Is this issue fixed in 3.6.0?

As discussed in this threadI fixed this issue by setting my request.current_page=None for that view.

I have a similar/likely related issue on urls that have both a cms page and an application view mounted (not via apphook). This used to work fine but now seems to result in static_placeholders located in the application template not rendering in the structure sidebar. If I remove the cms page, they reappear.

Is this issue fixed in 3.6.0?

Nope! sadly they haven't fixed it though its a long overdue fix. Still using version 3.4.6 meself.

I've used normal placeholders to elegantly fill some of my aplications texts, for example confirmation pages that can have images, galleries, whatever, in their own placeholder. All these placeholders seem gone in 3.5+ :|. I know they are still there, but not showing ;-) BUT: I always considered this some kind of hack, and I am not that surprised it suddenly stopped working?!
To be clear: Placeholders are show when on the "root" url of my apphook, but not on any sub views, like /confirmed/, or anything else.

I can report that this still happening with django-cms==3.7.1 and django==1.11.29. No render_placeholder placeholders in the sidebar on app hook sub pages.

Not working for me using the following versions:
Django==2.2.11
django-cms==3.7.1
Python 3.7.3

I did manage to work around this by setting the CMS_PLACEHOLDER_CONF and using a default text plugin with some dummy text. This allowed me to edit the plugin by double click-ing on it.
What is strange is that other static placeholders, from the home page do show up in the structure toolbar ...

Same issue here. Any word on a workaround/fix?

I have to add, I don't know if this makes any difference is that the page where my static placeholders don't show up are provided by a custom module that is integrated withing django-cms with an apphook.

I have to add, I don't know if this makes any difference is that the page where my static placeholders don't show up are provided by a custom module that is integrated withing django-cms with an apphook.

Standard Django CMS default page here!

Adding PlaceholderAdminMixin to the ModelAdmin an re-save the dynamic object with the PlaceholderField solves the problem for me. After reading better it is all there in the docs: http://docs.django-cms.org/en/latest/how_to/placeholders.html?highlight=PlaceholderAdminMixin

TLDR
Static placeholders within the template used by the show_menu template tag do not appear within the structure mode sidebar.
Explanation
I also noticed that some StaticPlaceholders, not all, do not appear within the structure mode sidebar.
After digging through some code I found the cause: The static placeholder which wasn't rendered in the structure mode sidebar was part of the template used by the ShowMenu template tag.
The function _scan_placeholders which is called by _scan_static_placeholders to find all StaticPlaceholderNode instances. The code within _scan_placeholders simply cannot cope with the ShowMenu node.
I was thinking, that the ShowMenu node or show_menu tag should be analyzed in the same way as include nodes.
However, the ShowMenu node itself has a property called child_nodelists which is empty. Therefore _scan_placeholders assumes there is nothing to be found.
Not sure if this covers all the other cases described here - I can imagine that some other template tags may cause the same behavior.
Temporary solution
Since, in my case, there are very few plugins to be rendered within the faulty static placeholder I added it within a hidden div to my template. This is it is shown within the structure mode sidebar again.
<div class="hidden">
    {% static_placeholder 'my_placeholder' %}
</div>

the issue appear with me today :(
totally headache, I'm trying from hours, because I was assume its from my code, but it seems like a bug !
I'm using django cms 3.11

I don't know if it's caused by the same issue, but the static placeholders are also not being shown in a brand-new django-cms 4.1.0 project.

@adlh Static placeholders are replaced by aliases in django CMS 4. They have their own editing endpoint from django CMS 4 on.


Tried out new file-watcher with flow server and it does not work, expects query string?

$ OCAMLRUNPARAM='b' ./node_modules/.bin/flow server --file-watcher watchman
Jul  7 10:28:58.582 [info] argv=/Users/qz1llg/Repos/golden_leaf/node_modules/flow-bin/flow-osx-v0.76.0/flow server --file-watcher watchman
Jul  7 10:28:58.582 [info] Creating a new Flow server
[2018-07-07 10:28:58.599] Watchman init: Watchman_sig.Types.Watchman_error("failed to parse query: must use [\"suffix\", \"suffixstring\"]")
Raised at file "map.ml", line 130, characters 10-25
Called from file "src/core/lwt.ml", line 817, characters 20-60
Uncaught async exception: Failure("Failed to initialize watchman")
Raised at file "map.ml", line 130, characters 10-25
Called from file "src/core/lwt.ml", line 817, characters 20-60

$ watchman --version                                                                                ✘ 110
4.9.0

Flow 0.78.0
Windows x64 Enterprise
Same issue
yarn run flow server --file-watcher watchman
yarn run v1.7.0
$ flow server --file-watcher watchman
Aug  6 12:00:56.245 [info] argv=O:\Projects\***\node_modules\flow-bin\flow-win64-v0.78.0\flow.exe server --file-watcher watchman
[2018-08-06 12:00:56.245] Watchman init: Unix.Unix_error(Unix.ENOENT, "CreateProcess", "")
Raised by primitive operation at file "src/unix/lwt_process.ml", line 106, characters 4-121
Called from file "src/unix/lwt_process.ml", line 285, characters 4-71
Called from file "src/unix/lwt_process.ml" (inlined), line 345, characters 2-49
Called from file "hack/watchman/watchman_lwt.ml", line 40, characters 18-113
Called from file "hack/watchman/watchman_lwt.ml", line 54, characters 23-43
Called from file "hack/watchman/watchman.ml", line 459, characters 4-73
Called from file "src/core/lwt.ml", line 2046, characters 16-20
Uncaught async exception: Failure("Failed to initialize watchman")
Raised at file "src/common/lwt/lwtLoop.ml", line 51, characters 9-68

Aug  6 12:00:56.245 [info] Creating a new Flow server
error Command failed with exit code 110.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

O:\Projects\***>watchman --version
4.9.4

I ran into the same issue, got it fixed by building watchman from HEAD.


Recommendations

Hi @raw-lab @raw937
Thanks for your previous answer regarding the difference between mercat and mercat2.  I was wondering if you have any recommendations on:

Number of input reads to use (I have illumina reads and I've tried downsample 100k, 1M, 5M...etc)
kmer length (I've used k=21, which depending on input can impact speed of running)
I was thinking of using mercat2 to quickly calculate the shannon/simpsons index as a way to compare diversity between samples (running mercat individually on each sample).  I was wondering if that can be used that way, as a way to compare between samples.

thanks again for your help!
Will

Hello Will,
We have removed the diversity estimation in mercat2 currently. We are working to improve the indexing so we can get a better species count with unique kmers.
If you run mercat2 you can compare and run many samples at once an build a global comparison. Also, this will plot a PCA for you at the end. You can use all your reads this way. You don't have to downsample. Let us know if you lacking in cpu power we can help.
What question are you asking?
If it's just differences between samples?

Thanks @raw-lab,
I just want to see if I can estimate diversity on reads between samples before actually trying to assemble them.  Practically I want some relative metric so I can have a heads up before running more downstream analysis, and also how much compute I need to allocate.
thanks again for your help.

We have the new version MerCat2 if you would like.


COMP: Set CMAKE_INSTALL_LIBDIR in ITKModuleExternal.cmake

Closes #3556

I suggest to close this pull-request and instead consider integrating #3722 that extended documentation.

Closing in favor of #3722


bug: netlify sites:create --json output is blank

- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
netlify sites:create --name foo -a bar --json

Produces an empty output.
- If the current behavior is a bug, please provide the steps to reproduce.
netlify sites:create --name foo -a bar --json

- What is the expected behavior?
Output is a valid JSON with information about newly created site.
- Please mention your node.js, and operating system version.
❯ node -v
v10.15.3

Thanks for the report. We need to add this.logJson(site) here https://github.com/netlify/cli/blob/master/src/commands/sites/create.js#L154 to support the json output of the site data


Find how to 'apt-get update' of a specific debian package

If backend is provided from a debian repo, let's update apt cache only for a specific debian repo.
from https://github.com/Samsung/ONE-vscode/issues/569#issuecomment-1120736375

If the artifactory data is changed when user requests toolchain lists, how can we control this situation?

Maybe we can have setInterval() that keeps calling apt-get update one or twice per day while ONE-vscode is up and running.
However, some users may not call apt-get update so we may need to find out some way to call apt-get update for backend Debian repo.

The following command may work:
sudo apt-get update -o Dir::Etc::sourcelist=${SOURCELIST}" \
    -o Dir::Etc::sourceparts="-" -o APT::Get::List-Cleanup="0"

If a package needs latest version of other package (which should be updated with apt-get update), this command may fail.
Let's use apt-get update for now.


Adding a test helper for asserting errors and fixes

Enabling tests to be easily written to confirm that we are writing tests that are fixing properly.
Refs @mikesherov's recommendation in #1128
Should be useful for updating the rules in #1127
Needed for #1202

Coverage remained the same at 99.12% when pulling 0d20754741fff7b1854260b06ea1531dff94bf01 on TheSavior:feature/test-fix into d651a78819680c6e9adc1c1330da09fe14d0be3d on jscs-dev:master.

Coverage remained the same at 99.12% when pulling ee710e3520506a2f5f355ca1cc0f22be64a7e23c on TheSavior:feature/test-fix into d651a78819680c6e9adc1c1330da09fe14d0be3d on jscs-dev:master.

:clap: Thanks!

Let's merge it?

@zxqfox if you encounter a reviewed-once and you also agree, merge away!


E2: Add "Namer" functionality

There is somewhat "funny" tool I find in Wire, it is called "Namer" (in Tools category).
So, I thought why not allow E2 to use this functionality?
Perhaps I could add it myself. Does anyone care about it?
If so, I suggest to simply add an overload for the existing function setName(string) to accept an additional argument (number) to specify whether to set the standard E2 "name" or the component name instead (Namer functionality).

Initially, I thought to myself, well what's the purpose of adding this. But after thinking about it for a while, I guess it would be kinda nice to have a getter and setter for this.

Alright, I am on it.

But, I have a question here about implementation. I see there is no limit to how long Wire Namer can set component name. So, how about I limit it to 512 characters (and no new lines and such)? I think 512 is more than enough for component name.

WireName uses SetNWString, which going off what the wiki says is limited to 199 characters (wtf kind of number is that garry).

Alright, then we let the GMod handle the length.
What about special characters such as double-quote, new-line, etc?
From what I read in the Namer tool source code, there is literally no validation. However, it does something behind the scenes, CPanel builds a TextBox control which is single-line only, and also double-quotes are replaced with a single-quote. If it didn't do this, then the ConCommand code could be exploited.

Closing this because we now have the PR

@Divran Why do this?! The issue should not be closed until the PR is merged, and also GitHub would have automatically closed this issue because I have included Fixes #1365 in the PR title.
Learn how to GitHub, Divran.

@CaptainPRICE Is there actually a solid use-case for this, or is it a "just because" kind of thing?

@AbigailBuccaneer Actually it is both. There are solid use-cases for those functions, but it is also "just because" kind of thing..
I have mentioned it a few times already in #1366..

I've seen you mention that you could hypothetically implement a remote communication system between E2s (which is a hack, not a use case), and that the already existing setName(s) is useful for debugging (again, a hack, not a use case). If you have a solid use-case for this then I can't find it but I'm interested in hearing it. If it's a 'just because' thing then I think we should probably bring the discussion back to "will this add any real value to Wiremod" before we move onto discussing APIs and reviewing code.

@AbigailBuccaneer

implement a remote communication system between E2s

You understood it wrong, for that I do use data-signals (or global/shared table) - which is not a hack.
I implemented a "Bridge" communication system between E2 and client-side GLua, that's right. And is not a "hack", really. Improved Wire Debugger (and many other stuff) I have built upon it.
If someone else has solid use-case for this, please speak up. (@oldmud0 ?).
(Well, I could always push this as my first Wire E2 extension on the Workshop...)
But, consider this, @Divran said on discord that he is fine with #1366 PR (since I implemented his B option), and a number of my friends would appreciate those as well, and so would I. Look it also adds anti-spam system to the existing setName(string) E2 function; It increases the overall security in server networking.
It is fun, so why not? :female_detective:

Using the entity's name to transmit arbitrary data from server to client is a hack, sorry.
@Divran said in #1366:

I think I've changed my mind and option B is probably the better choice here. The question now is whether or not we should add this at all. Is it really necessary?

So I think it's disingenuous to say "he said he's fine with it since I implemented option B".

It is fun, so why not? :female_detective:

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." — Antoine de Saint-Exupéry

Using the entity's name to transmit arbitrary data from server to client is a hack, sorry.

... again repeating yourself.

Divran said in ...

Yeah, I read that (btw I said "in discord" didn't I).
And so now it is waiting for either TomyLobo or Divran to review it again. I don't know what's taking so much time for them to review it.

On discord I said something along the lines of "idk we'll see what the others think".
It's taking so long because this issue turned into a shitshow so I opted to ignore it.
My opinion is: Do we really need this? Probably not. Most of the time, people who use gates don't use E2, and people who use E2 don't use gates. The wire namer was created for gates, therefore it doesn't make much sense to add a link between E2 and namer, because nobody will ever use it.


Xbox One disconnects from test runner

The Xbox One in our lab disconnects from the test runner most of the time.  The rate of this occurring is not consistent, but I have not been able to get 5 successful test runs in a row on Xbox.  When the disconnect occurs, the device appears to briefly hang.  There is no log to indicate what test was running at the time because log delivery to the test runner is not synchronous.
Through trial and error disabling certain subsets of the tests and doing 5 test passes, I found that disabling streaming_engine_unit.js alone is enough to get the tests to complete successfully.  So the trigger is some or all of the tests in that file.

I found that excluding EMSG tests from streaming_engine_unit.js seems to make Xbox reliably complete the tests without disconnecting.  Stopping emsg parsing right before calling box.reader.readBytes() also seems to do this.
Sadly, the problem goes away when I add console logs to readBytes().  So it looks like this is not going to be a straightforward problem to solve.


Build fails for blog posts with multiple authors

First of all, thanks for the awesome plugin!
We installed the plugin for a while now, but a few days ago, our builds started failing. The respective blog post that fails the build contains a list of authors defined like this:
---
authors: [user1, user2]
---

When running yarn build the build fails with the following error:
[ERROR] TypeError: Cannot read properties of undefined (reading 'authorId')
    at ./node_modules/@stackql/docusaurus-plugin-structured-data/src/index.js:346:112

hey @shochdoerfer, fixed (or worked around) https://github.com/stackql/docusaurus-plugin-structured-data/commit/ac1ba9cd957b2aea67600f83ef45ba6a3fb661ef

wow, that was a quick fix ;) Will test later. Thanks a lot!

Thanks! Quick favour can you ⭐ our main repo https://github.com/stackql/stackql
From: Stephan Hochdörfer @.>
Sent: Friday, May 19, 2023 6:05 PM
To: stackql/docusaurus-plugin-structured-data @.>
Cc: Jeffrey Aven @.>; State change @.>
Subject: Re: [stackql/docusaurus-plugin-structured-data] Build fails for blog posts with multiple authors (Issue #1)
wow, that was a quick fix ;) Will test later. Thanks a lot!
—
Reply to this email directly, view it on GitHub https://github.com/stackql/docusaurus-plugin-structured-data/issues/1#issuecomment-1554199773 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHIPA7YMSMHUPF5PYHVXLDXG4SRLANCNFSM6AAAAAAYG3JX7I .
You are receiving this because you modified the open/close state.  https://github.com/notifications/beacon/ABHIPAZLVCQBI5OII25QDJLXG4SRLA5CNFSM6AAAAAAYG3JX7KWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS4UM2N2.gif Message ID: @.*** @.***> >


Simplify the build of the docs and implements automatic deployment

This PR simplifies the building of the docs, automatically creating the components library and downloading pandoc if required, and adds an automatic publication step whenever there is a new release.

Could you elaborate? Now is the time to fix any possible issues on this front.

Oops sorry I didn't see your message, and merged, and then reverted

It was a while ago - off the top of my head I can't remember, maybe the bullet point formatting seemed unreliable. Were you able to serve the documentation locally to make sure it was formatting properly?

I think if it was OK locally then that's fine


docs-bug(multiple): errors seems a better choice in templates instead of hasError()

Documentation Feedback
Apprently in the Angular documentation to validate forms they never use hasError() function source. But in material documentation it's used in some different places.
Even tho the performance gain will be small, I have the feeling we should have a documentation that should share code that follows the "best practices".
Affected documentation page
https://material.angular.io/components/input/overview#changing-when-error-messages-are-shown

Closing this based on the discussion in https://github.com/angular/components/pull/28884.


No support for aarch64

Hello, I'm working on porting open fold to a Grace Hopper machine (Arm / aarch64). When trying to install according to the instructions I get:
PackagesNotFoundError: The following packages are not available from current channels:

 - pytorch::pytorch-cuda==12.1
 - pytorch::pytorch==2.1
 - mkl=2022.1*
 - libgcc=7.2*

The purpose of this issue is to ask what the plans for support aarch64 are and how I can help. I'm working on a PR on a fork.
Is there any plans to support Arm? And would you prefer the conda or container approach?

I also need to port to arm to run on Grace Hopper! Did you ever have any luck with this? I'd be willing to help if you still have interest.


Add numeric ID generation

@Phystro  do you think you can try this one out. It is rather simple, all you need to do is add IdKind.Numeric and use the inbuilt CryptoUtility.Random method to generate a number.
for example, to generate a 5 digit number, you'd do this:
CryptoUtility.Random(10000, 99999).ToString(CultureInfo.InvariantCulture)

So now the trick is in determining the min and max values based on the input length

OK. Trying it out

Once you do open a PR and tag me I check it out.... Open a PR to the dev branch not main


Update app-bar-and-bounding-box.md - changed metadata

Changed metadata

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/app-bar-and-bounding-box.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[otbn,dv] Fix loop warping force

Resolves #14223
Signed-off-by: Canberk Topal<EMAIL_ADDRESS>

Thanks for fixing this!


Add iscsi checks only when ceph is not enabled

this should probably be checking against the following ( where the backends list contains ceph ), as it is possible to use ceph but not as a cinder backend,  it's also possible to use ceph + something else.
https://github.com/blueboxgroup/ursula/blob/master/roles/cinder-common/defaults/main.yml#L6-L9

Agreed with paul.

Addressed in PR #1387


Some examples use beta version.

svg-components, with-pretty-url-routing, with-shallow-routing,with-webpack-bundle-analyzer.

I think we should consistent all example. So that it can avoid error from different version.

I already sent a PAR for these examples to use the stable version


Is it possible to load Cash in "noconflict mode"

We develop a small JS widget that can be load on any website
Until now we use jQuery if it is already loaded by website, or we load our version with noconflict mode.
I'm very interested to embed cash directly in our widget, but can we load it in "noconflict mode" ?
jQuery = window.jQuery.noConflict(true);
If another JS library already defined $ can we load cash to use another name ?
Thanks !

If another JS library already defined $ can we load cash to use another name ?

Sure, there's no "noConflict" method provided though, so you'll have to do something like this:
const _prev$ = window.$;
// Load cash now...
const cash = window.$;
window.$ = _prev$;

Thanks !


Error in codius.conf prevents passing Self Test

In /etc/nginx/conf.d/codius.conf
Some proxy fields under "Location" are in an incorrect order. This is preventing the enabling of Websocket support and thus causing the host to fail self test.
The correct order should be:
location / {
proxy_pass http://<IP_ADDRESS>:3000;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $connection_upgrade;
proxy_buffering  off;
proxy_set_header Host $host;
proxy_set_header X-Forwarded-For $remote_addr;
This is described here:  https://medium.com/codius/codiusd-1-2-0-upgrading-and-websocket-support-42f712a0cee9 where it is stated that the order of the proxy fields matters. The bolded fields must come first.

Thanks Fixed


While running "detectnet /dev/video0" video does not display though dectectnet is working

When running "detectnet /dev/video0" it runs and seems is doing something because the terminal is constantly spitting out [TRT] information but there is not video like in your example. When I run "video-viewer /dev/video0" it sees the camera and opens the video just fine.
Is there some kind of setting that needs to be toggled to get the video to display when running "detectnet /dev/video0"? What might cause the video to not show while running detect even though it seems to be detecting using the camera?

Just let detectnet run for awhile (like 5 minutes) - the first time you load a model, TensorRT needs to profile the model and create the engine.  This engine is then cached to disk so the next time you load that model, it will load it just a couple seconds.

Worked like a charm!!! You rock Dusty!


params and states should be accessed via a "params" and "states" method

From @catmando on November 23, 2015 16:16
Currently if you declare a param or state it creates a instance method of the same name.
This can cause name conflicts with other methods, and also does not tell readers of the code what the special properities of the methods are.
So the suggestion is that we access states and properties via a method called states / params.  For example
defined_state :foo
required_param :bar
...
    state.foo # currently can just say foo
    param.bar # currently can just say bar
    # alternative syntax 1
    states.foo
    params.bar
    # alternative syntax 2
    state_foo
    param_bar
...

Questions for discussion:

should the method be singular or plural, or just create the method like state_foo, param_bar
should we deprecate the current capability?  Why / why not?

Copied from original issue: zetachang/react.rb#83

From @catmando on November 24, 2015 21:9
I think the problem is you talk about the state (singular) and the parameters (plural) of a component.  State is kind of like sheep or deer.  I could go with state/params

From @ajjahn on November 24, 2015 15:54

I like state.foo / param.bar. I'm not sure about singular or plural. I'm experiencing some cognitive dissonance here. I think singular state and plural params reads most natural, but having the inconsistency is clearly wrong.

Yes. We don't have to remove it right away, but I don't think we need to support both interfaces for the long term.

From @ajjahn on November 25, 2015 3:55
@catmando So sheeps.foo / deers.bar? Okay okay, enough tom foolery. That's a good point though. I'd be okay with state/params. The next question is should params be props?

From @Thermatix on November 25, 2015 16:47
I agree @ajjahn, they have different behavior so should be kept distinct; I also prefer it with the the . as it feels more natural in my head and less 'magical'.

From @catmando on November 25, 2015 4:28
yeah I don't know... I personally much prefer params (they just feel more like parameters than properties) but not sure how much confusion it makes.

params gives a nod to rails, and will be familar to people coming from that background

params is what it is today and works

params allows "props" to be for low level access to the actual react props hash (ugh)

params makes it harder for react.js people (but not a lot I think)

params is longer than props

From @ajjahn on November 25, 2015 15:52
I agree. Params are beefed up props. The fact that they have more behavior than the underlying react props justifies making a distinction. Plus, it allows direct access to low level props if you need.

From @fkchang on November 25, 2015 21:34
state/params looks good to me.  Would still keep [] access too?

From @catmando on November 25, 2015 20:15
FYI... this also solves a nagging problem that we can't easily call a param "params" which react-router wants to do.  Now that params are scoped by the params method, and params.params works fine.

From @catmando on November 26, 2015 3:38
I don;t think so


[AMBARI-23174] [branch-2.6] Add storm topology metric expressions for custom downsampling cnfig.

What changes were proposed in this pull request?
This is a minor config change that needs to be made for the work done in AMBARI-23008 to have storm metrics aggregated differently.
How was this patch tested?
Manually tested by Jungtaek Lim.

@HeartSaVioR Can you take a look at the metric expression?


create a logo

Context
Needs a logo
Description
The logo is based on the Genoese Lighthouse from Constanta
Acceptance Criteria
The logo is uploaded to the repo and the readme is updated with the proper details.

/triage
/assign


[Bug]: Any engine except newest one doesnt work

I can't use any engine except newest one:  for an example 127 & 128 give this error now and it was working just fine until 1-2 days ago
Couldnt parse JSON:
<title>403 Forbidden</title>

403 Forbidden

nginx/1.18.0 (Ubuntu)

SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at IncomingMessage.<anonymous> (C:\x\127\node_modules\bas-remote-node\src\services\utils.js:15:22)
    at IncomingMessage.emit (node:events:525:35)
    at endReadableNT (node:internal/streams/readable:1359:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@dr3adx hello, you can find info about this problem here.

The problem with the servers has been resolved at the moment, the scripts are available again, but I still recommend updating to the latest version so as not to depend on it.


Can/should we collect ALKiln metrics to help with development?

Should?
Metrics might be useful to track how often tests are catching errors. Also, if lots of different orgs' are failing, that might let us know something of ours is broken even if we don't have a test covering any one particular thing. It'd be more useful if it was more than one org, otherwise it could just be a problem with their server. We might be able to see who's making their own feature files instead of just using our default ones.
We'd need to request consent, maybe through an ALLOW_ALKILN_TO_COLLECT_METRICS secret or through more fine-grained control of what kind of info they'd let us collect.
Could?
Could we do this through our action.yml? It wouldn't be able to add something to our repo directly without some kind of token because the action acts as if it's in the dependent's repo. Some kind of PAT that we hard-code (and thus is public) and lets anyone push to a totally separate repo that stores just metrics?

Feedback is we won't do it for now, but may reconsider it in the future.


Iterators

Consider this.

Should support dereference operation. This can be done since value is always nearly from its managing structure (tree node, for example).
Should be intercompatible between different data structures.


README.md: Minor Mardown tweaks.

Doesn't make a lot of difference though! But thanks :)

Nice catch @XhmikosR!
json looks so much better now!


Update traffic-manager-manage-profiles.md

Typo isuse, change WWhen to When

Thanks, @herman5006!


[JavaScript][Adaptive Card][Height property In Input.Text element is not supporting]

Platform

JavaScript

Author or host
Rendering in Webex teams
Version of SDK
1.2.0
Details
According to the Adaptive Card Schema explorer when Input.Text has the inherited "height" attribute set to "stretch" the behavior should be "The container will stretch its height to the available remaining height of the parent container." Card designer is not showing the height property in ELEMENT PROPERTIES
JSON:
{
      "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
      "type": "AdaptiveCard",
      "version": "1.0",
      "body": [
        {
          "type": "TextBlock",
          "size": "Medium",
          "weight": "Bolder",
          "text": "Custom JSON Design Input",
          "horizontalAlignment": "Center"
        },
        {
          "type": "TextBlock",
          "text": "In addition to showing your our pre-built samples, I can submit your custom design for you.  This helps to see how it will render or to see what type of payload your app will need to process if a user hits an Action.Submit button.",
          "wrap": true
        },
        {
          "type": "TextBlock",
          "text": "One way to get design JSON to paste here is to use the \"Copy Card JSON\" button from the [Buttons and Cards Designer](https://developer.webex.com/buttons-and-cards-designer) "
        },
        {
          "type": "Container",
          "items": [
            {
              "type": "Input.Text",
              "placeholder": "Paste card JSON here",
              "id": "cardJson",
              "isMultiline": true,
              "height": "stretch",
              "maxLength": 8000
            }
          ],
          "minHeight": "266px"
        }
      ],
      "actions": [
        {
          "type": "Action.Submit",
          "title": "Display My Card",
          "data": {
            "cardType": "customJsonInput",
            "nextAction": "submitJson"
          }
        },
        {
          "type": "Action.Submit",
          "title": "Go Back To The Built In Samples",
          "data": {
            "cardType": "customJsonInput",
            "nextAction": "samplePicker"
          }
        }
      ]
    }

Expected Output:

Actual Output:

Card Designer:

@dclaux thoughts for this one real quick? Also @paulcam206 since he's been toying with the designer as well as FYI.

@dclaux this is one of the Cisco integration bugs they reported.. thoughts?

As discussed last week, this kind of is a feature request. All inputs cannot honor the height property when set to "stretch". Basically, only Input.Text with isMultiline = true can - but it currently doesn't, by design. So we just need to make a collective decision whether or not we want to change that across all renderers (assuming non-JS renderers have the same behavior as the JS renderer). Aside from that the change (in JS at least) is trivial.

We agree that multiline Input.Text should stretch in this case.

We agree that multiline Input.Text should stretch in this case.


Safari(Windows) strange behaviour on delete

When you remove symbols from mask - it doesn't shifts back, but leaves empty space.
This bug can be reproduced only on Windows Safari.

@kenaku ,
Is this on the latest version of Safari on Windows?  Does this also appear on OSX?

Yes, latest version.
No, Safari on OSX works just fine.

@kenaku ,
I tested the demo page with Safari 5.1.7 on Windows 8 and it seem to work fine.
Can you provide more info.  Mask used?  Maybe a jsfiddle?


Failed to activate the termination package

dump:
Atom Version: 1.12.4
Electron Version: 1.3.9
System: Mac OS X 10.12.1
Thrown From: termination package, v0.3.3
Stack Trace
Failed to activate the termination package
At Failed to execute 'registerElement' on 'Document': Registration failed for type 'pio-terminal-status-icon'. A type with that name is already registered.

Error: Failed to execute 'registerElement' on 'Document': Registration failed for type 'pio-terminal-status-icon'. A type with that name is already registered.
    at Error (native)
    at Object.<anonymous> (/Users/davidebortolami/.atom/packages/termination/lib/status-icon.coffee:100:27)
    at Object.<anonymous> (/Users/davidebortolami/.atom/packages/termination/lib/status-icon.coffee:1:1)
    at Module._compile (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.value [as .coffee] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/Users/davidebortolami/.atom/packages/termination/lib/status-bar.coffee:5:14)
    at Object.<anonymous> (/Users/davidebortolami/.atom/packages/termination/lib/status-bar.coffee:1:1)
    at Module._compile (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.value [as .coffee] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.consumeStatusBar (/Users/davidebortolami/.atom/packages/termination/lib/termination.coffee:17:27)
    at Provider.module.exports.Provider.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52)
    at ServiceHub.module.exports.ServiceHub.consume (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/service-hub.js:50:18)
    at Package.module.exports.Package.activateServices (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:364:75)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:187:16)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:157:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:150:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:147:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:548:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:350:19
    at /Applications/Atom.app/Contents/Resources/app.asar/src/config.js:635:20
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Config.module.exports.Config.emitChangeEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:826:29)
    at Config.module.exports.Config.setRawValue (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:612:19)
    at Config.module.exports.Config.set (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:227:14)
    at Config.module.exports.Config.removeAtKeyPath (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:377:12)
    at Package.module.exports.Package.enable (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:77:26)
    at PackageManager.module.exports.PackageManager.enablePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:171:14)
    at HTMLButtonElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:358:27)
    at HTMLButtonElement.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLButtonElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands
     -4:29.6.0 core:undo (atom-text-editor.editor.is-focused.autocomplete-active)
     -3:47.2.0 settings-view:open (atom-text-editor.editor.is-focused)
     -3:35.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -2:30.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -2:28.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "gist-it",
      "markdown-preview",
      "language-gfm",
      "makro",
      "project-runner",
      "make-runner-panel",
      "linter-spell",
      "linter-write-good",
      "atom-terminal",
      "terminal-plus",
      "rst-preview-pandoc",
      "platformio-ide-terminal"
    ],
    "telemetryConsent": "limited",
    "themes": [
      "genesis-ui",
      "genesis-syntax"
    ]
  }
}

Installed Packages
# User
aesthetic-ui, v2.0.0 (inactive)
atom-beautify, v0.29.13 (inactive)
atom-material-syntax-dark, v0.2.5 (inactive)
atom-material-ui, v1.3.6 (inactive)
atom-spotify2, v2.1.2 (active)
atom-terminal, v0.8.0 (inactive)
auto-detect-indentation, v1.3.0 (active)
battery-status, v0.11.0 (active)
compare-files, v0.8.0 (active)
file-icons, v1.7.25 (active)
genesis-syntax, v1.0.7 (active)
genesis-ui, v0.5.0 (active)
git-plus, v5.25.3 (active)
git-time-machine, v1.5.4 (inactive)
hex, v0.6.2 (active)
highlight-line, v0.11.1 (active)
highlight-selected, v0.11.2 (active)
intel-hex, v0.1.0 (active)
intentions, v1.1.2 (active)
jekyll, v1.4.3 (inactive)
jekyll-snippets, v0.3.2 (inactive)
language-ansible, v0.1.11 (active)
language-arduino, v0.4.2 (active)
language-docker, v1.1.7 (active)
language-pfm, v0.82.0 (active)
language-tex, v0.4.0 (active)
linter, v1.11.18 (active)
linter-alex, v3.2.0 (active)
linter-ansible-linting, v1.2.1 (active)
linter-docker, v0.1.2 (active)
linter-js-yaml, v1.2.5 (active)
linter-jsonlint, v1.3.0 (active)
linter-just-say-no, v0.7.0 (active)
linter-proselint, v3.2.0 (active)
linter-shellcheck, v1.4.1 (active)
linter-spell, vundefined (inactive)
linter-spell-html, v0.6.1 (inactive)
linter-spell-javascript, v0.7.1 (inactive)
linter-spell-ruby, v0.3.1 (inactive)
linter-write-good, v0.8.0 (inactive)
make-runner, v1.1.14 (inactive)
make-runner-panel, v1.4.0 (inactive)
markdown-preview-plus, v2.4.0 (active)
markdown-themeable-pdf, v1.2.0 (active)
markdown-writer, v2.6.2 (inactive)
minimap, v4.25.6 (active)
minimap-cursorline, v0.2.0 (active)
minimap-find-and-replace, v4.5.1 (active)
minimap-highlight-selected, v4.4.0 (active)
minimap-linter, v1.6.0 (active)
minimap-pigments, v0.2.1 (active)
open-recent, v5.0.0 (active)
path-copy, v0.14.0 (active)
pdf-view, v0.53.0 (active)
php-twig, v4.0.0 (active)
pigments, v0.37.0 (active)
platformio-ide-terminal, v2.2.2 (inactive)
project-runner, v0.5.1 (inactive)
rst-preview-pandoc, v0.1.12 (inactive)
script, v3.11.1 (inactive)
sync-settings, v0.7.2 (active)
terminal-plus, v0.14.5 (inactive)
termination, v0.3.3 (inactive)
todo-show, v1.8.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (inactive)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.46.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

Uninstalling other terminal packages does not help

It's a cosmetic bug. I've gotten the same message when I uninstall/deactivate platformio-ide-terminal and install/activate termination without restarting Atom. These two packages share a code snippet that's causing the trouble. termination works just fine, though, if you restart Atom and doesn't produce any more warnings.
Try this:
Activate termination (if you've deactivated it)
See if it gives any warnings and copy them
Restart Atom
Does termination work?

Yes that was the problem.
(but for now it does not work, empty terminal.. will get back to you later)

No worries - thanks for the report! I'm sending in a fix in a few minutes.


Property renaming

That's it we need that xD

Not planned. Too error-prone. It would most likely struggle with dynamic keys, just like Obfuscator.io's renameProperties  (even on 'safe' mode):
// Input
(function () {
    const foo = {
        prop1: 1,
        prop2: 2,
        calc: function () {
            return this.prop1 + this.prop2;
        },
    };

    function doStuffWithFoo(foo) {
        var calc = "cal" + "c";
        console.log(foo[calc]());
    }

    doStuffWithFoo(foo);
})();
// 3

// Output
(function () {
    const _0x1ded56 = {
        '_0x7aa8af': 0x1,
        '_0x204e8e': 0x2,
        '_0x3d83a6': function () {
            return this['_0x7aa8af'] + this['_0x204e8e'];
        }
    };
    function _0x19b102(_0x420ffb) {
        var _0x643b75 = 'cal' + 'c';
        console['log'](_0x420ffb[_0x643b75]());
    }
    _0x19b102(_0x1ded56);
}());
// Uncaught TypeError: _0x18422a[_0x4ce7a3] is not a function

Object Extraction is safe alternative that can be used to rename property names by first converting them to individual variables.
Unless there is a concrete way to safely replace property names then I won't risk adding it. PRs are welcome to implement it.

if values are static this could be posible if you pre evaluate all string conversions but it woudl be horrible to implement plus if it acces a property from for example a http request or something that is not in the code itself would be imposible.

I mean, if you could connect to typescript somehow you will probably somehow be able to rename it ... probably

Use https://developers.google.com/closure/compiler/ and then obfuscate the generated JS code. Pretty sure reCAPTCHA is doing this.

Not planned, but pull requests are welcome.


Print choice

It would be better if the game printed the option I chose. In part as a confirmation that I didn't press the wrong key, but also to make a transcript make more sense.
Actually, it would probably be best if the game printed S when you save, D when you access the data bank etc, as well.

That does sounds sensible.. Should be a quick fix.

Added print output for story choices and other key-presses (A, D, F, H, ?, R, Q)
Thanks for catching these.


Implement fed avg

Not sure why its showing previous commits here? But the changes are in utils.py where I added the fed_avg method (which takes the number of datapoints into account for the average).


 However, when new API Versions are added the Go configuration often goes stale. In order to provide a more consistent experience between Go and other languages, we should either:

Abandon the current approach of relying on batch
Build tooling to detect when Go config has gone stale so that we can update it.

@bsiegel, we're talking about this at Go triage, and are sorta wanting to sit on it until we understand if there are big changes coming to the way that Swagger-To-SDK works. Think this work makes sense to start on now, or should we wait?

@marstr I think the approach I'm going to take is to have a configuration file or script file in each language repo which codifies:

The version of autorest to use
The correct flags and all other needed parameters to run autorest for the language
The set of actions to take after running autorest

As the language SDK maintainers, please feel free to construct the process you want/need, including the mode used for autorest and any post-autorest actions (which I gather is what the "tooling" above is meant to be). We can work later to make sure the SDK build service follows that process.

I believe this will be solved by moving to autorest.md files and supporting the existing _meta.json files with https://github.com/Azure/azure-sdk-for-go/pull/15111.

This is part of the Swagger->SDK work which is not being done


Update (-):ssp logo for compatibility with GitHub dark mode

Gets rid of the white outline that looked bad on a dark background. Should look OK in both light and dark themes now. Also added some gradient. Gradient is harder to get right, which is why I had only flat color before. Hope I didn't overdo it. The i is supposed to be ambiguous with a colon, but it didn't look enough like an i before. New gradient should suggest that shape without changing its footprint. Also the H should look like parentheses. These are suggestive of the hotword and s-expression syntax of Hissp's two readers.

It looks OK in both modes, and I think no worse than before in light mode.

Oh, and the blue and gold icon with silver letters resembles the coloring of Python's logo, although Hissp's silver is lighter. Not so much the green stroke, but it felt right.


Wrong Result When Render With ROI

First of all, thank you for your code!
I have tried the renderer_test  (test.cpp) changing the ROI as follows :
 cuda_renderer::Model::ROI roi = {320, 240, 100, 100};
And it give me the following result

When it should be:

Any clue why it is not working properly?
A second point I would like to raise relates about timing. The GPU ICP performance it's very impressive, good job! however this code:
device_vector_holder<::Vec3f> pcd_buffer_cuda, normal_buffer_cuda; 	scene.init_Scene_projective_cuda(scene_depth, K_, pcd_buffer_cuda, normal_buffer_cuda);
is about ten times slower than the ICP, why is it so slow?  do you have any advice for improving its perfomance?  Obviously, using a ROI will help and that's why it is so important that works properly the render with a ROI.
Thank you!

Oops, buffer idx here is wrong, it should be
            size_t x_to_write = (P[0] - roi.x);

Same for cuda side
It's much slower because the initial parts are totally on cpu. You can rewrite it (mainly normals) if caring about the speed.

Thank you for your quick reply!  now it works well.


raftstore: retry pending read index requests

Signed-off-by: qupeng<EMAIL_ADDRESS>What have you changed?
On follwer replicas pending read index requests will be retried. So that read commands won't be blocked forever in raftstore.
What is the type of the changes?
Bugfix.
How is the PR tested?

[ ] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/release

/release

/run-all-tests

/run-all-tests

/run-all-tests

/release

/run-all-tests

@5kbpers PTAL, I think it's completely different from what you has reviewed.

/run-all-tests


New DHARMA ID for encoders

@michaelnmmeyer michaelnmmeyer
Dear Michaël, I have updated recently the DHARMA ID list:
https://github.com/erc-dharma/project-documentation/commit/6432a24fbf3cbf8064905e55bcb665c2d70a475c#diff-a6c4b1d2995ff4f4a6d100a10ac0d3134538c1804a90c7c2e2c48fe71bce91e5
I have create two new IDs:

"ants" for Antonella Santoro (ansa was not available, as already used for Anjaneya Sarma).

"matr" for Margherita Trento

As far as I can see, these are not displayed on dharman.in.
Could you fix these when back at work, next week?
Thanks.

Done!


add extra http header

add extra http header to support extended functions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.caojingqi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve some inappropriate descriptions in the docstring of DinoTransformerDecoder.

Improve some inappropriate descriptions in the docstring of DinoTransformerDecoder.

@Li-Qingyun @Czm369

@keyakiluo Please fix the cl

Some formatting issues have been fixed. A review is required for subsequent checks. @hhaAndroid @Czm369 @Li-Qingyun


Forward Function{Entry,Exit} from LinuxCaptureService to LinuxTracing

The FunctionEntry and FunctionExit ProducerCaptureEvents emitted by user
space instrumentation are forwarded to LinuxTracing and transformed into
UserSpaceFunctionEntryPerfEvent and UserSpaceFunctionExitPerfEvent. Here
they will be assembled into FunctionCalls and used to fix unwinding when
samples fall inside one or more dynamically instrumented function, just like
with uprobes.
See the prototype of the integration of user space instrumentation and unwinding
as per
http://go/stadia-orbit-user-space-instrumentation-and-unwinding#heading=h.a3i5cfh8pexm
Normally, ProducerCaptureEvents go through the ProducerEventProcessor. We
send them to LinuxTracing instead by introducing an implementation of
ProducerEventProcessor
(ProducerEventProcessorHijackingFunctionEntryExitForLinuxTracing) that hijacks
FunctionEntry and FunctionExit events, but forwards all the other ones to
the real ProducerEventProcessor as usual.
Note: Detection of whether a sample fell inside a user space instrumentation
trampoline, or whether a sample fell inside the library injected by user space
instrumentation, or whether an address is inside a user space instrumentation
return trampoline for frame pointer callchain patching, is quite a more complex
matter and will come as a later change.
Bug: http://b/194704608
Test: Tried as part of the integration of user space instrumentation
and unwinding.

Meta-notes:

The first commit is https://github.com/google/orbit/pull/2977.
The change is split into multiple commits but it's meant to be squashed (an intermediate state would stop user space instrumentation from working). The reason is that I started with separate commits and I just decided to keep them all the way to the review because why not. Let me know if you prefer me to squash right away.

https://github.com/google/orbit/pull/2977 is now merged. I would wait until the end of the review to remove the first commit and rebase to avoid force pushing, but let me know if you'd prefer me to do that earlier.

lgtm!

@danielfenner Shall I take that as an approval? :D


Incorrect "Unused LANGUAGE pragma" warning with typed Template Haskell

The following
{-# LANGUAGE TemplateHaskell #-}

module Main (main) where

-- ch-test
import Test.Tasty.Hedgehog.Extra (testGenerator)

-- ch-uuid
import Data.UUID.Gen qualified as Gen

-- tasty
import Test.Tasty (defaultMain, testGroup)

main :: IO ()
main = defaultMain $ testGroup "Data.UUID.Gen" [$$(testGenerator [||Gen.uuid||])]

produces
ch-uuid/tests/Main.hs:1:1-32: Warning: Unused LANGUAGE pragma
Found:
  {-# LANGUAGE TemplateHaskell #-}
Perhaps you should remove it.
Note: may require `{-# LANGUAGE TemplateHaskellQuotes #-}` adding to the top of the file

But this is incorrect, as removing TemplateHaskell (or changing it to TemplateHaskellQuotes) causes the file to fail to compile.

+1. Facing same issue.
{-# LANGUAGE TemplateHaskell #-}

module Git where

import qualified GitHash as Git

version :: String
version = Git.giHash $$(Git.tGitInfoCwd)

I looked into this and it seems that isQuasiQuoteSplice, which is used to recognize TH usage here
https://github.com/ndmitchell/hlint/blob/b73274914d2bd3af0e4188a3de29b300631f06a5/src/Hint/Extensions.hs#L428
has changed to be more restrictive in recent versions of ghc-lib-praser:
Before GHC 9.6 it included both typed and untyped TH splices, but in ghc >=9.6 it only includes untyped splices:
https://hackage.haskell.org/package/ghc-lib-parser-ex-<IP_ADDRESS>/docs/src/Language.Haskell.GhclibParserEx.GHC.Hs.Expr.html#isQuasiQuoteSplice
Compare:
https://hackage.haskell.org/package/ghc-9.4.4/docs/Language-Haskell-Syntax-Expr.html#t:HsSplice
https://hackage.haskell.org/package/ghc-9.6.1/docs/Language-Haskell-Syntax-Expr.html#t:HsUntypedSplice
Not sure how to fix this yet :thinking:

not sure this is quite ready to be closed. re-opening while unsure.

@shayne-fletcher I think it's safe to close this issue. I tested my fix both reproducers and can confirm that the false positive is no longer emitted for either.


Backslash doesn't split to child trees

# Forward slash works:
vertebrates = DataTree.from_dict(
    name="Vertebrae",
    d={
        "/Sharks": None,
        "/Bony Skeleton/Ray-finned Fish": None,
        "/Bony Skeleton/Four Limbs": None,
    },
)
vertebrates
Out[67]:
DataTree('Vertebrae', parent=None)
├── DataTree('Sharks')
└── DataTree('Bony Skeleton')
    ├── DataTree('Ray-finned Fish')
    └── DataTree('Four Limbs')

# Backslash doesn't work:
vertebrates = DataTree.from_dict(
    name="Vertebrae",
    d={
        "\Sharks": None,
        "\Bony Skeleton\Ray-finned Fish": None,
        "\Bony Skeleton\Four Limbs": None,
    },
)
vertebrates
Out[69]:
DataTree('Vertebrae', parent=None)
├── DataTree('\Sharks')
├── DataTree('\Bony Skeleton\Ray-finned Fish')
└── DataTree('\Bony Skeleton\Four Limbs')

I'm guessing this is a Windows vs. Linux thing? For example, there's PurePosixPath usage here:
https://github.com/xarray-contrib/datatree/blob/a206e725d6207d0ddf0675a9bca33ee18679ff29/datatree/treenode.py#L30
https://docs.python.org/3/library/pathlib.html#pathlib.PurePosixPath
https://docs.python.org/3/library/pathlib.html#pathlib.PureWindowsPath
I'm guessing adding a Windows CI might find some more issues.

Good catch. Yes I expect this is because I used PurePosixPath.
Q: Do you think backward slashes should be coerced into forward ones? Or an error raised? Presumably we do not want two valid separator characters?

Windows uses backslash by default and coerces forward slashes to backslashes, I think we should handle both.
I'm hoping pathlib has a good trick for this but I haven't looked in to this enough.
If not, maybe the separator can be os-dependent?

But url:s uses forwardslashes (github.com/https://github.com/xarray-contrib/datatree/issues/250) so we should probably just be able to split on both.

Why do you say this? You're talking about a case where a datatree is created from a url, but on a windows machine?

Yes, I just noticed the url on the browser is forward slashes on my windows computer. And I was thinking someone could experience that case as well.

Thinking about this again, I don't think we should support multiple separators in the node paths. The node paths have nothing to do with the filesystem, they don't represent files on disk.
We might however want to help the user when opening from or saving to multiple files, in which on Windows we should convert backslashes in filepaths into forward slashes in node paths, and back again when saving. Until we actually have an open_mfdatatree or save_mfdatatree function we don't need to worry about this though.

I don't think we should support backslashes in datatree paths either, group paths should have nothing to do with filesystem paths (just like urls this should always be the same across operating systems).
Closing, but if you want to continue discussing please open a new issue on the xarray repository.


fix: have generateURL return null for undefined filenames

This lets the afterRead hook skip URLs for non-existent image sizes, cleaning up the following error:

[00:47:11] ERROR (payload): TypeError: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:387:5)
    at validateString (node:internal/validators:116:11)
    at Object.join (node:path:1172:7)
    at Object.generateURL (/project/node_modules/@payloadcms/plugin-cloud-storage/src/adapters/s3/generateURL.ts:13:48)
    at /project/node_modules/@payloadcms/plugin-cloud-storage/src/hooks/afterRead.ts:17:31
    at step (/project/node_modules/@payloadcms/plugin-cloud-storage/dist/hooks/afterRead.js:33:23)
    at Object.next (/project/node_modules/@payloadcms/plugin-cloud-storage/dist/hooks/afterRead.js:14:53)
    at /project/node_modules/@payloadcms/plugin-cloud-storage/dist/hooks/afterRead.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/project/node_modules/@payloadcms/plugin-cloud-storage/dist/hooks/afterRead.js:4:12)

I believe this was intended, based on || being used on the return value of generateURL here: https://github.com/payloadcms/plugin-cloud-storage/blob/2cd83f2aa6ceea00381dbf5ca16e1c83deb9f4f0/src/hooks/afterRead.ts#L23

Can someone please accept this in!
I need this fixed as well.

Hey @KGZM — thank you for the PR!
We dug into this and figured out the best way to handle the changes would be to just simply only run the adapter.generateURL if the filename is set. That way, the plugin is handling the logic, and not the adapters themselves.
Check it out here:
84cd214a89c32598969eb76aec9f22c1b18a62b1
I'm going to close this one in favor of the commit we pushed but really thank you for jumping in here!

@jmikrut Thanks for the quick fix. That solves it! Really thankful for this plugin itself.


Fixes pytests openai: args change and pathlib reference for pricing file

Description
Embedchain openai tests fail.
This fixes all the 7 tests.
Fixes #1601
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (does not change functionality, e.g. code style improvements, linting)
[ ] Documentation update

How Has This Been Tested?
Unit tests.

[x] Unit Test
[ ] Test Script (please provide)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@PranavPuranik Can you please update the lock file by doing poetry lock --no-update? Tests are failing because of it


Neovim crashes when using codesnap with rust code

When I call :CodeSnap on rust code, neovim crashes.

Here's the repo where this code resides: https://github.com/wireapp/core-crypto

https://github.com/mistricky/codesnap.nvim/assets/22574136/27c0589f-fe66-4b89-8732-2b5436d16f32
I'm not sure what's happen, I can't reproduce on my computer.
Can you provide the following information to help us to debug:

What's your architecture x86 or ARM?
What's version of Neovim do you use?
What's version of CodeSnap.nvim do you use?

on ARM. Mac M1 Pro
NVIM v0.11.0-dev-364+g73ae7d44a
Build type: RelWithDebInfo
LuaJIT 2.1.1720049189
Its the latest main. I had just installed yesterday when I was trying. It does work with lua though...

I can't reproduce, can you make a new clean Neovim config and install CodeSnap.nvim and try again?

I'm currently away from home. I'll try again on Monday.

It stopped happening... I think we can close this. If I make a way to reproduce it I'll reopen and give more details


Release 2.1.107

Backlog:

[ ] The __pex__ import hook does not handle registering top level PEP-420 packages #1910
[ ] The --resolve-local-platforms option does not work with --complete-platforms #1899
[ ] Expose setuptools and wheel version flags for use with non-vendored Pips. #1895
[ ] Plumb --pip-version to Platform tag calculation. #1894
[ ] venv_dir calculation doesn't correctly handle PEX_PYTHON_PATH with symlinks. #1885

[ ] PEX_INHERIT_PATH+default shebangs don't interact well with virtualenvs #1344
[ ] Pex interpreter cache is not upgrade / downgrade safe. #1176
[ ] Provide a better resolve error message for a Platform DistributionTarget when --resolve-local-platforms. #1070
[ ] Remove PEX_PYTHON_PATH from build time interpreter selection. #1075

Broken off from "Release 2.1.106 https://github.com/pantsbuild/pex/issues/1915" to make way for a fix for direct reference requirements with local versions failing to resolve in #1920.


Can't access element client side via this.$refs

<client-only>
    <vue-bootstrap-typeahead
      class="ctl"
      :type="type"
      :data="typeahead"
      :id="name"
      :name="name"
      ref="inputRef"
      :minMatchingChars="1"
      :value="value" size="lg"
      @hit="updateValue"
      @input="updateValue">
    </vue-bootstrap-typeahead>
    <input
      class="form-control form-control-lg ctl form-control"
      :type="type"
      slot="placeholder"
      :name="name"
      ref="inputPlaceholderRef"
      :value="value" />
</client-only>

I'm using the client-only that Nuxt imports. I have a component that only works client side vue-bootstrap-typeahead so I've wrapped it in client-only and filled the placeholder slot with a normal input. Problem is I was setting this.$refs.inputRef.value = value on the client side but the this.$refs doesn't include inputRef. inputPlaceholderRef does show up, however.
Is there a way in which this could work? In the meantime, maybe there is a work around?

When on the client, there is a one $nextTick delay before the client markup is rendered, so you need to delay your access to this.$refs.inputRef in a this.$nextTick(...):
export default {
  mounted() {
    // this.$refs.inputRef doesn't exist yet
    this.$nextTick(() => {
      // But now it does
      this.$refs.inputRef.value = 'foo'
    })
  }
}

@tmorehouse @tettoffensive
I had to do 2 $nextTicks or put the <client-only></client-only> in a parent component.
Not sure if this is an issue with this package or the vue-awesome-swiper package.
Solution 1: wait 2 ticks
mounted() {
    this.$nextTick(() => {
        this.$nextTick(() => {
            this.$refs.mainGallery.swiper.controller.control = this.$refs.thumbGallery.swiper
            this.$refs.thumbGallery.swiper.controller.control = this.$refs.mainGallery.swiper
        })
    })
}

Solution 2: parent component
// parent
<template>
    <client-only>
        <Child v-bind="$attrs"/>
    </client-only>
</template>

// child
<template>
    <stuff-here/>
</template>

<script>
    export default {
        mounted() {
            this.$refs.mainGallery.swiper.controller.control = this.$refs.thumbGallery.swiper
            this.$refs.thumbGallery.swiper.controller.control = this.$refs.mainGallery.swiper
        }
    }
</script>


Align usage of new internal API

Sentry is using some new api internally in its integrations, let's update ours to reflect that.

One new thing I see getting used is scope.setSDKProcessingMetadata, which substitutes entirely the usage of a custom eventProcessor

This needs some more thought, I doesn't look that using that API improves our plugin internal logic 🤔 . We have a different way of customising the event metadata at the moment.

Going to close this one


switch url at runtime

Should resolve issue #527
This allow to change url at runtime:
MixpanelAPI mixpanel = MixpanelAPI.getInstance(this, projectToken, "http://my.mixpanel.proxy");

Provided url is optional

Fixed on https://github.com/mixpanel/mixpanel-android/pull/530


Further flesh out hiring docs

This will close #523.

Will be ready for merge with passing tests after hackclub/markcop#88 is merged.

repush


Where are the binary files supposed to be

Hello,
I've juste tested the github actions with this piece of code
      - name: Run Infer#
        uses<EMAIL_ADDRESS>        id: runinfersharp
        with:
          binary-path: ${{ env.PUBLISH_WEBSITE }}
      - name: Infer# analysis results
        run: echo "${{ steps.runinfersharp.outputs.results }}"

      - name: Zip Website
        run: pushd ${{ env.PUBLISH_WEBSITE }}; zip -r ${{ env.PUBLISH_WEBSITE_ZIP }} .; popd

Where ${{ env.PUBLISH_WEBSITE }} equals to :
    env:
      BUILD_CONFIGURATION: Release
      PUBLISH_WEBSITE: ${{ github.workspace }}/artifacts/Website

Looking at the logs I have this error :
cp: cannot stat '/home/runner/work/MyWebsite/MyWebsite/artifacts/Website': No such file or directory
Timed out methods: 0
Unknown instructions:

I'm sure the dlls are here and the directory exists because this is the pipeline I use to deploy my webapp.
Have I missed something from the doc ?

I think the error may come from this step of the action: https://github.com/microsoft/infersharpaction/blob/618f2c5c1f79dd1986e2136d1f57f2b7f1733e5f/entrypoint.sh#L5
where $1 is the binary path you provided, which contains the binary files.
I am not sure why it complains about this non-existent folder if the same pipeline has been working for you, but I have a working sample that may help you identify the issue:
jobs:
  build:

    runs-on: ubuntu-16.04

    steps:
    - uses: actions/checkout@v2
    - name: Setup .NET Core
      uses: actions/setup-dotnet@v1
      with:
        dotnet-version: 2.2.108
    - name: Build with dotnet
      run: dotnet build ConsoleApp1/ConsoleApp1.sln

    - name: Run Infer#
      uses<EMAIL_ADDRESS>      id: runinfersharp
      with:
        binary-path: 'ConsoleApp1/ConsoleApp1/bin'
    - name: Infer# analysis results
      run: echo "${{ steps.runinfersharp.outputs.results }}"

I have a console app located at the root of the repo, called "ConsoleApp1". The script builds it with "dotnet build". The binary files would be created in "ConsoleApp1/ConsoleApp1/bin", which is supplied as the value for binary-path. The full path to the .dll file is "/home/runner/work/githubactions/githubactions/ConsoleApp1/ConsoleApp1/bin/Debug/netcoreapp2.2/ConsoleApp1.dll", where githubactions is my repo name (I assume your repo name is MyWebsite?). By setting binary-path as "ConsoleApp1/ConsoleApp1/bin", it copies everything under this folder for the analysis later.
Hopefully it would be helpful to you. Please let me know if you are still having issues.

I think the error may come from this step of the action: https://github.com/microsoft/infersharpaction/blob/618f2c5c1f79dd1986e2136d1f57f2b7f1733e5f/entrypoint.sh#L5
where $1 is the binary path you provided, which contains the binary files.
I am not sure why it complains about this non-existent folder if the same pipeline has been working for you, but I have a working sample that may help you identify the issue:
jobs:
  build:

    runs-on: ubuntu-16.04

    steps:
    - uses: actions/checkout@v2
    - name: Setup .NET Core
      uses: actions/setup-dotnet@v1
      with:
        dotnet-version: 2.2.108
    - name: Build with dotnet
      run: dotnet build ConsoleApp1/ConsoleApp1.sln

    - name: Run Infer#
      uses<EMAIL_ADDRESS>      id: runinfersharp
      with:
        binary-path: 'ConsoleApp1/ConsoleApp1/bin'
    - name: Infer# analysis results
      run: echo "${{ steps.runinfersharp.outputs.results }}"

I have a console app located at the root of the repo, called "ConsoleApp1". The script builds it with "dotnet build". The binary files would be created in "ConsoleApp1/ConsoleApp1/bin", which is supplied as the value for binary-path. The full path to the .dll file is "/home/runner/work/githubactions/githubactions/ConsoleApp1/ConsoleApp1/bin/Debug/netcoreapp2.2/ConsoleApp1.dll", where githubactions is my repo name (I assume your repo name is MyWebsite?). By setting binary-path as "ConsoleApp1/ConsoleApp1/bin", it copies everything under this folder for the analysis later.
Hopefully it would be helpful to you. Please let me know if you are still having issues.

Thanks for your reply, but it doesn't work. I've modified my pipeline like this :
      - name: List files before infersharp
        run: ls -R ${{ env.PUBLISH_WEBSITE }}
      - name: Run Infer#
        uses<EMAIL_ADDRESS>        id: runinfersharp
        with:
          binary-path: ${{ env.PUBLISH_WEBSITE }}

The ls -R ${{ env.PUBLISH_WEBSITE }} shows the dll are here :
Run ls -R /home/runner/work/MyWebsite/MyWebsite/artifacts/Website
/home/runner/work/MyWebsite/MyWebsite/artifacts/Website:
Azure.Core.dll
Azure.Identity.dll
Azure.Security.KeyVault.Certificates.dll
Azure.Security.KeyVault.Secrets.dll
Markdig.dll
Microsoft.AspNetCore.Authentication.JwtBearer.dll
Microsoft.AspNetCore.Authentication.OpenIdConnect.dll
Microsoft.AspNetCore.Mvc.Razor.Extensions.dll
Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.dll
Microsoft.AspNetCore.Razor.Language.dll

Thanks for your reply, but it doesn't work. I've modified my pipeline like this :
      - name: List files before infersharp
        run: ls -R ${{ env.PUBLISH_WEBSITE }}
      - name: Run Infer#
        uses<EMAIL_ADDRESS>        id: runinfersharp
        with:
          binary-path: ${{ env.PUBLISH_WEBSITE }}

The ls -R ${{ env.PUBLISH_WEBSITE }} shows the dll are here :
Run ls -R /home/runner/work/MyWebsite/MyWebsite/artifacts/Website
/home/runner/work/MyWebsite/MyWebsite/artifacts/Website:
Azure.Core.dll
Azure.Identity.dll
Azure.Security.KeyVault.Certificates.dll
Azure.Security.KeyVault.Secrets.dll
Markdig.dll
Microsoft.AspNetCore.Authentication.JwtBearer.dll
Microsoft.AspNetCore.Authentication.OpenIdConnect.dll
Microsoft.AspNetCore.Mvc.Razor.Extensions.dll
Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.dll
Microsoft.AspNetCore.Razor.Language.dll


Python: Text partitioning module

Motivation and Context
Porting the text partitioning module to python
(Reopening of PR #427 )
Description

This is adding the Text partitioning module in semantic_kernel/semantic_functions/semantic_text_partitioner.py
and the function_extention in semantic_kernel/semantic_functions/function_extension.py
Compared to the C# version the files were added directly into the semantic_functions directory instead of the semantic_functions/partitioning to not have too many nested directories.

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Agreed. text_chunker make sense, there is also #404 referring to extend the chunker, good idea to align on this terminology.

@JTremb I'm ready to approve this PR once the terminology from "semantic text partitioning" -> "text chunking" is complete

poetry run pre-commit run -c .conf/.pre-commit-config.yaml -a will run flake8, isort, and black
poetry run ruff check .

should address your linting errors.

@awharrison-28 Great! I did the renaming of the terminology (files, functions) partition -> chunk.
Do you think I should also move the text_chunker in a different package than semantic_kernel.semantic_functions ?
For the linting errors , it's related to files that I haven't modified so I did not push the changes. I can also add them in this PR.

Agree that this shouldn't need to be called "semantic".
I like the phrase "text chunking". As long as you all think implementing various "Chunkers" sounds good and makes sense.
In the future, we'll want to be able to chunk based off the number of characters, the number of tokens, and by other popular Python libraries like Spacy and NLTK.
Since this will be a common operation for anyone working with data in the SK, I think this can be considered a core SK Function.

@alexchaomander Can you help make sure changes made here are also made re: dotnet\src\SemanticKernel\SemanticFunctions\Partitioning\SemanticTextPartitioner.cs in dotnet kernel?

The terminology oracle agree to use the name: Text Chunker. Let's update both codebases


Shift + Home doesn't select the text

Version: Current insider build
OS: Windows 10
I'm using Shift+Home quite often in order to select everything left of the cursor and place it to the first column of the current line. The selections doesn't work this way with the current insider build.
Selecting text using these shortcuts works perfectly:
Shift+↑
Shift+↓
Shift+→
Shift+←
Shift+End

Can you try launching with --disable-extensions? And do you have any relevant personal keyboard bindings?

I can't reproduce it anymore with today's build based on commit 43e46ab. My keyboard shortcuts don't seem to interfere here:
[
  {
    "key": "ctrl+f5",
    "command": "workbench.action.reloadWindow",
    "when": "editorTextFocus"
  },
  {
    "key": "ctrl+shift+t",
    "command": "workbench.action.tasks.test"
  }
]


Detect migration clashes against mainline

What does this pull request do?
Extends the ci/circleci: validate_db job with applying migrations from main before migrating from the active branch.
What is the intent behind these changes?
The aim is to detect clashes of version numbers, which are typical after rebases.
This still won't detect clashes if branches are old or not rebased, so it's recommended to keep branch lifetime short

p.s. why won't this detect clashes if branches are not rebased?

I'm thinking of the case where the branch is old, and main has moved on since; unless the CI is re-run, the check can still be ✅ even if main has new migrations


fix an encoding issue with calling adb shell getprop

fix an encoding issue with calling adb shell getprop (don't assume UTF8)
be defensive about exceptions from Process.runSync
fix https://github.com/flutter/flutter/issues/5738

@eseidel @danrubel

Can we test this?

LGTM with comment to address as you see fit.

Sounds like from the bug report that we'd need to update this to LATIN1 (even the ASCII encoding is getting interpreted and is failing).

@devoncarew what's your plan with this PR?

Urk, this fell off my radar. I'll revisit, and fix it or close.


WIP: attempt to send HTML/JSON when Accept Header: */*

Per discussion #162
Iterate through all values of Accept Header when choosing a response type. If the accept header of */* is found fuego will attempt to first respond with HTML and then JSON if it is unable to Render HTML.
Will add tests and such if this is acceptable.

Closing as I completely missed what parseAcceptHeader was doing


Add 404 page

Explication
Add the view for the 404 error. The user will be redirected to this view when requesting a resource that does not exist
Checklist

[ ] Add a error 404 route at React Router
[ ] Add a empty or basic file to the 404 view

regardless of the effort estimate I want to be assigned to this task


Forms

Creating forms for comments and posts

The following changes are made in this branch:

Added routes for creating posts, likes, and comments
Created forms for post#new and comment#new actions
Added #create actions in controllers
Added links to #new actions in views

Status: Invalid 🔴
Hi @bernabasy 🙋♀,
While you made a great effort in this project, I can't review your code.
Invalid Code Review Request
You have submitted a project that has a README that is not professional. Here is a key point to consider when documenting your README.

Kindly ALWAYS delete the live demo section if the application is not deployed. If project requirements say to deploy the project, the section should be restored and the link updated. The goal is to make sure that you do not have any empty sections in your README because it makes it look unfinished.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Thank you for your suggestions.

hello, @KDlamini  thank you for approving my pull request.


Fix a bug where vertex 0 is never animated.

Closes issue #121.

Ah, I messed up the fix because the original code had an assignment expression, and I had originally split it into assignment then if, but combined them like the original code when I pushed the commit. But the assignment and if really do need to be two separate lines for a proper fix.

Does merging https://github.com/Quantomatic/zxlive/pull/123 fix this?

Yes, either #123 or #124 (or both). The assignment expression is fine for python 3.8 and higher, and as discussed zxlive is supporting >= 3.9 so it's okay. (I had removed it in an earlier state of this code because I wasn't sure whether 3.7 was going to be supported or not.)


How does Prisma work with Relay?

People sometimes wonder how to implement a GraphQL server that implements the Relay spec with Prisma. One important thing to be aware of in this context is that the GraphQL server implementation is independent from using Prisma, meaning Prisma only takes care of sending database queries but the GraphQL schema is modeled/implemented independently from that.
For a quick win, we can add this info as an FAQ to the docs.

Hey! Any updates on this? I am building a library to give users a set of relay/prisma/typegraphql helpers to make building relay-compliant API easier, but it seems like the query batching (n+1 problem) is a bit of a challenge with relay edges/nodes, would love to see if there is some internal discussion on this!


[Improvement] Enhance render speed

test connection for frontend and backend
reduce loading time when rendering pages
...
more waiting to added

Due to the database migration, the backend server has stopped temporary.
So this issue will be close until the backend server has reopened.


I have set up two users. But the computers in the two users can still communicate with each other. Am I setting it wrong?

I have set up two users. But the computers in the two users can still communicate with each other. Am I setting it wrong?

Bug description

Environment

OS:
Headscale version:
Tailscale version:

[ ] Headscale is behind a (reverse) proxy
[ ] Headscale runs in a container

To Reproduce

You should fill out the Environment-Infos to receive help.

Did you setup acl's? As far as my experience is that there are no access restriction as long as you did not setup acl's.
Are you on v0.23? ACL's are somewhat broken in the alpha in my experience.

For context, ACLs should be configured this way : https://headscale.net/acls/#acl-setup


Issue with currentActivity.getClass when using RN 0.30 on Android

Hi
We upgraded our app to RN 0.30 and while it works on iOS, it crash immediately at launch on Android:

AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
AndroidRuntime: at com.slowpath.hockeyapp.RNHockeyAppModule.start(RNHockeyAppModule.java:105)

This seems to be an issue with:
LoginManager.register(_context, _token, _appSecret, authenticationMode, currentActivity.getClass());
Any idea what we are doing wrong?
The only other thing we see in the logs is: "FATAL EXCEPTION: mqt_native_modules"
Thanks!

@martincik Any idea on how to deal with this?

@martincik
It seems the issue is with using getCurrentActivity() as activity can be null sometime.
I resolved the issue by adding the following to start, update and feedback:
    if (currentActivity == null) {
        // The currentActivity can be null if it is backgrounded / destroyed, so we simply
        // no-op to prevent any null pointer exceptions.
        return;
    }

I can make a pull request if you want.

thanks @martincik

I'm actually seeing this error when an app is started. It seems the currentActivity is null when start is called. You could no-op, but then HockeyApp wouldn't be started.
If I implement LifeCycleEventListener I can see:
  @Override
  public void onHostResume() {
    System.out.println("Printed after start method.");
  }

Is called after start. So when start was called there was no activity.
Maybe start could check for activity, if it isn't null then start. If it is then set a flag and then start in the onHostResume method.
If this sounds alright I'll submit a PR. It would also be good to get a release pushed.

Sounds good to me.


csharp-8.md - Forgetting how to Rainbow

Someone missed green.  This bothered me too much.
Summary
Describe your changes here:
Green, to the rainbow examples.  Call this a logic fix.

What are you talking about?  I am lost


fully implement all of e:cue's features

There are the attributes Deflection, Header, classicPos and classicEntry that are currently not or only partially implemented. See e:cue's explanation file somewhere in the installation.

I've had a look at both the main library (MainLibrary.xml) and in MainDefs.xml which describes the Library Editor's user interface.

The Header / HeaderMisc / HeaderChannels attributes are always empty (when present) and after looking at MainDefs.xml, it seems like they are just in there by mistake.
ClassicPos is never mentioned in MainDefs.xml. In the main library, it is counting the <*Channel> elements per fixture.
ClassicEntry is type int, value=0 (min=0, max=1000, delta=1), unitless, not visible and read only
Deflection is type int, value=0 (min=0, max=65535, delta=1), unitless, with the info "This value specifies how the fixture should react to the Highlight function. Since Highlight doesn't affect focus channels the value isn't relevant for focus channels.". In the main library, it is always value=0.

Resolution:

remove the Header / HeaderMisc / HeaderChannels attributes
keep ClassicPos="$i"
keep ClassicEntry="0"
keep Deflection="0"


Control Center crashing during  ssh key removal on Mac OS [Master]

How to reproduce:

Go to ssh-keys management.
From existing keys delete one of the keys.  (you should have more than  2 keys.)
Delete the second one.

Result: CC will crash.
logs_18.txt

This situation exists on Ubuntu too
logs_10.txt
logs_11.txt
on Ubuntu

When I removed the second key, cc crashed.
Failed in master

Forgot to update the cc.
Tested one more time.
Fixed in master

Removed several keys, CC did not crash.  Tested in prod


Outdated ol3-geocoder.min.css in CDN

http://cdn.jsdelivr.net/openlayers.geocoder/latest/ol3-geocoder.min.css is not minified version of
http://cdn.jsdelivr.net/openlayers.geocoder/latest/ol3-geocoder.css and classes don't match those generated in HTML.

@jan-tosovsky-cz  Would you mind to capture some screenshots?
For me is everything just fine.

It is indeed strange. At work I could see the correct version, but on my home computer there is an obsolete one (in both FF and Chrome), even after deleting browser cache.

Looking at that suspicious CF-Cache-Status: HIT response attribute I think it could be caused by an obsolete cache served by a specific local CDN server.

Let's consider this a cache/proxy issue, ok? I can be solved on your side.
Feel free to reopen it if you have any further problem related.


CopyFiles@2 task does not expand variables in Contents field

This took a bit of debugging to figure, so raising this. The "does not work" snippet has no errors in the build pipeline but doesn't copy the file.
// Does not work
- task: CopyFiles@2
displayName: 'Copy subscription $(Aks.SubscriptionId) Configuration.json to $(ob_outputdirectory)'
inputs:
flattenFolders: true # need to copy the file to one artifacts folder. Makes it easy to deploy to EV2 since all files are in the same folder.
Contents: $(Build.SourcesDirectory)/src/Linux/AKS/EV2-Deploy/CommonScopeBindings/subscriptions/$(Aks.SubscriptionId)/Configuration.json
TargetFolder: '$(ob_outputdirectory)'
// Works
- task: CopyFiles@2
displayName: 'Copy subscription $(Aks.SubscriptionId) Configuration.json to $(ob_outputdirectory)'
inputs:
flattenFolders: true # need to copy the file to one artifacts folder. Makes it easy to deploy to EV2 since all files are in the same folder.
SourceFolder: '$(Build.SourcesDirectory)/src/Linux/AKS/EV2-Deploy/CommonScopeBindings/subscriptions/$(Aks.SubscriptionId)'
Contents: Configuration.json
TargetFolder: '$(ob_outputdirectory)'

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1a08d700-66df-67d4-ac5e-3140af00f014
Version Independent ID: 1a08d700-66df-67d4-ac5e-3140af00f014
Content: CopyFiles@2 - Copy files v2 task
Content Source: task-reference/copy-files-v2.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

I believe you may have found a bug in the task itself, as the examples that were provided by the task owner show that variables can be used in the Contents field, and those variables should be available to all of the task inputs equally (any string parameters for task inputs are the same and the variable expansion would happen before the task runs.
Would you mind filing your report here?
Issues · microsoft/azure-pipelines-tasks (github.com)
I will track that and if there is a documentation fix that needs to be made after they evaluate it, I will make the update.
Thank you for letting us know.


Module not found: Error: Can't resolve 'path'

hi
Im going to make a ftp client bundle for my web
I test basic-ftp and ftp from nmp
then I got many error while compiling such as:
ERROR in ./node_modules/basic-ftp/dist/Client.js 5:15-30
Module not found: Error: Can't resolve 'path' in '/var/www/disn.ir/html/node_modules/basic-ftp/dist'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
- install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "path": false }
the question is,is that possible any way??
to use ftp client on front end?
be cause of tcp security stuff....
the other question,how do i know which npm module can use in web frontend and which not?

Please read error message and use this, you can't use Node.js module in browser, you need polyfill or disable this module

you can't use Node.js module in browser

this is not true, there is many example frontend web site based on node modules
but I read not all of them cant be bundled for using on frontend
if I am wrong give me a reference about that
best regards


refine util_tf2.py

Clarify each function's purpose
Function dlr_loss and dlr_loss_targeted become ModelAdapter's member functions
Support for setting data_format manually

Hi,
looks very nice, thanks! I'll try to quickly test it, then merge.

Merged, thanks!


Building virtual environment

Thank you very much for your coding.
I followed your instructions
-make: cd bin/ && bash make.sh

and run
bash train.sh or bash observe.sh but it had errors
FileNotFoundError: [Errno 2] No such file or directory: './venv/sumo/bin/sumo'
I would like to ask you how to run the model without a virtual environment and building sumo. Because I install sumo by sudo apt-get install sumo sumo-tools sumo-doc
And could I use a conda environment instead of a virtual environment?

Install as root, with: sudo bash make.sh.
I don't use conda if not specifically needed, this project was designed for venv.

Thank you very much. I can run your models


fstar.exe without any arguments passes garbage commands to shell

[hritcu@detained pub]$ bin/fstar.exe
... usage information ...
Error: using standard input to read formula.
For usage information: z3 -h
/bin/sh: line 1: $'\r': command not found
/bin/sh: line 2: $'\r': command not found
/bin/sh: line 3: SMT.RELEVANCY=2: command not found

Looking at this, it seems that F* is passing Z3 arguments to the shell.
I've observed this once, but now it seems hard to reproduce.

Could never reproduce this, closing.

Encountered this again with the OCaml binary. I think it's some sort of race condition that only occurs when fstar.exe exists very quickly.
[hritcu@detained ocaml-output]$ fstar.exe --version
F* 0.9.0
platform=Linux_x86_64
compiler=OCaml 4.02.3
date=2015-08-25T16:56:58-0700
[hritcu@detained ocaml-output]$ Error: using standard input to read formula.
For usage information: z3 -h
/bin/sh: line 1: $'\r': command not found
/bin/sh: line 2: $'\r': command not found
/bin/sh: line 3: SMT.RELEVANCY=2: command not found

One more occurrence right now:
fstar.exe --codegen OCaml ex1a-safe-read-write.fst
Error: using standard input to read formula.
For usage information: z3 -h
/bin/sh: line 1: $'\r': command not found
/bin/sh: line 2: $'\r': command not found
/bin/sh: line 3: SMT.RELEVANCY=2: command not found
Makefile:33: recipe for target 'extract-acl' failed
make: *** [extract-acl] Broken pipe


Update Bastion guide

Amended bastion guide, with the new Anchoring guide most of the information needed for bastion spots and anchoring is there, so to reduce confusion have amended this guide to be more about the rules for SRP and additional tips pertinent to Bastion.

Merged with e010f976005d5c53de215388d60f4c956d56a619


Add support for prefixmaps context object

This implements a smarter way of generating a converter that takes advantage of things besides the canonical records.
Blockers

[x] https://github.com/linkml/prefixmaps/issues/11. The issue here is that the prefixmaps package doesn't really provide any guarantees about bijectivity. In the mean time, we can just promote one conflicting prefix to be "canonical"

Codecov Report

Merging #22 (32abb78) into main (87a8ccd) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 32abb78 differs from pull request most recent head efc67df. Consider uploading reports for the commit efc67df to get more accurate results

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          226       244   +18
  Branches        39        44    +5
=========================================
+ Hits           226       244   +18

Impacted Files
Coverage Δ

src/curies/api.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

My preference would be that curies stays more minimal, doesn't introduce any additional dependencies

Same functionality implemented in https://github.com/linkml/prefixmaps/pull/25


Pass context to fetch in json-schema loader

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #4293
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Environment:

OS:
@graphql-mesh/...:
NodeJS:

Checklist:

[ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests and linter rules pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thanks for the PR @dr3 !
I moved your changes there with some other improvements on our fetch implementation!
https://github.com/Urigo/graphql-mesh/pull/4356