How to run a class that extends SfCommand ?

Hi,
This is not an issue but I can't find anywhere else to post this question.
I spent many time browsing forums and sources from salesforcecli projects but can't find anything to help me.
I would like to make a direct call (not a child_process exec or so) in my SFDX plugin to a class that extends SfCommand but I struggle with constructor args.
When I try to directly call a class that extends SfdxCommand, it works perfectly :
import { OrgListCommand } from '@salesforce/plugin-org/lib/commands/force/org/list';
[...]
const orgListCommand = new OrgListCommand(['--all', '--json'], {});
const rawResponse = await orgListCommand._run();
Right now, I am trying to make the following lines work :
import { PackageInstalledListCommand } from '@salesforce/plugin-packaging/lib/commands/package/installed/list';
[...]
const packageInstalledListCommand = new PackageInstalledListCommand([--targetusername ${orgAliasTmp}, '--json'], {});
const installedPackagesRawResponse = await packageInstalledListCommand._run();
(By the way, I can't find where the 'legacy' commands are... If you know, please tell me)
I made several tries :
First, it crashed on a 'config.plugins' error. So I tried to set the command config arg with '{ plugins: [] }'.
Then, it crashed on a 'config.scopedEnvVarKey' error. So I tried to set the command config arg with '{ plugins: [], scopedEnvVarKey: (k: string): string => { return k.replace(/-/g, '_').toUpperCase(); } }'. (From a piece of code I found in a salesforcecli project. It already seems pretty obvious that I was not on the right track)
Nevermind, it crashed on 'Unexpected argument: --targetusername' error.
So I tried to name the argument 'target-org'. Etc.
...
At the end of the day, I don't know if the problem comes from the way I call the class that extends SfCommand or if it is the called class itself. (I'm pretty sure, it is the first one as test on other classes went wrong too)
Thanks in advance for your help.
Rémy

This test in plugin-packaging shows an example: https://github.com/salesforcecli/plugin-packaging/blob/main/test/commands/package/install.test.ts#L137
Since this is essentially a cli question I would ask on https://github.com/forcedotcom/cli/issues but I think the link above should unblock you.

Thanks @shetzel, the test class helped me !    :)


feat: Improve ThemeProvider rendering performance

Little performance improvement
Not an objective comparison of performance:
Render time without memoization (second render)

Render time with memoization (second render)

@sajadevo


Fix container alignment on divine activities for all ages page

I would like to work on this issue under gssoc'23

ok @karthiknadar1204

@akshitagupta15june You can close this issue,someone seems to have already resolved this issue.
Thank you


make: install - remove -D for better cross-platform compatibility

install -D isn't available on OSs such as macOS and others.
using mkdir -p is more cross-platform friendly.

fixes  #25

Was there a reason this wasn't merged? This fix works for me @jb55

its a draft so I didn't look at it

will merge


new GM1 files exporter/importer(need help)

Hello Guys,
id like to make a new GM1 files Exporter/importer for making new Texture packs in Stronghold Crusader. I found a link to the following webside (https://stronghold.fandom.com/wiki/GM1_file_format) where the GM1 File is listed which bytes to read and for what they are standing. But i have some troubles to understand all of it, maybe someone can help me to find out what bytes to read after the FileHeader.

Thx for Helping

This is a very important and useful program will be! Milestones bless you! I am very glad that you are making a replacement for that program. She was buggy. Essentially, I unfortunately will not help. But thank you very much!
Это очень важная и полезная программа будет! Вех благ тебе! Очень рад что ты делаешь замену той программы. Она была глючная. По существу я к сожалению не помогу. Но большое спасибо!

upon my research to find a better program to work with the gm1 files I came upon this information as well granted i have no idea how to even start understanding it but the guys who made the stronghold europe mod might have some knowledge about it considering they managed to do a couple of things that didnt seem possible with the image toolbox program like resizing some images inside the gm1 files etc. (in case they are still active) https://www.moddb.com/mods/stronghold-europe

Hello Guys,
im back and i have now a little bit more i can read from the gm1 files:
File Header
Palette
Image offset list
Image sizes list
Image Headers
Images as ByteArray.
The only thing I do not understand is how to use the Pallete, the byteArray from the img to create the rgb Picture, How are the palette, and the byte array connected? The Pallete have a size of 5120 bytes and store the RGB Colors, and somehow the Bytearray have the Index of the color.
Maybe someone have an idea or a good website that explain how img stored in bytes with a palette? I tried now different Things. :/
If I get this done I have the pictures for editing :)

Maybe this helps you:
https://github.com/metalvoidzz/Sourcehold/blob/master/src/Parsers/Gm1File.cpp

Thank you Sh0down,
i didnt found the git on my research, that help me a lot now.

Hello Guys,
I can now open the GM1 Files. The Program have no functions yet, but I got a step closer for editing the images. Only one thing I’d like to know, how many of you use only Linux? Maybe I Code the program in Java or something like that so all of u can use it, not only windows User. ;)
A First Preview picture, it is not so pretty, because i used plenty time to decode that gm1 files and understanding it.

@Gaaammmler Wow !!! 0_0

I made now a git for the project so we can close the issue here now: https://github.com/Gaaammmler/Gm1KonverterCrossPlatform


Combination of Distinct and Offset does not work in v3.14.0

Describe the bug
After upgrading Cosmos DB SDK to the latest version, one of my queries stopped returning the data and now also causing an infinite loop. Removing Distinct or the OFFSET 0 LIMIT 15 part from the query makes SDK return the data again. I also tried versions [3.6.0 - 3.13.0] and they worked fine.
To Reproduce
var result = new List<CosmosDto>();
var query = new QueryDefinition("SELECT distinct c.Version, c.MetaData FROM Collection c ORDER BY c._ts DESC OFFSET 0 LIMIT 15");
var iterator = container.GetItemQueryIterator<CosmosDto>(query, requestOptions: requestOptions);
while (iterator.HasMoreResults)
{
    var moreResults = await iterator.ReadNextAsync();
    result.AddRange(moreResults.Resource);
}

Expected behavior
ReadNextAsync() should return the requested data back.
HasMoreResults should return false when SDK fails internally for whatever reason.
Actual behavior
ReadNextAsync() returns OK status but Resource value is an empty array.
HasMoreResults always stays true.
I validated the query through Data Explorer in Azure and that returns all the data correctly.
Environment summary
SDK Version: 3.14.0/3.15.0-preview
OS Version: Windows

I was not able to reproduce the issue. Please provide a sample program that reproduces the issue. Something that inserts the required data set and runs the query with your exact query request options.

Thanks for looking into this. Here is my Program.cs file:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.Azure.Cosmos;
using Newtonsoft.Json;

namespace CosmosSample
{
    public class Program
    {
        private static readonly Random Random = new Random();

        private static async Task Main(string[] args)
        {
            // Create client, database and container.
            var client = new CosmosClient(
                "https://localhost:8081",
                "C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==",
                new CosmosClientOptions
                {
                    ConnectionMode = ConnectionMode.Direct,
                    AllowBulkExecution = true
                });
            var databaseResponse = await client.CreateDatabaseIfNotExistsAsync("SampleDb");
            var containerResponse =
                await databaseResponse.Database.CreateContainerIfNotExistsAsync("SampleContainer", "/Metadata/BatchId",
                    20000);
            var container = containerResponse.Container;

            // Create Data.
            var concurrentTasks = new List<Task>();
            var batchIds = Enumerable.Range(0, 500).Select(x => Guid.NewGuid()).ToArray();
            for (var i = 0; i < 100000; i++)
                concurrentTasks.Add(Task.Run(() =>
                {
                    var cosmosDto = new CosmosDto
                    {
                        Id = Guid.NewGuid(),
                        Metadata = new CosmosDto.MetadataDto
                        {
                            BatchId = batchIds[Random.Next(0, batchIds.Length)]
                        }
                    };
                    container.CreateItemAsync(cosmosDto);
                }));
            await Task.WhenAll(concurrentTasks);

            // Query Data.
            var result = new List<CosmosDto>();
            var query = new QueryDefinition(
                "SELECT DISTINCT c.Metadata FROM SampleContainer c ORDER BY c._ts DESC OFFSET 0 LIMIT 15");
            var iterator = container.GetItemQueryIterator<CosmosDto>(query);
            while (iterator.HasMoreResults)
            {
                Console.Write("Querying Data... ");
                var moreResults = await iterator.ReadNextAsync();
                result.AddRange(moreResults.Resource);
                Console.WriteLine(
                    $"Retrieved {moreResults.Resource.Count()} records. Cost: {moreResults.RequestCharge} RUs.");
            }
        }
    }

    public class CosmosDto
    {
        [JsonProperty(PropertyName = "id")]
        public Guid Id { get; set; }

        public MetadataDto Metadata { get; set; }

        public class MetadataDto
        {
            public Guid BatchId { get; set; }
        }
    }
}

And here is my csproj file:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.14.0" />
  </ItemGroup>

</Project>

With this sample program I noticed that the more data I generate the longer SDK is going to keep looping and retrieving 0 records which is why it seems like an infinite loop in our environments that have millions of records. I tried 3.13.0 again and that SDK made only 1 request.

@bchong95 were you able to replicate the issue with my sample program?

Can you try increasing the page size to see if that speeds up the execution?

I updated the sample a bit to include the extra console outputs. Here are the sample program runs with page sizes 5, 50 and 500.

@bchong95 I just tried the latest SDK version (3.17.0-preview) that was supposed to fix this issue but I'm still seeing unexpected behavior (although this version of the SDK makes less calls to the database to retrieve the same data). Let me know if you are unable to reproduce the issue.

@bchong95  @neildsh  Any comments on @bernarden findings on 3.17.0-preview?

Hi @bernarden, this is expected behavior based on the interface:
public override async ValueTask<bool> MoveNextAsync(ITrace trace)
This returns true if there are any results and false otherwise. So you cannot return false on the last page, because then the last page would not be read. This results in one extra call to MoveNextAsync that returns immediately.

Hi @neildsh,
These are the issues that I see with the image above:

Why does SDK make the first 4 calls that return no data back but still cost 74.16 RUs.
The query attempt that actually returns the data back costs 0 RUs.
I haven't looked at the internals of this SDK but my expectation is that the iterator should know that it already returned the required number of documents based on the limit specified. This should result in just one call to iterator.ReadNextAsync() in this example instead of 6..

@bchong95 @ealsur @neildsh @sboshra Why was this issue closed?

Hi @bernarden ,
This is expected. Sometimes query results will be split over multiple pages. Each page's results is generated by a separate query execution. When query results cannot be returned in one single execution, Azure Cosmos DB will automatically split results into multiple pages. Each of these pages would have a separate RU charge, even if no records are returned.
Here are some examples for how to iterate through multiple pages of query results: https://docs.microsoft.com/en-us/azure/cosmos-db/sql-query-pagination#handling-multiple-pages-of-results
You should loop through all the query pages to get the results. The total RU charge for the query is the sum of the RU charges for each individual page.

Fine. Let's call them features.

One thing I want to recommend is rewriting the query to SELECT DISTINCT VALUE c.Metadata FROM c ORDER BY c.Metadata OFFSET 0 LIMIT 5. You might see better results, since we can stream results out.

In general the empty pages are to satisfy your sort order on _ts. The client needs to grab one page of records from each partition and then sort the results client side. Until then it's forced to pass back empty pages to give you a preemption point for the query. On the 5th page we finally have one page from each of the 4 partitions and we can serve the ORDER BY condition and that's when we return you the 5 documents. You can look at the CosmosDiagnostics to get a better sense of this.


Constant type validation

Currently it's possible to do this:
struct Foo {
    1: required bool bar = 0
}

This will always fail when Foo is serialized because 0 is not a bool. This should be type checked at compile time.

Duplicate of #31.


restfox: Add version 0.1.0

Add Restfox - an offline-first, minimalistic alternative to postman/insomnia/hoppscotch.
Closes #12065.

[x] I have read the Contributing Guide.

/verify

As the maintainer of this software, I'd love to see this merged.


Cargo test DYLD error

On version 22413d2, cargo does not pass its tests because of a library not being able to be loaded.
$ cargo test
 Compiling hamcrest v0.1.0 (https://github.com/carllerche/hamcrest-rust.git#2b9bd6cd)
   Compiling cargo v0.1.0 (file:///Users/tim/cargo)
open     Running target/cargo-39287a133529d146
dyld: Library not loaded: /opt/local/lib/libcurl.4.dylib
  Referenced from: /Users/tim/cargo/target/cargo-39287a133529d146
  Reason: Incompatible library version: cargo-39287a133529d146 requires version 8.0.0 or later, but libcurl.4.dylib provides version 7.0.0
Process didn't exit successfully: `/Users/tim/cargo/target/cargo-39287a133529d146` (status=5)

The version of curl I have is the latest MacPorts has to offer, and I believe even the latest that curl.haxx.se has.
$ curl --version
curl 7.39.0 (x86_64-apple-darwin14.0.0) libcurl/7.39.0 OpenSSL/1.0.1j zlib/1.2.8 libidn/1.29
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smtp smtps telnet tftp
Features: IDN IPv6 Largefile NTLM NTLM_WB SSL libz TLS-SRP

It looks like something is requesting a version (>= 8.0.0) of libcurl that doesn't exist.

I believe this is probably because pkg-config detected a libcurl library at /opt/local/lib but your DYLD_LIBRARY_PATH didn't have that directory in your path, so the generated binary was linked against one library but then ran with another, causing the error.
I think that this will be fixed by just adjusting your DYLD_LIBRARY_PATH, but please feel free to reopen if it reproduces!


Rework task switcher and add pinning.

Task switcher applet should get a complete rework because current code and design is hard to fit into the panel as it likes to get other widgets "out of bounds". And pinning window buttons would be a great feature to have that will compensate for lack of system tray.

Moved to 1.0 because current implementation randomly broke.

Never mind, it works again. Please don't break again.


feat: support setting an async executor provider

The Spanner Async API uses an ExecutorProvider for producing rows for an AsyncResultSet. The default that is automatically created is fine for most use cases, but did not allow users to override the default settings that are:

a pool containing at most 8 threads
threads automatically time out after 1 minute if they are not used

This PR adds the possibility for users to supply their own ExecutorProvider to use with the async API.
Fixes #1262

Do you know if there are any metrics available for the thread pool? I think we should expose thread pool usage in cloud monitoring for the default executor.

The standard executor services in Java do not expose any metrics, so we would need to add that ourselves (or add some open source library, there are a couple that do this). I'll add a feature request for it to the repository.


Incompatible with @ianvs/prettier-plugin-sort-imports when using prettier.config.js

What version of prettier-plugin-tailwindcss are you using?
v0.2.8
What version of Tailwind CSS are you using?
v3.3.2
What version of Node.js are you using?
v18.8.0
What package manager are you using?
Yarn v1.22.19
What operating system are you using?
macOS
Reproduction URL
https://github.com/chrissantamaria/prettier-plugin-tailwindcss-sort-order-bug
Describe your issue
I noticed that, despite being listed as a compatible plugin in the README, @ianvs/prettier-plugin-sort-imports is incompatible with prettier-plugin-tailwindcss. With the Tailwind plugin listed last in the plugins array (as instructed in the README), it still takes precedence over the sort plugin and effectively disables it.
Notably, this only occurs when using a JS-based prettier.config.js file (where plugins are require'd) rather than a JSON-based .prettierrc. I suspect this is due to the require changing how plugins are loaded, but I'm not familiar with the internals of either plugin to be sure.
Some alternatives I tried:

using @trivago/prettier-plugin-sort-imports instead - this has the same issue
using a different package manager - npm v8.18, Yarn v1.22 and pnpm v8.3 all have the same issue
using prettier-plugin-tailwindcss v0.2.3, as this was the first version to officially support @ianvs/prettier-plugin-sort-imports - no luck
creating a custom plugin combining aspects of both - this actually did work, but is far from elegant

If this is expected functionality, it may be a good idea to make a note of the differences between prettier.config.js and .prettierrc in the README (especially given that it shows examples using both).
(this is a duplicate of a discussion I opened a few weeks ago - didn't get any traction there, but if you'd rather move discussion back feel free to close this!)

Hey, thanks for reporting this one! I've merged a fix in #159 that should resolve this.
Could you install our insiders build and give it a test?
npm install prettier-plugin-tailwindcss@insiders

tested on my reproduction repo, works great! thanks for the quick fix :)

this solution isn't working for me :(


Custom headers issue on two different hosting environments

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
arn:aws:amplify:ap-northeast-1:476944795571:apps/d33dvg9x53pe0j
AWS Region
ap-northeast-1
Amplify Hosting feature
Custom domain
Frontend framework
Other
Next.js version
N/A
Next.js router
N/A
Describe the bug
My app has 2 environments. One is "main" (for production) and the other one is "staging".
After I created a new custom header by edit the customHttp.yml on AWS portal UI, main will auto take effect immediately about the new headers while staging will take effect until the app be redeployed.
Why there are difference between two environments?
Expected behavior
Both should need redeploy to let them taking effect the new headers.
Reproduction steps

Create new custom headers in AWS Amplify console and Save.
Staging environment takes effect while main will not.

Build Settings
No response
Log output
N/A
Additional information
N/A

Are you able to open a support case so we can look at the exact details of your app? Thank you


Multiple IncludeMany

I have a model with multiple nested collections that I'd like to populate in a single query.
Is there any reason we shouldn't be able to perform multiple IncludeMany's?

No reason, other than the significant complexity, which this library really isn't designed for. Entity Framework is more suited to these types of things. In hindsight I probably wouldn't have implemented this.


Add funding_uri to gemspec

I noticed that the project already has a FUNDING.yml. This PR adds the funding_uri to your gemspec to help increase visibility using the bundle fund command in Bundler.

thanks!


Azure private cluster and KeyVault not working

I am trying to setup the External Secret within an Azure Private Cluster and Service Principle. But getting below error in the pod --
ERROR, Authentication failed to complete due to the following errors:AuthenticationError: An error was returned while authenticating to Azure Active Directory (status code 400).More details:{ "error": "authority_not_found", "errorDescription": "The specified authority URL was not found."}AuthenticationError: An error was returned while authenticating to Azure Active Directory (status code 400).More details:{ "error": "invalid_request", "errorDescription": "Identity not found"}
This AKS cluster is private with AD + RBAC enabled.
I have create the default secret i.e. azure-credentials
cat <<EOF | kubectl apply -f -
{
"kind": "Secret",
"apiVersion": "v1",
"metadata": {
"name": "azure-credentials",
"namespace": "kubernetes-external-secrets"
},
"data": {
"clientid": "$clientid",
"clientsecret": "$clientsecret",
"tenantid": "$tenantid"
},
"type": "Opaque"
}
EOF
This SP has the Reader role on the KeyVault.
But i guess it is not even reaching KeyVault. Please suggest if i am missing any configuration.
Thanks.

There a many possible problems:

misconfigured the keyvault name in the CustomResourceDefinition
dns misconfigured
the sp must be in the access policy

Hope it ll help.

I verified the above items and they all look good to me.

keyvault name is fine in CRD
I exec in pod  and it is able to nslookup the keyvault dns. Are you referring to any other dns ?
SP is configured with List and Get access policy on the keyvault.

Please help experts.


docs: Fix path to bindings.js

A recent commit moved bindings.js to a different directory, which
broke the docs build.  This commit updates the path in the docs
Makefile.

Did this in a separate PR so that I can make sure it's working correctly there by verifying that the Travis build on that PR fails: https://github.com/kelda/kelda/pull/1181


feat(sdk): show user preferences and allow user to switch themes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.52%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10245

Relevant Lines:
107615

💛  - Coveralls


prop-types Validating external propTypes (eg. decorators)

This is something that comes from loggur/react-redux-provide#1 as propTypes are used to actually define data that will be provided to the component like this:
@provide({
  list: PropTypes.arrayOf(PropTypes.object).isRequired,
  pushItem: PropTypes.func.isRequired
})
export default class GoodTimes extends Component {
}

That doesn't coop well with this rule unfortunately. I am wondering if there is a way how to analyze this and read propTypes from higher-order component / decorator also.
I have noticed some undocumented customValidators, but I am not sure how does that works. If I understand correctly it accepts list of props that will be ignored?

I am also wondering the same thing, if there's a good way to avoid needing to add them all manually as exceptions.  In my case, I'm using a formsy-react decorator, and don't want to get linting errors on the methods it provides on this.props.

I also run into this issue when I am using acdlite/recompose. It turns out that moving propTypes up to a HOC / decorator is not only a sugar but also necessary. For example, when a component is wrapped in a HOC, one can not get its propTypes from outside unless its propTypes is declared in the outermost HOC.
// set propTypes in the component
@pure
class Foo extends Component {
	static propTypes = {}
}
expect(Foo.propTypes).to.be.an('undefined');

// set propTypes in the outermost HOC
@setPropTypes({})
@pure
class Bar extends Component {}
expect(Bar.propTypes).to.be.an('object');

I'll be happy to fix the rule for this but I've never used react-redux-provide, formsy-react or recompose.
Is there any common pattern on which we could rely?

@yannickcr
Here's basic example for using bem modifiers:
//bem.js
export function BEM(blockName) {
	if (typeof blockName !== 'string') {
		throw new Error(ERROR_DECORATOR_BLOCKNAME_VALIDATION);
	}

	return function(target) {
		if (typeof target !== 'function') {
			throw new Error(ERROR_DECORATOR_TARGET_VALIDATION);
		}

		if (target.prototype instanceof React.Component) {
			if (!target.propTypes || target.propTypes && !target.propTypes.modifiers) {
				target.propTypes = Object.assign({}, target.propTypes, {
					modifiers: React.PropTypes.arrayOf(
						React.PropTypes.string
					)
				});
			}
			if (!target.defaultProps || target.defaultProps && !target.defaultProps.modifiers) {
				target.defaultProps = Object.assign({}, target.defaultProps, {
					modifiers: []
				});
			}
		}

		target.prototype.bem = bem.bind(null, blockName);
		return target;
	};
}

//table.jsx
const CN_TABLE = 'table';

@BEM(CN_TABLE)
export default class Table extends React.Component {
	render() {
		return (
			<table className={this.bem(this.props.modifiers)}>
				<TableCol/>
				<TableHead/>
			</table>
		);
	}
}

any progress on this topic?

@yannickcr and all I added a simple test case that exposes an issue I came across while working with https://github.com/acdlite/recompose
https://github.com/yannickcr/eslint-plugin-react/pull/762
Hopefully this can help bring attention to this issue.

I'm also running into this issue, where I'm using a simple rest spread to inherit the propTypes of another component. It seems it needs to be an explicit object literal to parse :/
this yields me no propTypes except for "example" for a component:
import ExternalComponent from "somewhere";

export default MyComponent(props) => {
  <ExternalComponent {...props}></ExternalComponent>
}

MyComponent.propTypes = {
  ...ExternalComponent.propTypes,
  example: PropTypes.string
}

We need this !

PS: I'm right now using the ignore option of react/prop-types as a workarround for my decorated proptypes

@yvele I'm trying to do this but struggling to get it working, could you show me what your .eslintrc looks like?

@giuseppepaul Sure!
"rules": {
   "react/prop-types" : ["error", { "ignore": ["foo", "bar] }]
}

Just to leave another option, I export the proptypes for a decorator then destructure them into the connected class.
Decorator
...
...

export const authPropTypes = {
  authorize: PropTypes.func,
  isLoggedIn: PropTypes.bool,
  login: PropTypes.func,
  logout: PropTypes.func,
  userProfile: PropTypes.object
};

export default function withAuth(ComposedComponent) {
  ...
}

Decorated:
...
import withAuth, {authPropTypes} from 'decorators/with-auth';

@withAuth
class Header extends Component {
  static propTypes = {
    checked: PropTypes.bool,
    toggleMenu: PropTypes.func,
    ...authPropTypes
  }
...
}

Any progress on this? It's so annoying to duplicate all the component proptypes around the codebase or importing/spreading them all over. 😔

Would be great to have this.


[html] Autoclose of tags plain not working

VSCode Version: 1.21.1
OS Version: 10.13.3

Autoclose of HTML element are just plain not working in VSCode. I discovered this specifically in a JSX file, but it also seems to not be working in HTML files too. As in, I will type <div>FooBar</ and the </div> will not autocomplete. Also, typing <div> will not automatically insert a </div>. I would expect at least one of these functionality to work out of the box in VSCode. Nope, not working for me.
I have tried reading through as many GH issues related to my problem as I can, including #34307. I have also tried launching VSCode with all extensions disabled. Still not working.

JSX and HTML are different code bases. Please file separate issues.
I'm replying for HTML here, where we automatically add </div> both when typing <div> as well as </.

If this doesn't work for you, check that "html.autoClosingTags": true is configures.
If this is not the problem, please add a small code sample that shows the problem.

I decided to nuke my VSCode configuration and start from scratch. I installed the autoclose tag and rename tag plugins, and those seem to work fine for both HTML and JSX.
Thank you for the reply, but I don't think there's further action to pursue here, so I'll just go ahead and close.


Azure B2C reset password

I managed to reach the page in B2C but after the reset password, the new temp password doesn't work

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0576a50-8bfd-ac73-6cfc-5121de4c1ba1
Version Independent ID: df6d7234-db4f-1a15-3010-26bd56d934e8
Content: Self-service password reset in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/user-flow-self-service-password-reset.md
Service: active-directory
Sub-service: b2c
GitHub Login: @mmacy
Microsoft Alias: marsma

Please refer to the Note
This article applies to self-service password reset used in the context of the V1 Sign in user flow, which uses Local Account SignIn as the identity provider. If you need fully customizable password reset user flows invoked from your app, see this article.
It does not cover password reset when going via the Users menu in the Portal to change a users password using an Admin account unless the user is signing back in using the V1 Sign In Flow.
Are you signing in via the Sign In V1 flow after resetting the password via the Portals?
If not, password reset only works using the Password Reset User Flow and will prevent users signing in using any flow other than Sign In V1 flow if their password was reset by an admin via the Portal.


Minor refactor/log change for orderer startup

Type of change

Improvement (improvement to code, performance, etc)

Description
Minor refactoring / log change in orderer startup while investigating (re)start sequence when the system channel is removed, orderer restarted, and the bootstrap method/file are left set instead of switching to "none" and "" for the file.
Related issues
FAB-18230

/azp run

/azp run


CMS does not work with Content Security Policy (CSP). Requires unsafe-eval / unsafe-inline for script-src / style-src

Describe the bug
I have been using Netlify CMS for sites without a content security policy. I am now trying to increase the security of my sites by adding this.
The CSP requires defining what sources are allowed for scripts, styles, frames, objects, etc.
The CSP also blocks things like eval in any JS execution and also generally inline-scripts or styles.
While it is possible to globally allow these things by setting unsafe-inline or unsafe-eval as permitted, this is not recommended, as it defeats the purpose of the CSP.
Here is the CSP I am applying to one of my sites via special file that Netlify recognises on deploy:
/*
  X-Frame-Options: sameorigin
  X-XSS-Protection: 1; mode=block
  X-Content-Type-Options: nosniff
  Referrer-Policy: strict-origin-when-cross-origin
  Content-Security-Policy: default-src 'self'; font-src 'self' fonts.googleapis.com https://use.fontawesome.com https://fonts.gstatic.com; img-src 'self'; object-src 'self' https://www.netlify.com https://identity.netlify.com; script-src 'self' https://www.google.com https://www.googletagmanager.com https://www.gstatic.com https://identity.netlify.com https://cdn.jsdelivr.net; style-src 'self' https://fonts.googleapis.com https://use.fontawesome.com; frame-src https://www.google.com

As you can see, I have already attempted to somehow make anything coming from Netlify permissible, but Firefox states (among other things):
Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”)
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”)
To Reproduce
Deploy any site to Netlify with a Content Security Policy which does not permit unsafe-eval or unsafe-inline
Expected behavior
Once Netlify has been added as permitted source for scripts, styles, etc. for this to allow loading the CMS. This may require a way to load the Netlify CMS without an inline-script tag, but I am not seeing this issue with other scripts, like google tag manager.
Eval may be a bigger issue, as that would require a change to the CMS' code and eval maybe unavoidable.
Applicable Versions:
Tested on:

Firefox 65.01, Manjaro Linux
Chrome 72, Manjaro Linux
Chrome 72, Windows 10

CMS configuration
not relevant for this, presumably

I should add that I was able to resolve the inline-issues by using sha256 hashes in script-src (not the ones generated here, but only the ones Google Chrome shows when an element is blocked). The eval issue remains, however.

I tried to create my own local version of the script. It worked until I wanted to add cloudinary with triggers the same issues.
Is there a way around this ?

I second the question, is there any way around having to add unsafe-* stuff in the CSP?

It looks like the issue might be caused by AJV creating a function at runtime to compile JSON schema into executable code. It's described here https://github.com/ajv-validator/ajv/issues/406
One possible solution is to use standalone mode to compile schemas to code at build time.

After a bit more digging, we might have a way to eliminate this problem by compiling schemas during build time.
On https://github.com/netlify/netlify-cms/blob/dbf2920254fb3682e12463a6df8ded4b94b55be0/packages/netlify-cms-core/src/constants/configSchema.js#L364, we'd need to use compiled schema.
To compile schema, we can use AJV Standalone to create executable code that we store as a JavaScript module. There is a Webpack loader that can be used to take care of some of this, but this loader is using ajv-pack which is deprecated.
It looks like the game plan here would be,

Update https://github.com/downace/ajv-json-loader to use AJV 7 and Standalone mode
Configure webpack config to use the updated loader
Refactor getConfigSchema to read value from a module import
$$$

@erezrokah After doing some more digging, coding, and research, we're really close on this, but there is one final stumble that we're hitting.
We were able to completely extract the schema, and build the validateConfig function at build time. This works for our site, but there are cases where it will not work for everyone. Specifically, the schema itself can change dynamically based on widget schemas that are added via registerWidget() https://github.com/netlify/netlify-cms/blob/2877f7983e9b5f4ff0cb2cdaaf6549675af68913/packages/netlify-cms-core/src/constants/configSchema.js#L75
Unfortunately, registering widgets happens in the browser, and so it cannot be known at build-time what the complete schema will be including widget extensions.
It seems to me that the only way this can work correctly is to deprecate registration of pieces of schema along with widgets and instead make the schema for user-supplied widgets sufficiently broad to type-check against any widget config. That's a breaking change and would mean slightly less type-safety for config.yaml, but it also means that it can be deployed with a secure content policy because the entire schema would be known at build time.
We're investing so much effort in this because we really like Netlify CMS, but unsafe-eval is unfortunately a deal breaker for our security team. We'd love to find a way forward here, but not really sure what to do at this point.

Thanks for the additional information @cowboyd, is there a way to put this change behind an option?
Then users should be able to opt-in to the breaking change.
We could always generate the static schema during build, the generate the dynamic schema by default, or let users opt out of the last part if they'd like.

A compromise option that might be viable is to only do dynamic validation if we detect that we need to because there are widgets registered with custom schemas. Widgets registered that do not have any additional schema would not require any dynamic validation.
// defined at build time
import { staticValidateConfig } from './config.schema.json';

export function validateConfig(config) {
  if (Object.values(getWidgetSchemas().find(schema => !!Object.keys(schema)))) {
    // there are custom widget schemas, we can't use the static validation
    // this is the current `validateConfig` function.
    // this will trigger a CSP error unless `unsafe-eval` is set.
    return dynamicValidateConfig(config)
  } else {
    return staticValidateConfig(config);
  }
}

I like that idea @cowboyd 💡 !

@erezrokah I'm having a look at implementing @cowboyd 's suggestion.
There are a couple of places in the codebase where registerWidget is called.
One is in netlify-cms-app where a number of widgets are registered, where a number of widgets are added and in netlify-cms-core where an UnknownControl is registered.
I wonder if you could help me understand if:

The UnknownControl is always registered as a default editor control.
Do we need to account for the widgets in netlify-cms-app to determine if the schema is a dynamic schema or not?

Thanks for your input

Hi 👋

The UnknownControl is always registered as a default editor control.

UnknownControl is always registered, and it's in the "core" since it renders as a fallback when the CMS doesn't find a widget (e.g. someone made a typo in the configuration).
See https://github.com/netlify/netlify-cms/blob/dd8f0050c4e2d646e851da28056456c4b76a5738/packages/netlify-cms-core/src/lib/registry.js#L143
We can assume it will never have a schema.

Do we need to account for the widgets in netlify-cms-app to determine if the schema is a dynamic schema or not?

I think the schemas for those could be evaluated at build time, as netlify-cms-app should not reference widgets outside this monorepo.

@erezrokah I created a PR that includes changes implemented by @dagda1 and has all of the tests passing. There is a blocking the PR that I'll describe in a comment.

With help from @dagda1, I created an example repo that has CSP with Netlify. I created a version of Netlify build that works with CSP. You can find it here https://github.com/taras/create-react-app-csp-strict-example

We still need https://github.com/iarna/iarna-toml/issues/45 to fully eliminate eval.

Any updates here?

I have managed to solve above issue using exclude option.


Upgrade cmake build to grpc 162

Note: we need to change the cocopods files for the test projects because newer version of grpc generate the pb.cc files that require updating the cocoapods configurations. It only impact how we run our tests through xcodebuild, and the actual SDK is not impacted.
There are other various small changes needed to make everything build, i have left comments to call them out. The majority of the changes are coming from generated pb.cc files as a result of protobufcpp upgrade.

Should be good to merge now since we're on track to land SPM support for M145.

I meant the comment above for #12398


Query: Relational: GroupJoin/GroupBy compiler fixes and refactorings:

Include now works with GroupJoin/GroupBy
Tracking now works with GroupJoin/GroupBy
Materializer factories are now strongly typed.
Corrected some project default namespaces.
Simplified compilation/runtime of Include slightly.

@maumar

:shipit:

you can also enable ComplexNavigationsQueryTestBase -> Include_with_optional_navigation (i will add more tests once the change is in)

After adding some tests, I found an issue for a multi level include along with LOJ. In some cases the orderby we generate is (int?)c.Id, l.Id. When we lift the query, those orderbys are added to the projection, but because one of them is wrapped in convert, the uniquefying logic doesn't trigger.
Fix is to simply to remove convert when extracting orderings from a join:
in RelationalQueryModelVisitor -> class OuterJoinOrderingExtractor (line 519 ish)
change:
expressions.Add(binaryExpression.Left);

to
expressions.Add(binaryExpression.Left.RemoveConvert());

@maumar Made changes, thanks.


Provide simple example on a graph problem

Is it possible to provide a simple example of a graph problem such as a travel salesman problem?

Should be possible, I'm not too familiar with standard TSP benchmarks, like say the distribution of pairwise distances. Are there widely recognized libraries that generate these? Or perhaps some standard distribution people sample from?

Thanks for your response.  I was thinking about a simple case like the grid environment. A graph with a few nodes and attributes to the edges, for example in the following image:
.
In the beginning, there are no edges and the task is to add edges to connect A to F with the shortest path. The reward will be the inverse of the path length in this case.  One can also change the reward function to change it a more general graph. If it is not that clear, I can create a simple Env class in a separate branch and we can work together.

Yes that should be straightforward enough. You may want to take inspiration from this simple environment (it's still in a branch but I'm hoping to clean it up and merge all of this eventually).
If you start a PR/branch I'm happy to give feedback.

Hi @LianhaoYin, I have a code base for some graph combinatorial optimization problems (not including TSP but hopefully you may find it helpful): https://github.com/zdhNarsil/GFlowNet-CombOpt


[dependency] Use parent pom commons-lang3 version

Modifications
Use parent commons-lang3 version instead of define it each module
Documentation
Check the box below or label this PR directly.
Need to update docs?

[x] doc-not-needed
(Please explain why)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


storageos pod is not evicted when kube node is NotReady

Hello,
i see that
storageos-daemonset POD is not being "removed" form the NotReady node.
dm103   Ready      master   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.5 LTS   4.4.0-87-generic   docker://17.3.2
dm104   NotReady   <none>   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.3 LTS   4.4.0-87-generic   docker://17.3.2
dm201   Ready      <none>   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.3 LTS   4.4.0-87-generic   docker://17.3.2
dm202   Ready      <none>   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.3 LTS   4.4.0-87-generic   docker://17.3.2
dm203   Ready      <none>   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.3 LTS   4.4.0-87-generic   docker://17.3.2
dm204   Ready      <none>   37d   v1.13.0   <IP_ADDRESS>   <none>        Ubuntu 16.04.3 LTS   4.4.0-87-generic   docker://17.3.2

storageos            storageos-daemonset-h2kzs                     3/3     Running                      0          87m    <IP_ADDRESS>   dm201   <none>           <none>
storageos            storageos-daemonset-hhlz4                     3/3     Running                      0          18m    <IP_ADDRESS>   dm104   <none>           <none>
storageos            storageos-daemonset-jrlcn                     3/3     Running                      0          87m    <IP_ADDRESS>   dm203   <none>           <none>
storageos            storageos-daemonset-n2tqs                     3/3     Running                      0          87m    <IP_ADDRESS>   dm204   <none>           <none>
storageos            storageos-daemonset-s6v88                     3/3     Running                      0          87m    <IP_ADDRESS>   dm202   <none>           <none>

i waited for minuets

Hi, can you provide more details about your deployment? The cluster config file or a description of the storageoscluster resource would be very useful.
If the operator version you're running is from the master branch and not a stable release, this is the right behavior. In #110 we added pod priority class to the storageos pods to make them critical resource, resulting in no eviction. We need this because storage is a critical part of a cluster.
This behavior will be seen only if storageos is deployed in kube-system namespace. For any other namespaces, the pod priority won't be set.

sure,
it is form the master
more storageos_v1_storageoscluster_crd.yaml
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: storageosclusters.storageos.com
spec:
  group: storageos.com
  names:
    kind: StorageOSCluster
    listKind: StorageOSClusterList
    plural: storageosclusters
    singular: storageoscluster
    shortNames:
    - stos
  scope: Namespaced
  version: v1
  additionalPrinterColumns:
  - name: Ready
    type: string
    description: Ready status of the storageos nodes.
    JSONPath: .status.ready
  - name: Status
    type: string
    description: Status of the whole cluster.
      This should
  # be the path shared into to kubelet container, typically:
  # "/var/lib/kubelet/plugins/kubernetes.io~storageos".  If not set, defaults
  # will be used.
  # sharedDir:
  # kvBackend:
  #   address:
  #   backend:
  # nodeSelectorTerms:
  #   - matchExpressions:
  #     - key: somekey
  #       operator: In
  #       values:
  #       - nodefoo
  # tolerations:
  #   - key: somekey
  #     operator: "Equal"
  #     value: nodefoo
  #     effect: "NoSchedule"
  # resources:
  #   limits:
  #     memory: "1Gi"
  #   requests:
  #     memory: "702Mi"
  # disableFencing: false

---
apiVersion: v1
kind: Secret
metadata:
  name: "storageos-api"
  namespace: "default"
  labels:
    app: "storageos"
type: "kubernetes.io/storageos"
data:
  # echo -n '<secret>' | base64
  apiUsername: c3RvcmFnZW9z
  apiPassword: c3RvcmFnZW9z
  # Add base64 encoded TLS cert and key below if ingress.tls is set to true.
  # tls.crt:
  # tls.key:
  # Add base64 encoded creds below for CSI credentials.
  # csiProvisionUsername:
  # csiProvisionPassword:
  # csiControllerPublishUsername:
  # csiControllerPublishPassword:
  # csiNodePublishUsername:
  # csiNodePublishPassword:

my namespace is : storageos  , made no changes so far in the files i got from master

when the "node" removed form the cluster, it is shown in the "kubectl get pods"
, but using "describe" - the pod it is not ready,
i think at this time it needs to be evicted.
please correct me if there are other thoughts  or considerations

In that case, I don't think there's anything wrong or anything that can be done. It's the k8s scheduler that makes decisions about eviction based on various factors. Our concern is try to not get evicted as much as possible. We don't have control over the scheduler's decision and I don't see anything bad with it. Usually the k8s scheduler takes action when a node is not available after a minute or so. Maybe waiting for some time will get the pod evicted automatically. But again, it doesn't matters if it's running or gets evicted. StorageOS is running as a DaemonSet on all the other available nodes.
If an instance of storageos is unhealthy, storageos is usually aware of that and takes the necessary actions to failover and move volumes to other healthy nodes.
You can check the state of storageos nodes using the storageos cli command storageos node ls.

Also, kubectl describe stos example-storageoscluster will show you the description of your current status with all the active nodes and their health.

if i enable/put the node back to the cluster, the container does not start ( restart ) properly  - that is what i saw yesterday.
if i evict the pod manually ( force pod delete )and then add the node back, Deamonset restarts container, then  container start successfully
if i add / edit      "tolerations:"  for the pod :
 kubectl edit pod storageos-daemonset-jrlcn -n storageos

with
tolerationSeconds=3 - for example

right before i remove the "node", pod get evicted successfully, and then pod restarts successfully as well when  the "node" added
that is what i saw yesterday, if you want me to repeat, please let me know

In that's what's happening we can add tolerations for all the resources, something like this in the pod spec:
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 60
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 60

That should improve the recovery delay for all the pods.

yes, what file needs to modified ?  or it is in operators source code ?

To first test it, you can directly edit the daemonset resource and add the toleration in it.
If it results in the right behavior, you can add those toleration in the cluster spec like this.
We don't have any default tolerations at the moment. This type of toleration to improve the recovery time could be good to be default toleration, but maybe sometimes we would like them to be overwritable.  For adding defaults, we can add those tolerations to addToleration() function. This function is shared across all the other resources, so that would be good. But for now, I think we should try adding the toleration in the cluster resource manifest file. Need to think more about better ways to have some default overridable tolerations and test more.
Thanks for highlighting this issue.

i agree,
if you test , and see different beaver,  please let me know
since "node down" can be possible event that we need to heal, I think evicting the pod make scene
and to my taste,-  as soon as possible, then restarting it then the node is back
please share if this works well from storageOS point of view

I tried this and I'm afraid we can't do much when it comes to DaemonSets.
As per https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions

DaemonSet pods are created with NoExecute tolerations for the following taints with no tolerationSeconds:
node.kubernetes.io/unreachable
node.kubernetes.io/not-ready
This ensures that DaemonSet pods are never evicted due to these problems, which matches the behavior when this feature is disabled.

We can't set the toleration time. I guess we have to wait for the k8s scheduler to automatically detect and restart the DaemonSet pod.

more info here :
https://docs.openshift.com/container-platform/3.11/admin_guide/scheduling/taints_tolerations.html :
Pods that tolerate the taint without specifying tolerationSeconds
in their toleration specification
remain bound forever.


Postgres env secrets

Description of changes

This change should fix staging, instead of using harded username for production database we should be using the values listed in the kubernetes secrets which are namespaced.
Issue Resolved

Fixes Staging?
Summary:
Apparently both production and production-staging pods are using their own namespaced secrets storage. The secrets had a 2 values that were of importance:
POSTGRES_HOST and POSTGRES_PASSWORD
POSTGRES_HOST contained a different value, and in AWS it was shown that both of those exist and were paired correctly.
But in AWS the username for each was different and the k8s secrets showed they both used the same name as indicated in the config file.
Additionally they both used the same POSTGRES_PASSWORD but after inspecting our credentials management it was seen that prod and staging have two different master passwords.
Prior to merging this I'm going to:

add POSTGRES_USER environment variable to each namespaced secrets store.
modify POSTGRES_PASSWORD in staging to use correct value
deploy this codebase to staging and see if it fixes the issue.
merge this to prod.

I don't know how to do 3. Modifying 1 and 2 will not affect either environment until this is merged and changing 2 on staging isn't going to hurt us since until we merge this the username won't be valid.

Yeah if this works I'll try that.


Feature request: retry artifact publish

Occasionally we'll run into network hiccups when publishing artifacts via the artifactoryPublish task, it would be useful to be able to specify a retry count

Opened support ticket #78132 for followup.

@rspieldenner and @emkidwell,
A retry mechanism for both uploads and downloads is implemented since version 2.7.5 of the build-info dependency. The default value for max retries is 3.

We are running a version of the gradle plugin with a new enough bubild-info-extractor to have the retry logic. We're still occasionally hitting 503s from artifactory that don't get retried or are retried so fast to not be able to get past the hiccup.


Dosn`t display chosen value in filter field

In DSW dashboard we can`t see the chosen value for Filter

done in 3.1.14


Fix #1574, Proxy health check does not respect hostname when upstream Host header is configured

Fixes #1574

Change NewStaticUpstreams func signature to add the host string as a parameter
Change all usages of NewStaticUpstreams to pass "" for the new parameter
Change staticUpstream.HealthCheck struct to store the host string
Change NewStaticUpstreams to set staticUpstream.HealthCheck.Host
Set req.Host if upstreamHeaders includes Host with the {host} placeholder

Still needs tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

That's odd, the build from Travis CI had a spelling error from outside my changes. Hopefully I'm not stepping on any toes by fixing it.

Hey,
great work!

For the test; Maybe we could do it like for the insecureSkipVerify and test if the headers and host are sent?
About changing the function signature. I'm fine with it, just as an idea, wouldn't it be better to use the whole Caddy config as a parameter?

Regarding the func signature, I was just thinking principle of least privilege, only pass the info it needs. That would probably be fine though. A step further, we could pass the controller in (since we can get the config with the controller)?
Thanks for the comments, I'll work on it later today,

You are right ✌ You should pass at least information possible into the middleware.
Otherwise there would be the danger, that the configuration could be changed from inside the middleware. So let it, like it is.
Just the comment would be nice, and of course the test....

Alright, so I added the test and improved the comment for NewStaticUpstreams.
I also realized that I could improve flow by doing the string replace in NewStaticUpstreams instead of during the actual HealthCheck() (very marginal efficiency gain), because it shouldn't change because it's based off config.
Also, I took the liberty of cleaning up your test @pbeckmann, I hope that's not a problem - changes isv_tests to tests and made the error messages uppercase, for consistency.
Apparently the build failed on Travis CI, but I don't understand why.
The command "diff <(echo -n) <(gofmt -s -d .)" exited with 1.
What's that about? :thinking:

Hello @francislavoie,

Apparently the build failed on Travis CI, but I don't understand why.
The command "diff <(echo -n) <(gofmt -s -d .)" exited with 1.
What's that about? 🤔

This should help you 😄

@elcore aha, thanks. I'm still new to this. :smile:

@elcore aha, thanks. I'm still new to this. 😄

You are welcome 😄 ; I wish you a nice time in the world of Go and Caddy!

Fyi this PR also includes https://github.com/mholt/caddy/pull/1586 (I fixed it here because I didn't like Travis CI complaining), hope that won't be a problem.

Thanks @francislavoie! Would you like to be added as a collaborator so you can help preview pull requests, fix issues, etc, on a branch rather than in a fork? (We just ask that all PRs have at least one other collaborator approve before merging assuming the PR is not large; and we squash most PRs with multiple commits - we ask that large PRs get spliced up into multiple smaller ones).

Sure! That'd be cool. :+1:


The verion 2.0 (extended-csv-dataset-config-2.0) does not work with JMeter 5.5 or 5.6.2

Hello @rollno748 - The JMeter script which has the extended csv data set to any request in the script, does not open in JMeter and shows a dialog to install the plug-in first. Up on installing the plug-in "extended-csv-dataset-config-2.0" and restarting JMeter, it still does not open the script and shows the same message to install the plugin.
I am assuming JMeter is not detecting the installed plug-in "extended-csv-dataset-config-2.0" (still shows in available plug-ins tab of plug-in manager after installation too).
Note: I removed the jar file 2.0 from ext folder of lib directory and replaced with version 1.1 (di-extended-csv-1.1.jar) and it works fine.
So the problem is with version 2.0

Hi
Thanks for reporting this issue - Can you please provide a sample jmeter.log /jmx file to investigate furuther

Hi,
I did a quick try on JMeter-5.5 where i don't see any issue with it

JMeter-5.6.2

I dont see any issues with it - Can you please share your jmeter.log file ?

If you could share the jmeter.log - that would be of great help to suggest you some information

jmeter.log
Here it is and I do not see anything fishy here either!

You have jar conflicts - that might cause this kind of weird behaviour with JMeter
You should fix that first
Try removing the below plugins/lib and give it a try
jmeter-bzm-correlation-recorder-2.1.jar
jmeter-bzm-correlation-recorder-2.0.3.jar
json-20190722.jar

Sure, thanks! I removed the log file now.

The version 1.1 of the extended csv dataset config works fine though! very strange.

Did removing the above conflicts, fixed the issue ?

I haven't tried yet. Will do later today or tomorrow and get back. Thanks though for suggesting :)

Any updates ?

Hi, I tried now and it still did not work after resolving the conflicts. Here is the exception I see:
CannotResolveClassException: com.di.jmeter.config.ExtendedCsvDataSet
Detail:com.thoughtworks.xstream.converters.ConversionException:
---- Debugging information ----
cause-exception     : com.thoughtworks.xstream.converters.ConversionException
cause-message       :
first-jmeter-class  : org.apache.jmeter.save.converters.HashTreeConverter.unmarshal(HashTreeConverter.java:66)
class               : org.apache.jmeter.save.ScriptWrapper
required-type       : org.apache.jmeter.save.ScriptWrapper
converter-type      : org.apache.jmeter.save.ScriptWrapperConverter
path                : /jmeterTestPlan/hashTree/hashTree/hashTree[6]/hashTree/com.di.jmeter.config.ExtendedCsvDataSet
line number         : 3455
version             : 5.5

Hi! I just have put both 1.1 and 2.0 versions of Jar file in ../lib/ext and I am able to open the script now.
Anyways, sounds like this is only an issue on my machine, so fine to close the issue.

Also, thank you for this plug-in. This is great!

Thanks - keep supporting 👍
Please hit a star, if you like it !


Docs: Fix bugs in the documentation

Pull Request Test Coverage Report for Build 109

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 108:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Segfault when output directory does not exist

Hi Dengfeng,
Thank you for your work on this scaffolding approach and software!  I'm excited to see the results.
I wanted to mention that I ran into a segfault when running pin_hic_it for the first time because I (mistakenly) assumed the output directory would be created when the code was run.  I took a look at the core dump and read back through the README, and it became reasonably clear to me that an existing directory was a pre-requisite... but, that initial segfault was not the expected behavior.  So, maybe just mentioning this in case anyone runs into the same issue.
Thanks again for your work!
-brant

Hey brant,
Thanks for trying pin_hic and the suggestion, I have updated the code now it will pop out an error when output directory is not found.  Also pin_hic is not tested on many species so far, not for sure how well it can perform. I would be good if you can give me some feedbacks about the scaffolding results. I will take some time, see if i can improve it.
Best,
Dengfeng.

Hi there!
Thanks for addressing this issue. I am running into the same issue with pin_hic_it. I give output directory and still get segfault. Attaching the log file here for you to check.
Thanks,
Minal
pin_hic.log


Fix: README, Invalid link to key-value vs value store document

The  XXX: When shoould I use the value store against the key-value store. link in the README leads nowhere.

The key-value store uses the value store to provide a higher-level interface like common key-value stores (etcd, ZooKeeper, etc.), where arbitrary data can be stored under an arbitrary name.
The value store is the lowest brick of the architecture, providing the fundamental object named blocks, declined in a few flavors. Those blocks are cryptographically protected, their addresses are chosen randomly to guarantee a homogeneous distribution and prevent XXX(squating) and all operations are atomic, but the caller is responsible for keeping addresses.
For more details you can consult  XXX: When shoould I use the value store against the key-value store.

Yes, the XXX stands for "it's a placeholder until we have a specific page on the website".
I pretty sure we have one now so I'll remove the XXX and fix the link.
Thanks.

Fixed.
Thank you.


Add PhpStorm version to bug report

When a bug happens we have an automatic template used on GitHub, however this template does not include the PhpStorm version.
We should fix this simply by adding the IDE version and what IDE the user is using. (the user could potentially use IntelliJ Idea Ultimate also)

Merged into master.


fix(config): optimize process building

Don't delete branch, need to check changes between current version and this pr changes


[storage-file-share]Migrate storage-file-share to V6 generator

[storage-file-share]Migrate storage-file-share to V6 generator
API view to show interface differences comparing to last GA release is here.

API view is here


Blueprint::timestamps not setup correctly.  Almost backwards.
Problem

So upon table creation both columns are set to 0000-00.00 00:00:00
Then, upon an insert the created_at column sets the current time. Everything is fine so far...
Upon update of the same row however, the created_at column updates again to the current time and the updated_at column never changes from 0000-00-00 00:00:00.

Possible Solution
The correct column attributes for those columns to achieve the desired behavior is:
created_at TIMESTAMP DEFAULT 0
updated_at TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

Essentially, DEFAULT 0 is telling created_at to be NOT NULL. Therefore, when an INSERT INTO query passes NULL to it, it gets the current time and won't update again. However, it looks like you have to pass NULL to the created_at column upon the initial INSERT INTO or it will remain 0000-00-00 00:00:00.
Unfortunatety you can't have CURRENT_TIMESTAMP or NOW() or any combination of those on two TIMESTAMP columns so this is the common work around.
Hope that helps.

@GrahamCampbell Is this a bug?

This laravel migration produces the following schema.

TIMESTAMP ON UPDATE CURRENT_TIMESTAMP is currently being added to the first occurrence of the timestamp field i.e the expired_at field.

This issue keeps coming up here, on the forums and SO. We need to get a resolution to it or at least better PR to tell people about the risks of using $table->timestamps(); and $table->timestamp('fooed_at');

My original problem/case had nothing to do with using $table->timestamps() with an additional $table->timestamp() in the same table. The problem might also crop up in that scenario, however the problem is that you can't call CURRENT_TIMESTAMP twice in a table. So it could be the PHP is trying to do that and MySQL will simply refuse to do it and do the next best thing.
From the MySQL5.5 Manual:

One TIMESTAMP column in a table can have the current timestamp as the default value for initializing the column, as the auto-update value, or both. It is not possible to have the current timestamp be the default value for one column and the auto-update value for another column.

Also, this excerpt seems to reference the problem mentioned by @anishdcruz:

It need not be the first TIMESTAMP column in a table that is automatically initialized or updated to the current timestamp. However, to specify automatic initialization or updating for a different TIMESTAMP column, you must suppress the automatic properties for the first one. Then, for the other TIMESTAMP column, the rules for the DEFAULT and ON UPDATE clauses are the same as for the first TIMESTAMP column, except that if you omit both clauses, no automatic initialization or updating occurs.

It also gives possible solutions here: http://dev.mysql.com/doc/refman/5.5/en/timestamp-initialization.html

I've got the same problem here with using timestamps() in a migration and it was very frustrating when I found out after my application lost (overwrite) some sensitive data in production.
I don't have another TIMESTAMP column in the table. When I update something in the row MySQL always updates to the current time, but doesn't modify the update_at column. This setup just makes no sense on a created_at column, it should be used on updated_at. Please fix the timestamps() method.

This is a serious issue.
I would even go as far as to say the timestamps method should be removed completely for now and the documentation be updated to warn people of the current issue.
As @terdelyi mentioned, if this problem goes unnoticed for a period of time on a production site that may depend on this information bein accurate, it could be very costly to a company or web app.

What version of MySQL?

Personally I think ->timestamps() should just default to ->nullableTimestamps() to solve this issue.

I can tell you 100% for sure we are not removing the method.

Is anyone else in agreement that ->timestamps() should just call ->nullableTimestamps() so that we have a valid default to give to those columns across all versions of MySQL?

mysql  Ver 14.14 Distrib 5.6.28, for debian-linux-gnu (x86_64) using  EditLine wrapper

On the next 5.2 release ->timestamps() will just call ->nullableTimetamps().

We have MySQL 5.6.22 (local), MySQL 5.6.27 (production). I didn't ask to remove this method, just check that does created_at column really need a default "on update CURRENT_TIMESTAMP" instead of update_at. Normally you never refresh created_at data, especially when you update the row.

That is being added by a MySQL configuration option, not Laravel. Anyways, 5.2.14 will now just make ->timestamps() nullable by default.

It was on MySQL 5.6 and MariaDB (5.6) and PHP7 I first noticed the issue.
No I asked to remove it seeing as I personally think this behavior is something that can only properly be implemented in MySQL, with Triggers and such.

Setting the timestamp table to nullable will remove the auto-instantiation of the created_at table, won't it?

If the TIMESTAMP column permits NULL values but its definition does not include DEFAULT CURRENT_TIMESTAMP, you must explicitly insert a value corresponding to the current date and time.

I don't understand your question. The columns shouldn't auto-initialize at the database level. That is handled by Eloquent.

Ok. I wasn't aware Eloquent inserted values into the timestamps. I figured it was trying to use multiple CURRENT_TIMESTAMP attributes to handle it.
Thanks Taylor!

@taylorotwell You're right, that makes sense: "If the first TIMESTAMP column in a table is not specified as NULLable and doesn't have explicit DEFAULT or ON UPDATE value specified, it automatically gets DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP as attributes"
Sorry for the misunderstanding, I've never heard of that before. I also think ->nullableTimetamps()put things right, thanks for the quick fix.

my timestamps gives wrong time what should i do?


EventRegister.exe loads assembly without following assembly redirects

Consider project A (.exe) depending on project B (.dll); project B consumes package C, which brings EventRegister build targets. Both projects A and B are on
.NET Core 1.0.0 (all versions are matching). If project A is upgraded to .NET
Core 1.1.x, while project B isn't, EventRegister.exe will produce
LoaderException, until project B is moved to the same version of .NET Core.

Error MSB3073
The command ""C:.nuget\packages\microsoft.diagnostics.tracing.eventregister\1.1.28\build\eventRegister.exe" -DumpRegDlls @"D:\work\Debug\ux.eventRegister.rsp" "D:\work\Debug\ux.exe" " exited with code 1.

It looks like the code attempted to have .exe.config to be loaded into the app
domain, but the line is commented out.
I suggest revisiting that decision, or maybe roll some kind of custom reflection
using app domain events.

   Basically they can have an arbitrary chain of dependencies that frankly are in the limit unknowable.
Logically, EventRegister wants to do is to treat the IL file like it was data and reflect over it WITHOUT RESOLVING ANY DEPENDENCIES.
There are now tools/libraries that do this (e.g. CCI, ...).   Ideally EventRegster uses one of these.
    It is not clear however, it worth the effort (if someone wants to do that great, but we have not had a request for over 2 years.
Note that there is a work-around for any particular client.   Simply place your EventsSource in a DLL with SIMPLE dependencies (that is it is built with just built in things).   This is always possible since EventSource is PUBLISHING and API, and only USES EventSource tiself in its implementation.
Such a DLL will NEVER cause grief with EventRegister (since it can be loaded 'anywhere'.   It however can be USED from any application with any kind of loader behavior).

Thanks for detailed comment!
The issue with our situation is that our EXE has to directly consume the package (e.g. "X"), which brings EventRegister dependency in. That is, unless ProjectReference style projects would allow us to consume package "X" indirectly via the intermediate "pure DLL", which would take a hit of EventRegister, like you suggest. I'll investigate this.
Do you happen to know the story about this line in Program.cs? I assume there're some good reasons for it to be commented out. Although, I'd expect framework to provide this kind of facility for consumers of reflection APIs...

Do you happen to know the story about this line in Program.cs?

I did not write the funky loading code in EventRegister.   The developer who did is not longer in the group, and wrote it several-to-many years ago so even he may not remember.
Ideally you could get the library package to not take a dependency on EventSource but EventSource.Redist.

Fair enough. Thanks for your time!


Change to fetch head rev with refs/tags

CliGitAPIImpl#getHeadRev(String url) doesn't fetch refs/tags so git-plugin can't handle any tags (ref. https://github.com/jenkinsci/git-plugin/blob/af01132e56f767f7ee944a3b64b17aa3a0c7f198/src/main/java/hudson/plugins/git/GitSCM.java#L583, https://issues.jenkins-ci.org/browse/JENKINS-14917).
From the above, I changed CliGitAPIImpl#getHeadRev(String url) to fetch head revision with refs/tags by appending -t option to git ls-remote.
However I can't predict effect of this change. It should be another new method?

Can you explain the use case you're hoping to satisfy by broadening the search to include tags?
As far as I can tell, the git plugin is able to checkout tags, and build from tags, and refer to tags.  Is there a specific bug you're trying to fix?

My use case is

Use with SCM polling
Specify refspec

Specify tag by branch specifier

It looks doesn't work. In my suggestion, it caused by polling command with git (in this case: git -c core.askpass=true ls-remote -h https://github.com/moznion/sandbox) cannot obtain refs/tags.
(I checked this symptom on docker)
Do I take mistakes?

JENKINS-9713, JENKINS-21952, and JENKINS-23299 all describe cases where a Jenkins build runs with a tag and performs the checkout of the tag correctly.  I have job definitions for each of those bugs and have confirmed they are all able to build a tag of my choice.
Could you review those bug descriptions to see if one of them will allow you to do what you need, without requiring a code change to the plugin?

Thank you for your suggestion but I still can't build with tags even if applied shown solutions.
Maybe JENKINS-23299 is similar to my problem. Is this issue really resolved?
I think SCM polling kicks this method, it calls this, and it calls CliGitAPIImpl#getHeadRev(String url). If it can't fetch tag information by CliGitAPIImpl#getHeadRev(String url) then heads is empty, returns NO_CHANGES so task won't be run. And now looks like CliGitAPIImpl#getHeadRev(String url) doesn't fetch tag information...
FYI, my jenkins environment is following;
Jenkins version: 1.609.2
GIT Plugin version: 2.4.0
GIT Client Plugin version: 1.18.0

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Have you tried enabling "Use local workspace for polling" with the current versions of the plugins?

Sorry, how can I enable "Use local workspace for polling"?

It is an "Additional Behaviour" that you add to the job.

As far as I can tell, JENKINS-23299 is resolved.  My job which was created to verify JENKINS-23299 is enabled and does not build on every polling interval.


Fix stackoverflow

Description
It was hard to find but this code is causing stack overflow.

Purpose
This pull request is a:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Ouch, my bad.
Thanks for fixing it!


Add prettier config to sort tw classes in objects

Do we need to add prettier plugin setup in the readme file as well?

Do we need to add prettier plugin setup in the readme file as well?

for sorting classes for the custom themes?


Glossary of Terms

Glossary of Terms

English
Azərbaycanca

tutorial

accessibility
imkanlılıq

ceclarative
deklarativ

component
komponent

stateful komponent
hallı komponent

render
render etmək

data
məlumat

debug
dibaq

application
applikasiya

external plugins
xarici pluginlər

syntax
sintaksis

expression
ifadə

plain
sadə

techology stack
texnologiya steki

embedding expressions

attributes
atributlar

elements
elementlər

functional component
funskional komponent

class component
klass komponent

composition
kompozisiya

tool
alət

inheritance
varislik

lifecycle

handling events

conditional cendering

operator
operator

reuse

power
dəstəkləmək

mock

callback

tip

note
qeyd

example
nümunə

props
parametrlər

state
vəziyyət

context

DOM
DOM

ref

fragments
fragmentlər

portal
portal

class
klass

Web
Veb

UI
UI (not Azerbaijani İ)

Tick

bundle

package

xaxaxa)) very interesting translations, but somewhere i will change it

https://github.com/reactjs/az.reactjs.org/issues

Add "parent" translation and split react terms from general dev terms

Add constructor and initialization translations

Add "anchor" translation

translate 'package'

Update props and state translation

Add "reset" translation

Translate "crash"

Does anyone here agree that immutable = dəyişməzlik? I have added it to the glossary and currently using it. If someone does not think that this is the correct word, write here so we can discuss it.

Add "wrapped component" translation

Add "runtime" translation

add conditional rendering translation
update "immutable" translation
in my opinion immutable translation correct way is 'dəyişməyən'

I wrote the wrong translation. I am talking about immutability, not immutable.

ok, then i think most suitable variant dəyişməzlik or dəyişilməzlik

Add "interact" translation

Translate bundle and import

"Take the Tutorial" translated as "Dərsiliyi Götür", I think it would be better for understanding translate this to "Dərsliyə başla", and since now a literal translation is being made and it does not look very good

add "maintainer" translation

Add "output" translation

add "pattern" translation

add "instance" translation

add "native" translation

how to translate "local state"? "lokal state" or "daxili state"? or, perhaps "yerli state"?

and what about to inherit? genişləndirmək or varis olmaq?

translation for arrow function, ox funksiyasi?

For arrow function, I wrote arrow funskiyasi because I think ox funskiyasi is not very clear when someone reads through the content.
Inherit is written under “inheritance” in the glossary— varislik. Genishlendirmek is extend.
Are you talking about React state or just rhe technical word. When using React state, I use “state” but when the used context is not about React’s state, I use “veziyyet.” React’s state is kind of like special noun.
Yerli in computer terms is confusing. Daxili = internal. I write it as “lokal” because it is immediately clear to the reader.
For words that do not have clear translations, I try to use azerbaijani words that are commonly used among azerbaijani developers (checking forums and stuff).

Thanks for the answer. So let's summarize.
arrow function - arrow funksiyası
inheritance - varislik
local state - lokal state
But how about the verb to inherit? varis olmaq does not match properly. In Java, for example, they use the keyword extends when class inherits another class. So I suggest using genişləndirmək for to inherit.
By the way ,the State and Lifecycle section is ready. Tomorrow I will recheck it and create a pull request.

Okay, then let's use genişləndirmək for "inherit." Otherwise, yes agreed.

Tomorrow I will recheck it and create a pull request.

Great! :)

Add Asynchronous
Add Imperative
Add suffixes and pronunciation for API

Add node

Why not to use "düyün" for "node"?

@saidfagan Is this word being used in Azerbaijani translation of the computer term "node"? I personally chose "nod" because I thought there is no actual translation of this word. I just checked the word for it in Azerbaijan English Computer Dictionary: http://enaz.online/index.php?id=5531 (node), http://enaz.online/index.php?id=6174 (parent node). We can change them to "qovşaq" but as far as I knew, this word means Junction -- The act or process of joining or the condition of being joined.
The translations for this word is ambiguous at best. Therefore, I created a poll here; so that, we can decide on what to use: https://www.strawpoll.me/17766391.
@Haqverdi, @azizaismayilova, @saidfagan, please vote so that we can decide how to move with this word.

Add "higher order component" translation.

@GasimGasimzada I've never seen this word translated as "düyün", too. Programming related literature is very scarce in Azerbaijani. I just think this translation suits best.
Voted, waiting for the results.

So event handler will be hadisə işləyicisi. But, how will to handle events be? I think hadisə emal etmək suits best.

add translation for default

add translation for bind and binding

add translation for field, like class field

So event handler will be hadisə işləyicisi. But, how will to handle events be? I think hadisə emal etmək suits best.

Its okay. Regarding other translations, where did you add them/

I am currently working on Handling Events chapter. All of this words are from that chapter.

Could you please write the translations, so I can add them?

I suggest:
default - ilkin
bind - bağlamaq
binding - bağlantı
class field - klas sahəsi
Not sure about all of these. Will be glad to hear better translations.

Any ideas about loop? dövr, perhaps?

Add pooling translation.

Add controlled and uncontrolled component translation


Fix typo (syntax error in version index new method)

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1557   +/-   ##
=========================================
  Coverage     87.05%   87.05%
  Complexity     4204     4204
=========================================
  Files           408      408
  Lines         16873    16873
  Branches       1830     1830
=========================================
  Hits          14688    14688
  Misses         1695     1695
  Partials        490      490

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f38d4...228aeb4. Read the comment docs.


feat: added a note about speeches files' loop import mode

I've been trying to fix a bug spotted by @balloonpopper that causes a speech line to be looping forever even after the line was finished. This would happen if you change the volume in the middle of the speech playback : in that case, the AudioPlayer resets the resource in its stream. If that resource was imported with loop flag set to true, then AudioPlayer's finished signal would not be emitted anymore.
This might be a Godot bug, or maybe we're doing something wrong. Until we get more information, we will just encourage users to ensure their speech files are imported with that flag set to false, which solves the issue. Since speech audio files are not supposed to loop, this is a good practice anyway.

This looks good pending @balloonpopper 's suggestion.


High Resolution Viewport Invokes Non-responsive Layout

The side navbar partially covers up the menu icon that collapses the navbar.

When the side navbar is collapsed, there is white space on the left.

Fixed in 70cfedca9ceeb23f702e64805e490111b5d264e3


Add Python-3.10

Fixes #1346

Out of curiosity, why does PYTHON_VERSION need to be updated in qhub/provider/cicd/{gitlab,github}.py? I know @iameskild said it needed to be updated in the issue...
I think there are also a few places in the docs where 3.10 support needs to be mentioned:

setup.cfg: PYPI package tags
docs/index.md: Python version badge

Otherwise looks good to me!


build error

Encountered a build error in Windows 10.
https://gitlab.servapp.ru/kolamba/schat_project

I have checked and the error come from https://pub.dev/packages/quick_notify/versions/0.3.0-dev.0 which does not have update to fix this i will keep continue search about solution

Any solutions found? Would be very nice to get this package working, because i didn't found any other good package with all platform support.


NOTE: I removed the [Where T: class] , and changed to return default(T)

==> you only need the T: class constraint, becuase you wanted to return null.
==> but your valueserializer works any T, so there is no need for this constraint.
Default(T) will return null if T is class.
=======================================
It is causing downstream issues, with calling this function (within generic methods that do not have this constraint) ==> 3rd party libraries, which have generic methods, will not allow you to call your method (since it does not have the constraint)  ==>I created bug:  https://github.com/googleapis/google-cloud-dotnet/issues/2843

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it.

Please review again. I signed it again.
I signed it.

the bot is not seeing my signe cla

It may take a while to come through - I'm not sure. But I'll take a look at the proposed change on Monday - I'm not at all sure about it at the moment.

i resigned the CLA again.  Still waiting to be approved by googlebot

I would just not take any further action at this point. The CLA is irrelevant until we've decided about taking the PR anyway.


Hello

Can I help with coding make me member please I love coding

Hello @frayray909090!
First of all, sorry for the very late reply. This repository is quite new and we haven’t actively monitored comments from outside the team, but we should have!
To your question, you are welcome to contribute! This repository is open source, so you are totally able to fork and modify, and then pull request back your contribution. Github has a pretty good guide on how to do this https://docs.github.com/en/get-started/quickstart/contributing-to-projects . You don’t need special access to be able to contribute :slightly_smiling_face:
Hope this helps! I’ll close the issue, but you can comment more if you have more questions
Cheers
@xaviervia

Well then hello @xaviervia!

We're happy to see your passion and suggestions for Minecraft, though this is not quite the right forum for that :)
This project, ore-ui, is an open source project related to UI development. To ask questions or make suggestion about the game, check out the official Minecraft bug tracker.
Here's the bug tracker for Java: https://bugs.mojang.com/projects/MC/issues/
Here's the bug tracker for Bedrock: https://bugs.mojang.com/projects/MCPE/issues/
Cheers, and thank you again for the interest!


Color syntax in arrow functions

Wrong color syntax in arrow functions without body.

It depends on which color theme you are using. This is what it looks like with my One Dark theme on VSCode as well as compared against Atom.

I'am using One Dark (Sublime Babel)
This problem is present only in classes

In sublime-babel.json, after Line 344, add this:
{ "include": "#literal-language-variable"},
{ "include": "#literal-function-call"},

Please try that out and let me know if it breaks anything for you within classes.

Thanks, that's helped.
Also I noticed one more issue. It is not connected with bug above.

Sorry if this is the way it should be.

That one is expected. The regex inside grammar rules can only act on one line at a time.


Queryable Documentation

On this page:
https://middlemanapp.com/advanced/sitemap/
there is a link to http://rubydoc.info/gems/middleman-core/Middleman/Sitemap/Queryable
Which 404's.
Is there documentation somewhere for querying the sitemap? I'd like to do simple stuff like get all the pages in the /projects folder, with tag "featured" etc.

Ah, queryable is gone in v4. Those docs should be updated.

yikes! gone? is there a replacement system?

Yup, plain old Ruby works for every use-case and is more maintainable.
sitemap.where(path: "/site")

Becomes
sitemap.select { |r| r.path == "/site" }

ok, cool.  thank you.

@tdreyno: I think (?) you mean:
 sitemap.resources.select{ |r| r.path == '/hello'}

ah, yes. I did


Add config specs

What does this PR do?
Add config specs to directory
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Closing in favor of: https://github.com/DataDog/integrations-core/pull/7714/s


catkin_make_isolated: error: unrecognized arguments: --DCMAKE_BUILD_TYPE=Release

Following this tut: http://wiki.ros.org/jade/Installation/OSX/Homebrew/Source
This step ./src/catkin/bin/catkin_make_isolated --install -DCMAKE_BUILD_TYPE=Release
results in catkin_make_isolated: error: unrecognized arguments: --DCMAKE_BUILD_TYPE=Release
Removing --DCMAKE_BUILD_TYPE allows it to proceed, will update if this breaks anything.

The tutorial only contains a single - instead of two as you typed it.


✨ Add support for waveforms from pre-compiled json data

Here's a demo of 2 songs, the most important part for me is to be able to see quiet and loud parts to avoid jumping like in the second example
https://github.com/user-attachments/assets/07d1c91c-d035-406a-b30a-a8237b164ef4

Figured out render issues were related to caching (was using feedbackId instead controlId)


Enable non-root wildcard routes

spin test currently does not find routes that are declared with non-root wildcards.  E.g. /... works, but /users/... does not - it tells you "no route found in spin.toml manifest for request path '/users'".  Given the current limitation to a single component, this isn't a significant restriction, but was a bit surprising when Tim and I tried a non-root route while trying to resolve a different problem.
This PR fixes that, and also updates the routing module to support Spin 2.5 single-segment wildcards (/users/:id/note/...).  Aligning the routing turned out to be a bit more invasive than I'd hoped, but hopefully useful going forward - but I quite understand if this is premature!

The Cargo.lock conflict is because I reverted my rebase onto main after running into #67 and #68, because it was easier to test and debug this way.  Once you're happy with the code (or if those turn out to be quick fixes!), I'll put it back onto main.


Hack4change/task prize methods unification

Thank you for your work on this PR. We are closing it as these changes have been included in PR #XXX, which has already been merged.


/say does not display on Discord if ran by the Server

Messages sent through the console, through a function ran with no context, or as a non-player entity are not sent to Discord.
Messages sent through the console or ran by a contextless function should be sent to Discord with the author "Server" (this is most useful as it allows servers to send messages to Discord from in-game commands)
Messages sent through a non-player entity should either have that entity's name or a generic name

Right, it should not display any message if ran through the say command.

Fair point, I'll think about it


deep-linking

Would it be possible to enable deep-linking on the demo site, e.g. to ensure the menu links give distinct URLs? This would help for sharing, saving links to different parts, as well as to see which links lead to distinct pages.
On a related note, currently clicking on items in the colors category takes me to the page while I'd expect it to also scroll to the appropriate section. After this, I assumed this was the case for other categories as well, and hence skipped over icons not realizing it did have its own distinct section.

Yes, that's on the roadmap, but not a high priority at the moment.
If you would be willing to contribute, pull requests are most welcome.


Single variable simple expressions are not valid

Following program does not work. It says below. But Ideally it should work.
ballerina: invalid template expression: {a}
import ballerina.net.http;
@http:configuration {basePath:"/hello"}
service helloWorld {
@http:resourceConfig {
    methods:["GET"],
    path:"/{a}"
}
resource sayHello (http:Request request, http:Response response, string a) {
    response.setStringPayload(a);
    response.send();
}

}

Issue is still reproducible @shafreenAnfar

Fixed with #9136