Design Thinking Workshop planning for DevSuite

Dev Suite team (Dev Studio, DevSuite, CDK) have a challenge that they need more input from stakeholders outside of Dev Tools.  The team is reaching the point where they really need more input from the other business stakeholders identified above on how they can assist them with their products.
DevStudio Stakeholders:

Bob Davis (PM)
Dennis Golovin
Lala Mohanty
Jean-Francois Maury
DV (Daniel Veillard)
Martha Benitez Angulo

External Stakeholders we need to consider including:

Steve Spiecher
Ken Johnson (or assigned PM)
Rich Sharples (or assigned PM)
Mark Little (or assigned Eng Lead)

Pete raised the idea of Design Thinking and a workshop here, and I wanted
to get you looped in to start talking them through how it might
Verification Criteria:

Talk with PM and ENG about design thinking session and what it consists of
Create plan/proposal for design thinking session with the team, share with team, Pete, Catherine

@muruGanesan update on status for this?

I had multiple discussion with dev/eng team. As per today's discussion with Pete. 3 days design thinking workshop is confirmed and "QC" & "Hypothesis" features will be cover as part of this workshop. I will share the agenda and prerequisites soon.


improve MethodsAroundInterceptor API:add MethodAroundContext over the Interceptor …

Please answer these questions before submitting pull request
Why submit this pull request?

New feature provided
Improve performance

Related issues

New feature or improvement

MethodsAroundInterceptor should have MethodAroundContext  over the Interceptor
so we can pass current span,then we change ContextManager#stopSpan to ContextManager#stopSpan(span) -- for speed up and fail-fast
ref: https://github.com/apache/skywalking/pull/3068

static MethodsAroundInterceptor also need to be support

Why do we need to change this? How much performance does it bring to the agents?
I am not just asking benchmark, I am asking about in the real scenario tests

The change TraceAnnotationMethodInterceptor  in this pr is the use case
After change of TraceAnnotationMethodInterceptor  the code more strong (fail-fast)
and it could improve the performance  if we grid of the invoke  for ThreadLocal
It's another pr I want to do:)

I do know it is related to performance. My question is how much.
Change API will break many things, including document etc. especially we have many plugins today. I have found any real performance issue by using ThreadLocal. Actually, most of plugins wouldn't use this.

I do know it is related to performance. My question is how much.
Change API will break many things, including document etc. especially we have many plugins today. I have found any real performance issue by using ThreadLocal. Actually, most of plugins wouldn't use this.

The change of API is for the future, and it's compatible with the exist plugin (  without change the plugin ).

All these changes, including #3124 , need to be proved necessary. Also need to have multiple PMC/committors support that. I would not make the call here.
You should know, as OSS project, we only add or change API when it is necessary, especially these are all open APIs. You are bringing the extra maintain payload to the community.
Personally, I would support this change.
-1 from me.
cc @apache/skywalking-committers if anyone who wants this, please `+1 explicitly. And explain why and what are the scenarios.

Ask committer and PMC, id they support, open issue to discuss. We could not change core API directly.

I agree the API should not change if necessary
On my point of view, the API should  change  for the future
This PR try to  make the API strong: pass span over MethodAroundContext
and then call ContextManager#stopSpan(span)   -- the fail-fast version of stopSpan
combine with #3124( "span carrry TracingContext" , reduce call ThreadLocal  if not required ) will improve  the performance  additionally

Yes, I agree the two PRs will improve the performance, but we need to be careful about that. SkyWalking today is making the project more stable by several version releases. So, if we noticed serious performance concerns, we prefer to keep unchanged. Also, we haven't received the report, our agent core(not perfect :) for sure) causes the performance issue to target applications.


Tenant resource URL's

Package
filament/filament
Package Version
v3.2.27
Laravel Version
v10.43.0
Livewire Version
v3.4.4
PHP Version
PHP 8.2
Problem description
Resource URL's within navigation groups are displaying as the last tenant in the tenant menu instead of the current active tenant.
Example, currently the test1 tenant, the navigation is for the test3 tenant.

Example, currently the test 3 tenant, the navigation is for the test2 tenant.

This doesn't happen when the User resource is not within a navigation group.
Expected behavior
Resource URL's should be for the current tenant, not the last tenant in the tenant menu.
Steps to reproduce
Login to the reproduction repository, swap to test 3 tenant, the users resource will be for the test 2 tenant because its the last item in the tenant menu.
This doesn't happen in 3.2.24, the issue seems to have been introduced in the octane performance improvements pushed in 3.2.27
Reproduction repository
https://github.com/xHeinrich/fillament-issue
Relevant log output
I tracked this issue down to changes within the HasRoutes trait getUrl method but don't have a deep enough understanding to fix this one.

Relevant PR that I believe broke this is #11292


firmware: decide on whether to go with 8 or 12 voices

if so refactor the synth block diagram and remove extra voices

8... it's done


Format json fix

Added support for _format parameter. Supported formats are “json”, “application/json”, and “application/json+fhir”. All other formats (e.g. xml) error out.
Also fixed a small pointer bug that affected the content of error responses returned from the server.

Against wrong branch (master)


Import error email visuals don't fit the message

From CartoDB/design/issues/491
The visual language is a bit confusing:

Looks like everything went fine, instead of raising an error
It looks like current import mail code doesn't support error messages.
cc @AbelVM @saleiva @xavijam @MariaCheca

Some errors trigger the right visuals. @AbelVM do you know what triggered your original error mail?

Inconsistent cartodb_id. It was an import from query, so (my fault) there were some duplicated values for primary key.

I can't reproduce with repeated cartodb_id values. I'l keep trying, please let me know if you come up with other possible problem.

SELECT * FROM mytable
UNION ALL
SELECT * FROM mytable

And then, "create dataset from query"

Oh, great, thanks! This uses a different workflow than normal importing. Your steps reproduce the error 👍

Two actual issues here:

Error display is decoupled from errors itself.
Duplicating a dataset doesn't store created tables metadata.

Did acceptance, everything seems to work fine. Just a question: Are synchronization imports supposed to send emails? I did not receive an email for those (neither for ok and failure cases).

Imports from data library also do not trigger emails. Not sure if it is intended.

I think yeah @javitonino, both should trigger emails

@juanignaciosl @saleiva There is the following in the code:
      def should_notify?
        import_time >= MIN_IMPORT_TIME_TO_NOTIFY && @data_import.synchronization_id.nil?
      end

So no email will be sent for synchronizations (also not for data library, as those are syncs).
So for me, this is ✅ in acceptance as the issue in question has been fixed.
@saleiva If you feel we should send email when a synchronization imports, feel free to open a different ticket. Not sure if it makes much sense, as I think the email is not sent for a good reason (to avoid spamming the user every time it resyncs), but maybe it's worth it for the initial import?

No, those are not meant to send emails, as code says. The syncs would be too spammy (but I'm just guessing the original intention of avoiding those emails).

No, please, sync tables should not send emails :open_mouth:


Use Angular component as an editor and renderer

⚠  WIP
Description
Very similar feature to what we did for Vue wrapper: https://github.com/handsontable/vue-handsontable-official/issues/101 and we're doing for React wrapper (add link later).

[x] We already have <hot-column> component

[ ] Docs: We have an example with declared <hot-column> but maybe we should have a specific example to explain that and the basic example should be simpler
[ ] Docs: Add an example with <hot-column> and a for loop (is this possible in the Angular?)

[ ] Support Angular components as hot-renderer or hot-editor

[ ] Docs: Add an example with hot-renderer
[ ] Docs: Add an example with hot-editor

Basic use case
With each column declared by hand (done 👍 )
@Component({
  template: `

    <hot-table [colHeaders]="true" [rowHeaders]="true">
        <hot-column data="id" [readOnly]="true" title="ID"></hot-column>
        <hot-column data="name" title="Full name"></hot-column>
        <hot-column data="address" title="Street name"></hot-column>
    </hot-table>

  `,
})
class AppComponent { ... }

With *ngFor loop
@Component({
  template: `

    <hot-table [colHeaders]="true" [rowHeaders]="true">
        <hot-column *ngFor="let item of items; index as i;" [data]="item.data" [readOnly]="item.readOnly" [title]="item.title"></hot-column>
    </hot-table>

  `,
})
class AppComponent { ... }

Custom renderer / editor
We've choose to use attributes for components inside hot-column to mark them as hot-renderer or hot-editor or both at the same time.
@Component({
  template: `

    <hot-table [colHeaders]="true" [rowHeaders]="true">
        <hot-column data="id" [readOnly]="true" title="ID">
           <date-viewer hot-renderer></date-viewer>
           <date-picker hot-editor></date-picker>
        </hot-column>
        <hot-column data="address" title="Street name">
           <date-picker hot-renderer hot-editor></date-picker>
        </hot-column>
    </hot-table>

  `,
})
class AppComponent { ... }

Pros:

Single component can be market both as hot-renderer and hot-editor
They're not always needed. When component is both the renderer and the editor we can omit the directives. This gives us clean and simple markup that other options can't provide [1].

Cons:

Attribute name might be in conflict with other component attributes (very unlikely because we have hot- namespace)

As a helper function
From what we have learned in Vue we have to wrapp the component to match Handsontable interface. The wrapper function can be a helper so if someone wants to use settings object but a custom Angular renderer (s)he can use the helper for that.
// columns as a function example (but with better function name)
import { HotTable, HotColumn, WrapRenderer } from '@handsontable/angular';

const components = [[ ... ], ... ];

const hotSettings = {
  columns: function (col, row) {
    return {
      renderer: WrapRenderer(components[col][row])
    }
  }
}

Editor component interface
We will need an interface for components that can be used as an editor
// should be imported from handsontable.d.ts ?
interface CellEditor {
  focus: () => void;
  open: () => void;
  close: () => void;
  getValue: () => any;
  setValue: (newValue: any) => void;
  init: () => void;
}

@Component({ ... })
class AngularCellEditor implements CellEditor {

}

This way we can wrap component to work with our Editor lifecycle:
import { BaseEditor } from 'handsontable';

getCellEditorFromComponent(component: CellEditor) {
  return class extends BaseEditor {
    getValue() {
      return component.getValue();
    }
    setValue(value) {
      component.setValue(value);
    }
  }
}

Renderer component interface
Similar to CellEditor interface, but renderer currently is just a render function.
interface CellRenderer {
  value: string;
  td: HTMLTableCellElement;
  instance: HandsontableInstance;
  row: number;
  column: number;
  prop: any;
  cellProperties: Handsontable.CellProp;
}

@Component({ ... })
class AngularCellRenderer implements CellRenderer {

}

We have no renderer lifecycle but it will be easier to wrap to HOT:
getCellRendererFromComponent(component: CellRenderer) {
  return function(instance, TD, row, col, prop, value, cellProperties) {
    let cachedComponent = cache.get(TD);

    cachedComponent.$data.value = value;
    cachedComponent.$data.td = TD;
    cachedComponent.$data.row = col;
    cachedComponent.$data.prop = prop;
    cachedComponent.$data.cellProperties = cellProperties;

    return TD.appendChild(cachedComponent.$el);
  }
}

One component to rule them all (implement both)
@Component({ ... })
class AngularCellRenderer implements CellRenderer, CellEditor {

}

Notes

[ ] Handle error when both <hot-column> and <hot-table columns="[ ... ]"> are defined
[ ] Handle error when where <hot-column> slot has more than one/two/supported components
[ ] Handle error if <hot-column> children are not marked as hot-renderer or hot-editor
[ ] Handle error if <hot-column renderer="CutomRender"> and <hot-column><custom-renderer hot-renderer></custom-renderer></hot-column> are both defined. Same for editor.
[ ] Check if component implements correct interface methods
[ ] Find a way to provide context to the component. State and router for example.

Do you have scheduled this?
Want to use customrenderer and customeditor with angular components...

@saschbruegg that WIP (work in progress) and hasn't been added yet.

Given that this is a long way from happening and the current state of angular example (examples in published docs do not work as-is), is angular support on the way out?

@rogrdat can you share more details about broken examples here or on emails<EMAIL_ADDRESS>I would like to investigate that case.

Hi @alvin-h, @saschbruegg,
We merged wrapper for Angular into our main repository, handsontable/handsontable. Now library and wrapper are available in monorepo.
We also transfer all issues into one common issue board, where you can follow work progress and request issues.


Lotus release hand-off: FVM Selenium (r2)

Request
Please reset the Wallaby testnet with the following Lotus release.
Git reference
https://github.com/filecoin-project/lotus/tree/experimental/fvm-m2
Commit: https://github.com/filecoin-project/lotus/commit/c54145e337b8e21e22ea9bb45006122d0e13aa49
Features
This release adds multiple functionalities on top of the new EVM actor introduced in Talc release

Support for Ethereum precompiles
Support for masked ID addresses

The EVM actor now represents ID addresses in the form outlined in https://github.com/filecoin-project/ref-fvm/issues/821.

Support for SELFDESTRUCT
Support for opcodes:

SELFBALANCE
BLOCKNUMBER
COINBASE
DIFFICULTY

Performance optimizations in the Ethereum interpreter

Deployment of a simple smart contract can be tested with the attached example (Solidity source, and EVM compiled bytecode)
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.25 <= 0.8.15;

contract SimpleCoin {
        mapping (address => uint) balances;

        event Transfer(address indexed _from, address indexed _to, uint256 _value);

        constructor() {
                balances[tx.origin] = 10000;
        }

        function sendCoin(address receiver, uint amount) public returns(bool sufficient) {
                if (balances[msg.sender] < amount) return false;
                balances[msg.sender] -= amount;
                balances[receiver] += amount;
                emit Transfer(msg.sender, receiver, amount);
                return true;
        }

        function getBalanceInEth(address addr) public view returns(uint){
                return getBalance(addr) * 2;
        }

        function getBalance(address addr) public view returns(uint) {
                return balances[addr];
        }
}

Introduces two new commands in Lotus to create and invoke EVM actors:

lotus chain create-evm-actor
lotus chain invoke-evm-actor

Verification tests

Uncompress the below bytecode.
Deploy the smart contract.

⟩ ./lotus chain create-evm-actor ~/simplecoin.bin
sending message...
waiting for message to execute...
ID Address: t01001
Robust Address: t2fzzgpskwwzddllhrf35scsuqkrszrrnhmlesuwa
Return: gkMA6QdVAi5yZ8lWtkY1rPEu+yFKkFRlmMWn

Invoke the smart contract with two different addresses (owner and non owner, you will find they have different balances).

⟩ ./lotus chain invoke-evm-actor t01001 f8b2cb4f<PHONE_NUMBER>00000000000000ff00000000000000000000000000000000000064
sending message...
waiting for message to execute...
0000000000000000000000000000000000000000000000000000000000002710

⟩ ./lotus chain invoke-evm-actor t01001 f8b2cb4f<PHONE_NUMBER>00000000000000ff00000000000000000000000000000000000065
sending message...
waiting for message to execute...
0000000000000000000000000000000000000000000000000000000000000000

Compiled EVM bytecode
simplecoin.bin.zip

The "verification test" isn't passing for me using wallabynet:
$ ./lotus version
Daemon:  1.17.1-dev+wallabynet+git.bab009bb7.dirty+api1.5.0
Local: lotus version 1.17.1-dev+wallabynet+git.bab009bb7.dirty

$ ./lotus chain list --count=1 --height=0
0: (Sep  6 15:22:45) [ bafy2bzaceaxkepuvjenqk7go7iemehzffdb3bv46ib4njz2je6hp5poyysa46: t00, ]

$ md5sum ../simplecoin.bin
dd1a45822c513b9e41973f8cb85cdd87  ../simplecoin.bin

$ ./lotus chain create-evm-actor ../simplecoin.bin
sending message...
waiting for message to execute...
ID Address: t01048
Robust Address: t24p5lu5ctl6i4kurbdf2sqz2a7xw3ix4xzbyb3bi
Return: gkMAmAhVAuP6unRTX5HFUiEZdShnQP3ttF+X

$ ./lotus chain invoke-evm-actor t01048 f8b2cb4f<PHONE_NUMBER>00000000000000ff00000000000000000000000000000000000064
sending message...
waiting for message to execute...
0000000000000000000000000000000000000000000000000000000000000000

The expected result is<PHONE_NUMBER>000000000000000000000000000000000000000000000000002710
I'm seeing the same thing via the GLIF API.
It does seem to work on my standalone demo that has it's own localnet:
https://observablehq.com/@jimpick/fvm-actor-code-playground-simplecoin-evm-contract?collection=@jimpick/filecoin-virtual-machine

@f8-ptrk any idea why ^ is different than on localnet?

Hm, @jimpick, you are fetching the balance for ID address t0100 (...0064). Are you sure this is your address on Wallaby?

It most certainly isn't because t100 is very likely to be the account actor of the first miner in the network :-)

The thing is that this ^ command says: "give me the balance of address t100", which will be all zeros unless t100 was the actor who deployed t01048 in the first place. So when using Wallaby, most users (except the 1st one who deployed their contract after network reset) shouldn't pass ...0064 as the parameter, but their own hex-encoded ID address.

This is because you were probably the 1st miner after the network reset and your ID is t100 (...0064) in hex :) You can deploy as many times as you want - this example will always work for your ID.

@f8-ptrk You are The One!

Confirmed. Here's a modified SimpleCoin.js:
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.25 <= 0.8.16;

contract SimpleCoin {
        mapping (address => uint) balances;

        event Transfer(address indexed _from, address indexed _to, uint256 _value);

        constructor() {
                balances[tx.origin] = 10000;
        }

        function sendCoin(address receiver, uint amount) public returns(bool sufficient) {
                if (balances[msg.sender] < amount) return false;
                balances[msg.sender] -= amount;
                balances[receiver] += amount;
                emit Transfer(msg.sender, receiver, amount);
                return true;
        }

        function getBalanceInEth(address addr) public view returns(uint){
                return getBalance(addr) * 2;
        }

        function getBalance(address addr) public view returns(uint) {
                return balances[addr];
        }

        function getOrigin() public view returns(address) {
                return tx.origin;
        }
}

Signatures:
Function signatures:
f8b2cb4f: getBalance(address)
7bd703e8: getBalanceInEth(address)
df1f29ee: getOrigin()
90b98a11: sendCoin(address,uint256)

Deployed to t01065
$ ./lotus chain invoke-evm-actor t01065 df1f29ee
sending message...
waiting for message to execute...
000000000000000000000000ff000000000000000000000000000000000003ed

So I executed this method and got back 0x3ed = t01005
$ ./lotus state lookup -r t01005
t1ybjfphyqcsqblk2ceikpvmyaqy3ov5c6v2j2ewq

$ ./lotus wallet list
Address                                                                                Balance                      Nonce  Default
t1ybjfphyqcsqblk2ceikpvmyaqy3ov5c6v2j2ewq<PHONE_NUMBER>62509792182 FIL   14     X
t3sqt4lobkilb3q7xl3ybxxc3plt2xssqumxufg5roelg66igyfr4oti26bobvqarhvvese7ek25kfhrbkri4a  3998.937057468714422919 FIL  120

That looks like my default wallet.
$ ./lotus chain invoke-evm-actor t01065 f8b2cb4f<PHONE_NUMBER>00000000000000ff000000000000000000000000000000000003ed
sending message...
waiting for message to execute...
0000000000000000000000000000000000000000000000000000000000002710

All good!

Perfect, thanks @jimpick!


[llvm] install tools in tools/llvm

This fixes #13294; however, I'm not sure this is the best solution, so I would like reviews from affected parties (this is also the first portfile I've ever written, haha!)

Thanks again for running this down!


Fix command ID

@sshipway Since you were the original author of the command/exec change, I would love your feedback on this, since I don't know the rationale behind the command.ID change.
This change changes the output of the test result, so that this test file:
command:
  python_example:
    exec: |
      python3 << EOF
      import sys
      print('example output')
      for i in range(3):
        print(i)
      sys.exit(15)
      EOF
    stdout:
      - 'example'
      - '0'
      - '1'
      - '2'
    exit-status: 15
    timeout: 10000

Current state:
$ goss v --format documentation
Command: python_example: python3 << EOF
import sys
print('example output')
for i in range(3):
  print(i)
sys.exit(15)
EOF
: exit-status: matches expectation: [15]
Command: python_example: python3 << EOF
import sys
print('example output')
for i in range(3):
  print(i)
sys.exit(15)
EOF
: stdout: matches expectation: [example 0 1 2]

Total Duration: 0.090s
Count: 2, Failed: 0, Skipped: 0

With this PR:
$ goss v --format documentation
Command: python_example: exit-status: matches expectation: [15]
Command: python_example: stdout: matches expectation: [example 0 1 2]

Total Duration: 0.045s
Count: 2, Failed: 0, Skipped: 0

The rationale behind the change to the ID function was so that the logs would continue to show the command being run, as they did before the change.
However, since I had not considered that now it is possible to hide an entire script in the exec attribute, it is clear that the resulting behavious is not optimal.  So, I agree that this change (just displaying the key, even if an exec attribute is defined) is the best way to go.


Add more site info into the model

Site IPv4/IPv6 status
Site hosting org (not the same as location)
...

Example:
{
  "name": "RENCI",
  "acronym": "RENC",
  "hosting": "University of North Carolina-Chapel Hill RENCI",
  "ipv": "4/6",
  "location": "Chapel Hill, NC",
  ...
}

PTP status will be available as of FIM/CF 1.5.0


SS |  Task List

General learnings.

Please read clean code book below:

https://github.com/vamseeachanta/energy/blob/498f4a04d2254a5cdd434b1dc0387bd92f1573fd/it/REF-IT-Clean_Code.pdf

I have further resources below:

https://github.com/vamseeachanta/energy/blob/f0b086d56afefa8896fcb15256e7aef3c1c89b73/it

cathodic protection, Ship (VA to approve)

cathodic protection, Pipeline (VA to approve)

Plate buckling (VA to approve)

AQWA MES file analysis (Incorporated in DigitalModel. Configure to current directory or yml file specification) (DONE: Testing ongoing)

Next assignments:

Finance projects - Stock data analysis (Ongoing)

word utility: Table  ( Done; Testing ongoing)

https://github.com/vamseeachanta/assetutilities/issues/21

wind data from public websites

More engineering calculations

energydata - BSEE

https://github.com/vamseeachanta/energydata/issues/9

Databases (Supabase - 2GB)

https://github.com/vamseeachanta/assetutilities/blob/ce52eda54dc65662045eeb08c56cfc39e3f7ac80/docs/sub_databases

Hosting websites (AceEngineer02?)

https://github.com/vamseeachanta/assetutilities/blob/b2cbe58ce4bf5483ff863adb99ef73ce84aee6d8/docs/sub_website_hosting

~~Learn merging branches using git and VScode. Documentation by SS.

Methodology: https://github.com/vamseeachanta/assetutilities/blob/2a9dfcd1344d578b825861da19324e438cb3d4fb/docs/sub_git/git_advanced.md
teamresumes (Done)
assetutilities

branch 2024 merge complete.
Way Forward: Delete 2024
Created new branch "2024aug". Work in 2024aug going forward.

digitalmodel (CP_ss, ? ?)
acma-projects (ctr2, ctr1, )
delete stale branches

After fixing or running all tests.

Automate the following process every time a code change is made:

merging master on to current branch. Highlight if any merge conflicts come so we fix them promptly.
If no "merge conflicts", then ensure all tests that ran previously are running. (Base test csv file. - compare)

Library Tests (improvements ongoing)

Test all yml files in assetutilities\test_data ( DONE )
Test all yml files in digitalmodel ( Ongoing ).

assert (30 == 30). Pass the branch.
pass - folder (pipeline)
to_fix -another folder

Test all yml files in stockhold ( Pending ).

https://github.com/vamseeachanta/assetutilities/issues/4
https://github.com/vamseeachanta/digitalmodel/issues/53 ~~

git improvements :

https://github.com/vamseeachanta/assetutilities/issues/19

~~Visualizations:

https://github.com/vamseeachanta/assetutilities/issues/23 ( DONE ) ~~

~~Resume ( change time to time  )

https://github.com/vamseeachanta/teamresumes/issues/2~~

~~Doing calculus using python ( Ongoing )

https://github.com/vamseeachanta/assetutilities/issues/22~~

@vamseeachanta
Hello sir, good evening
I am writing this regarding my interest in data science and data ,
After rewiring my whole engineering journey, I came to one conclusion that i am more focused and i can do better in data frames and data related things, so if you can give me assignments associated with this i am ready to do. As well as if you need any help in your projects , can also assign me that also I am happy to do that.

Programming interest: python -> libarary pandas -> dataframes (rows, columns etc.)
Math: simple, statistics, ml, ai etc.
Business:  (Finance-banking, finance-stocks, physics based engineering etc., education, restaurants, etc)

@samdansk2 , I need weekly progress in the following format today. I just need 4-5 items

Task
Hours
Progress
Comments

Visualization
10
40%
-

@vamseeachanta
is word document ok sir?  or should I do here?

@samdansk2 What you have above is great. I will share this with my client. Thank you.

@samdansk2 , I added general learnings at the top of this list to do in  your own time.

@samdansk2 , please clean, close or relocate.
Need a clean slate without stale data. Should be such that we can refer to it everyday.


Adding proprietary extensions to questions

Is your feature request related to a problem? Please describe.
We would like to say that "when processing this question item, look up the threshold values for this patient's bodyweight". This is thus not a presentation/rendering issue, but related to adding additional meta-data about the question to be used by a processor when processing the submitted QuestionnaireResponse.
The most straight-forward way we could see how this would be implemented would be by adding an extension
{
   "url": "https://our.proprietary/fhir/StructureDefinition/extension-validate-using-threshold-value",
   "valueCoding": {
              "system": "https://our.proprietary/fhir/ValueSet/threshold-values",
              "code": "bodyweight"
    }
}

Describe the solution you'd like
An optional "Additional extensions" box. Either a dumb "JSON blob" type of input field or some kind of smarter form to help fill in the possible variations (not something we need).
Describe alternatives you've considered
Was wondering about making our own "questionnaire enricher" import module that would take a Structor exported questionnaire definition and make it possible to add some blob of JSON extensions to each questionnaire item.
Additional context
Add any other context or screenshots about the feature request here.

The only way to do this today is by adding it to the json document.
We will not add such an option any time soon, and adding raw json-code in a UI for non-programmers is not the purpose for this tool.

That is of course totally fair and I would not suggest you add it either! Bloat scope is murder to any product 🔪 For now, I guess we will just keep on manually editing/enriching the produced JSON schema and ponder creating a user-friendly UI for it. Still ...
 I was just wondering about what you had in mind when designing this.
I think no one is interested in maintaining forks of Structor with custom functionality, but there are alternatives to avoid scope creep in the core: support extending the product through an API. Has this been discussed? In pseudo-code something a la
structor.init({plugins: [myCustomPlugin, myOtherCustomPlugin]}) where these plugins could receive for instance receive some references and return components that should render to specific parts of the application.
Something like

const myPlugin = structor.createPlugin( React => {
    return {
        transform(schema) { return schemaWithCustomExtensions(schema); }, //  enriches the FHIR Questionnaire schema
        HeaderNode(props) { return <div>... </div>; }, // rendered to specified place in the header
        FooterNode(props) { ... return <div>{props.schema.title}</div>; } // rendered to specific place in the footer
    }
});

// props could include stuff such as `updateSchema(schema)` that could be used to capture additonal user data

Would something like this be interesting to have? This might be a good candidate for externals to create a PR for, but the concept would of course need a chance to be accepted before investing time in trying to squeeze it in.

Thanks, can you create a new issue with this proposed solution so we at least have it logged in a directly related issue. If you got the time to implement it, give us a PR and it isn't too intrusive we can consider to add the plugin solution as a feature


[BUG] The hard-coded timezone in anki_to_fsrs

https://github.com/open-spaced-repetition/fsrs-rs/blob/16bdf86c5053038dd6fc9bf939f395b889be9fe2/src/convertor_tests.rs#L178-L190
@AlexErrant, this function is used by fsrs-browser. It causes some problems for people in other timezone.
https://github.com/open-spaced-repetition/fsrs-browser/blob/58f27babb2bf6aea9de06820156a8213aa1712ff/sandbox/src/train.ts#L138
https://github.com/open-spaced-repetition/fsrs-browser/blob/58f27babb2bf6aea9de06820156a8213aa1712ff/src/lib.rs#L32-L44

Since this is a bug in fsrs-browser, and not in fsrs-rs's test suite, please feel free to transfer this issue there!


chore: update aws-cdk-lib to 2.141.0 from 2.132.1

Bump aws-cdk-lib version.

+1 thank you!  looking forward to this getting released, as we're stuck on a pretty old version of sst due to the cdk diff bug in 2.132.1

@krmorse we need this because it makes it easier to set resolver and depth limits on the graphql api instead of resorting to the escape hatch.

And fixed the commit, as I had switched to lockfile version 9 here, kept it at 6 now.

Thanks @berenddeboer!


Scoop stops after update error

When I update multiple applications using
scoop update *
I get an error sometimes such as 'The remote server returned an error: (404) Not Found'. and also 'ERROR Hash check failed!'. All other updates then fail as well.
https://github.com/lukesampson/scoop/blob/092005046454d94d141d5c68fdbdb4c4a1229ae9/lib/install.ps1
In lib/install.ps1 lines 379, 389 (function dl)
The exception throws an error. Wouldn't it be best to just print an error message?
in lib/install.ps1 line 111 (function dl_with_cache)
The function do_dl throws the error that is unhandled with try catch. It could be possible to pass it further via try and catch.
https://github.com/lukesampson/scoop/blob/092005046454d94d141d5c68fdbdb4c4a1229ae9/libexec/scoop-update.ps1
in libexec/scoop-update.ps1 line 209, dl_with_cache is called that may give an uncaught error. This stalls multiple updates (that didn't have error).
Suggestion: Simply print error message in lib/install.ps1 lines 379, 389 (dl as well as in dl_with_cache_aria2 functions)
Thanks

+1 - just ran into this myself with a blocked download of an app I had installed prior to the block being put in place. I want to keep the app but I can't run update * because it errors out on one of the first entries. Temporary workaround has been to remove the offending app folder from scoop\apps, running update * and then restoring the app folder to its original location.

https://github.com/ScoopInstaller/Scoop/issues/4135


https://www.facebook.com/profile.php?id=100075394320608&mibextid=2JQ9oc

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or example input/output images to help explain your problem.
Environment

OS: [e.g. Windows]
Compiler version: [e.g. clang 11.0.1]
CPU type: [e.g. x86_64]
cjxl/djxl version string: [e.g. cjxl [v0.3.7 | SIMD supported: SSE4,Scalar]]

Additional context
Add any other context about the problem here.

https://www.facebook.com/profile.php?id=100075394320608&mibextid=2JQ9oc


Fix for FF Icons

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[x] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

CC @rohanmaharjan100 this was my fix.

hmm, was it just a missing  > ?

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66b34258123c6da16d33dd99--harness-developer.netlify.app


[FEATURE] Repo size icon

Description
In the README an icon that specifies how large the repo size is would be great for people looking to clone the repo.
Screenshots
For example:
Additional information
No response

I would like to add this feature please assign it to me


integrate_1d tolerance isn't actually optional (but it should be)

Summary:
The tolerance parameter to integrate_1d isn't optional but it should be.
Description:
There are two signatures in the docs, but only the second works (the one with the tolerance) works: https://mc-stan.org/docs/2_19/functions-reference/functions-1d-integrator.html .
Reproducible Steps:
Here is an example model for the signature without the tolerance:
functions {
  real integrand(real x, real xc, real[] theta, real[] x_r, int[] x_i) {
    return 0.0;
  }
}

data {
}

transformed data {
  real x_r[0];
  int x_i[0];
}

parameters {
  real x[1];
}

model {
  real y = integrate_1d(integrand, 0, 1, x, x_r, x_i);

  x ~ normal(y, 1.0);
}

If you change
real y = integrate_1d(integrand, 0, 1, x, x_r, x_i);

to
real y = integrate_1d(integrand, 0, 1, x, x_r, x_i, 1e-8);

The model compiles.
Current Output:
The first model doesn't compile
Expected Output:
Both models should compile
Current Version:
v2.19.1

Should integrate_1d return a real? In the manual it returns a vector: https://mc-stan.org/docs/2_19/functions-reference/functions-1d-integrator.html

It should definitely be a real.

The compilation problem has been fixed. Docs will be fixed by https://github.com/stan-dev/docs/pull/151.


Add an Evac Shuttle busy event

About the PR

Added a new event, Evac Shuttle Busy. The Shuttle has been called by another station and you're forced into a queue. The station will be unavailable until it is finished.
Why / Balance

Frequently stations on the LRP side are quick to call the emergency shuttle rather than deal with the consequences of their collective actions. This event removes this option from the table temporarily and hopefully will encourage players to explore attempting to resurrect a station from a "doomed" state.
Technical details

Utilises the RoundEndSystem to put a cooldown of 60 minutes on calling the evac shuttle. Being done this way should still allow Admins to force end a round.
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

RoundEndSystem.ActivateCooldown was made public and given a default parameter to reduce breakages, but this could still occur.
Changelog

:cl: ZeroNationality

add: Added the Evac Shuttle Busy event

Saying “you can’t end the round for an hour” feels likely to cause some issues- especially when evac can often be called because of total (or near total) station destruction or due to a long / boring round (where all the zombies were killed quickly, for example). Having it be ~10 minutes could be fine as an alternative

1 hour is too long. Even ignoring accidents that can cause round ending disasters(engies forgetting to turn on emitters for singulo/Tesla is surprisingly common) current rules in wizard's den allow traitors to commit mass sabotage after half an hour is up.

Sorry in my previous comment I had misunderstood what this pr actually did. Anyways I believe that 1 hour is an extremely long time. Disasters such as a teslaloose for example will force an evac shuttle call without exception as it's nearly impossible to contain and will destroy any hope for a station to continue operating. Having this event block shuttle calls for a time that's 2/3rds of a usual round will just lead to people using restart votes much more instead of ending rounds the proper way. Something more reasonable like 10-15 minutes would be cool tho. SS13 also had random events which would delay the arrival of the shuttle to the station after it had been called along with events that shortened the time of arrival. Maybe those would be good substitutes as well?

Sorry in my previous comment I had misunderstood what this pr actually did. Anyways I believe that 1 hour is an extremely long time. Disasters such as a teslaloose for example will force an evac shuttle call without exception as it's nearly impossible to contain and will destroy any hope for a station to continue operating. Having this event block shuttle calls for a time that's 2/3rds of a usual round will just lead to people using restart votes much more instead of ending rounds the proper way. Something more reasonable like 10-15 minutes would be cool tho. SS13 also had random events which would delay the arrival of the shuttle to the station after it had been called along with events that shortened the time of arrival. Maybe those would be good substitutes as well?

I've just picked a longish number for now. My thinking was that a typical shuttle call takes 10-20 minutes to arrive, then waits around for a few minutes, departs (10-20 minutes of flight time presumably), gets unloaded (Few mins), preps to take a new evac (Few more min), etc.. So.. somewhere around 60 minutes of evac shuttle downtime seemed reasonable from a lore perspective.
Also don't forget that this number can be changed and randomised, I just needed this draft PR to be able to show context for a question I asked on discord :)

I agree with your concern that this will induce more people to vote to restart the round, especially as we currently have "I died, restart round pls" level voting going on with the LRP servers.
However I'm also hopeful that this event will also be tackled as a challenge by a large portion of the player base to survive despite the odds, rebuild what they can, and overcome the issue as best as can be managed.. even if then only to call the evac shuttle.

teslaloose is guaranteed station destruction so 1 hour would completely require a restart vote

I agree with your concern that this will induce more people to vote to restart the round, especially as we currently have "I died, restart round pls" level voting going on with the LRP servers.
However I'm also hopeful that this event will also be tackled as a challenge by a large portion of the player base to survive despite the odds, rebuild what they can, and overcome the issue as best as can be managed.. even if then only to call the evac shuttle.

Sorry to burst your bubble, but it absolutely will not cause that to happen. Restart votes will skyrocket. It shouldn't be 1 hour, maybe maximum 10-20 minutes.

teslaloose is guaranteed station destruction so 1 hour would completely require a restart vote

A station doesn't often survive a teslaloose long enough for the shuttle to make it out regardless. Kinda wish death wasn't so guaranteed tbh.  Then again, there are guaranteed safe setups that people are finding now it's been out a little bit.
That being said. Yes.. if everyone is dead then a restart is needed, if not then it's whoever remains playing out the end times like it's project zomboid or something.

Clearly we must balance this out with an event that makes the evac shuttle arrive earlier as though it was fasttracked


Compaction-aware store events

This makes store events aware of compaction, i.e. when a new chunk comes in and gets compacted with an older chunk, downstream subscribers will now be notified of what the new chunk looked like pre-compaction, and which chunk was merged with what.
This results in massive perf boost in downstream subscribers without requiring code changes (existing subscribers will effectively be working with diffs without knowing).

DNM: built on top of #6939

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

Gonna go ahead and merge this as I really need it on a few branches of mine ASAP and I don't want to make my rebase situation more nasty that it already is.


Analytics check

Mark, do we have:

[x] Analytics on the website - @markmacgillivray
[x] & successfully feeding into an account - Me
[ ] link / open tracking in mailgun - @markmacgillivray

Linked to #335

Yep there are analytics on the site, I don't know what you mean by link / open tracking in mailgun.

for mg.openaccessbutton.org we now have open tracking and link tracking in html messages.


Update README.md

@typicode
Would be great if you can add my deployment method to the readme file

@typicode
Would be great if you can add my deployment method to the readme file

Hello, can someone please add my deployment method ?


Cannot create new HostKeyAlgorithms entry with augeas > 1.9.0

Augeas 1.9.0 includes this change in the release notes:

Sshd: split HostKeyAlgorithms into list of values; recognize quoted group names with spaces in them (Issue #477)

However, both version 4.0.0 and the head of this repository treat this field as a simple value.
https://github.com/hercules-team/augeasproviders_ssh/blob/a0f3728f7b8a0307e0d3b41e6d30d4d995f948ca/lib/puppet/provider/sshd_config/augeas.rb#L46
As a result, trying to add this configuration directive to an sshd.conf that does not already contain it fails with somewhat unclear errors about the augeas tree
Notice: /Stage[main]/Ssh::Config/Sshd_config[HostKeyAlgorithms]/ensure: created (corrective)
Debug: Puppet::Type::Sshd_config::ProviderAugeas: Save failure details:
/augeas/files/etc/ssh/sshd_config/error/path = /files/etc/ssh/sshd_config/
/augeas/files/etc/ssh/sshd_config/error/lens = /opt/puppetlabs/puppet/share/augeas/lenses/dist/sshd.aug:142.12-.47:
/augeas/files/etc/ssh/sshd_config/error/message = Failed to match tree under /
[...]
     { "KexAlgorithms" }
     { "HostKeyAlgorithms" = "ecdsa-sha2-nistp256" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "ecdsa-sha2-nistp384" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "ecdsa-sha2-nistp521" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "ssh-ed25519" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "rsa-sha2-256" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "rsa-sha2-512" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "HostKeyAlgorithms" = "ssh-rsa" }
     { "HostKeyAlgorithms" =<EMAIL_ADDRESS>}
     { "Match" }
     { "Match" }

  with pattern
   (    { /AcceptEnv/ }
      | { /AllowGroups/ }
      | { /AllowUsers/ }
      | { /DenyGroups/ }
      | { /Subsystem/ }
      | { /DenyUsers/ }
      | { /MACs/ }
      | { /Ciphers/ }
      | { /KexAlgorithms/ }
      | { /HostKeyAlgorithms/ }
      | { /[Aa][Cc][Cc][Ee][Pp][Tt][Ee][Nn](([Vv][0-9A-Za-z]|[0-9A-UW-Za-uw-z])[0-9A-Za-z]*|)|[Aa][Cc][Cc][Ee][Pp][Tt][Ee]([0-9A-MO-Za-mo-z][0-9A-Za-z]*|)|[Aa][Cc][Cc][Ee][Pp][Tt]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Aa][Cc][Cc][Ee][Pp]([0-9A-SU-Za-su-z][0-9A-Za-z]*|)|[Aa][Cc][Cc][Ee]([0-9A-OQ-Za-oq-z][0-9A-Za-z]*|)|[Aa][Cc][Cc]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Aa][Ll][Ll][Oo][Ww]([Gg][Rr][Oo][Uu][Pp](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Gg][Rr][Oo][Uu]([0-9A-OQ-Za-oq-z][0-9A-Za-z]*|)|[Gg][Rr][Oo]([0-9A-TV-Za-tv-z][0-9A-Za-z]*|)|[Gg][Rr]([0-9A-NP-Za-np-z][0-9A-Za-z]*|)|[Uu][Ss][Ee][Rr](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Uu][Ss][Ee]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Uu][Ss]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Uu]([0-9A-RT-Za-rt-z][0-9A-Za-z]*|)|[Gg]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[0-9A-FH-TV-Za-fh-tv-z][0-9A-Za-z]*|)|[Aa][Ll][Ll][Oo]([0-9A-VX-Za-vx-z][0-9A-Za-z]*|)|[Aa][Ll][Ll]([0-9A-NP-Za-np-z][0-9A-Za-z]*|)|[Aa][Ll]([0-9A-KM-Za-km-z][0-9A-Za-z]*|)|[Aa][Cc]([0-9ABD-Zabd-z][0-9A-Za-z]*|)|[Cc][Ii][Pp][Hh][Ee][Rr](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Cc][Ii][Pp][Hh][Ee]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Cc][Ii][Pp][Hh]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Cc][Ii][Pp]([0-9A-GI-Za-gi-z][0-9A-Za-z]*|)|[Cc][Ii]([0-9A-OQ-Za-oq-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Gg][Rr][Oo][Uu][Pp](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Gg][Rr][Oo][Uu]([0-9A-OQ-Za-oq-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Gg][Rr][Oo]([0-9A-TV-Za-tv-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Gg][Rr]([0-9A-NP-Za-np-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Uu][Ss][Ee][Rr](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Uu][Ss][Ee]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Uu][Ss]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Uu]([0-9A-RT-Za-rt-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy][Gg]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Dd][Ee][Nn][Yy]([0-9A-FH-TV-Za-fh-tv-z][0-9A-Za-z]*|)|[Dd][Ee][Nn]([0-9A-XZa-xz][0-9A-Za-z]*|)|[Dd][Ee]([0-9A-MO-Za-mo-z][0-9A-Za-z]*|)|[Hh][Oo][Ss][Tt][Kk][Ee][Yy]([Aa][Ll][Gg][Oo][Rr][Ii][Tt][Hh][Mm](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Aa][Ll][Gg][Oo][Rr][Ii][Tt][Hh]([0-9A-LN-Za-ln-z][0-9A-Za-z]*|)|[Aa][Ll][Gg][Oo][Rr][Ii][Tt]([0-9A-GI-Za-gi-z][0-9A-Za-z]*|)|[Aa][Ll][Gg][Oo][Rr][Ii]([0-9A-SU-Za-su-z][0-9A-Za-z]*|)|[Aa][Ll][Gg][Oo][Rr]([0-9A-HJ-Za-hj-z][0-9A-Za-z]*|)|[Aa][Ll][Gg][Oo]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Aa][Ll][Gg]([0-9A-NP-Za-np-z][0-9A-Za-z]*|)|[Aa][Ll]([0-9A-FH-Za-fh-z][0-9A-Za-z]*|)|[Aa]([0-9A-KM-Za-km-z][0-9A-Za-z]*|)|[0-9B-Zb-z][0-9A-Za-z]*|)|[Hh][Oo][Ss][Tt][Kk][Ee]([0-9A-XZa-xz][0-9A-Za-z]*|)|[Hh][Oo][Ss][Tt][Kk]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Hh][Oo][Ss][Tt]([0-9A-JL-Za-jl-z][0-9A-Za-z]*|)|[Hh][Oo][Ss]([0-9A-SU-Za-su-z][0-9A-Za-z]*|)|[Hh][Oo]([0-9A-RT-Za-rt-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo][Rr][Ii][Tt][Hh][Mm](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo][Rr][Ii][Tt][Hh]([0-9A-LN-Za-ln-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo][Rr][Ii][Tt]([0-9A-GI-Za-gi-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo][Rr][Ii]([0-9A-SU-Za-su-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo][Rr]([0-9A-HJ-Za-hj-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg][Oo]([0-9A-QS-Za-qs-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll][Gg]([0-9A-NP-Za-np-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa][Ll]([0-9A-FH-Za-fh-z][0-9A-Za-z]*|)|[Kk][Ee][Xx][Aa]([0-9A-KM-Za-km-z][0-9A-Za-z]*|)|[Kk][Ee][Xx]([0-9B-Zb-z][0-9A-Za-z]*|)|[Kk][Ee]([0-9A-WYZa-wyz][0-9A-Za-z]*|)|[Mm][Aa][Tt][Cc](([Hh][0-9A-Za-z]|[0-9A-GI-Za-gi-z])[0-9A-Za-z]*|)|[Mm][Aa][Tt]([0-9ABD-Zabd-z][0-9A-Za-z]*|)|[Mm][Aa][Cc](([Ss][0-9A-Za-z]|[0-9A-RT-Za-rt-z])[0-9A-Za-z]*|)|[Mm][Aa]([0-9ABD-SU-Zabd-su-z][0-9A-Za-z]*|)|[Ss][Uu][Bb][Ss][Yy][Ss][Tt][Ee](([Mm][0-9A-Za-z]|[0-9A-LN-Za-ln-z])[0-9A-Za-z]*|)|[Ss][Uu][Bb][Ss][Yy][Ss][Tt]([0-9A-DF-Za-df-z][0-9A-Za-z]*|)|[Ss][Uu][Bb][Ss][Yy][Ss]([0-9A-SU-Za-su-z][0-9A-Za-z]*|)|[Ss][Uu][Bb][Ss][Yy]([0-9A-RT-Za-rt-z][0-9A-Za-z]*|)|[Ss][Uu][Bb][Ss]([0-9A-XZa-xz][0-9A-Za-z]*|)|[Ss][Uu][Bb]([0-9A-RT-Za-rt-z][0-9A-Za-z]*|)|[Ss][Uu]([0-9AC-Zac-z][0-9A-Za-z]*|)|([Ss][0-9A-TV-Za-tv-z]|[Mm][0-9B-Zb-z]|[Kk][0-9A-DF-Za-df-z]|[Hh][0-9A-NP-Za-np-z]|[Dd][0-9A-DF-Za-df-z]|[Cc][0-9A-HJ-Za-hj-z]|[Aa][0-9ABD-KM-Zabd-km-z]|[0-9BE-GIJLN-RT-Zbe-gijln-rt-z][0-9A-Za-z])[0-9A-Za-z]*|[Ss]|[Mm]|[Kk]|[Hh]|[Dd]|[Cc]|[Aa]|[0-9BE-GIJLN-RT-Zbe-gijln-rt-z]/ = /[^\t\n =]+([\t =]+[^\t\n =]+)*/ }
      | { /#comment/ = /[^\t\n\r ].*[^\t\n\r ]|[^\t\n\r ]/ }
      | { })*
    { /Match/ }*

Error: /Stage[main]/Ssh::Config/Sshd_config[HostKeyAlgorithms]: Could not evaluate: Failed to save Augeas tree to file. See debug logs for details.

In this output, I have the values entered as an array, btu a similar message with all the algorithms on one line appears if I provide them as a simple string.
I can work around this in my case by patching the line I referenced above, but this is not necessarily the appropriate solution for this module overall, since doing so would break users with older versions of augeas. There also seem to be tickets in the augeas and puppet worlds to make the sshd augeas lens recognize more array value (namely in my case GSSAPIKexAlgorithms,PubkeyAcceptedKeyTypes, and CASignatureAlgorithms), which means this problem could reoccur as more arrays are handled "correctly" by the underlying augeas lens but not by this module.

Thanks for reporting this.
There should be a check for the way this is parsed, using parsed_as?, as in https://github.com/hercules-team/augeasproviders_shellvar/blob/master/lib/puppet/provider/shellvar/augeas.rb#L25

Thank you. Would you like me to generate a PR to do something equivalent for the key listed here, along with the other ones I mentioned (which I am planning to submit to augeas as a PR in the near future) for future proofing?

Sure, I'd welcome a PR for that, thank you!

I submitted #65 for this. I validated it against both current augeas, and the updated sshd.aug lens I submitted in https://github.com/hercules-team/augeas/pull/721

Not exactly along the same path, but would PR #68 work?  Implemented it in my work env it seems to working for now.

I see this issue with Puppet Enterprise 2019.8.8 with Puppet Agent 6.24.0 on RedHat 7.9.
Ensuring host algorithms can be considered a high security requirement. Is there any way this issue can be bumped up in priority to support these high security environments?
I've tried file_line as a work around, but it's accidentally broken the sshd config by placing the "HostKeyAlgorithms" line after a "Match" line provided by sshd_config's "PublicAuthentication" key set with a "condition", then the service fails to start. file_line doesn't have a "before" parameter making it unfortunately difficult to just add "HostKeyAlgorithms" before "Match".
Is there a known work around for providing this HostKeyAlgorithms setting along with sshd_config settings provided with conditions?

@cheyngoodman to be clear, this is a community-supported project (see https://voxpupuli.org/), not supported by Puppet Inc.
My suggestion though is to manage the ssh configuration as a whole with a module like https://github.com/saz/puppet-ssh. This is going to be more consistent and reliable.

I'm trying to promote the issue and share details from a test environment.
Currently, I'm more likely to use loopiv:hostkeyalgo branch than to rework our SSH configurations around a new module.
I'm hoping there is a way to help test and merge a fix into upstream, instead of investigating a new module.

I'm hoping there is a way to help test and merge a fix into upstream, instead of investigating a new module.

Sure, the way is to submit a pull request that fixes the issue, and includes tests. If you can test to see if #68 fixes it for you, let us know there.

Fixed in #68.


fix: unable to handle non-GET request in cloudflare page

🔗 Linked issue

#497
#787
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Fix an issue that nitro won't be able to handle POST, PUT, etc requests on the Cloudflare page
Resolves #497 #787
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

When making these changes, I was able to get 200 responses for the API call however, the server API code never actually get executed. Have you run into that?

👋 Hi,
Thanks for creating the PR to fix this - however I'm not sure if the approach you have taken is the one that should be used going forward. Pages will still invoke a Function for static assets, which defeats the purpose of using Pages, so instead, we should take advantage of their internal static asset handling.
For more context please see my comment here


[apollo-datasource-rest] HTTPCache incorrectly caches 302 redirects

In package apollo-datasource-rest, the datasource is incorrectly storing a 302 redirect with the caching headers supplied by the final resource.  Then when the request is checked, the original URL is assumed to be fresh and it does not check the original redirect again.  This goes against the HTTP spec for 302 redirects (and caused a problem for me in my app)
I've created an integration spec that demonstrates the problem in my fork:  https://github.com/gburgett/apollo-server/blob/rest-caching/packages/apollo-datasource-rest/src/tests/integration.test.ts
To reproduce:

Set up a REST API with a 302 redirect to some static resource with cache-control: public, max-age=31536000, immutable
Issue a GraphQL query that performs a GET request to this 302 redirect path
Change the 302 redirect to point to another resource
Issue the same GraphQL query again

At this point, the expected behavior is that the new resource is returned.  The actual behavior is that the old resource is served from the HTTP cache.
Our current workaround is to set the TTL to 0 in the caching options for this data source.

There's two things going on here.
The first issue is that there are two layers of caching in Apollo Server and one of them is basically a sledgehammer that caches all GETs forever. We are going to fix that in #100.
However, this is going to reveal the opposite issue — we won't cache any redirects at all (assuming you don't change the redirect Fetch option to manual) because we will only see the final response, not the pre-redirect response. So we also won't cache 301 responses. I'll open a new issue.


Input Object arguments

Is something like this possible with this library?
https://atheros.ai/blog/input-object-type-as-an-argument-for-graphql-mutations-and-queries
I need the ergonomics of issues_insert_input, but with the ability to not pass certain fields:
https://github.com/graphql-rust/graphql-client/blob/master/examples/hasura/examples/query_1.graphql

I don't think I understand what you're asking for. What doesn't work with input objects today?

I am autogenerating my schema and I think changing the output from that is the right way for me to solve this.


assassin creed origin game frezen when play around 30 min version 2.4  and assassin creed odyssey fps drop Bad performeance when install dxvk all version

Please describe your issue as accurately as possible.
If you use Windows, please check the following page: https://github.com/doitsujin/dxvk/wiki/Windows
Software information
Name of the game, settings used etc.
System information

GPU:  rtx 3090
Driver: 555.99 -560.70
Wine version:
DXVK version: 2.4

Apitrace file(s)

Put a link here

For instructions on how to use apitrace, see: https://github.com/doitsujin/dxvk/wiki/Using-Apitrace
Log files
ACOdyssey_d3d11.log
Please attach Proton or Wine logs as a text file:

When using Proton, set the Steam launch options for your game to PROTON_LOG=1 %command% and attach the corresponding steam-xxxxx.log file in your home directory.
When using regular Wine, use wine game.exe > game.log 2>&1 and attach the resulting game.log file.
ACOdyssey_dxgi.log

assassin creed origin game frezen when play around 30 min version 2.4 and assassin creed odyssey fps drop Bad performeance when install dxvk all version

I've let the game sit on Windows with dxvk 2.4 for half an hour and then after that i played for 35-40 mins but i haven't reproduced anything weird. System memory and vram also seem fine.
Tested on a RTX 4080 with 555.99

I've let the game sit on Windows with dxvk 2.4 for half an hour and then after that i played for 35-40 mins but i haven't reproduced anything weird. System memory and vram also seem fine. Tested on a RTX 4080 with 555.99

assassin creed odyssey fps drop  and stuttering same here. Use everything normally.
ACOdyssey_d3d11.log
ACOdyssey_dxgi.log

Yes I can reproduce that dxvk gives lower performance. At least with Nvidias drivers on Windows, haven't compared to Linux.
Seems to be GPU bound though


LANG-1303 : Escape HTML characters once

Hi, this is my first time contributing to any open source project.
The feature goes as follows:
If already escaped HTML characters are in the input test, they get escaped again using StringEscapeUtils.escapeHtml4().
For example:
If the input is:
100 kg < 1000kg
Then the output of escapeHtml4() becomes:
100kg &lt; 1000kg
At my workplace, we felt the need for a method in StringEscapeUtils which does not escape already escaped characters.

Thanks for the pull request. 👍
StringEscapeUtils was ported to commons-text and will soon deprecated in commons-lang.
It would be nice if you could open a pull request at https://github.com/apache/commons-text
Thanks!

Thanks Pascal.
I have raised a pull request at commons-text: https://github.com/apache/commons-text/pull/23

Thanks Sampanna!
It would be nice if you would close this pull request. (I can not do it easily as this is a read-only repository.)
Thanks!


RPmovieSQLiteNewField and RPmovieNewField has Migrations files broken

Hi,
Actually, the project doesn't work, and especially if I let class RazorPagesMovie.Models.Movie as follow:
        public int ID { get; set; }

But this work if we replace by
        public int Id { get; set; }

I'm on Linux and I've tested with SqlServer. In fact, the official example let this possibility https://github.com/aspnet/Docs/blob/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieSQLiteNewField/Startup.cs .
Maybe, it's normal, because as https://docs.microsoft.com/en-us/ef/core/modeling/keys said, the convention is « By convention, a property named Id or <type name>Id will be configured as the key of an entity. »
Maybe it works on Windows because this system is case insensitive, but maybe doesn't work on Linux because this system is case sensitive.
I havn't a Mac, but maybe this problem could occur on Mac as this system is Case sensitive.
Actually the output is :
Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while updating the entries. See the inner exception for details. ---> System.Data.SqlClient.SqlException: Cannot insert
the value NULL into column 'ID', table 'RazorPageMovie.dbo.Movie'; column does not allow nulls. INSERT fails.
The statement has been terminated.
   at System.Data.SqlClient.SqlCommand.<>c.<ExecuteDbDataReaderAsync>b__122_0(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteAsync(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues,
 CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.ExecuteAsync(IRelationalConnection connection, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.ExecuteAsync(IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.ExecuteAsync(DbContext _, ValueTuple`2 parameters, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.ExecuteAsync[TState,TResult](TState state, Func`4 operation, Func`4 verifySucceeded, Cancellation
Token cancellationToken)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChangesAsync(IReadOnlyList`1 entriesToSave, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChangesAsync(Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.DbContext.SaveChangesAsync(Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at RazorPagesMovie.Pages.Movies.CreateModel.OnPostAsync() in /tmp/RazorPagesMovie/RPmovieSQLiteNewField/Pages/Movies/Create.cshtml.cs:line 45
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.ExecutorFactory.GenericTaskHandlerMethod.Convert[T](Object taskAsObject)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.ExecutorFactory.GenericTaskHandlerMethod.Execute(Object receiver, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker.InvokeHandlerMethodAsync()
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker.InvokeNextPageFilterAsync()
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker.Rethrow(PageHandlerExecutedContext context)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker.InvokeInnerFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Thanks in advance for your answer !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

An other solution is to add [key] on the line above like this:
        [Key]
        public int ID { get; set; }

@Rick-Anderson I could make the PR if you want ;-).

@JulioJu 	thanks for the offer, but it's more complicated with all the code and the docs. We'll get this fixed when we do the 3.0 version.
Thanks again for the offer.

@Rick-Anderson
I've tested again, and our analyses was completely false. Sorry.
I've tested again because as I'm new on dotnet I like to use your out-of-box samples to understand well some concepts. And I've discovered that uppercase ID work fine for Contoso sample. Therefore I've investigate further.

For:

RPmovieSQLiteNewField https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieSQLiteNewField
RPMovieNewField https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieNewField
On Linux Problem, the problem is not that ID is in uppercase, the problem is with Migrations files. In don't know what this migrations files bugs on Linux, but it's not due of uppercase ID.
Solve perfectly the problem by simply generate completely new Migrations with command :

# See also https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/new-field?view=aspnetcore-2.2&tabs=visual-studio-code
dotnet ef database drop \
  &&  rm -Rf Migrations bin obj \
  && dotnet ef migrations add InitialCreate \
  && dotnet ef database update \
  && dotnet ef migrations add Rating \
  && dotnet ef database update \
  && dotnet watch run

Contoso Example https://github.com/aspnet/Docs/blob/master/aspnetcore/data/ef-rp/intro/samples/cu/Models/Student.cs or
RPMovie Part3 https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovePart3
RPMovieSearch https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieSearch
==> all work fine with ID in uppercase.

Furthermore I've tested the following command without success for RPMovieNewField.
Following demonstrate that current Migration are completely broken on Linux Platform even if we replace all uppercase ID to Id.
find -name "*.cs*" -exec grep --color="always" ID {} + # to check what will be changed.
dotnet ef database drop \
  && find -name "*.cs*" -exec sed -i 's/ID/Id/g' {} + \
  && dotnet ef database update

Sorry for the misinterpretation
If you are ok I could make a PR to generate completely new Migrations files thanks command above for :

RPmovieSQLiteNewField https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieSQLiteNewField
RPMovieNewField https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples/RPmovieNewField

I've generated thanks tools dotnet-ef 2.2.1 (the last one today) and dotnet-core 2.2.102

If your are ok,

I could also add README for https://github.com/aspnet/Docs/tree/master/aspnetcore/tutorials/razor-pages/razor-pages-start/2.2-stage-samples
And I could correct README.md under folder https://github.com/aspnet/Docs/tree/master/aspnetcore/data/ef-rp/intro/samples (cuFinal) does not exists)
And correct error that appears caused of https://stackoverflow.com/questions/50825242/the-type-or-namespace-name-hosting-does-not-exist-in-the-namespace-microsoft

Furthermore there is a but with current

@Rick-Anderson, for this issue, if I understand it correctly, we can't use "ID" even if we are consistent about it because by the time it gets through migrations and data generation it is treated somewhere as "Id" instead?  Is this an issue to also raise for the product migration code?
If I understand what the fix is for the RP series, it is to redo all versions and the sub-variations of app samples (there are a lot in this series) with Id instead of ID, plus of course where it is mentioned in the tutorials?
Just thought I would verify in case the fix is simpler and more isolated than I am understanding it to be.  I didn't want to needlessly redo all the previous versions of the app and sub-variations,  sdk versions, IDE versions and sub-variations (sqlserver and sqlLite), unless that really is the only avenue.   Many thanks for your insight.

I'd put this on hold as we've only had one person report the problem.

@Rick-Anderson,  thanks, I was already feeling like I was overloading the RP 5.0 update as it was with the backlog into a rather large and complicated PR with perhaps too many issues at once.  This one really needs its own dedicated PR if it moves up in the priority list.  It certainly is a n interesting issue though.


Standardize zookeeper host string interface

I cloud see them in document:
pykafka.balancedconsumer.BalancedConsumer

zookeeper_connect  (str) – Comma-separated (ip1:port1,ip2:port2) strings indicating the zookeeper nodes to which to connect.

pykafka.client.KafkaClient

zookeeper_hosts  (str) – KazooClient-formatted string of ZooKeeper hosts to which to connect. If not None, this argument takes precedence over hosts

but i don't know which should be used.
thanks

Thanks for asking, @zpzhoudev. I agree the interface for specifying zookeeper connections could be a bit clearer. The simple answer to your question is that KafkaClient(zookeeper_hosts= can be used alone, without needing to specify zookeeper_connect in the BalancedConsumer constructor. That's because it's passed through to BalancedConsumer via Topic. The KafkaClient kwarg is also used in some situations for initial discovery of the Kafka brokers.
The naming of Zookeeper connection strings in the public interface should be audited and standardized.


Metadata example

Is it possible to have a working example on how to use metadata, especially the duration.
While testing this module, I get an empty string for duration.
	transcoder := ffmpeg.New(ffmpegConf).Input(in)

	metadata, err := transcoder.GetMetadata()
	if err != nil {
		return err
	}
	duration := metadata.GetFormat().GetDuration()
	fmt.Println(duration)

	_, err = transcoder.
		Output(out).
		WithOptions(opts).
		Start(opts)

        if err != nil {
		return err
	}

why is the duration an empty string? and how to fix it?
FWIW the input parameter is a file path something like "/tmp/jfkldflas.webm"

Same here, plus there's stuff not considered (thus not being parsed) like the language of the streams.


haskell.compiler.ghc8102Binary: don't pass llvmPackages_9

prepare to drop LLVM9 from nixpkgs
follow the same pattern as 274c1f0970e715ba4793fcd68b666af03a79a83e which dropped support for LLVM6.
I'm not familiar with Haskell or this tool chain so this modification could be incorrect but hoping that dropping support for LLVM9 is as easy as LLVM6.
Nothing to be built.
Result of nixpkgs-review run on x86_64-linux 1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

well, aarch64-linux is failing the assertion so this doesn't seem like as simple of a removal as LLVM6.

going to go a different direction with this one. can't remove the llvm reference nor the consumer.


Fixed Style action

It seems that the go version needs to change to everything involved in the action

We want to move to go1.19 though

/hold

Hmmm then let me try the workaround then

This comment says the new version works
https://github.com/golangci/golangci-lint/issues/3107#issuecomment-1293586494

/lgtm
/approve

/hold cancel


[SPARK-28294][CORE] Support spark.history.fs.cleaner.maxNum configuration

What changes were proposed in this pull request?
Up to now, Apache Spark maintains the given event log directory by time policy, spark.history.fs.cleaner.maxAge. However, there are two issues.

Some file system has a limitation on the maximum number of files in a single directory. For example, HDFS dfs.namenode.fs-limits.max-directory-items is 1024 * 1024 by default.
https://hadoop.apache.org/docs/r3.2.0/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml
Spark is sometimes unable to to clean up some old log files due to permission issues (mainly, security policy).

To handle both (1) and (2), this PR aims to support an additional policy configuration for the maximum number of files in the event log directory, spark.history.fs.cleaner.maxNum. Spark will try to keep the number of files in the event log directory according to this policy.
How was this patch tested?
Pass the Jenkins with a newly added test case.

Test build #107329 has started for PR 25072 at commit 59277d6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12471/
Test PASSed.

Test build #107329 has finished for PR 25072 at commit 59277d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107329/
Test PASSed.

Thank you for review, @srowen ! I'll update soon.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12503/
Test PASSed.

Test build #107366 has started for PR 25072 at commit 84ed42b.

Could you review once more? I addressed some of the comments. For the followings, please let me know your opinion if I missed the point. I can update more.

val oldAttempts = listing.view(classOf[ApplicationInfoWrapper]) (https://github.com/apache/spark/pull/25072#discussion_r301225173)
var deleted = false (https://github.com/apache/spark/pull/25072#discussion_r301226054)

Test build #107368 has started for PR 25072 at commit 3444b73.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12505/
Test PASSed.

For the default value, I agree with your concerns.
Although this default value, 1M, is big enough not to surprise general HDFS-default users. But, there might be two exceptions.

If they increase dfs.namenode.fs-limits.max-directory-items configuration already, the maximum is 6 * 1024 * 1024.
If they are using non-HDFS storage. Maybe, S3?

So, not to surprise all users including S3, do you want me to use Int.MaxValue instead? I can change like that. Technically, that will disable this feature, but spark.history.fs.cleaner.enabled itself is disabled by default, too.

The default value is increased to Int.MaxValue, too.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12506/
Test PASSed.

Test build #107369 has started for PR 25072 at commit f2c93a0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12507/
Test PASSed.

Test build #107366 has finished for PR 25072 at commit 84ed42b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107366/
Test FAILed.

Test build #107369 has finished for PR 25072 at commit f2c93a0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107369/
Test FAILed.

Test build #107368 has finished for PR 25072 at commit 3444b73.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107368/
Test PASSed.

Hi, @srowen .
Could you review this once more please?

Thank you so much for review and approval, @srowen !
Yes. I'll wait for @vanzin 's comment for one day.
Hi, @vanzin . Could you take a look at this if you have some time?

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12553/
Test PASSed.

Test build #107417 has started for PR 25072 at commit f2c93a0.

Test build #107417 has finished for PR 25072 at commit f2c93a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107417/
Test PASSed.

Merged to master. Thank you, @srowen .


Uncaught Exception: The Internet connection appears to be offline.: (null)

An uncaught exception was reported.
Info:
OS: darwin
Arch: x64
GPMDP Version: 3.0.0
Time: Mon Mar 07 2016 00:38:25 GMT-0600 (CST)
Error:
The Internet connection appears to be offline.: (null)
Error: The Internet connection appears to be offline.: (null)
    at Error (native)

This issue was created automatically inside the uncaughtException handler

Client side net issue, not internal


Can't download from criterionchannel.com, unsupported URL

Checklist

[ x] I'm reporting a broken site support
[ x] I've verified that I'm running youtube-dl version 2021.12.17
[ x] I've checked that all provided URLs are alive and playable in a browser
[ x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-u', 'PRIVATE', '-p', 'PRIVATE', 'https://www.criterionchannel.com/high-and-low/videos/high-and-low']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.9.7 (CPython) - macOS-10.16-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] high-and-low: Requesting header
WARNING: Falling back on generic information extractor.
[generic] high-and-low: Downloading webpage
[generic] high-and-low: Extracting information
ERROR: Unsupported URL: https://www.criterionchannel.com/high-and-low/videos/high-and-low
Traceback (most recent call last):
  File "/Users/mth/opt/anaconda3/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/mth/opt/anaconda3/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/Users/mth/opt/anaconda3/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/Users/mth/opt/anaconda3/lib/python3.9/site-packages/youtube_dl/extractor/generic.py", line 3489, in _real_extract
    raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.criterionchannel.com/high-and-low/videos/high-and-low

Description

I'm brand new using youtube-dl, but I think I followed the directions.  Am trying to record a movie from criterionchannel.com but I get the "Unsupported URL" error each time.  I can play the indicated URL ok in my browser (Firefox).  My system is an M1 MacBook Pro running MacOS 12.0.1.  I searched the bug database, and saw a couple of similar bugs which were closed, but nothing recent.

If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6

https://github.com/FiloSottile/age

If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6

https://github.com/FiloSottile/age

This (ie the penultimate line) in the page doesn't appear encouraging:
window.VHX.video = {
      id: "465719",
      status: "pending",
      isLive: "false",
      scheduled_at: "",
      isDRM: "true",
      isTrailer: "false",
    };

This (ie the penultimate line) in the page doesn't appear encouraging:
window.VHX.video = {
      id: "465719",
      status: "pending",
      isLive: "false",
      scheduled_at: "",
      isDRM: "true",
      isTrailer: "false",
    };

Not supported https://github.com/ytdl-org/youtube-dl/search?q=criterionchannel&state=open&type=issues

Not supported https://github.com/ytdl-org/youtube-dl/search?q=criterionchannel&state=open&type=issues

So also, duplicate of #20408.

So also, duplicate of #20408.

-----BEGIN AGE ENCRYPTED FILE-----
YWdlLWVuY3J5cHRpb24ub3JnL3YxCi0+IFgyNTUxOSBZd1ArR2ZDK0pxMHhjUHJN
NTZBVDZ2eWw0OFdMR21JblZiYzB6QmFXTHhzCnBITCtJYmNFVlRRbURFWTFBVTBC
R1lpL29pVWduWFFiVCt4ejUvcmd6L0UKLS0tIFhLcDlpZFdLVkY1RGtqd0ZtYWZK
ZTRTZUU3SExDZlFXMjVOanBSOVlIcDgKeArGd3wY56NUnIG3Z/oJHNedTR39QZWY
e55FBSPuTLC6pFKYXLNItIH39jKaYhmDfsjZqEljvZ7MzTdSwTU=
-----END AGE ENCRYPTED FILE-----

On Dec 31, 2021, at 8:16 PM, Zombo @.***> wrote:
If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6
https://github.com/FiloSottile/age https://github.com/FiloSottile/age
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003494914, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVXYERR4VCLOMLZHX6GDUTZWYVANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

-----BEGIN AGE ENCRYPTED FILE-----
YWdlLWVuY3J5cHRpb24ub3JnL3YxCi0+IFgyNTUxOSBZd1ArR2ZDK0pxMHhjUHJN
NTZBVDZ2eWw0OFdMR21JblZiYzB6QmFXTHhzCnBITCtJYmNFVlRRbURFWTFBVTBC
R1lpL29pVWduWFFiVCt4ejUvcmd6L0UKLS0tIFhLcDlpZFdLVkY1RGtqd0ZtYWZK
ZTRTZUU3SExDZlFXMjVOanBSOVlIcDgKeArGd3wY56NUnIG3Z/oJHNedTR39QZWY
e55FBSPuTLC6pFKYXLNItIH39jKaYhmDfsjZqEljvZ7MzTdSwTU=
-----END AGE ENCRYPTED FILE-----

On Dec 31, 2021, at 8:16 PM, Zombo @.***> wrote:
If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6
https://github.com/FiloSottile/age https://github.com/FiloSottile/age
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003494914, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVXYERR4VCLOMLZHX6GDUTZWYVANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

-----BEGIN AGE ENCRYPTED FILE-----
YWdlLWVuY3J5cHRpb24ub3JnL3YxCi0+IFgyNTUxOSBZd1ArR2ZDK0pxMHhjUHJN
NTZBVDZ2eWw0OFdMR21JblZiYzB6QmFXTHhzCnBITCtJYmNFVlRRbURFWTFBVTBC
R1lpL29pVWduWFFiVCt4ejUvcmd6L0UKLS0tIFhLcDlpZFdLVkY1RGtqd0ZtYWZK
ZTRTZUU3SExDZlFXMjVOanBSOVlIcDgKeArGd3wY56NUnIG3Z/oJHNedTR39QZWY
e55FBSPuTLC6pFKYXLNItIH39jKaYhmDfsjZqEljvZ7MzTdSwTU=
-----END AGE ENCRYPTED FILE-----

On Dec 31, 2021, at 8:16 PM, Zombo @.***> wrote:
If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6
https://github.com/FiloSottile/age https://github.com/FiloSottile/age
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003494914, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVXYERR4VCLOMLZHX6GDUTZWYVANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

-----BEGIN AGE ENCRYPTED FILE-----
YWdlLWVuY3J5cHRpb24ub3JnL3YxCi0+IFgyNTUxOSBZd1ArR2ZDK0pxMHhjUHJN
NTZBVDZ2eWw0OFdMR21JblZiYzB6QmFXTHhzCnBITCtJYmNFVlRRbURFWTFBVTBC
R1lpL29pVWduWFFiVCt4ejUvcmd6L0UKLS0tIFhLcDlpZFdLVkY1RGtqd0ZtYWZK
ZTRTZUU3SExDZlFXMjVOanBSOVlIcDgKeArGd3wY56NUnIG3Z/oJHNedTR39QZWY
e55FBSPuTLC6pFKYXLNItIH39jKaYhmDfsjZqEljvZ7MzTdSwTU=
-----END AGE ENCRYPTED FILE-----

On Dec 31, 2021, at 8:16 PM, Zombo @.***> wrote:
If you can provide credentials I can try to fix it. Run the following command and reply back with the output:
echo USER:PASS | age -a -r age1zkz9g0kld97vs826j0r7p3ghvz3zcyd4tcqr2vrxpt0uux7mkycsl77hy6
https://github.com/FiloSottile/age https://github.com/FiloSottile/age
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003494914, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVXYERR4VCLOMLZHX6GDUTZWYVANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

P.S. Thanks for taking a look.  Please let me know when you’re done with my account info (so I can change the password).
Michael

On Dec 31, 2021, at 9:17 PM, dirkf @.***> wrote:
So also, duplicate of #20408 https://github.com/ytdl-org/youtube-dl/issues/20408.
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003502142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVX7LZZZD2ABIB3WBGLTUTZ54XANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

P.S. Thanks for taking a look.  Please let me know when you’re done with my account info (so I can change the password).
Michael

On Dec 31, 2021, at 9:17 PM, dirkf @.***> wrote:
So also, duplicate of #20408 https://github.com/ytdl-org/youtube-dl/issues/20408.
—
Reply to this email directly, view it on GitHub https://github.com/ytdl-org/youtube-dl/issues/30449#issuecomment-1003502142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNPVX7LZZZD2ABIB3WBGLTUTZ54XANCNFSM5LCAOU6Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Thanks, I was able to log in. The media links are easily available:
https://drm.vimeocdn.com/1641090211-0xa72ebd75caa973a40bb219b0f03ab854de999dcd/01/432/13/327163529/1281250748,1281250737,1281250749,1281250740/1281250749-4-t1.m4s?assetId=327163529
but as other mentioned, they are protected by Vimeo DRM. So I think I cannot help in this case.

Thanks, I was able to log in. The media links are easily available:
https://drm.vimeocdn.com/1641090211-0xa72ebd75caa973a40bb219b0f03ab854de999dcd/01/432/13/327163529/1281250748,1281250737,1281250749,1281250740/1281250749-4-t1.m4s?assetId=327163529
but as other mentioned, they are protected by Vimeo DRM. So I think I cannot help in this case.

I have tried as well and (although not helpful) believe that VIMEO DRM prevents me from doing the same. I am getting the same "unsupported url" error

I have made an implementation if anyone is interested:
msg=GET URL="https://api.vhx.com/videos/high-and-low?url=high-and-low"
msg=GET URL=https://api.vhx.tv/videos/465719/files
msg=GET URL="https://player.vimeo.com/skyfire/redirect/327163529.mpd?drm=1&expires=1716223514&hevc=0&max_height=1080&pssh=0&sig=266e5a12c1738995dfd7b2c7ad6fe5b2893c9e9e&text_tracks=1"
msg=GET URL="https://drm.vimeocdn.com/1716223514-0x13058bcb0aadd8a68af98b312f764f25f715c446/01/432/13/327163529/1281250749,1281250740,1281250748,1281250737/master.mpd?assetId=327163529&pssh=0"
msg=GET URL="https://drm.vimeocdn.com/1716223514-0x13058bcb0aadd8a68af98b312f764f25f715c446/01/432/13/327163529/1281250749,1281250740,1281250748,1281250737/1281250749-0-t1.m4s?assetId=327163529"
msg=POST URL="https://drm.vhx.com/v2/widevine?token=eyJhbGciOiJIUzI1NiJ9.eyJhc3NldF9pZCI6MzI3MTYzNTI5LCJ2aWRlb19pZCI6NDY1NzE5LCJjbGlwX2lkIjozMjcxNjM1MjksImV4cCI6MTcxNjIyNzExNCwib2ZmbGluZV9saWNlbnNlIjpmYWxzZSwiaGRjcCI6dHJ1ZX0.zdY26ojdbMte1plPiGbni2eSqpumFoI93Sa5Eu-cO1Y"
msg="0.47 %" size="19.87 megabyte" rate="19.87 megabyte/s"