Using docker run with config file

Hey,
I thought it would be great if we can use docker run with config.yaml propertyfiles or anything like that.
I can preconfigure all container links, env variables and other things in normal readable/modifyable format.
Then just docker run --script link_group.yml
This could be very usefult to stay away of long attributes (and repeated operations when running several containers together) passed everytime to the container when we run it.
But anyways, that's again just a thought to discuss.
Thank you for your attention.

Checkout github.com/docker/fig

@jfrazelle thank you very much :)

This has been discussed in detail here https://github.com/docker/docker/issues/9694


Upgrade to OpenTelemetry 1.0 RC3

This version brings a couple of changes, most of which are
improvements:

You no longer need to register an application tracer, this is done automatically on library level.
:otel_propagator.text_map.extract/1 becomes :otel_propagator_text_map.extract/1

This should be released as a tag with version.
Signed-off-by: Maciej Szlosarczyk<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from maciej-szlosarczyk after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: a77879623d0600a146fab30f30bf88236f64538f

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Vollmond
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Vollmond]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix/drop console 2807

Fix issue #2807

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you move tests to https://github.com/swc-project/swc/tree/bfa645873710c07a77658ed0472ff817de6d10a5/crates/swc_ecma_minifier/tests/compress/fixture/issues and remove output.terser.js?
tests/terser is used for tests ported from terser.

Oh, I'm so sorry. I didn't notice this, thank you for your reminder.


Introduce JobState

Introduce the new JobState struct and a call GetJobState to fetch the job state using the new experimental low-profile API call.

Proposal for https://github.com/grisu48/gopenqa/issues/23

Function tested manually.


TPU setup in docs results in import failure for flash.Task

I am following TPU setup instructions on a clean Colab notebook. When I do so and attempt to import flash.Task I get the following error:
ImportError: /usr/local/lib/python3.7/dist-packages/_XLAC.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN2at13_foreach_add_EN3c108ArrayRefINS_6TensorEEENS1_INS0_6ScalarEEE
This is being run on Colab Pro with TPU enabled.

Actually, looking at the install log, I see the following:
ERROR: torch-1.15-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.
ERROR: torch_xla-1.15-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.
ERROR: torchvision-1.15-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.

It looks like the install instructions need to be updated.

Here a Google Colab that shows the issue:
https://colab.research.google.com/github/PytorchLightning/pytorch-lightning/blob/master/notebooks/06-mnist-tpu-training.ipynb
need to find new wheels

oh wow
it's because google colab recently switched the default python version from python 3.6 to 3.7.
This link works:
! pip install https://storage.googleapis.com/tpu-pytorch/wheels/torch_xla-1.7-cp37-cp37m-linux_x86_64.whl
You just have to replace 36 with 37 :)
I will update the notebooks


Support private docker registry for controller

Private docker registry useful for use standalone/internal k8s and for minimize traffic to Google docker registry.
Due agones.image.registry used for controller and sidecar - fleets and gameservers also MUST use secret via PodTemplate
apiVersion: "stable.agones.dev/v1alpha1"
kind: Fleet
...
spec:
...
  template:
    spec:
...
      template:
        spec:
          containers:
          - name: simple-udp
            image: <private registry address>/udp-server:0.3
          imagePullSecrets:
            - name: <docker registry secret name from fleet namespace>

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

I signed it!

I think this is a subset of #349 , isn't it? :thinking:

I think this is a subset of #349 , isn't it? 🤔

o_O yes! Maybe one agones.image.registry for controller and sidecar it's mistake?

Well, I don't know about other people but I would prefer to use my own secret yaml named as I want 🤔
And yes, you need that secret both for controller and sidecar, and it needs to be installed in both namespaces.

I have Cloud priveledge :smile: , so not sure I 100% understand the issues at play here, but can we close this PR now that #349 is merged or is there more to discuss here?

@Oleksii-Terekhov you can do the same thing using the Makefile now.
See https://github.com/GoogleCloudPlatform/agones/tree/master/build#running-a-custom-test-environment

Or I would assume, through the documented helm parameters, if they are not using the development tools (which I assume they are not here?)

OK. I close PR. But please add documentation/examples about ImagePullSecrets for controller, sidecar and gameServer (not all end users may able read helm charts or go code or build#running-a-custom-test-environment documentation for realize this possibility)


PDF display with Adobe plugin does not work in Bootstrap modal

Unfortunately, it seems that plugin content is not displayed correctly in a modal. This leaves us more or less with two options:

Use something like PDF.js to always convert PDFs to HTML
Use the old popup code

I think I prefer option 1, as this would allow us to integrate Hypothes.is as well.

Fixed by integrating pdf.js-hypothesis.js.


Add sponsors to index page

This adds our sponsors to the home page.

@harding - this adds the data, but it doesn't look very good yet!
It'd be nice if we could have the sponsors presented in a grid, similar to how the contributors were shown in bitcoincore.org prior to https://github.com/bitcoin-core/bitcoincore.org/commit/c8618b1359005d78b584c95b73d3856a84c52736. Is that possible within the minimal jekyll theme that we're using?

I've added fontawesome to address the comment here: https://github.com/bitcoinops/bitcoinops.github.io/pull/10#issuecomment-401208913 . @harding - do the last two commits look like the right approach?
I'm still waiting to get a good quote from Wences, and probably also update the quote from Chaincode.

@jnewbery LGTM with one suggestion:
diff --git a/assets/css/main.scss b/assets/css/main.scss
index 6e2907b..91a0511 100644
--- a/assets/css/main.scss
+++ b/assets/css/main.scss
@@ -34,11 +34,13 @@ br.clear {

 p.sponsor-quote {
         font-style: italic;
+        margin-top: 20px;
 }

 .sponsors h3 {
         font-weight: 700;
         font-size: 120%;
+        margin-bottom: 0;
 }

 // The long text quotes make this application of a two-column list

Currently it's,
Name

Twitter
Paragraph of text

This makes it,
Name
Twitter link

Paragraph of text

Which seems more natural to me.

rebased

I have approval for all three quotes from the sponsors, so I think this is ready for merge.
@harding / @moneyball - are you happy for this to go in?


Problem rendering dashboard from Tableau Online in Salesforce mobile app

It is not possible to view a dashboard in Tableau Online from in Salesforce Mobile.
Steps To Reproduce:

Use LWC to embed a dashboard from Tableau Online into Salesforce
Use the phone preview in Salesforce. This succeeds when the mobile form factor is enabled (see other bug).
Go to the Salesforce org in the Salesforce app on your mobile device
On the mobile app navigate to the page with the LWC embedded.
Log on when prompted to Tableau Online
You will then see redirects happening a couple times but are not able to select viewing the dashboard in Tableau Mobile
You end up landing on a blank page.

Expected result
You are able to see the dashboard embedded in the Salesforce mobile app.
Actual result
You see a blank page where the dashboard should be.
Additional information

I can confirm that this also happens on a cloud based Tableau Server, not exclusive to Tableau Online.

I ran into this issue when SSO was not set up correctly. Once I fixed SSO and updated settings in Tableau Online to the following, I was able to access Tableau dashboard within Salesforce mobile

Tried the embedding options that you've proposed above but still the Tableau Viz component couldnt load the dashboard in Salesforce mobile apps. Got the error as follow: https://ibb.co/tmWcdWq

I ran into this issue when SSO was not set up correctly. Once I fixed SSO and updated settings in Tableau Online to the following, I was able to access Tableau dashboard within Salesforce mobile

Tried the embedding options that you've proposed above but still the Tableau Viz component couldnt load the dashboard in Salesforce mobile apps. Got the error as follow: https://ibb.co/tmWcdWq

I ran into this issue when SSO was not set up correctly. Once I fixed SSO and updated settings in Tableau Online to the following, I was able to access Tableau dashboard within Salesforce mobile

Hi @jutamind - Which IdP are you using?

Hi @jutamind - Which IdP are you using?

Azure AD
On Wed, Jan 13, 2021, 1:10 AM Geraldine Zanolli<EMAIL_ADDRESS>wrote:

Hi @jutamind https://github.com/jutamind - Which IdP are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tableau/tableau-viz-lwc/issues/27#issuecomment-758805113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASFKSQOIBJVGEBG7Q3TXS4DSZR7ALANCNFSM4NGHKEXA
.

Azure AD
On Wed, Jan 13, 2021, 1:10 AM Geraldine Zanolli<EMAIL_ADDRESS>wrote:

Hi @jutamind https://github.com/jutamind - Which IdP are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tableau/tableau-viz-lwc/issues/27#issuecomment-758805113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASFKSQOIBJVGEBG7Q3TXS4DSZR7ALANCNFSM4NGHKEXA
.

Thank you for your quick answer. Microsoft has blocked all in-frame authentication and it cannot be enabled. Instead, Microsoft only supports pop-up authentication in a second window. As a result, the Mobile App is not going to work. The workaround for the moment is to use Sparkler: https://kb.tableau.com/articles/Issue/tableau-viz-lightning-web-component-does-not-work-on-salesforce-classic?_ga=2.262602188.1376070805.1610407075-1522774385.1608684711&_fsi=NoOuGy5v

Thank you for your quick answer. Microsoft has blocked all in-frame authentication and it cannot be enabled. Instead, Microsoft only supports pop-up authentication in a second window. As a result, the Mobile App is not going to work. The workaround for the moment is to use Sparkler: https://kb.tableau.com/articles/Issue/tableau-viz-lightning-web-component-does-not-work-on-salesforce-classic?_ga=2.262602188.1376070805.1610407075-1522774385.1608684711&_fsi=NoOuGy5v

@illonage , so are you saying that we use Tableau Viz component for desktop view and Sparkler for mobile view, ie 2 components to be added to expose 1 dashboard to the users? If so, how do i filter the component visibility so that Sparkler component is only viewable on mobile view and vice versa?

@illonage , so are you saying that we use Tableau Viz component for desktop view and Sparkler for mobile view, ie 2 components to be added to expose 1 dashboard to the users? If so, how do i filter the component visibility so that Sparkler component is only viewable on mobile view and vice versa?

@jutamind sorry for the confusion. You should use Sparkler for mobile and desktop for now.

@jutamind sorry for the confusion. You should use Sparkler for mobile and desktop for now.

Hello @illonage ,

The need is to embed Tableau server dashboard in Salesforce using Tableau LWC(Lightning web component) and use SSO if user has already signed in to Salesforce (Seamless authentication) .
Both Salesforce and Tableau server uses the same Okta IdP.
We are able to view the Tableau Server Sign-in page after embedding the dashboard URL using Tableau LWC. When we click on the sign-in button, popup will open trying to authenticate and close automatically then redirects back to the same sign-in page.
What step are we missing?
Do we need to enable iframe (in-frame authentication) in Tableau Server as well as in Okta ?
Help us out in enabling a seamless navigation between Salesforce and Tableau Server.
Identity Provider : OKTA
Tableau Server - 2018.1 and OKTA SAML Enabled
Salesforce - OKTA SAML Enabled

Hello @illonage ,

The need is to embed Tableau server dashboard in Salesforce using Tableau LWC(Lightning web component) and use SSO if user has already signed in to Salesforce (Seamless authentication) .
Both Salesforce and Tableau server uses the same Okta IdP.
We are able to view the Tableau Server Sign-in page after embedding the dashboard URL using Tableau LWC. When we click on the sign-in button, popup will open trying to authenticate and close automatically then redirects back to the same sign-in page.
What step are we missing?
Do we need to enable iframe (in-frame authentication) in Tableau Server as well as in Okta ?
Help us out in enabling a seamless navigation between Salesforce and Tableau Server.
Identity Provider : OKTA
Tableau Server - 2018.1 and OKTA SAML Enabled
Salesforce - OKTA SAML Enabled

Hi @SamarthaJanney,
In which browser are you experiencing that? You need to enable iframe authentication in Okta

Also in Tableau Server: https://kb.tableau.com/articles/howto/embedding-tableau-server-dashboards-into-a-website-without-prompting-for-credentials
I hope it helps,
Gigi

@lzachary I am facing the same issue where I see a blank screen on Salesforce mobile app where I should see the Tableau dashboard. It works well on chrome on desktop. Were you able to resolve this or implement any workaround of any sorts to make it work?

Resolution - https://help.salesforce.com/articleView?id=sf.branded_apps_cross_site_tracking.htm&type=5

Tableau Viz LWC is being Archived
All outstanding PRs and Issues are being addressed and closed. Please migrate to the new Tableau View LWC.
For more information about why the Tableau Viz LWC is being replaced by the Tableau View LWC, please see the README

Hi all, fortunately the new Tableau View LWC with seamless auth unlocks most Salesforce mobile app scenarios by allowing the component to authenticate to Tableau using JWTs. This obviates the need to allow in-frame authentication. If you run into issues using the new Tableau View LWC, please open a case through Salesforce.


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: http://www.openarena.ws/download.php
Publisher: Free software community
Package Name: OpenArena
Description: Free and open-source first-person shooter, and a video game clone of Quake III Arena.
Package Version:  0.8.8
Installer URL: http://www.openarena.ws/download.php?view.4

[Policy] zip-binary

[Policy] Unblocked; Will require ManifestVersion: 1.9.0 with ArchiveBinariesDependOnPath: true


Allow copy/paste to work in Release Notes

Issue Type: Bug
This issue relates to https://github.com/microsoft/vscode/issues/32524
Steps to Reproduce:

Open a Release Note
Select some text
copy (cmd + c)

Expected Results:
Should copy the selected text to allow and paste where needed
Actual Results:
I can't copy any content/text inside release notes
There is no context menu
Same issue in extensions
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:47:44.719Z)
OS version: Darwin x64 19.0.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (2.15GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

cmd+c works for me. Is this just the context menu?

It seems to be fixed in the last Release Notes, still the same problem in the extension page.


SocketIO support

I'm very excited for this package, but in ma current server I use SocketIO and not simply Ws. Will we have any chance to have SocketIO support into this lib?

which features do you have in socketIO that not have in get server?

which features do you have in socketIO that not have in get server?

Nothing particular, currently I use NestJS with SocketIO and Redis support as Backend , and I was trying to understand if there were alternatives in Dart. WebSocket is not quite like SocketIO, so I was wondering if SocketIO support already existed

Nothing particular, currently I use NestJS with SocketIO and Redis support as Backend , and I was trying to understand if there were alternatives in Dart. WebSocket is not quite like SocketIO, so I was wondering if SocketIO support already existed

WebSocket is not quite like SocketIO

Right, but what is the difference between them? I'm trying to understand what you need, because you already can use socket using GetServer, and if you are using Get for flutter frontend, will be more easy connect them

WebSocket is not quite like SocketIO

Right, but what is the difference between them? I'm trying to understand what you need, because you already can use socket using GetServer, and if you are using Get for flutter frontend, will be more easy connect them

I can analyze this request for appeal, but I will state my pure opinion here.
I used socket.io for years on node.js, and 100% of my projects with socket.io had to be migrated to Uws or websockets at some point, because it has a lot of bottlenecks.
The only advantage of socket.io in my point of view, has already been overcome and has become a disadvantage, which was the possibility of working with long pooling in environments that do not support websockets. It happens that nowadays websockets have support in basically all browsers, and using Flutter (mainly using Getx that has GetConnect) you will have 100% integration, both browser, both mobile, without any effort.
So I'm going to change this discussion a little bit to:
What resource do you need in socket.io that you don't have in the websocket (and more specifically in GetSocket)?
There is already a lot of abstraction like socket.on, socket.emit, socket.join (for rooms), socket.leave (to leave rooms), and all of this with a very low cost, and low latency, which certainly surpasses much the Socket.io with node.js.

I can analyze this request for appeal, but I will state my pure opinion here.
I used socket.io for years on node.js, and 100% of my projects with socket.io had to be migrated to Uws or websockets at some point, because it has a lot of bottlenecks.
The only advantage of socket.io in my point of view, has already been overcome and has become a disadvantage, which was the possibility of working with long pooling in environments that do not support websockets. It happens that nowadays websockets have support in basically all browsers, and using Flutter (mainly using Getx that has GetConnect) you will have 100% integration, both browser, both mobile, without any effort.
So I'm going to change this discussion a little bit to:
What resource do you need in socket.io that you don't have in the websocket (and more specifically in GetSocket)?
There is already a lot of abstraction like socket.on, socket.emit, socket.join (for rooms), socket.leave (to leave rooms), and all of this with a very low cost, and low latency, which certainly surpasses much the Socket.io with node.js.

Since this feature is not needed, I am closing this


engine: put tiltfile errors in the global log

Hello @jazzdan,
Please review the following commits I made in branch nicks/ch1073/errors:
9da8e07456adec506873facacc5eac56877d86c5 (2018-12-19 17:05:10 -0500)
engine: put tiltfile errors in the global log

(i'm not sure this is the right solution, but it's at least more consistent)


discord timestamps used in invalid embed fields

The discord Markdown timestamps introduced in #1666 are invalid in some embed fields like footers where they will render as plaintext leading ton on human readable data being sent.
The watchchannel send_header method tries to use a timestamp in the footer
https://github.com/python-discord/bot/blob/4d62dadc4d19f0c17d5cda8748c3fc520f2adccf/bot/exts/moderation/watchchannels/_watchchannel.py#L285-L296

And a reminder that's late tries to use a timestamp as a name in the author field
https://github.com/python-discord/bot/blob/4d62dadc4d19f0c17d5cda8748c3fc520f2adccf/bot/exts/utils/reminders.py#L191-L194

There's a similar issue with this log message
https://github.com/python-discord/bot/blob/ad163c41e097c95bda033007b7422b129cdbbcf1/bot/exts/moderation/stream.py#L140-L141
From this and my experience with #1721, it's become evident that #1666 was not thoroughly reviewed and tested. It's a bit concerning that several obvious errors were missed, but that might just be me having the power of hindsight. I think it's worth reviewing all uses of these Discord timestamp utility functions to make sure they're only used where they render properly.

I'd like to take this issue, if it's up for grabs.
(As a matter of fact, this issue has been already patched in case of the reminders)

From searching for around 30 minutes, the only issue that remains today that I could find was the log statement in Mark's above comment, and in discussion with @D0rs4n we decided it's not really worth PRing a fix since it has humanised time with it anyway.
As such, this issue can likely be closed, but @D0rs4n wishes to take a look themselves before we do so.

Yeah, I went through all the possible places where this could go wrong, and I could only find that log statement as well.
I observed this log statement more, and I believe it would be great if we could refactor this log message, though. Just for the sake of consistency.
So I'll keep this issue open, it should be a fairly easy patch.
(The mentioned log message again:
https://github.com/python-discord/bot/blob/9bae829f91c00f89fd1e725036f4d24ec796410b/bot/exts/moderation/stream.py#L137
)

@D0rs4n done in #2100 :+1:


Multicast channel with remote & local client - cant receive on both at the same time

I dont seem to be able to run a subscriber locally & remotely at the same time - is this normal or is there a config I have missed?
Publisher on box local ip
./StreamingPublisher -c "aeron:udp?endpoint=<IP_ADDRESS>:20121|interface=local ip" -m<PHONE_NUMBER>
I can run multiple clients on remote box, and they receive data e.g.
./RateSubscriber -c "aeron:udp?endpoint=<IP_ADDRESS>:20121|interface=remote ip"
If I run a local client also e.g.
./RateSubscriber -c "aeron:udp?endpoint=<IP_ADDRESS>:20121|interface=local ip"
nothing is received by this local client, until the remote ones are killed, then it'll start getting data.
The inverse also occurs i.e. if I start the local client first it'll receive data but the remote ones wont, until the local client killed.

Might be related to #552 , if on that issue the remote client was accidently left running & same thing was done

Might be related to #552 , if on that issue the remote client was accidently left running & same thing was done

This is likely to do with flow control.  The default flow control strategy for the driver is max.  This will mean that slower subscribers that can't keep up will end up missing messages.  To make this work, use |fc=min at the end of the aeron URI and you should see messages on both subscribers (tested locally and I see messages on both subscribers).
More detail on the various forms of flow control and their configuration options are available here: https://github.com/real-logic/aeron/wiki/Flow-and-Congestion-Control#flow-control

This is likely to do with flow control.  The default flow control strategy for the driver is max.  This will mean that slower subscribers that can't keep up will end up missing messages.  To make this work, use |fc=min at the end of the aeron URI and you should see messages on both subscribers (tested locally and I see messages on both subscribers).
More detail on the various forms of flow control and their configuration options are available here: https://github.com/real-logic/aeron/wiki/Flow-and-Congestion-Control#flow-control


Fleshing machine has broken textures

In the hand and inventory it's completely invisible, and in the world it's all black except for what you put in it (including blades)

Cannot reproduce.
What's your modlist?

Cannot reproduce. What's your modlist?

I know this thread is a bit old but I’m experiencing a similar issue. After testing around for a while I believe what happened is OP was, they were using the 1.20.1 version of Immersive Engineering (which is NeoForge) while using Forge 1.20.1. This is what I currently am doing and see a very similar visual error. I was under the impression that all 1.20.1 NeoForge mods would work on 1.20.1 Forge. I can confirm that if switching to NeoForge while using the same mod files this issue will go away. Immersive Engineering seems to work completely fine like this but for some reason the fleshing machine seems to be the only block being affected by this and its texture isn’t loading.


Action for generate CI matrix

I maintain three packages that use maturin-action, and it's great.
The hardest part is setting up CI to generate all the right binaries.
I propose we create a separate action to generate the github actions matrix with the right variables set for maturin-action to use to generate binaries.
The list-python-dependencies package, and in particular it's readme shows the workflow for this:

separate job to generate matrix info
the action outputs a pile of JSON defining the jobs to run and variables required for each job, specifically you need to write to the file defined by the GITHUB_OUTPUT env var - code example here
the first job sets outputs: to include that output
second job defines matrix to read that JSON - in the example case PYTHON_DEPENDENCY_CASE: ${{ fromJSON(needs.find_dependency_cases.outputs.PYTHON_DEPENDENCY_CASES) }}
you then define the maturin-action in the steps for that job

We could have switches to exclude/skip some targets, much like cibuildwheel offers, and a switch for abi3 etc.
A big advantages of this would be that without any extra work from maintainers, more and more targets could be added as maturin-action supports them - or remove if there are known issues.
Example current matrix sections:

rtoml
watchfiles (abi3)
pydantic-core

Demo of how this might finally look in a workflow yaml file:
jobs:
  generate_build_matrix:
    runs-on: ubuntu-latest

    outputs:
      MATURIN_MATRIX: ${{ steps.generate-matrix.outputs.MATURIN_MATRIX }}

    steps:
      - uses: actions/checkout@v3
      - uses: pyo3/maturin-generate-matrix-action@main
        id: generate-matrix
        with:
          exclude: 'win-pypy-*'

  build:
    needs:
      - generate_build_matrix

    strategy:
      # not sure if this actually works or if you need to use a nested matrix namepace as the package above does
      matrix: ${{ fromJSON(needs.generate_build_matrix.outputs.MATURIN_MATRIX) }}

    name: ${{ matrix.name }}
    runs-on: ${{ matrix.runs-on }}

    steps:
      - uses: actions/checkout@v3

      - name: set up python
        uses: actions/setup-python@v4
        with:
          python-version: ${{ matrix.python-version }}
          architecture: ${{ matrix.python-architecture }}

      - run: ...install stuff...

      - name: build
        uses: PyO3/maturin-action@v1
        with:
          command: ${{ matrix.command }}
          target: ${{ matrix.target }}
          manylinux: ${{ matrix.manylinux }}
          container: ${{ matrix.container }}
          args: ${{ matrix.args }}
          # on one combined line:
          matrix_action_config: ${{ matrix.matrix-action-config }}

      - run: twine check --strict ${{ matrix.out-dir }}/*

      - uses: actions/upload-artifact@v3
        with:
          name: pypi_files
          path: ${{ matrix.out-dir }}

@messense do you think you will be able to work on this?
Otherwise, there's a chance the pydantic team might be able to.
@davidhewitt do you have and thoughts on this?

do you think you will be able to work on this?

I'm a bit busy recently, help appreciated!

I think this is done now? At least there's a generate-ci command advertised in the README.

I think generate-ci creates a full github.yml file to commit to the repo. It think we want something similar that you can call in your github action to generate just the build matrix.


PirinelLtd.GitBlade version 1.0.6

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Please make sure to update the folder and file names using GitHub Desktop for Windows from https://desktop.github.com


API Filtering on invalid relation is no longer a silent error

Fixes #5331
CC @sunnysideup  for review please. :D
It has to go into master since introducing new errors would break backwards compatibility.

Looks good, merging


fix 404 Not Found Page on Refresh After Deployment

What does this PR do
This PR addresses issue #36  by fixing the redirecting to 404 not found page on refreshing the page regardless of whether the user has logged in, signed up, or simply navigated to a page that should be accessible
What Changed

update route configuration in vercel.json

How to Test

Navigate to any route within the application (e.g., login, signup, dashboard).
Refresh the page using the browser's refresh button.
Observe the changes.

Related Issues
Fixes #36

Please don't create PR without assigning to you

hey @theashikagupta , from now  i will make sure to follow the required format in future PRs.
For this PR, I've addressed the necessary changes, and I believe it meets the project's requirements. If you could take a look and consider merging it, I would greatly appreciate it.

@Saurabhchaudhary9799 kindly share the screenshots of changes, then we'll merge it
hey @yashmandi  , are you asking for code changes screenshot or visual changes screenshot after changing the code.

@Saurabhchaudhary9799 kindly share the screenshots of changes, then we'll merge it
hey @yashmandi  , are you asking for code changes screenshot or visual changes screenshot after changing the code.

visual changes, what changes have you done in frontend

hey @yashmandi  , the issue was solved by this PR related to after deployment , you can see the  changes after deployement only.


[cluster-test] Add a separate container for debugging validator/fullnode pods.

…ode pods.

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

please remember to revert this change

/land


Error in authentic.pl line 8

Dear,
I have notice that when I run a command like this:
virtualmin modify-user --domain "xxxxx.yyy" --user "zzzz" --disable-email
I have the following error:
Warning: something's wrong at /usr/share/webmin/authentic-theme/authentic.pl line 8.
(event the command was "successfully" executed)
Best regards,

Alright, open /usr/share/webmin/authentic-theme/authentic.pl and remove warn $@; It will be fine after that I believe!


DBZ-8133 Add async engine options also to Debezium server documentation

https://issues.redhat.com/browse/DBZ-8133

Hi @roldanbob I made the suggested edits as Vojta is on PTO this week and responded to your inquiries.  Let me know if there are any other edits needed as I did not make any changes related specifically to the 2 or 3 questioned areas.

Thanks for suggestions @roldanbob ! Applied now, please review again.

Applied, thanks!


How to do something different, if invited user's email already exists?

Scenario:
I have a vanilla User model with devise / devise_invitable fields and a multi-tenant app. Each tenant has its own (scoped) association table for its users (lets call it members) resulting in a many-to-many relationship: Tenant can have many users, User can be member of many tenants.
If a new user gets invited to a tenant, devise_invitable should behave normal. But if an existing user (who is already in the User table) gets invited to another tenant, something different should happen (my own database-foo and sending of a different invitation email text).
So  for testing purposes I created a  Users::InvitationsController, which I filled with a simple:
class Users::InvitationsController < Devise::InvitationsController
   private
      # this is called when creating invitation
      # should return an instance of resource class
      def invite_resource
         ## skip sending emails on invite if user exists
         super do |u|
            u.skip_invitation = true if u.invite_params[:email] ==<EMAIL_ADDRESS>         end
      end
end

to see, if I can switch behaviour.
My console showed me a param hash on invitation with something like:
Parameters: {<EMAIL_ADDRESS>"commit"=>"Invite User"}
But no matter what email I use, skip_invitation gets always triggered, so my guess is the params accessing is faulty.
So I have two questions:

What would be the correct way to access the email field of the invitation?

What would be the correct place in the controller to implement my wanted behaviour switch?

What I wound up doing was re-writing the entire :create method under app/controllers/devise/invitations_controller.rb -- putting in my own, custom logic.  Tad bit complex (way too complex, honestly), but it works.  Mostly; still having issues with the module generating invalid records

invite_resource calls User.invite!, which calls user.invite! if no error. But existing user will have error, so if you want to call invite! instance method, you need to clear errors. With skip_invitation you may avoid generating invitation token and sending email, but it still decrements invitation limit. I don't know if calling super with block is the best approach for your requirements.
Answering your questions:

invite_params, without u.
Probably it's better to override invite_resource to look for existing user, if you find it, do whatever you need, if no user, call super. invite_resource should return user which is invited, if user has no error, devise invitable renders as invitation successful

def invite_resource
  user = User.find_by(email: invite_params[:email])
  if user
     ...
  else
    super
  end
end


Unexpected logging on validation failure

FluentValidation.AspNetCore version
11.1.2
FluentValidation version
N/A
ASP.NET version
.NET 6
Summary
Running inside an AWS Lambda, calling ValidateAndThrowAsync, when validation of an email address fails there is a log sent to AWS CloudWatch:
-- EmailAddress: 'Email Address' is not a valid email address. Severity: Error
This is not coming from my code.  How can I disable logging, or alternatively configure it to log in JSON format?
We have another Lambda that handles our logs that expects everything to be in JSON so the log above is breaking that lambda.
Thanks
Steps to Reproduce
Validate an email address in AWS Lambda.

Calling ValidateAndThrowAsync throws an exception. How this exception is handled, processed and logged is not controlled by FluentValidation - it is up to your application to catch the exception and then process/log it as you require. If you don't catch/process the exception, then Lambda will treat it as unhandled and simply log it as a string.
Alternatively instead of throwing an exception, call ValidateAsync instead which returns a ValidationResult which you can process/serialise/log as you require.
Please note for future reference this is an issue tracker for reporting bugs in the FluentValidation.AspNetCore library - it is not for general support/usage questions.

Something is amiss then - our application throws other exceptions out of the lambda, and those are logged as JSON.

I'm afraid that is something you'll need to debug for yourself. As it isn't something that's being done by FluentValidation this isn't something that I can help with.
The text that you're seeing in the log is the standard ToString() representation of a ValidationException, suggesting that there is nothing handling the exception when it's being thrown, falling back to lambda's default unhandled exception behaviour.
As a starting point I'd suggest you begin troubleshooting by creating a minimal sample project reproduces the issue, stripping out anything unrelated.

Thanks for your time Jeremy.


I cant bind ctrl+alt+d in keybinds

Issue Type: Bug
I cant bind ctrl+alt+d in keybinds. When i try to set that combination it resets the field to only a D when i type the D
VS Code version: Code 1.32.1 (05f146c7a8f7f78e80261aa3b2a2e642586f9eb3, 2019-03-08T00:51:49.278Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz (4 x 2592)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.87GB (1.54GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

vs-jokes
cam
0.0.2

vscode-eslint
dba
1.8.2

gitlens
eam
9.5.1

vscodefy
iag
0.0.11

vscode-icons
rob
8.2.0

quokka-vscode
Wal
1.0.193

vscode-js-console-utils
wht
0.7.0

Please see this page for troubleshooting tips: https://github.com/Microsoft/vscode/wiki/Keybinding-Issues

@diedekerkhof What is shown when you try to press the desired keys? e.g.

Hello sir/madam,
First of all thanks for reaching out to me.
When i press ctrl+alt+d windows places this sign 'ð' and that brakes the
input field, when i press these keys in the input box it resets my input so
that the box is empty or just shows the letter d.
I am running on windows 10
thanks in advance,
Diede Kerkhof
Op wo 27 mrt. 2019 om 16:53 schreef Alexandru Dima<EMAIL_ADDRESS>
:

@diedekerkhof https://github.com/diedekerkhof What is shown when you
try to press the desired keys? e.g.
[image: keyboard-input]
https://cloud.githubusercontent.com/assets/5047891/25478333/fe31c830-2b40-11e7-865c-b2c3bb10dd75.gif
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/70199#issuecomment-477221042,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeFBbHUIMRLj5jJzIuBoPUKPz73EFVYZks5va5PpgaJpZM4boOgW
.

Thanks for replying. This indicates that ctrl+alt+d does not reach VS Code? Have you been able to use this keybinding successfully in other operating systems? Are you also trying with the left ctrl, left alt, and then d ?

I have not used it on other operating systems but i do use both left ctrl
and left alt
Op wo 27 mrt. 2019 om 20:54 schreef Alexandru Dima<EMAIL_ADDRESS>
:

Thanks for replying. This indicates that ctrl+alt+d does not reach VS
Code? Have you been able to use this keybinding successfully in other
operating systems? Are you also trying with the left ctrl, left alt, and
then d ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/70199#issuecomment-477322627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeFBbLbz0DjA7eP6yf7l6Yd4VcHEgaoQks5va8xggaJpZM4boOgW
.

@diedekerkhof Sorry I had a typo. Did you manage to use ctrl+alt+d in any other applications on the same OS?


updated adobe-dng-converter (9.4)

Thank you for the contribution. It needed some fixes, so they were made in a97a631a81af7b6189544e173f47ce6b259959ea. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


[libsquish] Fix usage

Export the INTERFACE_INCLUDE_DIRECTORIES to fix the usage issue.
Fixes #26343.

Thanks!


vim linespace setting doesn't work.

They use the same config, and the linespace is 10, but neovide doesn't set it.
linespace setting only in the GUI, neovide is the GUI 😅
Neovide:

Neovim in terminal:

This is repeat of https://github.com/Kethku/neovide/issues/481


Note app in js

Description
Added a Notes App built on React.
Fixes #7
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update
[x] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@shvam0000 resolve conflict

@Ayush7614 I've resolved all the conflicts, kindly merge


UI for dimensions order

Hi,
First of all, great work, it's indeed really fast and efficient.
Do you plan to add a UI to choose the dimension order, if possible consistent with the other importers?
Would be awesome when it support normals import and Ngons too :)

Well, the current builtin PLY importer also doesn't have an option to map the axes. Nor is there very much consistency among all the Blender importers if such as an option is present ;-)
But I'll leave this one open as a reminder that there's interest in it, will see what I can do in the future.

By the way, importing of vertex normals is already supported

FYI, I updated the module to work with Blender 2.8 and general n-gons are now also supported.


Adding IDE configuration and debugging configuration for VulnerableApp-php

Currently, we are using VSCode as IDE for the project but for debugging we are relying on docker build which takes time. So we need an IDE to run the project and debug it. This issue is used to setup.

Also add the documentation.


Some troubles and rampant speculation.

I'm on Linux. I'm pretty new to VS Code so apologies in advance.
I install the extension.
The doc says to go to Preferences -> Extensions -> VSCode Default Keybindings.
When I go there the page looks like this, and I am stuck.

Somehow that I cant' reproduce, I got a tab open that looks like this, and I checked the two boxes you see:

Then I go to a text editing tab, press Menu > Edit, and it tells me Cut/Copy/Paste is Super-x, Super-c, and Super-v. They don't work. There is a key Super on one of my keyboards, but it's captured by the window manager.
In my opinion, the key that's the logically right one to choose is not Super, it's Alt - it's in the physical space where the command key should be.

Hi there, thanks for raising the issue. I'm quite happy with using super as command on Linux.


Provide explicit passive setting of the listener based on props.preve…

…ntDefault as desktop/mobile have different defaults (fixes #168)

@Andarist it looks like this is failing tests, did you remember to run npm test before pushing?

Oh, I had to forget. Maybe we should add "precommit": "npm run test"?
I have debugged this and... PhantomJS is broken :/
Chrome:
getEventListeners(document).scroll // undefined

var fn = () => {}
document.addEventListener('scroll', fn, {passive:true})

getEventListeners(document).scroll // [Object]

document.removeEventListener('scroll', fn)

getEventListeners(document).scroll // undefined

But PhantomJS compares all arguments while removeEventListener (and I pass third object param in this PR) against those used in addEventListener call. We could tackle this and store reference to this object so it can be passed again to the removeEventListener (I've verified that it works then), but should we really? That seems like PhantomJS' issue. Ideally we could setup headless Chrome for testing, but didnt play with it yet.

@Pomax rebased after es6-class merge

thanks, @Andarist


Potential footfun: Updated streams do not show their value until the next tick.

I'm hesitant to label it a bug, but I think before v1 this would need to be fixed to prevent many other issues being reported by users.
@pygy suggested that S's subclock implementation may solve this.  So we should definitely look into that.
I think if that doesn't pan out, we could maintain a stack of stream contexts (in our fork) and return the latest value when we can detect we're in an S context.

@JAForbes  this is a deliberate S.js choice:

A Clear, Consistent Timeline - S apps advance through a series of discrete "ticks." In each tick, all signals are guaranteed to return up-to-date values, and state is immutable until the tick completes. This greatly simplifies the often difficult task of reasoning about how change flows through a reactive app.

Batched Updates - Multiple data signals can be changed in a single tick (aka "transactions").

We can revisit the timing model, but we must understand the systemic consequences of doing so (and I don't, right now).
Note that S.freeze() (the transaction helper) is broken by the monkeypatch as I type this.


Update file labels

Hi,
I'm trying to use code like the following to locate file in Drive (V2) and update file labels:
files = drive.list_files(q: query,	page_token: page_token)
files.items.each do |file|
# Code to match for file criteria
#
# I tried several constructs like:
# 1-
file.labels.restricted = true
drive.update_file(file.id, file)

# 2-
file.labels.update!(:restricted => true)
drive.update_file(file.id, file)

# 3-
__f = Google::Apis::DriveV2::File.new(id: file.id)
__f.labels = Google::Apis::DriveV2::File::Labels.new(restricted: true)
drive.patch_file(file.id, __f)

end
Always fails with:
Traceback (most recent call last):
19: from ./my-gdrive-helper.rb:479:in <main>' 	18: from ./my-gdrive-helper.rb:176:in find_directory'
17: from ./my-gdrive-helper.rb:176:in each' 	16: from ./my-gdrive-helper.rb:196:in block in find_directory'
15: from ./my-gdrive-helper.rb:233:in apply_action' 	14: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/generated/google/apis/drive_v2/service.rb:1324:in patch_file'
13: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/base_service.rb:360:in execute_or_queue_command' 	12: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:93:in execute'
11: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:57:in retriable' 	10: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:57:in times'
9: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:61:in block in retriable' 	 8: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:101:in block in execute'
7: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:57:in retriable' 	 6: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:57:in times'
5: from /var/lib/gems/2.5.0/gems/retriable-3.1.1/lib/retriable.rb:61:in block in retriable' 	 4: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:104:in block (2 levels) in execute'
3: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:299:in execute_once' 	 2: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:183:in process_response'
1: from /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/api_command.rb:116:in check_status' /var/lib/gems/2.5.0/gems/google-api-client-0.21.1/lib/google/apis/core/http_command.rb:218:in check_status': badRequest: Bad Request (Google::Apis::ClientError)
My question is, what am I doing wrong? How to update File labels to change "restricted" to "true" programmatically?
Thanks,
Tamer

I think I know the issue:
I was trying to run the above code to a directory not a file, from the Google Drive UI I cannot find "Prevent copy/download/printing" for directories (of course).  I tried the following code on file (mime_type != 'application/vnd.google-apps.folder') and it worked correctly:
	file.labels.restricted = true
	drive.patch_file(file.id, file)

Thank you.

Give us a holler if you need anything else.


QMK-Like Toggle Layer

I'm trying to make a button that behaves like TG(Layer) does in QMK. It adds the layer to the stack if it wasn't already there, and removes it if it was. A combination of layer-add and layer-rem in KMonad essentially, with some logic.
Is there a way to achieve this? If not maybe this can be a feature request.

What I do is to map a key in base layer to layer-add <layer> and map the same key inside the <layer> to layer-rem <layer>.

Definitely a solution. Just that the way I used to do this in QMK, and how I want to do it here is that the layer toggle key isn't on the base layer or <layer>, but on a third layer.
One way I can see how to do it is duplicate this third layer for <layer>. But I wouldn't like that and it would get crazy if I had to add a few more toggles.

Why can't you do this:

In "third layer", map keyX to layer-add <layer>.
In <layer>, map keyX to layer-rem <layer>.

Only difference compared to TG(layer) is that you have to define 2 buttons.
P.S. I am not against adding TG(layer)-like button.

That also does not work for me, because it's not feasible to map keyX to something in layer. I want keyX to be a very accessible key, maybe on the homerow, and the third layer to be a layer that's rarely used so the buttons on homerow can be used however.
I made the issue to confirm that something like this doesn't exist and I wasn't missing something. Seems like it doesn't. If enough people want it maybe it can be implemented someday. Thanks for your help.

I'll close the issue. I did not find a neat way to do what I wanted, but learned to live without it.

It's better to keep this open, so we can implement this. No eta though. :-)

Right. It's my first issue so I didn't know how these are handled generally. Let's leave it open then.


beacon: repair file extensions that were slugged

Beacon outputs csv files with names like:
ledger-ops-cost-e3917f684e8b60e7bfc453d6d8114b800bdf167d-haskell-from-63-nr-blocks-100-csv
ledger-ops-cost-e3917f684e8b60e7bfc453d6d8114b800bdf167d-haskell810-from-63-nr-blocks-100-csv
ledger-ops-cost-e3917f684e8b60e7bfc453d6d8114b800bdf167d-haskell810-from-63-nr-blocks-100000-csv
ledger-ops-cost-e3917f684e8b60e7bfc453d6d8114b800bdf167d-haskell96-from-63-nr-blocks-100000-csv

notice the -csv instead of .csv. This also occurs for the png files it produces:
mut-blockapply-e3917f684e8b60e7bfc453d6d8114b800bdf167d-vs-e3917f684e8b60e7bfc453d6d8114b800bdf167d-png
mut-forecast-e3917f684e8b60e7bfc453d6d8114b800bdf167d-vs-e3917f684e8b60e7bfc453d6d8114b800bdf167d-png

Why? Because the . get slugged:
    outfile = toSlug $
                "ledger-ops-cost-"
                <> vToFilePath installedVersion
                <> "-from_" <> show (analyseFromSlot opts)
                <> "-nr_blocks_" <> show (numBlocksToProcess opts)
                <> ".csv"

and
      ( toSlug
        $ Text.unpack header
       <> "-"
       <> (versionA opts).dbAnalyser
       <> "_vs_"
       <> (versionB opts).dbAnalyser
       <> ".png"
      )

This PR fixes that bug.

Thanks!

@dnadales could you hit the button? Thanks!


Deployment

e.g. https://stackoverflow.com/questions/38153044/how-to-force-an-https-callback-using-microsoft-aspnetcore-authentication-google

Done


[Table of Contents]: Manual trigger for anchor harvesting - DPO Consulting

Engineering info:

Innovation Team engineer: Pending Innovation team's 02/08 sprint planning
Innovation Team JIRA Ticket: https://jsw.ibm.com/browse/HC-2400
DPO consulting engineer:

The problem
CMS authors are changing titles / anchors within the TOC, but the TOC links do not update automatically. After the author changes a title, I want to be able to trigger an update on the TOC to harvest the anchors again.
The solution
Provide a method on the TOC element (or add logic to https://lit.dev/docs/v1/components/lifecycle/#requestupdate ), which will trigger harvesting of anchor tags within the TOC.
Application/website
Afterburner Adobe CMS / https://www.ibm.com
Business priority
Low Priority = release date is not dependent on fix or not upcoming
What time frame would this ideally be needed by (if applicable)
No response
Examples
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

Based on my conversation with @IgnacioBecerra, for this request, we'll need to check for the event that AEM provides for when the element is edited and trigger the rescan.

@proeung Can't you provide a method on the table of contents element to make it more reusable? So that I would just call that method on the AEM event. Because there would be multiple AEM events to trigger that method.

@dratzenboeck-ibm Yep! I should have a PR up for you to review shortly.

@dratzenboeck-ibm Here's the PR for this feature request (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/8329). Please take a look and let me know what you think.
Also, is there a corresponding ADCMS JIRA ticket for this request on your side? If so, can you give me the number so that I can update the status so that your team will know which release these changes will be available in? cc: @EAVilleda

@proeung Created one https://jsw.ibm.com/browse/ADCMS-2095


Add support for regular expressions

I think it would be interesting to add support for regular expressions. It looks like it already supports email/ip parsing so it doesn't look like a complex feature.
Nice work by the way!

Thanks so much, @polmonroig for your comment and feedback.
Sure I will look at how can I support regex ( if possible regex find and replace as well )

Hello @roopeshsn sure, I would love to review PR.
Thanks so much for pitching in.


Support custom Region/Zone label used by Locality Load Balancing to suit for hybrid cloud scenarios

We use Istio in multi cluster mode, so we have several data plane clusters on different platform such as Alibaba Cloud or Azure.
As we know, the istio feature "Locality Load Balancing" is based on the lables on kubernetes node, e.g.
topology.kubernetes.io/region
topology.kubernetes.io/zone

Unfortunately, most of these platforms have their own naming convention of the value of these labels, which are different from other platforms. And this can make "Locality Load Balancing" totaily not work.
so we expect if there is a way to customize the label name used by Locality Load Balancing ,e.g.
xxx.io/region
xxx.io/zone

[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[X] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

there should be a label named istio-locality, @hzxuzhonghu may know more about it.

@zirain is the  istio-locality  labeled on a node or a pod ?

istio-locality is per pod label, which will take preference over node labels

@howardjohn for example, we have two data plane clusters ,both in HongKong, one on  Alibaba Cloud , other one on AWS.
The Alibaba Cloud label the k8s node with topology.kubernetes.io/region=cn-hongkong , while the AWS label the node with topology.kubernetes.io/region=ap-east-1, but geographically they are in the same city(or region).

This is an interesting point, different clouds. How do you connect inter clusters then?

Maybe you are an exception but most users would not consider those the same
region even if they are geographically close. There is still egress costs
and leaving AWS network has latency costs even to a very local server.
With failover config you can make it the next highest priority
On Tue, Jul 12, 2022, 8:01 PM Zhonghu Xu @.***> wrote:

This is an interesting point, different clouds. How do you connect inter
clusters then?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/39876#issuecomment-1182710103, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNBZ7D4REOKBIZSCIDVTYWQ3ANCNFSM53KJCI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

@howardjohn emmm...that's the work of network engineer, but i think it's a common problem when we use more then one kind of cloud platform, including private cloud.

Yes, and those are very much by design not considered the same region. For
99% (if not more) it is not a good idea to treat them the same. If you do
want to you can configure the fail over keys to order based only on subzone
or something and define custom subzone label
On Tue, Jul 12, 2022, 8:06 PM zhaoli @.***> wrote:

@howardjohn https://github.com/howardjohn emmm...that's the work of
network engineer, but i think it's a common problem when we use more then
one kind of cloud platform, including private cloud.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/39876#issuecomment-1182712450, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKI7OSOCKTGUX4WUVTVTYXEDANCNFSM53KJCI3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

@howardjohn There is a scene, service sleep  send requests to reviews, sleep deployed on region A1,  reviews deployed on both region A2 and B2,  A1 and A2 are geographically same region, but they have different region name in different cloud platform.  We expect the priority of reviews in A2 is highter then B2, but actually they have the same priority by default.

so will a pr about customize  region/zone label be approved by istio community?

No, use the existing mechanisms failoverPriority or subzone label
…
On Thu, Jul 14, 2022 at 12:36 AM zhaoli @.> wrote: so will a pr about customize region/zone label be approved by istio community? — Reply to this email directly, view it on GitHub <#39876 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYGXNKBACYG52YDHST3DDVT67QHANCNFSM53KJCI3Q . You are receiving this because you were mentioned.Message ID: @.>

ok, Thank you.


I want to set startTime and add a callBack.How can i do?

I want to set startTime and add a callBack.How can i do?

You should use the same as with any other ng-model-enabled input.

{{datetime}}

$scope.datetime = new Date(); // set start date and time
$scope.onChange = function() {}; // set callback

Thanks.

I could not make it work properly. My code:
app.js
var app = angular.module('app', ['ionic', 'ionic.service.core', 'ionic.service.analytics', 'ngMessages', 'ngCordova', 'ionic.utils', 'app.controllers', 'app.routes', 'app.services', 'app.directives', 'angular-md5', 'ion-datetime-picker']);
controllers.js
.controller('MyController', function ($scope, $ionicPopup, AuthService, $state, $ionicLoading, $interval) {
   //Initial value
    $scope.datetime = new Date();

    //Event when confirm datetime
    $scope.datetimepickerEvent = function (){
                alert($scope.datetime);
            };

    //Function called before calendar show
    $scope.updateDatetime = function () {
                alert("I am working");
                $scope.datetime = new Date();
                alert($scope.datetime); // The datetime really update.
            };

});

home.html

{{datetime}}

Problem
After confirm datetime, the $scope.datetime doesn't show the same value in home.html and controllers.js, my function updateDatetime() really update datetime but can't update the datetime used by calendar. If I press Cancel button, this does not happen. If I confirm datetime in calendar and I need reopen it, the current datetime is outdated.
Is this a bug?
Thank you for your attention.
Gustavo Ferreira.

This is not a bug, but a lack of knowledge about how angular and javascript work.
Please see #14 and this demo made from your code to understand why it does not work for you.

Ok, thank you.


When is "dialogReadyForFulfillment" method called?

In Lex sample:-
When is the "dialofReadyForFulfillment()" function called?
In my lex console fulfillment is done by "return parameter to client".
I want to use these parameter in my app and do not expect any response.
How to use the parameters returned by lex bot in app?
the response which I get from lex bot is like "{Solt:value}"
How and from which function can I get to access this result?

there was a bug in the code that prevented ready for fullfilment to be called and has been fixed in 2.4.0. Please update the sdk to 2.4.0 and  give this a try


Build SDF from source to reproduce test failures

1a1baf7e791e4297b014498154b8a370fedfa784: Reproduce the broken tests we're seeing on Garden in #1264
67f735aea90cb3b967eb83c8e5e727763277cb73: Testing the potential fix on SDF's

I was able to reproduce the test failure using nightly debs and a matching gzdev branch name in https://github.com/ignitionrobotics/ign-gazebo/pull/1265#issuecomment-1003150821

Confirmed failures and fixes with GitHub actions for the 2 commits above:

1a1baf7: https://github.com/ignitionrobotics/ign-gazebo/runs/4668996334?check_suite_focus=true
67f735a: https://github.com/ignitionrobotics/ign-gazebo/runs/4669021230?check_suite_focus=true


Error on autocompletion call (when tab key pressed)

The following error happens on completion call:
<IDS|MSG>
  HMAC:
  header: {"date":"2015-12-05T12:22:47.481813","username":"username","session":"F872F3F77E2642148519055ED30878AA","msg_id":"e6e040a3-f3a0-4e5a-8ef4-a59e4ba731a9","msg_type":"kernel_info_reply"}
  parent: {"date":"2015-12-05T12:22:47.481813","username":"username","session":"F872F3F77E2642148519055ED30878AA","msg_id":"DBCD6418A3E44E35B574887A7A64F017","msg_type":"kernel_info_request"}
  content: {"protocol_version":[3,2],"language_version":[4,1,0],"language":"ocaml"}
Exception: Failure("content_of_json: comm_open")

The same error message happens when notebook loads.
I found that this is a message sent in scope of heartbeat mechanism


[CSL-807] Use NSIS liteFirewall plugin to add/remove rules

Based on my test environment, Windows 10, the liteFirewall approach made the networking Windows Security Alert prompt go away.
The installer is now strongly discouraged by SmartScreen, but this will probably go away in a signed build after this PR is merged. To override the warning I had to click a small "more info" link.

PRs are excluded from signing and I want to test a signed version of these changes. The new test/csl807-windows-firewall branch has the same changes, and should be signed in the Appveyor build.

In my test environment the signed version of these changes worked; no aggressive SmartScreen warning nor firewall prompts.

Looks good! :)


Comments: Deploy Updates

Link to chapter - http://serverless-stack.com/chapters/deploy-updates.html

@jayair
hi, jayair
I was wondering what "CloudFront caches our objects in it’s edge locations" meant?
so when I deploy again with the changes in buttons, I can see the changes in s3-website url but can't see them in my own linked up domain name. ( the one we just set up)
Can you explain a little bit more on this?
Thank you so much. I really appreciate your tutorial.

@deepseafishing Yeah CloudFront is a CDN so our assets are cached on edge servers that Amazon has. That's why we need to invalidate the CloudFront cache. It can take a minute or two to invalidate it but you should see your changes soon.

Why is it required to clear the cache of the redirecting cloudfront ?
The redirected page url in S3 didn't change. Isn't it ?

@lepirlouit Yeah you don't have to. We just do it for completeness sake.

This issue was moved to https://discourse.serverless-stack.com/t/comments-deploy-updates/16


Plugin crashes when logging in to VSTS - WebStorm

When I click the icon in the corner of my window, then click sign in, the following happens.

Microsoft login page appears in which I type in my work email address
Page says "redirecting to organization login"
At my company, Okta is used for auth, so we're automatically logged into our accounts when we're logged into our machines. So the dialog closes.
Error popup comes up in corner of WebStorm window saying plugin has crashed.

When clicking on the error popup, the following error message is displayed:
getAuthenticationInfoAsync failed: KEY_VSO_AUTH_FAILED
com.microsoft.alm.plugin.exceptions.TeamServicesException: KEY_VSO_AUTH_FAILED
	at com.microsoft.alm.plugin.authentication.facades.VsoAuthInfoProvider.getAuthenticationInfoAsync(VsoAuthInfoProvider.java:98)
	at com.microsoft.alm.plugin.authentication.VsoAuthenticationProvider.authenticateAsync(VsoAuthenticationProvider.java:69)
	at com.microsoft.alm.plugin.authentication.AuthHelper.getAuthenticationInfoSynchronously(AuthHelper.java:59)
	at com.microsoft.alm.plugin.context.ServerContextManager.getAuthenticationInfo(ServerContextManager.java:489)
	at com.microsoft.alm.plugin.context.ServerContextManager.createContextFromGitRemoteUrl(ServerContextManager.java:372)
	at com.microsoft.alm.plugin.context.ServerContextManager.createContextFromGitRemoteUrl(ServerContextManager.java:353)
	at com.microsoft.alm.plugin.context.ServerContextManager.getAuthenticatedContext(ServerContextManager.java:333)
	at com.microsoft.alm.plugin.context.ServerContextManager.getUpdatedContext(ServerContextManager.java:563)
	at com.microsoft.alm.plugin.operations.Operation$1.run(Operation.java:184)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

same happens here.
We are using ADFS for Auth. also with SSO.
I was able to enter my email address once. after that it just shows empty popups and then crashes.
I even uninstalled and re-installed the plugin but somewhere my previously entered email address is stored.

Currently we believe that this is a duplicate of a fixed issue #158 (or, more precisely, #158 was a duplicate of this issue).


Unable to download extensions

Cannot download any extensions from the marketplace. Manual downloading works

What does share process log say?

What does share process log say?

2023-02-22 07:44:13.404 [error] Failed to install extension. beardedbear.beardedtheme
2023-02-22 07:44:13.404 [error] Error: net::ERR_FAILED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:105:7047)
    at SimpleURLLoaderWrapper.emit (node:events:526:28)

Hmm, I just updated my VS Code client and am not seeing this anymore. I guess maybe I received a bad update or something.

Hmm network issue. Can you please open shared process window - using Toggle Shared Process command and see what the network tab and console tab says?
@deepak1556 @bpasero Given that we are making shared process a utility process, we have to build tooling infrastructure for network diagnosing. Current requests logging in the logs are not good enough. We used to get more information for network requests in the shared process console/network tab. It would be great if we can create a separate log file where we log all network requests with necessary info.

That makes good sense to me, maybe central from the request service and only when tracing is enabled.

Btw for this issue: we recently configured developer.sharedProcess.redirectRequestsToMain to be enabled by default, so it may have an impact here.

Oh nevermind, for insiders it was always enabled!


store_metadata_in_osv3: set artifacts to [] if pre_pyrpkg_fetch_artifacts was not run

pre_pyrpkg_fetch_artifacts plugin is deprecated

Coverage remained the same at 89.958% when pulling c2b8855a17d20cbfb8228f743b67d45608d931a1 on vrutkovs:fix-None-in-artefacts into 24804d2c2f55837fe3911105d4068662d86b61f1 on projectatomic:master.

Coverage decreased (-0.03%) to 89.931% when pulling b75cdf45fab05970ec72782b758b57ff9423b123 on vrutkovs:fix-None-in-artefacts into 24804d2c2f55837fe3911105d4068662d86b61f1 on projectatomic:master.


Memory usage after first tonic request

I was adding a RPC request to return RSS memory and noticed the RSS usage goes up in the server after the first GRPC request... significantly.
Terminal 1:
# target/release/conmon-server --runtime /bin/ls

Terminal 2:
# cat /proc/$(pidof conmon-server)/status|grep RSS
VmRSS:      1084 kB
# target/release/conmon-client
Version: Response { metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 10 Nov 2021 21:55:01 GMT", "grpc-status": "0"} }, message: VersionResponse { version: "0.1.0" }, extensions: Extensions }
# cat /proc/$(pidof conmon-server)/status|grep RSS
VmRSS:      3464 kB

@rphillips that's the reason why we have the mismatch between CI and our local tests. We test that the binary is up and running by verifying that the client works. Great find!

I'm still seeing this issue with #20.

I'm still seeing this issue with #20.

I'm not on my local machine but I can reproduce in https://github.com/containers/conmon-rs/pull/22

In #27 we migrated to capnproto


added a new website based on js

Hi i have added a tourism website its based on booking a tourist place please check it out i am open for any sort of suggestion.
https://github.com/user-attachments/assets/83e04cd0-4bcd-49f8-994d-f6a6561c340f

Hi @Inija-2503, I'm sorry for the inconsistency regarding the linting workflows. They have been updated but not reflected within your forked repo. So, please follow the below instruction carefully,

[!WARNING]
Please follow each step carefully, missing a step or improper use of any step could led to more error than the ones that are present right now.

Update the main branch within you remote/github repo as showen below,

Checkout to main branch on your local repo.
git checkout main

Pull the updated changes into your local repo.
git pull origin main

Checkout to your current branch i.e., Tourism.
git checkout Tourism

Rebase your Tourism branch with main branch.
git rebase main

Now push the rebased Tourism branch into your remote repo i.e., the one on Github.
# Simple push should do it
git push origin Tourism

# In case of any issue the following,
# git push origin Tourism -f

And hopefully this should fix the linting workflow. And if the linting workflows have not been triggered, make a small change within any of your javascript files and push them. That should trigger the linting workflow.
And once the linting checks have passed, I'll do the code review and merge your PR. Once again, I'm sorry for this inconvenience, It was my fault failing to updating the linting workflow for this repo. Thank you for your patience and support.

[!IMPORTANT]
If you need any help in any of the process (or) if you did understand any part of the solution I proposed, please ping me up here. Please don't take action based on some assumption. Feel free to ask me questions and doubts, I would be more than happy to help.


Translation - Configure app

i feel it might be unclear to users that "Save" button only saves that specific category. the notification message doesn't clear that misconception either

i feel it might be unclear to users that "Save" button only saves that specific category. the notification message doesn't clear that misconception either

Should both messages (button + notification) include the category? Or just the button?


Run buildifier in a GitHub Actions workflow

Description
With this commit we can continuously check is there is any lint error in BUILD.bazel and *.bzl files.
Closes #1089.
Issue IDs

https://github.com/google/mozc/issues/1089

We have merged your PR.
Thank you for the contribution!


Update actions to Node 20

You can see the deprecation warnings in this recent run.
My last PR (#13) failed because I can't push to an internal branch (#14), so I suspect this one will fail too. Could either 1) I be added as a contributor to this repo so that I can create an internal branch, or 2) could a maintainer please push my change as an internal branch to test the CI?

Thanks @jdblischak
I added you as a maintainer, let’s see if that resolves the issue

Superseded by #20


[jobframework] Use the jobs uid in workload's name hash.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
[jobframework] Use the jobs uuid in workload's name hash. With this we can avoid name collisions for workloads create for jobs having the same name and type created at different pints in time.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Use the job's uid in workload's name hash to avoid potential name collisions.

/cc @alculquicondor

I'm ok with this change, but before we merge it, I think we should make sure we are not depending on the predictability of the workload name.

What happens if admins do cluster migration?
We often migrate the existing cluster to a new cluster to update the k8s version with backup and restore etcd.
I guess that workloads are just recreated with a new name since Job UID is changed by migration, right?
So, there is no impact, right?

I still have concerns about this approach, summarized here: https://github.com/kubernetes-sigs/kueue/issues/1726#issuecomment-1945514791.

@alculquicondor
Passed the workload creation the workload name is irrelevant for Kueue, job reconciliation is done based on ownership (with the exception of prebuilt workloads when there is no relationship between the wl and job name).
From a human user perspective the wl names will continue to look similar <job-prefix>-<job-name>-<hash-segment>,  where hash-segment is an opaque string.
@tenzen-y
For etcd backup/restore I'd expect the workloads to be part of that process as well, if not, indeed the should just be recreated. (are the UIDs  changed in migration?)

For etcd backup/restore I'd expect the workloads to be part of that process as well, if not, indeed the should just be recreated. (are the UIDs changed in migration?)

If we directly backup and restore etcd, UID wouldn't be changed, but if we use cluster backup tools like the velero, UID will be changed. I'm ok with only recreating the workloads.

My worry is this line:
https://github.com/kubernetes-sigs/kueue/blob/e10df68a066f23ee1f6787de6e5cd24be86772df/pkg/controller/jobs/job/job_webhook.go#L80

GetWorkloadNameForOwnerRef

Yes , this could be problematic in case of  kueue upgrades, it could keep the child job Suspended if the workload for the parent was created before the upgrade.
A similar problem we have with prebuilt workloads, but only for jobsets at this point, and we do this https://github.com/kubernetes-sigs/kueue/blob/01bd53214c8bc92b9a1164b224104a2f73397b4a/pkg/controller/jobs/jobset/jobset_webhook.go#L60-L69
to overcome it.
Maybe we could droop the usage of the parentWlAnotation and cover the prebuilt scenario as well.

Maybe we could drop the usage of the parentWlAnotation and cover the prebuilt scenario as well.

Can you expand on this?

Maybe we could drop the usage of the parentWlAnotation and cover the prebuilt scenario as well.

Can you expand on this?

We can use an ownership based approach, the child job and the worker have the same parent . https://github.com/kubernetes-sigs/kueue/pull/1732/commits/4dc9ba07b3b255e0ea4c582cc5af36d2b08404d1

I like that. Let's start with a PR just for that.

I like that. Let's start with a PR just for that.

Moved in #1747

Should we update the PR description to note  that it fixes https://github.com/kubernetes-sigs/kueue/issues/1726? Or we believe there is more to do to close it, like the GC? In that case we may just mention "Part of #1726".

Should we update the PR description to note that it fixes #1726? Or we believe there is more to do to close it, like the GC? In that case we may just mention "Part of #1726".

Lt's go with Fix, since the issue cannot be reproduce after adding this.

/lgtm
IIUC the remaining issue is that when a running Job is deleted with --cascade orphan, then the workload remains admitted and continues to consume quota, which we want to tackle by GC (either removal or marking as finished). If this is correct, could you please open a follow up issue?

For the release note, maybe something more user-oriented:
"The workload name is no longer the same for recreated jobs (with the same namespace and name),
because  Job UID is used to determine the hash-like suffix in the workload name."
WDYT @tenzen-y

For the release note, maybe something more user-oriented: "The workload name is no longer the same for recreated jobs (with the same namespace and name), because Job UID is used to determine the hash-like suffix in the workload name."
WDYT @tenzen-y

@mimowo Generally, sgtm, but it is better to emphasize that the creating workloads names lose consistency or obtain completely random names. WDYT?

"The workload names are virtually random now."

Cannot be added since they are not random.

"The workload names are virtually random now."

Cannot be added since they are not random.

Well, I think saying "virtually" random, or "random from user's perspective" is fine, but I don't have a strong opinion. Still, I think we should make set the release note to something understandable to users. WDYT @tenzen-y ?

Release note updated

/approve

"The workload names are virtually random now."

Cannot be added since they are not random.

Well, I think saying "virtually" random, or "random from user's perspective" is fine (after saying that it is a hash-like in the previous sentence), but I don't have a strong opinion. Still, I think we should make set the release note to something understandable to users. WDYT @tenzen-y ?

Sorry for the late. It sounds good to me.


Fix bugs

Moved logic of CartMove from model to CartMoveCommand. Updated Model, ModelManager, ModelManagerTest and CartMoveCommandTest accordingly.
Added some test cases to assert true and false for Cookbook, Cart and Inventory

LGTM. Maybe we should untrack/remove cart.pdf from the repo since it's user dependent, possibly can add to .gitignore

I've added to my PR (#228)

LGTM. Maybe we should untrack/remove cart.pdf from the repo since it's user dependent, possibly can add to .gitignore

I've added to my PR (#228)

Alright, rmb to remove it from the repo too, as adding to .gitignore doesn't stop github from tracking it.


Scenario for Azure Arc-enabled servers - Azure Monitor

Is your feature request related to a new Jumpstart scenario you would like to contribute?
Yes, new scenario where Azure Monitor artifacts are deployed to demonstrate how to monitor Azure Arc-enabled servers.
Is your feature request related to a problem? Please describe.
This jumpstart scenario will show how to use Azure Monitor to get more insights of Azure Arc-enabled servers (which should be previously onboarded).
Describe the solution you'd like
A log analytics workspace will be deployed, along with its data sources. In addition, a set of OS alerts and workbooks will be created.
Describe alternatives you've considered
Not currently
Additional context
N/A

closed via #1011


Fix bug where stopping the SIPUAHelper caused a ConcurrentModificationError. Closes #282

For further detail look into #282.
This also fixes a problem where when cancelling a phone call in the initiation stage would lead to an error, because cancel_reason would not yet be set. Now the default reason is OK

Any updated on this getting merged?


📎 Auto generate the configuration page configuration.mdx

Description
The configuration.mdx is updated manually, and this is bothersome because we could actually generate automatically from the rust doc comments relatively easily.

On this page https://biomejs.dev/reference/configuration , we need to update biome hosted schema version automatically.

At the moment the page contains good examples, and there's a chance we won't be able to have those examples anymore.
I see two solutions:

have these examples inside the doc comments
having a dedicated page for these examples (a guide to the configuration)

I would like to work on this issue, can you assign me?

I assigned!

@yossydev I suggest to take a look at workespace_types.rs. It's a file that uses the JSON schema emitted by the configuration, to create TypeScript types.
We could do something similar with the JSON schema, and emit a markdown file instead. The JSON schema should retain the comments, although I don't know if it's to retain all of them, and if it's able to retain the markdown syntax too.

@ematipico
Hello! I have one question.
Right now I am trying to read<EMAIL_ADDRESS>and convert it to markdown!
However, the JSON schema defined seems to be different from the current configuration page.
For example,
{
  "$schema": "<EMAIL_ADDRESS>}

does not seem to be defined.
Presumably this is also required? Can I define it myself?
Please check it out at your leisure: 🙇♂
Translated with www.DeepL.com/Translator (free version)

Hi @yossydev , apologies for not explaining a bit more about what the task is about. This is my fault.
We don't want to read the file configuration_schema.json, but we want to use schemars crate, and extract the information from it.
schemars should create a data structure that contains the information we need. In fact, in workspace_types.rs, we use it programmatically to create TypeScript interfaces.
Here's an example of how you can generate the schema:
https://github.com/biomejs/biome/blob/c3150e615e4942e51b8331321f491f98303e9f83/crates/biome_service/src/workspace_types.rs#L421-L433
And this is a function that process the schema and starts generating types
https://github.com/biomejs/biome/blob/c3150e615e4942e51b8331321f491f98303e9f83/crates/biome_service/src/workspace_types.rs#L296
This isn't a beginner task, that was a mistake of mine, apologies for that. 🙇
If you think it's too complex and you don't want to do that, it's completely fine!

@ematipico
Thanks for the explanation!
Yes, it feels a bit like a heavy issue for me right now...!
Sorry, I would like to ask another person to handle this one!
If there is another issue that I can do, please let me deal with it!

Thank you @chansuke , let me know if you have any questions

@ematipico
I have implemented the auto-generation of configuration.md using schemars. This involves generating a JSON schema from struct Configuration and parsing it into markdown format.
This process requires programmatic parsing of JSON code blocks and lists, as our configuration is extensively described in JSON. For example:
{"anyOf":[{"$ref":"#/definitions/JsonConfiguration"},{"type":"null"}],"description":"Options applied to JSON files.\n\n### `json.parser.allowComments`\n\nEnables parsing of comments in JSON files.\n\n```json title=\"biome.json\" { \"json\": { \"parser\": { \"allowComments\": true } } } ```\n\n### `json.parser.allowTrailingCommas`\n\nEnables parsing of trailing commas in JSON files.\n\n```json title=\"biome.json\" { \"json\": { \"parser\": { \"allowTrailingCommas\": true } } } ```\n\n### `json.formatter.enabled`\n\nEnables Biome's formatter for JSON (and its super languages) files.\n\n> Default: `true`\n\n### `json.formatter.indentStyle`\n\nThe style of indentation for JSON (and its super languages) files. It can be either `\"tab\"` or `\"space\"`.\n\n> Default: `tab`\n\n### `json.formatter.indentSize`\n\nDefines the size of indentation for JSON (and its super languages) files.\n\n> Default: `2`\n\n### `json.formatter.lineEnding`\n\nThe type of line ending for JSON (and its super languages) files: - `lf`, Line Feed only (`\\n`), common on Linux and macOS as well as inside git repos; - `crlf` Carriage Return + Line Feed characters (`\\r\\n`), common on Windows; - `cr` Carriage Return character only (`\\r`), used very rarely.\n\n> Default: `lf`\n\n### `json.formatter.lineWidth`\n\nSpecifies the maximum number of characters on a single line in JSON (and its super languages) files.\n\n> Default: `80`"}

However, there are some notable differences compared to our existing configuration.mdx:

Order of Items:
The sequential generation of the document from struct Configuration introduces variations in the order of items.
JSON Blocks:
There are some discrepancies in certain JSON blocks.

How do you think about my approach :bow:

@chansuke

Order of Items:
The sequential generation of the document from struct Configuration introduces variations in the order of items.

I don't mind the order of the items, as long as they don't change if we execute the codegen script multiple times

JSON Blocks:
There are some discrepancies in certain JSON blocks.

I think it's fine, and I think we shouldn't keep all the examples. I think small code snippets should be fine.
I think we should move bigger code snippets like ignore, exclude and extends inside a different page. Maybe a new page where we explain how to set up Biome's configuration. The, the documentation could have a  link to that page.

@ematipico
Thank you for your reply!

I don't mind the order of the items, as long as they don't change if we execute the codegen script multiple times

Yes, wen can execute the codegen muiltiple times with same result

I think we should move bigger code snippets like ignore, exclude and extends inside a different page

Ok, I will move bigger code snippets from crates/biome_service/src/configuration/mod.rs to new file under crates/biome_service/src/configuration/ directory.

@ematipico
I've created a dedicated examples page for detailed configuration examples (like ignore, exclude, etc.) and added a link to this page in the main documentation. This approach was chosen as the simplest way to streamline the documentation and reduce its complexity.
How do you think about my approach :bow:

I'll look into it soon, thank you!

@ematipico
I rebased my working branch onto the latest commit to finalize my pull request. However, after rebasing with the latest Configuration, I encountered the following error:
   --> xtask/codegen/src/generate_markdown.rs:11:30
    |
11  |     let schema = schema_for!(Configuration);
    |                  ------------^^^^^^^^^^^^^-
    |                  |           |
    |                  |           the trait `JsonSchema` is not implemented for `biome_service::Configuration`
    |                  required by a bound introduced by this call
    |
    = help: the following other types implement trait `JsonSchema`:
              bool
              char
              isize
              i8
              i16
              i32
              i64
              i128
            and 279 others
note: required by a bound in `SchemaGenerator::into_root_schema_for`

To progress, I implemented a temporary fix which allowed me to generate markdown locally again. However, this fix might not be ideal as it bypasses the schemars configuration and could potentially affect other crates.
And with this fix, now I'm facing the error to derive JsonSchema like below:
error: cannot determine resolution for the derive macro `JsonSchema`
 --> crates/biome_service/src/configuration/css.rs:9:81
  |
9 | #[derive(Clone, Default, Debug, Deserialize, Eq, Partial, PartialEq, Serialize, JsonSchema)]
  |                                                                                ^^^^^^^^^^
  |
  = note: import resolution is stuck, try simplifying macro imports

Could you provide some guidance on how to resolve these issues :pray:

@chansuke Thank you for reaching out for help. I pushed a fix in your PR 989f192 (#1028)
Instead of using Configuration, we now have a new struct called PartialConfiguration that automatically created by our Partial macro. :)
https://github.com/biomejs/biome/blob/763844bab9b14e91e221d2bb460183573fd389f7/crates/biome_service/src/configuration/mod.rs#L68

@ematipico Thank you!!!!


Instructions/example for field_map?

Hi all,
I'm trying to configure wg-portal with Authentik using OIDC getting inspiration from #192.
However, when I use field_map with anything inside it I will get the following in the UI and absolutely nothing in the logs (even with log_level: debug:

This is the field_map I'm using currently using:
auth:
  callback_url_prefix:  https://xxx/api/v0
  oidc:
    - id: wgportal
      provider_name: wgportal
      display_name: xxx Auth
      base_url: https://xxx/application/o/wgportal/
      client_id: xxx
      client_secret: xxx
      registration_enabled: true
      field_map:
        user_identifier: preferred_username
        email: email
        firstname: given_name
        #lastname: given_name
        #phone:.
        department: given_name
        isAdmin: isAdmin
      extra_scopes:
        - users

And the following is the JWT payload returned by Authentik:
{
    "iss": "https://xxx/application/o/wgportal/",
    "sub": "4e494e272e132b57ec84801b7ee35b5c7cc74b2e4d095d2096822eceb8e2094e",
    "aud": "acvgD9pRIlSmfCCFMH56iOw9NQqwg867hRzTePh6",
    "exp":<PHONE_NUMBER>,
    "iat":<PHONE_NUMBER>,
    "auth_time":<PHONE_NUMBER>,
    "acr": "goauthentik.io/providers/oauth2/default",
    "amr": [
        "pwd"
    ],
    "email"<EMAIL_ADDRESS>    "email_verified": true,
    "isAdmin": true,
    "name": "authentik Default Admin",
    "given_name": "authentik Default Admin",
    "preferred_username": "admin",
    "nickname": "admin",
    "groups": [
        "authentik Admins",
        "ldapsearch",
        "Users"
    ]
}

Has anyone an example or instructions around how to field_map properly?

Thanks

@vromero did you tried with other username?
I think, that there is conflict with default admin user and your admin user from OIDC

Thanks @bonddim, that is a great catch.
I tried, however, with some other user and had no luck. Got the exact same result.

Some additional information that I failed to mention. OIDC works just fine if I don't provide a field_map. I just need to do it to assign admin privileges to some users.

one more...
Try to use is_admin instead of isAdmin property in your field_map:
...
field_map:
  is_admin: isAdmin

Wow that's another excellent catch!
Unfortunately, it didn't help.
Something that I notice is that the user_identifier: preferred_username seems to be some kind of inhibitor. If I leave it uncommented nothing works, if I comment it seems to work (but anything else in the section doesn't seem to have effect).
For instance the following does not work:
      field_map:
        user_identifier: preferred_username
        #email: email
        #firstname: given_name
        #lastname: given_name
        #phone:
        #department: given_name
        #is_admin: isAdmin

And as you can see, the non-admin user I'm testing with now has preferred_username perfectly well defined:
{
    "iss": "https://xxx/application/o/wgportal/",
    "sub": "56e5aa07a336ab4589d8faa96a0662a2be9261142d42ac2fcfa758e5c809242b",
    "aud": "acvgD9pRIlSmfCCFMH56iOw9NQqwg867hRzTePh6",
    "exp":<PHONE_NUMBER>,
    "iat":<PHONE_NUMBER>,
    "auth_time":<PHONE_NUMBER>,
    "acr": "goauthentik.io/providers/oauth2/default",
    "amr": [
        "pwd"
    ],
    "email": "",
    "email_verified": true,
    "isAdmin": false,
    "name": "Perry",
    "given_name": "Perry",
    "preferred_username": "perry",
    "nickname": "perry",
    "groups": [
        "Users"
    ]
}

Hey @bonddim,
After you found those two sloppy errors I went' back and checked the fundamentals. Turner our I wasn't requesting the right scopes:
      extra_scopes:
        - email, openid, profile

With this everything started to work.
Thanks


Update docs in Korean (2.6.0+)

Update all docs in Korean :)

I do not have reviewer in Korean officially. I will be looking for a Korean review as soon as possible.
:sad:

@kazupon Please add @kciter to reviewer. He is co-organizer of Vue.js Korean user group.

I cannot request a review from him in the github menu 😞
He should be able to de the review anyway

@posva Okay, I will reivew without reviewer. :)

@LinusBorg Sorry for the review request xD
@kciter But until now, anybody could review any pr, have that changed 😢 ?

@posva I think you are mistaken. You could assign any contributor as a reviewer, not just and "random" github user. kciter isn't a contributor yet.

@LinusBorg aaah, I didn't know it worked like that. Thanks for the info!

@LinusBorg aaah, I didn't know it worked like that. Thanks for the info!

@kciter  @yu1222 말씀해주신 내용에 맞춰 수정했습니다.  정말 감사합니다.
@kazupon I've got awesome reviewers! 😄
Please check commits and reviews.

@ChangJoo-Park ping me when it's ready 🙂
Thanks a lot 👍

@ChangJoo-Park Thanks! Also for reviewers!


Update darc subscription after Preview5 release

We needed to move to a different darc subscription for aspnetcore coherency, but after Preview5 we should return it to "lastest", whatever that means at that point.

This is now completed.


No new accessory is shown in Home app

Hi,
I have just installed your plugin, restarted homebridge and these are the homebridge log entries related to this plugin:
[6/20/2020, 09:46:09] [WideQ] Initializing WideQ platform... [6/20/2020, 09:46:09] [WideQ] ************************************************************** [6/20/2020, 09:46:09] [WideQ] WideQ v0.1.9 by NorDroN [6/20/2020, 09:46:09] [WideQ] GitHub: https://github.com/NorDroN/homebridge-wideq [6/20/2020, 09:46:09] [WideQ] Email<EMAIL_ADDRESS>[6/20/2020, 09:46:09] [WideQ] ************************************************************** [6/20/2020, 09:46:09] [WideQ] [INFO] Create client from token and get devices
Here is my plugin configuration:
{     "platform": "WideQ",     "refresh_token": "[token_taken_from_wideq_tool]"     "country": "RO",     "language": "ro-RO",     "debug": true,     "interval": 10 },
My problem is that there is no visible accessory that could be added in Home app.
Could it be that while wideq-state.json uses "oauthRoot":"https://ro.lgeapi.com", the URL returned from the browser contains "&oauth2_backend_url=https://gb.lgeapi.com/" ?
I've launched wideq tool with the following arguments:
pi@raspberrypi:~ $ wideq auth --country RO --language ro-RO Log in here: https://ro.m.lgaccount.com/login/sign_in?country=RO&language=ro-RO&svcCode=SVC202&authSvr=oauth2&client_id=LGAO2                                                                                21A02&division=ha&grant_type=password
Please help :)

Have you been authorized successful? Did you get refresh_token?
Try to run wideq ls -c RO -l ro-RO -t [refresh_token here].
What do you see?

Yes, everything was fine at that step.
I just ran pi@raspberrypi:~ $ wideq ls -c RO -l ro-RO -t [my_refresh_token] but here is no output:
pi@raspberrypi:~ $ wideq ls -c RO -l ro-RO -t dcf2...ed08 pi@raspberrypi:~ $

Hi,
I now have successfully recieved my refesh token and when I start homebridge it seems that everything is ok. But I can also see no new device.
I would like to add my washer ( F16WD128GH). What could be the problem?
Thanks in advance!

Having same issue.  Did u ever get this resolved?

No, I have abandoned until we'll get a reply for this ticket. I'm sorry but I don't have any idea what I could do any further in order to get this issue fixed or at least find out more information about it.

What information would you need? I can test thinge with my washing maschine for you! :)

Do you have any idea how could I activate debug logging for this plugin? I already have "debug": true set but it doesn't produce any debug output, other than:
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] Loaded plugin<EMAIL_ADDRESS>Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] Registering platform 'homebridge-wideq.WideQ'
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] Initializing WideQ platform...
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] **************************************************************
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] WideQ v0.1.9 by NorDroN
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] GitHub: https://github.com/NorDroN/homebridge-wideq
Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] Email<EMAIL_ADDRESS>Aug 11 12:16:28 raspberrypi homebridge[10593]: [8/11/2020, 12:16:28] [WideQ] **************************************************************
Aug 11 12:16:29 raspberrypi homebridge[10593]: [8/11/2020, 12:16:29] [WideQ] [INFO] Create client from token and get devices

I'm getting the same thing, same debug information.

I have the same problem :(

I have the same issue. I retrieved refresh token without issue and tested the toke without issue, but got the same debug info and just couldn’t see my device in homebridge.
I also tried different language setting, no luck. But as soon as I changed the country, it didn’t authenticate the token which means the token was specifically for the user with that specific locale setting.
 But Gmail didn’t work with token retrieval, I had to de-couple the fridge with the account and registered a new email just to be able to sign up with LG.


Can I get the value of current Beat with Lua script?

Can I get the value of current Beat with Lua script?

To answer your question, Yes.


feat: add missions polling

:tada: This PR is included in version 0.1.0 :tada:
The release is available on:

v0.1.0
GitHub release

Your semantic-release bot :package::rocket: