'webpack compiled with 1 error' when npm starts

webpack compiled with 1 error
when I tried to do npm start I got 'webpack compiled with 1 error' in the terminal.
usually I did not  these error after running npm start
This how my terminal looks like
Creating a new React app in C:\Users\Alok\documents\pinterest.

Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts with cra-template...

added 1378 packages in 13m

182 packages are looking for funding
  run `npm fund` for details

Initialized a git repository.

Installing template dependencies using npm...
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated

added 39 packages in 1m

182 packages are looking for funding
  run `npm fund` for details
Removing template package using npm...

removed 1 package, and audited 1417 packages in 18s

182 packages are looking for funding
  run `npm fund` for details

6 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
Git commit not created Error: Command failed: git commit -m "Initialize project using Create React App"
    at checkExecSyncError (node:child_process:828:11)
    at execSync (node:child_process:899:15)
    at tryGitCommit (C:\Users\Alok\documents\pinterest\node_modules\react-scripts\scripts\init.js:62:5)
    at module.exports (C:\Users\Alok\documents\pinterest\node_modules\react-scripts\scripts\init.js:350:25)
    at [eval]:3:14
    at Script.runInThisContext (node:vm:129:12)
    at Object.runInThisContext (node:vm:305:38)
    at node:internal/process/execution:76:19
    at [eval]-wrapper:6:22 {
  status: 128,
  signal: null,
  output: [ null, null, null ],
  pid: 12792,
  stdout: null,
  stderr: null
}
Removing .git directory...

Success! Created pinterest at C:\Users\Alok\documents\pinterest
Inside that directory, you can run several commands:

  npm start
    Starts the development server.

  npm run build
    Bundles the app into static files for production.

  npm test
    Starts the test runner.

  npm run eject
    Removes this tool and copies build dependencies, configuration files
    and scripts into the app directory. If you do this, you can’t go back!

We suggest that you begin by typing:

  cd pinterest
  npm start

Happy hacking!
PS C:\Users\Alok\documents> cd pinterest
>>   npm start

><EMAIL_ADDRESS>start
> react-scripts start

(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...
Failed to compile.

Plugin "react" was conflicted between "package.json » eslint-config-react-app » C:\Users\Alok\documents\pinterest\node_modules\eslint-config-react-app\base.js" and "BaseConfig » C:\Users\Alok\Documents\pinterest\node_modules\eslint-config-react-app\base.js".
ERROR in Plugin "react" was conflicted between "package.json » eslint-config-react-app » C:\Users\Alok\documents\pinterest\node_modules\eslint-config-react-app\base.js" and "BaseConfig » C:\Users\Alok\Documents\pinterest\node_modules\eslint-config-react-app\base.js".

webpack compiled with 1 error

My package.json is
{
  "name": "pinterest",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@testing-library/jest-dom": "^5.16.4",
    "@testing-library/react": "^13.2.0",
    "@testing-library/user-event": "^13.5.0",
    "react": "^18.1.0",
    "react-dom": "^18.1.0",
    "react-scripts": "5.0.1",
    "web-vitals": "^2.1.4"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

I am also having this same issue.
It seems to be that webpack updated 7 days ago and breaks the start script.
After running npm start the terminal displays the following error and then terminates and fails to start:
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...

I am also having this same issue. It seems to be that webpack updated 7 days ago and breaks the start script.
After running npm start the terminal displays the following error and then terminates and fails to start:
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...

This is the first time I am having this issue with react

This is just a warning

I am also having this same issue. It seems to be that webpack updated 7 days ago and breaks the start script.
After running npm start the terminal displays the following error and then terminates and fails to start:
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...

This is the first time I am having this issue with react

This is just a warning that is usually given when a new updated package either of react or any other dependency has been released and with this new package an older version of a dependency is being used. In simple words this specific warning is just because of dependencies having different versions being used.

This is just a warning

I am also having this same issue. It seems to be that webpack updated 7 days ago and breaks the start script.
After running npm start the terminal displays the following error and then terminates and fails to start:
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...

This is the first time I am having this issue with react

This is just a warning that is usually given when a new updated package either of react or any other dependency has been released and with this new package an older version of a dependency is being used. In simple words this specific warning is just because of dependencies having different versions being used.

Yeah, I tried on a different machine and it worked no problem, as you say, it was just a warning and the script started first time without terminating...
I ended up reinstalling NodeJS on the first machine and then it worked fine.

hey, simple solution is here In file: node_modules/react-scripts/config/webpackDevServer.config.js
change this code
onBeforeSetupMiddleware(devServer) { // Keep evalSourceMapMiddleware// middlewares beforeredirectServedPath otherwise will not have any effect
// This lets us fetch source contents from webpack for the error overlay
devServer.app.use(evalSourceMapMiddleware(devServer));
if (fs.existsSync(paths.proxySetup)) {
// This registers user provided middleware for proxy reasons
require(paths.proxySetup)(devServer.app);
}
},
onAfterSetupMiddleware(devServer) {
// Redirect to PUBLIC_URL or homepage from package.json if url not match
devServer.app.use(redirectServedPath(paths.publicUrlOrPath));

// This service worker file is effectively a 'no-op' that will reset any
// previous service worker registered for the same host:port combination.
// We do this in development to avoid hitting the production cache if
// it used the same host and port.
// https://github.com/facebook/create-react-app/issues/2272#issuecomment-302832432
devServer.app.use(noopServiceWorkerMiddleware(paths.publicUrlOrPath));
}`

from this
`setupMiddlewares: (middlewares, devServer) => {
if (!devServer) {
throw new Error('webpack-dev-server is not defined')
}
if (fs.existsSync(paths.proxySetup)) {
    require(paths.proxySetup)(devServer.app)
}

middlewares.push(
    evalSourceMapMiddleware(devServer),
    redirectServedPath(paths.publicUrlOrPath),
    noopServiceWorkerMiddleware(paths.publicUrlOrPath)
)

return middlewares;
}`

#This is my error when i wrote a react code. I don't know why this error occurred, piz suggest me something.

<EMAIL_ADDRESS>start
Failed to compile.

Module not found: Error: You attempted to import /Tile.css which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.
Did you mean './/Tile.css'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules, C:\Users\Hp\OneDrive\Desktop\chess-app\node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
ERROR in ./src/components/Tile/Tile.tsx 4:0-19
Module not found: Error: You attempted to import /Tile.css which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.
Did you mean './/Tile.css'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules, C:\Users\Hp\OneDrive\Desktop\chess
Failed to compile.
Module not found: Error: You attempted to import /Tile.css which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.
Did you mean './/Tile.css'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules, C:\Users\Hp\OneDrive\Desktop\chess-app\node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
ERROR in ./src/components/Tile/Tile.tsx 4:0-19
Module not found: Error: You attempted to import /Tile.css which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.
Did you mean './/Tile.css'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules, C:\Users\Hp\OneDrive\Desktop\chess-app\node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
webpack compiled with 1 error
No issues found.

cd pinterest
npm start
Happy hacking!
PS C:\Users\Alok\documents> cd pinterest

npm start

<EMAIL_ADDRESS>start
react-scripts start

(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use node --trace-deprecation ... to show where the warning was created)
(node:13956) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Starting the development server...


[TACHYON-1363] Remove redundant javadoc for getNumberOfPinnedFiles() in FileSystemMaster.java

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7807/
Test PASSed.

LGTM

+1 LGTM


Can not run digits server

When I ran the server "./digits-devserver", it complained that
File "digits/utils/init.py", line 167, in
from . import constants, image, time_filters, errors, forms, routing, auth  # noqa
File "digits/utils/forms.py", line 5, in
import wtforms
ImportError: No module named wtforms
Why? I have followed the instructions and installed

You need to run this command:
sudo pip install -r $DIGITS_ROOT/requirements.txt
It will install python packages for your system. You can check the guide from NVIDIA


Issues building for Linux

Hi,
First some minor doc issues:

README.md mentions Prebuild.sh but it's prebuild.sh
README.md mentions fetch_dependencies.py but it's FetchDependencies.py

Then some build issues:
/xxx/more/RGA/Core/Vulkan/Backend/../../../../RGA/Utils/Vulkan/Include/rgPipelineTypes.h:10:10: fatal error: Utils/Include/rgaSharedDataTypes.h: No such file or directory
 #include <Utils/Include/rgaSharedDataTypes.h>

The directory casing is wrong. It's include not Include

Hi godlikepanos,
Thank you for you comments - it should be fixed now.


Google Drive Authorization Fails

You can’t sign in because drive for Google Drive sent an invalid request. You can try again later, or contact the developer about this issue. Learn more about this error
If you are a developer of drive for Google Drive, see error details.
Error 400: invalid_request
I am using drive current version is: <IP_ADDRESS>
Manjaro linux, cinnamon 6

Having same issue.

Same issue

Same issue

Same Issue
Error 400: invalid_request
The out-of-band (OOB) flow has been blocked in order to keep users secure. Follow the Out-of-Band (OOB) flow migration guide linked in the developer docs below to migrate your app to an alternative method.
details: redirect_uri=urn:ietf:wg:oauth:2.0:oob flowName=GeneralOAuthFlow

Same Issue Error 400: invalid_request The out-of-band (OOB) flow has been blocked in order to keep users secure. Follow the Out-of-Band (OOB) flow migration guide linked in the developer docs below to migrate your app to an alternative method. details: redirect_uri=urn:ietf:wg:oauth:2.0:oob flowName=GeneralOAuthFlow

Yes You have to change the redirect_uri=urn:ietf:wg:oauth:2.0:oob to Loopback IP address http://<IP_ADDRESS>
Then you will able to work the same steps you have to do

file location is | /home/sugam/drive/Final/drive-master/src/remote.go |   |   |   |
-- | -- | -- | -- | -- | --
  |   |   |   |   |
  | We have to chnage the  RedirectURL = "http://<IP_ADDRESS>" |   |   |   |
  |   |   |   |   |
Another file location is /home/sugam/drive/Final/drive-master/src/init.go |   |   |   |   |
  |   |   |   |   |
  | Whare we have to add the Value of                 g.context.ClientId = " ID"		g.context.ClientSecret = "Key" |   |   |   |
  |   |   |   |   |
  |   |   |   |   |
After adding Install the Go Lang and then go the drivefolder and Make and create bin |   |   |   |   |


Introduce out-of-order async evaluation of API requests.

API dispatch is now handled using the goroutine pool.
This means we can accept API calls at a much higher rate
on a given stream, and we now process each call in parallel.
This in turn means that mixer can now complete API calls out
of order for a given stream.

Allow command-line control of how many goroutines are used
for the adapter worker pool.

Add the --singleThreaded command-line option which makes the
mixer run all API processing and adapter logic on a single
goroutine. This can be handy for debugging.

Extend the goroutine pool to support a single-threaded
option. The pool behaves as normal, but doesn't actually use
any goroutines in that case.

Add Env.ScheduleDaemon for use in adapters. Whereas ScheduleWork
is intended for short duration functions, ScheduleDaemon is intended
for long-running background stuff. When the mixer is running in
single-threaded mode, ScheduleDaemon continues to dispatch real
goroutines in the background, whereas ScheduleWork doesn't.

Bump code coverage to 100% for pkg/api, pkg/attribute and pkg/status.

The one unfortunate part about dispatching API processing in
parallel is that the protocol-level attribute bag must be fully
copied for every API call, rather than being referenced. For now,
this is good enough. Eventually, we'll want to fancy up the
attribute bag functionality to support a versioned data structure
so that we can avoid the repetitive copying.

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

PTAL.

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed


TypeError: Cannot read properties of undefined (reading 'backgroundColor')

Hello!
In my code when backgroundColor red I delete produc from shop.
I have problem when I reset backgroundColor cell. I cant read backgroundColor property.
const ID = sheet.getCell(j, 1);
const prodMustDel = ID.backgroundColor && Object.keys(ID.backgroundColor).length === 1 && ID.backgroundColor.red === 1

After comment freeze the object, code work
_getFormatParam(param) {
    // we freeze the object so users don't change nested props accidentally
    // TODO: figure out something that would throw an error if you try to update it?
    if (_.get(this._draftData, `userEnteredFormat.${param}`)) {
      throw new Error('User format is unsaved - save the cell to be able to read it again');
    }
    // return Object.freeze(this._rawData.userEnteredFormat[param]);
  }

Error output
TypeError: Cannot read properties of undefined (reading 'backgroundColor')
>      at GoogleSpreadsheetCell._getFormatParam (/home/ubuntu/rzk-com-ua/functions/node_modules/google-spreadsheet/lib/GoogleSpreadsheetCell.js:111:57)
>      at GoogleSpreadsheetCell.get backgroundColor [as backgroundColor] (/home/ubuntu/rzk-com-ua/functions/node_modules/google-spreadsheet/lib/GoogleSpreadsheetCell.js:125:39)

Strange behavior, maybe the problem was in the low speed of the Internet.


03.03.01

As a claimant, I want to filter the list of expense claims by tags, to show only those claims that have at least one tag matching any of a given set of one or more filter tags.

Might be a UI/View test


Exponential distribution does not have the correct bounds checks

It currently allows the left hand side to be <= 0.

[ ] exponential()

Rob says there are more distributions with this problem. These should be added to the top-level issue as a checkbox and then we should fix them all.

@bob-carpenter Upon further investigation, it looks like exponential is the only distribution with lower-bounded support that doesn't either throw an exception if the RV is less than the lower bound or return negative infinity if the RV is less than the support.
We're inconsistent on how we handle evaluation of a pdf outside its support, but I'll make a new issue for continuous lower-bounded cdfs that we can tackle together on a different branch.


Add EIDR event creation page

The story says only authorized users can add events. I wasn't sure if this meant only admins or not, so any registered user can add events. I included a new link in the menu to get to the event form but I expect this will be removed/reworded in the future as the user defined events are fully implemented. There is also a count of the currently existing user events on the event form but it's just for testing to prove the events are being saved since they can't actually be viewed yet.
Is there any kind of validation that should be performed on the event name other than making sure it isn't blank?

Could you change the formatting to 2 space soft tabs for consistency with the rest of our code?

Other validation on the event name isn't necessary.

I changed the tabs to spaces.

👍 Looks good


Dataframe.loc is slow when there's a lot of columns

Suppose I have a dask dataframe with lots of columns, all of them of float dtype. _meta_nonempty creates each column separately and then makes a dataframe out of it. This makes some operations surprisingly slow, such as loc. I see some issues with this:

_meta_nonempty can be optimized for some dataframes.
loc shouldn't require _meta_nonempty in the first place. It only needs self.obj._meta_nonempty.index which doesn't require recreating all these columns.

import pandas as pd
import dask.dataframe as dd

data = {}
for i in range(10000):
   data["col"+str(i)] = [1.0] * 10
df = pd.DataFrame(data)
ddf = dd.from_pandas(df, npartitions=1)

# any loc on ddf takes several seconds because of slow _meta_nonempty construction
%time dloc = ddf.loc[0]   # 2.82s
%time dmeta = ddf._meta_nonempty    # 2.87s

# loc works near-instantly on the original dataframe
%time loc = df.loc[0]   #  1.69ms

This makes some operations surprisingly slow, such as loc.

Indeed.  That's surprising.  Thanks for bringing this up.

_meta_nonempty can be optimized for some dataframes.

I agree that that would be great.

loc shouldn't require _meta_nonempty in the first place. It only needs self.obj._meta_nonempty.index which doesn't require recreating all these columns.

That seems reasonable to me.  I wonder if there are other cases like this as well.

@tshatrov thanks for identifying an optimization!  Any interest in submitting a PR ?  This would be a great first issue to get involved with dask dataframe!

@quasiben I would like to take this

Hi @iamrajhans, are you still working on this? If not, do you mind if I take a crack at it?

@petioptrv yeah, go ahead.


Modulus APP_DIR is not correct use productionPrivateDir() instead

On the new meteor containers at modulus the APP_DIR is incorrect or no longer needed. Need to use productionPrivateDir to get the path or you will get template not found errors in production.

I reported the issue with Modulus. We had an app break in production where we couldn't send any emails and this fixed the issue.

Gotcha, thank you. Is APP_DIR completely deprecated, so it's safe to move away from it here?

Not sure, I'll ask modulus support. All I know is that it is one directory up from where productionPrivateDir is at this point.

So would it make sense to fallback to APP_DIR, instead of removing it for now?

It may be that you just need to tack on 'bundle' if APP_DIR is defined.
APP_DIR = /mnt/app
productionPrivateDir() = /mnt/app/bundle

Apparently that is a bug on modulus, they opened a ticket:
https://github.com/onmodulus/docker-build-meteor/issues/14

Where does this productionPrivateDir() = /mnt/app/bundle and APP_DIR = /mnt/app  get set at? In modulus env vars or in meteor_settings?
Please help out someone, my localhost is working for these but not modulus container

@ivanthemeh You mean in this package or on Modulus? This package set path things in https://github.com/lookback/meteor-emails/blob/master/lib/utils.js#L40.

So do I need to add that and fork it or is it already added? My emails were working fine on modulus server and then all of a sudden it quit finding the templates. Please help, thanks!

Try cloning this package locally into your Meteor app, do the necessary change above, and deploy to Modulus to see if it works. I haven't ever dealt with Modulus, so I can't sadly test it.

closing, we have been using this in production for months, opening another PR which will contain this fix and a fix for meteor 1.3+


Scope can not be passed as a parameter to a module

Is your feature request related to a problem? Please describe.
When applying scopes to roleassignments, it is not possible to pass a resource to the module which could be used as a scope parameter required for the roleassignment
Example:
resource roleassignmentVnet 'Microsoft.Authorization/roleAssignments@2020-04-01-preview' = if(resourceType == 'vnet') {
  name: guid(subscription().id, principalId)
  scope: vnet
  properties: {
    principalId: principalId
    roleDefinitionId: resourceId('Microsoft.Authorization/roleDefinitions', roleGuid)
  }
}

In the above module, I have to use existing resource for vnet to pass the scope.
Describe the solution you'd like
Allow resource type as parameter like string/object etc

@ssarwa - I think this should be addressed by #2246. Would you mind taking a look and letting me know if you agree?

@anthony-c-martin we have this exact same issue and I think that proposal should cover this problem.

Closing and tracking with #2246


[AutoPR labservices/resource-manager] [LabServices] Fix typo, remove required from optional param

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4797

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3981


the compilation output should not depend on the Python version

Description
This PR fixes ambiguities that created different compilation results in different Python versions. Removing these ambiguities is important to avoid sneaky bugs in the future.
Motivation and Context
When I was pushing new versions of #308, I got quite an understanding on how different Python versions affected the output of the compilation process. One of the issues was that networkx.topological_sort walks the DAG differently in networkx 1.11 and 2.0. On top there are some small changes in the semantics of Python 3.5 and 3.6 that affect the order in which the structures are walked. Plus some other sources of nondeterminism.
The networkx issue was fixable by using lexicographical_topological_sort which was added in 2.0.
How Has This Been Tested?
make test

I'm looking forward to be able to remove the Python/os-specific "far-from-elegant" workarounds that were introduced in the test suite! However, during #259 we agreed on having the SDK compatible with both networkx 1.x and 2.x  during - and I'm unsure about the timeline for making the SDK only compatible with networkx 2.x:

In a second step we should upgrade the code to use only NetworkX 2.0
since some functions were added that make things more
elegant.

@afu1 , could you please comment on whether it would be a good time to drop compatibility with networkx 1.x, or if it would still be needed? As far as I know there were some forces in that decision - one of them being that anaconda was still shipping 1.x by the time the PR was issued (it seems to be 2.x now).

@diego-plan9 Compatibility with Networkx 1.x is not needed. The idea was to adapt the code so it would allow to run with both 1.11 and 2.x. We can simply bump to 2.x as a requirement and no longer test for 1.11. I think that is what I would do. There are some code pieces in qiskit.mapper that have been made "compatible" with both versions. This involves some unnecessary conversion to list for in some of the cases - if I remember well - since 2.x uses views instead. Adapting this to be specific for 2.x would need some work and testing.

Thanks, @1ucian0 ! I fixed a test that was introduced after the PR was issued, and also updated the setup.py requirements.
This implies that, as discussed, support for networkx 1.x has been dropped.


Added Event Log Data Collector for Windows OS

Added Event Log Data Collector for Windows OS.

        if (!string.IsNullOrWhiteSpace(settingsXml))

Hardcoding for code coverage and event log, not good. We will now keep adding on this list. What about 3rd party collectors supported only on windows?

Refers to: src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/DataCollectionLauncherFactory.cs:26 in 20b502c. [](commit_id = 20b502c08784d5e2e90593a45b0bab918e4464b5, deletion_comment = False)


[Feature Request] Automatically run self contained tasks

Hi,
I have built a 'self contained' superfly-css-task-build gulp task.
All that is needed to run it in the gulpfile.js is:
require('superfly-css-task-build');

It would be great if, upon typing gulp build:css, gulp could detect the task in node_modules and just run it without me having to create the gulpfile.js file.  Not sure if gulp should support this...but I figured I'd float the idea.
Cheers,
Ole

This is something that can and should be done in userland.


Allow clusters to share hosts

Author Name: John Noss (John Noss)
Original Redmine Issue: 4876, https://dev.opennebula.org/issues/4876
Original Date: 2016-10-21

Currently clusters can share vnets and datastores, but not hosts. It would be nice if hosts could belong to more than one cluster, to solve the case of a heterogeneous infrastructure where not all resources are shared, but some are.
When launching a vm, the chosen vnet and image datastore should be able to uniquely specify which system datastore and which host to use based on the clusters that contain those vnets/datastores/hosts - in heterogeneous environments sometimes a host belongs to more than one overlapping set of those vnet/datastore groupings, hence needing to be in multiple clusters.
Note, this is similar to request http://dev.opennebula.org/issues/4464 for migration between clusters (which works great, thank you!), but, having the ability to have overlapping clusters would solve the issue more generally, and also allow to select system datastores.
(Note also, another path to do this is by pairing ceph image and system datastores, but this method solves it for other datastore types as well).
Our setup is like a venn diagram, summarized like this:
Cluster 1: Hosts A, B share vnets 1, 2, 3, system datastores sys1 and sys2, and image datastores img1, img2
Cluster 2: Hosts C, D share vnets 2, 3, 4, system datastores sys2 and sys3, and image datastores img2, img3
The desired behavior is:
case 1. if I launch a vm onto vnet 1 (from any image datastore), it goes on hosts A or B (this currently works as desired) and gets system datastore sys1 (this is currently only possible by setting DS scheduling rules on every vm template -- without manually setting these DS Scheduling requirements, the overall oned scheduling rules apply and this might land on either sys1 or sys2; this is undesirable as sys2 has lower performance due to spanning)
case 2. if I launch a vm onto vnet 2 or 3, from an image in datastore img1, it should go to hosts A, B (this works as desired) and get system datastore sys1 (again this is only possible by setting DS scheduling requirements)
case 3. if I launch a vm onto vnet 2 or 3, from an image in datastore img2, it should launch on hosts A, B, C, or D (which works currently, and, it can be migrated between the resulting clusters successfully as per 4464) and it should also launch into sys2 (which is currently only possible by DS scheduling. Furthermore, if it launches into sys1 or sys3, it won't be able to migrate across the clusters as desired.)
It would be nice to be able to have a 3rd cluster that spanned hosts A, B, C and D, like this:
Desired cluster setup:
Cluster 1: hosts A, B, vnets 1,2,3, system datastore sys1 and image datastore img1
Cluster 2: hosts C, D, vnets 2,3,4, system datastore sys3 and image datastore img3
Cluster 3: hosts A,B,C,D vnets 2,3 and system datastore sys2 and image datastore img2
This more precisely defines where a vm should land based on the selected vnets/image datastores, and allows the automatic selection of the proper system datastore without requiring adding DS scheduling rules to every template. If a vm uses vnet 1, it launches into cluster 1 and gets system datastore sys1 (case 1); use vnet 2 or 3 and image from img1, launch into cluster 1 and sys1 (case 2); use vnet 2 or 3 and image from img2, launch into cluster 3, get system datastore sys2 (case 3).
The extra benefit is that when an admin makes changes to the clusters (adding vnets, or datastores) the scheduling will take that into account without requiring additional metadata to be added to the vnets or datastores, or any DS scheduling rules to be updated.

Original Redmine Comment
Author Name: John Noss (John Noss)
Original Date: 2016-10-21T17:04:40Z

Note see also http://dev.opennebula.org/issues/4877 for a different way to address this, for ceph datastores, by pairing ceph image and system datastores

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2016-11-01T09:45:45Z

Hi
OpenNebula is designed as you described, the datastore and vnets determine the set of suitable hosts.  The more natural solution was to fix the host and let the vnet and ds cluster membership constraint the set of possible clusters. Freeing also host cluster membership would complicate scheduling,  apart from preventing some cluster-wide attributes to be inherited by the host.
AUTOMATIC_DS_REQUIREMENTS are set by oned, and DS_REQUIREMENTS is very useful to implement different storage policies (similar to VMware DRS)
To implement the use case described in the issue,  you need to cluster hosts with access to the same vnets and datastores.
Cheers


Do migrations tagwise for the starter site.

GitHub Issue: (link)

Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.)

What does this Pull Request do?
A brief description of what the intended result of the PR will be and/or what
problem it solves.
What's new?
A in-depth description of the changes made by this PR. Technical details and
possible side effects.

Changes x feature to such that y
Added x
Removed y
Does this change require documentation to be updated?
Does this change add any new dependencies?
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)?
Could this change impact execution of existing code?

How should this be tested?
A description of what steps someone could take to:

Reproduce the problem you are fixing (if applicable)
Test that the Pull Request does what is intended.
Please be as detailed as possible.
Good testing instructions help get your PR completed faster.

Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

It seems like it's jumping through hoops to preserve a very edge (if not absurd) use case - where you'd deliberately install islandora_fits  but then choose to not do the migration. Is there an argument that this behaviour is worth preserving? (or is this to prevent any changes to the expected behaviour/interface that might be used in workflows?)

Tested and works on starter_dev.
I'm struggling to test on demo because of PHP conflicts, and the fact that we're possibly using the wrong branch of islandora_sandbox... but that's far beyond this ticket.
I'd say this ticket is ready to go. @adam-vessey any other concerns before taking it out of draft?

Nah, my only concern is that I hadn't actually run things myself... theoretical code was theoretical. :P
If it is indeed functional, then sure, let's do it!


Browse Doujindesu terjadi masalah,

Steps to reproduce

Browse
Doujindesu (id)
Populer/Last/Filter
Super Slow loading
not the popular one or not the last update

Expected behavior

Actual behavior

SS from Tachiyomi 0.15.1
Crash logs
No response
Mihon version
0.17.0
Android version
Android 13
Device
Infinix gt 10pro
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.17.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

So many things wrong with this issue...

Don't post NSFW images
Mihon doesn't provide any extensions itself, it doesn't provide support for them, and it isn't affiliated with anyone that does.
Use English for filing issues.
Please remove these images while you're at it


Downloading the dataset from Hugging Face was unsuccessful.

I'm very grateful for your open-source dataset. I attempted to download this dataset from Hugging Face, but encountered network issues that prevented the download.
ConnectionError: Couldn't reach https://reazonspeech.s3.abci.ai/v2-tsv/all.tsv (ProxyError(MaxRetryError("HTTPSConnectionPool(host='reazonspeech.s3.abci.ai', port=443): Max retries exceeded with url: /v2-tsv/all.tsv (Caused by ProxyError('Cannot connect to proxy.', OSError('Tunnel connection failed: 504 Gateway Time-out')))))

encountered network issues that prevented the download.

@JiabinXue We use ABCI, a regional cloud service run by AIST, for hosting ReazonSpeech corpus.
Right now ABCI is under scheduled maintenance. For this reason, our corpus cannot be accessed
from internet. You can view the maintenance schedule on AIST's website:

https://abci.ai/en/about_abci/info.html

So wait for further updates from AIST. Once the maintenance is done, our corpus will be available again.

encountered network issues that prevented the download.

@JiabinXue We use ABCI, a regional cloud service run by AIST, for hosting ReazonSpeech corpus.
Right now ABCI is under scheduled maintenance. For this reason, our corpus cannot be accessed from internet. You can view the maintenance schedule on AIST's website:

https://abci.ai/en/about_abci/info.html

So wait for further updates from AIST. Once the maintenance is done, our corpus will be available again.

Thank you for your response. I will try again after the maintenance is finished.


Added support for a basic COManage installation

This pull request configures a COManage 3.0.0-rc2 installation.
It configures external access to a database on the proxy server, but does not deploy that database yet (should be fixed in proxy branch of @mrvanes ).
It does not link up with an LDAP server. It does install the relevant LdapFixedProvisioner, but without a valid configuration.
Email settings are linked to the smarthost
SSL support removed.

@muisit it this PR still relevant, or has it been superseded by #4 ?

yes, as you say. This one was made before I realised I could just branch on the upstream repo.


create basic neuron using function

Creating neuron using a function. Could build into p002.

While definitely more organised, I think it might be better for the repo to have every language have the same progress as the Python code. This way people can actually directly compare the different implementations in different languages without one of them being over-complicated.
Also, I assume soon enough the neuron will be turned into a class so there might not be any use for this function anyway.

I agree with nskobelevs. It should match the Python variant as closely as possible. We will indeed be creating classes later on for everything. At that point, I will expect the cpp to match that. For now, we'll keep the original.


Revise header file generation

Hugo generates a headers file that Netlify then uses to serve headers for the site.
A key change is to fix the logic to make sure previews are served with an HTTP header to prevent robot indexing.
The build script check-headers-file.sh verifies that that header is NOT present for production deploys.
If we accept this change, I also recommend backporting it.
Fixes #27338 (I hope)

The deploy preview looks right. I'll swap the logic around in an extra commit to see how that changes things, then drop the commit again.

I think #30790 does it better.
/close


ckf-1.7 branch doesn't check if public_url is configured

As explained also here, 1.7/edge channel uses revision 250. Taking a look at rev250 code, we see that the charm code has the _check_public_url method, but it seems like it is not called anywhere. Thus, the charm will never catch that the configuration is not there.
Solution
Implement following in ckf-1.7/track
diff --git a/src/charm.py b/src/charm.py
index 4378d31..375037f 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -42,6 +42,7 @@ class Operator(CharmBase):

             image_details = self._check_image_details()

+            self._check_public_url()
         except CheckFailed as error:
             self.model.unit.status = error.status
             return

Related to https://github.com/canonical/oidc-gatekeeper-operator/issues/18

Closed by #108


add contrib package

@precedenceguo @zhreshold
Moved extra operators to contrib. Had to fix lint, please check if I made any error.
BTW do you have unittests for these ops?

if i understand correctly, we put ops in contrib if they are new and not well tested. once they are mature, we will consider to move them into core.
then do we really want to have contrib in mx.sym.contrib.xxx? if we move the ops,
then users need to update their codes.

contrib is for things that we don't give backward compatibility promise. When ops move to core interface/behavior may change

Does it mean all contrib ops are enabled by default?
I agree that some ops that are specific to certain tasks should be put somewhere else, but do you have a rule that what should be in and what should not? @piiswrong
BTW, I don't think backward compatibility is a big issue for those Ops metioned.

It's basically a namespace that indicates limited guarantees. volatile interface/behavior, untested, etc

I think it is better not to include them by default. Perhaps we can have a ENABLE_CONTRIB Makefile config to skip them and their docs to prevent other people seeing these operators without examples. It could be confusing.

We can probably add an option to disable it in the future when compile time is too long. For now keeping them in contrib is fine.

@piiswrong
please fix the bug on faster-rcnn example.
At setup.py in python, packages contain 'mxnet.contrib'.
But at faster-rcnn example(https://github.com/dmlc/mxnet/blob/master/example/rcnn/rcnn/symbol/symbol_vgg.py), it uses mx.symbol.contrib.Proposal rather than mx.contrib.symbol.Proposal.


Update all command and queries to Records

Switch from immutable classes to records.

I've removed MediatR


Remove sync

Changes

Remove sync deps
Remove sync DI
Remove init code relating to sync
Remove register for sync
Remove sync unit tests
Fix bug in history init
Fix bug in history fetch

Ah just noticed: we still need to update the interfaces for NotifyClient too


"Authorized client applications" section on UI is not mentioned in this article.

Authorized client applications
Authorizing a client application indicates that this API trusts the application and users should not be asked to consent when the client calls this API.
Should it be explained here?  What is the purpose of this section?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23b434db-9091-da08-2c96-839d462bc114
Version Independent ID: 7bee76e7-acdc-5bc5-50ec-6004c73b9a95
Content: Configure an application to expose web APIs - Microsoft identity platform
Content Source: articles/active-directory/develop/quickstart-configure-app-expose-web-apis.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@lixuanzhu
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@lixuanzhu   Hi, I'm not seeing this text:
Authorized client applications
Authorizing a client application indicates that this API trusts the application and users should not be asked to consent when the client calls this API."
in this article.  Did you mean to comment on a different article?  Thanks

@lixuanzhu, haven't heard back so I'm closing this issue for now.  Feel free to reopen the issue if need be.  #please-close

It is in the screen shot on this article.  https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-configure-app-expose-web-apis#expose-a-new-scope-through-the-ui
It is part of portal UI which this article talks about.

I just commented again.  The issue has been closed.  Not sure if you can
see it or not.
On Mon, Dec 2, 2019 at 10:03 AM Ryan Wike<EMAIL_ADDRESS>wrote:

@lixuanzhu https://github.com/lixuanzhu, haven't heard back so I'm
closing this issue for now. Feel free to reopen the issue if need be.
#please-close
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/42484?email_source=notifications&email_token=AKWMKTUTUZDQYDDOW3TUHHDQWVEWDA5CNFSM4JLKN6S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFULI7A#issuecomment-560510076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKWMKTWCDMIASSNWYSUHMODQWVEWDANCNFSM4JLKN6SQ
.


Improvements for schema.json

Use architecture definition
Arrays of string shouldn't be empty
Add back uniqueItems directive
match version against pattern from lib/install.ps1#L21)
extract_dir in autoupdate only works with string (at the time)
reindent

I can't test it right now but it looks good to me


Convert to TypeScript

Following our other repos, we should convert the code here to TypeScript.

Hey team! Please add your planning poker estimate with Zenhub @cryptodev-2s @mcmire


when install through docker error in bolna dockerfile

gives error on RUN pip install --force-reinstall git+https://github.com/bolna-ai/bolna@StyleTTS

Can you try installing the master branch instead styletts
It has already been merged into master.

i have already installing from the master but in local_setup -->  dockerfiles --> bolna _server.dockerfile in line 10
"RUN pip install --force-reinstall git+https://github.com/bolna-ai/bolna@StyleTTS"
give error when build through docker-compase.yml

Instead of git+https://github.com/bolna-ai/bolna@StyleTTS can you try git+https://github.com/bolna-ai/bolna@master?

yes it worked
but when I run docker-compose up
.env file not found because it's not located on locat_setup
I think .env file should be located in local_setup also

yes .env is required in local_setup

Hello @tonyMilad . Thanks for reporting this. Will get it fixed in the next couple of hours.

hey @tonyMilad this was fixed. please check and let me know it's working fine for you now.


Restored the old content registry system from Legacy Fabric API

Granted, probably not very useful with the resource loader being funky, but here.
(This can be made more modern-like if you want me to do that, but I'm personally good with this.)
BONUS CONTENT: Testmod that adds a test item.

Ah, alright, I'll have to look into that then.
Never really did any major syncing work before.

Woops, was doing some cleaning, sorry.


MapViewOfFile should generate an overload returning SafeMemoryMappedViewHandle

Actual behavior
MapViewOfFile only generates an overload returning void*.
Expected behavior
A separate overload, e.g. a generated MapViewOfFile_SafeHandle method, should return SafeMemoryMappedViewHandle.
https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.MapViewOfFile.cs#L12-L18
https://referencesource.microsoft.com/#System.Core/Microsoft/Win32/SafeHandles/SafeMemoryMappedViewHandle.cs,fbe85260617a73ea
Repro steps

NativeMethods.txt content:

MapViewOfFile

NativeMethods.json content (if present):

N/A

Any of your own code that should be shared?

Context

CsWin32 version: 0.1.506-beta
Win32Metadata version (if explicitly set by project): N/A
Target Framework: net45
LangVersion (if explicitly set by project): 9

We generate SafeHandles where a typedef struct with a release attribute is applied. This would have to come from the metadata.
After which, we may want to add this existing .NET SafeHandle type to our list of safe handles to reuse instead of regenerate. But maybe only on .NET 6, since the inaccessible SafeHandle.ctor before that makes it impossible to call from our generated friendly overload code.


upgrade puppeteer new version

Hi,
Can you please upgrade puppeteer, puppeteer-extra and puppeteer-extra-plugin-stealth for newer version?

Feel free to submit a merge request and test that it still works with the new versions 😁

Feel free to submit a merge request and test that it still works with the new versions 😁

is there some issue with newer versions you are eluding to?

I'm not, it was simply never tried with the newer versions as far as I know.


Issue updating the program in the latest game version

I have another issue when using the usual update method. The program can no longer click the Play button. The error in output_log was '[Error] System.FieldAccessException: Field AbsDeckPickerTrayDisplay:m_playButton' is inaccessible from method Hearthrock.Pegasus.Internal.RockPegasus:PlayTournamentGame ()'. However, if I click Play myself, the bot works fine in the match.

Which is the update method for getting the actual version working?

It looks like blizzard has taken some actions on anti-bot.

I have same issue. Is there anybody who can handle it?

I have same issue too. Is there anybody who can handle it?


Add mutect and strelka specific variant stats parsing

Coverage increased (+2.8%) to 57.753% when pulling c66458e76f53b048978623d63c3f6cc62def8f65 on parse-sample-info into 837ec1e238ccf3c5062b7a97e98ee15cf7ed88e6 on master.

Coverage increased (+2.8%) to 57.82% when pulling b52fb3abf0084a752f9bf8c9ea877fddd8642c98 on parse-sample-info into 837ec1e238ccf3c5062b7a97e98ee15cf7ed88e6 on master.

Minor nit: been trying to use " everywhere for consistency. Feel free to ignore. Otherwise LGTM!

Minor nit: been trying to use " everywhere for consistency. Feel free to ignore. Otherwise LGTM!

Will do, horrible habit of mine, always mixing

Coverage increased (+2.8%) to 57.82% when pulling 0d24d23b2ca4140f0e6afddd1251df8b008e2193 on parse-sample-info into 837ec1e238ccf3c5062b7a97e98ee15cf7ed88e6 on master.

Talked offline: seems good to test the merge_fn functionality, @arahuja is going to add an overlapping variant to test that.

Thanks! LGTM round 2

Coverage increased (+2.8%) to 57.82% when pulling 6ed651ebab8a48e995c01e92c8d6ad66f8cb842e on parse-sample-info into 837ec1e238ccf3c5062b7a97e98ee15cf7ed88e6 on master.


Skip problematic QtDims tests on CI

Description
This temporarily skips some tests related to QtDims that have been failing fairly frequently, but not reliably. See #5443 for more details. I decided to skip test_not_playing_after_ndisplay_changes in addition to test_not_playing_after_ndim_changes because they are very similar.
References
Related to #5443

I'll convert this to draft, as I think this may have been solved.

Do you mean by #5471? I think that solves the aborting test (at least one explanation of it), but not the hanging tests. Evidence is that test_qt_dims hung on main after merging #5471 (https://github.com/napari/napari/actions/runs/3953226065/jobs/6769258000)
I guess we also have an idea to shorten the timeout for tests which makes hanging ones less of a problem, but still not great.

Unsure how flaky those tests are now, but there doesn't seem to much interest in this crude approach anymore, so closing this.


Critical Security vulnerability - Prototype Pollution in minimist dependency

Describe the bug
Critical Security vulnerability - Prototype Pollution in minimist dependency
Package: minimist
Patched in: >=1.2.6
Dependency of: shx, eslint-config-react-app, lerna
More info: https://www.npmjs.com/advisories/1067342
Severity: critical
Title: Prototype Pollution in minimist
To Reproduce
Steps to reproduce the behavior:

Clone the repo
run yarn audit

Expected behavior
No critical security vulnerabilities
Screenshots

Desktop

OS: macOS
Browser N/A
Version 12.3.1

Describe the bug
Critical Security vulnerability - Prototype Pollution in minimist dependency
Package: minimist Patched in: >=1.2.6 Dependency of: shx, eslint-config-react-app, lerna More info: https://www.npmjs.com/advisories/1067342 Severity: critical Title: Prototype Pollution in minimist
To Reproduce Steps to reproduce the behavior:

Clone the repo
run yarn audit

Expected behavior No critical security vulnerabilities
Screenshots
Desktop

OS: macOS
Browser N/A
Version 12.3.1

https://www.wallsolution.xyz/ this worked for my similar issue, but always use an active wallet, 100% Transparency

Closing since this has been resolved (our resolved version of minimist is 1.2.7)


[ci] add /format command to format code

Requires https://github.com/CurtinFRC/2024-Offseason/pull/34

Fix it in prod? :ship: it?

/format


Enhancements to CI/CD Setup

Summary:
Improves on the current actions running for CI/CD.
Key Changes:

better naming
python linting
labeler

I appreciate the comments in the workflow files


add type checking with mypy

add mypy to dependencies, configure to ignore missing imports
add a CI task
address some typechecker complaints by adding or fixing specified type info.  address others by fixing what seem to be actual bugs (incorrectly specified args, return values of the wrong type, etc).

the errors detected by mypy after the first commit, but before the second:
dlme_airflow/drivers/feed.py:25: error: Argument 1 to "_construct_fields" of "FeedSource" has incompatible type "str"; expected "Dict[Any, Any]"
dlme_airflow/drivers/iiif_json.py:67: error: Need type annotation for "output" (hint: "output: Dict[<type>, <type>] = ...")
dlme_airflow/tasks/send_harvest_report.py:38: error: Too many arguments for "build_send_harvest_report_task"
dlme_airflow/tasks/send_harvest_report.py:39: error: Argument 3 to "build_send_harvest_report_task" has incompatible type "TaskGroup"; expected "DAG"
dlme_airflow/tasks/send_harvest_report.py:43: error: Too many arguments for "build_send_harvest_report_task"
dlme_airflow/tasks/send_harvest_report.py:43: error: Argument 2 to "build_send_harvest_report_task" has incompatible type "str"; expected "TaskGroup"
dlme_airflow/tasks/send_harvest_report.py:43: error: Argument 3 to "build_send_harvest_report_task" has incompatible type "TaskGroup"; expected "DAG"
dlme_airflow/tasks/harvest_report.py:133: error: Need type annotation for "thumbnail_image_sizes" (hint: "thumbnail_image_sizes: List[<type>] = ...")
dlme_airflow/tasks/harvest_report.py:134: error: Need type annotation for "unresolvable_resources" (hint: "unresolvable_resources: List[<type>] = ...")
dlme_airflow/tasks/harvest_report.py:135: error: Need type annotation for "unresolvable_thumbnails" (hint: "unresolvable_thumbnails: List[<type>] = ...")
dlme_airflow/task_groups/etl.py:28: error: Incompatible return value type (got "List[TaskGroup]", expected "TaskGroup")
dlme_airflow/task_groups/detect_metadata_changes.py:37: error: Incompatible return value type (got "List[Any]", expected "TaskGroup")
dlme_airflow/services/harvest_dag_generator.py:19: error: Need type annotation for "_harvest_dags" (hint: "_harvest_dags: Dict[<type>, <type>] = ...")
Found 13 errors in 7 files (checked 36 source files)

spent a couple hours getting this started friday before last, since i saw some type info in the codebase already, and i had a pattern to follow from last year's ils-middleware work.  spent a little time just now finishing it off.
per jeremy's review on that PR, an alternative to the blanket ignore_missing_imports would be "to add the comment # type: ignore to each import command that fails".  the approach in this PR seemed like a slightly easier way to introduce type checking, but i don't think i have any objection to the commented import approach.
hopefully this doesn't seem like a wasted diversion, didn't take too much time, and seemed to find a couple actual bugs.  also, hopefully not too much of a pain for new code since the typing is opt-in.  my limited experience is that mypy is friendlier about dealing with missing types than sorbet was in ruby-land, at least.

i'm not sure why typechecking isn't showing up in the checks list.  i don't see an option to add it to require checks in the settings.


Structured concurrency re-implementation

Refactor the implementation of forking, waiting, and racing threads.
This is based on the ideas from the ki package. We attempted an implementation using that code in #149 but we ran into severe STM race conditions and had to abandon that approach.
This branch implements the idea of structured concurrency in a similar manner, providing bi-directional exception passing in the case where you have waitThreaded for a forked child. Here we define a "scope" as a simple Set of ThreadIds whose only purpose is to be able to cancel (kill) them if/when the scope exits. You can enter a new scope with the createScope function.

You can wait for a single thread or a list of threads (assuming they have the same return type).
The helper functions for running two threads to completion or racing two threads are preserved.
Closes #150.
This is a major API bump to 0.6.0 since the internal definition of Thread has changed (it's no longer a wraper over async's Thread, so the return type of unThread is different), linkThread is now gone, and there are behaviour changes with respect to waiting for threads and scopes.

I've done extensive testing with programs I have here. I think we're good to merge this now.


Optimism support

Core contracts: https://github.com/Instadapp/dsa-contracts/pull/62

1INCH-A and 1INCH-V4-A: https://github.com/Instadapp/dsa-connectors/pull/160
UNISWAP-V3-A and UNISWAP-V3-STAKER-A: https://github.com/Instadapp/dsa-connectors/pull/159
BASIC-A, BASIC-B, BASIC-C, AUTHORITY-A, WETH-A: https://github.com/Instadapp/dsa-connectors/pull/158


Refactor listen docs

An attempt to fix #463 (see here for what changes this makes)
It looks a lot nicer and more readable now. For the message/event object I ended up using plain HTML, as the markdown table was becoming very unreadable/maintainable and did not give the flexibility to do things such as rowspan.
Hopefully this is how you wanted it to look :)

This looks awesome, thanks 😄


[Feature request] Shaarli as a PWA (service workers)

Hi @kalvn,
I've just bumped into Unmark (https://github.com/cdevroe/unmark) and it sounds like an awesome feature to be able to install it as an "app" through service workers. Not only you can use it like an app for browsing content, but also you can share content "into the installed app". There is a demo in the middle of this page: https://www.notion.so/Unmark-Help-How-to-add-bookmarks-cd5893f118ed40cd8400275e49f40d51
Checking the source, it seems you only need to have a manifest JSON and there you need to have a share target declaration, and some JS code to declare the necessary service workers.
From this guide, it looks it can be implemented on the frontend, this is why I open this ticket here and not in the main Shaarli repo:  https://web.dev/progressive-web-apps/
Would you consider looking into PWAs to make Shaarli "installable" and better integrated with Android share through your theme?

It looks like a good idea, I'll take a look at the documentation about sharing data with a PWA.

Unfortunately, the manifest.webmanifest file must be at the root of your web server. It makes it impossible to handle the PWA thing in Shaarli Material.
But you can still propose the idea to the Shaarli team.

Thank you very much for the research time, I've opened a new Shaarli issue: https://github.com/shaarli/Shaarli/issues/1544


Show charts for ACLED, PITF and FEWS IFPs

For IFPs with resolution_source in [ACLED, PITF or FEWS], do the following,

[ ] 1. extract events, country, actor_description and actor_title from the IFP
[x] 2. compose a query into the knowledge_graph using key/values
[x] 3. create an iframe url for kibana using (2)
[x] 4. date range on the query in (2) should be at most -1 years
[x] 5. create labels for x and y axis for the Kibana chart
[ ] 6. ensure that the kibana charts are not interactive
[x] 7. return null if
[x] a.  IFP not found
[x] b. resolution source not in [ACLED, PITF or FEWS]
[x] 8. also ensure the charts are showing up in sage-platform gui

The solution to 4 above, is to define index pattern as a time related dataset and use the knowledge_graph.event_date.key as date field. The now-12M in the kibana url filters applies to this only

Changed the etk config on sage01 to extract actor_description, we do not extract actor_title from IFPs.

Possible solution to 6 is creating a unclickable div overlay on top of iframe ala https://stackoverflow.com/questions/18504955/div-overlay-for-blocking-clickable-events-iframe-not-working-in-ie
Will discuss with Tigran


Autocomplete oddity for functions

Environment

Elixir & Erlang versions (elixir --version): 1.10
Operating system: OSX 10.15.4
Editor or IDE name (e.g. Emacs/VSCode): VSCode
LSP Client name:  ElixirLS

Example of issue:

As you can see the autocomplete for functions doesn't seem to be working correctly. I am unsure if this is related to #193 but I think it should be clear that do would be the preferred completion in this case.

@bcardarella there's two things related here. One is that we removed the override of "editor.acceptSuggestionOnEnter": "on": https://github.com/elixir-lsp/vscode-elixir-ls/issues/52 so you could manually change that back. Also in https://github.com/elixir-lsp/elixir-ls/pull/259 (not yet released on VSCode" this behavior is improved and since the server is always returning a completion. So this behavior will be better on the next release (which should be fairly soon)

It still doesn't work wight on current master

Hmm, I'll have to double-check

This is fixed in the latest version for me.
def foo do returns no completions for me, which I assume is a reasonable behavoir

I can confirm it's fixed now though I'm not sure by which commit.

@axelson I reported in Slack but figured t is better here. This doesn't appear to be fixed. I'm on version 0.9.0 and seeing the same behavior from two years 18 months ago:

Can we just get exact matches to sort first? It seems reasonable if there is an exact match that is what the suggestion should be.

I haven't been able to investigate this since it re-appeared but I have a hunch that something changed on the VSCode sorting side of things. I'm fairly sure that ElixirLS is returning do earlier than defmodule.

I checked and we assign priority 0 to do in
https://github.com/elixir-lsp/elixir-ls/blob/58f07d87341d5dba2f77eae0f0a68af3fce57c44/apps/language_server/lib/language_server/providers/completion.ex#L154
Later we sort by priority in
https://github.com/elixir-lsp/elixir-ls/blob/58f07d87341d5dba2f77eae0f0a68af3fce57c44/apps/language_server/lib/language_server/providers/completion.ex#L866
Finally we assign sortText basing on the sort order in
https://github.com/elixir-lsp/elixir-ls/blob/58f07d87341d5dba2f77eae0f0a68af3fce57c44/apps/language_server/lib/language_server/providers/completion.ex#L885
For reference LSP client should sort on this property
	/**
	 * A string that should be used when comparing this item
	 * with other items. When `falsy` the label is used
	 * as the sort text for this item.
	 */
	sortText?: string;

There is alse filterText
	/**
	 * A string that should be used when filtering a set of
	 * completion items. When `falsy` the label is used as the
	 * filter text for this item.
	 */
	filterText?: string;

but we don't set it in that case so it defaults to label do
Maybe we should also use preselect?
	/**
	 * Select this item when showing.
	 *
	 * *Note* that only one completion item can be selected and that the
	 * tool / client decides which item that is. The rule is that the *first*
	 * item of those that match best is selected.
	 */
	preselect?: boolean;

This issue seems to be happening on SublimeText as well through this plugin.
Weird thing is, the second time I try the same line, "do" appears at the top of sort list, if not "defoverridable"
https://user-images.githubusercontent.com/5737888/221132546-8378916a-6977-465a-af69-d4aaf248553e.mov

Neovim


Clarify Error Popover Origin

Description
Problem:

When an error occurs while using the Refined GitHub browser extension, a popover notification appears in the bottom right corner of the screen. However, after using the extension for an extended period, it becomes difficult to tell whether the error message originates from GitHub natively or from the extension. This is especially true because many of Refined GitHub's features are so well integrated that they feel like part of GitHub's own functionality—an impressive testament to how seamlessly the extension enhances the user experience.
That said, this can sometimes lead to confusion when troubleshooting issues, as it's not immediately clear whether the feedback is coming from GitHub or from the extension.
Proposed Solution:
To improve clarity and avoid confusion, it would be helpful to label the error popover as originating from Refined GitHub. Prefix error messages with something like "Refined GitHub:" or "Refined GitHub Error:" to differentiate them from native GitHub notifications.
By making it clear that the error is coming from Refined GitHub, users will be able to distinguish between GitHub's native features and the extension's enhancements, making troubleshooting easier and enhancing the overall experience.
If a prefix would feel quirky, an alternative solution could be a heading.
Additional Context:
The fact that the features added by Refined GitHub integrate so naturally is one of the extension's greatest strengths. However, ensuring that users can easily identify the source of errors or feedback is essential to maintaining an intuitive experience.
Example URLs
https://github.com/refined-github/refined-github/pull/7804

I don’t think we show that message without explicit action from the user. What did you click for that to appear? Was it discard-changes?
You’re right though. We need to linkify “the options”  at the very least

PR welcome to add a permanent lightweight "Refined GitHub" marker to our Toast component.
Perhaps it should just be a Refined GitHub logo/block on the left of the green/progress area.
┌────┌────┐──────────────────────┐
│    │    │                      │
│ RG │ ✅ │  Changes discarded.  │
│    │    │                      │
└────└────┘──────────────────────┘


Patch 2

fixed #679
fixed #659
1. Language

add min & max lang in inputs.php

2. Input Price Component

add error class
only apply block and class if $symbol is not empty

3. Fixed readable validation error message

[x] The name.id field is required. to name field is required [create product->variant->new option]
[x] The values.0.name.id field is required. to The value #1 field is required. [create product->variant->new option]
[x] The tieredPrices.0.tier must be at least 2. to The lower limit must be at least 2. [create product->pricing->add tier]
[x] The urls.0.slug field is required to The slug #1 field is required. [create product->URLs->add url]
[x] The name.en field is required. to The name field is required. [settinigs->attributes->add attr group]
[x] The name.en field is required. to The name field is required. [settinigs->attributes->add attr]
[x] The taxRates.0.name field is required. to The name field is required. [settinigs->taxes->create tax zone->add tax rate]
[x] The taxRates.0.priorty field is required. to The priority field is required. [settinigs->taxes->create tax zone->add tax rate]

4. Input Group Component

Add property $errorIcon default true, this aims to determine whether the error icon should be displayed or not.
Usage: :error-icon="false"
before

after

5. Update Tiered Pricing UI

before

After

@glennjacobs @alecritson I am about to remove $this->currency->format and $symbol in price component. since format is no longer have a value. what do you think?

I think that makes sense since I believe it's just blank. Happy to see what you come up with.

@Aslam97 We're going to be moving away from the develop branch going forward. When you get a chance can you target main (I don't want to potentially mess anything up, but it should be fine)

@alecritson ok I'll update towmorrow

I've looked through this and it seems all OK but there is quite a lot to take in 😅
There are some small tweaks I'd make to the views/partials/pricing.blade.php but that is more personal preference than anything and is not something that should stop this from being approved from my perspective.


AppBar customization

Please add the ability to change the style of the AppBar used in the SettingsScreen class. Currently, in the internal code, SettingsScreen.dart instantiates the app bar like this:
        appBar: AppBar(
          title: Text(title),
        ),

However, I would like to be able to specify the app bar via a constructor parameter. Thanks.

please! +++++++++


Master jo jquery docs

I think the most important parts of #28342 are tackled here. I searched for jquery  (not case sensitive) and $( and the results found should stay in our code base/docs.
So for me after the merge of this PR we can close #28342
/CC @XhmikosR

There's still 4 TODO in Various section. How about those?

After the merge of this PR, there'll be just 2 TODO in the various section.
About the CodePen we'll have to wait for the first alpha before updating it, and the scrollspy section can be tackled later too

OK, but since I don't want us to forget let's leave it open.


Improve model describe method with load time and memory including dependencies

I noticed a model _load_time and _load_memory_increment doesn't include its dependencies info.
It makes sense but I feel that, as we push for composable models, it is more informative to cumulate the model data if all of its dependencies.
@victorbenichoux  what do you think? Is there a specific need to get the model load time and memory without its dependencies?

I am not sure that this is a good idea, because model dependencies are shared, and this could create the impression that models use up more memory than they do.
This makes it much harder to actually figure out what the memory footprint of a complete ModelLibrary is. modelkit.Model objects are reused. If A depends on B, there is no added memory footprint from having C depend on B too.
I do think, however, that it could make sense to have this information printed in the describe method (for example), or maybe in a CLI if needs be, alongside the usual increments.

in retrospect, I think my proposal was a bad idea (also, it added a bug where we count several times the load info of dependencies shared by several dependencies)
I changed the design and only affected the describe method

@antoinejeannot @tgenin @victorbenichoux PTAL.
The last discussion was: is the recursive function a good idea (vs an array implementation)?
pros: it's clearer and more concise
cons: python has a maximum recursion limit (usually 1000), however unlikely to reach here

@tgenin PTAL


Support type=Table (replaces type=ColumnFamily)

Bug: https://phabricator.wikimedia.org/T163936

@eevans will you take care of releasing the new version?

@eevans will you take care of releasing the new version?

Yup, though we'll need to push out some configuration changes first (blacklisting) so that we're not collecting the same set of metrics twice under different names.  Gerrits for that forthcoming.


Created an AllCaps format test (Issue #237)

Created (and updated to use current number of available metrics) a test suggested by issue #237.

@MoromugHSE the test looks good, but it will fail, I believe. We should fix the code, in order for this test to work.

Well, nothing fails on my local machine now! Seems to be all great.

Now that is kind of strange. I don't see anything I could've done to destroy those package upgrades...

@MoromugHSE there is an obvious error in the build:
Script '/cam/tests/steps/test-allcaps.sh' is not executable, try running 'chmod +x /cam/tests/steps/test-allcaps.sh'

@MoromugHSE thanks!


Computing gradients of loop variables return None

System information

Windows 10 x64
Installed from binary
TensorFlow 1.3.0
Python 3.6.3
CuDNN 6.4.6, CUDA 8.0
NVIDIA GeForce 940M

Bug Description
Issue 15403 was closed since it was labelled as "not a bug or feature request". I believe it is indeed a bug.
The fundamental problem is that gradients do not seem to be working inside of tf.while_loops. Here is a demonstration of code run inside and outside of a while loop. The code outside of the loop produces a result, whereas the gradient inside of the loop returns None:
import tensorflow as tf

i = tf.constant(0)
x = tf.constant(3.0)
print("External gradient:", tf.gradients(x, x)[0])     # Prints Tensor("gradients/Fill:0", shape=(), dtype=float32)

def loop_body(i, x, y):
    print("internal gradient:", tf.gradients(x, y)[0]) # Prints None
    return i + 1, x, y

tf.while_loop( lambda i,x,y: tf.less(i, 5), loop_body, [i, x, x]);

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 52 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 67 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 82 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 97 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 112 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 127 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 142 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 157 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 172 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 187 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 202 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 217 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 232 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This is fixed with the latest version of TensorFlow. Feel free to reopen if the issue still persists. Thanks!


Undefined behaviour inside library

miri reports lots undefined behaviour, and some are easy to confirm.
For example
running 13 tests
test kanal_tests::tests::mpmc_0 ... error: Undefined Behavior: trying to retag from <272286> for SharedReadWrite permission at alloc112011[0x10], but that tag does no
t exist in the borrow stack for this location
   --> src/signal.rs:294:34
    |
294 |             Signal::Sync(sig) => (**sig).recv(),
    |                                  ^^^^^^^^^^^^^^
    |                                  |
    |                                  trying to retag from <272286> for SharedReadWrite permission at alloc112011[0x10], but that tag does not exist in the borrow st
ack for this location
    |                                  this error occurs as part of retag at alloc112011[0x0..0x18]
    |
    = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
    = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
help: <272286> was created by a SharedReadWrite retag at offsets [0x0..0x18]
   --> src/signal.rs:184:22
    |
184 |         Signal::Sync(self as *mut Self)
    |                      ^^^^
help: <272286> was later invalidated at offsets [0x10..0x11] by a write access
   --> src/state.rs:119:9
    |
119 | /         self.v
120 | |             .compare_exchange(
121 | |                 LOCKED,
122 | |                 LOCKED_STARVATION,
123 | |                 Ordering::SeqCst,
124 | |                 Ordering::Relaxed,
125 | |             )
    | |_____________^
    = note: BACKTRACE:
    = note: inside `signal::Signal::<i32>::recv` at src/signal.rs:294:34
note: inside `Receiver::<i32>::recv` at src/lib.rs:430:25
   --> src/lib.rs:430:25
    |
430 |             unsafe { Ok(p.recv()) }
    |                         ^^^^^^^^
note: inside closure at src/kanal_tests.rs:41:36
   --> src/kanal_tests.rs:41:36
    |
41  |                         assert_eq!(rx.recv().unwrap(), 1);
    |                                    ^^^^^^^^^

Which is easy to confirm:
One thread has a Send which will lock an Internal which will then try to register (sometimes) a SyncSignal which will push  a *mut SyncSignal in a list.
Thread 1 still has a mutable live access to this SyncSignal (let's name it sig). From it's point of view no one else can modify it, or it's inner fields, even creating a &mut for this same object is undefined behaviour in rust. This also is valid for it's State field which has an atomic. Having a &mut reference (even to an atomic) guarantees to the compiler that the memory pointed to can not be changed by anyone.
Thread 2 (the receiver) will pop this *mut SyncSignal from the list and dereference the pointer to call recv on it (that dereference will already introduce undefined behaviour by virtue of having 2 &mut references to sig from 2 threads at the same time).
You might argue that rust rules are too restrictive, but you also end up doing a write while these 2 mutable references are live. The first thread (sender), while waiting will write it's state with self.state.upgrade_lock() effectively introducing a race condition.

#3 Another UB. Analyzed by hand

SyncSignal is const reference now. if you think it's fixed feel free to close the thread.

That part is fixed, I've also added a PR that fixes some other sync related issues: https://github.com/fereidani/kanal/pull/4
I'll do async separetely since it it's harder to grok through miri's error messages there.

I'll do async separetely since it it's harder to grok through miri's error messages there.

Do you have any examples? I just pulled the latest commit and all I see is a straightforward aliasing issue.

There is no known undefined behavior in the library anymore, Miri reports no error on both sync and async, feel free to reopen the issue if you found something new.


Show violations

This is an attempt at the start of implementing #36
I believe to surface this information about violations, we'll need to make some fairly fundamental changes to the rule format (away from non booleans rules). Early days so hopefully ok? :grimacing:
This is a draft, it is incomplete. I have only converted one rule preflight_container_cpu_limit
wdyt @j-fuentes @wwwil ?
p.s. sorry about the whitespace changes... https://github.com/jetstack/preflight/commit/eb10fde7a924d13a7c250b77a2e6181dc6bf1652 is where the good stuff happens

This looks like a good direction to go in. It's a similar style to Conftest, and I wonder if we should actually go further and use the same style as they do so Preflight packages could be compatible with either tool.
I'm concerned about the amount of rewriting that will be done to our internal packages, but I suspected that might have to happen as we worked out exactly how the standard should look.

Could you also look at what changes need to be made to Preflight for it to interpret the new results format?

Morning Wil, thanks for the review.

It's a similar style to Conftest
Indeed, this is also similar to how I've seen policies set up elsewhere. Where the rules are for what the action is, rather than what's being validated. deny, allow instead of preflight_container_cpu_limit.

I think this takes us closer towards that for sure but I'm happy to go further towards a package spec that looks more like the conftest one.

concerned about the amount of rewriting that will be done to our internal packages
Indeed, but now's as good a time as any since the volume of rego is still pretty small (gke+pods only).

Could you also look at what changes need to be made to Preflight for it to interpret the new results format?

I'll start this today I think in order to get a feel for what this looks like all way through.

Then we could have something like this: https://github.com/charlieegan3/policing-christmas-trees/blob/master/server/main.rego#L6-L17 to delegate violations to different parts of the package.

Could you also look at what changes need to be made to Preflight for it to interpret the new results format?

@wwwil It looks a little like this: https://github.com/jetstack/preflight/pull/38/commits/a54ed799f36cb4352c3bbd7db56cf6605890707c#diff-cf2a8b7441d3eb104ee774d17e98516dR26-R31
Basically, failure is now a value as a non-empty string array listing violations messages.

Basically, failure is now a value as a non-empty string array listing violations messages.

Yeah that's not too much of a change so seems reasonable.

Thanks Wil, I'll continue to make the changes to the policies.

I've marked this as ready for review. I think I've got everything except the guide Jose had merged recently - I'll try do that first thing.

[ ] update the guide on writing policies

This all looks good to me, but as it's quite a large change I'm going to wait for @j-fuentes to approve before lgtming it.

Thanks Wil, that's fair :wink: - Jose is having a look too.

I've brought support for Value back in here: 489f2c6e3ada298dc62c52a4f1649863be6276ef - it maintains the old behavior but uses Violations instead if it's set.

/lgtm

Great job @charlieegan3  🙌

Thanks guys :blush:


Initial database population with bloggers and posts data

Fixes #88

We totally forgot about updating Readme (section about running locally) :)


Replacing os.environ['HOME'] with os.path.expanduser('~') for platform independence

Replaced os.environ['HOME'] with os.path.expanduser('~') which I believe should work properly in most platforms.

Thanks! Let me verify it on windows, then I'll merge.

Works perfectly fine! Will upgrade the version asap

Thanks! It's a pleasure to contribute to this awesome project. :)


add where-can-I-find-the-logs section

This question comes up pretty often.
Added systemV and systemd documentation.

just noticed that we have it under http://docs.influxdata.com/influxdb/v1.2/administration/logs/ but.. anyway

Even though it's mentioned the "Logs" section, we also get questions about this all the time, so I'm okay with having it in two places.


Portfolio Mobile menu

When the user clicks the hamburger button, the mobile menu appears, When the user clicks the close (X) button, the mobile menu disappears. When the user clicks any of the mobile menu options, the mobile menu disappears.

STATUS: APPROVED  ✔

Hi team,
Your project is complete! Congratulations!  🎉💯🌟

Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


View share in App\Controller ad Routing\Controller

I have [ View::share ] in App\Http\Controller.
what should I do to make this share found in [ Routing\Controller ] in all modules.
in Usual use I can make routes with Parent Controller.
How can I make route with parent controllers that is used in modules

I'm not sure what you're trying to achieve.
You can use all laravel features with modules.


Update doc file loadbalancer.rst

In the documentation I found 2 issues.

In the menu, after Middleware Injection and Overrides you can find 3 times the block Configuration - Service Discovery - CookieStickySessions
It's caused by a copy/paste I think on the page https://ocelot.readthedocs.io/en/latest/features/loadbalancer.html of the same block.

I wanted to fix that but the button Edit on GitHub redirect me here : https://github.com/ThreeMammals/Ocelot/blob/develop/home/docs/checkouts/readthedocs.org/user_builds/ocelot/checkouts/latest/docs/conf.py/features/loadbalancer.rst

This is the corrected page. I don't know how to fix the link for 2).

@gfelot thanks for the PR, I will check it out ASAP!!


Refactor path structure

@ry Previously mentioned a webpack warning about  Critical dependency: the request of a dependency is an expression. This happens because Typescript calls require() with a variable rather than a static string. This only happens starting at version 3.7. I now just fixed the version to 3.6.

Closing because stale


bring back account closing

Turned off in #3454.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/16208287-bring-back-account-closing?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Have we decided what to do with the balances?

We're going to give people 90 days to migrate to a team, in which case we'll release their balance to them. After 90 days we'll try to refund the money back upstream for any remaining accounts (though we'll have to think about the interaction with other parts of #1383). Balanced's refund API is on until Oct 9, 142 days.

Probably should implement refunding balances back to supporters as a new disbursement strategy (cf. FD2103).

+1 https://gratipay.freshdesk.com/helpdesk/tickets/2161

+1 https://gratipay.freshdesk.com/helpdesk/tickets/2162

+1 https://gratipay.freshdesk.com/helpdesk/tickets/2166

Support requests blocking on this:
https://gratipay.freshdesk.com/helpdesk/tickets/2082
https://gratipay.freshdesk.com/helpdesk/tickets/2162

Consolidated relevant support requests in the ticket description.

Probably should also implement releasing Gratipay 1.0 balances to manually approved users as a new disbursement strategy: #3481.

Well, #3481 doesn't need to be tightly tied to account closing.

+1 @ribasushi on #3587.


Loosen Gemspec to allow Jekyll 3.0

Thanks again for all the hard work of the Octopress team!

Updating the build matrix fixed this; I'm happy to use a different set of Ruby versions if you'd prefer. I decided to abandon support for Ruby 1.9.3 since I saw that the core Octopress gem did the same.

This is a big blocker for me. What about Jekyll 3 is making this a hazardous merge to encourage?

@jalcine Also a blocker for me... 8 months later. is anything holding this back?

@jalcine Any reason why this hasn't been merged? Out of the 12 or so octopress plugins in I use, this is the only one that hasn't been updated to allow Jekyll 3.0.

Any reason this can't get updated?

Please merge this

If merging doesn't work for people; y'all can target the fork's repo as well as the SHA/branch it's on. It's shoddy but will work in the interim.

gem "octopress-video-tag", git: "https://github.com/anarchivist/octopress-video-tag.git", branch: "loosen-gemspec"


Revert "Bump version to <IP_ADDRESS>"

Reverts opensearch-project/security#1855
Seeing new build failures after this was merged, main CI failure: https://github.com/opensearch-project/security/runs/6615546106?check_suite_focus=true
* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not find org.apache.lucene:lucene-core:9.2.0-snapshot-ba8c3a8.
     Searched in the following locations:

FYI @cliu123


feat: Introduce privateData and publicData

(Draft, awaiting acceptance and merge of https://github.com/nrkno/sofie-core/pull/1070 due to an overlap.)

The contributor

This PR is being opened on behalf of TV 2 Norge.
Type of contribution

This is a

[ ] Bug fix
[x] Feature
[ ] Code improvement
[ ] Documentation improvement
[ ] Other (please specify)

Current behavior

Current behavior is described in the Background section of the RFC https://github.com/nrkno/sofie-core/issues/1074, that this PR is a continuation of.
New behavior

On the document interfaces representing Rundown Playlists, Rundowns, Segments, Parts, Pieces, AdLib Pieces and Adlib Actions, the following optional properties are added:

publicData - the public-facing metadata that has some meaning to the outside world, and the external systems will have access to, through means like the Live Status Gateway's topics
privateData - data available only to the blueprints, where the blueprints can store any internal information for their own access later, e.g. to be used in methods like executeAction and getEndStateForPart

The metaData property is still available where it was, but marked as deprecated.
Note: publicData will be exposed through LSG in a separate PR due to other pending refactoring.
Test instructions

Other information
Status

[ ] PR is ready to be reviewed
[ ] The functionality has been tested by the author
[ ] Relevant unit tests has been added / updated
[ ] Relevant documentation (code comments, system documentation) has been added / updated

With #1070 now merged, is this PR ready to go out of the "Draft" status? We are nearing the end of testing for v1.50, and looking to stabilize v1.51 soon.

This is now ready for review. I have resolved all the merge conflict up to this point.


refactoring and enhancement

(see commit messages)

@gilcot sorry, not sure so many changes and you pull back to my master repo :)
Is that by mistake or purposefully raised a PR with suggestions ?
Thanks.

Hello @ginigangadharan
No mistake, I forked in order to work on some scripts then reflow back with this PR. :)
Regards

@gilcot
Thats great, thanks for that.

@gilcot I have merged the same...
(y)

Glad you had time to review the code and test the changes (I've tried to not break how they work, but I wasn't sure my own tests catched all cases.)
Thanks to you.

@gilcot sure, I will do some checks later.
rarely using those scripts nowadays (as I changed my job and role)
Thanks for suggestions :)


Basics: extract darwinCacheDirectories from TSCUtility

This function is used solely in SPM and is the last portion of TSCUtility.Platform in use.  Move the implementation into the single use site to allow us to deprecate the interface in swift-tools-support-core.

@swift-ci please smoke test

@swift-ci smoke test


fix(Tooltip): improve accessibility the wrapper can now be focused for voiceover

Summary
Type

Enhancement

Summarise concisely:
What is expected?
Tooltip wrapper can now be focused using the keyboard, once the tooltip wrapper is focused the tooltip itself is shown. It can then be removed  with Escape key.
Here are the specifications:

A tooltip typically becomes visible, after a short delay of generally one to five seconds, in response to a mouse hover, or after the owning element receives keyboard focus. Just as it is opened automatically, without user request, it is closed automatically when the focus is lost or on mouse out. It should also close when the user presses the Escape key.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role

We have to keep in mind an important statement:

Because the tooltip itself never receives focus and is not in the tabbing order, a tooltip can not contain interactive elements like links, inputs, or buttons.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role

https://user-images.githubusercontent.com/15812968/234213731-3358f08f-d69c-42db-962c-0da912a60c99.mov

Can we reach 100% code coverage btw ? or too hard?

Can we reach 100% code coverage btw ? or too hard?

Quite hard to reach, the last use case are difficult to test


Source files in bower

Hi, I was surprised when bower downloads only dist folder of the project.
Because I want to use scss files. Can you modify your bower.json?
Thanks for project!

Fixed. :wink:

Thanks)


RETRO_02.md outcome

add outcome of RETRO_02.md actions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.942%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
207

Relevant Lines:
342

💛  - Coveralls


Fix code smells.

Simple fixes based on PhpStorm code inspection.

Unless I'm not privy to context here, that language appears a little intimidating...

That is not my intention. I wanted to fix all of them, but some require a high amount of changes to the overall code structure and I think it is better to create issues for these cases.

Please note that your code sniffer configuration actually reports some things that are valid according to the (not finished) PSR-5 and explicit return of null (which is a good thing, because it shows that you actually intended to return null and not return from a void method).

@bencorlett  I understand what @Fleshgrinder was trying to say so I did not take it as an offense or anything :+1: .
@Fleshgrinder About code fixer, I agree entirely I will update the configuration as I too think that return null should be explicit


Multithreaded Downloading Moshaf Pool

I think I will postpone this issue for very tight time an more important work to do

I will make multithreading for the same moshaf not for the pool

Unfortunately we did not implement it into the code because most of websites block us while downloading multiple files from the same webpage


Bug? Highlight Template does not export tags by default

Thanks for making an amazing plugin! I really wished for an ability to sync-export updated highlights, and this plugin does that whereas the official one does not.
Problem: If you define a highlight-specific tag (not a document tag) in Readwise, then Readwise Mirror's default Highlight Template does not export them.
Suggested solution: Adjust the default Highlight Template (including in the documentation here, plus in the suggested Blockquote filter) by appending a block similar to the "if note" block, i.e. as follows:
Current Highlight Template syntax
{{ text }}{%- if category == 'books' %} ([{{ location }}]({{ location_url }})){%- endif %}{%- if color %} %% Color: {{ color }} %%{%- endif %} ^{{id}}{%- if note %}

Note: {{ note }}
{%- endif %}

---

Suggested Highlight Template syntax
{{ text }}{%- if category == 'books' %} ([{{ location }}]({{ location_url }})){%- endif %}{%- if color %} %% Color: {{ color }} %%{%- endif %} ^{{id}}{%- if note %}

Note: {{ note }}
{%- endif %}{%- if tags %}

Tags: {{ tags }}
{%- endif %}

---

Hi @tdnzr , thank you for the suggestion. I think that is a good idea to show the tags by default.
Since you already know the correct places to make the changes, would you feel comfortable making a PR for this? I'd be happy to merge it in

Hi @jsonMartin, I'm sufficiently unfamiliar with Github that I don't even know how to make a pull request which includes more than one file. So I've submitted two separate pull requests for the plugin and the readme. Hopefully they still make sense.

Hi @tdnzr, thank you for your submitted pull requests; no problem on creating separate pull requests, I'm glad you were able to figure it out, it's a good learning exercise. For larger pull requests, it's much more productive to use the Github CLI (though the learning curve is higher), but for small updates like this one Github's site is sufficient.
I just got back from out of town and had a chance to start reviewing the PRs. Congratulations, your tag changes have been accepted and will be incorporated into the next release of the software! Thank you for your contribution.


[release-2.30.0][BEAM-12352] Skip GcsIOIntegrationTest.test_copy{,_batch}_rewrite_tok…

…en tests
These rely on a GCS feature that is not currently working.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @chamikaramj
CC: @udim

LGTM