Selenized theme has bad colors

I don't know if it is intended, but the selenized colors looks weird in comparison to the solarized colors for exemple:
selenized:

solarized:

The colors at the left and right extremes looks good, but at the middle it's kinda hard to read.
And other problem that i encountered is the theme naming, selenized has to themes, selenized, and selenized_bw, and in the lightline repos there is selenized_light, selenized_dark, selenized_white and selenized_black. Light/dark and White/Black variants could be just one theme, and determine the bg/fg with the background value, like solarized does, but with selenized and selenized_bw.
And after comparing the colors in the selenized theme and lightline theme i found that the colors has different hex values.
If you are interested in the proposed changes, can make a pr tomorrow trying to solve those problems.
Thanks for developing this awesome plugin!

Concatinating the background variants makes it difficult to switching them on the fly but it's ok as long as leaving the both variants like PaperColor. Improving the colors is welcome.


Stone Barrel - Cobblestone generation not functional

Stone Barrel Cobblestone generation does not work.
The Barrel only fills with water when I right-click on it but no Cobblestone is generated.

Update your pack. It was fixed

I'm on Delta Hotfix 3 already.

Odd thing I found is that is only working once when I restart the server (or client), meaning it generates one Cobblestone when I right-click on the barrel to fill it up with water but when I do it a second+time, it does not work.

This should have fixed it https://github.com/trulyno/star-technology/commit/d6506a5609ea4b7d6cf770a24432154875eff2f4

I can confirm that the "fix" is present in my files, both on the server and client but it's not working.

then it is a mod issue. for now you can use the igneous extruder for auto cobble or a create cobble farm

Is NeoForge and Forge fully compatible? Because I see that the mod is only for NeoForge for the current version of modpack Minecraft version so you had to use that.

it should be, I did testing
it also is not a universal issue, some people can't make cobble, but others can

For people still experiencing this: dont use a hopper. use a chute. that seems to fix the issue


Change app icon

Description
No response
Suggestions
I would like to be able to change the icon of the WebCord app, either to the original Discord icon or to any other icon of my choice. This would be a nice feature to have, as it would allow users to customize the app to their liking.
Alternatives
No response
Additional Context
I'm on Linux and I use the Flatpak version of the app.

using AppImage:
Create a file (program_name.desktop) in .local/share/applications
put your icon path at "Icon"
[Desktop Entry]
Name=WebCord
Exec=/home/matheus/bin/discord/WebCord-4.7.0-x64.AppImage
Icon=/usr/share/icons/Zafiro-Icons-Dark/apps/scalable/discord.svg
Type=Application
Categories=Network;


Add optimum intel nncf extra to setup

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Doing update doesn't update value in GET builder,

Describe the bug
The value in GetBuilder doesn't update if value is changed, even if update() is called.
To Reproduce

Here's the sample widget.

class LoadingWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GetBuilder<LoadingController>(
      init: LoadingController(),
      builder: (_) => AlertDialog(
        content: Text(
          _.loaderMsg,
        ),
      ),
    );
  }
}

And here's the controller

class LoadingController extends GetxController {
  String loaderMsg = 'TempLoading';

  void showLoader({String msg = 'Loading...'}) {
    loaderMsg = msg;
    update();
    Get.dialog(LoadingWidget()); //<-- even moved it above but not working.
  }

  void hideLoader() {
    Get.back();
  }
}

And call it like:

RaisedButton(
  onPressed: () {
    LoadingController().showLoader(msg: 'Loading some new content');
  },
  child: Text('Show Loader'),
),

Expected behavior
When clicking on Show Loader button the text is in LoadingWidget should update, but whenever the button is click, there's only TempLoading text which is the default text.
Flutter Version:
1.17.5
Get Version:
3.4.0
Describe on which device you found the bug:
Pixel 2 API 28 - Android.

You are not calling a function, you are creating a new instance, and accessing a function from that newly created instance.
RaisedButton(
  onPressed: () {
    LoadingController().showLoader(msg: 'Loading some new content'); // HERE
  },
  child: Text('Show Loader'),
),

You should have done something like this:
RaisedButton(
  onPressed: () {
    Get.find<LoadingController>().showLoader(msg: 'Loading some new content'); // HERE
  },
  child: Text('Show Loader'),
),

@jonataslaw Thanks for quick response. I also tried that but this didn't work.

════════ Exception caught by gesture ═══════════════════════════════════════════
The following message was thrown while handling a gesture:
 LoadingController not found. You need call put<LoadingController>(LoadingController()) before

When the exception was thrown, this was the stack
#0      GetInstance.find
package:get/…/instance/get_instance.dart:162
#1      Inst.find
package:get/…/instance/extension_instance.dart:19
#2      LoginView.build.<anonymous closure>
package:bluebox/…/login/login.view.dart:29
#3      _InkResponseState._handleTap
package:flutter/…/material/ink_well.dart:779
#4      _InkResponseState.build.<anonymous closure>
package:flutter/…/material/ink_well.dart:862
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#399b8
    debugOwner: GestureDetector
    state: possible
    won arena
    finalPosition: Offset(209.9, 353.9)
    finalLocalPosition: Offset(48.2, 18.2)
    button: 1
    sent tap down
════════════════════════════════════════════════════════════════════════════════```

try lazyput it in main.I just tried it on myapp and it works, shows correct text when open the dialog.
class DI {
  static init() {
    /// Services
    Get.lazyPut<LoadingController>(() => LoadingController());
  }
}

void main() {
  DI.init();
  runApp(GetMaterialApp(
    home: MyApp(),
  ));
}

import 'package:get/get.dart';
import 'package:myapp/screens/loadingwidget.dart';

class LoadingController extends GetxController {
  var loaderMsg = 'TempLoading'.obs;

  void showLoader({String msg = 'Loading...'}) {
    loaderMsg.value = msg;
    Get.dialog(LoadingWidget());

    update();
  }

  void hideLoader() {
    Get.back();
  }
}

import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:myapp/services/loadingcontroller.dart';

class LoadingWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GetBuilder<LoadingController>(
      init: LoadingController(),
      builder: (data) => AlertDialog(
        content: Text(
          'State:   ${data.loaderMsg.value}',
          style: TextStyle(fontWeight: FontWeight.bold),
        ),
      ),
    );
  }
}

 RaisedButton(
                onPressed: () {
                  Get.find<LoadingController>()
                      .showLoader(msg: 'Loading some new content');
                },
                child: Text('Show Loader'),
              ),

Best!
but wait why did you use .obs? Is it required? I am not using it though.

Good :) Yeah String type will work if you use GetBuilder and update. I am not sure i think @jonataslaw has to answer but if it should be an "observerable" it needs .obs so you can use it in OBX functions (no need for update).

@lundin thanks!
I know it and I am in love with Observables and have been using it in TypeScript.
But overuse of it is not good and shouldn't be used just for small tasks like changing the widget text.

Hello! i'd like to explain some things:
You don't need update() in that case
As you know, update() is meant for rerender some Widget that is being show on the screen with a new value you want.
But if you pay attention, you are calling update() before the dialog show on screen! That means that you don't need update() in this occasion, because when dialog get show in the screen, it will get the value msgLoader has, and it will be the value inside the method, because you already changed the value before open a dialog
so, update() in that specific case is doing nothing.
.obs is not needed to work
since you don't need update, you don't need .obs too, because it is to update value of something that is already showing at the screen. Besides, when you using vars with obs, the widget you need to make it work is GetX(), not GetBuilder(). The reason it worked is because you didn't even needed in the first place
You need to make a instance of the controller before using it
The reason you got this error when you applied the changes @jonataslaw requested is because on the RaisedButton the controller was not initialized yet. And that's why putting it in the main method works. A good thing to do is add fenix: true to controller, like that:
Get.lazyPut<LoadingController>(() => LoadingController(), fenix: true);

By default, controllers are disposed when you are not using them in some screen, so if for example, you use it on the first screen, but don't use it in the second, it will be disposed and in the third screen you will not have the controller to use and it will give error.
the fenix: true argument makes so that whenever you call this method and the controller does not exist anymore, it will recreate the instance for you to use (now the name makes a little more sense right? 😅 )
that's all. I hope it helps you understanding better this package.

In my opinion, "fenix" is a bad property name, it should just be "recreate".

In my opinion, "fenix" is a bad property name, it should just be "recreate".

or it can have the same name that is used in bindings, keepFactory
although this would probably confuse people. Or not, since it does the same thing

@joanofdart and @Nipodemos very appreciated thanks. You don't know how much I love this package. This is one of theeee besssst package ever i have seen. I am exploring it further.


Dynamic lighting using normal maps?

From discussion Dynamic lighting using normal maps?
https://www.codeandweb.com/spriteilluminator

Any update regarding this? We use dynamic lighting in Cocos2D-iPhone and it is just incredible!


Bundle in main does not have all the changes from the code base

Bug Description
The bundle folder is out of sync with the the code/files in other directories
Version and Command Invocation
main
Steps to Reproduce:

Run make bundle
See files change other then the ones intended to be changed

Expected Result
Except that the bundle folder in main has all of the previous changes applied to other files/code in the project
Actual Result
There were more changes present then should be
Additional Context
N/A

/assign


Dockerfile and shell wrappers for ease of use

Thanks for the great post and code. I had a bit of issues setting up my mac, so I created a dockerfile instead.

Thanks for this!


Save user when parting channels

Fixes channels persisting in the config even after leaving them.

👍
Minor bugfix: merging.


Inconsistency for string in query check between Record and Replay

If I use a database connection, I’m (expectedly) getting errors when a string variable is directly used in a query.
However a check through Replay without database connection ignores these issues.
This is a problem when PHPStan is checked on a CI server without database as firstly doesn’t check for this issue and secondly it doesn’t play well with PHPStans baseline feature: Creating a baseline with database connection puts the error into the baseline, which then makes CI fail, as it gives an error when the ignored error is not occurring.

Thanks for reporting.
In CI of this repo we ran recording and replay tasks (without a db connection) which shows errors are reported as expected.
Could you create a small repository which shows your exact problem, so we can investigate?

Sure! Made a minimal self contained repository at https://github.com/netzhuffle/phpstandba-replay-inconsistency.
Running with DB container up reports the string used in the query as expected.
Running with DB container down unexpectedly reports no errors.

Oh, wait, it’s the difference in the debugMode setting of course.
Got it!

feel free to report new issues in case you stumble over other problems or have further feedback


Variable |SUPPLY_LOCATION| not passed to Mailchimp

For the template "de/supply/supply_invitation" in MailChimp the variable |SUPPLY_LOCATION| is not populated.

All others are passed in fine:

c9d221a6286a42aedcc32a3738a104531f32309a might fix this issue. needs to be tested on staging.

@dottorer do not know how to verify this on staging - not sure how many emails I sent to how many people.

Will test soon, this is easy to verify in Staging.

Tested in Staging - works great now!


FirebaseApp.Create not override default instance

Please fill in the following fields:
Unity editor version: 2018.421f
Firebase Unity SDK version: 6.12.0
Source you installed the SDK : unitypackage
Firebase plugins in use : Auth FireStore
Additional SDKs you are using : Facebook AdMob VoxelBusters
Platform you are using the Unity editor on : Windows
Platform you are targeting : Android
Scripting Runtime : IL2CPP
Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
	FirebaseApp.LogLevel = Firebase.LogLevel.Verbose;
	var status  = await FirebaseApp.CheckAndFixDependenciesAsync();
	var main = FirebaseApp.Create(new AppOptions() {
		ProjectId = "{another}",
		StorageBucket = "{anotherBucket}"
	});

With the code above, the main.Options.ProjectId and DefaultInstance still being the ID from config.json. Is it a bug or is it intended?
Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?

Don't know

What's the issue repro rate? (eg 100%, 1/5 etc)

100%

The FirebaseApp.Create issue is expected behaviour. There is limited support in Firebase for multiple projects in a single application.
The main.Options.ProjectId being incorrect sounds like a bug. Can you elaborate a little more on what exactly you're seeing?
Ex: do you mean that you're literally typing:
var main = FirebaseApp.Create(new AppOptions() {
	ProjectId = "{another}",
	StorageBucket = "{anotherBucket}"
});

then main.Options.ProjectId is the id from the JSON. Or are you checking FirebaseApp.DefaultInstance.Options.Projectid?
If you can confirm the main.Options one being incorrect in one of the quickstarts, I can get it into our but list.

@patm1987 I don't have access to the project on weekend but if I not make any mistake, The option of the FirebaseApp I get from Create without specify a name, or even specify the DefaultName as a name on Create is exactly the same as DefaultInstance. Its like Create was check the dictionary and just return the instance of that name in dictionary
Yes, yesterday I was debugging and seem like main.Options.ProjectId is the id from the JSON

@patm1987  Now I can confirm that this code
var overridden = FirebaseApp.Create(new AppOptions() {
	ProjectId = another,
	ApiKey = apikey,
	AppId = appid,
});

Debug.LogFormat("overridden.Options.ProjectId : {0}",overridden.Options.ProjectId);

Will still print the id in config json, not the another key I put there, at least in editor, don't know this behaviour also the same in actual device
I suspect that FirebaseApp.Create will always return app that was already created with the specified name. And will not override the app that was already created by any new AppOptions. So the DefaultApp was always created first won't get replaced and will not returned

Hi all,
Thanks for following up.
I was able to successfully override the ProjectId in a secondary app I created.  Could you wrap the attempt to create the new app in a try / catch block to see if an exception is being thrown?  Thanks!

@DellaBitta There was no exception being thrown, it just return app instance normally but the AppID was not the same one I was specified

Ok, I've opened an internal bug to track this issue. Thank you!

I seem to have a similar issue. For one of our projects the creation fails and falls back to the default instance.

Hi folks,
I think you at least need to setup ApiKey, AppId and ProjectId. Unfortunately those fields does not default to the google-services.json or GoogleServices-Info.plist in your project.
https://firebase.google.com/docs/reference/unity/class/firebase/app-options
Can you confirm again and see if you still cannot create FirebaseApp that way?

@chkuang-g I still get the same result as I try to report
The point is, this is not only about first creation, its about multiple creation. The FirebaseApp.Create function cache the precede creation by name without creating new app if the name is not changed. Which I think it should not be expected for Create function
Here is how to reproduce. You need to have 2 project and let one be default from google-services.json and another one specified directly by AppOptions
var main0 = FirebaseApp.Create();

var main1 = FirebaseApp.Create(new AppOptions() {
	ProjectId = specificName,
	ApiKey = specificKey,
	AppId = specificID
});

Assert.That(main1.Options.ProjectId,Is.EqualTo(specificName));

The assert will be failed. The name would be from the first creation, instead of overriding the existing app

Hi @Thaina, I checked the implementation detail, and yes if we see the project name is same with the default name, we will use the default option that set in the json files. I'd like to get more context of the use case that we have the need of creating multiple projects with the same default name but different options, based on that we can discuss if we want to change this behavior.
Thanks!

@cynthiajoan In my case I try to switch the default firebase app in my app on the fly. I have firebase app for test and for production. And I have a button to switch it. But then the app was not be created for the specified project as intended
This should be consider a bug because when we try to create the app, it should be created with projectID as a unique key, or we might try to specified more data with new AppOptions. And for the current behaviour the name is misleading. It should be GetOrCreate instead of plain Create


Ignore missing dependencies

To fix issues with steps/workflows filtered by when.

Shouldn't the depending step bein reauired to have the same filter as well in which case it would not be an issue?

I still think this could be useful, maybe not in our pipeline but in general otherwise there might be cases where you could have to duplicate steps just to match conditions. Skipped steps imho should be treated as completed in DAG resolution


DatabaseClient.eval() always return true when the result is a boolean

When evaluating a piece of JavaScript on the server using DatabaseClient.eval() seems to always return true when the expression results in a single boolean.  Even when the result is false.
To reproduce:
require('marklogic')
    .createDatabaseClient({
        host:     'localhost',
        port:     '8000',
        database: 'neo-elec-content',
        user:     'admin',
        password: 'admin',
        authType: 'DIGEST'
    })
    .eval(`false;`)
    .result()
    .then(res => console.dir(res));

returns the following:
[ { format: 'text', datatype: 'boolean', value: true } ]

We would expect of course value to be false.  If you change the expression in the eval() to, say, '42;', then you get the correct result:
[ { format: 'text', datatype: 'integer', value: 42 } ]

I use the marklogic package version 2.9.0 (installed last week with npm i marklogic.)

Looks like this is where that response object is generated for boolean:
https://github.com/marklogic/node-client-api/blob/master/lib/server-exec.js#L75
and Boolean(data.content)would produce the correct boolean value if content is false
let data = {"content": false};
Boolean(data.content);

So, the issue is further upstream in how the data.content is produced from the results, and that looks like it is done in the marshal() function
https://github.com/marklogic/node-client-api/blob/ee49df1fa05bb29908f931b2f13bce69470c2567/lib/mlutil.js#L215
Looks like it may be the marshal() function https://github.com/marklogic/node-client-api/blob/ee49df1fa05bb29908f931b2f13bce69470c2567/lib/mlutil.js#L215
where boolean falls through to the return String(data) at the end.
I think it needs an extra if statement to handle boolean:
else if (typeof data == "boolean") {
  return data;
}

If that is the case, when making a fix for boolean, should ensure that we have full coverage for all primitive types (and figure out if/when we will be upgrading the MarkLogic V8 engine and can handle bigint )

This test to verify boolean only verifies true, which is why it was not discovered. It would be helpful to have tests for both true and false
https://github.com/marklogic/node-client-api/blob/master/test-basic/server-exec.js#L78

The fix for this issue will be available in the upcoming release.

Closing this since fix is now available in version 3.5.0. Thanks.!


Upload evaluation outputs and adapters

It would be great if you could provide the individual outputs when running the models on the test sets. Additionally, is it possible to provide links to all the model adapters used (currently the README only includes llama-13b).
Perhaps a GDrive or Zenodo link would work well.
This would enable quicker turn-around times when comparing different adapters. Thanks a lot for the work so far!

Thanks a lot!

@HZQ950419 can you upload the adapter weights too?


Refactoring SampledBoxMap

This is the update to using FLoops.jl. There are some breaking changes:

domain_points and image_points for SampledBoxMaps now return points within the box. The caller must ensure that this holds, eg by using the new convenience functions center(b::Box) and vertices(b::Box), also rescale(center, radius, points) which returns a generator that rescales points within [-1,1]^N to be within Box(center, radius). Constructors such as BoxMap, PointDiscretizedMap, AdaptiveBoxMap use these functions.
map_boxes now uses @floop. Every boxset.set must implement a SplittablesBase.halve method. The base julia Set has this, and methods for OrderedSet, BitSet will be added in the next PR through SplitOrderedCollections.jl
There is a temporary working TransferOperator for gpu boxmaps, but it is not very elegant or efficient. The "real" gpu TransferOperator method will be added in the next PR, which is the TransferOperator refactor.

Interesting construction. I wonder whether this might be useful for the TreePartition as well.


unnecessary comparation

https://github.com/oceanprotocol/market/blob/4dca7d3442bbba51d98195150b78314967094234/src/%40utils/aquarius.ts#L192
this could be if (!didList.length) return

https://github.com/oceanprotocol/market/blob/4dca7d3442bbba51d98195150b78314967094234/src/%40utils/aquarius.ts#L214
this could be if (!dtList.length) return

Hello @catalin8v! Thanks for opening this issue :) Considering you also have the solution here, can you please open a PR?
Thanks for your contributions! 🙏


Update the wiki to add socks

Currently, socks aren't on the wiki and I can't find how to upgrade them or if that's been implemented yet, pls update sanku

Thanks for reminding me that this repository has a wiki - I totally forgot this exists. You should be looking at https://guides.wispforest.io/things/trinkets/socks/ which has up-to-date information.
Our hosted guides are also just web-versions of the in-game guidebooks - in the case of Things this is the Things Almanac you can craft with a Book and an Apple
Cheers

Oh thank you! The modpack Im using doesn't add patchouli by default for some reason so I never ended up actually using the almanac, you should probably update the wiki link on the curse forge page to include the more updated wiki link


Create a change log for App Mining decisions

What is the problem you are seeing? Please describe.
App Miners are confused about changes to app reviewers. PBC has no good way to reference the canonical state/updates of app mining changes.
How is this problem misaligned with goals of app mining?
Just makes things slow and confusing.
What is the explicit recommendation you’re looking to propose?
Create a change log and when we reach new decisions log them there.
Describe your long term considerations in proposing this change. Please include the ways you can predict this recommendation could go wrong and possible ways mitigate.
N/A. This is just a procedure change to make communication easy.

Done. Here it is: https://github.com/blockstack/app-mining/blob/master/CHANGELOG.md


Use string.prototype.repeat over repeating.

Purpose of this pull request?

[ ] Documentation update
[ ] Bug fix
[ ] Enhancement
[x] Other, please explain: Remove dependency.

What changes did you make?
Use string.prototype.repeat over repeating.

Is there anything you'd like reviewers to focus on?
No.

Coverage decreases, but that's just because there are less lines.

Thanks!!


report a bug

Microsoft PowerToys version
0.75.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Peek
Steps to reproduce
When I use tool "peek" to preview the icon on my desktop it has a bug
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
Windows11 21h2 the lastest version

Hi,
which issue are you experiencing when you try to preview a file?
Does it only happen on Desktop?
/bugreport


keep Playwright versions up to date on every release

Dependabot was recently disabled due to the noise it generated when upgrading the dependency versions.Main reason for disabling was since we relied on the exact versions of Playwright. PW version bump itself would need to be mapped to exact versions and has to be tested with HB to ensure they are smooth and safe to be merged.

We can reenable dependabot to get notified for the PW releases and also open a PR, which we could work on and manually fix if failing tests to make it workable.

NOTE: We may also need to automate the HB testing along with this change as we would require extensive testing with HB images when upgrading PW versions

Add a pre publishing/release script that checks if the PW version is up to date and fail if we are behind.
In case of API breakage from the PW core, we should have the ability to forcefully release.

@vigneshshanmugam does https://github.com/elastic/synthetics/issues/781 suffice for now, should this be automation we look at in the future?

Haven't looked in to this one yet @paulb-elastic, But yeah 781 should do it for this release. But we need some automation around it as its easy to slip.


fix: Start loading spinner earlier in Drop-in Card Form

Description
CHKT-2292

This change starts the loading spinner slightly sooner when making a payment with the Drop-in card form and removes the delay experienced by the user.

Manual Testing
Make a card payment and observe the spinner starts immediately upon tapping the Pay button.
Contributor Checklist

[ ]  All status checks have passed prior to code review
[ ]  I have added unit tests to a reasonable level of coverage where suitable
[ ]  I have added UI tests to new user flows, if applicable
[ ]  I have manually tested newly added UX
[ ]  I have open a documentation PR, if applicable

Reviewer Checklist

[ ]  I have verified that a suitable set of automated tests has been added
[ ]  I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
[ ]  I have verified the documentation PR aligns with this PR, if applicable

Before Merging

[ ]  If introducing a breaking change, I have communicated it internally
[ ]  Any related documentation PRs are ready to merge

Other Stuff

You can find out more about our automation checks here
Find out more about conventional commits here

Upon investigating how the loading state is managed in the lifecycle of a payment, I opted to simply start the loaidng earlier to remove the delay.
You will notice that the "Pay $xx" text comes back just before progressing to the next screen. This is not a regression and would IMO require a greater overhaul of how the loading state is managed between pre tokenization->tokenization->payment flows - the generic nature of this setup is giving us a sub-par experience in this Card form flow.


Add .flex extension for lex files to package.json

fixes #24

Hi there, thank you for the PR and sorry for the super late response, have been busy IRL.


Potential performance issue: .to_dict method slow in pandas below 2.2

Problem Description
Hello.
I have discovered a performance degradation in the .to_dict function of pandas version 1.5.3.  And I noticed that some parts of the repository depend on the pandas version 1.5.3. I found that many files such as skrub/_table_vectorizer.py used the influenced api. There may be more files using the influenced api. I am not sure whether this performance problem in pandas will affect this repository. Here are some discussions on pandas GitHub related to this issue, including #50990 and #54824.
Feature Description
I would recommend considering an upgrade to a different version of pandas >= 2.2 or exploring other solutions to optimize the performance.
Any other workarounds or solutions would be greatly appreciated.
Thank you!
Alternative Solutions
No response
Additional Context
No response

hello, thanks for investigating and reporting this!
a lot of this code is likely to change due to (i) adding support for polars dataframes, #888 and (ii) refactoring the table vectorizer, #877.
in any case 1.5.3 is a rather old version, so users can always update their version of pandas and benefit from the fast to_dict in recent versions.
1.5.3 is the oldest supported version, but skrub works with more recent versions of pandas too (including the latest release). by default pip and conda will install the latest version

I think this can be close because if a user is experiencing bad performance due to this they can just upgrade their pandas version (If I understand correctly). But if I misunderstood or am missing something feel free to reopen, @TendouArisu


Enable public access end-to-end test

The ESS bug which prevented this test from passing has been resolved.

To enable public access end-to-end tests, this is all that's required: https://github.com/inrupt/solid-client-js/pull/1375
I think we should work with environments and the bits of code you're deleting which in my opinion make the tests more readable and eliminate boilerplate code enables that. I think we should have a discussion about that point before just deleting this code which works well.

I am open to discussing the way tests are setup, but I'd rather have the discussion first, and then introduce the changes. The code which was replaced has less functionalities than the code I introduced, as it only tests against one server, and if we agree to use the alternative you proposed, I'd rather have it implemented once for all end-to-end tests of the repo, and not on some of the tests but not all.
Note that the end-to-end test is failing in https://github.com/inrupt/solid-client-js/runs/4381303128?check_suite_focus=true: I initially did the same thing as https://github.com/inrupt/solid-client-js/pull/1375, realized things were not working, and tripped on the authentication because it was inconsistent with the rest of the tests, for which my local setup is configured. That's why I removed the setup files.

I think we'd be better using a testing matrix here, so we just have the tests use one environment by default, no .each, and then in CI we run against all servers

I think we'd be better using a testing matrix here, so we just have the tests use one environment by default, no .each, and then in CI we run against all servers

Further, we've currently 3 different sets of env variables used for tests:
# For ACP:
E2E_TEST_POD=
E2E_TEST_IDP=
E2E_TEST_CLIENT_ID=
E2E_TEST_CLIENT_SECRET=

# For E2E:
E2E_TEST_ESS_POD=
E2E_TEST_ESS_IDP_URL=
E2E_TEST_ESS_CLIENT_ID=
E2E_TEST_ESS_CLIENT_SECRET=

E2E_TEST_DEV_NEXT_POD=
E2E_TEST_DEV_NEXT_IDP_URL=
E2E_TEST_DEV_NEXT_CLIENT_ID=
E2E_TEST_DEV_NEXT_CLIENT_SECRET=

I would be very happy to refactor this to just one set, and then we can just run the node e2e on one environment for dev-next / CSS.

I would be very happy to refactor this to just one set, and then we can just run the node e2e on one environment for dev-next / CSS.

I think it's inevitable that if we're testing multiple environments we'll need multiple sets of credentials. That said, we don't need to run every version of node against every os against every server. We should run unit tests against each os and node version we support, and stable node + linux against each server for e2e testing.

OK, so for your consideration, I have enabled and used pretty succinctly and succesfully GitHub environments in this PR: https://github.com/inrupt/solid-client-js/pull/1375/files
See the result in this test run: https://github.com/inrupt/solid-client-js/runs/4401039688

Replaced with https://github.com/inrupt/solid-client-js/pull/1375


Update owners for flex adapter

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add more reviewers and approvers for flex driver
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Manually merged to deal with prow job chicken and egg


Document retrying HTTP requests / rake tasks

Sometimes these fail because Publishing API isn't fully ready at
the time of action. We've sometimes documented this gotcha in the
application repo, but it is better to centralise the documentation
here. See
https://github.com/alphagov/contacts-admin/pull/845#discussion_r583457007

I'm late to the party, but this looks good to me - thanks @ChrisBAshton !


Setting Model Repo Path

When setting the model repo path as indicated in the documentation as such:
LLMWareConfig().set_home(".\llm_models\")
And confirming that it has worked by:
LLMWareConfig().get_model_repo_path()
When using ModelCatalog().get_llm_toolkit() the models download to the correct location.
But when using ModelCatalog().load_model("llmware/bling-phi-3-gguf") they are loaded to the cache directory. (.cache\huggingface\hub)
Because I want to package a RAG / PySide6 application, I would like to load local gguf models from within the app directory structure.
How can I force model downloads to the set home path?
Thank you!

@JBatUN- thanks - this is a great question.   For GGUF models from HF, llmware pulls a snapshot of the HF model repo using the huggingface_hub api, and then places the gguf files in the llmware model repo path - and deletes the symlinks that HF puts there - and then the only place that .load_model will look is the llmware model repo path - so the .gguf file in the model repo path is what is getting loaded/executed.   However, HF manages its own records in the .cache path, and it does create a placeholder entry, even for GGUF models.   Try deleting that HF .cache entry - it should not effect the use of the model.    (Please note that the situation is different for Pytorch models, where llmware by default will use the HF .from_pretrained() - and the files will be kept in the HF .cache.   There are workarounds for this Pytorch model loading, but we have not built into llmware at this point).    Please let me know if this answers your question.


authhandler error

When I receive serverclient and send ClientFinish. Will receive failed nodes.
error:
Node[description=failure, attributes={reason=401, location=atn}]
mark:
I login with the key.

This is not an issue with the library, you simply can't login using those keys / they are wrong


Missing Issues

Hello,
Sometimes, in production (so without xdebug... since I first thought it was related to #244), I have errors that does'nt show in sentry.
However, I have my trace in laravel.log...
I don't know how to reproduce easily... But even if I refresh the error page multiple times, I have a different sentry error ID, but nothing on my sentry's backoffice.
I would say it is 10%-ish of the errors....
Here is an error number if it can help : 7c9b5648f71a478eb6bece088b4f1e18
I don't think the error is relevant here, but here it is just in case :

[2019-07-07 07:40:42] production.ERROR: SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 'toto' (SQL: select * from `tata` left join `toto` on .... left join `toto` on.... {"exception":"[object] (Illuminate\\Database\\QueryException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 'toto' ... at /opt/****/shared/vendor/laravel/framework/src/Illuminate/Database/Connection.php:664, Doctrine\\DBAL\\Driver\\PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 'toto' at /opt/****/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:63, PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1066 Not unique table/alias: 'toto' at /opt/****/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:61)
[stacktrace]
#0 /opt/****/shared/vendor/laravel/framework/src/Illuminate/Database/Connection.php(624): Illuminate\\Database\\Connection->runQueryCallback('select`...',
It is possible the request is getting too big for Sentry (assuming you are using sentry.io) and is being dropped (unfortunately silently otherwise we might get stuck in a loop).
There is currently an issue in the SDK with gzip not being enabled correctly causing some requests to fail. We are looking into that trying to improve the situation.
For now you could try and disable the sql_binding which should drop a considerable amount of data of the request. We're still trying to figure out the best way to make sure events never exceed the limit.

@stayallive Yes, I had sql_bindings ON. Just disabled it. I will update if I still got the issue despite that change.
Thanks a lot.

Hello @stayallive
Just got the issue with sql_bindings to false.
The error was not DB-related :  Route [contact] not defined.
Error ID: 53be6fc19d6a4e5b8d2bab304727166b  (sentry.io)

Sorry but now I am a bit confused... the error was not db related but without the bindings disabled it did show up in Sentry now?

Hello. No, some error still no show up in sentry. Got another one yesterday evening.
I have 'sql_bindings' => false,.

Just happened again :
[2019-08-13 11:15:33] production.ERROR: Call to a member function getDisplayName() on null

Error displayed to the user : 5b3f8ee7df1a4673984da038c1fa333a
But no alert, and bug not found on sentry.io
My sentry conf is still the same :
<?php

return array(
    'dsn' => env('SENTRY_LARAVEL_DSN'),

    // capture release as git sha
    //'release' => trim(exec('git log --pretty="%h" -n1 HEAD')),

    // Capture bindings on SQL queries
    'breadcrumbs' => [

        // Capture bindings on SQL queries logged in breadcrumbs
        'sql_bindings' => false,

    ],

);

We have done a lot in the past few weeks to hopefully fix this (in particular we now correctly compress requests so they are a lot smaller).
I would love to hear from you if 1.3 of the Laravel integration and 2.2 of the base SDK (automatically installed with the Laravel integration) works better now!

Hi,
I experience the same issue.
This happens if we use the integration via Log Channels as described here: https://docs.sentry.io/platforms/php/laravel/#log-channels
If we integrate sentry by modifying the \App\Exceptions\Handler as described here:
https://docs.sentry.io/platforms/php/laravel/#laravel-5x--6x
everything is sent to sentry.
Maybe this helps debugging.
Cheers,
Patrick

@patrickschmidt The log channel issue might be caused by the level configuration option defaulting to something higher causing some events to not be sent, not really sure, feel free to open up a issue if you feel like this is a bug with examples of issues sent/not sent when using log channels vs. the exception handler.
This is a pretty old issue and I have not heard back from anyone here that the problems are still there using the latest version of the SDK. I'm going to close this issue for now. Feel free to open up a new issue of the problem persists so we can restart the investigation.

just for info, i did not had this issue for a long time now.  So I think it is solved indeed :)

Happy to hear that @Nuranto and thanks for reporting back 👍
As mentioned, please do open up a new issue if there is any smell of a regression or missed issues (or any other unexpected behaviour)!


chore: add flake.nix to ease development for nix users

Why does this need to be included in Changesets?

This looks like a script to do general node setup of installing node, corepack, etc. to setup a development environment. It doesn't seem appropriate to me to add this type of PR to every open source project and would suggest it should be closed


[omada] automatic updates for Omada addon

Which addon?
Omada Controller
Describe the solution you'd like
Your Omada controller addon doesn't currently get automatically updated when the upstream docker image is updated.
It would be nice to get an updater.json file set up for your addon
Describe alternatives you've considered

manually creating an issue here when there's an update, or
manually updating from within the addon and hoping things don't break

Additional context
The upstream docker image for omada gets updated automatically when there's a new release, and it would be great if the HA addon also got those updates automatically :)

Hi, the updater.json is created, let's see how that goes

Nice!
I think there's still something a bit funky with the container image versioning... It has versioned tags, but the tags don't get updated for patch releases of the Omada Controller
e.g., let's say

TPLink releases a new version of the Omada Controller at 5.4.6
the github repo for the docker container is updated to download 5.4.6 when the container is created
a new Docker image is pushed to the already existing 5.4 tag

Is there any way for the updater to detect that the existing tag has a new hash and should be rebuilt?

Alas I need a place in github or dockerhub showing this versioning as a release... There is no way for me to infer the real version... I'll look at the hash idea

Should be good now! I've based it on the last update date instead of the hash to have something smaller in theory


2.3.0 version of snap fails to start

Describe the bug
Altair 2.3.0 fails to start
To Reproduce
run altair from the command line
Expected behavior
It should start
Desktop (please complete the following information):

OS: Ubuntu
Version 18.04.2

Additional context
After auto-updating to 2.3.0 altair failes to start, reverting to 2.2.2 allows it to start.
There is no command-line output and I didn't know where to look to find a log file.

Hey, sorry to hear that. Could you try opening the developer tools (likely with F12) on the app to check if you can see any errors? Or it doesn't even show the app at all?

@imolorhe The app does not show at all

I'm not sure what the problem could be. There is no way for me to test the snap version of the app to verify that it is working (I don't use a linux). Perhaps there is some linux dependency required in the new version? Most users have installed v2.3.0 of the snap, so I would wait to see if more people complain about the same thing. Otherwise it might be a specific issue for you, which I don't know how to solve. If you do find a solution, please comment about it here, incase someone else has the issue later.
Perhaps some of these issues are related and could help?
https://askubuntu.com/a/993844
https://github.com/snapcrafters/atom/issues/30

Not working on macOS Mojave 10.14.6 either.

Today this appeared:

The issue still exists in 2.3.1

@thewunder if you could help me debug, that would be awesome! I have no idea why it's not working in linux. I tested it in Mac though. Also the Linux electron tests passed. I upgraded the version of electron so that might have something to do with it.

So you see any errors in the console after you start the application successfully? Can you also use the application after it starts?

I get a warning on successful startup:
(node:6528) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Yes everything works in the application once it is started.
Here are the configs generated after starting the application:
altair_config.zip

Is this still an issue with the newer versions?

Yes, I happened to re-install kubuntu and it is an issue even a fresh install

How about installing altair using the bunary itself, instead of snap. Does it work then?

The Appimage works fine, just the snap has issues

It sounds like this is an issue for snap to handle then. I can't verify it and it doesn't seem to affect any other format. Perhaps you can create an issue on snap's repo?

You could also try deleting the application data for the app. ($XDG_CONFIG_HOME or ~/.config on Linux)


_NET_WORKAREA property not found

This crate is very cool!  I tried copying the Window Manager Info fn main() and got the error
WmCtl(PropertyNotFound("_NET_WORKAREA")).  This comes from the line
let wmctl = WmCtl::connect().unwrap();

I am able to run the Linux standard command wmctrl -l.

@DavidBJaffe which Linux Distro and Window Manager are you using?

This is Ubuntu 22.04.  It is running through Docker on a Mac, which is an admittedly weird use case.  How can I determine which window manager is in use?

I have a GUI app, and my actual goal was to put a button on the app to screen capture it.  That started by finding the window id.  However, it appears this won't work at all under Wayland, so I think I will abandon the project.

Some random idea: xprop -root. This should print all properties of the root window. On one hand this should show us what is up with _NET_WORKAREA. On the other hand, this might provide information about the window manager:
$ xprop -root | grep '"i3"'
_NET_WM_NAME(UTF8_STRING) = "i3"

Oh, hey, i3 actually reproduces the problem!
$ xprop -root _NET_WORKAREA
_NET_WORKAREA:  not found.
$ cargo run info
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/wmctl info`
 error: witcher::Error: property _NET_WORKAREA was not found
symbol: wmctl::init
    at: src/main.rs:214:9
symbol: wmctl::main
    at: src/main.rs:255:11
symbol: __libc_start_call_main
    at: ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
$ xtrace cargo run info
[...]
000:<:0056: 24: Request(20): GetProperty delete=false(0x00) window=0x00000769 property=0x1ac("_NET_WORKAREA") type=0x6("CARDINAL") long-offset=0x00000000 long-length=0xffffffff
000:>:0056:32: Reply to GetProperty: type=None(0x0) bytes-after=0x00000000

I'm trying to obtain the workspaces for i3, and it seems that they won't implement _NET_WORKAREA (as mentioned here: https://github.com/qtile/qtile/issues/847#issuecomment-172625433). Does this mean there's no way to execute WmCtl::connect() without having that variable set?

tiling window managers like i3 or qtile don't typically work well with the manual shape and placement features offered by wmctl as they control the placement of the windows very carefully for tiling. that said I went ahead and removed the dependency on "_NET_WORKAREA" and it will just fall back on the screen total size. This should allow compatibility with window manager's that have partial EWMH support.


Make Pages enablement (and write permissions) optional

Background
Currently, if I try to run this Action without the pages: write permission on my workflow, it will fail even if the Pages site has already been enabled.
I would love to only need to grant pages: read permission in workflows that I am confident should already have the Pages site enabled. 🤷🏻♂
Implementation Choices
This PR implements 2 different enhancements in this area:

It adds a new optional Action input called enablement that defaults to "true" but can be set to "false" to explicitly disallow the Action from attempting to create/enable the Pages site if it does not already exist

It alters the Action's internal flow in such a way that the 1-3 API calls are all consolidated into a single entrypoint so we can:

utilize them more efficiently, i.e. potentially avoid the need for the pages: write permission
extract the API calls out of the other local modules so that they only deal with model/domain objects, thus making their unit tests much simpler without the need to mock HTTP responses

Testing looked great. 👍🏻


[Revert][Build] Ubuntu 22.04 was not compatible with Python Client Wheel

Fixes #20725
Motivation
Building the Docker image of Pulsar 2.11 was broken due to an incompatible wheel file. The wheel made on the manylinuz apachepulsar/pulsar-build image is compatible with Ubuntu 20.04, but is not compatible with Ubuntu 22.04.
Modifications
Reverting the changes to use Ubuntu 22.04 in Dockerfiles back to Ubuntu 20.04.
Added some print.
Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

I remember that we don't release Python client for 2.11. Shall we try to drop those code for an easier-to-maintain base?
cc @merlimat @BewareMyPower

The wheel is installed from pip directly, with PULSAR_CLIENT_PYTHON_VERSION to specify the version. https://github.com/apache/pulsar/blob/c749872a72a0f74e8daf2ebd2669287c410809cb/docker/pulsar/scripts/install-pulsar-client.sh#L30
I don't think we need much efforts to maintain it.

Sorry I missed the fact that branch-2.11 still build code from source.
I think the issue is that when cherry-picking the original PR to branch-2.11, it didn't pin the Python client version to 3.2.0 so the build failed.

I think the issue is that when cherry-picking the original PR to branch-2.11, it didn't pin the Python client version to 3.2.0 so the build failed.

+1, we should cherry-pick this PR https://github.com/apache/pulsar/pull/20475 with changing the python client version to 3.2.0. Here is the root cause: https://github.com/apache/pulsar/pull/20475#issuecomment-1573529615
And there's a PR to fix it: https://github.com/apache/pulsar/pull/20770


linguist - Example App version:bump to v1.28.3

Backstage release v1.28.3 has been published, this Pull Request contains the changes to upgrade to this new release
Please review the changelog before approving, there may be manual changes needed to enable new features:

Changelog: v1.28.3
Upgrade Helper: From 1.27.6 to 1.28.3

Created by Version Bump<PHONE_NUMBER>

Closing as this was created while testing the version bump automation


[LinearSearch][Dart]

This issue is about [Algo/DS Name](link to resource for the Algo/DS).

[x ] Issue Title is in form Algo/DS Name [Language].
[x ] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x ] This Algo/DS is worth adding to this repository.
x[ ] Assign this issue to me (I want to work on this).

[ x] I ensure that I am not already assigned to 2 or more issues.

[ x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x ] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

@AkhileshManda GFI 👍.


fix server logs selection in diagnostics.zip

oldest logs were attached to the zip, woopsie daisy

I am not the smartest sometimes...


Add to build instructions that java 8 is required

What is the runtime is Java8 also required? Or can it run on the older java 7?
This was the pi component that had a failed build when I tried with java 7

The question here is what we would assume as a minimal JRE for the project. We can try Java8 - this is new stuff anyway. Any Raspberry Pi comes with Java 8 on Rasbpian out of the box.
What do you think?

Considering that Oracle ends its security updates for Java 7 this month [1], I'd say we go with Java 8.
[1] https://www.java.com/en/download/faq/java_7.xml

yeah sure fine with me being java8+

I guess we can use maven enforcer to require Java8 or higher ?

The enforcer plugin only forces the use of Java8 at build time, while our Java8 requirement is about runtime if I'm correct.

Yeah, but you can't enforce runtime usage. JRE will just throw the class loading error if Java < 8 is used. I have added the information about Java 8 requirement to the main page.

Just like you can't compile for java8 using anything other then JKD8... so what's the point of the enforcing plugin in this case? :)

the build fails early. This is important for the bigger projects :) .
nicer error messages :)

You're right, the nice and early error message is better then letting the compiler plugin discover that it can't compile the source files.


bugfix(RCController): opInformer add wrong eventHandler

i think opInformer add EventHandler  use persistOpWorker  instead of  persistPpWorker

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cloud Marker Windows seems not to open

when I start Cloud Marker the window doesn't open.
If I then try to start the plugin again, the message appears that the plugin is already started. I suspect the window is outside the visible area of my screen. Reinstalling and deleting the DB didn't work, Cloud Marker created a new DB but wont show up
What can I do?

Same problem here. I've reinstalled the plugin and it works once. Then, when I try to load it the next time, it remains minimized on the task bar, but blank. Great when it works. Frustrating.

I posted something on another post with the same problem, a strange workaround, but worked for me but has to be done each startup (I have just copied from my other answer) :

Hover over SDRUno Icon (When running) on the taskbar
Right click on the 'MARKERS' in the preview box, a context menu appears click on 'Move' (don't click any mouse buttons yet)
The mouse cursor moves to the top left of the screen with a move icon, I had to press the right arrow on the keyboard then without clicking mouse button drag the MARKERS window back into the centre on the desktop.
You should be able to now drag it to another position.
I am not sure why it exhibits this behaviour but I have to do this most times after launching SDRUno and trying to load the Markers plugin, but it works for me.

I hope this helps others, I haven't been able to figure out why it does this.


jax tutorial 5: cannot run on GPU (due to clash with pytorch RNG)

Tutorial: -1 (Fill-in number of tutorial)
https://uvadlc-notebooks.readthedocs.io/en/latest/tutorial_notebooks/JAX/tutorial5/Inception_ResNet_DenseNet.html
Describe the bug
Same issue as in https://github.com/phlippe/uvadlc_notebooks/issues/83.
However it crops right at the start - merely importing pytorch causes issues.
See screenshot below
Can be fixed by moving
# Seeding for random operations
main_rng = random.PRNGKey(42)

before importing pytorch.

Here is a minimal colab to reproduce the core problem.
https://colab.research.google.com/drive/1gGDAGotSA0aJ9Nd1ilV9_xWBy6uFvVkU?usp=sharing

Closing the issue for being fixed in efbc9de8a08857f1d074d1063c8c3c861475eea4 and discussion continues in #83


Codecov still not showing up in PRs

Since migrating to workflows, we've had no coverage reports in pull requests. Not sure what's up with that,

Should be fixed now.


added basic ubuntu setup instructions, was tested on 14.04

and when I say tested, I mean that it is an edited copy of my bash history

The Dockerfile already contains all the instructions to setup an Ubuntu machine with storyplayer.

Hi Ron,
Thanks for these. I'll spin up a VM tonight to test them and polish them :)
Best regards,
Stu


How do I get a type from schema/validator?

Hey, a friend just shared this library with me. It looks pretty cool, and the benchmarks seem impressive :)
Reading the README I'm not sure how do I extract a type from validator?
Looking at the examples, I'd guess that this is possible, but it seems to be missing from the README. (I'm sorry if it's there and I missed it)
type Person = FromSchema<typeof personSchema>

Hi, to receive the type of schema you do something like this:
import type { TypeOf } from "@typeofweb/schema"

const personSchema = object({...})

type Person = TypeOf<typeof personSchema>

Hi, to receive the type of schema you do something like this:
import type { TypeOf } from "@typeofweb/schema"

const personSchema = object({...})

type Person = TypeOf<typeof personSchema>

https://github.com/typeofweb/schema/issues/33 Opened to fill the docs with information on TypeOf and other type helpers

https://github.com/typeofweb/schema/issues/33 Opened to fill the docs with information on TypeOf and other type helpers

Thanks

Thanks

The missing docs are now added here: https://typeofweb-schema.vercel.app/

The missing docs are now added here: https://typeofweb-schema.vercel.app/


Responses List bugs for duplicate schemas with different codes

If you reference the same schema but have different status codes (we have a 200 and a 201 that share a response body), weird things happen.  Clicking on the zippy for whichever status code wasn't last in the spec causes it to change to the other code, then expand on the next click.
Problem code appears to be https://github.com/Rebilly/ReDoc/blob/master/lib/components/ResponsesList/responses-list.ts#L45
The returned resp is shared by all the responses and so the last one out will do the final write to status code and boom :(
It seems like a simple clone with
Object.assign({}, this.specMgr.byPointer(resp.$ref));
was enough to fix my issue but haven't really tested or dug around in the code to see if there's a better way.

@theindexer thanks! simple clone was good solution.
I've already fixed it and added a testcase.
New version release is planned for tomorrow.

New version 1.7.0 has been released

Sweet, thanks!


The learning rate detected in the optimizer is not a Parameter type, so it is not recorded. Its type is '_IteratorLearningRate'.

Hello author, when I was using SummaryCollector for visualization, I encountered the following error:
The learning rate detected in the optimizer is not a Parameter type, so it is not recorded It type is'InteratorLearningRate '.
May I ask what is causing this?

@TanateT
Hello, thanks for your feedback.
It seems that the problem was caused by an improper definition of the learning rate.
You can try to debug the code on PyNative mode and to check the data type of the learning rate input to the optimizer.
If you need further help, please provide more details on your code.

@panshaowu ,
Hello,When I use the following code to train the icdar_15 dataset using CRNN and SVTR, and use 'summary=SummaryCollector (summarid_dir='summary', collect_freq=100) ', the above error will appear. You can try it on the GPU.

@TanateT Hello, I tried to modify the python script tools/train.py (refer to Tutorials):
def main(cfg):
    ....
    # training
    model = ms.Model(train_net)
    summary_collector = SummaryCollector(summary_dir='summary_dir', collect_freq=100)
    model.train(
        cfg.scheduler.num_epochs,
        loader_train,
        callbacks=[eval_cb, summary_collector],
        dataset_sink_mode=cfg.train.dataset_sink_mode,
        initial_epoch=start_epoch,
    )

And then I tested the function of SummaryCollector on a GPU server (1080Ti, CUDA 10.1) using following commands:
clear && python tools/train.py -c configs/rec/crnn/crnn_icdar15.yaml

No errors were raised. And SummaryCollector worked normally.  I could see the captured training info using MindInsight.
I am not sure whether you added more customized codes.
Could you please provide more details?


added modulecalls

Signed-off-by: Heiko Neblung<EMAIL_ADDRESS>
Description of your changes
Added support for modulecalls.

Fixes #9
I have:

[x] Read and followed terraform-docs' contribution process.
[x] All tests pass when I run make test.

How has this code been tested

I've implemented your suggested changes. I will update #367 to match the changes here.


tx hash in send message

Hello
How can I access the transaction hash created by the send message function?

@shirani98, Hello!
Unfortunately, the send message function does not provide access to the transaction hash. Having studied the API documentation (/v2/blockchain/message), it becomes clear that this method does not return any data. You need to come up with alternative methods or approaches to obtain the transaction hash.

Hello How can I access the transaction hash created by the send message function?

use this api
https://toncenter.com/api/v2/#/send/send_boc_return_hash_sendBocReturnHash_post


Extension issue

Issue Type: Bug
Extension Name: vsliveshare
Extension Version: 1.0.3968
OS Version: Windows_NT x64 10.0.19042
VSCode version: 1.54.3

:warning: We have written the needed data into your clipboard. Please paste! :warning:

Hey @samdruster, thanks for reaching out to Live Share! Can you please describe the issue you're facing and attach the logs? You can access your logs by going to > Live Share: Export Logs in the command palette.

Closing due to inactivity.


add general required qualifications to eventtype

closes #588

Coverage: 87.459% (+0.07%) from 87.392% when pulling 7bb494902db327fa79c56aa3a3713b42343015b8 on general-required-qualification into 7bb54bfa4bf0d1a4e2ab9b63034bcfb0dd4c4c90 on main.


updates async test to skip if SSL not installed

Pull Request check-list
Please make sure to review and check all of these items:

[X] Do tests and lints pass with this change?
[ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[X] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Creates parity in testing on the sync/async tests of the connection pool by skipping the ssl tests if ssl is not installed on the async tests.
Resolves #26

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@01db8ba). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   61.30%
=======================================
  Files           ?      132
  Lines           ?    34352
  Branches        ?        0
=======================================
  Hits            ?    21058
  Misses          ?    13294
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi Jay!
There are some commits in this branch that shouldn't be here.
I suggest you to run:
git fetch
git rebase -i origin/main

and delete all commits except 53cd1db764de5a7b9f42a5cbddd6bc2dbe7d3c5d
then force-push

Created new PR #36


Add "pro-tip" column

We occasionally have "pro-tips" from editorial practices that will be useful for internet searches, e.g.

How to move the content of an ISO Example block to the next line (https://github.com/metanorma/iso-6709/issues/17#issuecomment-1141575621).

I suggest we add a "pro-tip" section that lists them.

Wherever ZWNJ () is listed as a way of preventing Asciidoctor applying regexes, that too is a pro-tip.
Can I ask that the editors do the pro-tips instead of me?

Of course, @metanorma/editors can you please help gather the previous pro-tips and collect them here? Thanks!

Currently, there are two sections in metanorma.org dedicated to list these "pro-tips": Metanorma AsciiDoc tips and Edition tips.

Wherever ZWNJ () is listed as a way of preventing Asciidoctor applying regexes, that too is a pro-tip.

The first section already covers the use of  to handle particular markup escaping.
@ronaldtse, perhaps the existence of these two sections already covers the requirement of this task. Can I close?


Tracking weather alerts

Is there provision in the SDK to track weather alerts too?

There are provisions for tracking active weather alerts.  I am trying to figure out how it works right now.
This what I did
from noaa_sdk import noaa
n=noaa.NOAA
alerts = n.active_alerts()
This showed all the active alerts, I am trying to figure out how to filter them using the sdk.


Update Battlefield V

Game Title
Battlefield™ V
Status of the Anti-Cheat
🚫 Denied
Tinkering Steps
The game will no longer work on Linux/Steam Deck due to EA AntiCheat being implemented on April 3rd
Proof of Mention
https://steamcommunity.com/app/1238810/discussions/0/4355617246781704749/

This is such a shame


Small code refactoring

What does this PR do?

Added more unit tests
Moved exceptions to their own module
Added pytest conftest module

Motivation
Cover with tests a piece of code I want to refactor in an upcoming PR
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
No functional changes were made, no need to alter the changelog

Codecov Report

Merging #2120 into master will decrease coverage by 21.25%.
The diff coverage is 100%.


RHost MAKEFILE to build for windows

We should look into some sensible build system here rather than raw Makefiles, which are pretty painful. Some popular candidates include CMake, QMake and Jam.

Agreed

How does it relate to MB Linux build support


Cython compile time conditional statements are deprecated

https://github.com/cython/cython/issues/4310

https://github.com/cython/cython/issues/4310#issuecomment-1245862843

The current situation is something like "Cython core developers don't like this feature and would like to replace it with a better alternative". It's a statement of intent rather than immediate action. The main consequence right now is that we aren't interesting in proposals extend the current conditional complication feature. ... We'll make sure that suitable warnings appear in Cython well before anything removes, and that the alternatives are well-documented. Until then I'd wait (especially with respect to existing code).

Thanks for those links. So I think the conclusion is that for now, we can just leave things as they are, and when moving to cython 3, we can probably switch to use a lightweight templating (to include the GDAL-version specific things) at that point.


Unable to pass strings/text properly to String Function

I'm trying to setup some nodes to do a dynamic string/text replacement, however, I'm running into what I think is maybe an escaping issue:
here's is the default/working use case:

However if I pass in the text for text_c, the behavior changes.

Any help on this would be appreciated!

I'm not able to recreate this issue using primitive nodes, it may be another extension doing something?

ya, might be the CR node. I'll use a primitive node.


DevOps - Create Manifest (52)

Add Manifest.json file to the root of all CVS Functional Repositories

Abandoned by Workflow


Stateless: JWT Authentication Client Middleware

For stateless applications using JWT authorization, let’s add a middleware that inserts the Authorization: Bearer header.
Example:
export class JwtAuthorizationMiddleware implements MiddlewareClass {
  constructor(private getToken: () => Promise<string|undefined>) {
  }

  async invoke(context: MiddlewareContext, next: MiddlewareNext) {
    const token = await this.getToken();
    if (token) {
      context.request.headers.append(
        'Authorization',
        `Bearer ${token}`
      );
    }

    return next(context);
  }
}

Closing as irrelevant, as we went with the cookie-based stateless authentication, the dedicated middleware is not needed.


fix: use new secretInjectionConfigs keyMappings field in resource docs

Description of your changes
The example for DisposableRequest in the resource-docs still uses the deprecated secretKey and responsePath fields of SecretInjectionConfigs. This PR updates the docs to make it more in line with the examples in the examples folder.
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
N/A

Good catch! I've just added the sign-off :)


Add Store stats

[ ] Key Count
[ ] Directory Count
[ ] TTL Key Count

Where should we add this? Are we going to put it into the metrics endpoint? So something like:
etcdstore_v2_key_count
etcdstore_v2_dir_count
etcdstore_v2_ttl_key_count

We also have the /v2/stats/store endpoint but that has counters on operations at the moment.

This is for v3 api. see the label.

@xiang90 I added a v3api label, the release milestone just says when we plan to make it happen.

@xiang90 Is the plan to add it to the metrics endpoint though?

@philips Yes we plan to.

@xiang90 then why is this part of the v3api?

@philips This is a separate problem. What I am saying is this issue was for v3, not for v2 api from the very beginning.
If we want to add more stats into v2 stats, we need to create another issue for that.

@xiang90 so this will be a v3/stats endpoint? This issue just doesn't have enough information for someone to know what it is about.

/cc @spacejam I think you might be interested in this one.


Add support for dynamically adding properties on 10.7 and later

I indeed have a use-case :)
I have a dependency-injection library that reads @properties to determine dependancies. I'd like for it to work with Nu, with otherwise lacks any support for declaring properties.

Nifty. Thanks again for the patch, much appreciated. It's great to see people making use of this code.


Artifacts cannot find the build folder

Artifact upload cannot find the build folder, probably i doing some wrong but i don't found the error

name: Actions 😎

on: [push]

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

jobs:
  build:
    name: Build my project ✨
    runs-on: ubuntu-20.04
    strategy:
      fail-fast: false
      matrix:
        buildName:
          - testCi
        projectPath:
          - NewUnityProject
        unityVersion:
          - 2020.2.6f1
        targetPlatform:
#          - StandaloneOSX # Build a macOS standalone (Intel 64-bit).
          - StandaloneWindows64 # Build a Windows 64-bit standalone.
#          - StandaloneLinux64 # Build a Linux 64-bit standalone.
#          - iOS # Build an iOS player.
#          - Android # Build an Android player.
#          - WebGL # WebGL.
    steps:
      # Checkout
      - name: Checkout repository
        uses: actions/checkout@v2
        with:
          lfs: true

      # Cache
      - uses: actions/cache@v2
        with:
          path: ${{ github.workspace }}/${{ matrix.projectPath }}/Library
          key: Library-${{ matrix.projectPath }}-${{ matrix.targetPlatform }}
          restore-keys: |
            Library-${{ matrix.projectPath }}-
            Library-
      # Build
      - name: Build project
        id: myBuildStep
        uses: game-ci/unity-builder@v2
        with:
          buildsPath: ${{ github.workspace }}/Builds/
          unityVersion: ${{ matrix.unityVersion }}
          targetPlatform: ${{ matrix.targetPlatform }}

      # Output
      - uses: actions/upload-artifact@v2
        with:
          name: Build-${{ matrix.targetPlatform }}
          path: ${{ github.workspace }}/Builds/${{ matrix.targetPlatform }}

Not sure why you're adding the github workspace in buildPath and in upload-artifact path.
Recommend simplifying. See https://game.ci/docs/github/builder#complete-example.

Not sure why you're adding the github workspace in buildPath and in upload-artifact path.
Recommend simplifying. See https://game.ci/docs/github/builder#complete-example.

I'm using github workspace to go to the root of the repository, I tried to use it as it was in the documentation but it gave the same error

If you search for customBuildPath in your logs, does it match '/home/runner/work/testCi/testCi/Builds/StandaloneWindows64'?

I didn't find custom Build Path but the i found this path

Could you remove the trailing slash in your workflow:
        with:
-         buildsPath: ${{ github.workspace }}/Builds/
+         buildsPath: Builds

and in the upload part:
      # Output
      - uses: actions/upload-artifact@v2
        with:
          name: Build-${{ matrix.targetPlatform }}
-         path: ${{ github.workspace }}/Builds/${{ matrix.targetPlatform }}
+         path: Builds/${{ matrix.targetPlatform }}

It should work.

Same thing, could not find the folder. I left the public repository now it could be that I'm taking the folder the wrong way

Looks like you also forgot to set https://game.ci/docs/github/builder#projectpath
Which is important because your project is not in the root of your repository.

even with  project path, I couldn't get it to work

# Build
      - name: Build project
        id: myBuildStep
        uses: game-ci/unity-builder@v2
        with:
          projectPath: ${{ matrix.projectPath }}
          unityVersion: ${{ matrix.unityVersion }}
          targetPlatform: ${{ matrix.targetPlatform }}

      # Output
      - uses: actions/upload-artifact@v2
        with:
          name: Build-${{ matrix.targetPlatform }}
          path: builds/${{ matrix.targetPlatform }}

For some reason I can not see the output of your workflow as I see only this (see screenshot).

The screenshot that you're showing only says that it has created an empty directory to put your builds in.
The second screenshot shows the changes, but not the ones I was suggesting. ( you have a mismatch, because the default folder is not builds but build.

Please note that there are already hundreds of projects using our actions successfully, and there is not likely to be a bug in this basic functionality. (so far we have not seen evidence of anything not working).
I would recommend taking some initiative for your troubleshooting efforts at this point.


Make possible to install several apps on the device (testnet,mainnet).

Install "mainnet" and "testnet" apps to the device at the same time.

checked


Enhance get_route_to

Two proposed additions:

arg vrf
next_hop_type key inside the output dict

Remind me, what is next_hop_type?

As the name states, it is the type of the next hop. E.g. NULL routes have the next hop type "discard". Also, the type of the next hop can be an interface etc.

To me it seems we are encoding arbitrary information but maybe I am misunderstanding it.

NULL routes have the next hop type "discard"

Examples from different platforms?

the type of the next hop can be an interface

Is the type "interface" or an interface? If it's the latter this is clearly the wrong construct. "Ethernet1" is not a type, it's an interface.
To me it seems more natural to have next_hop_interface and next_hop. So I can do:
# discard route
next_hop_interface: null
next_hop: None

# regular route with no interface
next_hop_interface: None
next_hop: <IP_ADDRESS>

# next_hop and interface
next_hop_interface: "et1"
next_hop: <IP_ADDRESS>

Indeed, having more specific names rather than a generic next_hop_type would be more intuitive.
Let me think a bit about other types of fields, so if we are applying this API change right now we can introduce few more fields that have explicit next_hop_<type>: <name of the next hope type>.
But how would you represent: next_hop_interface: null vs. next_hop_interface: None and distinguish between them?
Perhaps having a field like null_route: True better, or something similar?

I don't think having a field null_route is necessary as that's a use case of a particular configuration.

But how would you represent: next_hop_interface: null vs. next_hop_interface: None and distinguish between them?

Sorry, the "data" on my previous comment had a "bug". null is not really an object but the string "null".

I recently got a similar use case so circirling back on this one. I mean for junos it's fine we can use key to filter table name if we want specific vrf. But for ios it seems we don't even have this api imported. Any reason? Also for ios, we most use vrf kw or we won't get table in specific vrf. adding @ktbyers to further comment.

Sorry, I dropped the ball here, I will try to revisit this issue during the week of 17th.

But for ios it seems we don't even have this api imported. Any reason?

Yes, the reasoning is that nobody submitted any code to add this method. I know you have the skills required, so please go ahead and provide an implementation, if you're willing to @sincerywaing :-)

I guess the difficult part for ios is that you need parse everything!@mirceaulinic I'll start looking into this :)

I spent some time looking into this and found it is really complicated to list every attribute for ios -
e.g. no interface shown here
Routing Table: test
Routing entry for <IP_ADDRESS>/28
  Known via "bgp 65777", distance 20, metric 0
  Tag 65777, type external
  Redistributing via ospf 20
  Advertised by ospf 20 metric-type 1 subnets route-map foh-bgp-to-ospf
  Last update from <IP_ADDRESS> 13:23:13 ago
  Routing Descriptor Blocks:
  * <IP_ADDRESS>, from <IP_ADDRESS>, 13:23:13 ago
      Route metric is 0, traffic share count is 1
      AS Hops 2
      Route tag 65777
      MPLS label: none

I can use a very simple way to put protocol, next hop, metric, distance here:
re_dict = {'protocol': r'Known\svia\s\"(.+?)\"', 'metric': r'metric\s(\d+)', 'distance': r'distance\s(\d+)', 'next_hop':  r'(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})\,\sfrom\s(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})', 'age': r'([\w:]+)\sago', 'routing_table': r'Routing\sTable\:\s([\w:]+)'}
for k, v in re_dict.iteritems():
     pat = re.compile(v)
     re_dict[k] = pat.search(s1).group(1).split(' ')[0]

print re_dict
{'distance': '20', 'metric': '0', 'next_hop': '<IP_ADDRESS>', 'protocol': 'bgp', 'age': '13:23:13', 'routing_table': 'test'}

        * protocol (string) - Supported
        * current_active (True/False) - N/A
        * last_active (True/False)  - N/A
        * age (int) - supported (**string**)
        * next_hop (string) - supported
        * outgoing_interface (string) - N/A, not displayed here but displayed in below show .
        * selected_next_hop (True/False) - N/A
        * preference (int) - N/A
        * inactive_reason (string) - N/A
        * routing_table (string) - Supported
        * protocol_attributes (dictionary) - N/A

However when there is load balancing and interface, from same device but different protocol
Routing Table: test
Routing entry for <IP_ADDRESS>/28
  Known via "ospf 10", distance 110, metric 0, type extern 2, forward metric 10
  Redistributing via bgp 65777
  Advertised by bgp 65666 route-map ospf-to-bgp
  Last update from <IP_ADDRESS> on TenGigabitEthernet1/0/0.405, 7w0d ago
  Routing Descriptor Blocks:
  * <IP_ADDRESS>, from <IP_ADDRESS>, 7w0d ago, via TenGigabitEthernet1/0/0.405
      Route metric is 0, traffic share count is 1
    <IP_ADDRESS>, from <IP_ADDRESS>, 7w0d ago, via TenGigabitEthernet1/0/0.405
      Route metric is 0, traffic share count is 1

{'distance': '110', 'metric': '0', 'next_hop': '<IP_ADDRESS>', 'protocol': 'ospf', 'age': '7w0d', 'routing_table': 'test'}

only the current best * one is selected, or next_hop would be a list
age is with the last updated one

so a better implementation would be separate the output to two parts -
Part I start from beginning to 'last update' to parse protocol, distance, metric, routing_table;
Part II strat from 'Routing descriptor blocks' to the end to return a list of dict including next_hop, age and protocol_spec arguments.
Thoughts?

@mirceaulinic what's your take on this? I think doing backwards compatible changes like the one you suggested is fine but I don't think we should do backwards incompatible changes as @sincerywaing is suggesting.
I am not suggesting his changes don't make sense (which they might) but I think that if we are planning to make backwards incompatible changes we should:

Use a model from the openconfig or the ietf communities, not something designed by us. Unless the openconfig/ietf fails to deliver on time, of course.
Use napalm-yang instead of a getter.

Use a model from the openconfig or the ietf communities, not something designed by us.

This is a sound idea, but I wasn't able to identify if there's any model available yet for the routes state. But sure, that's the long term solid solution.
For the short term, give that the method already exists, and @sincerywaing's question is specifically about IOS, we can implement this one easily.
I have two comments: we should fill in the fields as much as possible. If the information is not exposed at all by the device, that field will be empty (depending on the case, e.g. empty string for int, 0 or -1 for int etc.). This is also the case with EOS where, IIRC, there are two empty fields.
Some fields can be returned though:

current_active (True/False) - N/A

This information is available -- the * tells you that.

outgoing_interface (string) - N/A, not displayed here but displayed in below show .

No problem: as long as the device is able to give you this information, we can execute another request to retrieve this data.

protocol_attributes (dictionary) - N/A

This is another request, depending on the protocol.
Thoughts?

Ok, somehow I misunderstood @sincerywaing and I thought he was suggesting changing the current model.


affected/package: reflect

What version of Go are you using (go version)?

$ go version
go version go1.20 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
I'm comparing two maps with identical contents but different type aliases using reflect.DeepEqual.
Repro: https://go.dev/play/p/O_XKF0qJNfV
What did you expect to see?
I expected reflect.DeepEqual to return true. Quote from the reflect.DeepEqual doc:

Map values are deeply equal when all of the following are true: they are both nil or both non-nil, they have the same length, and either they are the same map object or their corresponding keys (matched using Go equality) map to deeply equal values.

So they are both not nil, have the same length, keys and values. Therefore the function must return true.
What did you see instead?
reflect.DeepEqual returns false

Actually I'm sorry. I take it back. The doc also says:

Values of distinct types are never deeply equal.


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-06-06T02:19:44+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
446a14bafac02a371b4defde9150bebee040c711
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote


Suggest vim syntax support in README

Love this plugin, can't live without it. Can't live without vim. This is what I've been using for a year or two.

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   87.14%   87.14%
=======================================
  Files          21       21
  Lines         459      459
  Branches      112      112
=======================================
  Hits          400      400
  Misses         53       53
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb224b...dfa7c2c. Read the comment docs.


pulling updates

This change just broke our Nginx configuration. /var/www was owned by root and /var/www/webroot by nginx. Now, the still somewhat running app (using the nginx user) cannot write files anymore.

@fnordfish do you use my fork? the master repo is located here https://github.com/jelastic-jps/lets-encrypt/

Sorry, just realized this was a fork. Not 100% sure how I ended up here. Anyhow, this got merged, wasn’t it?
The chown -R apache:apache /var/www matches exactly what we’re facing after just updating our certs :(

Never mind, I’ll open a ticket upstream. Sorry for the spam

@fnordfish I'm testing improvement, and push updates to the upstream time-to-time. But it's better to have a discussion at the upstream. I can't find your issue here https://github.com/jelastic-jps/lets-encrypt/issues. Is it related to jelastic add-on?

Just opened an issue at jelastic-jps/lets-encrypt#25


Incorrect handling of Array data in String.from_array

Here is a sample program:
actor Main
  new create(env: Env) =>
    let that_array: Array[U8] val = recover ['1', 0] end
    let s = String.from_array(that_array)
    try
      s.u64()
      env.out.print("ok")
    else
      env.out.print("error")
    end

You would expect this to print "OK" but it doesn't because of a bug in size handling in String.from_array. In the block that handles null terminated arrays, it should set size to size - 1 before exiting as the last element is a null terminator and pony doesn't count that as part of string length.
Note that fixing this bug results in a test elsewhere that fails and worries me some.
crypto/ConstantTimeCompare
class iso _TestConstantTimeCompare is UnitTest
  fun name(): String => "crypto/ConstantTimeCompare"

  fun apply(h: TestHelper) =>
    let s1 = "12345"
    let s2 = "54321"
    let s3 = "123456"
    let s4 = "1234"
    let s5 = recover val [U8(0), U8(0), U8(0), U8(0), U8(0)] end
    let s6 = String.from_array(recover [U8(0), U8(0), U8(0), U8(0), U8(0)] end)
    let s7 = ""
    h.assert_true(ConstantTimeCompare(s1, s1))
    h.assert_false(ConstantTimeCompare(s1, s2))
    h.assert_false(ConstantTimeCompare(s1, s3))
    h.assert_false(ConstantTimeCompare(s1, s4))
    h.assert_false(ConstantTimeCompare(s1, s5))
    h.assert_true(ConstantTimeCompare(s5, s6))
    h.assert_false(ConstantTimeCompare(s1, s6))
    h.assert_false(ConstantTimeCompare(s1, s7))

@SeanTAllen The problem should be solved by s5 having an extra U8(0) for the null terminator created by String.from_array

@Theodus agreed. BUT... I want to bring it up for discussion because maybe I'm missing something. I don't think I am, but I might be.

I believe this would be correct:
https://github.com/Sendence/ponyc/commit/4ead6e06bd3f1e0fa24cb2df29ebb984307a8169

I think much of the String package likely needs a review. Looking at some of the methods, I see conditions that are _size < _alloc, which should always be true, since _alloc should always be at least _size + 1.
The compact() method is one such example, that can be demonstrated with the following example:
actor Main
  new create(env: Env) =>
    let s = recover String(1000) end

    env.out.print(s.size().string() + " " + s.space().string())
    s.compact()
    env.out.print(s.size().string() + " " + s.space().string())

The output shows:

0 1000
0<PHONE_NUMBER>3709551615

@Perelandric Looks like I forgot about the null terminator when I implemented compact, sorry for that. I'll fix it.

@Praetonus No problem at all. Didn't mean to do any finger pointing. Mostly was just saying that it may not be a bad idea to go over some of these methods. I was about to do a fix for compact(), but if you're on it, I'll let you handle it, and I'll look around for anything else that stands out.

@jemc thoughts on this in light of the trim PR? append and from_array do very weird and different things with null terminators. from_array is currently broken but changing it would make it act different than append.

@SeanTAllen - in light of the trim PR, I'd suggest making from_array and append not do any null-terminator adding.  That is, since strings now have the possibility of not being null-terminated, and there are recommended methods for using in all FFI calls that require null-terminated strings, I think we can make these two methods work in a more straightforward way by ditching the adding of an extra null byte on the end.

Closing. This is no longer relevant due to from_array changes.

@SeanTAllen It seems like something needs to change, even if just the docs.
Currently if you pass an Array[U8] with the 0 byte as the last member, you get back a string that includes that 0 byte at the end. If that's the intended behavior, then it seems like either:

the docs should be updated to no longer suggest that the string will use the 0 as the null terminator.
the trailing 0 should have no meaning and the code should be updated to skip the 0 test.

Unless I'm missing something?

The 0 should have no special meaning. Can you update accordingly @Perelandric ?

Yes, I'll do a pull shortly.


Apps return 403 instead of 5xx errors when revision not available

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When an app has no active revisions, for example when it has been deactivated by az containerapp revision deactivate, going to its public endpoint returns HTTP 403 error, which is a Client Error meant for applications, and it becomes very confusing when trying to debug an app since it's not immediately obvious if the error is being generated by an App that failed deployment or by an application running on that App. The orchestration layers are clearly part of the "server architecture", and should thus return 5xx Server Errors, not Client Errors.
Steps to reproduce

Create an App with public ingress
Deactivate all revisions
Try to access the public endpoint

Expected behavior [What you expected to happen.]
The App should return a 5xx Error, like 502, 503, or even 501
Actual behavior [What actually happened.]
The App returns 403 Error, which makes absolutely no sense and makes debugging harder.

Thank you for reporting it. We will investigate.

Is there any update on this, we also encountered this issue

We are trying to return 5xx only if it's coming from the app and not the platform. We will change it to 404 which is more suitable.

Same issue. Following

We also observe this 403 errors. 403 makes absolutely no sense. I would also expect 5xx. This unexpected behaviour leads to logouts in our apps which are using the container app hosted backend. That means we have a lot of unnecessary logins after the backend is recovered.


Visual Overhaul?

The visual effects do leave things to be desired, the mechanics are well and good, but simple particle effects from base minecraft can be unattractive for those used to modded effects, so maybe some more flashiness would be a welcome addition to this mod, and make it have the same attraction as things like ars nouveau. just a suggestion

I will be doing this, but it is not a priority, as I'm still trying to finish much of the base mod.
Thank you for the suggestion!

The latest update adds new particles, some new renderers / models, and some other polish like sound effects. I'll close this issue when it is merged into main.


"ResnetFPN" not an FPN?

Very nice paper. Quick question: it seems the ResNetFPN in your code is not really an FPN, it's just a trimmed resnet18/resnet34 with a new final layer. Is that right?

Yes.


Italian translation

Hello,
I would like to add Italian translation to the app. Could I work on it?
Thank you.

Yes, you are welcome :)

Hello, can I know how much is left to translate? 👀

Yes of course! I will finish it later today.

Ok will wait for you to publish a new release :)


Commit empty states

LMS-6425

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 95.717%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
2022

Relevant Lines:
2072

💛  - Coveralls


Default location for mssqlclirc

Hi everyone,
I'd like to put my custom mssqlclirc in a default location, such that mssql-cli picks it up automatically. I have searched the docs, but it's not there. I'm working on Ubuntu, so I thought it might be ~/.mssqlclirc but that's not the case. I have to specify it explicitly. I'd like to avoid creating an alias to keep my environment clean. Is there a default location for the rc file?
Cheers!

The default configuration file on Linux is is called config and it's located in  ~/.config/mssqlcli where ~ stands for your home directory (/home/<user> in most cases).

Thanks :) I'd like contribute by documenting this. Could you tell me where this should go? Then I can send a PR

Probably into README.rst because this is the landing point for anyone interested in mssql-cli.


Add a "Powered by Loco" section to the README/site.

Now that I've got my site deployed (Loco backend with Leptos frontend) it would be great to have a section of the README that can feature sites built using Loco.

@slyons, I'm acquainted with several companies already utilizing Loco. However, we need to secure their approval before publishing any information. I'll reach out to them to obtain the necessary permissions.
If someone is currently using Loco in their company and grants permission to add their company to our README, please feel free to send a private message on the Discord channel, and we'll promptly include it."

@slyons you can now add you site here:
https://github.com/loco-rs/loco?tab=readme-ov-file#powered-by-loco


Start the draging programmatically on layers

Hey!
Is there any way I can start the "dragging" of polygons programmatically? I want to add a copy paste feature and when you press paste I want it to "stick" to your mouse, without the user having to hold down, and when they press the mouse button it places the polygon. I was able to make my own little script for the circles but polygons have multiple corners and they can be nested...
I tried to use dig a bit in the source code but sadly was not able to get it to work. Any way it would be possible to start the dragging programmatically or if it would be possible to expose a function where you can do that? Another fun feature that I would like but not needed, is to add a rotation handle to the normal markers so that they can be rotated as using L.RotatedMarker you can just add a rotationvalue and it automatically rotates the picture.
Best Regards
Philip Magyar

Take a look into our moveCoords function. You need to define a deltaLatLng with the values how much in each directions the coords should be moved. You can get this in a way like this:
    const deltaLatLng = {
      lat: latlng.lat - this._tempDragCoord.lat,
      lng: latlng.lng - this._tempDragCoord.lng,
    };

https://github.com/geoman-io/leaflet-geoman/blob/d11cafd347fa18d7f913bb2699dcb0b3d90b21a1/src/js/Mixins/Dragging.js#L347-L366
And the set the coords to the layer:
layer.setLatLngs(moveCoords(layer.getLatLngs()));

Thank you, this works perfectly!


Multiple SQL Notebooks with same query running against same database and table hang

Issue Type: Bug

REPO

Create a SQL Notebook & write a query against a table in the DB
SELECT TOP (1000) [InvoiceLineId]
,[InvoiceId]
,[TrackId]
,[UnitPrice]
,[Quantity]
FROM [dbo].[InvoiceLine]

Create a second notebook and run the same query
SELECT TOP (1000) [InvoiceLineId]
,[InvoiceId]
,[TrackId]
,[UnitPrice]
,[Quantity]
FROM [dbo].[InvoiceLine]

Note that the queries hang

Azure Data Studio version: Azure Data Studio 1.5.2 (f74080c96310354bc92211f1826c0fdce78ca2f6, 2019-03-22T06:09:10.602Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) M-5Y51 CPU @ 1.10GHz (4 x 1200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.10GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

@YurongHe I believe that this is related to the work that you're already doing for creating notebook connections


[WIP] Swift 1.2

:warning: Do not merge until Xcode  6.3 is made public :warning:
:rotating_light: Depends on typelift/Swiftx#7 :rotating_light:

Okay, I've reached the tail end of these changes for Friday's Merge-Despite-Travis™.  @pthariensflame documentation is sorely lacking all over this thing.  If you have any suggestions (especially for the Lens hierarchy), I'd love to hear them.

OK, so any tests involving ArrowOf are not to be trusted at the moment.  Must remember to hold off on asserting those properties until something more concrete is available in SwiftCheck.

TONIGHT WE DINE IN HELL
:boat: