validation test failure related to SELinux

Built cri from source. Able to run unit test, integration test. while running validation tests using command make test-cri, one test related SELinux module is failing on RHEL 7.3:
[k8s.io] SELinux runtime should support selinux [It] should error on create with wrong options.          This test failures is observed only with Enforcing SELinux mode & with Permissive mode, All tests of SELinux module are getting skipped
Expected Behavior
test should pass
Current Behavior
[BeforeEach] [k8s.io] SELinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] SELinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:38
[BeforeEach] runtime should support selinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:47
[It] should error on create with wrong options
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:77
STEP: create a container with selinux
STEP: Get image status for image: busybox:1.28
STEP: Create container.
[AfterEach] runtime should support selinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:51
STEP: stop PodSandbox
STEP: delete PodSandbox
[AfterEach] [k8s.io] SELinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
тв Failure [0.803 seconds]
[k8s.io] SELinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:72
runtime should support selinux
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:43
should error on create with wrong options [It]
/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:77
Expected an error to have occurred.  Got:
    <nil>: nil

/tmp/cri-install-crictl.STRb/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/selinux_linux.go:106

Steps to Reproduce
git clone https://github.com/containerd/cri $GOPATH/src/github.com/containerd/cri
cd $GOPATH/src/github.com/containerd/cri
git checkout v1.0.4
make install.deps
make
sudo make install
make test
make test-integration
make test-cri
Your Environment

$ go version
go version go1.10.1 linux/amd64

Operating System and version:
NAME="Red Hat Enterprise Linux Server"
VERSION="7.3 (Maipo)"

$ getenforce
Enforcing

Can anyone please help in this?

@miaoyq Can you take a look at this?

Just checking ... @vitt-bagal do you have libseccomp installed?

default config for containerd is enable_selinux = false... though if it's skipping the tests that going to be how critest validate is checking for selinux support.

Looks like this code for testing if selinux is enabled might be problematic. Maybe we should be using
getenforce....

@miaoyq I'd start with updating to the latest selinux util.. https://github.com/kubernetes-incubator/cri-tools/blob/master/vendor.conf#L17 Looks like we're behind.

@mikebrow  Has this test passed after updating the selinux util?

No, I don't have a reproduction of the failure. I was curious and doing a quick investigation before Lantau asked you to look into it. There have been a lot of changes to the code in question (selinux.GetEnabled()) and the binaries that use it are way behind the current master. See cri-tools/critest validate, containerd/cri, and runc. Just an observation.

Seems not yet, we run CI test on ubuntu or similar systems that do not have selinux.

@mikebrow  Seems not yet, we run CI test on ubuntu or similar systems that do not have selinux.

@mikebrow I have tried to run test with changing vendor.conf file to use b6fa367ed7f534f9ba25391cc2d467085dbb445a latest commit from master of opencontainers/selinux on Rhel 7.3 as one work around, But still test failure is observed. currently this issue is observed on RHEL only

@vitt-bagal I will fix this failure. It‘s because the level of selinux options has not been verified.

@miaoyq Thanks for fixing this!


broken theme

pls somebody help me idk what to do

This is an issue with the theme you're using, not because of BD v2


Comp bio guide error

Feedback: "I thought it was worth mentioning that computational biology majors are not eligible for the CS minor (at least for students enrolled in the Dietrich school) since their rule is that only 8 credits may overlap between the major and a minor"

Can you do this?>

Updated.


Settings cannot be applied per folder

Operating System
MacOS Sonoma
Ruby version
3.2
Project has a bundle

[ ] Has bundle

Ruby version manager being used
asdf
Description
Every time I open/reload VS Code, I get a bunch of warnings that our project is not set up correctly. We are using a monorepo setup with a ruby api and a nextjs web app.
my_project/
  client-web/   <-- nextjs app
  server-api/   <-- ruby app

Your configuration looks fine to be honest. This might be a silly question, but did you open the configured workspace in VS Code (as opposed to just opening the directory)?
When you open the project.code-workspace file, there should be a button in the bottom right corner offering to open that workspace in VS Code.

I did open it that way, yeah. I found that if I opened the server-api directly and copied the ruby settings in the workspace file to server-api/.vscode/settings.json that the whole project works MUCH better. But it's a monorepo....so I need all the other folders too, so that defeats the purpose of having the workspace :/
Being able to jump into source code does NOT work from the workspace, but it does with the individual folder


Some colours are skipped

createBlocks() takes a "colour" argument that defines the colour of the next block that will be created. At each recursion level, this is incremented.
The problem is that not all the recursion levels will create blocks, hence some colours are skipped
Example: open addressBook.rng and check the this.setColour() calls: only 0, 90 and 180 are used

Colours are generated by a mechanism that by construction cannot skip colours


LC0035 - false positive for fields that aren't enabled

We sometimes have fields on tables, that are there only as dummy fields to ensure that TransferFields won't be crashed by creating a field in a sibling table with a different type.
Those fields are having the property Enabled=false;
Those fields shouldn't trigger the info for Rule LC0035.

The same applies for fields that are Obsolete.
At least with ObsoleteState = Removed;.
I'm not sure what's the best approach for ObsoleteState = Pending;

I believe that fields with ObsoleteState = Pending should be treated as normal fields. They can be pending for quite a while, and why shouldn't they behave as regular fields during that time?

I don't think there's a right answer for this question. @jwikman, you're absolutely right about the pending for quite a while, but then again this property should already has been set when creating the field? But then we could discusses the use case on creating and new field and obsoleting the old one, then I would indeed like to raise that warning to be honest.
For consistency throughout the LinterCop, where all rules exclude pending and/or removed objects, I would like to apply the same here. It could becoming confusing when obsoleting the whole table versus obsoleting a single field. The LinterCop skips almost all rules when the object has a ObsoleteState property (regardless of the value).

True, we've got two scenarios - when we get this new rule on existing code, and when having this rule when writing new code. I was thinking about the first scenario - I would like the warnings on all fields, regardless of ObsoleteState "Pending" or not, when the rule applied on an existing project. :)
And for new code, the ObsoleteState Pending should not be a big issue.
And I think you are right to do the same in other rules (haven't thought through all of them, though 😉).
The only rules that definitely should take the ObsoleteState Pending into account are some of the AL rules (like AL0432)...
I hope I don't get to regret this... 😅


Need to report tokens/sec

With temperature not set to 0, the result may and will vary from run to run. Better way to report the performance is to report tokens/sec.

Ahh, I checked test_llm.py and didn't see token/s and reported this. Now I see that query_llm.py reports this metric. So, not a problem then.


Don't assign default path for showSaveDialog unless it exists

Fixes #14732
Problem: "Save As" for a new file would default to the previously used directory, instead of the open project folder in Atom.
A regression was introduced where we were assigning the default path to be undefined when there was no file path for an item, as in the case of a brand new, unsaved file. When no default path is specified the operating system defaults to displaying the previously used directory.
The fix was to simply not set the default path in Pane.prototype.saveItemAs if the item has no path, and let AtomWindow.prototype.showSaveDialog set it based on the project paths, which happens later on down the code path.

@kuychaco you might want to take a look at #15160, which uses a slightly different approach.

Ah yes, thanks for pointing that PR out @50Wliu. I totally missed it somehow.
The approach in #15160 addresses part of the problem, but won't account for if there are multiple folders open in the project and the desired default directory is anything other than the first folder. In this PR, we're effectively taking the same approach, but letting AtomWindow decide which folder to default to based on the project.

Hmmm, turns out AtomWindow's way of deciding is to simply take the first path in loadSettings.initialPaths, which seems to be the most recently added folder. It's not the most intelligent way of determining the default path when there are multiple folders in the project, but it seems to be what we were doing before the regression (reference https://github.com/atom/atom/commit/c6cae5b8fdfea982084b068a0b38a7c988c52f51).
In any case, this fix as-is gets us to the expected behavior for a majority of the cases and restores the previous functionality. Any other improvements for handling multiple folders in a project can be handled in a separate PR.

Nice work @kuychaco.


batteryTemperature not available

Since the PR #12 is merged, you expect to have batteryTemperature in the json from the API.
I have an error related to that as it seems I don't have this key in the API response.
Perhaps link to the model.

batteryTemperature appeared, and then disappeared after a few days.
I think if the sensor doesn't exist we can just ignore it completely at this stage. Can you update the PR to just remove the else statement?

Merged PR #14


Open session detail from search screen

Idea Description
Currently, we can't open it.
Reference images and links

🙋♀


OpenXmlSimpleType children do not implement equality

Description
Classes like StringValue and HexBinaryValue do not implement equality and you must use their Value properties to compare them. This is not handy and can lead to unexpected results.
Information

.NET Target: Any
DocumentFormat.OpenXml Version: 2.8.1

Repro
using System.Collections.Generic;
using System.Linq;
using DocumentFormat.OpenXml;
using Xunit;

namespace DocumantFormat.OpenXml.Tests
{
    public class OpenXmlSimpleValueTests
    {
        private const string HexBinary = "12345678";
        private const string Value = "Hello World";

        [Fact]
        public void HexBinaryValue_ValuesAreEqual_HexBinaryValuesAreNotEqual()
        {
            var hexBinaryValue1 = new HexBinaryValue(HexBinary);
            var hexBinaryValue2 = new HexBinaryValue(HexBinary);

            Assert.Equal(hexBinaryValue1.Value, hexBinaryValue2.Value);

            // Those two HexBinaryValue instances should be deemed equal.
            Assert.NotEqual(hexBinaryValue1, hexBinaryValue2);
        }

        [Fact]
        public void HexBinaryValue_ValueIsContainedInList_ListDoesNotContainHexBinaryValue()
        {
            var hexBinaryValues = new List<HexBinaryValue>
            {
                new HexBinaryValue(HexBinary),
                new HexBinaryValue("ABCDEF00")
            };

            var hexBinaryValue = new HexBinaryValue(HexBinary);

            Assert.Contains(hexBinaryValue.Value, hexBinaryValues.Select(hbv => hbv.Value));

            // The HexBinaryValue should be deemed contained in the list.
            // The fact that this wasn't the case was a gotcha.
            Assert.DoesNotContain(hexBinaryValue, hexBinaryValues);
        }

        [Fact]
        public void StringValue_ValuesAreEqual_StringValuesAreNotEqual()
        {
            var stringValue1 = new StringValue(Value);
            var stringValue2 = new StringValue(Value);

            Assert.Equal(stringValue1.Value, stringValue2.Value);

            // The two StringValue instances should be deemed equal.
            Assert.NotEqual(stringValue1, stringValue2);
        }
    }
}

Observed
Two distinct instances of HexBinaryValue or StringValue, for example, will not be deemed equal even if their values are equal.
Expected
Given two distinct instances of HexBinaryValue, when the Value properties of those instances are equal, then those HexBinaryValue instances should be deemed equal as well.
The same should apply to other child classes of OpenXmlSimpleType such as StringValue.

This is a great point. Are you suggesting implementing Equals(object) and GetHashCode()?

@twsouthwick Yes, those two at least. Looking at the string and int types for inspiration, we should also consider:

IComparable,
IComparable<T>, and
IEquatable<T>.

That sounds good to me. Can you prepare a PR for this?

Yes, can do.

Just to be sure, are you considering to pull into master or 3.x?
This shouldn't be a breaking change, so could create feature branch off of master for PR into master.

@ThomasBarnekow thanks for the contribution!


Network connection not working

Thanks for the great work,
I can't get a network connection. I ordered 2 different ethernet to usb adapters and 2 different wifi dongles with the mentioned chipsets. Non of them work.

Its an alpha and as an alpha this things are likely to happen. Plug and unplug until it gets connection

I know what's an alpha. If that's the argument there is no need to report any problems. I contribute to help. The mentioned chipsets didn't work on my end. That's all

I know what's an alpha. If that's the argument there is no need to report any problems. I contribute to help. The mentioned chipsets didn't work on my end. That's all

you aren’t reading it properly. Its an alpha,so there are problems like that in which you need to unplug and plug several times the dongle to make it work.
That’s all.
You can read about that topic here

The e2m documentation said to replug after booting and I did that many times but I'll keep trying. Thank you for the link.

I didn’t had too many problems with my units.
But with regards of tp link TL-WN725N first version isn’t working, only version 2 (I don’t have v3 so dunno)
Here is an attachment of v2

Old thread but...
I tried a no-brand USB Wi-Fi adapter and it didn't work even with unplugging/re-plugging rebooting etc.
I bought a TP-LINK  TL-WN725N and it worked first time with no issues in port 1.

The e2m documentation said to replug after booting and I did that many times but I'll keep trying. Thank you for the link.

I didn’t had too many problems with my units. But with regards of tp link TL-WN725N first version isn’t working, only version 2 (I don’t have v3 so dunno) Here is a pic of v2

V3 works fine. Tested today on my unit 🙂

Hello, I can confirm that this adapter for the Nintendo Switch also works very well with the TAITO Egret 2 mini
https://www.amazon.it/gp/product/B01N6S068R/


Can always fire Portal 1 and 2 with controller

Do you remember the options to turn on only portal 1 or 2 in Main tab and Portal Gun Pedestal? They don't work right.
We still can shoot both of them by press the Portal 1 and Portal 2 button (Setting like this:

), we should fix this because some Portal mappacks use much times this options may broken (Up And Away Remake)
Also now we don't need the option "shoot portal" in Tool tab anymore

Also, we still can fire portal with mouse by turn on the mouse after setting Portal 1 and 2 button (like on gif)


Eating the following space

It seems that the gem is swallowing the following space or new lines after a [shortcode] is inserted.
ex. If the content is Hello [first-name]\r\n\r\nit's a great day. the result will be Hello Bruceit's a great day.
Any idea what's going on?  Here's my code specifically:
Shortcode.register_presenter(InvoiceShortcodePresenter)
Shortcode.register_presenter(CustomerShortcodePresenter)

Shortcode.setup do |config|

  # the template parser to use
  config.template_parser = :erb # :erb, :haml, :slim supported, :erb is default

  # location of the template files, default is "app/views/shortcode_templates"
  # config.template_path = "support/templates/erb"

  # a hash of templates passed as strings, if this is set it overrides the
  # above template_path option. The default is nil
  # config.templates = { gallery: 'template code' }

  # an array of helper modules to make available within templates
  config.helpers = [OrdersHelper]

  # a list of block tags to support e.g. [quote]Hello World[/quote]
  # config.block_tags = [:quote]

  # a list of self closing tags to support e.g. [youtube id="12345"]
  config.self_closing_tags = [:'invoice-id', :'customer-first-name', :'customer-full-name']

  # the type of quotes to use for attribute values, default is double quotes (")
  config.attribute_quote_type = '"'

  # Allows quotes around attributes to be omitted
  # Defaults to true, quotes must be present around attribute values
  config.use_attribute_quotes = true
end

class InvoiceShortcodePresenter

  # name of the shortcode
  def self.for
    :'invoice-id'
  end

  def initialize(attributes, content, additional_attributes)
    @content = content
    @additional_attributes = additional_attributes
  end

  def content
    @content
  end

  def attributes
    {
      order: @additional_attributes[:order]
    }
  end
end

The template
@attributes[:order].visual_id

Hi,
Can you try https://github.com/kernow/shortcode/tree/whitespace-fix and see if it fixes the issue you're having?

That fixed it for the most part, thanks!
I did have a message like this:
Hello [first-name],

Thanks!

That was then changed to:
Hello [first-name],
Thanks!

I'm not able to reproduce the issue. See https://github.com/kernow/shortcode/commit/a4af5ceeddd8975e2c8a221ab38e7dbb349aa382 which passes. Would you be able to fork the whitespace branch and create a failing test?


wmiexec bug

(venvcrackmapexec)root@kali:~/Partage/CrackMapExec_fork# python crackmapexec.py <IP_ADDRESS> -u àlolé -H :1356a6dd7709ab1640d062fa957d6634 -x "whoami"
01-24-2016 11:46:38 SMB <IP_ADDRESS>:445 DC01       [*] Windows 6.3 Build 9600 (name:DC01) (domain:ADYOLO)
01-24-2016 11:46:38 SMB <IP_ADDRESS>:445 DC01       [+] Login successful ADYOLO\àlolé::1356a6dd7709ab1640d062fa957d6634
01-24-2016 11:46:40 SMB <IP_ADDRESS>:445 DC01       [+] Executed command via WMIEXEC
ERROR:root:'ascii' codec can't decode byte 0x85 in position 7: ordinal not in range(128)
Traceback (most recent call last):
  File "/root/venvcrackmapexec/local/lib/python2.7/site-packages/gevent/greenlet.py", line 327, in run
    result = self._run(*self.args, **self.kwargs)
  File "/mnt/hgfs/Partage/CrackMapExec_fork/core/greenlets.py", line 247, in main_greenlet
    ntlm_hash)
  File "/mnt/hgfs/Partage/CrackMapExec_fork/core/executor.py", line 24, in __init__
    wmi_exec.run(host, smbconnection)
  File "/mnt/hgfs/Partage/CrackMapExec_fork/core/scripts/wmiexec.py", line 82, in run
    dcom.disconnect()
  File "/root/venvcrackmapexec/local/lib/python2.7/site-packages/impacket/dcerpc/v5/dcomrt.py", line 1070, in disconnect
    del(INTERFACE.CONNECTIONS[self.__target][currentThread().getName()])
KeyError: 'Dummy-1'
<Greenlet at 0xb66578ecL: main_greenlet('<IP_ADDRESS>')> failed with KeyError

I never experienced that bug before, does it come from impacket ? I don't have it with --execm smbexec

Wait, it seems to be related to the utf-8 issue. I tried but did not managed to get it fixed...

@maaaaz I actually experienced this bug on a recent engagement, I have a feeling this might be an impacket bug, although I'm not really able to reproduce it

@maaaaz Looking at your command string and noticed that you don't have the full ntlm hash, did you remove that on purpose?

@maaaaz just reproduced it, will work on a fix asap

@maaaaz Fixed in v3.0


Extra blank skos:definition on fibo-fnd-plc-adr:PhysicalAddressIdentifier

This leads to a duplicate record in a SPARQL query for FIBO classes.
Release: https://spec.edmcouncil.org/fibo/ontology/master/2019Q1/prod.ttl.zip
Fix: delete the blank annotation property
fibo-fnd-plc-adr:PhysicalAddressIdentifier
  rdf:type owl:Class ;
  rdfs:comment "QName: fibo-fnd-plc-adr:PhysicalAddressIdentifier" ;
  rdfs:isDefinedBy fibo-fnd-plc-adr: ;
  rdfs:label "physical address identifier" ;
  rdfs:subClassOf owl:Thing ;
  rdfs:subClassOf lcc-lr:CodeElement ;
  rdfs:subClassOf lcc-lr:Identifier ;
  rdfs:subClassOf [
      rdf:type owl:Restriction ;
      owl:onClass fibo-fnd-plc-adr:PhysicalAddress ;
      owl:onProperty lcc-lr:identifies ;
      owl:qualifiedCardinality "1"^^xsd:nonNegativeInteger ;
    ] ;
  rdfs:subClassOf [
      rdf:type owl:Restriction ;
      owl:onClass fibo-fnd-plc-adr:PhysicalAddressingScheme ;
      owl:onProperty lcc-lr:isMemberOf ;
      owl:qualifiedCardinality "1"^^xsd:nonNegativeInteger ;
    ] ;
  skos:definition "" ;
  skos:definition "unique identifier for a physical address" ;
  skos:example "Physical address identifiers may include bar codes, QCR codes, and +codes in a number of countries." ;

The problem is also in the original RDF/XML source:
rdfs:labelphysical address identifier</rdfs:label>
skos:definition</skos:definition>
skos:definitionunique identifier for a physical address</skos:definition>
However, @jziemer2 , though it does not make sense here with a blank value, there is nothing IMO inherently wrong with having multiple triples for the same annotation property on a resource. So your SPARQL query processing should be able to cope.

I will have fixed this by the end of the day today, fyi, but I agree with Pete.  I'm wondering though, whether or not we should allow more than one skos:definition - other annotations yes, but multiple skos:definition in the same natural language maybe not?

@rivettp, as long as it is consistent.
One out of 1800 classes with more than skos: definition suggests a bug. There should be only one definition and label, but there can be several instances of the various SKOS notes. My query handles multiple annotation property instances, but it shouldn't concatenate two labels.


Lombok installer won't find target in MyEclipse 2018.2 installation

While running the Lombok installer and trying to integrate it into a Genuitec MyEclipse (v2018.2) installation the installer can't seem to find the file(s) it wants to target/modify.  If someone has a set of manual instructions to get Lombok integrated so MyEclipse will compile project code which includes Lombok annotations I'd be greatly appreciative! :) :+1:

@Andrew-Poloni No idea what exactly your eclipse needs, but can't you point the installer to the install directory manually? The only modified file is eclipse.ini and the only change is adding the line
-javaagent:/your-path-to-eclipse/lombok.jar

just after -vmargs. BTW the installer shows this information when you click on the first blue link.

I did in fact point the installer to the directory manually; I suspect the problem is that the installer is looking for a eclipse.ini file.  For a MyEclipse installation there is no such file; the file is myeclipse.ini which I'm guessing the installer doesn't recognize (and I did point it to the directory where that file lives).
I appreciate that you can manually modify the (my)eclipse.ini file to get Lombok working, but the Lombok installer Eclipse docs lump MyEclipse in with Eclipse so I expected the installer to work with either.  I might suggest that perhaps either the installer code should be modified to look for a myeclipse.ini file as well or a note to the difference in the documentation might be in order.

@Andrew-Poloni So, myeclipse.ini can be handled just like eclipse.ini, right? You did it manually and everything works for you now, right?
Disclaimer: I'm not a project owner and I'm not going to fix it myself. I was just trying to help you and make the problem clearer for someone who'll take care.

For #1830 we added support for finding installer in LOCALAPPDATA. Since this is also a Genuitec product, there is a good chance that the problem is solved in the next release.
We'll do an edge release soon, please let us know if that fixes this problem. If not, please tell us the exact path to both the executable and the ini file.

As it turns out, the easy fix (for me, anyhow) was to simply rename myeclipse.ini to eclipse.ini and then point the Lombok installer to that file.  The Lombok installer then found the file and modified it nicely.  Afterwards I simply renamed the file back to myeclipse.ini and restared MyEclipse.  I already had the Lombok JAR file in the build path of my project, so when MyEclipse restarted all my Lombok-related annotation compilation errors went away. :+1: That said, I'm assuming that a change of the installer code to look for files named myeclipse.ini along with eclipse.ini will fix this issue. :)
I like the fact that the Lombok installer puts the absolute path to the Lombok JAR into the .ini file; i.e., the location of the Lombok JAR used to launch the Lombok installer.  I would have probable missed that little detail had I done it manually.
BTW, I should have provided more context originally: I'm running on CentOS v7.5.

That is strange, we should also accept myeclipse.ini.

I just double-checked and the (Lombok v1.16.10) installer can't find the myeclipse.ini file in the directory where I installed MyEclipse (Bling) on CentOS v7.5 (~/Genuitec/MyEclipse/v2018_8_0).  Should I be using a later version of the Lombok JAR perhaps?

I just tried the latest version (v1.18.2) of the Lombok JAR file on CentOS v7.5 (Java v1.8.1_181) and the Lombok installer found both the myeclipse and myeclipse.ini file (after I directed it to the appropriate directory). (See attached.) My project has been using 1.16.10 for whatever reason and hasn't upgraded.  Looks like this was an issue you guys fixed some time ago ... thanks for looking into it.


nanoauth has the X-NANOBOX-TOKEN header as the default

Seen here

@iamthemuffinman You're right, thanks for this!
@glinton When you get a minute, can you review/merge this?

@tylerflint You're welcome! Probably the smallest PR ever. :)

@glinton Did you have a chance to review this?

@iamthemuffinman, sorry for the delay, I have reviewd it. I've just been debating whether to keep x-nanobox-token or go with the more generic x-admin-token that logvac implements. I'll go ahead and merge this in for now and change it when/if I finally decide. Thanks

@glinton No problem! Thanks!


Preventing random encounters doesn't work on the Veldt.

As the title states. In FF6, Memoria is able to prevent random encounters elsewhere, but not on the Veldt.

Thank you. Fixed.


Invalid toFileRange.lines when using --unified=0

When trying to parse a minimal diff using git diff --unified=0 the resulting lines in toFileRange is the same as the start value.
The following example (adding a single line):
diff --git a/tests/test_commands.py b/tests/test_commands.py
index 8838bb3bb0992afe26109081704e8c67a49a171a..ed42fd1d1e649d1197772f2047d7ce2a4461a533 100644
--- a/tests/test_commands.py
+++ b/tests/test_commands.py
@@ -12,0 +13 @@ def test_parse_git_version():
+    # add this

Results in:
{
  "type": "GitDiff",
  "files": [
    {
      "type": "ChangedFile",
      "chunks": [
        {
          "context": "def test_parse_git_version():",
          "type": "Chunk",
          "toFileRange": {
            "start": 13,
            "lines": 13
          },
          "fromFileRange": {
            "start": 12,
            "lines": 0
          },
          "changes": [
            {
              "type": "AddedLine",
              "lineAfter": 13,
              "content": "    # add this"
            }
          ]
        }
      ],
      "path": "tests/test_commands.py"
    }
  ]
}

From wikipedia:

The hunk range information contains two hunk ranges. The range for the hunk of the original file is preceded by a minus symbol, and the range for the new file is preceded by a plus symbol. Each hunk range is of the format l,s where l is the starting line number and s is the number of lines the change hunk applies to for each respective file. In many versions of GNU diff, each range can omit the comma and trailing value s, in which case s defaults to 1. Note that the only really interesting value is the l line number of the first range; all the other values can be computed from the diff.

@pdgendt Thank you for your report. I missed the notification about the issue, I'll check it out.

@pdgendt Thanks it's fixed in 0.0.17


Undo changed directory but UI doesn't reflect correctly

I use the default data.
Enter Command:
s 1
edit 1 r/remark
undo

This is because commit() is only called when an undoable command is called. In this case the first undoable command is edit, so the VersionedSaveIt that undo wants to roll back is initial version, whose Directory is root level.
I suggest post event DirectoryChangedEvent to change UI instead of trying to track the directory, because for me that means tracking all commands input.

That's a good suggestion. I've made the change in the latest PR.


How do we update Cluster Metrics feature?

Lens is shipped with custom prometheus stack. In case of there is update available (hope you'll maintain these images right?) how do we update those stack?

What's the correct way to update prometheus stack values? Let's say I modified this prometheus stack values quite heavily (requests, limits, volumes, args, configmaps etc). What would happen when there is new update available and update?
Will my edited values overwritten? If that's the case, we'd need edit values option before installation, instead of single "Install" button.

I think you should install your own prometheus there and configure lens to use it. I'd consider this built-in thing as "demo"

how do we update those stack?

Once we bundle more recents prom stack versio into the app, there'll be a "Upgrade" button in the cluster settings.

Let's say I modified this prometheus stack values quite heavily (requests, limits, volumes, args, configmaps etc). What would happen when there is new update available and update?

As there's currently no mechanisms in the app to customize the prometheus stack, you'd get all the modifications overwritten. Sounds like you probably are better of with running prometheus via Helm chart or the prometheus operator. Prom operator allow probably the best ways to customize the stack.

I'd consider this built-in thing as "demo"

Demo might not be the right word, but it is intended for people to get started easily. The end result of that is pretty close what you'd get with the stable Helm chart without any customizations.

Thanks for the answers folks!

Closing as the questions has been answered.


test: verify packages on module_hotfixes test

I've pushed regular rebase, let see if the tests budge this time :stuck_out_tongue:


Improve error handling when trying to use RAW github urls in annotations

Improve error messaging for invalid Github annotation urls to allow users to fix problems with annotations themselves.
Currently there is not much handling around common scenarios of invalid annotation urls that would allow a user to know what the problem is and fix it. They just get a generic NotAllowedError(Reading from xxx is not allowed)
Feature Suggestion
When a user tries to link to a raw version of a file in Github i.e. https://raw.githubusercontent.com/sonallux/spotify-web-api/main/official-spotify-open-api.yml in an api spec annotation they just see NotAllowedError(Reading from https://raw.githubusercontent.com/sonallux/spotify-web-api/main/official-spotify-open-api.yml is not allowed)
i.e.
definition:
  $text: https://raw.githubusercontent.com/sonallux/spotify-web-api/main/official-spotify-open-api.yml

It would be more helpful to explain that only valid Github web view addresses are allowed so users can fix this themselves.
Possible Implementation
Add another fallback before the default error message here https://github.com/backstage/backstage/blob/9e8507305c90c790f47b292339ceccbfeb602458/packages/backend-common/src/reading/UrlReaderPredicateMux.ts#L90
Context
Allow users to fix problems with annotations themselves

Maybe there's an argument to be had that we should be flexible and supporting raw urls too ... but that may be a bit of a bigger endeavor.
Is this type of checking something you might like to even contribute? One potential challenge is, should it be a fatal error that stops processing, or just some form of warning? We don't really have a nice mechanism for surfacing warnings unfortunately; logging isn't something the end user gets to see easily.


Card view in frontend tab

Hello!
I want to use new tab feature but it seems that card view (old group style) is not possible with view: yes
Am I wrong ?
Keep the good job !

Embed a group in a view group to get the desired behavior.

I can't get this to work. Can someone send me a sample of a config?

@balloob : I'm also interessted :)

Have a look at the documentation for the group component.

 I missed the group.GROUPNAME entry in the entities.
Thanks

@frekel : can you share your group config ?

sure:
I have this in configuration.yaml
group: !include config/group.yaml
and this in config/group.yaml
living_room:
      name: Huiskamer
      entities:
        - light.Go_lamp
        - light.Staande_lamp
        - light.TV_Lamp_Links
        - light.TV_Lamp_Rechts
kitchen:
    name: Keuken
    entities:
        - light.Keuken_spot_1
        - light.Keuken_spot_2
        - light.Keuken_spot_3
firstfloor:
    name: First floor
    view: yes
    entities:
        - group.living_room
        - group.kitchen
        - light.gang

Thanks !


Error when having multiple line charts with ON and OFF Regression

Dear phpepe,
I found a problem when adding more then one series to the regression library, I need to have all ON to have regression and cannot be selective regarding which one I would like to have a regression line,
found the problem to be in the (library code) line 88
    H.wrap(H.Chart.prototype, 'init', function (proceed) {
        var series = arguments[1].series;
        var extraSeries = [];
        var i = 0;
        for (i = 0; i < series.length; i++) {
            var s = series[i];
            var extraSerie = processSerie(s, 'init', this);
            extraSeries.push(extraSerie);
            arguments[1].series[i].rendered = true;
        }

        if (extraSerie) {
            arguments[1].series = series.concat(extraSeries);
        }

        proceed.apply(this, Array.prototype.slice.call(arguments, 1));

    });

I made a few changes to prevent adding undefined series in the case of regression being OFF and when the last series was undefined the validation seemed to not address this issue, so, I changed it as well (concat). With this I can now have a mix of series with regression ON and OFF without any problem.
    H.wrap(H.Chart.prototype, 'init', function (proceed) {
        var series = arguments[1].series;
        var extraSeries = [];
        for (var i = 0; i < series.length; i++) {

            var extraSerie = processSerie(series[i], 'init', this);
            arguments[1].series[i].rendered = true;

            if (extraSerie) {
                extraSeries.push(extraSerie);
            }
        }

        if (series && extraSeries.length > 0) {
            arguments[1].series = series.concat(extraSeries);
        }

        proceed.apply(this, Array.prototype.slice.call(arguments, 1));

    });

Do you want to add this correction by yourself and validate it, you should I submit a fix?
Best Regards

Thanks ! this is an old issue, reported on #66 .
If you think this fix that bug, are you confortable creating pull requests ?
Otherwise I need to find a time to pick your code from the comment, test and push to master.

I will do the pull request ;)
Thanks!


Use case of this vs. quicli?

I know that you're the author of the quicli crate, which seems to have a subset of functionality that conflicts with this (since both crates would set up env-logger, right?). Is the use case to have a more minimal set of dependencies and cut out the main! macro and its associated failure dependency? Perhaps you think that this is more appropriate to use generally now that ?-in-main is available on stable?

Good question! :) The next version of quicli will use this crate internally: https://github.com/killercup/quicli/pull/80
I first wrote this as part of quicli, but @yoshuawuyts convinced me that it makes sense to be a crate of its own. This way, people not using quicli can still use this.
(?-in-main still has some unresolved issues, and I'll follow up on that in the next few days.)
I hope that answers your questions!

Cool. I'd be glad if you would open a PR to improve the Readme! Right now it also doesn't show how to init the logger using the verbosity type.

...do you mean in this issue, or via some other medium? Just want to clarify.

It'll be somewhere else, as it has nothing to do with this crate specifically. :) The current problem is that it's not easy to get rid of quicli's main macro and use ?-in-main instead, as we lose the ability to print out the errors in a nice way. Sadly, right now it seems to depend on some features being added to failure, so I'll have to check with them how to do it once I have a clear idea of what needs to be done.


SignColumn extends into EndOfBuffer zone but LineNr does not

In this screenshot shows how the sign column (the one with the "m" mark in it) is drawn all the way down to into the "EndOfBuffer" region, but the "LineNR" area is not:

So not sure whether this is a bug report or a feature request, but one of two things should probably happen in the name of consistency ( either "the sign column should not extend into the EndOfBuffer zone" or "the LineNr columns should be drawn in the EndOfBuffer area just like the SignColumn is").
I suspect that, given that the ColorColumn stuff on the right also doesn't extend down into the end of buffer area, then perhaps the SignColumn should not extend. (Either that or ColorColumn should extend all the way down; I'd actually prefer it if they all extended all the way down, but above all I mostly just want something consistent.)
Screenshot was taken on:
VIM - Vi IMproved 8.1 (2018 May 18, compiled Dec 13 2018 12:08:00)
macOS version
Included patches: 1-577
Compiled by Homebrew

https://github.com/neovim/neovim/pull/1221

Useful because it points out something I hadn't noticed, which is that the fold column shares this behavior of extending down all the way. So really it's a choice between making all of fold column, sign column, number column, and color column extend all the way down, or making none of them do so. I'd favor the latter aesthetically speaking, but either would be an improvement over the current inconsistency.

Marco Hinz wrote:

https://github.com/neovim/neovim/pull/1221

Do I understand it correctly that NeoVim did NOT include this?
--
"Beware of bugs in the above code; I have only proved
it correct, not tried it." -- Donald Knuth
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

@brammool: Correct, although with the discussion on https://github.com/neovim/neovim/issues/9613 they are now saying:

Would you agree with extending the number column to the end of the screen? If so, I'd have another look at it.

given how much test coverage we have compared to then, it's much lower-risk (except performance regressions). No objection from me.
Maybe make it non-optional, unless someone objects, then maybe throw it into 'display' option.

@brammool
What's your opinion on this in general?
I think it would make sense to just extend the number column to the end of the window, so that all 3 column types (fold, sign, number) behave the same. It also shouldn't take too much code.
If someone can come up with a very good reason for doing the opposite, that is making the fold and sign column end at the end of the buffer instead of the window, we could implement both versions and make it configurable via a new entry in 'display'.

I'd also add colorcolumn to that list, as it's another vertical segment that currently doesn't extend all the way down.

@brammool
What's your opinion on this in general?
I think it would make sense to just extend the number column to the
end of the window, so that all 3 column types (fold, sign, number)
behave the same. It also shouldn't take too much code.

The problem is that below the last line there are no line numbers.
Would show an empty column, not sure if that looks OK.

If someone can come up with a very good reason for doing the opposite,
that is making the fold and sign column end at the end of the buffer
instead of the window, we could implement both versions and make it
configurable via a new entry in 'display'.

We already have more than enough options...
Since this is only a visual think, not functional, and I can't remember
it being mentioned before, I would only change it when it's a clear
improvement.
I believe the end of the number column at the last line, so that the "~"
lines are below it, is something that Vi already did.  Thus I don't
think we should take that away.
Having all the extra columns stop as well does not appear to have a
disadvantage.  And it gives the same look when 'number' is not set.
It's a clear end of the buffer lines then.  I tend to think this works
best.
--
Hacker: Someone skilled in computer programming (good guy).
Cracker: A hacker that uses his skills to crack software (bad guy).
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Here are some visuals to aid the discussion:
1: This is Vim with the different vertical columns visible:

From left to right, they are:

foldcolumn (extends all the way to the bottom)
signcolumn (extends all the way to the bottom)
number (stops at EndOfBuffer region)
cursorcolumn (stops at EndOfBuffer region)
colorcolumn (all the columns past 80 columns, stops at EndOfBuffer region)

2: Vim again, this time with visible "~" in theEndOfBuffer region (the previous screenshot hides them by setting the EndOfBuffer highlight group to make them invisible):

3: Neovim, which displays all of these columns in pretty much exactly the same way:

4: Neovim, with visible "~" in the EndOfBuffer region:

5: A mockup showing what Vim would look like if none of the columns extended to the bottom:

6: Same, but with visible "~" in EndOfBuffer region:

7: A mockup showing what Vim would look like if all of the columns extended to the bottom:

8: Same, but with visible "~" in EndOfBuffer region:

Of all of the mockups, I think 7 and 8 are the most aesthetically pleasing, but as @brammool says, moving the physical location of the "~" in the EndOfBuffer region may be a non-starter if it breaks with the pattern established by vi. 5 and 6 aren't quite as visually pleasing, but their consistency still makes them an improvement over the current behavior.

(upper split: unpatched vim, lower vim: patched Vim started with vim --clean -c ':set bg=dark foldcolumn=6 signcolumn=yes cursorcolumn colorcolumn=10 nu' screen.c
Patch:
diff --git a/src/screen.c b/src/screen.c
index 4973b510d..3aa2c0920 100644
--- a/src/screen.c
+++ b/src/screen.c
@@ -2317,52 +2317,17 @@ win_draw_end(
     int                endrow,
     hlf_T      hl)
 {
-#if defined(FEAT_FOLDING) || defined(FEAT_SIGNS) || defined(FEAT_CMDWIN)
     int                n = 0;
-# define FDC_OFF n
-#else
-# define FDC_OFF 0
-#endif
-#ifdef FEAT_FOLDING
-    int                fdc = compute_foldcolumn(wp, 0);
-#endif

 #ifdef FEAT_RIGHTLEFT
     if (wp->w_p_rl)
     {
        /* No check for cmdline window: should never be right-left. */
-# ifdef FEAT_FOLDING
-       n = fdc;
-
-       if (n > 0)
-       {
-           /* draw the fold column at the right */
-           if (n > wp->w_width)
-               n = wp->w_width;
-           screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-                   W_ENDCOL(wp) - n, (int)W_ENDCOL(wp),
-                   ' ', ' ', HL_ATTR(HLF_FC));
-       }
-# endif
-# ifdef FEAT_SIGNS
-       if (signcolumn_on(wp))
-       {
-           int nn = n + 2;
-
-           /* draw the sign column left of the fold column */
-           if (nn > wp->w_width)
-               nn = wp->w_width;
-           screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-                   W_ENDCOL(wp) - nn, (int)W_ENDCOL(wp) - n,
-                   ' ', ' ', HL_ATTR(HLF_SC));
-           n = nn;
-       }
-# endif
        screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-               wp->w_wincol, W_ENDCOL(wp) - 1 - FDC_OFF,
+               wp->w_wincol, W_ENDCOL(wp) - 1,
                c2, c2, HL_ATTR(hl));
        screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-               W_ENDCOL(wp) - 1 - FDC_OFF, W_ENDCOL(wp) - FDC_OFF,
+               W_ENDCOL(wp) - 1, W_ENDCOL(wp),
                c1, c2, HL_ATTR(hl));
     }
     else
@@ -2379,37 +2344,9 @@ win_draw_end(
                    wp->w_wincol, (int)wp->w_wincol + n,
                    cmdwin_type, ' ', HL_ATTR(HLF_AT));
        }
-#endif
-#ifdef FEAT_FOLDING
-       if (fdc > 0)
-       {
-           int     nn = n + fdc;
-
-           /* draw the fold column at the left */
-           if (nn > wp->w_width)
-               nn = wp->w_width;
-           screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-                   wp->w_wincol + n, (int)wp->w_wincol + nn,
-                   ' ', ' ', HL_ATTR(HLF_FC));
-           n = nn;
-       }
-#endif
-#ifdef FEAT_SIGNS
-       if (signcolumn_on(wp))
-       {
-           int     nn = n + 2;
-
-           /* draw the sign column after the fold column */
-           if (nn > wp->w_width)
-               nn = wp->w_width;
-           screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-                   wp->w_wincol + n, (int)wp->w_wincol + nn,
-                   ' ', ' ', HL_ATTR(HLF_SC));
-           n = nn;
-       }
 #endif
        screen_fill(W_WINROW(wp) + row, W_WINROW(wp) + endrow,
-               wp->w_wincol + FDC_OFF, (int)W_ENDCOL(wp),
+               wp->w_wincol + n, (int)W_ENDCOL(wp),
                c1, c2, HL_ATTR(hl));
     }
     set_empty_rows(wp, row);

It does clean up win_draw_end() quite a bit.

BTW: I wouldn't draw the colorcolumn and cursorcolumn into the end-of-buffer region, because people might think this is in the buffer. (In my opinion, mockup 5/6 makes it visually more clear, that the end-of-buffer does not belong to the file.)

Hi,
here is a proper patch with a test case. There are two things to note:

Not sure how to test drawing the command line window. It looks like
the commandline window is only created in interactive mode (e.g. when no
characters are in the typeahead buffer).  It might be possible to fix
this using the test_override() function, but since the command line
window is always drawn at the bottom, I am not sure how to figure out
the correct values values for the screen lines to be captured.

If I uncomment the call feedkeys() call and run the test
interactively, after the command line window opens and I close the
command line window manually using :q, I see a E315 invalid lnum error for line 40.

I believe this one is unrelated to the change in this patch. It looks
like, after closing the commandline window, Vim is trying to scroll the
top window to line 40. However, since the test window has only 20 lines,
this fails. I am actually wondering, why wp->w_cursor.lnum is 40 when
that test window only has 20 lines...
Backtrace:
#0  0x00005555558412d2 in siemsg (s=0x5555558587f8 "E315: ml_get: invalid lnum: %ld") at message.c:780
#1  0x0000555555696971 in ml_get_buf (buf=0x555555982c70, lnum=40, will_change=0) at memline.c:2487
#2  0x00005555556a4362 in plines_win_col (wp=0x555555980860, lnum=40, column=0) at misc1.c:2184
#3  0x00005555557c623b in scroll_to_fraction (wp=0x555555980860, prev_height=10) at window.c:5781
#4  0x00005555557c6179 in win_new_height (wp=0x555555980860, height=34) at window.c:5758
#5  0x00005555557c1a3a in frame_new_height (topfrp=0x555555986f20, height=35, topfirst=0, wfh=0) at window.c:2904
#6  0x00005555557bfbe9 in win_equal_rec (next_curwin=0x555555989640, current=0, topfr=0x555555986f20, dir=118, col=41, row=0, width=233, height=35) at window.c:1813
#7  0x00005555557c008b in win_equal_rec (next_curwin=0x555555989640, current=0, topfr=0x55555591a460, dir=118, col=41, row=0, width=233, height=35) at window.c:1952
#8  0x00005555557c051e in win_equal_rec (next_curwin=0x555555989640, current=0, topfr=0x555555914950, dir=118, col=0, row=0, width=274, height=70) at window.c:2092
#9  0x00005555557bfb1f in win_equal (next_curwin=0x555555989640, current=0, dir=118) at window.c:1772
#10 0x00005555557c0f7a in win_close (win=0x55555598e550, free_buf=1) at window.c:2479
#11 0x0000555555657128 in open_cmdwin () at ex_getln.c:7354
#12 0x000055555564b299 in getcmdline_int (firstc=58, count=1, indent=0, init_ccline=1) at ex_getln.c:1427
#13 0x000055555564a184 in getcmdline (firstc=58, count=1, indent=0) at ex_getln.c:832
#14 0x000055555564d8c7 in getexline (c=58, cookie=0x0, indent=0) at ex_getln.c:2684
#15 0x000055555563029b in do_cmdline (cmdline=0x0, fgetline=0x55555564d88a , cookie=0x0, flags=0) at ex_docmd.c:929
#16 0x00005555556c52e5 in nv_colon (cap=0x7fffffffdd30) at normal.c:5331
#17 0x00005555556bd6e7 in normal_cmd (oap=0x7fffffffde20, toplevel=1) at normal.c:1121
#18 0x00005555558398bf in main_loop (cmdwin=0, noexmode=0) at main.c:1359
#19 0x0000555555838f42 in vim_main2 () at main.c:901
#20 0x0000555555838649 in main (argc=9, argv=0x7fffffffe018) at main.c:441
This patch fixes it, not sure if this is correct:
diff --git a/src/window.c b/src/window.c
index c4b543de3..0b5629ec6 100644
--- a/src/window.c
+++ b/src/window.c
@@ -5774,8 +5774,10 @@ scroll_to_fraction(win_T *wp, int prev_height)
* relative position in the window as before (more or less).
*/
lnum = wp->w_cursor.lnum;

  if (lnum < 1)           /* can happen when starting up */

  if (lnum < 1)           // can happen when starting up
      lnum = 1;

  if (lnum > wp->w_buffer->b_ml.ml_line_count)  // safety check

      lnum = wp->w_buffer->b_ml.ml_line_count;
  wp->w_wrow = ((long)wp->w_fraction * (long)height - 1L
                                   + FRACTION_MULT / 2) / FRACTION_MULT;
  line_size = plines_win_col(wp, lnum, (long)(wp->w_cursor.col)) - 1;

Best,
Christian
Kotzt der Bauer über'n Trecker, war die Brotzeit nicht sehr lecker.

Thanks @chrisbra, @brammool!

yea this is really aggrivating for colorschemes that haven't fixed it.  just a heads up you can fix it with highlight clear endOfBuffer in init.vim... test it out on affected screen just run it in command mode :highlight clear endOfBuffer

example usage
" Ariake Dark colorscheme Ariake-Dark set background=dark highlight clear SignColumn highlight clear LineNr highlight clear endOfBuffer


Propose and implement a design with no scroll bars in the speaker section

Parent Issue: https://github.com/fossasia/open-event-webapp/issues/515#issuecomment-234709757
Propose and implement a design with no scroll bars in speaker section (make a screenshot how it will look like.

@mariobehling After taking lot of examples I think we should rethink this issue once
Points to be considered

We should have fixed height for each card otherwise it will give a very bad layout.
Example

When we keep this height fixed, we have to consider the speaker Bio coming from JSON which differs in content length.
Use case : some speakers have long Biography while others have small.

To deal with variable data under a fixed container only scrollbar works best. We can take examples of websites like facebook having fixed height chatbox at left corner and a scrollbar only when it is hovered.

The same UX is here

no scrollbar until the card is hovered
no scrollbar if speaker bio content length is less than card length.
scrollbar when speaker bio length exceeds card length and user hovers the card.

@mariobehling I have tried  orga-server UI as it is without scrollbar. The UI does not seems good to me to deal with large text. I have tried stress testing and the results are not so good. There is no check of overflow which I am explaining here with scrollbars. Please check snapshot in the condition the data is increased. I have tested this with some random data.
Stress Testing 1

Stress Testing 2

@mariobehling Solved in #562

done


fix(locales): updated translation from Crowdin

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error page Backend

@balasratran fixed in the commit bb86cc8
Please try again and let us know if you facing any other issues. Thanks for report the issue.


Cannot scroll to last item if has many items

first, thanks for you library it's very helpful for my work.
I have some issue when the container has lot of items. ( Ex. 50 items with 150px of width)
I look in the element inspector
this code
transform: translate3d(-1805.47%, 0px, 0px)
I guess it's always back to -1800%
how to increase?

Hello @khanitnanj,
Please provide a test case like a CodeSandbox or CodePen that clearly demonstrates the issue. I need this to understand the issue you're experiencing and in order to debug it.
Kindly,
David

Hi @davidcetinkaya
I've created a CodeSandbox
https://codesandbox.io/s/embla-carousel-react-basic-setup-0ky1p
This is what I found, but I have fixed on my project
The problem is

I set width for .content  to small box you can try at 300px
if .embla__slide I set the item width to 150px (flex: 0 0 150px)
I have items 50 items

it's will cannot scroll to the last item
but I fixed by changing some elements and and now on my project fixed.
Thank you for your super fast reply

Hello again @khanitnanj,
Thank you for the CodeSandbox, it helped me debug why you're experiencing this issue 👍.
Please use padding instead of margin for spacing between slides, like this example setup shows. Because Embla won't calculate the margins but the padding will be included when reading the slide widths if you use the border-box property as default like so:
html {
  box-sizing: border-box;
}

*,
*::before,
*::after {
  box-sizing: inherit;
}

Let me know if this helps!
Cheers
David

I'm closing this issue. Feel free to re-open it if you don't think it's resolved.
Thank you @khanitnanj!

Hi again @khanitnanj,
For what it’s worth, Embla Carousel now supports margin and any other means that will render spacing between your slides. You’re not forced to use the padding approach anymore. And it will automatically detect your spacings!
This feature was released with version 4.2.0. Read more about it here if you’re interested.
Kindly,
David


Add additionally functionality to contracts storage interface

Added unstable function seal_contains_storage which only checks for existence without reading the value.  ( fixes #10490 )
Added unstable function seal_take_storage behaves similarly to seal_get_storage but also deletes the value.
New unstable version of seal_set_storage returns the size of the overwritten value or u32::MAX.
New unstable version of seal_clear_storage returns the size of the overwritten value or u32::MAX.

Usually, I try to have a minimal API surface by not exposing functions that can be composed by calling multiple other functions. However, we want contracts that only need a simple mapping to be able to implement that without multiple calls into the contracts pallet.
Note
The weights make no sense because they assume that reading the length or checking for existence is possible in constant time with regard to the item size which is not the case. The benchmarks for seal_clear_storage and seal_contains_storage are using the maximum allowed item size and incur very high weights by doing so for this reason. This will be fixed in a PR that implements #10508.

/benchmark runtime pallet pallet_contracts

/benchmark runtime pallet pallet_contracts

/benchmark runtime pallet pallet_contracts

bot merge


API docs landing page

This change removes the API packages from the TOC and instead lists them on a single API Reference landing page, which has a language chooser to see the TS/JS vs. Python packages.
This largely just combines the existing two pages into a single combined page w/ lang chooser and eliminates the items from the TOC.
It could definitely be spruced up further, e.g.:

Adding logos for the "tier 1" clouds, possibly showing them like the Tutorials landing page, or having more of a separation between the mainline clouds and other providers
Listing the packages in 2 or 3 columns with nicer package-specific purple "bullet" like the bullets for APIs in #1669
Tighter copy at the top of the page

Fixes #1580

@bermudezmt, @lukehoban, is this along the lines of what you were thinking, or did you have something else in mind?


Document dollar sign and period use in a field name

What
This PR adds content to the documentation to explain the use of $ and . in field names.
Why
A user needs to understand the expected behavior of the query and indexing engine when naming fields.
How
Add a "Restrictions" sub-heading under the "Creating Indexes" heading to describe the behaviors of using a dollar sign as the first character in a field name and a period within a field name.
reviewer @mikerhodes
reviewer @gadamc
BugId: 47451

I'd be tempted to move this to above the "Creating Indexes" title, so nearer to the top. Then start with something like:

Query offers a powerful way to find documents within your datastore. There are a couple of restrictions on fieldnames you need to be aware of before using query:
And postfix with:
These come from Query's MongoDB heritage where these characters are not allowed in fieldnames, which we don't share. Hopefully we'll work around these restrictions in future.

Moved content to be under "Usage" heading.  Done in 8b0a3b9.

:+1:

+1


Updated Template with Content discussed and already there.

Thanks @sgoggins

Great iterative step :+1: -- we'll complete this eventually.


Memory leaks using Xamarin-IOS

Memory leaks using Xamarin.IOS
I have serious memory leaks with ReactUI.
I make a simple app to try to figure out the problem with this.
This app have 3 simples screens. 1- just have one UIBUtton for change to screenOne. 2- This screen have 3 button and 2 extra buttons for navigation (Back and go to last screen) 3- Have 4 buttons and one more to back.
All elements related with UIKit is disposed correctly, but not all reactive related.
I try everything to figure out what is wrong. I think the problem is between Reference counter of IOS and Garbage collector of Xamarin, but i cant confirm o refute this hipotesis.
The app source code is here: https://github.com/DrakorBofh/ReactiveIOSTest
This is a export of the app using the xamarin profiling tool:https://drive.google.com/file/d/0BwHPAEqsPcm5TjRhMVlONkl1ZEE/view?usp=sharing
In this file, i followed the following steps:
FirstScreen -> SecondScreen -> ThridScreen-> back to SecondScreen -> back to FirstScreen.
In all change of screen, the previous is disposed.
I Attached 3 screenshots of the Profiling tool with some examples.
This show the reference to some Viewmodels that must be disposed.

Paul, could you send us the quick fix for the KVOObservableForProperty you mentioned the other day?

A deeper analysis of memory leaks
I created incrementally an example to try to get all memory leaks.
The results:
ReactiveObject
ReactiveObject without any Properties or Commands.

ReactiveUI.IReactivePropertyChangedEventArgs
ReactiveUI.IReactiveObjectExtensions.ExtensionState
ReactiveUI.IreactivePropertyChangedEventArgs
System.Collections.Generic.ObjectEqualityComparer
System.Reactive.DisposedObserver
System.Reactive.DoneObserver
System.Reactive.NopObserver

ReactiveObject + RaiseAndSetIfChanged

The following classes, will be instanced for each view model used
System.Reactive.NopObserver<ReactiveUI.IReactivePropertyChangedEventArgs
System.Func<ReactiveUI.IReactivePropertyChangedEventArgs
System.Func<SystemCollections.Generic.IList<ReactiveUI.IreactivePropertyChangedEventArgs

ReactiveView

ReactiveView without any ViewModel or bindings.
ReactiveUI.AppSupportJsonSuspensionDriver
ReactiveUI.CanActivateViewFetcher
ReactiveUI.CocoaDefaultPropertyBinding
ReactiveUI.ComponentModelTypeConverter
ReactiveUI.CreatesCommmandBindingViaCommandParameter
ReactiveUI.CreatesCommandBindingViaEvent
ReactiveUI.DateTimeNSDateConverter
ReactiveUI.DefaultVideLocator
ReactiveUI.EqualityTypeConverter
ReactiveUI.ExpressionRewriter
ReactiveUI.FlexibleCommandBinder.CommandBindingInfo
ReactiveUI.INPCObservableForProperty
ReactiveUI.IROObservableForProperty
ReactiveUI.KVOObservableForProperty
ReactiveUI.KVOObservableForProperty.c_AnonStorey1
ReactiveUI.NSRunloopScheduler
ReactiveUI.NSRunloopScheduler.c_AnonStorey0<System.Action>
ReactiveUI.NullDefaultPropertyBindingProvider
ReactiveUI.PlafotmOperations
ReactiveUI.POCOObservableForProperty
ReactiveUI.ReactiveCommand<System.Exception>
ReactiveUI.StringConverter
ReactiveUI.SuspensionHost
ReactiveUI.UIKitcommandBinder
ReactiveUI.UIKitObservableForProperty
ReactiveUI.UIKitObservableForPropertyBase.ObservablePropertyInfo
ReactiveUI.WaitForDispatcherScheduler
System.Reactive.Subjects.ConnectableObservable<System.Boolean, System.Boolean>
System.Reactive.Subjects.ReplaySubject.ReplayOne<System.IObservable<System.IDisposable>>
System.Reactive.Subjects.ReplaySubject.ReplayOne<System.IObservable<System.Reactive.Unit>>
System.Reactive.Subjects.ReplaySubject<System.IObservable<System.IDisposable>>
System.Reactive.Subjects.ReplaySubject<System.IObservable<System.Reactive.Unit>>
System.Reactive.Subjects.Subject.Subscription<System.Exception>
System.Reactive.Subjects.Subject.Subscription<System.Reactive.EventPattern<System.EventArgs>>
System.Reactive.Subjects.Subject<System.Boolean>
System.Reactive.Subjects.Subject<System.Exception>
System.Reactive.Subjects.Subject<System.Object>
System.Reactive.Subjects.Subject<System.Reactive.EventPattern<System.EventArgs>>
System.Reactive.Subjects.Subject<System.Reactive.Unit>

ReactiveView + IViewFor

ReactiveUI.WeakEventManager<ReactiveUI.INotifyPropertyChanging, ReactiveUI.PropertyChangingEventHandler, ReactiveUI.PropertuChangingEventArgs>
ReactiveUI.WeakEventManager<System.ComponentModel.INotifyPropertyChanged, System.ComponentModel.PropertyChangedEventHandler, System.CompoenentModel.PropertyChangedEventArgs>

OneWayBind
No extra memory leaks
BindCommand
No extra memory leaks
WhenAnyValue
No extra memory leaks
ReactiveCommand.Subscribe()
No extra memory leaks

A deeper analysis of memory leaks
I created incrementally an example to try to get all memory leaks.
The results:
ReactiveObject
ReactiveObject without any Properties or Commands.

ReactiveUI.AppSupportJsonSuspensionDriver
ReactiveUI.CanActivateViewFetcher
ReactiveUI.CocoaDefaultPropertyBinding
ReactiveUI.ComponentModelTypeConverter
ReactiveUI.CreatesCommmandBindingViaCommandParameter
ReactiveUI.CreatesCommandBindingViaEvent
ReactiveUI.DateTimeNSDateConverter
ReactiveUI.DefaultVideLocator
ReactiveUI.EqualityTypeConverter
ReactiveUI.ExpressionRewriter
ReactiveUI.FlexibleCommandBinder.CommandBindingInfo
ReactiveUI.INPCObservableForProperty
ReactiveUI.IROObservableForProperty
ReactiveUI.KVOObservableForProperty
ReactiveUI.KVOObservableForProperty.c_AnonStorey1
ReactiveUI.NSRunloopScheduler
ReactiveUI.NSRunloopScheduler.c_AnonStorey0<System.Action>
ReactiveUI.NullDefaultPropertyBindingProvider
ReactiveUI.PlafotmOperations
ReactiveUI.POCOObservableForProperty
ReactiveUI.ReactiveCommand<System.Exception>
ReactiveUI.StringConverter
ReactiveUI.SuspensionHost
ReactiveUI.UIKitcommandBinder
ReactiveUI.UIKitObservableForProperty
ReactiveUI.UIKitObservableForPropertyBase.ObservablePropertyInfo
ReactiveUI.WaitForDispatcherScheduler

ReactiveObject + RaiseAndSetIfChanged

ReactiveUI.WeakEventManager<ReactiveUI.INotifyPropertyChanging, ReactiveUI.PropertyChangingEventHandler, ReactiveUI.PropertuChangingEventArgs>
ReactiveUI.WeakEventManager<System.ComponentModel.INotifyPropertyChanged, System.ComponentModel.PropertyChangedEventHandler, System.CompoenentModel.PropertyChangedEvent

ReactiveView
ReactiveView without any ViewModel or bindings.

System.Reactive.Subjects.ConnectableObservable<System.Boolean, System.Boolean>
System.Reactive.Subjects.ReplaySubject.ReplayOne<System.IObservable<System.IDisposable>>
System.Reactive.Subjects.ReplaySubject.ReplayOne<System.IObservable<System.Reactive.Unit>>
System.Reactive.Subjects.ReplaySubject<System.IObservable<System.IDisposable>>
System.Reactive.Subjects.ReplaySubject<System.IObservable<System.Reactive.Unit>>
System.Reactive.Subjects.Subject.Subscription<System.Exception>
System.Reactive.Subjects.Subject.Subscription<System.Reactive.EventPattern<System.EventArgs>>
System.Reactive.Subjects.Subject<System.Boolean>
System.Reactive.Subjects.Subject<System.Exception>
System.Reactive.Subjects.Subject<System.Object>
System.Reactive.Subjects.Subject<System.Reactive.EventPattern<System.EventArgs>>
System.Reactive.Subjects.Subject<System.Reactive.Unit>

ReactiveView + IViewFor

System.Func

BindCommand

ReactiveUI.ViewForMixins
ReactiveU.WeakEventManager
ReactiveUI.IreactivePropertyChangedEventArgs
ReactiveUI.IReactiveObjectExtensions.ExtensionState
ReactiveUI.IreactivePropertyChangedEventArgs

OneWayBind
No extra memory leaks
WhenAnyValue
No extra memory leaks
ReactiveCommand.Subscribe()
No extra memory leaks

Dismiss all of this, everything works fine

We did it!


Add option to set ColorChoice globally for [e]print[ln]?

I'm running into a situation now where I am adding a --color flag to my CLI to control color output. Currently the bunt docs recommend using write! with a custom stream then. And sure, it works, but I now want all my bunt calls to respect that color choice. So maybe it makes sense to add an ability to change the global color choice?

Implemented in dcf2588d8a82f50b03963781db9c049ae4626524 and released as 0.2.7


HL2 Best Practices

There's still some remaining recommendations for OpenXR performance I haven't gotten to for StereoKit. Don't need to get them all in for 0.1, just need to review and snag the low hanging fruit for now.
Recommendations are all here:
https://github.com/microsoft/OpenXR-SDK-VisualStudio#understand-openxr-samples-and-best-practices-for-hololens-2

Heads up that we just refined the recommendations there, including fixing up the recommended pixel format to be DXGI_FORMAT_B8G8R8A8_UNORM_SRGB, which is more optimal for performance on HoloLens 2 than linear formats. (avoids a copy)  Be sure you've got a gamma-correct render pipeline as you switch from linear to _SRGB here.

Thanks for the heads up! :)

Moving last remaining item, depth sharing, to v0.2:
https://github.com/maluoi/StereoKit/issues/38


How does the model perform on CurveLanes datasets?

Great and meaningful work！From the results of the paper，the lane line detection fits well，I consider that the advantage of this model lies in  the curve lanes’ prediction, so I can't wait to  see how it performs on the CurveLanes dataset , which has more complex and large curvature lanes compared to the TuSimple dataset. I am glad to provide a little help as much as I can.

Thanks for your interest and affirmation!
I'm also looking forward to seeing how it performs on more complex datasets. Feel free to pull requests after the code is public.

@liuruijin17 is there any plan on when will code public?

Thanks for your patience, codes have been public  @jinfagang .

@jinfagang Have you ever tested lstr on curvelanes? On culane, it is not promising....

@pandamax  @lucasjinreal  @jinfagang  @Starboy-at-earth
Have you ever tested lstr on curvelanes? 😆 Looking forward to your reply !

Thanks for your patience, codes have been public @jinfagang .

Hi，Rui jin, very nice work, I would like to ask if I want to test LSTR on Curvelanes, would it be better to convert Curvelanes to Tusimple format or to CULane, as I see that LSTR supports both datasets!


feat(type): added BitBool

Changes

added BitBool for mysql bit type

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5c8db0c) 62.29% compared to head (a922eaa) 61.47%.

:exclamation: Current head a922eaa differs from pull request most recent head b42b436. Consider uploading reports for the commit b42b436 to get more accurate results

Files
Patch %
Lines

bitbool.go
0.00%
13 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   62.29%   61.47%   -0.82%
==========================================
  Files          21       22       +1
  Lines         976      989      +13
==========================================
  Hits          608      608
- Misses        292      305      +13
  Partials       76       76

Flag
Coverage Δ

Unit-Tests
61.47% <0.00%> (-0.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SEO: Add missing description metadata

Many of the authentication and authorization docs have empty values for the description metadata field.

I have the group done for the security/dataprotection/configuration group of topics. I plan to have it in tomorrow (Thursday morning or early afternoon).


Add build status

Screenshot of what it looks like:

Sorry about the delay here — this is pretty cool! Could you share a screenshot?

@ekmartin I need a new review before this stuff can get merged but I'm also considering adding the icons to this repo as well as adding instructions on how to add slack emoji to the setup instructions as the default ones look pretty bad.
At which point I think setup might be easier if instead of an emoji i make it a url to an image hosted somewhere

@ekmartin yeah i guess Review required permission is still set even for collaborators.

hey @ekmartin I have a lot of plans for stuff I want to do with this repo, and you have the primo pip slug so I'd rather continue the project, would you consider moving this repo to an open source org like https://jazzband.co/ and adding me as a maintainer?  Otherwise I'll be starting my own fork.

If we can find a set of default emojis that look alright here I'd prefer not having configuration options for this at all. Opinionated is usually better than overly configurable and I think it's worth trying to keep the options to a minimum.
Regarding the maintainer question: I added you as a collaborator a while back, but it says it's awaiting your response. With that being said, I still prefer that all changes go through a pull request reviewed by at least one person. I'd definitely be open to moving the project to something like Jazzband, but I don't think that would change anything in terms of reviews and merging code — it would also definitely need things like tests first to follow the Jazzband guidelines.

Yea, you're right, this may be too much customizability.... hadn't thought of that.


[PROPOSAL] Heading row formatting

Description
It would be good if one could make the header row on an export bold, for visual differentiation from the results.
Example
The export heading row will be bold

It's possible to add styling to cells. Please have a look here.


rkt: deduplicate images on image removal

Resolve and deduplicate all images before removing them to prevent
unnecessary error messages.
Fixes #1779

Could you extend the functional tests with similar scenarios I wrote in #1779? You probably could get away with a single image instead of four, but call rkt image rm <image_name> <image_hash> and rkt image rm <image_hash> <image_name>.
Thanks.

Fixed comments and added tests.

Some nits, buts LFAD otherwise. There is a bit of duplication in functional test, but this could be addressed in a separate issue/PR.

The image removal tests have been simplified.

Forgot to merge it, sorry. LFAD.


Extract resource name for http filters

Purpose
The resourceNode.name.value is evaluated as the resource name concatenated with the accessor and $ symbols. In order to engage HTTP filters, the exact resource name should be desugard in to the HTTP filter context.
Example 1:
resource function get sayHello is evaluated as "$get$sayHello" and converted by the PR as "sayHello"
Example 2:
resource function myAccessor sayHello is evaluated as "$myAccessor$sayHello" and converted by the PR as "sayHello"
Example 3:
resource function my\$Accessor say\$Hello is evaluated as "$my\$Accessor$say\$Hello" and converted by the PR as "sayHello"
Related to https://github.com/ballerina-platform/ballerina-lang/pull/27820
Related to https://github.com/ballerina-platform/ballerina-standard-library/issues/584
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

The resourceNode.name.value is evaluating is correct according to the new service type changes. It should be fixed at ballerina/reflect module.
Related issue: https://github.com/ballerina-platform/ballerina-standard-library/issues/837

The resourceNode.name.value is evaluating is correct according to the new service type changes. It should be fixed at ballerina/reflect module.
Related issue: https://github.com/ballerina-platform/ballerina-standard-library/issues/837


Kotlin Emitter

Hey!
We @smartsquaregmbh are currently working on scaling our socket.io infrastructure. Because the java emitter implementation seems to be unmaintained and broken we're working on a kotlin emitter. It would be great if you want to list this in the implementation section. :)
https://github.com/SmartsquareGmbH/socket-io-redis-emitter
The project is heavily work in progress at the moment.

I've just added the example directory which contains a working docker-compose setup.

Hey @darrachequesne! I came across this again and think the library is now stable enough. Would you be open to adding it to the repository’s README? (cc @rubengees) 😊


panic: runtime error: invalid memory address or nil pointer dereference

I am facing this issue when converting the docker-compose.yml file . It is a straighforward compose file with couple of volume mounts and no env variables.
Kompose version : kompose version 0.1.0 (8227684)
Error:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x18 pc=0xbbff5c]
goroutine 1 [running]:
panic(0x15a9b60, 0xc82000e0e0)
/usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project.(*Project).handleNetworkConfig(0xc8201762a0)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project/project.go:254 +0x26c
github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project.(*Project).load(0xc8201762a0, 0xc820355c40, 0x12, 0xc8201e4800, 0x4c3, 0x6c3, 0x0, 0x0)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project/project.go:209 +0x638
github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project.(*Project).Parse(0xc8201762a0, 0x0, 0x0)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/vendor/github.com/docker/libcompose/project/project.go:87 +0x335
github.com/skippbox/kompose/pkg/loader/compose.(*Compose).LoadFile(0x22db590, 0xc820355c40, 0x12, 0x0)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/pkg/loader/compose/compose.go:121 +0x52f
github.com/skippbox/kompose/cli/app.Convert(0xc8202e1400)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/cli/app/app.go:145 +0x4e8
github.com/skippbox/kompose/cli/command.ConvertCommand.func1(0xc8202e1400)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/cli/command/command.go:32 +0x21
github.com/skippbox/kompose/vendor/github.com/urfave/cli.Command.Run(0x1811338, 0x7, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc8203947d0, 0x4b, 0x0, ...)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/vendor/github.com/urfave/cli/command.go:179 +0x1399
github.com/skippbox/kompose/vendor/github.com/urfave/cli.(*App).Run(0xc8203c2840, 0xc82000a140, 0x4, 0x4, 0x0, 0x0)
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/vendor/github.com/urfave/cli/app.go:196 +0x137c
main.main()
/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/cli/main/main.go:47 +0x33b

Hi @beravelli
from trace you posted it looks like issue with libcompose, during parsing network definition.
Can you please show docker-compose file that you used, or at least snippet of it with network definitions?

Hi kadel,
networks:
- incubator
networks:
incubator:

It works it I take out the networks and volumes section in the docker-compose.yml file

@beravelli network definition was improved with this recent PR https://github.com/skippbox/kompose/pull/195. We will soon publish new release included this fix. Right now could you try getting kompose HEAD and test with your compose file?

Similar issue: https://github.com/skippbox/kompose/issues/149

close via #195


Julia implementations?

Would you be interested in some Julia comparisons (e.g. DataFrames.jl, TidierData.jl)? If you are I'm happy to write them!

@rdboyes I think that's a great idea!


Failed to run on the given Interpreter: Regular TensorFlow ops are not supported by this interpreter. Make sure you apply/link the Flex delegate before inference.     Node number 62011 (FlexSize) failed to prepare.

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): pip install tf-nightly
TensorFlow version (or github SHA if from source):
2.4.0-dev20200916

Provide the text output from tflite_convert
For Android Studio project that gives the following error:
java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: Regular TensorFlow ops are not supported by this interpreter. Make sure you apply/link the Flex delegate before inference.
Node number 62011 (FlexSize) failed to prepare.
    at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
    at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:163)
    at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:360)
    at edu.ilab.covid_id.localize.tflite.TFLiteObjectDetectionAPIModel.recognizeImage(TFLiteObjectDetectionAPIModel.java:202)
    at edu.ilab.covid_id.ir.ConnectFlirActivity$7.run(ConnectFlirActivity.java:673)
    at android.os.Handler.handleCallback(Handler.java:789)
    at android.os.Handler.dispatchMessage(Handler.java:98)
    at android.os.Looper.loop(Looper.java:164)
    at android.os.HandlerThread.run(HandlerThread.java:65)

# Copy and paste here

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem.
If including tracebacks, please include the full traceback. Large logs and files
should be attached.
Here is the colab used to convert the saved model to tflite
https://colab.research.google.com/drive/1_9l_DcyNuVV1NxU3PsmSMjWeI9nTEwNS?usp=sharing
Here is the drive with the saved model to tflite
https://drive.google.com/drive/folders/1MCvDti2ygukqw6fGE18WpnFOSzR_AanF?usp=sharing
Here is the java code which uses the tflite model
ConnectFlirActivity.zip

I think the above android application does not have Select TF ops. You can follow the below guides to add the Select TF ops:
https://www.tensorflow.org/lite/guide/ops_select#android_aar
https://www.tensorflow.org/lite/guide/reduce_binary_size

No, it has TF ops


Patch release

non-breaking patch release

[x] add functionalities to generate foo data (PR #136 and #155, issue #118)
[x] export coerce! (PR #155, issue #149)
[x] stratified sampling for partition (PR #138, issue #113)
[x] minor improvements for cross entropy and briers score (PR #148)
[x] improve performance of selectrows for DataFrames and julia native tables (PR #154)

Codecov Report

Merging #156 into master will increase coverage by 0.85%.
The diff coverage is 94.47%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   81.47%   82.33%   +0.85%
==========================================
  Files          28       29       +1
  Lines        1663     1806     +143
==========================================
+ Hits         1355     1487     +132
- Misses        308      319      +11

Impacted Files
Coverage Δ

src/measures/measures.jl
71.79% <ø> (-1.38%)
:arrow_down:

src/MLJBase.jl
78.94% <ø> (ø)
:arrow_up:

src/utilities.jl
100% <100%> (ø)
:arrow_up:

src/tasks.jl
81.94% <100%> (-2.57%)
:arrow_down:

src/data.jl
92.51% <90.56%> (-2.08%)
:arrow_down:

src/datasets_synthetic.jl
95.95% <95.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0a7f3...3c90fa0. Read the comment docs.

green flags everywhere, just the stuff we love.


Finish documentation and JSON schemas

This is a critical issue for Beta 5.0.
In folders /doc/game and /schemas you can find some examples of already documented parts of a game.
All the files need to be included in order to produce a full game documentation.
How can you help?
Explore the example game files and try to make JSON schemas for them. If you are unsure about what a given parameter serves for, ask here. I'll be glad to help.

This has been completed some time ago.


Request body

Validator will return a warning for requestBody content objects with multiple schemas.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Samer Jaser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

We don't actually want to validate for this


Regex search and replace hangs when trying to enter \n

I have a 17MB file and when I search for tab (\t) and replace with another character, the app FLIES!!! Totally surprised.
But, if I try and search for a new line character (\n), it hangs as I press the "n" character. So I get the backslash character in, but I don't actually see the letter "n", the app hangs before it's "drawn" to screen.

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

project-manager
ale
0.23.0

xml
Dot
1.9.2

tortoise-svn
fan
0.1.1

auto-close-tag
for
0.5.5

Angular2
joh
2.11.2

qub-xml-vscode
qub
1.2.8

java
red
0.15.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

I can confirm this is also happening on
Ubuntu 17.10 4.13.0-32-generic #35-Ubuntu
VScode Version 1.20.0

Although I was able to search and replace a \n regex easily (to remove every empty line of a file, specific regex was ^\n, I also have a problem with a \n-related regex search: /\*(.*\n?)*\*/.

Pasting the regex immediately hangs VS Code, and a window appears after a few seconds, suggesting to reopen the window.
Typing the regex manually will hang when typing the fourth * character specifically (I reproduced it many times to make sure it was this specific character hanging), so: /\*(.*\n?)*\ works, then as you type the * right after that, it hangs.

This is on VS Code 1.21.1, on Windows 10, both x64.

I am having a similar problem when using search and replace.
my search regex is as follows:
^  <%- if (.*\n.*){2,5} <%- end -%>$

which consistenly hangs vscode. The file I am searching within is 26 lines long (very small file).
basic regex with \n work fine, but anything slightly complex results in crashes

When we have backtracking in the regex, or a normal regex when the file content is really large, VSCode will freeze as we run the search in the main thread. Duplicate of https://github.com/Microsoft/vscode/issues/30874, let's track it there. We should probably search async in a worker if the model is available in the worker.


Read minimal things from excel sheet, and read them fast

Only want to know the number of sheets, and the first row for each sheet to figure out the fields.
This is very slow since it seems to read everything: DataSet result = excelReader.AsDataSet();
Code:
IExcelDataReader excelReader = ExcelReaderFactory.CreateOpenXmlReader(new MemoryStream(stream));
excelReader.IsFirstRowAsColumnNames = true;
DataSet result = excelReader.AsDataSet();
Any way to get around this, to load only the sheet info + 1st row into memory so that this operation is fast.

Use IExcelDataReader.Read, IExcelDataReader .NextResult and IExcelDataReader.ResultsCount instead.

That works. Awesome. Thanks a ton.


Add a Site Name field to the Publish to GCE dialog.

Change the way we deploy a project to a GCE VM.
Fix #944

Closing this to make separate PRs.


fix yaml deprecation warnings

Using a colon after an unquoted mapping key that is not followed by an indication character (i.e. " ", ",", "[", "]", "{", "}") is deprecated since version 3.2 and will throw a ParseException in 4.0.

Hi @qtsd! Thanks a lot for your contribution, we really appreciate it :smile:
I will merge this pull request and create a new tag so you can benefit from your commit immediately.
Have a great day!


Simplify SHA1/MD5 fingerprint generators

Remove the very curious usage of '[:]', which was used because the hex
function requires []byte, but md5/sha1.Sum give you [Size]byte, and
[:] will return []byte.
Stop iterating through the bytes to construct the colonized string;
use fmt.Sprintf("% x", data) as shown in Golang docs (and replace the
spaces with colons): https://play.golang.org/p/e7W5FVB-hW

Great, thanks, @krishicks! Looks much simpler! Does the strings.Replace/fmt.Sprintf combo deserve extraction into its own private helper function?
Best,
Eric

@ematpl Updated.


Skype Error: internal channel failure

In last few days I sometimes get the following message (I think since I updated to 3.5.5):
“There was an error completing this request due to an internal channel failure.”
It appears only on skype. Facebook Messenger seems to work fine.
Does anyone know what this means?

Tips to troubleshoot and consider attaching a debugger or using App Insights to get more details.

@Noc2 Could you please share your bot msa app id, and I will search backend logs for errors. Thank you!

Microsoft App ID is 64ba2a82-af90-43f0-8aea-42a95405a1ba
Since a few days I’m using App Insights, but I couldn’t determine the exact source of the problem.
I’m currently rewriting a lot of the code of my bot. I hope that will improve the performance and solve this problem.
At the beginning, I came up with my own solution for multiple dialogs, state, and IScorable, which probably wasn’t a good idea ;-).

@Noc2 Could you please also share what kind of request and payload did you try to send?

Thanks. Problem seems to be solved.

Since the last week, I have this issue again. After some further testing with ngrok, I think the problem appears when Request.CreateResponse(HttpStatusCode.OK) isn’t send in a certain time window (around 10 seconds, probably because of slow API calls).
Getting another error message, in this case, might be helpful.

I am having the same issue. Getting the message There was an error completing this request due to an internal channel failure.
I am using ngrok to debug my bot code at the ngrok endpoint OPTIONS /api/messages is being invoked instead on POST/api/messages. Any help?


Can bus dependency removal

How to remove can bus dependency from BEVFormer (from training and inference both)?

Setting use_can_bus=False. It should remove the can_bus embedding layer.


Stack Data Structure

Problem Statement :
Implementation of stack Data Structure using arrays (Static Memory allocation ).
I will do this in C  .
Please assign it me under DCP'21.

/assign


Not solving the optimization model with the SCIP solver

Hello. I have successfully installed the SCIP solver on Windows 10 and on Julia and on a Jupiter notebook. But when I try to solve my model, I face the following problem (according to the picture):
Please note that this same model is easily solved by all my other solvers like Gurobi, CBC and GLPK without such error!

Solved the same model with Gurobi solver! please guide me:

Hello, did you install SCIP separately from the Julia package?
See the instructions here: https://github.com/scipopt/SCIP.jl#custom-installations

Dear Mathieu Besançon @matbesancon
Yes I have installed the latest version of SCIP separately.

Can you do "using SCIP" in a Julia session and see if it also kills the session?
I would invite you to check the other issues opened for Windows:
https://github.com/scipopt/SCIP.jl/issues?q=is%3Aissue+Windows+

Yes I easily do this command "using SCIP" and there are no errors. Only by defining the variables and solving the problem you will get the mentioned error.
Please see the figure below: The command "optimize!(model)" that I type faces the problem of solving.

Does anyone know where the problem is?

Can you try:
o = SCIP.Optimizer()

Dear @matbesancon
Which line should I replace this command with? My model is below:
using JuMP, SCIP
model = Model(SCIP.Optimizer)
set_attribute(model, "display/verblevel", 0)
set_attribute(model, "limits/gap", 0.05)
@variable((model), x);
@variable((model), y);
@objective((model), Min, (x) + (y));
@constraint((model), x >= 0)
@constraint((model), y >= 5)
optimize!(model)
println(value.(x))
println(value.(y))

Just
using SCIP
@show @eval SCIP libscip
o = SCIP.Optimizer()
As an alternative attempt, please run the code that you already have but
without the line setting verblevel to 0. You can do both.
Thanks!
On Thu, Nov 16, 2023, 06:30 Hossein @.***> wrote:

Dear @matbesancon https://github.com/matbesancon
Which line should I replace this command with? My model is below:
using JuMP, SCIP
model = Model(SCIP.Optimizer)
set_attribute(model, "display/verblevel", 0)
set_attribute(model, "limits/gap", 0.05)
@variable((model), x);
@variable((model), y);
@objective((model), Min, (x) + (y));
@constraint((model), x >= 0)
@constraint((model), y >= 5)
optimize!(model)
println(value.(x))
println(value.(y))
—
Reply to this email directly, view it on GitHub
https://github.com/scipopt/SCIP.jl/issues/281#issuecomment-1813814415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2FDMSBZGRBUIQE76POZMLYEWQGTAVCNFSM6AAAAAA7M263MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTHAYTINBRGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

The path of libscip is in .julia/artifacts, which means SCIP was not installed or recognized.
Please follow the similar steps as in this issue: https://github.com/scipopt/SCIP.jl/issues/248

The problem was solved. Thanks.