Blocking untill the end of the response?

Hello,
I am not sure if this is a bug, or a mistake from my end.
I am trying the streaming api in the following:
    pub fn retrieve_response_async(
        param: ReportDeps,
        content: Arc<Mutex<String>>,
        toasts: Arc<Mutex<Toasts>>,
        boolean_flag: Arc<AtomicBool>,
    ) {
        let flag = boolean_flag.clone();
        let url = "http://<IP_ADDRESS>:8000/reportstream";
        let request = ehttp::Request::post(url, serde_json::to_vec(&param).unwrap());

        ehttp::streaming::fetch(
            request,
            move |result: ehttp::Result<ehttp::streaming::Part>| {
                let part = match result {
                    Ok(part) => part,
                    Err(err) => {
                        boolean_flag
                            .clone()
                            .store(false, std::sync::atomic::Ordering::Relaxed);
                        toasts
                            .lock()
                            .error(format!("An error occurred while streaming `{url}`: {err}"));
                        return std::ops::ControlFlow::Break(());
                    }
                };

                match part {
                    ehttp::streaming::Part::Response(response) => {
                        tracing::info!("RESPONSE");
                        println!("Status code: {:?}", response.status);
                        if response.ok {
                            std::ops::ControlFlow::Continue(())
                        } else {
                            boolean_flag.store(false, std::sync::atomic::Ordering::Relaxed);
                            toasts.lock().error(format!(
                                "An error occured, please try again: {}",
                                response.status_text
                            ));
                            std::ops::ControlFlow::Break(())
                        }
                    }
                    ehttp::streaming::Part::Chunk(chunk) => {
                        if chunk.is_empty() {
                            flag.clone()
                                .store(false, std::sync::atomic::Ordering::Relaxed);
                            std::ops::ControlFlow::Break(())
                        } else {
                            let chunk = String::from_utf8(chunk).unwrap();
                            tracing::info!("{:?}", chunk);
                            content.lock().push_str(&chunk);
                            std::ops::ControlFlow::Continue(())
                        }
                    }
                }
            },
        );
    }

As of current, this is only resolving after the request has completed. Note that I'm using a streaming response from actix:

#[post("/reportstream")]
pub async fn report(payload: web::Payload) -> impl Responder {
    let ReportDeps {
        doctor_input,
        age,
        name,
        sex,
        date,
    } = type_cast::<ReportDeps>(payload).await;

    let (mut tx, rx) = futures::channel::mpsc::unbounded::<
        std::result::Result<actix_web::web::Bytes, std::io::Error>,
    >();

    let mut result = client.chat().create_stream(request).await.unwrap();

    tokio::task::spawn(async move {
        while let Some(message) = result.next().await {
            let message = match message {
                Ok(message) => {
                    if let Some(message) = message.choices[0].delta.content.clone() {
                        message.clone()
                    } else {
                        String::new()
                    }
                }
                Err(e) => e.to_string(),
            };
            let _ = tx.start_send(Ok(Bytes::from(message)));
        }
    });
   /// This works and results in a streamed response
    HttpResponse::Ok().streaming(rx)
}

As you see, the response is coming in, but its chunks are not being handled as they are coming in, instead, the streaming api is waiting until the end of the response.
Note that curl --no-buffer "<IP_ADDRESS>:8000/reportstream" gives a chunked response.

I find this hard to follow. You log the response with tracing::info!("RESPONSE");, and each chunk with tracing::info!("{:?}", chunk);, yet none of these show up in the log you pasted. Maybe silence the spam form h2?
@jprochazk wrote the chunk code, maybe he has some ideas

Ok,
I'll try to rephrase the original post.
I have a client-server combo.
The client is written in egui and compiles to wasm via trunk.
The server endpoint I'm hitting results in a streaming response using actix (https://docs.rs/actix-web/latest/actix_web/struct.HttpResponseBuilder.html#method.streaming).
Normally, when I use an alternative client such as curl, I can get the response chunk by chunk.
When I use ehttp::streaming via either Chrome or Firefox, the request does not print chunk by chunk, but instead waits for the completion of the request and handles it as one big chunk.

This still needs a minimal reproduction. Without any code to run, there's little we can do to help.
On the web, ehttp::streaming it calls the same functions in the same order as the following JS code:
function fetch_streaming(request, on_part) {
    fetch(request)
        .then(async (response) => {
            on_part({ response: new Response(null, response) });
            const reader = new ReadableStreamDefaultReader(response.body);
            while (result = await reader.read(), !result.done) {
                on_part({ chunk: result.value });
            }
            on_part({ chunk: new Uint8Array() });
        })
}

const URL = "https://example.org";
fetch_streaming(
    URL,
    (part) => {
        const { response, chunk } = part;
        if (response) {
            console.log(`status: ${response.status}`);
        } else {
            if (chunk.length === 0) return console.log("done");
            console.log("chunk", chunk);
        }
    }
);

You can test your server against this snippet to see if the streaming response also works on the web.

Hello,
As requested, I have prepared a mvp via eframe on https://github.com/MinaMatta98/Demo-Debug .
The expected behaviour is that as each chunk comes in, it will append to the string, but this is deferred until the finalization of the call.

If you wanted to see what the expected output would be, look at this link:
https://github.com/emilk/ehttp/assets/81748812/ed71b386-3ef8-4d63-bb3a-34b8a4dfe772
Note that was via the exact same server endpoint being used in the mvp product above.

This isn't an issue with ehttp. You need to:

Not use any compression in the reportstream route
Call ctx.request_repaint() in the ehttp::streaming::fetch callback

https://github.com/MinaMatta98/Demo-Debug/pull/1
https://github.com/emilk/ehttp/assets/1665677/60246978-1d91-43a1-a1f0-16ea0a439c24

Hello,
Thank you very much.
I apologize, as I was under the impression that this was an ehttp problem. Thank you for your assistance.
Could you please provide some information as to why compression should be disabled?


Update code for Create resource group article in python SDK example code. Replaces AzureCliCredential with DefaultAzureCredential.

Article PR: https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/5523
Work item:  https://dev.azure.com/msft-skilling/Content/_workitems/edit/222521

@bobtabor-msft Please have a look at the associated article PR (in description). If it looks good, then please merge this PR. Please note the timing issues in the comments for the article PR. Also, be aware that the code will not show up when reviewing the article PR as it is pulled from main.


Rekey identification with fix

This fixes the flake encountered after the merge.

Revert the revert
Handle the case where we rekey and there was a logic race (the other code paths are ok)
Will be merged after Jenkins passes three times as to avoid flakes

3 runs of Jenkins have passed green.

Appveyor not related.


Provide rendering context to plugin directives

Proposal
I am using myst to write a paper asynchronously with a few people, and during the drafting phase it would be nice to be able to write a mention directive where we can make notes that mention another author - e.g. i'm writing a draft section, and i want to ask another author to check me on something, or to assign some section to someone else. Then I would like to make a second directive like a mentionsList where I can render all the mentions in one place.
This is reminiscent of the canonical "Developing a TODO extension" for sphinx.
This is also a general pattern, where one might want to have a directive that can be aware of and use nodes that are outside of its argument and body, or in another document entirely. Searching i found this prior issue re: bloglike/gallery behavior, and one could see how it might be nice to keep bloglike functionality in-universe with existing myst concepts by just having a blogpost directive that can render a list of posts by having access to the render context: https://github.com/jupyter-book/mystmd/issues/840
other examples include indexes, backlinks/wikilinks/etc.
Some approaches
this might be trickier than it seems, i have not yet taken a deep look at the myst rendering process and am raising this first as a feasibility check.
There's the basic issue of timing - when does the directive get called. it would probably be massively overcomplicating if one had to pause the render, leave a placeholder, render everything else, and then at the end render all custom directives. then there's perf, where needing to copy and pass an entire humongous document through standard streams, parse, etc. when doing any minor incremental build of a single page. and so on
But some possible approaches, lmk which of these might be appealing, if any, and i'd be happy to collaborate on a patch.
Build Phase Hooks - this is probably the most complex to get right, but most flexible approach. a cheap and easy version would be just to add a hook method between the tokenizing phase before the directives are applied where a plugin could modify the tree and inject the information it needed into the unprocessed directive. that would be probably pretty tricky to write and error prone without a lot of helpers, but it would be extremely general.
Pass the whole AST to a directive that requests it in its spec - easy but expensive, especially with larger multipage documents.
Dependencies between directives - it could be possible to just declare that one directive must be applied after all the directives of another type/name have been processed. Then you could pass only those directives that the dependent directive has requested to it as context. This would be intuitive to write, probably more performant, but a little fragile because as far as i'm aware there isn't any namespacing for directives, which would be a problem if someone was using a bunch of 3rd party plugins that weren't mutually deconflicted. It would be relatively easy to implement, just topo sort the directive nodes by dependencies.
Events/listeners - Another case aside from a big index directive might be one that wants to be dependent on the value from a neighboring directive. So that same dependencies idea from above at a type level could be applied at the instance level, where a directive could declare itself an emitter of an event type, and another could declare itself a listener for an event type. So in the case of global indexing-style directives, you just have a single key, but then you have a superset of behavior where pairs/groups of heterogeneous directives can depend on one another and reuse values. This would probably be on the more complex side of things to implement, but it would be ~ cool ~ and probably ~ overengineered ~.
Phased directives - this is probably way less desirable, but instead of build phase hooks one could also imagine having an enum in directives that allow them to declare that they should be rendered at a particular point in the build phase. just listing options, i don't think this is a particularly good one.
Additional notes
Anyway just sketching, hopefully i made the distinction between the actual pitch/need and the potential ideas part clear enough. "i want to be able to have context-aware directives and there are a bunch of different ways that could happen and i want to help out with the one you like" is what i'm going for here, so lmk ttyl <3

There is something that is pretty close to your use case here:
https://github.com/myst-ext/myst-ext-points/blob/main/extension.mjs
This defines a points role and pointReport directive, and then a transform to make sure they are in sync. The initial parsing is completed by directives and roles, and they leave a specific type (or subtype) of a node that can be transformed later in the process. The transform comes in later (following the "pass the whole ast and phased directives approaches you mention) and actually does the addition and final display. Hopefully that makes sense - at transform time, you do have access to the whole AST, and also things can happen async, whereas the directive/roles parsing is constrained to be both synchronous, fast and local.
I think you lay out a lot of the tradeoffs we are thinking about as we make these transformation chains a bit more complex, as well as user friendly. However, what you are talking about is possible today, at least in the context of a single document.

oh that rocks!!!! I was wondering how to do this with a transform but was thinking about it in terms of passing values to the directive which rendered it, rather than doing the rendering in the transform and the directive is just a placeholder node.
I'll test this out, my initial question is whether or not i get the context of the whole project (like all the different pages in a multipage book) or just the current page, this comment is making me think i might need to do something else, but rather than taking your time asking you to tell me i'll just try it out ;)
since this came up in terms of making a blog index, would it be helpful for me to draft a docs PR with your example? Reading the current docs now, the pattern seems obvious in retrospect, but it might be helpful to have as another worked example on how to combine custom directives, roles, and transforms, and that one is a good one (and also looks like fun! i wish my teachers had a sweet document-driven points system)

Currently the transforms are document specific, certainly something to change in the future:

https://github.com/jupyter-book/mystmd/issues/1616

We would absolutely LOVE help with the docs and examples to make this clearer. Maybe if you are turning this into a mini-tutorial that is sharable and we can help you out along the way that would be fantastic. :)


Update codecov setting for test coverge check

Add codecov/patch status to ensure patch unit-test coverage.
Reference: https://docs.codecov.com/docs/commit-status
Update codecov ignore list.
Add github_checks annotations, and lines that are added
on a commit without coverage will show up in the pull request
files view with an annotation. You can hide annotations in the
files view by just pressing 'a', or unselecting "Show annotations"
in the top right of the file.
Reference: https://docs.codecov.com/docs/github-checks#annotations-in-the-checks-tab

For #3943
Signed-off-by: Lan Luo<EMAIL_ADDRESS>Signed-off-by: Wenqi Qiu<EMAIL_ADDRESS>

Codecov Report

Merging #3986 (b722327) into main (2f9134b) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3986      +/-   ##
==========================================
- Coverage   64.58%   63.74%   -0.84%
==========================================
  Files         295      298       +3
  Lines       43740    43834      +94
==========================================
- Hits        28251    27944     -307
- Misses      13215    13662     +447
+ Partials     2274     2228      -46

Flag
Coverage Δ

integration-tests
36.58% <ø> (?)

kind-e2e-tests
42.51% <ø> (-8.64%)
:arrow_down:

unit-tests
44.31% <ø> (ø)

Impacted Files
Coverage Δ

pkg/agent/proxy/endpointslicecache.go
0.00% <0.00%> (-83.60%)
:arrow_down:

pkg/agent/secondarynetwork/cnipodcache/cache.go
0.00% <0.00%> (-77.56%)
:arrow_down:

...g/agent/apiserver/handlers/featuregates/handler.go
4.54% <0.00%> (-77.28%)
:arrow_down:

pkg/controller/egress/store/egressgroup.go
1.72% <0.00%> (-54.32%)
:arrow_down:

pkg/agent/controller/networkpolicy/packetin.go
16.90% <0.00%> (-52.82%)
:arrow_down:

pkg/support/dump.go
7.90% <0.00%> (-49.16%)
:arrow_down:

...kg/apiserver/registry/system/supportbundle/rest.go
22.17% <0.00%> (-49.14%)
:arrow_down:

...g/agent/controller/serviceexternalip/controller.go
35.83% <0.00%> (-45.74%)
:arrow_down:

pkg/support/dump_others.go
0.00% <0.00%> (-44.74%)
:arrow_down:

pkg/agent/secondarynetwork/podwatch/controller.go
0.00% <0.00%> (-36.48%)
:arrow_down:

... and 86 more

/test-all

/test-flexible-ipam-e2e
/test-ipv6-e2e
/test-multicluster-e2e
/test-windows-e2e

@tnqn @antoninbas  Could you help to review if it's ready to merge?  thanks.

/skip-all


Make sure sending cancel request in StatementClient.close

Purpose
Make sure sending cancel request in StatementClient.close()
Overview
StatementClient.close() sends a cancel request:
https://github.com/treasure-data/trino-client-ruby/blob/55c3bdce35c1b3feca019ba1d0518d6f02b21b8e/lib/trino/client/statement_client.rb#L264-L280
But it doesn't if any errors happen inside the client because state is changed to client_error in exception!():
https://github.com/treasure-data/trino-client-ruby/blob/55c3bdce35c1b3feca019ba1d0518d6f02b21b8e/lib/trino/client/statement_client.rb#L133-L136
This change will make sure sending a cancel request when StatementClient.close() is called unless state is finished, query_failed or client_abort.
Checklist

[x] Code compiles correctly
[x] Created tests which fail without the change (if possible)
[x] All tests passing
[ ] Extended the README / documentation, if necessary

This change seems to make behavior of StatementClient inconsistent with Java's StatementClient. We will consider different ways.


No virtual keycode for question mark on linux

I've only tested this on linux. Pressing shift+'/' ('?') produces:
KeyboardInput {
    device_id: DeviceId(
        X(
            DeviceId(
                3
            )
        )
    ),
    input: KeyboardInput {
        scancode: 26,
        state: Pressed,
        virtual_keycode: None,
        modifiers: ModifiersState {
            shift: true,
            ctrl: false,
            alt: false,
            logo: false
        }
    }
}

Without the shift key pressed, it detects the slash just fine.

Can't reproduce:
DeviceEvent { device_id: DeviceId(X(DeviceId(12))), event: Key(KeyboardInput { scancode: 42, state: Pressed, virtual_keycode: Some(LShift), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } }) }
WindowEvent { window_id: WindowId(X(WindowId(73400323))), event: KeyboardInput { device_id: DeviceId(X(DeviceId(3))), input: KeyboardInput { scancode: 42, state: Pressed, virtual_keycode: Some(LShift), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } } } }
DeviceEvent { device_id: DeviceId(X(DeviceId(12))), event: Key(KeyboardInput { scancode: 53, state: Pressed, virtual_keycode: Some(Slash), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } }) }
WindowEvent { window_id: WindowId(X(WindowId(73400323))), event: KeyboardInput { device_id: DeviceId(X(DeviceId(3))), input: KeyboardInput { scancode: 53, state: Pressed, virtual_keycode: None, modifiers: ModifiersState { shift: true, ctrl: false, alt: false, logo: false } } } }
WindowEvent { window_id: WindowId(X(WindowId(73400323))), event: ReceivedCharacter('?') }
DeviceEvent { device_id: DeviceId(X(DeviceId(12))), event: Key(KeyboardInput { scancode: 53, state: Released, virtual_keycode: Some(Slash), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } }) }
WindowEvent { window_id: WindowId(X(WindowId(73400323))), event: KeyboardInput { device_id: DeviceId(X(DeviceId(3))), input: KeyboardInput { scancode: 53, state: Released, virtual_keycode: None, modifiers: ModifiersState { shift: true, ctrl: false, alt: false, logo: false } } } }
DeviceEvent { device_id: DeviceId(X(DeviceId(12))), event: Key(KeyboardInput { scancode: 42, state: Released, virtual_keycode: Some(LShift), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: false } }) }
WindowEvent { window_id: WindowId(X(WindowId(73400323))), event: KeyboardInput { device_id: DeviceId(X(DeviceId(3))), input: KeyboardInput { scancode: 42, state: Released, virtual_keycode: Some(LShift), modifiers: ModifiersState { shift: true, ctrl: false, alt: false, logo: false } } } }

Can we get some system info, and keyboard layout?

I forgot to mention this, but even if I could reproduce it, it would be an upstream issue from winit.

My output was from running on linux, with the dvorak keyboard layout.
@ZeGentzy looking at the output you pasted, it looks like you're reproducing the problem. Here's a line from your output corresponding to pressing shift + "?/" (ie. question mark), with newlines added for clarity
WindowEvent {
  window_id: WindowId(X(WindowId(73400323))),
  event: KeyboardInput {
    device_id: DeviceId(X(DeviceId(3))),
    input: KeyboardInput {
      scancode: 53,
      state: Pressed,
      virtual_keycode: None,   // <-- this is the problem
      modifiers: ModifiersState { shift: true, ctrl: false, alt: false, logo: false } } } }

When you pressed the "?/" key, the virtual_keycode is None. Looking at the definition of the VirtualKeyCode type[1], I can't see a variant corresponding to the question mark.
Also you're right, this is an issue with winit, not glutin. Should I close this and make an issue there or is there enough overlap?

https://docs.rs/winit/0.19.0/winit/enum.VirtualKeyCode.html

Ah, I did not spot that. File it upstream and post a link to the new issue right here.

https://github.com/tomaka/winit/issues/812

Closing in favor of upstream. rust-windowing/winit#812


Fix error with code coverage

closed by https://github.com/oaeproject/Hilary/pull/2499 (hopefully)


Use optional chaining

If you're using a version of TypeScript that supports optional chaining, you can simplify the conditional checks further.

configureRouter will never be nullish here.
Please stop creating spam issues/PRs.


AbstractMethodError withOnClickListener

Crash upon implementing withOnClickListener.
Hi, Good day,
Turning on proguard makes it crash upon clicking:
      fastItemAdapter.withOnClickListener((v, adapter, item, position) -> {
            //function here to jump to activity
            return true;
        });

Logcat:
07-30 16:04:21.795 28904-28904/com.unionbankph.oneuhub.uat E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.unionbankph.oneuhub.uat, PID: 28904
    java.lang.AbstractMethodError: abstract method "boolean com.mikepenz.a.e.g.onClick$7c4067ea(android.view.View, com.mikepenz.a.e, com.mikepenz.a.l, int)"
        at com.mikepenz.a.b$1.a(Unknown Source:116)
        at com.mikepenz.a.g.h.onClick(Unknown Source:36)
        at android.view.View.performClick(View.java:6891)
        at android.view.View$PerformClick.run(View.java:26083)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6938)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

But if I add this line:
-keep class com.mikepenz.fastadapter.**
It fixes the problem, but I know that it actually doesn't fix the problem, I just prevent the proguard on touching the library.
Details

FastAdapter version 3.2.8
Support version 27.1.1
BuildTools Version 27.0.3
Android Studio 3.1.3
Potential conflicting libraries implementation "com.mikepenz:materialize:1.1.2@aar"

I've also check this issues but neither has the same issue encountered like mine: #256 #237 #197 #270

which proguard configuration do you use? any special definition like more optimisation than suggested by the android team?
I use the adapter in many libs with proguard enabled too but have never faced this issue

Hi sir, here's my proguard main project config:
-keep class com.shockwave.** #pdf

-keep class com.itsgmobility.hrbenefits.BuildConfig { *; }

-keep public class android.support.v7.widget.** { *; }
-keep public class android.support.v7.internal.widget.** { *; }
-keep public class android.support.v7.internal.view.menu.** { *; }

-keep public class * extends android.support.v4.view.ActionProvider {
    public <init>(android.content.Context);
}

-keepclassmembers enum * {
    public static **[] values();
    public static ** valueOf(java.lang.String);
}

-dontwarn java.lang.invoke.** #can't find referenced class java.lang.invoke.LambdaMetafactory

#dynamically reference classes
-dontnote com.bumptech.glide.GeneratedAppGlideModuleImpl #com.bumptech.glide.Glide
-dontnote sun.misc.Unsafe #com.google.gson.internal.UnsafeAllocator
-dontnote android.os.SystemProperties #com.scottyab.rootbeer.utils.Utils
-dontnote com.android.org.conscrypt.SSLParametersImpl #okhttp3.internal.AndroidPlatform
-dontnote org.apache.harmony.xnet.provider.jsse.SSLParametersImpl #okhttp3.internal.AndroidPlatform
-dontnote sun.security.ssl.SSLContextImpl #okhttp3.internal.Platform
-dontnote org.robovm.apple.foundation.NSObject #retrofit2.Platform
-dontnote org.robovm.apple.foundation.NSOperationQueue #retrofit2.Platform$IOS$MainThreadExecutor

#duplicate library classes
-dontnote com.google.auto.value.AutoAnnotation
-dontnote com.google.auto.value.AutoValue$Builder
-dontnote com.google.auto.value.AutoValue
-dontnote org.apache.http.params.HttpConnectionParams
-dontnote org.apache.http.params.HttpParams
-dontnote org.apache.http.params.CoreConnectionPNames
-dontnote org.apache.http.conn.ConnectTimeoutException
-dontnote org.apache.http.conn.scheme.HostNameResolver
-dontnote org.apache.http.conn.scheme.SocketFactory
-dontnote org.apache.http.conn.scheme.LayeredSocketFactory
-dontnote android.net.http.SslCertificate$DName
-dontnote android.net.http.SslCertificate
-dontnote android.net.http.HttpResponseCache
-dontnote android.net.http.SslError
-dontnote okhttp3.logging.HttpLoggingInterceptor$Level
-dontnote okhttp3.logging.HttpLoggingInterceptor$Logger$1
-dontnote okhttp3.logging.HttpLoggingInterceptor$Logger
-dontnote okhttp3.logging.HttpLoggingInterceptor

#disable shifting mode in BottomNavigationView
-keepclassmembers class android.support.design.internal.BottomNavigationMenuView {
    boolean mShiftingMode;
}

And here's my build.gradle release config:
release {
            shrinkResources true
            minifyEnabled true
            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
            proguardFiles fileTree('proguard').asList().toArray()
}

I do have many proguard files, but I guess the proguard for the main project is what you're looking for, the other proguard config are from their corresponding libraries.

Are you using any other library that depends on fast adapter? (./gradlew app:dependencies)

Hi sir @FabianTerhorst, I did run that command, I've checked the response and there's no library that depends on fast adapter. I also can't remember that I include a library that depends on fast adapter. By the way, here's the summary of my libraries:
https://github.com/pwittchen/ReactiveNetwork v0.11.0
https://github.com/f2prateek/rx-preferences v2.0.0
https://github.com/scottyab/secure-preferences v0.1.4
rxjava v2.1.10
rxandroid v2.0.2
rxbinding v2.1.1
glide v4.0.0
https://github.com/hdodenhof/CircleImageView v2.2.0
gson v2.8.2
autovalue v1.3
https://github.com/code-troopers/android-betterpickers v3.1
firebase
From this list, I don' think they depend on fastadapter.

Hi sirs, have you successfully recreated the issue? Do you need any additional info other than this to recreate it?

No we sadly haven't in the sample app it works perfectly and also in other apps where we use proguard including advanced optimizations it works great.
you'd probably need to create and provide us a sample to showcase the issue as it is otherwise hard to assume anything

Please report back :). You can reopen if still relevant. close for now.


Invalidate guide page queries when XMLTV is regenerated

We can do this using the event stream listener
Also want to invalidate if the Update XMLTV task is run from the settings page

Added invalidation for the XMLTV task piece as part of a PR earlier today:
https://github.com/chrisbenincasa/tunarr/blob/main/web/src/pages/settings/TaskSettingsPage.tsx#L38


gratuitous symbolic names

such as "such as proportion (0x2237) for double colon" /cc @som-snytt

Abide is superseded by https://github.com/scalacenter/scalafix; closing all issues

I'd like a scalafix rule that suggests gratuitous symbolic names.


bind ⌘W to close the window

minor improvement to listen to ⌘W and close the window.

Cool idea! It might make sense to do this with electrons global shortcut package in server.js.

Note with global shortcut, you need something like this to avoid it affecting other applications (at least on OS X).
https://github.com/sindresorhus/electron-debug/blob/e5ae265a958b71d2a544ab3b0d093ff50e2b8d87/index.js#L26-L38

Electron's global shortcuts are actually global even when the app isn't focused, so something like in electron-debug needs to be done, like @mattdesl posted. But doing it like this seems a hacky to me. In electron-debug's case there seems to be no other option because it's sort of a "plugin" that's used during development and it can't inject itself in to the renderers. But it's not something you want to do if you have other options.
I think ⌘+W (and Control+W too) should be handled in the renderer.
BTW, the Escape key already closes the window. If that's not enough ⌘/Control+W could be implemented the same way.

Perhaps the global-shortcut package is intended for shortcuts like ⌘Space for Spotlight, it really needs to be registered as a global shortcut.
I agree with @maxkueng that for ⌘W it suits better in the renderer.
I'll also include CTRL + W in this PR, sorry about that.

Cool, thanks for the insight!

@gibatronic It looks good so far. Do you want to add support for Ctrl+W too so it will also work on non-OSX operating systems? Then we can merge this.

Sure!

Thanks, mate! I've published your changes in<EMAIL_ADDRESS>:)

Awesome! :dancer:


UpdateServicesServer: WSUS.cab file is missing products

Details of the scenario you tried and the problem that is occurring
The initial sync WSUS.cab file is out of date and is missing Windows Server 2019 and other products.
The following snippet fails because Windows Server 2019 is not a known product.
UpdateServicesServer 'UpdateServices' {
  Synchronize = $false # Default, use WSUS.cab
  Products = @(
    'Windows Server 2019'
  )
 ...

Verbose logs showing the problem
[[UpdateServicesServer]UpdateServices] Products test failed
[[UpdateServicesServer]UpdateServices] Test-TargetResouce returned false after calling set. | ErrorType: MSFT_UpdateServicesServer.TestFailedAfterSet

After a full sync, Windows Server 2019 product can be used.
Suggested solution to the issue
Please update bundled WSUS metadata export in WSUS.cab
The DSC configuration that is used to reproduce the issue (as detailed as possible)
See above.

The operating system the target node is running
Windows Server 2019
Version and build of PowerShell the target node is running
5.1.17763.1007
Version of the DSC module that was used
UpdateServicesDsc <IP_ADDRESS>

A full manual sync fixed the issue, but it would be good to be able to enable the product without having 2x DSC runs.

Specifically it is this file which is out of date: https://github.com/dsccommunity/UpdateServicesDsc/blob/master/source/DSCResources/MSFT_UpdateServicesServer/WSUS.cab

Would it help if I documented the procedure to create an updated version of WSUS.cab?

Yes please, documenting that step would be very helpful :)


Can't create agent pool due to error: Failed to create topic (User not authorized)

Summary
Can't create agent pool due to error: Failed to create topic (403 user not authorized). I can successfully create a topic with the service account via cli using gcloud pubsub topics create ... I've checked that the service account has the roles assigned (as per docs) and the correct project is set.
Am I missing any other permissions not provided by the roles below?
Service Account Roles

Storage Transfer Admin
Storage Object Admin
Pub/Sub Editor

Environment details

OS type: Arch Linux
Python version: 3.9.15
pip version: pip 22.0.4
google-cloud-storage-transfer version: 1.5.2

Code example

Via Python:

        from google.cloud import storage_transfer_v1
        agent_pool = storage_transfer_v1.AgentPool()
        agent_pool.name = 'my-agent-pool'

        request = storage_transfer_v1.CreateAgentPoolRequest(
            project_id='my-project-id',
            agent_pool=agent_pool,
            agent_pool_id='my-agent-pool-id',
        )

        # Make the request
        response = storage_transfer_v1.StorageTransferServiceClient().create_agent_pool(request=request)

Via CLI:  gcloud transfer agent-pools create 'my-agent-pool'

(both produce same error)
Stack trace
│ /usr/local/lib/python3.9/site-packages/google/cloud/storage_transfer_v1/serv │
│ ices/storage_transfer_service/client.py:1313 in create_agent_pool            │
│                                                                              │
│   1310 │   │   )                                                             │
│   1311 │   │                                                                 │
│   1312 │   │   # Send the request.                                           │
│ ❱ 1313 │   │   response = rpc(                                               │
│   1314 │   │   │   request,                                                  │
│   1315 │   │   │   retry=retry,                                              │
│   1316 │   │   │   timeout=timeout,                                          │
│                                                                              │
│ /usr/local/lib/python3.9/site-packages/google/api_core/gapic_v1/method.py:15 │
│ 4 in __call__                                                                │
│                                                                              │
│   151 │   │   │   metadata.extend(self._metadata)                            │
│   152 │   │   │   kwargs["metadata"] = metadata                              │
│   153 │   │                                                                  │
│ ❱ 154 │   │   return wrapped_func(*args, **kwargs)                           │
│   155                                                                        │
│   156                                                                        │
│   157 def wrap_method(                                                       │
│                                                                              │
│ /usr/local/lib/python3.9/site-packages/google/api_core/grpc_helpers.py:74 in │
│ error_remapped_callable                                                      │
│                                                                              │
│    71 │   │   try:                                                           │
│    72 │   │   │   return callable_(*args, **kwargs)                          │
│    73 │   │   except grpc.RpcError as exc:                                   │
│ ❱  74 │   │   │   raise exceptions.from_grpc_error(exc) from exc             │
│    75 │                                                                      │
│    76 │   return error_remapped_callable                                     │
│    77                                                                        │
╰──────────────────────────────────────────────────────────────────────────────╯
PermissionDenied: 403 Failed to create topic
(projects/my-project-id/topics/my-agent-pool-name-cloud-ingest-list). Please grant Pub/Sub permissions to the STS service account.
Additional details: User not authorized to perform this action

@calum-mcg Thanks for your detailed inquiry, let's get you unblocked.

I've checked that the service account has the roles assigned

Which service account are you referring to? STS uses a Google-managed service account that matches this pattern<EMAIL_ADDRESS>does this service account have the appropriate permissions?

@danielbankhead - Thanks for your reply. I am using my own custom service account that does not match the pattern above. How can I create and enable this Google-managed service account via the Python SDK?

@calum-mcg It should be auto-generated (but not visible until you add permissions to it); you can add permissions to it in the same way as any service account.

Thanks for your help @danielbankhead


Backport juno

backport for previously created volumes

Thank you for contributing to openstack/cinder!
openstack/cinder uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


feat: define MeasureTheory.Lp.const

Lean fails to generate the Norm instance in 1 lemma. I tried to use letI and failed.

[x] depends on: #5234

This PR/issue depends on:

leanprover-community/mathlib4#5234
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#5234
By Dependent Issues (🤖). Happy coding!

Yes, Lean fails to generate Norm instance in the commented lemma.

@sgouezel It turns out that the issue was with NormedField vs NontriviallyNormedField, not with Lean instance search.

LGTM!
bors d+

bors merge


HBASE-27938 - PE load any custom implementation of tests at runtime

This is a cherry-pick of #5307

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 51s
branch-2 passed

+1 :green_heart:
compile
0m 29s
branch-2 passed

+1 :green_heart:
checkstyle
0m 11s
branch-2 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 28s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 10s
hbase-mapreduce: The patch generated 4 new + 27 unchanged - 0 fixed = 31 total (was 27)

-0 :warning:
whitespace
0m  0s
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
13m 44s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

-1 :x:
spotless
0m 35s
patch has 63 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

24m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5310

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux c51438090d98 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 7d8e187ec5

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

whitespace
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-general-check/output/whitespace-eol.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 19s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 31s
branch-2 passed

+1 :green_heart:
compile
0m 17s
branch-2 passed

+1 :green_heart:
shadedjars
4m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
4m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
14m 32s
hbase-mapreduce in the patch passed.

30m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0513c1547ae0 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 7d8e187ec5

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/testReport/

Max. process+thread count
2684 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 52s
branch-2 passed

+1 :green_heart:
compile
0m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
15m  7s
hbase-mapreduce in the patch passed.

33m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c897f9bf1bd0 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 7d8e187ec5

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/testReport/

Max. process+thread count
3284 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 34s
branch-2 passed

+1 :green_heart:
compile
0m 29s
branch-2 passed

+1 :green_heart:
checkstyle
0m  9s
branch-2 passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 25s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 38s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  7s
The patch does not generate ASF License warnings.

24m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5310

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 56fd23e7593d 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 267d6219ba

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
branch-2 passed

+1 :green_heart:
compile
0m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
15m  2s
hbase-mapreduce in the patch passed.

32m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5310

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bdbd20b2b07d 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 267d6219ba

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/2/testReport/

Max. process+thread count
3335 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5310/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Can't swipe a FlatList inside a TouchableWithoutFeedback

Hello,
I have a horizontal FlatList wrapped with a TouchableWithoutFeedback and every time i try to swipe horizontally it instead activates the Touchable's onPress. How can one fix this bug?
React Native version:
0.61.5

refer to #14155

Thank you for the issue @tankpower1, we need more information to debug this.
• Could you make sure to follow the full issue template?
• Could you provide a Snack or repo that demonstrates this bug?


Update zio-sbt-website to 0.4.0-alpha.24

About this PR
📦 Updates dev.zio:zio-sbt-website from 0.4.0-alpha.23 to 0.4.0-alpha.24
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-sbt-website" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-sbt-website" }
}]

labels: sbt-plugin-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #141.


2024-12-12_01-36-00_master-next_aws-sdk-cpp

Automatically created.

Successfully created backport PR for kirkstone-next:

#10759

Successfully created backport PR for scarthgap-next:

#10760

Successfully created backport PR for styhead-next:

#10761


Segmentation Fault during Lambda Execution

Describe the bug
Hello,
I work in AWS Support and I am raising a Github issue on behalf of a customer.
The customer uses the Lambda Layer for AWS Data Wrangler in their Lambda function to read json files from S3, create panda dataframes using awswrangler and process the file data, create a glue catalog table and store the flattened data files in S3 in parquet format. It was observed that a small number of Lambda invocation executions out of thousands fail with the error Runtime exited with error: signal: segmentation fault Runtime.ExitError
After having done some research, it appears as though this type of error is raised by a binary dependencies ( implemented in C/C++) utilized a Python module. From having looked at many resources on the web, the Pandas module in particular is known for raising this type of error for various different root causes.
I am trying to assist the customer with guidance on how to troubleshoot the root cause of their segmentation faults going forward, particularly on how to gather some more useful debug information. Currently the logs for the failed Lambda invocations end abruptly with the logged line Runtime exited with error: signal: segmentation fault Runtime.ExitError and there is no insight into what is happening with Pandas and the related binary dependencies.
From what I gather from [1][2], it is not entirely straightforward to debug binary dependencies for Pandas for segmentation faults.
Can you please provide guidance on what steps can be taken to output verbose debug logging for the aws data wrangler layer and its binary extensions in the Lambda environment? In particular, it would be great if we could have steps to collect debugging and replication data so that we can come back with the information needed for troubleshooting for an issue on this repo. Any other insights you may have would be appreciated.
References:
[1] https://pandas.pydata.org/docs/development/debugging_extensions.html
[2] https://blog.richard.do/2018/03/18/how-to-debug-segmentation-fault-in-python/
How to Reproduce
Unfortunately, we do not have detailed steps on how to reproduce the issue other than the Lambda execution logs and the names of the files that were being processed.
The issue happened intermittently (only for a few invocations out of thousands). The customer noted that the issues only happened when they were utilizing version 5 of the Lambda Layer and have not happened since they upgraded to subsequent versions.
At this point we are seeking guidance on how best to gather debugging information to troubleshoot the issues in more detail.
Expected behavior
For the error not to happen and for the Lambda runtime not to exit.
Your project
No response
Screenshots
No response
OS
Amazon Linux 2, underlying OS for Python Lambda Runtime
Python version
3.9
AWS SDK for pandas version
arn: arn:aws:lambda:us-east-1:336392948345:layer:AWSDataWrangler-Python39:5
Additional context
No response

Hi @Alexander-Ludwig, in terms of debugging, my advice would be for the customer to first enable logging in their Lambda function code. They could add a line for pandas too:
logging.getLogger("pandas").setLevel(logging.DEBUG)

Hopefully this would give them more visibility into the error.
It's interesting that they haven't encountered this error after upgrading from version 5 of the layer. It could very well be that pandas introduced a fix in their latest version which we have released as part of the most recent awswrangler layers

Is this closed? I've been running into the same error

I get the same error when using python3-saml library.


Timed out while waiting for handshake

Connecting: apache@<IP_ADDRESS>:22
Error: Timed out while waiting for handshake
I'm able to use the same credentials with FileZilla

Duplicate with #53


[Bug Report] Vue   Element-UI   Meteor gives the following error: "import Vue from 'vue'; ... SyntaxError: Unexpected reserved word"

Element UI version
1.3.6
OS/Browsers version
macOS Sierra Version 10.12 / Google Chrome Version 59.0.3071.86 (Official Build) (64-bit)
Vue version
2.1.10
Reproduction Link
https://github.com/gczh/meteor-vue2-example
Steps to reproduce
Run the following commands in the given sequence:
meteor npm i
meteor

Note: try doing the following
npm uninstall -S element-ui
meteor

You should be able to get meteor working again.
I believe that some element-ui dependency is causing a conflict with vue and or meteor. I'm not quite sure which it's conflicting with though.
What is Expected?
$ meteor
=> Started proxy.
   [HMR] Dev server listening on port 3003
=> Started MongoDB.
=> Started your app.

=> App running at: http://localhost:3000/

What is actually happening?
We get the following error:
W20170615-15:55:06.801(8)? (STDERR) /Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/packages/modules.js:936
W20170615-15:55:06.804(8)? (STDERR) import Vue from 'vue';
W20170615-15:55:06.806(8)? (STDERR) ^^^^^^
W20170615-15:55:06.807(8)? (STDERR)
W20170615-15:55:06.807(8)? (STDERR) SyntaxError: Unexpected reserved word
W20170615-15:55:06.808(8)? (STDERR)     at Object.exports.runInThisContext (vm.js:53:16)
W20170615-15:55:06.810(8)? (STDERR)     at /Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/boot.js:331:30
W20170615-15:55:06.814(8)? (STDERR)     at Array.forEach (native)
W20170615-15:55:06.816(8)? (STDERR)     at Function._.each._.forEach (/Users/SOHAPPY/.meteor/packages/meteor-tool/.<IP_ADDRESS>krbjsg  os.osx.x86_64 web.browser web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
W20170615-15:55:06.817(8)? (STDERR)     at /Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/boot.js:158:5
W20170615-15:55:06.819(8)? (STDERR)     at /Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/boot.js:387:5
W20170615-15:55:06.820(8)? (STDERR)     at Function.run (/Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/profile.js:510:12)
W20170615-15:55:06.822(8)? (STDERR)     at /Users/SOHAPPY/Documents/Projects/meteor-vue2-example/.meteor/local/build/programs/server/boot.js:386:11
=> Exited with code: 1
=> Your application is crashing. Waiting for file change.
^C

Referencing https://github.com/meteor/meteor-feature-requests/issues/6, it could be that element-ui is not transpiled into ES2015 syntax. As meteor doesn't seem to transpile node_modules, this could be why it's breaking things.


Batch and interval arguments are confusing

Hi,
I've been digging into the code and tweaking behaviour as the module wasn't working for me with large metric counts.
My assumption reading the documentation, and standard queuing behaviour, would be that batch size and interval are to ensure steady throughput to a graphite server. However that doesn't seem to be the case. The batch size works in that is how many metrics are sent in one socket operation, but there is no delay based on the interval.
For instance:

Create an async sender queue with batch size 50, and interval 5
Put 1000 metrics onto the queue
I would now expect the lib to send 50 metrics, every 5 seconds, so 1200 message a minute.
Instead, I can log graphyte sending 50 messages to the socket at a time, without a delay

2021-07-20 13:22:15,309 - graphite-buffer - INFO - sent message of 6185B, 50 metrics, to graphite:2003 in 0.222 seconds
2021-07-20 13:22:15,536 - graphite-buffer - INFO - sent message of 6204B, 50 metrics, to graphite:2003 in 0.227 seconds
2021-07-20 13:22:15,762 - graphite-buffer - INFO - sent message of 6173B, 50 metrics, to graphite:2003 in 0.226 seconds
2021-07-20 13:22:15,985 - graphite-buffer - INFO - sent message of 6206B, 50 metrics, to graphite:2003 in 0.223 seconds
2021-07-20 13:22:16,211 - graphite-buffer - INFO - sent message of 6205B, 50 metrics, to graphite:2003 in 0.225 seconds

The guilty code being:
                if current_time - last_check_time >= self.interval:
                    last_check_time = current_time
                    for i in range(0, len(messages), self.batch_size):
                       batch = messages[i:i + self.batch_size]
                       self.send_socket(b''.join(batch))
                    messages = []

It seems the algorithm is to check the queue every interval seconds, then flush the entire queue with batch number of metrics in each write operation?
So, is this behaviour intentional, and interval is how often the thread queue basically wakes up and flushes the queue? Or is this buggy behaviour, and it should instead read&send a specific number of metrics (batch #) off the queue each interval?

Hi @jake2184, it's been a while since I wrote this code, but yeah, this is intentional. The idea is that the thread wakes up at least every interval seconds if you're sending slowly, but it'll happily send faster than that if the caller is adding metrics faster. So the interval is to specify the maximum time between sends when sending fairly slowly; it's not intended for throttling.
I realize now that the docs/README don't make this particularly clear -- I'd happily accept a PR to clear this up in the README and/or code comments.

Ok - if it's intentional that's not a problem, I'll likely just end up forking the code base - I'm using this to write a daemon to collect tens of 1000s of metrics, dumped once a minute, and slowly stream data up to a central server.
Thanks for the quick response.


Block Backend from non Mr.Moore users

[ ] Create a check for admin, and redirect back to wallet if not admin

I tried to go to the web pages, but because you are not admin, there is no data actually being sent, so there is no real access granted.


@import-normalize does not work

Describe the bug
According to the documentation adding @import-normalize in index.css should reset the browser styles but apparently it does not work and gives error as:
Unknown at rule @import-normalizecss(unknownAtRules)
Here is the image with @import-normalize

Did you try recovering your dependencies?

npm version - 6.14.4
Which terms did you search for in User Guide?

normalize css and reset css
Environment

System:
OS: macOS 10.15.6
Binaries:
Node: 12.18.0 - /usr/local/opt/node@12/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.8 - ~/dev/cph-trips/node_modules/.bin/npm
Browsers:
Chrome: 85.0.4183.121
Firefox: 76.0.1
Safari: 14.0
npmPackages:
react: ^16.13.1 => 16.13.1
react-dom: ^16.13.1 => 16.13.1
react-scripts: 3.4.3 => 3.4.3
Steps to reproduce

Download create react app using npx create-react-app
Add @import-normalize in index.css

Expected behavior

Adding  @import-normalize should reset the browser style and not show the unknown error

hey bro do you have a work around on this one? for me I just exported the whole code from this link

same behavior, not working

I ended up importing another css normalizing package from npm.
On Sun, Nov 1, 2020 at 11:15 AM aRtoo<EMAIL_ADDRESS>wrote:

hey bro do you have a work around on this one? for me I just exported the
whole code from this link https://meyerweb.com/eric/tools/css/reset/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/9710#issuecomment-720129990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKLRHTDYFVJMMFCHBB3NQWTSNWQU5ANCNFSM4R3XS7OA
.

Same problem  here.....

repro: https://codesandbox.io/s/import-normalize-doesnt-work-with-cra-p52f9

Thanks @corysimmons for the workaround but still people should know that normalize css does not work out of the box in create-react-app so that they don't spend lot of time trying to fix it as I spent good couple of hours.

Thanks @corysimmons for the workaround but still people should know that normalize css does not work out of the box in create-react-app so that they don't spend lot of time trying to fix it as I spent good couple of hours.

Seeing as @import-normalize is part of csstools/postcss-normalize, I'd recommend their version of normalize.css instead, because it isn't opinionated and is still supported (unlike the normalize.css fork):

yarn add @csstools/normalize.css
put import<EMAIL_ADDRESS>before other css imports in index.js`

hello, guys. any updates?

no updates yet?

+1

+1

+1

+1

+1

+1

+1

+1

My workaround is just simply to use this in your index/App.css or scss
https://newbedev.com/css-how-to-remove-user-agent-stylesheet-in-css-code-example
but yeah it's confusing since the documentation does not tackle this issue
https://create-react-app.dev/docs/adding-css-reset

+1

+1

+1

Não está funcionando ainda... só funciona quando instala a dependência ' npm normalize ' e coloca dentro da pastra index.tsx -> import 'normalize.css'

@leo-ngra
The correct command is: "npm i normalize.css"


Some files from Roslyn have no semantic info

E.g. search for eventhookupcom and compare with http://source.roslyn.io

Fixed by disabling VSSDK targets for VS extensibility projects which won't succeed on a hosted machine without VS installed.


Mouse crossing on multiple monitor setups with different resolutions

Description of the new feature / enhancement
At the current state in windows if you run a multi monitor setup consisting of different resolutions you can only cross from one monitor to the other at the level the monitor resolutions align together. Mouse Crossing would enable a user to cross to the other monitor without these restrictions.
The picture below is to illustrate the current state. You can only go from one monitor to the other at the green part and not the red part

A simple solution would be to map the red part to the top of the monitor next to it, so if you try to cross on the highest point of the red part you land at the highest point of the monitor you cross to. But maybe there are smarter solution for this issue.
I would place this as a new plugin thats situated inside the MouseUtils folder and would need a simple enable / disable feature.
Scenario when this would be used?
Basically in everyday work and usage this scenario occurs
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/1226


Preview Version no longer required

Remove the info for the preview version and link to the default installation instructions for the PowerShell module instead.

@Weishaupt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#sign-off


Design thoughts

Guys (mostly Piotr but also anyone who's listening),
Firstly, on timeline, we need something working well in time for September 1st-ish, the time we give the tutorial.
So we can't be too ambitious: think, cleaned up and reorganized version of Snowfall, working by early-to-mid August.  Sorry I have delayed this for so long.  Liyong is working on   replicating ESPNet results with k2 mechanisms, he is making good progress, we may want to incorporate parts of that.
I want to avoid big centralized APIs at the moment.
I also want to avoid the phenomenon in SpeechBrain and ESPNet where there is a kind of "configuration layer" where
you pass in configs, and these get parsed into actual python code by some other code.  I would rather keep it all
Python code.  Suppose we have a directory (this doesn't have to be the real name):
egs/librispeech/ASR/
then I am thinking we can have subdirectories of that where the scripts for different versions of experiments live.
We might have some data-prep scripts:
egs/librispeech/ASR/{prepare.sh,local/blahblah,...}
and these would write to some subdirectory, e.g. egs/librispeech/ASR/data/...
Then for different experiments we'd have the scripts in subdirectories, like:
egs/librispeech/ASR/tdnn_lstm_ctc/{model.py,train.py,decode.py,README.md}
and we might have
egs/librispeech/ASR/conformer_mmi/{model.py,train.py,decode.py,README.md}
that would refer to the alignment model in e.g. ../tdnn_lstm_ctc/8.pt, and to the data in ../data/blah...
The basic idea here is that if you want to change the experiment locally, you would copy-and-modify the scripts in conformer_mmi to e.g. conformer_mmi_1a/, and add them to your git repo if wanted.  We would avoid overloading the scripts in these experiment directories with command-line options.  Any back-compatibility would be at the level of the icefall Python libraries themselves.   We could perhaps introduce versions of the data directories as well, e.g. data/, data2/ and so on (not sure whether it would make sense to have multiple versions of the data-prep scripts or use options).
In order to avoid overloading the model code, and utility code, with excessive back-compatibility, I suggest that we have versions of the model code and maybe even parts of the other libraries: e.g. snowfall/models1/.  Then we can add options etc., but when  it becomes oppressive we can just copy-and-modify to models2/ and strip out most of the options.   This will tend to reduce "cyclomatic complexity" by keeping any given version of the code simple.  At this point, let's think of this to some extent as a demo tool for k2 and lhotse, we don't have to think of it as some vast toolkit with zillions of features.

OK, that is pretty similar to Kaldi. I can work with that. I also recently started to dislike the "configuration layer" and somehow prefer to write just the necessary things in a given script/notebook...
Some suggestions:

let's aim to keep all the model definitions in the "library" part of Icefall and specifically avoid local for that -- I feel that "well-tuned" configurations should be more easily re-usable than copy-paste style;
instead of models1/models2/modelsN, we could do icefall/models/conformer/v{1,2,3}.py, icefall/models/tdnnf/v{1,2,3}.py, etc. (or even better models/conformer/conformer_{1a,1b,1c}.py), I like that approach more because models1/models2 suggests it's a different, new version of the toolkit (like espnet, espnet2)
it'd be best to have the lexicon/lang creation in Python in the "library" part (as per https://github.com/k2-fsa/snowfall/issues/191 which maybe I'll finally find the time for now that I'm back) -- I'd like to be able to re-use phone/BPE/subword/character lexicons and lexicon-related code across recipes, also merge multiple lexicons e.g. for multilingual/multi-accent models

Mid/long-term considerations:

ideally, every "training" script wouldn't be too long (I think ~200, maybe ~300 loc sounds reasonable, unless we come up with something very involved and non-standard), we should regularly move some common patterns to the "library" part as functions/classes...
we should at least consider a common function signature for all model forward methods to allow simpler use via torchscript (or we could add methods like .get_inputs_info() [not necessarily with that name] that help users figure out which inputs to provide, although maybe that beats the purpose?)

One more suggestion: let's try to aim to make the library friendly to use with jupyter notebooks by making most of the functionality importable (even if it's something used just by one recipe I guess); they are really great for prototyping/tinkering with these things

OK, that is pretty similar to Kaldi. I can work with that. I also recently started to dislike the "configuration layer" and somehow prefer to write just the necessary things in a given script/notebook...

Cool!

let's aim to keep all the model definitions in the "library" part of Icefall and specifically avoid local for that -- I feel that "well-tuned" configurations should be more easily re-usable than copy-paste style;

I guess I'm OK with that, if we mean things like the conformer being in the "library", but I think it could be a good idea to use local model.py to "put pieces together".  The point is, we may want to experiment with a lot of new things, and I want it to be easy to do.

instead of models1/models2/modelsN, we could do icefall/models/conformer/v{1,2,3}.py, icefall/models/tdnnf/v{1,2,3}.py, etc. (or even better models/conformer/conformer_{1a,1b,1c}.py), I like that approach more because models1/models2 suggests it's a different, new version of the toolkit (like espnet, espnet2)

OK.

it'd be best to have the lexicon/lang creation in Python in the "library" part (as per Building lexicons in Python snowfall#191 which maybe I'll finally find the time for now that I'm back) -- I'd like to be able to re-use phone/BPE/subword/character lexicons and lexicon-related code across recipes, also merge multiple lexicons e.g. for multilingual/multi-accent models

After seeing a draft I might agree.  I'm OK to centralize some code code after patterns emerge.  But I want any utilities and centralized classes to befairly simple and easily separable, so that you can understand one piece without understanding the whole.

Mid/long-term considerations:

ideally, every "training" script wouldn't be too long (I think ~200, maybe ~300 loc sounds reasonable, unless we come up with something very involved and non-standard), we should regularly move some common patterns to the "library" part as functions/classes...

Sure, in the longer term hopefully they can become much shorter.

we should at least consider a common function signature for all model forward methods to allow simpler use via torchscript (or we could add methods like .get_inputs_info() [not necessarily with that name] that help users figure out which inputs to provide, although maybe that beats the purpose?)

I'm OK with settling on a particular order of tensors, e.g. (N, C, T), not sure if that's what you mean? (I think speechbrain does that?).

I'm OK with settling on a particular order of tensors, e.g. (N, C, T), not sure if that's what you mean? (I think speechbrain does that?).

my point was about the number of args/kwargs — currently the signature of forward in our models is inconsistent, so you can’t use them as drop in replacements with inference code. 100% plug and play doesn’t seem attainable (we may want to keep adding inputs to try out new things) but at the very least we could modify all signatures to accept (*args, **kwargs) so that simpler models can work with extra inputs.

Mm, do speechbrain or ESPNet do that?
I'm cautious about this.  Seems to me potentially a recipe for bugs.
On Fri, Jul 2, 2021 at 8:01 PM Piotr Żelasko @.***>
wrote:

I'm OK with settling on a particular order of tensors, e.g. (N, C, T), not
sure if that's what you mean? (I think speechbrain does that?).
my point was about the number of args/kwargs — currently the signature of
forward in our models is inconsistent, so you can’t use them as drop in
replacements with inference code. 100% plug and play doesn’t seem
attainable (we may want to keep adding inputs to try out new things) but at
the very least we could modify all signatures to accept (*args, **kwargs)
so that simpler models can work with extra inputs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/icefall/issues/1#issuecomment-872944561, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLOYUPVSCFI6IRISM65LTVWTANANCNFSM47TSKU2A
.

Mm, do speechbrain or ESPNet do that? I'm cautious about this. Seems to me potentially a recipe for bugs.
…

I don't think they do. My knowledge might be out of date but the last time I checked, none of the existing PyTorch-based ASR frameworks I know of seriously addressed the matter of model deployment.

We can consider such things later on.  We are working on a deadline right now and I want to consider this a demo of k2/lhotse for now, so we can explore architectures, before really settling on common APIs.


Need Dashboard

I need a dashboard where I can analyze bot conversations with users. It also provides the ability to connect the bot at any time with a live human agent.

Have you found any? Looking for the same

can you guys provide a more detailed description of what you need? features, ui, etc.
I'm working on a project and might help.

Yeah, well i run my chatbot via Flowise API. I need a dashboard that can follow the conversations made on the chatbot for my clients to see. My chatbot is made with react.js and the API and so on. But something like https://chat-dash.com/, bit for flowise.


MRG: Fix source

PR to 0.14 to see if it fixes the problem.

Links appear fixed
https://5377-1301584-gh.circle-artifacts.com/0/home/ubuntu/mne-python/doc/_build/html/generated/mne.io.Raw.html
There is some CSS problem that has arisen recently in master we should probably also fix

CSS and links fixed:
https://5386-1301584-gh.circle-artifacts.com/0/home/ubuntu/mne-python/doc/_build/html/generated/mne.io.Raw.html
Merging