HBASE-27991 fixing ClassCastException in multithread client run

This PR is now open for review. The details os stack trace is captured in https://issues.apache.org/jira/projects/HBASE/issues/HBASE-27991
ForkJoinPool and ThreadPoolExecutor are both implemented classes of the ExecutorService interface from the java.util.concurrent package, which provides a framework for asynchronously executing tasks in Java.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 13s
master passed

+1 :green_heart:
compile
0m 22s
master passed

+1 :green_heart:
checkstyle
0m  9s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

-0 :warning:
javac
0m 20s
hbase-examples generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

-0 :warning:
checkstyle
0m  8s
hbase-examples: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 27s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

-1 :x:
spotless
0m 42s
patch has 45 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

27m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5346

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux ecaf56004898 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7cfa47dfe0

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-examples.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-examples U: hbase-examples

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 15s
master passed

+1 :green_heart:
compile
0m 17s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 16s
the patch passed

+1 :green_heart:
javac
0m 16s
the patch passed

+1 :green_heart:
shadedjars
4m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 59s
hbase-examples in the patch passed.

18m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5346

JIRA Issue
HBASE-27991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7ea370828454 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7cfa47dfe0

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/testReport/

Max. process+thread count
1354 (vs. ulimit of 30000)

modules
C: hbase-examples U: hbase-examples

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 11s
master passed

+1 :green_heart:
compile
0m 21s
master passed

+1 :green_heart:
checkstyle
0m  9s
master passed

+1 :green_heart:
spotless
0m 47s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

-0 :warning:
javac
0m 19s
hbase-examples generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
checkstyle
0m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 29s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

26m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5346

JIRA Issue
HBASE-27991

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 41d57011086a 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7cfa47dfe0

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-examples.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-examples U: hbase-examples

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
master passed

+1 :green_heart:
compile
0m 15s
master passed

+1 :green_heart:
shadedjars
4m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
0m 15s
the patch passed

+1 :green_heart:
javac
0m 15s
the patch passed

+1 :green_heart:
shadedjars
4m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 39s
hbase-examples in the patch passed.

19m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5346

JIRA Issue
HBASE-27991

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 08b880188da2 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7cfa47dfe0

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/5/testReport/

Max. process+thread count
1623 (vs. ulimit of 30000)

modules
C: hbase-examples U: hbase-examples

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
master passed

+1 :green_heart:
compile
0m 21s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 32s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

-0 :warning:
javac
0m 21s
hbase-examples generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
checkstyle
0m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 21s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  8s
The patch does not generate ASF License warnings.

27m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5346

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux bdf51331d23f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dae078e5bc

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-examples.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-examples U: hbase-examples

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5346/8/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Hi @Apache9 I suspect https://issues.apache.org/jira/browse/HBASE-22244 / https://github.com/apache/hbase/pull/155 might have broken compatibility as the failure of this example client shows that an old client which was passing ForkJoinPool no longer works and requires a ThreadPoolExecutor only. Do you mind having a look at this one?

https://issues.apache.org/jira/browse/HBASE-22244

I have been able to write a UT to confirm this. Raised https://issues.apache.org/jira/browse/HBASE-28035, raised a UT PR to demonstrate same at https://github.com/apache/hbase/pull/5365

Gentle Reminder: @Apache9 can u please review

I suspect https://issues.apache.org/jira/browse/HBASE-22244 / https://github.com/apache/hbase/pull/155 might have broken compatibility on what can be passed to ExecutorService as the failure of this example client shows that an old client code which was passing ForkJoinPool no longer works and requires a ThreadPoolExecutor only.

I have been able to write a UT to confirm this. Raised https://issues.apache.org/jira/browse/HBASE-28035, raised a UT PR to demonstrate same at #5365

Since we have a JIRA for the issue which cause this class to fail, I am good with this change to go in as is. We can look at the issue which introduced this bug as part of HBASE-28035.
+1 to this change.

Thanks for making your 1st contribution in Apache HBase @nikita15p :)
Also, could you please raise a backport PR for branch-2 (since the failure is only relevant for branch-2 as explained in https://github.com/apache/hbase/pull/5365#issuecomment-1687107824) ?


feat: limit view fields exposed to render function

Description:
This PR addresses issue #137 by making changes to object exposed to user-provided render.
Previous:
class AnyView {
  async render() {
    // ...
    let cleanup = widget.render(this);
    // ...
  }
}

Proposed:
class AnyView {
  async render() {
    // ...
    let cleanup = widget.render({ model: this.model, el: this.el });
    // ...
  }
}

The key focus is on minimizing the API surface area by reducing the exposed fields to the user-provided render function. This change is expected to improve encapsulation and limit the potential for erroneous modifications.
In a review of current projects utilizing anywidget, no evident use-cases were identified that would be adversely affected by this change. It's worth mentioning that there's still a degree of uncertainty about how these changes will impact model (un)subscriptions within Backbone.
To-Do:

Investigate the potential impacts of this change on granular model subscriptions and unsubscriptions in Backbone.

Request for Review:
I would like to invite reviewers to provide feedback, especially in areas related to Backbone's model (un)subscriptions. Any objections or observations on potential impacts are greatly appreciated.
cc: @maartenbreddels @juba @domoritz @kolibril13

This would work for my use case, too.


Could not find OAuth cookie

I have created a private app for one of my merchants. It was working fine but after some days the app doesn't work with this error message

I have to reinstall the app to get it working again.
I have checked your code it should automatically go through the whole auth process again.

I have checked the database it deleted the session but It doesn't redirect the whole auth process again.
Any idea why this issue occurring?

I've been recently getting reports about this -  a quick fix is to manually run the auth again by the URL after uninstalling the app. Weirdly enough, having pushed out ~50+ apps at this point, I've never seen this issue at any point so there has to be a piece of documentation I'm either missing or something's actually going wrong. Is there a way to reliably replicate this error?

I have tried to recreate the issue but couldn't able to do it.
if I can I will let you know.
Thanks.

Is this happening in dev mode or in production? Also, try removing node_modules and .next folder when it happens to see if it works. Though for most parts it's to do with how Shopify's package handles OAuth cookies, so if you start auth at api.example.com and your callback is at dashboard.example.com, it'll break because cookie is set to sameSite: lax, scoping it to that subdomain instead of the whole domain.

It is happening in the production mode.
And I am using the same subdomain on auth and the callback.

Can you try this gist out?
https://gist.github.com/kinngh/ab36102f4c1f2bdd9a56729253af222b

okay @kinngh

@ifat802 any updates on this?

The issue seems to be fixed.
The issue did not reoccur. @kinngh


Add option to disable HTTP servers

Fixes #3141
This PR adds functionality to disable the HTTP servers in node (RPC, REST, events, speculative execution). Additionally, it separates the configurations of the RPC and speculative execution servers, which were previously under the same section.
This functionality can't be tested in node, so the tests are in casper-test. After this PR gets merged, https://github.com/casper-network/casper-test/pull/88 should also get merged.

While I don't disagree with @marc-casperlabs points above, I think we're ok to merge this as is since some of his concerns will be addressed when we clean up the RPC server component in upcoming work.
The rough plan is to get rid of the component entirely, since it's probably surplus to requirements.  The server running in the tokio task will be able to interact directly with the other components as required via holding a copy of the effect builder for its lifetime.
Even if we don't go as extreme as removing the component, we can still probably reduce the event variants to just one or two if we change the server task to not route requests via its own component.

As for the routing itself (and getting rid of the boolean checks), how about something like this instead (this is for variant one):
[...]
I don't think it is a tremendous issue to keep it the way it is right, but it would be nice to clean the state up a little and not have all these if self.enabled guards in the match blocks.

That's what I meant here - https://github.com/casper-network/casper-node/pull/3147#discussion_r910731740

I refactored the logic of the servers in https://github.com/casper-network/casper-node/pull/3147/commits/fe2da27e0e87c7ce5cc3b8b420f2e15b58a128c1.
I ended up ditching the Feature suggestion because it felt like a worse Option (fewer methods, functionality, etc.) and I found no good place to put it, since it had to be reused in 3 different servers.
@marc-casperlabs @Fraser999 @goral09 let me know what you think. If this is not an improvement, we can just revert this commit and merge without it, since the previous work had all approvals.

bors try

bors r+

bors merge


ODBC page should be improved

It currently has some very pixelated / distorted images: https://duckdb.org/docs/api/odbc/windows

Worth checking they're not caused by imagebot?

No, they were already distorted in the summer before I added imgbot.

Fixed by #1309


Follow up on Parts and Wiring

Hi sorry for bothering on Christmas Day, I hope you don’t mind. So the reason I am ordering from amazon instead of Ali Express is because I have Amazon gift cards I want to use and this is a good use for them, so my final parts and this board, https://www.amazon.com/gp/product/B07HF44GBT/ref=ox_sc_act_title_2?smid=A2K4DGCC72N9AG&psc=1, this relay, https://www.amazon.com/gp/product/B07C8LSXKC/ref=ox_sc_act_title_1?smid=A2NHKNRXF8LPRC&psc=1, and these wires to connect to my sprinkler system, https://www.amazon.com/gp/product/B01EV70C78/ref=ox_sc_act_title_3?smid=A2WWHQ25ENKVJ1&psc=1. So if all my parts look okay is there any tutorial you could point me to, so I could see how to link my sprinklers?

Hello, please refrain from opening new issues each time regarding the same question, just comment on original issue.
I can't vouch for the specific parts you've linked to work, especially the relay board as it looks to be 5V. You should really do your own research, and set out a detailed plan of how you're going to implement this including the wiring before you buy anything. Have a look around on Google and YouTube if you're totally unfamiliar with relays and ESP8266 programming.
As I said though, I can't offer much more guidance what I've already said. Unfortunately, I have no incentive/time to write as detailed a guide from the ground up as it seems like you need. Please just read around carefully and make sure you grasp the key ideas before committing to anything.

Thank you so much for all the help you have provided
When you say that the relay board is 5V what is the difference between a 3.3V board and a 5V board, will using the 5V board short circuit my sprinklers?

The board you linked will not work with the ESP8266 as it is the wrong voltage.

So my only option for a relay board is 3.3V?

My sprinkler system has an output of 12VAC, so what do I need to buy for that?

My sprinklers are not smart right now and cannot connect to WiFi, so this project will make them smart?


feat add shouldPlay prop

some times the anime should not play
such as when pagination, no item added or removed,
prev page items dispear, next page items show
the anime will make an confuse like the prev page items were removed
and the next page items were added

Changes Unknown when pulling 444166f67848e1612b8e8c2a600f9a0287a2667b on superwf:master into ** on react-component:master**.

不要动画时可以直接替换标签。。。。
table 动画里是这样处理的。。。https://motion.ant.design/exhibition/demo/table-enter-leave;
getBodyWrapper = (body) => {
    // 切换分页去除动画;
    if (this.currentPage !== this.newPage) {
      this.currentPage = this.newPage;
      return body;
    }
    return (<TweenOneGroup
      component="tbody"
      className={body.props.className}
      enter={this.enterAnim}
      leave={this.leaveAnim}
      appear={false}
    >
      {body.props.children}
    </TweenOneGroup>);
  }

额。。好吧，，这个好像没 appear....

恩是没有appear，加个呗

@superwf 可发PR？？参考 animate

恩，我看看弄弄

Changes Unknown when pulling 3c37aa0d30b43bb3f9756a594c17c2d2eac2d636 on superwf:master into ** on react-component:master**.

额。。。。

0.13.0


Makefile deploy target is broken

What happened?
The deploy and undeploy targets need to updated due to the recent kustomize changes (#180). When I run make deploy I get this error:
/Users/johnsanda/Development/k8ssandra/cass-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
cd config/manager && /Users/johnsanda/Development/k8ssandra/cass-operator/bin/kustomize edit set image controller=k8ssandra/cass-operator:latest
/Users/johnsanda/Development/k8ssandra/cass-operator/bin/kustomize build config/default | kubectl apply -f -
customresourcedefinition.apiextensions.k8s.io/cassandradatacenters.cassandra.datastax.com created
serviceaccount/controller-manager created
role.rbac.authorization.k8s.io/leader-election-role created
clusterrole.rbac.authorization.k8s.io/manager-role created
rolebinding.rbac.authorization.k8s.io/leader-election-rolebinding created
rolebinding.rbac.authorization.k8s.io/manager-rolebinding created
configmap/manager-config created
Error from server (NotFound): error when creating "STDIN": namespaces "cass-operator" not found
Error from server (Invalid): error when creating "STDIN": ClusterRoleBinding.rbac.authorization.k8s.io "manager-res-rolebinding" is invalid: subjects[0].namespace: Required value
Error from server (NotFound): error when creating "STDIN": namespaces "system" not found
make: *** [deploy] Error 1

Did you expect to see something different?
cass-operator should have deployed into the cass-operator namespace.
How to reproduce it (as minimally and precisely as possible):

Create a kind cluster -  kind create cluster --config tests/testdata/kind/kind_config_6_workers.yaml --image kindest/node:v1.20.7
Build and load operator image - make docker-kind
Deploy cass-operator - make deploy

Environment
kind

Cass Operator version:
v1.8.0

┆Issue is synchronized with this Jira Task by Unito
┆Issue Number: K8SSAND-958
┆Priority: Medium

This is already done in master.


Add configurable port to website, #3.

Allow customize service port from website.

Detect invalid port configuration and provide default port.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

Will adjust UI layout in another PR.


various cleanups

please go vet
adding missing mutex Unlock

Thanks for this PR!
I do have some questions about some changes I don't really understand though :)

cleaned up.

@Helcaraxan How is the latest code?

Thanks @dajohi and @Helcaraxan !


Problem with ArgumentResolver

I created extension for ZF for integration framework with behat.
BehatZendFrameworkExtension
Till 3.2 everything worked fine with argument resolver, that get services form ZF application.
On project with Behat 3.3, with container, this functionality started to set null in constructor of FeatureContext using Container and my extension.
I assume, that both solutions are now mutually exclusive?
Any option, to add both, with priority? or other solution.

They are exclusive on purpose to remove confusion. There is a concept of priority, but the container resolver has the highest priority there is.
If you really need to surface services from two containers, I'd suggest creating third, aggregate container, delegating to two others.

Due to that, i'm working on https://github.com/timiTao/behat-aggregate-container.
Any suggestions?


doi fix in paper.bib

removed doi.org prefix in two doi fields

Maybe we don't want this PR to be merged


Excluding sites doesn't work

I've tried excluding Youtube since vimari ruins it (I can't comment because the hotkeys override my typing), but it isn't working at all. I tried youtube.com, youtube.com/watch, https://youtube.com, and nothing works. Restarted my browser, too and it still didn't work. What's going on?
Edit: Tried google.com as well and nothing changed.

Same for me.  I downgraded to 1.11 so I could comment on YouTube videos and use Gmail again.

I can confirm this setting works poorly, right now the exact URL is required which makes it useless for youtube since every video has an unique URL. Will try to fix this until next version.

This is fixed and will be included in 1.13.0.


CI/CD: Release quality and methods should be clarified e:2d

For example:

how do we ensure that there are no known security issues?
How do we make sure that the plugins work as expected?
What is our project-wide standard for testing and verification?

Anywhere a user can download a release, it should be made clear what goes into making it release ready.
This includes:

on github releases
on the main docs site
in the main README and CONTRIBUTOR files.

Once the text to be shown is clear then it would be mechanical to display it in the appropriate location. One approach is have a page in the docs site and provide a text link in the required locations.

Generating an SBOM would help show quality.


added search bar

This PR resolves Issue #259

Added search functionality for searching contributors

Sorry, This issue has been resolved already


Modifier -> SwiftUI -> Modal presentations: alert(_:isPresented:presenting:actions:)

Doc:
https://developer.apple.com/documentation/swiftui/view/alert(_:ispresented:presenting:actions:)-4rhk6
https://developer.apple.com/documentation/swiftui/view/alert(_:ispresented:presenting:actions:)-78spw
https://developer.apple.com/documentation/swiftui/view/alert(_:ispresented:presenting:actions:)-9h5um

[ ] Swift implementation
[ ] Elixir implementation

#636 for all alert modifiers. Rejecting


Test isolation validation should include canceling active test waiters in ember-test-watiers

The ember-test-waiters library will soon include an API to cancel all pending waiters. This is a similar concept to where we cancel timers if test isolation validation is triggered:
https://github.com/emberjs/ember-qunit/blob/c27964ad9fb61e6c80959ccdfdca145a3c5a1572/addon-test-support/ember-qunit/test-isolation-validation.js#L94-L100
This will help ensure that we don't leak state from one test to another, potentially 'wedging' the test waiters and creating an inconsistent state.

I'm a bit on the fence here, while I agree that it might seem nice to have I do not think that we can actually cancel the async operation that the waiters are paused on. This means that while the waiters will not pause tests any more, you actually are in a broken state. Silently swallowing that seems extremely bad...

Had a good chat with @rwjblue offline. We agreed that adding this API will likely result in leaks actually occurring, defeating the point of the waiters.
We discussed evaluating settled when a test starts, and if we're not in a settled state, fail hard then so we don't incorrectly signal test failures on successive tests.

@scalvert - Should we close then?


GithubComment creation is not possible when using it is created as part of ObjectTemplate along with Jinja2 templated field

Overview:
We are trying to setup an ephemeral env for ease of development using the resources available with template-controller. Our use case involves creating a GithubComment resource as part of the ObjectTemplate so that we can add a comment to the pull request. This would mean dynamically creating the GithubComment with the pull request ID fetched by ListGithubPullRequests. To achieve this, we will have to use jinja2 templating for spec.github.pullRequestId either with double-quotes (identified as a string) or without it (throws invalid map key error when trying to create resources).
Template controller version used: v0.7.0
Details:
Scenario 1: spec.github.pullRequestId as Jinja2 template with double quotes ("{{ matrix.pr.number }}" identified as string)
---
apiVersion: templates.kluctl.io/v1alpha1
kind: ListGithubPullRequests
metadata:
  name: demo-service
  namespace: demo
spec:
  base: dev
  head: demo-org:.*
  interval: 1m
  limit: 5
  owner: demo-org
  repo: demo-service
  state: open
  tokenRef:
    key: GITHUB_TOKEN
    secretName: demo-service
---
apiVersion: templates.kluctl.io/v1alpha1
kind: ObjectTemplate
metadata:
  name: demo-service
  namespace: demo
spec:
  serviceAccountName: demo-preview-env
  prune: true
  interval: 1m
  matrix:
    - name: pr
      object:
        ref:
          apiVersion: templates.kluctl.io/v1alpha1
          kind: ListGithubPullRequests
          name: demo-service
        jsonPath: status.pullRequests
        expandLists: true
  templates:
    - object:
        apiVersion: templates.kluctl.io/v1alpha1
        kind: GithubComment
        metadata:
          name: demo-service-{{ matrix.pr.number }}
          namespace: demo
        spec:
          github:
            owner: demo-org
            repo: demo-service
            pullRequestId: "{{ matrix.pr.number }}"
            tokenRef:
              secretName: demo-service
              key: "GITHUB_TOKEN"
          comment:
            source:
              text: "Demo comment"

Error:
1 error occurred:\n\t* failed to create typed patch object (demo/demo-service-1; templates.kluctl.io/v1alpha1, Kind=GithubComment): .spec.github.pullRequestId: expected numeric (int or float), got string\n\n

Scenario 2: spec.github.pullRequestId as Jinja2 template without double quotes ({{ matrix.pr.number }})
---
apiVersion: templates.kluctl.io/v1alpha1
kind: ListGithubPullRequests
metadata:
  name: demo-service
  namespace: demo
spec:
  base: dev
  head: demo-org:.*
  interval: 1m
  limit: 5
  owner: demo-org
  repo: demo-service
  state: open
  tokenRef:
    key: GITHUB_TOKEN
    secretName: demo-service
---
apiVersion: templates.kluctl.io/v1alpha1
kind: ObjectTemplate
metadata:
  name: demo-service
  namespace: demo
spec:
  serviceAccountName: demo-preview-env
  prune: true
  interval: 1m
  matrix:
    - name: pr
      object:
        ref:
          apiVersion: templates.kluctl.io/v1alpha1
          kind: ListGithubPullRequests
          name: demo-service
        jsonPath: status.pullRequests
        expandLists: true
  templates:
    - object:
        apiVersion: templates.kluctl.io/v1alpha1
        kind: GithubComment
        metadata:
          name: demo-service-{{ matrix.pr.number }}
          namespace: demo
        spec:
          github:
            owner: demo-org
            repo: demo-service
            pullRequestId: {{ matrix.pr.number }}
            tokenRef:
              secretName: demo-service
              key: "GITHUB_TOKEN"
          comment:
            source:
              text: "Demo comment"

Error:
error: error parsing github-comment-test.yaml: error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{"matrix.pr.number":interface {}(nil)}

Suggested Solution:
Currently, the field spec.github.pullRequestId accepts only int. To handle the above scenario, my suggestion is to change this to type IntOrString k8s intstr type. I can work on this and raise a PR if the solutions looks good.

https://github.com/kluctl/template-controller/pull/59 contains the changes suggested for handling this issue.

@madhukarmmallia-plivo Thanks, I have merged #59 now.
However, I believe that this topic is something that will constantly re-occur, as other places in the k8s world will have the same issue.
The problem here is, that template-controller treats the field as string when it initially parses the yaml. Then, after rendering the templates inside the object template, it can't know if a value that ends up being a number should be treated as a number or as a string now. Right now, it always defaults to emitting a string when sending the resulting json to the k8s api, which then causes failures. This issue is present in all kinds of k8s resources that we have no control of (so we can't introduce IntOrString there).
The solution that always works is to use raw instead of object in templates. This treats the whole object as a string and thus allows to handle all cases in yaml/json parsing.


Chapter 9/cmake presets

I extended and cleaned the presets a bit to fit the recommendations in chapter 9 and switched the ci to use the presets to build

LGTM


MSetAsync Set for one Property to null

Thanks for reporting an issue in NRedisStack! Please update the appropriate text below, as much data as possible really helps!
NRedisStack Version: 0.13.0
Redis Stack Version: 7.4.0-v1
Description:
When using MSetAsync and passing multiple KeyPathValues to it I can not pass in one KeyPathValue with null as value.
I have a fix for this. I need to basically map null to "null", but this is inconsistend with the Set Command.
That one does not accept "null" but only null.
This array:

Leads to this exception:
StackExchange.Redis.RedisServerException: expected value at line 1 column 1
at NRedisStack.Auxiliary.ExecuteAsync(IDatabaseAsync db, SerializedCommand command)
at NRedisStack.JsonCommandsAsync.MSetAsync(KeyPathValue[] KeyPathValueList)

hi @kurtisane , thank you for using NRedisStack and letting us about the case your are experiencing.
i was trying to reproduce the case with null values, yet not successful..
could you check if this exception shows up even when you drop the string value at index 0 in screenshot (the one starts with 2UZb_.....).
i believe the issue is due to misuse of value field KeyPathValue  type for string values.
if that is the case, could you try to do something like below to handle the case for strings;
        values = new[]
             {
            new KeyPathValue("key1", "$.textField1", "\"someText\""),
            new KeyPathValue("key1", "$.textField2", new RedisValue("someText")),
            new KeyPathValue("key1", "$.textField3", null),
        };


how can I change the directory

How can i change the directory?

Added Custom File Path - Directory feature. Can you please test it?

thank you so much


Question: Passing object references

I've got a general question about working with the module and passing object references from an environment like Node, to evaluated scripts and/or scripts running on a page. The specific use case is for developing a module that leverages mocha and headless chrome for CI automation testing. In that case, the Mocha script running in the browser needs to be provided a stdout interface.
There are solutions for that particular use case, such as using DOM events to send and listen for a 'stdout' event, coupled with https://github.com/kumavis/browser-stdout. But I thought it would be particularly useful if passing references was possible. Is that possible now, and if not, what needs to happen to make that possible?

Component
Version

Operating system
Mac OS 10.12.5

Node.js
7.8.0

Chrome/Chromium/...
Version 59.0.3071.115

chrome-remote-interface
latest

AFAIK it's not possible, only JSON object can be passed, as of why I'm not the authoritative source but I think that the problem is that Node.js and the browser are two distinct JavaScript execution environments. You might have more luck if you ask this in the Google Group.
Speaking of general purpose workarounds, I think this problem can be split in two directions:

from Node.js to the browser;
from the browser to Node.js.

Case 1 is easy, you can just call Runtime.evaluate({expression: '/* browser code */'}) whenever you want, e.g., upon a Node.js-related event.
Case 2 is more complex because the interaction must be started (or at least expected) by Node.js, for example, in the browser:
function doNodeAction(param) {
    if (window._nodeAction) {
        _nodeAction(param);
    }
}

While in Node.js:
async function prepareNodeAction(action) {
    // wait for browser
    const param = await Runtime.evaluate({
        expression: `new Promise((fulfill, reject) => {
            _nodeAction = fulfill;
        }).then(() => {
            _nodeAction = null;
        })`,
        awaitPromise: true
    });
    // actually perform the action
    action(param);
}

In this way you can even implement a very limited browser event handler. I do really hope there are better ways to accomplish that...

That's really a pretty solid way to go about it in the near term though. I could in theory create a stub of stdout that simply piped out to node in much the same way. Thanks for giving that some consideration.

The main problem is that you have to re-prepare the Promise after every browser invocation of doNodeAction(param); a while (...) loop would probably do as long as you await prepareNodeAction inside it.
Another problem is that you should somewhat buffer the browser invocations of doNodeAction(param) when window._nodeAction is null.
This is an interesting problem, if you come out with a neater solution or simply want to link to another discussion thread feel free to post it here.

Tangential thought: It really is a shame that there's no built-in event bus for clients. That'd make so much sense.

That'd make so much sense.

True but I see why it has not been implemented yet, at the very least the browser's JavaScript environment should be aware of being inspected and thus provide an API to interact with it, something like window.devtools.postMessage(...) which would trigger some CDP event.
Another hackish solution would be using the Runtime.consoleAPICalled and send events to Node.js using the Console API:
console.log({type: 'event', data: {...}});

Then in Node.js:
await Runtime.enable();
await Runtime.consoleAPICalled(({type, args}) => {
    if (type !== 'log' || args.length != 1 || args[0].type !== 'object' || /*...*/) {
        // skip other Console API calls based on the expected arguments
        return;
    }
    const object = args[0].preview.properties;
    // ...
});

And that's exactly what I ended up doing last night - piggy backing on the Console API. Thanks very much for being so active on this repo and for humoring so many questions about the protocol. It's incredibly helpful.

@cyrus-and I found an interesting quirk with the Runtime.consoleAPICalled method: it would appear that CDP is performing some kind of cropping of text values.
For instance:
let json = JSON.stringify({"suites":1,"tests":1,"passes":1,"pending":0,"failures":0,"start":"2017-08-01T02:35:50.914Z","end":"2017-08-01T02:35:50.996Z","duration":82});
console.log({ json });`

Ends up looking like this:
{ type: 'object',
  description: 'Object',
  overflow: false,
  properties:
   [ { name: 'json',
       type: 'string',
       value: '{"suites":1,"tests":1,"passes":1,"pending":0,"fail…","end":"2017-08-01T02:35:50.996Z","duration":82}' } ] }

Notice the "fail…" bit in the resulting object. JSON.parse will naturally fail, as the string has been made invalid JSON for some reason. It's a bizarre quirk and I can't find any info regarding it.
Any ideas?

I notice this behavior (i.e., string members of objects may be shortened for the sake of preview) in DevTools itself but not via the CDP, I tried with the following and I'm not able to reproduce it:
const CDP = require('chrome-remote-interface');

CDP(async (client) => {
    const {Page, Runtime} = client;
    Runtime.consoleAPICalled(({args}) => {
        console.log(args[0].value);
    });
    try {
        await Page.enable();
        await Page.navigate({url: 'http://example.com'});
        await Page.loadEventFired();
        await Runtime.enable();
        await Runtime.evaluate({
            expression: `let json = JSON.stringify({"suites":1,"tests":1,"passes":1,"pending":0,"failures":0,"start":"2017-08-01T02:35:50.914Z","end":"2017-08-01T02:35:50.996Z","duration":82});
                         console.log(json);`
        });
    } catch (err) {
        console.error(err);
    } finally {
        client.close();
    }
}).on('error', (err) => {
    console.error(err);
});

In my case the console.log is coming from a script block within a simple html file loaded by Page.navigate. eg (truncated for brevity):
<!doctype>
<html>
<body>
  <script>
    console.log(...);
  </script>
</body>
</html>

await Page.navigate({ url: 'file://' + path.join(__dirname, 'test.html') });

I wasn't able to find a consistent pattern to the string length that would trigger that quirk, but I was able to reproduce that quirk consistently. I don't think the issue lies with this module. At the very least we have it documented here as a potential issue.
My workaround, for the purposes of the event bus simulation, was to use localStorage in conjunction with DOMStorage.domStorageItemUpdated  since there's practically no limit on the size of a thing you can set there. I set a localStorage item in the client/html/script localStorage.setItem('bus', ''); to init the value, and reset the value every time the event bus needed to "emit" back to the node app. The value for each set had to be stringified and then parsed in the node app, but it's very effective, and it's significantly simpler to work with than the Console solution - the main reason being there's no need for parsing a complex item tree in the preview property, and no need for a module like https://github.com/ironSource/node-chrome-unmirror to facilitate that.

OK I made a mistake in my previous snippet, I'm not returning an object but just a string. If I return an object then I'm able to reproduce it.
Well, we have accidentally found a solution then: just pass the JSON string directly instead of {json: '{...}'}. In this case no alteration is performed and you can easily get the value with:
Runtime.consoleAPICalled(({args}) => {
    const object = JSON.parse(args[0].value);
    console.log(object);
});

My workaround, for the purposes of the event bus simulation, ...

That's a smart solution, thanks for sharing.


EASI-4649 Upgrade vite & vitest

EASI-4649
Description

Bumps up vite and vitest to current.
How to test this change

Reinstall npm packages and expect business as usual.
yarn install
yarn test
yarn start
yarn cypress:run

PR Author Checklist

[ ] I have provided a detailed description of the changes in this PR.
[ ] I have provided clear instructions on how to test the changes in this PR.
[ ] I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it

e.g. "Approving because I tested it locally and all functionality works as expected"
e.g. "Approving because the change is simple and matches the Figma design"

Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

This is in a good spot for meeting requirements, but just taking a little more time to see if other related upgrades should fit in.

@adamodd would you mind (I know it's a bit of an odd request) pushing up a purposefully failing client test? I think that's the only time the new --reporter=github-actions will actually create anything for us to see 👀
Once the tests run, we can probably just revert the commit!

Force break is in but still don't see any UI hook to the error.
I'm guessing we need to set process.env.GITHUB_ACTIONS === 'true'
https://vitest.dev/guide/reporters#github-actions-reporter
How much would we actually use this since broken client tests should by blocked by our pre commit hook?

Reverted reporting attempts because they failed


docs(sidebar): fix sidebar not expanding on behavior link

This fixes issue #1805

Fails

:no_entry_sign:
All of your entries in CHANGELOG.md should be in the **Unreleased** section!

  Generated by :no_entry_sign: dangerJS


[enhancement] - Better scrolling when using the trackpad

When using the trackpad, scrolling does not happen unless I really swipe a lot. I could not find a way to disable smooth scrolling in the current version of the debugger (0.9.8 alpha), so I do not know how scrolling from the trackpad would behave without that.

This should work better after d560f8c734ba87fd1ea79e2dd5fefb6e3031fe00.

This is way better, thank you!


Migrate device_port_forwarder to null safety

device.dart is too large to easily migrate to null safety, and it is imported by a lot of other files.
Start pulling it apart.  Create a null safe device_port_forwarder file contains ForwardedPort, DevicePortForwarder, and NoOpDevicePortForwarder.  Pull out the relevant tests from device_test.
Part of #71511

Google testing — Google testing passed! wow that worked.


Publishing records in search results refreshes the page

Publishing records in search results refreshes the page.  We want the user to remain in the search results when publishing items.

publish process is still reloading search results page.


Save message hash for every multisig session

Using the SDK search for the state of the transaction, this info will be fetched by frontend. When all signatures are done. Create JWT.
Endpoint Get Transaction: getTransaction
https://docs.safe.global/reference/api-kit

How can I test issues related to multisig in Unit Testing column ?
On which branch? @CarlosQ96 @mateodaza


Rethink signal handling

Default signal handling in Linux could lead the firecracker process to become orphaned.  To prevent this, the SDK sets up some default signal handlers that forward signals along to the firecracker process.  However, this is pretty implicit and not super discoverable unless you read the code, and it may interfere with signal handling that the calling application intends to perform.  We should think about:

what we want signal handling to be
whether the SDK should register signal handlers by default
how this can be made more explicit and less implicit

If I may add my 2 cents as a user of firecracker and this sdk (in some personal experiments), my biggest issue with the SDK's signal handling is that it doesn't unset the handlers after the firecracker process goes away. This ended up interfering with some of my own signal handlers.

In my case, I want to control signal handling from my own process - I would rather have some option to disable the auto-signal handler creation inside the firecracker SDK.

How about having
func (m *Machine) Close() error {
	if err := m.StopVMM(); err != nil {
		return err
	}
	return m.Wait(nil)
}

and let customers kill firecracker by closing the machine?
It is a bit cumbersome than our current signal handling, but more explicit and won't interfere with the host application's signal handling.
We currently try to free resources we made by assuming the application's signal handling policy, but we really don't know about. In Go, providing explicit Close() is more common way of doing that.

For what it's worth, we have a use-case where we do not want signals to be handled by firecracker-go-sdk since we sometimes want to orphan firecrackers and pick them back up later (we only really care about their PID and use meta data to recognize them).
It could be an option in the machine config.

I think #166 is good enough to close this issue.
Regarding the idea I proposed above, StopVMM() is killing a VM forcibly and we are trying to avoid using the method on firecracker-containerd. So calling this method Close() is bit misleading, since it is unsafe.

@kzys I agree.  Closing this.


Removing or update VPC Peering note

Describe the issue here.
VPC isn't currently available (expected for H1/2021). I'm not sure if we should remove this entirely or the pricing language alone. It's caused confusion with a handful of new users who view the option as available today.
Relevant URLs
https://docs.influxdata.com/influxdb/cloud/account-management/pricing-plans/#vpc-peering
What products and version are you using?
InfluxDB Cloud

I don't want this to be removed.  Because NOT having it was also causing confusion.
Folks are searching for VPC....and the point is, we want to gauge the demand. Having the conversation allows us to do that.  Being silent on this does not.
If you want to suggest other language....please let us know.  But, do not remove.


Setup Help With Existing Project

I am trying to configure DDE for existing project. I cloned the repo & placed my codebase in docroot folder inside cloned repo. Did follow the steps here and for settings here. Now when I am trying to run dsh up, I am getting this error.
Vagrant attempted to execute the capability 'configure_networks'
on the detect guest OS 'linux', but the guest doesn't
support that capability. This capability is required for your
configuration of Vagrant. Please either reconfigure Vagrant to
avoid this capability or fix the issue by creating the capability.

DDE is not supported anymore. Please use Docksal https://github.com/docksal/docksal


[BEAM-5092]  Optimize Row comparison.

retest this please

retest this please

retest this pelase

Run Java PreCommit

@timrobertson100  all comments addressed


Add schema compatibility checker for Ruby

This change introduces a module Avro::SchemaCompatibility to perform a full compatibility check between two schemas in Ruby. This compatibility check extends the existing schema matching implemented in Avro::IO::DatumReader.match_schemas. The implementation of the .match_schemas class method has been moved to the new module and is called as part of the full compatibility check.
#read?, #be_read? and #mutual_read? methods have been added to Avro::Schema as a way to invoke the new compatibility checks.
Tests for the new module were based on the test cases from:

lang/java/avro/src/test/java/org/apache/avro/io/parsing/TestResolvingGrammarGenerator2.java
lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java

Additional fixes included:

support for empty records and empty unions in Ruby (these were useful to demonstrate test parity for compatibility checking)
schema promotion between bytes and strings in .match_schemas
schema promotion within complex types in .match_schemas, e.g. an array of ints promoted to an array of longs

Prime: @jturkel

Thanks for reviewing this. I'm going to submit this change to the official repo. I'm also going to merge this change into our fork that has the logical type support.


video chat screen freeze in ios when app goes background to foreground

In ios in  video chat screen freeze in ios when app goes background to foreground. Here screen freeze means toolbar buttons are not clickable for a few seconds and some time few minutes.  I have also implemented the appState and mute the audio and also stop the camera capture like below code :--
componentDidMount() {
AppState.addEventListener('change', this.handleAppStateChange);
}
componentWillUnmount() {
AppState.removeEventListener('change', this.handleAppStateChange);
}
handleAppStateChange = (AppState) => {
if (this.props.selectedUsersIds.length != 0) {
if (AppState === 'inactive') {

}
else
{

if (AppState === 'background') {
  console.log('---background  toolbar---');
  CallService.setAudioMuteState(true);
  this.setState((prevState) => ({isAudioMuted: true}));
  CallService.setvideoMuteState(true);

} else {
  console.log('---active  toolbar---');

  CallService.setAudioMuteState(false);
  this.setState((prevState) => ({isAudioMuted: false}));
  CallService.setvideoMuteState(false);
}

}
}

}
setvideoMuteState = (mute) => {
if (mute) {
this._session.mute("video");
} else {
this._session.unmute("video");
}
};
it works first time but on second try I got this error log 👎
2021-06-22 08:53:32.436621+0530 StudyGroup[5863:500637] [BoringSSL] nw_protocol_boringssl_get_output_frames(1301) [C20.1:2][0x10c16c090] get output frames failed, state 8196
2021-06-22 08:53:32.437986+0530 StudyGroup[5863:500637] [BoringSSL] nw_protocol_boringssl_get_output_frames(1301) [C20.1:2][0x10c16c090] get output frames failed, state 8196
2021-06-22 08:53:32.442700+0530 StudyGroup[5863:500637] TIC Read Status [20:0x0]: 1:57
2021-06-22 08:53:32.442793+0530 StudyGroup[5863:500637] TIC Read Status [20:0x0]: 1:57
Can you please help.
Thanks

setvideoMuteState = (mute) => {
if (mute) {
this._session.mute("video");
} else {
this._session.unmute("video");
}
};

Hello @priyankasaini3 !
I think that you should ignore AppState === 'inactive', use AppState === 'background' instead. Do not use } else {...} after if (AppState === 'background') {...}, because it doesn't specify an exact AppState.
if (AppState === 'inactive') { /* ignore */ }
if (AppState === 'background') { /* mute video track */ }
if (AppState === 'foreground') { /* unmute video track, if it was unmuted before gone to background */ }

Also check the screenshot below to configure your iOS project via Xcode. It may help you to hold stream in background a long time. You are able to mute only video track and left audio working while in background.

Hi,
Thanks for reply. I did the code change according to your guide line and also did the setting in xcode as per of your guidance. But no-luck getting the same issue again I have providing the code and setting below and also providing my log. Please help thanks.
componentDidMount() {
AppState.addEventListener('change', this.handleAppStateChange);
}
componentWillUnmount() {
AppState.removeEventListener('change', this.handleAppStateChange);
}
handleAppStateChange = (AppState) => {
if (AppState === 'inactive') {

  /* ignore */ }
if (AppState === 'background') {
  console.log('---background  toolbar---');
  CallService.setvideoMuteState(true);

  /* mute video track */ }
if (AppState === 'active') {

  console.log('---foreground toolbar---');
  CallService.setvideoMuteState(false);

 /* unmute video track, if it was unmuted before gone to background */ }

}

2021-06-24 16:56:31.888874+0530 StudyGroup[1972:267536] [javascript] ---background  toolbar---
2021-06-24 16:56:31.938903+0530 StudyGroup[1972:268028] [native] [VideoCaptureController] Capture will stop
2021-06-24 16:56:40.948569+0530 StudyGroup[1972:267811] [native] [VideoCaptureController] Capture stopped
2021-06-24 16:57:10.374709+0530 StudyGroup[1972:267597] [BoringSSL] nw_protocol_boringssl_get_output_frames(1301) [C22.1:2][0x10bd76ac0] get output frames failed, state 8196
2021-06-24 16:57:10.375259+0530 StudyGroup[1972:267597] [BoringSSL] nw_protocol_boringssl_get_output_frames(1301) [C22.1:2][0x10bd76ac0] get output frames failed, state 8196
2021-06-24 16:57:10.380620+0530 StudyGroup[1972:267597] TIC Read Status [22:0x0]: 1:57
2021-06-24 16:57:10.380752+0530 StudyGroup[1972:267597] TIC Read Status [22:0x0]: 1:57
2021-06-24 16:58:14.998841+0530 StudyGroup[1972:267397] [native] [VideoTrackAdapter] Mute event for 0 7A542731-A7E0-49A2-9BFA-EAA1E08D5988 09568463-f938-49b5-a589-3a14d883da39
2021-06-24 16:58:17.492785+0530 StudyGroup[1972:267536] [javascript] ---foreground toolbar---
2021-06-24 16:58:17.494675+0530 StudyGroup[1972:268153] [native] [VideoCaptureController] Capture will start

As I understand toolbar's buttons don't work (not clickable) some time, right? Does the video continue working after app goes to foreground? Please, clarify

when the app goes to foreground  the below function trigger (if (AppState === 'active'))  after some time in-fact the app is in foreground that is why toolbar's button  and  CallService.setvideoMuteState(false); not works on time.
if (AppState === 'active') {
console.log('---foreground toolbar---');
CallService.setvideoMuteState(false);
/* unmute video track, if it was unmuted before gone to background */ }

both toolbar's buttons  and video not works when the app is in foreground because AppState=== 'active' trigger after some time and I don't know why this happen. Please help thanks.

Did you swipe from top to bottom (show/hide iOS Notification Center)?
I know that ”inactive”/”active” state triggers when show/hide Notification Center.
Try to use ”inactive” AppState instead of ”background” on iOS.
The code below I use to manage this case (sample):
handleAppStateChange = async (appState) => {
    const isActiveAppState = appState === 'active';
    const isInactiveAppState = Platform.select({
        ios: appState === 'inactive',
        android: appState === 'background'
    });

    if (isInactiveAppState) {
        this.setMuteVideo(true);
    } else if (isActiveAppState) {
        this.setMuteVideo(false);
    }
};

Hi ccvlad,
I have implemented the above code provided by you but I got the same error again. I think when app come from background to foreground then something is happening which delay the appState to update from inactive to active state.

Try to check your AppState listener. Add console.log(appState) and make sure that it is working correct.

Hi ccvlad,
I have checked it in console.log(appState) and come to know that appState get active after 1 to 3 min later when the app is in foreground. So toolbar and video not works for for 1 to 3 min when the app is in foreground.

Can we need to implement CallKit and VoIP push notifications to solve this issue.

Hi ccvlad,
I have solved the issue , actually the issue is related to the timer which we have implemented during the call duration. when app goes in background it create the problem that is why toolbox freeze.
Thanks for your time and help.

Closed due to inactivity. Please create a new issue if needed.


Fiddle UI improvements

@Dkendal for some reason I can't get tests to pass - unable to require.resolve the json modules, have you seen this before or have any ideas?

CLI tests don't seen to work on main branch either so maybe we can ignore in regards to this PR as it's unrelated and worth a look separately

@steve8708 the require.resolve issues are resolved, the other errors look (more) legit, did something change with the jsx-lite/core build process?

Shouldn't have no. I'm seeing different errors locally (trying to run .d.ts files as tests and complaining you cannot have files with no tests)

I ran into that as well it was just a left over from running TSC and then getting compiled for some reason. You can delete any .d.ts and js files there. If there are any js files they'll break the tests as they ll get sourced instead of the ts files.

Alternatively rungit clean packages/cli/src -i

Still am having issues getting it to work - can you take over on getting cli tests passing when time permits?

Sure thing

@steve8708 fixed

@Dkendal 🙏 🙏🙏


Remove GoPath dependency from gomock reflection

The current gomock.bzl implementation declares a dependency
on the GoPath provider to virtualize a GOPATH in the execution
of mockgen.
Upon further investigation and experimentation, it appears that
this isn't necessary for reflect-based mock generation. This opts
to remove the GoPath dependency from the reflect path.

This is great. Thanks!


Test on CI

Originally opened 2019-11-17 15:47 EST by @remram44
Find a way to run this on CI, and run some sort of integration tests.

Originally posted by @remram44
Added the CI machinery and the skeleton of an integration test. To be finished after e60e3e9bf009b3f8aba2590fdeeaba0bc3f7eb64

Done by 3cc1a547


Replace EventDispatcher with EventEmitter

Replace hand-rolled event dispatching system with EventEmitter.
@brian-gates you were right
CC @jonathanong

Jon caught a rogue await in the EventDispatcher I wrote and, rather than fixing it, I replaced it with what you suggested.


Added dispose() for bottomSheet.

BottomSheet haven't dispose() method. I added this method for dispose of the BottomSheet with its controller (Like Dialog).
  @override
  void dispose() {
    if (Get.smartManagement != SmartManagement.onlyBuilder) {
      WidgetsBinding.instance!.addPostFrameCallback(
          (_) => GetInstance().removeDependencyByRoute(name)); // name = "BOTTOMSHEET: ${builder.hashCode}";
    }
    super.dispose();
  }

Fixes #1127
Fixes #1351

Pre-launch Checklist

[-] I updated/added relevant documentation (doc comments with ///).
[-] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[✓] All existing and new tests are passing.

Thanks!
LGTM

There is still a problem with this, reopening does not call onReady


Cannot get package with nuget

Hi, I am trying to install the package in a Unity Project.
I am a bit of a noob regarding .NET frameworks so I am at lost here.
When I Install-Package TorchSharp -Version 0.95.4 I get
Could not install package 'TorchSharp 0.95.2'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.7.1', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

Other packages in nuget works (get installed without problem) so the issue seems to lie with the TorchSharp package. Any idea?

TorchSharp is for .NET 5 and above.  It won't work with .NET Framework.
Thanks

@ValerioB88 I using Godot 3D engine which will support .NET6 soon.

Unity engine will support .NET5 and up. Preview for now.
see:
https://forum.unity.com/threads/net-standard-2-1.757007/


Deployment Failed, Error: No credentials found

For some not yet identified reason, the azure/webapps-deploy@v3 (I also tried<EMAIL_ADDRESS>fails with the following error:
Error: Deployment Failed, Error: No credentials found. Add an Azure login action before this action. For more details refer https://github.com/azure/login

My GitHub actions workflow job looks as follows:
  deploy:
    name: Deploy to Azure Web App
    runs-on: ubuntu-latest
    environment: dev
    needs: [build_test_publish, iac_apply]
    steps:
      - name: Download artifact
        uses: actions/download-artifact@v4
      - uses: azure/login@v2
        with:
          client-id: ${{ secrets.AZURE_CLIENT_ID }}
          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
      - name: Deploy to Azure Web App
        uses<EMAIL_ADDRESS>        with:
          app-name: my-app
          package: .
      - name: Logout
        run: |
          az logout

The steps Download artifact and azure/login@v2 both succeed. To set up the secrets, I followed the official docs here and the jobs before the one above succeed with the same secrets (iac_apply for example). I also enabled debug logging where I saw that az account show is executed and the next log entry was {} so I assume the account show command returns an empty object. But I have no idea why. Would be happy about any suggestions, hints or resolutions.

We have the exact same setup and have the exact same problem. The az login work for Azure/functions-action but NOT for azure/webapps-deploy with a private endpoint. The workaround is to use<EMAIL_ADDRESS>. Why this has been neglected for so long, the action is already on 3.0.2. Who's even using the versions above 2.2.9 if they are not working?

@borislavml unfortunately v2.2.9 didn't work either (same error msg). As a workaround I used az cli: https://github.com/rufer7/dotnet-webapi-using-az-key-vault-secret-rotated-by-terraform/blob/main/.github/workflows/ci-cd.yml

Hello @rufer7 . Are you by any chance using AZURE_CORE_OUTPUT: none in env of the workflow? If yes, then that is causing the issue. Do let us know.

Hello @prathambande yes I do. I wasn't aware of that
this is causing the issue. I'll check in the next days. If this helps I can create a PR to extend the README with a troubleshooting section. Would that be appreciated?

@prathambande works (see here). Thx a lot!


Repo not found

git clone https://git-codecommit.eu-west-1.amazonaws.com/v1/repos/awsome-terraform-example-container
fatal: repository 'https://git-codecommit.eu-west-1.amazonaws.com/v1/repos/awsome-terraform-example-container/' not found

Hi @mobious999 .
Thanks for open this issue. First of all, in which region have you deployed your stack? The documentation and stack in our example is being deployed on eu-west-1. If you are using a different region, the codecommit repo should be deployed in a different region, that's why you are getting a "not found".
https://github.com/aws-samples/aws-cdk-tfsec/blob/main/docker_pipeline/docker_pipeline.py#L30

Hi @cesarpball, I've tried us-east-1 and us-east-2.


Fix wrong encryption message for block and file storage

Resolve: bz#2038873
Signed-off-by: Timothy Asir Jeyasingh<EMAIL_ADDRESS>

@bipuladh Please review

@bipuladh , @SanjalKatiyar Please review

/retitle Bug 2038873: Fix wrong encryption message for block and file storage

/approve
/lgtm


[FIX] "Unable to find any packages" on the website for a brief time

Describe the bug
It's a low priority bug.
When loading the gallery, for a brief period of time the message "Unable to find any packages" appear even if packages are found.
To Reproduce
https://nest.land/gallery
Expected behavior
"Loading packages" message should stay longer
Screenshots

Desktop (please complete the following information):

OS: [e.g. macOS]
nest.land Version [e.g. 0.1.0]

Smartphone (please complete the following information):

OS: Windows & Android
Browser Chrome & Firefox
nest.land Version 0.1.3

This issue occurs because of the way I wrote the gallery loading order. I'll see if I can find a solution to this. I wrote this code in the middle of the night, so hopefully I'll be able to think clearer!


[BUG] Missing apiType error when creating Cognitive Search Prompt Flow connection using the UI

Describe the bug
When creating a new "Add Cognitive search connection" in prompt flow UI, we get a 400 bad request with this message:
"Required metadata property ApiType is missing".
When we look at the openAI connection, it does have an "apiType" textBox, but not for Cognitive Search. Not sure while it would be required anyway.
I manually modified the payload to include "api_type":"azure" but I still get the exact same error message.
How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

In prompt flow UI, try to create a new Cognitive search connection. It fails everytime.

Expected behavior
Successfully Add a Cognitive Search connection in prompt flow without having to specify apiType.
Screenshots

@marcalap since here is to track the issue of the open source version of prompt flow, the issue reported is about AML Studio portal. Could you help open ocv through the portal UI. I will also try if I can repro from my side in portal. Thanks a lot!

Thanks.
it's fixed.


How to install OAT compiler

Hi,
I'm studying control-flow attestation in embedded devices focusing on your work which is very interesting. In order to test your work i have been trying to install the oat compiler but i can not. Can you please help me step by step to install it ? Thank yo so much.
Here is my questions:
1-  I downloaded the latest version of cmake from (https://cmake.org/download/) and then i installed it following these instructions (https://cmake.org/install/) . Then i was wondering what the build directory should be. Should it be ad independent directory or the cmake directory inside the oat-llvm40 directory ?
Thank you

Hi there,
You can refer to the Quick Start section in this doc: https://github.com/RiS3-Lab/OAT-Project/blob/master/oat-llvm40/docs/CMake.rst
Let me know if you have any further questions.

Zhichuang

Hi there,
You can refer to the Quick Start section in this doc: https://github.com/RiS3-Lab/OAT-Project/blob/master/oat-llvm40/docs/CMake.rst
Let me know if you have any further questions.
* Zhichuang

Hi there,
You can refer to the Quick Start section in this doc: https://github.com/RiS3-Lab/OAT-Project/blob/master/oat-llvm40/docs/CMake.rst
Let me know if you have any further questions.
* Zhichuang

Should the build directory be an independent directory or a directory within oat-llvm directory ?
Thank you

Hi there,
You can refer to the Quick Start section in this doc: https://github.com/RiS3-Lab/OAT-Project/blob/master/oat-llvm40/docs/CMake.rst
Let me know if you have any further questions.
* Zhichuang

Should the build directory be an independent directory or a directory within oat-llvm directory ?
Thank you

You should create one outside the source directory. Like:
mkdir build

Hi there,
You can refer to the Quick Start section in this doc: https://github.com/RiS3-Lab/OAT-Project/blob/master/oat-llvm40/docs/CMake.rst
Let me know if you have any further questions.
* Zhichuang

Should the build directory be an independent directory or a directory within oat-llvm directory ?
Thank you

You should create one outside the source directory. Like:
mkdir build

Ok i got i, so for the step number 4 should i download the llvm source code or all necessary files are inside the oat folder ?

Ok i got it, so for the step number 4 should i download the llvm source code or all necessary files are inside the oat folder ?

oat-llvm40/ is the source repo for llvm, you should use it.

Ok i got it, so for the step number 4 should i download the llvm source code or all necessary files are inside the oat folder ?

oat-llvm40/ is the source repo for llvm, you should use it.

Yes, i did it! First i created the foder mkdir build, after that cd to this directory: cd build and then i run the command cmake path/to/oat-llvm40. However after CMake has finished running, i tried to run cmake --build command within the build directory but i got these messagge Usage: cmake --build <dir> [options] [-- [native-options]]

Ok i got it, so for the step number 4 should i download the llvm source code or all necessary files are inside the oat folder ?

oat-llvm40/ is the source repo for llvm, you should use it.

Yes, i didi it! However when i build the llvm using the command 'cmake --build .' i got this error message :
[ 62%] Linking CXX shared library ../../lib/libLTO.so collect2: fatal error: ld terminated with signal 9 [Killed] compilation terminated. tools/lto/CMakeFiles/LTO.dir/build.make:261: recipe for target 'lib/libLTO.so.4.0.0' failed make[2]: *** [lib/libLTO.so.4.0.0] Error 1 make[2]: *** Deleting file 'lib/libLTO.so.4.0.0' CMakeFiles/Makefile2:15272: recipe for target 'tools/lto/CMakeFiles/LTO.dir/all' failed make[1]: *** [tools/lto/CMakeFiles/LTO.dir/all] Error 2 Makefile:155: recipe for target 'all' failed make: *** [all] Error 2
Thank you.

Can you double-check that you basically followed the following sequence?
#Assume you are in the current directory of OAT-Project/
mkdir build
cd build
cmake ../oat-llvm40/
cmake --build .

Btw, when you run cmake ../oat-llvm40/,  is there any warnings or errors?

Can you double-check that you basically followed the following sequence?
#Assume you are in the current directory of OAT-Project/
mkdir build
cd build
cmake ../oat-llvm40/
cmake --build .

Btw, when you run cmake ../oat-llvm40/, is there any warnings or errors?

No there is not. I think it is a problem of memory exhaustion on the server


Declaring prototype methods in loops

Any reason defining prototype methods works well inside of if statements, but it doesn't work in loops?
class Foo
  if foo
    bar: 123 # Works well
  while foo
    bar: 123 # UNEXPECTED 'OUTDENT'

Seems like a bug...the following works:
class Foo
  if foo
    bar: 123
  while foo then bar: 123

This also works:
class Foo
  while foo
    1
    bar: 123

Seems like it doesn't work only when its the first statement in the loop?

→ #981


SAMZA-1293: Enable partition expansion of input streams (SEP-5)

@lindong28 : Perhaps I missed the discussion on the SEP. Can we please send out a [DISCUSS] email to open source?

@vjagadish1989 Thanks for the reminder. The KIP is still work-in-progress and it can be found at https://cwiki.apache.org/confluence/display/SAMZA/SEP-5%3A+Enable+partition+expansion+of+input+streams. I am still working on the proposed change section for "Handle partition expansion while tasks are running". I will send out the DISCUSS email after the KIP is completed. I have opened this pull request for ease of preliminary review and discussion.

@lindong28  I would question the motivation for this PR or even SEP, when there has been no discussion around it. Since I don't have any context, I am more inclined towards a -1 for this PR.
It is difficult for Samza community and developers to review your changes without any context. Please start a discussion in the mailing list so that everyone is on the same page and we can make progress.

@navina This pull request is ready for official so there is no need for something official such as +1 or -1. I will start discussion thread when the SEP is ready.

We will re-open pull request after SEP-5 discussion.


Feature request: export the schema as a GraphQL type language string

It looks like apollo-codegen introspect-schemat only outputs a .json file; could it instead output a .js file with a GraphQL type language string that would work with https://github.com/apollographql/graphql-tools?
From:
http://dev.apollodata.com/tools/graphql-tools/generate-schema.html

Inverse issue: https://github.com/apollographql/graphql-tools/issues/366

I'm now using and recommending the new graphql-cli and graphql-config standards: https://www.graph.cool/blog/2017-08-01-graphql-config-and-cli-aeghee3di9. Would be great if this repo gets updated to use them as well :)

I think it's a great idea to be able to output in both formats.

Closing for lack of activity. Feel free to reopen if someone is going to work on it :)

Any update on schema file export?

It would also be great to be able to export a schema without looking at the context. So there's no longer a need to feed it with an ever changing token just to get a schema exported.
Could this be reopened please?


fix #1767

Currently, when a node allows SSL/port:3001 and does not provide a stable connection for WebSockets subscription the wallet fails to login.
Proposed solution:
fallback for HTTP/port:3000 and retry the connection, in case it fails wallet should fall-back to a different node seeking a valid Websocets connection.

I had created the PR related to the WebSocket issue.
https://github.com/symbol/statistics-service/pull/108
Should we wait for this merge then only update the wallet apps?

I tested following scenario (which I think works on 1.0.8)

Choose node X in profile Y
Close app
Stop node X
Open app and try login to profile Y

Result: Login is not possible (same error as previously)
===
Other issue is that if we have "broken" node and it will be returned by statistics service then we are also unable to login because /network/fees/transaction failing. You can simulate by setting node https://node.finefettle.life:3001/network in local storage as selected node.
Currently this node is broken. Call https://node.finefettle.life:3001/network/fees/transaction returns error 500:
https://node.finefettle.life:3001/network/fees/transaction

{
"code": "Internal",
"message": "ENOENT: no such file or directory, open '/symbol-workdir/api-node-config/config-node.properties'"
}

@cryptoBeliever

I'm wonder what will happen if REST is available only over https (no http)? And no wss:3001 or ws:3000 is available. It will switch to another node?

yes, it should switch to a different node.
for the second scenario if endpoint network/fees/transaction returns 500, if we stopped calling that endpoint on login/import accounts the case when a user has any transactions that need rentalFees like namespaces/mosaics in history we won't be able to display them correctly.

for the second scenario if endpoint network/fees/transaction returns 500, actually we need to call that endpoint on login to be able to display namespaces/mosaics transactions as the wallet needs rental fees to display them correctly.

@bassemmagdy I'm not asking to not call this endpoint but broken node should not block user from login.

@yilmazbahadir after discussion with @cryptoBeliever we agreed to separate the rental Fees issue into a new one and to be addressed in a different branch.

There 2 changes recently made in the statistics service:

NodeInfo.apiStatus.webSocket object https://github.com/symbol/statistics-service/blob/8ea683a3e75591f6de9b04f7f8c106edda36466a/openapi/openapi.yml#L315
Filtering secured(HTTPS && WSS) nodes only.

PR https://github.com/symbol/desktop-wallet/pull/1777 integrates statistics-service openapi client with these changes.
We should be using apiStatus.webSocket.url instead of falling back to a different websocket protocol logic here.
You will find a new field wsUrl in the NodeModel class. We should be using that field to connect to a websocket, if not successful then try a different node.

We should be using nodeModel.wsUrl instead of trying to calculate ourselves here => https://github.com/bassemmagdy/symbol-desktop-wallet/blob/10381d9fd7d16b5b2d4760f53787604cdcc3ca4d/src/services/NetworkService.ts#L181

@yilmazbahadir the issue is it's not available (nodeMode.wsUrl) before creating the nodeModel, which has the createRepositroyFactory() as a part of it, so we could update the HTTPS nodes the same way as we do for HTTP ones.

@yilmazbahadir the issue is it's not available (nodeMode.wsUrl) before creating the nodeModel, which has the createRepositroyFactory() as a part of it, so we could update the HTTPS nodes the same way as we do for HTTP ones.

Should we change the order of calls instead?
First call NodeService.getNodesFromStatisticService and then the others?

Looks good to me, can be merged after the checks are successful.

@bassemmagdy
The following scenario doesn't work again:

Choose node X in profile Y
Close app
Stop node X
Open app and try login to profile Y

Result: Login is not possible (same error as previously)
You can simulate node down by manually changing selected node in local storage to non-existent.

After latest fixes all good :+1:


Separated AI and User Chat

This pull request implements the separation of AI responses and user messages into distinct areas within the chat interface.
Changes

User Messages Area:

Added a separate section for user messages.
Displayed user messages with a distinctive style and avatar.

AI Responses Area:

Added a separate section for AI responses.
Displayed AI responses with a different visual style and avatar.

Layout Adjustments:

Ensured a clear separation between user messages and AI responses.
Adjusted the layout to improve readability and user experience.

I have made the necessary edits to the files as discussed. The changes include:

Updated the #header h1 CSS property to display 'gitNarrator' instead of 'GITNARRATOR' by removing the uppercase text-transform property and adjusting the font size to 45-50px.
Made the "User Messages" and "AI Responses" headers static to remain visible while scrolling.
Ensured that the "User Messages" area and the "AI Responses" area scroll uniformly together.
Adjusted the layout to ensure user messages and AI responses are on the same line for better readability.
Added a distinct avatar for AI in the response area.

Thank you for reviewing these changes.


Support for multiple IPs in a A/AAAA DNS record

[Idea|Proposal]
So currently, nats uses the net package to create a TCP connection to the (NATS) server.
The current implementation basically takes the first IP from the domain name and uses it to create a TCP connection.
For users that can’t implement different loadbalancing techniques through the DNS, using the first IP from the record is kind of a bummer and kind of forces the servers to have multiple domains (as only the first IP is used).
What would be really cool, is that before or while creating the TCP connection to the server, the dns resolution returns all the IPs and uses them as nats server endpoints to connect, enabling reconnecting to all the IPs in the record.
Let me know what you guys think!

We do this for the Go client now so this will probably make sense.

See https://github.com/nats-io/node-nats/blob/master/examples/expander

:D this does not seem like support from your side :D but thanks for the example tho!

Hey @aricart any reason we should not add this into base like we do with Go client?


Implemented gradual rollout with hotfix support

Gradual rollout feature

PendingVersion and PendingVersionTime in the state are never read. if they are only there for troubleshooting consider removing them altogether and including in "status" page the current scheduled upgrades.
They look like something that was left behind from a previous implementation approach. unless I missed something

They are exposed via the /status endpoint which is reflected in the healthcheck/status.json mechanism in Boyar. Meaning we will see this info in the status page. I added it explicitly so once we release a gradual version we could easily see when every validator is planning to upgrade to it.

That was what I thought - my suggestion was to remove them from the snapshot because they have no functional value there and they appear to be stored there for functional reasons.

That was what I thought - my suggestion was to remove them from the snapshot because they have no functional value there and they appear to be stored there for functional reasons.

hmm... the only sources of data for the endpoint renderers (/node/management, /vchains/management, /status) is the state and the config (which is static on launch). I'm not sure how elegantly to pass this data to the renderer if it's not in the state.
The way I look at state is all the current "persistent" state of the service. Eventually we will want to implement some persistence for this service so it will be able to restart without reconstructing the state from zero. The way to go IMO will be to write the state JSON to disk after every poll. When we do this, I will really want these fields there too, because I could reconstruct the timers of a pending upgrade based on this state information (meaning the service was restarted when there was a pending upgrade scheduled but not yet performed).
In other words, this information feels like the current state of the service.
The reason I also have the timers map in the imagePoll object is that it's a JS timer and it's not serializable so I couldn't put it inside the state.

The way I look at state is more of a "redux"/"mobx"-like state of the service, and not necessarily Ethereum state based on Ethereum events.

i understand... just for the sake of argument - in this case I'd probably use a simple logic timer that wakes up every minute and checks the model for upcoming upgrades to implement. this way the service is simple and the state serves as source of truth.. but either way nice

Yeah, it's a good idea. I considered it instead of the setTimeout timer. Especially since setTimeout has a max limit of about 40 days. The problem was I wanted to poll this every second (current docker hub poll is every 3 minutes) so this meant creating a new task. We already have 2 main tasks (Eth block sync and docker hub poller), and adding another big task just for this was also ugly.. so I went for the timer option.. also another task means monitoring for the task, because it may die on exception..


PlayAnim statement and RenAnim node

Some statement to play animations  from RenAnim - I will be "anim".
RenAnim will be AnimationPlayer Node that have global Ren id and it will allow to animate ren statements.

Done as anim statement and RenAnimPlayer node


HSEARCH-3348 Consider backend TCK and test utils as test code during the Sonar analysis

https://hibernate.atlassian.net//browse/HSEARCH-3348
It's a rather ugly hack, but I couldn't find any other way. At least it should not cause much maintenance hassle.
Results of a full analysis after this patch: https://sonarcloud.io/project/activity?branch=sonartest-yrodiere&id=org.hibernate.search%3Ahibernate-search-parent&selected_date=2018-09-11T11%3A54%3A22%2B0000
To be compared with: https://sonarcloud.io/project/activity?id=org.hibernate.search%3Ahibernate-search-parent&selected_date=2018-09-11T12%3A13%3A24%2B0000
So yeah, that's quite a lot of noise we got rid of.

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.608%

Totals

Change from base Build 8:
0.0%

Covered Lines:
10095

Relevant Lines:
11656

💛  - Coveralls

Looks good.

Merged, thanks


add timestamp_hint to the node uptime extrinsic

the report_uptime extrinsic need to accept also second argument timestamp_hint which is the timestamp of the node at the time of reporting the uptime.
The extrinsic will still ONLY use the timestamp of the block, but the hint is ONLY used to make sure that the report is in an acceptable range (say 30 seconds before the current timestamp) any hints that are much older (or in the future) should instead return an error.
This is to make sure nodes that fails to report uptime duo to connection error that they will eventually fail (in case low level client tried to reconnect)

A thing to take into account here is that when this extrinsic changes input and the release is rolled out is that nodes who don't run the "new" code yet, will get errors posting the uptime extrinsic. We need to make sure that this does not affect the minting in any way.

we already have UpdateNodeUptimeV2


ThingML as a maven dependency

Hi,
There is an issue when using ThingML as a maven dependency, maven fails to import it, it seems that there is a problem in the repository. I get this error :
Failed to collect dependencies at org.thingml:compilers.registry:jar:2.0.0-SNAPSHOT -> org.thingml:compilers.c:jar:2.0.0-SNAPSHOT -> org.thingml:compilers.framework:jar:2.0.0-SNAPSHOT -> org.thingml:thingml:jar:2.0.0-SNAPSHOT: Failed to read artifact descriptor for org.thingml:thingml:jar:2.0.0-SNAPSHOT: Could not find artifact org.thingml:language:pom:2.0.0-SNAPSHOT in thingml-snapshot

Hi,
We used to have a Maven repo, but unfortunately, it is not maintained/available anymore... @ffleurey when do you plan to have a public Maven repo available?
I am trying a solution based on jitpack.io, but I cannot (yet) make it work... I'll keep you updated if I succeed. Maybe you can also try jitpack? Seems like a neat solution if we can get it to work...

As an alternative to jitpack.io, I could make a Maven repo into a mvn-repo branch  on the ThingML repo... what do you think @ffleurey ???

I ended up compiling the source code directly from the repo and adding the jar to my project,
			<groupId>org.thingml</groupId>
			<artifactId>thingml-registry</artifactId>
			<version>1.0</version>
			<scope>system</scope>
			<systemPath>${project.basedir}/path/to/thingml-registry.jar</systemPath>
		</dependency>```

I suggest that you remove the maven option from the readme (as it is not working)

OK, we should probably look into this: https://help.github.com/en/articles/about-github-package-registry#supported-clients-and-formats


Convert anti-air

Some gets created for default HoI4, so find a method to convert it. Or formally decide we don't want to do so.

There are fifteen total in 1936. It's not quite enough to make it worthwhile to convert.


Consider setting IndentBlanklineContextStart

indent-blankline.nvim recently added support for underlining context. By default it looks like this with Catppuccin (Mocha palette).

In my opinion it looks better when the underline matches the indent line. By setting a custom highlight I can make that happen.
vim.cmd([[highlight IndentBlanklineContextStart guifg=#CDD6F4 gui=underline]])

Perhaps this should be the default behaviour of catppuccin/nvim?

Added on the dev branch: https://github.com/catppuccin/nvim/commit/afd581cdfa1f50e6d14aea77f50de168fc7296c1

That works perfectly, thank you @nullchilly!
re: fg vs sp... yes, @lukas-reineke schooled me on that. I seem to have copied an older version of that line into this issue, my bad.


[#5976] Improvement(bin):Add validation checks to the startup scripts to prevent incorrect usage

What changes were proposed in this pull request?

Add file suffix ‘template’ to the following scripts:

bin/gravitino.sh
bin/common.sh
bin/gravitino-iceberg-rest-server.sh

Add a validation check on GRAVITINO_VERSION in the script bin/common.sh  ( renamed to bin/common.sh.template ) with the followings :
GRAVITINO_VERSION=GRAVITINO_VERSION_PLACEHOLDER
if [[ "$GRAVITINO_VERSION" == *_VERSION_PLACEHOLDER ]]; then
  echo "GRAVITINO_VERSION is not set. Please make sure you are running the script from the distribution/package/bin and before running the script, run './gradle clean build -x test compileDistribution'"
  exit 1
fi

Update the following tasks in the root build.gradle.kts as described below :

compileDistribution
compileIcebergRESTServer

 eachFile {
      if (name == "gravitino-env.sh" || name == "common.sh") {
        filter { line ->
          line.replace("GRAVITINO_VERSION_PLACEHOLDER", "$version")
        }
      }
    }

Why are the changes needed?
To prevent incorrect usage with startup scripts
Does this PR introduce any user-facing change?
No
How was this patch tested?

The scripts below will exit with status 1 and print an error message with the correct instructions

cd bin
gravitino.sh.template start
gravitino-iceberg-rest-server.sh.template start

correct way to run gravitino :

./gradle clean build -x test compileDistribution

cd distribution/package/bin

./gravitino.sh start

./gravitino-iceberg-rest-server.sh start

This smells like an over engineering effort although I do appreciate the intention.

@liuchunhao Thank you for your improve user experience.
Some Gravitino new user do not know the need compile the Gravitino first, but directly execution bin/gravitino.sh in the project root path, and find that it cannot be used, causing confusion to new users.

I will use your PR to test, because gravitino.sh is very important. So, I need some time to review this PR. Thanks.

I ran ./gradle clean build compileDistribution with all test tasks, and everything seems fine.
After launching ./gravitino.sh start, I sent an API call to /api/version, and it worked fine.


refactor(#117): Give special group name to test keywords

The group name is 'typescriptTestKeyword'

HiLink the typescriptTestKeyword as Keyword, personally think it's more suit than Constant.

Got it, will update.

Updated.
As I'm not quiet sure what's the original intend to highlight the none contained auto-generated groups as Structure, I just leave it as is and override it in the common.vim to Keyword.

I have updated the generating script. I think it should get contained statement removed.

Updated and regenerated.

Thanks!

Why would this not be scoped to type Function since these are, indeed, functions. Can we please reconsider this?

@dsifford Yes they are just functions, but these functions are widely adopt by test runners and almost the standard APIs for testing. Here we want to detect these special functions and give them a group name so that it gives theme the possibility to 'theme' these groups differently.
I don't think the theme should have the responsibility to detect special languages' syntax/special stuffs, it should leverage on the syntax plugins, also that's why we want these syntax plugins.

Right, but the syntax should not be the arbiter of deciding whether or not the "special" functions receive "special" highlight colors. That is the responsibility of the theme.
The syntax can, and sometimes should, apply a special, more specific scope of  function (as done here) but that scope should not make any decisions about whether or not a function should be colored like a keyword. That is the responsibility of the theme. Period.
If the decision is to move forward with this, I'm going to have to fork this repo and maintain it myself, because I am strongly against this decision.

@dsifford I think I misunderstood your initial meaning. I'm ok with this, to 'scope' the typescriptTestGlobal to Function. @HerringtonDarkholme If you are ok with this I will create another pr for the changes.

Yes, that's what I meant. Sorry for maybe coming off rude or hostile before. Hadn't had my breakfast yet. :confounded:

That's ok, these arguments make the things we rely on moving forward.


Update legend formatting in DefaultAzureCredential flow diagram

Clean up the DAC auth flow diagram's formatting

API change check
API changes are not detected in this pull request.