cairo: add patch to fix crashes on darwin

Description of changes

Apply fixes from https://gitlab.freedesktop.org/cairo/cairo/-/issues/420
This patch is applied by Homebrew and MacPorts as well.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This should target staging, see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging for instructions.

Sorry for the noise changing from master to staging..

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/963


GetIsConjugated() cannot recognize the conjugation of Ethylene.

Dear developers,
Thanks for your kindly contribution! I met a simple issue about the conjugation recognition of C=C bond in Ethylene.
Describe the bug
GetIsConjugated() cannot recognize the conjugation of Ethylene.
To Reproduce
M2 = Chem.MolFromSmiles('C=C')
M2 = Chem.AddHs(M2)

Chem.SetConjugation(M2)

for bond in M2.GetBonds():
    idx1 = bond.GetBeginAtomIdx()
    idx2 = bond.GetEndAtomIdx()
    print(atoms[idx1].GetSymbol()+str(idx1), atoms[idx2].GetSymbol()+str(idx2), bond.GetIsConjugated() )

Output:
C0 C1 False
C0 C2 False
C0 H3 False
C1 C4 False
C1 H5 False

Expected behavior
C0-C1 GetIsConjugated() should be True.
Configuration (please complete the following information):

RDKit version:  rdkit-pypi in /usr/local/lib/python3.10/dist-packages (2022.9.5)
OS: Colab
Python version (if relevant): 3.10.12
Are you using conda? no
If you are using conda, which channel did you install the rdkit from?
If you are not using conda: how did you install the RDKit?

Additional context
Add any other context about the problem here.

Why do you consider Pi system in ethylene as conjugated?

Conjugated means : have at least two unsaturated bonds in conjugation, so a Pi system ...C=C-C=C-C=C-... One single unsaturated bond is not "conjugated". Le mar. 5 déc. 2023 à 11:05, Piotr Wawrzyniak @.> a écrit :
…
Why do you consider Pi system in ethylene as conjugated? — Reply to this email directly, view it on GitHub <#6933 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJBWYTO46JUEMZJCMZMCNDYH3WWVAVCNFSM6AAAAAA7RQKM56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBQGQZDQOJUG4 . You are receiving this because you are subscribed to this thread.Message ID: @.>

Aha! Thank you! I agreed.


Implement empty ranges RFC

Going to work on implementing this RFC throughout this week. Will close https://github.com/ponylang/ponyc/issues/4255
Initial commit sets up a test-driven development approach using the "Examples of Affected Ranges" list from the RFC, copies the updated constructor from the RFC, and adds a helpful make rule, test-stdlib-debug-collections, because I could not figure out how to pass --only="collections/Range" to the existing test-stdlib-debug make rule.
Non-exhaustive list of tasks before the PR is ready for review:

[ ] Delete the new make rule test-stdlib-debug-collections
[ ] Organize test into logical groups, most likely by type parameter

Also reasonable to group any new "empty range" tests based on the three criteria as stated in the RFC

[ ] Test that .has_next() is False for empty ranges
[ ] Add new documentation detailing the changes
[ ] Add release notes detailing the changes

I found an instance of "footgunnery" in the "Examples of Affected Ranges" from the RFC

Range(0, 10, -1), .is_empty() == true, .is_infinite() == false

In actual Pony, this would be Range[A](0, 10, -1) where A is the type parameter. Well if A = USize then Range[USize](0, 10, -1) which wraps around to be Range[USize](0, 10,<PHONE_NUMBER>3709551615) which is not empty, nor infinite, but rather produces a single element of [0] -- this applies to all unsigned integers. Of course, then A is a float or signed, then the above does apply. I added additional tests to cover this.

@rhagenson that footgun was discussed on the RFC and was decided that it wouldn't be address at this time. That was left to a further RFC to sort out.

I do not doubt it was discussed. Only instance from the list of affected ranges that I have found so far as being not quite the same based on the type parameter used so making the entry in the list misleading. I added tests and will need to note it in the docs that it is a possible tripping point.

Hi @rhagenson,
The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.
Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4280.md to match the number of this pull request.
The basic format of the release notes (using markdown) should be:
## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

I believe I have covered everything from the RFC. I added to the original scope only in additional tests and one sentence in the proposed docstring to note the wraparound when using an unsigned type and negative literal. I organized tests by the three classifications (finite, infinite, and empty) as well as removed an unused testing function (_count_range).

@rhagenson can you update the first comment to be the commit comment that should be used when squashing and merging this PR?


fix StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 3

fix StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 3
to StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 2

Coverage remained the same at 93.27% when pulling d1fcab60c19a0c75fd497450f4df77965e42b147 on goni-hgs:master into 0343b4fda87161265acf30d5ee61e525e751358d on apache:master.

Shouldn't this result in  StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 1 because the sequence 'aa' is at every index?

I agree with britter.  StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 1 would be true because the sequence 'aa' is at every index. There seems to be confusion around this method, but it seems to me the original code had it correct.
........
int index = lastIndex ? str.length() : INDEX_NOT_FOUND;
do {
if (lastIndex) {
index = CharSequenceUtils.lastIndexOf(str, searchStr, index - 1);
} else {
index = CharSequenceUtils.indexOf(str, searchStr, index + 1);
}
........
I'm not sure why StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 3 would ever be true.
StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 2 is easier to see where it's coming from, but StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) == 1 is still the correct answer, and it also works for other tests. I found my way here because I wanted to use this method in a project, but found that the current release is broken by commit e5a3039. With the current release if the first index is between 0 and searchStr.length() -1 the method will return the index for ordinal + 1.....in other words the wrong index.

I guess this pull request can be closed, now that https://github.com/apache/commons-lang/commit/e5a3039f7a1e727fca40db7357a9191b6a7cf41d has been reverted with https://github.com/apache/commons-lang/commit/d75fe46b8f1b0d5c27887052ee4714d6a9c7ea4b and additional tests and javadoc have been added with https://github.com/apache/commons-lang/commit/7fd021d82ff431fb31f42bc6c5c44a3b979cb426


It throws an error when the given promise has been rejected using toast.loading() method

Thanks for this great library.
There is a bug you should be aware of. when I use the loading() method if the given promise has been rejected it throws an error that should not be thrown because of using try..catch.
The error() callback must be called without any error.
I believe that you should remove the throw err on the last line to fix the bug.
Regards, Javad Moradkhah.

Hi Javad , Thanks for using rc-toastr and I thank you for reporting this. I will fix that ASAP,


wrong ID for MYC (gene) test

The "NeverShow: cancer decreases activity or abundance of MYC proto-oncogene, bHLH transcription factor" test (Test case 24, asset 312) is using the gene ID NCBIGene:7553. I can see this in the test log https://informationradiator.renci.org/test-runs/53/tests/9184
However, this ID is actually for ZNF7. Instead, I think NCBIGene:4609 is the ID for "MYC proto-oncogene, bHLH transcription factor".

I definitely agree that the curie does not match the name. @sandrine-m do you think you could look into this and potentially use NCBIGene:4609 for this asset? I ran it through node norm and it just said MYC, so not sure if that's close enough.

Thanks @colleenXu  for reporting this asset. @maximusunc I have not submitted this particular test asset but I can try to have a look at it to try to understand what the user meant (MYC or something else?)

corrected with the proposed NCBIGene:1636 ID in the test asset sheet. Please close if the error does not happen anymore. Thanks

NCBIGene:1636 is ACE. So is this meant to be one of the ACE tests (Test case 23 in the sheet?

Thank you @colleenXu for correcting me. I do not know what are ACE tests.
I made a mistake when I responded to you earlier and did not copy paste the good ID in my answer on GitHub. I verified today that the correction I made earlier is the correct ID : NCBIGene:4609 for MYC. I corrected in the Testing QA Pairs from which the test cases are built. I did not edit another sheet. I am not sure if I answered your question?

Sounds like this is taken care of.


"editor.referenceInfos" setting marked as "Unknown configuration setting"

VSCode Version: 1.8.0
OS Version: Windows 10 x86-64

Steps to Reproduce:

Open settings.json.
Place next option inside it.

"editor.referenceInfos": false

Save settings.json.

Actual Results:

It will be squiggled with the tooltip "Unknown configuration setting".

Expected Results:

No squiggles and tooltip have to be shown.
editor.referenceInfos setting should be known.

editor.referenceInfos is deprecated and is replaced by editor.codeLens and hence warnings are shown. Please use editor.codeLens.


Browser doesn't detect changes

I am pretty new to React, please bear with me.
ENVIRONMENT

Ubuntu 20.04 in Windows 10 (WSL2)
Node version - v14.1.0
Npm version - v6.14.7
Code editor - VS Code v1.14.0

STEPS I DID

npx create-react-app <app-name>
cd <app-name>
npm start
https://localhost:3000 opens up in default browser with default React landing page. Console says '[HMR] Waiting for update signal from WDS... '
Delete all files in src directory and create empty index.js in src directory.

Output expected: Blank screen
Output: Default landing page of React even if I reload the page.
There are no changes detected even if I make any other changes in index.js or adding other files.
Struggles I made before filing an issue :(

Looked in issues of create-react-app.
Tried troubleshooting create-react-app as mentioned in official docs.
Looked in stackoverflow for similar questions. Found some but none worked, maybe because my dev environment was different from them (WSL2 in Windows 10).

Can you share the complete project folder?

@HemanthDavuluri Here's the link to the repo https://github.com/shettykaran21/jsx .
The browser doesnt detect changes irrespective of the project in my WSL2. It runs fine in Windows 10.

If you restart the server after having deleted all the files, and then make changes, does it refresh?

@eddiemonge Yeah, I have to start the server after every change I make and it refreshes 👍

@shettykaran21 it's advisable to write your end user code in different directories intended as per your functionality like components, server, assets and models etc. and finally including them in App.js for containerization.
It's ok to experiment with projects but remember to maintain a proper structure 👍🏻

@mmudunuri Ok! Will keep this in mind 😀. Thanks for your suggestion


Document the job name requirements

Closes #495

Can you update this to reflect the change from #535?
Thanks!

@brndnmtthws: Done!

Beautiful, thanks!


added fine tuning videocap task, modified vatex dataset for this task

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Not play video on ios having error "The server is not correctly configured".

Bug
Hey there i am using react native video of version 5.2.1 and this following is the url i am trying to play its working fine in android but not in ios
https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053.
giving me error
{"error": {"code": -11850, "domain": "AVFoundationErrorDomain", "localizedDescription": "Operation Stopped", "localizedFailureReason": "The server is not correctly configured.", "localizedRecoverySuggestion": ""}, "target": 19249}
is this the library issue or the server. also what's the cause of issue. i am stuck badly
Platform
ios
Which player are you experiencing the problem on:

iOS

Environment info
React native info output:
System:
OS: macOS 13.0
CPU: (8) arm64 Apple M2
Memory: 134.06 MB / 8.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 19.7.0 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 9.5.0 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.0 - /Users/algoacepc/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
Languages:
Java: 11.0.18 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.6 => 0.70.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Library version: 5.2.1
this is my code
    <Video
      source={{
        uri: `${videoUrl}`,
        type: 'mp4',
      }} // Can be a URL or a local file.
      ignoreSilentSwitch={'ignore'}
      onLoadStart={e => console.log('Video Load Start', e)}
      onBuffer={() => {
        console.log('this is bufferering');
      }} // Callback when remote video is buffering
      onError={e => {
        console.log('error', e);
        Toast.show('file lost or corrputed', Toast.LONG);
      }}
      onLoad={() => {
        console.log('this is onLoad');
        setLoading(false);
      }}
      minLoadRetryCount={5}
      onReadyForDisplay={() => {
        console.log('this is onReady for display');
        setLoading(false);
      }}
      hideShutterView={true}
      controls={true}
      resizeMode={'contain'}
      style={styles.videoPlayerStyle} // Store reference
    />

i am stuck for severals days thanks in advance

You need to check why your server return a http error. I guess an error linked to http header.
The server is not correctly configured.
Doesn't seem related to react native video

@freeboub  need help: i am new need help. kindly guide me how do i know which header to include because i am using a third party tool. any suggestion or there is a way debug which header i need to include?

https://github.com/react-native-video/react-native-video/blob/master/docs/DEBUGGING.md

hey there its streaming fine in android but in ios its giving above error

@freeboub  thanks for your guidence i have tried the charles proxy and when i excute requet of video url i.e
https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053
the header i found from content tab is
| HTTP/1.1 200 OK
-- | --
Date | Thu, 22 Jun 2023 06:04:48 GMT
Content-Type | application/octet-stream
Content-Length | 499458
Server | nginx/1.16.1
Vary | Origin
Vary | Access-Control-Request-Method
Vary | Access-Control-Request-Headers
Access-Control-Allow-Origin | *
Vary | Origin
Vary | Access-Control-Request-Method
Vary | Access-Control-Request-Headers
Content-Disposition | attachment; filename="CECF4482-370E-4657-9D4D-01B2A9A4305B.mp4"; filename*=UTF-8''CECF4482-370E-4657-9D4D-01B2A9A4305B.mp4
Connection | keep-alive
and this overview

URL
https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053

Method
GET

Status
Complete

Response Code
200 OK

Content-Type
application/octet-stream

Client Address
-

Remote Address
a41.chat.agora.io/<IP_ADDRESS>:443

Protocol
HTTP/1.1

Tags
-

Kept Alive
No

SSL
TLSv1.2 (TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256)

Connection

Timing

Request Start Time
6/22/23 11:04:47

Request End Time
6/22/23 11:04:48

Response Start Time
6/22/23 11:04:48

Response End Time
6/22/23 11:04:49

Duration
1.61 s

DNS
1 ms

Connect
27 ms

TLS Handshake
745 ms

Request
1 ms

Response
502 ms

Latency
338 ms

Speed
317.90 KB/s

Request Speed
2.33 MB/s

Response Speed
1,017.34 KB/s

Size

Request
2.38 KB (2,440 bytes)

Response
510.71 KB (522,963 bytes)

Total
513.09 KB (525,403 bytes)

but i still didnt get its returning me 200 ok status but when i try to play in ios its giving me error of this.
{"error": {"code": -11850, "domain": "AVFoundationErrorDomain", "localizedDescription": "Operation Stopped", "localizedFailureReason": "The server is not correctly configured.", "localizedRecoverySuggestion": ""}, "target": 19249}
i didnt get it can you please help me out?

Ok, and did you try to record network trace with your iphone ?

currenlty i am using emulator on my mac and this is emulator reponse when i try to play video
URL | https://a41.chat.agora.io
Method | CONNECT
Status | Complete
Notes | SSL Proxying not enabled for this host: enable in Proxy Settings, SSL locations
Response Code | 200 Connection established
Content-Type |
Client Address | <IP_ADDRESS>:56556
Remote Address | a41.chat.agora.io/<IP_ADDRESS>:443
Protocol | HTTP/1.1
Tags | -
Kept Alive | No
SSL | TLSv1.2 (TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256)
Connection |
Timing |
Request Start Time | 6/22/23 11:40:00
Request End Time | -
Response Start Time | -
Response End Time | 6/22/23 11:41:01
Duration | 1 m 1 s
DNS | 2 ms
Connect | 111 ms
TLS Handshake | 732 ms
Request | -
Response | -
Latency | -
Speed | 3.77 KB/s
Request Speed | -
Response Speed | -
Size |
Request | 3.37 KB (3,448 bytes)
Response | 228.59 KB (234,077 bytes)
Total | 231.96 KB (237,525 bytes)
this is content
CONNECT a41.chat.agora.io:443 HTTP/1.1
Host | a41.chat.agora.io
Proxy-Connection | keep-alive
Connection | keep-alive
and this is header tab

| HTTP/1.1 200 Connection established
-- | --

�

@freeboub  i have tried to give header of content type but still its giving me same error

@ahmedShaheer3 @freeboub I got the same issue here .. i checked the headers of the URL that im using to display video and the header looks like this => HTTP/1.1 206 Partial Content
Date: Thu, 14 Mar 2024 06:01:43 GMT
Server: Apache/2.4.52 (Ubuntu)
X-Powered-By: Express
Access-Control-Allow-Origin: *
Accept-Ranges: bytes
Content-Range: bytes 0-1/1053887
Content-Type: video/mp4
Transfer-Encoding: chunked

For those who are still having this issue, you probably need to implement HTTP byte-range requests support on the backend. Please see https://bunny.net/academy/http/what-are-http-range-and-byte-range-requests/


Site is too small on mobile

responsiveness isnt broken but everything is really small

try using
<meta name="viewport" content="width=device-width, initial-scale=1.0>

don't know anything about how viewport works but ill try it

https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

seems to work alright, any other issues are put onto #11


unpackPhase error

Hi, @considerate! I'm trying to make a dev environment for a package https://github.com/deemp/gists/blob/master/purifixTrouble/flake.nix and it fails with
error: builder for '/nix/store/zdx2dwjviwg70hp09b4ar1w076hcfvgy-develop-my-project.drv' failed with exit code 1;
       last 2 log lines:
       > unpacking sources
       > variable $src or $srcs should point to the source
       For full logs, run 'nix log /nix/store/zdx2dwjviwg70hp09b4ar1w076hcfvgy-develop-my-project.drv'.
error: 1 dependencies of derivation '/nix/store/fg3vhcc99327wabbdzzqp31dppyc1lh7-nix-shell-env.drv' failed to build

What can be the problem?

It looks like you’re including app.develop in mkShell. The expression app.develop already evaluates to a devShell so you don’t have to wrap it in a mkShell call.
If you want to add more things to the shell the preferred approach is to use app.develop.overrideAttrs(old: { … }) and then extend the nativeBuildInputs.

Thank you! That was it.


feat(http2): add HTTP2 keep-alive support for client and server

This adds HTTP2 keep-alive support to client and server connections
based losely on GRPC keep-alive. When enabled, after no data has been
received for some configured interval, an HTTP2 PING frame is sent. If
the PING is not acknowledged with a configured timeout, the connection
is closed.
Clients have an additional option to enable keep-alive while the
connection is otherwise idle. When disabled, keep-alive PINGs are only
used while there are open request/response streams. If enabled, PINGs
are sent even when there are no active streams.
For now, since these features use tokio::time::Delay, the runtime
cargo feature is required to use them.

Wonderful! Will try to take a look today/tomorrow a bit backed up with work :)


sync core with firefly-common

Migration from older Prefix based configuration naming to the new Config/Section naming introduced in firefly-common v0.1.4
closes #802

Codecov Report

Merging #805 (66f35ac) into main (8aeb9a9) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 66f35ac differs from pull request most recent head 56667af. Consider uploading reports for the commit 56667af to get more accurate results

@@            Coverage Diff            @@
##              main      #805   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          303       303
  Lines        18774     18773    -1
=========================================
- Hits         18774     18773    -1

Impacted Files
Coverage Δ

internal/apiserver/metrics_server.go
100.00% <100.00%> (ø)

internal/apiserver/server.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/address_resolver.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/config.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/ethereum.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/config.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/fabric.go
100.00% <100.00%> (ø)

internal/database/postgres/config.go
100.00% <100.00%> (ø)

internal/database/postgres/postgres.go
100.00% <100.00%> (ø)

internal/database/sqlcommon/config.go
100.00% <100.00%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeb9a9...56667af. Read the comment docs.


Sync, callback and async version of safePermutation

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Report progress on running install

/cc @blixtra @robszumski

Can you help me understand your motivation for adding this? If we do, it should be stderr (recently wrote up my rationale here)

Assuming this is related to #2011 - if you have an example of trying to integrate this with Ansible or some other system, please provide details so we can better understand your use case.

Honestly, this was pretty ad-hoc, with no defined use case. I thought conveying more information to an user will lead to better UX.

I'm not necessarily vetoing that, just saying it should be on stderr if so.

Changed to stderr

I feel weakly about this so going to defer to one of the other maintainers.

Superseded by #2101


API aggregation should be configurable and secured

Describe the bug
There are some setup requirements for getting API aggregation working properly and securely, e.g. extra flags on kube-apiserver and proxy CA, client cert, client key.
We cannot assume the above requirements are always met, so the API aggregation should be optional and we can provide a doc for user to do it securely if they want.
Due to this change, antctl (controller mode) should no longer connect to Kubernetes api by default.
Expected

[x] The default manifest shouldn't register APIService with insecureSkipTLSVerify set to true. (#714)
[ ] antctl should use another way to reach antrea api.

Versions:
Please provide the following information:

Antrea version (Docker image tag). 0.5.1

With #714, The APIServices managed by Antrea are secured now. The kube-aggregator (kube-apiserver) will verify the antrea-controller's serving cert against a valid CA bundle.
As we don't have a deployment case that API aggregation is disabled, closing this for now.


Assertion Error?

hi @oPromessa,
Me again, have run through and it seems to search flickr but some sort of assertion error stops the script?
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] fn:[search] success:[True] result:[<Element 'rsp' at 0xb6613740>] errcode:[0]
[1263][2018.09.12 19:20:12]:[MainProcess][WARNING ]:[root] +++#190: Found [1] images with checksum:[edecfb41ac8106d099939bbab1859b3b]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] Title:[IMG_4301]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] Compare Titles=[True]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] fn:[getAllContexts] attempts:[3] waittime:[8] randtime:[True]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] fn:[getAllContexts] kwarg[photo_id]=[44592096102]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] ___Retry f():[retry_flickrapi_fn] Max:[3] Delay:[8] Rnd[True]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[root] ___Retry f():[retry_flickrapi_fn]: Attempt:[1] of [3]
[1263][2018.09.12 19:20:12]:[MainProcess][INFO    ]:[flickrapi.core] Calling {'nojsoncallback': 1, 'method': 'flickr.photos.getAllContexts', 'format': 'etree'}
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[flickrapi.core] REST Parser: using xml.etree.cElementTree
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] fn:[getAllContexts] Output for fn_result:
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root]

[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] fn:[getAllContexts] success:[True] result:[<Element 'rsp' at 0xb6613f80>] errcode:[0]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] len(resp.findall(set)):[0]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] find_tag: photo:[44592096102] intag:[album:Scarborough, WA - Northstead Street, 7 December 2013]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] fn:[getListPhoto] attempts:[3] waittime:[15] randtime:[True]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] fn:[getListPhoto] kwarg[photo_id]=[44592096102]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] ___Retry f():[retry_flickrapi_fn] Max:[3] Delay:[15] Rnd[True]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[root] ___Retry f():[retry_flickrapi_fn]: Attempt:[1] of [3]
[1263][2018.09.12 19:20:13]:[MainProcess][INFO    ]:[flickrapi.core] Calling {'nojsoncallback': 1, 'method': 'flickr.tags.getListPhoto', 'format': 'etree'}
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[flickrapi.core] REST Parser: using xml.etree.cElementTree
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root] fn:[getListPhoto] Output for fn_result:
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root]

autoupload
checksumedecfb41ac8106d099939bbab1859b3b
december2013

[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root] fn:[getListPhoto] success:[True] result:[<Element 'rsp' at 0xb6613e00>] errcode:[0]
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root] auto-upload
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root] checksum:edecfb41ac8106d099939bbab1859b3b
[1263][2018.09.12 19:20:14]:[MainProcess][INFO    ]:[root] album:December 2013
[1263][2018.09.12 19:20:14]:[MainProcess][WARNING ]:[root] IS_UPLOADED:[UPLOADED WITHOUT SET WITHOUT ALBUM TAG]
[1263][2018.09.12 19:20:14]:[MainProcess][WARNING ]:[root] is_already_uploaded:[False] Zcount:[1] Zpic:[None] ZisNoSet:[False]
[1263][2018.09.12 19:20:14]:[6923       ][PRINT   ]:[uploadr] Found, continuing with next image.
[1263][2018.09.12 19:20:14]:[MainProcess][WARNING ]:[root] Found, continuing with next image.
[1263][2018.09.12 19:20:14]:[6923       ][PRINT   ]:[uploadr] Successful file:[/volume2/photo/Photo/2013/December/IMG_4301.JPG]
[1263][2018.09.12 19:20:14]:[MainProcess][CRITICAL]:[root] Exception: <type 'exceptions.AssertionError'>: [1263][2018.09.12 19:20:14]:[6923       ][ASSERT  ]:[uploadr] photo_id None:[/volume2/photo/Photo/2013/December/IMG_4301.JPG]
[1263][2018.09.12 19:20:14]:[MainProcess][CRITICAL]:[root]   File "/root/apps/Python/bin/uploadr.py", line 664, in
run_uploadr(PARSED_ARGS)
File "/root/apps/Python/bin/uploadr.py", line 415, in run_uploadr
myflick.upload()
File "/root/apps/Python/lib/python2.7/site-packages/lib/FlickrUploadr.py", line 553, in upload
success = self.uploadFile(lock=None, file=file)
File "/root/apps/Python/lib/python2.7/site-packages/lib/FlickrUploadr.py", line 1489, in uploadFile
.format(NP.strunicodeout(file)))

Hello @rkilg
First things first...

I've noticed this output is coming from version 2.8.6.
I was expecting you'd be using 2.8.6-alpha.33 as it fixed the original weird problem we've had! To confirm can you please check the version at the start of the log files. You'll have one of these lines:

[uploadr] ----------- (V2.8.7-alpha.33) Start -----------(Log:40)
[uploadr] ----------- (V2.8.6) Start -----------(Log:40)

Anyhow, it's fine to go with 2.8.6... as it now seems to work past that weird initial error! 👍

Request

Can you share a bit more of the log file? Say the previous 1000 lines or so to help me out debugging this error
Can you let me know if this pic IMG_4301  (with md5sum checksum edecfb41ac8106d099939bbab1859b3b):

exists in two folders/album:  "December 2013"  and "Scarborough, WA - Northstead Street, 7 December 2013"
or it was moved from "December 2013" folder/album to "Scarborough, WA - Northstead Street, 7 December 2013" folder/album

To confirm the checksum of the pic you can issue the command on DSM Synology SSH:

$ md5sum IMG_4301.JPG
194577a7e20bdcc7afbb718f502c134c   IMG_4301.JPG

Check my analysis below but re-running it may very well work as this error was really a great coincidence.

The issue: analysis under progress

I need more logs but it seems the upload failed and while double-checking whether it was not on flickr it found the previously loaded/duplicated pic... and confused things a bit.
Anyhow it is a supported scenario so we may be in face of an bug.
But re-running it may very well work as this error was really a great coincidence.

Hi @oPromessa,
No the folder file is the same i tried to take out my folder address for privacy reasons and obviously missed it. The file folder combo is the same throughout.

Hmmm. Ok! that threw me off then.

Yes, share your concern on privacy.

If you could send the log file from the point in which handling starts on this particular file... there should be a reference to:  Uploading file:[....]

besides this log file there maybe another with the regular output file. If you can also strip that one out to start from the point in which handling starts on this particular file... that'd be great!

Can you also confirm the version you're using?

/root/apps/Python/lib/python2.7/site-packages/flickr_uploader-2.8.6.dist-info

The end of the terminal output screen + the uploader.log file, it says files were being processed but my flickr site is still stuck on ~15K files and sorting by uploaded date nothing has changed?
flickrupload.txt
uploader.log

Good info. Thanks!
Next steps

I think the files are uploading but it is a bit slow... You can kill the task/process and let's relaunch it in multiprocessing mode to load multiple files at the same time.

You can use the parameter -p 10 or -p 20 or even -p 30. It will depend on your system's capability and load. On my DS415+ I can go up to -p 30 without impact.
The performance I get is... for reference only. If you have more videos it will take longer.

Performance (with options: "-p 30"):
upload: 340 pics/min ~= 20.000 pics/hour.
addfiletoset: ~1000 albums/65000pic = 17.000 pics/hour

Let's also remove the option -x which shows the percentage progress of each file but it is not relevant at this point.

[1489][2018.09.15 23:52:37]:[29268      ][PRINT   ]:[uploadr] Successful file:[/volume2/photo/Photo/2013/January/16 January 2013/IMG_1828.JPG]
0
0
0
40
40
80
80

Analysis

It started at

[2018.09.15 08:38:51]:[29268      ][PRINT   ]:[uploadr] ----------- (V2.8.7-alpha.33) Start -----------(Log:40)

After 15 hours or so is still going:

[2018.09.15 23:55:14]:[MainProcess][WARNING ]:[root]  Uploading file:[/volume2/photo/Photo/2013/January/16 January 2013/IMG_1830.JPG] On Album:[16 January 2013],,,

I see some errors on upload on a specific timeframe. In particular file IMG_3937.MOV fails uploading for 10 times. But nothing out of the ordinary.
You should at least have around ~18500K files uploaded:

[2018.09.15 15:35:40]:[29268      ][PRINT   ]:[uploadr] Files Processed:[ 18500] of [ 41065]

Not yet on Albums as they are placed on albums later.
I can see the files are still uploading...

/volume2/photo/Photo/2013/January/16 January 2013/IMG_1828.JPG is one of the last ones.
Can you check on flickr.com as it must be there.

Good. Yup... I failed to mention the total number of pics on the Flickr banner on the browser (check image) does not update often when a lot of uploading is going on!

If you want you can try and to: https://www.flickr.com/services/api/explore/flickr.people.getPhotos

copy/paste Your User ID and hit Call Method

You should get the total... 150 in this test case. But I don't guarantee it's absolutely correct!

The log file/link gives an error. Can you re-upload?
Now with 30 processes it will go a lot faster: around  upload: 340 pics/min ~= 20.000 pics/hour.
You can check progress by typing on another SSH session to your DSM:
$ tail -f uploader16092018.log
....

(hit Ctrl-C) to cancel```

Im getting don't support that file type error for some reason, uploading the log files here?:
still at that number, is it just overwriting image files, can I option to not overwrite?

uploader1609err.log
uploader16092018.log
Just stopped the script, taking all my upload bandwidth, I only have max 1MBps unfortunately

""

Hello there.

Yup 1MBps is quite limiting. Try maybe with -p 10 during the night (when you need less bandwidth) which would be less demanding. I guess it will use as much bandwidth as it can get...
The total stuck on 15284 is a bit weird...
The "File type not supported" does occur with a few JPGs. I marked them as "bad" and using the -b flag we'll not try to re-upload those files.
From the logs I do see it running... and uploading... for this file it took 11s. For instance do check on flickr.com if this file is uploaded PC090545_face0.jpg to confirm...

[1133][2018.09.16 03:56:20]:[3966       ][PRINT   ]:[uploadr]   Checking file:[/volume2/photo/Photo/2014/February/16 February 2014/PC090545_face0.jpg]...
[1133][2018.09.16 03:56:25]:[3966       ][PRINT   ]:[uploadr]  Uploading file:[/volume2/photo/Photo/2014/February/16 February 2014/PC090545_face0.jpg] On Album:[16 February 2014]...
[1133][2018.09.16 03:56:31]:[3966       ][PRINT   ]:[uploadr]   Uploaded file:[/volume2/photo/Photo/2014/February/16 February 2014/PC090545_face0.jpg] ID=[44658385752]. Check for duplicates/wrong checksum...
[1133][2018.09.16 03:56:31]:[3966       ][PRINT   ]:[uploadr] Successful file:[/volume2/photo/Photo/2014/February/16 February 2014/PC090545_face0.jpg]

As it checks if files were previously loaded it takes a bit longer (12s in this case) but it ensures no duplicates... but again 1Mbps is limiting us here!

[1133][2018.09.16 03:56:27]:[3963       ][PRINT   ]:[uploadr]   Checking file:[/volume2/photo/Photo/2012/June/27 June 2012/IMG_1699.JPG]...
[1133][2018.09.16 03:56:42]:[3963       ][PRINT   ]:[isuploaded]  IS_UPLOADED:[UPLOADED WITHOUT SET WITH ALBUM TAG]

Terminal Saved Output 1809 uploadr.log
Left running overnight, still no increase in the number of files, the script says they are uploading but flickr must be blocking them or something, any idea?
Files that are listed in the end I did a search in my photostream and they could not be found.

Ok...Looking at the log...

Found a 1st run from 08:23:11 killed at around 08:26:24. Was it
Found a 2nd run at 11:19:39 with 3 processes

Recommendations:

Run with the -u option to avoid checking if the file is on flickr.com. For initial uploads we may gain a few hours here as it is taking
Sometimes processes launched via the terminal timeout and are killed. to prevent that one should use the nohup command like this:

$ nohup uploadr.py -b -p 3 -vv -u > uploadr.log 2> uploadr.err &
[1] 24328
$ jobs -l
[1]+  24328  Running                  nohup uploadr.py -b -p 3 -vv -u > uploadr.log 2> uploadr.err
$ kill %1  # Use this option to kill it if you want. BUT you should not!
[1]+  Terminated              nohup find / -type d
$ exit # you can logout if you want,. When you return process 24238 is still active

Upload times vary... from 40 seconds, to 1 minute but some take 4minutes. So our average should be ( 60 minutes / 2 minutes per file ) * 3 processes = 90 images per hours it is about right... only thing is I don't understand how you've uploaded ~15000 pics in one go in one single process!!!

Further analysis: 1st run...

08:23:11 Started
08:23:45 Went thru RAW files... all were already converted to JPG.
08:23:45 Launched 5 processes

Further analysis: 2nd run..

11:29:39 started
13:15:32 Verifying if pics previously loaded are on flickr.com: IS_UPLOADED:[UPLOADED WITHOUT SET WITHOUT ALBUM TAG]

😱 It checked around 600 pics (both runs)... To check one pic it is taking anything from 2 to 5 minutes; and on occasions 9 minutes. Very slow!
📓 My recommendation is to run with the -u option to avoid checking if the file is on flickr.com. For initial uploads we may gain a few hours here as it is taking

13:18:27 Killed. It ran for about 2 hours... It had uploaded only about 188.
Upload times vary... from 40 seconds, to 1 minute but some take 4minutes. So our average should be ( 60 minutes / 2 minutes per file ) * 3 processes = 90 images per hours it is about right... only thing is I don't understand how you've uploaded ~15000 pics in one go in one single process!!!

### 1 minute upload time
[1589][2018.09.17 13:07:22]:[27340      ][PRINT   ]:[uploadr]   Checking file:[/volume2/photo/Photo/2014/March/Western Australia - Australia, 8 March 2014/IMG_4733.JPG]...
[1589][2018.09.17 13:07:25]:[27340      ][PRINT   ]:[uploadr]  Uploading file:[/volume2/photo/Photo/2014/March/Western Australia - Australia, 8 March 2014/IMG_4733.JPG] On Album:[Western Australia - Australia, 8 March 2014]...
[1589][2018.09.17 13:08:23]:[27340      ][PRINT   ]:[uploadr]   Uploaded file:[/volume2/photo/Photo/2014/March/Western Australia - Australia, 8 March 2014/IMG_4733.JPG] ID=[29801204927]. Check for duplicates/wrong checksum...
[1589][2018.09.17 13:08:23]:[27340      ][PRINT   ]:[uploadr] Successful file:[/volume2/photo/Photo/2014/March/Western Australia - Australia, 8 March 2014/IMG_4733.JPG]
### 4 minutes upload time
[1589][2018.09.17 13:10:22]:[27340      ][PRINT   ]:[uploadr]   Checking file:[/volume2/photo/Photo/2014/August/31 August 2014/IMG_7783.JPG]...
[1589][2018.09.17 13:10:43]:[27340      ][PRINT   ]:[uploadr]  Uploading file:[/volume2/photo/Photo/2014/August/31 August 2014/IMG_7783.JPG] On Album:[31 August 2014]...
[1589][2018.09.17 13:14:46]:[27340      ][PRINT   ]:[uploadr]   Uploaded file:[/volume2/photo/Photo/2014/August/31 August 2014/IMG_7783.JPG] ID=[29801325067]. Check for duplicates/wrong checksum...
[1589][2018.09.17 13:14:46]:[27340      ][PRINT   ]:[uploadr] Successful file:[/volume2/photo/Photo/2014/August/31 August 2014/IMG_7783.JPG]

Hello @rkilg ! Did you manage to get the uploading?
I've since launched version 2.8.7.

Do install version 2.8.7 with pip upgrade and make sure to save the etc/ files (.ini and .cron) as they get overwritten with the upgrade:

pip install flickr-uploader --prefix=~/apps/Python --upgrade

Hi @oPromessa
As u may be aware Flickr have removed the 1TB free offer and reduced to 1000 photos only therfore I have deleted my accounts :( looking at cloud storage potential solutions now with Cloud Sync it's a shame cause your script was good

Thank you for your encouragement @rkilg. Yes, sad news from Flickr.
If you happen to be an Amazon Prime user, you can use Cloud Sync to upload all your pics to Amazon Drive and use the Photos apps to view them. Videos are limited to 5GB storage.
Creation of Albums is not possible... I'm looking into their API for a possible port of this tool into Amazon (don't know if I'll have the time)!
Thanks!


minSdkVersion

minSdkVersion 14 is OK ?
current is 15

See https://github.com/grandcentrix/tray/issues/102


Modified structures and laboratories blocks

Changed structure list, info
Changed laboratory list, info

addedd through command line to resolve conflicts


APEX-250 #resolve #comment added checkstyle suppressions file to excl…

…ude DTCli from System.out and System.err checks

@vrozov please review

@davidyan74 please review


RHOARDOC-1818: Edited references to MicroProfile to include Eclipse

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@Ladicek I added Eclipse to all references to Microprofile in section titles and in particularly notable locations in the docs. I have omitted some mentions of MicroProfile in case there were multiple instances close to one another in the text.
This should still comply with the Eclispe guidelines.
Please let me know what you think. Thanks.

Thanks @inoxx03, I tried to add a comment to all changes here. In general, I'd prefer if we could spell it out in the full form near the beginning of each guide/chapter/semantic unit and then use the short form, as it's typically followed by yet another name, which makes it harder to read. For example, referring to MP OpenTracing API as "Eclipse MicroProfile OpenTracing API" is hard to read, even "MicroProfile OpenTracing API" isn't exactly the best. On the other hand, when referring to MP itself, "Eclipse MicroProfile" is as good as just "MicroProfile", so why not.

@Ladicek  Thank you for your feedback. I generally agree to not changing the names of fractions,as I share your concern over this worsening the readability of fraction names. I will try to incorporate the full Eclipse trademark names into the text in the affected sections instead.

@Ladicek I have updated the PR based on your suggestions. Please let me know what you think. Thank you.

I added a few tiny suggestions that I'd like you to review, but otherwise LGTM.

Thank you for the suggestions @Ladicek. I have reviewed and accepted them. Please feel free to merge this PR when you have a chance:)

Thanks!


Background Charting music stacking up when realoding a json file

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version.
When pressing 7 on the main menu and after that going into the chart editor if you wait till the background music plays and then reloading a json file the music won't stop, it will just keep playing with the other music because you realoaded a new json file and it plays two songs at the same time.
Command Prompt/Terminal logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
Waiting for the song to play in the chart editor and then reloading the json the song won't stop it will keep playing with the other song of the realoded json, you can do it mutiple times realoding the jsons even I did it accidentally while charting.

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here.
Yes

Already fixed in latest commit.


txhash: Implement TxHashCache for OP_TXHASH and OP_CHECKTXHASHVERIFY

This is obviously experimental and only makes sense if/when the relevant proposal is accepted by the community.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

791 of 854 (92.62%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 83.457%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/blockdata/script/borrowed.rs
4
9
44.44%

bitcoin/src/blockdata/script/txhash.rs
696
754
92.31%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/blockdata/script/borrowed.rs
4
76.74%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
19862

Relevant Lines:
23799

💛  - Coveralls


feat: helm chart for self hosted

I have made a working helm chart to provide self hosted promptfoo for team sharing

@didlawowo thank you so much for contributing this! Would you mind taking a quick pass at site/docs/usage/self-hosting.md with instructions for getting it up and going?
I hope you don't mind that I fixed the lint.
What's the best way to test your branch?  I tried with minikube but ran into errors around { { vs {{ in your yaml templates.

@didlawowo thank you so much for contributing this! Would you mind taking a quick pass at site/docs/usage/self-hosting.md with instructions for getting it up and going?
I hope you don't mind that I fixed the lint.
What's the best way to test your branch? I tried with minikube but ran into errors around { { vs {{ in your yaml templates.

it's curious because i don't have error on my cluster.
i'm using argo cd app somethings like this but a simple helm install with some value custom should work.
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: promptfoo
  namespace: kube-infra
  finalizers:
  - resources-finalizer.argocd.argoproj.io
spec:
  destination:
    server: https://kubernetes.default.svc
    namespace: mlops
  project: mlops
  source:
    repoURL: git@github.com:xxxxx/continuous-delivery.git

    targetRevision: main
    path: charts/promptfoo
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
    syncOptions:
    - CreateNamespace=true

i have added pvc persistence

Thank you @didlawowo


Ignore unused rules in generated parser

https://github.com/dmajda/pegjs/issues/200 talks about reporting unused rules.
At the same time with reporting (as a warning), unused rules should not make it into the parser at all (unreachable code).

This will be done alongside stage 1 of #523


Suppress DataFrame.applymap deprecation warning

Addresses https://github.com/apache/beam/issues/33441 .
Given we still use pandas < 2.1 , suppressing the warning.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Run Build python source distribution and wheels

/ptal @liferoad

R: @liferoad


Angular Plugin: Removed isolate scope, added onPin, onUnpin, onTop, onNotTop events.

I removed the isolate scope, it's only hooked up to initialization right now anyway, so it shouldn't need to be bound and you can now apply your own ng-controller on an element with headroom applied. The example I used this is was for hiding a subnavigation when the headroom was unpinned.
I also added in events, although there is probably a cleaner way to do this. this should fix #105

I'm not familiar enough with angular to understand the reason for the change (or the correctness of it tbh!). Can you give a demo of what this change adds to the feature set (e.g. your use case in the description, hiding the subnav, would be good).
What about the issues @JobaDiniz identified (also should probably remove that console.log :)?

The callbacks (onPin, onTop, etc) should be bindable, so that's essentially what @spaceribs commit is doing.
@WickyNilliams I could create a PR with my contribution. What I did, besides improving @spaceribs code, was to add transclusion to the directive, which makes much more sense if you think about.
With transclusion, I'm able to add html inside the headroom, so headroom function as a wrapper around some html content, like:
<headroom class="headroom container" offset="50" ng-disabled="shouldDisableHeadroom()" on-top="isOnTop = true" on-not-top="isOnTop = false" classes='{"initial": "slide", "pinned": "slide--reset", "unpinned": "slide--up"}'>

My Content

</headroom>

And I think the directive should be used only like a html element, and never like an attribute (again, for me it just makes more sense).
Moreover, I add code to enable/disable the headroom, which in turn will call headroom.destroy() and headroom.init().

yep, I would take @JobaDiniz code, I didn't test some of the features he checked but the main idea was that isolating the scope prevented anything from communicating outside of the directive.

Sorry for the delay all. Life got in the way.
I've read through this again, and still have no idea whether to accept. My angular skills are near zero, and there's so much angular-specific vocabulary (transclusion! directive! isolate scope!) that it's hard for me to understand. I may call on a friend with some angular experience to assist :)

@JobaDiniz @WickyNilliams
Any movement on this? PR says there are conflicts. Interested because I'm attempting to bind to onUnpin and haven't been able to get it working.

Do you want a review on this @WickyNilliams? Happy to refactor existing Angular PR to use $attrs to Observe potential changes. If we're using readonly properties then we can go down this route to use the $attrs Object. If you'd like to be able to $watch for changes on those parsed scope: {} values then we should integrate $watch where appropriate and register against the relevant callbacks in the Headroom instance.

@toddmotto what's the deal with this now that your other angular PR has been merged? What @JobaDiniz was saying above, about it being an element and not an attribute seemed to make sense. But all this angular stuff confuses the hell out of me :P

Well, the PR is pretty old now - ideally we should use isolate scopes rather than full inheritance. Happy to take some of the existing code and make a new PR, we'd need to consider what you want data-bound versus delegated functions. If you're delegating functions we should use scope: { fnName: '&' } to do this to allow callbacks inside the Directive. What functions do you need to keep alive in the Angular event loop? I'm not familiar with the unpin etc. methods so unsure which methods are more observers that respond to change and what are one-time calls. If you want to open an issue we can define the spec in there and look at approaching it with the currently merged Directive.

@toddmotto agreed, adding something like on-unpin="&" etc. to the directive is probably the best/most optimized option.

OK cool. I'm done for today, I'll open an issue tomorrow, and ping you guys. 👍


Removed superfluous "logging enhancer initiated" message

A specific reason why you don't like the message? I can't tailor to everybody's specific tastes, so I would like to hear some argument that would benefit the community at large.

I just don't understand why the log message is there to begin with? It just seems a bit spammy?
Maybe I'm being a bit picky but all my logs are in the global namespace and it would require a fair bit of refactoring to change all my log output to use a separate non-global space so that I don't get this message in my otherwise nicely formatted logs anymore.
Or maybe make it an option to disable?
Orr.... maybe I'm completely misunderstanding and there's a way to disable this message without changing all my references to $log in the system?
We have 40,000+ devices that only output info/error messages rarely and we plan to sync these logs with a logging server, it would be nice if they all didn't report this info line whenever they boot.

Merged. Will do a release soon.

I very much appreciate the work you've done on this amazing module, thanks for understanding :-) :+1:

It's in v1.3.1. Good luck.
Beware, starting at 1.3.0 the package.json main property is now point to the source instead of the dist file. Might not be an issue if you already pointed directly to the dist script or if you are using a tool that understands commonjs.

That's actually fine, I do my own compression etc after the main gets pulled in (automatically with bower/wiredep) so all good. Thanks for the advice :+1:


NAVI31 was not detected properly due to a typo.

I was trying to compile the TensorFlow for my RX 7900XTX and found that a typo in device_description.h was preventing it from detecting the card properly. With this fix, TF now detects my graphics card.
I'm sure there are other issues that need to be addressed before 7900 series works properly. But I wanted to bring this to the developer's attention.
So far, I got a Stable Defusion (https://gist.github.com/BloodBlight/0d36b33d215056395f34db26fb419a63) and an LLM (https://blog.mlc.ai/2023/08/09/Making-AMD-GPUs-competitive-for-LLM-inference) working on my 7900 and want to get FT working as well. It seems AMD is getting close to supporting all the popular ML models soon.

Enabling 7900 this way seems to leave the graphics card in a confused state after running a simple example. After running TF example from (https://www.tensorflow.org/tutorials/quickstart/advanced) leaves my machine in an unstable state and X session eventually crashes.

LGTM


Review Oscar's communications - and possibly consolidate them into a single framework

Oscar currently sends emails via the customer dispatcher and also has a notifications framework.  There are also a few places where emails are sent directly from views.
These components should be reviewed and possibly unified into a single communications framework.

Perhaps we can move it to the separate application and see if it is flexible and customizable enough? WDYT @solarissmoke @mvantellingen ?

Agreed - there is a case for refactoring the entire communications workflow. I think a good first step would be to make sure that all existing communications are sent through the Dispatcher?

Yes, that would be a good step to start with.

Having done with @samitnuk large refactoring on one of the projects, in order to have single and consistent backend for all kinds of notifications, now I find original idea even more useful.

Fixed in #3260.


Fire

It should have a passive ability to damage anyone passing through it or standing on the tile.


bitbucket now supports 2FA

See https://bitbucket.org/site/master/issues/5811/support-two-factor-authentication-bb-7016 and http://blog.bitbucket.org/2015/09/10/two-step-verification-is-here/

Already added in #1315


Hopscotch 0.2.6 Release Ticket

This ticket's here to track status of the 0.2.6 release.
Purpose of Release
Maintenance release for 0.2.x master branch. Triage and clear out existing PRs against the master branch. This release should avoid introducing major new features (#197 is a possible exception to this). Unless something urgent comes up or we end up with another significant queue of PRs, this is likely our last 0.2.x release.
Steps

[x] Create discussion thread for release.
[x] Triage PRs that will be included in this release.
[ ] Work with PR submitters get all fixes to Ready to Merge status.
[ ] Merge all changes to master.
[ ] grunt releasePatch, generate PR, check Travis CI for release health, merge to master.
[ ] Update hopscotch (and jQuery) version on gh-pages.

Call for PRs
If you have a Pull Request (PR) you'd like to propose for inclusion in this release, please let us know! You can use this thread for general discussion around this release. To make it as part of this release, here's the key dates you'll want to be aware of...
First draft of all PRs posted: Sunday, June 26th, 8pm PDT
All PRs merged: Wednesday, June 29th, 1pm PDT
Release pushed to master: Wednesday, June 29th, 6pm PDT
(Note: The release dates provided above may be earlier in the week, depending on our PR progress).
Before submitting a PR, check out the CONTRIBUTING.md file for submission details. Also, please note that since we're focused on getting ES6 Refresh ready to go, new features should be saved for that branch and probably won't be merged into master at this time. If you have a PR you'd like to submit, but don't think you could make the timeline published above, do let us know so we can plan accordingly.
Thanks for contributing to Hopscotch!

Pushing back the release day to July 1st to allow for updating currently posted PRs.

All done! Marking milestone as resolved. 🎉

Good work, thank you. Could someone push to npm as it appears that there is a version mismatch:

@newtriks: Done! Sorry... I was making the silly assumption that NPM would pick up the new version from GitHub automatically. =P


Prevent arrow keys from dismissing tab renamer

PR Checklist

[x] Closes https://github.com/microsoft/terminal/issues/9632
[x] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated.
[ ] Schema updated.
[ ] I've discussed this with core contributors already.

@KalleOlaviNiemitalo - FYI

Thanks!


emmet.extensionsPath and multi root workspaces

Testing #117277

Create a multi root workspace with two folders (a, b) with the following contents:

a/emmet1/snippets.json
{
  "html": {
    "snippets": {
      "ullllle1": "ul>li[id=${1} class=${2}]*2{ Will work with html, pug, haml and slim }"
    }
  }
}

b/emmet2/snippets.json
{
  "html": {
    "snippets": {
      "ulle2": "ul>li[id=${1} class=${2}]*2{ Will work with html, pug, haml and slim }"
    }
  }
}

Now try configuring emmet.extensionsPath as a user setting with "emmet.extensionsPath": ["emmet1", "emmet2"]
In b, create a new html file and trigger emmet for ull

Bug
The snippet from a is used.
Even if I just set "emmet.extensionsPath": ["emmet2"],  I don't seem to be able to get the snippets from b to be used
I also tried "emmet.extensionsPath": ["b/emmet2"] but could not load the snippet this way

Also worth noting that you cannot set emmet.extensionsPath on a per folder level so that files in each workspace use a different snippets file
May be worth investigating making emmet.extensionsPath a resource level setting so that can be supported


Add more values for network-mode config key

network-mode valid values are default or vsock. We need another name for the default mode as the current plan is that vsock becomes the default in the future.

All I could think of was legacy or perhaps more informative bridged or switched, but this kinda based on the hypervisor... and native is also not the right name.

bridged sounds good to me, but not sure how good this name is on Windows?

Workable...


32x32 Matrix issues!

Matrix : https://www.digitalimpuls.no/diverse/143599/32x32-rgb-led-matrix-panel-6mm-pitch
Board : https://www.tindie.com/products/brianlough/esp32-i2s-matrix-shield/ (w/ D1 Mini ESP32)
Working Plasma Demo : https://streamable.com/vmbh6f (atleast i think it is working as it should...)
but displaying simple text within setup();
  dma_display->setTextSize(1);     // size 1 == 8 pixels high
  dma_display->setTextWrap(false); // Don't wrap at end of line - will do ourselves

  dma_display->setCursor(5, 0);

  dma_display->setTextColor(dma_display->color444(0,8,15));
  dma_display->println("LED MATRIX!");

  delay(5000);

does not work : https://cdn.discordapp.com/attachments/637812536158453780/813773646190477332/image0.jpg
i can se a faint hint of the text but as you see the entire 8 rows are almost lit up for some reason :S
Entire code main.cpp
#include <Arduino.h>
#include <Wire.h>
#include <SPI.h>

#include <ESP32-HUB75-MatrixPanel-I2S-DMA.h>
#include <FastLED.h>

// Configure for your panel(s) as appropriate!
#define PANEL_WIDTH 32
#define PANEL_HEIGHT 32  	// Panel height of 64 will required PIN_E to be defined.
#define PANELS_NUMBER 1 	// Number of chained panels, if just a single panel, obviously set to 1
#define PIN_E -1

#define PANE_WIDTH PANEL_WIDTH * PANELS_NUMBER
#define PANE_HEIGHT PANEL_HEIGHT

// placeholder for the matrix object
MatrixPanel_I2S_DMA *dma_display = nullptr;

uint16_t time_counter = 0, cycles = 0, fps = 0;
unsigned long fps_timer;

CRGB currentColor;
CRGBPalette16 palettes[] = {HeatColors_p, LavaColors_p, RainbowColors_p, RainbowStripeColors_p, CloudColors_p};
CRGBPalette16 currentPalette = palettes[0];

CRGB ColorFromCurrentPalette(uint8_t index = 0, uint8_t brightness = 255, TBlendType blendType = LINEARBLEND) {
  return ColorFromPalette(currentPalette, index, brightness, blendType);
}

void setup()
{

  Serial.begin(115200);

  HUB75_I2S_CFG mxconfig;
  mxconfig.mx_width = PANEL_WIDTH;
  mxconfig.mx_height = PANEL_HEIGHT;      // we have 64 pix heigh panels
  mxconfig.chain_length = PANELS_NUMBER;  // we have 2 panels chained
  mxconfig.gpio.e = PIN_E;                // we MUST assign pin e to some free pin on a board to drive 64 pix height panels with 1/32 scan
  //mxconfig.driver = HUB75_I2S_CFG::FM6126A;     // in case that we use panels based on FM6126A chip, we can change that

  // OK, now we can create our matrix object
  dma_display = new MatrixPanel_I2S_DMA(mxconfig);

  // let's adjust default brightness to about 75%
  dma_display->setBrightness8(96);    // range is 0-255, 0 - 0%, 255 - 100%

  // Allocate memory and start DMA display
  if( not dma_display->begin() )
      Serial.println("****** !KABOOM! I2S memory allocation failed ***********");

  // well, hope we are OK, let's draw some colors first :)
  Serial.println("Fill screen: RED");
  dma_display->fillScreenRGB888(255, 0, 0);
  delay(1000);

  Serial.println("Fill screen: GREEN");
  dma_display->fillScreenRGB888(0, 255, 0);
  delay(1000);

  Serial.println("Fill screen: BLUE");
  dma_display->fillScreenRGB888(0, 0, 255);
  delay(1000);

  Serial.println("Fill screen: Neutral White");
  dma_display->fillScreenRGB888(64, 64, 64);
  delay(1000);

  Serial.println("Fill screen: black");
  dma_display->fillScreenRGB888(0, 0, 0);
  delay(1000);

  /*dma_display->setTextSize(1);     // size 1 == 8 pixels high
  dma_display->setTextWrap(false); // Don't wrap at end of line - will do ourselves

  dma_display->setCursor(5, 0);

  dma_display->setTextColor(dma_display->color444(0,8,15));
  dma_display->println("LED MATRIX!");

  delay(5000);*/

  // Set current FastLED palette
  currentPalette = RainbowColors_p;
  Serial.println("Starting plasma effect...");
  fps_timer = millis();
}

void loop()
{
      for (int x = 0; x < PANE_WIDTH; x++) {
            for (int y = 0; y <  PANE_HEIGHT; y++) {
                int16_t v = 0;
                uint8_t wibble = sin8(time_counter);
                v += sin16(x * wibble * 3 + time_counter);
                v += cos16(y * (128 - wibble)  + time_counter);
                v += sin16(y * x * cos8(-time_counter) / 8);

                currentColor = ColorFromPalette(currentPalette, (v >> 8) + 127); //, brightness, currentBlendType);
                dma_display->drawPixelRGB888(x, y, currentColor.r, currentColor.g, currentColor.b);
            }
    }

    ++time_counter;
    ++cycles;
    ++fps;

    if (cycles >= 1024) {
        time_counter = 0;
        cycles = 0;
        currentPalette = palettes[random(0,sizeof(palettes)/sizeof(palettes[0]))];
    }

    // print FPS rate every 5 seconds
    // Note: this is NOT a matrix refresh rate, it's the number of data frames being drawn to the DMA buffer per second
    if (fps_timer + 5000 < millis()){
      Serial.printf_P(PSTR("Effect fps: %d\n"), fps/5);
      fps_timer = millis();
      fps = 0;
    }
}

Try the earliest published version of this library.
Doesn't this board have it's own pinmapping, can't see anything in your sketch to do with this.

Try the earliest published version of this library.
Doesn't this board have it's own pinmapping, can't see anything in your sketch to do with this.

you mean the I2S shield board i have? it uses the default pinout!

Try 1.2.4 version of the library.

Try 1.2.4 version of the library.

i've done that like 20 times, tested all the versions! none works


fix: add max = [Integer.MAX_VALUE] param to query all users from group memberlist of keycloak

Hello!
Thanks for sharing this incredible camunda keycloak plugin!
Keycloak GET /{realm}/groups/{id}/members by default returns only 100 rows. So I added max Integer value as size to fetch all users.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @zhmaksat,
thanks for your pull request. Fetching all users might be a good idea in your use case, but can cause issues for other scenarios. I know a customer who imported around 50.000 users into his Keycloak instance.
As leaving the default to 100 can't be the solution, I think I'm going to make this configurable. This might not only affect querying the members of a group, but querying all users without a filter as well. Furthermore I will have to check side effects with sorting and filtering, some of these are implemented within the identity provider plugin due to missing functionality of the Keycloak REST Api.
I'm going to leave this pull request open as a reminder.
Gunnar

Thanks for response.
The configurable option is also applicable for us. With special attention we are waiting for a solution. Good luck!

Hi @zhmaksat,
I have added a configuration option for maxResults to the plugin. See last commits. I will close this pull request, but leave the corresponding issue open until a new plugin version will be released.


Pull Request Guidance & Feature Request: Undo/Redo

It would be nice to have an undo/redo feature built into the page as a set of buttons.  I'm not entirely sure how complicated this would be. It looks like this is entirely built in HTML5 and JavaScript; so I will take a look around and see what I can do. (this also tells me that I can run this as a local web page offline, correct? It doesn't look like the cache service worker or any other components actually reaches beyond its own directory if I am not mistaken)
I cannot find any information on contribution; do you have a listed process for submitting pull requests if I have one?

I'm not the project manager, but yes this entire project is written in JS and will work offline (i.e. makes no communication.
As far as general issue tracking/contributions go.. it seems the project is kind of dead.. It may be better to just fork it and have people contribute to your fork.


Is there a way to use it with my own API key?

Hello Lian
Thanks for your great work!
I have compiled your version 0.0.1 and 0.0.2 with go and tried to use my own google api key
cmd > vfrmap.exe -api-key [mykey]
it just works for a second and then I get an javascript error in my browser
do I something wrong?
can I implement my key direct in your code somewhere?
your version 0.0.6 works really fine.
but google satellite data together with MSFS is just wow

hey, using the old version with -api-key should 'just work'. maybe if you have the detailed error that javascript chrome dev tools output it would be easier to debug.
but this projects doesn't support that old version anymore, so i'm going to close the issue here.


[Feature] Define Signature trait

Component
primitives
Describe the feature you would like
Add methods in Signature impl into new trait, and impl new trait for Signature. Add as super traits any From<T> etc impls for Signature.
Additional context
No response

we probably also want something like
#[cfg(not(feature = "rlp"))]
trait SignatureSuperTrait {}

#[cfg(feature = "rlp")]
trait SignatureSuperTrait: alloy_rlp::Encodable + alloy_rlp::Decodable {}

pub trait Signature: .. + SignatureSuperTrait {
    ...
}

but can do this as separate issue too


Improve domain files for better readability

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@32c569a). Click here to learn what that means.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   52.16%
=========================================
  Files             ?       29
  Lines             ?      370
  Branches          ?       43
=========================================
  Hits              ?      193
  Misses            ?      159
  Partials          ?       18

Impacted Files
Coverage Δ

src/timer/app/pauseTimer.js
100% <100%> (ø)

src/timer/app/stopTimer.js
100% <100%> (ø)

src/timer/app/skipTimer.js
100% <100%> (ø)

src/setupTests.js
100% <100%> (ø)

src/timer/app/playTimer.js
90.9% <100%> (ø)

src/timer/domain/Entry.js
100% <100%> (ø)

src/timer/store/index.js
91.48% <80.95%> (ø)

src/timer/domain/Session.js
96.22% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c569a...8d82ff9. Read the comment docs.


⚠ Turnos 24x7 has degraded performance

In e141954, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 932 ms

Resolved: Turnos 24x7 performance has improved in 316b0a8.


when i reset harbor.cfg,how make it tkae effect.

did i must del images and "docker-compose up -d" again?

i used 0.1.1 for step.

You need to execute docker-compose build, and remove the old volume /data because of the updated DB schema of this version, then run docker-compose up -d

then after that,am i created user and project will be OK？

Old data will be lost, you need to create user and project again.

thanks ~~

btw before execute docker-compose build,am i must "docker-compose stop"?

Of course.

Thank you for your answer patiently.


AfterPublish -> Publish

Moved from: https://github.com/dotnet/AspNetCore.Docs.de-de/issues/67
@BerndK commented 14 hours ago
It seems to be not working to use AfterPublish and BeforePublish, use just 'Publish' then it works
like: AfterTargets="Publish"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 684d1f55-3d8b-9ba6-ee65-e8f84c2b4244
Version Independent ID: 2db330b4-e830-715f-0a15-e406f85e1d3b
Content: Visual Studio publish profiles (.pubxml) for ASP.NET Core app deployment
Content Source: aspnetcore/host-and-deploy/visual-studio-publish-profiles.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The following folder publish profile was created with Visual Studio and publishes to a network share:
<?xml version="1.0" encoding="utf-8"?>
<!--
This file is used by the publish/package process of your Web project.
You can customize the behavior of this process by editing this
MSBuild file.
-->
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <WebPublishMethod>FileSystem</WebPublishMethod>
    <PublishProvider>FileSystem</PublishProvider>
    <LastUsedBuildConfiguration>Release</LastUsedBuildConfiguration>
    <LastUsedPlatform>Any CPU</LastUsedPlatform>
    <SiteUrlToLaunchAfterPublish />
    <LaunchSiteAfterPublish>True</LaunchSiteAfterPublish>
    <ExcludeApp_Data>False</ExcludeApp_Data>
    <PublishFramework>netcoreapp1.1</PublishFramework>
    <ProjectGuid>c30c453c-312e-40c4-aec9-394a145dee0b</ProjectGuid>
    <publishUrl>\\r8\Release\AdminWeb</publishUrl>
    <DeleteExistingFiles>False</DeleteExistingFiles>
  </PropertyGroup>
</Project>

@Rick-Anderson Im not talking about the profile.
I wanted to define a task that copies the files to a server (via SCP).
This task should fire after the publish process.
This is defined here: https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/visual-studio-publish-profiles?view=aspnetcore-3.1#run-a-target-before-or-after-publishing
But this does not work!
Wrong:
<Target Name="CustomActionsBeforePublish" BeforeTargets="BeforePublish">
Correct:
<Target Name="CustomActionsBeforePublish" BeforeTargets="Publish">
Same for AfterTargets.
Hope this more clear now.

@sayedihashimi  should I make this change? Have these targets changed?

I'm not sure but @vijayrkn should know.
I believe that the MSBuild targets across Visual Studio have moved away from the "BeforeTargetName" and "AfterTargetName" pattern, so it sounds like it's correct that BeforePublish and AfterPublish no longer are defined in our .targets file.

The current documentation is correct.  WebSdk has a "BeforePublish" & "AfterPublish" target that gets executed before and after the core publish operation.
The way to look at it is that the target "Publish" just consolidates all the files to be published but core publish does more than that like running transforms, updating app configs etc. So if something needs to run before that, then it should be based on "BeforePublish" & "AfterPublish"
https://github.com/dotnet/websdk/blob/f012288885a64c36c03aed371f5fba3ff3dc6da2/src/Publish/Targets/Microsoft.NET.Sdk.Publish.targets#L36-L37

Just to mention, that I did not use the websdk, but a .net core 3.1 project that has to be published. Initially I tried the "AfterPublish" (as described in doc) which has not been triggered in my case. But when I switched to "Publish", it worked as expected. Perhaps this is not perfectly consistent on all use cases (different project types might have defined additional targets, which is perfectly fine), perhaps it's worth to mention, that "Publish" might be a good guess for others.


Not able to set soundfont with prboom-plus

Game
Ultimate Doom
Engine
prboom-plus
Linux Distribution
Arch
Luxtorpeda Version
48
Bug description
Soundfont option not working
Steps To Reproduce

Set the MIDI player to fluidsynth
Get a soundfont
Set the path to the soundfont in the engine's config file
Open the game and see that nothing has canged

Expected Behavior
The chosen soundfont will be used
Additional Context
I don't understand much of this stuff, but could it be that the version of fluidsynth bundled with the engine is old? I tried to hyperlink it but everytime I launch the game it gets replaced
Relevant log output
No response

@lucascoelho07 What path is the soundfont in? All of the games are running under the steam runtime, so it has to be a path that is accessible. The library files are installed every launch. Fluid synth is 2.1.3, so fairly recent.

The soundfont is in .prboom-plus (same folder as prboom-plus.cfg)
I set it like this snd_soundfont    "roland.sf2" and it works fine with the normal version, but not with luxtorpeda

@lucascoelho07 Ok, can you describe a bit further what you are attempting to do?

Where did the soundfont come from and if possible could you provide it?
What version are you using for the "normal" version, both of prboom and fluidsynth?
What behavior inside prboom-plus are you expecting?
Can you provide logs showing the difference between the two attempts, as in using lux and using the "normal" version?

Feel free to comment if you continue to need help.

Try adding yourself to the audio group.

Sorry for taking so long to answer

@lucascoelho07 Ok, can you describe a bit further what you are attempting to do?
1. Where did the soundfont come from and if possible could you provide it?

I don't remember where I got it, but it's the Roland SC-55 by EmperorGrieferus

2. What version are you using for the "normal" version, both of prboom and fluidsynth?

For prboom-plus I've tested the version from the AUR and for libfluidsynth I'm using version 3.0.4 that comes with the fluidsynth package from the Extra repository on Arch

3. What behavior inside prboom-plus are you expecting?

I expect it to use the soundfont I set in prboom-plus.cfg

4. Can you provide logs showing the difference between the two attempts, as in using lux and using the "normal" version?

Could you give me information on where to grab the logs?
Let me try to explain better:
When I launch prboom-plus(the one from AUR) from terminal using prboom-plus -iwad "/home/myuser/.local/share/Steam/steamapps/common/Doom 2/base/DOOM2.WAD" it works as intended, but when I launch the luxtorpeda version it uses some other soundfont that is not the one I set.
Also if I let snd_soundfont empty the version from the AUR uses the same generic sounding soundfont as the luxtorpeda package
The soundfont file is in the same folder as the config file (/home/myuser/.prboom-plus)

Try adding yourself to the audio group.
Tried but no success

@lucascoelho07
By behavior, I was mainly wondering is it that the sound isn't working at all, or that it's not playing against the soundfont you expect?
For logs, the best way is running steam in terminal. Then you can copy and paste it into a file and upload it here.
Do other settings seem to be working between the prboom-plus you are using and the luxtorpeda one, like controls and graphics?
Also, have you tried setting in the config file a full path instead of the relative path?

@lucascoelho07
Also just to see if it helps, I did an upgrade PR where you can download the new version and see if it helps: https://github.com/luxtorpeda-dev/packages/suites/5105111019/artifacts/152802430
You can use this by going to ~/.cache/luxtorpeda/appid and replacing the latest .tar.xz file with the one inside the zip file given.

Everything seems to be working perfectly with the exception of music that plays but not as intended.
I tried this new version, but the game won't start (I renamed it to prboom-plus-common-6.tar.xz, is that right?)
prboom-plus log
steam log

@lucascoelho07
Could you try downloading the latest and trying again? I believe I've gotten it fixed, if  you put the filename to a soundfont and then drop the soundfont in the "steamapps/common/Ultimate Doom/prboom-plus/" directory, it should see it.
I was able to put a soundfont and then use fluidsynth and the music played as expected.
If you still have issues, let me know and please provide a log file.

IT WORKS!!!!!!!
THANK YOU SO MUCH
it also works on ~/ and ~/.prboom-plus


show=False raises NameError: name 'plt' is not defined for waterfall plot.

Below code for when using show=False on waterfall plot, it raises NameError: name 'plt' is not defined error.
Reproduce as below:
import xgboost
import shap

X, y = shap.datasets.boston()
model = xgboost.XGBRegressor().fit(X, y)

explainer = shap.Explainer(model)
shap_values = explainer(X)

shap.plots.waterfall(shap_values[0], show=False)

Duplicate of #2471
It has been fixed, try updating your shap version.

Thank you! Looks like it has not been fixed in latest v0.40.0, but installing from the master branch do fixes it.


move odo repo to redhat-developer

WORK IN PROGRESS
odo consist of two GitHub repositories:
https://github.com/openshift/odo
https://github.com/openshift/odo-init-image
Checklist:
before moving repos

[x] delete https://github.com/redhat-developer/odo-fork (originaly forked from redhat-developer/odo, and it might create some mess with redirects)
[ ] make sure that the repositories are moved/renamed, and we are not creating new once, only this will ensure that all redirects work properly

after repos are moved

[ ] Make sure that all matainers have write permissions to the repo
[ ] update odo pkg imports github.com/openshift/odo/* to   github.com/redhat-developer/odo/*
[ ] update CI jobs

[ ] update  OpenShift CI jobs in openshift/release
[ ] update Jenkins configuration for PSI jobs

[ ] update links in odo.dev
[ ] update links in readme.md
[ ] update links in docs/

contributors that have locally cloned odo repo should update its url git remote set-url origin https://github.com/redhat-developer/odo

[ ] update CI jobs

[ ]  update  OpenShift CI jobs in openshift/release

prepared prow ci config updates:

https://github.com/openshift/release/pull/23832
https://github.com/openshift/release/pull/23840


DSA : Implementation of Binary search tree in Python

Hi Avinash  I Would like to contribute binary search tree implementation in Python for Hacktoberfest fest in your repository. @avinash201199

@Adi7171  Go ahead :)


You have a lot of problem with your code

In many line, it has print inessario that assures that it does not execute. I tried it in many distro and nothing

Could you be more specific?

Did you try python2?
The style of print line in these codes is based on python2.

I'll assume that was the problem.


--ref option not available

Hi. Many thanks for this great tool. After running make command, it seems that --ref option is not available.
Here is the snapshot of the output of "./trust4 --help" command.

Thank you for your reply.

The --ref is available from the wrapper run-trust4. "./trust4" is the core program for assembly, but it still needs the output from fastq-extractor or bam-extractor. This will be handled by the wrapper.

The --ref is available from the wrapper run-trust4. "./trust4" is the core program for assembly, but it still needs the output from fastq-extractor or bam-extractor. This will be handled by the wrapper.

Thanks for the swift reply!


Fixed inability to drop user without host being specified

Fixes github.com/dolthub/issues/4135

Merging as it's an extremely simple fix


Add option to allow .scale_to_box() to size up (as well as down)

https://github.com/JujuAdams/Scribble/commit/afd29da3be459076e9cf002fc4ac81cd14bf55df


Type check failed in match where clause

(czp@nebula) [nba]>       MATCH p = (n:player)<-[e:like]-(m)       WHERE n.age >= 33.0000000000011         RETURN n.name AS player, n.age AS age
[ERROR (-12)]: SemanticError: Data type error of field : age

Mon, 01 Feb 2021 11:06:47 CST

(czp@nebula) [nba]>       MATCH p = (n:player)<-[e:like]-(m)       WHERE n.age >= 33         RETURN n.name AS player, n.age AS age
+---------------------+-----+
| player              | age |
+---------------------+-----+
| "Shaquile O'Neal"   | 47  |
+---------------------+-----+
| "Kobe Bryant"       | 40  |
+---------------------+-----+
| "Kobe Bryant"       | 40  |
+---------------------+-----+

The filter condition of IndexScan is too strict.

MATCH bug still in v2.0.1


ITHttpInputSourceTest instability blocking the development pipeline

The test has become very unstable recently and it is blocking the development pipeline. Offline debugging indicates that this is potentially a Travis memory limitation issue for docker where due to some reason (Travis change? Software change?) the runtime memory requirement increased to make this test fail. The docker memory issue described above is just a hypothesis based on log interpretation and local tests. Debugging and finding a solution may take some time so I am proposing to ignore this test to unblock the pipeline while I debug this and find a solution. The final solution may include some memory parameter changes and/or some structural changes to the test.

Partial update for #11744 so non-ingestion commits can continue to be merged till a complete fix is implemented

@loquisgon please update the title and the description. The title will be included in the git commit history, so it should be intuitive enough to understand the overview of change. What test will be ignored? Who's "we" in the title? Also, I feel a bit uncomfortable about this change because the PR description currently lacks the plan for the real fix. Who will continue working on the real fix? What is the plan for the follow-up?

I have updated the title and description but this PR is exactly what the previous title and description indicated. It is a pragmatic, tactical, action to just unblock the pipeline while I continue debugging the issue offline. I am identifying docker related memory pressure issues offline that make this test fail locally with some similarity to the Travis failures. But getting to the bottom may take some more time due to the slow debug cycle. The final solution may be in the form of having parameters change and/or structural test changes (maybe don't do memory intensive ingestion if all we are looking for is to test an input source). But I don't know yet.

@loquisgon thanks for updating the title and description. I asked to update them not because I don't agree with the motivation of this PR, but it lacks details. It didn't say what test you are disabling and why it is a good temporary workaround to unblock development. They are clear now. Thanks for looking into the issue. I'm going to approve this PR, but we should wait for Travis to finish and see whether it is less flaky than before.

Cool, Travis seems to pass all tests without restart! At least I didn't restart any job. I'm going to merge this. Thanks again @loquisgon for working on this!


Crash in vkQueueSubmit()

Hey! After updating to the 1.3.261.1 SDK (from <IP_ADDRESS>), I hit a crash when calling vkQueueSubmit(). I'm running on macOS Sonoma (14.0), and am building with Xcode 15.0
I built a debug package of MoltenVK locally to test against; here's my callstack:
#0	0x0000000107297d78 in mvk_smallvector_allocator<MVKRenderSubpass, 0>::operator[](unsigned long) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Utility/MVKSmallVectorAllocator.h:78
#1	0x0000000107297d5c in MVKSmallVectorImpl<MVKRenderSubpass, mvk_smallvector_allocator<MVKRenderSubpass, 0>>::operator[](unsigned long) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Utility/MVKSmallVector.h:305
#2	0x0000000107291458 in MVKRenderPass::getSubpass(unsigned int) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKRenderPass.h:302
#3	0x0000000107293df8 in MVKCommandEncoder::getSubpass() at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:642
#4	0x00000001073a7f94 in MVKGraphicsResourcesCommandEncoderState::encodeBindings(MVKShaderStage, char const*, bool, std::__1::function<void (MVKCommandEncoder*, MVKMTLBufferBinding&)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLBufferBinding&, MVKArrayRef<unsigned int const>)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLTextureBinding&)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLSamplerStateBinding&)>) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.mm:726
#5	0x00000001073a9254 in MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.mm:814
#6	0x000000010729531c in MVKCommandEncoderState::encode(unsigned int) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.h:92
#7	0x0000000107295208 in MVKCommandEncoder::finalizeDrawState(MVKGraphicsStage) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:735
#8	0x000000010728d9c8 in MVKCmdDrawIndexed::encode(MVKCommandEncoder*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCmdDraw.mm:408
#9	0x00000001072929d8 in MVKCommandEncoder::encodeCommandsImpl(MVKCommand*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:380
#10	0x0000000107292260 in MVKCommandEncoder::encodeCommands(MVKCommand*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:373
#11	0x000000010729208c in MVKCommandEncoder::encode(id<MTLCommandBuffer>, MVKCommandEncodingContext*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:347
#12	0x000000010729232c in MVKCommandBuffer::submit(MVKQueueCommandBufferSubmission*, MVKCommandEncodingContext*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:240
#13	0x0000000107371994 in MVKQueueFullCommandBufferSubmission<1ul>::submitCommandBuffers() at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm:635
#14	0x000000010736f57c in MVKQueueCommandBufferSubmission::execute() at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm:453
#15	0x000000010736c4b4 in execute(MVKQueueSubmission*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm:72
#16	0x000000010736c438 in MVKQueue::submit(MVKQueueSubmission*) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm:90
#17	0x000000010736cf48 in VkResult MVKQueue::submit<VkSubmitInfo>(unsigned int, VkSubmitInfo const*, VkFence_T*, MVKCommandUse) at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm:129
#18	0x000000010721da04 in vkQueueSubmit at /Users/aaron/Projects/MoltenVK/MoltenVK/MoltenVK/Vulkan/vulkan.mm:434

In MVKGraphicsResourcesCommandEncoderState::encodeBindings(), _cmdEncoder->_pEncodingContext->_renderPass is null (causing the crash in _cmdEncoder->getSubpass()->getFirstViewIndexInMetalPass().
My project uses the VK_KHR_dynamic_rendering extension, in case that's relevant.
Please let me know if there is any more information I can provide to help track this down.
Thanks!

Hard to tell what's going on here, relative to this report. As far as I can tell, any changes to code relevant to this issue, changed well before the Vulkan <IP_ADDRESS> MoltenVK release.

In MVKGraphicsResourcesCommandEncoderState::encodeBindings(), _cmdEncoder->_pEncodingContext->_renderPass is null (causing the crash in _cmdEncoder->getSubpass()->getFirstViewIndexInMetalPass().

The call stack at the top seems to indicate that the renderpass was retrieved, and the getSubpass() call is not finding the correct subpass.

My project uses the VK_KHR_dynamic_rendering extension, in case that's relevant.

Are you using multiview as well? There might be an issue with reaching the subpass for the mulitview. That did change between the <IP_ADDRESS> and 1.3.261.1 releases.
If you are using multiview, Is it possible to get more information about how you are using it?
Are you able to post access to a sample app that demonstrates the issue?

My project is located at https://github.com/aaronmjacobs/Forge

I'm having a tough time cloning your repo (same thing happens without the --recurse-submodules). Have you encountered this before?
$ git clone --recurse-submodules https://github.com/aaronmjacobs/Forge.git
Cloning into 'Forge'...
remote: Enumerating objects: 3493, done.
remote: Counting objects: 100% (550/550), done.
remote: Compressing objects: 100% (336/336), done.
remote: Total 3493 (delta 328), reused 361 (delta 210), pack-reused 2943
Receiving objects: 100% (3493/3493), 2.04 MiB | 16.33 MiB/s, done.
Resolving deltas: 100% (2377/2377), done.
git-lfs filter-process: git-lfs: command not found
fatal: the remote end hung up unexpectedly
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

git-lfs filter-process: git-lfs: command not found

Looks like you need to install git-lfs.

My apologies, I forgot that I had set up git-lfs for the project a while back. Installing git-lfs before cloning the repo should allow it to succeed. Alternatively, if you'd prefer not to install it, I've uploaded a full copy of the repo here: https://drive.google.com/file/d/171IH_cD1aIpyP-P6m8rOtjIxT754E97I/view?usp=share_link

I've uploaded a full copy of the repo

Thanks. I got it working from your upload.
I've attached a Vulkan call trace:  Forge-Vulkan-Call-Trace.txt.zip
In the trace, there are many vkCmdDraw* calls prior to the first and only occurrence of vkCmdBeginRenderPass. You mention using the VK_KHR_dynamic_rendering extension, in which case there should be a call to vkCmdBeginRendering prior to any vkCmdDraw* calls.
BTW...you can enable Vulkan call tracing by adding the MVK_CONFIG_TRACE_VULKAN_CALLS=1 environment variable before running your app.

Thanks for the heads up about MVK_CONFIG_TRACE_VULKAN_CALLS, that should be helpful in tracking down issues in the future.
It's true that I only call vkCmdBeginRenderPass() once per frame, as all my rendering uses vkCmdBeginRendering() instead, except for Dear ImGui. What's strange is, if I set MVK_CONFIG_TRACE_VULKAN_CALLS, I can see the log output, but when I step over the call to vkCmdBeginRendering(), it doesn't get logged.
It seems like the core issue here is likely that the call isn't being registered for some reason. Any ideas why that might be?
Thanks!

After trying out a few things, I discovered that things seem to fall apart in the validation layer somehow. I call vkCmdBeginRendering(), but vkCmdBeginRendering() in vulkan.mm never gets hit. I tried disabling validation layers in my code, and sure enough, everything works as expected.
I'm not sure where the validation layer / vulkan_layer_chassis code lives, so it's hard for me to investigate further.

Wait, are you calling vkCmdBeginRendering(), or vkCmdBeginRenderingKHR() (with the KHR suffix)? The former requires Vulkan 1.3. The latter is what is exposed by VK_KHR_dynamic_rendering.

I'm calling vkCmdBeginRendering(), not vkCmdBeginRenderingKHR(). My project uses Vulkan 1.3, and also requests the VK_KHR_dynamic_rendering extension. If I don't request the extension, I hit an error in the validation layer when creating pipelines (VUID-VkGraphicsPipelineCreateInfo-pNext-pNext, "vkCreateGraphicsPipelines: Includes a pNext pointer (pCreateInfos[0].pNext) to a VkStructureType (VK_STRUCTURE_TYPE_PIPELINE_RENDERING_CREATE_INFO), but its parent extension VK_KHR_dynamic_rendering has not been enabled").

MoltenVK does not yet support Vulkan 1.3 (see #1852). It reports Vulkan 1.2. Therefore, attempting to use vkCmdBeginRendering() on MoltenVK is, according to the Vulkan standard, undefined behavior (i.e. you must not do this--emphasis theirs). It happens to work in MoltenVK alone, but the validation layer checks that you are not violating the standard by invoking undefined behavior. So it refuses to forward vkCmdBeginRendering() to MoltenVK, even though MoltenVK's vkGetDeviceProcAddr() returns a non-null pointer for that function. If you want the validation layer to pass, you must call vkCmdBeginRenderingKHR() when the ICD advertises VK_KHR_dynamic_rendering but not core 1.3. (Admittedly, the validation layer could probably handle this better, e.g. by printing a validation failure message when you call vkCmdBeginRendering() without core 1.3.)
Note that a 1.1+ instance will actually allow you to create a downlevel device by default, so if you really do need 1.3, you have to check the version of Vulkan that the physical device supports.

Thanks for the detailed info, that all makes sense. Calling vkCmdBeginRenderingKHR() does indeed fix the issue, and everything works as expected.
I definitely agree that it would be helpful for the validation layer to output a message if it decides to not forward the function call. Where would be the best place for me to request that feature?
Thank you!

On the issues page of the KhronosGroup/Vulkan-ValidationLayers project.

Wait, are you calling vkCmdBeginRendering(), or vkCmdBeginRenderingKHR() (with the KHR suffix)? The former requires Vulkan 1.3. The latter is what is exposed by VK_KHR_dynamic_rendering.

Ah! Good thinking!

the validation layer could probably handle this better, e.g. by printing a validation failure message when you call

I definitely agree that it would be helpful for the validation layer to output a message if it decides to not forward the function call. Where would be the best place for me to request that feature?

And yes...I would expect the validation layer to spit out errors on any calls not supported by a Vulkan API version, or enabled extensions. Might be an oversight, and worth reporting to them.


New Icon?

I thought now that we have the possibility to use SpotMenu with different players, maybe it would be more consistent to have a new app icon that suggest that not only Spotify can be used with it.
Of course I love the current logo, this was just a thought.
V1:

V2:

The last one looks quit similar to another app called MiniPlay though.... What about this version?

@kmikiy what do think ? :)

Wow they all look great 👍 especially v1 in the purple or orange color and v3

they all look good to me, i'll check what they look like live

So, now I am satisfied with the look of the icons. Took me quite a while, and sometimes only a small change. Hope you like it :)

great work :) Already chose one, erm two...  😋