[Bug] build from source error, follow the instructions but cannot find mpi-cxx

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.

Describe the bug
When I followed the procedure of installation from source, I came across this  error, can you have a look at and help me fix this error, Thanks   In conda install command I found openmpi-mpicxx will be installed, is there something wrong my openmpi-cxx is not successfully installed, how can i check this?
CMake Error at /usr/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find MPI (missing: MPI_CXX_FOUND)
Call Stack (most recent call first):
/usr/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.24/Modules/FindMPI.cmake:1835 (find_package_handle_standard_args)
CMakeLists.txt:68 (find_package)
The following packages will be downloaded:
package                    |            build
---------------------------|-----------------
binutils_impl_linux-64-2.38|       h2a08ee3_1         5.2 MB
binutils_linux-64-2.38.0   |       hc2dff05_0          24 KB
ca-certificates-2023.7.22  |       hbcca054_0         146 KB  conda-forge
cudatoolkit-10.2.89        |      h713d32c_10       449.7 MB  conda-forge
gcc_impl_linux-64-11.2.0   |       h1234567_1        22.2 MB
gcc_linux-64-11.2.0        |       h5c386dc_0          25 KB
gxx_impl_linux-64-11.2.0   |       h1234567_1        10.6 MB
gxx_linux-64-11.2.0        |       hc2dff05_0          24 KB
kernel-headers_linux-64-2.6.32|      he073ed8_16         692 KB  conda-forge
libgcc-devel_linux-64-11.2.0|       h1234567_1         2.5 MB
libgfortran-ng-7.5.0       |      h14aa051_20          23 KB  conda-forge
libgfortran4-7.5.0         |      h14aa051_20         1.2 MB  conda-forge
libstdcxx-devel_linux-64-11.2.0|       h1234567_1        14.6 MB
mpi-1.0                    |          openmpi           4 KB  conda-forge
nccl-<IP_ADDRESS>              |       h1a5f58c_0       106.4 MB  conda-forge
openmpi-3.1.3              |    h1c2f66e_1001         4.0 MB  conda-forge
openmpi-mpicxx-3.1.3       |    h6bb024c_1001           7 KB  conda-forge
rapidjson-1.1.0            |    he1b5a44_1002         104 KB  conda-forge
sysroot_linux-64-2.12      |      he073ed8_16        14.6 MB  conda-forge
------------------------------------------------------------
                                       Total:       632.1 MB

The following NEW packages will be INSTALLED:
binutils_impl_lin~ pkgs/main/linux-64::binutils_impl_linux-64-2.38-h2a08ee3_1
binutils_linux-64  pkgs/main/linux-64::binutils_linux-64-2.38.0-hc2dff05_0
cudatoolkit        conda-forge/linux-64::cudatoolkit-10.2.89-h713d32c_10
gcc_impl_linux-64  pkgs/main/linux-64::gcc_impl_linux-64-11.2.0-h1234567_1
gcc_linux-64       pkgs/main/linux-64::gcc_linux-64-11.2.0-h5c386dc_0
gxx_impl_linux-64  pkgs/main/linux-64::gxx_impl_linux-64-11.2.0-h1234567_1
gxx_linux-64       pkgs/main/linux-64::gxx_linux-64-11.2.0-hc2dff05_0
kernel-headers_li~ conda-forge/noarch::kernel-headers_linux-64-2.6.32-he073ed8_16
libgcc-devel_linu~ pkgs/main/linux-64::libgcc-devel_linux-64-11.2.0-h1234567_1
libgfortran-ng     conda-forge/linux-64::libgfortran-ng-7.5.0-h14aa051_20
libgfortran4       conda-forge/linux-64::libgfortran4-7.5.0-h14aa051_20
libstdcxx-devel_l~ pkgs/main/linux-64::libstdcxx-devel_linux-64-11.2.0-h1234567_1
mpi                conda-forge/linux-64::mpi-1.0-openmpi
nccl               conda-forge/linux-64::nccl-<IP_ADDRESS>-h1a5f58c_0
openmpi            conda-forge/linux-64::openmpi-3.1.3-h1c2f66e_1001
openmpi-mpicxx     conda-forge/linux-64::openmpi-mpicxx-3.1.3-h6bb024c_1001
rapidjson          conda-forge/linux-64::rapidjson-1.1.0-he1b5a44_1002
sysroot_linux-64   conda-forge/noarch::sysroot_linux-64-2.12-he073ed8_16
The following packages will be SUPERSEDED by a higher-priority channel:
ca-certificates    pkgs/main::ca-certificates-2023.08.22~ --> conda-forge::ca-certificates-2023.7.22-hbcca054_0
Proceed ([y]/n)? y
Downloading and Extracting Packages
Preparing transaction: done
Verifying transaction: done
Executing transaction: / By downloading and using the CUDA Toolkit conda packages, you accept the terms and conditions of the CUDA End User License Agreement (EULA): https://docs.nvidia.com/cuda/eula/index.html
done
Reproduction
Build from source
install packages for compiling and running:
conda create -n lmdeploy python=3.10
conda activate lmdeploy
git clone https://github.com/InternLM/lmdeploy.git
cd lmdeploy
pip install -r requirements.txt
conda install openmpi-mpicxx nccl rapidjson -c conda-forge
build and install lmdeploy:
mkdir build && cd build
sh ../generate.sh
After running generate.sh command above, i got this error
Error traceback
No response

@ehuaa hi, could you try with the prebuilt docker image: docker pull openmmlab/lmdeploy:latest. https://hub.docker.com/r/openmmlab/lmdeploy/tags

@ehuaa This issue may be caused by PR #370
The installation method of conda may not be very robust, you can try the earliest compilation and installation method of lmdeploy
https://github.com/InternLM/lmdeploy/blob/18c386d914e8c7ec35b8be1d146a579a45deacad/docs/en/build.md

I have checked my installation of mpicxx and found it in lmdeploy/bin/mpicxx  which has been successfully installed. I wonder if the CMakeLists.txt has something wrong with mpicxx?

@pppppM

maybe you should add FindMPICXX here?

@ehuaa This issue may be caused by PR #370
The installation method of conda may not be very robust, you can try the earliest compilation and installation method of lmdeploy
https://github.com/InternLM/lmdeploy/blob/18c386d914e8c7ec35b8be1d146a579a45deacad/docs/en/build.md

@pppppM I tried this earlier version of installation method  and install mpi from source just can't work well... can you take a look at the MPI env above ? I think this can make installation work well.

@ehuaa hi, could you try with the prebuilt docker image: docker pull openmmlab/lmdeploy:latest. https://hub.docker.com/r/openmmlab/lmdeploy/tags

@RunningLeon Can you give a tutorial of using docker file to compile lmdeploy from source and every time i modify some code, if i should reconstruct the docker file as well to compile it again?

@ehuaa hi, you could create a container and do everything inside it. Just like you do in a host machine.
docker pull openmmlab/lmdeploy:latest
docker run -it --rm --gpus=all openmmlab/lmdeploy:latest
...

@ehuaa may check if PR #602 helps

@ehuaa hi, you could create a container and do everything inside it. Just like you do in a host machine.
docker pull openmmlab/lmdeploy:latest
docker run -it --rm --gpus=all openmmlab/lmdeploy:latest
...

docker save my time, thanks

@ehuaa may check if PR #602 helps

Ok, I'll follow this instruction

#602 has been merged. If there is any question, feel free to update this issue.


Implemented new features

Hi,
I noticed your project and I thought I would help. I'm a huge vi fan and I've just started getting into Xcode and git. I'll be glad to continue helping with more features as I find time.

I have a question about your code.
This is just because my lack of understanding of NSScrollView and its NSClipView.
I want to confirm my understanding.
What I see in the code handling 'zz' is
NSPoint center = NSMakePoint(0.0, [[scrollView documentView] bounds].size.height / 2);
[[scrollView contentView] scrollToPoint:center];

The center.y is always same value if the source code view is fixed size.
After we call scrollToPoint, the point specified by "center" becomes (0,0) of the NSClipView's bounds.
Is this right?

You are right. It could just be this instead:
[[scrollView contentView] scrollToPoint:NSMakePoint(0.0, 0.0)]


Add salesforce conference.

Kindly add salesforce conference.

@s1974kumar do you have a link to the conference?

No
On Mon, 6 Jan 2020, 10:26 Nikhita Raghunath<EMAIL_ADDRESS>wrote:

@s1974kumar https://github.com/s1974kumar do you have a link to the
conference?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nikhita/tech-conferences-india/issues/172?email_source=notifications&email_token=ALMABZXMYDK5TJELRNSOSD3Q4K2WLA5CNFSM4J6HXNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIENEHY#issuecomment-571003423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALMABZRH3UKRLNDQ3OBDO6TQ4K2WLANCNFSM4J6HXNRQ
.

We'll need a link to the conference to add it to the README. Closing since this isn't actionable.


Additional Query

A parameter has been added to increase the possibilities of queries, so it is possible to make optimistic updates on transactions.
Two tests were added, one to verify the transaction by passing the additional parameter and a rollback test.
In the README an example of how to pass this additional parameter has been added.

@renanpupin


Example not working

I saw some previous issues about the examples not working which were related to webpack version. I am a v2.1.0-beta.27 after npm installing and I receive no errors.
The server says its running on localhost:8080 but I see nothing when I view in the browser, just "The localhost page isn't working"
I tried upgrading webpack-dev-server and webpack to v2.2.0-rc.0 and that didn't help..

Hey @marr I have tried to run the example from a clean clone and it worked, can you tell me which browser / node version you are using ?

Hi Alex, I tried using node v5.11.1, 6.4.0, 7.2.0 and Safari 10.0.2 and Chrome 55.0.2883.95. It seems there may be some kind of issue on my machine, because I tried it on another machine last night and things worked fine. I'm not sure how to troubleshoot this on my machine. If you have any ideas let me know. Thanks!

@marr I've tried it as well, and it does still work. I'll close this for now. Can you provide more information in case it's an issue with the server or build itself? If it doesn't output an error though, it shouldn't be an issue with the example.

I am on osx 10.11.6 (el capitan), its possible my machine just needs a clean but i found it odd this didn't show any errors it just seemed to not get any data from the server. I run another development app on localhost:8080 just fine (closed it obviously before starting this). lsof -i:8080 was empty before starting this server, so there shouldn't be any conflict.

Well, I'm unsure how to help you with this :?
All we're doing is this on the webpack-dev-server:
server.listen(8080, "localhost", function() {
  console.log('☕  Server is listening on localhost:8080.');
})

Might be worth trying to change it to just server.listen(8080, function() {

@philpl That did fix it. I wonder what the issue with specifying "localhost" is?

@marr It might be an issue that prevents localhost from resolving to <IP_ADDRESS> or ::1 on your machine, maybe?


Small issue in responsive navbar

Describe the bug
The navbar has an anchor element for meet pets which has styling inconsistent with links in the navbar because of p-3 tailwind class
To Reproduce
Steps to reproduce the behavior:

Go to https://akshitagupta15june.github.io/PetMe
Compress the screen horizontally using developer tools window
Click on navbar menu icon
See error at pet me link

Expected behavior
The anchor element should have same styling as other elements
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser chrome

Additional context
Just a minor issue

Hey @Sachin4219
I am a GSSOC'23 contributor and would like to work on this.
Please assign me.
Thank you :)

@yeolesanskruti Sorry to say but I am just a contributor here so, I cannot assign anyone even I was not assigned this issue I created. PR for this issue has already been submitted

Ok. Thank you :)
On Mon, 19 Jun, 2023, 11:24 pm Sachin Shukla, @.***>
wrote:

@yeolesanskruti https://github.com/yeolesanskruti Sorry to say but I am
just a contributor here so, I cannot assign anyone even I was not assigned
this issue I created. PR for this issue has already been submitted
—
Reply to this email directly, view it on GitHub
https://github.com/akshitagupta15june/PetMe/issues/837#issuecomment-1597549109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6Y2W47RMIBQSAOTPYT5BTTXMCG45ANCNFSM6AAAAAAZH4DAZY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Hack

Hack
Originally posted by @ashvan23 in https://github.com/ashvan23/github-slideshow/issues/1#issuecomment-850808877

Hack
Originally posted by @ashvan23 in https://github.com/ashvan23/github-slideshow/issues/1#issuecomment-850808877


Premine?

How could I use this generator to generate a monero based coin with premine?

Not implemented. If you want to implement, you can use the bytecoin version of the generator and port it


Investigate many users' servers stopping simultaneously during cryocloud tutorial

From @tsnow03 on slack:

The CryoCloud hub has just shut down for all of our users during our tutorial.

We did have some commands run by a tutorial lead that may have messed up our server:

Then we shut down our server and it took a while for that server to clear and for us to be able to start a new one. In the mean time, most people in the tutorial were kicked off. But we were able to get back up and running fine after that. Thinking through how it happened, it brings up a few questions on our new shared server system.

We currently tell our users to go to hub control and stop server before logging off.
Also, if my server gets stuck and needs to be shut down, I'm guessing everyone else I'm sharing with also experiences the loss of their server? (edited)

On my end, it was a cell where the pip install/import cell never stopped running - kernel said it was busy but wouldn't interrupt out of it. After a couple kernel restarts, the cells weren't responding and kernel continued to say Connecting so we stopped server and logged off. We had a few tries at starting the server again from the login page and it gave the "Your server is stopping. You will be able to start it again once it has finished..." error. That is when many people in the room started saying they were being kicked off.

I need to check with people to find out what their errors were because I was a little too distracted to check other people's computers in that moment. I'm sure my personal server issue was the bad cell commands and maybe an overload, and was mostly the server being slow to shutdown, but I was thrown off by a bunch of people losing their servers. (edited)

People were able to log back in but it took a few minutes. I just heard back that our users experienced a window popping up about the server. I think it was the Server Unavailable or Unreachable window that pops up after a person stops their server.

In local time (to me, UTC+0530), the issue was reported on slack at 9:11 PM.
Looking at Grafana (https://grafana.cryointhecloud.2i2c.cloud/d/iqt8mUSVk/cluster-information?orgId=1&from=1679657257498&to=1679694542140) I see:

So there was a drop in user count immediately after, I think this is the hub noticing some of these pods were gone and acting appropriately. So in some ways, this is the part that worked well, as it allowed the pods to come back up. So, why were those pods killed?
Looking at the graph of memory usage:

You can see that for one particular node, memory usage hit full, and then there's data missing - meaning the node _exporter on that node was also killed - and then everything came back a while later. So the node basically went OOM.

Looking at the new pod diagnostics dashboard for that same time period, we see:

Restricting it to just pods that have more than 2GB of usage:

Counting, that's at least 17 users with more than 2GB, and I think they were mostly on the one node. I validated this by modifying the query (PR for that: https://github.com/jupyterhub/grafana-dashboards/pull/70) to only show users on the affected node:

So that's 13 users, all on the node that had the problem.
Now to figure out which profile these users had picked. We unfortunately don't have logs here, but given that these are set as memory requests, we can actually get that info from prometheus (PR incoming). So for that one node, we have:

So this means the node died because we had too many pods with memory usage far exceeding their requests.

@consideRatio I think this is super relevant to the node sharing work too.

Ok great to know. Thank you @yuvipanda for investigating! It sounds like the pip install shut everyone down. I did have most people on a 1 Gb slot, so we should find out ahead of time what the memory load will be and make sure people grab a larger memory subset at the beginning of the session in tutorials and events. I will also tell people as part of good habits in the cloud to be aware of their memory usage and grab the memory slot that fits their usage. This will be great info for our event leaders too so they can avoid the same challenges. Thank you!!!

Thanks @tsnow03.
I think there are two action items here:

[ ] How do we make it easier for users to pick the 'right' set of resources for them? What was your experience with the current set of profiles, @tsnow03?
[ ] Set memory limits for all profile options too. We can be generous here, but especially for workshops, I think we must set them so users don't all accidentally stomp on each other.

@yuvipanda I think its reasonable to precautionary set limits to make user pods experience out of memory killed processes instead of having the node experience memory pressure and evict user pods. Its more disruptive to be evicted than having a process in the server be killed.
I'm writing this comment to challenge the communication and/or understanding a bit, where "node died" and "stomp on each other" is specific phrases that prompted this.

So this means the node died because we had too many pods with memory usage far exceeding their requests.

Set memory limits for all profile options too. [...]I think we must set them so users don't all accidentally stomp on each other.

I assume the node didn't die in the sense that it became entirely unusable and had to be replaced, but it experienced memory pressure one or more times and that led to pod evictions. When it happened, I expect that not all pods exceeding their memory requests were evicted, but only one or a few of the pods that exceeded their memory request the most.
An alternative communication/understanding

A node/machine were running out of memory as individual user servers running on the node consumed more memory than they had requested on average. When this happened the node ensured it function by forcefully terminating entire user servers that exceeded their requested memory with the largest relative amount.
When a forceful termination of a user server happens, the user will note that jupyterhub doesn't understand that it isn't available either for a while. In practice, its not JupyterHub itself, but KubeSpawner that should be aware of this, and https://github.com/jupyterhub/kubespawner/issues/714 represents a proposal to make KubeSpawner handle this situation better.
A "better safe than sorry" approach (that will cost more) to avoiding forceful termination of user servers is by putting a limit on their memory use to match the requested memory. If they pass this limit they will instead experience a forceful termination of a process inside their user server (typically not the entire server), such as a Python kernel running code in a Jupyter noteboook.
Right now, several 2i2c community hubs are configured without limits on memory for individual users. Very advanced users could protect themselves from forceful terminations by requesting more memory than they consume, but it would be good if as few as possible has to learn to become a very advanced user. With that in mind, it could be helpful to provide a limit on memory per user server, but if that should be equal to the request, twice the request, or four times the request etc is impossible to say. If in doubt, having a memory limit of four times the requested memory is probably a good starting point.
Ideally, users are guided to refine their request so that they don't consistently use a lot more than they have requested. If they do, the limits become less important. Limits can be seen as a safeguard of forceful user server terminations.

I realize this comment should be refined with discussion and graduate into documentation for 2i2c engineers and community members etc, but for now I've made it here and I'll reference it from other places.
Suggested action points
These are action points scoped for cryocloud specifically.

cryocloud's hub is setup with memory limits matching 4x the requested memory to force users using a lot of memory to become aware of it without crashing their user server
cryocloud's community representatives consider if they think the current default node share choice is what makes sense for the different machine types (small, medium).

Currently small machine type (32GB, 4CPU) defaults to 1 GB of memory request, should it default to 2GB?
Currently medium machine type (128GB, 16CPU) defaults to 4 GB of memory requests, should it default to 4GB still or something even higher?

@consideRatio I actually just had a conversation with @MattF-NSIDC today and they suggested that we change the default. I think it would be ideal to use 4 Gb for the small (I think most people probably work at 2-3 Gb) and 16 Gb for the medium server.
@yuvipanda I'm going to be telling users to check their memory usage from time to time to give them a good idea of how much they tend to use, and adjust their server size to that.

@tsnow03 the change requires a pull request to this repo, relocating a default: true line in two places, one for small, and one for medium, both in the same file. I've opened https://github.com/2i2c-org/infrastructure/pull/2470 representing this.
With 4GB / 16GB requested memory for small / medium nodes, they will both fith 8 users per node still before a new node has to be started.

Awesome. That makes sense. Thank you so much for showing me!

Closed after revision, feel free to open if you disagree.


Fonts not included in the demo

Hi, I stumbled upon this issue when optimizing hopscotch using r.js.
The demo file flat-ui.css imports demo/fonts/Flat-UI-Icons-16.eot which is not there.
Thanks!

Thanks for the info! Per #288, this folder should be going away, so marking as Won't Fix.


Add Mailgun support to Ghost

When setting up Ghost, we never got around to integrating email support. As of now, no emails are sent for password reset, account creation, etc.
This issue involves only using our existing Mailgun account for The Gazelle which we use for<EMAIL_ADDRESS>email addresses. I believe Ghost has built-in support for this, so you only have to hook up the Mailgun API to Ghost's existing end-points.

We're removing Ghost


Problems with debugger

Estou com problemas para rodar o debugger

node_modules/vitest/vitest.mjs run --threads false --coverage -t should return an entity with errors<EMAIL_ADDRESS>Debugger listening on ws://<IP_ADDRESS>:45253/92ab3c49-bf70-4b84-bf71-cb5e52b09cba
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Waiting for the debugger to disconnect...
^C
Process finished with exit code 130 (interrupted by signal 2: SIGINT)

I think this post lacks some information what is actually problematic.
However i did also have problems in the past, maybe this helps you. In order to come to the next breakpoint you need to initially click on "Resume Program" or hit F9.
I don't know why this is the case, but this enables you to start the actual test and get to breakpoints etc.

I think this post lacks some information what is actually problematic. However i did also have problems in the past, maybe this helps you. In order to come to the next breakpoint you need to initially click on "Resume Program" or hit F9. I don't know why this is the case, but this enables you to start the actual test and get to breakpoints etc.

Obrigada! Vou tentar fazer


Support for paletted PNG

This doesn't look right.  It has a memory leak, the png structures are still allocated by libpng and never deallocated.  Plus, in the generic case there is no assurance that the palette will be consistent between tiles.

How about adding the palette to PNGs in a separate filter module?
That way you can serve all PNGs as grayscale and colorize them on the way out, consistently.
And I will finish the code that expands palette PNGs to RGBA, just in case we use a service that uses an inconsistent or optimized palette.

Would it make sense to instead have a hook for an optional Lua filter script?

I'm not sure from where we would get the palette information if not from the tiles. Are you suggesting to grab the color palettes from config files?

Indeed, get a palette from a config file.  That way the input can be true
grayscale, no palette.
On Mon, May 1, 2017 at 7:01 PM, Joe T Roberts<EMAIL_ADDRESS>wrote:

I'm not sure from where we would get the palette information if not from
the tiles. Are you suggesting to grab the color palettes from config files?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lucianpls/mod_reproject/pull/4#issuecomment-298479235,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHdvNdmvzrJCRi0ri1-WNmzGN3Flm80ks5r1o6KgaJpZM4NK3Fn
.


Improvement in Scroll sync with recycler plugin

#29

I check your pr and you have a bug with horizontal scroll on the headers

Fixed. #34


NP-38 Create contact details

Add contact details component. This is a very simple component with just title + body coming from Contentful.

@panosvoudouris looks good, only thing I've noticed:

[ ] There should be 24px paragraph spacing, each different contact option would be a new paragraph

Closed as the content model is not yet defined.


Installation problem.

In the process of installing a tool, I have run into a problem. I was going through the "How to use" section. Please, see the picture below.

It may probably be caused by "-install"

Updated the readme file with the correct command as
npm install -g
Thank you!


[firebase_messaging]: Data only message not delivered to firebase onMessage listener in Foreground

Is there an existing issue for this?

[X] I have searched the existing issues.

Are you aware of the differences between iOS and Android background message handling?

[X] I understand that iOS and Android background messages behave differently, and I've designed my application with that in mind.

Do you have an active Apple Developer account?

[X] I have an active Apple Developer account.

Are you using a physical iOS device to test background messages?

[X] I am using a physical iOS device to test background messages.

Have you enabled "Remote Notifications" & "Background Mode" (Checking options for "Background Processing" & "Remote Notifications") in your app's Xcode project?

Have you created an APNs key in your Apple Developer account & uploaded this APNs key to your Firebase console?

Have you disabled method swizzling for Firebase in your app?

Are you sending messages to your app from the Firebase Admin SDK?
admin
  .messaging()
  .send(

    {
      token: token,
      data: {
        type:'example',
      }
    },
  false,
  )
  .then((res) => {
    if (res.failureCount) {
      console.log('Failed', res.results[0].error);
    } else {
      console.log('Success');
    }
  })
  .catch((err) => {
    console.log('Error:', err);
  });

Have you requested permission from the user to receive notifications?

[X] I have the relevant permission to receive notifications.

Have you used the 'Console' application on your macOS device to check if the iOS device's system is throttling your background messages?
padrão	10:30:55.722393-0300	SpringBoard	Received incoming message on topic br.com.pushapplication at priority 5
padrão	10:30:55.751090-0300	SpringBoard	[br.com.pushapplication] Received remote notification request B5D0-3548 [ waking: 0, hasAlertContent: 0, hasSound: 0 hasBadge: 0 hasContentAvailable: 1 hasMutableContent: 0 pushType: Background]
padrão	10:30:55.751188-0300	SpringBoard	[br.com.pushapplication] Process delivery of push notification B5D0-3548
padrão	10:30:55.751246-0300	SpringBoard	[br.com.pushapplication] Request DUET delivers content-available push notification to application
padrão	10:30:55.751513-0300	SpringBoard	SUBMITTING: com.apple.pushLaunch.br.com.pushapplication:F3EB4A
padrão	10:30:55.753089-0300	dasd	Submitted Activity: com.apple.pushLaunch.br.com.pushapplication:F3EB4A at priority 5 (Wed Oct 11 10:30:55 2023 - Thu Oct 12 10:30:55 2023)
padrão	10:30:55.761168-0300	dasd	com.apple.pushLaunch.br.com.pushapplication:F3EB4A:[
	{name: ApplicationPolicy, policyWeight: 50.000, response: {Decision: Absolutely Must Proceed, Score: 1.00, Rationale: [{[appIsForeground]: Required:1.00, Observed:1.00},]}}
 ], FinalDecision: Absolutely Must Proceed}

Additional context and comments
I'm using Flutter version 3.10.4
Firebase Messaging version: 14.6.2
iOS device: iPhone 8
iOS version: 16.3.1
I'm sending a data only message to my Flutter app running in foreground using the admin script above. However, It's not being processed by onMessage listener, on android everything is fine. The only thing that appears on my log is this:
Warning: Application delegate received call to -application:didReceiveRemoteNotification:fetchCompletionHandler: but the completion handler was never called.

The message works well if the 'notification' part is present, but I need the push to be silent. Any help?
Here's my AppDelegate.swift:

Thanks for the report @thiagommohallem
Check this issue and see if it resembles your case and helps to resolve your case or not.

Thank you for the reply @darshankawar, but I'm afraid not. I only see the problem with data-only notifications exclusively on my iOS device. I'm able to send a 'normal' notification and trigger the onMessage method as shown below:

Only the silent ones does not make through the listener, the only thing that prints out in the console is this:

On Android everything works perfectly.

Thanks for the update @thiagommohallem
You may check the plugin example and see its implementation and compare it with yours to check if any config is missing at your end or not.

@darshankawar I've replaced my app code with the example you sent me. Same results. Data-only messages are not captured by the onMessage listener with my app on the foreground on an iOS device. The only differences that I saw in native config files was that my AppDelegate is in Swift, the example is in Objective-c and that in the info.plist, processing is enabled for the UIBackrgoundModes, tried that as well.
Still got the same warning:
Warning: Application delegate received call to -application:didReceiveRemoteNotification:fetchCompletionHandler: but the completion handler was never called.
It seems to me that the silent-push method is not being handled natively for iOS

Updates: I was able to override the didReceiveRemoteNotification method in my AppDelegate.swift adding this code to invoke onMessage for data-only a.k.a silent push's
override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {

        let controller : FlutterViewController = window?.rootViewController as! FlutterViewController
        let channel = FlutterMethodChannel(name: "plugins.flutter.io/firebase_messaging", binaryMessenger: controller.binaryMessenger);

        let dictionary: NSDictionary = [
                    "messageId": "1697221363163183",
                    "data": [
                        "type":  "update-customer-wallet"
                    ],
                ]
        channel.invokeMethod("Messaging#onMessage", arguments: dictionary)
    }

Doing that, my push was received by the onMessage method as shown below:

I think the firebase_messaging plugin is failing to call the channel method, or the didReceiveRemoteNotification implementation is not being called on the plugin side at all.

Thanks for the update @thiagommohallem
Re: didReceiveRemoteNotification, check this issue with underlying comments for reference and see if they help in your case or not.

@darshankawar I was able to make my own implementation for the didReceiveRemoteNotification method to handle data-only messages in iOS. I've tried the example code and got the same errors results, I'd be great if you or anyone in the team could try it to see if this data-only foreground in iOS is a bug in my project/device or in the plugin.
I've put breakpoints everywhere during the 'investigation' part of this bug. The firebase messaging plugin here was not picking up anything from silent push's in foreground. But was working properly for notifications with alerts.

@thiagommohallem
this works for ios data messaging (silent), the important thing is an option with content available
payload = {
'data': {
"click_action": "FLUTTER_NOTIFICATION_CLICK",
"sound": "default",
"priority": "high",
"myData" : "myData"
},
fcm.sendToDevice(tokens, payload, {'content_available': true})

@thiagommohallem this works for ios data messaging (silent), the important thing is an option with content available
payload = { 'data': { "click_action": "FLUTTER_NOTIFICATION_CLICK", "sound": "default", "priority": "high", "myData" : "myData" }, fcm.sendToDevice(tokens, payload, {'content_available': true})

Hi @yostrokon
Everything is ok, We are sending notification using api post method. I can add click_action, sound, priority in data map but where to add content_available as true?
Is mydata key also needed?

@msarkrish
i'm using firebase function for sending push notification, and there is a third parameter for options, content_available true will trigger onMessage listener on IOS when notification missing in payload,
mydata is an example key for your data to send with the data message,

Ok @yostrokon . But still, we are facing that warning. listener is not getting called.

Updates: I was able to override the didReceiveRemoteNotification method in my AppDelegate.swift adding this code to invoke onMessage for data-only a.k.a silent push's
override func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {

        let controller : FlutterViewController = window?.rootViewController as! FlutterViewController
        let channel = FlutterMethodChannel(name: "plugins.flutter.io/firebase_messaging", binaryMessenger: controller.binaryMessenger);

        let dictionary: NSDictionary = [
                    "messageId": "1697221363163183",
                    "data": [
                        "type":  "update-customer-wallet"
                    ],
                ]
        channel.invokeMethod("Messaging#onMessage", arguments: dictionary)
    }

Doing that, my push was received by the onMessage method as shown below:
I think the firebase_messaging plugin is failing to call the channel method, or the didReceiveRemoteNotification implementation is not being called on the plugin side at all.

Thank you @thiagommohallem . Now issue got resolved.

I was using the official FCM plugin from NodeJS to send my notifications, tried content available inside aps property and it didn't work. Ended up doing my own implementation overriding the didReceiveRemoteNotification in AppDelegate.swift based on FLTFirebaseMessagingPlugin.m.
It could be something specific to my project @darshankawar. But apparently, @msarkrish was facing the same issue. It is working for me this way, of course it is preferable if Firebase handled it, but due to business demand, I had to make it work first. Don't think I will keep doing tests because it is 'fixed' for me. Any updates on this i will post here. Thanks for the help

Thanks for the updates. Based on above comment / solution, I'll close this as resolved. If we get more traction on such case, will consider reopening it. If you disagree, write in comments and I'll reopen it.


Issue/update last data

Pull Request
Description
add in last data updated
Fixes #20
How Has This Been Tested?
normal tests

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Codecov Report

Merging #21 (d5cfb4e) into main (9219f51) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   93.93%   94.11%   +0.17%
==========================================
  Files           4        4
  Lines         165      170       +5
==========================================
+ Hits          155      160       +5
  Misses         10       10

Impacted Files
Coverage Δ

pvconsumer/app.py
90.69% <100.00%> (+0.57%)
:arrow_up:

pvconsumer/pv_systems.py
97.36% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Implement changes to make plugin work with Pipelines

This PR builds on #486
There were a few bugs with that PR, but it doesn't seem like anyone is working on it now. The additions in this PR add support for Pipelines, and fix some of the issues in the other PR, such as proper Github status updates.
The second commit simply changes the default template for the jenkins build description and removes the HTML. HTML doesn't render in the build description, so I'm not sure why it's included in the default template.
Note on Tests: I'm not sure why tests fail with a NullPointerException. If you drop the Jenkins version below 1.6, all tests pass. Putting the Jenkins version above 1.6 causes the way JSON is deserialized (in the tests) to fail. Before tests are run, we attempt to set up a Trigger object using the line:
GhprbTrigger trigger = spy(req.bindJSON(GhprbTrigger.class, json));
But the bindJSON call in Stapler throws an error, and refuses to move past this.
So -- For what it's worth, I've done a bunch of testing locally with this plugin, and it works, but I can't get the tests to pass, so YMMV. If someone can take a look at the way tests are set up and recommend a solution, I'd be more than willing to implement it.

Thanks for taking this another step forward, @ButkiewiczP
Indeed, whenever I've looked at this kind of upgrade myself, I end up hitting the nullpointer exceptions in the bindJSON call. Haven't gotten to a solution yet; I wonder if the trigger object never gets created. But thank you for codifying this; hopefully we can figure out what's up with the error and get this enhancement into the plugin.

@hughsaunders Huge thanks for spotting that. What an awful typo to have in the code base 😑 .
PR has been updated to include the code to fix all the broken tests. Hopefully this is enough to get this merged in 😄

@ButkiewiczP Thanks for your work on this. I'm running with a locally compiled version of this plugin but have a problem where github pull request builder is not saved when saving a job. I add the trigger to a job, configure it, click save, reload the config page for that job and the trigger config is gone :/
logs:
Mar 22, 2017 2:29:18 PM WARNING hudson.model.Descriptor verifyNewInstance
Father of org.jenkinsci.plugins.ghprb.GhprbTrigger@1c089694 and its getDescriptor() points to two different instances. Probably malplaced @Extension. See http://hudson.361315.n4.nabble.com/Help-Hint-needed-Post-build-action-doesn-t-stay-activated-td2308833.html
Mar 22, 2017 2:29:18 PM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger stop
Stopping the ghprb trigger for project scratchpipeline
Mar 22, 2017 2:29:18 PM INFO org.jenkinsci.plugins.ghprb.GhprbTrigger start
Starting the ghprb trigger for the scratchpipeline job; newInstance is true

@hughsaunders Thanks for picking up on that. Turned out to be a misplaced @Extension,  not exactly sure how that wound up in there. I tested locally before and after pushing up the latest commit, and have solved the issue.

Thanks @ButkiewiczP for the quick response, I'll try again with the latest version.

@ButkiewiczP works for me, thanks! :shipit:

@hughsaunders Glad to hear it
@benpatterson Is there anything more I can or should do to move this along? Would really like to get this into the Jenkins repo.

@ButkiewiczP I'll take a closer look in the coming days. Psyched you found
the typo. Surely that's been there a long time.
On Mar 22, 2017 1:48 PM, "Patrick Butkiewicz"<EMAIL_ADDRESS>wrote:

@hughsaunders https://github.com/hughsaunders Glad to hear it
@benpatterson https://github.com/benpatterson Is there anything more I
can or should do to move this along? Would really like to get this into the
Jenkins repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/ghprb-plugin/pull/497#issuecomment-288482698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB6WxnHJ6MS5qy-11MPHIa-Jj49lO2jZks5roV72gaJpZM4MkKoo
.

@benpatterson I think my latest commit should address all the issues you mentioned above. Let me know if you have other suggestions.

@ButkiewiczP sorry, maybe a silly question but will the branc variable (sha1) and the refspec configuration remain the same?
Those configurations were added at the 'Source Code Management' job section but that section is not present in pipeline projects, or is there something I'm missing?

Hi - Also checking in here. I'm looking at this on a local environment and am now encountering the crumb issue described here. There is a fix for another plugin that can be found here.
Error message for any future googling is WARNING: No valid crumb was included in request for /jenkins/ghprbhook/. Returning 403.
I have not ruled out errors in my set-up, but since a change appears to have been introduced in Jenkins 2, I suspect a change is needed. If I can get to this, I'll let you know...if OTOH you have the time, feel free to take a look....

Re: the csrf protection, there's a better reference implementation here. I'm obviously looking into it but also don't have a lot of cycles the next couple of weeks so thought I'd call it out in a slow-motion #livetweet

@benpatterson Can you elaborate on the crumb issue you're seeing? When do you see the error? Are you able to trigger and build pipeline jobs after pushing pull requests at all? Is there any easy way to replicate this?
I only ask because I haven't seen this issue in my local set up.

@ButkiewiczP If it helps, I have a docker instance running jenkins 2.7.3 (admittedly old). I manually configured a webhook on a test repo I use for this purpose, and I'm using ngrok to capture the webhooks and point them at my instance. This had not been a problem on my docker image before this change, but again it's quite possible I have made a mistake in the setup somewhere. So I say with perhaps 75% certainty that this will be an issue. 😰

@benpatterson  @ButkiewiczP I had a crumb related error when I forgot /ghprbhook/ from the hook url. Reproduced just now:
Webhook URL: http://1fbaea60.ngrok.io/
Response:

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
<title>Error 403 No valid crumb was included in the request</title>

HTTP ERROR 403

Problem accessing /. Reason:

    No valid crumb was included in the request

Powered by Jetty://

Webhook URL: http://1fbaea60.ngrok.io/ghprbhook/
Response: Empty/200

@hughsaunders Thanks for pointing that out.

The checkbox to automatically manage the webhook works for me and hasn't given me any crumb errors. @benpatterson Can you double check your hook URL is correct? Or try to automatic hook management? If you still get the error then I'll start digging into a fix.

Folks indeed as I was worried about, looks like the webhook was user error 😞
Thanks for working through the various details. We may leave a couple of things for later but I'm planning on merging this soon.

As noted, I simplified the existing PR a bit and removed the changes to the template.
Very excited how this was a community-driven enhancement. Thanks everyone who commented, coded, and patiently made this work. I'll release ASAP.

Released in v 1.36.0. It'll take ~24 hours to be available on the cloudbees infrastructure.


CLI returns 0 even when failures

Only failures should return 1, warnings should still produce 0

warnings
failures
errors
exit code

no
no
no
0

yes
no
no
1

*
yes
no
2

*
*
yes
3

@tombaeyens returning 1 in case of warnings seems to introduce another issue - when soda-core is used in a pipeline and it returns 1 in case of warnings - this will stop tie pipeline etc. What are your thoughts on this?


Correct examination of IHtmlHelper.Label() return value

#5317
worked only because TagBuilder cannot be empty and HtmlString overrides ToString()
TagBuilder.ToString() (now the type's FullName) is also never empty

:up::date: @Eilon rebased and did the code duplication.

f222fa4


Multi-Cluster environment

Multi-Cluster support is blocked by JX
https://jenkins-x.io/v3/about/maturity-matrix/

https://github.com/liqotech/liqo is it possible solution?

@golak we should focus on JX solution, see: https://jenkins-x.io/v3/admin/guides/multi-cluster/


This doesn't work

Even using the Office Click-to-Run configuration tool, this always installs the wrong version of Visio.  I can't activate it.  It's pathetic that Microsoft can't resolve this issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e6c0641-503d-7959-2afb-839821cc792f
Version Independent ID: 046c52d9-4fbe-4fe7-0778-5c1d4138f69e
Content: Use the Office Deployment Tool to install volume licensed versions of Project 2016 and Visio 2016
Content Source: DeployOffice/use-the-office-deployment-tool-to-install-volume-licensed-editions-of-visio-2016.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

@mguyett -- What version of Visio does it install?

Same here, using the VisioProXVolume product ID and when I go to activate using a VL key, it tells me the key is for volume licensed edition which is not installed.

@kylethompsonpt The code hasn't changed, the "configuration.xml" is the generic name for the XML file you need to create. You can use one of the included XML files (that you listed above), as a starting point, or create your own, using additional instructions found in the "Overview of the Office Deployment Tool".

@timmmay Same here, using the VisioProXVolume product ID and when I go to activate using a VL key, it tells me the key is for volume licensed edition which is not installed.

Did you use the C2R-P key from the licensing site? If so, were you ever able to resolve the issue?

Is there an answer to above? I just had the same situation with Visio. The keys worked fine a month ago and now I get activation failed.

@rconlee1 The keys they provide in the article are generic keys, that would probably only give you the equivalent of a Trial Period. Those keys would not be for permanent use. If you’ve purchased Visio, you should be using your C2R-P keys which would be on the Microsoft Volume Licensing site.

Just for the record, the procedure worked just fine for me, and the correct version of Visio Pro 2016 installed, as expected. I am using my purchased keys (labeled C2R-P in the licensing site), and they activated just fine, after install. So I don’t anticipate any activation issues in the future. But I’ll definitely keep you all posted, if I have any issue.

I noticed after a restart it worked fine. If you are activating using kms then be sure kms is diwcoverable or host cache enabled . Do a restart and check .
null

Thank you williestylez!  I hadn't even noticed the C2R-P keys.  I've been looking for this answer for awhile.  I don't know why Microsoft has not made it clear in their documents!  I'm up and running because of you!

I had a lot of problems with installing Project 2016 with these instructions. Finally, I got it working on Windows 10 1903 64 bit running FROM ADMINISTRATIVE COMMAND PROMPT

... the following command where setup.exe latest version ODT and configuration file were: .\setup.exe /configure .\configurationPr2016.xml
The configurationPr2016.xml is the following:

The license code for the volume license does not work. I have Office 365 license from my university, and Project volume license from national academy of science, who is not interested in getting the keys. I got Project working this way for more than a year now.

XML does not pass, so figure out substituting _ for triangular brackets
Configuration
Add OfficeClientEdition="64" Channel="Monthly"
Product ID="ProjectProXVolume" PIDKEY="WGT24-HCNMF-FQ7XH-6M8K7-DRTW9"
Language ID="en-us" /
/Product
/Add
/Configuration

Hi, I got similar issue. When I tried that way, I am stucked at "setup.exe/ download visio.xml". The dialogue box said error, CODE 30029-1007 (0). I do have plenty of storage and working internet access. Please share the Office folder file downloaded from the "setup.exe/ download visio.xml" step or kindly help me to explain. Thank you. :)

...When I tried that way, I am stucked at "setup.exe/ download visio.xml". The dialogue box said error, CODE 30029-1007 (0). I do have plenty of storage and working internet access.

@avwplace the issue you're facing is that you're either:

using the wrong command (your syntax above is incorrect, but may just be a typo); it should be:
setup.exe /download visio.xml
You're using the wrong XML filename (make sure your XML file is actually called visio.xml)
You're XML file is not located in the same directory that you're working from, or that your setup.exe file is in
Or your, XML file is configured incorrectly. Provide the text in the XML file (obscure your key so that you don't expose it to the internet)

The last theory is more of a long shot because I think one of the other three issues is what's really plaguing you.

For issue #4, you can use the Office Customization Tool at config.office.com. This allows you to point+click a configuration file and you can be 100% certain that the syntax is correct.

Closing due to the age of the initial issue report and it seems to have been resolved. Feel free to open new issue if problem persists.


Add post and comment translation feature

This PR adds a "See translation" button beneath posts and comments which are not in the user's language.
Currently a draft since I might want to do some refactoring.

Hmm, the loading indicator is kinda hard to see in white themes. Might have to add an option to customise its colour so we can change it here.

Looks great!


Remove Headers

I have installed traefik 1.7 in K8s. How can i remove and add headers to ingresess?

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


Git Repository Reporting (Prometheus)

Add exporters for git repository reporting via Prometheus.
Requirements

[ ] per repository
[ ] issues
[ ] Merge requests
[ ] time spent
[ ] milestones
[ ] per organization (Github)/group (Gitlab)

added 2m of time spent

marked this issue as blocked by #156

marked this issue as related to #115


log toolkit may do not take effect in some case

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?

Question
when i start an app (called test_app) in IDE,i configure the logback file by following this instruction,but i found it didn't take effect.
i debug this question step by step in agent jar. i found the class org.apache.skywalking.apm.toolkit.log.logback.v1.x.TraceIdPatternLogbackLayout didn't been transformed.this seems to be strange.what is it happened?
then  i put an break point in this place,

and see the debug stack trace in ide ,Suddenly I understand.

from this picture, we can see that the TraceIdPatternLogbackLayout class was loaded in premain method,and invoke by boot method.but at that time,the byte buddy instrument didn't work.because the code is
...
 ServiceManager.INSTANCE.boot();
...
 new AgentBuilder.Default()...
.installOn(instrumentation);

that is the class TraceIdPatternLogbackLayout loaded is before instrumentation.
this only happens when application code is loaded by AppClassLoader,because the logback.xml in this classpath.
in other cases,this code work fine cause their classloader is redefined like spring boot or tomcat etc. in this cases,the class TraceIdPatternLogbackLayout will be loaded only by app code invoke logger ,when agent started by AppClassLoader,it can not see the logback.xml config file thus he dont know the class TraceIdPatternLogbackLayout,
Solution
To resolve this problem ,the simplest way is to change the order of
...
 ServiceManager.INSTANCE.boot();
...
 new AgentBuilder.Default()...
.installOn(instrumentation);

to
...
 new AgentBuilder.Default()...
.installOn(instrumentation);
...
 ServiceManager.INSTANCE.boot();

that is first invoke instrumentation then boot all service in case of the boot service contains some method need to be enhanced.
but i dont know if there has some other problem will be caused?
so please check
i test  logback only , but follow this train of thought,log4j and log4j2 may have the same issue

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Ha, @candyleer I think your analysis is right. This is caused by dependencies of dependencies. Changing the boot sequence looks good for me. All existed boot services are only about timer or listener register.

For log4j2, I think it is another thing need to check. If none of our dependencies used it, it is good for now.
Please follow your thoughts, and send a pull request to fix this. And I will ask @ascrutae to run the automatic test in SkyWalking infra, to recheck it in real applications.


my balance

why i didn't fund my balance ?

I’m not make any exchange or withdraw why i see that i’m exchanged my balance and withdraw it?

@loudiyi1 if it wasn't you who made sell orders and withdrew the funds, then it means your account was compromised. We can't do anything in this case. Last login was made from <IP_ADDRESS> IP, if it's not yours, I suggest you to change the password.


add HTTP3 datagram support

Implement HTTP/3 datagrams described in RFC9297 Section 2.1.
solves #3522.
Example for client side API:
req, _ := http.NewRequest("GET-DATAGRAM", "https://<IP_ADDRESS>:443/datagram", nil)
datagrammer, respChan, err := client.Transport.(*http3.RoundTripper).RoundTripWithDatagrams(req)
data, _ := datagrammer.ReceiveMessage(context.Background())
datagrammer.SendMessage(data)

Example for server side API:
server.Handler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
    datagrammer := w.(http3.Datagrammer)

    data, _ := datagrammer.ReceiveMessage(context.Background())
    datagrammer.SendMessage(data)
})

How can I initialize the newStreamAssociatedDatagrammer context? It crashes on my code:
`panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x688754]
goroutine 23 [running]:
github.com/quic-go/quic-go/http3.(*streamAssociatedDatagrammer).ReceiveMessage(0xc000214100, {0x7bfac0, 0x9e6ea0})
/home/uweber/quic-go/http3/datagram.go:150 +0x154`
Explicitly setting it works however:
`+++ b/http3/datagram.go
@@ -38,6 +38,7 @@ func newDatagrammerMap(conn quic.Connection, logger utils.Logger) *datagrammerMa
func (m *datagrammerMap) newStreamAssociatedDatagrammer(conn quic.Connection, str quic.Stream, settingsHandler PeerSettingsHandler) *streamAssociatedDatagrammer {
d := &streamAssociatedDatagrammer{

          ctx:             context.Background(),`

Sorry, have been busy these days and may get back on this next week. Actually I' m feeling a bit tentative on whether this should wait until #4160 be finished since RFC9297 requires a peer to only handle datagrams after sending and receiving the settings frame.  Maybe a separate PR is needed to allow the client and server to block on receiving the settings frame, which can also make the changes in this PR smaller and easier to be reviewed.


ReferenceError: Buffer is not defined in init.ts

In 0.7.1 (3d-compat), I'm seeing this error:
Uncaught (in promise) ReferenceError: Buffer is not defined
While awaiting Rapier.init().
Buffer seems undefined in this commit, but not sure if there's some global definition somewhere: https://github.com/viridia/rapier.js/blob/40ef3dc75208f1936ac3b41520e99d8dec20d805/rapier-compat/src3d/init.ts#L10
Seems like it's gone in master: https://github.com/viridia/rapier.js/blob/master/rapier-compat/src3d/init.ts
So maybe it just needs a new version pushed? Or maybe I'm importing incorrectly - neither of the following work for me:
import * as Rapier from "@dimforge/rapier3d-compat";

async function main() {
    await Rapier.init();
}

import Rapier from "@dimforge/rapier3d-compat";

async function main() {
    await Rapier.init();
}

The first one worked in 0.7.0. Thanks for any help!

So maybe it just needs a new version pushed?

You are right, we need to make a new release for rapier-compat. I’ll do that in a minute.

The 0.7.2 release of rapier-compat is done. Does it solve your issue @wwwtyro?

Works like a charm now, thanks for that!


Diagnostic jump does not close preview

Describe the bug
When having multiple diagnostics on the same line, jumping through diagnostic will not make the floating window disappear.
See the following example.
https://github.com/nvimdev/lspsaga.nvim/assets/72013831/9fe14692-59ca-47ae-8a07-efb202dd3fb5
This does not seem to be effective anymore when one or more other lines have diagnostics too.
Steps to reproduce

Open a file with multiple diagnostics on the same line (ensure having an lsp for the filetype), see lua example below
Try jumping between diagnostics using lspsaga
See floating windows are not closing automatically

Fu

print("yes")

Expected behavior
Floating windows should close, even if the cursor is not moving while jumping between diags.
Neovim version (nvim -v)
0.9.1
lspsaga commit
e552e9d
Terminal name/version
terminator 1.91

Thanks, I'm shocked by your responsiveness

@glepnir It seems that this fix introduced a new bug while jumping through diagnostics.
When jumping from one diagnostic to another, you will need to do it twice to trigger the UI.
See the following example
https://github.com/nvimdev/lspsaga.nvim/assets/72013831/60521aa7-99a2-4a97-82af-5a5baad2075c

fixed


Code storage by hash v2

PR description
This is a redo of https://github.com/hyperledger/besu/pull/5889 including a fix for detection of existing storage.

Storing code by hash instead of by address. This is needed so that Besu can serve snapsync as we need to be able to retrieve the code by hash.
After syncing with this change it's not possible to downgrade to an older version of Besu. If we think this is needed I could add a subcommand to do the conversion.
Testing

Checkpoint sync on Sepolia, Goerli and Mainnet
Confirmed the same code bytes were stored for both column families by running a comparison tool on the stored code bytes https://github.com/hyperledger/besu/pull/6019/files#diff-9c4d660b9f0b067bbaf230c40ff79f2a53fef78e88c0c5e368b43e3891d0f68bR227
Compatibility testing to ensure that existing databases continue to work
Compared storage of code size on mainnet. Before: 9 GiB After: 2GiB. Column family to store code counts i.e. CODE_HASH_COUNT is using 38 MiB.
Compared FCU and new payload times on mainnet with and without code changes showing no significant difference in times

Hi @jframe, since this PR changes the format, I think we need to introduce a new version in the database metadata.
When I introduced the variables storage, I didn't introduce a new version, an that was an error, so I am now doing that, and with the occasion, refactoring the way we store database metadata to be more easy to read, so I suggest that we synchronize on this and we can introduce a new version and so leverage the existing protection mechanism.

Hi @jframe, since this PR changes the format, I think we need to introduce a new version in the database metadata. When I introduced the variables storage, I didn't introduce a new version, an that was an error, so I am now doing that, and with the occasion, refactoring the way we store database metadata to be more easy to read, so I suggest that we synchronize on this and we can introduce a new version and so leverage the existing protection mechanism.

I think a good idea. Will sync up with you on this. Don't think it needs to go in this PR though as this is experimental and doesn't seem right to bake in database versions as part of an experimental feature. But before it's production ready would like to have database versioning for code storage column family in Bonsai to prevent db compatibility issues.

Confirmed on test nodes that restart issue no longer occurs

is it working fine with a call to resyncWorldstate API RPC ? should be fine just to be sure

Tested with resyncWorldState API RPC and it's working fine


Add AI Features for Advanced Error Handling and Performance in Ray Cross-Language Tests

This update to the script enhances the cross-language functionality in Ray with AI-driven features. These improvements include advanced error handling, performance optimizations, and AI-driven insights for debugging and analysis.
Key Updates:

Integration of AI-driven Features:

Error Prediction and Handling: Introduced AI-based mechanisms to predict and handle potential errors in cross-language calls. This includes improved detection of invalid arguments and erroneous function calls.

Performance Optimization: Leveraged AI to optimize performance by predicting potential bottlenecks in cross-language function executions and making adjustments accordingly.

Enhanced Error Handling:

Improved error handling for invalid arguments and non-existent functions, utilizing AI to provide more descriptive and actionable error messages.

Added AI-based insights to help identify common sources of errors and suggest potential fixes.

Extended Cross-Language Functionality:

Data Handling: Added new tests for handling large arrays, complex mappings, and nested data structures to ensure robustness in cross-language interactions.

Additional Functionality Testing: Included tests for various data types and complex data structures, such as tuples and dictionaries, to ensure comprehensive coverage of cross-language capabilities.

Code Refactoring:

Renamed variables to avoid shadowing built-in names and improve code readability and maintainability.
Updated comments and documentation to reflect the new features and enhancements.

Test Cases Updated:

test_cross_language_cpp: Enhanced with additional AI-driven checks and validations. Tests for handling large data structures and various data types have been added.
test_cross_language_cpp_actor: Updated to include AI-driven error handling and performance optimizations for actor-based cross-language interactions.

These updates aim to improve the robustness and performance of cross-language functionalities in Ray while providing enhanced error handling and insights through AI-driven enhancements.

Why are these changes needed?

Related issue number

Checks

[ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
[ ] I've run scripts/format.sh to lint the changes in this PR.
[ ] I've included any doc changes needed for https://docs.ray.io/en/master/.

[ ] I've added any new APIs to the API Reference. For example, if I added a
method in Tune, I've added it in doc/source/tune/api/ under the
corresponding .rst file.

[ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy

[ ] Unit tests
[ ] Release tests
[ ] This PR is not tested :(

This pull request introduces significant enhancements to the Ray cross-language functionality testing script, incorporating advanced AI-driven features. Below are the key updates:

Enhanced Error Detection and Handling:

Integrated AI-based techniques for predicting and managing errors in cross-language function calls. This improves the robustness of error handling, especially for edge cases and invalid arguments.

Performance Optimizations:

Applied AI algorithms to optimize the performance of cross-language function interactions. This includes more efficient handling of large data structures and complex types.

Improved Assertions and Validation:

Updated assertions to utilize AI models for validating expected outcomes. This ensures that the results from cross-language function calls are more accurately verified.

Refactored Variable Names:

Renamed shadowing variables to avoid conflicts with Python built-ins, improving code readability and maintainability.

Expanded Test Coverage:

Added additional test cases to cover a broader range of scenarios, including large data inputs and various complex data structures.

These improvements are aimed at enhancing the reliability and efficiency of the Ray cross-language functionality testing, leveraging AI to provide deeper insights and optimizations.


Disable automatically adjust brightness

In System Preferences > Displays there's a checkbox that is checked by default to "Automatically Adjust Brightness".
I've looked for ways to turn this off programmatically but haven't found anything. I thought I'd suggest it here in hopes that someone else knows and it's of general interest to the community.

@jfelchner looks like that link 404s now.
I did find this:
http://stackoverflow.com/questions/12239496/disable-ambient-light-sensor-screen-dimming-programmatically-on-os-x
and tried: defaults write com.apple.BezelServices dAuto -boolean false
But it didn't seem to work for me, has anyone else had any luck?

@philipwalton can we go ahead and close this out please?
Changes in High Sierra are making it a requirement that the majority of these settings changes are going to have to be done with AppleScript rather than using defaults commands.

I have not found a nice way to do this so here's an ActionScript I wrote for toggling the setting.
ActionScript must open the System Preferences and click around and crap, but that's the way they want to do stuff I guess...
tell application "System Preferences"
  activate
  set current pane to pane "com.apple.preference.displays"
end tell

tell application "System Events"
  tell window "Built-in Retina Display" of application process "System Preferences"
    -- The tab group isn't loaded right away when we've just opened the "Displays" preferences
    repeat until exists tab group 1
    end repeat
    tell tab group 1
      click radio button "Display"
      set cb to checkbox "Automatically adjust brightness" of group 1
      click cb
      if value of cb is 0 then
        display notification "Disabled automatically adjust brightness"
      else
        display notification "Enabled automatically adjust brightness"
      end if
    end tell
  end tell
end tell

tell application "System Preferences" to quit


[WIP]Add ColoredStairstepPlot: StairstepPlot with different color for each category (Y-value)

Example usage:
      val colors = generateHueColorPalette(4)
      ColoredStairstepPlot(
        sleepCycles.map { Point(it.startCycle, it.depth) }, // Deserialized JSON.
        LineStyle(
          brush = SolidColor(colors[0]),
          strokeWidth = 2.dp
        ),
        {
        // Arbitrarily select color for each category (Y-value)
        when(it) {
          SleepDepth.awake ->
            LineStyle(
              brush = SolidColor(colors[0]),
              strokeWidth = 4.dp
            )

          SleepDepth.REM ->
            LineStyle(
              brush = SolidColor(colors[1]),
              strokeWidth = 4.dp
            )

          SleepDepth.light ->
            LineStyle(
              brush = SolidColor(colors[2]),
              strokeWidth = 4.dp
            )

          SleepDepth.deep ->
            LineStyle(
              brush = SolidColor(colors[3]),
              strokeWidth = 4.dp
            )
        }
        },

Generated plot image:

Thanks for contributing. I think if lineStyle.strokeWidth is wider than levelLineStyle.strokeWidth, you will see it in the "background" of the level part of the line. In your example, the level lines were 4.dp so they completely covered the 2.dp lineStyle. One solution for that is to not draw the path from drawConnectorLine at line 328, and instead draw the vertical part of the line together with the horizontal parts in drawLevelLines.

Thank you for the review. That's what on my TODO list already ;).
BTW, There's couple of issues that'll need your help:

Is the function name correct, I'm not a native speaker so there may be a more proper name for this.
Or should this be merged into StairstepPlot, adding drawLevelLines parameter?
This would involve changing GeneralLinePlot's signature to accept drawConnectorLine as DrawScope's receiver. (instead of Path's receiver)

The function name could also be StairstepPlot and then function overloading would select the right one depending on if the caller provided the levelLineStyle parameter or not.
Because ColoredStairStepPlot requires starting a new line segment for each segment of the plot, I think the GeneralLinePlot implementation should be kept separate. This is primarily because, if someone is using a line stroke that is dashed, when each line segment is started the phase will restart at 0. StairstepPlot plots the entire line created by GeneralLinePlot as a single path so the dash phase will be continuous over the whole path. That does mean some of the GeneralLinePlot code will be duplicated but it's not much and trying to factor out the common parts may not be worth the trade-off in increased complexity. But if you have ideas on how to do it elegantly please make a suggestion.
In ColoredStairStepPlot, a continuous path of the line should still be generated (mainLinePath) for use as part of the area boundary for when the areaStyle is not null.

@gsteckman
I utilized a visitor pattern to avoid duplicating code, (between drawConnectorLine and drawing each line segment),
besides, I've added a flag that allow overlayDrawing, since if levelLineStyle is bigger than lineStyle, enabling it would give a nice antialiasing effect (like in PR description), otherwise, aliasing at each vertex can be easily spotted.

The following is with overlayDrawing enabled but lineStyle is bigger (you can notice the red background over magenta ones)

@KentVu Have you tried using StrokeCap.Square when drawing the level lines? I think that might eliminate the artifact. One problem with using overlayDrawing=true is that if you use a dash pattern for the level line, and it doesn't match with the dash and phase of the lineStyle, then you will see it "underneath" the level line. So ideally we can figure out a way to draw the level lines and the vertical lines without an "artifact".
The detek check is failing. Please run the detekt gradle task on the code and correct any failures it finds (it will flag deprecations, you don't need to correct those they are only warnings).
Thanks!

@gsteckman
As per your suggestion, I've removed the overlayDrawing parameter and tried out the StrokeCap, the 'artifact' has eliminated nicely.
I've also made StrokeCap an optional parameter to leave users control what they prefer.
Beside, there's another issue that the vertical lines overlap the level lines, which I've addressed.
Here is for StrokeCap.Square, but the vertical lines overlapping level lines:

Here is for StrokeCap.Round (which I personally prefer), with overlapping issue fixed:

Have you tested this with a filled area? I think the logic for creating mainLinePath has changed, and now the area's bounding path will not match the line drawn at the code below the //drawLevelLines comment. For example in the first iteration of mainLinePath the moveTo and lineTo will both be to the scaled points[0] and so no line is drawn.
To avoid the partial overlapping you observed, two passes can be made: The first pass to draw the vertical lines, and the second pass to draw the horizontal lines. Then there shouldn't be the need for the correction factors to compensate for the stroke width, since the horizontal lines will then always draw on top of the vertical lines.

I've tested with a filled area, seems like it was properly drawn:

I'll try to implements the two passes drawing as per your suggestion.

@gsteckman
I've implemented 2 pass drawing as per your suggestion, everything seems working fine as my observation.
Please kindly review ;)


Unit test - initialize firebase problem

Writing tests for js files of the original version of base codes, I discover that initalizeFirebase() function declared in most of js files will cause error "Firebase App named '[DEFAULT]' already exists" when running unit test. To solve this problem, I use "firebase.apps.length === 0" to check whether Firebase is initalized or not. In this case, although the error seem to be fixed, I am concerned by whether this will affect the functionality of the website. Anyone have any opinions to this issue or can think of an alternative?

I think it is fine if you skip testing initalizeFirebase() function because 70-80% coverage is enough.

The problem is that most js files given in the base code contains initalizeFirebase() function in their global scope. In other words, initalizeFirebase() function must be run when testing other function within the js files. It can't be simply skipped.

Oh then we have to check whether the addition code will affect the website or not first.


Sleep timer

Summary
This issue adds timer logic the basic sleep/wake functionality implemented here.
The timers should be enforced at the platform level by tier. In this iteration, users will not have the option extend/disable the timers.
These should be the tier defaults:

Starter Tier - 30 minutes
Pro Tier - 3 hours
Enterprise Tier - 6 hrs

Users can wake a sleeping cluster with uffizzi cluster wake. And uffizzi cluster sleep should force a cluster to sleep immediately no matter what the timer is (edited)

Notes from @waveywaves :

We can start setting a default timer on the clusters
Install the operator on production and set the default timer to a week in the beginning
Then then user can manually wake the cluster if it is sleeping, it would be better to install the operator and just start using the timer in production, considering kubecon is around the corner as well

We need to setup a webhook that would receive the information from the operator when a cluster is put to sleep.

Follow up ticket:
https://github.com/UffizziCloud/uffizzi_platform/issues/1256


⚠ ClamAV has degraded performance

In 12e1462, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 396826e.


Gallery API request count tracking by endpoint as metric

Addresses https://github.com/NuGet/Engineering/issues/4133 (without user agent consideration).
Added support for client-side metric pre-aggregation as I see no reason to have each individual request tracked as an instance of a metric: AI metrics are not subject for sampling, and we are getting millions of API requests per hour. Non-preaggregated metric would waste resources.
There seems to be two options for submitting sample for pre-aggregation:

By calling Metric.TrackValue that has no overload that accepts any kind of list of dimension values.
By obtaining a MetricSeries object by calling Metric.TryGetDataSeries (which does have an overload accepting an array of dimension values) and then call its TrackValue method.

None of those accepts a dictionary of dimensions names and dimension values (I'd guess, order matters in this case and dictionary enumeration does not produce stable sequence of keys). I chose to go with the first approach to provide dictionary-like interface (and eliminate the possibility of mismatching dimension names with values) to add dimensions and not to waste time/memory converting the list of values to an array.
With pre-aggregation, AI SDK sends pre-aggregated metrics once per minute (default aggregation interval).
Added telemetry calls to all public methods of ODataV1FeedController and ODataV2FeedController.

Looking ...


Kubeflow multinode cluster installation #896

I described in this use case how to setup in on-prem multi-node Kubernetes cluster Dynamic Provisioning using NFS volumes in order to allow KubeFlow installation and bind existing Persistent Volume Claims without pain.
I added also a Limitations section for this solution and a Resources section to get information about Kubernetes resources used.

This change is

I'll review this.
Preview at https://deploy-preview-897--competent-brattain-de2d6d.netlify.com/docs/use-cases/kubeflow-on-multinode-cluster/
I think sarahmaddox@'s comment on the other PR still applies:

Please would you add a link to the issue that this PR is addressing. (Also, is it related to issue #230 ?) If there isn't a fitting issue yet, please create one and I'll add it to the doc sprint Kanban board.

/assign @alecglassford

Thanks @alecglassford and @mastrogiovanni!
Answering your questions (quoted here for ease of reference):

I think this document might fit better under "Getting Started" rather than under "Use Cases." It could slot under "Kubeflow on Kubernetes"in the left-nav and have a title like "Kubeflow on Kubernetes (multi-node cluster)" — this doc basically tells readers to follow the "Kubeflow on Kubernetes" guide but also do some additional steps to make it work for a multi-node cluster. What do you think?

I agree - if this doc does follow directly on from the "Kubeflow on Kubernetes" guide then we should put it in the same section as that page. But I'm wondering: Has the Kubeflow on Kubernetes guide diverged since you wrote this PR, @mastrogiovanni? It no longer has the section about stuck pods.

Do you have a style recommendation for the term "on-prem"? The Google Developers style guide says on-premises; not on prem or on premise but there seem to be various usages on kubeflow.org. The terminology in this doc should be unified.

Thanks for pointing this one out! Personally, I don't like the recommendation in the Google Developers style guide that we should always use "on-premises" with the hyphen, no matter what the part of speech. It seems a clunky and bothersome solution that breaks English syntactical conventions. Still, I can see why the style guiders have chosen to retain the hyphen in all situations - it becomes very tricky to decide when to use the hyphen and when not. So, putting all that together, I think we should include the hyphen but use mostly the abbreviated form and explain the usage at the top of the page.
How about this:

Page title (as Alec suggested): Kubeflow On-prem in a Multi-node Kubernetes Cluster
First usage on the page:  This guide describes how to set up Kubeflow on premises (on-prem) in ...
All other occurrences on the page: on-prem

Hi @sarahmaddox. I noticed that now "Kubeflow on Kubernetes" was updated to include the possibility to install KF in a cluster with or without Istio installed. This modification doesn't solve the storage problem that occurs in multi-node cluster, in fact, the troubleshooting section is already there and it must not be deleted.
About on-prem, I like your solution:

Page title (as Alec suggested): Kubeflow On-prem in a Multi-node Kubernetes Cluster
First usage on the page: This guide describes how to set up Kubeflow on premises (on-prem) in ...
All other occurrences on the page: on-prem

If for you is ok, I'll put it in this way.

Fixes https://github.com/kubeflow/website/issues/814

/ok-to-test

Hi @sarahmaddox. I noticed that now "Kubeflow on Kubernetes" was updated to include the possibility to install KF in a cluster with or without Istio installed. This modification doesn't solve the storage problem that occurs in multi-node cluster, in fact, the troubleshooting section is already there and it must not be deleted.

Thanks @mastrogiovanni. Let's keep your guide (Multi-node Kubernetes Cluster) in the Use Cases section for now.  We may move it later, but the getting-started section is undergoing a lot of flux right now. We should add a link from the Kubeflow on Kubernetes page to your new page - you can do that in a separate PR if you like. The link should be in the Next steps section at the bottom of the page.

@alecglassford if you're happy with the content, we can merge this PR. Exciting!

/lgtm
(I think @sarahmaddox needs to approve and merge)

Thanks @mastrogiovanni and @alecglassford!
/lgtm
/approve

Hi @mastrogiovanni, is this doc (setting up Kubeflow in on-premise Kubernetes cluster) available? I can't seem to find it on the official doc. Thanks for working on this!

 I'm not able anymore to find it.
@sarahmaddox https://github.com/sarahmaddox is the page already used or
it was deprecated?
The introduction of Istio and authentication as well as the support for
different platforms made obsolete that page?
Il giorno lun 7 ott 2019 alle ore 17:56 David Dai<EMAIL_ADDRESS>ha scritto:

Hi @mastrogiovanni https://github.com/mastrogiovanni, is this doc
(setting up Kubeflow in on-premise Kubernetes cluster) available? I can't
seem to find it on the official doc. Thanks for working on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/pull/897?email_source=notifications&email_token=AAMCME5YWFTP57MALNMTCLTQNNL2DA5CNFSM4IBE2662YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQ32QA#issuecomment-539082048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMCME4S4QR3MDSUJGBK3LDQNNL2DANCNFSM4IBE266Q
.

Hallo Both :) the doc has moved to this location:
https://www.kubeflow.org/docs/other-guides/kubeflow-on-multinode-cluster/
On Wed, 9 Oct 2019, 21:16 Michele Mastrogiovanni<EMAIL_ADDRESS>wrote:

You are right! I'm not able anymore to find it.
@sarahmaddox https://github.com/sarahmaddox is the page already used or
it was deprecated?
The introduction of Istio and authentication as well as the support for
different platforms made obsolete that page?
Il giorno lun 7 ott 2019 alle ore 17:56 David Dai <
<EMAIL_ADDRESS>ha scritto:

Hi @mastrogiovanni https://github.com/mastrogiovanni, is this doc
(setting up Kubeflow in on-premise Kubernetes cluster) available? I can't
seem to find it on the official doc. Thanks for working on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/kubeflow/website/pull/897?email_source=notifications&email_token=AAMCME5YWFTP57MALNMTCLTQNNL2DA5CNFSM4IBE2662YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQ32QA#issuecomment-539082048
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAMCME4S4QR3MDSUJGBK3LDQNNL2DANCNFSM4IBE266Q
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/pull/897?email_source=notifications&email_token=ABO2TC66UMDEC5PHHXYKQ6LQNWVQZA5CNFSM4IBE2662YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAXMUCA#issuecomment-539937288,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABO2TCYAOHKASK2AZAL3753QNWVQZANCNFSM4IBE266Q
.


WIP OSSM-6056 Initial changes to add k8s go client to e2e test

Jira: https://issues.redhat.com/browse/OSSM-6056
Work in Progress

@luksa I'll submit tomorrow new changes, I'm in a battle to get working the delete check with the go-client

@luksa added some changes from the review, I left some TODO to finish tomorrow morning + test on ocp cluster

Some comments inline, but I also have a general comment:
Wouldn't it be better to keep Eventually and WithArguments in the same line. When WithArguments is on the second line, the text doesn't read as fluently (at least not for me).
For example, I'd change this:
Eventually(cl.Get).
	WithArguments(ctx, key("istiod", controlPlaneNamespace), deployment).
	Should(ReturnNotFoundError(), "Istiod should not exist anymore")

to this:
Eventually(cl.Get).WithArguments(ctx, key("istiod", controlPlaneNamespace), deployment).
	Should(ReturnNotFoundError(), "Istiod should not exist anymore")

By keeping them both on the same line, it's closer to how you usually call functions (functionName(arguments...)).

Ok, I'll made this change

/test lint


Add infrastructure for timeouts

Add infrastructure for timeouts
:recycle: Current situation & Problem
Async operations sometimes require to make sure that there is a maximum time an operations runs. To have a standardized way of dealing with timeouts, this PR introduces a new, generalized TimeoutError (similarly simple like Swift's CancellationError) to communicate that a timeout occurred. Additional, the PR adds a withTimeout method that makes it easier to race timeouts against an async operation.
:gear: Release Notes

Add TimeoutError
Add withTimeout(of:perform:) method

:books: Documentation
Code examples have been added to illustrate how to use those new types.
:white_check_mark: Testing
Unit testing was added to verify functionality.
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Thank you @Supereg 🚀


add two new modules to admin dashboard

Looky likey:

Note that there is a subsequent ticket to move the graphs below off the admin dashboard onto their own page.

@axemonkey Would you mind updating the copy on the Report page to match the copy in the screenshot? This will be content reviewed properly in the future, but want improve it in the short term.

Done. :+1: :ok_hand: :metal:

Done. :+1: :ok_hand: :metal:

Looks great, please merge


Support fargatePlatformVersion property at EcsClientConfig

What does this PR do?
This PR introduces fargatePlatformVersion[1]  property for EcsClientConfig. This property is expected to be provided by SystemConfig.

[1] https://docs.aws.amazon.com/AmazonECS/latest/developerguide/platform_versions.html#platform-version-migration

Thanks!


Edge Clipboard, alert div to class

I ran into a pasting issue for Microsoft Edge which probably affects other versions of Internet Explorer. Because of a security setting, IE may block access to the clipboard http://www.thewindowsclub.com/harden-clipboard-data-theft-ie. There is certainly a cleaner way to write it but the code.
Also for reference: https://msdn.microsoft.com/en-us/library/ms535220(v=vs.85).aspx
I fixed and corrected the both || paste version but not the button and tested it in Edge and Google Chrome.  Both browsers behaved as expected.
There was also an issue when there are two (or more) summernote divs with separate ids. After a paste event, the cleanerAlert div is added to all summernote divs.  When the timeout event happens, only the first cleanerAlert div is removed.  By switching to class, the timer removes it from both.  It would be great to have you rewrite so that the cleanerAlert div is applied and subsequently removed for the summernote div with the paste event.
Thanks for reviewing and I apologize for writing this initially in a comment.  Thanks for teaching.

No worries, thanks for contributing, it's greatly appreciated.
Targetting seperate instances of Summernote is something I haven't worked out how to do, and is something I'd like to work out, especially also for the save-button plugin, as it is now that indicates content change on all instances, and removes the button change class for all instances, but only saves the content for the instance the content is saved in. Something for another day at this time, it's 4:50am and I need to go sleep.


Gaps in context submenus causes menu to disappear before mouse is over it

Similar to the issue for the user profile (https://github.com/Comfy-Themes/Discord/issues/96), the gap between context menu and submenus is too wide and the mouse sometimes does not "catch" the submenu before it disappears.
https://github.com/Comfy-Themes/Discord/assets/55717063/700ab088-dcf5-4d7e-8f20-e6c8e9e58b19

Will fix that in the next push


Ensure ApplicationProtocolNegotiationHandler does handle handshake fa…

…ilures completely
Motivation:
When ApplicationProtocolNegotiationHandler is in the pipeline we should expect that its handshakeFailure(...) method will be able to completly handle the handshake error. At the moment this is not the case as it only handled SslHandshakeCompletionEvent but not the exceptionCaught(...) that is also triggered in this case
Modifications:

Call handshakeFailure(...) in exceptionCaught and so fix double notification.
Add testcases

Result:
Fixes https://github.com/netty/netty/issues/10342

/cc @hyperxpro

All good! Thanks for the fix. :-D

@netty-bot test this please


Scroll is not getting initiated if we use ng-repeat to populate inner content

Scroll is not getting initiated if we use ng-repeat to populate inner content
Sample Link: http://plnkr.co/edit/CoqEZF9BlwDQR5rqZ3T6?p=preview

I was able to make it working by calling self.update() method in $timeout. Is there any other workaround for this issue ?
// call update method after some delay (after dom manipulation)
$timeout(function(){
self.update();
});

You could try using the autoUpdate option. It requires MutationObserver or a polyfill. Otherwise you can continue to use the update method.


Missing syntax highlighting in Polyglot Notebook extension

Syntax highlighting in polyglot notebooks are broken after the November update.
This is how a snippet looks in the default theme

This is how a snippet looks with Rosé Pine

Jupyter notebooks using python seems to be working fine. This is just affecting polyglot notebooks with C#, F# and Powershell.

Honestly I'm not sure how to reproduce this as I have no experience with using notebooks but if notebooks are a shareable file and you can provide an example file of this happening I'll take a look :)

See here for an example covering some of the usual syntaxes
https://gist.github.com/akselkvitberg/d81d727ed948458c5ea959b81deaaf7d

I have same problem.
Polyglot Notebooks Version: v1.0.4102020
Version: 1.75.0 (user setup)
Commit: e2816fe719a4026ffa1ee0189dc89bdfdbafb164
Date: 2023-02-01T15:23:45.584Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

I found the solution. The theme does not enable semantic highlighting by default, so it needs to be enabled manually in the settings.
"editor.semanticHighlighting.enabled": true

I regard this as solved, but perhaps semantic highlighting should be enabled by the theme?

Good find! I wouldn’t mind enabling it in the theme but some values may need tweaked. Happy to look at this soon but if anyone notices weird or poor highlighting with semantic enabled please post screenshots here :)


Sheet intercepting touch events from RecyclerView.

I'm using a RecyclerView inside the bottom sheet in several places in my app. I've noticed that sometimes the sheet intercepts the touch event to scroll the RecyclerView back to the top and moves the sheet instead. If I start the scroll in the other direction first it works correctly.

That's strange. I wrote a pretty extensive new view component using
recyclerview recently and didn't see anything like this. Could you give a
snippet of code that reproduces this, or is it just random?
Other potential areas of trouble are if your view is wrap_content or has
text input with adjustSize set on your activity.
On Wed, Sep 30, 2015 at 8:01 AM Evan Tatarka<EMAIL_ADDRESS>wrote:

I'm using a RecyclerView inside the bottom sheet in several places in my
app. I've noticed that sometimes the sheet intercepts the touch event to
scroll the RecyclerView back to the top and moves the sheet instead. If I
start the scroll in the other direction first it works correctly.
—
Reply to this email directly or view it on GitHub
https://github.com/Flipboard/bottomsheet/issues/71.

Going to close this for now, feel free revisit if you're able to nail down the issue. For an example of a recyclerview in the sheet, check out the comments view for any item in the flipboard app

I am facing this too. Anything I should keep my eyes open for that could cause this issue?


Toolbar min-width + add npm release command

Description

Define CSS min-width to toolbar .inf CSS class to prevent toolbar items overlapping when columns are all hidden with columns visibility manager extension
Automate git commands in npm's release command to commit and create tag for new package version (#584)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Development tool configuration change

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes do not lower current test coverage
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

lets try it 👍


Event PAge

Event page links are wrong, use the below links.
Video 1: https://www.youtube.com/watch?v=AtoVNe1mVUA&t=792s
Video 2: https://www.youtube.com/watch?v=Rm2lT9j6VxQ&t=522s
Video 3: https://www.youtube.com/watch?v=rNF66FCLmYM

can we use this transition?
https://recodehive.github.io/awesome-github-profiles/pages/help.html

add this as well.

Sir I want to work


Add CoFounder.ai the first AI Co-Founder for your startup

@seawatts  thanks for the add. Services section list platforms and open source projects to build langchain services. CoFounder would go in projects if open source or proprietary otherwise.

Excellent, thanks for the update! I just updated it to proprietary.


Unhandled exception when testing node/health during healthCheck

Trying to run the healthCheck but apparently REST was not running fine yet and I got this exception:
2021-03-01T20:55:21.627Z info     Testing http://localhost:3000/node/health
(node:3362394) UnhandledPromiseRejectionWarning: #
(node:3362394) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:3362394) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
2021-03-01T20:55:21.643Z warn     Rest http://localhost:3000/node/health is NOT up and running YET: {"statusCode":503,"statusMessage":"Service Unavailable","body":"{"status":{"apiNode":"down","db":"up"}}"}

The health check should fail because Rest wasn't running. Is this happening?
The UnhandledPromiseRejectionWarning warning should be there.

The rest was not running ok, but imo the unhandled exception should be handled much cleaner. Especially if it is deprecated.


dates not needed

minor cleanup here. Since this is under version control, the most recent update dates are redundant. Removing that information from the style guide doc.

LGTM @katyhuff


[2.x] Update SqlBaseParser

Description

Update SqlBaseParser.g4 file to solve build issue.
The file was not valid and caused build issue in network disconnected environment.
This change will align the file to main branch.

Related Issues
n/a
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] New functionality has javadoc added.
[ ] New functionality has a user manual doc added.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I found that we probably should track Spark 3.3.2 and Flint 0.4 instead of main branch? cc: @vamsi-amazon

I found that we probably should track Spark 3.3.2 and Flint 0.4 instead of main branch of both? cc: @vamsi-amazon

+1


Client has no withdraw and loan function

fixed on commit: https://github.com/pitzzahh/automated-teller-machine-console/commit/0c10aa336c8f6f5afe0d51fe1c45911d4b4ce853


When calling TwaLauncher.launch() a blank screen is shown if could not connect to web app

I may be missing something, but when i cannot connect to the web app for some reason the default behaviour appears to just show a blank screen. Is this expected behaviour?
i notice there's some documentation on offline scenarios here:
https://developer.chrome.com/docs/android/trusted-web-activity/offline-first/#handle-offline-scenarios
but i'm not sure how to incorporate this with the TwaLauncher. is there anyway to set a LauncherActivity or perhaps a concept like "offline strategy" ?

You web application should have a Service Worker that is installed on the first run and will manage offline access after that. Check this article on how to implement this on your PWA.
There is an edge case where the user may be offline when the application is run for the first time, and the PWA didn't have a chance to install the Service Worker. Instead of a blank page, the user would see the Chrome dinosaur page. The article you linked explains how to overcome that particular issue, and the solution described is to create your own LauncherActivity by extending the existing one and slightly modifying its behaviour.


config: get_env_config() should have config_path as optional

Rather than needing to specify the same config throughout our program, let the parameter config_path be optional, and be default assigned. From what I've viewed from the source code, the static method uses the get_config() method, which uses a fixed path if not specified from the end user.

The version of our code being used

1.0.0

@Rizxcviii Thanks for opening.. I'm in agreement. Fix started.