[HOLD for payment 2023-09-27] [$500] Money in wallet badge is not center vertically

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to settings
check the amount in badge

Expected Result:
money should be in center vertically
Actual Result:
money in badge is not center vertically
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/b80a85ca-14cb-4d97-878a-dfd747c83629
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692597419368009
View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ea8fed02b430b214
Upwork Job ID:<PHONE_NUMBER>595770368
Last Price Increase: 2023-09-06
Automatic offers:

ZhenjaHorbach | Contributor | 26600759
gadhiyamanan | Reporter | 26600761

It is vertically aligned. We need to conside $ symbol too.

I think the problem is in lineHeight
But it only works on Safari for me
Chrome renders correctly lineHeight
For example, how Safari reacts to changes lineHeight

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e2ef043508da9f2c

Proposal
Please re-state the problem that we are trying to solve in this issue.
The problem is that Money in wallet badge is not center, bottom is bigger than top.
What is the root cause of that problem?
The root cause of the problem is  :
The line-height of the badgeText is smaller (16px) than the height of the badge (20px).
What changes do you think we should make in order to solve the problem?
We can set the line-height of the badgeText and the height of the badge to be the same, which will center it.

What alternative solutions did you explore? (Optional)
None

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

@ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
@anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

@ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
@anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

Hello )
Yes, I checked today morning, in fact this is the only correct acceptable value (fontSize value) )
And it turns out that in this case the available values are:
-styles without lineHeight;
-lineHeight which is equal to fontSize.
In other cases, bugs appear in Safari.
But maybe you're right, styles without lineHeight can lead to potential unpredictability in the future )

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

@ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
@anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

I just tested it on Safari and it does have display issues. It seems to be a font-related problem. When I disabled the ExpensifyNeue-Regular font in devtools, it displayed correctly. One possible solution could be adjusting the fonts, as mentioned in this answer:
https://stackoverflow.com/a/15860322

@robertKozik - bump on proposal review - thx!

Hmmm thanks for your findings @anyongjitiger, if it's indeed the problem related with the font I think it's not a bug then. I'm heading OOO for today, but tomorrow morning I'll double check the alignment of the $ sign, I think it can be vertically aligned

I've rechecked it, and it appears to be linked to the font ExpenifyNeue-regular, but that's not the sole factor. Even with the same font, there's a discrepancy between Safari and Chrome. Considering this, I'm inclined to agree with @ZhenjaHorbach's proposal for consistency across both browsers.
Selected Proposal: proposal
Contributor: @ZhenjaHorbach
🎀 👀 🎀 C+ reviewed

Hmm, after looking at this again - I'm not sure this is the correct root cause.
From the original proposal, it basically mentions that Chrome should already work as expected.
Then from this update - https://github.com/Expensify/App/pull/27137/files#r1324317248, if we're adjusting the line height for all of web then wouldn't it be incorrect now?
cc @robertKozik could you let me know what you think about this?

There was no drawback to address whole web, not only the safari case, that's why I initially passed it in review. But after checking it out again, I agree that we should reduce scope to be safari-specific

It seemed there were no drawback to addressing the whole web rather than just the Safari case, which is why I initially passed it in review. However, upon reevaluation, I agree that we should reduce the scope to focus specifically on Safari.

Does not look like the issue mentioned here was fixed. https://github.com/Expensify/App/issues/27654#issuecomment-1726650591

cc @kavimuru Do you have more info about the reproducing this bug?

"Hi! It seems that the remaining discrepancy is likely due to the font, as mentioned here. With the PR, we've addressed how Safari handles vertical centering. Previously, Safari behaved differently than Chrome, but now they're aligned."
before safari:

after safari:

Payments

[ ] Reporting bonus: @gadhiyamanan ($50 via Upwork)
[ ] Contributor: @ZhenjaHorbach ($500 via Upwork)
[ ] C+: @robertKozik ($500 via Upwork)

@robertKozik - can you review this checklist when you have a chance? thanks! https://github.com/Expensify/App/issues/26308#issuecomment-1727194081

@maddylewis this is eligible for $250 because it was reported before 30 aug

Issue is created before the announcement https://expensify.slack.com/archives/C01GTK53T8Q/p1693424078129649

@robertKozik - bump on this one ty! https://github.com/Expensify/App/issues/26308#issuecomment-1743040256

@robertKozik - bump https://github.com/Expensify/App/issues/26308#issuecomment-1727194081

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: that was inconsistency between browsers, no particular PR introduced it
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. We don't need regression test for visual bugs
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I think we don't need regression test for this one as it's purely visual bug which don't interfere with any user flow

everyone is paid and a regression test isn't required since this is purely visual. closing!


TTNN eltwise_atanh - fail when input tensor has ROW_MAJOR layout (GS and WH)

ttnn.atanh fails in cases when layout of an input tensor is ROW_MAJOR. During sweep test, for every combination of parameters with layout = ROW_MAJOR, an error occurs in this format:

Always | FATAL    | For valid non-interleaved buffers page size 2048 must equal buffer size 63168. For interleaved-buffers page size should be divisible by buffer size

Test hangs after several FATAL errors.
To Reproduce
Steps to reproduce the behavior:

Checkout branch amalbasaTT/opsets4and5-unit-tests
Run command:pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_eltwise_atanh.py

Expected behavior
Test case should fail with the error:

RuntimeError: TT_FATAL @ ../ttnn/cpp/ttnn/operations/eltwise/binary/device/binary_device_operation.cpp:194: (input_tensor_a.get_layout() == Layout::TILE && input_tensor_b.get_layout() == Layout::TILE)
info:
Inputs to eltwise binary must be tilized

Getting Additional info for the operation under test and its behavior:
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweep test:
pytest tests/ttnn/python_api_testing/sweep_tests/run_sweep_test.py --input-path tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_working/grayskull/ttnn_eltwise_atanh_test.yaml --input-method cli --cli-input results_ttnn_eltwise_atanh

To do this, you should:

Follow the Getting Started page to setup the repo, environment variables and python-env
Activate source build/python_env/bin/activate
Checkout amalbasaTT/opsets4and5-unit-tests
Run sweeps by using pytest tests/ttnn/python_api_testing/sweep_tests/run_sweep_test.py --input-path tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_working/grayskull/ttnn_eltwise_atanh_test.yaml --input-method cli --cli-input results_ttnn_eltwise_atanh
After the run is completed all test sweeps results should be available inside specified output directory (in this case ./results_ttnn_eltwise_atanh). There you will find .csv which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching unique data_seed field.

Tests fail with appropriate error

Updated test results, got expected results.


WIP: work on some data races around ObjectLister

This is work that I started on fixing data races around object listing before realizing that #13 and #14 are probably higher priorities. This branch probably conflicts with #14, so I'll have to fix that up before continuing here.
Please read the individual commit messages for more details.
/cc @ccstolley, @carlosmn

I just pushed up a rebased version of this branch. Each commit passes all of the tests. I think it is ready for review.
The commits are written to be readable one by one.

This still passes the tests even in combination with #16, and I only added a comment since the last review, so I'm going to merge this through.


ESET.ESETSecurity version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

Make sure to test your manifest in a virtual machine.


Release pipeline

part of #864
The build pipeline described in #2 should also be able to release and publish artifacts such as docker images, helm charts, documentation, etc.  The Rook project has a good example of this.

Rook release readme
Rook Jenkinsfile release step

Here are the steps I did manually for the v0.1 release. First tag the release:
make tag VERSION=v0.1.0
git checkout release-0.1

Now publish:
build/run make -j4  publish BRANCH_NAME=release-0.1 AWS_ACCESS_KEY_ID="..." AWS_SECRET_ACCESS_KEY="..." GIT_API_TOKEN="..."

Then promote:
Build/run make -j4  promote BRANCH_NAME=release-0.1 VERSION=v0.1.0 CHANNEL=alpha AWS_ACCESS_KEY_ID="..." AWS_SECRET_ACCESS_KEY="..."

We need to get Jenkins doing this. For some reason it did NOT pickup the tag and resulting in the wrong release. I think its a  jenkins config to sync tags that we are missing.

@Defilan we'd like to get a Crossplane v0.2 release out this week.  Please sync with me about the automation gaps and what it will take, thanks!

Note that it may be OK to have some manual steps for v0.2, but having an understanding for a smooth release is important.

The tag and promote Jenkinsfiles were removed from the upbound/build repo with this commit: https://github.com/upbound/build/commit/ab8c075886f671ec257918414053b1e805a73605.  There's not much context about why they were removed, perhaps because they are not easily generalized and therefore are a better fit for individual repos that are consuming the build repo as a submodule?

We have decided that properly implementing and testing the automated Jenkinsfile and release pipelines has too much risk for the short timeline left for v0.2. @Defilan will work on this properly and at high quality for v0.3.

@Defilan will you be able to work on this release pipeline for v0.3?

We are committing to adding this release pipelines for v0.4 as part of #864.  This should cover not only the main Crossplane repo, but also the stacks that we are actively developing and maintaining, e.g. the cloud provider stacks.

I have opened a series of PRs to add the same tag and promote pipelines to the stacks repos that have already merged into Crossplane master

https://github.com/crossplaneio/stack-gcp/pull/67
https://github.com/crossplaneio/stack-aws/pull/53
https://github.com/crossplaneio/stack-azure/pull/47
https://github.com/crossplaneio/stack-rook/pull/12

Release pipelines for tagging and promoting have been added to main crossplane repo, stack-aws, stack-gcp, stack-azure, and stack-rook.  I believe this issue is now completed.


Inconsistent type check

https://github.com/microsoft/presidio/blob/d8541e973349ceefccec926a01992dd554de6123/presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry.py#L128
    def _get_nlp_recognizer(
        nlp_engine: NlpEngine,
    ) -> Union[Type[SpacyRecognizer], Type[StanzaRecognizer]]:
        """Return the recognizer leveraging the selected NLP Engine."""

        if not nlp_engine or type(nlp_engine) is SpacyNlpEngine:
            return SpacyRecognizer
        if isinstance(nlp_engine, StanzaNlpEngine):
            return StanzaRecognizer
        if isinstance(nlp_engine, TransformersNlpEngine):
            return TransformersRecognizer
        else:
            logger.warning(
                "nlp engine should be either SpacyNlpEngine,"
                "StanzaNlpEngine or TransformersNlpEngine"
            )
            # Returning default
            return SpacyRecognizer

Currently, it uses type(nlp_engine) is SpacyNlpEngine instead of isinstance(nlp_engine, SpacyNlpEngine). It will lead to a warning even if the engine is an instance from an inherited class:
from presidio_analyzer.nlp_engine import SpacyNlpEngine

class LoadedSpacyNlpEngine(SpacyNlpEngine):
    def __init__(self, loaded_spacy_model):
        self.nlp = {"en": loaded_spacy_model}

if __name__ == "__main__":

    import spacy
    nlp = spacy.load("en_core_web_lg")
    temp_engine = LoadedSpacyNlpEngine(nlp)
    print(type(temp_engine) is SpacyNlpEngine)
    print(isinstance(temp_engine, SpacyNlpEngine))

Hi @ChenghaoMou, the other NLP Engines (Stanza, Transformers) inherit from SpacyNlpEngine, so replacing with isinstance would not work. If you have any suggestions which keeps the existing flow in tact + supports inherited engines, please let us know. In general, you don't have to use the NlpEngineProvider, and can instantiate your custom NlpEngine yourself, before passing it to the AnalyzerEngine.

I see. Thanks for the explanation. Could you elaborate on why changing the flow won't work here?
if isinstance(nlp_engine, StanzaNlpEngine):
    return StanzaRecognizer
if isinstance(nlp_engine, TransformersNlpEngine):
    return TransformersRecognizer
if not nlp_engine or isinstance(nlp_engine, SpacyNlpEngine):
    return SpacyRecognizer

That should work! Will you update your PR?

BTW more changes are coming to the NLP engine in this PR #1159

Thank you for the pointer! It looks like the config system should eliminate my reason for the PR, at least for my use case. I have updated the PR in case it is still wanted, and I am happy to close it otherwise.

I'm interested to understand more about your use case, if you're willing to share.

The short version is that I want to use en_core_web_lg, en_core_web_trf, or a custom-trained spacy model like the LoadedSpacyNlpEngine above without warning, but it looks like the config or NlpEngineProvider should be enough.


added IBAN generation feature for Austria

needed IBAN generation feature for Austrian customers so implemented it

Please, be so kind and add some tests to verify that the new feature works well. Thank you!

Will do tomorrow.
Greetings
On Thu, Aug 27, 2015 at 3:29 PM, Jan Schädlich<EMAIL_ADDRESS>wrote:

Please, be so kind and add some tests to verify that the new feature works
well. Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/jschaedl/Iban/pull/19#issuecomment-135428478.

Hi. The test is failing due to a missing "t" in assertIban(...). Can you please fix it and do the pull request again. Thank you.

Thanks i-ivanov!


go

I don't think it was meant to be a PR, right?

Sorry!  I accidentally mixed up the repositories
Отправлено из myMail для iOS
пятница, 9 декабря 2022 г. в 11:35 +0100 от @.***  @.***>:

I don't think it was meant to be a PR, right?
—
Reply to this email directly,  view it on GitHub , or  unsubscribe .
You are receiving this because you authored the thread. Message ID:  <marcveens/telegram-bot-nodejs-azure-function-starter/pull/3/c1344134543 @ github . com>


BUG - New V3 doesn't support service parameter inside up command.

Hey, with new major version my gitlab CI starts crashing from yesterday.. I was able to partly migrate to v3, but i am stuck with railway up command. In v2 there was property to specify which service i wanna turn on  --service. In new v3 there is not such a option and i can't find anywhere how to specify that.
Is there any alternative for this option or you just forgot to implement this key feature in new version ?

--environment and --service flags seem to be broken. I had to pin my version to 2.1.0 to get my CD pipelines working again ):

How did you specify version ? I tried -    curl -fsSL https://raw.githubusercontent.com/railwayapp/cli/v2.1.0/install.sh | sh but this script inside is trying to install still latest version - 3xx.... :(

I'm using it in GitHub Actions via npm install<EMAIL_ADDRESS>

The service flag is now available in the latest version. The environment flag will be added soon (PR is open)


If forwarded port is not known, try to find it with x-forwarded-proto

The issue
My front load balancer (Google LB) doesn't set the X-Forwarded-Port header and my reverse proxy is not using TLS, that result with a X-Forwarded-Port set to 80 in my backend application.
My solution
I think that if X-Forwarded-Proto is set and the X-Forwarded-Port isn't, we should try to guess the port with X-Forwarded-Proto header before reverse proxy connection type (TLS).

@Juliens @emilevauge : this PR seems to be important for usage on Google Cloud Platform

@ldez  Do you think it is possible to merge this PR ?


Cannot delete a project through the dashboard

Cannot delete a project through the dashboard. Most likely because the ID is not set in the request

Fixed - Will go into next release @Munklinde96


Classification detail view

Using only EFO ontology and disease id as input.
Starting from @peatroot prototype

Related to #457

It requires some iteration but we have a first version running. Next iterations will go in #666


received full heartbeat request addressed to node with different revision after rolling restart with ephemeral storage

What happened?
Running kubectl rollout restart sts redpanda -n redpanda after deploying with ephemeral storage results in an unhealthy cluster, with the destroyed broker remaining in the cluster and the new broker getting assigned a new node ID (increasing the broker count by 1).
What did you expect to happen?
Expected the cluster to restart and result in a healthy cluster.
How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

Create kind cluster:
kind create cluster --name jlp-cluster --config ~/projects/redpanda/kind-config.yaml

Create Redpanda config with ephemeral storage:
cat << EOF > values.yaml
tls:
  enabled: false
storage:
  persistentVolume:
    enabled: false
EOF

Deploy Redpanda 24.1.8 via helm 5.8.12:
helm install redpanda redpanda --repo https://charts.redpanda.com -n redpanda --wait --create-namespace --set version=5.8.12 --set image.tag=v24.1.8 -f values.yaml

Once the cluster is healthy, do a rolling restart:
kubectl rollout restart sts redpanda -n redpanda

Continuously run the following command until redpanda-2 is available:
kubectl logs pod/redpanda-2 -n redpanda -f

Eventually you will see print constantly:
WARN  2024-07-19 18:46:48,917 [shard 0:raft] raft - [group_id:0, {redpanda/controller/0}] consensus.cc:3922 - received full heartbeat request addressed to node with different revision: {id: 2, revision: 0}, current node: {id: 3, revision: 0}, source: {id: 1, revision: 0}

I've ran through this multiple times. Sometimes the rolling restart doesn't continue past redpanda-2. Other times it continues as expected. Most times the cluster ends in the following state, where redpanda-2 is assigned a new node ID and redpanda-1 never returns to the cluster:
> kubectl exec -it redpanda-2 -n redpanda -c redpanda -- rpk cluster info
CLUSTER
=======
redpanda.a0eeca84-6e4c-44cc-b32c-3238b20a8679

BROKERS
=======
ID    HOST                                             PORT
0*    redpanda-0.redpanda.redpanda.svc.cluster.local.  9093
3     redpanda-2.redpanda.redpanda.svc.cluster.local.  9093

TOPICS
======
NAME      PARTITIONS  REPLICAS
_schemas  1           3

> kubectl exec -it redpanda-2 -n redpanda -c redpanda -- rpk cluster health
CLUSTER HEALTH OVERVIEW
=======================
Healthy:                          false
Unhealthy reasons:                [leaderless_partitions nodes_down under_replicated_partitions]
Controller ID:                    0
All nodes:                        [0 1 2 3]
Nodes down:                       [1]
Leaderless partitions (1):        [kafka/_schemas/0]
Under-replicated partitions (1):  [redpanda/controller/0]

Anything else we need to know?
We have this doc for this config, but there is no mention of an issue with being able to restart. It seems that running in this state is never a good idea with this issue, since anytime a broker leaves the cluster the cluster will become unhealthy. The brokers should be decommissioned when using ephemeral storage. We have this doc explaining how to perform a rolling restart, but no mention of any issues when using ephemeral storage.
It would be great if we could disable any changes when users run kubectl rollout restart sts redpanda -n redpanda when they also have storage.persistentVolume.enabled: false.
Which are the affected charts?
Redpanda
Chart Version(s)

This happens with all versions I've tested, from 5.8.12 to 5.7.24.

Cloud provider
none
JIRA Link: K8S-299

Some excellent discussion going on in our internal slack.
The tl;dr is that we (I) don't believe there are use cases outside of simple testing / verification of chart / redpanda behaviors. If anyone has other uses cases, please chime in!
Until then, we'll update the docs and add some red tape to both NOTES.txt and the values.yaml file indicating that the errors seen here are expected behavior.

[ ] @chrisseto file a docs issue


No annotation processing settings found.

[PermissionsManager Plugin] Missing settings: No annotation processing settings found. Use 'android gradle plugin version >= 2.2' or 'android-apt'

I can't generate the dependency in the app.gradle

Which version of android gradle plugin do you use?


fatal error: unexpected signal during runtime execution

This appears to be an issue inside the pg_query_go package:
https://github.com/lfittl/pg_query_go/issues/12
I've added a mutex around the normalize function to see if it helps and am currently stress testing it to see if it fixes it.

This hasn't reoccured.  Closing issue.


Missing 'data mode' docs for data/elements sections? Data size section?

Hi,
The docs for data sections seems to be out dated - there's a whole 'data mode' scheme for 'active' and 'passive' data, see:
https://webassembly.github.io/spec/core/binary/modules.html#data-section
The elements section also has a similar setup I believe.
Also missing is docs for section type '12' which I think just contains size of data section.

Yes, that's correct. I'm not currently working on adding new features to this document.

Okay, no problem, a bit of a shame as they're by far the most readable webassembly docs around IMO, but I understand it's a massive job!


Route Multicast without IGMP join

Hello toglobit
I want to know if there is any way to ask Neighbors to send the multicast groups that are in the pimd.conf file without send the IGMP to join request to the pimd from another interface?
Regards

I'm not really sure I understand what you mean, what multicast groups in pimd.conf are you referring to? Also, by Neighbors, do you mean PIM Neighbors?
Could you provide an example, a drawing of your set up, or your pimd.conf?
As a background for further discussion I'm providing a quick recap of how it all works:

Multicast is always supposed to be forwarded to the IGMP querier on the LAN
On Layer-3 an IPv4 multicast router usually runs a dynamic  protocol like DVMRP (mrouted) or PIM
On Layer-2 the router is usually configured to also be IGMP querier.  This is what tells all end devices and switches (that may employ IGMP snooping) that all multicast should be forwarded in the direction of the IGMP query
When these LAN connected end devices hear the IGMP Query, periodically sent by the router, they can respond with an IGMP Join (called IGMP membership report in IGMP v3) to signal they want a particular group, or set of multicast groups, to be forwarded to them

Hence, multicast on the LAN is always forwarded to the IGMP querier (the PIM router), this is usually handled transparently by IGMP-aware switches (called IGMP snooping).  This makes the IGMP querier (the PIM router) a sort of focal point for multicast on the LAN.
The root cause in your case may be that multicast isn't properly forwarded to your PIM router.  For that there is unfortunately no cure from the perspective of pimd. The LAN must be properly set up to either understand that receiving an IGMP query means "forward multicast in that general direction", or configured to forward all multicast towards the router.  In the latter case there is usually a multicast router port setting in the firmware of managed switches on the LAN.

Hello Troglobit, Thanks for your answer
Sorry if my question is not clear at all
the groups that I'm referring is the rp_addres line something like this:
"rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1"
That I want to say is: there is any way to request the multicast data to the PIM neighbor without the igmp query from the LAN?
Maybe this is a confusing question, but this is because I'm working on layer 1 network, I don't know if you know something about this, but this is for market data distribution that it comes in multicast, so I need to distribute this market data via layer 1 without that igmp query from the LAN
this is my pimd.conf

igmp-query-interval  12
igmp-querier-timeout 42
spt-threshold packets 0 interval 100
phyint enp0s31f6 disable
phyint enp1s0d7 disable
phyint enp1s0d6 disable
phyint enp1s0d5 disable
phyint enp1s0d4 disable
phyint enp1s0d3 disable
phyint enp1s0d2 disable
phyint lo disable
phyint enp1s0 enable dr-priority 101 distance 1 metric 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS>  masklen 32 priority 1

Hello Troglobit, Thanks for your answer
Sorry if my question is not clear at all
the groups that I'm referring is the rp_addres line something like this:
"rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1"
That I want to say is: there is any way to request the multicast data to the PIM neighbor without the igmp query from the LAN?
Maybe this is a confusing question, but this is because I'm working on layer 1 network, I don't know if you know something about this, but this is for market data distribution that it comes in multicast, so I need to distribute this market data via layer 1 without that igmp query from the LAN
This is my pimd.conf file
igmp-query-interval  12
igmp-querier-timeout 42
spt-threshold packets 0 interval 100
phyint enp0s31f6 disable
phyint enp1s0d7 disable
phyint enp1s0d6 disable
phyint enp1s0d5 disable
phyint enp1s0d4 disable
phyint enp1s0d3 disable
phyint enp1s0d2 disable
phyint lo disable
phyint enp1s0 enable dr-priority 101 distance 1 metric 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS> masklen 32 priority 1
rp_address <IP_ADDRESS> <IP_ADDRESS>  masklen 32 priority 1
Thanks, Regards.

So, you want to be able to flood all groups received on inbound interfaces of the Rendez-Vous Point to any other interface on the same router, without receiving any IGMP Join/Membership report on those latter interfaces?
That is not how it's supposed to work, and there is no mechanism available in pimd for this.  I'd recommend having an end device connected on those interfaces do an IGMP join instead.

Well, what is your LAN, is it 172.10.10/24? It seems you've disabled that interface.  Try enabling it and run tcpdump on that interface.  If there's a lot of traffic you can tell tcpdump to filter out only igmp traffic.  You can also enable IGMP debug messages in pimd to see if they are registered.  See the pimd -h usage text for help.

No, my LAN is  <IP_ADDRESS>/27 network
I have pimd running with -d and I can see the registry of the groups but there is no passing data

OK. Did you try tcpdump on the interface, do you see any inbound IGMP join messages for the groups you want to forward? And if you do, do you see any inbound multicast on the <IP_ADDRESS>/31  interface?

Yes I can see the IGMP request on the interface but there is nothing of data
[root@localhost test090317]# tcpdump -i enp4s0d1 igmp -vv
tcpdump: listening on enp4s0d1, link-type EN10MB (Ethernet), capture size 262144 bytes
17:37:41.489487 IP (tos 0xc0, ttl 1, id 0, offset 0, flags [DF], proto IGMP (2), length 56, options (RA))
localhost.localdomain > igmp.mcast.net: igmp v3 report, 3 group record(s) [gaddr igmp.mcast.net is_ex { }] [gaddr all-routers.mcast.net is_ex { }] [gaddr pim-routers.mcast.net is_ex { }]
17:37:41.557109 IP (tos 0x0, ttl 1, id 28618, offset 0, flags [none], proto IGMP (2), length 40, options (RA))
<IP_ADDRESS> > igmp.mcast.net: igmp v3 report, 1 group record(s) [gaddr <IP_ADDRESS> is_ex { }]
17:37:45.557109 IP (tos 0x0, ttl 1, id 28619, offset 0, flags [none], proto IGMP (2), length 40, options (RA))

Then you need to check where the multicast data for group <IP_ADDRESS> stops.

Which device generates group <IP_ADDRESS>?
Does it reach the first PIM router?
What is the TTL of the multicast data?  (Must be > 1 to even be considered for routing)
etc.

I've solved the issue, it was the layer 1 switch that it was dropping the multicast, now I can receive the data
Thanks for your help!


Search temporarily not working on fumadocs.vercel.app

To Reproduce
This is not affecting my own deployment but search seems to be not working on the fumadocs.vercel.app website. To reproduce, go to fumadocs.vercel.app & search for anything using the search box.
Current vs. Expected behavior
Expected behavior is to see a list of relevant search results. Currently see no results for any search terms. Here's a video:
https://github.com/user-attachments/assets/83869667-4a32-49ab-97b2-e8cae0be0361
Provide environment information
Running the fumadocs.vercel.app on MacOS 15.1, Arc Browser (v1.66.0).

Which area(s) are affected? (Select all that apply)
Not sure
Additional context
The same problem seems to exist also on Chrome.

Algolia free tier limit exceeded, we will migrate to Orama Cloud soon


Extend 'Client' class with 'create_multiple' and 'bulk_delete' methods

@karolkulesza  Thank you for the contribution.  I've posted a couple comments.

@karolkulesza Thanks for the information.  Could you provide some level of spec coverage to go with this change?

@karolkulesza  Could you rebase this branch? I think it will fix the build issue.  Also, I'd like to see a spec added for this.

@karolkulesza Could you rebase this branch? I think it will fix the build issue.

Fixed my build issues. Seems like the only one left is related with 'On Premise authentication':
  1) DynamicsCRM::Client#authenticate On-Premise authenticates with username and password
     Failure/Error: wsdl = open(organization_endpoint + "?wsdl=wsdl0").read

     SocketError:
       getaddrinfo: Name or service not known
     # ./lib/dynamics_crm/client.rb:345:in `organization_wsdl'

@karolkulesza I'd like to see this work get contributed, but your branch is quite diverged at this point.  Can you rebrase this branch from the latest master so we can see the actual differences?

@karolkulesza Would you be able to re-base your branch? I'd like to get this feature added.


TeamCity CI server fails fetch from gogs via http

Gogs version (or commit ref): <IP_ADDRESS>9
Git version: not relevant
Operating system: Windows 10
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist (usually found in log/gogs.log):

Description
More or less the same problem as #2431, but only over HTTP.

Define "fail".


Solutions page: Logo grid - on keyboard navigation, focus stays twice in each card.

Detailed description
Issue :-

On keyboard navigation, Focus stays twice in each card.
Visual focus is also not there while navigating through images

Additional information

@Praveen-sr I've navigated through the page and wasn't table to reproduce the issue:

Could you please clarify how to reproduce the issue?


Record internal and external audio?

Really like this script! I think I would be able replace SimpleScreenRecorder with blaze if it could record the internal and external audio at the same time.
I managed to get the external (microphone) audio recording working by setting the -i flag in ffmpeg to default, but was not able to get both internal and external working at the same time. Would be able to implement this to blaze?

Sadly I don't think there's an easy way. I also have no microphone so I wouldn't be able to test.


*: solve cloud tikv disk full problem

What problem does this PR solve?
Issue Number：#10537
When the disk is full, no mather one or two or the majority or all, what we expected will be:

TiKV not crash directly.
Support restoring storage through drop table/delete from table, expansion is also allowed.
Provide slightly better reading ability.

What is changed and how it works?

Introduce a two-level threshold defense mechanism
Different flow control algorithms are used under each threshold to provide different business support capabilities and spatial recovery capabilities

Check List
Test
UserDoc
Release note
not available

/run-integration-common-test

/run-test

Rest LGTM. Good job!

/test

/merge


added options tests

Looks like we have a conflict - you may have to pull my PR changes first and then resubmit.

@sujitdmello done :)


Tailwind CSS logo in Readme

Add Tailwind CSS logo in Readme appropriately under Tech Stacks section

Assign this issue to me

ok sure
However, I am waiting for this project to be accepted for GSSOC '23

i would like to work for it under GSSOC'23 @SrijanShovit

Good morning, I have seen the issue and as a beginner in open source I'd appreciate it if this issue can be given to me.

@alokmishra70 Have you attempted the task? If no, I would merge someone else's PR for this issue.

I kindly request your consideration in assigning Issue #2 under GSSOC'23 to me.

Hey @SrijanShovit I've made a pull request for this issue. please merge it. Thanks

Hey @SrijanShovit I've made a pull request for this issue. please merge it. Thanks

I kindly request your consideration in assigning Issue #2 under GSSOC'23 to me.

@Rutujeet Assigning this to u

Hey @SrijanShovit I've made a pull request for this issue. please merge it. Thanks

Hey @iusamahub Kindly wait till the issue is assigned to you next time since it is done on a first come first serve basis.Thanks


Regarding finetuning

Dear Authors,
Thank you so much for providing this amazing work. I could reproduce the results for lung tumor segmentation on the provided preprocessed dataset. However, I want to finetune the lung tumor segmentation model on my data. I preprocessed the data according to the given code. When I try to fine-tune the model using the provided pre-trained weights, the dice score is zero consistently and not improving at all. Can you please help me with this?
Regards
Shweta

Dear Authors,
Thank you so much for providing this amazing work. I could reproduce the results for lung tumor segmentation on the provided preprocessed dataset. However, I want to finetune the lung tumor segmentation model on my data. I preprocessed the data according to the given code. When I try to fine-tune the model using the provided pre-trained weights, the dice score is zero consistently and not improving at all. Can you please help me with this?
Regards Shweta

Hello, I apologize for any inconvenience caused. When running the training_scripts/run_training_acdc.sh script, I encountered a negative train_loss. I am eagerly awaiting your response!


Change my maintainer email [1.6 branch]

friendship ended with putin

Fix the conflicts first, then I can merge


Release Google.Cloud.Dataform.V1Beta1 version 1.0.0-beta06

Changes in this release:
New features

Add IServiceCollection extension methods for client registration where an IServiceProvider is required. (commit 022fab2)

Created release for Google.Cloud.Dataform.V1Beta1-1.0.0-beta06


Custom game configurations for Abiotic Factor

Description
After game update v0.9.3 UE4SS stopped working for Abiotic Factor.
I've dumped MemberVariableLayout.ini and VTableLayout.ini from game's PDB file with UVTD, then edited the FMalloc vtable with help of Martin to match FMalloc vtable in the game which contains FExec virtual functions as well.
Since the FExec is not supported and is hard coded to size of 1, I had to remove one of the FExec functions.
https://github.com/UE4SS-RE/RE-UE4SS/blob/1aa51fbec1aa6c5989a19d484b460eb9b027ab0d/UE4SS/src/UE4SSProgram.cpp#L705

After playing for several hours and multiple sessions the configs seems to be fine.
Of the more than 400 people who have downloaded the version v3.0.1-204-gb47690f bundled with the configs from NexusMods, nobody has reported anything so far.
I'm converting the Draft to a PR.

I have also used these configs for Abiotic Factor and seem to work fine. Cheers for this.
Why is UE4SS submodule updated in this PR?

Why is UE4SS submodule updated in this PR?

Not sure, it was on the branch and somehow sneak into it on wrong revision. Should be fixed now.


useFetch will be http 400 when navigate from different layout page in old browser and ios app(alipay/qq)

Environment

Operating System: Linux
Node Version:     v20.9.0
Nuxt Version:     3.12.2
CLI Version:      3.12.0
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, app, modules, legacy, experimental
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-tphpdd?file=nuxt.config.ts
Describe the bug
When this issue (#24229) was closed, i have try the latest version.
I'm trying to polyfill the old browser(use nuxt-vite-legacy, my old browser is android chrome 56), but found an another bug:

'when navigate to a page which use different layout, useFetch's result will be http 400; but it will be ok when i refresh the page'

And then i test in ios alipay to valid if #24229 fixed, i found http 400 occur again. so, i guess it exsists in ios qq too.
Additional context
https://github.com/nuxt/nuxt/assets/55608642/12eb5cef-5626-4ecd-8b7b-4c3872d2f4cb
my operate just like this.
Logs
No response
### Tasks

In that case, you may need to set responseType: 'json' as one of the options to useFetch. Does that help?

In that case, you may need to set responseType: 'json' as one of the options to useFetch. Does that help?

nop! it dosen't work, still http 400

Is there a way to test this on a computer?

Is there a way to test this on a computer?

I just try chrome56  on windows, it occur too.
You can download this version's chrome form here


fix(footer): divide legal nav to chunks

Related Ticket(s)
Refs #3047.
Description
This change divides legal nav contents to chunks of columns, as our React variant does.
Changelog
Changed

A change divides legal nav contents to chunks of columns.

Good point @kennylam - Probably lodash.chunk()?

Good point @kennylam - Probably lodash.chunk()?

@asudoh Yes exactly. I didn't use chunk in mine because I forgot we recently added lodash. So I just basically did the same with reduce. But now that we have it, that would work great.


chore(can): update timings to match linux

Linux uses significantly different canbus bit timing parameters from the
microcontrollers. This may not be a problem but it also certainly may be

the sync jumps are very different and may lead to very rapid
synchronization loss; and the pipettes are wildly different from the rest of
the micros.

This fixes the above by setting the values to be the same as linux.
Note: this will go into main, just doing it onto the branch it's based on to show off the differences better

Looks fine, but wasn't Joe saying 50ns might be too short of a time period yesterday?

Yes, and I don't intend to merge this until we've actually verified the physical functionality - that's a big part of why I split this off


Add new storage system events

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Messaging.EventGrid


Feature/swift3 migration.review

@tuzonghua this is my review, I've tried to follow at best:
https://swift.org/documentation/api-design-guidelines/
using label for first paramaters, make for factory methods, shorter names.

Lgtm!


Allow Orchest installation without installing Argo

Description
This PR  deploys argo on controller startup if specified, it helps deploying orchest in multiple namespaces and if cluster already have argo, user can disable it, so orchest uses cluster argo, the argo can be disable by addons argo=false
Fixes: #866
Checklist

[x] The documentation reflects the changes.
[x] The PR branch is set up to merge into dev instead of master.
[x] In case I changed code in the orchest-cli I followed its release
checklist
[ ] I haven't introduced breaking changes that would disrupt existing jobs, i.e. backwards
compatibility is maintained.

CLI changes still has to be added.

Really like the addons approach :)!

Are there any plans to add user-facing docs about the concept of addons or to highlight the fact that deploying with no argo is possible?

Are there any plans to add user-facing docs about the concept of addons or to highlight the fact that deploying with no argo is possible?

Sure, will add that

LGTM assuming changes w.r.t. https://github.com/orchest/orchest/pull/1016#discussion_r889963365

I can't run the scripts/build_container.sh script anymore, because the services/orchest-controller/Makefile fails to generate the manifests.
make: Entering directory '/home/orchest/services/orchest-controller'
Updating CRD manifests
/home/orchest/.cache/tools/controller-gen crd paths=./pkg/apis/... output:dir=deploy/helm/templates
Generating orchest-controller.yaml manifests
Error: template: orchest-controller/templates/deployment.yaml:16:14: executing "orchest-controller/templates/deployment.yaml" at <eq .Values.addons.enableArgo "true">: error calling eq: incompatible types for comparison

Use --debug flag to render out invalid YAML
make: *** [Makefile:59: manifestgen] Error 1
make: Leaving directory '/home/orchest/services/orchest-controller'

@yannickperrenet : fixed


Can't connect to custom API

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Able to use aad credentials in my application
Observed Behavior
I am getting
https://login.microsoftonline.com/<Tenant_GUID>/oauth2/authorize?client_id=<Client_GUID>&redirect_uri=https%3A%2F%2F<APP_ID>.azurewebsites.net%2Fsignin-oidc&response_type=id_token&scope=openid%20profile&response_mode=form_post&nonce=<NONCE_VALUE>&state=<STATE_VALUE>&x-client-SKU=ID_NETSTANDARD2_0&x-client-ver=<IP_ADDRESS>
Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
If i watch it in the browser DevTools I get
Options request that returns 200
Then a get that returns a 302
and another get that returns 302
Steps to Reproduce
I have an API that is secured using aad and accessible from the browser.
I followed https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/use-aadhttpclient-enterpriseapi-multitenant.md and got that working with a function.
Substituting my client and my url is causing grief.

This isn't clear why you are requesting to the /authorize endpoint. If you followed the doc, you use the AADHttpClient to obtain the access token from SPO, not from the AAD authorize endpoint.
Need more context... sorry... unable to understand the question / scenario.

I figured this one out. It's because I was using the AAD -> App Registrations -> App -> Application ID URI as the client factory resource endpoint.
When using the the function example the Application ID URI is the same as the function URL. On custom apps it is not.


Getting a crash on a MacBook Pro 13' with Intel GPU

I am trying tvmlang on my Mac OS 13.3, MacBook pro 13 with just a mere Intel GPU 550. I am unable to compile any model - I get an  error "Check failed: allow_missing Device API gpu is not enabled."
I compiled with support for metal, cuda, opencl, opengl (I manually installed glfw3 and modified config.mk to add the following flags)

the additional link flags you want to add
ADD_LDFLAGS = -lglfw3

the additional compile flags you want to add
ADD_CFLAGS = -framework Cocoa -framework OpenGL -framework IOKit -framework CoreVideo

No matter what sample I try to run, I get this error. Is tvmlang supported on computers with Intel GPUs?
Alexandru
acostin-macOS:nnvm acostin$ python from_onnx.py
Downloading from url https://gist.github.com/zhreshold/bcda4716699ac97ea44f791c24310193/raw/93672b029103648953c4e5ad3ac3aadf346a4cdc/super_resolution_0.2.onnx to super_resolution.onnx
File cat.png existed, skip.
[20:18:34] src/runtime/metal/metal_device_api.mm:118: Intializing Metal device 0, name=Intel(R) Iris(TM) Graphics 550
Traceback (most recent call last):
File "from_onnx.py", line 81, in
m = graph_runtime.create(graph, lib, ctx)
File "/Users/acostin/.local/lib/python2.7/site-packages/tvm-0.4.0-py2.7-macosx-10.6-x86_64.egg/tvm/contrib/graph_runtime.py", line 44, in create
return GraphModule(fcreate(graph_json_str, libmod, device_type, device_id), ctx)
File "/Users/acostin/.local/lib/python2.7/site-packages/tvm-0.4.0-py2.7-macosx-10.6-x86_64.egg/tvm/_ffi/_ctypes/function.py", line 183, in call
ctypes.byref(ret_val), ctypes.byref(ret_tcode)))
File "/Users/acostin/.local/lib/python2.7/site-packages/tvm-0.4.0-py2.7-macosx-10.6-x86_64.egg/tvm/_ffi/base.py", line 66, in check_call
raise TVMError(py_str(_LIB.TVMGetLastError()))
tvm._ffi.base.TVMError: [20:18:34] src/runtime/graph/graph_runtime.cc:503: Check failed: ret == 0 (-1 vs. 0) [20:18:34] src/runtime/c_runtime_api.cc:88: Check failed: allow_missing Device API gpu is not enabled.

please ask general questions at https://discuss.tvm.ai/ in your case, we will need to change the target context to metal(0) instead of gpu(0)(which means cuda)

Hi Tianqi.
Thanks for the note. I'll try now. BTW - installation instructions improved dramatically in the last week. I like your project and I am curious to see how it will improve the performance of models on desktop in particular.
As a funny note though - as TVM is trying to make neural networks fast everywhere, on all GPUs and CPUs, is there a way to refactor the API reflect that? (like tvm.gpu(0) should be my GPU not my Cuda endpoint). Or maybe improve the sample app to be more portable...
A

hi @acostin1
can u give some tips how to install tvm in macbook?
thanks.


Description
This pull request introduces technical documentation about the namespace replication mechanism. Two new documentation sections are added:

A first page with the general concepts and resources involved.
A second page with an in-depth analysis of the various Liqo controllers involved in the replication process.

/doc-build

/doc-build

@Andreagit97 Very good work, Andrea. Please feel free to squash my commits and address the remaining comments.
Overall, it looks very good to me.

/doc-build

/doc-build

/doc-build

/doc-build

/doc-build

/rebase test=true

/rebase test=true

/test

/doc-build


Change color/icon style of yellow "warning" in-cell notifications to red "error"

Make the existing yellow "warning" in-cell notifications have the styling of the red "error" notifications (see comment from 2/18). That way, yellow is reserved exclusively for EC.

Confirmed.


Release Google.Cloud.Metastore.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.Metastore.V1-1.0.0-beta01


Added favicon in contributor's page

Related Issue
Added the favicon to contributor's page.
Fixes:  #4082
Description
Added the favicon to contributor's page that will enhance the website more.
Issue no. #4082
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

favicon is already there . maybe due to internet issue , u may not be getting it .


endpoint default url and status

renamed struct OverpassStatus into EndpointStatus
moved struct to #TYPES in line 12
made hard coded URLs explicit

Looks pretty nice.
I'm really unsure about the renaming of OverpassStatus to EndpointStatus. From the users perspective you just get the current status of the Overpass API you're currently using, independent of the current endpoint / instance you're using.
But I also get your point. There is no general overpass status. So it's currently only the status of the endpoint you're using.
Still if I'd execute Overpass.status() and EndpointStatus is returned I would be completely confused.
What do you think about just using 'Status'?


Adding section in the documentation to explain environments

Description
Adding a section in the documentation to explain environments.
Documentation linked to #246
Checklist

[x] I have updated the documentation (README.md and /docs)
[x] I have followed the contributing guide

Coverage remained the same at 93.975% when pulling 54478b44329ba8372c38548774f4c4357e09393b on add-doc-section-env into a0a75c2d242d31193b62fdc3e86db1ede18612a0 on main.


Expanded esp32 chip support

These changes extend coverage of the esp32 port to esp32-c3, esp32-s2, and esp32-s3 chips.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

I still need to update documentation and add to the CHANGELOG but the code and tool changes should be ready.


How to clear cache when map file changed

Map file content is cached in fileContentsCache variable, when map file changed, how to clean cache.

Sorry, i found it


[NonBlocking Bug]: unit tests no longer pass, last controller test fails.

Is there an existing issue for this?
**No** I have searched the existing issues

Current Behavior
When running our unit-test suite, I've recently found that the last 'controller' test no longer passes.  Output is too verbose to include here.  Run "pytest" from an up-to-date copy of seedsigner "dev" branch.  Briefly, I believe that it's the thread startup which watches for a microsd or no-microsd; the traceback looks like:
tests/test_controller.py:49:
src/seedsigner/controller.py:133: in configure_instance
controller.microsd.start_detection()
src/seedsigner/hardware/microsd.py:30: in start_detection
self.start()
src/seedsigner/models/threads.py:14: in start
super().start()
E           RuntimeError: threads can only be started once
/usr/lib/python3.7/threading.py:843: RuntimeError
Expected Behavior
My expectation is that all tests pass 100% w/o warnings after each merge/commit to the seedsigner dev branch.
Suggested Fix
It's above my current understanding, and I suspect we won't need this until SeedSignerOS becomes an official release.
No clue if this deserves a fix in code or if this particular test is no longer valid.
Anything else?
This first appeared in commit https://github.com/SeedSigner/seedsigner/commit/c6c8ff25eee414840b2769fde7a0f9360d244bec
I found it after a fresh manual installation didn't resolve my very custom installation.
Then I tried a harder more brute-force approach (because I still didnt understand the traceback).  I did a binary search of "git log --oneline" knowing that these tests had passed 100% when I first installed in late October.
Along the way I did plenty of manual loops like:
git reset --hard "my-next-binary-search-commit-target"
pip3 install -r requirements.txt
pip3 install -r tests/requirements.txt
pip3 install -e .
pytest -v
...as well as:
git pull origin
...whenever my next commit target was more recent than where I'd "reset --hard"
tagging: @newtonick  and @DesobedienteTecnologico as I'm guessing they might know.
Formatting of this issue is a shout-out to @EverydayBitcoiner and their suggestions in https://github.com/SeedSigner/seedsigner/issues/292

More information:
It's not about which particular controller test is failing, it's more about a threading.Thread object calling its self.start() method more than once. In the test_controller.py file, the first test is just testing that an exception is raised if the Singleton is not created via "get_instance()", the second and third tests are real tests.  If I swap the order of those two test fixtures, it's always the second one that will fail because the thread is being start()ed again as controller.microsd is initialized in a subsequent test fixture.

Knowing that Controller and Settings are Singletons, and so is MicroSD,
and seeing the comments about Singletons not being isolated by pytest w/ a kludge to set their _instance attribute to None at the top of the controller test fixtures,
I've added:
from seedsigner.hardware.microsd import MicroSD
...to the import lines of test_controller.py
...and
MicroSD._instance = None
...to the setUp-ish section of each test fixture
and the tests are finally all passing again... but this does not give me any comfort.
Please explain this to me if you can, or the correct fix if you know it.


[MINOR][DOCS] Make pivot doctest deterministic

What changes were proposed in this pull request?
This PR proposes to make pivot doctest deterministic by explicitly adding a sort.
Why are the changes needed?
To have the deterministic result.
Does this PR introduce any user-facing change?
Yes, it changes the user-facing example in PySpark API reference.
How was this patch tested?
Manually ran the doctests.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master.


Installing SLES-12 hangs on failing command 'dmidecode'

I have been using WSL for years, mainly Ubuntu, in both WSL/WSL1 and WSL2 form.
Way back, I was also able to experiment with SuSE and development trials (1year license). I wanted to resume my SLES evaluation after a long time of focus on Ubuntu.
So I wanted to install SLES-12 (I tried for both WSL1 and WSL1). I seem to have a valid "trial code", but all my attempts fail with the same error:
> wsl --list --online
The following is a list of valid distributions that can be installed.
Install using 'wsl --install -d <Distro>'.

NAME            FRIENDLY NAME
Ubuntu          Ubuntu
Debian          Debian GNU/Linux
kali-linux      Kali Linux Rolling
openSUSE-42     openSUSE Leap 42
SLES-12         SUSE Linux Enterprise Server v12
Ubuntu-16.04    Ubuntu 16.04 LTS
Ubuntu-18.04    Ubuntu 18.04 LTS
Ubuntu-20.04    Ubuntu 20.04 LTS

> wsl --status
Default Distribution: Ubuntu-20.04
Default Version: 1

Windows Subsystem for Linux was last updated on 11/23/2021
WSL automatic updates are on.

Kernel version: <IP_ADDRESS>

> wsl --list -v
  NAME            STATE           VERSION
* Ubuntu-20.04    Running         1

>wsl --install --distribution SLES-12
Downloading: SUSE Linux Enterprise Server v12
Installing: SUSE Linux Enterprise Server v12

This continues in a new terminal:
Installing, this may take a few minutes...
Installation successful!
Register your SLES to enjoy the full SLES experience.
Visit https://www.suse.com/subscriptions/sles/developer/ for free developer subscription.
Enter registration code (leave empty to skip registration): <my_trial_code>
/usr/lib64/ruby/2.1.0/open3.rb:193: warning: Insecure world writable dir /mnt/c in PATH, mode 040777
command 'dmidecode -s system-uuid' failed

👉 The terminal just hangs here without any further information or instructions...

@dseynhae try installing w/out registration. It works on WSL2:


Feature - Allow TS names to include network callsign

Fixes #791

When this goes live, it would probably be best to warn people they need to use their exact callsign, especially after a controller change, where someone controlling KK TWR might be EGKK__TWR or EGKK_1_TWR etc., to avoid being kicked (As long as I'm reading the implementation of this right)

True, or advise them there's not really any need to change to the regular callsign anyway if they are on a relief callsign.
Does the API offer a way to poke people? Maybe that would be less harsh - but also log who was sent a message? I.e. "controller x logged on as y but TS name is z"

@morphicsphil - good shout.  We'll need to modify the poke/kick scenario for this, as I've bolted it onto the rest they'll be kicked straight away... We really could do with a graceful kick scenario (of 2 warnings or something).  Waiting to hear back from @NFarrington on his review and suggestions for improvement.

Closing due to my messing up of the push. Re-opened in #890


remove raw write from persistence

Coverage increased (+0.02%) to 84.989% when pulling b5e9439b4d06893fb3487d7fdaa8d3f26ce4ba64 on hendrik-cliqz:remove_raw_write into 62505f254d027f82786e258962976852e87993e5 on cliqz-oss:master.

Coverage decreased (-0.04%) to 84.935% when pulling e5d45a87f11952f3430dd81447e28a51366806f5 on hendrik-cliqz:remove_raw_write into 62505f254d027f82786e258962976852e87993e5 on cliqz-oss:master.

works now


On articles about persisting add-in state and settings

The article https://docs.microsoft.com/en-us/office/dev/add-ins/develop/persisting-add-in-state-and-settings seems to be updated recently (09/10/2021) but offers either to save settings within a document (Settings, CustomParts) or to use techniques provided by browser (localStorage).
The issue with localStorage, is that with many modern browsers (namely, Safari and latest Edge builds) even if we use Storage API, this information is not persisted between sessions - I've read similar issues in OfficeDev/office-js (while they were mostly about sharing data between dialog and taskpane) and tested with Safari 15.1, Safari 15.4 and Edge 95: even if requestStorageAccess is granted by user (on a click event, as required), for documents in iframe, this permission is reset on browser reload and the worse part is that the localStorage granted to iframe is cleared. Firefox also requires to request a new approval from a user after a browser was closed, but after a new requestStorageAccess call the iframe can access all the data from previously used localStorage, so while a user is bothered to click a "Allow Storage"-like button every time the add-in is loaded, it's possible to persist user data and login information in localStorage.
Another relevant article here is https://docs.microsoft.com/en-us/office/dev/add-ins/develop/itp-and-third-party-cookies
It says:

Use the Storage Access API so that the third-party can request permission to get access to its first-party cookies. Current versions of Office on Mac and Office on the web both support this API.
Note
If you're using cookies for purposes other than authentication, then consider using localStorage for your scenario.

It features nice example (while it does not cover promise rejection), but does not mention that the data won't be preserved.
To my understanding the only solution for Office on the web add-ins would be using SharedRuntime.storage.
Article URL
https://docs.microsoft.com/en-us/office/dev/add-ins/develop/persisting-add-in-state-and-settings
https://docs.microsoft.com/en-us/office/dev/add-ins/develop/itp-and-third-party-cookies

Hi @alexuaua,
Thank you for reporting this. @davidchesnut, could you please take a look and help clarify the data persistence story?

I've read all latest Storage API specifications and played with Storage API, and found that I got confused by localStorage mention in the article about ITP, while the main phrase points only about cookies:

Use the Storage Access API so that the third-party can request permission to get access to its first-party cookies.
requestStorageAccess grants access to cookies in Safari, but local storage is ephemeral (cleaned when browser is closed) - this may be worth to mention, if one needs a local storage or indexedDB (for Firebase Auth or auth0), there is no need to play with Storage Access API as it won't grant these. On other side Firefox preserves localStorage contents.

And I've got it wrong with Edge – with default settings there are no issues with Edge (for Mac, I've not checked Windows yet).

Hi @alexuaua,
To be clear are you asking how to persist data that is associated with the user (not the document or session?) Yes, that's correct that you can save data at the browser level, but it is not really persistent as the user can delete it. You can also use the  Settings data, but that is document specific.
To store data per user you would need to sign in the user and then store their information in a database. For that approach I'd recommend to sign in the user using SSO and call getAccessToken to get the user's identity via the returned access token. Then you can create a unique id to store data in a server database for each user.
Hope I'm understanding your scenario correctly. Please let me know if there are more details I perhaps missed.
Thanks!
David

Hi @davidchesnut,
My only point here (in office-js-docs) was that it's probably worth to mention that the storage techniques mentioned in the article are not available on Mac (with default browser, Safari), and another article mentions Storage API and ITP with Safari on Mac, but this does not work for iframes (an add-in case).
And thanks a lot for the idea of using SSO token to exchange for a login token instead of local storage – as I understand (I'm still setting up the example) the sign-in/consent prompt should be displayed only the first time we call getAccessToken and an Office app provides it silently on subsequent calls.
I'm only a bit confused by this note

You should not rely on SSO as your add-in's only method of authentication.
Because if we don't have any local storage, we can only rely on SSO token to exchange it (on our back-end) for a token, let's say, from a social login provider.

It still would be great to have a storage API (even a very simple, like a Google API for Workspace add-ons ) for add-ins to store some user preferences. But this is definitely a feature request for the office-js repo, and offtopic here.

@davidchesnut as I understand you are the main contributor to the Node.js add-in with SSO example, so here looks like a good place to ask you.
Every time I click the "Get OneDrive Files List" button, I see a "Office Add-in NodeJS SSO wants to display a new window" confirmation dialog inside the taskpane.
Is this a correct behaviour?
Because if there is no bug or some compatibility issue, requiring a user to confirm each time the add-in loaded, unfortunately, makes the scenario with using SSO + getAccessToken useless (vs simply asking user to log-in again) to persist an authorisation or settings.
And thanks in advance for your attention.
Alex

Ok, I added PR #3138 to clarify that some browsers may not support localStorage, and also linked to the article on how to test for availability.
Regarding the "Office Add-in NodeJS SSO wants to display a new window" message:
Yes, this is by design. To work around popup blockers the user must be asked for permission. This only happens if:

The user is not signed into Office.
The user has not consented to the add-in yet.
The admin has not consented to the add-in yet. (which can be done in the app registration process to avoid this case.)

Once the user signs in, and consents, you shouldn't see this message anymore. You should just receive the access token. So it should just be a one-time request.
Thanks!
David


ENYO-2334: Popup close button misaligned and with background color - reverted

With merged PR, popup close button does not get spotlight's background color. So, I made reverted PR.
Enyo-DCO-1.1-Signed-off-by: Suhyung Lee<EMAIL_ADDRESS>

During 2.6.0-pre.15.1 test, regression issue is discoverd. So merge this(ENTO-2334 revert PR) for release 2.6.0-pre.15.2 tag


feat(Data/List/SplitLengths): splitting a list to chunks of given sizes

Currently this uses List.sum, but it could also use Nat.sum. What's better?

Currently this uses List.sum, but it could also use Nat.sum. What's better?

List.sum is fine!

One could prove stronger theorems. As long as the partial sums are big enough, the getElems have the right length.

One could prove stronger theorems. As long as the partial sums are big enough, the getElems have the right length.
One could even prove an unconditional result about the length of the i-th part, as a minimum.
(I wouldn't say these are strictly essential for this PR, but I do have a slight preference for getting the complete API in on the first go.)

Isn't that List.splitLengths_map_length?

One could prove stronger theorems. As long as the partial sums are big enough, the getElems have the right length.
One could even prove an unconditional result about the length of the i-th part, as a minimum.
(I wouldn't say these are strictly essential for this PR, but I do have a slight preference for getting the complete API in on the first go.)

Isn't that List.splitLengths_map_length?

No, because that is only valid with the condition l.length = sz.sum. I want the unconditional lemmas.

@Command-Master any further thoughts on this one?

@Command-Master any further thoughts on this one?

My apologies, I missed this. I still don't quite understand what statement are you looking for. Is it (sz.take i).sum <= l.length -> (sz.splitLengths l)[i].length = sz[i]?

Currently this uses List.sum, but it could also use Nat.sum. What's better?

The latter is soon going away,it seems

@Command-Master any further thoughts on this one?

My apologies, I missed this. I still don't quite understand what statement are you looking for. Is it (sz.take i).sum <= l.length -> (sz.splitLengths l)[i].length = sz[i]?

Yes.

Thanks, this is great now!
bors merge


Delete calendar?

I didn't connect my Google account, because I just want to keep everything local. I found if I didn't have any calendars, the plugin would notice me to create a new calendar. But I didn't find any way to delete the local calendar I created.
How should I do?

If this feature does not exist, could you add some feature to add, delete and rename those calendar?

There should be a calendar list file at ~/.cache/calendar.vim/local/calendarList. You can edit or delete the file.


Test starter output board

Use 12V AC and switch board tester to test the starter output board.

Tested on bread board.


Rebuilding the blog and adding many fantastic features

🛠 Fixes Issue #241
https://user-images.githubusercontent.com/56798376/166122223-016b8dc1-fa75-4c53-a448-82d8f7bdc4f6.mp4

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Can you please review this PR @singhmansi25 @KKhushhalR2405

@muhammadgalhoum resolve these merge conflicts
@raghavTinker @KKhushhalR2405 review this PR carefully

@muhammadgalhoum in this video only features of this PR is there or all combine ??

All blog features in one video

@muhammadgalhoum in this video only features of this PR is there or all combine ??

All blog features in one video

ok @muhammadgalhoum resolve the conflicts i will merge

@muhammadgalhoum resolve these merge conflicts
@raghavTinker @KKhushhalR2405 review this PR carefully

Solved


Affects balance

If you change the skin of  minions and disable minion skins in game settings, Nicole will look different from other minions.
改了小兵皮肤后在游戏设置里关闭小兵皮肤然后妮蔻变成小兵的皮肤会跟普通小兵不一样

谢谢

#1


Update readme_template.md

After updating my repo for macOS 10.15, optimizing for zsh and introducing a config file I am happily accepting your offer getting listed in the interesting applications section.
We were talking about it here.
You can of course change the text if you do not like it like this.
Thanks in advance

Thanks @tiiiecherle.  I like.  Merging.

Thanks @tiiiecherle and Nissar @funilrys.
Merging.


[CAMB.AI] Carnegie Mellon AI founder reaching out

Deets in README.md PR

Thank you for reaching out. This pull request seems unrelated to the project. Please ensure that PRs are relevant to the project's scope. As for the job offer, I appreciate the gesture, but I'm not currently seeking new opportunities. I'll be closing this PR. Thanks again.


Login with domain user UPN with RDP

I have a question on the proper way to get this working.
I am trying to login using a user we have setup with a custom userPrincipalName. eg. user1@compa
I am using Local Machine plugin with Gateway enabled.
and LDAP plugin.
This processes through the plugins but then I get an error: No mapping between account names and Security ID's was done. then logs me out.
If i attempt to login using the users samAccountName user1.abc it bypasses the plugins all together.
Also a local account gets automatically created when i login with user1@compa but not with user1.abc
On a separate note, is there a way to just force all users to authenticate regardless of 'pGina Created' attribute?
Any help would be appreciated, love the work on this project!
Some additional log info that may help. the computer domain is: iitdev.local
2017-10-20 14:50:40,978 [1108|18|DEBUG] RemoteLog[NativeLib]: [Provider.cpp:473] SerializedDomainNameAvailable: couldn't work out domain name
2017-10-20 14:50:40,979 [1108|17|DEBUG] RemoteLog[NativeLib]: [Provider.cpp:473] SerializedDomainNameAvailable: couldn't work out domain name
2017-10-20 14:50:40,983 [1108|29|DEBUG] RemoteLog[NativeLib]: [Credential.cpp:492] Credential::Connect: Processing login for j1@mfa3
2017-10-20 14:50:40,986 [1108|14|DEBUG] PluginDriver:56d20104-4f94-45df-b979-fa31f01fa997: New PluginDriver created
2017-10-20 14:50:40,988 [1108|14|INFO ] pGina.Service.Impl: domain:compa
2017-10-20 14:50:40,989 [1108|14|INFO ] pGina.Service.Impl: domain:compa
2017-10-20 14:50:40,992 [1108|14|INFO ] pGina.Service.Impl: domain check:[False] [True] [True]
2017-10-20 14:50:40,992 [1108|14|DEBUG] pGina.Service.Impl: domain logon: Username:user1domainmember:iitdev.local domain:compa

http://mutonufoai.github.io/pgina/documentation/user.html

just force all users to authenticate regardless of 'pGina Created' attribute?

no


Diagnostic logs

Please elaborate on how diagnostic logs can be gathered. I am currently troubleshooting a failed white glove provisioning, and I cannot figure out how to gather and view diagnostic logs. I cannot find this documentation on this page or the page for Troubleshooting Windows Autopilot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca5b57d1-61b3-39d4-34ff-d6dcb858c250
Version Independent ID: 42609104-815f-9e7a-39aa-38d92cc910c9
Content: Windows Autopilot for white glove deployment
Content Source: windows/deployment/windows-autopilot/white-glove.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

Let's see if I can post the example image here..

Also, you can go to a command prompt and run the following:
mdmdiagnosticstool.exe -area Autopilot;TPM -cab c:\autopilot.cab


python3Packages.opentelemetry-instrumentation-botocore: init at 0.46b0

Description of changes
Add opentelemetry-instrumentation-botocore python module https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-botocore
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 326504 run on x86_64-linux 1

8 packages built:

python311Packages.opentelemetry-instrumentation-botocore
python311Packages.opentelemetry-instrumentation-botocore.dist
python311Packages.opentelemetry-propagator-aws-xray
python311Packages.opentelemetry-propagator-aws-xray.dist
python312Packages.opentelemetry-instrumentation-botocore
python312Packages.opentelemetry-instrumentation-botocore.dist
python312Packages.opentelemetry-propagator-aws-xray
python312Packages.opentelemetry-propagator-aws-xray.dist


Thumbnail as a config?

My use case is to upload a thumbnail / cropped photo to the same backend I am storing it in.  It looks like the thumbnail backend only stores things locally, but maybe i've read the code wrong.

Just read through - that was from a PR probably two years old, so I'd completely forgotten.  To my eyes, it looks like it'll use the storage backend for saves/thumbnailing, but that os.unlink isn't backend-linked or compatible.  Could definitely use improvement.


docs: improve API documentation

refs #306

Coverage decreased (-0.01%) to 83.431% when pulling 1467b81f51fe4e1dbb2ba40607951063161cc02a on docs-306 into d319a2fa80cac2c9fc3c853921c1b1fb13f8dba9 on master.


WMS ID: #11121

WMS ID 11121
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[x ] All filenames are lower case (including folders, images, files, etc.)
[x ] Filenames are descriptive
[x ] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[x ] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[x ] Image references in markdown contain an alternate text

Hi @secassessment
It looks like your pull request is creating copies of all the workshop files. Could you please update your request to fix this issue or provide additional details.

Hi @secassessment
It looks like your pull request is creating copies of all the workshop files. Could you please update your request to fix this issue or provide additional details.

Hi, I just created the pull request as indicated in the docs. I changed all images in the workshop as the OCI console changed. Could that be the reason?

@secassessment Moving this conversation to slack.

Hi @secassessment,
Please let me know if you need further assistance to get this PR approved.
Thank you,
Ramu

Hi @secassessment,
Please let me know if you need further assistance to get this PR approved.
Thank you, Ramu

Hi Ramu,
Thanks a lot it would be great if you could help. What should I do to resolve the conflicts?
Regards,
Sonia

Hi @secassessment,
To resolve merge conflicts, please merge the latest changes from the main branch to this branch and resolve the conflicts. This troubleshooting guide has more details.
Thanks,
Rahul

@secassessment - Please join the LiveLabs Office Hours meeting tomorrow to look at resolving these conflicting files. As the PR is more than 2 weeks old closing the PR for now. Once the conflicting files are resolved, can create another PR.


feat: convert and export from markdown

TODO:

[ ] Add some tests

Eh. Marking as draft, as less idempotent than I think is ideal.
Settles after a few recurrent runs, but whitespace shifts around.
Will look into it and push tests when I have a bit more time

this is awesome 😮
let me know if there is anything I can do to help on this
(also thank you for the DRYness / cleanup)

Thanks! Hope this PR didn't get too large.
Do you have a way of testing on windows? Looks like maybe some unicode encoding or something is causing the windows test failure. Or maybe line endings? Not sure what's going on

Skipping the test for now. I can come back to it this evening

Do you have a way of testing on windows? Looks like maybe some unicode encoding or something is causing the windows test failure. Or maybe line endings? Not sure what's going on

@dmadisetti I can help you test on Windows.
For reference, I spin up a trial Windows VM using VirtualBox. I think I got the image from here but I don't remember 100%: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/

Cool making a list for later:

[ ] I think I'm going to remove most of the test data files, 7 seems excessive and is cluttering the PR- maybe just keep one of the bigger ones, and make a custom one (need to check more complex yaml for front matter header). Will also change to snapshots for ease updating.
[ ] New line between md and code
[ ] .python.marimo tag
[ ] Get app name

@akshayka Awesome! I'm pretty sure it's the emojis in python -> md, so we could just skip the emoji case for windows- but debugging it might take some playing around. I do have access to a windows vm, but don't have virtual box or anything set up right now

Pretty sure that failure was an actions network issue- not sure how to retrigger tests


Create WASM compilation example(s)

Would be good to create an example (or maybe a couple) showing how we can compile WASM files to MASM files. The basic example could include something simple - like computing a fixed Fibonacci number. We could add to these examples over time to include more complex use cases.
The examples could be in a separate top-level directory (e.g., examples)  with a short README explaining how to compile them.
The main goal here is to make it easy for newcomers to see how compilation works and check out the output of the compiler for some simple programs.

@bobbinth For examples, shouldn't it be about Rust to MASM? Because a developer is going to be more interested on learning how "compilation from a high level language to MASM" works and less on how it works with WASM to MASM.
And when we include an example on Rust to MASM compilation, it is going to include WASM to MASM part anyway.

shouldn't it be about Rust to MASM?

Eventually, yes - but for now we can start simpler and show Wasm to MASM.

This is closed via #91, which covers compiling Rust->Wasm and Wasm->Masm. The current process is not great, but isn't too complicated, but there are a few things I need to address to streamline the process a bit. The frontend changes that @greenhat is working on are going to change things as well, though I expect much of that will be a separate process with its own guide, rather than replacing the ones in that PR. In any case, we'll want to get GitHub pages set up for this repo when we can (I don't believe anyone but @bobbinth can do that currently, but hopefully we can push updates automatically once set up).


new maintainers

Signed-off-by: David Chung<EMAIL_ADDRESS>

@YujiOshima @ndegory @kaufers - welcome!

Thank you for adding me !
I'm exciting! Really motivated ! 😆


Unlocking room promotes all peers, but it shouldn't

I had a look at server/lib/Room.js and I see there:
case 'unlockRoom':
{
if (!this._hasPermission(peer, CHANGE_ROOM_LOCK))
throw new Error('peer not authorized');
			this._locked = false;

			// Spread to others
			this._notification(peer.socket, 'unlockRoom', {
				peerId : peer.id
			}, true);

			this._lobby.promoteAllPeers();

			// Return no error
			cb();

			break;
		}

This means that if the room gets unlocked all peer from lobby get promoted. But I think this is a bug, as only these with BYPASS_LOBBY should get promoted, not all. The ones with no BYPASS_LOBBY should stay in the lobby and must be promoted by a user with PROMOTE_PEER. This as it is currently mixes up permissions and lock.

After a deep analysis, of course peers in lobby don't have permissions yet, so I think just removing the line this._lobby.promoteAllPeers(); is the correct solution.


Update Puppeteer.md

Summary
Being new to Jest, I was pretty confused about the detour via file system since I was expecting global.__BROWSER__ to be the same in every env. Renaming it and adding a comment should make it more clear.
Test plan
I have submitted the same PR in https://github.com/xfumihiro/jest-puppeteer-example/pull/12 where I ran the demo test successfully.

Codecov Report

Merging #6477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6477   +/-   ##
=======================================
  Coverage   63.48%   63.48%
=======================================
  Files         227      227
  Lines        8697     8697
  Branches        4        3    -1
=======================================
  Hits         5521     5521
  Misses       3175     3175
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794e86a...546a8ef. Read the comment docs.

Thanks!


[Upgrade to 19.9.0] 'Request' object has no attribute 'pop'

Describe the bug
This bug is only introduced when I upgrade my server to 19.9.0 from 19.6.3.
Although the server still returns the response, it freezes during teardown of any test cases.
ERROR    sanic.error:app.py:991 Exception occurred in one of response middleware handlers
Traceback (most recent call last):
  File "/Users/son/.local/share/virtualenvs/ora-backend-SVHRxsY1/lib/python3.7/site-packages/sanic/app.py", line 983, in handle_request
    request, response
  File "/Users/son/.local/share/virtualenvs/ora-backend-SVHRxsY1/lib/python3.7/site-packages/spf/framework.py", line 571, in _run_response_middleware
    _response = await _response
  File "/Users/son/.local/share/virtualenvs/ora-backend-SVHRxsY1/lib/python3.7/site-packages/gino/ext/sanic.py", line 91, in on_response
    conn = request.pop('connection', None)
AttributeError: 'Request' object has no attribute 'pop'

Environment (please complete the following information):

OS: Mac OS 10.14.6
Version: 19.9.0

can you post a code snippet to help us try and replicate?

Version:
Gino: 0.8.3
from sanic import Sanic
from sanic.response import json
from gino.ext.sanic import Gino

db = Gino()
app = Sanic(__name__)

DB_CONFIG = {
    "DB_HOST": "localhost",
    "DB_PORT": "54320",
    "DB_USER": "postgres",
    "DB_DATABASE": "postgres",
    "DB_POOL_MIN_SIZE": 5,
    "DB_POOL_MAX_SIZE": 10,
}
SANIC_CONFIG = {**DB_CONFIG, "KEEP_ALIVE_TIMEOUT": 10}
app.config.update(SANIC_CONFIG)

db.init_app(app)

@app.route('/')
async def test(request):
    return json({'hello': 'world'})

if __name__ == '__main__':
    app.run(host='<IP_ADDRESS>', port=8000)

You need to be using request.ctx now because the dict API on request is no longer (fully) supported. https://sanic.readthedocs.io/en/latest/sanic/middleware.html#modifying-the-request-or-response

Issue is this line in Gino's sanic extension:
https://github.com/fantix/gino/blob/2c233e9fcf80637ef24f9d16d8652d27d14bddf7/gino/ext/sanic.py#L91
Because this is an issue within a different project, I'm closing this, but have opened the issue with Gino here: https://github.com/fantix/gino/issues/581


Fatal when refmt on Some x y

When parsing this example, we should not fatal the parser, but rather give a graceful parsing error (like any other parse error).
Make sure to set export CAMLRUNPARAM='b' to see good stack traces as always.
Here's the command that triggers the error and the resulting error:
refmt ./examples/pure/logo.re
Fatal error: exception File "src/reason_parser.ml", line 3833, characters 17-23: Assertion failed
Raised at file "src/reason_toolchain.ml", line 87, characters 10-13
Called from file "src/reason_toolchain.ml", line 269, characters 14-57
Called from file "src/refmt_impl.ml", line 12, characters 48-157
Called from file "src/refmt_impl.ml", line 189, characters 18-69

Here's the contents of logo.re that causes the failure:
Some 10 20;

Here's the assert false where it occurs in our parser.mly:
  | as_loc(constr_longident) simple_non_labeled_expr_list_as_tuple
    {
      if List.mem (string_of_longident $1.txt)
         built_in_explicit_arity_constructors then
        (* unboxing the inner tupple *)
        match $2 with
          | {pexp_desc=Pexp_tuple [inner]; pexp_loc; pexp_attributes} -> mkexp (Pexp_construct($1, Some inner))
          | _ -> assert false
      else
        mkExplicitArityTupleExp (Pexp_construct($1, Some $2))
    }

The reason I think it is even unboxing the tuple like this is to make conversion from/to ml/reason more seamless. Reason uses explicit arity, and OCaml uses implicit arity. So we recognize it as a built in constructor type and make sure it has the right number of arguments and then auto-unbox. I actually think that not only are we ungracefully handling this case, but our general approach may be wrong because you can always redefine a type like:
type ttt = Some of int int | None of bytes

Then Some x y would cause a failure.
The auto-unboxing of tuple is still useful when converting a type from ML to Reason  (even if you can redefine the Some type) because it doesn't have to be a perfect conversion - the type checker will catch any incorrect guesses. But for standard parsing, I think we should not have any special behavior for Some/None unless the standard OCaml parser does.
Maybe @yunxing knows more about what this line of code does.

This is likely an easy fix, btw - I just want to make sure I have the right idea.

@jordwalke Catching up. Yes, What happens is this line makes sure the right number of arguments get passed down to the constructor. We should remove this check and let the underlying type checker does its job.

Stale!


[Question]Measure memory usage

How does one measure the memory and disk space used by turi objects?
I'm currently converting large number of pandas dataframes to a sframe and would like to measure whether transformations I perform the dataframe to optimize the memory have any effect on sframe.

Hello @DmitryZagursky,
There are easy, informal ways of doing this and much more rigorous ways that are harder to set up.  The quickest way is simply to use utilities like top / htop / iotop to poll the usage as you are running the program.
At a more detailed level, there are ways of profiling memory usage in python, which will likely be helpful here (E.g. https://stackoverflow.com/questions/552744/how-do-i-profile-memory-usage-in-python).
For disk usage, Turicreate uses a cache directory, which is given by tc.config.get_runtime_config()['TURI_CACHE_FILE_LOCATIONS']. Running du for that directory will give you idea of how much disk Turi is using.
Hope that helps!
-- Hoyt

Thank you for the response. (I didn't have much more to say on the matter before)
The reference to tc.config did help me at the time somewhat.
As for the rest, those methods are more of workarounds (to somewhat different problem) rather than answers to the question. I was hoping there was  something akin to pandas.memory_usage() method (apparently not among the documented ones). How does turi itself determine the size of sframes? It does somehow detect that the structure exceeded the TURI_FILEIO_MAXIMUM_CACHE_CAPACITY_PER_FILE and starts writing to disk.


"don't nest sub_command_groups and sub_commands to the same parent"

The discord API seems to allow this just fine, this limitation should be removed from the package.

I suspect that you misunderstood something, have a look at this image from the official documentation:

I already looked at it, this page doesn't state anything about having subcommands and subcommand-groups on the same levels, none of the example confirm nor deny that it's possible, so I tested it, and it does indeed work perfectly fine

Proof:

My bad; I'll fix that as soon as possible

Thank you :D

Fixed in 1.2.8


@awesome-cordova-plugins/push not working in new devices  | Android

Bug Report
i am using  "@awesome-cordova-plugins/push": "^6.3.0",
i am checking with debug app its working in old version android phones but not in new brand phones.

Im using version @dev but this plugin dont send pushnotification in ios using cordova plugin add @havesource/cordova-plugin-push@dev (this version 4.0.0 no crash but dont received notification)

This repo is not related to @awesome-cordova-plugins/push . You will need to find the repo for @awesome-cordova-plugins/push and report to those developers.


Tensor Core support for NVIDIA Volta architecture

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):
5386775e64aac0bb5020974122645da900bc312a
Python version: 3.5
Bazel version (if compiling from source):0.8.1
GCC/Compiler version (if comp6iling from source):5.4.0
CUDA/cuDNN version:9.1 / 7.0.5
GPU model and memory: Titan V
Exact command to reproduce:

Describe the problem
It is widely reported that using float16 on Nvidia Volta architecture comes only with x2 improvement instead of the expected x4 x8 improvement using Tensor Cores
https://github.com/tensorflow/benchmarks/issues/77
https://devblogs.nvidia.com/parallelforall/programming-tensor-cores-cuda-9/
I checked that Tensorflow master branch used
cudnnGetConvolutionForwardAlgorithm
to get the best possible algorithm for the given GPU.
However I think either
cudnnGetConvolutionForwardAlgorithm_v7
or
cudnnFindConvolutionForwardAlgorithmEx
should be used to fully utilize the Volta architecture.
Could you please check this issue with a Volta architecture GPU?
Source code / logs

Thanks @zheng-xq @egborbe @yzhwang for the helpful info!
Are Tensor cores are on by default using Tensorflow 1.7 or later? I run resnet50 with float16 and synthetic data on one node of v100 but only get 535 examples/sec, which is only half of what is reported here. In this issue 675 examples/sec is reported. I wonder why people can get over 1k and whether 535 can be regarded as a reasonable number.


”Ruși”, ”Vâlcele”, ”Vâlcelele Bune”, ”Vâlceluța” are listed in the drop-down menu

Description:
When user writes ”Ruși”, ”Vâlcele”, ”Vâlcelele Bune”, ”Vâlceluța” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Ruși"

Expected results
The location appears in the drop-down menu as "Sat Ruși, HUNEDOARA (Bretea Română)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Vâlcele"

Expected results
The location appears in the drop-down menu as "Sat Vâlcele, HUNEDOARA (Bretea Română)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Vâlcelele Bune"

Expected results
The location appears in the drop-down menu as "Sat Vâlcelele Bune, HUNEDOARA (Bretea Română)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Vâlceluța"

Expected results
The location appears in the drop-down menu as "Sat Vâlceluța, HUNEDOARA (Bretea Română)".


Added Netlify Provider

Added a Netlify Provider that works with the Netlify API to the list of third-party providers.

@putyourlightson @bencroker, thank you for contributing, and I'm sorry it's taken so long to respond. While we don't fully review the code of all third-party providers, we do try to make sure each provider includes tests. Since your package doesn't include tests, I'll close this PR. Full free to re-submit after you update your package with tests. Cheers!

Fair enough @ramsey, I'll add tests to the package and resubmit.


Allowing to query optional columns with a secondary index.

Doesn't seem to work in Scala 2.9.

Hi @henningp We don't offer support for Scala 2.9 anyway, but there is an easier way to do this without the implicit ambiguity.


Admin consent successful response example typo

The Successful response  has the parameter 'state=' twice:
GET http://localhost/myapp/permissions?tenant=a8990e1f-ff32-408a-9f8e-78d3b9139b95&state=state=12345&admin_consent=True
It should look like this:
GET http://localhost/myapp/permissions?tenant=a8990e1f-ff32-408a-9f8e-78d3b9139b95&state=12345&admin_consent=True

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d32f55ac-acbc-292b-d1b7-ffdd257b11e1
Version Independent ID: ae2a266c-051b-7307-93fd-74bc521c93bf
Content: OAuth 2.0 client credentials flow on the Microsoft identity platform
Content Source: articles/active-directory/develop/v2-oauth2-client-creds-grant-flow.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

Thanks for the catch! Will fix.

@kha1989led
Thank you for pointing this out! Since there's a PR to update the documentation, I'll go ahead and close out this issue.
Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
Thank you for your time and patience!