Rule updates

Proposed changes
This PR pulls in and resolves conflicts from #17, #19, and #20. It also resolves previous review comments. Most of these include quality changes. Briefly (click drop toggle to see notes from previous PRs for respective workflows):

Freesurfer

Update to the thalamic segmentation output file name (which is defined by Freesurfer)
Uses wildcards to define some of the outputs
Addition of relevant references in the .smk file

Mrtpipelines

Updates to pybids_inputs
Use of variables instead of grabbing from config for every rule
Renamed rules to reflect similar naming of mrtrix functions
Update mrtrix container to 3.0.3.

zona_bb_subcortex

Defines the zona output directory
Changes for snakefmt
Fix name of files in resources for zona
Added anticipated path for anat segmentation for transformation purposes between different MNI spaces and subject native space
        These files are available locally at the moment, but are too big to be added to the git repo
Add transformation to rule to define an transform matrix

All rules have also been updated to make use of functools.partial.
An additional note - a couple of files needed for transformation is too large to be shared via this repository and after a brief discussion, look into downloading it as part of the container build / point users to download location. Need to discuss with @jclauneuro to see what best option is here (files are SNSX32 related, namely T1w and subcortical segmentations in MNI152NLin6Asym and MNI152Nlin2009b space)
Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionalitiy)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

[ ] Changes have been tested to ensure that fix is effective or that a feature works.
[ ] Changes pass the unit tests
[x] Code has been run through the poe quality task
[x] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

Syntaxes and workflow bugs have been fixed as of c5b4856. Also did a dry-run through the workflow to ensure it works (although labelmerge not added yet).

@tkkuehn Above changes should be fixed. I also found a few other workflow piping issues that need to be corrected for when I was adding in resources and logs. Will throw that in a separate PR.


/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found

mihoro: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by mihoro)` occurs when running mihoro setup.

Please try the musl variant.
https://github.com/spencerwooo/mihoro/releases/download/v0.4.0/mihoro-x86_64-unknown-linux-musl.tar.gz


Update bugs in UG and DG

Codecov Report

Merging #196 (6659910) into master (473a424) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
+ Coverage     66.02%   66.09%   +0.07%
- Complexity      699      705       +6
============================================
  Files           131      131
  Lines          2487     2501      +14
  Branches        327      330       +3
============================================
+ Hits           1642     1653      +11
- Misses          714      715       +1
- Partials        131      133       +2

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/driver/Driver.java
84.21% <0.00%> (-6.70%)
:arrow_down:

...eedu/address/logic/commands/EditDriverCommand.java
91.66% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
97.22% <0.00%> (+0.12%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
93.81% <0.00%> (+0.19%)
:arrow_up:

...a/seedu/address/model/driver/UniqueDriverList.java
56.81% <0.00%> (+3.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473a424...6659910. Read the comment docs.


Bug with custom order functions for relay connections

Hi guys, I’m trying to configure a custom sort with a stored postgres function, and it works for me when i just query things, using the .Order(…) func generated for every model, but the problem is with .Paginate(..) generated function for querying a relay graphql connection, when i use the .Order(…) before the .Paginate(…) I’m getting an error for the count query (which is running to get the totalCount of the relay connection)
2022/12/07 15:03:16 driver.Query: query=SELECT COUNT("catalog_package_version"."id") FROM "catalog_package_version" WHERE "catalog_package_version"."catalog_package_id" IN (SELECT "catalog_package"."id" FROM "catalog_package" WHERE "catalog_package"."name" = $1 AND "catalog_package"."type" = $2) ORDER BY versions_sort(version) DESC args=[axios npm]
  resp: {
    "errors": [
      {
        "message": "ERROR: column \"catalog_package_version.version\" must appear in the GROUP BY clause or be used in an aggregate function (SQLSTATE 42803)",
        "path": [
          "packageVersions"
        ]
      }
    ],
    "data": null
  }
  error: packageVersions: ERROR: column "catalog_package_version.version" must appear in the GROUP BY clause or be used in an aggregate function (SQLSTATE 42803)

}
What I don’t get is, why would the order by be ever added to the count query?… it’s pretty redundant to order when you count

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Order by section is added to the count query
Expected Behavior 🤔
Order by section should be excluded from the count query

Your Environment 🌎

Tech
Version

Go
1.19.3

Ent
0.11.0

Database
PostgeSQL

Driver
https://github.com/jackc/pgx

duplicate of https://github.com/ent/ent/issues/2807

What I don’t get is, why would the order by be ever added to the count query?… it’s pretty redundant to order when you count

I waited for your PR after our discussion on Slack 2 months ago 😅
I'll send a patch to fix this later today. Thanks for reporting this.

Closed with https://github.com/ent/ent/pull/3226.


Allow splitting JS & CSS

Thanks for this useful library!
I’ve noticed including the {% vite_asset %} tag at the end of the document body creates a flash of unstyled content.
This PR allows outputting the styles and the scripts separately so you can put the styles in the head section and the scripts at the end of the body. It is also backwards compatible and the existing {% vite_asset %} tag can still be used as-is.

Hi,
When do so see a flash ?
In production mode, a basic link tag is generated for CSS so it should not flash and you should not put your vite_asset in the <head> because of how ViteJS produce its compiled JS.
ViteJS produce module JS that are defer by default meaning that it will be executed after DOM loaded (same as putting your script at the end of the <body>).
If your users use older version of browser please refer to https://github.com/MrBin99/django-vite#vite-legacy-plugin to mitigate this problem.

Ah yes, you’re right. Maybe it could be mentioned in the readme that the vite_asset tag should be put in the head?

Yes, you're right. I was sure to have written it but I only mentioned it implicitly because it is one of the feature of ViteJS.
And I imply that someone who use django-vite have read the ViteJS doc.
But I will mention it explicitly in the doc, thanks.


upgrade lz4_flex to 0.8

It does not seem to build, can you have a look? @PSeitz

@fulmicoton my "improvement" before committing didn't seem to work, should work now


Cost change Due to SQL License Downgrade

[It would be very helpful if its very clearly mentioned that even if we downgrade the license, that is by uninstalling the SQL and reinstalling the free  ( Developer ) or downgraded version of SQL as long as the SQL License type is not changed in the Azure Portal , it would be charged on the old pricing version. Currently its not very clear and it has impacted the billing , even though at the OS level we downgraded the SQL to Dev version but we were still getting charged for Standard version as after doing the downgrade the license type was not changed in the Azure Portal. May be Azure Portal should auto detect that but as long as that is not the case. So it should be very clearly highlighted  ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e312b6b-d5a9-6653-92ff-80494123a536
Version Independent ID: 59867322-724a-7df3-95f4-10562fe6fdbd
Content: In-place change of SQL Server edition - SQL Server on Azure VM
Content Source: articles/azure-sql/virtual-machines/windows/change-sql-server-edition.md
Service: virtual-machines-sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@manishjha2088 Thanks for the feedback. We are investigating the issue and will update you shortly.

Hi @manishjha2088 , thanks for your feedback! We document that here

here:

Do you have feedback for how we could present this information better?
Thanks!
Masha from the SQL Docs team

@manishjha2088 Hope that helped answer your question. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


MGMT-15507: Set restricted list of approvers for protected release-ocm-2.9 branch

/cc @filanov @gamli75 @romfreiman

opened https://github.com/openshift/assisted-image-service/pull/150

/close


Nice one!

Nice one @lexmag!
redix_pubsub will be shared in our next RedisWeekly!

Thanks on behalf of @lexmag I guess? :)


Issue with NPM installing

When I enter:
meteor npm install react-stepzilla --save
I get:
npm WARN<EMAIL_ADDRESS>requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none was installed.
I have webpack 2.3.3 installed, any ideas?
Thanks

@BrianSHenderson I've seen this somewhere, does it make StepZilla behave weirdly? as it's just a warning it may not.

I'm afraid I couldn't get it to work

@BrianSHenderson is this still an issue?

Found another way around the problem


rbd: use the new format of the daemon name

This will allow the ceph -s to classify the daemon names we report
by using the gateway names instead to simplify the ceph -s output.
We will keep the service name to make sure it won't break the ceph
dashboard and the third part apps.
Fixes: https://tracker.ceph.com/issues/49057
Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

The output in ceph-iscsi will be:
# curl --insecure --user admin:admin -X GET http://<IP_ADDRESS>:5000/api/disk/rbd/block2
{"allocating_host":"lxbceph3","backstore":"user:rbd","backstore_object_name":"rbd.block2","controls":{},"created":"2021/02/03 02:50:04","image":"block2","owner":"lxbceph3","pool":"rbd","pool_id":8,"status":{"gateways":{"portal/lxbceph2":{"cmd_timed_out_cnt":0,"conn_lost_cnt":0,"lock_lost_cnt":0},"portal/lxbceph3":{"cmd_timed_out_cnt":0,"conn_lost_cnt":0,"lock_lost_cnt":0}},"lock_owner":"","state":"Online"},"updated":"2021/02/03 02:51:42","wwn":"fda9f699-4cc8-4ae2-a6c1-8620bad79bcc"}

# curl --insecure --user admin:admin -X GET http://<IP_ADDRESS>:5000/api/disk/rbd/block1
{"allocating_host":"lxbceph2","backstore":"user:rbd","backstore_object_name":"rbd.block1","controls":{},"created":"2020/12/25 01:27:15","image":"block1","owner":"lxbceph2","pool":"rbd","pool_id":8,"status":{"gateways":{"portal/lxbceph2":{"cmd_timed_out_cnt":0,"conn_lost_cnt":0,"lock_lost_cnt":0},"portal/lxbceph3":{"cmd_timed_out_cnt":0,"conn_lost_cnt":0,"lock_lost_cnt":0}},"lock_owner":"","state":"Online"},"updated":"2020/12/25 02:25:45","wwn":"24dfcf4b-b552-4d13-b66b-1bbb5eff45e1"}


Add Haskell IDE Engine (hie) support

This PR should address the issue #1578.
I don't think it is ready to merge yet.
For me, hie is working in a stack project or on a single file. I don't know about cabal projects (it shouldn't because it only searches for "stack.yaml", maybe I should search for the nearest "*.cabal" file too ?).
Help is appreciated :beer:.
TODO list:

[x] Make a function to find the nearest file corresponding to *.cabal
[x] Do more testing on plain GHC project (no file to identify them)
[x] Add tests for hie

Everything should be good now !
This is how a project is found: it searches for a stack.yaml, if it doesn't find it, it will search for a *.cabal file and if it fails again, it will use the buffers directory.

Cheers! :beers:

Cheers! :beers:


⚠ Jenkins Plugins Artifactory has degraded performance

In 02051e7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1175 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 45e72ff after 40 minutes.


Dont use init

Given recent precompilation concerns it would be better not to use and recommend using __init__ here.
Instead pynew() could have a runtime value check, and do the import automatically on the first call?
We could pass it a string for the module name, or a closure.

Nice idea.
Would be good to investigate if adding such a check has any performance penalty, since it will be done for every

Was this actually implemented?

No, I guess I hit the Close button by mistake!

@cjdoris is there any benchmark suite of yours? I'd like to test a few a ideas for such lazy-loading mechanism.

Just https://github.com/cjdoris/PythonCall.jl/blob/main/BENCHMARKS.md which may be out of date. Might be nice to formalise them.

IMO this is still relevant, it should be re-opened and added to a milestone so that it is not automatically re-closed as stale.

Auto closing issues afyer 30 days doesnt really make sense, Im not going to keep pinging all my githib issues

Marking stale due to inactivity is a questionable practice. Issues that are not fixed don't just go away.
There is no chance I will work on this, it was basically a "heads up" issue for future design.

Like I said, issues which are actual issues I can label so they stick around, like I did with this one.
The bot is to close the issues that aren't actually issues - such as because it actually got resolved or the user didn't provide a way to reproduce the issue.

Issues can be closed from PRs using e.g. closes #x . Or manually if they dont matter.
Butvauto closing will end up with discussions like this - there is a reason almost no other packages do it. But your call of course.


Using Cobra/Viper

Hi...
i was reading the project and realized that parsing command line and configuration codes are in daemon/main.go file. How you think about separating daemon and project bootstrapping logic and use some packages like github.com/spf13/{cobra,viper}?
thanks

Hello,
Thanks for you contribution. I reviewed Cobra and Viper and they seem like a good fit. But one thing  regarding Viper is that if we wan't to implement it in order not to break backwards compatibility we will need to have our layer above Viper which will totally defeat purpose of Viper.
Also i don't mind increasing major version and start working on 2.0.0 but before that i would like to review couple more things which can be implemented in major version update
If you have more suggestions regarding this i'm open for discussion


hiredis dependency preventing using node versions > 10?

Hi,
I'm currently looking to use cote for a project running node 16.
I've found that to be able to install cote I need to be running node 10 and i need to manually install hiredis which is a dependency of a dependency (redis-parser) of a dependency (node) of a dependency (@dashersw/node-discover).
I was wondering what the likely hood of that base dependency (@dashersw/node-discover) being updated to use newer versions is? looking at the package.json for these packages it is no longer dependant on hiredis
Thank you
For anyone facing issues with node-gyp trying to use this package.
The work around that I have been using is to downgrade to Node 10.24.1, run npm i hiredis and then change back to the version of Node that I am using.

Hello @andrewcartwright1, I'm not sure I understand you correctly—cote installs and works well with node 16, and there doesn't need to happen any manual installations. As far as I can see, installing cote doesn't install hiredis in your package-lock.json.

Hi,
Thanks for getting back to me. So the issue that I was having at the time of writing this was..
I had done a npm install for cote and than ran Webpack dev server, this kept failing due to an issue with hiredis being missing.
I later traced this to some of the dependencies in cote requiring it.
I managed to resolve the issue by adding the hiredis dependency on a lower node version.

I see, but if any dependencies of cote required hiredis, we would have seen it in package-lock.json. As far as I can tell, a clean install of cote doesn’t require hiredis.


Sorting deltas

The deltas aren't sorted in any way.
When a peer has changed data during its offline period and other (online) peers have altered data for that item too in that period the delta of the offline peer is added to the end of the array of deltas when that peer comes online after the changes of the online peers.
That way the change of the offline peer will be seen as the last delta, which is not expected behaviour.
By sorting the delta array based on the timestamp this issue will be resolved.

Probably fixed by default sorting deltas by timestamp. Oldest comes last.

Seems good


doc: update docs to clarify clang16 is needed

We have accidentally needed this, but really I rather do this than roll back recent concept changes to barretenberg. As clang16 continues to improve C++20 spec compliance, and we now need it, we should document this.

hey ludamad, I'd be happy to check this one out. I think it could be a great place for me to start getting a feel for the project as I explore with i

Hey there Tommy. I'm happy for you to take this one on. We'd want to start with the README.md's in circuits and circuits/cpp/barretenberg, as well generally do a pass on anywhere clang is mentioned in the repo and see if it can be updated.

As well, if you're so inclined, you can check out the current docs folder (yarn && yarn build && yarn serve) and see if there's something we can add there

@tommymaher15 Any updates here? Anything you need / need this assigned to someone else?

This is now done


Problem_Statement_47

Write a program to alphabetically sort a set of names entered by the user .

I am Mahevash Patel student at CCOEW pune, I want to work on this issue may you please assign it to me

You have been assigned another issue already! If no one asks for this issue, you will be assigned this issue after you complete the first one(after PR is merged)

I'd like to work on this issue.
Nandana Nair CCOEW
SY-E&TC

Very first this issue was assigned to me before the 2nd assignment and I have started working on this issue

@MashTerro We are sorry but this issue is not and will not be assigned to you as you already have other issue assigned and we specifically mentioned that requests after October 1 starts will be counted as mentioned in the instructions. So, please stop working on this issue as your PR will not be accepted.

@MashTerro We are very sorry but this issue is not and will not be assigned to you as you already have another issue assigned. We specifically mentioned in our mail that only 1 issue at a time. Please stop working on this issue as your PR will not be accepted.

@Nandana1911 submit your code in "Solutions" folder. Deadline is 3 Oct'21, 11 : 59 pm

A gentle reminder @Nandana1911, You need to create your PR by 11: 59 today otherwise this issue will be assigned to someone else! Also make sure you mention this issue in the comment of that PR.

@Krush2311, can you please assign this issue to me after today 11:59 pm, I have submitted my first issue


feat: Add a rate limiter for the backfill executor

Is your feature request related to a problem? Please describe.
Currently, the backfill executor consumes snapshot side messages as quickly as possible, which may result in producing an overwhelming amount of messages and causing downstream back pressure, ultimately affecting the entire streaming graph. To prevent this issue, I propose implementing a rate limiter for the backfill executor to regulate the snapshot reading flow. The rate limiter would require us to set a quota, such as 10K rows per second. Ideally, users would be able to modify this configuration during backfilling, but it seems that passing config changes through barriers may not be feasible. Another solution would be to apply the configuration changes only to the new backfill executor (i.e., the new MV on MV), or to apply the changes on cluster restart, although this may not be ideal.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

Related issue #8177


OATH Gardening

This PR is a set of small fixes/enhancements to OATH that I have noticed over the last few weeks.

[x] Don't push to Allure reports in pipeline if an agent issue happens and tests don't run.
[x] Update acapy docker build from aries, and move container to python 3.12.
[X] Extend wait for agent status to 60 seconds and if agent container shutdown don't let curl hang waiting for a response.

This is ready. I want to get this into the main repo so I can manually kick off a couple workflows, one passing (acapy) and one failing (credo) to make sure the workflow conditions are correct for submitting to the reporting service. If it works, I'll do another PR to update all workflows with the same logic.


fix: Allow network policy based on signal type

Description
Changes proposed in this pull request (what was done and why):

The allow list of ports in network policy should be based on signal type for agents and gateways
Allow scraping from istio envoy ports as well.

Changes refer to particular issues, PRs or documents:

https://github.com/kyma-project/telemetry-manager/issues/614
https://github.com/kyma-project/telemetry-manager/issues/536

Traceability

[x] The PR is linked to a GitHub issue.
[ ] New features have a milestone set.
[ ] New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
[x] The corresponding GitHub issue has a respective area and kind label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.
[ ] Adjusted the documentation if the change is user-facing.
[x] The feature is unit-tested
[x] The feature is e2e-tested

tested with cur to the podl by running a busybox container in k3d cluster and it works fine
curl -v http://xx.xx.xx.xx:15090/stats/prometheus

/test all

/test all


Replace ogier/pflag with spf13/pflag

Also, go test from a clean clone is broken:
./flag_test.go:100: undefined: ResetForTesting
./flag_test.go:101: undefined: GetCommandLine
./flag_test.go:228: undefined: ResetForTesting
./flag_test.go:229: undefined: GetCommandLine
./flag_test.go:283: undefined: ResetForTesting
./flag_test.go:288: undefined: GetCommandLine
FAIL    _/home/mvdan/git/pflag [build failed]

I'm not entirely sure why, since the functions are defined in export_test.go. Perhaps move them into flag_test.go?


Robot Name v3

Changed class names, added better exception handling, refactored Registry class to not incorporate instance variable

@Manbearpixel Discussed that a pairing would be good, and a resubmit after that.


Mark Object as code

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Serialize and deserialize

Is there a reliable way to convert a Process[IO, _, _] to a string and back?

Not really as the attached input/output/error streams are also part of the process value.

Suppose I have a string and I want to execute it as if it were a bash script, in the current working directory. One option is to write it to a tempfile and execute it that way, but perhaps there is a better way?


Issue 3632 - modify float is float to do a bitwise compare

Make 'is' between floats and structs containing floats consistent at run-time and compile-time.
This fixes the padding issue of the previous fix.
http://d.puremagic.com/issues/show_bug.cgi?id=3632
@9rnsr This includes your fix for 3789 from pull #387 - if you can put those changes into a single commit I'll rebase on top of that instead of copying your fix.

Actually never mind it need phobos changes too, I'll just remove the == test cases.

Had to revert the rest, too. xtest46.d fails on OSX. Patch needs more work & testing.

Yeah sorry, I needed to cut out the == part and hadn't done it yet.  Doing it now.

https://github.com/D-Programming-Language/dmd/pull/730

this pull request also clearly failed in the pull tester so was a bad candidate for merging:
http://d.puremagic.com/test-results/pull-history.ghtml?projectid=1&pullid=724

Yeah, even when the master branch is broken, the pull history should show that the pull passed with earlier versions.
if (walterReviewPassed)
{
    if (pullTesterState == passing)
        pull();
    else if (masterTesterState == failing && pullTesterHistory == good)
        pull();
    else
        dontPull();
}
else
{
    rejectPull();
}

if masterState == failing goFixMasterAndQuitLookingAtPulls();

There is still a delay between master getting fixed and the pulls moving back from red to green.


Updated gradle file

Updated gradle file as per Android Studio 3 & latest sdk
Change Note:
Added google dependencies in 'dependencies' section

Updated gradle file as per Android Studio 3 & latest sdk
Change Note:
Added google dependencies in 'dependencies' section


Wrong Postition for Channel Tags

commit d03a34d343e085254fb40e054f5500e9700ac9b7 already fixes that, try to reload discord

FIxed now, but now a new problem emerges.

The # appears to be in the wrong size

if you mean the size is small, that was intentional
if you are talking about the position it should be fixed now, will look like this:

ehhh... new problem.

lol
fixed


Simple theme assets not exposed / composer.json is different when re-installing themes

Affected Version
phpunit/phpunit            5.7.27             The PHP Unit Testing framework.
silverstripe-themes/simple dev-master e4b3aa2 The SilverStripe simple theme (default SilverStripe 3 theme)
silverstripe/recipe-cms    1.1.1              SilverStripe recipe for fully featured page and asset content editing
silverstripe/recipe-plugin 1.2.0              Helper plugin to install SilverStripe recipes

Description
When re-installing the simple theme with composer, you're unable to expose the assets (css, js, webfonts) through composer vendor-expose.
When using composer create-project the them installs and the assets are exposed. But removing the theme using composer remove and then re-installing it using composer require mean it has a different composer.json file and is missing the extra metadata.
Steps to Reproduce

Create project

composer create-project silverstripe/installer myproject

Run through silverstripe installer
View home page correctly displaying the simple theme

composer remove silverstripe-themes/simple
composer require silverstripe-themes/simple
composer vendor-expose

Note: nothing from the simple theme is exposed.

Load the home page.

Initial composer.json when installing with create-project:
{
    "name": "silverstripe-themes/simple",
    "description": "The SilverStripe simple theme (default SilverStripe 3 theme)",
    "type": "silverstripe-theme",
    "keywords": ["silverstripe", "theme"],
    "license": "BSD-3-Clause",
    "authors": [
        {
            "name": "Sara Tušar (Innovaif)",
            "homepage": "http://www.saratusar.com"
        }
    ],
    "require": {
        "composer/installers": "*",
        "silverstripe/framework": ">=3.5"
    },
	"extra": {
		"branch-alias": {
			"dev-master": "3.2.x-dev"
		},
        "expose": [
            "css",
            "images",
            "javascript",
            "webfonts"
        ]
	}
}

composer.json when installing with composer require:
{
    "name": "silverstripe-themes/simple",
    "description": "The SilverStripe simple theme (default SilverStripe 3 theme)",
    "type": "silverstripe-theme",
    "keywords": ["silverstripe", "theme"],
    "license": "BSD-3-Clause",
    "authors": [
        {
            "name": "Sara Tušar (Innovaif)",
            "homepage": "http://www.saratusar.com"
        }
    ],
    "require": {
        "composer/installers": "*",
        "silverstripe/framework": ">=3.0"
    }
}

ah... This is just because we're pulling in dev-master from the recipe. Can the theme have a stable release?

@micmania1 How is this related to pulling in dev-master?

@chillu When you run composer create-project it seems to pull in an "unstable" (the latest) version of the simple theme.
When your remove it and run composer require silverstripe-themes/simple it'll pull in the latest stable version which only works with SilverStripe 3, not 4.

@andrewandante raised an issue this morning for this: https://github.com/silverstripe-themes/silverstripe-simple/issues/56

I've tagged 3.2.0 of simple theme; hopefully this is fixed by that


Fix images rendering on Firesite for Stripe extension

Not sure where to track this but let's fix Stripe's images by the next release.

fixed for both Stripe extensions:
https://firebase.google.com/products/extensions/firestore-stripe-invoices
https://firebase.google.com/products/extensions/firestore-stripe-subscriptions


typing custom element lifecycle callbacks

I've added types for the four custom element lifecycle callback methods.
If I've read the spec correctly, ideally we would also like to be able to stipulate that

the value of ElementRegistrationOptions.prototype should be an object which includes either HTMLElement or SVGElement in its prototype chain.
the return value of document.registerElement() will be a constructor for a subclass of HTMLElement or SVGElement or the descendent named in (1).

Does anyone know how this could be expressed in Flow?

I am a little confused about the failing tests. Can anyone give me a hint?

Here's a gist of my attempt to enforce inheritance from HTMLElement with an intersection type. It seems that Flow is unaware that the value for the prototype key has inherited HTMLElement's methods through the call to Object.create().

some of them look like bogus race conditions so I'm re-running the tests. the dom, taint and taint-lib failures are because the tests work by comparing flow's output (tests/testName/testName.out) to the expected output (tests/testName/testName.exp), which includes line numbers, and your change adds lines so it pushes everything down. just cp .out to .exp if the changes are legit.

they could also be because dom.js has changed a couple times, so make sure you rebase

@facebook-github-bot import

I'm rebasing this and updating the tests. I also changed the void return type to mixed. We've been trying to be better about doing that since most APIs don't look at the return value, and it's sometimes convenient to return a value because of arrow functions (e.g. doStuff(() => somethingThatReturnsAValue()))
Also, to be really pedantic, I think the attributeChangedCallback should actually be overloaded since oldAttributeValue and newAttributeValue can't both be null at the same time, and the ?string args should probably be string | null since values are always strings, and namespaces are null | string. but I'm not even sure offhand how you overload object properties like that. Feel free to send a followup PR if this sounds worth looking into.

On void vs. mixed: this is a really strange API with a lot of footgun potential, and the reason I wanted to type it was to put a very restrictive fence around it.
these callbacks are intended to be methods, not functions. They perform side effects, rather than returning values; they should never be called by the user and nobody should ever depend on their return type.
the calling convention is strange compared to ES6 classes, and will look like either:
```
document.registerElement(
  'custom-element-name',
  prototype: Object.create(
    HTMLElement.prototype, {
      createdCallback: { value: function createdCallback() {...} },
      attachedCallback: { value: function attachedCallback() {...} },
      detachedCallback: { value: function detachedCallback() {...} },
      attributeChangedCallback: { value: function attributeChangedCallback() {...} },
    }));
```
or
document.registerElement(
  'custom-element-name',
  prototype: Object.assign(
    Object.create(HTMLElement.prototype), {
      createdCallback() {...},
      attachedCallback() {...},
      detachedCallback() {...},
      attributeChangedCallback() {...},
    }));

these callbacks must have a this for document.registerElement() to bind to the DOM element instance, so using an arrow function would be semantically wrong.
On string | null vs ?string: agreed.
On the signature of attributeChangedCallback: I agree that there is an interdependency between the parameters that isn't captured by this annotation, but I have trouble imagining errors that could be prevented by a more precise type or ergonomics that the inference engine could extract. That said, and if we want to try anyway, maybe a union type would work?
attributeChangedCallback: void | (
  attributeLocalName: string,
  oldAttributeValue: string,
  newAttributeValue: string,
  attributeNamespace: string | null
) => void | (
  attributeLocalName: string,
  oldAttributeValue: null,
  newAttributeValue: string,
  attributeNamespace: string | null
) => void | (
  attributeLocalName: string,
  oldAttributeValue: string,
  newAttributeValue: null,
  attributeNamespace: string | null
) => void;

Do you have any thoughts on the matter of enforcing the relationship between the return type of document.registerElement() and the prototype of the ElementRegistrationOptions object?

@AprilArcus Thanks for sending this PR and especially thank you for explaining the choices you made so lucidly.
On the void vs. mixed discussion, I think you make a very good case. To paraphrase, the reason to go with mixed is because we get a lot of feedback that brace-less arrow functions should be allowed, even though they have a non-void return type, because the caller ignores the return value. It seems that in this case, arrow functions would be a bad idea in the first place, since we want to use the re-bound this. I could go either way on it, but I just wanted to note my appreciation of your perspective here.
I was curious about the overloaded signature for attribute changed, so I wrote up a small test to see how Flow might behave:
/* @flow */

function foo(delegate: {
  attributeChanged:
    ( ((oldValue: string, newValue: string) => void)
    & ((oldValue: string | null, newValue: string) => void)
    & ((oldValue: string, newValue: string | null) => void) )
}) {
  delegate.attributeChanged("old", "new"); // ok
  delegate.attributeChanged(null, "new");  // ok
  delegate.attributeChanged("old", null);  // ok
  delegate.attributeChanged(null, null);   // error
};

foo({
  attributeChanged: function(oldValue, newValue) {
    if (oldValue == null) {
      (newValue: string); // not that smart -- we still think newValue can be null
    }
  },
});

As you can see, the overloaded signature is only really useful if you're going to call the method, which nobody would do here, since it's library code. It doesn't help guide implementations, so I think moving to an overloaded signature would actually be worse, due to the consequent degradation in error messages.
@mroch Let me know if I can help push this through.

I added some tests that should fail (passing an unrecognized callback, or attempting to use invalid params), but they are currently passing (maybe due to Object.assign() or Object.create() upcasting to any?)

By looking at the test fixtures I feel that this (flowtry) should work:
class Foo extends HTMLElement {
  attributeChangedCallback(
    localName: string,
    oldVal: string, // Error: This might be null
    newVal: string, // Error: This might be null
    namespace: string) {}
}

document.registerElement('foo', Foo);

However, flow 0.28.0 is reporting no errors.
But this (flowtry) reports an odd error:
class Foo extends HTMLElement {
  attachedCallback(): mixed {}
}

document.registerElement('foo', {prototype: Foo.prototype});

4:   attachedCallback(): mixed {}     ^ method `attachedCallback`. This type is incompatible with
/static/flowlib/dom.js:372:     attachedCallback?: () => mixed;
                                                   ^ undefined


Add logo of new silver sponsor and remove old platinum

main landing page sponsor section changes:

new silver is https://www.svix.com/ - brand logo -> https://www.svix.com/press/
remove IQVIA as platinum

context why IQVIA should be removed:

hey, i would love to contribute to this issue if anyone is not assigned for this please

can i work on this issue please

@muhammedanaskhan there is a open PR for it already.
You can try working on some other issue.


add macro output test for object wrap

Needed some changes to the test runner

Codecov Report
Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (0c7f83e) to head (e1c5ea2).
Report is 198 commits behind head on main.

Files with missing lines
Patch %
Lines

ops/op2/mod.rs
97.36%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   81.43%   81.85%   +0.41%
==========================================
  Files          97       98       +1
  Lines       23877    25919    +2042
==========================================
+ Hits        19445    21215    +1770
- Misses       4432     4704     +272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Avoid flatpak_module_tools v0.13, requires python3.9

This mirrors a change in test.sh.
Signed-off-by: mike kingsbury<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Can you please also remove the mirrored change from test.sh? Thanks.

Code removed from test.sh.

:+1:

No release notes needed


Error message when clicking on "older" (after page 2)

@cm805 Did you say you added some screenshots to this issue?  If so, you may not have submitted the comment.

Once you are on page 2 click "older"

@jlouis-onrr @mojobnichols I took a look at this and it's not something I could figure out, so we need developer help.


Markdown syntax highlighting should ignore math inside $$

VSCode Version: 1.12.2
OS Version: macOS Sierra 10.12.5

Steps to Reproduce:

Create a markdown document and use inline LaTeX (e.g. $a_{b}$) for math.
VSCode interprets the markdown underscore to mean italic text -- instead of math subscript -- and will make the markdown text italic until it sees a matching underscore delimiter.

I think this is behavior is theme dependent, but I'm not sure. Changing themes just changes how the text between the underscores is rendered (italic or colored or whatever). I believe that markdown delimiters (_ and *) in math mode should be ignored the way they are in code blocks.

The builtin markdown extension targets commonmark which does not support that syntax.
An extension may be able to extend the builtin markdown grammar using an injection similar to https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example or the extension could provide its own markdown grammar that includes math support in its grammar

I'm not sure I see how the injection can be used in the example you linked. (It looks like it calls source.js to change what happens inside superjs code blocks, AFAICT.) In lieu of an extension, is there a way to turn off syntax highlighting _ in the theme? That may be simpler for now.

Instead of injecting to the fenced code block rules like in the linked example, you would want to add an  injection for the latex grammar to #paragraph in this case.
The syntax highlighting is up to the grammar. You can customize the grammar if you want to handle _ specially for markdown

I think I can figure out how to do this with a couple more clues. If I use your codeblock.json as a template, I assume I'll have to change the injectionSelector to something for inline LaTeX. Where are the list of these grammars (i.e., where did you get markup.fenced_code.block.markdown)? Also, I'm still not clear what happens with "include": "source.js". Is this the file that controls syntax highlighting for the injected grammar inside the begin and end patterns? Would I have to pull this from an extension for LaTeX?


Restore socok8s integration job (SOC-10434)

Job was mistakenly deleted, restore it

If it was deleted, can't you revert the commit that did it?

If it was deleted, can't you revert the commit that did it?

Not really, not without modifications to that commit, hence I rather have a new commit with just the restore. Lets not complicate it.

This is causing Jenkins to show an exception when visiting the jobs page and other subpages.
It started out beginning with java.lang.ClassCastException: hudson.model.ParametersDefinitionProperty cannot be cast to com.cloudbees.hudson.plugins.folder.AbstractFolderProperty and continuing as a normally long one.
Now it changed to just java.lang.ClassCastException, nothing more.

A similar problem happened in https://github.com/SUSE-Cloud/automation/pull/3433 .


add http-request del-header

add http-request del-header to remove an HTTP header from a request before relaying it to a backend

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 68.8%

Totals

Change from base Build<PHONE_NUMBER>1:
0.2%

Covered Lines:
1376

Relevant Lines:
2000

💛  - Coveralls


Use knative-sandbox teams for sandbox repos as assignees

We are seeing the following on some update nightlies PRs:

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/eventing-wg-leads.
Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

For example on https://github.com/knative-sandbox/eventing-istio/pull/31#issuecomment-1598571578.
This PR uses the knative-sandbox groups for assignees for knative-sandbox projects.

/assign @pierDipi


CrudTrait PHP 7.2: count(): Parameter must be an array or an object that implements Countable

Bug report
hi everyone =3
What I did:
install php7.2
What I expected to happen:
count(null): 0
What happened:
count(null): Parameter must be an array or an object that implements Countable
at count(null)in CrudTrait.php (line 83)
What I've already tried to fix it:
workaround by downgrading to php7.1
Backpack, Laravel, PHP, DB version:
backpack/crud                         3.2.22
laravel/framework                     v5.4.36
PHP 7.2
mysql  5.7.20

"backpack/crud": "^3.2"
upgrading to
"backpack/crud": "^3.3"
fixed my issue

Hi @Darival  - thanks for sharing the solution!

Thanks @Darival same issue to me. backpack/crud upgrade solves for me as well 👍

I Still have This Issue..


Release zip file has repeated "taskkill" in KillHidden.vbs whereas the repo code does not

Concerned File:
KillHidden.vbs
Description:
I was digging into why the GroovyRP was not closing when I closed Groove, and here's this weird thing I found:
The KillHidden.vbs in the zip file from the Release page contains the code as shared in the below screenshot:

Whereas the code for the same file is correct one in the repository here:
https://github.com/jojo2357/Music-Discord-Rich-Presence/blob/0799aff3df3ef4c9f756e1969c6d206725ee8381/GroovyRP/bin/Release/KillHidden.vbs#L2 :

Doh! I had just found and fixed it guess i forgot to make a release.

Confirm 1.4.0 fixes this then close or lmk

yes, 1.4.0 fixes it!


2023.3.x feature open record in modal

Screenshots of the Implementation

Image 1 - Additional setting "Record Display Options" (select dropdown) in the record list page block

Image 2 - Displaying a record entry as a modal
Changelog
What was added?
When adding a "record list" page block in the Compose page builder, a dropdown field has been added with three options:

open record in the same tab
open record in a new tab
open record in a modal

The default option is to open in the same tab.
Note: The first two options already existed and are handled gracefully, e.g. respected for existing record lists
The new thing here is the third option - "open record in a modal". When this option is selected and the user goes to a record list page or a page that displays record lists, he can click on a specific record and it will open as a modal. From the modal, the user can do whatever he wants with the existing record (edit, delete, clone) or even add a new record.
How it was added?
In the Compose app, a root event was emitted from the RecordList component that emits an event with all the necessary information to a new modal component, which has been called from the public page. The modal is then able to display the record and its information. In order to do this, instead of using routes, the ViewRecord component is added as a child component to the modal and it receives its props from the modal itself.

Closed due to Monorepo Migration


Reorganize/update CI testing

Add osx (using osx_image to get a recent osx version).

Switch to language=generic from language=python. Travis's python was not previously being used (conda is being used), but travis's python was still being installed. Apart from being unused, travis's auto-installation of python on osx fails.

Drop python 3.4. Python 3.4 has already effectively been dropped because it's been failing every time (allowed failure).

Some additional minor reorganization.

@jbednar, I requested a review thinking travis was about to finish, but it turns out travis is currently experiencing problems with its osx service. The push build has finished but the pr build is stuck in a queue. Sorry about that - you'll have to come back later...


Add constructor function

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.09%. Comparing base (c0b87a1) to head (385dafd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   95.00%   95.09%   +0.08%
==========================================
  Files          22       22
  Lines        1082     1101      +19
==========================================
+ Hits         1028     1047      +19
  Misses         54       54

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add RPM PR test job for Copr

This is in conjunction with:

https://github.com/theforeman/foreman-packaging/pull/9290
https://github.com/theforeman/obal/pull/344

The goal is to enable a scratch build for packaging PRs against Copr so that we can test and hone the workflow before starting to then perform release builds into Copr.

You can see a passing instance of this on the packaging project PR -- https://github.com/theforeman/foreman-packaging/pull/9290
This can get reviewed I feel, but ultimately must wait for the following to be merged:

https://github.com/theforeman/obal/pull/344
https://github.com/theforeman/foreman-packaging/pull/9290

I've tested this quite a bit, and tested the release job and therefore opting to merge so these jobs are running and I am getting build testing and getting release builds so that Copr stays up to date.


Option to modify the bootstrap urls in logview.ftl

Hi,
thanks for providing such a great addon. Would it be possible to replace the links to the bootstrap files in your logview.ftl?
Default is cdn-url, but it would be nice to be able to overwrite this in your configuration?
We have a very restrictive Content-Security-Policy in our environment, so I don´t want to use the maxcdn provider.
Thanks,
Jens

Hi Jens,
I'm glad you like my little project.
I agree that configuring external urls would be helpful. I'm thinking of having an (optional) list of urls in the config that completely overrides the external styles that are included. That would give you complete freedom to switch versions or to substitute your own design.
What do you think?
Lukas

Thanks Lukas for your response.
A first step would be to have these two urls configurable from outside via configuration, so that we can inject the href from outside- default would be your urls...
https://github.com/lukashinsch/spring-boot-actuator-logview/blob/master/lib/src/main/resources/templates/logview.ftl#L4
https://github.com/lukashinsch/spring-boot-actuator-logview/blob/master/lib/src/main/resources/templates/logview.ftl#L5
Sounds that reasonable to you? I want to have a quickwin now and include your addon very soon...

closed in PR #21

Just pushed a new release, should be available from maven central soon

Hi Jens,
v. 0.2.9 is available from maven central. let me know if it works for you.
Regards
Lukas

Thank you, Lukas. Works great!


Add /load [path] to load saved chat history

Allow users to load saved chat history. The command should read the txt file and load the chat history to the chat session

Solved this issue under JWoC.


Remove hotshot

Hotshot is not supported in python3 and we don't use the output in our tests now. Propose to just remove it and add cProfile stuff if we need profiling down the road.

Part of #7067


new synonym for abnormal hair follicle infundibulum morphology

Add:
abnormal hair follicle infundibulum morphology (MP:0010682)
NEW SYN: abnormal dermal piliary canal morphology
NEW SYN: abnormal dermal pilary canal morphology
SOURCE:  UBERON:0005968

Done.


Simulator Bug

Hello,
Thank you for your kindness.
I'm encountering an error with the simulation you provided.
When the robot pushes the block downwards, it vanishes under the desk. Here is the video showcasing the issue.
Thank you.

Unfortunately, this is a known problem of pybullet collision handling which is caused by high forces and a high mass of the robot arm. If you wanted to create your own simulation, you could try to reduce the robot's mass and forces, but this would change the simulation dynamics, so we won't change this. From our experience, these situations didn't happen often enough to pose a serious problem.


Credentials, Schemas, and More: Signing Config

Expose configuration for signing data. Including: key types, signature algorithms, envelope (VC vs VC-JWT) and more.

Handled in #123 #121 #118 follow up here #105


add ChatHistory & ChatMessage entity, SupportChatHub, MassTransit, Ch…

…atConsumer, VideoPaginationTests

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5e8a97d) to head (2a9972f).
Report is 49 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #75      +/-   ##
===========================================
+ Coverage   94.65%   100.00%   +5.34%
===========================================
  Files          77        48      -29
  Lines        1367       855     -512
  Branches      167       118      -49
===========================================
- Hits         1294       855     -439
+ Misses         73         0      -73

Flag
Coverage Δ

backend
?

frontend
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrapping a float in a ternary operator leads to wrong image being produced

[Shaders, screenshots, error log, reproduction steps, platform info, etc.] [ZIP]
In the shader, line:
vec3 p3 = from + (s3 + zoffset) * dir / (0.500 / 0.5);
becomes:
vec3 p3 = from + (s3 + zoffset) * dir / (0.500 / (injectionSwitch.x > injectionSwitch.y ? 0.5 : 0.5));
This small change causes the background to be more blue compared to the original. What is interesting in this case is that the value of injectionSwitch should not matter, as the ternary expression will always evaluate to the same value. Tested using Chrome and Firefox.
Recipient:

Variant:

Reported:
https://devtalk.nvidia.com/default/topic/982343/opengl/-bug-webgl-wrapping-a-float-in-a-ternary-operator-leads-to-wrong-image-being-produced/

Problem persists with driver version 378.13.

Fixed in driver version 381.22.


cells with 100% contamination?

Is it common for decontx to find many cells with nearly 100% contamination?  I get the following results (converted the contamination to percentage for readability).
quantile(result$decontX_contamination*100, probs=seq(0,1,0.1))
      =>
0%    0.00
10%   0.17
20%   0.41
30%   0.90
40%   2.02
50%   4.61
60%  10.43
70%  21.30
80%  34.85
90%  59.42
100% 99.95

This is using a vanilla call with no background and no labels, batch is simply the library. For one of the libraries there is a cluster with ~ 75% of the cells having > 90% contamination. Incidentally, there is a lot of erythrocyte contamination, but even if I discard all erythrocyte genes (not just hemoglobin genes), I still get a similar number of cells with very high contamination.

Hi @plijnzaad, thanks for the question. Do all of your cells in the dataset have close to 100% contamination or is it just the cells within specific clusters?
It may be helpful for us to see some of the diagnostic plots like plotDecontXContamination, plotDimReduceCluster, and plotDecontXMarkerPercentage. Sometimes the clustering can be an issue with very high levels of contamination and using an alternative set of cluster labels can help.

Hi Joshua,
thanks for your reply, I have attached a few images of 4 different libraries of related material, which was heavily contaminated  with erythroid cells and which I have tried to get rid in different ways passing it to decontx. I have blanked out names of the markers/cell types in the plotDecontXMarkerPercentage plot (of yet another related library) as this is a bit sensitive. All  samples have a few fairly clear immune cell clusters, and a big sprawling cluster of different celltypes of our tissue of interest.
clusters (decontx clustering) :

marker percentages:

before/after correction:

Thanks for sending these along. Overall, I think the results seem in line with what we have seen previously. Many of the markers are reduced in certain clusters as observed in the percentage barplots (although it is a bit hard to tell since I am not sure which markers are supposed to be expressed or not in each cluster).
There might be cases where better clustering would help. For example, in this sample where you see a group in which half of the cells have high contamination:

My guess is that these cells are all in the same cluster based on the density based clustering method DecontX relies on (but you can double check by plotting the decontX_clusters stored in the colData of the SCE object as described in the tutorial). If these cells were split into 2 clusters, then these cells may not have as high contamination estimates. You can try to tweak this in decontX by lowering the number of variable genes in the varGenes parameter (e.g. from 5000 by default to 2000) or by decreasing the clustering density parameter dbscanEps (e.g. from 1 to 0.5). You can also supply your own cluster labels via the z parameter.
The other possibility is that these sets of cells are doublets. We have seen in the past that doublet clusters get flagged with relatively higher levels of contamination.


[BUG]: Multiplayer matchmaking based on snippetId

Description
The Matchmaking logic is going to assign users to a race based on the randomly selected snippet, so if a lot of snippets exist on the language selected, two users are most likely never going to enter the same race.
Changing that to enter races based only on the same language would fix this.
the match making function:
async function raceMatchMaking(
  snippet: Snippet,
  userId?: User["id"],
): Promise<RaceType> {
  if (userId) {
    // For logged in user, we choose race if:
    // 1. its snippet is the same
    // 2. hasn't started or ended yet
    // 3. all participants are logged in user
    // 4. race's participants has not reached maxiumun capacity
    // TODO: 5. participants stats most suitable to current user

    let availableRace = await prisma.race.findMany({
      where: {
        snippet: {
          id: snippet.id,
        },

Why it's a problem:
  const snippet = await getRandomSnippet(searchParams.lang);
  // ...
  let raceToJoin: RaceType | null = null;
  //...
  //Fetch available races and join one. if there none, create one.
  raceToJoin = await raceMatchMaking(snippet, user?.id);

(optional) What browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm working on this


Accuracy analysis from fully labelled data of positives only

If you have a list of labels containing a comprehensive list of only the positives, it should be possible to perform accuracy analysis (ROC, precision recall, false positives, false negatives etc.)
i.e. if you have all the positive labels, then everything else can be assumed to be a negative

Notes from an investigation into this.
We currently have a method called block_from_labels, which will create all the record pairs for a set of labels

Easiest route is:

Assume that the input dataset has the labels (a clustered label column).  You can therefore add blocking on labels to ensure you get a splink score for all positives
Compute ROC by using the scored negative links from the blocking rules
Any comparison not created by the blocking rules gets an implicit splink score of 0.0


RemoteApp Window Size unable to change

if you start a RemoteApp for example:
xfreerdp /v: /d:DOMAIN /u:USER /p:'PW'  -floatbar /cert-ignore /rfx /gdi:hw +clipboard +aero +fonts /app:"||APP"
RemoteApp start as expected, but its not possible to handle the window, you could resize it to half of the monitor, so if you click anywhere other than the RemoteApp Window, the RemoteApp window  gets maximized...
Issue only exist in Plasma, Gnome is working.
thanks.

Well, which version did you try, which distro?
Did you give our nightly builds a try? https://github.com/FreeRDP/FreeRDP/wiki/PreBuilds


add wilc1000 WiFi module support on SAME54 platform

add wilc1000 Wi-Fi module host driver and SDIO driver to SAME54 MCU change clk from 48MHz to 120MHz

@xiaowenxia
The original Pull Request is #700
But you mention that the kernel code should be changed.
I fallback the kernel code change in this PR
I closed the PR #700 and use this PR instead.
Thanks
Ben


Modular output (items/url/etc)

I like the idea of plugins. I think a "plugin manager" from kristify in background would fit or not? It would in init phase search for plugins and give it the "plugin manager".


Aerodrome swap fees 20 deploy files

Contracts

Contract
Address

AerodromeAMOStrategy (implementation)
0x8bb67820E8aC1a775DA25E50391718C1457d07ac

Governance

Update the AMO strategy implementation

Check attachments for generated JSON files
1730157451105-scheduleBatch-gov-tx.json
1730157451106-executeBatch-gov-tx.json
Important!
I had to deploy the contract twice, because the first time I accidentally deleted the schedule transaction files. The second deployed contract doesn't show constructor arguments on Base. But it exactly matches the code deployed on this address: 0xfc96Ab53Dd1864B26C0DbC8534154B32ad434335. You can use this one to verify the constructor arguments (the Basescan also notices that the deployed bytecode of the contracts match)
Deploy checklist
Two reviewers complete the following checklist:
- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

I've verified the deployment

[x] All deployed contracts are listed in the deploy PR's description

[x] AerodromeAMOStrategy

[x] Deployed contract's verified code (and all dependencies) match the code in master

[x] AerodromeAMOStrategy

[ ] The constructor parameters are correct

[x] platformAddress, VaultAddress
[x] weth address
[x] OETHb address
[x] swapRouter
[x] nonfungiblePositionManager
[x] clOETHbWethPool
[x] gauge address
[x] sugarHelper
[x] lowerBoundingTick
[x] upperBoundingTick
[x] tickClosestToParity

[x] The transactions that interacted with the newly deployed contract match the deploy script.

[x] There are no txs outside the governance action

[x] Governance proposal matches the deploy script

[x] upgradeTo

[ ] Smoke tests pass after fork test execution of the governance proposal

sol2uml diff 0x8bb67820E8aC1a775DA25E50391718C1457d07ac .,node_modules -n base
Compared the "AerodromeAMOStrategy" contract with address 0x8bb67820E8aC1a775DA25E50391718C1457d07ac on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/Math.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/aerodrome/ICLGauge.sol
match   contracts/interfaces/aerodrome/ICLPool.sol
match   contracts/interfaces/aerodrome/INonfungiblePositionManager.sol
match   contracts/interfaces/aerodrome/ISugarHelper.sol
match   contracts/interfaces/aerodrome/ISwapRouter.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/strategies/aerodrome/AerodromeAMOStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/utils/InitializableERC20Detailed.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/VaultStorage.sol


Correspondence between paper formulas and code

Hello, sorry to bother you. I am a beginner and I have some shallow questions to ask you. May I ask why, in the compute_logprobe function, multiple tokens are indexed on responsive_log_probes corresponding to the probability distribution of a single token? How do these log_tokengsprob sums correspond to [1y | | π ref (· | x)] in the paper? I am looking forward to receiving your reply. Thank you

Thank you very much for your question.
The KL divergence between the identity function 1_y and the reference policy \pi_ref results in the log probability of the text y. We will make this clearer in future revisions.
Please let us know if you have any other questions.


[client] build preview lingers hex->world view

Describe the bug When in building preview, changing world view doesn't reset the preview and lingers on the world map following mouse movements. The only way to make it go away at the moment is to go back to hex view.
To Reproduce

Go to hex view
Click on a building card to generate a building preview
Go to world view

Screenshots

Closed by #969


scripts/setup-data-dir.sh is out of sync with init/systemd/tmpfiles.d/rkt.conf

Currently the tmpfiles.d drop-in sets up the /etc/rkt directory owned by the group rkt-admin.  However, the setup-data-dir.sh script does not.  Per @lucab this needs fixing so he requested I file an issue.

Arguably setup-data-dir.sh should:

create a system group named rkt
create a system group named rkt-admin
if systemd-tmpfiles is in path, just pass tmpfiles.d/rkt.conf to it
if /etc/tmpfiles.d/ exists, copy rkt.conf there
otherwise just continue with normal script execution

Bonus point: rework current script to parse items from rkt.conf instead of hardcoding them in two places.

I'll be happy to review/shepherd PRs fixing this. Feel free to ping me with any question/doubt related to this.

Is this still Open? I see a merged PR and a few commits that point to this issue.

It seems this was addressed partially: scripts/setup-data-dir.sh was synced with init/systemd/tmpfiles.d/rkt.conf at the time.
However, to close this we should check that they're still on sync, and address the bonus points mentioned by @lucab in https://github.com/rkt/rkt/issues/2862#issuecomment-229980007

rework current script to parse items from rkt.conf instead of hardcoding them in two places.
use systemd-sysusers for point 1 and 2 above.

I can work on the 1st item (reworking the script to parse rkt.conf), if this is up for grabs.

SGTM, thanks!


[bug fix] parameters and system prompt being set to empty in config

See https://github.com/lastmile-ai/aiconfig/pull/323#issuecomment-1826032815

Just want to also add that when the config has empty parameters, system prompt (ex. doesn't need them) -- config.run fails. See screenshot:

I'm going to lower this to mid pri for now so we can focus on 373, 399, 401, and 402.

I think this is probably a salient enough bug to rank right below the immediate requests/reports from users. I'll mark planned; it's on my calendar for late in the week.

Going to close this (can't repro). We can reopen if necessary.


error: open k json file fail: ~/SyzDescribe/config/knowledge-v6.1.json

Hi， an interesting job!
When I try to run SyzDescribe, I get some error.
My command is tools/SyzDescribe/SyzDescribe --config_json=config.json
The info in config.json is:
{
  "bitcode": "built-in.bc",
  "knowledge": "~/SyzDescribe/config/knowledge-v6.1.json",
  "version": "v6.1"
}

My linux kernel version download with the command git clone --branch v6.1 xxx
My LLVM version "Ubuntu LLVM version 14.0.0", and clang version is Ubuntu clang version 14.0.0-1ubuntu1.1
The info in debug.log is:
info: Fri Dec  8 01:59:00 2023
info: Fri Dec  8 01:59:00 2023 : bitcode: built-in.bc
info: Fri Dec  8 01:59:00 2023 : *************************************************
info: Fri Dec  8 01:59:00 2023 : ****************ReadIR***************************
info: Fri Dec  8 01:59:06 2023 : ****************check all function start*********
info: Fri Dec  8 01:59:07 2023 : ****************check all function end***********
info: Fri Dec  8 01:59:07 2023 : ****************indirect functions start*********
info: Fri Dec  8 01:59:07 2023 : ****************indirect functions end***********
info: Fri Dec  8 01:59:07 2023 : ********find_init_and_exit_function start********
info: Fri Dec  8 01:59:07 2023 : ********find_init_and_exit_function end**********
info: Fri Dec  8 01:59:07 2023 : knowledge json file: ~/SyzDescribe/config/knowledge-v6.1.json
error: Fri Dec  8 01:59:07 2023 : open k json file fail: ~/SyzDescribe/config/knowledge-v6.1.json
#0 0x00007f830e911d01 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/lib/x86_64-linux-gnu/libLLVM-14.so.1+0xe3fd01)
#1 0x000055e716dfdffc yhao_log(long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (.constprop.0) knowledge.cpp:0:0
#2 0x000055e716e05e72 sd::knowledge::read(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (build/tools/SyzDescribe/SyzDescribe+0x6de72)
#3 0x000055e716db4f55 sd::Manager::analysis() (build/tools/SyzDescribe/SyzDescribe+0x1cf55)
#4 0x000055e716da28d5 main (build/tools/SyzDescribe/SyzDescribe+0xa8d5)
#5 0x00007f830d6a7d90 (/lib/x86_64-linux-gnu/libc.so.6+0x29d90)
#6 0x00007f830d6a7e40 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e40)
#7 0x000055e716da5dd5 _start (build/tools/SyzDescribe/SyzDescribe+0xddd5)

I built the linux kernel v6.1 followed the command https://github.com/ZHYfeng/Generate_Linux_Kernel_Bitcode/blob/master/v6.1/README.md , and the build-in.bc files generated from the kernel source are present in each driver folder. I am not quite clear about the structural relationship between .bc, config.json, and the paths specified in config.json, and is there any difference in running Syzdescribe between linux kernel v6.1 and v6.2. I hope it can provide the absolute path relationships for script execution, or a demo example running with Syzdescribe.
Thanks.
In addition, when I run the command build/tools/DifuzeFix/DifuzeFix --bitcode=built-in.bc followed the https://github.com/ZHYfeng/PortedDIFUZE, I got the empty result.json file with the only "null" in it. Colud you give me some advice?

As mentioned,
  "knowledge": "~/SyzDescribe/config/knowledge.json",
    // the path of the knowledge file

This is the path of the knowledge file.
And all the path are the absolute path.

I find that you use config_json in cmd, which is wrong (and is used in old version).
Please check the README since I also update the README when supporting v6.1.
The cmd should be ~/SyzDescribe/build/tools/SyzDescribe/SyzDescribe  --config=config.json.
And the json should be:
{
  "bitcode": "~/SyzDescribe/built-in.bc",
  "knowledge": "~/SyzDescribe/config/knowledge-v6.1.json",
  "version": "v6.1"
}

I find that you use config_json in cmd, which is wrong (and is used in old version). Please check the README since I also update the README when supporting v6.1.
The cmd should be ~/SyzDescribe/build/tools/SyzDescribe/SyzDescribe --config=config.json. And the json should be:
{
  "bitcode": "~/SyzDescribe/built-in.bc",
  "knowledge": "~/SyzDescribe/config/knowledge-v6.1.json",
  "version": "v6.1"
}

Thank you for the reply. In my environment, replacing the ~ with the absolute path works.
{
  "bitcode": "/home/xxx/SyzDescribe/built-in.bc",
  "knowledge": "home/xxx/SyzDescribe/config/knowledge-v6.1.json",
  "version": "v6.1"
}


How to edit the Prometheus default configuration, when I edit the secret prometheus-k8s, it will become the default configuration.

kubectl apply -f coreos/kube-prometheus/manifests

All targets in kube prometheus are configured using a CRD called ServiceMonitor or PodMonitor. Those then are used to generate the secret you were trying to edit. I recommend getting familiar with the prometheus operator which is the component that does all of this: https://github.com/coreos/prometheus-operator

Closing due to staleness. Please reopen if you think this is still relevant.


Option to convert keys to keywords

This is simple to do manually after de-serializing, but having the option built-in it would be nice.
Converting a JSON string to an alist, sometimes it is desirable to treat JSON keys as keywords.
An example:
CL-USER> (defvar *simple-test* '((:a . 1) (:b . 2)))
*SIMPLE-TEST*
CL-USER> (with-input-from-string (s (shasht:write-json* *simple-test* :alist-as-object t :stream nil))
           (shasht:read-json* :stream s :object-format :alist))
(("A" . 1) ("B" . 2))
CL-USER>

Given the code above, a way to get back ((:A . 1) (:B . 2)) after calling read-json can be convenient.
I don't think it should be the default, and it could even work for hash-table keys too, in the default object format. (for less :test #'equal arguments :smile:)

I am not saying I am completely opposed to this, but some have pointed out that this is security risk.
https://github.com/sabracrolleton/sabracrolleton.github.io/blob/master/json-review.md#security
In general using hash tables is the best fit for JSON. On the other hand, do you have a use case? I can think about it if you do.

I don't have a particularly strong use case, I just happened to have an alist and was using keywords as keys for convenience.
I dumped the data to a file and noticed that reading it back I had to convert the string keys to keywords again.
And, in my case it was a couple hundred entries, so it wasn't a big deal to loop and create a new alist with keyword :)
Considering the security implications, it is probably better not to do this.

In the case of plists I think the justification is a bit stronger. There is a dynamic variable *symbol-name-function* that is used to control what function get the name of the symbol. This is only done on the write-json side. I'll look into providing a generic way to do this on both the write and the read side and probably leave it up to the user to override it if they wish.

@Mr-Dispatch you don't need to ask permission to submit a PR. Just do it. I'll review it without preconditions.

I was more like asking whether it would even be considered a feature (I haven't even cloned, I just edited on a whim, copied to my .local-projects, ql:uninstalled ultralisp original, restarted, enjoyed).
PR would be a "few more keystrokes" ;-)


[3.5beta5] vibrate_handheld() on iOS does 1 haptic pulse

Godot version
3.5.beta5
System information
iOS, iPhone 12
Issue description
On iOS the Input.vibrate_handheld(duration_ms: int = 500) used to do exactly that - vibrate for half a second.
In this 3.5.beta5 version, the same call to Input.vibrate_handheld() results in a single haptic tick, which is quite different than a 500ms vibration.
Steps to reproduce
Run a project on iOS with Input.vibrate_handlheld()
Minimal reproduction project
No response

See https://github.com/godotengine/godot/pull/60397.
cc @timoschwarzer

Opened two PRs :)

On iOS the Input.vibrate_handheld(duration_ms: int = 500) used to do exactly that - vibrate for half a second.

Fun fact @oeleo1: The vibration had a fixed duration of 400ms before. The duration_ms parameter was completely ignored. (And apparantly I ignored it with my previous changes as well)

@timoschwarzer Thanks for fixing it!


JQuery 3.5.1?

I'm upgrading a site to JQuery 3.5.1 as Google Lighthouse tells me it's the latest version that doesn't have vulnerabilities (https://snyk.io/vuln/npm:jquery?lh=2.2.4&utm_source=lighthouse&utm_medium=ref&utm_campaign=audit).
I found this updated repo for the slider but it still doesn't work. Just wondering if it's incompatible with JQuery 3.51 at the moment? My debugging efforts don't show anything conclusive.
Regards,
Craig

Forget it, it was a clash with slimmage.js !


Oriented views

This PR rewrites the views to better handle dataset orientation.

cameras transform to the dataset, not the other way around
slice views now mimic an orthogonal MPR view, so there should be consistent coronal, sagittal, and axial views (assuming the  dataset orientation is correct)

This means the slices are along IJK, but each slice is correctly oriented in space.

Code LGTM but I haven't tested. Let me know if you'd like me to before merging.


Update README.md

@dhiru30  thanks a lot for your improvements. We are using an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf
Just fill in the form, sign and send a scanned copy over to cla[at]arangodb[.]com or via fax +49-221-2722999-88
Note: As we are a company registered in Germany, we are obliged by law to have a signed scanned copy of CLA to be able to accept pull requests to the official ArangoDB repository.


KAFKA-14474: Move OffsetIndex to storage module

For broader context on this change, please check:

KAFKA-14470: Move log layer to storage module

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Test failures look unrelated, re-running just in case.

Failures are unrelated.


Register view_as_real as complex functions | fix(torchlib)

Previously I omitted complex=True

Is there any test guarding it?

That’s a good question. I haven’t come up with ways of doing it. Any suggestions?
Will merge for now. Happy to follow up!

Is there any test guarding it?

That’s a good question. I haven’t come up with ways of doing it. Any suggestions?
Will merge for now. Happy to follow up!

It can't be added into ops_test.py with extra_opinfo?

That's true. My bad


feat(breadcrumb): add optional path-style

add optional breadcrumb styling for path. This somewhat follow agnoster styling.
Currently support full, letter, and unique. Default to full.
letter format:

unique format:

awesome feature but personally think that probably not enough use from a broad audience, going to close for now but will leave as ref for people interested in the future

yep I was just meant to open a PR for this one, as this is very opinionated.


Feature request/support for Windows Containers

@davidalger  In one of the current M2 project some of our team has to work on Windows and they don't have way for ubuntu or not even in WSL. So I tried gathering "davidalger/warden" magento images and created environment for Magento 2 as attached here.
m2_env.zip
The issues it's having

It's very slow [Even in same ubuntu machine warden containers are really fast but this containers are very slow] => Are you able to spot what should be added/changed in this to make it work faster just with this images?
How can I add SSL certificates or enable way for https to these local development environment

This will be really great option if the same lib. can work in Windows also

@Elamurugan-Nallathambi It's a curious idea, but I'm not sure supporting non-WSL installs on Windows is something that's even feasible here. I'm not a Windows guy, but I'm pretty sure you need WSL to run bash scripts, and that is largely the makeup of this tool :)
Not being a Windows guy, I'm not really sure what options you have without using WSL to sign SSL certs on a Windows only environment. As far as docker containers for handling them, feel free to reference https://github.com/davidalger/warden/blob/master/docker/docker-compose.yml which is the definition for the containers Warden runs to route requests via Traefik. They may come in useful.
As far as performance goes, it's my understanding that Docker for Windows suffers similar performance issues as on macOS when mounting directories from the host into the containers. This is because Docker can't really run containers natively on a Windows or macOS host (it runs them in a VM in both cases). So you'll be wanting to look into Mutagen as is done for darwin environments on macOS. On darwin environments, pub/media is mounted, and the rest is sycned into the container by mutagen session started via warden sync start (something that's not used on Linux). These references may be helpful:
https://github.com/davidalger/warden/blob/master/environments/magento2.darwin.yml
https://github.com/davidalger/warden/blob/master/environments/magento2.mutagen.toml
If someone would like to put in the effort to tackle supporting WSL and closing whatever gap there may be installing Warden on Windows in context of WSL, I'd be open to merging PRs to that effect. I have no Windows setup around to test on however (and not much desire to do this myself for the time being). I know that @adexandros at least took a stab at installing Warden on WSL at one point, but not sure what the results were, although I do note you're indicating the immediate issue at hand WSL wouldn't work.

Closing as I have no intent (nor the time) to provide support for Warden on Windows currently. If a contributor would like to make this happen, it may be re-opened.


Gamepad: Primary/secondary use trigger gets multiple triggers due to analog input

Primary/secondary use trigger needs refining as the analog input causes it to get triggered multiple times in a row.
Seems to be a matter to properly parse the input.

Fixed!
Had to change the input detection to is_action_just_pressed.


Inline whitespace in text removed around a custom element (in build only)

I have a web component that outputs text only (a formatted logo that does some stuff that would justify making it a component). Because it is text-based, it is often used inline with other text. But, when I make a build using $ npm run build it minifies and removes the whitespace before and after the component. During development (using the es-dev-server), whitespace is maintained just fine.
The main issue for me is that a built version of my application now looks differently than the development version. I can work around this by replacing the whitespace with nbsp;, but obviously not preferred.
This issue can be reproduced with the bare code samples below.
class MyElement extends LitElement {
  render() {
    // expect: lorem logo ipsum
    // actual: loremlogoipsum
    return html`lorem <my-logo></my-logo> ipsum`;
  }
}

export class MyLogo extends LitElement {
  render() {
    return html`logo`;
  }
}

This might be a build issue with custom elements only. Because lorem  ipsum builds just fine. See images below.
Whitespace gone:

Whitespace maintained:

Can you try with the latest version of building-rollup? I think this is fixed by https://github.com/open-wc/open-wc/pull/1050

You are right, that fixed it and it's working fine now. Thanks!


Performance Work

Fixes #9, and fixes #8.

simplified some of the DB connections (relying on cursor fetch iterators, so we don't load all rows into memory multiple times) so they're faster
added an intro screen with summary statistics about the interview, with a warning that things might be slow for larger interviews
added an interview where you can create fake data and delete data for an existing interview.

trying to figure out how to handle finding interviews to display the data though: generating fake data only works well (and only advised) to work on a new, local server, it can cause excess CPU usage on the server

moved the excel download file generation to be a background task if there are more than 10000 rows in the current interview stats, to prevent risk of timeout.

@BryceStevenWilley are you able to update the PyPI repository?

Didn't respond at the time, but yes, pypi has been updated: https://pypi.org/project/docassemble.InterviewStats/0.2/.


Track changes from settings.json

I wonder if we can introduce tracking of direct changes from settings.json and give the user an option to apply them to one of extension supported configuration files. It could serve as an improvement of the current behavior of merging with settings.json (we can for example block updating settings.json if we detect that it's out of sync).
I'm thinking of the scenario:

settings.json is produced as a result of merging settings.shared.json with settings.local.json and marked as synced
settings.json is modified (thus becoming non-synced)
extension detects it and sends the notification
user is presented with the option to "Sync" (either triggered manually or required before merging settings.shared.json and settings.local.json)
user can select the target configuration file where the diff would be applied (we'd need to perform some checks*)

Please let me know if that makes sense, I can take a look and start researching the possibilities (I guess some diff libraries would be the first thing to look for).
*we'd need to check that after applying the diff to one of our configuration files, produced settings.json would be the same as it was, otherwise we should block applying to certain config files (for example if the user would like to apply to settings.shared.json but in the same time his settings.local.json overrides the field - in such scenario only applying to settings.local.json should be possible).

Appreciate the thought, but I'm not sure I understand the use case and I'm not entirely convinced it's something we should do regardless.
Fundamentally, this extension is a bolt-on/band-aid type approach around a gap in VS Code which I hope will be resolved and available natively at some point (perhaps being far to overly optimistic though).
As such I'd like to try to minimize complexity, both in terms of the code and in terms of the mental model for users when leveraging the extension. I believe it's a fairly simple mental model at the moment, the real gap is the lack of the ability to use the UI. I'm not convinced that adding monitoring of native files and incorporating those into the fold is worth the hit on the mental model just to be able to use the UI (especially given that we've wired up autocomplete/intellisense on all the supported local/shared files)


Add Senselab

The build process also re-added relative links to the TSVs - that's why they changed.


Data Models 🎉 🚀 ✔

Data Models 🎉 🚀 ✔

Installed Ruby on Rails framework.
Used Ruby Gems as a software packages system.
Understood what ORM is.
Used database migration files to maintain database schema.

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @Nizamuddin4493,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly format your README correctly using the link shared with you previously. Your README should contain the Table of Contents with all the links present and their corresponding sections.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Avoid duplicating test code between e2e & canary

We have a few tests that run the same path in both e2e & canary flows. We previously used test suites exported from the tested package itself but this is not a great solution, as it pollutes the actual code that's necessary to run the packages.
We should figure out a way to share the test code without exporting it from the packages

One way to tackle this would be to have a separate package which would contain the test suites. That way we would not clutter the original package.
OTOH this is not ideal for tests like Aztec RPC Server because this breaks a norm a bit because the unit test would not longer be in the same package.

This is pretty much what I have in mind.
I think we should have dir just for tests that will replace end-to-end and then having this tests run on different levels of mocking. Most e2e tests currently could either be run against Sandbox or a plain RPC Server.
I see unit tests as a separate thing and they should be in the project's directory. They should be run just by yarn test and not require any extra setup


Fix mouseout bubbling while initial target was not listening (fix #3648)

This simple change should fix #3648.
Sadly, I can't add a unittest because happen doesn't seem to allow configuration of relatedTarget when firing an event (not sure why, cc @tmcw), so while in unittests this check is always true.

Awesome!

I think this fix has regressed. (Too bad a unit test wasn't possible…) If a target doesn't listen in _findEventTargets it will skip it but continue to the parent, thus implicitly bubbling, even if the event is in nonBubblingEvents. I can write up an example to reproduce, if you want.

I can write up an example to reproduce, if you want.

Would be very nice, thanks! You can use http://playground-leaflet.rhcloud.com/ for that :)

For the record, it's now possible to set `relatedTarget in happen, since https://github.com/tmcw/happen/pull/17

Related: https://github.com/Leaflet/prosthetic-hand/issues/9

Here you go: http://playground-leaflet.rhcloud.com/damu/1/edit?html,output
There is a click event bound to the map which prints to the console. Clicking on either marker should not trigger that event, because the default options of Marker include nonBubblingEvents to include click (among other events). However, if you click on the top marker (which does not have a popup bound), it still fires. This is exactly the bug that this PR originally fixed.

Thanks!
I'm not sure this is a bug actually. Some details:

this PR was about preventing mouseout and mouseover to be targeted on parent elements of the original target
nonBubblingEvents means not firing events on parents of an element if this element actually caught the event
in your example, topMarker is not listening for click, thus the event is sent to the map
if you don't want the map to received the event, you need to catch it on the marker and stop it: topMarker.on('click', L.DomEvent.stop);

Hope this makes sense! :)

Ah, if this is intentional then that's fine, but it still doesn't seem great to me that just setting an event handler has the side effect of preventing bubbling.
I would expect people to be confused by this, especially because the browser's bubbling does not work like this. For example, you don't have to call topMarker.on('click', L.DomEvent.stop);, it also prevents bubbling when you do topMarker.on('click', function() {});. I did not expect that.
If you do want to keep this behaviour, I'd suggest adding some comments in the code to clarify that this is how it's supposed to work (right now this is the only comment as far as I can tell). And perhaps something about this in the documentation, too.

For example, you don't have to call topMarker.on('click', L.DomEvent.stop);, it also prevents bubbling when you do topMarker.on('click', function() {});. I did not expect that.

See https://github.com/Leaflet/Leaflet/pull/3605#issuecomment-119589147 for more context about this design decision. I agree that this needs to be somewhere in the doc.

Yeah, that makes sense, this would be a significant breaking change. I suppose both solutions have some element of surprise in them. Perhaps it would also help if we wouldn't call this stuff "bubbling", since that implies things work similar to DOM bubbling. I don't have good alternatives though.
Anyway, thanks for your quick responses and providing context!


Time dimensions

See #1037 (WIP)

Hey @dgaubert  it would be nice that someone starts to review this, the CARTO VL front to expose this ain't finished yet but I don't forsee relevant changes here. There's some documentation here:


[FLINK-9976][streaming] Remove unnecessary generic parameters

What is the purpose of the change
This PR removes unnecessary generic parameter from format builder methods of the StreamingFileSink.
These are inconsistent with other existing methods that use the already defined bucket ID type of the builder, and as of right now would always lead to ClassCastExceptions if one tried to use a different type.

but the bucket ID type is already defined in the constructor. you can't just change that.

I think the Builders are done wrong. Instead of reusing the builder, the builder should be immutable and each call should return a new builder that has fields from the old builder and the new value that the user wants to set. This way we don't need to reinterpret. WDYT?

I think that would be a nicer approach. The fact that this compiles and runs without error is rather disgusting:
final RowFormatBuilder<String, String> original = forRowFormat(new Path("test"), (Encoder<String>) (element, stream) -> stream.write(0));
final RowFormatBuilder<String, Integer> casted = original
	.withBucketerAndPolicy(new Bucketer<String, Integer>() {
		@Override
		public Integer getBucketId(String element, Context context) {
			return 0;
		}

		@Override
		public SimpleVersionedSerializer<Integer> getSerializer() {
			return null;
		}
	}, new RollingPolicy<String, Integer>() {
		@Override
		public boolean shouldRollOnCheckpoint(PartFileInfo<Integer> partFileState) throws IOException {
			return false;
		}

		@Override
		public boolean shouldRollOnEvent(PartFileInfo<Integer> partFileState, String element) throws IOException {
			return false;
		}

		@Override
		public boolean shouldRollOnProcessingTime(PartFileInfo<Integer> partFileState, long currentTime) throws IOException {
			return false;
		}
	});

if (!original.equals(casted)) {
	throw new RuntimeException();
}

@aljoscha I've reworked the builders. This introduced a small gotcha for tests; if you set the bucketFactory, and afterwards change the type the factory is overridden with a default factory.

👍 that's better now

Shall we also change the PR's title?

I agree that the code looks nicer now, but essentially the only thing changed is that in the:
if (!original.equals(casted)) {
	throw new RuntimeException();
}

now we throw the RuntimeException, right?

yes, the functionality is the same, and in my example the test would now fail.


The Location Map cannot request the tiles through the API Gateway

Created: https://github.com/kalisio/kdk/issues/211

fixed with: https://github.com/kalisio/kdk/issues/211


Test about student login and logout

Test about student login and logout
Test environment setup

note: env.rb is generated by cucumber

I think this looks great!

This looks good Han-Yi


[BUG] - DatePicker incompatible with @internationalized/date v3.6.0

NextUI Version
2.4.8
Describe the bug
In v3.6.0 of @internationalized/date, parseDate return CalendarDate which is incompatible with the DatePicker's value and onChange props.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Use v2.4.8 of NextUI
Use v3.6.0 of @internationalized/date
Use Typescript
Using the instructions in the docs, create a controlled DatePicker
You should be receiving a TS error

Expected behavior
Using parseDate from the latest @internationalized/date should be compatible with DatePicker.
Screenshots or Videos

Operating System Version
macOS
Browser
Chrome

For v2.4.8, please use 3.5.5 for @internationalized/date. Any higher version may cause unexpected issues. We've specified the exact version in docs (in next release) so users will install the same version as the one defined in our package
Will leave this issue open for @internationalized/date version upgrade and corresponding changes.

Closing - @internationalized/date has been upgraded to 3.6.0 in latest version.


add google analytics

i see what you mean, @suejinkim20 . this is still wired up to deploy via Howard's Netlify account. we can recommend disconnecting that now that we're deploying in Sterling.