snapps fix predicate typ

Explain your changes:
Proofs parties are expected to have Full predicates but they can't be the first party https://github.com/MinaProtocol/mina/blob/642746d802f378f811a6647c178498aea6fdb2eb/src/lib/transaction_snark/transaction_snark.ml#L1674
This means one cannot create a txn that just updates the state.
Changed it to accept both nonce and accept predicate by doing the appropriate transformation between t and var
Explain how you tested your changes:
Ran a local node, generated the transaction that performs an update with Proof which got included in the block and snark worker generated a txn snark for it
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

Closing this in favour of https://github.com/MinaProtocol/mina/pull/9736


non-sub videos are considered sub videos

https://www.twitch.tv/videos/607730282
i can watch this on incognito just fine and im not a sub but twitchleecher says that it's a sub-only video.
the streamer has some of his vods sub-only but some not. and since i could view the free vods i wanted to see if im also able to download them

Can't help here. The API call to Twitch when downloading the VOD tells TL that it is actually sub-only. I also can watch teh VOD in Firefox (not even incognito). Seems to be a mistake/bug on Twitches end.


Message envelope and uncaught exceptions

We need a way to handle uncaught exceptions. Thrift uses the following shape for internal exceptions.
enum ExceptionType {
  UNKNOWN = 0
  UNKNOWN_METHOD = 1
  INVALID_MESSAGE_TYPE = 2
  WRONG_METHOD_NAME = 3
  BAD_SEQUENCE_ID = 4
  MISSING_RESULT = 5
  INTERNAL_ERROR = 6
  PROTOCOL_ERROR = 7
  INVALID_TRANSFORM = 8
  INVALID_PROTOCOL = 9
  UNSUPPORTED_CLIENT_TYPE = 10
}

struct TApplicationException {
  1: optional string message
  2: optional ExceptionType type
}

We need to be able to send messages with that as the payload and EXCEPTION as the message type.

Proposal: We call it InternalApplicationError or something similar that is more obvious than TApplicationException. It is simple enough to make message.dumps and message.loads support it. (Right now, message.loads treats this as an unknown exception and raises an exception with the Value-level representation).
import thriftrw
from thriftrw.something import InternalApplicationError  # something or just top-level TBD

myservice = thriftrw.load(..)
payload = myservice.dumps.message(InternalApplicationError(..), seqid=42)

Actually, the EXCEPTION message still needs the method name.


Hello, I have a question about your paper.

about word-level coreference resolution paper's table 4 (memory and time)
I have start-to-end coreference resolution korean model.
and also have word-level coreference resolution korean model.
but, when I tried to run model in my test data, the results was as follows.
571 documents (Length less than 512 sequences)

model
time
memory

s2e-coref
5.4s
1.6GB

wl-coref
10s
2.1GB

GPU : RTX TITAN 24GB
model : BERT-base
# my measurement
with output_running_time():
            model.evaluate(data_split=args.data_split,
                       word_level_conll=args.word_level)

As mentioned in the paper, other factors are thought to exist. However, I am curious as to how time and memory were measured to get good results as in the paper. For example, I am curious about your own measurement method, such as simply measuring the time of 'self.run'. Also, when evaluating, memory accumulates as the evaluation progresses. In my case, it was recorded as 1.4GB for the first time, but by the end of the last time it occupied 2.1GB.
If the reason is as mentioned in the paper,
"
However, they should not be directly compared, as there are other factors influencing the running time, such as the choice of a framework, the degree of mention pruning, and code quality.
"
I'd love to hear your own thoughts about the different results. For example, the result of using a separate module called span predictor, the result considering all spans, etc.
Thanks for your good paper!!

Hi!
Thank you for your interest. Sorry for taking a long time to reply, I was on vacation.

However, I am curious as to how time and memory were measured to get good results as in the paper. For example, I am curious about your own measurement method, such as simply measuring the time of 'self.run'.

The time reported in the paper was obtained by looking at the time elapsed by tqdm during evaluation. The peak memory consumption was tracked using nvidia-smi reported GPU usage.

Also, when evaluating, memory accumulates as the evaluation progresses. In my case, it was recorded as 1.4GB for the first time, but by the end of the last time it occupied 2.1GB.

PyTorch does not always free unused memory, so if it needed 2.1 GB to process one document, it might not release the memory for the following documents, even if the memory consumption to process them is lower.

I'd love to hear your own thoughts about the different results. For example, the result of using a separate module called span predictor, the result considering all spans, etc.

The obvious two things that are different between your measurement setup and mine are the data and the encoder. If you could produce the same evaluation with using a larger encoder (say, bert-large) and with using conll data, I would have more input to reason about the causes of such differences.

Thank you for answer!


Update frontend image

Remove enabled filter for two filters.
Add more description on the filters

Tested-by: zlq

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

There is no way for this change affect existing test, we haven't update the image SHA, rerun the test

/gcbrun


Update repo links: sferik/rails_admin → railsadminteam/rails_admin

The jruby tests seem a bit flaky and fail intermittently.

Thanks for the review @codealchemy
I have both those links for now as I think that is preferred to a 404 or out of date link. We can add them back once the services have been migrated to railsadminteam (something I cannot do).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.218%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
3355

Relevant Lines:
3678

💛  - Coveralls

Thanks ❤


[SMALLFIX]Support Format Master only

Now, the format operation can be invoked by several command:

alluxio format
alluxio formatWorker
alluxio-start.sh -f ACTION

But there no way to format master only through the alluxio script.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16565/
Test PASSed.

@yupeng9  Yes, it is like formatWorker command, it can format master on current node, formatWorker command format worker on current node too.

@yupeng9 Thank you for your comment, PTAL.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16593/
Test PASSed.


enhancement(Navisworks): Improve Tree Building handoff and Conversion Loop

Prerequisites

[x] I read the contribution guidelines
[x] I checked the documentation and found no answer.
[x] I checked existing issues and found no similar issue.
[x] I checked the community forum for related discussions and found no answer.
[x] I'm requesting the feature to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)

What package are you referring to?
SpeckleNavisworks
Is your feature request related to a problem? Please describe.
Because of the incremental development leading to the alpha release, similar problems were solved multiple times. Some parts of the CanConvert process are repeated 2/3 times

Converting Selections to the ultimate number of nodes to convert
In the Connector/Conversion loop
Validating the converted objects

Describe the solution you'd like
Having adopted the Collections class, added more Geometry Primitives and handled the fallbacks for those not yet supported, there are now fewer unknowns in the CanConvert loop and the Object conversion in general. Simplifying the logic of "keeping score" will increase speed, improve UX with progress reporting and accurately record the total object count.
Describe alternatives you've considered
I considered picking up a previous attempt at converting all child nodes in a flat list and reconstructing the tree once all are converted. The current solution has the keeping track of pointers already baked in, but the logic of Deep First feels worth keeping.
Part of the solution should be to stop applying both approaches in one.

Closing this ticket as we are moving to Jira to reduce noise. You can access it there.


Feature request: alternative syntax for setting geolocation

The current syntax for setting geolocation is,
- setLocation:
    latitude: 13.5266
    longitude: 78.2150

Provide a convenience syntax in the following format,
- setLocation: 13.5266,78.2150

@ragunathjawahar Going to close this out and let's continue conversation on #105


Haml error: ActionView::Template::Error (undefined method `capture_haml' ...)

Steps to reproduce
Minimal reproduction repository
Expected behavior
Component should render without incident, when using Haml template.
Actual behavior
Error is raised:
ActionView::Template::Error (undefined method `capture_haml' for #<#<Class:0x00007fc4fcb73338>:0x00007fc4fcaca440>
Did you mean?  capture_with_haml):

System configuration
Rails version: <IP_ADDRESS>
Ruby version: 2.7.1
Gem version: 2.18.0

@spdawson thank you for the report! We definitely want to make sure haml works with ViewComponent. Would you be willing to write a PR with a test case for this issue?

@joelhawksley I've added a test case in #428

Thanks @spdawson! Would you be up for pairing with me on this one? Send me an email<EMAIL_ADDRESS>

I would be willing to help if it's needed. I plan to use view components with Haml at work. If Haml doesn't work with view components right now, it's a blocker. Let me know how I can help.

@dmarcoux send me your pairing availability for the next week to<EMAIL_ADDRESS>❤

@dmarcoux send me your pairing availability for the next week to<EMAIL_ADDRESS>heart

Done :slightly_smiling_face:

hey @spdawson @dmarcoux
I was taking a look at this issue and the repository provided, I noticed it is using helpers.link_to.
As https://github.com/github/view_component/pull/428#discussion_r468713628 explained, helpers. is unnecessary in this situation and removing it solved the issue (at least in the provided repo)
Could you confirm that removing helpers. fixes the issue? Also, is there any specific reason as why you are using helpers.?

Could you confirm that removing helpers. fixes the issue? Also, is there any specific reason as why you are using helpers.?

Yes, removing the helpers. scope does resolve this issue for me; thanks @dmarcoux!

I do get this error even without any helpers in my templates. My component however renders a rails form and another component within it.
default.html.erb (preview template):
<%= form_with model: @gig do |f| %>
  <%= render Places::EditComponent.new(form: f, attr_name: :venue) %>
<% end %>

edit_component.html.haml (the component itself):
= @form.fields_for @attr_name do |pf|
  %div{class: errors.present? ? 'has-error' : ''}
    = render Places::MapComponent.new(place: place, style: @style, fireEvent: @fireEvent)

The error message points to the @form.fields_for line.


Issue with seeders number

Sometimes in the search results i see torrents that show 30 or 40 seeders but when i select the torrent and elementum starts downloading the buffer it shows this for seeders 1/1. Why is that?

In search results you see the number that you get from torrent website.
When you add torrent - you see number from torrent library, which collects peers from different places.


788 - Added NanoCpus property to HostConfig

Codecov Report

Merging #789 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #789     +/-   ##
===========================================
- Coverage     65.85%   65.35%   -0.5%
+ Complexity      699      693      -6
===========================================
  Files           158      158
  Lines          3031     3031
  Branches        348      348
===========================================
- Hits           1996     1981     -15
- Misses          879      891     +12
- Partials        156      159      +3

I cleaned up the git commits here https://github.com/spotify/docker-client/pull/806


rancher-compose image / build overrides

Rancher Version:
v1.1.0-dev1
Expected:
when using a rancher-compose file in combination with docker-compose file. How can we override a build: /path/to/Dockerfile directive in the docker-compose file with a image: my-docker-user/my-docer-repo directive in the rancher-compose file?
This is very handy as we use build for developing locally, and image for the remote build.
furthermore we would also like to remove/add other directives such as volumes etc...

@andrewmclagan A couple of ways to cut this...
You could use the 'extends' function of docker compose, you could use extends in your docker-compose file and use an environment variable passed at runtime to determine which 'version' of the config you want to run in. https://docs.docker.com/compose/extends/ has some more details, I could always paste some examples if it's of interest.

@andrewmclagan Let me know if you have further questions, @Rucknar has some great suggestions.
At this time, you can't have the image in the rancher-compose.yml as we expect that info in the docker-compose.yml files.


Release for ES 7.9.2

Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/7.9/release-notes-7.9.2.html

Version <IP_ADDRESS> has been released today.


Unexpected error during request: list index out of range

2016-08-08 21:36:13,904 [       scan] [   INFO] Completed 90.16% of scan.
2016-08-08 21:36:15,061 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 21:36:15,342 [       scan] [   INFO] Completed 91.80% of scan.

Appears occasionally. Verified all accounts were logged in properly.

I been getting this to...  Been running good all day..
016-08-08 22:05:09,940 [       scan] [   INFO] Completed 75.32% of scan.
2016-08-08 22:05:10,137 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,197 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,263 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,276 [       scan] [   INFO] Completed 75.39% of scan.
2016-08-08 22:05:10,341 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,398 [       scan] [   INFO] Completed 75.46% of scan.
2016-08-08 22:05:10,426 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,437 [       scan] [   INFO] Completed 75.52% of scan.
2016-08-08 22:05:10,502 [     pgoapi] [   INFO] Unexpected error during request: Request throttled by server... slow down man
2016-08-08 22:05:10,503 [     pgoapi] [   INFO] Unexpected error during request: list index out of range
2016-08-08 22:05:10,506 [       scan] [   INFO] Map Download failed. Trying again.

Have you verified that you accepted the game TOS on all accounts?

It seems this is a bug within the api we are vendoring. I'm investigating this further.

f81219e5bc726e4310997028d5b316ab5e811166


Improvement of methods.

Because of using map tickers are returned shuffled. Made Tickers method returning array sorted by Ticker.Rank as it comes from CoinMarketCap API.

@bearbeard look good, merged!


[BP-1.13][FLINK-22382][tests] Harden ProcessFailureCancelingITCase.testCancelingOnProcessFailure

This commit hardens the ProcessFailureCancelingITCase.testCancelingOnProcessFailure by increasing the
accepted heartbeat timeout.

Thanks for the review @zentol. The failing test case seems to be unrelated. Merging this PR now.


Issues/bugs, may I get some help, please?

Hi!
I've got some issues...I'm really trying to understand the code, but I still have issues with it...may I get some help, please?
Whenever I ask a worker to build a construction, the worker gets stuck inside the construction and I cannot assign more workers to the same construction.
If I ask a worker to gather resources, it works perfectly, but if I move the worker somewhere while he's getting back to the base, it's getting bugged, it becomes unable to get or drop resources anymore.
Is there any command for resetting the number of carried resources? I can't find how to get the number of carried resources....
I'm sorry if the problems may sound a bit silly...but I'm still learning... ^.^

Hey @ForgottenFrog,
that's multiple questions, so let's take a look at these one by one:

What construction mode are you using, i.e. at the RTSConstructionSiteComponent attached to your building, what's the value of the Construction Cost Type? Also, what's the value of MaxAssignedBuilders?
The worker should be able to drop resources at any building with a RTSResourceDrainComponent configured to accept the respective resources in its Resource Types. In any case, the number of carried resources is stored in the CarriedResourceAmount property of the URTSGathererComponent.

Hi! Thank you for your reply!
I've managed to solve the workers problem. Sorry about that one, but the second problem is still there...
So...whenever I select a worker, I command it to mine, it gets the resources, goes to the base, drops them and then returns to the resource source.
That's great, it works, but only if you don't bother the worker
Once the worker is carrying the max amount of resources and I cancel his command to drop them to the base (let's say I want to build something...), the worker is unable to collect or drop any resources anymore.
Once the return command gets cancelled, the resources can't be dropped, resetted or checked anymore.
And, regarding the resources, I spotted a problem (Idk if it's only my case...) The maximum amount of resources of a resource source can be changed, but the current amount cannot. And Idk why, but no matter how I change that number, if I use a simple print string to get the current resource amount, it is always starting with 1000.

Well observed! Thanks for sharing!
The first issue is actually rather a misconfiguration: The order for returning resources was not added to the list of orders that can be issued via right-click. I've pushed a fix in https://github.com/npruehs/ue4-rts/commit/f6f885fa53f5e4d56605a834bf8e4e20301b366b, but you can quick fix that in your project by adding the order to the DefaultOrders array of your player controller blueprint. Note that the order of orders is important here - the ReturnResources order should be added right before the MoveOrder.
The second issue is a bug in the initialization of the current resources. I've added a fix in https://github.com/npruehs/ue4-rts/commit/f2099a6fcef2cc0a79edff04dfde7b1ba272b94a.

Thank you for solving the problems! I really apreciate it.


Show disabled_color when disabled=True for markup label

Fix for #3959
Regarding the alpha thing, I dont think markup currently supports alpha because I tried this:
Label:
    markup: True
    color: 0,0,1,0.5
    text: 'A [color=#77FF0000]B[\color]'

and it outputs this image:

@dessant please review this.

I agreee, alpha is a different issue, the pr looks good. :100:


[Android] Build failed in emulator. Could anyone help me???

I'm getting the same problem as well

Found the issue.  Please refer to this link: http://stackoverflow.com/questions/17155475/could-not-find-com-google-android-gmsplay-services3-1-59-3-2-25-4-0-30-4-1-32
If you do not have Google Repository or Google Play Services it will give you the error above


zabbixapi gem not loaded when using ruby1.8

If I enable manage_resources in zabbix::server on a machine running ruby 1.8.7, I get the following error:
err: Could not run Puppet configuration client: no such file to load -- zabbixapi

(I'm using debian, and puppet seems to have a hardcoded dependency on ruby 1.8, despite ruby 1.9.3 also being installed on the system.)
Do you intend this module to work with ruby 1.8.7, or only newer versions?

I've downloaded the Debian 7.7 iso images and installed an fresh debian into vbox. I installed ruby1.8 first and than the apt repository from puppetlabs and installed puppet (It installed the ruby1.9 to). I can't reproduce it this way, so I'll have to wait on your comment about how to reproduce this.
p.s. Happy new year ;)

I've downloaded the Debian 7.7 iso images and installed an fresh debian into vbox. I installed ruby1.8 first and than the apt repository from puppetlabs and installed puppet (It installed the ruby1.9 to). I can't reproduce it this way, so I'll have to wait on your comment about how to reproduce this.
p.s. Happy new year ;)

@dj-wasabi Thank you for the attempted fix.
I pulled this down and attempted to run again but I'm still seeing the same error. I purged all existing instances of zabbix-api using gems before running puppet.


Skill Tournaments

🚀 Feature Proposal
Hey OSRS BOT I have a suggestion to add to the bot to make it more popular.. its actually genius and if I knew how to code my own bot I would do it but I dont. My suggestion is to add !commands to be able to keep track of peoples xp like on a scoreboard or something like that alot of Old School Runescape Clans/Communitys are hosting these weekly skill tournaments where a everyone pitches in for a reward for the winners then they vote for a specific skill what ever skill wins the vote will be the skill they train for the week for the tournament. Whoever gets 1st, 2nd, or 3rd with the most xp of the skill of that week wins so it would be nice to have a feature that could do that in the osrs bot like if there was some kind of xp tracker that refreshes every sunday night at 12 am and starts at 12:01am every monday and be able to assign the skill for the week like !weeklyskill - agility. so people can just type !skilloftheweek and osrsbot will inform them the weekly stat
Describe the feature you're suggesting here, give lots of information and describe it as best you can. Please check that the feature hasn't already been suggested first, by searching the issues in this repository.

we have now had sotw week tournaments


[Feature- 9837][plugin/ui] support FlinkSQL Task

Purpose of the pull request
We want FlinkTask to have an editor to fill out flink sql.
Users can implement flink sql tasks or flink sql cdc tasks through the sql editor, which is convenient for users to perform data processing and ETL.
This change added tests and can be verified as follows:

Brief change log
ProgramType.class add sql type
FlinkTask.class and FlinkTask.class add main logical for support Spark sql command
FlinkConstants.class 和 FlinkParameters.class Common parameters for connecting Flink sql commands and methods for obtaining parameters
use-flink.ts adds some logic to support front-end pages supporting spark sql editing SQL
close #9837

Verify this pull request
This change added tests and can be verified as follows:
org.apache.dolphinscheduler.plugin.task.flink.FlinkTaskTest

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

@Amy0104 @devosend Take a look at this PR

Codecov Report

Merging #9840 (7850a08) into dev (828034f) will increase coverage by 0.34%.
The diff coverage is 62.04%.

:exclamation: Current head 7850a08 differs from pull request most recent head fa5e9d0. Consider uploading reports for the commit fa5e9d0 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9840      +/-   ##
============================================
+ Coverage     40.41%   40.75%   +0.34%
- Complexity     4527     4569      +42
============================================
  Files           834      833       -1
  Lines         33639    33700      +61
  Branches       3721     3737      +16
============================================
+ Hits          13595    13736     +141
+ Misses        18760    18648     -112
- Partials       1284     1316      +32

Impacted Files
Coverage Δ

...er/server/master/runner/WorkflowExecuteThread.java
8.29% <0.00%> (ø)

...hinscheduler/plugin/task/flink/FlinkConstants.java
0.00% <ø> (ø)

...hinscheduler/plugin/alert/script/ScriptSender.java
60.60% <11.11%> (-18.57%)
:arrow_down:

.../dolphinscheduler/plugin/task/flink/FlinkTask.java
65.24% <65.28%> (+65.24%)
:arrow_up:

...inscheduler/plugin/task/flink/FlinkParameters.java
98.14% <75.00%> (+80.50%)
:arrow_up:

...olphinscheduler/plugin/task/flink/ProgramType.java
100.00% <100.00%> (+100.00%)
:arrow_up:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828034f...fa5e9d0. Read the comment docs.

你好@Dannila，你能把这个添加到文档中吗？谢谢。

ok

ok, another pr will be mentioned later to add documents

Please also add documents in this PR. Thanks.

I think it needs to be clearer！

还请在此 PR 中添加文档。谢谢。

Quindi aggiungerò il documento ora

ok, another pr will be mentioned later to add documents

Please also add documents in this PR. Thanks.

good job, supporting Flink sql is big feature, By the way, the doc is very important, the PR with relevant doc will keep the code and documentation as consistent as possible

Well done, I had approved to run CI.

Kudos, SonarCloud Quality Gate passed!
  0 Bugs   0 Vulnerabilities   2 Security Hotspots   5 Code Smells
 71.8% Coverage  2.2% Duplication

BTW, please check the https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9840&resolved=false&types=SECURITY_HOTSPOT

@zhuangchong Excuse me, do you think this PR needs to be further optimized?

@Dannila Please resolve conflicts.

@Dannila Please resolve conflicts.

OK, I'll fix it in the next commit.

请rebase最新的代码，我们删除旧的UI。

是的，在最新的提交中，我有rebase最新的代码。

可能是操作。我们取消了旧的UI改写，所以从目前UI-Next来看UI，你的这个操作没有成功。

Excuse me, is this operation successful in the latest commit?

yes, will review later.

yes, will review later.

Gratitude！

To ensure the quality and style of the front-end code, you should run  pnpm run prettier to format the front-end code. @Dannila

could we add it to CI? when could not formatted will fail our CI @devosend ?

we should have frontend get at least one approval from our frontend developer

To ensure the quality and style of the front-end code, you should run  pnpm run prettier to format the front-end code. @Dannila

Sorry, I don't know much about front-end, I don't know much about this should run pnpm run prettier to format front-end code

The front end part LGTM

Greatful

Thanks for your contribution. This is a good beginning. Considering that it's your first contribution, I think we can get deep communication, you can contact me through mail or add WeChat(SbloodyS), when mail or added, please tell me who you are. I think I can help to familiar with the Dolphinscheduler if you meet with problems.


Refactor Address

Blocked on https://github.com/rust-bitcoin/rust-bech32/pull/30 and https://github.com/rust-bitcoin/rust-bech32/pull/31.
Inspired by: https://github.com/ElementsProject/rust-elements/pull/16/.

use AddressError instead of encode::Error
replace using bech32-bitcoin with Payload::WitnessProgram variant

Closes https://github.com/rust-bitcoin/rust-bitcoin/issues/253.

@stevenroose Could you provide additional justification for this change? The overall stats come out to +419 −185, and I'm not convinced that the extra lines are more readable than what we have right now.

@dongcarl without this change we cannot support non-v0 segwit addresses

@dongcarl

@stevenroose Could you provide additional justification for this change? The overall stats come out to +419 −185, and I'm not convinced that the extra lines are more readable than what we have right now.

The main reason was to take out the dependency on the bitcoin_bech32 crate. It didn't really make sense to have it a separate crate since it was really only relevant for encoding Bitcoin addresses, which is what the util::address module does. So while trying to support v0+ segwit addresses and a generic from_script, I noticed the annoyance of the bitcoin_bech32 crate's indirection.
Also I implemented Elements' bech32 and blech32 addresses in a similar way because the bitcoin_bech32 crate didn't work for that.

Codecov Report

Merging #255 into master will decrease coverage by 0.24%.
The diff coverage is 75.43%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   81.81%   81.56%   -0.25%
==========================================
  Files          38       38
  Lines        6823     6927     +104
==========================================
+ Hits         5582     5650      +68
- Misses       1241     1277      +36

Impacted Files
Coverage Δ

src/lib.rs
100% <ø> (ø)
:arrow_up:

src/consensus/encode.rs
76.77% <ø> (+0.38%)
:arrow_up:

src/blockdata/script.rs
78.35% <100%> (+0.43%)
:arrow_up:

src/util/address.rs
80.38% <74.2%> (-7.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0f114...9a3145c. Read the comment docs.

Ok I squashed some fixup commits and added the from_script fuzzer. Please review once again.


Navbar of Services is not Working

Hello Project Admin,
There is a major issue in  navbar in the Services section.
Working on this soon will raise a PR
Issue Video -
Screencast from 21-06-23 05:06:36 PM IST.webm

Yeah, pls fix it @SyedImtiyaz-1

Thank You for assigning @akshathar-navada I'm working on this.
Soon will raise a PR 👍🏻

Hello @akshathar-navada ,
The Navbar alignment bug is fixed.
Video -
Screencast from 22-06-23 02:57:31 AM IST.webm
One more notice by my side - The OS-Code website is proper but when it's comes to the Services section it becomes very slow while working on this issue it's kinda headache to me because I have to refresh the website every single time whenever I save code in my VS-Code and after refresh it takes 3-4 minutes to load so I have a recommendation Minify the CSS and JavaScript to make the website faster & robust.
If you want to make website faster then I can do it you. 💯
By the way above issue is ready to Merge 👍🏻


Issue With KeePassDX, If i Open Database via KeePassVault

Overview
Hi!
If i Open my KeePass Database via KeePassVault then save something
I can't open my Database via KeePassDX client anymore
How to reproduce

Open Database via KeePassVault
Save new info
Then exit
Then reopen it via KeePassDX
It failed
Before saving new info via KeePassVault
Opening via KeePassDX worked!

Version
1.8.0
Android Version
Android 14
Device Model
Pixel XL

Hi,
Thanks for detailed report. I can't reproduce this issue with new database (created in the app), could you please share additional information?

Does this issue happen only with your personal database or does it happen on new files too?
If this is personal database, could you share information about it: How many entries does it have? How big is database file? How old is database? Does it have files in it? How many does it have?

@IzumiSenaSora

This issue should be fixed in #281 but it will not fix already affected entries in database. This means, that previously modified entries (that didn't allow KeePassDX to open the file) should be deleted.
Could you please check? Build is available here, you may choose any build except app-fdroid-automation.apk
@IzumiSenaSora

I wasn't able to reproduce the bug according to your steps. But looks like I finally managed to find valid steps for it with new db:
1 - Create new db file
2 - Add entry "Entry 1"
3 - Change title of "Entry 1" -> "Entry 2"
4 - Check that KeePassDX opens db
5 - Change title of "Entry 2" -> "Entry 3"
5 - Open db with KeePassDX, it should not open it
The issue was caused by error in processing entries history, I think it should be fixed now.
Could you please check it again? So we can sure that there are no more issues with entry history. Build is available here @IzumiSenaSora


Update azure-storage-blob to 12.6.0

Updates com.azure:azure-storage-blob from 12.5.0 to 12.6.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.azure", artifactId = "azure-storage-blob" } ]

labels: library-update, semver-minor

The codecov report is wrong. The affected paths are S3 and Sftp, there's no way an update to the azure client affects that


Race condition in AzureServiceBusQueue when multiple processes are creating the same queue

Right now, EnsureQueueCreatedAsync will check if the queue exists, and then if not, it will try to create it. If another process creates the queue in-between these two calls, then the create fails with a MessagingEntityAlreadyExistsException. This is caught and handled and works fine.
However, there's a catch - if another process is currently creating the queue, then it will fail with MessagingException, which is not caught.
The error seen in logs is:
Microsoft.ServiceBus.Messaging.MessagingException: The remote server returned an error: (409) Conflict. SubCode=40901. Another conflicting operation is in progress.

Since MessagingEntityAlreadyExistsException derives from MessagingException, the solution is to catch MessagingException instead.

Fixed by #46


SPI words is vital

Hello,
I integrate the SPI management words:
#define ENABLE_SPI_SUPPORT
//.......
OPTIONAL_SPI_SUPPORT \
//......
 Complete article here: https://esp32.arduino-forth.com/article/display_MAX7219_manage8x8


Initialze Daru::Index from range

@v0dro This is ready to be merged.

@v0dro The to_h works to seem fine in Daru even when using Ruby 2.0. I am currently looking at what the problem is.

This is weird:
[4] pry(main)> RUBY_VERSION
=> "2.0.0"
[5] pry(main)> a = [1, 2, 3].each_with_index
=> #<Enumerator: ...>
[6] pry(main)> a.method(:to_h).source_location
=> ["/home/ubuntu/.rvm/gems/ruby-2.0.0-p643/gems/backports-3.6.8/lib/backports/2.1.0/enumerable/to_h.rb", 4]

Is there any way to check Daru version inside pry?

Finally, here the fix:
Adding   spec.add_development_dependency 'nmatrix', '~> 0.2.1' to specfile of statsample-glm solves the issue.

Why was this happening?

I am investigating.

Here's a permanent fix and it explains the issue: https://github.com/v0dro/daru/pull/126


Add Event Table to Snowflake Provide

Description:
I would like to request the addition of the event table feature to the Snowflake provider in Terraform. Currently, this feature is not supported by the provider. The event table is used for logging and tracing purposes in Snowflake. You can find an example of setting up an event table in the Snowflake documentation: Event Table - Setting Up.
Solution:
I suggest adding two new resources to the Snowflake provider: snowflake_event_table and snowflake_event_table_grant. These resources will allow users to create an event table and grant permissions to it it.  Additionally, the provider can utilize the existing snowflake_account_parameter resource to set the account's event table.
Alternatives Considered:
As an alternative, users can manually create the event table and associate it with their account using  SQL.
Additional Context:
Please note that the event table is still in public preview.

It is the first step toward getting resource added.

Hi @sfc-gh-swinkler, any updates on this topic? or any estimates?

Hey @bob-zarkoob, they are part of https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-the-rest-of-the-fundamental-ga-objects-for-the-provider-v1.


Increase .travis.yml consistency between repos

aspnet/Universe#349
minimize dotnet setup time; no need for caching

2a03500


can you please update for 1.17.1

Thanks Draylar. I hope your day is filled with delicious foods.

90% done, should be out by Wednesday if all goes well

hmmm.. im thinking this will be a future wednesday and maybe support 1.18.1?

Sorry for the wait, https://github.com/Draylar/game-phases/releases/tag/1.1.0-1.17.1 is out and I'm hoping to get 1.18 out today or tomorrow. Just have to update FibLib and then it should be an easy move up! I'll also work on getting documentation out soon:tm:.
FibLib for 1.17 release is at https://github.com/Haven-King/FibLib/releases/tag/1.2.1-1.17 (no libs JIJed).

Initial 1.18.1 is available here with a FibLib build available here. Might push out another release today depending on progress.


Incorrect Momentum Scroll Events fired on Android

[x] I have reviewed the documentation
[x] I have searched existing issues
[ ] I am using the latest React Native version

This is being reproduced with the latest Expo SDK version 25, which uses React Native 52. But I haven't seen any fixes in the changelog since that so I'm assuming it's still happening.

The momentum scroll on Android are firing before the momentum actually ends. Contrary to iOS, which behaves as it should.
Environment

Environment:
OS: macOS High Sierra 10.13.2
Node: 6.12.3
Yarn: 1.5.1
npm: 3.10.10
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: https://github.com/expo/react-native/archive/sdk-25.0.0.tar.gz => 0.52.0
Steps to Reproduce

A snack to reproduce the issue: https://snack.expo.io/@abdallamohamed/onmomentumscroll-bug-on-android
Expected Behavior

Here's how it behaves on iOS:
During a momentum scroll, if you start another scroll:

An onScrollDragBegin is fired.
When the user lifts their finger, an onScrollDragEnd is fired.
An onMomentumScrollBegin is fired and the scrollview starts scrolling.
When it finally stops, an onMomentumScrollEnd is fired.

Actual Behavior

An onScrollDragBegin is fired.
When the user lifts their finger, an onScrollDragEnd is fired.
An onMomentumScrollBegin is fired, followed instantly by 2onMomentumScrollEnd events.
The scrollview keeps scrolling and it finally stops.

1


How to call real function with CMOCK_MOCK_FUNCTIONn macros

I am trying to use new style CMOCK_MOCK_FUNCTIONn macros and want to invoke real function in expectation. I am unable to figure out how to do that?

@devesh25427 please take a look at section Specifying expectations. The botom line is:

The functions are mocked as long as its corresponding mocker class instance exists

If not mocked, the real function will be called.

@hjagodzinski thanks for reply. I understood that real function is called when there is no mock class instance. Earlier I was able to call real function using Invoke(<mock_class_name>::real) because there was a static member in class pointing to real function. I can still see static real function pointer created by CMOCK_MOCK_FUNCTIONn macro but don't know how to call it.
Sometimes I need to call real instance while setting expectation.

I see now what you're after. Unfortunately there is no support for calling a real function while specifying expectations. Internally C Mock keeps pointer to a real function and you could use that but it's far from being ideal. I will look into ways to expose a real function so it can be used in cases like yours.

Thanks @hjagodzinski

@devesh25427 in case you are still interested I have created pull request #22 which provides the means to call a real function when using the CMockMocker class for mocking.


Remove type circularity in wizard.tsx

This code has a type circularity that previously went undetected. Adding an as Wizard assertion here removes the circularity.
See https://github.com/microsoft/TypeScript/issues/46939 / https://github.com/microsoft/TypeScript/pull/46981 for more context

Thank you!
@RyanCavanaugh Please sign your commit.

I'm not really set up to do that; this is mostly an FYI. I'll close and whoever does the TS 4.6 upgrade can refer back to the fix. Thanks!

Thanks for the heads up anyhow.


Suspended users should not be able to cancel their account

Nor, probably, to edit their account.

Actually perhaps they should. They can't easily bypass suspension by doing so (which was the main issue) because they would need to be re-approved so we'd see them coming past.

Agreed (with myself) - it’s not a problem if suspended users cancel their account, and good that they can from a GDPR point of view.


Could not work , even use the official script

(TE) root@bjdb-h20-node-118:/aml/TransformerEngine/examples/pytorch/fsdp# torchrun --standalone --nnodes=1 --nproc-per-node=$(nvidia-smi -L | wc -l) fsdp.py
W0712 09:57:45.035000<PHONE_NUMBER>12128 torch/distributed/run.py:757]
W0712 09:57:45.035000<PHONE_NUMBER>12128 torch/distributed/run.py:757] *****************************************
W0712 09:57:45.035000<PHONE_NUMBER>12128 torch/distributed/run.py:757] Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
W0712 09:57:45.035000<PHONE_NUMBER>12128 torch/distributed/run.py:757] *****************************************
Fatal Python error: Segmentation fault
Current thread 0x00007f2714afb740 (most recent call first):
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/c10d_rendezvous_backend.py", line 113 in _call_store
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/c10d_rendezvous_backend.py", line 64 in init
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/c10d_rendezvous_backend.py", line 259 in create_backend
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/registry.py", line 36 in _create_c10d_handler
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/api.py", line 263 in create_handler
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/rendezvous/registry.py", line 66 in get_rendezvous_handler
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/launcher/api.py", line 235 in launch_agent
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/launcher/api.py", line 132 in call
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/run.py", line 870 in run
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/run.py", line 879 in main
File "/root/miniconda3/envs/TE/lib/python3.12/site-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 347 in wrapper
File "/root/miniconda3/envs/TE/bin/torchrun", line 8 in
Extension modules: numpy.core._multiarray_umath, numpy.core._multiarray_tests, numpy.linalg._umath_linalg, numpy.fft._pocketfft_internal, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._mt19937, numpy.random.mtrand, numpy.random._philox, numpy.random._pcg64, numpy.random._sfc64, numpy.random._generator, torch._C, torch._C._fft, torch._C._linalg, torch._C._nested, torch._C._nn, torch._C._sparse, torch._C._special (total: 20)
Segmentation fault (core dumped)

We should make sure your system is correctly configured and that the distributed job is launched correctly. Otherwise fsdp.py should have printed out the world size:
https://github.com/NVIDIA/TransformerEngine/blob/8e039fdcd98fc56582d81e373880c1509c2b8f73/examples/pytorch/fsdp/fsdp.py#L207
Can you try running the following script with python -m torch.distributed.launch --standalone --nnodes=1 --nproc-per-node=1 test.py?
import sys
def _print(*args, **kwargs):
    print(*args, file=sys.stderr, **kwargs)

_print("Starting script")
import torch
_print("Imported PyTorch")
torch.distributed.init_process_group(backend="nccl")
_print("Initialized NCCL")
rank = torch.distributed.get_rank()
world_size = torch.distributed.get_world_size()
_print(f"{rank=}, {world_size=}")

We should make sure your system is correctly configured and that the distributed job is launched correctly. It's odd that fsdp.py didn't print out the world size after initialization:
https://github.com/NVIDIA/TransformerEngine/blob/8e039fdcd98fc56582d81e373880c1509c2b8f73/examples/pytorch/fsdp/fsdp.py#L207
Can you try running the following script with python -m torch.distributed.launch --standalone --nnodes=1 --nproc-per-node=1 test.py?
import sys
def _print(*args, **kwargs):
    print(*args, file=sys.stderr, **kwargs)

_print("Starting script")
import torch
_print("Imported PyTorch")
torch.distributed.init_process_group(backend="nccl")
_print("Initialized NCCL")
rank = torch.distributed.get_rank()
world_size = torch.distributed.get_world_size()
_print(f"{rank=}, {world_size=}")

HI @timmoon10  this is the output of the script

We should make sure your system is correctly configured and that the distributed job is launched correctly. It's odd that fsdp.py didn't print out the world size after initialization:
https://github.com/NVIDIA/TransformerEngine/blob/8e039fdcd98fc56582d81e373880c1509c2b8f73/examples/pytorch/fsdp/fsdp.py#L207
Can you try running the following script with python -m torch.distributed.launch --standalone --nnodes=1 --nproc-per-node=1 test.py?
import sys
def _print(*args, **kwargs):
    print(*args, file=sys.stderr, **kwargs)

_print("Starting script")
import torch
_print("Imported PyTorch")
torch.distributed.init_process_group(backend="nccl")
_print("Initialized NCCL")
rank = torch.distributed.get_rank()
world_size = torch.distributed.get_world_size()
_print(f"{rank=}, {world_size=}")

HI @timmoon10  this is the output of the script

Interesting, so we need to figure out why the toy script worked while FSDP script failed somewhere before:
https://github.com/NVIDIA/TransformerEngine/blob/8e039fdcd98fc56582d81e373880c1509c2b8f73/examples/pytorch/fsdp/fsdp.py#L205-L207
Differences I can see:

python -m torch.distributed.launch vs torchrun
Multi-GPU vs single-GPU
torch.cuda.set_device
PyTorch and Transformer Engine imports: https://github.com/NVIDIA/TransformerEngine/blob/8e039fdcd98fc56582d81e373880c1509c2b8f73/examples/pytorch/fsdp/fsdp.py#L10-L22


'container update' command; closes #149

Currently, updating a container that doesn't exist returns an empty error. That'll be fixed by #164


Configurable Retry Logic

This is a complimentary PR to complete the remaining works, extend the feature, and address comments on PR #693.

Did you mean to check in the two DLLs?

If you mean ClassLibrary_CustomConfigurableRetryLogic DLLs, I'd say they're customized retry logics compiled for .Net Framework and .Net Core to assess the external injection by test project for different .Net versions.

I've been having trouble with the tests due to the new default use of the retry policy. It looks like if no policy is set and the connection can't be made (for example a bad connection string) you can end up in an infinite retry loop which stops the manual tests dead where they used to just fail the individual test and continue.
I've also hit a case trying to debug where a config property is passed to the retry policy setup and assert that it isn't null but at runtime the null is accepted, since we don't run the tests with debug builds this will never be hit so either it's missing an important case that should be tested or it's a worthless assert.

I've been having trouble with the tests due to the new default use of the retry policy. It looks like if no policy is set and the connection can't be made (for example a bad connection string) you can end up in an infinite retry loop which stops the manual tests dead where they used to just fail the individual test and continue.

It's not clear to me under what circumstances it will go to an infinite loop. Could you provide more step-by-step information, please?

I've also hit a case trying to debug where a config property is passed to the retry policy setup and assert that it isn't null but at runtime the null is accepted, since we don't run the tests with debug builds this will never be hit so either it's missing an important case that should be tested or it's a worthless assert.

Suppose you're pointing to the SqlRetryLogicProvider. In that case, generally, I assert null values in debug mode for internal usage to enforce an object creation at design time. Since this is an internal type and isn't going to be accessible directly, I've included the assert in debug mode to prevent null usage at design time; and this parameter won't be null. If you have another scenario, please include it here for further discussion.

It's not clear to me under what circumstances it will go to an infinite loop. Could you provide more step-by-step information, please?

Running the manual tests locally will always fail in the retry logic at the moment. Master, netcore2.1, build run and wait for it to just stop in the exponential retry test.

Try breaking your named pipes connection string. Then it'll hit the infinite loop with an exponential backoff. In order to make it actually work you'll have to update the manual tests project to copy the config file on build, at the moment it doesn't and that's caused me a lot of problems.
Named pipes didn't work on my machine for some reason and over the weekend I uninstalled cleaned and then reinstalled SqlServer. So I'm setting everything up from clean, if you can't connect using "np:localhost" then previously some tests failed but it was ok because I knew which ones they were. Now I can't complete a test run because it hits a loop. Yes, I should fix my machine and I'm working on that but having the ability for the tests to fall into an endless loop doesn't seem like a good idea anyway.
A couple of things I noticed while looking at the retry code as it is as the moment in master;
https://github.com/dotnet/SqlClient/blob/554c0156c0227b41c08fbaeea1b030149f0c2976/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/SqlConfigurableRetryLogicManager.CreateProvider.cs#L73-L76
This is problematic because it causes an exception on any OpenAsync call which doesn't have a policy, which at the moment is all of them. Instead of null check then throw could you just if and jump to using the default?
On that call stack that leads to that there's this call:
https://github.com/dotnet/SqlClient/blob/554c0156c0227b41c08fbaeea1b030149f0c2976/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1459-L1462
Which is going to cause an instance delegate to be allocated each time it's invoked. Could that be changed to a lambda which takes the token and connection as a params and then the compiler can use a hidden static delegate.

Call Stack:
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(Microsoft.Data.SqlClient.ServerInfo serverInfo = {Microsoft.Data.SqlClient.ServerInfo}, string newPassword = "", System.Security.SecureString newSecurePassword = null, bool redirectedUserInstance = false, Microsoft.Data.SqlClient.SqlConnectionString connectionOptions = {Microsoft.Data.SqlClient.SqlConnectionString}, Microsoft.Data.SqlClient.SqlCredential credential = null, Microsoft.Data.ProviderBase.TimeoutTimer timeout = {Microsoft.Data.ProviderBase.TimeoutTimer})	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(Microsoft.Data.ProviderBase.TimeoutTimer timeout, Microsoft.Data.SqlClient.SqlConnectionString connectionOptions, Microsoft.Data.SqlClient.SqlCredential credential, string newPassword, System.Security.SecureString newSecurePassword, bool redirectedUserInstance)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlInternalConnectionTds.SqlInternalConnectionTds(Microsoft.Data.ProviderBase.DbConnectionPoolIdentity identity, Microsoft.Data.SqlClient.SqlConnectionString connectionOptions = {Microsoft.Data.SqlClient.SqlConnectionString}, Microsoft.Data.SqlClient.SqlCredential credential = null, object providerInfo, string newPassword = "", System.Security.SecureString newSecurePassword = null, bool redirectedUserInstance = false, Microsoft.Data.SqlClient.SqlConnectionString userConnectionOptions, Microsoft.Data.SqlClient.SessionData reconnectSessionData, bool applyTransientFaultHandling = true, string accessToken, Microsoft.Data.ProviderBase.DbConnectionPool pool)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(Microsoft.Data.Common.DbConnectionOptions options, Microsoft.Data.Common.DbConnectionPoolKey poolKey, object poolGroupProviderInfo, Microsoft.Data.ProviderBase.DbConnectionPool pool, System.Data.Common.DbConnection owningConnection, Microsoft.Data.Common.DbConnectionOptions userOptions)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(System.Data.Common.DbConnection owningConnection = {Microsoft.Data.SqlClient.SqlConnection}, Microsoft.Data.ProviderBase.DbConnectionPoolGroup poolGroup, Microsoft.Data.Common.DbConnectionOptions userOptions)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(System.Data.Common.DbConnection owningConnection = {Microsoft.Data.SqlClient.SqlConnection}, System.Threading.Tasks.TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal> retry = null, Microsoft.Data.Common.DbConnectionOptions userOptions = {Microsoft.Data.SqlClient.SqlConnectionString}, Microsoft.Data.ProviderBase.DbConnectionInternal oldConnection = {Microsoft.Data.ProviderBase.DbConnectionClosedNeverOpened}, out Microsoft.Data.ProviderBase.DbConnectionInternal connection = null)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(System.Data.Common.DbConnection outerConnection = {Microsoft.Data.SqlClient.SqlConnection}, Microsoft.Data.ProviderBase.DbConnectionFactory connectionFactory = {Microsoft.Data.SqlClient.SqlConnectionFactory}, System.Threading.Tasks.TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal> retry, Microsoft.Data.Common.DbConnectionOptions userOptions)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlConnection.TryOpen(System.Threading.Tasks.TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal> retry = null, Microsoft.Data.SqlClient.SqlConnectionOverrides overrides)	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute<bool>(object sender = {Microsoft.Data.SqlClient.SqlConnection}, System.Func<bool> function = {Method = {System.Reflection.RuntimeMethodInfo}})	Unknown	Non-user code. Skipped loading symbols.
 	Microsoft.Data.SqlClient.dll!Microsoft.Data.SqlClient.SqlConnection.Open(Microsoft.Data.SqlClient.SqlConnectionOverrides overrides)	Unknown	Non-user code. Skipped loading symbols.
 	ManualTests.dll!Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.ConcurrentExecution(string cnnString = "Data Source=np:localhost;Initial Catalog=Northwind;Integrated Security=True;Pooling=False;Connect Timeout=5", Microsoft.Data.SqlClient.SqlRetryLogicBaseProvider provider = {Microsoft.Data.SqlClient.SqlRetryLogicProvider})	Unknown	Non-user code. Skipped loading symbols.
 	[Native to Managed Transition]		Annotated Frame
 	[Managed to Native Transition]		Annotated Frame
 	xunit.execution.dotnet.dll!Xunit.Sdk.TestInvoker<System.__Canon>.CallTestMethod(object testClassInstance) Line 150	C#	Non-user code. Symbols loaded.
 	xunit.execution.dotnet.dll!Xunit.Sdk.TestInvoker<Xunit.Sdk.IXunitTestCase>.InvokeTestMethodAsync.AnonymousMethod__1() Line 257	C#	Non-user code. Symbols loaded.
 	xunit.execution.dotnet.dll!Xunit.Sdk.ExecutionTimer.AggregateAsync(System.Func<System.Threading.Tasks.Task> asyncAction = {Method = {System.Reflection.RuntimeMethodInfo}}) Line 48	C#	Non-user code. Symbols loaded.

That's great if "np:localhost" works on your machine you'll have no problems. Change it to something that you know won't work and then run the manual tests, they'll hang.

Results by invalid "NPConnectionString": "Data Source=np:localhost;Database=Northwind__;Integrated Security=true;"

for the SqlConnectionReliabilityTest:

for the SqlCommandReliabilityTest:

And for SqlConnectionReliabilityTest by "NPConnectionString": "Data Source=npt:localhost;Database=Northwind__;Integrated Security=true;":

Still can't find hang or infinite loop!
Here is the command to run the tests:
dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" /p:Platform="AnyCPU" /p:Configuration="Release" /p:TestTargetOS=Windowsnetcoreapp --no-build -v n  --filter "SqlConnectionReliabilityTest" /p:TargetNetCoreVersion=netcoreapp2.1

I'm also in agreement with @Wraith2 's comment above and would suggest something like:
public override object ExecuteScalar()
{
...
    if (IsRetryOptedIn) // Check if user enabled App Context switch here
    {
        ds = RetryLogicProvider.Execute(this, () => RunExecuteReader(0, RunBehavior.ReturnImmediately, returnStream: true));
    }
    else
    {
        ds = RunExecuteReader(0, RunBehavior.ReturnImmediately, returnStream: true);
    }

[Similarly for other APIs]
I think the check for App Context switch that happens inside the Reliability layer is too late, but based on perf results I didn't consider that significant before. But I agree if we can avoid it's after-effects, that should be preferred way to go. So until users opt-in, they should not get affected by any means. For other reliability implementation inside SqlConnection too, we should be checking App context switch earliest before changing any flow, if it's avoidable.

It will need to be split out into a second function. The compiler hoists the closure into the scope of the containing function to ensure that the variables contained within the closure are always accessed through it. Compare these two:
With Local Function:
        public override Task OpenAsync(CancellationToken cancellationToken)
        {
            if (!RetryLogicProvider.Enabled)
            {
                return InternalOpenAsync(cancellationToken);
            }
            else
            {
                return OpenAsyncWithRetry(cancellationToken);
            }

            Task OpenAsyncWithRetry(CancellationToken token)
            {
                return RetryLogicProvider.ExecuteAsync(this, () => InternalOpenAsync(token), token);
            }
        }

public override Task OpenAsync(CancellationToken cancellationToken)
{
	if (!RetryLogicProvider.Enabled)
	{
		return InternalOpenAsync(cancellationToken);
	}
	return <OpenAsync>g__OpenAsyncWithRetry|148_0(cancellationToken);
}

[CompilerGenerated]
private Task <OpenAsync>g__OpenAsyncWithRetry|148_0(CancellationToken token)
{
	<>c__DisplayClass148_0 <>c__DisplayClass148_ = new <>c__DisplayClass148_0();
	<>c__DisplayClass148_.<>4__this = this;
	<>c__DisplayClass148_.token = token;
	return RetryLogicProvider.ExecuteAsync(this, new Func<Task>(<>c__DisplayClass148_.<OpenAsync>b__1), <>c__DisplayClass148_.token);
}

With Inline Call:
        public override Task OpenAsync(CancellationToken cancellationToken)
        {
            if (!RetryLogicProvider.Enabled)
            {
                return InternalOpenAsync(cancellationToken);
            }
            else
            {
                return RetryLogicProvider.ExecuteAsync(this, () => InternalOpenAsync(cancellationToken), cancellationToken);
            }
        }

public override Task OpenAsync(CancellationToken cancellationToken)
{
	<>c__DisplayClass148_0 <>c__DisplayClass148_ = new <>c__DisplayClass148_0();
	<>c__DisplayClass148_.<>4__this = this;
	<>c__DisplayClass148_.cancellationToken = cancellationToken;
	if (!RetryLogicProvider.Enabled)
	{
		return InternalOpenAsync(<>c__DisplayClass148_.cancellationToken);
	}
	return RetryLogicProvider.ExecuteAsync(this, new Func<Task>(<>c__DisplayClass148_.<OpenAsync>b__0), <>c__DisplayClass148_.cancellationToken);
}

Which shows that only if you split out the call do you avoid the allocations. I like the local function approach because it keeps the allocating call wrapper private to the callsite. I'm not wild about the compiler naming convention. I could be convinced that it's better as a full private function.

In that case, we can pass method delegate to a common method too (compacted version):
    public override Task OpenAsync(CancellationToken cancellationToken) =>
        (!IsRetryEnabled ? InternalOpenAsync(cancellationToken) :
            DoTaskWithRetry(InternalOpenAsync(cancellationToken), cancellationToken));

    // This can also go in a Util class so SqlCommand can also use this.
    internal Task DoTaskWithRetry(Task task, CancellationToken token) =>
        RetryLogicProvider.ExecuteAsync(this, () => task, token);

    // Stays with other App Context Flags or in Utils
    internal bool IsRetryEnabled = <TryGetSwitch>;

Similar redirect APIs can be written for other RetryLogicProvider Execute APIs, so that we can prevent the default RetryLogicProvider from loading and control it externally.

I'm not fully following the discussion, but if the concern here is about heap allocations introduced because of closures, then that can be avoided without introducing a special opt-in flag. Make your lambdas static (via the new C# 9 syntax), and pass whatever objects you need to reference as parameters (including this).

See https://github.com/dotnet/efcore/pull/24208 for an example of a similar change in EF Core.

I looked into doing that @roji but that would need changes to the callsites in SqlRetryLogicBaseProvider which is publicly exposed. Even if we wanted to change that class it would expose the people who wanted to implement their own retry provider to the internal workings because they'd be given access to the closure object rather than it being baked into the delegate. The way around that it to make the retry provider less generic and have context objects for each of the internal calls that needs retrying.
I'd like to get c#9 in the library because it would make the static delegates I add a lot cleaner, they'd be compiler generated instead of me littering them all over the place manually. I talked to roslyn team and they say it's not supported but that it will work and won't generate invalid il that netfx can't use as long as we don't use features that require runtime support, static delegates do not require runtime support.

Hi @roji
This is a preview feature and is not meant to be consumable by default. Hence it's controlled with App Context switch which is going to be disabled by default. Our intention is to not change driver behavior for user applications that don't want to use Retry Logic Provider right now, including any visible allocations/performance cost.
We're trying to move AppContext switch checks from internal provider layer to driver layers where this feature begins to allocate resources that are not needed.

Apologies if I'm misunderstanding things - I really am missing a lot of the context. This would indeed require adding a RetryLogicProvider.Execute overload which accepts a "state" parameter and passes it to the lambda; this overload could then be called from OpenAsync, ExecuteScalar or anywhere else. I understand that RetryLogicProvider is an abstraction meant to be passed from the outside - FWIW methods accepting both a lambda and a state parameter to be passed to that lambda are very common in .NET precisely to avoid the heap allocation issue. The fact that people are exposed to that parameter doesn't seem problematic to me - part of the contract of a retrying provider would simply be for the implementation to pass that parameter when invoking the lambda. BTW I'd suggest taking a look at what we've done around this in EF Core, the concepts are very similar (e.g. an abstraction that's meant to be implemented by external users or providers).
Re changing driver behavior, if you have a default NoopRetryLogicProvider that simply executes the given lambda once, everything should just work well, with no behavior changes or perf regressions. But if there's some reason why you can't introduce the new overload, then the above suggestions do seem right.
Re C# 9 static lambdas, that is only an optional thing in this context - as long as a lambda doesn't refer to anything other than its parameters, it wouldn't be a closure and trigger any heap allocations. The C# 9 feature only helps avoid accidentally introducing such a reference, but as long as you're willing to introduce the new overload above the problem should go away.

It requires 2 state parameters, this and cancelationToken, which means a tuple or some custom context object. the instance delegate contains the this ref so you only see one stat parameter but if we make it static as you suggest (and i'd have liked) then we have to pass in two params. Ultimately for an async call to be retried we're going to have to save the state on the heap sometime so closures are likely to be somewhere i'd just like to move them into a path that is only taken if the user wants to have retry logic active.

Valuetuples box with async because they're always either part of the async closure or they're passed in an object typed state parameter. If you strongly type the state params you end up with the sort of code we have in AsyncHelper which is complicated and still can't avoid allocations. We also can't use valuetuple in netfx without requiring a new non oob dependency which might be possible but isn't my decision to make.

the heap allocations from the closures are unrelated (and in addition to) any async state

To do any async call to signature other than static void fn() you require at least one piece of state. In order to suspend and allow threadless awaiting that information will always end up on the heap. The runtime only provides the ability to pass a single state object (unless you can conceal one in an TCS and recover it through task.AsyncState)  and it is typed as object so any valuetype will box. There are no ways around this if you end up with a non synchronous completion.

Oh and another thing I noticed was that the retry api is using IEnumerator parameters and i think it should probably be using IEnumerable parameters. It's technically a breach of the rules to re-use an enumerator since there's no way to rewind them. An enumerable object can return itself multiple times it is a static implementation that is safe.

Valuetuples box with async because they're always either part of the async closure or they're passed in an object typed state parameter. If you strongly type the state params you end up with the sort of code we have in AsyncHelper which is complicated and still can't avoid allocations.

Yes, I'm suggesting making the state parameter generic. I'm not sure what's complicated about that, and especially why it doesn't avoid allocation; it's just a generic parameter that gets passed to a function. Again, if look at the PR cited above, you can see it working and not allocating. This part of it has nothing to do with whether the method is async or not - it's just about whether your lambda is a closure or not.

We also can't use valuetuple in netfx without requiring a new non oob dependency which might be possible but isn't my decision to make.

OK.

the heap allocations from the closures are unrelated (and in addition to) any async state

To do any async call to signature other than static void fn() you require at least one piece of state. In order to suspend and allow threadless awaiting that information will always end up on the heap. The runtime only provides the ability to pass a single state object (unless you can conceal one in an TCS and recover it through task.AsyncState) and it is typed as object so any valuetype will box. There are no ways around this if you end up with a non synchronous completion.

I honestly don't understand what the above has to do with closure heap allocations. I also suspect you're talking about some SqlClient-specific detail of how you guys implement async - regular C# async/await methods have no single state object typed as an object, etc. I really think all this is irrelevant to what we're discussing.

The static lambda will eliminate the delegate allocation. That seems like a good idea, compiler supported or not. I'd like to use the static keyword for safety and ease of use. Agreed on those points.
How the closure of state is transported, compiler generated or manually, isn't important to me since we can't avoid it. If we use manual context it will change the published surface area of the retry provider. I assume that would be a bad thing.

OK, thanks for listening on this. To summarize my point, ignoring SqlClient-specific constraints for a second, in C# it's quite easy to manage the abovein a way that will be zero-allocation.
Specifically in SqlClient, if you can't add the required public method to RetryLogicProvider for some reason (Is this type already public? I'm not seeing it in the docs), and/or cannot use value tuples and prefer not to use structs in their place, then that indeed cannot be done. Splitting your method into two, so that the closure occurs only when the feature flag is on, seems like the right way to restrict the closure allocations to when the feature flag is on.

In that case, we can pass method delegate to a common method too (compacted version):
    public override Task OpenAsync(CancellationToken cancellationToken) =>
        (!IsRetryEnabled ? InternalOpenAsync(cancellationToken) :
            DoTaskWithRetry(InternalOpenAsync(cancellationToken), cancellationToken));

    // This can also go in a Util class so SqlCommand can also use this.
    internal Task DoTaskWithRetry(Task task, CancellationToken token) =>
        RetryLogicProvider.ExecuteAsync(this, () => task, token);

    // Stays with other App Context Flags or in Utils
    internal bool IsRetryEnabled = <TryGetSwitch>;

Similar redirect APIs can be written for other RetryLogicProvider Execute APIs, so that we can prevent the default RetryLogicProvider from loading and control it externally.

Great conversation! The intent of the initial prototype was indeed to avoid any allocation in case retry logic was not configured for connection opening and command execution (meaning if no config file section or explicit assignment in code was there). Setting aside the App Context switch, which in my mind should only exists during Preview, why the IsRetryEnable switch couldn't just check the condition above?

Setting aside the App Context switch, which in my mind should only exists during Preview, why the IsRetryEnable switch couldn't just check the condition above?

The exact implementation can be whatever works best I just extended the existing enabled flag from the provider internals to the provider surface. If there's any easier and lower cost way to do the operation I'd be happy with it.
In order to check if there's a config the loader logic has to do a fairly costly one-time check (does io) parses and instantiates the used defined provider with using reflection. That logic is hidden in the static RetryLogicProvider internals and I'm not sure there's a low overhead way to do that and meet the hard requirement that this feature should require no calling code changes to be configurable. My view was that the lazy init had to happen sometime so it may as well happen on the first connection attempt and have it over with.

In order to check if there's a config the loader logic has to do a fairly costly one-time check (does io) parses and instantiates the used defined provider with using reflection. That logic is hidden in the static RetryLogicProvider internals and I'm not sure there's a low overhead way to do that and meet the hard requirement that this feature should require no calling code changes to be configurable. My view was that the lazy init had to happen sometime so it may as well happen on the first connection attempt and have it over with.

That was exactly my idea. Isn't that the same in other config sections like for authentication provider? if i remember correctly we mentioned that in previous conversations.

It may be the same. The authentication code addition predates my experience with this library and it isn't something that has come up with any of the performance changes I've made so I don't know much about it. As long as there is some way to avoid casual users paying a penalty for a feature they aren't using I'm not too bothered about the implementation detail.

I just did a quick profile run on this and the additional changes to avoid allocations worked well. I can't see anything obviously attributable to retry logic when it isn't enabled. Good job @DavoudEshtehari

@DavoudEshtehari question - why is error 4060 on the list of transient errors? I see comments in SMO and SSMS code that say 4060 means the database doesn't exist.

I haven't reviewed the SSMS logic, but according to the documentation, error number 4060 is listed as one of the transient errors for Azure SQL Server.

@shueybubbles IIRC, it's because, on startup, database availability can be delayed between the time a server starts accepting connections and the time a particular database is available. So, adding automatic retries reduces the incidences of connection failure when a server is starting up but a database is not yet available.

Well, we need a new error value for the cloud case, then. It's pointless to keep trying when the server knows there no such database.

@shueybubbles
Yes, sleeping databases is another issue. I think they prioritized making serverless as seamless as possible for existing apps to adopt and made some compromises that limit options.
There is a good recent conversation on the EF repo about transient 4060 errors and create database actions: https://github.com/dotnet/efcore/issues/33191


Rancher 2.2 Alpha 6 monitoring notification send_resolved: true

What kind of request is this (question/bug/enhancement/feature request):
enhancement
Steps to reproduce (least amount of steps as possible):
Goto monitoring, 'Add notify'
For option, 'Email', Slack and so on, there is no option to set  'send_resolved:true'. That cause Prometheus alertmanager to send alert [resolved]
Result:
Other details that may be helpful:
Email sample

name: 'wi-email'
email_configs:

to<EMAIL_ADDRESS>send_resolved: true

Slack sample

name: 'instalment'
slack_configs:

channel: application-channel
send_resolved: true
text: "{{ range .Alerts }}{{ .Annotations.description }}\n{{ end }}"
http_config:
tls_config:
insecure_skip_verify: ALERTMGR_SSL_SKIP_VERIFY
proxy_url: http://proxy:8080

In master-head 9ce31ab5e
The option Send Resolved Alerts is available for all supported notifiers.

add Slack as a notifier with the Send Resolved Alerts option enabled,

see the value "sendResolved": true in the API call's response and when viewing in API

enable the cluster monitoring

At the cluster-level alert section, configure the following alert

launch an app which pods are deployed in the node jiaqi-master-worker1

receive the alter in Slack:

The CPU usage on the node jiaqi-master-worker1 is over 20%
Alert Name: a2
Severity: critical
Cluster Name: do (ID: c-7h9jt)
Used CPU: 1500 m
Total CPU: 4000 m

delete the app
wait for a while, receive the following message that contains only the title of the previous alter

The CPU usage on the node jiaqi-master-worker1 is over 20%

@gitlawr Is it a valid testing case? Is the second alert message (the one has only the title) the resolved alert?

@jiaqiluo We should make the text more clear

The bug fix is validated in rancher:master-head 41ce3ac49
Following the same steps as my previous comment describes, now the messages in Slack is clear to tell us the alter is resolved.


Can't scroll page while mousing over "Report Content" modal

Description

If you open the Report Content modal on a single result page, you are only able to scroll the body of the page if your cursor is hovering outside the modal.
Reproduction

Open any single image page.
Click Report this content to open the modal
Move your cursor outside of the modal (but do not click). See that you can scroll the page.
Mouse over the modal itself, and attempt to scroll. See that you can no longer scroll the page (and the modal itself is not scrollable).

Resolution

[ ] 🙋 I would be interested in resolving this bug.

@stacimc can`t recreate this. am i doing something wrong?
https://user-images.githubusercontent.com/29175506/204260676-4b82a2e3-57c6-466b-bc26-6106da545ca3.mp4


Data Augmentation Techniques

Related Issue: #416

@shreya024 you can Bold heading by using (## write here ) in a separate cell ,do it in your .ipynb

@shreya024 you can Bold heading by using (## write here ) in a separate cell ,do it in your .ipynb

I have added the headings in ipynb

@Rutikab12 Kindly add the labels


Issue 56 - remove special chars in package names

added new function to replace non a-z, 0-9 characters with underscores. Also added the sanitizer to the Service name creation function. Added simple text fixtures to based on the existing cat fixtures.

🌮 🍾 thanks, @dnfehren!!


Add webhook support

Webhook support would probably be a good idea, as github commits and other stuff support them, so I can have a github feed in a server

Issue already tracked here: https://github.com/revoltchat/delta/issues/6


Option to add custom search engines like searXNG

And Kagi!

You can already add custom search engines.

You can do that. Turn on search.useCustomEngine and add enter a customEngineURL


Adding upgrade chain test

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #2143 (4856409) into main (dcd616c) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   80.03%   79.28%   -0.76%
==========================================
  Files         170      170
  Lines       11823    11855      +32
==========================================
- Hits         9463     9399      -64
- Misses       1942     2040      +98
+ Partials      418      416       -2

Impacted Files
Coverage Δ

...ps/27-interchain-accounts/controller/types/msgs.go
58.82% <0.00%> (-32.09%)
:arrow_down:

modules/apps/27-interchain-accounts/types/codec.go
79.54% <0.00%> (-0.89%)
:arrow_down:

.../apps/27-interchain-accounts/host/keeper/keeper.go
83.33% <0.00%> (ø)

...apps/27-interchain-accounts/host/keeper/genesis.go
89.47% <0.00%> (ø)

...s/27-interchain-accounts/controller/types/codec.go
0.00% <0.00%> (ø)

...27-interchain-accounts/controller/keeper/keeper.go
94.73% <0.00%> (ø)

...dules/apps/27-interchain-accounts/types/genesis.go

...ps/27-interchain-accounts/genesis/types/genesis.go
0.00% <0.00%> (ø)

modules/apps/27-interchain-accounts/module.go
56.62% <0.00%> (+0.52%)
:arrow_up:

...7-interchain-accounts/controller/keeper/account.go
82.35% <0.00%> (+4.57%)
:arrow_up:

... and 1 more


DateTime and Date Form Field

When selecting DateTime or Date in wagtailadmin it sets the html for the form to type='text' instead of type='date'.

Hi @SableWalnut,
The type attribute we use here is inherited from Django's own DateInput / DateTimeInput widgets. According to https://code.djangoproject.com/ticket/16630#comment:11, Django made the decision not to adopt type='date' at the same time as implementing type='email', type='url' etc, as this would disallow certain date formats that we wish to accept. This would be an issue on Wagtail too, so I think it's best to keep the current type='text' behaviour.
#880 adds the ability to override the widget on a FieldPanel, so it will be possible for users to replace the default widget with a custom one that uses type='date' if desired.


Update Twitter logo

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Updated the Twitter logo in HTML files to use the new FontAwesome class.

Verification
I tested the changes by following these steps:

Made the necessary changes to the HTML files as described in the issue #6624.
Opened the HTML files in Visual Studio Code.
Used the Live Server extension in Visual Studio Code to preview the changes in a local development environment.
Confirmed that the new Twitter logo is displayed correctly in the browser when using the Live Server.
Inspected the HTML elements to ensure that the updated FontAwesome class is applied.

The changes are working as expected, and the new Twitter logo is displayed correctly when using the Live Server for testing.

If you have any further questions or need more information, please let me know!

Can you please fix DCO?

Can you check https://deploy-preview-6627--thanos-io.netlify.app/ and see if it is working as expected? I think some logos are still the old one

now that you added a new commit, can you please sign the DCO again for your latest commit?

Fixed

I have tried everything possible but dont know whats happening. Let me create another branch and create another pull request.


PropagationType.CUSTOM is not supported (?)

Hi, I'm trying to implement a custom propagation, following an official doc: https://docs.spring.io/spring-cloud-sleuth/docs/current-SNAPSHOT/reference/html/howto.html#how-to-change-context-propagation
I copied code as is, and created a configuration for new propagation mechanism:
@Configuration
@AutoConfigureBefore(BraveAutoConfiguration.class)
class CustomPropagationAutoConfiguration {
    @Bean
    CustomPropagation customPropagation() {
        return new CustomPropagation();
    }
}

But I can't make it work, and I suspect that it's not yet supported (?)
https://github.com/spring-cloud/spring-cloud-sleuth/blob/76ad931b4298b18389d0a4ea739316c14682888b/spring-cloud-sleuth-brave/src/main/java/org/springframework/cloud/sleuth/brave/bridge/CompositePropagationFactorySupplier.java#L82
Is there anything I'm missing? Or since it's not implemented, I should create my own FactorySupplier bean as well (for time being)?

Can you show that in a sample?

Sorry for a false report, I couldn't replicate an issue in a demo project, and so I was able to find an error in my package.
There's one thing though, which probably should be fixed in another ticket, I think.
I have the following properties:
spring.sleuth.propagation.type=CUSTOM

yet I have the following request:
GET http://localhost:8080/test

HTTP/1.1 200
Content-Type: application/json
Transfer-Encoding: chunked
Date: Mon, 01 Feb 2021 12:11:52 GMT
Keep-Alive: timeout=60
Connection: keep-alive

{
  "Accept": "text/plain, application/json, application/*+json, */*",
  "Host": "httpbin.org",
  "User-Agent": "Java/11.0.10",
  "X-Amzn-Trace-Id": "Root=1-6017f008-2acd2edb69b0d07879741fde",
  "X-Custom-Trace": "21dbc394894528c6:a5e5664b61305cce"
}

Response code: 200; Time: 2400ms; Content length: 229 bytes

X-Amzn-Trace-Id shouldn't be present
Complete snippet:
package custom.sleuth.propagation.demo

import brave.internal.codec.HexCodec
import brave.internal.propagation.StringPropagationAdapter
import brave.propagation.Propagation
import brave.propagation.TraceContext
import brave.propagation.TraceContext.Extractor
import brave.propagation.TraceContext.Injector
import brave.propagation.TraceContextOrSamplingFlags
import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.module.kotlin.convertValue
import com.fasterxml.jackson.module.kotlin.readValue
import org.springframework.boot.autoconfigure.AutoConfigureBefore
import org.springframework.boot.autoconfigure.SpringBootApplication
import org.springframework.boot.runApplication
import org.springframework.cloud.sleuth.autoconfig.brave.BraveAutoConfiguration
import org.springframework.context.annotation.Bean
import org.springframework.context.annotation.Configuration
import org.springframework.web.bind.annotation.GetMapping
import org.springframework.web.bind.annotation.RestController
import org.springframework.web.client.RestTemplate
import java.util.Objects

@SpringBootApplication
class Application

fun main(args: Array<String>) {
    runApplication<Application>(*args)
}

const val CUSTOM_TRACE_HEADER = "x-custom-trace"

@Configuration
class RestTemplateConfiguration {
    @Bean
    fun restTemplate(): RestTemplate = RestTemplate()
}

@RestController
class TestController(
    val restTemplate: RestTemplate,
    val objectMapper: ObjectMapper
) {
    @GetMapping("/test")
    fun test(): Map<String, String> {
        val response = restTemplate.getForEntity("https://httpbin.org/anything", String::class.java)
        val body = objectMapper.readValue<Map<String, Any>>(response.body!!)
        return body["headers"] as Map<String, String>
    }
}

@Configuration
class CustomPropagationConfiguration {
    @Bean
    fun customTracePropagation(): CustomTracePropagation {
        return CustomTracePropagation()
    }
}

class CustomTracePropagation : Propagation.Factory(), Propagation<String> {
    override fun keys(): List<String> = KEYS

    override fun <R> injector(setter: Propagation.Setter<R, String>): Injector<R> {
        return Injector { traceContext: TraceContext, request: R ->
            val trace = traceContext.traceIdString() + ":" + traceContext.spanIdString()
            setter.put(request, CUSTOM_TRACE_HEADER, trace)
        }
    }

    override fun <R> extractor(getter: Propagation.Getter<R, String>): Extractor<R> {
        Objects.requireNonNull(getter)
        return CustomTraceExtractor(getter)
    }

    override fun <K> create(keyFactory: Propagation.KeyFactory<K>): Propagation<K> {
        return StringPropagationAdapter.create(this, keyFactory)
    }

    companion object {
        val KEYS = listOf(CUSTOM_TRACE_HEADER)
    }
}

class CustomTraceExtractor<R>(
    private val getter: Propagation.Getter<R, String>
) : Extractor<R> {
    override fun extract(request: R): TraceContextOrSamplingFlags {
        val traceString = getter[request, CUSTOM_TRACE_HEADER]
        if (traceString == null || traceString.isBlank()) {
            return TraceContextOrSamplingFlags.EMPTY
        }
        val trace = traceString.split(":").toTypedArray()

        if (trace.size != 2) {
            return TraceContextOrSamplingFlags.EMPTY
        }

        return try {
            val traceContext = TraceContext.newBuilder()
                .traceId(HexCodec.lowerHexToUnsignedLong(trace[0]))
                .spanId(HexCodec.lowerHexToUnsignedLong(trace[1]))
                .build()
            TraceContextOrSamplingFlags.create(traceContext)
        } catch (ex: NumberFormatException) {
            TraceContextOrSamplingFlags.EMPTY
        }
    }
}

or
full maven project: sleuth-propagation.zip

Can you please rewrite this to java? It will be much easier for me to work with this. Also, do you append any headers to the incoming request?

@marcingrzejszczak here you go
sleuth-propagation.zip


[Bug]: Blank line inserted at top of file every time inline value edited in db table

Contact Details
No response
What happened?
I use inline variables instead of YAML for my db values. Whenever I make a change to a value using the plugin there is a blank line inserted at the top of the changed file. This is consistently reproducible.
As an example, if I have a file that contains only this text:
variable1:: value1

and I edit value1 in a db table, a blank line will be inserted at the top of the file. If I change the value again in the table, another blank line is inserted at the top.  I tried changing the "Select position for new inline fields" to "bottom" even though I wasn't adding any new fields, but that didn't fix the issue. It doesn't matter if there is other text above or below the inline variable.
I'm using Obsidian version 1.0.0.  The OS is Windows 10. I did searches here for "line," "blank," etc. but didn't see this mentioned.
What platform were you using?
Desktop
Version of the plugin
2.7.1
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

Edit: Updated to be more concise.

Just for some extra info, I created a new file that only had

variable:: value

at the top, and nothing else in the file, and was able to reproduce the issue.

fixed =) thanks for the report was a regression of the last version


For a 0.1.0 release, take II

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3695ce2). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   88.43%
=========================================
  Files             ?       19
  Lines             ?      467
  Branches          ?        0
=========================================
  Hits              ?      413
  Misses            ?       54
  Partials          ?        0


How to estimate the memory use of cc-metric-store

We want to use clustercockpit to monitor the cluster with 3000 nodes. Now the seperate machine installing clustercockpit is 8Gb memory. When the cc-metric-store start, the memory use of this machine will reach 90% or above, then it killed by system. To resolve this problem, we want to increas memory of machine, but we don't know the much memory is enough.
Is there a recommanded memory of our project?
The config of cc-metric-store is below:

numbers of nodes: 3000
numbers of metrics: 100+
"checkpoints" interval: 12h
"checkpoints" restore: 24h
retention-in-memory： 24h

We migrated this issue to the cc-metric-store repo:
https://github.com/ClusterCockpit/cc-metric-store/issues/17
Sorry for the delayed answer. We will address this soon, maybe by providing a script.


Flaky test: Ensure VMI has updated migration status

What this PR does / why we need it:
We need to ensure we do not use the "source" node
to find the Pod which holds the domain.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

/cc @dhiller @brianmcarey @enp0s3

/cherry-pick release-1.0

/kind flake


Translations into Ukrainian language

material-react-table version
v2.11.2
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
Hi
I am working on a project where I am using material react table. I need the table to also support Ukrainian language. I created a translation that fully supports Ukrainian language. I would be grateful for adding this to MRT.
Greetings
Minimal, Reproducible Example - (Optional, but Recommended)
https://codesandbox.io/p/sandbox/mrt-ua-i18n-language-v6tgp9?file=%2Fua%2Findex.esm.d.ts
Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA

@MarekPatyna It seems that the full locale name is ukUA from my understanding. That's what Material UI itself names their locale. And usually its fine to just refer to it by the first 2 letters, unless there are multiple dialects.

I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/

@MarekPatyna Your translations seem to be a lot different than the current uk locale in MRT. Which one is more correct? The existing one or yours?

I don't speak Ukrainian at b2/c1+ level, so I would personally suggest leaving the current translation. Thanks for the quick replies and good luck with MRT development!

I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/

And if a language isn't there, its more comprehensive source is https://iso639-3.sil.org/code_tables/639/data.

Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA

@MarekPatyna To clarify, the ISO 3166-2 code you were seeing for Ukraine (UA) is the country code, not the language code: https://en.wikipedia.org/wiki/ISO_3166#Parts

Apologies for writing back so late but I completely forgot about this issue. Thank you again @imnasnainaec @KevinVandy  for your help.
Best regards!