Could the scenario of Predator-Prey be also released?

Thanks for releasing the code. I noticed that the reward setting of the Predator-Prey in the paper is different from the simple_tag of the particle environment. It would be great if the author could also share the paper version of the scenario.
Thanks,
Ye

Hi,
we will upload the code in the next 2-3 weeks. I will close the issue once the code has been uploaded.
Best,
Georgios

Hi Georgios,
May I know if there are any update about the releasing of the Predator-Prey part of the code. Great thanks!
Best,
Ye

Hi Ye,
sorry for the delay. It has been added now.
Best
Georgios

Thanks Georgios! It looks great.
I'll close the issue then.
Best,
Ye


[docs]: Improve contributing.md guide #1540

Closes
Closes #1540
Description
I have Improved the contributing.md guide in the easiest way.
Screenshots

Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines

So sorry I misunderstood the issue labels and made the PR


Reimplement ValueEstimate as a subclass of float

This reimplements ValueEstimate as a subclass of float. This is backwards compatible, as new ValueEstimate still exposes value attribute (although marked as deprecated).

Looks good – have you checked if value is used somewhere in core so it can be fixed already in this PR?

It seems to me that the only place it is in use is in cost functions which we are planning to get rid of anyway.


fix: use saturating casts in lean_float_to_uint8 to avoid UB

The C Standard, <IP_ADDRESS>, paragraph 1 [ISO/IEC 9899:2011], says,

When a finite value of real floating type is converted to an integer type other than _Bool, the fractional part is discarded (i.e., the value is truncated toward zero). If the value of the integral part cannot be represented by the integer type, the behavior is undefined.

This means that the simple implementation uint8_t f(double d) { return (uint8_t)d; } is undefined behavior for large values of d. The correct version is to check that the value would truncate to a value in the range of the target type, that is, 0 <= d < 2^8. We have to write out 2^8 as a double constant though since this doesn't appear in any standard headers.
This changes the observable behavior of the cast from wrapping modulo 2^8 to saturating, but I think this behavior is more defensible (and it's also what rust did when they hit the same issue).
See also the Zulip thread.

This should probably documented in docstrings...?  That will be another PR though.


Fixed building issues, added AnimToTexture Plugin. Works in 5.0

Hey :)
Took a bit of time to fix the building issues some users were encountering.
It now boots on 5.0.1.
Cheers!

Thanks for the PR! Apologies that I was not able to get this merged in earlier. I'm currently working to get the project working for 5.3 so I am afraid that there may be conflicts.


Update to 102.0.5005.115-1

No patches needed to be updated. Compiled and tested successfully.

Do you want to push a new tag as well?

I just did that while you were writing 😂

Can we automate the tag creation via GH Actions like in the bare repo?

bare repo?

*base repo 😅

The base repo doesn't have any git tag automation, tags get created manually (usually by me)
It does have automation for creating github releases. The tag that you just pushed is the first to run the actions workflow introduced in #125, meaning that a release with compiled binaries will release in ~18-25 hours

So in the base repo, pushing a new tag triggers the creation of a release. That explains why the tag was present before I got the release notification.


Pass environment argument to label module

According to terraform-null-label, a label follows the following naming convention:  {namespace}-{environment}-{stage}-{name}-{attributes}. However, using the environment argument in this module produces an error:
An argument named "environment" is not expected here.

This pull request fixes this error by passing environment as an argument to the label module.

+1 on this. We would like to use the environment param and tag for consistency with the rest of our modules.

@guigo2k please, update PR and address the comments

obsolete due to https://github.com/cloudposse/terraform-aws-vpc/pull/48

Closing out as environment was supported as part of #48. Regardless, thanks for the effort @guigo2k!


[Task]  remove warning codes

Description
remove warning codes in module shenyu-plugin-springcloud
Task List
No response

there is not any warning codes at all

there is not any warning codes at all

OK, thank you ,and  you can close this issue


Import statement snippet inconsistent between .ts and .tsx files

Create a .ts file
Type import
Press tab to activate the "import statement" snippet

Expected and actual: completes to import {  } from "module";

Create a .tsx file (TypeScript + JSX)
Type import
Press tab to activate the "import statement" snippet

Actual: completes to import name = require('');
Expected: completes to import {  } from "module";
Is there any reason why the snippet is inconsistent between .ts and .tsx files?

Yes this is unintentional. I've marked this as help wanted in case anyone want to take a look. Here are the relevant snippet files: https://github.com/Microsoft/vscode/tree/master/extensions/typescript/snippets

@mjbvz Thanks! See https://github.com/Microsoft/vscode/pull/34653
I was also thinking it would be useful to add this to .js and .jsx extensions. What do you think?

Thanks for the PR! The change should be in the next insiders build
Yes I think adding the same for js/jsx also make sense. Did you want to submit another PR that copies these snippets over to js/jsx?


Mixin apply failed mixins.common.core.optional.json:util.math.MixinMutableBlockPos

Forge: 2254
SF: 2254
I think I first saw this error with SF 2254, but not 100% sure.
startup forge log:
https://pastebin.com/iHrRhEHq
error:
https://pastebin.com/Q2N3Z6wq

<Zidane> !gf field_177997_b
-MCPBot_Reborn- === MC 1.11: net/minecraft/util/math/BlockPos$MutableBlockPos.x (co$a.b) UNLOCKED ===
-MCPBot_Reborn- Name       : b => field_177997_b => x
-MCPBot_Reborn- Descriptor : I
-MCPBot_Reborn- AT         : public net.minecraft.util.math.BlockPos$MutableBlockPos field_177997_b # x
-MCPBot_Reborn- Comment    : Mutable X Coordinate
-MCPBot_Reborn- Last Change: 2014-09-25 20:23:36.116450-04:00 (diesieben07)

You've got a mod doing some shady ASM. Remove mods one by one until you find the culprit.

This is probably a better/more efficient option than removing mods one by one: https://asie.pl/Projects/Minecraft/Mods/EnvironmentChecker


JSON no longer has 'has_active_subscription' field

Current build will crash due to datacamp no longer providing this JSON field. Removing that check from the set_profile method fixes things. There seems to be no clear substitute key, apart maybe from the key indicating if the user is on his first trial week.
https://github.com/TRoboto/datacamp-downloader/blob/cc04f1ffabeb7f1e828db6c5d0d177dfc905df31/src/datacamp_downloader/datacamp_utils.py#L486

There is a key called active_products. That might be a good substitute.

can someone please help me with the "has_active_subscription" error


fix the url in article "Best practices for writing Dockerfiles"

From context on next line,tar -xJC implies the file is big.tar.xz instead of big.tar.gz.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:vizv/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Oh! well spotted!
LGTM
ping @fredlf @jamtur01 @moxiegirl @SvenDowideit


mongo update cat error

When I try to update a cat I get this mongo error:
[1]   name: 'MongoError',
[1]   message: 'exception: Mod on _id not allowed',
[1]   value:
[1]    { name: 'cat1',
[1]      age: 5,
[1]      weight: 2,
[1]      _id: 57b30f94b642ee7a18ab5c42,
[1]      __v: 0 },
[1]   errmsg: 'exception: Mod on _id not allowed',
[1]   code: 10148,
[1]   ok: 0 }
(even after pulling a fresh copy of the repo). Inserting and deleting cats from the mongoDB works great.

That's strange, did you edit some lines of my code? I can update the cats without any issue. What version of MongoDB and Node you have? Did you create the "cats" database by yourself (it should be created automatically) or you add any index? Does you receive any error in browser console too (F12 in Chrome)? Check also the "Network" tab (I'm using Chrome: F12 -> Network) while you edit the cat and tell me what you see there. There should be a successful PUT request (the edit) with the new data.

I was making changes in the code, but now the problem persists after pulling fresh copy's of the repo without code changes. I have not created any databases myself.

I think you are right, please update MongoDB (I've 3.2.8) and let me know if it persists. Also note that I didn't test it with Node 6.x, I've 4.4.7.

I have updated mongoDB to 3.2.8 and updating records works again, thanks !
If I may make a suggestion for the app it'd be:

maybe an auth functionaility (jwt tokens?) for securing the routes with canActivate
and an api (secured)  for save data calls

Thanks for the help and for sharing the project. I like its simplicity , ideal for learning MEAN with angular2. Now I'll try to replace mongoDB with mongo lab.

Good!
About the suggestions:

authentication is not a simple task and can be accomplished in multiple ways. I want to keep the project very simple. I don't know if I will add it in future (maybe in a separate project with Angular 2 final). Btw JWT is a good way to do it.
do you mean secured api calls so that only authorized users can call /api/xxx? If so, yes it should be implemented because now everyone can call update and delete api calls and this is not really cool...
About mLab I think you just need to edit line 18 of server.js, so that you can use a remote mongo database.

It might indeed be better to wait for the final Angular 2 release and make it a seperate project, and for the API  I mean indeed that only authorized users can make calls so it relies on the authentication.
And thanks for the mlab tip !


DDev Latest HEAD Build is Very Noisy/Verbose on Start/Stop

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
https://gist.github.com/timnolte/765b01ad319d66eaf841d503fb324aea
Expected Behavior
Previously the output would be:
$ ddev start
Starting <project>...
Network ddev-<project>_default  Created
Container ddev-<project>-web  Started
Container ddev-<project>-dba  Started
Container ddev-<project>-redis  Started
Container ddev-<project>-db  Started
Container ddev-router  Started
Successfully started <project>
Project can be reached at https://<project>.ddev.site https://<IP_ADDRESS>:33026

or
$ ddev stop
Container ddev-<project>-db  Removed
Container ddev-<project>-redis  Removed
Container ddev-<project>-dba  Removed
Container ddev-<project>-web  Removed
Network ddev-<project>_default  Removed
Project <project> has been stopped.

Actual Behavior
Now the output is as follows:
$ ddev start
Starting <project>...
 Network ddev-<project>_default  Creating
 Network ddev-<project>_default  Created
 Container ddev-<project>-db  Creating
 Container ddev-<project>-dba  Creating
 Container ddev-<project>-web  Creating
 Container ddev-<project>-redis  Creating
 Container ddev-<project>-redis  Created
 Container ddev-<project>-dba  Created
 Container ddev-<project>-web  Created
 Container ddev-<project>-db  Created
 Container ddev-<project>-db  Starting
 Container ddev-<project>-redis  Starting
 Container ddev-<project>-web  Starting
 Container ddev-<project>-dba  Starting
 Container ddev-<project>-redis  Started
 Container ddev-<project>-dba  Started
 Container ddev-<project>-web  Started
 Container ddev-<project>-db  Started
 Container ddev-router  Creating
 Container ddev-router  Created
 Container ddev-router  Starting
 Container ddev-router  Started
Successfully started <project>
Project can be reached at https://<project>.ddev.site https://<IP_ADDRESS>:33137

and
$ ddev stop
 Container ddev-<project>-db  Stopping
 Container ddev-<project>-redis  Stopping
 Container ddev-<project>-dba  Stopping
 Container ddev-<project>-web  Stopping
 Container ddev-<project>-redis  Stopped
 Container ddev-<project>-web  Stopped
 Container ddev-<project>-dba  Stopped
 Container ddev-<project>-db  Stopped
 Container ddev-<project>-redis  Stopping
 Container ddev-<project>-redis  Stopping
 Container ddev-<project>-db  Stopping
 Container ddev-<project>-db  Stopping
 Container ddev-<project>-dba  Stopping
 Container ddev-<project>-dba  Stopping
 Container ddev-<project>-web  Stopping
 Container ddev-<project>-web  Stopping
 Container ddev-<project>-redis  Stopped
 Container ddev-<project>-redis  Removing
 Container ddev-<project>-dba  Stopped
 Container ddev-<project>-dba  Removing
 Container ddev-<project>-web  Stopped
 Container ddev-<project>-web  Removing
 Container ddev-<project>-db  Stopped
 Container ddev-<project>-db  Removing
 Container ddev-<project>-redis  Removed
 Container ddev-<project>-db  Removed
 Container ddev-<project>-dba  Removed
 Container ddev-<project>-web  Removed
 Network ddev-<project>_default  Removing
 Network ddev-<project>_default  Removed
Project <project> has been stopped.

Steps To Reproduce

Update to the latest HEAD release from https://nightly.link/drud/ddev/workflows/master-build/master
Start & Stop a project.

Anything else?
No response

Thanks, I had noticed this; I think it's a change in docker-compose, but should be easy to sort out.


Use GitHub issues to track progress

Could you please create GitHub issues to track what you planned to do?

My current project progress includes finding a Faiss method that achieves 100% similarity with the results of linear search, allowing me to make comparisons (this took more time than expected, as most Faiss methods generally carry an error margin of about 4-5%). All current comparison functions use cosine similarity.
I have designed a simple benchmark that simulates multiple search parameters and checks if all search results (top_k) are identical, a method that can tolerate floating-point level discrepancies.
I have also implemented the first version of my own method, but I didn’t do anything particularly new—I simply re-implemented Python’s linear search in C++ STL. The underlying data structure is still using vector.
Additionally, after briefly reviewing the official documentation, I found that Faiss does not seem to support the remove operation, so I plan to skip that part for now.
The next step should be to study Faiss’s methods more closely to understand what optimizations they’ve made and where they achieve their speed. Since I am due to present a paper in our lab soon, I think reviewing their research paper would be a good approach.

Sounds good.  Reviewing what you did is a solid way to plan ahead.  But it will be more productive to focus on creating issues.  Actions matter.


Include the user created source reference in traces, more helpful error messaging

Quite often, when you make mistakes in your code, you get these useless error messages that don't indicate the source of the problem in your code, just a reference to some internal react code. It would be extremely helpful if the trace would include a reference to your local code that is the source of the exception.
E.g., this one occurs when you render the NavigationHeader in Navigation Experimental if you reference a variable in your code that doesn't exist.
Argument 0 (<null>) of RCTUIManager.updateView could not be processed. Aborting method call.
Cannot read property '_currentElement' of null
TypeError: Cannot read property '_currentElement' of null
at ReactCompositeComponentMixin._updateRenderedComponent (/tmp/react-native.js:16341:46)

Here is another one. It tries to give a helpful hint but doesn't indicate the location in the code where the problem occurs.
Objects are not valid as a React child (found: object with keys {dispatchConfig, dispatchMarker, nativeEvent, type, target, currentTarget, eventPhase, bubbles, cancelable, timeStamp, defaultPrevented, isTrusted, touchHistory, isDefaultPrevented, isPropagationStopped, _dispatchListeners, _dispatchIDs}).
If you meant to render a collection of children,
use an array instead or wrap the object using createFragment(object) from the React add-ons.
Check the render method of `Text`.
at invariant (/tmp/react-native.js:14101:7)
at traverseAllChildrenImpl (/tmp/react-native.js:29065:44)
at traverseAllChildren (/tmp/react-native.js:29093:8)
at flattenChildren (/tmp/react-native.js:29141:1)
at ReactMultiChild.Mixin._reconcilerUpdateChildren (/tmp/react-native.js:28499:14)
at ReactMultiChild.Mixin._updateChildren (/tmp/react-native.js:28638:23)
at ReactMultiChild.Mixin.updateChildren (/tmp/react-native.js:28613:6)
at ReactNativeBaseComponent.Mixin.receiveComponent (/tmp/react-native.js:28190:6)
at Object.ReactReconciler.receiveComponent (/tmp/react-native.js:14471:18)
at ReactCompositeComponentMixin._updateRenderedComponent (/tmp/react-native.js:16344:17)

I would say is that the lack of proper root sourcing of errors, is my number one loss of time factor by far on RN,

totally agree
i suffered enough from this error

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/include-the-user-created-source-reference-in-traces-more-helpful-error-messaging
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Add Tracestrack Maps

Tracestrack Maps now provides vector tiles & style.

Yes, vector maps are a paid service, as with many of the other providers listed

Oh, I can scroll the screen to see pricing... Not the most intuitive design I must admit, this is how it looks - no hint of content outside the screen that I should scroll to and no mention of pricing in the main menu at the right...


[PR Workflow] If a PR gets data-plane label, it should get APIStewardshipBoardReview label.

Per this comment:

https://github.com/Azure/azure-sdk-tools/issues/6184#issuecomment-1641071151

Also ensure that:

If a PR has APIStewardshipBoardReview label, it must get APIStewardshipBoardSignedOff label to be merged.

If a PR gets data-plane label AND the new-api-version label, it should get APIStewardshipBoardReview label.


Added new card

_ No description provided. _

you have get assigned then make a pr ok and also share SS of your card added.. please go through the contribution guidelines once..


Clusters do not contain enough models to calculate CI

Project Robyn
I was running the model with the new time-series validation feature both on my own data and on the simulated data, but every time I do that robyn_run() gives a warning:
Input data has 208 weeks in total: 2015-11-23 to 2019-11-11
Initial model is built on rolling window of 208 week: 2015-11-23 to 2019-11-11
Time-series validation with train_size range of 50%-80% of the data...
Using weibull_pdf adstocking with 22 hyperparameters (22 to iterate + 0 fixed) on 16 cores

Starting 5 trials with 2000 iterations each using TwoPointsDE nevergrad algorithm...
Running trial 1 of 5
|=================
*** WARNING: skipped 83840 bytes of output ***

|======================================================================| 100%
Finished in 2.38 mins

DECOMP.RSSD NOT converged<EMAIL_ADDRESS>0.13 > 0.11 &<EMAIL_ADDRESS>0.18 > 0.069
NRMSE NOT converged<EMAIL_ADDRESS>0.33 > 0.19 &<EMAIL_ADDRESS>0.47 <= 1.3
Total run time: 11.95 mins

Running Pareto calculations for 10000 models on 1 front...
Pareto-Front: 1 [26 models]
00:00:13 [=========================================] 100% | 26
Calculating clusters for model selection using Pareto fronts...
Auto selected k = 10 (clusters) based on minimum WSS variance of 5%
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 2 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 3 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 4 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 5 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 7 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 9 does not contain enough models to calculate CI
Warning in confidence_calcs(xDecompAgg, cls, all_paid, dep_var_type, k,  :
Cluster 10 does not contain enough models to calculate CI
Collecting 26 pareto-optimum results into: /dbfs/FileStore/Angelina Sandbox/Robyn_202301041632_init/
Exporting general plots into directory...
Failed exporting results, but returned model results anyways:
Error in ts_validation(OutputModels, quiet = TRUE, ...): object 'OutputModels' not found

After this, it only saves the general plots, but no one-pagers at all. I tried this 2 times with my own data, and 1 time with a simulated data from Robyn. On the screenshot are the only files it produces after this warning.

Provide reproducible example
My code is exactly the same as in the demo, except ts_validation = TRUE . Everything else is copy pasted from demo.
Environment & Robyn version

Robyn 3.9.0
R version 4.1.3 (I am running it in Databricks)

Thanks in advance for your help!

I found this thread that indicates it's related to Databricks. please check https://stackoverflow.com/questions/58386830/databricks-prints-only-around-280-lines-of-data

Hi @Angylina this is a warning that is printed whenever a cluster doesn't contain at least three solutions, this no CI can be calculated. Can you please check how many models per cluster you are getting? It seems the algorithm is setting k=10 and all solutions are in clusters 1 and 8. Did you pick only 1 pareto-front? Can you set it to "auto" (at least 100 models) or increase to more fronts manually to see if you get more solutions per cluster? Did you check the distribution of solutions to see if you're getting really weird and/or extreme results?

Old ticket. Please reopen if necessary.


does it support select childer sql?

select c.color,c.money,        (select p.name from person p where p.phone = c.phone )
from car c ;
how do i  implement  this ?

Joins are supported - this is a left join.


Question about pixel feature

Thank you for releasing the source code.
During reading the code, I wonder where the target view is, because there is no RGB loss between predicted target view and ground-truth target view.

Hi, due to the rendering cost of NeRF, we could only supervise using random batches of rays in each image.
Therefore we use a MSE loss on the rays rather than the views


Replaced Makefile build system with CMake

CMake has various advantages over Makefiles.

Portability to different platforms
Generates build scripts for different build systems: GNU Make, Ninja Build, Visual Studio
Easy compliance with various common patterns.

This branch replaces the Makefile build system with CMake, and adds support for packaging with CPack.

Hi jhol,
Thanks for contributing!  Few comments:

test_bv binary should be in tests/.
.gitignore is missing cmake products.  I like git status to be clean after building a clean repo.
The simpletest target is missing.  I use both simpletest and test as part of my development workflow.  Also, if I have to reconfigure to run all the tests, I will forget to do so and commit untested stuff, I'm sure.  It would be OK to skip the valgrind test if valgrind isn't found.

I'm happy to merge your if you fix these and I don't find anything else.
Any chance you've tested this on Windows?

@cseed Thanks for the comments. I'll address these things in the next day or two.
I didn't test windows just yet. I think msys2 would be the way to go to test that out.

@cseed I've been working on your comments...

About test_bv. Putting it in tests/ doesn't really mesh with CMake, because CMake encourages (though does not require) out-of-tree building. If someone is doing an out-of-tree build, it becomes rather ugly to put the executable in the source tree.
I added *.cmake to .gitignore
I made some improvements to the way the dependency programs are detected, and added a simpletest target. For now I think it's better to require valgrind, because anyone who comes to help with the project really should be giving it the thorough testing treatment.

@jhol

OK, I can get behind out of source builds.  Can we still put test_bv in $builddir/tests/?  (I didn't check, does arachne-pnr end up in $builddir/bin/?)
Thanks!
While I agree it is better to require valgrind, and I would like to do that, I develop on OSX 10.10 Yosemite and valgrind currently does not support it.  In the meantime, I'm going to need some hack that lets me configure and test without valgrind.

@cseed

I can't see any clean way of controlling the cmake output directory. Is this important?
No problem.
I added a commit that skips the valgrind test (with a warning) if the valgrind is not found.

@cseed So what's your verdict on this branch?
My feeling is that while it may not be possible to exactly replicate your existing work-flow with CMake, ultimately it's going to give a much more scalable solution, that will give lots of powerful features and ancillary benefits for free.
Are there any issues that you regards as deal-breaking?

@jhol Sorry for taking so long to reply.  Yes, I agree with you.  I want to be a little more comfortable with CMake before I merge the changes into the mainline, so I don't feel it is getting in the way as development goes forward.  I've merged your changes into the feat-cmake branch and made some changes (set default build type, set CMAKE_RUNTIME_OUTPUT_DIRECTORY to build executeables in bin/, run tests in the build dir, use test labels to implement make simpletest, don't require yosys, etc.)  I have a few pending (minor) issues:

How to portably determine compiler optimization flags for custom build type RelDebug.  (I want to build optimized without -DNDEBUG by default.)  I have no idea about this.
Implement one of these solutions to portably require C++11:
https://stackoverflow.com/questions/10984442/how-to-detect-c11-support-of-a-compiler-with-cmake
test or disallow in-source builds, see:
https://stackoverflow.com/questions/1208681/with-cmake-how-would-you-disable-in-source-builds
need targets to build the example in examples/rot (rules to build a .bin from a .v's).
I will keep this branch up to date and will merge it in when I feel like I can comfortably add new build features.  Thanks again for our contribution!

@cseed - if you like I can look into these things. Would that be helpful? I've been following your work on this branch, and it looks like you're making progress.
Just a little word of advice - I hope you don't mind me giving it. I would recommend the advice in this article: "Git Commit Hygene".
I've noticed several commits in the project that are check-point commits; just a series of snapshots of work. I generally recommend not doing this; the history becomes much more meaningful when contributors have taken care to produce a series of atomic modifications. I highly recommend the use of git add -p - I use it to add all my changes to my commits, that way I know that my commit does just one thing with zero extraneous changes.
I feel a little bad sticking my oar in about this; but then in the end I think it's a helpful thing to do, and the thing about git history is that it is completely permanent.
If you would like, I can do a rebase tidy-up feat-cmake before you merge it.

@cseed So it looks like my branch has bit-rotted. I can update it if you like, but I was wondering if you agree with the concept of this patch? Do you actually want this change to go in? Personally I think having CMake would make quite an improvement for portability, but I don't want to go to the effort of rebuilding the branch if it's not going to merge.

@jhol First, let me say I greatly appreciate your contribution and I totally agree moving to CMake is a real improvement.  I have no intention of letting this branch drop and my plan was to update/integrate it after I finished PLL support.  I started a new job in July and I've had much less time to work on arachne than I would like.  Although I haven't announced it anywhere, PLL support is essentially done (people are using it without complaint) so now is a perfect time to revisit this branch.
If you update it, I will merge it straight away.  I just need it to pass Travis and verify I can build debug on Linux and OSX.

@cseed great! Thanks for updating me. I know how it feels. I've experienced something similar myself in the past few months.
I'll revisit the branch in the coming few days.
Also, I received my iCE40 HX8K board in the mail this week, so I'm finally able to actually test out the software with real hardware. I ran it up with the rot example (with some mods), and it worked perfectly.
Do you have any example code for the PLL config? That would be a good addition to the examples, I would say.

Great!
Here is an example from @SubProto to use it to generate a VGA pixel clock:  https://github.com/SubProto/icestick-vga-test/blob/master/vga.v
I agree.  I'll add examples for all the major hardware features.

@cseed Is this still something you want to move toward? I ask since I am interested in getting the toolchain needed for Ice40 parts compiling on Windows. I have managed to get arachne-pnr building using MSVC and I think MinGW should still work.

@benpye I would love someone to take this forward. It's probably needs some major rebasing by now, but the concept is good. Whatever happens the project should have exactly one build system in operation.

@jseed I agree. To clarify, that's using CMake to generate the MSVC solution.

Yeah CMake can make MSVC projects, Makefiles and my personal favourite Ninja-build files. None of these should be checked in of course- the use will generate the needed bus files when bootstrapping.


[Feature] support upnp mode

Support upnp mode.
It is well described here

I implemented this, but I cannot find a way to use mpd with such configuration.
So some help/suggestion is needed.
I will leave the branch alive for some time.

I did not find a way to use mpd like I could do years ago with GMPC. GMPC seems quite dead now, so I believe this feature is not very important.
Feel free to reopen or create anew if new information is available

Silly me, I noticed that the feature requires to run the image in host mode, otherwise it won't discover any server.
I am implementing the feature just for the sake of completeness, but for better result, I recommend to add upmpdcli (maybe using this image on top of mpd so that you can use a proper upnp/dlna control point like bubbleupnp, mconnect, upplay (from the same author of upmpdcli).

Fixed in this release.


Resolve invalid nonce queries + race conditions in TxPool

Description
This PR resolves some pending issues with the TxPool module:

Race conditions when locking the account-specific queue
Invalid next nonce read from world state when the TxPool is advanced (introduced in PR #224)
Invalid TxPool account nonce when the world state has advanced
Unpruned leftover transactions on block insertion

Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)
[x] I have added sufficient documentation both in code, as well as in the READMEs

Additional comments
The PR is not meant to be a fix-all solution but rather a patch until we get up and running with the TxPool refactor.

@lazartravica
What do you mean?
The  fetch that the dispatcher does for pending nonces shouldn't rely on the TxPool to return a not found message, like it did earlier.
If the account is not initialized in the TxPool, it will grab the value from state, but if it is (and it's an account that has seen some uncommitted activity since the last state change), it will return the TxPool nextNonce.
We already had this functionality earlier, which was overwritten by PR #224.

eth_getTransactionCount with the "pending" block param will always return the nextNonce from the state, are you aware of this, and did we plan out an issue to fix this?

@lazartravica What do you mean?
The fetch that the dispatcher does for pending nonces shouldn't rely on the TxPool to return a not found message, like it did earlier.
If the account is not initialized in the TxPool, it will grab the value from state, but if it is (and it's an account that has seen some uncommitted activity since the last state change), it will return the TxPool nextNonce. We already had this functionality earlier, which was overwritten by PR #224.

Thanks for the clarification. Got it. Approving the PR


Prepare firefox and chrome extension directories

As discussed in #1 this PR creates separate manifest files for firefox and chrome.
Added build.sh to prepare dist/ directory with browser specific manifest.
I tested uploading the generated zip to the firefox store and managed to get a sign xpi back.
I have not published the addon on the firefox store, wasn't sure if you wanted to do that or want me to go ahead and do it.

As discussed in #1 this PR creates separate manifest files for firefox and chrome.
Added build.sh to prepare dist/ directory with browser specific manifest.
I tested uploading the generated zip to the firefox store and managed to get a sign xpi back.
I have not published the addon on the firefox store, wasn't sure if you wanted to do that or want me to go ahead and do it.

Thanks for the contribution, I've sent you an email 😉


Task A.1

I added the following assumptions:

Fintype G
$X_i$ is measurable
$\mathbb{P}_i$ is a probability measure

I think one may need to add similar assumptions to some downstream lemmas to make them compile now.

Yes - I am fixing those right now

This was a bit more involved than I had hoped. The proof of the conditional version applies this lemma on the marginal distributions. These are only probabilty distributions when $Y$ satisfies some nondegeneracy condition. I've added a sorry instead of figuring out the precise condtion on $Y$, since I don't know exactly what is true in the applications.

OK.  Somehow CondMultiDist_nonneg was overlooked in the blueprint, but I'm sure it gets used somewhere, so I will add it and also add a task to fill in the sorry.


What is the correct implementation of YouTubeStandaloneIOS.playVideo?

Hello all,
How do I correctly implement this as it isn't very clear in the docs. I tired the following and got:
"TypeError: null is not an object (evaluating '_reactNativeYoutube.YouTubeStandaloneIOS.playVideo')
import {YouTubeStandaloneIOS} from 'react-native-youtube';

class AddMemoryTabScreen extends Component {

    render() {
        return(
            <View>
                {YouTubeStandaloneIOS.playVideo('KVZ-P-ZI6W4')}
            </View>
        )
    }
}

I'm now getting this error after using the example implementation from this repo:
import {YouTubeStandaloneIOS} from 'react-native-youtube';

class AddMemoryTabScreen extends Component {

    render() {
        return(
            <View>
                <Button
                    title='Press to Play video'
                    onPress={() =>
                        YouTubeStandaloneIOS.playVideo('KVZ-P-ZI6W4')
                            .then(() => console.log('iOS Standalone Player Finished'))
                            .catch(errorMessage => this.setState({ error: errorMessage }))
                    }
                />
            </View>
        )
    }
}

Solved! The resolution to this was mentioned in a comment by @onpaws in #65. I had to manually link the Library and everything worked.


Randomize normalized_reticle_size and spin_modifier parameter

Short Description:
When calling catch_pokemon API, parameter normalized_reticle_size is fixed to 1.950 and also spin_modifier is fixed to 1.
This PR makes them random.
Fixes:

normalized_reticle_sizes and spin_modifier are fixed to constant values

This should be a configurable settings, since some people (like me) prefer to have the normalised value and get the xp bonus every catch

    ...
    "evolve_captured": false,
    "humanize_catch_parameters": true,
    "catch": {
    ...

I'm trying to add humanize_catch_parameters to config.json.
If this is set to true, normalized_reticle_size and spin_modifier will be randomized.
How about the default value?

Rather than a true/false, wouldn't be better to fill a % for how much randomness you want ?
Something like that :
    ....
    catch_randomize_reticule_factor : 0.8
    catch_randomize_spin_chance : 0.6
    catch_randomize_hit_chance : 1.0
    ....

In the example above. you would be able to randomize the reticule between 80% et 100% of the optimal value (1.950?), and have 60% chance to do a spin hit.
The last parameter isn't implemented yet, but that would be nice to be able to miss sometimes too, to completely simulate a human behaviour.
That would allow more control over the hit ratio, and add more variety amongst all bots.

I've updated the code based on @Likael 's idea (before EDIT2, sorry).
I've checked actual (in game) value of normalize_reticle_size and spin_modifier.
It seems 1 <= normalized_reticle_size <= 1.950 and 0 <= spin_modifier <= 1.
Config parameters looks like this:
    "catch_randomize_reticule_factor": 1.0,
    "catch_randomize_spin_factor": 1.0,

catch_randomize_reticule_factor:

1.0 (default, and max value) means NO randomize: always 'Excellent' throw.
0.0 (min) means randomize between normal and 'Excellent' throw.

catch_randomize_spin_factor:

1.0 (default, and max value) means NO randomize: always perfect 'Super Spin' curve ball.
0.0 (min) means randomize between normal (not curved) ball between 'Super Spin' curve ball.

I didn't write code abouthit_pokemon and is fixed to 1, so Pokeballs will always hit Pokemon at this time.

Can we update this to use the new config approach?

Updated to use add_config in pokecli.py

:+1:

encounter_id: (...MASKED...)
pokeball: ITEM_POKE_BALL
normalized_reticle_size: 1.01213991642
spawn_point_id: "(...MASKED...)"
hit_pokemon: true
spin_modifier: 0.187229141593

This is an actual in-game, captured value of CatchPokemonMessage, when I had thrown almost not curved, and bad throw (but hit the pokemon)

Rebased to dev again

Rebased to dev again

👍

👍

Should add to the Wiki documentation. I would but its locked.
Thx

 **catch_randomize_reticule_factor:**
1.0 (default, and max value) means NO randomize: always 'Excellent' throw.
0.0 (min) means randomize between normal and 'Excellent' throw.
 **catch_randomize_spin_factor:**
1.0 (default, and max value) means NO randomize: always perfect 'Super Spin' curve ball.
0.0 (min) means randomize between normal (not curved) ball between 'Super Spin' curve ball.

This doesn't seem to be working still. I always get the curve (or nice throw) bonus but rarely get anything beyond that.
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,

"Catch pokemon api seems didn't throw excellent ball after server update?" https://github.com/tejado/pgoapi/issues/157
Same issue reported to upstream


icon-after and icon-sup modifiers

It would be nice to have an additional modifier for ui icons that would move icon placement to after the text rather than before.
For example, the modifier icon-ui-link-external produces this result when used on an element.

However, if I want that icon to appear after the text rather than before, then I've got to do something like:
See What's New
If I want the icon to appear as superscript, the easiest way would be
See What's New
Modifiers for icons that facilitated this would be nice.
See What's New

See What's New

The icon font is actually deprecated. You should just put an svg in there.

alrighty then

http://gif-finder.com/wp-content/uploads/2016/07/Jim-Carrey-Alrightythen.gif


updated the Holmes-Storage documentation

I added more details and references to the documentation.

Nice job, I agree with Georges changes. We might bring back local-fs later but for now it's definitely gone.

@cynexit regarding local-fs is it incompatible with changes or just nobody that updated it? I do use it all the time for testing :P


fix(patch): fix #746, check desc get is null and only patch window.resize additionally

fix #746,fix #741

#722 break #741, not patch onresize(maybe others), so I add it back in this PR
fix #746, check originalDescGet is null or not.

@mhevery , I have updated my PR.

only patch specified properties
window patch resize property
check originalDesc is null or not

please review. thank you !

I tried the patch, it still gives the same error. Same steps to reproduce. Brand new project, ng serve, error.

@smorhaim , you can try the attached zone.js, the error still exists because the dist/ folder is not updated.
dist.zip

@JiaLiPassion it works! Thanks.

is it fixed? which version? i tried downgrade from 0.8.8 to 0.8.5 and 0.8.4 but same issue as described in #6063

@JiaLiPassion, do you know when /dist folder is going to be updated?
Thanks!

@dkontorovskyy , it will be the next version release, please wait for a while.


Vulkan surface never gets disposed

In this line of code, you create a surface that never gets properly disposed. That leads to a VkSurfaceKHR not destroyed message when trying to dispose of a VkGraphicsDevice

Can reproduce systematically on disposing my vulkan backend app : on device dispose, the vk instance destroy doesn't throw but still informs me that the surface hasn't been destroyed as an error.
VUID-vkDestroyInstance-instance-00629(ERROR / SPEC): msgNum: 0 - OBJ ERROR : For VkInstance 0x225f6940f20[], VkSurfaceKHR 0xf8ce070000000002[] has not been destroyed. The Vulkan spec states: All child objects created using instance must have been destroyed prior to destroying instance (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-vkDestroyInstance-instance-00629)
    Objects: 1
        [0] 0xf8ce070000000002, type:<PHONE_NUMBER>, name: NULL

This should be fixed by https://github.com/mellinoe/veldrid/commit/31e3f023ec47cbb51a6009de111b78c5bcc44251


Receiving data from SPP profile fails under Windows 10 Version 1809

We are using the 32feet library to connect to a Bluetooth Classic module (Bluegiga/Silabs WT11) via a virtual COM port connection (SPP).
Below is an excerpt of the C# code we use.
Code
...
// connect
InTheHand.Net.Sockets.BluetoothClient m_localClient;
m_localClient = new InTheHand.Net.Sockets.BluetoothClient();
m_localClient.Connect(mapping.Address, BluetoothService.SerialPort);
...

// receive data
if (m_localClient != null && m_localClient.Connected){
   Stream inStream = null;
   inStream = m_localClient.GetStream();
   int numberOfBytes = inStream.Read(m_receivedData, 0, m_receivedData.Length);
   ...
}
...
// send data
...
if (m_localClient != null && m_localClient.Connected){
   Stream outStream = m_localClient.GetStream();
   if (outStream != null){
      outStream .WriteTimeout = 1000;
      outStream .Write(data, 0, data.Length);
   }
}
...
// disconnect
if (m_localClient != null){
    m_localClient.Close();
    m_localClient.Dispose();
    m_localClient = null;
}

Problem
Under Windows 7 this code works.
Under Windows 10 (1803 Build 17134) the code throws an exception at the receive data part.
We are still running tests with earlier versions of Windows 10 to see when the problem was introduced because there are indications that with earlier versions of Windows 10 (1507 or higher) the code worked. If we find out which versions work and which not, I will update this issue accordingly.
Connecting the virtual COM ports created by the Windows Bluetooth stack via any terminal software works under Windows 10 as well as under Windows 7, so there is no general problem with using the SPP profile.
Interestingly on the Bluetooth module side we receive the message "SYNTAX ERROR" on the serial output when trying to establish the connection using the 32feet library code above. This error does again not appear when using Windows 7.
The WT11 module uses the latest firmware (55.7.0 build 1118), although the behaviour is the same for older firmware versions.
Error
The error we get ist mostly this one:
System.IO.IOException: Unable to read data from the transport connection: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
Less often this one
System.Net.Sockets.SocketException (0x80004005): An invalid argument was supplied 00078025BEDA:0000110100001000800000805f9b34fb
at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
at InTheHand.Net.Bluetooth.Msft.SocketBluetoothClient.Connect(BluetoothEndPoint remoteEP)
at InTheHand.Net.Sockets.BluetoothClient.Connect(BluetoothAddress address, Guid service)
Or that one:
System.Net.Sockets.SocketException (0x80004005): An operation was attempted on something that is not a socket 00078025BEDA:0000110100001000800000805f9b34fb
at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
at InTheHand.Net.Bluetooth.Msft.SocketBluetoothClient.Connect(BluetoothEndPoint remoteEP)
at InTheHand.Net.Sockets.BluetoothClient.Connect(BluetoothAddress address, Guid service)

Is the device successfully paired on your Windows 10 machine? What Bluetooth radio does your PC have? You can view Device Manager and look under the Bluetooth node. You should see a Bluetooth Device (the radio) and Microsoft Bluetooth Enumerator and Microsoft Bluetooth LE Enumerator along with paired devices.
You should also see the device in Settings >Devices > Bluetooth & other devices and it's state should change from Paired to Connected when your app established the connection.

I intended to add more info to the initial issue before submitting but accidentally found out there is a keyboard shortcut for submitting, so the issue got submitted before I finished writing.
Yes, the device is successfully paired with Windows.
I have Microsoft Bluetooth Enumerator and Microsoft Bluetooth LE Enumerator as well as the paired device showing up. Im not 100% sure about the change from "Paired" to "Connected" in "Settings >Devices > Bluetooth & other devices". There seems to be a connection for a short time but then we are back to paired. When I open the COM port (COM11 out of COM3 and COM 11) in this case port via Putty we definitely geht a connected in "Settings and Devices".
We tested on multiple machines with multiple devices and dongles. Currently I am using an CSR8510 A10 dongle (VID_0A12&PID_00019, Microsoft Driver Version 10.0.17134.376) but the behaviour is the same with two other dongles we tested.
Im currently speculating that there might have been a change in some kind of authentication with Windows 10 Version 1083 which our modules fail to respond to. Also the modules specify SPP 1.1 compatibility while Windows 10 now uses SPP 1.2, but to my knowledge this should not be an issue.

Does the device require Authentication/Encryption and do you set the relevant Authenticate/Encrypt properties on the BluetoothClient before the Connect() call. It is possible that Windows 10 has somehow changed the defaults for these. Perhaps this explains the syntax_error on the remote device?

We don't require authentication on the device side. However, I indeed think that from a certain Windows 10 version something authentication related has changed, which is somehow causing the problem. Unfortunately Microsoft is not exactly known detailed changelogs or at least pretty good in hiding them from me.
After some more looking into, it seems that the 32feet library in Windows 10 establishes the connection and it is immediately closed again. If this happens by the  32feet library, by Windows or by the module is not clear yet.
Windows 10 1083 is also affected. We are still testing older versions.
The closing seems to happen almost always in between the test for  "m_localClient.Connected == true" and finishing the actual stream reading "int numberOfBytes = inStream.Read(m_receivedData, 0, m_receivedData.Length);". The errors we get are thus because the stream reader looses its connection in the middle of reading data. Sometimes a the connection is lost a bit sooner, sometimes later, because we get different amounts of data out. The first transfers involved are one packet of 515 bytes and one packet of 512 bytes. Mostly the first transfer already fails, but sometimes we get into the second one, but latest then the connection is gone.
The "SYNTAX ERROR" I mentioned above as given out by the Bluetooth module seems to be related to the fact that our device code, depending on the timing" has not yet realized, that the connection is lost and tries to send data to a link ID that is no longer connected.
This behaviour is described in the UG218 (https://www.silabs.com/documents/login/user-guides/UG218.pdf) as a known issue (IWRAP821):  “Ignored commands called just after closing Bluetooth connection. iWRAP commands may be ignored or may cause SYNTAX ERROR if called just after closing connection. No problems were found if commands are called 1 second or later after connection close.”
So this error is actually a result of the disconnect and not the cause.

The problem is "fixed".
I am documenting the "fix" here, in case someone else experiences the same problem.
The Exceptions were caused by setting a timeout on the instream, which for some unknown reason I did not include in the read code, but only for the write code above.
Solution
Removing the timeout from the reading stream, resulting in a default value of "infinite" solves the issue.
Cause
Our code sets a default timeout of 100 ms.
if (m_localClient != null && m_localClient.Connected){  …  inStream = m_localClient.GetStream();  inStream.ReadTimeout = 100;  …  inStream.Read(m_receivedData, 0, m_receivedData.Length);  … }
The above code works with Windows 7, with our default 100 ms timeout.
The above code does not work with Windows 10. Even if the timeout is increased to 1000 ms it fails, at which point we stopped looking into the timeout as the source of the problem, but rather focussed on the fact that the Bluetooth connection gets closed.
Seemingly Windows 10 takes a lot longer than Windows 7 to establish the Bluetooth stream to a connected , after the 32feet library states it is connected. A timeout of 10000 ms or no timeout at all on the stream is working.
"Affected" Windows 10 versions
Below also the results for the different Windows 10 versions. All the versions we tested were showing the same problem.
1507 Build 10240 affected
1511 Build 10586 not tested
1607 Build 14393 not tested
1607 Build 14393 affected
1703 Build 15063 affected
1709 Build 16299 affected
1803 Build 17134 affected
1809 Build 17763 affected
@peterfoot: Thanks taking the time to look into this.


[Issue- 476] data load is failing with empty dimension column

data load is failing with empty dimension column

Closing this PR will be fixed with PR #475


Fix: Check for MCP Available Attributes

Description
proposed fix for #3225
Solution
Since some servers do not provider resources, tools, etc., check if client methods are available with simple wrapper:
this.client.listResources()
this.client.listTools()
this.client.listPrompts()

  async checkClientAttribute(func: () => Promise<any>): Promise<any> {
    try {
      const result = await func();
      return result;
    } catch (e) {
      return null;
    }
  }

There is prob a better way to handle this, but it's a good hot fix 😁
Checklist

[] The relevant docs, if any, have been updated or created

Screenshots

Testing

Install the filesystem server:

npm install -g @modelcontextprotocol/server-filesystem

Configure MCP in ~/.continue/config.json:

{
  "experimental": {
    "modelContextProtocolServer": {
      "transport": {
        "type": "stdio",
        "command": "npx",
        "args": [
          "-y",
          "@modelcontextprotocol/server-filesystem",
          "/path/to/directory"
        ]
      }
    }
  }
}

TODO

[ ] handle duplicate Tools:
Adding the @modelcontextprotocol/server-filesystem server produces the following warning with the default tools:

Warning: Encountered two children with the same key, `read_file`.
Keys should be unique so that components maintain their identity across updates.
Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

To handle duplicate tools, an easy fix would just be to encode the BuiltinTools using some sort of prefix:
export enum BuiltInToolNames {
  ReadFile = "builtin:read_file",
  ReadCurrentlyOpenFile = "builtin:read_currently_open_file",
  CreateNewFile = "builtin:create_new_file",
  RunTerminalCommand = "builtin:run_terminal_command",
  ViewSubdirectory = "builtin:view_subdirectory",
  ViewRepoMap = "builtin:view_repo_map",
  ExactSearch = "builtin:exact_search",
  SearchWeb = "builtin:search_web",
  ViewDiff = "builtin:view_diff",
}

@sestinj @Patrick-Erichsen This is ready for review!

I tried to get this to work on my end, could you confirm my config.json structure please? I put "experimental" conf at the root (and at the end).
{
  "models": [
    {
      "title": "Claude 3.5 Sonnet (Free Trial)",
      "provider": "free-trial",
      "model": "claude-3-5-sonnet-latest",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "GPT-4o (Free Trial)",
      "provider": "free-trial",
      "model": "gpt-4o",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "Llama3.1 70b (Free Trial)",
      "provider": "free-trial",
      "model": "llama3.1-70b",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "Codestral (Free Trial)",
      "provider": "free-trial",
      "model": "codestral-latest",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "model": "claude-3-5-sonnet-latest",
      "provider": "anthropic",
      "apiKey": "",
      "title": "Claude 3.5 Sonnet"
    }
  ],
  "tabAutocompleteModel": {
    "title": "Tab Autocomplete",
    "provider": "free-trial",
    "model": "codestral-latest"
  },
  "customCommands": [
    {
      "name": "test",
      "prompt": "{{{ input }}}\n\nWrite a comprehensive set of unit tests for the selected code. It should setup, run tests that check for correctness including important edge cases, and teardown. Ensure that the tests are complete and sophisticated. Give the tests just as chat output, don't edit any file.",
      "description": "Write unit tests for highlighted code"
    }
  ],
  "contextProviders": [
    {
      "name": "code",
      "params": {}
    },
    {
      "name": "docs",
      "params": {}
    },
    {
      "name": "diff",
      "params": {}
    },
    {
      "name": "terminal",
      "params": {}
    },
    {
      "name": "problems",
      "params": {}
    },
    {
      "name": "folder",
      "params": {}
    },
    {
      "name": "codebase",
      "params": {}
    }
  ],
  "slashCommands": [
    {
      "name": "share",
      "description": "Export the current chat session to markdown"
    },
    {
      "name": "cmd",
      "description": "Generate a shell command"
    },
    {
      "name": "commit",
      "description": "Generate a git commit message"
    }
  ],
  "experimental": {
    "modelContextProtocolServer": {
      "transport": {
        "type": "stdio",
        "command": "npx",
        "args": [
          "-y",
          "@modelcontextprotocol/server-filesystem",
          "~/Desktop"
        ]
      }
    }
  },
  "embeddingsProvider": {
    "provider": "free-trial"
  },
  "reranker": {
    "name": "free-trial"
  }
}

@adamszewe thanks for opening this!
I poked around the TS interface for client a bit and I think we can use client.getServerCapabilities in the modifyConfig to do this a bit cleaner.
https://github.com/search?q=repo%3Amodelcontextprotocol%2Ftypescript-sdk getServerCapabilities&type=code
--
150 | * After initialization has completed, this will be populated with the server's reported capabilities.
151 | */
152 | getServerCapabilities(): ServerCapabilities \| undefined {
153 | return this._serverCapabilities;
154 | }

// Server supports resources and tools, but not prompts
--
214 | expect(client.getServerCapabilities()).toEqual({
215 | resources: {},
216 | tools: {},
217 | });

I think our logic could then look something like this:
    const capabilities = this.client.getServerCapabilities()

    if (capabilities?.resources) {
      const resources = this.client.listResources()
      // ...
    }

+1 to the implementation for BuiltInToolNames, I think the prefix is a good call.

I tried to get this to work on my end, could you confirm my config.json structure please? I put "experimental" conf at the root (and at the end).
{
  "models": [
    {
      "title": "Claude 3.5 Sonnet (Free Trial)",
      "provider": "free-trial",
      "model": "claude-3-5-sonnet-latest",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "GPT-4o (Free Trial)",
      "provider": "free-trial",
      "model": "gpt-4o",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "Llama3.1 70b (Free Trial)",
      "provider": "free-trial",
      "model": "llama3.1-70b",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "title": "Codestral (Free Trial)",
      "provider": "free-trial",
      "model": "codestral-latest",
      "systemMessage": "You are an expert software developer. You give helpful and concise responses."
    },
    {
      "model": "claude-3-5-sonnet-latest",
      "provider": "anthropic",
      "apiKey": "",
      "title": "Claude 3.5 Sonnet"
    }
  ],
  "tabAutocompleteModel": {
    "title": "Tab Autocomplete",
    "provider": "free-trial",
    "model": "codestral-latest"
  },
  "customCommands": [
    {
      "name": "test",
      "prompt": "{{{ input }}}\n\nWrite a comprehensive set of unit tests for the selected code. It should setup, run tests that check for correctness including important edge cases, and teardown. Ensure that the tests are complete and sophisticated. Give the tests just as chat output, don't edit any file.",
      "description": "Write unit tests for highlighted code"
    }
  ],
  "contextProviders": [
    {
      "name": "code",
      "params": {}
    },
    {
      "name": "docs",
      "params": {}
    },
    {
      "name": "diff",
      "params": {}
    },
    {
      "name": "terminal",
      "params": {}
    },
    {
      "name": "problems",
      "params": {}
    },
    {
      "name": "folder",
      "params": {}
    },
    {
      "name": "codebase",
      "params": {}
    }
  ],
  "slashCommands": [
    {
      "name": "share",
      "description": "Export the current chat session to markdown"
    },
    {
      "name": "cmd",
      "description": "Generate a shell command"
    },
    {
      "name": "commit",
      "description": "Generate a git commit message"
    }
  ],
  "experimental": {
    "modelContextProtocolServer": {
      "transport": {
        "type": "stdio",
        "command": "npx",
        "args": [
          "-y",
          "@modelcontextprotocol/server-filesystem",
          "~/Desktop"
        ]
      }
    }
  },
  "embeddingsProvider": {
    "provider": "free-trial"
  },
  "reranker": {
    "name": "free-trial"
  }
}

Hello, have you solved the problem. I encountered the same issue that I have added the modelContextProtocolServers, but I cannnot see the mcp after I typed @.

Tried last time a few days ago (maybe they have updated it since) but sadly still didn't work for me

@SimonB97 @YanxingLiu the config has actually changed in the recent pre-release:
change modelContextProtocolServer -> modelContextProtocolServers (severs in now plural). I opened a PR with some potential fixes for multiple servers: #3462

Contributor

Thanks for your work, I have tried the setting mentioned in https://github.com/continuedev/continue/pull/3462. But it still failed. The detail is shown in that PR. I would like to ask if you know why this is. Thanks a lot for your help.


Fix missing route; Fix wildcard+options

Adds fixes for edge cases regarding usage of recently adde ::wildcard route.

Closed in favour of https://github.com/utopia-php/framework/pull/95


Permission denied when creating Xcode directory

Is there an existing issue for this?

[X] I have searched the existing infra issues

Type of Request
bug
Infrastructure Environment
Devicelab
What is happening?
Some (if not all) of mac devicelab bots have permission denied when trying to create a directory in /opt/flutter.
For example, when installing Xcode, we download the Xcode app into /opt/flutter/xcode, however, if the xcode directory does not exist yet, it is created with mkdir. However, this fails due to file permissions.
mkdir /opt/flutter/xcode: permission denied

https://ci.chromium.org/ui/p/flutter/builders/try/Mac Engine Drone/471486/overview
Either we need to update permission allowance or the xcode directory needs to be created manually when bots are set up.
Note: the xcode directory has the owner of swarming currently, which allows directories to be created inside of it
Steps to reproduce
ssh into a bot and do
mkdir /opt/flutter/xcode

Expected results
Directory gets created or is already there

@kentnguyen99 Could you help run below command to unblock?
sudo mkdir -p /opt/flutter/xcode && sudo chown -R swarming /opt/flutter/xcode

@yusuf-goog Does this sound a good fit to add to salt for make sure the folder exists with correct permission?

I already did it manually for mac-1

@keyonghan we should probably chown at /opt/flutter:
sudo mkdir -p /opt/flutter/xcode && sudo chown -R swarming /opt/flutter

https://dash-internal-review.git.corp.google.com/c/salt/+/1920 is potential fix in salt to setup the directories.

Ran potential fix on mac-45. @vashworth can you confirm if the issue is resolved on that machine?

Looks like https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-11 needs to have it's permissions updated, as well

fixed permissions on mac-11

This should have been resolved.

@keyonghan & @yusuf-goog  Looks like https://dash-internal-review.git.corp.google.com/c/salt/+/1920 never got merged in?

Confirmed with @yusuf-goog all bots have been with correct permission now. We may still need to make sure these configs auto handled by salt for potential future cases like OS upgrade, etc? Just in case, reopening, but lowing priority to P2.

We may still need to make sure these configs auto handled by salt for potential future cases like OS upgrade, etc?

Yeah we handled it manually for the upgrade so far, but I think it's important to have it automated as it could get forgotten next upgrade or if we get new bots

https://dash-internal-review.git.corp.google.com/c/salt/+/1920  is submitted. This should run on new mac setups, and is available for us to run manually if ever the case arise.
@vashworth let me know if theres anything else, if not , you can go ahead and close this


Fixed unslottable spells

What has been fixed
Fixed a bug that prevented to slot spells inside containers. Now the system is capable of doing so, but only when a spell is dragged and dropped from a compendium window.
Explanation of the issue
The system, before putting the item inside a container, performs multiple checks and one of these checks is the weigth. Since spells do not have the weight property, the code "!itemToAdd.data.data[storageOption.weightProperty]" will always return true (negated false) and, as such, the system will always call "continue;". For this reason, the function will always return "null".
Future Work
My proposed solution is a "bandaid" fix and should not be used for extended periods of time. A proper solution involves checking the existance of every property and making sure that every item has every property.

Hey Rygar, thanks for thinking along, unfortunately I cannot accept this PR for two reasons.

First, because it was kind of a bandaid fix I ignored it a little too long, and now there's merge conflicts. I know where to apply your change however, but the real reason:
Second, you can just add another storage section, set accepted item types to only accept spells, set its storage identifier to spell slot, set capacity to Items. This last step disables the weight check.

Hope this works out for you. :-)


desktop: Add basic emoji support

For non-mobile devices, add support for emoji.

Create a util function that detects whether it's a mobile device or not.
If not a mobile device, add a row of basic emojis right above the text area. (Chat page)

Can i try this one?

@zygisS22 Sure!

@zygisS22 are you still working on this? Mind if I give it a shot?

@zygisS22 are you still working on this? Mind if I give it a shot?

yeah sure, i been busy with work unfortunately haven't done much yet 😞


docs: set crates badge and update gitignore

Codecov Report

Merging #23 (b37dee6) into develop (2683c20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #23   +/-   ##
========================================
  Coverage    82.82%   82.82%
========================================
  Files            2        2
  Lines          262      262
========================================
  Hits           217      217
  Misses          45       45

Impacted Files
Coverage Δ

src/lib.rs
86.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2683c20...b37dee6. Read the comment docs.


Is it possible to ignore (TooFewKeywordSteps) when keyword added with 'No Operation'

REQUIREMENT: I need a keyword in my test whose implementation will be done in future, so I added keyword with 'No Operation'.
Example:
*** Keywords ***
Keyword Name
|    |No Operation
QUESTION: Is it possible to ignore keyword with 'No Operation' in (TooFewKeywordSteps)?

At present, no, it's not possible. However, you can certainly write your
own rule that does.
On Sun, Jul 15, 2018 at 1:21 AM Shiva Prasad Adirala <
<EMAIL_ADDRESS>wrote:

REQUIREMENT: I need a keyword in my test whose implementation will be done
in future, so I added keyword with 'No Operation'.
Example:
*** Keywords ***
Keyword Name
No Operation
QUESTION: Is it possible to ignore keyword with 'No Operation' in
(TooFewKeywordSteps)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boakley/robotframework-lint/issues/53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABEmYrHgWRHx3_WgVW24bD_z5nuh-Dfjks5uGt9wgaJpZM4VQIZQ
.

@boakley I vote for a keyword never having too few steps based on our most recent conversation about very readable tests with no variables :-).


Fix dash m

Fixes the behavior of this script when a message is specified on the command line.

This change is

Fixes #7

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


structurizer: split regions into Divergent vs Convergent, and optimize based on that.

The first commit is a pretty large refactor that ended up a bit worse than I expected.
We might just want to have this instead (and call it in a few places):
impl Region {
    fn diverges(&self) -> bool {
        self.exits.is_empty()
    }
}

The second commit is just an on-the-fly OpPhi simplification that we should probably merge completely separately.
And the third commit is "clever hack" (to remove some unnecessary empty blocks, see example below) that could also probably be done without the first commit, it just didn't hit me that it was possible before the refactor.

(click to open example code & before/after graphs for the third commit)
pub fn marker() {}

pub fn shortcircuit_and(a: bool, b: bool) {
    if a && b {
        marker();
    }
}

Before

After

Closing in favor of SPIR-T (which has its own structurizer, with a different design).


cosmetics

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   74.74%   74.74%
=======================================
  Files           4        4
  Lines         388      388
=======================================
  Hits          290      290
  Misses         93       93
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ecbea...c92451c. Read the comment docs.


Error when training single class model

Hello,
first of all, thank you very much for your work on this project.
When i try to train a table detection model with one class called bordered, I get the following error which I can't resolve:
missing 4 required positional arguments: 'casting', 'from_', 'to', and 'i'
I'm annotating the data with Robotflow and exporting the annotation as COCO.

I set the number of classes (num_classes) in my config.py to 2, as it was recommended in another issue.
I also tried to set it to 1, with the same results.
My config.py file looks like this:
# The new config inherits a base config to highlight the necessary modification
_base_ = '/content/mmdetection/configs/mask_rcnn/mask_rcnn_r50_caffe_fpn_mstrain-poly_1x_coco.py'

# We also need to change the num_classes in head to match the dataset's annotation
model = dict(
    roi_head=dict(
        bbox_head=dict(num_classes=2),
        mask_head=dict(num_classes=2)))

# Modify dataset related settings
dataset_type = 'COCODataset'
classes = ('bordered',)
# See https://github.com/open-mmlab/mmdetection/blob/master/docs/2_new_data_model.md
data = dict(
    train=dict(
        img_prefix='/content/data/train/',
        classes=classes,
        ann_file='/content/data/train/coco.json'),
    val=dict(
        img_prefix='/content/data/val/',
        classes=classes,
        ann_file='/content/data/val/coco.json'),
    test=dict(
        img_prefix='/content/data/val/',
        classes=classes,
        ann_file='/content/data/val/coco.json'))

# We can use the pre-trained Mask RCNN model to obtain higher performance
load_from = '/content/checkpoints/mask_rcnn_r50_caffe_fpn_mstrain-poly_3x_coco_bbox_mAP-0.408__segm_mAP-0.37_20200504_163245-42aa3d00.pth'

And my coco.json file like this:
{
    "annotations": [
        {
            "area": 5231538.0,
            "bbox": [
                181,
                514,
                3081,
                1698
            ],
            "category_id": 1,
            "id": 1,
            "ignore": 0,
            "image_id": 1,
            "iscrowd": 0,
            "segmentation": [
                [
                    181,
                    514,
                    181,
                    2212,
                    3262,
                    2212,
                    3262,
                    514
                ]
            ]
        },
        {
            "area": 5317632.0,
            "bbox": [
                178,
                481,
                3072,
                1731
            ],
            "category_id": 1,
            "id": 2,
            "ignore": 0,
            "image_id": 2,
            "iscrowd": 0,
            "segmentation": [
                [
                    178,
                    481,
                    178,
                    2212,
                    3250,
                    2212,
                    3250,
                    481
                ]
            ]
        },
        {
            "area": 5338392.0,
            "bbox": [
                187,
                499,
                3054,
                1748
            ],
            "category_id": 1,
            "id": 3,
            "ignore": 0,
            "image_id": 3,
            "iscrowd": 0,
            "segmentation": [
                [
                    187,
                    499,
                    187,
                    2247,
                    3241,
                    2247,
                    3241,
                    499
                ]
            ]
        },
        {
            "area": 5252280.0,
            "bbox": [
                193,
                493,
                3036,
                1730
            ],
            "category_id": 1,
            "id": 4,
            "ignore": 0,
            "image_id": 4,
            "iscrowd": 0,
            "segmentation": [
                [
                    193,
                    493,
                    193,
                    2223,
                    3229,
                    2223,
                    3229,
                    493
                ]
            ]
        },
        {
            "area": 5449728.0,
            "bbox": [
                25,
                514,
                3072,
                1774
            ],
            "category_id": 1,
            "id": 5,
            "ignore": 0,
            "image_id": 5,
            "iscrowd": 0,
            "segmentation": [
                [
                    25,
                    514,
                    25,
                    2288,
                    3097,
                    2288,
                    3097,
                    514
                ]
            ]
        },
        {
            "area": 5665344.0,
            "bbox": [
                11,
                514,
                3106,
                1824
            ],
            "category_id": 1,
            "id": 6,
            "ignore": 0,
            "image_id": 6,
            "iscrowd": 0,
            "segmentation": [
                [
                    11,
                    514,
                    11,
                    2338,
                    3117,
                    2338,
                    3117,
                    514
                ]
            ]
        },
        {
            "area": 5231927.0,
            "bbox": [
                225,
                496,
                3019,
                1733
            ],
            "category_id": 1,
            "id": 7,
            "ignore": 0,
            "image_id": 7,
            "iscrowd": 0,
            "segmentation": [
                [
                    225,
                    496,
                    225,
                    2229,
                    3244,
                    2229,
                    3244,
                    496
                ]
            ]
        },
        {
            "area": 6534769.0,
            "bbox": [
                243,
                528,
                2969,
                2201
            ],
            "category_id": 1,
            "id": 8,
            "ignore": 0,
            "image_id": 8,
            "iscrowd": 0,
            "segmentation": [
                [
                    243,
                    528,
                    243,
                    2729,
                    3212,
                    2729,
                    3212,
                    528
                ]
            ]
        },
        {
            "area": 5565560.0,
            "bbox": [
                5,
                519,
                3080,
                1807
            ],
            "category_id": 1,
            "id": 9,
            "ignore": 0,
            "image_id": 9,
            "iscrowd": 0,
            "segmentation": [
                [
                    5,
                    519,
                    5,
                    2326,
                    3085,
                    2326,
                    3085,
                    519
                ]
            ]
        },
        {
            "area": 5209464.0,
            "bbox": [
                11,
                531,
                3068,
                1698
            ],
            "category_id": 1,
            "id": 10,
            "ignore": 0,
            "image_id": 10,
            "iscrowd": 0,
            "segmentation": [
                [
                    11,
                    531,
                    11,
                    2229,
                    3079,
                    2229,
                    3079,
                    531
                ]
            ]
        }
    ],
    "categories": [
        {
            "id": 1,
            "name": "bordered",
            "supercategory": "none"
        }
    ],
    "images": [
        {
            "file_name": "ubr18275_0010.jpg",
            "height": 2883,
            "id": 1,
            "width": 3262
        },
        {
            "file_name": "ubr18275_0012.jpg",
            "height": 2883,
            "id": 2,
            "width": 3263
        },
        {
            "file_name": "ubr18275_0014.jpg",
            "height": 2883,
            "id": 3,
            "width": 3262
        },
        {
            "file_name": "ubr18275_0016.jpg",
            "height": 2883,
            "id": 4,
            "width": 3262
        },
        {
            "file_name": "ubr18275_0017.jpg",
            "height": 2883,
            "id": 5,
            "width": 3262
        },
        {
            "file_name": "ubr18275_0023.jpg",
            "height": 2883,
            "id": 6,
            "width": 3263
        },
        {
            "file_name": "ubr18275_0024.jpg",
            "height": 2883,
            "id": 7,
            "width": 3263
        },
        {
            "file_name": "ubr18275_0028.jpg",
            "height": 2883,
            "id": 8,
            "width": 3263
        },
        {
            "file_name": "ubr18275_0029.jpg",
            "height": 2883,
            "id": 9,
            "width": 3263
        },
        {
            "file_name": "ubr18275_0031.jpg",
            "height": 2883,
            "id": 10,
            "width": 3262
        }
    ],
    "type": "instances"
}

torch and cuda available: 1.5.1+cu101 True
mmdet: 2.8.0
cuda: 10.1

Thank you very much in advance.

For single class detection, the num_classes in head should be 1 rather than 2. num_classes means the number of foreground classes, see the conventions.

For single class detection, the num_classes in head should be 1 rather than 2. num_classes means the number of foreground classes, see the conventions.

Thank you for your response.
Unfortunately the same error occurs when I set the classes to 1.
model = dict(
    roi_head=dict(
        bbox_head=dict(num_classes=1),
        mask_head=dict(num_classes=1)))

Thank you for your response.
Unfortunately the same error occurs when I set the classes to 1.
model = dict(
    roi_head=dict(
        bbox_head=dict(num_classes=1),
        mask_head=dict(num_classes=1)))


DSMR: TCP, reconnecting and V4 CRC support

Description: This PR adds TCP connection support and automatic reconnecting on disconnect. Also includes upstream dsmr_parser changes which add support for V4 telegram CRC checking.
Related issue (if applicable): #5144
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#1699
Example entry for configuration.yaml (if applicable):
# Example configuration.yaml entry for remote (TCP/IP, i.e. via ser2net) connection to host which is connected to Smartmeter
sensor:
  - platform: dsmr
    host: <IP_ADDRESS>
    port: 2001
    dsmr_version: 4

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.
[x] Waiting for changes to be released upstream.

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Waiting for upstream changes to dsmr_parser to be merged and released (the owner is very responsive), will be updating the requirement then: https://github.com/ndokter/dsmr_parser/pull/12
Also waiting for community testers to confirm functionality: https://community.home-assistant.io/t/support-for-reading-dutch-smart-meter-electricity-gas-p1-port/1676/146?u=aequitas

Good to go.


[base] The onTransitionEnter onTransitionExited methods are not documented in the Menu properties interface

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Please check the PR - https://github.com/mui/material-ui/pull/37568

The issue is about the Modal, not the Menu, right?

The issue is about the Modal, not the Menu, right?

yes, I have changed the title of the issue

@michaldudak please check the PR


Release 1.8

This release primarily improves interoperability when other projects consume TypeART.
This includes proper naming of CMake variables, to streamline support via FetchContent or, simply, with add_subdirectory.
Likewise, the LLVM pass options have been prefixed to avoid any name clashes.
The package config has been improved to also provide the wrapper scripts via cached variables.
Internally, we now support stack lifetime markers, which are used by LLVM to signal if a stack allocation becomes valid. This is relevant in the context of stack coloring algorithms, which reuse stack space but not necessarily with the same type -- this is important for TypeART to distinguish -- and is enabled now.
LLVM pass

Refactor command line options to use prefix typeart-
Support LLVM stack lifetime start markers when instrumenting stack allocations. Only when the lifetime of a stack var starts are it's address and type information valid. This is especially the case in the context of stack coloring, where stack space is re-used (with potentially different types but same memory address).
Add support for LLVM 14

Scripts & compiler wrapper

Try to detect and support Open MPI, Intel MPI and MPICH wrapping
Support compile & link single invocation, i.e., typeart-clang source.cpp -o source.exe. Previously a two step compilation process was required.

CMake

CMake: rename options and cache variables to TYPEART_ prefix
Package config provides the wrapper scripts via find_program as cached variables.

Misc

Update clang-format (configuration) to version 12
Provide new btree-backed map as alternative to Abseils
Fix Abseil to long-term release version
Add codespell config file
Add lit test targets check-typeart-... for testing
Fix lit flag for when thread support is detected, i.e., use Threads_FOUND

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-7 of 262 (97.33%)  changed or added relevant lines in 9 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.0%) to 89.956%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/passes/TypeARTPass.cpp
83
84
98.81%

lib/passes/analysis/MemOpVisitor.cpp
25
27
92.59%

lib/runtime/TypeResolution.cpp
86
90
95.56%

Files with Coverage Reduction
New Missed Lines
%

lib/runtime/TypeResolution.cpp
1
94.89%

lib/runtime/Runtime.cpp
3
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
3242

Relevant Lines:
3604

💛  - Coveralls


[carry 11669] Add Stale image info under Viewing Repostories and markdown fix-ups

carries https://github.com/docker/docker.github.io/pull/11669 with my review comments addressed, the commits squashed, and some markdown fix-ups I found on this page.

@FranchommeE  @spencerhcheng @usha-mandya PTAL

@thaJeztah Wondering if we can reduce the size of the images (Create repository, visibility settings, delete repository)in the Private repositories section. Looks good otherwise. Thanks.

@thaJeztah LGTM , thanks!
I had marked my 1st PR #11669 as Draft because it was missing screenshots.
Also I am unsure of the process to be in sync with Removing the feature flag (and make the feature GA) and deploying the updated documentation. There is also a conflict to expect upon merging, as this update shouldn't override the changes brought by #11668

Wondering if we can reduce the size of the images (Create repository, visibility settings, delete repository)in the Private repositories section. Looks good otherwise. Thanks.

I added a "max-width" to the images (included in https://github.com/docker/docker.github.io/pull/11686 as well). We should probably have a look at defining proper styles for those (using the bootstrap/css grid), also w.r.t. "hidpi" images.

There is also a conflict to expect upon merging, as this update shouldn't override the changes brought by #11668

Ah, yes, thanks for the heads-up; merge conflict should be trivial to fix

I'm creating a PR to remove the feature flags: https://docker.atlassian.net/browse/HUB-4619 which will be ready to deploy any time. I'll be out from Nov 5th to the 11th - giving @ddebroy a heads up on deployment coordination.

@FranchommeE Could you let us know when we are planning to go live with this update? Thanks.

@usha-mandya Perfect timing! I was just pinging you on Slack about this: we plan on going live this week. I am not sure yet of the exact date/time.


Plug for C++20 :P

Based on one part of issue #24
We could actually implement the compile-time configuration similarly to one of the proposals in the aforementioned issue, namely
constexpr oe::const_string_t conf = "{"
                                    "    'option1': true,"
                                    "    'option2': true,"
                                    "    'list_option3': {"
                                    "        'inside_opt1': true,"
                                    "        'inside_opt2': false"
                                    "    }"
                                    "}";

int main() {
    oe::preconfigure<conf>();

    oe::init("Oxygen Engine Demo", 1280, 720);
    oe::load_world_func("some_file.csl");
    oe::start();

    return 0;
}

This would require somewhat refactoring the structure of the internal API, as well as the use of C++20 for non-type-template-parameters.
Below is an example implementation. The basic idea is the following:
We create a completely object oriented API for the engine. There is one class, oxygen_engine_t, that does absolutely
everything. The C-Style API is a wrapper around that: A single global variable, and each public API function simply calls the
corresponding oxygen_engine_t member function.
The necessity for a single top level class that handles everything arises because of the desire for compile-time configuration.
The JSON string is parsed at compile time, and the resulting configuration struct is used as a template parameter while defining
the global oxygen_engine_t instance. That way, one an oxygen_engine_t member function is called, all of the configuration
options are known beforehand.
The catch is that this actually requires C++20 in order to be able to pass around the config string as a compile time constant.
https://godbolt.org/z/5q99a6qx8

Nice piece of code demonstration!
With your suggestion we have a serious problem because one would need to add an API function/method in 3(!) different places plus the implementation could only be in the .h and it would be a chore and a really large file. The 2016 version had a FEngine AND a FTaskmanager class and i though it would be simple to just have ONE task manager class in the end and the C-style API around it as a wrapper.
It could be possible to use this in your own APIs internally if you want (csl for example) if you manage to find a use case. You could change the interpreter class for example to work with templates like this. The only requirement by me would be to be C++17 compatible in the end with the same API. (This means only csl::interpret should stay the same. The class doesn't have to etc.) But you said you have not found a use case yet, so idk.
I think in any case the drawbacks outweigh the benefits for the main API in the end and as you said we still cannot find a use case for user-configurable compile-time constants.
Can you use the templated constructor with C++17 even if it is not a compile-time constant in the end?

Now that you say it, having to put every implementation in the header file is kind of a dealbreaker in this case, I agree :D
In order to be able to properly pass around the config options we would have to use C++20 for non-type-template-arguments.
Otherwise this
template<const_config_t Conf>
class oxygen_engine_t : public oxygen_engine_base_t {
    // ...
};

becomes this
template<bool ConfOption1_, bool ConfOption2_ /* ... */>
class oxygen_engine_t : public oxygen_engine_base_t {
    // ...
};

and we would only be able to pass integer and boolean types as config options (And enums, but they essentially are integer types).
And I am not entirely sure what you are refering to when you say "templated constructor" in your last sentence.

Ok, I thought it worked with C++17 only with making those parameters not constexpr but i was wrong.
So we cannot use this :D
If you found a use case where you really really really want to use user-configurable compile-time parameters on the main API bug me again and reopen this. But remember this is a game engine and almost everything should be able to change at start time or runtime whenever possible!


Replace our API's json with msgpack

That's what neovim uses and it fits better than json

Premature optimization


Smoke test

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/Azure/azure-docs-sdk-java, working directory: W:\vpjc-s, target branch: master, target branch commit: e374f00ba434707be38b4448817e5c666f2b6b31, source branch: smoke-test, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/Azure/azure-docs-sdk-java, working directory: W:\pucu-s, target branch: master, target branch commit: e374f00ba434707be38b4448817e5c666f2b6b31, source branch: smoke-test, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/Azure/azure-docs-sdk-java, working directory: W:\v4s2-s, target branch: master, target branch commit: e374f00ba434707be38b4448817e5c666f2b6b31, source branch: smoke-test, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


undefined local variable or method `index'

I am getting this error:
undefined local variable or method `index' for #<#<Class:0x0055e486ef2f98>:0x007f940ad636e8>

I do not know what I am doing wrong. Here is the code for the page:

            <button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-collapse">
                Toggle navigation

            </button>
            <%= link_to "Contact-App", page_path(index), class: "navbar-brand" %>

        <%= render 'shared/navigation_links' %>

I have an index page in my app/views/pages
This is what High_Voltage initializer looks like:
# config/initializers/high_voltage.rb
HighVoltage.configure do |config|
  config.home_page = 'index'
end

What could I possibly be doing wrong?

It sounds like you're looking to link to the root with your "Contact-App" link. You could instead use:
<%= link_to "Contact-App", root_path, class: "navbar-brand" %>