WIP: Archive openjdk regression tests output including diagnostic files

Change workDir from $(TEST_RESROOT) to TKG $(REPORTDIR) so it will be
archived by default
Do not need to archive *.jtr separately in Jenkins file as *.jtr are under
$(REPORTDIR) (i.e., test_output_*) now and they will be archived by default

Fixes: https://github.com/eclipse/openj9/issues/5454
Signed-off-by: lanxia<EMAIL_ADDRESS>

https://ci.eclipse.org/openj9/view/Test_grinder/job/Test-Grinder_Sandbox/28/
Output:
05:07:05.270  Unhandled exception
05:07:05.270  Type=Segmentation error vmState=0x00000000
05:07:05.270  J9Generic_Signal_Number=00000004 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
05:07:05.270  Handler1=000000000E0A20B0 Handler2=000000000E2A7340 InaccessibleAddress=0000000000000000
05:07:05.270  RDI=0000000010292B00 RSI=000000000FFBB220 RAX=0000000010292B00 RBX=00007000008EDAB8
05:07:05.270  RCX=0000000000000000 RDX=000000000FFBB220 R8=00000000000E0000 R9=00000000100D3300
05:07:05.270  R10=00007000008EDAE0 R11=0000000035AC7B0B R12=00007000008EDAC8 R13=00007000008EDAC0
05:07:05.270  R14=00007000008EDAB8 R15=00007000008EDAC0
05:07:05.270  RIP=0000000000000000 GS=0000 FS=0000 RSP=00007000008ED7B8
05:07:05.270  RFlags=0000000000010246 CS=002B RBP=00007000008EDAA0 ERR=0000000000000014
05:07:05.270  TRAPNO=000000140000000E CPU=0000000000140000 FAULTVADDR=0000000000000000
05:07:05.270  XMM0<PHONE_NUMBER>ac7b0b (f: 900496128.000000, d: 4.449042e-315)
05:07:05.270  XMM1<PHONE_NUMBER>292698 (f: 271132320.000000, d: 1.339572e-315)
05:07:05.270  XMM2 c3e0000000000000 (f: 0.000000, d: -9.223372e+18)
05:07:05.270  XMM3<PHONE_NUMBER>000016 (f: 22.000000, d: 1.086944e-322)
05:07:05.270  XMM4<PHONE_NUMBER>00002f (f: 47.000000, d: 2.322109e-322)
05:07:05.270  XMM5 3fd2e8e300000000 (f: 0.000000, d: 2.954643e-01)
05:07:05.270  XMM6 000fffffffffffff (f:<PHONE_NUMBER>.000000, d: 2.225074e-308)
05:07:05.270  XMM7 3ff0000000000000 (f: 0.000000, d: 1.000000e+00)
05:07:05.270  XMM8<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM9<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM10<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM11<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM12<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM13<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM14<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  XMM15<PHONE_NUMBER>000000 (f: 0.000000, d: 0.000000e+00)
05:07:05.270  Target=2_90_20190410_201 (Mac OS X 10.11.6)
05:07:05.270  CPU=amd64 (4 logical CPUs) (0x200000000 RAM)
05:07:05.270  ----------- Stack Backtrace -----------
05:07:05.270  ---------------------------------------
05:07:05.270  JVMDUMP039I Processing dump event "gpf", detail "" at 2019/04/12 04:11:36 - please wait.
05:07:05.270  JVMDUMP032I JVM requested System dump using '/Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/core.20190412.041136.24905.0001.dmp' in response to an event
05:07:05.270  JVMDUMP010I System dump written to /Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/core.20190412.041136.24905.0001.dmp
05:07:05.270  JVMDUMP032I JVM requested Java dump using '/Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/javacore.20190412.041136.24905.0002.txt' in response to an event
05:07:05.270  JVMDUMP010I Java dump written to /Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/javacore.20190412.041136.24905.0002.txt
05:07:05.270  JVMDUMP032I JVM requested Snap dump using '/Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/Snap.20190412.041136.24905.0003.trc' in response to an event
05:07:05.270  JVMDUMP010I Snap dump written to /Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/Snap.20190412.041136.24905.0003.trc
05:07:05.270  JVMDUMP007I JVM Requesting JIT dump using '/Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/jitdump.20190412.041136.24905.0004.dmp'
05:07:05.270  JVMDUMP010I JIT dump written to /Users/jenkins/workspace/Test-Grinder_Sandbox/openjdk-tests/TestConfig/test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/jitdump.20190412.041136.24905.0004.dmp

dmp can be found in the archive: https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Test/Test-Grinder_Sandbox/28/
Lans-MacBook-Pro:TestConfig lanxia$ find . -name *.dmp
./test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/core.20190412.041136.24905.0001.dmp
./test_output_15550559055705/jdk_util_0/work/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest/jitdump.20190412.041136.24905.0004.dmp

I could also change reportDir -r $(Q)$(TEST_RESROOT)$(D)report$(Q) to TKG $(REPORTDIR)/report, so it will be archived by default. I didn't change it in this PR since it looks like no one uses it. People that run openjdk regression locally will be able to see the reportDir.

Would like to deliver it after the release. Mark this PR WIP for now.

workDir is also the location for all executed tests, i.e. .class files. Probably filter those to reduce the archive size?

I checked the size and .class files does not seem to affect much, so I will keep them for now.

At one point very early on, we archived html files, but @akolarkunnu advised that the jtr files contained more information and were more useful, so we did not bother with the html files.
I am happy to have this particular PR merged now (ahead of the release) if you like.  We will still have 3 days to monitor runs before Tuesday, so the intent was locking the repo down later tonight.

Sorry Shelley, missed your msg last Friday. I am ok to merge it before release. Removing WIP.

Its not a problem to wait either (now that we are so close to the release, I will say we wait), also, since PR is still pending @sophia-guo 's review.


Add Helm-Dashboard

Cool open source tool that makes managing Helm charts more efficient and straightforward using a neat GUI

Please confirm this pull request meets the following requirements:

[X] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[X] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[X] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[X] Content (and my changes are in index.md)

I think this list should include this cool new open source tool

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[X] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[X] My suggested edits are not about an existing topic or collection, or at least not a single one
[X] My suggested edits are not about curating a new topic or collection, or at least not a single one
[X] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Just wanted to add Helm-Dashboard to the list of tools

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Closing


VEX documents in a image manifest

Docker builds are storing SBOMs and Attestations in a image manifest as described here in OCI spec . I wonder if we can store the VEX documents in the same manifest as new layers. Doing this can allow for attestations to be in a single image manifest that'll help build tooling on top with a single workflow.

Hey @RealHarshThakur vexctl already supports attesting openvex documents and attaching them to images in OCI registries (see vexctl attest --attach). We use the sigstore tooling under the hood.

@puerco  I mean, can we store the VEX documents as an image manifest similar to how a "docker build" produces it right now?
It seems like its currently storing the VEX documents in a sha256-hash.att

The attestations are designed to be added to the att bundle where cosign can find, download and verify them, so this is how we'll keep doing it by default at least. What's the use case?

For VEX documents that are constantly being added, it may get tricky to store them as image manifest. After having a chat with OCI spec maintainers, it looks like referrers API is the way to go. Similar to how cosign has this:
COSIGN_EXPERIMENTAL=1 cosign sign --allow-insecure-registry --registry-referrers-mode=oci-1-1

Yep, that's where we are heading. Once 1.1 is released and cosign moves we'll also inherit it.
Should we close this then?

yep, thanks!


Refactor add_currency()

Hi, I don't know if that's the desired structure of the code, but I was wondering if there's a specific need for all the Currency objects created by the final part of classes.py. After all, these objects are accessed via the CURRENCIES dict.
If there's no such specific need, I refactored classes.py so that CURRENCIES and CURRENCIES_BY_ISO get the objects from a loop. I eventually eliminated the add_currency() function. I'm creating a PR for that, merge it if you will, ok?

The way it currently works means that every currency is directly importable (from moneyed import USD, GBP), which is very convenient, and static analysis tools can ensure that the import is correct. With your changes, I imagine these things would not be true. So closing on that basis. If I've misunderstood please leave a comment.


Docs for debian 11 build are out of date

You provide build docs for Debian11, but they are just the Debian10 build docs copied. Some of the build dependencies do now exist in Debian 11 so they really need updating.
We now have abseil (0~20200923.3-2), and nlohmann-json (3.9.1-1). There are also a couple of crc32c implementations, but I'm not sure if they are the right ones?
So 'absl-dev nlohmann-json3-dev' should be added to the apt install line at the top and those two sections of 'download-and-build' removed.

Thanks, let me try to use at least the Abseil and nlohmann-json packages.  Unfortunately Protobuf and gRPC still need to be built from source.

Package
Debian Version
Required
Comments

Abseil
20200923
20200923

protobuf
3.12.x
3.15.8
Need to compile form source

gRPC
1.30
1.35
We need to compile our own gRPC because protobuf

nlohmann-json
3.9.1
3.4

crc32c
not found

Searched for crc32c and crc32

Unfortunately the Abseil version is Debian 11 is not recent enough for gRPC's needs.  We could try to pin gRPC to an old enough version, but it would need to be (a) old enough to use Abseil == 20200923.x, and (b) new enough to support Protobuf >= 3.15.8.
That seems too finicky, better to compile all three from source.

Thanks for the bug report. If you have any other thoughts on how to improve the instructions for Debian 11 (or 10, or 9) please let us know.


ci: Check with --locked flag

This makes it possible to detect issues like #192 earlier in the continuous integration process.

While we are at it, why not put this at every stage?

While we are at it, why not put this at every stage?

Do you mean cargo build as well?
https://github.com/Skallwar/suckit/blob/32aa47aa645d88f5954cdae813542003890775b3/.github/workflows/build_and_test.yml#L78
I can add it build command as well but check will already fail before reaching there.

Let's add it in build this way if the ci changes a bit and check is not before build for some reason, we will not have issues


Cherry-Pick

My History looks very messy, because in the tfs we picked a lot of code. Now I would like to change "Git-Tfs" so it uses Cherry-picks. But before I start I would like to know if this is even possible and where to start, because I have good experience in Git, but little in Tfs.

Now I would like to change "Git-Tfs" so it uses Cherry-picks.

You will need to elaborate more on that because it's not very clear.
Do you want to make changed in git-tfs to accommodate your workflow?
Or do you ask if git-tfs is able to handle a workflow where you do some git cherry-picks?
If it is the 2nd, it should not be a problem if you take care about always removing the git-tfs metadata at the bottom of the commit message i.e. "git-tfs-id: " for commits already pushed that you want to cherry-pick in another branch.

Like in the 2nd, I want to change git-tfs so that is mostly uses Cherry-picks instead of merges

I didn't fully get the explanation:
You said you are developing in TFS on several branches and are cherry-picking this. In TFS there is no cherry-pick, so I am not sure what you are doing.
Or are you importing these TFS branches into git-tfs and then cherry-picking these to other imported TFS branches?

I didn't fully get the explanation:

Me neither...

Okay in our TFS Repo that we use at the time we move a lot of code to a lot of different branches (they do this with merges and have a branching strategy with  Forward Integration and Backward Integration) and if you track 1 change-set it will look something like this.

When I now convert the Repo the Git the history is very confusing

so our idea would be that we just use cherry-picks so that we have smooth history and with git cherry-pick -sx you can always trace back where the code came from

Ok, that makes it clearer.
TFS forward/backward integration usually is  done on all the changesets and is stored in the merge information.  AFAIK it can  also be done on file level, so only parts of it are "picked". Neither of those have a 1:1 mapping in the git world.
So neither a git merge nor a git cherry-pick are good candidates, as the meaning is not the same as in TFS.
Furthermore, a git cherry-pick is just another commit, there is no information stored in git itself which identifies that commit A'  is actually a cherry pick of commit A
The only thing which comes close would be to deactivate the merge handling altoegether, e.g.
by forcing to always go into that if case. (completely untested, just an idea)
https://github.com/git-tfs/git-tfs/blob/d39c306eb8a4887e81ee11ccd66912335dae0eac/src/GitTfs/Core/GitTfsRemote.cs#L443-L444


added jax version of randman

I implemented a jax randman class and tested it in the 'Randman usage example' and 'Performance tests' notebooks.
There are three vmaps on top of the new 'eval_freq' method, and the final dataset is built by chunks to avoid out-of-memory errors.

Great, thanks! Would it be possible to put the Jax version in a separate file (e.g., jax.py) so that one could still use the library even without having jax installed? We could adopt a similar strategy for the PyTorch version.

I saw that the performance test only works on computers with two GPUs, would it be possible to rewrite the code so it runs on machine with a single GPU? Moreover, is the JAX code unloaded after the object is destroyed or can one only really use the jax code for jax programs (or else the GPU memory remains blocked)?


add capacity to decode by header-specified kid

The JWT header parameter kid can specify a key id with which the token should be verified. (JWT Spec). This PR adds this functionality to the library, by allowing the key parameter to decode to take a dictionary of {[keyId]: key}, and allowing the kid parameter of header to specify which key to decode with.
For example, if the header of token looks like
{ alg: 'RS256', kid: 'keyId123' }

then
jwt.decode(token, {keyId123: secret})

is equivalent to
jwt.decode(token, secret)

.
This is useful for interacting with third party JWT issuers, for example AWS Cognito. With these, you do not necessarily know which secret will be used to sign a token in advance. The only way to use these services with this library currently is
var header = JSON.parse(new Buffer(token.split('.')[0], 'base64').toString()) // can't get header with jwt-simple
var keys = getKeys() // say this returns { key1: 'key...', key2: 'key2...' }
var token = jwt.decode(token, keys[header.kid]);

Caveats
The kid parameter will generally refer to a key specified in an array of JWKs, which look like this. It's possible you might want the keys parameter to take an array of JWKs instead of the dictionary of {[kid]:key}. IMO it's not worth the complexity, but if you want me to change it to work like this then I can do that. Note however that this would add dependencies to this module as the conversion from JWK to pem is non-trivial.

If you were aiming for something, I would recommend JWKS but unfortunately most versions of Node don't support keys in the JWK format. I think as jwt-simple is designed to be simple, adding in JWKS support is a bit out of scope.


Image components doesn't render data URIs

Data URIs (data:image/jpeg;base64,{content}) are not rendered by dmc.Image (which returns a src="about:blank") or dmc.Avatar (which renders the default placeholder).
However, html.Div renders the same URI properly.

related to #256

@AnnMarieW Thanks. I searched for "data URI/URL" and didn't find it. Closing as dupe.


data race in router

See https://s3.amazonaws.com/flynn-ci-logs/20150124075627-ebb3efd3-build-64abc0bceb3faaa955ad67dbaa93ab54a0e697ae-2015-01-24-07-57-35.txt

/cc @benburkert @bgentry

ah, yeah, looks pretty clear-cut here. We're setting Addr and TLSAddr on the HTTPListener in Start() with no safety:
	s.Addr = s.listener.Addr().String()

Should be pretty easy to untangle that.

Should be fixed by #797.


change discourse to github discussions

The discourse group has been deactivated for a long time now.

Spurious netlrts-smp failure:
make[3]: Entering directory '/home/circleci/project/netlrts-linux-x86_64-smp/tests/charm++/load_balancing'
make -C lb_test testp OPTS='-g -Werror=vla -optimize -production' TESTOPTS='++local +setcpuaffinity +CmiSleepOnIdle ++ppn 2'
make[4]: Entering directory '/home/circleci/project/netlrts-linux-x86_64-smp/tests/charm++/load_balancing/lb_test'
../../../../bin/testrun  +p4 ./lb_test $(( 25 * 4)) 100 10 40 10 1000 ring +balancer GreedyLB +LBDebug 1  ++local +setcpuaffinity +CmiSleepOnIdle ++ppn 2
Charmrun> scalable start enabled.
Charmrun> started all node programs in 0.007 seconds.
Charm++> Running in SMP mode: 2 processes, 2 worker threads (PEs) + 1 comm threads per process, 4 PEs total
Charm++> The comm. thread both sends and receives messages
Converse/Charm++ Commit ID: v6.11.0-devel-390-g92f61428d
Charm++ built with internal error checking enabled.
Do not use for performance benchmarking (build without --enable-error-checking to do so).
Makefile:34: recipe for target 'testp' failed
make[4]: *** [testp] Terminated
Makefile:26: recipe for target 'testp-lb_test' failed
make[3]: *** [testp-lb_test] Terminated
Makefile:72: recipe for target 'testp-load_balancing' failed
make[2]: *** [testp-load_balancing] Terminated
Makefile:37: recipe for target 'testp-charm++' failed
make[1]: *** [testp-charm++] Terminated
Makefile.tests.common:36: recipe for target 'testp' failed
make: *** [testp] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded


Slow import time

The python_on_whales package is a bit slow to import (noticeable for scripts when you just want to show help output):
   > python -V
Python 3.12.1

   > echo 'import python_on_whales' > /tmp/script.py

   > time python3 /tmp/script.py

real    0m0.629s
user    0m0.569s
sys     0m0.057s

   > python -m cProfile /tmp/script.py | head
         1438040 function calls (1220502 primitive calls) in 1.141 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
       20    0.000    0.000    1.881    0.094 cli_wrapper.py:1(<module>)
       45    0.001    0.000    1.531    0.034 __init__.py:1(<module>)
    468/1    0.017    0.000    1.141    1.141 {built-in method builtins.exec}
        1    0.000    0.000    1.141    1.141 script.py:1(<module>)
   3502/1    0.005    0.000    1.141    1.141 <frozen importlib._bootstrap>:1349(_find_and_load)

Related to https://github.com/gabrieldemarmiesse/python-on-whales/issues/512 since importing these extra dependencies seems to be contributing around 25% of the time.

Thanks for the bug report, I reproduced it with tuna and -X importtime, and here are the results I found:

Importing python-on-whales takes around 480ms
Importing the download_cli module takes around 118ms, it will be fixed when #512 is fixed.
The majority of the time left (80%) is used to create the pydantic models, see https://github.com/pydantic/pydantic/issues/6768

There is not much we can do about the pydantic models. We can provide solutions to users:

Users who are making CLI tools or other tools that are very sensitive to import times should use lazy import tools such as https://pypi.org/project/lazy-imports/ . I have used such tools in the past and found them very performant and easy to use.
Mojo is turning out to solve a bunch of issue that are present in python. For example, since it's a compiled language, the import times only impact the compilation speed and not the runtime speed. Once Mojo is mature enough, I would be very happy to make python-on-whales compatible. Users should be able to then make CLI tools that start very fast and are not impacted by import times by using the Mojo compiler.

Since there is not much we can do except fixing #512  and then much later (1+ year) provide a Mojo package, I would advise to close this issue.

I think we should keep this open as import time can be important and I'd say it's currently too high, this is still currently a major pain point for me. Following https://github.com/gabrieldemarmiesse/python-on-whales/issues/512#issuecomment-2137956659 would you be happy with removing the dependencies that account for ~20% of the time or prefer to wait a bit longer?

The import time has improved slightly (in my testing around 500ms, down from 600ms) since removing the typer/tqdm dependency, and the config change at https://github.com/gabrieldemarmiesse/python-on-whales/pull/643 roughly halves this. However, a 200ms import time is still more than I'd hope for, e.g. for implementing a CLI tool that supports running a command in a running container, where the Podman command itself takes ~100ms. Perhaps we're just dependent on some more Pydantic performance improvements here...


Nested List and Inline markdown issues

I have found that some inline lists and bold fonts are not represented correctly in mkdocs material, but are displayed correctly in the traditional Markdown compiler.
A markdown of the form shown here will display the correct hierarchy and bolding correctly in both material and traditional markdown compilers:

Nulla et rhoncus turpis. Mauris ultricies elementum leo. Duis efficitur
accumsan nibh eu mattis. Vivamus tempus velit eros, porttitor placerat nibh
lacinia sed. Aenean in finibus diam Test.

Duis mollis est eget nibh volutpat, fermentum aliquet dui mollis.
Nam vulputate tincidunt fringilla.
Nullam dignissim ultrices urna non auctor.

However, when I remove some redundant-looking spaces (which is what most markdown editor plugins usually do), the traditional compiler displays it correctly, but material no longer displays the correct list hierarchy and bolding:

Nulla et rhoncus turpis. Mauris ultricies elementum leo. Duis efficitur
accumsan nibh eu mattis. Vivamus tempus velit eros, porttitor placerat nibh
lacinia sed. Aenean in finibus diamTest.

Duis mollis est eget nibh volutpat, fermentum aliquet dui mollis.
Nam vulputate tincidunt fringilla.
Nullam dignissim ultrices urna non auctor.

The Issue was from : https://github.com/squidfunk/mkdocs-material/issues/7841#issue-2759221599

There are a couple of things here.

I'm not sure what we mean by "traditional Markdown compilers", so let's ignore that. Python Markdown has been around a very long time, before recent CommonMark parsers and was based on the original spec that was outlined in https://daringfireball.net/projects/markdown/.

I'm not sure what extensions or options you are configuring when displaying your Markdown results. That is a must when we are talking about behavior. So, I am going to assume no additional extensions and no special options when talking about the behavior until at some future time when you disclose what options you are using.

Anyways, so you are pointing out two things that are clearly documented in Python Markdown's documentation.

List indentation is clearly documented as requiring 4 spaces or one tab (tabs being translated to 4 spaces, though you can represent a tab at any length in your editor). This is documented here and describes ways in which you can configure the accepted length with the associated caveats mentioned.

Middle-word emphasis is also described here and generally relates to emphasis with _, * will perform middle-word emphasis using the default configuration. I'm not sure what your configuration looks like so I cannot speculate, but you can see below that middle-word emphasis works fine.

"""Example."""
import markdown

print(f'Markdown Version: {markdown.__version__}')
print('-----')

MD = """
diam**Test**

diam **Test**
"""

extensions = []
extension_configs = {}

print(markdown.markdown(MD, extensions=extensions, extension_configs=extension_configs))

diamTest

diam Test

If you have something specific you'd like to demonstrate, please create a minimal, reproducible example. You can use the script above as a template if it is easier.

I'm sorry to have caused you confusion. Since I was using markdown rendering in both Github and VsCode with only two spaces for sublists, in addition middleWorld, e.g. bolding is rendered without additional spaces, I found these differences when using MkDocs, if these formats above are Python Markdown specifications, that Indeed not an issue.
It just bothers me that when I build my MKDocs site using GitHub as well as the regular markdown editing style (which uses only two spaces, and compiles the middle word without spaces), they don't display correctly. The following two writing formats, the first using the Python Markdown specification and the second the regular writing style, make no difference in the GitHub page and VSCode, but not in MakeDocs. You can see the link to the first time I asked the question, where the MakeDocs material points to Python Markdown as the issue：https://github.com/squidfunk/mkdocs-material/issues/7841#issuecomment-2562425756.
- Nulla et rhoncus turpis. Mauris ultricies elementum leo. Duis efficitur
  accumsan nibh eu mattis. Vivamus tempus velit eros, porttitor placerat nibh
  lacinia sed. Aenean in finibus diam **Test**.

    * Duis mollis est eget nibh volutpat, fermentum aliquet dui mollis.
    * Nam vulputate tincidunt fringilla.
    * Nullam dignissim ultrices urna non auctor.

- Nulla et rhoncus turpis. Mauris ultricies elementum leo. Duis efficitur
  accumsan nibh eu mattis. Vivamus tempus velit eros, porttitor placerat nibh
  lacinia sed. Aenean in finibus diam**Test**.

  * Duis mollis est eget nibh volutpat, fermentum aliquet dui mollis.
  * Nam vulputate tincidunt fringilla.
  * Nullam dignissim ultrices urna non auctor.

It just bothers me that when I build my MKDocs site using GitHub as well as the regular markdown editing style (which uses only two spaces, and compiles the middle word without spaces), they don't display correctly.

Let me be very clear. I cannot reproduce your middle-word problem with the example you have given, which means something else is causing that issue for you, so you would need to give us a minimal, reproducible example showing us the specific Markdown extension (with configuration) that is causing the issue. If you do not provide that, I cannot help further on that issue.

As for the list problem, you are welcome to use 4 spaces in both GitHub and Python Markdown which will work in both. You can search our issues and see that the 2 space difference has been brought up multiple times. This difference is documented and the repo owner has been very clear that there are no intentions to change this.
So, you can either use 4 spaces, configure tab_length as described in the docs (accepting any issues that it may or may not cause, though I don't think MkDocs exposes changing this option), or write your own list extension (or use one if it already exists) that uses 2 spaces for lists. The wiki points to a lot of third-party extensions, I believe one of them (though I don't recall which) allows for 2 space indents with lists, though I cannot speak to whether it introduces other issues as I do not use it.


Fix spelling mistake

Checklist:

[x]  I have performed a self-review of my own code,
[ ]  I have commented my code, particularly in hard-to-understand areas,
[ ]  I have made corresponding changes to the documentation,
[ ]  I have added tests that prove my fix is effective or that my feature works,
[x]  New and existing unit tests pass locally with my changes ("bundle exec rake"),
[ ]  Title include "WIP" if work is in progress.

Resolves #468
Description
This is a simple update to fix a spelling mistake.
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Ran locally (see screenshot)
Screenshots

Thanks for this!


prerequisites doesn't work

Hi,
I am trying to add some more directories to my auto load path by doing this
Padrino.before_load do
  MyApp.prerequisites << Padrino.root("app/presenters/*.rb")
end

This is the way specified in the docs. But when I try and do this I get the following error
vendor/ruby/1.9.1/gems/rake-<IP_ADDRESS>/lib/rake/ext/module.rb:36:in `const_missing': uninitialized constant Object::MyApp (NameError)

And even when I  do this after the
Padrino.load!

command, and do a reload, the files in this directory are not loaded.
Is there something that I am doing wrong here?

@DAddYE any ideas?

I think you should use dependencies:
Padrino.before_load do
  MyApp.dependencies << Padrino.root("app/presenters/*.rb")
end

prerequisites are deps that prevent app to load correctly, dependencies are files used in app.
If you need it globally you can also use:
Padrino.dependency_paths << Padrino.root("app/presenters/*.rb")

Finally if you want to add a path to your Padrino env you should use:
Padrino.set_load_paths = File.expand_path('../../app/presenters/', __FILE__)

# somewhere
require 'my_presenter'

Thanks I will give that a try.
But what I really wanted to know is why
MyApp

Was not recognised within the
Padrino.before_load do
end

block, within the boot.rb file?

Yep because apps will be loaded after before load.
# -> before_load
# -> loading config/apps.rb
# -> other stuff
# -> after_load

But then the documentation here
http://www.padrinorb.com/guides/development-commands
referring to autoload paths is wrong then, because the suggestions in the docs says this
# config/boot.rb
Padrino.before_load do
  SimpleApp.prerequisites << Padrino.root('my_app', 'custom_model.rb')
  SimpleApp.prerequisites << Padrino.root('custom_folder/*.rb')
end
Padrino.load!

Which is exactly what I did, which is what caused the problem.

Argh! Sorry!
@nesquena can you change from before_load to after_load ?

Fixed the typo, thanks @DAddYE

@DAddYE I'm having problems adding a path to the autoload paths.
There doesn't seem to be a Padrino.dependencies (or MyApp.dependencies) method?
If I add the path to MyApp.dependency_paths, then it doesn't automatically load the classes defined in the path.
If I add the path to MyApp.prerequisites, it does load the class, but changes to the class don't get reloaded.

I have found the same to be true.
I have to restart my app server each time I make changes to one of these files.
It is quite annoying but up till now I have managed it.

Add the path the padrino watcher: Padrino.set_load_paths('./foo/bar') then load as a prerequisites with App.prerequisites

In boot.rb turn on the devel mode to see what's happen: Padrino::Logger::Config[:development][:log_level] = :devel

Okay that seems to work
The real question though, for clarity sake is, what is the difference between
MyApp.dependencies
MyApp.prerequisites
Padrino.dependency_paths
I think I am not the only one that is confused as to the differences between them
I use them because the docs (and yourself) say to use them to achieve the goal, but I have no real understanding as to their differences, when or even where to use them so as they as used properly and as intended by the padrino devs.
An explanation or an addition to the docs would be greatly appreciated.

I'm also confused.
On Jan 14, 2012, at 7:29 PM, "Philip H. MacIver"
<EMAIL_ADDRESS>wrote:

Okay that seems to work
The real question though, for clarity sake is, what is the difference between
MyApp.dependencies
MyApp.prerequisites
Padrino.dependency_paths
I think I am not the only one that is confused as to the differences between them
I use them because the docs (and yourself) say to use them to achieve the goal, but I have no real understanding as to their differences, when or even where to use them so as they as used properly and as intended by the padrino devs.
An explanation or an addition to the docs would be greatly appreciated.

Reply to this email directly or view it on GitHub:
https://github.com/padrino/padrino-framework/issues/731#issuecomment-3496818

Yep, I can understand that and we are rewriting it in a more simple way.
App.dependencies are controllers, mailers or helpers.
Basically things to be loaded during App.
Prerequisites are thing that need to be loaded before App. I.e. models, libs.
Padrino.set_load_path is a shorthand of $LOAD_PATHS and in particular we use it to watch changes in our files for perform a reload.
Questions?

Okay I get that.
But then what is the diffrence between
MyApp.dependencies
and
Padrino.dependency_paths

The first one is dependencies of a single app, second one are all deps of all apps.

okay, thanks


Java: Update the model used in java/semantickernel/examples

Since July 2023, text-davinci-003 is not available for new users in Azure Open AI, another model should be used instead https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/legacy-models

https://github.com/microsoft/semantic-kernel/pull/4401

May require a migration to v1.0 once we get into our new repo.


Issues with building macOS Sample Player

After following the build instructions in the README, I run into the following errors when building the frameworks/project:

I believe the latest update to the XCFrameworks submodule fixes this issue.


Store FilteredMinimalFileTree patterns to the configuration cache

To enable file tree inputs like zipTree(file).matching(patternSet) to be correctly restored from the cache.
Follow-up to #19825

@bot-gradle test QFL

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Parse Query Filter Information

Summary
Initial implementations of parsing query filters into a simpler representation of what is expected of the resources in a query.
New behavior
Parses the elm for the where part of the relevant queries into a simpler representation. This recursively walks through the ELM and interprets what it is able to.
Code changes

src/Calculator.ts, src/Execution.ts, src/types/Calculator.ts: Updates to return parameters used for calculation, similarly to how elm is returned now. This is so the parameters (i.e. Measurement Period) be used again for interval re-calculations in the filter parsing. There are additional changes here to call the filter parsing work to add to the information collected about retrieves for the gap reports.
src/QueryFilterHelpers.ts: Static functions for parsing query information and filters. This is the core of this PR.
src/types/CQLExecution.d.ts: Beefed up type defs for cql-execution for more pieces that were used by the filter parsing.
src/types/ELMTypes.ts: Defined much more of the ELM structure for the expression types we use for parsing. The reference for these structures can be found here, https://cql.hl7.org/04-logicalspecification.html#expressions.
src/types/QueryFilterTypes.ts: Typescript fefinitions for the filter representations that come out of the query filter parsing.

Testing guidance
This works for EXM130. Running a gaps report with debugging on, you will see this new queryInfo structure on the retrieve data in the gaps.json debug. Other measures shouldn't break. But filters that cannot parse will be indicated in the output as { type: 'unknown' }.

jest coverage report 🧪
Total coverage

Status
Category
Percentage
Covered / Total

🔴
Statements
34.34% (+4.58% 🔼)
514/1497

🔴
Branches
19.84% (+4.96% 🔼)
363/1830

🔴
Functions
33.46% (+5.54% 🔼)
89/266

🔴
Lines
34.53% (+4.68% 🔼)
481/1393

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show new covered files 🌑
Coverage of new files

Status
Filename
Statements
Branches
Functions
Lines

🟡
QueryFilterHelpers.ts
61.64%
58.29%
91.67%
61.14%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Taking this out of draft. It could still use more unit tests though.

 Most are questions. Also, this needs a rebase to have the latest test coverage stuff. There should be no conflicts since we didn't touch any of the same files.
All of these inline comments were co-authored with @okeefm and @lmd59


Remove copy of old gtest.

The copy of gtest in the repository was old enough that it broke with
the new compiler on Ubuntu 14.04.  Rather than try to keep the copy of
gtest up to date, I deleted it and changed the build scripts to expect
it to be installed on the system at GTEST_DIR, a directory specified as
a build command line argument.
I also updated the README to reflect this change.

LGTM
Anything we need to be aware of when writing new gtest code for compatibility?


i386 2.0.0 and 2.0.1 releases are actually x64 version

Discussed in https://github.com/flant/ovpn-admin/discussions/140

Originally posted by Alexbanul September  4, 2022
Can you check ovpn-admin-linux-386.tar.gz ?
file ovpn-admin

ovpn-admin: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, for GNU/Linux 2.6.32, Go BuildID=7UNSQVSGBvjC5CAhseiK/0E6tJgr_39gqrRfAEML3/UBPiv3n_l7SoXebHund1/LC5lYoWbtKxPH5uehdCo, BuildID[sha1]=43e2b35a5a31ee643d5c5d60712d571b4ced90f5, stripped

I would like to try ovpn-admin but I couldn't build it from sources and the x86 binary version 1.7.5 doesn't work with openvpn server 2..4.7
Thank you!

fixed by this commit


Ticket Validation - Fix wrong error behaviour

Description
Dismiss navigation controller after clicking OK on error message.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-10874

Closing the PR as per the final decision.
FYI: @KerstinJumpertz


Fix introduced typo in HDRIVE if statement, updated ebuild.

 I introduced a typo in your Linux operating system classes. I fixed it. Also, I got some recommendations from the Gentoo Packaging team (https://bugs.gentoo.org/show_bug.cgi?id=578114) which I've worked into the ebuild.

Great! Thanks for fixing that!


Not able to use GPU

I have tied lucid with a bunch of tensoflow-gpu versions and most of them were giving errors like this
NodeDef mentions attr 'Truncate' not in Op<name=Cast; signature=x:SrcT -> y:DstT; attr=SrcT:type; attr=DstT:type>; NodeDef: import/ToFloat = Cast[DstT=DT_FLOAT, SrcT=DT_UINT8, Truncate=false] or too old that some ops are not defined
The only way that works for me was pip install lucid[tf] which works but only CPU version
Can I get more precise compatibility instructions?

@madnavs sorry you're running into compatibility issues. I think this is unlikely to be an issue with lucid, though—the error you describe afaik happens when you try to import a saved graph from a newer TF version in an older one. I can't help with setting up tensorflow in general, but ensure you're using a new-ish version by inspecting the version of TF your actual code loads:
import tensorflow as tf
print(tf.__version__)

(We run the tests on r1.13, but anything above ~1.11 should mostly work.)
If you're installing a modern version and still running into these import issues with models from our modelzoo, please reopen—and in that case if you could add a reproduction that would be awesome; preferably in a colab notebook. :-)


Fix: using many prisma client versions on the past test

Our test now does not support more than one past version test.
Because we have a DB from Heroku to test with and we use schema name for every test by os name and node version here you will use the same schema name so every test will reset the schema for the other one.

Updated the create schema function to add the prisma version to it.
Moved the Heroku DB link to GitHub actions secrets.
Updated the CONTRIBUTING.md files on how we will use the test on the local and from fork repos.

We must add the E2E_DB_URL to GitHub actions secrets before running the actions workflow for this PR

@AhmedElywa  I think this PR has too much going on. Could we please split this out into a few PR's based on the functionality we're adding? For example:
PR 1: Move the Heroku DB link to GitHub actions secrets.
PR 2: Update the create schema functions to add the Prisma versions
PR 3: Update documentation for local testing

@AhmedElywa I think this PR has too much going on. Could we please split this out into a few PR's based on the functionality we're adding? For example:
PR 1: Move the Heroku DB link to GitHub actions secrets. PR 2: Update the create schema functions to add the Prisma versions PR 3: Update documentation for local testing

I am working on the same file same line to add the prisma version and DB URL it will make a conflict?


Installation problems on OSX

I've tried to install Magenta in many different ways but none works.
Maybe need to update my osx version? I'm on 10.10.5
Donwloaded an installed both Anaconda 2 and 3.
But when running the magenta installation script always outputs an error saying
"CONDA_PREFIX: readonly variable"
Then tried manually with Python 2.7 and Python 3.5 and 3.7
With 2.7 and 3.7 always got an error saying
Could not find a version that satisfies the requirement tensorflow>=1.13.0 (from magenta)
With 3.5 got an error saying
Could not find a version that satisfies the requirement magenta (from versions: ) No matching distribution found for magenta
Any ideas on this?
Sorry I'm new to Tensorflow/Magenta

I've managed to get the same problem both with the Anaconda and manual installation instructions (for python 2.7) and narrow the problem a bit.
Solved the issue with CONDA_PREFIX adding the correct path into bash:
export PATH=~/anaconda2/bin:$PATH
and now using Anaconda for python 2.7 properly but I get the same error:
ERROR: Could not find a version that satisfies the requirement tensorflow>=1.13.0 (from magenta) (from versions: none)
ERROR: No matching distribution found for tensorflow>=1.13.0 (from magenta)

After updating to a latest version of OSX (now on 10.12.6) I can install all packages correctly.
So now the installation seems to be successful but unfortunately when I try to run any instruction on the command line I get always an error like:
[1]    41576 illegal hardware instruction  convert_dir_to_note_sequences   --recursive
That means that my processor isn't compatible?
As far as I understand tensorflow is properly installed.
My processor is an Intel Xeon 3,33 GHz 6-Core Intel Xeon


--acceptCertificate can accept fingerprints in a variety of formats

When using the --acceptCertificate parameter, the JSS CLI requires the fingerprint that is specified to be in a hex string format. The value must meet the following criteria:

be 60 characters long
all characters must be upper-case
semicolon is used to separate bytes

The following is an example of an acceptable value:
5E:D1:5E:D4:D4:42:71:CC:30:A5:B6:A2:DA:A4:79:06:67:CB:F6:36
Depending on the approach used to read the fingerprint from the certificate, the fingerprint value may not conform to these requirements. For example, the fingerprint above may be returned in the following formats:

5ED15ED4D44271CC30A5B6A2DAA4790667CBF636
5e:d1:5e:d4:d4:42:71:cc:30:a5:b6:a2:da:a4:79:06:67:cb:f6:36
5ed15ed4d44271cc30a5b6a2daa4790667cbf636

This feature ensures that fingerprints in a variety of formats can be matched correctly.

The related pull request has been merged.

Yes. this works. jss deploy app --acceptCertificate 89:17:0D:35:FB:F6:FC:3E:8E:E5:9A:22:CE:6C:83:81:8C:DE:76:DD -c -d Thank you!


Custom tree views: Expanding an initially collapsed tree node triggers full recursive loading of collapsed child nodes

VSCode Version: 1.13.1
OS Version: Win 10

Steps to Reproduce:

Create a custom tree view where there is a collapsed node with children that in turn are collapsed as well (with children etc. of their own).
Add a log statement in getChildren() to observe loading.
Run the extension and click on the collapsed node. Observe how the whole subtree is loaded even though only the next level is displayed.

This is a massive problem when you rely on lazy loading for cases when loading a full subtree is not feasible and relies on heavier operations. Given that lazy loading seems to be applied for the initial tree state I assume this is some kind of bug.

@letmaik May I know what is the collapsibleState of your TreeItem? If it is set to TreeItemCollapsibleState.Collapsed then we will ask for children of that item only when the user Expands it. If it is set to TreeItemCollapsibleState.Expanded then we will ask the children of that item immediately to show the children.

All are initially collapsed. The way you describe it is what I would expect, but that's not what I'm seeing.

Will investigate and see what is causing this. Thanks.

@letmaik  Here is my sample tree provider. And I see that getChildren is called only when the parent state is Expanded.
vscode.window.registerTreeDataProvider('testView', <vscode.TreeDataProvider<string>>{
	getChildren(element: string): string[] {
		if (!element) {
			return ['1'];
		}
		if (element === '1') {
			return ['1.1', '1.2']
		}
		if (element === '1.1') {
			return ['1.1.1', '1.1.2']
		}
		if (element === '1.1.2') {
			return ['<IP_ADDRESS>']
		}
		return null;

	},
	getTreeItem(element: string): vscode.TreeItem {
		let collapsibleItemState;
		if (element === '1') {
			collapsibleItemState = vscode.TreeItemCollapsibleState.Expanded;
		}
		if (element === '1.1' || element === '1.2') {
			collapsibleItemState = vscode.TreeItemCollapsibleState.Collapsed;
		}
		if (element === '1.1.2') {
			collapsibleItemState = vscode.TreeItemCollapsibleState.Expanded;
		}
		return new vscode.TreeItem(element, collapsibleItemState);
	}
});

Can you please provide your sample snippet that is causing this issue?

I just tried it again and can confirm that everything is fine. I really have no idea what happened when I first noticed that. Maybe I was mislead by something. Sorry about that!


Post slack message when e2e tests fail or a regression has been detected

Details

Coming from here.
The aim of these changes it to:

Send a slack message when the e2e test pipeline fails / is broken to the Margelo slack room, so we can fix it asap.
Send a slack message to the #newdot-performance room when a performance regression has been detected, so it can be addressed asap.

Fixed Issues

https://expensify.slack.com/archives/C035J5C9FAP/p1706861462618879
Tests

This is a dev/CI only change, no tests needed.
Offline tests

QA Steps

This is a dev/CI only change, no tests needed.
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
This is a dev/CI only change, no screenshots needed.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@AndrewGable @mountiny

Yes, updated the PR to use the action directly and not temper with the existing composite action!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.39-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌


Ability to Fully Export and Import All Memos and Instance Configurations

Is your feature request related to a problem?
Absolutely. As a frequent user of the Memos, I've come across a recurring issue. While the app does a fantastic job at storing and organizing my notes, there are scenarios where I need to switch server or reinstall the app. During these transitions, I often find restoring my memos and configurations challenging, as there is no straightforward way to export and import all memos and instance configurations.
Describe the solution you'd like
I propose the introduction of a comprehensive export and import feature. More specifically, I'd like functionality that allows users to fully export all their memos, including attachments, tags, and custom configuration settings, into a file format like ZIP. This feature should also allow for the reverse process, i.e., importing all memos and instance configurations from the previously mentioned format.
This would ensure that user data is securely and conveniently backed up and enable easy data transfer across instances, should the need arise.
Additional context
This new feature would significantly enhance the user's control over their data and make it easier to switch services or reinstall the app without the fear of data loss. It would be a valuable addition to the Memos.

Agreed. Just like Wordpress' im- and export feature.
Currently, there's something that does export your memos, kirika, but that isn't hosted anywhere anymore. Perhaps kirika could be worked into memos as a native feature?

"All Memos and Instance Configurations"

I guess this is what the docker container stored. 😂

Any update on this feature?

Backups are not in the pipeline. See https://github.com/usememos/memos/issues/3802#issuecomment-2293215545
All your data is available in your mapped folder (db and assets, assuming you are using docker) so you should be able to back it up easily


add more descriptions, etc. to YAML files to fill out documentation

Consider adding additional definitions for different audiences (e.g. contributor vs user)


Invalid username or password

The project looks nice, I installed genieacs and genieacs-gui.
I can't log in to the genieacs-gui, any idea why? TY
Tested with both usernames and password in the users table.
db/development.sqlite3
sqlite> select * from users;
id|username|password|created_at|updated_at
1|admin|admin|2016-09-07 11:30:56.369909|2016-09-07 11:30:56.369909
2|user|user|2016-09-07 11:30:56.374503|2016-09-07 11:30:56.374503
cd genieacs-gui
cp config/graphs-sample.json.erb config/graphs.json.erb
cp config/index_parameters-sample.yml config/index_parameters.yml
cp config/summary_parameters-sample.yml config/summary_parameters.yml
cp config/parameters_edit-sample.yml config/parameters_edit.yml
cp config/parameter_renderers-sample.yml config/parameter_renderers.yml
cp config/roles-sample.yml config/roles.yml
cp config/users-sample.yml config/users.yml

Didn't get much time to check out the code. but fixed an issue in ruby/2.3.0/psych.rb.
Is this the correct yml?

Load the document contained in +filename+.  Returns the yaml contained in
+filename+ as a Ruby object
def self.load_file filename
filename = "config/summary_parameters-sample.yml"
File.open(filename, 'r:bom|utf-8') { |f| self.load f, filename }
end

Hi @ztgu !
This GitHub issue tracker is only for known bugs. There in the mailing list http://lists.genieacs.com/mailman/listinfo you can discuss it, if you explain us a little bit more that would be great! Including what have you installed and how.


No need to wait after Wire.requestFrom().

Hi, I noticed that in your repositories there is always a while(Wire.available() == 0); after a Wire.requestFrom(). You may remove all those lines with while(Wire.available() == 0); (11 times).
Explanation: Common-mistakes#1

Thanks for the catch @Koepel ! And that's a very nice Wiki resource that you've put together.
While you're right that the use of the Wire.available() can be removed, blocking of the remainder of the program execution was intentional. In these sketches, the whole point of the programs are to report temperature, and they don't really do anything useful if the temperature sensor doesn't return any data. However, the failure mode of the program simply stopping may be confusing for beginning users, so I'm going to make a change to check the returned number of bytes from Wire.requestFrom(), print an error message if it is zero, and then halt the program execution.

I prefer to check if the number of requested bytes is the same as the number of received bytes. Either with the return value of Wire.requestFrom() or with a single call to Wire.available().
At this moment that is the same as checking for zero (or non-zero), since the Wire library returns zero if it detects a problem on the I2C bus.

Is your preference for doing that to handle multi-byte requests that might return incomplete data? In the examples that I've just updated, they are all single byte requests. As far as I'm aware, the only conceivable values that could be returned by Wire.requestFrom() are 0 or 1 when a request for a single byte is made. Thus, in my examples, halting to an error on the return value being equal to zero is functionally equivalent to checking that the return value is not equal to 1.

Yes, I meant for multi-byte requests. For a single byte it is 0 or 1 of course.

Ok - understood. Will keep that in mind for any multi-byte reads that I do in the future!


Running SP with default parameters could be improved

The example for running a SP with a default parameter is (as usual for MS help pages) the most simple case. And in this case perhaps the least helpful. Far more useful would be an example of running a sp where it has two default parms and you only need to supply the second.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d1f2710f-b5a5-bb12-f204-3d332ef0356e
Version Independent ID: e838c337-fabe-5a2c-f605-ee389b321227
Content: Specify Parameters - SQL Server
Content Source: docs/relational-databases/stored-procedures/specify-parameters.md
Service: sql
Sub-service: stored-procedures
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@nottoc -- thank you for your feedback and request.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@WilliamDAssafMSFT -- William, please look into this issue.

Hi @nottoc, thanks for taking the time to provide this feedback. You'll be happy to know this article update is in flight, to add a more detailed example with multiple nullable parameters. This is great feedback for how Microsoft Docs, even old reference articles like this, can be made more useful and applicable to practical use. Keep the great ideas coming!
You can even author the suggestions for code samples like this by making an edit to our open-source docs here on GitHub. To add a commit and receive credit as a contributor to the article, create a Pull Request and get the ball rolling on a doc improvement. By opening a pull request, you're collaborating with the author(s), like myself, to add changes directly to the documentation. After the updated article is reviewed and published, GitHub will list you as an article contributor. Select the "Edit" pencil at the top of most articles in Microsoft Docs to begin a pull request.
Either way, thanks for your feedback! Closing this issue. Look for an updated doc soon.


open-watcom-v2-unwrapped: unstable-2022-10-03 -> unstable-2023-01-30, more platforms

Description of changes

bump
adjust patching to some changes to the date embedding
enable on more platforms

Aarch64 (new, tested on aarch64-linux, aarch64-darwin untested)
32-bit ARM (already existed but I can't test it)
MIPS (32-bit support should be there but the wrapper won't know where the binaries are placed, feedback from anyone on this would be appreciated!)

(PPC should be supported too but there's no convenient entry for that in doubles.nix, wrapper also won't know where the binaries are)
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build open-watcom-v2-unwrapped

Hmm, seems like DOSBox doesn't build on aarch64-darwin… Gonna have to test this another time I guess.

Looks like DOSBox got fixed on aarch64-darwin, maybe worth another test?

@ofborg build open-watcom-v2-unwrapped

Hmm still having no luck with the aarch64-darwin CI, this time for reasons that feel entirely outside of my control. Must not be my year haha.
deleting unused links...
note: currently hard linking saves 0.00 MiB
copying path '/nix/store/b6y2prxms56m2kzssqdkcgxxrf83yx4d-clang-11.1.0' from 'https://cache.nixos.org'...
trying https://github.com/open-watcom/open-watcom-v2/archive/de461d35171d88ea80030608597699cb89e1dbe6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
copying path '/nix/store/dkmq62ibx58cmci1nq1rbwsc0y067r85-cctools-binutils-darwin-973.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/kvqy6garv73hnn6iiaparwicvskacflp-cctools-binutils-darwin-wrapper-973.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/fb4rdxr69sy1vsi98z3njxjzdq3rj3ah-clang-wrapper-11.1.0' from 'https://cache.nixos.org'...
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
copying path '/nix/store/mnr2a6hn5ng7a0rdnklwlk3k8ifpvvi5-stdenv-darwin' from 'https://cache.nixos.org'...
running auto-GC to free<PHONE_NUMBER>8 bytes
finding garbage collector roots...
deleting garbage...
deleting unused links...
note: currently hard linking saves 0.00 MiB
100 69.9M    0 69.9M    0     0  6974k      0 --:--:--  0:00:10 --:--:-- 9375k
unpacking source archive /private/tmp/nix-build-source.drv-0/de461d35171d88ea80030608597699cb89e1dbe6.tar.gz
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/seg16.asm': No space left on device
running auto-GC to free<PHONE_NUMBER>6 bytes
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/seg386.asm': No space left on device
error (ignored): error: cannot bind to socket '/nix/var/nix/gc-socket/socket': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/seh386v2.asm': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/stjmp086.asm': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/stjmp386.asm': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/bld/clib/startup/a/stjmpaxp.asm': No space left on device
[...]
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/zipup.sh': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/zipuprel.cmd': No space left on device
mv: cannot create regular file '/nix/store/mkmlzcqh93w8f1hbrvm231ixpk397ahx-source/zipuprel.sh': No space left on device
error: writing to file: No space left on device

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1636

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1776


Code cells in command mode should be rendered

CodeMirror measures on window resizes, so having as few around as possible is good.

See https://codemirror.net/demo/runmode.html for an example - generates innerHTML on a node:
import "codemirror/addon/runmode/runmode"
CodeMirror.runMode(myText, myMode, myNode);

This should not be done automatically by the code cell, but available as render/unrender methods that can be used by a single-user notebook or a console, for example.

👍
I agree. In the console, this is a no-brainer optimization.

Moved to https://github.com/jupyter/jupyterlab/issues/15


Hydration mismatch when custom element contains child node

Environment

Operating System: Linux
Node Version:     v19.8.1
Nuxt Version:     3.4.1
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      vue
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/dritter/nuxt-hydration-mismatch-reproducer
Describe the bug
If I have a custom element that has a child node, I get an hydration mismatch.

This reproducer configures a custom element my-component (using a nitro hook) and uses it.
The custom element renders a red block on the client side.
Interestingly this does not happen, if:

the custom element has no child node
I wrap the connectedCallback() code in a setTimeout with a large timeout (like 1000ms)

I would have guessed that by marking it as custom element that this element gets completely ignored.
Not sure if this is a Bug in really in nuxt or in Vues SSR part (apologies if this is wrong).

This doesn't sound like a Nuxt issue to me. Would you see if you can reproduce with https://stackblitz.com/github/nuxt-contrib/vue3-ssr-starter and, if so, raise an issue to https://github.com/vuejs/core ? 🙏

@dritter are you using nuxt-alt/auth?

@dritter are you using nuxt-alt/auth?

@zabavnikov Nope.
@danielroe I was able to reproduce it upstream and created https://github.com/vuejs/core/issues/8110
Thanks for your help.
Closing this Issue here.

I encountered the same error? How did you solve it

@cn1001wang This is not solved. I closed this issue because it is a bug within vue, not nuxt. See https://github.com/vuejs/core/issues/8110

Btw. I forgot to mention that we could work around it using a 3rd party lib to delay hydration: https://github.com/Baroshem/nuxt-lazy-hydrate


Updated BGP session filter to use ASN attribute instead of number

This resolves an issue in #98 where the search filter on BGP Sessions is broken

I'm going to close this and open one that also includes the fix for issue #119


Traefik behaves as if using port 8443 externally (instead of 443)

Do you want to request a feature or report a bug?
Bug
What did you do?

I followed official documentation to install Traefik using Helm 3: https://docs.traefik.io/getting-started/install-traefik/#use-the-helm-chart
I added a custom value to get HTTP to https redirection:
`additionalArguments:

--entrypoints.web.http.redirections.entrypoint.to=websecure`

What did you expect to see?
I expected http://toto.com to redirect requests to https://toto.com
What did you see instead?

http://toto.com redirects to https://toto.com:8443
Can be explained by the fact that traefik in launched with --entryPoints.websecure.address=:8443 by the Helm template to avoid root privileges (perfectly understandable from a security point of view, if it was working...)

Output of traefik version: (What version of Traefik are you using?)
traefik:2.2.1

What is your environment & configuration (arguments, toml, provider, platform, ...)?
Standard, bare-metal Kubernetes

This is the values I had to customize to go forward (sadly running the container as root, yet with limited capabilities):
ports:   web:     port: 80   websecure:     port: 443 securityContext:   capabilities:     add:       - NET_BIND_SERVICE   runAsNonRoot: false   runAsUser: 0

Hello,
The redirection can be defined like that:
additionalArguments:
- --entrypoints.web.http.redirections.entrypoint.to=433
- --entrypoints.web.http.redirections.entrypoint.scheme=https

Hi @ldez ,
thanks for your suggestion. Yet, it gives me this error:
time="2020-05-02T18:11:56Z" level=error msg="'to' entry point field references a non-existing entry point: 433" providerName=internal entryPointName=web

Check your Traefik version, it must be 2.2.1

Yes, it is:
$ k -n traefik-v2 get deployments.apps traefik -o json | jq -r '.spec.template.spec.containers[0].image'
traefik:2.2.1

Sorry mistake in my example:
additionalArguments:
- --entrypoints.web.http.redirections.entrypoint.to=:433
- --entrypoints.web.http.redirections.entrypoint.scheme=https

Thanks @ldez, not that intuitive, but your solution works!

I have same issue after upgrading to 2.2.1 , chart 8.1.4
we need to change
--entrypoints.web.http.redirections.entryPoint.to=websecure
to
when I have --entrypoints.web.http.redirections.entryPoint.to=:443

I also have the same problem, it was not solved. Can you help me ?
        - --entryPoints.web.address=:8000
        - --entryPoints.websecure.address=:8443
        - --entrypoints.web.http.redirections.entrypoint.to=:8443
        - --entrypoints.web.http.redirections.entrypoint.scheme=https

apiVersion: apps/v1
kind: Deployment
metadata:
 name: aa
spec:
 replicas: 1
 selector:
   matchLabels:
     app: aa
 template:
   metadata:
     labels:
       app: aa
   spec:
     containers:
     - name: aa
       image: aa/aa
       ports:
       - containerPort: 3000
     imagePullSecrets:
       - name: a
---
apiVersion: v1
kind: Service
metadata:
 name: aa-svc
spec:
 ports:
 - port: 80
   targetPort: 3000
   protocol: TCP
   name: http
 - port: 443
   targetPort: 3000
   protocol: TCP
   name: https
 selector:
   app: aa
---

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: aa-ingress
spec:
  rules:
    - host: aa.test.com
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: aa-svc
                port:
                  number: 80

apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: aatest
  namespace: default
spec:
  entryPoints:
    - websecure
  routes:
    - match: Host(`aa.test.com`)
      kind: Rule
      services:
        - name: aa-svc
          port: 80
  tls:
    secretName: aa-cert

I used myvalues.yaml and it worked.
It didn't need securityContext: add: [NET_BIND_SERVICE]

chart version: 33.0.0
app version: v3.2.0

# myvalues.yaml
ports:
  web:
    redirectTo:
      port: websecure

#### skip it
#securityContext:
#  capabilities:
#    drop: [ALL]
#    add: [NET_BIND_SERVICE]
#  readOnlyRootFilesystem: true
#  runAsGroup: 0
#  runAsNonRoot: false
#  runAsUser: 0


Add a default value to the dynamics

https://answers.ros.org/question/416011/strange-behavior-and-instability-of-six-axis-manipulator-in-ros-2-with-gazeboclassic-when-using-position-control/
The provided link addresses the actual issue. I would like to suggest adding a default value to the friction and damping parameters to minimize unnecessary errors and complications. As a newcomer to ROS, I apologize if this suggestion seems trivial or misguided. I am proposing this idea based on personal experience, as I encountered significant difficulty in identifying the root cause of the issue.

Hi @danzimmerman, I appreciate your explanation about the 'fmax' parameter and its implications in gazebo_ros2_control. Based on my experience, I suggest that we consider changing the default value of the 'fmax' parameter. This might help to prevent confusion and unintended errors, especially for newcomers in this field.
Alternatively, adding a clear warning in the documentation about the potential issues when the dynamics tags are not properly set could be beneficial. This could highlight the importance of setting these tags and the potential problems that might occur if they are omitted.
I believe these changes could significantly improve user experience and make it easier for beginners to understand and use gazebo_ros2_control effectively. Thanks again for your insightful explanation.


Error in SpatialPlot(object = object, features = features, images = images,  :    Could not find any spatial image information

Hello everyone,
I am trying to visualize the file SS200000135TL_D1.h5ad (https://db.cngb.org/stomics/datasets/STDS0000234) in Rstudio using Seurat.
In order to be clear, what I did is:

Download the .h5ad file from the link above
Following the tutorial page https://stereopy.readthedocs.io/en/latest/Tutorials/Format_Conversion.html , I wanted to convert the .h5ad file in a .rds file in order to see it in RStudio and work with it using Seurat
I ran the command Rscript h5ad2rds.R --infile  --outfile  and I obtained the file SS200000135TL_D1.rds. Here is the output message:

Attaching package: ‘dplyr’
The following objects are masked from ‘package:stats’:
filter, lag

The following objects are masked from ‘package:base’:
intersect, setdiff, setequal, union

Loading required package: SeuratObject
Loading required package: sp
Attaching package: ‘SeuratObject’
The following objects are masked from ‘package:base’:
%||%, intersect, t

Attaching package: ‘Seurat’
The following object is masked from ‘package:base’:
%||%

Registered S3 method overwritten by 'SeuratDisk':
method            from
as.sparse.H5Group Seurat
Warning: Unknown file type: h5ad
Creating h5Seurat file for version <IP_ADDRESS>00
Adding X as data
Adding raw/X as counts
Adding meta.features from raw/var
Adding X_pca as cell embeddings for pca
Adding X_umap as cell embeddings for umap
Adding spatial as cell embeddings for spatial
Adding sn to miscellaneous data
[1] "Finished! Converting h5ad to h5seurat file at:"
[2] "./SS200000135TL_D1.h5seurat"
[1] "h5seurat time consuming: 1.978"
Validating h5Seurat file
Initializing Spatial with data
Adding counts for Spatial
Adding feature-level metadata for Spatial
Adding reduction pca
Adding cell embeddings for pca
Adding miscellaneous information for pca
Adding reduction spatial
Adding cell embeddings for spatial
Adding miscellaneous information for spatial
Adding reduction umap
Adding cell embeddings for umap
Adding miscellaneous information for umap
Adding command information
Adding cell-level metadata
Adding tool-specific results
Warning message:
Key ‘spatial_’ taken, using ‘lxkaz_’ instead
[1] "Successfully load h5seurat:" "./SS200000135TL_D1.h5seurat"
Attaching package: ‘rhdf5’
The following object is masked from ‘package:hdf5r’:
h5version

[1] "rds time consuming: 11.011"
[1] "Start to saveRDS..."
[1] "Finished RDS."

Here comes the issue: when I try to visualize this .rds file with a simple Seurat::SpatialFeaturePlot (stereo.seq, features="n_genes_by_counts") + theme(legend.position="right") (taken from the spatial tutorial in Seurat), it gives me back this error

Error in SpatialPlot(object = object, features = features, images = images,  :
Could not find any spatial image information
What am I missing? Do you know how to see this spatial .rds file? Am I giving the wrong features parameter?
Thank you so much in advance for your help!

Sorry, our data files don't contain image, so the converted RDS will also have no image, I am not familiar with Seurat, I don't know whether SpatialPlot can be ran without image, I am so sorry.

@tanliwei-genomics-cn Thank you for your fast and kind reply!
Just a question: do you mean that this particular .h5ad file does not have an image or instead that all Stereo-Seq output files (also .gem and .gef) do not have an image?
Finally, could you kindly tell me where I can find .gem or .gef example files? I searched for them in the past days, but I found only .h5ad file from https://db.cngb.org/stomics/datasets/

Yes, Stereo-Seq files GEM and GEF are the source data of our analysis, currently, there are no any images in them, h5ad is converted from GEM or GEF and then RDS is converted from this h5ad, so the h5ad and rds also have no image.
You can get GEM and GEF example file from our network disk, going into Stereopy_Demo_Data/Demo_MouseBrain you can see what you want.

格式转换出现无法成功
我用SAW流程分析得到的gef
https://stereopy.readthedocs.io/en/latest/Tutorials/Format_Conversion.html
按照上述教程，先将gef文件转为h5ad，这一步可以成功
但是h5ad2rds报错，错误情况如下所示
Attaching SeuratObject
Seurat v4 was just loaded with SeuratObject v5; disabling v5 assays and
validation routines, and ensuring assays work in strict v3/v4
compatibility mode
Registered S3 method overwritten by 'SeuratDisk':
  method            from
  as.sparse.H5Group Seurat
Error in as.vector(x, "character") :
  cannot coerce type 'environment' to vector of type 'character'
Calls: <Anonymous> ... sprintf -> paste -> as.character -> as.character.default
Execution halted

Sorry, our data files don't contain image, so the converted RDS will also have no image, I am not familiar with Seurat, I don't know whether SpatialPlot can be ran without image, I am so sorry.

But why when I use stereomap to open GEF/GEM file, it can see image, cell, cluster and gene expression?


Wrap CreateIndexRequest mappings in _doc key in ml-commons

Description
Adds the _doc key wrapper around index mapping as required by CreateIndexRequest javadoc.
Related Issues
See also https://github.com/opensearch-project/OpenSearch/issues/14984
Testing Details
When the cluster has v1 templates with patterns matching the index, without the _doc wrapper, dynamic mappings are getting enabled for the index. From below, created_time is being created as long (dynamically picked) instead of timestamp type which is defined in the mapping definition.

With changes in this PR by adding _doc wrapper, even if cluster has v1 templates, indices are getting created with expected mappings.

Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Have you checked any difference by wrapping index mapping with _doc or not ?

@rbhavna please unlink the opensearch bug as there are other impacted plugins that need to track it

Have you checked any difference by wrapping index mapping with _doc or not ?

Yes when v1 template is added already, without _doc wrapper I see dynamic mappings are created. Will add details to PR description

Have you checked any difference by wrapping index mapping with _doc or not ?

@ylwu-amzn I've done testing with all combinations of v1 and v2 templates, with and without the _doc.   Adding _doc does not cause any additional problems and is, in fact, added by the REST API.
I've tested all combinations (with and without _doc) and with/without v1 and v2 templates. The only failure occurs with the v1 template and lack of _doc.
@owaiskazi19 and I walked through all code paths with both deprecated v1 and current v2 mappings.  In v2 case and with no v1 mapping, code automatically determines the _doc type at run time and thus these not impacted as they are processed in a list.  The only impact is with v1 (deprecated) index templates which do a map "merge" and because the template populates the _doc field, it is now "present" and the auto-populating that occurs when there's no _doc doesn't happen and the user mapping is lost.

@rbhavna just to be sure, can you also test with v2 templates both the scenario.

@rbhavna just to be sure, can you also test with v2 templates both the scenario? Also, looks like you attached the same screenshot in the description

Thanks @owaiskazi19 Updated the description. And will do more testing with v2 templates

Have you checked any difference by wrapping index mapping with _doc or not ?

@ylwu-amzn I've tested all combinations (with and without _doc) and with/without v1 and v2 templates. The only failure occurs with the v1 template and lack of _doc. Adding _doc does not cause any additional problems and is, in fact, added by the REST API.
@owaiskazi19 and I walked through all code paths with both deprecated v1 and current v2 mappings. In v2 case and with no v1 mapping, code automatically determines the _doc type at run time and thus these not impacted as they are processed in a list. The only impact is with v1 (deprecated) index templates which do a map "merge" and because the template populates the _doc field, it is now "present" and the auto-populating that occurs when there's no _doc doesn't happen and the user mapping is lost.

I am actually curious if we can have similar fix for update index as well. This fix will take care of any newly created domains from 2.15. For domains upgrading from previous versions with incorrect mappings to 2.15, do you think adding this _doc wrapper helps?

@rbhavna just to be sure, can you also test with v2 templates both the scenario? Also, looks like you attached the same screenshot in the description

@owaiskazi19 Tested the v2 template scenario. If cluster has v2 template that matches the index being created, irrespective of v1 template being present or not and with/without _doc wrapper in the code, user defined mappings are created. So the issue occurs on an index only when all the below three scenarios are met

there is no matching v2 template
there is a matching v1 template
there is no _doc wrapper explicitly added to create index request

Correct me if wrong @dbwiddis

I am actually curious if we can have similar fix for update index as well. This fix will take care of any newly created domains from 2.15. For domains upgrading from previous versions with incorrect mappings to 2.15, do you think adding this _doc wrapper helps?

If the domain had an incorrect mapping, it would have failed in the first place when ingesting docs to those indices. @dbwiddis wdyt?

The PR content can't match this commit message Wrap CreateIndexRequest mappings in _doc key in ml-commons

The PR content can't match this commit message Wrap CreateIndexRequest mappings in _doc key in ml-commons
how about add XContentType to fix v1 index template issue ?

let me change to a meaningful one

So the issue occurs on an index only when all the below three scenarios are met

there is no matching v2 template
there is a matching v1 template
there is no _doc wrapper explicitly added to create index request

Correct me if wrong @dbwiddis

Generally yes.  Some caveats:

the _doc wrapper is only required for the single-arg String json mapping.  If it adds on , XContentType.JSON it is ok.
the matching v1 template is often the template_default_settings which I think is how default number of shards/replicas/etc. was handled in ES 7.7 or earlier.


[System Tests]: Fix faulty system tests

This PR fixes the underlaying issues that causes the latest nightly buillds to fail.

Fixes Create a pod with environment variable that was checking
for an env property instead of environment in the definition
Fixes Create a pod with ephemeral volume that was using the old
layout to create an ephemeral volume

To test, use:

docker pull mesosphere/dcos-ui && \
docker run -it --rm --ipc=host \
  -e CLUSTER_URL=$OPEN_CLUSTER_URL  \
  -v `pwd`:/dcos-ui \
  mesosphere/dcos-ui dcos-system-test-driver \
  ./system-tests/driver-config/dev.sh

Pods and Jobs failed for me with the same error.
CypressError: cy.visit() failed trying to load:

http://<IP_ADDRESS>:4200/

We attempted to make an http request to this URL but the request failed without a response.

We received this error at the network level:

  > Error: ESOCKETTIMEDOUT

Common situations why this would fail:
  - you don't have internet access
  - you forgot to run / boot your web server
  - your web server isn't accessible
  - you have weird network configuration settings on your computer

The stack trace for this error is:

Error: ESOCKETTIMEDOUT
    at ClientRequest.<anonymous> (/tmp/tmpni4n550h/.cypress/Cypress/resources/app/node_modules/request/request.js:778:19)
    at ClientRequest.g (events.js:286:16)
    at emitNone (events.js:86:13)
    at ClientRequest.emit (events.js:185:7)
    at Socket.emitTimeout (_http_client.js:614:10)
    at Socket.g (events.js:286:16)
    at emitNone (events.js:86:13)
    at Socket.emit (events.js:185:7)
    at Socket._onTimeout (net.js:334:8)
    at tryOnTimeout (timers.js:232:11)
    at Timer.listOnTimeout (timers.js:202:5)

    at Object.cypressErr (http://localhost:45711/__cypress/static/js/cypress.js:5723:15)
    at Object.throwErr (http://localhost:45711/__cypress/static/js/cypress.js:5688:22)
    at Object.throwErrByPath (http://localhost:45711/__cypress/static/js/cypress.js:5715:21)
    at http://localhost:45711/__cypress/static/js/cypress.js:11249:41
    at visitFailedByErr (http://localhost:45711/__cypress/static/js/cypress.js:11095:24)
    at http://localhost:45711/__cypress/static/js/cypress.js:11248:24
    at tryCatcher (http://localhost:45711/__cypress/static/js/vendor.js:46486:31)
    at Promise._settlePromiseFromHandler (http://localhost:45711/__cypress/static/js/vendor.js:44621:31)
    at Promise._settlePromiseAt (http://localhost:45711/__cypress/static/js/vendor.js:44697:18)
    at Promise._settlePromises (http://localhost:45711/__cypress/static/js/vendor.js:44813:14)
    at Async._drainQueue (http://localhost:45711/__cypress/static/js/vendor.js:42180:16)
    at Async._drainQueues (http://localhost:45711/__cypress/static/js/vendor.js:42190:10)
    at MutationObserver.Async.drainQueues (http://localhost:45711/__cypress/static/js/vendor.js:42018:14)

I ran this test and got the following failing test:
✘ Services Pods Create a pod with environment variable
But @mlunoe noted that this is expected to fail, as stated in Slack: https://mesosphere.slack.com/archives/G0KN0QD6K/p1493743942103372
So let's merge it!


Upgrade to go 1.21

Changes

/kind

Fixes #

Release Note

Docs

Also the target branch will need to be release-v1.12

Ah sorry, nevermind ... :)


Update weaver-cats, weaver-cats-core, ... to 0.7.10

Updates

com.disneystreaming:weaver-cats
com.disneystreaming:weaver-cats-core
com.disneystreaming:weaver-core
com.disneystreaming:weaver-framework

from 0.7.9 to 0.7.10.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming" } ]

labels: test-library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #303.


[FEATURE] Pinecone: Retrieve X Chunks Before & Y Chunks after the Matching Chunk

In the Flowise Vectara node, in response to a query, Vectara similarity matches the query to a single sentence chunk in the VDB, and retrieves that sentence. It can also optionally retrieve x sentences before and y sentences after the matching sentence. This is really useful for bringing in context wider than the matching chunk.
Would it be possible to do something similar in Pinecone or Weaviate so that the matching chunk is retrieved together with a specified number of contiguous chunks before and after it?

this is a functionality offered by Vectara, I'm not sure if Pinecone or Weaviate offer similar functionality

I don't think P or W do this out-of-the-box. But something similar would be achievable using Langchain's Parent Document Retriever: https://python.langchain.com/docs/modules/data_connection/retrievers/parent_document_retriever. Any chance of that being added?


factorio: 1.1.74->1.1.76

Description of changes
Updated the URL, version number and sha256 of the Factorio game package non-experimental stable (aka alpha) to 1.176
Things done

Built on platform(s)

[* ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Superseded by https://github.com/NixOS/nixpkgs/pull/225257


Updated tag text

For the Committer

[ ] I made sure that the site looks great and functions perfectly live
[ ] I ran splell check
[ ] I'm ready for these changes to be made live

For the Reviewer
General Review

[ ] All changes/updates requested were intentionally changed or added (no extraneous file or partial updates)
[ ] The live rendered page behaves and looks like intended.
[ ] All links work as intended. (click every link to make sure that it takes the user to the expected place).
[ ] The markdown was rendered to HTML as intended. (Tables look right, code samples are gated properly).
[ ] Any style or CSS changes are tested on multiple different pages to ensure nothing unexpected broke or changed.
[ ] I proof-read the live site (gitbook serve) and there are no oblivious splelling or grammer misteaks.

Gitbook Specific

[ ] Any new documentation pages have been added to the SUMMARY.md file so they are rendered to HTML.
[ ] Any links to other pages within this documentation use relative links ([read more about ...](guides/voice/voicemail.md)).
[ ] Gitbook can install and build the documentation (gitbook install & gitbook build)

Code Specific

[ ] All code has been tested against the live API.
[ ] All code can be run without throwing errors or new warnings.
[ ] All code is formatted correctly and consistently (spaces, tabs).
[ ] All code is legible and idiomatic to the language.
[ ] All code uses sensical method, function, and variable names.
[ ] All code samples use the appropriate syntax highlighting.
[ ] Any examples re-use same phone numbers, uuids, variable names, etc... throughout (IE don't have something like {from: '+19191231234', to: '+19191231234'} unless it's meant to show the same phone number calling/texting itself ).

TL;DR

[ ] I did these things
[ ] I'm ready for these changes to be made live

 [Usabilla Feedback Item - Testing this out in the Node, the default is GET even when my application is set to POST. I could not get a callback to POST to my callback URL without setting the POST method explicitly.
I would also recommend stating explicitly that the tag parameter isn't stored and disappears after the callback, just for the sake of clarity.
Thanks!](https://trello.com/c/PQoWtCeG/269-usabilla-feedback-item-testing-this-out-in-the-node-the-default-is-get-even-when-my-application-is-set-to-post-i-could-not-get-a)

Preview Changes at:
http://bw-apdocs-specify-tag-stored-once.s3-website-us-east-1.amazonaws.com/


Version 3.0.0

This isn't really an issue but I didn't find anywhere else to put it. I was wondering when Version 3.0.0 of The Homebrewery was coming out. I was looking at the change logs and the last time there was an update was a little over a year ago. I know it takes awhile for these things but I just wanted to know if there is an approximation on ETA

Redirected to subreddit and closing.


Craete a to do list application

This PR has the following updates:

Display to-do items dynamically.
Add inputs to add a to-do item.
Add Delete icons and event listeners to remove a to-do item.
Add the capability to edit a to-do item.
Add a checkbox to select completed to-do items.
Add a clear all button to clear completed items.

Hi @sylvester-wamaya
You have done a good job so far! 👍

Overall, the code is well-structured and follows good practices. Minor improvements can be made to reduce code repetition, but it doesn't significantly impact the functionality or readability of the code.🫡
Highlights

Follows GitHub flows ✅
Descriptive PR title and summary ✅
Showed professionalism ✅
Used ES6, Webpack well. ✅
Used best practices in all categories ✅

Required Changes ♻

It is better to keep all your files inside the repository organized. Since the project requirement is to use ES6 standards, build your project using modules. it is best to keep all the .js module files inside a modules directory. It would seem more professional.

In your crud.js file, one improvement could be extracting the code block responsible for removing child elements from the list element into a separate reusable function to avoid repetition. (Please check comments below 👇).

Please consider this, as the submit method can be simplified by directly assigning the event listener to the todoInput element instead of adding an event listener inside the submit method. 😃

Inside your index.js file, the event listeners for the focus and blur events have similar code blocks. Consider refactoring the code to remove duplication by extracting the common logic into separate functions and reusing them. 🥺

Please consider removing the unused lines of code. The todo.defaultComplete() method is commented out. If it's not needed, it's better to remove it from the code. 🥺

Consider using arrow functions (() => { ... }) for event listeners to ensure the lexical this binding and improve code readability. 🙆♂

Optional suggestions

[OPTIONAL] You can go through your files again and organize the code to make it look cleaner, simpler to read, and more professional. ✨ You could add comments to your code to keep track of your code and identify which section play responsible for which part. 😉

Cheers and Happy coding!🍻💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Hi @sylvester-wamaya
You have done a good job so far! 👍

Overall, the code is well-structured and follows good practices. You did great following the suggestions from the previous review. There's nothing else to say, other than, it's time to merge it.🫡
Highlights

Follows GitHub flows ✅
Descriptive PR title and summary ✅
Showed professionalism ✅
Used ES6, Webpack well. ✅
Used best practices in all categories ✅

Status: Approved ✅
Optional suggestions

[OPTIONAL] You can go through your files again and organize the code to make it look cleaner, simpler to read, and more professional. ✨ You could add comments to your code to keep track of your code and identify which section play responsible for which part. 😉

Cheers and Happy coding!🍻💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.