Possible merger of Numbro and Numeral js?

as per @BenjaminVanRyseghem and @jamiter this is a place to discuss a possible merger of numbro and numeraljs.
Let's continue the discussion we left from #242 (since that's one is closed).
Numbro is basically a fork of Numeraljs so very likely we can merge this together assuming its a mutual decision.  I am not a collaborator nor a contributor of any of this two projects.  But I do vote we can have a collaborative effort in just one project so we can spend our energies towards one goal.  We are all climbing the same mountain anyway.

@adamwdraper Would be great to know your opinion on this.

I think it would be great to explore this.  I thought I was going to have more time for this again, but looks like I am working on a new company so I definitely could use some help.  @jamiter and @BenjaminVanRyseghem how would you like to proceed?

Would a suggestion be maybe moving numeral-js to numeral-js org?  And adding the maintainers of Numbro as admin.
2nd phase would be deprecation notice of Numbro pointing back to numeral-js.
cc @BenjaminVanRyseghem and @foretagsplatsen (not sure if I can mention an org)

as numbro as maintainer, a community, and some more progress, why not adding @adamwdraper as an admin to numbro, and join the effort there?
not wanting to sell numbro, but it looks to me that quite some people moved already from numeral-js to numbro :smile:

@adamwdraper, you did a really great job building this package and @BenjaminVanRyseghem's work to keep development going is very much appreciated. It would be great to see this moving forward as a combined effort!
I have to agree with @BenjaminVanRyseghem that the community moved on during the silence in this repo. The numbro package and documentation have come a long way. So I think the numbro repo should be the basis for future development. Maybe we can rename numbro to numeral and release a 3.0 version? Just a suggestion.
@thisguychris, an org sounds like a good plan!
I say all this mostly as a consumer, not a contributor or maintainer. (I contributed a little and thought of the numbro name.) I use it a lot though, so I'm really happy to see this happening.

as numbro as maintainer, a community, and some more progress, why not adding @adamwdraper as an admin to numbro, and join the effort there?

@BenjaminVanRyseghem not quite, If you check the contributors alone, the bulk of the code came from @adamwdraper.  He is still the no. 1 contributor of Numbro http://take.ms/YeAwk.
Which make sense since Numbro is a fork of numeral-js itself.  Also bulk of the code from Numbro are PR merges that came from Numeral-JS.   From the looks of it, Numbro owe it a lot to Numeral-js getting where it is right now.
If the author wants to maintain the name ~ Numeral-js.  I think everyone owes him at least a lot.   We should respect and at the least give him the final say when it comes to naming.
~~
Just an addendum to my suggestion.  There should be at least be two owners from both sides.  (Numeral-JS, and Numbro).  So everyone will have equal rights and will be able to look after each other.

@thisguychris I totally agree that most of the code comes from Numeral-js :smile:
But OTOH, numeral tends to now have the reputation of being dead for years...
Let wait for @adamwdraper answer on that :smile:

But OTOH, numeral tends to now have the reputation of being dead for years...

you have a point there @BenjaminVanRyseghem
However just looking at the NPM stats alone, shows Numeral-js is still more popular than Numbro?
https://nodei.co/npm/numbro.png?downloads=true
https://nodei.co/npm/numeral.png?downloads=true
Numbro ~ 41.4k downloads in the last month
Numeral-js- 384k downloads in the last month
Numeral-js may sound dead to you but the numbers don't lie.

@thisguychris being dead doesn't mean being not used :smile:
IE9 is dead for years, yet still massively used.

@BenjaminVanRyseghem sure but that's a context of consumers.  NPM stats solely come from developer usage and CI stats.
Let me ask you this question back to you.  How can you prove people think Numeral JS is dead for years and Numbro being the favored child?

My point here is the number one consumer of either libraries are developers such as ourselves.  The only think that can quantify that is NPM stats as far as I can tell.

look at the commits history, you will see that Numeral is dead.
There is this issue from 2 years ago.
I am not saying numbro is the favored child, but as long as I know, that's the only fork people are talking about here. See those comments also comment1 comment2

I never said people are not using numeral.
But clearly there is little to none progress made here over the last 2 years, while numbro is quite more active.

dead ~ no.  Hiatus maybe.  If there are a lot of people using it not dead.  It just means it's not just actively maintained.  Those are two different things.
Let us just agree that we have a different interpretation.
~
At the end of the day.  If people actively using Numeral-js more than Numbro.  From that logic alone.  Shouldn't Numbro yield and deprecate itself over Numeral-js.  40k users vs 384k.  Almost 10 times more user affected?

@thisguychris when I say dead, I mean not moving forward.
Whatever project (despite being used or not) making no progress is doomed to disappear.
So yes, Numeral is more download that numbro, but how long before people try to find something else?
Your last argument means "never fork a project, as you start with 0 follower"...
Anyway the users will be affected, as AFAIR, the APIs aren't 100% compatible anymore, so I tend to consider having to change a string in package.json not the biggest problem

So yes, Numeral is more download that Numbro, but how long before people try to find something else?

Now let us not talk about the future but what is present right now.   Humans are bad at predicting the future.  Just look at the "Back to the Future".  😜

Whatever project (despite being used or not) making no progress is doomed to disappear.
The author recently did a bunch of merges and responded positively about the merge.  So your argument is invalid because there was progress.  How can you say its doomed?

Your last argument means "never fork a project, as you start with 0 follower"...
I don't get your logic.  I just presented actual numbers from NPM.  Now you misinterpret by never fork a project?  How can that be me saying "never for a project".

I presented actual facts from actual stats.  You were presenting something ~ What if?  You can't predict the future, my friend.  If that's your source of truth so be it.
Here are my actual points, please don't try to change what I said.

@adamwdraper is still the no. 1 contributor of Numbro
Numeral-JS have more active users using it.
Just from my own opinion.  I think we owe @adamwdraper at least give him the final say for the name.

I am not talking about the future. Numeral has been "not moving" aka dead for years. Then @adamwdraper started moving forward again, just before saying he doesn't have enough time to continue this way. So this is not the future. This project has made very few to no progress over the last 2 years (not blaming at all, we all have to manage our time).
I didn't say Numeral is doomed, I said whatever project with no progress is doomed.
You say "let's deprecate numbro because it's less used that Numeral", then "let's deprecate the fork you just did, it's less used that the original project". How is that an argument?
I never said "what if". But feel free to think I did, for what I care.

1 .@adamwdraper is still the no. 1 contributor of Numbro

That's not correct. @adamwdraper owns most of the code, that's true. But he never contributed to Numbro.

Numeral-JS have more active users using it.

Numeral-JS has no active user as there is no activity. It's still more used that numbro though.
But it can't last (and no, that's not predicting the future...)

Sigh, really?  Please don't try to warp what I said.

That's not correct. @adamwdraper owns most of the code, that's true. But he never contributed to Numbro.

It's correct.  :D  Numbro is a fork.  He has actual commits to show.  Don't think of a second just changing the name makes all Adam's contribution disappear.  http://take.ms/E7wIu
Please don't try to play semantics here.  You know what I mean.  Bulk of the code came from @adamwdraper.   Whether he contribute after the name change of your fork or not is a different matter altogether.

Numeral-JS has no active user as there is no activity. It's still more used that numbro though.
But it can't last (and no, that's not predicting the future...)

What is your definition of an active user?
~~
I'm not trying to argue here.  If you want to continue to debate on what I said or not said.  Feel free to email me.

So yes, Numeral is more download that Numbro, but how long before people try to find something else?

Is this not you asking the future on what it holds?

"But it can't last (and no, that's not predicting the future...)"
You do know this is an oxymoron right?

Look, I will stop follow this discussion, and wait for @adamwdraper to ping me to see what we do

It's correct. :D Numbro is a fork. He has actual commits to show. Don't think of a second just changing the name makes all Adam's contribution disappear. http://take.ms/E7wIu

@thisguychris I think you're misunderstanding @BenjaminVanRyseghem here. Nobody wants to make @adamwdraper contributions disappear, this is not a question of pride or code ownership.
There's no need to imply such things, I find this allegation to be a bit insulting towards @BenjaminVanRyseghem, who worked hard and spent a lot of time improving the library and trying to move forward with it, and we all profit from his work.
Now let's wait for @adamwdraper's response to this thread, see what he wants to do, and discuss the future of Numbro/Numeral all together to find the brightest future possible for the project.

@NicolasPetton I think you're the one misunderstanding me too.  I am not implying anything.  That's how I read his statements.  If you have contribution then you are a contributor.   Please don't try to demonize me. Just because I oppose a maintainer's idea.

as numbro as maintainer, a community, and some more progress, why not adding @adamwdraper as an admin to numbro, and join the effort there?

I'm also not the one who started calling names.  So please don't make me the culprit by saying I'm insulting someone.

(I have better to do that feeding the trolls)

The play with words and semantics.  That's not what important here, to be honest.  So I find the whole thing argument to be absurd.  Hence I resigned.  Here's what I said:

I'm not trying to argue here. If you want to continue to debate on what I said or not said. Feel free to email me.

Lastly. If anyone thinks I'm insulting anyone here, I apologise. That's not my intention. I'm sorry if I came off that way. I genuinely want to have the best outcome here for everyone. I don't intend to anger anyone earlier and moving forward.

Thanks for your answer. Let's move forward together!

Ha, I thought this would be an easy and noncontroversial thing to do.  I planned on just adding the maintainers of Numbro to Numeral.

I also think Numeral has made some important strides forward in the way of modularity.  It has always been my intention to keep Numeral as a small library, and therefore I don't add every feature possible.  But recently I separated out formats from the core of the library, so now devs can include only the formats they are using.  This should also make it easier to port any Numbro features over.
Anyway, @jamiter and @BenjaminVanRyseghem, let me know if you want to join Numeral as I think that would be great, but if not then I guess we can just keep both projects going.

Let me know if you want to join Numeral as I think that would be great, but if not then I guess we can just keep both projects going.

We should definitely have just one repository for combined work. I understand the advantages of the numeral branding so we should keep that name. I would like to join as a contributor, but let me explain what I think is the current situation.

I thought this would be an easy and noncontroversial thing to do. I planned on just adding the maintainers of Numbro to Numeral.

It involves a little more work than that. Numeral has fallen behind severely in some areas. Take the locale key formats for example. They are still not official local formats, while they are all cleaned up in numbro. Like nl-BE instead of be-nl, which is a new issue in numeral, but fixed 2 years ago in numbro. Not even talking about the fixes in those files. Some merging of all the updates from the passed two years will take some time and we might lose some commit history.

I also think Numeral has made some important strides forward in the way of modularity.

That's great, but the work that has been done in numbro is more significant to be honest. Numbro isn't just a fork, it was the way forward, while this project was abandoned for 2 years. That's why I suggested numbro being the basis of the new numeral version. Maybe I'm over-emphasizing this, but theirs been a lot of work done by @BenjaminVanRyseghem and other contributors:

It has always been my intention to keep Numeral as a small library, and therefore I don't add every feature possible.

Let's keep going that route! Numbro hasn't added any significant features as far as I know, so that shouldn't prevent a merge.
@BenjaminVanRyseghem, are you ok with joining numeral and get updates from numbro back in numeral? (In whatever way)

I hope my last comment didn't stop the progress on this... We can still make this happen. The longer we wait the harder it's going to be to merge the two.

As someone trying to figure out which of these to incorporate into my project right now, I'd love to see them merged.

@skybondsor  I'm in the same position! :)  I'm probably going to go the Numbro route as that seems more mature right now.

I hate the name numbro, but would love to see the projects merged.

I'm sure this is never going to happen but merging back to Numeral makes way more sense. By the simple fact that when I search for a script to format numbers I found this package and numbro was no where to be seen.

How can the community help with the merge?

Any news?

@BenjaminVanRyseghem @jamiter what if @adamwdraper transferred ownership to a neutral organization numeral-js/numeral-js, and put all of you as admin? Would that be enough to drop the numbro name and move forward together?

numbro is now too far away from numeral to be merged.
Moreover, I don't really want it to be associated with a "dead" project.

@BenjaminVanRyseghem alright, thanks for the clarification.

@thisguychris I think this issue can be closed since this is definitely a no go.

@BenjaminVanRyseghem Numeral usage numbers are still high. And people looking for fixes in the numeral issues and PRs are not aware of numbro. @adamwdraper seems to be taking a long hiatus from the library. Would you consider taking over the numeral library and publishing numbro as v3?

I asked him to DM me more that a year ago. I will no insist more.
Sorry for people here, but this seem impossible. I invite every one willing to see things moving one to join the numbro ship.

And people looking for fixes in the numeral issues and PRs are not aware of numbro

I could go over all the PR/issues and tell to join numbro, but that's dirty. I am considering to go on PR that have been merged into numbro to tell people though.

@BenjaminVanRyseghem That sounds fair to me. I think posting on the issues and PRs is fair game though. People are opening PR's to Numeral.js fairly frequently and also opening issues and they could be contributing or not facing those issues with numbro!


v0.2.2 calls deprecated FuturesSession function

This message gets logged every second when using v0.2.2:
2018-12-03 18:21:19,927 [WARNING] FuturesSession (5262): `background_callback` is deprecated and will be removed in 1.0, use `hooks` instead

This was introduced in v0.9.9 of the requests-futures library:
https://github.com/ross/requests-futures/commit/b14916d82bfc31ad7ed01a14f2578f5638ce0d25

Should mention that I haven't tried with v0.3 yet due to #14 so can't say if it's still an issue


chore: stop using symlinks for jest config

Apparently, CodePipeline does not correctly read them out from GitHub,
and this results in text files containing the referent path. How
Windows-esque!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: de72cc4a89428cce98d62deb9c7dc612fe4729e2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


List jumps to selected item while scrolling

While details panel opened it is impossible to scroll down the workload list. It permanently jumps to selected item causing bad UX.
https://user-images.githubusercontent.com/9607060/220112991-7423bbb9-f53e-4ee5-b160-cbbc3409fe1e.mov

Happens only on frequent table re-rendering. It may happen if some deployment in the process of scailing by adding or removing many pods at once.
Relates to https://github.com/lensapp/lens/issues/6853

lens have a very bad UI
look at issue https://github.com/lensapp/lens/issues/7980


Performance issue on Macbook Pro M1

System information

Script can be found below
MacBook Pro M1 (Mac OS Big Sir (11.5))
TensorFlow installed from (source)
TensorFlow version (2.5 version) with Metal Support
Python version: 3.9
GPU model and memory: MacBook Pro M1 and 16 GB

Steps needed for installing Tensorflow with metal support.
https://developer.apple.com/metal/tensorflow-plugin/
I am trying to train a model on Macbook Pro M1, but the performance is so bad and the train doesn't work properly. It takes a ridiculously long time just for a single epoch.
Code needed for reproducing this behavior.
import tensorflow as tf
from tensorflow.keras.datasets import imdb
from tensorflow.keras.layers import Embedding, Dense, LSTM
from tensorflow.keras.losses import BinaryCrossentropy
from tensorflow.keras.models import Sequential
from tensorflow.keras.optimizers import Adam
from tensorflow.keras.preprocessing.sequence import pad_sequences

# Model configuration
additional_metrics = ['accuracy']
batch_size = 128
embedding_output_dims = 15
loss_function = BinaryCrossentropy()
max_sequence_length = 300
num_distinct_words = 5000
number_of_epochs = 5
optimizer = Adam()
validation_split = 0.20
verbosity_mode = 1

# Disable eager execution
tf.compat.v1.disable_eager_execution()

# Load dataset
(x_train, y_train), (x_test, y_test) = imdb.load_data(num_words=num_distinct_words)
print(x_train.shape)
print(x_test.shape)

# Pad all sequences
padded_inputs = pad_sequences(x_train, maxlen=max_sequence_length, value = 0.0) # 0.0 because it corresponds with <PAD>
padded_inputs_test = pad_sequences(x_test, maxlen=max_sequence_length, value = 0.0) # 0.0 because it corresponds with <PAD>

# Define the Keras model
model = Sequential()
model.add(Embedding(num_distinct_words, embedding_output_dims, input_length=max_sequence_length))
model.add(LSTM(10))
model.add(Dense(1, activation='sigmoid'))

# Compile the model
model.compile(optimizer=optimizer, loss=loss_function, metrics=additional_metrics)

# Give a summary
model.summary()

# Train the model
history = model.fit(padded_inputs, y_train, batch_size=batch_size, epochs=number_of_epochs, verbose=verbosity_mode, validation_split=validation_split)

# Test the model after training
test_results = model.evaluate(padded_inputs_test, y_test, verbose=False)
print(f'Test results - Loss: {test_results[0]} - Accuracy: {100*test_results[1]}%')

I have noticed this same problem with LSTM layers

Duplicate of #https://github.com/keras-team/keras/issues/14967

I wouldn't consider this as duplicate, because I could run the code of https://github.com/keras-team/keras/issues/14967 faster than LSTM.

@OriAlpha I ran your code in colab and I see the runtime as shown below. What is the runtime with M1.
Epoch 1/5
20000/20000 [==============================] - ETA: 0s - loss: 0.5699 - accuracy: 0.7099/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/training.py:2426: UserWarning: `Model.state_updates` will be removed in a future version. This property should not be used in TensorFlow 2.0, as `updates` are applied automatically.
  warnings.warn('`Model.state_updates` will be removed in a future version. '
20000/20000 [==============================] - 19s 936us/sample - loss: 0.5699 - accuracy: 0.7099 - val_loss: 0.4316 - val_accuracy: 0.8064
Epoch 2/5
20000/20000 [==============================] - 18s 901us/sample - loss: 0.3450 - accuracy: 0.8649 - val_loss: 0.3272 - val_accuracy: 0.8642
Epoch 3/5
20000/20000 [==============================] - 18s 899us/sample - loss: 0.2563 - accuracy: 0.9035 - val_loss: 0.3063 - val_accuracy: 0.8728
Epoch 4/5
20000/20000 [==============================] - 18s 908us/sample - loss: 0.2189 - accuracy: 0.9219 - val_loss: 0.3067 - val_accuracy: 0.8702
Epoch 5/5
20000/20000 [==============================] - 18s 895us/sample - loss: 0.1934 - accuracy: 0.9332 - val_loss: 0.3149 - val_accuracy: 0.8702
Test results - Loss: 0.3238884867286682 - Accuracy: 86.74399852752686%

Please check the gist here.
I think this is more related to M1 than TF as it was running in 18s each epoch on a cpu. I also ran it on my Mac and see similar results. Thanks!

I tried for few hours, due to slow training I only trained for 1 epochs, this is a log
Epoch 1/1
20000/20000 [==============================] - loss: 0.5489 - accuracy: 0.6923
--- 6894.8485770225524902 seconds ---

Just for one epoch, it takes around 2 hours that's a nightmare

@OriAlpha Thanks for quick response with test results.
I don't have access to M1 but will check with other team members. Thanks

You can use this link for GPU support for m1 mac. Steps needed for installing Tensorflow with metal support.
https://developer.apple.com/metal/tensorflow-plugin/

Unfortunately no one on our team has an M1 macbook to test this with. We suggest asking on the apple developer forum:
https://developer.apple.com/forums/tags/tensorflow-metal
I also notice you're disabling eager execution (tf.compat.v1.disable_eager_execution()), which means you're actually running legacy no-longer-maintained/supported codepaths. It's possible the tensorflow metal plugin was only designed to work well with TF2 / eager execution (though I can't say for sure)

Oh really, its bad news hope its fixed in future release

@OriAlpha As mentioned above this is more related to M1 than TensorFlow. I think it is better to post it in apple developer forum or Stackoverflow.
I am closing this issue. Please feel free to reopen if I am mistaken. Thanks!


Camel 19755

Description
Provides a component for the Thymeleaf template engine.
Target
main
Tracking
CAMEL-19755
Apache Camel coding standards and style

[ X] I checked that each commit in the pull request has a meaningful subject line and body.

[ X] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

I looked briefly over it and it seemed OK. Still, I think it would be good to have more reviewers looking at this one.

And, before I forget: thanks for your contribution!

Thanks for this, I'm planning to integrate the PR this week.

Merged. Thanks.

closing as merged


Move -detailed-exitcode flag or add option to disable it from automatically being added to the end of a plan task

I want to add extra commands to the end of my terraform plan script, but I get the Too many command line arguments error due to -detailed-exitcode being added to the end of the command.
Here's the example I'm working with:
      - task: TerraformTaskV4@4
        displayName: 'Terraform Plan'
        inputs:
          provider: 'aws'
          command: 'plan'
          commandOptions: '-out="test.tfplan" > tf_plan.txt'
          workingDirectory: '$(System.DefaultWorkingDirectory)/terraform'
          environmentServiceNameAWS: 'aws-service-name'

Change request
Either one of:

The -detailed-exitcode flag to be added automatically as the first flag before attaching the user specified commandOptions
There to be an inputProperty to disable the -detailed-exitcode flag

Actual behaviour
The command output looks like:
terraform plan -out="test.tfplan" > tf_plan.txt -detailed-exitcode

Expected behaviour
The command output to look like:
terraform plan -detailed-exitcode -out="test.tfplan" > tf_plan.txt

Or to be able to specify an input option so the task will look like:
      - task: TerraformTaskV4@4
        displayName: 'Terraform Plan'
        inputs:
          provider: 'aws'
          command: 'plan'
          commandOptions: '-out="test.tfplan" > tf_plan.txt'
          workingDirectory: '$(System.DefaultWorkingDirectory)/terraform'
          environmentServiceNameAWS: 'aws-service-name'
          detailedExitCode: false

Hi, why do you need to pipe output to tf_plan.txt?.  I need a bit more context to see if there is any other solution, like using the 'custom' command option.

closing this due to inactivity


How to execute multiple scripts

is it possible to execute 100 scripts in batch mode with time scheduled.

Please read the contributing guidelines; these types of questions are ill-suited for GitHub. Thanks!


[hevce] fix recon format for specific cases

Fix recons format for specific cases when input format differs
from the output. For example, for HEVCe VDENC
Y210 format is supported as input while the output is P010

How about RGB input format support

It is supported both for 8b & YUV420 and 8b & YUV444 as output


Feature: Neighbouring plots protect from attack.

Brief Description:

Adds 2 new config options, one which enables the feature and another
which sets how many neighbouring plots are required to protect a plot.
This feature is similar to the attack edge plots only, but further slows
attackers by requiring that they attack from a corner and chip away at a
town in order to get to their homeblock.

Changes:

The feature is off by default, but when it is enabled it will require 3
neighbouring plots to grant protection.

Relevant FlagWar Issue tickets:

Closes https://github.com/TownyAdvanced/FlagWar/issues/74.

[x] I have tested this pull request for defects on a server.

By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.

I can also build it and have @BunkerSlav test it out.

Either way is fine by me.

Bunker let me know they're away and unable to test for a while.

This has been tested with great success.


 Not sure if this is related to the change of icon or general icon padding though
(requires monitoring to be installed)
The icon in the button, far right

This is covered as part of the form validation rework


feat: Sessions are now extendable with additional info.

Refs:

https://github.com/jfyne/live/discussions/31

This PR has a breaking change:
The Session is no longer a struct with an ID string on it. It is now a map[string]interface{} which should allow people to store arbitrary data in it.
To replace calls to Session.ID I have added a helper function SessionID(s Session) string which will return the session ID.

:+1:


docs: Modify the style of Markdown files

Modified almost all markdown files, so that the document can pass most markdownlint checks.At the same time, the Chinese-English mixed part of the Chinese document has been formatted (adding spaces and using full-width symbols).
fix some syntax error, such as

0. Edit the testingPlugin variable to match your plugin meta. use 0 as sequence number
[Multi-Row Functions](./multi_row_functions.md unclosed parentheses

Hi, thank you for your contribution to our documentation. We appreciate your efforts in trying to improve the quality of the content.
Regarding the changes you made to the markdown rules, it's important to note that using the default configuration may lead to unforeseen issues. Our current setup involves using other tools to convert markdown files to HTML, and the existing configuration has been carefully discussed and tested to ensure compatibility and consistency throughout the project.
As such, we would not recommend making changes to the rules configuration without a thorough understanding of the potential impact on the overall formatting and presentation of the content. We kindly ask you to consider this before proposing any further modifications to the rules.
Once again, thank you for your contribution, and we look forward to working together to maintain and improve the quality of our documentation.

Will these modifications be accepted?

Thank you very much for the contribution. This is related to the document publish service for various products, so it is still under evaluation. We'll get back to you soon.


Copyedit IP Restriction plugin documentation

Where is the problem?
https://docs.konghq.com/hub/kong-inc/ip-restriction/
What happened?
The current language is not in alignment with our style guide and contains needless complexity. Additionally, there are some grammatical errors.
What did you expect to happen?
Clear, simple language in accordance with our style guide.
Also, $ does not appear before cURL request code samples.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

Closing due to all content being generated via YAML.


Syntax Highlighting Break in This Context

Steps to reproduce
The following line of code throws off the syntax highlighting in vim:
test=$((seq 10; echo "NA") | fzf)
The the two closing parentheses are highlighted in red in vim.  All following function declarations are magenta whereas previous function declarations are cyan. Replacing the parentheses with the (deprecated) back ticks corrects the highlighting. Bash runs the code in both formats without errors.
Expected behaviour
Correct syntax highlighting.
Operating system
Pop!_OS 20.04, i3-wm
Version of Vim
vim 8.1, st 0.8.4
Logs and stack traces
No response

I suppose you are talking about a shell filetype? Have you checked :h ft-sh-syntax?  In particular, you may want to test out :let g:is_bash=1 and/or :let g:sh_no_error=1. Oh, and please try with the latest Vim version. 8.1 is already quite old.

Can confirm with the latest Vim version.
Vim's syntax file interprets $(( as the beginning of an arithmetic expression, and hence can't find matching parentheses for the two closing parentheses. Therefore the error. If you add a white space after the first parenthesis, the syntax error goes away:
test=$( (seq 10; echo "NA") | fzf)

That did the trick. Thanks!

I assume this is in the shell syntax highlighting.  @cecamp


fix(core): select options pipe has wrong return types

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Looks like that the functions return types on elect Options Pipe have the wrong types
labelProp was (any)=> any , it's changed to string
valueProp was (any)=>boolean, it's changed to any
disabledProp was (any)=> string, it's changed to boolean
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please check if the PR fulfills these requirements
[X ] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
A unit test has been written for this change.
[X ] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[X ] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)
Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information:

Thank you @luizfbicalho!


[AERIE 1885] Add enabled/disabled to goal in sceduling specification

Tickets addressed: AERIE-1885
Review: By commit
Merge strategy: Merge (no squash)

Description
This PR adds the capability to toggle a scheduling goal within a scheduling specification as either enabled or disabled. A disabled scheduling goal is ignored during scheduling execution.
Verification
A test is added testSingleActivityPlanGoalDisabled() in SchedulingIntegrationTests.java. Also tested through the UI by adding three goals, disabling the second goal directly via the db, observed correct behavior.
Documentation
Two sentence have been added to https://github.com/NASA-AMMOS/aerie/wiki/Scheduling-Guide#specifying-the-order-of-goals noting the effect of enabled/disabled goals.
Future work
There have been discussions around how the ordering/priority of goals is implemented in the UI. These discussions are some ways off resulting in tickets, so for now there are no clear next steps resulting from this PR.

First off, thank you for your thoughtfulness!
I had some similar thoughts as well. I think the solution lies somewhere between option 1 and option 2. A refactoring maybe in order.
It would seem that PostgresSpecificationRepository#getSpecification should return the full specification, disabled goals and all. Previously, it made sense that the goals were being compiled in getSpecification because all goals in the specification were used in a scheduling execution. It also makes sense that the goal's compilation is orchestrated by the PostgresSpecificationRepository as the output type Specification only makes sense with the Java representation of goals. With the addition of enabled/disabled, we'd like to not compile disabled goals (as you identified).
Okay so I started writing thinking the answer lay between options 1 and 2, but now I'm veering towards option 2 as being the better solution. Right now the system has need to retrieve a Specification with only enabled goals, therefore not compiling disabled goals. If a future use case arises that needs the full Specification, we can refactor.
Again, thank you for your thoughtful response.

Previously, it made sense that the goals were being compiled in getSpecification because all goals in the specification were used in a scheduling execution. It also makes sense that the goal's compilation is orchestrated by the PostgresSpecificationRepository as the output type Specification only makes sense with the Java representation of goals.

Am I reading correctly that the database driver is also responsible for compiling scheduling TypeScript into Java rules? 🤔

The PostgresSpecificationRepository currently makes the call to compile the goals, with the Specification being returned to the Scheduler. PostgresSpecificationRepository

Am I reading correctly that the database driver is also responsible for compiling scheduling TypeScript into Java rules? 🤔

Yes, and I don't love it either 😅 Originally this decision was made because the Specification was defined in terms of the scheduler's Goal type, so in order to create a Specification object, you needed to turn the typescript strings into Goal objects. I would love to decouple that, but I'm having trouble envisioning exactly how.

In some ways, the Specification doesn't need to be concerned with the contents of the goals - it merely needs to refer to those goals (whether by id, or by reference to a java object, perhaps hidden behind an interface).
We could have the specification store a list of thunks, () -> Goal, (or, in what I think is a morally equivalent way, a list of GoalIds) which would allow us to defer compilation until after a specification has been created, without the specification needing to know that the goals are represented as typescript.

without the specification needing to know that the goals are represented as typescript.

:thinking: I think the domain model is a little thin here, specifically regarding what a "specification" is. Because the scheduler wants to work with concrete goals, and there's nowhere else between the scheduler and the repository to turn specifications into goals, the responsibility for performing this interpretation has fallen to the repository. (Let me know if I've misunderstood the domain here.)
It seems to me that the database should be returning the source-level data, and whoever receives it should then pass the specification on to some other component to turn the specification into goals, before then passing the goals on to whoever needed them. At a very abstract level, this could be done by dependency injection, giving whoever calls the repository a component that knows how to interpret specifications as goals.
Put slightly differently, it's not a Postgres abstraction that goals are stored as typescript -- it's a high-level design decision. Individual components may not need to know about this, but that decision does need to be located somewhere. Imagine, for the sake of probing the architecture, if we used the filesystem instead of Postgres to store TypeScript specifications -- would we really want to duplicate that code between multiple database drivers, or couple two drivers to the same post-processing concern? This is really the remit of the caller to interpret the stored data.


Testing labels

Testing a PR related to deprecating certain labels.

@techievivek the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

@techievivek the SuccessCoach label has been deprecated. Please use Concierge for issue triage. See https://stackoverflow.com/c/expensify/posts/tagged/950 for more details.

@techievivek the AutoAssignerSuccess label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.


Upgrade z2jh version

Brings in KubeSpawner 6 (changelog). Primary changes for us are:

https://github.com/jupyterhub/kubespawner/pull/650 to deal with https://github.com/2i2c-org/infrastructure/issues/1530
https://github.com/jupyterhub/kubespawner/pull/724, to allow us to build complex profileList UI (needed for our binderhub work)
https://github.com/jupyterhub/kubespawner/pull/642 which needs more escaping

OAuthenticator version does not change, as we were already using the version present in this z2jh version
JupyterHub 4.0 is used (changelog), from 3.1.1

User images should be eventually upgraded to JupyterHub 4.x, but not immediately necessary

Tested on:

staging.2i2c.cloud, all good.
staging.utoronto.2i2c.cloud, because it is using jupyter-server 1.0 explicitly. Works fine.
staging.jmte.2i2c.cloud, which helped us catch dask-gateway related escaping issues. There is still another issue to be sorted.
Tested GPU on staging.jmte.2i2c.cloud, worked ok

I tried on JMTE staging, and trying to launch the GPU instance leads to this error:
[E 2023-06-27 04:28:07.190 JupyterHub gen:630] Exception in Future <Task finished name='Task-1416' coro=<BaseHandler.spawn_single_user.<locals>.finish_user_spawn() done, defined at /usr/local/lib/python3.11/site-packages/jupyterhub/handlers/base.py:979> exception=KeyError('JUPYTERHUB_SERVICE_PREFIX')> after timeout
    Traceback (most recent call last):
      File "/usr/local/lib/python3.11/site-packages/tornado/gen.py", line 625, in error_callback
        future.result()
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/handlers/base.py", line 986, in finish_user_spawn
        await spawn_future
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/user.py", line 902, in spawn
        raise e
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/user.py", line 798, in spawn
        url = await gen.with_timeout(timedelta(seconds=spawner.start_timeout), f)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/jovyan/.local/lib/python3.11/site-packages/jupyterhub_configurator/mixins.py", line 45, in start
        return await super().start(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 2679, in _start
        pod = await self.get_pod_manifest()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 1996, in get_pod_manifest
        env=self._expand_all(self.get_env()),
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 1829, in _expand_all
        return {k: self._expand_all(v) for k, v in src.items()}
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 1829, in <dictcomp>
        return {k: self._expand_all(v) for k, v in src.items()}
                   ^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 1831, in _expand_all
        return self._expand_user_properties(src)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 1812, in _expand_user_properties
        rendered = template.format(
                   ^^^^^^^^^^^^^^^^
    KeyError: 'JUPYTERHUB_SERVICE_PREFIX'

While  non-GPU profiles seem to cause this error:
[E 2023-06-27 04:29:03.329 JupyterHub gen:630] Exception in Future <Task finished name='Task-41' coro=<BaseHandler.spawn_single_user.<locals>.finish_user_spawn() done, defined at /usr/local/lib/python3.11/site-packages/jupyterhub/handlers/base.py:979> exception=ValueError('Expected option test-of-latest-image-image for profile 16th-of-medium-0-25-4-cpu-1-16-gb, not found in posted form')> after timeout
    Traceback (most recent call last):
      File "/usr/local/lib/python3.11/site-packages/tornado/gen.py", line 625, in error_callback
        future.result()
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/handlers/base.py", line 986, in finish_user_spawn
        await spawn_future
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/user.py", line 902, in spawn
        raise e
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/user.py", line 798, in spawn
        url = await gen.with_timeout(timedelta(seconds=spawner.start_timeout), f)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/jovyan/.local/lib/python3.11/site-packages/jupyterhub_configurator/mixins.py", line 45, in start
        return await super().start(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 2635, in _start
        await self.load_user_options()
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 3133, in load_user_options
        await self._load_profile(selected_profile, selected_profile_user_options)
      File "/usr/local/lib/python3.11/site-packages/kubespawner/spawner.py", line 3056, in _load_profile
        raise ValueError(
    ValueError: Expected option test-of-latest-image-image for profile 16th-of-medium-0-25-4-cpu-1-16-gb, not found in posted form

Aha, https://github.com/2i2c-org/infrastructure/pull/2719/commits/cbeb7dede0e36e4d3c01ecd658cb5f280b835ff1 fixes a bunch of the escaping issues!!!

ok, the 'test-of-latest-image' is a leftover user_option only for my own user:
1|3||{"pod_name": "jupyter-yuvipanda", "namespace": "staging", "dns_name": "jupyter-yuvipanda.staging.svc.cluster.local"}|||2023-06-27 06:46:54.609155|{"profile": "16th-of-medium-0-25-4-cpu-1-16-gb", "image": "jmte", "test-of-latest-image-image": "jmte"}|

GPU tests worked out

I've reverted all the hubs I've tested back to master, to not break CI.

Ok, last issue sorted out and description updated!


Publish all docs for 0.11.2004 release.

Draft until #804 completes.

Docs Build status updates of commit 15f0f46:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/iqsharp-magic/chemistry.broombridge.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.encode.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.fh.add_terms.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.fh.load.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.inputstate.load.md
:warning:Warning
View
Details

api/iqsharp-magic/config.md
:warning:Warning
View
Details

api/iqsharp-magic/estimate.md
:warning:Warning
View
Details

api/iqsharp-magic/index.md
:warning:Warning
View
Details

api/iqsharp-magic/lsmagic.md
:warning:Warning
View
Details

api/iqsharp-magic/package.md
:warning:Warning
View
Details

api/iqsharp-magic/performance.md
:warning:Warning
View
Details

api/iqsharp-magic/simulate.md
:warning:Warning
View
Details

api/iqsharp-magic/toffoli.md
:warning:Warning
View
Details

api/iqsharp-magic/who.md
:warning:Warning
View
Details

api/iqsharp-magic/workspace.md
:warning:Warning
View
Details

articles/relnotes/index.md
:warning:Warning
View
Details

articles/quickstarts/search.md
:warning:Warning
View
Details

articles/quickstarts/qrng.md
:warning:Warning
View
Details

api/iqsharp-magic/toc.yml
:white_check_mark:Succeeded

api/qsharp/Microsoft.Quantum.AmplitudeAmplification.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Arithmetic.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Arrays.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Bitwise.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Canon.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Characterization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.JordanWigner.VQE.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.JordanWigner.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Convert.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Core.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Diagnostics.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Environment.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.ErrorCorrection.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Bitwise.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Convert.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Diagnostics.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Math.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Testing.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Intrinsic.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Logical.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.MachineLearning.Datasets.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.MachineLearning.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Math.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Measurement.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Optimization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Oracles.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Preparation.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Primitive.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Research.Characterization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Research.Chemistry.yml
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

api/iqsharp-magic/chemistry.broombridge.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.encode.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.fh.add_terms.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.fh.load.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.inputstate.load.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/config.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/estimate.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/index.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.

api/iqsharp-magic/lsmagic.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/package.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/performance.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/simulate.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/toffoli.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/who.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/workspace.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

articles/relnotes/index.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.install.standalone".

articles/quickstarts/search.md

Line 123: [Warning] The code snippet "~/quantum/samples/algorithms/simple-grover/host.py" could not be found.
Line 123: [Warning] The code snippet "~/quantum/samples/algorithms/simple-grover/Host.cs" could not be found.
Line 123: [Warning] The code snippet "~/quantum/samples/algorithms/simple-grover/Host.cs" could not be found.

articles/quickstarts/qrng.md

Line 99: [Warning] The code snippet "~/quantum/samples/getting-started/qrng/host.py" could not be found.
Line 99: [Warning] The code snippet "~/quantum/samples/getting-started/qrng/Host.cs" could not be found.
Line 99: [Warning] The code snippet "~/quantum/samples/getting-started/qrng/Host.cs" could not be found.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I'm not sure why this is raising warnings about code samples not being found, but I suspect it's because the docs build ran an incremental build. Let me try and force that.

Docs Build status updates of commit 6ed1b5b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/iqsharp-magic/chemistry.broombridge.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.encode.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.fh.add_terms.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.fh.load.md
:warning:Warning
View
Details

api/iqsharp-magic/chemistry.inputstate.load.md
:warning:Warning
View
Details

api/iqsharp-magic/config.md
:warning:Warning
View
Details

api/iqsharp-magic/estimate.md
:warning:Warning
View
Details

api/iqsharp-magic/index.md
:warning:Warning
View
Details

api/iqsharp-magic/lsmagic.md
:warning:Warning
View
Details

api/iqsharp-magic/package.md
:warning:Warning
View
Details

api/iqsharp-magic/performance.md
:warning:Warning
View
Details

api/iqsharp-magic/simulate.md
:warning:Warning
View
Details

api/iqsharp-magic/toffoli.md
:warning:Warning
View
Details

api/iqsharp-magic/who.md
:warning:Warning
View
Details

api/iqsharp-magic/workspace.md
:warning:Warning
View
Details

.github/workflows/check-samples-branch.yml
:white_check_mark:Succeeded

.vscode/settings.json
:white_check_mark:Succeeded

api/iqsharp-magic/toc.yml
:white_check_mark:Succeeded

api/qsharp/Microsoft.Quantum.AmplitudeAmplification.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Arithmetic.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Arrays.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Bitwise.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Canon.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Characterization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.JordanWigner.VQE.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.JordanWigner.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Chemistry.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Convert.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Core.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Diagnostics.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Environment.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.ErrorCorrection.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Bitwise.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Convert.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Diagnostics.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Math.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Extensions.Testing.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Intrinsic.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Logical.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.MachineLearning.Datasets.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.MachineLearning.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Math.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Measurement.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Optimization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Oracles.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Preparation.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Primitive.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Research.Characterization.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Research.Chemistry.yml
:white_check_mark:Succeeded
View

api/qsharp/Microsoft.Quantum.Research.RandomWalkPhaseEstimation.yml
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

api/iqsharp-magic/chemistry.broombridge.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.encode.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.fh.add_terms.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.fh.load.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/chemistry.inputstate.load.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/config.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/estimate.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/index.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.

api/iqsharp-magic/lsmagic.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/package.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/performance.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/simulate.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/toffoli.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/who.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

api/iqsharp-magic/workspace.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Invalid value for ms.date: '2020-04-29'. Must be a date in format MM/DD/YYYY, no more than 30 days from today.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

The only warnings are about the new IQ# docs, which we've confirmed still render correctly. While we should fix those warnings, I think we're good to defer that for now. Thanks!


UserLocation with renderMode native does not show up on iOS

UserLocation with renderMode "native" seems to not work (the user location is not being shown, it does work with renderMode "normal") on iOS simulator (xCode Version 13.3.1 on Macbook Pro M1) + device (iPhone 13 mini) using "@rnmapbox/maps": "rnmapbox/maps#main"
Example:
import React from "react";
import MapboxGL from "@rnmapbox/maps";

export const BugIOSUserLocation = () => {
  return (
    <MapboxGL.MapView style={{ flex: 1 }} tintColor={"red"}>
      <MapboxGL.Camera />
      <MapboxGL.UserLocation
        renderMode="native"
        showsUserHeadingIndicator={true}
      />
    </MapboxGL.MapView>
  );
};

Are you using v10? I noticed this as well. Neither of the native rendering modes on iOS show the user location marker. Looking through the source files it doesn't appear that these have been built out yet for v10 but I could be mistaken.

After updating to latest Installing rnmapbox-maps 10.0.0-beta.22 (was 10.0.0-beta.18), UserLocation is no longer visible on iOS simulator

This seems to work for me just fine with latest version - beta.43


Limit channel name size

Summary
Limit channel name size on push proxy to avoid potential "Payload too large" errors.
Ticket Link
NONE

/update-branch


RFC: list required / optional arch features and clarify policy

We need to identify optional arch features and decide which ones are truly required for acceptance in the tree.
First thing, let's try to put together a list of all these configs or kernel features which may (at least in some cases) require support in arch/ code. This is what I came up with so far, please amend as necessary:

CONFIG_HAS_DTS
CONFIG_HW_STACK_PROTECTION
CONFIG_USERSPACE
CONFIG_DYNAMIC_INTERRUPTS
CONFIG_STACK_SENTINEL
CONFIG_FLOAT / CONFIG_FP_SHARING
CONFIG_IRQ_OFFLOAD
CONFIG_INIT_STACKS and stack_analyze() (doesn't work on ARC/ARMv8 when examining active thread)
CONFIG_STACK_POINTER_RANDOM
CONFIG_THREAD_MONITOR
CONFIG_EXECUTION_BENCHMARKING (can we merge with CONFIG_TRACING?)
CONFIG_THREAD_USERSPACE_LOCAL_DATA (should be renamed to thread-local storage)
CONFIG_TRACING
CONFIG_SYS_POWER_MANAGEMENT (and related configs)
CONFIG_EXCEPTION_STACK_TRACE (feasibility depends on arch, ARM is very hard for example)
CONFIG_BOOT_TIME_MEASUREMENT (can we merge with CONFIG_TRACING?)
CONFIG_COVERAGE_GCOV (XIP considerations for extra gcov sections)
CONFIG_STACK_CANARIES (may or may not require arch support)
CONFIG_SMP
Z_ARCH_EXCEPT() (no associated config, see include/kernel.h)
z_arch_system_halt() (default __weak version just spins with IRQs locked)
z_arch_esf_t implemented and passed to z_fatal_error() with appropriate data populated
CONFIG_UART_INTERRUPT_DRIVEN (for debug console device)
CONFIG_TICKLESS_KERNEL (timer driver considerations)
build system "west flash" or "make flash"
build system "west debug" or "make debug"
switch() vs swap() -- seriously, why do we have 2 designs for this? we should standardize on switch() unless someone can explain why we have to have 2 designs around

Once we have this full list, determine what is the minimum set (assuming HW support) that has to be implemented before an arch port can be merged into the tree. And then review tests to ensure that these are all being tested, in particular clear out whitelists.

truly required for acceptance in the tree.

One side comment here: I think it would be more constructive to think it as: What features should have more focus on their documentation, and having a clear API, and appropriate tests, to ensure whoever wants to contribute them, can implement it with a reasonable effort.

What features should have more focus on their documentation, and having a clear API, and appropriate tests, to ensure whoever wants to contribute them, can implement it with a reasonable effort.

No, that's really not what I'm getting at here at all.
I open this because I keep getting surprised on what features are missing from our arch ports. I want to set a minimum standard of features (it will not be all of what's named above) that are minimum criteria for the arch port to go in. Period.
If you think some features have insufficient documentation, or have badly designed APIs, or have insufficient tests, go file bugs on them specifically.

CONFIG_INIT_STACKS and stack_analyze() (doesn't work on ARC/ARMv8 when examining active thread)

@andrewboie why is this not working for ARMv8-M? Is there any issue reported? :)

@andrewboie  perhaps the following too?
ATOMIC OPERATIONS
USE_SWITCH
XIP

DYNAMIC_DIRECT_INTERRUPTS, after #21516 is merged


Make Variables discard playmode changes

this week i was working on small project and we used the variables of unity-atoms pretty extensively.
And one of the more annoying this is, that scriptable objects keep playmode changes in the editor.
So you have to write scripts that setup your variables to start values.
I propose to make the Variable classes Implement ISerializationCallbackReceiver like shown here: https://unity3d.com/de/how-to/architect-with-scriptable-objects (the 3rd image)

could be implemented like this: https://github.com/soraphis/unity-atoms/commit/f95307c8068dde0a6994eaf0cec4d67761f01ad4

This is a great feature and something that I've been thinking about / toying around with myself. However, I think there are different use cases, sometimes you want the value to persist between scenes and plays and sometimes you want it to be reseted to an initial value. Therefore, I propose that the ScriptableObjectVariable should also contain a ScriptableObjectVariableBase called initalValue (this will need to be part of the generic signature in order to be serialized properly). If the constant (ScriptableObjectVariableBase) is set we set in OnAfterDeserialize, otherwise we don't. Would gladly accept a pull request (but I might also try to implement this right away - so check if it has already been implemented before doing a pull request).
Side note: when you want to reset something at the start of a scene you can use OnStartHook combined with SetVariable.

sometimes you want the value to persist between scenes and plays

this is a dangerous thing! while you might want it for in-editor features this will never happen in builds. because of that I highly recommend implementing a reset system.
(also: in-editor features will probably not use unity-atoms)

Therefore, I propose that the ScriptableObjectVariable should also contain a ScriptableObjectVariableBase called initalValue (this will need to be part of the generic signature in order to be serialized properly)

I'd argue against that, because: you'd need for nearly all variables an additional variable for resets. this reset variable would have its own description fields, old values, events, and so on
while all you actually want is: a boolean flag whether or not you wanna reset, with a default on true. (because really, I can't imagine a case where you want to store something inbetween editor sessions)

Side note: when you want to reset something at the start of a scene you can use OnStartHook combined with SetVariable.

which will introduce WAY MORE assets than i actually need (it doubles the amount).
in the game we made the other week, we had around ~10!? unity-atom variables. that would be 20 + the OnStartHook.

while you might want it for in-editor features this will never happen in builds.
Risking sounding like a noob. I have been looking into this before, but I remembered that it actually was saved between plays in build. Just tried it, and yes you are right. Thanks!
I'd argue against that, because: you'd need for nearly all variables an additional variable for resets. this reset variable would have its own description fields, old values, events, and so on
So because of the above reasoning I agree with you 👍

Maybe it would be great though to be able to persist state between plays, by serializing to json / xml for example. What do you think? Should I create a new issue for that?

while all you actually want is: a boolean flag whether or not you wanna reset, with a default on true. (because really, I can't imagine a case where you want to store something inbetween editor sessions)
On a second note, yes a boolean would probably be much easier and will introduce way less asset files (a good thing).

Question, do you know if OnAfterDeserialize and OnBeforeSerialize are called when switching between scenes? Is it different when running in the editor vs in an actual build?

Maybe it would be great though to be able to persist state between plays, by serializing to json / xml for example. What do you think? Should I create a new issue for that?

for me, that is the job of a savegame system. In the game project I worked the other week i also have a savegame system. I read values from atom-variables and on load i feed them back in.
Serializable variables - for me - are mainly a way to provide vales across multiple scenes (or across multiple prefabs).

Question, do you know if OnAfterDeserialize and OnBeforeSerialize are called when switching between scenes? Is it different when running in the editor vs in an actual build?

In the editor: they are called when entering playmode. they are not called for scene changes (neither playmode nor edit mode). they are called when unity recompiles and maybe on a few other ocassions.
in the build: "OnAfterDeserialize" is called once, when the game starts.
(i just tested that with a debugger)
In my project I'm currently using my fork of unity atoms, and I have not found a problem with OnAfterDeserialize yet. and it reduced "initialization code" - code lines where i just made sure that on game start the atom-variables have a specific value.

Implemented in 06eab90bb184d9cebb6d39336c7dd4bb391407e1 and fixes in ed574215ad4e09a7cc9e6b494da9691d26786e37


Importing PuTTY sessions

Description of the new feature/enhancement
I wonder if there's a chance for (or a way if it is there and I can't simply find it ;)) making import and later sync for PuTTY sessions. I do know that PuTTY can't be used inside Terminal but it would be great if we could simply import and manage sessions instead of making all the entries.
Proposed technical implementation details (optional)
There are tools that wraps putty (like SuperPuTTY for example) and they have a way to import sessions by opening window for that.
What I'd like to get is to have new option when adding new profile. That could be a button that would open window with a list of PuTTY sessions where I could choose which one I'd like to import as a Terminal profiles.
As a bonus feature it would be great to have checkbox for syncing all the profiles so if I'll get a new one in putty it will show up in Terminal as well.
Cherry on top would be to have auto sync for all the imported profiles to stay up to date with Putty but at least manual sync would be enough.
Is that even possible to achieve?

Putty sessions are stored at HKCU\SOFTWARE\SimonTatham\PuTTY\Sessions.
From there you can extract protocol, username, hostname, portnumber but many of the values are protocol-specific (e.g. PublicKeyFile).
Most importantly, you need to map protocol to a specific command/tool for Terminal to call (with a specific argument list).

You could try creating a profile that calls putty.exe and if putty allows commandline parameters for choosing a particular saved session config, you could add that at the end. Otherwise, I'd suggest creating a profile using ssh.exe from Win32-OpenSSH and define the username@hostname there.

A Windows Terminal profile that calls putty.exe would be inconvenient to use because PuTTY opens its own window instead of using the console.

My suggestion was more on how to make it easier to import into Terminal. I know how can I do this manually (it's even in FAQ :P) but it would be so much more convenient if there was built-in tool for that (especially for lazy people ;)). And one of the reason for that is the fact that you can't use putty.exe inside Terminal because it will open new window, as @KalleOlaviNiemitalo also pointed out.

This is a fun idea for a dynamic profile generator. Thanks!

Notes for someone who may be interested in working on it: putty ships a command-line SSH client of its own, plink, which is aware of putty profiles. That may be even easier than trying to gin up a ssh.exe command line.

When I last tried running plink.exe in Windows Terminal, I could not get the VT sequences to work. I don't remember whether the problem was in input or in output. Anyway, plink is not intended for interactive use.

Anyway, plink is not intended for interactive use.

After 30 seconds of experimentation - yea that's the impression I get. Arrow keys definitely didn't work, and Ctrl+C did instantly kill plink, instead of get sent to the client. Output seemed generally okay, but that's probably because we're opting them in to VT processing by default for output. (I idly wonder if this would work if we also opted them in to vt input by default)
That being said, the sessions are all listed in Computer\HKEY_CURRENT_USER\Software\SimonTatham\PuTTY\Sessions, so enumerating them is easy enough. It's just the input thing that seems wonky.

Ah, that's a fair point. Thanks!

I realize we're all used to PuTTY, but ssh has been part of windows for a while now. You can definitely get the same effect with Ctrl+C working if you use ssh instead of plink.
The command line I use is
C:\Windows\System32\OpenSSH\ssh.exe pathomas@waffles

I mean, yes, we're all aware that you can use ssh.exe instead. The whole point of this thread is to make it easier for someone to migrate the settings that they have already in putty directly to Windows Terminal profiles 😝
Using ssh.exe as the client commandline definitely would work, but then we'd need to manually reconstruct the rest of the ssh commandline from the putty registry settings, where plink doesn't have that issue. I'm sure there's a happy medium between those two.

As this is not yet fixed I've got a small workaround for this:
https://github.com/Kipjr/powershell/blob/main/Putty2WinTerminal.ps1
It parses the Putty configuration and adds it to Settings.json

(I'm tagging this for discussion because I never saw the above comment till today, and I want to circle back on it once I'm off paternity leave)

That's a slick script, and looks like it does most of what people would want. We're trying to draw the right balance here between what dynamic profile generators to include in-box, and which to exclude. If we add too many, then people's settings get polluted with quite a few dynamic profiles, and our experience for configuring those today is... less than great.
The code in #13763 might help with this, for letting floks nest profiles in the dropdown easily, but that's not a good enough solution.
I think (at the moment), I'd rather this stay an external tool. Something folks can easily run and synthesize profiles for themselves, but not forced on everyone by default. We've got near-ish term plans for dynamic profiles as extensions, and this would make a GREAT test case for that. In fact, I'm putting it into the planning timetable as our prototypical example of such an extension.

While it is not integrated in WT, you can try this solution: https://github.com/SailorMax/psh

While it is not integrated in WT, you can try this solution: https://github.com/SailorMax/psh

Is it possible to use it for  Serial Connections?

Is it possible to use it for Serial Connections?

Currently only ssh. I never used Serial Connections.
Can you check plink.exe? I'll try to use it for Serial Connections if it has acceptable functionality.

Is it possible to use it for Serial Connections?

Currently only ssh. I never used Serial Connections. Can you check plink.exe? I'll try to use it for Serial Connections if it has acceptable functionality.

I am not able to Console Cisco Switch. It seems Putty is standalone GUI, thus it might be not possible to make serial connection through WT.  I am looking a way to make Serial Connection through/within Windows Terminal.

Putty is standalone GUI, thus it might be not possible to make serial connection through WT

To work in WT you can use plink.exe from putty's package (plink -serial COM1 -sercfg 115200,n,8,1,N).
Today I also added support this type of putty's sessions in psh (psh session_name or psh COM1:115200,n,8,1,N) [it work via plink!]

Putty is standalone GUI, thus it might be not possible to make serial connection through WT

To work in WT you can use plink.exe from putty's package (plink -serial COM1 -sercfg 115200,n,8,1,N). Today I also added support this type of putty's sessions in psh (psh session_name or psh COM1:115200,n,8,1,N) [it work via plink!]

Interesting. Plink is working, however I couldn't make psh, and that's fine. My goal is to be able to manage/do my job all in WT.


Add accentTextTheme, accentIconTheme

First run at a fix for #6796.

LGTM provided you complete the work ;-)

closes #6796


Add image margin

As title, there is margin or padding in most of tags (p, h1, h2) , but not in img.
It result in no spacing between text and image.

will you be able to provide a screenshot ?

For example:
# Introduction

texttext

![eee](https://dataduppedings.no/subcube/Colour_Gradients/Yellow-Green_256x256.png)

....

texttext

....

![eee](https://visualidentity.columbia.edu/sites/default/files/styles/cu_crop/public/content/Colors/pms290c.jpg?)

![aaa](https://bfmbrainfall.files.wordpress.com/2015/10/red5.jpg?w=200&h=200&crop=1)

The  API is the primary way to get data out of  our platform.

In RapiDoc, it will show

and in VSCode preview

thanks, out of curiosity, which VS code plugin are you using to show RapiDoc preview ? we do have internal VSCode and Confluence plugins for RapiDoc, but I would rather like to contribute to some existing plugin as coz our internal plugins arent open-source

Its built-in feature in VSCode.
Here's a set of example extensions that customize the preview.

I see,
you are previewing just the markdown,
I thought you are previewing the OpenAPI Spec itself using a plugin specifically built for OpenAPI

Well we ran provide image margin suggestion with our internal user base. Majority voted to keep things unchanged as it gives possibilities to join images and also separate them if needed. The control remains with the user rather than forcing it on them
This is also in compliant with various markdown engines and renderer
I have updated our markdown example to show various layout possibilities with images to clear things up
as shown below

If you need a line gap between the image and the text then you may do that in the markdown


Redundant configuration usage activation deprecation warning with Kotlin feature variant source set

Expected Behavior
A Kotlin project declaring a feature variant using a source set other than "main" should not emit a redundant configuration usage activation deprecation warning on running ./gradlew --warning-mode=all build.
Current Behavior
A warning like the following is emitted:
> Configure project :
The resolvable usage is already allowed on configuration ':fooSupportRuntimeClasspath'. This behavior has been deprecated. This behavior is scheduled to be removed in Gradle 9.0. Remove the call to setCanBeResolved(true), it has no effect. Consult the upgrading guide for further information: https://docs.gradle.org/8.2/userguide/upgrading_version_8.html#redundant_configuration_usage_activation

Context (optional)
No response
Steps to Reproduce
Run ./gradlew --warning-mode=all build on the following project: issue-example.zip.
Gradle version
8.2
Build scan URL (optional)
No response
Your Environment (optional)
No response

Facing similar issue with Kotlin plugin and a custom test suite starting with test....
Here is the minimal build configuration:
plugins {
    kotlin("jvm") version "1.9.0"
}

testing {
    suites {
        val testInregtation by registering(JvmTestSuite::class) {
        }
    }
}

./gradlew --warning-mode all emits:
The resolvable usage is already allowed on configuration ':lib:testInregtationRuntimeClasspath'. This behavior has been deprecated. This behavior is scheduled to be removed in Gradle 9.0. Remove the call to setCanBeResolved(true), it has no effect. Consult the upgrading guide for further information: https://docs.gradle.org/8.2/userguide/upgrading_version_8.html#redundant_configuration_usage_activation
        at Build_gradle$1$1.execute(build.gradle.kts:7)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

At the same time if you rename custom test suite from testInregtation to integrationTest, the warning is gone.

As part of evolving Gradle's Configuration API, we soon want to make the allowed usage of a Configuration immutable upon creation.
As a small step toward this, Gradle 8.2.x emits deprecation warnings when a configuration has its usage redundantly set to the current value.  For example, if a configuration is already consumable, setting consumable = true would warn.  This might be harmless, but is likely a code smell that means work will be necessary soon, prior to when configuration usages become immutable.
We special cased skipping this warning for several common scenarios involving widely used plugins in the code here as a temporary measure to avoid spamming warning messages to users who can't address them.  However we don't and can't cover scenarios involving additional SourceSets like this issue reports, since the names can't be known in advance.
This situation has been brought to the attention of the Kotlin team: https://youtrack.jetbrains.com/issue/KT-60879/Deprecation-warning-on-trying-to-configure-Configuration-multiple-times, but is not a high priority.
We are also currently thinking about other ways to communicate recommendation information other than warnings, and this message in particular is something we might consider changing in near future versions of Gradle.

Thanks for the follow up.

We are also currently thinking about other ways to communicate recommendation information other than warnings, and this message in particular is something we might consider changing in near future versions of Gradle.

Perhaps Gradle needs a --pedantic mode where it nags about such code-smell issues which are not in and of themselves problems.

I'm seeing such warning when following an example from the documentation on how to create a feature variant with a source set:
sourceSets {
    api { // Warning: The resolvable usage is already allowed on configuration ...
        java {
            srcDir "src/api/kotlin"
        }
    }
}

java {
    registerFeature("api") {
        usingSourceSet(sourceSets.api)
    }
}


Support ARM64 in Ubuntu Focal

What would you like to be added:
Support for ARM64 in Ubuntu images
Why is this needed:
With the rise of usage of Graviton processors Ubuntu images for ARM is required.

As a side note, Canonical already provides ARM64 Ubuntu EKS optimized images
https://cloud-images.ubuntu.com/docs/aws/eks/


Fix client side warn handling

For some reason warning logs were not handled properly like in the server.

Issue labeling / autotriage fail xd xd

Issue labeling / autotriage fail xd xd

Fixed lint


Got "indexError:list index out of range" after one successful excution

I got an error after successfully generating gif the first time.
It can run successfully once and will get error aftermath, so I have to restart comfyui to generate next animation.
I have set the batch size to 16 and the KSampler worked fine.
below is the output:
got prompt
[AnimateDiff] - INFO - Loading motion module mm_sd_v15_v2.ckpt
[AnimateDiff] - INFO - Converting motion module to fp16.
model_type EPS
adm 0
Using xformers attention in VAE
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
Using xformers attention in VAE
got prompt
missing {'cond_stage_model.text_projection', 'cond_stage_model.logit_scale'}
left over keys: dict_keys(['alphas_cumprod', 'alphas_cumprod_prev', 'betas', 'cond_stage_model.transformer.text_model.embeddings.position_ids', 'log_one_minus_alphas_cumprod', 'model_ema.decay', 'model_ema.num_updates', 'posterior_log_variance_clipped', 'posterior_mean_coef1', 'posterior_mean_coef2', 'posterior_variance', 'sqrt_alphas_cumprod', 'sqrt_one_minus_alphas_cumprod', 'sqrt_recip_alphas_cumprod', 'sqrt_recipm1_alphas_cumprod'])
Requested to load SD1ClipModel
Loading 1 new model
[AnimateDiff] - INFO - Injecting motion module with method default.
E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch_utils.py:776: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
return self.fget.get(instance, owner)()
Requested to load BaseModel
Loading 1 new model
100%
E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\model_base.py:48: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
self.register_buffer('betas', torch.tensor(betas, dtype=torch.float32))
E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\model_base.py:49: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
self.register_buffer('alphas_cumprod', torch.tensor(alphas_cumprod, dtype=torch.float32))
[AnimateDiff] - INFO - Ejecting motion module with method default.
Prompt executed in 315.94 seconds
[AnimateDiff] - INFO - Injecting motion module with method default.
Requested to load BaseModel
Loading 1 new model
loading in lowvram mode 1041.7423362731934
[AnimateDiff] - INFO - Ejecting motion module with method default.
ERROR:root:!!! Exception during processing !!!
ERROR:root:Traceback (most recent call last):
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-animatediff\animatediff\sampler.py", line 295, in animatediff_sample
return super().sample(
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1237, in sample
return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1207, in common_ksampler
samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\sample.py", line 90, in sample
real_model, positive_copy, negative_copy, noise_mask, models = prepare_sampling(model, noise.shape, positive, negative, noise_mask)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\sample.py", line 81, in prepare_sampling
comfy.model_management.load_models_gpu([model] + models, comfy.model_management.batch_area_memory(noise_shape[0] * noise_shape[2] * noise_shape[3]) + inference_memory)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\model_management.py", line 402, in load_models_gpu
cur_loaded_model = loaded_model.model_load(lowvram_model_memory)
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\model_management.py", line 293, in model_load
device_map = accelerate.infer_auto_device_map(self.real_model, max_memory={0: "{}MiB".format(lowvram_model_memory // (1024 * 1024)), "cpu": "16GiB"})
File "E:\comfyUI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\python_embeded\lib\site-packages\accelerate\utils\modeling.py", line 958, in infer_auto_device_map
tied_module_index = [i for i, (n, _) in enumerate(modules_to_treat) if n in tied_param][0]
IndexError: list index out of range
Prompt executed in 4.20 seconds

Hmm, this look the same with #34. Can you observe the VRAM (via Task Manager or similar tools) to see if VRAM is released after the first gen?

Yes, it dropped after generation but the issue still occurred. I have 4 gb dedicated gpu memory and it dropped from nearly full to 1.6gb. I know very little about how it works but  I don't need to remove modules from memory on a1111, which I'm using more often.
If it is because of memory, how to get rid of that?

Hmm, this look the same with #34. Can you observe the VRAM (via Task Manager or similar tools) to see if VRAM is released after the first gen?

Yes, it dropped after generation but the issue still occurred. I have 4 gb dedicated gpu memory and it dropped from nearly full to 1.6gb. I know very little about how it works but I don't need to remove modules from memory on a1111, which I'm using more often.
Edit: After closing the console, the memory dropped to 0.
If it is because of memory, how to get rid of that?


rake tarantula:setup fails, rails 3.1 application

Added gem "tarantula" to the development group in gem file and the gem has installed with bundle install.
Running rake tarantula:setup gives the error "Don't know how to build task 'tarantula:test'"

You can add this to your Rakefile as a workaround for right now:
load "relevance/tasks/tarantula_tasks.rake"

The real fix is to add a Railtie that pulls in the rake tasks - patches welcome!


Graduate Evented PLEG to Beta

Signed-off-by: Harshal Patil<EMAIL_ADDRESS>Add EventedPLEG to FeatureGates doc.
Corresponding PR - https://github.com/kubernetes/kubernetes/pull/115967
Enhancement - https://github.com/kubernetes/enhancements/issues/3386

Thanks @harche
(I think that) you should also update https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/ to mention this beta feature gate and why you might care about it.
If that's not the right page to update, we should find which is the right page and update that instead. For beta features, even those disabled by default, we nearly document why you might want to turn them on and the work you need to do associated with enabling the feature.

IMO, the right place for such page would https://kubernetes.io/docs/concepts/configuration/
I will add a page describing Evented PLEG and its usage. Thanks.

IMO, the right place for such page would https://kubernetes.io/docs/concepts/configuration/

That isn't the best home. If you want to document pod lifecycle events as a concept, put that in https://kubernetes.io/docs/concepts/containers/ or https://kubernetes.io/docs/concepts/workloads/pods/
If you want to explain the cluster operator angle, the content should live in either https://kubernetes.io/docs/concepts/cluster-administration/ or https://kubernetes.io/docs/tasks/administer-cluster/ (make the choice depending on whether you are explaining how to perform a task, such as migrating to CRI notifications, or providing general context).

IMO, the right place for such page would https://kubernetes.io/docs/concepts/configuration/

That isn't the best home. If you want to document pod lifecycle events as a concept, put that in https://kubernetes.io/docs/concepts/containers/ or https://kubernetes.io/docs/concepts/workloads/pods/
If you want to explain the cluster operator angle, the content should live in either https://kubernetes.io/docs/concepts/cluster-administration/ or https://kubernetes.io/docs/tasks/administer-cluster/ (make the choice depending on whether you are explaining how to perform a task, such as migrating to CRI notifications, or providing general context).

It's a configuration of the kubelet (and CRI Runtime) that affects how it maintains its internal cache of pod statuses. That's the reason I thought configuration made sense. This is not directly connected to any concepts related to containers or pods, neither is it related to any operator or cluster administration.

Coming to think of it, maybe https://kubernetes.io/docs/tasks/administer-cluster/ makes sense.

/sig node

/hold

/hold cancel

Thanks. This will need some work before we can merge it, I'm afraid. For example, I think we should advice readers to drain the nodes they're reconfiguring, or at least empower them to consider doing that.
What do you think @harche ?

yes, it makes sense.

@sftim Thanks for your valuable feedback. I have updated the PR with those recommendations.

/approve

/lgtm


React

The information visualization components require React Javascript Library to run. Therefore, the application framework should be React or at a minimum interface with it.

I have added the initial code into the repo: gitHub.com/OpenDRR/wet-react-js