Having to add all child item css from advanced fields manually in render method

Problem Description
When I have child items in the module i am having to add all css from the advanced fields for the child manually in the render method. i am actually having to recreate the logic that the advanced field are using on regular items. Is this normal.
Steps To Reproduce

Create any child items on a module and try to  use their advanced field settings, these are only available in this.props.content.attrs, you have to recreate all the code to use advanced field from module like border, box shadow etcetera in the render method which i know is a performance hit.

Screenshot and/or gif
`const border_radius_string = attr.border_radii;
const border_radius_array = border_radius_string !== undefined ? border_radius_string.split('|'):'';
			const borderTopLeftRadius = border_radius_array ? border_radius_array[1]: '0px';
			const borderTopRightRadius = border_radius_array ? border_radius_array[2]: '0px';
			const borderBottomRightRadius = border_radius_array ? border_radius_array[3]: '0px';
			const borderBottomLeftRadius = border_radius_array ? border_radius_array[4]: '0px';
			const divStyle = {
				height: content.props.attrs.height,

			};
			const imgStyle = {
				borderTopLeftRadius,
				borderTopRightRadius,
				borderBottomRightRadius,
				borderBottomLeftRadius,
				borderRadius: attr.border_radii,
				boxShadow: `${attr.box_shadow_horizontal} ${attr.box_shadow_vertical} ${attr.box_shadow_blur} ${attr.box_shadow_spread} ${attr.box_shadow_color}`,
				borderStyle: border_style,
				borderColor: attr.border_color_all !== undefined ? attr.border_color_all : '#00000',
				borderLeftStyle: attr.border_style_left !== undefined ? attr.border_style_left: attr.border_style_all,
				borderLeftColor: attr.border_color_left !== undefined ? attr.border_color_left: attr.border_color_all,
				borderTopStyle: attr.border_style_top !== undefined ? attr.border_style_top: attr.border_style_all,
				borderTopColor: attr.border_color_top !== undefined ? attr.border_color_top: attr.border_color_all,
				borderRightStyle: attr.border_style_right !== undefined ? attr.border_style_right: attr.border_style_all,
				borderRightColor: attr.border_color_right !== undefined ? attr.border_color_right: attr.border_color_all,
				borderBottomStyle: attr.border_style_bottom !== undefined ? attr.border_style_bottom: attr.border_style_all,
				borderBottomColor: attr.border_color_bottom !== undefined ? attr.border_color_bottom: attr.border_color_all,
				borderWidth: border_width
			}
			return (

			);
		});`

QA Checklist
Reporter

[ ] Helpful title used

Helpful title format: Scope(s) :: One Sentence To Describe The Issue
Example: VB :: Floating Toolbar :: Jumps To Top Of Page

[x] Detailed description
[x] Steps to reproduce included
[ ] Support Ticket URL included
[ ] Image and/or gif

Developer

[ ] Steps to reproduce proven solved
[ ] Test included and coverage acceptable and all Tests passing?
[ ] PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Estimated points on issue
[ ] Proper code documentation and conventions?
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Peer Review

[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Steps to reproduce proven solved
[ ] Affected areas are tested and ok
[ ] Proper code documentation and conventions
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Quality Assurance

[ ] All tests passed on CircleCI.
[ ] Steps to reproduce passed, the fix works.
[ ] No errors in console or output
[ ] Affected areas are tested and ok
[ ] The fix does not change a customer's website in any surprising or unintended way

[ ] If Divi's design is adjusted, settings are migrated gracefully and invisibly

Design Review

[ ] UI is to spec
[ ] UX is to spec
[ ] Design is to spec
[ ] No surprising visual changes to a customer's website will be experienced after updating

[ ] Any/all visual changes are migrated gracefully

Dev Review

[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?
[ ] i18n used if applicable
[ ] Implementation acceptable, DRY, Scaleable, future safe
[ ] Best practices used, cleverness and grokage, ES6 use, etc.

I think you might be doing something wrong and therefore having these issues. I just gave it a try and border styles are perfectly applied to my child module:

You should post your field config so the devs can identify what might be going wrong.

Actually I might know what you are doing wrong.  Are you using this.props.content in the parent to output the html genreated by each child? Does your html contain the necessary order classes and data-adresses?

I am not using a react component per child should I be? i am using this.props.content to to render the html generated by each child, the html does not contain the necessary order classes and data-adresses, how do i get those, what am i doing wrong?

When i try using this.props.content in my parent I get the error below, it is trying to render the content "object", is there something i am doing wrong. I am following the example exactly.
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.
Check the render method of t.
in t (created by t)
in div (at HelloWorld.jsx:17)
in div (at HelloWorld.jsx:15)
in CustomCtaParent (created by t)
in div (created by t)
in div (created by ETBuilderModule)
in t (created by ETBuilderModule)
in ETBuilderModule (created by t)
in t (created by t)
in t (created by ETBuilderColumn)
in div (created by ETBuilderColumn)
in t (created by ETBuilderColumn)
in ETBuilderColumn (created by ETBuilderRow)
in div (created by ETBuilderRow)
in t (created by ETBuilderRow)
in ETBuilderRow (created by ETBuilderSection)
in div (created by ETBuilderSection)
in t (created by ETBuilderSection)
in ETBuilderSection (created by ETBuilderRoot)
in div (created by t)
in t (created by ETBuilderRoot)
in div (created by ETBuilderRoot)
in ETBuilderRoot
in t

Actually you must use a react component to render your child modules as is shown in our example:
https://github.com/elegantthemes/divi-extension-example/blob/master/includes/modules/CustomCtaParent/CustomCtaParent.jsx
https://github.com/elegantthemes/divi-extension-example/blob/master/includes/modules/CustomCtaChild/CustomCtaChild.jsx

I got it now, i wasn't importing the child component in index.js, thanks for the help


Dev optimisations

Consider caching the SettingsService instead of _expensiveRendering.
The settings changed message will still need to be handled, but that's slightly more accurate the behavior (even if it's never checked)

Calling GetValue inside of the draw method will still have performance issues, since the control is x:Loaded it will still check the settings service every time you connect to a voice channel.


Support Libravatar

It would be great to see support for Libravatar as well.
Libravatar is a free software alternative to Gravatar that respects user privacy and offers similar functionality. Adding support for Libravatar would provide users with more options for managing their avatars and enhance the overall flexibility of the extension.
Here are a few points to consider:

Privacy: Libravatar emphasizes user privacy, which aligns with the values of many GNOME users.
Interoperability: Supporting multiple avatar services can cater to a wider audience and improve user experience.

Thanks for the suggestion! I will do this!

@danialbehzadi It should be working in the main branch. Care to give it a try? You can use Libravatar by choosing it in the prefs.


Warning from autoprefixer

We recently upgraded the version of autoprefixer that we're using for the web site and I noticed it has started issuing this warning:
autoprefixer: /home/tom/src/osm/rails/app/assets/stylesheets/id.css:4777:5: end value has mixed support, consider using flex-end instead

It comes from the included iD CSS and refers to this line and caniuse does seem to confirm that while it works in Firefox it doesn't work in Chrome for example.

@tomhughes Thanks for letting us know, I fixed this for the next release.


Subclassing BatchWriter is prevented by Argparser at top of file

Moving it into the if __name__ == "__main__": block will fix this.

We've got a backlog of changes internally that we'll push publicly tomorrow, and at that point we can bring this PR into master.


change config using login name to account hash.

https://github.com/pajlads/StealingArtefacts/blob/86bd014cb7a849fc0c0a4a4ce73c7b78f3328f9e/src/main/java/io/cbitler/stealingartefacts/StealingArtefactsPlugin.java#L268
Change using the login name in the config group to the account hash. This would mirror how Runelite does it, and might help with account security for people who import/export their settings.
Also getUsername seems to be deprecated.
https://github.com/runelite/runelite/blob/f86b2b1bc75ee927a6971354ff2609e2de32555a/runelite-api/src/main/java/com/jagex/oldscape/pub/OAuthApi.java

:+1: should be easy & non-disruptive
Would be fixed by #5 but it's not quite ready


2024-11-28_01-35-52_master-next_python3-boto3

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10556-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10556-to-kirkstone-next
git switch --create backport-10556-to-kirkstone-next
git cherry-pick -x bac20852b7f5b45431c594ad8729d3e84ace58c6

Successfully created backport PR for scarthgap-next:

#10563

Successfully created backport PR for styhead-next:

#10564


Add content_id for all-smart-answer-questions draft flow

Description
Even draft flows must have a content_id, because they are registered with the Publishing API in the integration environment.
I've added a test to catch this problem, but it would be better to modify the Flow class to effectively make it impossible to create a flow without a content_id.
External changes
None in production. However, this should fix the exception that was happening in rake publishing_api:publish when the integration build was deployed.

Looks good to me, @floehopper!

👍


Fix for #1702, additional tests for GeoWaveFeatureReader, doc updates.

Fixes #1702 and also handles cases where the geometry constraint is empty. Fixes a previously unknown bug with queries based on a temporal constraint only that broke depending on if the user issued the query with ECQL vs CQL. Added test for queries that only use temporal constraint to catch this issue in the future should it arise again. Also includes dev-guide update for debug configurations, fixing errors from pom.xml for plugin execution.

Forgot to format and signoff will re-issue


Add Timeout state to ls command

Today, if an ls command does not return or takes a really long time, it will hang the whole process waiting for the wonky machine.  This introduces a per-goroutine timeout to ensure that ls always returns (relatively) speedily, and indicates "Timeout" issues when they occur.
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

:+1:. I wonder if 1s is enough for all cases or if maybe it'd be a good idea to add a flag to change the timeout... Though it sort of seems that if a machine takes >1s something's very wrong ;)

Yeah +1 to @hairyhenderson -- I've seen several timeouts greater than 1s just trying to reach slow providers.

Yeah, 1 second is pretty aggressive, however I'd like to keep it pretty tight as one of the goals of this PR is to prevent non-responsive machines from freezing the UI up.  3 seconds?

I'm good with 3s :+1:

LGTM


fix sort by status

Summary
Another quick fix, this one to fix sorting by status by sending up is_active as the key instead of the unsupported status.
Ticket Link
https://mattermost.atlassian.net/browse/MM-29371

Feel free to merge after review!

Done!


expose node web app port is 3000 instead of 80

The node web app is exposed on port 3000 . The step 10 on port configuration needs to ask to enter 3000. something like :
Enter the web node app listening value of 3000 for the port, and then select Enter to complete the workflow.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61801b87-f37b-1025-c41e-73689e49b9da
Version Independent ID: f66e1382-6bd2-1b08-bb15-1e1868bf0062
Content: Deploy to Azure Container Apps using Visual Studio Code
Content Source: articles/container-apps/deploy-visual-studio-code.md
Service: container-apps
GitHub Login: @alexwolfmsft
Microsoft Alias: alexwolf

We have assigned the issue to the content author . They will evaluate & update the document as appropriate

#please-close


Crash in Json.Net when retrieving recent media from userid (unauth)

Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

my c# code:
var config = new InstagramConfig("aeae etc", "5185 etc");
var users = new InstaSharp.Endpoints.Users(config);
var feed = await users.Recent("username"); // <-- crash on this line
return View(feed.Data);

nuget instasharp 2.0.1
nuget newtonsoft json 7.0.1
please let me know if I need to provide more info for this bug/crash

Found it! it was because my username should have been an instagram user ID
http://jelled.com/instagram/lookup-user-id#
perhaps modify the lib to return a nice error instead of a crash.


nested dependency?

From the package.json, it seems this package is depending on it's own.
May I know why is it behaving this way?

Hey @beenotung
Thanks a lot for raising this issue
While I was testing I added it after that I forgot to remove it.


Adding Korean README.md

Adding Korean-translated README file to this journey.
Also adding a link to Korean README in original README file.

thanks!


Allow usage of polymer elements with angular2

We need to do some work to make angular2 compatible with Polymer.dom.
cc @justinfagnani

similar to https://github.com/Polymer/polymer/issues/1405

I can write up the layer pretty quickly. Just need a place to put it.

It' would be great :)

See also angular/angular#5531
Enabling full shadow DOM fixes some (many/most/all?) related issues. At least it looks good in Chrome. Haven't tried with other browsers.

We’ve been working on making any Polymer element work with Angular 2 nicely. Check out https://www.npmjs.com/package/@vaadin/angular2-polymer and tell us how it feels.
The quick user quide is here: https://github.com/vaadin/vaadin-core-elements/blob/master/docs/angular2.adoc
We also have a full blown tutorial in the works, you can read it here: https://github.com/vaadin/angular2-polymer/blob/d4581e8fd82841eea84ef40e16e262a12ee4b082/docs/tutorial.adoc


Problems loading HLS streamed by Adobe FMS 5 in Chrome

Chrome 51.0.2704.84 m (64-bit)
Windows 7 64 Bit
Clappr Version: 0.2.25

Stream a HLS livestream from an instance of Adobe Media Server 5
Attempt to play .m3u8 source inside Clappr in Chrome browser

Obviously the stream is expected to buffer and play without break. Instead, Chrome loads the initial few seconds of the live stream, plays it, freezes, then buffers infinitely without anything further being played. When inspecting, I can see the .m3u8 being fetched but the new .ts files aren't being loaded & played. I have tried a separate stream encoded with Wowza and everything works fine in Clappr. It's just to do with how Adobe Media Server 5 encodes the live stream (and how Clappr then reads that stream).
This issue was reproduced at http://cdn.clappr.io/ & same problem. When using other players/plugins, the same .m3u8 plays without a hitch. For instance, when playing in Grind Player with OMSF HLS plugin, it loads completely fine.
See test player here:
http://trnsmt.tv/admincpanel/testoclappr.html

To add to above - I have since linked to previous Clappr build 0.2.52 and it works perfectly on desktop.
I've seen a couple of mentions of possibly this same bug so feel free to close if the issue is already well known.
Lastly, accessing this test player on an Android device (Nexus 5, Chrome), I can audibly hear the segments overlapping/glitching. What can be causing this? What sort of buffer rules should be present in the options?

It's already know :) thanks a lot!

I can audibly hear the segments overlapping/glitching. What can be causing this? What sort of buffer rules should be present in the options?

I'd for you to go to our troubleshooting guide, very often these glitching/overlapping are related either to your input or segmentation (mostly PTS) and some cases, mostly for mobile, some devices might behave very different from other similar device :(

The troubleshooting is in another branch https://github.com/clappr/clappr/blob/split_readme/TROUBLESHOOTING.md (yet to be merged)

and, icon play and icon loading center not working, no show when stop. test in chrome 64 bit win 10. firefox is ok.
See test player here:
http://trnsmt.tv/admincpanel/testoclappr.html

The main source (m3u8) is a live stream between 8.00 - 14.00 GMT. Outside of those hours we would like the player to fall back to audio stream (has been added to that test player as another source). However, when the live .m3u8 is not available, the player tries to buffer infinitely and never falls back to the audio source. Have I configured the sources wrong or is this a bug?

i try live .m3u8 http://<IP_ADDRESS>/livetv/keeng.m3u8 but icon play center no show when stop

@samcarmex

However, when the live .m3u8 is not available, the player tries to buffer infinitely and never falls back to the audio source. Have I configured the sources wrong or is this a bug?

How are you setting this up?

@leandromoreira
See test player source - is that correct or do I need to use some sort of plugin to have it fall back?
http://trnsmt.tv/admincpanel/testoclappr.html

@samcarmex ohh I think you're doing right but the way Clappr works is different than what you expect, the fallback plugin works as in video tag, you inform some and Clappr will chose the first that works.
In your case you'll probably need to listen to PLAYER_ERROR and then load another source.


Support JarJar

Close #92
We are waiting of https://github.com/MinecraftForge/MinecraftForge/pull/8822
This is more changes than I would have liked, but the system requires the maven notation and the version.
The version range is generated from [VERSION,), which is VERSION or above. This should be very straight forward.
Adding a dependency for nesting has the same syntax as Fabric:
include "group:module:version"

Signed-off-by: shedaniel<EMAIL_ADDRESS>

We are now waiting for https://github.com/MinecraftForge/MinecraftForge/issues/8843

Any update on this as the issue in forge has been fixed.


 See https://pub.dev/packages/test#timeouts
  dart:isolate  _RawReceivePortImpl._handleMessage

00:46 +211 ~1 -1: C:\b\s\w\ir\k\flutter\packages\flutter_test\test\live_widget_controller_test.dart: Input event array on LiveWidgetController

https://ci.chromium.org/p/flutter/builders/prod/Windows framework_tests/784

FYI @goderbauer

Have you seen this on other non-windows platforms as well?

Just on windows so far

I haven't seen this again so I'm going to lower the priority

Has this happened again since the first report?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


where is representjs

Hi there, thank you very much for open sourcing!
I was trying to run PLBart, however, I did not find the representjs file.
Besides, I saw two folders for PLBart. I run the PLBart under the Task folder, should I run the PLBart folder instead?
Thank you very much in advance!

Sorry for the late response and the mistake in this issue. representjs is the package name of contracode. Therefore, you should first cd contracode, then pip install -e "." to install representjs to your python environment.

Hi @ZZR0, thank you for the reply. However, I found I cannot install the packages by pip install -e "." under the Task/Code-Refinement/contracode/ folder.

Oh, sorry. You should run pip install -e "." under CodeStudy/contracode


Drawer Body does not hide browser tab on Mobile devices

Describe the bug
Browser tab doesn't transition away on scroll down.
What is the expected behavior?
Whenever scrolling down a web app on ios, the mobile tab should transition away and the Drawer body content should expand to be full screen; this doesn't happen on mobile.
What are the steps to reproduce?

Open this app on mobile iphone and scroll down; observe browser tab doesn't transition away.
https://pxb-angular-theme-demo.web.app/dashboard

Environment

Safari, IOS

Interesting... might be related to the height:100% css rule

Window has to be the thing that scrolls, not the body content div

PXBLUE-2158


Is it possible to use EfficientNet backbone in TSN?

Is it possible to use an EfficientNet backbone in TSN? I mean something like this:
model = dict(
    type='Recognizer2D',
    backbone=dict(
        type='EfficientNetB4',
        pretrained='torchvision://efficientnet_b4', <------------- somehow change this
        depth=50,
        norm_eval=False),
    cls_head=dict(
        type='TSNHead',
        num_classes=3,
        in_channels=2048,
        spatial_type='avg',
        consensus=dict(type='AvgConsensus', dim=1),
        dropout_ratio=0.4,
        init_std=0.01),
    train_cfg=None,
    test_cfg=dict(average_clips=None))

I dont know if this is possible. For sure there are no weights in the model zoo for this but maybe if this can be done it can be initialized with PyTorch EfficientNet's weights.

@alejopaullier96 mmaction is no longer maintained. Please check mmaction2


Bad heroku git URL

This plugin is using bad repository URL for pushing to Heroku.
from a Heroku app foo-app it creates
git@git.heroku.com:foo-app.git clone url
but it should be
git@heroku.com:foo-app.git
without the git. subdomain
Do you plan to fix this? Or is there any way how to directly specify the push repository URL? Instead of app name?
Thanks

I have created a pull request to fix this #4

Fixed with #4


v2.5 installed from PyPI does not have mongodb module

I've installed v2.5 via pip. Attempting to use the mongodb module like so:
from testcontainers.mongodb import MongoDbContainer

gives me:
ImportError: No module named mongodb

Looking in my virtual environment:
(env) sabsays-MacBook-Pro:st2-test-utils sabsay$ ls env/lib/python2.7/site-packages/testcontainers/
__init__.py       compose.pyc       elasticsearch.pyc google            nginx.py          oracle.pyc        redis.py
__init__.pyc      core              general.py        mysql.py          nginx.pyc         postgres.py       redis.pyc
compose.py        elasticsearch.py  general.pyc       mysql.pyc         oracle.py         postgres.pyc      selenium.py

it is indeed not there :-)

Oops, hehe. Forgot about the options to install with pip install testcontainers[mongodb].
That seems to work although, core/generic.py imports sqlalchemy which shouldn't be needed to use mongodb. Think the DbContainer class in core/generic.py really doesn't belong there, as it brings in extra (optional) dependencies.

I still have to use
pip install git+https://github.com/testcontainers/testcontainers-python.git`

to get a working testcontainers[mongodb] in Gitlab-CI.

The extra is called mongo rather than mongodb. Version 2.6.0 should have that included.


Status updates not going to ST any

Just realized after the latest updates I Am not getting any updates to my ST setup. I can manually refresh but don’t get status changes or zone updates.  Looked at all the usual but not exactly sure where else to look.

I also noticed the webapp sometimes loads the status properly but after a while I see it say please wait loading... and never switches.

further inspection seems the web-app is getting all hungup when the upnp notification is enabled.  If I disable it all is good for days.

Q. if disabled your ST still works? I have seen the upnp service cause issues it is easiest to see specifics inside of the info log under /opt/alarmdecoder-web/instances/logs/ at the same time as the problem happens.

I have the same issue.  The webapp will stop updating ST (usually with a zone stuck open) and when checking the webapp keypad and live event pages it won’t show event updates.  Restarting the webapp will fix it but eventually it fails again, sometimes within minutes.  I’ll try to do some testing and monitor the log file.

I'm having this issue too. Rebuilt my AD Net Appliance with latest image too. My Smartthings integrations are now dead in the water. Ugh!

Sorry was offline today with network down. Lots of fun :(
I am usually available at<PHONE_NUMBER> x 703 10AM to 10PM PST. Leave a message I may not answer if I dont recognize the phone # and am otherwise preoccupied.
I can go over your setup and see if I broke anything or if you just had a upgrade glitch.

On a lark I power cycled the Smartthings Hub and it's been updating for the last 2 hours so maybe that was the issue. I will post again tomorrow with a status

I have the same issue randomly and fully powering off the SmartThings hub for a few minutes fixes it.  Not sure why though

I can also confirm this happened to me a few times during development. I think all the code changes while running causes the hub to stop listening on its local port.
Reboot also fixed it. The issue has not returned and seems to only happen when I publish code changes to my hub.

OK. After restarting my Smarthings hub all is well again. I really thought this issue was the same as what was reported by jjslegacy because I would get updates for a few minutes after restarting the webapp but then they would completely stop. I'm back in business!

Excellent! Keep me posted if you see it go poof again. This problem has a few causes both need work. One idea is to expand on the UPNP plugin page to show connections and last talk times. Still need to work on the UPNP notification and make it asynchronous so it will not stall out other parts of the system when the HUB locks up.

I am having this issue again and this time the reboot of the hub isn’t helping.  Seems totally broken now.

some log info:
0000]," DISARMED CHIME   Ready to Arm  "]]></last_message_received></e:property>
</e:propertyset> [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:462]
2019-07-18 03:22:59,601 INFO: Event UPNPPush Notification Failed: '' line: 464 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:467]
2019-07-18 03:22:59,611 INFO: Event:<PHONE_NUMBER>00606c02456cf5ec0101010000 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:422]
2019-07-18 03:22:59,639 ERROR: Error sending notification for UPNPPush: line: 138 UPNPPushNotification Failed: '' line: 464 [in /opt/alarmdecoder-webapp/ad2web/decoder.py:459]
2019-07-18 03:22:59,668 INFO: _notify_subscribers [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:447]
2019-07-18 03:22:59,671 INFO: _notify_subscribers: {'4c75c894-a90b-11e9-829a-7f2f4d7d14b9': {'callback': u'http://<IP_ADDRESS>:39500/notify', 'host': u'<IP_ADDRESS>:5000', 'timeout':<PHONE_NUMBER>.407198}}
<e:propertyset xmlns:e="urn:schemas-upnp-org:service:AlarmDecoder:1">

Any logs inside smartthings graph page would be helpful as well as logs
from app on AD2 webapp.
Try rebooting the pi and then when it is back up force a refresh on the
bottom of the AD2 st app screen.
On Wed, Jul 17, 2019, 8:03 PM Jeffrey Cowen<EMAIL_ADDRESS>wrote:

I am having this issue again and this time the reboot of the hub isn’t
helping. Seems totally broken now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nutechsoftware/alarmdecoder-smartthings/issues/32?email_source=notifications&email_token=AAPSWFCOXU4ZIUCWNOMSQXLP77MP7A5CNFSM4G2AKAAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2HFZVA#issuecomment-512646356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSWFB7EXBD7TQL3DEECJ3P77MP7ANCNFSM4G2AKAAA
.

I see nothing at all in the smartthings graph logs page.  I have rebooted the pi and the smartthings hub.
The manual refresh from ST App works just fine.
All I really see is this in the logs:
2019-07-18 13:18:22,368 INFO: Event UPNPPush Notification Failed: '' line: 464 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:467]
2019-07-18 13:18:22,379 INFO: Event:<PHONE_NUMBER>006163024543f531fb456cf5ec03010101 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:422]
2019-07-18 13:18:22,409 ERROR: Error sending notification for UPNPPush: line: 138 UPNPPushNotification Failed: '' line: 464 [in /opt/alarmdecoder-webapp/ad2web/decoder.py:459]
2019-07-18 13:19:45,856 INFO: SUBSCRIBE host:<IP_ADDRESS>:5000 callback: http://<IP_ADDRESS>:39500/notify timeout: Second-28800 [in /opt/alarmdecoder-webapp/ad2web/api/views.py:243]
2019-07-18 13:19:45,858 INFO: add_subscriber: ba4d0dde-a91d-11e9-a8d3-b827eba59841 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:203]

I'm having this same issue. WebAPP Log:
<e:property><panelstate><panel_perimeter_only>False</panel_perimeter_only><panel_chime>False</panel_chime><panel_alarming>False</panel_alarming><panel_battery_trouble>False</panel_battery_trouble><panel_entry_delay_off>False</panel_entry_delay_off><panel_ready>True</panel_ready><panel_fire_detected>False</panel_fire_detected><panel_powered>True</panel_powered><panel_exit>False</panel_exit><panel_panicked>False</panel_panicked><panel_armed_stay>False</panel_armed_stay><panel_type>ADEMCO</panel_type><panel_bypassed>False</panel_bypassed><panel_armed>False</panel_armed><panel_relay_status /><panel_zones_faulted /><last_message_received><!-- --><![CDATA[[10000001000000003A--],008,[f70200051008001c08020000000000],"****DISARMED****  Ready to Arm  "]]><!-- --></last_message_received></panelstate></e:property> </e:propertyset> [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:462] 2019-07-16 08:55:33,978 INFO: Event UPNPPush Notification Failed: [Errno 113] No route to host line: 464 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:467] 2019-07-16 08:55:33,989 INFO: Event: 0451449:0:0:0:0:0:0 [in /opt/alarmdecoder-webapp/ad2web/notifications/types.py:422] 2019-07-16 08:55:34,081 ERROR: Error sending notification for UPNPPush: line: 138 UPNPPushNotification Failed: [Errno 113] No route to host line: 464 [in /opt/alarmdecoder-webapp/ad2web/decoder.py:459]

that looks slightly different as I don't have the " No route to host"

Sean so kindly stared at mine long enough until it fixed itself.  It appears although no hard evidence as the issue was on the smartthings side - something stormy in the cloud I guess.

Magically working on mine too. Pulled the latest web app and library updates also.

Excellent. The latest updated I just did will prevent double ARM events in
ST but if you are using the Raspbian 9 image it wont actually updated the
the API :(
It was a bug in the "oil change" Good news is I just finished testing and
release the latest Raspbian 10 image. I spent a bit of time testing all of
the notifications. Still early but a few have tested it as well as my own
testing and it seems solid. I plan on updating my system at home tomorrow.
Best
Sean M
On Sat, Jul 20, 2019 at 10:48 PM jasonsf<EMAIL_ADDRESS>wrote:

Magically working on mine too. Pulled the latest web app and library
updates also.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nutechsoftware/alarmdecoder-smartthings/issues/32?email_source=notifications&email_token=AAPSWFFT22W4RQLMSQVQLA3QAP2EJA5CNFSM4G2AKAAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2N4K5Q#issuecomment-513525110,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSWFFU264PJIS2POHX3H3QAP2EJANCNFSM4G2AKAAA
.


get_by_nxos will return first_fixed with None

Hi,
I tried get_by_nxos and noticed that the advisories always had "first_fixed" with None .
ad_nxos = query.get_by_nxos('nxos', '7.3(3)N1(1)')

In order to troubleshoot this, I used get_request to fetch the raw API output for both ios and nxos:
ad_iosxe = query.get_request('iosxe', params={'version':'3.16.1S'})
ad_nxos = query.get_request('nxos', params={'version':'7.3(3)N1(1)'})

From the results, the raw outputs of each ios advisory has the key called "firstFixed":
{
    'advisoryId' = {str} 'cisco-sa-appnav-xe-dos-j5MXTR4'
     ...
    'firstFixed' = {list: 1} ['16.12.6']
     ...
}

Instead, the raw output of each nxos advisory has the key "platforms", which contains the 'firstFixes':
{
    'advisoryId' = {str} 'cisco-sa-nxos-cdp-dos-ce-wWvPucC9'
    ...
    'platforms' = {list: 2} [
          {'id': '265090', 'name': 'Cisco Nexus 5000 Series Switches', 'firstFixes': [{'id': '289274', 'name': '7.3(12)N1(1)'}], 'vulnerabilityState': 'vulnerable'},
          {'id': '265094', 'name': 'Cisco Nexus 6000 Series Switches', 'firstFixes': [{'id': '289274', 'name': '7.3(12)N1(1)'}], 'vulnerabilityState': 'vulnerable'}
     ]
     ...
}

I think the reason for the issue lies in no code logic handling nxos outputs in advisory.py. The temporary workaround is to use get_request and get firstFixes manually.

Hi,
I tried get_by_nxos and noticed that the advisories always had "first_fixed" with None .
ad_nxos = query.get_by_nxos('nxos', '7.3(3)N1(1)')

In order to troubleshoot this, I used get_request to fetch the raw API output for both ios and nxos:
ad_iosxe = query.get_request('iosxe', params={'version':'3.16.1S'})
ad_nxos = query.get_request('nxos', params={'version':'7.3(3)N1(1)'})

From the results, the raw outputs of each ios advisory has the key called "firstFixed":
{
    'advisoryId' = {str} 'cisco-sa-appnav-xe-dos-j5MXTR4'
     ...
    'firstFixed' = {list: 1} ['16.12.6']
     ...
}

Instead, the raw output of each nxos advisory has the key "platforms", which contains the 'firstFixes':
{
    'advisoryId' = {str} 'cisco-sa-nxos-cdp-dos-ce-wWvPucC9'
    ...
    'platforms' = {list: 2} [
          {'id': '265090', 'name': 'Cisco Nexus 5000 Series Switches', 'firstFixes': [{'id': '289274', 'name': '7.3(12)N1(1)'}], 'vulnerabilityState': 'vulnerable'},
          {'id': '265094', 'name': 'Cisco Nexus 6000 Series Switches', 'firstFixes': [{'id': '289274', 'name': '7.3(12)N1(1)'}], 'vulnerabilityState': 'vulnerable'}
     ]
     ...
}

I think the reason for the issue lies in no code logic handling nxos outputs in advisory.py. The temporary workaround is to use get_request and get firstFixes manually.

Thanks @qifawu
Cisco IOS and Cisco IOS XE doesn’t have the concept of platform, it is a single product.  NX-OS,ACI, ASA, etc have the additional fields of platform and hence a first fix release based on per platform rather than just the operating system.
You can define a filter for the platformAlias: example:

filter = query_client.OptionalParameters(query_client.PLATFORMALIAS,'NEXUS9000')
ad_nxos = client.get_by_nxos('default','7.0(3)I6(2)',filter)

If you wish to obtain the first fix for each:

for item in ad_nxos:
...   print(item.advisory_title)
...   for platform in item.platforms:
...     print("  " + platform.name,end=":")
...     for fix in platform.firstFixes:
...       print(fix['name'])
...
Cisco NX-OS Software MPLS OAM Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(10)
Cisco FXOS and NX-OS Software Cisco Discovery Protocol Denial of Service and Arbitrary Code Execution Vulnerability
Cisco Nexus 9000 Series Switches:9.3(10)
Cisco NX-OS Software OSPFv3 Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:9.3(9)
Cisco Nexus 9000 Series Switches Bidirectional Forwarding Detection Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:9.3(9)
Cisco FXOS and NX-OS Software Cisco Discovery Protocol Service Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:9.3(9)
Cisco NX-OS Software Cisco Fabric Services Over IP Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:9.3(9)
Cisco NX-OS Software NX-API Command Injection Vulnerability
Cisco Nexus 9000 Series Switches:9.3(9)
Multiple Cisco Operating Systems Unidirectional Link Detection Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(10)
Cisco FXOS and NX-OS Software Unidirectional Link Detection Denial of Service and Arbitrary Code Execution Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(10)
Cisco NX-OS Software IPv6 Netstack Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(9)
Cisco NX-OS Software NX-API Cross-Site Request Forgery Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(9)
Cisco FXOS and NX-OS Software Cisco Fabric Services Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(9)
Cisco NX-OS Software Data Management Engine Remote Code Execution Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(8)
Cisco NX-OS Software Call Home Command Injection Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(2)
Cisco NX-OS Software IPv6 Protocol Independent Multicast Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(8)
Cisco IOS, IOS XE, IOS XR, and NX-OS Software One Platform Kit Remote Code Execution Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(8)
Cisco FXOS, IOS XR, and NX-OS Software Cisco Discovery Protocol Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(8)
Cisco NX-OS Software Cisco Fabric Services over IP Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(4)
Cisco FXOS and NX-OS Software Authenticated Simple Network Management Protocol Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(6)
Cisco NX-OS Software Remote Management Memory Leak Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(4)
Cisco NX-OS Software Network Time Protocol Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(6)
Cisco NX-OS Software Virtualization Manager Command Injection Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(6)
Cisco NX-OS Software NX-API Denial of Service Vulnerability
Cisco Nexus 9000 Series Switches:7.0(3)I7(6)

Output without a filter defined:
Cisco NX-OS Software MPLS OAM Denial of Service Vulnerability
Cisco Nexus 3000 Series Switches:7.0(3)I7(10)
Cisco Nexus 9000 Series Switches:7.0(3)I7(10)
Cisco FXOS and NX-OS Software Cisco Discovery Protocol Denial of Service and Arbitrary Code Execution Vulnerability
Cisco Nexus 3000 Series Switches:9.3(10)
Cisco Nexus 9000 Series Switches:9.3(10)
.
.
.
HTH.  If need more qualification on this please pop an email to<EMAIL_ADDRESS>


"weed mount " changes the mounted dir mod to 777

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Describe the bug
A clear and concise description of what the bug is.
Not sure.
System Setup
List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Describe the bug
Not sure.
The mounted dir mod is changed to 777.
System Setup
mkdir data
weed server -dir data/ -filer
mkdir mnt
weed mount -dir mnt
Expected behavior
The mnt dir mod should be the same as before.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

which version?


reduce cpu host overhead when using moe

The operation .to('cpu') is not necessary for exp_counts, and it will cause device to host synchronization which damage  performance.

Hi, @tohtana  I have clarified the modifications you mentioned and retest this PR with Megatron-Deepspeed on GPU platform(8xA800). It runs well and loss remains consistent with the original method, Could you please help review it again? Thanks!

https://github.com/microsoft/DeepSpeed/pull/5881 also adopts this plan to reduce cpu time


Icons are shifted out of place

Issue: In Stu's last PR it shifted the icons a little bit we thought it was best to fix in a new ticket 👍
Screenshot:

@phillsatellite is this still an issue?


Slightly change the example

Hello @vlukiyanov! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file examples/20news/20news.py:

Line 85:80: E501 line too long (84 > 79 characters)
Line 131:80: E501 line too long (80 > 79 characters)


AWS S3 KMS Encryption Custom Signature

Please review and let me know if I need to sign a copyright release of any sort for this PR to be accepted.

Looks good, merging.

Thank you!


Implement ACL

The goal is to create a fine grained access control layer for each function of the DAO Registry.
Conditions:

each function in the DaoRegistry gets assigned an ACL flag
before executing any function in the DaoRegistry, the ACL needs to be checked to see if the current module/adapter has access to it
when a module is registered via Managing Adapter, the module needs to ask for permissions (the ACL)
to encode the ACL, we should use the FlagHelper, so that the 256 possible flags values are encoded into 1 uint256

close with #75


host the web server somewhere

decide where to host and host

any issues with heroku? we can take a look at GCP, Azure since AWS is out of option

For heroku we need to check db limits in free tier. Otherwise no issue that i can think of. I guess we need to check that on any service we consider

Why is AWS out of option?

Why is AWS out of option?

I would tag @visajkapadia

That option is in now @aniketjingar


Small change to trigger new build

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


feature(backend): setup rejectContribution method.

🍰 Pullrequest
Admin need a method to reject contributions instead of deleting them
Issues

fixes #2332

Todo

[X] Create a method to rejectContribution (for admins)
[X] Find contribution
[x] Update contribution (state = rejected, rejectedAt = now, rejectedBy = adminUser.id, ...)
[x] Save updatedContribution
[x] Send EMail to user
[x] wallet > my contributions > everything
[x] wallet > community > accepted, rejected, pending
[x] admin > user search > creation list > everything
[x] admin > unconfirmed contributions > only pending
[x] denied contributions must throw an error in confirmContribution in backend/src/graphql/resolver/ContributionResolver.ts

Admin Unit Test have to be reworked / fixed
Frontend Unit Test have to be rework / fixed


[Peek] Fix leak in unmanaged memory

Summary of the Pull Request
Fixes an issue where Peek leaks a small amount of memory for each image (or likely for each file) viewed in the context of a folder operation.
PR Checklist

[x] Closes: #33593
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
For unclear reasons, a non-trivial amount of unmanaged memory (between a few hundred KB and 1 MB) is held for each Windows.Storage.StorageFile instance kept in an internal cache (which is created for each previewed file and not released until the Peek context is changed). This type is intended to only hold a small amount of file-metadata, but in practice seems to have a bigger footprint.
Validation Steps Performed
Created a test bench as follows:

Created a folder with 2000 images (all duplicates of a single 300 KB image).
Created a script to preview all files in the folder by activating the Peek window and repeatedly injecting the right cursor key.
Tracked process private bytes and broke this down into managed and unmanaged memory using a memory profiler.

Before this change, the overall memory usage goes up from ~100 MB to ~2GB. Almost all of this delta is attributable to an increase in unmanaged memory. After my change, the overall memory usage is more or less stable.
I did not observe any loss in functionality (although I only did a sanity check) or any visible increase in preview loading time as a result of this change.

/azp run

hell yeah fixing this bug!

Sadly, after some investigation by @stefansjfw, it appears that my experiment was flawed. The leak appears to be some strange (possibly OS-level) caching that appears to increase Peek private bytes only the very first time a particular file is previewed. Restarting the Peek process (or PowerToys entirely) and previewing the same file again, bizarrely, does not seem to increase Peek private bytes.
In the image below, we have my experiment running. In the left (stable) half of the graph, Peek is cycling through files that an earlier Peek process had previewed. In the right (rising) part of the graph, Peek is cycling through files that it has never previewed before. I don't think I've ever seen behaviour like this before!

Anyway, it means that this PR is based on junk science and has to unfortunately be scrapped.


RDKTV-22121 CEC Report Features Thunder

Added support for  and  CEC message
Also added API's to set and get CEC Version from RFC

Bringing in review comments as another change


Fix formatting issues in documentation: Removed periods and added backticks

Removed periods, Use backticks to format references to the file names (instead of italics).
Why:
The bullet points were not complete sentences, and according to the style guide, lists with incomplete sentences should not end with periods. This change ensures the article follows the documentation style guide.
Closes: #35661
Closes: #35660
Closes: #35658
Closes: #35657
Check off the following:

[x] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
[x] The changes in this PR meet the docs fundamentals that are required for all content.
[x] All CI checks are passing.

@lalithaar Thanks so much for opening a PR with this fix! I made on small tweak and removed the parentheses around the file name, as they aren't needed 💛 I'll update the branch and get this merged once tests are passing 🍏


fix: Remove totals table rows from displayed row count

Fixes #1407. When aggregations were added, both the table and column tooltips displayed an increased row count to account for the totals table. Rows from the totals table are now subtracted from the row count displayed to users.

I have read the CLA Document and I hereby sign the CLA

Great work!


spirv-val: Optimize struct field decoration lookup

A std::set is used instead of std::vector, where the elements are
ordered by member index first.  Decorations for fields are now looked up
by going over the range of decorations for the member only, instead of
the whole set.
In an ANGLE test that generates a struct with 4096 members, validation
goes down from ~140ms to ~90ms.  On debug builds, the difference is more
pronounced, going down from ~2.5s to ~600ms.

I see glslc tests have a few failures where OpLine is now emitted unexpectedly. Is that a flake? Doesn't seem related to this change.

I re-ran that bot and it's passing now.

I see glslc tests have a few failures where OpLine is now emitted unexpectedly. Is that a flake? Doesn't seem related to this change.

It's not a flake.
The smoke tests deliberately use top of tree Glslang and Shaderc.  Glslang now has more output when compiling with debug info turned on, and Shaderc did not catch up yet.  I updated Shaderc yesterday.
https://github.com/google/shaderc/pull/1249


Add TimSort Algorithm

Timsort is a hybrid sorting algorithm that combines the best features of merge sort and insertion sort. It is typically the fastest sorting algorithm for most data sets.
Feature :
Add Timsort sorting technique  in C, C++ and Python.
Description of solution :
Will add TImsort Sorting algorithm with adequate comments for readers to get a clear understanding.
To add in C , C++ and Python.
Alternatives Considered :
Can you assign me this issue under SSoC '23 so that I can send in a PR on 1st June ?

@SPARSH1608 Could you also implement this algorithm in Java

@Kumar-laxmi YES I CAN

@Kumar-laxmi I can implement this algorithm in java.
Could you please assign it to me.
Thank you!

Assigned!
@SPARSH1608 : C, C++, Python and Java

Since there this issue is inactive the assignment is being removed

@Kumar-laxmi I was working on it ,  due to some changes in my other PR I couldn't do it please assign me this issue again


[lexical-table] Fix table cell format for selection within cell

Currently, the TableCellNode tracks the format of the paragraph inside. This is applied correctly when selection is via table selection (range selection including a table, whole table selection, cells selection).
There is a collection of cases if it's selection within the table cell, since the table cell is not selected the format doesn't propagate to the parent TableCellNode correctly and things get out of sync. This fixes those cases.
Before:
https://github.com/user-attachments/assets/bb1feffc-ab08-4232-9e86-3735eca43335
After:
Things are in sync
https://github.com/user-attachments/assets/fb459ff0-0898-4c81-a2e4-a001f796d86a

Hi @ivailop7, I know it's not my place to say. But given you are able to reproduce and demonstrate this issue in the playground, it should also be possible to write an e2e test for this. Given there are many organizations that rely on this codebase, would you be willing to write one, or otherwise specify in your PR description why tests were not included for this change?

This kinda seems like something that should be handled by the selection class rather than a command? Since we do have a paragraph in every cell maybe it makes sense not to store this format there at all since it can and should already be stored on the paragraph (per #6583)

This kinda seems like something that should be handled by the selection class rather than a command? Since we do have a paragraph in every cell maybe it makes sense not to store this format there at all since it can and should already be stored on the paragraph (per #6583)

Yeah, that's probably a better approach and would make preserving the styling on empty cells more consistent. Need to redo it, but my holidays ended, so don't have as much time to do PRs. Will revisit in the coming weeks.


retry RPM download if it fails

this particular task is prone to occasional errors since it downloads a large file over the internet. would be nice to have it retry a few times automatically, especially for playbooks running across a group of servers.

merged on #72.


[Next.js ISR] - Falling back to using page's rendering function for html -> blank page

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d3am3wm1pufv8b
Region
us-east-1
Amplify Console feature
No response
Describe the bug
When performing ISR, the CloudWatch logs show this INFO message:
2021-09-29T19:35:48.201Z 7bb932bc-a773-57c0-aa41-6b72654e1cb5 INFO Falling back to using page's rendering function for html

When that happens, the page regenerates as a completely blank page.
Expected behavior
The page does not regenerate as a completely blank page.
Reproduction steps

Next.js 11.1.0
Create an ISR page
Under some unknown scenario, the page does not regenerate successfully and generates a blank page

Sorry, terrible reproduction steps. There are no relevant logs to suggest why this is happening.
Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        # The scripting library zx requires Node 14.
        - nvm install 14
        - nvm use 14
        - yarn install
    build:
      commands:
        - yarn build
  artifacts:
    baseDirectory: .next
    files:
      - "**/*"
  cache:
    paths:
      - node_modules/**/*
      - .next/cache/**/*

Additional information
No response

This is code in the Lambda:
const renderPageToHtml = async (page, req, res, renderMode) => {
    const { renderOpts, html: htmlResult } = await page.renderReqToHTML(req, res, renderMode);
    let html;
    try {
        if (typeof htmlResult === "string") {
            html = htmlResult; // Next.js < 11.1
        }
        else {
            html = htmlResult ? await resultsToString_1([htmlResult]) : ""; // Next >= 11.1.1
        }
    }
    catch (e) {
        // Fallback to using renderReqToHtml without renderMode specified,
        // which will render html based on the page's renderReqToHtml,
        // which should always work (but adds another *warm* render cost)
        console.log("Falling back to using page's rendering function for html");
        html = (await page.renderReqToHTML(req, res));
    }
    return { html, renderOpts };
};

I noticed that another branch that uses 11.1.2 works. I plan on using 11.1.2 on the desired branch and will report back here.

It looks like it worked! So 11.1.0 is broken on ISR but 11.1.2 works. Up to the AWS team if you're interested in keeping this open since there is a workaround!


Handling tiles that failed due to max queue size being reached

Right now, when a tile can not be retrieved due to the max queue size being reached, the callback method mapTileRequestFailed is being called just like as if the corresponding provider doesn't have this tile. This is problematic, as MapTileProviderArray is then looking for the next appropriate provider for this tile, which we don't want in case the queue is full. This causes too much CPU and Memory load.
Related:  #757, probably also #801
This PR introduces a separation between mapTileRequestFailed and the new mapTileRequestFailedExceedsMaxQueueSize in:

IMapTileProviderCallback.java
MapTileModuleProviderBase.java
MapTileProviderBase.java
MapTileProviderArray.java

@spyhunter99 Why does it fail? Sorry, it's my first PR, anything I can do?

It's a combo of travis and the avd. I'll kick it

you have to go to travis and look at the raw log. Usually there is a reason for the failure. In this case, it's a compile error
/home/travis/build/osmdroid/osmdroid/osmdroid-android-it/src/main/java/org/osmdroid/tileprovider/modules/MapTileProviderTest.java:30: error: <anonymous org.osmdroid.tileprovider.modules.MapTileProviderTest$1> is not abstract and does not override abstract method mapTileRequestFailedExceedsMaxQueueSize(MapTileRequestState) in IMapTileProviderCallback
	final IMapTileProviderCallback mTileProviderCallback = new IMapTileProviderCallback() {
	                                                                               ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.````

Oh, I see - thanks, I think I got it now...

@spyhunter99 I think I resolved the compile error and reran the checks three times on the same code, always with different failures. Once two of the three checks passed, just one failed, once two failed and now all three failed again? Can't find anything meaningful in the log. What am I missing?

@secaw looking at this now

@spyhunter99 Looking good now, thanks.


Add ros shortcut commands

Adding ,rossetip and ,rossetmaster shortcut commands.

@YUKINA-3252 Could you review this?


Update README.md

Move contributing to the top of the file

I believe I have solved the issue, but I am looking for anyone who has insights to view my changes and possibly approve the PR. If anyone would look at this it would be appreaciated.


[Bug]: The maximum value of the partition table is not displayed in full

ODC version
4.2.3
OB version
all
What happened?
When a partition table has multiple maximum values, the front end only displays one：

What did you expect to happen?
table ddl:
CREATE TABLE "SHANLU"."RANGE_PARTI_TIME_TYPE" (
  "C1" DATE,
  "C2" TIMESTAMP(9),
  "C5" VARCHAR2(64)
)
 partition by range(c1, c2)
(partition P0 values less than (TO_DATE(' 2022-12-31 23:59:59', 'SYYYY-MM-DD HH24:MI:SS', 'NLS_CALENDAR=GREGORIAN'),Timestamp '2022-12-31 23:59:59.000000000'));

How can we reproduce it (as minimally and precisely as possible)?
no
Anything else we need to know?
No response
Cloud
No response

pass


Feature/nsg

Merge request for NSG initial release

I have read the CLA Document and I hereby sign the CLA


Fix ingest sorting by Enabled flag

@Fosol Although this shows as merged, I don't see the change in the dev branch.


Sipping Chalice duration

Using the "Sip Chalice" macro applies temporary hit points and an effect to the target.  However, the temporary hit points and effect expire when the end of the round is reached, i.e., when the last actor on the encounter tracker hits "End Turn" and the initiative returns to the top of the initiative for a new round.

It sure does, good catch. I'll have a fix for it.


Replace demo.gif

Issue: ☝

👏

This is really nice! What'd you use to create it?

Glad you like it @ewolfe, Daniel Egerev created it for us, maybe he can explain the process?

@ewolfe the animations were done in Adobe After Effects. I first created the illustrations in Adobe Illustrator and then imported to After Effects to animate them 🙂


Fix outputting retention time in Sciex scheduled transition lists

Fixed "retention time is always zero" in exported scheduled Sciex transition list (reported by Jeff)
Based on this support request:
https://skyline.ms/announcements/home/support/thread.view?rowId=63103
This was my best guess about how to fix this one.

I think this will mess up the method export logic. I would rather do
            else   // CSV
            {
                return string.Format(@",{0},{1},{2}",
                    dp,
                    ce,
                    rt);
            }

in GetOptionalColumns method. Do you know if RT has to be the second column in the csv file?

in GetOptionalColumns method. Do you know if RT has to be the second column in the csv file?

That's a good question. I must confess I don't know anything about how this works (or even how to test this). Can you fix this?

I think this will mess up the method export logic. I would rather do
            else   // CSV
            {
                return string.Format(@",{0},{1},{2}",
                    dp,
                    ce,
                    rt);
            }

in GetOptionalColumns method. Do you know if RT has to be the second column in the csv file?

Rita, this definitely fixes the old transition list export support. I don't see that it would break method export. Though, I think you need to fix the comment where you switched the code from using the "dwell" column for for retention time when the method is scheduled to using a new RT column.
            // If the ScheduledMethod flag was set assume that the Dwell time column in the
            // transition list file has retention time.
            if (ScheduledMethod)

               retentionTime = transition.Dwell;

               retentionTime = transition.Rt ?? 0;

Are you positive that this is now always correct? It seems like this fix would again make it possible to use transition.Dwell. It is also never correct to use zero for RT when it is a scheduled method.
So, I think more attention is needed here. When exactly would transition.Rt be null?

So maybe:
        // If the ScheduledMethod flag was set assume that the Dwell time column in the
        // transition list file has retention time.
        if (ScheduledMethod)
            retentionTime = transition.Rt ?? transition.Dwell;


Issue #SH-996 feat: Portal: Do not allow user to enroll to future batches but prevent them from consumption

created new PR


fix: Navigator: if the path is empty -> force the homepage

Hi everyone,
As noticed in #4983, the Navigator is broken when:

The app is killed AND
We want to open the homepage
(All other links are OK)

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (014557e) 9.61% compared to head (d775b80) 9.61%.

Files
Patch %
Lines

.../smooth_app/lib/pages/navigator/app_navigator.dart
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4986      +/-   ##
==========================================
- Coverage     9.61%   9.61%   -0.01%
==========================================
  Files          323     323
  Lines        16279   16280       +1
==========================================
  Hits          1565    1565
- Misses       14714   14715       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SR SQL Planner Summer Camp] New Parser and Analyzer support CreateUserStmt

What type of PR is this：

[x] enhancement

Which issues of this PR fixes ：

Fixes #7950

This PR changes the same classes as your other PR #8503. Please close one of the PRs in case of conflict.

@padmejin ignore this pr temporarily, it rebase on PR #8503, just for running ut now.

[FE PR Coverage Check]
:heart_eyes: pass : 103 / 123 (83.74%)
file detail

path
covered line
new line
coverage
not covered line detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
2
00.00%
[324, 328]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
4
7
57.14%
[351, 353, 361]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeStmtAnalyzer.java
39
50
78.00%
[141, 145, 146, 148, 151, 202, 206, 207, 209, 212, 219]

:large_blue_circle:
com/starrocks/analysis/CreateUserStmt.java
11
14
78.57%
[128, 129, 141]

:large_blue_circle:
com/starrocks/analysis/AlterUserStmt.java
10
11
90.91%
[113]

:large_blue_circle:
com/starrocks/sql/ast/UserAuthOption.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/Analyzer.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
25
25
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 58 / 70 (82.86%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%
[388]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
2
4
50.00%
[470, 472]

:large_blue_circle:
com/starrocks/analysis/CreateUserStmt.java
11
14
78.57%
[127, 128, 140]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeStmtAnalyzer.java
32
38
84.21%
[141, 145, 146, 148, 151, 219]

:large_blue_circle:
com/starrocks/sql/analyzer/Analyzer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
11
11
100.00%
[]

It's ready for review now. @padmejin

[FE PR Coverage Check]
:heart_eyes: pass : 87 / 90 (96.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/BaseCreateAlterUserStmt.java
46
48
95.83%
[90, 118]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeStmtAnalyzer.java
27
28
96.43%
[178]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/AlterUserStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/CreateUserStmt.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 84 / 89 (94.38%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/BaseCreateAlterUserStmt.java
44
48
91.67%
[53, 54, 90, 118]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeStmtAnalyzer.java
26
27
96.30%
[177]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/AlterUserStmt.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/CreateUserStmt.java
2
2
100.00%
[]

run starrocks_admit_test


[fix-is-online] replacing is-online dependency

is-online dependency excluded
Now we are using connectivity instead is-online. It's is a much simpler approach and probably no more errors will occur because of this type of check.
agent start messages changes
Now when there is internet connection will display this message:
azk: Checking version...
azk: azk 0.12.0 detected

Otherwise, if no internet connection is available:
azk: Checking version: there is no internet connection to check azk version.

How to test:

start agent with and without internet

$ azk agent start
$ azk agent stop

download an docker image with and without internet

$ adocker rmi -f azukiapp/azktcl:0.0.1
$ azk shell --image azukiapp/azktcl:0.0.1

This commit closes #368 and closes #371

Good job @saitodisse, simple and powerful solution.

LGTM :+1:


Update issue templates

Bug reports are often missing some context. This PR updates our templates to address the issue.

Unintentional duplicate of #220. Closing.


✨ Feature Suggestion | disable sensor in firefox

search device.sensors in about:config , turn all "enable" flags to false, can be used to prevent websites from use accelerometer to record audio indirectly

Seems like a reasonable addition, @Thorin-Oakenpants what do you think?

ignore it, close with prejudice

Any elaboration?

@Thorin-Oakenpants
sorry, i'm not a native speaker of english, and i can't understand what means of "prejudice" here, could you please explain it ?
if you think i have some prejudice in what i said before, i apologize to you here

It seems like a good addition, if it does what you say it does, for laptop users or people who have a microphone plugged in all day on their desktop machines.

@LongJohn-Silver
I think you may misunderstand, this flag is more target to mobile platform which have accelerometer. if you want to prevent website access microphone, you can deny "microphone" permission

Any elaboration?

where are the sources, papers on this? (not doubting op, and I already know sensors have other FP issues: but everything needs sources in order to evaluate)
what is the actual threat? e.g. I know sensors provide a high precision timestamp and the application of that means different things. What is the end threat here of this "audio recording" - what is the it recording. Audio may just a simple way to hash the combined sensor data and is not required .. this is why we need sources
what is the proper solution? i.e not some blanket "set everything to false"
what do Mozilla and RFP and TB say
who is this solution targeted at? - Fenix users with about:config access, right? That's very niche
who is PTIOs audience?

I commented at tor project - typically this is something that should get handled upstream under RFP: most likely under bugzilla 1562290

here is the source and paper (maybe)

thanks - i'll add that to the tor ticket notes

IMO, you can close this. My source tells me it looks like this attack is impractical from a webpage. Also note the default settings: ambientLight and proximity aren't exposed.  I didn't read the paper in detail. But this is a very niche attack, if even at all possible/practical within Fenix
device.sensors.*
- ambientLight.enabled ; false // devicelight (false since FF62)
- enabled              ; true
- motion.enabled       ; true
- orientation.enabled  ; true
- proximity.enabled    ; false // userproximity and deviceproximity (false since FF62)
- test.events          ; false // FF70+


Add files via upload

The last second upload corresponds to task2 for a faster tank;
The last one corresponds to task4, solving a part of issue #28 to us 上下左右 make it move

I wonder if task2 is finished in this moment.

this new upload has finished issue #294 ,for task 4 , thanks~


Add RBS for<EMAIL_ADDRESS>

This PR add RBS for<EMAIL_ADDRESS>Currently this RBS contains definition of

JWT.encode and JWT.decode (incomplete)
Error classes

@pocke Thanks for review. I reflected your comment at d0f8db2.


Appstudio update test-component-pac-nklc

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-nklc-on-pull-request has failed.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
33 seconds
clone-repository

---
---
build-container

Pipelines as Code CI/test-component-pac-nklc-on-pull-request has failed.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
33 seconds
clone-repository

---
---
build-container

Pipelines as Code CI/test-component-pac-nklc-on-pull-request has failed.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
33 seconds
clone-repository

🏃 Running
---
build-container


Make function helptext more concise with a +bids/Contents.m

What do you think about making the per-function helptext more concise by concentrating the whole-library doco in a central +bids/Contents.m help file (that pops up when you do help bids)?
This way users can do help bids to get info on the overall library, and help <fcn> for the individual functions takes up less precious space in the command window. Each of the individual function help texts will have a link to the main bids help item so it'll be easy for users to find.
Works in Matlab R2014b-R2019b, though there's a bug in earlier versions of Matlab that causes the help for help bids to be displayed twice.

good idea!

Thanks for all the merges!


Fix group parameters' name with type Array

Yes,it's a fix, I will improve it.

Updated.

Sorry I merged another PR that conflicts with this, would you mind rebasing? Apologies.

It can be merged now, I think.

Merged via https://github.com/tim-vandecasteele/grape-swagger/commit/12dae157e9d1b633490c0aa44c809a61c4e9ac09.


Installing the plugin breaks Hoobs service from starting

Issue

I turned on my Hoobs.
Added the Hue Plugin
Followed the installation guide here: https://plugins.hoobs.org/plugin/homebridge-hue
When I clicked on my Hue Hub it created a user, which I then inserted into the config.
When I click Save it keeps on loading and never stops.
In the end, I rebooted Hoobs, and when I start it up, I see: "Bridge Service Not Running"

Log Messages

18/10/2020, 18:09:57 HOOBS listening on port 80.
18/10/2020, 18:10:04 Loaded plugin "homebridge-hue".
18/10/2020, 18:10:04 [Hue] config.json: warning: plugin_map: ignoring unknown key
18/10/2020, 18:10:04 [Hue] homebridge-hue v0.11.77, node v12.16.3, homebridge v3.2.6
18/10/2020, 18:10:04 [Hue] warning: not using recommended node version v12.19.0 LTS
18/10/2020, 18:10:05 [Hue] searching bridges and gateways
18/10/2020, 18:10:10 [Hue] 192.***.***.128: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:10 [Hue] 192.***.***.136: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:10 [Hue] 192.***.***.167: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:10 [Hue] 192.***.***.190: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:10 [Hue] 192.***.***.101: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:10 [Hue] Philips hue: Philips BSB002 bridge v1941056000, api v1.41.0
18/10/2020, 18:10:11 [Hue] Philips hue: 1 accessories
18/10/2020, 18:10:38 [Hue] 192.***.***.128: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:38 [Hue] 192.***.***.136: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:38 [Hue] 192.***.***.167: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:38 [Hue] 192.***.***.190: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:38 [Hue] 192.***.***.101: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:53 [Hue] 192.***.***.128: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:53 [Hue] 192.***.***.136: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:53 [Hue] 192.***.***.167: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:53 [Hue] 192.***.***.190: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:10:53 [Hue] 192.***.***.101: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:08 [Hue] 192.***.***.128: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:08 [Hue] 192.***.***.136: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:08 [Hue] 192.***.***.167: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:08 [Hue] 192.***.***.190: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:08 [Hue] 192.***.***.101: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:23 [Hue] 192.***.***.128: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:23 [Hue] 192.***.***.136: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:23 [Hue] 192.***.***.167: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:23 [Hue] 192.***.***.190: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s
18/10/2020, 18:11:23 [Hue] 192.***.***.101: <IP_ADDRESS>:80: cannot connect: ENETUNREACH - retrying in 15s

Please contact HOOBS support for issues with HOOBS.  See https://github.com/ebaauw/homebridge-hue/issues/694

I see @ebaauw thanks


--bc option does not work

$subj

Hi,
it seems, that --bc option still does not work even with the latest Symbiotic, at least when combined with --prp=memsafety. However, it may be quite useful for verifiaction of Autotools/CMake projects compiled using wllvm.
Sample code:
int main(void)
{
    char arr[1];
    arr[1] = 0;
}

Problem:
$ clang -O0 -c -emit-llvm -o main.bc main.c
$ symbiotic --bc --prp=memsafety main.bc
7.0.0-dev-llvm-9.0.1-symbiotic:88057663-dg:e89761ff-sbt-slicer:fff6245c-sbt-instrumentation:2f9be629-klee:59f3e288
INFO: Starting instrumentation
wrapper: `which slllvm` failed with error code 1

Running DG points-to analysis with inv...
PTA inv done.
PredatorPlugin: Running Predator...
|> predator_wrapper.py --out predator.log --32 predator_in.bc
wrapper: `which slllvm` failed with error code 1
Predator wrapper finished with non-0 exit status
PredatorPlugin: failed to open file with predator output
RESULT: ERROR (Instrumenting the code failed)
ERROR:  == FAILURE ==
Instrumenting the code failed

Symbiotic finds the out-of-bounds array access if the .c is used directly.

The problem here is that sbt-instr segfaults for some reason.

The problem is that the input file has no debugging information, which was required by sbt-instr. Now it should work.

I have tested the fix and in works. Thanks!


Segfault when invoking :python3 command

Steps to reproduce
On Slackware64-current (development branch of Slackware Linux) recent Vim upgrade to version 9.1.0680 causes Vim to segfault when invoking :python3 command. Running this simple command line is enough to reproduce:
$ vim -u NONE -c 'py3 print("foobar")'
Vim: Caught deadly signal SEGV
Segmentation fault

git bisect shows that the problem started from 9.1.0668 patch.
Expected behaviour
The version before the upgrade (9.1.0645) was working without segfaults.
Version of Vim
9.1.0680
Environment
OS: Slackware64-current (dev branch)
glibc 2.40
gcc 14.2
python 3.11.9
Vim built with --enable-python3interp=dynamic
Terminal: KDE Konsole 23.08.5
$TERM: xterm-256color
Shell: bash 5.2.32
Logs and stack traces
Reading symbols from /usr/bin/vim...
[New LWP 6621]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `vim -u NONE -c py3 print("foobar")'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fa974265d5b in PyObject_GC_UnTrack () from /usr/lib64/libpython3.11.so.1.0
(gdb) bt
#0  0x00007fa974265d5b in PyObject_GC_UnTrack () from /usr/lib64/libpython3.11.so.1.0
#1  0x00007fa9742e81db in ?? () from /usr/lib64/libpython3.11.so.1.0
#2  0x00007fa974250fe5 in ?? () from /usr/lib64/libpython3.11.so.1.0
#3  0x00007fa97423a01a in ?? () from /usr/lib64/libpython3.11.so.1.0
#4  0x00007fa9741e062d in PyObject_VectorcallMethod () from /usr/lib64/libpython3.11.so.1.0
#5  0x00007fa9742c54aa in ?? () from /usr/lib64/libpython3.11.so.1.0
#6  0x00007fa9742c4fab in Py_FinalizeEx () from /usr/lib64/libpython3.11.so.1.0
#7  0x00000000006ea34b in python3_end () at if_python3.c:1260
#8  0x000000000070ad47 in getout (exitval=1) at main.c:1755
#9  <signal handler called>
#10 0x00007fa974265f54 in ?? () from /usr/lib64/libpython3.11.so.1.0
#11 0x00007fa9741fda45 in ?? () from /usr/lib64/libpython3.11.so.1.0
#12 0x00007fa974265e94 in ?? () from /usr/lib64/libpython3.11.so.1.0
#13 0x00007fa9742cefb0 in ?? () from /usr/lib64/libpython3.11.so.1.0
#14 0x00007fa9742ced69 in ?? () from /usr/lib64/libpython3.11.so.1.0
#15 0x00007fa974265a71 in _PyObject_GC_New () from /usr/lib64/libpython3.11.so.1.0
#16 0x00007fa974203948 in PyCMethod_New () from /usr/lib64/libpython3.11.so.1.0
#17 0x00007fa97420f590 in ?? () from /usr/lib64/libpython3.11.so.1.0
#18 0x00007fa97420eae7 in PyType_Ready () from /usr/lib64/libpython3.11.so.1.0
#19 0x00007fa974297286 in PyType_FromModuleAndSpec () from /usr/lib64/libpython3.11.so.1.0
#20 0x00000000006dcf0d in AddHeapType (type_object=type_object@entry=0x7f6480 <BufferType>) at /tmp/vim-9.1.0686/src/if_py_both.h:234
#21 0x00000000006e6ee5 in init_types () at /tmp/vim-9.1.0686/src/if_py_both.h:7055
#22 Py3Init_vim () at if_python3.c:2127
#23 0x00007fa9742bc526 in ?? () from /usr/lib64/libpython3.11.so.1.0
#24 0x00007fa9742bc8ee in ?? () from /usr/lib64/libpython3.11.so.1.0
#25 0x00007fa974203da1 in ?? () from /usr/lib64/libpython3.11.so.1.0
#26 0x00007fa974241ff5 in _PyEval_EvalFrameDefault () from /usr/lib64/libpython3.11.so.1.0
#27 0x00007fa97423a00b in ?? () from /usr/lib64/libpython3.11.so.1.0
#28 0x00007fa9741e0ac6 in ?? () from /usr/lib64/libpython3.11.so.1.0
#29 0x00007fa9741e1a8f in PyObject_CallMethodObjArgs () from /usr/lib64/libpython3.11.so.1.0
#30 0x00007fa974254d0a in PyImport_ImportModuleLevelObject () from /usr/lib64/libpython3.11.so.1.0
#31 0x00007fa97424090f in _PyEval_EvalFrameDefault () from /usr/lib64/libpython3.11.so.1.0
#32 0x00007fa97423a00b in ?? () from /usr/lib64/libpython3.11.so.1.0
#33 0x00007fa9742b330a in PyEval_EvalCode () from /usr/lib64/libpython3.11.so.1.0
#34 0x00000000006df050 in Vim_PyRun_String (
    str=str@entry=0x72dd98 "import vim; import sys; sys.path = list(filter(lambda x: not x.endswith('must>not&exist'), sys.path))",
    start=start@entry=257, globals=0x7fa973ff2dc0, locals=0x7fa973ff2dc0) at /tmp/vim-9.1.0686/src/if_py_both.h:264
#35 0x00000000006ea124 in Vim_PyRun_SimpleString (
    str=0x72dd98 "import vim; import sys; sys.path = list(filter(lambda x: not x.endswith('must>not&exist'), sys.path))")
    at /tmp/vim-9.1.0686/src/if_py_both.h:275
#36 Python3_Init () at if_python3.c:1457
#37 0x00000000006ea3a5 in DoPyCommand (cmd=0x3048b274 "print(\"foobar\")", init_range=0x6dd1f0 <init_range_cmd>, run=0x6df1e0 <run_cmd>,
    arg=0x7ffe79935670) at if_python3.c:1499
#38 ex_py3 (eap=0x7ffe79935670) at if_python3.c:1562
#39 0x00000000004fce5b in do_one_cmd (cmdlinep=0x7ffe799355d0, flags=11, cstack=0x7ffe79935820, fgetline=0x0, cookie=0x0)
    at ex_docmd.c:2616
#40 do_cmdline (cmdline=<optimized out>, fgetline=fgetline@entry=0x0, cookie=cookie@entry=0x0, flags=flags@entry=11) at ex_docmd.c:1028
#41 0x00000000004fe3be in do_cmdline_cmd (cmd=<optimized out>) at ex_docmd.c:622
#42 0x000000000070bbe6 in exe_commands (parmp=0x7f9640 <params>) at main.c:3173
#43 vim_main2 () at main.c:790
#44 0x00007fa974829d57 in __libc_start_call_main () from /lib64/libc.so.6
#45 0x00007fa974829e15 in __libc_start_main_impl () from /lib64/libc.so.6
#46 0x00000000004748d1 in _start () at ../sysdeps/x86_64/start.S:115

please show the complete :version output

VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Aug 18 2024 16:58:09)
Included patches: 1-680
Compiled by<EMAIL_ADDRESS>Huge version without GUI.   Is this a recent regression?

Yes, Vim was upgraded to 9.1.0680 on Aug 18. If I revert to previous package (9.1.0645, issued on Jul 31) from the archive, I no longer get a segfault.
As I mentioned in my initial report, when git bisecting, I start getting segfaults from 9.1.0668.

Hm, I don't understand the stack trace and don't know how to fix this

Hmm, is it better to disable Stable ABI on unix-like systems by default?

@audriusk can you compile and test without the stable ABI please?

Built both 9.1.0680 (what's currently in Slackware) and 9.1.0686 (the latest at the moment of writing) using --with-python3-stable-abi=no. Now :version shows +python3/dyn and I no longer get segfaults, I can even bring back plugins which use Python interface and they work without problems.

I can't reproduce this with Vim 9.1.689 +python3/dyn-stable built on Arch Linux but using Debian stable's Python 3.11. (It doesn't reproduce with Arch Linux's Python 3.12 either so I find a Python 3.11 to try.)
@audriusk could you compile Python with debugging symbols and retry?

OK, so I built Vim 9.1.0698 using --with-python3-stable-abi=3.8 (:version shows +python3/dyn-stable) and rebuilt Python 3.11.9, using -ggdb3 -Og for both. Still getting segfaults when invoking :py3 command.
Here's the backtrace from gdb:
[New LWP 350]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `vim -u NONE -c py3 print("foobar")'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  _PyObject_GC_UNTRACK (op=op@entry=0x7fe43bf61880) at ./Include/internal/pycore_object.h:171
171         _PyGCHead_SET_NEXT(prev, next);
#0  _PyObject_GC_UNTRACK (op=op@entry=0x7fe43bf61880) at ./Include/internal/pycore_object.h:171
#1  0x00007fe43c25e4b7 in PyObject_GC_UnTrack (op_raw=op_raw@entry=0x7fe43bf61880) at Modules/gcmodule.c:2242
#2  0x00007fe43c2a6589 in lock_dealloc (self=0x7fe43bf61880) at ./Modules/_threadmodule.c:60
#3  0x00007fe43c18835f in _Py_Dealloc (op=<optimized out>) at Objects/object.c:2390
#4  0x00007fe43c22070b in Py_DECREF (op=<optimized out>) at ./Include/object.h:538
#5  0x00007fe43c2206ba in Py_XDECREF (op=<optimized out>) at ./Include/object.h:602
#6  _PyFrame_Clear (frame=frame@entry=0x7fe43ca4a3f8) at Python/frame.c:141
#7  0x00007fe43c205964 in _PyEvalFrameClearAndPop (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, frame=frame@entry=0x7fe43ca4a3f8) at Python/ceval.c:6406
#8  0x00007fe43c1fc670 in _PyEval_Vector (tstate=0x7fe43c517318 <_PyRuntime+166328>, func=<optimized out>, locals=locals@entry=0x0, args=<optimized out>, argcount=<optimized out>, kwnames=<optimized out>) at Python/ceval.c:6439
#9  0x00007fe43c14d90a in _PyFunction_Vectorcall (func=<optimized out>, stack=<optimized out>, nargsf=<optimized out>, kwnames=<optimized out>) at Objects/call.c:393
#10 0x00007fe43c14d07d in _PyObject_VectorcallTstate (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, callable=callable@entry=0x7fe43bf69080, args=args@entry=0x7ffcb5792db0, nargsf=<optimized out>, kwnames=kwnames@entry=0x0) at ./Include/internal/pycore_call.h:92
#11 0x00007fe43c14d529 in PyObject_VectorcallMethod (name=name@entry=0x7fe43c4f6c00 <_PyRuntime+33440>, args=0x7ffcb5792db0, args@entry=0x7ffcb5792da8, nargsf=<optimized out>, nargsf@entry=9223372036854775809, kwnames=kwnames@entry=0x0) at Objects/call.c:855
#12 0x00007fe43c23d6e0 in PyObject_CallMethodNoArgs (self=<optimized out>, name=0x7fe43c4f6c00 <_PyRuntime+33440>) at ./Include/cpython/abstract.h:107
#13 wait_for_thread_shutdown (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>) at Python/pylifecycle.c:2902
#14 0x00007fe43c23c985 in Py_FinalizeEx () at Python/pylifecycle.c:1764
#15 0x00007fe43c23c958 in Py_Finalize () at Python/pylifecycle.c:1938
#16 0x00000000006a3d96 in python3_end () at if_python3.c:1260
#17 0x00000000006c26a1 in getout (exitval=exitval@entry=1) at main.c:1755
#18 0x000000000054445d in preserve_exit () at misc1.c:2288
#19 0x0000000000575aff in deathtrap (sigarg=11) at os_unix.c:1238
#20 <signal handler called>
#21 _PyObject_IS_GC (obj=obj@entry=0x7913e0 <Error>) at ./Include/object.h:772
#22 0x00007fe43c25ec25 in visit_decref (op=0x7913e0 <Error>, parent=<optimized out>) at Modules/gcmodule.c:452
#23 0x00007fe43c179c81 in dict_traverse (op=<optimized out>, visit=0x7fe43c25ec1c <visit_decref>, arg=0x7fe43c6053c0) at Objects/dictobject.c:3547
#24 0x00007fe43c25ec0d in subtract_refs (containers=containers@entry=0x7fe43c4fd250 <_PyRuntime+59632>) at Modules/gcmodule.c:478
#25 0x00007fe43c25eb68 in deduce_unreachable (base=base@entry=0x7fe43c4fd250 <_PyRuntime+59632>, unreachable=unreachable@entry=0x7ffcb5793530) at Modules/gcmodule.c:1100
#26 0x00007fe43c25e8be in gc_collect_main (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, generation=generation@entry=1, n_collected=n_collected@entry=0x7ffcb5793588, n_uncollectable=n_uncollectable@entry=0x7ffcb5793580, nofail=nofail@entry=0) at Modules/gcmodule.c:1226
#27 0x00007fe43c25e698 in gc_collect_with_callback (tstate=0x7fe43c517318 <_PyRuntime+166328>, generation=1) at Modules/gcmodule.c:1400
#28 0x00007fe43c25e64f in gc_collect_generations (tstate=<optimized out>) at Modules/gcmodule.c:1455
#29 0x00007fe43c25e3a9 in _PyObject_GC_Link (op=op@entry=0x7fe43bf74ea0) at Modules/gcmodule.c:2270
#30 0x00007fe43c25e318 in gc_alloc (basicsize=<optimized out>, presize=<optimized out>) at Modules/gcmodule.c:2290
#31 0x00007fe43c25e2ab in _PyObject_GC_New (tp=tp@entry=0x7fe43c3faca0 <PyCFunction_Type>) at Modules/gcmodule.c:2298
#32 0x00007fe43c185bf1 in PyCMethod_New (ml=ml@entry=0x7fe43c3ffe60 <tp_new_methoddef>, self=self@entry=0xf5a3520, module=module@entry=0x0, cls=cls@entry=0x0) at Objects/methodobject.c:101
#33 0x00007fe43c1969ef in add_tp_new_wrapper (type=0xf5a3520) at Objects/typeobject.c:7184
#34 0x00007fe43c196987 in type_ready_set_new (type=type@entry=0xf5a3520) at Objects/typeobject.c:6381
#35 0x00007fe43c195f1e in type_ready (type=type@entry=0xf5a3520) at Objects/typeobject.c:6465
#36 0x00007fe43c195e9c in PyType_Ready (type=0xf5a3520) at Objects/typeobject.c:6507
#37 0x00007fe43c19b494 in PyType_FromModuleAndSpec (module=0x0, spec=0x7ffcb57939b0, bases=0x7fe43bf59ea0) at Objects/typeobject.c:3574
#38 0x00007fe43c19b01a in PyType_FromSpecWithBases (spec=<optimized out>, bases=<optimized out>) at Objects/typeobject.c:3364
#39 0x00007fe43c19b001 in PyType_FromSpec (spec=<optimized out>) at Objects/typeobject.c:3634
#40 0x00000000006971a3 in AddHeapType (type_object=type_object@entry=0x7b0280 <BufferType>) at /tmp/vim-9.1.0698/src/if_py_both.h:234
#41 0x0000000000697da5 in init_types () at /tmp/vim-9.1.0698/src/if_py_both.h:7055
#42 0x000000000069a11d in Py3Init_vim () at if_python3.c:2127
#43 0x00007fe43c2298be in create_builtin (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, name=name@entry=0x7fe43c67af70, spec=spec@entry=0x7fe43bf72410) at Python/import.c:995
#44 0x00007fe43c229e75 in _imp_create_builtin (module=<optimized out>, spec=0x7fe43bf72410) at Python/import.c:1046
#45 0x00007fe43c18606e in cfunction_vectorcall_O (func=0x7fe43c616610, args=0x7fe43c645948, nargsf=<optimized out>, kwnames=<optimized out>) at Objects/methodobject.c:514
#46 0x00007fe43c14de53 in _PyVectorcall_Call (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, func=0x7fe43c186008 <cfunction_vectorcall_O>, callable=callable@entry=0x7fe43c616610, tuple=tuple@entry=0x7fe43c645930, kwargs=kwargs@entry=0x7fe43c67ae80) at Objects/call.c:245
#47 0x00007fe43c14dd98 in _PyObject_Call (tstate=0x7fe43c517318 <_PyRuntime+166328>, callable=0x7fe43c616610, args=0x7fe43c645930, kwargs=0x7fe43c67ae80) at Objects/call.c:328
#48 0x00007fe43c14dd5e in PyObject_Call (callable=callable@entry=0x7fe43c616610, args=args@entry=0x7fe43c645930, kwargs=kwargs@entry=0x7fe43c67ae80) at Objects/call.c:355
#49 0x00007fe43c205e9b in do_call_core (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, func=func@entry=0x7fe43c616610, callargs=callargs@entry=0x7fe43c645930, kwdict=kwdict@entry=0x7fe43c67ae80, use_tracing=0) at Python/ceval.c:7321
#50 0x00007fe43c204b8b in _PyEval_EvalFrameDefault (tstate=0x7fe43c517318 <_PyRuntime+166328>, frame=0x7fe43ca4a370, throwflag=<optimized out>) at Python/ceval.c:5376
#51 0x00007fe43c1fd096 in _PyEval_EvalFrame (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, frame=frame@entry=0x7fe43ca4a098, throwflag=throwflag@entry=0) at ./Include/internal/pycore_ceval.h:73
#52 0x00007fe43c1fc662 in _PyEval_Vector (tstate=0x7fe43c517318 <_PyRuntime+166328>, func=<optimized out>, locals=locals@entry=0x0, args=<optimized out>, argcount=<optimized out>, kwnames=<optimized out>) at Python/ceval.c:6434
#53 0x00007fe43c14d90a in _PyFunction_Vectorcall (func=<optimized out>, stack=<optimized out>, nargsf=<optimized out>, kwnames=<optimized out>) at Objects/call.c:393
#54 0x00007fe43c14d07d in _PyObject_VectorcallTstate (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, callable=callable@entry=0x7fe43c5d7ce0, args=args@entry=0x7ffcb5793d20, nargsf=nargsf@entry=2, kwnames=kwnames@entry=0x0) at ./Include/internal/pycore_call.h:92
#55 0x00007fe43c14d74d in object_vacall (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, base=base@entry=0x0, callable=0x7fe43c5d7ce0, vargs=vargs@entry=0x7ffcb5793d90) at Objects/call.c:819
#56 0x00007fe43c14dfb3 in PyObject_CallMethodObjArgs (obj=0x0, name=<optimized out>) at Objects/call.c:879
#57 0x00007fe43c22a3b9 in import_find_and_load (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, abs_name=abs_name@entry=0x7fe43c67af70) at Python/import.c:1748
#58 0x00007fe43c22a117 in PyImport_ImportModuleLevelObject (name=name@entry=0x7fe43c67af70, globals=<optimized out>, locals=locals@entry=0x7fe43c67ad80, fromlist=fromlist@entry=0x7fe43c3fb880 <_Py_NoneStruct>, level=0) at Python/import.c:1847
#59 0x00007fe43c20615c in import_name (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, frame=frame@entry=0x7fe43ca4a020, name=0x7fe43c67af70, fromlist=fromlist@entry=0x7fe43c3fb880 <_Py_NoneStruct>, level=level@entry=0x7fe43c4eeca8 <_PyRuntime+840>) at Python/ceval.c:7422
#60 0x00007fe43c201b43 in _PyEval_EvalFrameDefault (tstate=0x7fe43c517318 <_PyRuntime+166328>, frame=0x7fe43ca4a020, throwflag=<optimized out>) at Python/ceval.c:3946
#61 0x00007fe43c1fd096 in _PyEval_EvalFrame (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, frame=frame@entry=0x7fe43ca4a020, throwflag=throwflag@entry=0) at ./Include/internal/pycore_ceval.h:73
#62 0x00007fe43c1fc662 in _PyEval_Vector (tstate=tstate@entry=0x7fe43c517318 <_PyRuntime+166328>, func=func@entry=0x7fe43c659f80, locals=locals@entry=0x7fe43c67ad80, args=args@entry=0x0, argcount=argcount@entry=0, kwnames=kwnames@entry=0x0) at Python/ceval.c:6434
#63 0x00007fe43c1fc5b8 in PyEval_EvalCode (co=0x7fe43bf65680, globals=<optimized out>, locals=0x7fe43c67ad80) at Python/ceval.c:1148
#64 0x000000000069729f in Vim_PyRun_String (str=str@entry=0x6e5d58 "import vim; import sys; sys.path = list(filter(lambda x: not x.endswith('must>not&exist'), sys.path))", start=start@entry=257, globals=0x7fe43c67ad80, locals=0x7fe43c67ad80) at /tmp/vim-9.1.0698/src/if_py_both.h:264
#65 0x00000000006972f9 in Vim_PyRun_SimpleString (str=str@entry=0x6e5d58 "import vim; import sys; sys.path = list(filter(lambda x: not x.endswith('must>not&exist'), sys.path))") at /tmp/vim-9.1.0698/src/if_py_both.h:275
#66 0x00000000006a3b34 in Python3_Init () at if_python3.c:1457
#67 0x00000000006a3c10 in DoPyCommand (cmd=0xf4be274 "print(\"foobar\")", init_range=init_range@entry=0x697d45 <init_range_cmd>, run=run@entry=0x698bf3 <run_cmd>, arg=arg@entry=0x7ffcb5794380) at if_python3.c:1499
#68 0x00000000006a3ded in ex_py3 (eap=0x7ffcb5794380) at if_python3.c:1562
#69 0x00000000004e0667 in do_one_cmd (cmdlinep=cmdlinep@entry=0x7ffcb5794b98, flags=flags@entry=11, cstack=cstack@entry=0x7ffcb5794560, fgetline=fgetline@entry=0x0, cookie=cookie@entry=0x0) at ex_docmd.c:2616
#70 0x00000000004e160a in do_cmdline (cmdline=<optimized out>, fgetline=fgetline@entry=0x0, cookie=cookie@entry=0x0, flags=flags@entry=11) at ex_docmd.c:1028
#71 0x00000000004e2117 in do_cmdline_cmd (cmd=<optimized out>) at ex_docmd.c:622
#72 0x00000000006c1940 in exe_commands (parmp=parmp@entry=0x7b3440 <params>) at main.c:3173
#73 0x00000000006c3921 in vim_main2 () at main.c:790
#74 0x00000000006c5041 in main (argc=5, argv=0x7ffcb5794d78) at main.c:441

Let me know if you need any other info or compiling with additional options.

The stack trace reminds me of https://github.com/python/cpython/issues/116510, but I'm not 100% sure it's the same issue.  (Nor do I fully understand that issue.)

Probably a missing Py_DECREF somewhere. I'd try valgrind / asan, or use rr to figure out what happened to visit_decref's argument.

OK, so I built Vim 9.1.0698 using --with-python3-stable-abi=3.8 (:version shows +python3/dyn-stable) and rebuilt Python 3.11.9, using -ggdb3 -Og for both. Still getting segfaults when invoking :py3 command.

@audriusk  Are you saying that with those compiler flags, it still crashes at 9.1.0698 but not the previous version? That seems quite odd to me. I'm fixing some issues with 9.1.068, but its behaviors should only be different when compiling using higher versions of Python so I'm quite curious.

Previously, the way we called IncRef and DecRef were also a little weird and not properly the stable ABI properly. I fixed it in #15648 (9.1.0724). If you could check using that as well that would be useful because I'm suspecting that the improper implementation of ref counting could have resulted in something being corrupted.

Sorry, I wasn't very clear, what I meant is that enabling stable ABI (after the default was changed to unstable ABI) brought back segfaults for me even with the latest Vim version at the time of writing.
Now I tried building Vim 9.1.0724 with stable ABI enabled, also rebuilt Python 3.11.10 (what's currently in Slackware) with debugging symbols. Got segfault yet again. I won't paste the backtrace, because it's mostly the same (only the addresses differ).
Tried playing with valgrind earlier (as suggested by @lilydjwg; don't know other tools), but this was way over my head to make any use of it.

Hmm, I'm not sure if I'm really equipped to how you debug this since I don't have an easy way to install Slackware myself to replicate the same issue. The callstack does look like it's an issue with refcounting which is why it's plausible that it's related to 9.1.0668, but my change (9.1.0724) should have changed how it works.
Just out of curiosity have you tried other stable ABI versions? Or did you only try 3.8? E.g. did you try setting it to 3.11 or 3.10? (The stable ABI number just has to be equal or lower than the current Python version you have)


added the url_for function for progress bar

A Micro change in the url for progress in the index.html file Templates


v1.62 Firmware installation failed

OS: Mac OS
Problem: instantly (the loading bar did not run at all) show update failed.
Device toggle: cable, mac
Device: K2 US, white backlight

Same problem here... Mac OS Catalina, K6 White leds.

Getting the same error. Were you able to resolve this? @vespina @IzHoBX

Nop. Didn;t want to try anything else, from fears I could brick my keyboard.

same here

I have the same problem , my keyboard is typing random keys tried to reset but no use . Updating the firmware also failed .
Any other ways to resolve this issue


Feature: namespace BQ metadata field when provided

when BQ_METADATA_NAMESPACE= config is set to some value, namespace the kafka offset metadata in BQ i.e, as a RECORD/STRUCT type.
By default, the value will be empty, which means metadata fields will be written as different columns rather than a RECORD/STRUCT type.

@sravankorumilli Please review and merge.


[Bug]: Missing json2html package in requirements

Contact Details
<EMAIL_ADDRESS>What happened?
The json2html package is missing from the requirements and must be manually installed
Version
1.2.7
Relevant log output
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct

Hello @Kacperxxx , sorry to hear that, our team is working to fix that ASAP!

Fixed in version 1.2.8 😎 👍

Thanks!