Make filters optional?

Should we return all classes if no filters are used?
https://github.com/yiisoft/classifier/blob/16b0d8aaa2b4b1f435ccb2b087f2a52e5e43be22/src/Classifier.php#L75-L77

Why do you want to get all classes without any filters?

If classifier will be may parse specific folder only, it is matter.

Either we need to refactor filters.

Why do you want to get all classes without any filters?

Are the specified directories not a filter?

Are the specified directories not a filter?

I mean initial classes to which the filters will aready be applied. Now is include all PHP files from defined directories and use get_declared_classes() for get all classes. In this case directory is not filter.

Make sense, would you implement it, @rustamwin ?

Make sense, would you implement it, @rustamwin ?

#41

Let's separate it

Now is include all PHP files from defined directories and use get_declared_classes() for get all classes. In this case directory is not filter.

See https://github.com/yiisoft/classifier/blob/master/src/Classifier.php#L97-L100


New command: 'pa pcf init'

Fixes issue #952

Coverage remained the same at 100.0% when pulling e843fa7dc5860bcbcfc75dc673cc01ae833eb831 on YannickRe:pa-pcf-init into 062093d21c38eff93987e1e89e5e78da634c8cb1 on pnp:dev.

Nice! We'll review it shortly 👍

Merged manually. Thank you and great to have you with us! 👏


Enforce Validation on any request type

Hey there ,
Thank you for providing this middleware , it's a blessing since i don't have to have to manually do it now. I forked it and modified abit for a project i'm working on .
I would only recommend that for the validation to not rely on the front end headers for the content type. as alot of times those aren't provided and as a result your validation logic will not work.
in this code block , theoretically we should just enforce validation on all 3 types of request types and headers types.
if ctLen > 1 && ctHdr == "application/json" {
			err := mw.HandleJson(c)
			if err != nil {
				return err
			}
		} else if ctHdr == "application/x-www-form-urlencoded" {
			err := mw.HandleXFormEncoded(c)
			if err != nil {
				return err
			}
		} else if strings.Contains(ctHdr, "multipart/form-data") {
			err := mw.HandleMultiPartFormData(c, ctHdr)
			if err != nil {
				return err
			}
		}

or an alternative solution if you think that makes it not elegant , is to enforce it route level , where we can specify which request typeValidator to use ie would look like this kind of.
var xssMdlwr middleware.XssMw
router.POST("",xssMdlwr.HeaderType('application/json'),controller.SomePostFunc)

this way we don't have to rely on the client passed header type.

Hi @baderkha thanks for the suggestion. I haven't worked on this code for some time, so will have to get my head around it again when I get a chance, go with what seems right to you. Feel free to submit a PR and we can get this merged in, try to include a test if possible. Thanks (Sorry for the late reply.)


Register hosted tool with toolname

With non-hosted tools, you can specify a toolname to go along with the path to the docker image (ex. quay.io/test/test2). You cannot do this for hosted tools. This means that you cannot have two hosted tools with the same image provider path. You can also not have one non hosted tool with a given image provider path, and a hosted tool with the same path.
For example, say I have the quay.io image agduncan94/md5sum. I can only use that image for one hosted tool, even though I may use the same image for different tools.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.6
┆Sprint: Seabright Sprint 5 Electric
┆Issue Number: DOCK-394

Undecided as to whether we want to squeeze hosted tools into 1.5.0 or punt to 1.6.0

I was able to confirm that the dockstore name suffix is editable at creation time for hosted tools.
Testing against staging
DockstoreAPI - 1.6.0-beta.0DockstoreUI - 2.3.0-beta.0


"Application Not Responding" almost every time Godot quits

Godot version:

3.1.1
OS/device including version:

MacOS 10.14.3
Issue description:

error.txt
Steps to reproduce:
Open Godot
Quit Godot
Happens both when quitting to project list and just quitting out of godot completely
Minimal reproduction project:

Not sure what the root cause of the error is, but #29134 should hopefully turn it from a hang into a regular crash-on-exit with stack trace

I use godot alternatively in 4 computers + 1 laptop. 2 computer crashes on exit and 2 not. The 2 that crashes, crashes 2 times: first the project manager once a project is selected, later crash godot editor on exit... not to annoying to me, only for confirmation.

Duplicate of #15754.
Looks like old issue.

I have the same issue as reported by @e-e .  If someone creates a pull-request to fix it, I'd be happy to build and test it.

I'll close this as a duplicate of #15754, as this issue seems to be describing the same bug.


User is blocked to proceed for Transaction and Exchange.

Frequency: 100%
App version: Staging build v1.5.2
Repro on: Samsung Galaxy Note 5 (7.0), Samsung Galaxy s5 (6.0.1)
Testing Account<PHONE_NUMBER>/BackupKay
Repro Steps:

Launch the app.
Tap + tab.
Select celo contact user.
proceed for transaction and tap on send button.
Observe “Failure Sending Payment” message is shown

Impact: User is blocked to send money and exchange the cUSD to cGLD.
Investigation:

“Failure Sending Payment” message is shown when user tap on Send button.
Sometime Confirming… text is shown on “Payment Sent” transaction while proceed for transaction and exchange
User is able to send request payment.
Issue is always repro either celo CLI toggle is enabled or disabled

Current Behavior: Confirming… text is shown on “Payment Sent” transaction while proceed for transaction and exchange
Expected Behavior: User should be able to send the payment and exchange the cUSD to cGLD.
Attachment: Blocked_Transaction&Exchange.mp4 (Bug observe at  13 sec)

@jmrossy it is observed that I am able to send transactions and Exchange the cUSD to cGLD or cGLD to cUSD after uninstalled and re-install the app.
I have taken the below logs for the same:
Logs for blockage where the issue was observed : BlockageLogs.log
Logs after reinstalling the app and app is working fine: AfterReinstalltheapp.log

@Lss-Ankit Thanks for sharing the logs! For the future, it would help if you can filter the adb logs to just our app. I can recommend a tool called pidcat which helps greatly with this. The command would be pidcat -t "GoLog" -t "Go" -t "ReactNativeJS" -t RNGeth or pidcat org.celo.mobile.BUILD_VARIANT_HERE

@jmrossy Thanks for the update!! I will provide the logs by filtering the adb command with PID.

@jmrossy Update on Issue:
Verified with Android staging build v1.5.2 (104694505) and found the following:

"Failure Sending payment" error message is shown when a user taps on the "Send" button if a user has given white space in the "For" field while proceeding for payment.

Note: Previously issue was repro randomly.
Attachment: Android_FailureSendingPaymentIssue.mp4 (Bug observed at 26 sec)

Hi @tarikbellamine I have verified this issue using latest Android internal build v1.3.0(1004294316) & Test Flight Build v1.3.0(27). and found issue is fixed
In app keyboard is open when user select any contact
Repro on devices: Vivo V11 pro (10),iPhone 6+(12.4.5)


As a Developer, I want the Rust node to provide all the bootstrapping requirements, so that other nodes can bootstrap from it

Currently the Rust node cannot be used by other nodes to fully perform the ledger synchronization process during bootstrap because the root of the frontier is not kept up to date as the transition frontier advances when more blocks are applied.
Whenever the best tip changes the node needs to check if the root of the frontier changed too and adjusts its internal state accordingly so that it can respond to ledger-related RPC requests with the correct data.
Old stale data needs to be garbage collected too to avoid memory leaks.
Frontier root update logic is described here

Closing in favor of #91 (both are for the same task)


Testing section

Moved VTU to top. since it is official.
Added Jest-Serializer-Vue-TJW
vuenit and vue-unit are both VTU alternatives that haven't been updated since VTU came out. Moved more interesting projects above them.
vue-container is no longer maintained, moved to bottom

@Scrum Merge conflict is resolved. This PR includes organizing this sections so the most relevant projects are moved to the top, and the deprecated/unmaintained are moved to the bottom.

Always add your items to the end of a list. To be fair, the order is first-come-first-serve.

see CONTRIBUTING
We do not single out anyone, everyone is equal here. Please return the list to its original state and add yours link to the end of the list

I understand your reasoning behind why this rule exists generally, to prevent people from doing self-promotion. However it leads to a disorganized mess. You might as well just do it alphabetically so people do not infer meaning from the order. Or, better, actually order them meaningfully, to save people time. Though this ordering takes the time of those maintaining the list, which is what I was trying to help with.

@TheJaredWilcurt I didn’t immediately notice that you made the correction on another line, regarding this as adding your package

I understand your reasoning behind why this rule exists generally, to prevent people from doing self-promotion. However it leads to a disorganized mess. You might as well just do it alphabetically so people do not infer meaning from the order. Or, better, actually order them meaningfully, to save people time. Though this ordering takes the time of those maintaining the list, which is what I was trying to help with.

There are rules, they must be observed otherwise there will be chaos. Putting order in the lists should be done as a separate task without mixing with the addition of


Read only MySQL (MongoDB BI connector) results in backtrace

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

I am trying to use SuperSet to connect to an instance of the MongoDB BI connector which presents a read-only MySQL server, supporting only the commands given in[1]. I believe this should work, but unfortunately the database fails to be added with a backtrace given below.
[1] https://docs.mongodb.com/bi-connector/master/supported-operations/
Superset version
0.17.6. Full output of pip freeze for the virtualenv below. This is on RHEL7 using the python 2.7 software collection. Same end result if using the python 3.5 software collection.
alembic==0.9.1
amqp==1.4.9
anyjson==0.3.3
appdirs==1.4.3
Babel==2.4.0
backports.shutil-get-terminal-size==1.0.0
billiard==<IP_ADDRESS>
boto3==1.4.4
botocore==1.5.47
celery==3.1.23
cffi==1.10.0
click==6.7
colorama==0.3.9
cryptography==1.7.2
decorator==4.0.11
docutils==0.13.1
enum34==1.1.6
Flask==0.12.1
Flask-AppBuilder==1.8.1
Flask-Babel==0.11.2
Flask-Cache==0.13.1
Flask-Login==0.2.11
Flask-Migrate==2.0.3
Flask-OpenID==1.2.5
Flask-Script==2.0.5
Flask-SQLAlchemy==2.0
Flask-Testing==0.6.2
Flask-WTF==0.14.2
future==0.16.0
futures==3.1.1
gunicorn==19.7.1
humanize==0.5.1
idna==2.5
ipaddress==1.0.18
ipython==5.3.0
ipython-genutils==0.2.0
itsdangerous==0.24
Jinja2==2.9.6
jmespath==0.9.2
kombu==3.0.37
Mako==1.0.6
Markdown==2.6.8
MarkupSafe==1.0
mysqlclient==1.3.10
numpy==1.12.1
packaging==16.8
pandas==0.19.2
parsedatetime==2.0
pathlib2==2.2.1
pexpect==4.2.1
pickleshare==0.7.4
prompt-toolkit==1.0.14
ptyprocess==0.5.1
pyasn1==0.2.3
pycparser==2.17
pydruid==0.3.1
Pygments==2.2.0
PyHive==0.3.0
pyparsing==2.2.0
python-dateutil==2.6.0
python-editor==1.0.3
python-openid==2.2.5
pytz==2017.2
requests==2.13.0
s3transfer==0.1.10
sasl==0.2.1
scandir==1.5
simplegeneric==0.8.1
simplejson==3.10.0
six==1.10.0
SQLAlchemy==1.1.9
SQLAlchemy-Utils==0.32.14
sqlparse==0.2.3
superset==0.17.6
thrift==0.10.0
thrift-sasl==0.2.1
traitlets==4.3.2
wcwidth==0.1.7
Werkzeug==0.12.1
WTForms==2.1

Expected results
Database is added as new (read only) data source
Actual results
The following traceback occurs:
/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/default.py:305: SAWarning: Exception attempting to detect unicode returns: ProgrammingError('(_mysql_exceptions.ProgrammingError) (1064, "parse sql \'SELECT CAST(\'test plain returns\' AS CHAR(60)) AS anon_1\' error: syntax error at position 42")',)
  "detect unicode returns: %r" % de)
/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/default.py:305: SAWarning: Exception attempting to detect unicode returns: ProgrammingError('(_mysql_exceptions.ProgrammingError) (1064, "parse sql \'SELECT CAST(\'test unicode returns\' AS CHAR(60)) AS anon_1\' error: syntax error at position 44")',)
  "detect unicode returns: %r" % de)
/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/default.py:305: SAWarning: Exception attempting to detect unicode returns: ProgrammingError('(_mysql_exceptions.ProgrammingError) (1064, "parse sql \'SELECT CAST(\'test collated returns\' AS CHAR CHARACTER SET utf8) COLLATE utf8_bin AS anon_1\' error: syntax error at position 55 near character")',)
  "detect unicode returns: %r" % de)
2017-05-11 15:56:43,490:ERROR:root:(_mysql_exceptions.OperationalError) (1105, 'statement *parser.Rollback not supported')
Traceback (most recent call last):
  File "/opt/superset27/lib/python2.7/site-packages/superset/views/core.py", line 1343, in testconn
    engine.connect()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2091, in connect
    return self._connection_cls(self, **kwargs)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 90, in __init__
    if connection is not None else engine.raw_connection()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2177, in raw_connection
    self.pool.unique_connection, _connection)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2151, in _wrap_pool_connect
    e, dialect, self)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1465, in _handle_dbapi_exception_noconnection
    exc_info
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2147, in _wrap_pool_connect
    return fn()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 328, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 766, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 516, in checkout
    rec = pool._do_get()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 1138, in _do_get
    self._dec_overflow()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 66, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 1135, in _do_get
    return self._create_connection()
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 333, in _create_connection
    return _ConnectionRecord(self)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 461, in __init__
    self.__connect(first_connect_check=True)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/pool.py", line 661, in __connect
    exec_once(self.connection, self)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/event/attr.py", line 246, in exec_once
    self(*args, **kw)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/event/attr.py", line 256, in __call__
    fn(*args, **kw)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 1331, in go
    return once_fn(*arg, **kw)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/strategies.py", line 181, in first_connect
    dialect.initialize(c)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/dialects/mysql/base.py", line 1682, in initialize
    default.DefaultDialect.initialize(self, connection)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 266, in initialize
    self.do_rollback(connection.connection)
  File "/opt/superset27/lib/python2.7/site-packages/sqlalchemy/dialects/mysql/base.py", line 1575, in do_rollback
    dbapi_connection.rollback()
OperationalError: (_mysql_exceptions.OperationalError) (1105, 'statement *parser.Rollback not supported')

Steps to reproduce

Install and run superset and the mysqlclient python packages
Try adding a new database under Sources, entering a URI of the form mysql://uname:passwd@bicon.domain.com:3307/somedatabase
Click test connection
Backtrace above results

Digging in further, this boils down to the BI connector not supporting a sufficient set of SQL-99 commands for the MySQL SQLAlchemy DBAPI layer to work - the lack of TRANSACTION support in particular. I'll close this, as I don't think it can be fixed by SuperSet devs.

Hey @jonathanunderwood ! I'm trying to to connect my superset instance to a mongodb bi connector. I'm having the same issue as you. Do you have any advice for me? Thanks!

Hey @jonathanunderwood ! I'm trying to to connect my superset instance to a mongodb bi connector. I'm having the same issue as you. Do you have any advice for me? Thanks!

@aguspina I gave up. I contacted MongoDB support at the time and asked them to add the required TRANSACTION support for this, but that was rejected at the time, as the point of the BI connector is meant to only provide read functionality. That was 3 years ago, and I've moved on to other technologies now for that use case. Sorry to be of no help to you :(


Add a side Dockerfile.multi-stage which will build prometheus inside …

This will allow anyone to build prometheus easily without any building environment.
Combined this with a quay.io account and you'll have ready to test images at your disposal
for all your development branches.
Signed-off-by: Sylvain Rabot<EMAIL_ADDRESS>

Thanks for your PR. If you're looking to improve the Prometheus build system you can find it at https://github.com/prometheus/promu

If you wish to develop and maintain your own build system for building your own images of Prometheus you are free to do so. We already have a build system that covers our needs, so are not willing to maintain an additional build system on top of that. We only have limited resources, so cannot support every possible way in which someone may wish to operate Prometheus.

There is absolutely nothing to maintain, It does a simple make build and copies the resulting binary inside a fresh docker image.

This is an independent new build system, which for consistency would have to be copied to all other Go repositories in this organisation as this repo acts as a template for build purposes. We will inevitably get PRs and other changes to this file as things change, which will need to be reviewed, and then those changes propagated to all other Go repos. On top of that we'd get support request for this new system.
No change is free, and any new feature like this implies future ongoing support and maintenance costs.
What I'd suggest is maintaining this in your own fork of the repo, as that is where you want to apply this.

This would indeed be also useful for all the software that are intended to be ran inside docker (i.e. : alertmanager, node_exporter ... etc).
And like I said it is based on make build so you would have as much support request as you would have if make build outputs where to change.
This is a 33 lines sequential script with absolutely no complexity, the "support" overhead of this is near zero.
Anyone with the amount of skill needed to make the smallest change to prometheus that would use this to build images would be able to fix it if it were to be broken.
So please spare me the support overhead excuse cause it does not outweigh the fact that this would ease and fasten building and testing docker prometheus images for everyone.

It's not a build system, it's a convenient tool to ease development and testing.
With this I would have been able to test #4202 before you merge it to master and break everything ...


Implement POST /v1/chains/:chainId/safes/:safeAddress/messages

Closes #256
(Please review: https://github.com/5afe/safe-client-gateway-nest/pull/279 first)
Adds the POST endpoint /v1/chains/:chainId/safes/:safeAddress/messages

Unit (controller) tests were added for the route
OpenAPI specification was added.

Coverage: 86.611% (-2.2%) from 88.851% when pulling 79825152de949916305101bed72de3e1c10e5037 on post-messages into 482300bef1680a0e3bf56178387ffc8cba3a4029 on main.

@hectorgomezv If this is based on another branch you can target that branch (instead of main). This makes it easier to review as it should only show the changes added on top of the branch which you depend on.

@hectorgomezv If this is based on another branch you can target that branch (instead of main). This makes it easier to review as it should only show the changes added on top of the branch which you depend on.

@hectorgomezv If this is based on another branch you can target that branch (instead of main). This makes it easier to review as it should only show the changes added on top of the branch which you depend on.

Thanks, I'll do it. I was rebasing manually but as you said is harder to review (that's why this PR is still on draft 😅)


Nuru/few flow

Hi,
Attached contained few annotations that i added following the error trail for your perusal.

'Object' as a type is not concrete. It helps nothing.
We have concrete types for most of these, and for whichever we don't need to be added.


Additional parameters for keystone

This change introduce new parameters for keystone resource:

authProtocol - 'http' or 'https' part of auth url which instructs
clients to use encrypted connection or plain text
region - defines region used by keystone server and clients
projectDomain and userDomain - instructs clients which domain should
be used

Those parameters are required when external keystone is in use to
properly configure clients in cluster. In that case keystone resource is
a source of information about external cluster and is not directly
managed by controler. It is external provisioner responsibility to mark
keyston resource active and set appropriate IP address.
Jira: CEM-17834

recheck

recheck ha


Version flag

Description of the change:
This PR adds a version flag to the operator-sdk scorecard subcommand which will support
the ability of the end user to specify which version of the scorecard they want to run.
With this flag added, typical usage in code looks like:
    if schelpers.IsV1alpha2() {
            // v1alpha2 logic
    }

The version command option is allowed on the scorecard CLI command line or
within the scorecard configuration file.
If not set, the version value is v1alpha1 which represents the current scorecard implementation.
This PR includes code to validate the version:  v1alpha1, v1alpha2 being the valid choices
When a user specifies an invalid version an error is reported as follows:
    $ operator-sdk scorecard --version foomatic
    Error: invalid scorecard version (foomatic); valid values: v1alpha1, v1alpha2
    Usage:
      operator-sdk scorecard [flags]

This PR provides the version implementation within the schelpers package can can imported within the scorecard and scplugins packages when needed.
The PR includes a unit test which tests the version validation logic.
Motivation for the change:
This PR supports a future scorecard implementation and allows the scorecard to support different implementations by switching upon the requested version.

/test e2e-aws-subcommand
/test e2e-aws-ansible

/test e2e-aws-ansible

If the goal here is to create a flag in order to keep 2 implementations of the scorecard ( the old one and the new one ) then IMHO --latest or --new would be enough, do not you agree? Also, should not better change the current implementation instead of creating more than one version? if we have the old and the new one then we will need to keep maintained both.
c/c @estroz

@camilamacedo86 The ability to pin scorecard to a particular version (v1alpha2) is what I was going for here, this way people can migrate to or try out the new output version if they want to and when they want to.  The default is still v1alpha1.  At some point, people might want this to default to the latest (e.g. v1alpha2), but I would consider that a future PR to make that default change.
I'm just starting to work on the actual implementation of the v1alpha2,  the goal is to have a single scorecard implementation as today, but switch in the current code when required to achieve the v1alpha2 output format.

/retest

HI @jmccormick2001,
Really tks for the clarifications. If we will move forward with so shows just missing add a new flag in the docs and geat job 👍 by the way.

/test e2e-aws-helm

/test e2e-aws-go

/test e2e-aws-subcommand

/test e2e-aws-helm
/test e2e-aws-go

/test e2e-aws-go

/test e2e-aws-go

/test e2e-aws-go


Correct Packing Pattern (Support C# & C++/WinRT)

[x] Fix .nuspec/.targets To Support C# and C++/WinRT
[x] Use Generic.xaml , automatic merging of xaml resource files
[x] Fix WinUI3 x86 __cdecl -> __stdcall

After the changes, a newly created C++UWP project is not able to run.

I am no longer able to build the UWPCsharpExample project, and got these errors
1>------ Build started: Project: UWPCSharpExample, Configuration: Debug x64 ------
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763). Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm-aot. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm64-aot. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x64. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x64-aot. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x86. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.
NU1202: Package WinUIEssential.UWP 1.2.7 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x86-aot. Package WinUIEssential.UWP 1.2.7 does not support any target frameworks.

I build the UWPPackage nuget first, then install to the UWPCsharpExample project.


Improve API for setting Configurations as producers or consumers

I find it very difficult to remember how to configure Configurations as producers and consumers The existing properties, isCanBeResolved and isCanBeConsumed are vague (they seem like synonyms to me). The documentation can help - particularly the table in this page - but finding it is always difficult because it doesn't have a HTML link and it's buried in the middle of a large page.
I'd like the API to be changed so it's more descriptive and clear, and the Javadoc updated.
I'd also like the old example for JaCoCo to be updated and re-instated https://docs.gradle.org/7.3/samples/sample_jvm_multi_project_with_code_coverage.html. It was removed because of the new plugin, but knowing how to share artifacts between plugins is still useful.
Expected Behavior
What I think would be best is to do away with the multiple booleans, and replace them with an enum. Under the hood, there can still be the boolean flags.
/**
 * <insert more docs here>
 *
 * See: https://docs.gradle.org/7.5.1/userguide/declaring_dependencies.html#sec:resolvable-consumable-configs
 */
enum class ConfigurationRole(
    val isCanBeConsumed: Boolean,
    val isCanBeResolved: Boolean,
) {
    /** Bucket of dependencies */
    INTERNAL(false, false),
    /** Exposed to consumers */
    PRODUCER(true, false),
    /** Resolve for certain usage */
    INCOMING(false, true),
    /** Legacy, don’t use */
    LEGACY(true, true),
    ;
}

In the Kotlin DSL this is easy to apply already, with an extension var.
val jacocoAggregateSource: Configuration by configurations.creating {
  role = ConfigurationRole.PRODUCER
}

var Configuration.role: ConfigurationRole
    get() = ConfigurationRole.get(isCanBeResolved, isCanBeConsumed) // helper function
    set(value) {
        isCanBeConsumed = value.isCanBeConsumed
        isCanBeResolved = value.isCanBeResolved
    }

Another option is to create some helper methods. On that helper method, I'd like there to be descriptive Javadoc, and a direct link to the pertinent documentation.
val jacocoAggregateSource: Configuration by configurations.creating {
  isProducer() // new helper method
}

/**
 * Mark this [Configuration] as a 'producer' that exposes artifacts and their dependencies for consumption by other
 * projects
 *
 * See: https://docs.gradle.org/7.5.1/userguide/declaring_dependencies.html#sec:resolvable-consumable-configs
 */
fun Configuration.isProducer() {
    isCanBeResolved = false
    isCanBeConsumed = true
}

Current Behavior
It's difficult to create configurations with the correct flag. It's difficult to find the documentation. The words 'resolvable' and 'consumable' seem like synonyms, I don't really get the difference between them.
Context
I'm trying again to share outputs between projects in a safe way.

Yes, this is something we want to do, but it's quite a large change and not actually planned for the short term.


Images for the Multi-CD Episodes

The multi CD episodes (100, 125, 150, 175, 200...) are all missing their individual covers. There are some noticeable differences and I personally like to keep copies of both the full 3 hour episodes as well as each part with its respective cover.
e.g:
Ep100 Cover as provided by dreimetadaten

EP100A provided with the CD:

I doubt that there will be many / any good digitized copies of the individual parts but it would be nice to provide them in the cases where they do exist (or even lower quality scans for the ones that don't). This problem is less prominent with ep 200 and a non problem with ep 225 since 200 seems to only change the letter for each cover while 225 seems to only have a single cover.

I doubt that there will be many / any good digitized copies of the individual parts

That was the main reason I initially decided against including them, it's not easy to find high quality digital sources.
IIRC I do have some good versions, especially for 100 (it's what I used to superimpose the two smaller images left and right, like in the original).
I'm unable to check my sources at the moment, but will be some time around next week.
But I agree that these should be included for completeness sake, even if they don't meet my "quality standard".
The same goes for multi-CD special episodes (e.g. "… und der dreiTag").
I appreciate any help in finding high quality sources!

Wonderful, I went through the effort of finding the highest quality versions of each cover 100, 125, 150, 175 and as such can provide those. It would be nice to get digital copies of the originals but I think we will just have to try and find the highest quality scans.
Here is the collection of covers I have collected. (175 are the digital copies I think)
100,125,150,175 Cover.zip

Totally forgot this …
Someone sent me an email in June 2023 which also included a mix of scans and digital sources they created/edited for 100, 125, 150, 175 and 200. Those are also quite good:
100 - Toteninsel.zip
125 - Feuermond.zip
150 - Geisterbucht.zip
175 - Schattenwelt.zip
200 - Feuriges Auge.zip

Betrifft die Teile folgender Folgen:

[ ] Serie/100 (3 Teile)
[ ] Serie/125 (3 Teile)
[ ] Serie/150 (3 Teile)
[ ] Serie/175 (3 Teile)

Fehlende Coverbilder für DiE DR3i "Das Seeungeheuer" (Teile 1 & 2) wurden ergänzt mit #60


@schematics/angular typescript dependency is still 2.6

Bug Report or Feature Request
- [x] bug report
- [ ] feature request

Area
- [ ] devkit
- [x] schematics

Versions
node --version : v9.11.1
npm --version : v5.6.0
Linux Debian 9.4
Repro steps
git clone git@github.com:noelmace/nx.git
cd nx
git checkout 9c1b1bf0aa2410c6ba32
yarn install
yarn build

The log given by the failure
packages/bazel/src/utils/ast-utils.ts(32,38): error TS2345: Argument of type 'ts.SourceFile' is not assignable to parameter of type 'ts.SourceFile'.
  Types of property 'kind' are incompatible.
    Type 'ts.SyntaxKind.SourceFile' is not assignable to type 'ts.SyntaxKind.SourceFile'. Two different types with this name exist, but they are unrelated.
packages/bazel/src/utils/ast-utils.ts(206,38): error TS2345: Argument of type 'ts.SourceFile' is not assignable to parameter of type 'ts.SourceFile'.
packages/bazel/src/utils/ast-utils.ts(233,32): error TS2345: Argument of type 'ts.SourceFile' is not assignable to parameter of type 'ts.SourceFile'.

Desired functionality
Upgrade @schematics/angular typescript dependency to 2.7.2 in order to play well with angular v6 and therefore @angular/cli v6.
Mention any other details that might be useful
See https://github.com/noelmace/nx/commit/9c1b1bf0aa2410c6ba32c7787006c847bb8faf40 for the complete list of conflicting dependencies.
The code source corresponding to the failure's log is https://github.com/noelmace/nx/blob/9c1b1bf0aa2410c6ba32c7787006c847bb8faf40/packages/bazel/src/utils/ast-utils.ts
yarn list --pattern typescript :
yarn list v1.5.1
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>Done in 1.11s.

FYI : if nobody is already on this, I would be happy to (try to) do it. It would be my first PR on devkit so if you have any advice ...


Make the code "enhancing" the bundle more maintainable and extensible

User Story
As a RS developer, I want a maintainable and extensible way of handling things like enhancing the bundle metadata and handling the birthtime.
Description/Use Case
There may be other cases where post translation to FHIR we need to parse the HL7 message, do some work on it to get a value, and then update the output FHIR message before completing the conversion. We want to figure out a more maintainable and extensible way to handle this.
Risks/Impacts/Considerations
Dev Notes
Arnej's idea: Instead of updating translate every time we need to do something similar, I'm imagining a separate class that handles this. The class could be called something like BundleEnhancer and usage could be BundleEnhancer.run() and the run method would run all the methods like handleBirthTime. This way at least we don't have to update translate every time and then we can expand on this mechanism and make it even better, maybe. Also this way we are acknowledging that our business case requires us to do some sort of post conversion cleanup (I don't like cleanup hopefully we can think of a better word) and we can split this functionality out to be its own thing so everything is more cohesive.
Another note here is we may have a fork of the LinuxForHealth HL7 -> FHIR converter soon, and a lot of these solutions, like handleBirthTime, should be addressed there whenever possible and BundleEnhancer or its equivalent solution should be used as a last resort.
Acceptance Criteria

[ ] The code that "enhances" the bundle in moved out of the translate function
[ ] The code is now extensible

Hey team! Please add your planning poker estimate with Zenhub @arnejduranovic @jack-h-wang @JessicaWNava @JFU-NAVA-PBC @jimmyfagan @mkalish @thetaurean

@arnejduranovic @avnieldravid Please revisit priority.


ERR wrong number of arguments for 'spop' command

when use the command  spop foo 3
response :ERR wrong number of arguments for 'spop' command
why?

Hi @chuanqi
I tested the command on a Linux machine to verify if this is a Windows-specific issue or not.
On Linux it also returns the "wrong number of arguments" error.
Since we don't make fixes/changes in the original Redis code, you should ask in the official Redis forum.
Thank you.

Cite: The count argument will be available in a later version and is not available in 2.6, 2.8, 3.0

Thanks @BridgeAR, I'm closing the issue.

@BridgeAR thanks.


Refactor conv

Decouple the environment for bound vars (de Bruijn) and free vars (named), by defining an ExprConvCtxt trait
Avoid threading the number of binders by explicitly tracking layers in the bound variable environment

I hope this isn't too annoying @ranjitjhala, but I think these changes simplify the code quite a bit and they make it easier to implement the changes in https://github.com/liquid-rust/flux/pull/278

No worries I think I will probably circle back to take an entirely fresh
crack at #278
On Fri, Dec 30, 2022 at 10:29 PM Nico Lehmann @.***>
wrote:

I hope this isn't too annoying @ranjitjhala
https://urldefense.com/v3/__https://github.com/ranjitjhala__;!!Mih3wA!D63R0hbYOxV_mMZHoftqIlOk2yi1KEjQtqkp27SkM9V1miMylR98gkD0pg4_wPZ7TPpYSlNP9h_zrTtT5yu5e78-$,
but I think these changes simplify the code quite a bit and they make it
easier to implement the changes in #278
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/278__;!!Mih3wA!D63R0hbYOxV_mMZHoftqIlOk2yi1KEjQtqkp27SkM9V1miMylR98gkD0pg4_wPZ7TPpYSlNP9h_zrTtT5wwsFfWM$
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/279*issuecomment-1368172966__;Iw!!Mih3wA!D63R0hbYOxV_mMZHoftqIlOk2yi1KEjQtqkp27SkM9V1miMylR98gkD0pg4_wPZ7TPpYSlNP9h_zrTtT56sPSWeD$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAMS4OCUS4YUXZICFGFD5O3WP7HEHANCNFSM6AAAAAATNMKXXU__;!!Mih3wA!D63R0hbYOxV_mMZHoftqIlOk2yi1KEjQtqkp27SkM9V1miMylR98gkD0pg4_wPZ7TPpYSlNP9h_zrTtT54HsGkxi$
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add 'unpack-dir' option to unpack specific directory

The unpack option is for unpacking files. In some scenarios, it's not suffice. For example(part of maxogden/electron-packager#114), when packaging an app using a flash plugin to asar on OS X, there is no way to unpack PepperFlashPlayer.plugin since the flash plugin is a directory on OS X. So with this patch, we can easily make the asar app work well with flash plugin.

:+1:


TypeError: null is not an object (evaluating 'ReactNativeBlobUtil.DocumentDir')

I am using react-native-blob-util because rn-fetch-blob has not been updated since 5 years ago and I have this error which happens with rn-fetch-blob too:
TypeError: null is not an object (evaluating 'ReactNativeBlobUtil.DocumentDir')
I am using react-native 0.68.1 and this only happened on android and not iOS.
If someone has already faced the issue.
"react-native": "0.68.1",
"react-native-blob-util": "^0.16.0",

I'm also seeing this issue. Strangely, the problem only happens when I run react-native run-android for an emulator, but install the resulting build to another. Installing to the initial emulator works fine.

I encountered this as well. It looks like auto linking isn't configured properly for android. I believe to fix this, react and react-native need to be added as dev and peer dependencies to this project. Something like this:
    "devDependencies": {
        ...
        "react": "16.13.1",
        "react-native": "^0.68.2"
    },
    "peerDependencies": {
        "react": "*",
        "react-native": "*"
    }

To work around this before it's fixed, you can configure manually linking.  Of course, those instructions aren't quite right either. They reference the old class and package names. Rename :react-native-fetch-blob to :react-native-blob-util and com.RNFetchBlob.RNFetchBlobPackage to com.ReactNativeBlobUtil.ReactNativeBlobUtilPackage and you should be good.

fyi the repo I'm working on has an unconventional setup, but ai fixed this issue by running react-native bundle

Can you confirm it's working with the peerDependencies? @rusty120  @filiptdz
Porlbme is I wasn't able so far to reproduce it myself

@RonRadtke My best guess is this isn't a problem caused by this library, but instead any other issue that causes the React Native bundler not to resolve the native modules. A good solution might be to update it not to crash when the native module isn't found, so people aren't drawn to the conclusion that there may be a problem with this library

@RonRadtke I can confirm the changes above resolve the issue for me. I pulled the repo and tested it locally. I ended up simply going with manual linking however to avoid having to fork the repo in the short term. If you use npx create-react-native-library ... to create a new node modules you'll notice the template includes react and react-native as peer dependencies, so I'm pretty sure they should be there.
I suspect the issue doesn't happen if you have react-native installed globally or use npx react-native bundle to build, which is maybe why not as many people have been tripped up by this?

I have the same issue with react-native-blob-util 0.13.7 and react native 0.64.3
I don't understand why it occurs without updating anything. It was working before

I tried both adding peerDependencies and manually linking.. neither works for me. Maybe it's because I'm using expo

The library doesn't work with expo since it is using native code

Hey together,
had some problems with react-native-pdf which is relying on this library as it seems.
Anyhow, whoever uses Expo might be interested in how to run native code - might help resolving your issues:
https://github.com/wonday/react-native-pdf/issues/624#issuecomment-1367842701

This is still occurring, running on RN .70+ Just recently switched to this library from fetch, and i get undefined galore. I don't understand why not include RN dependencies if it is a RN package, if it resolves it?


Fixed SetFileTime for mac.

Fixes #3508

@lemonmojo Ah, got it. The creation time must be before modification and access time. Since creation time is not handled the times are too old for the system.

@akallabeth I see... Any news on a new PR? thx!


Support URL links in LSP hover popups.

For example, It would be nice to have links to pages in the sway reference that people could click on to find out more information.
Below is an example from rust-analyzer rust.

This is supported, although not many of the sway docs have links.


Implement Lovelace Spell Animation

When the player opens the secret Lovelace Library door using the spell, the corresponding animation should play (player using wand/spell affecting world). The door should then be unlocked allowing the player to walk through.

@rmkubik Ryan will clarify the technical requirements for this.

Player animations are split into two parts.

The actual player pulling out the wand animation frame
The running magic spell effect animation

We can see this implemented for the flamethrower in the Forest of Open Source.
Callouts from the above implementation:

This code checks the player's facing

We should use player.facing === 'UP'/'LEFT'/'RIGHT'/'DOWN' now.

Creates a game sprite dynamically with the directionally appropriate flamethrow effect
Then we trigger "useTool" to start the player animation, we'll want to useTool "wand" for our implementation
After the animation is done, we clean up after ourselves by removing the animation sprite

This function can be used wherever in scripting to play a spell animation.

In working on this solution:
If there are commonalities in this implementation and the flamethrower implementation, we should propose new world functions that might make creating entities dynamically easier or implementing more complex tools easier.

FYI, I removed one of the custom properties on the secret library door at the very end of the Lovelace Tower map. The door should be interactable even when !completedObjectives["api-04-remote-and-local"] but should only be spellable when completedObjectives["api-04-remote-and-local"]. There is a conversation that launches if the player tries to interact with the door before completing the objective that tells them to complete it to get the spell.

@rmkubik Is there a particular sprite/sprites we wanted to use for this? I know we have the sparkles appear above the door when it's interactable, but for the magic spell effect animation, what else did we want to use there?

We wanted to use these spell effects, the way we do the flamewthrower in the open source forest:
https://github.com/TwilioQuest/twilioquest-base/blob/main/tilesets/Operator_ToolEffects_UpDown.png

@MarvJohnson Playing through with some last minute testing:

The spellable lovelace shine marker should not be on the Lovelace door from the lovelacehallway to the lovelace tower map, since the player doesn't need a spell to open it. I noticed it appears when the door opening animation plays.
door from lovelace tower to library is currently interactable (exclamation point appears) but the player cannot do anything. Either we should make the door completely un-interactable until they complete obj 4, or we should make sure the exclamation point interaction brings up the library-door conversation.

@MarvJohnson Playing through with some last minute testing:

The spellable lovelace shine marker should not be on the Lovelace door from the lovelacehallway to the lovelace tower map, since the player doesn't need a spell to open it. I noticed it appears when the door opening animation plays.
door from lovelace tower to library is currently interactable (exclamation point appears) but the player cannot do anything. We should either make the door completely un-interactable until they complete obj 4, or we should make sure the exclamation point interaction brings up the library-door conversation (it's possible you have an outstanding PR that resolves this. If so, apologies!)

These should be fixed here and here

In working on this solution:
If there are commonalities in this implementation and the flamethrower implementation, we should propose new world functions that might make creating entities dynamically easier or implementing more complex tools easier.

+1 on this. The implementations ended up being practically the sam. I'm sure there's a way we could reduce the overhead for achieving similar features moving forward!

Closing this as it was covered in PR #94!


HBASE-25660 Print split policy in use on Region open (as well as spl…

…it policy vitals)
Add a toString to all split policy implementations listing name and
vitals. Use this toString in the Region open message. Ditto for flush
policy for the Region.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 40s
branch-2 passed

+1 :green_heart:
compile
3m  7s
branch-2 passed

+1 :green_heart:
checkstyle
1m 10s
branch-2 passed

-1 :x:
spotbugs
2m  8s
hbase-server in branch-2 has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
checkstyle
1m 11s
hbase-server: The patch generated 0 new + 171 unchanged - 2 fixed = 171 total (was 173)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 33s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

39m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3044

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux ef8ff46778de 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af8dc2e4df

Default Java
AdoptOpenJDK-1.8.0_282-b08

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

Max. process+thread count
96 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 17s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

+1 :green_heart:
shadedjars
6m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
137m 42s
hbase-server in the patch passed.

166m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 300b2d933b7a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af8dc2e4df

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/testReport/

Max. process+thread count
3973 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2 passed

+1 :green_heart:
compile
1m  0s
branch-2 passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
212m 48s
hbase-server in the patch passed.

240m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3044

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3013e9bba907 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af8dc2e4df

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/testReport/

Max. process+thread count
2682 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3044/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Modify CLI tag page

This PR makes a couple of chnages to the CLI tag documenation. One is related to a commit on https://github.com/openmicroscopy/openmicroscopy/pull/4061 allowing tags to be created without a description.
The second relates to deleting tags and is in response to https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=7884&p=16139#p16137
A question regarding this second commit is whether the examples should be added to the delete page and a simple link be provided or if it is okay to have this explanation of one aspect of a command on anthor command page.

You can use ref mark-up to add a pointer to new the new section on the delete page.
Add .. _deleting_tags above your new heading and then you can use ``:ref:deleting_tags to add a reference on the delete page and it will automatically use your heading for the link text.

There's a reference to TagAnnotation in the first section of https://www.openmicroscopy.org/site/support/omero5.1-staging/users/cli/delete.html, I'd stick the ref at the end of "Additionally, objects of the three annotation types, FileAnnotation, TagAnnotation and TermAnnotation are not deleted by default when the objects to which they are linked are deleted."

Changes to this page look fine on staging, probably good to merge once the ref is added.

This will need rebasing to develop once merged btw

@hflynn, thanks. I'll add in the reference.
Re https://github.com/openmicroscopy/ome-documentation/pull/1269#issuecomment-133019341, this is not quite the same thing as on the tag page it is about directly deleting tags rather than as a side-effect of deleting other objects that may be tagged.
The PR this relates to has not yet been merged - more chnages migh be added to this if that PR is chnaged. The develop PR has yet to be opened (which is slightly different) but yes I'll rebase this as soon as possible.

Fine to add the ref somewhere else.
If you'd rather do a separate PR for develop to match the different code changes (rather than rebase and then add further), go ahead, I didn't realise there were going to be different code changes there.

should be good to merge once everything is green


Changing website content

This PR involves changing the title and header of the website to "What's My Sentiment?". Along with this, a few changes were made to the description to match the current MVP.

I just added another feature to this PR which is making the sentiment analyzer output a bit more pretty

LGTM!!


Fix kerning rendering with letterSpacing (v4.x)

Description of change
Addresses issue of incorrect kerning for PIXI.Text when letterSpacing is a value other than 0, as described in issue #4635.
Pre-Merge Checklist

[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Example:
new PIXI.Text('YouTube', {align: 'center', fontSize: 72, fontFamily: 'Times', letterSpacing:1});
With this change:

Current behavior in v4.8.8:

Here's a live example. This is broken in v4 and v5. Will probably also need to make fix there.
https://www.pixiplayground.com/#/edit/T8hApbGS5kM~E16hGJUm6 (v4.8.8)
https://www.pixiplayground.com/#/edit/hU8dE_75THuOLP8ZmdjlI (v5.1.3)

nice catch @ericente !


WIP: Redo robot registration

It has just occurred to me, the way we have it set up at the moment is that the robot ID matches to a specific use case (123abc for switch and qwerty for thermostat), whereas we want a robot ID to be configured to do any of these use cases (because the ID is the HAL not the PAL).

[x] refactor RegisterRobot
[ ] refactor AddSwitch / RemoveSwitch
[ ] add AddThermostat / RemoveThermostat
[ ] create UnregisterRobot

Merged into #149


[NEW ICON] Supabase

Skill Name
Subabase
Why?
Supabase is an open source Firebase alternative.
Start your project with a Postgres database, Authentication, instant APIs, Edge Functions, Realtime subscriptions, Storage, and Vector embeddings.
Reference Image

supabase icon is already in there.

[!NOTE]
You might want to go at the newest version of the project which is located here

Oh, I found it. Sorry, my mistake. I searched the issues, but I didn't find anything about it.


[Feature] Go templates

Is your feature request related to a problem? Please describe.
The TF code works but I'd like to make it a Go template to do things that at this time HCL don't allow me to do.
Describe the solution you'd like
Instead of passing a static TF code, pass a Go template with the values to render it.
Describe alternatives you've considered
Render the code before pass it to Terraformer.
Proposal
Allow to receive a Go template and a map with the values. This could be in the New function or in a Parse function or both.
Additional context
Notice that the character used by Go templates by default is also used in HCL. We may consider to use a different character to make is more human readable.
References

Go Templates and Terranova is documented in the example 06 on the Terranova-Examples repo: https://github.com/johandry/terranova-examples/tree/master/06_templates.
At this time I'm not sure if this should be a feature on Terranova, I think it will add more complexity to the module/package, so maybe keep the package simple to do what is was meat to do.
The Go Templates & Terranova feature may be a external package or documented as an example.
I'll appreciate your comments on this topic.


dummy-pr-1538-pointer

Changes proposed in this PR

Why are we making these changes?

@nsinkov Should we close this?


Speed up import of files

On file with 316,000+ rows, with 25 columns, the read time is taking about 18 seconds.  Using the sqlite3 shell to import from the command line takes about 3 seconds.  This needs to be optimized.

This fix takes the read time down to 6 or 7 seconds for the same file, so rough 2x of sqlite3 shell, but we're doing more checks + it's managed code.


Website Offline https://test.webrtc.org/

Error: Page not found
The requested URL was not found on this server.
ping webrtc.org
Ping wird ausgeführt für webrtc.org [<IP_ADDRESS>]
ping test.webrtc.org
Ping wird ausgeführt für ghs.google.com [<IP_ADDRESS>]
What are the plans for the service?

This repo states that it's on hold, but I have no idea what the next steps are.  This is a useful tool, so it would be a shame if it disappeared.  Xirsys hosts their own version, but it targets Xirsys servers only.

I have a version of this repo which I updated to the latest Polymer libraries.  Not sure if the fact this project is still running on very old libraries is the reason for its halted status...


Implement pause/resume

Hi @linxiulei I fixed CI by https://github.com/fuweid/embedshim/pull/32. Please rebase Thanks!

Done, PTAL!


go get is noisy on repos with meta tags

Example:
$ go get -u -v golang.org/x/tools/cmd/gorename
Fetching https://golang.org/x/tools/cmd/gorename?go-get=1
Parsing meta tags from https://golang.org/x/tools/cmd/gorename?go-get=1 (status code 200)
get "golang.org/x/tools/cmd/gorename": found meta tag main.metaImport{Prefix:"golang.org/x/tools", VCS:"git", RepoRoot:"https://go.googlesource.com/tools"} at https://golang.org/x/tools/cmd/gorename?go-get=1
get "golang.org/x/tools/cmd/gorename": verifying non-authoritative meta tag
Fetching https://golang.org/x/tools?go-get=1
Parsing meta tags from https://golang.org/x/tools?go-get=1 (status code 200)
golang.org/x/tools (download)

None of this is useful, and shouldn't be shown unless something goes wrong.

You asked for -v, you got it.

This output is very useful when diagnosing issues with repos with meta tags.
As Dave said, you got what you asked for by specifying -v. We're not going to add -vv.

I feel this is inconsistent, meta tags are being special cased here. There's no logging of VCS specific stuff, why treat this differently? If there is a meta tag issue, it can be resolved with other tools. Rule of Silence: When a program has nothing surprising to say, it should say nothing.

Rule of silence should not apply if the user explicitly supplies a verbose
flag.

What kind of output do you expect when using the verbose flag?

Just the usual stuff relating to which packages download new changesets.

I think this is incredibly useful, since it shows you the magic that is happening with the meta tags.  If you don't get that output with -v, how else would you get it?

Also if there's other diagnostic information that we could be showing but
aren't, we should probably include that in the -v output too.


[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]

auto-merge triggered by github actions on bot-auto-merge-branch-22.08 to create a PR keeping branch-22.10 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

SUCCESS - auto-merge


minor refactorings

I think the whitespace amendments make sense and might as well be accepted.
The decision to rewrite the #selector parameters in minimized form is more a question of taste. Because #selector's argument is interpreted by Swift and has to match against a known method name, it is able to infer from a standalone method name which actual selector to use. But to my mind it is better when the #selector argument actually conveys to anybody reading the code that there is an argument expected for the given method. Personally I would prefer to keep the somewhat noisy "(_:)" addendum on the #selector arguments.

Actually on the subject of the whitespace changes: I think it's probably a question of whether Brent cares about maintaining any whitespace standards and wants to establish some kind of standard going forward. If the editor is just going to add these kinds of whitespace in the future and it won't be enforced, there isn't really any point in taking a massive "correction" to whitespace.

@adamnemecek thanks for taking the time to put together this pull request.  Unfortunately it is now out of date and has merge conflicts.
In the future if you want to implement some sweeping changes like this, please join the Slack channel and run them by Brent first.  It increases the chances that your pull request will be accepted.


Update template in meta.yaml, tick build num

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Unable to find a specification for Google-Maps-iOS-Utils (~> 1.0)

Uncomment this line to define a global platform for your project
platform :ios, '9.0'
source 'https://github.com/CocoaPods/Specs.git'
target 'SwiftDemoApp' do
Comment this line if you're not using Swift and don't want to use dynamic frameworks
#use_frameworks!
Pods for SwiftDemoApp
pod 'GoogleMaps'
pod 'Google-Maps-iOS-Utils', '~> 1.0'
end
This is pod file code but still i get same error "Unable to find a specification for Google-Maps-iOS-Utils (~> 1.0)"
I reinstall cocoapod then also i get this type of error

Try "pod update".

Here is what I get when I run the above Podfile through pod install on my mac:
$ pod install
Analyzing dependencies
Downloading dependencies
Installing Google-Maps-iOS-Utils (1.0.1)
Installing GoogleMaps (2.0.0)
Generating Pods project
Integrating client project

[!] Please close any current Xcode sessions and use `Google Maps iOS Utils test.xcworkspace` for this project from now on.
Sending stats
Pod installation complete! There are 2 dependencies from the Podfile and 2 total
pods installed.

I suspect you might need to shake your CocoaPod installation.

You can try running the command below to sync your pods repo.
pod repo update


RSI is wrong on tradebot

calculated RSI properties for candle:
2017-05-27 21:43:06 (DEBUG):             rsi: 98.42998966176029
The RSI/TSI has a problem of range on tradebot is 98 to 100 in early.
EMA problem ?
Solved:
Create a TAlib version of RSI strat

@aneopsy Could you please share your TAlib version of RSI strat?
Thanks.

@darklow Talib doesn't install on windows, if it's your OS. Have the same issue. Don't know about the RSI problem though

If anyone can let me know what is wrong with the RSI version I can fix that :)

I have the same problem and there's nothing wrong with the RSI version, the problem is that there is no history being loaded when gekko first starts.
The history setting doesn't seem to work. For example with Bitstamp, it can load up to a day of history, but it doesn't actually make candles out of it.
I've made a quick workaround for it in this commit: https://github.com/andreialecu/gekko/commit/04fa5758bde229009040b95538779e05ac8c0fb4, but I don't think it's the right fix. I need to get more familiar with the code before fixing it properly.

I have the same problem and there's nothing wrong with the RSI version, the problem is that there is no history being loaded when gekko first starts.

When the code hits this path it means that Gekko just called an exchange and it returned all data, which means that as soon as the pipeline starts the same data will be fetched and all data will be fed into Gekko. If this did not work for you please open a new issue, because I think your commit will pump the same candles twice into the strat.

While that may be true, without that particular hack the rsi always starts at 99+. At least on bitstamp. So the other code path is probably not working for some reason. I'll take another look at it tonight.

I have the same problem with RSI, any updates on this?

rsi is calculated on live, at least is what I think.
On Wed, Jun 14, 2017, 4:44 AM jjngpuri<EMAIL_ADDRESS>wrote:

I have the same problem with RSI, any updates on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/759#issuecomment-308311460, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALhf8gFrsonnG7yD7kmRV6PLOjeJa_RLks5sD1b_gaJpZM4Noc4a
.

Same issue here, where the RSI always starts at 99+. I have a full import of Poloniex history for my currency pair (going back months). The trade bot appears to recognise this history exists when it starts, and loads it in. However, when the first trade is triggered, the DEBUG console is giving me a value of 99+ for the RSI (when measuring it separately, I'm getting below 30). As such, the bot appears to be "selling low".
Don't appear to get this issue when running backtester in the UI. Is it perhaps because the number of candles being used to generate the initial history can be defined here?

My RSI strat was selling ridiculously low, too. I figured it was due to a bad strategy so I didn't bother enabling debug.
After backtesting this again using the same settings, I find it returns an almost perfect result, with clear buy/sell indicators on the lows and highs. The market I was running it on did not change drastically compared to the history I tested it on.
I'm happy to test this live if anyone needs more info.

I created an RSI strategy from the TALib library.  When running TALib RSI it in paper trade mode, it is unable to calculate the RSI from stored exchange history.  However, it does just fine in backtest mode.
The only real advantage, I can see, from using TALib vs the built-in RSI is that it won't trade on incorrect data. The built-in RSI strategy seems to hover right at 99 to 98, at least for the hours that I let it run.  My particular strategy requires a few hours of data to calculate a trend...
Anyway, it seems like there's possibly a glitch with using stored data for these two algos.  Here's a debug log.
`2017-07-07 14:31:27 (INFO):	Setting up Gekko in realtime mode
2017-07-07 14:31:27 (INFO):
2017-07-07 14:31:27 (INFO):	Setting up:
2017-07-07 14:31:27 (INFO):		 Candle writer
2017-07-07 14:31:27 (INFO):		 Store candles in a database
2017-07-07 14:31:27 (INFO):
2017-07-07 14:31:27 (INFO):	Setting up:
2017-07-07 14:31:27 (INFO):		 Trading Advisor
2017-07-07 14:31:27 (INFO):		 Calculate trading advice
2017-07-07 14:31:27 (INFO):		 Using the strategy: talib-rsi
2017-07-07 14:31:27 (INFO):		The trading method requests 600 minutes of historic data. Checking availablity..
2017-07-07 14:31:27 (INFO):
2017-07-07 14:31:27 (DEBUG):		Available local data:
2017-07-07 14:31:27 (DEBUG):			from: 600 minutes ago
2017-07-07 14:31:27 (DEBUG):			to: 2 minutes ago
2017-07-07 14:31:27 (INFO):		Usable local data available, trying to match with exchange data..
2017-07-07 14:31:27 (DEBUG):		Fetching exchange data since 17 minutes ago
2017-07-07 14:31:27 (DEBUG):	Scanning back in the history needed...
2017-07-07 14:31:27 (DEBUG):	2017-07-07T21:14:00+00:00
2017-07-07 14:31:27 (DEBUG):	Scanning backwards...2017-07-07T21:25:40.359Z
2017-07-07 14:31:27 (DEBUG):	Scanning backwards...2017-07-07T21:17:22.717Z
2017-07-07 14:31:28 (DEBUG):	Backwards: 2017-07-07T21:06:27.353Z (17817979) to 2017-07-07T21:09:10.026Z (17818078)
2017-07-07 14:31:28 (DEBUG):	Backwards: 2017-07-07T21:09:10.026Z (17818079) to 2017-07-07T21:17:22.167Z (17818178)
2017-07-07 14:31:28 (DEBUG):	Backwards: 2017-07-07T21:17:22.717Z (17818179) to 2017-07-07T21:25:40.359Z (17818278)
2017-07-07 14:31:29 (DEBUG):	Backwards: 2017-07-07T21:25:40.359Z (17818279) to 2017-07-07T21:30:23.864Z (17818378)
2017-07-07 14:31:29 (DEBUG):	Backwards: 2017-07-07T21:26:11.713Z (17818285) to 2017-07-07T21:30:57.458Z (17818384)
2017-07-07 14:31:29 (DEBUG):	Backwards: 2017-07-07T21:26:11.713Z (17818286) to 2017-07-07T21:30:57.458Z (17818385)
2017-07-07 14:31:29 (DEBUG):	Backwards: 2017-07-07T21:26:19.222Z (17818288) to 2017-07-07T21:30:57.458Z (17818387)
2017-07-07 14:31:30 (DEBUG):	Backwards: 2017-07-07T21:26:19.222Z (17818288) to 2017-07-07T21:30:57.458Z (17818387)
2017-07-07 14:31:30 (DEBUG):	Scan finished: data found:800
2017-07-07 14:31:30 (DEBUG):		Available exchange data:
2017-07-07 14:31:30 (DEBUG):			from: 25 minutes ago
2017-07-07 14:31:30 (DEBUG):			to: 0 minutes ago
2017-07-07 14:31:30 (DEBUG):		Stitching datasets
2017-07-07 14:31:30 (INFO):		Full history locally available.  From 2017-07-07 21:07:12 UTC to 2017-07-07 21:30:57 UTC. (24 minutes)
2017-07-07 14:31:50 (DEBUG):	Requested BTC/USD trade data from GDAX ...
2017-07-07 14:31:50 (DEBUG):	Processing 46 new trades. From 2017-07-07 21:30:57 UTC to 2017-07-07 21:31:05 UTC. (a few seconds)
2017-07-07 14:32:10 (DEBUG):	Requested BTC/USD trade data from GDAX ...
2017-07-07 14:32:10 (DEBUG):	Processing 13 new trades. From 2017-07-07 21:31:28 UTC to 2017-07-07 21:31:59 UTC. (a few seconds)
2017-07-07 14:32:30 (DEBUG):	Requested BTC/USD trade data from GDAX ...
2017-07-07 14:32:30 (DEBUG):	Processing 4 new trades. From 2017-07-07 21:32:04 UTC to 2017-07-07 21:32:06 UTC. (a few seconds)
undefined
2017-07-07 14:32:30 (DEBUG):		 rsi: undefined
2017-07-07 14:32:50 (DEBUG):	Requested BTC/USD trade data from GDAX ...
2017-07-07 14:32:50 (DEBUG):	No new trades.
snip
2017-07-07 17:52:02 (DEBUG):	Processing 9 new trades. From 2017-07-08 00:51:45 UTC to 2017-07-08 00:52:01 UTC. (a few seconds)
37.24163848177364
37.24163848177364
2017-07-07 17:52:02 (DEBUG):	In low since 1 candle(s)`

Sources online use the cumulative moving average (CMA) over a period of 14 days, where Gekko uses EMA as average for RSI. Could this be an issue?

Let's ping @cykedev, he added RSI back in 2014 (#208)

I'm working on a TA library as well, so I might be able to port your calculations in the near future, if @cykedev doesn't respond. A possible problem would be which RSI to pick; the original one from the paper or a newer version, for example the ones mentioned on Wikipedia.

@wuhkuh I came across this, maybe you can use it in a way? https://github.com/WaiSiuKei/ta-lib

Could you guys take a look at this version of  RSI. I've effectively modified someone elses, it's here: https://github.com/thegamecat/gekko-trading-stuff
It's written as a Strategy, so just chuck it in the Strategies folder and update the config.js then backtest.

New version of RSI has landed in develop branch, props to @wuhkuh! As soon as that lands in a release I will consider this issue closed :)

That landed in stable a while ago!


Video element - cached element

Hi guys I'm a little bit confused about a video element.
My project consist in a main video page. I should be able to play and pause the video to show some extra  informations, but when I change route and I come back to the main page, the one with the video, the video gets "duplicated". You can notice it from the overlayed audio: one from the from the cue point when I paused before changing page, and the other is from the video begin.
It's like the first element is cached by the browser.
How I can reinit video element when I come back to main page? Or, how can I avoid this "cached video behaviour"?
Video element markup:
<video class="video" playsinline preload="auto" src="~/assets/url/to/video"></video>
Video is stored in a variable in mounted hook like this:
var mainVideo = document.querySelectorAll('.video')[0]
I've tried some tricky solutions but i can't get away with it. Any ideas?

I solved in a tricky way with some javascript

I have the same problem as well, can you please how you fixed it.

I re-init the variable before play the video.
Something like that:
mainVideo = document.querySelectorAll('.video')[0] mainVideo.play()

I see, I don't really like that solution, it feels like a bad hack but thank you for telling me anyway. I'm going to try and find another way I can maybe solve it.

Let me know if you will find another solution

Can you reproduce this problem on your local production build or does it only happen on a hosted server?

Both environment

Can you invite me into the repo? With me, I can only replicate it on my hosted server and not locally. I want to see if its the same with your repo @nicoladl.

I can't because is a business repo.
I can share the url of the project https://charlyzenger.ch/en/

I have to run off now, got to catch the train. I created that issue, hopefully we'll get a better answer on how to solve it. I'll talk in a bit.

I fixed it by adding a unique ID to my video player and placing it ID inside a data tag for my video element. Whenever I call the play() method on my video player, I query select all my video elements and check if the ID of the current video player matches any of the video elements ID.
So I did something like this:
<template>

    <video :data-id="id" @loadedmetadata="startAutoplay()"/>

</template>


Amplification and Enablement of Automation and TechZone Collection

Program to amplify and enable our IBM sellers, and Partners and their sellers as well as stakeholders across EEDA team on our Automation and TechZone collection (Reference Architecture, CPI, Data Fabric and MAS) as we release them.  The program will entail: SLACK, EEDA Publisher page, Seismic, GSI Newsletter, Sales Zone, PW Newsletter etc).  Asset Enablement via EEDA YL initiative.
https://ec.yourlearning.ibm.com/w3/series/10317716

Released AWS, Azure and IBM Cloud Automation for Reference Architecture, CPI and MAS Automation for AWS, Azure and IBM Cloud on TechZone. Promoted via Newsletter, EEDA Guild Publishers page.


--blame-hang causing crash with AccessViolationException

I'm using --blame-hang in an invocation to dotnet vstest (via a runsettings file) on an AzDO pipeline.  In the logs, I can see that when the blame collector identifies a hang, it tries to create a dump of the hung process, but it's failing with the following AccessViolationException:
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Repeat 2 times:
--------------------------------
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.WindowsHangDumper+NativeMethods.MiniDumpWriteDump(IntPtr, UInt32, Microsoft.Win32.SafeHandles.SafeFileHandle, MINIDUMP_TYPE, MINIDUMP_EXCEPTION_INFORMATION ByRef, IntPtr, IntPtr)
--------------------------------
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.WindowsHangDumper.CollectDump(System.Diagnostics.Process, System.String, Microsoft.TestPlatform.Extensions.BlameDataCollector.DumpTypeOption)
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.WindowsHangDumper.Dump(Int32, System.String, Microsoft.TestPlatform.Extensions.BlameDataCollector.DumpTypeOption)
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.ProcessDumpUtility.HangDump(Int32, System.String, Microsoft.TestPlatform.Extensions.BlameDataCollector.DumpTypeOption, System.String, System.Action`1<System.String>)
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.ProcessDumpUtility.StartHangBasedProcessDump(Int32, System.String, Boolean, System.String, System.Action`1<System.String>)
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.BlameCollector.CollectDumpAndAbortTesthost()
   at Microsoft.TestPlatform.Extensions.BlameDataCollector.InactivityTimer+<>c__DisplayClass1_0.<.ctor>b__0(System.Object)
   at System.Threading.TimerQueueTimer+<>c.<.cctor>b__23_0(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.TimerQueueTimer.CallCallback(Boolean)
   at System.Threading.TimerQueueTimer.Fire(Boolean)
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.TimerQueue.AppDomainTimerCallback(Int32)

Because of this crash, the test host isn't aborted, which requires the pipeline stage to terminate at its given timeout.
We're using version 5.0.302 of the dotnet SDK on our pipeline agents.  I have limited access to the agents, so I'm hoping maybe someone's seen this before, or has a troubleshooting step I can try?  If not, I can try to gain access to one of the agents to track the issue down.

Hello, the windows hang dumper uses only this p\Invoke call, and there is no option to switch to the native hang dumper of .NET Core, I did it this way to keep it simpler. And to avoid depending on external executables (procdump) on Windows.
I haven't seen it fail in this yet. Does your code target net5.0 target framework? Or do you only build with 5.0 SDK and target older framework?
We could possibly add option to force the native 5.0 hang dumper on windows. But that would require code changes, and a new build, so it would take time.

Our target framework is <TargetFramework>net5.0-windows</TargetFramework>.   On our CI machines, we're using the dotnet-install scripts to install the SDK/runtime.
It also appears to be working-ish on some agents.  On some agents, it's able to create a full dump that I can open and debug, but I'm not able to debug the mini dumps it creates.  The visual studio debugger indicates that there was no compatible code running (although I know there was managed code running because I hand crafted the hang).
The various agents we run on all have different sets of software installed - what's really required for this collector to work correctly?

Once this is shipped you will be able to use the VSTEST_DUMP_FORCEPROCDUMP=1 env variable to force using procdump over the PInvoke call for hang dumps. You need procdump installed in your PATH. Easiest way to install it on azdo is via choco.


NOISSUE - Implementation of gRPC mTLS

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
This PR aims to add MTLS (Mutual Transport Layer Security) support for the gRPC client in the Mainflux . It includes changes to both the gRPC server side and client side. The implementation of MTLS ensures secure communication between the client and server by requiring authentication and encryption for the transmitted data.
Which issue(s) does this PR fix/relate to?
Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
No
List any changes that modify/break current functionality
No
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes

Running Mainflux Core Services
To run all the Mainflux core services, use the following command:
make run

This command will start all the mainflux core services.
If you want to run the Mainflux core services with GRPC_MTLS enabled, use the following command:
GRPC_MTLS=true make run

This will start all the mainflux core services with secure communication using automatically generated certificates if they are not already available.
Running Addons Services
To run all the addons services, you can use the following command:
make run_addons

This command will start all the addons services.
If you want to run the addons services with GRPC_MTLS enabled, you can use the following command:
GRPC_MTLS=true make run_addons

This will start all the addons services with secure communication using automatically generated certificates if they are not already available.
Running Specific Addons
If you only want to run specific addons, you can specify them in the command. For example, to run the timescale-reader and timescale-writer addons, use the following command:
make run_addons timescale-reader timescale-writer


Added mutex in the rpc call setEmotion.

Fixes #138
Still need to be tested on the robot.

I've tried the changes on my laptop and everything seems to work properly, but it needs to be tested on ergoCub

The code has been tested on ergoCub.
We noticed that sometimes, the transition does not appear.
I checked the code and I think it is related to showTransition. I will address this soon

The code has been tested on ergoCub.
We noticed that sometimes, the transition does not appear.
I checked the code and I think it is related to showTransition, where I don't lock the mutex. I will address this soon

Great thanks!

The code has been tested on ergoCub.
We noticed that sometimes, the transition does not appear.
I checked the code and I think it is related to showTransition, where I don't lock the mutex. I will address this soon

Done in https://github.com/icub-tech-iit/ergocub-software/pull/139/commits/a260c767f40a315db2a2ec9a50598669e42d02e5
With https://github.com/icub-tech-iit/ergocub-software/pull/139/commits/ab77ae809c2ddb5acbd75884de1692d1a42100ba I tried to speed up a bit the transitions, although they still take a long time to start. I suppose it is related to the loading of the images and video at runtime, but it is outside the scope of this PR.
I have tested it on ergoCub

Merged, thanks!


[Suggestion] Essentia Phials compatible with Bibliocraft potion shelves

I don't know if this would be a change in TC or Bibliocraft, but currently (B24) I'm able to place vis crystals in potion shelves, but not phials (either full or empty). At one time they did work this way, and it'd be great to have that back. Thanks!

Add "phial" as an additional keyword to AdditionalPotions in the Bibliocraft config...

Didn't know I could do that. Thanks!


Is it possible to request the entire CNAME chain?

I'm not even sure if this is possible but I can't seem to figure out how to request the entire CNAME chain from a single request. I've tried something like this so far:
package main

import (
	"fmt"

	"github.com/miekg/dns"
)

func lookupCNAME(client *dns.Client, domain string) (cnames []*dns.CNAME, err error) {
	msg := &dns.Msg{}
	msg.SetQuestion(dns.Fqdn(domain), dns.TypeCNAME)

	resp, _, err := client.Exchange(msg, "<IP_ADDRESS>:53")
	if err != nil {
		return cnames, err
	}

	for _, a := range resp.Answer {
		if r, ok := a.(*dns.CNAME); ok {
			cnames = append(cnames, r)
		}
	}

	return cnames, nil
}

func main() {
	const (
		domain = "sub1.example.com" // a domain that returns a CNAME to another CNAME
	)

	cnames, err := lookupCNAME(new(dns.Client), domain)
	if err != nil {
		panic(err)
	}

	// A slice of CNAMEs?
	fmt.Println("CNAME records:", cnames)
}

Nevermind! I think I found what I'm looking for, performing a recursive A lookup (TypeCNAME to TypeA) also returns the entire CNAME chain.


Brownout detector & WIFI reconnect

after "Brownout detector was triggered" board cannot connect to WIFI and no ESP reset
board is offline forever

Did this crash the board permanently - I assume you could cycle power and everything worked again?

Reset button or turn on/off restore board


Fix java checkstyle handler.

The checkstyle handler is capable of parsing the new and old output
formats. Unfortunately there are some particular output messages that
matched both the new and old regular expressions:
[WARN] whatever:11:7: WhitespaceAround: ''if'' is not followed by whitespace. [WhitespaceAround]
This caused ALE to report extra errors since the message was being
matched twice, once as a warning and another (incorrect) old formatted
error.
This MR fixes this by stopping any parsing using the old format regexp
is any errors of the new format are correcly parsed. There is no reason
to expect checkstyle to output both styles in the same report.

Cheers! :beers:


NVIDIA GPU support

This would make it easier to use kubespray in conjuction with kubeflow.
I think this is what it would take:

Add two new boolean vars: accelerators_enabled and device_plugins_enabled to inventory/group_vars/k8s-cluster.yml
Expand the kube_feature_gates list var in main.yml to set Accelerators={{ accelerators_enabled|string }} and DevicePlugins={{ device_plugins_enabled|string }}
Create a new playbook called contrib/nvidia_gpu/nvidia_gpu_ubuntu.yml that does the following:
On every node:
a) Install a user-configurable nvidia-XYZ driver apt package. (Perhaps default to nvidia-384)
c) Install the nvidia-docker2 package following the instructions here: https://github.com/nvidia/nvidia-docker/wiki/Installation-(version-2.0)
d) Update /etc/docker/daemon.json to set "default-runtime": "nvidia"
e) Run pkill -SIGHUP dockerd
f) Install the k8s-device-plugin daemonset via kubectl

Hello,
2 small questions:

In step 2 - which main.yml there are many of them
do you have an examply of nvidia_gpu_ubuntu.yml ?

Thank you in advance.

@AtzeDeVries as I am playing with mining setups now, I can confirm that installing via the runfile is the best thing to do, I had too much pain with apt-get installations. Haven't had any problems with license or so, here is part of the code I am using (it's not very clean yet, but to give generic idea):
# https://gist.github.com/wangruohui/df039f0dc434d6486f5d4d098aa52d07#install-nvidia-graphics-driver-via-apt-get
- name: Install dependencies for run files
  apt:
    name: "{{ item }}"
    state: present
  with_items:
    - build-essential
    - dkms

- name: Donwload driver
  get_url:
    url: http://us.download.nvidia.com/XFree86/Linux-x86_64/390.25/NVIDIA-Linux-x86_64-390.25.run
    dest: /root
    mode: 0755

- name: Blacklist for Nouveau Driver
  copy:
    src: blacklist-nouveau.conf
    dest: /etc/modprobe.d/

- command: update-initramfs -u

- name: Reboot machine (not quite sure why this step is needed, was following tutorial)
  include: reboot.yml

- name: Stop lightdm/gdm/kdm
  service:
    name: lightdm
    state: stopped

- name: Install driver
  command: /root/NVIDIA-Linux-x86_64-390.25.run --dkms -s

- name: Check if driver is installed correctly
  command: nvidia-smi

- name: Start lightdm/gdm/kdm
  service:
    name: lightdm
    state: started

X server is needed if you need to access nvidia-settings as nvidia-smi doesn't expose all GPU characteristics. Generally, I am not sure if driver installation should be part of the code, perhaps just kubernetes and docker configureation and leave driver installation to the user as it is done on the host itself and not related directly to kubernetes?

Thank you very much for the help !!!


TyphoonConfigPostProcessor: only one config is used, no matter how many of them are present

This is actually a silly kind of pull request :)
Setup:

Typhoon 2.3.0
single root assembly with several collaborating ones
each assembly has it's own .plist file, indicating that through:

- (id)config
{
    return [TyphoonDefinition<EMAIL_ADDRESS>}

Expected: all values from all configs are available for injection through<EMAIL_ADDRESS>Actual: I can inject values only from one config
Reason: TyphoonConfigPostProcessor overrides all TyphoonInjectionByConfig instances. In the case described, there are several TyphoonConfigPostProcessors. Thus, the last applied TyphoonConfigPostProcessor overrides values from other configs with nil objects.
Solution/workaround: In TyphoonConfigPostProcessor, check whether it contains value for the config key, and if it doesn't, just skip corresponding TyphoonInjectionByConfig instance.
This can be done by replacing this code in TyphoonConfigPostProcessor.m:
#pragma mark - Protocol Methods

- (void)postProcessComponentFactory:(TyphoonComponentFactory *)factory
{
    for (TyphoonDefinition *definition in [factory registry]) {
        [definition enumerateInjectionsOfKind:[TyphoonInjectionByConfig class] options:TyphoonInjectionsEnumerationOptionAll
                                   usingBlock:^(TyphoonInjectionByConfig *injection, id *injectionToReplace, BOOL *stop) {
            injection.configuredInjection = [self injectionForConfigInjection:injection];
        }];
    }
}

- (id<TyphoonInjection>)injectionForConfigInjection:(TyphoonInjectionByConfig *)injection
{
    id value = [self configurationValueForKey:injection.configKey];
    id<TyphoonInjection>result = nil;

    if ([value isKindOfClass:[NSString class]]) {
        result = TyphoonInjectionWithObjectFromString(value);
    } else {
        result = TyphoonInjectionWithObject(value);
    }

    return result;
}

with this code:
#pragma mark - Protocol Methods

- (void)postProcessComponentFactory:(TyphoonComponentFactory *)factory
{
    for (TyphoonDefinition *definition in [factory registry]) {
        [definition enumerateInjectionsOfKind:[TyphoonInjectionByConfig class] options:TyphoonInjectionsEnumerationOptionAll
                                   usingBlock:^(TyphoonInjectionByConfig *injection, id *injectionToReplace, BOOL *stop) {
            id configuredInjection = [self injectionForConfigInjection:injection];
            if (configuredInjection) {                 //<---  SOLUTION part 1
                injection.configuredInjection = configuredInjection;
            }
        }];
    }
}

- (id<TyphoonInjection>)injectionForConfigInjection:(TyphoonInjectionByConfig *)injection
{
    id value = [self configurationValueForKey:injection.configKey];
    id<TyphoonInjection>result = nil;

    if ([value isKindOfClass:[NSString class]]) {
        result = TyphoonInjectionWithObjectFromString(value);
    } else if (value) {                 //<---  SOLUTION part 2
        result = TyphoonInjectionWithObject(value);
    }

    return result;
}

It seems that @mbaltaks has already implemented the global config attaching in TyphoonStartup.m. It either looks for TyphoonConfigFilename key in the Info.plist, or looks for<EMAIL_ADDRESS>file in the main bundle, where %@ is a bundle identifier.
This approach seems fine, but I have the following suggestions:

It would be more flexible to store an array of configs under a TyphoonConfigFilename key - the configs contents can be completely unrelated, but require global scope. This solution should be backwards compatible, so maybe it'd make sence to introduce another key - TyphoonConfigFilenames and to deprecate the previous one.
We should definitely document this feature - a couple of my colleagues asked for this already - and we didn't know, that it's implemented already :)

Updated documentation about TyphoonConfig usage: https://github.com/appsquickly/Typhoon/wiki/What-can-be-Injected


Duplicated “Update Branch” button

Description
When “Require branches to be up to date before merging” is enabled in branch protection and branch in PR is not up to date, I see two buttons to update it
Environment
https://github.com/<USERNAME>/<REPO>/pull

Screenshot

I'm seeing the same problem. Not sure yet what's going on, but the related piece of code is here:
https://github.com/sindresorhus/refined-github/blob/90226744b60546d48006db95cf1352d1e7a7d580/source/features/update-pr-from-base-branch.tsx#L59-L86
Maybe GitHub changed the way they impementated their update branch button. It is possible to look up the button using:
if (select('.branch-action-btn')) {
  return;
}

Yep, that'd be great. Line 60 should probably be:
 if (select.exists('.rgh-update-pr-from-master, .branch-action-btn')) {

But I think .branch-action-btn includes other similar buttons nearby, so it needs to be more specific.


have moveit_planners depend on chomp

Description
By default, the packages generated by moveit_setup_assistant now include a chomp configuration - but do not depend on chomp. the packages do depend on moveit_planners, so it makes sense to include chomp here.
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

Thanks for the quick fix! Not blocking this PR but would you mind to delete the other commented out moveit_planners_chomp exec_depend. I think it doesn't exist anyways

Updated - hadn't noticed that it was also chomp - I only looked for the one package that I was trying to include!


RFC: Merge C++ and Python documentation

@wesm @pitrou Would love to get your feedback on this early as it involves some work. The C++ part works nice with the XML generated by doxygen but one needs to explicitly list the parts that should show up in Sphinx. There is also an autoindex variant for C++ but that produces a wall of errors. I'm quite happy with the approach.
@kou As you mentioned in the mail thread, GLib needs the XML for GObject introspection to work, so I'm not going to touch that. I would still add top-level sections for the languages based on it and link to the generated API docs. Would that be ok for you as a first shot?

Would that be ok for you as a first shot?

Yes!

I almost never read the C++ docs (reading the .h files instead), so I'm not sure how people like to use it currently. I like this PR on the principle.

I will take a look when I can. We might go ahead and promote this to the top level of the repository to start having more documentation across languages

I'm not sure about this. We should either move everything (including go, rust, java, ruby, etc.) to sphinx and make doc a top level directory or use the standard documentation tool for that particular language.

I think there's two kinds of documentation:

Prose explanations of things
Generated / browsable API documentation

In Python we are using Sphinx for both. Other projects only are doing the latter.
I would be in favor of having a top level doc/ directory where we develop prose documentation for the entire Arrow project including some of its programming language implementations. How we deal with generated API documentation may be on a case by case basis, but the doc index page should have links to every API listing that exists (Java, GLib, Python, Ruby, JavaScript, etc.). Getting every project's API docs into a single Sphinx project is probably too much to ask

I wanted to give this a try but it seems doc building currently fails. The Python API docs are not generated anymore.

@pitrou I will have a look later but one thing I noticed is that it always helped to have the Python package build and installed using both:
python setup.py build_ext --build-type=$ARROW_BUILD_TYPE --with-parquet --with-plasma --inplace
python setup.py build_ext --build-type=$ARROW_BUILD_TYPE --with-parquet --with-plasma install

@pitrou rebased and also seeing a problem with the API docs.

These were issues with sphinx>=1.8. I'll push a fix soon.

@kszucs This now also contains a docker setup for building the Sphinx documentation.
@wesm @pitrou This is ready for review / merge. It contains a very basic set of C++ documentation. I would like to work on that in a separate PR and get the things here merged to prevent further merge conflicts.

Apparently there's a failed Travis-CI entry.

@kszucs @pitrou Can you take a look at this again? I hope I have incorporated all comments.

I'll take a look Monday.

One thing: I think Benchmarks.md isn't part of the documentation tree at all. It should be in the top-level python directory (it's really some kind of README).

Will merge on green build and follow-up with Benchmarks.md in a separate PR to unblock other branches that also touch the documentation: https://issues.apache.org/jira/browse/ARROW-3932

There was an anaconda.org timeout; I just restarted the failing build

@wesm Fixed, so this is ready for re-review.