Korean localization

Korean localization for this mod.
I'm not familiar with modding, so I'm not sure how to handle the keywords and prefixes in tooltips in the in-game. So I think there might be cases where it doesn't show up properly. I'd appreciate feedback on that or an environment where I can test it myself.

For keywords, they need to be prefixed with the modid and have one of the names defined in the names array.
here an example:
[
  {
    "ID": "${ModID}:Verdict",
    "PROPER_NAME": "평결",
    "NAMES": ["평결", "평결보다"],
    "DESCRIPTION": "#y평결을 가진 대상은 대상의 턴 시작 시 현재 체력이 #y평결보다 작다면 사망합니다. 아니라면, #y평결을 #b5 얻습니다."
  }
]

So if you wanted to use Verdict, you'd use this in card text
"DESCRIPTION": "Blah blah ${ModID}:평결 blah.

I would like to ask you a few more questions.
I don't think I fully understood your description, so I'll make an example. In the case of Candylands/Cardstring.json, should I change the fleeting in the card description to ${ModID}:fleeting, ${ModID}:일회용, or just 일회용?
And ${ModID}: is it for all situations where keywords are applied? Some biomes contain '${ModID}:' in id:, and others don't.
Also, Keywordstring.json contains the NAMES array, and I thought it would work to write down the same keywords so that they can be referenced in situations where they are used in different forms in a sentence. Should I just write all the forms that are used in Cardstring.json and so on?
Last question, why does metallicize or buffer that exist in vanilla games exist as keywords?

I haven't received an answer yet, so I've revised the rest of it as I understand it so far. I'd like to see it applied to ingame.
Additionally, I'm not used to github, so I think I made a mistake during uploading maybe.
(programmer's world is too complicated)
If there's anything I need to fix, I'll try again

should I change the fleeting in the card description to ${ModID}:fleeting, ${ModID}:일회용, or just 일회용?
I believe fleeting is a keyword from StSLib so you'd want to use 일회성 as defined here https://github.com/kiooeht/StSLib/blob/master/src/main/resources/localization/stslib/kor/legacyKeywords.json
For keywords from this mod, you'd want to always use ${ModID}: + one of the defined names in the korean keyword strings file the keyword is in.

${ModID}: will be replaced by the modid when compiled, so after compilation it'll be anniv6: this is used as a prefix for most things to prevent overlap with other mods. (For example, if two mods had a keyword called Fleeting, then the one loaded later would overwrite the keyword from the earlier one.) It doesn't have to be used for Biome IDs since biomes are something original to this mod and won't be replicated by other mods, some people just prefer to have them though.

Should I just write all the forms that are used in Cardstring.json and so on?
Pretty much, everything in the names list will be recognized as belonging to that keyword when used in the cardtext (in combination with the ${ModID}: prefix)

\u00a0'
I think that's a non breaking space, should be fine to leave.
[REMOVE_SPACE]
This is used in certain strings (basically everything that's not a card string) for formatting, if you use #y to highlight a word yellow, it will highlight everything until the next space so #yExhaust, unless xyz the , after Exhaust would be yellow. To prevent that people use Exhaust [REMOVE_SPACE], unless xyz the [REMOVE_SPACE] will be removed before the user can see it and the , won't be yellow since there was a space even if it got removed later.

why does metallicize or buffer that exist in vanilla games exist as keywords?
Because base game didn't create keywords for them. For metallicize, the card just explains what the power does, it doesn't say Gain 5 Metallicize. To not bloat text modders like making keywords for them.

I haven't received an answer yet, so I've revised the rest of it as I understand it so far. I'd like to see it applied to ingame.
My bad, was on easter holiday.

Thank you for your response.
I've updated it again.

Alrighty thanks, do you want to be credited as moviejw or would you prefer a different name?

I didn't know the comments were coming up even after the request was merged, so I just checked your comment.
I want to be credit as moviejw.


Adding Hashicorp Vault as addon

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gautambaghel I gave it a shot (before merging). I am getting the following error:
Normal   ReconciliationSucceeded  16m (x11 over 66m)  kustomize-controller  (combined from similar events): Reconciliation finished in 120.898824ms, next run in 5m0s                                                                                │
│   Warning  ReconciliationFailed     13m                 kustomize-controller  Pod/vault/vault-unseal dry-run failed, reason: Forbidden, error: pods "vault-unseal" is forbidden: error looking up service account vault/vault-unseal-sa: serviceaccount "vault-unseal-sa" not found                                                                                │
│ Namespace/vault created                                                                                │
│   Warning  ReconciliationFailed  82s (x3 over 11m)  kustomize-controller  Pod/vault/vault-unseal dry-run failed, reason: Forbidden, error: pods "vault-unseal" is forbidden: error looking up service account vault/vault-unseal-sa: serviceaccount "vault-unseal-sa" not found                                                                                │

I see the sa in the yaml file, however, it does not seem to have any effect (sa is not created). It could be related to general approach dealing with multi-doc yaml files in flux.
Have you tried this with fluxcd on your end?

@shapirov103 - I made a few more commits to this PR, just making sure you're using the latest commit?
https://github.com/aws-samples/eks-anywhere-addons/pull/21/commits/7cabae2a23f504268023230ce6340c277cd95437
I didn't actually deploy it via FluxCD now that I think about it, I simply did a
kubectl apply -f vault-unseal.yaml
Is that a problem?

@shapirov103 I can separate out the individual YAMLs, hang on

Approving the PR. Please add a tester job when you get a chance.


Use one toolbar for more than one editor.

If I was to be able to add and remove editors to a page and wanted one toolbar to use for them all, how would I go about doing this? Great library otherwise!

Currently you have to write your own custom toolbar for this. Good way to start is to look here: https://github.com/Voog/wysihtml/blob/master/examples/wotoolbar.html

Thanks that works great for most commands however is there an example for how I would do this for to create a link or add an image?

After searching for a solution for a few days I found this in your wiki: https://github.com/Voog/wysihtml/wiki/Supported-Commands#createLink from this I can see I just need to add the link value however to get user input for the link, they must use another textbox to type it into. This causes issues as the focus on the editor is lost. How do you fix this with the simple editor when using the dialog boxes? Thanks.


Trigger socket disconnect on App recovery from DB

The idea for dealing with sockets during Application recovery from the database is to simply invoke the error handler and let the application deal with the problem, typically reconnecting / starting the listen socket again.
In order to do this, we need to save a tad more state in env... a list of the error handler callbacks, right?

If we can get this in, we have a good interface for communicating with our Acton applications in a programmatic way (stdin/stdout sucks, as we've discussed). This in turn enables us to write much better tests that are both more robust and can run much faster. As you indicated this was a fairly small thing, I'm putting this right at the top of the priority list and assigning you :)


fix: Show configuration errors as workflow errors

:tada: This PR is included in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement least privilege principle for cloudfront, lambda and db migration stacks

…front permissions
Feature or Bugfix

Bugfix

Relates
-
Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A

Is the input sanitized? N/A
What precautions are you taking before deserializing the data you consume? N/A
Is injection prevented by parametrizing queries? N/A
Have you ensured no eval or similar functions are used? N/A

Does this PR introduce any functionality or component that requires authorization? N/A

How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
Are you logging failed auth attempts? N/A

Are you using or adding any cryptographic features? N/A

Do you use a standard proven implementations? yes
Are the used keys controlled by the customer? Where are they stored? N/A

Are you introducing any new policies/roles/users? N/A

Have you used the least-privilege principle? How? Yes, by removing the * for cloudfront permissions and explicitly specifying the distribution id arn.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Leaving in draft state until additional permission restrictions added to lambda roles and dbmigration role

Hi @mourya-33 Can you merge main into your branch? That way we can see your changes better

Sure @dlpzx

@dlpzx @noah-paige I merged changes from main and reopened the PR

Yes @dlpzx i am running a few more tests and will update the list of tests performed here by tomorrow.

Hi @mourya-33 - left one minor comment and can you run ruff format and commit the changes ( I see the ruff workflow is failing)
I will do a quick test in the meantime

@noah-paige @dlpzx Here are the tests and validations performed for this PR.

Deploy to AWS
Link/Unlink Environment
Create/Delete Notebooks
Create/Delete ML Studio
Create/Delete Pipelines
Add/Import/Delete Datasets

Verified the loggroups for graphql, esproxy and awsworker as well which are now manually created from the lambda-api stacks.

Updated the files for ruff format check as well

Tested:

[ ] CICD Pipeline Completes
[ ] CodePipeline CB Policy Updated
[ ] Cross Account Cloudfront Role Updated
[ ] DB Migration Role Updated
[ ] Lambda Roles Updated
[ ] Lambda Functions Work and Still write to same CW Logs (GraphQL, AWSWorker, ESProxy)


Missing 'browser' field of package.json

When target is web, webpack use ['browser', 'module', 'main']as default value for resolve.mainFields.
As swr's package.json currently does not provide 'browser' field, 'module' entry point is used and thus the bundle breaks with syntax error in some old browsers. (e.g. IE11)
Sure, users can always override resolve.mainFields setting by themself, but wouldn't it would be nice if swr provided "browser": "./dist/index.js", so it works out of the box for old browsers? If core team agrees, I could come up with the PR (though it would be one-liner.)

@heejongahn not sure which error did you receive but I think this issue https://github.com/vercel/swr/issues/278 is probably related. it would be good if you can provide more information about the error here for us to track.
usually the "main" field and "module" are pretty enough for bundler to consume, since they're targeting CommonJS and ESModule format of assets.
If you need to convert your application assets to other formats by webpack (like UMD or just IIFE), it's up to application layer. or you can also use babel to transform swr dist by babel to the format you need.

for some reason I saw the ESModule build is using ESNext syntax
build:esm": "tsc --target ESNext --module ES6 --outDir esm
@shuding is it ok to use ES5 or it's specified to ESNext to due to some special reason?

@huozhi  For me, it was class syntax in esm/cache.js which caused the error.

I think for temporary work around you can include swr in the babel transform list, based on https://github.com/vercel/swr/issues/278
{
  test: /\.(js|jsx)?$/,
  exclude: /node_modules\/(?!swr)/,
  use: {
    loader: 'babel-loader',
  },
},

@huozhi Yeah I think it's a mistake to use ESNext, totally okay to change it to ES5.

Fixed in<EMAIL_ADDRESS>

Thanks!


Make sure that modal's computed properties only run when the modal is active

With a large amount of modals this is a performance issue.

It seems that watchers are to blame. The watched properties will need to come with guards if they're expensive to calculate.

Make a util for modal watchers.


How can i populate redux store before the route transition occurs?

You can use the onEnter hook to run a redux action, including anything async.


Fix: Remove broken badges

This pull request

[x] removes broken badges

Hey @localheinz,
sorry for a long response time.
Good catch, thanks a lot for your contribution. We will merge it into PHP 8.1 support branch.
Have a great working day))

Merged into https://github.com/spryker/docker-php/pull/47

Thank you, @alexanderM91 and @zyuzka!


The PowerToys Run window is in an abnormal position

Microsoft PowerToys version
0.83.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Press my preset shortcuts.
✔ Expected Behavior
The search box that appears, like in the pre-0.83.0 version, is in the upper part of the screen, similar to that of Mac.
Alternatively, you can open up the functionality to let users configure where the search box appears,When it is confirmed that it is not possible to go back to a version earlier than 0.83.0.
❌ Actual Behavior

As you can see, it is now in the middle of the screen.
Other Software
No response

/dup #34072


Virtual kubelet reflection logic improvements

Description
This PR introduces a set of improvements concerning the liqo virtual kubelet reflection logic:

Fix a bug which caused remote objects to be overwritten in case a local one with the same name was created.
Refactor the forge/reflection logic to use the cluster identity structure instead of the bare cluster ID.
Introduce an initial support to emit events when reflection succeeds/fails, for a more user-friendly feedback.

Additionally, it slightly uniforms the naming of certain variables in that part, as well as removes deprecated constants.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Manually, checking that events are generated correctly.
[x] Existing tests

/merge


[Feature]: Aegis item effect

Are you on the latest version?

[X] I'm on the latest version

Is there a fix in progress related to your proposal?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
No response
Describe the solution you'd like
I think it is neat to have Aegis item effect f you are holding Aegis. The priority of the status should be:

Smoked
Aegis
Aghanim and Shard

Dota 2 Patch
7.31d
Anything else?
No response

Hello @mikqsq, thanks for using the application.
This looks cool, I'm checking if I can see the player's inventory during the match. If I can I'll implement an icon for Aegis


Better import for sometimes failing mypy test

Would get:
dev_tools/bash_scripts_test.py:33: error: Name
'_pytest.tmpdir.TempdirFactory' is not defined
This fixes it. Don't know why it sometimes works on
some configurations.

This change got reverted somehow

This change got reverted somehow

Not only that, this file got reverted all the way to its version from December...

Hmmm...my "automated rebasing" strategy was error prone, this must have been overridden then. Let me fix that.


Not able to generate matrices

Hi,
I am not able to generate matrices. I have created a jar file (file.jar) of a single source file.
Following is the output of the command executed.
Please advise me how to proceed further

It seems that you need to compile the source file to a jar by jdk6, and use encoding.jar to generate   metrics with the above jar by Jed 10 or later....
It's quite complex but I successfully got the matrices by using two versions of jdk.....

It seems that you need to compile the source file to a jar by jdk6, and use encoding.jar to generate metrics with the above jar by Jed 10 or later....
It's quite complex but I successfully got the matrices by using two versions of jdk.....

Hi,
I have tried to use two versions of jdk, but it still told me "Totally 0 methods processed.". I'd appreciate if you tell me how to generate metrics with encoding.jar, or was there something that I went wrong.
Thanks a lot.

I also used JDK 8 to make jar file of source files and then passed it to encoding.jar but I got "Totally 0 methods processed." as result. Can anyone please respond if you were able to reproduce the matrices.

Hi, I am not able to generate matrices. I have created a jar file (file.jar) of a single source file. Following is the output of the command executed. Please advise me how to proceed further

Can the source files you write be shared? I reported an error in the process of executing the command, let me see and I write the difference in what


As listener showing marker?

As listener showing marker?

Hello! Unfortunately, I’m not sure I understand. Would you be able to expand on that?

the user clicks on the chart, the chart shows a marker, I need to listen to this

Got it! Pull request #96 will add such functionality. The feature will be available in the next release of Vico.

Hello! Vico 1.2.0 introduces the feature requested. The update should be available within 30 minutes. Thanks for the suggestion!


Swagger change for mtls and runningState

Add mtls properties for managed ManagedEnvironment
Add running state for Revision

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

@kazrael2119 the breaking change is not introduced by this PR. And it's already reviewed and approved: https://github.com/Azure/azure-rest-api-specs/pull/22423, WI: https://msazure.visualstudio.com/One/_workitems/edit/16986590

@weidongxu-microsoft @kazrael2119 the breaking change is not introduced by this PR. And it's already reviewed and approved: #22380, WI: https://msazure.visualstudio.com/One/_workitems/edit/16986590

@weidongxu-microsoft synced with me offline that there's still missing breaking change approval for some existing codes. @mikekistler could you help to review the breaking change, thanks! https://msazure.visualstudio.com/One/_workitems/edit/21201424

Breaking changes previously reviewed/approved in #22896


adding steps to fix 404 after step 21

using your personal token on gogs leads that you can pull but you can't push ONLY the password enables you to push the changes.

This fix is not needed if you follow the workshop instructions - using the provided accounts and passwords.  Ideally we want to workshop not to be cluttered with edge use cases, which are outside the instructions.
I suggest the instructions are not updates, but this note should be added to the workshop setup instructions / readme, as a pointer that Gogs doesn't use the token for command line login

Hi Brian, I was told by Carlos Santana to add it there thats why, thanks for reaching me out and whatever works am fine with it. thanks again.

Raafat Abaid                                                                                DevOps Engineer ‣IBM Technology Garage                                                                                📞<PHONE_NUMBER>                        @.***                          ▴ BluePages ▴ Slack ▴ LinkedIn
----- Original message -----From: "Brian Innes" @.>To: "cloud-native-toolkit/developer-guide" @.>Cc: "Ray Mekhaeil" @.>, "Author" @.>Subject: [EXTERNAL] Re: [cloud-native-toolkit/developer-guide] adding steps to fix 404 after step 21 (#486)Date: Mon, Oct 4, 2021 8:29 AM      This fix is not needed if you follow the workshop instructions - using the provided accounts and passwords. Ideally we want to workshop not to be cluttered with edge use cases, which are outside the instructions. I suggest the instructions    ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization. ZjQcmQRYFpfptBannerEnd

This fix is not needed if you follow the workshop instructions - using the provided accounts and passwords. Ideally we want to workshop not to be cluttered with edge use cases, which are outside the instructions.
I suggest the instructions are not updates, but this note should be added to the workshop setup instructions / readme, as a pointer that Gogs doesn't use the token for command line login
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

@binnes reviewed and said is not need it


freerdp-shadow3.lib unresolved external symbols

Describe the bug
When I try to compile the project, I get the following errors towards the end:
Creating the freerdp-shadow-cli.lib library and the freerdp-shadow-cli.exp object
LINK : warning LNK4098: default library 'MSVCRT' conflicts with use of other libraries; use /NODEFAULTLIB:library
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_surface_fill not resolved
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_label_draw not resolved
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_engine_free not resolved
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_engine_new not resolved
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_surface_free not resolved
freerdp-shadow3.lib(shadow_lobby.c.obj) : error LNK2001: external symbol __imp_rdtk_surface_new not resolved
freerdp-shadow-cli.exe : fatal error LNK1120: 6 external unresolved

To Reproduce
Steps to reproduce the behavior:

configure the project with the command: cmake -GNinja -B freerdp-build -S freerdp -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON -DCMAKE_INSTALL_PREFIX=D:\freerdp\workspace -DWITH_SERVER=ON -DWITH_SAMPLE=ON -DWITH_PLATFORM_SERVER=OFF -DUSE_UNWIND=OFF -DWITH_FFMPEG=ON -DWITH_SWSCALE=ON -DWITH_DSP_FFMPEG=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DWITH_WEBVIEW=OFF -DCHANNEL_URBDRC=OFF
Compile with: cmake --build freerdp-build
See error

Expected behavior
That the project is compiled.
Application details

FreeRDP version (3.2.0)
cmake parameters: -B freerdp-build -S freerdp -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON -DCMAKE_INSTALL_PREFIX=D:\freerdp\workspace -DWITH_SERVER=ON -DWITH_SAMPLE=ON -DWITH_PLATFORM_SERVER=OFF -DUSE_UNWIND=OFF -DWITH_FFMPEG=ON -DWITH_SWSCALE=ON -DWITH_DSP_FFMPEG=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DWITH_WEBVIEW=OFF -DCHANNEL_URBDRC=OFF

Environment (please complete the following information):

OS: [Windows]
Version/Distribution: [Windows 11]
Architecture: [amd64]:

@MatteoBax so you play randomly with CMake options and found a combination that does not work?
A note:

server side backends are not implemented for windows (the library is there, but nothing more than a sample works) - only exception is proxy which works fully
static linking on windows is quite a beast and we don´t test more than the clients with it. Feel free to create pull requests for stuff that you find ;)


[Fix] AllowedReaction code

fix/optimize code from #8886
before: AllowedReaction was piped throu multible templates in the worst case
now: just exec func AllowedReaction
Fix:
if you change reactions you are not able anymore to change it by this UI element:

@zeripath https://github.com/go-gitea/gitea/pull/9518#discussion_r361710740 is in this case a general discusion ... but this PR fixes a bug (wich I'm searching for the issue Nr right now)

Codecov Report

Merging #9518 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9518      +/-   ##
==========================================
+ Coverage   41.45%   41.48%   +0.02%
==========================================
  Files         571      571
  Lines       75248    75249       +1
==========================================
+ Hits        31196    31214      +18
+ Misses      40172    40160      -12
+ Partials     3880     3875       -5

Impacted Files
Coverage Δ

routers/repo/issue.go
37.61% <ø> (-0.05%)
:arrow_down:

routers/repo/pull.go
30.77% <ø> (-0.09%)
:arrow_down:

modules/templates/helper.go
40.33% <100%> (+0.37%)
:arrow_up:

modules/task/migrate.go
25% <0%> (-3.95%)
:arrow_down:

models/error.go
32.08% <0%> (-1.12%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

models/repo.go
47.97% <0%> (-0.11%)
:arrow_down:

modules/migrations/gitea.go
9.66% <0%> (+0.63%)
:arrow_up:

modules/migrations/migrate.go
25.78% <0%> (+1.57%)
:arrow_up:

modules/repository/repo.go
35.52% <0%> (+1.97%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145c1ea...2a18ba8. Read the comment docs.


Allow changing port numbers for serviceActivated containers

Earlier discussion in https://groups.google.com/forum/#!topic/rkt-dev/JD0jwJy74R0 says that the port number is used to match the socket to the right application. Reading between the lines, the name of the protocol in the ACI metadata is ignored, and the rkt run option --port=NAME:HOSTPORT is ignored. To keep things easier to talk about, I'm going to call the systemd listening socket sysport, a port in the ACI metadata aciport, with name aciportname.
Right now (as far as I understand it), there is no way to change the port a serviceActivated container listens on without rebuilding the ACI. This is clearly not as nice as with the non-serviceActivated containers.
Instead of the current logic (matching sysport to aciport), I would like to propose the following:

if --port is not given, behave just like now: match sysport to aciport
with --port=NAME:HOSTPORT, match sysport to HOSTPORT, NAME to aciportname, and the related aciport to find what app to pass the listening fd to.

This was actually a bug, the way you describe is how it's supposed to work.
Here's a fix: #2138

We're still discussing the right UX for this. Stay tuned...


ARROW-4033: [C++] Use readlink -f instead of realpath in dependency download script

This documentation might be better moved to the Sphinx docs.

+1. This only failed because of the Gandiva microbenchmark taking too long


Merged fork pulls

Single pull req for Napkins's fork pull request with all commits merged together and conflicts cleared

MERGE APPROVE:


In unfilled masks, static characters are duplicated

Describe the bug
In unfilled masks, static characters are duplicated.
In the example, the number 7 is duplicated.
Mask: "+7 (999) 999-99-99",
Value: "+7 (123) 123-12-3_",
View:  "+7 (712) 312-31-23".
Live example
https://jsfiddle.net/0ujgqf7b/
Please complete the following information:

OS: Ubuntu 16
Browser Google Chrome Version 70.0.3538.110 (Official build), (64 bit)
Inputmask version 5.0.0-beta.158

Fixed in the current beta
https://jsfiddle.net/mnoq1k3y/


Download article does not complete

When I try to download an article, my query

newsplease.NewsPlease.download_article('http://www.thehindu.com/todays-p    ...: aper/tp-national/tp-otherstates/Elephant-destroys-three-houses-in-Meghal    ...: aya-village/article17026523.ece')

does not complete or time-out on Python 3.5.2. On Python 2.7.3, however, it returns a result, but also returns the following TypeError

Traceback (most recent call last):   File "/Users/mdmadhusudan/anaconda/envs/earthengine/lib/python2.7/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks     current.result = callback(current.result, *args, **kw)   File "/Users/mdmadhusudan/anaconda/envs/earthengine/lib/python2.7/site-packages/newsplease/pipeline/pipelines.py", line 365, in process_item     json.dump(ExtractedInformationStorage.extract_relevant_info(item), file_) TypeError: unbound method extract_relevant_info() must be called with ExtractedInformationStorage instance as first argument (got NewscrawlerItem instance instead)

I am on macOS Sierra. Any suggestions on how to fix either? Thanks.

Should be fixed now in both versions (Py2.7 and 3.x). I also packaged the new code to PyPI so that you can simply perform pip install news-please --upgrade. Please let me know if this does work for you.

Thanks, Felix! Confirming that the upgrade fixes this issue on Python 3.5.2.

On 29-Mar-2017, at 2:44 PM, Felix Hamborg<EMAIL_ADDRESS>wrote:
Should be fixed now in both versions (Py2.7 and 3.x). I also packaged the new code to PyPI so that you can simply perform pip install news-please --upgrade. Please let me know if this does work for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/fhamborg/news-please/issues/22#issuecomment-290031491, or mute the thread https://github.com/notifications/unsubscribe-auth/AGtdY1Kawh2RikmydlcXMWuP8A6J_6hDks5rqiEEgaJpZM4MsZ0a.


Add documentation of NeptuneLogger class

Closes #8
Currently, evotorch.logging.NeptuneLogger is undocumented in the user guide, as described in #8 . This pull request resolves this issue by adding an additional section of documentation to userguide/logging in the documentation.

Codecov Report

Merging #15 (e458798) into master (b845b9a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e458798 differs from pull request most recent head 2b2f01d.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Ability to disable nesting only or dragging only, data-nestable-disabled attribute functionality

Hello,
I am wondering if it would be possible to add parameter to select what to disable.
Example data-nestable-disabled="nesting" would disable nesting new items into it, but you could still drag the item itself wherever you want. And data-nestable-disabled="dragging" would disable dragging, but you could still nest items into it.
Also, really great work on the lib. Finally great jquery free nestable alternative :)

Implemented in v0.2.0
Reopen if needed.


chore(main): release ngx-intl 2.0.0

:robot: I have created a release beep boop
2.0.0 (2022-08-08)
⚠ BREAKING CHANGES

temp. remove intl-list pipe

Bug Fixes

temp. remove intl-list pipe (b3f2f3b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/haiilo/ngx-intl/releases/tag/ngx-intl-v2.0.0 :sunflower:


Feature: Flag tasks with new version available

Pipeline designer shows flag next to build tasks, which exists newer version for. For example, when the build uses Azure App Service Deploy version 3, there is flag that version 4 is available.
It would be nice, if the VSCode extension underlines the task. For example, when there is task: AzureRmWebAppDeployment@3 in YAML, it would get underlined, because task: AzureRmWebAppDeployment@4 is available.

Agreed, we could do this with a Hint diagnostic.

note that there's also new versions available but at preview.  So you don't want to necessarily push too hard in that case.  Also, whatever we do, it shouldn't be conveyed as an error - more of an FYI

Hi all, just a quick update on this feature request:
In order to implement such a feature, we need to update the language server first. Per the investigation, it seems that the main work for this feature needs to be implemented on the "language server" side.
I have already opened the related issue at the language server repo:

https://github.com/microsoft/azure-pipelines-language-server/issues/120

After all work for the language server will be completed, we will introduce the new feature flag by the next possible solution:

Get the new flag from the settings.json VS Code user config file
Send this flag to the language server


Fix small typo

@nielmistry : Thanks for your contribution! The author, @cawa, has been notified to review your proposed change.

@nielmistry - Thanks so much for your contribution! The article has been updated, and this text has been removed.
#please-close


More Adaptable Type Name Generation Logic

When there are multiple data models with the same name, the default behavior is that a counter assigns each duplicate model an incrementing suffix.
I tried to assign more meaningful names to duplicate types by using their namespaces. Non-duplicate ones should remain to have simple names without namespaces. And duplicate ones should incorporate only the parts of the namespace just enough to differentiate them, not the complete namespace.
But as far as I have examined, there seems to be no pluggable way to do this without changing the source code.
So, I have forked the project and created the following pull request: https://github.com/RicoSuter/NSwag/pull/2218
In order for this to work, I also had to make changes to the NJsonSchema project so that AppendSchema method would receive the type information: https://github.com/RicoSuter/NJsonSchema/pull/1001
The only problem is that in its current state, this becomes the default behavior. I tried to factor out the namespace related code so that it would be a generic solution where anyone could inject this behavior at will. But due to various serializations and deserializations of the OpenApiDocument, it loses the DefinitionsMap variable which I used to contain the type related information along with the generated and duplicate type names. So the following code which I used to generate the document does not have access to this type information:
var command = new WebApiToOpenApiCommand();

command.AssemblyPaths = new string[] { @"....dll" };
command.OutputFilePath = "swagger.json";

var doc = (OpenApiDocument)command.RunAsync(null, new ConsoleHost()).Result;
var docJson = doc.ToJson();

It would be great if someone could pitch in to extract this logic away from WebApiOpenApiDocumentGenerator.cs to the consumer code above. If the above code has access to the DefinitionsMap, then it would be possible to abstract away this postprocessing into a customizable structure. We can even define a "namespace-when-duplicate" kind of parameter and keep this logic as a parametric option while still exposing the DefinitionsMap structure for extensibility.

I am currently facing the same issue.
I have no input but will follow this issue.

With the WebApiOpenApiDocumentGenerator you can provide a custom implementation of the ISchemaNameGenerator (in NJsonSchema) to customize the type name generation.

With the WebApiOpenApiDocumentGenerator you can provide a custom implementation of the ISchemaNameGenerator (in NJsonSchema) to customize the type name generation.

Thanks for the input RicoSuter.
Is there any sample how to use the AspNetCoreOpenApiDocumentGenerator? as this is the generator for the Asp.Net Core.
I've tried to implement a new SchemaGenerator as below:
public class Foo : ISchemaNameGenerator
{
	public string Generate(Type type)
	{
		return type.FullName;
	}
}

and using it as:
services.AddSwaggerDocument(x =>
{
	x.SchemaType = SchemaType.OpenApi3;
	x.SchemaNameGenerator = new Foo();
});

But the result is not reflected in the swagger.json or the swaggerUI.
Am I doing something wrong here?

But the result is not reflected in the swagger.json or the swaggerUI.

I think it always uses the last segment of the .
Quickly try
public class Foo : ISchemaNameGenerator
{
	public string Generate(Type type)
	{
		return type.Name  + "Dto";
	}
}

But the result is not reflected in the swagger.json or the swaggerUI.

I think it always uses the last segment of the .
Quickly try
//code..

Thanks!
Now I understand that in order to accomplish the result i want I need to use both SchemaNameGenerator and TypeNameGenerator in synergy.
public class Bar : ITypeNameGenerator
{
	public string Generate(JsonSchema schema, string typeNameHint, IEnumerable<string> reservedTypeNames)
	{
		return typeNameHint;
	}
}

public class Foo : ISchemaNameGenerator
{
	public string Generate(Type type)
	{
		return type.FullName;
	}
}

This will create a ModelName/Typename that consist of the full namespace.

@RicoSuter Could you also comment on the initial issue and the related pull requests please?

Here an implementation sample found in stack overflow: https://stackoverflow.com/questions/45241177/nswag-namespace-in-model-names
Did anyone tried this approach?
Anyway it would be good to have this  out of the box as configuration property within Nswag generator.
An idea: GenerateTypesWithFullNamespaces = true

Has there been any progress on this issue?


Env updates

This PR updates conda package versions for the course (see #10).

Conflicts resolved, will merge if you don't have any objections @verku @fasterius


Clarify "incorrect facets mapping" error

Using Baobab I have found that it's quite frequent to run into the "incorrect facets mapping" error:
  baobab.Facet: incorrect facets mapping.   facet.js:47

While it's clear I have some typo somewhere or I failed to require something, wouldn't it be a good idea to explain this error a little bit?
I mean, explaining at what point Baobab checks for that and where to trace the error.

This time I found it was due to using ['facetName'] instead of 'facetName'. I think it's easy to run into this because of the facets API. But I'll close this since its covered in issue #195

Nonetheless, a more helpful error message wouldn't hurt :).


Removed unused methods from EventBus interface.

We removed the following methods from "org.apache.cloudstack.framework.events.EventBus" and it respective implementations.
. org.apache.cloudstack.framework.events.EventBus.subscribe(EventTopic, EventSubscriber)
. org.apache.cloudstack.framework.events.EventBus.unsubscribe(UUID, EventSubscriber)
the following files are affected by this PR:
org.apache.cloudstack.mom.inmemory.InMemoryEventBus, org.apache.cloudstack.mom.kafka.KafkaEventBus and org.apache.cloudstack.mom.rabbitmq.RabbitMQEventBus
Those methods are not used in cloudstack, they are used only in some test cases and these tests cases were removed too.

Did you try rebuilding CS with each type of event queue?

ACS CI BVT Run
Sumarry:
Build Number 149
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=4
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:

<nose.suite

ContextSuite context=TestScaleVm>:setup Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
Passed test suits:
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering

@bvbharat I see that a test failed; I checked the logs and it seems that it was because it failed to apply the port forwarding rule. However, I could not find anything else (more details about the errors).
Could you help us to track if the failure is really due to the code changes?


DeletedTerms#clear should reset ByteBlockPool

Description
This is a bug left by #12573. As we are using a common ByteBlockPool across all BytesRefHash, the map clear won't help release the memory held by ByteBlockPool and the pool will allocate new slices when new terms added because the offset is never reset.
Sorry for the missing!

wow good catch. Out of curiosity, how did you catch it? Are you running snapshot Lucene builds in production?

Just to confirm: the previous PR was not released/included in 9.8.0 right? So users are not hitting this memory leak when using the 9.8.0 release.

Yes, the previous PR is not included in 9.8.0 release.

Out of curiosity, how did you catch it? Are you running snapshot Lucene builds in production?

Not really, just come up this accidentally when reading codes :)


IndieAuth?

Somebody suggested we look into IndieAuth.
https://indieauth.com/developers
I could see a scenario where we continue to allow un-auth'ed users, but if somebody wants to authenticate in some way they could be shown as such in the chat via some kind of styling.
Just an idea we can think about for down the road.

Happy to help make this happen

Awesome!  The web UI is going through a refactor right now (#103), so any changes that effect the frontend will need to wait for that.  But it allows for some brainstorming of how this might function in the meantime.
It looks like not a lot of services provide support for IndieAuth.  When testing it with my web site that has Mastodon, Keybase, Linkedin, Spotify and LastFM links only Github came back as a provider.  This is fine, but it does put it a bit in the category of something only advanced/power users would use or understand unless mainstream services (Like Facebook or Instagram or something) were compatible.
If only power users were to use this, and we style people to say "these people are authenticated and these people are not" then it kind of creates this weird dichotomy in the chat between people who support a very specific thing and those who don't.
All something to think about.

Indie web is just oauth right?  If so I’d target oauth and let people chose to use indie web, or maybe even their own solution

I don't believe at the moment we have a solid use case for adding any user-facing auth, especially after we removed avatars in chat, so I'm closing this.


[* DateTimeV2] Time resolution not consistent across cultures.

Time resolution of certain time expressions in CJK implementation is not always consistent with standard implementation.
For example in DateTimePeriod: "今日の午後4時から明日の午後5時まで" (from 4pm today to 5pm tomorrow) resolves to "(2016-11-07T16:00:00,2016-11-08T17:00:00,PT25H)" while in standard implementation the resolution is "(2016-11-07T16,2016-11-08T17,PT25H)"
CJK should be made consistent with standard implementation.

@tellarin, in standard DateTimePeriod when both sides contain a date the duration is rounded to the hour, e.g.
"between jan 12 at 4pm and jan 12 at 5.30pm" -> (XXXX-01-12T16,XXXX-01-12T17:30,PT2H).
Instead when only one date is present the duration is not rounded, e.g.
"jan 12 between 4pm and 5.30pm" -> (XXXX-01-12T16,XXXX-01-12T17:30,PT1H30M).
Should we fix this discrepancy or is it so by design?

@aitelint This is indeed a bug. The non-rounded resolution is the correct one. Thanks for tracking it.


Add tests for ensuring kubernetes sync

What this PR does / why we need it:
Generating pkg/app/piped/executor/mock.go with Bazel has a cycle import issue (https://github.com/pipe-cd/pipe/issues/820), hence manually generated for now:
mockgen -source=./pkg/app/piped/executor/executor.go -destination=./pkg/app/piped/executor/mock.go -package=executor

I will add more test cases as another PR if no problem to keep going.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Do we have any better way? (We should avoid using an external command to generate the code and push them to Git)

The surest way is resolving https://github.com/pipe-cd/pipe/issues/820 at first.

I'd better address that, wouldn't it?

Yes, let's do it.

👍

I noticed no need to use mock for LogPersister, just fake is enough. It doesn't require to check the log output precisely.

Just now applied it.

Nice.
/approve


TF-slim: slim.evaluation.evaluation_loop results in code run that is stuck without progress.

Hi all, I am unsure why the evaluation loop would result in the code not running. My GPU memory is not consumed or whatsoever, and my CPU memory usage is at a minimum. This is what I get:
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcublas.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcudnn.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcufft.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcurand.so locally
Starting Evaluation of Validation Dataset
predictions type: Tensor("Cast_2:0", shape=(?,), dtype=float32)
Running evaluation Loop...
WARNING:tensorflow:From /usr/local/lib/python2.7/dist-packages/tensorflow/contrib/slim/python/slim/evaluation.py:426 in evaluation_loop.: __init__ (from tensorflow.python.training.summary_io) is deprecated and will be removed after 2016-11-30.
Instructions for updating:
Please switch to tf.summary.FileWriter. The interface and behavior is the same; this is just a rename.
INFO:tensorflow:Waiting for new checkpoint at ../preprocessedData/model.ckpt-50

All I did was to run this:
print 'Starting Evaluation of Validation Dataset'
#Load the validation dataset for evaluation while training
test_dataset = get_split('validation', train_dir)
test_images, _, test_labels = load_batch(test_dataset, height = image_size, batch_size = batch_size, width = image_size, is_training = False)

with slim.arg_scope(inception_resnet_v2_arg_scope()):
	logits, _ = inception_resnet_v2(test_images, num_classes = test_dataset.num_classes, is_training = False)

predictions = tf.argmax(logits, 1)
predictions = tf.cast(predictions, tf.float32)
print 'predictions type:', predictions
# print tf.Print(predictions)

# Define the metrics:
names_to_values, names_to_updates = slim.metrics.aggregate_metric_map({
	'streaming_auc': slim.metrics.streaming_auc(predictions, test_labels),
    # 'eval/Accuracy': slim.metrics.streaming_accuracy(predictions, test_labels),
    # 'eval/Recall@5': slim.metrics.streaming_recall_at_k(logits, test_labels, 5),
})

print'Running evaluation Loop...'
checkpoint_path = tf.train.latest_checkpoint(log_dir)
metric_values = slim.evaluation.evaluation_loop(
    master='',
    checkpoint_dir=checkpoint_path,
    logdir=log_dir,
    eval_op=names_to_updates.values(),
    final_op=names_to_values.values())

It's been a really long time since there is no progress. Is the function working?

Thanks @kwotsin ! First off, you probably want to pay heed to the warning and see if your problem disappears after that. Then, I would suggest using tf.Print the tf debugger, or asking for parts of the graph that are earlier than that. If that doesn't work for you, please ask piecemeal questions on stackoverflow, where we monitor all questions with the tag "tensorflow".

Hi @kwotsin ,
I am trying to evaluate InceptionV3 on Imagenet using the same script but with slim.evaluation.evaluate_once() and I see no usage of GPU (RTX 2080) or any significant CPU activity. Is there a solution to the issue?
Thank you!


HTML '!" starter is not working

Issue Type: Bug
anytime I start a HTML file and type ! + tab nothing happens
VS Code version: Code 1.69.1 (b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a, 2022-07-12T08:21:24.514Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Extensions (6)

Extension
Author (truncated)
Version

dark-synthwave-vscode
Aar
0.0.14

todo-tree
Gru
0.0.215

deepdark-material
Nim
3.3.0

indent-rainbow
ode
8.3.1

html5-boilerplate
sid
1.1.1

open-in-browser
tec
2.0.0

(5 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627cf:30244335
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vscaac:30438847
pylanb8912cf:30520717
vsclangdc:30486549

/duplicate of #154375
Fix should be released in 1.69.2 but in the meantime you can manually trigger suggestions with Ctrl+Space

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Fix: Add linting, GitHub Actions, package meta

Package meta:

Corrected to non-production-ready version
Add Corbin's URL
npm update
move deps to to peers and non-dev (are these correct?)
engines and files properties
README.md shell

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[SPARK-14930][SPARK-13693] Fix race condition in CheckpointWriter.stop()

CheckpointWriter.stop() is prone to a race condition: if one thread calls stop() right as a checkpoint write task begins to execute, that write task may become blocked when trying to access fs, the shared Hadoop FileSystem, since both the fs getter and stop method synchronize on the same lock. Here's a thread-dump excerpt which illustrates the problem:
"pool-31-thread-1" #156 prio=5 os_prio=31 tid=0x00007fea02cd2000 nid=0x5c0b waiting for monitor entry [0x000000013bc4c000]
   java.lang.Thread.State: BLOCKED (on object monitor)
    at org.apache.spark.streaming.CheckpointWriter.org$apache$spark$streaming$CheckpointWriter$$fs(Checkpoint.scala:302)
    - waiting to lock <0x00000007bf53ee78> (a org.apache.spark.streaming.CheckpointWriter)
    at org.apache.spark.streaming.CheckpointWriter$CheckpointWriteHandler.run(Checkpoint.scala:224)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

"pool-1-thread-1-ScalaTest-running-MapWithStateSuite" #11 prio=5 os_prio=31 tid=0x00007fe9ff879800 nid=0x5703 waiting on condition [0x000000012e54c000]
   java.lang.Thread.State: TIMED_WAITING (parking)
    at sun.misc.Unsafe.park(Native Method)
    - parking to wait for  <0x00000007bf564568> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
    at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
    at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
    at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1465)
    at org.apache.spark.streaming.CheckpointWriter.stop(Checkpoint.scala:291)
    - locked <0x00000007bf53ee78> (a org.apache.spark.streaming.CheckpointWriter)
    at org.apache.spark.streaming.scheduler.JobGenerator.stop(JobGenerator.scala:159)
    - locked <0x00000007bf53ea90> (a org.apache.spark.streaming.scheduler.JobGenerator)
    at org.apache.spark.streaming.scheduler.JobScheduler.stop(JobScheduler.scala:115)
    - locked <0x00000007bf53d3f0> (a org.apache.spark.streaming.scheduler.JobScheduler)
    at org.apache.spark.streaming.StreamingContext$$anonfun$stop$1.apply$mcV$sp(StreamingContext.scala:680)
    at org.apache.spark.util.Utils$.tryLogNonFatalError(Utils.scala:1219)
    at org.apache.spark.streaming.StreamingContext.stop(StreamingContext.scala:679)
    - locked <0x00000007bf516a70> (a org.apache.spark.streaming.StreamingContext)
    at org.apache.spark.streaming.StreamingContext.stop(StreamingContext.scala:644)
    - locked <0x00000007bf516a70> (a org.apache.spark.streaming.StreamingContext)
[...]

We can fix this problem by having stop and fs be synchronized on different locks: the synchronization on stop only needs to guard against multiple threads calling stop at the same time, whereas the synchronization on fs is only necessary for cross-thread visibility. There's only ever a single active checkpoint writer thread at a time, so we don't need to guard against concurrent access to fs. Thus, fs can simply become a @volatile var, similar to lastCheckpointTime.
This change should fix SPARK-13693, a flaky MapWithStateSuite test suite which has recently been failing several times per day. It also results in a huge test speedup: prior to this patch, MapWithStateSuite took about 80 seconds to run, whereas it now runs in less than 10 seconds. For the streaming project's tests as a whole, they now run in ~220 seconds vs. ~354 before.
/cc @zsxwing and @tdas for review.

Test build #57030 has started for PR 12712 at commit 61a388a.

Test build #57030 has finished for PR 12712 at commit 61a388a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57030/
Test FAILed.

Jenkins, retest this please.

Test build #57040 has started for PR 12712 at commit 61a388a.

Test build #57040 has finished for PR 12712 at commit 61a388a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57040/
Test PASSed.

Merged build finished. Test PASSed.

LGTM, thanks for fixing this!

LGTM. Merging to master


Mark Close after PCapWriter is closed

Motivation:
Right now, we mark PcapWriteHandler as closed even before closing PcapWriter. When we call PcapWriter#close, it detects the state to be closed and ignores closing OutputStream.
Modification:
To prevent this from happening, we should call markClosed only after calling PcapWriter#close.
Also added CloseDetectingByteBufOutputStream to detect close call and assert it in the test case.
Result:
Properly close PcapWriter and prevent memory leak of OutputStream.

@hyperxpro can you also do this for 5.x ?

Sure!


ParseRaw Json file Failing To Decode

To reproduce:

git clone https://github.com/0xPrimata/test-parse-json

forge script ConfigScript

Comment out _loadConfig(); in Config.s.sol

forge script ConfigScript

Expected Behavior:
Being able to read from index 0 to index 4 ofaddress[] labsSigners; and address[] foundationSigners; in either ConfigData structs.
Currently both error with script failed: panic: array out-of-bounds access (0x32).
Considering that this might be an issue with Solidity itself and the behavior of data storage of multiple arrays in a struct, but currently unaware of it.

Does parseJson return the keys in alphabetical order?


Add configuration via environment variables

An explicit path and options for emacsclient (shoutout to @meereeum for suggesting a way of doing this)
Make copying and pasting optional

done


How can i display a specific tooltip in a line chart, but also display the tooltip when dragging.

I'm creating a line chart, but there are a few conditions.

The maximum and minimum values should be displayed as tooltips in the line chart.
When dragging on the line chart, the tooltip should be displayed automatically.

I was making a chart while looking at example 5, but
The tooltip is not displayed when dragging because the handleBuiltInTouches of LineTouchData is set to false.
I want a chart similar to the following photo.

Thank you for your help.

Hi, you can just disable the built-in touches (just like what we did in example 5), then implement your custom touch handling.
(just take a look at the default touch handling that we have built-in)

I have another approach, create another class that extends FlDotPainter. And inside that class, we will draw the information that we want to display the info.
This is my implementation of my chart:
class FlDotTodayPainter extends FlDotPainter {

  /// This class is an implementation of a [FlDotPainter] that draws
  /// a circled shape and a "today" indicator
  FlDotTodayPainter({
    required this.color,
    this.dotRadius = 4.0,
    this.cornerRadius = 4.0,
    this.dotColor,
    this.dotStrokeWidth = 0.0,
    this.offsetFromDot = 8.0,
    this.textPadding = EdgeInsets.zero,
  });

  Color color;

  double dotRadius;

  /// Optional color for dot color
  Color? dotColor;

  /// The stroke width to use for the circle
  double dotStrokeWidth;

  double offsetFromDot;

  EdgeInsets textPadding;

  double cornerRadius;

  double get _colorLum => color.computeLuminance();

  void _drawDot(Canvas canvas, FlSpot spot, Offset offsetInCanvas) {
    if (dotStrokeWidth != 0.0) {
      canvas.drawCircle(
        offsetInCanvas,
        dotRadius + (dotStrokeWidth / 2),
        Paint()
          ..color = dotColor ?? color
          ..strokeWidth = dotStrokeWidth
          ..style = PaintingStyle.stroke,
      );
    }

    canvas.drawCircle(
      offsetInCanvas,
      dotRadius,
      Paint()
        ..color = color
        ..style = PaintingStyle.fill,
    );
  }

  void _drawText(Canvas canvas, FlSpot spot, Offset offsetInCanvas) {
    final textSpan = TextSpan(
      text: 'Today'.hardcoded,
      style: kHeader3TextStyle.copyWith(
        color: _colorLum < 0.5 ? AppColors.white : AppColors.black,
        fontSize: 10,
      ),
    );

    final textPainter = TextPainter(
      text: textSpan,
      textDirection: TextDirection.ltr,
      textAlign: TextAlign.center,
    )..layout(
        minWidth: 0,
        maxWidth: 150,
      );

    // Offset to center with the dot
    final textOffset = Offset(
      offsetInCanvas.dx - (textPainter.width / 2),
      offsetInCanvas.dy + offsetFromDot + textPadding.top,
    );

    canvas.drawRRect(
      RRect.fromLTRBAndCorners(
        textOffset.dx - textPadding.left,
        textOffset.dy - textPadding.top,
        textOffset.dx + textPainter.width + textPadding.right,
        textOffset.dy + textPainter.height + textPadding.bottom,
        topLeft: Radius.circular(cornerRadius),
        topRight: Radius.circular(cornerRadius),
        bottomRight: Radius.circular(cornerRadius),
        bottomLeft: Radius.circular(cornerRadius),
      ),
      Paint()
        ..color = color
        ..style = PaintingStyle.fill,
    );

    textPainter.paint(canvas, textOffset);
  }

  /// Implementation of the parent class to draw the circle
  @override
  void draw(Canvas canvas, FlSpot spot, Offset offsetInCanvas) {
    _drawDot(canvas, spot, offsetInCanvas);

    _drawText(canvas, spot, offsetInCanvas);
  }

  ...
}

I have the same problem. How did you solve it，pleease tell me,Thanks


Firefox & Chrome Commands Don't Work

For some reason, I can't get the firefox and chrome commands to work. If were unable to scat flash our victims then it's useless. You have to be able to take it to the extreme. We won't mention

What about a scat command


Settings Tab: Restore Defaults button doesn't work from 2nd click

Platform: MacOS

This problem is still there as of 4/20/2018.


Fix collection pagination and add test

This might have been an issue with babel compilation -- essentially, the options passed in to fetchPage were not actually being passed for Collections, resulting in fetchPage always returning the default page and pageSize.
Fixes #1258

don't forget this:
bookshelf.plugin('pagination');
look this [https://github.com/tgriesser/bookshelf/wiki/Plugin:-Pagination]


[SPARK-26745][SQL] Revert count optimization in JSON datasource by SPARK-24959

What changes were proposed in this pull request?
This PR reverts JSON count optimization part of #21909.
We cannot distinguish the cases below without parsing:
[{...}, {...}]

[]

{...}

# empty string

when we count(). One line (input: IN) can be, 0 record, 1 record and multiple records and this is dependent on each input.
See also https://github.com/apache/spark/pull/23665#discussion_r251276720.
How was this patch tested?
Manually tested.

Not only in JSON, in CSV as well.


Support for a Claude 3 and Mistral

Support for a Claude 3 and Mistral

+1

This is what I got when I tried:
Error invoking the model: ValidationException(properties: AWSBedrockRuntime.ValidationException.Properties(message: Optional("The provided model identifier is invalid.")), httpResponse: Status Code: http_status_400 Content-Type: application/json, Date: Tue, 05 Mar 2024 14:16:48 GMT, Content-Length: 55, Connection: keep-alive, x-amzn-ErrorType: ValidationException:http://internal.amazon.com/coral/com.amazon.bedrock/, x-amzn-RequestId: 19af9adc-a147-4045-aa39-b1ed5cbf4896, message: Optional("The provided model identifier is invalid."), requestID: nil)

FYI: Claude 3 supports file uploads so it'd be interesting to support that as well

+1

Claude 3's new version v1.1.4 has been released. Please let me know if you encounter any issues while using it.

Now also supports image upload.

@didhd does the API support uploading PDF files?

@NathanHazout Bedrock API itself does not support PDF files. We need to create some kind of PDF extractor inside the app.


🌱 extraannotationsync: use function pointers

Summary
Switch from storing listers/indexers as struct fields to using function pointers to implement listing/getting data from the informer caches.

/approve

/lgtm


How install cerebro plugin with command line?

How install cerebro plugin with command line?

very help full


[Feature] Add ability to change table column width using Table/Column settings

Currently I can change the table column width by drag the column separator.
While this works, it is not ideal for some cases.
One case is when I want to set the column width to a specific size numerically.  This is not possible today.
Another case is when trying to resize the last column of the table.
It's currently very tricky to place the pointer to exactly the right spot to enable dragging to change the size.
Many times I end up resizing the whole tables instead.

@mingfang thank you for the feature request!

HI, is this request still open? I am too looking for fixing the column width but in vain. Though I set the width it gets automatically changed with presence or absence of data. DO we not have a fix for setting the column width yet

Hey @pjgittst this is still not prioritized!

Would love to the feature as well. My use case is actually making columns smaller than dragging allows. My users mostly using phones.

This feature would be extremely useful especially for columns that have text wrap enabled.  If their initial column width is small, the entire table looks horrible on load.

+1 on the feature request

Another use case is setting some columns to be only as wide as needed to fit the content. We have a few tables where the first column is an icon button to trigger an action, and since we have a lot of content to display it would be great if it wasn't wider to start with.

+1 for this. This would make tables much more cleaner and easier to read while optimizing the real estate on the page.
And related to @floretan's comment there's this feature request for auto sizing the width based on the content https://github.com/appsmithorg/appsmith/issues/35347


build error on latest master

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Centos 7.4.1708
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:NA
TensorFlow installed from (source or binary): source
TensorFlow version: commit 0e4117f67192a140466ba66513035e24bbd1a474
Python version: 3.6
Installed using virtualenv? pip? conda?: source
Bazel version (if compiling from source):0.22.0
GCC/Compiler version (if compiling from source): gcc 6.3.0
CUDA/cuDNN version: NA
GPU model and memory:NA

Describe the problem
Provide the exact sequence of commands / steps that you executed before running into the problem
ERROR: /home/guizili/.cache/bazel/_bazel_guizili/fb08bc8aff974002b12a4e85119bd120/external/com_github_googlecloudplatform_google_cloud_cpp/google/cloud/BUILD:27:1: no such target '@bazel_tools//tools/cpp:cc_flags': target 'cc_flags' not declared in package 'tools/cpp' defined by /home/guizili/.cache/bazel/_bazel_guizili/fb08bc8aff974002b12a4e85119bd120/external/bazel_tools/tools/cpp/BUILD and referenced by '@com_github_googlecloudplatform_google_cloud_cpp//google/cloud:generate_build_info'
ERROR: Analysis of target '//tensorflow/tools/pip_package:build_pip_package' failed; build aborted: Analysis failed
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

The same problem here (attempt to build from master) :

Ubuntu 18.04
Bazel version: 0.23.1
Python version: 2.7.15rc1 and 3.6.7

This is because, we need bazel 0.24.0 or above to build the latest master. Try with bazel 0.24.0 or 0.24.1.

updating Bazel  to 0.24.1 solves this build issue.

Here is a tip for compiling the tensorflow master branch.In many cases only certain versions of bazel can be successfully compiled.Check the Continuous build status, read the compile log for the corresponding version, and find the available bazel version.

Thanks all it works on 0.24.1.
Basically, if the bazel version need upgrade, TF will increase the minimal supported version of bazel, that maybe a issue.

The minimal version of bazel was updated yesterday in https://github.com/tensorflow/tensorflow/commit/407a4f3b9d39055a981b91c15f6911fdb38135d5
I think this defect is resolved.

I am closing the issue as it was resolved. But, please let me know if I'm mistaken.

Update 0.23.1 -> 0.25.2 helped.


drivers: nrf_802154: nrf_802154_trx.c - assertion fault when enabling Segger SystemView tracing

Describe the bug
Assertion fault (radio not disabled) in IRQ handler when receiving a radio packet via nRF 802154 driver while tracing with Segger SystemView backend is enabled.
To Reproduce
Steps to reproduce the behavior:

Enable Tracing together with the nRF 802.15.4 radio driver

# Tracing
CONFIG_TRACING=y
CONFIG_SEGGER_SYSTEMVIEW=y

#Radio
CONFIG_IEEE802154=y
CONFIG_NET_L2_IEEE802154=y
CONFIG_NET_L2_IEEE802154_RADIO_CSMA_CA=y

Build and flash some app with radio reception to the target hardware (nRF52840)
Wait for incoming packet.
The assertion will trip as documented below. The condition can even be reproduced in a debugging session - see stacktrace below.

Obs: It is NOT necessary for the SystemView application to be connected and running. The exception will occur even when just running the application.
Expected behavior
The IRQ should work independently of tracing being enabled or not.
Impact
Tracing is not usable while receiving packets on the radio.
Logs and console output
ASSERTION FAIL @ WEST_TOPDIR/modules/hal/nordic/drivers/nrf_802154/driver/src/nrf_802154_trx.c:1379
[00:00:03.325,103] <err> os: r0/a1:  0x00000004  r1/a2:  0x00000563  r2/a3:  0x20005a5c
[00:00:03.325,134] <err> os: r3/a4:  0x00000000 r12/ip:  0x00000000 r14/lr:  0x0001d043
[00:00:03.325,134] <err> os:  xpsr:  0x61000011
[00:00:03.325,164] <err> os: Faulting instruction address (r15/pc): 0x0002959a
[00:00:03.325,195] <err> os: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
[00:00:03.325,225] <err> os: Fault during interrupt handling
[00:00:03.325,256] <err> os: Current thread: 0x20002518 (idle)
[00:00:04.157,745] <err> os: Halting system

This is the stack trace:
wait_until_radio_is_disabled@0x0001d024 (zephyr/modules/hal/nordic/drivers/nrf_802154/driver/src/nrf_802154_trx.c:1379)
rxframe_finish@0x0001d602 (zephyr/modules/hal/nordic/drivers/nrf_802154/driver/src/nrf_802154_trx.c:1461)
irq_handler_crcok@0x0001d812 (zephyr/modules/hal/nordic/drivers/nrf_802154/driver/src/nrf_802154_trx.c:2094)
nrf_802154_radio_irq_handler@0x0001e5da (zephyr/modules/hal/nordic/drivers/nrf_802154/driver/src/nrf_802154_trx.c:2468)
nrf5_radio_irq@0x00030ed4 (zephyr/zephyr/drivers/ieee802154/ieee802154_nrf5.c:731)
??@0x000087ae (zephyr/zephyr/arch/arm/core/aarch32/isr_wrapper.S:259)

And this the context of the assertion that fails:
nrf_802154_trx.c, line 1359ff
static inline void wait_until_radio_is_disabled(void)
{
    nrf_802154_log_function_enter(NRF_802154_LOG_VERBOSITY_HIGH);

    bool radio_is_disabled = false;

    // RADIO should enter DISABLED state after no longer than RX ramp-down time, which is equal
    // approximately 0.5us. Taking a bold assumption that a single iteration of the loop takes
    // one cycle to complete, 32 iterations would amount to exactly 0.5 us of execution time.
    // Please note that this approach ignores software latency completely, i.e. RADIO should
    // have changed state already before entering this function due to ISR processing delays.
    for (uint32_t i = 0; i < MAX_RXRAMPDOWN_CYCLES; i++)
    {
        if (nrf_radio_state_get(NRF_RADIO) == NRF_RADIO_STATE_DISABLED)
        {
            radio_is_disabled = true;
            break;
        }
    }

    assert(radio_is_disabled); /* --> THIS IS THE FAILED ASSERTION */
    (void)radio_is_disabled;

    nrf_802154_log_function_exit(NRF_802154_LOG_VERBOSITY_HIGH);
}

Environment (please complete the following information):

OS: Linux
Board: adafruit_feather_nrf52840
Toolchain: west build/flash with JLink EDU, V7.66a, SystemView V3.32
Commit: zephyr main @ 47ef58e8ac

Additional context
n/a

Unfortunately, I don't have access to adafruit_feather_nrf52840, but I've tried to reproduce the issue with my nrf52840dk_nrf52840 DK but with no success. I've used echo_server/echo_client samples, with all the configs you mention enabled, but got no luck hitting the assert. The sample just keeps working, regardless of SystemView being connected or not.
@jciupis Did you perhaps encounter any problems with the aforementioned assert in the past?

@rlubos No, I don't recall this assert ever causing any trouble.

@rlubos, @jciupis  Would it help you if I provided the source code of my application? It's not exactly open source, but it's also not very sensitive. I could push it to a private repository on github and let you have a look. As I'm using the usual abstractions (pinctrl, devicetree, etc.) it shouldn't be too hard to make it work on a standard Nordic dev kit which is very similar to the Feather. Unfortunately it is quite hard to provide a minimal showcase as this seems to be some integration issue. Otherwise I'd already have provided a fix as I usually do. I spent considerable time to find the root cause but I've no more ideas where to look...

Oh and of course I'd also be available for a remote debugging session if you like (over whatever video tool you use). But then it's also not that much of a show stopper. So I understand if you don't have the time for any of this of course. Just close if you don't think it worth the effort.

@fgrandel If you could share you app, I can try to reproduce the problem.

@rlubos Ok, will do. Just give me a little time to provide a working example as I'm currently in the middle of implementing a feature. As soon as the issue is (again) reproducible, I'll let you know.

@rlubos You should have gotten an invitation to the private repository. I just checked that the problem is still reproducible with the latest main branch. The problem is in this app: https://github.com/fgrandel/co2sensor/tree/master/edge/firmware/gateway

@fgrandel Thank you for the access. To my surprise, I was able to build your application w/o any modifications needed.
It took me a moment to reproduce, as it seems that it's not only the SystemView that needs to be enabled but also an active USB is needed (application USB cable connected to a host). With both conditions fulfilled, I hit the assert on every first reception, just as described.
Since the problem seems to be quite complex (a lot of factors considered) I might need to seek some help internally in the driver dev team. Therefore I can't give any promises regarding ETA for the fix at this point. But at least I can acknowledge that the problem exists and is reproducible on our DK.

@rlubos Wow, I'm impressed! If I can help anything let me know.

Thanks @carlescufi for keeping the ticket alive. :-)


HBASE-25896 Implement a Region Visualization on Master WebUI

This is a demonstration of visualization of regions on the cluster. The visualization is a stacked
bar chart showing total storefile size per table per region server, with the x-axis being server
names, the y-axis being storfile size, and the bars stacked per table. The visualization is
generated entirely on the fly from within the browser, implemented using Vega Lite. So far, Vega
appears to handle rendering this visualization for a cluster of over 700 region servers with
approximately 300,000 regions.
Per 0, include an update to the top-level LICENSE.txt. Also update LICENSE files in all binary
distributions (i.e., jars), by way of LICENSE.vm. Vega uses a BSD 3-clause variant without
advertising clause, and as such is a "Category A" license, per 1.
No changes are made to the NOTICE files, as per the existing example of bundling the minified
JQuery, which is also a Category A license.

This PR is on top of #4177

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
jshint
0m  0s
jshint was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  0s
master passed

+1 :green_heart:
compile
7m 13s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
9m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
7m 35s
the patch passed

-0 :warning:
javac
7m 35s
root generated 1 new + 1471 unchanged - 1 fixed = 1472 total (was 1472)

-0 :warning:
checkstyle
1m 18s
root: The patch generated 1 new + 89 unchanged - 0 fixed = 90 total (was 89)

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
13m 10s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
10m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

65m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle jshint

uname
Linux 88bae28d2bc9 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bcd9a9acef

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
compile
1m 45s
master passed

+1 :green_heart:
shadedjars
3m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
3m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
388m 12s
root in the patch passed.

413m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f5a5b3e1a544 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bcd9a9acef

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/testReport/

Max. process+thread count
3436 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
12m  5s
the patch passed

-0 :warning:
javac
12m  5s
root generated 1 new + 1468 unchanged - 1 fixed = 1469 total (was 1469)

-0 :warning:
checkstyle
1m 44s
root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
15m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
15m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 11s
The patch does not generate ASF License warnings.

91m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle jshint

uname
Linux 07e69e2d881f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / be0afbf23a

Default Java
AdoptOpenJDK-1.8.0_282-b08

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 50s
master passed

+1 :green_heart:
compile
3m 33s
master passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 53s
the patch passed

+1 :green_heart:
compile
3m 46s
the patch passed

+1 :green_heart:
javac
3m 46s
the patch passed

+1 :green_heart:
shadedjars
6m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  7s
the patch passed

_ Other Tests _

-1 :x:
unit
377m 39s
root in the patch failed.

423m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3c35072854b1 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / be0afbf23a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/testReport/

Max. process+thread count
2508 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
jshint
0m  0s
jshint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  3s
master passed

+1 :green_heart:
compile
6m 14s
master passed

+1 :green_heart:
checkstyle
3m  3s
master passed

+0 :ok:
spotbugs
0m 27s
branch/hbase-assembly no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 12s
branch/hbase-resource-bundle no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 38s
branch/hbase-shaded no spotbugs output file (spotbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m 49s
the patch passed

+1 :green_heart:
compile
6m 11s
the patch passed

+1 :green_heart:
javac
6m 11s
the patch passed

-0 :warning:
checkstyle
0m 51s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
checkstyle
1m 37s
root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+0 :ok:
spotbugs
0m 12s
hbase-resource-bundle has no data from spotbugs

+0 :ok:
spotbugs
0m 38s
hbase-shaded has no data from spotbugs

+0 :ok:
spotbugs
0m 25s
hbase-assembly has no data from spotbugs

_ Other Tests _

+1 :green_heart:
asflicense
0m 59s
The patch does not generate ASF License warnings.

77m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
dupname asflicense javac xml compile spotbugs checkstyle jshint

uname
Linux 9d144f90d773 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f640b7fd27

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-general-check/output/whitespace-tabs.txt

Max. process+thread count
57 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 44s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 51s
master passed

+1 :green_heart:
compile
4m 25s
master passed

+1 :green_heart:
javadoc
3m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 28s
the patch passed

+1 :green_heart:
compile
4m 19s
the patch passed

+1 :green_heart:
javac
4m 19s
the patch passed

+1 :green_heart:
javadoc
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  7s
hbase-resource-bundle in the patch passed.

+1 :green_heart:
unit
0m 55s
hbase-http in the patch passed.

-1 :x:
unit
144m 41s
hbase-server in the patch failed.

+1 :green_heart:
unit
1m  1s
hbase-shaded in the patch passed.

+1 :green_heart:
unit
0m 22s
hbase-assembly in the patch passed.

-1 :x:
unit
286m 49s
root in the patch failed.

464m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4178

Optional Tests
javac javadoc unit compile

uname
Linux 446cd7044249 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f640b7fd27

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/testReport/

Max. process+thread count
2587 (vs. ulimit of 30000)

modules
C: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4178/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Rebased and addressed checkstyle and whitespace issues.


[Draft][Search] Regenerate code using 2023-10-01-preview API version

Regenerating code based on https://github.com/Azure/azure-rest-api-specs/commit/89b513cacdafda3c91b772aded35981825c1be4d

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Search.Documents

@heaths, @tg-msft and @pallavit - This API is approved for the preview release. I have created an issue for tracking the follow-up items related to GA - https://github.com/Azure/azure-sdk-for-net/issues/39081


Remove LoginInfo from Identity trait

@see https://groups.google.com/forum/#!topic/play-silhouette/XiItX-P3ZP0

Coverage increased (+0.05%) to 98.43% when pulling 45ec812024978fceb12d421510709b14b6a3a4c7 on akkie:login-info into 8758b81fd217bee7571c17b35a4605b0dab14256 on mohiva:master.

Coverage increased (+0.05%) to 98.43% when pulling 45ec812024978fceb12d421510709b14b6a3a4c7 on akkie:login-info into 8758b81fd217bee7571c17b35a4605b0dab14256 on mohiva:master.

I like this change :) How about introducing type FakeIdentity.Predicate to make it a bit more explicit?

I think we can remove the predicate function, if we use a Map[LoginInfo, Identity] for the FakeIdentityService and the FakeEnvironment.

That makes sense. Just keeping it clean must be enough as it's not a part of user facing API :)

Coverage increased (+1.63%) to 100.0% when pulling 0c363d51d09278dd9e182117680b7b5826ff0c8b on akkie:login-info into 8758b81fd217bee7571c17b35a4605b0dab14256 on mohiva:master.

Coverage increased (+0.05%) to 98.42% when pulling 0c363d51d09278dd9e182117680b7b5826ff0c8b on akkie:login-info into 8758b81fd217bee7571c17b35a4605b0dab14256 on mohiva:master.


sfk fails hash check during install

The prior version did as well, is SourceForge up to something with the binary. The last version I tweaked the json to pull from the dev site and manually set the the sha 256 to get it to install.

Fixed


[Feature] optional network policy for the operator

The prometheus node-exporter includes an optional default network policy in their helm chart.
It would be nice if a policy that permits only the required access to the operator could be optionally enabled.  https://cloudnative-pg.io/documentation/1.19/security/#exposed-ports
This request specifically ignores any Clusters created by the operator.
For egress perhaps something like:
  egress:
  - to:
    - namespaceSelector:
        matchLabels:
          name: kube-system
    ports:
    - protocol: UDP
      port: 53
    - protocol: TCP
      port: 53
    - port: 443
      protocol: TCP

Yes indeed having an optional network policy will be helpful. I want to implement this as well, is PR welcomed in this repo? If so maybe I can give it a try

@winston0410 sure, PRs are definitely welcome! We kind of try to keep the chart as lean as possible, so unfortunately sometimes we have to reject some PR, but this one feels like a totally valid addition!

Sure, this is my first attempt:
https://editor.networkpolicy.io/?id=c0jMGv4TmUc9l0hV
Not 100% sure about the egress, it will be great if someone who know the project better can help

I have these egress rules:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: egress-cloudnative-pg-policies
  namespace: cloudnative-pg
spec:
  podSelector:
    matchLabels:
      app: cloudnative-pg-operator
  policyTypes:
  - Egress
  egress:
  - # k8s' coreDNS
    to:
    - namespaceSelector:
        matchLabels:
          kubernetes.io/metadata.name: kube-system
    ports:
    - protocol: UDP
      port: 53

  - # k8s API server for leases
    ports:
    - protocol: TCP
      port: 6443

  - # namespace database
    to:
    - namespaceSelector: {}
      podSelector:
        matchLabels:
          cnpg.io/podRole: instance
    ports:
    - protocol: TCP
      port: 5432 # Postgres
    - protocol: TCP
      port: 8000 # Status

And these for Ingress including metrics collection and Istio:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: ingress-cloudnative-pg-policies
  namespace: cloudnative-pg
spec:
  podSelector:
    matchLabels:
      app: cloudnative-pg-operator
  policyTypes:
  - Ingress
  ingress:
  - # CnPG webhook server
    ports:
    - protocol: TCP
      port: 9443

  - # VMagent for metrics scraping
    from:
    - namespaceSelector:
        matchLabels:
          kubernetes.io/metadata.name: monitoring
      podSelector:
        matchLabels:
          app: vmagent
    ports:
    - protocol: TCP
      port: 8080

I do not use a pgbouncer hence I am not sure if the above will block connections to pgbouncer ;)


fix:default choco version for tomcat

fix:use GH App bot to check out (and commit)

Both Chocolatey and GitHub made some breaking changes.