Add Basic Sign-in, Sign-up Pages

Installed django-crispy-forms (used in the HTML pages)
Sign-in and Sign-out pages are available at <IP_ADDRESS>:8000/users/sign_in/, <IP_ADDRESS>:8000/users/sign_up/
Sign-in, Sign-up use Django built-in validations for username, password, password confirmation
If Sign-up is successful, page is redirected to Sign-in page (over wise the form is cleared)
If Sign-in is successful, page is redirected to homepage (over wise the form is cleared)
More features will be implemented in a separate PR
( Sign-in and Sign-up success/fail messages, email validation for<EMAIL_ADDRESS>etc..)

Resolves: #88

@LeonRabinovich Maybe it's better to separate this PR into two PR's Sign-in page and Sign-up page? (if it's not too much mess to separate)
It will be easier to make a CR.
Also, it can be approved faster.
WDYT?

@LeonRabinovich Maybe it's better to separate this PR into two PR's Sign-in page and Sign-up page? (if it's not too much mess to separate)
It will be easier to make a CR.
Also, it can be approved faster.
WDYT?

Well it's possible but it will cause some problems because they Are tightly connected together at some methods.(I will probably need to remove some stuff)
Also, i can only work on it next week, and it will prolong the next PR for the user profile page.
If you think it's critical to split them - let me know.

@LeonRabinovich Maybe it's better to separate this PR into two PR's Sign-in page and Sign-up page? (if it's not too much mess to separate)
It will be easier to make a CR.
Also, it can be approved faster.
WDYT?

I'll split it into 2 diffrent PRs, but probably only on Friday / Saturday


Fix newlines in yabai output

Description
Whenever I cmd + f in my Google Chrome to search the web page, the parsing of the yabai windows output fails due to a newline in the output. Google Chrome will prefix the window title with "Find in page\n":
{
  "title": "Find in page\n    Amazon Web Services Sign-In"
}

I'm not sure since when this was broken, possibly since f165275d1c87fed45129b99da0163459b6f87f0f, but reverting this commit still did not fix this issue.  I got it fixed by adding the | tr -d '\n' at the end instead.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I manually tested this.
Before my commit, it would show "... JSON error..." in the bar if I would cmd + f on a page. After my commit, it works normally.
Test Configuration:

OS version Sonoma 14.5
Yabai version yabai-v7.1.1
Übersicht version Version 1.6 (82)
Google Chrome version 124.0.6367.209

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings

Oh, sorry I must have broken your fix by simplifying the new line cleanup thinking it would still work.


Using Awaitility instead of Thread.sleep() in the integration tests to check for the job status

Build finished.

Build finished.


Fix issue with ObjectUnsubscribedError

This is another fix for issue with ObjectUnsubscribedError. This error occurs very often when component is destroyed (and after that timer executes function whcih requires component).

@mczachurski This happens to me too, I thought it was another library or angualr related error, but noticed the ObjectUnsubscribedErrorImpl error only after triggering the reset function on the carousel component.

Can @sheikalthaf merge this pull request? I got this error to. Thank you!

@mczachurski thanks for the PR. I was busy with my work. can you resolve the conflict. so that i can merge the PR.
Thanks

Hi, I resolved conflicts.

Thanks @mczachurski ,
It will be available in next release.


Add optimized grafana dashboard

This optimized dashboard mainly lowers the cardinality of the CPU
metrics. Specifically instead of using avg(rate(node_cpu_seconds_total
which has a cardinality of total CPUs across all managed clusters, we
instead use cluster:node_cpu:ratio which has a cardinality of 1 per
cluster.
That is with 100 clusters, with 16 CPUs, the cardinality before was
100*16 = 1600, where as with this change we now only fetch 100 metrics.
This should scale quite a bit better on larger installations with many
clusters/nodes.

/test test-unit
/test e2e-kind

/test test-unit

/test test-unit

/test test-unit

/test test-unit

/test images

/retest

/retest

/test e2e-kind

/retest


feat: moving builtins options to builtin plugins

Summary
https://github.com/web-infra-dev/rspack/discussions/4006
deprecate warning is disabled for now, will enable it once document ready

rspack.DefinePlugin
rspack.ProvidePlugin
rspack.ProgressPlugin
rspack.HtmlPlugin
rspack.SwcJsMinimizerPlugin
rspack.SwcCssMinimizerPlugin
rspack.CopyPlugin
rspack.BannerPlugin: conflict with ./lib/BannerPlugin

Test Plan

Test seems failing

What about react fast refresh plugin?

ReactRefreshPlugin is To-Be-Determined based on last meeting, for now dev-server needs handle it manually

ReactRefreshPlugin is To-Be-Determined based on last meeting, for now dev-server needs handle it manually

@ahabhgk How would you like to implement this? Shouldn't we align this to webpack plugin's implementation?

Actually, ReactRefreshPlugin can be implemented as a JS plugin which wraps new ProvidePlugin and add a entry after this PR merged, so a separate JS plugin looks good to me, cc @hardfist

I found it strange this PR not being able to show up in the release note of v0.3.1. Is it included or not?

Not included


Use "Viewer" for CFBundleTypeRole

Changeset e3d89e2a introduced CFBundleTypeRole and CFBundleURLSchemes with "bundid". But changeset 85426020 switched it to "eid". Since "eid" is defined by the BSI (TR) this should be "Viewer" instead of "Editor".
https://developer.apple.com/documentation/xcode/defining-a-custom-url-scheme-for-your-app
Choose a role for your app: either an editor role for URL schemes you define,
or a viewer role for schemes your app adopts but doesn’t define.

Thank you for the PR, you are right, we missed setting the correct CFBundleTypeRole.
As we require signed commits (last sentence in https://github.com/digitalservicebund/useid-app-ios/blob/main/doc/adr/0003-branching-strategy.md#decision) and your commit signature is unverified, please resign your commit. https://docs.github.com/en/authentication/troubleshooting-commit-signature-verification/using-a-verified-email-address-in-your-gpg-key I will merge this PR as soon as this is done.

Done. :-)


Yanyang/change get column accessor

Summary
change getColumnName accessor to public for validation from internal MPs
Testing Done
n/a
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.61%. Comparing base (56c19cb) to head (4f5952d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #437   +/-   ##
=========================================
  Coverage     67.61%   67.61%
  Complexity     1544     1544
=========================================
  Files           138      138
  Lines          6059     6059
  Branches        654      654
=========================================
  Hits           4097     4097
  Misses         1684     1684
  Partials        278      278

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enable checkstyle for all modules

FEATURE REQUEST

Please describe the feature you are requesting.

checkstyle is disabled in some modules. it would be good to enable checkstyle on all modules, to enforce code styles.

Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

nice-to-have

Provide any additional detail on your proposed use case for this feature.

we can follow apache/bookkeeper#230 to divide this into multiple small tasks

checkstyle has been applied to several modules, including distributedlog-proxy-server,distributedlog-proxy-client, distributedlog-protocol,distributedlog-core-twitter,distributedlog-common and distributedlog-benchmark.
So add checkstyle to below modules:

[ ] distributedlog-core

[ ] distributedlog-proxy-protocol

[ ] distributedlog-tutorials

[ ] tests


Update README with OSSF best practices badge

Update README with ossf badge
Checklist

[v ] I have reviewed the contribution guidelines
[ v] I have signed the CLA
[ ] My code includes unit tests
[ ] All unit tests and lint checks pass locally
[ v] My PR contains documentation updates / additions if required

/azp run


Bug: settings panel is horizontally compressed

Bug Description
Updated today and the Obsidian Settings screen became super narrow. I see there was a new change to the Settings stylings but my window is very wide and the Settings are still much too narrow, disrupting the contents. See screenshot.
To Reproduce
Install newest Sanctum in unmodified Obsidian.
Expected behavior
Settings screen should be readable.
Relevant Screenshot(s)

Obsidian Version
0.15.9
Installer Version
0.15.9
Font Size
10
Which editor are you using?

[ ] New Editor
[ ] Legacy Editor

In which mode(s) does the problem occur? (if applicable)

[ ] Reading View (Preview)
[ ] Editing View - Source Mode
[ ] Editing View - Live Preview

Which operating system?

[ ] Windows
[X] macOS
[ ] Linux
[ ] Android
[ ] iOS

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Themes - Manage → Update).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] If the bug occured after updating the theme, I read the last couple Releases to make sure the bug is not an intentional change.

Additional Context
No response

Hi! There should be a style settings option to adjust the settings menu width to your preference. :)


Fixed AAC encoding for microphone

Fixed b-frame interval for FFMPEG
Fixed sample size for FAAC

Hi @akallabeth, as you know, I'm always interested in sound subsystem fixes, optimizations and improvements, as I use lots of video/sound/mic over FreeRDP. Can you confirm that you tested this fixes with Windows? I'm asking because I've done several tests with this and AAC and the mic sound is still garbled. PCM works perfect, but AAC has lots of distortion. The first few tries it seemed a little better than before this fix, but to be sincere, I reverted the fixes and it sounds the same.

@vscfreire yes, tested against windows 8 to 10 (and server 2016 and 2019)
no distortions (and especially no increasing delay) with these patches.
tested with integrated sound recorder app.

Which kind of distortions do you have? (maybe attach some sample record)?
Which backend do you use (ffmpeg or faac)
Which os do you use on the client side?

AACRecordingTest.zip
ffmpeg - tried the latest minors of 4.2.4, 4.3.2 and 4.4.0, all had the same kind of distortions
Windows 10 19043.1110 on the client, Windows Server 2016 on the server

Used Audacity to record the sample, if I pressed a second time on the Record, the session would also disconnect. With PCM, not only the recorded sound is perfect, but the session doesn't disconnect if I record again.

@vscfreire ok, weired. did you try with faac instead of ffmpeg too? (different encoder, so you can rule out issues there)
will do a recheck of the windows client, mac and linux do work fine with faac and ffmpeg (but there is some format conversion issue with some ffmpeg builds)


Should we use any formalized formatting system for comments like Doxygen?

@DangerousFreedom1984 wrote in issue #23:

4) I really want to keep Koe's high standards in writing c++ files and avoid code and design smell. So should we also use Doxygen or something like that to better document the files?

For reference: https://doxygen.nl/

@UkoeHB answered:

It might be worth a try, but maintaining that would become an ongoing task. I also don't know if the cleaned-up header comment style I'm using will work with Doxygen (iirc they use @param and so on, which is ugly):
/**
* brief: func_name - comment
* type: type - comment   (for templates)
* param: param - comment
* inoutparam: param_inout - comment
* outparam: param_out - comment
* return: comment
*/
template <typename type>
return_type func_name(param_type param, inoutparam_type &param_inout, outparam &param_out);

@DangerousFreedom1984 's answer to that:

Yeah, on top of the name conventions/organization that you are using, I will try to at least write a few words for each function. It looks better than nothing to me.

In my experience this "commenting every parameter" style soon degenerates into trivial comments that are pretty much worthless to everybody with even a little understanding of the codebase. Plus, the better the names of the parameters, the less need there is for additional comments, and those names better be good.
There is more: Those comments tend to rot, like koe also hinted at, and may become a net negative if you can't rely on them. Finally they make the header and code files longer and thus less readable.

I recently had the task to give some advice at the company I work and came up with the following general approach:
When you write comments try to put yourself into the shoes of the reader of your code, using as much "empathy" as you can muster, and ask yourself: Which important facts about the code in question would be the hardest to understand for that reader from looking at the code? What would took them the longest time to understand from merely looking at the code without any support from additional info in the form of comments?
Then comment at least those facts.
There are some candidates for such things that I encounted repeatedly in my own programming:

Sometimes, despite my best intentions to come up with a good structure for my program, and apply good layering and good modularization, several parts of the code have to work together in non-obvious ways. The parts that "belong together" in this way are hard to find without some pointers in the form of comments, and there is the danger that people unintentionally break things by uncoordinated changes.

Sometimes a piece of code looks wrong at first sight, but is correct nevertheless, and it might be hard to understand why. I take great care to comment each code piece that "surprises" readers in this way, to make sure nobody "corrects" it later out of limited understanding.

Sometimes I don't implement some feature, to keep things simple, and because I am sure that the feature won't be needed right away, and maybe later will be needed in a different form that I am not yet able to correctly predict. (I call this the Nothing in advance principle). If I do that, I carefully document what I did not implement, and why not, so nobody later implements what I so carefully and thoughtfully left out, just because it looks missing or in need of improvement.

Sometimes my code looks sub-optimal, as if I did not choose the best way to implement a piece, but in fact I did think through alternatives and saw non-trivial disadvantages in those ways that may look more attractive at first glance. Sometimes I try to comment those discarded alternatives and their non-obvious problems, again to avoid that somebody falls into the trap to rework my code and ends up with something worse.

One thing I'd really appreciate when everyone reviews the seraphis code is to point out confusing points that could benefit from code comments (and also existing code comments that are confusing).


make chacha20Key.Open append plaintext to dst

Open currently returns the plaintext slice and does not touch the dst slice. According to the docs of cipher.AEAD:

"[I]f successful, appends the resulting plaintext to dst, returning the updated slice."

This PR adds the append call to Open and nothing else.

Good catch — thanks!


Fix parsing of grades

When bb grades retrieves grades, there is HTML output in the text stream. Fix the regexes in bb_grades to make it output a nicely formatted list of grades.

My output looks good! Plus, now both the manually entered and calculated grades are displayed.

My output looks good! Plus, now both the manually entered and calculated grades are displayed.

:v:

:v:


Added writer setting to include the encoding in the declaration

For silly enterprise-y reasons, some other software I use breaks if the encoding field is missing. This adds support on the Writer to include it in output.

Added bool field on the Writer
Added a set_write_encoding method on Writer
Broke the declaration writing out into a format_declaration method
Added code to write the encoding (currently guaranteed to be UTF-8)
Added tests

I called it write_encoding rather than just encoding to leave that name available for a future setting to actually choose the encoding itself, rather than just whether or not to write the encoding field.

Released as 0.3.2


Zero out garbage space of vertices buffer of BitmapText

Fix #6900
https://jsfiddle.net/18dkq4t3/

Codecov Report

Merging #6902 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #6902   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          671       671
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff49a2...0bcdcff. Read the comment docs.

Thanks @SukantPal :tada:


Update SwiftPM library version to 5.7

This allows building packages requiring tool version 5.7.

@yonihemi Oh, I didn't remember that PR (even though it's just 2 months ago :joy: ) So we can just pick your commits, right?


At General Availability, will az aks get-credentials enforce kubectl to connect with credentials unique to each AAD user logged in via az login instead of returning shared credentials that are the same for all users?

At General Availability, will az aks get-credentials enforce kubectl to connect with credentials unique to each AAD user logged in via az login instead of returning shared credentials that are the same for all users?  I'm concerned that production clusters need to be secure at General Availability such that kubectl credentials to access the cluster can't walk out of the organisation.  If an AAD account is disabled, the key in the .kube\config file should no longer allow cluster access.  This might be RBAC-AAD integration, or it might be something simpler for GA.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d501ff67-9208-8bcb-e8df-f09e9b16a802
Version Independent ID: e3fc3851-ddc4-d26c-251d-6ae53d714081
Content: Frequently asked questions for Azure Kubernetes Service
Content Source: articles/aks/faq.md
Service: container-service
Product: unspecified
GitHub Login: @neilpeterson
Microsoft Alias: nepeters

@DaveAurionix - this is a good question. I hate to punt you to a different issues tracker, but would you mind raising this as an issue at this repo (AKS service issues tracker).
https://github.com/Azure/AKS
If you ping me on the issue, i will help track.

@neilpeterson no problem, done, and thanks.  #397

@DaveAurionix - thanks. I am going to close this one in favor of #397
#please-close

@DaveAurionix  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Restart and Synchronize Issue

Hi, we have been using this library for a consensus scenario. But there seems to be some issues about restarting a node.
In our scenario, we run 4 nodes for consensus.
Then we stop one of them for approximately 0.5~1 hours.
Then we restart the node.
Afterwards, the node runs for a lot of synchronization blocks and gets stuck. Moreover, it finally drags down all other three nodes, and the whole system hangs.
What could be the problem and do u have a solution for this case?
Thanks~

Btw, in addition, the database written out by hotstuff keeps growing, and there is no mechanism to remove old data. Is this expected?

Sadly this codebase doesn't not implement crash-recovery (so there is no safe way to securely restart a node). To do so, we would need to persist a number of information to storage (eg. preferred round and last voted round).

Regarding the database size, it is unclear how to solve it by only looking the validator's codebase. A typical solution is to clearly define the "active state" of the validator and cleanup everything else at epoch change (which is not currently implemented); then rely on some sort of "archival" nodes to persist the entire history of the blockchain. This however implies a blockchain ecosystem (which is beyond the scope of the consensus core).

@asonnino Thanks. I have been using this library for a scenario that requires recovery, even after a long period shut down. I  have already implemented something that should work. Perhaps I will post a PR after testing. :)


changing the event icon

is it possible to change the circle to a rectangular or a line?
and if this is possible, is it possible to change the rectangular's size when zooming?

Hope it is somehow clear what I mean...

See the new demo / GIF in the project homepage : the shape of individual events is no longer an issue, since we're metaballing te events to show uneven distributions.

The incoming demo link is: http://marmelab.github.io/EventDrops
It is not yet finalized, some style adjustments are still required. But metaballs are now visible.