i18n: decimal comma separator

Unless there is other repo/mechanism to handle with internationalization, i would suggest to include dot in babel, with a parameter to allow translators to select the decimal separator, and make proper replacement in Utils.toFixed().
As always..., thanks for this great simulations!!

@ariel-phet, have we looked into using built-in browser support for number i18n? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat now looks like it meets our minimum browser requirements, and would handle some cases where we would want to change how numbers are displayed:
var number = 123456.789;

// German uses comma as decimal separator and period for thousands
console.log(new Intl.NumberFormat('de-DE').format(number));
// → 123.456,789

Doesn't look like a catch-all, as I believe its behavior for Arabic may not be what we've been told is the best:
new Intl.NumberFormat( 'ar' ).format( 123456.789 ) // "١٢٣٬٤٥٦٫٧٨٩"

@jonathanolson I don't believe we have looked into built in browser support. I believe we usually have the option to set the separator on a sim by sim basis but perhaps I am mistaken.
Marking for dev-meeting

+1 for investigating built-in (browser) support for numbers.

+1 for investigating built-in (browser) support for numbers.

agreed

Perhaps we should ask the translator in Rosetta to enter:
decimalSeparator (default to '.')
thousandsSeparator (default to none)

Would these strings be in Joist?

@oliver-phet will poll some of our translators about this issue

@oliver-phet Any reply from translators?

The general consensus from trusted translators is that this is not a priority. A couple said it would help to have the control, others didn't mind.

We will plan to make this automatic for each locale with established conventions, work to be done with Rosetta etc work

@kathy-phet said:

[I'm] wondering about the challenges around displaying numbers more in the locale of the countries. Has the development team considered this (new?) function https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat. I know its complicated to figure out how to support different number formats - especially with the precision with which we tend to do alignments or other display characteristics. I am just wondering if this function is new and if it is at all helpful for PhET. e.g. if we wanted to display 50.5 as 50,5 when using the German translation.

It appears Intl.NumberFormat was introduced around 2013.  We discussed it in this issue https://github.com/phetsims/dot/issues/68 in 2017 and there is a related issue for i18n of the keypad in https://github.com/phetsims/scenery-phet/issues/333.  I’ll post your comment in dot#68 and check the status.
@jbphet or @ariel-phet can you please comment on the status?

This is just one of those features that has never bubbled to the top of the priority list.  @oliver-phet said above:

The general consensus from trusted translators is that this is not a priority.

We can reconsider and make it a priority if needed.

I will try to bring this question up at status meeting this week.

new Intl.NumberFormat relies on BCP 47 language tag, so we would likely want to build and maintain a mapping from our codes to the BCP47.

https://tools.ietf.org/html/bcp47#section-2

Marking again for dev meeting for two reasons:

This is never getting any time spent on it because it's marked as medium priority, and there are always higher priority things happening.  Should we schedule it to become high priority at some point?
We got a request for this feature from a translator, see https://github.com/phetsims/rosetta/issues/252
Should this issue be moved?  The dot repo doesn't seem like the most obvious place for it.

Marking again for dev meeting for two reasons:

This is never getting any time spent on it because it's marked as medium priority, and there are always higher priority things happening.  Should we schedule it to become high priority at some point?
We got a request for this feature from a translator, see https://github.com/phetsims/rosetta/issues/252
Should this issue be moved?  The dot repo doesn't seem like the most obvious place for it.

The dev team discussed this in the 1/25/2021 supplemental developer meeting, and I will follow up by first having @oliver-phet survey the translators in an effort to gauge how important and valuable this feature would be to them, and then to work with @kathy-phet to decide whether to allocate time to this now or defer.

The dev team discussed this in the 1/25/2021 supplemental developer meeting, and I will follow up by first having @oliver-phet survey the translators in an effort to gauge how important and valuable this feature would be to them, and then to work with @kathy-phet to decide whether to allocate time to this now or defer.

My note from https://github.com/phetsims/rosetta/issues/252#issuecomment-766972319

In my opinion, PhET should look "at home" in other languages, and the only reason to delay or forego this issue is if it is prohibitively expensive.

My note from https://github.com/phetsims/rosetta/issues/252#issuecomment-766972319

In my opinion, PhET should look "at home" in other languages, and the only reason to delay or forego this issue is if it is prohibitively expensive.

Elaborating on the survery idea...  The questions that I would ask are something like, for your locale:

What decimal separator is used?
Are students used to seeing the English separator (dot) and does it confuse them?
Is using the correct separator essential, nice to have, or not really necessary?
Is usabity or learning compromised if we do nothing, and continue to use the English separator?

Elaborating on the survery idea...  The questions that I would ask are something like, for your locale:

What decimal separator is used?
Are students used to seeing the English separator (dot) and does it confuse them?
Is using the correct separator essential, nice to have, or not really necessary?
Is usabity or learning compromised if we do nothing, and continue to use the English separator?

Thanks for the ideas @pixelzoom

Thanks for the ideas @pixelzoom

We've received 32 responses to the survey I sent to our full list of trusted translators (150 translators).
It seems this is a priority feature to translators:

~90% view using the correct separator as Essential / Nice to have
50% feel usability or learning would be compromised without the feature

Also, it seems that the most used separator isn't a comma or decimal, but a space.

~43% of translators use Comma for decimal and space for thousands in their locale.

Full list of separators used:
16 responses: Comma for decimal and space for thousands: 123 456,789
8 responses: Comma for decimal and period for thousands: 123.456,789
6 responses: Period for decimal and comma for thousands: 123,456.789
1 response: Comma for decimal and no separator for thousands: 123456,789
1 response: Forward slash for decimal and comma for thousands; 123,456/789

We've received 32 responses to the survey I sent to our full list of trusted translators (150 translators).
It seems this is a priority feature to translators:

~90% view using the correct separator as Essential / Nice to have
50% feel usability or learning would be compromised without the feature

Also, it seems that the most used separator isn't a comma or decimal, but a space.

~43% of translators use Comma for decimal and space for thousands in their locale.

Full list of separators used:
16 responses: Comma for decimal and space for thousands: 123 456,789
8 responses: Comma for decimal and period for thousands: 123.456,789
6 responses: Period for decimal and comma for thousands: 123,456.789
1 response: Comma for decimal and no separator for thousands: 123456,789
1 response: Forward slash for decimal and comma for thousands; 123,456/789

I'm going to move this issue to the rosetta repo.  There really isn't a perfect place for this to go, since localization of the decimal separator is a very cross-cutting feature, and we're not sure at this point if we would do it automatically or based on translation, but having this issue in dot is clearly sub-optimal.


render-readme doesn't work if readme fails on CRAN version of the package

See example: https://github.com/easystats/effectsize/actions/runs/3159789035

Thanks, should be fixed now.


Elevation for Material Components not visible in android.

Cards, Switch, Paper etc have no elevation visible in Android but works fine in iOS. Elevation has to be defined in order for visibility. None shown by default. Shadow property doesn't work in Android.

@thyagarajarahul

According to the Material Doc, Switches don't have elevations, though it could be added if we need it.

As far as I can tell Paper's shadow property works on Android

Cards do appear to have an issue with rendering shadows

This has been patched by this https://github.com/codypearce/material-bread/commit/eb810464754fcf5ee3785043f74c2cba2316c0b9
This will be included in the next version, however you can test it now by pointing your the npm package to the repo.


use tag as application version

I noticed you tagged 0.2.2 but the version in .app.src is 0.1.0. This PR replaces the static version with git which tells rebar3 to replace it with the latest tag, if it isn't on an exact tag it'll use a version of the latest tag +build.#.ref<git hash>.

My bad. I've pulled the tag. I'll merge and retag 0.2.2


WVV title not persisted no reload

Testing #105764
Not sure if this is actually better behavior, but if I set a webview view title and then reload, the view title is not preserved.

To verify:

Create webview view with a custom title
Reload.
Make sure the title is displayed correctly.
Also make sure the .title property on the WebviewView is correct
Try this again but with the webview collapsed when you do the reload

Actually, after discussing this at the extension authors call, I am reverting this change.
Say you have a webview view that shows the current editor's name in its title. You then collapse that view and reload VS Code. That title will now not be updated until the webview becomes visible again. It makes more sense to show the generic webview title in this case


CNN Policy

Can you please add an example of a CNN policy? All the code is oriented towards MLP policies.

I found that the observation dimension of Hopper-v1/v2 is 11, so it's not an image as a input for network. I think the MLP policy is the suitable method in fixing such gym game. Surely, if you work on another different domain, you can have a try for CNN policy.


Unale to build from Dockerfile

Hi,
I am trying to build this from Dockerfile as my docker ARCH="x86_64"  and  I want to change the EXPOSE port. However it is always complaining while copying file path. COPY failed: stat /var/lib/docker/tmp/docker-builder688375406/.build/linux-x86_64/json_exporter: no such file or directory

Hi, have you found a solution to this?

Path issue has been fixed, and using the customized port.


make cogwheels a proper device

 autistic.sack.of.friends on Discord says

this will let them function in combination with auto-assemble and bulk recycle, streamlining the process considerably. maybe then we could even add some parts that feel way too expensive (e.g. encased chain drives) to a "cog device"

 yarden.zamir on Discord says

The auto assembler works witjh all stonecutter recipes so it should already works but yea I agree. No reason for them to not be a mini device like the network devices and such

 yarden.zamir on Discord says

Encased chaindrive makes sense gameplay wise but a bit off thematically

 yarden.zamir on Discord says

Are they too expansive thoguh

 autistic.sack.of.friends on Discord says

maybe...

 autistic.sack.of.friends on Discord says

you need more of them to be useful than something like a gearbox

 autistic.sack.of.friends on Discord says

at least 2

 autistic.sack.of.friends on Discord says

is there any fitting re-theme we could do to cogs

 yarden.zamir on Discord says

I've ran a small playtest in the weekend with gemperc and I used them extensivly as I love them and didn't feel a lack becuase the early game sprays you with mechanical devices now

 autistic.sack.of.friends on Discord says

oh yeah

 yarden.zamir on Discord says

That is true, but I don't know if that's enough to split them to a seperate device

 yarden.zamir on Discord says

I would prefer to give the player even more devices in that case if it is still expansive, but am not sure thats needed

 autistic.sack.of.friends on Discord says

i guess

 autistic.sack.of.friends on Discord says

i feel like cogs should be more versatile conceptually

 autistic.sack.of.friends on Discord says

oh yeah ,can't find where you mentioned it but steam engines are easily configurable


Parallelized edge contraction

This might be related to the ContractionNetwork issues: It would be good to have a method that allows to contract edges in parallel.
For example, assume we want to multiply pairs of matrices in a chain:
mat = np.random.random([1000, 20, 20])
result = tf.stack([tf.matmul(mat[i], mat[i + 1]) for i in range(0, 1000, 2)])

to get a (500, 20, 20) tensor. Doing result = tf.matmul(mat[::2], mat[1::2]) is ~x10 faster. The API would be something like net.parallelized_contract([list of edges]) .

So your case of 10x speedup is very specific to this setup (most parallel edge contractions can't be easily reduced to a simple matmul). I'm pretty sure JAX and TF both parallelize as much as possible in @tf.function and @jax.jit modes, so I'm not sure what else we could do on our side.
Beyond that, doing parallel contraction of arbitrary edges will require knowing the optimal contraction order, which requires a smart contraction algorithm. All of which will be handled with ContractionNetwork and net.async_contraction
I think most of your wants are going to be fulfilled with the ContractioNetwork. If you have a specific design in mind that I'm not seeing, feel free to reopen this issue.


STORM-2388 JoinBolt breaks compilation against JDK 7

replace String.join with Guava Joiner to keep compatible against JDK 7

I'm just fixing it from 1.x branch since storm-core on master branch and 1.x branch are already diverged.

+1

+1

+1

+1

+1


400 Bad Request when download

Both with/without input returns this.
IDC: Oracle Integration Cloud (OIC)
IPDR: <IP_ADDRESS>/19

Both with/without license input returns this.
IDC: Oracle Integration Cloud (OIC)
CIDR: <IP_ADDRESS>/16
NetRange: <IP_ADDRESS> - <IP_ADDRESS>

When accessing to the API download and not providing the key, the system redirects (http redirect) to GitHub download link.
HTTP 4XX namespace is for client error, you should check how your machine is connecting to internet.


Audio

Add OGG Vorbis music and sound effect support to Driftwood using SDL_Mixer.

Added in ae62b653a210907b3dd42e55f66ee12a06623c6d and b76be469cc86fa46467104d9d9eb37edd3f511b7


[SymbolGraph] Use isImplicitlyPrivate for extended types

This was just using hasUnderscoredNaming before but this only checks the
leafmost type. When filtering extended types, it should continue to look up
through nesting types to see if they are also implicitly private.
rdar://61843516

@swift-ci Please smoke test


Inconsistent requirements.txt comments

Package manager/ecosystem
python, pip-tools
What you expected to see, versus what you actually saw
Our org has a monorepo with multiple requirements.txt and requirements.in files. When there is a dependency that needs to be upgraded across multiple requirements files, Dependabot usually opens a single PR that contains all of the changes but sometimes opens multiple PRs, one for each subproject. This is a little annoying but we can deal with it; although if there is a way to consistently split up the PRs I'd love to know about it!
Our main issue is that this big single PR updates every single comment in the requirements.txt files it touches with relative pathnames from the repo root, so # via -r requirements.in becomes # via -r ussd/requirements.in. Any subsequent PR that touches only a single subproject reverts these comments (# via -r ussd/requirements,in -> # via -r requirements.in). This switching back-and-forth is fairly annoying and can cause octopus merges to fail in fun and interesting ways.

Possibly related? https://github.com/dependabot/dependabot-core/issues/3636


Update config.fnl

Hello! I arrived here from GitHub search 🤓. This link was recently changed, so I figured I'd update as many inbound links as possible

That is very nice of you, appreciate it very much!
Have a great day!


DataFrame.Agg() supports multiple expressions

Could you please add a second parameter to DataFrame.Agg() that accepts params Column[] expressions so that the overall method signature becomes DataFrame.Agg(Column, params Column[] )? This would be compatible with Microsoft's Spark DotNet solution.

Fixed and on nuget.org as 3.5.1-build.17


Support for using Key Vault references for secret values?

I'd be curious to know how secret values are secured in the current form of Container Apps and if there are plans to enable Key Vault references similarly to how you can in App Services. This is probably the main blocker for me in moving a production app to Container Apps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 735a0e03-0632-feb7-8787-e62118809072
Version Independent ID: 938a7233-56e5-dd1b-05c0-2a15b8920f12
Content: Manage secrets in Azure Container Apps
Content Source: articles/container-apps/manage-secrets.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@ctvanzandt42
Thanks for your Question! We are currently investigating and will get back on this.

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


Allow users to manually abort

Potentially:

When reaching 80% of the remaining Rate Limited calls
Turn the "loading" button red and if clicked: abort

A proposed implementation was made there: https://github.com/useful-forks/useful-forks.github.io/issues/7#issuecomment-787044619

Aborting all ongoing Promises isn't as trivial as I thought. There is a partial solution, but I'm still waiting on something that fulfills the 3 constraints listed there: https://stackoverflow.com/q/67086017/9768291

what about using AbortController? See https://github.com/octokit/rest.js/blob/2c7bf0c4c1121e03dae135768f20b983f1015b78/docs/src/pages/api/03_request_formats.md

@micalevisk
Say I have 100 calls to make, and that after 70 I realize I need to stop. From what I understand, the AbortController indeed helps with avoiding the necessity to await the 70 calls to receive a response. But would it help with making sure that the following 30 requests that were supposed to be issued would get cancelled before being executed?

I didn't used AbortController API yet. But I guess each call could have its own abort signal, so you can invoke those controllers as you wish as long you track them properly

30 requests that were supposed to be issued would get cancelled before being executed?

Yes. You just pass the signal to fetch and when the call is made, it be immediately fail because the signal was already given.


Terminal in editor area not restored after vs code restart.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2
OS Version: Windows 11

Steps to Reproduce:

Start VS code without extensions :
code-insiders --disable-extensions
Create new terminal in editor :
CTRL+SHIFT+P -> Terminal:Create New Terminal in Editor area to the side.
Close vs code by clicking on 'x' button on app top right of the WIndow.
Re-open vs code, see that the terminal in editor area is not restored.

Notes:

Persistent sessions value set
"terminal.integrated.persistentSessionReviveProcess": "onExitAndWindowClose"
No issues with the terminals in panel area. Terminal are restored correctly when vs code is restarted. Issue only with terminals opened in editor area,

I found the issue and implemented a fix in #151852.  It doesn't preserve the location of the editor, but at least restores them.


Uncaught Error: spawn /usr/share/atom/atom (deleted) ENOENT

This is happening after a fresh install:
I am running Debian 8
[Enter steps to reproduce below:]

Installed deb file atom-amd64.deb  v0.186.0
Run the Program

Atom Version: 0.184.0
System: linux 3.12-1-amd64
Thrown From: Atom Core
Stack Trace
Uncaught Error: spawn /usr/share/atom/atom (deleted) ENOENT
At events.js:94

Error: spawn /usr/share/atom/atom (deleted) ENOENT
    at exports._errnoException (util.js:753:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
    at child_process.js:1142:20
    at process._tickCallback (node.js:364:11)

Commands

Config
{
  "core": {
    "disabledPackages": [
      "autocomplete-clang",
      "web-browser",
      "deprecation-cop"
    ]
  },
  "editor": {
    "invisibles": {}
  }
}

Installed Packages
# User
html2haml, v0.6.0
language-haml, v0.15.0
linter, v0.12.0
linter-clang, v2.25.1

# Dev
No dev packages

Duplicate of #4505, please subscribe there for updates.


OOTB Granite Bee Agent

Is your feature request related to a problem? Please describe.
I want to be able to easily get started with a Bee agent that uses Granite-3.0-8B-Instruct, and be able to use most of the functionality that Bee provides OOTB.
Describe the solution you'd like
OTTB bee agent implementation and ideally a way to easily swap models for a Bee agent
Add docs as well
Describe alternatives you've considered
NA
Additional context
Related ticket: https://github.com/i-am-bee/bee-agent-framework/issues/70

Documentation update needed, then ready to ship.


[Snyk] Fix for 8 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

public/themes/custom/infofinland/package.json
public/themes/custom/infofinland/package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

619/1000  Why? Has a fix available, CVSS 8.1
Prototype Pollution SNYK-JS-AJV-584908
No
No Known Exploit

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-ANSIREGEX-1583908
Yes
Proof of Concept

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-MINIMATCH-3050818
Yes
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-PATHPARSE-1077067
No
Proof of Concept

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-POSTCSS-1255640
No
Proof of Concept

479/1000  Why? Has a fix available, CVSS 5.3
Improper Input Validation SNYK-JS-POSTCSS-5926692
No
No Known Exploit

489/1000  Why? Has a fix available, CVSS 5.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-SIDEWAYFORMULA-3317169
No
No Known Exploit

736/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 8.3
Sandbox Bypass SNYK-JS-WEBPACK-3358798
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: @sideway/formula
    The new version differs by 2 commits.

5b44c1b 3.0.1
9fbc20a chore: better number regex

See the full diff

Package name: copy-webpack-plugin
    The new version differs by 4 commits.

46af20a chore(release): 7.0.0
5d5635f refactor: code (#567)
c6f68a5 refactor: code
4cea28b refactor: next

See the full diff

Package name: eslint-config-drupal-bundle
    The new version differs by 7 commits.

970cbd8 clean up the package.json and locks
a2a4300 Update to drupal 9.5.x latest eslint/prettier configs.
4f306ab skip log files in repo
c73c0c5 1.1.0
26fb80f Merge pull request #5 from shaundrong/upgrade-d9-settings
bb921b4 Update to Drupal 9's eslint settings
3ffb1c7 Merge pull request #3 from shaundrong/doasync-merge

See the full diff

Package name: html-webpack-plugin
    The new version differs by 13 commits.

873d75b chore(release): 5.5.0
ddeb774 chore: update examples
1e42625 feat: Support type=module via scriptLoading option
7d3645b Bump pretty-error to 4.0.0 to fix transitive vuln for ansi-regex CVE-2021-3807
79be779 [chore] changes actions to run on pull_requests
b7e5859 [chore] fixes CI to avoid race conditions
48131d3 chore(release): 5.4.0
16a841a [chore] rebuild examples
3bb7c17 Update index.js
e38ac97 Update index.js
f08bd02 [chore] updates fixtures
d62a10f [chore] upgrades<EMAIL_ADDRESS>-> 6.0.2
2f5de7a Remove archived plugin

See the full diff

Package name: node-sass
    The new version differs by 17 commits.

99242d7 7.0.1
77049d1 build(deps): bump sass-graph from 2.2.5 to 4.0.0 (#3224)
c929f25 build(deps): bump node-gyp from 7.1.2 to 8.4.1 (#3209)
918dcb3 Lint fix
0a21792 Set rejectUnauthorized to true by default (#3149)
e80d4af chore: Drop EOL Node 15 (#3122)
d753397 feat: Add Node 17 support (#3195)
dcf2e75 build(deps-dev): bump eslint from 7.32.0 to 8.0.0
bfa1a3c build(deps): bump actions/setup-node from 2.4.0 to 2.4.1
80d6c00 chore: Windows x86 on GitHub Actions (#3041)
566dc27 build(deps-dev): bump fs-extra from 0.30.0 to 10.0.0 (#3102)
7bb5157 build(deps): bump npmlog from 4.1.2 to 5.0.0 (#3156)
2efb38f build(deps): bump chalk from 1.1.3 to 4.1.2 (#3161)
fca5257 build(deps): bump actions/setup-node from 2.3.0 to 2.4.0
6200b21 docs: Double word "support" (#3159)
eaf791a build(deps): bump actions/setup-node from 2.1.5 to 2.3.0
16b8d4b build(deps): bump coverallsapp/github-action from 1.1.2 to 1.1.3

See the full diff

Package name: rtlcss-webpack-plugin
    The new version differs by 4 commits.

6d73d89 nvmrc -> `16`, yoshi -> `@ 5`
0997097 upgrade to `rtlcss@3` (#16)
ab6f0c9 Update package.json
ba8ceec Update pom.xml

See the full diff

Package name: webpack
    The new version differs by 250 commits.

5d64468 Merge pull request #16792 from webpack/update-version
67af5ec chore(release): 5.76.0
97b1718 Merge pull request #16781 from askoufis/loader-context-target-type
b84efe6 Merge pull request #16759 from ryanwilsonperkin/real-content-hash-regex-perf
c98e9e0 Merge pull request #16493 from piwysocki/patch-1
5f34acf feat: Add `target` to `LoaderContext` type
b7fc4d8 Merge pull request #16703 from ryanwilsonperkin/ryanwilsonperkin/fix-16160
63ea82d Merge branch 'webpack:main' into patch-1
4ba2252 Merge pull request #16446 from akhilgkrishnan/patch-1
1acd635 Merge pull request #16613 from jakebailey/ts-logo
302eb37 Merge pull request #16614 from jakebailey/html5-logo
cfdb1df Improve performance of hashRegExp lookup
4d561a6 Add test for behaviour of filesystem-cached assets with loaders
dfaa3b4 lint: remove trailing comma
dcc3e71 Serialize code generator data to support generated assets
b67626c Merge pull request #16491 from lvivski/main
d957cdf Fix formatting
6011163 Fix formatting
ea5e864 Fix HTML5 logo in README
2112f9b Replace TypeScript logo in README
5513dd6 Merge branch 'webpack:main' into patch-1
4b4ca3b Merge pull request #16500 from Jack-Works/avoid-cross-realm-object
4f39c9f fix: type error
c922ee1 chore: revert breaking change

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Improper Input Validation

Decided to close obsolete Snyk PRs and run again


Data mining to fetch latest pal + trait stats

Pal Calc depends on a list of pal data from the game in order to do its breeding calculations. It also uses some trait data for displaying traits in its UI.
Pal Calc currently uses data mined by others and shared publicly. Unfortunately there isn't a consistent source of information which has all of the data needed for its calculations.
How is this data mining performed, and can it be done as part of Pal Calc?
Alternatively, is there another frequently-updated source that could be referenced? We will need to collect, at least, the data mentioned in PalCal.GenDB.
https://paldb.cc was suggested and is frequently updated with the list of pals, but it seems to be missing InternalIndex which is required as a "tie-breaker" for breeding calculations.

Hi,
under https://paldb.cc/en/Breeding_Farm the InternalIndex for Pals is shown as IndexOrder.

Thanks for the reference @RudelNudel ! I didn't see this before
paldb.cc tends to be updated regularly so I'm ok with relying on that as a source. The only remaining question is a DB for traits/passives. paldb.cc includes a list of traits and their ranks, but we'll also need the internal "code-name" for each trait in order to recognize them in save files

This was mentioned as a possible source for palworld data: https://github.com/KrisCris/Palworld-Pal-Editor/blob/develop/src/palworld_pal_editor/assets/data/
It just seems to be missing the InternalIndex.
I also took another stab at data-mining using FModel based on the instructions here: https://pwmodding.wiki/docs/intro
I was able to extract the latest set of pal icons and the mapping of internal->display names for skills, but I wasn't able to properly extract the list of skills or the list of pals. I exported the .uasset files and could see the info I wanted in a text editor, but it seems to be a UE-specific table format.

In the meantime, paldb.cc for full pal info and Palworld-Pal-Editor for trait IDs seems to be a sufficient combo for now. I'm manually updating with new pals + traits and will write an exporter to scrape these later.

I was able to find the internal trait names using paldb.cc, and with v1.4.4 I've add a data scraper which fetches all required info from paldb.cc. This new data is used in v1.4.4 and will be updated with this method in the future.


Feature Implementation: Blog/News Section

Keep the community updated with development progress, upcoming features, and community highlights.
@YadavAkhileshh I would love to work on it, could you please assign this task to me?

@YadavAkhileshh hello!?


Add folder for types Interfaces, Models, Router, Helps from Typecsript

@miguelsolorio
https://www.figma.com/file/UQQzTjcRvWsZW9udePXOSr/Symbols---File-Icons-(Copy)?type=design&mode=design&t=zIiTKZHz8wKOQz7H-0

Can you please share what folder names these will map to?

@miguelsolorio  I have named each frame with its proper name

Thanks, are you able to create a PR?

@miguelsolorio  can you guide me on how to do this?

Thanks for the suggestions, I omitted utils since we already had that one.

@miguelsolorio the interfaces folder is named wrong you wrote interface without the "r"

@keidsondesigner thanks for that catch, fixed the typo.

In the meantime you can use the following configuration until the new version is released:
  "symbols.folders.associations": {
    "interfaces": "folder-intefaces",
  }


'React/UIView+React.h' file not found after upgrade to RN 0.60.5

I upgraded my project from RN  0.59.10 to 0.60.5 but when I run the project I receive this error.
I followed the change steps from https://react-native-community.github.io/upgrade-helper/?from=0.59.10&to=0.60.5
and of course, I installed the new pods
React Native version: 0.60.5
System:
OS: macOS 10.14.6
CPU: (4) x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
Memory: 357.99 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 12.9.1 - /usr/local/bin/node
Yarn: 1.17.3 - /usr/local/bin/yarn
npm: 6.10.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 26.0.2, 27.0.3, 28.0.2, 28.0.3
System Images: android-28 | Android TV Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
IDEs:
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.5 => 0.60.5
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Did you convert your code to cocoapods? If so, did you do a pod install in the iOS directory?

@RichardLindhout
yes I updated my project to cocoapods and I installed the pod dependency with pod install

@YahiaYasLife How you solved this issue ?

@RichardLindhout @kumbhar-ketan
I resolved the issue by removing all libraries from Libraries folder.
And installing the dependency @react-native-community/art
yarn add @react-native-community/art
cd ios && pod install

It didn't worked for me :/ I tried both like you said, or by adding directly   pod 'React-ART', :path => '../node_modules/react-native/Libraries/ART' inside my podfile, but none of them worked, and still getting this error.

any ideas why ?

@MayoudP
Did you remove all libraries from ios Libraries folder?
Did you unlink all dependencies?
when you install yarn add @react-native-community/art you don't need to link it manually.

I basically deleted the folder LIbrairies, concerning the unlink, should I remove all the item in Link Binary with Libraries and keep none ? cc @YahiaJabeur

@MayoudP
As far as I remember, I unlinked all libraries with the command react-native unlink if it's not working try to unlink manually.
Then I removed all libraries but I kept the folder Libraries exist in the ios project

@YahiaJabeur Thanks it indeed worked, stuck now with another error which I already got in react-native 0.59.X and again in 0.60 (but the fixe I had before is not working anymore). The error is about this :
Unable to resolve module ./DeprecatedColorPropType from .../react-native/Libraries/Components/View/ViewStylePropTypes.js
Since it's not concering this issue, I'm gonna investigate on it somewhere else (but if you know an existing issue which fixing it in 0.60, I'd be glad to have the redirection #) !


Screenshot support

Is there support for sending a screenshot of the current screen that you are one while you are shaking to submit a bug report?

That feature should already be supported! I have occasionally seen screenshots not successfully attaching to emails on older versions of Android - what are the device specs you're testing with? Thanks!

Closing, no follow-up info provided.


A query about HikarCP regarding hikari.connection-test-query

Environment
HikariCP version: 3.2.0
JDK version     : 11
Database        : Oracle 12c
Driver version  : ojdbc7

Hi,
This is not an issue, but a question that I wanted to ask about a functionality. I have asked the question in stackoverflow @https://stackoverflow.com/questions/55258128/connection-checker-java-class-in-spring-boot-using-hikaricp
Could you please suggest a way of achieving what I have asked in the question ?
Thanks

import com.zaxxer.hikari.HikariConfig;
import com.zaxxer.hikari.HikariDataSource;
import org.springframework.stereotype.Component;

import javax.sql.DataSource;
import java.sql.Connection;
import java.sql.SQLException;

@Component
public class ConnectionChecker {

    public boolean isConnectionValid(DataSource dataSource) {
        try (Connection connection = dataSource.getConnection()) {
            return connection.isValid(3); // Adjust timeout as needed
        } catch (SQLException e) {
            return false;
        }
    }

    public static void main(String[] args) {
        // Example usage
        HikariConfig config = new HikariConfig();
        config.setJdbcUrl("jdbc:mysql://localhost:3306/mydatabase");
        config.setUsername("username");
        config.setPassword("password");

        DataSource dataSource = new HikariDataSource(config);
        ConnectionChecker checker = new ConnectionChecker();
        System.out.println("Is connection valid? " + checker.isConnectionValid(dataSource));
    }
}


Any chance of using Knex on the browser/client side? (feature question)

We're currently using Knex & Objection to load data from a MSSQL server in an Angular 2 application using GraphQL and Apollo as our transfer libraries (essentially everything is transferred as JSON).
Everything on the Node.js side works fine, however, as GraphQL transfers everything over the wire as JSON the object itself is of course lost, and to deserialize it back on the client we would be calling the constructor of the object and then call $parseJson(...) to get it back to what it was.
The "problem" is that Knex is built for running on the client side of things, and thus when it tries to import the necessary references;
export class OurClass extends Model {
with the import:
import {Model} from 'objection';
The whole thing fails with a stack trace to ansi-styles and console coloring (hence why I ask in the Knex repo rather than Objection as the 3 steps after Objection are Knex related);
zone.js:392 Error: module is not defined
  Evaluating http://localhost:3000/node_modules/ansi-styles/index.js
  Evaluating http://localhost:3000/node_modules/chalk/index.js
  Evaluating http://localhost:3000/node_modules/knex/lib/helpers.js
  Evaluating http://localhost:3000/node_modules/knex/lib/raw.js
  Evaluating http://localhost:3000/node_modules/knex/lib/query/builder.js
  Evaluating http://localhost:3000/node_modules/objection/lib/utils/knexUtils.js
  Evaluating http://localhost:3000/node_modules/objection/lib/queryBuilder/QueryBuilderBase.js
  Evaluating http://localhost:3000/node_modules/objection/lib/queryBuilder/QueryBuilder.js
  Evaluating http://localhost:3000/node_modules/objection/lib/model/Model.js
  Evaluating http://localhost:3000/node_modules/objection/lib/objection.js
  Evaluating http://localhost:3000/app/app/model/entities/LegalEntity.js
  Evaluating http://localhost:3000/app/app/app.component.js
  Evaluating http://localhost:3000/app/app/app.module.js
  Evaluating http://localhost:3000/app/main.js

The thing I'm trying to accomplish by re-using knex/objection on the client it to avoid having to generate a whole set of database model objects that don't contain the imports to Knex/Objection (so the client & server share the same data model objects), and then having to implement our own deserializer to get it back into a Javascript class Object on the client.
Hope that wasn't too confusing a question.
Thanks in advance!

This is not supported and as usual if you try to run node code in browser, you need to pack all the dependencies with the compiled lib and face those libs, which are not supported by browser (e.g. ones that tries to make tcp connection to database etc.).
Afaik no-one has ever tried to pack objection to be able to be used from browser. This is not really related to knex. Maybe in stackoverflow someone can help you to learn how to port node software so that it can be ran in browser. Also try to read knex issues which are mentioning webpack.


[Storage-Preview] az storage account migration: Add start and show commands

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Storage-Preview


TooManyMethodsFoundException for inherited protected methods

Steps to re-produce,

Create a class with a protected method and override the same in subclass.
Create a test for the subclass and try to suppress the method call throws TooManyMethodsFoundException.

TestInterface.java
package com.test.powermock;

/**
 * Created by dineshkumar on 06/05/16.
 */
public interface TestInterface {
    public int testMethod() throws Exception;
}

AbstractTest.java
package com.test.powermock;

/**
 * Created by dineshkumar on 06/05/16.
 */
public abstract class AbstractTest implements TestInterface {

public int testMethod() throws Exception {
        return 0;
    }

    protected void voidMethodWithParams(String a) throws Exception{

    }
}

ImplClassTest.java
package com.test.powermock;

/**
 * Created by dineshkumar on 06/05/16.
 */
public class ImplClassTest extends AbstractTest {

    @Override
    public int testMethod() throws Exception {
        voidMethodWithParams("a");
        return 2;
    }

    @Override
    protected void voidMethodWithParams(String a) throws Exception{
        System.out.println("dd");
    }
}

ImplClassTestTest.java
package com.test.powermock;

import org.powermock.api.mockito.PowerMockito;

import static org.powermock.api.support.membermodification.MemberMatcher.method;
import static org.powermock.api.support.membermodification.MemberModifier.suppress;
import static org.testng.Assert.*;

/**
 * Created by dineshkumar on 06/05/16.
 */
public class ImplClassTestTest {

    @org.testng.annotations.Test
    public void testTestMethod() throws Exception {
        ImplClassTest implClassTestSpy = PowerMockito.spy(new ImplClassTest());
        suppress(method(ImplClassTest.class, "voidMethodWithParams", String.class));
        int res = implClassTestSpy.testMethod();
        assertEquals(res, 2);
    }
}

After google, https://groups.google.com/forum/#!topic/powermock/h1U5YyEXqfY
Also tried the following code,
package com.test.powermock;

import org.powermock.api.mockito.PowerMockito;

import static org.powermock.api.support.membermodification.MemberMatcher.method;
import static org.powermock.api.support.membermodification.MemberModifier.suppress;
import static org.testng.Assert.*;

/**
 * Created by dineshkumar on 06/05/16.
 */
public class ImplClassTestTest {

    @org.testng.annotations.Test
    public void testTestMethod() throws Exception {
        ImplClassTest implClassTestSpy = PowerMockito.spy(new ImplClassTest());
        suppress(method(AbstractTest.class, "voidMethodWithParams", String.class));
        suppress(method(ImplClassTest.class, "voidMethodWithParams", String.class));
        int res = implClassTestSpy.testMethod();
        assertEquals(res, 2);
    }
}

The problem I feel is in org.powermock.reflect.internal.WhiteboxImpl#getAllMethods get all the methods till super class but doesn't differentiate by type if the method names are same.
Maven version
<dependency>
           <groupId>org.testng</groupId>
           <artifactId>testng</artifactId>
           <version>6.8.5</version>
           <scope>test</scope>
       </dependency>
       <dependency>
           <groupId>org.powermock</groupId>
           <artifactId>powermock-core</artifactId>
           <version>1.6.5</version>
           <scope>test</scope>
       </dependency>
       <dependency>
           <groupId>org.powermock</groupId>
           <artifactId>powermock-api-mockito</artifactId>
           <version>1.6.5</version>
           <scope>test</scope>
       </dependency>
       <dependency>
           <groupId>org.mockito</groupId>
           <artifactId>mockito-all</artifactId>
           <version>1.10.19</version>
           <scope>test</scope>
       </dependency>
       <dependency>
           <groupId>org.powermock</groupId>
           <artifactId>powermock-module-testng</artifactId>
           <version>1.6.5</version>
           <scope>test</scope>
       </dependency>

is also reproducible with EasyMock ... :-(

@thekingnothing What should be the fix for this? I will try and submit a pull request. As @dinesh-kumar-11 has already investigated, getAllMethods() is iterating through the whole class hierarchy and fetching all methods. So, the fix should definitely be where getAllMethods() is being used.

@gauravsak
You may try to investigate the issue. I cannot say where it should be fixed. May it should be fixed in getAllMethods() not to return all methods. (I'm not sure that method from parent should be returned if it is overwritten in child). Or maybe in place where the best method candidate is searched.
If you want to investigate the issue I'll add it to next release backlog.

I have hit the same issue. I can't mock the overridden protected methods. PowerMock gives the following error.
org.powermock.reflect.exceptions.TooManyMethodsFoundException: Several matching methods found, please specify the argument parameter types so that PowerMock can determine which method you're referring to.

I'm also observing this error. The problem is that PowerMock searches for all methods in the class hierarchy for Child that match the name and given input argument types and store them in a set which should prevent duplicates (see WhiteboxImpl.findMethod). But the set is a set of java.lang.reflect.Methods and the equals method compares not only method name and input argument types but also return type. Thus we end up with both the child and parent method in the set. (This is the case for all 1.x version of PowerMock).
Has there been any progress on this?

I am also having this problem. Has this issue been fixed in any newer version?

is there any workaround for this issue?

Found a workaround -> Use methods instead of method - https://stackoverflow.com/questions/34779022/how-to-suppress-onsaveinstancestate-using-powermock


purge app tabs on low memory?

I wonder if this is accounting for the memory issues ?

any chance it has to do with this? https://github.com/artsy/eigen/issues/903

nope, it's a pretty standalone concept

Yeah that would definitely be worth looking into :+1:


remove unused branch retrieval

The call to git.branch wasn't being used, it seems.

:shipit: - but I think adding some basic smoke tests might be good (in light of 1.1.0)

Agreed.

rebased

:+1:


Lack of options to ignore errors

We're introducing this beautiful library on FE side and encountered unpleasant aftermath of this decision - increase in the number and severity of site errors.
The problem is that even if some, in other case not important, error is there - like some value is undefined, instead of an empty string - where we previously could have just some empty div - now the whole server response fails to be processed.
In our case we have plenty of nested .transform(), so there's just no chance to pass and process them anyhow separately - to pass them additionally to some custom wrapper or anything like that - we have to rely on zod.
Would be nice to have some option to still enforce .parse() to keep proceeding with .transform(), even without guarantee of the final validity - since we already will have what we're looking for - information, that some data is in unexpected format - instead of ruined UI, which is a very high price to pay.

I would say that the goal of Zod is the ensure that the data you get after calling parse is precisely in the format you expect based on the inferred type. So if some data can be undefined, you're going to have to be honest about that and make it .optional(). That gives you runtime guarantees about what the actual type is when you go to use it. Otherwise, if you don't actually care about the runtime type of the data you get back, I'm not sure why you'd want to use Zod (or even TypeScript 😅 ).
It's possible that you can leverage passthrough more in your usage to get the idea you want, so if you can share some valid input and output data, maybe we can suggest a strategy using Zod? Otherwise, it's pretty easy to transform data in TypeScript/JavaScript directly, no need to use Zod.

I do agree with you about "that's actually the whole idea", so probably it's just our case is quite specific.
We have some legacy blocks in responses, and one of the goals is to get rid of improper casing, namely kebab-case -> snake_case transformation.
At the moment, on FE side toSnakeCaseDeep() is widely used, which allowed us to switch to more unified types, yet introduced the problem that it's hard to align FE and BE efforts, since FE types are defined for state "after" transformation - so we can't really tell what is there before update to snake case. From BE side situation is problematic as well - for nested values it takes enormous effort to find out if something can be safely changed to snake_case format or not.
So decision was made - to introduce zod validation on FE side and share these schemas with BE to be able to completely transfer BE to snake_case - and remove .transform() from schemas. Because of this decision, we now have to move on FE side all kebab -> snake updates to these .transform() modification and of course we introduced plenty of them.
The problem is that we are quite sure that current data from responses will work fine on the site - since it just works without any issues - whatever there could be with "small" problems, like something can be null or undefined - everything is already covered.
Yet now it's very difficult for us to fix all the possible cases for those "null or undefined" or .optional() issues, and whenever something happens - some big block or the whole page just fails to load.
For now we weren't able to find out how to deal with this situation and will appreciate any advice - how to keep .transform() running even with error, since this error is most likely not a problem any more.


chore(brillig): Allow dynamic-size foreign calls

Description
Problem*
Incremental progress towards https://github.com/noir-lang/noir/issues/1556
Takes this milestone "Add support for slices such that in Brillig we can call an oracle and have it return a slice with length not known and enumerate over that slice" and does the part necessary for such oracles in brillig vm
As an intro, start with the comment in brillig_vm/src/opcodes.rs
Additional Context

PR Checklist*

[*] I have tested the changes locally.
[*] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Very weird thing - when I closed my unconventionally-titled PR (had a DONT MERGE at start), this one started to report that failure

Mostly nit comments but this looks solid

@vezenovm I merged your work into here, this could use another pass


simplify boolean logic

Replace if statements with if-not statements that continue or exit.

Sorry for this taking so long, I thought I've already merged it!

No worries.  Thanks for merging!

@zaz I'm planning to release this under Unlicense, would you have any problem with that?

@iamale: Sure.  No problem.


add support for ns records

This adds support for ns records.

@al-dexter Could you update the README again ?

Regarding the terraform011  branch, I'm not sure we want to backport new features to this branch, I'd like to have an opinion of @x4121 on this, but if we do, this would be a concern of another PR.

@al-dexter seems you missed to update the Optional Inputs section .
I came up with changing the changelog :
0.3.0 - Add support for creating NS records subdomain
How do you think?


Update instant.page script

Updates per some recent changes in the repo, including validation warnings emitted when <a> tags don't have href props.
I feel a little weird using instant.page CDN for something like this so copied it into it's own template.

Gonna merge this to get it on staging.


Suggestion/Feature request: Tree cutter

Suggestion/Feature request
Tree cutter option for admin/commander at the FOB(s)
Is your feature request related to a problem? Please describe:
no problem, just the current grass cutter in 0.963a only removes grass not trees
Describe the solution you'd like:
Possibly implement either a tree cutter object if they even do them or a script that could clear tree around X distance called in the kp_liberation_config i.e. "tree_cutter_radius = 50;"
Additional context:
for example antistasi has a similar feature and could come in handy when maybe building in a built up wooded area.

Basically done in v0.96.5 via the create clearance action for commander/admin.


bug: @stencil/no-unused-watch reporting errors after eslint v8 update

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already report this problem, without success.

Stencil ESLint Version
v0.3.1
Current Behavior
After updating eslint to v8.x I'm now getting lint errors on @stencil/no-unused-watch with message: Watch decorator @Watch("xxx") is not matching with any @Prop() or @State().
This happens with all instances of @Watch in my codebase.

Expected Behavior
There should only be a lint error when there is no matching @Prop or @State to correspond with the @Watch.
Steps to Reproduce
Update eslint to v8.x, add @stencil/eslint-plugin and create a component with a @Prop and then add a @Watch for it.
Code Reproduction URL
No response
Additional Information
No response

facing same issue related to decorators linting :(

Solved on #84.


Meteor 1.4 Viewmodel events don't work

Events don't seem to work with Meteor 1.4

Make a repro. Events work just fine.

Don't forget the change in vm where events is not a definable property anymore because it's better to use bindings (especially since there is the repeat function).
See here: https://viewmodel.org/docs/bindings#events
Something I would forget sometimes, so I hope this helps.

@fvpDev repeat is React only :)

Oh, whoops. Now I bet ur really annoyed lol sorry about that. Thanks for the clarification.

@ManuelDeLeon Sorry I just solved my issue. I was starting a new Meteor 1.4 project and doing meteor add manuel:viewmodel gave me viewmodel version 1.9.12 for some reason! I checked that the latest is 6 and tried to update but no luck. Seems to be a Meteor bug. Had to do meteor add<EMAIL_ADDRESS>and it updated and now events are working!
I will say there is still some confusion on my part. I guess the version of viewmodel I was using with Meteor 1.3 was 4.1.9. It seems as though {{b "value: message"}} syntax no longer works. I was able to get it working with b="value: message" syntax. Is there somewhere that these changes are mentioned? I still see a lot of examples on your site using the presumably old method, and also the events object on viewmodel (which seems to still work!?). Actually I have that working with Meteor 1.4 but not the event binding method.
Anyhow, thanks for all your work, viewmodel is great! I think I have it working now even though there is some guessing and confusion still on my part.

b=" is for React
{{b " is for Blaze
On Sep 27, 2016 5:38 PM, "scott-cornwell"<EMAIL_ADDRESS>wrote:

Closed #274 https://github.com/ManuelDeLeon/viewmodel/issues/274.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManuelDeLeon/viewmodel/issues/274#event-804707317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AED31vYC4ur-GbDDYYi37ce8NqTe0IFOks5quaj7gaJpZM4KINcE
.


Upgrade Hydra from 1.0 to 1.1

Upgrade Hydra from 1.0 to 1.1 according to the doc.

Hi, I do not see code differences in your commit, instead of several newlines. Please double-check the commit, and if possible, comment on which part of code must be changed by upgrading hydra from 1.0 to 1.1.

Most changes in Hydra 1.1 are not relevant to this repo.
The must-to-address change is the package header. Hydra 1.1 dropped the need of # @package _group_, so I removed them in this PR.
Ref: https://hydra.cc/docs/upgrades/1.0_to_1.1/changes_to_package_header


Pull LUDOX protocol out of tests.

Take the building of the LUDOX protocol object and file out of the body of the test, and move it to a python script in the examples/ directory.  The test now will load and run this procedure, making it reusable.
The top level ludox_protocol procedure is decomposed into sub-procedures, to make it possible to demonstrate it step-by-step, the way @dbryce has done in his jupyter notebook.

This is marked as WIP, because this version has a slight difference in description string that breaks test_LUDOX.py

Fixed the whitespace issue and force-pushed. Tests now pass for me locally. Checking the CI results.

Note that to make this pass the tests, I had to make my LUDOX protocol bug-compatible with main. That is, as before, the provisioning of LUDOX and H2O are flipped, and this should be fixed.

I wonder whether the level of refactoring into functions wrapping 1-2 steps is a bit excessive? Other than that, this is fine by me.

I did that because I wanted to support Dan's demo where he shows adding components to the protocol step-by-step, with partial protocol graphs along the way.  Otherwise, constructing the whole protocol in a single procedure would be fine.

I wonder whether the level of refactoring into functions wrapping 1-2 steps is a bit excessive? Other than that, this is fine by me.

I did that because I wanted to support Dan's demo where he shows adding components to the protocol step-by-step, with partial protocol graphs along the way. Otherwise, constructing the whole protocol in a single procedure would be fine.

I don't think I need those because it will likely vary much by protocol.  I think I'd rather show the nitty gritty.  One option would be to use IPython magic to start with these function calls and then have them replaced by their bodies.  Then, we can execute the body in the cell.  This would (I think) require executing the cells twice.

I wonder whether the level of refactoring into functions wrapping 1-2 steps is a bit excessive? Other than that, this is fine by me.

I did that because I wanted to support Dan's demo where he shows adding components to the protocol step-by-step, with partial protocol graphs along the way. Otherwise, constructing the whole protocol in a single procedure would be fine.

I don't think I need those because it will likely vary much by protocol. I think I'd rather show the nitty gritty. One option would be to use IPython magic to start with these function calls and then have them replaced by their bodies. Then, we can execute the body in the cell. This would (I think) require executing the cells twice.

You could do that, or you could just build the notebook from the module, using the Python library that lets you create a notebook and then populate its cells.  I did that in my code that automatically built notebooks from the growth analysis code.  You could grab the module with the protocol definition, then pull the code out of each of the functions (using AST) and shove it into the notebook cells.  That would programmatically build a notebook file that you could then run, avoiding the need for multiple executions and self-modifying cells.

Meanwhile, I would like to get this merged -- modified if necessary -- sooner rather than later, so I can build container specifications into the protocol.


Next.js 16: Convert the Avatar React page from MDX to TSX

This also deletes the Avatar usage page. I'll convert that to TSX in a separate PR.
Some of the code is in a messy state, but I'll clean that up once I've found the abstractions that I like. (For example, there's still an components/mdx/ folder even though we're leaving MDX.)

@lavelle — I got into a Git merge mess, but I think I've fixed it. Can you take another look?

Closing this for now. Will revisit


Crick fails to install via pip when wheel needs to be built

Describe the issue:
pip install crick fails when building a wheel due to apparent errors in the pyproject.toml file. The issue is fixed by #41 but that change has not been released.
Minimal Complete Verifiable Example:
In a clean environment, run
pip install crick --no-cache-dir
Anything else we need to know?:
The output of the above command:
  Downloading crick-0.0.4.tar.gz (428 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 428.5/428.5 kB 680.9 kB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [151 lines of output]
      <string>:4: DeprecationWarning:

        `numpy.distutils` is deprecated since NumPy 1.23.0, as a result
        of the deprecation of `distutils` itself. It will be removed for
        Python >= 3.12. For older Python versions it will remain present.
        It is recommended to use `setuptools < 60.0` for those Python versions.
        For more details, see:
          https://numpy.org/devdocs/reference/distutils_status_migration.html

      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-install-e9co2_0b/crick_1846722b288141f2872a28b5fddbd047/crick/space_saving.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-install-e9co2_0b/crick_1846722b288141f2872a28b5fddbd047/crick/stats.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-install-e9co2_0b/crick_1846722b288141f2872a28b5fddbd047/crick/tdigest.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      Compiling crick/tdigest.pyx because it changed.
      Compiling crick/space_saving.pyx because it changed.
      Compiling crick/stats.pyx because it changed.
      [1/3] Cythonizing crick/space_saving.pyx
      [2/3] Cythonizing crick/stats.pyx
      [3/3] Cythonizing crick/tdigest.pyx
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `description` defined outside of `pyproject.toml` is ignored.
      !!

              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:

              `description = 'High performance approximate and streaming algorithms'`

              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `description` is listed as `dynamic`.

              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

              To prevent this problem, you can list `description` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

      !!
        _handle_missing_dynamic(dist, project_table)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `readme` defined outside of `pyproject.toml` is ignored.
      !!

              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:

              `readme = 'Crick\n=====\n\n|Build Status| |Conda Badge| |PyPI Badge|\n\nCrick is a fast library of approximate and streaming algorithms. It is still a\nwork in progress, use at your own risk.\n\nInstallation\n------------\n\nCrick is available via ``conda`` or ``pip``:\n\n::\n\n   # Install with conda\n   $ conda install crick -c conda-forge\n\n   # Install with pip\n   $ pip install crick\n\n.. |Build Status| image:: https://github.com/dask/crick/actions/workflows/tests.yml/badge.svg\n   :target: https://github.com/dask/crick/actions/workflows/tests.yml\n.. |PyPI Badge| image:: https://img.shields.io/pypi/v/crick.svg\n   :target: https://pypi.python.org/pypi/crick\n.. |Conda Badge| image:: https://anaconda.org/conda-forge/crick/badges/version.svg\n   :target: https://anaconda.org/conda-forge/crick\n'`

              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `readme` is listed as `dynamic`.

              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

              To prevent this problem, you can list `readme` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

      !!
        _handle_missing_dynamic(dist, project_table)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `license` defined outside of `pyproject.toml` is ignored.
      !!

              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:

              `license = 'BSD'`

              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `license` is listed as `dynamic`.

              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

              To prevent this problem, you can list `license` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

      !!
        _handle_missing_dynamic(dist, project_table)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `authors` defined outside of `pyproject.toml` is ignored.
      !!

              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:

              `authors = 'Jim Crist'`

              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `authors` is listed as `dynamic`.

              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

              To prevent this problem, you can list `authors` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

      !!
        _handle_missing_dynamic(dist, project_table)
      /private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `keywords` defined outside of `pyproject.toml` is ignored.
      !!

              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:

              `keywords = ['streaming approximate algorithms']`

              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `keywords` is listed as `dynamic`.

              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

              To prevent this problem, you can list `keywords` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

      !!
        _handle_missing_dynamic(dist, project_table)
      Traceback (most recent call last):
        File "/Users/.../conda/envs/crick-test/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/Users/.../conda/envs/crick-test/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/Users/.../conda/envs/crick-test/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 54, in <module>
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 103, in setup
          return distutils.core.setup(**attrs)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 159, in setup
          dist.parse_config_files()
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 627, in parse_config_files
          pyprojecttoml.apply_configuration(self, filename, ignore_option_errors)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/pyprojecttoml.py", line 67, in apply_configuration
          return _apply(dist, config, filepath)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py", line 56, in apply
          _apply_project_table(dist, config, root_dir)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py", line 82, in _apply_project_table
          corresp(dist, value, root_dir)
        File "/private/var/folders/5l/v0p6xl4d5md7t7l6bfy7kh340000gp/T/pip-build-env-w99jvs0a/overlay/lib/python3.10/site-packages/setuptools/config/_apply_pyprojecttoml.py", line 163, in _long_description
          file = val.get("file") or []
      AttributeError: 'NoneType' object has no attribute 'get'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.```

**Environment**:

- Dask version: NA
- Python version: 3.10.13
- Operating System: MacOS on arm64
- Install method (conda, pip, source): pip

Should be fixed now with 0.0.5 https://github.com/dask/crick/releases/tag/0.0.5
Please reopen if not. :)

Thank you so much! Is it possible to get an updated conda release as well? The latest there is 0.0.3.

You bet, https://github.com/conda-forge/crick-feedstock/pull/20 is poised to go in soon. :+1:

@dankerrigan it's just been merged, apologies for the delay!


Update sbt-scalafix to 0.9.15-3

Updates ch.epfl.scala:sbt-scalafix from 0.9.15-2 to 0.9.15-3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: sbt-plugin-update, semver-pre-release

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   86.59%   86.59%
=======================================
  Files         135      135
  Lines        1485     1485
  Branches       36       36
=======================================
  Hits         1286     1286
  Misses        199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a028b2b...a6c53f7. Read the comment docs.


Benchmarks specified but ignored without a benchmarks field in manifest.

I got the following warning message: Benchmarks specified but ignored without a benchmarks field in manifest.
I used the following command line:
python -m ego4d.cli.cli --output_directory="/datasets/ego4d" --datasets clips annotations viz slowfast8x8_r101_k400 av_models --metadata --benchmarks AV -y

That's just a result of benchmarks not being relevant for some of the datasets specified.  No issue there.  We can clean up the error message.
Thanks Kyle

Thanks!


IOS build issue

Found two errors:

node_modules/@charmy.tech/react-native-stroke-text/ios/StrokeTextView.swift:94:40 Cannot find 'RCTFont' in scope
node_modules/@charmy.tech/react-native-stroke-text/ios/StrokeTextView.swift:94:55 'nil' requires a contextual type

Have fun 🎉
https://github.com/charmy/react-native-stroke-text/releases/tag/1.2.2


readOnlyRootFilesystem changed to true

#34117

No reason as such. Shall I remove the extra line?
On Sun, 5 Jun, 2022, 10:54 am Sean, @.***> wrote:

@.**** commented on this pull request.
In content/en/examples/policy/restricted-psp.yaml
https://github.com/kubernetes/website/pull/34133#discussion_r889650832:

@@ -45,4 +45,5 @@ spec:
# Forbid adding the root group.
- min: 1
max: 65535

readOnlyRootFilesystem: false

readOnlyRootFilesystem: true

Are there any reason to add a empty line in the end of file?
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/34133#pullrequestreview-995976739,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUQQSLSOQ5FCFMSKBTUNEYTVNQ2YBANCNFSM5X4OTZOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'd like to see some evidences why this change is needed.

@NitishKumar06 , please take a look at @tengqm 's [comment](I'd like to see some evidences why this change is needed.)

Hey! I think this was not an issue to be worked upon. Shall I close this PR?

@NitishKumar06 👋🏻

I think this was not an issue to be worked upon. Shall I close this PR?

As wrangler for the week, I can do it for you.
/close

Thank you ! @zacharysarah


Unable to export data as sql

Hi, I am unable to export a table as an sql insert statement
using version 4.3.5 on Windows 10

cannot reproduce the issue.
ticket closed.
if it is still actual for you - feel free to reopen the issue


Update stable version in repo from 0.3.1 to 1.0.0

Think about update stable version to 1.0.0
Version: stable=0.3.1 (1352 days old) => latest=1.0.0 (16 days old)
Installs: stable=2002 (92%), latest=113 (5.19%), total=2176
Click to edit

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.0.0 but the current stable version is already 1.0.0.
So this issue should be closed.


Us044 display ru details

Added new page at /reporting-units/<ru_ref>
Currently it only displays the most recent reporting unit name and the RU_REF
Trello
Confluence

 US044: INT View RU Details [Med]

Codecov Report

Merging #45 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage    99.7%   99.72%   +0.02%
==========================================
  Files          20       22       +2
  Lines         337      365      +28
==========================================
+ Hits          336      364      +28
  Misses          1        1

Impacted Files
Coverage Δ

response_operations_ui/__init__.py
100% <ø> (ø)
:arrow_up:

...ions_ui/controllers/reporting_units_controllers.py
100% <100%> (ø)

response_operations_ui/views/reporting_units.py
100% <100%> (ø)

response_operations_ui/views/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb7158...178853c. Read the comment docs.


SignUp with Social Account

Hi,
Is it possible to create facebook Signup ??

Hi @sajumani,
Yes, if you mean if you can create a user by having them sign in with their Facebook account, then absolutely.  Feel free to take a look at the Usage section, where Facebook is the first example.
Let me know if you have any other questions!


feat: structure auto-completion & partial InfoTrees

This PR adds auto-completion for the fields of structure instance notation. Specifically, querying the completions via Ctrl+Space in the whitespace of a structure instance notation will now bring up the full list of fields.
This PR also makes completions of partial structure fields in the bracketed structure instance notation work again (e.g. completing a in { a }). These were previously broken by the introduction of set notation.
In order to facilitate language server support for ambiguous syntax where all associated elaborators fail, this PR introduces the notion of an InfoTree choice node and an InfoTree PartialTermInfo node. Choice nodes are produced by the elaborator when several overloaded elaborators fail and contain the InfoTrees of each failed elaborator as subtrees. PartialTermInfos are generated when an individual elaborator fails to produce an Expr so that the subtrees produced by that elaborator can be retained as children of that PartialTermInfo.
Since the InfoTree contains more similar CompletionInfos after the introduction of choice nodes, this PR reworks the CompletionInfo selection to be more effective at selecting the best CompletionInfo amongst multiple similar ones.
Finally, this PR splits Completion.lean into several files and fixes #5807.
Breaking changes

Lean.Elab.withInfoContext' and Lean.Elab.Term.withInfoContext' gained a new parameter mkInfoOnError that is used to produce an InfoTree node when the elaborator x fails. In cases where mkInfo produces a TermInfo using Lean.Elab.Term.mkTermInfo, mkInfoOnError should produce an equivalent PartialTermInfo without an Expr using Lean.Elab.Term.mkPartialTermInfo.
Lean.Elab.Info gained two new alternatives: ofPartialTermInfo and ofChoiceInfo.
The id field of the fieldId alternative of Lean.Elab.CompletionInfo has been turned into an Option with none representing a full field completion.

Details of other changes

Init/Prelude.lean and Init/Meta.lean: Add two new functions getTrailing? and getTrailingTailPos? to work with the trailing whitespace of a SourceInfo / Syntax.
Lean/Elab/App.lean:

Adjust dot completion of a.b.c so that the CompletionInfos for a.b.c reference the syntax a, a.b and a.b.c respectively, instead of all referencing a.b.c. Before, these CompletionInfos were indistinguishable and we only chose the right one by accident.
Adjust mergeFailures to produce an InfoTree with an ofChoiceInfo root node and the InfoTrees of all failed elaborators as subtrees instead of throwing them away.

Lean/Elab/BuiltinTerm.lean: Adjust elabCompletion so that it always produces an identifier CompletionInfo, even when elaborating the left hand side of a dot completion succeeds and we also add a dot CompletionInfo to the InfoTree. With the changes to the CompletionInfo selection in the language server, the language server will now always pick the correct one of these two. Before, we had a special case in the language server dot completion where under certain circumstances we would treat it a dot completion as an identifier completion instead - with this change, this is now not necessary anymore.
Lean/Elab/MutualDef.lean: Adjust expandWhereStructInst to set reasonable SourceInfos for the produced bracketed structure instance notation. The structure field completion benefits from this SourceInfo.
Lean/Server/RequestHandling.lean: Adjust handleCompletion so that in the - completion case, we also emit CompletionInfoData. This fixes #5807.

Does this work after def foo : MyStruct where  and package foo where?

Does this work after def foo : MyStruct where and package foo where?

"Yes" to the first question, see the test file: https://github.com/mhuisi/lean4/blob/mhuisi/constructor-field-completion-2/tests/lean/interactive/completionStructureInstance.lean
It doesn't work in the second case because Lake config declarations are a separate command with its own syntax and its own elaborator. For now, whitespace completions are specific to certain syntaxes (before macro expansion).

Does this make it easy to implement the corresponding feature in lake? This has been a long standing feature request.

The whitespace completion triggers on the Lean.Parser.Command.whereStructInst parser. I don't know whether it makes sense for Lake to move its config declarations to this parser. (cc @tydeu)

@mhuisi It don't think using whereStructInst directly is likely viable. Is there some way to emulate this behavior in  a different elaborator?

@mhuisi It don't think using whereStructInst directly is likely viable in Lake. Is there some standard way to emulate this behavior in a different elaborator?

No, there is not.

@mhuisi Ah, so this new completion is hardcoded to the parser and is not a matter of creating the right info-tree nodes?


Where can I find the barcode for single cell identify from the returned object of repLoad ?

Hi,
thank you so much for the excellent tool for users. I have a question below:

I have a single cell immune reportoire data and preprocessed with MixCR
loaded by repLoad function.
object have the following columns:

> names(immdata$data$`HZ01_d1-B.clonotypes.IGH`)
 [1] "Clones"     "Proportion" "CDR3.nt"    "CDR3.aa"    "V.name"     "D.name"     "J.name"
 [8] "V.end"      "D.start"    "D.end"      "J.start"    "VJ.ins"     "VD.ins"     "DJ.ins"
[15] "Sequence"

The Clones have very large numbers such as:
> summary(immdata$data$`HZ01_d1-B.clonotypes.IGH`$Clones)
     Min.   1st Qu.    Median      Mean   3rd Qu.      Max.
      1.0       1.0       4.0   37466.6      21.5 2598331.0

I think this can be the reads number.
However, I cannot get the single cell- level data from this dataframe. the barcode identity is not shown in the output. I would like to combine single cell mRNA and TCR data. Is that function supported by the current version?

Hello, @zh-zhang1984 !
Thank you for using our package!
Currently, we are developing a Single-cell support for the Immunarch package.
We have made new tutorial for BCR MIXCR data (https://immunarch.com/articles/web_only/BCRpipeline.html). It may help you.
We will be very pleased and grateful if you consider providng an example of your data. You can send the data directly to our tech support at<EMAIL_ADDRESS>Best regards,
Immunarch team


Typings - why DoughnutControllerChartOptions do not extend ChartOptions?

export interface DoughnutControllerChartOptions {
	/**
	 * Sweep to allow arcs to cover.
	 * @default 360
	 */
	circumference: number;

	/**
	 * The portion of the chart that is cut out of the middle. ('50%' - for doughnut, 0 - for pie)
	 * String ending with '%' means percentage, number means pixels.
	 * @default 50
	 */
	cutout: Scriptable<number | string, ScriptableContext<'doughnut'>>;

	/**
	 * The outer radius of the chart. String ending with '%' means percentage of maximum radius, number means pixels.
	 * @default '100%'
	 */
	radius: Scriptable<number | string, ScriptableContext<'doughnut'>>;

	/**
	 * Starting angle to draw arcs from.
	 * @default 0
	 */
	rotation: number;

	/**
	 * Spacing between the arcs
	 * @default 0
	 */
	spacing: number;

	animation: false | DoughnutAnimationOptions;
}

This also applies for all other types of charts (PolarAreaControllerChartOptions, BarControllerChartOptions, ....).
Environment

Chart.js version: 3.6.0

The specific chart types do not inherit from ChartOptions because ChartOptions is composed from a number of different pieces.
export type ChartOptions<TType extends ChartType = ChartType> = DeepPartial<
  CoreChartOptions<TType> &
  ElementChartOptions<TType> &
  PluginChartOptions<TType> &
  DatasetChartOptions<TType> &
  ScaleChartOptions<TType> &
  ChartTypeRegistry[TType]['chartOptions']
>;

Is there a specific reason you need inheritance for the chart options types?

And do some of those pieces not apply for some chart types? Because otherwise I dont see a problem with having a composed base class.
Now, when I want to have a method which returns chartOptions object I have to use return type DoughnutControllerChartOptions  & ChartOptions. I am not saying this is a big issue for me. I have just intuitively assumed inheritance is there already.

They should all apply to all chart types though some of the pieces change type based on the chart type. I think if you had a function that created the chart options for a doughnut chart, the return type would be ChartOptions<'doughnut'>. That will pull in the DoughnutControllerChartOptions via https://github.com/chartjs/Chart.js/blob/master/types/index.esm.d.ts#L3444 which is included as the last item in the DeepPartial I showed above.

I understand now. But would it not be better not to export DoughnutControllerChartOptions (and likes of it) in typings?

I think there are use cases for that exported type too: creating an custom/extended chart type based on doughnut. But maybe the types could be put in different paths for "users" and "developers" (very bad examples for paths)

For now I think we should stick with the ChartOptions<ChartType> typings. We can expose concrete versions if absolutely necessary, but it doesn't seem like that big of a deal to include the chart type where it's used or define an alias in each project.


Validate CKKA

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address: 51pPuhLArFyrUTiLwFtoySBnELppjNdG13b86zPVBY9Z
Token Name: CIKKA
Token Symbol: CKKA
Logo: (https://raw.githubusercontent.com/baba7ji/crypto/main/cikka.png.png)
Link to the official homepage of token:
Coingecko ID if available  : WORKING ON IT

Hello, this is an unmaintained fork of the deprecated Solana tokenlist repo. Closing this PR.
If you'd like to add token metadata, we recommend you to look at adding onchain Metaplex metadata.
https://developers.metaplex.com/token-metadata/token-standard


Creating new API version for Alerts API

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[x] new API version

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month:
April
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month:
April
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hi @ruowan ,
In regard to the following Cross-Version Breaking Changes -> 1011 - AddingResponseCode | The new version adds a response code '204'.New: Microsoft.Security/stable/2022-01-01/alerts.json#L566:11
This changes and fix the swagger to what we implemented from the start, currently the SDK throws an exception when using this method.
How can we get an exemption for this specific validation?

Pls fix semantic error first.

Working on that
השג את Outlook עבור Androidhttps://aka.ms/AAb9ysg

From: Ruoxuan Wang @.>
Sent: Thursday, February 17, 2022 6:50:28 AM
To: Azure/azure-rest-api-specs @.>
Cc: Yifat Birnbaum @.>; Mention @.>
Subject: Re: [Azure/azure-rest-api-specs] Creating new API version for Alerts API (PR #17877)
Pls fix semantic error first.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F17877%23issuecomment-1042573207&data=04|01|Yifat.Birnbaum%40microsoft.com|9dbc5dbdd6cd4c09eafa08d9f1d105b6|72f988bf86f141af91ab2d7cd011db47|1|0|637806702366557288|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=6ctp7v35pgWc9sAgzumOdpUu356zPGNRPnUgbH6gPgc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMNXSX42GVRVTOWN4KPAFGDU3R5BJANCNFSM5OQ7BNAA&data=04|01|Yifat.Birnbaum%40microsoft.com|9dbc5dbdd6cd4c09eafa08d9f1d105b6|72f988bf86f141af91ab2d7cd011db47|1|0|637806702366557288|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=gohEN5edOe7Xy11Lgr1odO1tGHDaVy%2FRB4iHyQ%2FA9qY%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Yifat.Birnbaum%40microsoft.com|9dbc5dbdd6cd4c09eafa08d9f1d105b6|72f988bf86f141af91ab2d7cd011db47|1|0|637806702366557288|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=5ZXTkXVX4Mk4duHWhwqi6Uq%2FlLB2EGKfKsKaKcEbieQ%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Yifat.Birnbaum%40microsoft.com|9dbc5dbdd6cd4c09eafa08d9f1d105b6|72f988bf86f141af91ab2d7cd011db47|1|0|637806702366557288|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rJbzcwTGS6KzoGxWVjjkn%2FVwdzt2jVM20MBlAznrbs0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @ruowan
Can you please review this PR?
I have breaking changes validations failure, as I changed operations and enums, and created new API version for this


Roll Packages from c7008cf08813 to d654f7597fb1 (3 revisions)

https://github.com/flutter/packages/compare/c7008cf08813...d654f7597fb1
2023-10-04<EMAIL_ADDRESS>[pigeon] FlutterApi error handling (flutter/packages#5008)
2023-10-03<EMAIL_ADDRESS>[webview_flutter] [webview_flutter_wkwebview]Fix race condition in flaky test (flutter/packages#5068)
2023-10-03<EMAIL_ADDRESS>Roll Flutter from 57ed72417780 to 512299113fa0 (21 revisions) (flutter/packages#5067)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Updated fix for #22

Hi @AustinBGibbons, @haeley-qf  I updated fix for #22. It implies dependency on JDK7 due to Files class usage, but I see no big problem here.
Changes in comparison with #23:

Moved commits to separate branch wip_22
Updated .travis.yml to depend on JDK7
Check for file existence added
Tests passed

#29 has been pulled, thanks!