For Chinese devices, Google Play Store is missing

🐛 Bug Report

Expected behavior
Reproduction steps

When I set forceAndroidLocationManager, I still can't get
Configuration
Version: 1.x
Platform:

[x] :iphone: iOS
[x] :robot: Android

@sestegra @willbryant @AlexandreRoba

I have literally no idea why you tagged me. Unsubscribing.

@jahnli, as I am not in China I cannot reproduce this issue on a real device. The only thing I can do is use an emulator without Google Play Store installed. Which for me works fine, have a look at this issue with complete reproduction steps and source code: https://github.com/Baseflow/flutter-geolocator/issues/773#issuecomment-883311979
Feel free to debug further using the plugin source code and if you notice a mistake I would be happy to help and fix it. In that case don't hesitate to leave another comment. For now I will be closing this issue as there isn't much other details and as shown in the linked issue the above code simply work on the emulator and real devices.


host in google cloud

hey guys, i need run the api in the cloud. I try aws, but i get a problem in the google chrome instalation. So i try on google cloud. I instanciate an ubuntu 18.04 vm, install all packages, chromedriver and google chrome. When i run in headless mode any method, like get_unread or get_my_contacts, the following message return:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/webwhatsapi/__init__.py", line 344, in get_unrea
d
    raw_message_groups = self.wapi_functions.getUnreadMessages(include_me, include_notifications, use_unread_count)
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/webwhatsapi/wapi_js_wrapper.py", line 28, in __g
etattr__
    wapi_functions = dir(self)
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/webwhatsapi/wapi_js_wrapper.py", line 46, in __d
ir__
    self.driver.execute_script(script.read())
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 63
6, in execute_script
    'args': converted_args})['value']
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 32
1, in execute
    self.error_handler.check_response(response)
  File "/home/rrafaeljuniorr/anaconda3/lib/python3.6/site-packages/selenium/webdriver/remote/errorhandler.py", line
 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.JavascriptException: Message: javascript error: Cannot read property '_reactRootContaine
r' of null
  (Session info: headless chrome=72.0.3626.109)
  (Driver info: chromedriver=73.0.3683.20 (8e2b610813e167eee3619ac4ce6e42e3ec622017),platform=Linux 4.15.0-1027-gcp
 x86_64)

I use the method driver.save_screenshot and this png return https://drive.google.com/file/d/1_ebmOC_WfC0Tl1kkSShIW-BYrJzbu1Ce/view?usp=sharing
The api can enter in my whatsapp, but the methods dont work. I install the api with pip
Ps.: selenium standalone works

somebody help me, please

Doesn’t install from pip directly. You need to use your own version with the PR waiting from approval merged

The API works with Chrome only on pip version

Sorry, but the pip version or the master repository version doesn’t work anymore. You need to checkout the master with #547 changes. Try to use firefox, I run my service on digital ocean without a problem.


Tests are fixed in https://github.com/dividat/focus-shift/pull/9


Introduce yaml standard library module

Description:

Need to convert[1] into a standard library module adhering to the standard library development process[2]
[1] https://github.com/ballerina-platform/module-ballerina-yaml
[2] https://github.com/ballerina-platform/ballerina-standard-library/blob/main/docs/library-development-process.md

Closing as completed.


Daytona executable binary being removed after use

Describe the bug
Was trying to play with this on my M2 and got this weird behavior:

curl https://download.daytona.io/daytona/get-server.sh | bash

Results: daytona executable in my $HOME/bin directory.

run in a console "daytona server" and it starts fine, but the executable is now gone.

download a new one and if the server is running it's removed right away.

If I stop the server, run the get-server.sh and install a new executable in the $HOME/bin and run a "./daytona help" it displays the help command and removes the executable... weird right???

Looks like running the executable results in removal of that file.
To Reproduce
See above.
Expected behavior
Would not expect the installed binary to be deleted every time trying to use it?
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Macbook M2
Browser: N/A
Daytona Version: current

Additional context
Add any other context about the problem here.

Hi @eschabell! Thanks for trying it out 😄
Also I couldn't reproduce this. The only way binary would be removed, actually not removed but overwritten is if you run the script again and it installs the binary on the same path.
Just to check could you try manually:
curl -sf -L https://download.daytona.io/daytona/latest/daytona-darwin-arm64 -o $HOME/bin/daytona
chmod +x $HOME/bin/daytona

Also you can open Finder on that path and monitor when and if daytona file would be removed. Maybe some security setting?

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.

Due to the lack of activity in the last 7 days since it was marked as "stale", we are closing this Issue. Do not hesitate to reopen it later if necessary.


New plugin: Improved Context Menu

Holding off on reviewing this at the moment as we're considering it as an addition to core in runelite/runelite#17514

This feature was added to core.

I’ve removed the player condensing part of this plugin, it still has some functionality, like adding scroll indicators and capping the menu entry count


EventCounters link doesn't work

The link in the first line of this page in "This document gives an overview..." points to https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.Tracing/documentation/EventCounterTutorial.md but that page itself is 404ing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4663502f-573f-f660-a728-1fabcde8acec
Version Independent ID: 8f9e15bb-34cc-8105-7a47-0d215a27f396
Content: Event counters in Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/eventcounters.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@WhitWaldo Thank you very much for bringing this to our attention. I have submitted a PR to fix the issue, the change is merged internally and will go-live in the public docs shortly.
Until the change reflects, please know that the doc should actually point to this file.
Going forward, the .NET team is using https://github.com/dotnet/runtime to develop the code and issues formerly in the corefx repository.
Please see the following for more context:
dotnet/announcements#119 "Consolidating .NET GitHub repos"
Thanks again!


Harmony: Fat arrow and destructuring in params

Currently esprima throws an exception in cases where the arguments to a fat arrow function have destructuring:
fn( ({ field_name: field_value}) => field_value); //'Unexpected token =>',

This PR will likely fix issue 554 as well.
Note: this patch is from a downstream project that I saw doesn't have this problem: https://github.com/termi/es6-transpiler/blob/master/lib/esprima_harmony.js#L3390-L3394

Superseded by PR #299.


Pug (Jade 2) support in Vue single file components

It is not obvious how to modify webpack config files to use pug (jade 2) syntax inside Vue components. How can we do it?

Please see #97


Unable to fetch dashboard!

Hello,
I get this error in a new created Apigility Project in Zend Studio after the first composer update.

Can  you tell me which versions I have to use in order to prevent this?
Kind regards
Matthias

@netzfische  It will be almost total guess but I would go with zf-hal:<1.4
If it doesn't help we need investigate it more... Let me know if you can try it.
@weierophinney is working now on new zf-apigility-admin version, and it will be done shortly, so probably then this issue will be resolved.

@webimpress Switching to zfcampus/zf-hal version 1.3.1 helped to solve this problem.
Thanks alot.

Hi, we encountered the same problem today and it was also cause by zf-hal version 1.4.x.
To solve it we had to use zf-hal version 1.3.x and downgrade zf-apigility from version ~1.3 to version ~1.2.

I am having the same issue.

@webimpress thanks it helped

zf-apigility-admin 1.5 is already released, so I think it can be closed :)

This repository has been closed and moved to laminas-api-tools/api-tools-admin; a new issue has been opened at https://github.com/laminas-api-tools/api-tools-admin/issues/17.


Add Azure Batch DataPlane SDK version 10

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

For SDK team:

The REST API PR for this REST API is here: https://github.com/Azure/azure-rest-api-specs/pull/4795
This change does introduce breaking changes
Test coverage was added where appropriate (most model changes are covered by existing reflection based testing)

SDK team folks, please allow some time for my coworkers @xingwu1 and @bgklein to review prior to merging.

This also deletes the extra packages.config file which was causing #4880

Looks good to me.

LGTM as well


[BUG] Launch.sh has wrong file path after installing

Describe the bug
After installing, the Launcher.sh has the wrong file path to the wine folder.
The script wants to go into the folder with "wine" in the front, but there is only a folder without that.
Removing the wine in the script or adding it to the folder fixes it. Idk atm how to fix it but that would need fixing
To Reproduce
Steps to reproduce the behavior:

Run install script
Let if finish
Profit?

Expected behavior
Idk what it supposed to do but i guess work properly?
Screenshots

Distro

The issue comes from a recent change in the naming convention of wine-ge's latest release. In the recent release, the wine- prefix has been removed from the folder name, while it's still present in the .tar.xz file. Since the folder's location is retrieved from the .tar.xz file, it's causing a mismatch. This has been fixed, apologies for any inconvenience it might've caused.


Does swagger support annotations on interfaces?

I have some interfaces for which I need to generate swagger documentation. Does swagger support
annotations on interfaces? Can I generate documentation for annotations on interfaces?

Yes.

If I have a class that implements an interface. What is the syntax I have to establish a relationship between the interface and the class that implements the interface?

I don't really know what that means.

Does swagger automatically recognize that a particular class implements an interface?

It should.

What versions of swagger support annotations on interfaces?

Most of them, but you should use the latest, 1.5.0.


re: Checklist for an ideal TOS

why include "Website terms of service are not strictly necessary"?

Because we love it when there are no TOS. Not all platforms need a TOS!

Agree with Jane. I like saying this because I think a lot of people operate under the assumption that every site must have them.


Installation doesnt work

Please check your installation guide.
pi@ceres:~ $ cd /srv
pi@ceres:/srv $ mkdir hss
pi@ceres:/srv $ sudo mkdir hss ->isnt it line above?
pi@ceres:/srv $ sudo chown hss:hss hss -> some error like "could'nt find user" or something like that (sorry can't remember exactly)

Hi, thanks for the hint, fixed the instructions.

Thanks, maybe i can support some skills soon.

Good to hear, hope youre happy with the platform.
One thing to note about the skill-registry: since its running on a free tier heroku account, it will power down after a certain idle time, so the first access will take some seconds (e.g. registering skills, querying skills etc.).
Since there is not too much interest for my hss-skill platform, I havent developed this any further in terms of better hosting / more user friendly connection.


Deprecation warnings  Passing 100%, a non-string value, to unquote() from when deploying to heroku.

DEPRECATION WARNING: Passing 100%, a non-string value, to unquote()
will be an error in future versions of Sass.
on line 27 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/vendor/bundle/ruby/2.1.0/gems/bourbon-3.1.8/app/assets/stylesheets/helpers/_deprecated-webkit-gradient.scss, in linear-gradient'        from line 73 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/vendor/bundle/ruby/2.1.0/gems/bourbon-3.1.8/app/assets/stylesheets/addons/_button.scss, in simple'
from line 26 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/vendor/bundle/ruby/2.1.0/gems/bourbon-3.1.8/app/assets/stylesheets/addons/_button.scss, in `button'
from line 2 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/app/assets/stylesheets/bitters/extends/_button.scss
from line 1 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/app/assets/stylesheets/bitters/extends/_extends.scss
from line 10 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/app/assets/stylesheets/bitters/_bitters.scss
from line 17 of /tmp/build_9267e583e31fc2d70dd66ebd798e28ab/app/assets/stylesheets/application.css.scss
DEPRECATION WARNING: Passing 100%, a non-string value, to unquote()

Good find

This is infact an issue with the Bourbon's button() mixin (which is getting deprecated anyway) and not actually an issue with neat.


Procedure body is stored in incorrect syntax in information_schema.routines after ALTER PROC

Description
Currently when procedures are modified using alter procedure in Babelfish, the information_schema.routines catalog updates the definition to be alter procedure ... which is incorrect behavior. This commit fixes the information_schema entry to store the alter procedure as create procedure ...
Issues Resolved
BABEL-4971
Test Scenarios Covered

Use case based -

ALTER PROCEDURE alter_proc_p1
AS
    select * from alter_proc_orders
GO

select ROUTINE_NAME, ROUTINE_BODY, ROUTINE_DEFINITION from information_schema.routines where SPECIFIC_NAME LIKE 'alter_proc_p1';
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar
alter_proc_p1#!#SQL#!#CREATE PROCEDURE alter_proc_p1<newline>AS<newline>    select * from alter_proc_orders
~~END~~

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

26 of 35 (74.29%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 73.484%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contrib/babelfishpg_tsql/src/pl_handler.c
26
35
74.29%

Totals

Change from base Build<PHONE_NUMBER>4:
0.004%

Covered Lines:
42536

Relevant Lines:
57885

💛  - Coveralls


Add info on creating custom tomcat and configuring it for Windows

Add info on creating custom tomcat and configuring it for Windows
Performs similar configuration changes as done in the Linux section on Shared Server Level resources, but for Windows Tomcat Web Apps

will close/reopen for labeling

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Blaireaux

What steps will reproduce the problem?
1.    string str = "2";
      const char *c = str.c_str();
       changedStatus.AddMember((char*)c, turned_on ? "on" : "off",    this->_doc->GetAllocator());
2. Received : "changed_statuses" => {"\xB8" =? "off"}

What is the expected output? What do you see instead?
Received : "changed_statuses" => {"2" =? "off"}

What version of the product are you using? On what operating system?
-

Please provide any additional information below.
-

Blaireaux.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 1 Nov 2014 at 8:04

This is a user error.  "str" (and therefore "*c") is quite likely destroyed,
when you try to read the object again.  You need to copy the string, if you
can't guarantee that the contents' lifetime is sufficiently long.

Try to change your code to:
  string str = "2";
  Value name(str.c_str(), this->_doc->GetAllocator());
  changedStatus.AddMember(name, turned_on ? "on" : "off",    this->_doc->GetAllocator());
Alternatively, if you really have a constant string "2" here, then you can
safely use:

  Value name("2"); // no copy (but constant string literal)
  changedstatus.AddMember(name, ...);

hth,
Philipp

Original comment by<EMAIL_ADDRESS>on 2 Nov 2014 at 7:17


text_on_image Creator - Web design #65

https://images01.nicepagecdn.com/page/22/94/html-template-2294603.jpg Design a text_on_image like the above image
Create a file "text_on_image_NUM_by_(YourName).html" in the modules/text_on_image folder.
Use simple HTML and CSS and JAVASCRIPT to create the text_on_image animation. You can use the interface development https://kwickerhub.com/ (This project) or you can write the lines of code yourself.
Step by Step Guide.
Fork this project(Use the 'fork' button in the top right corner) and Clone your Fork.
git clone https://github.com/YOUR_USERNAME/frontend
Open your code Editor and Create a file "text_on_image_NUM_YOUR_NAME_.html" in the "modules/text_on_image" folder of this project you just cloned. No need to create head, title and body tags, Just Add a div tag with some embedded style(i.e use the style tag) and the script tag where necessary.
If you want to add an image resource, please add it in the folder ••
"modules/text_on_image/images_and_icons"
We recommend you use an svg for your image/icon.
Push your Code: You need to push your recent changes back to the cloud. Use the command below in the main directory of this Repository
git push origin dev
or use a GUI tool to avoid mistakes or complexity. LOL.
Then make you Pull Request...
Below is a example of the code structure we need:
<div>
    <!---YOUR CODE---->
</div>

<style>
    /* YOUR STYLE */
</style>

<script>
    // YOUR SCRIPT if any
</script>

The goal of this issue is to create modules that other people/dev/designers can use or easily import into their projects. Avoid the desire to style all elements in the page by using codes like:
<style>

*{

}
/* OR */

div, a, h1, pre{

}

</style>

use classes or id to style the elements to avoid a collision of styles.
Remember to make your module usable across different screens(Make your design responsive).
For more examples:
modules->buttons
modules->cards
for examples of contributions or Pull request accepted in to the project.
And please do not wait for this issue to be assigned to you as we have limited hands but have a lot to do/cover. Please send in your PR.
Good-luck and thank you.

Please assign me with this issue, I would like to work on this task

Please assign me with this issue, I would like to work on this task

Hey @NtemKenyor I am working on this issue.

I am working on this one

I am working on this issue

Ok i am not working now thats why i have removed my comments as well
On Thu, Nov 23, 2023, 2:22 PM kteju1 @.***> wrote:

I am working on this issue
—
Reply to this email directly, view it on GitHub
https://github.com/KwickerHub/WebCraftifyAI/issues/565#issuecomment-1824841036,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMGECPAEOVYEH32CTVMDUDDYF6O75AVCNFSM6AAAAAA6LWSBPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUHA2DCMBTGY
.
You are receiving this because you commented.Message ID:
@.***>


Finish tsm file exporter

Add ability to export TSM files to line protocol to be imported back into another database.

[ ] Rebased/mergable
[ ] Tests pass
[ ] CHANGELOG.md updated
[ ] Update docs
[ ] Update README.md

@gunnaraasen

Doesn't this functionality exist already in https://github.com/influxdata/influxdb/blob/master/cmd/influx_inspect/export.go?

@jwilder comments addressed.  Ready for review.

Two small things, but looks good! 👍

Is this part of the 1.0 beta?

@retorquere It's in the current nightlies.

Ok, no issue. Is this compatible with 0.13 and could I compile it separately? Alternatively, are the nightlies usable enough to be mostly-available, and is there a clean upgrade path between 0.13?
Is there a timeline for 1.0?

@retorquere The upgrade bath from 0.13 is straight-forward, installing the new package over the existing 0.13 will be sufficient. Please review the Changelog before upgrading in case you want to modify the new default configuration values (particularly max-series-per-database).

Thanks for the feedback, and I'm looking at that parameter now, but this is about the number of series, not taking into account the cardinality of the tags? Not that it would affect me I think; I have 3 series, each with one tag with cardinality 3, but with 70 fields.


Electrum freezes when loading wallet file

Electrum freezes when i type in my encrypted password. I have tried on multiple computers and it does the same exact thing.

Same for me. After new version there is only window to go for Console or terminate whole app.

Does this happen on all versions of Electrum-VTC or just the current one?

I thought that it is problem of previous version (downloaded 2 weeks ago) so I downloaded new version and got same results :/

Can you describe exactly what happens preferably with screenshots? In the meantime, you can restore the wallet from the seed it gave you when you first created it.

There is a screen cast, if it helps you:
https://youtu.be/Jkz-ZRLNTMQ
Will try to restore my wallet. Thanks

I've tried second backup wallet file and everything is OK now.

Sounds like this is solved now.


Defining top level functions does not work

Functions generated at top level are skipped during compilation:
haxe code:
package;

// not working (not existing in c++)
function test_me(): String {
  return "hello";
}

// works
class Test {
  public static function test(): Int {
    return 5;
  }
}

class Main {
  static function main(){
    trace("Hello world from haxe!");
    Test.test();
    test_me();
  }
}

main.h
#pragma once

class Main {
public:
	static void main();
};

class Test {
public:
	static int test();
};

Main.cpp
#include "Main.h"

#include <iostream>
#include <memory>
#include <string>

using namespace std::string_literals;

void Main::main() {
	std::cout << "Main.hx:16: Hello world from haxe!"s << std::endl;
	Test::test();
	test_me();
}
int Test::test() {
	return 5;
}

Huh... this is very weird. I'll try and resolve asap!

Thanks for the report, fixed! (Make sure Reflaxe is updated: haxelib update)


Rare Lag / bump for large image files when using page indicator / mouse scrolling

Setup or portable version of the app?
Portable
Steps to reproduce

Chapter 1.zip
Chapter 2.zip
Expected Behavior.zip

Extract the above zip files and open them - For better experience and faster loading for comparison.
Type a value in the page indicator for the expected behavior file above.
Now, type a value in the page indicator for the chapter 1, chapter 2.
Compare them both.
You can also use the scroll bar for comparison, drag the scroll bar down.

https://github.com/mienaiyami/yomikiru/assets/116664905/b8815f7e-4d46-4ba0-be41-c546b9798aa7
✔ Expected Behavior
To be as smooth as the below test file with no lags / bumps while using page indicator, scroll bar.

Open expected behavior.zip and extract it to a folder.
Copy and paste upto 1600 files.
Now navigate using page number.
It is still smooth with no lag at all, even when the total folder size is 255 MB with 1600 images.
In layman terms, I am torture testing the app, but still it only uses 5 - 7% of CPU usage while fast scrolling through 1000's of images with no lags at all.

https://github.com/mienaiyami/yomikiru/assets/116664905/f7eb92a9-8e18-4689-8f7d-16de37970a22
❌ Actual Behavior
1. The chapter 1, chapter 2 files have lags while using page indicator, scroll bar.
2. Rarely, lags / bumps also occur while scrolling.

Bumps / Lags related,

I tested the mouse scrolling for 15 times on these two files, it only had lags for 2 times out of 20 times while using scrolling.
That too not for the entire chapter, but for 5 - 7 images.
I opened the dev tools to see if there is any error, but unlike the pervious versions there is no decode error too.

https://github.com/mienaiyami/yomikiru/assets/116664905/66dbd217-7cfe-4d4b-9b48-152750e0ae67
https://github.com/mienaiyami/yomikiru/assets/116664905/d5c845e1-916d-4031-a474-e02d9e26e292
https://github.com/mienaiyami/yomikiru/assets/116664905/394d3872-f208-4cf1-ab7d-ef7df58fe6b5

Thanks, I will look into it.
And maybe also add a very small delay before changing page on input to prevent unnecessary scrolling.

The above error is probably related to shortcut saving. Did you change shortcut settings?
I have fixed that and will be releasing on Saturday or Sunday.

It cant be fixed. It is possibly system related.

I cant control resources allocated to app. It is controlled by the framework.

Its actually normal. Image resolution is maybe too high or is it webp? Its hard to control everything through provided methods.
I believe it has to do more with this specific image creator, i think it is the same manga which started the old stuttering issue.

What do you mean by this? Does this have something to do with webp?
I meant the images from that studio. And yes, webp images are more compressed than jpg and png.

It is also related to #140 and #143. Things above will not cant any measuresable difference.
I think I will need to add option to toggle hardware acceleration.


Protect Orchestrator API with different JWT then the one of AYS Server

Currently you get both access to the Orchestrator API AND the AYS Server with the same JWT, which should not be allowed, the AYS Server RESTful API should be protected for internal use only.
This is maybe also why we had the problem described in https://github.com/zero-os/0-orchestrator/issues/888

This is not possible by design. Because the orchestrator forwards the JWT of the client towards the AYS server which by itself forwards it to the zero-os nodes.


Don't delete targets that seem invalid if they are 'direct' targets

Fixes #2087
We were removing the cm.targets entry because we had an incoming connection from that IP address, but that means we remove all knowledge of previous attempts so we will reconnect very quickly.
Leaving all "direct" targets in the targets set is a better approach: it is bounded (by the size of the direct peer list), and innocuous unless the connection is repeatedly failing.

I think this will cause weave status connections to report failed direct connections as retrying forever, even beyond the stated retry deadline, when there is an inbound connection from the target IP.
We could perhaps introduce another state, e.g. TargetDisabled. But that is a change which ripples through the code. So perhaps leave that out of 1.4.x but put it in 1.5.x?

Yes:
weave_on $HOST1 launch-router $HOST2
weave_on $HOST2 launch-router $HOST1

On host1:
weave status connections
<- <IP_ADDRESS>:40908   established fastdp da:21:5e:dd:1e:c9(host2)
-> <IP_ADDRESS>:6783    failed      dial tcp4 <IP_ADDRESS>:6783: getsockopt: connection refused, retry: 2016-03-23 11:49:26.882239193 +0000 UTC

the "connection refused" is from the time when host1 was up but host2 wasn't ready yet.


UTF-8 Characters are not displayed in response panel (raw-view)

when dealing with utf-8 characters in api responses, it displays as unicode escape sequences , for example
response from api is :
{name:"علی عماد"}

but in response panel's raw view it is :
{name:"\u0639\u0644\u06CC\u0020\u0639\u0645\u0627\u062F"}

Yes raw view is meant for showing the raw response


Gemm slow on specific AMD epyic CPU

Describe the bug
Running the faer-bench benchmark on 2xAMD EPYC 7V13 64-Core Processor
is surprisingly slow. Both in absolute numbers, as well as in comparing the speedup of faer(par) over faer(seq).
This does not seem to be the case on other, larger AMD server cpu's
To Reproduce
Just to keep track for myself:
CXXFLAGS="-I/u/drehwald/prog"  CXX=g++ cargo +nightly run --release --no-default-features --features faer
Expected behavior
Well, don't be slow.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
➜  ~ g++ --version
g++ (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

➜  ~ cargo +nightly --version
cargo 1.71.0-nightly (d0a4cbcee 2023-04-16)

Additional context
Our admin just got back to me, university admins probably won't adjust the perf settings for us, the machine is too busy so it would be a perf risk. But I got access to two other AMD machines, maybe we can use that for pinning the issue down.

solved by https://github.com/sarah-ek/gemm/commit/ab51c49534176f8a2823a01fd1d24b2f2aa8ccc7

solved by https://github.com/sarah-ek/gemm/commit/ab51c49534176f8a2823a01fd1d24b2f2aa8ccc7

f64

## Matrix multiplication

Multiplication of two square matrices of dimension `n`.

    n       faer  faer(par)    ndarray   nalgebra      eigen
 8192     27.09s      1.06s    926.3ms          -      2.14s


Add inner loop aggregation options

Fixes #8.
This PR introduces an aggregation option for the inner_loop callback, which controls how the logs from the inner loop are aggregated. The default behavior of returning the last value for each entry in a collection is maintained. This is equivalent to manually setting aggregation="last".
aggregation supports a string value, one of "last", "first", "min", "max", "mean", and "sum". In this case all values in all collections will be aggregated as specified. However, since some collections might require different aggregations (e.g., "stateful_metrics" and "metrics" likely want "last" and "mean", respectively) it is also possible to specify a dict from collection to aggregation such as {"stateful_metrics": "last", "metrics": "mean"}. If a collection is not specified in this dictionary, then the "last" aggregation is used.
A inner_loop_kwargs argument has been added to train_loop in order to surface the aggregation options to a user of that API.
The PR also adds tests for both aggregation and inner_loop_kwargs.
Let me know what you think :) I also wasn't sure how best to document this functionality.

Thanks @JamesAllingham for doing this! I like the approach of transposing as it makes implementing reduction fairly easy.
I do have some request though, can you make it more general by also accepting Callables?

Thanks @JamesAllingham for doing this! I like the approach of transposing as it makes implementing reduction fairly easy. I do have some request though, can you make it more general by also accepting Callables?

No problem! Happy to contribute to this library. Thanks for the positive feedback.
That's a great idea – done. Let me know what you think of the changes.

My pleasure! Thanks for fixing the pre-commit.

Thanks @JamesAllingham for doing this!
Gave the PR a little push to pass it over the line.


drivers: clock_control: stm32h5: boot_clock_assert_fix

When the image is chain-loaded, clocks may already by initialized. The driver was lacking support for already configured HSE and PLL sources. When CONFIG_ASSERT=y get_startup_frequency was failing since it did not recognize these sources.
It's the same issue that was addressed in #58109 for stm32u5.

Thanks for the PR! Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request.

I think I've messed up signing the commits. Could you take a look? Should i just redo my PR?

I think I've messed up signing the commits. Could you take a look? Should i just redo my PR?

You just need to reset your branch to the initial commit, then amend it.
To update the author name, see https://www.git-tower.com/learn/git/faq/change-author-name-email
Once you're done, use git push -f ... to update the remote branch.


Avoid downloading duplicate

A quick update to avoid downloading duplicate images

That is not going to work at scale and will make the code slow
The best way to do this is to remove images from the input file

Right, I removed dup check but added history base check.

I want this package to scale. It currently works up to 400M samples, i intend for it to work for a few billions next.
Adding an "history check" in that way will not scale.
I don't think there is any way but to have a job before that script to do the filtering of the input
We could consider providing that script as another file / command in this repo.

I made a hot fix for the laion400m dataset here . Maybe you can consider this solution for other formats.
1 resume flag
2 it is a valid resume if both meta parquet and tar file exists in each downloader thread
3 for a valid resume downloading thread, filter out those not downloaded yet and only download this into a resume.tar
4 append resume.tar to original tar to get a new tar.
It now only works for fixed dataset resuming with the exact same command.
I use this feature to maintain image number as the original order.

I did ran the script and the performance with or without history check isnt much different.

the problem here was putting everything in memory. That doesn't work for 400M samples
I will implement a better solution for this
thanks for the PR anyway!


add safeguards against invalid raw json strings

I realized that my code that serializes raw JSON down from the database has no protections to ensure that the data is actually valid JSON. If it's malformed in any way, the formatter will happily send it onto the wire and the client will choke on the response.
I added a check that validates raw json properties before they are serialized. If the property value contains unparseable syntax, like { x }, then the entire object will be sent down as an empty hash {}. If the property value contains unquoted keys, then the keys will be quoted. So { foo: 3 } will be serialized as { "foo": 3 }.
(I originally wanted to have the same behavior if we detect unquoted keys as if the JSON is malformed. But I don't think it's possible to make Json.NET do this - the JToken parser just converts the unquoted keys into quoted ones instead of throwing an exception.)

BTW this will not merge cleanly with #43, so I'll fix and rebase when one is merged.

Merges cleanly now.


 Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y fix #1493

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

3 of 4 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.317%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/sema/src/resolver/config.rs
3
4
75.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
54031

Relevant Lines:
76839

💛  - Coveralls


always disable deabstraction in dynamic compilation mode

Now that IRGen can handle everything with deabstraction disabled, we can disable deabstraction in dynamic compilation mode.
This removes the -tf-disable-deabstraction compiler flag.
Since TFDeabstraction no longer runs in dynamic compilation mode, I can remove a bunch of special case conditions that only occur in dynamic compilation mode:

shouldBeInlined has a special case to turn off most inlining in dynamic compilation mode. Removed this.
A special case to allow generic out-parameters when it's in dynamic compilation mode. Removed this.
A special case to allow nonconst attributes in dynamic compilation mode. Removed this.
A special case to not promote constants to graph in dynamic compilation mode. Removed this.
A special case to allow generic TensorGroup inputs in dynamic compilation mode. Removed this.

And one other simplification:

I removed a check that skips deabstraction when fn.isAvailableExternally(). This is correct because the subsequent !tfc.shouldBePartitioned() now handles it. (Before this PR, the !tfc.shouldBePartitioned() check did not run in dynamic compilation mode, which is why we needed the additional fn.isAvailableExternally() check).

@swift-ci please test tensorflow


Marx.css or marx.min.css?

I have opened both files in my editor and while I haven't gone line by line, they both looks about the same and almost have the same number of lines.
Also, I kind of have another topic but didn't want to spam the issues with my questions. In the marx demo seen here http://codepen.io/mblode/details/QNaKMe it says the article tag is 60%, the aside 40%, and section 100%. In the CSS file (both marx and marx.min) the article selector is set to "width: 100%" and so is Aside. Am I not understanding something fundamental about this?
I'm referencing it correctly in my html. It worked fine pulling it from here as well.
<link rel="stylesheet" href="https://cdn.rawgit.com/mblode/marx/master/css/marx.min.css">
http://puu.sh/pSUsH/945f15794c.png

It looks like at some point, aside and such were given full widths (instead of sidebar-like abilities)

so what's the point of article and aside? I guess the demo is not up to date anymore.


Webworker proxy with If-Modified-Since header

Is this a bug report?
Yes
Steps to reproduce
I have poller in shared worker with header If-Modified-Since

run webpack-dev-server with proxy
Poller starts
backend returns 304 status

Expected behavior
http-proxy-middleware send 304 status, not 502
Actual behavior
i have errors in console
[HPM] Error occurred while trying to proxy request /api/[API_METHOD] from localhost:3000 to http://[SERVER_IP]/ (HPE_INVALID_CONSTANT) (https://nodejs.org/api/errors.html#errors_common_system_errors)

and errors in Network in chrome devtools:
General:
Request URL: http://localhost:3000/api/[API_METHOD]
Request Method: GET
Status Code: 502 Not Modified
Remote Address: [::1]:3000
Referrer Policy: no-referrer-when-downgrade

Request Headers:
Accept: application/json, text/plain, */*
If-Modified-Since: Fri, 20 Dec 2019 12:41:54 GMT
Referer: http://localhost:3000/assets/worker.60f6a122912284b508fb.js
User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.79 Safari/537.36
X-Requested-With: XMLHttpRequest

Response:
Error occured while trying to proxy to: localhost:3000/api/[API_METHOD]

But on server nginx log have:
"GET /api/[API_METHOD] HTTP/1.1" 304 20 "http://<IP_ADDRESS>/assets/worker.18dcf756e7fd7ec3befb.js" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.79 Safari/537.36"

304 - status, but proxy send me 502 status with Not Modified message
Setup
webpack-dev-server configuration:
proxy: {
    '/api/**': {
      target: "http://[SERVER_IP]/",
      changeOrigin: true
    }
}

http-proxy-middleware: 0.19.1(as<EMAIL_ADDRESS>dependencies)
server: "webpack-dev-server": "3.1.3"

client info
Fedora 31 (5.3.16-300.fc31.x86_64)
node version: v12.13.1

I'm also hitting this after upgraded node to v14 and npm to v7.
Perfectly good (according to Chrome/Firefox) HTTP 1.1 304s turn into 502s.
[HPM] Error occurred while trying to proxy request /version from localhost:2992 to http://localhost:5000 (HPE_INVALID_CONSTANT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
Any update, others experiencing or something I could be doing wrong? Thanks

Same situation without worker. With other statuses 300, 301,302, 303 - it proxy well.
But when i back from server 304, it fires error

wait for a solution, I found it cause a Zlib Error: unexpected end of file, I think it's nothing to decompress, so it crash.
And I tried to return statusCode just 304 from local simple express server, it normally work. So, doesn't know what response with 304 cause this issue, anybody have precise demo for reproduce this issue?

Same situation without worker. With other statuses 300, 301,302, 303 - it proxy well. But when i back from server 304, it fires error
Still no solution?


[AAP-24669] Support Undo and Reset for Settings Inputs

The latest CI run indicates failures for known flaky test cases. Merging this PR. https://github.com/ansible/ansible-ui/actions/runs/9472914648/job/26099123816?pr=2473


Make sure Opacity widgets/layers do not drop the offset

fixes https://github.com/flutter/flutter/issues/89255
fixes https://github.com/flutter/flutter/issues/71008
Now, instead of dropping the opacity layer when it is either disabled or the value is opaque, it uses an OffsetLayer instead. This avoids some of the memory regression from https://github.com/flutter/flutter/pull/83145, because the engine special cases OpacityLayers to always raster cache them, but does not do quite the same with OffsetLayers.
I did see some regression on mean/median on the internal benchmark, but overall the values are still within the range of the change without this PR.
/cc @xster

Gold has detected about 4 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/89264

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/89264

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/89264

Gold has detected about 1 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/89264

Gold has detected about 2 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/89264

This changes some internal goldens in an expected manner, since there's no longer the pixel snapping going on at the end of an opacity animation. /cc @renyou @angjieli - this looks like it affected about 170 golden files internally in a smoke test. I assume it will be more in a full TGP.

/cc @flar

@flar - I'm not quite clear if you want to discuss the checks further. For some of the range asserts, I think we should just file a new bug and address it separately in case this gets reverted. They're not a bad idea, but there's not a great reason IMHO to include them here where they were already absent.
I'd prefer to avoid the type checks in addToScene simply because that code path gets hit very frequently, including after the alpha has settled on whatever value the animation ends/stops/pauses at.

Gold has detected about 3 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/89264

Gold has detected about 5 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/89264

@flar - I'm not quite clear if you want to discuss the checks further. For some of the range asserts, I think we should just file a new bug and address it separately in case this gets reverted. They're not a bad idea, but there's not a great reason IMHO to include them here where they were already absent.

Handling that separately sounds good.

I'd prefer to avoid the type checks in addToScene simply because that code path gets hit very frequently, including after the alpha has settled on whatever value the animation ends/stops/pauses at.

None of that is a blocking comment, but I'm still not clear why you think that it is saving anything for frequently hit code. The code already has an as operator which is (A is B) ? A : throw and that has the same cost as (A is B ? A : null) with the language not requiring the as in that case.
(I'd love to see the language have an as? operator that was literally "or null" rather than "or throw".)

The performance concerns are really secondary. The real problem is that if you got all the way to addToScene with the wrong kind of engineLayer, you made a mistake along the way and potentially retained an entire layer tree (and any images it had) longer than necessary. Once you know the alpha is changing the layer should let the engine know to release resources.

Landing this on red because the scuba changes are expected.
@flar - happy to discuss further and see if we can continue to improve on this, but again my main concern is around not holding native resources any longer than absolutely necessary.


FBT001: exclude boolean operators

Fixes #14202
Summary
Exclude rule FBT001 for boolean operators.
Test Plan
Updated existing FBT.py test.

We have an is_known_dunder_method method that we could use for that.

@charliermarsh I updated using is_known_dunder_method (this required making crate::rules::flake8_boolean_trap::helpers public).
However, I am not sure if this is the best approach. For one, there is no official list of dunder methods from python's side, and what is considered a known dunder method can change from one version to the next.
Maybe a simpler approach would be to just exclude dunder methods in general? This would be easier to document/teach as well.

The is_known_dunder_method also contains __init__ and __new__, which are probably the two most important functions for FBT001 to check.

I think "all dunder methods except init and new" should be easy to maintain and explain.


HDDS-3985. Update proto.lock files.

What changes were proposed in this pull request?
update proto.lock files that were missed in HDDS-3807 and HDDS-3612
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3985
How was this patch tested?
No testing needed.

I wanted to ask this earlier on other PRs: what's the policy for updating proto.lock files?  Shouldn't we keep a version generated for "previous release" (ie. 0.5.0 currently)?  If they are always updated, how do they guarantee backwards compatibility?
CC @elek

I wanted to ask this earlier on other PRs: what's the policy for updating proto.lock files? Shouldn't we keep a version generated for "previous release" (ie. 0.5.0 currently)? If they are always updated, how do they guarantee backwards compatibility?

Agree, the original version should be kept. Unfortunately the maven plugin always refresh the lock files but we can ignore the proto files. I will create another PR to ignore lock files.

I propose to use #1224 instead of updating the lock files.

Thank You @adoroszlai for the question.
As these are optional fields, I think it will not break backward compatibility.
But I am also not completely sure when this file needs to be updated? (My main reason for adding this is, as @elek said it will generated new proto.lock file from current proto, and it adds those files during PR commit.)
@mukul1987 @avijayanhwx Can you help answer the above question of when this file needs to be updated.

proto.lock file represents and older state of the protobuf files. When build is executed the plugin compares the current *.proto files and the proto.lock files.
If we would like to be backward compatible with the previous release (in our case, it's 0.5.0) the proto.lock file should represent the 0.5.0 state. Therefore we shouldn't update it.
After the 0.6.0 release we can update all the proto.lock files (once!), which means during the build the master state will be compared with the 0.6.0.
As a thumb rule, proto.lock file should generated from the old proto which supposed to be backward compatible with the current proto files.

proto.lock file represents and older state of the protobuf files. When build is executed the plugin compares the current *.proto files and the proto.lock files.
If we would like to be backward compatible with the previous release (in our case, it's 0.5.0) the proto.lock file should represent the 0.5.0 state. Therefore we shouldn't update it.
After the 0.6.0 release we can update all the proto.lock files (once!), which means during the build the master state will be compared with the 0.6.0.
As a thumb rule, proto.lock file should generated from the old proto which supposed to be backward compatible with the current proto files.

Thank You @elek for your reply. I understood the process now. I agree with you, that before every release these proto.lock files should be updated at once.
I will close this PR, but it creates a problem of proto.lock files getting updated during the build. I think this needs to be solved, as this causes problem these files are also showing up during PR commit.

I will close this PR, but it creates a problem of proto.lock files getting updated during the build. I think this needs to be solved, as this causes problem these files are also showing up during PR commit.

Thanks @bharatviswa504.  This is being addressed in #1224.


what way is used for Tokenize the dataset?

Doc, say: All models are trained from the 1st 100M tokens
Can share some example how prepare that 100M tokens from the text input?, I'm trying to train support for ES lang.
Thanks

The tokenizer is included in the recasepunc.py script. It is a modified version of the BERT tokenizer which keeps punctuation when lower-casing. Example usage:
xzcat cc-100/$lang.txt.xz | python recasepunc.py --lang=$lang preprocess 100000000 > data/$lang-100M.txt


Use valid type hints for Python 3.9

I have no idea how this made it past the linters.

I am not sure why neither mypy nor the Python parser complain about it.
bayandin@mbp neon % poetry run python3 --version
Python 3.9.20
bayandin@mbp neon % poetry run mypy --python-version 3.9 test_runner/fixtures/pageserver/http.py
Success: no issues found in 1 source file

I had ruff check finding these issues, so I'm pretty confused, and I had rebased on main since my ruff changes PR went in.

Note that a stub file can sometimes make use of a typing feature before it is available at runtime, as long as the stub does not make use of new syntax. For example, a type checker will understand int | str in a stub as being a Union type annotation, even if the type checker is run using Python 3.9, despite the fact that the | operator can only be used to create union types at runtime on Python 3.10+. As such, Ruff will often recommend newer features in a stub file than it would for an equivalent runtime file with the same target version.

from https://docs.astral.sh/ruff/settings/#target-version

hmm, but these are not stub files.


Refactor elasticsearch scaler config

Refactor the scaler to match the new metadata guidelines.
Because i deleted const defaultUnsafeSsl = false in the elasticseach_scaler.go, kafka_scaler.go is giving error pkg/scalers/kafka_scaler.go:354:19: undefined: defaultUnsafeSsl. That's why I added the const in kafka_scaler.go.
Extra check if both username and password are provided when addresses is used (also test added).
Made a new splitWithSeparator function so the separator is configurable.
The documentation states that the field index is comma separated. In the code it is semicolon. There is a separate PR created in the keda-docs repo (1465).

Checklist

[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Tests have been added
[X] A PR is opened to update the documentation on (repo) (if applicable)
[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Related: 5797
Docs: 1465

Hi @wozniakjan
I've also refactored the Elasticsearch scaler to match the new metadata guidelines. This one needs a good look at the code 🙏
This because TypedConfig support slices, but only the elemSeparator accepts ",". So i added code so you can also slice on more separators like ";". For now I'm going on vacation 🌞 Any major changes due to feedback I'll do later. Many thanks in advance!

Looking good, could you please resolve the config? then we are good to merge this one. Thanks

Done :) Can you also run the run-e2e run for elasticsearch?

/run-e2e elastic*


Searchbox improvements

This PR is on the wrong branch, it's for review only.
Please merge #2197 first and I will re-create the PR on the correct branch
Summary
Linked to #2200

[x] Reset button
[x] Magnifier

Result

(Without instantsearch-algolia-theme.css)

(With instantsearch-algolia-theme.css)

Staging URL to see the SearchBox in action: http://obsequious-stomach.surge.sh/?selectedStory=SearchBox.default

We should be all good now @bobylito 👍


Nav item scroll with Slide?

Hi, this slide have option Nav_Item scroll with Slide like http://kenwheeler.github.io/slick/
with Slider Syncing feature?
I have many thumbnail image,i want the active thumbnail always show the first, what i have to do to get it?
My code: https://codepen.io/notrealdev/pen/dKdQNJ

You probably need 2 sliders: one for the slider itself, one for the thumbnails.
And then the two can share the same prev/next buttons to make them sync.

There are dragStart, dragMove and dragEnd events, although it's not in the document. (I will update this soon) So you can sync the index of the two sliders on dragEnd.


[SPARK-24681][SQL] Verify nested column names in Hive metastore

What changes were proposed in this pull request?
This pr added code to check if nested column names do not include ',', ':', and ';' because Hive metastore can't handle these characters in nested column names;
ref: https://github.com/apache/hive/blob/release-1.2.1/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java#L239
How was this patch tested?
Added tests in SQLQuerySuite.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/659/
Test PASSed.

Test build #92594 has started for PR 21711 at commit dbc300e.

Test build #92594 has finished for PR 21711 at commit dbc300e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92594/
Test PASSed.

@gatorsmile

@gatorsmile plz give me comments on this? Thanks.

Test build #93018 has started for PR 21711 at commit fa0233e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/964/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93019 has started for PR 21711 at commit 9fabeef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/965/
Test PASSed.

Test build #93020 has started for PR 21711 at commit 482a0c0.

Test build #93021 has started for PR 21711 at commit 37c9ce3.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/966/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/967/
Test PASSed.

Test build #93022 has started for PR 21711 at commit 424ecba.

Test build #93024 has started for PR 21711 at commit 8a6465b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/968/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93019 has finished for PR 21711 at commit 9fabeef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93019/
Test FAILed.

Test build #93018 has finished for PR 21711 at commit fa0233e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93018/
Test FAILed.

Test build #93022 has finished for PR 21711 at commit 424ecba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93022/
Test FAILed.

Test build #93025 has finished for PR 21711 at commit b298522.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93025/
Test FAILed.

Test build #93020 has finished for PR 21711 at commit 482a0c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93020/
Test PASSed.

Test build #93021 has finished for PR 21711 at commit 37c9ce3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93021/
Test PASSed.

Test build #93024 has finished for PR 21711 at commit 8a6465b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93024/
Test PASSed.

Test build #93079 has started for PR 21711 at commit bcdae88.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/992/
Test PASSed.

Test build #93079 has finished for PR 21711 at commit bcdae88.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93079/
Test FAILed.

It seems like Aveo errors, so I’ll trigger when it fixed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/994/
Test PASSed.

Test build #93082 has started for PR 21711 at commit bcdae88.

Test build #93082 has finished for PR 21711 at commit bcdae88.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93082/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1006/
Test PASSed.

Test build #93098 has started for PR 21711 at commit bcdae88.

Test build #93098 has finished for PR 21711 at commit bcdae88.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93098/
Test PASSed.

Thanks! Merged to master.


Add R2RML implementation

Adding r2rml implementation overhaul to API. This will serve as a starting base for this project.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f87112c). Click here to learn what that means.
The diff coverage is 89.21%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   89.21%
  Complexity        ?       74
=========================================
  Files             ?       10
  Lines             ?      204
  Branches          ?       21
=========================================
  Hits              ?      182
  Misses            ?       11
  Partials          ?       11

Impacted Files
Coverage Δ
Complexity Δ

...om/github/jiefenn8/graphloom/r2rml/TriplesMap.java
100% <100%> (ø)
9 <9> (?)

...om/exceptions/InvalidMappingDocumentException.java
100% <100%> (ø)
1 <1> (?)

.../com/github/jiefenn8/graphloom/r2rml/R2RMLMap.java
100% <100%> (ø)
3 <3> (?)

...jiefenn8/graphloom/configmap/ConfigMapFactory.java
50% <50%> (ø)
1 <1> (?)

.../graphloom/exceptions/base/GraphLoomException.java
50% <50%> (ø)
2 <2> (?)

.../github/jiefenn8/graphloom/io/MappingDocument.java
71.42% <71.42%> (ø)
3 <3> (?)

...b/jiefenn8/graphloom/r2rml/PredicateObjectMap.java
72.72% <72.72%> (ø)
5 <5> (?)

...a/com/github/jiefenn8/graphloom/mapper/Mapper.java
85.71% <85.71%> (ø)
9 <9> (?)

...m/github/jiefenn8/graphloom/r2rml/R2RMLParser.java
91.17% <91.17%> (ø)
15 <15> (?)

...ithub/jiefenn8/graphloom/r2rml/R2RMLValidator.java
96.55% <96.55%> (ø)
26 <26> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87112c...13f5190. Read the comment docs.


[DOCS] Make the frontend and backend setup into shell commands

Description
Currently in the link that directs us to setup the frontend and backend locally has a bunch of commands that require manual copying, I was thinking of making them into shell commands to copy them directly and ease the task of the contributor
Screenshots
No response
🥦 Browser
Google Chrome
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no)
[X] I am a GSSoC23 contributor (blank for no).

I would like to work on this issue under gssoc'23

Hey @karthiknadar1204 , can you please explain what do mean by making them into shell commands to copy them directly and ease the task of the contributor ?

Like right now the commands are like the one you have presented, I propose to turn them all into something like this

Instead of copying it manually using the cursor, I was thinking of making it easier by making them into the one in the above picture

Sounds good, you can go ahead with it !
Remember, Good PR makes you a Good contributor !
We at Milan work hard to maintain the structure, and use conventional Pull request titles and commits. Without a proper template for the PR, not following the guidelines and spam might get the pull request closed, or banned.

Please make sure that you have read our documentation on Commiting guidelines and Pull request guidelines.

Once you have done the changes you can request a review. If I suggest changes again, do those and request a review again.

Make sure you DO NOT modify the PR template that we have, use it as it is.

Last but not least, be patient. It takes a while to review the changes and get it merged.

Thank you


speedTestError: Error status code 500, errorMessage: INVALID_HTTP_RESPONSE

I am having the result sometimes and sometimes it's throwing the error of INVALID_HTTP_RESPONSE and Error status code 500. even my onDone callback never calling
An error occurs in the Android device.
continuously on startUploadTesting (onProgress) method call and throw this error.
In startDownloadTesting it's working fine only Android, not in IOS
I/flutter ( 6394): arguments are {id: 1, percent: 0.0, transferRate: 0.0, type: 1, speedTestError: Error status code 500, errorMessage: INVALID_HTTP_RESPONSE}
I/flutter ( 6394): callbacks are {1: [Closure: (String, String) => Null, Closure: (double, double, SpeedUnit) => Null, Closure: (double, SpeedUnit) => Null]}

Also having the same issue, any updates? @Sheetal-25 @TahaMalas @aks3800


How about batch requests?

Hello! Is there a way to use power of batch requests with fb_graph?
Thank you for awesome gem!

No, this gem don't support batch requests.

I would like to try add batches support to this gem. I just use this gem a lot in my current project and I think it is a perfect place where this functional should be :)

let me close this unactive issue.


FFI failure due to Headers() not existing

Ran a pretty basic example
module Main where

import Prelude
import Effect (Effect)
import Effect.Aff (launchAff_)
import Effect.Class (liftEffect)
import Effect.Console (log)
import Fetch (fetch)

main :: Effect Unit
main =
  launchAff_ do
    { status, text } <-
      fetch "https://httpbin.org/get"
        { headers: { "Content-Type": "applications/json" } }
    responsText <- text
    liftEffect do
      log responsText

and got this error
ReferenceError: Headers is not defined
    at Module.unsafeNew (file:///home/gavinok/.local/Dropbox/Programming/purescript/real-fetch/output/Fetch.Core.Headers/foreign.js:2:3)
    at __do (file:///home/gavinok/.local/Dropbox/Programming/purescript/real-fetch/output/Fetch.Core.Headers/index.js:25:33)
    at Module.unsafePerformEffect (file:///home/gavinok/.local/Dropbox/Programming/purescript/real-fetch/output/Effect.Unsafe/foreign.js:2:10)
    at file:///home/gavinok/.local/Dropbox/Programming/purescript/real-fetch/output/Fetch.Core.Headers/index.js:24:30
    at file:///home/gavinok/.local/Dropbox/Programming/purescript/real-fetch/output/Fetch.Core.Headers/index.js:37:70
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:533:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)
[error] Running failed; exit code: 1

My mistake didn't run the the experimental fetch setting


Remove unused Symbol type

The Symbol type is unused. Remove it.
Signed-off-by: Daniel Müller<EMAIL_ADDRESS>

LGTM!  Thanks!


Pass through when input image exceeds pixel limit?

I'm working with sharp using streams and was wondering if there is a good way to resize an image if its number of pixels is below the number specified in the limitInputPixels option but pass through otherwise?
Currently, when the number of pixels of the image is above limitInputPixels, sharp seems to error and end the stream.
For example, something like the following, but where the image is piped through to destination even if its number of pixels exceeds the limitInputPixels:
const resizer = sharp({failOnError: false, limitInputPixels: someLimit}).resize(someWidth);
imageReadable.pipe(resizer).pipe(destination);

Hi, you'll need to add this logic yourself, perhaps by converting the Stream to a Buffer via https://www.npmjs.com/package/get-stream

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


Too large margins around contact icons in the message list

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.310
Problem you are trying to solve
Compared to other clients, the margin around the contact icon in the message list is too large. It's a waste of space at the expense of the message preview.
K-9

BlueMail

Suggested solution
Reduce the icon margin.
Screenshots / Drawings / Technical details
No response

This was done intentionally so the subject and sender name align with the toolbar title. See https://m2.material.io/design/layout/spacing-methods.html#spacing
We're not optimizing layouts to put as much text as possible on the screen. But if you want to make more room for text, you could disable the contact pictures in settings.

More work on the message list design is planned (see e.g. #4110). However, it's currently not a priority.


picture

If there are pictures in Excel, how to convert them into Entity or List.

Does not support for now, what type do want get image as? byte[] or Stream or other type?

byte[]

Ok, thanks for the info, I'll try to implement this at my best as soon as possible

If completed, please reply me here，thank you

Ok, will do

A new preview release(WeihanLi.Npoi 1.15.0-preview-20210228-054739) had been published to nuget, you can try this https://www.nuget.org/packages/WeihanLi.Npoi/1.15.0-preview-20210228-054739

ok，thanks

I tried it and found no problem

Ok, great thanks for your feedback, will publish stable release later

fixed by #103 , please use 1.15.0


[JAV-566] report type/version when register to SC

SDK report their framework type and version when register to SC
Each service with specific version has a certain framework+version
Present the type/version information in console in Service+Version level
In gov service, send the different command to CC according to the type/version when doing management

Coverage decreased (-0.06%) to 86.713% when pulling b3f92ff1be9cae731826b4712227253e71f54d0a on weichao666:JAV566CSE769 into aaaceec4b4af96200309960cf3ed69885933f233 on ServiceComb:master.

we have servicecomb and cse version, which one  will  we report


⚠ Bofrost.de has degraded performance

In e0f21c0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1143 ms

Resolved: Bofrost.de performance has improved in 6743b43 after 6 minutes.


ubuntu arm64,  cannot allocate memory in static TLS block

On Ubuntu bionic on arm64 I have got the following error on latest version of PyAV:
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import av._core
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import av
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/me/PyAV/av/__init__.py", line 9, in <module>
    from av._core import time_base, pyav_version as __version__
ImportError: /usr/lib/aarch64-linux-gnu/libgomp.so.1: cannot allocate memory in static TLS block

$ uname -a
Linux alarm 4.19.25-sunxi64 #5.78 SMP Mon Apr 8 07:19:19 CEST 2019 aarch64 aarch64 aarch64 GNU/Linux

I have recompiled all the libraries from source and now it works.
But the default installation way "pip3 install" don't work on Ubuntu/arm64.

Unfortunately this doesn't look like a problem with pyav itself, but more like a problem at the distribution level or in ffmpeg itself..

I have the same issue with pip3 install, will try to compile from source and see...

OK in that case I'm going to close this issue.


Reformatting MainView widget :art:

Just a test whether the checks are working, thus merging with Admin privileges.


Panel Version
1.0.0-beta7
Wings Version
1.0.0-beta3
Service
discord/redbot
Modified
No, I did not modify the egg
Expected Behavior
Install the server and be able to use it
Actual Behavior
The following error occurs during startup
/entrypoint.sh: eval: line 13: syntax error near unexpected token newline' /entrypoint.sh: eval: line 13: PATH=$PATH:/home/container/.local/bin redbot pterodactyl --token "DISCORDTOKEN" --prefix >'
Steps To Reproduce
Install the server, config Discord Token, prefix, and owner. Try and start the server
Install logs
https://ptero.co/wakaqehemu

there part of the install logs missing please run tail -n 5000 $(ls -Alrt /var/log/pterodactyl/install/*.log | tail -1 | sed 's/  */ /g' | cut -s -d' ' -f9) | nc pteropaste.com 99

I just tried this and it works just fine for me, please come to the discord to resolve this.


add install to the resources and plugin.xml

Bug fix
Fixed bug

I fixed the bug which was reported in this issue #2147
I forget to add install resource dir in lgsvl_simulator_bridge package.
So, colcon could not find rqt_lgsvl_configurator UI file.
Fix applied

I add install line to the resource dir to the CMakeLists.txt in this package.
After this PR was merged, when user clicks LGSVL Simulator button in simulation tab, the configurator UI appears.

Cross build failed in the CI due to the missing ymc binary, but the normal build worked so I will merge this.


[Bug] Support Minecraft version is error

On modrinth, the mod displays the following information

But under this file fabric.mod.json
{
  "depends": {
      "minecraft":"1.17.1"
  }
}

https://github.com/Ecorous/NoMoreScore/blob/main/src/main/resources/fabric.mod.json#L31

Related information: Crash-Report from Quilt（About remove this tag）
Before and After

I just want to say: Are you kidding me?

The "After" link is a multiconnect error, but I will fix the fabric.mod.json and reupload later today

I forgot, am fixing now

I'll push out a new release now.

Not have automatic build?

Not have automatic build?

Do you mean github actions artifacts, or cf/mr auto uploading? I haven't gotten round to either. I can do it at some point though

I only just got round to updating curse, sorry. It's fixed now


Enchants can't be added

You can't take a book and put it on the horseshoe in survival. I tested it in creative to see if the enchantment still works if you force it on and it does. 1.21

Fixed in latest release.


Custom id column not working

In Laravel Migrations, $table->id() always creates a column of type BIGINT(20). I am trying to use a custom numeric data type using following code in migrations.
$table->mediumInteger("id", true, true);
When using this package, it always creates a column of BIGINT datatype though the size is different e.g. BIGINT(8). I have tried other numeric data types like smallInteger, integer but they do not work.
I also tested in Laravel (without) this package and it works the way it suppose to.
Am I missing something?

I just tested this and it seems to work? Maybe I am misunderstanding your issue/question. See this test for an example: https://github.com/singlestore-labs/singlestoredb-laravel-driver/pull/42/files#diff-f6da6c22d5e74ab81179bda2693633c2fb36619a61c3d97f857875f906c8fa1bR67


Cleaning up collaborator api

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Fixes #81
What's this PR do?

Moves data mutations into WebsiteCollaboratorSerializer
Simplified WebsiteCollaboratorViewSet.get_queryset down to a single query definition
Removed update / create methods on WebsiteCollaboratorViewSet which were now unnecessary
Simplified validation in WebsiteCollaboratorSerializer to lean on DRF as much as possible
Moved permissions_group_name_for_role into a new website/utils.py to avoid circular imports
Removed group from WebsiteCollaboratorSerializer since it's unused and is a backend detail that the frontend doesn't need to know about

How should this be manually tested?
Go to the collaborators UI and verify you can view/add/edit/delete editors and administrators.

Codecov Report

Merging #202 (ddc57a3) into master (ad6cfcf) will decrease coverage by 5.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   86.37%   81.21%   -5.17%
==========================================
  Files          99       45      -54
  Lines        2510     1304    -1206
  Branches      397      139     -258
==========================================
- Hits         2168     1059    -1109
+ Misses        324      228      -96
+ Partials       18       17       -1

Impacted Files
Coverage Δ

websites/constants.py
100.00% <100.00%> (ø)

websites/models.py
86.15% <100.00%> (+0.21%)
:arrow_up:

websites/permissions.py
91.15% <100.00%> (-0.23%)
:arrow_down:

websites/serializers.py
100.00% <100.00%> (ø)

websites/utils.py
100.00% <100.00%> (ø)

websites/views.py
100.00% <100.00%> (+1.53%)
:arrow_up:

main/serializers.py
0.00% <0.00%> (-100.00%)
:arrow_down:

static/js/query-configs/utils.ts

static/js/components/SiteSidebar.tsx

static/js/lib/urls.ts

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6cfcf...ddc57a3. Read the comment docs.

Still reviewing the code & functionality right now, but one question/suggestion in the meantime you can take or leave: What do you think about splitting the collaborator view tests from websites/views_test.py to a separate file (collaborator_views_test.py et al)? That views_test.py file is pretty big, and I expect it will only get bigger. Separating the collaborator tests from the tests for API views that just deal with Website/WebsiteContent data might be helpful

Could we do that in a separate PR? I think splitting up the views themselves (and the tests along with them) is a good goal but that definitely explodes the scope of this work.


Make nuget package more compatible

Changes suggested:
Change target framework to .NET 4.5
Update Hangfire.Mongo.nuspec to align to nuget standard folder structure.
Update to latest MongoDB.Driver (2.2.3)
Im not an expert in multiple nuget targets, so i didnt add multiple build configurations for the latest frameworks. Im thinking targeting 4.5 should suffice for now.

@gottscj thanks for contribution


Load Reordering

This PR refactors buffered memory reads from the manycore to handle response reordering.

@max-ruttenberg Can you approve this?


How to get /etc/sensors/imx415.bin

Good morning! The given configuration sample matches a SigmaStar SSC338Q+IMX415 camera module. HiSilicon chips still need this sensor_config parameter filled, but instead needs a .ini file located under /etc/sensor/config that provides interface and signal processing details instead of a calibration.

Thank you for your reply. I can modify divinus.yaml to point to /etc/sensor/config/imx415_i2c.ini


Version check functionality

WIP DO NOT MERGE

Should this be closed in favor of #368 ?

Closed in favor of https://github.com/deeplearning4j/DataVec/pull/369


This is a fix to get stable_txt2img working on an M1 Mac.

Install Stable Diffusion as per https://medium.com/gft-engineering/macbook-m1-how-to-install-and-run-stable-diffusion-7bfb2f802b1a
Install PyTorch by running :
conda install pytorch torchvision torchaudio -c pytorch-nightly

Running with more than one sample seems to break it so I'm just running multiple itterations to get the regularization images:
python scripts/stable_txt2img.py --ddim_eta 0.0 --n_samples 1 --n_iter 200 --scale 10.0 --ddim_steps 50 --ckpt ~/Downloads/sd-v1-4-full-ema.ckpt --prompt "a photo of a <class>

How long is it taking you to train the models this way?

I can't get this repo (not the lstein one mentionned by OP) to train on M1.
I was able to patch my way out until i didn't get any visible errors, but inevitably got stuck on training never progressing (epoch 0)

@swankwc I haven't gotten to training yet.  ATM his patch is just forstable_txt2img.py which took 1484.16s user 6134.54s system 24% cpu 8:30:55.51 total.
I'm having problems getting main.py to run.  Even if I comment out all the CUDA code, and change the Trainer to MPS I'm still getting a CUDA error in trainer.fit
Traceback (most recent call last):
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/main.py", line 836, in <module>
    trainer.fit(model, data)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 770, in fit
    self._call_and_handle_interrupt(
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 723, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 811, in _fit_impl
    results = self._run(model, ckpt_path=self.ckpt_path)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1236, in _run
    results = self._run_stage()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1323, in _run_stage
    return self._run_train()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1345, in _run_train
    self._run_sanity_check()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1413, in _run_sanity_check
    val_loop.run()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 155, in advance
    dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 128, in advance
    output = self._evaluation_step(**kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 226, in _evaluation_step
    output = self.trainer._call_strategy_hook("validation_step", *kwargs.values())
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1765, in _call_strategy_hook
    output = fn(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 344, in validation_step
    return self.model.validation_step(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 368, in validation_step
    _, loss_dict_no_ema = self.shared_step(batch)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 908, in shared_step
    loss = self(x, c)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 937, in forward
    c = self.get_learned_conditioning(c)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 595, in get_learned_conditioning
    c = self.cond_stage_model.encode(c, embedding_manager=self.embedding_manager)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 324, in encode
    return self(text, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 318, in forward
    tokens = batch_encoding["input_ids"].to(self.device)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/cuda/__init__.py", line 221, in _lazy_init
    raise AssertionError("Torch not compiled with CUDA enabled")

I can keep using this PR to track that work or open a new one.  Opinions?

@Sorrow do you have your work somewhere? You seem to have gotten further than me. Maybe we can collaborate.

Renamed PR explain scope of work better.

@beettlle, I've been able to get it up and running on my Macbook Pro with some modifications using your code. It's linked here if you'd like to take a look: https://github.com/SujeethJinesh/DreamBoothMac

That's awesome @SujeethJinesh !  Let me reset my env and I'll try it tomorrow.

@SujeethJinesh I'm still getting the following error with your branch. Any ideas?
% python main.py --base configs/stable-diffusion/v1-finetune_unfrozen.yaml -t --actual_resume ~/Downloads/sd-v1-4-full-ema.ckpt -n ramona --gpus 0, --data_root ~/Downloads/ramona --reg_data_root outputs/txt2img-samples --class_word ramona
<gobs and gobs of stuff>
Traceback (most recent call last):
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/main.py", line 806, in <module>
    trainer.fit(model, data)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 770, in fit
    self._call_and_handle_interrupt(
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 723, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 811, in _fit_impl
    results = self._run(model, ckpt_path=self.ckpt_path)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1236, in _run
    results = self._run_stage()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1323, in _run_stage
    return self._run_train()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1345, in _run_train
    self._run_sanity_check()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1413, in _run_sanity_check
    val_loop.run()
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 155, in advance
    dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 128, in advance
    output = self._evaluation_step(**kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 226, in _evaluation_step
    output = self.trainer._call_strategy_hook("validation_step", *kwargs.values())
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1765, in _call_strategy_hook
    output = fn(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 344, in validation_step
    return self.model.validation_step(*args, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 368, in validation_step
    _, loss_dict_no_ema = self.shared_step(batch)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 908, in shared_step
    loss = self(x, c)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 937, in forward
    c = self.get_learned_conditioning(c)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 595, in get_learned_conditioning
    c = self.cond_stage_model.encode(c, embedding_manager=self.embedding_manager)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 324, in encode
    return self(text, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 319, in forward
    z = self.transformer(input_ids=tokens, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 297, in transformer_forward
    return self.text_model(
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 258, in text_encoder_forward
    hidden_states = self.embeddings(input_ids=input_ids, position_ids=position_ids, embedding_manager=embedding_manager)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/Documents/github/Dreambooth-Stable-Diffusion/ldm/modules/encoders/modules.py", line 180, in embedding_forward
    inputs_embeds = self.token_embedding(input_ids)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/modules/sparse.py", line 160, in forward
    return F.embedding(
  File "/Users/cdelgado/miniforge3/envs/ldm/lib/python3.10/site-packages/torch/nn/functional.py", line 2206, in embedding
    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: Placeholder storage has not been allocated on MPS device!

I tried running @SujeethJinesh 's repo and got the same error as you @HannesGitH . Some additional things I was to install the following
conda install pytorch torchvision torchaudio -c pytorch-nightly
conda install chardet

My latest attempt to fix was to perform the cast as follows
class DDIMSampler(object):
    def __init__(self, model, schedule="linear", **kwargs):
        super().__init__()
        self.model = model
        self.ddpm_num_timesteps = model.num_timesteps
        self.schedule = schedule

    def register_buffer(self, name, attr):
        if type(attr) == torch.Tensor:
            if attr.device != torch.device("mps"):
                attr = attr.to(torch.device("mps"), torch.float32)
        setattr(self, name, attr)

but that gave me this error
AppleInternal/Library/BuildRoots/c651a45f-806e-11ed-a221-7ef33c48bc85/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShaders/MPSCore/Types/MPSNDArray.mm:705: failed assertion `[MPSTemporaryNDArray initWithDevice:descriptor:] Error: product of dimension sizes > 2**31'               | 0/5 [00:00<?, ?it/s]
[1]    1493 abort      python scripts/stable_txt2img.py --ddim_eta 0.0 --n_samples 2 --n_iter 1  10.
/Users/jose-rs/anaconda3/envs/ldm-mac/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown

@SujeethJinesh open a PR https://github.com/SujeethJinesh/DreamBoothMac/pull/3 to fix the float64 error.
I was able to get around the error
AppleInternal/Library/BuildRoots/c651a45f-806e-11ed-a221-7ef33c48bc85/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShaders/MPSCore/Types/MPSNDArray.mm:705: failed assertion `[MPSTemporaryNDArray initWithDevice:descriptor:] Error: product of dimension sizes > 2**31'               | 0/5 [00:00<?, ?it/s]
[1]    1493 abort      python scripts/stable_txt2img.py --ddim_eta 0.0 --n_samples 2 --n_iter 1  10.
/Users/jose-rs/anaconda3/envs/ldm-mac/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown

I changed the size of the image to 256 x 256 that did the trick. It unblocks me for now, but it would be good to figure out a better solution. I will try to fix later.

In my latest attempt I tried to perform training
 python main.py --base configs/stable-diffusion/v1-finetune_unfrozen.yaml  -t --actual_resume ~/Downloads/sd-v1-4-full-ema.ckpt -n hello_world --gpus 0, --data_root ~/Downloads/couch_images --reg_data_root ~/Downloads/other_images/ --class_word couch_trainversion_314

I get the following error
pytorch_lightning.utilities.exceptions.MisconfigurationException: You passed `devices=1` but haven't specified `accelerator=('auto'|'tpu'|'gpu'|'ipu'|'cpu')` for the devices mapping, got `accelerator='mps'`.

My best guess is that the pytorch lighting version specified (1.5.9) does have this feature
https://lightning.ai/docs/pytorch/stable/accelerators/mps_basic.html
@SujeethJinesh how did you get this work?

@alberto-salinas would you mind trying the following from 's site in your environment to see if MPS is supported?
import torch
if torch.backends.mps.is_available():
    mps_device = torch.device("mps")
    x = torch.ones(1, device=mps_device)
    print (x)
else:
    print ("MPS device not found.")


API V2 go-live todos

Derived from diff of https://github.com/GaloyMoney/galoy/blob/graphql-schema-plan/src/schemaV2.graphql and https://github.com/GaloyMoney/galoy/blob/main/src/graphql/main/schema.graphql
Queries:
globals
nodesIds -> lightningNodePubkeys
Resolver needed

walletNameAvailable
resolver needed + boilerplate

onChainTxFee
everything needed
Needs reconsidering

mutations
 onChainAddressCreate: OnChainAddressPayload! # always a mutation
  onChainAddressCurrent: OnChainAddressPayload! # mutation first time it's issued, then query
  onChainPaymentSend(input: OnChainPaymentInput!): PaymentStatusPayload!
  onChainPaymentSendAll(input: OnChainPaymentAllInput!): PaymentStatusPayload!
   intraLedgerPaymentSend(input: UserPaymentInput!): PaymentStatusPayload!

mobile only mutation

deviceNotificationTokenCreate

mobile only queries (can be skipped for potential announcement)

mobileVersions

businessMapMarkers
Partially done (some boilerplate)

btcUsdPriceListForGraph
boilerplate + resolver needed

quizQuestions
open design questions
boilerplate + resolver done

See https://github.com/GaloyMoney/galoy/projects