Convert langString to string

Thanks to @aliokan for providing this query.
It converts all strings tagged as a langString to a regular string. langStrings are not a conventional way to store strings, especially not when there is no language attached to it.

The intention is to have eventual consistency. As new decisions are harvested, old data with broken language tags are removed as new and correct data replaces it. This query will only have affect on dump files. If those dump files are used to replicate the state of harvested decisions, then these corrections happen at once.

I approved. Thanks for your explanation :pray:


The example "rendering Markdown using pulldown-cmark and ammonia" does not compile

The "rendering Markdown using pulldown-cmark and ammonia" example on https://maud.lambda.xyz/render-trait.html does not compile. I am not sure about the specific reason why it doesn't work but I guess one would have to write! to the buffer instead of returning PreEscaped(safe_html) the signature of the function of the  Render trait has changed?
I guess it should be something like
impl<T: AsRef<str>> Render for Markdown<T> {
    fn render(&self) -> Markup {
        // Generate raw HTML
        let mut unsafe_html = String::new();
        let parser = Parser::new(self.0.as_ref());
        html::push_html(&mut unsafe_html, parser);
        // Sanitize it with ammonia
        let safe_html = ammonia::clean(&unsafe_html);
        PreEscaped(safe_html)
    }
}

Thanks for reporting!
Yeah, that looks like a simple typo. I'll fix.

Thanks for reporting!
Yeah, that looks like a simple typo. I'll fix.


Installation of Operator with BPF Dataplane Crashes Due to API Server Resolution Failure

Expected Behavior
Installing the Tigera operator on a fresh EKS cluster with AWS VPC CNI Networking, the BPF data plane enabled and kube-proxy disabled is able to connect to the Kubernetes API Server using a domain name and run successfully.
Current Behavior
The operator gets stuck in a crash loop due to DNS lookup timeouts. The DNS lookup is attempting to use CoreDNS, which is not yet running as the AWS VPC CNI pod is not running. The AWS VPC CNI pod is not running because it cannot connect to the API server without kube-proxy or calico running. The operator should be able to connect to the API server using a domain name without CoreDNS as per the docs - https://projectcalico.docs.tigera.io/maintenance/ebpf/enabling-bpf#configure-calico-to-talk-directly-to-the-api-server
Steps to Reproduce (for bugs)

Create an EKS cluster on Kubernetes 1.21 with the default AWS VPC CNI networking enabled. Do not scale out any nodes.

Apply the Tigera Operator to the cluster, including CRDs so the Installation resource will get created successfully:

helm template calico projectcalico/tigera-operator --include-crds --values=helm-values.yml > all.yml
kubectl apply -f all.yml

My helm-values.yml file looks like:
installation:
  kubernetesProvider: "EKS"
  calicoNetwork:
    linuxDataplane: "BPF"
    hostPorts: null

Disable kube-proxy as per the instructions in https://projectcalico.docs.tigera.io/maintenance/ebpf/enabling-bpf. Setup the kubernetes-services-endpoint configmap with the EKS API server endpoint. This can be pulled using kubectl get configmap -n kube-system kube-proxy -o yaml | grep server.

Scale up one node for the operator to run on.

Context
When the operator comes up, it attempts to connect to the EKS API server endpoint, which needs to use DNS. The operator is running with the ClusterFirstWithHostNet DNS policy, so it tries to resolve this using cluster DNS. Because cluster DNS isn't running, this fails, and the operator degrades to a crash loop.
Your Environment
EKS using Kubernetes 1.21 with AWS VPC CNI networking

This might just be a helm chart issue which is not in this repository. Could you try manually changing the dns policy for operator and see if one will work? (You should be able to do that by editing the tigera-operator deployment.)
If this is just a helm chart issue, then dnsPolicy might need to be exposed in which case an issue on projectcalico/calico should be created as that is the source of the helm chart.
If it doesn't work to change the dnsPolicy then I'm not sure what solution will be.

@shelby-moore as @tmjd says this should be resolved by switching the Tigera Operator dnsPolicy.
If you need something simpler than a manual change I have an alternative Tigera Operator chart that already supports setting hostNetwork & dnsPolicy; although these appear to currently be missing from the documentation they are in values.yaml.

Switching the dnsPolicy to Default appears to be working, the AWS EKS endpoint resolves. Yay! Using the endpoint for the proxy I have running in front of the API doesn't, which is odd. However, the error is that the certificate is signed by an unknown authority, so it's no longer within the scope of this issue.


Display Html data from disqus to jquery-comments

I am trying to display html data in the comments. Issue is it shows me html in text format with  and other tags etc. How can i avoid this.  Sample string is given bellow.

Ramdas and Shivaji's perception of \"Bhavāni incarnate as India\" and Sri Aurobindo's patriotic expression in his  100 verse sanskrit poem Bhavāni Bharati is very significant:

http://surasa.net/aurobindo/bh...

Also the revolutionary blueprint and programme to free India by an order of Bhakts and Karamyogis was called by Sri Aurobindo as Bhavāni Mandir:

http://www.searchforlight.org/...

You can remove any and all HTML tags quite easily with JavaScript prior to passing them on the library. See for example: https://stackoverflow.com/questions/822452/strip-html-from-text-javascript


Changed stack resolver to work with Ubuntu

Stack uses the lts-6.20 resolver, and thus, hint-5.2.0.
Testing has proven no issues.

Thanks!


Enable quoting of all identifiers by default

@FroMage  what wou you think of this approach? cc/ @gsmet
On the upside it will consistently create/update the table names...
but I don't think you'll be able to use the import.sql as easily anymore; maybe that's ok and we switch to the Flyway approach :)
Writing SQL directly in the DB also becomes a bit messy, you'll have to be identifiers consistently.
DO NOT MERGE

It's a PR in your own repo, you can merge it if you want ;)
So what does that mean for import.sql then?
I won't be able to insert into foo … if I have @Entity class Foo {}?

So my position on this one is that it should work with the default settings.
From what I see in the original issue, it seems to be really the default behavior not working. I'm pretty sure it used to work back in the time because I used update all the time with my H2/PostgreSQL databases in the past.

It's a PR in your own repo, you can merge it if you want ;)
So what does that mean for import.sql then?
I won't be able to insert into foo … if I have @Entity class Foo {}?

That's right, you'd have to use insert into Foo, except that you'll have to quote "Foo" otherwise psql will downcase it first and then complain the table foo doesn't exist (as the physical name is Foo).
When trying an import.sql with this syntax it did reject the script though, haven't figured why yet but I guess such escaping is not supported.
@gsmet

So my position on this one is that it should work with the default settings.

Well we can agree on the ideal :)  but we need to decide how to do that in practice, as each option I can think of will backfire on some other area.
My personal experience has always been fine with this as well, but I suspect in my case this is caused as I'd regularly use my own custom naming strategies as I always needed 100% control on the schema output.

Yes, it not only used to work, but also drop-and-create manages to drop the right tables, while update does not update the right ones, so it's really a Hibernate bug IMO. But regardless I agree we should fix it here to have a quick fix.
I'm not sure the strategy to use quoting is the right way to fix this, though, because it makes even using psql harder, no?
Do note that at least another user reported this not working with H2 in https://github.com/quarkusio/quarkus/issues/1886 so it's not just postgres.

What does @emmanuelbernard think?

Agreed. I think we really need to understand the root of the issue.

You can't have the old style back so let's look ahead. Rather than keep repeating "fix the bug" tell me how you think this is supposed to work ;)

So it appears that H2 will upper-case everything that is not quoted. While PG will lowercase everything non-quoted and even quoted things if they don't contain any uppercase letters. I think requiring users to quote their table names when interacting with the DB is the nuclear option to catch a fly. Especially because Java guidelines mean that every table name will be CamelCased, so quoting will be required by any manual DB interaction.
I don't see the naming strategy listed as options in quarkus-hibernate-orm so I can't test them.
All else on the side, do you think fixing update would be hard or impossible? Without talking about delays.

It's a non trivial problem as the databases just don't deal with naming consistently and there's not much we can do about that; but I think we can fix it or at least push some reasonable default naming strategy depending on the dialect.
But we need to agree on what strategy exactly...
FYI in the ORM core team the consensus has been that the status quo is as good as it can get: people really are expected to be precise with their naming and plugging a user custom strategy is very common, and is the least surprising option as they will have made an explicit choice.
But you're advocating an approach of "users shouldn't be bothered at all" .. wich has my sympathies but we've not been able to achieve that so far.

I think requiring users to quote their table names when interacting with the DB is the nuclear option to catch a fly.

Well it has some more benefits; just try having an entity called "User" and see... :-(
But sure it's nuclear as it makes all other tools more annoying to use; would be great if all tools used quoting by default.
So "quoting enabled by default" is totally unreasonable in ORM upstream as it would break existing applications, but it's something we could consider for Quarkus given the focus on greenfield apps.

So this is how it would look like, if we were to apply the change in this PR:

https://github.com/quarkusio/quarkus-quickstarts/commit/de3e48fffba94d830a2753aa406ca1a8573b166d

Not too bad?

What I fail to understand is that I used PostgreSQL with update for years without any issue.
Did you reproduce it with PostgreSQL? I see the OP uses H2. For H2, I think we dropped the schema so I don't have any data for it.
I don't have the time right now to check it out, please don't rush it.

@gsmet sure in fact I'm working with PostgreSQL only.


make it more clear to save password on initial setup screen

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #support.

Fixed, branch: zach/316/walkthrough-password-fix


validate question

Hello :
Sorry first, my engilsh isn't very good.
I need to validate a lot of card types.
var card = {
cardType: 'VISA',
number: '4111111111111111',
expiryMonth: '03',
expiryYear: '2100',
cvv: '123'
};
var validation = CreditCard.validate(card);
When card type is Visa Delta or Visa Electron or Visa Debit, Can I use CreditCard.validate(card) by cardType: 'VISA' to get correct result ? thank you a lot.

According to http://support.worldpay.com/support/kb/bg/testandgolive/tgl5103.html, Visa debit and electron numbers start with a 4, so they should be fine.


Add .getmdl-select__fullwidth and .getmdl-select__fix-height classes

Update the CSS of mdl-select according to https://github.com/CreativeIT/getmdl-select/blob/master/src/scss/getmdl-select.scss so that the element can automatically adapt to the maximum height and/or the maximum width of values.

Hey, thanks. I'll give it a look

I changed the class names to meet BEM standards and fixed one of the rules


zsh: killed  ./nomore403

always in PATH CASE SWITCHING I got
zsh: killed     ./nomore403
how I can solve this

Can you check with the latest version? Thanks.


Incorrect date when using .when with weekdays

hello! :wave:
There appears to be an issue with maya.when() when using weekday names.
>>> today = maya.now()
>>> print(today)
'Sun, 15 Apr 2018 16:58:03 GMT'

>>> tomorrow = maya.when("monday", prefer_past=False)
>>> print(tomorrow)
'Mon, 09 Apr 2018 00:00:00 GMT'

dateparser seems to handle this correctly, but only when the setting 'PREFER_DATES_FROM' is set to 'future'.
>>> dateparser.parse("monday")
datetime.datetime(2018, 4, 9, 0, 0)

>>> dateparser.parse("monday", settings={"PREFER_DATES_FROM": "future"})
datetime.datetime(2018, 4, 16, 0, 0)

>>> dateparser.parse("Apr 16")
datetime.datetime(2018, 4, 16, 0, 0)

>>> dateparser.parse("Apr 16", settings={"PREFER_DATES_FROM": "past"})
datetime.datetime(2017, 4, 16, 0, 0)

The default setting for dateparser appears to be "current_period" from dateparser/dateparser_data/settings.py.
As the only way to alter the 'PREFER_DATES_FROM' setting is change prefer_past, there is currently no way to get the future day in this instance.
I'll open a PR with a failing test.

Hi! Thanks for contribution!

I'll open a PR with a failing test.

Great! :tada:
@kennethreitz what about exposing the PREFER_DATES_FROM setting from dateparser via the maya.when() API?
Something like:
maya.when('monday', prefer_dates_from='past')

@timofurrer  I had thought:
-def when(string, timezone='UTC', prefer_past=False):
+def when(string, timezone='UTC', prefer_past=None):

-    if prefer_past:
+    if prefer_past is False:
+        settings['PREFER_DATES_FROM'] = 'future'
+    if prefer_past is True:
         settings['PREFER_DATES_FROM'] = 'past'

     dt = dateparser.parse(string, settings=settings)

This should allow all three of dateparsers options of 'current_period', 'future', and 'past'.

Sounds even better!
I'm looking forward to accept the change in the PR you've already made ;)

I might have second thought about the proposed API.
The thing is, that for me, setting prefer_past=False doesn't intuitively mean that it should prefer the future. It would just mean that not the past should be preferred and therefore the current_period is used. Which isn't the case.
Having both arguments prefer_past and prefer_future available leads to inconsistencies and therefore not really an option. Which leads us to prefer_dates_from= argument. I know it's kinda verbose but the best I can come up with right now. And thoughts?

I agree.
My thoughts behind keeping prefer_past was that it's a non breaking change.
I think because prefer_dates_from is more verbose, it might be nicer.
-def when(string, timezone='UTC', prefer_past=False):
+def when(string, timezone='UTC', prefer_dates_from='current_period'):

    settings = {
         'TIMEZONE': timezone,
         'RETURN_AS_TIMEZONE_AWARE': True,
         'TO_TIMEZONE': 'UTC',
+        'PREFER_DATES_FROM': prefer_dates_from,
     }
-    if prefer_past:
-        settings['PREFER_DATES_FROM'] = 'past'
+
     dt = dateparser.parse(string, settings=settings)
     if dt is None:
         raise ValueError('invalid datetime input specified.')

Let me know and I can push up some changes ✨

Yes, let's do that! @kennethreitz any thoughts on that one?

Done in #147


Send multipart email to improve formatting

Slack desktop client doesn't make links clickable and
doesn't use fixed width font.
To fix that, we send HTML and plain text. HTML is generated
via markdown.
Issue: https://progress.opensuse.org/issues/111215
Screenshot:

Depends on #165

Added not-ready label because I need to wait until os-autoinst-scripts-deps is updated after #165 was merged

@Mergifyio rebase

@pdostal  It is already deployed :)


Z-index for WordPress

Hi Jan,
Would it be an issue if the --lity-z-index-base could be upped to 99999 so that the light box close button does not get obscured by the admin bar when the default script and stylesheet are included in a WordPress theme?
It's obviously not a big issue but would make things a bit easier, specially when using the stylesheet hosted on CDNJS for example.
BTW, there does not seem to be a WordPress plugin with this fantastic light box yet. I can create one if you're not opposed to the idea :)

@RavanH I'm with you here. I can't think of a reason to up the value to 99999.


Small formatting changes to meet mdformat for trestle ssp-generate templates

Issue description / feature objectives
Trestle has by default adopted mdformat as a defacto standard for ensuring consistent markdown formatting.
(slightly) modify template ssp templates such that when mdformat is used with the following addons:
- mdformat-tables
- mdformat-config
- mdformat-frontmatter
- mdformat-gfm
No changes are made on the objects generated by trestle.
Completion Criteria

Closeing as completed.


chore: rm ui-kit-stage

we introduced that while transitioning to kommander IIRC. we currently don't use
it anymore.
Testing

Trade-offs

Dependencies

Screenshots

:tada: This PR is included in version 5.2.0 :tada:
The release is available on:

v5.2.0
GitHub release

Your semantic-release bot :package::rocket:


Unable to use link with paranthesis on the editor

Bug Report
What is the current behavior?
Hello I'm using the gitbook editor and there's seems to be a problem with some links:
as I looked I saw that your using the words syntax for links, however, when I'm trying to insert links that has parenthesis in them (mostly form github and wikipedia) the first closing parenthesis in the link itself seems to close the link parenthesis of the syntax which leaves me with a broken link and visual awkwardness in the page, here's an example:
##### [Om Next](https://github.com/omcljs/om/wiki/Quick-Start-(om.next)\)
which renders into something like this:
Om Next)
only with a link to:
https://github.com/omcljs/om/wiki/Quick-Start-(om.next
What is the expected behavior?
Well I think this bug is pretty self explanatory and it seems like a really bad bug as I couldn't even reproduce it in the md complier of github.
I should specify that I tried to use a different link syntax but as I save, the editor seems to rearrange the code and bring back this code up here...
For GitBook Editor

Operating System?
Ubuntu 16.04 LTS
(Web) Browser version?
Mozilla firefox 49.0 I think...
(Desktop) Editor version?
6.2.1
Was the bug present in previous versions?
I think it's my first version so I can't be sure...

Hi,
I'm pretty sure that the backslash () at the end of the link is causing the problems and it's unnecessary to have it there. It usually used to escape syntax elements and render them literally. Try to remove it and test again.
Cheers,
Imre

Hi Imre, thanks for replying
Well actually there is nothing wrong with the md cause, as I found out
recently,  in the web editor it renders just fine.
Moreover, I didn't write the md, it is automatically generated by the
gitbook desktop editor,
I've tried numerous ways to write this link but the gitbook code generator
keeps on rewriting it like this.
Since, It's working just fine on the web site it's no biggie, but it is a
bug on the gitbook desktop app md renderer (I think..).
Hoped I helped,
Lidor
2016-10-12 9:21 GMT+03:00 nagim<EMAIL_ADDRESS>
Hi,
I'm pretty sure that the backslash () at the end of the link is causing
the problems and it's unnecessary to have it there. It usually used to
escape syntax elements and render them literally. Try to remove it and test
again.
Cheers,
Imre
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GitbookIO/feedback/issues/203#issuecomment-253129335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK4kpbzqazVtzIuFzAbgtRaV4r3jb62lks5qzHxlgaJpZM4KTh2P
.


Using frames messes up the blur effect.

Bug
When I try to blur an element out and the page contains frame elements then the blur is mislocated on the screenshot. For example If i have a 100px frame on the left side (menu) then on the main frame the blur effect is 100px to the left compared to the element I want to blur out.
To Reproduce
Steps to reproduce the behavior:
Try to blur out elements on a page containing frames and framesets.
Expected behavior
I expect that the specified element is blurred precisely.
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 74

@bioneyez Could you provide some more information for better understanding like a screenshot of the webpage with the element that you were trying to blur and the actual blur?

On the left side you can see a house icon (thats the menu but now its collapsed). I wanted to blur out the application number text input. As you can see the blur is misaligned. I tried it without collapsing the menu and in that case the blur is even more misaligned since then the menu frame takes more space from the page.

@bioneyez Thanks for posting a probable solution. Based on your investigation if I may ask, could you try modifying the source code to fetch coordinates using selenium driver? Currently the coordinates are fetched using javascript. Method _get_coordinates_from_driver(self, element) fetches coordinates from the driver. Im hoping that if the offset issue could be solved using selenium then there would not be any need for additional code to calculate offset based on frames in the page.
I would need a couples of days to look into this issue and get back to you. However feel free to investigate further and raise pull request if you figure out a proper solution

@jz-jess I tried modifying the source code as you suggested, but the result is the same. Selenium driver returns the coordinates relative to the current frame, not the whole page.  https://sqa.stackexchange.com/questions/32617/how-to-get-coordinates-of-element-inside-iframe

@bioneyez Understood. I'd prefer that we fix the issue using python similar to the code in the link above.
I'm assuming now that this would be breaking even the capture element keyword.
I'm thinking we could add an argument in the capture keywords to take frame locators in a list and then modify the blur method to get location of frames using selenium and adding it to the elements location.
Since Im struggling to find time to work on fixing some current issues. It would be great if you would be able to to raise a pull request with a fix. I can fix it myself after a few days if it isn't very urgent.

@jz-jess I'm not sure we need to pass the frames as a list, since we can retrieve all the parent frames automatically. I would prefer python as well, but I think it's a struggle to get all the frame positions using selenium driver. Right now my only idea is to iterate through all the parent frames using switchTo and accumulate the offset, but then we need to switch back to the original frame. If you have a better idea please tell me. It's not urgent since I solved it locally using JS, and it works for now.

@bioneyez If you have implemented the JS code in the library and called it using selenium execute script, then I would like to take a look at it. You can raise a pull request

@jz-jess Another issue came into my mind. What if we want to blur elements in different frames. Right now I think it's only possible to blur elements in the active frame.

@bioneyez What if we call select frame keyword first and then call the capture element keyword?
If this doesnt work then support would have to be added :)

@jz-jess My problem with the above mentioned suggestion is that I think it should be possible to capture the full screen and just pass a list of elements that should be blurred regardless of which frame contains which element. Either by specifying some kind of pattern ex. "frameName:class=tail". I think its cumbersome to specify a list of elements for each frame the page contains and then capturing them individually. Let me know what you think about this.

@bioneyez Let me try to put it another way.
The library is essentially just an extension to selenium. Now consider an example where you are writing a functional test.
To interact with an element within a frame, you would ideally switch to frame using selenium and then interact with the required element.
This is the behavior that this library would also ideally mimic.
The above step is only when you want to capture an element within a single frame.
However like you suggested when you would want to blur elements in the whole page, you would want the capture screen keyword itself to take care of all the frames present in the page and calculate offsets accordingly. This would require proper testing to ensure all cases are covered

Thats exactly how I imagined.

@bioneyez So we're on the same page then :)
Feel free to update your pull request with your fixes. Will release it as part of the upcoming release post review and testing

@jz-jess Can you help me out implementing the capture full screen functionality the way we agreed upon earlier? I tried it and its not that straightforward as I thought.
My concept was:

Get the current frame
initialFrame = self.driver.execute_script("return self.name")
Switch back to the root content and get all the frames in the page

self.driver.switch_to_default_content()
frames = self.driver.find_elements_by_tag_name("frame")

Iterate through all the frames and call the blur_regions on each of them.

for index, frame in enumerate(frames):
            self.driver.switch_to.frame(frame)
            currentFrame = self.driver.execute_script("return self.name")
            logger.console("Blurring in: " + str(currentFrame))
            self.blur_regions(blur, radius, path)

Switch back to the initial frame
self.driver.switch_to_frame(initialFrame)

Unfortunately it's not working, I get StaleElementReferenceException
Concerns

frameset handling
nested frames

@bioneyez StaleElementReferenceException commonly occurs when iterating over a list of loctors. In this case maybe frames. I think the state of DOM is changing in between the iterations which is why the error is thrown.
Before we get into the issue, in your current approact how do we get to know that the region we're trying to blur is within a particular frame?

@jz-jess Right now I don't care about that. I'm trying to blur all the specified elements in all the frames. (later I plan to modify that but for now I think it's okay).
So for example if id=element is in both frame1 and frame2, then it should blur out that element in both of those frames.

@bioneyez Looks like we are trying to find a non existent selector within a frame.
https://stackoverflow.com/questions/53246587/slate-element-reference-exception-when-handling-frames
Would this be the reason?

I think we need to switch to default_content within the loop after blurring, so we can switch to the next frame.

Good point. Now it looks like its working as expected.
What do you think how should it work in case of capture full screen keyword?
Should we care about which frame contains the specified element or just blur out the specified element in every frame? If yes, how should it work? Adding some kind of identifier logic for example:
frame=frameName&class=elementClass (I'm open for suggestions) and if no frame is specified then the blur out in all the frame would be the default.
+1 TODO: make it work for iframes as well

I think we could try blurring an element in every frame. We should catch NoSuchElement exception and continue incase element isn't present.
Keep it simple for the user.
In most cases there will not be frames present I assume. And above logic should take care of it if frames are present. This would require quite a bit of testing though :)

I pushed the solution to the existing pull request,
Extensive testing will be required since I've only managed to do a little bit. I hope everything is ok though.

@bioneyez This has been released in v1.3.2. There were a couple of bugs in your pull request. However they were minor and I was able to fix them. I was able to test it against demo pages with iframes.
Thanks for the help.


[Bug report]: TdsModal does not respect the "show" property

Requirements before reporting

[X] No duplicated issue reported.
[X] I have checked the latest version if the bug exist there. See all available packages at npmJS.com
[X] I have followed the installation guide.

Package versions
"@scania/tegel-react": "1.8.1"
Browser
Chrome
Framework
React
Version
React 18.3.1
Reproduction steps

Add TdsModal with property "show" set to true.
Click close button or backdrop

Code example
Demo:
https://quaspar.github.io/tegel-modal-bug-report/
Code:
https://github.com/quaspar/tegel-modal-bug-report/blob/main/src/App.js
Screenshots
Add/Copy screenshot here
Expected behaviour
Modal should not close as long as the show prop is true.
Console errors
Add warning/error message
Contact information
<EMAIL_ADDRESS>

@quaspar I believe that you can reach this behavior by not using a selector and adding onTdsClose={e => e.preventDefault()}
Then showing and hiding the modal should only rely on the toggling of the show prop.
Let me know if this solution works for you.

Not considered an issue. Seems like lack of information. Closing it. Reopen if provided solution does not work.

Hello, thank you for your replies. Where am I supposed to add the onTdsClose property? I've added it to the modal component, and also added a console log, but no event seems to be caught, and modal closing is not prevented. See links to code and demo above.


Replace apiVersion for ingress in helm chart

Merlin uses mlp chart to perform end to end test. However, the chart uses an already removed version of Ingress API and causing issue when running on Kubernetes 1.22 (https://github.com/gojek/merlin/actions/runs/3328466066/jobs/5504628894).
This PR replace extensions/v1beta1/Ingress with networking.k8s.io/v1/Ingress in the helm chart.

@gojek/roc-dev @pradithya what's our plan for preventing MLP chart drifting away from https://github.com/caraml-dev/helm-charts/tree/main/charts/mlp?

Hmm, didn't realize that. Shall we remove this chart in that case?


Post CSS cleanup

Cleans up post CSS type.
Additions

Fixes #271 - adds clearfix to post body.

Removals

None.

Changes

Changes post_header class to be post_heading, to be consistent
with the summary_heading and be more semantically correct.
Changes the post_dek to paragraph, because that’s what it is.
Fixes typo in cheat sheet.
Includes elements in cheat sheet and fixes structural issues and
missing elements from the cheat sheet.

Testing

Visit a blog entry with a sidebar and remove the body content till the post aside sidebar is higher in height than the blog body copy.

Review

@jimmynotjim
@sebworks
@Scotchester

Preview
Before:

After:

:+1:
Should this be merged into gh-pages since it's existing and outside the Sprint? I'm ok with it waiting till Sprint-21 gets merged in, but figured I'd ask.

I figure it's easier in sprint-21 so it gets another review when all the pieces are in. Probably better to do all work (outside e.g. Readme updates) on the sprint branch, and do more rigorous checks every two weeks when sprint branch goes into gh-pages.

Sounds good. You'll need to pull the latest from sprint-21 to get a merge.

Done!


Support MapType in joins

Closes #2133
This adds MapType support for sort-merge join, hash join, and broadcast join.
I didn't add it for broadcast nested-loop join because it looks like we don't support other complex types for that one.

build


Used initializer to add invokeAction to component. Allowed ability to…

... require Actions and Parameters
Please look over this very carefully as pretty much all has changed.

invokeAction is made available on every Component.
requiredActions array is available to enforce which actions are required.
requiredParams array is available to enforce which params are required.

Notes:
If an action is NOT required use of the invokeAction and you would expect a return value from this optional action, use would be as follows
let x = this.invokeAction('onChange');
if (x !== undefined) {  // You have to do the if because you do not know if the action was passed, and now undefined can not be a valid return value
   // use return value
}

as opposed to NOT using invokeAction which would be
if (this.attrs.onChange) {
    let x = this.attrs.onChange();
    // use return value.
}

If you are depending on a return value, as you can see, you pretty much wont avoid the if, so the attempt to wrap the if in invokeAction really doesn't buy you anything, but its there, use as you wish.
I would not think that an action is optional sometimes and required at others, so checking for required at the call does not make sense. Don't want the developer calling the strict version all the time then missing then forgetting and calling the none strict in another for the same action. If you actually needed that... it would be bascially
// non strict
if (this.attrs.onChange) {
   this.attrs.onChange();
}

// strict
this.attrs.onChange();

one error is as good as another.
But to provide a more generic approach, the array requiredActions is provided. Just list the actions you want required in the array and they will be checked when the component is rendered and an error thrown if not defined. That made it really easy to include another array requiredParams to check for params in general.
RequiredActions and requiredParams really have nothing to do with invoking actions, so should they be in this add-on or another add-on or another add-on named ember-require-parameters which better describes its purpose.

Is this change (or the proposed 'ember-require-parameters') likely to move forward? We're looking for something like this.

@irvingreid nope.


RFC: Implement stream/transform in RunnableRetry

Yield a "stream reset" marker before starting the next attempt
Open question: How to deal with this best in RunnableSequence/RunnableMap? The next steps in the sequence are probably not designed to handle the reset marker, should RunnableSequence retry all steps after "current" once it sees a retry marker?

Open question: How to deal with this best in RunnableSequence/RunnableMap? The next steps in the sequence are probably not designed to handle the reset marker, should RunnableSequence retry all steps after "current" once it sees a retry marker?
Are the options:

RunnableSequence stops as soon as it sees a reset marker and kicks off a retry
RunnableSequence sees a reset marker, makes sure it is propagated through all the steps and then kicks off a retry

Could runnables declare that they support the reset marker and if so, they would receive a reset marker if part of a runnable sequence?
What problems do we think users might bump into? e.g., runnable appending streaming content to a file (not for logging purposes) and can't clean up?

For astream log, do we need a correlation id for reset markers?


fix: fix some little style bugs

changes

changed the name typewriter effect so the blue bar (cursor? idk what its called) is on the same line as the name text
removed w-screen from navbar so on windows it doesn't overflow and create a horizontal scrollbar (mac doesnt do this its quite odd)

cheers

Thank you for your contribution! @jckli


Timeout issue

Hi,
when using nfs volumes and restoring a backup I get a timeout error.
I use the --cmd-timeout=10m
But after about 1 minuut the create commands exits
convoy create d4d-hans-volume --backup vfs:///mnt/nfs1/backup?backup=backup-53065b720c5f4c72\u0026volume=d4d-dbs-volume
ERRO[0072] Error response from server, Timeout executing: tar [xf /mnt/nfs1/d4d-hans-volume/backup-53065b720c5f4c72.bak -C /mnt/nfs1/d4d-hans-volume.tmp], output , error
{
"Error": "Error response from server, Timeout executing: tar [xf /mnt/nfs1/d4d-hans-volume/backup-53065b720c5f4c72.bak -C /mnt/nfs1/d4d-hans-volume.tmp], output , error \u003cnil\u003e\n"
}
convoy --version
convoy version v0.5.0

Hi @jhmnieuwenhuis
It's a bug in backup area, the timeout should be much longer for tar command.
We will fix that.

Ok, Thanks for the quick response !
Any idea when this can be expected.
I may need to look for another solution to back/restore in the mean time...
Regards,
Hans

Probably a week or two, current we're busy on another project.

hi @jhmnieuwenhuis
Can you check what's the CmdTimeout in your /var/lib/rancher/convoy? I think the timeout wasn't updated in this case.

You are right !
I added the CmdTimeout to my servicefile, but it was not updated in the /var/lib/rancher/convoy/convoy.cfg
After adding it to the convoy.cfg file it worked as expected.
I am on Centos 7
Regards,
Hans Nieuwenhuis

Glad it work!


Create index for all UUID fields and metadatavalue

In my performance testing, I discovered the need for several indexes for UUID joins.  Also querying metadatavalue was slow, so I added a couple of additional indexes.
I have not yet retested my migration with this script update.  I am curious to get feedback on these changes and to hear if others concur that these are needed.

I have tested (and fixed) this PR.  I am curious to know if others find these additional indexes helpful.

+1 I haven't done any performace testing, I trust Terry's testing. But I agree with this change, having indexes on UUIDs should have obvious benefits for query planning.

Nice.
This really ought to be a separate migration, so that those who are already testing 6.0 will pick it up after it is merged.

@mwoodiupui Would it not be better to leave it in this migration as it could potentially speed up the migration itself ?

But existing 6.0-SNAPSHOT instances won't be upgraded, because they already have this migration.  In general, each published change to a schema should be a new migration.  You wind up with many of them.

@mwoodiupui I believe @terrywbrady mentioned that without these indexces the migration itself takes a long time. So having them in place might indeed break the SNAPSHOT instances but it would speed up the migration for when DSpace 6 is released. ( @terrywbrady please correct me if I'm wrong).
But I do agree that migrations should be in separate sql files if possible.

I suggest that we add the UUID indexes to the existing migration so that they can be used during the upgrade. The number of people building from master is relatively low and we can notify them via dspace-devel and dspace-commit to run the migration separately. The number of people who will benefit from faster migration is much larger.

The indexes that were needed to expedite the migration were handled in a previous PR. https://github.com/DSpace/DSpace/pull/1101

+1 Updating these DB migrations directly is OK in this scenario as otherwise the upgrade to 6.0 will be painful for large sites.  Since no one should be running 6.0-SNAPSHOT in production, the pain of having to drop your existing 6.0-SNAPSHOT database and re-run these old migrations should only affect developers (and we can warn them on dspace-devel as soon as this is merged).


No status at Elodie app

open app
put folder A and folder B
Click Start Organising
Click in another window. At this moment the app disappear (minimised)
Open the app again, there is no status

+1


Cloudflare 403 / 1020 Error

Hi, don't know if this issue is link to #194 but i'm getting 403/1020 error.
< CONNECT https://haapi.ankama.com/json/Ankama/v2/Api/CreateApiKey HTTP/1.1
< Host: haapi.ankama.com
< User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 11_0 like Mac OS X) AppleWebKit
/537.36 (KHTML, like Gecko) Chrome/51.0.7610.461 Mobile Safari/537.36
< DNT: 1
< Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image
/apng,*/*;q=0.8
< Accept-Language: en-US,en;q=0.9
< Accept-Encoding: gzip, deflate
< Content-Length: 46
< Content-Type: application/x-www-form-urlencoded
<
< login=user&password=passs&long_life_token=true
> HTTP/1.1 403 Forbidden
> Date: Thu, 16 Apr 2020 14:57:25 GMT
> Content-Type: text/html; charset=UTF-8
> Transfer-Encoding: chunked
> Connection: keep-alive
> Set-Cookie: __cfduid=dc2fdd90607abe2da71e2b302c6d1d5801587049045; expires=Sat,
 16-May-20 14:57:25 GMT; path=/; domain=.ankama.com; HttpOnly; SameSite=Lax
> Cache-Control: max-age=15
> Expires: Thu, 16 Apr 2020 14:57:40 GMT
> X-Frame-Options: SAMEORIGIN
> Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-c
gi/beacon/expect-ct"
> Vary: Accept-Encoding
> Server: cloudflare
> CF-RAY: 584ec2374d54f156-ARN
> Content-Encoding: gzip
> cf-request-id: 022517b68d0000f1563923e200000001
>
<!DOCTYPE html>

<title>Access denied | haapi.ankama.com used Cloudflare to restrict access</titl
e>
<meta charset="UTF-8" />
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge,chrome=1" />
<meta name="robots" content="noindex, nofollow" />
<meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=
1" />
<link rel="stylesheet" id="cf_styles-css" href="/cdn-cgi/styles/cf.errors.css" t
ype="text/css" media="screen,projection" />

Please enable cookies.

          Error
          1020
          Ray ID: 584ec2374d54f156 • 2020-04-
16 14:57:25 UTC

Access denied

What happened?

This website is using a security service to protect itself from o
nline attacks.

    Cloudflare Ray ID: 584ec2374d54f156</st
rong>
    •
    Your IP:
    •
    Performance & security by Cloudflare

Cloudflare has blocked this request (Code 1020 Detected).

Python 3.8.2
Windows 10

Can you show code example as well please?

Looking at my past tickets, I have looked into a simliar issue before ...
https://github.com/VeNoMouS/cloudscraper/issues/169#issuecomment-601458942
however, looking re-issuing that code, i get 1020... i think the site has changed something and you're missing a cookie... can you explain the whole process to get the point of posting to haapi.ankama.com ?

Here is my code
import cloudscraper
import sys

try:
	username = 'test'
	password = 'test'
	scraper = cloudscraper.create_scraper(browser={'browser': 'chrome', 'desktop': False})
	logindata = {'login': username, 'password': password, 'long_life_token': 'true'}
	print (scraper.post("https://haapi.ankama.com/json/Ankama/v2/Api/CreateApiKey", data = logindata, timeout=10).text)
except Exception as e:
	print(e)
finally:
	sys.stdout.flush()

You need a valid ankama account for the request to work and to get the error.
Use those informations :
username = "xiyai5orn3uqxj7l"
password = "wnyr143enmza3csf"

Neg, still 1020

Calling CreateApiKey is the first step, there is no step before.
This request is the first step to establish a connexion between the client and the server of the game.
It result in a json containing some informations needed to establish a connexion with the server websocket.

Take a look at the request when it's done through a broswer (simulating the real request) :

"Take a look at the request when it's done through a broswer (simulating the real request) :" HTF CAN I TAKE A LOOK WHEN YOU WONT EXPLAIN WHERE!!! FFS!!

Calm, I'm trying my best to explain, english isn't my native langage.
There is 3 cookies in the request header : __cfduid __cfruid __cf_bm.
Last time I checked, some of them where missing from the scraper when debugging.

Here is the html code used to replicate the connexion without cloudscraper :
`

submit
`

Or you could just tell me what your doing in your browser on anakama.com to replicate like ive asked several times already.

You can't do it directly with the browser, It's an api used by the game Dofus Touch, you can do it with an emulator like Lindo.

cipherSuite issue...
ciphers = [
            'ECDHE-ECDSA-AES128-GCM-SHA256',
            'ECDHE-RSA-AES128-GCM-SHA256',
            'ECDHE-RSA-AES128-SHA',
            'AES128-GCM-SHA256',
            'AES128-SHA',
            'ECDHE-RSA-AES256-SHA384',
            'AES256-SHA',
            'DES-CBC3-SHA',
            'ECDHE-RSA-AES256-GCM-SHA384'
]
scraper = cloudscraper.create_scraper(
    debug=True,
    browser={
        'custom': 'Mozilla/5.0 (Linux; U; Android 6.0.1; zh-cn; OPPO R9s Plus Build/MMB29M) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.134 Mobile Safari/537.36 OppoBrowser/4.4.9'
    },
    ciphersuite=ciphers
)

scraper.post(
    'https://haapi.ankama.com/json/Ankama/v2/Api/CreateApiKey',
    data={
        'login': 'test',
        'password': 'test',
        'long_life_token': 'true'
    }
)

DEBUG
< POST /json/Ankama/v2/Api/CreateApiKey HTTP/1.1
< Host: haapi.ankama.com
< User-Agent: Mozilla/5.0 (Linux; U; Android 6.0.1; zh-cn; OPPO R9s Plus Build/MMB29M) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.134 Mobile Safari/537.36 OppoBrowser/4.4.9
< DNT: 1
< Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
< Accept-Language: en-US,en;q=0.9
< Accept-Encoding: gzip, deflate, br
< Content-Length: 45
< Content-Type: application/x-www-form-urlencoded
<
< login=test&password=test&long_life_token=true
> HTTP/1.1 601 Bad Credentials
> Date: Fri, 17 Apr 2020 00:07:46 GMT
> Content-Type: application/json
> Transfer-Encoding: chunked
> Connection: keep-alive
> Set-Cookie: __cfduid=db1be504f3bce878d0aaeed58c96489021587082064; expires=Sun, 17-May-20 00:07:44 GMT; path=/; domain=.ankama.com; HttpOnly; SameSite=Lax
> Set-Cookie: __cf_bm=e39f8aae065f296faf88bf214f8fb10366dbdbd2-1587082066-1800-AbGl1oZLuexXCCqV8xuhacbSQUtIwZ6S/Q6tjTFRwOlWqkhfdhonywJF5GKAnqYJVL0/d8Ga4JSTGkE1xfLnfC8=; path=/; expires=Fri, 17-Apr-20 00:37:46 GMT; domain=.ankama.com; HttpOnly; Secure
> Access-Control-Allow-Origin: *
> X-Duration: 2.760172
> CF-Cache-Status: DYNAMIC
> Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
> Server: cloudflare
> CF-RAY: 5851e859e928eeaa-AKL
> cf-request-id: 02270f8c2e0000eeaa1cb43200000001
>
{"reason":"FAILED"}
<Response [601]>

Feel free to donate a coffee / beer via https://www.buymeacoffee.com/venomous <3

Hi Venomous , you pushed the fix ? i can't seem to update cloudscraper

No refer the posted code....

https://github.com/VeNoMouS/cloudscraper/issues/195#issuecomment-614962385

I have the same problem on another website so i guessed cloudfare changed their cipherSuite globally , that's why i asked if you're gonna push an update

No globally, its just a enhanced security measure outside of the norm... for instance, sneakersnstuff.com have it enabled... its not a default thing.

I could push it as a standard update... but its only a handful of sites that have beefed up their security at this stage that it is effecting.

i would love it if you push it s a standard update , i'm having the same issue with some websites

So why not just issue
ciphersuite=[
        'ECDHE-ECDSA-AES128-GCM-SHA256',
        'ECDHE-RSA-AES128-GCM-SHA256',
        'ECDHE-RSA-AES128-SHA',
        'AES128-GCM-SHA256',
        'AES128-SHA',
        'ECDHE-RSA-AES256-SHA384',
        'AES256-SHA',
        'DES-CBC3-SHA',
        'ECDHE-RSA-AES256-GCM-SHA384'
    ]

in the mean time?

it didn't work for me ( python )

Linux?

windows 10

Open a ticket then.

do you have discord ? i dont wanna go public ^^

@HiImNatsu what version of python on win10, just checked 3.7.5 and higher and des is not in openssl on windows.

Run the following code to see if you you have the cipher compiled into your OpenSSL library that comes with python..
Windows

3.7.5, 3.8 does not
3.6 does have support.

``python
import ssl
from operator import itemgetter
context = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)
context.set_ciphers('DES-CBC3-SHA')
'DES-CBC3-SHA' in map(itemgetter('name'), context.get_ciphers())

Run the following code to see if you you have the cipher compiled into your OpenSSL library that comes with python..
Windows

3.7.5, 3.8 does not
3.6 does have support.

import ssl
from operator import itemgetter

context = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)
context.set_ciphers('DES-CBC3-SHA')
'DES-CBC3-SHA' in map(itemgetter('name'), context.get_ciphers())

Thank you it worked , bought you a coffee :D

Good morning, VeNoMouS
I hope you are fine in this confination times.
I am trying the code with ciphersuite you posted here, but I am getting this error:
TypeError: init() got an unexpected keyword argument 'ciphersuite'
Python2 and Python3. Any ideas why it is showing? Thank you in advance.
I guess it is a problem with python language, but any help will be welcomed.

ciphersuite -> cipherSuite

Thank you Syliaz! It works now ;)

Sorry, but I have other error now... when I do the test with get_ciphers suggested in this post, I get:
'SSLContext' object has no attribute 'get_ciphers'
Any ideas how to solve it? Thank you!

Anyway, it may not be important... the relevant thing for me is testing against the real web and it is not working now because of the Covid-19. So... I'll have to wait and see if it works some months later. Thank you anyway!


transparently use docker targets when building

Issue #, if available:
Description of changes:
We have traditionally relied on building our components on the host, which requires a fair amount of setup and dependencies.   A while back we did introduce the run-in-docker target(s) to make it easier to run parts of the build locally and match checksums/attribution files by using a docker container running the builder-base image which is what we run in prow/coudebuild.  Recently we started using EKS-D golang builds which are only produced for linux so building on mac and matching checksums (which was possible before) is no longer possible.  Using the builder-base docker approach has worked pretty well.
This PR extends our use of these docker container by converting certain targets, go build/go licenses/attribution and some project specific targets, to use docker automatically if the required toolset is missing.  In the case of golang, we just assume its missing since the likelihood of someone having install EKS-D go is not very high.  This can be overridden if the developer wants to build on the host instead of the container.
The approach used in Common.mk to run the docker targets transparently is a bit hacky....  Its basically the same approach documented and taken in #2546.  The good new is that for project Makefiles where we want to use docker if, say npm is missing in the case of the prometheus build, its a pretty simple change.
I did go through and update the building-locally doc, in which I created and recreated AL2 and AL23 instances to confirm I had as much documented as I could find.
I did add a build-all target to the root Makefile, which I do not intend to be used anywhere but it is a nice helper when trying to validate that an instance has all the dependencies needed to build pretty much the entire stack.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/lgtm
/approve

/test all

/unhold


[SPARK-24596][SQL] Non-cascading Cache Invalidation

What changes were proposed in this pull request?

Add parameter 'cascade' in CacheManager.uncacheQuery(). Under 'cascade=false' mode, only invalidate the current cache, and for other dependent caches, rebuild execution plan and reuse cached buffer.
Pass true/false from callers in different uncache scenarios:

Drop tables and regular (persistent) views: regular mode
Drop temporary views: non-cascading mode
Modify table contents (INSERT/UPDATE/MERGE/DELETE): regular mode
Call DataSet.unpersist(): non-cascading mode
Call Catalog.uncacheTable(): follow the same convention as drop tables/view, which is, use non-cascading mode for temporary views and regular mode for the rest

Note that a regular (persistent) view is a database object just like a table, so after dropping a regular view (whether cached or not cached), any query referring to that view should no long be valid. Hence if a cached persistent view is dropped, we need to invalidate the all dependent caches so that exceptions will be thrown for any later reference. On the other hand, a temporary view is in fact equivalent to an unnamed DataSet, and dropping a temporary view should have no impact on queries referencing that view. Thus we should do non-cascading uncaching for temporary views, which also guarantees a consistent uncaching behavior between temporary views and unnamed DataSets.
How was this patch tested?
New tests in CachedTableSuite and DatasetCacheSuite.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/333/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4228/
Test PASSed.

Test build #92105 has started for PR 21594 at commit 71b93ed.

Test build #92107 has started for PR 21594 at commit b9f1507.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/335/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4231/
Test PASSed.

cc @gatorsmile @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4232/
Test PASSed.

Test build #92108 has started for PR 21594 at commit 4171062.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/336/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92105 has finished for PR 21594 at commit 71b93ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92105/
Test PASSed.

Test build #92107 has finished for PR 21594 at commit b9f1507.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92107/
Test PASSed.

Test build #92108 has finished for PR 21594 at commit 4171062.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92108/
Test PASSed.

Merged build finished. Test PASSed.

IMHO it is good, but may confuse users. Could you please add some JavaDocs to explain the difference?

@TomaszGaweda @viirya  Nice suggestion about the doc. I'll update it.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/362/
Test PASSed.

Test build #92145 has started for PR 21594 at commit c3a8e92.

Test build #92145 has finished for PR 21594 at commit c3a8e92.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92145/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/386/
Test PASSed.

Test build #92185 has started for PR 21594 at commit d97149d.

Test build #92185 has finished for PR 21594 at commit d97149d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ForeachBatchFunction(object):
case class ArrayDistinct(child: Expression)
class ForeachBatchSink[T](batchWriter: (Dataset[T], Long) => Unit, encoder: ExpressionEncoder[T])
trait PythonForeachBatchFunction

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92185/
Test FAILed.

retest please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/395/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92194 has started for PR 21594 at commit 2f00f2f.

Test build #92194 has finished for PR 21594 at commit 2f00f2f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92194/
Test PASSed.

Merged build finished. Test PASSed.

document the behavior changes in the # Migration Guide of /docs/sql-programming-guide.md

Thanks for fixing the current behavior! This is a very important fix.

Test build #92265 has started for PR 21594 at commit bf42fdf.

Test build #92265 has finished for PR 21594 at commit bf42fdf.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92265/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/445/
Test PASSed.

Test build #92274 has started for PR 21594 at commit bf42fdf.

Test build #92274 has finished for PR 21594 at commit bf42fdf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92274/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/453/
Test PASSed.

Test build #92286 has started for PR 21594 at commit f7d48e5.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/454/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92286 has finished for PR 21594 at commit f7d48e5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #92287 has finished for PR 21594 at commit bfda8c1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92287/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92286/
Test FAILed.

Test build #92290 has started for PR 21594 at commit bfda8c1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/456/
Test PASSed.

Test build #92290 has finished for PR 21594 at commit bfda8c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92290/
Test PASSed.

Thanks! Merged to master.


Support for SIGHUP/Config reload.

Allow sending 'hello app, please reload your configuration' to all nodes. This can be done locally with docker kill -sHUP subconfig_appname_1

Seems to be implemented via on kill command, going to test soon™ as user reported it didn't work…

Seems to be implemented via on kill command, going to test soon™ as user reported it didn't work…

I think it should work. I have sent custom signals via kill command
On Sun, 3 Jan 2021, 02:09 jtagcat<EMAIL_ADDRESS>wrote:

Seems to be implemented via on kill command, going to test soon™ as user
reported it didn't work…
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/overnode-org/overnode/issues/54#issuecomment-753471688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6JSVLRU3VZYD74EKFWKHTSX4LIPANCNFSM4VQ7FHWA
.

I think it should work. I have sent custom signals via kill command
On Sun, 3 Jan 2021, 02:09 jtagcat<EMAIL_ADDRESS>wrote:

Seems to be implemented via on kill command, going to test soon™ as user
reported it didn't work…
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/overnode-org/overnode/issues/54#issuecomment-753471688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6JSVLRU3VZYD74EKFWKHTSX4LIPANCNFSM4VQ7FHWA
.

Tested, indeed does work (problem of rtfm).

Tested, indeed does work (problem of rtfm).


section_id is not a valid section ...

Sometimes after deleting and re-creating a new section, test case upload fails with above mentioned error.
Solved
Open developer tools ( F12 or Ctrl+Shift+I ), and do Empty cache and hard reload, by right clicking the refresh button on Chrome.

Cache busting introduced.
See commit https://github.com/m-debnath/testrail_import_app/commit/5b6b4ec9440e631f67a6283f6c3a3664d3651ae5


Improve SerDe test harness

As a developer, I'd like to improve the TestBinder test coverage also to include SerDe workflows.
Acceptance:

Add test coverage for SerDe workflows
Assert on positive and negative content-type conversions

I think with with https://github.com/spring-cloud/spring-cloud-stream/issues/1127 we should reconsider the whole approach in general. While the above commit at this moment is strictly in core, the greater idea is to turn it into a "new" test binder


allow using alternate crate root with derive macro

Needed for https://github.com/rkyv/rkyv/issues/343.
Adding #[check_bytes(crate = "rkyv::bytecheck")], or similar, allows using a different crate root.

This looks correct to me, could you add a test to bytecheck_test that exercises this functionality?

Added

Thanks for the PR!


Very high false coding rate

(Just making an issue for what @philip-schrodt has reported elsewhere so we can consolidate discussion):
UniversalPetrarch is enormously overproducing events. Not sure what the source of the false positives is. E.g.:
Records evaluated:    1018
Correct events:        565    44.21%
Uncoded events:        713    55.79%
Extra events:         3212   315.52%

This should be documented better, since it is from the Spanish cases and
cannot  be repo'd in this branch.
On Mon, Oct 29, 2018, 15:49 Andy Halterman<EMAIL_ADDRESS>wrote:

(Just making an issue for what @philip-schrodt
https://github.com/philip-schrodt has reported elsewhere so we can
consolidate discussion):
UniversalPetrarch is enormously overproducing events. Not sure what the
source of the false positives is. E.g.:
Records evaluated:    1018
Correct events:        565    44.21%
Uncoded events:        713    55.79%
Extra events:         3212   315.52%
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openeventdata/UniversalPetrarch/issues/52, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJrP1uNZMrRygUC7omvzSEP_197rIBQJks5up2nrgaJpZM4YAUtT
.

In progress. Should be getting an update this next week from what's been
told to me by the team last week.
On Mon, Nov 5, 2018, 13:25 Andy Halterman<EMAIL_ADDRESS>wrote:

Any update on this? This is one of the biggest obstacles to using
UniversalPetrarch in production.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openeventdata/UniversalPetrarch/issues/52#issuecomment-436002949,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJrP1up5mZqA0ImEOVbvrxnXpIPiI9LJks5usJCUgaJpZM4YAUtT
.

From talking with @JingL1014, it sounds like she has a couple theories for what could be causing the high false positives:

other true events in the sentences (we only annotated protest and assault events, so events beyond those will be seen as "extra events")
the actor spans could be too large, leading to too many actors being coded, and therefore too many events.

There's also the possibility there's some larger unknown problem in how it's handling the coding.
I think a few tests could help figure out which are going on:

what's the overproduction of protest or assault events only? (eliminate cases from theory 1)
how many of the extra events share an event code and just have different actors? (That would test theory 2)
look at the spans UP is returning (see #44) to make sure nothing wild is happening in the phrase extraction part.

This is specific to Spanish and some issues in the validation code for it.
Should be getting some more specifics with updates from @JingLu, and Phil
and Javier et al on the ES cases.
On Tue, Dec 4, 2018, 08:27 Andy Halterman<EMAIL_ADDRESS>wrote:

Is there an update on this? Have you looked into those tests? It sounds
from @philip-schrodt https://github.com/philip-schrodt like some
sentences are still producing many events so something's still going wrong.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openeventdata/UniversalPetrarch/issues/52#issuecomment-444118178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJrP1tkKraOUbxHMbg5Hkh_bcJG5gej4ks5u1oZWgaJpZM4YAUtT
.


Lowercase sirupsen/logrus package

go mod vendor will fail with error
go<EMAIL_ADDRESS>parsing go.mod: unexpected module path "github.com/sirupsen/logrus"

if the package name is in upper case. The convention seems to be lower case.

I'm actually using https://github.com/aellwein/slf4go with zap now.


Python errors when IP connection fails

Hi Xavier, just found your module and I've started playing with it. I do not write Python code but I can read it.
Thusfar two errors have shown up.

When a TCP connecton fails, there is a syntax error in the except handler. The Domoticz.Error line has "self.IPaddress"in it. Should be "self.IPAddress" (with upper case 'A')
When this exception occurs, the 'client' variable isn't declared.

Next step for me is figure out why the connection fails.
Kind regards,
Rob

Hi Rob,
Can I have the exception error you have in your log ?
King regards,


Deal with dicom to niftii conversions

Description
The objective of this issue is to discuss about dicom to niftii and niftii to dicom conversions.
Functions to explore

https://github.com/qurit/rt-utils
https://razorx89.github.io/pydicom-seg/guides/write.html
https://github.com/gacou54/to_dicom_seg

I find interesting the approach of rt-utils, especially its facility to save the input in a new array.
But I had issues to keep the orientation of the inputs and outputs (see image).
also, as it is a mesh and not voxels, I observe interpolation problems in very irregular contours.

I will explore pydicom-seg approaches: #2
Orientation issues reported
https://github.com/qurit/rt-utils/issues/102
https://github.com/qurit/rt-utils/issues/84

Nifti and DICOM are using a different spacial coordinate system

Very interesting issue about DICOM orientation: https://gist.github.com/agirault/60a72bdaea4a2126ecd08912137fe641


Change archive format for directories to .zip and add iOS/etc. support.

This PR switches from .tar.gz as the preferred archive format for compressed directories to .zip and uses NSFileCoordinator on Darwin to enable support for iOS, watchOS, tvOS, and visionOS.
This feature remains experimental.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@kperryua I can't add you as a reviewer for whatever reason. Hi.

Seems mostly reasonable - except for this spawning processes under SWT_NO_PROCESS_SPAWNING 😂

As discussed elsewhere, there's a ! in there.

@swift-ci test

@swift-ci test

@swift-ci test


feat: add export-terraform function for exporting KCC resources as Terraform

This adds a Terraform export function.
See go/terraform-krm-export for more context.

@morgante CI is reporting one of the tests to be failing
 --- FAIL: TestE2E/../../examples/export-terraform-imperative

@morgante PTAL


File refactor

Clean up some file handling to be more idiomatic, portable, avoid file handle leaks, and use BP when rescuing.

(note, this PR passed circleci, but circleci did not update PR)


Custom errors functionality (#60)

The idea is to extend the error reporting functionality for the benefit of the applications using the gem. It will be much easier for the developers of such applications to understand the precise error and its context from the exception being raised.
The custom errors will be raised only if raise_errors: true setting is provided for the Configuration object.
This is a pull-request from a feature branch to the master. The feature branch was already reviewed and accepted in https://github.com/applift/hasoffersv3/pull/60.

@miry I've decided to make the feature branch first and then open this PR to the master. The idea is that the hasoffersv3 maintainers will be able to update any external docs or notify current users that there is a new functionality available before these changes will get to the master. Also, this leaves some space for more thorough QA etc.


Session Expiry Config

It looks like by default all sessions expire after a period of 1yr. I think this is too short of a duration when it comes to mobile apps, there could be case for an app with millions of users wherein a year from now sessions will expire for tens of thousands of users at the same time.
I think we should have it at a minimum of 3/5 yrs or allow users to customise the duration.

Added by #997


Small correction.

https://github.com/ali-bouali/book-social-network/blame/f9e16680db83b154b926aef2984994c252a37cc5/book-network/src/main/java/com/alibou/book/email/EmailService.java#L40
With the code as it is I always got an error: org.thymeleaf.exceptions.TemplateInputException: Error resolving template [ACTIVATE_ACCOUNT], template might not exist or might not be accessible by any of the configured Template Resolvers
After changing templateName = emailTemplate.name(); to templateName = emailTemplate.getName(); everything is working.

thanks for sharing, i'll also have the same error but works fine right now

I think that I know how to help, and I hope Ali allows me to answer the question. For activation the application is waiting not a token, but the been generated and saved code:
private String generateActivationCode(int length) {
    String characters = "0123456789";
    StringBuilder codeBuilder = new StringBuilder();

    SecureRandom secureRandom = new SecureRandom();

    for (int i = 0; i < length; i++) {
        int randomIndex = secureRandom.nextInt(characters.length());
        codeBuilder.append(characters.charAt(randomIndex));
    }

    return codeBuilder.toString();
}

So you could try to send it instead of sending token.

thanks for sharing, i'll also have the same error but works fine right now

Sorry - I think I described the issue badly. The application can be booted and is running without any error, but while you are doing a registration, email can't be sent (it not appears here http://localhost:1080/#/), and in terminal appears this error message
org.thymeleaf.exceptions.TemplateInputException: Error resolving template [ACTIVATE_ACCOUNT], template might not exist or might not be accessible by any of the configured Template Resolvers
This is why I started the discussion, as I found the correction. The registration can't work without it correctly.

Alibou sir i'm having an issue that i couldn't fix in the account activation it always saying invalid token

Hello, also you could recheck ~ 02:48:00 the tutorial video https://www.youtube.com/watch?v=xqhdRrFzLFY
I think the problem is described there.

The issue is that i can reiceive the verification token but when for the activation i got Invalid token exception and i have log the token it seems i got two different token. like this "Invalid token787589,824433"

This is the error i got when verified the account it seems to generate to different token
{
"message": "Token not found: 787589,622352",
"status": 401
}

I have also removed @Transactional on the activateAccount method

You should make postgres and mail containers to start from zero every time - for that I changed this
ddl-auto: update
to this
ddl-auto: create-drop
Now every time you restart the application you have its initial state. What that gave? By your comments I there is some trouble with saving generated token in the database. I think you should debug the code and explore why the saved code is like this '787589,622352', as it has to be two times shorter: this 787589 or this 622352. How it happened you sending while testing this 'doubled' code? It is not right.

This is the error i got when verified the account it seems to generate to different token { "message": "Token not found: 787589,622352", "status": 401 }

Exactly while testing the token has double.
Let me show you i have debug

here is my repository link: https://github.com/AtalibAgAlmousleck/full-stack-spring-boot-angular-books

Exactly while testing the token has double. Let me show you i have debug
here is my repository link: https://github.com/AtalibAgAlmousleck/full-stack-spring-boot-angular-books

I would like to offer you to find the solution, so please read carefully - I am trying to help.
Thanks for sharing the picture - but the main problem is the same - how this double token '787589,622352' appeared in the db? I think you should simply to start with new email and postgres services (the simplest way for me was editing this ddl-auto: update
to this
ddl-auto: create-drop
in the project application-dev.yml file)
Then, you could start the application with switched debug here
**private String generateAndSaveActivationToken(User user) {
// Generate a token
String generatedToken = generateActivationCode(6);
var token = Token.builder()
.token(generatedToken)
.createdAt(LocalDateTime.now())
.expiresAt(LocalDateTime.now().plusMinutes(15))
.user(user)
.build();
tokenRepository.save(token);
    return generatedToken;
}**

After this method the generated token has to be saved in the db and you could check it. It should contain only six numbers (if yoy did not do any changes in this tutorial).
One more question - did you change the EmailService.java #41 templateName = emailTemplate.name(); to templateName = emailTemplate.getName();?
I think without this correction the registration process also can't be successfully accomplished.

Exactly while testing the token has double. Let me show you i have debug
here is my repository link: https://github.com/AtalibAgAlmousleck/full-stack-spring-boot-angular-books

Unfortunately the git link you sent can't be opened - please recheck. Maybe it is better to see your code.


overlappedQuque is not dequeued completely in doWorkUsingIOCompletionPorts()

    //for (size_t i = 0; i < overlappedQueue.GetCount(); i++)
    while (overlappedQueue.GetCount())

only half of the queue is removed by the for loop.

Not sure what this was referring to originally, but the IO completion port loop has been rewritten for 2.2 and we do not believe it has dispatch issues. Please take a look and open a new issue if you believe there is something still wrong.


Telerik AppBuilder: Cannot build iOS app because of the plugin

Expected Behaviour
App should build successfully with this plugin included
Actual Behaviour
When plugin is added to the app, the build fails
Reproduce Scenario (including but not limited to)
Trying to build the app using Telerik App Builder with plugin included
Steps to Reproduce
/
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
iOS 10.2
Cordova CLI version and cordova platform version
cordova --version: 6.4.0
cordova platform version iOS: 4.3.1

Plugin version
1.9.2
Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
Server exception
Project "PushSpikeProject-new-app.tmp.proj" (default targets):
Warning: Cannot include the following item(s) in your application: .flowconfig. The build system treats items with a leading dot as hidden files or directories and does not process them. If you want to include these items in your application package, rename them and rebuild your app.
ios Build Tooling revision 2<IP_ADDRESS>r
Build Tooling Hostname administrators-mac-14.local
Warning: Failed to install 'com.adobe.phonegap.push.PushPlugin':TypeError: Cannot read property 'length' of undefined at /private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/lib/Podfile.js:151:17 at Array.map (native) at Podfile.write (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/lib/Podfile.js:147:28) at /private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/Api.js:289:29 at _fulfilled (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:834:54) at self.promiseDispatch.done (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:863:30) at Promise.promise.promiseDispatch (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:796:13) at /private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:604:44 at runSingle (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:137:13) at flush (/private/tmp/builds/WAtqtO6r8ISLmeqXFt/app/cordova/node_modules/q/q.js:125:13)
Warning: Cannot read property 'length' of undefined
Warning: /Users/builder/BpcTooling/Cordova3/node_modules/cordova-build-utils/bin/install-plugins-3.js:190 throw Error("exit code: " + code); ^ Error: exit code: 1 at Error (native) at ChildProcess. (/Users/builder/BpcTooling/Cordova3/node_modules/cordova-build-utils/bin/install-plugins-3.js:190:14) at emitTwo (events.js:87:13) at ChildProcess.emit (events.js:172:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:211:12)
Error: Build failed during execution
Error: 'Build failed with error code 1'
Done building project "PushSpikeProject-new-app.tmp.proj" -- FAILED.

@mralj please open a ticket with Telerik.


Relocate parethenses for proper tab completion

Putting the parentheses around object in the <Default> tag caused them to be overwritten by the tab completion, resulting in a broken class definition like:

class NewFloatfloat:
    pass

Placing the parentheses in the <Code>  tag we ensure that tab completion only highlights object for replacement, and leaves the parentheses in place resulting in a proper class definition like:
class NewFloat(float):
    pass

Unfortunately, leaving them out of the tag makes it more difficult to delete the bases entirely, resulting in it being harder to create a correct Python 3 class definition.
We'll take this proposal as a vote for changing that, but without stronger evidence that most users want to specify bases rather than remove them, we're not prepared to make the change globally.

Unless we can figure out a way for delete to also remove the parentheses... might be possible?

I didn't take into account that in Python 3 all classes inherit from object implicitly.
As it stands, users wanting explicit inheritance from object just have to hit enter after filling out ClassName, so this code snippet benefits them the most, in particular Python 2 users who have to use explicit inheritance. Users wanting implicit inheritance from object have to hit the backspace and erase the (object) portion. Users wanting to replace object have to hit backspace, then add the parentheses back along with the bases. I see now why the current state is an optimal balance for Python 2 and Python 3 users under the assumption that inheriting from object is the most common use case.
I would like to try making the next tab highlight only object for replacement, before cycling back to ClassName. So the sequence of highlighting would be ClassName, (object), object. That way all users could replace or delete the parts they want. I made an attempt at this within the class.snippet XML file but I suspect it may not be possible solely from there. I would be interested in pursuing this but I would need some guidance. If this solution is not viable I am fine with the current state of this code snippet.
Thanks for taking a look at this.

With the existing snippet, you're not really saving any keystroke if you delete the base (unless you really wanted that pass).
Personally, I'd rather have 2 separate optimized snippets class and classb.

cl<Tab><Tab> is shorter than class<space>, though since we're not using the bases variable anywhere else in the snippet we may as well remove it completely and let people type it as part of the name.

Closing this PR, as we're not going to take it as-is, but we should keep thinking about ways to improve our code generation features like snippets.


Latest version of the ADMMOptimizer Implementation

Summary
Latest version of the ADMMOptimizer Implementation
Details and comments
Refactored the code
Added a unit test
Removed unnecessary code

Hi, in overall:

Linter output looks good to me.
Variables have been renamed wherever it is possible and makes sense.
Documentation is updated.
Please review and consider it for inclusion.

Hi Anton,
thanks for implementing these many changes, the code looks very good so far and pretty much ready to go in my opinion! I have three more points to discuss (or postpone, we can also do more in a second refactor step).
1. Linter
I'm still getting a few errors when running pylint (see bottom of the post). Most of the complaints are coming from the matrix cache variables (q0, etc). Let's just add a pylint ignore on top of that block that should silence most warnings. I'll add a code suggestion.

Linter output looks good to me.

Are you sure you ran the correct configuration? Can you double check that the following command executed in the root directory doesn't raise any warnings?
pylint -rn qiskit/optimization/algorithms/admm_optimizer.py

Converter
In the solve function you're converting the OptimizationProblem to an ADMMState:
        # parse problem and convert to an ADMM specific representation.
        binary_indices = self._get_variable_indices(problem, CPX_BINARY)
        continuous_indices = self._get_variable_indices(problem, CPX_CONTINUOUS)

        # create our computation state.
        self._state = ADMMState(problem, binary_indices, continuous_indices, self._rho_initial)

        # convert optimization problem to a set of matrices and vector that are used
        # at each iteration.
        self._convert_problem_representation()

In the optimization stack we have problem converters from one representation into another (see https://github.com/stefan-woerner/qiskit-aqua/tree/master/qiskit/optimization/converters). Do you think it makes sense to have an OptimizationProblemToADMMStateConverter converter?
We can also do that in a second refactor step and merge it now. @stefan-woerner what's your opinion?
Pylint output
************* Module optimization.algorithms.admm_optimizer
qiskit/optimization/algorithms/admm_optimizer.py:121:8: C0103: Attribute name "q0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:122:8: C0103: Attribute name "c0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:123:8: C0103: Attribute name "q1" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:124:8: C0103: Attribute name "c1" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:126:8: C0103: Attribute name "a0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:127:8: C0103: Attribute name "b0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:128:8: C0103: Attribute name "a1" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:129:8: C0103: Attribute name "b1" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:130:8: C0103: Attribute name "a2" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:131:8: C0103: Attribute name "a3" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:132:8: C0103: Attribute name "b2" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:133:8: C0103: Attribute name "a4" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:134:8: C0103: Attribute name "b3" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:137:8: C0103: Attribute name "u" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:139:8: C0103: Attribute name "x0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:572:16: C0103: Variable name "b2" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:574:8: C0103: Variable name "a2" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:575:8: C0103: Variable name "a3" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:781:8: C0103: Variable name "x0" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
qiskit/optimization/algorithms/admm_optimizer.py:782:8: C0103: Variable name "u" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)

Linter
Yes I'm aware of these suggestions - variable names do not conform a pattern. No, I'm not aware that there is a requirement that the output of the linter must empty. If so, I have a huge list of complaints from the linter on another source files. Adding this linter hint does not solve the problem completely, there are other places with short names. I can add hints everywhere but this approach eliminates the value of the linter.

Converter
The internal state contains not only matrices and vector but other internal variables used in the implementation. I'd rather pull out methods that extract a matrix representation to OptimizationProblem itself, to the base class. For instance a method that builds a quad matrix from the objective coefficients. I think such methods may be convenient in other places and we can discuss this. At this moment I'd keep the implementation as is.
Yes, I can pull the conversion part out of the ADMM implementation to a separate kind of converter class. But:

there are no rules how converters should be built. There's no a base class and their role in this setup looks too vague to me.
The state is only used in the ADMM implementation, it is very specific to the implementation and to the supported problem type. So, I'm not convinced this part should introduced.

vary_rho is a kind of enum. I can make it a true enum if you think it is better. Idea here is that we have to specify a strategy how we update rho. It is not a boolean variable, we update rho whatever value vary_rho has. So, either we keep as it is now, or make a enum.

Linter
It is actually a requirement to go into Aqua, see the contributing guidelines: https://github.com/stefan-woerner/qiskit-aqua/blob/master/CONTRIBUTING.md, there are also continuous integrations tools set up that only allow merging once all tests and linters pass.
Yes, there are other files that don't pass the lint test, but they are being refactored as well 🙂

I know the ignore doesn't resolve all, let's merge and resolve the rest later.

Converter

At this moment I'd keep the implementation as is.
Yes, let's do that later.

vary_rho

vary_rho is a kind of enum.
If it is an enum that's fine, that was not clear to me from the code. So the enum would decide by how much rho is increased at each iteration?

@Cryoris as I wrote vary_rho may take two values now, each of them defines a strategy how we update rho at each iteration.
Thanks for the review!


parallel & parallelCount don't have effect?

These two parameters are documented but don't seem to have any effect in practice?
Are docs ahead of live?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b3f565b-88e4-88d6-a534-48ec21e6e3d8
Version Independent ID: 9fca89ae-4a6e-a43a-2834-1a91ad44c256
Content: Publish Build Artifacts task - Azure Pipelines & TFS
Content Source: docs/pipelines/tasks/utility/publish-build-artifacts.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Ah, yes. Thanks @joseph-cloudthing , I don't see them in the product either. I'll take a look into this.

@elbatk Did you find anything about this? We don't see it live either

Just giving a spin on this as this looks possibly easy to fix/improve. The parallel is in the code as seen here :
https://github.com/Microsoft/azure-pipelines-tasks/blob/master/Tasks/PublishBuildArtifactsV1/publishbuildartifacts.ts#L90
However it seems the param isn't configurable from the interface. Not sure about the yaml definition... Probably there could be a debug output that confirms / deny the parameter count be easily added...

Is anyone still having an issue with this?

I'm closing this issue. If there are any more issues with this, please open a new issue.


Rename do_data_time_math() to do_date_time_math()

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/3172#issue-1339706487
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #3173 (ead870a) into master (89bcfc4) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
- Coverage   85.85%   85.85%   -0.01%
==========================================
  Files         291      291
  Lines       52786    52786
==========================================
- Hits        45320    45317       -3
- Misses       7466     7469       +3

Impacted Files
Coverage Δ

...tafusion/physical-expr/src/expressions/datetime.rs
84.22% <80.00%> (ø)

datafusion/expr/src/window_frame.rs
92.43% <0.00%> (-0.85%)
:arrow_down:

datafusion/core/src/physical_plan/metrics/value.rs
86.93% <0.00%> (-0.51%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
77.43% <0.00%> (-0.18%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @JasonLi-cn


Fix #106, explain how to deal with undeterminable and anon authors

Explains how to deal with undeterminable and anon. authors
References the new section from the "referencing other works" information
section

Related issues
Refs: #240 (tracking implementation), fix #106 (describing issue)
Describe the changes made in this pull request

Adds an explanatory subsection to definition.reference.authors section
Add links to new section from all authors sections.

Instructions to review the pull request

Look at schema-guide.md
Discuss and decide whether

this is the best place to describe this?
the header (needed to link to it) is the right level
references to new section are in all (and only in) places where they need to be

Merging as discussed in a live review call.

@sdruskat Seems to be useful to GAP: see our suggested citation at https://www.gap-system.org/Contacts/cite.html


Collection Column

Describe the Bug
I want to display page collection column as a label, not object.

Link to the code that reproduces this issue
http://fsicms.app/admin/collections/pages?limit=10&sort=pageTitle
Reproduction Steps
I want to display page collection column as a label, not object.

Which area(s) are affected? (Select all that apply)
db-postgres

I assume this is within a group field named pageStatus. You can create a custom Cell component to do this.
Here is an example: https://github.com/payloadcms/payload/blob/main/test/admin/components/CustomCell/index.tsx