[WIP] Add make api and generated API docs

High Level Description

Adds <adminrouter-src>/api/ directory for Ngindox YAML and HTML
Adds make api to generate above API docs

Related Issues

DCOS_OSS-696 Generate DC/OS API Doc from AdminRouter nginx.conf

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@vespian: Sharing this early to get buy in on the draft.
I still need to add this to CI somehow and figure out how to get the 1.9.x version of the YAML via HTTP so I can generate new HTML for dcos-website.
The HTML generated here is just for manual verification that it looks good and automatic validation that HTML will generate without error. For dcos-website the command to generate HTML will be slightly different to exclude the inline javascript and css (which has to be modified specifically for the dcos-website environment where it is included into another page).
I also plan to add inline comments to the config files in this PR, to correspond to what I did in the example files: https://github.com/karlkfi/ngindox

Here's the rendered HTML from this PR branch:
https://rawgit.com/mesosphere/dcos/karlkfi/adminrouter-ngindox/packages/adminrouter/extra/src/api/nginx.master.html
https://rawgit.com/mesosphere/dcos/karlkfi/adminrouter-ngindox/packages/adminrouter/extra/src/api/nginx.agent.html

OK to test

OK to test

test this please

retest this please

test this please

test this please

New CI build added:
https://jenkins.mesosphere.com/service/jenkins/view/DCOS/job/public-dcos-adminrouter-api/
Unfortunately, the PR webhook triggering doesn't seem to be working...
Example output:
https://jenkins.mesosphere.com/service/jenkins/view/DCOS/job/public-dcos-adminrouter-api/7/console

test this please

test this please

test this please

test this please

test this please

FINALLY got Jenkins webhooks working.
Apparently the existing webhooks were using a github-webhook url, but the "github pull request builder" I'm used to using requires a ghprbhook URL....
So I added a new webhook for ghprbhook with just PR & Issue Comment events.

rebased

I still need to add this to CI somehow and figure out how to get the 1.9.x version of the YAML via HTTP so I can generate new HTML for dcos-website.

Please add it to the existing CI as just an another buildstep/stage - just like i.e. flake8 check are invoked.

New CI build added: https://jenkins.mesosphere.com/service/jenkins/view/DCOS/job/public-dcos-adminrouter-api/

Let's please not multiply CIs, AR already has one and there were some discussions already with #foundations about integrating it into DC/OS tests to have just one run for all the stuff.
On top of that the check jenkins/public-dcos-adminrouter-api is now failing and confusing people as the code it requires is still not in the master branch.

Apparently the existing webhooks were using a github-webhook url, but the "github pull request builder" I'm used to using requires a ghprbhook URL....

Because we were not using it - Jenkins Pipeline scripts do not support GitHubPullRequestBuilder hence the plain GH hook address.
We can jump on quick hangout and I can explain to you how to integrate it with existing CI :)

Reviewed 2 of 7 files at r1, 2 of 7 files at r3.
Review status: 4 of 11 files reviewed at latest revision, 5 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 5 at r3 (raw file):

# Absolute path to AdminRouter source, even if make is run from elsewhere
SRC_DIR:=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))

Do we use it here somewhere?

packages/adminrouter/extra/src/Makefile.common, line 98 at r3 (raw file):

.PHONY: api
api:
	@for prefix in nginx.master nginx.agent ; do \

Soonish we will split these files into multiple smaller ones - this will not be a problem, right?

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):

	@for prefix in nginx.master nginx.agent ; do \
		echo "Generating api/$${prefix}.yaml" && \
		docker run --rm -v "$(SRC_DIR):/src" karlkfi/ngindox parse -f /src/$${prefix}.conf > $(SRC_DIR)/api/$${prefix}.yaml && \

Can we include this tool in the devkit container so that we do not have two different development environments for AR?

packages/adminrouter/extra/src/README.md, line 16 at r3 (raw file):

- NGINX: [nginx.master.conf](nginx.master.conf)
- YAML: [api/nginx.master.yaml](api/nginx.master.yaml)

The api directory may suggest that this directory somehow contains API-related code, while it's just the documentation. Can we move it into doc/ directory? At some point, I will most probably have to split README.md so this will be a good place to put individual README.mD sections too.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):

#!/usr/bin/env bash

Let's please include it in the Makefile.in for now - I do not want to multiply directories we keep around and this script is mall enough, for now, to not to justify individual file IMO. I am thinking about something like make verify-api-docs

Comments from Reviewable

Looks like Reviewable doesn't use line comments or the github review system. So there's no way to respond in thread to each comment without using Reviewable.

Reviewable also seems really confused... It says the Makefile.common changes aren't in the PR.

kk, let's drop reviewable then - GH PR discussions can get messy, but reviewable seems to also be problematic :/ I will resubmit the PR comments in GH way.
FYI @adamtheturtle

Review status: 4 of 11 files reviewed at latest revision, 5 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 5 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Do we use it here somewhere?

This is easier to see in Github's interface. It's used in make api.
The primary reason to use this variable is because PWD is the directory of the user, not the directory of the Makefile. This allows executing the makefile from outside the source directly: make api -f packages/adminrouter/extra/src/Makefile.

packages/adminrouter/extra/src/Makefile.common, line 98 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Soonish we will split these files into multiple smaller ones - this will not be a problem, right?

Depends what you mean by "problem". It you're planning to use more includes, that's fine. If you're planning to have multiple entrypoints, they'd have to be added here and generate more yaml and html files and we'd need to re-think the docs pages.
What are you planning?

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Can we include this tool in the devkit container so that we do not have two different development environments for AR?

Ngindox is not a development environment, it's effectively just an executable in a container image. As of now tho it requires node & npm to install and run. I doubt you want or need either of those in your development environment. That said, it depends on how you use your development environment... Personally I never actually develop in a container, because I prefer a GUI IDE.
There's also a limitation that Ngindox doesn't actually produce a self-contained executable yet. It executes a cli.js as the entrypoint, using node directly. I'd like to fix that, but it's not done yet.

packages/adminrouter/extra/src/README.md, line 16 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
The api directory may suggest that this directory somehow contains API-related code, while it's just the documentation. Can we move it into doc/ directory? At some point, I will most probably have to split README.md so this will be a good place to put individual README.mD sections too.

It depends on whether you think the YAML is the API or just documents the API...
I put it in api/ so that it matched make api. They should probably match, whatever we change it to. And I didn't think make doc or make docs made sense, because there might be more docs than just the api docs.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Let's please include it in the Makefile.in for now - I do not want to multiply directories we keep around and this script is mall enough, for now, to not to justify individual file IMO. I am thinking about something like make verify-api-docs

I hate giant makefiles, they're nearly impossible to maintain by anyone but the author, and rife with "tricks" to get anything complex done, but if that's how you want to do it, fine.

Comments from Reviewable

Reviewed 1 of 7 files at r1, 1 of 1 files at r2, 5 of 7 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 97 at r3 (raw file):

.PHONY: api
api:

Can we please make it api-docs?  Just anapi can have many different meanings.

packages/adminrouter/extra/src/Makefile.common, line 98 at r3 (raw file):
Previously, karlkfi (Karl Isenberg) wrote…
Depends what you mean by "problem". It you're planning to use more includes, that's fine. If you're planning to have multiple entrypoints, they'd have to be added here and generate more yaml and html files and we'd need to re-think the docs pages.
What are you planning?

More includes, entrypoints stay the same. OK, so this is not an issue then.

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):

I doubt you want or need either of those in your development environment.
I would :)

The make api-docs target will become an integral part of the build process. This means that nginxdox should be shared with the rest of the dev environment.
Also, the devkit container is meant to provide a development environment where people can immediately start developing AR, this includes the tools you use to generate doc.
It does not make much difference for dcos build process, as the container is cached anyway.
And last but not least - I would very much prefer to have the definition of all the tooling needed for NGINX doc generation in the AR repo itself. ATM I do not know how exactly the karlfi/ngindoc tool is built.

packages/adminrouter/extra/src/README.md, line 16 at r3 (raw file):

I put it in api/ so that it matched make api.

We currently have make test yet we have the test-harness/tests/ directory where the tests reside. Should I also rename it? I think that make api-docs target plus putting the results in docs/api/ seems like a good compromise.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):
Previously, karlkfi (Karl Isenberg) wrote…
I hate giant makefiles, they're nearly impossible to maintain by anyone but the author, and rife with "tricks" to get anything complex done, but if that's how you want to do it, fine.

I am really trying to keep things neat and simple. As soon as the Makefile starts being unmanagable, I will break it down into smaller parts like like for dcos-ca (https://github.com/mesosphere/dcos-ca/tree/master/helper_scripts). But let's cross this bridge when we get there.

Comments from Reviewable

+1 to dropping reviewable. It does not play well with Github's review. It's situation in which we either use github or use reviewable. It seems using github is less cumbersome now.

Review status: all files reviewed at latest revision, 4 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…

I doubt you want or need either of those in your development environment.
I would :)

The make api-docs target will become an integral part of the build process. This means that nginxdox should be shared with the rest of the dev environment.
Also, the devkit container is meant to provide a development environment where people can immediately start developing AR, this includes the tools you use to generate doc.
It does not make much difference for dcos build process, as the container is cached anyway.
And last but not least - I would very much prefer to have the definition of all the tooling needed for NGINX doc generation in the AR repo itself. ATM I do not know how exactly the karlfi/ngindoc tool is built.

karlkfi/ngindox is a standalone tool: https://github.com/karlkfi/ngindox
It is not specific to Admin Router, and can be used to generate docs for any NGINX config.
I'm not going to put the ngindox source in the dcos repo. That doesn't make sense for a standalone tool.
You also don't need to know how it's built when it's distributed in a container, that's kinda the point. That said, the how is in the readme, if you're interested.
If you want me to install node & npm & ngindox in your devkit, I can do that later. But I can't do it NOW, because ngindox doesn't install as a binary yet. Once I figure that out, using it without Docker will be easier. I'm still not sure I want to be distributing binaries for a node project, or if that's even feasible without requiring node to be installed, which would make it pointless.
Another option is to use docker-in-docker in your devkit.

packages/adminrouter/extra/src/README.md, line 16 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…

I put it in api/ so that it matched make api.

We currently have make test yet we have the test-harness/tests/ directory where the tests reside. Should I also rename it? I think that make api-docs target plus putting the results in docs/api/ seems like a good compromise.

make api-docs and docs/api/ sounds fine.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
I am really trying to keep things neat and simple. As soon as the Makefile starts being unmanagable, I will break it down into smaller parts like like for dcos-ca (https://github.com/mesosphere/dcos-ca/tree/master/helper_scripts). But let's cross this bridge when we get there.

That's basically exactly what i did, just with a different directory name...

Comments from Reviewable

KK, Let's just finish this review in Reviewable so that we do not mess things up too much.

Review status: all files reviewed at latest revision, 3 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):

I'm not going to put the ngindox source in the dcos repo. That doesn't make sense for a standalone tool.

Totally, I am very far from asking you to do it :)

You also don't need to know how it's built when it's distributed in a container, that's kinda the point.

All I want is you to add steps from https://github.com/karlkfi/ngindox/blob/master/README.md -> add them to the Dockerfile of the devkit container so that the tool is installed in the devkit container. It does not have to be binary - I am also compiling AR in the very same docker container.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):
Previously, karlkfi (Karl Isenberg) wrote…
That's basically exactly what i did, just with a different directory name...

Yep, but as I said - let's cross this bridge when we get there. For now I would relly like to take advantage of the fact that AR is in DC/OS repo and I do not have to resort to helper_scripts approach/keep everything in one place for now.

Comments from Reviewable

Moved api to docs/api
Renamed make api to make api-docs
Replaced ci/validate-api-docs.sh with make check-api-docs
Updated Jenkinsfile-insecure.groovy to run make check-api-docs

I can still put ngindox into the devkit, but I don't think it's actually worth the effort... If I install it in the devkit it makes the usage actually more complicated, because it wouldn't be in the entrypoint...

Alright, I've published ngindox to npm and fixed the install issue. There's no self-contained binary, because that's apparently non-trivial with npm, but it is at least easily installable:
$ curl -sL https://deb.nodesource.com/setup_5.x | sudo -E bash -
$ sudo apt-get install -y nodejs
$ npm install -g ngindox

Review status: 3 of 11 files reviewed at latest revision, 3 unresolved discussions.

packages/adminrouter/extra/src/Makefile.common, line 97 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Can we please make it api-docs?  Just anapi can have many different meanings.

Done.

packages/adminrouter/extra/src/Makefile.common, line 100 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…

I'm not going to put the ngindox source in the dcos repo. That doesn't make sense for a standalone tool.

Totally, I am very far from asking you to do it :)

You also don't need to know how it's built when it's distributed in a container, that's kinda the point.

All I want is you to add steps from https://github.com/karlkfi/ngindox/blob/master/README.md -> add them to the Dockerfile of the devkit container so that the tool is installed in the devkit container. It does not have to be binary - I am also compiling AR in the very same docker container.

Done.

packages/adminrouter/extra/src/ci/validate-api-docs.sh, line 1 at r3 (raw file):
Previously, vespian (Paweł Rozlach) wrote…
Yep, but as I said - let's cross this bridge when we get there. For now I would relly like to take advantage of the fact that AR is in DC/OS repo and I do not have to resort to helper_scripts approach/keep everything in one place for now.

Done.

Comments from Reviewable

Added Node, NPM, and Ngindox to adminrouter-devkit
Updated make api-docs to use ngindox in adminrouter-devkit

Alright, @vespian. I believe I addressed all your feedback. LMK.

@adamtheturtle Please have a look - let's ship it soonish!

@jgehrcke: Do you have a better suggestion for the descriptions of the following routes?

/acs/api/v1
/acs/api/v1/auth/
Or should we just punt on it?
If not. Are we good to go?

FWIW, the conf file comments are the source of truth. Ngindox uses them to generate the yaml file.

@mesosphere-mergebot bump-ee

Looks like the Cache and Deprecated metadata fields are getting lost by Ngindox.... need to fix that before merging.

Alright, I fixed the Cache and Deprecated metadata fields. I think we're good to go!


Sentiment analysis chain

Requesting for code review @hwchase17

Requesting the code review for  @hwchase17

Apologies for the slow review! Pr has some merge conflicts, happy to re-review if you'd like to resolve


Navigation layout - is not centered

Bugs
What MDL Version are you using? (please be specific, e.g. major.minor.patch)

actual from web
What browser(s) is this bug affecting (including version)?
Google Chrome, Version 61.0.3163.79 (Official Build) (64-bit)
What OS (and version) are you using?
Windows 10, x64
What are the steps to reproduce the bug? Can you create a plunker/codepen/jsfiddle which reproduces it?

<title>test</title>

        <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
        <link rel="stylesheet" href="https://code.getmdl.io/1.3.0/material.indigo-pink.min.css">

        <meta name="viewport" content="width=device-width, initial-scale=1.0">

                    Title


Automatically Detecting Spy Peers

Currently, there is no feature to detect spy peers/nodes, which has been discussed here.
Some important anomalies to consider are:

When INV is sent to the peer, but the peer doesn't send GETDATA to our node
Spy nodes never send us INV for transactions we sent

We only handle INV, GETDATA, and TX p2p messages. We need to maintain a shared state – one entry (IP address + Port) for each connection with the number of INV, GETDATA, and TX sent and received. Additionally, spy peers will close the connection, so we also need to account for handling closed connections. Once all this is implemented, we can have some stats on normal/spy peers/nodes.
One approach could be to find the ratio of INV/GETDATA for each peer, but there might be other heuristics to detect peer identity.
A reference implementation has been done at the following URL: https://github.com/i-am-yuvi/peer-observer/tree/spy-detection.

As discussed with @0xB10C, we can have peer_id as the identifier for any peer instead of ipaddress+port for privacy reasons.

Another question arises, how do we display the stats for each peer? Maybe we could have something that would display the stats after a certain time(5 mins or 10 mins) of all the peers. @0xB10C

Here in this PR #45, I have used Mutex for the shared state, I think we can use atomics instead of Mutex as it is more efficient and we don't have to rely on lock and unlock operation!!

Another question arises, how do we display the stats for each peer? Maybe we could have something that would display the stats after a certain time(5 mins or 10 mins) of all the peers. @0xB10C

I think that's fine for a start until we figured out a good threshold. Maybe you can sort them based on how many getdata's they have send.

Another question arises, how do we display the stats for each peer? Maybe we could have something that would display the stats after a certain time(5 mins or 10 mins) of all the peers. @0xB10C

I think that's fine for a start until we figured out a good threshold. Maybe you can sort them based on how many getdata's they have send.

Yeah, that would be good for now!

@0xB10C  I have observed some p2p messages received by Bitcoin node using logger in peer-observer i.e. NotFound([WitnessTx(225ac634fa62c...), is this because there is no protobuf definition for this msg type?

No, notfound is a message in the bitcoin p2p protocol.
See https://en.bitcoin.it/wiki/Protocol_documentation#notfound
If your node receives a getdata but it does not have the data, it may respond with a notfound message.


[Request for help] pattern not rendered correctly in some unknown condition

Patternlab is a project with which one can implement a design system. It supports pluggable templating engines. An engine in PatternLab speak is the adaptor which links their code base to the real templating engine. The twig engine is one of them.
A few weeks back, I gave this engine an update by putting Twing underneath.
Once this got released, a few people started working with this refreshed integration. Out of it came the following issue report: https://github.com/pattern-lab/patternlab-node/issues/1201
The report has a link to an example project just before the screenshot. You can download and try it for a reproducable case.
For more than 2 weeks now, I have been trying to find where it goes wrong, but debugging an inherent async setup is hard. So far I failed to find the cause, but it has to be either in Twing itself or in how I integrate Twing in the adaptor (engine-twig). None of the other Patternlab engines have this problem (Mustache, Handlebars). Sidenote: I would welcome async/await in the Twing codebase for the sole reason of debugging.
I would be grateful if anyone from the twing team could try out the sample project and have a look at how I integrate Twing. Any feedback would be welcome to find this issue.

Will have a look and let you know.

@ericmorand bumping to twing 5.0.1 seems to have fixed the problem for me. I asked the creator of the original issue for a confirmation.
Given that PatternLab triggers a sequence of rendering promises, I assume I was bitten by #497. Is that a reasonable assumption?


Update function signature for 0100-same-tree.py

File(s) Modified: 0100-same-tree.py
Language(s) Used: python
Submission URL: https://leetcode.com/problems/same-tree/submissions/1104492565

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@sgrtye Thanks for your contribution 👍


[R] Compilation from source ignores user compilation flags

Describe the bug, including details regarding any error messages, version, and platform.
Installing the R package for arrow using install.packages without a previous system libarrow installation will make it compile the core library on-the-fly, but compilation of said library ignores whatever compilation flags a user sets up for their R setup.
As an example, in a linux system, if I create a file ~/.R/Makevars like this:
MAKEFLAGS += -j$(nproc)

R packages compiled from source will be compiled in parallel using the number of threads in the system as returned by nproc, but installation of the core libarrow during install.packages will not add such flag and will thus compile single-threaded.
Same for other flags used in Makevars, like CXXFLAGS.
Component(s)
R

Setting NOT_CRAN=true will use nproc for the build, CRAN is very particular about core usage so it's limited on purpose. This will also opt in to use of the precompiled binaries if you have openssl and libcurl installed.
You can also set MAKEFLAGS as an envvar which will be picked up by the libarrow build.

Setting NOT_CRAN=true will use nproc for the build

It was just an example. Same happens for other types of build flags, like compiler, preprocessor and linker flags which a user might also want to customize.

You can also set MAKEFLAGS as an envvar which will be picked up by the libarrow build.

Yes, I guess one can set standard env. vars for the build system if needed, but the issue is: R packages are meant to follow the R configuration when compiling rather than following standard env. variables like CC and such. Other R packages do not require setting up flags in special ways.

but the issue is: R packages are meant to follow the R configuration when compiling

It does, for the R package part. Using R makevars for the libarrow build would just cause issues.

Yes, I guess one can set standard env. vars for the build system if needed

As you said yourself you can influence the flags for the bundled build. The bundled build and pre-compiled binaries are a convenience feature only, we could also just add libarrow as a system dependency (e.g. like GDAL for geospatial packages).  We have spent a lot of time and effort to make it easy to install the package, even for users without experience with compiling complex C++ projects.
If you want to compile libarrow in a special way to suit your needs you can either use the env. vars or you can build it locally and build the R package against that version with no problem, the easiest way to do this is to have libarrow in your pkg-config path. See also https://arrow.apache.org/docs/r/articles/developers/install_details.html#finding-libarrow-on-the-system


Ansible playbook 0.8.0 updates

This is a copy of #6144 and it's introduced because that PR has an issue with the author's of one commits

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: geoand
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
Assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @geoand. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geoand, sdake, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ymesika @sdake I believe the changes should also be cherry-picked into the release-0.8.0 branch. Is that possible?

@sdake I don't think so. Only critical fixes will go into that branch.
BTW, are you willing to go to the next Ansible step and use Helm?

@ymesika  I don't have any Helm experience, but if people think that the playbook is best suited to using Helm, then sure!


Add information about node conditions

Fixes #27878
Blocked by #27739
Page updated: /docs/concepts/scheduling-eviction/taint-and-toleration#taint-nodes-by-condition
/sig docs
/language en
/do-not-merge hold
/review @sftim @alculquicondor
/assign

Hi @alculquicondor .
Do you have time to review these updates? Thanks.

/sig node

/sig scheduling
LGTM

Page preview:
https://deploy-preview-27879--kubernetes-io-master-staging.netlify.app/docs/concepts/scheduling-eviction/taint-and-toleration/

We have an LGTM on this if anyone wants to approve :)

Preview: https://deploy-preview-27879--kubernetes-io-main-staging.netlify.app/docs/concepts/scheduling-eviction/taint-and-toleration/

/lgtm

/approve


[fix][broker] Fix LedgerOffloaderStatsImpl singleton close method

Motivation
The LedgerOffloaderStatsImpl singleton close method can't be called twice due to wrong condition in the close method.
Also not every metric is unregistered from the prometheus collector.
Also there might be concurrency issues while closing.
I've noticed that the test LedgerOffloaderMetricsTest often fails if the topic test method is executed after the namespace one.
This is because the assertions in the namespace test are not strict enough to catch the error.
Modifications

Set the singleton instance to null after closing
Unregister all the metrics
Add synchronized to the close method which makes sense since the creation method is synchronized too
Fix assertion in LedgerOffloaderMetricsTest to be more precise

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

/pulsarbot rerun-failure-checks


Bug in function calculate_seasonality()?

Dear lightweight_mmm Team
First of all thanks a lot for this great package. It really solves a lot of problems that I see in common MMM approaches.
I think I stumbled upon a small bug when digging into the package that I want to share here.
In media_transfomrs.py => calculate_seasonality() the degrees_range is initialized with:
degrees_range = jnp.arange(degrees)
This results in Device Array of:
DeviceArray([0, 1], dtype=int32)
If I get the maths right, this will always result in a constant for the 1st degree of seasonality, rather than a wave shape. As we are using priors, that doesn't necessarily break the model, but probably isn't intentional.
inner_value = seasonality_range * 2 * jnp.pi * degrees_range / frequency
 season_matrix_sin = jnp.sin(inner_value)
 season_matrix_cos = jnp.cos(inner_value)

I hope this is helpful.
Kind regards
Finn

Thanks Finn! We're working on a fix for this now

This is fixed now. Thanks again for flagging this!

Thanks, I'm happy that this was helpful!


NFDIV-4201: Update application submitted notification  templates

Change description
Update application submitted notification  templates
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4201
Pull request checklist
Before raising

[ ] tests have been updated / new tests has been added (if needed)
[ ] README and other documentation has been updated / added (if needed)

Before merging

[ ] this ticket been reviewed by QA
[ ] the user story been signed off by the PO

Note: Bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.

code changes went in on another PR


application/octet-stream

Hi! Could you help with it? is it important to have for image (logo) content-type like image/png becouse with
application/octet-stream logo doesn't appear ?

@kozakdenys


[Feature Request] Group Payout Support

no description? what's wrong..

Hello, I have added this.
import robloxapi, asyncio
client = robloxapi.Client("COOKIE")

async def main():
    group = await client.get_group(groupid)

    # example 1
    await group.pay(1, 1000)  # pays roblox 1000 robux

    # example 2
    user = await client.get_user(name='iranathan')
    await group.pay(user.id, 1000)  # pays me 1000 robux

asyncio.run(main())

The example code you provided gives me RuntimeError: Event loop is closed

I can't reproduce this error. Have you updated the library with pip install git+https://github.com/iranathan/robloxapi.git -U?

Updated it, still getting the same error


TECL: Serve other models

Got 404 error in browser on attempts to serve other models from same folder.
Need ability to access files from assets folder (gltf with binary data and textures and packed glb).

@bogdan-karlenko I have moved all relevant parts from this PR to the master branch. I did this manually, by hand, because I didn't want to bother with merging :smile:  . I am closing this now. Please pull latest master, and continue working from there. Thanks!


[from TODO] Query layer return Nothing even when rewards are received

There is a TODO in Plutip tests:
https://github.com/Plutonomicon/cardano-transaction-lib/blob/0576feabc1c7ec03eceb0d65a09fec4b26939322/test/Plutip/Staking.purs#L659C1-L662C1
If Ogmios indeed does that it seems like a too serious bug to ignore.
This TODO needs to be either removed or resolved.

Does this test work for you @Renegatto ?
https://github.com/Plutonomicon/cardano-transaction-lib/blob/0576feabc1c7ec03eceb0d65a09fec4b26939322/test/Plutip/Staking.purs#L575

@klntsky that's another test, I think the PubKey one also needs that assertion uncommented.

Oh I see what you mean, the test you are pointing at is skipped.
I have not ran that one.


Documentation request

Hello,
Thank you for the work on this plugin / project. It would be great to have more detailed documentation on the settings for Auth, Implicit and Hybrid flows. So far, I can only use the Kong Konnect documentation and I'm not sure this plugin works exactly the same.

https://github.com/revomatico/kong-oidc for examples


Update POC licensing guidelines

Updates licensing guidelines to recommend that a short-term license key be provided to new trial admins during the deployment and configuration stage prior to a full POC license being issued.
This will ensure that admins for enterprise POCs are able to fully configure and test their instance prior to POC rollout without encountering any gating issues.

@amenne I don't think this adds much, if any, friction to an admin during the deployment process. Our license keys are very easy to apply and manage from an admin perspective. I think the extra step(s) that it takes to do an "admin" key for initial setup and then the full POC key, later on, is worth it to mitigate any license key-related risk that may come up during the deployment process for a prospect.
Agreed that we need more clarity on Free vs Ent licenses. Merging this PR so those changes can be updated.


ss cannot start server with v2ray-plugin enabled due to 'bind: address already in use'

Issue:
I was trying to use the ss with v2ray-plugin. below is the command.
ss-server -c /etc/shadowsocks-libev/config.json -p 443 --plugin v2ray-plugin plugin-opts "server;tls;host=.com" -m chacha20-ietf-poly1305
The 1st time it started successfully. However after the restart of the machine, it failed to start due to below
2019-11-22 17:23:10 INFO: plugin "v2ray-plugin" enabled
2019-11-22 17:23:10 INFO: initializing ciphers... chacha20-ietf-poly1305
2019-11-22 17:23:10 INFO: tcp server listening at <IP_ADDRESS>:49355
2019-11-22 17:23:10 INFO: running from root user
2019/11/22 17:23:11 V2Ray 4.19.1 (Po) Custom
2019/11/22 17:23:11 A unified platform for anti-censorship.
2019/11/22 17:23:11 failed to start server: v2ray.com/core/app/proxyman/inbound: failed to listen TCP on 49355 > v2ray.com/core/transport/internet: failed to listen on address: <IP_ADDRESS>:49355 > listen tcp <IP_ADDRESS>:49355: bind: address already in use
2019-11-22 17:23:11 ERROR: plugin service exit unexpectedly
The ss config file is the default one. The port "49355" seems to be the port used by the v2ray and it's a random value. Before the ss server start, the port was not used. Any idea why this error happened?

Maybe it would be better to write all config in to config.json?

Maybe it would be better to write all config in to config.json?

I found out the problem, there was '--' missing before 'plugin-opts'.


Logger replaces app.info

app.info has been deprecated for some time in preference of
sphinx.util.logging and has finally resulted in our first crash.
This fixes the problem.
Signed-off-by: Oscar Andreasson<EMAIL_ADDRESS>

Please be aware I haven't tested this yet.

Thanks !


Documentation: Set ReEDS network for transmission data

Type of documentation issue
Incorect Information, Typo
Issue Description
In Model Data, in Transmission there are some instruction on how to run the model using the ReEDS network.
The documentation indicates o use the ReEDS network in PyPSA-USA to enable the links: transport_model setting. In the file workflow/config/config_default.yaml, links does not have a transport_model wildcard but lines does which might be a typo in the documentation.
Link to existing documentation
https://pypsa-usa.readthedocs.io/en/latest/data-transmission.html
Suggested Update
Modify in the documentation enable the links: transport_model to enable the lines: transport_model
Additional Info
No response

Thanks for noting this typo!
We are planning a release this week that restructures how you select transmission networks- so keep an eye out!


Fix of Wrong type of UrlOffset in ClickEvent

Fix of  https://github.com/edjCase/SendGrid.WebHooks/issues/1

Much appreciated


Files written into bucket with 0 bytes

Files written with 0 bytes and failed to write:

My mounting command:
$GOPATH/bin/goofys -o allow_other --file-mode=0777 --dir-mode=0777 --endpoint https://s3.us-east-1.wasabisys.com mybucket /mymount
I am able to write/create directory/file using cli/gui running on Ubuntu 20.04.

can you post your --debug_s3 log?

probably dup of #636


feat(storage): support identifying "object not found" error kind

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously when ObjectStore::read returns a error, we cannot tell whether it's object does not exist or any other error kinds (maybe transient ones). We encounter several cases to distinguish them.
This PR add is_object_not_found_error method for ObjectError.
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Ideally we better replace this BoxedError in ObjectErrorInner::S3(BoxedError) with a dedicated error type, and move implementation detail of is_object_not_found_error into it.
I think we can do that when we're adding more is_**_error for ObjectError. For example, is_timeout_error for all object store types like #9160.


Dacpac Deploy when no SQLCMD variables are defined silently fails

Occurring because Object.fromEntries(sqlCmdVars) throws when sqlCmdVars is undefined.  Will also need updating in vscode-mssql. Introduced by https://github.com/microsoft/azuredatastudio/pull/23082, which was originally a fix for SQLCMD variables not getting passed to STS

verified this is fixed in the latest RC build


mousefix stop working after transferring locations

mousefix stop working after transferring locations mostly using return. go fullscreen and back to window mode does not fix it. need to relaunch game

Agreed, mousefix stop working after teleports. If You teleport to Altgard and You hold right mouse button and you still moving mouse (before new map is fully loaded),  mousefix stop working.

It is working as expected when full mode screen, you will have this issue only in windowed mode

fixed


Fix count from ORC files with no column names

Fixes #8214.  Exception was occurring because normally when there are no column names we cannot prune the file schema since it needs to "line up" with the read schema. However in the case where we do not need any columns from the file, we actually can prune the file schema since it's the special-case of loading only row counts and no columns.  Lacking column names is not a problem when not reading any columns.

build


 But we have to use sudo-prompt again. It's not good to ask second time to user for having UAC permission. Is there any event listener to kill the program started by sudo-prompt or any other mechanism that we can stop asking UAC again?

Thanks @abdurrahmanarikan , I am sorry but that is beyond the scope of sudo-prompt, since we don't return a child process due to cross-platform complexity.
I would recommend rather communicating between your processes using simple files or sockets.


Multi root: revisit workspace file format

/cc @sandy081

Fixed via https://github.com/Microsoft/vscode/pull/33097


Slow Bulk Insert Performance [SUPPORT]

Hi Team,
We are trying to load a very large dataset into hudi. The bulk insert job took ~16.5 hours to complete. The job was run with vanilla settings without any optimisations.
How can we tune the job to make it run faster?
Dataset
Data stored in HDFS / parquet
size: 5.5 TB
number of files: 27000
number of records: ~300 billion
hudi options
.option(RECORDKEY_FIELD_OPT_KEY(), "id")
.option(PARTITIONPATH_FIELD_OPT_KEY(), "")
.option(PRECOMBINE_FIELD_OPT_KEY(), "")
.option(HIVE_STYLE_PARTITIONING_OPT_KEY(), "true")
.option(TABLE_TYPE_OPT_KEY(), MOR_TABLE_TYPE_OPT_VAL())
.option(OPERATION_OPT_KEY(), BULK_INSERT_OPERATION_OPT_VAL())
.option(TABLE_NAME, "")
spark conf
conf.set("spark.debug.maxToStringFields", "100");
conf.set("spark.sql.shuffle.partitions", "2001");
conf.set("spark.sql.warehouse.dir", "/user/hive/warehouse");
conf.set("spark.sql.autoBroadcastJoinThreshold", "31457280");
conf.set("spark.sql.hive.filesourcePartitionFileCacheSize", "2000000000");
conf.set("spark.sql.sources.partitionOverwriteMode", "dynamic");
conf.set("mapreduce.input.fileinputformat.input.dir.recursive", "true");
conf.set("spark.storage.replication.proactive", "true");
spark submit
SPARK_CMD="spark2-submit
--files log4j.properties
--conf "spark.driver.extraJavaOptions=${log4j_setting}"
--conf "spark.executor.extraJavaOptions=${log4j_setting}"
--conf spark.kryoserializer.buffer.max=2040M
--num-executors 25
--executor-cores 5
--driver-memory 8G
--executor-memory 21G
--master yarn
--deploy-mode client
Environment Description

Hudi version : 0.5.3

Spark version : 2.40

Cloudera version : 6.33

Hadoop version : 3.0.0

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) : No

screenshot of spark stages

@vinothchandar are you able suggest some tweaks?

@somebol assuming this is an initial load and after this, you would do insert/upsert operations incrementally?
High level, bulk_insert does a sort and writes out the data. From what I can tell, you have sufficient parallelism.  Could you look into how skewed task runtimes within those stages are?
P.S:  We do incur the cost of Row -> GenericRecord -> Parquet (@nsivabalan has a branch with a fix, that will make it to 0.6.0)

@vinothchandar yes, this is an initial load and we plan to use upsert for incrementals. The task failures are mainly due to preemption.
would there be any benefit say increasing bulkimport parallelism to say ~10000?
The tuning guide mentions " hoodie.[insert|upsert|bulkinsert].shuffle.parallelism such that its atleast input_data_size/500MB" in our case the input data size is 5.5 TB, so by that calculation our parallelism should be around 11000.

stages 4 & 6 seem to have the most skew.
screenshots of stage details
*stage 6

*stage 4

*stage 3

*stage 2

" hoodie.[insert|upsert|bulkinsert].shuffle.parallelism such that its atleast input_data_size/500MB
The reason for this was the 2GB limitation in Spark shuffle.. I see you are on Spark 2.4, which should work get rid of this anyway.

Still worth trying to increase the parallelism to 10K , may be.. it will ensure that the memory needed for each partition is lower (spark's own datastructures).. Also notice how much data it's shuffle spilling.. In all your runs, GC time is very high.. stage 4 75th percentile, for e.g 45 mins out of 3.5h. Consider giving large heap and tune gc bit? https://cwiki.apache.org/confluence/display/HUDI/Tuning+Guide has a sample to try..
Looking at stage 4:
it's the actual write.. line here triggers the DAG and counts the errors during write.. The workload distribution there is based on Spark sort's range partitioner.. seems like it does a reasonable job (2.5x swing between min and max records).. Guess it is what it is.. the sorting here is useful down the line as you perform upserts.. e.g if you have ordered keys , this pre-sort gives you very good index performance.
Looking at stage 6:
Seems like Spark lost a partition in the mean time and thus recomputed the RDD from scratch.. You can see one max task taking up 3hrs there.. My guess is its recomputing. if we make stage 4 more scalable, then I think this will also go away IMO.. Since shuffle uses local disk, I will also ensure cluster is big enough to hold the data needed for shuffle..
Btw all these are spark shuffle tuning, not Hudi specific per se.. and a 5.5TB shuffle is a good size :)

@somebol : can you please check Vinoth's response above and try it out. Let us know if you need more help. Hudi has some perf improvements specific to file listing in latest release that could help you.

@somebol : can you please check Vinoth's response above and try it out. Let us know if you need more help. Hudi has some perf improvements specific to file listing in latest release that could help you.

Hudi also has an optimized version of bulk insert with row writing which is ~30 to 40% faster than regular bulk_insert. You can enable this by setting this config "hoodie.datasource.write.row.writer.enable" to true. Closing this due to no activity. But feel free to reach out to us if you need more help. Happy to assist you.


Update to IBM Open XL C/C++

Hi all,
the documentation currently suggests to use IBM XL C/C++ v2.4.1 compiler. Now, I got curious because it specifically mentions z/OS 2.4 but we are running 2.5. Back in May  the IBM Open XL C/C++ v1.1 compiler was released.
What is the strategy in moving over to Open xlclang? Which - if I read the docs correctly - targets our use case exactly: enhance porting distributed software over to z/OS.
It doesn’t seem to run on z/OS 2.3 but you can still compile for backwards compatibility if needed. Most customers should be moving to 2.4 anyways so that shouldn’t be an issue.
I haven’t myself tried building the existing projects with that compiler. Are there any obvious obstacles that would hinder using the new compiler? I’m happy to experiment a bit and report back my results.
Cheers - David

Unrelated comment but hopefully it's helpful as feedback/a request.
Naming this Open XL C/C++ is annoying.
It's open but it's not really, because you get it for free only if you also pay for XL C/C++.

IBM is working with the LLVM and Clang community: https://www.ibm.com/docs/en/open-xl-c-cpp-zos/1.1?topic=new-llvm-clang-infrastructure
The strategy is definitely to migrate to a truly open C/C++ compiler that people could get either unsupported for free, or supported at a cost, like Open Source software from other vendors, e.g. RedHat.
I can't provide a specific date when or if this would happen unfortunately. If/when we can provide a better answer, we'll definitely put it here!

@v1gnesh @Crosswind I've added a PR to clarify that the compiler is indeed priced (since it has a pre-req of the base C/C++ optionally priced feature on z/OS): https://github.com/ZOSOpenTools/meta/pull/53


Model the fractions of visible and invisible doublets in case of multiplexing

Hey,
on https://demultiplexing-doublet-detecting-docs.readthedocs.io/en/latest/test.html you write:

Please let us know if there are additional features that you think will help make this tool useful.

Not clear where I am supposed to do that, so I do it here.
The tool is very nice, but what I think would be a very useful upgrade is to
Model the fractions of visible and invisible doublets in case of multiplexing
E.g.: invisible home doublet (sample barcodes: sbc-1 + sbc-1) or visible hetero doublet (sbc-1 + sbc-2). Let it be genotype muxing or sample barcode muxing (sbc).
The gist is:

If you mix at 50-50 ratio, your demuxer algorithm will find much more doublets than
if you mix at 90-10 ratio.

I wrote a function for this task in Seurat.utils, you could base on that, but its essentially just multiplying a couple of fractions!

Hi @vertesy !
Thanks for your comment! Sorry for my delayed response - I've been mulling this over for the last day.
I agree this could be very helpful but I think this can really only be implemented for genotype-based demultiplexing doublet annotations. I had considered something like this at one point but decided against it because the doublets detectable by the transcription-based doublet detecting softwares are a function of how heterogeneous the cell types being analyzed are and I think this is a bit hard to estimate a prior.
But your point is well taken and I think I could implement something like this and make it clear that it is only applicable for the genotype-based doublet detections. I would probably try to add it to our doublet calculator and also as a function as part of the package. I think it would be most helpful for users to be able to determine this early on so they know what results to anticipate when they run the tools.
Let me know what you think.

Hey, sure, your call what you think is relevant for your audience.
Just to be precise, what I suggest is applicable for at least 3 ways of multiplexing and it gives the upper estimate at perfect labeling for:

Genotype,
Antibody (the original Cell Hashing paper), and
Lipid based (Multi-seq paper & 10X Cell Multiplexing ) demux.

cheers!

On a similar note, all calculations seem to be legit for the original 10X chip.
Now with the new 10x high throughput chip, the doublet rate is ~halved.


Update to include DO & correct capitalization

Added DigitalOcean as an option
Updated capitalization
Update Equinix Metal to Equinix

Signed-off-by: Ariel Jatib<EMAIL_ADDRESS>

please review and merge @jeefy


Move ruleset out of src/

Description
Move ruleset to /Ramsey.
Motivation and context
Every PHPCS ruleset I've seen/written uses one directory in the root.
That is all.

There is a brand new action:
          - name: "Validate ruleset"
            uses<EMAIL_ADDRESS>            with:
                xml_ruleset: "Ramsey/ruleset.xml"

I’ll have to give some thought to this change. It doesn’t follow the standard code pattern of any of my other repositories, nor does it follow the pds/skeleton standard I try to follow.
I like the new action. Does that mean I can remove the xmllint scripts?

There could be a misunderstanding.

pds/skeleton
This publication describes a standard filesystem skeleton suitable for all PHP packages.

This is a PHPCS standard. PHPCS is an extremely rare animal. Please look at the standards this standard uses. All of them are without src/.

I like the new action. Does that mean I can remove the xmllint scripts?

Thank you.
This is up to you. In turn I like your PHP code checking XML.

This is a PHPCS standard.

Does PHPCS document this directory structure as the preferred structure, or is it a matter of convention? PHPCS goes way back to the PEAR days, so it retains some of the older ways of organizing PHP code. 🙂

I do not know.
BTW PHPCS is not a standard, it does use src/
https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src

all of these https://github.com/PHPCSStandards
https://github.com/slevomat/coding-standard too

That works for me. I merged the other PR, so you might want to rebase this one and change the path in the workflow.

Done 🍏

Thank you!

You're welcome.
It was a pleasure to work on this ruleset.


Unsure if X is supposed to be the Ten?

I'm not getting any Ten cards to render, they could just be replaced by the X or T cards, but I'm not sure if that's intended or a bug

Yeah, e.g. Tc would be "ten of clubs". You can also do Xc to mean "any card of clubs" or Tx to mean "ten of any suit". All cards are intended to be represented as 2 characters. I can expand the docs to make this clearer.

Let me know if this is clearer: https://github.com/mAAdhaTTah/obsidian-poker/pull/16


AutoGluon Tabular Improvements

Issue #, if available:
Description of changes:
Major Additions:

Repeated KFold Bagging
Stacker max_models hyperparameters
Memory Optimization / Checks
Improved Logging, Leaderboard, Info
Various Bug Fixes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-177-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-177/2/index.html

Job PR-177-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-177/4/index.html

Job PR-177-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-177/5/index.html


feat(core): Use Wry custom protocol instead of embedded server

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[x] Yes. Issue #___
[ ] No

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
YAY! It's finally here!!!!

This still needs a fix on macOS.


Flexibility with Validation Input Groups

Currently, validation for forms is not documented and does not seem to be flexible for a regular text input. For example, <EmailInputGroup /> seems to be too specific and tied to an email input. Would it make more sense to simply apply validation to the form elements as props. In angular for example, you get a scoped form object that uses children form elements based on their name properties. For example a form with name="someForm" with an input with name="email" would be inherited and referenced as someForm.email for validation attributes (pristine, dirty, invalid, valid).
Would it make sense to pass the validation state of the FormField in via this.props. For example:
<FormField validity={this.props.validity}>
</FormField>

This would allow the FormField to specify a childContextType and pass the validity down to whatever child existed under the FormField. Then both the FormField and the child component (FormInput, Checkbox) would render themselves based on the validation passed in. When the FormInput, Checkbox changes it's validation, the onChange would trigger passing the current validity along as well. Upon validation in the developers callback, he could pass down the new validation.

We're on the same page :)
Please see my comment on #46


fe crash or enter into has not master status

when fe enters into split-brain status or from normal running into not master status, we should have a method to use --metadata_failure_recovery to recover cluster.

https://github.com/selectdb/doris-operator/pull/124


fix(exports): strips referenced imports of models

The reference import path isn't needed as we have already imported all models into the file in question.
This fixes a bug I am having where the entire type with import is being put where a type is located.
The big issue with this import is that it is an absolute path on the computer that generated the code. This is an issue when we want to deploy the code in a library.
This changes:
  {
    prop1: string;
    myCustomProp: import('/User/person/project/src/openapi/generated/requests/models").MyCustomProp;
  }

to
  {
    prop1: string;
    myCustomProp: MyCustomProp;
  }

I would love to find another way to solve this, as this seems like a hack, but I have yet to find a solution.

@seriouslag Is there any specific case I can reproduce? I would like to try reproducing it on my PC.

@seriouslag Is there any specific case I can reproduce? I would like to try reproducing it on my PC.

openapi.json
I was able to duplicate the issue with this file.


Revert "Add Smit's affiliation"

Reverts QuantEcon/qe_libraries_article#12

@jstac Should I open the PR again?

@Smit-create Yes please :-)


Different Start Times?

Firstly, I LOVE this planner. Hugely helpful for supernote users... what a gift you have bestowed on mankind.
One thing I have an issue with is when I'm planning my day, I usually start working at 7:15 am, so I will have meetings/administrative tasks that I can't add because the template starts at 9am
Any chance we could make a 7am-7pm template for remainder of 2022 and 23/24?
Beggars and Choosers I know :) But it would be a huge help

Hi!
Thank you for your interest in this project!
To help you, you need to fill in some details:

which pattern do you use? (lined, dotted)
AM/PM, or 00-24 time?
with a daily calendar, or without it?
Is Monday or Sunday the first day of the week?

In the no-daily-calendar template, 17-hour-span is available (7—23). In the with-daily-calendar template, 12-hour-span is available.
7 AM — 7 PM is 13 hours total, so it won't fit into the with-daily-calendar template.

I personally use lined, 24 hour, daily calendar, with Sunday First.
Sorry, I meant 07-18 with the final hour ending at 19 (but no block for the 19th hour)
I can’t tell you how much this has helped my productivity.
Gabe
Sent from my iPhone

On Jul 13, 2022, at 05:38, Vitaliy Kudryk @.***> wrote:

Hi!
Thank you for your interest in this project!
To help you, you need to fill in some details:
which pattern do you use? (lined, dotted)
AM/PM, or 00-24 time?
with a daily calendar, or without it?
Is Monday or Sunday the first day of the week?
In the no-daily-calendar template, 17-hour-span is available (7—23). In the with-daily-calendar template, 12-hour-span is available.
7 AM — 7 PM is 13 hours total, so it won't fit into the with-daily-calendar template.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

@boilerwarrior1 reopen if you'll have any further questions

Dude. It’s freaking perfect. Do you have a donation jar set up?
Sent from my iPhone

On Jul 15, 2022, at 04:48, Vitaliy Kudryk @.***> wrote:

Closed #36 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


dlib_encoder enhancement

Thanks for your helpful repository. I have tried dlib face encoder for face recognition purpose in coral developer board which takes around 800 ms for me.
Is it normal or am i missing something ?
Can i make this even faster ?

Did you compile dlib like this to use NEON per the readme:
# -O3 enables auto vectorization optimizations
# so that the compiler automatically uses NEON instructions.
$ python3 setup.py install --set DLIB_NO_GUI_SUPPORT=YES \
--set DLIB_USE_CUDA=NO --compiler-flags "-O3"

Generally dlib is the slowest of the three methods I tried for face detection on the coral dev board. For sure using the TPU is the fastest and is pretty accurate. If you need real-time operation I recommend using the TPU. See how to perform face detection using dlib, OpenCV and the TPU here.
Let me know if I can help further.

@goruck Yes. Installed dlib as mentioned. Initially i have used dlib for face detection, It took too much time ~ 1.16 s. So i have moved to ssd_mobilenet_v2_face_quant_postprocess_edgetpu.
Now i am looking to reduce (may be i can't) the Dlib face embed extraction time  which is approx 0.8 s.
Is there any way to make dlib faster in coral dev board ? or Can i convert it as tflite model to use TPU ?
Note : I have tried dlib-to-tf-keras-converter which can't help me. Also having accuracy issue even while loaded with tensorflow.

@Bhanuchander210 in this project I use dlib via face_recognition.face_encoding to extract facial embeddings. These are then used to train a SVM to do real-time face recognition on faces found by inference on the TPU. I extract and train off-line so real-time operation isn't a requirement. So net is I have not looked at optimizing dlib on this platform.
What is your specific application  that calls for fast extraction of facial embeddings?
Note: A possible alternative is to use OpenCV to extract the embeddings. I have a skeleton of this in the code (see this) but have not spend much time on it.

@goruck  Dlib works faster in x86 as it takes approx 50 ms only, but in coral board it takes approx 800 ms which is not expected.
I am just trying / searching to optimise dlib for good fps as much as possible, even i am aware of that coral dev board is particular for TPU models :)


add ros2 service echo beginners CLI and Service Introspection demo.

to close https://github.com/ros2/ros2/issues/1285 and replace https://github.com/ros2/ros2_documentation/pull/2981

@Yadunund thanks for the review!

@Mergifyio backport iron


Fix logback + JMX memory leak on web application reload

I've been using Spring PetClinic to test memory leaks in Apache Tomcat and I've found a memory leak in PetClinic related to logback and JMX. This pull request fixes the leak but, given I have next to no Spring development experience, I may well have gone about fixing this completely the wrong way.

Thanks Mark for your contribution. To fix this memory leak, we decided to remove the JMX configurator. We would keep Petclinic as simple as possible. And adding a ServletContextListener is a little bit tricky for new Spring developers.
Feel free to submit other leaks or performance issues. And long life to Apache Tomcat.


System Vendor Id Not Being Populated

Bug Description
Systems frontend  when using dictionary functionality is writing to System > meta > vendor > id, when we need to be populating System > vendor_id
Steps to Reproduce

Do this...
Then This...

Expected behavior
A description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Version: 2.19
OS:
Python Version:
Docker Version:

Additional context
Add any other context about the problem here.

Starting QA

Stopping QA, dictionary not working on staging at the moment.

Resuming QA - I think we need to make sure we have every field in the system PUT request regardless of whether it's being edited. It seems like System PUT wants to make sure everything matches.  For example, we're no longer sending in a meta field in this request, so if there was meta information that is being updated with null.


Errors are not cleared after closing the typescript file

Open a ts file
Generate some errors (do not save the file)
Problems view show errors
Close the file and choose not to save
🐛 Errors are still shown

Note: Debugged that typescript is not clearing the diagnostics.

Duplicate of #59363


x/tools/cmd/gopls: vet and staticcheck return "same" diagnostic

What version of Go are you using (go version)?

$ go version
go version devel +c3c53661ba Tue Sep 17 04:37:46 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190923183622-59c6680fe2c1
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20190923183622-59c6680fe2c1

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build538251118=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Running with staticcheck turned on.
With the following file:
package main

import "fmt"

func main() {
	fmt.Printf("%s")
}

the following "identical" diagnostics are returned:
PublishDiagnostics callback: &protocol.PublishDiagnosticsParams{
    URI:         "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Version:     0,
    Diagnostics: {
        {
            Range: protocol.Range{
                Start: protocol.Position{Line:5, Character:1},
                End:   protocol.Position{Line:5, Character:1},
            },
            Severity:           2,
            Code:               nil,
            Source:             "printf",
            Message:            "Printf format %s reads arg #1, but call has 0 args",
            Tags:               nil,
            RelatedInformation: nil,
        },
        {
            Range: protocol.Range{
                Start: protocol.Position{Line:5, Character:11},
                End:   protocol.Position{Line:5, Character:11},
            },
            Severity:           2,
            Code:               nil,
            Source:             "SA5009",
            Message:            "Printf format %s reads arg #1, but call has only 0 args",
            Tags:               nil,
            RelatedInformation: nil,
        },
    },
}

What did you expect to see?
Just one diagnostic reporting the missing argument.
What did you see instead?
Two, as above.

cc @stamblerre @ianthehat

Thanks for reporting. I guess the correct solution would be to maintain some set of duplicate checks. Deduping these diagnostics as we see them wouldn't work because they may have differently worded messages, etc.
Should we disable vet checks that are provided by staticcheck or vice versa?

Should we disable vet checks that are provided by staticcheck or vice versa?

I seem to recall from Slack the other day, @dominikh mentioning that he plans to effectively subsume all vet checks in staticcheck. But I'll leave up to you all to decide which is the source of truth :)

That is indeed the plan, but it is a long-term plan for me. And, of course, vet will continue to gain new checks, too, so I wouldn't simply replace vet with staticcheck in gopls.
Maintaining a list of duplicate checks sounds like the correct approach. Deciding which implementation of a check to use will be the hard part. Some checks are better in staticcheck, some are better in vet… And the list will need to be kept in sync as either vet or staticcheck gain new checks that overlap.

Also, this issue extends to golint as well.


build fails for tinystl

both using command line and latest clion ide i have this error:
[ 40%] Building CXX object src/shared/CMakeFiles/shared.dir/coroutine.cpp.obj In file included from C:\Users\user\Desktop\v\virtual-reality\src\shared\coroutine.h:29:0,                  from C:\Users\user\Desktop\v\virtual-reality\src\shared\coroutine.cpp:24: C:/Users/user/Desktop/v/virtual-reality/dep/tinystl/include/stl/function.h:38:59: error: 'is_callable' is not a member of 'std'      template <class T, typename = typename std::enable_if<std::is_callable<T, Args...>::value>::type>                                                            ^~~ C:/Users/user/Desktop/v/virtual-reality/dep/tinystl/include/stl/function.h:38:86: error: template argument 1 is invalid      template <class T, typename = typename std::enable_if<std::is_callable<T, Args...>::value>::type>                                                                                ^ C:/Users/user/Desktop/v/virtual-reality/dep/tinystl/include/stl/function.h:38:87: error: expected identifier before '::' token      template <class T, typename = typename std::enable_if<std::is_callable<T, Args...>::value>::type>                                                                                ^~ C:/Users/user/Desktop/v/virtual-reality/dep/tinystl/include/stl/function.h:38:87: error: expected '>' before '::' token C:/Users/user/Desktop/v/virtual-reality/dep/tinystl/include/stl/function.h:38:97: error: 'type' in namespace '::' does not name a type      template <class T, typename = typename std::enable_if<std::is_callable<T, Args...>::value>::type>                                                                                ^~~~ C:\Users\user\Desktop\v\virtual-reality\src\shared\coroutine.cpp: In member function 'void coroutine_loop::run()': C:\Users\user\Desktop\v\virtual-reality\src\shared\coroutine.cpp:87:26: error: 'INT_MAX' was not declared in this scope          int sleep_time = INT_MAX;                           ^~~~~~~
my env is:
Windows 10
latest mingw-w64 downloaded "now"
cmake bundled 3.13.2
make/gcc/g++ from mingw install folder
could you please help debugging this error?
thanks

Odd. Error complains about missing std::is_callable while code uses std::is_invocable. Maybe your MingW version does not support that? I tested this code only with MingW that comes with msys2 so if you use any other distribution chances are it may fail.

that's what happens when you work with 3 different VM open :)
i tried to compile using the "old" function which is is_callable, as also you pointed out. then forgot to revert/save in the right VM before the last compile shot.
by the way, i got it working now: from my tests, it only compiles on msys2 64bit+mingw64, but i can't confirm right now.
thanks for your quick reply and also for this project, back testing.


Doc Typo: addTypenameDocumentTransform rename to addTypenameSelectionDocumentTr…

…ansform
typo
Description
typo in the doc
addTypenameDocumentTransform should be addTypenameSelectionDocumentTransform
Type of change

[ ] This change requires a documentation update

Checklist:

[ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

A really innocent issue but takes a minute for any new onboarding user. Just hit it myself and it's completely benign but worth noticing there are about 100 other small things for users to keep in mind when adopting the preset.


bennett wenger

wrote as much as I had time for.
requesting merge.
see you all next week!

Thanks!


Remove unnecessary integration tests.

Remove unnecessary integration tests.

Removing CanOverrideAllPorts, CanOverrideOnlyApiPort
These are simple set/retrieve tests on command line args & don't require node spin up
Already covered in NodeSettingsTest unit tests
NB:  There is a bug in both of these so if they are necessary we need to reinstate https://github.com/stratisproject/StratisBitcoinFullNode/pull/3413

Preferred: @fassadlr @dangershony

@thefazzer can you please list the tests which cover these scenarios?

I had a quick look and there are no tests which cover for instance, the overriding of API/RPC ports. You will need to write a test that sets these values in a string[] and then pass it to NodeSettings constructor. Then that instance can be passed to ApiSettings, RpcSettings etc. You can then check that the value on RpcSettings (for example) is the value that you passed into node settings' constructor.

@fassadlr Slightly more expansive change.


Add a way to disable the prompt

This is part of work to simplify this nushell PR. Clearing out the prompt removes a reference to the stack, letting us avoid a copy

@rtpg can you please add in a example that shows this working...  Thanks !

@rtpg as far as the example it can be as simple as the
https://github.com/nushell/reedline/blob/main/examples/basic.rs
but call it disable_prompt.rs

@rtpg as far as the example it can be as simple as the
https://github.com/nushell/reedline/blob/main/examples/basic.rs
but call it disable_prompt.rs

I don't really understand what you're saying here. Can you add an example and some test to ensure this behavior works in the future?

unresponsive.


Prevent safari from zooming in on mobile

This occurs whenever the font size is less than 1rem.

@joshblack I don't think so. @jeanservaas said the font size should be 14px regardless of input size.
Mobile browsers will zoom in on inputs if the font size is < 16px, but we didn't want that behavior for the icon pages: https://github.com/carbon-design-system/design-language-website/issues/383
This PR keeps the IDL/Carbon styles and behavior in sync (until federated modules comes out 😆)


Change that should break the build

This will break the build... I am using this as a test to validate the Pipeline Failure Notifications


Validation provisioning test

There provisioning tests added, as well as framework additions.
Framework:
Cleanup boolean (so the end user has the ability to forgo a cleanup)
rke-machine-config constructor for digital ocean. (Needed to provision a DO cluster)
machine pool setup helper function (to facilitate creating multiple pools for a cluster)
name generator package for creating unique names for resources created
new config for node role inputs for users do input their desired node setup for machine pools for a cluster
Node Driver Provisioning tests:
AWS/Digital Ocean node driver cluster provisioning
1_Node_all_roles_Admin_User
1_Node_all_roles_Standard_User
3_nodes_-1_role_per_node_Admin_User
3_nodes-1_role_per_node_Standard_User
Dynamic Input admin user
Dynamic Input standard user
1_Node_all_roles_Admin_User
1_Node_all_roles_Standard_User
3_nodes-1_role_per_node_Admin_User
3_nodes-_1_role_per_node_Standard_User
Dynamic Input admin user
Dynamic Input standard user

@paynejacob I've made some updates to the framework, would like your thoughts on them. Thank you.

I just wanted to be clear on the scope of this PR before review.
This will make sure the cluster gets a Ready/Active status in Rancher after provisioning and no other validation would be made. Is this correct?

I just wanted to be clear on the scope of this PR before review.
This will make sure the cluster gets a Ready/Active status in Rancher after provisioning and no other validation would be made. Is this correct?

Correct

@paynejacob sorry Jacob one last review, I made some updates for the configs in the machinepools directory. Suggestions made from my team. I would appreciate one last review on this PR before we merge it in. Thanks!


Blank Page Issue with Latest Build in Docker Environment

Hi Jorge,
I encountered an issue with the latest build: it compiles and runs in Docker, but accessing the server only loads the database and conversations partially before showing a blank page. No login screen appears. The logs indicate all models as "Not implemented."
Could this be a configuration miss on my end or a bug in the code?
Thanks for your help,
Mario

@mbronze I am not able to reproduce this. Can you share the console logs from your page via chrome developer page. Once on the unsaged page right click and click inspect and then click the console tab

sure, here is;
chatbot.digitaldevices.ca-1702948766019.log

Invalid API key', hint: 'Double check your Supabase anon or service_role API key.'}
Did you have the supabase variables set in the .env.local prior to building the docker image? This usually happens when the .env.local is not present in the apps/unsaged folder prior to building

Found the problem not on the .env.local but on Portainer Stack the env variables for supabase  not copied properly.
I guess it override the variables set on the .env.local of the build.
To avoid issues we should just place the env variables in one place or .env.local on root or portainer stack (Docker Compose).
Working good now.
Thank you Very Much


Update the filter quickstart guide.

This change appears to be converting filters_quickstart.md to be filters.md and wiping out all the info in the existing filters.md file. Why did you do this?

@DennisHeimbigner The organization of the generated documentation is getting difficult to parse; this moved it onto the same page, at the top of the filters document. Let me check out how to do this with separate markdown documents.


Compatibility with SWADE (system) and Minimal UI (module)

SWADE (possibly other systems as well):
The context menu for players on the SWADE system is rendered behind the Small Time UI, making it impossible to access all options:

Since the context menu is regularly used in the SWADE system, this makes attaching the Small Time UI there pointless.
Minimal UI:
Minimal UI makes the players menu a little smaller and moves it further to the left of the screen, causing the attached Small Time UI to be slightly off-center:

This one is a very minor problem of course but it is mildly triggering.
Thank you for such a great module however. =)

Addressed the layer order in 1.13.15. I can't accommodate the Minimal UI module tho, sorry.


License?

Can you add a license file to this project?  (Ideally something permissive like MIT and not the GPL would be nice :))

Sure!

Well, after adding the license I realized that SevenZipSharp is licensed under LGPL, this shouldn't  affect the MIT license I just placed on the application, but I am re-opening this issue to remind myself to research the issue further and include all relevant attributions.

IANAL, but if you're embedding SevenZipSharp in to the user's binary, then their binary inherits the LGPL requirements.  Which is rather restrictive.
If I'm reading your code correctly, it only uses SevenZipSharp if the user requests LZMA compression, right?  Does it only embed SevenZipSharp in to the user's binary if they're using LZMA?  If so, then not using LZMA compression means the LGPL requirements won't leak in to the user's binary.  Since you're not embedding SevenZipSharp in to your own binary, your own code should likewise be "protected" from LGPL and the MIT license holds as the most restrictive.
If you were to distribute a DotNetCompressor binary in the future, you'd need to be sure not to embed SevenZipSharp in to your own binary, unless you're willing to release the source code as MIT license and the binary as LGPL license.  Which you could certainly do, but it's maybe a bit confusing.
You might want to make a note in the readme that if the user uses LZMA compression they'll end up inheriting the LGPL license in to their binary.  You could think about adding an option to leave SevenZipSharp.dll separate from the client binary, so that the license doesn't get inherited, but that does mean clients end up with 2 binaries to manage.
Again, IANAL, so take my recommendations/interpretations with a grain of salt.

Sorry for not closing this issue sooner.
The new update removes SevenZipSharp, and uses a different (permissive) compression library.
The MIT License should now be in an unambiguous place.


version 8.0 seems not finished ?

I can finish compiling on Ubuntu 16.04 and win10 64bit, but the binary file  run ( local mode ) with error.
on ubuntu , like this:

in cs_init.txt at 0:
Error opening utf8writeappend file LOGS/startlog.txt: No such file or directory
Segmentation fault

on windows10  , when run the original chatscript.exe file , it crashed.
Then I compile this project , no erros.  But when I run the new  chatscript.exe , it crashed again.
Is this a problem ?

I use the 8.0 version available on https://sourceforge.net/projects/chatscript/
I just managed building and running one of my basic bots without any problem (Windows 10 64, French language for CS).

I have to manually create a folder called LOGS in ChatScript then the program will launch.

@DougDanforth Thanks for your information.  I makedir LOGS ,and it run normally this time.
@ludan-av Thanks for your information, too.

I got this error message too!

This project is moved to ChatScript. And the latest version is 8.2 now.
@rezaee


Implement GroupKeyStoreImpl in EFR32

Problem
Currently, we does not have GroupKeyStoreImpl for EFR32 platforms.
Proposed Solution
Implement GroupKeyStoreImpl

KVS is implemented on EFR32 platform since a long time ago..


Issue with Ionic 5 and angular 13

Hello,
I am facing an issue when implementing the ionic-selectable.
it is not working with Ionic 5 and angular 13.
Error in HTML page :
Can't bind to 'items' since it isn't a known property of 'select-searchable'
Ionic version : 5.4.16
Angular CLI: 13.1.2
Node: 16.13.1
Package Manager: npm 8.1.2
OS: win32 x64
Angular: 13.1.1
Package                         Version
@angular-devkit/architect       0.1301.2
@angular-devkit/build-angular   13.1.4
@angular-devkit/core            13.1.2
@angular-devkit/schematics      13.1.2
@angular/cli                    13.1.2
@angular/language-service       12.0.5
@schematics/angular             13.1.2
rxjs                            7.4.0
typescript                      4.5.4
IonicSelectableModule has already been imported in the lazy loaded page and app.module.ts

Hello,
In case anyone face the same issue, I just solved it by adding the below:

Add  enableIvy to angularCompilerOptions to tsconfig.json

"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
"strictInjectionParameters": true,
"strictInputAccessModifiers": true,
"strictTemplates": true,
"enableIvy": false
}

Add the below to package.json:

"scripts": {
"postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points",
}
Go the solutiion from


[Bug]:

All of the following criteria must be met

[X] All Requirements must be installed.
[ ] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
I have tried playing smt nocturne hd remaster with mods but every time I finish the fight with the Preta after becoming the Demi-fiend when it gets to the menu where you get money and exp it just freezes I should also mention that my playthrough on a new game plus
Did you attach your log file?

[ ] Yes, I attached my log file to the text box above.
[X] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

okay..? this isn't the Nocturne HD remaster github, this is the MelonLoader github. Please only open issues that occur without running any mods, as we do not make those.

I was using MelonLoader for mods and it was causing the game to freeze


Support for multiple values of an argument in ServiceDescription mode

It should be possible to pass several values for an argument, i.e. for a specific predicate in a client's SPARQL query.
Like tags for photos:
?photo
  a schema:Photography;
  schema:keywords "tag1", "tag2";
  ...

Implemented in v0.3.2.beta1.


Update manifest.json

Only changing the manifest version won't work for the migration. There are a lot of breaking change introduced in manifest version 3 and listen1 is using some of them. (i.e. declarative web request).
#817 tries to add mv3 to the current version(mv3 for v3 is already added). You can contribute to that if you want.
Closing this for now

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


chore(actions): Add workflow to clean up old cypress runs

This currently runs once a month on a schedule, or manually as we see fit. I figure we start this on the cypress runs, and we can expand this to other workflows in the future. Note, it targets based on the yaml file name.

The prettier and main actions currently are suffixed with yml. Before we add clean-ups for those, we probably want to rename them.
Example run targeting a different workflow on my repository to confirm this worked:
https://github.com/bheiskell/StarWarsFFG-Enhancements/actions/runs/4214411151/jobs/7314855574


Does not handle errors thrown by Node's fs module

Environment details

Node.js version: v12.2
@google-cloud/error-reporting version: 2.0.0

Steps to reproduce
I found today that not all errors are created equal. I have a very simple setup:
		app.use(errorReporting.express)

I then tried to test this error reporting. It works with the example in the README which uses JSON.parse. I also had my own example which relies on fs.writeFile. To my surprise it didn't work.
testRouter.post('/error/bug2',
	async (req, res) => {
		await fsPromise.writeFile('/this/is/not/a/path', 'datas', 'utf8');
	});

... results in this bad boy
ERROR:@google-cloud/error-reporting: Encountered an error while attempting to transmit an error to the Stackdriver Error Reporting API. ApiError: ReportedErrorEvent.context must contain a location unless `message` contain an exception or stacktrace.

Now, I can't tell what the fs errors are missing that other errors have. For example, upon inspection all the following evaluated to true:

err instanceof Error
!!err.message
!!err.stack

So if it looks like a duck and quacks like a duck... why is it not a duck? The only thing I can think of is that it may have some atypical methods, perhaps a toJSON or the like, that make it look all funny when it's being transformed into a request payload. But I'll be honest, this one's beyond me.
[Error: ENOENT: no such file or directory, open '/this/is/not/a/path'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/this/is/not/a/path'
}

@rubenvereecken I tried with mentioned version, but I could not reproduce it.
The error message that you got is when context does not contain a location and message also doesn't have any exception or stacktrace.
Here is the complete working example:
const express = require('express');
const fs = require('fs');

const { ErrorReporting } = require('@google-cloud/error-reporting');

const errors = new ErrorReporting({
    reportMode: 'always'
});

const app = express();

app.post('/error', (req, res, next) => {
    fs.writeFileSync("/this/is/not/a/path", 'datas', 'utf8');
});

app.get('/', (req, res) => {
    res.send('Welcome!!')
});

app.use(errors.express);

app.listen(3000);

Output in Cloud Console:
Error: ENOENT: no such file or directory, open '/this/is/not/a/path'
at Object.openSync (fs.js:462)
at Object.writeFileSync (fs.js:1384)

Hi @rubenvereecken, can you provide more of your entire code snippet, including how you are reporting the error itself?
Note that your error message needs to be converted into a string.

Hi @rubenvereecken, can you provide more of your entire code snippet, including how you are reporting the error itself?
Note that your error message needs to be converted into a string.

Closing this issue due to 2+ mo no reply. Do feel free to reopen if issue persists.

Closing this issue due to 2+ mo no reply. Do feel free to reopen if issue persists.


How to pretrain in a new dataset?

Dear author,
Thank you for open-sourcing this very meaningful work. I have a couple of questions, and I would appreciate it if you could provide some clarification:
Is GPT-ST only applicable to the four transportation datasets mentioned in your paper? Can I modify certain parameters and run it on other datasets after converting them into time and spatial feature files?
In your project introduction document, I noticed that you employ different running modes and baseline models. Is this a fixed combination? For instance, if I want to use the STGCN baseline model to pre-train my own spatiotemporal dataset, is it feasible?
Thank you very much for your response!

Hello, thank you for recognizing our work.
GPT-ST can be applied to various spatiotemporal datasets. If you want to use it on a new dataset, I recommend retraining on it. Here is a brief summary of the steps: you can start by adding the new data file in the ./data folder and include data processing code in ./lib/load_dataset.py, then add a configuration file for the new dataset in ./conf/GPTST_pretrain/.
# Use the following command for pretraining, and the path to save the weights is specified in the configuration file of the new dataset.
python Run.py -dataset [new_dataset_name] -mode pretrain

# After completing the pretraining you can proceed with testing. Don't forget to add the conf file for the downstream model and the adjacency matrices required by different baselines:
python Run.py -dataset [new_dataset_name] -mode eval -model STGCN

The document only presents a subset of examples, and these are not fixed combinations. If you want to solely pretrain and test the STGCN without utilizing the GPT-ST model for enhancement:
python Run.py -dataset [new dataset name] -mode ori -model STGCN

You can set debug to True in ./conf/GPTST_pretrain/params_predictors.conf. This will ensure that the STGCN weights are saved.


return autogenerated keys

is there any chance to retrive autogenerated keys from an insert statement? Something like the jdbc executeUpdate(String sql, int autoGeneratedKeys)? This would be really cool.

A simple way to do this (for PostgreSQL, at least) is to include RETURNING to your insert statement, that will make it return a result set with all keys that were produced by the insert. Not sure how we could implement this inside the driver itself as there is no direct command to pull this data.

yes, unfortunately MySql doesn't suppert the RETURNING. In the meantime i implemented a local keygenerator, so i'm having more controle about that.

If you are using MySql, this is something you could do :
 queryResult.asInstanceOf[MySQLQueryResult].lastInsertId.

yay, I didn't even remember this was there for MySQL :smile:

super, thanks a lot. I guess its not used like that in the vertx packages for mysql and postgres. Will check that,


fix: correct type definitions

It not works in TS : )
Fix types file according to the commit feat: change server options.

Good catch, thank you!


fix(TableCard): use table loading state rather than card

Closes #1904
Summary

When isLoading is set in TableCard, set view: { table: { loadingState: isLoading } } instead of passing it to Card
Also fixes a bug where loadingState.rowCount was not being respected

Change List (commits, features, bugs, etc)

Add isLoading knob to all TableCard stories
Add isLoading story to TableCard

Acceptance Test (how to verify the PR)

Go to ?path=/story/watson-iot-tablecard--with-is-loading and see that the table loading state is being used and there are 7 rows
Go to  /?path=/story/watson-iot-table--with-loading-state and see that 7 rows are shown

:tada: This PR is included in version 2.141.0-next.69 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.142.0-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.142.0-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.142.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.142.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Frontend] Integrated author Apis

Asana Link: https://app.asana.com/0/1204411152293714/1204618434482829/f

Integrated the Author APIs with the frontend
List, Details, Create, and Update working
Delete integrated but not yet working because of pending soft-delete implementation.
Although not part of this ticket, but also integrated the newly created refresh_token endpoint.

Wonder Why Test Cases Are Failing , must be due to conflicts from multiple PR`s , please check and fix in the next PR

Wonder Why Test Cases Are Failing , must be due to conflicts from multiple PR`s , please check and fix in the next PR

Yes the test cases are failing because one of the previous PRs had some issues with the new status column. @Sana-Ullah786 said that will be fixed in the next PR.


Add metadata validation tests

Is your feature request related to a problem? Please describe.
Following on from #283 , a good sanity-check test would be to run the metadata-validate tool over all the reference metadata.yaml stored in the reference directory (config/metadata_sources). Not only would this prevent bad metadata leaking into the repo, it would also provide a test whenever the metadata schema is updated.
Describe the feature you'd like
Add a test suite that runs metadata-validate over all metadata.yaml in the config/metadata_sources directory.
Describe alternatives you've considered
I thought about requesting this as a CI check instead, but I realized it's faster & easier to do at the pytest level.
Additional context
Nil.

I've added this ability in the 285 branch, including the ability to automatically find and test existing catalog_sources. Now blocked by the metadata errors in #286 .

Just merged #286 into main, and main into branch 285 - I think it's ready to merge.

Closed by #288.


Update reports and team-reports zero state

Reports
Before:

After:

Team reports:
Before:

After:

Merged with other pr