Could not read kubernetes Secrets using cluster client

Hi I am encountering this issue when trying to port a GKE cluster to EKC.
Here are the version info of the applications in use.
Kubectl:
Client Version: v1.27.2
Kustomize Version: v5.0.1
Server Version: v1.27.3-gke.100
Helm:
v3.10.1+g9f88ccb
Docker:
Docker version 24.0.5, build ced0996
KMF
v1.1.0
NB: I am using WSL2 with the ubuntu distro version 22.04
Here is a screenshot of the error I'm receiving as well.

@romaine-murray - We will look at this issue. Meanwhile you can pick the package in release section to test.

@romaine-murray  - Have you found a solution for it? I'm facing the same issue; this error was raised from the Generate_cronjob_config function.
I'm using Kubectl 1.26, Helm 3.8, and KMF 1.1.0.
logs:
Please pass the location of source kubernetes cluster kubeconfig file: ********
Please pass the source context (default: **********):
Please pass source type  (supported source types GKE,AKS,KOPS): GKE
Deploy
GKE Resources
GKE GetSourceDetails....
Namespace list entered by user
cronjob: default
Could not read kubernetes Secrets using cluster client: the server could not find the requested resource

Hi @khanhnd0408, our team have since abandoned this workflow and opted to deploy into AWS EKS manually, as we were strapped for time, maybe another time we'll be able to investigate this issue further.

Hi
is there a solution for that?

@vasarobi we are having the below issue and additionally we've attempted with all tags  (v<IP_ADDRESS>,v1.1.0,v1.0.0)
Error1: Used branch main
Deploy
GKE Resources
GKE GetSourceDetails....
Namespace list entered as 'all' by user, hence all namespaces will be considered
Could not read kubernetes Secrets using cluster client: the server could not find the requested resource
Error 2: Used branch dependabot/go_modules/helm.sh/helm/v3-3.14.2
Deploy
GKE Resources
GKE GetSourceDetails....
Namespace list entered as 'all' by user, hence all namespaces will be considered
2024/03/06 07:55:40 exit status 1

@vasarobi we are having the below issue and additionally we've attempted with all tags (v<IP_ADDRESS>,v1.1.0,v1.0.0)
Error1: Used branch main
Deploy GKE Resources GKE GetSourceDetails.... Namespace list entered as 'all' by user, hence all namespaces will be considered Could not read kubernetes Secrets using cluster client: the server could not find the requested resource
Error 2: Used branch dependabot/go_modules/helm.sh/helm/v3-3.14.2
Deploy GKE Resources GKE GetSourceDetails.... Namespace list entered as 'all' by user, hence all namespaces will be considered 2024/03/06 07:55:40 exit status 1

Apologies for any inconvenience. We acknowledge the problem arising from Helm. At this time, we haven't established a plan to address this issue. If you are not planning on helm migration then pls disable the Helm section in the source code and attempt running the package.

@vasarobi can you give more context on disabling the Helm section in the source code. I tried removing all helm related methods, still encountering the same issue. Is there any forked repository having disabled Helm section?

@vasarobi can you give more context on disabling the Helm section in the source code. I tried removing all helm related methods, still encountering the same issue. Is there any forked repository having disabled Helm section?

@siddhantprateek  - The libraries & packages have to be updated to use the latest ones. You can comment out helm in below section.
file: aws-kubernetes-migration-factory/app/source/gke/gke.go
code: source_impl.Generate_helm_charts(sCluster, &resources)


AmazonS3: No valid region has been specified. Unable to return region name

Getting an exception:
java.lang.IllegalStateException: No valid region has been specified. Unable to return region name at com.amazonaws.services.s3.AmazonS3Client.getRegionName(AmazonS3Client.java:4613)
added one line to provided test S3MockRuleTest:
https://github.com/adobe/S3Mock/blob/master/testsupport/junit4/src/test/java/com/adobe/testing/s3mock/junit4/S3MockRuleTest.java
`    @Test
public void shouldUploadAndDownloadObject() throws Exception {
final File uploadFile = new File(UPLOAD_FILE_NAME);
    s3Client.createBucket(BUCKET_NAME);
    s3Client.putObject(new PutObjectRequest(BUCKET_NAME, uploadFile.getName(), uploadFile));

    final S3Object s3Object = s3Client.getObject(BUCKET_NAME, uploadFile.getName());

    System.out.println(s3Client.getRegionName() + s3Client.getRegion());`

looks like this question has been answered a while back, closing :)


Doesn't work on Garena client.

title

Alright, and after pressing Enter, it says [+] Boosted the lobby!, correct?
I'm going to try and get my hands on a Garena client and see what I can do, although some other Garena users have told me that it works.


Fix duplicated type name on generics

This commit addresses #2379 by implementing additional logic to resolve
strawberry.lazy annotated types. Previously, if the same return type
was declared in one location using strawberry.lazy and in another
location without, then a DuplicatedTypeName exception would be raised.
Summary of Changes:

Added logic to handle StrawberryOptional in schema_converter.py
Added check to determine if strawberry.lazy refers to the
__main__ module to prevent an import leading to instantiation
of new module members.

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

#2397

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fix DuplicatedTypeName exception being raised on generics declared using
strawberry.lazy. Previously the following would raise:
# issue_2397.py
from typing import Annotated, Generic, TypeVar

import strawberry

T = TypeVar("T")

@strawberry.type
class Item:
    name: str

@strawberry.type
class Edge(Generic[T]):
    node: T

@strawberry.type
class Query:
    edges_normal: Edge[Item]
    edges_lazy: Edge[Annotated["Item", strawberry.lazy("issue_2397")]]

if __name__ == "__main__":
    schema = strawberry.Schema(query=Query)

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to San Kilkis for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


Update instructions for creating development clusters

What this PR does / why we need it:
Update instructions for setting up development clusters on GKE and minikube.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
e4db29ae1f5c29d77dc871c6008737eab768c81f
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Animatable trait for interpolation and blending

Objective
Allow animation of types other than translation, scale, and rotation on Transforms.
Solution
Add a base trait for all values that can be animated by the animation system. This provides the basic operations for sampling and blending animation values for more than just translation, rotation, and scale.
This implements part of bevyengine/rfcs#49, but is missing the implementations for Range<T> and Color. This also does not fully integrate with the existing AnimationPlayer yet, just setting up the trait.

Removing the controversial label as the RFC has been merged. I'll update this PR and address the comments as soon as I can.

After some heavy research and trying to understand everything I have found out that godot's implementation is similiar to what we are going for and they have so far pretty much done all the heavy lifting.
We pretty much just have to rewrite what godot has in rust and then link it to the bevy-engine. https://github.com/godotengine/godot/tree/master/scene/animation
Also we would have to change somethings so that we can interface with it as in godot's implemention you interface it with the editor which we do not have yet.

Removing the controversial label as the RFC has been merged. I'll update this PR and address the comments as soon as I can.

I don't know what this refers to but bevyengine/rfcs#49 is in Draft, not merged. And to me at least is veryuch controversial.

I don't know what this refers to but bevyengine/rfcs#49 is in Draft, not merged. And to me at least is very much controversial. See my review for context.

https://github.com/bevyengine/rfcs/pull/51is the RFC in question, which was written to be independent of the primitives RFC. I'll probably rewrite that RFC when it comes time to do reflection-based "animate anything" work. For now, this is strictly focused on composition of skeletal animation and morph targets.

bevyengine/rfcs#51 is the RFC in question, which was written to be independent of the primitives RFC and has been merged. I'll probably rewrite the primitives RFC when it comes time to do reflection-based "animate anything" work.

Ok, this was confusing because the PR description only talks about bevyengine/rfcs#49 and says this PR implements it (which looks to be the case), while there's no mention of bevyengine/rfcs#51.

For now, this is strictly focused on composition of skeletal animation and morph targets.

Then I think a trait for each individual value is the wrong abstraction I think. If we want an optimized system for those two, and I think we do, then we should do specifically that and heavily optimize it. That means trying to gather as many Transform as possible and then batch-interpolate them with a tight SIMD loop (data oriented pipeline). There should be no function call there. This is the only way we can have a performant animation system handling complex/large skeletons at scale. I very much doubt we need the "interpolate a Handle<T>" in that part, there's no way we will have a skeleton with one Handle<T> per bone/joint or per vertex for a morph target. If we want the animation system to also account for Handle<T> animations then that's necessarily at a different, reduced scale, and then we can consider a different design. Here we're doing a generic approach mixing all scales.

Ok, this was confusing because the PR description only talks about bevyengine/rfcs#49 and says this PR implements it (which looks to be the case), while there's no mention of bevyengine/rfcs#51.

Thanks. Forgot to update that since this PR was written originally while the RFC's review was under way. Done.

That means trying to gather as many Transform as possible and then batch-interpolate them with a tight SIMD loop (data oriented pipeline). There should be no function call there.

That is exactly what Animatable::blend is. Note how it has no self argument of any kind, it takes a iterator of BlendInputs, and there's zero use of dynamic dispatch within any of it's implementations. It's meant to be a way to gather a weighted blend of inputs from an iterator, which can be sourced from a cache-friendly data-oriented data store. The Vec3A, Vec4, and Transform implementations all rely on glam's built in SIMD acceleration. The Vec3 implementation is specialized to use Vec3A's since it's likely to improve performance, even when unaligned. Is there another SIMD operation that I'm missing here that would help that is not being included in that loop?

I very much doubt we need the "interpolate a Handle<T>" in that part

These other implementations are there for when we enable reflection-based animation, and will not be directly used. The trait was designed to support the immediate use case of skeletal/morph target animation, but not get in the way of a reflection based "animate anything" down the line. Handle<T> was primarily desirable for sprite and material swap animation.

there's no way we will have a skeleton with one Handle<T> per bone/joint or per vertex for a morph target. If we want the animation system to also account for Handle<T> animations then that's necessarily at a different, reduced scale, and then we can consider a different design. Here we're doing a generic approach mixing all scales.

As mentioned in the PR description, this PR only aims to introduce the trait, not dictate how it's integrated into existing components or systems. The current plan is to use this in conjunction with the animation graph presented in the composition RFC to enable composable skeletal/morph target animation, and that won't use implementations other than Vec3(A), Quat, and Transform, nor any form of dynamic dispatch.

Sorry for dragging that, I still don't understand how this trait is supposed to work with the current system in a way that's performant. I think the main red flag I have is impl Animatable for Quat (and Vec3), which hints at a "one call per translation/rotation/scale value".

That is exactly what Animatable::blend is. Note how it has no self argument of any kind, it takes a iterator of BlendInputs, and there's zero use of dynamic dispatch within any of it's implementations. It's meant to be a way to gather a weighted blend of inputs from an iterator, which can be sourced from a cache-friendly data-oriented data store.

I was writing an answer with pseudo-code and I think I understood what's going on. You intend blend() to be called once with the entire collection of all Transform from all sources, including all animations being blended, possibly from different animation roots, is that correct? That is, ideally, you intend <Transform as Animatable>::blend() to be called exactly once per frame, no matter how many animations from how many graphs are being animated. Did I get that right?
Assuming this is the case, this is a lot better than I thought, thanks for your patience! I do have a couple of remarks though for performance:

The layout of BlendInput<T> is not great, and becomes worse the bigger T is and the higher its alignment is. I think the type will always have padding, no matter what T we use (assuming at least 4 bytes like f32, because it's unlikely we'll blend some u8). This will waste some space on the CPU cache and increase cache misses. I think it would be best to tightly pack the T values, and tightly pack the weight values (so struct of arrays, instead of array of structs). Reading from 2 different arrays in a hot loop is not too bad perf-wise if the loop is long enough.
The additive per BlendInput forces the if check to be inside the hot loop. I think this is bad, given you will likely have sequences of 64~256 transforms (bones/joints) with the same constant value, then comes the data for another animation which changes that. I'd try to find a way to move that if outside the loop. Maybe we need 2 loops, one for additive blend and one for non-additive one. Or maybe we need to replace a single flat iterator with a nested one (iterate over batches, which can be additive or not, and each batch has a {value + weight} pair only, inheriting the additive-ness from the batch itself).

The Vec3A, Vec4, and Transform implementations all rely on glam's built in SIMD acceleration. The Vec3 implementation is specialized to use Vec3A's since it's likely to improve performance, even when unaligned.

Fair, but the Vec3 doesn't (even thought there's probably no SIMD in glam for that) and neither does the Quat one. Given that it's likely more performant and space-effective to split Transform animation by tracks/curves along each translation/rotation/scale (plenty of animations have unit scale for example, this is a big waste to blend thousands of Vec3::ONE) I expect impl Animatable for Quat to be one of the most used code of the entire PR (for skeletal animation), closely followed by impl Animatable for Vec3/A, and impl Animatable for Transform be marginal for those very complex animations that animate all of translation/rotation/scale at once (but even then we could split the processing).

Is there another SIMD operation that I'm missing here that would help that is not being included in that loop?

It's not a clear cut to me that {load + lerp + store} in SIMD is faster than lerping on CPU. This definitely used to be false, although more recent architectures are tremendously faster at load/store. In any case, this probably needs 1) removing the if from the middle as previously mentioned, and 2) possibly unrolling the loop manually (say, 4 times, to keep SIMD registry use low) to pipeline the loads/stores. That way I think this can become a win over pure CPU. Another trick that unrolling 4 times helps is loading 4 Vec3 tightly packed in memory into 3 registers directly without CPU copy (48 bytes), shuffling to convert to Vec3A directly inside the SIMD registers, then blend and do the opposite to store back to CPU. I don't think the compiler would be able to do that directly from the current code, it will likely have to copy the Vec3 into a stack-allocated Vec3A, load that (so 4 loads instead of 3) and then on store do yet another copy from Vec3A to Vec3. All of that needs to be profiled obviously.
Ok so overall I don't have any more concern performance-wise provided this PR allows the above suggestions to be implemented in the future (or proven they're not needed). This means that my last blockers I think would be:

That Quat::interpolate() implemented manually (although, see remark below, could be ignored for now and fixed in a later PR, it's just that this looks like a reimplementing of glam)
The rotation blend in Transform::blend() that I find pretty dodgy. Maybe I got the maths wrong but weighting Quats looks incorrect. The glam implementation of impl Mul<f32> for Quat clearly casts the Quat to Vec4 so doesn't interpret it as a rotation in any way. And scaling all components of a Quat as far as I know produce nothing that looks like a rotation.
The per-value additive and the if inside the hot loop, and the layout of BlendInput, which we can't really change once the PR is merged without breaking everything.

We can optimize the individual Animatable implementations later.

I don't have much to add to the review other than what @rodolphito said, looks good otherwise.

There's a bigger problem with switching to nlerp i've discovered: Glam's nlerp is not commutative, nor can it easily be made commutative. This is because it is normalizing after interpolating, which makes sense for blending two quaternions, but it also means that its no longer a truly linear operation. To commutatively blend an arbitrary number of quaternions, one would need to defer the normalization til the very end. This is problematic however because the intermediary values are not true rotation quaternions because they are not unit length. We'd want to encode this in the type system somehow. I think it can be done with a PR to glam, but it might be contentious as it adds complexity and would need some extra implementations. There would need to be a DenormalizedQuaternion type that implements Into<Quaternion>, and have specialized lerp methods that take combinations of DenormalizedQuaternions and Quaternions to linearly interpolate them. Then at the end it would be silently normalized and converted into a Quaternion as soon as it gets used.
For this reason I am opting to leave slerp in for the moment, because this would need further discussion and upstream work in glam.

I've realized there actually is a simpler way forward that can be implemented now without changes to glam.

BlendInput says additive determines "Whether or not to additively blend this input into the final result" which is actually not what its doing. Additive BlendInputs are being applied in the order they are given in the blend stack, meaning if a non-additive BlendInput is present after an additive one, the additive one is not blended into the final result as claimed. This will look wrong and be unintuitive, compared to most animation solutions ive worked with

@rodolphito I've been told that what this PR does actually matches what Unity does. In Unity override layers cancel out the results of previous additive layers.

For posterity, the discussion that led to this being merged can be found here: https://discord.com/channels/691052431525675048/774027865020039209/1202358388466384956


Deleting a Bone2D that is referenced by a PhysicalBone2D crashes the editor

Godot version
4.0.3 stable
System information
Godot v4.1.beta1 - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.14057.2005) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
Issue description
Deleting a Bone2D that is associated with a PhysicalBone2D crashes the editor.
However, if you go and remove the reference to the Bone2D from the PhysicalBone2D and try to delete the Bone2D, it still crashes the editor.
Expected behavior would be that deleting the Bone2D would just reset the PhysicalBone2D to a null reference.

Steps to reproduce

Load the attached project
Delete this bone

Godot crashes

Minimal reproduction project
ragdoll-tests (2).zip

I think this might have something to do with it, if that helps. I can't change the Bone 2d Index back to -1, it won't let me, just gets stuck on 0


[Bug]: dbt metadata and files bundles point to different location for profiles

Meltano Version
All
Python Version
NA
Bug scope
Other
Operating System
All
Description
The metadata for some number of dbt plugins doesn't accurately represent what will be installed when the files bundle is loaded.
https://github.com/meltano/hub/blob/main/_data/meltano/transformers/dbt-bigquery/dbt-labs.yml#L20-L22 for example points to $MELTANO_PROJECT_ROOT/transform/profiles/bigquery but the actual file is in https://github.com/meltano/files-dbt-bigquery/tree/config-version-2/bundle/transform/profile  which is just $MELTANO_PROJECT_ROOT/transform/profile.
Each setting for the plugin-specific adapters should be reviewed alongside their file bundle.
This was reported in Slack  by @astrojuanlu
Code
No response

Hi, @cjohnhanson. Thanks for picking this up.
The correct location of the profiles directory would be the adapter-specific profile folder. So, $MELTANO_PROJECT_ROOT/transform/profiles/bigquery would be the correct location for bigquery.
This is because dbt doesn't allow pointing to a specific file, and we would want to ensure conflicting profiles don't clobber or conflict with each other.

@aaronsteers @tayloramurphy FYI it looks like this is because the default branch for this repo was at some point changed from master to config-version-2. The path is correct in master, but since the pip url for the repo would just get the default branch, it's getting that incorrect version in that old branch.
@WillDaSilva, @pandemicsyn, or @edgarrmondragon -- it looks like I don't have permissions to change the default branch in the dbt-bigquery repo. Do any of you have ownership of that? If so, could you either give me ownership or change the default branch back to master? That should resolve the issue here.

@cjohnhanson I have updated the default branch to be main, which points to the same commit as master.

After the branch is changed, what would be the best way to amend the local filesystem for an existing project? (In other words: is there an alternative solution to "just delete everything and start from scratch"?)

@astrojuanlu unfortunately I don't think there's a simple automated solution for correcting an existing project. I think you'll need to manually change the file paths (e.g. something like mv $MELTANO_PROJECT_ROOT/transform/profile $MELTANO_PROJECT_ROOT/transform/profiles/bigquery).

config-version-2 was introduced when dbt version 0.17.0 was launched https://docs.getdbt.com/guides/migration/versions/older versions/upgrading-to-0-17-0#using-config-version-2 It's not clear to me if we still need to support config-version-1 and can just point everything to main. Especially considering the adapter-specific configs are mainly for 1.0 I think we're okay to just point everything at main. @aaronsteers anything I'm missing there?

@tayloramurphy FWIW all of the other adapter-specific file bundles point to main

Confirmed it works now 👍🏽


Add azure monitor opentelemetry distro

Distro is a convenience package that will install azure monitor related components for monitoring solution.

Discussed offline with @lzchen - we don't want to do a meta package at this time. Closing this for now.


prep-1.0: How to set an initial value for ui-dropdown lists?

I'm using the ui-dropdown module to display a selection. How can I set a certain entry to be active/selected? In my case settings.user.currentLanguage would map to language.code.
{{#ui-dropdown  class="selection"
                value=settings.user.currentLanguage
                onChange=(action "changeI18nLanguage")}}

{{t "settings.language"}}

  {{#each availableLanguages as |language|}}

      {{language.name}}

  {{/each}}

{{/ui-dropdown}}

I just added an initialization method onto ui-dropdown that will set the original selection based on the value you pass in (value=settings.user.currentLanguage as seen above.)
See 6c8929832c099af6f30a5f95fdbf3f400bd26be1 or just pull down the latest.

I see. It's working. Thanks!


update README for Some API

Update README to account for Monapt.Some as a class.

So sorry for the delay on this!


Rename up_squared_adsp to intel_adsp_cavs15

The Audio DSP is not specific to up_squared, so make it more generic.
Also removes stray file.

@plbossart FYI

This PR (patch 2 specifically) breaks APL / cAVS1.5 builds in some not immediately obvious way. I'll try to figure it out, please, wait with merging

this?
/home/nashif/zephyr-sdk/xtensa/intel_apl_adsp/xtensa-zephyr-elf/bin/xtensa-zephyr-elf-objcopy: /home/nashif/Work/zephyrproject/zephyr/build/zephyr/zephyr.elf.mod: warning: empty loadable segment detected at vaddr=0, is this intentional?
/home/nashif/zephyr-sdk/xtensa/intel_apl_adsp/xtensa-zephyr-elf/bin/xtensa-zephyr-elf-objcopy: /home/nashif/Work/zephyrproject/zephyr/build/zephyr/zephyr.elf.mod: warning: empty loadable segment detected at vaddr=0, is this intentional?
/home/nashif/zephyr-sdk/xtensa/intel_apl_adsp/xtensa-zephyr-elf/bin/xtensa-zephyr-elf-objcopy: BFD (crosstool-NG <IP_ADDRESS>-3f461da-dirty) 2.32 internal error, aborting at /home/buildslave/src/github.com/zephyrproject-rtos/sdk-ng/build/build_xtensa_intel_apl_adsp/.build/xtensa-zephyr-elf/src/binutils/bfd/elf.c:7164 in rewrite_elf_program_header
/home/nashif/zephyr-sdk/xtensa/intel_apl_adsp/xtensa-zephyr-elf/bin/xtensa-zephyr-elf-objcopy: Please report this bug.

@nashif I'm getting this:
/usr/local/src/project/51/src/zephyr-andyross/modules/audio/sof/src/schedule/timer_domain.c:33:2: error: #error "Zephyr uses 19.2MHz clock derived from SSP which must be enabled."
   33 | #error "Zephyr uses 19.2MHz clock derived from SSP which must be enabled."
      |  ^~~~~
[164/238] Building C object modules/sof/CMakeFiles/modules_sof.dir/usr/local/src/project/51/src/zephyr-andyross/modules/audio/sof/src/audio/pipeline.c.obj
ninja: build stopped: subcommand failed.

@lyakh can you check if you have the name of the board hardcoded somewhere in your tree?

@lyakh are you reproducing this on the Zephyr master branch or some other tree?

@lyakh are you reproducing this on the Zephyr master branch or some other tree?

@andrewboie to test SOF I need additional patches, so, I took the SOF-integration tree from @andyross, which works as is, and applied these patches on top


How does hunspell works

I looked for a paper which explains how does hunspell works, but without any success. I would like to know how does hunspell works and especially how does it make suggestions ? Does it uses Levenshtein distance to look for the best suggestion ?

See hunspell, and mainly their docs, for info on that: https://github.com/hunspell/hunspel.
This isn't the place for help with hunspell though!


C# HttpClient

Hi,
It looks like only RestSharp is here for C#. HttpClient is in the .NET standard library and is the standard way to make HTTP requests (without a third party library like RestSharp).
If there is no ongoing work to add HttpClient, I can PR to add a snippet for HttpClient.
Thanks.

Would gladly welcome this, thanks @johnsabr.

Any news for adding C# HttpClient?, Thank you.


DateHeader component dont't pass any "timelineUnit" props

Describe the bug
I am trying to build a feature Daily and Weekly sorting.
I am facing an issue when I used DateHeader Component. It has a unit props for updating the DateHeader component. For Example:- when I selected 'weekly' then DateHeader got a unit="week" but the timeline does get updated, only the DateHeader component gets updated.
Then I researched more about it and found timelineUnit props but there is no description about the  timelineUnit props in the documentation. Please give a better solution to my problem.
To Reproduce
Steps to reproduce the behavior:

Go to 'Timeline page'
Click on ' weekly sorting'
only update DateHeader
not update timeline

Expected behavior
When I select to weekly then my timeline also updaed with dateHeader
Screenshots
when I select the weekly

only update the dateheader not a timeline

Desktop (please complete the following information):

Browser [Chrome]

@awesomearpit could you please create a codesandbox example with your bug please


Code Review Comments/Suggestions

Plenty up for debate, obviously.  I've been relatively forthright with the changes, if people think stuff needs winding back then lets discuss here.  Tried to split everything in to separate commits to make things easier.

Just wondering about moving to 1.8. Why that choice?

I think both 1.6 and 1.8 are legitimate choices.  1.8 is good because it's the current release (and allows us to show things like tryWithResources on the CacheManager.  1.6 is also good because thats the base level compatibility for Ehcache itself.  So I think we should move away from 1.7, but I'm open to moving in both directions.


Remove lotus-helpers dependency from Gemfile.tt

Related to https://github.com/lotus/lotus/issues/165.
Removed dependency from the Gemfile so that it is only in the gemspec.
Only issue is that the tests will not run at the moment because it cannot find lotus-helpers (~> 0.1) ruby
cc/ @jodosha @joneslee85

:+1:

@jodosha can you please push 0.1.0 to rubygems.org? cheers

@tomkadwill I think that the content of #182 should be added here, to complete this PR and makes CI green.


[SSR] Watch out for code order between find() and subscribe()

I just ran into a subtle bug with SSR, it's not really an issue but I thought I'd make a note of it in case somebody else has the same problem.
On the client (inside a reactive context such as getMeteorData()), both of these do basically the same thing:
Meteor.subscribe("myPublication");
const data = Posts.find().fetch();
return {posts: data};

and
const data = Posts.find().fetch();
Meteor.subscribe("myPublication");
return {posts: data};

Since the context is reactive, it doesn't matter if you do the find().fetch() first or subscribe first, because find().fetch() will rerun a second time once the subscription is ready anyway.
But when running on the server the order does matter! If you call fetch() before subscribe(), there won't be any data in Posts (since FlowRouter SSR only makes available data that you've “published” to simulate the client's state) and fetch() will return an empty array.
So make sure to always subscribe first.

Yeah! This is not a bug anyway :)
I think your PR to the README will address this.


Cannot resolve module 'leaflet/dist/leaflet.css'

**I'm submitting a bug
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

When I run the server (in dev mode or in production mode), I get a error that leaflet.css cannot be resolved. I assume that the title is enough to describe  the problem.
My environment:
Mac osx El capitan, node v4.4.4

@neposoft you need to update npm version, take a look here https://github.com/akveo/ng2-admin/issues/11 and here https://github.com/akveo/ng2-admin/issues/15


1.0 - PMO guide is missing canPlaceOrder property

I'll fix this.

Fixed in https://github.com/donejs/donejs/commit/47260e3ec65b3d2ab654efd853614b3b4d419385


Warped/Crimson Nylium Villager Trade

Is your feature request related to a problem?
I would like to be able to purchase some nylium
Describe the solution you'd like.
Both types of nylium to be added to a villager trade
Describe alternatives you've considered.
Possibly a crafting recipe for both nylium types, for example 1 netherack = 1 nylium or even 4:1
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other
No response

Perhaps you could suggest trade prices, name of the villager, location, should it be a brand new one, or added to a previous one etc

Added to Norah, The Warped


Document how to setup Yggdrasil

I couldn't find any steps regarding configuring Yggdrasil and adding the necessary peers to join our network. Yggdrasil official documentation is lacking as well so it would be nice to add more details.
An example for that is the documentation for Terrafrom provider: https://library.threefold.me/info/manual/#/manual3_iac/grid3_terraform/manual__terraform_caprover?id=pre-requisites. Which just declares it as a pre-requisite without providing more details or even pointing to the official documentation.
The necessary peers can be find here: https://github.com/threefoldtech/zos-config/blob/main/production.json

https://github.com/threefoldtech/info_grid/commit/449698b0d7dcddffba6bff25084df70dd9379bbb please let me know if anything needs to be updated

It's not added in the getting started menu

should be added here

you may find it here yggdrasil


Fixes #462 Refactor logout directive into controller

https://github.com/yunity/foodsaving-frontend/issues/462

Codecov Report

Merging #482 into master will increase coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #482      +/-   ##
=========================================
+ Coverage   98.54%   98.6%   +0.05%
=========================================
  Files         207     206       -1
  Lines        2951    2932      -19
=========================================
- Hits         2908    2891      -17
+ Misses         43      41       -2

Impacted Files
Coverage Δ

client/app/components/home/home.js
100% <ø> (ø)
:arrow_up:

client/app/components/_topbar/topbar.controller.js
81.81% <0%> (-18.19%)
:arrow_down:

...upEditCreateForm/groupEditCreateForm.controller.js
85% <0%> (-0.72%)
:arrow_down:

...reEditCreateForm/storeEditCreateForm.controller.js
94.44% <0%> (-0.3%)
:arrow_down:

...p/_groupEditCreateForm/groupEditCreateForm.spec.js
100% <0%> (ø)
:arrow_up:

...e/_storeEditCreateForm/storeEditCreateForm.spec.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91e004...39b98d8. Read the comment docs.

Are you interested in adding a test as well? There wasn't one before, but now it's easier to write one :)
I would stub the Authentication.update method and test if the logout method successfully redirects to the login page. A similar test is in the login.spec.js in line 65, but this one is using a mock http backend instead of a stub.

Perfect! Will merge now!


apps: return non-zero status code for incomplete requests

This should make it easier to use quiche-client in scripts.

This change is a good one to make.
I think it would help to have a way to identify clearly if the connection handshake did not succeed at all vs. Connection opened and only some requests did not succeed. Can we have different status codes?
Siduck doesn't strictly care if the number of acks doesn't match the number of quacks. It is a lossy protocol after all. Perhaps to avoid noise by not marking it as fail?

@LPardue ok, that's actually slightly nicer to implement, PTAL.

Yeah, good point. Added error message, will merge once green.


docs(contributing): 📝 add more documentation for contributing

This should allow more people to contribute to this.

@Wyatt-Stanke Friendly ping on this--mind addressing the open comments on this PR or close this out? I'm trying to reduce the number of stale PRs. Thanks so much!

Hey! Sorry, I completely forgot about this PR! I will update!

I'll redo this and put it into a new PR since a lot has changed.


[refactor] Fetch data URL from stable JSON link tag instead of depending on HTML class names

Motivation
Reduce risk of plugin breakage as datasette evolves
Change

Currently, we get the JSON data for the page into the component, the same way datasette-vega does, we perform a search here

https://github.com/hydrosquall/datasette-nteract-data-explorer/blob/efc067a073f007cf3a1d5311ab79dde9f3876d10/frontend-src/main.tsx#L9

However, user-visible DOM structure is not a particularly stable API to develop against. It is safer to develop against the link tag instead. We should change the selector to query for this alternate URL.

https://docs.datasette.io/en/stable/json_api.html#discovering-the-json-for-a-page

TIL: querySelector API supports arbitrary CSS strings, no longer need to query elements just by ID

https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
You can use [attributeName="attributeValue"] when selecting by arbitrary DOM node attributes ( see https://stackoverflow.com/questions/5608808/css-style-a-link-based-on-its-rel-attribute )

Update: this API was only added in 61.1 as of this commit ( https://github.com/simonw/datasette/commit/3ef47a0896c7e63404a34e465b7160c80eaa571d
) . I should probably leave this issue alone until plugins have a way to specify which version of Datasette they require for correct behavior (perhaps related to https://github.com/simonw/datasette/issues/1704 ). Otherwise, changing this API will lead to the plugin being unable to find the target element.
Motivation: I tried updating this for a local test, but my local datasette version was 0.60.2, so it wasn't able to find the expected element.

Reopening since this should be squared away once Datasette hits 1.0, and I can pin the plugin against a stable parent version.


bugfix:A class with private access constructors should not be loaded by SPI.

Ⅰ. Describe what this PR did
Fix a bug that will appear when the class has default private constructor
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1927 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #1927      +/-   ##
=============================================
+ Coverage      55.27%   55.27%   +<.01%
+ Complexity      2401     2400       -1
=============================================
  Files            428      428
  Lines          14219    14221       +2
  Branches        1664     1664
=============================================
+ Hits            7859     7861       +2
+ Misses          5658     5657       -1
- Partials         702      703       +1

Impacted Files
Coverage Δ
Complexity Δ

.../io/seata/common/loader/EnhancedServiceLoader.java
63.63% <100%> (+0.61%)
24 <0> (ø)
:arrow_down:

...in/java/io/seata/server/session/GlobalSession.java
84.54% <0%> (-0.49%)
67% <0%> (-1%)

...o/seata/server/coordinator/DefaultCoordinator.java
48.01% <0%> (-0.4%)
27% <0%> (-1%)

...server/store/file/FileTransactionStoreManager.java
58.09% <0%> (+0.63%)
30% <0%> (+1%)
:arrow_up:

LGTM.

Thanks for your approval
I want to know Is there any  other conditions to pass this pr（Ask another person with authority to review?） Thank you for your help.

LGTM.

@xingfudeshi
Thanks for your approval
I want to know Is there any other conditions to pass this pr（Ask another person with authority to review?） Thank you for your help.

@jsbxyyx @xingfudeshi
all the checks and reviews passed,please merge into develop.


PostgreSQL and pgAdmin

pgAdmin III stores its configuration in the registry.
A mechanism to adorn the execution of putty.exe with registry backup and restore is needed.

Depends on #17 and #18

Resolved with 94fdcfa6165c0758b8a9d4a70c79c5739b1e9752


Data Factory: Add try to vnet integration block

Issue-id
PR Checklist

[ ] I have added example(s) inside the [./examples/] folder
[ ] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description
Data Factory Integration Runtime Azure SSIS' "vnet_integration" dynamic block requires all four attributes to be passed, however Terraform permits all four as optional.
Additionally, Terraform states that only "subnet_id" or "subnet_name" can be specified - not both.
This PR allows all four attributes to be optional rather than forced - allowing the resource to be deployed successfully.
Does this introduce a breaking change

[ ] YES
[x] NO

Testing

thanks for your contribution to CAF @adamcaino!


Rename TESTING to TESTING.md

The content is obviously markdown (use of the link syntax).
Additionally, GitHub currently formats it badly by showing the whole text on a single line.

Additionally, GitHub currently formats it badly by showing the whole text on a single line.

The purpose of the TESTING file is to instruct document the testing procedure for potential contributors. Since it isn't possible to edit, run and test the code in GitHub, this doesn't matter.
Is there some other compelling reason to rename the file? If I decide to change the formatting to something else, such as restructured text, it would be nice if I didn't have to rename the file. A file extension isn't really necessary anyways, particularly for a human readable file such as this.

The purpose of the TESTING file is to instruct document the testing procedure for potential contributors. Since it isn't possible to edit, run and test the code in GitHub, this doesn't matter.

I did try to read it on GitHub.

I'm sorry, I'm closing this as WONTFIX. It just seems so trivial.
On Wed, May 18, 2016 at 08:50:55AM -0700, Valentin Lorentz wrote:

The purpose of the TESTING file is to instruct document the testing procedure for potential contributors. Since it isn't possible to edit, run and test the code in GitHub, this doesn't matter.

I did try to read it on GitHub.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/uiri/toml/pull/46#issuecomment-220070945


Add various tweaks and improvements to CSV parsing

Redirect when no session data after bulk upload
case-insensitive email look up
Move csv parsing to util.py, add test
Move verification to util.py, add tests
Ensure data structure from csv parsing is json-serializable

Thanks @sburns - @pbanaszkiewicz can you please review and then merge if you think it's good? This and logins and we're ready to deploy.

Thanks @sburns!
@gvwilson I'll review as soon as learn some phase portraits, which should be in about hour.

Hey @sburns,
this PR looks okay. Mostly I need you to fix these small errors and ensure they don't pop out anymore. Tests don't catch them, so we need some tests to test this part of the code.
Other than that there are only some minor improvements to test suite.
Cheers,
Piotr

[ ] switch to django's json dumps
[ ] squeeze basic parse test into equal sets
[ ] explicit newline in test csv string
[ ] generate BulkPersonAddTemplate.csv dynamically using PERSON_UPLOAD_FIELDS as columns.
[ ] show useful error message for KeyErrors in upload_person_task

@pbanaszkiewicz I think I hit everything, let me know?

@sburns thanks a lot! I'll check this out tomorrow and let you know.

@sburns as part of the code review I found three bugs (including the bug with unicode that I commented in https://github.com/swcarpentry/amy/pull/165#discussion_r23617908).
All three are basically bugs in my original code, and I have fixed them to make sure the code's working, so I'll simply send you a PR so that you can update this PR with our code.
When it comes to your latest additions to this PR, I'm really happy with your code.
To sum up: thank you for your updates and tests. They're great. I'll now send you a PR, so you can merge it and then this PR (#165) should update automatically. Finally we'll be able to successfully merge this PR (#165) into the master branch.

@sburns: here you go https://github.com/sburns/amy/pull/1.
It took longer that I anticipated :/ but there should be less errors now.

Merged, thanks @pbanaszkiewicz. @gvwilson I think this is ready to go.

Okay, on the permission given me by @gvwilson in https://github.com/swcarpentry/amy/pull/165#issuecomment-71377130 I shall merge.


REST API can create task but won't add GCP cloud storage to it

Expected Behaviour

Based on the commit found here.
I am able to create a new cloud storage by sending a POST request to http://:/api/cloudstoreages with the following command body:
{
  "provider_type": "GOOGLE_CLOUD_STORAGE",
  "resource": "my_bucket",
  "display_name": "My Bucket",
  "credentials_type": "KEY_FILE_PATH",
  "key_file_path": "/credentials/gcs.json",
  "specific_attributes": "region=US-EAST1",
  "manifests": ["test_manifest.jsonl"]
}

Then I should be able to create a new task with that cloud storage attached by sending a POST request to http://:/api/tasks the following body:
{
  "name": "Test Task",
  "project_id": 1,
  "chunk_size": 1,
  "image_quality": 70,
  "server_files": [
     "test/img1.jpg",
     "test/img2.jpg",
     "test/manifest.jsonl"
  ],
  "cloud_storage_id": 1,
  "use_zip_chunks": true,
  "use_cache": true
}

Current Behaviour

With my requests the cloud storage is created and the manifest is attached. I am able to manually create a labeling task with data from this new cloud store, but when I try to use the API a task is created with no dataset attached. I can go to the tasks page and see a new task is there but there are no images and no jobs attached to it.
I have tried the POST request with "remote_files" and "client_files" instead of server files with no change in result as well as manually creating the task and trying to use a PATCH request to update an existing task with more photos.
When I then go inspect the status of the newly created task at http://:/api/task//status, I see the following error
{
    "state": "Failed",
    "message": "FileNotFoundError: [Errno 2] No such file or directory: '/home/django/data/storages/1/test/manfiest.jsonl'",
    "progress": 0.0
}

I went into the docker container and manually added the test files, both manifest and images into the directory from the error above and the request then worked.
Why is this searching a directory within the docker container for files and not the cloud storage?
Context

I need to use the API to add new labeling jobs as new photos are collected.
Your Environment

Using the following CVAT versions:
Server version: 2.1
Core version: 5.0.1
Canvas version: 2.13.2
UI version: 1.37.0
Interacting with the API using python requests library in python 3.7.

Push! This happened to me, too

@Marishka17 , could you please look?


chore: Expose render.renderer.RendererBaseT and do not require | None when defining Renderer types

(Merging early)


White background at chat enable/disable

Hi!
I really appreciate your work. Saves me from getting strokes. Enjoying it to the fullest. Thanks a lot.
There is this white background, which seems off, at the place where the room chat is enabled/disabled.

That option is limited to just G Suite users (Google support link), and I do not have any G Suite for Education account that I can use for creating meetings, so I won't be able to fix this unless someone else made a pull request with the fix. Alternatively, if you know the html class for that element, I should be able to fix it.

That option is limited to just G Suite users (Google support link), and I do not have any G Suite for Education account that I can use for creating meetings, so I won't be able to fix this unless someone else made a pull request with the fix. Alternatively, if you know the html class for that element, I should be able to fix it.

I understand.
I think I can help with finding the html class. The following seems to be the code that is specific to that element. Please feel free to ask for more code if necessary.

Let everyone send messages

<input jsname="YPqjbf" jsaction="focus:AHmuwe; blur:O22p3e; change:WPi0i" type="checkbox" class="VfPpkd-e9dDuf-bMcfAe" role="switch" aria-label="Let everyone send messages" checked="" aria-checked="true">

I understand.
I think I can help with finding the html class. The following seems to be the code that is specific to that element. Please feel free to ask for more code if necessary.

Let everyone send messages

<input jsname="YPqjbf" jsaction="focus:AHmuwe; blur:O22p3e; change:WPi0i" type="checkbox" class="VfPpkd-e9dDuf-bMcfAe" role="switch" aria-label="Let everyone send messages" checked="" aria-checked="true">

The code for the switch seems to be the following.
<input jsname="YPqjbf" jsaction="focus:AHmuwe; blur:O22p3e; change:WPi0i" type="checkbox" class="VfPpkd-e9dDuf-bMcfAe" role="switch" aria-label="Let everyone send messages" checked="" aria-checked="true">

The code for the switch seems to be the following.
<input jsname="YPqjbf" jsaction="focus:AHmuwe; blur:O22p3e; change:WPi0i" type="checkbox" class="VfPpkd-e9dDuf-bMcfAe" role="switch" aria-label="Let everyone send messages" checked="" aria-checked="true">

Create a new style and add this to it and let me know if that changes the color of the white background.
@-moz-document domain("meet.google.com") {
    .WAPtFd.jE2Fge {
        background-color: #202124;
    }
}

Create a new style and add this to it and let me know if that changes the color of the white background.
@-moz-document domain("meet.google.com") {
    .WAPtFd.jE2Fge {
        background-color: #202124;
    }
}

Yes, it changes the color of the white background. Although the text is black, when the publicly released version is added, it looks as one would expect.
No style:

Style with the code in previous comment:

Publicly released style + style with the code in previous comment:

Yes, it changes the color of the white background. Although the text is black, when the publicly released version is added, it looks as one would expect.
No style:

Style with the code in previous comment:

Publicly released style + style with the code in previous comment:

I just realized I could copy and paste the html you sent earlier and add it to the page to test it myself. This is what it looks like now.

Anyways, for making the issue report, I'll publish the changes shortly.

I just realized I could copy and paste the html you sent earlier and add it to the page to test it myself. This is what it looks like now.

Anyways, for making the issue report, I'll publish the changes shortly.


Allow serving of offline segments immediately/inclusively.

Description
Today, Pinot serves queries to Hybrid tables by applying a time filter
based on data availability. For example, when the most recent offline
segment is for 1/2/2000, and a query has no time filter, then the broker
queries the offline table for * - 1/2/2000 (exclusive), and the realtime
table with 1/2/2000 (inclusive) - *.
This means that when you upload a new offline segment, it technically
doesn't begin to be served by the broker until another offline segment
pushes the watermark higher.
This change permits a new config which tells the broker to immediately
start serving offline segments once available; or in other words, to
query the offline table with the most recent time value inclusively.
Upgrade Notes
New feature is entirely opt-in and should not require downtime to enable.

@ianvkoeppe I am unclear on the PR description:

The first offline segment should immediately push the high-water-mark.
Your requirement seems contrary to the other requests we are getting, where the high-water-mark being pushed up pre-maturely (before all segments from the new date are ONLINE) causes inconsistent results during the push time. And we are getting multiple requests to address the inconsistency by deferring the push of high-water-mark until the entire push is complete.

This is a fantastic contribution!

@mayankshriv, thanks for reviewing. See answers inline below.

The first offline segment should immediately push the high-water-mark to (maxTime-1). Are you referring to a case with single segment push per day?

Yes, this is for cases where there is a single segment push per day.

Your requirement seems contrary to the other requests we are getting, where the high-water-mark being pushed up pre-maturely (before all segments from the new date are ONLINE) causes inconsistent results during the push time. And we are getting multiple requests to address the inconsistency by deferring the push of high-water-mark until the entire push is complete.

This sounds like the current supported case. In our case, we have a Hybrid table where we serve current day metrics from realtime and once per day upload an offline segment. The issue is, since we only upload one segment per day, the latest offline segment isn't used until the next day's data is pushed.
Today we get around this by creating "dummy" segments with empty rows and +1 day as a way of forcing the time value to increment further and serve the latest actual offline segment. Unfortunately, this won't work for us any longer and we need a better long-term solution.
I hope this clarifies, but let me know if you have any further questions.

@mayankshriv, thanks for reviewing. See answers inline below.

The first offline segment should immediately push the high-water-mark to (maxTime-1). Are you referring to a case with single segment push per day?

Yes, this is for cases where there is a single segment push per day.

Your requirement seems contrary to the other requests we are getting, where the high-water-mark being pushed up pre-maturely (before all segments from the new date are ONLINE) causes inconsistent results during the push time. And we are getting multiple requests to address the inconsistency by deferring the push of high-water-mark until the entire push is complete.

This sounds like the current supported case. In our case, we have a Hybrid table where we serve current day metrics from realtime and once per day upload an offline segment. The issue is, since we only upload one segment per day, the latest offline segment isn't used until the next day's data is pushed.
Today we get around this by creating "dummy" segments with empty rows and +1 day as a way of forcing the time value to increment further and serve the latest actual offline segment. Unfortunately, this won't work for us any longer and we need a better long-term solution.
I hope this clarifies, but let me know if you have any further questions.

I see, the single segment per day clarifies the confusion. There's also a new api being added in the controller that makes it a protocol. Perhaps you could piggy-back on it to update time-boundary? @snleee What do you think?
https://github.com/apache/incubator-pinot/pull/5712

There's also a new api being added in the controller that makes it a protocol. Perhaps you could piggy-back on it to update time-boundary? @snleee What do you think?

#5712

Subbu mentioned this functionality might be possible via the controller in the future. I have just a couple concerns with that approach.

We are planning to build a reporting pipeline within an execution environment where we may not have the flexibility or control to configure jobs which call the controller. Pinot segment creation, upload, etc. is all abstracted away.
Managing the time boundary ourselves might be error prone since it means we have to have custom code to track our latest successful job runs and update the time boundary correctly afterwards. I'm worried about maintaining a custom job step that could potentially update the time boundary incorrectly, or having to think about how we'd rollback an update if we wanted to delete a badly pushed segment.

I'm interested to hear your thoughts on these.

@ianvkoeppe this is definitely a good feature to have.  However, the solution is too restrictive and we generally prefer table level config (for multi-tenancy).
Can you please create an issue to discuss high level requirements and solution.
My requirements

should be configurable per table. Have something like timeBoundaryUpdateStrategy which will allow us to add more strategies. RoutingConfig is probably the right place
An explicit API to update the time boundary for the table. This can be handy where users can call the API after all the segments are uploaded for a day.

@ianvkoeppe can u please create an issue first? It is better to agree on an implementation strategy in an issue. In case of external API changes, let us define the APIs clearly in a doc so that we can all comment on it.

@kishoreg and @mcvsubbu I've created this issue: https://github.com/apache/incubator-pinot/issues/5751. I've described the problem statement and a couple potential approaches. Let's discuss there.


Allow FileDescriptorSets in place of individual .proto files

Most protocol buffer and gRPC projects that I have seen involve many proto files that typically exist outside of the client codebase. These large sets of proto files can be compiled into a file descriptor set:
protoc -I . --descriptor_set_out=descriptor-set.bin foo.proto

These descriptor sets can then be consumed during the protoc code generation process with --descriptor_set_in:
mkdir codegen_dir
protoc --descriptor_set_in=descriptor-set.bin --java_out=codegen_dir foo.proto

Rather than having to include many *.proto files, it would be cleaner (IMHO) if we could use a descriptor set. Example:
sources:
  - name: MyGrpcApi
    handler:
      grpc:
        endpoint: localhost:50051
        protoFilePath: foo.proto # this will still be needed to identify which proto definition in the descriptor set should be used.
        fileDescriptorSet: descriptor-set.bin
        serviceName: Example # maybe this isn't needed
        packageName: io.xtech.example # maybe this isn't needed

Adding a possible scenario to this feature request, it could be feasible for a single descriptor set to be passed in and all of the services contained in it automatically added without having to specify the descriptors within it. :thinking:

Sounds cool! Do you think you can create a PR so we can merge it and release a new version with this feature?

I'll work on it. Been reading up on how to do it and there might be a potential showstopper.
In order to convert a FileDescriptorSet into a Root object (used by graphql-mesh), we'd need to use the descriptor extension.
Then we'd need to set the packageDefinition variable using createPackageDefinition from grpc/grpc-node. Unfortunately, that function is not exported and https://github.com/grpc/grpc-node/issues/550 was closed.
Looks like others have opened up issues on protobuf.js (https://github.com/protobufjs/protobuf.js/issues/1117). I'll keep digging and code up a sample PR if I can.

Okay, I shifted gears and am starting with reflection support. I did fiddle with using statically generated descriptor sets, but was having some trouble with decoding them.
Check out https://github.com/Urigo/graphql-mesh/pull/1086. Once reflection is working. It shouldn't be too hard to also support file descriptor sets.

gRPC handler supports FileDescriptorSets;
https://github.com/Urigo/graphql-mesh/blob/master/packages/handlers/grpc/yaml-config.graphql#L18


license?

Hello, thanks for putting this together :)
Sorry if there's a license somewhere, but I wasn't able to find one.
Would you be up for adding a LICENSE file? For purely selfish reasons, I'd appreciate if it were permissive (e.g. Apache, MIT), but GPL would be better than nothing :)
Thanks again

Hello @zdog234,
I have added an MIT license for this project, thank you for your issue.
Is it ok?

looks good to me! Thanks :)


Could not find gem 'jekyll-rdf (>= 0) ruby'  in source …

I get the following error, when I try to run jekyll with jekyll-rdf on my system:
/usr/lib/ruby/vendor_ruby/bundler/resolver.rb:357:in `resolve': Could not find gem 'jekyll-rdf (>= 0) ruby' in source at ../. (Bundler::GemNotFound)
Source does not contain any versions of 'jekyll-rdf (>= 0) ruby'
	from /usr/lib/ruby/vendor_ruby/bundler/resolver.rb:164:in `start'
	from /usr/lib/ruby/vendor_ruby/bundler/resolver.rb:129:in `resolve'
	from /usr/lib/ruby/vendor_ruby/bundler/definition.rb:193:in `resolve'
	from /usr/lib/ruby/vendor_ruby/bundler/definition.rb:132:in `specs'
	from /usr/lib/ruby/vendor_ruby/bundler/definition.rb:177:in `specs_for'
	from /usr/lib/ruby/vendor_ruby/bundler/definition.rb:166:in `requested_specs'
	from /usr/lib/ruby/vendor_ruby/bundler/environment.rb:18:in `requested_specs'
	from /usr/lib/ruby/vendor_ruby/bundler/runtime.rb:13:in `setup'
	from /usr/lib/ruby/vendor_ruby/bundler.rb:121:in `setup'
	from <my home>/.gem/gems/jekyll-3.1.3/lib/jekyll/plugin_manager.rb:33:in `require_from_bundler'
	from <my home>/.gem/gems/jekyll-3.1.3/bin/jekyll:9:in `<top (required)>'
	from ../../install/bin/jekyll:23:in `load'
	from ../../install/bin/jekyll:23:in `<main>'

This might be due to the fact, that I've installed the gems to an install/ directory next to the source and have a local .gem directory in my home. But Could not find gem 'jekyll-rdf (>= 0) ruby'  in source … still looks strange ('jekyll-rdf (>= 0) ruby' instead of something like 'jekyll-rdf (>= 0)')
Maybe you can help me with this problem.

Does jekyll-rdf (0.0.0) appear when you run gem list | grep  jekyll-rdf? If not, you should reinstall jekyll-rdf into your local
gem directory.
On 28.04.2016 16:20, Natanael Arndt wrote:

I get the following error, when I try to run jekyll with jekyll-rdf on
my system:
|/usr/lib/ruby/vendor_ruby/bundler/resolver.rb:357:in resolve': Could  not find gem 'jekyll-rdf (>= 0) ruby' in source at ../.  (Bundler::GemNotFound) Source does not contain any versions of  'jekyll-rdf (>= 0) ruby' from  /usr/lib/ruby/vendor_ruby/bundler/resolver.rb:164:in start' from
/usr/lib/ruby/vendor_ruby/bundler/resolver.rb:129:in resolve' from  /usr/lib/ruby/vendor_ruby/bundler/definition.rb:193:in resolve' from
/usr/lib/ruby/vendor_ruby/bundler/definition.rb:132:in specs' from  /usr/lib/ruby/vendor_ruby/bundler/definition.rb:177:in specs_for'
from /usr/lib/ruby/vendor_ruby/bundler/definition.rb:166:in
requested_specs' from  /usr/lib/ruby/vendor_ruby/bundler/environment.rb:18:in  requested_specs' from
/usr/lib/ruby/vendor_ruby/bundler/runtime.rb:13:in setup' from  /usr/lib/ruby/vendor_ruby/bundler.rb:121:in setup' from /.gem/gems/jekyll-3.1.3/lib/jekyll/plugin_manager.rb:33:in
require_from_bundler' from <my  home>/.gem/gems/jekyll-3.1.3/bin/jekyll:9:in <top (required)>' from
../../install/bin/jekyll:23:in load' from  ../../install/bin/jekyll:23:in ' |
This might be due to the fact, that I've installed the gems to an
|install/| directory next to the source and have a local |.gem|
directory in my home. But |Could not find gem 'jekyll-rdf (>= 0) ruby'
in source …| still looks strange (|'jekyll-rdf (>= 0) ruby'| instead
of something like 'jekyll-rdf (>= 0)')
Maybe you can help me with this problem.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/DTP16/jekyll-rdf/issues/16

yes.
$ gem list | grep jekyll-rdf
jekyll-rdf (0.0.0)

I think there must be a typo somewhere, since it says 'jekyll-rdf (>= 0) ruby' in the error message.

Uhm. Can you please post your jekyll _config.yml here? Thx.
On 29.04.2016 10:57, Natanael Arndt wrote:

yes.
|$ gem list | grep jekyll-rdf jekyll-rdf (0.0.0) |
I think there must be a typo somewhere, since it says |'jekyll-rdf (>=
0) ruby'| in the error message.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/DTP16/jekyll-rdf/issues/16#issuecomment-215662815

It this one https://github.com/DTP16/jekyll-rdf/blob/d30cacb093015ec8522cbd830287382b7ad18daa/test/source/_config.yml I try to build your example.

Try to change line 23 to gems: [jekyll-rdf] and make sure you have
no Gemfile in the site's directory with something like this gem  'jekyll-rdf', :path => '../' this is just for running in our test env

Cool, just removing the Gemfile broad me quite a bit further, but still an error:
Configuration file: <my path>/_config.yml
            Source: <my path>/source
       Destination: <my path>/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
jekyll 3.1.3 | Error:  key not found: "jekyll_rdf"

Do you have something similar to this in your config?
jekyll_rdf:
     path: "simpsons.ttl"

Ok, sorry the path to the model was missing:
…
gems: [jekyll-rdf]

jekyll_rdf:
    path: "rdf-data/simpsons.ttl"


Bug in analytics service after rasa x upgrade

After upgrading to current version of rasa x (0.24.2) I experienced the followning exception when startin rasa:
ERROR:rasax.community.services.event_service:Caught an exception while consuming events. Will retry in 5 s. Traceback (most recent call last):   File "/usr/local/lib/python3.6/dist-packages/rasax/community/services/event_service.py", line 970, in continuously_consume     consumer.consume()   File "/usr/local/lib/python3.6/dist-packages/rasax/community/services/event_consumers/sqlite_consumer.py", line 37, in consume     origin=DEFAULT_RASA_ENVIRONMENT,   File "/usr/local/lib/python3.6/dist-packages/rasax/community/services/event_consumers/event_consumer.py", line 124, in log_event     self.analytics_service.save_analytics(data, sender_id=event.conversation_id)   File "/usr/local/lib/python3.6/dist-packages/rasax/community/services/analytics_service.py", line 333, in save_analytics     self.update_session_data(event)   File "/usr/local/lib/python3.6/dist-packages/rasax/community/services/analytics_service.py", line 343, in update_session_data     or event_timestamp - latest_session.latest_event_time > SESSION_TIMEOUT TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
I fixed it like this...
line 343 in analytics_service.py
if (

       not latest_session **or not latest_session.latest_event_time**

        or event_name == Restarted.type_name
        or event_timestamp - latest_session.latest_event_time > SESSION_TIMEOUT
    ):

I think the whole problem was just about mounting an older version of rasa model to this newly created container. Can you confirm that this would make sense?

Mhm, actually that does not make sense 🤔 Which database are you using and are you using the default Rasa X image?

well not using the default image; as shown above I install rasa x in docker. By "database" you mean the backend? That would be just files - as that is the default

well not using the default image; as shown above I install rasa x in docker. By "database" you mean the backend? That would be just files - as that is the default

Ok, that means it's using the sqlite database.
We can definitely fix that in the code 👍 Not sure why this is happening, did you have any weird code or restarted the container in between weird time? Can you try to re-run the container with a --force-recreate.

Thinks to remember for the solution:

_create_new_session does not need a commit
latest_event_time should have a default value


Add icon and .desktop file

Is your feature request related to a problem? Please describe.
Maybe you can add and logo to the program,and add a .desktop file in the Linux package.

Thanks for the feedback! In my plan, executables and installers for the three major operating systems Linux, MacOS and Windows will be supported, such as: .deb, .rpm, .AppImage, .dmg, .pkg, .exe & installer.exe...
This requires an overall planning and design that includes:

determining the supported package formats;
technology selection for cross-platform compilation and packaging;
unification and reuse of resource directories, etc.;
the Github Actions workflow development;

The above requirements will be completed in multiple issues, so this issue is only one of them. Of course, you can also not consider so much, starting with support for Linux desktop icons.
If you are interested, please feel free to submit a Pull Request, or more development guidance/suggestions.


Fix onDidChangeStatuses of null error

When working in a folder without a git project (for instance when modifying system files), this package throws an error Cannot call onDidChangeStatuses of null.
This is because atom.project.getRepositories() returned an array with [null].
So running flatMap on this will still try to run onDidChangeStatuses to listen for these change events on a null repository.
This fixes this issue by returning only the save observable if repositories[0] is falsey.

Thank you very much!
I’ve meant to fix this for quite some time now, but I got caught up with other work, and didn’t spend time to finally fix this. Thank you again!

@dtinth what is the eta on bumping versions for APM?
Is the general idea to have this merge back into the original yuno-commit?

I forgot to bump!
Thank you for reminding me.


[Feature] - Linking library with application in Angular Multi Project Workspace by src path instead of dist/path - for hot reloads

Command
generate
Description
Currently, when you create a multi-project workspace with a library and application. To view the library changes you have first do ng build my-lib --watch and then ng serve. This is a bit clunky.
$ ng new base-workspace --no-create-application
$ ng g library  my-lib --root libs/my-lib
$ ng g application my-app

The problem is in tsconfig.json uses the path  to the dist folder.
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "my-lib": [
        "dist/my-lib",  <<--------------<<<<
      ]
    },

Describe the solution you'd like
Update tsconfig.json file to point to the src path rather than the dist path. This eliminates the need to build the library everytime you make a code change. Especially when you developing & testing locally. All you have to do is ng serve and the hot reload should take care of the rest.
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "my-lib": [
        "libs/my-lib/src/public-api",       <<--------------<<<<
      ]
    },

Describe alternatives you've considered
Currently I have to manually update the tsconfig.json file. It would be nice if angular cli can take care of this.

Thanks for opening the issue, we do not recommend using this pattern.
Please see: https://angular.io/guide/creating-libraries#building-and-rebuilding-your-library

Thank you for sharing the link. However, the link does not explain why a mylist/src/public-api pattern is bad. Is there any specific reason why we want use the dist/path over mylib/src/.

From the link:

The CLI build command uses a different builder and invokes a different build tool for libraries than it does for applications.

The build system for applications, @angular-devkit/build-angular, is based on webpack, and is included in all new Angular CLI projects
The build system for libraries is based on ng-packagr. It is only added to your dependencies when you add a library using ng generate library my-lib.
The two build systems support different things, and even where they support the same things, they do those things differently. This means that the TypeScript source can result in different JavaScript code in a built library than it would in a built application.

For this reason, an application that depends on a library should only use TypeScript path mappings that point to the built library. TypeScript path mappings should not point to the library source .ts files.

Since building an app and library use different build pipeline there can be some difference in output. While in most cases this is not a problem, there are cases were it can cause broken behaviour. This is because when when pointing the path mappings to src of the library, this is built as part of the application using the application build pipeline. In other terms, it is no longer treated as a library, but rather it just another directory in the application.


Added secondary names to list dropdown

Need to update the version number as well, in 3 places. Root level package.json and package-lock.json, as well as in the library's package.json file.


pip version 0.6 is missing utils/utils.h

The 0.6 version in
https://pypi.python.org/pypi/milk/
is missing file utils/utils.h.

experience same issue here when running pip install milk on OSX
    creating build/temp.macosx-10.10-x86_64-2.7
    creating build/temp.macosx-10.10-x86_64-2.7/milk
    creating build/temp.macosx-10.10-x86_64-2.7/milk/supervised
    compile options: '-I/usr/local/lib/python2.7/site-packages/numpy/core/include -I/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c'
    extra options: '-std=c++0x -stdlib=libc++'
    clang++: milk/supervised/_perceptron.cpp
    milk/supervised/_perceptron.cpp:8:10: fatal error: '../utils/utils.h' file not found
    #include "../utils/utils.h"
             ^
    1 error generated.
    milk/supervised/_perceptron.cpp:8:10: fatal error: '../utils/utils.h' file not found
    #include "../utils/utils.h"
             ^
    1 error generated.
    error: Command "clang++ -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -I/usr/local/lib/python2.7/site-packages/numpy/core/include -I/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c milk/supervised/_perceptron.cpp -o build/temp.macosx-10.10-x86_64-2.7/milk/supervised/_perceptron.o -std=c++0x -stdlib=libc++" failed with exit status 1


The program opens and closes immediately

I am using the latest version and the program just opens the CMD for 1 second and closes immediately on Windows 11 latest version.

Project is fully console app!
Use cmd for run project.

Project is fully console app! Use cmd for run project.

I used the exe one from the release am I doing something wrong?

No. Since version <IP_ADDRESS> it is impossible to start a project without console. Now you need to use the console to interact with the project

No. Since version <IP_ADDRESS> it is impossible to start a project without console. Now you need to use the console to interact with the project

Sorry for my ignorance but I am not understanding what I should do.
what commands or steps I should run/do?
In the ReadMe, you said just to run the exe file
like said here and that what I did

Yes. The .exe already has all the files you need to work and you don't need to install anything. Just download the .exe and use it.

Yes. The .exe already has all the files you need to work and you don't need to install anything. Just download the .exe and use it.

But that is what I did and like I said when I am clicking the exe file it opens CMD for 1 second and then closes it immediately

Sir, I am telling you there is a bug with the exe methods I downloaded the exe file from the release and double-clicked it, then it opened CMD for 1 second, and then it closed itself.
I tried the exe it 3 different computers same behavior it is not working

https://github.com/rzc0d3r/ESET-KeyGen/blob/main/wiki%2FKeyGenerator.md

Open cmd: Win+R, cmd
Write full path to project .exe file.
Press Enter

I did and I got an error as you can see from my taskbar I have Edge/Chrome/Firefox

Input required run-arguments

Input required run-arguments

But Sir I am running the exe what should I do?

Always launch like this in the future.
Or you can create a shortcut .eche file and write arguments in its settings. This way you will be able to start the project as it was before, just by clicking on it

Да, вот все получилось, так и есть создал ярлык и в свойствах переименовать добавил в конце  --chrome --key через пробел, спасибо.

Input required run-arguments

But Sir I am running the exe what should I do?
You said " Open cmd: Win+R, cmd Write full path to project .exe file. Press Enter "
and I did but like you saw above I get this error so again if you say something try to explain what steps I should take to solve it

Hello,
Just run in cmd following command: ESET-KeyGen_v<IP_ADDRESS>_win64.exe --chrome --key

Yes

Input required run-arguments

But Sir I am running the exe what should I do?
You said " Open cmd: Win+R, cmd Write full path to project .exe file. Press Enter "
and I did but like you saw above I get this error so again if you say something try to explain what steps I should take to solve it

Hello,
Just run in cmd following command: ESET-KeyGen_v<IP_ADDRESS>_win64.exe --chrome --key

Thanks you so much for explaining me what to do to fix the issue

This is the solution ESET-KeyGen_v<IP_ADDRESS>_win64.exe --chrome --key


Add kubernetes server docker image to docker hub

Depends on #18.

Seems like a dupe of #18

https://hub.docker.com/r/springcloud/spring-cloud-dataflow-server-kubernetes/


Slippage entry overwritten when we display warning

Describe the bug
https://amarok.bridge.connext.network/USDC-from-ethereum-to-binance
Go to here
When I enter a small amount .000001 in slippage
I see the yellow text Warning, but it also changes the amount i entered to 0. It shouldnt overwrite my entry with 0

We override the amount due to the smallest possible increment for slippage is 0.01%  (discussed in this card). And already adjusted the amount to be overwritten to 0.01%. Please try it again.

@just-a-node let me know your thoughts on the minimum
If we have good reason im fine with it but it

prevents me from testing super low slippage (not sure how to test slippage UX well yet so we can have employee address override)
Maybe we should just tell user in UI "Minimum slippage is 0.01%"


column sortable option must fallback to True

https://github.com/robotools/vanilla/blob/3ef4eba6dca0a94d14eef6da343524fd601f387d/Lib/vanilla/vanillaList2.py#L656
now it falls back to None

Should it fall back to True or False? It was off by default in List because back when vanilla used Cocoa Bindings sorting was quite difficult and in some instances would modify the represented data. I don't know if we should preserve the off-by-default setting or not.

Was there any update on this? There are some EZUI-based tools that I think would be greatly enhanced with the ability to sort table results. Thanks!


Remove a list

Simply add a button to remove a list.
See issue https://github.com/wekan/wekan/issues/611

@BaobabCoder I tried this and the Activities list on the side bar isnt updating correctly.. When i remove a list it shows this:
Username added undefined to this board.
Shouldnt it show "Username remove XX list from this board."

@whittssg thank you, I didn't see it. I'm pretty new on wekan. I'll fix it soon.


[WIP] [Authz] remove usage of ClassTagExtensions and make dependency jackson-module-scala in provided scope

to fix #4102
remove usage of ClassTagExtensions for better compatibility to jackson-module-scala
assume spark-core of Spark 3.x's core already has dependency on com.fasterxml.jackson.module:jackson-module-scala_${scala.binary.version}
change the scope of com.fasterxml.jackson.module:jackson-module-scala_${scala.binary.version} to provided

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Spark 3.0 using jackson-module-scala of v2.10.0 which does not provide ClassTagExtensions trait.
But ClassTagExtensions is used in serde package object.
https://github.com/FasterXML/jackson-module-scala/compare/jackson-module-scala-2.10.0...v2.14.1#diff-8df8a0d1dd5962fb14f1ef93dc02dfad7003971b2bcedc2cfb1522989b8c1249R14

@ASiegeLion Could you help me out to test this solution for Jackson lib conflict ?
It should be ok as no usage of ClassTagExtensions again where you have exception thrown previously.
Just check this branch out, compile Authz again , and put plugin jar and all the dep jars again in you Spark 3.2 (Remember to clear previously put dependency jars)?

@ASiegeLion你能帮我测试一下这个 Jackson lib 冲突的解决方案吗？ 它应该没问题ClassTagExtensions，因为在你之前抛出异常的地方没有再次使用。 只需检查这个分支，再次编译 Authz，然后将插件 jar 和所有 dep jar 再次放入你的 Spark 3.2（记得清除之前放置的依赖 jar）？

yes, it's all right

@ASiegeLion Could you help me out to test this solution for Jackson lib conflict ? It should be ok as no usage of ClassTagExtensions again where you have exception thrown previously. Just check this branch out, compile Authz again , and put plugin jar and all the dep jars again in you Spark 3.2 (Remember to clear previously put dependency jars)?

yes, it's all right

cc @yaooqinn  @pan3793

Thanks, merged to master


Unable to train

When I try to run tools/train.py, I met a issue:
/root/hhh/YOLO-master
unknown host, exit
How can I figure out it?

Thanks for your reminder, we have updated the training code. Please try it again.

Thanks for your reminder, we have updated the training code. Please try it again.

Hi, bro, i also met this bug.
Can you tell me what do you change this project?


Layer Search not Displaying

I cannot get the layer search to display in either the preview or the browser once exported.

Sorry this post was for Tom.


2724 inline edit activity item

#2724
I'm opening this as a draft because it's so very close to functionally complete but with one perplexing issue.
What I'm seeing is when using the hard delete functionality on an Identification (previously only on the id edit page), there seems to be some unpredictable results perhaps from a race condition.
From the observation.js duck, deleteID is called. It sends off dispatch( callAPI( inatjs.identifications.delete, Object.assign( {}, { id }, options ) ) ); Now callAPI will await the promise, however it appears that the response is returned BEFORE the backend has truly deleted the identification (sometimes). The next thing that happens is that setObservation() will go out and fetch the current (perhaps sometimes deleting and sometimes deleted) information and apply that to the (front end) state. Thus, sometimes this includes the the record marked api_status: "deleting". Stepping through the redux state diffs in the browser I can see it deleting and "restoring" it from the latest pull for identifications in the same step:
0(pin):{id:251,uuid:'436e08bf-6cfd-4f…ent:false} (ADDED)
2(pin):{id:251,uuid:'436e08bf-6cfd-4f…api_status(pin):"deleting"'} (REMOVED)

I'm not really sure what the best way to deal with this. Any ideas @kueda ?

In theory this should ensure that the observation index in ES is up-to-date before DELETE /identifications/:id returns, and this should ensure you're bypassing any caching, so yeah, that's kind of mysterious. Any ideas @pleary?
That said, I think that's probably an issue with our API and not within the scope of this UI work, I wouldn't let that hold you up, Brian.

Yes this sounds similar to what was happening in https://github.com/inaturalist/iNaturalistAPI/issues/200#issuecomment-652652554 - the classic Elasticsearch refresh issue. Brian would you mind testing something and see if it fixes this problem for you - on the line after https://github.com/inaturalist/inaturalist/blob/master/app/controllers/identifications_controller.rb#L250 which is @identification.wait_for_obs_index_refresh = true could you try adding @identification.wait_for_index_refresh = true? And you'll need to add attr_accessor :wait_for_index_refresh to the Identification model too.
With this change we will be asking the ID to wait until both the observations and identifications indices are refreshed. I wouldn't think this would be needed since I think the observation indexing happens last, and if we're waiting for a refresh on that I would think the ID index would also have been refreshed. But it would be an interesting test. If that works - great. If not, then as @kueda said this is an issue beyond the scope of this ticket and we can dig into it further later on.

Hey @pleary I tested that out without luck. In addition to it happening last, there's also include Shared::TouchesObservationModule which should in theory be setting wait_for_index_refresh to true using the after_destroy hook anyway, so I'm not sure.
I'll open up as a non-draft PR, but I do want to reiterate the behavior that gave me hesitation in the first place:
If a user uses the new inline hard delete functionality on an Identification, there's a good chance the Identification card will stay in place which would be confusing. Any attempts to edit/withdraw/delete it then will result in an error modal popping up and then the card disappearing, but obviously not ideal. Additionally, refreshing the page will clear it out as would I imagine any subsequent front end action which calls setObservation().
Just wanted to make sure that was clear.

Just saw I messed up and somehow included commits from https://github.com/inaturalist/inaturalist/pull/2727 here. Shouldn't be a problem if https://github.com/inaturalist/inaturalist/pull/2727 is merged first.

Thanks for all the feedback. I'll be able to address the issues early next week but totally understand if you're looking to get this out sooner so feel free to take it from here if urgent. Otherwise I'll pick it up then. Have a great weekend!

There are a few UI issues that I was planning on fixing myself, but if you want to address them, I'll just list them

I'll take a look.

Regarding Identify, if there's a way to replace DiscussionList with Activity in a separate PR, that would be great. However, I think the reason I haven't done so is that I do think the "Add ID" and "Comment" button should remain where they are in the ObservationModal, which is kind of incompatible with the way Activity works. If you want to propose a way to make Activity work with that UI, I'd certainly be interested in seeing / hearing what you have in mind. Maybe open a separate issue for that if you have an idea.

Was thinking a little bit about it, but yeah, wanted to break it off into something separate.

extreme social distancing (aka camping)

Haha, nice! That was me last weekend. Thanks for the feedback and enjoy the trip!

Very minor thing I noticed while updating styles.
# observations/show.scss
@import "../shared/activity_item";
...
@import "./identify/observation_modal";

# identify/observation_modal.scss
@import "../../shared/activity_item";

This results in the styles for ActivityItem being included in the compiled show.css a couple times.
We recently both independently added commits doing something similar with shared/text_editor.
Hopefully a quick enough fix to restructure in a separate issue.


Disable early drags and/or location (depends on server/section setting)

There should be a functionality for afk checks that disables early drags for everything other than Nitro: this will present an issue in the future fungal event if we are not able to resolve this, since people obtaining early drags for Mseal/Ftome is not intended by the Head Raid Leaders of this server.

dooule

Resolved


[MM-52755] Change user disconnect to HTTP POST

Summary
This PR makes it so the user disconnect endpoint requires the request to use HTTP method POST.
Note- This PR only resolves the issue for Jira server instances as there is some issue while connecting to the Jira cloud instance. We will make the fix for cloud instances once this issue is fixed.

Hello @raghavaggarwal2308,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

This is still relevant and pending PR review.

@mickmister Fixed the comments mentioned by you

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (292b5bc) 31.18% compared to head (2a2bdac) 31.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   31.18%   31.13%   -0.05%
==========================================
  Files          50       50
  Lines        7405     7409       +4
==========================================
- Hits         2309     2307       -2
- Misses       4905     4911       +6
  Partials      191      191

Impacted Files
Coverage Δ

server/http.go
69.58% <100.00%> (ø)

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@raghavaggarwal2308 Is there a connected JIRA ticket?

@esarafianou Would you mind giving this PR a review?

@hanzei  here is the Jira ticket:
https://mattermost.atlassian.net/browse/MM-52755

@DHaussermann this is ready for QA review

This was not something I had cycles for. I have asked Brightscout if they can provide QA.

Tested and Passed

This issue is tested on MM v-7.8.2 and on Jira server version 9.
The connect and disconnect command are working fine.
The edge cases of connecting and disconnecting even after the user is connected and disconnected are also working fine.
The disconnect user API has been changed to POST method, and is not accessible through the GET API as earlier.
This testing also ensured that the disconnect command URL is not working if tried hitting it on a browser.

I have tested this issue and everything seems to be working fine.

Tested and Approved, LGTM

This issue is tested on MM v-7.8.2 and on Jira server version 9.
The connect and disconnect command are working fine.
The edge cases of connecting and disconnecting even after the user is connected and disconnected are also working fine.
The disconnect user API has been changed to POST method, and is not accessible through the GET API.
This testing also ensured that the disconnect command URL is not working if tried hitting it using a browser.


bug(main menu): resolutions drops for preview images when going back.

browser
Edge
bug description
https://github.com/cyperdark/osuck-skins/assets/107962621/e15c3857-4528-4597-a8c0-2c75cd2c88fb

fixed


Can bff/user return the user avatar address?

/bff/user gets the values as shown in the figure by default. Can I get the user address through /bff/use?

Something similar to getting /connect/userinfo

duplicate

An alternative is to have the OIDC middleware call the userinfo endpoint by setting the GetClaimsFromUserInfoEndpoint to true, and then map the address claim from userinfo into the session with ClaimActions.MapUniqueJsonKey("address", "address").

Thank you, this method is feasible


Make the Airdrop Campaign Cancellable/Upgradeable

OriginalToken depends on an existing AirdropCampaign to which it distributes remaining funds after the cofounder distribution. If there are bugs in the airdrop it would be nice to be able to replace it with another contract, or even just cancel the campaign and place its tokens under the custody of another account/contract.

I've addressed this by making it possible to revoke approval of the airdrop campaign by the token holder (the address which holds the tokens for the airdrop, and has approved the airdrop for balance transfers).
It is also possible to set the token holder to address zero, effectively cancelling the airdrop


F #1684 add LXD support for disk TYPE=BLOCK

add '-s' to the file command to read special devices
add '-s' to enable "sync mode" kpartx when adding partition mappings

and handle the DISK case for disk['TYPE']

will rewrite the commit message


Introduce LC-Dailies leaderboard page

What's your idea?
Render data served on https://lc-dailies.deno.dev.
Reference:

https://oss.acmcsuf.com/lc-dailies

Related: https://github.com/acmcsufoss/lc-dailies/issues/35


Add index parameter to documentation for Node.descendants callback

https://github.com/ProseMirror/prosemirror/issues/972

This is intentional. Is there a situation where you needed that parameter, or did you just notice the disconnect between the source and the docs and assume it's a mistake?

I do not have a situation where that parameter is needed. While working through an issue, I saw the conversation in the referenced issue and thought the parameter was meant to be documented.

Ah, I had forgotten that conversation. If it's already exposed in nodesBetween I guess it makes sense to do that here too.


Documentation: "spring.ai.vectorstore.redis.uri" property is not available anymore

Bug description
The spring.ai.vectorstore.redis.uri property still mentioned in the docs here was removed in Spring AI M3.
spring.data.redis properties must be used to configure the datasource now.
Environment
Spring AI M3/M4
Steps to reproduce
Expected behavior
Documentation should be updated.

@timosalm When you populate the spring.data.redis properties, with spring-ai-redis-store-spring-boot-starter do you get an auto-configured VectorStore?
I can't seem to configure a RedisVectorStore at all with Spring AI M4 at the moment, auto-configured or manual.

I had to remove spring-boot-starter-data-redis to get a RedisVectorStore

@dashaun Yes, I don't have a "spring-boot-starter-data-redis" dependency: https://github.com/timosalm/spring-ai/blob/main/build.gradle
Maybe you should create an issue for that, as there will probably be applications that use Redis not only as a vector store, and at least some guidance in the docs would be great.


docs: Show Expected Output for Commands (trivial)

Checklist

[x] I've searched the issue queue to verify this is not a duplicate feature request.

Proposed Feature
It would be helpful if the expected output of certain commands were included in the documentation or comments.
For example, after running the command make hack-kind-up, the user might see something like:
Release "argo-rollouts" has been upgraded. Happy Helming!

or
> k get no
kargo-dev-cluster-control-plane   Ready

Motivation
helps users verify that they have executed commands correctly.
reduces confusion when users are unsure whether the command worked as intended.
Suggested Implementation
Mention expected output for commands in documentation wherever applicable.

IMO, the output might differ for some users. Instead of pointing the correct output, a better way is to provided a fix to the possible errors that can be encountered during the implementation of specific steps. We should try to keep the kargo docs as simple as possible. We can take inspiration from how the Argo Docs have been written.

Let's show output where it is helpful to do so.
There are many cases where it is not, including ones (like helm install commands) where the output is verbose and of limited value.
With that being said, I think I take it for granted that it's obvious when a command succeeds or fails and the docs might currently reflect that. It is obvious to me, in large part, because I have my shell prompts configured to give visual cues as to the success or failure of the previous command. Obviously, not everyone has that...
So what might be helpful, in some cases, is to provide commands that make it easier to validate the outcome of previous ones.
For instance, for a contributor running make hack-install-prereqs, they should be able to run kubectl get deployments -n cert-manager, kubectl get deployments -n argocd, and kubectl get deployments -n argo-rollouts and in all cases see 1/1 replicas ready, up to date, and available.
Provided we don't go overboard, I'd be very supportive of these sort of commands and example output that assert success in critical places.

As I think this is primarily applicable to the quickstart, which is trending toward being more UI-centric, I think this issue is much less relevant now. Closing.


[FEA] Spark 3.3 exposes Arrow value vector, update HostColumnarToGpu

Is your feature request related to a problem? Please describe.
https://issues.apache.org/jira/browse/SPARK-38028 exposes the value vector in the ArrowColumnVector. We have a class AccessibleArrowColumnVector that does this so we wouldn't need that anymore for spark 3.3 and >.  They are also possibly making it extendable https://github.com/apache/spark/pull/35393

I'd like to have a try.
A good chance for me to learn the background knowledge about ArrowColumnVector.

Should we add 2 functions in SparkShims like
def createArrowColumnVector: ColumnVector
def getArrowColumnVector: ColumnVector

which return AccessibleArrowColumnVector for spark version < 3.3 and ArrowColumnVector for spark version >= 3.3?

Since this is not expected to result in a performance gain, I'm not sure this is worth addressing until Spark 3.3 is our minimum supported version.  At that point we can simply remove AccessibleArrowColumnVector and use the new capabilities of ArrowColumnVector in Spark 3.3+.