internal traffic policy changes in kpng server

Introducing InternalTrafficToLocal field kpng server. This will propogate the ServiceInternalTrafficPolicy config to backend.

/approve
/lgtm


beta channel ahead of master ?

I think something seems to have gone wrong with beta (channel) branch, I did this just now as I was seeing same thing with my local fvm managed install and with clean install from git, beta is for some reason labeled as 2.7 while master is 2.6 ?
cc @christopherfujino
git clone https://github.com/flutter/flutter.git -b beta
Cloning into 'flutter'...
...

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 2.7.0-3.1.pre, on Ubuntu 21.04 5.11.0-38-generic, locale en_AU.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2020.3)
[✓] VS Code
[✓] Connected device (2 available)

• No issues found!
~/temp/flutter $ flutter channel master
Switching to flutter channel 'master'...
git: Already on 'master'
git: Your branch is up to date with 'origin/master'.
Successfully switched to flutter channel 'master'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
beta  ~/temp/flutter $ flutter upgrade
Flutter is already up to date on channel master
Flutter 2.6.0-12.0.pre.535 • channel master • https://github.com/flutter/flutter.git
Framework • revision 04156b6636 (2 days ago) • 2021-10-29 18:29:31 -0700
Engine • revision 3a0a63c2d2
Tools • Dart 2.15.0 (build 2.15.0-262.0.dev)

and just to be sure back again to beta:
flutter channel beta
Switching to flutter channel 'beta'...
git: Switched to a new branch 'beta'
git: Branch 'beta' set up to track remote branch 'beta' from 'origin'.
Successfully switched to flutter channel 'beta'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
beta  ~/temp/flutter $ flutter upgrade
Downloading Dart SDK from Flutter engine a75e3b80f9c1ffb30bbe736c5a42e4a815a79197...
 ...
Building flutter tool...
Flutter is already up to date on channel beta
Flutter 2.7.0-3.1.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision fc7015e35a (4 days ago) • 2021-10-27 15:18:41 -0700
Engine • revision a75e3b80f9
Tools • Dart 2.15.0 (build 2.15.0-178.1.beta)

Likewise dev seems to have a reasonable version:
flutter channel dev
Switching to flutter channel 'dev'...
git: Already on 'dev'
git: Your branch is up to date with 'origin/dev'.
Successfully switched to flutter channel 'dev'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'

 ~/temp/flutter $ flutter upgrade
Flutter is already up to date on channel dev
Flutter 2.6.0-11.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision 4b330ddbed (6 weeks ago) • 2021-09-16 17:29:58 -0700
Engine • revision 5b81c6d615
Tools • Dart 2.15.0 (build 2.15.0-116.0.dev)

I only noticed this because hot-reload for Linux desktop seemed to stop working for me on my beta and hot-restart started behaving strangely as well.

/cc @csells

This was not intentional, but fallout from two things:

A quirk in the way the Flutter CLI tool calculates the version on the master channel (it only looks at version tags that are on direct ancestors); and
The fact that the last beta release was not based on a dev release.

To fix this, I will update the flutter conductor release tool to always tag the branch point when publishing a new release branch.

It appears my fix was not robust enough, as with the past two beta releases, the branch point was not tagged. I will need to land another fix for this.


fix 1828

fixes https://github.com/druid-io/druid/issues/1828

👍

travis failure with AnnouncerTest - https://travis-ci.org/druid-io/druid/jobs/139633994

@nishantmonu51 can you make the title describe what the patch does?
Also is there any test which would be appropriate to add for this?

@drcrallen I think difficult to test

👍 after travis


vagrant-aws fails to install on Ubuntu 12.04 LTS

Hi,
I'm new to vagrant, I'm trying to use aws, however I've been unable to install the vagrant-aws plugin on all the Ubuntu machines I've tried, the latest one is a virgin Ubuntu 12.04 installation.
I'm running the latest vagrant release (v1.3.5), I've sucessfully used the vagrant-digitalocean plugin (https://github.com/smdahlen/vagrant-digitalocean).
The errors I get when I try to install vagrant-aws follows:
vagrant plugin install vagrant-aws
Installing the 'vagrant-aws' plugin. This can take a few minutes...
/opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/installer.rb:562:in `rescue in block in build_extensions': ERROR: Failed to build gem native extension. (Gem::Installer::ExtensionBuildError)
    /opt/vagrant/embedded/bin/ruby extconf.rb

Extracting libxml2-2.8.0.tar.gz into tmp//ports/libxml2/2.8.0... OK
Running 'configure' for libxml2 2.8.0... ERROR, review 'tmp//ports/libxml2/2.8.0/configure.log' to see what happened.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of
necessary libraries and/or headers.  Check the mkmf.log file for more
details.  You may need configuration options.
Provided configuration options:
--with-opt-dir
--with-opt-include
--without-opt-include=${opt-dir}/include
--with-opt-lib
--without-opt-lib=${opt-dir}/lib
--with-make-prog
--without-make-prog
--srcdir=.
--curdir
--ruby=/opt/vagrant/embedded/bin/ruby
/home/admin/.vagrant.d/gems/gems/mini_portile-0.5.2/lib/mini_portile.rb:265:in block in execute': Failed to complete configure task (RuntimeError) 	from /home/admin/.vagrant.d/gems/gems/mini_portile-0.5.2/lib/mini_portile.rb:257:in chdir'
from /home/admin/.vagrant.d/gems/gems/mini_portile-0.5.2/lib/mini_portile.rb:257:in execute' 	from /home/admin/.vagrant.d/gems/gems/mini_portile-0.5.2/lib/mini_portile.rb:65:in configure'
from /home/admin/.vagrant.d/gems/gems/mini_portile-0.5.2/lib/mini_portile.rb:108:in cook' 	from extconf.rb:101:in block in '
from extconf.rb:119:in call' 	from extconf.rb:119:in block in '
from extconf.rb:109:in tap' 	from extconf.rb:109:in '
Gem files will remain installed in /home/admin/.vagrant.d/gems/gems/nokogiri-1.6.0 for inspection.
Results logged to /home/admin/.vagrant.d/gems/gems/nokogiri-1.6.0/ext/nokogiri/gem_make.out
from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/installer.rb:540:in block in build_extensions' 	from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/installer.rb:515:in each'
from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/installer.rb:515:in build_extensions' 	from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/installer.rb:180:in install'
from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/dependency_installer.rb:297:in block in install' 	from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/dependency_installer.rb:270:in each'
from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/dependency_installer.rb:270:in each_with_index' 	from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/dependency_installer.rb:270:in install'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/action/install_gem.rb:49:in block in call' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/gem_helper.rb:42:in block in with_environment'
from /opt/vagrant/embedded/lib/ruby/1.9.1/rubygems/user_interaction.rb:40:in use_ui' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/gem_helper.rb:41:in with_environment'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/action/install_gem.rb:39:in call' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/action/warden.rb:34:in call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/action/bundler_check.rb:20:in call' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/action/warden.rb:34:in call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/action/builder.rb:116:in call' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/action/runner.rb:61:in block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/util/busy.rb:19:in busy' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/action/runner.rb:61:in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/command/base.rb:17:in action' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/command/install.rb:27:in execute'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/plugins/commands/plugin/command/root.rb:52:in execute' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/cli.rb:38:in execute'
from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/lib/vagrant/environment.rb:478:in cli' 	from /opt/vagrant/embedded/gems/gems/vagrant-1.3.5/bin/vagrant:96:in <top (required)>'
from /opt/vagrant/bin/../embedded/gems/bin/vagrant:23:in load' 	from /opt/vagrant/bin/../embedded/gems/bin/vagrant:23:in '
The mistake seems to be in the nokogiri dependency, the log file follows:
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... no
checking for cc... no
checking for cl.exe... no
configure: error: in /home/admin/.vagrant.d/gems/gems/nokogiri-1.6.0/ext/nokogiri/tmp/ports/libxml2/2.8.0/libxml2-2.8.0': configure: error: no acceptable C compiler found in $PATH See config.log' for more details
In my opinion, the plugin installation should be self-sufficient, even when I install gcc (through build-essential) the plugins still fails to install with the following error:
http://sprunge.us/BSKR

@chilicuil Thanks for the tip.

the last comment helped me to install that plugin, thnx


[Key Vault] Separating public and internal folders

For min/max testing and to make sure this goes in before I start doing more changes.

/azp run js - keyvault-keys - tests

/azp run js - keyvault-certificates - tests

/azp run js - keyvault-keys - tests

/azp run js - keyvault-certificates - tests

/azp run js - keyvault-secrets - tests

/azp run js - keyvault-certificates - tests

/azp run js - keyvault-keys - tests

/azp run js - keyvault-secrets - tests


Update the Complex data model EF Core tutorial for Nullable reference types

Update the Complex data model EF Core tutorial for Nullable reference types, or at least add a note.
Example issue is the text The Instructor entity has a nullable OfficeAssignment navigation property, but this is not correct as the code actually creates a required property IF the Nullable Reference Types feature is enabled. Which is on by default for new projects BTW.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 912ebaa6-721f-c8b3-7b3a-7f16d4c24360
Version Independent ID: b6135ff6-897f-c5fa-c61d-d9fad4ee9acd
Content: Tutorial: Create a complex data model - ASP.NET MVC with EF Core
Content Source: aspnetcore/data/ef-mvc/complex-data-model.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

This is rolled into the .NET 7 update.


Add configure parameter for LDAP Group search in config panel

New issue to track the UI part of task #3507

@stonezdj please help to review https://github.com/vmware/harbor/pull/5074


Add BinaryImage to Jewel

Hi,
thanks for this contribution. I was reviewing it and looks good, just one thing to improve. It's good to have a Jewel version of BinaryImage so we can apply jewel styles on it, but the composing parts does not change, so we can use Basic pieces. Only in the case we need to add or change something we can extend and create a new class with the changes.
Can you please apply this changes?
Thanks!

What's the use case for adding jewel styles to an image?
If the reason for this is to be able to use the j namespace in MXML, there's no need to add classes at all. You can add the following to the Jewel manifest:
<component id="BinaryImage" class="org.apache.royale.BinaryImage" lookupOnly="true"/>

Hi Harbs,
thanks for pointing that. In Jewel case all components has a CSS rule associated to work consistently cross themes. In this case we still need to add its own and will probably be added to the _image.sass file, so when using runtime theme switching all work as expected.

Hi,
thanks for this contribution. I was reviewing it and looks good, just one thing to improve. It's good to have a Jewel version of BinaryImage so we can apply jewel styles on it, but the composing parts does not change, so we can use Basic pieces. Only in the case we need to add or change something we can extend and create a new class with the changes.
Can you please apply this changes?
Thanks!

Perfect!!
I've already changed it

Many thanks! merged! :)


Inconsistent underlining ripples

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Ripples should behave consistently between components.
What is the current behavior?
Ripples for different components are positioned/behave differently.
Select (Notice the ripple is above the line)

Input (This time, below the line)

Another component with a underlining ripple is the tabs, where the underline goes above the baseline, like the select's. I haven't checked other components.
What is the use-case or motivation for changing an existing behavior?
Style inconsistency is weird. ☹
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
material@master

See #2124


skipTo() fails on Chrome

Current version of Chrome (18.0.1025.142).  The playhead is not reset when skipTo() is called.  Directly setting the element's currentTime attribute fails as well.  Is this a bug in Chrome?  (Note: in my testing, there are multiple instances of the player on the page, and it works fine in Safari).
Note: I'm using skipTo() to return the playhead to the start of the track when it finishes playing.  As a workaround, if skipTo() fails (determined by checking if audiojs.element.ended is true) I reload the track ( audiojs.load(audiojs.mp3)).

Unable to reproduce in the latest Chrome release on Android and desktop. Closing unless this is still an issue


13/analog-quil-examples

Add readout cavity scan example measurement in examples.md. Resolves #10.

@stylewarning @ecpeterson There are some TODOs in this PR and some open questions, hoping to start a discussion.

what's left on this?

@stylewarning I addressed @caryan's DELAY removal request, and I believe he has one more question he'll post shortly. I'd also like to better understand how $-prepended variables work (e.g. $qubit) before I say this is ready. I'll remove the wip when it is.

@stylewarning this PR is now ready.


Gsoc2021 quad float boostify

@sinandredemption this should be repaired/reset regarding branch protection.
As mentioned, there might be some local small changes that you need to recreate. I apologize for the confusion. Let's see if branch protedction/CI are fully up and running agin, then please continue. I will be out for a few hours now.


[Hacktoberfest] Convert to typescript

This task should not be very difficult since it's a single file library. I think we could gain significant value from it, achieving a lot of soundness in a pure functional library, with further mantainability for years to come.

Maybe converting to TypeScript is not necessary, but adding type declarations would be enough.
I made a PR #27 with colorsys.d.ts - my fork works pretty well with my TypeScript projects.

Thanks for that

Did the version with the typescript file get published? I'm currently not seeing it in v1.0.22

Yeah, it is just on github master, but npm package doesn't seem to be updated.


Add a project changelog

This changelog should be updated over time when implementing any notable changes. Adding changes that were missed to older versions should be fine too.

Thanks!


Check if download of assessment.zip succeeded.

Hi @aronasorman - this fixes #182.
We now capture if download of assessment.zip failed and exit accordingly to prevent the build from continuing.

Merging now to create a new OSX installer for testing.

@aron Here's a screenshot of a sample download of assessment.zip that's been closed by the remote server... not sure why the remote server did that. :(


[PLAT-78692] Optimize m3coord fanout to remote storages

What this PR does?
If a query has “shardName=” filter, it should only fan out the query to the local storage and the corresponding remote storage.
Example queries:
https://temp.corp.databricks.com/?c16721341d39f4eb#0Y5ZYeVzcbHg1KnhBS0/n+x9GJMjEwZyndLCicQEPtU=
How is it tested?
Run the m3 stack locally
m3dbnode configuration
+  filter:
+    read: "read_optimized"
+  "rpc":
+    "enabled": true
+    "errorBehavior": "warn"
+    "listenAddress": "<IP_ADDRESS>:7202"
+    "remotes":
+    - "name": "dev-aws-oregon-dev"
+      "remoteListenAddresses":
+      - "localhost:8080"

Port-forward oregon-dev global endpoint
$ k-m3 dev-aws-us-west-2 port-forward svc/m3coord-read-global-internal-svc 8080:7202

Relavant m3dbnode logs
Starting logs
$ rg -N 'optimized' ~/data/m3.logs/m3dbnode.log

{"level":"info","ts":"2023-04-11T20:07:35.173-0700","msg":"Using read optimzied filter for the remote storages","Filter.Read":"read_optimized"}

$ rg -N 'underlying' ~/data/m3.logs/m3dbnode.log

{"level":"info","ts":"2023-04-11T20:07:35.173-0700","msg":"Created fanout storage with underlying storages","num_stores":2}
{"level":"info","ts":"2023-04-11T20:07:35.173-0700","msg":"The underlying stores: ","store_name":"local_store","store_error_behavior":"fail","store_type":0}
{"level":"info","ts":"2023-04-11T20:07:35.173-0700","msg":"The underlying stores: ","store_name":"remote_store_dev-aws-oregon-dev","store_error_behavior":"fail","store_type":1}

Query processing logs
http://localhost:7201/api/v1/query?query=up{shardName="oregon-dev-on"}
$ {"level":"info","ts":"2023-04-11T20:25:20.916-0700","msg":"filtered out some storages","num_stores_before_filter":2,"num_stores_after_filter":1}

http://localhost:7201/api/v1/query?query=up{shardName="oregon-dev"}
No log for this one because no remote storage is filtered.
Unit test
$ go test -timeout 30s -run ^TestReadOptimizedFilter$ github.com/m3db/m3/src/query/policy/filter

Tested the performance in oregon-dev

nice, I would assume we enable this only for global read coordinator.

Yes, only the global read coordinator in dev/staging/prod-aws-us-west-2 will have the following config.
+  filter:
+    read: "read_optimized"

Have you done some simple load test? I would like to know if a query through m3coord with shard_name set is roughly equivalent to hitting the regional M3 instance (modulo the network costs)

I haven't. I deployed it to the global endpoint in oregon-dev. Could you guys do a quick test there? The query rewriter should use = instead of =~.  @bencon-db
https://m3-global-aws-us-west-2.dev.databricks.com/?g0.expr=up{shardName%3D"oregon-dev"}&g0.tab=0&g0.Humanize+Labels=false&g0.Stacked=false&g0.UTC=true&g0.Full+Width=false&g0.startStr=now-1h&g0.endStr=now&g0.range_input=1h

Some test links:

podInErrorStateCheck-ab-historical With filter, without filter; nvirginia-dev goes from ~300-400ms -> ~100-200ms
newPodWithHighServerRequestFailureRateCheck-ab-historical With filter, Without filter

This one always errors with "zero width assertions not allowed" when the filter is added

This one always errors with "zero width assertions not allowed" when the filter is added

I'm looking at this error.

This one always errors with "zero width assertions not allowed" when the filter is added

I'm looking at this error. The prod global endpoint returns the the error, so it's not caused by this PR. Is the error new to you? @bencon-db

@bencon-db The query has '$' in a regex (=~). '$' should be escaped as \\$.
com.databricks.backend.common.rpc.ManagerAdminApi$RunCommandInClusterContainers

Ah, this seems like a bug in our query rewriter. Apologies for the noise.


feat(RHTAP-1726): Fix-GitHub-action-against-Stage

Description
This PR implements the needed updates per the usage of the new Stage Prometheus SA created by Jan
The SA secret will be used as a token to login to the Stage member cluster hence having the authorization to query Stage Prometheus service
OCP_PROMETHEUS_TOKEN env var is the perf-team-prometheus-reader-cluster-sa Prometheus service account secret
Added PROMETHEUS_HOST env var into logic and as new secret
Tested the GITHUB Action load_test workflow successfully
Issue ticket number and link
https://issues.redhat.com/browse/RHTAP-1726 - Fix GitHub action against Stage
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Renamed OCP_TOKEN GITHUB Actions secret to OCP_PROMETHEUS_TOKEN and populated it with the Stage Prometheus SA secret
a. Get your personal token for Staging member cluster (https://console-openshift-console.apps.stone-stg-m01.7ayg.p1.openshiftapps.com/dashboards) and login with your personal OCP Token into the cluster
b. Get the OCP_PROMETHEUS_TOKEN and update the OCP_PROMETHEUS_TOKEN GITHUB Action secret
oc -n perf-team-prometheus-reader get secret/perf-team-prometheus-reader-cluster-sa-token-cjxsc -o json | jq --raw-output '.data.token | @base64d'

Get the Prometheus host and store it in a new GITHUB Action secret (PROMETHEUS_HOST)
oc -n openshift-monitoring get route -l app.kubernetes.io/name=thanos-query -o json | jq --raw-output '.items[0].spec.host'

Test the GITHUB Action load_test workflow- https://github.com/naftalysh/e2e-tests/actions/workflows/loadtest.yaml
And observed it succeeded

Access the artifacts section and download the loadtest workflow artifacts
https://github.com/naftalysh/e2e-tests/suites/17785727671/artifacts/1019209134

How to reproduce:
Run the loadtest in my fork before this PR is merged or in redhat-appstudio org e2e-tests repo when the PR is merged
https://github.com/naftalysh/e2e-tests/actions/workflows/loadtest.yaml
Checklist:

[X] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/CC jhutar

@naftalysh you don't need to read the route to get the full prometheus URL. You can actually construct it from the information you already have.

The Prometheus URL is something like https://thanos-querier-openshift-monitoring.apps.${BASE_URL}>/api where the BASE_URL is also part of the API URL (provided by the STAGE_MEMBER_CLUSTER variable, or you can get that by running oc whoami --show-server).
That API URL is something like https://api.${BASE_URL}:6443. You can extract the BASE_URL from it dynamically and then use it to construct the actual Prometheus URL
@pmacik
The only question is - do we want to rely on the assumption that the Prometheus server will always start with "thanos-querier-openshift-monitoring"?
If we can rely on it, than I can use your suggestion, otherwise we should keep the current method

The only question is - do we want to rely on the assumption that the Prometheus server will always start with "thanos-querier-openshift-monitoring"?
If we can rely on it, than I can use your suggestion, otherwise we should keep the current method

We can assume that Prometheus server will always start with thanos-querier-openshift-monitoring  and if that changes, we will update the code
So, I'll adapt Pavel's suggestion

/hold

@jhutar @pmacik
The change worked and the loadtest workflow succeeded
But I have noticed within the monitoring-collection.log in the artifacts a few errors:

(6 errors) Recurring error - User "system:serviceaccount:perf-team-prometheus-reader:perf-team-prometheus-reader-cluster-sa" cannot list resource "nodes" in API group "" at the cluster scope'

"ERROR Failed to execute command 'oc get nodes -l node-role.kubernetes.io/worker -o name | wc -l' - returned stdout '0', stderr 'Error from server (Forbidden): nodes is forbidden: User "system:serviceaccount:perf-team-prometheus-reader:perf-team-prometheus-reader-cluster-sa" cannot list resource "nodes" in API group "" at the cluster scope' and returncode '0'"

root ERROR Failed to measure measurements.token_pool_rate_secondary: missing 'response' in response's 'data'
root ERROR Failed to execute command 'cat /usr/local/ci-secrets/redhat-appstudio-load-test/load-test-scenario.${SCENARIO} | sed 's/\ /,/g' | sed 's/[^ ]* ([^= ])=([^= ])/"\1":"\2",/g' | sed 's/(.*),$/{\1}/g'' - returned stdout '', stderr 'cat: /usr/local/ci-secrets/redhat-appstudio-load-test/load-test-scenario.: No such file or directory' and returncode '0'

Hello @naftalysh
Ad 6 errors where "system:serviceaccount:perf-team-prometheus-reader:perf-team-prometheus-reader-cluster-sa" cannot list resource "nodes" in API group "" at the cluster scope: I guess that is because of these: https://github.com/redhat-appstudio/e2e-tests/blob/main/tests/load-tests/cluster_read_config.yaml#L102-L121. We either need to remove these or get different SA that would have permissions for these actions.
Ad measurements.token_pool_rate_secondary could not calculated: Yep, this metric https://github.com/redhat-appstudio/e2e-tests/blob/main/tests/load-tests/cluster_read_config.yaml#L25-L27 is either gone or not set for the time range when you ran it. Anyway imo this is irrelevant.
Ad Failing to access openshift-ci secret load-test-scenario which is not available for the Stage load testing: No need to block this PR because of these IMO. Until now it can not be ran at all, so this is definitely an improvement. It is because of https://github.com/redhat-appstudio/e2e-tests/blob/main/tests/load-tests/cluster_read_config.yaml#L123-L125. If you want to have it clean, we can change it to if [ -r /usr/local/ci-secrets/redhat-appstudio-load-test/load-test-scenario.${SCENARIO} ]; then ...; else echo '{}'; fi.

/unhold
/approve

/lgtm


VScode freeze when openning a directory

VSCode Version: 1.25.1
OS Version: MacOS 10.13.5

VSCode seems to try to check each files of the directory and sub-directories…
It's slow and VSCode freeze most of times.
Steps to Reproduce:

Open a huge directory project with code . command
try to work on a file (impossible to scroll, vscode freeze)

Does this issue occur when all extensions are disabled? No

Duplicate of https://github.com/Microsoft/vscode/issues/3998


CSS3's font-size-adjust would be a nice one.

CSS3's font-size-adjust would be a nice one.

This issue was imported from Google Moderator
Moderator votes: +3
Issue added by Olly on 2012-05-04
To vote this issue up or down, simply include +1 or -1 in your comment.

Already added at http://caniuse.com/#feat=font-size-adjust


Expose batch estimator sensor info to Python API

Returns sensor information (used for grabbing a subset of sensordata corresponding to measurements used by estimators).
Adds batch_server to build.yml for Github testing.

Added a Python function to get measurements from sensordata.


alicloud: fixes the nil pointer when importing the alicloud resources and supports global region

…

@xiaozhu36 Hey! Thanks for you PR. Can you fix CLA sign?

@googlebot I signed it!


SonoffLAN not loading after core-2021.8.5 update

Good day,
I Updated to core-2021.8.5 and my SonoffLAN integration won't load. Here are the errors:
Setup failed for sonoff: Could not set up all dependencies.
11:04:05 AM – (ERROR) setup.py - message first occurred at 11:04:05 AM and shows up 2 times
Unable to set up dependencies of sonoff. Setup failed for dependencies: zeroconf
11:04:05 AM – (ERROR) setup.py - message first occurred at 11:04:05 AM and shows up 2 times
Error during setup of component zeroconf
11:04:05 AM – (ERROR) components/zeroconf/init.py
I am running Cloud mode. Issue #557 by DirkMu is closed, but mine is still not loading.
Please help?
Thank you in advanced

Hi All,
Disabled IP v6 and rebooted, now its loading.
Thank you


batch requests until we get something that will trigger a wait

it's the latter part that is somewhat hmmmmm

The .on() handler and async() seems to have handled the original need for this.
Batching is still a concern, but not one to block release.


Don't use symbolic links on Windows, it requires admin account.

Running  python runtests.py -vv --debug cpdef_enums on Windows with Python 3.7 I get the following error.
======================================================================
ERROR: runTest (__main__.CythonRunTestCase)
compiling (c/cy2) and running cpdef_enums
----------------------------------------------------------------------
Traceback (most recent call last):
  File "runtests.py", line 1306, in run
    ext_so_path = self.runCompileTest()
  File "runtests.py", line 975, in runCompileTest
    self.test_directory, self.expect_errors, self.expect_warnings, self.annotate)
  File "runtests.py", line 1240, in compile
    so_path = self.run_distutils(test_directory, module, workdir, incdir)
  File "runtests.py", line 1112, in run_distutils
    self.copy_files(test_directory, workdir, related_files)
  File "runtests.py", line 1009, in copy_files
    copy(file_path, join(target_directory, filename))
OSError: symbolic link privilege not held

Currently it creates symbolic links only if os.symlink exists, seemingly under the assumption that on Windows it doesn't exist. But according to the docs, it actually does exist except:
On newer versions of Windows 10, unprivileged accounts can create symlinks if Developer Mode is enabled. When Developer Mode is not available/enabled, the SeCreateSymbolicLinkPrivilege privilege is required, or the process must be run as an administrator.

OSError is raised when the function is called by an unprivileged user.

Thanks


Build for python-3.8

Issue: python-3.8 not currently supported

Environment (conda list):  Any python-3.8 based environment.

Can you add the python-3.8 build?

Thank you,
Maarten.

I think someone tried in the past, and did not succeed: https://github.com/conda-forge/gensim-feedstock/pull/40
Are you able to make a PR?

Hi Michael,
Not easily, but the comments seem to indicate that you should be able to add the "bot-rerun” label
to #40 to have the bot create a new PR to start working on.
Could you give that a try?

OK, added the label, let's see if it helps.

You might have to re-open it (according to the reply to my gitter question about it)

On Dec 30, 2019, at 7:54 AM, Michael Penkov<EMAIL_ADDRESS>wrote:
OK, added the label, let's see if it helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/conda-forge/gensim-feedstock/issues/41?email_source=notifications&email_token=AAGFPI3NFIM3VPKGIXQEWTTQ3GLKDA5CNFSM4J3SORA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZWFIY#issuecomment-569598627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGFPIYPZ7BSTXKKBM2BQ53Q3GLKDANCNFSM4J3SORAQ.


{Network} az network dns: Move forward to use new api version 2023-07-01-preview

Related command
az network dns zone
az network dns record-set
Description
This PR explicitly sets the query_parameter "api-version" to the latest api-version (2023-07-01-preview) for the zones and the record-set REST calls. This reverts back the change done in #26902
Testing Guide
Note: This output of the commands would vary based on the DNS zones in your subscription.
Example commands:

az network dns zone list would return all the zones in your subscription
az network dns record-set  list   --zone-name foo.com --resource-group hello --query "[?name=='@']" would retrieve all record sets in the zone foo.com
az network dns zone show  --name google.com --resource-group allhandsdemo -o table

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Network


[6.0🍒] NCGenerics: it's not experimental

Explanation: Ensures that feature-guards in interfaces always evaluate to true for $NoncopyableGenerics, regardless of whether the module was built with -enable-experimental-feature NoncopyableGenerics.
Scope: Important for people who start using the feature without the flag in their build configuration, so they actually emit correct swiftinterface files.
Issue: rdar://127701059
Original PR: https://github.com/apple/swift/pull/73501
Risk: Low.
Testing:
Reviewer: @egorzhdan reviewed the C++ interop bits

@swift-ci test

@swift-ci test macOS

@swift-ci test macOS platform

@swift-ci test

@swift-ci test


Documentation + Interactions/Modules defined directly

I erred on the side of overdocumenting and gave every class/function/method a docstring. Let me know if it's too much.

Looks great and the documentation is nice and thorough.


Logout

Leave the meeting:

[x] Tell open connections to close
[x] Call logout when the app is closed
[x] Implement leave button in the UI triggering the logout

@jo-code Can you take a look at this later? I pushed the code, the web client does receive a message (user changed) with attribute loggedOut: false. But when a web client is logging out, there is another user changed message (validated: false) and only after that the user is no more listed in the participants list in the web client. That second message is missing when logging out from the app and I cannot figure out why 😄

@jo-code Seems like the code in bigbluebutton-html5/imports/api/users/server/publishers.js should have been called, but it wasn't. Maybe we need the server logs from the IT Ops team to check the error, or we need to figure out how to cause the MeteorJS connection to close:

Unfortunately I could not find anything that we do differently compared to the Web Client. We have to take a closer look again...


kibana41 4.1.8

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
[x] Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
[x] Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?
[x] Does your submission adhere to Versions "Acceptable Formulae" guidelines?

Bump stable version from 4.1.7 to 4.1.8

Thanks again @Jerzerak!


263 api for number of voters

The major tasks are:

Created separate vardb for counting the voters who are against as well as with the proposal.
Created an external function to return those values.

closing the pull request as it got accidentally created from other branch.


Mitgcm & eccov4 notebooks

This is the essential PR of the repo that not only adds two example notebooks requested in Issue #3 but also handles repo-wise configuration. The whole list of tasks this PR does is as follows:

[x] Add eccov4 notebook

The notebook is fully added, but we will need to figure out how to access the "ocean.yaml" data catalog through GCFS

[ ] Add mitgcm notebook (Needs to be finalized)
[x] Add the MIT license that shows copyrights clearly (i.e. Xgcm's until 2022, Pythia's from 2022)
[x] Populate the environment.yml file (to have many common dependencies among all the notebooks of this cookbook, and all the dependencies o f two notebooks in this PR)
[x] Update a few workflows to use the custom-named conda environment
[x] Add thumbnail
[x] Update _toc.yml and _config.yml

I just updated this branch so it should be consistent with the latest infrastructure.


[WIP] - Stop Publisher registering routes

Publisher now uses the Publishing API to register routes for all it's formats.
Merge after:

[ ] - https://github.com/alphagov/govuk-content-schemas/pull/465
[ ] - https://github.com/alphagov/publisher/pull/520

Trello card

We've realised that we need to move withdrawing into Publisher (doing it via the publishing API at the same time) before we can stop Panopticon registering routes entirely, so closing this.


Update "Preview features" notification text

Fixes https://github.com/Microsoft/azuredatastudio/issues/4420.


1.14.4 server crash on startup

Awesome work.
We tried to add you mod to our current server and will crash during startup.
Might be a mod incompatibility issue, but here is the full log.
And the crash log here.
Hope it helps and here is something on your end to make it work.
Thanks.

[05Sep2019 03:26:53.254] [Server thread/FATAL] [net.minecraftforge.fml.ModLoader/CORE]: Error during pre-loading phase
net.minecraftforge.fml.ModLoadingException: Mod §emoglowstone§r requires §6ctdcore§r §o2 or above§r
§7Currently, §6ctdcore§r§7 is §o§nnot installed

Can you try installing CTD Core for 1.14.4? It looks like that is the issue.
https://www.curseforge.com/minecraft/mc-mods/ctd-core/files/2768442

YES !
Wow being late and not reading does that.
Working perfectly fine on client and server.
Will include in all our modpacks.
Thank you so much, awesome mod.


scripts when writing

How can I get this removed:

it makes me very uncomfortable to see lines of scripts when I write.

You have trailing whitespace. Just remove the spaces, and the indent lines will also not show up.

Tienes espacios en blanco finales. Simplemente retire los espacios y las líneas de sangría tampoco aparecerán.

I put the spaces to be able to show the scripts, what I want is to remove those scripts even if there are spaces, the truth is that they make me very uncomfortable and distracting when it comes to coding.

I don't understand. If you want them completely gone, why not uninstall the plugin?

No entiendo. Si quieres que se vayan por completo, ¿por qué no desinstalar el complemento??

I do not want it to go completely, it is a great complement, it helps a lot, but when writing code moments I see that there is a script then I say: "I wrote badly?"and I realize it is the plugin. if you can't ok i can live with it :)

Then I still don't really understand what you want.
When do you not want to see them?

Then I still don't really understand what you want.
When do you not want to see them?

Well, what I want is not to see them when it is in insert mode, I feel as if I am wrong to tapas but then when trying to delete I remember that it is the plugin, nothing more, because then the truth is a fantastic complement

Okay, I understand now :+1:
There is no option for this, but you could overwrite the autogroup.
If you put this in your config after loading indent-blankline, it should not update from insert mode anymore.
augroup IndentBlanklineAutogroup
    autocmd!
    autocmd OptionSet list,shiftwidth,tabstop,expandtab IndentBlanklineRefresh
    autocmd FileChangedShellPost,TextChanged,CompleteChanged,BufWinEnter,Filetype * IndentBlanklineRefresh
    autocmd WinScrolled * IndentBlanklineRefreshScroll
    autocmd ColorScheme * lua require("indent_blankline.utils").reset_highlights()
    autocmd VimEnter * lua require("indent_blankline").init()
augroup END

Okay, I understand now +1
There is no option for this, but you could overwrite the autogroup.
If you put this in your config after loading indent-blankline, it should not update from insert mode anymore.
augroup IndentBlanklineAutogroup
    autocmd!
    autocmd OptionSet list,shiftwidth,tabstop,expandtab IndentBlanklineRefresh
    autocmd FileChangedShellPost,TextChanged,CompleteChanged,BufWinEnter,Filetype * IndentBlanklineRefresh
    autocmd WinScrolled * IndentBlanklineRefreshScroll
    autocmd ColorScheme * lua require("indent_blankline.utils").reset_highlights()
    autocmd VimEnter * lua require("indent_blankline").init()
augroup END

I put it at the end of my init.vim but there are no changes.

hm yeah.. I thought it would work, but it doesn't.
Sorry then, I don't think there is an easy way to do this, other than overwriting the autogroup directly in plugin/indent_blankline.vim

ok, also thank you very much for trying to help me


[Feature]Add click-to-zoom function to images in official documents. (官网文档中的图片添加点击放大的预览功能)

Ex.

good idea，thx！

We will consider the feature in https://github.com/apache/incubator-dolphinscheduler-website, thx!


bash: nodejs-dashboard: command not found

I did:
"npm install nodejs-dashboard --save-dev"
added "require('nodejs-dashboard')" to the top of my app.js
ran "nodejs-dashboard node app.js" from the command-line and get this error:
"bash: nodejs-dashboard: command not found"

You have to install it globally.
"npm install nodejs-dashboard --save-dev -g"
The docs need to be updated accordingly

You have to run it as an npm script if you're not installing it globally (which is fine). Per the README:
"scripts": {
    "dev": "nodejs-dashboard node index.js"
  }

Then you can do npm run dev and it should work. This is because npm scripts load the node_modules/.bin folder into the PATH when running, and that's where the executable is.

@svennidal as noted you'll need to run as a script. Alternatively you could access the bin directly using:
./node_modules/nodejs-dashboard/bin/nodejs-dashboard.js ... but the preferred method at this time is via script.

Thanks! 👍


chore(deps): address deprecated url-search-params package

While doing an npm install, I saw that the url-search-params package is deprecated, and needed to be replaced.  See https://www.npmjs.com/package/url-search-params for more details!

Thx, will merge on next release.

Wonder if we can't use the built in

@jimmywarting this: https://github.com/bitinn/node-fetch/issues/245#issuecomment-375944880


Request the user upgrade if the Android SDK version is 24

[x] Detect Android SDK version 24 and request the user upgrade.
[x] Consolidate on one definition of the Version class.

Fixes https://github.com/flutter/flutter/issues/7588

@devoncarew @jakobr-google

lgtm w/ the version check change

I've updated the message and the test to be < minimumAndroidSdkVersion. PTAL.

Marking this approved now that we have a cleanup bug filed.

This fixes https://github.com/flutter/flutter/issues/7588 which is the only remaining software bug open for our march 8th milestone. :)  If this is needed for March 8th we ideally want to get this in this morning, since @cbracken plans to make our first branch for that release this afternoon.

Does this still need to make it into the hackathon branch?

A this point I think we can just add this to the list of issues to watch out for.


World Generation missing in other dimensions

I use Aroma1997's Dimensional World that is basically considered the "Mining World" mod and the ores from this mod are not spawning there. It is usually Dim 6 and I had this issue with a few other mods that put a fix in for this. Ebon Arts, Environmental Tech and TAIGA all had this issue.
Is there a way you can set it so that world gen happens in other dimensions and or add whitelisting so we can set which dimensions world gen occurs in? Either fix would be great.
Aromas Dimensional World - https://minecraft.curseforge.com/projects/aroma1997s-dimensional-world
Some code used by Environmental Tech dev to have ores spawn in other dimensions:
http://pastebin.com/dGAQeccv
Hope that helps.

Its fixed in the new 2.0.13 version.


Check for RecyclerView.getChildAdapterPosition returning NO_POSITION

Prevents calls to the adapter with invalid position -1.

Thanks!


remove the theme argument

The theme argument can be removed because it's now available in the props. Documentation has already been updated, so this change requires that we remove references to theme here and here (which also means that we can probably remove these tests as well) :+1:

For the benefit of anyone reading this...
You once had code like this:
const MyDiv = glamorous.div((props, theme) => ({
  fontSize: theme.main.fontSize,
}))

You can now write that like this:
const MyDiv = glamorous.div(({theme}) => ({
  fontSize: theme.main.fontSize,
}))

For anyone else who wants to help, this would be really helpful.

Is it OK if I'm taking this one? (I want to get familiar with the code-base :smile:)
Normally I should be able to take a look at the codemod tomorrow too, if no one has taken it by then.

Sounds awesome!

This has been merged into next. Will be released 🔜ish


devise an efficient method for task discovery

We need a way, preferably an automatic one, to tell the server which tasks are at its disposal, and to add this information to the central database, to be served to clients. For this reason every task must advertise its inner workings by means of a task manifest. At the very minimum:
name: str
input_type: str
output_type: str

almost certainly we'll also need a
default_parameters: Dict[str, Any]

for all the default parameters required to run the task besides determining input and output.
possible solutions:

Add a __FRACTAL_MANIFEST__: Dict[str, Any] dunder variable within the task code itself. This is very clean but it requires all the source code to be imported upfront, which can require a few seconds with just a handful of tasks.
Place the information in a <task_name>.fractal file in a serialised format (json seems the obvious choice) that sits in the same folder (currently fractal/tasks/) as the actual code. Then we can simply glob the file pattern and read the info out.
have each task reside in a separate folder in which we require a dunder file __FRACTAL_MANIFEST__ with the same. This is the most future proof option as it would allow to, e..g, clone a repo somewhere, as long as that repo contains the magic file.

For a (small) selection of core tasks we could use option 2, but I strongly advise towards option 3.

Thanks for the overview of the options Jacopo!
From a (power) user perspective, option 2 & 3 are very attractive. It means we can make it fairly easy for users to add new tasks without having to change any of the general files and the core function really is just a python file with a python function, plus there is a small "metadata" file that contains some relevant info. We could also receive python function files from users and just add the metadata file on top easily then.
From a user side, I don't feel like option 2 or 3 would differ that much. So if option 3 seems like the thing that would be more stable long term, let's directly go with that

Conclusion of our call on July 5th was that option 3 seems like a good direction to go, so let's work towards this when we refactor the tasks next :)


cannot deploy on localhost again

The changes for https://github.com/Onto-Med/top-deployment/issues/23 seem to be reverted or there is a new issue, as Caddy will try to serve on HTTPS on localhost, which fails.

I think the error is caused by 33d8b881c0f3c15431dc98402fa379a543bbe3aa because it removes the base URL from the Caddyfile:
-{$BASE_URL} {
+	rewrite /api /api/
 	reverse_proxy /api/* backend:8080
+	rewrite /auth /auth/
 	reverse_proxy /auth/* keycloak:8080
 	reverse_proxy /* frontend:80

The current Caddyfile still has the closing brace but no base URL on top:
    rewrite /api /api/
    reverse_proxy /api/* backend:8080
    rewrite /auth /auth/
    reverse_proxy /auth/* keycloak:8080
    reverse_proxy /* frontend:80

    header / Cache-Control no-cache
    header /api/* Cache-Control no-cache
}


[BUG] List indent

Describe the bug
When tabbing and shift-tabbing and indented list the contents of the list gets copied and doubles each time this occurs. All other community plug-ins have been disabled.
To Reproduce
This hasn't reproduced in another vault and though continues after restarting obsidian. Only seems to be for this particular list.
Expected behavior
List parent and child indent.
Screenshots

Desktop (please complete the following information):

OS: MAC OS Big Sur
Obsidian Version: 0.12.3

Additional context

@joshsvnd Hi! Please try to update the plugin. It should be fixed in https://github.com/vslinko/obsidian-outliner/releases/tag/1.1.11

🤦♂  I should have checked that. Thanks. That seems to have fixed it.


Attribute name is been rendered as data-name

The documentation mention the ability to define the name attribute, however, it's been transformed into data-name.
Version:  "@uploadcare/react-widget": "^1.2.1"
Example:
<Widget
              publicKey="Secret"
              id="file"
              name="file"
              tabs="file url"
              previewStep="true"
            />

Result:

Thanks for issue!

The documentation mention the ability to define the name attribute

Yep, we have that stuff in react guide, I will fix


Implement the OSLCServer.create method

Takes a resource that contains the values of the resource to create.
Eventually each resource should have a reference to its constraining resource shape. This method should check the resource contents against its shape before attempting to POST to the server. This might be redundant with what is already being done by the server, but is a good idea anyway.
This uses the OSLC creation factory service URL in the service provider. The created resource is returned.

Create is implemented, but does not deal with resource shapes. Doing so in the client would be redundant with what is done in the server, so this is not necessary.


consider scipy.sparse for text-ms-matrix

this may prove a lot more memory efficient. Not sure if it's practical, though.

worked nicely for the person-ms-matrix in #57 , should be attempted for text-ms-matrix too


Add Social Media Icons to Footer on all Pages

I have added social media icons to Footer on all Pages
Before :

After :

@Orca-63 pls resolve the conflicts.

@Orca-63 Okay, I will Check and merge it.


How to get extra_modality ‘flow_xym’

Hello, I saw RawFrameDecode_Custom in /mmaction/datasets/pipelines/custom_temporal.py. How should I get flow_xym here?

Hi, I visualized a flow_xym image. Is there something wrong？

Hi, I visualized a flow_xym image. Is there something wrong？

It is my implementation following the statement from MvPL(https://arxiv.org/abs/2104.00682). I didn't visualize a lot of samples and your sample seems good. As the order of the three channels will affect the visualizatation but not for the model, the color difference to the visualization in MvPL is acceptable. Please have a try and get the performance, the result with Flow + our framework should be close to TG + our framework.

Okay, thank you. I'll try to reproduce MvPL.


Syncing ldap group descriptions

Syncing group descriptions with LDAP.
https://github.com/zulip/zulip/issues/31040
https://chat.zulip.org/#narrow/stream/31-production-help/topic/sync.20group.20descriptions.20from.20ldap/near/1892521
Extended ZulipLDAPUser to have function for getting descriptions from LDAP. The function group_description_from_info is similar to that used in https://github.com/django-auth-ldap/django-auth-ldap/blob/master/django_auth_ldap/config.py for getting the group names.
Group descriptions are now synced as part of the sync_groups_from_ldap process. This ensures that group descriptions for all relevant users are checked during synchronization. However, this method isn't the most efficient, as the descriptions only need to be synced once. Optimizing this would require either modifying the existing sync_groups_from_ldap command or creating a new command specifically for syncing group descriptions.
A new setting, LDAP_GROUP_DESCRIPTION_ATTR, has been introduced to map descriptions to an attribute in an LDAP group. To enable description syncing, this setting must be configured. If left unset, no syncing will occur, meaning organizations that do not explicitly enable this feature will not experience any changes.
TODO:
Documentation of  description syncing.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@mateuszmandera can you review this one at this point?

So I'd just like some confirmation on the two notes/questions I left above. After that I can add some documentation and then should be ready for integration review.

@mateuszmandera

Cool, tagged for integration review now. @timabbott Can you review next? The configuration interface via the LDAP_GROUP_DESCRIPTION_ATTR server-level setting might be worth some consideration -  but it makes sense to me.
It might be a bit weird that you can configure the group lists per-realm, but this is only server-level - but it seems even stranger and unlikely to have different LDAP attribute names for group description for different realms... So while we could allow customizing this per-realm, it seems like an excessive level of granularity.

Noted one fairly serious bug, but otherwise this looks good (though I'll do a final copy-editing pass on the docs before merging).

The configuration interface via the LDAP_GROUP_DESCRIPTION_ATTR server-level setting might be worth some consideration - but it makes sense to me.
It might be a bit weird that you can configure group lists per-realm, but this is only server-level - but it seems even stranger and unlikely to have different LDAP attribute names for group description for different realms... So while we could allow customizing this per-realm, it seems like an excessive level of granularity.

Yeah, I think this is correct; we will want the entire set of LDAP configuration variables to be per-realm.

Yeah, I think this is correct; we will want the entire set of LDAP configuration variables to be per-realm.

Hmm, Is your point that we want to have this as this global-style variable for now, because once we transition to a proper per-realm ldap configuration framework, settings of this kind will naturally get transitioned to be per-realm? That's my thinking too, if I read this correctly.

Yep, exactly.

@timabbott  Replied in https://github.com/zulip/zulip/pull/31863#discussion_r1897579970 about why storing the already_synced_groups would have to be very ugly/hacky and just pushed a commit improving that query + another commit to just clean up the sync_groups_from_ldap function overall to read cleaner.


Package for .NET 6/7 without MAUI

Sorry if this is the wrong place to ask! I am wondering, is this the future package for .NET 6/7 support for applications that do not use MAUI, but instead use what is formally known as Xamarin.Android and Xamarin.iOS?
Our project uses ZXing.Net.Mobile, but it doesn't seem to work anymore even on the latest beta packages.
Thanks!

ZXing.Net.Mobile seems to have been essentially abandoned 2 years ago. I've found 2 forks on GitHub with some efforts to recompile ZXing.Net.Mobile against net6. I've not tested them personally.

https://github.com/BrianDT/ZXing.Net.Mobile
https://github.com/joeerwood/ZXing.Net.Mobile (https://www.nuget.org/packages/ZXing.Net6.Mobile/3.2.0-alpha5)


bug: Ionic Scroll Delegate scroll top value always 0

Type: bug
Platform: all
I have a directive that uses $ionicScrollDelegate.getScrollPosition().top in order to bind to the scroll event on . So that when scroll happens, I make an element dissappear from view (a footer bar).
This works on first app load, on current view. But if I go browse via a certain path in the app: openingen a side menu, selecting a menu item, a new modal opens with content. I click a link in this modal..., and the app now closes modal and navigates to a new route and view template.
Now is where this "bug" begins. The $ionicScrollDelegate.getScrollPosition().top value is always zero from now on. No matter if I go back to the start view. It will from now on always report 0 value. Hence, no longer hiding my footer bar on any view in the app.
I cannot find any info that I'm doing this wrong in any way, or that it's supposed to be acting like this.Or, how I reset the top position so to speak.
I've created a code pan that echoes current value to console via console.log. So please, go there and open the debug console.
Scroll on the first view. See how the value updates.
Now open left menu and move to any other view.
See how the console now always reports 0 as value on scroll.
http://codepen.io/johced/pen/JowyGx

UPDATE:
I do not know anymore if this is a "bug".
On state changes the ionicScrollDelegate has many objects or handlers.
I was able to solve this by adding a delegate-handle="nameOfHandler" next to each directive attribute to specify which ionicScrollDelegate handler I want to use.
This issue can be closed, unless it's a "bug" that getScrollPosition().top maybe should return the position of the "latest" handler available and not the first (of possibly many ionicScrollDelegate objects.

We advise $ionicScrollDeleate code use the ionView events to do their thing after the page has loaded. Otherwise you can run in to race conditions like what it looks like you were in. Thanks!


Add diagnostic info

Add a button to let end-user can provide more info in issue reports.

I think it's better to control show diagnose button in setting page, because most of users will not use that feature.


Include redux-logger among dependencies

The logger package is effectively used at runtime, so we must include it
as a dependency.

Thanks!


Use named exports for jest-diff

Summary
Similar to https://github.com/facebook/jest/pull/11359 and https://github.com/facebook/jest/pull/11360, I had problems when using jest-diff together with rollup's plugin-commonjs that turns cjs back into esm.  It appears that there was originally a desire to use all named exports for jest-diff, but the move was delayed originally.  This PR removes the default export for jest-diff and exposes diff() as a named export.  I also did my best to find any usages of the default export in the documentation.
Test plan
I tested this in my own snowpack app by building jest from my branch and replacing files in my node_modules.

Codecov Report

Merging #11371 (d4c588b) into master (3f6b420) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11371   +/-   ##
=======================================
  Coverage   64.19%   64.19%
=======================================
  Files         308      308
  Lines       13519    13519
  Branches     3293     3293
=======================================
  Hits         8678     8678
  Misses       4126     4126
  Partials      715      715

Impacted Files
Coverage Δ

packages/jest-diff/src/index.ts
82.75% <ø> (ø)

packages/jest-matcher-utils/src/index.ts
86.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6b420...d4c588b. Read the comment docs.

It looks like one test died out.  :(

Published as next.9


Performance Issue with tiles

AdvancedRocketry-1.10.2-1.0.19

That appears to be a chunk load loop.  That's not good.

Duplicate of #1333


Backend & pipeline crash with recent pySigma versions

Hi there, thanks for publishing this backend!
Was experimenting around with it and noticed that it crashes with any recent pySigma versions, with the following traceback:
Traceback (most recent call last):
  File "C:\Users\<REDACTED>\convert_to_xql.py", line 8, in <REDACTED>
    pipeline = CortexXDR_pipeline()
               ^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\pipelines\cortexxdr\cortexxdr.py", line 364, in CortexXDR_pipeline
    return ProcessingPipeline(
           ^^^^^^^^^^^^^^^^^^^
  File "<string>", line 15, in __init__
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\processing\pipeline.py", line 442, in __post_init__
    raise TypeError(
TypeError: Each item in a postprocessing pipeline must be a QueryPostprocessingItem - don't use processing classes directly!

Alternatively, if instead of using the pipeline, the CortexXDRBackend is imported directly, it crashes on import with the same error.
The error is fairly descriptive, so at the bottom of this issue, I've put a simple diff for it.
As you'll notice, the diff also makes another small change, changing the related transformation's return from query, True to query. That's because that bool isn't actually necessary, and leaving it in (once the prior error is fixed) will cause:
Traceback (most recent call last):
  File "C:\Users\<REDACTED>\convert_to_xql.py", line 15, in <REDACTED>
    cortex_backend.convert_rule(rule)
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\conversion\base.py", line 203, in convert_rule
    finalized_queries = [  # 3. Postprocess generated query
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\conversion\base.py", line 204, in <listcomp>
    self.finalize_query(
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\conversion\base.py", line 1864, in finalize_query
    return super().finalize_query(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\conversion\base.py", line 662, in finalize_query
    return self.last_processing_pipeline.postprocess_query(rule, backend_query)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\processing\pipeline.py", line 527, in postprocess_query
    query, applied = item.apply(self, rule, query)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\processing\pipeline.py", line 385, in apply
    result = self.transformation.apply(pipeline, rule, query)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\<REDACTED>\Lib\site-packages\sigma\pipelines\cortexxdr\cortexxdr.py", line 53, in apply
    if re.search(single_pattern, query): # for single value
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\WindowsApps\<REDACTED>\Lib\re\__init__.py", line 176, in search
    return _compile(pattern, flags).search(string)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'tuple' (while finalizing query for rule None)

--
The diff that solves both:
diff --git a/sigma/pipelines/cortexxdr/cortexxdr.py b/sigma/pipelines/cortexxdr/cortexxdr.py
index 979736d..80627c6 100644
--- a/sigma/pipelines/cortexxdr/cortexxdr.py
+++ b/sigma/pipelines/cortexxdr/cortexxdr.py
@@ -2,7 +2,7 @@ from typing import Union
 from sigma.pipelines.common import logsource_windows, windows_logsource_mapping
 from sigma.processing.transformations import ConditionTransformation, AddConditionTransformation, FieldMappingTransformation, DetectionItemFailureTransformation, RuleFailureTransformation, ChangeLogsourceTransformation, SetStateTransformation
 from sigma.processing.conditions import LogsourceCondition, ExcludeFieldCondition, RuleProcessingItemAppliedCondition
-from sigma.processing.pipeline import ProcessingItem, ProcessingPipeline
+from sigma.processing.pipeline import QueryPostprocessingItem, ProcessingItem, ProcessingPipeline
 from sigma.processing.postprocessing import QueryPostprocessingTransformation
 from sigma.rule import SigmaDetectionItem, SigmaDetection, SigmaRule
 from sigma.exceptions import SigmaTransformationError
@@ -71,7 +71,7 @@ class ReplaceIntegrityLevelQueryTransformation(QueryPostprocessingTransformation
         if output_type == 'json':
             query = json.loads(query)

-        return query, True
+        return query

 def CortexXDR_pipeline() -> ProcessingPipeline:
@@ -374,6 +374,9 @@ def CortexXDR_pipeline() -> ProcessingPipeline:
             *unsupported_rule_types,
         ],
         postprocessing_items=[
-            ReplaceIntegrityLevelQueryTransformation(),
+            QueryPostprocessingItem(
+                identifier=f'replace_integrity_level',
+                transformation=ReplaceIntegrityLevelQueryTransformation(),
+            ),
         ],
     )
\ No newline at end of file

I've tested the patched state with a number of local sigma rules, works flawlessly.
Would be great if you could apply this diff! I would've opened a pull request directly, but unfortunately you've not allowed that for this repository.

Thank you @jgubler for both identifying the issue and finding a solution! Sorry that PRs aren't able to be created directly - I'll see if I can get access fixed up for this repo. In the meantime, I'll be pushing out this change in version 0.1.4!


doc: fix translation inconsistency

Check List
Please read and check followings before submitting a PR.

[ ] I want to publish my theme on Hexo official website.

[ ] I have read the theme publishing doc.
[ ] name is unique.
[ ] link URL is correct.
[ ] preview URL is correct.
[ ] preview URL web site is rendered correctly.
[ ] Add a screenshot to source/themes/screenshots.
[ ] Screenshot filename is same as value of name.
[ ] Screenshot size is 800 * 500.
[ ] Screenshot file format is png.

[ ] I want to publish my plugin on Hexo official website.

[ ] I have read the plugin publishing doc.
[ ] name is unique.
[ ] link URL is correct.

[x] Others (Update, fix, translation, etc...)

Languages:
[x] en English
[ ] ko Korean
[ ] pt-br Brazilian Portuguese
[ ] ru Russian
[ ] th Thai
[ ] zh-cn simplified Chinese
[ ] zh-tw traditional Chinese

Looks great! Would you mind updating the changes for all languages? Simply copy that line (in English) to other languages will be fine.


Laravel 10.x Shift

This pull request includes the changes for upgrading to Laravel 10.x. Feel free to commit any additional changes to the shift-103963 branch.
Before merging, you need to:

Checkout the shift-103963 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Clear any config, route, or view cache
Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

:warning: Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.
You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 4f4a1085 and make the config file changes manually.

:information_source: Shift updated your dependencies for Laravel 10. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 10. Watch dealing with dependencies for tips on handling any Composer issues.
The following dependencies were updated by a major version and may have their own changes. You may check their changelog for any additional upgrade steps.

[ ] laravel/ui
[ ] sentry/sentry-laravel
[ ] tightenco/ziggy

:information_source: Shift detected your application has a test suite. To make verifying the upgrade to Laravel 10 easier, Shift did not upgrade your test suite to PHPUnit 10. Once you have completed your upgrade, you may run the PHPUnit 10 Shift for free to upgrade your test suite to PHPUnit 10 separately.

:information_source: Laravel 9 adopted anonymous migrations. Shift automated this change to align with modern Laravel conventions and avoid naming migrations.

:information_source: Laravel renamed the password_resets table to password_reset_tokens. While an optional change, Shift detected you have a migration for this table and created a migration to rename it as well as updated the reference in your config/auth.php file. Be sure to run php artisan migrate to complete your upgrade.

:warning: Laravel 10 has added a return type of array to the Event broadcastOn and Notification via methods. However, you may still return a single channel from these methods.
Shift added the array return type to these methods in the following classes. You should review them to ensure you are returning an array, or remove the return type.

[ ] app/Events/ChecklistUpdated.php

:information_source: Laravel 10 added PHP type hints to all user-land code included in a new Laravel application. In an effort to modernize your code, Shift added type hints to any method which is used by Laravel.

:information_source: Now with type hints in your code, defining types within PHP DocBlocks is redundant. Laravel has removed all of the @param and @return tags from its DocBlocks where types are defined with PHP. Similarly, Shift removed these tags from any DocBlock where the code now has equivalent type hints.

:information_source: Shift understands developers have different preferences when it comes to type hints. All of Shift's automation is done in nice, atomic commits. This makes it easier to undo any of the changes Shift makes.
If you wish to undo the changes relating to type hints, you may run:

git revert cdb156b to revert the DocBlock changes.
git revert bea193e to revert the type hints added from DocBlocks.
git revert c4d14a4 to revert the type hints added for Laravel 10.

:warning: In Laravel 10 you may no longer implicitly cast a DB::raw() expression to a string. Instead, you must retrieve the string value from the expression using the getValue() method. Query builder methods will continue to automatically handle DB::raw() expressions as before. This change only affects instances where you are using DB::raw() expressions in your own code.
Shift detected calls to DB::raw(). You should review these instances to see if you are attempting to use them as a string.

[ ] database/migrations/2022_04_29_115418_rename_polymorphic_comments_class_name.php

:information_source: Laravel began using Vite to build frontend assets in Laravel 9.19. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

:warning: Laravel 10 requires Composer 2.2 or higher. You should verify the Composer version in your environments by running composer --version to ensure it meets this new requirement. If necessary, run composer self-update to update Composer.

:warning: Laravel 10 requires PHP 8.1 or higher. You should verify the PHP version in your environments to ensure it meets this new requirement.

:warning: Shift detected you are using a Laravel package like Horizon or Nova which may need to have its published assets regenerated after upgrading. Be sure to use artisan to republish these assets as well as php artisan view:clear to avoid any errors.


Windows Path?

Hi,
why do you the windows path separator?
https://github.com/itsmeow/QuickHomes/blob/e22e29b84e311a851bf53cbeaed61ecd11b856c1/java/its_meow/quickhomes/command/CommandSetHome.java#L48
Its working, but still messy.
root@mcbukolos:~# ls -a /home/minecraft/server/
.                    Fine Technology.log                          journeymap                   OpenComputersMod-<IP_ADDRESS>-lua53-native.64.so           snapshots-server           world-20171218-223054.zip
..                   forge-1.12.2-<IP_ADDRESS>62-installer.jar.log  libraries                    ops.json                                               structures                 world-20171223-223058.zip
banned-ips.json      forge-1.12.2-<IP_ADDRESS>78-installer.jar.log  loading-log.log              options.txt                                            usercache.json             world-20171225-185110.zip
banned-players.json  forge-1.12.2-<IP_ADDRESS>81-installer.jar      local                        .\quickhomes                                           usernamecache.json         world-20171225-213647.zip
config               forge-1.12.2-<IP_ADDRESS>81-installer.jar.log  logs                         .\quickhomes\05836a8b-4500-415e-b6c8-16fabbca4c48.txt  whitelist.json             world.old
crafttweaker.log     forge-1.12.2-<IP_ADDRESS>81-universal.jar      minecraft_server.1.12.2.jar  .\quickhomes\73f65d38-194d-4274-8952-04343b571eea.txt  woot
crash-reports        forge_server.jar                             minemenu                     .\quickhomes\ad4a6ddc-640f-46bd-868f-2a2357956485.txt  world
dynmap               hc-recipes                                   .mixin.out                   scripts                                                world-20171213-193928.zip
eula.txt             hs_err_pid375.log                            mods                         server.properties                                      world-20171216-221358.zip

Since the path begin with a dot, its marked as hidden file in non windows systems

I would probably have to add a manual OS check and change the directory from there. I don't exactly have a Linux system to test on

No, you can safe you slashes. See https://stackoverflow.com/questions/2417485/difference-between-file-separator-and-slash-in-paths

With the Java libraries for dealing with files, you can safely use / (slash, not backslash) on all platforms. The library code handles translating things into platform-specific paths internally.

I will update the mod.

File separators changed. Issue resolved.

I seriously cannot upload this file anywhere. It isn't corrupt but both CurseForge and GitHub give me errors when I try to upload it. Seriously, I can't get this thing to you. You can build it yourself if you really need my mod but by now you've probably removed it anyway. Sorry.


Refactor output lookup

This refactors the mechanics of the ${output} lookup so that it uses the internal stacker.Stack as the lookup point.
With the addition of the DAG, in order to ensure that output lookups didn't involve unnecessary network calls, we changed stacker.actions.build to call provider.set_outputs to store the stacks outputs when the step was completed.
https://github.com/remind101/stacker/blob/c1aad4f8713c64c90abc02e6c10ad2eda1a18c8e/stacker/actions/build.py#L262-L264
The output lookup would then use this cached value, through provider.get_output.
https://github.com/remind101/stacker/blob/c1aad4f8713c64c90abc02e6c10ad2eda1a18c8e/stacker/lookups/handlers/output.py#L44-L49
This was the smallest change that we could make in the DAG branch, while keeping everything fast and functional, but won't work well moving forward as we think about cross account/region support, as well as the possibility of adding new node types to the graph (e.g. hooks).

In this PR, when a stack is "done", we store the outputs on the internal stacker.Stack object. The output plugin looks up the stack object, then returns the output from there. This has a couple of advantages:

It ensures that we're not keeping global state for cached lookups, so we don't have a potential for a race.
It'll work better when we think about cross account/region stacks using profiles. You can think of a scenario where, stacker is managing two stacks, both named "RoleModel" in separate accounts. The output lookup needs to be aware that these nodes in the graph are separate things.

Codecov Report

Merging #550 into master will decrease coverage by 0.11%.
The diff coverage is 90.54%.

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   87.55%   87.43%   -0.12%
==========================================
  Files          95       95
  Lines        6108     6122      +14
==========================================
+ Hits         5348     5353       +5
- Misses        760      769       +9

Impacted Files
Coverage Δ

stacker/tests/actions/test_build.py
96.77% <ø> (ø)
:arrow_up:

stacker/tests/actions/test_destroy.py
100% <ø> (ø)
:arrow_up:

stacker/tests/test_stack.py
97.91% <ø> (ø)
:arrow_up:

stacker/actions/diff.py
59.71% <0%> (ø)
:arrow_up:

stacker/tests/test_plan.py
98.05% <100%> (-1.3%)
:arrow_down:

stacker/tests/test_variables.py
100% <100%> (ø)
:arrow_up:

stacker/lookups/handlers/output.py
80% <100%> (-1.82%)
:arrow_down:

stacker/plan.py
90.55% <100%> (-0.66%)
:arrow_down:

stacker/tests/lookups/handlers/test_output.py
100% <100%> (ø)
:arrow_up:

stacker/exceptions.py
92.17% <100%> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1aad4f...317dfcc. Read the comment docs.

Can you run this by the folks in the stacker channel, just to make sure we aren't breaking anything for anyone we know of?

I ran it poll and nobody said they were using this. Makes sense; just using requires is pretty unlikely in itself, and someone going through the effort to do requires: [${namespace}-stack-name] is probably even more unlikely.

@ejholmes re:

just using requires is pretty unlikely in itself

FWIW, we mostly uses requires + native export/import over the output/param pattern because of the strong guarantees we get from pushing the dependency information into the CFN domain.

FWIW, we mostly uses requires + native export/import over the output/param pattern because of the strong guarantees we get from pushing the dependency information into the CFN domain.

Cool, good to know. We don't have any plans to get rid of requires, so you're still good as long as you're using the "short name" (the name of the stack without the namespace added to it).


Add some TileSet editor keyboard shortcuts.

simply adds much needed keyboard shortcuts for "Select", "New Rectangle", and "New Polygon" buttons in the TileSet editor. For me this significantly reduces wrist strain when editing large or complex tile sets, since it removes the need to repeatedly navigate the cursor up to the toolbar and back down again.
Defaults I chose are:
CTRL-1: Select
CTRL-2: New Rectangle
CTRL-3: New Polygon

@norton-corbett Is this still desired? If so, it needs to be rebased on the latest master branch.

This PR has been abandoned by its author, no response for over 2 months. Closing.


ENH: add center patch prediction

this adds functionality to predict on a patch and keep the model output for a central region of that patch. This is how model inference is done for the TIL models in https://doi.org/10.3389/fonc.2021.806603
fixes #33

I am closing this because do not have a use for this functionality now. In the future, we might...


don't reduce insulinReq for expectedDelta (we have minGuardBG for that)

Even if BG is dropping when we enter carbs, we generally want SMB to be able to get insulin started quickly, unless minGuardBG predicts BG will drop too low.  This PR comments out the code that previously reduced insulinReq when minDelta was < 0 but > expectedDelta.

This is ready to merge if no objections.


docker: Use amd maintained base for mpi/ucx/...

To be tested but that should work (it build locally at least)

It gives me some weird permission error locally not sure why but yeah seem like the "nicer" way to do it without caring about maintaining a base

Superseeded by #2104, closing


phwmon: remove

Description of changes
It seems some were still interested in this package as of 2 years ago but the upstream issue for python3 support hasn't seen any movement.
cc @romildo

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Although it is not essential, I still use phwmon. But I do not have a solution to its dependence on python 2. I would keep it in nixpkgs unless it stops working or its removal is essential for other important parts of the system to progress.

@romildo maybe you can find an alternative? it's probably a goal to remove all python 2 eventually

@romildo maybe you can find an alternative? it's probably a goal to remove all python 2 eventually

Feel free to remove it. If one day it is ported to python 3, one can repack it.

Change looks good.
@armeenm please rebase.

Rebased.


Codon usage

Please review initial code for codon usage table download and parsing.

I can confirm that the functions run fine in Jupyter.
Unittests were OK and the code looks good too.


[WB-3559] Add missing attributes/methods to run object

Fixes: https://wandb.atlassian.net/browse/WB-3559
Did an audit of attributes we want to support from 0.9.7 and added to unit tests
Fixed a bunch of error messages when running tests due to missing shutdown of the message queue

Merging. if you have any comments, please let me know and I will fix things up


remove some packages marked broken for over 1.5 years

Description of changes
Partially automated with this script:
#!/usr/bin/env nix-shell
#!nix-shell -i bash -p jq -p git
set -eux
cutoffTS=$(date -d "now - 18 months" +%s)
unset NIX_PATH
NIXPKGS_ALLOW_BROKEN=1 NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-env -f . -qaP --json --meta > all_pkgs.json
# idk what meta.position does here, but attrsets.nix is _probably_ wrong
grep -vE '(haskell-modules|node-packages|lib/attrsets.nix)' $(nix-build ./test.nix) | while read f; do
    file=$(cut -d" " -f2 <<< "$f")
    attr=$(cut -d" " -f1 <<< "$f")
    ln=$(grep -n 'broken.*=.*$' "$file" | cut -d: -f1)
    # echo "$file: $ln"
    # [[ "$ln" == "" ]] && continue
    blame=$(git blame -p "$file" -L "$ln,$ln" | tee)
    commit=$(echo "$blame" | head -n1 | cut -d" " -f1)
    author=$(grep -oP "(?<=^author ).*(?=$)" <<< "$blame")
    authorDate=$(date -d "@$(grep -oP "(?<=^author-time ).*(?=$)" <<< "$blame")" --rfc-3339=date)
    commitTS=$(grep -oP "(?<=^committer-time ).*(?=$)" <<< "$blame")
    [[ "$commitTS" > "$cutoffTS" ]] && continue
    commitDate=$(date -d @"$commitTS" --rfc-3339=date)
    git rm "$file"
    git commit -m "$attr: remove after being marked broken for over 18 months

It was marked in commit $commit by $author on $authorDate (commited on $commitDate)"
done

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

idk, tbh. I don't think we backport things like this and the packages are already marked as broken on there, so it's not like they present a security risk or anything.

Sure

https://github.com/NixOS/nixpkgs/pull/179011 shows that this PR removed default.nix but left *.patch files behind for syncthing-gtk.
There might be more left-overs from this incomplete PR.

oops. Thanks for noticing that. I skimmed to other commits again and I think I got all the files in those.

oops. Thanks for noticing that. I skimmed to other commits again and I think I got all the files in those.

Assuming that a package removal means removing its default.nix, it looks like syncthing-gtk's patch was the only left-over according to this snippet run against latest master:
$ git ls-files $(gh pr diff 175961 | lsdiff --strip=1 -i '*/default.nix' | rev | cut -d/ -f2- | rev)
pkgs/applications/networking/syncthing-gtk/paths.patch

sadly it isn't always that easy. some packages don't come from/with a default.nix, see e.g. 6da0d2b7a642aaa643b002083e5ed1558ecbe335


Autocomplete - Allow end user to modify autocomplete filter

Proposed changes
Move autocomplete filter to a configuration item. Useful for the following reasons:

Allow the developer to make custom filter.
Reduce amount of new features to be introduced into the code base.
Other libraries (Awesomplete) already do this.
Change is low risk.
66 lines of unit tests for 4 lines of code change

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

merged into rollup. Will be included in next release


Material toggle

Add material toggles for 3D views.

:tada: This PR is included in version 1.3.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BLOCKED] Release v0.22.0

I think we want to wait for https://github.com/rust-bitcoin/rust-bitcoin/issues/284.
Also blocked on https://github.com/rust-bitcoin/rust-bitcoinconsensus/pull/11.

We don't want to bump the secp or bitcoinconsensus versions in this release, so that people have an opportunity to update to the new APIs without needing to update everything at once.

We will release 0.23 with no changes except for the dep bumps.

Ah yeah right, forgot about that. Will update accordingly.

Codecov Report

Merging #366 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   82.56%   82.64%   +0.08%
==========================================
  Files          39       39
  Lines        8236     8265      +29
==========================================
+ Hits         6800     6831      +31
+ Misses       1436     1434       -2

Impacted Files
Coverage Δ

src/network/stream_reader.rs
95.13% <0%> (+0.16%)
:arrow_up:

src/network/message.rs
70.84% <0%> (+1.15%)
:arrow_up:

src/network/address.rs
83.92% <0%> (+3.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a643ac4...35ad4a4. Read the comment docs.

@stevenroose can you add #349 to this and remove "Blocked"


What is the speed of the prediction in test.py ?

I was wondering if anyone has tested the speed of the prediction in test.py. I tried it on a system with nvidia K80, cuda8.0 and it took around 2-3s for the prediction.

@rahulranjan07
I have not tested thoroughly. According to my experience, most of time is spent on zoom() on CPU. And also, I am using 5 scales for testing, which is basically 5 times of a single pass.

Yes, I saw that. I would try to implement pytorch multiprocessing on these scales and check if it gives a better timing.


[AIRFLOW-1560] Add AWS DynamoDB hook and operator for inserting batch…

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1560

Description

[x] Here are some details about my PR, (No UI Changes):

The PR addresses airflow integration with AWS Dynamodb.
Currently there is no hook to interact with DynamoDb for reading or writing items (single or batch insertions). To get started, we want to push data in DynamoDB using airflow jobs (scheduled daily). Idea is to read aggregates from Hive and push in DynamoDB (write data job will run everyday to make this happen). First we want to create DynamoDB hooks (this PR addressed the same) and then create operator to move data from Hive to DynamoDB.
http://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#service-resource
Something to think about - Performance
I think airflow's generic approach for reading all data from source and then transferring to the destination by either storing source data in memory or disk is not the best optimized approach (in cases of big data with potential performance issues). When I started my initial design - I categorized it into 2 use cases a) small data b) big data.. The operators written in airflow code right now mostly handle small data (so does this PR). My approach would be to start with this operator (small data) and then handle big data use case if we see performance issues. I have some thoughts on how we can handle big data operations (using batching mechanism). For instance:

Fetch all distinct id's (primary key) from source
Create N buckets and assign bucket number to all the id's
For each bucket : fetch data from source and then insert into destination.

Plan to handle this in subsequent PR.
Something to think about - Other ways of transferring data from hive to dynamodb
There can be multiple ways for this data transfer to occur and here are some of the thoughts on current design decisions (KISS - keep it simple and sweet):

Lambda function : You can write a lambda function to transfer data and trigger the function using AwsLambdaHook (https://github.com/apache/incubator-airflow/pull/2570) but lambda lifetime is 5 mins and if the data transfer takes longer lambda will die.

Amazon Ecosystem (Amazon EMR, Big Data Pipeline, AWS Glue): Not to forget adding these systems create additional complexities (aws dependencies, aws limits, system complexities, IAM issues, airflow integrations with additonal dependencies and ofcourse $$)

http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBPipeline.html

Not to forget insertions in dynamodb are tricky because of WCU's and boto handles the insertions gracefully by automatically throttling insertions (buffering etc)

Tests

[x] My PR adds the following unit tests :

test_aws_hook.py
adds mock_dynamodb2 from moto (https://github.com/spulec/moto). Wrote a test case to get aws resource object for dynamodb and create table via resource object and assert if count of items in table is 0 (implies table was created).

test_dynamodb_hook.py
adds mock_dynamodb2 from moto (https://github.com/spulec/moto). Wrote a test case to get aws resource object for dynamodb and create/insert data in dynamodb table. Then this unit test writes 10 items in the table using write_batch_data operation

HiveToDynamoDBTransferTest
this unit test checks the workings of HiveToDynamoDB operator by inserting 1 record in dynamodb table via write operation.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@bolkedebruin resolved commits. thanks

@artwr @criccomini seems like you guys reviewed similar AWS related PR - https://github.com/apache/incubator-airflow/pull/1630
Would be great if you could help review my PR. Any inputs are welcome (this is my first contribution to airflow) :)

Codecov Report

Merging #2587 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
+ Coverage   70.86%   70.87%   +<.01%
==========================================
  Files         150      150
  Lines       11617    11617
==========================================
+ Hits         8232     8233       +1
+ Misses       3385     3384       -1

Impacted Files
Coverage Δ

airflow/hooks/hive_hooks.py
40.17% <0%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b978b2...ae43038. Read the comment docs.

@skudriashev thanks for reviewing. I have cleaned up some parts and pushed again.

This PR is way more useful than just adding a DynamoDB. It adds boto's general "resource" API to the aws_hook, where previously it only had boto's "client". This will provide a good base for extending the AWS operators / sensors / hooks for other AWS services. I can see that there has been a significant addition of tasks for interacting with Google's cloud, but the AWS side now needs to catch up and this could contribute to that aim.

This other PR makes a similar change to the aws_hook to add the "resource" type, so that the s3_hook can  be upgraded to using boto3: https://github.com/apache/incubator-airflow/pull/2532

LGTM

thanks @bolkedebruin


fix (#minor); makerdao-ethereum; fixed procotoal side rev from wrong liquidation penality #1785

This fixes the issue in protocol side revenue (#1785) due to liquidity penalty using incorrect decimals for the Cat V1 contract.

cat v1: https://etherscan.io/address/0x78f2c2af65126834c51822f56be0d7469d7a523e#code
cat v2: https://etherscan.io/address/0xa5679C04fc3d9d8b0AaB1F0ab83555b301cA70Ea#code

deployment & validation

deployment: https://thegraph.com/hosted-service/subgraph/tnkrxyz/makerdao-ethereum?version=pending
validation dashboard: https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmdN5XkS372qmKv1mDVq9SJZ68PsMb9YXrXRZS3Qha3Xfc&tab=protocol

awaiting sync

Confirmed, fixed the issue :)
also the recent increase in supply-side revenue is due to increase in dai savings rate


Vehicles don't track their cargo weight anymore

Adding items to vehicle cargo doesn't add their weight to the weight bar at the bottom of the vehicle sheet anymore after latest updates (v12 stable and dnd5e 3.2.0). It was still working on fvtt v11.315 with dnd5e 3.1.2

Cargo tracking is still working fine, but it doesn't seem to be taking equipment weight into account.

It is also massively over-counting the weight of coins, so that will need to be fixed.


[BUG]: Snake Animation

Description of the bug
Hello, there seems to be a bug in that snake animation. I think you should update it.

here is the original author's repo https://github.com/Platane/Platane
you know what to do next, haha, wish you a happy life！
Steps To Reproduce
none
Additional Information
none

Hello @sun0225SUN 👋,
Thanks a lot for reporting that bug🐛.
It now has been fixed.😁🎉


Define Congestion Thresholds

Context:
Working with Tim/Chris to define various congestion thresholds using INRIX data samples.
Timebox:
2 days


Bump version

🗣 Description
This pull request bumps the version so we can build a fresh AMI.
💭 Motivation and context
The previous AMI is getting long in the tooth, so we are overdue for a rebuild.
🧪 Testing
All pre-commit hooks pass.  I also built a staging AMI and deployed it to our staging COOL environment and verified that it functions as expected.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.
[x] Create and test a staging AMI with these changes.

✅ Pre-merge checklist

[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a production AMI with these changes.

Does this deserve a minor version bump? Comparing the v0.1.3 tag to the 0.2.0-rc.1 tag I only see linter and Terraform changes. This AMI configuration was already using a Bullseye image.

Son of a gun!  I will fix it. :man_facepalming: