Foreign key constraint breaks transaction state

A foreign key constraint that's classified as deferred (see SQLite docs here) breaks the transaction state.
Example program:
package main

import (
	"database/sql"
	"fmt"
	_ "github.com/mattn/go-sqlite3"
)

func main() {
	db, _ := sql.Open("sqlite3", "file::memory:")
	db.Exec(`PRAGMA foreign_keys=ON`)
	db.Exec(`CREATE TABLE "pk_table" ("id" integer not null primary key autoincrement)`)
	db.Exec(`CREATE TABLE "fk_table" ("fk" integer not null default 0 REFERENCES pk_table(id) DEFERRABLE INITIALLY DEFERRED)`)
	tx, _ := db.Begin()
	tx.Exec(`INSERT INTO "fk_table" (fk) VALUES (0)`)
	tx.Commit()
	tx, err := db.Begin()
	fmt.Println(err.Error())
}

For a more profound example with proper error checking:
fk_constraint_transaction.go.txt
According to the semantics of database/sql, a transaction must be finished after a call to tx.Commit().
However, according to SQLite documentation of deferred foreign key constraints:

Deferred foreign key constraints are not checked until the transaction tries to COMMIT. For as long as the user has an open transaction, the database is allowed to exist in a state that violates any number of deferred foreign key constraints. However, COMMIT will fail as long as foreign key constraints remain in violation.

A very similar issue was reported here: #184

As you can see in the upper example, PRAGMA foreign_keys=ON is required.

seem to be fixed by https://github.com/mattn/go-sqlite3/pull/407

@mattn Thanks for the effort. However, I keep on getting the same error even with the patch from #407:

cannot start a transaction within a transaction

This PR here: https://github.com/mattn/go-sqlite3/pull/300 addresses a similar issue, but the fix is limited to cases where the error condition is SQLITE_BUSY.
Unfortunately, the error in the case described above seems to be a very generic SQLITE_ERROR type error, which might be anything. Otherwise I would have suggested to simply extend the error check from SQLiteTx.Commit() in a way that it checks for "transaction within a transaction", too.


Proposal to Update README with Github Actions Workflow Information

Hello,
I've been experiencing issues with Github Actions workflows not being triggered. After some research, I found out that this behavior is actually a deliberate decision made by Github. More context can be found here.
I think that adding a note about this to the README could be beneficial to prevent confusion for future users. Would you be open to a PR where I add this information?
Looking forward to your response.

Sound great, any PR is welcome!

@Elph PR summited.


README - Add Developer Setup

Update the root README file with a clean developer setup that includes the following:

Getting started
Configuring your machine
Development (general)

Draft PR - work in progress: https://github.com/ansible/azure-aap-deployment-driver/pull/22

no needed.


feat: highlight whole context block

Highlight "whole context" JSON blocks. Partially addresses https://github.com/mattpocock/xstate-catalogue/blob/master/ideas.md#visual-ideas.
e.g. see the drag & drop machine

So good! Instant merge


Variables Graphical View doesn't show up on raspberry pi

As I said I don't get the "variable graphical view" to work, neither as widget nor in the sensor-details:
Log stays empty as well, maybe increase the loggerlevel? But I don't know which one:
2016-08-05 13:05:49,145 INFO [main] [org.mycontroller.standalone.StartApp:209] TJWS server started successfully, HTTPS Enabled?:true, HTTP(S) Port: [8443]
2016-08-05 13:05:49,146 INFO [main] [org.mycontroller.standalone.StartApp:107] MyController.org server started in [20661] ms
[Fri Aug 05 13:05:55 CEST 2016] IO error: javax.net.ssl.SSLException: Connection has been shutdown: javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection? in processing a request from /<IP_ADDRESS>:8443 / sun.security.ssl.SSLSocketImpl
2016-08-05 13:07:46,362 INFO [Acme.Utils.ThreadPool(1)-PooledThread: Acme.Serve.Serve$ServeConnection@14b40fc] [org.mycontroller.standalone.gateway.mqtt.MqttGatewayImpl:70] MQTT Gateway[tcp://localhost:1883] connected successfully..
2016-08-05 13:15:17,765 INFO [Acme.Utils.ThreadPool(6)-PooledThread: Acme.Serve.Serve$ServeConnection@293a6b] [org.mycontroller.standalone.mqttbroker.MoquetteMqttBroker:71] MQTT broker restart triggered...
2016-08-05 13:19:24,743 INFO [Acme.Utils.ThreadPool(6)-PooledThread: Acme.Serve.Serve$ServeConnection@62c4af] [org.mycontroller.standalone.gateway.mqtt.MqttGatewayImpl:70] MQTT Gateway[tcp://localhost:1883] connected successfully..

PS: This only affects the "Variables graphical view". Other graphical widgets are working fine. This issues affects dashboard and sensor-detail view stuff.

Well I found the solution .. blocked by "ublock origin"

Maybe remap this path? "metrics/metrics" get blocked on at least "my" adblocker:

@cimba007 Are you running browser on Raspberry PI? No one reported metrics/metrics blocked by ad blocker. This is the first time. Which Ad blocker are you using? I'm using AdBlock and I never face issues like this.

I am using "uBlock Origin". mycontroller is running on my raspberry and I browse from my main computer running chrome.
The /metrics/metrics gets blocked by an adblock list named:

No big dead as the only thing I had to do was to whitelist my raspberry .. but I remember some1 else having a problem with "widgets loading forever" .. maybe he hat the same addon? (Issue was posted on the forums)

Nevertheless .. I noticed the loading time of the graphic is very long on one particular graph.
6 hours .. 1 measurement per seconds = 3600*6 = 21600 to display/calculate average .. where does the caluclation of the graph happen? Does the client calculate the average/min/max over 21600 points or the server? The graph is very slow on my raspberry and on my i5-3570k@4,2ghz so I guess there has to be some hidden bottleneck:
As you can see the graph kind of "stuck" after a few cm and then takes like ~10-15seconds. No "big" deal but maybe something that can be improved .. ofc. I can reduce my note to not send data every seconds for 3 graphcs ;-)

@cimba007

The adblocker I use is "uBlocks origin" (chrome)
The /metrics/metrics gets blocked by an adblock list named:

It looks like if we have repeated name in url, uBlocks blocks it. I will fix this one.

Nevertheless .. I noticed the loading time of the graphic is very long on one particular graph.

It should not happen. Did you change default settings of Settings >> Metrics >> Data retention settings?

6 hours .. 1 measurement per seconds = 3600*6 = 21600 to display/calculate average .. where does the caluclation of the graph happen? Does the client calculate the average/min/max over 21600 points or the server? The graph is very slow on my raspberry and on my i5-3570k@4,2ghz so I guess there has to be some hidden bottleneck:

All calculation happens on server side. That too with separate thread. When we query takes metric data from database without any calculation. Oracle java is recommended for Raspberry PI.

As you can see the graph kind of "stuck" after a few cm and then takes like ~10-15seconds. No "big" deal but maybe something that can be improved .. ofc. I can reduce my note to not send data every seconds for 3 graphcs ;-)

This is kind of issue that graph will not get expand loads all the data in few cm. Few cm data loaded immediately?

It should not happen. Did you change default settings of Settings >> Metrics >> Data retention settings?

Nothing changed here. I narrowed down the issue a little bit:
Have a very close look at the first picture. This is already all data!!! Only the visualization is compressed to 1cm. After the named time 5-10seconds the graph "expands" .. showing exactly the same data but now only normal. Maybe this is an issue with the width-detection of the window? I am not sure.

@cimba007 Yes, there is an issue with graph. In our controller source it is located at https://github.com/mycontroller-org/mycontroller/blob/development/dist/src/main/package/www/controllers/sensors.js#L409
Actual issue: https://github.com/krispo/angular-nvd3/issues/40
I will check a way and fix this one. Thank you!

If you have an idea how to fix this feel free to contact me if you need some1 to test the fix. I like your project very much .. looks like a lot of work and dedication went into this project.

@cimba007 I'm unable to reproduce this issue. Can you check by changing value from 1000 to 1500 in your comtroller code on https://github.com/mycontroller-org/mycontroller/blob/development/dist/src/main/package/www/controllers/sensors.js#L415
in installed location >> mycontroller/www/controllers/sensors.js#L415

I haven't run my sensor node for the last few days. Just started collections values a few hours ago. I will check when I have at least enough values to fill the 6hour window.

Currently I cannot reproduce the issue. The graph shows the first cm and now after a split seconds will show the rest (as opposed to 30 sec delay when I opened the issue).

I'm closing this issue. We can reopen if we can reproduce.


backport(v3.2.x) onto the v3.x branch

Proposed Changes

This is a backport PR including all non-breaking changes since 3.1.0

We're landing breaking changes on main at the moment, so if we want to eventually do a 3.2.x release, we need to branch at https://github.com/cloudevents/sdk-javascript/commit/f3953a9a5abf5c0267247f9939cf567a47eccd91. We'll probably want to backport the following PR and commits before a release.

https://github.com/cloudevents/sdk-javascript/pull/328

https://github.com/cloudevents/sdk-javascript/commit/4779d89ad054973cb0af8ec4119e073b78970392

https://github.com/cloudevents/sdk-javascript/commit/7423acb7fc4d431cc8d335fd5ccb1ad4a1f28a65

Version: Pending 3.2.0

Can't quite figure out why DCO check is failing. A visual scan of all commits shows them all as signed off.

Can't quite figure out why DCO check is failing. A visual scan of all commits shows them all as signed off.

The check is complaing about this commit:
https://github.com/cloudevents/sdk-javascript/pull/336/commits/8ac3eb0c69d980a4475052ce3f102b8b88602fa5

@lholmquist I see it complaining about this one https://github.com/cloudevents/sdk-javascript/pull/336/commits/f3953a9a5abf5c0267247f9939cf567a47eccd91. I just set that DCO check to pass manually, since a review of the commit message shows that it has been signed off.

@cloudevents/sdk-javascript-maintainers I think we should be ready to drop a v3.2.0 release. GTG?

LGTM

@lance when you do merge this,  don't hit "Squash and Merge" :)


Coverage report generation is broken

Running dune runtest --instrument-with bisect_ppx --force doesn't run the full test suite, failing at some point of the execution, whereas running the same command without instrumentation runs the whole test suite.
The error shown if the following:
File "src/lib/mina_state/snarked_ledger_state.ml", line 479, characters 54-62:
479 |     let ( || ) b1 b2 = Tick.(Run.run_checked Boolean.(b1 || b2))
                                                            ^^^^^^^^
Error: This variant expression is expected to have type
         'a Run.Internal_Basic.Checked.t
       There is no constructor true within type Snarky_backendless__Checked_runner.Simple.Types.Checked.t

I was able to confirm that this is the error preventing the tests from running. Excluding the file from coverage generation, the codebase builds and tests are run.

Should be fixed by #13005


Support custom parameters

Since we don't have a way to pass custom parameters yet, this PR addresses that. I'm also new to flutter, open to suggestions or better solutions.
Testing:
• Use this as a guide on how to pass custom params.
• I added a log in onCallStateChanged so that it'll print custom data if its not null

Thank you @KPR7168, looks very good! I'll just do some small changes but thanks a lot for designing it!

Thank you @KPR7168, looks very good! I'll just do some small changes but thanks a lot for designing it!
So one question, I see that you are sending this on 'Ringing' which I believe is only received on the caller and not the calle

My mistake, it seems that ringing is sent on two places

Hello @KPR7168, can you test these changes?

@diegogarciar looks good to me.

Awesome, merging then!


[Bug] 使用llamafactory训练 glm4的lora-rm模型、glm4的freeze-kto模型等，出现部署问题ValueError: Input None is not valid. Should be a string, a list/tuple of strings or a list/tuple of integers.

Checklist

[x] 1. I have searched related issues but cannot get the expected help.
[x] 2. The bug has not been fixed in the latest version.
[x] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug
Traceback (most recent call last):
|   File "/opt/conda/lib/python3.10/site-packages/starlette/responses.py", line 261, in wrap
|     await func()
|   File "/opt/conda/lib/python3.10/site-packages/starlette/responses.py", line 250, in stream_response
|     async for chunk in self.body_iterator:
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/serve/openai/api_server.py", line 503, in completion_stream_generator
|     async for res in result_generator:
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/serve/async_engine.py", line 576, in generate
|     prompt_input = await self._get_prompt_input(prompt,
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/serve/async_engine.py", line 525, in _get_prompt_input
|     input_ids = self.tokenizer.encode(prompt, add_bos=sequence_start)
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/tokenizer.py", line 600, in encode
|     return self.model.encode(s, add_bos, add_special_tokens, **kwargs)
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/tokenizer.py", line 531, in encode
|     return super(ChatGLM4Tokenizer, self).encode(s,
|   File "/opt/conda/lib/python3.10/site-packages/lmdeploy/tokenizer.py", line 366, in encode
|     encoded = self.model.encode(s,
|   File "/opt/conda/lib/python3.10/site-packages/transformers/tokenization_utils_base.py", line 2629, in encode
|     encoded_inputs = self.encode_plus(
|   File "/opt/conda/lib/python3.10/site-packages/transformers/tokenization_utils_base.py", line 3037, in encode_plus
|     return self._encode_plus(
|   File "/opt/conda/lib/python3.10/site-packages/transformers/tokenization_utils.py", line 719, in _encode_plus
|     first_ids = get_input_ids(text)
|   File "/opt/conda/lib/python3.10/site-packages/transformers/tokenization_utils.py", line 705, in get_input_ids
|     raise ValueError(
| ValueError: Input None is not valid. Should be a string, a list/tuple of strings or a list/tuple of integers.
Reproduction
CUDA_VISIBLE_DEVICES=1 lmdeploy serve api_server saves/glm4/lora/train_2024-06-27-13-34-50-rm22/export_model/ --server-port 23333 --max-batch-size 128 --tp 1 --model-name xxxxx
Environment
lmdeploy==0.5.3

Error traceback
No response

same question when use glm4 awq
lmdeploy==0.5.3

@ldknight 方便提供下模型么？

遇到相同问题

@ShulinJ 烦请提供下复现代码

一样的问题，用llamafactory微调glm4，把模型合并后使用也是这个问题，用Transformers可正常加载

更新到 0.6.0, 指定对话模板名 glm4
lmdeploy serve api_server <model_path> --chat-template glm4


Build error when using DYNAMIC_ARCH=1 inside a virtual machine

I am inside a KVM virtual machine, which has generic CPU-Information
processor       : 0
vendor_id       : GenuineIntel
cpu family      : 6
model           : 2
model name      : QEMU Virtual CPU version 1.0
stepping        : 3
microcode       : 0x1
cpu MHz         : 2899.998
cache size      : 4096 KB
fpu             : yes
fpu_exception   : yes
cpuid level     : 4
wp              : yes
flags           : fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pse36 clflush mmx fxsr sse sse2 syscall nx lm rep_good nopl pni vmx cx16 popcnt hypervisor lahf_lm
bogomips        : 5799.99
clflush size    : 64
cache_alignment : 64
address sizes   : 40 bits physical, 48 bits virtual
power management:

The build fails with the error:
getarch_2nd.c:12:35: error: ‘SGEMM_DEFAULT_UNROLL_M’ undeclared (first use in this function)
     printf("SGEMM_UNROLL_M=%d\n", SGEMM_DEFAULT_UNROLL_M);

even though DYNAMIC_ARCH=1 is used during configuration, which indicates that the CPU was not detected properly.
My expected behaviour is that the build should generate a generic library.
Is it really necessary to set the TARGET, as it is done e.g. in the .travis.yml: https://github.com/xianyi/OpenBLAS/blob/develop/.travis.yml ?

Seems your virtual machine received  a set of cpu capabilities that matches no "known" actual processor model, so choosing a TARGET becomes necessary.

@martin-frbg: I'd like to be able to build a general version of openblas (which I was expecting to get with DYNAMIC_ARCH) which would run fine (and preferably fast) on all machines I'd copy the binary to.

DYNAMIC_ARCH build will still contain all available cpu-specific codes for the architecture (and runtime cpu detection to choose one), but the build still needs to know what the cpu in the build host is.

@martin-frbg: I don't quite understand why the build needs to know which cpu architecture the build host has. Shouldn't the build be independent of the build-host cpu-type?

Could be something as mundane as the DYNAMIC_ARCH of being a later add-on on top of the host-specific build, or to be able to run the tests as part of the build process (not sure if current versions still do this for DYNAMIC_ARCH builds, but the general code dates back to libgoto). Probably not worth rewriting the build system just to save a small fraction of the user base the trouble of configuring a "sane" cpu in their emulator.

As years old faq says - expose realistic CPU (or look in Makefile.rule to avoid reality checks)
https://github.com/xianyi/OpenBLAS/wiki/faq#qemu

I see that this has now been addressed in the original context (nixOS) by supplying a low-featured cpu type as a TARGET to the build task. Any objections to closing this here as well ?

For me personally it solves the problem, so I don't oppose closing the issue.


[WIP][AGORA-1849] Formal OAS for Agora API

PR-Codex overview
This PR sets up a GitHub Actions workflow for CI that lints a Swagger API definition file.
Detailed summary

Added GitHub Actions workflow for CI with Swagger linting
Defined OpenAPI spec for Agora API with detailed information
Added paths for retrieving lists of delegates and specific delegate details

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

You can use the following in-browser OAS editor and validator to get a prettier view of the API if you'd like:
https://editor-next.swagger.io/
Just copy-paste oas_v1.yaml into it.

@kent @andreitr @stepandel, how do you feel about having discussion and feedback on the proposed schema on this PR?

@kent @andreitr @stepandel, how do you feel about having discussion and feedback on the proposed schema on this PR?

should we just follow this spec @Flip-Liquid ? https://www.notion.so/argoagora/Agora-s-OP-API-Draft-Document-32b2bed3193841d4b272b5ab39167cbb

@kent @andreitr @stepandel, how do you feel about having discussion and feedback on the proposed schema on this PR?

should we just follow this spec @Flip-Liquid ? https://www.notion.so/argoagora/Agora-s-OP-API-Draft-Document-32b2bed3193841d4b272b5ab39167cbb

yup, that comment was from a few days ago before we had that notion doc


Enum for Direction parameter in History

This PR should resolve https://github.com/ably/ably-flutter/issues/83. I've replaced previously used String value with an enum shared between RealtimeHistoryParams and RestHistoryParams. Sadly, this is a breaking change, because it's not possible to deprecate unnamed constructors in Dart, but since it's a rather small difference, I don't think it should cause too many issues. I've left a note about this in UPDATING file.

As these are breaking changes, is there a critical need to merge these changes until we're able to do a major release?

As these are breaking changes, is there a critical need to merge these changes until we're able to do a major release?

It's nothing really urgent, so I guess we can wait. On the other hand, it's a small change and it should be relatively easy for users to adapt to it.

@stmoreau @QuintinWillison I've changed the base of this PR to integration/version-2, so we can merge breaking changes in the next major version


Reify on associations fails when associations were destroyed

Situation 1:
Assume contract has_many invoices. When contract is modified, invoices are destroyed and created, by method called make_invoices. And make_invoices destroy old invoices before contract updated. That results to invoices.deleted_at < contract.updated_at < invoices.created_at. While reifying contract, contract.versions.last.reify(has_many: true, mark_for_destruction: true).invoices won't rebuild destroyed invoices, due to their deleted_at < contract.updated_at = versions.created_at.
Is created_at > version_at at lib/paper_trail/reifiers/has_many.rb#104 in load_versions_for_hm_association
where("created_at >= ? OR transaction_id = ?", version_at, tx_id) necessary?

Thanks for the bug report. Per our contributing guide please use
our bug report template.

Closed due to insufficient information. Per our contributing guide please use
our bug report template.


Watch mode failed to render

I'm pretty frequently getting messages like the following and an empty file when running in watch mode on Ubuntu 18.10:
ℹ Changed template src/html/index.html
⚠ Failed to render src/html/index.html, null output
✔ Wrote index.html

If I save the file again, it seems to build correctly. I also have the verbose flag enabled, but those are the only messages I'm seeing.
I think it might be related to https://github.com/babel/babel/issues/4332 and https://github.com/postcss/postcss-cli/issues/215, which were both fixed by adding awaitWriteFinish options to chokidar.watch.

Just released v3.0.7, It fixes two issues one of which is related to this.
Outputs were null primarily because no actual error was handled while rendering a template, and more honestly errors were ignored with a null output. This is no longer the case and from now rendering error will fail with a stack trace.
This is better because we can take a look at the error to see if something is wrong in our config our njk is doing something unexpected.
Let's hope this will make this issue more easy to debug, before applying any fixes.
Please have a look at examples in the wiki also.
Thanks for improving it 🎉.

Thanks for the quick update! I'm unfortunately still having the same problem. The only difference is that now the ⚠ Failed to render src/html/index.html, null output no longer appears, but an empty file is still generated. Saving again correctly builds the file most of the time.
I can sit on the same file without editing, and hit save every few seconds. Most of the time the file is generated correctly, but occasionally an empty file is created instead. The log always appears the same regardless of what happens, with no additional messages:
ℹ Changed template src/html/index.html
✔ Wrote index.html

Unfortunately adding awaitWriteFinish to chokidar doesn't seem to change anything for me locally.

Can you share me the file with the exact command you are running so that I can reproduce it.

@mohitsinghs I setup a demo repo at https://github.com/mdmoreau/njk-demo. It doesn't happen super consistently, but it does output empty files a decent amount.

@mdmoreau Thanks for the setup. I tried it but it is quite surprising that I am unable reproduce the empty outputs despite of frequently saving both source files. Tested on windows too.

@mohitsinghs Thanks for the help! This is what I'm getting in the log when an empty file gets created:
ℹ Changed template src/html/index.html
{ constructed: '' }
{ rendered: '' }
{ written: '' }
✔ Wrote index.html

@mohitsinghs Thanks for the help! This is what I'm getting in the log when an empty file gets created:
ℹ Changed template src/html/index.html
{ constructed: '' }
{ rendered: '' }
{ written: '' }
✔ Wrote index.html

Looks like file is not even being passed. We need to dig deeper. Going update that branch with more logs right now.

@mohitsinghs Thanks for the extra output. Getting this now when it builds an empty file:
{ chokidar: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
ℹ Changed template src/html/index.html
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ preparing: '' }
{ constructed: '' }
{ rendered: '' }
{ written: '' }
✔ Wrote index.html

Here's the output when it renders correctly, though I imagine it's the same as what you're seeing:
{ chokidar: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
ℹ Changed template src/html/index.html
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ preparing:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ constructed:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ rendered:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
{ written:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
✔ Wrote index.html

This is when saving through VS Code on Ubuntu 18.10 for what it's worth.

@mohitsinghs I figured I'd try saving through another editor (gedit), and I haven't been able to generate an empty file yet. The strange thing is that I'm getting all of this output on just one file save:
{ chokidar:
   '/home/mdmoreau/Desktop/njk-demo/src/html/.goutputstream-TJ1LUZ' }
ℹ Changed template src/html/.goutputstream-TJ1LUZ
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ chokidar: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
ℹ Changed template src/html/index.html
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ preparing:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ constructed:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ rendered:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
{ written:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
{ preparing:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ constructed:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ rendered:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
{ written:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
✔ Wrote index.html
✔ Wrote index.html
{ chokidar:
   '/home/mdmoreau/Desktop/njk-demo/src/html/.goutputstream-TJ1LUZ' }
ℹ Changed template src/html/.goutputstream-TJ1LUZ
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ preparing:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ constructed:
   '{% extends "templates/default.html" %}\n\n{% block body %}{% endblock %}\n' }
{ rendered:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
{ written:
   '<!doctype html>\n\n  \n    <meta charset="utf-8">\n    <meta http-equiv="x-ua-compatible" content="ie=edge">\n    <title>build</title>\n    <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n  \n  \n    \n  \n\n' }
✔ Wrote index.html

It seems like that is working correctly, though it looks odd, and the issue might be with VS Code (https://github.com/Microsoft/vscode/issues/61310).

@mdmoreau Extra output is due to extra events emitted by chokidar which is due to swap files created by editors likes vim or gedit. I'll ignore dotfiles in the next release to fix that.

I made some more changes in null output branch and we are watching for changes only ( instead of all events ).
This  should fix extra output for editors like vim and gedit.

@mohitsinghs Seeing normal output when using gedit now, but still getting the following with the frequent empty file generation in VS Code:
{ chokidar: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
ℹ Changed template src/html/index.html
{ passed: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ preparing: '/home/mdmoreau/Desktop/njk-demo/src/html/index.html' }
{ nonpromised: '' }
{ promised: '' }
{ constructed: '' }
{ rendered: '' }
{ written: '' }
✔ Wrote index.html

May be worth just letting it sit for a while since it seems like it might be an issue with VS Code. Appreciate the quick responses though!

From this test this is confirm now that file is empty and some other tool is doing that ( Might be VSCode or some plugin of it ).

Sounds good - thanks!

Sounds good - thanks!


Client: CreateUser - fetch sites from the server

Server should return sites and default site.

Done!


"Select" component should render its items inside (or near of) its component tree

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
I have this code:
      <Select className={styles.public} value='public'>
        <MenuItem value='public'>Public</MenuItem>
        <MenuItem value='private'>Private</MenuItem>
      </Select>

When I click on my Select component, its values are rendered in body (i.e. pretty much in root area of DOM), in a some div with id="menu-".
But I wanted it to be inside or near the Select component.
Examples 🌈

Sorry, I don't have the examples yet (maybe I'll post something later?)
Motivation 🔦
Initially I wanted to say "it's a bug" but technically it's not bug, but I don't like this behaviour and here's why...
In my case I use this Select component in some component that can be minimized if you click somewhere outside of it. Of course, visually the menu items of the select are inside of the component. But in the DOM they are not. This ends up in a bug when my component gets minimized, because the click on the menu counts as "outside"

UPD. As a workaround, I'm using NativeSelect temporarily

You can disable it with MenuProps={{ disablePortal: true }}.

@eps1lon huh, this one is not obvious. It works. Thx!


postgres installation on wsl

going to try again to install postgres right into wsl and not share file systems
https://computingforgeeks.com/how-to-install-postgresql-13-on-ubuntu/

Actually going to try this one first
https://docs.microsoft.com/en-us/windows/wsl/tutorials/wsl-database
potentially helpful sites

https://stackoverflow.com/questions/56824788/how-to-connect-to-windows-postgres-database-from-wsl
https://serverfault.com/questions/1041981/how-can-i-connect-to-postgres-running-on-the-windows-host-from-inside-wsl2

changed default port to 5434

can't connect with pgadmin so trying this https://dzone.com/articles/setting-up-a-postgresql-database-on-an-ubuntu-inst#:~:text=To edit the configuration file,the version of PostgreSQL installed.

probably not the most useful stuff in the world but I have a bit of documentation about this here


WIP: Sync reasoner factpp

Add FaCT++ to supported reasoners accessible with sync_reasoner().

Reading the reasoned ontology from an rdflib graph back into the owlready2 triplestore needs to be implemented...


draft: merge webpack to vite

ref: https://github.com/graphql/graphiql/pull/2323#issuecomment-1104859303

I plan on coming back to this FYI! I have no wifi at home but now I'm at the office, so I may be able to put more time into helping you on this!

I don't have much time before 05.01, the work content is dead on the 30th, maybe I will have some time to deal with the 5.1-5.5 holiday

If you like! Would it be ok if I made some commits this week if I have some time?

Sorry it’s been a long time! But I would love to revive this PR and finish this up to help out the upstream graphiql2 and users who need more/ new formats. @jonathanawesome you may be interested in tinkering with this as well!

Sorry, I haven't been motivated to do this since using Apollo explorer
https://studio.apollographql.com/sandbox/explorer

Hello @acao any plans to revive this?

yes I was hoping someone would! just have not had time. I a move to pnpm and move all library builds to esbuild & vite, and upgrade webpack example(s) to 5 and update vite examples etc.

@rxliuli i hope it's ok if we re-open your PR for reference as we make the migration?

@rxliuli i hope it's ok if we re-open your PR for reference as we make the migration?

Of course, feel free to use

@rxliuli thank you and thank you for this helpful draft PR! I'm happy you found a tool that works for you. GraphQL is the only mission!

@shabab477 let me know if and when you'd like to take this on! I just want to get a few more releases out to the LSP, and some fixes for<EMAIL_ADDRESS>before i dive down this important but inevitably complex "rabbit hole" haha

@acao I went over the repo. I'm open to work this weekend after my "usual" work 😉

@acao i created a PR here but seems a lot has changed since this commit has been made. I will have resolve the conflicts.

closed by https://github.com/graphql/graphiql/pull/3679


Enhancement: Please Add DataTables::TableTools plug-in to the UI

DataTables has a nice plugin TableTools. This allows for a one-click export to CSV/Excel/PDF.
https://www.datatables.net/extensions/tabletools/
ColVis might be another nice UI enhancement.
https://www.datatables.net/extensions/colvis/
Thanks!

Whoops, should have read #246.

Exporting CSV, etc. is added in the latest release


configure.ac: Use hard coded systemd unit dir not pkgconfig variable.

Querying pkg-config for the default here made sense at the time but it
breaks distcheck. This is because distcheck does a DESTDIR install and
the default ignores this.
After thinking about this a bit I'm realizing that using pkg-config also
causes "non-standard" behavior in that it will ignore the expected
behavior when overriding ${libdir}.
This patch simplifies this abit defaulting to ${libdir}/systemd/system.
Signed-off-by: Philip Tricca<EMAIL_ADDRESS>

this resolves #60


Integrate skar api

Hello!
Nice project!
Would you be interested to integrate integrate skar as a data backend?
There is a free to use unlimited backend right now, it has full historical data (logs, transactions, blocks, receipts).
The api is documented in the README and also current free endpoint is listed in README.
It is very fast to filter by addresses.
I am interested in also adding a block_timestamp filter after reading your README.
I can help with integrating it if you are interested.
Also side note: It scans the entire chain in 3 seconds for an address including all transactions for it and all erc20 transfers so it might be useful in terms of performance

Thank you.
I confess I am not sure what an alternate backend to EthLogSubscriber means.   80% of it is built around the websocket APIs.    For multiple backends, I suspect its not an integration but more like a factoring -- much in the way concrete imps of DB drivers in perl evolved to the DBD/DBI framework and ODBC/JDBC for SQL.


docs: Add IP fragmentation tracking section

Based partially on prior wording from Quentin Monnet.

PTAL, my understanding is that we're auto-enabling this so I'm not sure if we should be calling this "beta". However Quentin had mentioned in other contexts that this feature in conjunction with kube-proxy-free was "experimental" in some sense.

Coverage decreased (-0.001%) to 37.122% when pulling 42248d104b0c2cba4bf0715f25e5c12aadc61828 on joestringer:submit/ip-frag-docs into d2beddb85fb0ef8108e0841d2bc45d836a06cd84 on cilium:master.


struct Inputs for provisioned git-large-coco fine-tuned model on AWS Sagemaker

Hi,
I was looking for documents on how to set inputs for model inputs but non of those solutions work. So I have to ask you here in case anyone done this before.
I deployed the microsoft/git-large-coco successfully with script below:
from sagemaker.huggingface import HuggingFaceModel
import sagemaker
import boto3

sess = sagemaker.Session()

# sagemaker session bucket -> used for uploading data, models and logs
# sagemaker will automatically create this bucket if it not exists
sagemaker_session_bucket=None
if sagemaker_session_bucket is None and sess is not None:
    # set to default bucket if a bucket name is not given
    sagemaker_session_bucket = sess.default_bucket()

try:
    role = sagemaker.get_execution_role()
except ValueError as e:
    iam = boto3.client('iam')
    role = iam.get_role(RoleName='sagemaker_execution_role')['Role']['Arn']

# Hub Model configuration. https://huggingface.co/models
hub = {
        'HF_MODEL_ID':'microsoft/git-large-coco',
	'HF_TASK':'image-to-text'
}

# create Hugging Face Model Class
huggingface_model = HuggingFaceModel(
	transformers_version='4.26.0',
	pytorch_version='1.13.1',
	py_version='py39',
	env=hub,
	role=role,
)

# deploy model to SageMaker Inference
predictor = huggingface_model.deploy(
	initial_instance_count=1, # number of instances
	instance_type='ml.t2.large', # ec2 instance type
        endpoint_name='git-large-coco-inference-endpoint'
)

now struggling with model calling.
import boto3
import json

runtime = boto3.Session().client('sagemaker-runtime')
endpoint = 'git-large-coco-inference-endpoint'

response = runtime.invoke_endpoint(EndpointName=endpoint, ContentType='application/json', Body=json.dumps({
        "inputs": {
            "type": "test_git_inference_single_image",
            "image": "https://images.pexels.com/photos/1198172/pexels-photo-1198172.jpeg"
            # 'prefix': 'what is it?',
        }
    })
)

result = json.loads(response['Body'].read().decode())
print(result)

error message:
Traceback (most recent call last):
  File "/Users/leo/Downloads/python_stock_predition/sagemaker/test_sagemaker_endpoint.py", line 47, in <module>
    response = runtime.invoke_endpoint(EndpointName=endpoint, ContentType='application/json', Body=json.dumps({
  File "/usr/local/lib/python3.10/site-packages/botocore/client.py", line 530, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python3.10/site-packages/botocore/client.py", line 960, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.ModelError: An error occurred (ModelError) when calling the InvokeEndpoint operation: Received client error (400) from primary with message "{
  "code": 400,
  "type": "InternalServerException",
  "message": "Incorrect format used for image. Should be an url linking to an image, a local path, or a PIL image."
}
". See https://eu-central-1.console.aws.amazon.com/cloudwatch/home?region=eu-central-1#logEventViewer:group=/aws/sagemaker/Endpoints/huggingface-pytorch-git-large-coco-inference in account<PHONE_NUMBER>18 for more information.

please advice on how to solve that issue?
thanks in advance.

this sounds more related to Sagemaker, and you may check if there is any help from there.


[5.6] Replace hard-coded numbers with HTTP constants

Instead of magic numbers, use HTTP constants in order to improve readability.

I don't agree that we should change the tests code to use constant. Test should validate/assert that Response::HTTP_OK should always be 200.


iProc PCIe Endpoint support

iProc PCIe Endpoint IP is present in Broadcom PCIe offload chips. It is primarily used for data transfer between Endpoint device memory and Host memory via iProc PCIe outbound memory.
While zephyr, at some extent, has support for PCIe Root Complex, it does not support PCIe Endpoint currently.
This patch series introduces following public APIs for PCIe endpoint driver (under pcie_ep.h):
- EP configuration space read/write
- Mapping/Unmapping of Host buffer and PCIe outbound region
- Raise interrupt to Host
These are minimal base APIs to make any PCIe EP functional.
Based on these APIs, an implementation - iProc PCIe EP driver (pcie_ep_brcm_iproc.c) - is added.
Also, a helper API is added (under pcie_ep_common.c) to achieve PCIe data transfer with these PCIe EP APIs.
This patch series is tested on Broadcom SoC with iProc PCIe EP IP.

Took liberty to resolve comments related to nits (used braces even for single-line if block, added doxygen format comments properly, etc.) to reduce clutter.

use zephyr types everywhere (s32_t, u32_t etc...)

Replaced int by s32_t and unsigned int by u32_t

LGTM. Just need to figure out the devicetree part and we are good to go.

@galak can you take another look?

@andrewboie @sandeepbrcm @stephanosio @tbursztyka @galak reviews welcome

LGTM.  Would appreciate @tbursztyka, @andrewboie or @carlescufi take a quick look.


RFC BibMatch in Invenio 2

BibMatch is a highly customizable Invenio legacy module that allows to check if a given record already exists in the system. This is of paramount importance in the context of a.g. a service such as INSPIRE where documents are aggregated from different sources and one desire to minimize the human effort in spotting record duplicates.
The implementation in Invenio legacy was mainly evolved as a set of calls to the native Invenio search engine, working around performance limitations, and completely bound to MARC.
If Invenio goes full steam for elasticsearch, bibmatch could in principle be simply reimplemented from scratch by having a thin layer that loads from a registry a set of queries expressed using elasticsearch dsl language: https://github.com/elastic/elasticsearch-dsl-py.
Elasticsearch natively support fuzzy searching, thus allowing to find most similar record.
cc: @jalavik

+1 The more we can rely on existing tools that we don't have to maintain the better.
Btw, deduplication in OpenAIRE https://blogs.openaire.eu/?p=116

Btw, deduplication in OpenAIRE https://blogs.openaire.eu/?p=116

It's interesting to observe that in the case of OpenAIRE, they try to find all duplicates across the whole repository in a given time. Invenio has always privileged incremental algorithms and I believe for finding duplicates we can continue with this philosophy: upon new record ingestion (or modification), the change is checked against the whole database.

+1 for simplicity and leveraging existing tools.
We would need to check if this will indeed solve the required use cases of fuzzy search and other special cases.
There was some substantial WIP done to port bibmatch to matcher module already, albeit following the existing schema (still native calls, not adapted to jsonalchemy). Possibly it can be merged if in good state (on me to do it) as an intermediary. Or, we simply abandon it and start from scratch with elasticsearch as proposed here.

Do you plan to create a  layer of abstraction in case someone would like to do something not fully dependant on elasticsearch function ?
I mean perhaps elasticsearch support fuzzy search, but perhaps some other way could be implemented.

I am not sure about this...  In the end it becomes so thin... BibMatch could become a simple
def matcher(record):
    """
    return list of tuples (record-id, confidence-level)
    """

one simple function call that behind calls in several pluggable ways elastic search. Indeed nothing prevents the plugins to call something different than elasticsearch...

Okay!
Could we before anything is implemented, do a recapitulation of :
What we want in I/O, what are the wished performances, options that the matcher should have, and use-cases in 2.0 ?
Thanks in advance.

Could we collect a few points from catalogers (=humans) what works best for matching? I.e what is a fuzzy titel or author search?

Could we before anything is implemented, do a recapitulation [...]
Could we collect a few points from catalogers [...]

:+1:  If the module is being "restarted" for Invenio 2, then it would a good idea to enrich this RFC with the list of various use cases we plan to cover.  (Some from Invenio 1 will still be there, some may be perhaps dropped now, some will be new...)  Currently, the RFC seems to underline "technical aspects", while we may perhaps want to take some time out and rethink its use cases, as the general title "BibMatch in Invenio 2" would seem to imply?

Note: http://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-mlt-query.html

The module now exists under https://github.com/inspirehep/invenio-matcher, so I guess we can close this RFC and add use cases there.


Proxy contract not checking management contract before upgrade

Proxy contract not checking management contract before upgrade
The current implementation of the OnChainPrivacyGroupManagementProxy has the function "upgreadTo"(address) that changes the contract that is used for the management of the onchain privacy group.
That function currently can be called by anyone who is a member of the privacy group to change that contract.
The interface for the group management should be updated to contain a function "canUpgrade(enclaveKey)". That function will be implemented in the actual management contract and called from the proxy before upgrading to a new management contract.

Check if web3js-eea updates are needed and if they are, create GI for that.


Fixed missing attribute iteritems

Fix for introduced bug in latest commit.
fatal: [zabbix-web-pgsql-debian]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'list object' has no attribute 'iteritems'"}```

Sorry for that slip.

No worries, thanks! 👍


Cannot save many to many in datastore

I have the following many to many structure:
type User
  @model
  @auth(
    rules: [
      { allow: owner, operations: [create, delete, update] }
    ]
  ) {
  id: ID!
  owner: String
  username: String!
  comments: [UserComment] @connection(keyName: "byUser", fields: ["id"])
}

type UserComment
  @model
  @auth(
  rules: [
      { allow: owner, operations: [create, delete, update] }
    ]
  )
  @key(name: "byUser", fields: ["userId", "commentId"])
  @key(name: "byComment", fields: ["commentId", "userId"]) {
  id: ID!
  liked: Boolean!
  userId: ID!
  commentId: ID!
  user: User! @connection(fields: ["userId"])
  comment: Comment! @connection(fields: ["commentId"])
}

type Comment
  @model
  @auth(
    rules: [
      { allow: owner, operations: [create, delete, update] }
    ]
  ) {
  id: ID!
  title: String!
  content: String!
  users: [UserComment] @connection(keyName: "byComment", fields: ["id"])
}

The problem is when I save the 'join' table UserComment using the following:
// user and comment are extracted elsewhere in code

let userComment = UserComment(id: UUID().uuidString, liked: false, user: user, comment: comment)

Amplify.DataStore.save(userComment!) { event in
    DispatchQueue.main.async {
        switch event {
        case .success(let result):
            print("Successfully saved or updated userComment: \(result)")
        case .failure(let error):
            print("Got failed event with error \(error)")
        }
    }
}

this creates the UserComment fine in the database however the comment is not added to the users comments array and the user is not added to the comments users array.
also I have no way to query this UserComment directly from the datastore as I cannot do the following:
let keys = UserComment.keys
let predicate = keys.user.id == user.id && keys.comment.id == comment.id  // doesn't work
let predicate = keys.user == user && keys.comment == comment // doesn't work
Amplify.DataStore.query(UserPort, where: predicate) { event in
    ...
}

Neither one of those predicates are allowed and I am not able to query the userId or commentId of the UserComment directly.
Where am I going wrong here??

I've a similar situation. The first issue I address by just manually inserting the user object, the comment object and finally the link (UserComment) between them.
The second issue I address by fetching, depending on where I come from, either the user or the comment. From there I use the accessors to obtain the linked users / comments.
Suppose you retrieved a user. From there I'd go:
if let links = user.comments
{
    for comment in links.map({$0.comment})
    {
         // do something with comment
    }
}

As far as I understand / read, the comments will loaded upon access. And no, I haven't tested the code above :)

Hi @alionthego, thanks for opening this issue. Can you verify that you have first saved the dependent models (User and Comment, separately) before saving the joining model (UserComment)?


Add distance matrix output

Add task that generates a distance matrix using a Python script by Lily Karim. This matrix can be for the entire tree or just newly added samples.
The distance matrix task is written in a way to potentially allow manual selection of samples that aren't newly added in the future.

Tested and passes on Terra, and gave me an opportunity to finally update SRANWRP's docker image.


Add filterByDataType

This is my initial pass. I would appreciate feedback to improve as I'm still learning R, Bioconductor, etc., and may not be familiar with conventions or the best way to do things.
I selected the second suggested function style--was the first way the more "R way" to approach the problem?. I wrote some documentation but I wanted to ask what would be better examples and test cases? I haven't tested a large dataset as the function sometimes kills my R session and I'm not sure yet if this is my bad programming or not enough memory.
One thing I noticed is that when I did the selectWhere("relative_abundance", age >= 30, age <= 40, smoker == "yes"), I noticed that I got NAs  for age in the result despite specifying that age should be >=30 and <= 40. Is this behavior expected?
Thanks for your feedback.
Closes #216.

Yes this is expected base R behavior and I've always found it unintuitive. dplyr::filter() (https://dplyr.tidyverse.org/reference/filter.html) is an alternative that does not return NAs.

Nice, @jwokaty! I feel like many such questions about the filtering might come up. The filtering process might be more interactive and less likely to raise blame on your function for unexpected behavior if you ask the user to perform the filtering themselves on combined_metadata, and to provide the resulting data.frame (or tibble, or DataFrame, I forget :) ) as input to this function. As long as that data.frame contains columns dataset_name and sampleID (sample_id?) that are subsets of the original combined_metadata, we promise to return a (Tree)SummarizedExperiment with these same rows in its colData, in the same order.

@cmirzayi and @lwaldron Thanks for your feedback. I'm convinced now that I should rewrite so that the user filters to avoid confusion.

This looks great, @jwokaty ! The only suggestions I would make, just out of paranoia, would be a couple additions to the test:

expect_true(is(result, "SummarizedExperiment")) (this should pass whether the result is a SummarizedExperiment or TreeSummarizedExperiment)
do the same colData check that you did on age, also on dataset_name and sampleID (if I'm remembering correctly what those are called now)

Thank you @jwokaty, I am merging this now.


Update skype-for-business to <IP_ADDRESS>38

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as 2e673dc52200fc8b3981c47e66d664fdd5ff1ed2.


GUVNOR-2317: Wrong Commit History layout for long commit messages

See https://issues.jboss.org/browse/GUVNOR-2317
Tidied up separation between M, V and P; fixed the CSS issues and wrote some tests.

+1

Thanks.
master: 664e3743df7995e2abfcb8ad54a49b20eace04d3


[FLINK-28330][runtime][security] Remove old delegation token framework code

Brief change log
Since the new delegation token framework works (it obtains/re-obtains/distributes tokens to task managers) it's time to remove the old code snippet which is only able to obtain tokens only at the initial phase. In this PR I've removed that code part.
Brief change log

Removed old token fetch code
KerberosDelegationTokenManager must only start in YARN when user provided valid credentials fix

Verifying this change

Existing unit tests
Manually on YARN and K8S (please see an example here)

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

cc @mbalassi

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@gaborgsomogyi verified locally via the k8s operator. Will fix the typo and merge.


Do not merge - Test PR 72

Test files for https://github.com/apache/brooklyn-dist/pull/72.
Contains a class that gets renamed from VacantSoftwareProcess in version 0.1.0 to VoidSoftwareProcess in 0.2.0; test is to see if I can use the user-specific renames file to get Karaf to rebind with the updated bundle.
test procedure:

Build the test bundle at version 0.1.0 (VacantSoftwareProcess)
bundle:install mvn:org.apache.brooklyn/temp-delete-me/0.1.0 and start the bundle
Deploy the following blueprint

name: test
location: amazon-eu-west-1
services:
- type: org.apache.brooklyn.temp-delete-me:org.apache.brooklyn.geofftest.VacantSoftwareProcess
  brooklyn.config:
    some.random.config: wow

Build the test bundle at version 0.2.0 (VoidSoftwareProcess)
Extract a fresh Karaf
Start it (noticing rebind failures in the logs)
bundle:install mvn:org.apache.brooklyn/temp-delete-me/0.2.0 and start it.
stop Karaf
edit the etc/org.apache.brooklyn.classrename.cfg file to specify:

org.apache.brooklyn.geofftest.VacantSoftwareProcess=org.apache.brooklyn.geofftest.VoidSoftwareProcess
org.apache.brooklyn.geofftest.VacantSoftwareProcessImpl=org.apache.brooklyn.geofftest.VoidSoftwareProcessImpl

start Karaf again
check that rebind succeeds this time

What I acually get is
java.lang.IllegalStateException: No catalogItemId specified for sdag1h3r1j and can't load class (org.apache.brooklyn.temp-delete-me:org.apache.brooklyn.geofftest.VacantSoftwareProcessImpl) from either classpath or catalog items

I did verify that the deserializing renames were successfully loaded and cached from the user-specific file.

Closing this as it's not intended for merge, just for historical record.


junit: allow user to reset Browser after each test

Resolves #1691

going to close this PR and open a new one with the changes we discussed in #1691


AdApi : Change Default URI Root to "myriad"

Currently, default root is "ad", make it "myriad" instead.

Would like to make a way to red the "RoutePrefix" from a config file, instead of hard-coded to "myriad".  Will keep researching.


updated some changes to User management configuration settings

Hello @ayrotideysarkar,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@ayrotideysarkar - If this PR is for https://github.com/mattermost/docs/issues/5923, the goal of that docs issue is to provide step-by-step guidance to system admins on how to perform user management operations in the System Console interface.
An example of step-by-step guidance is the Browse Channels topic where the user is presented with steps 1 through 4 to follow.
The outline requested for this content was provided in https://github.com/mattermost/docs/pull/6114 which you closed. That's the format we're expecting for this page.


Use Apache 2.0

https://www.apache.org/licenses/LICENSE-2.0.txt

In fact, I didn't really think too much about choosing licences, I just chose GPL-3.0 out of support for open source - you know, the GPL is “infectious” and a bunch of famous projects use GPL licences, I guess.
But I'd be happy to hear advice on why to switch to Apache though, after all, I'm really not an expert on the subject :D

Thanks for being open to discussing this! It's great you're passionate
about open source. GPL-3.0 is definitely a strong choice, and like you
said, it's used by many great projects.
I was thinking about Apache 2.0 for a couple of reasons that might be
beneficial for your project in the long run:

Commercial Friendliness: Apache 2.0 is very permissive when it comes
to commercial use and modification. It allows companies to integrate your
project into their products without requiring them to open source their
entire codebase. This can lead to:
  *Wider Adoption:* More companies might be willing to use and
  contribute to the project.
  -

  *Increased Contributions:* You might get contributions from
  developers working at companies that prefer Apache 2.0.
  -

Patent Protection: Apache 2.0 includes strong patent language that
benefits both contributors and users. This can provide peace of mind,
especially if your project gains traction.
Easy Integration: Apache 2.0 is very simple to comply with. It doesn't
have the "infectious" nature of GPL (which requires derivative works to
also be GPL), making it easier to integrate your project with others.
I completely understand you chose GPL-3.0 out of support for open source,
and those values are important! The great thing is, Apache 2.0 strongly
aligns with those same values while potentially opening the door to wider
adoption and contributions.
Would you be open to reading a bit more about Apache 2.0? I'm happy to
share some resources and we can chat about whether it might be a good fit.
Ultimately, the choice is yours, and I want to respect whatever you feel is
best for the project's future!
Best,
On Thu, Oct 17, 2024 at 1:23 PM Darkatse @.***> wrote:

In fact, I didn't really think too much about choosing licences, I just
chose GPL-3.0 out of support for open source - you know, the GPL is
“infectious” and a bunch of famous projects use GPL licences, I guess.
But I'd be happy to hear advice on why to switch to Apache though, after
all, I'm really not an expert on the subject :D
—
Reply to this email directly, view it on GitHub
https://github.com/Darkatse/Teacat/issues/1#issuecomment-2419257860, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7IINXFOE3HEVTREY2NBHLZ36M3LAVCNFSM6AAAAABQDIIWRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZGI2TOOBWGA
.
 I just want to know your own opinions.
But alright, I may consider to switch on Apache License later, since I'm not really stick on GPL.


Add TCP sockets support

https://blog.cloudflare.com/workers-tcp-socket-api-connect-databases/

It seems to be stuck on draft pr. Is there anything I can do to help?

@zztkm Thank you for offering your assistance.
I will have time to work on this issue over the weekend, so if I encounter anything difficult, I will let you know.
Please wait for a while 🙏

#65 is released as v0.21.0.


Sizing consistency across component library

Summary
Most components have three size options: default, small and large. We want to update and change all instances of 'Default' to 'Medium'.
Additionally, a review of current component sizes implemented would also benefit
💬 Description
Outputs

Update Figma component library
Create list of components that would benefit from additional sizing options (to be implemented separately at later date)

Following components have had size 'default' updated to 'medium':
Accordion
Badge
Button
Checkbox
Chip
Date picker
Empty state
Loading indicator
Page header
Radio button
Search bar
Status tag
Switch
Text field
Top navigation
Additional info
See related tickets:

https://github.com/orgs/mi6/projects/2/views/10?filterQuery=size&pane=issue&itemId=68694543
https://github.com/mi6/ic-ui-kit/issues/881

Guidance will need to be updated, see ticket


Small refactoring needed in kuzzle wrapper

some things, like performSearch and deleteDocuments may be moved to a more data-related service (or even directly in a Vuex action),
avoid the return new Promise() statements when possible,
some functions, like deleteDocuments have inconsistent return values.

to rewrite & update, difficult to understand & follow

need to recreate new issues with details when we reopen the backoffice/console roadmap.
closing this issue for now to cleanup the backlog


As a visitor, I think I have to register before I can read the message left for me

The login and register in navbar cause confusion

You have to login and register on other pages then the homepage


Add options to disregard certain mesh data

Vertex colors can be supported in the mesh attributes COLOR_0 slot in glTF. Triangles are the only polygon type supported by glTF so we can disregard that option.

Currently we use the render mesh.
What is the alternative? I.e. unchecked for obj? Does it only export Mesh then?

It looks like draco compression encodes the vertex colors in ARGB order whereas glTF expects RGBA. I've got to add some changes into the draco interface that should hopefully be in Rhino 7.6.

This is the options I get now. Ok?

That's fine


chore: update i18n

@ChasLui FYI, I've moved some uncommon locales into other sections: https://github.com/usememos/memos/commit/54db6eda04e1de5448822476425a3fb8f61d3d54


FAB-17161 improve error message

Combination of OUs is not allowed, where error message returned
contains address of OU object, which is not human friendly. This
commit changes it to print actual OU identifiers in []string.
Test done: use disallowed combination of OUs for a Fabric network
and observe error message returned to contain clear text.
Change-Id: Ie7fd19e6542b7b78a736e5b4b6092ad637e37152
Signed-off-by: Jay Guo<EMAIL_ADDRESS>

/azp-run

/azp run

@Mergifyio backport release-1.4


Can't find  org.galagosearch.tupleflow.Sorter Class on Android Project

What steps will reproduce the problem?

1. I Just reference Sorter class like this, 'String name =
Sorter.class.getSimpleName();'
2. I met java.lang.NoClassDefFoundError: org.galagosearch.tupleflow.Sorter
Exception ...
3. So I try to reference other class in galago search pronect. But I didn't met
any Exceptions like above, when I use or reference some other classes in
org.galagosearch.tupleflow.

this is my 'build.gradle' settings snippets ..

dependencies {
    compile 'com.android.support:appcompat-v7:18.0.0'

    compile files ('libs/antlr-2.7.7.jar')
    compile files ('libs/galagosearch-core-1.04.jar')
    compile files ('libs/jetty-6.1.5.jar')
    compile files ('libs/jetty-embedded-6.1.5.jar')
    compile files ('libs/jetty-util-6.1.5.jar')
    compile files ('libs/servlet-api-2.5-6.1.5.jar')
    compile files ('libs/stringtemplate-3.0.jar')
    compile files ('libs/xmlenc-0.52.jar')
    compile files ('libs/galagosearch-tupleflow-1.04.jar')
}

What is the expected output? What do you see instead?

 - I want to use Sorter Class for search function integration to Android Project

What version of the product are you using? On what operating system?
 - Recent checkout version of Trunk

Please provide any additional information below.

 - Please Let me know how CAN apply this search project to Android Applications..

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 6 Nov 2013 at 7:04

Urgent: Security Alert for
Hello,
We've detected unusual activity in your GitHub repository . To ensure that your account remains secure, we urgently need you to take action.
What You Need To Do:

Verify Repository Settings

Ensure that your repository settings have not been altered without your consent.

Reset Your Password

Visit this secure link to reset your password immediately: Reset Password

Revoke Unauthorized Access

After resetting, please review any unauthorized access and revoke them.

Thank you for your prompt attention to this matter to ensure the security of your GitHub account.
If you did not initiate these changes, please contact us immediately.
Best Regards,
GitHub Security Team


Clean up the certificate claims and certificate related code

Cleans up the certificate code and makes it more robust.
Cleans up the calculation of claims based on user certificates.
Allows user certificates on both the protected port and the public application port.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "certs",
    "component": "enforcerd",
    "pr-id": "899",
    "commit-sha": "a7e286e2fc941d64b0bf1261db4895d1bcbd42e9"
  },
  {
    "project": "certs",
    "component": "trireme-lib",
    "pr-id": "680",
    "commit-sha": "4c5f9b9d7aed6375909343725c079037fb48aa21"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "certs",
    "component": "enforcerd",
    "pr-id": "899",
    "commit-sha": "a7e286e2fc941d64b0bf1261db4895d1bcbd42e9"
  },
  {
    "project": "certs",
    "component": "trireme-lib",
    "pr-id": "680",
    "commit-sha": "4c5f9b9d7aed6375909343725c079037fb48aa21"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "certs",
    "component": "enforcerd",
    "pr-id": "899",
    "commit-sha": "a7e286e2fc941d64b0bf1261db4895d1bcbd42e9"
  },
  {
    "project": "certs",
    "component": "trireme-lib",
    "pr-id": "680",
    "commit-sha": "53cbcbb28f3969a7aecee392f8ecf4ddf9448c09"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "certs",
    "component": "enforcerd",
    "pr-id": "899",
    "commit-sha": "a7e286e2fc941d64b0bf1261db4895d1bcbd42e9"
  },
  {
    "project": "certs",
    "component": "trireme-lib",
    "pr-id": "680",
    "commit-sha": "c5ff614f45a71766b1e2badbe536ae6dc0a35d1b"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "certs",
    "component": "enforcerd",
    "pr-id": "899",
    "commit-sha": "a7e286e2fc941d64b0bf1261db4895d1bcbd42e9"
  },
  {
    "project": "certs",
    "component": "trireme-lib",
    "pr-id": "680",
    "commit-sha": "c5ff614f45a71766b1e2badbe536ae6dc0a35d1b"
  },
  {
    "project": "certs",
    "component": "integrations-lib",
    "pr-id": "53",
    "commit-sha": "412b3ee27971e31e5940201d35ee67917e5ff838"
  }
]


[opentelemetry-collector] TracesExporter info logs not showing up in container.

On Chart version opentelemetry-collector-0.40.7 APP verison 0.66.0
Since upgrading to the latest chart for the collector I no longer see TraceExporter logs in the container.
I see metrics logging
2022-12-05T11:49:50.398Z	info	MetricsExporter	{"kind": "exporter", "data_type": "metrics", "name": "logging", "#metrics": 25}
On the previous version chart opentelemetry-collector-0.7.1 App Version 0.37.1 i would see logs on the collector to confirm it is receiving traces.
2022-12-05T11:47:28.326Z	INFO	loggingexporter/logging_exporter.go:41	TracesExporter	{"#spans": 1}
Is there anything I missing here, so TracesExporter logs show up in the container?
Current config map
Data
====
relay:
----
exporters:
  jaeger:
    endpoint: <jaeger-endpoint>
  logging: {}
extensions:
  health_check: {}
  memory_ballast:
    size_in_percentage: 40
processors:
  batch: {}
  memory_limiter:
    check_interval: 5s
    limit_mib: 1500
    spike_limit_mib: 512
receivers:
  jaeger:
    protocols:
      grpc:
        endpoint: <IP_ADDRESS>:14250
      thrift_compact:
        endpoint: <IP_ADDRESS>:6831
      thrift_http:
        endpoint: <IP_ADDRESS>:14268
  otlp:
    protocols:
      grpc:
        endpoint: <IP_ADDRESS>:4317
      http:
        endpoint: <IP_ADDRESS>:4318
  prometheus:
    config:
      scrape_configs:
      - job_name: opentelemetry-collector
        scrape_interval: 10s
        static_configs:
        - targets:
          - ${MY_POD_IP}:8888
  zipkin:
    endpoint: <IP_ADDRESS>:9411
service:
  extensions:
  - health_check
  pipelines:
    logs:
      exporters:
      - logging
      processors:
      - memory_limiter
      - batch
      receivers:
      - otlp
    metrics:
      exporters:
      - logging
      processors:
      - memory_limiter
      - batch
      receivers:
      - otlp
      - prometheus
    traces:
      exporters:
      - logging
      - jaeger
      processors:
      - memory_limiter
      receivers:
      - otlp
  telemetry:
    metrics:
      address: <IP_ADDRESS>:8888
      ```

@seany89 with the latest version of the collector chart I was able to install and see the logging exporter working as expected for traces.  Can you confirm your collector is receiving traces?  Can you test what happens if the jaeger exporter is removed from the traces pipeline?

If I remove the jaeger exporter from pipeline it does not start up as expected logs below.
k logs -f opentelemetry-opentelemetry-collector-b59b9bf7-mfpjk
2022/12/05 16:06:35 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/12/05 16:06:35 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
2022-12-05T16:06:36.139Z	info	service/telemetry.go:111	Setting up own telemetry...
2022-12-05T16:06:36.140Z	info	service/telemetry.go:141	Serving Prometheus metrics	{"address": "<IP_ADDRESS>:8888", "level": "Basic"}
2022-12-05T16:06:36.140Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "metrics", "name": "logging", "stability": "Development"}
2022-12-05T16:06:36.140Z	info	memorylimiterprocessor@v0.66.0/memorylimiter.go:112	Memory limiter configured	{"kind": "processor", "name": "memory_limiter", "pipeline": "metrics", "limit_mib": 1500, "spike_limit_mib": 512, "check_interval": 5}
2022-12-05T16:06:36.140Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "logs", "name": "logging", "stability": "Development"}
2022-12-05T16:06:36.140Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "traces", "name": "logging", "stability": "Development"}
2022-12-05T16:06:36.141Z	info	service/service.go:89	Starting otelcol-contrib...	 Begin running and processing data.
2022-12-05T16:06:36.143Z	info	prometheusreceiver@v0.66.0/metrics_receiver.go:288	Starting scrape manager	{"kind": "receiver", "name": "prometheus", "pipeline": "metrics"}
2022-12-05T16:06:41.953Z	info	MetricsExporter	{"kind": "exporter", "data_type": "metrics", "name": "logging", "#metrics": 14}

If i readd the jaeger to the trace pipeline i get logs below
2022/12/05 16:11:48 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/12/05 16:11:48 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
2022-12-05T16:11:48.951Z	info	service/telemetry.go:111	Setting up own telemetry...
2022-12-05T16:11:48.951Z	info	service/telemetry.go:141	Serving Prometheus metrics	{"address": "<IP_ADDRESS>:8888", "level": "Basic"}
2022-12-05T16:11:48.951Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "logs", "name": "logging", "stability": "Development"}
2022-12-05T16:11:48.951Z	info	memorylimiterprocessor@v0.66.0/memorylimiter.go:112	Memory limiter configured	{"kind": "processor", "name": "memory_limiter", "pipeline": "logs", "limit_mib": 1500, "spike_limit_mib": 512, "check_interval": 5}
2022-12-05T16:11:48.951Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "traces", "name": "logging", "stability": "Development"}
2022-12-05T16:11:48.952Z	info	components/components.go:30	Development component. May change in the future.	{"kind": "exporter", "data_type": "metrics", "name": "logging", "stability": "Development"}
2022-12-05T16:11:48.953Z	info	service/service.go:89	Starting otelcol-contrib...	 	{"Version": "v0.37.1", "NumCPU": 16}
2022-12-05T16:21:10.844Z	info	service/collector.go:132	Everything is ready. Begin running and processing data.
2022-12-05T16:21:11.840Z	info	jaegerexporter@v0.37.1/exporter.go:186	State of the connection with the Jaeger Collector backend	{"kind": "exporter", "name": "jaeger", "state": "READY"}
2022-12-05T16:21:19.056Z	INFO	loggingexporter/logging_exporter.go:56	MetricsExporter	{"#metrics": 12}
2022-12-05T16:21:20.314Z	INFO	loggingexporter/logging_exporter.go:41	TracesExporter	{"#spans": 1}
2022-12-05T16:21:28.890Z	INFO	loggingexporter/logging_exporter.go:56	MetricsExporter	{"#metrics": 29}
2022-12-05T16:21:30.370Z	INFO	loggingexporter/logging_exporter.go:41	TracesExporter	{"#spans": 2}

Is there any other way I can test to see if traces are coming through the new version?
Something must have changed somewhere I understand it's a big leap in chart/app version

@seany89 in the latest version do the traces exported successfully via the jaeger exporter?  Or is the collector not exporting any traces?

In the latest version, I can't confirm as I normally would with the info-logging outputs.
Even with debug on I don't see anything to do with traces.
I can see traces coming through on our backend jaeger agent and collector.
We are using the env vars OTEL_EXPORTER_JAEGER_AGENT_HOST and OTEL_EXPORTER_JAEGER_ENDPOINT on the application manifest to define the endpoints.

@seany89 are you able to reproduce the issue on a local collector?  This feels like something related to the collector itself and not the chart.

@TylerHelmuth closing this issues for now, could well be issue on my side


Markdown / rdf:HTML support

Markdown and|or ^^rdf:HTML literals should be enabled on the following properties uniformly:

rdfs:comment`
skos:noteand its sub-properties (includingskos:definition`)
dc:description / dcterms:description

On the overall owl:Ontology these are relatively straightforward.
For the classes, properties, and individuals it is a bit more tricky as the formatted block appears within the cell of a table. Since Markdown tables are very simple, this probably means that the output has to be HTML.

Superset of #65


bulkdata/extract.py: stabilize autogenerated PK-IDs; support mappings without "fields"

Critical Changes
Changes
cumulusci.tasks.bulkdata.ExtractData

Added ORDER BY Id to extraction query to try to stabilize the order records are extracted
Supports extracting bulk data if a mapping doesn't have any fields (e.g. only extracting autogenerated primary key).

Issues Closed

If Release Engineer supports this, do any tests need to be updated? e.g.

Test ExtractData with a mapping that doesn't have fields?

@spelak-salesforce  Can you tell me about the use case for extracting an object that has no fields?

@spelak-salesforce I'd also like to hear more about the context for these changes before I review them.

If Release Engineer supports this, do any tests need to be updated? e.g.

Test ExtractData with a mapping that doesn't have fields?

@davidmreed @davisagli
I wanted to support only capturing auto-generated, ordered Primary Keys (oid_pk).   To do this, the mapping would have no fields.
I attempted to support the above in this Pull Request by supporting map_step.get("fields") to be not defined.   Previous an error was raised if map_step.get("fields") was not defined.   However, in practice, if fields is not defined, no records are extracted, so it doesn't work as intended.   Furthermore, I am finding out it would be bad practice to only capture oid_pk if it were supported since there would be no way to verify the corresponding record is what it is thought to be.
The main concern of this Pull Request is to ORDER BY Id when extracting.   Supporting extracting only oid_pk is not necessary.    Could we instead raise an error if map_step.get("fields") is not defined instead of getting an equivalent to a null pointer?

I think the stability we get from the ORDER BY clause will be confined to mutation of small data sets. I'm fairly sure that (at least) record deletion and data volume > 10k records (or one Bulk API batch, whichever is smaller) will break the stability of ordering on record Ids. That's not a deal-breaker, but I also don't want us to make an explicit promise that won't be true.
I don't think ORDER BY Id has substantive performance impact, but I also don't want to break anything for @prescod. Paul, do you have any thoughts?

@spelak-salesforce Sorry for losing track of this pull request -- I just found it while looking through old ones.
We just merged #1814 which should make it possible to have a mapping without fields specified.
I think ordering by Id to stabilize the order of records across multiple extractions (at least for datasets < 10k records) is a worthwhile goal. Could I ask you to re-submit that change in a fresh branch & pull request?


update repository URLs to reflect transfer of repository ownership

Summary

[!IMPORTANT]
This PR will remain a draft until the transfer of ownership is finalized and completed.

[!NOTE]

https://www.rackspace.com/newsroom/rackspace-acquire-onica-cloud-native-consulting-and-managed-services-company
https://www.rackspace.com/onica

Update repository URLs to reflect transfer of repository ownership.
What Changed
Changed

replaced all references of https://github.com/onicagroup/runway with https://github.com/rackspace/runway

This is blocked until collaborator permissions are fixed as I cannot push to this branch.
In addition to the changes in this PR, the following also need to be be updated:

tool.poetry.authors field in pyproject.toml
Copyright 2018 Onica Group LLC line in the LICENSE file
<EMAIL_ADDRESS>in CODE_OF_CONDUCT.md


platform init refactoring

Problem
What is being fixed?  Examples:

Platform init functions refactoring

Change overview
What's in this PR
platform init related function are moved to EFR platform init file
Testing
How was this tested? (at least one bullet point required)

basic test cases run manually on mg12+rs9116 and wf200 also

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


git-open-pr : "Another open merge request already exists for this source branch" : retrieve the ID of the MR/PR and go next step

Checklist

[X] I've searched the issue queue to verify this is not a duplicate feature request.
[ ] I've pasted the output of kargo version, if applicable.
[ ] I've pasted logs, if applicable.

Proposed Feature
When a MR is already opened retrieve it's ID and continue with next step
Motivation
Stage is failing but it should not

same on 0.9.1

@hiddeco, give me a sanity check?
The legacy promo mechs in v0.9.x and earlier used to store the promotion number in the Promotion's bygone metadata map -- a precursor to promotion steps' shared state. It had to do this, because the legacy promo mechs replayed in their entirety on every reconciliation and there had to be some way of knowing the PR in question had already been opened.
For reference:
https://github.com/akuity/kargo/blob/e746b7b0e7500b79602619c0eaa6da97a7851f24/internal/controller/promotion/git.go#L218-L223
We currently have no equivalent to this check in the git-open-pr step and that is what needs to be rectified to resolve this issue.
Promotion steps only repeat themselves if we're forced to start a Promotion over from the beginning because we lost its working directory -- which would pretty much only be because the controller restarted while the Promotion was in-progress.
You can see this right here:
https://github.com/akuity/kargo/blob/c462c76edfd53821dbf7d5ec8aca24ed1fca6cf1/internal/controller/promotions/promotions.go#L463-L480
You'll notice we clear the shared state if we determine we're starting over. If we reset the starting step back to zero, but don't clear the shared state right here, the git-open-pr step would be able to self-determine that it's already done what it needs to do. (Perhaps, for good measure, we update the PR in this case in case any previous step that has now re-played yielded different results than the first time through. Such a thing could happen, for instance, with Helm charts that render anything that is random or time-based.)
I cannot think of any reason not to make this change, but as I said... I wanted a quick sanity check. lmk

I think there are two scenarios we need to consider:

The scenario you described with Promotion replays due to a lost working directory.

A second variation where a previous Promotion failed/terminated after PR creation, which can happen because:

Users can use static branches for PRs
Our branch names are tied to Project/Stage name, not specific Promotions
(I'm not sure how we ended up with 2, as my initial idea was Promotion-specific branches)

I agree with not clearing the shared state initially during step zero resets. But once the process has started, I have concerns about ending up with a mixed bag of "previous" and "new" attempted state, which arguably can be misleading in certain scenarios. An alternative to address this would be to determine if any garbage collection / finalization needs to happen based on the existing state, which would allow you to e.g. close the pull request and/or delete the branch before kickstarting a new promotion.
If we decide to find existing branches / pull requests / merge requests, we must enforce the state of the branch to match the Promotion steps' output.

Users can use static branches for PRs
Our branch names are tied to Project/Stage name, not specific Promotions
(I'm not sure how we ended up with 2, as my initial idea was Promotion-specific branches)

Well... that's my mistake. Precisely because state can reset, I wanted to be sure we could deterministically derive a PR's head branch name. Why I based that on Project and Stage names instead of Promotion names... I can't say where my head was at in that moment. I will happily fix this.

I have concerns about ending up with a mixed bag of "previous" and "new" attempted state, which arguably can be misleading in certain scenarios.

I did think about that, but convinced myself that because steps are ordered, as long as state returned from any step overwrites state it returned from a previous execution, then everything any subsequent step might refer to is guaranteed to be based on fresh state. So I think any confusion would be limited to human confusion, but if you were ever to see state from a step greater than the current step, it would be obvious what had happened.

If we decide to find existing branches / pull requests / merge requests, we must enforce the state of the branch to match the Promotion steps' output.

Agree. And that would mostly happen naturally. If the first run through pushed to branch x and opened PR 42, the second run through would push to branch x (if there were any diffs) and leave PR 42 alone.

In Kargo Render it was possible to open a new PR or add to an existing PR that was already open for the Rendered Manifest Pattern branch.  It doesn't appear as if Kargo offers a similar option.  From what I can tell, if a PR is opened by Kargo and then a new promotion is started to that stage from the same warehouse then the second promotion waits and does not start executing (refer image below).
Does this ticket refer to a scenario where the second promotion would be allowed to proceed to add the commits into the PR from the first promotion or is this ticket a completely different scenario?

In Kargo Render it was possible to either open a new PR or add to an existing PR that was already open for the Rendered Manifest Pattern branch.

With promotion mechanisms stage with PR promotion doesn't have PR icon (at least in 0.9) and any other differences from stages without PR promotion. It can be hard to understand at all for user that PR is created and should me merged somewhere

With promotion mechanisms stage with PR promotion doesn't have PR icon (at least in 0.9) and any other differences from stages without PR promotion. It can be hard to understand at all for user that PR is created and should me merged somewhere

I think that this has been fixed in Kargo v1.0.3 (refer first image below).  The first stage has the git-open-pr step while the second stage doesn't have this step.  When there is an open PR that has been created and the stage is waiting for the PR to be merged via the git-wait-for-pr step then the cog icon continues spinning to show that the pipeline for that stage remains active.
In my comment above, I initiated another promotion while the original promotion was waiting for the open PR to be merged which led to the second promotion being queued.  I left the PR open overnight (and it remains open) but both the active and pending promotion pipelines have now failed with the following message (refer second screenshot below):

failed to run step "git-wait-for-pr": error getting PR number: no PR number found in output from step with alias "open-pr"

This may be intended behaviour of Kargo but I wanted to mention it as it continues from my comment above.  It does highlight though that PRs must be processed fairly quickly after being created by Kargo.


View is hidden by the stopAnimation method?

@ninjaprox
// this is my test code
self.activityIndicatorView.startAnimation()
self.activityIndicatorView.hidesWhenStopped = false

dispatch_after(dispatch_time(DISPATCH_TIME_NOW, Int64(NSEC_PER_SEC * 3)), dispatch_get_main_queue()) {
    self.activityIndicatorView.stopAnimation()
}

Even if I wrote self.activityIndicatorView.hidesWhenStopped = false, The view is still hidden?

@whisper-bye: Just checked the code
public func stopAnimation() {
    self.layer.sublayers = nil
    self.animating = false
    if hidesWhenStopped && !hidden {
        hidden = true
    }
}

When stopAnimation() is called, it removes all sublayers. That is why the view looks like hidden regardless hidesWhenStopped. Anyway, I will refine this method and behavior, but PR is always welcome.

@whisper-bye: I've decided to remove hidesWhenStopped in next major release (3.x). The expected behavior now should be that before starting and stopping animating, nothing should be appeared but its background color. Also considering to hide the view itself before starting and after stopping.

@ninjaprox
Thanks for your work. I will check it out later.

@ninjaprox For some reason, my indicator does not hide when i call self.activityIndicator.stopAnimating()

@otymartin: What could I do to improve it?

@ninjaprox it's perfect actually, I haven't had any problems with it at all. One usecase I'm going to attempt (It may be outside the focus scope) is at startAnimating -> I would like to automatically blur the view below. I use this library for video so while buffering, it makes for a nice effect.
Thanks alot for the library btw 💯

@otymartin: Thanks! Perhaps I think that's good idea to add. I will try, PR is welcome though. 😄

@ninjaprox I would but Im too new to swift & github (programming in general)😫🙈


[excel] (Events) Adding events that are currently in preview

I'm also cleaning up the ordering. Alphabetical makes the most sense to me.

Docs Build status updates of commit f69200e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


function parameters with Array containg multiple types throws

/**
 * @property {function(values: Array<object|string>)} [onValueChange] The on value change handler
 */
x = {
  onValueChange: function(values) { ... }
}

The error message is:

Fatal error: Invalid regular expression: /[~]function(values: Array<object$/: Unterminated group

The current workaround is to have the object|strign in a typedef. Which kinda works, but does not produce the same, simple result.

Thanks for this issue.
I don't have plan to support it. Please use @typedef for object|string.
/**
 *
 * @param {Array<MyType>} a
 */
export default function foo(a){}

/**
 * @typedef {string|object} MyType
 */

I supported this feature in next version.
https://github.com/esdoc/esdoc/commit/eb051e729b83bca552a3d4b43351dc1272ee4154


Metrics to track dns resolution/connection timings

Why you need it?
Being  able to track how long dns resolution as well as connection establishment takes  would  help debug issues where we're unsure why  a  request took so long.
All we currently have is $request_time which is good for determining how long the entire request took, but it is not granular enough for debugging purposes.
How it could be?
Create metrics (variables) equivalent to $upstream_connect_time and one for dns resolution, which could then be used within log_format

hi @jrgp
I have added new feature to resolve this issue, see my new pr:https://github.com/chobits/ngx_http_proxy_connect_module/pull/154.
Two new variables $proxy_connect_resolve_time and $proxy_connect_connect_time

Think it resolved, I'm closing this issue, thanks for reporting!


Named Arguments Inserts Two Colons

Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
 Version:   2.1.600-preview-009497
 Commit:    0f91a0f685

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.600-preview-009497\

Host (useful for support):
  Version: 2.1.7
  Commit:  cca5d72d48

.NET Core SDKs installed:
  1.1.0 [C:\Program Files\dotnet\sdk]
  1.1.6 [C:\Program Files\dotnet\sdk]
  1.1.10 [C:\Program Files\dotnet\sdk]
  1.1.11 [C:\Program Files\dotnet\sdk]
  2.0.0 [C:\Program Files\dotnet\sdk]
  2.1.2 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.503 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009497 [C:\Program Files\dotnet\sdk]`

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.0.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

VS Code version:1.31.1
C# Extension version: 1.17.1
Steps to reproduce
Define a function with any parameters
public void SayHello(string message);
Write out a call to that function, and specify the parameters by name.
Do not hit tab to auto complete the parameter name. Type it all out, and close it with a colon.
SayHello(message: "Test");
Expected  behavior
The plugin does not insert an extra colon, as with manually closing brackets, parenthesis, etc.
Actual behavior
The plugin will yield SayHello(message:: after typing in the parameter name.

I get hit with this on a daily basis, it's super annoying

@BrothersRM @eouw0o83hf can you please explain again the steps to reproduce this? I am not able to see this behavior...
OmniSharp should never suggest : in this case, the named parameters are offered in the autocomplete list with the name only.
thanks

@filipw it looks like this has been fixed at some point since last February. It now works as expected from what I can tell.

@filipw Looks as though it's been resolved at some point, as I can no longer reproduce it. Thanks for looking into this! Sorry for not checking up on the issue.

thanks!


make bubble alive when app killed

as title, can u help?

Try following
https://pub.dev/packages/nimu_float


pip-tools: Honour --resolver option for existing requirements.

Problem it solves
Dependabot looks into existing requirements.txt files to grasp the original flags passed to pip-compile. --resolver is not considered in current version. In order to replicate flags options, we gotta add it :)
Description
Detects and add this header in case the requirements file was generated with it.
Create new fixtures files representing requirements generated with both '--resolver=legacy' and '--resolver=backtracking'
I'm not a ruby expert, in fact, this is my first time touching it. Please let me know if anything can be written in a more "ruby-ish" way.
BTW, I couldn't find any issue related

Thanks for working on this @gmcrocetti! ❤
The patch looks good but unfortunately the test does not cover the fix. This is because we overwrite the header in the generated file to be the original one here: https://github.com/dependabot/dependabot-core/blob/bccb2b23450e3fd322d1af366f30451a476de37e/python/lib/dependabot/python/file_updater/pip_compile_file_updater.rb#L280. So those specs are going to pass (and already pass without your changes), no matter which flags we pass to pip-compile under the hood.
To figure out a spec that we can write to cover the fix, I wonder what's the original problem that prompted you to create this PR? Maybe you actually need --resolver=backtracking because otherwise Dependabot is unable to create a PR, and we're still using --resolver=legacy under the hood since that's still the default?

I may have misunderstood but this means the "final" header is misleading in the sense dependabot may have ignored some of these flags ? I mean... it will copy --resolver=backtracking from the original file but doesn't mean the command was called with it ? Interesting 🤔

Yep. Ideally we'll end up running the same command recorded in the header, but there could be cases (like this bug) where we don't. Either way don't want to update the header in our PRs regardless, because users never expect Dependabot updating anything other than version numbers.

Dependabot is able to run but the dependencies are not what we expect :/. I indeed need this flag in order to generate the proper set of dependencies.

Can you share a public repository where this issue can be reproduced? Ideally we'd be able to record the situation in a test case, and instead of asserting that the correct header is written, assert that the correct dependencies are resolved.

Okay !
Fair enough. It's indeed the expected user experience. Thanks for explaining :)
I don't have one right now (it's privte) but will work towards that :). I'll let you know

Thanks so much @gmcrocetti, this is live now!