Update new-netfirewallrule.md

Changed Default Value for interfacetype

@dariomws306 @tseward
Peer review needed for this PR. Thanks.

Looks good.

Looks good but I think we should apply the same update to W2012 and W2012R2 versions.

Looks good but I think we should apply the same update to W2012 and W2012R2 versions.

cc @msbemba

Madechanges

Looks good but I think we should apply the same update to W2012 and W2012R2 versions.

cc @msbemba

Made changes to 2012 and 2012r2 as well.

Docs Build status updates of commit 121f912:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docset/winserver2012-ps/netsecurity/New-NetFirewallRule.md
:warning:Warning

Details

docset/windows/netsecurity/new-netfirewallrule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/netsecurity/New-NetFirewallRule.md

Line 1083: [Warning] Invalid file link:(~/winserver2012-ps/GPv2_Cmdlets/New-GPO.md).
[Suggestion] Missing attribute: title. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a322a01:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docset/winserver2012-ps/netsecurity/New-NetFirewallRule.md
:warning:Warning

Details

docset/windows/netsecurity/new-netfirewallrule.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/netsecurity/New-NetFirewallRule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/netsecurity/New-NetFirewallRule.md

Line 1083: [Warning] Invalid file link:(~/winserver2012-ps/GPv2_Cmdlets/New-GPO.md).
[Suggestion] Missing attribute: title. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@AndreaBarr The PR is ready to be merged. Thanks.


Ability to Merge Coverage files

When I merge a trx file I need the coverage files merged as well.

Hey @IanBFarrell  thx. for submitting this. Note that we also accept contribution to the project.


"memory"

Running the script I get the mysterious message "memory".
And that's it, just "memory", nothing else at all.
While the amount of rows per table is correct, and the PRIMARY and UNIQUE keys seem ok, the FOREIGN keys are weird, at least if I open them using SQLPro. They look like this:
  FOREIGN KEY (`fragged_player`) REFERENCES (null) () `pixp_user` (`user_id`,
  FOREIGN KEY (`fragger_player`) REFERENCES (null) () `pixp_user` (`user_id`,

When in an old correct version of the file they looked like this:
  FOREIGN KEY (fragger_player) REFERENCES pixp_user (user_id),
  FOREIGN KEY (fragged_player) REFERENCES pixp_user (user_id),

I don't have a working version of the application right now, so I can't test it yet; in case I'll keep you posted.
Feel free to ask me for clarifications or specific debugging.
PS: keep in mind this is a very small db, so there cannot be a real memory error. I mean, if there is, it's because there is some bad loop of some sorts, certainly not because of actual db size.

Versions:
mysqldump --version
mysqldump  Ver 10.17 Distrib 10.4.10-MariaDB, for osx10.14 (x86_64)

sqlite3 --version
3.24.0 2018-06-04 14:10:15 95fbac39baaab1c3a84fdfc82ccb7f42398b2e92f18a2a57bce1d4a713cbaapl

Was your SQL code dumped from MySQL using the commands in readme? We don't (and can't) support any other syntax :cry:.

Was your SQL code dumped from MySQL using the commands in readme? We don't (and can't) support any other syntax 😢.

It was.
I mean, I just added the user and the password, but that's about it.
mysqldump --skip-extended-insert --compact [options]... DB_name > dump_mysql.sql
became something like
mysqldump --skip-extended-insert --compact -u pixp pixp -P > dump_mysql.sql
(not sure I remember this exactly, but it was basically that, I only added username and pwd)
I have now tried to alter the tables manually using SQLPro, but trying to edit the FOREIGN keys crashes it, and trying to delete them gives a syntax error.
(of course you can't do support for SQLPro here, I'm telling this just so you know that the created db was problematic)
Keep in mind that being the db quite simple I could recreate it by hand (annoying but not a big deal), but I appreciate your effort in writing this tool so I'd like to help you anyway.

Ok this might or might not help you: I managed to convert the db using this other script https://github.com/techouse/mysql-to-sqlite3
However, I had a couple of adjustments to make. Namely, there were two INDEXes that the script didn't like: it told me they already existed.
Not really sure if it could be the same problem or a different one.
(I still have to actually test the db live, so far I've only converted it)

Thanks for your effort. Unfortunately the python app https://github.com/techouse/mysql-to-sqlite3 can't be of any help here, because they are "cheating" :wink:. They use MySQL to load the DB (either to memory or to an on-disk temporary DB) and then use the MySQL API to read the data and information out and assemble SQLite syntax out of it. So it won't work for huge databases (or be very slow). We use a very fast (though error prone and unsafe) approach of on the fly rewriting (transpilation) using nearly no memory and no temporary storage and having no dependencies except for POSIX stuff.
Could you please provide the whole MySQL dump or at least the problematic parts (e.g. through pastebin) and then the resulting output you get from mysql2sqlite (please use the latest git version - we're actually not doing any releases yet).

(sorry I've been quite busy these days, and wasn't able to do any test… I'll update you if I can!)

I have exactly the same problem. I initially got it and thought it was because I was running it on an EC2 instance but I downloaded the dump and I get the same on my MacBook. "memory".
It gives that error on the very first statement:
/*!40101 SET @saved_cs_client     = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `articles` (
  `articleID` int(11) NOT NULL AUTO_INCREMENT,
  `include` text NOT NULL,
  `title` text NOT NULL,
  `date` date NOT NULL DEFAULT '0000-00-00',
  PRIMARY KEY (`articleID`)
) ENGINE=MyISAM AUTO_INCREMENT=9 DEFAULT CHARSET=latin1;
/*!40101 SET character_set_client = @saved_cs_client */;

@markstickley which AWK (and version) are you using? This is all weird - I've tested the latest version from git and with recent GNU AWK it works without any issues (as it did in Nov 2019 when this thread got opened).

OK I'm not too familiar with awk but a bit of googling got me to this (on my MacBook):
$ awk -Wversion 2>/dev/null || awk --version
awk version 20070501

Bit different on my Ubuntu EC2 instance:
$ awk -Wversion 2>/dev/null || awk --version
GNU Awk 4.1.3, API: 1.1 (GNU MPFR 3.1.4, GNU MP 6.1.0)
Copyright (C) 1989, 1991-2015 Free Software Foundation.

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see http://www.gnu.org/licenses/.

Hope that helps...

Thanks - both versions are supported by this script. So let's summarize.

you ran mysqldump ... and got file.sql from it
you ran ./mysql2sqlite file.sql > file2.sql
you ran sqlite3 file2.db < file2.sql
you noticed message memory and an error code on the command line (i.e. in $? variable there was no 0)
you noticed there is no file2.db file

I've tried exactly this process, but it went like this:

I took the example code from https://github.com/dumblob/mysql2sqlite/issues/65#issuecomment-573162370 and put it in file.sql
I ran ./mysql2sqlite file.sql > file2.sql (I got no errors, no complaints, no warnings, no issues)
I ran sqlite3 file2.db < file2.sql (be careful, file2.db must not exist as otherwise sqlite3 will complain about existing tables as the create table... is without if not exists)
I noticed message memory (which is fine as that's what SQLite PRAGMA journal_mode = MEMORY; outputs) and no error code on the command line (i.e. in $? variable there was 0)
I noticed there is file2.db file
I ran sqlite3 file2.db (which opened in an interactive mode)
I ran select * from articles; and it ran fine and returned empty result without any errors
I closed the db with .exit

Btw. you can also run sqlite3 with the -echo argument to see each command and sqlite3's response line by line.

OK this is really helpful thank you.
I actually ran the commands as instructed under the Usage section in the readme but I assume that and these instructions are basically doing the same thing.
I think I just assumed that the memory message was an error without any other context. Having completed the steps you outlined (and ignoring the memory output) it seem to have worked great. Thank you very much for your help!


Move voting results to the top?

We could move the voting placeholders and results to the top and center align them, maybe even make those cards bigger

Closed via https://github.com/humanmade/Hatjitsu/commit/a712e55695ed516b2ad4dfcc84b4182f66133224


Option to cargo run to make it set the project dir as the current working directory

Problem
I set up a cargo alias in .cargo/config.toml as follows:
[alias]
gen-cli-reference = "run -- generate-cli-reference docs/cli-reference.md"

The goal is so that cargo gen-cli-reference would be a nice cross-platform way a developer can auto-generate some docs.
This only works from the root directory of the project, because cargo run runs the binary in the current working directory.
Proposed Solution
I would like an option cargo run --in-project-dir that runs the binary from the root of the project, which is $CARGO_MANIFEST_DIR, I think. Then, I could define
[alias]
gen-cli-reference = "run --in-project-dir -- generate-cli-reference docs/cli-reference.md"

and cargo gen-cli-reference would work from anywhere.
Notes
Workaround: An alternative might be to write an xtask that reads $CARGO_MANIFEST_DIR (Update: I checked that this is indeed available to a program running with cargo run). The xtask would then execute cargo run.
I think this could work well, but would require quite a bit of boilerplate code.

For myself, this feels like a fairly specialized flag for run.  I wonder if another approach is to design this into a more advanced "alias" system that I would one day love to have.  Unfortunately, that is less firmly defined and very low on most people's priority lists.

Another issue in this proposal is the semantics of --in-project-dir. Does it refer to the workspace root or thee package root directory? I believe both of them are reasonable choices, but you cannot satisfy both usages with only one boolean flag.
And agree with epage this is fairly specialized and a bit low in priority. xtask is indeed a good alternative, as you've mentioned. Cargo itself also makes use of it to determine package/workspace root. If you'd like to get the directory rustc is invoked from, see the unstable CARGO_RUSTC_CURRENT_DIR env var.
Some other issues might be related:

https://github.com/rust-lang/cargo/issues/6575
https://github.com/rust-lang/cargo/issues/10789
https://github.com/rust-lang/cargo/issues/12477

Since there is an alternative and nothing blocks people from using that, I'll label this as P-low as this moment. Please let us know if there is more info you'd like to add :)

I think this is fair, thanks for the example and the suggestions!
Another thing I missed is that run -- generate-cli-reference > docs/cli-reference.md couldn't be an alias. OTOH, I'm not sure whether that should be in-scope.

When you run cargo run -- generate-cli-reference > docs/cli-reference.md in your shell, > is parsed and interpreted as redirections by the shell. However, when it is an alias, there is no shell involved in parsing it in Cargo, so a list of args ["generate-cli-reference", ">", "docs/cli-reference.md"] will be passed to the running executable I believe. This is discussed in https://github.com/rust-lang/cargo/issues/6575.

Yes, it'd need a different syntax, or some other solution. Shelling out would defeat the purpose of portability to Windows.

I'm running into this and find a proper workaround:
[env]
CARGO_WORKSPACE_DIR = { value = "", relative = true }

[alias]
o = "run --manifest-path $CARGO_WORKSPACE_DIR/dev/Cargo.toml --"

However, it seems alias string doesn't resolve env var and thus this fails to work. But perhaps the direction is worth to dig more.

There is no variable substitution in [alias] yet. We'll need to define a proper cross-platform escape for that. See https://github.com/rust-lang/cargo/issues/13348#issuecomment-1912350511 for relevant issues and discussions.


Enable swagger to sdk pipeline for Ruby in master branch

Enable swagger to sdk pipeline for Ruby in master branch

Hi @vishrutshah, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

@vishrutshah The build is green, but we didn't actually test the generation it self. The script is looking for the list of swagger files changed by this PR. Since there is swagger files changed by this PR, no build are tested:
INFO:__main__:Skip file not in PR authorization

I suggest you to launch the script manually from your computer, using vishrutshah:swagger_to_sdk_ruby as your local branch. You should be able to test the real behaviour.

@lmazuel I've pushed swagger_to_sdk_config.json into master branch to enable this pipeline. How do you sync https://github.com/AutorestCI/azure-sdk-ruby from https://github.com/Azure/azure-sdk-ruby.

No modification for Ruby

No modification for Python

No modification for NodeJS


{Core} Optimize performance for MSAL migration

Description
As authentication logic is now split from Profile, performance can be further improved by lazy loading .auth.identity module.
> Measure-Command {python -m azure.cli version}
TotalMilliseconds : 384.9338

> Measure-Command {az version}
TotalMilliseconds : 404.2362

Imported modules can be inspected with
python -X importtime -m azure.cli version 2>perf.log; tuna .\perf.log

performance Optimization


journaling of Ferret screen output (SHOW, LIST, errors & warnings)

Reported by Ansley B Manke on 21 Aug 2003 17:24 UTC
From Billy, 20-Aug-2003
Hi Steve, Ansley -
I often use the journal files to reconstruct a calculation,
perhaps years later. Although the jnl retains every command
given, it can still be difficult to figure out what was done,
particularly if a variable was defined and redefined several
times during a session. This is also the case if a script was
used to define variables, perhaps having been edited during
the session or after.
A useful enhancement would be the ability to write the variable
definitions currently in force into the jnl file during a session.
The command would be something like:
yes? SHOW VARIABLE/JNL name
and it would simply write the current list of variables into
the jnl file (in the same format as SHO VAR would list them in
the session window). That would allow the user to more easily
reconstruct a plot or calculation by recording the exact
definitions in force at the time a PLOT or SAVE command was
given.
Billy K
--- could also be applied to other SHOW commands, and
the LIST command.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/594

Comment by<EMAIL_ADDRESS>on 7 Nov 2003 22:52 UTC
move to Ferret Tasks, reassign to Ansley
Further ideas:
A series of new qualifiers, SHOW  */JNL  and LIST/JNL.
OR,
SET MODE REDIRECT:journal
or
SET MODE REDIRECT:filename.txt
which would allow you to take the output of any stdout command and
send it (or a copy of it?) to the journal file.  Since all output passes
through the single routine STDLIST such a command could (in principle)
quite easily easily be implemented.
One detail, so that the principles of the journal file are not violated,
would be to precede the lines of output (as sent to the journal file)
with an exclamation mark.

Comment by<EMAIL_ADDRESS>on 5 Nov 2004 19:05 UTC
changing "Severity" tag of bugs under Ferret Tasks to "enhancement"

Comment by<EMAIL_ADDRESS>on 5 Nov 2004 19:20 UTC
Changing Component of bugs in "Ferret Tasks" from All to Main

Comment by<EMAIL_ADDRESS>on 17 May 2006 23:19 UTC
*** Bug 1413 has been marked as a duplicate of this bug. ***

Comment by<EMAIL_ADDRESS>on 7 Jun 2007 16:33 UTC
I really like the idea of being able to redirect arbitrary screen output to a
journal file.  This would enable scripts to access a lot more information about
the Ferret state.
In addition to resolving bug 1413, it'd provide immediate workarounds for
proposed future enhancements -- like the return=modulo feature suggested in bug
1359.  It'd also allow scripts to detect warning messages and notes from Ferret,
check what external functions are available, get a list of the datasets
currently in use, etc.

Comment by<EMAIL_ADDRESS>on 19 Jun 2007 21:12 UTC
Capturing here a set comments from an email thread...
(Steve)
This is an idea that has floated around in various forms ... maybe we should
bounce some ideas around an pin down an approach.  The goals are

able to redirect stdout (for example the stat command)
able to redirect stderror
redirect to a new file?  append? to the journal file as comment lines?
should it be a state that lasts for only the next command?  Or until
turned off?  Or until the end of the current journal file?

For example one:
SET REDIRECT[     "stdout"
or "stderr"
e.g.
SET REDIRECT/next/journal stdout
STAT expression
The default for "SET REDIRECT" alone might be (say) to redirect both stderr and
stdout to ferret_redirect.txt until turned off with CANCEL REDIRECT.

(Andrew)
I like that specification.  In terms of implementation order, I would prioritize
the qualifiers (top to bottom) as:
/FILE=name
/CLOBBER
/APPEND
/JOURNAL
/NEXT
If I understand correctly, the "/FILE=name" qualifier would redirect the
specified output stream (STDOUT or STDERR) verbatim to a text file instead of to
the screen. In contrast, the "/JOURNAL" qualifier would redirect to the
currently active journal file (displayed with SHOW MODE JOURNAL) in the form of
comments (i.e. prefixed with "! ").
Am I correct in assuming that "/CLOBBER" and "/APPEND" would apply only
to verbatim output files such as "/FILE=name", and not to a journal file?
(I'm not sure you'd ever want to clobber a journal file via REDIRECT.)
The "/NEXT" qualifier is simply a shorthand form for isolated commands,
to prevent having to CANCEL REDIRECT, right?  That's fine.
You could add yet another qualifier:
/TEE
(like the Unix command) which would output to the screen as well as
the specified file.  E.g.  the following commands
SET REDIRECT/TEE/JOURNAL
would journal all Ferret commands, stdout, and stderr, with everything still
going to the screen as well.

(Billy K )
I agree with everything Andrew says. Both TEE and NEXT sound like additions I
would use.
With regards to Steve's question 4, I think REDIRECT should define a state that
persists until turned off (but NEXT shortcuts for the case of a single command).
I would make the STDOUT the default listing.

Modified by karl.smith on 22 May 2010 01:21 UTC

Modified by karl.smith on 22 May 2010 01:21 UTC

Comment by karl.smith on 27 May 2010 23:45 UTC
Added
SET REDIRECT [ /TEE ]{ /JOURNAL | /FILE= /CLOBBER } [ STDOUT ] [ STDERR ]
and
CANCEL REDIRECT [ STDOUT ] [ STDERR ]
Messages sent to the journal are prefixed with '!'
If neither STDOUT or STDERR is given, SET REDIRECT defaults to just STDOUT, and CANCEL REDIRECT cancels all currently active redirections.
At this time it does not redirect MESSAGE strings ('SAY' strings, warnings, and errors).
/NEXT not implemented, so will have to set redirect, run the command, and cancel redirect

Comment by karl.smith on 27 May 2010 23:46 UTC
Should have had slash-append or slash-clobber in the command line

Comment by andrew.wittenberg on 28 May 2010 00:25 UTC
Very cool!  One other suggestion while you're at it -- could you add redirection to a Ferret symbol and/or string variable?  This would enable a script to more easily capture Ferret's messages and do error checking etc.
Of course, we could already to this with the above syntax:
set redirect/tee/clobber/file=result.txt
<<commands>>
cancel redirect
let result = spawn("cat result.txt")

But this could be simplified to something like:
set redirect/tee/variable=result
<<commands>>
cancel redirect

and with /NEXT this would be even simpler.  Is this doable?

Comment by steven.c.hankin on 28 May 2010 23:20 UTC
Be careful not to let the complexity of this outpace its utility.  The command syntax "/variable=result" is likely to be quite hard to implement, because it asks to invoke the "compiler" functions of Ferret from an unusual starting point.  One approach might be to keep this idea in mind as a target for implementation after fundamental redesigns have occurred through the wrapping in Python.
An alternative and easier way to implement this functionality might be the inverted approach of
REDIRECT/file=result.txt (Ferret command 1; ferret command 2)

which would blend naturally into how operations are performed on Ferret's "control stack". Even for this, though, I'd consider the cost/benefit carefully.
Question:  The intention of the "/TEE" qualifier isn't self-evident to me.  Is it to indicate that you want to add another output path, while preserving the current ones (e.g. add a file logging while retaining stdout)?   Similar vein question about having both a /JOURNAL and a /FILE.  How do these differ?  Consider whether simplifications in the command qualifiers are possible.

Comment by steven.c.hankin on 28 May 2010 23:36 UTC
oops -- in editing the last comment I ended up suggesting a syntax that was fairly easy, but not equivalent to Andrew's suggestion.  The simpler-to-implement equivalent to what Andrew suggested might be something like
let result = REDIRECT(<<commands>>)

The target filename for the redirect would need to be set in the SET REDIRECT command.
Babbling here ... but since this implementation is in part an exercise to climb the learning curve, it may be worth mentioning that arguably the use of SET REDIRECT to set only state information such as a filename that is later be invoked by a REDIRECT command or a REDIRECT function is more consistent with other Ferret commands.
Implementing a REDIRECT command would in fact be a good learning curve exercise and might be nicer to use than a SET REDIRECT, which must almost always be followed by a CANCEL REDIRECT.  (A new xeq_redirect.F subroutine could be patterned after xeq_repeat.F)

Comment by ansley.b.manke on 29 May 2010 00:07 UTC
Now that I think of it, maybe this functionality is more in the line of a SET MODE, which can stay set for one command or a whole session. We already have
SET MODE JOURNAL :filename]
SET MODE METAFILE [:filename]

so perhaps this should be in that family of commands.

Comment by karl.smith on 3 Jun 2010 23:28 UTC
(Sorry, wasn't getting e-mails that comments had been added.)
I think SET MODE REDIRECT instead of SET REDIRECT is better in line with what I have currently implemented.  I am then envisioning "let result = REDIRECT(<>)" being implemented as a command stack along the lines of what Andrew suggested: redirect desired output stream(s) to a temp file, run the command(s), cancel the redirect, set the variable with the file contents.

Modified by karl.smith on 3 Jun 2010 23:30 UTC

Modified by karl.smith on 3 Jun 2010 23:30 UTC

Comment by karl.smith on 7 Jun 2010 18:11 UTC
Since SET MODE ... does not support qualifiers at this time, I am leaving SET REDIRECT and CANCEL REDIRECT as is.
For the redirect function:
LET result = REDIRECT()
where the commands produce multiple lines of text, I am assuming that the result will be an array of strings as is produced if one used:
LET result = SPAWN("cat tmpoutfile")
(but I won't be using SPAWN).

Comment by ansley.b.manke on 7 Jun 2010 18:21 UTC
This ticket is getting long and complex.
Karl, I think I sent you in the wrong direction thinking about putting the result of the REDIRECTed commands into a variable.
Here is the bit I think Steve was talking about, just a modification of the SET REDIRECT you've already done.
An alternative and easier way to implement this
functionality might be the inverted approach of

REDIRECT/file=result.txt (Ferret command 1; ferret command 2)

which would blend naturally into how operations are
performed on Ferret's "control stack".

Modified by ansley.b.manke on 5 Jan 2011 19:48 UTC

Comment by karl.smith on 5 Jan 2011 20:44 UTC
Since
SET REDIRECT [ /TEE ] { /JOURNAL | /FILE=<name> [ /APPEND | /CLOBBER ] } [ STDOUT ] [ STDERR ]
and
CANCEL REDIRECT [ STDOUT ] [ STDERR ]
are implemented, once I get these in the documentation I will close this ticket.  I will open another ticket with the
LET myresult = REDIRECT( <commands> )
discussion, which probably has lower priority.

Modified by karl.smith on 9 Mar 2011 20:42 UTC

Modified by karl.smith on 4 Apr 2011 17:11 UTC

Comment by karl.smith on 8 Apr 2011 20:21 UTC
Added set redirect (and cancel redirect) to plone command reference.


Proposal: change mutation name style

The original text uses REMOVE_TODO (uppercase constant style, reminiscent of React and Redux) as mutation name in an example. I propose that it changes to todoRemoved, a style that will match the rest of the code, while maintaining a clear distinction from related actions.

We're actually inconsistent about this in our current examples - sometimes using UPPER_CASE, sometimes camelCase. We're discussing it internally and right now, are leaning towards consolidating on camelCase for mutation names, which is more generally the standard for function names in JavaScript.

@chrisvfritz awesome, very glad to hear! -- should I keep this PR open then? :)

@chrisvfritz I'll insist then on my proposal for past-tense mutations then. I think having both deleteTodo and removeTodo would be weird and would contribute to confusion. Having past-tense mutations (todoRemoved) offers a clear and easy distinction between mutations and actions. We've adopted this standard in a number of projects at work and it's been pretty manageable.
I'll leave the PR open if this suggestion stands a chance of consideration.

@galvez I think the chances are relatively low, but it's not impossible at this point. Personally, if I see something called todoRemoved, I'd think it was either a boolean to tell me whether or not a todo was removed, or an event to log that the todo was removed. In the context of commit('todoRemoved', todoId), the todo is not technically removed yet, so we're calling the function to make that happen rather than reporting that it was already done.
Also more generally in JavaScript, imperative-style verbs are almost universally used for called functions, so we'd be breaking a big convention of the larger ecosystem.
Does that make sense? Also, I'd love to hear more about the confusions that the past-tense convention resolved for you. I'm wondering if there may be a 3rd option or additional convention that could resolve all our concerns. 🙂

@galvez I think the chances are relatively low, but it's not impossible at this point. Personally, if I see something called todoRemoved, I'd think it was either a boolean to tell me whether or not a todo was removed, or an event to log that the todo was removed. In the context of commit('todoRemoved', todoId), the todo is not technically removed yet, so we're calling the function to make that happen rather than reporting that it was already done.
Also more generally in JavaScript, imperative-style verbs are almost universally used for called functions, so we'd be breaking a big convention of the larger ecosystem.
Does that make sense? Also, I'd love to hear more about the confusions that the past-tense convention resolved for you. I'm wondering if there may be a 3rd option or additional convention that could resolve all our concerns. 🙂

we'd be breaking a big convention of the larger ecosystem.

That's a valid point. Adopting past tense for mutations also required creating the notions that mutations are really special functions. Since their purpose is to provoke actual state change, naming them in past tense simply created a way to identify them by interpreting them in a what happened after this ran narrative. It made sense enough to me, but I understand it may confuse some. Other ideas that come to my mind would involve even more complex and redundant semantics.

One small thing: the past-tense narrative also encourages data wrangling logic to happen outside the mutation, keeping them pure.

Since their purpose is to provoke actual state change, past tense simply created a way to identify them by interpreting them in a what happened after this ran narrative.

That makes sense. 🙂 It's what I was attempting to achieve with the suggestion to describe the specific nature of the mutation, but it sounds like it's not quite sufficient to avoid confusion. 😅 Do you think it would help to define an exhaustive list of verbs to recommend that all mutations begin with?
Browsing through my own apps, I believe every mutation could begin with one of the verbs below:

push: when using Array.prototype.push.

pop: when using Array.prototype.pop.

unshift: when using Array.prototype.unshift.

shift: when using Array.prototype.shift.

reverse: when using Array.prototype.reverse.

copyWithin: when using Array.prototype.copyWithin.

fill: when using Array.prototype.fill or otherwise setting static or non-deterministic values for 2 or more items in an array.

sort: when using Array.prototype.sort or otherwise sorting the items in an array (e.g. with lodash's sortBy or orderBy).

delete: when removing 1 or more items from an array or object, whether using Array.prototype.splice, Array.prototype.filter, Vue.delete, or some other strategy.

set: for all other cases using = to set a new value for an existing property, or Vue.set to create/set a property.

As a bonus, this strategy would also help people limit the scope of their mutations, keeping all business logic in actions where it belongs. In the apps I have access to, I did notice some cases where none of the above verbs were appropriate - but in every case, the mutation was doing much more than it should have.
And as another bonus, this convention could speed up development with snippets and we might even be able to automate its enforcement in eslint-plugin-vue! 😻 (@michalsnik, do you think that might be feasible?)
What are your thoughts? In the teams you've worked with, do you think this would clarify the responsibilities of mutations for and reduce the cognitive overhead of naming them?

@chrisvfritz No reason we can't do both, I guess? How about we add a paragraph as follow to the docs:

When naming mutations, a good strategy is to mimic the list operations the mutation mainly performs, e.g., `pushUser`, `unshiftUser`. If that is too limiting an approach, you can also adopt a past-tense narrative style, where a mutation is named after the changes it provokes, e.g., `userAdded`, `userRemoved`. Either way promotes keeping mutations pure, with data wrangling logic best kept in actions.

I added it to the bottom of style-guide/index.md, but feel free to edit and relocate it if you think it's a good idea.

I like this idea @chrisvfritz !
However in terms of eslint rule that might check it - I'm not so sure. Depending on a person or team, structure of the vuex module might differ drastically. Some might keep it in store folder, some not. One team prefers to have single file modules, other not. Same with keeping mutation names as constants in a separate file. I don't see how - except explicit comments detect whether given mutation is indeed a mutation using just an AST and filename from the context. In the end it might probably introduce too many false positives as well as false negatives.
I think that this kind of rule might be feasible but only per-project case as a team's internal agreement, so as from our plugin's perspective I must say: no, it's not feasible, unless I missed something.

Maybe we should move this to https://github.com/vuejs/vuex? 🤔


Align confirm delete modal popup header texts

Change the card title for all confirm delete modal popups from "Are you sure" (may include question mark but not consistent) to "Confirm deletion".
Before

After

We will group this with an effort to make a generic confirm delete dialog that can be used in many use cases.

Yes, combined it with #1402 but all confirm delete dialogs are now converted to templ since today and also merged in dev.


Bimanual manipulation update

Update to PR #228
Depends on Field-Robotics-Lab/uuv_manipulators#9
Expected scenario:
Demonstrates grasping and stability while holding a static object and picking up a pot.

Changes made:

Added controller arguments (effort vs position)
Added arguments for ROV initial position in launch file

To test
roslaunch dave_demo_launch dave_oberon7_moveit.launch

After allowing time for startup, run
roslaunch rexrov_oberon7_moveit rexrov_dual_arm_moveit_planning_execution.launch moveit_controller_manager:=rexrov

Once planning can begin, run the updated simple demo
rosrun_dave_nodes bimanual_simple_demo.py

Notes:

Occasionally the pot slips out of the gripper, I adjusted the pot friction values locally.

Ooh this is cool.
Since we're here, could I ask for a favor? Could you throw this extra object into the world:
<uri>model://sunken_vase_distorted</uri>

as part of the "scenario: degraded object manipulation" task? Our current scenario for that task has a multibeam sensor but not an arm, so it's more perception than manipulation.  This world looks perfect with its existing stock of 1 vase. We could make it 2 vases.
Thanks in advance!

@mabelzhang Do you want me to do anything else with it? Ie, set it as a target to pick up or anything?


IndexError: list index out of range on lemmatized Korean data

Hi!
Maybe you have some guess for what might cause your code to fail on en-ko dev? It has worked fine for other languages I have tried so far.
Traceback (most recent call last):   File "evaluate_term_wmt.py", line 381, in <module>     exact_match(l2, exactreferences, outputs, ids)   File "evaluate_term_wmt.py", line 298, in exact_match     c, w, cl, wl = compare_EXACT(outputs[i], references[id])   File "evaluate_term_wmt.py", line 89, in compare_EXACT     hyp_l = ' ' + ' '.join([w.lemma for w in doc_f.sentences[0].words]) + ' ' IndexError: list index out of range
Help would be much appreciated!

It seems to happen when your hypothesis has an empty line. Let me talk to Antonios and see if we can give a fix.

Thanks! It was a trivial mistake on my part!


CAN'T UPDATE LONG URL

When I update the long url the short url doesn't redirect to the new/updated url. On the info page, the long URL is "clearly" displayed on the page, and when I hover with my mouse it is again displayed in the bottom left of the browser screen. But when I click it, it redirects to the index/home page of the website I'm linking to. The same thing happened when I click on the shortened url also. Very annoying. Now I have to delete all my links and start over using a different shortened name for each. Is there a cache folder I can clear out to resolve this issue?

Is there a cache

Yes, right in your browser. Please clear your browser's cache.
See #1964


feat(spanner): exporting transaction._rolled_back as transaction.rolled

IPR  [13]

@mf2199  Yes , true but not sure about give a access through class property as they need to expose as a class variable like ClassName.Variable.
I am confused, Should i make that change or let googler comment on the current changes like what they want.

I'd explain the alternative in the comments and ask for their opinion. Again, your solution isn't wrong.

Merged.


Add reprompt text functionality

This should have the following interface, probably:
respond("Here's a thing!", reprompt: "Please say that again.")

Don't forget to add SSML support by wrapping in <speak> and stripping out any <speak> tags added by the user (see #12)

Is this issue under already under construction? At least it marked like that in a Contributing section.

Hi Veronika, this is not currently under active development - it’s on my
roadmap of features but haven’t been able to make a start yet
Hopefully within a month I’ll have added this, unless you’d like to have a
go?
On Fri, 25 May 2018 at 21:18, Veronika Salo<EMAIL_ADDRESS>wrote:

Is this issue under already under construction? At least it marked like
that in a Contributing section.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sjmog/ralyxa/issues/11#issuecomment-392168810, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADVzNitFQYCG00CXHFyOSAb91DppsYlsks5t2GcxgaJpZM4SkJCz
.

@sjmog @mattrayner I created a PR for the issue: https://github.com/sjmog/ralyxa/pull/16


fix acting expected stderr as an error in logs and results, no need for ignore_exit_code to be present for expected stderr.

This change is

See https://github.com/Landoop/coyote/pull/9


Docker Healthcheck support

Describe the feature
Being able to see a "health status" of the openvpn Docker container.
Describe the solution you'd like
I would like support for the Docker Healthcheck (that is also shown in Portainer.io and probably other Docker management software).
Describe alternatives you've considered
Alternative is setting up something similarly without the use of the already existing tools within Docker.
Additional context
Usually for HTTP services I add something in the Dockerfile like this:
HEALTHCHECK --interval=60s --timeout=10s --retries=3 CMD (curl -sS http://localhost:80 && curl -sS http://localhost:443) || exit 1.
Obviously in this case curl probably won't suffice. But there should be a command to check if the UDP or TCP port 1194 is open and otherwise results in an error. That should be sufficient to create simple HEALTHCHECK support for Docker.
For debugging and testing purposses you can use:
docker inspect --format "{{json .State.Health}}" containername

To expand on the idea in .... just use pgrep in your dockerfile or docker-compose file

So @ElleshaHackett,
Give the now closed PR a look. In there is tour recipe on getting a HEALTHCHECK for the openvpn container.
And then maybe close this thank you. Have a great 1.

@larssb great! Thanks a lot :)


Unable to download the latest version(v1.0.0-beta.11-webpack.2) via npm

Mac OSX El Capitan

ng version
(node:3185) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
angular-cli: 1.0.0-beta.10
node: 6.3.0
os: darwin x64

https://github.com/angular/angular-cli#updating-angular-cli

Running into the same problem cant install angular-cli@webpack.
Download is fine and then it starts to lockup one core with 100%
Last message is see is.
extract:angular-cli: sill doParallel extract 1136
When the log level is upped this is happening somewhere around accessing the .staging area.

Mine is exiting on this error. No idea how to fix it. I've unbuilt the old angular cli and cleared my npm cache.
npm ERR! Linux 4.2.8-300.fc23.x86_64
npm ERR! argv "/home/<user_dir>/.nvm/versions/node/v4.3.2/bin/node" "/home/<user_dir>/.nvm/versions/node/v4.3.2/bin/npm" "install" "-g" "angular-cli@webpack"
npm ERR! node v4.3.2
npm ERR! npm  v2.14.12
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| >=1.9.0-dev
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>

I noted that the last version of the cli in npm registry is different from github release

@kevinaud I experienced the same error last week.
You need to have upgrade npm to version 2 or higher.
It's also mentioned in the docs: https://angular.io/docs/ts/latest/quickstart.html
I hope this helps.
Kinds
Greg

Still cant figure out why its hanging.
Tried different .npm dirs / local & global
with the following versions angular-cli@webpack and<EMAIL_ADDRESS>
Arch Linux
npm -v 3.10.6
node -v v6.5.0

Downloading works as intended then it moves from getting a lock into unbuild and gets stuck after that.

Hi @nrehm,
could you provide a log, please?
That would help to figure out the problem.
Kinds
Greg

Sure @GregOnNet  cutting it down to the relevant part.
npm i -g --loglevel verbose angular-cli@webpack &> node.log

npm verb correctMkdir /home/spdy/.npm correctMkdir not in flight; initializing
npm verb afterAdd /home/spdy/.npm/lodash._baseisequal/3.0.7/package/package.json not in flight; writing
npm verb correctMkdir /home/spdy/.npm correctMkdir not in flight; initializing
npm verb afterAdd /home/spdy/.npm/lodash._baseisequal/3.0.7/package/package.json written
npm verb correctMkdir /home/spdy/.npm/_locks correctMkdir not in flight; initializing
npm verb makeDirectory /home/spdy/.npm/_locks creation not in flight; initializing
npm verb lock using /home/spdy/.npm/_locks/staging-a6bba7612d1947de.lock for /home/spdy/.npm-global/lib/node_modules/.staging
npm verb unbuild lib/node_modules/.staging/parse5-e8969c23
npm verb unbuild lib/node_modules/.staging/abbrev-ef9e8e0c
npm verb unbuild lib/node_modules/.staging/adm-zip-3355db79
...
npm verb unbuild lib/node_modules/.staging/chalk-b2d504b0
npm verb unbuild lib/node_modules/.staging/supports-color-e57343cb
npm verb unbuild lib/node_modules/.staging/source-map-54701b35
npm verb unbuild lib/node_modules/.staging/clap-a91a9668
npm verb unbuild lib/node_modules/.staging/ora-695777ca

here it gets stuck and locks up one core with 100%.
Tried to install it on another arch linux installation same problem.

Unfortunately I do not have Arch Linux running on my system.
I have never seen this kind of error as well.
I wonder what correctMkdir means.
Does npm try to write something to the disk but has no permissions?

It would error out with EACCESS.
Did tests with sudo and the default installation / used a prefix etc.
Reinstalled node/npm gets kinda confusing what the root problem is right now.
Other packages install just fine.

for all with the same issue, there is a closed issue here: #1932. short: current version of nodejs (6.5) causes this issue. downgrade to 6.4 helped.
Is this a nodejs issue or an angular-cli (dependency) issue?

Closing as a dupe of https://github.com/angular/angular-cli/issues/1932, which has a solution/explanation.


Troubling at inputing API key

When I input my openai API key, and press the right refresh like key, it just keep rolling and rolling on the right side. And I'm sure my api key is validate.
just like this:

And then, "Server error unspecified " occurs

So I have no idea whether it is because of my api key or my internet environment or just something else. Looking forward to your reply. Really wish ai-reader goes well.

When I input my openai API key, and press the right refresh like key, it just keep rolling and rolling on the right side. And I'm sure my api key is validate. just like this:  And then, "Server error unspecified " occurs  So I have no idea whether it is because of my api key or my internet environment or just something else. Looking forward to your reply. Really wish ai-reader goes well.

Thanks for the report! I think it might have to do with the regional ban on OpenAI's part as I've heard about people not being able to use AI Reader until they connect via VPN (and using VPN in global mode, instead of, e.g., in browser only). Please try with global VPN again if you can and report back.
On my end, I'll add a more specific Error message for this situation so you know it's because of the connection issue with OpenAI server.


Set user agent

I came across a site I'm trying to scrape which does not return results unless the User-Agent header is set. It's probably good practice anyway to set it to something like "scrape-it X.Y.Z" to self-identify. Alternatively, my problem would be solved if it were possible to pass options through to the underlying request which I could imagine being useful for other purposes too.

@michaelmior Use the headers object:
// Promise interface
scrapeIt({
    url: "http://ionicabizau.net"
  , headers: { "User-agent": "scrape-it X.Y.Z" }
}, {...}).then(...);

By passing an object instead of a string, you're passing the options. Hope it helps!

Sorry, I must have missed this in the documentation. Although it should have been painfully obvious after I looked at the code. Thanks :)

@michaelmior No worries, feel free to ask when you're in need. 😁 Have fun with this library!


fish angle description

we should add fish angle
definition should be: angle of  the principal axis of the mask formed with/by head, eye and trunk traits

I will add this to the v1 list and image


Replace the Logo of Layer5 with Service-Mesh-Patterns in config.yml workflow

Description

Currently, we are using the Logo of Layer5 instead of service-mesh-patterns. This repository is under the organization service-mesh-patterns, so, there should be the image of service-mesh-patterns.
How to resolve this?

Go to .github and replace this welcome image with the new one:

Download this image, and upload with the correct name for future reference. The name of the image should be Service-Mesh-Patterns-celebration
After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:

  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
    	   	    	    	 :star: Please leave a [star on the project](../stargazers). :smile:

That's it.

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I would like to work on this issue.


Implement a parser for Codacy

Based on the discussion of https://github.com/DefectDojo/django-DefectDojo/discussions/8970 I opened this issue to help with a PR regarding codacy.

No response in the discussion to bring report files. Thus, closed.


Windows VM cannot get serial output

I've got a serial device which connects to ubuntu through PL2303 USB converter. The serial device would output strings to USB-serial when it's working.
In ubuntu I open a console and type "cat /dev/ttyUSB0" to see if there's any string from the device.
sudo xfreerdp /serial:COM1,/dev/ttyUSB0
When the serial device is working, I can see output in the console with "cat /dev/ttyUSB0", but no any output in Windows VM opening a hyper terminal.
What might lead to this?

There have been some changes in serial redirection. Reopen if this still affects current nightly builds.


 Kunnen later natuurlijk nog toegevoegd worden.

Couple of comments:

I see 185 changed files including some collections that should have remained unchanged with the commits done. As part of the STAC_IO default template. Did you run the script again when you changed this?
Also could you check the provider? We are not the producer. Please have a look at the flood projections or pop. dynamic scripts.
Can you add the labels "Sea Levels" and "Full-Track" in the list of key words where mean sea level etc is situated? This will help F/E with their filters.
Regarding the plot type, please try this: collection.extra_fields["deltares:plotType"] = PLOT_TYPE. It should work then..
The license part is now proprietary. I see that you removed a part in the stac scripts. It this in line with what was present in the metadata.json?

Cheers


Change .IPA name.

Change .IPA name " Beam Wallet" to "Beam Wallet Testnet", "Beam Wallet Masternet", "Beam Wallet Mainnet"  according to build's branch.

"

checked on testnet.


funkwhale: init at 0.20.0

Motivation for this change
This adds a new package and module which enable the Funkwhale music web service  (https://funkwhale.audio/).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Any progress here?

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

types.str for a single string where merging does not make sense, or cannot work
types.lines for multi-line configuration or scripts where merging is possible
types.listOf types.str for a mergeable list of strings

Nothing happening so closing.

@FRidh I'm not sure I understand. Do you expect more actions from me ? I've made all the requested changes for the initial pull request but my fixes didn't received any review.

Please do not merge master. Instead, rebase your changes on top of master.

Thanks for the review. I also fixed the deprecated types.string and updated to funkwhale 0.19.1.

Hi @worldofpeace I've fixed the descriptions and the hashes of the python packages. There are also new packages extracted from the funkwhale NixOs module. You will see that I've disabled the check phase for half of them, I didn't find obvious ways to make tests pass for those, and my python abilities are limited. If you want to merge the python packages separately, should I prepare distinct pull requests ?

@mmai I've pushed some fixup commits here for things I knew how to fix right away.
I think I can do one last quick review of the modules, and I can just push them to master from this PR.

@worldofpeace I've rebased the fixups.
I've removed the explicit dependencies on django_2_2 on django-oauth-toolkit and django-auth-ldap. django-auth-ldap is in fact compatible with django 1, and for django-oauth-toolkit I took inspiration on django-raster to check the django version.
I tried to setup tests on channels-redis with the github sources, but they eventually fail, I've kept the code in comments.

@mmai I'll see about integrating the python packages later today.

Lol more like today now :rofl:

Merged all python modules in #71262.
We need to drop all those commits from here, and the funkwhale commit needs a rewrite to not add you to the maintainer list. I had to do that separately for merging the modules https://github.com/NixOS/nixpkgs/pull/71262/commits/3895e097c365fee76149efd676d94bef5952bdf2.

Thanks @worldofpeace . I've removed the python packages commits.

@FRidh @Infinisil I didn't managed to set a structure resembling what you describe. Looking at the mailman package code and the documentation didn't help.
I'm really sorry to say that  at this point I am not able to work on this anymore. I feel that my python and nixos abilities are to shallow and I invested way more time than initially planned, and I see that we are far from having a stable package (the master branch already breaks python dependencies).
Feel free to close the pull request.

Hi, I am one of Funkwhale's maintainer, and I wasn't aware of this packaging effort, so I'm a bit late. I don't have any knowledge about NixOS, however, I'd be willing to help if you need some clarification or tweaks on Funkwhale side to make it easier to packagers.
I can also answer questions you have regarding our dependencies, for instance.
Many thanks to the people who worked on this!

@matthiasbeyer would you be able to finish it?

Holy cow. I doubt it. Mainly because I do not know how to properly write services and also because I have little time. I will try next weekend though, if I do not forget.

@jbaum98  I believe https://github.com/NixOS/nixpkgs/pull/53416#pullrequestreview-306554871 and maybe https://github.com/NixOS/nixpkgs/pull/53416/files#r338540545?
You should re PR and review can begin again.

We also have https://github.com/NixOS/nixpkgs/pull/53416#issuecomment-573788340 who responsive to questions so this can be transplanted into NixOS as easily as possible.
But honestly, a lot of the issues here will be ecosystem ones.

I'm going to close this since @mmai said they won't be working on it anymore, so it won't be merged. The code should still be available though.

@FRidh I looked at the mailman PR, and I'm not quite clear on what structure we want for the Django app.
Also, this project has a pretty complicated architecture:

The project relies on the following components and services to work:

A web application server (Python/Django/Gunicorn)
A PostgreSQL database to store application data
A redis server to store cache and tasks data
A celery worker to run asynchronous tasks (such as music import)
A celery scheduler to run recurrent tasks
A ntp-synced clock to ensure federation is working seamlessly
It seems like we want package the API server separately from the frontend server, and then hook that together with all the other stuff in the NixOS module.


Runnable Examples: 21 total, added 10

Purpose
See #153
Changes
Added following runnable examples:

getBlockFinalizationSummary.ts
getBlockInfo.ts
getBlockPendingUpdates.ts
getBlockSpecialEvents.ts
getBlockTransactionEvents.ts
getBlocks.ts
getBlocksAtHeightAbsolute.ts
getBlocksAtHeightRelative.ts
getBranches.ts
getConsensusStatus.ts

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

I support @soerenbf in expressing that it is almost never OK to say "I'll fix this in a followup PR". Structure PRs in a way that that is not necessary.

All right I addressed the comments and some other issues I stumbled on:

Printed more information wherever I saw it fit
Removed the -h flag, it had inconsistent behavior with --help
Removed all unused const's
Don't do streamToList on stream examples, but mention it in the documentation.
I don't import from common anymore, only nodejs
Documentation comments now have correct style


Questions about how I best procede, ran into  some errors from dep versions

I had a travisci building, and the godep workspace, and was working on an rpmspec.
The plan did work though, making an rpmspec did become possible.
However, after installing the test rpm, i realized we have a problem.
Our code has errors due to upstream changes. How should I procede?
Are we gonna assume dev has the newest upstream deps, and fix the errors?

I close it as we are using the go 1.5 vendoring now. Feel free to reopen for further discussion.


replace Fakt with open source font Inter

Inter -- https://rsms.me/inter/

FontFaceObserver doesn't appear to support loading ttf files, so waiting for fonts to be loaded before rendering wasn't working properly
replace Fakt with open source font Inter
update a few font properties to make it look as close to Fakt as possible
we only need 2 weights for Inter and the files sizes are smaller, so nice performance win

before:

after:

@jesicarson

@ascott Sorry, I know already gave you the go ahead via slack for this change, but I just did a closer review on my monitor here, and I actually think we should wait until you hear back from the Fakt foundry to make this adjustment.
The weights are actually quite different, particularly the title of the case, and the logo. The typography was carefully considered and I don't want to lose the subtle details that the Fakt font offers. For another option, however, it looks like Inter has adjustable weights, could we try to match the original a bit more closely?

homepage mocks with inter:

we decided to stick with Fakt.


How to modify the mirror address

I need to modify the mirror address of this job

hi @clcc2019, please see: https://docs.pixielabs.ai/reference/admin/deploy-options/#custom-image-registry


Question - Prior - Training vs Testing

Hi @karttikeya
I noticed that during the training that a standard normal prior is assumed to compute the KL Loss. However, in the testing/evaluation, I see this hyperparameter for sigma (value set to 1.3) https://github.com/HarshayuGirase/PECNet/blob/4c342597ca4310ef4976412dd8c829ad60a5465a/utils/models.py#L127
Two questions -
a) Why this difference? i.e why not use 1.3 during training as well to compute the KL ?
b) How did you find 1.3?
Regards & thanks
Kapil

Please see Section 3.1 of the paper.

In contrast, in situations where a high number of predictions are to be generated (such as K = 20, a standard
setting on benchmarks) we propose to use σT > 1 with no truncation. We posit that this procedure allows simple adjustment of prediction diversity in favor of overall performance for different K, thereby providing a simple method of
achieving good performance in all settings without requiring any retraining.

Thanks. Missed this part.


WIP: hackish script to compare JSON from Guix and Nix

Motivation for this change
Simple script to see where nixpkgs and guix deviate. This is still very much a WIP and needs a lot of spit and polish (hardcoded paths, etc.)
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@rbvermaa here you go ;-)

The Guix JSON is here: https://www.gnu.org/software/guix/packages/packages.json
The Nix JSON is here: http://nixos.org/nixpkgs/packages.json.gz

I could turn this into a more useful script, but I wanted to get some feedback first to see if it would be useful for people.

Data is now downloaded from the Guix and Nix websites. What would be the right place in Nixpkgs to move this to?

This doesn't seem to work anymore :( I guess because Nix' packages json is gone?

This doesn't seem to work anymore :( I guess because Nix' packages json is gone?

It still seems to be there. Maybe it was a temporary glitch while the json was being regenerated?

I see now that it is just trying to fetch http://nixos.org/nixpkgs/packages.json.gz instead of https://nixos.org/nixpkgs/packages.json.gz. When using HTTPSConnection for nixos the script is working nicely.
Seeing the output, is this something that https://repology.org/ also solves?

I see now that it is just trying to fetch http://nixos.org/nixpkgs/packages.json.gz instead of https://nixos.org/nixpkgs/packages.json.gz. When using HTTPSConnection for nixos the script is working nicely.
Seeing the output, is this something that https://repology.org/ also solves?

This was merely a hackish script to get provide something. Using repology instead makes perfect sense to me.

This seems to be stalled and should probably be closed. @Mic92 @armijnhemel

Happy to close it if someone wants to provide a good alternative based on repology. A the moment I have no time to fix the script.

Does this solve your problem: https://github.com/matthiasbeyer/repolocli (shameless self-promotion).
If not, but it could, feel free to submit changes!

The original goal was just to see how well we are doing being up to date, but also to make it more automatic instead of someone going to the repology website to check. I never got around to implementing that, so if your program could be used to make an alerting service that would be great :-)

I plan to implement something like this, yes. Patches welcome!

In that case I will close this one :-)


Fix issue creation bug

@michaelsena When merged we can create new bugs using a link that looks like this:
https://github.com/uport-project/3box-activity/issues/new?template=bug_report.md


Support for --static option via #67

This pull request supports #67

Hi @abepark01 ! Are you interested in addressing the comments made on this PR?

Yes! Sorry, I've been a bit busy, but would love to see how I can resolve.
I do understand concern about duplicating code, so trying to see what can be done.
Thanks!
Sent from my iPhone

On Jul 3, 2015, at 8:21 PM, Douglas Christopher Wilson<EMAIL_ADDRESS>wrote:
Hi @abepark01 ! Are you interested in addressing the comments made on this PR?
—
Reply to this email directly or view it on GitHub.

I added some comments, and I'm very interested in getting this feature implemented. Do you want me to make a pull request based off this?

Hi guys!
Thanks for the feedback; I have updated the code base on the feedback provided.
Please review and let me know!

Seems like the AppVeyor build is failing due to timeouts; any suggestions?

express(1) (no args) should have installable dependencies:
Error: timeout of 30000ms exceeded. Ensure the done() callback is being called in this test.

Hi guys,
Please let me know if there are any additional issues you would like for me to address? I do believe this is ready to go out.

@abepark01  Sooooo.... any news on this getting merged?

Hi @dougwilson!
Just wanted to see you got a chance to review the fixes I made in response to your feedback.
Thanks!
I would love to see this merged if everything checks out.

Please add tests for the static option to the test suite.

Sorry this got closed from some GitHub voodoo. It doesn't have the option for me to re-open it form some reason! :( Please re-create your pull request.


Not working on a Sunton ESP32-2432S028

I'm using a Sunton ESP32-2432S028 and flashing it via the web interface.
I was able to flash it using the ESP32 DevKitC option, but it is showing a white screen.
Here's the logs:
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1216
ho 0 tail 12 room 4
load:0x40078000,len:10944
load:0x40080400,len:6388
entry 0x400806b4

[INFO]: Loading saved brightness state
[INFO]: Reading latch stated back from memory:
000000000000000000000000000000
[INFO]: SPIFFS initialised.
[INFO]: Free Space: 752247
[INFO]: Loading Wifi Config
[INFO]: WiFi Credentials Loaded
[INFO]: Loading version 0.9.17
[INFO]: All configs loaded
[INFO]: General logos loaded.
[INFO]: Starting BLE
[INFO]: BLE Keyboard version: 1.3
[INFO]: ArduinoJson version: 6.17.3
[INFO]: TFT_eSPI version: 2.3.70
[INFO]: Drawing keypad
[INFO]: Sleep enabled.
[INFO]: Sleep timer = 10 minutes

I then tried ESP TouchDown and got a black screen, looks like it isn't communicating with the panel:
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1216
ho 0 tail 12 room 4
load:0x40078000,len:10944
load:0x40080400,len:6388
entry 0x400806b4

[INFO]: Loading saved brightness state
[INFO]: Reading latch stated back from memory:
000000000000000000000000000000
[WARNING]: Unable to start the capacitive touchscreen.
[INFO]: SPIFFS initialised.
[INFO]: Free Space: 752749
[INFO]: Loading Wifi Config
[INFO]: WiFi Credentials Loaded
[INFO]: Loading version 0.9.17
[INFO]: All configs loaded
[INFO]: General logos loaded.
[INFO]: Starting BLE
[INFO]: BLE Keyboard version: 1.3
[INFO]: ArduinoJson version: 6.17.3
[INFO]: TFT_eSPI version: 2.3.70
[INFO]: Drawing keypad
[INFO]: Sleep enabled.
[INFO]: Sleep timer = 10 minutes

ESP32-S3-DevKitC-1 (Using USB keyboard) and ESP32-S3-DevKitC-1 (Using BLE keyboard) aren't supported for my board.
Please let me know if I can help get this working, I suspect it would involve a code path for connecting to the display specific to this board.

Hi Rebbeca,
There is no support for the ESP32-2432S028. But if you look at here https://github.com/DustinWatts/FreeTouchDeck?tab=readme-ov-file#community-support You can maybe find some support for the ESP32-2432S028.
Good Luck!
P.S. Always feel free to reopen the issue


PMs Not Showing Proper Account Names

Since updating the PMs to use window.coredata, the account names have remained as account numbers instead of updating. This really should be resolved sooner rather than later.

This is not yet 100% solved, but is a heck of a lot closer to being correct. Closing Issue.


Add PPM Documents handler and tests.

Jira ticket for this change
Summary
This creates a handler for PPM Documents and connects it to the service object. The endpoint is /shipments/{shipmentID}/ppm-documents. Tests check that errors are returned when the SO returns errors, and that the happy path returns a 200 and the documents. This approach is largely based on the existing weight ticket handler.
Note that the YAML definition for Moving Expenses now references MovingExpenses.yaml rather than ProGearWeightTickets, which I think had been in error.
Note too that the endpoint is listed under PPM in the Swagger UI, though we're querying via the MTO shipment; I assume that listing it here with give it a better chance of being found, since it's not used for non-PPM shipments.
Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers

Ensure that the endpoint appears at milmovelocal:3000/swagger-ui/ghc.html or the equivalent, under the PPM heading.
Ensure that the payload is as expected.
Run server tests.

These are to be checked by a reviewer.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 4ab484963faf7583d771184d4e7942fca7f343b8

Thanks for the detailed feedback as always, @felipe-lee and @pearl-truss. Each of those changes should be ready in my second commit.

Oh, I also tested with postman and successfully got the documents for a shipment out!
Used shipment bf119998-785a-4357-a3f1-5e71ee5bc757
I minimized two of the sections to be able to show all the doc types.


Can we use it with react native navigation

Thanks for this awesome library. Can we use this library with react-native-navigation?

@nandorojo so this library does not work to animate shared components between react-navigation screens?

There is now a different library called react-navigation-shared-element which supports animations between screens with react navigation.
I wrote a quick tutorial for getting it up and running here.
If you'd rather see the code, I also made an expo snack example.
If you aren't using an Expo managed project (must be SDK 35+), be sure to follow the instructions to link it to your app here.
It works very well with nested components too.
Finally, if you aren't already, I suggest using react-native-screens to help improve performance for react-navigation. Good luck!

@nandorojo Thanks

@nandorojo Note that you cannot use react-native-screens with react-navigation-shared-element and it is unlikely to ever be supported


From Page 2 back to Page 1

Hi,
I've observed that when you reached page two on the blog you cannot come back to page1 by click to previous or the actual number 1. For sure You've detected this problem, do you how it can be fixed?
Thanks

It works just fine, check the demo site. The issue is you probably didn't specify a url:  in your _config.yml when testing locally. If you do that the previous link will appear not to work. The same if you try to click the site name link in the header.
Set it as url: http://localhost:4000 when testing locally or your domain when pushing to production and it will just fine.


[AKS] Add network plugin none support

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

AKS

/azp run

Some of the CIs failed due to lack of the recording file for the newly added test case. I have queued a pipeline to generate one. May download it from here and add this to the test/latest/recordings folder.

Some of the CIs failed due to lack of the recording file for the newly added test case. I have queued a pipeline to generate one. May download it from here and add this to the test/latest/recordings folder.

Thank you!


Allow eo3-validate to validate against a product definition

eo3-validate can now take product yamls along with the dataset yamls, and it will check the list of measurements match the product.
$ eo3-validate products/*.yaml samples/**/*.odc-metadata.yaml
ga_ls5t_ard_3-0-0_092084_2009-12-17_final.odc-metadata: ✓
ga_ls7e_ard_3-0-0_092084_2016-08-23_final.odc-metadata: ✓
ga_ls8c_ard_3-0-0_092084_2016-06-28_final.odc-metadata: ✓

ok: All good
$

(One catch: each product must be listed earlier than its datasets or it wont be found to match against)
There is also a --thorough flag which will also open the data (with rasterio) to verify that dtypes/nodata values/etc match the product.
$ eo3-validate --thorough products/*.yaml samples/**/*.odc-metadata.yaml
ga_ls5t_ard_3-0-0_092084_2009-12-17_final.odc-metadata: ✓
ga_ls7e_ard_3-0-0_092084_2016-08-23_final.odc-metadata: ✓
ga_ls8c_ard_3-0-0_092084_2016-06-28_final.odc-metadata:
- E	different_nodata	oa_combined_terrain_shadow nodata: product -999 != dataset None

failure: 1 error
$

(Output has colours too. But there's still room for improvement in the readability of everything)

This also fixes the nodata mismatch shown in the above examples for ARD contiguity bands.
See also GeoscienceAustralia/digitalearthau#231


[WIP] Integration tests

Replaced by https://github.com/KonduitAI/deeplearning4j/pull/353 to fix commit history


Why is form normalize not a normal config?

Why is it something that has to passed into the form reducer itself? Seems rather complex because it requires modifying overall application initialization to change the normalization behavior of one specific form.
http://erikras.github.io/redux-form/#/api/reducer/normalize

By normalizing in the reducer, it guarantees that the data is normalized no matter where it comes from. Your form might be initialized or even edited from different components or processes dispatching actions.
Does that help/make sense?

Wouldn't one make the same argument about validation? How come validation is defined on a per form level but normalization is defined on global reducer level?

Because validation doesn't need to change the data.
You might not want to validate all of your form in every decorated element. e.g. Wizards

Could we have the option to add the normalize in the config?
While your points are valid, it makes for a weird separation. Now the whole app needs to know about the component that holds that particular form.
I'd rather take the small risk and keep all the things that are dealing with this form in one file.

I have a question: what if I have a single form factory that accepts different form names and needs normalize on them? What's the approach?

I think I've found the answer: formKey

@gabrielhpugliese, formKey is getting removed in the next version in favor of just using different form names. There might be some config-level normalization as well. Thank you for reminding me of this use case.

There might be some config-level normalization as well.

@erikras is there anything new on this? Because this would allow me to actually use normalization. At the current state there is no way I could explain someone why I have to change the central reducer for normalization of a single field in a small form elsewhere..  Everyone in my team I've talked to about normalization in redux-form is asking me the title question. I do understand your reasons to do the normalization in the reducer, but I do not understand why the config is not in the actual config of the form like the validation.

@kromit I'd suggest opening a new issue asking to allow normalize in the config.


Fix Booking Order Validation

Coverage decreased (-0.02%) to 77.17% when pulling e18b5a9311e5a5e461eabf09cfa043512a87d379 on kharissuryandaru:dev into 3bd9f88037002d431a5a07e766c15a5ea3567cbf on danliris:dev.


Private builds not showing up in my Launcher

Solder Repo Hash: 139e88e
Operating System and version: Heroku-16 stack (Ubuntu 16.04 based)
PHP version: 5.6.32
Composer version: 1.6.5
Server type: Virtual
Type of database: PostgreSQL
Type of hosting: Shared
Link to the affected install's public url: http://fierce-reaches-35013.herokuapp.com
For some reason, when I mark a build as private, it doesn't show up in my launcher that's been linked with the Solder installation. The latest public build installs just fine. I wasn't able to find anything in the linked docs about that either.
Screenshot from the build list:

I realize that "shared hosting is not supported", but this hardly feels like a shared hosting issue, considering that the rest of the modpack management works just fine.

have you added your launcher UUID to the list in Configure Solder > Client Management?


added missing exports from models/Common/index & models/Params/index,…

… fixing imports for seasons-client

@andron0909 This PR is available in v0.6.5. Thank you!


CLOUD-48384 sshj 0.15 is released

@biharitomi

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1842/


Error on Uniform01Measure

I tried to use the following command following the Numerical Integration tutorial:
Uniform01Measure(PolyChaos.w_uniform01, (0.0, 1.0), true)
However I get the following error message:
MethodError: no method matching Uniform01Measure(::typeof(w_uniform01), ::Tuple{Float64,Float64}, ::Bool)

Stacktrace:
 [1] top-level scope at In[7]:1
 [2] include_string(::Function, ::Module, ::String, ::String) at .\loading.jl:1091

Hey Alex,
I'm not sure, I can follow. I get the following
julia> using PolyChaos
julia> measure = Uniform01Measure()
Uniform01Measure(PolyChaos.w_uniform01, (0.0, 1.0), true)

This is exactly the output to be expected?
Are you using v0.2.3?

Yes, I am using v0.2.3. I think the error lies in the syntax since calling Uniform01Measure() works without issue. However, to integrate from -1 to 1 I tried using Uniform01Measure(PolyChaos.w_uniform01, (-1.0, 1.0), true) given the form of the output when no argument is given to Uniform01Measure. What would be the correct syntax in this case?

Did you see this issue?
Does using Uniform_11Measure and Uniform_11Orthopoly do the job?

No, I didn't see that issue. That does solve the problem though!


chore(backend-embed): output deno logs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#395
#394
#393  👈
#392
#391
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Fix some documentation warnings

It still throws some warnings for missing terms in glossary. But resolves all of the docstring warnings.

Codecov Report

Merging #1179 (034da99) into main (8fc4005) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   94.83%   94.83%
=======================================
  Files          82       82
  Lines        8089     8089
=======================================
  Hits         7671     7671
  Misses        418      418

Impacted Files
Coverage Δ

dimod/constrained.py
94.00% <ø> (ø)

dimod/discrete/discrete_quadratic_model.py
95.29% <ø> (ø)

dimod/generators/gates.py
93.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc4005...034da99. Read the comment docs.


Chrony init error

Problem/Motivation
Chrony addon not starting.
Home Assistant Core - 2024.9.1
Home Assistant OS - 13.1
Expected behavior
Chrony to start and run as expected.
Actual behavior
It doesn't start.

Steps to reproduce
I just installed Chrony and it doesn't start.
Proposed changes
N/A
Hardware Info

Looks like it pulled the wrong image for whatever reason, you can try an "ha supervisor repair" from SSH, and also check the Supervisor logs.
It isn't an issue with the addon itself.


Updated the wasm installation instruction

Hi @rmliddle, this is how the wasm build worked for me. Does it make sense or am I using npm in the wrong way?

This looks good to me

I'll merge them, thanks!


fix-safe-wc-connection

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
The focus of this PR is to enhance the Wallet Connect functionality by adding support for optional chains and improving storage management.
Detailed summary

Added support for optional chains in Wallet Connect
Improved storage management for connect parameters
Introduced a list of supported chains for safe usage

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#4091  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on  Graphite


Error thrown if namespace is not exactly TabularTables

This is very interesting and I may be missing something, somewhere, but, unless the namespace is TabularTables, an error is thrown:
You must pass Tabular.Table instance as the table attribute

So basically I cannot do this:
Tables={}

if (Meteor.isClient) {
  Template.registerHelper('TabularTables', Tables);
}

{{> tabular table=Tables.myTable}}

Tables.myTable = new Tabular.Table({
  name: 'myTable',
  /* table props */
});

And it works again if I find/replace Tables to TabularTables

Actually, I think this is a quirk of templating/blaze/spacebars (not sure which one exactly). I've run into it before. It's because helpers are called with a different this value, so it sort of overrides the prototype.
The solution is to do something like:
Template.registerHelper('Tables', {
  myTable: Tables.myTable
});

Or if that doesn't work, then:
Template.registerHelper('Tables', {
  myTable: function () {
    return Tables.myTable;
  }
});

Oh, I see. Well better keep it as it is than mess around with quirks ;)
In fact, I was thinking of suggesting you put the namespacing and initialization code right in the package and make it by default mandatory to create tables using the TabularTable namespace.
But, thanks for taking the time and explaining this.

Interesting idea. I created #92 to track it.

That's really strange, I've the same error in the following case:

root
|->common
|->subfolder
------|->client
------|->common
------|->server

If I put the example shown in the readme in the root/subfolder/common it says
You must pass Tabular.Table instance as the table attribute
If I put it in the root/common it works.

That's really strange, I've the same error in the following case:

root
|->common
|->subfolder
------|->client
------|->common
------|->server

If I put the example shown in the readme in the root/subfolder/common it says
You must pass Tabular.Table instance as the table attribute
If I put it in the root/common it works.

@aldeed I've noticed the same behavior as @tetiolaw . Is this normal? Should the we always put the file in /common and by no means in /common/subfolder?
STRANGE!

Have the same issue.

Meteor loads the deepest nested files first, so if it's used in a deeply nested file but defined in a shallow nested file, it's used before it's defined and that won't work. There are various ways to solve. You could put table definitions in /lib, reconfigure the nesting, whatever is necessary so that the code is combined in the correct order.

@aldeed any example on GitHub using Meteor 1.3 to check that please?

I'm using Meteor 1.3 and can't seem to get around this issue either.

I did

var myTable = new Tabular.Table({
	name: "Locations",
	collection: Markers,
	columns: [
		{data: "name", title: "Name"}
	]
});

Template.registerHelper('Tables', {
  myTable: myTable
});

and then changed the template to do
{{> tabular table=Tables.myTable class="table table-striped table-bordered table-condensed"}}
and it worked. Not exactly clear that's what you need to do from reading the readme but it's working so I'm good to go.

I did

var myTable = new Tabular.Table({
	name: "Locations",
	collection: Markers,
	columns: [
		{data: "name", title: "Name"}
	]
});

Template.registerHelper('Tables', {
  myTable: myTable
});

and then changed the template to do
{{> tabular table=Tables.myTable class="table table-striped table-bordered table-condensed"}}
and it worked. Not exactly clear that's what you need to do from reading the readme but I'm good.

I did

var myTable = new Tabular.Table({
	name: "Locations",
	collection: Markers,
	columns: [
		{data: "name", title: "Name"}
	]
});

Template.registerHelper('Tables', {
  myTable: myTable
});

and then changed the template to do
{{> tabular table=Tables.myTable class="table table-striped table-bordered table-condensed"}}
and it worked. Not exactly clear that's what you need to do from reading the readme but I'm good.

Maybe a Pull request to include your example into the README? 👍


⚠ ClamAV has degraded performance

In b3e3bae, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 775889f.


Add no of patient recovered in district wise  display

Is your feature request related to a problem? Please describe.
Currently, it displays the count of a new patient in red at the district level
Describe the solution you'd like
A clear and concise description of what you want to happen.
Adding count of patient recovered at district wise will be a good feature. Currently its display a commutative count at the state level

We do show the recovered in both the table and state views. Can you elaborate where you need the recovered count?

My suggestion was to daily recovered count at the district level similar to the state level in green color. It's there.
Thanks


minor hotswap doc touchups

will rebase after #389 gets sorted!

lololol that’s from a search-replace to capitalize Lua omg
tyty! will merge in tomorrow!!
On Thu, Mar 9, 2023 at 5:36 PM trent @.***> wrote:

@.**** commented on this pull request.
Looks great dan! Just that one typo.
Otherwise good to merge :)
In crow/timeline.md
https://github.com/monome/docs/pull/390#discussion_r1131695405:

-:unless(predicate) takes a "predicate" -- a true or false value -- or a function that produces one. Whenever the predicate evaluates as true, the timeline will stop!
+### :unless
+
+:unless(predicate) takes a "predicate" -- a true or false value -- or a function that produces one. Whenever the predicate evaLuates as true, the timeline will stop!
there's a capital L in evaluates :)
—
Reply to this email directly, view it on GitHub
https://github.com/monome/docs/pull/390#pullrequestreview-1333914965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5L2HGZ6ASSWVBO2NTYYUTW3JLO3ANCNFSM6AAAAAAVVVQUXU
.
You are receiving this because you authored the thread.Message ID:
@.***>