Undefined symbols while building

I am trying to build the hello world application with PHP 8.1.27 on my mac and getting following error.
 = note: Undefined symbols for architecture arm64:
            "_zend_ce_traversable", referenced from:
                ext_php_rs::zend::ce::traversable::h089e7d6026267058 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.09.rcgu.o)
            "_zend_ce_exception", referenced from:
                ext_php_rs::zend::ce::exception::he44752202538fe3f in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.09.rcgu.o)
            "_zend_hash_get_current_key_zval_ex", referenced from:
                ext_php_rs::types::array::Iter::next_zval::hbff174f56c838cae in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.08.rcgu.o)
            "_zend_hash_move_forward_ex", referenced from:
                ext_php_rs::types::array::Iter::next_zval::hbff174f56c838cae in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.08.rcgu.o)
            "_zend_objects_store_del", referenced from:
                _ext_php_rs_zend_object_release in libext_php_rs-669e74370219ea33.rlib(2e40c9e35e9506f4-wrapper.o)
            "__efree", referenced from:
                _ext_php_rs_zend_string_release in libext_php_rs-669e74370219ea33.rlib(2e40c9e35e9506f4-wrapper.o)
            "__emalloc", referenced from:
                _ext_php_rs_zend_string_init in libext_php_rs-669e74370219ea33.rlib(2e40c9e35e9506f4-wrapper.o)
            "_zend_hash_get_current_key_type_ex", referenced from:
                ext_php_rs::types::array::Iter::next_zval::hbff174f56c838cae in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.08.rcgu.o)
            "_zend_hash_get_current_data_ex", referenced from:
                ext_php_rs::types::array::Iter::next_zval::hbff174f56c838cae in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.08.rcgu.o)
            "_gc_possible_root", referenced from:
                _ext_php_rs_zend_object_release in libext_php_rs-669e74370219ea33.rlib(2e40c9e35e9506f4-wrapper.o)
            "___zend_malloc", referenced from:
                _ext_php_rs_zend_string_init in libext_php_rs-669e74370219ea33.rlib(2e40c9e35e9506f4-wrapper.o)
            "_zend_throw_exception_object", referenced from:
                ext_php_rs::exception::throw_object::he7478897a957b4ab in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.07.rcgu.o)
            "_instanceof_function_slow", referenced from:
                ext_php_rs::zend::class::_$LT$impl$u20$ext_php_rs..ffi.._zend_class_entry$GT$::instance_of::h847453b79ebb6b71 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.04.rcgu.o)
            "_zend_throw_exception_ex", referenced from:
                ext_php_rs::exception::throw_with_code::h9b9f9fcb81de2ea4 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.07.rcgu.o)
            "_zend_is_iterable", referenced from:
                ext_php_rs::types::zval::_$LT$impl$u20$ext_php_rs..ffi.._zval_struct$GT$::is_iterable::h019be3c154175dc9 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.04.rcgu.o)
            "_zval_ptr_dtor", referenced from:
                ext_php_rs::types::zval::_$LT$impl$u20$ext_php_rs..ffi.._zval_struct$GT$::change_type::hf2bebe82b351de42 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.04.rcgu.o)
            "_zend_wrong_parameters_count_error", referenced from:
                ext_php_rs::args::ArgParser::parse::h1babdec6352b98c6 in libext_php_rs-669e74370219ea33.rlib(ext_php_rs-669e74370219ea33.ext_php_rs.4306f0632f9e2866-cgu.11.rcgu.o)
          ld: symbol(s) not found for architecture arm64
          clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

I am getting kinda the same error with PHP 8.3.3, seems not related to a specific PHP version. Maybe something changed in newer patch versions?

Have you followed the steps here? https://davidcole1340.github.io/ext-php-rs/getting-started/hello_world.html#cargoconfigtoml

ohh lol. didn't saw that while trying out the hello world 🙈 . Now it it is working. sorry :)
At least when someone else searches for an issue, they will find this 😅


CSV import with tags not setting tags

Versions
NetBox Version: 3.6.7
NetBox DNS Version: 0.21.4
Python Version: 3.12.0
Describe the bug
When importing data using CSV import with a tags field with valid tag data, it is not adding the tags. I can add the same tags manually after the data has been imported.
To Reproduce
Steps to reproduce the behavior:

Go to Record Bulk Import
Add the below data (pasted from Excel in CSV tab separated format) with a valid tags field entry and import it. (Note that I've changed the domain names in the below example to hide my actual domains.)
The same issue happens importing from a comma separated CSV file.
I am able to import other netbox records (IP address) with the same tag field successfully.

zone	name	ttl	type	value	status	tags
uk.domain.biz	test-kp	3600	CNAME	web0.domain.co.uk.	active	dns-static
Expected result
Expect to the see the imported data with the correct tag field added.
Actual result
The record is imported except that the tag field is empty.
Screenshots
If applicable, add screenshots to help explain your problem.

Hi @KPTheProf, thanks for reporting! I can reproduce it - will look into what's causing this problem soon.

This issue is even better than I initially thought ...
Turned out that it wasn't only a problem with records, but also with zones, name servers and views. The origin of this lay in the very beginning of the predecessor netbox-dns (even before I started working on it), and obviously over more than two years nobody (including myself) ever noticed it.

@peteeckel Hi Peter, I can confirm that this issue is now resolved , along with the other issues that I've reported recently.
I would just like to say a big "Thank You" for all the support and hard work that you've given on this great project.
I trust that you and yours will have a wonderful (and relaxing!) Christmas holiday period.  🎄 🎅 😄

Hi @KPTheProf, the best wishes for you and those around you, too!
Maintaining such a project wouldn't be half the fun weren't it for the people using it and contributing to it - and good issues are a contribution that can't be overrated. So thanks to you and all the other contributors, too! I hope to see you all again next year.


Add weighs and move files under Tasks > Access App.

Partially addresses #8398.
Preview: https://deploy-preview-8625--kubernetes-io-master-staging.netlify.com/docs/tasks/access-application-cluster/web-ui-dashboard/
This is one of several PRs that I will submit to get the Tasks left nav in order.

/assign @bradtopol

/cc @kubernetes/sig-docs-pr-reviews

Overall this looks very good. Just had the one inline comment on thoughts on how to best handle the new page that just holds a single link issue.

@bradtopol Let's get this merged, and discuss adding a sentence before the link at a later time. Right now I would just like to get the bare bones in place.

@steveperry-53 Makes sense! Will do!
/approve
/lgtm


Getting Missing boundary in multipart/form-data error in logs while uploading the files

Getting Missing boundary in multipart/form-data error in logs while uploading the files.

The API works fine when i test it via postman.

Any help pls ?

Duplicated by #252

I think this is different than #252, or perhaps I have missed something in both issues that has already been solved.
Here is my setup

And here is the message as captured in chrome

and the payload

And then in my python flask API, it does not detect it as a form or file. Although the data is present, it is not in an easy or standard format to read.

The issue looks to be that the "boundary" is not included in the Content-type, as described here.

Were you able to solve this then ??

@vanimesh, no I did not find a solution.
Thanks @mikhail-vl for re-opening this.

@fgnn We appreciate your questions and working on an article and updating documentation to highlight latest updates.

Hi @asimonok , thank you for working upon the request. Any idea when we could have this fix released ?

@vanimesh PR is merged. You can try the updated version from CI artifacts.

Updated to 3.7.0 and confirmed it works now. Thanks!

@fgnn Thank you for confirming.
Please let us know if there is anything else.

Yess it works fine for me too. Thank you very much


Pattern:  Perform the gap analysis of the code, design and functional specs for the featured link

User Story

As a [user role below]:
DDS BA

I need to:
review the design specs, functional specs and code

so that I can:
be sure that all are aligned and provide a quality experience for the designers and developers that use the ibm.com Library patterns and components to build their web sites.

Additional information

Design specs issue #659
Functional specs issue #683
alpha dev issue #706

Acceptance criteria

[ ] Gap analysis of alpha code and design & functional specs
[ ] If applicable, create and size stories for additional work

@photodow @jeffchew Here is the separate issue for the gap analysis to be performed at the beginning of each sprint that the QA work is scheduled.  Take a look and make any changes you think are needed.  @photodow Do you want an estimate to be included with all of the gap analysis issues I create or would you like to add it later?


Empty maps

A way to clear and initialize maps is needed. You can create a map in a contract, and it will be an empty map by default, but you can't create an empty map afterward:
Error: Line 68, col 39:
  67 |         }
> 68 |         let addresses: map[Int]Address;
                                             ^
  69 |
Expected "="

You can't create a struct and just omit map in the initialization, either.
There should be a way to create an empty map and to clear an existing one.

Added emptyMap() in 0.9.1


[CU-86er3atde] Add tests to cover the entire data converting flow from adapter model to PyMock-Server model

Target

Add tests to cover the entire data converting flow from adapter model to PyMock-Server model
Task ticket: CU-86er3atde
TODO list:

[x] Add tests for the entire data converting flow
[ ] Fix the data converting issue

Effecting Scope

No any breaking changes.

Description

Add unit tests for the entire data converting flow.

Flow: API documentation data model -> adapter model -> PyMock-Server data model

Refactor a little bit level of source code for being more convenience in test

Task linked: CU-86er3atde Add tests to cover the entire data converting flow


feat(effect): add effect to public api

For writing custom renderers it would be nice to be able to follow a similar structure as found in the base renderer:
https://github.com/vuejs/vue-next/blob/5c33776e67a5136aca5100f8ad1b0c968527f8de/packages/runtime-core/src/renderer.ts#L1095-L1097
This would require having the effect function available to use. We can't import it from the reactivity package because of the following snippet from the readme:

This package is inlined into Global & Browser ESM builds of user-facing renderers (e.g. @vue/runtime-dom), but also published as a package that can be used standalone. The standalone build should not be used alongside a pre-bundled build of a user-facing renderer, as they will have different internal storage for reactivity connections. A user-facing renderer should re-export all APIs from this package.

This PR adds this function to the public API.

This is reverted because I misread my own explanation. If you are building a user-facing renderer, you should have both @vue/reactivity and @vue/runtime-core in your dependencies, and be able to import effect from @vue/reactivity.
The sentence

The standalone build should not be used alongside a pre-bundled build of a user-facing renderer, as they will have different internal storage for reactivity connections.

only applies to the situation where:

You are shipping your custom renderer with @vue/reactivity inlined;
A consumer of your custom renderer decides to install @vue/reactivity as a standalone dependency and import effect from it.

Which should be really rare, since end users of custom renderers shouldn't need effect. Or, if you think your users would need it, you can export effect from your custom renderer.

How about when you use both the runtime-dom renderer and a custom renderer in a single application? Then reactivity would be included in the build of runtime-dom.
Correct me if I'm wrong, but I think installing reactivity in the custom renderer would make it so that the internal storage of the runtime-dom and the custom renderer reactivity are different as alluded to in the readme, which could cause problems.
So how would you suggest this can be solved?


Conflicting license requirements

The license requirements listed in this doc ("to access the sign-ins activity report, your tenant must have an Azure AD Premium license associated with it") conflict with the requirements in this doc: https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/concept-sign-ins ("The sign-in activity report is available in all editions of Azure AD")

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2763640f-ae78-a69e-0999-2863240dc2ff
Version Independent ID: dd39081a-afd8-dda2-5a08-7cf54bab1fa4
Content: What are Azure Active Directory reports? - Microsoft Entra
Content Source: articles/active-directory/reports-monitoring/overview-reports.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@MartijnvanPraag
Thanks for your feedback! We will investigate and update as appropriate.


Keycloak OAuth Provider

Add support for the keycloak oauth provider.

We plan on adding support for generic OpenID Connect providers, so we will keep the Keycloak use case in mind when designing that solution to ensure it encompasses how you would need to configure Keycloak.


Replace Sqlite with Room

[x] Replace Sqlite with Room
[ ] Write migration to migrate old db into new

migration: https://medium.com/google-developers/understanding-migrations-with-room-f01e04b07929


The other args are lost if i use  loading="defer"

I've a component who take an argument
php:
    #[LiveProp(writable: true)]     public ? Projet $projet= null;
template :
<twig:Web:MatomoChartProjet  :projet="projet"  />
It's work perfectly. But if use loading="defer" ....      the var $projet is now null....
for information; loading="defer" on my other components with no args....

Hey @AlDaFlux thanks for your reports! I can't reproduce your issue could you create a small reproducer to show your issue! Thanks!

Hi @WebMamba
I make a small project :
2024-DeferCaseSmall.zip
It's ok for you or you need more projects file ?

Detail :

php component :

namespace App\Twig\Components;

use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
use Symfony\UX\LiveComponent\DefaultActionTrait;

#[AsLiveComponent]
final class Arg
{
    use DefaultActionTrait;

    #[LiveProp(writable: true)]
    public ? String $message = "Empty";

}

template component

<div{{ attributes }}  class='col alert {% if  this.message %}{% if  this.message =='Empty' %}alert-warning{% else %}alert-success{% endif %}{% else %}alert-danger{% endif %}'>
    {{ this.message }}
</div>

template

     <div class='row'>
        <twig:Arg message="Arg OK" />
        <twig:Arg message="Arg OK" loading="defer" />
    </div>

Result :

I believe your JS is not executed / compiled ... probably because of the .scss file.
Also, you did not import the namespace for the LiveProp attribute
use Symfony\UX\LiveComponent\Attribute\LiveProp;

I could not install your package.json so i tried your code with AssetMapper instead, and got no problem (defer was working i mean).
Can you check your webpack / assets configuration ?

Damned !  It was just that....  I've forgot the use Liveprop..... thanks for the help !


Nicer way to view Sentences (e.g. while developing candidate extractors)

Might be overkill, but probably worth adding something simple here

Users should be able to "browse" through sentences in a simple but clean fashion- and should be based on the same (simple!) in-cell framework as other labeling / error analysis tasks!

First version of Viewer is in new merged PR!


Question: Setup at the pytest session level

I'd like to do some setup of a database (for instance adding all the tables) once, it seems expensive to do this with every test even using transacted_postgresql_db. Is there a way to do this initial setup of schemas only once? I tried adding postgresql_db to a pytest.fixture with session scope but postgresql_db has function level scope so I was unsure how to proceed.

http://pytest-pgsql.readthedocs.io/en/latest/#customizing-database-fixtures


d3.sliderRight() not display correctly

Track line not covering all the scale when slider created with d3.sliderRight().
Problem solves if created with d3.sliderLeft() as in the provided example.
import * as d3 from 'd3';
import * as d3sl from 'd3-simple-slider';

var sliderVertical = d3sl
      .sliderRight()
      .min(Utilities.zoomOptions.minScale)
      .max(Utilities.zoomOptions.maxScale)
      .default(1)
      .height(slider_height-30)
      .fill('#2E4F4F')
      .tickValues([0.2, 1, 2, 3])

    var gVertical = d3
      .select('#zoom-slider')
      .append('svg')
      .attr('width', slider_width)
      .attr('height', slider_height)
      .append('g')
      .attr('transform', 'translate('+(slider_width/2)+',15)');

    gVertical.call(sliderVertical);

The above code generates this, which is not correct:

import * as d3 from 'd3';
import * as d3sl from 'd3-simple-slider';

var sliderVertical = d3sl
      .sliderLeft()
      .min(Utilities.zoomOptions.minScale)
      .max(Utilities.zoomOptions.maxScale)
      .default(1)
      .height(slider_height-30)
      .tickValues([0.2, 1, 2, 3])

    var gVertical = d3
      .select('#zoom-slider')
      .append('svg')
      .attr('width', slider_width)
      .attr('height', slider_height)
      .append('g')
      .attr('transform', 'translate('+(slider_width/2)+',15)');

    gVertical.call(sliderVertical);

The second block, generates the following, which is correct, but I would love to have numbers on the opposite side:

Could it be a problem related to how I import the library?

Thanks for reporting this. It also affects sliderTop. I have published version 1.5.5 which should fix the issue but do let me know if it does not!

Please re-open if this is still an issue. Closing on the assumption it is now fixed.

Not sure if this is the same issue or not, but I am having a similar problem. I am trying to create and then hide a slider and then bring it back again. I do this by first creating a slider
const slider = d3
    .sliderRight()
    .domain([0,3])
    .step(1)
    .tickFormat(d => {
        return options[Math.round(d)];
    })
    .ticks(3)
    .value(sliderValue)
    .height(100)
    .on('onchange', val => {
       sliderValue = val;
       val = options[Math.round(val)];
       data = reformatData(obj, val);
       root = partition(data);
       chart.select('#licenseCenter').remove();
       update();
    });

Which yields:

Then, later I use this if/else to create/delete the slider
if (o.depth == 0) {
    console.debug('beep');
    sliderBox.selectAll('g').remove();
    sliderBox.call(slider);
} else {
    console.debug('boop');
    sliderBox.selectAll('g').remove();
}

Which yields:

Please let me know if you have any ideas on fixing it. Code for the project lives here.

Thanks for taking the time to report this @aidan-epperly. I'll take a look and get back to you!

@aidan-epperly I've published v1.7.2 which I should address your issue. If you could test it out and let me know I'd be grateful. 👍

@johnwalley Yes, that fixes it! Thank you for the help.


Improvement in difference engine

I propose adding a new method to status.go:

// Difference returns the Current value of a Difference by key
func (t *Status) Difference(key string) (string, bool) {
	diff, ok := t.Differences[key]
	if !ok {
		return "", ok
	}
	return diff.Current(), diff.Changes()
}

Usage would be like this in an Apply() phase to check if file content has been modified:
	if content, ok := status.Difference("content"); ok && f.Type == "file" {
		err = ioutil.WriteFile(f.Destination, content, f.FileMode)

As part of this, the engine and Check() should use the status.go status.AnyChanges() method.

This means that a typical check would just AddDifference() for every field, and AnyChanges()  is used to see if any of the defined differences indicate a change.
Instead of doing this in my Check() method:
	if f.State != actual.State {
		status.AddDifference("state", actual.State, f.State, "")
	}

I'd just do:
status.AddDifference("state", actual.State, f.State, "")

And expect anything else to call AnyChanges() for any change or Difference() to get the value of a specific change.
We'd have to be more aggressive about using Default values to fill in results when Original or Current is not defined.
For example of default, take the example of permissions. The logic would be:

If mode is set in the hcl file,  use that value
if the mode is not set in the hcl file but the file exists, use the existing permissions
if mode is not set & the file doesn't exist, use 0750

👍  The docker container resource already follows the pattern of calling status.AddDifference without comparing first which mostly works today. But, other parts of the system need updating. For example, the printer doesn't check if the diffs have changes so you end up with output like described in https://github.com/asteris-llc/converge/pull/317#issuecomment-249736326.


mainfest || package.json is read as ASCII

Package.json is read by SublimeLinter as ASCII not UTF-8, so the author which contained ö broke the whole plugin.
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 303, in on_activated
    callback.on_activated(v)
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/sublimelinter.py", line 282, in on_activated
    self.check_syntax(view)
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/sublimelinter.py", line 209, in check_syntax
    Linter.assign(view, reset=True)
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/linter.py", line 744, in assign
    linter = linter_class(view, syntax)
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 55, in __init__
    self.read_manifest(path.getmtime(self.manifest_path))
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 225, in read_manifest
    self.cached_manifest_hash = self.hash_manifest()
  File "/Users/einarlove/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 232, in hash_manifest
    return hashlib.sha1(f.read().encode('utf-8')).hexdigest()
  File "./encodings/ascii.py", line 26, in decode
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 347: ordinal not in range(128)

@malandrew, know any reason behind node_linter.py#L232 and why it has the .encode('utf-8).
I believe that file is already being opened in utf-8 encoding by default, so the double encoding attempt is throwing the final error.

I don't recall why, but if I were to guess it is because I'm used to opening stuff up as Buffers from my work with nodejs and add 'utf8' by default when I want text. I would imagine that that can be safely removed, but someone who knows python better than me should make that judgement.

Thanks for bringing this to our attention @einarlove
Your issue worked for me after being removed, so that has been released and should be seen in Package Control in 30 minutes or so. Thanks to @malandrew for providing the history.

or not.

Sorry, carry this on in #209


Type inference for conditions?

I Have a constructor like this,
class Playlyfe
   def initialize(@client_id, @client_secret, @store = nil)
       unless @store
          @store = ->(token : Hash(String, JSON::Type)) { puts "Storing Token" }
       end
   end

  def get_access_token
      token = {} of String => String
      @store.call token
  end
end

in ./playlyfe.cr:83: instantiating 'get_access_token()'

      token = get_access_token()
              ^~~~~~~~~~~~~~~~

in ./playlyfe.cr:67: undefined method 'call' for Nil

    @store.call token
           ^~~~

But I get this compile error shouldn't the compiler know that @store will never be nil.
Anyway I tried this
def initialize(@client_id, @client_secret, @store = ->(token : Hash(String, JSON::Type)) { puts "Storing Token" })
end

But then this gives this this error
in ./playlyfe.cr:67: undefined method 'call' for String

    @store.call token
           ^~~~

And is there an easier way to alias this {} of String => String
I tried alias ReqQuery = Hash of String => String But that doesn't seem to work.

The alias should just be alias ReqQuery = Hash(String, String). For the other question see #477.

Thanks got that alias thing working. But now when I create an empty hash parameter with this alias
def api(method, route, query = {} of ReqQuery)
end

it gives me this error
x error in ./playlyfe.cr:93: expecting token '=>', not ','

  def api(method, route, query = {} of ReqQuery, body = Object.new, raw = false)                                          ^

Is this not possible or is there some other syntax because I have a lot of methods with this and don't want to redefine the types.

Simply do query = ReqQuery.new

Thanks that works.. Need to learn more on crystal.


fix: use golang.org/x/exp/constraints

The constraints builtin has been removed as per this issue, so this PR switches things to use that now that 1.18 is officially released.

No problem, thanks for making this package!


feat: app siloing in new key store

Fixes #5635

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5721  👈
#5717
#5653
#5691
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

l2_block_processing_time_in_ms (64): 10,469 (+16%)
note_successful_decrypting_time_in_ms (32): 586 (+20%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,808
6,796
6,808

l1_rollup_execution_gas
587,289
587,277
587,289

l2_block_processing_time_in_ms
1,418 (+9%)
5,230 (+11%)
:warning: 10,469 (+16%)

note_successful_decrypting_time_in_ms
161 (+2%)
:warning: 586 (+20%)
979 (+3%)

note_trial_decrypting_time_in_ms
65.1 (+6%)
93.5 (-5%)
99.6 (+45%)

l2_block_building_time_in_ms
10,856 (+3%)
39,570 (+5%)
78,186 (+6%)

l2_block_rollup_simulation_time_in_ms
10,668 (+2%)
38,880 (+4%)
76,848 (+5%)

l2_block_public_tx_process_time_in_ms
5,303 (+4%)
21,240 (+7%)
42,476 (+7%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,144 (+9%)
28,884 (+3%)

note_history_successful_decrypting_time_in_ms
1,143 (+1%)
2,268 (+6%)

note_history_trial_decrypting_time_in_ms
34.8 (-7%)
75.8 (+5%)

node_database_size_in_bytes
18,739,280
35,119,184

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
149 (+3%)
44,561
26,424

private-kernel-inner
157 (+1%)
72,188
26,424

private-kernel-ordering
109 (+1%)
51,090
39,297

base-parity
3,904
128
311

root-parity
1,069 (+1%)
1,244
311

base-rollup
13,405 (+1%)
110,820
957

root-rollup
49.5 (+1%)
4,551
821

public-kernel-app-logic
82.5 (-1%)
48,151
40,933

public-kernel-tail
122
53,644
7,385

merge-rollup
10.7 (+4%)
2,760
957

public-kernel-teardown
78.3
48,151
40,933

public-kernel-setup
77.2
48,151
40,933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.9 (+9%)
17.7 (+11%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.638 (+10%)
0.548 (+11%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.7 (+13%)
81.3 (+12%)
260 (+13%)
499 (+11%)
971 (+11%)
1,930 (+11%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.531 (+13%)
0.502 (+12%)
0.475 (+13%)
0.467 (+11%)
0.462 (+12%)
0.463 (+12%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.5 (+12%)
119 (+11%)
373 (+9%)
735 (+11%)
1,446 (+11%)
2,885 (+10%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.537 (+12%)
0.538 (+11%)
0.510 (+11%)
0.507 (+11%)
0.504 (+11%)
0.504 (+11%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.0 (+10%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.587 (+10%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
41,005
528,889

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
905
1,161
1,377

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,136 (+1%)
785 (+3%)
3,410

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
457 (+5%)
304 (+3%)
809 (+7%)
389 (+2%)
1,340 (+9%)
458 (+1%)


Compiler check for the nullability of condition cases

In the below case, the compiler hints that child could be null, however it can't, since it is either B or C.
class A {
  A? parent;
}

class B extends A {}
class C extends A {}

void f(A a) {
  A? child = a;
  while (child is B || child is C) {
    child = child.parent; // The property 'parent' can't be unconditionally accessed because the receiver can be 'null'.
  }
  while (child is B) {
    child = child.parent; // this is fine
  }
  while (child is C) {
    child = child.parent; // this is fine
  }
}

Please change the title to be better understood. Any hint of where this check should be implemented is highly appreciated.

That's also part of flow analysis.
@leafpetersen @stereotype441

Duplicate of https://github.com/dart-lang/language/issues/1377


Fix double application of CTM on text stroke

Fixes #2613

The changes on the images seem pretty drastic. Do we see something comparable from the reference platform? If so, you have my sign off.

The reference platform performs a little differently than we do wrt drawing modes and frames but the scale is the same.

In reply to: 299242879 [](ancestors = 299242879)

@aballway how does ref platform render differently?
sample?

the reference platform will draw each run individually, so with clipping, etc. the regions do not overlap and causes nothing to show up.

In reply to: 299271074 [](ancestors = 299271074)


Remove import-export library

It wasn't being used and added several seconds to inglesp's startup time
locally.

I don't mind removing it, but just to note the use-case: I added it in because people kept asking how many CCGs were signed up to alerts and I wanted to make it self-service.

several seconds

Mildly interested in why.... any idea?

several seconds

Mildly interested in why.... any idea?

It does a load of autodiscovery stuff.  (I investigated a few months ago but can't remember the details.)


[Feature]: Proof of Work value ($5,000 Bounty) from Manifold Labs

🚀 The feature, motivation and pitch
Background
We design incentive algorithms for people to run LLM's. We have absolutely no control of who runs or how these llms are run (to the extent that they pass a verification system, the goal of this bounty). All we know is an ip address for a person running a model. These are called miners. On the other side are validators, each run by some team. Our company purely controls what code these validators run and how miners are scored, although we don't have access to these validators themselves. Validators will query 28 miners (total ~230ish) at a time and score their responses continuously in order to ensure miners are running the right model.
Miners receive two types of requests, organic and challenge requests. These semi-indistinguishable from one another (the goal is for them to be completely indistinguishable), and for these organics to possibly be scored later on. All queries, organic and non, are saved to a database with virtually all their data.
Miners are highly incentivized to cheat and keep their costs down while maximizing their profits. Since LLMs are non-deterministic in nature (even at zero temp) due to rounding errors in floating point math from shared memory access during parallel processing, it is near impossible to simply generate a response and do simple comparisons on miner responses. Any sort of response comparison incentivizes miners to use lighter models that have very similar responses, or quantized models.
Our goal is to have miners run the model they say they are running. Our goal IS NOT to have miners run models that give better answers. We specifically want to verify miners are running the exact model they claim they are running. Validators want to be able to sell their bandwidth to miners to actual customers in an openai format, where customers can specify a model that miners are running. Validators cant sell bandwidth to miners where the customer has no idea what model is going to be hit.
Another issue is that miners are expected to have a middle man in-front of their llm that can potentially be used to weed out queries if the miner knows the query wont be scored. If we only use queries with 0 temp, miners can just block any organic request.
What we want:
A proof of work value (PoWv) per token (int, hexadec, string, hash, float, etc) that can only be generated by having

the weights loaded in memory
the previous [query / response] tokens
is unique for every new token
is not in any way pre-computable
uses sampling params as part of the calculation

Along with a way to verify these PoW number given

all previous tokens
sampling params
model weights

These values should be returned similar to log probs per token
The PoWv should not in any way depend on previous PoWv's due to floating point rounding errors that cause massive drift (and the core reason llms are non-deterministic)
https://github.com/pytorch/pytorch/issues/75240
https://github.com/NVIDIA/cccl/issues/886
We do not expect this to be a feature added to vllm, and would be more than happy to maintain a fork of vllm with this feature.
Alternatives
What we do right now
Validators will generate a question, and then generate an answer (with as low temp as possible) to that question and save it as "ground truth". It will then send the same question to miners, and compare their responses to the ground truth calculating the edit distance between the two to determine if the response is valid, and if so will give a score based on speed of response.
Problems:
This edit distance is not very accurate, giving false positives and false negatives
Edit distance only works on very low temperatures
validators need to generate an entire answer to validate a miners response
The first solution brought to us that we can verify works for our needs will get the bounty. if you think you have a real solution, reach out and we can get a contract written up.
Additional context
Our company is Manifold Labs, and own subnet 4 on bittensor. Feel free to message us on discord, or here in the github issue to continue this conversation.
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Solved in-house. see https://github.com/manifold-inc/vllm-powv
not sure if this would be welcome as a PR into vllm once i get it cleaned up, but would love to hear feedback around it.


different load_balancing_loss with different pipeline_parallel_size

I load the same model trained with megatron + megablocks, and I found the load_balancing_loss is slightly different. When I increase the pipeline_parallel_size, the load_balancing_loss is also increasing. Is it just the problem of precision or there is a potential bug？
For example, when I train a 500M gpt model with 64 experts, I list the lbl and pp_size in the table below.

pp_size
lbl

1
1.005E-01

2
1.007E-01

4
1.013E-01

BTW, is there an example for enabling moe_weight_parallism in megablocks?

Interesting! This could be a number of things. We have a flag to compute the LBL in float32, which might help rule out the numerics. Did you change anything else about your setup? e.g., changes in weight initialization, data order, etc.

BTW, is there an example for enabling moe_weight_parallism in megablocks?

We haven't plumbed support for MoE weight parallelism in our Megatron-LM fork, which it sounds like you're using. There are some users who do use it but I don't believe their frameworks are open-source (yet!).

I think it is caused by precision. Is there a plan for supporting MoE weight parallelism in the Megatron-LM fork?

Great, if it is caused by precision I would recommend trying FP32 and see if that resolves the difference.
Supporting weight parallelism in Megatron-LM is easy-ish, depending on how you'd like to use it. Could you share the sharding configuration that you'd like to use?

I'd like to use weight parallelism in dMoE with SwiGLU layers. I noticed that weight parallelism is not supported with GLU yet.

Ah yes, it is not. Is there an issue with expert model parallelism for your setup?

Yes, the expert model parallelism does not support distributed optimizer, and it uses the data parallel group, which is inconvenient for larger-scale pre-training.

Yes, our Megatron-LM integration is certainly not sufficient for large scale training. There is more proper framework integration in the pipeline, but it won't be available for a bit unfortunately.
If you're interested in using MegaBlocks in some way that isn't currently supported by our Megatron fork I'm happy to answer any questions you have implementing it!


Rotation in the mmark example leads to tile-sized artifacts

Zulip thread: #gpu > Artifacts in rotated mmark example
OS: Fedora Linux 39
CPU/GPU: Intel i5-1240p (integrated Graphics)
API: Vulkan
Also reported in the Zulip thread to occur on different machines (probably macs?), so doesn't seem to be API specific
There are several 16x16 pixel solid blocks, along with several axis-aligned right-angled triangles in unexpected places when the mmark example is rotated.

Screenshot (from the GPU renderer)

To reproduce:
cargo run -p with_winit -- --test-scenes

then press ← once, then Q (or E) a few times to see the artifacts.
edit: Removed  a section on the CPU renderer, as I'm not sure how I reproduced that

This was resolved by #440, which integrated linebender/kurbo#325 and linebender/kurbo#326


Update isCapture.js to avoid null error

Proposed fix for https://github.com/wwayne/react-tooltip/issues/312

There is a build error related to an invalid peer in the dependences...
npm ERR! Linux 4.11.6-041106-generic npm ERR! argv "/home/travis/.nvm/versions/node/v4.8.4/bin/node" "/home/travis/.nvm/versions/node/v4.8.4/bin/npm" "install" npm ERR! node v4.8.4 npm ERR! npm v2.15.11 npm ERR! code EPEERINVALID

closing this since there is a tested fix in react-tooltip-currenttarget that will be merged here soon


Does not exist in type 'CredentialBody | ExternalAccountClientOptions'

Environment details

OS: Windows
Node.js version: 16.14.0
npm version: 8.3.1
@google-cloud/storage version: 7.7.0

Problem
Can't create a client with credentials passed by value as a JavaScript object like the documentation mentioned.
  private readonly STORAGE = new Storage({
    projectId: 'your-project-id',
    credentials: {
      type: 'service_account',
      project_id: 'xxxxxxx',
      private_key_id: 'xxxx',
      private_key:'-----BEGIN PRIVATE KEY-----xxxxxxx\n-----END PRIVATE KEY-----\n',
      client_email: 'xxxx',
      client_id: 'xxx',
      auth_uri: 'https://accounts.google.com/o/oauth2/auth',
      token_uri: 'https://oauth2.googleapis.com/token',
      auth_provider_x509_cert_url: 'https://www.googleapis.com/oauth2/v1/certs',
      client_x509_cert_url: 'xxx',
      }
    });

When I'm following documentation, my IDE tells on private_key_id:
Object literal may only specify known properties, and 'private_key_id' does not exist in type 'CredentialBody | ExternalAccountClientOptions'.ts(2353)
googleauth.d.ts(52, 5): The expected type comes from property 'credentials' which is declared here on type 'StorageOptions'

As well for : private_key_id, auth_uri, token_uri, auth_provider_x509_cert_url, client_x509_cert_url
Expected behavior
Works as described in the documentation.
Thanks

Hi @Shidooo it looks like the docs were never updated with changes to the auth client. I will get them updated. As you noted, those fields no longer exist.

@danielbankhead in looking into this it also appears that the docs for auth might also be out of date: https://github.com/googleapis/google-auth-library-nodejs/blob/7ae4aaea0311de1a3e10f4e86a1ef93ff00656b5/README.md?plain=1#L296 looks like a lot of those fields no longer exist.

Turns out this is a small bug in GoogleAuth's constructor parameters. Currently the GoogleAuthOptions.credentials type parameter is more limited in properties than the GoogleAuth#fromJSON method, although in their code paths are used in the exact same way.
Here's a PR to resolve:

https://github.com/googleapis/google-auth-library-nodejs/pull/1719

However, some fields aren't directly used in the google-auth-library, but are used with glcoud. These can be omitted for now:

private_key_id
auth_uri
token_uri
auth_provider_x509_cert_url
client_x509_cert_url

Fixed upstream


Adding OptionalIndexCompressionFormats and PrimaryKeyPairRef properties to templates and repository creation support

… in virtual

[ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
[ ] All static analysis checks passed.
[ ] This pull request is on the dev branch.
[ ] I used gofmt for formatting the code before submitting the pull request.

Will you also be able to resolve the conflict @shimib?


fix: camera aspect

Problem
Orthographic camera is not getting updates when screen size changes. So the aspect ratio falls out of sync with window size, resulting in squished/stretched images.
Solution

Update orthographic camera aspect when screen size updates
Give user a "manual" flag to keep Tres from updating camera

Context
Manual flag in R3F.

Thanks for this @andretchen0. I like the manual prop, I'm thinking how we could add it to the docs so the users are aware of it.

Maybe we add an entry in https://docs.tresjs.org/advanced/ ?
I'm not sure many users will want it. It's pretty niche. Afaik, no one had complained that Tres was controlling the <TresPerspectiveCamera /> previously.
I just don't want to force people to drop Tres because their use case requires controlling the camera.

Thanks for this @andretchen0. I like the manual prop, I'm thinking how we could add it to the docs so the users are aware of it.

Maybe we add an entry in https://docs.tresjs.org/advanced/ ?
I'm not sure many users will want it. It's pretty niche. Afaik, no one had complained that Tres was controlling the <TresPerspectiveCamera /> previously.
I just don't want to force people to drop Tres because their use case requires controlling the camera.

I would say you already found it valuable so let's not wait for the community to request it or complain about it, if someone asks, we can direct the user to that documentation.
Outside of the scope of this PR, @andretchen0 I'm strongly thinking about adding a cookbook to the docs similar to this https://docs.astro.build/en/recipes/., maybe is a good candidate?

@andretchen0 hey buddy, can you confirm me this would not need to update any docs? If not then we can merge it already

It would potentially break an existing orthographic camera that the user was updating themselves — which was really the only choice, previously.
Maybe that needs documentation?

I hardly think anyone was doing that until now 😂, it's ok then

I think you're right. Lol


Angular compitability with ellipse plugin

Any idea if I can integrate this solution into angular.io (version 2+) application and how? I find a react solution for this here but I need something that works well with ngx-leaflet plugin. would love to hear about possible solutions. maybe you could help me @jdfergason  I am having only typescript issues... I am currently getting the following error - 'ERROR TypeError: leaflet_ellipse__WEBPACK_IMPORTED_MODULE_2__ is not a function'

Note I am not using ngx-leaflet but the same techniques should work:
Import the library like you normally would in typescript.
import 'leaflet-ellipse';

Create a type definition file that extends the one for leaflet.
leaflet-ellipse.d.ts
declare namespace L {
  export interface EllipseOptions extends PathOptions {
    startAngle?: number;
    endAngle?: number;
  }

  namespace ellipse {
    export function ellipse(
      latlng: LatLngExpression,
      radii: number[],
      tilt: number,
      options: EllipseOptions
    );
  }
}

Things should work without any errors just by calling the library normally.

@guidingarrow Thanks for your reply! I will try this out and give an update since it is more elegant from the solution we currently have...


Allow self hosting dev tunnels server

Dev tunnels is a great feature, however it would be great if I was able to host the forwarding service on-site for those who need the additional security. Especially now that vscode server has removed the option to serve-local

Thanks for the suggestion. However, we do not have plans for a self-hosted option.

Thanks for the feature request. I'm closing this based on my previous response - we don't have plans to do this.


Excluded rows being included with bulk action when using "select all"

Package
filament/tables
Package Version
v2.17.36
Laravel Version
v9.52.7
Livewire Version
v2.12.3
PHP Version
PHP 8.1.8
Problem description
When you click the "select all" option after checking some rows, excluded rows are being included and are being affected by the bulk action.

Expected behavior
Excluded rows should never be included in the "select all" function.
Steps to reproduce

Exclude rows using isTableRecordSelectable()
Select a row
Click "select all"
Run a bulk action
Observe the action affected non-selectable rows

Reproduction repository
https://github.com/filamentphp/filament/
Relevant log output
No response

Fixed by #6581.


changeDate event not fired on manual typing

Expected behaviour
The 'changeDate' event is fired when I manually change the date by typing in the input.
Actual behaviour
The 'changeDate' event is not fired.
Datepicker version used
1.7.1
Example code
https://jsfiddle.net/0e9Ltt21/5/
This seems to have been caused by 110b12072cf424480a7fe0cd10ec917458a2e4a8 where the && fromArgs check was added to the comparison of new and old dates.

Any chance of a new release to fix this issue?


HYperDriveStep submitted from my local system onto a cluster on AML workspace hangs forever "getting a storage with a msi token for output upload "

### Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
How can we reproduce the problem in the simplest way?
Have you found a mitigation/solution?

[2022-01-09 16:01:33Z] Current job status is: Completed [2022-01-09 16:01:33Z] Job completed successfully. [2022-01-09 16:01:34Z] getting a storage with a msi token for output upload [2022-01-09 16:01:49Z] Current job status is: Completed [2022-01-09 16:01:49Z] Job completed successfully. [2022-01-09 16:01:50Z] getting a storage with a msi token for output upload [2022-01-09 16:02:06Z] Current job status is: Completed [2022-01-09 16:02:06Z] Job completed successfully. [2022-01-09 16:02:06Z] getting a storage with a msi token for output upload [2022-01-09 16:02:22Z] Current job status is: Completed [2022-01-09 16:02:22Z] Job completed successfully. [2022-01-09 16:02:23Z] getting a storage with a msi token for output upload [2022-01-09 16:02:39Z] Current job status is: Completed [2022-01-09 16:02:39Z] Job completed successfully. [2022-01-09 16:02:40Z] getting a storage with a msi token for output upload [2022-01-09 16:02:55Z] Current job status is: Completed [2022-01-09 16:02:55Z] Job completed successfully. [2022-01-09 16:02:55Z] getting a storage with a msi token for output upload
The "Hyper-parameter tuning step" using "HyperDriveStep" is getting hanged and not creating data ouput--> "Saved_Model" and "Metrics_data.json" file

Hi @priya170807
Please provide additional details.
What is the command you were attempting? Have you attempted other ways of auth?

Please reopen with the requested details


when running visual_7w ,  the code erros with ModuleNotFoundError: No module named 'language_model'

Dear scholar ,
do you know the method to deal with it ?

Well, it should be the problem with the dataset and its corresponding preprocessed model files. Have you downloaded the data_v7w in the Preprocessing section yet?


Authentication type disabled; set to Connection String

Whereas this article instructs the reader to Select the connection type required to connect to your database, in my view of the Link existing database form in the Azure Portal, the Authentication type combo-box is disabled. However, since I have enabled the system-assigned managed identity for the server, I was anticipating an alternative authentication type available based on the SMI rather than the only enabled option, namely the user-name/password combination. As it's likely unclear to uninitiated individuals who encounter this issue how they might resolve it, perhaps this article could be enhanced to anticipate this eventuality and guide the reader to a resolution.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c8902e25-5067-799f-db06-1e587b23ff55
Version Independent ID: 9219df69-9436-0b6c-6b85-c7e06157bd32
Content: Database connection configuration in Azure Static Web Apps
Content Source: articles/static-web-apps/database-configuration.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@CalvinQuark
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


only cache metadata for deployment objects

Signed-off-by: Tommy Hughes<EMAIL_ADDRESS>

@wilybrace ready for review, thanks!


Installing Ory-Editor monorepo postinstall error

ory editor is giving me this problem when doing "npm i" command
npm ERR! undefined postinstall: npm-run-all clean clean:lerna bootstrap build:lib
https://github.com/ory/editor/blob/master/README.md#install-dependencies

Please give a bit more information, for example, which node version are you using, which npm version, what is the error log, and so on.
Otherwise it is impossible to help.


High CPU usage when querying

I updated dbeaver to the latest version this morning. Then, I started having some high CPU usage (60-70%) randomly on executing queries.
I'm running windows 10 N 64 bit

Duplicate of #1189.
Will be fixed in hotfix version (30.01)

I searched issues for 'cpu' to see if somebody else had reported this one, but I searched only for the open issues :D


Introduce option for high volume request tracking

Beyla tracks the full request completion time, this typically means we look to see if the application is responding with more data after the first HTTP response. One example would be a large file download, where the majority of the time is actually serializing the data on the wire. When the client uses keep-alive, we don't necessarily see the connection close event, but we tell by new pushed requests that we should terminate an earlier request.
This approach doesn't work well in when there's high volume of requests, e.g. beyond our current map sizing. The delayed requests will likely be booted out of the map before we have a chance to complete them. The ideal fix is to provide an option to resize the maps to match the volume of requests, but we need to finish the work of the tracer code restructuring for this to happen.
I'm adding an option to force Beyla to complete the request as soon as the response is finished. It will produce less accurate accounting for large file downlaods, but it will avoid no data for high volume of requests. We can also use this option to unblock clients if there are bugs in the delayed request accounting.
This PR is partial, since I accidentally pushed to main. Please review the following commits too:
https://github.com/grafana/beyla/commit/7be9c33fc08aa825f275213d3418f4c7a5b3440d
and
https://github.com/grafana/beyla/commit/bd3e5f4c3b9e30bf10ab0839ed4c344b83cb3c56

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.34%. Comparing base (bd3e5f4) to head (64d185d).

:exclamation:  There is a different number of reports uploaded between BASE (bd3e5f4) and HEAD (64d185d). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (bd3e5f4)
HEAD (64d185d)

oats-test
1
0

k8s-integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1192       +/-   ##
===========================================
- Coverage   78.34%   53.34%   -25.01%
===========================================
  Files         136      136
  Lines       11501    11501
===========================================
- Hits         9011     6135     -2876
- Misses       1932     4965     +3033
+ Partials      558      401      -157

Flag
Coverage Δ

k8s-integration-test
?

oats-test
?

unittests
53.34% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wallet - "Street cannot be left blank" error  when all the address fields are manually entered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Other
Action Performed:
Precondition:

Personal details are not filled.
User has assigned themselves a physical card.

Click on the physical card.
Click Get physical card.
Enter name and phone number > Next.
On address page, manually fill in the address instead of selecting an address from the suggestion dropdown.
Proceed to confirmation page.
Enter magic code.

Expected Result:
User should be able to validate the information since all the address fields are filled.
Actual Result:
"Street cannot be left blank" error shows up when all the address fields are manually filled.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/2d5e70a6-8c5c-4498-bdb6-34918f5e467c
View all open jobs on GitHub

Closing to handle regression here.


Remove Swagger from the Schedule Service

Swagger is bloating the schedule service war 100x

+1

Looks like @agoncal added swagger looking at https://github.com/microprofile/microprofile-conference/commit/13979eab4735a5538399856aa9a6c6190d86e033

Need to add Ivan to this repo so we can assign things to him.


Add ReferenceCountUtil.touch(...) calls before we store messages into…

… a queue to make debugging leaks easier
Motivation:
We should touch our messages when we take over ownership, this allows easier debugging of buffer leaks.
Modifications:
Let's add touch call before enqueue into internal datastructure
Result:
Easier to debug buffer leaks

Why not calling buf.touch directly? It would resolve to a nice invokevirtual instead of interface check and invokeinterface

Why not calling buf.touch directly? It would resolve to a nice invokevirtual instead of interface check and invokeinterface

done

@franz1981 PTAL again

@normanmaurer
I see there are still touch around; remember https://github.com/netty/netty/pull/13782 where I've introduced an inlined concrete class check because is in the hot path there?
Given that the paths where is added now are super-hot, I really suggest to make it obvious to the JIT which method we want to call, doing something similar.
I know it's sad we have to perform something like that, but it depends by how many "receivers" (ie different concrete classes) are observed at the instanceof call-site there.
If there is more than one (UnpooledXY, FileRegion, PooledZW) than the JIT has to perform the infamous interface check.
Moreover, invokeinterface right after, has to perform a O(n) scan itself to find the right interface method offset to call it (this instead happens only if there are more than 2 receivers, instead, AFAIK).

@franz1981

@normanmaurer
I see there are still touch around; remember #13782 where I've introduced an inlined concrete class check because is in the hot path there? Given that the paths where is added now are super-hot, I really suggest to make it obvious to the JIT which method we want to call, doing something similar.
I know it's sad we have to perform something like that, but it depends by how many "receivers" (ie different concrete classes) are observed at the instanceof call-site there. If there is more than one (UnpooledXY, FileRegion, PooledZW) than the JIT has to perform the infamous interface check. Moreover, invokeinterface right after, has to perform a O(n) scan itself to find the right interface method offset to call it (this instead happens only if there are more than 2 receivers, instead, AFAIK): I've refreshed my knowledge on it at https://blogs.oracle.com/javamagazine/post/mastering-the-mechanics-of-java-method-invocation.

Yeah I hink you are right... PTAL again.


Update README.md

Do you know why you're using python3 pip install instead of just pip install?  I suspect that might be specific to your setup and not the most common need but I'm not sure.

Maybe you have Python 2 also installed?  This seems to answer my question: https://stackoverflow.com/questions/56940665/pip-install-vs-python3-m-pip-install


Move Pause button to upper left corner

I think that the current location of the pause button obstructs the view of the bottom of the board too much. I suggest it gets moved up to the top right of the screen, in between the pause/reset button and the information text. Below is a mockup. I do have a fairly large phone screen; I'm not sure if this will cause any undesirable effects on smaller screens.

I think it is a good Idea but I prefer keeping the top text centered, so I will try moving the pause button below the replay button. The table shrinks going up so there shouldn't be any problems. To keep symmetry, the cheat indicator will be moved below the settings button.


The package is not available in a stable-enough version

whenever i run the below command
composer require dchesterton/marketo-rest-api
than found the error " - The package is not available in a stable-enough version according to your minimum-stability setting" please tell me what i do just download your setup and after run the command

Thanks

Please take a look at Composer's minimum-stability option: https://getcomposer.org/doc/04-schema.md#minimum-stability.


Style fixes.

I think we need to delete ShuffledRange in favor of the randomization algorithm used elsewhere in safeside, as this increases cache contention substantially, muddying the waters.
See: https://github.com/google/safeside/blob/main/demos/timing_array.h

AFAICT, the commit does not touch the .cc file. Not sure what the errors on Travis as saying.

While you are at it, why are these functions living in the global namespace?

That's issue #7. I'm still leaving that open as something somebody can do for funsies, but if nobody externally has tried it to get their feet wet, we should just fix it ourselves for sure.

AFAICT, the commit does not touch the .cc file. Not sure what the errors on Travis as saying.

I think it was already broken (starting from when this was checked in), I'll fix that... in this CL, actually, since it's a style fix to cache_size (.cc, but, same thing).
The specific warning from travis is fixed, anyway.


remove 'www*.' prefix when parsing allowed_domains

This fixes this specific use case:

User has entered the parameter: url=https://www.example.com.
This sets allowed_domains=["www.example.com"].
However, the site lists its links as https://example.com/some-page (without the 'www.' prefix)
This causes the OffsiteMiddleware to filter out the links.

Removing any 'www*.' prefixes beforehand allows for a cleaner allowed_domains value.
The reverse should also work where url=https://example.com is used as the arg which sets allowed_domains=["example.com"] and the site uses links like https://www.example.com/some-page. This is because, the allowed_domain would always be a subset of the links in the OffsiteMiddleware (code ref).
Lastly, also moved parsing the allowed_domains from the BaseSpider to the EcommerceSpider since ArticleSpider would have a different way to parse them due to multiple seeds.

Codecov Report

Merging #27 (0600505) into main (015c590) will increase coverage by 0.01%.
 Consider uploading reports for the commit 377381f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   98.37%   98.39%   +0.01%
==========================================
  Files          11       11
  Lines         492      498       +6
==========================================
+ Hits          484      490       +6
  Misses          8        8

Files
Coverage Δ

zyte_spider_templates/spiders/base.py
100.00% <ø> (ø)

zyte_spider_templates/spiders/ecommerce.py
97.91% <100.00%> (+0.18%)
:arrow_up:

Although I wonder if a better approach might be to find the top-level domain part of the URL (with tldextract, which Scrapy uses), and include that plus the subdomain. So, a.b.c.example.com becomes example.com. It’s just a thought, though, and I am not even sure if it would be a change for the better or for the worse.

This might be the case later on as @PyExplorer polishes the Article Spider which has quite lots of varying cases with the domains.


Not to use double interpolation

Is your feature request related to a problem? Please describe.
Avoid using double interpolation in the one string
Your thoughts?
Additional context.
Example
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Love it

Added issue https://github.com/rubocop-hq/rubocop/issues/7480

Made PR to rubocop repo https://github.com/rubocop-hq/rubocop/pull/7714


Problem While Booking Tickets

Stuck After Tatkal Opening Time:

When I log in before the Tatkal booking opens, the system waits as expected. However, even after the Tatkal booking time begins, the process continues to wait and does not proceed further.

Website Unreachable Error:

The script frequently displays a "Website unreachable" error and then stops functioning. I have attempted to book tickets five times in both AC and SL Tatkal categories, but the same issue occurs each time.

I would look deeper into your issue "Website unreachable error". if you can provide me logs displayed in your Console.
You can also describe what exactly needs to do to simulate the error.

New version released, Ticket closed, Try with new version


[Feature Request] Align driver authentication with Kubernetes neo4j authentication

When initiating neo4j from Kubernetes from the official helm chart, it creates secret with NEO4J_AUTH variable.
The value is in the form of: <username>/<password>.
Current implementation forces the username and the password to be separated, and it would be great if we can just use this variable as is.
My current workaround is to create another secret with the username and the password under different values. (maybe someone else have suggestion on simpler workaround as well?)

Another better workaround (thanks to @israelstmz for the idea) is to manipulate the helm chart to create 2 separate values
neo4j-auth.yaml
... Skip few lines without changes

{{- $username := printf "neo4j" | b64enc -}}
{{- $password := include "neo4j.password" . | printf "%v" | b64enc -}}
{{- $auth := include "neo4j.password" . | printf "neo4j/%v" | b64enc -}}
apiVersion: v1
kind: Secret
metadata:
  name: "{{ $secretName }}"
  namespace: "{{ .Release.Namespace }}"
  labels:
    app: "{{ template "neo4j.name" . }}"
    {{- include "neo4j.labels" $.Values.neo4j | indent 4 }}
type: Opaque
data:
  NEO4J_USER_NAME: "{{ $username }}"
  NEO4J_PASSWORD: "{{ $password }}"
  NEO4J_AUTH: "{{ $auth }}"
{{- end -}}
{{- end -}}
{{- end -}}

I'll add a corresponding property and parse that.
The driver itself requires username / password separately.
This library has the joy of sitting in-between teams :)


Update overview.md

Spelling fix

@ciphertxt : Thanks for your contribution! The author, @MarkusVi, has been notified to review your proposed change.


fix(deisctl): update mesos code to use io.Writer

The mesos start/stop/install code needed to change from using channels to io.Writers in order to compile.
Tested manually with make -C deisctl/ build && deisctl install|start|etc mesos.
Refs #4025.

Code LGTM.

code LGTM!

This almost certainly needs to be done on the K8s code, too, @smothiki


🐛 [firebase_analytics] Firebase iOS SDK 7.3.0 re-introduces iOS 9 support, deployment target still 10.0

Bug report
The Firebase iOS SDK 7.3.0 re-introduces iOS 9 support, but the minimum deployment target for firebase_analytics is still 10.0.
Firebase iOS SDK issue: firebase/firebase-ios-sdk#6882
Related PR (for firebase_crashlytics): FirebaseExtended/flutterfire#4626

Leaving this issue open for further investigation.


No route matches [POST] "/auth/:provider"

Not using any of the existing client side integration libraries, how would I redirect users to the provider auth page?
I tried setting up a form posting to the above url, but it seems that there's no such route in rails routes.
I also tried using get request to /auth/:provider which then gets redirected to /omniauth/:provider?resource_class=User, however also getting No route matches [GET] "/omniauth/:provider" error message

It appears that I need to add the following line to omniauth.rb in the initializer to get it to work.
Rails.application.config.middleware.use OmniAuth::Builder do
  OmniAuth.config.allowed_request_methods = [:get]
  ...
end

However in the console now I'm getting a warning message
 You are using GET as an allowed request method for OmniAuth. This may leave
  you open to CSRF attacks. As of v2.0.0, OmniAuth by default allows only POST
  to its own routes. You should review the following resources to guide your
  mitigation:
  https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284
  https://github.com/omniauth/omniauth/issues/960
  https://nvd.nist.gov/vuln/detail/CVE-2015-9284
  https://github.com/omniauth/omniauth/pull/809

Thank you!!! Lifesaver


Support key values with colons

Fixes #1128
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1156 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   62.55%   62.55%
=======================================
  Files         184      184
  Lines       10268    10268
=======================================
  Hits         6423     6423
  Misses       3044     3044
  Partials      801      801

Impacted Files
Coverage Δ

pkg/action/clihelper.go
78.26% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74bec9b...4d68ab4. Read the comment docs.


Security issue: state parameter missing in redirect URL

Hi,
I am a bit concern while using the projects's code for my own microservice because I noticed that the state parameter in redirect URL is missing.
RFC 6749  strongly recommends the presence of the state param because the absence of state param can essentially enable an attacker to perform Cross Site Request Forgery (CSRF) attack [1].
The following code snippet is what I am talking about which is from getAccessToken method in ApiController rest controller class where parameters of the redirect URL such as code, grant_type, redirect_uri, scope are constructed.
// zlt-demo/sso-demo/web-sso/src/main/java/com/sso/demo/controller/ApiController.java

    param.add("code", code);
    param.add("grant_type", "authorization_code");
    param.add("redirect_uri", redirectUri);
    param.add("scope", "app");

I want to know your view on this security concern and how it can affect the security of my application against CSRF attack as mentioned in the RFC 6749 document?
Thanks in advance.
References:
[1]  RFC 6749 The OAuth 2.0 Authorization Framework Cross Site Request Forgery

Thank you for your suggestion! Increasing the state parameter can effectively prevent CSRF attacks.
But my demo is just a simple sso demonstration. The simplest way to demonstrate the entire sso interaction process does not need to consider CSRF attacks.

Thank you for your response. I am closing the issue.


There should be an option to only mine from one subtitle file not both at the same time

I would like the English subtitles to not be mined

@YossefGamerr Please check the Subtitle Track 1, 2, 3, ... settings in the Anki settings.


3.x - Code Quality

This PR creates a cohesive docblock usage, import usage and removes the copyright headers from all files.
Closes #2666 and #2670

Coverage increased (+0.005%) to 97.318% when pulling bb36daec11ca941849d5c0fff1221c503340e075 on l0gicgate:3.x-CodeQuality into 09efe4d2aaebcde6c414c5ada9a8f33c4ce11165 on slimphp:3.x.


Tony.  Do you know that China's "water army" is powerful?

Tony.  Do you know that China's "water army" is powerful?

What is this garbage?


Research: Video chat

What open source or off-the-shelf tech can we integrate for video chat in the town hall meetings?

I believe these are the questions to be considered before we finalize the video chat service:

Do we need different messenger ? or video+ audio+ message
Do we have any user number limitation?
Do we need team collaboration feature / just one on one
Security
Call duration
Launch via browser or download and call
For Web, Android, iOS, macOS, Windows & Linux
Free trial duration
Presenting/  screen sharing needs
Age group using the service
Call encryption

I  have researched a couple of options for free video chat.Here are the options:

Stream:

Include messaging option
Free trial
Reference : https://getstream.io/chat/

Twilio

Include SMS option
Group, p2p option
Reference :https://www.twilio.com/video-api

Jitsi meet

Share your desktop, presentations, and more
Invite users to a conference via a simple, custom URL
Edit documents together using Etherpad
Pick fun meeting URLs for every meeting
Trade messages and emojis while you video conference, with integrated chat.
Reference : https://jitsi.github.io/handbook/docs/intro

Jami

Audio / Video Calls
Screen Sharing
Conferences
Messaging
For Web, Android, iOS, macOS, Windows & Linux
Reference: https://jami.net/

Nextcloud Talk:

Fully on-premise, 100% open source
Easy screen sharing
Webinars & public web meetings
Individual and group calls & chat
Reference :https://nextcloud.com/talk/

Element:

For Web, Android, iOS, macOS, Windows & Linux
Open source
Messaging, voice and video
Reference :https://element.io/features

BigBlueButton:

Virtual classroom
Whiteboard
Fully open source solution for integrating real-time collaboration
Reference :https://bigbluebutton.org/developers/

Luisa has bought a subscription for Zoom. We should look into seeing if Zoom can be integrated into the website.


[MS-396] Re-installation of MS-Data and UI and Check node requirement

Description
This PR will check if user has node installed for their machine when installing moonshot-ui. And also allow for reinstallation of moonshot-data and moonshot-ui
Motivation and Context
Type of Change

How to Test
[Provide clear instructions on how to test and verify the changes introduced by this pull request, including any specific unit tests you have created to demonstrate your changes.]
Checklist
Please check all the boxes that apply to this pull request using "x":

[ ]  I have tested the changes locally and verified that they work as expected.
[ ]  I have added or updated the necessary documentation (README, API docs, etc.).
[ ]  I have added appropriate unit tests or functional tests for the changes made.
[ ]  I have followed the project's coding conventions and style guidelines.
[ ]  I have rebased my branch onto the latest commit of the main branch.
[ ]  I have squashed or reorganized my commits into logical units.
[ ]  I have added any necessary dependencies or packages to the project's build configuration.
[ ]  I have performed a self-review of my own code.
[ ]  I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

Link to Jira: https://imda-dsl.atlassian.net/browse/MS-395?atlOrigin=eyJpIjoiZTcxOTFkMTQ5MTY3NDhiMWJjYjk0OTE5NGNlM2UyODQiLCJwIjoiaiJ9


fix midi out for newly created projects

@democloid ok I think it should be ready for review now.

@democloid this fix causes a bug with the instruments

@democloid this fix causes a bug with the instruments

@RAWJUNGLE you'll have to explain what the bug is, I'm not an mind reader

@democloid  For example, if I create a chain, a phrase, put an instrument and click to select another instrument I get a midi channel at once, that is, I go I00 to I01, a midi channel appears, and if I want to switch back somehow, the tracker freezes, and so on and so forth.
It doesn't matter if it's an old project or a new one, it's useless.

outdated


Car game

I want to make a car game where the speed of the car increases every few seconds and we have to dodge the obstacles with the help of Python.
Please assign this issue to me under SWOC @pinak22dhir

@VardaPanchal005  can you explain in detail?

simple car game where it has to avoid other cars and the speed will increase every specified seconds. on the road.

nice idea, i assigned you this issue, now waiting for another pr of yours, good luck @VardaPanchal005 , happy coding

Thank you

no progress @VardaPanchal005

I made the game but I'm facing error in cloning repository

I tried some stackoverflow solutions but that didn't help either

try  to make another repository @VardaPanchal005

are you suggesting that i try to clone in another repo ?


Make release depend on linting

Feature request
We want to release only when linting succeeds
Motivation
No response

Releases only trigger when PRs are merged to main. To tackle this, we can enforce that for successful PR merges it needs to successfully pass the linter github action, in the repo settings itself

From https://github.com/OpenAdaptAI/OpenAdapt/pull/289#issuecomment-1644531948:
Once this merged we can resolve https://github.com/OpenAdaptAI/OpenAdapt/issues/335 by enforcing PRs to pass the new lint/test github action before they can be merged. This will ensure it will not fail after its merged to main. I currently do not have permission to do this on my end but the instructions are below.

We can do this by clicking on Settings and then clicking on branches

After clicking on 'edit' for main branch

Navigate to this section and check the following checkboxes. In the search bar we would search for Python CI and add it as a status check. Then Save.

@Mustaballer thank you for the instructions!
Unfortunately I'm not able to find Python CI:

Any suggestions? What do you need in order to be able to do this on your end?

I need 'write permissions' to add the status check.

Anyone with write permissions to a repository can set the state for any status check in the repository

@abrichr can you try searching for 'run-ci'?

@Mustaballer you have write permissions

Here is what I see:

@abrichr It should be run-ci (macos-latest)


Error resequencing class members with XData blocks

Same deal as #51 but with XData blocks instead of foreign keys.

This also affected Projection Definitions


Use new nitric release and clean up build output

https://github.com/nitrictech/pro-backend/issues/421

Codecov Report
Base: 27.08% // Head: 27.08% // No change to project coverage :thumbsup:

Coverage data is based on head (d0150dd) compared to base (ed7df5f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #375   +/-   ##
========================================
  Coverage    27.08%   27.08%
========================================
  Files           52       52
  Lines         4560     4560
========================================
  Hits          1235     1235
  Misses        3208     3208
  Partials       117      117

Flag
Coverage Δ

unittests
27.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/output/verbose.go
0.00% <0.00%> (ø)

pkg/tasklet/tasklet.go
42.50% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cannot read properties of undefined (reading 'close')

Bug Report

🔎 Search Terms

watcher
crash

🕗 Version & Regression Information
4.8.0-dev.20220711
Seems like a regression as I do not remember seeing this in TS 4.7
Details
When closing editors in VS Code, recently I've been seeing the following crash:
  ERR <semantic> TypeScript Server Error (4.8.0-dev.20220711)
Cannot read properties of undefined (reading 'close')
TypeError: Cannot read properties of undefined (reading 'close')
    at Object.close (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:6834:29)
    at Object.close (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:116840:29)
    at closeFileWatcherOf (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:116891:32)
    at Map.forEach (<anonymous>)
    at Object.clearMap (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:19668:13)
    at Object.clear (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:122531:16)
    at ConfiguredProject.Project.close (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:171446:38)
    at ConfiguredProject.close (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172930:40)
    at ProjectService.removeProject (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:173991:25)
    at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:175861:86
    at Map.forEach (<anonymous>)
    at ProjectService.removeOrphanConfiguredProjects (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:175861:44)
    at ProjectService.cleanupAfterOpeningFile (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:175805:22)
    at ProjectService.applyChangesInOpenFiles (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:176009:26)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:177372:46)
    at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:179564:96
    at IpcIOSession.Session.executeWithRequestId (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:179555:28)
    at IpcIOSession.Session.executeCommand (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:179564:41)
    at IpcIOSession.Session.onMessage (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:179592:35)
    at process.<anonymous> (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:183758:31)
    at process.emit (node:events:390:28)
    at emit (node:internal/child_process:917:12)
    at processTicksAndRejections (node:internal/process/task_queues:84:21): Error: <semantic> TypeScript Server Error (4.8.0-dev.20220711)

I can't repo this reliably but here's the complete log of a session the crashed (it's quite large)
tsserver.log.zip

First error in logs is possibly https://github.com/microsoft/TypeScript/issues/49310

Based on the trace (closeFileWatcherOf followed by two close calls), I think this is caused by a double-close of this watcher: https://github.com/microsoft/TypeScript/blob/7b764164ede080afff02ec731dfea72b3f4f73f3/src/compiler/sys.ts#L1098
It's not clear to me from the API of FileWatcher whether or not a double close is intended to be to be legal (I'll add some asserts to various implementations to check), but I think making this one not crash is straightforward.

I can't say I know for sure if the API should allow double closes or not; there are clearly some refcounted file watchers which just start returning early once their references are up. There are also some other cases (different from this issue's trace) which could potentially crash if some invariant were violated, but we a aren't seeing those. So I'm inclined to go the safer route that doesn't do a undefined!.


Mark bswap32 instrinsic with interpreter primitive annotation

Unlike bswap16 (and most other intrinsics), bswap32 wasn't marked with the Primitive annotation when in interpreted mode, despite an instruction seemingly existing for it
Discovered while trying to run the compiler in interpreted mode

I added it to the milestone, and we can add the spec later after #11578 is merged


Feature/improve usability

What is the purpose of this pull request?
Simplify usage of method Logger.Log
What issues are related to this pull request?

[x] close #62 Create log extension

@Caldas done


Update getting-started.md

Another site for your documentation (still under construction though)

Sorry, we only list applications that we maintain ourselves here.


pwm_input modifications

** Reset feature added for pwm_input driver. **
GPIO_GPIO5_OUTPUT (AUX 6 signal pin) is currently used as reset pin.
Reset is happening if pwm_input don't get any data for some time, to prevent reset-spamming while lidar is not connected ROMFS should toogle pwm_input driver on parameter. (not implemented in this fork)
** Publication to range_finder topic added **
range_finder topic is used by several sensors (pwm_input, i2c lidar interface and range_finder currently) and ROMFS should have cases to enable ony one of them.

Thanks! Doing a full review now.

@Zefz This brings the Lidar-Lite to life. I need to think a moment about how to layer this architecturally.

@LorenzMeier I was planning to get all rangefinders and altimeters data into DISTANCE_SENSOR message. Are there other plans (like keep using range_finder topic) or can I proceed with this? Mavros already is capable of sub and pub into DISTANCE_SENSOR msg.

LidarLite still needs working PWM drivers (#1949).

@arbulgazar it would be awesome if you could do your changes against https://github.com/PX4/Firmware/pull/2200 :+1:

I can't get this to run yet, I keep getting:
nsh> pwm_input start
[pwm_input] advertising 536948912
nsh> [pwm_input] Lidar is down, reseting
[pwm_input] Lidar is down, reseting
[pwm_input] Lidar is down, reseting
...

Pin 5 and 6 are connected as shown here http://copter.ardupilot.com/wiki/common-optional-hardware/common-rangefinder-landingpage/common-rangefinder-lidarlite/#connecting_to_pixhawk_via_pwm, the rail is powered with 5v, and I'm using a 300 Ohm pull-down.

Try one kilo ohm instead

Actually I think it's rather software related. Did you put FMU in PWM mode and / or disabled the driver? I need to check if there are missing dependencies / startup order things.

Already re-soldering :). I didn't touch the fmu command...

I switched to 1k Ohm and disabled the fmu command, still nothing!
Does the Lidar-lite have any indication that it's running? Any idea how to debug this?

@bansiesta are you using this https://github.com/PX4/Firmware/pull/1949?

@TSC21: I'm currently trying pwm_input. Is this not needed for ll40ls start pwm?

As @Zefz said:

LidarLite still needs working PWM drivers (#1949).

Sorry, don't get it. Tell me what I need to run in what order and what you suspect to work.

@bansiesta I can't really tell. From what I know, I2C drivers are working for LidarLite but have problems related to bus hold, which is a problem related to LidarLite only. That's why a PWM driver is needed. But, from what I can see, there's no current implementation for using PWM with LidarLite in the firmware, and that's what @Zefz was implementing, but it didn't finished it. So, I suspect @Zefz code must be done first before getting this to work.

@TSC21 Understood thanks. I've already continued where @Zefz left off and I think I have an idea what is going on there. However, for the PWM part to work, this pwm_input needs to work but doesn't for me. The interrupt seems never triggered.

Aha, seems to work now, a pwm_input test was necessary.

Good catch :D BTW, check https://github.com/PX4/Firmware/commit/43668cc8c8f6413861277aeab3fa026564b5c4fa. Big change on structure, as range_finder topic is totally replaced by distance_sensor.

@TSC21: thanks for the heads-up. I'll try to merge that in later.

I wasn't modifying start-up scripts, was not sure you want lidar starting with fmu, but probably should have wrote this in comment:
pwm_input start full required in order to both initialize and start timer. pwm_input start will lead only to timer initialization. This however is listed in help message you get on pwm_input.

I will do changes with respect to #2200 after week or so. Thesis is demanding time now, can't push it back.

@arbulgazar: Thanks for your work, I based my work on it and went from there. It's merged now.
Btw:
I removed the pwm_input start full argument because the read is now triggered from the ll40ls driver. Also the pwm_input only publishes to the pwm_input topic and the ll40ls driver then converts this to a distance, etc..
This should leave the pwm_input driver as a generic interface that can be extended for other use cases.


Simulating shock/boundary layer interaction

Hi,
I’m interested in exploring this code for simulating compressible wall-bounded turbulence, especially for spatially-developing turbulent boundary layers (TBL) on a flat plate and shock/boundary layer interactions (SBLI).
From a quick look at the code, it seems like it doesn’t currently support generating inflow turbulence or oblique impinging shocks. I was wondering if your team has any plans to add these functionalities?
Since the package already has built-in machine learning, it would be interesting to explore implementing some deep-learning-based turbulence inflow generation. And the strong shock system in SBLI could be a good testbed for your latest development of ML-based ILES, shock capturing, ... .

Hi, thanks for your comment.

Yes, we are planning to integrate support for generating inflow turbulence.
Oblique impinging shocks can already be generated either by modeling the immersed solid body via a level-set field or by specifying the Rankine-Hugoniot conditions via Dirichlet boundary conditions.

We are very open to the idea to integrate ML-based turbulence inflow conditions!


--silent flag for testing

The interpreter should have a --silent or --quiet command line option to suppress any audio output. Useful if you only want to validate an input file. Potentially also useful for testing as well.

Thinking more about it, this is probably not needed.
However, an option to produce a *.wav file (or some other format) instead of playing sound would definitely make sense. (And also allow for easy testing.)


Gene info cards contain styled text from selected gene, external link to disease info

User instructions:

Search genes:

SAMD11, ITGAV, DDR2, etc...

Click on chromosome with gene (highlighted one)
Click on band with gene (highlighted one)
When card pops up, click "more" for link to NCBI post on disease information.

Please review these changes to confirm demo-ability, @suneettipirneni & @APherwani.

Actually, @APherwani can you review this since we are going to work on the AlphaFold renders in these cards?

LGTM


Keyboard  Remap Shortcut don't work after an hu

Microsoft PowerToys version
0.66.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
The Keyboard remap work well, until pass some hours (or minutes) and the Windows Keyboard shortcuts become the map again... Don't matter if i unable/re-enable the Keyboard manager.
✔ Expected Behavior
Keyboard manager remap/replace windows keyboard shortcuts
❌ Actual Behavior
Do absolute nothing, just use the windows shortcuts like PowerToys doesn't exists
Other Software
No response

Some of these seem to happen on getting "virtual" keys stuck, which then makes it so the combination of keys being pressed not being exactly what's expected. I imagine this being /dup #17344


Error in IdentityAttachKLSparseReg

I am getting the following error when using the IdentityAttachKLSparseReg Symbol. Here's my code :
import mxnet as mx
data = mx.symbol.Variable(“data”)
data_nd = mx.nd.array([1,1,1,1])
out = mx.symbol.IdentityAttachKLSparseReg(data)
exe = out.bind(mx.cpu(), {‘data’ : data_nd })
Traceback (most recent call last):
File “”, line 1, in
File “/usr/local/lib/python2.7/dist-packages/mxnet/symbol.py”, line 1607, in bind
‘aux_states’, aux_states, self.list_auxiliary_states(), False)
File “/usr/local/lib/python2.7/dist-packages/mxnet/symbol.py”, line 1242, in _get_ndarray_inputs
raise ValueError(‘Length of %s does not match the number of arguments’ % arg_key)
ValueError: Length of aux_states does not match the number of arguments
Am specifying only one Input as per the description. But still it throws out error stating the number of arguments are less ( 1 vs 2 ). The scenario is the same in NDArray.

@mxnet-label-bot add [Symbol]


Restore function is incorrect

The restore function performs several actions:

resets the PoE chip
(supposedly) re-initializes the PoE chip according to the driver init defaults

What this command should do is

(optionally) reset the PoE chip
apply driver init defaults.
load a persistent config of my choice

When I run the restore command, it immediately complains that it cannot load the persistent config. This implies that persistent config is either not applied, or not applied consistently.
Given that poed automatically overwrites the persistent config at regular intervals, this effectively means that "restore" leaves the PoE system in an unknown/inconsistent state

Same issues: https://github.com/dentproject/poed/issues/13 https://github.com/dentproject/poed/issues/14
Relates issue: https://github.com/dentproject/poed/issues/10
We will implement poecli cfg sub command for manipulate the config file.
EX:
Load persistent config(P1-enable):
poecli cfg --load
poecli show -p 1
1     Port On (0x01)     enable     low     IEEE802.3AF/AT    4       400 (mW)   30000 (mW)   54.2 (V)    9 (mA)
Save runtime to persistent config(P1-disabled by poecli set):
poecli set -p 1 -e 0
poecli cfg --save
Load an test config:
poecli cfg --load --config /root/test_config.json
Save runtime config [ /run/poe_runtime_cfg.json ] to some place:
poecli cfg --save --config /root/good_config.json
Restore factory:

poecli restore (Will be platform state after initialize done)
'poecli cfg --load` (Will load persistent config to chip)

Check Branch tag:
https://github.com/leonchiang/poed/releases/tag/issue_fix_0001