Defining a variable T inside a test with DOCTEST_CONFIG_DISABLE defined does not compile

Description
Defining a variable named T inside a TEST_CASE with DOCTEST_CONFIG_DISABLE defined gives the following errors
main.cpp: In function ‘void _DOCTEST_ANON_FUNC_1()’:
main.cpp:7:12: error: declaration of ‘double T’ shadows template parameter
     double T = 273.15; // "declaration of 'double T' shadows template parameter"
            ^
In file included from main.cpp:3:0:
doctest.h:2729:15: note: template parameter ‘T’ declared here
     template <typename T>                                                                          \
               ^
doctest.h:2734:5: note: in expansion of macro ‘DOCTEST_CREATE_AND_REGISTER_FUNCTION’
     DOCTEST_CREATE_AND_REGISTER_FUNCTION(DOCTEST_ANONYMOUS(_DOCTEST_ANON_FUNC_), name)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
doctest.h:2968:19: note: in expansion of macro ‘DOCTEST_TEST_CASE’
 #define TEST_CASE DOCTEST_TEST_CASE
                   ^~~~~~~~~~~~~~~~~
main.cpp:5:1: note: in expansion of macro ‘TEST_CASE’
 TEST_CASE("test")
 ^~~~~~~~~

It seems like the section around line 2734 is not disabled even if DOCTEST_CONFIG_DISABLE is defined. Perhaps that's part of the problem?
Steps to reproduce
#define DOCTEST_CONFIG_DISABLE
#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
#include "doctest.h"

TEST_CASE("test")
{
    double T = 273.15; // "declaration of 'double T' shadows template parameter"
}

Compile using g++ -Wall main.cpp -o main using g++ version 6.3.0.
Extra information

doctest version: v1.2.2
Operating System: Debian 9 Stretch
Compiler+version: g++ 6.3.0

hmmm I'll have to fix this - when DOCTEST_CONFIG_DISABLE is used all test cases are turned into uninstantiated templates with T as the typename parameter - I'll change it to _DOCTEST_DISABLED_TEST_CASE_PARAMETER or something like that. Thanks for reporting!

weird - the smart commit didn't close the issue when it got pushed to master even though it references the issue - closing manually.


[Suggestion] Press enter to send the emote instantly

First of all, very nice plugin. But it's a bit counter intuitive. Like having to click on the emote before pressing enter.
https://i.imgur.com/wzMNlYe.gif - instantly pressing enter
https://i.imgur.com/Fswasi5.gif - clicking the emote first before pressing enter
https://i.imgur.com/tmnZrg3.gif - normal discord emote pressing enter instantly

Oh yeah, it would be nice if you can turn the case sensitive off in the settings.
Thanks!

Note that you can use tab to autocomplete the emotes as well

Done in 1.9.6


fix: remove ambient, install all typings postinstall.

This has caused me some problems when I npm install after killing node_modules. There's no reason to pass this flag in.


Error when running meltano config dbt set target ...

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3025
Originally created by @Greta991 on 2021-10-27 10:51:20

I tried to change target dbt with command:
meltano config dbt set target bigquery
But it returns:
[ERROR] The discovery.yml manifest received from https://www.meltano.com/discovery.yml could not be parsed. [CRITICAL] Could not update meltano.yml: dump_all() got an unexpected keyword argument 'sort_keys'
What's it mean?
Thank you.

View 6 previous comments from the original issue on GitLab


Surface consensus mechanism configuration to CLI status

This breaks the formatting on coda client status slightly, but it's still easily human readable. As an example, the new configuration entry prints like:
Consensus Configuration:
    proposal_interval = 5000

This is for posig, for postake there are multiple entries

Updated with proper json support. This is what the output looks like now with postake, json and non json:
[nathan@muse coda]$ ./_build/default/src/app/cli/src/coda.exe client status -json
{
  "num_accounts": 18,
  "block_count": 1,
  "uptime_secs": 9,
  "ledger_merkle_root":
    "169105839888979101823705255245535441612404953868911697383122620482216080259735771743313147",
  "staged_ledger_hash":
    "((ledger_hash<PHONE_NUMBER>88979101823705255245535441612404953868911697383122620482216080259735771743313147)(aux_hash\"\\156\\141\\018\\209\\244\\144\\180^e\\153\\161\\220_\\181d\\165]~\\005\\237\\149eSk-&\\199*=\\188\\25250\"))",
  "state_hash":
    "347559749758477489674946532477091080866880273497385806155571778401862773851360850661225024",
  "commit_id": null,
  "conf_dir": "/home/nathan/.coda-config",
  "peers": [],
  "user_commands_sent": 0,
  "run_snark_worker": false,
  "propose_pubkey": null,
  "histograms": null,
  "consensus_mechanism": "proof_of_stake",
  "consensus_configuration": {
    "delta": 3,
    "k": 24,
    "c": 8,
    "c_times_k": 192,
    "slots_per_epoch": 576,
    "slot_duration": 2000,
    "epoch_duration": 1152000,
    "acceptable_network_delay": 6000
  }
}
[nathan@muse coda]$ ./_build/default/src/app/cli/src/coda.exe client status
Coda Daemon Status
-----------------------------------
Number of Accounts:       18
Block Count:              1
Uptime:                   12s
Ledger Merkle Root:<PHONE_NUMBER>88979101823705255245535441612404953868911697383122620482216080259735771743313147
Staged-ledger hash:       ((ledger_hash<PHONE_NUMBER>88979101823705255245535441612404953868911697383122620482216080259735771743313147)(aux_hash"\156\141\018\209\244\144\180^e\153\161\220_\181d\165]~\005\237\149eSk-&\199*=\188\25250"))
State Hash:<PHONE_NUMBER>58477489674946532477091080866880273497385806155571778401862773851360850661225024
Configuration Dir:        /home/nathan/.coda-config
Peers:                    Total: 0 ()
User_commands Sent:       0
Snark Worker Running:     false
Proposer Running:         false
Consensus Mechanism:      proof_of_stake
Consensus Configuration:
    delta = 3
    k = 24
    c = 8
    c_times_k = 192
    slots_per_epoch = 576
    slot_duration = 2000
    epoch_duration = 1152000
    acceptable_network_delay = 6000


Please add plabayo.tech

Thanks for creating this curated list of minimal websites!
My (side-project) company's website is less than 10kb: https://www.plabayo.tech/
I keep it very minimalistic and without any JS or anything.

Going to close it for now as according to the rules it is not yet noteworthy, given we haven't received much publicity yet. Will close it and re-open only once I satisfy that rule as well. Thank you anyway.


Database file

No database files or structure

please upload the example database

database file inside "save_path" guys. export the "save_path" and you will see save_path.out

can you send me data in sql form please


ALIEN_EXPORT is sometimes used ONLY to satisfy unit tests

Unit tests must access and stress internal components of Alien. Currently, to access these objects, they have to be exported, so they can be called by the consumer test program.
This leads to exposing a lot of internal objects to end-user.
We should rethink the way we make these tests, to integrate them deeper in Alien and avoid leaking private API.

One possible technical solution is to describe Alien as a CMake object library and then consume it twice: for producing a real shared library and for making the unit tests executable. This way the test executable will be in the same "module" as the rest of Alien.


Tests e2e

Tests e2e for next pages:
Accordion
Alert
Buttons
Carousel
Collapse
Modals

Current coverage is 85.62% (diff: 100%)

Merging #1121 into development will not change coverage

@@           development      #1121   diff @@
=============================================
  Files               35         35
  Lines             1280       1280
  Methods            228        228
  Messages             0          0
  Branches           213        213
=============================================
  Hits              1096       1096
  Misses             184        184
  Partials             0          0

Powered by Codecov. Last update ec6ccc3...bdabc69


Bypass the unable decompressed files for atool

OLCS-384
Fixes OLCS-384

According to the supported archives, I set the whitelist for atool.

LGTM

LGTM


Time varying intercept

This PR adds a time varying coefficient for the intercept. It's near-identical to #598, except it does not add support for time varying media contributions (this, we will add later).
Description
The API is now:
mmm = DelayedSaturatedMMM(
    date_column=my_date_column_name,
    channel_columns=my_media_column_names,
    time_varying_intercept=True,            # <-- This is new
)

Moreover, the model_config can now contain arguments for the time varying prior:
mmm = DelayedSaturatedMMM(
    ...
    model_config={
        ...,
        "tvp_kwargs": {
            "m": 200,
            "L": 100,  # If left to None, is estimated from the data (supporting 1 year of future OOS prediction)
            "eta_lam": 1,
            "ls_mu": 52,  # If left to None, is estimated from the data (supporting 1 year of future OOS prediction)
            "ls_sigma": 10,
            "cov_func": myCovFunc,  # If left to None, default Matern52 is used (good default).
        },
    }
)

Changes are also made to the plotting and data setter functions, to support out of sample predictions.
Checklist

[X] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[X] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

[X] MMM
[ ] CLV

Type of change

[X] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--628.org.readthedocs.build/en/628/

@ulfaslak can you please the notebook name in https://raw.githubusercontent.com/pymc-labs/pymc-marketing/main/docs/source/notebooks/index.md so that it gets passed tot he docs 🙏

@ulfaslak you might also wanna update the branch as we solved an issue in https://github.com/pymc-labs/pymc-marketing/pull/633 🙏

View / edit / reply to this conversation on ReviewNB
juanitorduz commented on 2024-04-16T10:42:12Z ----------------------------------------------------------------
Line #7.        sampler_config={"chains": 2, "draws": 10, "tune": 10, "nuts_sampler": "numpyro"},
Just 10 draws?

ya that was for debugging. I'm revising this whole notebook and making it nice now :). Thanks for all the comments!

Alright, final tests added to cover all new cases. @wd60622 @juanitorduz curious to hear your thoughts on these, maybe I'm breaking some implicit conventions for how we structure tests, please let me know and I will correct.

Ahh there are merge conflicts. Will resolve, but tests can still be reviewed

Oh, also forgot to add @wd60622 s cool idea for wrapping TVP params in a class. Will add ASAP, but after (and if tests are fine in your opinions) we are probably good to merge

Just out of curiosity, have we tried to run the original notebook but now doing the intercept variable? I say this to know if we have seen the behaviour of the model in general with all parameters in place, controls, seasonality, channels, etc. 💡

Lots of comments, sorry. This is gonna be epic 🚀 Haven't touched the notebooks much but the plots are looking sweet

Really nice comments man, thanks a lot. Addressed them all. Will add some more tests, give it a good stare and then it should be close to the finish line.

pre-commit.ci autofix

@juanitorduz @wd60622 got the ✅ now.
Updates are:

Addressed all of @wd60622 s last comments. Good stuff 🙌.
I updated the deterministic returned by time_varying_prior to be centered on one. This has some nice properties (see notebook).
I added tests for new logic that wasn't covered.
I updated the notebook to include an example where time varying intercept is a trend (not a sinus).

@ulfaslak This looks fantastic! The code itself is ✅ IMO (any comments @wd60622 ?). On the other hand, I think the notebook needs a bit more of the storyline. Consider a user who has never seen a time-varying intercept model.  The main points a reader should get from the notebook (IMO) are:

What is a TV intercept?
Why is it useful?
How to use it in PyMC-Marketing?
-What are the benefits? (thinking about the MMM objective of better inference)
When to use it?
When it might not work?

WDYT?
PS. Also I added some minor comments about the plots XD

+1

View entire conversation on ReviewNB

The main points a reader should get from the notebook (IMO) are:

What is a TV intercept?
Why is it useful?
How to use it in PyMC-Marketing?
What are the benefits? (thinking about the MMM objective of better inference)
When to use it?
When it might not work?

Some of these questions have already been answer in the notebook. I think we just meet to complete the storyline and the takeaways 🤜🤛
WDYT?

Thank you. This is very actionable!

The notebook looks really nice! @ulfaslak

Isn't plt.show() more standard? I'll listen to a good argument (probably you're right).

View entire conversation on ReviewNB

Well, it is not needed inside the notebook so that is the reason I suggest the change :)

View entire conversation on ReviewNB

Is there an example of changing the covariance function in the model config?

Agree!

View entire conversation on ReviewNB

Agree with Juan here, I think it would be good to mention here what was discussed about the period within which the TVP does not deviate too much from reality. Being 90 days a great threshold if you work with daily data, of course not a consistent law for all cases, but regularly see it (Even in this example).

View entire conversation on ReviewNB

Considering adding a third example with spiky events, cause really that's what this is good for, I think...

View entire conversation on ReviewNB

For sure. refactoring the whole thing now to avoid boilerplate

View entire conversation on ReviewNB

Love it!

View entire conversation on ReviewNB

Thanks

View entire conversation on ReviewNB

lazy/ultra-brief way to offset time on the x-axis

View entire conversation on ReviewNB

yea, we do write to data when we synth new targets, so another option is to write to data_train and data_test separately, but this seems like the lesser evil

View entire conversation on ReviewNB

resolved in latest commit, i believe

View entire conversation on ReviewNB

@juanitorduz @wd60622 @carlosagostini Thanks for the reviews guys 🚀
I spent the day revising the notebook and I think it turned out quite nice:

Updated story line. Much better read now, particularly intro IMO. Reflects most comments I believe, let me know if not.
Everything factored into functions now that are reused across examples, to there is much less code to take in (fully DRY)
Added an example on "random events" that I think you might appreciate. Plays with ls_mu and prior setting to show how to improve fit, with difficult intercept.

+1

View entire conversation on ReviewNB

+1

View entire conversation on ReviewNB

@ulfaslak the notebook is looking much better!
I left some minor comments. I think there are other small ones by Will. Once you check those (or ignore them if you think you are happy now and would rather work on iterations), we can merge this one :)
Also, can you add
%load_ext watermark
%watermark -n -u -v -iv -w -p pytensor

at the end as the other notebooks please :)

There is one test failing tests/mmm/test_tvp.py::test_calling_without_default_args

+1

View entire conversation on ReviewNB

done

View entire conversation on ReviewNB

nice catch

View entire conversation on ReviewNB

There is one test failing tests/mmm/test_tvp.py::test_calling_without_default_args

I'll address this tomorrow.
SO CLOSE!!

That would be an interesting observation indeed!

View entire conversation on ReviewNB

There is one test failing tests/mmm/test_tvp.py::test_calling_without_default_args

I'll address this tomorrow.
SO CLOSE!!

The notebook looks amazing! There are a couple of minor comments open in the notebook, but they are not blockers, IMO (it would be nice to test if, in this case, the out-of-sample forecast accuracy breaks after one length scale). So, once you are happy with the notebook and you fix the test, we can merge this amazing addition! :)

(tomorrow is 1st of May so maybe you do it on Thursday and enjoy the day :D )

I love the new introduction!

View entire conversation on ReviewNB

Maaa maybe. I think in reality things are more complicated than that and we can't make an observation that simple. The default length-scale is 2 years (104.36 when data is weekly, 730.5 when it is daily)... When I lower length-scale in the last example, to one year, OOS uncertainty actually get smaller. I could try to dig into the relationship between LS and OOS performance, but the finding and nuanced answer would probably be *it depends*, and then—to bake that into this notebook—would require a new section. That might clutter the narrative and would take me a bunch of time = slow down release. So while interesting that you note this, I am against adding it for now (could be material for another time though, let's take note).

View entire conversation on ReviewNB

I'll start using ax.annotate ALL THE TIME from now on 😈

View entire conversation on ReviewNB

Maaa maybe. I think in reality things are more complicated than that and we can't make an observation that simple. The default length-scale is 2 years (104.36 when data is weekly, 730.5 when it is daily)... When I lower length-scale in the last example, to one year, OOS uncertainty actually get smaller. I could try to dig into the relationship between LS and OOS performance, but the finding and nuanced answer would probably be it depends, and then—to bake that into this notebook—would require a new section. That might clutter the narrative and would take me a bunch of time = slow down release. So while interesting that you note this, I am against adding it for now (could be material for another time though, let's take note).
 Let's skip this for this first iteration :)

(tomorrow is 1st of May so maybe you do it on Thursday and enjoy the day :D )

Appreciate the gesture 🙏. I'm already two cups of coffee deep though, so I might as well get it wrapped up 😅

@juanitorduz @wd60622 @carlosagostini  OK I think it's done now. Fixed the test and did some last minute copy fixes using grammarly (lotta typos when writing in free hand in code editor). Letting the CI spinners converge now, and hopefully we can merge today on May 1st 🎉.

Fantastic 🚀 !
@wd60622 do you have any additional comments :) ?

@juanitorduz @wd60622 @carlosagostini OK I think it's done now. Fixed the test and did some last minute copy fixes using grammarly (lotta typos when writing in free hand in code editor). Letting the CI spinners converge now, and hopefully we can merge today on May 1st 🎉.

How do you see Grammarly on notebooks? Or do you convert it to markdown?

I have Grammarly as a Chrome extension, and then I just load the notebook in the browser the old school way.


Celeste linux version falied launch

Celeste loaded from the steamctl version of Linux does not start:
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0

03/03/2024 00:35:56
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0

03/02/2024 22:10:41
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0

03/02/2024 22:08:23
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0

03/02/2024 21:43:37
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0

03/02/2024 21:41:43
System.DllNotFoundException: CSteamworks assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Steamworks.NativeMethods.SteamAPI_RestartAppIfNecessary(Steamworks.AppId_t)
  at Steamworks.SteamAPI.RestartAppIfNecessary (Steamworks.AppId_t unOwnAppID) [0x00005] in <531bc3e71a224e2ab9095ed44c8acdb9>:0
  at Celeste.Celeste.Main (System.String[] args) [0x0007b] in <4a26f9ded6704c87a2f47e66d2d85163>:0```

That's the Steam version, no? I have the itch.io version which works, but doesn't come with any steamworks files. Can you share the list of files ($ ls) that are in the game directory? Also assuming you're on OpenBSD, do you have the package libcsteamworks installed?

Thanks, but the Linux version still doesn't work well. It started thanks to libcsteamworks, but no splash screen appeared. Tried the Windows version by installing from steamctl, and it works fine (only without sound, for obvious reasons)! List of files of the linux version awesomes$ ls Celeste Celeste.Content.dll Celeste.bin.x86 Celeste.bin.x86_64 Celeste.exe Celeste.exe.config_ Celeste.png Content FNA.dll FNA.dll.config_ FNA3D.dll Mono.Posix.dll_ Mono.Security.dll_ Steamworks.NET.dll System.Configuration.dll_ System.Core.dll_ System.Data.dll_ System.Drawing.dll_ System.Numerics.dll_ System.Runtime.Serialization.dll_ System.Security.dll_ System.Xml.Linq.dll_ System.Xml.dll_ System.dll_ gamecontrollerdb.txt lib lib64 monoconfig_ monomachineconfig_ mscorlib.dll_

Thanks, I added the support for Steam Windows version to the Status Tracker: https://github.com/IndieRunner/IndieRunner/commit/bc4473c07a3497dfc740dafe30afe28786fa639e
What output do you get when trying to launch the Windows version?

The Windows version just works. I played this game with gamepad and it works just fine, maybe I should close the issues? since Celeste eventually worked, although not the Linux version


CASMNET-1059: Bump CANU version to 1.0.0

Summary and Scope
CANU has been updated to feature complete as of the 1.0.0 release and needs to be included in CSM 1.2 build.
Issues and Related PRs

Resolves CASMNET-1059
Merge with https://github.com/Cray-HPE/csm/pull/214

Tested on:

wasp
Local development environment

Test description:

Tested upgrade from 0.0.5 and 0.0.6 to 1.0.0.
On system testing of SHCD validate, configuration generation and validation and cabling checks.

Were continuous integration tests run? YES
Was upgrade tested? YES
Was downgrade tested? NO as downgrade to 0.0.6 or lower will not be useful on CSM 1.2 systems.

Risks and Mitigations
None
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

wrong merge ;)


Html item gets repeated in inspector an arbitrary number of times

Using latest version from github.
Using usciter.exe, even with a simple example like:
<html lang="en" window-resizable="true" window-wclassth="400dip" window-height="600dip" theme="light">

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="wclassth=device-wclassth, initial-scale=1.0">
    <title>Test</title>
</head>

<body>
</body>

</html>

Cannot reproduce this, not in scapp.exe nor in usciter.exe


[Design] Why the problem detail does not be collapsed

Generally, we maybe need to see the concrete rule basic description like "Finding xxxx", but now it displays the detailed description...maybe the short description can be refactered into "An HTTP-based URL with xxxx", currently, "Finding xxxx" is not that user-friendly for me.

I think I understand this item now.  This is a request for the short name at the bottom (here DS126858) to be more meaningful.

Based on what it currently looks like collapsed that seems to meet the request here.

No info from requestor.


Sysadm issue trackers now up - update docs

The issue trackers for sysadm are not up and running, so we need to update docs to point there for the place to report issues instead of the trueos-core repo.

im an idiot... wrong place to put this. :P


Telia Carrier is now Arelion

I left an old class for Telia there, but am glad to remove it -- not sure what the proper way of handing this rename is, but noticed that the library as-is was not processing Arelion maintenance notices so modified it to do that.


fix: Use npm template package

As opposed to using a local one with file: option
Further Details:
https://github.com/facebook/create-react-app/blob/v3.4.1/packages/create-react-app/createReactApp.js#L750 is the problem. It would parse @contentful in our name and break. It's partially also a bug on create-react-app. If a template name has @ in it's name, it will break. Unless it's part of the organization name.
We already published a template on npm: https://www.npmjs.com/package/@contentful/cra-template-create-contentful-app.
FYI, this means going forward we will publish 3 times: once for template, for org scoped pkg and create-contentful-app parked name.

@Jwhiles while using node to run CRA - it's unavoidable. We can use npx but someone brought up an issue with running npx inside parent process of npx.

@Jwhiles should work with npx as a subprocess but it is fragile to me. With resolve you're guaranteed to run a direct dependency of CCA (run with npx too) rather than allowing the child npx to decide on its own. While debugging we've seen the child npx download deps of CRA again.


Broken

Just wanted to let you know the plugin isn't working any more. It's one of my favorites- it's been immensely helpful working on 200m hunter and I've recommended it to a handful of people.

Just saw this, will fix immediately

Well that was short lived, Jagex changed the way box traps work so there isn't a way for the client to see what chin is going where. Unfortunately this means I need to freeze this plugin until either jagex sends the information to clients again or someone finds an alternative solution

Thanks for looking into it! I noticed that chinchompas no longer face the box traps they're targeting (or targeted by?) with a recent update. I've been sending Jagex bug reports about it. Do you think that if they fixed that bug, you'd be able to get the plugin working again? I'm not sure about exactly what changed with chinchompa/box trap behavior behind the scenes.


Added period, description sorted errors.

Added period and added description in roles as requested.

closes #ISSUE-NO
What does this PR do?
Description of the task to be completed?
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions

Hey community members please review this PR thank you.

Thank @Panquesito7 for reviewing. Have great day.


Added recursive reference counting protection and more test cases

SizeOf currently fails on any self-referential data structures. This change adds reference tracking to the SizeOf method so that these data structures are properly counted.
In addition, more test cases were added to achieve 100% test coverage of the SizeOf method.

I didn't even realize anyone else uses this repo, thanks for the PR and the overall code clean up.

Glad to help, this was definitely the best starting point I could find for solid memory sizing, which is essential for writing a good cache. I'll likely be making another PR soon that optimizes this further to no longer depend on so much recursion, since that fails for structures like linked lists.


chore: 0.3.0 release proposal

~TODO:~

[x] Upload release notes: https://github.com/open-telemetry/opentelemetry-js/releases/tag/untagged-513fd81d6bc8224a38c8
[x] Merge #596
[x] Update examples w/ new version

Note:

Removed "private": true from mongodb-core and pg plugins.

Codecov Report

Merging #599 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #599      +/-   ##
=========================================
- Coverage   90.06%   89.9%   -0.16%
=========================================
  Files         168     167       -1
  Lines        8374    8215     -159
  Branches      751     747       -4
=========================================
- Hits         7542    7386     -156
+ Misses        832     829       -3

Impacted Files
Coverage Δ

...es/opentelemetry-node/src/instrumentation/utils.ts
90.47% <0%> (-9.53%)
:arrow_down:

...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts
66.66% <0%> (-8.34%)
:arrow_down:

...entelemetry-exporter-jaeger/test/transform.test.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-tracing/src/config.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-tracing/src/utility.ts
100% <0%> (ø)
:arrow_up:

...ges/opentelemetry-exporter-zipkin/src/transform.ts
100% <0%> (ø)
:arrow_up:

packages/opentelemetry-tracing/test/Span.test.ts
100% <0%> (ø)
:arrow_up:

.../opentelemetry-exporter-zipkin/test/zipkin.test.ts
100% <0%> (ø)
:arrow_up:

.../opentelemetry-plugin-dns/test/utils/assertSpan.ts
100% <0%> (ø)
:arrow_up:

...ry-tracing/test/export/SimpleSpanProcessor.test.ts
100% <0%> (ø)
:arrow_up:

... and 14 more

I wonder if we can add a CI task to make sure the package.json matches the version.ts

please run npm run bootstrap - 2 packages (core & exporter-collector) should regenerate automatically the version.ts files
what about examples ?

Done, ptal

please run npm run bootstrap - 2 packages (core & exporter-collector) should regenerate automatically the version.ts files
what about examples ?

wow great catch


Attributes not working as expected with wrapper components in Next.js App Router

Firstly, I want to express my gratitude for creating such a brilliant library.
I've been trying to use Kuma like this:
import { k } from "@kuma-ui/core";
import { PropsOf } from "@kuma-ui/core/dist/components/types";

type Props = PropsOf<typeof k.div>;

export const Center = (props: Props) => {
  return (
    <k.div display="flex" alignItems="center" justify="center" {...props} />
  );
};

I create something like the above, and then use it like this:
  <Center flexDir="column" gap="var(--space-lg)">
    ...

But the flexDir="column" and other attributes I specified in the latter don't work..
Environment (App Router)
 "dependencies": {
    "@types/node": "20.4.1",
    "@types/react": "18.2.14",
    "@types/react-dom": "18.2.6",
    "eslint": "8.44.0",
    "eslint-config-next": "13.4.9",
    "next": "13.4.9",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "typescript": "5.1.6"
  },
  "devDependencies": {
    "@kuma-ui/core": "^0.5.0",
    "@kuma-ui/next-plugin": "^0.8.0",
    "react-icons": "^4.10.1"
  }

@AsazuTaiga
This feature is available in our latest beta release, please give it a try! . Appreciate any feedback you have. 👍


Failed to install extension: Signature: EACCES

Testing #164452

Configure

"extensions.verifySignature": true,
"_extensionsGallery.enablePPE": true

Try to install nikhgup1.component-creator
I get the following error:

2022-10-26 14:07:38.343 [error] Error while installing the extension: nikhgup1.component-creator
2022-10-26 14:07:38.343 [error] Failed to install extension. nikhgup1.component-creator
2022-10-26 14:07:38.343 [error] Signature: EACCES
    at pt.download (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:37:113204)
    at async x.doRun (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:89:199243)
2022-10-26 14:07:38.344 [error] [uncaught exception in sharedProcess]: EACCES: Signature: EACCES
    at pt.download (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:37:113204)
    at async x.doRun (vscode-file://vscode-app/usr/share/code-insiders/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:89:199243)

Version: 1.73.0-insider
Commit: c3eebaead9d3bf1cb961b91fca1b8af31990d328
Date: 2022-10-26T09:30:42.684Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux arm64 5.15.0-52-generic
Sandboxed: Yes

@dtivel Is EACCES error coming from the vsce-sign exe?

Is vsce-sign present?  If so, I suspect it's an issue with file permissions.  Do file permissions need to be set during install?  I tried setting them during preinstall, which worked locally.

It's present and here is the exe access levels in Linux ARM 64
-rwxrw-r-- 1 root root 14853557 Oct 26 07:20 vsce-sign

It's also same in Mac ARM 64
-rwxr--r--  1 sandy081  staff  30494992 Oct 26 12:04 vsce-sign

It worked in Mac but not in Linux. When I changed the exe's access in Linux ARM 64 to 777, it worked.
Not sure if Linux ARM 64 needs spl access


Detect blocked room exits and route around them

This adds to the Intel system by having it route from the centermost resource (controller or source) to each of the connecting rooms. If it can't route (due to walls) it considers the room blocked.
This also updates the call to findRoute to route around blocked exits by utilizing the second argument (fromRoom) in the routeCallback function to check against blocked exits.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

TheRealMaxion
✔

semperrabbit
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Don't have augment_images

my imgaug version is 0.2.9，but don't have augment_images method, the method is _augment_images.

augment_images() is defined in imgaug.augmenters.meta.Augmenter from which all augmenters inherit. Hence, all augmenters should offer that method. It automatically calls _augment_images(). It is also one of the oldest methods in the library, so your version should hardly influence that.
Please provide a stacktrace and which augmenters you call.

Thanks, the problem is solved.


Global variable does not work correctly in v4 production

Behaviour:
Trying to bundle a draft-js dependency (into vendor).
Said bundle uses the "global" variable
In fusebox v4 development mode global is initialized with window:
// Patching global variable
if ($isBrowser) {
  g['global'] = $isWebWorker || $isServiceWorker ? {} : window;
}

In production mode these types of code get generated:

$fsx.f[441] = function(module, exports){
"use strict";
var global = {};

and then  var selection = global.getSelection(); throws an error. If I initialise global = window, and remove the var global = {} lines from the vendor.js code works properly.

thanks! This has been fixed in the latest alpha. I will be posted a list of breaking changes shortly for you to migrate.

problem has been fixed in the latest version. Thank you!


Blocked keyboard input after entering a container

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
After entering a container with podman exec -it containername /bin/sh the keyboard input can be blocked by typing anything during the time between executing mentioned command and getting shell. By blocked I mean any kind of input in the terminal session from typing classic characters or Ctrl+C or anything else. The only way out is to kill the session and open a new one.
Steps to reproduce the issue:

podman pull alpine
podman create alpine sleep 100000
podman start --latest
podman exec -itl --latest /bin/sh (after executing this, type anything on the keyboard, before entering the container)

Describe the results you received:
Unresponsive terminal session with shell prompt
Describe the results you expected:
Responsive terminal session with shell prompt
Additional information you deem important (e.g. issue happens only occasionally):
none
Output of podman version:
Version:            1.6.1
RemoteAPI Version:  1
Go Version:         go1.12.9
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.12.9
  podman version: 1.6.1
host:
  BuildahVersion: 1.11.2
  CgroupVersion: v1
  Conmon:
    package: conmon-2.0.1-1.fc30.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.1, commit: 4346fbe0b2634b05857973bdf663598081240374'
  Distribution:
    distribution: fedora
    version: "30"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>0
  OCIRuntime:
    package: runc-1.0.0-95.rc9.gitc1485a1.fc30.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc9+dev
      commit: 0840802d505e28d3adcbc7a275cbeadbdf64ddec
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 8
  eventlogger: journald
  hostname: harry-work
  kernel: 5.3.6-200.fc30.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-4.git19d199a.fc30.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.2
      commit: 19d199a6ca424fcf9516320a327cedad85cf4dfb
  uptime: 4h 44m 43.56s (Approximately 0.17 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/omichal/.config/containers/storage.conf
  ContainerStore:
    number: 6
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.6.4-2.fc30.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.6.4
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /var/home/omichal/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 8
  RunRoot: /run/user/1000
  VolumePath: /var/home/omichal/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.6.1-2.fc30.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
Running Fedora Silverblue 30

Can you also reproduce this problem with podman run?
@haircommander PTAL - could this be the way we handle sync for podman exec?

I could not reproduce with run, but could with exec

the cause is currently a mystery to me, I'm gonna poke around for a bit

This now is the case again with Toolbox 0.0.18-1 and podman 1.8.0-2 on FSB31. Can anyone reproduce?

@fbruetting Yeah, I can reproduce it with both Toolbox container and the steps in the original issue.
toolbox-0.0.18-1.fc31.noarch, podman-1.8.0-2.fc31.x86_64, crun-0.12.1-1.fc31.x86_64

Can someone reopen then?

Reopening and I wonder if #5203 at least helps to address this?

@HarryMichal Do you still have this issue?

Yes, I still do. But on version 1.8.0. I currently don't have 1.8.1 installed on my system.

I have podman 1.8.1-dev and I still have the issue.

I have been hitting this too on Fedora 31. I have:
podman-1.8.2-2.fc31.x86_64
conmon-2.0.14-1.fc31.x86_64
crun-0.13-1.fc31.x86_64

I'm hitting this on Fedora 32 with:

podman-1.9.1-1.fc32.x86_64
conmon-2.0.15-1.fc32.x86_64
crun-0.13-2.fc32.x86_64

Do you have a reproducer we could play with?

@rhatdan Yes, I have a reproducer. Please run this:
podman run -dit --name too_fast docker.io/library/alpine

then copy and paste these lines (in one go, with the newline) into a shell:
podman exec -it too_fast sh
echo "I'm typing waaay too fast."

Every time I run this, I get an interactive shell that:

Hangs
Does not respond to CTRL-c or CTRL-d
Only closes when I hit CTRL-p CTRL-q (after some noticeable delay)

Nice, @mheon @haircommander Does this help you guys out?


[Bug]: chromadb-client: ModuleNotFoundError

What happened?
As e.g. https://docs.trychroma.com/guides#using-the-python-http-only-client suggests, after pip install chromadb-client I should be able to import chromadb to create a client.
But when I do that, I get errors that many modules are missing, e.g. httpx, starlette, tokenizers, ...
Not sure if I'm missing something obvious?
Versions
chromadb-client                          0.5.4.dev0
python 3.12 and FROM python:3.12.3-bookworm
archlinux and docker
Relevant log output
Traceback (most recent call last):
  File "/app/app.py", line 1, in <module>
    import chromadb
  File "/usr/local/lib/python3.12/site-packages/chromadb/__init__.py", line 5, in <module>
    from chromadb.api.async_client import AsyncClient as AsyncClientCreator
  File "/usr/local/lib/python3.12/site-packages/chromadb/api/async_client.py", line 1, in <module>
    import httpx
ModuleNotFoundError: No module named 'httpx'

@curious-broccoli, thanks for reporting this. We've recently switched from requests library to httpx and this change may not have been propagated to the http client (I'll check). As far as the other libs go, I'll test them and take appropriate action to remedy the situation. Do you need the async client if not I'd suggest you revert to an earlier version e.g. 0.5.0.


Replication fails on Ubuntu 14

"Remote from" replication fails with Create on Ubuntu 14 which is using CouchDB 1.5. There is no useful error message.

Resolved in d0e6ab90db090c0e1b6b872269769e555cc21e06


Query about fetching tweet replies/comments.

Discussed in https://github.com/PLhery/node-twitter-api-v2/discussions/324

Originally posted by muhitrhn July  8, 2022
Is it possible to fetch replies/comments of a specified tweet.

This isn't a place for asking for advice about Twitter API. Please stick to discussions, or use https://twittercommunity.com/.

@alkihis And of course, if I posted here, that means I want to know if it’s possible by this Package.


RemoteAST: Fix Error existential introspection on Linux

This cherry-picks a couple of patches to 5.1 that are needed by https://github.com/apple/swift-lldb/pull/1377. Sorry for the lousy commit messages -- the changes fix two different bugs at different points in time.

@swift-ci Please test


how to convert the last 5 pages of a docx to pdf

I need to convert the last 5 pages of a docx file to pdf.
I have two questions:

how to count the total number of pages of a docx file by code?
is it possible to tell last 5 pages without knowing the exact number of pages of a docx?

Hello @Simplici

Might be possible with another library.
Maybe LibreOffice provides a way to do that with its page ranges option, but I'm not sure about that.

@gulien
I have searched for a library to do that, but nothing found. the reason it that there is a page information in docx xml representation, but that information is not reliable especially when the document is generated by program.
the only way to get the number of pages is to do it when the document have been fully rendered by Word or LibreOffice.
for your 2nd proposition, i have also done some research, but no useful information was found.


[ISSUE #4492] support Kqueue

Make sure set the target branch to develop
What is the purpose of the change
support Kqueue
Brief changelog
support Kqueue
Verifying this change
support Kqueue
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4621 (2888546) into develop (3ee603a) will decrease coverage by 0.06%.
The diff coverage is 11.90%.

@@              Coverage Diff              @@
##             develop    #4621      +/-   ##
=============================================
- Coverage      43.46%   43.40%   -0.07%
- Complexity      6210     6217       +7
=============================================
  Files            817      817
  Lines          57654    57693      +39
  Branches        7873     7883      +10
=============================================
- Hits           25059    25040      -19
- Misses         29351    29410      +59
+ Partials        3244     3243       -1

Impacted Files
Coverage Δ

...e/rocketmq/remoting/netty/NettyRemotingServer.java
58.30% <6.66%> (-3.09%)
:arrow_down:

.../apache/rocketmq/remoting/common/RemotingUtil.java
12.21% <13.04%> (+0.17%)
:arrow_up:

...che/rocketmq/remoting/netty/NettyServerConfig.java
46.77% <25.00%> (-1.51%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
45.76% <0.00%> (-3.41%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
82.38% <0.00%> (-0.96%)
:arrow_down:

.../rocketmq/broker/filter/ConsumerFilterManager.java
72.19% <0.00%> (-0.90%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
48.06% <0.00%> (-0.56%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
68.80% <0.00%> (-0.51%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee603a...2888546. Read the comment docs.

Coverage decreased (-0.06%) to 47.52% when pulling 28885462ee7ea0990b1858d61ad641e83c3caca0 on skasj:develop_kqueue into 3ee603a49b04c0b602ff8eb45b3ef4330293fba8 on apache:develop.


Multiline filter does not handle @metadata properly

Hi,
I've been using @metadata in a configuration file for Logstash 1.5.4. My config is using metadata to represent the type of an event. I use metadata instead of type because I don't want the type field in my output (and I have multiple config in a single directory and each output will be different depending on the type). Anyway, here is a trimmed-down version of my config:
input {
    file {
        path => "/tmp/web.log"
        sincedb_path => "/dev/null"
        start_position => "beginning"
        add_field => { "[@metadata][type]" => "web" }
    }
}
filter {
    multiline {
        pattern => "^\s"
        negate => false
        what => "previous"
    }
}
output {
    if [@metadata][type] == "web" {
        stdout { codec => rubydebug { metadata => true } }
    }
}

My test file contains 3 lines (with proper line ending):
line 1
line 2
line 3

When I execute this config, the last line is never output. If I remove the if [@metadata][type] == "web" test, that last line is output.
I looked at the code of the multiline plugin and found that metadata are not always handled properly (if I am not mistaken). In the case of the previous filter, when the event does not match the pattern, the current event is kept aside in a tmp variable and the pending events are all merged together to replace the current event. The current event, stored in tmp variable, is put in the pending array until the next event comes or a flush is triggered. Problem is, when the current event is stored in tmp, the metadata are not kept (because it is using .to_hash instead of .to_hash_with_metadata). Also, when the pending events are all merged together, they are passed to event.overwrite, which, AFAICT, is not handling metadata either. In case of a next filter, we have the same problem because of event.overwrite.
I've written a small patch that fixes the issue with my configs. I am not sure it cover all cases and if we should modify event.overwrite also. Let me know if you'd like me to make further changes to it. Or feel free to use the code for a fix if deemed necessary.
Thanks!

@pascaldimassimo thanks for filling this issue, while working on #22 I just tested your patch and works like charm. thanks.

Perfect! Once you have a fix for #22 available, I'll test it with my config. Thanks!

Hi @pascaldimassimo much appreciate, you can check #23 for more details, just updated the PR a few minutes ago.

Fixed in https://github.com/logstash-plugins/logstash-filter-multiline/pull/23


Add follow on twitter badge as part of the docs

This is how it looks like:-

Description
Included a follow on twitter badge as part of Readme.md file.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

@Hixie Thoughts :thinking:

cc @mjohnsullivan

cc @sfshaza2


Chore mow table's mv need have all key column

Proposed changes
mow table's mv need have all key column

run buildall


DNS name does not have enough labels

Hello!
tried your script on pfSense.... and see this:
[2.2.5-RELEASE][root@gw]/root/acme-tiny: python acme_tiny.py --account-key ./account.key --csr ./domain.csr --acme-dir /usr/local/etc/nginx/letsencrypt/ > ./signed.crt
Parsing account key...
Parsing CSR...
Registering account...
Registered!
Verifying Common...
Traceback (most recent call last):
  File "acme_tiny.py", line 198, in <module>
    main(sys.argv[1:])
  File "acme_tiny.py", line 194, in main
    signed_crt = get_crt(args.account_key, args.csr, args.acme_dir, log=LOGGER, CA=args.ca)
  File "acme_tiny.py", line 104, in get_crt
    raise ValueError("Error requesting challenges: {0} {1}".format(code, result))
ValueError: Error requesting challenges: 400 {"type":"urn:acme:error:malformed","detail":"Error creating new authz :: DNS name does not have enough labels","status":400}

Can you please post or email me your CSR? It looks like you're trying to request the domain Common.

Following up, did you get your issue resolved?

sorry, was busy.

Appears to be an invalid CSR. Emailed you the details.

I think letsencrypt does not support dhnamic dns services like changeip with url "foo.epac.to", am I wrong

am I wrong

Yes, why should not LE support dynamic DNS services? As long as the domain can be verified LE supports all sites.

It may be acting them as subdomains, I couldn't verify my sertificate, it's failing at verifying stage.

Yes the only thing, which may happen is that they exceeded their rate limit. FOr this issue I'd suggest you to look at https://community.letsencrypt.org/t/ratelimit-for-dynamic-dns-domain/17733/

How did you solved this  issue?


Remove: StandardNotes.StandardNotes version 3.20.2

<3.22.11 is deprecated/archived

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.2 schema?

Microsoft Reviewers: Open in CodeFlow

Closing because the line endings changed on 3.20.0, for some reason :/


@rebass/components is not compatible with emotion 10

@rebass/components is not compatible with emotion 10

Is the solution similar to https://github.com/rebassjs/rebass/pull/537, where the Babel config would need to be updated to change the package @rebass/components imports from (e.g. replacing react-emotion with @emotion/styled?
https://github.com/rebassjs/components/blob/ca2f0a2e21797410b407c9c8b87c1e855d433472/.babelrc#L14

I believe that's all that's needed, though this probably warrants a major version bump

ended up with making them from styled-system this removes the dependency problem.. i did
import styled from '@emotion/styled';
import {
alignItems,
alignSelf,
color, display,
flex,
flexBasis,
fontSize,
justifyContent,
order,
space,
width,
} from 'styled-system';
export const Box = styled('div')({
boxSizing: 'border-box',
}, width, space, flex, fontSize, color, order, alignItems, justifyContent, alignSelf, flexBasis, display, (props) => props.css);
Box.displayName = 'Box';


Not able to redirect the log to a file with documents4j-server-standalone-1.0.2-shaded

Hi.
We are currently using documents4j-server-standalone-0.2.1-shaded to convert our office douments to pdf.
I would like to upgrade to version 1.0.2.
However, it looks like there is a bug in the commandline parsing in version 1.0.2 which makes it impossible to redirect the logging to a file.
The problem can be reproduced by running 1.0.2 from a windows command promt like this :
C:\PDFKonv\old>"C:\Program Files\Java\jre1.8.0_91\bin\java.exe" -jar documents4j-server-standalone-1
.0.2-shaded.jar -F "C:\PDFKonv\temp" -L "C:\logs\log.txt" http://APP204800:8080 -V "info"
10:33:30.027 [main] ERROR c.d.standalone.StandaloneServer - The documents4j server terminated with a
n unexpected error
joptsimple.OptionArgumentConversionException: Cannot parse argument 'C:\logs\log.txt' of option [arg
uments]
.
.
Error: Cannot parse argument 'C:\logs\log.txt' of option [arguments]
Use option -? to display a list of legal commands.
For comparison, this is how the command outputs on the version 0.2.1
C:\PDFKonv>"C:\Program Files\Java\jre1.8.0_91\bin\java.exe" -jar documents4j-server-standalone-0.2.1
-shaded.jar -F "C:\PDFKonv\temp" -L "C:\logs\log.txt" http://APP204800:8080 -V "info"
Logging: The log is written to C:\logs\log.txt
Logging: The log level is set to INFO
Welcome to the documents4j server!
on jul 13 10:39:09 CEST 2016: Started server on 'http://APP204800:8080'
The documents4j server is up and running. Hit the enter key to shut it down...

I am planning a new version of documents4j in the near future where I fix a few other bugs, as well. This one will be included in that version. Thanks for reporting.

Thanks a lot for the reply. I have one further question. Does documents4j have bultin log rotate, or do we have to do that "manually" ?

documents4j uses logback. You can configure the logging as described in their manual: http://logback.qos.ch/manual/appenders.html

Thanks :+1:

I did a copy paste mistake when adding the command line switch for SSL and remapped the logging constants to those for SSL. Therefore, nothing could be parsed anymore. I fixed this on master and will include it in the next release which is coming soon. Sorry for the long wait.

Hi, thank you :-)
Tore
On Fri, Dec 23, 2016 at 4:33 PM, Rafael Winterhalter <
<EMAIL_ADDRESS>wrote:

I did a copy paste mistake when adding the command line switch for SSL and
remapped the logging constants to those for SSL. Therefore, nothing could
be parsed anymore. I fixed this on master and will include it in the next
release which is coming soon. Sorry for the long wait.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/documents4j/documents4j/issues/32#issuecomment-269006262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATfR0cSPzcxAY0XRvgKWnR-Upb0FUe4-ks5rK-nEgaJpZM4JLMGd
.


nixos/paperless: use python from pkg for gunicorn

Copy of commit msg
This ensures that a compatible gunicorn is used when pkg is overridden.
Potentially fixes #190850 (needs backport).

Whether or not this fixes the mentioned issue, this is improves correctness.

Thanks, that fixed it :)


remove pk check since it is redundant and may break South datamigration

Change supposed to address issue #119.

By the way: as you can see this change introduced test fails.  This is because previously deserialization didn't actually happen during these tests since your JsonModel instances don't have pks assigned. Now you can see ValidationError's caused by python json model which doesn't accept arbitrary strings as valid JSON.

New commits are supposed to fix ValidationError that happens with new Model instances. I've also revised test cases. I believe for string to be considered valid JSON it should be enclosed in double quotes as in rfc7159.

Is this still relevant now that we only support 1.8+ and South is deprecated? Please reopen if there is an issue. Thanks!


Add more thorough I8080 HIL tests

Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝

[x] I have updated existing examples or added new ones (if applicable).
[x] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
[x] My changes were added to the CHANGELOG.md in the proper section.
[x] I have added necessary changes to user code to the Migration Guide.
[x] My changes are in accordance to the esp-rs API guidelines

Extra:

[x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖
Description
More HIL tests
cc @bugadani . Thanks to #2128 this was very easy to write. I just wanted to note that I had to set the pcnt input after setting the I8080 output because output configuration seems to wipe out the input settings. I'm not sure what needs changing yet.
Testing
Ran them.

because output configuration seems to wipe out the input settings.

Yup, this is something that we need to figure out for other peripherals as well.


mcmc_sampler not visible from do_samplers

I'm not extremely skilled at Python so this might be a dumb question. But I cloned the repository and ran setup.py and I can access the logic where I need it. But the mcmc_sampler somehow does not show up. Here is example code
import dowhy.do_samplers as do_samplers
do_samplers.get_class_object("weighting_sampler")

Out[14]: dowhy.do_samplers.weighting_sampler.WeightingSampler
do_samplers.get_class_object("mcmc_sampler")
Traceback (most recent call last):
File "", line 1, in
do_samplers.get_class_object("mcmc_sampler")
File "/home/johan/anaconda3/lib/python3.6/site-packages/dowhy-0.1.0-py3.6.egg/dowhy/do_samplers/init.py", line 19, in get_class_object
raise ImportError('{} is not an existing do sampler.'.format(method_name))
ImportError: mcmc_sampler is not an existing do sampler.
dir(do_samplers)
Out[16]:
['DoSampler',
'builtins',
'cached',
'doc',
'file',
'loader',
'name',
'package',
'path',
'spec',
'get_class_object',
'import_module',
'kernel_density_sampler',
'multivariate_weighting_sampler',
'string',
'weighting_sampler']
So it is missing indeed. Do you have a suggestion?

I tried this and am unable to reproduce--seems to work on my setup. Can you share your python version/system details?

Python version 3.6.3 :: Anaconda custom (64-bit)
OS Ubuntu 16.04
if there is more that you need (dependencies on system libs? versions of some other programs?) I'm glad to provide that information too

can't recreate on my ubuntu 18.04 setup. can you make sure you're up to date with master?

Thanks for getting back to me. I still get the error but looking closer at the error message I saw that pymc3 is missing.
After installing pymc3 I got a key  error about blas. blas is installed. There was also a missing environment variable, which I set and I got a lot of complaints about theano not having a compile module. So I will have a look at the dependencies again to find the reason before I continue to answer here. And maybe I'll upgrade to 18.04 first.

Hi @steunenberg Checking in, were you able to run it on your machine?

Hi @amit-sharma I tried to find out what was missing in setup.py but I could not find out.  As mentioned above, when I'm in the dowhy root directory, the object exists. But somewhere else it does not. This seems a setup.py issue. But I must admit that I did not try that much. Half an hour seemed enough to me.

Hey @steunenberg, just merged an update from @ktmud that may be a fix for this issue. It could be that a PyMC's version was creating a problem. If you get a chance, can you pull the latest master and try if it fixes the problem for you?


Make Preparer extend Serializable

Aggregators created through the Preparer interface retain references to the original Map/FlatMap Preparer instance. For Summingbird Storm jobs, this causes issues since the aggregators need to be Java serializable.
While we could try to construct the instances such that we don't retain any unnecessary references, it seems simpler to just make Preparer extend Serializable to avoid any issues in the future.
cc @avibryant

LGTM

merge when green!


Version Command output is empty

▶ codegpt version
version:  commit:

I will take it.

@stevenklar release v0.0.3 https://github.com/appleboy/CodeGPT/releases/tag/v0.0.3 please try it out.


Lesson 13, API error while deploying contracts to kovan

Hi
I tried to upload TokenFarm and DappToken on kovan but I'm getting this error on the terminal
`Running 'scripts\deploy.py::main'...
Transaction sent: 0xac25cec120ae5c7f1d4d100f4b3d75425a16f3ef2b09f0b5fd20a886854e8a7a
  Gas price: 2.500000007 gwei   Gas limit: 702941   Nonce: 27
  DappToken.constructor confirmed   Block: 28803854   Gas used: 639038 (90.91%)
  DappToken deployed at: 0xcCe6cbc8FaF84e8Ed6DEcC662A39D49dD60673af

Transaction sent: 0x7f50b670ce1624e1b84839e9b9fc0af502e98b93e0e3832af2009fb7a0c4db5b
  Gas price: 2.500000007 gwei   Gas limit: 1075353   Nonce: 28
  TokenFarm.constructor confirmed   Block: 28803856   Gas used: 977594 (90.91%)
  TokenFarm deployed at: 0xCa4C5019410Cdd562f1B69568A6063B376c297E0

Waiting for https://api-kovan.etherscan.io/api to process contract...
  File "C:\Users\Fedro\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\_cli\run.py", line 50, in main
    return_value, frame = run(
  File "C:\Users\Fedro\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\project\scripts.py", line 103, in run
    return_value = f_locals[method_name](*args, **kwargs)
  File ".\scripts\deploy.py", line 42, in main
    deploy_token_farm_and_dapp_token()
  File ".\scripts\deploy.py", line 10, in deploy_token_farm_and_dapp_token
    token_farm = TokenFarm.deploy(
  File "C:\Users\Fedro\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\contract.py", line 524, in __call__
    return tx["from"].deploy(
  File "C:\Users\Fedro\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\account.py", line 557, in deploy
    contract.publish_source(deployed_contract, silent=silent)
  File "C:\Users\Fedro\.local\pipx\venvs\eth-brownie\lib\site-packages\brownie\network\contract.py", line 392, in publish_source
    raise ValueError(f"API request failed with: {data['result']}")
ValueError: API request failed with: []`

this is what my deploy.py looks like

from scripts.helpful_scripts import get_account, get_contract
from brownie import DappToken, TokenFarm, network, config
from web3 import Web3

KEPT_BALANCE = Web3.toWei(100, "ether")

def deploy_token_farm_and_dapp_token():
    account = get_account()
    dapp_token = DappToken.deploy({"from": account})
    token_farm = TokenFarm.deploy(
        dapp_token.address,
        {"from": account},
        publish_source=config["networks"][network.show_active()]["verify"],
    )
    tx = dapp_token.transfer(
        token_farm.address, dapp_token.totalSupply() - KEPT_BALANCE, {"from": account}
    )
    tx.wait(1)
    weth_token = get_contract("weth_token")
    fau_token = get_contract("fau_token")
    dict_off_allowed_tokens = {
        dapp_token: get_contract("dai_usd_price_feed"),
        fau_token: get_contract("dai_usd_price_feed"),
        weth_token: get_contract("eth_usd_price_feed"),
    }
    add_allowed_tokens(token_farm, dict_off_allowed_tokens, account)
    return token_farm, dapp_token

def add_allowed_tokens(token_farm, dict_of_allowed_tokens, account):
    for token in dict_of_allowed_tokens:
        add_tx = token_farm.addAllowedTokens(token.address, {"from": account})
        add_tx.wait(1)
        set_tx = token_farm.setPriceFeedContract(
            token.address, dict_of_allowed_tokens[token], {"from": account}
        )
        set_tx.wait(1)
    return token_farm

def main():
    deploy_token_farm_and_dapp_token()`

I don't really understand what's going on here, also I've tried to find solutions online but none were useful
Could someone help me on this please?

Hello @DieKant the code is complaining about the API key, if you have configured the parameter "verify=true" for kovan on your brownie-config.yaml you will also have to add the EtherScan API key to you .env otherwise it won't work.

Hi @cromewar
I do have both an etherscan API key in my .env file as ETHERSCAN_TOKEN and the "verify=true" in my brownie-config.yaml under the kovan network
I've tried to solve this multiple times but I didn't find a solution yet

Hum strange as the error is complaining bout that verification, could you change the verify to false, and see if it pass through? just to confirm is a problem with the API key.

Hi @cromewar
I solved the issue by putting True instead of config["networks"][network.show_active()]["verify"] in the publish_source option
This doesn't make any sense whatsoever, I made this custom test (it's right below this text) and it passes the assertion phase, I don't understand why if it's the same exact thing it gives an error when I use it one way instead of another
`def test_is_it_true():
verify = config["networks"][network.show_active()]["verify"]
assert verify == True
used this command->  brownie test -k test_is_it_true --network kovan
`

You are awesome @DieKant I think this should be because the contract must be verified in order to be executed (don't know why tough).


Binary download unavailable

The binary download page returns a 404 error:
http://gogs.io/docs/installation/install_from_binary.html

http://gogs.io/docs/installation/install_from_binary
without .html

Some links in the docs are broken. The correct one for that one is:
http://gogs.io/docs/installation/install_from_binary

Great, thanks!

Oops, sorry about that.
Should we still support arbitrary extension or simply result 404?

There's also 404 for other documentation pages- for example the "Configuration and Run" page.

@delucks just remove all extensions like ".md" and ".html" should work.

Close for now but open for continuing discussion.


Fix test for release

fix: https://github.com/Azure/azure-dev/issues/36

/check-enforcer override

We probably need to sit down at some point and try to clean up how the versioning story works here - there's a lot of interactions between these files and the build jobs and I think we should write down how the system works and see if we can simplify stuff.
If we end up needing to use this file in tests, we might also look into the embedding stuff in the go toolchain now, perhaps we could embed the version.txt file in the tests so we didn't have to do this runtime.Caller stuff long term.


Find all mentions of ASRG in the Press and add to the ASRG Website as a Post.

https://www.asrg.io/about-us/asrg-in-the-press/

I found 4 News... and those are posted https://www.asrg.io/about-us/asrg-in-the-press/

https://drive.google.com/drive/u/0/folders/1gjaG1Z9jqXQND9NVpIz5Z9TgpzipAfS8

@heldyboy  Please give me an access to view this above link


Question: Is it possible to configure [features] lists?

Hey!
Thanks for developing taplo. I am working on introducing it to our repo at https://github.com/centrifuge/centrifuge-chain/pull/1055 and one feature that seems missing is the capability to also sort lists under [features]. For example, the std feature list here.
Am I missing how to achieve that or is it really not supported at them moment? Thank you!

Hi, if you are looking to sort values in an array, it's indeed not a feature yet. However it might become one in the near future, it's tracked in #158.

sweet, thank you 🚀


Use of trace with Monomer on Windows Machines

Currently the use of trace from debug.trace is does not output any result when in use with Monomer on Windows. It works just fine on Linux, but it outputs nothing to the terminal on Windows. It still builds just fine, just outputs no text.
error works on both, but on Windows it manifests as a dialogue box.
I'm not sure if this was intentional, but trace would be a very helpful tool if it were available.

Hi @ulfur-einn!
Maybe the discussion in this issue is helpful: https://github.com/fjvallarino/monomer/issues/207

Thank you, the inclusion of -optl-mconsole in my cabal file worked.
I appreciate your help!


receivingApplicationName and receivingFacilityName translation properties are not applied to HL7 senders on output

Problem statement
receivingApplicationName and receivingFacilityName translation properties are receiver settings that are meant to set a default value for MSH-5 and MSH-6 respectively. This feature is working when the sender is submitting a CSV file. However, this is not working when the sender is submitting HL7. The expectation is all receiver settings will equally apply regardless of the sender input message type.
Acceptance criteria

[ ] The value in receivingApplicationName should be applied consistently to MSH-5 on output regardless of input message type
[ ] The value in receivingFacilityName should be applied consistently to MSH-6 on output regardless of input message type

@kant777 any updates?

Closing as finished


Is it possible to set a audio bitrate ? [Q]

Hi @Swetha081099
What do you mean by "set an audio bitrate"?
If you mean "reencode an audio elementary stream at a higher/lower bitrate", then you should use tools such as ffmpeg or any other audio/video editor. TSDuck works on the transport layer, it does not mux, decode or encode the audio/video content.


[TS Migration] Migrate 'FormHelpMessage.js' component to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25054
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Press +, choose assign task
Press next without any changes
Observe that help messaged showed as expected

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android-native-converted.webm

Android: mWeb Chrome
android-web-converted.webm

iOS: Native
https://github.com/Expensify/App/assets/23215729/079d40f9-3372-4a83-b5be-3c78ba9539cf

iOS: mWeb Safari
https://github.com/Expensify/App/assets/23215729/a25e8656-fa6c-4032-9ce3-df83a2c175cd

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/23215729/e10937f4-da86-466a-abfd-62570021cb6e

MacOS: Desktop
https://github.com/Expensify/App/assets/23215729/c7a48ef6-d135-4965-a73d-20d026b17941

@0xmiroslav conflict solved

@0xmiroslav friendly bump!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/49892675-9b88-4e1e-a58b-84b70e170f3b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/dad581b3-e8f6-4c59-8010-645791cad66c

iOS: Native
https://github.com/Expensify/App/assets/108292595/96879821-329a-4f0a-91e9-119867035413

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/98c78024-6b2a-479a-ab57-2d70ed1fc035

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/033a854c-67bb-4268-9186-d06041e1083c

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/1ee04e52-e11b-4cf1-bb1c-1a64ac7c753e

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅


Support all of jsxstyle props

jsxstyle has this which I think is rad:
var MyComponent = React.createClass({
  render: function() {
    return <Block color="red" hoverColor="yellow">Hello, world!</Block>;
  }
});

We should look into supporting that for our "Element Components" (glamorous.Div, glamorous.Img, etc).

We really should just take a hint from what glamor-jsxstyle does and basically do the same thing (with some exceptions and utilities afforded us via glamorous).

It's important to note that the actual element's have already been implemented as glamorous-jsxstyle. We just need to support the additional props that jsxstyle supports.

If nobody else has started on this, I'd like to work on this.

Hey @newyork-anthonyng! Thanks for reaching out! Now that the built-ins support the css attribute, I'm actually unsure what more we need. It's not exactly the same API, but it's equally powerful (if not more so). I'm unsure whether we need much more 🤔

@kentcdodds Yes, agreed. The think the css attribute is more flexible than the jsxstyle props. Should we close this issue?

Yeah, let's do that 😀


No ObservableObject of type Store<AppState, AppAction, World> found. A View.environmentObject(_:) for Store<AppState, AppAction, World> may be missing as an ancestor of this view.: file SwiftUI, line 0

Hey, I've read the article (kudos for it) and tried to play around with your structure but I'm getting fatal error when trying to get to recipe details from recipes listing:
Fatal error: No ObservableObject of type Store<AppState, AppAction, World> found. A View.environmentObject(_:) for Store<AppState, AppAction, World> may be missing as an ancestor of this view.: file SwiftUI, line 0
2020-04-05 17:40:38.374178+0200 Recipes[3256:60476] Fatal error: No ObservableObject of type Store<AppState, AppAction, World> found. A View.environmentObject(_:) for Store<AppState, AppAction, World> may be missing as an ancestor of this view.: file SwiftUI, line 0

Do you know maybe what is causing the problem?

@sm0nster Hi, could you please show me code that raises the error? Usually, we have this error when forget to pass EnvironmentObject.

Recipes/Features/Recipes/RecipesContainerView.swift:16:
private var recipes: [Recipe] {
        store.state.recipes.compactMap {
            store.state.allRecipes[$0]
        }
}

Sorry I didn't attach it earlier but I'm using AppCode, and this showed up after I have run it in Xcode.

@sm0nster do you have added @EnvironmentObject var store?

@mecid I haven't changed anything it's just cloned repo

@sm0nster I've just tried to clone the repo and it worked normally. Could you please try again?

@mecid I've cloned the repo again, run it and first, when I tapped "breakfast" it opened details controller with infinite loader, I tapped "back" and now when I'm trying to tap any meal type I get same error :/

@sm0nster that's really strange because I can't reproduce the error.

Hi,
I may be experiencing the same issue. I tap Breakfast (or any category) and the next screen just hangs. Repo is freshly cloned. I also tried creating my own api creds at edamam.com in case that was the issue, but that didnt help. Perhaps the fetch request isnt completing and causing an issue? I'm still getting familiar with Combine and Xcode debugging unfortunately, hence no solution and pr.
Xcode Version 11.4 (11E146)
Any ideas? Or additional info I can provide?

@panckreous @sm0nster try to switch the filter to vegan recipes.

confirmed working as expected with Vegan and Vegetarian.


Future2021 and Telephasic changelog and blueprints

Hello.
Grav Themes repository, in the last four days it does not display version information and change log correctly.
In the Telephasic theme, the blueprints.yaml file is set to version 1.0.1, while the Grav theme repository shows 1.0.0.
On the other hand, Future2021 does not show the bug fix badge (in red color) in the Changelog, and I think the Changelog.md file is correct.
Are these files (changelog.md and blueprints.yaml) in the correct format?
Thanks

I feel like you haven't been following the guide at https://learn.getgrav.org/17/advanced/grav-development#grav-themes

Your blueprints version are correct, your tags and release are not, they shouldn't be including the prefixed V, as stated in the link above note:

Ensure your naming for each tag is consistent. GPM uses this information to determine if your plugin/theme is newer
than the last. We recommend using Semantic Version Numbers for tags. E.g. 1.2.4. Consistency for
all tags is paramount!
This is going to be hard now for you to fix because it implies you delete all of the tags/releases and do it again. I advice you to not do that, but you will have to be consistent with the way you are going to release going forward, if you start dropping the V, it's going to be causing issues.

Your Changelog doesn't show the bugfix tag because your release states #fixed (https://github.com/pmoreno-rodriguez/grav-theme-future2021/commit/5fadfa535a570559a24483887f3d37dce0a10df3).

It's not enough for you to make changes changes to your develop/master branch, if you are not releasing them. Tags/Releases are the only thing Grav's GPM look at, so even if your CHANGELOG looks corrected now, it is still displaying wrong from Grav's perspective when looking at the release tag.
This is probably also the reason why your other theme shows version 1.0.0, i think you updated the blueprint AFTER the tag/release.
Try re-releasing your themes and wait until GPM runs again, see if that fixes any of the other issues you are mentioning.


feat(FX-3192): ask notification permissions

The type of this PR is: Feature

This PR resolves FX-3192
Description
Demo
iOS
https://user-images.githubusercontent.com/3513494/129373362-ebc40b75-6d2a-4191-9cb3-0143feafdf1e.mp4
Android
Uploading Android.mp4…

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Ask notification permissions for Saved Search M2

This PR contains the following changes:

Dev changes (Ask notification permissions for Saved Search M2)

  Generated by :no_entry_sign: dangerJS against 7ebfa3086c54dcd445a113c03d1a6801bb090a62


video player not playing videos from URL in release apk

Which player are you experiencing the problem on:

Android

React native info output:
System:
    OS: macOS 12.4
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    Memory: 28.18 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 9.1.3 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.0.0 => 18.0.0
    react-native: Not Found
    react-native-macos: Not Found
    react-native-tvos:  0.69.6-2
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.2.1
Steps To Reproduce

npm i react-native-video
import Video from 'react-native-video';
<Video source={{uri: "URL"}}   // Can be a URL or a local file.
ref={(ref) => {
this.player = ref
}}                                      // Store reference
onBuffer={this.onBuffer}                // Callback when remote video is buffering
onError={this.videoError}               // Callback when video cannot be loaded
style={styles.backgroundVideo} />
...

Expected behaviour

Expected videos from url's to load and play but it stays loading without end in release build, however it is working fine in development build

Not enough information investigate...
What is the error ? What happen in the logcat ? Did you check the url is https and not http ?

In development mode, the video plays as expected, there is no error, but in release apk, the video does not play at all, the app stays on loading the video. and the url is https, same url works in development mode but not in release apk.

In development mode, the video plays as expected, there is no error, but in release apk, the video does not play at all, the app stays on loading the video. and the url is https, same url works in development mode but not in release apk. i'm not sure how to get logcat ?

Can you also post the source video url you're trying to play ? Did you also reproduce this issue with other reliable sources like Google's demo assets ? If you didn't can you also try these and share the result here ?
https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd

After i was able to view logcat information i realised that production api was sending http and not https url to the video player, It is finally working after i changed url from http to https. thanks for the help.


File missing

First of I want to say this is a great insight into the BERT model. But there seems to be a file missing from General Analysis. The file as said can be used to generate one's own wiki data.
(create_wiki_data.py). It would be quite helpful if you provide it .

Oops, that comment is out-of-date. You can use preprocess_unlabeled.py and extract_attention.py to create your own data files (see the README for details).

Thank You very Much 😊


Add parsers

This PR adds back the removed parsers that @nickmccurdy correctly pointed out are still needed by the GitHub formatter.

Out of curiosity, do you know what the Angular parser is for? Do they have their own file format like Vue now? I haven't used it since AngularJS 1, I thought it still used ordinary JS files and HTML files with special attributes.

Taking a cursory look, it looks like it’s used for the HTML parser (see here).

In that case I guess it's useful to keep it, I just wanted to make sure it's being used.


Setup

Could anyone tell me how set this up with yuzu please? first time using a randomizer with any game. Thank you

With Yuzu, right click the game press dump romfs then once it finishes it'll open a folder, throw the randomizer in there and then select your randomization settings
then go to Yuzu right click your game and drag the newly created "mods" folder into that, then rename the folder whatever you want to call your mod

Is there supposed to be an exefs folder with the romfs because I don't have that.