copy attribution button doesn't work

as discussed on call, flagging here to keep track

Which browser model, please? I checked it on the latest firefox and it's OK, scripted but copy to clipboard is a new technology in web browsers. It should fall back to displaying a text field for the user to copy from if the clipboard fails.

needs to not use relative links

@mattl Implemented in next version.

can't test now b/c model is not up

you may need to hit up the src/ directory

chromium Version 45.0.2454.99 (64-bit)

Oh that should be supported (as of Chromium 43):
http://caniuse.com/#feat=clipboard
The way it is meant to work is:

The user clicks on the "Copy Attribution" button.
Where the clipboard is supported, the code copies the attribution string to the clipboard. Where the clipboard is not supported, it shows a text field allowing the user to copy the attribution manually.
The user can now paste the attribution string into e.g. a text document or the address bar.

If it is not possible to paste the attribution string after pressing the button and the text area does not show instead that is a bug. Please can you see if there is anything in the JavaScript logs? They can be accessed using Command-Option-J in Chromium.
Possibly we should alert the user when copying is successful but that's not particularly effective to do just with Bootstrap.

Got it. It works. But it is not obvious to the user what is happening. Can some kind of notice be given that attribution has been copied to clipboard?

Suggest maybe change the button class?

We now pop an alert area under the Copy Attribution button that tells the user they have copied successfully.
It would look better above or beside the button, but above would move the button and might cause the user to click in the wrong place, and beside would end up under the button anyway on smaller devices.


Remove dependency on istio/proxy Dockerfiles

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a6aa1b6bf1f17fde723827a52e9fcb60aa3018b7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a6aa1b6bf1f17fde723827a52e9fcb60aa3018b7
link
/test istio-unit-tests

prow/istio-presubmit.sh
a6aa1b6bf1f17fde723827a52e9fcb60aa3018b7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a6aa1b6bf1f17fde723827a52e9fcb60aa3018b7
link
/test istio-unit-tests

prow/istio-presubmit.sh
596e4237003db8c0cca836ddc20f23227a1828fc
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
596e4237003db8c0cca836ddc20f23227a1828fc
link
/test istio-presubmit

prow/istio-unit-tests.sh
596e4237003db8c0cca836ddc20f23227a1828fc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
596e4237003db8c0cca836ddc20f23227a1828fc
link
/test istio-unit-tests

prow/istio-presubmit.sh
ed9a01fb34369e6902cd2726c749a7a0b424dd0b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
ed9a01fb34369e6902cd2726c749a7a0b424dd0b
link
/test istio-presubmit

prow/istio-unit-tests.sh
cd502777f5ca5fea0a9897ead1cb310621602eb1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
cd502777f5ca5fea0a9897ead1cb310621602eb1
link
/test istio-unit-tests

prow/istio-presubmit.sh
cd502777f5ca5fea0a9897ead1cb310621602eb1
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Regarding "make init", but name it might be intended to run once but "make depend" is mostly just an alias for init.  I'm not sure we really have any 1-time update steps anymore.  Up until now (though a recent PR may have or is soon to change this) bin/init.sh has/had mostly been reduced to downloading the envoy binary from the proxy repo, which is more like a dependency update (i.e., something you want to see updated each time you pull in newer changes from a repo) than a 1-time update.

And thanks for doing this !!!

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-simple

prow/istio-unit-tests.sh
96e83335a1997455bff448c36f44e2e66e82956e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-simple

prow/istio-unit-tests.sh
96e83335a1997455bff448c36f44e2e66e82956e
link
/test istio-unit-tests

prow/istio-presubmit.sh
96e83335a1997455bff448c36f44e2e66e82956e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-simple

prow/istio-presubmit.sh
96e83335a1997455bff448c36f44e2e66e82956e
link
/test istio-presubmit

prow/istio-unit-tests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
52413be3a48a3c93130e433a368ede20d9b764c1
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
fcb3a72c224003165f0c6df174dff61012ff1250
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6d7f732ffd82d00ae806764332129b02de8be66e
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
6d7f732ffd82d00ae806764332129b02de8be66e
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
6d7f732ffd82d00ae806764332129b02de8be66e
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


IBMCloud target resource not working properly

Hi,
We recently ran into the issue where targetting all the orgs under my cf , I cannot login to it -
bash-3.2$ ibmcloud target -cf
IBM Cloud Foundry Public is deprecated. For more information, see http://ibm.biz/ibmcf-announce
Targeted Cloud Foundry (https://api.us-south.cf.cloud.ibm.com)
Targeted org Abhijit.Thakur
Targeted space test
API endpoint:      https://cloud.ibm.com
Region:            us-south
User<EMAIL_ADDRESS>Account:           Abhijit Thakur's Account (6b9e1afb31ebb7b48f9edd1c8fb64a5a)
Resource group:    No resource group targeted, use 'ibmcloud target -g RESOURCE_GROUP'
CF API endpoint:   https://api.us-south.cf.cloud.ibm.com (API version: 2.182.0)
Org:               Abhijit.Thakur
Space:             test
bash-3.2$ Ibmcloud cf orgs
Invoking 'cf orgs'...
Getting orgs as<EMAIL_ADDRESS>name
Abhijit.Thakur
TJBot Blue Hack Austin
bash-3.2$ ibmcloud
bash-3.2$ cf target -o 'FabLab-MainOrg
bash-3.2$ ibmcloud target -o 'Abhijit.Thakur'
Targeted org Abhijit.Thakur
API endpoint:      https://cloud.ibm.com
Region:            us-south
User<EMAIL_ADDRESS>Account:           Abhijit Thakur's Account (6b9e1afb31ebb7b48f9edd1c8fb64a5a)
Resource group:    No resource group targeted, use 'ibmcloud target -g RESOURCE_GROUP'
CF API endpoint:   https://api.us-south.cf.cloud.ibm.com (API version: 2.182.0)
Org:               Abhijit.Thakur
Space:
bash-3.2$ ibmcloud target -o 'TJBot Blue Hack Austin'
FAILED
Could not get org:
Org 'TJBot Blue Hack Austin' was not found under account 'Abhijit Thakur's Account'.
bash-3.2$
If we try it using just cloud doundry cli , we don't runinto this issue.
Can you please let us know if this is by design and if so what is the explaination for it.

Please notice that the ibmcloud target commands that are failing are the ones aiming to target to a CF Org of the same region but owned by a different IBM Cloud Account.
We looked for such limitation into the docs but there is nothing explaining this behaviour

As we discussed in another thread, the targeting is purposely within the account, not across accounts. This is a convention that the CLI  enforces and is common in IBM Cloud.


fixes:"Created-at" section peeping out of "Doctor's discussion"

Proposed Changes

Fixes #8795
Change z-index to 10

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

@Sulochan-khadka the issue still persist

@Sulochan-khadka when you are making a PR please make sure that its working. I would highly recommend you to complete the Merge checklist when you submit a PR.

[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.

☝ we have added this in the merge checklist for the author to catch accidental bugs that he maynot have caught, a demo would actually be help them discover it better.

@nihal467 @bodhish Apologies for the inconvenience caused. Actually i only explored the bug in patient's notes and not in discussion notes. Therefore, was a bit confused. Have solved both the bugs...
Patent's notes:

Discussion notes:

@Sulochan-khadka Can you resolve the conflicts?

@Sulochan-khadka Can you resolve the conflicts?

While merging , it is showing error in this line :
"import { pluginMap } from "./pluginMap"; " Does this file exists. @nihal467 @rithviknishad

While merging , it is showing error in this line : "import { pluginMap } from "./pluginMap"; " Does this file exists. @nihal467 @rithviknishad

https://github.com/ohcnetwork/care_fe?tab=readme-ov-file#install-the-required-dependencies will create the file


respond-cart taxRate wrong override

There is a bug on respond-cart.html component at line # 353 which will break tax calculation on cart.
this.taxRate = 0;

this line overrides this.taxRate set before on line # 320 this.taxRate = parseFloat(respond.site.settings.TaxRate);
BUGFIX: remove line # 353

Closing issues not related to R6.


WIP: Have all CEGUI deps build via CMake and come from submodules

Still a recursive cmake configure and build call, but this is better than the previous solution (static linking on Linux!)
Problems are as follows:

./ext/CEGUI/CMakeLists.txt doesn't see the value of $CEGUI_DEPS_INSTALL_PATH
_d suffix does not get added to Debug builds of dependencies and Release builds probably overwrite them when installing

The result is that irr::ext::CEGUI doesn't build on Linux, on Windows it builds but doesn't link.
Cosmetic:

glew installs binary utils and shared libs, even though I tell it not to build those
pcre installs and builds the docs and man pages

@Crisspl @Przemog1 if you can help fix in spare time (in July), that'd be great!


Add adr 9 for react-bootstrap

Coverage remained the same at 87.994% when pulling 52957339ec01510f02de3fa1b8ac1a0890932a9f on abutterworth/react-bootstrap-adr into 74c64c3ab3bd3089152146237ce227b70bb89229 on master.

It goes without saying, but this does have the effect of tying us closer to Bootstrap and further from any sort of CSS-in-JS solution.  @abutterworth, do you think CSS-in-JS is still an important option for us?  It was going to be a heavy lift if we decided to do it, but now it'll be even heavier.  For those following along, we'd discussed CSS-in-JS as being a useful way of isolating our CSS by co-locating it with components, reducing our CSS footprint, and potentially easing theming by adopting something like emotion-theming.
This is potentially just fine, but I wanted to bring it up for the sake of completion.

My only concern with this approach is related to a11y. Are there plans to audit the react-bootstrap components and identify/fix any a11y gaps?

@davidjoy I think this may actually help us decouple from Bootstrap. Today, many Bootstrap components are written as html in our applications – this change would reduce that by pulling those components into Paragon. These new shim components we create to pass through react-bootstrap components can then be the single point to swap technology for any future innovation that takes us beyond Bootstrap.
I think CSS-in-JS is a good future for us. If we choose to adopt it we should do it iteratively (and therefore in a way that is compatible with Bootstrap being present on the page). I imagine a future where we adopt new technology by replacing our react-bootstrap shims 1 by 1 (removing sections of bootstrap scss along the way).

@AlasdairSwan I'll reach out to @wittjeff to request reviews of these components as we pull them in.

@wittjeff has done a quick a11y sniff test on the react-bootstrap components here: https://docs.google.com/spreadsheets/d/1FR42auyyFPfOLenlcj6OLuYZ7NU0aBTZvYIM58iSElQ/edit#gid=0
I'll update this PR to reflect the following plan:

For the 19 components that pass our initial audit we will pull them in
For the 8 that do not we will make upstream changes. Or, if they are needed urgently we will enforce a11y requirements in the shim component.

:tada: This PR is included in version 9.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature request] Could see the original line of assert statement

Do you want to request a feature or report a bug?
I want to request a feature
What is the current behavior?
test('Should return jwt after successfully registration', async () => {
        await removeTestUser();
        const response = await request(app).post(signupAPI).send(testUser);
        expect(response.statusCode).toBe(200);
        expect(response.body).not.toHaveProperty('error');
        expect(response.body).toHaveProperty('user');
        expect(response.body.user.name).toBeDefined();
        expect(response.body.user.email).toBeDefined();
        expect(response.body.user.token).toBeDefined();
        await removeTestUser();
    });

I use supertest + jest to test my express.js application, all use the latest version.
The test runs fine. The problem is, if there is anything wrong, the output would be:
 ● [API Test] /api/auth/register › Should return jwt after successfully registration

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at _callee8$ (tests/backend/integration/signup.test.js:98:57)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:65:40)

Some situation like this, If the value is undefined,
And I happen to have multiple same assert,
There is no way to see the reason in the bash,
I need to track back to the file to see which line threw the error.
Yes, I should track back, but wouldn't it better to show a result like below:
What is the expected behavior?
 ● [API Test] /api/auth/register › Should return jwt after successfully registration

    expect(response.body.user.name).toBeDefined()

    Expected response.body.user.name to be defined, instead received
      undefined

      at _callee8$ (tests/backend/integration/signup.test.js:98:57)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:65:40)

Thanks :) Love jest.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
{
  "verbose": true,
  "rootDir": "../",
  "testPathIgnorePatterns": ["<rootDir>/node_modules/", "<rootDir>/tests/acceptance/", "<rootDir>/tests/coverageReport/", "<rootDir>/dist/"],
  "collectCoverage": false,
  "coverageDirectory": "tests/coverageReport",
  "collectCoverageFrom" : ["**/src/**"],
  "coveragePathIgnorePatterns": ["<rootDir>/node_modules/", "<rootDir>/configs/", "<rootDir>/src/config/appconfig.json", "<rootDir>/dist/"],
  "coverageReporters": ["text", "text-summary"]
}

Jest now only has access to a value carried by response.body.user.name, that's why it shows generic message. Wonder how we could make it better.

Maybe it's possible to do something along the lines of Ava, which displays the code around the failed assertion?

See e.g. https://github.com/avajs/ava#magic-assert and https://github.com/avajs/ava#snapshot-testing

I cannot reproduce this.
test('renders fallback', async () => {
    const res = await request(app).get('/footer/fallback');

    expect(res.status).toBe(201);

    expect(prettifyMarkup(res.text)).toMatchSnapshot();
})

  ● renders fallback

    expect(received).toBe(expected)

    Expected value to be (using ===):
      201
    Received:
      200

      at _callee$ (routes/podlet-footer/test/e2e.test.js:27:40)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:296:22)
      at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:114:21)
      at step (routes/podlet-footer/test/e2e.test.js:1:287)
      at routes/podlet-footer/test/e2e.test.js:1:447
          at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

The top of the stack trace matches the line in my code

But I suppose in general actually showing the place in code, but that's tracked in https://github.com/facebook/jest/issues/3415


Field middleware not working for introspection fields

Describe the bug
Field middleware is not executing for introspection fields
To Reproduce
Steps to reproduce the behavior:

Please check https://github.com/ChilliCream/hotchocolate/pull/852
Data for introspection field is not touched

Expected behavior
Middleware should work for all fields. As an option, could you please suggest how I can distinguish introspection query and add additional logic for it.
Desktop (please complete the following information):

OS: Windows 10
Version 9.0.4

Sorry for the wait ... will tell you how this works tomorrow.

@michaelstaib , sorry for disturbing you, but could you please point me to the right place where I can add additional security check (special scope) for introspection query?
Thanks in advance

Hi, sorry for letting that hang so long. When we designed hc we did on purpose exclude middlewares from introspection resolvers since by adding transformations you could make your server non-spec compliant.
Reflecting on that we could opt to allow this with an additional schema option. I will move this to the next release.

OK, this one is supported with 9.1 preview 44
[Fact]
        public async Task FieldMiddlewareHasAnEffectOnIntrospectIfSwitchedOn()
        {
            // arrange
            string query = "{ __typename a }";

            ISchema schema = SchemaBuilder.New()
                .AddQueryType<Query>()
                .Use(next => async context =>
                {
                    await next.Invoke(context);

                    if (context.Result is string s)
                    {
                        context.Result = s.ToUpperInvariant();
                    }
                })
                .ModifyOptions(o =>
                    o.FieldMiddleware = FieldMiddlewareApplication.AllFields)
                .Create();

            IQueryExecutor executor = schema.MakeExecutable();

            // act
            IExecutionResult result = await executor.ExecuteAsync(query);

            // assert
            Assert.Empty(result.Errors);
            result.MatchSnapshot();
        }


Allow running npm audit without node_modules

Is your feature request related to a problem? Please describe.
Currently, jf audit-npm requires the presence of node_modules.
Describe the solution you'd like to see
We can bypass it in npm >= 7 if we provide the --package-lock-only, like we do in Intellij IDEA plugin: https://github.com/jfrog/ide-plugins-common/pull/71
Describe alternatives you've considered
Running npm install before audit.
Additional context
It looks like the audit-npm tries to resolve the sha256 files from the npm cache. We probably don't really need them in the npm-audit.

Fixed by https://github.com/jfrog/jfrog-cli/issues/1473


fix(ecau): gracefully reject Amazon Music pages

Amazon made it very difficult to extract cover art from these pages, so for now, we'll drop support for them. See #611.
Closes #611.

It doesn't really make sense to do the translation anymore, since it'll translate to the unsupported page anyway, so let's just always throw there too. I've opted to throw the error rather than outright removing the provider, as I don't want to rule out the possibility of re-adding support if the situation changes in the future.

Yeah, that makes sense. The only thing which is left now is updating supported_providers.md.


v1: fix command always LOCAL

The changes in #61 overrides all header.Command to LOCAL (which was set to PROXY by initVersion1) unconditionally.
https://github.com/pires/go-proxyproto/blob/b6f440c01c68bf65792f463adcc71eb620fb0484/v1.go#L55-L60
This makes these functions returning the original addresses rather than the addresses contained in the proxy header.
https://github.com/pires/go-proxyproto/blob/b6f440c01c68bf65792f463adcc71eb620fb0484/protocol.go#L127-L155
Unfortunately, the problem was not revealed, since the EqualsTo function, which is used by the tests to compare actual and expected headers, straightly returns true when the command is LOCAL, and the command is not being compared.
https://github.com/pires/go-proxyproto/blob/b6f440c01c68bf65792f463adcc71eb620fb0484/header.go#L150-L170
This PR also updated the condition that checks the token length, made it to make sense.
The comments for ProtocolVersionAndCommand are also updated, made it less confusing.

Coverage decreased (-0.2%) to 93.967% when pulling 45d2fa61a35c2a9126a680fe7c3d1af254f01978 on bohanyang:fix-v1-command into b6f440c01c68bf65792f463adcc71eb620fb0484 on pires:main.

Coverage decreased (-0.2%) to 93.967% when pulling 45d2fa61a35c2a9126a680fe7c3d1af254f01978 on bohanyang:fix-v1-command into b6f440c01c68bf65792f463adcc71eb620fb0484 on pires:main.

Done fixing the comments!

Done fixing the comments!

https://github.com/pires/go-proxyproto/releases/tag/v0.4.2

https://github.com/pires/go-proxyproto/releases/tag/v0.4.2


No support for canon lasor printer. (CAPT Printer Driver for Linux)

I want to use LBP-3050 printer but there is no driver.
I would love to create a package for it but don't know how to start.
While I am researching, if anyone can help, feel free to post any suggestion.
This is link to printer driver.
The problem I try to solve / progress so far:
[ ] I don't understand the license, is direct fetching allowed?
[ ] There was no direct-link to use with fetchurl
[ ] I will create WIP PR when I have some progress

AFAIK, you can do it without installing CAPT driver.

Download and extract driver
cd ./Src
tar -xf cndrvcups-capt-2.71-1.tar.gz
./cndrvcups-capt-2.71/ppd/ will contain bunch of .ppd files. Often it is all you need to install a printer
Install printer via CUPS using file CNCUPSLBP3050CAPTK.ppd

As for download link, you can get link of downloaded file from browser. For me it is http://gdlp01.c-wss.com/gds/6/0100004596/05/linux-capt-drv-v271-uken.tar.gz and it works from several locations.
Fetching does not seem to be restricted by license, and wget works fine.

Thank you but my printer just broke yesterday, :(
I will leave this issue opened for others to confirm your solution.

If anyone still want to do this there are some example of compiling instruction I have found.

arch aur
some random github makefile

I am still trying to build the driver here but have no success when the build is done without any error I will open the PR to fix this issue.
If anyone can help me please take a look.

I don't know what about yours, but it seems like there is another community effort in reverse engineering these printers https://github.com/mounaiban/captdriver/wiki#supported-devices
I do test it recently via canon-capt already packaged in NixOS and it works quite great for me. Maybe you can try to test it? @wizzup

Probably I will close this issue for now.


report liquidity error when not enough funds in default strategies

report liquidity error when not enough funds in default strategies. This is how the error looks like (next to Origin Vault) in the UI

**connected issue:**https://github.com/OriginProtocol/origin-dollar/issues/906

Thanks both concerns are valid points. Interestingly when I was measuring with & without the check when doing a redeem on a forked node there was a 40399 gas difference. Not 120k in my case but still substantial increase.
I see 2 possible solutions:

move this calculation into a helper contract and expose it as a non payable function
add try/catch block around the withdrawal code and assume (sometimes oncorrectly?) if it fails on that line it is a liquidity error

None of the solutions are ideal.. How do you feel about them @DanielVF ?

Thanks for the feedback @DanielVF . Have updated the solution where all the error handling is done on the dapp side.


Removed label dependency for before/after

REDMINE#17372

[X] Remove dependency between label width and slider initial position

Removed max-width for label of before/after content element, which was causing the long labels to break in to different lines.

Coverage remained the same at 99.208% when pulling c0ccdd24288a9309a945579c01e1328e4b0f26cf on UsmanMuhammad:remove-label-dependency into 50ad5ca62f61b5d1780900664b50eadc4276a273 on codevise:master.


Automatically add Commons Geocoding Template from the GPS data stored in image

The MediaWiki API only finds images that have been explicitly geocoded, i.e. the Locations template added to the Commons page. The web-based Upload Wizard automatically adds the Location template, but our app doesn't seem to do it. This hampers categorization of future uploaded pics with similar coordinates, as the newly-implemented GPS categorization depends on finding nearby pictures.

Is this already in the app? I uploaded this image, and a bot had to read out the coordinates:
https://commons.wikimedia.org/wiki/File:Vermarkungspunkt_of_the_Austrian_Post.jpeg

Hi @tobias47n9e , this feature has been scheduled for implementation by October, as per the timeline. Sorry for the wait! :)

@misaochan Thanks. Will be looking forward to this.

Just confirming that the {{Location|lat|long}} template described at https://commons.wikimedia.org/wiki/Commons:Geocoding will be appropriate for this?

I think so. Are there any other parameters you will set in the template?

No, I don't think so. Do you think any other parameters will be necessary?

Just checked and I don't think we need to add precision. Does the location API give the standard deviation of the current position measurement? In a canyon with few visible GPS satellites the measurement can be off by 100s of km.

As far as I know, the Android location API doesn't.

Picture that I uploaded to test my PR branch: https://commons.wikimedia.org/wiki/File:Punnet_Strawberry_Farm.jpg
The template seems to work, I think.

This has been released - please let me know if it works properly for you. It seems to work for my pictures.

It works!

Great! :) @nicolas-raoul , do you think this is okay to close?

Great!


图像中多条线条存在，后面的线条会覆盖前面的线条，希望图像展示可以自定义层级覆盖逻辑

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?
图像展示可以自定义层级覆盖逻辑
What does the proposed API look like?
可以使用类似z-index的属性标识图像的层级

我也遇到了同样的问题 请问是咋解决的呢


Hyprland workspaces hosting-monitor css class

Adds the css class onThisMonitor.
This will make it possible to only style the waybar that a workspace is on.
Example:
#workspaces .onThisMonitor {
  color:blue;
}

/* waybar of monitor 1 with workspace A open:   [    A       B    ]
 *                                                  blue   white
 *
 * waybar of monitor 2 with workspace B open:   [    A       B    ]
 *                                                 white    blue
 */

Closes #2959

That is already possible with the current classes.

Sorry for the wait.
I went with hosting-monitor for the css class name.

LGTM, thx!
Can you also add the new option to the github wiki?


Azerbaijani (Cyrillic)  Kazakh (Cyrillic)  Kyrgyz (Cyrillic)  Tajik (Cyrillic)  Tatar (Cyrillic)  Uzbek (Cyrillic)

I have tested this language over and over again and also managed to get the screenshots of the books to make sure that nothing is missed. I really like the script shifter and was hoping that it would work well for Cyrillic Azeri since Latin Azeri was not part of it. But as I mentioned earlier unfortunately it doesn't work for certain letters. I will try to if I can insert the examples : This is the title of the book (LCCN#00655035 ) in original Azeri Cyrillic ( I have a screenshot of the cover and title page) Азəрбајҹан Совет əдəбијјатынын поетика мəсəлəлəри : ǂb елми əсəрлəрин тематик мəҹмyеси This is how the ScriptShifter romanized it Azərbai̐jan Sovet ədəbиi̐i̐atыnыn poetиka məsələlərи : ǂb elmи əsərlərиn tematиk məjmyesи This is how correctly it should have been romanized based on LC-ALA romanization table Azărbai̐jan Sovet ădăbii̐i̐atynyn poetika măsălălări : ǂb elmi ăsărlărin tematik măjmu̇esi I will highlight which of the letters were correctly romanized and which failed: This how this letter looks like in the table: Vernacular Romanization ә ă While in some other instances this letter was romanized fine in this particular case as you can see it stayed as vernacular during the romanization process. These two letters: ј,ҹ were romanized correctly both in the 1st word of the tile and others based on the table: ј i̐ ҹ j The next incorrectly romanized letter is a basic и which should be represented by i и i The next incorrect letter is ы which should have been romanized as y ы y The last incorrect letter which is contained in the last word "мəҹмyеси" is the letter "ү" which should have been romanized as u̇ ү u̇ I want to repeat that I have tested several titles. This is a second example: Азәрбајҹан XXI әсрин астанасында" Республика елми-практики конфрансынын : материаллары Azărbai̐jan XXI ăsrиn astanasыnda" Respublиka elmи-praktиkи konfransыnыn : materиallarы The set of letters here is more limited but the in accuracies with the romanization are almost the same. What surprised me here was the fact that ә in the first word "Азәрбајҹан" was romanized correctly which was not a case in previous example. BBut the problem with the letters и and ы stayed the same.

ә -> ă: the issue is with the source letter, which in the reporter's text is ə (Latin Small Letter Schwa, U+0259) while Scriptshifter has a configuration entry for ә (Cyrillic Small Letter Schwa, U+04D9)
ј, ҹ are not a problem, correct?
и (U+0438), ы (U+044B): these are bona fide table errors. Azerbaijani inherits from _cyrillic_base, and these letters are not defined in either table.
y in мəҹмyеси: this is also an issue with the source string, which has is a Latin "y" letter rather than ү (U+04AF), which is correctly mapped in both upper- and lowercase.

Greetings Matt and Stefano,
As I was looking though this post and preparing to the meeting with Rachel today, it suddenly occurred to me why it was decided not to include Azeri Latin in the script shifter.  What was this decision based upon. we are talking about few peculiar letters and some diacritics. I realize that this might not be one of your top priority languages but if it doen't need much work then why not?  Thanks.  Muzhgan.

I just met with Muzhgan about these issues.

I agree with Muzhgan that adding a handful of Latin letters might be worth our time. Someone using U+0259 in Azerbaijani they are transliterating almost certainly means to use U+04D9. As a test to make sure I am doing the process correctly, I am adding that to the table, in upper and lower case, in only the script_to_roman section because that is the only area the mistaken character is significant. Please let me know what you think.
@scossu, you are correct, ј and ҹ are not a problem.
Thank you for adding those letters!
Since an accidental Latin "y" (U+0079) could be intended to be "у" (U+0443) or "ү" (U+04AF) in Azerbaijani, it is not as simple to assume what letter is meant, so I did not add anything for that.
This would need to be entered as a different issue if possible, but would it be possible to add a flag when there are untransliterated Latin-block Unicode characters, or highlight them in some way in the output? Apologies if that has already been discussed in an office hours and I forgot.

Dear Stefano,
We just worked on Azeri script with Rachel and did not touch any other scripts mentioned.  Thank you. Muzhgan.
From: Stefano Cossu @.>
Sent: Thursday, August 24, 2023 6:25 PM
To: lcnetdev/scriptshifter @.>
Cc: Nazarova, Muzhgan @.>; Comment @.>
Subject: Re: [lcnetdev/scriptshifter] Azerbaijani (Cyrillic) Kazakh (Cyrillic) Kyrgyz (Cyrillic) Tajik (Cyrillic) Tatar (Cyrillic) Uzbek (Cyrillic) (Issue #14)
CAUTION: This email message has been received from an external source. Please use caution when opening attachments, or clicking on links.
Closed #14https://urldefense.com/v3/__https://github.com/lcnetdev/scriptshifter/issues/14__;!!EDx7F7x-0XSOB8YS_BQ!Z26sNs_ykG9kchIdkodAwRm1b3MNyUyNO3DBoWq6zNs3ZXHepPUY2SaoMMcpqb5qSS9jvveloQxRnJl5RYlusg$ as completed via #44https://urldefense.com/v3/__https://github.com/lcnetdev/scriptshifter/pull/44__;!!EDx7F7x-0XSOB8YS_BQ!Z26sNs_ykG9kchIdkodAwRm1b3MNyUyNO3DBoWq6zNs3ZXHepPUY2SaoMMcpqb5qSS9jvveloQxRnJl1QamWZQ$.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/lcnetdev/scriptshifter/issues/14*event-10186587514__;Iw!!EDx7F7x-0XSOB8YS_BQ!Z26sNs_ykG9kchIdkodAwRm1b3MNyUyNO3DBoWq6zNs3ZXHepPUY2SaoMMcpqb5qSS9jvveloQxRnJmus72U7A$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BB6TFQQ65RHBFNBSZXL3OP3XW7IDXANCNFSM6AAAAAAT57NCBY__;!!EDx7F7x-0XSOB8YS_BQ!Z26sNs_ykG9kchIdkodAwRm1b3MNyUyNO3DBoWq6zNs3ZXHepPUY2SaoMMcpqb5qSS9jvveloQxRnJlqIArN2Q$.
You are receiving this because you commented.Message ID: @.***>

Dear Muzhgan,
That is okay, I think the title was from the list of language experts, I do not think Stefano thinks all of those scripts are now perfect. We will add new tickets/issues to track the specific problems you find in the other languages, or if you find new issues with Azeri script.
Thank you,
Rachel

Thanks, Rachel. Muzhgan.
From: "rrroche"<EMAIL_ADDRESS>Subject: [lcnetdev/scriptshifter] Azerbaijani (Cyrillic) Kazakh (Cyrillic) Kyrgyz (Cyrillic) Tajik (Cyrillic) Tatar (Cyrillic) Uzbek (Cyrillic) (Issue #14)
Date: 25 August 2023 09:32
To: "lcnetdev/scriptshifter"<EMAIL_ADDRESS>Cc: "Nazarova, Muzhgan"<EMAIL_ADDRESS>"Comment"<EMAIL_ADDRESS>CAUTION: This email message has been received from an external source. Please use caution when opening attachments, or clicking on links.
Dear Muzhgan,
That is okay, I think the title was from the list of language experts, I do not think Stefano thinks all of those scripts are now perfect. We will add new tickets/issues to track the specific problems you find in the other languages, or if you find new issues with Azeri script.
Thank you,
Rachel
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/lcnetdev/scriptshifter/issues/14*issuecomment-1693367348__;Iw!!EDx7F7x-0XSOB8YS_BQ!csMTqaoXhdbJwbgrxaet2uX5KiAT89sjbjsXRrdu6kwFURLAFrJtBrx2_j5-q5LT9d0pDUtZ8CEhVeG2SHwoMg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BB6TFQRX7PZJ36LIM6NGER3XXCSLTANCNFSM6AAAAAAT57NCBY__;!!EDx7F7x-0XSOB8YS_BQ!csMTqaoXhdbJwbgrxaet2uX5KiAT89sjbjsXRrdu6kwFURLAFrJtBrx2_j5-q5LT9d0pDUtZ8CEhVeGjPXQvfQ$.
You are receiving this because you commented.Message ID: @.***>


[fix][client] Fix clearIncomingMessages so that it doesn't leak memory while new entries are added

Motivation
The current ConsumerBase.clearIncomingMessage has a race condition when using Shared or Key_Shared subscription type.
https://github.com/apache/pulsar/blob/69a45a11e22c1d963391110fb3488c9b9f98f759/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java#L1224-L1229
When using Shared or Key_Shared, this method is called in redeliverUnacknowledgedMessages while new entries are flowing to the client. This would leak memory and memory limit counters would get skewed.
Modifications

Pull messages from the queue and release them one by one.
Return the number of messages that were removed.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (69a45a1) 73.43% compared to head (7f4bd25) 73.40%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #21767      +/-   ##
============================================
- Coverage     73.43%   73.40%   -0.03%
+ Complexity    32798    32772      -26
============================================
  Files          1897     1897
  Lines        140647   140646       -1
  Branches      15489    15491       +2
============================================
- Hits         103290   103248      -42
- Misses        29283    29316      +33
- Partials       8074     8082       +8

Flag
Coverage Δ

inttests
24.19% <34.37%> (+0.02%)
:arrow_up:

systests
24.79% <34.37%> (+0.03%)
:arrow_up:

unittests
72.69% <84.37%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...a/org/apache/pulsar/client/impl/RawReaderImpl.java
83.65% <100.00%> (ø)

...va/org/apache/pulsar/client/impl/ConsumerBase.java
73.83% <100.00%> (-0.30%)
:arrow_down:

...he/pulsar/client/impl/MultiTopicsConsumerImpl.java
77.87% <100.00%> (-0.71%)
:arrow_down:

...ache/pulsar/client/impl/ZeroQueueConsumerImpl.java
66.25% <50.00%> (+0.81%)
:arrow_up:

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
78.00% <78.94%> (-0.02%)
:arrow_down:

... and 53 files with indirect coverage changes

Hi @lhotari, is it possible to reproduce the issue? Or is it possible to inject some delay to reproduce the issue with a test? So that we can avoid regression and easily understand what problem is fixed.

Hi @lhotari, is it possible to reproduce the issue? Or is it possible to inject some delay to reproduce the issue with a test? So that we can avoid regression and easily understand what problem is fixed.

@codelipenghui I'll try to do that. However, it's pretty clear from the code that there are multiple race conditions that this PR would address.
One of the races is caused by the NoOpLock used for shared subscription.

One issue that I was able to reproduce, I haven't yet checked whether this PR fixes the problem. The repro app might be about a different issue.
A very messy repro app that does nasty things: https://github.com/lhotari/pulsar-playground/blob/lh-PR21767-investigation/src/main/java/com/github/lhotari/pulsar/playground/TestScenarioIssueRedeliveries.java
repro:
git clone -b lh-PR21767-investigation https://github.com/lhotari/pulsar-playground
cd pulsar-playground
./gradlew shadowJar
# start Pulsar in docker in the background
docker run --rm --name pulsar-standalone -d -p 8080:8080 -p 6650:6650 apachepulsar/pulsar:3.1.1 /pulsar/bin/pulsar standalone -nss -nfw
# wait a few seconds for Pulsar to start
sleep 5
# run the test app using the shadow jar with all dependencies
java -cp build/libs/pulsar-playground-all.jar com.github.lhotari.pulsar.playground.TestScenarioIssueRedeliveries
# stop and remove Pulsar in docker
docker stop pulsar-standalone

All messages should be eventually received. In the test case, about 5 to 15 out of 10000 are usually lost.
The test app prints how many are remaining (lost)
[main] INFO com.github.lhotari.pulsar.playground.TestScenarioIssueRedeliveries - Done receiving. Remaining: 10 duplicates: 8704 reconsumed: 985
[main] ERROR com.github.lhotari.pulsar.playground.TestScenarioIssueRedeliveries - Not all messages received. Remaining: 10

UPDATE 3 about the repro app:
When I increase the number of messages to 1M, the processing gets stuck in a loop where it's only the redelivered messages that keep on rotating. That is expected in many ways when there's a frequent call to consumer.redeliverUnacknowledgedMessages(). Calling that method is causing issues. I wonder how many Pulsar applications in the wild contain this type of mistake?
Could we improve the documentation for redeliverUnacknowledgedMessages to reduce confusion? What is a valid use case to use this method? Is it really needed in the user level API?
Since failover/shared subscription types are essentially calling consumer.redeliverUnacknowledgedMessages() under the covers, it's possible that a Pulsar application gets into this vicious cycle where the number of failed messages is very high and very little progress, or in worst case no progress, will be made between the redelivery calls. There is the consumer epoch solution to help with the problem, but I could see how it doesn't help prevent the situation when there's a large amount of messages that are in redelivery and it keeps the loop between the client and the broker busy.
It seems that such a problem could be detected from the relivery counters in topic stats, but that's something that isn't visible in Grafana / Prometheus metrics directly, IIRC.
In most cases the situation would get resolved after a while, but only after burning a lot of CPU cycles and transferred bytes across the network. I wonder if there's a better way to deal with high error rates in Pulsar?


Upgrade Mailbox Beta.app to v0.7

Thank you for your contribution! However, @szhu has made a PR with version 0.7.1 so this one is superseded by https://github.com/caskroom/homebrew-cask/pull/13353. Better luck next time and sorry for all the inconvenience.


Support for NATS.io

Streaming market data to a target application via NATS.io
https://nats.io
https://github.com/nats-io/python-nats
https://github.com/nats-io/asyncio-nats

Thanks for your suggestion. I will investigate it. :)


PMID:18093330

child of FYPO:0001249
increased origin firing efficiency in subtelomeric heterochromatin

increased origin firing efficiency in subtelomeric heterochromatin FYPO:0007068
edit file: 114cdf13de728d46a2edc8df48ad44e699753af4
release: f39d67cf78a0e54b72f8640494fba5de2839405c


Add load balacing algorithm type

what

Expose the target group load_balancing_algorithm_type configuration as a variable.

why

I would like to change from the default round_robin to least_outstanding_requests.

/docs

/docs

/rebuild-review

/rebuild-review

/rebuild-readme

/rebuild-readme

/test all

/test all

/rebuild-readme

/rebuild-readme

/test all

/test all


wsl1  The specified network name is no longer available

Environment
Windows build number:  10.0.19042.867]
Your Distribution version: Ubuntu-20.04
Whether the issue is on WSL 2 and/or WSL 1: WSL 1

Steps to reproduce

WSL logs:  https://aka.ms/AAbr57v
Expected behavior

I can start Ubuntu 20.04 by inputting bash through windows + R
Actual behavior

wsl2 和VMware冲突
@.***
From: therealkenc
Date: 2021-04-01 02:53
To: microsoft/WSL
CC: Iatbzh; Author
Subject: Re: [microsoft/WSL] wsl1 The specified network name is no longer available (#6736)
There is no way to tell what might have happened in the 20 days for a repro. Suggestion would be to install a WSL2 distro.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

There is a conflict between wsl2 and VMware. Although there are improvement methods, it will make VMware difficult to use, so I choose the combination of wsl1 and VMware. However, at present, this problem appears after I update the system patch during this period, so I hope to solve this problem

没有办法告诉您20天内可能发生的问题。建议是安装WSL2发行版。
There is a conflict between wsl2 and VMware. Although there are improvement methods, it will make VMware difficult to use, so I choose the combination of wsl1 and VMware. However, at present, this problem appears after I update the system patch during this period, so I hope to solve this problem

There is no way to tell what might have happened in the 20 days for a repro. Suggestion would be to install a WSL2 distro.
I've made an update. Please check. There are logs and screenshots in the feedback center

need-repro
I am running into: Version 10.0.19042 Build 19042
Bash failure-launch
Ubuntu 20.04 LST: failed with error 0x8000000d , error illegal state change was requested


How do we add node?

NVM is already added to the brewfile, now how do we automate downloading the latest stable node version?
is it a good idea to do so everytime dotfiles are installed? (unexpected change of the node version)

Solved here by adding a setup_node script


HDDS-10248. Remove unused, dead code in hdds-client module

What changes were proposed in this pull request?
Removing dead code from hdds-client module. Dead code besides that it is not used can be harmful, if someone starts to use it, as it was not used it might not have been updated either along with similar functionality, so it is better to get rid of it.
Please describe your PR in detail:
The PR is, removing unused code from hdds-client module.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10248
How was this patch tested?
Functionality should not be changing, if the code compiles, and existing tests are running fine, that pretty much proves that we did not needed these methods.
On the other hand, due to potential reflective access it is hard to prove that complete methods are not called, therefore I ran a search for the method name in the codebase and checked for that manually.

Minor cleanup needed
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/HddsClientUtils.java
 21: Unused import - java.time.ZoneId.
 22: Unused import - java.time.format.DateTimeFormatter.

@fapifta please wait for clean CI run in your fork before opening PR

Thanks @fapifta for the cleanup, @kerneltime for the review.


Implement non-streaming V2 GRPC API calls.

Purpose
The client currently interacts with the V1 GRPC API exposed by the node. Migrating it to use the V2 GRPC API has a number of advantages, including, but perhaps not limited to better types and payload deserialization using code generated from protocol buffer schemas.
This PR concerns itself with implementing the non-streaming V2 GRPC node API calls. The changes implement the non-streaming API calls of the V2 GRPC API as well as functionality for translating between generated protocol buffer schema types and their native (Concordium) Haskell type equivalents. Specifically, this translation is used for interface parameters and return values.
Depends on
https://github.com/Concordium/concordium-base/pull/307
Changes
Implementation of helpers and API calls:

Implement (non-streaming) V2 GRPC API call helper(s)
Implement (non-streaming) V2 GRPC API calls

shutdown
peerConnect
peerDisconnect
getBannedPeers
banPeer
unbanPeer
dumpStart
dumpStop
getAccountInfo
getModuleSource
getInstanceInfo
getNextAccountSequenceNumber
getNextUpdateSequenceNumbers
getConsensusInfo
getBlockInfo
getPoolInfo
getPassiveDelegationInfo
getBlocksAtHeight
getTokenomicsInfo
invokeInstance
getBranches
getElectionInfo
instanceStateLookup
getBlockItemStatus
getPeersInfo
getNodeInfo
sendBlockItem
getAccountTransactionSignHash
getBlockChainParameters
getBlockFinalizationSummary

To the reviewers; comments with the FIXME-prefix indicate lines where I have doubts about what approach to use.

There are still a few critical issues remaining.
And there is this general issue that you use ^? a lot on a lens, but I don't see how that is necessary. It is a Lens, so you should be able to use ^..

Great. I annotated the places where I had doubts. Thanks for the feedback 👍🏼 🙂
The why: The proto-lens docs kind of suck, and I opted for ^? as it was listed as safe. When I started this, it was unclear whether I could expect all message fields to be present. Search-replace with a well-crafted regex should remedy this, and should not impact things too much.

In a feature branch, you can click the folder in GitHub to see the commit ref:
https://github.com/Concordium/concordium-base/tree/d132f5de85753b3ac7200c60ba5f756eef270dd3
So we should also have have PR’s for things that are not PRs pulling into main?

On 8 Feb 2023, at 09.27, Aleš Bizjak @.***> wrote:
@abizjak commented on this pull request.
In src/Concordium/Client/GRPC2.hs https://github.com/Concordium/concordium-client/pull/209#discussion_r1099800982:

-- equivalent. Returns Nothing if the conversion failed.

fromProto :: a -> Maybe (Output a)

+instance FromProto Proto.AccountIndex where

type Output Proto.AccountIndex = AccountIndex
fromProto = return . AccountIndex . deMkWord64

+instance FromProto Proto.AccountAddress where

type Output Proto.AccountAddress = AccountAddress
fromProto = deMkSerialize

+instance FromProto Proto.CredentialRegistrationId where

type Output Proto.CredentialRegistrationId = (CredentialRegistrationID, RawCredentialRegistrationID)
fromProto crId = do

   raw <- deMkSerialize crId

   nonRaw <- credIdFromRaw raw

Where is this function defined? There is no PR in base, nor is this in main there.
—
Reply to this email directly, view it on GitHub https://github.com/Concordium/concordium-client/pull/209#pullrequestreview-1288680847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUIXBRLMFI47VA6KAFX4PTWWNKGXANCNFSM6AAAAAAUDUJNB4.
You are receiving this because you authored the thread.

No, nothing is merged into main.

Den 8. feb. 2023 kl. 12.50 skrev Aleš Bizjak @.***>:

@abizjak commented on this pull request.
In src/Concordium/Client/GRPC2.hs:

-- equivalent. Returns Nothing if the conversion failed.

fromProto :: a -> Maybe (Output a)

+instance FromProto Proto.AccountIndex where

type Output Proto.AccountIndex = AccountIndex
fromProto = return . AccountIndex . deMkWord64

+instance FromProto Proto.AccountAddress where

type Output Proto.AccountAddress = AccountAddress
fromProto = deMkSerialize

+instance FromProto Proto.CredentialRegistrationId where

type Output Proto.CredentialRegistrationId = (CredentialRegistrationID, RawCredentialRegistrationID)
fromProto crId = do

   raw <- deMkSerialize crId

   nonRaw <- credIdFromRaw raw

Right, but that is not merged to main, right? Nor is there a PR? Or where is this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


Task view: pressing "c" to jump to comments section does not work

Hey, thanks again for the extension. I've noticed that while in the task view, pressing "c" to jump to comments section does not work, although my understanding is that it is covered by this extension and the original version. Steps to reproduce:

Open any task in task view
Press "c" - comments section is not activated

Good point!  Added this in version 163


When a user refreshes the page, "if signed_in?" shows the user they are not signed

I'm using "if signed_in?" but it shows logged in users they are not signed in when they refresh the page until they click any action on the site. When they click a link, the header is updated to show that they are signed in.
- if signed_in?
   %li.nav-link= link_to current_user.display_name, edit_user_path
   %li.nav-link= link_to "Sign Out", sign_out_path, method: :delete
- else
   %li.nav-link= link_to "Sign Up", sign_up_path
   %li.nav-link= link_to "Sign In", sign_in_path

Are you loading any of the page via AJAX? Is turbolinks involved? Are there cache headers involved? Do you see this behavior in development only or also in production?
There's nothing in Clearance itself that could possibly explain this situation where clicking a link shows a user logged in, but refreshing does not. If you can reproduce this in a sample app, I'm happy to take a look.

@derekprior - I apologize for the delay and thanks for taking the time to reply. I've added you to the sample repo, and turbolinks as well as caching is not set up in the test application using clearance.

I'm not able to access the repository, but it's also been quite some time since this issue was opened and I haven't heard of any other issues. It seems like if this were a widespread issue almost every use of Clearance would be broken. I'm going to close for now, but if you have more detail, please add it.


[Feature] The biggest demand for TTS is the reading API. Can it be made into an app to run TTS services on mobile devices in the future?

Feel free to ask any kind of questions in the issues page, but please use English since other users may find your questions valuable.
Is your feature request related to a problem? Please describe.
Novel read.
Describe the solution you'd like
Set TTS on mobile, listen to the novel.
Describe alternatives you've considered
MultiTTS
Additional context

Our api service will be avaliable soon on https://fish.audio/.  You can later to use our api service build your own mobile apps.

很期待朗读api的上线！

Looking forward to the speak api going live!

Our api service will be avaliable soon on https://fish.audio/. You can later to use our api service build your own mobile apps.

Is is possible to deploy API on mobile local?
Novel reading do really coast too much when using 4g/5g

https://github.com/fishaudio/fish-speech/issues/515 Change title to English.


Fix external dependencies for MagicNet demo

Just ripped the files from the cs.stanford.edu/people/karpathy/...  Tried to minimise changes, personally I think it's best to avoid hosting any of these external libs locally.
For the data files, because of the requests for the .txt one must still run a server to load the demo page.
I did not check if other demos are similarly broken when running locally.

Hmmmm I agree in general it's just that I'm worried of bloating the core library with all these appendages and extra data files, etc. Do you happen to know how large these files are in terms of kb?

The data files together are 4.2 MB.  The JS lib is negligible (29KB).
I agree bloat is a concern, not in terms of KB but in terms of readability.
We could just link to https://archive.ics.uci.edu/ml/machine-learning-databases/iris/iris.data etc.  According to Talebian antifragility they will probably outlive this repo.  Same for the JS, including jQuery.
Or we could make it work at least for npm.  That would mean explicitly adding a demo/package.json with these deps and demo/Readme.md with a few lines to get started:
  #  Assuming you have already built convnetjs
  cd demo/
  npm install
  cp -a /node_modules/. /js/
  cd ..
  npm install http-server #  If you don't already have it
  http-server
  #  Now visit http://<IP_ADDRESS>:8080/demo/

I'm open to other suggestions.

I checked now, some of the other demos also have broken deps, mostly to MNIST data.

Friendly ping :-)

Very sorry for late reply on these, too busy with other things :( I think I'm going to remove MagicNet altogether, which will deprecate this PR and we can keep the core library lean.

That works too. :-)  However because the other demos have the same problem, we should probably create an Issue then, to track what is needed for any dev to build the site (whether that is changing the source to point to external versions, adding data files to the repo or creating instructions in the README about how to get them).

I mostly thought of the demos as a dump of some example code that people might refer to. Ideally it would be as you describe. But many of the demos require data (e.g. CIFAR images), which I think are too large to be put in the repo. At the very least in any case all of this should be documented in the README, which I should do.
I'm going to close this issue and in short term will update Readme. Thanks!


module 'tensorflow.python.ops.nn' has no attribute 'rnn_cell'

my OS is win10， and the version of tensorflow is 1.0. but  errors occured : No module named 'tensorflow.models',the code snippets as follow:
from tensorflow.models.rnn.translate import data_utils
from tensorflow.models.rnn.translate import seq2seq_model
I am new to tensorflow ,thank you!

@yydxlv tensorflow.models has been moved to a separate github repository
You can clone this locally,and move the models folder into your tensorflow folder (found in python site packages ). After that you will have tensorflow.models in your import working correctly. Also if you still have problems with getting data_utils and seq2seq_model not importing from rnn.translate, you can move those files out and rearrange a bit of code in the translate.py to make everthing work. I also had the same problem when starting out, and this was the workaround I used.
Hope it helps!

if you are using Tensorflow 1.0, try import like this:
import tensorflow as tf
from tensorflow.contrib import rnn
hidden_size = 100
batch_size  = 100
num_steps   = 100
num_layers  = 100
is_training = True
keep_prob   = 0.4
input_data = tf.placeholder(tf.float32, [batch_size, num_steps])
lstm_cell = rnn.BasicLSTMCell(hidden_size, forget_bias=0.0, state_is_tuple=True)

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Make CONTRIBUTING refer to contrib license guide

What does this PR do?
Depends on cyberark/community#74
What ticket does this PR close?
Connected to cyberark/community#1
Checklists
Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[x] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation

Merging even with broken build, bc this docs update doesn't impact it


[PROTOTYPING] - Version 1 Integration

Put together the majority of the version 1 deliverables into a prototype.
Deliverables
List the relevant deliverables (in order of precedence):

[x] #34
[ ] #33
[ ] #26
[ ] #27
[ ] #25
[ ] #74

In addition, integration should include the following:

Assembly instructions and documentation (i.e. video)
Merging all /deliverable/ directories to a master release structure (i.e. a single fabrication BoM, single purchase BoM, single assembly instructions, etc.)
Adding the following subsystems to the Fusion360 CAD:

Aeroponics
...

Assembly date: TBD

I think for version 1 purposes, it isn't necessary to formalize the infrastructure (i.e. mounting all the aeroponics hardware to a subframe), we can just kinda throw a sheet of plywood on top of the box and call it a day


fix(api): properly authorize GET workflow fallback to archive

Cherry pick of patch for https://github.com/argoproj/argo-workflows/security/advisories/GHSA-h36c-m3rf-34h9

@Joibel could you update https://github.com/argoproj/argo-workflows/security/advisories/GHSA-h36c-m3rf-34h9 to mention that it is resolved by this PR? Usually we've had it written at the bottom of the "Summary" section (for example, see https://github.com/argoproj/argo-workflows/security/advisories/GHSA-ghjw-32xw-ffwr)
Just to be able to follow the fix accordingly and posterity/historical lineage.
(Right now you have to dissect the version numbers and diff to find this as there is no direct link from the advisory itself. The GH reviewed version includes the PR and commit if it's in the original as well.)


Add flush interval configuration property

Fixes #2
It also needs https://github.com/SAP/aker/pull/6 in order to work properly.
For more details around it, please have a look at
https://github.com/golang/go/blob/master/src/net/http/httputil/reverseproxy.go#L45

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

LGTM 👍

What is the behavior if the flush interval configuration is not specified?
Does it behave as it did prior to this change or does it fail parsing?

It behaves as it did prior to the change.
If the flush_interval property in the configuration of the plugin is not set, the handlerConfig object will have its FlushInterval set to the default value of the type (0, since time.Duration is int64).


Add README.md files for each nuget package.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.271%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2574

Relevant Lines:
2794

💛  - Coveralls


Abstract creation of PTX/AMDGPU kernels

Create kernels via target util

jenkins: retest this please

jenkins: retest this please

@sumesh13 commit 6cfa0ab is the same as 3213dd6 ?

@sumesh13 commit 6cfa0ab is the same as 3213dd6 ?

Oops...just pushed the right changes

jenkins: retest this please


Save Chat history conversations in txt file or json file or yml file in python

Hi,
I want to save the chat conversations between user and bot and save it on the txt file or yml file or json format this help in avoid training all the time and i want call this chat history file for further process could any one help in this issue please
Thank you in advance
Happy codding...

This might helpful https://chatterbot.readthedocs.io/en/stable/corpus.html#exporting-your-chat-bot-s-database-as-a-training-corpus

@vkosuri  hi this is my code
from flask import Flask, render_template, request
from chatterbot import ChatBot
from chatterbot.trainers import ChatterBotCorpusTrainer
app = Flask(name)
english_bot = ChatBot("Chatterbot", storage_adapter="chatterbot.storage.SQLStorageAdapter")
english_bot.set_trainer(ChatterBotCorpusTrainer)
english_bot.train("./data")
@app.route("/")
def home():
return render_template("index.html")
@app.route("/get")
def get_bot_response():
userText = request.args.get('msg')
reply =  str(english_bot.get_response(userText))
if name == "main":
app.run()
now i want to save the chat conversations which are from the data folder(contains yml files) and after the conversation is finished i want to save that conversation in one file
could you help me in that way
Thank you in advance
Happy codding....

You can probably do this manually. Every time the user asks a question, add it do a dict. When you get the bot response, add it to the dict as well and so on and so forth. At the end, when the user exists the program, you can export the dict into a file. For example, if you use PyYAML, you can simply do yaml.dump(dict) . Then you can use the resulting .yaml file to train your bot via the ChatterbotCorpusTrainer.

Thank you @Ligh7bringer

Hi every one while i am saving the chat data into a yml file i failed to save the url data how can i save that data in then yml file in chatterbot using python
Thank you in advance .....
Happy codding......

Hi everyone, I want to save the chat conversations which are from the data folder and after the conversation is finished, I want to save that conversation in on file.


feat(MobilePhone): add mobile phone illustration~

Overview

Illustration for LX team, code from pairing w/ @irenerobb72 ✨

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

🚀 Styleguide deploy preview ready!https://6239ef8827c6df2361f152bd--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.24.1-alpha.74b24f.0@codecademy/gamut-kit@0.6.86-alpha.74b24f.0@codecademy/gamut-labs@30.5.1-alpha.74b24f.0@codecademy/gamut@45.3.1-alpha.74b24f.0@codecademy/monaco@0.6.28-alpha.74b24f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://623b548f8a1f5300ac3dd219--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.24.1-alpha.4a473c.0@codecademy/gamut-kit@0.6.89-alpha.4a473c.0@codecademy/gamut-labs@31.0.1-alpha.4a473c.0@codecademy/gamut@46.0.1-alpha.4a473c.0@codecademy/monaco@0.6.30-alpha.4a473c.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://623e130a8c8ebe1739c58365--gamut-preview.netlify.appDeploy Logs


Update schema to include a namespace

PR Template:
Describe your changes

Update the schema to be inline with the test schema basic_schema.yaml https://github.com/project-kessel/relations-api/blob/main/internal/data/spicedb-test-data/basic_schema.yaml

Ticket reference (if applicable)
Fixes #
Checklist

[ ] Are the agreed upon acceptance criteria fulfilled?

[ ] Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

[ ] Do your changes have passing automated tests and sufficient observability?

[ ] Are the work steps you introduced repeatable by others, either through automation or documentation?

[ ] If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
[ ] An SOP (Standard Operating Procedure) was created

[ ] The Changes were automatically built, tested, and  - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

[ ] Are the agreed upon coding/architectural practices applied?

[ ] Are security needs fullfilled? (e.g. no internal URL)

[ ] Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

[ ] For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

LGTM


turn on aa service for featherstone in preprod and prod

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.30%. Comparing base (a148a72) to head (eb8fa98).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1152   +/-   ##
=========================================
  Coverage     84.30%   84.30%
  Complexity     3721     3721
=========================================
  Files           383      383
  Lines         12613    12613
  Branches       1096     1096
=========================================
  Hits          10633    10633
  Misses         1476     1476
  Partials        504      504

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.