Fix | Addressing failure on providing correct error message when symmetric key decryption fails using Always Encrypted.

The issue is happening when IsDBNull called on an encrypted column with backed keys in Azure key vault. If, for any reason, application fails to decrypt column keys, not the value the actual key for the column, the driver is waiting for the pending data to be received and throws unknown TDS token header, by setting the pending data to false, application will not process the rest to read the data.
 string command = $"SELECT [SSN] FROM [{s_schema}].[{s_table}]";
            using SqlCommand sqlCommand = new(command, connection);
            try
            {
                connection.Open();
                using SqlCommand cmd = connection.CreateCommand();
                cmd.CommandText = command;
                try
                {
                    using SqlDataReader reader = cmd.ExecuteReader();
                    if (reader.HasRows)
                    {
                        while (reader.Read())
                        {
                            if (!reader.IsDBNull(0))
                            {
                                _ = reader[0];
                                Console.WriteLine("It's not null db");
                            }
                        }
                    }
                }
                catch (Exception ex)
                {
                    Console.WriteLine(ex);
                }
~~~

You removed the DrainData(stateObj) function call later. Can you explain what the implication was?
Also, I am just adding a note not to forget to include tests.

You removed the DrainData(stateObj) function call later. Can you explain what the implication was?
Also, I am just adding a note not to forget to include tests.

Adding a test is bit complicated. It needs some modification to prevent the application from obtaining the key to decrypt column key. DrainData is reproducing the issue as there is no data at this point for the column. Basically at this point setting pending data to false will cause the driver to skip looking for the column value and exception will be thrown immediately.

What would be the result of this change with MARS enabled, and/or parallel async calls? These are the questions that require more tests.

What would be the result of this change with MARS enabled, and/or parallel async calls? These are the questions that require more tests.

So, the issue only happens on ISDBNull to get the column's info and if you dont use that no issue comes up at all. For async and MARS we do have tests to run and read values, I am not sure if ISDBNull has been called inside those tests, but no failure on the pipelines so far. I will try to come up with a solution for the test purposes.

Thanks! I've tested this fix locally and it seems good to me. We'll have to add the test in a separate PR.


Opt-in error reporting and anonymous usage reporting

Not a blocker for releasing v2, but we're rolling out a new codebase so that means exciting new bugs that we haven't found yet.
It'd be great to get user errors reported automatically, in a way that we can see what's happening with real usage, and have a service we can point users to if they want to find out more / solve the problem / contribute to a fix. The error reporting should be opt-in, respectful of user privacy and give us stack traces and runtime environment info.
More broadly, it'd be great to have some anonymous, opt-in usage stats so we can see what functions are popular and what isn't getting used, so we can focus the user testing to figure out if the feature is superfluous or if it's the UX that is getting in the way.

There is a problem with "opt-in usage stats so we can see what functions are popular" because if it is an opt-in you will have unrepresentative sample of people :) If we want to gather meaningful usage data, it needs to be enabled by default (opt-out).  The hard part is to ensure we don't sent any personal data.
I feel "Telemetry" project in Firefox may be an example how to do it right:

It's helpful for Mozilla's engineers and decision-makers to be able to measure how Firefox behaves in the real world. The Telemetry feature provides this capability by sending performance and usage info to Mozilla. As you use Firefox, Telemetry measures and collects non-personal information, such as performance, hardware, usage and customizations. It then sends this information to Mozilla on a daily basis and we use it to improve Firefox.

https://telemetry.mozilla.org
https://wiki.mozilla.org/Telemetry
https://support.mozilla.org/en-US/kb/share-data-mozilla-help-improve-firefox

cc https://github.com/ipfs-shipyard/ipfs-desktop/pull/697 (Opt-in error reporting in ipfs-desktop)

Closed (stale). Please re-open if necessary - thanks!


what does the 'rate' parameters actually mean in code?

The github readme says 'rate' measures how much rank to retain,  but in the code implements "results = torch.svd_lowrank(weight, q=desired_rank, niter=niter)" confuses me a bit. desired_rank means to retain, desired_rank = max_rank * k so k means how much to retain, then k = (10 - rate) * 0.1, so rate should mean how much to reduction? Is there something wrong with my understanding?

thanks！！！


TODO: Add space for blood pressure and pulse readings

Add additional space for systolic and diastolic readings for blood pressure as well as a pulse reading.

I am working on this and even already have a separate Excel template prepared for blood pressure and pulse. Over the next few weeks, I will work on integrating the two template sheet sets into one sheet set.

At first, this was done as a separate file. It is all now integrated into one file.


Build Error

As soon as I add the library/dependency(com.github.orangegangsters:lollipin:2.0.0@aar) to build.gradle(app)
and try to build the project i am getting the error

Error:Execution failed for task ':app:transformClassesWithDexForDebug'.
com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException: Error while executing java process with main class com.android.dx.command.Main with arguments {--dex --num-threads=4 --output C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\transforms\dex\debug\folders\1000\1f\main C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_fc98aba6c411568099b28414c3d0c74f379aa4f2.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_868c90179f7c6dc89a6b18cb6f92a7ebc552d4e7.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\baseLibrary-2.2.0-beta1_9724b4c2b98367ecdff6a7f489a2455300c26237.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_3d58e0f098d6da787adb69ffd792a8d90677cc7b.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_33ae3e82d086bce527d35feb047037ef6cdc0b3e.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_c1719ff83ef27dd94ae2e490f10da47d1fbd2c62.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_53ab2bcf3a95330d9f3e02c6d0f279ce288673d4.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_a1c0d06f65602559f479596edc58a7fdd7a81c0b.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_1b2e901c3f78df0c17fb00c929b6884a4b7b97f9.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_3abd37d54fa777a7cd912d60684b35d3d64d7df3.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_541e5577b0a03784b8a087122d48679d84df807b.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_03584dfa5a487bfbd5895c39da41ac697e4129b3.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_f78e088c1ddca4523c89ce8b0188e3d832fe8a59.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_25fdbfba737e159260ce832e02b8c09c371d27c4.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_4094ad0e6f4b3447e68032404587bc2947146bab.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_e43e37be1bc3615a239a645dd9d5ab8e933e40f4.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_36712ec0d148e3519b999c7eb033039bff5649b5.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_80c961acef4bad6ada327165479776458c8c5cf7.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_194598683b0e20333af44d926141cae9b0f36551.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_d8c797ad5281993e4beaddf28a762ec82574f0a6.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_f1311112735f29590c33d01c718feaac96a97052.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_65ba8bf726b064d818114af69cf34c6ab69f8ec5.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_48d6845a32053df6e7c60b913b7ad79fe7421855.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_1ab8e89b4e7ae4871cadf12b17d86945840c7a40.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_90fe1468ddccc5f66a81c82f64308d304ac0fb9d.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_fa32ad138fc42cbb885293a3f8ea85df9e956045.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_5e9fbbb57e6dfd1d4908d642435538b7b9f81c39.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_61d0220e94d78246af0450b37bf7042cfc0a06aa.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_29cfb98623b2eb59302f2df7aca43fcfe45acf0d.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_1e0825c0f48a0ca7c2a05b13fec5f3a496bae5a7.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_4e02be51399a498dbe2bfddbd6d6c78d70b36ed8.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_2c1b0ae7e29b1906e2aaf980ccb92afc02a86239.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_98a691c23124d368d496fbcf62e7396a764682df.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_8557666818b0c475799a9ce1a2d9ff8f4afeb8ae.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_00cc194d53726f3a1ff1f2734c5c224b59e9aa71.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_2588042a65b91e959acf41ace8845fb363859287.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_ce6bbce1ce462479d5d092a967c6d32001a020e9.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_bb17caa77ace09bd0bd6cfed0bcce4909d5cf172.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_66406e537ab958e5fd22e2f902422deffef1a589.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\support-annotations-24.2.0_b7e28dbb9679f0fe89756ee9232c44ca2fc9af65.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_dce399ca21a06f31d53f30b779c2ccd1d9541ca9.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\debug_3296a8eee398ce57aef14cb5653e6c10eb8f6906.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_e7697b4ebaf6da46ddea447ff729fcf6dae44fa8.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_59304a2225a6e834c6c67685df45a837814c4226.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\internal_impl-24.2.0_3bfc80933b8a61b05b2e829912ecd58031773442.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_822f3d90cfbae64ae15e811c0bca3ea47645106d.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_f65dfb224e91313fd33b246b6e462e610ec4dcb5.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_7069f0800b5d7f455d99efb8493b3251af87391d.jar C:\Users\IK\AndroidStudioProjects\Xymen\app\build\intermediates\pre-dexed\debug\classes_fa2827fc08a949cbe556dbe222554dedffd11018.jar}

Xymen is the name of my app.
Build is not working
Android Studio 3.0 Canary 3
Gradle: gradle-4.0-milestone-1-all.zip

Gradle: Gradle-4.4-all.zip
compile SDK: 24
buildToolsVersion: 27.0.2
in Android Studio V 3.1.2 March 13, 2018, build working fine
Try with these configurations.


css  and js file unable to access

All reference file(css,js..) under this site cannot be accessed(http://syk.testin.com/homeimg/ad001.png net::ERR_EMPTY_RESPONSE),
only the reference of other sites can be accessed.(http://abc.com/base.css is ok!)

nginx+modsecurity2.9
location / {
ModSecurityEnabled on;
ModSecurityConfig modsecurity.conf;
proxy_pass http://syk.testin.com;
proxy_redirect default;
    }

Please use the nginx_refactoring branch:
https://github.com/SpiderLabs/ModSecurity/tree/nginx_refactoring

Thank you very much, problem solved


Suggested contributions

Hey I know this is just a PoC and @oxalica isn't active anymore on it. However I would like to contribute and get it closer to production-ready. What kinds of contributions are most important right now?

I'll try to include support for the registry layout version 2

Thanks! PRs are welcome.

What kinds of contributions are most important right now?

The complexity of this project grows quite beyond my expectation, especially the already-over-complex dependency and feature resolution parts, let alone the registry layout v2 (weak features and dep:package). Since v2 is gradually used by more and more crates, it's now a primary usability issue. I tried some ways to refactor and/or simplify it but failed. If you have any idea or implementation patches, I'm happy to hear that.
Time penalty due to the lack of streaming build is also a concern. Cargo can build the dependent crates, and as long as all its dependencies has rmeta files produced, but may before their codegen (rlibs). Nix derivation boundary stops us from doing this. But it's less of concern and can be overcome by cached dependency builds.
If you're willing to, we can discuss on Matrix. The address is on my GitHub profile page.

Alright I'll contact you soon 😊

Closing since we already have a PR
https://github.com/oxalica/nocargo/pull/17


Make class on body persists if another Reveal is still visible.

When multiple Reveal modals are open and I close one of them, the class .is-reveal-open was removed from the <body> despite another modal still being open.
Now checking if another Reveal is visible before removing the class.
Added visual and automatic test.

Looks good, thanks @Owlbertz!


Update/ena schemas 1.11.0

Description

keep ENA schemas up to date
Related issues

Type of change

[x] Updates

Changes Made

update ENA schemas from https://github.com/enasequence/schema/tree/master/src/main/resources/uk/ac/ebi/ena/sra/schema
adjust JSON Schemas with new ENA schema updates

Testing

[x] Tests do not apply

Mentions

If I understand correctly, these are copies from the ENA schema repository?

If I understand correctly, these are copies from the ENA schema repository?

yes, local copies. Linking the repo directly might cause issues if they change something drastically.


⚠ Bofrost.es has degraded performance

In fda18c8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1385 ms

Resolved: Bofrost.es performance has improved in ab442f6 after 6 minutes.


Sway's enums are different to Rust.

The enums need some attention I think, since they're a bit different to Rust's, which I assume this plugin is based on initially.

We should do this instead: https://github.com/FuelLabs/sway.vim/issues/11


readme-guestbook.vercel.app is not registered as an OAuth redirect domain.

Hi Jason,
now.sh is now vercel.app and redirects https://readme-guestbook.now.sh/ to https://readme-guestbook.vercel.app/.
This new domain does not seem to be registered in firebase and due to that the website does not work anymore.
The login popup closes instantly and produces the following error:
{
    "code": "auth/unauthorized-domain",
    "message": "This domain (readme-guestbook.vercel.app) is not authorized to run this operation. Add it to the OAuth redirect domains list in the Firebase console -> Auth section -> Sign in method tab."
}

Thanks @vincentscode, fixed! ✨


Expose loadbalancer IPv4 when Traefik disabled.

Currently the code in output.tf returns null for load_balancer_public_ipv4 if Traefik is disabled. I can understand the reasoning, because without an ingress controller to provision an IP from the Hetzner LB, there is no LB IP to speak of. However, I'm disabling Traefik to install nginx-ingress instead. I'm sure many others disable Traefik to instead install their own preferred ingress controller.
Since there is no way for the Terraform module to detect whether or not a user will provision an ingress controller after Terraform provisioning, I think it makes sense to err on the side of caution, and return proper load_balancer_public_ipv4 value even when Traefik is disabled.

Hello @geraldwuhoo, it makes sense! PRs welcome, that should be a quick fix.
@phaer FYI.

Moving this to a discussion in the ideas section, @geraldwuhoo, If you decide to take this on, I will convert it back to an issue to properly close it and give proper attributions.


[Feature request] Allow expose multiple ports from container

Hi,
On https://codx.meetnav.com need to expose other ports than neko to allows developers to test their work from their own browser. So when user is running a website on port 3000 inside neko, I need to be accessible as well through https://rooms-domain.com/room/<room-name>-3000/ for example.
What if we create a "PORTS" section on settings and we add the extra traefik labels for this ports mapping?
Thanks

Great, wider solution.
On Sat, Feb 26, 2022, 12:46 Miroslav Šedivý @.***>
wrote:

Adding to configuration posibility to add own traefik labels to every room
could be general solution to this. And it could cover multiple future use
cases, what do you say?
—
Reply to this email directly, view it on GitHub
https://github.com/m1k1o/neko-rooms/issues/42#issuecomment-1052063795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAF3JTCECNX4PFVLTDKYRO3U5C4RTANCNFSM5PMTTDYA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Great, wider solution


CoreCLR 2.0 - TODO for resources in error handling

From @stephentoub on Thursday, August 17, 2017 7:22:57 AM
From @ayende on August 17, 2017 14:7
When a web socket connection is broken, I'm getting this:

I assume that is something that should be fixed :-)
Copied from original issue: dotnet/coreclr#13425
Copied from original issue: aspnet/WebSockets#198

From @stephentoub on Thursday, August 17, 2017 7:22:58 AM
That's coming from here:
https://github.com/aspnet/WebSockets/blob/4e2ecf8a63b9fc78175d1ef62bf2b1918b8b3986/src/Microsoft.AspNetCore.WebSockets/Internal/fx/SR.cs#L22

From @jkotalik on Tuesday, August 22, 2017 11:47:05 PM
Looks like we need to update our copy of WebSockets, I'll go ahead and fix that.

From @jkotalik on Tuesday, August 22, 2017 11:59:38 PM
@anurse Seems like we need to also be copying https://github.com/dotnet/corefx/blob/master/src/System.Net.WebSockets/src/Resources/Strings.resx for the comments?

From @anurse on Wednesday, August 23, 2017 12:48:32 PM
Yep, sounds right

From @anurse on Wednesday, August 23, 2017 4:31:23 PM
I'd propose this for a patch release. If not 2.0.1, then the next one. The risk is low and the impact is pretty high: Having these exception messages be completely bogus strings is not a good thing and it's easy for a customer to encounter this.
Note: the PR for this also brings in some behavior changes, we would need to fully understand those before considering taking those in the patch as well, but taking the exception message changes should have no behavioral impact and should be very safe for patching
/ping @muratg @Eilon

From @davidfowl on Wednesday, August 23, 2017 10:32:29 PM
Damn I forgot to file this bug in 2.0.0 https://github.com/dotnet/corefx/issues/21509 😞

From @Eilon on Thursday, August 24, 2017 9:46:03 AM
Moving out of patch milestone.

From @jkotalik on Monday, September 18, 2017 11:53:31 AM
@anurse Do we still want to merge this in or figure out a better solution?

From @Tratcher on Monday, September 18, 2017 1:44:28 PM
We need to find an non-manual solution.

From @anurse on Monday, September 18, 2017 3:34:01 PM
We need https://github.com/dotnet/corefx/issues/21537, which is still on the queue for 2.1
Then we can just remove the copying altogether

From @jkotalik on Monday, September 18, 2017 3:52:01 PM
Closed my PR as we will wait for corefx to expose their implementation in 2.1.

From @davidfowl on Wednesday, September 20, 2017 1:48:43 AM
Will that package be netstandard?

From @anurse on Wednesday, September 20, 2017 8:36:39 AM
My understanding is yes. It will support the managed implementation on all platforms with non-managed light-ups

From @jkotalik on Thursday, September 28, 2017 2:49:30 PM
Awaiting response from https://github.com/dotnet/corefx/issues/21537 for next action.

From @anurse on Thursday, September 28, 2017 3:49:13 PM
Well, it sounds like we're going to keep copy-🍝 for now, so I guess we should just update our code with the latest. Note that https://github.com/dotnet/corefx/pull/24288 is pending and we may as well wait until that's in to pull it as well.

From @anurse on Friday, September 29, 2017 9:35:04 AM
The PR I referenced has been merged. @jkotalik , we might as well do another code sync from the latest corefx master using the script. It's relatively harmless even if we end up moving away from code sharing and it makes sure we don't accidentally ship another release with this problem ;)

From @jkotalik on Friday, September 29, 2017 9:58:50 AM
I mean the whole problem before was we weren't pulling the resx file for websockets. We will need to add that to the script.

From @anurse on Friday, September 29, 2017 12:09:41 PM
Yeah, I'm not happy about expanding our code-copying, but if they're not going to release an OOB we're going to have to do it eventually. We don't have to rush in to fixing this, but by 2.1 RTM we have to do one of: fix the script and copy the resx, or drop the source copying and switch to an OOBed package.

From @stephentoub on Friday, September 29, 2017 12:22:43 PM

We don't have to rush in to fixing this

Yeah, I suggest you hold off.  I'm still hopeful they'll be an OOB here.


MultiHeadAttention layer save and load changes weight

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): pip install tensorflow
TensorFlow version (use command below): v2.4.0-49-g85c8b2a817f 2.4.1
Python version: 3.7.11
Bazel version (if compiling from source):
GPU model and memory: https://aws.amazon.com/ec2/instance-types/g4/
Exact command to reproduce: see the source code below

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the problem.
trained a small model with a MHA layer and save model (savedModel) and load it back, the weight of the MHA layer changed. I have checked similar thread like this, the suggestion was to fix the seed given to the kernel_initializer, so did that as shown below, but does not fix the problem. Notably, if just build the model and save without training (.fit), loading back the model, then the outputs are consistent.
Describe the current behavior.
model.save and then load back have different weight in the MHA layer and gives rise to different output from forward pass.
Describe the expected behavior.
save and load back should be consistent
Contributing.

Do you want to contribute a PR? (yes/no): no
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
from tensorflow.keras.layers import MultiHeadAttention, Concatenate, Add, Dense
from tensorflow.keras.initializers import glorot_uniform
import tensorflow as tf
from tensorflow.keras.optimizers import Adam

def encoder_layer_simple(units, d_model, num_heads, dropout, name="encoder_layer"):
    assert d_model % num_heads == 0

    depth = d_model // num_heads
    query = tf.keras.Input(shape=(None, d_model), name="query")
    key = tf.keras.Input(shape=(None, d_model), name="key")
    value = tf.keras.Input(shape=(None, d_model), name='value')

    attention, attn_weights = MultiHeadAttention(num_heads, key_dim=depth, value_dim=depth, dropout=dropout,
                                                 kernel_initializer=glorot_uniform(seed=0))(
        query=query, value=value, key=key, return_attention_scores=True)
    attention = tf.keras.layers.LayerNormalization(epsilon=1e-6)(attention + value)

    # ffwd sub-layer
    outputs = tf.keras.layers.Dense(units=units, activation='relu')(attention)
    outputs = tf.keras.layers.Dense(units=d_model)(outputs)
    outputs = tf.keras.layers.Dropout(rate=dropout)(outputs)

    outputs = tf.keras.layers.LayerNormalization(epsilon=1e-6)(outputs + attention)

    return tf.keras.Model(inputs=[query, key, value], outputs=outputs, name=name)

then create an 'encoder' model and do a fit
encoder = encoder_layer_simple(512, 400, 8, 0, name='test_encoder')

query = tf.random.uniform([256, 100, 400])

enc_x = {'query':query, 'value':query, 'key':query}
enc_y = tf.random.uniform([256, 100, 400])
encoder.compile(Adam(),'MSE')
encoder.fit(x=enc_x, y=enc_y)

save_path = "path_to_model"
encoder.save(save_path)
loaded = tf.keras.models.load_model(save_path, compile=False)

eout = encoder(enc_x)
lout = loaded(enc_x)

np.allclose(lout.numpy(), eout.numpy()) # will output False

also can get weight matrix from the MHA layer, close but different
encoder.get_layer("multi_head_attention").get_weights()[0][1, 4, 1:10]

array([ 0.01589977,  0.01451083, -0.00762749, -0.00915873,  0.00802898,
0.00830225, -0.01598875,  0.01182209,  0.01533959], dtype=float32)
loaded.get_layer("multi_head_attention").get_weights()[0][1, 4, 1:10]

array([ 0.01591637,  0.01452216, -0.00764309, -0.00916362,  0.0079951 ,
0.0082739 , -0.01598743,  0.01181626,  0.01530811], dtype=float32)

I would like to work on this issue

@sanatmpa1 @yesufeng I tried reproducing the issue using the code provided by you and could not find an error. The loaded weights were the same.
You can find the code for the following here.
Python used: Python 3.7.12
Tensorflow version used: 2.6.0
I think the issue is fixed in the current release. If so you can please close the issue.

@sanatmpa1 @yesufeng I tried reproducing the issue using the code provided by you and could not find an error. The loaded weights were the same. You can find the code for the following here. Python used: Python 3.7.12 Tensorflow version used: 2.6.0 I think the issue is fixed in the current release. If so you can please close the issue.

@sanatmpa1 thank you! seems that I need access to that drive<EMAIL_ADDRESS>

Was that code helpful? @yesufeng

Was that code helpful? @yesufeng

again I don't have access to it

sorry for the inconvenience. https://colab.research.google.com/drive/1wzh8t-BiwuzRJZ1jW_gtsyqIy-2B2Zpj?usp=sharing

@yesufeng,
Can you take a look at the above comment by @MrinalTyagi ? Thanks!

verified with tf2.5+, it works. Thank you!


⚠ AGEG website (prod) has degraded performance

In d9f647e, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1924 ms

Resolved: AGEG website (prod) performance has improved in b36f6c0.


Manipulating inspected data with periods in property name results in error

Version
5.1.0
Browser and OS info
Chrome 75 / Windows 10
Steps to reproduce

Inspect the following:

Use "Add new item" add a new element to name.has.periods or name.also.has.periods.

What is expected?
New element is added to the data, and appropriate reactive actions are taken.
What is actually happening?
New element is not added.
Console contains error stack trace:
backend.js:2403 TypeError: Cannot read property 'has' of undefined
    at set (backend.js:651)
    at setStateValue (backend.js:2398)
    at Bridge.<anonymous> (backend.js:1550)
    at Bridge.emit (backend.js:5472)
    at Bridge._emit (backend.js:5172)
    at backend.js:5097
    at Array.forEach (<anonymous>)
    at backend.js:5097
    at listener (backend.js:2568)

Same issue when removing existing items.

I think you are asking for troubles with those property names. :joy_cat:


Love the idea!

I have this project in the same vein, https://github.com/pawamoy/yore. It's for when the deprecation period actually stops and you want to remove the dead code.
Before that codecrumbs helps migrating all downstream codebases! It's actually genius.

Thank you, this is the first project which I published on GitHub.
Inline-snapshot came later but was more successful, so I put most of my time into inline-snapshot currently. But I hope to continue my work on codecrumbs sometime.
There are some ideas left like migrating positional arguments to keyword arguments or to provide a Griffe extension 😉
What do you think? How difficult is the last one?

I'm probably biased, but I found extensions to be generally super simple to write :smile: Happy to help any way I can if you find some time to experiment :slightly_smiling_face:


Current time/frame in plot

Indicate the current time/frame position displayed in the napari viewer in the frame rate plot.

The current time/frame is now visible on plot.


parse AAP2 section on jpeg in MediaTrace

I'd like to write a mediapolicy uses some APP2 data, but mediatrace doesn't report on the contents.

Only ICC stuff or something else?

Thx, all I needed for now.


PDTS: Container element texts are not serialized

This is a todo for PDTS.
PDTS works in principle, it will function correctly without the texts and the elements can still be identified by their technical and short names.

I believe this is not yet supported.
Thanks
-Aman

Is that a question? The status is still the same. PDTS works, and the main texts are OK.

Not sure if I should be expecting this.

PDTS has been added recently, please raise any other problems with PDTS objects as a new issue.

FYI, I have removed the experimental status from PDTS, please update to the latest version.

stale. closing


Fix navigation

This PR ensures a minimal working navigation, including the refresh of kernelspecs on editing and delete.
Not all cases have been tested and the current implementation should be considered a basis to enhance.

@Carreau I have disabled isort for now as I can not find the cause of the issue (isort is not very explicit with the error).


SSL Redirection via Heroku

I'm currently at a loss for the best practice in getting forced SSL redirection with Nuxt deployed to Heroku.
Is there a guide somewhere for this that I simply haven't been able to find?

Hey. Can you try this: https://github.com/nuxt/hackernews/blob/master/middleware/https.js ?

@pi0 Thanks for the reference. Unfortunately, redirect only allows for relative redirection, not absolute. When I try to use the linked snippet as middleware, I end up with a recursive loop that provides a url such as:
http://testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/https:/testapp.herokuapp.com/

@natecox I'm not a Heroku app user but they may have Edge SSL redirects too. BTW for middleware redirection with absolute paths, we may use window.location = ... and req.setHeader('Location:') should test it if working or not :)

We ran into this issue in #770 and implemented a workaround: https://github.com/nuxt/nuxt.js/issues/770#issuecomment-304126495

I haven't had a chance to try this code out, but I did run across it a while back. Without trying to be disrespectful to the code author, the workaround there seems really hacky; which is a side effect of redirect simply not allowing absolute URLs.
If this is the accepted solution I'll just go with it, but I feel like there's an opportunity to improve from the Nuxt side.

For clarity, I really think that Nuxt would benefit by providing a force_ssl option to handle this automatically.

@natecox After some search, found a simpler soloution usingn nuxt's new serverMiddleware option + express-force-ssl (demo soon)

Sounds promising! I haven't seen serverMiddleware anywhere, is it documented?

@natecox Comment deleted as it is not handling client side conditions. I will share a demo for serverMiddleware usage.

Sorry for delay. Was doing few tests with currenct redirect middleware. Just implemented redirect-ssl which seems being compatible with heroku too. (Full supporting x-forwarded-proto). In order to register middleware you can install redirect-ssl package and adding this to nuxt.config.js: (needs nuxt 1.x)
module.exports= {
serverMiddleware: [ 'redirect-ssl' ],
}```

Please let me know if it's working with heroko. And if was not successed don't worry as middleware system is improved a lot with next release also we may provide an easier module for SSL redirects too.

@pi0 This seems to work fine, ssl redirection on the server is working without an issue.
I would absolutely be in favor of baking this functionality into Nuxt with a toggle flag.

Happy hearing it's working. Unfortunately while many would benefit from such functionalities we cannot add everything to Nuxt core as it may get out of control soon (https serve is not in the core too) However instead we introduce a modular system which modules can be added in a on liner manner to enhance projects.

@pi0 redirect-ssl isn't working for us.
We have installed the package:
npm install -S redirect-ssl

Placed it in nuxt.config.js:
module.exports = {
   build: {},
   // ...
   serverMiddleware: ['redirect-ssl']
}

Started the server:
npm run build && npm run start

And finally, tunneled it through ngrok:
ngrok http 3000

When we visit the ngrok url http://ourapp.ngrok.io we expect to be redirected to https://ourapp.ngrok.io. Instead, we remain on the http site.
Thank you for your help!

@PiusNyakoojo I'll check ngrok soon.

Thanks pi!

@PiusNyakoojo Just update redirect-ssl and to 1.1.0 and it will work!

Haha, incredible. Thanks pi!

Hey @pi0, one last thing:
How do you disable redirect-ssl for localhost development? 😄

Haha that was the reason i planned writing a nuxt module for easier usage. Currently you may conditionally disable that line using process.env or commenting out by hand 😂 Will provider module in few days.

@PiusNyakoojo with<EMAIL_ADDRESS>it's forced to only redirect in production (a.k.a. when process.env.NODE_ENV === 'production'

@pi0 it's work! Thank you for your work


Implement attack: "Boundary Attack++: Query-Efficient Decision-Based Adversarial Attack"

Paper link: https://arxiv.org/abs/1904.02144

Boundary Attack++ has recently been renamed to HopSkipJumpAttack: A Query-Efficient Decision-Based Attack


Update MD file on new branch 2017-11-17_07-27-15

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Stats: Initialize fields to their default values

Currently, a stats entry is only added the first time it is written, meaning that if we have stats that record rare or infrequent event, we'll get "No Data" until the event triggers.
This is not ideal in general, and very visible when the network gets stuck, as we don't get the "0" stats for block externalized.

Underlying data is:
agora_application_info {version_="v0.13.0",build_timestamp="Mon Jul 19 07:58:11 2021",frontend_version="2096",public_key="boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n",genesis_timestamp="20210614T000000Z"} 1
agora_endpoint_calls_total {endpoint="block_heigth",protocol="http"} 43
agora_endpoint_calls_total {endpoint="receive_preimage",protocol="http"} 825
agora_endpoint_calls_total {endpoint="transaction",protocol="http"} 1029
agora_endpoint_calls_total {endpoint="public_key",protocol="http"} 5
agora_endpoint_calls_total {endpoint="receive_envelope",protocol="http"} 66
agora_endpoint_calls_total {endpoint="node_info",protocol="http"} 642
agora_endpoint_calls_total {endpoint="local_time",protocol="http"} 141
agora_transactions_received_total 206
agora_transactions_accepted_total 206
agora_transactions_rejected_total 0
agora_transactions_poolsize_gauge 244
agora_transactions_amount_gauge<PHONE_NUMBER>000000
agora_preimages_gauge {key="boa1xrval6hd8szdektyz69fnqjwqfejhu4rvrpwlahh9rhaazzpvs5g6lh34l5"} 740
agora_preimages_gauge {key="boa1xzval4nvru2ej9m0rptq7hatukkavemryvct4f8smyy3ky9ct5u0s8w6gfy"} 740
agora_preimages_gauge {key="boa1xzval2a3cdxv28n6slr62wlczslk3juvk7cu05qt3z55ty2rlfqfc6egsh2"} 740
agora_preimages_gauge {key="boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n"} 740
agora_preimages_gauge {key="boa1xrval5rzmma29zh4aqgv3mvcarhwa0w8rgthy3l9vaj3fywf9894ycmjkm8"} 740
agora_preimages_gauge {key="boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh"} 740

But we expect to see agora_block_height_counter.

Fixed by #2311


Better sample data

Add JSON sample data (instead of only DER samples)
Add the automatically-gzipped metadata files. (TUF optionally gzips each metadata file.)
Update the full metadata zips to include these and the other new long-expiry data.

I've been working on this for work: https://github.com/heartsucker/uptane-test-vectors.
They don't have human friendly names, but it might be useful to add these in some capacity (possibly as a git submodule).

Thanks (: I'll take a look.

The repo you have there is along the lines of what we're thinking for TAP 7, yes! These particular files, added in this PR, are intended only as samples and not compliance testing data. I do use them in some unit tests for the secondary module, though.

BTW, FYI, @vladimir-v-diaz, that format may be of use for TUF's compliance tests.

Yep!
Note that link you provided is broken.  It incorrectly has a period at the end.

@awwad Got it. Carry on, then. :D

Should you also add the gzipped versions of JSON metadata?
What metadata formats are stored in the full metadata zips?  role.der; role.der.gz; role.json, role.json.gz?

I think they're all in there, in the folders and the zip files.
4 files per role (4 roles) per repository (2 repositories) per scenario (2 scenarios), the four files being: .json, .der, .json.gz, .der.gz.

I do not see the addition of gzipped JSON files, only .der.gz.  Are you only including them in the full metadata zip?

:facepalm
*.json.gz was in the .gitignore (and also my global gitignore). Sorry, fixed in 4d75719. Thanks for noticing early. (:


The file/component names in shared/login is a tad confusing, but I tried to guess at the use cases by looking at import statements and walking through the app registration process. I've renamed "UsernameEmail" to "UsernameEmail (Login)" to reflect that it seems to only be used in the login process (when the app is first installed), not in the signup process as denoted by the folder it's located in and the method it's loaded by (some injection through actions/dispatch).
@keybase/react-hackers

Intro

Login

:mag_right: These commits introduced some visual changes:

Added: Username_Email_Login-Waiting

Added: Username_Email_Login-Start

Added: Username_Email_Login-Name_Error

Added: Username_Email_Login-Name_Email

Added: Username_Email_Login-Name

Added: Username_Email_Login-Email_Error

Added: Username_Email_Login-Email

Added: Login_Signed_Out-Single_previous_user (view)
Added: Login_Signed_Out-Multiple_previous_users (view)
Added: Login_Signed_Out-Error (view)
Added: Intro-User_who_just_revoked_device (view)
Added: Intro-First_time_user (view)
Removed: Username_Email-Waiting (view original)
Removed: Username_Email-Start (view original)
Removed: Username_Email-Name_Error (view original)
Removed: Username_Email-Name_Email (view original)
Removed: Username_Email-Name (view original)
Removed: Username_Email-Email_Error (view original)
Removed: Username_Email-Email (view original)

:+1: % style nits

:mag_right: These commits introduced some visual changes:

Added: Username_Email_Login-Waiting

Added: Username_Email_Login-Start

Added: Username_Email_Login-Name_Error

Added: Username_Email_Login-Name_Email

Added: Username_Email_Login-Name

Added: Username_Email_Login-Email_Error

Added: Username_Email_Login-Email

Added: Login_Signed_Out-Single_previous_user (view)
Added: Login_Signed_Out-Multiple_previous_users (view)
Added: Login_Signed_Out-Error (view)
Added: Intro-User_who_just_revoked_device (view)
Added: Intro-First_time_user (view)
Removed: Username_Email-Waiting (view original)
Removed: Username_Email-Start (view original)
Removed: Username_Email-Name_Error (view original)
Removed: Username_Email-Name_Email (view original)
Removed: Username_Email-Name (view original)
Removed: Username_Email-Email_Error (view original)
Removed: Username_Email-Email (view original)


Add implicit access to AppState

Coverage increased (+0.03%) to 27.355% when pulling 945f1fcb38d6a10d74977baeefc7c3dda3493656 on context-state into ba1bdf901a35cc89df135a88bc8d5d44c1275a2d on master.


Constant Reconnecting when logged in

Describe the bug
In the last month or longer Chatterino(1) has been stuck in the reconnecting loop on every channel chat added. Strangely, when I log out everything starts working perfectly
To reproduce
By logging in and out within the client.
Screenshots
Example in Gif
Chatterino version
Chatterino for Twitch (v1.3.3)
Operating system
Windows 10
Additional information
I have tried re adding my account. Chatterino2 does the same to me. Having all the chats or just 1, It's still the same result.

@Shoebug reduce your channel count to >101 (100 or less) (not including /whispers or /mentions)

Having it reduced doesn't help. The problem still persists.

Most likely your auth token expired.
Try adding it new (don't know if deleting one works rn).

Strangely, when I log out everything starts working perfectly

I missed this part, @SLCH should be correct about your auth token being expired

@Shoebug https://i.imgur.com/zvutYSG.png

Not really a Chatterino issue (other than that we don't advertise any limits).
There are limits set to how many channels you can join, and you've exceeded that limit. Not much we can do, sorry.

@Shoebug Although this issue is closed, try lowering your channels to >36. I've been told 35 works on c1. 🤷


Az interactive - cannot import name 'ENV_ADDITIONAL_USER_AGENT´

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az interactive
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'ENV_ADDITIONAL_USER_AGENT'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 658, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 692, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/interactive/custom.py", line 41, in start_shell
    azext_interactive.start_shell(cmd, style=style)
  File "/home/tarjei/.azure/cliextensions/interactive/azext_interactive/__init__.py", line 10, in start_shell
    from .azclishell.app import AzInteractiveShell
  File "/home/tarjei/.azure/cliextensions/interactive/azext_interactive/azclishell/app.py", line 31, in <module>
    from azure.cli.core.commands.client_factory import ENV_ADDITIONAL_USER_AGENT
ImportError: cannot import name 'ENV_ADDITIONAL_USER_AGENT'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az interactive

Expected Behavior
Environment Summary
Linux-5.4.0-1069-azure-x86_64-with-debian-10.2 (Cloud Shell), Common Base Linux Delridge (quinault)
Python 3.6.10
Installer: DEB

azure-cli 2.33.0 *

Extensions:
containerapp 0.2.2
interactive 0.4.3
ai-examples 0.2.5
ssh 1.0.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

interactive


Can't send mail : end of file reached /usr/lib/r..... `read_nonblock'

Hi,
I'm using Huginn in docker with Gmail account to send mails.
I'm trying to use huginn like this : RSS feed to email.
With the email trigger, I have this error :  	end of file reached /usr/lib/ruby/2.2.0/net/protocol.rb:153:in `read_nonblock'
My password had special caracters, so I used quote : same thing.
I changed it with no special caracters : same thing.
I changed the email agent to send basic email :
{
"subject": "You have a notification!",
"headline": "Your notification:",
"expected_receive_period_in_days": "2"
}
Same thing.
Do you have any ideas ?
Thanks

Are you sure you have the email server and port configured correctly in your environment settings? This could happen if the mail server isn't responding.
See this thread from a different project: https://github.com/sameersbn/docker-gitlab/issues/170

I'm think yes because I had an other error with gmail plain / 587. I had to change for login / 465

It looks like 587 is the correct one.  http://serverfault.com/questions/395359/is-the-legacy-smtp-client-submit-port-456-or-465-what-is-the-history-of-thi

Hi,
Thank you !
This is my config :
Same as the picture but with 587 port.
And accept less secure apps :
https://www.google.com/settings/security/lesssecureapps


Automatically scan for types that implement interfaces

In the following schema, a query is defined that returns a list of an interface. Two concrete types implement hat interface.
Today, one has to add these types manually to the schema dictionary. Otherwise, one will get a SchemaClassScannerError, because the classes for the types are not found (for more information, please see issue #97).
I would like to recomment to scan the schema definition the following way:

Find queries that return interfaces (or list of interface instances).
Scan for types in the schema that implement that interface even if they are not directly refered in the query definitions.
Add these types into the schema dictionary.

schema {
    query: Query
}

type Query {
    bases: [Base]
}

interface Base {
    text: String
}

type ChildOne implements Base {
    text: String
}

type ChildTwo implements Base {
    text: String
}

Unfortunately it's not a good idea to scan for implementations of an interface in java, which is why this library doesn't do it already :/
https://stackoverflow.com/a/3123134

That being said I'm definitely open to other ideas about how to discover those children without having to provide them when creating the schema.


Documentation 24.05

Description

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[ ] Copyright and license header are present on all affected files

@AjayRaturi123 Please check mark  the checks


error response after a 'redirect after post'

axios({
      method: 'post',
      url: url,
      data: querystring.stringify(formData),
      headers: {
        'Content-Type': 'application/x-www-form-urlencoded'
      }
    }).then(response => {
      console.log(response)
    }).catch(err => {
      console.log(err)
    })

The code above will fail with code 504,  what i want is response with code 302 or auto redirect.
request do what i want
request.post({url: url, form: formData/*, followAllRedirects: true*/}, (err,httpResponse,body) => {
      console.log(httpResponse.headers)
})

Redirects are automatically followed by browsers so you can never get the original 302. It seems that you're server is returning that 504 for the second request.


WIP Tech/overhaul ui

Refactor state-management en UI

Not ready for review yet

Fixes: https://github.com/storybooks/storybook/issues/3837 https://github.com/storybooks/storybook/issues/3854 https://github.com/storybooks/storybook/issues/3652 https://github.com/storybooks/storybook/issues/3702 https://github.com/storybooks/storybook/issues/3921 https://github.com/storybooks/storybook/issues/2313 https://github.com/storybooks/storybook/issues/3999 https://github.com/storybooks/storybook/issues/1708
Partially:
https://github.com/storybooks/storybook/issues/4139
REFACTOR the state-management & core

[x] REMOVE redux in preview, expand storyStore with it's function
[x] REMOVE MANTRA in manager, use mobX for state management
[x] OPTIMIZE the way stories are stored in state
[x] CLEANUP all addon names
[ ] CLEANUP storyStore api
[ ] ADD ability to send postMessage to multiple iframes/windows
[ ] Split mobx stores
[ ] Connect the mobx stores following best practices
[ ] CLEANUP mobx stores from unused state
[ ] CLEANUP containers / components from unused state
[ ] Add unit testing to mobx stores

IMPROVE the ui

[x] REMOVE treebeard, replace with a custom treeView component

[ ] IMPROVE styling
[ ] ADD support for rootSeperators
[ ] ADD auto-open of selection
[ ] ADD empty message when filtering results in 0

[x] ADD zoom function on preview component

[x] ADD grid function on preview component

[x] ADD eject iframe function to preview

[x] ADD SyntaxtHighlighter component & use it everywhere where's there's code

[ ] ADD UI to toggle panels/fullscreen

[ ] IMPROVE theming

[x] FIX linting

[ ] FIX unit test

[ ] CLEANUP setOptions everywhere to withOptions

TODO:

[ ] https://github.com/storybooks/storybook/issues/244

@ndelangen -- is this reviewable? What would you like us to look at? The PR seems too big to look at

@tmeasday, it's only a WIP. I think in the end there will be more :trollface:

Yes just a start haha

I've checked a bit what's going on here (😱). Can you at least separate the emotion upgrade out of the other changes?
Like: master -> emotion-upgrade -> other-changes

Can you please avoid zebra-table style? It brings a lot more confusion than value

Can you please avoid zebra-table style? It brings a lot more confusion than value
it's themable!

It's something that was suggested by a designer..

Can you please @-mention the desiner here? I would really like to see the arguments

cc @domyen

@domyen which purpose do the zebra stripes have here?

ADD auto-open of selection

I don't like this feature, TBH. I don't want my stories to change when I am just opening the sub-tree... It should be at least optional
Another question:

I feel that this section, is likely to be extended, and there is no place for it in the stories panel. It will be nice to have it in the left side as the vertical tabs (like in the SBNext)
Also, I am missing highlighting of the search results.

The images Norbert shared are WIP and not the final recommendation for the Storybook UI. I suspect lots of changes are underway, so I can't comment much on the specifics of what's currently on branch.
@Hypnosphi Stripes are intended to make the row distinctions clearer. They're a bit over the top right now, expect them to be toned down (a lot!).
@igor-dv Agree! :)

@domyen, is there any sketch of the final UI that you can share?

@igor-dv working on it right now! Give me a day or so.

So here are the designs I'm going to implement on top of this branch:

@domyen But here each row is just one label. Does anyone have some trouble with distingushing them? The problem is, stripes bring the wrong impression like the odd rows are in some aspect different from even ones

AFAIR @shilman used to have some objections agains file-like icons in tree view

@Hypnosphi @domyen  I wasn't the biggest fan of the "heavy" file icons we had, but these ones are less visually intrusive and look pretty 👌 to me.

INVESTIGATE if addon-storysource can use router directly over state method What can I do to help ?

I did a little bit of QA on where we were at and added a list of bugs to the bottom on fhe PR summary above


MSID: 97014 Version: 1 DOI: 10.1101/2<IP_ADDRESS>3208

MSID: 97014
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3208
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=97014
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3208

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/97014v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3208
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/97014/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c37) has a publication-type='other'. Is that correct?


Reduce size of API production image

Problem

Development python packages are included in the final production image for the API and the Ingestion Server. Those aren't needed there and represent a risk; we should be able to remove them easily following a strategy similar to the Catalog with a docker-compose.yml / docker-compose.override.yml files.
Description

Exclude dev packages from the openverse-api and openverse-ingestion_server images.

I have reduced the scope of this issue to only cover the API and not the ingestion server because

The ingestion server does not use PDM so optimising it will be a separate endeavour that cannot share effort with the same endeavour for API.
The ingestion server is already planned to be phased out so there is not much to gain by optimising it in its current deprecated form.


fix: downgrade the TS version to the 4.6.4

Description
As in title. TS versions >=4.7 has a breaking change related to one of internal function. ts-node which oclif uses has a problem with that. See more: https://github.com/microsoft/TypeScript/issues/49257 That PR fixes problem with downgrading TS to the 4.6.4. We should wait for a fix on the side of ts-node and maybe even TS and then bump typescript version to latest.
Run of prepublish script:
npm run prepublishOnly

><EMAIL_ADDRESS>prepublishOnly
> npm run build && oclif manifest

><EMAIL_ADDRESS>build
> rimraf lib && node scripts/fetch-asyncapi-example.js && tsc && echo "Build Completed"

Fetched ZIP file
Unzipped all examples from zip
Build Completed
started command oclif manifest
[ARGS]:  {"path":"."}
[ROOT]:  /Users/---/Documents/AsyncAPI/cli
[PLUGIN]:  {"options":{"root":"/Users/---/Documents/AsyncAPI/cli","type":"core","ignoreManifest":true,"errorOnManifestCreate":true},"_base":"@oclif/core@1.18.0","valid":false,"alreadyLoaded":false,"children":[],"warned":false}
Loading plugin
plugin loaded
[DOTFILE]:  undefined
[FILE]:  /Users/---/Documents/AsyncAPI/cli/oclif.manifest.json
wrote manifest to /Users/---/Documents/AsyncAPI/cli/oclif.manifest.json
end command oclif manifest

Related issue(s)
https://github.com/asyncapi/cli/actions/runs/3265207184/jobs/5367218700#step:7:246

/rtm


Dead code in navbar.js

In navbar.js, there is some code registered to the resize event to restore a visible menu when the window width increases beyond 320px.
However, all visibility and transition animations is handled in pure CSS now, and the action taken by the code does nothing (no context, to my knowledge, where an inline style is applied to the menu element). This seems to be dead code left in as an oversight and should be removed:
    /*
    * Display the navbar back to normal after resize
    */
    window.addEventListener('resize', function() {
        var w = window.innerWidth;
        if (w > 320) {
            menu.removeAttribute('style');
        }
    });

Thanks I will fix that ;)


brew services restart formula no longer start the service if it is not currently running

Previously, regardless of if a service is running or not, executing the command brew services restart formula would start the service (after stopping it first if it is running).
Now, if the service is not currently running, executing the command brew services restart formula does nothing. If the service is currently running, the command brew services restart formula behave as expected.
I think this recent commit caused this behaviour change: https://github.com/Homebrew/homebrew-services/commit/4746bf7263ce807f77ba01214c6992c7b041c2d7
Would it be possible to restore the previous behaviour?

Ah this is very likely the cause of https://github.com/Homebrew/homebrew-bundle/issues/1023 maybe?

That could be, I'm not sure that a restart should silently do start if there was nothing to stop though

@SMillerDev that's how it's been working previously though?

@SMillerDev I cant find any official documentation, this is the closest I could get which I think is the blog post I read when we were moving off of boxen
https://mikemcquaid.com/2016/06/15/replacing-boxen/

I used and improved the Homebrew Bundle tool to allow each project to have a Brewfile with Homebrew packages which are shared at a system level and have background services started automatically.

This would imply brew bundle handles the starting of any services that are necessary IMO

That could be, I'm not sure that a restart should silently do start if there was nothing to stop though

@SMillerDev Yeh, it should, there's a bunch of scripts out there that rely on this behaviour (including brew bundle) unfortunately.

Hey, you approved it 😄. I'll make a PR later today if nobody beats me to it

Hey, you approved it 😄.

😅. I did not review well enough it seems.

I'll make a PR later today if nobody beats me to it

Yes, please ❤

#400

Thanks all for the quick handling!


Cache

1 test is failing when running tests from this branch:
[----------] 1 test from ForkProcessSandbox
[ RUN      ] ForkProcessSandbox.CaptureOutputFromChildProcess
/Users/Stanislaw/Projects/LLVM/llvm/projects/mutang-project/unittests/ForkProcessSandboxTest.cpp:29: Failure
Value of: Passed
  Actual: 2
Expected: result.Status
Which is: 3
[  FAILED  ] ForkProcessSandbox.CaptureOutputFromChildProcess (13 ms)


How to Fetch all tenants from store?

Hi!
Thanks for a great lib. I've been playing with it for a while and I'm confused how to get all Tenants from tenant store?
IMultiTenantStore does not have such method...
This is clear for some stores but not for the ConfigurationStore. The only way is to get it from IConfiguration object but that's not very intuitive.
Any method to get it? Or can you add GetAll method to this interface and implement that in all stores?

Found PR #309

Hi @vermilion
We have a pending PR that will add a method to retrieve them all. Hopefully that will help out.
-Drew


Use S3 module in bastion to prevent older versions from never being deleted

User Story
We have S3 versioning enabled in bastion to allow recovering logs that are accidentally deleted.
We also have S3 lifecycle management configured to gradually transition logs to cheaper storage. Therefore, logs remain in S3 for 30 days before moving to IA (Infrequent Access) storage. After 60 days they move to Glacier and after 180 days they expire and are permanently deleted.
In order to prevent older versions from being retained forever, in addition to the lifecycle policy for the current version we need to configure a separate lifecycle policy for noncurrent versions. Otherwise, older versions will never be moved to cheaper storage and will never be expired/deleted.
The S3 bucket module allows both current and noncurrent version lifecycle management: https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket It would appear to make sense reusing the S3 bucket module in the bastion module.
Value

Questions / Assumptions

Definition of done

[ ] readme has been updated
[ ] user docs have been updated
[ ] another team member has reviewed
[ ] tests are green

Reference
How to write good user stories

https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/pull/11

https://github.com/ministryofjustice/modernisation-platform-environments/pull/105

https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/pull/12

https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket/pull/17

https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/pull/13


Can't type comments properly in

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
When typing a comment inside of a

Our snippets are showing up in script and style blocks. Obviously not desirable.


feat(regexp-assemble): Deconstruct magical regexes for 932

Several data files from 932 contained "magical" regular expression
prefixes. This commit takes them apart and adds comments to the
individual parts, as far as possible.
Replaces https://github.com/coreruleset/coreruleset/pull/2544#issuecomment-1126973082 for v4.1/dev.

Weird that we have conflicts here now. Maybe rebasing?

rebased


Add rclone binary to official docker container or provide an image variant including rclone binary

Output of restic version
0.16.2
What should restic do differently? Which functionality do you think we should add?
It would be really nice to have the latest rclone binary included in the official restic container image (or maybe provide a second container variant as part of the release process which contains the bin from rclone/rclone:latest?).
What are you trying to do? What problem would this solve?
I am evaluating backup strategies for my home-NAS, and after listening to a podcast with Alex I am really keen to start experimenting with restic, which looks awesome!
One thing that is currently providing some headache is the integration of rclone while using the official container image. I am using a backend that only has rclone support, so I need to have the rclone binary accessible in the container, which is currently not the case.
For most NAS distributions, it is really easy to install/update software via docker, so users can pull the official images for restic and rclone, but they cannot easily use the binaries together without potentially messy hacks, relying on 3rd party containers, or building their own container, and thus making things more complicated and losing their systems container GUI- or auto-update functionality.
Kopia decided to do this some time ago, and it just makes it so much easier to use on a NAS with limited build capabilities. Could help a lot of folks to have something similar for restic, especially since this is such an important part of the functionality for many backends.
Thank you for consideration!

rclone has a very different release cycle than restic. To keep the binary up to date, we'd need some automation to rebuild the image. Maybe someone wants to set up the necessary Github Actions to publish such an image to the GHCR?

Ah, I see, you mean building anew container on every rclone update, even if there is not restic update?
I was more or less thinking about the simpler option, just pulling the latest available rclone binary from rclone/rclone at restic build time, not if docker can do this natively by using something like FROM rclone/rclone ADD xyz...

Ah, I see, you mean building anew container on every rclone update, even if there is not restic update?

I had a CI job in mind that runs every few days. rclone usually has a higher release frequency than restic and I'd like to avoid issues that ask for updates.

I was more or less thinking about the simpler option, just pulling the latest available rclone binary from rclone/rclone at restic build time, not if docker can do this natively by using something like FROM rclone/rclone ADD xyz...

With multi-stage builds in docker it's really simple to collect binaries from multiple images.


Fancy multipart forms API

Add an easy-to-use API for creating a multipart/form-data request body and sending it. This API should allow for referencing one or more file streams as form parts. Allowing for files is tricky as described in #7.
There are a couple existing crates we could make use of:

https://crates.io/crates/multipart
https://crates.io/crates/multipart-async
https://crates.io/crates/mime_multipart
https://crates.io/crates/formdata

At first glance, none of these appear to support a fully async writing of forms though, except multipart-async which looks unstable, which is unfortunate.

will this issue be ever resolving? 😄
I wanted to use isahc for my telegram client. but this issue was a blocker :[
https://github.com/ayrat555/frankenstein/blob/master/examples/api_trait_implementation.rs#L113

Technically you don't need this in order to send multipart forms since a multipart form is just bytes. You can craft the request body yourself or use one of the various multipart form libraries on Crates.io to generate such a request body.
One of the primary use-cases for multipart forms is to upload files, but since Isahc's core logic is async, using blocking file I/O is a non-starter. The help wanted label is totally accurate here, since this is a big feature that will require a lot of design and implementation time to do correctly. I'd like to add this at some point though.


Do not log payload

Missed that one.

We can still log payloads and headers, so long as we use an appropriate logger that is clear that it may capture sensitive values. like require('util').debuglog('riff-sensitive')

Sounds good, would you mind if it is done in another PR? That dedicated logger could be used in other places in the invoker as well.


balabolka: Add version <IP_ADDRESS>9

Closes #4460

What is balabolka.echo file??

It stores strings that are part of the settings and should also be persisted, I overlooked it. Also files balabolka.pcfg and balabolka.dat are hidden so Get-ChildItem needs the -Force switch to see them.

/verify


update: January 2024

Fixes README.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1b6cfd7) 90.34% compared to head (4b94a77) 90.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   90.34%   90.34%
=======================================
  Files          11       11
  Lines         352      352
=======================================
  Hits          318      318
  Misses         34       34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


AL - Fatal Alert

Describe the bug
We received a fatal alert for the send function delivering a message to ALDOH 7/16.  Message ID is  a7595980-9178-4d4e-a4bd-7b7ffc24b2c5
Entire message below:
[1;31m23:01:17.100 [pool-2-thread-49][599] FATAL-ALERT gov.cdc.prime.router.azure.SendFunction - FAILED Sftp upload of inputReportId a7595980-9178-4d4e-a4bd-7b7ffc24b2c5 to SFTPTransportType(host=<IP_ADDRESS>, port=22, filePath=./upload, credentialName=null) (orgService = al-phd.elr), Exception: Exhausted available authentication methods, All retries failed. Manual Intervention Required. Send Error report for: a7595980-9178-4d4e-a4bd-7b7ffc24b2c5 to al-phd.elr[m

Hey team! Please add your planning poker estimate with ZenHub @brick-green @greene858 @jbiskie @jorg3lopez @MauriceReeves-usds @oslynn @TomNUSDS

This was in staging. no need to resend


Horizontal scrollbar is hardly usable in Boards / Focalboards

Summary
Hello @kelderek and @esethna, Thank you for your great work on the vertical scrollbar issue (https://github.com/mattermost/desktop/issues/1513 and PR: https://github.com/mattermost/mattermost-webapp/pull/11292)
I'm wondering if it would be possible to apply the same on the horizontal scrollbar, which is not easy to use in Focalboard?

Adding @wuwinson as this would be his area of ownership.

Thanks @biva @esethna! Transferring this to the Focalboard repository. cc @asaadmahmood Thoughts on making the horizontal scrollbar in Boards the same width as the new vertical scrollbar in Channels?


Boilerplate: omit conformance conflict with Complain About: missing-example-ids yes

Previously, if I said Boilerplate: omit conformance and Complain About: missing-example-ids yes, I would be fine. Even if the boilerplate section had <div class="example"> without an ID, there would be no problem.
However, recent attempts to re-build https://github.com/WICG/import-maps/blob/master/spec.bs are failing, because now it seems the processing order has changed, and the check for missing example IDs happens before the removal of the conformance section. So my spec won't build until I remove Complain About: missing-example-ids yes.

Linting example IDs has happened before removing unwanted boilerplate for at least three years (before that the code organization was different and I haven't gone to the effort of tracing further back).
What happened here is that Boilerplate: omit conformance was cargo-culted in from the first commit, and didn't actually do anything, as there was no conformance boilerplate in the spec.  However, I recently added the ability to have default boilerplate per megagroup, like all W3C specs, and included a conformance boilerplate section in the footer.include. Since WICG doesn't define a footer, it started using the W3C version (previously it used the "default" version, which was basically empty).
Anyway, fixed by putting an ID on that example example. ^_^

Heh, yup, example-ID linting has always been processed before unwanted-boilerplate removal. ^_^ https://github.com/tabatkins/bikeshed/commit/d3ca415c3473c439b8e7d0cc3e1dc561fec20174


Fix #144

Problem
In full-convolutional-network model such as InceptionV3 case, it might not be understood input/output data shape of each layers before starting train/predict.
That is model definition is construction like (None, None, None, channels) .
So it might not be able to correctly work visualize_cam .
For details see #144 .
Improvement
It get tensor's shape from actual input/output data, not from model definition.

@raghakot , please review this PR.
Thanks!

Although I'll merge this PR because this PR have passed about a half year, please revert it if you find any problem.
Thanks!


Use memory_address::{VirtAddr, PhysAddr} in the kernel

This depends on https://github.com/hermit-os/rust-aarch64/pull/9

Would probably be an interesting case for continuous benchmarking...


Review & Reconciliation of Blockchain Commons Security Services Contract?

Blockchain Commons is an open infrastructure organization that both offers security review services (largely security architecture reviews and risk/threat models, but rarely code reviews), and will be asking others to review our own code.
In spirit of open development, in addition of sharing our code, we are also sharing our best practices and legal templates. We have just released the first draft of our "security services contract" https://github.com/BlockchainCommons/Open-Development/tree/master/security-services-contract which is intended to be used in future contracts by others of us, but also when we ask others to review our work.
I'd very much be interested in reconciling our contract with the language and concerns of raised by this community, and thus improve it for use by our community. Issues and PRs welcome!

Closing as spam as this doesn't appear to have any direct correllation to disclose.io

This isn’t spam, but closely related. We are defining rules in our agreement that allow us to disclose vulnerabilities despite NDAs, and be able to share some details in research papers. The problem is that most companies asking for paid security reviews want the results to be secret under NDA but as responsible members of the community we can’t do that.
So our goal is to say what we do if we find a vulnerability in code or products & services available to the public. We will report as per your vulnerability policy, but if you don’t have one here is what we will default to.
As your project is also defining best practices for vulnerability policies, it would be useful to see if we can compare and align the disclosure policies.
We hope more security reviewers will ask to not be held under NDA in their contracts with companies, and by offers a “standard” that others can point to that they can get these security review contracts accepted by companies.
I urge you to consider looking out what we are doing, suggest changes to make consideration of what your advocacy is doing, and also help contract-based security researchers in addition to bug-bounty security reviewers change the status quo.
I urge you to keep this issue open until it can be replaced by a better more concrete solution.


D3 Funnel is not work in local

I had download the zip package, but is not work in local. I can not view the funnel and any other.

Now it's ok because of the reference is not work.  but how to show the legend in the funnel chart and how to decision the location of the legend

The lack of a legend is now tracked under #56.


To do list

In this Pull Request, the following changes were introduced:

Created a new React Project. ✅
Added Linters with config files. ✅
Removed unnecessary default files. ✅
Create To-do Container, To-do List & To-do Item. ✅
Added Header to the App. ✅
Refactored code to use Functional Components. ✅
Fixed Linter issues. ✅
Update Readme. ✅

Status: Approve 🍾 👍 🎊
Hi @awais-amjed ,
Congratulations! 🎉 Project Approved ✅
****
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
To Highlight 🥇
Your Pull Request has a proper title and description. ✔
No Linter errors ✔
Your Design looks awesome, keep rocking 🚀
Status: Optional Changes.

[ ] Please kindly delete (all unnecessary files) boilerplate that got created by the CRA (texts, images, and styles), please checkout your public directory and delete them as this will make your repository less crowded.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Thanks :D


Feature: HTTP headers

To test my ingress gateways on Kubernetes, I needed to add support for HTTP headers. I wanted to contribute that back as likely others might need it too.
The headers are a map[string]string read from the configuration yml file.

Thanks! Looks good to me.
I think I nice addition could be a way to declare global HTTP headers one wants to use on every HTTP request, or possibly being able to declare a "named set" of HTTP headers one then could refer to in the yaml.


More fixes for Haskell / Stack

Please have a look at the individual commit messages for the details.

This change is

4th commit message: "ids to not" -> "ids do not"


Handler for Rust's Cargo

Similar to package.json it would be nice to support Ruts's cargo dependencies. Opening in either crates.io or docs.rs

can you test this handler if it works for you? I'm not really using rust so I have little to no knowledge 😄

It works for the most important use cases. You can point a dependency to a git repo, but you have the url there and calling gx on the url goes to the url instead of crates.io, so I think this is not important.

i'm not sure if i understand you correctly. So for example you have a dependency like the following:
regex = { git = "https://github.com/rust-lang/regex.git" }

if you press gx and your cursor is on the regex part you go to crates.io/crates/regex and if you press gx on the url part you go to the github repo - isn‘t that supposed to happen?

btw please provide me with edge cases where gx doesn't work. The more data I have, the better the tool will become 👍

i'm not sure if i understand you correctly. So for example you have a dependency like the following:
regex = { git = "https://github.com/rust-lang/regex.git" }

if you press gx and your cursor is on the regex part you go to crates.io/crates/regex and if you press gx on the url part you go to the github repo - isn‘t that supposed to happen?

This is what I expected to happen yes. Though someone might have a different opinion. Since the dependency is pointing to a git repo, someone might expect to gx with the cursor on regex and go to the github url instead of crates.io

btw please provide me with edge cases where gx doesn't work. The more data I have, the better the tool will become 👍

There are other ways to declare dependencies:
[patch.crates-io.openmls]
package = "openmls"
git = "https://github.com/wireapp/openmls"
branch = "feat/rfc9420"

If you want to follow the current behavior, calling Browse inside the brackets could got to crates.io too. The regex might be tricky though. You can see more examples here: https://github.com/wireapp/core-crypto/blob/develop/Cargo.toml And here: https://github.com/wireapp/core-crypto/blob/develop/crypto/Cargo.toml#L58-L63

Hmm.. I don’t think it would be a good idea to merge this hacky handler and I also don’t know how to improve this (I already tried something with treesitter, but it didn‘t work out). So my suggestion is to abandon this PR until I (or someone else) have the time and resources to properly implement this.

I think what you already implemented will be helpful for 99% of the time and users.
Maybe add a disclaimer in the readme about this "limitation" and merge?

Hm, as I said I'm not fully satisfied with the current behavior, so I don’t like to merge this PR. But you can add a custom rust handler (possible since #47) for this specific use case. E.g.:

require("lazy").setup({
{
  dir = "~/jam-dev/home/gx.nvim",
  keys = { { "gx", "<cmd>Browse<cr>", mode = { "n", "x" }} },
  cmd = { "Browse" },
  init = function ()
    vim.g.netrw_nogx = 1 -- disable netrw gx
  end,
  config = function() require("gx").setup{
    handlers = {
      rust = { -- custom handler to open rust's cargo packages
        filetype = { "toml" },
        filename = "Cargo.toml",
        handle = function(mode, line, _)
          local crate = require("gx.helper").find(line, mode, "(%w+)%s-=%s")

          if crate then
            return "https://crates.io/crates/" .. crate
          end
        end,
      },
    },
  } end,
},
})


DRDT-55: Featured content in homepage (Marquee Plugin)

https://readersdigest.atlassian.net/browse/DRDT-55
Add support for the Marquee functionality.

Created new staging environment for pr-65. Here are some useful links:
WordPress Admin
Homepage
Article
Listicle
Page
Hub

There are visual regressions!
View the full visual regression test report

Congrats! Frontend performance tests passed!
Full Lighthouse performance results:

Page/Branch
pr-65
master
Result

Homepage
91
96
✔

Article
97
98
✔

Listicle
95
98
✔

Page
98
98
✔

Hub
97
96
✔

(Note: Tests are against the NOADS version of the pages!)

Updated staging environment for pr-65. Here are some useful links:
WordPress Admin
Homepage
Article
Listicle
Page
Hub

There are visual regressions!
View the full visual regression test report

Congrats! Frontend performance tests passed!
Full Lighthouse performance results:

Page/Branch
pr-65
master
Result

Homepage
95
97
✔

Article
98
98
✔

Listicle
98
90
✔

Page
98
98
✔

Hub
97
94
✔

(Note: Tests are against the NOADS version of the pages!)

@fariasf i see the conflict in composer.json file. i looked wp-forms-api.js lgtm

Updated staging environment for pr-65. Here are some useful links:
WordPress Admin
Homepage
Article
Listicle
Page
Hub

There are visual regressions!
View the full visual regression test report

Congrats! Frontend performance tests passed!
Full Lighthouse performance results:

Page/Branch
pr-65
master
Result

Homepage
96
96
✔

Article
98
98
✔

Listicle
98
97
✔

Page
98
98
✔

Hub
97
95
✔

(Note: Tests are against the NOADS version of the pages!)


[Compute] Missing support for 'Standard_Fx' VM sizes

The following VM size types from class 'VirtualMachineSizeTypes':
"Standard_F1"
"Standard_F2"
"Standard_F4"
"Standard_F8"
"Standard_F16"
"Standard_F1s"
"Standard_F2s"
"Standard_F4s"
"Standard_F8s"
"Standard_F16s"
"Standard_H8"
"Standard_H16"
"Standard_H8m"
"Standard_H16m"
"Standard_H16r"
"Standard_H16mr"
"Standard_L4s"
"Standard_L8s"
"Standard_L16s"
"Standard_L32s"
"Standard_NV6"
"Standard_NV12"
"Standard_NV24"
"Standard_NC6"
"Standard_NC12"
"Standard_NC24"
"Standard_NC24r"
This causes a deserialization error when user queries VMs that use one of these sizes, as there is no known enum value for it.
See https://github.com/Azure/azure-sdk-for-python/issues/1007

Resolved: https://github.com/Azure/azure-rest-api-specs/pull/1238


CAPTCHA seems unreadable most of the time these days

Some examples:

Same here

Can we at least give temp option to disable it?


Added rgoslin.

This adds the rgoslin library for parsing and normalization of lipid shorthand nomenclature dialects.

https://github.com/lifs-tools/rgoslin


Error occurred when executing InstantMeshLoader

Hi Terry,
followed the install instructions on windows11 - rtx3090 - Cuda 12.1

Visual Studio Build Tools](https://visualstudio.microsoft.com/downloads/?q=build+tools)
ComfyUI-3D-Pack
ComfyUI-InstantMesh

and got error message
Error occurred when executing InstantMeshLoader:
Error building extension 'nvdiffrast_plugin': [1/16] C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1;
Thanks

hi @RegRurutu , could you refer to https://github.com/jtydhr88/ComfyUI-InstantMesh/issues/6, looks like someone got fix this issue.

installing CUDA 12.1 ?
I removed every other version installed previously !
and double checked the env variable CUDA_HOME to point to C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1
Still the same error !


v0.56.0-rc3 - UI - white on gray color problem

on rancher.dev/infra/containers/1i1/volumes:

@lvuch @westlywright Can you find out which theme this is having issues with?

@rvion thanks for bravely testing our RC :smile:

@deniseschannon it's light theme

@deniseschannon I have an open pr with a fix for this

version - master 1/27
Verified fixed


BulkInsertOrUpdateAsync Inserted/Updated date column

Hi,
This is ultimately questions of finding out whether a feature is available or not.
I have recently used BulkInsertOrUpdateAsync and could not be able to insert DateAdded or update DateUpdated column in the table. These fields were not exposed in the Entity class and the assumption that BulkInsertOrUpdateAsync will handle it. Any chance to have those field handled/populated while the execution occurs?
Another question is that does BulkInsertOrUpdateAsync handle many-to-many relationships?
Thanks

To manipulate the columns you need to define them in Entity.
Onyl exception are ComputedColumn
As for Bulk ops to multiple tables you need to do it one by one, so set lists and then Bulk each table.
Also it should be done in a transaction.


Add support for git repo download.

Separate HTTP downloads from RepoActions into separate files；
Add a Downloader interface for subsequent extension；
Add support for git repo download;

CI Test failed with log:  Compiling Swift module Yams failed: (Exit 1):
I got the same error from branch master.


Support using a Terraform module instead of cloudformation?

All our infra is in Terraform and thus would like to use it for this too instead of AWS CF. I am not sure if you are doing something in the cloudformation that can't be done using terraform. If yes, please let me know and I can look into alternatives.

@pksunkara you can easily use terraform to provision the CF stack. I don't think you want to go into reimplementing the whole stack with the native terraform primitives.
I can send you an example if you want.

@crohr Thanks for the response. While what you said is a workaround, I prefer a terraform module instead of a CF stack. Therefore, I want to understand your reasons for why it can't be a terraform module. Is there any capability in CF that can't be done with a terraform module?
Please don't misunderstand me, I am just trying to wrap my head around the choice here.

@pksunkara Reasons for using CloudFormation and not terraform:

1-click install / 1-click upgrades (see demo video on runs-on.com)
declarative, and AWS ensures convergence vs hopefully terraform plans and converges as expected
preview changesets easily, view outputs easily in a UI

All in all, CloudFormation has been a godsend for that project, 10/10 would use it again.

Again I'm not sure what terraform would bring to the project. If you really want to manage the stack with terraform, just import the CF template and use terraform to launch the stack provisioning.


Permissions when installing globally: postInstall can't place config file.

On my dev machine, I need sudo to globally install packages... but I think that user change is stopping me from being able to write the config file to the proper user's home directory.

Now requires a manually-entered command: b8c96361101c648c7602e23f78323859ee153f80.


[Feature Request] Add code scenario to the demo UI

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

Motivation

It would be helpful for people who want to try the demo out for coding tasks
Solution
No response
Alternatives
No response
Additional context
No response

@lightaime @hammoudhasan  I suggest you to play around with Code in Agents till the point we are sure to merge it into the HF agents repo. As of now the updated version is not automatically available on HF and on Camel home page.