refactor merge to allow late discovery of sources

@caolan here is a PR for a refactor of merge that passes all tests but avoids the toArray pre-buffering of sources. Tell me what you think.
this is related to issue https://github.com/caolan/highland/issues/132

@vqvu I went through several version of PR. I ended up taking your algorithm from the 3.0.0 branch and adapting it to allow for late discovery of sources.
I would appreciate if you could take some time to review it ; we could merge this into the 2.x branch and remove it from the patchset of 3.0.0

I don't think it's necessary to look at _incoming.length. We should be able to implement all transforms (besides the core consume) without having to look at private variables.
I also don't think it's correct for two reasons:

consume will use the _outgoing queue in certain circumstances.
A stream constructed with a generator function can generate sources synchronously, but not until the generator is called, so looking in _incoming doesn't work.

An example of (2) is
_(function (push, next) {
    push(null, _([1, 2, 3]));
    push(null, _([3, 4, 5]));
    push(null, _([6, 7, 8]));
    push(null, _([9, 10, 11]));
    push(null, _([12, 13, 14]));
    push(null, _.nil);
}).merge().toArray(_.log);

// Should be
// => [ 1, 3, 6, 9, 12, 2, 4, 7, 10, 13, 3, 5, 8, 11, 14 ]
// is
// => [ 1, 3, 2, 6, 4, 3, 9, 7, 5, 12, 10, 8, 13, 11, 14 ]

I think the solution is to iteratively call pull until there is async behavior, then go into the main merge loop. See getSourcesSync in https://gist.github.com/vqvu/a7838e456783432a2e45.

@vqvu thanks for the review. I agree that using the internal variables was not a good idea (and I was missing the subtlety of _incoming/_outgoing in the case you mentionned).
I squashed the PR and added :

the new test that you mentionned (generation of sync sources via a generator)
your algo from the gist

I simply moved the called to 'next()' from the pullFromAllSources function to the main generator loop. It looked more readable to me.

Awesome! Looks good to me.

Actually, I forgot something. There is a test on 3.0.0 called "pass through errors (issue #141)" that you should copy over too.

@vqvu I backported the test from 3.0.0 and squashed the PR.


dev urls don't match prod urls due to trailing slashes

As in this Issue, there may be a discrepancy in dev and prod URLs which may cause Google indexing to think the site has redirect issues.
We may need to switch URLs to  new URL('./relative', Astro.url) according to https://docs.astro.build/en/reference/configuration-reference/#buildformat , in order to be consistent but I could be wrong.
Also, there seems to be some work going on with astrojs/sitemap https://github.com/withastro/astro/issues/5604 and https://github.com/withastro/astro/issues/5630 to fix this issue.

Hi thanks for opening an issue.
Can you describe exactly where and in what context you are encountering an issue? Is it the generation of links in the pages, or the generation of the canonical URL in the head ie.
<link rel="canonical" href="[http://localhost:3000/hello-astro/](view-source:http://localhost:3000/hello-astro/)">

I have compared the results between yarn dev and yarn preview and they seem consistent, because I am generally generating a URL based on BASE_URL for example
const siteurl = new URL(import.meta.env.BASE_URL, Astro.url)

First I want to say thanks for the beautiful template!
Actually, never mind. I can't reproduce the issue locally either. So I guess I'll close this.
Thinking to myself, my issue may have been related to my deployment (I'm using Clouflare pages).
For all the blog pages, the sitemap that was generated contained blog page URLs that end in a slash (when viewed through yarn preview)
However,  those URLs in production (actually deployed via Cloudflare, not yarn preview) ended up missing slashes when you navigate to them via the site. Even if you added the slash manually, it would redirect to the corresponding URL with no slash. But I ended up just adding a slash to all my urls using (I'm not a JS person and this was just a quick fix):
sitemap({
      serialize(item) {
        // if item path ends with / remove it, then add it back
        let path = item.url.endsWith('/') ? item.url.slice(0, -1) : item.url;
        return {
          url: `${path}/`,
        };

      }
    }),

in astro.config.mjs


mdpress:90:in render': private method render' called for #RedcarpetCompat:0x00000002cf7810 (NoMethodError)

Hi,
it seems it does not work with current redcarpet. As a workaround, I have installed redcarpet 3.1.2 manually and it works.
I'll try to make a fix later.
Best regards
Josef

same here, how can I install that manually?

first, use  gem uninstall redcarpet --v=3.3.2 command to delete redcarpet3.3.2 ， then use gem install redcarpet -v 3.1.2 command to install redcarpet3.1.2

Thanks @sils1297 .
with your advice, this error was solved.
In addition, Maybe gem uninstall parameter '--v' should modify as '--version' according to real version.
In my computer:
$ sudo gem uninstall redcarpet --v=3.3.2
ERROR:  While executing gem ... (OptionParser::AmbiguousOption)
    ambiguous option: --v=3.3.2
$ redcarpet --version
Redcarpet 3.3.3
$ sudo gem uninstall redcarpet --v=3.3.3
ERROR:  While executing gem ... (OptionParser::AmbiguousOption)
    ambiguous option: --v=3.3.3
$ sudo gem uninstall redcarpet --version=3.3.3
...
$ sudo gem install redcarpet -v 3.1.2
...
successful.


Network Error while running the kong services

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong Enterprise <IP_ADDRESS>
Current Behavior
After running the kong  services the server get started but when we are opening the dashboard in the browser we got "network error"

Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
No response

Hello @AliHumadi2000,
you report that you're using Kong Enterprise, but this repository is for the open source version of Kong.  Can you reach out to your official support contact at Kong to get help, please?
Thank you,
Hans


Update CI for Fedora 38

The CI for the koji-osbuild plugin needs to be updated to test on Fedora 38.
https://issues.redhat.com/browse/COMPOSER-1917

@supakeen Please take a look if related PR will satisfy this issue requirements.

I am reopening this as related PR is still not merged due to some issues and was closed automatically due to iddle.


Should I still see my page-specific js file ?

Hi,
Rails rookie here. found your superb gem through a blog post.
I implemented  on a deal_page.html
I want deals.js only to load on deals_page and NOt on the homepage.
Is it normal that on LOCAL mode (localhost:3000), when I check chromde dev tools list of files loaded I still see deals.js on the homepage?

@misner
Paloma is not selectively LOADING javascript files, rather it is selectively EXECUTING javascript code.
So to answer your question, every js file will still be loaded, but not all of them will execute.
If your deals.js contains something like this:
var DealsController = Paloma.controller('Deals');

DealsController.prototype.index = function(){
  // this will only execute on route deals#index
};

It will still be included/loaded on every page. But the index function will ONLY execute when you render the index page of Deals.

thanks a lot for your reply.
I see.
I thought I could do with Paloma :
(A) only execute certain javascript depending on the loaded page
(B) also only load certain javascript according to the loaded page (why? to optimize the size of files loaded for that page. For example, why burden the load time with deals.js if I only need it when the page /deals.html load...
So if I get you right, I can only do the (A) with Paloma ? not B?
Rookie here :) so I'm trying to be sure I understand Paloma right.

@misner
Yes. You can only do option B with Paloma.
I agree with you, you should minimize the javascript loaded on your home page to make sure that it will render fast. But for the rest of the page, I think it is alright to load all javascript. You may want to read about the Rails Asset Pipeline about it (http://guides.rubyonrails.org/asset_pipeline.html#main-features)


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
0bb608c -> 111aff9

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.28.4 -> v1.28.5

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.28.5
Compare Source
Bug Fixes

deps: update gomod (#761) (e57b7c5)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: .github/workflows/release.yml
Command failed: export CUSTOM_DIRECTORY=/tmp && export PATH=$PATH:/tmp && make dependency-install-darwin-linux
curl: (7) Failed to connect to github.com port 443: Connection timed out
make: *** [Makefile:65: dependency-install-darwin-linux] Error 7

/run pipeline

/run pipeline

:tada: This PR is included in version 1.1.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update GetEmbeddedKernelResources

With this new PR merged into Jupyter Core, we can remove the "hack" in here to allow proper directory structure and naming with / once the next release rolls around for Jupyter Core and the version in this repo is updated.

@theRoughCode releases of Jupyter Core are handled manually on an as-needed basis; there's no regular release cadence for that package. Let me know if you'd like more details on that, and I'd be happy to help get a new release pushed.

Sounds good! I guess the change doesn't impact any existing files, so we could wait for the next release (whenever that might be). Or if you think that it would be useful to include that change, we can do that and I can work on the fix. :)

Makes sense! I think if this doesn't affect anything immediately then there's no need to do it right now. We can just leave this issue open as a reminder to do it after the next release of Jupyter Core.


client.query - error client is undefined method in the contoller

I have been using v0.3 for a long time and a typical query like this works great:
      videos_query = Parse::Query.new("Videos").tap do |q|
      #q.eq("UserTagID", current_user.UserTagID)
      q.eq("CompanyTag", current_user.CompanyTag)
      q.eq("videoPrivacy", 'No')
      q.order_by = "-videoCreatedAt"
      q.limit = 1000
      @results = q.get
      end.get

Now I have migrated to parse server and so have been trying to use the latest version from the master branch so as to be able to specify my Parse Server URI.
The new documentation seems to show replacing Parse::Query.new with client.query. However when I do that it crashes the controller because client is an undefined method.
Any suggestions would be much appreciated,
Tom

@OpConTech hi, can you show me how you create the client? You have to do something like that:
client = Parse.create ...
query = client.query("Videos").tap do |q|
....
end

Hi rhymes,
I don't do that on the line above but I am able to get this to work in an initializer parse-client.rb
---- parse-client.rb --------
::MyParseClient =  Parse.create
:application_id      => ENV['PARSE_SERVER_APPLCATION_ID'],
:api_key             => ENV['PARSE_SERVER_API_KEY'], # optional, defaults to nil
.....
Before in v0.3.0 I didn't have to do this the existing Parse::Query.new  just worked in the controller
videos_query = Parse::Query.new("Videos").tap do |q|
Using the initializer I showed above I have been able to get this to work today:
videos_query = MyParseClient.query("Videos").tap do |q|
But is there a better way to do this than what I have above? Or do I have to replace every Parse::Query.new in my code to  MyParseClient.query( in order to use the v1.0.0 alpha?

Yes, the 1.0 breaks compatibility to remove the singleton object that was present in the 0.3.

Thanks rhymes. Based on your feedback I have the queries working now.
One more quick question to help me finish the transition from 0.3 to 1.0.0 alpa.
I have been defining current_user in the application_controller.rb as:
----------- application_controller.rb------------------
private
def current_user
@current_user ||= User.find(session[:user_id]) if session[:user_id]
end
// Note User.find  is from the old parse-resource gem
But I am having trouble getting this to work correctly in v.1.0.0 alpha because when I try:
@current_user ||= Parse::User.find(session[:user_id]) if session[:user_id]
the compiler lets make know that Parse::User in v1.0 does not have a .find method.
Any chance you might know a good way to define a global @current_user in v1.0?

@OpConTech I'm not sure how parse-resource works, I've never looked into it.
You could create a method "find_user_from_parse" or whatever that just uses parse-ruby-client, see how you can retrieve users: https://github.com/adelevie/parse-ruby-client#retrieving-users
Or you could just keep using parse-resource as before, it's not maintained but if it's still working for you why change it?

@rhymes I'm still struggling with a way to setup current_user in parse_ruby_client.
With parse_ruby_client after you have logged in using:
user = Parse::User.authenticate("username", "password", client)
how do you create a current_user so that in any controller you can check the status as well as pull data from the fields in the current_user object.
Is there a Parse::User.current_user or something?
Any help would be much appreciated.

No, because current_user in Rails is part of, for example, the devise Gem. It's an helper method injected in the controller and the view. Definitely not parse-ruby-client's responsibility.
I think you're looking to define a global variable, there are many ways to go about it: http://dalibornasevic.com/posts/9-ruby-singleton-pattern
Know that probably none of those are thread safe (if your app uses multi-thread it might be a concern), this is a thread safe option http://bonamin.org/blog/2012/03/06/thread-safe-global-variables-in-ruby/
Hope this helps, I'm closing this because it's out of the scope of the library.


ci: remove coverity

Signed-off-by: Loong Dai<EMAIL_ADDRESS>Coverity scan has been abandoned for a long time, remove it at this point.


Display of changed for 'napalm_configure' is always True, even when forced to False

nornir==3.3.0
nornir-napalm==0.2.0
nornir-utils==0.2.0
Python 3.8.10
--
I'm new to nornir, so I'm not sure yet how the changed: True | False works exactly yet. Is this related to the dry_run variable? Maybe this is not relevant as an issue...
How to reproduce:

I run the following task, in dry_run, so I am not expecting any changes on the device.

task.run(
        task=napalm_configure, dry_run=True, configuration="interface loopback 1000"
    )

And in the output, I see:
---- napalm_configure ** changed : True ---------------------------------------- INFO
I would expect to see False. Is this normal?

https://nornir.readthedocs.io/en/latest/api/nornir/core/task.html?highlight=dry_run#nornir.core.task.Task.is_dry_run
I guess I should have started here!
changed True if the task is changing the system
which is different from the dry_run variable


Allow downloading of root_files in a chef repository

A FileSystemEntry with a nil parent is a "root directory" and thus
should exists so long as its filesystem path exists. This was preventing
the download of files such as invitation.json whose parent directory is
a root directory.

This is currently breaking knife-ec-backup.  I'm not particularly thrilled with this solution, but I've exhausted the time I can put into it at the moment. My "not thrilled"-ness comes from the fact that it seems like we should always be representing the root chef repository dir with ChefRepositoryFileSystemRootDir or FileSystemRootDir objects.  I also think it would make more sense if we defined the root dir as being its own parent which would save us from carting around nils.

cc @chef/lob @jkeiser @chef/maintainers

LGTM :+1:

:+1:


Add a CI build for JDK 19

Flushes out an issue with Http Client.

@swankjesse requesting post review


fix: #6 cursor placement

Alaska Airlines Pull Request
Fixes: #6
Summary:
This update will address the bug related to moving the cursor on iOS safari.

Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updates requests library and removes urllib pin

Removes a pinned dependency for urllib and updates requests to latest.

I'm guessing it wasn't intentional to also re-lock dependencies like black to new versions?

You are correct that it was unintentional. I think I need to do a poetry remove on urllib and poetry update requests with those two. Will fix up.


Add missing columns to blended_skill_talk

Adds the missing columns to blended_skill_talk to align the loading logic with ParlAI.
Fix #4426

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Move armada to a neutral github organization

As a CNCF sandbox project, please move to a neutral github organization

Hey Chris, thanks for filing the issue and coming by.
Can you help us understand what is meant by a neutral github organization, and give us a pointer to the CNCF policy that requires this be moved?
Thanks in advance!

https://github.com/VSCodium My bet is its similar to the idea of this repo that exists for vscode?

I'd create something like https://github.com/armadaproject to host the
project and move relevant repos over.
The code can not live in a non neutral or company affiliated organization.
On Wed, Oct 5, 2022 at 3:57 PM Adam McArthur @.***>
wrote:

https://github.com/VSCodium My bet is its similar to the idea of this
repo that exists for vscode?
—
Reply to this email directly, view it on GitHub
https://github.com/G-Research/armada/issues/1594#issuecomment-1269077799,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSIMKWZQRGQ3EW6GTUIDWBYBUFANCNFSM6AAAAAAQ5XO6FA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Cheers,
Chris Aniszczyk
https://aniszczyk.org

@Chris - this namespace is purely for open source tools that we are exporting from our organization. G-Research isn't a commercial entity selling any sort of product. Any chance we could get a pass on this for now? We're hoping to get everything else on the sandboxing checklist done by kubecon.

we don't want to conflate repos in your organization that aren't part of CNCF with what is inside of CNCF, I've created https://github.com/armadaproject and invited you as an owner

@Chris - it looks like I'm just a member in the new org. Can I get admin access so I can make sure things are ready for the transfer?

@caniszczyk We migrated armada to a neutral github organization now.


Bayes model selection

This adds additional information to the analysis results and gets rid of the ModelComparison class. Now, AIC, DIC, BIC are calculated after a fits and saved in the AR. This requires an additional universal abc method in plugin prototype to return the number of data points used. For binned spectra, this is just the total number of channels used in the fits. For unbanned spectra, it is the number of points used to evaluate the likelihood. @giacomov I have put some dummy functions in for the Fermi/HAWC plugins for you to update. All other plugins should be taken care of, except that I think you switched VERITAS to its own plugin.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@df2bd97). Click here to learn what that means.
The diff coverage is 92.75%.

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage          ?   74.72%
=========================================
  Files             ?      118
  Lines             ?    11981
  Branches          ?        0
=========================================
  Hits              ?     8953
  Misses            ?     3028
  Partials          ?        0

Failing dude to the merge with the master branch which was failing. I will try to fix.


Move documents on SoyBase Classic to annex

https://data.legumeinfo.org/annex/Glycine/max/

Clean up file name to remove special characters
File type needs to changed / remove white space and line endings.

Need to go through folders and make sure all is copied and organized.

@jd-campbell  work on during Christmas break

I have found a large amount of PDF, doc, docx, xls, xlsx, jpg, and tiff files.  I have sent emails and scheduled meetings to sort out what to do with these files.

I have not received any invitations yet
Sent from my iPhone
On Dec 27, 2023, at 5:55 PM, Jacqueline Campbell @.***> wrote:

I have found a large amount of PDF, doc, docx, xls, xlsx, jpg, and tiff files. I have sent emails and scheduled meetings to sort out what to do with these files.
—
Reply to this email directly, view it on GitHubhttps://github.com/soybase/jekyll-soybase/issues/68#issuecomment-1870699118, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADLL6224WQVUZJCS5QI2HNTYLSYOHAVCNFSM6AAAAABALVMP4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGY4TSMJRHA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Add affy soychip probe hits to annex


set_at or rollback

Because sometimes you need to advance the lexer backwards.

Not necessarily against this, though in most cases this should be avoidable. If you are going to re-lex a portion of input that's been already lexed, you are doing a lot of extra work that could be avoided by caching tokens if you are constructing grammar with some ambiguity.

Sometimes a grammars can be a bit ambiguous, so a small lookahead, like a single char, is useful to disambiguate between token types. On extreme cases, like heredocs there's even a need to jump around the source code.
As the simplest solution, would it make sense to change bump to use isize instead of usize? Or maybe a seek function that uses absolute positioning instead of relative?
This would still put the onus on the developer instead of making Logos more complex, with implementing lookahead in the regex, similar to the approach taken by Ragel.


WIP: Silverstripe 5 support

I've upgraded the composer dependencies and made a start on the React application by following the SS4 - > SS5 migration path, but I'm unable to figure out the build tooling to compile the React 18 source.

What's the status here?

The React application needs to be upgraded and some breaking changes need to be fixed. I lack the skills needed to do this myself. There's more to it than the quick fix suggested above


feat: add JAVA_OPTS configuration

This PR try to make it super easy for people to be able to configure their Java options by need. Like this:
{
  "kotlin.java.opts": "-XX:+UseParallelGC -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Dsun.zip.disableMemoryMapping=true -Xmx4G -Xms4G -Xlog:disable",
}

This is useful for development with big repository.
Alternatively, user environment variables would also work just fine.

Good work, thank you very much.


%UPSTREAM_CLUSTER% in logs is empty in case of no_healthy_upstream

Title: %UPSTREAM_CLUSTER% in logs becomes "-" when there are no healthy upstreams for the matching cluster.
Description:
Envoy should return proper %UPSTREAM_CLUSTER%, even if there were no requests made for that cluster.
Config:
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address: { address: <IP_ADDRESS>, port_value: 8080 }
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          stat_prefix: ingress_http
          access_log:
          - name: envoy.file_access_log
            config:
              path: /dev/stdout
              json_format:
                upstream_cluster: "%UPSTREAM_CLUSTER%"
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains: ["*"]
              routes:
              - match: { prefix: "/" }
                route:
                  cluster: my_service
          http_filters:
          - name: envoy.router
  clusters:
  - name: my_service
    connect_timeout: 1s
    type: static
    load_assignment:
      cluster_name: "my_service"
      endpoints:
      - lb_endpoints: []

Logs:
{"upstream_cluster":"-"}

yeah, looks like we only get the cluster from the host, so if a cluster is selected but a host is not found, it wouldn't log
https://github.com/envoyproxy/envoy/blob/master/source/common/formatter/substitution_formatter.cc#L641


Update versions of components

Fix EDK2 version numbers.
Make coreboot/EDK2 versions for MSI boards up-to-date.

Do we want to merge it now or after the release?

@krystian-hebel We can merge it now, it won't change.


Create WG Template

For review by the TAC

Thanks @jmertic.  We'll review at TAC meeting before merging.

Thanks @dheckenberg ! Unless you think it should be reviewed by the TAC specifically, I'd say bring your suggestions into this PR and let's incorporate now.

@jmertic I agree with JF's suggestions.  Can you make these changes or would you like JF to submit them in subsequent PR?

@dheckenberg I think since this PR is still open, it would be best for @jfpanisset to submit any changes to this one if that's ok.

@jfpanisset could you submit your suggestions as changes to this PR?

I'm not sure I know how to submit changes to an in-flight PR. I tried following the instructions at:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
but was unable to push my changes back to the wg-template branch, presumably since I don't meet the pre-requisites for this workflow. Might be easier to just let this PR go in, and I'll submit these changes on top of it?
I really need to get better at git / github...

Yeah - not sure what the issue is but I attempted to merge in your suggestions @jfpanisset. Let me know if I missed anything.

@jfpanisset  Ok to merge?

Yes, looks like my comments were incorporated.


Put on conda

Talk to Flatiron SCC about this, since they've done it for some packages.

Chiming in here from the pyOpenSci review:
I would suggest putting the package on conda-forge. Their guide is here: https://conda-forge.org/docs/maintainer/adding_pkgs.html
I haven't tested but my impression is you'll be able to generate a recipe with grayskull.
Note that any dependencies will also need to be on conda-forge; in your case I think this includes pyrtools, which might be a bit more tricky to make a conda-forge recipe for if there's a build involving C code.

Thanks for the pointer! I've hesitated on this partly because I'm not sure what the advantage of being on conda-forge is. Our installation from pip works fairly well (that is, I haven't had people report issues with it), so what's the advantage of additionally getting up on conda-forge?
(And yes, our dependencies include pyrtools, which does include C code)

I'll explain when I post my review, and raise a related issue.
Basically:
(1) you should prefer to install conda binaries into a conda environment -- for reproducibility, pip should only be used "after" conda
(2) having conda-forge build and render a binary with their infra IME is less painful then doing all the work to get a package on your own personal channel on anaconda.org, and also makes it easier to collaborate on maintaining the binary through a GitHub repo

One wrinkle here might be that pip allows for optional dependencies, which plenoptic includes (pip install plenoptic[dev]). conda doesn't and might never support this feature (https://github.com/mamba-org/boa/issues/245). Is the recommendation from pyOpenSci in such cases to build the environment and install with pip last, and forego the conda build?

Hi @EricThomson :wave:
Not sure if there's an official pyOS recommendation here yet.
Thanks for asking, we probably do need to address this somewhere in the pyOS docs.
Would you mind raising an issue on the guide suggesting we explain how pip's optional-dependencies relate to conda? We do show using something like pip install -e .[tests] in our guide.
The short answer: AFAICT there's no mechanism in conda right now that directly maps to pip's optional-dependencies.
See https://github.com/conda/conda/issues/7502 where it seems like the current answer is a "meta-package" where each group of optional dependencies is given a different package name, e.g., conda install tensorflow-gpu or conda install tensorflow. But I don't find good examples of this.
Several Conda Enhancement Proposals have proposed adding a "conda install package[extra]" like-syntax to conda but again AFAICT none are accepted and implemented

https://github.com/conda/conda/issues/11053
https://github.com/conda/conda/issues/11053
That is all based on five minutes of me googling though, so I will check in the pyOS Slack with people involved in conda and conda-forge to make sure we are up to date.

If you as a developer are using optional-dependencies as a mechanism to add dependencies to your dev environment, though, I wouldn't go to all the trouble of building a metapackage or something like that. This is a very common use case, like your pip install -e . "plenoptic[dev]" shows.
Some people have strong feelings about it
.
The short answer here is that if you develop in a conda environment you probably want to have separate files that devs can use, e.g. plenoptic-dev.yaml. In pure Python you will see people do something similar with a dev-requirements.txt file, and/or lockfiles for dev environments.
Personally I prefer to develop in pure Python because it's one less layer of things to deal with. If it all possible I'd rather set up development so that conda-forge does all the work for me, but that does require doing more work up front; like for you all you might need to release a conda-forge package of pyrtools first, or vendor whatever functions you use from pyrtools inside plenotpic. Might be worth double checking how much of plenoptic actually depends on / needs to depeon on pyrtools.
Some of the (pure Python) swiss-army-knife dev tools provide a way to specify these dependencies without adding them as optional-dependencies: e.g., hatch has the concept of environment dependencies, poetry has dependency groups. PDM also allows specifying a group, but it just adds them directly to optional-dependencies.
My approach is to add to optional-dependencies "by hand" and then have nox sessions that will run something like pip install . -e "myproject[dev]" for me. Better yet, nox will run them for for a contributor that doesn't want to bother with learning all this stuff yet.
Also worth noting here you can use recursive optional dependencies so that "dev" includes "docs" and "tests".
Does that answer your question?

Hi @NickleDave thanks a lot for this very thoughtful reply! I should qualify this with my "contributions" to plenoptic are solidly in the form of minor PR reviews and lurking/fandom rather than substantive. 😆 Hence, Billy's thoughts ought to be weighted heavily here (like...infinity). He also knows a lot more than I do about package management/publishing, I've just started to really wade into these waters.
I will have to really think about your reply and the material you suggested: it is very useful and a lot for me to process. I think also raising an issue at the guide is a good idea, as I don't want to sidetrack this particular issue.
Sidenote: I brought this up partly because I use tools like Deep Lab Cut in which these optional dependencies are used for essential subpackages (compared to the more developmental bits that users shouldn't have to think about like docs and dev). Also, in a package I maintain, we've internally discussed a lot whether we should split it into two packages so we can continue to ship to conda, just because they don't support optional dependencies. It's a real quandry.
Anyway, thanks so much for your time I will definitely follow up, but probably outside of this thread so I don't sidetrack Billy's review 🥲

Thanks for bringing up the optional dependencies issue @EricThomson ! Like @NickleDave pointed out, in plenoptic they're all developer dependencies, so I think providing the extra plenoptic-dev.yaml file will be sufficient.y
Since I also maintain pyrtools, I can look into getting it on conda as well, though it will be more complex because it has some compiled C code. plenoptic does not rely on pyrtools very strongly (just a handful of functions and, in particular, it doesn't use the C code at all) -- @NickleDave I'm unfamiliar with "vendoring functions", what does that mean?

I'm unfamiliar with "vendoring functions", what does that mean?

Ah, sorry, by "vendor" I mean "copy source code" from pyrtools into plenotpic
Like the way pip vendors rich
What I was saying if you only use a handful of functions, maybe you should just copy those into plenoptic :slightly_smiling_face:

@EricThomson thank you for raising an issue about this.
I also started a topic about this in the pyOpenSci Discourse if you want to add feedback there: https://pyopensci.discourse.group/t/optional-dependencies-in-conda-discuss-in-guide/422
We're trying to have more general discussions there in a more public way (kind of like Python does with PEPs etc.)

As an followup: is the main reason this is necessary because I describe using conda in my install instructions? (And so changing the instructions to use venv or some other virtual environment manager would eliminate the need to get on conda.) Or is it generally a good idea to get on conda regardless?

This is purely based on my experience and what I know about your package: I think it's worth getting a package on conda-forge. That's because you depend on torch and for a lot of people the easiest way to install torch + NVIDIA etc will still be using conda. My understanding might be out of date because I have noticed there is an nvidia python package.
It also might be worth it for no other reason than that you will have a lot of scientists who are used to conda and you want to make things easy for them and you want to make environments replicable.
This is the cost as developers we pay for having both pip and conda.

Opened a PR for this on conda-forge: https://github.com/conda-forge/staged-recipes/pull/25506

We ended up splitting this into two PRs, one for pyrtools, and one for plenoptic. The plenoptic one does not have a Windows build, because there's no Windows pytorch build on conda-forge (issue tracking this). I'll continue to watch that issue and hopefully eventually that will get solved.
I'll link this issue to the PR adding conda install instructions once I open that in a bit. That PR will close this one.


Watch for new pods when logs --follow

What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6058
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/override windows-integration-test/Windows-test
odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] should serve endpoints
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:87
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4281/tests/integration/cmd_dev_api_server_test.go:101
[...]
Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

/override "SonarCloud Code Analysis"
Duplicate code on Mocks


update from upstream

chore(deps): bump github/codeql-action from 2.1.14 to 2.1.15
chore(deps): bump rust from 1.61.0 to 1.62.0
feat: more rust 1.62
chore: and more 1.62
chore: added script to easily update from upstream

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.372%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
38

Relevant Lines:
43

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Design System >Elements > File Uploader > All stories multiple -true upload file display twice file.

Describe the bug
Check All stories twice file.
Design System >Elements > File Uploader > Controls > Multiple -True Then select 1 file display 2 & select 4 display 8.
Steps to reproduce bug

Go to 'https://https://stage-react.raaghu.ai/'
Navigate to 'Design System >Elements > File Uploader > Controls > Multiple -True'
Then select 1 file display 2 & select 4 display 8.

Actual result-
Check All stories twice file.
Design System >Elements > File Uploader > Controls > Multiple -True Then select 1 file display 2 & select 4 display 8.
Screenshots

Expected result-
When Multiple is set to True, the component should allow users to select and display files as follows:
Select 1 file: The component should display exactly 1 file.
Select 4 files: The component should display exactly 4 files.
Desktop (please complete the following information):
-OS: [Windows 10 Enterprise]
-Browser [ edge]
-Version [ 125.0.2535.92]

Fixed on dev

Fixed on stage

Issue still exists on stage
File Uploader > Drop Area Side Icon > Control >Multiple - True/ False not working proper.

Fixed on dev

Fixed on stage


Updated imgui.net to 1.89.1

I went ahead and updated to v1.89.2, which includes a change to the generator so that ImGuiKey retains backwards compatibility.


fix simplify range produce true when reference is nullable

if reference is nullable, even if range is all, we should not return true, but should return reference is not null. for example,
before simplify: c1 > 5 or c1 < 10
after simplify:
c1 is nullable: c1 IS NOT NULL
c1 is not nullable: TRUE
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run feut


Support force login

I missed this PR. I've added quite a number of changes that made this PR conflicting so I've added the changes from this commit separately onto the branch at 3d46014
This PR will now be closed


error when opening the zip file

Describe the bug
windows default in-built archive tool gives error,
7-zip works fine, so its windows archive tool issue... small indie company.  😄
btw i had same issue in previous releases aswell.
feel free to dont care about this, cuz alternative zipping software works.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: WIndows 11 24H2 (26100.1742)

Hi, thanks for tracking this issue!
Personally I made 7zip my default archive opening app so I really didn't make sure this was an issue... but it is now fixed with the latest commit 0dd738ef9972e9c0911be41087acd711fcaa7177 (this time I did test it 😅).
This build tooling change will be applied from the next build onwards!


Rename the extension

With recent changes the extension name should change to reflect latest changes.

Fixed in https://github.com/microsoft/vscode-edge-devtools/pull/134


Create a permission entry for WinSW

See https://github.com/kohsuke/winsw/

I want to release 1.19.1 to fix the versioning issue.
This release won't actually go into Jenkins since there is no functional changes. After the release I will work on winsw-2.0 integration

:+1: the path is good http://repo.jenkins-ci.org/public/com/sun/winsw/winsw/


Formatting for many args

Would be nice to get functions with lots of arguments be reformatted to look like:
function longfunctionname_that_is_long(
        lots,
        of,
        args,
        even,
        more,
        args
    )
    ..code..
end

Instead of:
function longfunctionname_that_is_long(lots, of, args,
                                       even, more, args)
    ..code..
end

Same applies for function calls, keyword arguments etc!

pinning https://github.com/JuliaGeometry/TetGen.jl/blob/master/src/cppwrapper.jl#L198-L216 for an example.

@SimonDanisch would you agree if that function definition, etc exceeds the line length to nest it like above?
I think actual function calls should probably remain as
foo(a,
    b,
    c)

Instead of
foo(
    a,
    b,
    c
)

what do you think?
Also how should the args be indented in the function def?

How's this https://gist.github.com/domluna/d381483879eb287e1e0a6fb3cf13f5ec?

Sorry, I first was on vacation and then I got side tracked while commenting :D This looks great :)
Although, I usually try to make this:
dict = Dict{Symbol,Any}(
        :numberofpointattributes => NAttributes,
        :numberofpointmtrs => NMTr,
        :numberofcorners => NSimplex,
        :firstnumber => Cint(1),
        :mesh_dim => Cint(3),
    )

Like this:
dict = Dict{Symbol,Any}(
    :numberofpointattributes => NAttributes,
    :numberofpointmtrs => NMTr,
    :numberofcorners => NSimplex,
    :firstnumber => Cint(1),
    :mesh_dim => Cint(3),
)

Since the closing bracket still seems to clearly belong to dict and it wastes less space ;)

But the former plays nicer with Junos  indent based block recognition

With #14 this is (assuming indent width is 4)
function longfunctionname_that_is_long(
    lots,
    of,
    args,
    even,
    more,
    args
)
    ..code..
end

and
dict = Dict{Symbol,Any}(
    :numberofpointattributes => NAttributes,
    :numberofpointmtrs => NMTr,
    :numberofcorners => NSimplex,
    :firstnumber => Cint(1),
    :mesh_dim => Cint(3),
)


[CARBONDATA-2988] use unsafe for query model based on system property

use unsafe for query model based on sytem property
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/629/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8890/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/635/

@xuchuanyin I don't what is the purpose of doing this? Please elaborate problem in PR description.
This variable is added to avoid JVM crash when freed multiple times. I am not getting why this should be configurable.

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/830/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8900/

@ravipesala @kumarvishal09 We have encountered JVM crash problem.
The dump file complains

Clearly it is unsafe memory related problem. Since in the previous PR, we have disabled the unsafe for query, I think in this place we should disable the unsafe accordingly.

@xuchuanyin This problem is fixed in PR https://github.com/apache/carbondata/pull/2793

OK, I'll close this PR instead


Remove Tpetra::Distributor dependency of Search package

Also replace Teuchos::Comm by raw MPI communicator in the interface of the distributed search tree
The interesting part is in the definition of Details::Distributor that is replacing Tpetra::Distributor.  For now I decided to keep the same interface.
The PR is marked as "work in progress" because I still wanted to revisit the extract_and_sort_ranks() routine but reviews and comments are welcome at this time.

Codecov Report

Merging #516 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +<.01%
==========================================
  Files         127      128       +1
  Lines        9251     9245       -6
==========================================
- Hits         8898     8893       -5
+ Misses        353      352       -1

Impacted Files
Coverage Δ

...s/Meshfree/src/DTK_NearestNeighborOperator_def.hpp
100% <ø> (ø)
:arrow_up:

...earch/test/tstDetailsDistributedSearchTreeImpl.cpp
97.16% <ø> (-0.59%)
:arrow_down:

packages/Meshfree/src/DTK_PointCloudOperator.hpp
100% <ø> (ø)
:arrow_up:

.../Meshfree/src/DTK_NearestNeighborOperator_decl.hpp
100% <ø> (ø)
:arrow_up:

...eshfree/src/DTK_MovingLeastSquaresOperator_def.hpp
100% <ø> (ø)
:arrow_up:

...kages/Discretization/src/DTK_Interpolation_def.hpp
100% <ø> (ø)
:arrow_up:

...shfree/src/DTK_MovingLeastSquaresOperator_decl.hpp
100% <ø> (ø)
:arrow_up:

...est/tstMovingLeastSquaresOperatorSimpleProblem.cpp
98.55% <ø> (-0.05%)
:arrow_down:

packages/Meshfree/src/DTK_DetailsSVDImpl.hpp
99.14% <ø> (ø)
:arrow_up:

packages/MapFactory/src/DTK_C_API_Map.hpp
89.15% <ø> (-0.13%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a52f0...0973c59. Read the comment docs.

Ready for review.  I am not sure what's going on with the timeouts.


Extension host terminated unexpectedly.

/needsMoreInfo
Does this also happen with VS Code Insiders? Download: https://code.visualstudio.com/insiders/

cannot reproduce, thanks


[DOC] Cite source of pretrained parameters for bert_12_768_12

Description
Cite source of pretrained parameters for bert_12_768_12 in docstring and on modelzoo.
Fixes #896
Checklist
Essentials

[X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage
[X] Code is well-documented

Changes

Cite source of pretrained parameters for bert_12_768_12

Comments

@eric-haibin-lin

Job PR-915/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-915/1/index.html

Don't merge yet, turns out there is some issue with the links on the http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-915/1/model_zoo/bert/index.html

Should be good now

Job PR-915/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-915/2/index.html


one-vs-all sampler - how to get binary targets?

Hi, great work on the library!
I am attempting to implement a task sampler that samples 1-vs-all tasks. That is every task is a binary classification problem where the class 0 contains shots of one random label, and the class 1 contains shots of all other classes except the label that represents class 0.
I inherited from MetaDataset and did the following (my question is below the code):
`
def __ getitem __(self, index):
if not isinstance(index, int):
    raise ValueError('The index of a `OneVsAllMetaDataset` must be an integer')

# create 2 datasets for the task: first one corresponds to label=index, second one contains all other labels
idx_set = [i for i in range(len(self.dataset))]
del idx_set[index]

# Use deepcopy on `Categorical` target transforms, to avoid any side
# effect across tasks.
dataset_one = ConcatTask([self.dataset[index]],
                          1,
                          target_transform=wrap_transform(Categorical(),
                                                             self._copy_categorical_one,
                                                             transform_type=Categorical))
dataset_vs_all = ConcatTask([self.dataset[i] for i in idx_set],
                            1,
                            target_transform=wrap_transform(Categorical(),
                                                            self._copy_categorical_vs_all,
                                                            transform_type=Categorical))

task = ConcatTask([dataset_one, dataset_vs_all],
                  self.num_classes_per_task)

if self.dataset_transform is not None:
    task = self.dataset_transform(task)

return task

`
After applying the ClassSplitter and the BatchMetaDataLoader, I get correct tasks, but I am not happy with the labels. They look like this for a single task with 5 shots:
tensor([[  0,   0,   0,   0,   0, 211, 727, 613, 198, 435]])
They are the outputs of the Categorical transform. But I want this instead:
tensor([[  0,   0,   0,   0,   0,  1,  1,  1,  1,  1]])
since I want to represent a binary task. Do you have any hint how to fix this?
I would be happy to do a pull request with the code once it is fixed. 1-vs-all samplers are commonly used these days.
Cheers!

You probably want to create your own target_transform, instead of the default Categorical target transform. You can take inspiration from Categorical.
If you manage to implement the one-vs-all sampler, I'd be very happy to have a PR!

thanks for the hint. that makes sense. I'll give it a go!


pythonPackages.pywinrm: old rev -> 0.1.1

Motivation for this change
This was previously tied to an older commit rev and not an actual release version; and that old commit was causing connectivity issues due to improper SSL support. That is fixed in the 0.1.1 release.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Note that I did test with nox-review wip, but get the following error:
error: libgssapi_krb5.so: cannot open shared object file: No such file or directory
builder for ‘/nix/store/brsyi1qw9b1nrwsmfd4l7dridhnjr191-python3.5-pywinrm-0.1.1.drv’ failed with exit code 1

...but the Kerberos support is optional, and I wasn't sure how to have it completely ignored. Outside of nox-review, everything works as expected connecting to Windows hosts without Kerberos. Any suggestions on how that optional dep should be handled better?

@elasticdog the failure only occurs with Python 3.5 and during checkPhase and is a common issue (https://github.com/NixOS/nixpkgs/issues/14849).
Setuptools tries to run tests, and is a bit too eager with it with Python 3.5 and starts loading stuff it shouldn't. What needs to be done is disabling testing (and adding a note that no tests are in the archive). I will merge this anyway since the update is good.


Is there a way not to use jQuery for this? it is not working will on device.

I need some help. Thanks!

Did you find solution for this?


Simplified SortReferences()

Fixes #3259.
Changes proposed in this pull request:

Builds a simpler dependency graph for topological sorting

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR! Just for the record, it should be used either this approach -or- the one proposed in #3305. They are mutually exclusive solutions for the out of memory exception.


[FLINK-4242] [table] Improve validation exception messages

Improve validation exception messages in table api.

Will update later to include the issue of flink-4241 .

@twalthr @fhueske Can you take a look at this?

Thanks @gallenvara. I will merge this...


Number of VMs (servers) must be supported for all controllers

[Version]
17.0 2017/05/17
[How to reproduce]
For controllers other than openstack, this user story has to work too.
[Expected result]
Controllers can retrieve any information from the target IaaS service as long as this information is provided by the respective IaaS API. So if there is only one AWS server in a subscription, then 1 has to be returned.
[Observed result]
Subscriptions other than OpenStack only show "0" VMs in the respective tables.
[Details]
see user story

Currently OpenStack/K5 adapter support orchestration with multiple VMs. Azure is not available yet.
Other adapters are for AWS EC2 and VMWare. These should return "1" as fix number.

@GoebelL Requirements says:

If the number of VMs is not available, i.e. if it is not relevant, it is left empty.
We provide 0 for that instead of null. Should we rework it?

For IaaS services the number of VMs has to be a digit.
For non-IaaS services the field must be empty, because it is not relevant.

Non-IaaS subscriptions do not have a number of VMs.
It must be evident that here this number is not relevant.

@badziakp
Is this reflected? 0a30000 doesn't seem to address this.

@GoebelL
As I understood Non-IaaS subscriptions are those which are not connected to any controller. Am I right?
If yes, then method  0a30000 will be not called for them and in the result no value will be stored. Can you write me a test case when the solution will fail?

Ok, I got it. You are right, the commit solves it.

Checked on Windows Server 2016, jdk1.8u121, build US9442 EXPORT USAGE UT-22 2017/05/30 in SAML mode for AWS, Vmware and Openstack. It works as expected.

Retested on Windows Server 2016, jdk1.8u121, build BES_MASTER_UNIT-1766 2017/06/01 in SAML mode for AWS and Openstack. It works as expected.


WIP: Handling broken VR

Works in progress, trying to reproduce the issue of broken vr after using the wrong volume replication class on a pvc restored from snapshot.

[x] Add the missing pieces to test rbd snapshot in drenv (on top of the lima branch)

Posting for validation with e2e job.

Merged into lima branch


[Class modifiers] package:meta implementation

New class modifiers
This issue tracks the package:meta implementation of the new class modifiers feature.

[x] #50977

Specs

Sealed types
Base-interface-final
Type modifiers

@kallentu, @munificent: besides @reopen, is there anything to do in annotation-land? (See: package:meta.)

Yeah.  It looks like things have moved...
Here's a good place to start: https://github.com/dart-lang/language/blob/master/accepted/future-releases/class-modifiers/feature-specification.md

Closing as @reopen has landed.  (Support in the linter is tracked in https://github.com/dart-lang/linter/issues/3920)


Respect COLUMNS environment variable

Determining the real terminal width is hard to do portably, but it's pretty simple to see if the COLUMNS env var is defined and use it instead of the hard coded 80 if it is.
I could make a PR if this is considered to be a good idea.

Sounds like a useful tweak - yes please :-)

:+1:

As COLUMNS isn't always an environment variable (for example on mksh, you can access it as $COLUMNS, but it isn't stored in the environment); it would be best to fall back on more native approaches.
order of precedence: COLUMNS, native, 80
for example if a native solution isn't detected.
For linux (tested):
#include <sys/ioctl.h>
#include <unistd.h>

// ...

winsize w;
ioctl(STDOUT_FILENO, TIOCGWINSZ, &w);
CLARA_CONFIG_CONSOLE_WIDTH = w.ws.col;

For windows (untested)
#include <windows.h>

// ...

CONSOLE_SCREEN_BUFFER_INFO csbi;
GetConsoleScreenBufferInfo(GetStdHandle(STD_OUTPUT_HANDLE), &csbi);
CLARA_CONFIG_CONSOLE_WIDTH = csbi.srWindow.Right - csbi.srWindow.Left + 1;


[PROBLEM] 2. Add Two Numbers

Difficulty
Medium
Problem Description

You are given two non-empty linked lists representing two non-negative integers. The digits are stored in reverse order, and each of their nodes contains a single digit. Add the two numbers and return the sum as a linked list.
You may assume the two numbers do not contain any leading zero, except the number 0 itself.
Example 1:

Input: l1 = [2,4,3], l2 = [5,6,4]
Output: [7,0,8]
Explanation: 342 + 465 = 807.

Example 2:
Input: l1 = [0], l2 = [0]
Output: [0]

Example 3:
Input: l1 = [9,9,9,9,9,9,9], l2 = [9,9,9,9]
Output: [8,9,9,9,0,0,0,1]

Constraints:

The number of nodes in each linked list is in the range [1, 100].
0 <= Node.val <= 9
It is guaranteed that the list represents a number that does not have leading zeros.

Link
https://leetcode.com/problems/add-two-numbers/

Hi, I want to work on this.

Let me solve this interesting PROBLEM.

Okay sir


Support Version for China Region

Describe the feature you'd like
machine downtime monitor is useful.
but it can't work in aws china region.
can you guys create an version for china aws region?
Thanks

Hi @ZenoRewn -
Thank you for reaching out. To help us research, can you please let us know the issues you're having that's preventing you from launching the solution? Is there an error you are seeing in the CloudFormation event logs?


add 20-some DOIs for ERM00000064

See https://nanocommons.github.io/specifications/jrc/ and then Scholia:

Or maybe just add this that widget to the ERM DB page?

Or use the approached used by Wikidata, object stated as?


off canvas nav not quite working

I'm sure it's something that I've done, but I can't suss out why the off-canvas navigation isn't working on my site: https://co97.justrjlewis.com.  I didn't notice any errors...a few warnings, but no errors.
Could you take a look?

@jpescador any thoughts?

Issue resolved with #48


Disposable & unique links suggestion

I've made two additional link types as described here: http://vorple-if.com/outgribe/2011/more-undum-link-types/
Would you be interested in having those link types in the official branch? I'd rather have them in the core system than as an external plugin, but I have no problem providing them as such. I thought I'd ask before integrating them to the core system so I don't have to do the extra work if you think they'd work better as a plugin.

For anyone reading this now:

Wayback Machine link
Summary:

disposable links: once a disposably linked situation is visited, all future links are removed. vs once where the current link disappears, but new links can be added later. can also be disposed of programmatically to close off links without their ever having been visited.
unique links: handles the case where you want the user to see one link to a place, but they might encounter that one link in several branches. once one unique link is reached, the others stop being links.
choice popups: when a choice popup link is clicked, it displays a menu of links.

Note that Vorple 2.5 is the last Vorple to support Undum. Vorple 3 (the current version) is all-in on Inform.


Migrate to latest M4

This is to get support for x-ms-original-file and configuration option to omit a defined list of header names from parameters (needed to support header responses in LROs).
Part of the M4 changes includes single-value enums no longer being treated as constants, so the code generator  has to be updated to take this into account.

Dependent on https://github.com/Azure/autorest/issues/4293


Revert "Delegate cloud preparation on AWS to cloud-prepare"

This reverts commit ff3c9d118dab233106c37d37bdf6ee5dae120383.
cloud-prepare-based deployment is currently broken because of missing
permissions for machineset handling.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

/lgtm
/approve

/cc @tpantelis


WLAN Problem & No Controll

Hello,
I always have the problem that the connection with the WLAN loses and does not reconnect directly.
Where can I enter the wifi data, which he should always use only the one?
/Edit
Also, I have the problem that my strips can no longer control.
At "#define LED_PIN D5" some mode is running and at D4 there is no reaction

Okay, I was able to fix the problem with the controller "#define ENABLE_E131" disabled.

Please reopen if you still facing issues.


Setting instance_market_options conditionally

Description
In the current version of module "~> 6.5.1" it is not possible to use spot instances conditionally (or I do not know how to do this ;))
Versions

Module version [Required]:

Terraform version:
Terraform v1.2.7

Provider version(s):
provider registry.terraform.io/hashicorp/aws v4.34.0

Reproduction Code [Required]
variable "spot_price" {
  type = number
  default = 0
}

module "prometheus_asg" {
  source  = "terraform-aws-modules/autoscaling/aws"
  version = "~> 6.5.1"

  name = "some-name"

instance_market_options = var.spot_price > 0 ? {
    market_type = "spot"
    spot_options = {
      max_price = var.spot_price
    }
  } : null

}

Above example cause error:
│   on .terraform/modules/.... line 140, in resource "aws_launch_template" "this":
│  140:     for_each = length(var.instance_market_options) > 0 ? [var.instance_market_options] : []
│     ├────────────────
│     │ var.instance_market_options is null
│
│ Invalid value for "value" parameter: argument must not be null.

Another try with:
instance_market_options = var.spot_price > 0 ? {
    market_type = "spot"
    spot_options = {
      max_price = var.spot_price
    }
  } : {}

Throws error
The true and false result expressions must have consistent types. The 'true' value includes object attribute "market_type", which is absent in the 'false' value.

Expected behavior
Possible to make condition in instance_market_options.

the easiest option is - don't wrap modules in modules (and don't use workspaces for environmental isolation)

Yeah, this is option, but I have many common options in each environment, in some cases, the only difference is spot/non-spot and name, but a bunch of options are the same. So i thinks it is not a good solution.

this is not related to the module but related to how you are trying to mange terraform


rustup downloads toolchain components twice

Problem
When I install a toolchain it seems to download everything twice. This is my output:
$ rustup install nightly
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2019-10-15, rust version 1.40.0-nightly (e413dc36a 2019-10-14)
info: downloading component 'cargo'
info: downloading component 'rust-std'
175.3 MiB / 175.3 MiB (100 %)  11.9 MiB/s in 13s ETA:  0s
info: downloading component 'rustc'
 66.2 MiB /  66.2 MiB (100 %)  12.1 MiB/s in  6s ETA:  0s
info: installing component 'cargo'
info: installing component 'rust-std'
175.3 MiB / 175.3 MiB (100 %)  13.4 MiB/s in 11s ETA:  0s
info: installing component 'rustc'
 66.2 MiB /  66.2 MiB (100 %)   7.9 MiB/s in  9s ETA:  0s

The same happens for the stable and beta channels. Or is the second line of:
175.3 MiB / 175.3 MiB (100 %)  13.4 MiB/s in 11s ETA:  0s

The unpacking of it? The visual feedback looks very much like a download, and the speed is very similar to my download speeds.
Output of rustup --version:
rustup 1.20.0 (a7f257941 2019-10-14)

Output of rustup show:
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/user/.rustup

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu (default)
nightly-2018-12-06-x86_64-unknown-linux-gnu
nightly-2018-12-24-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu
1.17.0-x86_64-unknown-linux-gnu
1.21.0-x86_64-unknown-linux-gnu

active toolchain
----------------

stable-x86_64-unknown-linux-gnu (default)
rustc 1.38.0 (625451e37 2019-09-23)

While the progress bars are similar, the lines prior to them do clearly indicate download vs. install and I assure you it's not downloading twice.


Add table alicloud_alidns_domains

References
The table alicloud_alidns_domains should mimic the aliyun alidns DescribeDomains query.

Go SDK is available on https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/services/alidns/describe_domains.go
Terraform provide this datasource https://registry.terraform.io/providers/aliyun/alicloud/latest/docs/data-sources/alidns_domains, Go code is available here https://github.com/aliyun/terraform-provider-alicloud/blob/master/alicloud/data_source_alicloud_alidns_domains.go

A sample output from cli:
aliyun alidns DescribeDomains
{
	"Domains": {
		"Domain": [
			{
				"AliDomain": false,
				"CreateTime": "2020-02-08T19:07Z",
				"CreateTimestamp":<PHONE_NUMBER>000,
				"DnsServers": {
					"DnsServer": [
						"ns7.alidns.com",
						"ns8.alidns.com"
					]
				},
				"DomainId": "REDACTED",
				"DomainLoggingSwitchStatus": "CLOSE",
				"DomainName": "REDACTED",
				"PunyCode": "REDACTED",
				"RecordCount": 0,
				"ResourceGroupId": "rg-REDACTED",
				"Starmark": false,
				"Tags": {
					"Tag": []
				},
				"VersionCode": "mianfei",
				"VersionName": "Alibaba Cloud DNS"
			},
			{
				"AliDomain": false,
				"CreateTime": "2019-01-29T10:29Z",
				"CreateTimestamp":<PHONE_NUMBER>000,
				"DnsServers": {
					"DnsServer": [
						"ns7.alidns.com",
						"ns8.alidns.com"
					]
				},
				"DomainId": "REDACTED",
				"DomainLoggingSwitchStatus": "CLOSE",
				"DomainName": "REDACTED",
				"PunyCode": "REDACTED",
				"RecordCount": 0,
				"ResourceGroupId": "rg-REDACTED",
				"Starmark": false,
				"Tags": {
					"Tag": []
				},
				"VersionCode": "mianfei",
				"VersionName": "Alibaba Cloud DNS"
			}
		]
	},
	"PageNumber": 1,
	"PageSize": 20,
	"RequestId": "REDACTED",
	"TotalCount": 2
}

Still needing this table, it's no stale

Hello @vmdude,
Apologies for the delay in adding this enhancement. I have raised this PR to include the new table request. However, I was unable to test it due to the unavailability of the required resources in our test environment.
It would be greatly appreciated if you could test it on the PR branch (issue-450) and share your observations with us.
Thank you!

I've pulled and installed issue-450 branch plugin and got these errors:
> select * from REDACTED.alicloud_alidns_domain

Error: REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {}
	REDACTED: failed to populate column 'akas': rpc error: code = Internal desc = transform domainToAka failed with panic interface conversion: interface {} is alidns.DomainInDescribeDomains, not map[string]interface {} (SQLSTATE HV000)

+-------------+-----------+----------+------------+--------+-------------+------------------+--------------+-------------+------------+-------------------+-------------------+------------------+--------------+--------------+-----------+------------------+----------+------->
| domain_name | domain_id | group_id | group_name | remark | create_time | create_timestamp | record_count | instance_id | ali_domain | resource_group_id | instance_end_time | instance_expired | version_name | version_code | puny_code | registrant_email | starmark | min_tt>
+-------------+-----------+----------+------------+--------+-------------+------------------+--------------+-------------+------------+-------------------+-------------------+------------------+--------------+--------------+-----------+------------------+----------+------->
+-------------+-----------+----------+------------+--------+-------------+------------------+--------------+-------------+------------+-------------------+-------------------+------------------+--------------+--------------+-----------+------------------+----------+------->
>

Ah, my mistake, @vmdude. I’ve pushed a fix to the same branch. Could you please pull the latest changes to your local setup and try building the plugin again? Let me know how it goes!

Awesome 💪  it works fine, all properties are populated! Thanks a lot

Thank you so much, @vmdude, for taking the time to test out the PR. Your effort is greatly appreciated!


Windows/v3

Fixes and updates to support running on Windows. Tested with mingw32 and mingw64 on python2 and python3.
Also adds test for Suricata bug 2769.

Replaced by #27


Remove superfluous extern crate

(first time using gh cli for a pull request... apparently it lets the shell expand backticks)


Get rid of PIL and replace it with Pillow

Made some progress in https://github.com/NixOS/nixpkgs/pull/11086


Broken link

Hi
The link here: "Deploy: WinRM - IIS Web App Deployment" - Deploy the package. is broken.
It points to: https://github.com/Microsoft/vsts-rm-extensions/blob/master/Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppDeploy/README_IISAppDeploy.md
Regards
Dennis

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7353b2d-ab02-2e8f-983f-c846c9508f6d
Version Independent ID: 8fed9e9b-0bd6-acb7-e64f-577148a0091a
Content: Deploy to IIS using WinRM - Azure Pipelines
Content Source: docs/pipelines/apps/cd/deploy-webdeploy-iis-winrm.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

Raised a PR#894


Feat: Addition of feedback form in nav bar

Describe the feature
Addition of feedback form will help us improvise the website
Add ScreenShots

I will add rate us button beside login button
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would like to work on this issue. Please assign this task to me under @GSSoC24

@minakshikr7 I am working on this issue

@Satyam1923 assign me this issue under GSSOC'24

@Satyam1923 Please assign me this issue under @GSS0C24


Method Illuminate\Support\Collection::add does not exist.

I don't know exactly what I need to do.
I want to add multiple values to attr.
Trying this.
$model->tags->add(['Alexandria', 'Cairo'])
I added this code to my Model
    /**      * Create a new Eloquent Collection instance.      *      * @param  array  $models      * @return Rinvex\Attributes\Support\ValueCollection      */     public function newCollection(array $models = [])     {         return new ValueCollection($models);     }
Get this

Not sure right now. I would need to have the same state in the database to try to reproduce the issue.

It was not in the database, some method was returned not the ValueCollection() but the Collection().

@mepoohsta thank you for reaching out, and sorry for the delay!
Well, buddy there's no add method in Laravel's Collections! AndValueCollection actually inherits from it, so you just need to use push like normal, make sure to READ THE WHOLE DOCUMENTATION as it's really mandatory to understand how this package works. And you can visit official Laravel Collections page too 🙂
P.S. If you're using this package for managing tags, it's not efficient and highly not recommended. You can use Rinvex Tags instead.


KVM Service - Preparation of Certificates for external hosts

Start-Date:
Effort Estimate: 1.25

[ ] Design - 0.5
[ ] Coding - 0.5
[ ] Unit Test - 0.25

This issue belongs to kvmservice and was handled there.


Help is shown as raw markdown

When executing hub pr, the help is shown, but it contains some markdown syntax that looks confusing on the terminal, especially _list_ and _checkout_
Related code
https://github.com/github/hub/blob/b15d8de5e468f32653ff3bdfc2224cd3e429080a/commands/pr.go#L25-L29

Thanks; good catch! We should improve this so that the appropriate, properly formatted man page is shown.

Hey everyone, I'd love to give this a shot as my first PR for Hub!
Funny enough, I've just begun maintaining a project and needed a way to automate checking out contributors PRs instead of adding their remote, fetching, and checking out their branch 😅
From what I understand, the _ denotes italicized text, which we do not want showing at all - am I understanding this correctly?

@SeanPrashad Thanks for offering to help out!
I would say that the main problem here is that running hub pr displays help text that is in a raw format (i.e. includes special formatting characters such as _), while hub help pr displays a nice man page. Perhaps running hub pr should be equivalent to running hub help pr.

Great, that makes sense @mislav - I'll open a PR in a little while 😄


Tweak GitHub scope based on context

Looks like public_repo is not needed and it's the controversial permission (for good reason).

Fix: https://github.com/opencollective/opencollective/issues/1034


update full ui

Describe your chaotic idea
We can change the UI by adding interactive features. For example, if we click on an image of a lion, it will play the sound of a lion roaring. Similarly, in the animal section, there will be many animals, and clicking on any image will trigger its sound. I can add several such features, so please give me a chance, and I will deliver a much-improved version.
Add Screenshots or Sketches

Confirm

[X] I understand that my idea will add to the chaos and I'm okay with it
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this feature
[X] I'm GSSOC'24 Extd registered Contributor
[X] I'm Hacktoberfest registered Contributor

Will discuss on this later
Keeping on pending for now till the main page PR #2 is merged

Thanks for assigning it to me. I will work on it.  level?

Wait, dont work on it now, I have told that its on pending, I will notify when you can start
Assigned you so that no one else comments to get assigned

You can check the current UI and propose changes to me so we can proceed further!

Are you still interested in doing this task??

yes

Its already done now, you responded after 4 days
I am closing this issue now as its already done now!


Add Total row/col to Purchase Order table

Enhance "Purchase Order Items" table by adding:

[ ] "Total" column with quantity * unit price
[ ] "Grand Total" row with sum of all rows quantity and prices.

@sintech / @SchrodingersGat I think this can be closed

@sintech check out latest version and let us know if this addresses your requests

This is exactly what i needed, thanks @matmair , @SchrodingersGat


feat: add rover health checker

Yea I do think we can / should share this code more - I just want to see how the collector feeds into this first and then circle back around to make the health check more generic


Make ContentMap immutable and constructed from another map

Fixes #17

@rultor merge

@rultor merge

@suseika OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@suseika Done! FYI, the full log is here (took me 1min)


cdogs-sdl 0.6.1 (new formula)

C-Dogs SDL is an open source, classic overhead run-and-gun game.
No test block is there yet; command line arguments like help somehow didn't work on the shell.

We can test that the thing launches without crashing, the way pioneers does.
  test do
    server = fork do
      system "#{bin}/pioneers-server-console"
    end
    sleep 5
    Process.kill("TERM", server)
  end

I've done so in a new PR; we'll see how it works: #654

Merged in #654. Thank you for your contribution to Homebrew!


Stack overflow from package:analyzer LeastUpperBoundHelper.getLeastUpperBound

Consider the code example from https://github.com/dart-lang/sdk/issues/53254 and paste it into DartPad:
void foo<T extends List<S>, S extends List<T>>(T x, S y) {
  var a = (x == y) ? x : y;
}

Notice the confusing error message:

I expected the error message to be descriptive and not confusing.

Note that this is a known issue, see https://github.com/dart-lang/sdk/issues/53254#issuecomment-1683624544 by @eernst for details.
I have suggested one possible solution here: https://github.com/dart-lang/sdk/issues/53254#issuecomment-1683845625. It is not meant to resolve the issue, but to detect it and to fail early before the stack overflow occurs.

I'll bump this issue over to the sdk repo.

@devoncarew This issue wasn't necessarily meant to resolve the underlying issue that causes the analysis to fail, but to point out that DartPad is outputting what appears to be raw unprocessed output from the analyzer.
That is, I expected to see an error message like the following:


Make lobby ready button clear what state you are in

About the PR
I've heard (and also felt) this button has been confusing. The text already existed, this just makes it so the button text properly explains if you are ready or not ready. The timer is also aligned to the left so that when the button changes size it doesn't look as jank.
Screenshots

readybuttonbetter.webm
no issue when it should say join either
Changelog

:cl: ashtronaut
tweak: Tweaked the lobby ready button to be explicitly clear what state you are in, hopefully this reduces confusion!

closes https://github.com/space-wizards/space-station-14/issues/10829

imo, the button should be of a fixed width. It stretching like that looks weird.

imo, the button should be of a fixed width. It stretching like that looks weird.

I can make it a fixed min width of when it says "Not Ready" but of course for any other languages / translations it may continue to change sizes. I didn't think it was a huge deal since it also serves as extra attention drawing, but I can still make the change

imo, the button should be of a fixed width. It stretching like that looks weird.

okay i did this, updated video


Whitelist instead of blacklist

instead of blacklisting unsupported, now I'm whitelisting only the supported ones.
Way simpler :+1:

thanks again, @aureliojargas :dart:


Fix arrow key when overlay

Fixes #46

This change is

Reviewed 2 of 2 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Remove redundant / for rss link

It rendered with //index.xml which broke my S3 based deployment.
Kudos for the awesome theme!

Thank you!

@MayADevBe thank you for an awesome theme!
You're welcome to use my blog as another showcase!

@erikzaadi I'm glad you like it!
I will do that.
If you like to add comments to your blog posts, maybe check out my blog post about it, I have not integrated that feature into this theme.


Define cluster

The documentation states "across multiple, isolated hardware nodes, in a cluster.".
What is the precise definition of a cluster in this context?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a57ffc39-d1a4-77f7-d78a-415db2deeae7
Version Independent ID: 7ec4a1b0-6545-97e5-449c-f5e72df0242e
Content: Tutorial - High availability for Windows VMs in Azure - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/tutorial-availability-sets.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

Cluster implies hardware cluster here.
For example, in this section, it is mentioned

Use Get-AzVMSize to list all the available sizes on the hardware cluster for the availability set.

Thanks for your question. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.

Thanks, I'm aware it means hardware cluster, but what is the definition of that? How many of these "isolated nodes" are there in a cluster?


Provide informations about certificates in secrets

What would you like to be added:
If there is a certificate inside a secret or config map. show additional values like SAN attributes or expired/notBefore dates.
Why is this needed:
Quickly detect if a certificates is expired.
Environment you are Lens application on:

Kubernetes distribution: [EKS, AKS, GKE, Rancher, ...]: Any, GKE in this case
Desktop OS: MacOS

Current workaround:
Copy certificate in a file and run openssl x509 -in tls.crt -text -noout.

We feel this is beyond the scope of what Lens should provide, may be good implemented via an extension

@jim-docker It‘s possible to add a new label like „implement-as-extension“?
Motivated Extension developers could use this to get a list about enhancment like that.

I figured out, extensions for lens are quite simple.
If any one is interrested into this feature, take a look here https://github.com/jkroepke/lens-extension-certificate-info


NET 4.5.1 support: AspNetCore 2.0 do not target it any longer

AspNetCore 2.0 do NOT target .NET 4.5.1 any longer.
It targets netstandard1.3 and 1.5.
Should AppInsights AspNetCore SDK 2.2 drop support for .NET 451 too?

no longer relevant: the SDK still depends on Hosting 1.0.2 that supports .NET 4.5.1+


Tests creating unwanted artifacts

I've started noticing that running the unit tests with ./gradlew clean build can create a force-close file unexpectedly that doesn't get cleaned up at the end of the tests.
Ideally I'd like to figure out a clean way to properly mock the ConditionService tests and any others that create files so they no longer need to create real files, but I'd settle for figuring out which test is failing to clean up after itself and fixing that.

This seems to be due to pitest mutating the tests in ways that leave files on the disk. It doesn't happen when I only run JUnit.


NETOBSERV-765 Restore metrics

The alternative could be to cover /metrics with AuthChecker, which would require a bearer token config in ServiceMonitor.

How hard is it to implement ?

There should be changes in go.mod and go.sum files right?

No change there, prometheus is already imported, there's just a couple more files being used hence added to vendors

@OlivierCazade I implemented your suggestion; see also https://github.com/netobserv/network-observability-operator/pull/310

/ok-to-test

@jotak - I tested this with plugin image listed here and used NOO image from PR: https://github.com/netobserv/network-observability-operator/pull/310. I enabled user workload monitoring, but I am not able to  see plugin metrics being scraped, in below screenshot you can find metrics from just FLP container:

@memodi I retried this morning and it worked for me. Same steps as you: deploy my operator PR image, set this console plugin image, enable user workload monitoring... wait a minute or so to get metrics populated, and they are:

Also if you trigger some queries to Loki via the console plugin, you should get dedicated metrics such as netobserv_http_api_calls_duration_bucket

If you retry, could you check the Targets page to see if the console plugin is listed and w/o errors?
E.g:

/approve


docs: aa-core withGasEstimator

docs: add aa-core withGasEstimator

We will also need to mention gasEstimator in the same page as that's the related readOnly field and we decided to mention them along with these here.
For example, see feeDataGetter for withFeeDataGetter: https://github.com/SahilAujla/aa-sdk-private/blob/withFeeDataGetter/site/packages/aa-core/provider/withFeeDataGetter.md#feedatagetter

can you add the example build UO to the usage section? then can ship

@avasisht23 just updated the example and read only fields


CVode_options key error

Simulations of FMUs shipped with non-CVode solver fail due to KeyError:
File "modestpy/fmi/model.py", line 136, in simulate
    opts["CVode_options"]["atol"] = 1e-6
KeyError: 'CVode_options'

Setting 'atol' should be solver-independent and, preferably, user-accessible, not fixed.

Solved in https://github.com/sdu-cfei/modest-py/commit/03ed12113f4c367c4bf896198c490a7cd36c1916


In the use of declarative configuration , custom Dao contains a field named "plugins", which can cause startup exceptions

Summary
In the use of declarative configuration , custom Dao contains a field named "plugins", which can cause startup exceptions
Steps To Reproduce

Create plugin and define Daos, which are defined as follows:
local typedefs = require "kong.db.schema.typedefs"
return { demo = {
name = "demo",
primary_key = { "id" },
admin_api_name = "demo",
admin_api_nested_name = "demo",
fields = {
{ id = typedefs.uuid },
{ version = { type = "string", required = true } },
{ plugins = { type = "string", required = true } }
}
} }

start kong
docker run -ti
--name kong
-e KONG_DATABASE=off
-e KONG_PLUGINS=demo
-e KONG_DECLARATIVE_CONFIG=/etc/kong/kong.yml
-v /opt/test/kong.yml:/etc/kong/kong.yml
-v /opt/test/demo:/usr/local/share/lua/5.1/kong/plugins/demo
kong/kong-gateway:<IP_ADDRESS>-alpine

exception as follow:
2021/05/17 14:05:55 [error] 1#0: init_by_lua error: /usr/local/share/lua/5.1/kong/db/schema/init.lua:2197: attempt to index local 'self' (a nil value)
stack traceback:
/usr/local/share/lua/5.1/kong/db/schema/init.lua:2197: in function 'new_subschema'
/usr/local/share/lua/5.1/kong/db/schema/plugin_loader.lua:221: in function 'load_subschema'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:255: in function 'load_plugin_subschemas'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:267: in function 'load_plugin_subschemas'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:783: in function 'load'
/usr/local/share/lua/5.1/kong/db/declarative/init.lua:51: in function 'new_config'
/usr/local/share/lua/5.1/kong/init.lua:351: in function 'parse_declarative_config'
/usr/local/share/lua/5.1/kong/init.lua:571: in function 'init'
init_by_lua:3: in main chunk
nginx: [error] init_by_lua error: /usr/local/share/lua/5.1/kong/db/schema/init.lua:2197: attempt to index local 'self' (a nil value)
stack traceback:
/usr/local/share/lua/5.1/kong/db/schema/init.lua:2197: in function 'new_subschema'
/usr/local/share/lua/5.1/kong/db/schema/plugin_loader.lua:221: in function 'load_subschema'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:255: in function 'load_plugin_subschemas'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:267: in function 'load_plugin_subschemas'
...are/lua/5.1/kong/db/schema/others/declarative_config.lua:783: in function 'load'
/usr/local/share/lua/5.1/kong/db/declarative/init.lua:51: in function 'new_config'
/usr/local/share/lua/5.1/kong/init.lua:351: in function 'parse_declarative_config'
/usr/local/share/lua/5.1/kong/init.lua:571: in function 'init'
init_by_lua:3: in main chunk

Additional Details & Logs

Kong version : 1.5.1 and <IP_ADDRESS>-alpine
Operating system : centos7

At present, my solution is to add verification logic to distinguish between plugins schema and custom "plugins" field. The details are as follows:
https://github.com/Kong/kong/blob/master/kong/db/schema/others/declarative_config.lua
The original code:

Code I changed:
...
if fname == "plugins" and fdata.elements and fdata.elements.subschema_key then
for plugin in pairs(plugin_set) do
...
Do not confirm whether it is the most appropriate solution, please advise?

Hi @freefengeli , the schema you posted looks strange and might be missing somthing. I can't start
Kong with the schema you posted. Is that based on the legacy DAO format?
Also you mentioned using <IP_ADDRESS>-alpine, are you a Kong Enterprise user?
If you would want to have a field named plugins in config, it seems to work:
schema.lua
local typedefs = require "kong.db.schema.typedefs"

return {
  name = "demo",
  fields = {
    { consumer = typedefs.no_consumer },
    { protocols = typedefs.protocols_http },
    { config = {
        type = "record",
        fields = {
          { id = typedefs.uuid },
          { version = { type = "string", required = true } },
          { plugins = { type = "string", required = true } }
        },
      }
    }
  },
}

kong.yml
_format_version: "1.1"
plugins:
 - name: prometheus
services:
- protocol: http
  host: <IP_ADDRESS>
  port: 8080
  routes:
  - protocols:
    - http
    paths:
    - /v1
    plugins:
    - name: demo
      config:
        version: "1.1"
        plugins: "asdsad"

Hi @fffonion , It has nothing to do with the schema. lua file . The daos. lua file of the plugin is as follows，
local typedefs = require "kong.db.schema.typedefs"
return { demo = {
name = "demo",
primary_key = { "id" },
admin_api_name = "demo",
admin_api_nested_name = "demo",
fields = {
{ id = typedefs.uuid },
{ version = { type = "string", required = true } },
{ plugins = { type = "string", required = true } }
}
} }

@freefengeli I see, I can reproduce the bug. Will open a PR.


Add function to go from variable sampling to fixed sampling using interpolation

I suggest we use this package for the resampling:
https://github.com/kbarbary/Dierckx.jl
Example usage:
julia> x=[0,1,1.2,2,10]
5-element Array{Float64,1}:
  0.0
  1.0
  1.2
  2.0
 10.0

julia> y=x.^2
5-element Array{Float64,1}:
   0.0
   1.0
   1.44
   4.0
 100.0

julia> sitp=Spline1D(x,y)
Spline1D(knots=[0.0, 1.2, 10.0], k=3, extrapolation="nearest", residual=0.0)

julia> sitp([0,1,2,3,4,5,6,7,8,9])
10-element Array{Float64,1}:
 -6.505143321387812e-19
  1.0
  4.0
  9.000000000000002
 16.000000000000004
 25.0
 36.0
 49.0
 63.99999999999999
 80.99999999999999

This is linked to #77
We need to redesign resample and fixed_resample (base.jl) to have a more flexible syntax and simpler parameters. The docstring does not help yet understand how to apply the function to specific regions.

Resample to match an array of time points:
resample(d, t=Array(0:0.01:10))
resample to match another dataset:
resample(d, t=d0.t)
resample to match a constant timestep (keeping start and end the same, cutting last point is needed)
resample(d, dt=0.01)
upsample/downsample
resample(d, upsample=2)
resample(d, downsample=3)
Do we still want to enable up/down sampling on select ranges of time values? It may increase numerical errors down the line.

The package Dierckx.jl required a build step:
Pkg.build("Dierckx")
Not sure if this is a problem, e.g. that user need some compiler installed, etc. It seems that the module is using some fortran code.

The doc of Dierckx is unclear about the need to have a compiler installed, but it seems that the package can download precompiled libraries for most platforms/OS, so we should be fine.
https://github.com/kbarbary/Dierckx.jl/blob/master/deps/build.jl
Could we automate the command Pkg.build("Dierckx") as part of the RHEOS install? It would be good to see how the automated tests work in due course...

Tests are working fine with the module Dierckx being built as required.
Closed with 58951316f6823479a1dd60e53ff9b6ef3e2ce3dd

Actually, there is a doc section to rewrite too. Keeping this open for now.

aed4f046d0f5487cc5f3256ad6327c9585fa4c68


Feature: Color network drives

What feature or improvement do you think would benefit Files?
It would be helpful if the network drives box had a different color than the local drives.
If it could be customized, even better. Thus, local drives would have one color, network drives another, and external drives such as GDrive or OneDrive another color.
Requirements

This proposal allows to quickly differentiate local and network drives.

Files Version
<IP_ADDRESS>
Windows Version
Windows 10 Pro 22H2
Comments
No response

What do you mean by box? Network drive have different icons to local ones and a separate widget is being discussed at #5135

What do you mean by box/color? Network drive have different icons to local ones and a separate widget is being discussed at #5135

Something like this:

This proposal allows to quickly differentiate local and network drives.

Can you elaborate on this use case and how it fits into your workflow?

Can you elaborate on this use case and how it fits into your workflow?

We work with several local disks and network drives, I personally have 10 and sometimes more.
When you have a high pace of work it would be nice to be able to quickly identify the drives by color and not having to read the name.
Sometimes the drives are different folders on the same IP and at a quick glance the first thing you see is several folders with the same IP, which forces you to stop to identify each one.
On the other hand, colors are easier to remember, which helps in medium or large companies to better identify things for standard users or users with limited computer skills.
For example, users will more easily remember that the Documents unit is blue. That is easier than not making them remember the Y:
At least in our case it is a matter of productivity and getting to automate movements by color association.

@EugeneRM0 would applying custom icons to the different drives help?

What about having Network Drives in a separate group on the home screen?

@yaira2  In my particular case, it works for me. I can put the same icon but in different colours so that the mental association is quicker.
I'm sure there are many people who would welcome customising the icon.
Thanks

@EugeneRM0 I believe you can change the icon from the desktop.ini file, can you check if this works?


Conflicting Namespaces

SIMDCompressionAndIntersection shares many classes and header file names with FastPFor. When using them together, there are issues since this library doesn't enclose anything in a namespace.
I'm proposing renaming all #ifndef NAME_H_ to #ifndef SIMDCompressionAndIntersection_NAME_H_ and enclosing all relevant pieces in a namespace, maybe called SIMDCompressionLib?
If these sound like reasonable names and changes, I will go ahead and do so.

Yes, this does sound reasonable. A PR would be appreciated.

Submitted: #3

@aconz2
Your PR is excellent. I have added your name to the README and CHANGELOG.
I am closing this issue, reopen if you disagree.

Cheers. Thanks for making this code available in the first place.