Updated nomenclature (Publish->ForcedPublish); reflects drake master

As of Drake PR (#18106), usage of Publish should be ForcedPublish As of now, drake-ros builds fail.

This change is

@jwnimmer-tri for review, thanks!


Enable multiple SASL Mechanism

Is their way where we can enable multiple access control on AWS MSK Cluster e.g. one for IAM Access Control & another is SASL/SCRAM authentication till the time we have support of IAM Access Control for other languages than Java?

That is not currently possible.

AWS MSK now supports multiple authentication mechanisms on a single cluster.
MSK also supports updating security settings for an existing cluster.

@vivekkwatra I know it has been sometime since you asked, but AWS MSK now supports multiple authentication mechanisms on a single cluster.
MSK also supports updating security settings for an existing cluster.


Heart rate monitor turns off with LCD

This "bug" occurs when "Simple Heart Rate widget" is installed.
It turns off the heart rate monitor whenever the LCD turns off, however this is not practical when "Heart Rate Recorder" is running.
I know this is not strictly a bug since the widget should turn off the sensor, however with the recorder this leads to bad readings. One option would be to give the "Heart Rate Recorder" application a option to show the heart rate similar to "Simple Heart Rate widget" so it can be fully replaced.

Thanks! Actually yes, this is totally possible to change since in 2v09 (I think) I added the ability for apps to request the HRM to stay on just for them. I'll get some changes in to fix this in the next few minutes.


bugfix for OSX drives with description ':', which leads to invalid yaml

fixes #118

Hey there!
Thanks a lot for the pull request. What happens if a drive has a description that "contains" a colon? I think we should surround the value of description in double quotes, which will prevent YAML from complaining but will allow you to get the actual description, either if its just a colon, or a string containing a colon.
What do you think?

Yeah, double-quoting the description sounds like a better option to me. AFAICT the linux.sh script already does that, so I'm surprised that darwin.sh doesn't?

AFAICT the linux.sh script already does that, so I'm surprised that darwin.sh doesn't?

Yeah, they get out of sync very easily. Maybe we can do some linting or something to make sure they all get the same fixes (for example, another script that checks that every property printed by the script is surrounded in double quotes)?
Closing in favor of https://github.com/resin-io-modules/drivelist/pull/127


Use Distroless as base image for all Keptn services

Currently, we use alpine:3.11 as base image for most of our services.
This distro however is "only" a community project and contains dependencies we do not need.
Therefore, this issue proposes to switch to distroless images. More precisely, to gcr.io/distroless/base.
With distroless we can decrease the size of the images.
Definition of Done:

gcr.io/distroless/base is used as base image in all services
Services can still be monitored with Dynatrace

One thing to note: golang monitoring with Dynatrace has certain requirements, which is why we use golang-alpine for building and alpine for a runtime (libc, musl, ...).
If this still works with Dynatrace, then let's reduce our image size :+1:

I've looked at the distroless containers, and I noticed the following:

We won't be able to have tools like cat, kubectl, helm, git, mongodump, ... in those containers. We either need to manually install them (which is a pain, and alpine solves this nicely) or we need to use Go-Libraries instead of the binaries which means rewriting some code.
"With distroless we can decrease the size of the images." - I doubt that. I've trimmed down our docker images using alpine and removing as much of the non-essential dependencies as possible.
For instance, take the mongodb-datastore: https://hub.docker.com/layers/keptn/mongodb-datastore/0.7.1/images/sha256-90e348deaff91c25ff2e055ab52fdaf15e260ee5745dd50b2130f7f11c0606d6?context=repo
Most of the disk space used for this image comes from COPY commands in the Dockerfile (e.g., the compiled binary, swagger.yaml files, config files), and not from the base image.
Another example is the cnofiguration-service, where we add git as a CLI tool, which obviously has some dependencies that require some disk space:
https://hub.docker.com/layers/keptn/configuration-service/0.7.1/images/sha256-3a84454b836baf813d7eba0e143f4b58ea784dbf220e26d99924a39163e55596?context=repo
Debugging and troubleshooting is much easier and nicer when you can just exec into a container and start a shell. Plus I'm not sure if distroless containers will support debugging using Skaffold and GoLand.

In summary, I don't think moving to Distroless for all our containers is the right move. Maybe it works for some of our containers, but for others we would need to do significant rewrites before we can change the base-image to distroless.
Anyway, this is just my opinion, and if you or someone else has another opinion, please share it :)

We are seeing issues with our alpine based Docker Images in certain scenarios (nslookup fails when searchdomain is misconfigured): https://github.com/keptn/keptn/issues/2951
I am seeing an immediate benefit in switching away from alpine based images to something else (distroless is an option, but let's look at other options too).
The main criteria based on my experience are:

Deep-Monitoring with Dynatrace needs to work
Debugging using GoLand + Skaffold needs to work
Size of the resulting Image needs to be as small as possible (comparable to current sizes)
Dependency Handling (e.g., installing 3rd-party packages) needs to be simple, without us having to maintain versions of those dependencies

We are seeing issues with our alpine based Docker Images in certain scenarios (nslookup fails when searchdomain is misconfigured): https://github.com/keptn/keptn/issues/2951
I am seeing an immediate benefit in switching away from alpine based images to something else (distroless is an option, but let's look at other options too).
The main criteria based on my experience are:

Deep-Monitoring with Dynatrace needs to work
Debugging using GoLand + Skaffold needs to work
Size of the resulting Image needs to be as small as possible (comparable to current sizes)
Dependency Handling (e.g., installing 3rd-party packages) needs to be simple, without us having to maintain versions of those dependencies


tikv_kv: introduce raft extension

What is changed and how it works?
Issue Number: Ref #13827
What's Changed:
So anything related to raft will call raft extension instead of router.
This makes it easier to introduce new raftstore implementations.

Check List
Tests

Unit test
Integration test

Release note
None

/merge


[Q] How to correctly configure DekTec output for DVB-T2

Starting from a working configuration in DekTec's StreamXpress for the play-out of a transport stream in DVB-T2, I failed to copy the set-up to TSDuck .
Problems:

at the time of writing the commands,  I seem to be missing TSDuck equivalents for DekTec's "Frame structure : NUM_DATA_SYMBOLS" and "PLP0 : NUM_BLOCKS"
output result on DTU-315 : no error messages in the cmd console, but the stream is played out at a BW of 10 MHz iso the configured 8 MHz (and consequently cannot be received on a TV)
output result on DTU-215 : cmd console gives an error from the DekTec driver : "*Error: dektec: output device start send error: DTAPI_E_INVALID_SAMPRATE (DTAPI status 4306)"
TSDUCK_DVBT2.txt

command input 👍
tsp --add-input-stuffing 1/3  -I file C:\data\scratch\streams\DVB-T2_Bonn_514.000MHz_CH26_PLP0.ts -i  -P limit --bitrate 21983722  -O dektec  --device 0 --frequency 514000000 --level -350 --modulation DVB-T2 --bandwidth 8 --bandwidth-extension --cell-id 0  -–papr none --pilot-pattern 2 --plp0-code-rate 3/5 --plp0-fec-type 64k --plp0-group-id 1 --plp0-high-efficiency --plp0-id 0 --plp0-il-length 3 --plp0-il-type 0 --plp0-issy none --plp0-modulation 64-QAM --plp0-rotation --plp0-type 1 --t2-fpsf 2 --t2-guard-interval 19/128 --t2-l1-modulation 64-QAM --t2-network-id 12421 --t2-system-id 32769
What could I be doing wrong ? Are there any examples for DVB-T2 play-out on DekTec ?

Closed ?

Reopening issue since it seems legitimate.

at the time of writing the commands, I seem to be missing TSDuck equivalents for DekTec's "Frame structure : NUM_DATA_SYMBOLS" and "PLP0 : NUM_BLOCKS"

These two fields are automatically computed from other parameters using the Dektec function DtDvbT2Pars::OptimisePlpNumBlocks.
The results are documented as follow in Dektec's API documentation:

OptPlpNumBlocks: optimum value for the number of FEC blocks per IL frame for PLP0 to maximise the DVB-T2 channel’s bitrate.
OptNumDataSyms : optimum value for the number of data OFDM symbols per T2 frame to maximise the DVB-T2 channel’s bitrate.

output result on DTU-315 : no error messages in the cmd console, but the stream is played out at a BW of 10 MHz iso the configured 8 MHz

Do you mean that you specify --bandwidth 8 but, when you analyse the RF signal, you get 10 MHz bandwidth ?
Could you try with tsp --debug ... It should display all DVB-T2 parameters which are passed to the Dektec API. The bandwidth is marked as m_Bandwidth =. For 8 MHz bandwidth, the integer value should be 4. If this is the case, either your measurement is incorrect or there is a bug in the Dektec API.

output result on DTU-215 : cmd console gives an error from the DekTec driver : "*Error: dektec: output device start send error: DTAPI_E_INVALID_SAMPRATE (DTAPI status 4306)"

This is a Dektec error. I have no idea what it means. It is not documented as a possible error code for DtOutpChannel::SetTxControl.  I have no DTU-215 to try. Please use tsp --debug and post the complete output.
Also post the output of tsp --version=all to make sure we can specify the right DTAPI version if the problem should be reported to Dektec.

Indeed, your understanding concerning BW is correct : using StreamXpress I get an 8 MHz channel that can be received on the TV.
Using the TSDuck commands as described, yields either an error (DTU-215) or a 10 MHz channel that cannot be received (DTU-315) (seen on a spectrum analyser with identical settings for the 8MHz and 10 MHz observation)
"tsp -- debug " shows that m_Bandwidth = 4 (as expected).
Somebody suggested me to add the bitrate in the output processor, e.g. -o dektec --bitrate=21983722.
And YES, this works !!!  It is however not very practical, because the value is extemely critical : deviations of merely
feedback_TSDuck_debug.txt
more than +/- 100 ppm  already (!) cause reception to fail on the TV, and deviations of a couple of % generate again the same dektec error.
NOTE : the value was obtained from StreamXpress.

From your debug trace file, I see that you are using TSDuck version 3.17, which is quite old. The latest version is 3.27.
There is maybe an inconsistency between the Dektec library (linked with TSDuck, quite old: <IP_ADDRESS> while the latest one is <IP_ADDRESS>) and the Dektec device drivers (separately installed, maybe newer: <IP_ADDRESS> but still not up to date since the latest one is 4.28.2).
I would recommend to install the latest versions of both. This would ensure that the Dektec library and drivers are aligned. Please retry and let us know the result. Also retry tsp --version=all to check the TSDuck, Dektec libraru and Dektec drivers versions.
TSDuck (with embedded Dektec library): https://tsduck.io/download/tsduck/
Dektec device drivers: https://www.dektec.com/downloads/SDK/

updating SW and drivers according to above links : same result.
feedback_TSDuck_updSW.txt

OK, I think I found an issue with the bitrate with DVB-T2. In the Dektec output plugin with modulators, the default bitrate is computed from the modulation parameters (normally, each specific set of modulation parameters is arithmetically associated with a bitrate). Each modulation type uses a distinct algorithm and the computation was not done with DVB-T2. This is fixed now. The appropriate bitrate should be computed without being forced to specify it.
You may try to rebuild from source or wait until tomorrow for the next nightly build on Windows, available here. You need version 3.28-2446 or higher. Please try tomorrow with the new version.
Now, the 10-MHz vs 8-MHz bandwidth is another issue. How do you conclude that the signal has a 10-MHz bandwidth instead of 8-MHz?

Using the nightly build, shows that DVB-T2 is now playing correctly on both DTU-215 and DTU-315.  This means the 10 MHz /8MHz problem is now also solved.  I think it wa
feedback_TSDuck_nightly.txt
s due to something with Dektec that causes it to switch over to 10 MHz mode when some of the configuration parameters are missing or incorrect.  With only the hardware of DTU-315 supporting this mode, DTU-215 gives the DTAPI_E_INVALID_SAMPRATE error instead.

OK, so shall we conclude that the issue is solved and can be closed ?

Sure, for me the issue is fully solved.  The solution from TSDuck is far more elegant (and flexible) than the one of sending the bitrate with the output processor.
Thank you !


#171: Bump Triple-T gradle-play-publisher

Description (required)
For alpha builds we use the gradle-play-publisher to automatically package and publish the app. In older versions there was a compatibility bug with Gradle 6.3 (https://github.com/Triple-T/gradle-play-publisher/issues/797). Using the updated version (2.8.1) should fix the problem.
There is version 3.0.0, however I've stuck to 2.8.1 as the breaking change of 3.0.0 is that it no longer supports PKCS keys (.p12 files) which we use.
Fixes the publishing step of the build, related to #171, #1056, #3469

Given the failing master build, I'm going to try merging this now. Although it doesn't currently block PRs going green, the issue does stop new alpha builds being generated and therefore hold back testing.


Links not shown after render view.

It not shown after render view, but it show when I trigger action on model.

Hi! do you found any solution for this issue_


Enhancement: better handling of texture color files rule inside maya

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?
To auto set the right colorspace for texture, i use maya color management policy file (xml)
I need to lock the policy so that it does'nt get overwritten by artist (very easy to do by mistake),
The issue is that OpenPype will not be able to then change settings such as
<Parameter name="OCIOConfigFile" value="/prod/softprod/libs/ocio/aces_1.2/config.ocio"

Which can cause issue with the pipeline
Ideally i would like to be able to just have the <Parameter name="userRules" value=`...' part
I tried to erase the part that i didn't want in the xml but maya complain that it is not valid xml
This is low priority request we can get over the issue by generating new .xml file with the correct seettings mirroring the openpye one.
How would you imagine the implementation of the feature?
Find a way to have maya handle the textures file rules without having to lock the colormanagement policy
Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:
No response
Additional context:

xml exemple

This could be resolve by using an OCIO v2 configuration which include files rules . But for that we need new oiio package
See here : https://github.com/ynput/OpenPype/issues/5345


[1.16] Default theme updates

From discussion with @cinnamon-msft et. al.

[ ] Dark theme by default (was system)
[ ] tab.background: terminalBackground
[ ] Change the tab row colors back to what they were pre-Controlsv2

This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted.
The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad.

[ ] tabRow.unfocusedBackground set to something sensible in the default themes as well.

The 🌶 rejected ides:

Default to mica on

Rejected cause this would disable vintage opacity
Rejected cause our Mica story isn't fleshed out yet
Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall.

... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body.

see all the above.

Immersive experience is the  best. I hope Windows Terminal can change color scheme when theme changed.
For example, like this feature in VS Code.

Thanks a lot.

🏗 Work in progress 🏗

originscreenshottab.backgroundtabRow.backgroundtabRow.unfocusedBackground

Edge Dark

#3b3b3b
#202020
#202020

Terminal (Controlsv1)

#
#
#

Terminal (Controlsv2)

#
#
#


Adic7ed provider failed with x-files series

Subliminal failed to find subtitle for the new x-files episodes. Here the error i got
INFO:subliminal.api:Listing subtitles with provider 'addic7ed' and languages {<Language [fr]>}
INFO:subliminal.api:Initializing provider addic7ed
INFO:subliminal.providers.addic7ed:Logging in
DEBUG:subliminal.providers.addic7ed:Logged in
ERROR:subliminal.api:Unexpected error in provider 'addic7ed', discarding it
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/subliminal/api.py", line 116, in list_subtitles
    provider_subtitles = self[name].list_subtitles(video, provider_languages)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 259, in list_subtitles
    return [s for s in self.query(video.series, video.season, video.year)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 214, in query
    show_id = self.get_show_id(series, year, country)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 187, in get_show_id
    show_ids = self._get_show_ids()
  File "/usr/lib/python3.5/site-packages/dogpile/cache/region.py", line 1053, in decorate
    should_cache_fn)
  File "/usr/lib/python3.5/site-packages/dogpile/cache/region.py", line 657, in get_or_create
    async_creator) as value:
  File "/usr/lib/python3.5/site-packages/dogpile/core/dogpile.py", line 158, in __enter__
    return self._enter()
  File "/usr/lib/python3.5/site-packages/dogpile/core/dogpile.py", line 91, in _enter
    value = value_fn()
  File "/usr/lib/python3.5/site-packages/dogpile/cache/region.py", line 610, in get_value
    value = self.backend.get(key)
  File "/usr/lib/python3.5/site-packages/dogpile/cache/backends/file.py", line 220, in get
    with self._dbm_file(False) as dbm:
  File "/usr/lib/python3.5/contextlib.py", line 59, in __enter__
    return next(self.gen)
  File "/usr/lib/python3.5/site-packages/dogpile/cache/backends/file.py", line 215, in _dbm_file
    "w" if write else "r")
  File "/usr/lib/python3.5/dbm/__init__.py", line 88, in open
    raise error[0]("db type could not be determined")
dbm.error: db type could not be determined

It seems like a cache issue. Please remove the cache file in ~/.config/subliminal/ and try again.

ok got a new error message now
INFO:subliminal.api:Initializing provider addic7ed
INFO:subliminal.providers.addic7ed:Logging in
DEBUG:subliminal.providers.addic7ed:Logged in
DEBUG:subliminal.providers.addic7ed:Getting show id
INFO:subliminal.providers.addic7ed:Getting the page of show id 85, season 10
ERROR:subliminal.api:Unexpected error in provider 'addic7ed', discarding it
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/subliminal/api.py", line 116, in list_subtitles
    provider_subtitles = self[name].list_subtitles(video, provider_languages)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 259, in list_subtitles
    return [s for s in self.query(video.series, video.season, video.year)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 229, in query
    series = match.group('series')
AttributeError: 'NoneType' object has no attribute 'group'

my mistake my folder permission wasnt properly set.
now i got a new error
INFO:subliminal.api:Listing subtitles with provider 'addic7ed' and languages {<Language [fr]>}
INFO:subliminal.api:Initializing provider addic7ed
INFO:subliminal.providers.addic7ed:Logging in
DEBUG:subliminal.providers.addic7ed:Logged in
DEBUG:subliminal.providers.addic7ed:Getting show id
INFO:subliminal.providers.addic7ed:Getting the page of show id 85, season 10
ERROR:subliminal.api:Unexpected error in provider 'addic7ed', discarding it
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/subliminal/api.py", line 116, in list_subtitles
    provider_subtitles = self[name].list_subtitles(video, provider_languages)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 259, in list_subtitles
    return [s for s in self.query(video.series, video.season, video.year)
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 224, in query
    raise TooManyRequests()
subliminal.exceptions.TooManyRequests

Well, you made too many requests to addic7ed and you're now limited. Wait a few hours and try again.

ok i wait and too many request error is gone, but the previous one "AttributeError: 'NoneType' object has no attribute 'group'" is still here.

Please check my pull request. It fixes the problem with X-Files and eventually other series that have a dash in the name.

kakai248 I compiled your hotfix branch, but addic7ed provider failed to login with it.
INFO:subliminal.api:Listing subtitles with provider 'addic7ed' and languages {<Language [fr]>}
INFO:subliminal.api:Initializing provider addic7ed
INFO:subliminal.providers.addic7ed:Logging in
ERROR:subliminal.api:Unexpected error in provider 'addic7ed', discarding it
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/subliminal/api.py", line 116, in list_subtitles
    provider_subtitles = self[name].list_subtitles(video, provider_languages)
  File "/usr/lib/python3.5/site-packages/subliminal/api.py", line 61, in __getitem__
    provider.initialize()
  File "/usr/lib/python3.5/site-packages/subliminal/providers/addic7ed.py", line 100, in initialize
    raise AuthenticationError(self.username)
subliminal.exceptions.AuthenticationError: mac1202

That is weird. The only thing I changed was adding a dash to this line:
series_year_re = re.compile('^(?P<series>[ \w\'.:-]+)(?: \((?P<year>\d{4})\))?$')

It doesn't even affect the authentication phase.

I just retry downloading subtitle and this time it's work strange :)
So I confirm your PR is fixing this issue.

Fixed with d125ffa


Deployment request: Ontology Mainnet

Chain Name
Ontology Mainnet
Chain ID
58
RPC URL
https://dappnode1.ont.io:10339
Block Explorer URL
https://explorer.ont.io/
Deployment Funds
Yes

Done, thanks!


[Bug] Cannot show multiple xAxis of type time

Version
5.3.3
Link to Minimal Reproduction
Create two xAxis of type 'time'
Steps to Reproduce
Add the following to xAxis options.
xAxis: [
{
id: "time1",
type: 'time',
axisLabel: {
margin: 0
}
},
{
id: "time2",
type: 'time',
data: [1657171900000,165717200000,<PHONE_NUMBER>000,1657176800000,1657177800000,1657178800000],
axisLabel: {
interval: 0,
margin: 10
}
},
}
Current Behavior
Second xAxis doesn't show. It shows if I set it to 'category'. But with 'category' the labels are not aligned to their corresponding timestamp, so I have to create two xAxis of type time.
Expected Behavior
Should show multiple xAxis. Reason is that I would like to show icons below the corresponding timestamps. So I want to create two xAxis of type time, and replace timestamps with icons on the second xAxis
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

Solution:
There can only be one 'time' xAxis per series, so just add xAxisIndex to each series.


Set/Protect cmdlets for Nutanix and HyperV cmdles, support for enabling/disabling CloudOn

Description
Added the following cmdlets:

Protect-RubrikHyperVVM
Set-RubrikHyperVVM
Protect-RubrikNutanixVM
Set-RubrikNutanixVM

Also added CloudOn support into Set-RubrikVM
Related Issue
#185
Motivation and Context
Improves code coverage for the module and 4.1 features.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTION document.
[ ] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@pmilano1 said to :shipit:


#7695 no need to manually release chunk during upload in HttpUploadServer

Motivation:
After https://github.com/netty/netty/pull/7527 fix there is no need to manually release chunks (HttpData) during file upload as they will be released on HttpPostRequestDecoder.destroy().
Modification:
HttpUploadServer example doesn't release chunks manually (doesn't call data.release()).
Result:
Fixes https://github.com/netty/netty/issues/7695 and https://github.com/netty/netty/issues/7689

Could anyone confirm (@johnou @doom369 @fishjam) which of the fixes: this one, or https://github.com/netty/netty/issues/7814 is the valid one for this bug? After upgrading netty version we experienced the same problem (our file uploading looks like was based on this example) and I'm not sure whether dropping this data.release() call is save/official/approved by netty fix.

@pnowojski my approach works for me well for a long period on the production system.

Thanks for the information. We will probably go the same way.


New SPAN created for handling on /error when request does not have span header

Uncaught exceptions are catched by Tomcat and forwarded to /error for handling by Spring's default BasicErrorController.
It appears the span logged from within the BasicErrorHandler (and anywhere in the handling chain after the TraceFilter) may not refer to the same span as from within the handler that threw the uncaught exception. It actually depends on whether the original request had span headers on it or not:

if span headers are present and the request is parent of an ongoing trace, span stays the same in /error
if no span header is present, everything appears as if two spans were created: one first the original attempt at invoking the handler, a second for the forward to /error.

This behaviour is observed with SpringCloud Edgware.SR2.
Things are different however with Finchley.M6: the same span is reported in both cases.
I have attached two sample applications to illustrate the case. They are built from Spring Initializr with Web and Sleuth features only. Both are the same except one is built on Edgware.SR2 and the other on Finchley.SR6.
The application contains a simple RestController that logs a small message and throws a RuntimeException whenever it receives a request (mapped on /**).
The context also contains a custom DefaultErrorAttributes with the same behaviour as the original except it logs a message when the errorAttributes() method is invoked. This method is invoked after Tomcat has forwarded the request to the ErrorDispatcher after reception of an uncaught exception.
The application starts on port 8080 by default.
Scenario 1
Invoke the service - an uncaught RuntimeException is thrown
curl -v http://localhost:8080

Application logs:
 INFO [-,e7f50e4c43a76f7c,e7f50e4c43a76f7c,false] 41701 --- [nio-8080-exec-2] com.example.demo.RestService             : Request received - about to throw an exception
ERROR [-,e7f50e4c43a76f7c,e7f50e4c43a76f7c,false] 41701 --- [nio-8080-exec-2] o.s.c.sleuth.instrument.web.TraceFilter  : Uncaught exception thrown

org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.RuntimeException: boom
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:982) ~[spring-webmvc-4.3.14.RELEASE.jar:4.3.14.RELEASE]
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861) ~[spring-webmvc-4.3.14.RELEASE.jar:4.3.14.RELEASE]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:635) ~[tomcat-embed-core-8.5.27.jar:8.5.27]
....
ERROR [-,,,] 41701 --- [nio-8080-exec-2] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.RuntimeException: boom] with root cause

java.lang.RuntimeException: boom
	at com.example.demo.RestService.custom(RestService.java:30) ~[classes/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_151]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_151]
....
 INFO [-,045aa25bab393b07,045aa25bab393b07,false] 41701 --- [nio-8080-exec-2] com.example.demo.RestService             : getErrorAttributes() invoked for /error

The first two lines are caused by the request hitting the RestController handler. They both refer to the same Span (e7f50e4c43a76f7c).
The third line is logged by Tomcat because of the uncaught exception - it does not contain any Span (as expected, see #714).
The last line is caused by the handling on /error.
--> Logs generated by /error refer to a DIFFERENT span than when the request originally hit the rest controller.
Scenario 2
Invoke the service with Span headers:
curl -v -H "X-B3-TraceId: 97952cdf1b39993f" -H"X-B3-SpanId: 97952cdf1b39993f" http://localhost:8080

Application logs:
Note: exception logged by Tomcat is omitted for brevity.
 INFO [-,97952cdf1b39993f,97952cdf1b39993f,true] 41701 --- [nio-8080-exec-3] com.example.demo.RestService             : Request received - about to throw an exception
ERROR [-,97952cdf1b39993f,97952cdf1b39993f,true] 41701 --- [nio-8080-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Uncaught exception thrown

org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.RuntimeException: boom
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:982) ~[spring-webmvc-4.3.14.RELEASE.jar:4.3.14.RELEASE]
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861) ~[spring-webmvc-4.3.14.RELEASE.jar:4.3.14.RELEASE]
....
 INFO [-,97952cdf1b39993f,97952cdf1b39993f,true] 41701 --- [nio-8080-exec-3] com.example.demo.RestService             : getErrorAttributes() invoked for /error

--> All logs now refer to the SAME span, including those generated by /error.

Is it for 2.0.0.M6 - if that's the case then it's a known issue that I haven't filed. Thanks for doing that for me ;)

sample-projects.zip

Well... according to me, everything is fine in 2.0.0... but 1.3.x behaviour is odd (and annoying).

Seriously? Interesting, I'll double check that then. Thanks for the sample!

I suspect a new span is actually created for /error in both cases but they reused the ids embedded in the request - so they look the same. However, we may have two server received events and it will look as if the server received two consecutive requests: one for the original URI, the second for /error.

I think that the problem might be present in both cases but Brave & Zipkin combination is handled in a more intelligent way.

To give you some background: we have a custom handler behind /error that includes the span ids in the error response. For us it is important they are the same as from within the rest handler.

I wonder if the difference in behaviour comes from the following changes in TraceWebAspect:

2.0.x: L147-149
1.3.x: L150-159

1.3.x marks the span for close after the HandlerExceptionResolver is invoked, 2.0.x does not (afaik). Why should it be closed anyway? The handler may not have handled the exception and it will bubble up to Tomcat...
What's the purpose of instrumenting the HandlerExceptionResolver by the way - besides maybe capturing details about the exception... ?

In 2.0.x the problem was already fixed in TraceFilter. I've forgotten to backport it to 1.3.x.
The problem wasn't with the aspect, it was in TraceFilter. I haven't checked if there's an error controller present when an exception was thrown. Cause if there is one then it means that it will be called and it will execute the logic of closing the span. In 2.0.x there's a problem with multiple tags, but I guess that's another problem to solve

Nice - I'm gonna test latest SNAPSHOT asap. I'll keep you informed.
Your comment let me think the TraceFilter expects Tomcat to forward the request to /error in case of uncaught exception. Correct?
As already mentioned, this is not always the case. For instance, Tomcat silently ignore uncaught  org.apache.catalina.connector.ClientAbortException (subtype of IOException) exceptions: they are not logged and not forwarded to the ErrorDispatcher. Is this causing issues to the TraceFilter?

Your comment let me think the TraceFilter expects Tomcat to forward the request to /error in case of uncaught exception. Correct?

Correct

As already mentioned, this is not always the case. For instance, Tomcat silently ignore uncaught org.apache.catalina.connector.ClientAbortException (subtype of IOException) exceptions: they are not logged and not forwarded to the ErrorDispatcher. Is this causing issues to the TraceFilter?

I haven't tested that at all so we can actually give it a go and check it out.


revisit content and align rerank

Issue

Closes #https://github.com/langchain4j/langchain4j/issues/2314
Change

General checklist

[x] There are no breaking changes
[x] I have added unit and/or integration tests for my change
[ ] The tests cover both positive and negative cases
[ ] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
[ ] I have manually run all the unit and integration tests in the core and main modules, and they are all green

[ ] I have added/updated the documentation
[ ] I have added an example in the examples repo (only for "big" features)
[ ] I have added/updated Spring Boot starter(s) (if applicable)

Checklist for adding new maven module

[ ] I have added my new module in the root pom.xml and langchain4j-bom/pom.xml

Checklist for adding new embedding store integration

[ ] I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
[ ] I have added a {NameOfIntegration}EmbeddingStoreRemovalIT that extends from EmbeddingStoreWithRemovalIT

Checklist for changing existing embedding store integration

[ ] I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

add tests and coverage


Params of type list not accepted in VertexAI

When trying to use parameters of type list vertexAI pipeline fails with the error.
INPUT in params.yml:
signature_columns:
  - email
  - created_at
  - creation_country
  - has_company_name
  - partner_id
  - account_type
  - followers_count
  - posts_count
  - is_private
  - is_verified
  - risk_level

Generated step that fails:

Error:

Same as https://github.com/getindata/kedro-kubeflow/issues/60

We use this setup: https://github.com/getindata/kedro-kubeflow/pull/90 in Kubeflow and it works nice with both lists and dicts.


Calibration Dashboard: empty pipette mount

Overview
These should be the states of the calibration dashboard when there is an empty pipette mount.
Implementation details
When a mount is empty there are no highlighted calibrations and no ability to open/close the card
Design
https://www.figma.com/file/2xjSLHXquNsKvC1mV9NMjr/6.2-Liquid-Setup%2C-Changing-Deck-State%2C-Wizards?node-id=2304%3A194016
Acceptance criteria

[ ] Empty mount has no open/close functionality
[ ] Progress tracker skips empty mount card
[ ] Empty mount card is not clickable
[ ] Empty mount card still appears in normal ordering on the dashboard

This was released as 6.3.


Fix script to Get User Assigned Identity

There were improper parens and ID property access around the Get-AzUserAssignedIdentity call.

@kipphoward : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@kipphoward - thanks for making that fix!
#sign-off


Can't run spateo on google colab

After downloading mousebrain_bin60.h5ad, installing spateo:
pip install spateo-release

and running:
fname_bin60 = "mousebrain_bin60.h5ad"
adata_bin60 = st.sample_data.mousebrain(fname_bin60)

I'm getting:
KeyError                                  Traceback (most recent call last)
[/usr/local/lib/python3.8/dist-packages/anndata/_io/utils.py](https://localhost:8080/#) in func_wrapper(elem, *args, **kwargs)
    155         try:
--> 156             return func(elem, *args, **kwargs)
    157         except Exception as e:

7 frames
KeyError: 'dict'

During handling of the above exception, another exception occurred:

AnnDataReadError                          Traceback (most recent call last)
[/usr/local/lib/python3.8/dist-packages/anndata/_io/utils.py](https://localhost:8080/#) in func_wrapper(elem, *args, **kwargs)
    160             else:
    161                 parent = _get_parent(elem)
--> 162                 raise AnnDataReadError(
    163                     f"Above error raised while reading key {elem.name!r} of "
    164                     f"type {type(elem)} from {parent}."

AnnDataReadError: Above error raised while reading key '/layers' of type <class 'h5py._hl.group.Group'> from /.

Any idea why?
cat /etc/os-release
Ubuntu
VERSION="18.04.6 LTS (Bionic Beaver)"

Hi @vladimirkovacevic thanks for using spateo. I have released a new patch spateo v1.0.2,  could you please consider updating spateo and let us know?
pip install -U spateo-release.
Also what anndata version are you using? make sure to have anndata >= 0.8.0

@Xiaojieqiu Hi, I have update spateo-release to V1.0.2, also updata anndata to 0.8.0. but this problem remains. Any ideas for this?

I have the same problem.Do you solve it now?

I can solve this by updating the anndata to 0.8.0 in colab. The tricky part is you have to make sure you are using the correct version of anndata. The easiest way might be to install anndata 0.8.0 first before installing spateo. You can run import anndata and print(anndata.__version__) before you run the analysis to check the current version.


wrong handling of oneway=-1

I assume a wrong handling based on the following observation:
http://localhost:5000/viaroute&start=52.3870278,9.8994556&dest=52.4040975,9.8988906&output=gpx
This is a short, but clearly wrong routing across the "Autobahnkreuz Hannover-Ost".
The ways
http://www.openstreetmap.org/browse/way/108099638
http://www.openstreetmap.org/browse/way/17565220
http://www.openstreetmap.org/browse/way/17565236
http://www.openstreetmap.org/browse/way/4250406
are tagged "oneway=-1" (i assume this a temporary tagging due to a construction site in that area).
in ./DataStructures/ExtractorCallBacks.h around line 164:
            } else if( oneway == "-1") {
                w.direction  = _Way::opposite;
                std::reverse( w.path.begin(), w.path.end() );
            }

reversing and marking opposite seems to be too much?

oneway = -1 is the preferred way to indicate oneway in the opposite direction, relative to the direction of the way.
http://wiki.openstreetmap.org/wiki/Key:oneway
so i think osrm does the right thing?

i can't get osrm to work right now, so can't test this myself, but it does sounds like a bug. perhaps you're right that marking _Way::opposite AND reversing the way is a "double negation".

i have a 12MB osm file for testing purpose. Please let me know if someone is interested in.
With this file i was able to reproduce the problem. After setting "obeyOneways=no" the problem is not reproducable.

i'm experimenting with a test suite based on cucumber: https://github.com/emiltin/Project-OSRM/tree/cucumber
it would be good to expand the suite to cover this case. note that the test suite is based on a osm file covering copenhagen in denmark, but the area does include streets with oneway=-1,  for example http://www.openstreetmap.org/browse/way/27226010

The problem is, that i can't reproduce the bug with way 27226010. Everything seems to be working there. So, either the bug is more complicated or i really have overlooked a mapping bug - though i checked it several times now...
... The routing plugin of Josm is able to use the correct route
Another way to workaround the problem is to just reverese the ways listed above in the raw data material (and also change oneway=-1 to oneway=yes

perhaps check that there is not two overlapping way on top of each other?

i can reproduce the problem with the hanover motorway. like you it seems to work fine with the copenhagen way. so there must be some difference..

i changed
            } else if( oneway == "-1") {
                w.direction  = _Way::opposite;
                std::reverse( w.path.begin(), w.path.end() );
            }

to
            } else if( oneway == "-1") {
                w.direction = _Way::oneway;
                std::reverse( w.path.begin(), w.path.end() );
            }

This avoids a second reserve at line 206 later on in the same file:
        if ( w.direction == _Way::opposite ){
            std::reverse( w.path.begin(), w.path.end() );
        }

This code change resolves the hannover problem. Up to now i could not detect any new wrong behaviour in other situations, e.g. Kopenhagen way

i found that the copenhagen way has cycleway=opposite_lane, which overrides oneway if you're using bicycle routing (which i was). so after switching to car routing, i get the same incorrect behaviour as in the hanover example: i'm routed against the correct oneway flow. you fix seems to solve the problem, although it might be better to remove the lines:
        if ( w.direction == _Way::opposite ){
            std::reverse( w.path.begin(), w.path.end() );
        }

that way all the oneway stuff is on one place.

a fix: https://github.com/DennisOSRM/Project-OSRM/pull/76

it could be important (for other things to work correctly) to that the way is in fact marked with _Way::opposite, which is an argument for my variation of the fix.

Hannover-Ost has been under construction in the past and there have been tags to reflect temporary change of lanes. Are you sure that the data you are using is correct?

i didn't see anything wrong with the data.
note that http://www.openstreetmap.org/browse/way/27226010 was changed by somebody today

Are you sure that the data you are using is correct?

Yes, i am sure. osrm does not handle oneway=-1 correct. If i reverse the mentioned ways and change oneway=-1 to oneway=yes, it works.
way
A->B oneway=-1

should be the same as
B->A oneway=yes

we need automated tests

Indeed, reversing the path twice seems too much. I'll investigate a bit and push a fix to this issue later today.

And yes, an automated test suite would be awesome.

@emiltin: Aren't your cucumber test yet functioning?

it's close. but most test currently fail because osrm seem to return empty route description, see #89.
also the whole things needs to be cleaned up a bit.

What is "the whole thing"?

my cucumber tests


feat: allow user to provide a variable file

To make the templating easier the user can provide a file vith the list of key=value parameters he wants to be able to use in the slack notifications

This dosnt seem to work in the notification.


Allow localisation of content licence and copyright notices in Footer

This are the bare minimum changes needed for enable localisation of the Footer component's content licence and copyright notices. In this case, it is assumed that an Open Government Licence (OGL) and Crown copyright are still being used, and that the notices are only being translated into another language.
This differs slightly from the internationalisation spike work, as I've split the contentLicence and copyright parameters into html and text versions to facilitate extending them with more options, as described below.

Issues #1290 and #1291 originally asked that it be possible to remove the OGL and Crown graphics. This hasn't been done in this PR, as it isn't strictly needed for the current localisation work and (for the most part) public-facing GOV.UK services will have been made available under OGL and Crown copyright.
I've created a version of this work with more customisation options, including changing/removing the Crown copyright URL and removing the licence/copyright graphics, as a separate branch. You can compare those branches here. Whether we consider these changes necessary or not is up for discussion!

This PR makes sense to me (although needs tests and a Changelog entry to make it 'release ready' - aware it's still in draft). I'm happy to do just what's needed to enable internationalisation, although can see benefits of the other approach too. If we go with this PR, do you think it would then involve a breaking change to introduce the ability to completely override the logo etc too?

@vanitabarrett I don't think anything in this PR would block us expanding it to include the other options at a later date.

I've added a changelog entry but was a little unsure of how to focus it (as 'customisation', as 'localisation', as 'translation'), as it can now be changed, but still practically has to be OGL and Crown copyright.
Can you give an expert opinion, @claireashworth?

Looks good to me! Would be great to get the commits tidied up/squashed a bit before merging.


fix: updated js-gardener

:tada: This PR is included in version 2.1.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for generating multiple protos

Break file generation to separate method
Convert string flag to string slice flag (existing behaviour
should not be affected by this change)
Run file generation for every proto in a goroutine
Add timer for info (probably should be hidden behind a flag)

Closes #9

I've quickly tested it, and it appears to be working (in a backwards compatible way too). We'll fix the master tests separately.


Add Pipeline Resources for Image Transfer

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

@sajayantony @mnltejaswini

/azp run automation - sdk

/azp run automation - sdk

@jaysterp Please fix the modelvalidation error

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@NullMDR ModelValidation errors fixed.

/azp run

@jaysterp Please fix the error in python generation:
[AutoRest] ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions [AutoRest]     - file:///z/work/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:1684:4 ($.definitions.SourceTriggerDescriptor) [AutoRest]     - file:///z/work/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json:2541:4 ($.definitions.SourceTriggerDescriptor) [AutoRest]  [AutoRest] ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions [AutoRest]     - file:///z/work/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:2220:4 ($.definitions.TriggerProperties) [AutoRest]     - file:///z/work/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json:2132:4 ($.definitions.TriggerProperties)

/azp run automation - sdk

/azp run automation - sdk

Added some minor comments. Please take a look.

@majastrz the comments relate to general changes that involve the entire swagger. Can we open a separate PR after this one to tackle those all together?

@majastrz the comments relate to general changes that involve the entire swagger. Can we open a separate PR after this one to tackle those all together?

Yeah, I think that will be ok.

Another commit is coming, so removing signoff labels for now...

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@NullMDR can you please take a look?

@NullMDR we are ready to merge


feature request: Feature map

💻

[X] Would you like to work on this feature?

What problem are you trying to solve?
When running the adapter on Astro@3, the message shows at dev:
[astro] The adapter @astro-aws/adapter doesn't provide a feature map. From Astro 3.0, an adapter can provide a feature map. Not providing a feature map will cause an error in Astro 4.0.

Describe the solution you'd like
We need to add a feature map to the adapter so that Astro doesn't complain.
Describe alternatives you've considered
Add an empty feature map to silence the error
Documentation, Adoption, Migration Strategy
No response

The adapter does provide a feature map unless Astro changed how it works. Are you using the latest version of @astro-aws/adapter?

@lukeshay i'm still at 0.3, i'll update to 0.5. thanks for publishing new releases so fast 🙏


GUAC-1172: Implement file browsing UI

This change adds a new file browsing interface, accessible by clicking on any drive listed within the new "Devices" section of the Guacamole menu. From within this interface, files can be downloaded individually or uploaded into the current directory.
The file transfer manager has been moved out of the Guacamole menu and into a dialog that appears only while transfers are in progress.

Now using an actual template and the $templateRequest service available as of Angular 1.3.x. Also took this chance to remove the old manual usage of $templateCache and $http that was added to replicate $templateRequest while using Angular 1.2.x (a7366e8).


chore: remove user orgs from joinable orgs response

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.805%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5480

Relevant Lines:
11003

💛  - Coveralls

@Chief-Rishab can you rebase and resolve the conflict, the PR looks good. I'll merge.


:seedling: Bump IPAM to v1.7.3

What this PR does / why we need it: Bump IPAM from v1.7.2 to v1.7.3

/test metal3-centos-e2e-integration-test-release-1-7


Update README.md to include link to paper

Love the work, but I originally stumbled on the repo and had some trouble finding the original paper. Thought adding a direct link would help!

Good catch. Thanks!


New package: CryptoGroups v0.1.0

Registering package: CryptoGroups
Repository: https://github.com/PeaceFounder/CryptoGroups.jl
Created by: @akels
Version: v0.1.0
Commit: 0979cd9dfbf0e982b72b7e9875d6956692186e8a
Reviewed by: @akels
Reference: https://github.com/PeaceFounder/CryptoGroups.jl/commit/0979cd9dfbf0e982b72b7e9875d6956692186e8a#commitcomment-35777947

Please fix the compatibility bounds for the next release such that it will be automatically merged.

TagBot tag

TagBot tag

TagBot tag

It is not going to work until you delete the existing tag.

I did not understand what was wrong so I tried stuff - making new releases, removing tags and playing with Julia registrator. I managed to make a patch release - https://github.com/JuliaRegistries/General/pull/5219

TagBot tag

It is not going to work until you delete the existing tag.

I removed existing tags which made TagBot happy. However, it did not tag the release afterwards ;/
@christopher-dG how can I get TagBot again working for me?

TagBot tag

TagBot tag

If I would remove every tag and release and then create a new fresh one, would then TagBot work?

You are not supposed to tag yourself at all, that is TagBot's job.

Seems like it did its job.


Cannot format text to "heading two"

Issue Summary
When I select some text and try to convert it to "heading two" using the popup controls, nothing happens. I tried 3 different browser engines.
Worked perfectly before the latest update.
Uploading 20220214_201657.mp4…
.
Steps to Reproduce

Select text in the post editor
Press "heading two" in the popup
Nothing happens

Ghost Version
4.36.0
Node.js Version
v16.14.0
How did you install Ghost?
Using the official guide on an Ubuntu VPS
Database type
MySQL 8
Browser & OS version
Mac OS X 12.2.1 ; Brave 1.35.101 ; Safari 15.3 ; Firefox 98.0b4
Relevant log / error output
No console errors

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

This was fixed in https://github.com/TryGhost/Admin/commit/9c9b55c7274734bc40dc7b32059a59aaee028d85 but it looks like the release that was supposed to include this was created empty.
See the diff between the v4.36.0 and v4.36.1 here: https://github.com/TryGhost/Admin/compare/v4.36.0...v4.36.1
@kevinansfield Do you think you can resolve this? Thanks!

4.36.1 was a patch release for a specific issue. The fix for this issue will be included in the next full Ghost release that's currently scheduled for tomorrow.

Thank you for the quick turnaround and for keeping us updated 🙏


STRIDE_IN_1X1=True for torchvision models?

Thanks for this very intriguing work!
I found that you used torchvision pretrained models instead of MSRA pretrained ones while setting STRIDE_IN_1X1=True, which is somehow inconsistent with torchvision resnet. I reproduced a model using MSRA R-50 backbone w/ dropout=0.1, and it turned out that it is 0.7% AP lower than the reported one w/ dropout, probably indicating that differently pretrained backbones kinda matters. Maybe there can be some further improvement if this configuration inconsistency is fixed.

Hi~
All settings of STRIDE_IN_1X1 in our code is False, not True.
In genearal, torchvision pretrained models and MSRA pretrained ones won't make a difference. If you use MSRA pretrained models, you should set :
INPUT.FORMAT: "BGR"
MODEL.RESNETS. STRIDE_IN_1X1: True
MODEL.PIXEL_MEAN: [103.530, 116.280, 123.675]
MODEL.PIXEL_STD to [1, 1, 1]

Thanks for your reply, I just probably found the real inconsistency between my configuration and yours which causes the drop (gradient clip is not enabled in my case). Closing the issue.


Improve private server support (Closes #9)

I have added improved private server support!:

Leaving token blank in config setup lets the user put in their server url, port, username, and password
Gets a token from the api using that information

Thanks for taking a look at it! You are correct, leaving the api token blank will allow the user to enter the hostname, port, username, and password.
I didn't ask the user whether it is http or https, since private servers only really support http. (Well, the steam client will force http on a private server, so you're stuck with that). I kept https for connecting to the official server.
This: https://blog.screeps.com/2017/08/shards/ article says they were adding to the private server, however I haven't personally tried using them.
I'll go ahead and update the install docs!

Thanks for updating! I'll push a new version out later this week, and all clients will auto update after that!


[wrangler] set additional c3 args to respect -y flag

Fixes #3333 #3319
What this PR solves / how to test:
When wrangler init ... -y delegates to C3, it now sets enough args to skip all prompts in C3.
Test by running wrangler init -y or wrangler init --from-dash test -y and confirm the process exits without user input.
Author has included the following, where applicable:

[ ] Tests
[x] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Closing in favour of #3359


config.rabbitmq_config format more details

About the Rabbitmq setup variable the only way that I did it work was using amqp URI format:
config.rabbitmq_config = "amqp://user:password@host:port/vhost"
Is there another format way to use it?
Please if there is would it be possible to add it to README?
Thanks.

Hi @trombini77. Thank you for your question and suggestion. I'll be able to look into this eventually, but in meantime I'd recommend you have a look in the code, and if you find something we'd love if you could submit a PR to update the documentation.

@trombini77 health_check uses the Bunny gem to interface with RabbitMQ. Whatever you define in rabbitmq_config is passed directly to Bunny.new. So I'd recommend looking at Bunny's docs to see what is supported there.


Fishing rod issue.

You are unable to see your own fishing line when you try to fish. Other players are able to see it though.

In the latest version 0.4.5 this doesn't seem to be the case anymore.

It still appears to be an issue for me, can anyone else confirm its fixed?

Cannot replicate, closing. Tested with 1.9 & 1.8.9


Tutorial on adding custom policies

❔ Question
We have a requirement that needs cost optimization based on memory usage. Since AWS doesn't provide memory usage by default, like CPUUtilization. We have our own custom metrics with name spaces as Linux/Memory and/or Windows/Memory with metric name MemoryUtilization.
Creating a JAVA file for custom metrics seems possible but I am little lost on how to start. Can you provide a small tutorial that can be expanded to other custom metrics as well.
Policy Name: PacMan_LowUtilizationAmazonEC2InstancesRule_version-1

Hi Varun,
Follow below steps to write a custom rule in Pacbot
https://github.com/tmobile/pacbot/wiki/Write-a-new-Rule-in-PacBot.
Let me know if you need any further details
Thanks,
Kanchana

Thanks for the link. I'll give it a go and see how it works.

Basically, replace CPUUtilization with MemoryUtilization ?


"invalid name of certificate" from cdn.leafletjs.com

see attached screen shot

Closing as duplicate of #7165.


Smarts conversion failed

Description:

RDKit Version: 2017.09.2
Platform: Windows, python 3.5.4

I expected the Mol objects built both from Smiles and from Smarts are exactly the same; however, they seem different and Mol created from Smarts went wrong w/ MACCS fingerprint calculation as follows:
>>> m_smiles = Chem.MolFromSmiles('Cc1ccccc1')
>>> rdMolDescriptors.GetMACCSKeysFingerprint(m_smiles)# work correctly

>>> m_smarts = Chem.MolFromSmarts('Cc1ccccc1')
>>> rdMolDescriptors.GetMACCSKeysFingerprint(m_smarts)

---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-46-1d65f00d0d45> in <module>()
      3
      4 m_smarts = Chem.MolFromSmarts('Cc1ccccc1')
----> 5 rdMolDescriptors.GetMACCSKeysFingerprint(m_smarts)

RuntimeError: Pre-condition Violation
	getNumImplicitHs() called without preceding call to calcImplicitValence()
	Violation occurred on line 153 in file Code\GraphMol\Atom.cpp
	Failed Expression: d_implicitValence > -1
	RDKIT: 2017.09.2
	BOOST: 1_59

Sorry that my question may not make the point because I am a beginner in the chemoinformatics field, but I hope someone would answer my question.
Is it better for me to input the correct one with the correct method? For instance, are only Chem.MolFromSmiles(<correct SMILES syntax>) and Chem.MolFromSmarts(<correct SMARTS syntax>) acceptable?
Best regards,

While they are related, SMARTS and SMILES are quite different in practice.
SMARTS is like a chemistry regular expression and allows you to search for
structures in a molecule including very non-chemically sensical structures,
like five bonds to a carbon.

q = MolFromSmarts("C()()()()*")

This means that the Chemical Sanitization that RDKit normally uses cannot
be applied to a smarts pattern.  Taking the same structure and trying to
make a molecule (via MolFromSmiles) shows this:

q = MolFromSmiles("C()()()()*")

[23:03:38] Explicit valence for atom # 0 C, 5, is greater than permitted
The downside is that any downstream operation that requires real chemistry
won't have the data that it needs from a smarts pattern.
Again thinking of SMARTS as a regular expression that searches for
structures in a chemically sane molecule is  a useful conceit.  For more
information, this link may be useful:
http://www.daylight.com/dayhtml/doc/theory/theory.smarts.html
Now if you have a molecule and extract the structure matched by the smarts
pattern, then you might be able to do what you want.
Hopefully this make sense,  let us know if you need more assistance.
On Sun, Apr 15, 2018 at 10:33 PM, Sean<EMAIL_ADDRESS>wrote:

Description:

RDKit Version: 2017.09.2
Platform: Windows, python 3.5.4

I expected the Mol objects built both from Smiles and from Smarts are
exactly the same; however, they seem different and Mol created from Smarts
went wrong w/ MACCS fingerprint calculation as follows:

m_smiles = Chem.MolFromSmiles('Cc1ccccc1')>>> rdMolDescriptors.GetMACCSKeysFingerprint(m_smiles)# work correctly
m_smarts = Chem.MolFromSmarts('Cc1ccccc1')>>> rdMolDescriptors.GetMACCSKeysFingerprint(m_smarts)
---------------------------------------------------------------------------RuntimeError                              Traceback (most recent call last) in ()
3
4 m_smarts = Chem.MolFromSmarts('Cc1ccccc1')----> 5 rdMolDescriptors.GetMACCSKeysFingerprint(m_smarts)
RuntimeError: Pre-condition Violation
getNumImplicitHs() called without preceding call to calcImplicitValence()
Violation occurred on line 153 in file Code\GraphMol\Atom.cpp
Failed Expression: d_implicitValence > -1
RDKIT: 2017.09.2
BOOST: 1_59

Sorry that my question may not make the point because I am a beginner in
the chemoinformatics field, but I hope someone would answer my question.
Is it better for me to input the correct one with the correct method? For
instance, are only Chem.MolFromSmiles() and Chem.MolFromSmarts() acceptable?
Best regards,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/1823, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJbioL7JHdLpikzuJETXK5wOr2DbKxC0ks5tpALsgaJpZM4TVx-D
.

Dear @bp-kelley, I appreciate your very quick response.
I've got the picture by your saying that 'Again thinking of SMARTS as a regular expression that searches for
structures in a chemically sane molecule is  a useful conceit.'
I don't have the right person who knows about the differences between SMARTS and SMILES nearby and it is so great help.
Thank you so much.
Best regards,


Adjust MinUptime that forever uses

Tried to find an answer in the readme but I failed.
Had an issue with a bug that got deployed and it was not initiated until after 2 seconds which meant it was looping. I would like to adjust the value permanently. Can I do that via configuration?

It's not possible via config. You need to fork and use mup yourself.
This is the file you need to edit:
https://github.com/arunoda/meteor-up/blob/master/templates/linux/meteor.conf#L26
May be you can send me a PR which can be changed it from an env variable.
On Wed Feb 18 2015 at 4:32:12 AM David Rinnan<EMAIL_ADDRESS>wrote:

Tried to find an answer in the readme but I failed.
Had an issue with a bug that got deployed and it was not initiated until
after 2 seconds which meant it was looping. I would like to adjust the
value permanently. Can I do that via configuration?
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/269.

ok thanks!
Ill try to get some time to do a PR!

great.
On Wed Feb 18 2015 at 4:36:35 AM David Rinnan<EMAIL_ADDRESS>wrote:

ok thanks!
Ill try to get some time to do a PR!
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/269#issuecomment-74775013.

is linux/meteor.conf only run with setup? or reconfig as well?

I have made a PR #271
while writing this it struck my mind that I havnt actually tested it. :)
pretty straight forward though.
How do you normally carry out testing for MUP? I dont have a server available strictly for testing purposes. Any good suggestions on how to test without a server?


Polymorphic not handling polymorphism in select_related()

Hi there,
I have models like this:
from django.db import models
from polymorphic import PolymorphicModel
class B(PolymorphicModel):
    pass

class B1(B):
    pass

class A(models.Model):
    b = models.ForeignKey(B)

Now when I run the following test, I can see that select_related() is not dealing with polymorphism of the b relation:
>>> a = A()
>>> b = B1()
>>> b.save()
>>> a.b = b
>>> a.save()
>>> saved_a = A1.objects.select_related('b').filter(pk=a.id)[0]
>>> saved_a.b._class_
<class 'mytest.models.B'>
Any way to make it return a B1 object?

Same issue here. So there is no workaround for select_related()? This should be pretty important thing as select_related() saves hundreds of queries in most of cases.

Replacing select_related with prefetch_related seems to work indeed. I had a bug due to having an instance of the parent class in memory which didn't have the method available on it that the subclass does, thus getting an error when trying to call the method.
When I replace select_related with prefetch_related this error doesn't occur.
I assume that a new query for each object that I tried to prefetch isn't executed when trying to access the related object from it's parent object, but I haven't looked at the queries being done. I might do that later.


Cannot Copy Blob OpenRead() Stream

Which service(blob, file, queue, table) does this issue concern?
Blob
Which version of the Azurite was used?
Azurite v3.0.0-preview
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
NPM
What's the Node.js version?
v8.1.0
What problem was encountered?
Cannot copy open read blob stream to another stream.
Steps to reproduce the issue?

Create a blob in blob storage
Open a read stream of the blob (OpenRead() or OpenReadAsync())
Attempt to copy the blob stream to a new stream (stream.CopyTo() or stream.CopyToAsync())

Sample code:
var cloudBlob = _container.GetBlockBlobReference(blobName);
var memoryStream = new MemoryStream();
using (var stream = await cloudBlob.OpenReadAsync(cancellationToken)
{
await stream.CopyToAsync(memoryStream);
}
Have you found a mitigation/solution?
Use Azurite V2 (2.7.0)

Hi @Richyl2 I cannot reproduce this issue when trying to download blob via stream. Below is my sample code. My Azure Storage .Net SDK is 9.3.3.
using Microsoft.WindowsAzure.Storage;
using Microsoft.WindowsAzure.Storage.Blob;
using Microsoft.WindowsAzure.Storage.RetryPolicies;
using System;
using System.IO;
using System.Threading.Tasks;

namespace Azurite
{
    class Program
    {
        static void Main(string[] args)
        {
            sample().Wait();
        }

        static async Task sample()
        {
            string containerName = Guid.NewGuid().ToString();

            CloudStorageAccount storageAccount = CloudStorageAccount.Parse("UseDevelopmentStorage=true;");
            CloudBlobClient blobClient = storageAccount.CreateCloudBlobClient();

            Console.WriteLine("Creating Container");
            CloudBlobContainer container = blobClient.GetContainerReference(containerName);
            try
            {
                BlobRequestOptions requestOptions = new BlobRequestOptions() { RetryPolicy = new NoRetry() };
                await container.CreateIfNotExistsAsync(requestOptions, null);
            }
            catch (StorageException)
            {
                Console.WriteLine("If you are running with the default connection string, please make sure you have started the storage emulator. Press the Windows key and type Azure Storage to select and run it from the list of applications - then restart the sample.");
                Console.ReadLine();
                throw;
            }

            string file = "Git-2.16.2-64-bit.exe";
            CloudBlockBlob blockBlob = container.GetBlockBlobReference("blob.data");
            await blockBlob.UploadFromFileAsync(file);

            // Download blob to file system
            Console.WriteLine("Download Blob from {0}", blockBlob.Uri.AbsoluteUri);
            await blockBlob.DownloadToFileAsync(string.Format("./CopyOf{0}", "blob.downloaded.exe"), FileMode.Create);

            // Download blob into stream
            var memoryStream = new MemoryStream();
            using (var stream = await blockBlob.OpenReadAsync())
            {
                //await stream.CopyToAsync(memoryStream);
                string dest = string.Format("./blob.memorystream.exe");
                FileStream fileStream = new FileStream(dest, FileMode.OpenOrCreate);
                Console.WriteLine(dest);
                await stream.CopyToAsync(fileStream);
            }

            Console.WriteLine("Delete Container");
            await container.DeleteIfExistsAsync();
        }
    }
}

Still not working for me. However, the main difference here is I am using the 'Microsoft.Azure.Storage.Blob' SDK (v10.0.3) https://www.nuget.org/packages/Microsoft.Azure.Storage.Blob/10.0.3?_src=template . Here is a snippet of the code I am using (looks pretty similar).
`using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.Azure.Storage;
using Microsoft.Azure.Storage.Blob;
namespace Azurite.Bug
{
class Program
{
private static readonly byte[] SampleByteArray = new byte[] { 1, 2, 3 };
    static void Main(string[] args)
    {
        Sample().Wait();
    }

    static async Task<byte[]> Sample()
    {
        CloudStorageAccount storageAccount = CloudStorageAccount.Parse("UseDevelopmentStorage=true;");
        CloudBlobClient blobClient = storageAccount.CreateCloudBlobClient();

        CloudBlobContainer container = blobClient.GetContainerReference(Guid.NewGuid().ToString());
        await container.CreateIfNotExistsAsync();

        CloudBlockBlob cloudBlockBlob = container.GetBlockBlobReference(Guid.NewGuid().ToString());
        await cloudBlockBlob.UploadFromByteArrayAsync(SampleByteArray, 0, SampleByteArray.Length);

        using (var stream = await cloudBlockBlob.OpenReadAsync())
        {
            using (var memoryStream = new MemoryStream())
            {
                await stream.CopyToAsync(memoryStream);
                return memoryStream.ToArray();
            }
        }
    }
}

}`

@Richyl2  In your sample, MemoryStream already has data in it's inner _buffer, not sure why it doesn't convert to byte array.

How strange! Thanks for your quick response and help with the issue 👍! Will stick to Azurite v2.7.0 for now as I need this for our build system.


AttributeError: 'Image' object has no attribute 'new'

Hi, Why am I facing this error ?
its complaining about this line:
alpha = img.new().resize_(3).normal_(0, self.alphastd)
Whats wrong here? I'm using Pytorch 0.4

Found the cause of the error! I had to use transform.ToTensor() prior to calling the Lighting() method. failing to do so results in an PIL image being sent as the input for lightining() which expects a Tensor and thats why the error occurs.


Translation to Spanish: Verify and update translation of automated-testing-and-debugging.json

[x]  Use the Javascript Console
[x]  Using typeof

[X] Use the Javascript Console
[X] Using typeof

Verified. No changes are necessary.

Closing then. Thanks.


URL parser for Ausländer

I read in this comment that you may have tried working on it https://www.reddit.com/r/berlin/comments/ppxaqr/comment/huda954/?utm_source=share&utm_medium=web2x&context=3
I'm wondering if instead of dealing with the form you can just parse the URL of the pre-filled form, for example https://otv.verwalt-berlin.de/ams/TerminBuchen/wizardng/6efbab98-b17e-4dc0-8015-4db0f0f2ad6b?dswid=1173&dsrid=486&st=2&v=1652861470436
I'd love to try working on it but not sure how to deploy a bot, any info would be appreciated. Thank you for your effort so far ☀

hey there, thanks! if it ended up working - that would be cool! I had trouble debugging the happy path and lack of motivation to work on it further.
regarding deployment - I normally was deploying it from my machine, but I'll try to add GitHub action here that will be doing that automatically on merge

I started PR #8


Wire up Grammar-Kit Gradle plugin to frontendFile

@micpiotrowski feel free to incorporate these changes into your PR #338

Ok, merged, can be closed


auxdisplay: Add SerLCD auxdisplay driver

SerLCD is an interface for several lcd character display sold by sparkfun.

Thank you for your review, I hope I have all comments addressed.

Addressed the review comments.

All remaining comments addressed

Hi,
are there any remaining issues? I would like to get this merged.

Zephyr is in feature freeze mode for the 3.5 release, this can be merged after the release is complete (which should by this Friday)

Any updates on this?

@janhenke I've manully added it to my project, but can you also please include an example board (with I2C) to show how you actually define it inside the devicetree ?
Thanks :)

@fabiobaltieri please merge :)

@janhenke I've manully added it to my project, but can you also please include an example board (with I2C) to show how you actually define it inside the devicetree ?
Thanks :)

I not think it would be helpful to have a separate example project for every device driver, especially as this driver is pretty standard in terms of the devicetree.
But here you go:
&i2c1 {
	serlcd@72 {
		compatible = "sparkfun,serlcd";
		reg = <0x72>;
		columns = <16>;
		rows = <2>;
	};
};

&i2c1 {
	serlcd@72 {
		compatible = "sparkfun,serlcd";
		reg = <0x72>;
		columns = <16>;
		rows = <2>;
	};
};

Since there's no upstream board with this you could add it in the description part of dts/bindings/auxdisplay/sparkfun,serlcd.yaml if you want, few other bindings do it.

Compliance issues need fixed


url and identifier in the license field are handled incorrectly

Currently, swagger-parser will error with the following message attribute info.license.identifier is missing when parsing an OpenApi 3.1 document where license.url and license.name is set (see the example document below).
According to the official OpenApi 3.1 schema it must have either the license.url or the license.identifier set but not both.
This PR will fix swagger-parser to work according to the schema.
Example OpenApi 3.1 which currently fails:
openapi: 3.1.0
servers:
  - url: 'http://abc:5555/mypath'
info:
  version: '1.0'
  title: dd
  license:
    name: test
    url: http://example.com
paths:
  /resource1/Id:
    post:
      description: ''
      operationId: postOp
      responses:
        '200':
          description: Successful
        '401':
          description: Access Denied
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/mydefinition'
        required: true
components:
  schemas:
    mydefinition: {}

Link to the OpenApi 3.1 schema:
https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#licenseObject

Thanks!


update: add a new plugin type for streamed scap data

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
What this PR does / why we need it:
This adds definitions for a new plugin type named capture plugin. Similarly to source plugins, this new type of plugin is meant to produce events. However, source plugins are tied to produce events from a specific source type, and most certainly can't produce events related to syscalls. Capture plugins are meant to fill this gap by allowing to generate raw events, like the ones contained in scap files. For this reason, this plugins uses the scap format as an open standard to produce events.
Applications of capture plugins might involve generating scap data on-the-fly, streaming it from a network connection, or reading it from a file.
The APIs for capture plugins are defined as follows:
const char* (*get_required_api_version)();
uint32_t (*get_type)();
ss_plugin_t* (*init)(const char* config, ss_plugin_rc* rc);
void (*destroy)(ss_plugin_t* s);
const char* (*get_last_error)(ss_plugin_t* s);
const char* (*get_name)();
const char* (*get_description)();
const char* (*get_contact)();
const char* (*get_version)();
ss_instance_t* (*open)(ss_plugin_t* s, const char* params, ss_plugin_rc* rc);
void (*close)(ss_plugin_t* s, ss_instance_t* h);
ss_plugin_rc (*read)(ss_plugin_t* s, ss_instance_t* h, uint8_t* buf, uint32_t n, uint32_t *nread);

This type of plugins can open and close a capture session, similarly to what we have for source plugins. Then, all the extraction-related symbols are excluded, and the API is simplified to only rely on a read function. libscap calls read repeatedly to consume the scap-formatted data, and extract events from it until EOF is reached.
Accordingly, this PR bumps the plugin API to version 0.3.0.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
update: add a new plugin type for streamed scap data
update: bump plugin api version to 0.3.0

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign ldegio after the PR has been reviewed.
You can assign the PR to them by writing /assign @ldegio in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnosek thank you for your review, I addressed your comments.

LGTM label has been added.  Git tree hash: 3e705e45ff4ffc69268b95ba32ae138bc1aee632

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Probably it's too late to include this in the next Falco release, so...
/hold

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

We can close this for now. I still think this concept has potential, but there's no use for it right now, and this implementation is very old and unaligned with the most recent changes.


[JS-to-C++ test] Rename example app's tests

Rename example_cpp_smart_card_client_app's /integration_tests/ to /js_to_cxx_tests/. We concluded on this new name while adding such tests to smart_card_connector_app recently.
This is a pure refactoring commit. The related effort is tracked by #869.

can you also update example_cpp_smart_card_client_app/build/Makefile?

good catch, done


Pointer to anonymous structure types have problems

Version and Platform (required):

Binary Ninja Version: 3.0.3395-dev
OS: macOS
OS Version: 12.0.1
CPU Architecture M1

Bug Description:
When a type is a pointer to an anonymous structure, several things break. Notably:

The types view shows them as typedef struct* foo;
References to them in the ILs show as struct* whatever;
There may be issues with aliasing the type? (revenge of #2428 ?)

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Open the binary from #3108
Open the types view
Search for IUnknown
Observe broken type

Expected Behavior:
I expected either typedef struct { contents }; or some sort of way to see the inner fields.
Screenshots:

Additional Information:
This is similar to #3108 but harder, as this would require fixing the underlying problems with our handling of pointers-to-anonymous-structures, instead of just changing the type libraries to never produce them.

This was fixed by the clang updates for 3.1 which also changed the way these types are rendered.


Migrate mobilenet_v3 from keras-team/keras-applications to tensorflow/tensorflow/python/keras/applications/

Just like mobilenet_v2.py and all the others migrated to https://github.com/tensorflow/tensorflow/tree/master/tensorflow/python/keras/applications on Apr 3rd, https://github.com/keras-team/keras-applications/blob/master/keras_applications/mobilenet_v3.py is ready to be migrated since Apr 2nd
Are you willing to contribute it (Yes/No): No
Will this change the current api? How? No
Who will benefit with this feature? All users

MobileNetV3 application is now added in TF 2.4.1.
See api docs:
https://www.tensorflow.org/api_docs/python/tf/keras/applications/MobileNetV3Large
https://www.tensorflow.org/api_docs/python/tf/keras/applications/MobileNetV3Small
Thanks!


Wrong version in link

URL for relevant page?
https://docs.influxdata.com/chronograf/v1.5/introduction/getting-started/
What products and version are you using?
latest....
Where did you look before opening the issue?
wget https://dl.influxdata.com/chronograf/releases/chronograf_<IP_ADDRESS>_amd64.deb
sudo dpkg -i chronograf_<IP_ADDRESS>_amd64.deb

should reflect the latest version not an old one especially considering it is a page specifically for v1.5 it should not have a link to v1.4
Maybe there should be a static link to the latest version.

Made this non-specific about versions. Changed the step to say to download and install InfluxDB, getting the files at the InfluxData Downloads page. Closing -- change made in master and will appear in next build.


Embed Twitter timeline

Number of Volunteers: 1
Would be nice if we can embed a Twitter timeline on our home page.
See here for instructions.
Should be easy but low priority.
Probably check with Publicity chairs about this.

@ppartha03 @raghavjajodia @ninell-oldenburg Can you three discuss who will work on this? I think we probably only need one person.
Also, this is pretty low priority right now so it would be nice to work on higher priority issues first.

I'll unassign myself. I started working on another issue :-)

Close this since we will have a bot in Rocket.Chat to sync tweets.


[breaking] remove support for encoded directories

This is technically breaking, but only barely. Encoded directories mostly didn't work save for 11 characters. It's not clear to me it's possible to support more than that and those characters can generally be represented in a much nicer way in decoded format anyway. There's really no reason a user should have been writing %40 instead of @ in their directory name in the first place. I think #, ? (only on Linux and Mac), and : (only on certain Windows systems) are the only ones that might be a bit less convenient to write as you'd now have to use a parameter matcher now. This seems like a good trade-off for making the code and docs much easier to understand
I removed the $SVLT test simply because it's already covered by other tests such as the @svelte test. The others were removed because they were testing encoded characters in directories which we no longer support
Closes https://github.com/sveltejs/kit/issues/7554
Closes https://github.com/sveltejs/kit/issues/7567
Closes https://github.com/sveltejs/kit/pull/7573
Closes https://github.com/sveltejs/kit/pull/7563
Probably solves https://github.com/sveltejs/kit/issues/7577 although I'm going to leave that open for a bit longer as I'd like to check on a couple more things first

We initially had this because we wanted to be able to support routes with arbitrary special characters in them. Without this, there's no way of having a route with literal characters in it that would normally have special meaning to SK other than to create a dummy param with a matcher that matches that one specific string.  I don't think we want to completely remove support for encoded directory names.

Yes, however, that has never actually worked. I tried dozens of versions going back more than a year to at least Vite 2.5 and none of them supported putting %5b (an encoded [) in the route except as a parameter. So this doesn't change anything in that regard. And more importantly, as far as I can tell, I don't think it's something Vite supports and thus would be impossible for us to implement even if we wanted to.
If we make this change now it puts us in a safe place for 1.0 where what we claim to support and actually support match. It would be backwards compatible to add support for encoded routes in the future if anyone else can figure out how or there's a new release of Vite that begins supporting it. In the meantime, it's such an uncommon character to have in a URL and no one has ever filed an issue about it, so I don't think it's a very common use case that we need to implement before 1.0.

I haven't followed the (de)coding madness in the past, so how big of a breaking change is this? Were people previously forced to do %40[username] and now they are forced to do @[username], or did @[username] always work, so people had two ways of doing the same? How often do people want to have # or ? in their filenames (any examples of that in the wild)? Does this have any effect on the characters encoded inside parameters ([blog] where blog is does-this-work%3F; %3F is ?)?

@ always worked, so this is a very minor breaking change. There are only three characters that are somewhat affected per the PR description. I don't believe you were ever allowed a % inside brackets as part of a parameter name

I mean the potential impact to people who have written down their paths in an encoded manner at the moment (hello/world%3F/+page.svelte) - from what I understand, this would no longer be possible, which might be a bigger breaking change than we think.

There were only 11 characters that were even possible to write in encoded format previously. I've honestly never seen one in the wild. hello/world%3F is a pretty ugly URL, so people don't tend to hard code symbols like that in URLs but only use them in dynamic contexts.

Been noodling around on this stuff locally and while I was able to get everything basically working for SSR and in a built app, it fails when JS kicks in because Vite can't load modules with certain characters in them. I think it's probably a Vite bug, but I also think that using URL-encoded characters in filenames is always going to be fraught.
So I agree that we should remove support for URL-encoded characters in directory names. I don't agree that we should prevent people from using those characters in their routes though. Asking people to do foo[x=colon]bar for /foo:bar — creating a useless x param and forcing the creation of a colon matcher — is user-hostile in my view.
So we need a way of encoding certain characters that Vite can understand and that works on all filesystems. Ideally, it would be familiar to web developers. Luckily, just such a method exists: HTML entities. The example above would become foo:bar.
Ideally, the decoding would happen as early in the process as possible. I think we should be able to decode everything except the characters that that are meaningful to SvelteKit: [ ] ( ). (Aside: we've talked about this before without resolution — do we need to reserve any other characters, in case we want to implement something like Next's proposed dynamic parallel routes? Or are we okay with something like that requiring a major version bump?)


Error with react 18

Description
seems related: https://github.com/inlet/react-pixi/issues/306
react-dom.development.js:22665 Uncaught Error: Expected subtree parent to be a mounted class component. This error is likely caused by a bug in React. Please file an issue.
    at findCurrentUnmaskedContext (react-pixi.es-dev.js:3904:15)
    at getContextForSubtree (react-pixi.es-dev.js:20484:23)
    at Object.updateContainer (react-pixi.es-dev.js:20603:17)
    at Stage.componentDidMount (react-pixi.es-dev.js:22880:17)

Steps to reproduce

Use the code from https://reactpixi.org/components/graphics
The error above appears.

Additional info

@inlet/react-pixi version: 6.7.0
React version: 18.0.0
ReactDOM version: 18.0.0
PIXI version: 6.3.0

Is there a solution for this?

Is there a solution for this?

I couldn't find any solution in the past several months, so I migrated to raw WebGL instead.

This should be fixed now in v7.0.0-alpha.0, please install from @pixi/react-pixi


Add Search

What:
Add Google Search functionality following design system pattern placement in upper right of page (see Cannabis), but styled consistent with Drought CSS and color scheme.
Why:

Help users locate content as we start to flesh out what's on the drought site (more and more stuff!)
Alternative ways to find information (accessibility angle as well)
Design system consistency (Cannabis has search)

Example:
https://cannabis.ca.gov/
https://cannabis.ca.gov/serp/?q=testing
Acceptance:

Drought site content is ingested/scrapped appropriately so that it can be returned as search results
User able to input search string
** Obtain search results when there are results from the Drought site
** Obtain "no results" view when there are no results from the Drought site. Example: https://cannabis.ca.gov/serp/?q=blahblah
With search implemented, ensure we have appropriate level instrumentation so we can see search terms look uped as part of site analytics. Helps determine trends. Maybe this needs to be a separate ticket and needs to involve ODI Insights team.

@xjensen can you start looking into this into next week? Happy to hammer our more implementation specifics as followup, but would be great if you could do an initial pass with Jim/Chach to start. Thanks!

@jaredwyee, yes, can do. I'll start familiarizing myself with the challenge.

cc @adam-little in case there is design work here we want to consider.

No additional design changes at this point. Just match Cannabis (except use Drought color).


Custom Fonts and Color Palettes

See this website for color palettes

See this website for setting up color palettes in R. It discusses the base plotting functions with RColorBrewer library, by providing minimum reproducible examples.


Record whether a CodeAction is a fix or not

Omnisharp-roslyn side of fixing https://github.com/OmniSharp/omnisharp-vscode/issues/5335.

Tuples are great for these types of intermediate structure scenarios.

@JoeRobich @filipw for review please.


[Feature] [k8s] Add k8s CI test and GitHub Actions

Purpose of the pull request
Add K8S CI in github actions.
Brief change log
Add a k8s test to verify follow points:

Lint test
Chart Install test: mainly for dolphinscheduler chart and zookeeper, postgresql
Check server status ready

Files changed:

.github/workflows/ci_k8s.yml  CI to Github Actions
docker/kubernetes/check-node.sh check k8s node already
docker/kubernetes/check.sh check server

Verify this pull request
This change added tests and can be verified as follows:

Added dolphinscheduler k8s test to ensure we can build a correct and healthy cluster on k8s.

@Xuedixuedi you use so many third party GitHub Actions that are not allowed in Apache infra, please try to use submodules

Codecov Report

Merging #6190 (273796c) into dev (04720b3) will decrease coverage by 3.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #6190      +/-   ##
============================================
- Coverage     46.29%   42.83%   -3.47%
- Complexity     3732     4798    +1066
============================================
  Files           609      692      +83
  Lines         25074    34549    +9475
  Branches       2868     4593    +1725
============================================
+ Hits          11608    14799    +3191
- Misses        12322    18414    +6092
- Partials       1144     1336     +192

Impacted Files
Coverage Δ

...uler/server/worker/runner/WorkerManagerThread.java
43.33% <0.00%> (-33.14%)
:arrow_down:

...r/service/queue/PeerTaskInstancePriorityQueue.java
65.38% <0.00%> (-27.95%)
:arrow_down:

.../server/worker/processor/TaskExecuteProcessor.java
55.35% <0.00%> (-20.26%)
:arrow_down:

...eduler/server/worker/runner/TaskExecuteThread.java
38.38% <0.00%> (-18.34%)
:arrow_down:

...inscheduler/server/worker/config/WorkerConfig.java
13.33% <0.00%> (-13.34%)
:arrow_down:

...inscheduler/server/master/config/MasterConfig.java
27.58% <0.00%> (-8.78%)
:arrow_down:

...nscheduler/server/entity/TaskExecutionContext.java
77.87% <0.00%> (-8.69%)
:arrow_down:

...er/server/builder/TaskExecutionContextBuilder.java
47.27% <0.00%> (-7.28%)
:arrow_down:

...er/api/service/impl/TaskDefinitionServiceImpl.java
45.70% <0.00%> (-7.08%)
:arrow_down:

...he/dolphinscheduler/common/utils/ScriptRunner.java
51.51% <0.00%> (-7.06%)
:arrow_down:

... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04720b3...273796c. Read the comment docs.


.ui5ignore file as a tool to resolve what to build and what not || .gitignore / .npmignore support

Hi, guys
I have a proposal.
Sometimes it is convenient to control what to include and what not into build.
I am really afraid - that CLI option is not a right place to resolve this dependencies as this list might be quite complicated.
Working with git and npm we already have standard in using .gitignore and .npmignore files to control what is going to be pushed and published.
So it might be a nice feature also to have .ui5ignore file to control what is gonna be build.
For example I would like to define some dependency inside src folder ( lodash.merge or moment.js ) and I want to build library only with index.js file - ignoring the rest.
Thank you!

Hey @ThePlenkov,
Thank you for this suggestion.
Just checking, are you aware of the builder.resources.excludes ui5.yaml configuration (see documentation)? I think this should already help with your use case.

@RandomByte - actually I haven’t seen it. Thank you. Gonna try it - may be is enough

yes, this section makes its work. Thank you! I will sync it manually with gitignore)) Thanks!