feat: Added ability to rollback a helm release

Description

Functionality added to rollback a helm release
Helm app Deployment history API response change to support rollback helm release feature

Fixes # https://github.com/devtron-labs/devtron/issues/1281
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
By hitting new Rollback release APIs and helm app deployment history APIs (for both full and hyperion mode)
Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR require documentation updates?
[ ] I've updated documentation as required by this PR.
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas

Unit testcase is not required. API testcases are needed.

@manish-agrawal-ai can we add template for this bug/feature ?


Add entity names (for debug purpose only). Also add system that renders named entities

solved in main


[question]

hi there! This project looks really cool, i'm glad it exists.
I was hoping you could elaborate on how this crate fits into the existing ecosystem - is this crate competing against, or complimentary to juniper?

Hi @danieleades, thanks for the question!
We didn't write this project to compete with other projects in the ecosystem. We wanted to have a library with built in semantic analysis to help us write more performant composition and query planning for Apollo Federation implementations along with a few other schema manipulation tools. While it's built to work for some of Apollo's tools, we chose to make it generic enough that other folks can use it as well if they chose to. juniper is a really brilliant project, and I think it'd be cool to see if apollo-parser could work with it!

i think the strength of Rust is the community. If there's any scope for having apollo and juniper pulling in the same direction, that's got to be a win


Incompatibility with immersive portals, (now with the right crashlog)

here is the popper crashlog
bclib 1.3, immersive portals 1.2.5, fabric api 46.4

Duplicate of https://github.com/paulevsGitch/BCLib/issues/85


[ci] fix CI by updating validate_documentation workflow docker image

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.
[x] I've added or updated relevant unit tests.

Motivation and Context
CI is broken in master:

I think CircleCI pushed some breaking changes on their end because this happened without us making changes.
Description
We'd need to update the docker image from one that is using Ruby 2.6.x to 3.x, and just 2 weeks ago we updated ours to 2.7. I'm not sure if we really need a custom docker image for this workflow/lane, it's just a validation step. If this passes CI, I think it's better to lean on standard CI-provided images since they require less maintenance, so next time we need to bump we simply update this LOC, instead of having to update a docker image in another repo. Happy to hear dissenting opinions though 🙏 I'm curious to understand why this specific workflow/lane required a custom image.
Testing Steps
Pass CI.

New here


Why is the NuGet.exe file installed into my projects?

After using NuGet to install this library into my projects I noticed that the NuGet.exe file was added to each of them. Why is this needed?

This no longer occurs as of 1.6.3


Black doesn't format docstrings??

oddly enough black doesn't seem to format docstrings properly. i'm not sure why but will open this as something to look into in the future!!

to address this i've #198 added flake 8 to hit docstring and other line length issues! it also catches unused imports!! yay


Any plan to support using Angular4 ?

Can we have a demo about sign using Angular ????

It's server side project.


[Bug]: Inconsistent Responses with VLLM When Batch Size > 1 even temperature = 0

🐛 Describe the bug
Test Environment:

Hardware: A100 80GB GPU
Model: Llama3-8b
- Parameters: temperature = 0, max_tokens = 1024, max_num_seqs = 256, seed=1
I make OpenAI-Compatilbe Server using python -m vllm.entrypoints.openai.api_server  ...

Test Method:

First, requests were sent one at a time to verify if the same prompt consistently produces the same response.
Second, more than one requests with same prompt at a time were sent  to verify if the same prompt consistently produces the same response.

Discovered Issue:
- Consistency with Single Request: When the batch size is 1, the same prompt consistently produces the same response.
- Inconsistency with Multiple Requests: When the batch size increases to more than 1, the responses for the same prompt become inconsistent.

When I set vllm server with parameter max_num_seqs = 1, the result is all same

I think this suggests that the issue arises from the way the Batch Scheduler processes multiple requests together.
My problem is similar with others
https://github.com/vllm-project/vllm/issues/3544
https://github.com/vllm-project/vllm/issues/4606
https://github.com/vllm-project/vllm/issues/608

Also related: #5404

@gjgjos Do you see the same behaviour if you use float32 out-of-interest?

also: how different are the responses you are seeing? are they total garbage? or do they start off as expected and then diverge to something reasonable but different to the single request case.

This phenomenon is caused by the different operations corresponding to float16 and float32.

also: how different are the responses you are seeing? are they total garbage? or do they start off as expected and then diverge to something reasonable but different to the single request case.

The responses are very similar. Only one or two words are different. This issue is only for float 16. Also, not only vllm but also huggingface or fastertransformer makes this issue.
What is exact reason and is there any solution for FP16?

makes

Hi! I tried fp32 when generating MATH500 results. And I found about 10/500 pieces are different during dual testing. So it seems that fp32 cannot fix this bug.

I think I also met this issue:
https://github.com/vllm-project/vllm/issues/7779
You can see the logprob is slightly different for each generation.
After change max_num_seqs 1, 500 generation got exactly same result.
Could you please help to explain more about this issue and how to fix it?
Thanks in advance!

We encountered exactly the same issue, and we are currently using FP16.
In our use case, this kind of data fluctuation is quite critical to the results, and we are looking for a solution.
Is there any solution to this problem now? Thanks.

Any updates here?


Tooling & fixing code style issues

Added gulp
Added eslint with airbnb config
Added uglify
Added package.json
Fixed errors which came up with eslint

Note, even though I went through the file, fixed all the issues which came up in eslint and added gulp with uglifier, I did not test the code itself. But there shouldn't be any problems.

Hi there, can you resolve the conflicts please. Thanks. Also, it would be great if we don't change the code pattern.

Well, the only reason I did any changes to the code pattern was because eslint gave me 198 errors, all of which are now fixed in this PR..

It would be great if this lib had tests, so we could be 100% sure we don't break existing functionality by accident.

@JuhQ Sure thats coming soon, I'll be working on that by this weekend. Also, I appreciate your efforts, but just because we don't have tests for the same, I am bit reluctant for the lib pattern changes.

Totally understood. Let's merge this after there's tests, so I we can be sure this pr doesn't break any existing functionality. I'll rebase and refactor once some tests are implemented. Drop a note on this pr when they are done and I'll start work on that.
There's no reason to hurry this pr, better be sure no existing functionality is broken

@JuhQ Great, thanks a lot. I'll update you, once am done with the tests.

@i-break-codes conflicts fixed


npm package contains tmp folder

Hello,
I just noticed that the currently released npm package (0.1.5) has a tmp folder inside, that is 13.8 MB large. Since it's not under version control here, I guess it shouldn't be there, but was present while publishing the package. Removing this subfolder would decrease the package size from 13.8 MB to 43.4 KB :grinning:
Ben

This should be resolved now, thanks.


How should I use psake NuGet package?

I'd like to reference psake in my project through NuGet to be able to update it easily. However, I'd also like to have some kind of just-run-this-file-and-everything-will-build.cmd somewhere it can be easily found (i.e., in root dir of a project).
As for now, NuGet puts psake stuff into solution-dir\packages\psake.<IP_ADDRESS>\tools. The version part will obviously change, so how should my runner.cmd looks like?
UPD: I mean, there's a way to just use whatever version exists through simple logic (take whatever matched psake* and use it), but I wonder if there's a simpler way to do it.

I know this is a bit dated, but you could create folders at the solution level and put any scripts that need referencing in there. I am happy to if needed.


sizing nodes by a variable in 2d does not propogate to 3d view

Not sure if this supposed to be a feature, but if 3D view is supposed to also have node sizing, it's not transferring over from 2D

I looked at this feature and it seems that 2D and 3D have the same sizing by node feature independently in the options for each view. The features that propagate to other open views are usually in the global settings menu and selecting nodes. I think it is best to keep it that way since propagating settings at the view level will introduce problems with precedence and independent control of the feature.

I can implement this behavior if this feature deserves special treatment.

FWIW, I strongly agree with @jaywokim. It's supposed to work that way, for exactly the reason he described.


make cephcsi is failing in head branch

Describe the bug
make cephcsi should create a docker image.
[root@localhost ceph-csi]# make cephcsi
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
if [ ! -d ./vendor ]; then (go mod tidy && go mod vendor); fi
GOOS=linux go build -tags=reef -mod vendor -a -ldflags '-X github.com/ceph/ceph-csi/internal/util.GitCommit=c0fc7b36e38d94a38500490a4c988beaa1179cdf -X github.com/ceph/ceph-csi/internal/util.DriverVersion=canary' -o _output/cephcsi ./cmd/
# github.com/ceph/go-ceph/rbd
vendor/github.com/ceph/go-ceph/rbd/encryption.go:35:50: could not determine kind of name for C.RBD_ENCRYPTION_ALGORITHM_AES128
vendor/github.com/ceph/go-ceph/rbd/encryption.go:36:50: could not determine kind of name for C.RBD_ENCRYPTION_ALGORITHM_AES256
vendor/github.com/ceph/go-ceph/rbd/encryption.go:73:19: could not determine kind of name for C.RBD_ENCRYPTION_FORMAT_LUKS1
vendor/github.com/ceph/go-ceph/rbd/encryption.go:87:19: could not determine kind of name for C.RBD_ENCRYPTION_FORMAT_LUKS2
vendor/github.com/ceph/go-ceph/rbd/encryption.go:29:26: could not determine kind of name for C.rbd_encryption_algorithm_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:111:9: could not determine kind of name for C.rbd_encryption_format
vendor/github.com/ceph/go-ceph/rbd/encryption.go:22:11: could not determine kind of name for C.rbd_encryption_format_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:136:9: could not determine kind of name for C.rbd_encryption_load
vendor/github.com/ceph/go-ceph/rbd/encryption.go:64:12: could not determine kind of name for C.rbd_encryption_luks1_format_options_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:78:12: could not determine kind of name for C.rbd_encryption_luks2_format_options_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:23:11: could not determine kind of name for C.rbd_encryption_options_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:71:30: could not determine kind of name for C.sizeof_rbd_encryption_luks1_format_options_t
vendor/github.com/ceph/go-ceph/rbd/encryption.go:85:30: could not determine kind of name for C.sizeof_rbd_encryption_luks2_format_options_t
make: *** [Makefile:164: cephcsi] Error 1
[root@localhost ceph-csi]#

A clear and concise description of what the bug is.
Environment details

Image/version of Ceph CSI driver :
Helm chart version :
Kernel version :
Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
krbd or rbd-nbd) :
Kubernetes cluster version :
Ceph cluster version :

Steps to reproduce
Steps to reproduce the behavior:

Setup details: '...'
Deployment to trigger the issue '....'
See error

Actual results
Describe what happened
Expected behavior
A clear and concise description of what you expected to happen.
Logs
If the issue is in PVC creation, deletion, cloning please attach complete logs
of below containers.

csi-provisioner and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in PVC resize please attach complete logs of below containers.

csi-resizer and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in snapshot creation and deletion please attach complete logs
of below containers.

csi-snapshotter and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in PVC mounting please attach complete logs of below containers.

csi-rbdplugin/csi-cephfsplugin and driver-registrar container logs from
plugin pod from the node where the mount is failing.

if required attach dmesg logs.

Note:- If its a rbd issue please provide only rbd related logs, if its a
cephFS issue please provide cephFS logs.
Additional context
Add any other context about the problem here.
For example:
Any existing bug report which describe about the similar issue/behavior

@parth-gr have you followed https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#development-workflow?

The easiest is to run make containerized-build, that provides all dependencies in a container and you won't need to install Ceph or other development libraries on your system.

Not sure but looks like something wrong with the setup
[rider@localhost ceph-csi]$ make containerized-build
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
docker run --rm -v /home/rider/go/src/github.com/ceph/ceph-csi:/go/src/github.com/ceph/ceph-csi:z quay.io/cephcsi/cephcsi:devel make cephcsi CONTAINERIZED=yes
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
fatal: detected dubious ownership in repository at '/go/src/github.com/ceph/ceph-csi'
To add an exception for this directory, call:

	git config --global --add safe.directory /go/src/github.com/ceph/ceph-csi
if [ ! -d ./vendor ]; then (go mod tidy && go mod vendor); fi
GOOS=linux go build -tags=reef -mod vendor -a -ldflags ' -X github.com/ceph/ceph-csi/internal/util.GitCommit= -X github.com/ceph/ceph-csi/internal/util.DriverVersion=canary' -o _output/cephcsi ./cmd/
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
make: *** [Makefile:164: cephcsi] Error 1
make: *** [Makefile:200: containerized-build] Error 2

Secondly do we keep ceph-csi insisde the ceph project  generally for development?

In mac I am getting
rider@Parths-MacBook-Pro ceph-csi % make containerized-build
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
podman run --rm -v /Users/rider/Desktop/go/src/github.com/ceph/ceph-csi:/go/src/github.com/ceph/ceph-csi quay.io/cephcsi/cephcsi:devel make cephcsi CONTAINERIZED=yes
Trying to pull quay.io/cephcsi/cephcsi:devel...
Error: initializing source docker://quay.io/cephcsi/cephcsi:devel: reading manifest devel in quay.io/cephcsi/cephcsi: manifest unknown
make: *** [containerized-build] Error 125
rider@Parths-MacBook-Pro ceph-csi %

Not sure but looks like something wrong with the setup
[rider@localhost ceph-csi]$ make containerized-build
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
docker run --rm -v /home/rider/go/src/github.com/ceph/ceph-csi:/go/src/github.com/ceph/ceph-csi:z quay.io/cephcsi/cephcsi:devel make cephcsi CONTAINERIZED=yes
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
fatal: detected dubious ownership in repository at '/go/src/github.com/ceph/ceph-csi'
To add an exception for this directory, call:

	git config --global --add safe.directory /go/src/github.com/ceph/ceph-csi
if [ ! -d ./vendor ]; then (go mod tidy && go mod vendor); fi
GOOS=linux go build -tags=reef -mod vendor -a -ldflags ' -X github.com/ceph/ceph-csi/internal/util.GitCommit= -X github.com/ceph/ceph-csi/internal/util.DriverVersion=canary' -o _output/cephcsi ./cmd/
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
make: *** [Makefile:164: cephcsi] Error 1
make: *** [Makefile:200: containerized-build] Error 2

Secondly do we keep ceph-csi insisde the ceph project generally for development?

connected offline with @parth-gr,
Issue was due to change in folder ownership. By changing the owner to correct user issue was resovled.
@parth-gr, can we close this now?

Sure get is running by make -j4 image-cephcsi CSI_IMAGE_NAME="quay.io/mpraveen/cephcsi" CSI_IMAGE_VERSION="volsnap-omap-regenerate" GO_ARCH="amd64" and updating the folder permissions


Reindex/reload items from html

It would be nice to have a function for re-index/reload the list from html. In my case the content changes via ajax.

Would be great to have this features, this is the only "bad point" of your library.
If we have to refresh the page, what is the actual solution ? Re-declare a new List ? This will consume more and more memory isn't it?
Thanks.

+1

The feature is on it's way (finally)

:+1:

Great!

Have you a stable release for this fix?

@javve At least, can you give us some indication to use this new feature?

@javve I agree with @Soullivaneuh. It would be great to have short instruction on how to use this feature. List.js is awesome (!), but the absence of this feature is giving me a hard time, when working with ajax :/

v1.2.0 is now released and this should work now! Please tell me if not :disappointed_relieved:
Release note: https://twitter.com/javve/status/705104547451170816 RT = :heart: :grin:
Docs for reIndex(): http://www.listjs.com/docs/list-api#reindex

Thank you for reindex().
Do you have an exemple of use please ?
Thanks again.

Thank you for reindex().
Is it possible to reindex pagination too ? When reindexing, it seems that only items are reindexed, not pagination. Or maybe am I using it the wrong way ?
@dubinfo Just use myList.reindex() assuming that myList is a list initialized before.

+1 for pagination refresh. When I dynamically add an item (not using the add method as I have a very large and complex object to add) all other pages are lost. I've tried all combinations of .reIndex() and .update() but nothing works. Currently I think I'll have to abandon pagination which is a shame. Great otherwise, thanks

Will the new update (1.2.0) be added to some Maven repository's also? The latest version there is 1.1.1. Would like to use the update() function :+1:

@sylvainmetayer in case u want to change the item display per page, just change page property of your list variable like "mylist.page = 10" and run mylist.update()

I would also want to update pagination when changing the option page size property. Any suggestions?

If you use ajax and want to reindex, you can do it to retrieve everything after the ajax call :
yourList.filter();      //reinitialise list (add all items in dom)
yourList.reIndex(); //reinitialise index with items in dom
projectFilter();       //apply filter
//projectFilter is th name of my function who initialize variables with filters checked and selected. This function embedded :
userList.filter(function(item) {
// (...) code here with res = true/false
});

+1 for pagination refresh. When I dynamically add an item (not using the add method as I have a very large and complex object to add) all other pages are lost. I've tried all combinations of .reIndex() and .update() but nothing works. Currently I think I'll have to abandon pagination which is a shame. Great otherwise, thanks

Is there any update on this issue? I have the same problem when I use the remove method.


Fix scripts after common slim

Update secret backend change script
Update preview script

This fixes at least some of the current brokenness. Merging this to main until we tackle the other corner cases


Navigation between memories | chat feels buggy sometimes

Navigation in some pages overall feels like this
Can we profile this with android or xcode profilers, and decrease it as much as we can?
I have a hunch we have a lot of unneeded ui refreshes.

also, this ?

also, this ?

Yes sir

should we close this ? pls mention the related PR sir

should we close this ? pls mention the related PR sir

This one sir #1021

do smth like this, next time ;)


When integration with vim, how to specify command in biblatex format? Thanks!

When integration with vim, how to specify command in biblatex format? Thanks!
https://retorque.re/zotero-better-bibtex/citing/cayw/#diy

I get it, something like let format = &filetype =~ '.*tex' ? 'biblatex&command=parencite' : 'pandoc'
Thanks!

I need to sit down and fix that bot, sorry about the noise. I don't actually know how the vim integration works (I'm an avid vim user, but the macro language is deep, scary voodoo), I just provide the backend.


fix(deps): move lodash to dependencies

Since we utilize lodash in our source code, lodash should be listed in dependencies instead of devDependencies.

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           17        17
  Branches         3         3
=========================================
  Hits            17        17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7adfa...29fde96. Read the comment docs.

Thanks!


Play mp3 livestream

I'd like to play a mp3 livestream like
http://mp3.radiobielefeld.c.nmdn.net/ps-radiobielefeld/livestream.mp3
or http://edge.live.mp3.mdn.newmedia.nacamar.net/radiobielefeld/livestream.mp3
but when using play_uri I get no error and the sonos controller says that the track is not encoded right.
I hope that someone can help me.
Greetings,
Sabbertran

Hallo @Sabbertran
Can you please provide a complete minimal code example of the failure?

Hey,
this is the code which gave me the error in the sonos controller:
`#!/usr/bin/env python
from soco import SoCo
import soco
speaker = SoCo('<IP_ADDRESS>')
speaker.play_uri("http://mp3.radiobielefeld.c.nmdn.net/ps-radiobielefeld/livestream.mp3")`

Also, just to clarify, by sonos controller I mean the windows application that comes for any sonos speaker, not SoCo

Ahh. So what you are talking about is that setting a uri like that, produces an error in the Sonos controller. But does is play? Also full text of the error from the controller would be helpful.

No, it doesn't play.
The error message say "Wiedergabe von 'livestream.mp3' nicht möglich - Titel ist nicht korrekt codiert."
which translates to "Playback of 'livestream.mp3' not possible - title is not encoded correctly.".

Hmm, that sounds wierd. Can you try and actually provide it with a title, like so:
speaker.play_uri("http://mp3.radiobielefeld.c.nmdn.net/ps-radiobielefeld/livestream.mp3", title="testtitle")

Still the same error when providing it with a title

I have the same issue.
import soco device = soco.discovery.any_soco() zone = device.group.coordinator zone.play_uri('http://rundfunk.ice.infomaniak.ch/rundfunk-192.mp3', title='Rundfunk FM')

I can confirm this issue and it has also been raise in the SoCo google group (https://groups.google.com/forum/#!topic/python-soco/cktqjwY_8_Q). @DPH has agreed to look into it, so we will see what he comes up with.

have discovered Sonos calls radio stations using a prefix of 'x-rincon-mp3radio://'
So it works if you change http:// to the above.
example:
speaker.play_uri("x-rincon-mp3radio://mp3.radiobielefeld.c.nmdn.net/ps-radiobielefeld/livestream.mp3", title="testtitle")

Cheers Daivd

@KennethNielsen any thoughts is we can do the 'http//:' switch to 'x-rincon-mp3radio://' in SoCo or if it is more complex than that. I can see lots of people hitting this issue so would be nice to automate it as Sonos does when you add a radio station. If not sensible to change automatically then maybe include in documentation. Welcome your thoughts
Cheers David

@DPH No, I think we should do the conversion in the play_uri method. This method has always sort of been a "work around" to provide a more direct route to get to play a uri than to add it first, so I think it should continue to do that i.e. actually playing a uri.
Extra info. After I saw that you solved it in the google group, I also tested it in a m3u type from a secure uri (https) and that works as well. Since it would not be unreasonable to think that maybe a secure uri would be handled differently. But that works as well \o/.
Do you want to make a PR out of it or should I?
Regards Kenneth

@KennethNielsen maybe we need a play_stream which does the conversion and then calls play_uri.
I use play_uri to call local files and would not want that converted eg:
play_uri('x-file-cifs://server/sounds/MyNiceRing.mp3')

also the snapshot class in SoCo uses play_uri to restore whatever uri was playing before.
Maybe play_uri is the raw 'play what it is given', and there are other methods that call play_uri and do appropriate conversion? (e.g. play_stream, play_file etc. Thoughts.
Happy you do a PR as I still have trouble with GitHub but am slowly learning!
Cheers David

@DPH: I actually already implemented a play_stream in a PR, but for a different purpose. In any case, I don't think we need it here. I would simply only convert the URI if it is a http(s) variety, maybe even with a keyword arg to optionally disable the conversion altogether. Something along the lines of:
    def play_uri(self, uri, title='', meta='', convert_internet_uris=True):
        ...
        for prefix in ('http://', 'https://'):
            if uri.startswith(prefix) and convert_internet_uris:
                uri = uri.replace(prefix, 'x-rincon-mp3radio://', count=1)
        ...

What do you think?
BTW. I'd be happy to "tutor" you with regards to making the PR, if you are interested.
PS: The prefix specifically mentions mp3. Has anyone tried this approach with one of the other file formats that Sonos support (AAC or WMA)?

@KennethNielsen: your approach makes good sense.
Looked for AAC / WMA streams to test but hard to find. most seem to use mp3 / m3u.
Also Tune-in which is the main source for Sonos only supports mp3 across all platforms but AAC on its mobile apps! See http://help.tunein.com/customer/portal/articles/944944-what-are-the-preferred-streaming-formats-on-tunein-
I think we are safe to go with this and see if anyone raises problems with other streams.
Thank you for the tutor offer. Would like to do that, but think we should get this one in quickly. What do you think? Will email you separately so I can get my set up right for next one.
Regards David

Thanks for figuring this out, guys.
Looking forward to the update in the new release.


Migrate Specialist Interface to GOVUK Design System

What
Convert the specialist views in Collections Publisher to the Design system.
Why
This will address any accessibility concerns and make the whole app consistent with one design pattern.
Additional Information
We should move things like for like (or as close as possible). Once we have like for like migration, we can iterate on the user journey if needed.
Screenshots
Index

Before
After

New

Before
After

Edit

Before
After

Show (parent)

Before
After

Show (child)

Before
After

Guidance for review
Probably easiest to run it locally and then compare it to the app on integration.
https://trello.com/c/iRM9tUxa/307-convert-remaining-views-in-collections-publisher-to-design-system
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Great work - I've added a few comments

Thanks @DilwoarH . Will action now


Fix #561 NumericEntity used current culture instead of invariant culture to parse State

Proposed change

Fixed bug #561 NumericEntity used current culture instead of invariant culture to parse State
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]
[x] The code compiles without warnings (code quality chek)
[x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

Codecov Report

Merging #564 (d9da2f6) into dev (19c8ee4) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##              dev     #564      +/-   ##
==========================================
- Coverage   62.30%   62.29%   -0.01%
==========================================
  Files         180      181       +1
  Lines        6672     6673       +1
  Branches      932      931       -1
==========================================
  Hits         4157     4157
  Misses       2181     2181
- Partials      334      335       +1

Flag
Coverage Δ

unittests
62.29% <69.23%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...odel/NetDeamon.HassModel/Internal/FormatHelpers.cs
0.00% <0.00%> (ø)

...odel/NetDeamon.HassModel/Entities/NumericEntity.cs
56.25% <56.25%> (ø)

...NetDeamon.HassModel/Entities/NumericEntityState.cs
100.00% <100.00%> (+20.00%)
:arrow_up:

...rc/Daemon/NetDaemon.Daemon/Daemon/NetDaemonHost.cs
55.15% <0.00%> (-0.44%)
:arrow_down:

...nRunner/DaemonRunner/Service/App/DaemonCompiler.cs
75.81% <0.00%> (+0.11%)
:arrow_up:

...mon.HassClient/Internal/Net/WebSocketClientImpl.cs
75.86% <0.00%> (+3.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c8ee4...d9da2f6. Read the comment docs.


Add a polite request to the users to vote for us as a witness, to support SteemProjects

Idea:

Do not display this message to logged users, which are already voting for us
Display a different message to logged users, which already votes for 30 witnesses
Link to statistics of SteemProjects, to show that SteemProjects is actually very useful to new Steemians
Link to voting via SteemConnect (?)

Proposal of message for logged users (via steemconnect), which are not using proxy and which are not voting for our witness:

the plan is to make A/B tests and check which message/style of message is performing better.


Ballista: Executor must return statistics in CompletedTask / CompletedJob

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We cannot fix the shuffle mechanism until we have partition stats, or ShuffleReaderExec will attempt to read empty partitions, causing an error.
Describe the solution you'd like
Scheduler should receive partition stats and only try and read from non-empty shuffle partitions.
Describe alternatives you've considered
As a workaround we could write empty shuffle files for empty partitions.
Additional context
None

I can work on this improvement.

Other improvement I can think of is if the shuffle data was colocated on the same host with the shuffle reader, we should allow the reader to read from disk directly(LocalShuffle Reader) instead of reading from remote Rpc.

@metesynnada @andygrove
Sorry, I do not get a chance to look into this. Regarding the issue, I'm not sure we would like to fix it in this way. In my opinion, even read empty partitions, ShuffleReaderExec should not return Error or cause any data quality issue.
We will do some test and see what the specific error it is.
@yahoNanJing

Let the CompletedTask return the partition stats is quite heavy.  Imaging we have 1000 map tasks and 1000 reduce tasks(partition = 1000), the stats will become 1M.

@thinkharderdev

I update the tpch-q3 to test, intend to use o_shippriority = 'none' to produce this
select
    l_orderkey,
    sum(l_extendedprice * (1 - l_discount)) as revenue,
    o_orderdate,
    o_shippriority
from
    customer,
    orders,
    lineitem
where
        c_mktsegment = 'BUILDING'
  and c_custkey = o_custkey
  and l_orderkey = o_orderkey
  and o_orderdate < date '1995-03-15'
  and o_shippriority = 'none'
group by
    l_orderkey,
    o_orderdate,
    o_shippriority
order by
    revenue desc,
    o_orderdate;
0 rows in set. Query took 11.347 seconds.

@andygrove how could you produce this error?


GH-79 Copy and delete performance

Description
Copy & Delete now return a specific status code based on resulting state:

204 if the operation is complete
206 if there is more to process.

Copy operation remaining keys are stored in KV, subsequent calls for that operation w/ continuation token will use the remaining list, updating KV as necessary if more remain.
Delete operation can simply be called again and again until a 204 response is returned.
Related Issue
Fixes #79
How Has This Been Tested?
Added unit tests, also added functional/integration test as expected by browser.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Just wondering is there anything stopping us from merging this?


Remove @ToBeFixedForConfigurationCache from MavenPublishDependenciesIntegTest

By avoiding the resolution of the api configuration during configuration caching, which is accomplished via the replacement of compileJava.classpath.

@bot-gradle test ACC

OK, I've already triggered the following builds for you:

AllConfigCacheTestsPullRequestFeedback build


pull request for e2e test at 12/04/2016 12:26:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add save to yaml interface for training_config

save training config to yaml

Codecov Report

Merging #582 (3f3cb2c) into training (9493738) will increase coverage by 0.06%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##           training     #582      +/-   ##
============================================
+ Coverage     59.83%   59.90%   +0.06%
============================================
  Files           152      152
  Lines          6058     6070      +12
  Branches        869      870       +1
============================================
+ Hits           3625     3636      +11
  Misses         2206     2206
- Partials        227      228       +1

Impacted Files
Coverage Δ

towhee/trainer/training_config.py
88.20% <87.50%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9493738...3f3cb2c. Read the comment docs.

/approve


Enable HelliumLogger to print to TextOutputStream, in addition to the ability to print to terminal

The swift print function that prints to the output stream is a generic one.
public func print<Target : TextOutputStream>(_ items: Any..., separator: String = default, terminator: String = default, to output: inout Target)
Currently, due to this Apple's issue, it is not possible to pass to print a variable of type TextOutputStream, it should be a variable of a class that implements TextOutputStream.
To enable HeliumLogger to print to a text output stream, it should be a generic class, which is incompatible with the current implementation. So the solution is to make HeliumLogger open class with open function doPrint to enable subclassing HeliumLogger.


Use tailwindcss

TL;DR
Set up and start using tailwindcss as UI framework.
The long version
So far, we had not decided which UI/CSS approach/toolkit use in the React branch. Instead, apart from those experiments to test how to offer dynamic layouts, we were just adding rough CSS rules in plain *.css files.
It's not an easy decision to choose among so many (fun and great) ways to build the user interface in the Web development world. Styled components? emotion? goober? css-modules? stylable? whatever other CSS in JS library?
Honestly, I haven't had the opportunity to work with any of those libraries to have enough knowledge and choose the right one for this project.
But the time has arrived and we must stop just prototyping and start working with a reliable UI toolkit. And that's why I think that the simple and straightforward could continue using plain CSS, but using the well known utility-first framework tailwindcss.
To not extend too much this (already long) PR description, let me use a couple of links to justify the chose

https://tailwindcss.com/#what-is-tailwind

https://tailwindcss.com/docs/utility-first/#app

Now I know what you're thinking, "this is an atrocity, what a horrible mess!" and you're right, it's kind of ugly. In fact it's just about impossible to think this is a good idea the first time you see it — you have to actually try it.

https://www.smashingmagazine.com/2020/02/tailwindcss-react-project/

Further readings (long and a bit old articles)

https://frontstuff.io/in-defense-of-utility-first-css
https://adamwathan.me/css-utility-classes-and-separation-of-concerns/ (a very long and old one)

Thus,
this PR set up and start using tailwindcss by styling the login form. For sure, I've tried to follow its core concepts (i.e., respecting the mobile-first breakpoint system), but there is room yet to still applying their recommended best practices (i.e., removes not use colors, removes not needed breakpoints, etc).
Thoughts?
Does it look good as starting point for you? Or maybe are you thinking that it's just tomorrow's Bootstrap?
Screenshots

Click to show/hide screenshots

Classic theme

Portrait
Landscape

Green theme

Portrait
Landscape

Resources
Apart from its really nice documentation

https://tailwindcss.com/docs

there are plenty of resources for/around tailwindcss

https://tailwindcss.com/resources
https://github.com/aniftyco/awesome-tailwindcss
:tv: https://www.youtube.com/watch?v=nqNIy8HkEQ8 - Tailwind CSS Tips, Tricks & Best Practices
...

This pull request is my first contact with tailwindcss... and also with styled components, with emotion, with goober and all the other technologies you named. I fully trust your criteria regarding that choice.

@ancorgs

I fully trust your criteria regarding that choice.

Thank you so much, but take into account what I said

I haven't had the opportunity to work with any of those libraries

It's true that I usually read a lot and tried to follow what is being cooked in the web development world, but nothing more. At this time it could be said that I'm disconnected from that area ;)


Model object has no attribute '_is_compiled'

I am working on a linux server with the adapt package version 0.4.4. If I run an example for the feature_based models  DANN, DeepCoral, WDGRL, CDAN, MCD, MDD, and CCSA I always get this error:
AttributeError: 'DeepCORAL' object has no attribute '_is_compiled'. Did you mean: '_jit_compile'?
Do you know how I can solve this?
Thank you so much!

Identical to issue 124


Runtime error during normalization

Thank you for your awesome work! I'm quite interested in plugging in my posenet model as source for your model. However ...
Thanks for your interest in our research!
If you have problems running our code, please include

Your operating system
Ubuntu 16.04 LTS
Your tensorflow version
1.12.
Your python version
3.5.2
The stack trace of the error that you see

The command I run is
python src/predict_3dpose.py --camera_frame --residual --batch_norm --dropout 0.5 --max_norm --evaluateActionWise --use_sh --epochs 200 --sample --load 4874200
The code runs fine until I get the following stack trace:
/home/thomas/una-dinosauria/src/data_utils.py:462: FutureWarning: arrays to stack must be passed as a "sequence" type such as list or tuple. Support for non-sequence iterables such as generators is deprecated as of NumPy 1.16 and will raise an error in the future.
  complete_train = copy.deepcopy( np.vstack( train_set.values() ))
Traceback (most recent call last):
  File "src/predict_3dpose.py", line 537, in <module>
    tf.app.run()
  File "/home/thomas/una-dinosauria/venv/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 125, in run
    _sys.exit(main(argv))
  File "src/predict_3dpose.py", line 532, in main
    sample()
  File "src/predict_3dpose.py", line 411, in sample
    actions, FLAGS.data_dir, FLAGS.camera_frame, rcams, FLAGS.predict_14 )
  File "/home/thomas/una-dinosauria/src/data_utils.py", line 462, in read_3d_data
    complete_train = copy.deepcopy( np.vstack( train_set.values() ))
  File "/home/thomas/una-dinosauria/venv/lib/python3.5/site-packages/numpy/core/shape_base.py", line 283, in vstack
    return _nx.concatenate([atleast_2d(_m) for _m in tup], 0)
MemoryError

Also, I'm using numpy 1.16.1. The VM i run has 4Gb ram allocated.
I changed the line
462   complete_train = copy.deepcopy( np.vstack( train_set.values() ))
to   complete_train = copy.deepcopy( np.vstack( list(train_set.values()) ))

because this is what I understood numpy version > 1.16 wants, but the error remained about the same.
So, I'm a little lost here. Can anyone reproduce the problem?
This is research code, and its primary purpose is to reproduce the scientific results that you see in our paper.

Wow, this was just caused by a lack of RAM allocated. I increased the RAM size to 6Gb and the demo works now.


ARROW-2118: [C++] Fix misleading error when memory mapping a zero-length file

This was causing an unintuitive error to bubble up when reading a malformed, zero-length Parquet file. To improve the actual Parquet error message, we must complete PARQUET-1243

Appveyor build here https://ci.appveyor.com/project/wesm/arrow/build/1.0.1763

+1


FIX: Allow user to direct message themself again and fix DM inconsistencies

At some time in the past few months (possibly #758)
the ability for users to create a new DM channel with themselves
was broken. There was inconsistency around the
chat direct message controller sometimes accepting
an array of usernames and sometimes accepting
a comma separated string of usernames. They are
both needed - the former for POST and the latter
for GET. The test for POST in ruby did not pass the
usernames as an array so it was not catching the
error which was preventing the creation of the channel,
which was caused by a duplication of the current user
in the users array.
This commit also splits the create! method argument
for DirectMessageChannelCreator into acting_user/
target_user arguments, which will make it easier to
add mute/ignore checks involving the user creating
the message and who they are targeting. It also addresses
some inconsistencies with how the usernames are passed
to the controller from JS, and adds missing specs
for DirectMessageChannelCreator

Failing test is unrelated

@nattsw removed acting_user, kept target_users though since it is used and will make the next PR easier.


fix: Refactor deployed config caching

mostly a code cleanup (i.e. removed explicit chunking as SDK handles it)
lots of logs switched to debug-level (configure level in config yaml!, the --debug flag is not working)
cleaned up dry-run logging and potentially fixed issues with delete and prepare command
new CogniteResourceCache and CogniteDeployedCache to track deployed CDF resources

looks now like an overkill to replace the -- sometimes buggy -- time.sleep() and reload from CDF

no feature changes so next version is v2.0.3
and finally made the --debug flag working, which now can overwrite an INFO log-level for files and console in config-yaml

don't use it regularly as it logs a lot of groups and datasets details

closed #47


Move custom start button text to StartNodePresenter

This moves the custom start button text from StartButton to the ERB templates for the Smart Answer start pages. This allows us to access the custom start button text from the StartNodePresenter which will make it possible to send this content to the Publishing API as part of PR #3126.
Note that calculate-your-child-maintenance is the only Smart Answer that has custom start button  text at the moment.
https://trello.com/c/arlZczQO/423-2-republish-smart-answer-part-year-profits-to-finalise-your-tax-credits-start-page-as-a-transaction-page

Thanks, @chao-xian! I'll get it merged.


Update airflow chart denpency to latest chart version

Hi,
it seems that there is currently an issue with the used airflow version 2.5.3 (marked as dependency in the openmetadata-dependency chart).
https://github.com/apache/airflow/issues/29112
The latest airflow community-chart is 8.8.0 with airflow version 2.6.3 - would it be possible to update this?
Cheers,
@cberge908

Closing this as it seemed to be released in chart v1.1.12


Change dotnet core windows server hosting requirement to the LTS version

Going to close this PR since we will integrate everything from the OutSystems installer fork


feat(dsb-client-gateway-api): pending ack for search

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Branch initialization stuck with INSTALL_REFERRER_FETCH_WAIT_LOCK

It might be related only to the particular integration I'm doing but the call sequence looks legit so it feels like an issue.
Basically I found that Branch SDK calls stuck when app is installed from Play Store or using adb install with following adb shell am broadcast -a com.android.vending.INSTALL_REFERRER -n <package_name>/io.branch.referral.InstallListener --es referrer "test_referrer=test" command.
The locking sequence is following:
request.addProcessWaitLock(ServerRequest.PROCESS_WAIT_LOCK.INSTALL_REFERRER_FETCH_WAIT_LOCK); at Branch.java:2316
InstallListener.captureInstallReferrer(playStoreReferrerFetchTime, this); at Branch.java:2317
reportInstallReferrer(); at InstallListener.java:40
callback_.onInstallReferrerEventsFinished(); at InstallListener.java:114
requestQueue_.unlockProcessWait(ServerRequest.PROCESS_WAIT_LOCK.INSTALL_REFERRER_FETCH_WAIT_LOCK); at Branch.java:1530
for (ServerRequest req : queue) at ServerRequestQueue.java:372

i.e. in the first line code sets lock on current request and tries to remove it (synchronously in my case) in the last line, but, unfortunately the call itself is not in the queue yet so stays locked forever.

@mikhailmelnik We have seen a corner case causing this particular issue  when there is no internet connection at the time of install. We have fixed this issue in v2.14.5. Can you please make sure you are using v2.14.5 or above

@sojanpr here is exact line from my gradle file implementation('io.branch.sdk.android:library:2.14.5') { exclude module: 'answers-shim' } and during debugging session (as well as when I was installing app from Play Store) device was always online.

@mikhailmelnik Thanks for the update . Is this happening on a second init using se force_branch session call? Can you please  provide the steps if you do initilaise Branch in a custom way

@sojanpr I can't check it right now but from what I remember it happens only on the first app launch.
I'm using Branch SDK the following way:
Application.onCreate:
        Branch.enableLogging();
        // Branch.setPlayStoreReferrerCheckTimeout(0);  <-- this is workaround
        Branch.getAutoInstance(application);

and then in the custom callback (which occurs when required part of the app is ready, so a few activities might be shown during this time, or none when app launch is initiated by adb shell ... command):
Branch.getInstance().setIdentity(CUSTOM_IDENTITY, (referringParams, error) -> {
    // code which is never called under mentioned conditions
}

@mikhailmelnik  I could reproduce this issue with some other steps. Working on a fix and update you soon. Thanks for brining it to attention

@mikhailmelnik Opened a new PR for fixing this issue. https://github.com/BranchMetrics/android-branch-deep-linking/pull/548. Really appreciate if you can review it.

@mikhailmelnik Fix is released with v2.15.1. Can you please try this version

@sojanpr sorry for delay with reply, was offline whole day. I had checked PR (don't know internals but change looks reasonable) and tested the new version. Can't say for sure how it will behave in production but it works well in my synthetic test.
I've noticed one more thing in the logcat after upgrade, even after Invalidate caches/restart, not sure about the reason and how critical it is:
I/art: Rejecting re-init on previously-failed class java.lang.Class<io.branch.referral.InstallListener$ReferrerClientWrapper$1>
I/art: Rejecting re-init on previously-failed class java.lang.Class<io.branch.referral.InstallListener$ReferrerClientWrapper$1>

@mikhailmelnik Thanks for testing and updating.
The log in the above comment is caused by an optional dependency. It is only a warning depend ending on your config. Here is more notes on it. https://github.com/BranchMetrics/android-branch-deep-linking#proguard-warning-or-errors-with-appindexing-module.
Thanks

@sojanpr the link you've mentioned is about Proguard warning while I see these log entries in logcat on the app's startup.
If I understand it correctly the runtime engine can't load io.branch.referral.InstallListener$ReferrerClientWrapper$1 class but there is no such class at all. I've compared the source code with the decompiled one from the release build with disabled Proguard and can't find any difference or trace of what might be an inner class in this case.

@mikhailmelnik Thanks for the details. We are looking into it.
Could you please check if your app  has a dependency on 'com.android.installreferrer:installreferrer:1.0' or above. We use this as an optional dependency for getting install referrer
https://github.com/BranchMetrics/android-branch-deep-linking/blob/master/Branch-SDK/src/io/branch/referral/InstallListener.java#L92

@sojanpr no, there is no such dependency in the project. Should it be added? Could you please point me to the related article if any?

@mikhailmelnik it is an optional dependency. No need  to add it. Wondering if any other dependency your app has already adding it.

@sojanpr just checked the output of .\gradlew.bat app:dependencies and there is no such dependency in the whole project.

@mikhailmelnik  thanks for checking it. Trying to reproduce the issue and get back to you soon

@mikhailmelnik
Since it looks  like Dalvik is trying to load a non-added dependency, could you please help with the following

Disable Instant run and try again (Doesn't make much sense to me either but there was an bug causing this in IR)
Add pro-guard since proguard will strip of the non included dependencies from JAR.

If none of the above work can you please update and try this work around until we  have the real issue fixed

add dependency 'com.android.installreferrer:installreferrer:1.0'

@sojanpr the strange thing is I've tried both enabled and disabled proguard and it didn't make any difference. Also all of the experiments were taken on the result of .\gradlew.bat installRelease after full cleanup and cache invalidation so I'm pretty sure it is not the Instant Run issue.
Suggested workaround with optional dependency removed these messages but what does it actually do?

@mikhailmelnik Thanks for trying it. The optional  dependency is to support more accurate install attribution using google play install referrer  library


Clarify startup class selection

It was not clear how the two ways of specifying the startup
class differed.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@samiraguiar Awesome work! Your change will be live within the next 24 hours.


phrase_prefix match on random value causes slow querys and spike memory usage

Describe the bug
A clear and concise description of what the bug is.
Steps to reproduce (if applicable)
Steps to reproduce the behavior:
Example Request

[!CAUTION]
The index pattern in the request expands to 4 indexes and contains 3,869,958,639 documents in total

/api/v1/_elastic/logline.996226df4b.2024-06-03*,logline.996226df4b.2024-06-04*/_search
{
  "size": 0,
  "query": {
    "bool": {
      "must": [
        {
          "multi_match": {
            "type": "phrase_prefix",
            "query": "6c59f652-f1f5-11ee-86b2-562c83a610e2",
            "fields": [
              "_line"
            ],
            "lenient": true
          }
        }
      ]
    }
  }
}

[!NOTE]
It seems like its the length of the query we're trying to match here, if I shorten the search query, it'll finish but the time increases
the longer it gets

6c59f652 - 19556 ms
6c59f652-f1f5-11ee - 32743 ms
6c59f652-f1f5-11ee-86b2-562c83a610e2 - Did not finish

The memory usage spikes above defined memory limits (4gb), and the longer running queries take long enough that kubernetes OOMKiller is prompted to terminate the pod running the query.
In comparison to the timings presented by elasticsearch on a near identical data set

6c59f652 5277 ms
6c59f652-f1f5-11ee - 3378 ms
6c59f652-f1f5-11ee-86b2-562c83a610e2 - 5365 ms

Example Document
{
  "__key": "logline:996226df4b:webapp:ldw-5c4b45dd7d-w94fv:ld11",
  "_account": "996226df4b",
  "_app": "webapp",
  "_bid": "34c1c7cb-e8c4-4190-afcc-5c2591384b7e:31899:ld11",
  "_cluster": "ld11",
  "_file": "/var/log/containers/ldw-5c4b45dd7d-w94fv_default_webapp-0fe267d84862d915a960d4159a47f52d560b4dfd072a1b6d4691c3979a5c3369.log",
  "_host": "ldw-5c4b45dd7d-w94fv",
  "_id": "1751243621446717490",
  "_ingester": "logdna-agent/3.10.0-beta.1 (Amazon,Linux/2)",
  "_ip": "***REDACTED***",
  "_label": {
    "app": "ldw",
    "pod-template-hash": "5c4b45dd7d"
  },
  "_lid": "1751243621446717490",
  "_line": "[240604 19:23:32] [info] {\"message\":\"Proxy request from 2a6204e8c7 to /v3/pipeline/6c59f652-f1f5-11ee-86b2-562c83a610e2\",\"meta\":{\"stack\":[\"at ProxyServer.<anonymous> (/opt/app/server/config/proxies/proxy.js:15:12)\",\"at ProxyServer.emit (/opt/app/node_modules/eventemitter3/index.js:210:27)\",\"at ClientRequest.<anonymous> (/opt/app/node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js:133:16)\",\"at ClientRequest.emit (node:events:519:28)\",\"at ClientRequest.emit (node:domain:488:12)\",\"at tickOnSocket (node:_http_client:839:7)\",\"at onSocketNT (node:_http_client:902:5)\",\"at process.processTicksAndRejections (node:internal/process/task_queues:83:21)\"],\"version\":\"8.5.108\",\"commit\":\"32c4bf268d\"}}",
  "_logtype": "json",
  "_meta": {
    "Image Name": "us.gcr.io/logdna-k8s/logdna-web",
    "Tag": "8.5.108"
  },
  "_mezmo_line_size": "1305",
  "_originating_user_agent": null,
  "_tag": [
    "agent-v2",
    "prod",
    "us-east-1",
    "aws"
  ],
  "_ts":<PHONE_NUMBER>835,
  "container": "webapp",
  "containerid": "0fe267d84862d915a960d4159a47f52d560b4dfd072a1b6d4691c3979a5c3369",
  "level": "info",
  "message": "Proxy request from 2a6204e8c7 to /v3/pipeline/6c59f652-f1f5-11ee-86b2-562c83a610e2",
  "namespace": "default",
  "node": "***REDACTED***",
  "o_meta": {
    "commit": "32c4bf268d",
    "stack": [
      "at ProxyServer.<anonymous> (/opt/app/server/config/proxies/proxy.js:15:12)",
      "at ProxyServer.emit (/opt/app/node_modules/eventemitter3/index.js:210:27)",
      "at ClientRequest.<anonymous> (/opt/app/node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js:133:16)",
      "at ClientRequest.emit (node:events:519:28)",
      "at ClientRequest.emit (node:domain:488:12)",
      "at tickOnSocket (node:_http_client:839:7)",
      "at onSocketNT (node:_http_client:902:5)",
      "at process.processTicksAndRejections (node:internal/process/task_queues:83:21)"
    ],
    "version": "8.5.108"
  },
  "pod": "ldw-5c4b45dd7d-w94fv"
}

Expected behavior
I would generally expect memory to remain under control, and/or be released after the query completes.. There don't seem to be any settings to help control memory. We have strict limits on memory for quickwit running on kubernetes, But quickwit itself seems to have an unbounded memory usage cap internally (or a leak).

Every time this query is run, memory makes a significant jump and never seems to come down.
Additionally, query times are very slow for this kind of query and fail to complete in a reasonable amount of time (10-30seconds).
Configuration:

Output of quickwit --version

Quickwit 0.8.0 (aarch64-unknown-linux-gnu 2024-06-04T12:57:54Z 67a798d)

The index_config.yaml

version: '0.8'
# metastore_uri: postgres connection string generated by postgres operator
default_index_root_uri: s3://***REDACTED***/indexes
searcher:
  fast_field_cache_capacity: 2G # default 1G
  aggregation_memory_limit: 500M # default 500M
  partial_request_cache_capacity: 64M # default 64M
  max_num_concurrent_split_searches: 100 # default 100
  split_cache:
    max_num_bytes: 2000G
    max_num_splits: 1000000
    num_concurrent_downloads: 4
indexer:
  enable_cooperative_indexing: true
  enable_otlp_endpoint: true
  cpu_capacity: 1000m
ingest_api:
  max_queue_disk_usage: 4GiB
storage:
  s3:
    region: us-east-1
    endpoint: https://s3.amazonaws.com

@esatterwhite  can you check how quickwit behaves on this if it was a simple phrase query?
@trinity-1686a can you investigate?

@trinity-1686a
https://github.com/quickwit-oss/tantivy/pull/2425/files
Here are two optimization. The removal of the allocation at each match is probably important for this specific query.
The other one much less.

some of the tokens composing the uuid appear frequently (~150m times) other appear only around 1k time. There is probably some improvement to do on how we do the intersection of terms

Next steps:

ask if regular phrase query are faster.
ask eric if the recent image are faster. (they included #2425)
integrate the optim introduced in #2425. At the very least remove the allocation per doc.

Consider using emitting a PhraseScorer when we detect there is only one term detected in the Weight.

this was diagnosed to happen because the code tokenizer doesn't like hex much, and given 6c59f652-f1f5-11ee-86b2-562c83a610e2 would generate [6, c, 59, f, 652, f, 1, f, 5, 11, ee, 86, b, 2, 562, c, 83, a, 610, e, 2] which contains a lot of token, many of which are likely present in tons of documents (the 1-2 bytes ones)

fixed by #5200


Set time and date automatically

Hey,
I'm not sure how this is helpful. It's just another data point for Apple, since your computer will be periodically talking to them. It sounds the opposite of reducing attack surface. What am I missing here?
(Love osxlockdown, though. Thanks a bunch!)

Already discussed at https://github.com/SummitRoute/osxlockdown/issues/18
He just forgot to replace “Set” by “Disabling” : https://github.com/SummitRoute/osxlockdown/commit/54c095ac318fd50d5aa3fb92711d98c962981207 ;)

Oh, I tried finding past issues mentioning this and got nothing. Good to know @pwnsdx, thanks! (I'll actually do the PR for that.)


disableGlobbing option: treat glob-like paths as literal paths

As discussed with @es128 at https://github.com/paulmillr/chokidar/issues/300.
Naming options is always tricky, so shout if you have a better suggestion than ignoreGlobs.
If you're happy with the code, I'll update the docs.

Coverage increased (+0.01%) to 98.405% when pulling c052b752e14063fbc3f92aca61522a406569ae44 on octachrome:master into d90d112797206e60236d723693965ff155c6cd1f on paulmillr:master.

Cool, I'm glad the easy approach seems to work out. Thanks for the PR.
As for the option name, I don't think ignoreGlobs is very clear about the intent. Perhaps disableGlobbing?
Also, if you don't mind, can we add tests showing this working on an individual file, as well as showing that other files that would match the glob pattern (if it were being treated as such) do not get watched.

Coverage increased (+0.04%) to 98.429% when pulling a94defbe5544928dd82f0f806d004becbd226044 on octachrome:master into d90d112797206e60236d723693965ff155c6cd1f on paulmillr:master.

@es128 I added some more tests - do they address your concerns?

Yes. Thank you, great work!

Would I be right in saying that this ignoreGlobs option affects the watcher path only and not any filepaths passed to the ignored option?
I can't seem to get something like this to work - tried with relative and absolte pathing. It always picks up the changes!
Chokidar.watch("../Folder (1)", { disableGlobbing: true, ignored: "bin", ignoreInitial: true, depth: 5 }).on('all', function (event, path) {
    console.log(event);
    console.log(path);
}).on('error', function (error) {
    console.log(error);
});

@DaleMckeown The docs for ignored say "The whole relative or absolute path is tested, not just filename". So you need to use a regex. If you want to ignore files in any subdirectory named bin:
ignored: /\/bin\//,

Or if you only want to ignore files in a directory named bin in your root directory:
ignored: /^\.\.\/Folder \(1\)\/bin\//,

@octachrome Ah, thanks! I'll take a look and see if I can get that working tomorrow.


File indicating version does not exist when installing from pypi

File indicating version number is in all caps while the file listed in the setup.py file is all lowercase.  As a result, it's not installing properly from PyPI.  Package installation from github works though.  PyPI distribution should be updated

Hi @jkartzman thanks for bringing this to my attention. I have pushed the latest version to 1.2.0, it should contain the lower case version file. Let me know if it works and I'll close the issue :)

Works great now!


Telegram

Checklist

[ x] I'm reporting a new site support request
[ x] I've verified that I'm running youtube-dl version 2021.04.07
[ x] I've checked that all provided URLs are alive and playable in a browser
[ x] I've checked that none of provided URLs violate any copyrights
[ x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://t.me/r_Damnthatsinteresting/23326
Channel https://t.me/s/r_Damnthatsinteresting

Description

Requesting support for native Telegram videos. Channels can be displayed in browser, groups cannot but being able to crawl all of the videos uploaded on a channel (instead of using Telegram's export tool which kindof blows) would be pretty sweet.

Bro there is like no way I can find to do this online :'( wtf. I don't want to have to forward a link to a bot that's insane I just want to download the url directly..

https://github.com/ytdl-org/youtube-dl/issues/23376

@mayeaux please provide example link

@mayeaux please provide example link

https://t.me/disclosetv/5934

With all due respect, I am not helping anyone to get that bullshit. If you have another video thats not someone spreading conspiracy theories, I am glad to help.

 If you have another video thats not someone spreading conspiracy theories, I am glad to help.

https://t.me/disclosetv/5947

Related: https://github.com/yt-dlp/yt-dlp/issues/2910


Track listing in MiniPlayer doesn't size properly

The issues is most easily observable by seeing that the scrollbar is screwed up when the list continues off the end of the scree.

Seems like a DOM update problem: Resizing the window doesn't always cause the DOM to recalculate dimensions :/

Seems like a DOM update problem: Resizing the window doesn't always cause the DOM to recalculate dimensions :/

Looks like an issue with DetailsList from FluentUI :/

Yup. Maybe I'll eventually make my own scrollable virtual list...


Support for MapReduce function parameters in Java Client

The Java Client doesn't currently expose any way to include parameters to for
functions in MapReduce queries.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 16 Dec 2010 at 10:19

Original comment by<EMAIL_ADDRESS>on 29 Dec 2010 at 10:05

Changed state: Accepted

I'm aiming to finish it for this weekend - it's a really small thing.

Original comment by<EMAIL_ADDRESS>on 29 Dec 2010 at 2:34

Sven, did you actually start working on this? Any estimates?

Original comment by<EMAIL_ADDRESS>on 29 Dec 2010 at 2:28

What is missing exactly? The MapReduce.Task has had a parameters-member/method
since the initial commit?

Original comment by<EMAIL_ADDRESS>on 2 Jan 2011 at 1:20

You're right, my fault: if it works as expected, feel free to close the issue
as "won't fix".

Original comment by<EMAIL_ADDRESS>on 3 Jan 2011 at 7:33

Original comment by<EMAIL_ADDRESS>on 29 Dec 2010 at 2:37

Changed state: Started

Non-issue. Already implemented.

Original comment by<EMAIL_ADDRESS>on 3 Jan 2011 at 8:54

Changed state: WontFix


[WIP, ENH, VIZ]: Refactor _figure.py-classes to prepare alternative backend

Abstract
This PR is supposed to refactor all methods and attributes from the Classes associated with the current implementation of 2D-Data-Visualization (mainly MNEBrowserFigure) into a new parent class called MNEDataBrowser. This should make the addition of a new implementation based on pyqtgraph (currently developed here more feasible. It will contain all visualization-independent steps of the preparation of data. Furthermore the aim is to let both backends use similar data-structures to store gui-elements like Annotations, Event-Lines, etc. ... . And some backend-independent GUI-Methods could be outlined as abstractmethods.
ToDo

[X] Create MNEDataBrowser
[X] Move MNEBrowserFigure-Initialization to MNEDataBrowser
[X] Extract GUI-independent methods from MNEBrowserFigure
[X] Refactored DataIO
[X] use/set/get for browser-backend
[ ] Refactor Tests

I would make this first PR just the first three points above, and stop before "Adapt PyQtGraph". I think refactoring the existing classes into a data class and matplotilb subclass is a good first PR.
There is a separate also difficult question about how we want to refactor tests. Ideally some or all of the existing raw and epochs data browsing tests would work on the new backend. So maybe an additional bullet point that could be part of this first PR would be to make it so that the matplotlib-specific stuff in the tests is also separated out in some way.
In 3D we do this by having a _renderer abstraction, and things like _renderer._close_all() exist that close all Mayavi or PyVista figures, for example. And then there is a pytest fixture that yields both a Mayavi and Pyvista backend that can be used in the tests. I'm not sure if we want to copy this verbatim but it is something to think about. See for example here:

renderer fixture itself, which parametrizes over backend: https://github.com/mne-tools/mne-python/blob/main/mne/conftest.py#L290-L294
renderer fixture use: https://github.com/mne-tools/mne-python/blob/main/mne/viz/tests/test_3d.py#L168-L201

I think it seems reasonable to add a browse_backend fixture or something that in this first PR just (trivially) parametrizes over ['matplotlib'], and then in the next PR that actually adds pyqtgraph support it adds 'pyqtgraph' to its list of params.

... don't worry about this too much for now (unless you want to!), as we can discuss this more in depth on Thursday. In the meantime you can keep working toward the first two points above in this PR for the next couple of days probably!

@larsoner Thank you for your suggestions. As you say, an abstraction would be helpful to avoid having to switch between cases for every part in the tests which is matplotlib-specific (accessing axes, simulate clicking, pyplot-functions). Maybe I can have methods for those cases in BrowserBase (or what we plan to call it).
I saw that for PyQt-testing there are fixtures from pytest-qt which help with creating the application-context and widget-interaction. Would you combine a possible browse_backend-fixture with pytest-qt?
As you suggest I will continue with the abstraction of BrowserBase first, but I hope I can get to the tests too soon.
P.S. Please don't worry about the preliminary integration of pyqtgraph in _get_browser. I added this just to try some things out already with the PyQtGraph-Prototype, because that helps me think about which parts of BaseBrowser can be used by both backends. I will remove this part again for the final PR.

I saw that for PyQt-testing there are fixtures from pytest-qt which help with creating the application-context and widget-interaction. Would you combine a possible browse_backend-fixture with pytest-qt?

Yes, we'll probably need this to simulate mouse clicks (which we currently already do for our MPL-based window with _fake_click()).

I have a question about the browser(backend)-fixture:
As I understand the renderer-fixture yields the entire renderer-object depending on the current backend-parameter.
In most of the tests in test_raw.py the figure-object is got from raw.plot(). In some cases there are parameters added to raw.plot() if required for the test. If I would want to have one browser-fixture, I would need a way to pass arguments to raw.plot() inside the fixture (this is probably not the way fixtures are supposed to be used) or I would need a fixture for every use-case (which is probably also bad). Or is there another way?
If not, maybe a browser_backend-fixture just parametrizes the backend-names and returns the string to be then passed into raw.plot(). For that I would have to change the API of raw.plot() already by adding the browser_backend-parameter.
WDYT?

If not, maybe a browser_backend-fixture just parametrizes the backend-names and returns the string to be then passed into raw.plot(). For that I would have to change the API of raw.plot() already by adding the browser_backend-parameter.

This is close to what I had in mind. I think eventually we'll probably want a mne.viz.set_browse_backend / mne.viz.use_browse_backend / mne.viz.get_browse_backend like we have mne.viz.set_3d_backend et al. So I think the browser_backend fixture can be structured roughly like:
@pytest.fixture
@pytest.parametrize('backend', ('matplotlib',)
def browser_backend(backend):
    with mne.viz.use_browse_backend(backend):
        yield

But we also know that each test now needs an instance of some sort of click-keypress class, so once that refactoring is done this could become:
...
    if backend == 'matplotlib':
        tester = _MatplotlibFakeInteractor()
    # else:
    #    assert backend == 'pyqtgraph'
    #    tester = _PyQtGraphFakeInteractor()
    with mne.viz.use_browse_backend(backend):
        yield tester

and then inside your tests you can have
def plot_raw(browser_backend):
    ...
    fig = raw.plot(...)
    browser_backend._fake_click(fig, ...)

and this _fake_click is a method of _MatplotlibFakeInteractor and "does the right thing" for matplotlib, etc.

Alternatively, if you want to skip the browse_backend stuff for now, you could have the FakeInteractor have a .backend property that is the string, and you'd call in every test:
raw.plot(..., backend=backend)

but this set/use/get pattern is pretty nice.

@larsoner Thank you, I see. So you would rather have use/set/get than an additional parameter? Or both?

I also thought I maybe could put the fake-interactions as abstract-methods into BrowserBase and have the backend-specific code inside the backend-classes to have it all together. Then interactions inside the tests could be done with methods from the figure/pyqt-object (and it would be accessible by users)
WDYT?

@drammock Thank you for the detailed feedback, I see I have a lot to work on.

instead of keeping MPL-specific stuff in _figure.py and moving backend-agnostic code into _backend, you could (should?) put the MPL-specific code in _mpl_figure.py and use _figure.py for the backend-agnostic stuff (and later, use _pyqtgraph_figure.py for the new backend. That way, what is currently cut-paste would be staying where it is (and changes to it would be easier to see)... the MPL-specific stuff should not be changing much in this PR anyway so having that stuff be the cut-paste part is preferable.

I'll see to that I apply your proposed option 2.

I see why keeping BrowserBase in _figure.py is a huge advantage for reviewing. Just for the more distant future I think it might be clearer with _browser.py to avoid direct association to matplotlib.figure.Figure. But naming these files is something we could change way afterwards, right? So I will do as you propose and but everything new into _figure.py as proposed.

I see why keeping BrowserBase in _figure.py is a huge advantage for reviewing. Just for the more distant future I think it might be clearer with _browser.py to avoid direct association to matplotlib.figure.Figure.

I don't share that worry...  ordinary users won't ever look at _figure.py (only contributors), and presumably anyone wanting to look at it will be able to see that it's not matplotlib-specific.  I'm happy to be outvoted here if others disagree, but let's delay such renaming until the PR is otherwise (nearly) ready to be merged.

Update from today @drammock:
I implemented your feedback and tried to refactor the remaining tests in test_raw.py. I realized that I probably need to start now with the second PR for the integration of the pyqtgraph-backend because in many test-cases I am not sure how this will turn out for the pyqtgraph-backend in the end without having implemented it (since I don't have that much experience with pytest-qt yet).
Or I try to finish this PR with the outlook of probably having to change many tests again when I add the pyqtgraph-backend.
WDYT?
P.S. I know there is still a test failing in test_plot_raw_traces, I had a hard time finding reason because I thought I refactored everything without a change.

I realized that I probably need to start now with the second PR for the integration of the pyqtgraph-backend

I strongly advise to finish this one first.  I know it can be difficult to ignore what you know about PyQtGraph and resist changing things now that you know will need to be changed eventually, but there is a reason we keep recommending you to do it this way.

Or I try to finish this PR with the outlook of probably having to change many tests again when I add the pyqtgraph-backend.

Yes!  It is 100% expected, part of the process, and okay to implement a conceptual split between backend-agnostic code and MPL-specific code, knowing that some of it will have to change very soon.  It is in most cases still easier to do it that way, even though it seems like more work.  And it is definitely less error-prone because (1) there is a defined halfway point where we get to ensure all the tests still pass, and (2) the separate steps are much easier to review, meaning human reviewers are more likely to catch mistakes.

@marsipu I pushed one commit to split the big test_plot_raw_traces into 4 smaller tests, which made it easier to figure out what was going wrong.  I'm not 100% sure why it was happening, but changing the fake-click to be on the second trace (a grad channel) instead of the first one (IAS) was enough to fix it.

Thank you @drammock

@cbrnr and @hoechenberger I leave it to one of you two to push the green button

@cbrnr @hoechenberger Is there still something I can improve?

I didn't have time to review, I'll probably do it tomorrow. Some of the discussions have not been resolved, are these still open issues?

Some of the discussions have not been resolved, are these still open issues?
Thanks for the hint, most of them are already outdated and resolved.

I didn't know that we have mne/conftest.py to define fixtures. I believe that it only makes sense to define fixtures here that are used in several places. It looks like the ones you added are very specific to the browser viz test – would it make sense to move these fixtures closer to where they are needed (i.e. somewhere in mne/viz/tests)?

I didn't know that we have mne/conftest.py to define fixtures. I believe that it only makes sense to define fixtures here that are used in several places. It looks like the ones you added are very specific to the browser viz test – would it make sense to move these fixtures closer to where they are needed (i.e. somewhere in mne/viz/tests)?

The reason I moved the fixtures for the data-import from mne.io.tests.data into conftest.py was that those were partly redundant in test_raw.py, test_epochs.py and test_ica.py.
When searching across mne-python I see, that they could be used in several other tests too, as in test_csp.py, test_montage.py, test_transformer.py, test_csd.py [...].
Maybe this would be something to be resolved from #4926 in another PR?
But I can of course move the fixtures in a separate file in mne.viz.tests if you like that better, should I do that now?

But I can of course move the fixtures in a separate file in mne.viz.tests if you like that better, should I do that now?

I wasn't aware of these fixtures until now, so I'm probably not the best person to decide where they should go. However, I feel like it is not even straightforward to decide if test setup parts should go into a fixture or if they should be defined within the actual test. And if they go into a fixture they can either be defined in a module or more globally in a conftest.py file.
In short, so far I've written my tests to be entirely self-contained, e.g. generating test data directly inside the test function.
What is our recommended best practice for writing tests? I haven't found anything in our docs, and it seems like this is an important topic. On the one hand, fixtures can make tests run much faster, but on the other hand tests are harder to understand with all that fixture magic happening in the background (at least IMO).
This is not really relevant to this PR, so maybe we should discuss it somewhere else. But a quick statement from @drammock, @larsoner or @hoechenberger on how to proceed with the fixtures you added here would be good.

We don't have a strict policy about fixtures. We did have fixtures before, including some in conftest and some defined in the test files they were used in. IMO the changes here are fine. I guess a future PR that describes how to write tests could also add comments to test files explaining where to find the fixtures.

Looks good, I haven't checked the tests though. General comment: please make sure to spell terms such as 2D browser and browser backend without dashes (please check all your changes, I haven't commented on all occurrences).

@hoechenberger if you have time please take a final look and merge if you're happy.

in it goes!  Thanks 1e6 @marsipu


MM-35838/MM-35923 Fix memoization of selectors

Turns out https://github.com/mattermost/mattermost-webapp/pull/8109 caused some issues around memoization since we weren't checking results at the right time. In particular, makeGetChannelIdsForCategory was checking the channels for changes before doing filtering and sorting which caused the results to not be updated when they should've changed because something else (sort order or DM autohiding limits) should've caused their results to change.
getChannelsNameMapInCurrentTeam didn't cause any of these issues, but it was only returning a new result when one of the channels' display names changed. While this seems like it was okay for the cases we used it in, I'd be worried about there being some cause we didn't expect here where it would break. This will result in slightly worse performance of the Markdown component (notably, it'll now re-render again when a post is made because one of the channels it contains had its last_post_at change), but we could make a new selector that just maps names to display names if we think that's an issue. I started doing that, but the code around the channel linking in Markdown is a bit sketchy looking, so I didn't want to risk breaking it if we didn't need it.
Ticket Link
https://mattermost.atlassian.net/browse/MM-35838
https://mattermost.atlassian.net/browse/MM-35923
https://mattermost.atlassian.net/browse/MM-35981
https://mattermost.atlassian.net/browse/MM-35982
https://mattermost.atlassian.net/browse/MM-35983
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/8109
Release Note
NONE

@hmhealey if the changes to getChannelsNameMapInCurrentTeam weren't causing any issues can we leave that as is? The Markdown component re-rendering was a fairly large part of the performance issues that my profiling was showing

@jwilander I'll take another look, but I can't remember if it was actually causing issues or not. The issue would be the same as the channel sidebar one if it did occur, but the nature of the problem makes it difficult to find since the code looks right.
I'll check again to see if it's actually causing an issue at the moment, but if it's not, I could revert the changes I made and cover it with comments explaining the bug instead. I can also look at fixing it in a way that behaves how we want it to.

For cherry-picking to cloud.

/cherry-pick cloud

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
/app/.ssh/config: line 1: Bad configuration option: {message
/app/.ssh/config: terminating, 1 bad configuration options
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch upstream
Fetching origin
/app/.ssh/config: line 1: Bad configuration option: {message
/app/.ssh/config: terminating, 1 bad configuration options
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch origin

+++ Returning you to the master branch and cleaning up.

@hmhealey You can cherry-pick it manually.


Support for set type attributes

Adding support for ASTs with Set type parameters to ASTTransformer would be valuable. For example, have the ability to address the following metamodel (with a Set type parameter) in a transformation.
@dataclass
class Library(Node):
    books: Set["Book"] = field(default_factory=set)

@dataclass
class Book(Node):
    name: str = ""

Thank you fore reporting this @ivan-alfonso !


Error: missing provider provider["registry.terraform.io/hashicorp/aws"].service

Found a bug? Maybe our Slack Community can help.

Describe the Bug
When running terraform plan inside the module, Terraform throws the followiing error:
Error: missing provider provider["registry.terraform.io/hashicorp/aws"].service

Expected Behavior
Terraform should display a summary of the actions it will execute based on the module's inputs.
Steps to Reproduce
Checkout this branch.
Inside the /examples/complete directory run the following:
terraform init

Then run:
terraform plan

The console then throws the following error:
╷
│ Error: missing provider provider["registry.terraform.io/hashicorp/aws"].service
│
│
╵

Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: macOS Big Sur
Version 11.2.3

@mattt-liu this was provider was added to the example in pr https://github.com/cloudposse/terraform-aws-firewall-manager/pull/9. are you still seeing an issue?


Programming Languages - "TypeScript Resources"

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section
Description:
Hey @jfmartinz I have added the typescript resources in programming languages, as your instructed format (Topic Excluded)
please take a look and let me know, hope it helps Thank You!!
Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[X] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[X] I followed the prescribed PR title template. (Check this if you're adding a resource)

@jfmartinz I will make the changes in folders like java, javascript, c/c++ with this format of yours by removing unnecessary topic column, is that okay?

Yes, you can create the PR right away

Let me mention the mistakes of formatting:

The order of the cols should be
Resource name (With the URL)
Description

Some of them does not follow this, example:

Some of the table does not contain description. Only the parent, the child elements should not have any description.

For example:
Tutorials in Java should have description but the child should not have description, for example Fundamentals, OOP should not have any description, you should add it on the parent which is tutorial and you're going to describe the section (tutorial) what its about.

Got it @jfmartinz Thank you for the instructions.


Docs Error Fixing and PPP Update

Pull Request Test Coverage Report for Build 365

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.967%

Totals

Change from base Build 364:
0.0%

Covered Lines:
2891

Relevant Lines:
3443

💛  - Coveralls


Create endpoints to check service status

Created endpoints which query count of rows in product and article tables to check if the service is running or not.
This is my first time contributing to OSS , would love to hear your feedback . :)

@tiagostutz please review my PR.

Hi @nabanitadewan !! Nice to receive your PR, good job!
I did the review and asked for some changes. If you have any doubts, please let me know. 🤓

Hi @tiagostutz , I don't see changes requested.

Click on the Files changed tab and scroll down over the codes and check that there are inline changing requests, like this:

@nabanitadewan my bad, I had forgot to push "Submit review". Now it should be visible to you 😄

@tiagostutz . I have made the changes as requested. Could you please review it?

Great job @nabanitadewan ! Thanks a lot for your contribution on this. 🥇


Training works, but testing doesn't

I'm using StarSpace for multilabel classification, and training the model works fine, but testing gives me the following error:
assertion "pair.first < this->numRows()" failed: file "src/proj.h", line 57, function: void starspace::SparseLinear::forward(const std::vector<std::pair<int, Real> >&, starspace::Matrix&) [with Real = float]
Aborted (core dumped)
Here is the full output:
starspace test -testFile cache/val.txt -model cache/starspace.model -predictionFile cache/starspace.pred
Arguments:
lr: 0.01
dim: 100
epoch: 5
maxTrainTime: 8640000
saveEveryEpoch: 0
loss: hinge
margin: 0.05
similarity: cosine
maxNegSamples: 10
negSearchLimit: 50
thread: 10
minCount: 1
minCountLabel: 1
label: label
ngrams: 1
bucket: 2000000
adagrad: 1
trainMode: 0
fileFormat: fastText
normalizeText: 0
dropoutLHS: 0
dropoutRHS: 0
Start to load a trained starspace model.
STARSPACE-2017-2
Model loaded.
Loading data from file : cache/val.txt
Total number of examples loaded : 39892
------Loaded model args:
Arguments:
lr: 0.01
dim: 100
epoch: 5
maxTrainTime: 8640000
saveEveryEpoch: 0
loss: hinge
margin: 0.05
similarity: cosine
maxNegSamples: 10
negSearchLimit: 50
thread: 10
minCount: 10
minCountLabel: 1
label: label
ngrams: 2
bucket: 2000000
adagrad: 1
trainMode: 0
fileFormat: fastText
normalizeText: 0
dropoutLHS: 0
dropoutRHS: 0
assertion "pair.first < this->numRows()" failed: file "src/proj.h", line 57, function: void starspace::SparseLinear::forward(const std::vector<std::pair<int, Real> >&, starspace::Matrix&) [with Real = float]
Aborted (core dumped)
This happens even when I test on the same data I trained on, so I don't think it has to do with the data.
I'm using cygwin on Windows, if that matters.

I tried using the tsv file instead, it seems to work.

@rajicon glad to know the tsv file works. Sometimes it could be due to the model saved is corrupted, or it's not the same version. Try to make clean and rerun the model to see if the problem persists.

Closing as no recent update.


apparent blocking when uploading via opendal

Hello :wave:
rustic_core 0.2.0
I'm noticing a (perhaps) unusual behaviour when taking a snapshot and pushing it over opendal:s3.
The backup progressbar seems to increment, then pause, then increment ... until complete.
When backing up locally, the progress bar moves constantly, which leaves me to suspect either:

a) Rustic builds packs, counts progress, then uploads in a blocking fashion
b) A transmit buffer is being saturated, throttling the entire process.

I haven't had the opportunity to dive in to the implementation, but I was wondering if it would be possible to discuss in the case of:

a) Running build and transmit in separate threads, and incrementing progress bytes when tx has completed, or;
b) Customising the size of the transmit buffer

Could anybody shed some light as to what is going on, and how we might come up with a more performant solution?
My apologies if this is the wrong place to discuss this, and if my understanding is way off.
Many thanks to everyone who is working on this wonderful library.

Thanks @talss89 for opening this issue and sorry for the very late reply :-/

When backing up locally, the progress bar moves constantly, which leaves me to suspect either:
* a) Rustic builds packs, counts progress, then uploads in a blocking fashion

* b) A transmit buffer is being saturated, throttling the entire process.

The progress bar actually does increase after the data has been chunked and successfully inserted in the queue which then compresses (if set), encrypts and packs it into a data pack file in-memory. This in-memory pack file is then transferred to the backend. There are some channels installed which transfer the data to the next step but which also block if the data cannot be processed fast enough.

So, the progress bar is actually not fully representing how much data has been completely processed. This should be corrected.
It could be that we are also not perfectly efficient here. But on the other hand if the bottleneck is uploading, then at some time (independently from the used queue sizes), every queue is filled and the progress only continues with the rate the backend can be filled with pack files..
We are having some vague ideas how to optimize the processing (which currently also is quite complicated which is not good), maybe using some kind of actor model throughout the whole process. But first we want to implement high-level integration tests so we can be sure that we won't introduce any regression when doing this.

I haven't had the opportunity to dive in to the implementation, but I was wondering if it would be possible to discuss in the case of:
* a) Running build and transmit in separate threads, and incrementing progress bytes when tx has completed, or;

This is already separated. What could be improved is the location of the byte increment. But: If we use large pack sizes and only increment once the data has been transferred, we will always see the mentioned behavior. Better would be to have multiple progresses: Read data / processed data (i.e. chunked/.../until packed in-memory) / transferred data. But I didn't get multi-progress working with indicatif, so far...

* b) Customising the size of the transmit buffer

This is currently also not possible. But I think the way to go is to customize queue lengths.


TestBtrfsMounts has been failing since golang/go@1cde87b

TestBtrfsMounts has been failing since golang/go@1cde87b
As you might know, travis (tip) has been failing due to this issue.

--- FAIL: TestBtrfsMounts (0.28s)
        btrfs_test.go:43: temporary mount point created /tmp/containerd-btrfs-test304576757
        btrfs_test.go:140: Temporary file created /tmp/containerd-btrfs-test369731024
        btrfs_test.go:156: Created loop device /dev/loop0
        btrfs_test.go:159: Creating btrfs filesystem
        btrfs_test.go:167: Mounting /dev/loop0 at /tmp/containerd-btrfs-test304576757
        btrfs_test.go:61: "/tmp/containerd-btrfs-test304576757/TestBtrfsPrepare-056817903/active/0945fdb16853720d83eecd724ad17e502f72e9ad14f220b560e89d28" not found
        helpers.go:23: unmount /tmp/containerd-btrfs-test304576757
        btrfs_test.go:188: Removing loop device
        btrfs_test.go:196: Removing temporary file
        btrfs_test.go:203: Removing temporary mount point
FAIL

It passes with the previous commit golang/go@e0d50a5830cbd17810cd488bf70d86fd0c2757ec
$ docker build --build-arg GO_COMMIT=e0d50a5830cbd17810cd488bf70d86fd0c2757ec -t tmp01 . && docker run --privileged tmp01
...
delete /tmp/containerd-btrfs-test116468877/TestBtrfsPrepare-066459207/active/6be2b25d47b065b8d07b36299b90c2ee91b6c0468c5661092208b5b9
delete /tmp/containerd-btrfs-test116468877/TestBtrfsPrepare-066459207/active/8eb08c44629e584c2c7ef645e469561a3a134d0a98833868fbff4a46
PASS

This seems an issue on Go, but I'm opening github issue here for tracking.
I'll look into whether it is known by the maintainers of Go.

Awesome analysis!
Could you confirm we saw this problem before https://github.com/docker/containerd/commit/5922756d8b0fcaec1c845b029b3f18cf2b8d6343? As far as I remember, we did.
Regarding the fix for https://github.com/golang/go/issues/13433, I am not quite sure how this affects us. I've tracked the error message down to https://github.com/stevvooe/go-btrfs/blob/8539a1d04898663b8eda14982e24b74e7a12388e/btrfs.go#L75. If that bool ok is misassigned to a bug in that patch, it makes sense that we'd be missing that entry.

Could you confirm we saw this problem before 5922756? As far as I remember, we did.

Yes,
https://github.com/docker/containerd/commits/master/snapshot/btrfs

4382d553ea7e9d7f8a44ae267583bef22112c5eb (latest): PASS
5922756d8b0fcaec1c845b029b3f18cf2b8d6343: FAIL
9c4b235954fc1d42f02943b534360510f58b254c: FAIL
...

cc @samuelkarp

Since we are not hitting this recently, let me close this issue now.
We should revisit this if we hit the issue again


PangoFc [FEATURE REQUEST]

Can you please make bindings for PangoFC

Which API specifically do you need?

The font config one

Which specific type/functions do you need? They can't be fully automatically generated that's why we ask.


No error if server goes down.

I tried to send a mail to my custom smtp-server using smtp transporter.
There was an error while processing the incoming email on my server and it shut down. I expected a error message from nodemailer, but instead the callback never fired.
var transporter = nodemailer.createTransport(
  {
    host: 'not.reliable.server',
    port: 25,
    auth: {
      user: 'test',
      pass: 'test'
    }
}

console.log('Sending Email...')
tansporter.sendMail(mailOptions, function(error, info) {
 console.log('nobody calls me... :('
});

Result
C:\dev> node index
C:\dev> "Sending Email..."
C:\dev>

This is most probably fixed in v1.9.0. Could you try again?


[table] column width not affected by columns prop after init

Describe the bug
The column widths does not update when the table’s column prop is modified after the initial render. This bug has been “hidden” by the fact that the TableHead handles the column widths in its own state, so column resizing is still working.
This state probably doesn’t belong in the TableHead component, it should have been outsourced to either the application or the stateful table like all the other serializable states. If the user is to load saved views with column widths included then this bug needs to be fixed.
To Reproduce
It actually requires some code changes to be reproducible. E.g. Create a story with a table that is resizable and has initial column widths. Update the columns prop after the initial render, e.g. using a set timeout.
The new column widths from the columns prop is not applied.
Expected behavior
The new column widths should be applied
Environment/versions:

OS: [e.g. MacOS, Windows]
Browser: [e.g. chrome, safari]
carbon-addons-iot-react version: [e.g. v2.60.0]

Additional context
If applicable, add screenshots to help explain your problem.
Add any other context about the problem here.
Specific timeline issues / requests

:tada: This issue has been resolved in version 2.79.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: