[#cleanup] cleanup unused code

Codecov Report

Merging #5606 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5606      +/-   ##
==========================================
- Coverage   40.46%   40.44%   -0.02%
==========================================
  Files        2868     2867       -1
  Lines       86565    86551      -14
  Branches    11452    11451       -1
==========================================
- Hits        35027    35007      -20
- Misses      48498    48504       +6
  Partials     3040     3040

Impacted Files
Coverage Δ

...orp/pinpoint/thrift/io/AgentEventTBaseLocator.java
0% <0%> (-100%)
:arrow_down:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...nitor/DefaultDataSourceMonitorRegistryService.java
77.77% <0%> (-11.12%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
62.5% <0%> (-2.21%)
:arrow_down:

...ollector/cluster/zookeeper/ZookeeperJobWorker.java
81.01% <0%> (-1.39%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.28% <0%> (+0.35%)
:arrow_up:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
66.42% <0%> (+1.42%)
:arrow_up:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
83.58% <0%> (+2.98%)
:arrow_up:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
65.71% <0%> (+8.57%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b9f41...793e056. Read the comment docs.


sink(ticdc): limit the number of transactions cached in a mysql worker

What problem does this PR solve?

Issue Number: close #10896
What is changed and how it works?

Remove the Add method of Txn.Worker to reduce interdependencies between modules.
Use the method of conflictDetector to receive event in Txn.Worker.
Implement causality.worker that support different batch control policies.

Check List
Tests
In the workload skew case, the maximum performance improvement after optimization is about 300% ~ 1000%.

Manual test (add detailed scripts or steps below)
Workload: sysbench random update

Before #10376

#10376

With this pr

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`Fix the issue that workload could not be evenly distributed among different mysql sink workers in some scenarios`.

/retest

/test all

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

Need to merge the latest master branch to include the commit tsc8ed99f6396968d53642d19de22e54f1c8d1d285 to pass the pull-dm-compatibility-test. @CharlesCheung96

/retest

/test cdc-integration-pulsar-test

/test verify

/test verify

/retest


fix(package): update kronos-service to version 3.2.11

https://greenkeeper.io/

[Current coverage][cc-pull] is 58.06%

Merging [#247][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #247   diff @@
==========================================
  Files             1          1
  Lines            31         31
  Methods           7          7
  Messages          0          0
  Branches          3          3
==========================================
  Hits             18         18
  Misses           13         13
  Partials          0          0

Powered by Codecov. Last updated by [ae5452b...5d37b5e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/compare/ae5452bb2897a3f9e69e51d8f75fb82982e048c2...5d37b5ee51127f4712af5525849a557ee3b16674
[cc-pull]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/pull/247?src=pr


File Name patterns for new BC versions

Hi,
New code analysers from AL Language extension shows warning if file is not named correctly.
E.g: table 123 "PREFIX My Demo" should be in file PREFIXMyDemo.Table.al, and page extension 1234 "PREFIX My Demo Ext" extends "Standard Page" should be in file PREFIXMyDemoExt.PageExt.al.
My initial guess was to use this:
		"CRS.FileNamePattern": "<ObjectNameShort>.<ObjectType>.al",
		"CRS.FileNamePatternExtensions": "<ObjectNameShort>.<ObjectType>.al",
		"CRS.FileNamePatternPageCustomizations": "<ObjectNameShort>.PageCust.al"

This does not correctly capitalize object type (e.g. gives "codeunit" intead "Codeunit"), and does not give shorter extension object type (e.g. gives "pageextension" instead "PageExt").
I'm using AL Language extension 5.0.191295 (that's from insider BC version).
IMHO all that is missing is <ObjectTypeShortPascalCase> that would give "Table", "Page", "Codeunit", "Report", "Query", "XmlPort", "Enum", "TableExt", "PageExt", "EnumExt", "PageCust".
Analyser does not consider case however it PascalCase looks nicer.
Thanks.

So .. they made a rule to force a fixed naming behaviour :-/.  Not sure I like that :(.
Thanks for the headsup - I guess I'll need to solve this by the time they release it.. .

Hello,
It seems that the new naming rule of microsoft does not include the affix in the file name!
The new naming:
..al
.Ext.al
Thanks

Well, I have an issue with this ... .  If I change anything on the "auto renaming" part, I will start creating new names all of a sudden in existing environments - without people expecting it .. :-/.
Don't know what I should do, to be honest :(.

@ernestasjuska , @hmerbouche ,
I decided to add a seperate tag as suggested ... .  As I don't have a complete overview - do you think this is conclusive - not sure about the controladdin :-/ - and no way I can look it up ... ?
            case 'page': return 'Page';
            case 'pageextension': return 'PageExt';
            case 'codeunit': return 'Codeunit';
            case 'table': return 'Table';
            case 'tableextension': return 'TableExt';
            case 'xmlport': return 'XmlPort';
            case 'report': return 'Report';
            case 'query': return 'Query';
            case 'profile': return 'Profile';
            case 'pagecustomization': return 'PageCust';
            case 'enum': return 'Enum';
            case 'enumextension': return 'EnumExt';
            case 'controladdin': return 'ConAddin';

@ernestasjuska @hmerbouche ,
if you'd like to test it - here's a pre-build:
https://www.dropbox.com/s/7vvkwit4t9qujw9/crs-al-language-extension-1.1.20.vsix?dl=1

I think these settings should work as "Best Practice", which make you able to use a prefix (or suffix), not add it in the filename, and the pascalcasing is there ... .
    "CRS.OnSaveAlFileAction": "Rename",
    "CRS.FileNamePattern": "<ObjectNameShort>.<ObjectTypeShortPascalCase>.al",
    "CRS.FileNamePatternExtensions": "<ObjectNameShort>.<ObjectTypeShortPascalCase>.al",
    "CRS.FileNamePatternPageCustomizations": "<ObjectNameShort>.<ObjectTypeShortPascalCase>.al",
    "CRS.ObjectNamePrefix": "ALDA ",
    "CRS.RemovePrefixFromFilename": true,

@waldo1001
I tested the new vsix and the new setting, it seems just perfect!
Do you know when you can release this new version?
Thanks

@waldo1001
To complete / correct your list  :)
Object | Abbreviation
Request Page | RequestPage
Control Add-ins | ControlAddin
Dotnet | Dotnet
Profile | Profile

@waldo1001
Thanks. It works great.
Tested control add-ins naming:
For controladdins it should return "ControlAddIn" with capital "I".

Found one more type interface "LBC My Interface" { } should be in file LBCMyInterface.Interface.al.

Pretty soon ;-)

@waldo1001 Do you like to change ConAddin to ControlAddin like the Suggestion from Microsoft?

Forced naming standard :( That would be the worst. The current standard isn't very readable. Gimme my spaces.


SyntaxError: invalid syntax

I cloned the repository in hopes of running flask shell but the following error occured.
Do we have to rename the whole app? Thanks!
    from {{cookiecutter.app_name}}.app import create_app
         ^
SyntaxError: invalid syntax

You must install the project via cookiecutter, not by cloning the repository. Look at the first part of the README

Correct; you must use this together with cookiecutter.


Snapcraft failed with status 2

Hey,
I am trying to build a snap on Ubuntu and am running into a problem. I tried using electron-installer-snap both as the standalone version, as well as part of Electron Forge. I am running into the exact same issue with the module, possibly conflicting with the module cross-spawn-promise.
Here's the console output:
electron-installer-snap --src=build/TestApp-linux-x64

Snapcraft failed (2)
Re-run with the environment variable DEBUG=electron-installer-snap:snapcraft for details.
(node:16964) UnhandledPromiseRejectionWarning: Error: Exited with status 2
    at closeArgsToError (/home/meh/Documents/Projects/TestApp/node_modules/cross-spawn-promise/lib/index.js:20:16)
    at ChildProcess.<anonymous> (/home/meh/Documents/Projects/TestApp/node_modules/cross-spawn-promise/lib/index.js:76:19)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
(node:16964) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16964) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handledwill terminate the Node.js process with a non-zero exit code.```

I am unaware as to how to address this issue. Please suggest how this problem can be fixed, or if there is a workaround. Thank you!

Per the error message, try rerunning the command with DEBUG=electron-installer-snap:snapcraft to get the output of the snapcraft command that electron-installer-snap runs:
DEBUG=electron-installer-snap:snapcraft electron-installer-snap --src=build/TestApp-linux-x64

Thanks! Getting this error now:
Failed to update the package cache: Some files could not be downloaded:

E:Failed to fetch copy:/home/meh/.cache/snapcraft/stage-packages/apt/ebbb4b1389f7016ca9b0be1bf758a6dabc4816304b01c4a504834f8b8be018b1c6748d93faa768ea0be99565dd4b0574/var/lib/apt/lists/partial/security.ubuntu.com_ubuntu_dists_bionic-security_main_dep11_icons-48x48.tar.gz  Hash Sum mismatch
E:Some index files failed to download. They have been ignored
or old ones used instead.

Check that the sources on your host are configured correctly.

 They have been ignored
or old ones used instead.

Check that the sources on your host are configured correctly.
Snapcraft failed (2)
(node:7511) UnhandledPromiseRejectionWarning: Error: Exited with status 2
    at closeArgsToError (/home/meh/Documents/Projects/TweetenApp/node_modules/cross-spawn-promise/lib/index.js:20:16)
    at ChildProcess.<anonymous> (/home/meh/Documents/Projects/TweetenApp/node_modules/cross-spawn-promise/lib/index.js:76:19)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
(node:7511) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7511) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

This looks like the error to me:
Err http://security.ubuntu.com/ubuntu bionic-security/main DEP-11 64x64 Icons
  Hash Sum mismatch

I don't know why this is happening, but it's more of an apt/Ubuntu problem, so I can't offer any help here. Try checking in Ubuntu's Stack Overflow or forums.

@MehediH You can try electron-builder If you don't have custom stage packages, packaging will be done without apt. And if you have custom stage packages, you can always set set _REMOTE_BUILD=true env to build using free remote service (where all configuration is done properly and proper Ubuntu version is used).

Anyway, electron-installer-snap also can be used — but to avoid errors due to your local system, you can use Docker. Image electronuserland/builder is suitable not only for electron-builder, but of course for electron-installer-snap` as well. Please note — implied that you build using electron version 2 (because set of packages different since electron 2 uses gtk3).

electron-installer-snap automatically uses the correct packages based on whether the app uses Electron >= 2.0 or not.

Hi guys, I realize this isn't an issue with the module itself but I am still having the same issue. I tried changing the download server for Ubuntu Software but it didn't help, and tried a bunch of other things that didn't help either. Any idea as to what could be causing this?
Also -- I was wondering, would I be able to create a snap package by using Windows Subsystem for Linux?

Is there any chance you just need to run an apt-get update because your sources are out of date?

It's possible that wiping out the apt cache might work, but I haven't tried it. When I run tests for electron-installer-snap, I use a Docker image of Ubuntu 16.04.

Cleaning the apt cache doesn't work, neither does changing the sources.

Yeah, I would just use a Docker container, such as the one that's used for tests in both electron-installer-snap and Electron Forge. It's Ubuntu 16.04, but that shouldn't matter unless you have some hard dependency that requires a newer Ubuntu version.

I don't really want to get in the trouble of using Docker. Do you have any Ubuntu env where you can try and repro the problem?

Evidently it is not currently recommended to build snaps on Ubuntu 18.04 without a container. I tried to run the electron-installer-snap tests with Ubuntu 18.04 and got some interesting errors:
https://travis-ci.org/electron-userland/electron-installer-snap/jobs/405055315#L706-L712
Looking for similar errors led me to https://forum.snapcraft.io/t/python-plugin-glibc-error-in-ubuntu-18-04/5233 which explains why.

Probably easier to just build on 16.04 then for now?

Probably easier to just build on 16.04 then for now?

Either 16.04 or a container running 16.04.

I ended up moving to electron-builder and solved this problem with lots of help from @develar. Thanks everyone.


Guessing Games exercise: Replace Utils.feedback with TestedCell

Todos

[x] add tested_cell as dependencies
[x] replace all feedbacks with TestedCell
[x] add solution for each TestedCell
[x] remove all assertions in feedback

You're on fire ❤🔥❤🔥❤🔥❤🔥
It might be worth making a PR to add the :tested_cell dependency to all livebook files, so we don't have to add it each time 🤔 It would also make it easier for others to use the TestedCell.


External links are  rather than

External links being implemented with <button> elements rather than <a> elements results in unintuitive browser behaviour.

compared to

This makes it hard to "open in new tab" external links.
I am aware that this is technically unneccessary since that is the default behaviour, however it forces additional mental load on the user to distinguish between internal and external links before clicking.
This also means that command-click on mac or ctrl-click on windows does not work for these links which creates a very confusing experience

Yes I tried My mouse middle button to open link in new tab And It didn't work. After inspecting It is html  rather than html  tag

@aaroncowie Thank you for raising this issue. This has been fixed and external links are implemented as  elements.


Feature Request - Only Loan out if current rate is better than existing

Hi,
Really enjoy using the bot. The one issue i have is whether to keep the auto renew on or off.
Say the best loan rate is currently 0.1% and i have the following loans -
1 BTC - 0.2%
2 BTC - 0.05%
I want to keep the 0.2% with auto-renew on and remove auto renew on the 0.05% loan so i can get it loaned out at a better rate.
Is this possible?
Thanks!
R

Why would you want that, if your bot is always online?

if the market go down when your lending end, if you have auto-renew, it will only renew to the same %. and nobody will take it because market is way under your %.

Ah I see. Thanks for the clarification!
I want to loan out BTC with a min of 0.04% and DASH with a min of 0.1% how is this possible? Do i just need to edit the #coinconfig line?

This would be the coin config your looking for:
coinconfig = ["BTC:0.04:5","DSH:0.01:5"]

was going to write same thing

I tried. Doesnt seem to work still lending DSH at lower rate.

Sorry forgot to type the A... this should work, although its around 0.03 right now it would be around there for a wile till it gets lower :)
coinconfig = ["BTC:0.04:5","DASH:0.01:5"]

my setting -
mindailyrate = 0.04
#coinconfig = ["BTC:0.04:5","DSH:0.1:5"]

hi new to this , i have ltc and xmr , ltc i like a min of. 0.001 , xmr 0.018 , how should i edit my coinconfig . note no btc or any other coins atm. thanks for all reply

@rje8686 people would still have to pay back the lending, when setting the last option at 0 it means it wont lend out new ones. It should return back into your wallet when people paid it off :)

@m33Lucky use this coin config:
coinconfig = ["LTC:0.001:5","XMR:0.018:5"]

@RDash21 in the coinconfig = ["Xmr:0.018:5"]
The 5 means 5 lends ?
Must this number be same as the spread lend?
Bot now dumps max amount after min daily rate of 0.018

@m33Lucky it means it will trade 0.018 Minimal daily rate and up to 5% maximal daily rate.

@RDash21 you're almost right :)
5 - is how many coins you want to lend, but it's not fully implemented yet. It only works in two different ways: if it's 0 - stop lending the coin, if it's something else - lend all. The idea was in the future to put a limit on coins, so you could withdraw half etc., but it's not as simple to code it.

does it override the min dailyrate line?
will BTC be lent at 0.05 or 0.04?
my setting -
mindailyrate = 0.04
#coinconfig = ["BTC:0.05:5","DASH:0.1:5"]

@rje8686 yes it does. But do you know that '#' in front of the line means it's a comment - this option is not active. To put into effect please remove '#'.

Closing due to inactivity and solution found.


Image download suggestion

I just found out about this. This is exactly what I've been waiting for for months now. Thank you so much!
Now, I've been using Heroic Launcher for my non-Steam games. A tool that came in handy was Boilr. It's available in the Discover Store. It can edit images for native Steam games as well, but I found it very useful for any non-Steam games I have. After the game is added to the Steam library, all you need is your SteamGridDB API key.
Hope this helps.

@hgdagon heck yeah brother that's definitely on my radar to add. I'm still trying to figure out the best way to do it! But thank you for the suggestion that really helps!


Age calculator is not interactive in phone veiw  i.e not responsive

Describe the bug
Age calculator is not interactive in phone veiw  i.e not responsive
Expected behavior
It should be responsive
Screenshots (Mandatory)

Additional context (Mandatory )
Are you contributing under any open-source program ?

Yes I am gssoc24 contributor

@apu52 Please assign me this issue under GSSoC'24

@agastya3636 Welcome to the METAVERSE!!!!!!!
Thanks for raising the issue . I have assigned you . you can start working on this issue.


Improve auxiliary file handling

This PR improves the handling of auxiliary files:

Besides being read, these files are now also written.
ProgCode objects now provide direct access to the contents of the referenced files. This required to back-link the Database object from DiagLayer which in turn required some custom __deepcopy__()  methods to avoid unexpected results like a deepcopy of a single diag layer containing the whole database.

Besides this, this PR first fixes the mksomersaultmodifiedpdx.py example: the somersaultecu has been slightly changed (by adding an auxiliary file for a single-ECU job), and thus the modified somersault ECU needed to be dragged along. Unfortunately the script has been broken for the last few weeks...
Andreas Lauser<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

@andlaus those are 3 unrelated topics in one PR, better to split them

@andlaus those are 3 unrelated topics in one PR, better to split them

I agree in principle, but the auxiliary file stuff requires the first two patches, while the "provide database via the diaglayer" stuff would be unused without the ProgCode changes. Do you still want it to be split?

@andlaus those are 3 unrelated topics in one PR, better to split them

I agree in principle, but the auxiliary file stuff requires the first two patches, while the "provide database via the diaglayer" stuff would be unused without the ProgCode changes. Do you still want it to be split?

Yes please, the changes are too much to review all at once

okay, done: cf #311 and #312...

alright: with #311 and #312 merged, I rebased this on top of the latest master. I fixed two further issues as drive-bys (https://github.com/mercedes-benz/odxtools/pull/310/commits/76364d88355df30348ede7fdf598d0271118f585 and https://github.com/mercedes-benz/odxtools/pull/310/commits/63958a8eb26d85648369c830ab22208a6b710884 ), but I don't think that these warrant a separate PR...


Corrected CONTRIBUTING.md

🛠 Fixes Issue
#741

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Hello @Wishy-S
The git clone for gh repo clone SauravMukherjee44/CodeIN-Community-Website is totally fine. We want to clone this repo, so removing SauravMukherjee44 will not be benefical.
Closing the issue.

@IAmTamal , @SauravMukherjee44 please read the steps from the beginning in my opinion if someone just  going to execute the same commands in an increasing order that won't going to work for him/her and might be problematic for them.


Add T&C to demo

It is necessary to add demo T&C to the Showcase

Term and Conditions demo is presented in the Showcase-generator.

It can by added by the command: yo showcase:feature-terms-and-conditions
@tony-shannon
What information should be located inside Terms and Conditions modal window?

This issue had been done

Tested on dev and couldn't see T&C. Moving back into "to do"

@PhilBarrett
Could you please clarify where did you test it?
because dev.ripple.foundation:8000 - it is for Helm-version
and dev.ripple.foundation (without 8000) - it is very old version, and I don't have possibility to upload build here
But you can see, that Showcase-generator is equipped with T&C-feature and it can be added to the Showcase:


开端

开端
Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[ ] I accept that @willmcgugan may be pedantic in the code review.

Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

I'm assuming this was a mistake?


about mount safety

Mount You can specify the directory to mount by using '-filer.path'
However, this is very insecure, and if the root directory is mounted and the '/bucket' is mistakenly deleted, it could be a security risk
Quarantine paths, any solutions?

We can choose to not allow deleting /buckets folder. Is this a solution?


*: prepare for raftstore-v2's split

Signed-off-by: SpadeA-Tang<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Ref #12842
What's Changed:

This PR add a new API create_checkpoint which uses create_checkpoint of the rocksdb.
It also refactors a small part of v1's split in order to reduce code duplication when implementing v2.
Check List
Tests

Unit test
Integration test

Release note
None

/cc @BusyJay @tabokie

/merge


Add LIBRA

@stamper-dev
Please check this PR
I think origin_chain should be native
If you think ok, accept and update after.


Input problem on Windows XP

When I'm using legacy mode under XP , I can have full access to the keyboard but unable to use mouse normally. But when I disabled legacy mode, both keyboard and mouse became unable to use.

Both software and external keyboard have that problem.

Can you post a screenshot of your UTM cursor settings?

@ToaruTaikun post your .utm or config.plist and screenshots of your UTM settings otherwise I will close this for not enough information.


Why a lot of plugins works well in local obsidian notes but not with published website

I have installed iconize and tag & word cloud, they work well in my local obsidian notes but it does not work in my published netlify website using digital garden

The published site is a static website that renders your markdown and is not Obsidian app and that whole ecosystem of capabilities. Core features are going to work along with some community plugins supported like Dataview, Excalidraw, Mermaid, others.
See the features supported by the Digital Garden here:
https://dg-docs.ole.dev/features/


Could not compile monoio-http (lib)

error: concrete type differs from previous defining opaque type use
   --> /Users/shabbirhasan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/monoio-http-0.2.3/src/common/body.rs:111:9
    |
111 | /         async move {
112 | |             let buf = self.bytes().await?;
113 | |             match encoding.as_str() {
114 | |                 "gzip" => {
...   |
136 | |             }
137 | |         }
    | |_________^ expected `[async block@/Users/shabbirhasan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/monoio-http-0.2.3/src/common/body.rs:68:9: 83:10]`, got `[async block@/Users/shabbirhasan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/monoio-http-0.2.3/src/common/body.rs:111:9: 137:10]`
    |
note: previous use here
   --> /Users/shabbirhasan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/monoio-http-0.2.3/src/common/body.rs:68:9
    |
68  | /         async move {
69  | |             match self.stream_hint() {
70  | |                 StreamHint::None => Ok(Bytes::new()),
71  | |                 StreamHint::Fixed => self
...   |
82  | |             }
83  | |         }
    | |_________^

error: could not compile `monoio-http` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

You can use old toolchain. For example nightly-2023-06-28


Select2 v3.4 width calculation changed

It seems that the way width of a select2 calculated has changed since version 3.2
I use a class on my inputs (x-large) that sets width to 210px. It worked well with Select2 3.2 and width of the div container (select2-container) wasn't overwritten and the class was copied to the div by select2.js.
The new version seems to copy the class, but it also sets inline width (149px in my case) which overrides the css width.
I quickly debugged it and it seems that it's because of this difference in initContainerWidth:
v3.2

 if (this.opts.width === "resolve") {
// next check if css('width') can resolve a width that is percent based, this is sometimes possible
// when attached to input type=hidden or elements hidden via css
style = this.opts.element.css('width');
if (style.indexOf("%") > 0) return style;
// finally, fallback on the calculated width of the element
return (this.opts.element.outerWidth() === 0 ? 'auto' : this.opts.element.outerWidth() + 'px');
}
return null;

v3.4

// next check if css('width') can resolve a width that is percent based, this is sometimes possible
 // when attached to input type=hidden or elements hidden via css
style = this.opts.element.css('width');
if (style && style.length > 0) return style;
if (this.opts.width === "resolve") {
    // finally, fallback on the calculated width of the element
    return (this.opts.element.outerWidth(false) === 0 ? 'auto' : this.opts.element.outerWidth(false) + 'px');
}

return null;

The old version was getting element's width only if this.opts.width === "resolve". The new code does it outside of the if block. The value for my input is "copy". Any reason this logic was changed?

Awesome. Thanks!!!


GPU can not be identified when using Tensorflow 2.4./2.5

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
tf 2.4
Custom Code
Yes
OS Platform and Distribution
Ubuntu 20.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.6/
GPU model and memory
RTX 3080
Current Behaviour?
GPU can not be identified under the tensorflow2.4.0 environment, and the code can only running using CPU. I am wandering whether Tensorflow with higher version (>=2.5) supports GPU, or whether TensorFlow 2.4/2.5 is compatible with CUDA 11.6.

Note that two RTX 3080 GPUs were installed on the machine, and the CUDA and CUDNN are installed properly, since there is no bugs when running other programs written based on Pytorch and GPU can be identified.

Standalone code to reproduce the issue
This is an environmental problem. The GPU cannot be recognized using tensorflow 2.4 / 2.5 framework, but it can be recognized using pytorch.

Relevant log output
No response

Hi @v3551G !  Could you check with Cuda 11.2 and CudNN 8.1 too on 2.7 or 2.8 . Thank you!

Thank you. On another machine equipped with RTX3080, install with CUDA 11.4, GPU can be identified when using Tensorflow 2.4.x

@v3551G ! Thanks for the update . Cuda 11.6 has stability issues . Please stick with tested configurations for optimum performance and  move this to closed status if it is resolved. Thank you!


Frequency of workflow catalogue stats updates

Just curious regarding how frequently the stats on the workflow catalogue are updated? Seems like its been a few weeks now :)

I was thinking the same!

I think the issue is related to the github actions..the catalogue is not correctly updated:
https://github.com/snakemake/snakemake-workflow-catalog/actions

Good catch, I checked the logfile and it looks like the error might be related to some rate limit being exceeded?
https://github.com/snakemake/snakemake-workflow-catalog/actions/runs/6045587868/job/16405876863#step:4:2439-L2441

Yes, indeed, probably related to this: rate limit
Hope they fix it soon.


feat: Added Client Credentials Flow to Swagger and Updated Role Configuration

title: '(feat): Added Client Credentials Flow to Swagger and Updated Role Configuration'
Description
This PR introduces a new feature
It adds the Client Credentials Flow to the Swagger configuration to make possible new ways of authentication
Pre-review checks

[x] DEPENDENCIES are up to date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Additional information

To request a review, check out who's involved to see a list of contributors and committers
Use the mailing list if you are unsure, who to contact, or if want to engage in a general discussion
Check out our guide on how to contribute
Check out our Release Guidelines
Check out the Eclipse Foundation contribution guidelines

Fixes #369 (Issue added retroactively)


[addon-storyshots] location of snapshots folder

Currently I am using the latest alpha version of Storybook, but as I remember correctly it was the same behavior in version 3.x.
Actual Behavior
When I run all stories as snapshot tests with Storybook Storyshots, I get one snapshots folder next to one arbitrary component with a story.

Expected Behavior
I would love having a snapshots folder for each component with a stories file. It shouldn't be the case that the snapshots folder for all stories is located at one place, which would be fine, but not next to one arbitrary component with a story.
Maybe I am just missing a configuration or it's something on Jest's end, but I would be thankful to get any advice for this.

In the latest version, storyshots addon has this new thing:
https://github.com/storybooks/storybook/tree/master/addons/storyshots/storyshots-core#stories2snapsconverter

Thanks for your prompt reply @igor-dv  But as I see it, this is nothing for specifying the location of the snapshots folder, is it?

You can derive from the Stories2SnapsConverter class and change this functionality
Here is an example.

Okay, this could work. Thank you!

Hey @rwieruch,
Did you ever get this working? Trying to implement at the moment and not having a lot of luck.
Cheers,
Otis.

Nope @CrashyBang Unfortunately not. I would have expected it to be the default at some point :)

Hey @rwieruch,
I kept playing with this and was able to get something like what you want with this:
// This is my storybook.spec.js

import path from "path";
import registerRequireContextHook from "babel-plugin-require-context-hook/register";

import initStoryshots, {
  Stories2SnapsConverter,
  multiSnapshotWithOptions
} from "@storybook/addon-storyshots";

registerRequireContextHook();

initStoryshots({
  configPath: "./testing/config/storybook",

  // this creates a *.snap.js for each *.stories.js I have
  test: multiSnapshotWithOptions(),
  // this tells storybook we're to look for stories (I have all mine in one folder) but as far as I know it searches down recursively from here
  integrityOptions: {
    cwd: path.resolve(__dirname, "../../stories")
  },
  stories2snapsConverter: new Stories2SnapsConverter({
    // This puts all my *.snaps.js in a __snapshots__ folder next to my stories folder, the default is to have them next to the *.stories.js files themselves
    snapshotsDirName: "../__snapshots__",
    // This just sets the extension to *.snap.js which I like
    snapshotExtension: ".snap.js"
  })
});

Oh perfect! I will definitely check it out 👍

Seems reasonable to me -- I think @igor-dv is probably the one to make the call

Should anyone come to this thread looking for answers, now there's a nice built-in configuration multiSnapshotWithOptions for that:
initStoryShots({ test: multiSnapshotWithOptions({ renderer }) })


Let PgFunctions support different data sources

PgFunctions now  only support to set definitions with BigQuery SQL statement. But if we have more data sources, we need to have converters for different data source.

legacy issue.


Update csv_eval.py

Fixed showing recall and precision of every class. Before this, it shows one equal number for every class.

This patch leads to bad plotting output. It seems that you need to somehow clear the canvas(e.g. plt.clf()) every time you call plt.plot.


ng build --prod || Can't resolve './public_api' in '/node_modules/angularfire2/database'

Angular:
^6.1.7
Firebase:
^5.0.0-rc.10
AngularFire:
^5.0.4
Steps to reproduce
Im getting the following error after ng build --prod
Actual behavior

ERROR in ./node_modules/angularfire2/database/index.js
Module not found: Error: Can't resolve './public_api' in '/Users/Sites/fornida-ng6/node_modules/angularfire2/database'

ERROR in ./node_modules/angularfire2/firestore/index.js
Module not found: Error: Can't resolve './public_api' in '/Users/Sites/fornida-ng6/node_modules/angularfire2/firestore'

package.json
{
  "name": "fornida-ng6",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e",
    "prestart": "ng build --prod && ngc",
    "build:ssr": "npm run build:client-and-server-bundles && npm run webpack:server",
    "serve:ssr": "node dist/server",
    "build:client-and-server-bundles": "ng build --prod && ng run fornida-ng6:server",
    "webpack:server": "webpack --config webpack.server.config.js --progress --colors"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^6.1.7",
    "@angular/common": "^6.1.7",
    "@angular/compiler": "^6.1.7",
    "@angular/core": "^6.1.7",
    "@angular/forms": "^6.1.7",
    "@angular/http": "^6.1.7",
    "@angular/platform-browser": "^6.1.7",
    "@angular/platform-browser-dynamic": "^6.1.7",
    "@angular/platform-server": "^6.1.7",
    "@angular/router": "^6.1.7",
    "@angular/service-worker": "^6.1.7",
    "@ng-toolkit/universal": "^1.1.41-beta.110",
    "@nguniversal/express-engine": "^6.1.0",
    "@nguniversal/module-map-ngfactory-loader": "^6.1.0",
    "angularfire2": "^5.0.0-rc.10",
    "core-js": "^2.5.4",
    "desandro-classie": "^1.0.1",
    "express": "^4.16.3",
    "firebase": "^5.0.4",
    "font-awesome": "^4.7.0",
    "jquery": "^3.3.1",
    "jsoneditor": "^5.24.6",
    "jwt-decode": "^2.2.0",
    "jwt-simple": "^0.5.1",
    "ng-snotify": "^4.3.1",
    "ngx-slick": "^0.1.3",
    "node-bigcommerce": "^3.0.0",
    "rellax": "^1.7.0",
    "request": "^2.88.0",
    "rxjs": "^6.2.1",
    "rxjs-compat": "^6.2.1",
    "sticky-js": "^1.2.0",
    "ts-loader": "^5.1.1",
    "zone.js": "^0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.6.8",
    "@angular/compiler-cli": "^6.1.7",
    "@angular/language-service": "^6.1.7",
    "@nativescript/schematics": "^0.3.1",
    "@types/jasmine": "~2.8.6",
    "@types/jasminewd2": "~2.0.3",
    "@types/jquery": "^3.3.6",
    "@types/node": "^8.10.29",
    "codelyzer": "~4.2.1",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~1.7.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "^2.0.4",
    "karma-jasmine": "~1.1.1",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.3.0",
    "ts-node": "~5.0.1",
    "tslint": "~5.9.1",
    "typescript": "~2.7.2",
    "webpack-cli": "^3.1.0"
  }
}

Here is what i did

npm uninstall angularfire2 firebase
npm install @angular/fire firebase --save
changed import paths from /angularfire2 to /@angular/fire in app.module.ts
updated import paths in any component using angularfire

forgot password reset link , see the video link completely solved
https://youtu.be/daGZO6YAkRg


Enable trim mode (<% -%>) for Template.render

Enable trim mode for BOSH ERB templating if Template.render is been used.

Closing in favor of #2004 as it had tests. Thanks!


[hbo] Improve extractor support for different URL scheme

[x] I've verified and I assure that I'm running youtube-dl 2016.10.07
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Site support enhancement

Description of your issue, suggested solution and other information
I noticed there is already an extractor for some HBO videos, but it only works when the URL is in a specific format ending with a video ID.  There are many videos on HBO website that do not contain a video ID in their URL (examples listed below).  However if you view page source on these and search for "videoId" you will find the video ID for it, which you can then use to re-construct a new working URL according to extractor requirements.
So basically if you can add these types of links to valid URL list on HBO Extractor.
Example URLs:

Single video: http://www.hbo.com/westworld/about/video/westworld-teaser-trailer.html?autoplay=true
Single video: http://www.hbo.com/girls/episodes/5/52-i-love-you-baby/video/ep-52-inside-the-episode.html?autoplay=true
Single video: http://www.hbo.com/game-of-thrones/about/video/season-5-invitation-to-the-set.html?autoplay=true

Thanks for the report. Those URLs will be supported in the next version.

Great, thanks very much for adding this!


Add a feature to only build for a selected environment

We can build for selected flavour using
arkana --flavour snowflake
It would be nice to have feature like
arkana --environment Production
So that we don't need to have every environment keys in our CI and we can just load only production keys in CI and that would be enough to run Arkana on CI

Makes sense! 👍
I'll keep this one open, feel free to contribute with a PR if you have the chance 😃 I won't have availability to work on this anytime soon, but should be a simple change!

I would like this as well. In my case we have debug and release builds that have different OAuth credentials. On a local developer machine they should not be able to build release configurations. We only build release configurations in CI environment which provides the environment variables for release.
My workaround will essentially be to define 2 different yaml files. The one ran on developer machines only has:
environments:
  - Debug

and .arkana-release.yml has:
environments:
  - Debug
  - Release

Nice solution @dalewking ! 💪 good to see that this has a workaround while it doesn't get implemented.
I'm open to discussing how you guys feel like this should be implemented, from a DevX PoV, architectural, etc. I don't have an opinion yet

The workaround suggested by @dalewking would require to manage multiple .arkana.yml for different environments.
Having the capability of selecting the environment while running arkana is the best way to go, i think.

That is why I labeled it a workaround, not a solution. It works but not ideal to have different yaml files that only differ in targets.

Yes, i understand that.
I was just commenting to put some wheitage on not relying upon a workaround and going with the actual sultion 😄

@nishchal-v @dalewking I've opened a PR for this here: https://github.com/rogerluan/arkana/pull/48
Would you be so kind and review it? Possibly test it? See if I missed anything, if you'd change anything in the design, etc :) Looking forward to your feedback! I hope this improves your projects without the necessity to keep multiple config files around 🤗
Cheers!

Wow, thank you so much for including the feature 🙏🏼.
Regarding the review of the PR, I am unaware of the Ruby development so it would be best if someone who understands the Ruby and it's coding standards review it.
Regarding the testing of the PR, I have tested it for environment selection and it works as intended. Thanks again for including this feature.
I also have added a suggestion in the PR comments, see if we can make that change else current changes would do just fine.

Btw, waiting for the Android projects support 😅.
This tool is very helpful from security standpoint for iOS projects, thanks for providing such open-source tool 🙏🏼

Glad you like the project and thanks for testing the PR!
I'm afraid to inform that for Android support I'll either need a sponsor or someone else to contribute to the project 😅


Example code is missing pub keywords in returns

Aim
Many of the examples in the documentation state something like this:
fn foo(x : Field, y : pub Field) -> Field {
    x + y
}

However, this syntax does not seem to be accepted (anymore). The return value should have the pub keyword.
Should this issue be listed as a 'bug' or an 'idea'? Dunno.
Expected Behavior
I expect the example codes to work.
Bug
Without the pub keyword I get error:
The pub keyword is mandatory for the entry-point function return type because the verifier cannot retrieve private witness and thus the function will not be able to return a 'priv' value
To Reproduce

Installation Method
Binary
Nargo Version
nargo 0.17 86704bad3af19dd03634cbec0d697ff8159ed683
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response

Nothing? Nobody interested?

Hi @microbecode. The example you've posted is actually valid Noir, foo is a non-entrypoint function so its return value isn't required to be public. This is only the case for the function main so I expect what's happened is you've renamed the function to main which adds the extra restriction. It looks like we don't explicitly flag up this requirement for main in the docs however so we could add a section on that.
I've removed the public argument to foo in #3643  to help avoid any confusion in future.


Zazu plugin is activating, but Zazu doesn't show plugin output

Expected Behavior
Zazu should display plugin results correctly.
Actual Behavior
Plugins activate properly, but their results are not rendered by Zazu.
Sseems to me that Zazu goes to fallback mode and the actual plugin's output is not shown. Only the fallback (file-search) output is rendered.
Steps to reproduce the behavior

install Zazu for windows via zazu-Setup-0.5.2.exe
install a plugin, say "zazu-ip-address" from https://github.com/blakek/zazu-ip-address
try to activate the above plugin (Open Zazu and type ip)
the plugin generates proper output, but it doesn't show up in Zazu.
Zazu falls back to file search for the given text, ip

See screenshot with plugin logs: https://imgur.com/XYCnu9M
This erroneous behavior is not limited to the above plugin, it also happens for other plugins too (e.g. the giphy plugin also doesn't work as expected).
Versions

Zazu: 0.5.2
OS: Windows 10 Pro, 64 bit

Please, include a link to gist of most applicable ~/.zazu/log/ file.
https://gist.github.com/nonbeing/48375a6fbc27a80ad6161acf3a441985
Relevant snippet from logs:
{"results":[{"icon":"fa-globe","title":"Internal IP: <IP_ADDRESS>","subtitle":"(Select to copy to the clipboard)","value":"<IP_ADDRESS>"},{"icon":"fa-globe","title":"Public IP: <IP_ADDRESS>","subtitle":"(Select to copy to the clipboard)","value":"<IP_ADDRESS>"}],"plugin":"blakek/zazu-ip-address","block":"cjjjp9wau0000lor38cl4rrdf","level":"info","message":"Script Results","timestamp":"2018-07-13T08:08:28.407Z"}
NOTE : the actual value of public IP in the logs has been changed. Have verified that the plugin works correctly and the logs do have the correct public IP.

Here's my .zazurc.json:
{
  "hotkey": "alt+space",
  "theme": "tinytacoteam/zazu-light-theme",
  "displayOn": "detect",
  "plugins": [
    "blakek/zazu-ip-address",
    "tinytacoteam/zazu-calculator",
    "tinytacoteam/zazu-file-finder",
    "tinytacoteam/zazu-template",
    "tinytacoteam/zazu-system",
    "tinytacoteam/zazu-package-manager",
    {
      "name": "tinytacoteam/zazu-fallback",
      "variables": {
        "rootSearches": [
          "google"
        ]
      }
    },
    {
      "name": "tinytacoteam/zazu-clipboard",
      "variables": {
        "ClipboardKey": "cmd+shift+v"
      }
    }
  ]
}

Thank you for reporting it!


fix: added props 'default BorderColor' and 'defaultFontColor'

Added the ability to set default frame and font colors separately from each other: added "defaultBorderColor" and "defaultFontColor" props.

Good job!


Search viewlet multiroot UI

We need to determine what the UI for multiroot searches in the search viewlet will look like, and experiment with different possibilities. This will be influenced in part by multiroot UI decisions elsewhere in the product.
Separate issue for functionality and include/exclude behavior in multi and single root workspaces: #27226
A few initial options:

Group results under a new node per root folder where the list still scrolls together (mostly implemented here: https://github.com/Microsoft/vscode/pull/29964#issuecomment-312380260)
Group results in subviews that scroll independently (git viewlet?)
Leave them in a flat list, but make the folder name stand out somehow

Some thoughts:

Group results under a new node per root folder where the list still scrolls together (mostly implemented here: #29964 (comment))

I like that this UI allows you to clearly see which of your workspaces have results. It precludes interleaving results from different workspaces though.

Group results in subviews that scroll independently (git viewlet?)

N scroll views sounds clunky.

Leave them in a flat list, but make the folder name stand out somehow

This leaves open the option to interleave results from different repos. In practice, I am not sure what heuristic for sort order would be better than just grouping by repo (maybe just # of results per file?).
I would favor 1 or 3.

It might not be too complicated to offer both options (1 and 3), either with a setting or with a toggle button.

@roblourens I suggest we add this to our UX meetings (this week and/or next week).


some html code missing < >

when I use 0.11.1,I try insert  htmlcode to docx.I found some html tag like '' '' missing <>
But,when I use 0.10.5 '< >' can show me.

I'm sorry 😐 Commit wrong。


[Request] Biome Specific Spawns

Would it be possible to add a feature to restrict ore spawns based on a list of biomes given in a new config option?

Yeah, I am gonna rework the mod when I get the time, gonna fix biome / dimension specific spawn option as well as reworking how the config looks.

This can be found in https://www.curseforge.com/minecraft/mc-mods/ore-tweaker the 1.16 version.
Sorry this did not happen 4 years ago.


Parallel processing pr

Adding joblib feature parallelization.

Added check if parallelization can be performed in nm_stream_offline
Changed class attribute to instance attribute in nm_mne_connectivity
Added dependency of joblib
Added Tests for equal sequential and parallel computation

@toni-neurosc I worked on a different branch where I merged some of your commits from #281.
Thanks for adapting the PR!
The model.predict is a basic (not really tested) method to load a ML model and get directly predictions that could be used for real-time applications. It was however badly implemented, and not tested, so I removed it for now.
The real-time computation also one of the reasons why I put the computation in this strange while True loop, s.t. a datastream could replace the nm_generator and constantly feeds data until a "stop signal" is reached.
Optimally this would be replaced by a mne-lsl Stream at some point (#278, https://mne.tools/mne-lsl/stable/generated/tutorials/00_stream.html#sphx-glr-generated-tutorials-00-stream-py).
Regarding the parallelization implementation, I found out that there are some issues with parallelization of certain feature estimation and post-processing methods. Currently normalization for example is implemented sequentially, which means that batches need to be iteratively computed. The same is true for bursts, since there also a time window (of e.g. 30s) has to be defined and then iteratively processed.
I added now a check for those methods in nm_stream_offline and throw an exception if those are selected when parallel is set  to True.
Personally I am also a bit more in favor of joblib across OS systems, which simplified the code a bit. So for now I removed the OS check.
Thanks again! Such a great addition to the tool

Hi Timon! Thanks for your comments, those are some good points that I did not consider, partly cause the parallelization is one of the first things that I tried to do and did not have a proper full-picture view of the software (still don't have it).
I indeed notice the issue with parallelization while working on nm_bursts, since the circular buffer persists across batches and it's used to update the percentile. There is however a possibility to maintain the parallelization if the update of the buffer and the calculation of percentile is done sequentially, and then the processing of the batch is submitted to the worker pool with a frozen copy of the percentile. This logic could extend to the normalization but I'd have to check.
Of course this requires a little more low-level knowledge of how the sub-processes are being spawn and which data is being copied between processes and which one is just referencing other blocks of memory which could change during execution. For example, if a class variable self.burst_thr is calculated and stored, and then the job is submitted, will that burst_thr be copied into the new process, or when the next batch comes and updates it, will it affect already running processes? I need to research or write a test case for it.


HADOOP-17289 ABFS: Fixing the test case ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics

Currently the test does not work when the fs.azure.test.appendblob.enabled=true.
Fix: By making the expected calls number relative to the number of calls before the actual operations are made.
Driver test results against taccounts in Central India region
HNS-OAuth-AppendBlobTrue
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73
[INFO] Results:
[INFO]
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
HNS-OAuth-AppendBlobFalse
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73
[INFO] Results:
[INFO]
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
HNS-SharedKey-AppendBlobTrue
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33
[INFO] Results:
[INFO]
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16
HNS-SharedKey-AppendBlobFalse
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33
[INFO] Results:
[INFO]
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 245
[INFO] Results:
[INFO]
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 58s

trunk passed

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
15m 16s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 57s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 54s

trunk passed

-0 :warning:
patch
1m 13s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  1s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  8s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
0m 57s

the patch passed

_ Other Tests _

-1 :x:
unit
1m 28s
/patch-unit-hadoop-tools_hadoop-azure.txt
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

72m 12s

Reason
Tests

Failed junit tests
hadoop.fs.azure.TestBlobMetadata

hadoop.fs.azure.TestNativeAzureFileSystemConcurrency

hadoop.fs.azure.TestNativeAzureFileSystemFileNameCheck

hadoop.fs.azure.TestWasbFsck

hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked

hadoop.fs.azure.TestOutOfBandAzureBlobOperations

hadoop.fs.azure.TestNativeAzureFileSystemContractMocked

hadoop.fs.azure.TestNativeAzureFileSystemMocked

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2343/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2343

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux be1a6e361e33 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a308a1ec22b

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2343/2/testReport/

Max. process+thread count
421 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2343/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The yetus run error is due to tests failing on the WASB side, which is not affected by the changes proposed here.
Link to HADOOP-17325.

Can we get this rebased to trunk (not merged), so that the sole changes are from the PR here?


No module named 'json' error

I have deployed the Sanbox local source code, and I have updated the python_path to the path of the Miniconda virtual environment (python_path=/root/miniconda3/envs/sanbox/bin/python). However, when I actually use it, it still reports a 'No module named 'json'' error
If I'm deploying with Miniconda, is this configuration not workable?

same

same

same

same

I have deployed the Sanbox local source code, and I have updated the python_path to the path of the Miniconda virtual environment (python_path=/root/miniconda3/envs/sanbox/bin/python). However, when I actually use it, it still reports a 'No module named 'json'' error If I'm deploying with Miniconda, is this configuration not workable?

I haven't tried your scenario, but I can roughly guess the reason for the problem, mainly related to the location of Python. When building the project, the Python related environment will be copied to/var/sandbox/sandbox python. The location you provided is:/root/miniconda3/envs/sanbox/bin/python， So it will be copied to/var/sandbox/sandbox-python, and you need to check if there is/var/sandbox/sandbox python/var/local/lib/python3.XX/site-packages under/var/sandbox/sandbox-python related dependencies

I resolved this issue through the following steps:
Start the Image:
First, I launched the sandbox image to access the container environment:
docker start <container_name>
docker exec -it <container_name> /bin/bash

Modify the Default Python Path:
Inside the image, I located the system’s default Python path and changed it to the Python path installed in Miniconda. This ensures the container uses Miniconda’s Python environment instead of the system’s default Python.
Check the current Python path:
which python

Update the PATH environment variable to point to Miniconda’s Python:
export PATH="/path/to/miniconda/bin:$PATH"

Verify the change:
which python

Save the Changes:
To make the changes persistent, I updated the container’s configuration or saved it as a new image:
docker commit <container_id> <new_image_name>

Restart the Image:
Finally, I restarted the image to verify the modifications:
docker stop <container_name>
docker start <container_name>
docker exec -it <container_name> /bin/bash
which python  # Confirm the Python path is correctly set

By following this approach, I successfully switched the Python environment of the sandbox image to Miniconda, resolving the related issue.


GH-695 Implement an access token API to manage tokens

#695

Good job! Some cosmetic issues, but I'll take care of it later as I don't really require from you to follow my codestyle 1:1, especially that's it's not precisely defined.
Might be a good idea to cover this api with unit & integration tests, do you want to try to do this in a new PR or you're done for now? :)

I'll start on the unit & integration tests now


Unfreeze jdk9 appveyor package version

So it gets the new package version which has the updated download links. However, the new package version needs to be approved first: https://chocolatey.org/packages/jdk9

@2m, any workaround we can do in the meanwhile to unblock our CI?

Apparently it is possible to select not-yet-approved version with the -version, which I did as a workaround.


I encountered an issue when attempting to return an embedding for a string containing the character "∙". The error message I received was: "Your request contained invalid JSON: 'utf-8' codec can't decode byte 0xad in position 5614: invalid start byte".
In addition to the "∙" character, when embedding approximately 1000 times, other special characters also cause similar issues. This problem has been noted previously, as seen in this link: https://github.com/opensearch-project/ml-commons/issues/1666. Could you please address this issue again?
Thank you.
Removing the special character and replacing it with " " works. If I request the embedding directly from open AI (with special character) it works fine.
How can one reproduce the bug?
Steps to reproduce the behavior:
Setup Open AI connector described here:
Retrieve embedding for string described above.
What is the expected behavior?
Embedding should be returned for strings containing special characters.
What is your host/environment?
Opensearch 2.13 running in AWS
Do you have any screenshots?
N/A
Do you have any additional context?
N/A

This is a known issue.  You can go to AWS OpenSearch console, then upgrade to OpenSearch_2_13_R20240520-P4 to fix the issue


#315 loosen system.web

I've implemented moving HttpUtility into an interface to show the approach.  I tried a number of things, and this seems to have the least impact on the existing code-base.
Created projects for Asp.Net and Nancy to show how to use it.  Future users would need to update the SquishIt.Configuration for SquishIt.AspNet.Configuration in order to get the right web dependencies configured.  As there is this Configuration, used statically, it wasn't easy to abstract out and this was the neatest way I found.
I created a private class within MachineConfigReader to handle the System.Web.Configuration.DeploymentSection, as that would have to be done for every web framework except ASP.NET, so it's a lot simpler to do it for all and avoid the interface.
Similarly one or more enumerations will have to be copied internally to SquishIt for similar reasons (e.g.
AspNetHostingPermissionLevel).
Please take a look and let me know what you think.  I can implement the rest of the interfaces quickly, as I already prototyped them (mainly HttpContext, HttpRuntime)
I've done my best to follow the coding style, though it doesn't seem to be consistent ;)

Hey I just wanted to circle back and see where things stand on this - if you are done I can probably merge it manually into my branch and go from there.  Or if you're out of time, just let me know where you left off.
I could have sworn I replied to this before it must have gotten eaten.  Sorry about that.  And for the inconsistent code style - your stuff looks fine.  Some of the stuff that looks different is reaaaaaaaallllllllly old.

Hi, sorry, I did get your previous message and I haven’t had a chance to look at it again yet and finish it off, but I should be able to by next week, if that’s ok.
Do you have a preference on the style?  Generally I go with R#...
From: Alex Ullrich<EMAIL_ADDRESS>Sent: 09 February 2016 19:25
To: Worthaboutapig/AC-SquishIt<EMAIL_ADDRESS>Cc: Jeremy Clarke<EMAIL_ADDRESS>Subject: Re: [AC-SquishIt] #315 loosen system.web (#1)
Hey I just wanted to circle back and see where things stand on this - if you are done I can probably merge it manually into my branch and go from there. Or if you're out of time, just let me know where you left off.
I could have sworn I replied to this before it must have gotten eaten. Sorry about that. And for the inconsistent code style - your stuff looks fine. Some of the stuff that looks different is reaaaaaaaallllllllly old.
—
Reply to this email directly or view it on GitHubhttps://github.com/Worthaboutapig/AC-SquishIt/pull/1#issuecomment-182019157.

For styling, pretty much everything is VS / R# defaults (unless it wasn't at the time I got involved).
If you look at RelativePathAdapter, that is a pretty recent addition and should serve as an example.
Maybe as part of 1.0 release I'll try a global R# cleanup - last time I tried it didn't work so well but that was a few versions ago.

Just realized I didn't answer your main question - next week is fine.
Thanks again for this - we get Nancy questions a few times a year and I never really know how to answer them.

What is the status on this?  I'd like to get 1.0 out soon.  Have some bandwidth at the moment if you need help.

Hi, sorry I haven't looked at this, been a bit snowed under.  I'll try and take a look at it again today, feel free to pester me.

Also, I can't quite see why, but when I run the tests in feature/v1.0, several blow up with
System.Reflection.TargetInvocationException : Exception has been thrown by the target of an invocation.
  ----> System.InvalidProgramException : Common Language Runtime detected an invalid program.

which is thrown as part of Jurassic.Library.UserDefinedFunction.CallLateBound(Object thisObject, Object[] argumentValues).  If I change tests to run under x86 everything's fine, though this library is MSIL.  Any ideas? (I'm using the R# test runner and changing the Options->Platform in the test runner.

I use testdriven.net haven't had any problems - it might be a testrunner issue.  Jurassic is squirelly in general though, I had almost as many issues with it in the past as I did with ironruby.  I wouldn't think you're changing a lot in the preprocessors (at least I hope) so don't worry about it too much.
Just realized a new version of jurassic is out too, I will upgrade that today.  Let me know if you need a hand with anything - I'm hoping to get 1.0 out ASAP.

Thanks, no, not expecting to touch the preproccessors themselves, just where the dependencies need extracting from the tests.  I can set R# to run in x86 mode for tests, which doesn't affect the commits, so it's likely an Jurassic/ R# incompatibility.
I'm working through the rest of it now, I'll make a pull request when I'm done, hopefully I can finish it off today.
Oh, do you have any view on Contracts (System.Contracts)? I use them rather than custom null-guards...

Looks nice enough.  What is the experience like for external callers, that would be my main concern in any kind of change like that.

I've got most of the work done, however, it's quite difficult pulling out the call site references, as there's a general static approach in the design.  Personally I'm not a fan of the service-locator Configuration.Instance approach, it makes this kind of refactoring awkward :)
I need to get fix a few more of the tests and abstract the caching.  Hopefully I can send a pull request tomorrow.
As for the Code Contracts, probably that won't be relevant as too much of the code expects injected references to be null, so adding guards doesn't work.

Yeah I've come to terms with it over the years but there are definitely some frustrating things I run into now and then.  I'd like to replace the configuration stuff but don't really have a great idea on what to replace it with - that was all added slowly and it got unwieldy over time.  You're probably feeling more pain than anyone other than me has with that stuff right now, so if you have ideas I'd love to hear them.  I figure with 1.0 I can break whatever I want :)
Would love to introduce proper dependency injection but its more work than I have time for right now, and I'm not sure how much payoff there really is for the end user.  Once 1.0 is out I'm going to start figuring out asp.net core support, I'm hoping a middleware approach there will work nicely for that kind of setup work.

I'd be happy to work on DI, I love refactoring ;) For the end user not much difference, I'd expect, except better error-handling.  But for dev, it would be much better, clear separation and dependencies, as well as a tighter design, fewer difficult-to-track bugs, I'd think.
I'm also adding in xml comments as I go with the parts I'm touching, so I'd be happy to work on that too.
I'll finish this pull request and if you think the code/ approach is ok, I'm happy to work on the DI stuff.

Oh, and I was thinking of setting up a room on JabbR, I don't see one.  It's quite a good way of chatting/ throwing ideas around and helping people.  What do you think?

I've just noticed 'SquishIt.Framework.Resolvers.ResolverFactory`.  Is that some sort of poor-man's DI? Hmmm. Are you familiar with it?

Are you talking about https://jabbr.net?  I signed up there but can't see how to create a room.  Sounds like a harmless enough idea though.
Resolver factory would be about the poorest man's DI.  Its really for resource resolution - FileSystem, HTTP and 2 different types of embedded resource.  The factory just saves you from needing to reference all 4 resolver types.

Yes, jabbr.net.  I've created a room and, I believe I've invited you.  I've invited some AlexCuse, anyway :).
Thanks on the factory, I guess that should be rolled into a general DI approach.  It's really a pain getting this working, as there's lots of implicit and explicit dependencies all over the place.  It's one of those things that's fine until it isn't... then it falls apart! Still, plodding through trying to minimize my impact on the rest of the codebase.

I factored out all the System.Web references, but the knock-on effect for the Configuration.Instance means I may as well do the DI work too, as you suggested.  I've done a portion of it, but it'll take a day or two.  I'll try to sort it out this week.

Anything new on this?  I just got back from a few days vacation and don't see the jabbr room anymore.  Email me if thats easier :)

Hi, oh, I don't know about that, I haven't done anything :)  Either with jabbr, or with the code, been rather busy.  I can probably take a look at it in the next week or so.  Mainly I need to pull out the rest of the dependencies, which is tedious, more than difficult.

If you want to make sure the Asp.net stuff is all removed and then lay out your gameplan for configuration stuff I can do it.  I really need to get 1.0 out soon, people are reporting more and more javascript minifier bugs that I think will be fixed by moving to the newer versions of ajaxmin/yui.
Punting on it is also an option - the configuration stuff we have now isn't ideal, but we do have it.

Hi, well I can work on it today, so I'll take a look and get back to you later :)  It's quite a big change, so would make sense to include in a full version change and, personally I think it would make future development easier, though that maybe a matter of style/opinion.

Hello, sorry, didn't do much before, I'm working on it now.

Thanks, no rush - let me know if I can do anything to help.

Hi, I've done some more work today.  All the configuration instance static stuff is gone, which also means the test scopes have gone (as they are just there to attempt to manage the static-ness of configuration), so everything's constructor injected now, which reveals there are a lot of dependencies for the BundleBase.  I've tidied one of these, the rile resolver stuff, which I've rewritten to actually follow the interfaces and be injected normally, which has allowed those interfaces to be grouped.  When it's working, it'll probably be worth trying to group more of the interfaces together, in order to make the injection more manageable.
The tests in SquishIt.Tests are passing (I've had to update some of them), now I need to get the versions of the tests specific to ASP.NET / Nancy to run.  Not difficult, but will take some more time.  I may get it done today... will let you know.

Hi, still working on this when I can, but difficult ATM time-wise.  I'm trying to get closer to sending another PR for review, by just making the ASP.NET tests run with the new approach and add in the Nancy ones afterwards.  I need to find the time to revise all the tests, have done some of them- there's a lot of cleanup/ simplification.

THanks - I was just thinking this morning I should reach out and see how this is going.
Anything I can help with?

Well, I could try and get some more done in the next few days and push it to you, so you can take a look- after all, I'm a bit concerned that you may not like the approach I've taken and I'll have wasted loads of work! :) (Though, IMHO it's the best approach and I've thought a lot about it).

Honestly anything is probably better than whats there now.  I'd mostly like to get started on an explainer document for people migrating from previous versions.  I also need to start thinking on how to update https://github.com/AlexCuse/SquishIt.S3
Got an example you can just drop in here in case you don't want to push?

Hi, I've opened a new pull request with the latest working copy and have annotated it with a changelog, so please take a look...


Helm 2 support

The apiVersion in Chart.yaml is set to v2 . This stops people with Helm 2 from using this chart.
When I change it to v1 and use the chart seems to work. Is there a reason why it has been set to v2?
Could we change it to v1 so people stuck on Helm 2 can use the chart?

I would like to push a branch to fix this, and possibly some other bits, but I'm getting
$ git push --set-upstream origin allow-helm-2
remote: Permission to timescale/timescale-prometheus.git denied to oliverpjames.
fatal: unable to access 'https://github.com/timescale/timescale-prometheus.git/': The requested URL returned error: 403

@oliverpjames you need to open a PR from your own repo. You don't have permission to push directly to this repo

Sorry for letting this issue stagnate. Helm 3 has been out for a year so I am gonna close this issue. If people feel strongly please re-open this issue or file a new one.


"Home" page: Make the list of blue bullet points look consistent in mobile view

Right now, the text looks untidy and inconsistent, please fix that.

Please make sure you refer to the issue number # when you are making a pull request.
Please add screenshots and (or) screen recordings for your resolution of the issue in your pull request, in order to ensure your pr gets merged soon. This is highly recommended.

I want to work on this

Go ahead, @NPriyajit! All the best.

Hi @NPriyajit I just unassigned you from the issue as you already have 2 open issues, please complete them first. Thanks.

I want to work on this issue under GSSoC22.

Assigned @aashay-03


DEADLINE_Exceeded when writing large amounts of data to firestore

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

OS: Mac os X
Node.js version:v 14.15.3
npm version:
@google-cloud/firestore version: 3.5.0

Steps to reproduce

attempt to write a lot of data into firestore
after awhile it will start erroring with DEADLINE_EXCEEDED.

recreatable 100% of the time... don't know what happened but it used to work, we didn't change anything and now it's erroring out.

looks like poor internet connection on the client side is causing DEADLINE_exceeded


CLI doesn't upgrade clustermesh-apiserver...

Hi,
not sure if this is correct but I wonder a bit because of the results of an upgrade from 1.10.5 to 1.10.7.
The upgrade didn't touch the clustermesh-apiserver at all. Do I need to reinitialize the clustermesh
after upgrades?
Versions:

cilium-cli: v0.10.1 compiled with go1.17.6 on windows/amd64
cilium image (running): v1.10.7

Status (image versions) after upgrade from 1.10.5 to 1.10.7:
Image versions    cilium                   quay.io/cilium/cilium:v1.10.7: 6
                  cilium-operator          quay.io/cilium/operator-generic:v1.10.7: 1
                  clustermesh-apiserver    quay.io/coreos/etcd:v3.4.13: 1
                  clustermesh-apiserver    quay.io/cilium/clustermesh-apiserver:v1.10.5: 1

Clustermesh api-server is still version 1.10.5
Kind regards,
Michael

Thanks for the report @seimic. Indeed it looks like currently cilium upgrade will only upgrade the cilium DaemonSet and the cilium-operator Deployment. I think the command should also check whether clustermesh-apiserver and/or hubble-relay are installed and need to be upgrade.
Possibly also related: #190, #260


method filter moved to query parameter.

Fixes #336
Description
method arguement moved to default query parameter dictionary.
Other information

Made necessary changes in the tests
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Closing PR since checks failed


AWS just announced region-specific reservations (instead of AZ-specific), are you guys going to support the new reservation type (mostly just a grouping issue?)?

AWS just announced region-specific reservations (instead of AZ-specific), are you guys going to support the new reservation type?  I would assume that this is just a grouping issue or something pretty simple to fix.

Hi @scumola real sorry for such a late reply.  I haven't had the opportunity to really give this project the love it needs -- I don't have any plans to update at this time but I am happy to take PRs (from anyone) so long as the current usage and use cases aren't impacted.


New spelling for Wasmi in the codebase

From now on we use "Wasmi" instead of "wasmi" since it is simpler and more standard as a name. Other Wasm runtimes such as Wasmer, Wasmtime and Wasm3 have the same spelling.


btc.Transaction.fromPSBT() fails in<EMAIL_ADDRESS>

Hello!
Thank you for your work on the scure libraries, they work great!
That said, I'm having trouble getting btc.Transaction.fromPSBT working in<EMAIL_ADDRESS>Other things work great: Creating btc.selectUTXO, tx.toPSBT, just btc.Transaction.fromPSBT fails with:
Reader(magic): TypeError: Cannot read property 'prototype' of undefined

Thrown somewhere in decodeStream.
We have polyfills for crypto, TextEncode/TextDecode, Buffer, stream etc.
This same code works in a web environment with the same inputs.
Any input/help would be appreciated!
This might be an issue for micro-packed instead.
Let me know and I can open an issue there.

Spent a lot of time on this but it works correctly in react native 0.74.2.
You will need to create a reproducible repo with exact code which is breaking.

We don't support Buffers. You must always use Uint8Array.  For example, it completely redefines semantics of slice to make it like subarray instead of copy.

I wasn't aware of that re: Buffers! Thanks!
Turns out that fastestsmallesttextencoderdecoder TextDecoder shim isn't up to full spec / only supports utf-8 for speed purposes ( I'm assuming that is the issue). Replacing the shim fixed the issue.
Other shims that make similar compromises suggest to use Buffer for other types of conversions, but after your comment above I'm assuming using TextDecoder was a deliberate choice.
Thanks again for your time and sorry for the churn, I was banging my head against the table.


documentation suggestions

I have a few questions that aren't answered by the documentation but eventually managed to figure it out. After reading/trying it out a few times.
So here are some suggestions that I believe will improve comprehension for new users.

animated and native needs to be used together. This piece of information needs to be on the prop page for native.

While reading the doc, the constant question I have is, what is animated ?
The only place where this is mentioned is on the perf page. The perf page is somewhat "hidden", i.e. the last place someone new to the library will read.
Unrelated: I realised that not all property are supported by native ? i.e. background ?

The config prop needs to be clarified better.

While reading, I noticed that the config prop allows easing, but at the same time allow physics based configuration. So my first impression is "What's happening?"
It is only later on the gotchas page that I understand what's happening.

The documentation should list the exports of the library to let users know what can be done/ or not done.

All good suggestions. I must say i am struggling a little with proper english and writing docs in general. Would you be up for a PR? It's all under /documentation/*.mdx, simple markdown files with some components mixed in.

Unrelated: I realised that not all property are supported by native ? i.e. background ?

native supports all styles and attributes, background works, too. Just tried it too and seems fine to me, do you have a snippet that i could inspect?

Would you be up for a PR? I would be so happy if someone with a better grasp for structuring could take a look at this.

Yea sure, I can take a stab at it.

Do you have a snippet that i could inspect? https://codesandbox.io/s/9z766oxwvp

My bad. I reported the wrong thing.
It's the transform property that is not working for me.

Here's an example without native:

https://codesandbox.io/s/628478kx5r

Here's an example with native:

https://codesandbox.io/s/l93o2m5067
The transform -40px doesn't seem to apply on native

Ah, that's an easy fix, it needs to be:
transform: styles.y.interpolate(y => `translate3d(0px, ${y}px, 0px)`)

Explained here: http://react-spring.surge.sh/perf#interpolation
But see, that's exactly the kind of stuff i have problems putting into understandable terms and structure. What native really does is spit out Objects instead of plain values. These objects receive updates. That is why you need animated.el, it knows how to deal with these animated-objects.

ah I see. Thanks for all the information. Really appreciate it.
So that's the behaviour of native.
I guess this leaves me to the next logical question. Why isn't native the default?

👌 Thanks again. I'll see what I can do about the docs. English is not first language too, but what I can offer is my fresh perspective on the documentation as a beginner.

@drcmda Love this library! Thanks so much for it. But also running into confusion when using native...

Ah, that's an easy fix, it needs to be:
transform: styles.y.interpolate(y => translate3d(0px, ${y}px, 0px))

Does this mean that when using native, all numerical values need to be applied using interpolate (rather than just style={props}?

Only if you need to interpolate (transform) values in any way. These aren’t numbers, they’re self updating objects that react otherwise couldn’t understand, that’s why you need animated.element.

Only if you need to interpolate (transform) values in any way.

If you can use values as they are, you don't need to worry about anything:
to={{ opacity: 0, transform: 'translate3d(10px,0.0)', color: 'blue' }}>
  {props => <animated.div style={props} />}

If you are using values that you shape into something else, you interpolate:
to={{ something: 10, color: 0.75 }}>
  {props => <animated.div style={{
    transform: props.something.interpolate(x => `translate3d(${x}px,0,0)`,
    color: props.color.interpolate({ range: [0,1], output: ['red', 'blue'] })
  }}>}

Interesting! Thanks for the thorough reply.
That demo is incredible, by the way. 👏
Just so I understand, when you say interpolating is "a tiny bit faster", do you mean it results in (slightly) better performance? I'm trying to understand if I should interpolate whenever I can (similar to using native whenever possible), or if the difference isn't noticeable.
I prefer the shorter syntax of your first code example but will adopt whatever approach results in the smoothest performance.
Your library is sweet and I want to use it properly. :)

Upfront interpolation has a small tax since it has to regexp the hell out of these strings to extract numeric data from it, but it isn’t that much.


how to set lr scheduler?

Hi
I'm getting this error when i'm trying to set a poly_lr scheduler
Traceback (most recent call last):
File "train.py", line 229, in
train(cfg, writer, logger)
File "train.py", line 86, in train
scheduler = get_scheduler(optimizer, cfg["training"]["lr_schedule"])
File "/media/grace/Drive2/work2/pytorch-semseg/ptsemseg/schedulers/init.py", line 48, in get_scheduler
return key2scheduler[s_type](optimizer, **scheduler_dict)
TypeError: init() takes at least 3 arguments (2 given)
Following is my config file
`model:
arch: icnetBN
data:
dataset: cityscapes
train_split: train
val_split: val
img_rows: 1025
img_cols: 2049
path: data/
training:
n_workers: 64
train_iters: 60000
batch_size: 8
val_interval: 500
print_interval: 25
loss:
    name: 'multi_scale_cross_entropy'
    size_average: True
optimizer:
    name: 'sgd'
    lr: 1.0e-2
    weight_decay: 0.0005
    momentum: 0.99
lr_schedule:
    name: 'poly_lr'
resume: icnet_cityscapes_best_model.pkl`

Can anyone help with this?

you need to set max_iter for poly_lr

Is the max_iter for poly_lr seem strange? After epoch exceeds max_iter, the factor becomes negative. If epoch is smaller than max_iter, lr seems not being updated.


Feature/enable browsersync customization

Coverage remained the same at 69.554% when pulling 91cbc98f4ffa45e8240de5abc98a6629efef02f1 on feature/enable-browsersync-customization into 4eaa43fd6f1f2576b78f9666989685c057c97094 on master.


updating twitter keyword vars

Are you a current Fivetran customer?

Fivetran Employee
What change(s) does this PR introduce?

Updating twitter_ads__using_keywords variables for default consistency
Did you update the CHANGELOG?

[x] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[ ] No  (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[ ] Yes

Is this PR in response to a previously created Bug or Feature Request

[x] Yes, Issue/Feature [#69]
[ ] No

How did you test the PR changes?

[x]Buildkite
[ ] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[x] BigQuery
[x] Redshift
[x] Snowflake
[x] Postgres
[x] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:dancer:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

[ ] Regenerate docs
[ ] Update Changelog
[ ] Update dbt projects (find out whether this is a patch or minor)


物体切割出现异常

您好，感谢。
我修改examples中的cloth_on_rigid.py代码为：
   cutter = scene.add_entity(
        morph=gs.morphs.Mesh(
            file="meshes/cross_cutter.obj",
            euler=(90, 0, 0),
            scale=0.8,
            pos=(0.5, 0.5, 0.2),
            fixed=True,
            convexify=False,
        ),
        surface=gs.surfaces.Iron(),
    )

    cloth = scene.add_entity(
        # material=gs.materials.PBD.Cloth(),
        material=gs.materials.MPM.Elastic(),
        morph=gs.morphs.Mesh(
            file="meshes/cloth.obj",
            scale=1.0,
            pos=(0.5, 0.5, 0.5),
            euler=(180.0, 0.0, 0.0),
        ),

        surface=gs.surfaces.Default(
            color=(0.6, 1.0, 0.8, 1.0),
        ),
    )

但是出现问题：

cloth.obj is a single-layer mesh, which is not suitable for MPM simulations. Typically, MPM is good at simulating volumetric objects.
For cutting an MPM object, cut_dragon.py serves as a good reference.
However, if your goal is to cut a piece of cloth, I’m sorry to inform you that this is not currently supported. The PBD solver used in the cloth simulator does not support fracture.

OK，thank you ！


Arithmetic optimizations

This pull request contains some meaningful optimizations in various calculations that result in more effecient code. Most of the changes are unrelated. Here's an outline of the changes:

Transform
The transform class is the one with the most changes, almost the whole thing is changed.
The old Transform class used a 2x2 matrix to represent rotation and 2 extra variables for translation. But because the only possible transforms are rotation and translation (no shear, scale etc) the 2x2 matrix is superfluous. It always contains [cos(theta)    -sin(theta)] and [sin(theta)    cos(theta)].
The new Transform class has just 2 members for rotation (cost and sint) which saves space and greatly simplifies calculations. Also some mathematic optimizations have been made by using some properties and rearrangement.

Vector2
Apart from some misc changes the most notable here is the new tripleProduct implementation.
Uses 4 multiplications instead of 8. This implementation is partially inlined in Gjk as well to slightly reduce the multiplications in the hot path of execution.

Gjk
See above; less multiplications in main detection code by taking advantage of the tripleProduct implementation.
Also rearrangment of some calculations that result in less multiplications.

Island
Not very important changes. In the step where the settings maximum values are enforced some improvements can be done so less things are re calculated.

Vector3
Really minor changes

If you have any questions I can explain in more detail

This looks really good.  Let me pull it down and do some testing.  All unit test pass right?

Hey William,
I checked the tests, there where three failing tests but they where not because of actual errors. I made a small change that makes one of those go away (TransformTest:319 expected 0.0 but got -0.0 which is the same anyway). The other two are:

CircleSliceTest.gjkDistance:330 expected:<0.449> but was:<0.45>
TransformTest.lerp:278 expected:<1.6323813093168174> but was:<1.6323813093168176>
The first one should be ok since it has an error delta 1.0e-3 (maybe the test fails because of small floating point inaccuracies) and the second is just a small change in precision coming from the new changes (possible solution is to add a small delta there as well?).
I don't know how you would prefer those to be resolved so I post this here for you to decide.

Yeah, it should compare using an appropriate delta.  I have to change these slightly sometimes too.

Finally got around to reviewing again.  This looks great - great finds in the Transform class for sure.


Head/Tail implementation is slow

Someone posted some benchmarks on twitter for us against a couple of other tools. head and tail were performing incredibly slow.
The culprit is column_partitions.  This is incredibly inefficient.
The same is true with tail.

Closed via #39


Support for group expression nesting

related pull request https://github.com/mysema/querydsl/pull/570
TODO Make sure that also the case of https://github.com/mysema/querydsl/issues/417 is supported

#570 was merged.


Adjust to latest gyroflow file format

Hi,
In latest dev build, and soon to be v1.5.1, I've changed the format of the extended data a bit. Instead of using bincode I now use standard CBOR, which should be easier to parse
If version == 3, then gyro_data = cbor2.decoder.loads(raw)
This was needed because we now have additional data from certain files, like per-frame offset, per-frame exposure time and hopefully soon per-frame lens profile information. Adding all these additional information using bincode would be pretty hard to parse in external tools, so I decided to switch to CBOR, which has parsers in all languages
raw_imu and quaternions fields were removed from gyro_source. Instead, there's now file_metadata there which contains:
pub struct FileMetadata {
    pub imu_orientation:     Option<String>,
    pub raw_imu:             Vec<TimeIMU>,
    pub quaternions:         TimeQuat,
    pub gravity_vectors:     Option<TimeVec>,
    pub image_orientations:  Option<TimeQuat>,
    pub detected_source:     Option<String>,
    pub frame_readout_time:  Option<f64>,
    pub frame_rate:          Option<f64>,
    pub camera_identifier:   Option<CameraIdentifier>,
    pub lens_profile:        Option<serde_json::Value>,
    pub lens_positions:      Option<TimeFloat>,
    pub has_accurate_timestamps: bool,
    pub additional_data:     serde_json::Value,
    pub per_frame_time_offsets: Vec<f64>,
    pub per_frame_data:      Vec<serde_json::Value>,
}

Additionally, I added:

synced_imu_timestamps - array of timestamps for every IMU sample, with added interpolated offsets
synced_imu_timestamps_with_per_frame_offset - same as above + per frame time offset, which involves exposure time and custom VSYNC offset from the file metadata - this is the final offset. The timestamps represent middle of the frame, ie. in case of 59.94 video, 0 is the middle row of first frame, 16.68 middle row of the second frame etc.
adaptive_zoom_fovs - per frame smoothed FOV for adaptive zoom

So instead of interpolating the offsets on your side in python, you can just use imu.timestamp = synced_imu_timestamps_with_per_frame_offset[imu_index]
file_metadata = cbor2.decoder.loads(zlib.decompress(decode(data['gyro_source']['file_metadata'])))
synced_imu_timestamps_with_per_frame_offset = cbor2.decoder.loads(zlib.decompress(decode(data['gyro_source']['synced_imu_timestamps_with_per_frame_offset'])))

samples.zip

GyroFlowToCSV.zip
updated, but not tested and only works with the new version, will need to be updated with ifs that check version to work with both new and old

Hi @AdrianEddy,

updated, but not tested and only works with the new version, will need to be updated with ifs that check version to work with both new and old

I finally tested out the revised GyroflowToCSV script you posted. To get the script to work successfully with Python v3.10.9 on my laptop I had to adjust the cbor2 function to use the cbor2._decoder.loads() instead of cbor2.decoder.loads().
Here is the modified python script should anyone else want to explore it:
GyroFlowToCSV.zip

In latest dev build I added an option to export camera data directly to CSV, JSON, USD or JSX (for AE) from Gyroflow. Please test if it works as expected for you.
I also have a question - what's the use case for this data? Since this only exports camera rotations, and not translations, it doesn't replace 3D camera tracker. Is there a way to use rotations and then track translations only?
https://gyroflow.xyz/devbuild/ Motion Data -> Export -> Export camera data

Thanks for adding the native data export options to GyroFlow. This will make things far more accessible for end users!

My primary interest in the GyroFlow CSV/JSON/USD data export options is to use the motion data to help with spherical video rotational stabilization for 180VR/360VR post-production workflows.


Deploy flexvolume by DaemonSet

Workflow:
    cat >flexvolume-configmap.yaml <<EOF
kind: ConfigMap
apiVersion: v1
metadata:
  name: flexvolume-config
  namespace: kube-system
data:
  auth-url: "https://${SERVICE_HOST}/identity_admin/v2.0"
  username: "admin"
  password: "${ADMIN_PASSWORD}"
  tenant-name: "admin"
  region: "RegionOne"
EOF
    kubectl create -f flexvolume-configmap.yaml
    kubectl create -f ${FRAKTI_ROOT}/deployment/flexvolume/flexvolume-ds.yaml

The /usr/libexec/kubernetes/kubelet-plugins/volume/exec/cinder~flexvolume_driver/ should be created automatically with binary inside.
And /etc/kubernetes/cinder should have also be created with right content.

This change is

@feiskyer addressed review comments

/lgtm