MQTT Cover Tilt State Not Reflecting Correctly

**Home Assistant release (hass --version): 0.45.1
**Python release (python3 --version): Python 3.4.2
**Component/platform: MQTT Cover Tilt
Description of problem:
Hello,
I'm having an issue with the tilt aspect of the MQTT cover component working correctly. There are a few issues.
When I toggle the blinds via the main arrow, the open MQTT message is sent. The state updates to "open" and the blinds respond correctly. However, the tilt state does not update. It remains at zero. This happens in optimistic mode as well.

The tilt status of blinds in the slider and state does not appear to update based on any message received from the blinds. It only jumps to the ends of the slider based on the direction of the arrow you hit.

In my case, the top end of my slider value is 200 (which is fully open to the top) and when I hit the tilt arrow up, the blinds move to 100 (my tilt_opened_value). However, the slider in the front end shows that it is all the way over to the right. If I drag it around a few spots, the slider reports 200 and send the appropriate MQTT message.

It is a little strange to me to have two set of arrows in the UI card for the MQTT cover component. I understand that the tilt service is different and that people may want to be both. However, there is not really a case for wanting to use the default MQTT cover component with the MQTT cover tilt component at the same time. I think it just makes it more confusing. Is there anyway we can use just the MQTT tilt arrows and bypass the main open/close arrows?

Problem-relevant configuration.yaml entries and steps to reproduce:
cover:
  - platform: mqtt
    state_topic: "bruh/blind1/cover/state"
    command_topic: "bruh/blind1/cover/command"
    name: "blinds1"
    qos: 0
    retain: true
    payload_open: "OPEN"
    payload_close: "CLOSE"
    payload_stop: "STOP"
    state_open: "OPEN"
    state_closed: "CLOSE"
    optimistic: false
    value_template: '{{ value }}'
    tilt_command_topic: "bruh/blind1/cover/tilt"
    tilt_state_topic: "bruh/blind1/cover/tilt-status"
    tilt_min : 0
    tilt_max: 200
    tilt_opened_value : 100
    tilt_closed_value : 0

Thanks much for the help! Super excited to share the project as soon as I can work out the bugs. Cheers!

Hey @robbiet480 and @cribbstechnologies. Sorry to be aggressive and tag you guys.
I can use the component as-is for my Blinds V2 project, but it would be nice to work out the user experience a little more. If you have thoughts about debugging this, let me know.
Cheers!

The up/down arrows not in the more-info view are for raising and lowering the cover. The diagonal arrows in the more-info view are for tilting. The way the component is coded right now there's no reporting of open/close functionality to the UI and the component class always assumes the open/close is configured.
My blinds are 0-180 but I only use 100-180 because I don't care about the lower portion of movement so my tilt_min and tilt__opened_value (I'm inverted) are the same and similarly for the other set of values. There are likely a bunch of edge cases outside of my configuration I didn't test. I'm leaving the country on the 6th but if I find some time between now and then to work on this I'll see what I can do.

PR issued to make command_topic optional as well as supporting of set-position for up/down position
https://github.com/home-assistant/home-assistant/pull/7841
I've got the UI updated to show/hide up/down and tilt controls based on supported features (but it looks like hell)

I'm trying to figure out how to make whatever shows up be right-aligned. Once that's done I'll issue a PR for that and update the docs for the .io site and issue a PR for that

Nice! Just as an update, me and @cribbstechnologies worked through my typos and resolved the state updating issue. The pull fixes the dual arrows and cleans up the UI nicely. Once #7841 gets merged, I'll be good to go. Thanks much for the help!


Error on checkoutPaymentCreate GraphQL

What I'm trying to achieve
I'm traying to create a checkout payment throught checkoutPaymentCreate with a GraphQL request. There is an error that says: Couldn't resolve to a node: 41eb582e-9d70-4195-a71a-cc41b4019e09 but that checkoutId exists on the checkout table.
Request:
mutation{
  checkoutPaymentCreate(checkoutId: "41eb582e-9d70-4195-a71a-cc41b4019e09", input:{
    gateway:"DUMMY",
    token: "41eb582e-9d70-4195-a71a-cc41b4019e09",
    amount: 1,
    billingAddress:{
      firstName:"Name",
      lastName: "Last",
      companyName: "Company",
      streetAddress1: "Street 1",
      streetAddress2: "Street 2",
      city: "city",
      cityArea: "area",
      postalCode: "10093",
      country: "country",
      countryArea: "area",
      phone: "66884894"
    }
  }){
    paymentErrors{
        field
        message
        code
    }
  }
}

Response:
{
    "data": {
        "checkoutPaymentCreate": {
            "paymentErrors": [
                {
                    "field": "checkoutId",
                    "message": "Couldn't resolve to a node: 41eb582e-9d70-4195-a71a-cc41b4019e09",
                    "code": "NOT_FOUND"
                }
            ]
        }
    }
}

@srendon Here you have the right solution https://github.com/mirumee/saleor/issues/4768#issuecomment-535663996.
You can use the following query to get a checkout ID:
{
  checkout(token: "41eb582e-9d70-4195-a71a-cc41b4019e09") {
    id
  }
}

@srendon Here you have the right solution #4768 (comment).
You can use the following query to get a checkout ID:
{
  checkout(token: "41eb582e-9d70-4195-a71a-cc41b4019e09") {
    id
  }
}

Thank you @bogdal that solved my problem.


node warning about punycode

Description
When I run myst start, I get a warning - no issues running, just a warning:
(node:12596) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Seems to be an issue only on node version >=21 (https://stackoverflow.com/questions/68774489/punycode-is-deprecated-in-npm-what-should-i-replace-it-with).
Proposed solution
Additional notes

Tried to actually fix this tonight, couldn't get of node-fetch cjs version, and this isn't going to be updated.
https://github.com/node-fetch/node-fetch/pull/1793
Instead I quieted the error in a few places. Should be ok for a CLI to not show these.


Using AWS S3 for persistent storage of OAuth tokens giving ClientError (Access Denied)

Hello again! 😅 I have had some success implementing the S3 storage for OAuth tokens and installation, however have run into an issue I'm not quite sure how to solve. I come across this issue when trying to navigate to the .../slack/install link: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied
I thought this might be a permissions issue so I added these permissions to the bucket:
{
    "Version": "2012-10-17",
    "Id": "redacted",
    "Statement": [
        {
            "Sid": "redacted",
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::user-num:my-user-name"
            },
            "Action": "s3:*",
            "Resource": "arn:aws:s3:::my-bucket-name"
        }
    ]
}

I also tried setting actions to:
"s3:PutObject",
"s3:PutObjectAcl",
"s3:GetObject",
"s3:GetObjectAcl",
"s3:DeleteObject"

And this allowed me to manually add and remove files and folders from the bucket, but the slack application was still giving me an access denied error.
I have my code setup like this:
s3_client = boto3.client("s3", aws_access_key_id=AWS_ACCESS_KEY_ID, aws_secret_access_key=AWS_SECRET_ACCESS_KEY)
state_store = AmazonS3OAuthStateStore(
        s3_client=s3_client,
        bucket_name=os.environ["SLACK_STATE_S3_BUCKET_NAME"],
        expiration_seconds=600,
    )
oauth_settings = ...,
        installation_store=AmazonS3InstallationStore(
                s3_client=s3_client,
                bucket_name=os.environ["SLACK_INSTALLATION_S3_BUCKET_NAME"],
                client_id=os.environ["SLACK_CLIENT_ID"],
           ),
        ...

app = App(
    process_before_response=True,
    signing_secret=os.environ.get("SLACK_SIGNING_SECRET"),
    oauth_settings=oauth_settings,
    oauth_flow=LambdaS3OAuthFlow(),
)

My settings.py file looks like this (though I only reference a few things from here, I normally reference straight from .env file:
AWS_ACCESS_KEY_ID = os.getenv("AWS_ACCESS_KEY_ID", None)
AWS_SECRET_ACCESS_KEY = os.getenv("AWS_SECRET_ACCESS_KEY", None)
SLACK_STATE_S3_BUCKET_NAME = os.getenv("SLACK_STATE_S3_BUCKET_NAME", None)
SLACK_INSTALLATION_S3_BUCKET_NAME = os.getenv(
    "SLACK_INSTALLATION_S3_BUCKET_NAME", None
)
SLACK_LAMBDA_PATH = os.getenv("SLACK_LAMBDA_PATH", None)

The slack application .settings portion of the error page shows that all of these variables are being initialized correctly.
Any help understanding my issue would be much appreciated!
Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version
slack-bolt==1.6.1
slack-sdk==3.8.0
slackclient==2.9.3
slackeventsapi==2.2.1
Python runtime version
Python 3.9.6
OS info
Darwin Kernel Version 20.5.0: Sat May  8 05:10:31 PDT 2021; root:xnu-7195.121.3~9/RELEASE_ARM64_T8101
Steps to reproduce:
Currently this is running on a docker container, but I imagine any slack application would reproduce the issue if the code setup was the same as I have pasted above.
Expected result:
The application should be able to store OAuth tokens and installation data to the AWS S3 bucket.
Actual result:
:(

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hello @JasonDykstraSelectStar !
This definitely looks like an S3 bucket permission issue.
Your permissions look fine, though one thing that jumped out at me: it seems like there are two S3 buckets at play : SLACK_STATE_S3_BUCKET_NAME and SLACK_INSTALLATION_S3_BUCKET_NAME. Are you sure your user has permissions to both of these buckets?

Hey @filmaj ! Thanks for the quick reply! I have both of these names initialized to the same bucket, as I was following this example. I suppose I could change those two variables to both be the same thing for the sake of confusion.

Do you have the aws CLI tool installed by any chance? It would be nice to confirm via another method that your AWS credentials have access to the buckets. If you don't have them installed, installation instructions for the AWS CLI are here.
Then you can run something like this to list buckets for your account:
AWS_ACCESS_KEY_ID="<your-access-key>" AWS_SECRET_ACCESS_KEY="<your-access-secret>" AWS_DEFAULT_REGION="your-aws-region" aws s3 ls

First check if the bucket(s) you are setting as your state and installation locations is listed via the aws s3 ls command. If you can see the bucket names you specified for the state/installation locations, next let's test if you can upload to these buckets by running:
AWS_ACCESS_KEY_ID="<your-access-key>" AWS_SECRET_ACCESS_KEY="<your-access-secret>" AWS_DEFAULT_REGION="your-aws-region" aws s3 cp some-file s3:///name-of-your-bucket

So I have permissions s3:* so I should be able to list buckets, however upon executing aws s3 ls I get An error occurred (AccessDenied) when calling the ListBuckets operation: Access Denied. Also when I try the second command, when I enter the bucket name or the ARN, I get Invalid bucket name "": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]+:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$" Perhaps I need to look elsewhere to set permissions?

So I have permissions s3:* so I should be able to list buckets, however upon executing aws s3 ls I get An error occurred (AccessDenied) when calling the ListBuckets operation: Access Denied.

OK, given the assumption you gave your user all permissions, let's focus on solving listing buckets first.
Let's check which user is associated with the access key you are using. You can do that by running:
AWS_ACCESS_KEY_ID="<your-access-key>" AWS_SECRET_ACCESS_KEY="<your-access-secret>" aws iam get-user

The Arn output of the above command MUST exactly match your policy statement's Principal.AWS property. Looking at your Principal AWS property as you posted in your original post, you have arn:aws:iam::user-num:my-user-name - I assume this is a placeholder, but usually user ARNs are prefixed with user/ before the username, i.e. arn:aws:iam::account-num:user/my-user-name. Perhaps that is it?
I also noticed something just now that the Resource section of your policy only references the bucket name, and not any path within the bucket. This may also be the issue. Usually to provide general sweeping permissions to S3 buckets, including the ability to upload to any key within the bucket, I use a policy that looks like this:
        Statement: [ {
          Effect: 'Allow',
          Action: [
            's3:*'
          ],
          Resource: [
            'arn:aws:s3:::my-bukkit',
            'arn:aws:s3:::my-bukkit/*'
          ]
        } ]

Maybe try using a similar approach to the Resource property in your policy as well?

Hey! So an update on the problem: my user (from doing aws iam get-user) is the same as on the Principal.AWS policy. The address was indeed arn:aws:iam::account-num:user/my-user-name I just didn't properly convey that in the original comment. The action section of the bucket policy is set to s3:* and the resources matches what you have above, with both ...my-bukkit and ...my-bukkit/*.
I've called AWS since I still get an access denied issue when trying to list buckets with my account, even after given admin status on AWS. Support told me the issue was probably related to the CLI so they will look into it and get back to me.

OK, sounds good. 🤞

So the issue was that another permission Force-MFA was taking priority, and since commands issued through the CLI did not have multi-factor authentication by default, it was returning a permission denied error. My solution for this was to create a custom permission in AWS that does not require MFA, but perhaps there is a solution for this through Bolt if someone happens to stumble across this issue in the future?

@JasonDykstraSelectStar Thanks for sharing your updates here! Yes, as you corrected yourself, if you set the OAuthFlow to App, the initialization of OAuthFlow requires the properly configured OAuthSettings values.
If I understand correctly, it seems that everything is clear now. Would you mind if we close this issue now?

Yep, sounds good! Thanks again for your help @filmaj


Mining<PHONE_NUMBER>854775808 rocks creates a negative stack size

Reproduced on windows 10, did it twice just to make sure

Download https://github.com/EclipsedMango/EpicSurvivalGame/releases/tag/v0.0.2-alpha
Extract the zip file into a folder
Open the folder
Double click on executable file
Click the play button
Mine a rock and pick up the item
Repeat step 6<PHONE_NUMBER>854775807 more times

You will now have a negative stack size.


Fix typo in  polybase update docs

Docs have a typo in the update polybase process. This edit fixes the typo

@L1ghtman2k : Thanks for your contribution! The author(s) have been notified to review your proposed change.


refactor(abc): remove _undefined in favour of MISSING

Summary
This PR removes the unnecessary _undefined sentinel from abc.py in favor of MISSING. This attribute was used internally, so this will not be a breaking change for users. Closes #840.
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have run task pyright and fixed the relevant issues.

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Instead of aliasing MISSING just from .utils import MISSING

I think this would be well suited for another refactor because there are quite a few files that use the same alias.

Instead of aliasing MISSING just from .utils import MISSING

This will be fixed in #842.

This will be fixed in #842.

I don't see why not fix it here, not doing this in this PR would stall the other PR?

^, why not import normally in your PR, this would still be properly scoped.

This will be fixed in #842.

I don't see why not fix it here, not doing this in this PR would stall the other PR?

This PR does not edit the import, so it is not conflicting with the other

This will be fixed in #842.

I don't see why not fix it here, not doing this in this PR would stall the other PR?

This PR does not edit the import, so it is not conflicting with the other

I get it.
Resolved in 2b777c4

Should there be an alias of _undefined to MISSING, similar to the EmptyEmbed issue, in order to not make it a breaking change. This could be breaking if someone were to be manually passing _undefined to set_permissions as a default?
I suppose the thinking is that, as it is underscore-prefixed it's not part of the public API, so that's somebody else's problem. If so, that's fine by me.

I don't think there should be an alias because yeah it's not under the public API.


How can edit yaw value of points？

After the robot reaches a point of interest, it needs to turn the direction angle. How to set these directions in the traffic editor？

Hi @mbb1234567890, based on my current experience there are two ways to achieve this behavior without modifying the nav_graph, it doesn't store any orientation information. The workarounds I did are as follows, depending on the situation.

Use a GoToPlace directly (api_request as robot_task) or define a sequence of such and send it to dispatcher instead of Loop task. In the GoToPlace task description, you can define an orientation attribute.

Use the dock capability if you still want to use loop task, the robot will reach the point (wp1) leading up the waypoint (wp2) with the dock_name defined and call the dock() function in the fleet adapter. In this way, before the dock() function is called, the robot will be at wp1 and pointing towards wp2.

but I read from somewhere this feature might get reworked
I would recommend try out the first approach. Maybe the maintainer has better solution and correct me if I am wrong. I am also very interested in how to properly control the end point orientation in rmf.

Hi @Briancbn ，I also agree the first approach，but where can define the orientation attribute? It can't be hard code for every point. How to make the nav_graph to be a semantic map?

I also agree the first approach，but where can define the orientation attribute?

You can try it out by defining it over here like the following
https://github.com/open-rmf/rmf_demos/blob/459919bb8617a8344a7d456c3c054baca6b39b68/rmf_demos_tasks/rmf_demos_tasks/dispatch_go_to_place.py#L101
        # Define task request description
        go_to_description = {'waypoint': self.args.place,
                             'orientation': 0.0}

How to make the nav_graph to be a semantic map?

I don't know the answer to this.

Thanks @Briancbn

No, that parameter does not represent a yaw value that a robot must respect at that vertex.
To have you robot arrive at a waypoint with a specific yaw, you can add an orientation value to the GoToPlace request in your task as @Briancbn has explained above.
If you have any alignment/docking routines you robot can perform to achieve precise positioning/orientation, you may couple the GoToPlace activity with a PerformAction one which will allow you to run any custom routine from your fleet adapter once at that waypoint. Alternatively, you can also assign a dock property to that waypoint in traffic-editor and have your fleet adapter implement the dock() callback to perform any such routine. However, it is recommended not to use the dock method unless the waypoint is a leaf waypoint in the graph, ie, it only connects to one other waypoint and ideally does not overlap with any other traffic lanes.

Hi @Yadunund  thanks for explain.
I hope to rely on open-rmf to schedule the robot to head towards the specified direction after arriving at the specified waypoint. I hope that the waypoint and the direction only need to be edited once in the traffic-editor. When the waypoint is a passing point, the robot does not need to consider the direction. When the waypoint is the target point, need to finally turn to the specified direction.
The GoToPlace solution mentioned above needs to pass in an additional orientation parameter. If this parameter is not edited in xxx.building.yaml, the program cannot automatically obtain the binding relationship.
So I would very much like to edit the direction property of the waypoints in the traffic-editor.

Use another configuration file to record waypoint orientation information to solve this problem


gpt3small is broken

gpt3small seems to have been left behind in some of our updates, and neither scripts/train_gpt3small.sh nor scripts/train_gpt3small_pipeline.sh run.

scripts/train_gpt3small.sh is running at my colab (I only dropped the train batch size because of OOM)..

scripts/train_gpt3small.sh is running at my colab (I only dropped the train batch size because of OOM)..

scripts/train_gpt3small.sh is running at my colab (I only dropped the train batch size because of OOM)..

Interesting. Can you provide a link to the file?

scripts/train_gpt3small.sh is running at my colab (I only dropped the train batch size because of OOM)..

Interesting. Can you provide a link to the file?

https://colab.research.google.com/drive/1IThG90kOdndybKuScNEZ1QG9nwnuj2l1?usp=sharing
there is some problem with the pipeline code. I'm trying fixing it. something with
num_stages (2) must divide distributed world size (1)

https://colab.research.google.com/drive/1IThG90kOdndybKuScNEZ1QG9nwnuj2l1?usp=sharing
there is some problem with the pipeline code. I'm trying fixing it. something with
num_stages (2) must divide distributed world size (1)

Ah yes, you cannot use parallel pipeline on a single GPU unit. The whole
point of parallel pipeline is to divide the pipeline between GPUs, which
you cannot do. You can manually set num_stages to 1, or you can use the
non-pipeline code.
On Wed, Jan 20, 2021 at 11:15 PM srulikbd<EMAIL_ADDRESS>wrote:

https://colab.research.google.com/drive/1IThG90kOdndybKuScNEZ1QG9nwnuj2l1?usp=sharing
there is some problem with the pipeline code. I'm trying fixing it.
something with
num_stages (2) must divide distributed world size (1)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/EleutherAI/gpt-neox/issues/71#issuecomment-764248263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZJVMBDQ76DLXFSFZZAWVDS26S75ANCNFSM4WHTG4SA
.

Ah yes, you cannot use parallel pipeline on a single GPU unit. The whole
point of parallel pipeline is to divide the pipeline between GPUs, which
you cannot do. You can manually set num_stages to 1, or you can use the
non-pipeline code.
On Wed, Jan 20, 2021 at 11:15 PM srulikbd<EMAIL_ADDRESS>wrote:

https://colab.research.google.com/drive/1IThG90kOdndybKuScNEZ1QG9nwnuj2l1?usp=sharing
there is some problem with the pipeline code. I'm trying fixing it.
something with
num_stages (2) must divide distributed world size (1)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/EleutherAI/gpt-neox/issues/71#issuecomment-764248263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZJVMBDQ76DLXFSFZZAWVDS26S75ANCNFSM4WHTG4SA
.

ok, what I suspected. thanks!
how can I help right now?
I saw that we need kubernetes skills, so I'm learning it.
anything else for a newcomer?

ok, what I suspected. thanks!
how can I help right now?
I saw that we need kubernetes skills, so I'm learning it.
anything else for a newcomer?

Have you checked out the Evaluation Harness? That is extremely
important to both this project and other ones, and is more accessible to
people who can write code but are newcomers to AI research. Each task that
needs completing has an associated Issue.
On Wed, Jan 20, 2021 at 11:53 PM srulikbd<EMAIL_ADDRESS>wrote:

ok, what I suspected. thanks!
how can I help right now?
I saw that we need kubernetes skills, so I'm learning it.
anything else for a newcomer?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/EleutherAI/gpt-neox/issues/71#issuecomment-764311425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZJVMBE72SG77DM3M7KYG3S26XMFANCNFSM4WHTG4SA
.

Have you checked out the Evaluation Harness? That is extremely
important to both this project and other ones, and is more accessible to
people who can write code but are newcomers to AI research. Each task that
needs completing has an associated Issue.
On Wed, Jan 20, 2021 at 11:53 PM srulikbd<EMAIL_ADDRESS>wrote:

ok, what I suspected. thanks!
how can I help right now?
I saw that we need kubernetes skills, so I'm learning it.
anything else for a newcomer?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/EleutherAI/gpt-neox/issues/71#issuecomment-764311425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZJVMBE72SG77DM3M7KYG3S26XMFANCNFSM4WHTG4SA
.


multiple header grid

It would be nice to have a way to declare a multiple level header for a table grid in which the last level in the deaders determines the column type, and other options.
Thank you for your work!

Thank you for the valuable request!

BTW multiple row header is already possible to implement with headerRowRenderer:
    headerRowRenderer: function() {
        var $result = $("<tr>")
            .append($("<th>").attr("colspan", 2).text("Name"));

        return $result.add($("<tr>")
            .append($("<th>").text("First Name"))
            .append($("<th>").text("Last Name")));
    }

See the fiddle:
http://jsfiddle.net/tabalinas/k9935wn3/

Sorry, but does not work sorting by columns.

 Like in the following fiddle http://jsfiddle.net/tabalinas/k9935wn3/3/

Thank you!!!

And again. Please see special case - http://jsfiddle.net/RedScorp/3q24e6fn/
Your example: full working.
My example: column "date" and "contacts" without sorting. I do not understand - how to add the right conditions.

It doesn't work in in your case because you don't attach the handlers to th with rowspan.
Just attach click handlers on your th.
$("<th>").attr("rowspan", 2).text("Id").on("click", function() { grid.sort(index); });

Good morning.
I have added your line in "append" and received an error - variable "index" is not found.
Hmmm. Okey, I added index manually, and - It worked!
http://jsfiddle.net/RedScorp/3q24e6fn/3/
$result = $result.add($("<tr>")
  .append($("<th>").attr("rowspan", 2).text("Id").on("click", function() { grid.sort(0); }))
  .append($("<th>").attr("rowspan", 2).text("Date").on("click", function() { grid.sort(1); }))
  .append($("<th>").attr("colspan", 2).text("FullName"))
  .append($("<th>").attr("colspan", 2).text("ColAB"))
  .append($("<th>").attr("rowspan", 2).text("Contacts").on("click", function() { grid.sort(6); }))
);

Thank you! Thanks for your work!

And the next question: "sortDescClass" (.jsgrid-header-sort .jsgrid-header-sort-asc .jsgrid-header-sort-desc) is used for the first  in a row, with a height of (0). How to move the class to the second row?
For example: http://jsfiddle.net/RedScorp/3e1vvhvb/1/
Thanks.

Good question. As this scenario is not build-in, you have to put a workaround:
Add _setSortingCss to the grid config:
    _setSortingCss: function() {
        var fieldIndex = $.inArray(this._sortField, this.fields); // this is how you know the sorting field index

        // add css class to the header cell. You can identify it by fieldIndex.
        $yourHeaderCell.addClass(this._sortOrder === "asc" ? this.sortAscClass : this.sortDescClass);
    },

To get access to the $yourHeaderCell save $header rows that you create in headerRowRenderer to this (in current case this is a grid).

I have a question, does anyone know how to add rowspan to the rows of my table? Not to the header, if not to the rows, so that it has for years grouped a value and appears the combined cell.
Like this in the row 13 and 14

@llopez91, this can be achieve with rowRenderer.

Hi tabalinas, can you show me how to do?, Thanks :)


[HUDI-2062] Catch IOException in WriteProfiles #getCommitMetadataSafely

Catch IOException in WriteProfiles #getCommitMetadataSafely
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #3138 (0b32830) into master (2687eab) will decrease coverage by 13.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #3138       +/-   ##
============================================
- Coverage     16.53%   3.13%   -13.41%
+ Complexity      468      82      -386
============================================
  Files           274     274
  Lines         10649   10649
  Branches       1088    1088
============================================
- Hits           1761     334     -1427
- Misses         8730   10289     +1559
+ Partials        158      26      -132

Flag
Coverage Δ

hudiclient
0.00% <ø> (ø)

hudisync
6.72% <ø> (ø)

hudiutilities
9.52% <ø> (-48.89%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2687eab...0b32830. Read the comment docs.

@yuzhaojing The flaky test cases seem to be fixed yesterday. You can try to pull --rebase with the master to see if we can make the CI pass. WDYT?

@yuzhaojing The flaky test cases seem to be fixed yesterday. You can try to pull --rebase with the master to see if we can make the CI pass. WDYT?

Ok, CI is passed.


fix a typo in Azure provider auth config script

Closes #
📑 Description

✅ Checks

✅ My pull request adheres to the code style of this project
✅ My code requires changes to the documentation
✅ I have updated the documentation as required

[ ] All the tests have passed

No. Only changed one line in doc, do we have to run a CI?

ℹ Additional Information

@AlexsJones
Hi Alex, I found a typo in Azure provider config script when trying k8sgpt. Please take a look at this PR.
Let me know if I need to do anything else to get the PR right.
Thanks!

Merging is blocked since commit needs to be signed. I am trying to figure out how to unblock.


TGP-2086: commodity code expired day

See https://github.com/hmrc/trader-goods-profiles-frontend/pull/373 for previous approvals


[bugfix] Metric not logged properly in manual optimization

What does this PR do?

Fixes #7206 #6833
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Hello @tchaton! Thanks for opening this PR.

In the file tests/trainer/optimization/test_manual_optimization.py:

Line 1281:30: W292 no newline at end of file

Do see the Hitchhiker's guide to code style


Enhance modularity by providing additional module options for various functionality

What would you like to be added:
Introduce the capability to modularize different functionalities within the Editor page. For instance, instead of solely supporting Markdown documents, consider adding modules for spreadsheets or whiteboards as additional options.
One potential approach to providing modularization settings could be exploring options similar to the configuration file offered by Docusaurus.
Why is this needed:
This would allow users to customize the modules based on their requirements.
Additional Information:

Offer a more diverse range of functionalities within the Editor page to cater to different user needs.
Provide flexibility and customization options for users to enhance their editing experience.

The introduction of the module can consider the message-based structure used in Summernote.
Reference link: https://github.com/summernote/summernote/blob/develop/plugin/hello/summernote-ext-hello.js


Connection dialog broken in Insiders if ConnectionProvider doesn't exist

Issue Type: Bug
Update: this happens if you have a postgres connection listed in the Connections view and the extension isn't installed. The capabilities service breaks as it returns an undefined object:
const options = this.capabilitiesService.getCapabilities(model.providerName).connection.connectionOptions;

This is on my Mac & Insiders. Anything that tries to show the connection dialog is completely busted from the Connections view (click + button) and SQL Query window (click "Connect"). Somehow it works from Notebook.
Looking at debug console I see the following error:
Unhandled Promise rejection: Cannot read property 'connection' of undefined ; Zone: <root> ; Task: null ; Value: TypeError: Cannot read property 'connection' of undefined
    at new ConnectionProfile (workbench.main.js:158329)
    at configValues.map.c (workbench.main.js:159245)
    at Array.map (<anonymous>)
    at ConnectionStore.convertConfigValuesToConnectionProfiles (workbench.main.js:159243)
    at ConnectionStore.getRecentlyUsedConnections (workbench.main.js:159240)
    at ConnectionManagementService.getRecentConnections (workbench.main.js:208695)
    at Promise (workbench.main.js:313042)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.doShowDialog (workbench.main.js:313041)
    at Promise (workbench.main.js:312979)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.showDialogWithModel (workbench.main.js:312977)
    at Promise (workbench.main.js:313006)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.showDialog (workbench.main.js:312999)
    at Promise (workbench.main.js:208275)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionManagementService.showConnectionDialog (workbench.main.js:208268)
    at ToggleConnectDatabaseAction.connectEditor (workbench.main.js:174687)
    at ToggleConnectDatabaseAction.run (workbench.main.js:174949)
    at ActionRunner.runAction (workbench.main.js:11283)
    at ActionRunner.<anonymous> (workbench.main.js:11274)
    at Generator.next (<anonymous>)
    at workbench.main.js:5809
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at __awaiter (workbench.main.js:5805)
    at ActionRunner.run (workbench.main.js:11268)
    at ActionViewItem.onClick (workbench.main.js:67817)
    at Immediate.platform.setImmediate [as _onImmediate] (workbench.main.js:67792)
    at runCallback (timers.js:696)
    at tryOnImmediate (timers.js:667)
    at processImmediate (timers.js:649) TypeError: Cannot read property 'connection' of undefined
    at new ConnectionProfile (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:158329:97)
    at configValues.map.c (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159245:47)
    at Array.map (<anonymous>)
    at ConnectionStore.convertConfigValuesToConnectionProfiles (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159243:33)
    at ConnectionStore.getRecentlyUsedConnections (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159240:25)
    at ConnectionManagementService.getRecentConnections (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208695:42)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313042:79)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.doShowDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313041:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312979:22)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.showDialogWithModel (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312977:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313006:30)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.showDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312999:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208275:47)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionManagementService.showConnectionDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208268:20)
    at ToggleConnectDatabaseAction.connectEditor (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:174687:46)
    at ToggleConnectDatabaseAction.run (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:174949:22)

From Connect view:

console.(anonymous function) @ /Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
check @ workbench.main.js:9736
_event @ workbench.main.js:9797
set providerName @ workbench.main.js:158093
createFromStoredProfile @ workbench.main.js:158486
profiles.map.p @ workbench.main.js:158688
getConnections @ workbench.main.js:158687
getConnectionProfileGroups @ workbench.main.js:159357
getConnectionGroups @ workbench.main.js:208692
getAllServerGroups @ workbench.main.js:312581
initDialog @ workbench.main.js:312598
handleInitDialog @ workbench.main.js:312938
_connectionDialog.onInitDialog @ workbench.main.js:313024
fire @ workbench.main.js:9844
initDialog @ workbench.main.js:237493
onProviderTypeSelected @ workbench.main.js:237349
updateProvider @ workbench.main.js:237512
doShowDialog @ workbench.main.js:313036
Promise @ workbench.main.js:312979
ZoneAwarePromise @ /Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891
showDialogWithModel @ workbench.main.js:312977
Promise @ workbench.main.js:313006
ZoneAwarePromise @ /Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891
showDialog @ workbench.main.js:312999
Promise @ workbench.main.js:208275
ZoneAwarePromise @ /Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891
showConnectionDialog @ workbench.main.js:208268
run @ workbench.main.js:194093
runAction @ workbench.main.js:11283
(anonymous) @ workbench.main.js:11274
(anonymous) @ workbench.main.js:5809
ZoneAwarePromise @ /Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891
__awaiter @ workbench.main.js:5805
run @ workbench.main.js:11268
onClick @ workbench.main.js:67817
platform.setImmediate @ workbench.main.js:67792
runCallback @ timers.js:696
tryOnImmediate @ timers.js:667
processImmediate @ timers.js:649
/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280 Unhandled Promise rejection: Cannot read property 'connection' of undefined ; Zone: <root> ; Task: null ; Value: TypeError: Cannot read property 'connection' of undefined
    at new ConnectionProfile (workbench.main.js:158329)
    at configValues.map.c (workbench.main.js:159245)
    at Array.map (<anonymous>)
    at ConnectionStore.convertConfigValuesToConnectionProfiles (workbench.main.js:159243)
    at ConnectionStore.getRecentlyUsedConnections (workbench.main.js:159240)
    at ConnectionManagementService.getRecentConnections (workbench.main.js:208695)
    at Promise (workbench.main.js:313042)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.doShowDialog (workbench.main.js:313041)
    at Promise (workbench.main.js:312979)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.showDialogWithModel (workbench.main.js:312977)
    at Promise (workbench.main.js:313006)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionDialogService.showDialog (workbench.main.js:312999)
    at Promise (workbench.main.js:208275)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at ConnectionManagementService.showConnectionDialog (workbench.main.js:208268)
    at AddServerAction.run (workbench.main.js:194093)
    at ActionRunner.runAction (workbench.main.js:11283)
    at ActionRunner.<anonymous> (workbench.main.js:11274)
    at Generator.next (<anonymous>)
    at workbench.main.js:5809
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891)
    at __awaiter (workbench.main.js:5805)
    at ActionRunner.run (workbench.main.js:11268)
    at ActionViewItem.onClick (workbench.main.js:67817)
    at Immediate.platform.setImmediate [as _onImmediate] (workbench.main.js:67792)
    at runCallback (timers.js:696)
    at tryOnImmediate (timers.js:667)
    at processImmediate (timers.js:649) TypeError: Cannot read property 'connection' of undefined
    at new ConnectionProfile (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:158329:97)
    at configValues.map.c (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159245:47)
    at Array.map (<anonymous>)
    at ConnectionStore.convertConfigValuesToConnectionProfiles (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159243:33)
    at ConnectionStore.getRecentlyUsedConnections (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159240:25)
    at ConnectionManagementService.getRecentConnections (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208695:42)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313042:79)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.doShowDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313041:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312979:22)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.showDialogWithModel (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312977:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:313006:30)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionDialogService.showDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:312999:20)
    at Promise (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208275:47)
    at new ZoneAwarePromise (/Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:891:29)
    at ConnectionManagementService.showConnectionDialog (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:208268:20)
    at AddServerAction.run (file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:194093:47)

Azure Data Studio version: Azure Data Studio 1.9.0-insider (a79f1ac830e3cb99130a21797a48d8db76fda4a0, 2019-06-13T07:15:23.201Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.35GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I'm not able to repro this on master and Insiders on Windows. Can someone else with a mac verify if they also see this issue?

Charles - I put out a PR and clarified the issue is if you remove the PGSQL extension but still have PGSQL connections (say in recent connections).


Add Apple ARM instructions

Description of the problem

Installation instructions for Apple ARM were not available

Description of the solution

Make a first version available

@tonielgeitani  you will be the guinea pig

@tonielgeitani Can you check if the newer version is clearer? I added the missing (weird) details


Navigation: Improve accessibility (#4651, #4755, #4756)

Description
Implemented accessibility recommendations for MudNavGroup, MudNavMenu, and MudNavLink.
The main goal of this PR is to improve/fix keyboard navigation in navigation blocks and to address the issues linked below.
I introduced a NavigationContext that allows passing state down a navigation group chain which allows us to figure out whether buttons/links at a specific level of the chain should be focusable via keyboard navigation.
Usage of tabindex, aria-label, aria-expanded, aria-hidden, aria-controls attributes should now be better (but not necessarily perfect).
I also had to change the Localizer API to accept arguments which can be quite useful (passing a value to a longer translation to include it in a certain position for example).
Fixes #4651
Resolves #4756 (original issue is fixed/improved but implementation differs from request)
Fixes #4755
How Has This Been Tested?
Visually + unit tests.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

NavMenu Sub Groups example comparison
https://github.com/MudBlazor/MudBlazor/assets/15004223/890d82ab-da63-4620-a4c2-e36d20582799
MudBlazor docs navigation comparison
https://github.com/MudBlazor/MudBlazor/assets/15004223/1eac76d9-796b-4e6b-a7ef-7f1af7e3adf2
Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

FYI @ScarletKuro @henon!
These changes should work with !8672. I made MudNavGroup a nav too because that cleans up the accessibility tree quite a bit:

@ScarletKuro I changed the Localizer API without thinking too much about it, let me know if you want it done differently (i.e. by adding an overload instead).

@ScarletKuro I changed the Localizer API without thinking too much about it, let me know if you want it done differently (i.e. by adding an overload instead).

Looks ok, as I understand it's optional and it doesn't break existing code and doesn't change how the Localizer is behaving.

These changes should work with !8672.

@igotinfected please use # instead of ! to link to issues or PRs. i.e. #8672

These changes should work with !8672.

@igotinfected please use # instead of ! to link to issues or PRs. i.e. #8672

My bad, thanks for catching that (and in one of my other comments too), I'm on Azure DevOps at work where you have to use ! for PRs so it's just muscle memory 🤪

@igotinfected Thanks. For this we don't need to add anything to the v7 migration guide right?

@henon nope should be transparent!


net: LookupNetIP returns IPv4 in IPv6 instead of IPv4

What version of Go are you using (go version)?

$ go version
go version go1.18.2 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jaroslav.kaspar/Library/Caches/go-build"
GOENV="/Users/jaroslav.kaspar/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jaroslav.kaspar/go/pkg/mod"
GONOPROXY="github.com/wandera/*"
GONOSUMDB="github.com/wandera/*"
GOOS="darwin"
GOPATH="/Users/jaroslav.kaspar/go"
GOPRIVATE="github.com/wandera/*"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.18.2/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.18.2/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/k5/bmlsxyfn1tjd50_r0x637flc0000gp/T/go-build3646431415=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
package main

import (
	"context"
	"fmt"
	"net"
)

func main() {
	ips, err := net.DefaultResolver.LookupNetIP(context.Background(), "ip4", "google.com")
	if err != nil {
		panic(err)
	}

	fmt.Printf("%+v\n", ips)
	fmt.Printf("is IPv4: %t\n", ips[0].Is4())
	fmt.Printf("is IPv6: %t\n", ips[0].Is6())
	fmt.Printf("is IPv4 in IPv6: %t\n", ips[0].Is4In6())
}

What did you expect to see?
[<IP_ADDRESS>]
is IPv4: true
is IPv6: false
is IPv4 in IPv6: false

What did you see instead?
[::ffff:<IP_ADDRESS>]
is IPv4: false
is IPv6: true
is IPv4 in IPv6: true

The method LookupNetIP is currently just a wrapper around the old way. But the old way represents IPv4 in 16 bytes slice, so when this wrapper parses the slice it will always create an IPv6 address. For IPv4 addresses, it's IPv4 in IPv6. It makes it harder to manipulate with a new address representation. For example I cannot just simply compare result of netip.MustParseAddr("<IP_ADDRESS>") with the same address returned by LookupNetIP(). The comparison results in non-zero value.
I would propose converting the old address into 4 bytes slice (if it's IPv4 address) before parsing https://github.com/golang/go/pull/53555 . What do you think?

It seems that the original IP is converted to IPv6 here:
https://github.com/golang/go/blob/416c953960a475b7418b5c6aef0f46dd102b9129/src/net/cgo_unix.go#L341-L348
Maybe it's better to remove the conversion?
  func copyIP(x IP) IP {
- 	if len(x) < 16 {
- 		return x.To16()
-	}
  	y := make(IP, len(x))
  	copy(y, x)
  	return y
  }

I run ./all.bash after this change and all tests passed (on Linux). But I'm not sure whether this func is covered by the tests.
BTW, the 3 lines were added as part of the commit to fix #6465. I have tested on tip with the 3 lines removed and can not reproduce #6465.

You are right. It seems quite weird to me that the copyIP function converts it to 16 bytes.

CC @bradfitz @josharian

@kasparjarek I'm sorry that my suggested approach turns out to need more changes than that. So I will send a CL myself.

em... I also met this problem with AddrFromSlice.   and i send a cl

em... I also met a similar problem with AddrFromSlice.   I send a cl
https://go-review.googlesource.com/c/go/+/443196

This problem also seems quite weird to me. When i got i ipv4 address, i also wish got i ipv4 address from netip package.

Hi @kasparjarek, how about the implementation in PR#56406? Let's just change the calling from netip.AddrFromSlice to netip.ParseAddr which already do the IPv4/6 separation. Does it make sense?


Eventually list namespaces for test

What type of PR is this:
/kind tests
Which issue(s) this PR fixes:
Fixes #5836
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/lgtm

@feloy If I understood correctly, tests are not passing on Prow because of https://github.com/redhat-developer/service-binding-operator/issues/1172, right?

@feloy If I understood correctly, tests are not passing on Prow because of redhat-developer/service-binding-operator#1172, right?

Yes, I think so

@feloy If I understood correctly, tests are not passing on Prow because of redhat-developer/service-binding-operator#1172, right?

Yes, I think so

I think there has been a misunderstanding. IMO, the still failing tests (8 tests constantly failing) are due to https://github.com/redhat-developer/service-binding-operator/issues/1172, but there are 2 flaky tests that should be fixed with this PR.
I'll wait for the fix on SBO, and reopen this PR if there are still flaky tests.

I closed this PR by mistake, hadn't realized I did that. Feel free to open it @feloy.

@feloy should we put this on hold until the SBO issue is resolved?

/test v4.10-integration-e2e
This fix is independent from the SBO problem. It tries to fix the problem when the listing of namespaces is not up to date.
I restart the tests as I can see some network errors

This fix is independent from the SBO problem. It tries to fix the problem when the listing of namespaces is not up to date.
I restart the tests as I can see some network errors

The test fixed by this PR seems to be passing. I'm inclined to merge this PR.

I can see the same failure on IBM Windows tests (from another PR):
https://cloud.ibm.com/devops/pipelines/929da3ed-6cad-4026-a847-7a8485f20fa4/582614a3-b910-4659-ac27-6288668c5fe6/a1d74ffa-3d39-4dbb-8583-b0a34f87f3bd/1b647bf2-5a73-485b-87de-29789ad66f1f/f4f3f320-fa08-4612-b4a9-3a86e3eefb28?env_id=ibm:yp:eu-de

SBO has just been updated to v1.1.1, running the tests again:
/test v4.10-integration-e2e

/retest-required

/test v4.10-integration-e2e

Can we merge this PR?

For me yes it can be merged

Can we merge this PR?

For me yes it can be merged

/approve

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cloud

/override ci/prow/unit


Adds option to mute ping sound for specific channels

Mutes the sound of the highlight for hightlights coming from that specific channel
https://i.imgur.com/Lg2SyfB.png

(fixed wrong local branching)

Tried it and it works well :+1:

@pajlada i think this is a bit more readable then

Please create a new PR (or just fix this one) based on nightly instead of master. I think the only manual thing you'll need to fix is the chatterino.pro line-ending-fix

@pajlada should be now all fine, tested it works again

Thank you for the contribution!


added readme suggestions

Hey Michael, I added a few suggestions for clarifications in the blog post. Great post, just a couple of things I needed to tweak to get it going. Cheers.

updated in today's release - thanks!


Rebuild because of PyO3

No source changes, only fixes in dependencies
Rebuild because of https://github.com/PyO3/pyo3/issues/4757

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12243733660. Examine the logs at this URL for more detail.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12243821702. Examine the logs at this URL for more detail.


Updating for v9: from chai to tap testing framework

Hello!
Here I tried to switch to tap as testing framework.
I know that is not needed to mark this dep as ready for the update, but it was not that much work, so I give it a shot.
Any suggestion is always welcomed!

How should am I supposed to proceed with conflicts? Should I resolve them here? @jsumners

Unfortunately, I think we will need to take a different approach on this one. There is a possibility that the Pino org as a whole could be included in the OpenJS Foundation. At this time projects in that org must rely on dependencies that use licenses from a short list of allowed licenses, and tap is moving to BlueOak without possibility of being dual licensed (https://github.com/tapjs/tapjs/issues/821#issuecomment-1721839895).
If you want to migrate the tests to something similar, I believe using https://nodejs.org/dist/latest-v18.x/docs/api/test.html will suffice.

Thank you @jsumners, I'll try and use that instead.

I appreciate the enthusiasm, but this item should probably be held off. See the updates I added yesterday on the overall tracking issue.

Make sense, I'll close this PR then


Format codes based on .editorconfig, Part 8

So it seems that the formatter doesn't trim white space in comments.

So it seems that the formatter (or Roslyn, to be exact) doesn't trim white space in comments.

I think you're probably correct. How exactly are you applying the .editorconfig rules to update the code?

How exactly are you applying the .editorconfig rules to update the code?

I'm using dotnet-format since the very first PR of this series: dotnet/samples#2865.


Add method go generate preview

Codecov Report

Merging #4 into master will decrease coverage by 1.33%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   99.46%   98.13%   -1.34%
==========================================
  Files           4        4
  Lines         187      214      +27
  Branches       27       31       +4
==========================================
+ Hits          186      210      +24
- Misses          1        4       +3

Impacted Files
Coverage Δ

lib/main.js
97.7% <100%> (-1.11%)
:arrow_down:

lib/device.js
96.49% <95.83%> (-3.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8aacc7...862c755. Read the comment docs.


Classic Host Functional issues

Rancher Versions: 3/28
Issues:

[x] InterouteVDC - Can't see Icon?

[x] When switching between different drivers, the icons appear and disappear depending on which one you have selected.
When first enter:

After clicking a couple of the drivers on top:

[ ] Click on InterouteVDC driver and it hangs.  Error:
Uncaught EmberError {description: undefined, fileName: undefined, lineNumber: undefined, message: "Assertion Failed: HTMLBars error: Could not find c…o component or template with that name was found)", name: "Error"…}

[x] Classic Add host, Close & Create buttons should take me back to Host list page, not the New Add Host page.

[x] Create button creates host, but doesn't leave add page.

[x] Can't scale host on add host page

@tfiduccia most of this is fixed except the interroute driver which we talked about breaking into another ticket

Version - 4/24
Verified fixed


Redis cache needs to be clean on application startup

After modification in device definition, redis cache needs to clean manually. It should be added to application bootup configuration to remove the cache automatically to avoid errors later.

Closing, redis has been dropped in favour of ehcache since v4.4.0


Mac build

Summary
I don't own an Apple device, so I can't build this application for MacOs
Details
I would really appreciate it if someone would clone the repository and generate the build for MacOs. It should be as simple as running npm install from the root folder, and then doing npm run dist

Hi! Is this still an issue? Because I'd be glad to help!

Yes, this is still an issue, I still don't own any devices that run MacOS. Help is appreciated!

Do you have a 512x512 icon? I can't use 512x512.png from the repository, as it also has only 256x256 pixels.

Sorry about that, I'll put the 512x512 image here. Also I think it makes sense to wait for version 4.0.0 before you build it, because I'll be releasing that soon, so all the latest features can be included!

Sure, and thanks for the icon! Just ping me here when you need the Mac build! 😃

So I've just released version 4 for windows and linux, you can go ahead with the mac build!

I was able to sucessfully build it. However, the app is not functional on Mac :(.
The menu doesn't get displayed properly and the few actions that are displayed, don't work.
On both my Windows and Ubuntu machine it gets displayed correctly and also works, except for the theme toggler (nothing changes when I click, but I think that's for another issue).

Oh that's unfortunate. Looks like a mac build won't be possible as of now. As for the theme toggling, you have to to restart the application for the new theme to show, I should probably mention that somewhere.
But anyway, thanks for the help!

I think I will fork the repository and try to implement a proper menu on Mac.
For the theme I'm sorry, I don't know how I couldn't come up with the idea to simply restart the application 😅.

Great news! I got the menus to work with mac!
I submitted a pull request.
GitHub doesn't allow files bigger than 10 MB to be attached to comments, so here's the download link to the DMG file.

That's great! I'll add it to the new release.

time to close it?


[20.03] chocolateDoom: 2.3.0 -> 3.0.1 (CVE-2020-14983)

Motivation for this change
Fixes CVE-2020-14983:
https://github.com/chocolate-doom/chocolate-doom/blob/539ef367c9982c5945f8608b63d2236eaecc929a/NEWS.md#301-2020-06-24
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM. Thanks!


Remove uses of reduce/spread which causes significant latency to large middlewares

Hi there, at work we have a very large graphql schema and use graphql middlewares heavily. I've recently been debugging why our graphql server takes so long to start up and identified one area in this library that contributes a good chunk of that time.
I found that this library performs quite poorly when a particular middleware contains a lot (~1k+) of keys. After a deeper inspection, I see that applicator.ts uses the reduce/spread anti-pattern which I have been bitten by a few times in the last handful of years. The simple changes in this PR should not change the behavior of this library at all but they did reduce the total latency of our applyMiddleware call from ~11s to about 6s. If others in the community are using this library with large schemas & middlewares then I want them to benefit as well.

Hey @dimatill, any chance you've had a moment to look over this change?

wow, @ryanquinn3 this is a great finding! Thank you!

@dimatill This is what I get for submitting the PR via github's web editor 😞
Commit pushed. I've confirmed that the package builds & tests pass.

Thank you @ryanquinn3 !!!


Improve Snake

Simplify main - get rid of the welcome and use input instead of readKey

Assume Square class and (version of) draw procedure will be in the library

This line:

call snake.clockTick(currentDirection, gameOn)
is invalid, as a value type cannot be passed by reference. So turn this into two methods, a clockTick() procedure, and an isStillAlive() function.

Create a Game class, which can be instantiated, and 'played' within a test (i.e. with no I/O). As part of this, move the Apple out of Snake into Game. Also move several other methods from Snake to Game. Snake should only know about moving and growing.

Note that there will still be a playGame procedure because this does all the drawing. It will need to cache the location of the previous head & tail & length of snake.

Remaining work absorbed in #520


Support for passing strings in Cleo Call

while making a script i found that gta3sc doesnt support strings passing by cleo call.
More here http://brmodstudio.forumeiros.com/t6018p25-13-gosub-e-cleo_call#273946
Can this be added in future releases?

This is a complicated issue because CLEO calls only support receiving strings as integer pointers. So it's about language design, what would be good semantics to solve this problem elegantly.
Will close this because it's already open as #86, but feel free to ask any questions or provide suggestions :)


BUG:Heading and corner products are out of the screen and not visible clearly

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Hello @arghadipmanna101, Isuue at latest deals section
-The heading of that section hide into screen
-The Corner product images are not align properly
Screenshot of Issue:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

GOOD MORNING SIR
PLS ASSIGN ME THIS ISSUE @arghadipmanna101 .I want to work on this .


Typescript: Cannot find name 'Generator'.

I keep getting this error from typescript
ERROR in [at-loader] ./node_modules/redux-saga-routines/src/index.d.ts:26:46
    TS2304: Cannot find name 'Generator'.

Typescript: 2.5.3
redux-saga-routines: 2.2.1

@LKay your help needed

@tonoslav Could you share your tsconfig.json's compile flags? Make sure you have at least: es2015.iterable and es2015.generator in your lib and have @types/node installed.

Fixed, thank you
{
    "compilerOptions": {
      ...
        "lib": [
            "dom",
            "es5",
            "scripthost",
            "es2015.generator"
        ]
    },
   ...
}


Review if a package description is required for these packages

Scaffolding\src\Microsoft.Framework.CodeGeneration
Scaffolding\src\Microsoft.Framework.CodeGeneration.Common
Scaffolding\src\Microsoft.Framework.CodeGeneration.Core
Scaffolding\src\Microsoft.Framework.CodeGeneration.EntityFramework
Scaffolding\src\Microsoft.Framework.CodeGeneration.Templating
Scaffolding\src\Microsoft.Framework.CodeGenerators.Mvc

TFS Bug#232571

These have all been updated for preview 2


Support angular 4

Do you support angular 4?

@Yura13 yes, the latest ng2-smart-table version is supporting angular 4.

thanks


//test/integration:listener_lds_integration_test is flaky or failing in CI

I saw there was an old issue (#22348) about this test being flaky, but it's been closed for a while so I'm making a new issue of it.
CI failure
[  FAILED  ] IpVersionsAndGrpcTypes/ListenerMultiAddressesIntegrationTest.MultipleLdsUpdatesSharingListenSocketFactoryWithMultiAddresses/2, where GetParam() = (4-byte object <01-00 00-00>, 4-byte object <00-00 00-00>)

[ RUN      ] IpVersionsAndGrpcTypes/ListenerMultiAddressesIntegrationTest.MultipleLdsUpdatesSharingListenSocketFactoryWithMultiAddresses/2
test/integration/http_integration.cc:206: Failure
Failed
Please don't waitForDisconnect with a 5s timeout if failure is expected

Stack trace:
  0xb24298: Envoy::(anonymous namespace)::ListenerMultiAddressesIntegrationTest_MultipleLdsUpdatesSharingListenSocketFactoryWithMultiAddresses_Test::TestBody()
  0x1e3f5e8: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x1e3f488: testing::Test::Run()
  0x1e405d8: testing::TestInfo::Run()
... Google Test internal frames ...

test/integration/listener_lds_integration_test.cc:747: Failure
Value of: codec_client_->waitForDisconnect()
  Actual: false (Timed out waiting for disconnect)
Expected: true
Stack trace:
  0x1e3f5e8: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x1e3f488: testing::Test::Run()
  0x1e405d8: testing::TestInfo::Run()
... Google Test internal frames ...

emm... put it on my list

Another failure https://dev.azure.com/cncf/envoy/_build/results?buildId=142055&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=67a76341-37f4-5b49-db38-acbb8a59af82

closing as up of https://github.com/envoyproxy/envoy/issues/22489


Remove space in Windows installer's default location

Currently the windows installer's default location is C:\local\Helics v2.0.0-rc1. We should make it C:\local\helics-v2.0.0 going forward.

It keys off the version number and build so once the -rc1 is removed that should automatically change.  But  we should fix that space.
On my machine the default ends up being C:\local\helics_2_0_0-rc1   or are you talking about the installer itself rather than the Install build?

This is fixed in #621 by adding a folder parameters to CPACK_NSIS variable


Implement basic training for the new C++ implementation of object detection

With these changes, I can now train a model on the data from our "breakfast" demo:
import turicreate as tc

data = tc.SFrame('breakfast-data.sframe')
m = tc.extensions.object_detector()
m.train(data, 'annotation', 'image', {'mlmodel_path':'/Users/jong/Desktop/od-init.mlmodel', 'max_iterations' : 1000})

I get output like:
+--------------+--------------+--------------+
| Iteration    | Loss         | Elapsed Time |
+--------------+--------------+--------------+
| 1            | 7.98467      | 10.86s       |
| 2            | 7.9668       | 14.37s       |
| 3            | 7.96799      | 17.87s       |
...
| 999          | 0.560803     | 1h 1m        |
| 1000         | 0.630218     | 1h 1m        |
+--------------+--------------+--------------+

I can't actually export the model yet or run prediction, but it's clearly learning something, right? Well, there's no data augmentation, so it's probably overfitting. And all the image resizing is happening on a single thread (the same one feeding MPS), so it's slow.

I rediscovered virtual functions and cleaned up the dependency injection into object_detector, along the way to fleshing out the unit tests. We could probably stand to add more, but this should be enough to get us off the ground.

Thanks for the review, Hoyt! Going to keep this open a bit longer in case others want to offer feedback.
Also, disregard my comments re performance. When building for release, even single-threaded image processing seems to keep up with the MPS backend. I'm optimistic that we can handle full data augmentation with the appropriate parallelization.


Failed to resolve :com.github.jlmd:AnimatedCircleLoadingView:1.1.5

I have Same problem , I have added it to repository but its not working.
repositories {
    jcenter()
    maven {
        url "http://dl.bintray.com/jlmd/maven"
    }
}

Are you adding it in allprojects?
allprojects {
  repositories {
    maven {
      url "http://dl.bintray.com/jlmd/maven"
    }
    jcenter()
  }
}

Yes I have added in allprojects..
On 7 March 2016 at 00:24, José Luis Martín<EMAIL_ADDRESS>wrote:

Are you adding it in allprojects?
allprojects {
repositories {
maven {
url "http://dl.bintray.com/jlmd/maven"
}
jcenter()
}
}
—
Reply to this email directly or view it on GitHub
https://github.com/jlmd/AnimatedCircleLoadingView/issues/14#issuecomment-192962655
.

Well, I've just test it and it's working.

having same issue:
Error:Could not find com.github.jkwiecien:EasyImage:1.1.5.

Uhm, it's not related to my library. You have to ask it to the owner of com.github.jkwiecien:EasyImage

@jlmd - apologize, yes, my bad, it works, thanks!


Add --skip and --trunc options to cutcsv

Now that --no-heading has been implemented in cutcsv, the groundwork for --skip N and --trunc N has been laid. --skip ignores the first N lines, and --trunc ignores lines N and following. All line numbers are absolute, so "cutcsv --skip 30 --trunc 41" will output only lines 31 through 40.
The "--no-heading" option has exactly the same effect as the "--skip 1" option.)

Now that the csv command has a --lambda option, --skip and --trunc aren't needed. In fact, I've retired the whole cutcsv command because csv's new features have made cutcsv unnecessary.


Consider having linkage default to standard linkage in relationships.

Always include (standard) linkage:
linkage always: true

Include customized linkage (if included):
linkage do
  ...
end

Closed by #34.


Parsing of the transaction description: Missing information

Hi @mschindler83,
first of all: Great work! I really love this tool.
I used it with comdirect bank and found an issue with the MT940-parser. I some cases, the reponse contains a divider-string within the description section, although it is still the same transaction. As a result there are parts of the name and/or description missing. Here an example:
RAW-Response (divided and personal information taken out):
Array
(
[0] =>
[1] => 20:MT940-1701250150
[2] => 21:NONREF
[3] => 25:20041144/418311700EUR
[4] => 28C:0/1
[5] => 60F:C170123EUR1921,44
[6] => 61:1701230123DR139,63NMSCNONREF//POS<PHONE_NUMBER>
[7] => 86:820?20ÃœBERTRAG/ÃœBERWEISUNG?21RECHNUNGSNR. 17/27?22END-TO-END-REF.
[8] => ?23NICHT ANGEGEBEN?24Ref. J9217021C1831775/2?30GENODEF1HTR?31DExxxxxxxxxxx?32DR. MEIER
[9] => 61:1701230123DR69,58NMSCNONREF//POS<PHONE_NUMBER>
[10] => 62M:C170124EUR1199,64
)
The information from index 8 is completely lost, as the parser expects it to be part of index 7.
My workaround is as follows:
MT940.php:
protected function parseToArray()
    {
....
	$transaction = substr($day[$i], 3);
	$description = substr($day[$i + 1], 3);
	//WORKAROUND:
	if (substr($day[$i+2],0,1)=="?" && substr($day[$i+2],2,1)!=":") {
	    	//add missing line
	    	$description.=$day[$i+2];
	}

As I'm not a php-expert, I'm pretty sure that you can find a much more flexible and elegant solutions for this issue. I just wanted to show my workaround for better unterstanding. Also I'm not aware about problems which could arise from this code, when using it with other banks.
Thanks and best regards!
Edit:
It's even worse. The parser has a problem with the divider-string that comdirect returns. Comdirect is sometimes sending "\r\n" in the middle of a description. If then a "-" is accidently right behind it (as it belongs to the description), the parser threats it as a new transaction.

Hi,
I referred to this issue in issue #23 .
As I am not a php expert either, I think there is a better solution to this than mine. I got it to work in the meantime (not sure if it always works).

I still however have an issue with two arrays being created accross one single transaction. This leadsto` an incomplete description1.
Now I found a way to solve this by replacing following line in line 59 of MT940.php

Original line:
$days = explode($divider . '-', $this->rawData);
New line:
$days=preg_split('/([\r\n][-][\r\n]|[\r\n][-][+])/', $this->rawData);
The old line does not work because my raw data (Deutsche Bank) looks like this sometimes (replaced some stuff):
:86:105?20EREF+LA-12431-2017-01-02-11?21-27-02-8?22MREF+N1/13002/14/2
-H?23CRED+DExxZZZxxxxxxxxxxx?24SVWZ+01.17 Autom. Sollstell?25ung
1/3002/14/2, DG li, Stp?26l. 24 xxxxxxxxxxxx 16?27ABWA+WEG Fr
xxxxxxxxx. 16 W?30BYLADEM1001?31DE00000000000000999999?32WEG xxx
xxxxxxxxx. 16 Xxxxxx?33n
The point is the \r\n- in this case. Here it continues with the description "H?23CRED+DExxZZZxxxxxxxxxxx?2 ...". In other cases I saw it would either be only "-" or "-+...". But I'm not sure if these will be the only cases?
My new line does not consider @@ as a separator - didn't get it to work with the $divider variable :-(

This can potentially be solved by the structured description. I added code to actually expose it here: https://github.com/mschindler83/fints-hbci-php/pull/48

The Problem is, that there may be lines starting with "-", so the line
$days = explode($divider . '-', $this->rawData); will cut the rest apart. I have a workaround for this: $days = preg_split('%^-$%', $this->rawData);, for which I will create a PR.

The workaround from @mgrundkoetter has helped me, too. Thank you for that.
It seems that this fix is not part of v1.0.4. Is there a reason why the fix has not yet been adopted?


Wrong playlist ordering on future3

Describe your problem
I noticed that the playlist order is alphabetical, not based on the id3 tag track numbers as it should.
My library is organized with this pattern: Album Artist/Album/Artist - Album - Track nr - Title.
For album from one artist this is not a problem.
However, for sompilations or soundtracks the order is messed up.
I.e. for this Sing 2 Soundtrack  the files are named like this:
❯ ls
'Adam Buxton - Sing 2 (Original Motion Picture Soundtrack) - 16 - Tippy Toes (with Fancy Feelings & DSCOSTU) - BONUS TRACK.mp3'
'Bomba Estéreo - Sing 2 (Original Motion Picture Soundtrack) - 10 - Soy Yo - Sing 2 Mix.mp3'
'Halsey - Sing 2 (Original Motion Picture Soundtrack) - 12 - Could Have Been Me.mp3'
'Keke Palmer - Sing 2 (Original Motion Picture Soundtrack) - 17 - Christmas (Baby Please Come Home) (feat. Scarlett Johansson, Taron Egerton, Reese Witherspoon & Tori Kelly).mp3'
'Kiana Ledé - Sing 2 (Original Motion Picture Soundtrack) - 03 - Can'\''t Feel My Face.mp3'
'Reese Witherspoon - Sing 2 (Original Motion Picture Soundtrack) - 14 - Break Free (with Nick Kroll).mp3'
'Sam i - Sing 2 (Original Motion Picture Soundtrack) - 08 - Suéltate (with Sam i & Jarina De Marco feat. Anitta, BIA) - From Sing 2.mp3'
'Scarlett Johansson - Sing 2 (Original Motion Picture Soundtrack) - 04 - Heads Will Roll.mp3'
'Scarlett Johansson - Sing 2 (Original Motion Picture Soundtrack) - 09 - Stuck In A Moment You Can'\''t Get Out Of.mp3'
'Scarlett Johansson - Sing 2 (Original Motion Picture Soundtrack) - 15 - I Still Haven’t Found What I’m Looking For (with Bono).mp3'
'Sing 2 Cast - Sing 2 (Original Motion Picture Soundtrack) - 05 - Sing 2 Audition Medley.mp3'
'Taron Egerton - Sing 2 (Original Motion Picture Soundtrack) - 07 - There'\''s Nothing Holdin'\'' Me Back (with Tori Kelly).mp3'
'Taron Egerton - Sing 2 (Original Motion Picture Soundtrack) - 11 - A Sky Full of Stars.mp3'
'Tori Kelly - Sing 2 (Original Motion Picture Soundtrack) - 02 - Let'\''s Go Crazy (with Taron Egerton, Reese Witherspoon, Nick Kroll).mp3'
'Tori Kelly - Sing 2 (Original Motion Picture Soundtrack) - 06 - Where the Streets Have No Name (with Taron Egerton, Scarlett Johansson, Reese Witherspoon, Nick Kroll).mp3'
'Tori Kelly - Sing 2 (Original Motion Picture Soundtrack) - 13 - I Say A Little Prayer (with Pharrell Williams).mp3'
'U2 - Sing 2 (Original Motion Picture Soundtrack) - 01 - Your Song Saved My Life - From Sing 2.mp3'

And the resulting playlist is sorted alphabetically, not in track order:
pi@phoniebox:~ $ mpc playlist
Adam Buxton, Fancy Feelings, DSCOSTU - Tippy Toes (with Fancy Feelings & DSCOSTU) - BONUS TRACK
Bomba Estéreo - Soy Yo - Sing 2 Mix
Halsey - Could Have Been Me
Keke Palmer, Scarlett Johansson, Taron Egerton, Reese Witherspoon, Tori Kelly - Christmas (Baby Please Come Home) (feat. Scarlett Johansson, Taron Egerton, Reese Witherspoon & Tori Kelly)
Kiana Ledé - Can't Feel My Face
Reese Witherspoon, Nick Kroll - Break Free (with Nick Kroll)
Sam i, Jarina De Marco, Anitta, BIA - Suéltate (with Sam i & Jarina De Marco feat. Anitta, BIA) - From Sing 2
Scarlett Johansson - Heads Will Roll
Scarlett Johansson - Stuck In A Moment You Can't Get Out Of
Scarlett Johansson, Bono - I Still Haven’t Found What I’m Looking For (with Bono)
Sing 2 Cast - Sing 2 Audition Medley
Taron Egerton, Tori Kelly - There's Nothing Holdin' Me Back (with Tori Kelly)
Taron Egerton - A Sky Full of Stars
Tori Kelly, Taron Egerton, Reese Witherspoon, Nick Kroll - Let's Go Crazy (with Taron Egerton, Reese Witherspoon, Nick Kroll)
Tori Kelly, Taron Egerton, Scarlett Johansson, Reese Witherspoon, Nick Kroll - Where the Streets Have No Name (with Taron Egerton, Scarlett Johansson, Reese Witherspoon, Nick Kroll)
Tori Kelly, Pharrell Williams - I Say A Little Prayer (with Pharrell Williams)
U2 - Your Song Saved My Life - From Sing 2

The files have the right id3 tag track number, i.e. this one is track 16, but is played first due to the alphabetical order:
❯ eyeD3 Adam\ Buxton\ -\ Sing\ 2\ \(Original\ Motion\ Picture\ Soundtrack\)\ -\ 16\ -\ Tippy\ Toes\ \(with\ Fancy\ Feelings\ \&\ DSCOSTU\)\ -\ BONUS\ TRACK.mp3
eyed3.plugins:WARNING: Plugin '('lastfm.py', '/usr/lib/python3/dist-packages/eyed3/plugins')' requires packages that are not installed: No module named 'pylast'
... - Tippy Toes (with Fancy Feelings & DSCOSTU) - BONUS TRACK.mp3              [ 5.03 MB ]
--------------------------------------------------------------------------------------------
Time: 02:09	MPEG1, Layer III	[ 320 kb/s @ 44100 Hz - Joint stereo ]
--------------------------------------------------------------------------------------------
ID3 v2.4:
title: Tippy Toes (with Fancy Feelings & DSCOSTU) - BONUS TRACK
artist: Adam Buxton, Fancy Feelings, DSCOSTU
album: Sing 2 (Original Motion Picture Soundtrack)
album artist: Various Artists
release date: 2021-12-17
track: 16
disc: 1
Publisher/label: Sing 2 Soundtrack Album
FRONT_COVER Image: [Size: 136810 bytes] [Type: image/jpeg]
Description: cover

Is there any way to change this behaviour ?
What's your hardware set up?

Phoniebox setup fresh using today's Rpi OS lite 32bit (bullseye)
Installation following the Installing Phoniebox future3 instructions

I mean yes, I could re-organize my whole library because a pattern like Album Artist/Album/Track nr - Titleinstead of Album Artist/Album/Artist - Album - Track nr - Title would be a work around, but that's a lot of work, a I guess I'm not the only affected person by this.

Interesting use case. this should be doable. I need to check how this could be done.


Update cortana-integration.md

Added details about requirements for briefing email and Teams.

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4920

@msbemba


[Historical Data Migration] Simplify input mechanism for historical data migration Docker image

relates #162, blocked by #165
Today, the Docker image for historical data migration uses a volume mount to supply the Data Prepper config file to be used. This approach makes it incompatible with the Docker ECS context, preventing it from easily being deployed to the cloud.
The aim of this task is to investigate, design and implement an input mechanism (that may move away from volume mounts) that would make the Docker image cloud-compatible.

This issue is no longer applicable. Historical data migration is now accomplished at scale with Reindex-from-snapshot (RFS).


GitHub Pages for websites

Hi Everyone,
At the end of last night's session we brainstormed some ideas for future sessions. One idea was a session on using GitHub pages for building a websites.  I've setup a few websites using GitHub Pages and am happy to put together a lesson.
Thoughts? Reactions?
-Tom

+1! I've wanted to start a tech-y blog/public lab notebook-type thing using GitHub pages for a while now, but I've never quite had the time to properly tackle Jekyll's learning curve.

What do you think? Should we schedule a session for the week of Nov. 16?

That sounds good!

How does Nov. 19 sound? We can do our normal Thursday time.

Sounds good to me.
On Tue, Nov 3, 2015 at 2:05 PM, Tom Hohenstein<EMAIL_ADDRESS>wrote:

How does Nov. 19 sound? We can do our normal Thursday time.
—
Reply to this email directly or view it on GitHub
https://github.com/bulib/studyGroup/issues/16#issuecomment-153455856.

Hi Everyone,
Thank you to everyone who attended. We had 9 participants.


Database password

I have created the website and hostname with my own users. Also, I have created the unique ID as per my preferences, that means I am using my own logic for uuid.
Not sure whether its a bug or an something I am missing, I am trying to connect to the database but it always gives me a password error.
Ex.
9nvAm2y1MuvNrJbp - this is the UUID of a record in website. I have manually created the mysql username - 9nvAm2y1MuvNrJbp with same password as username - 9nvAm2y1MuvNrJbp
But this package seems to be using some other, in this case mentioned its using - 960118aea56599f9ac2dc5775a7fa3ba
Not sure where this password is coming from. Would it be possible to advise the reason for this.
My logic to create the website and hostname, I am using users table rather than customers table.
private function registerTenant($name)
    {
        // Create website
        $website = new Website;
        $website->user_id = $this->user->id;
        $website->uuid = str_random();
        $website->save();

        // Associate the website with a hostname
        $hostname = new Hostname;
        $baseUrl = config('app.url_base');
        $hostname->fqdn = "{$name}.{$baseUrl}";
        $hostname->website_id = $website->id;
        $hostname->user_id = $this->user->id;
        $hostname->save();

        // Final host
        return $hostname;
    }

The password is a combination of the website UUID and the App Key, as the app key is randomly generated per instance it's one of the safest ways to create randomized credentials.
Hope this helps. You are still able to override this logic by listening to the related ConfigurationLoading/Loaded events.

Thanks, this really helps. Great work (Y)
BTW, I am exploring your package. Is there anyway we can avoid tuning this package build in migrations?
I have reviewed the tenancy.php and docs on your website. I realised that we can setup the tenant migrations folder but nothing for existing migrations.
Also, do you feel that using User.php instead of Customer.php (\Hyn\Tenancy\Models\Customer::class) will have any impact on the website considering that I am working on stateless web application which will be accessed through API.

avoid tuning the built-in migrations; sure add your own additive migrations
existing migrations for the system connection can go in the default database/migrations folder
I'd recommend using User::class, the Customer::class is losing importance with each release as well.

Noted, thanks.

That's really very helpful information, thanks @luceos


xPSDesiredStateConfiguration: Adding a Branches section to the README.md

Changes to xPSDesiredStateConfiguration

Adding a Branches section to the README.md with Codecov badges for both
master and dev branch (issue #416).

Fixes #416

This change is

Codecov Report

Merging #417 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #417   +/-   ##
===================================
  Coverage    67%    67%
===================================
  Files        27     27
  Lines      3939   3939
  Branches      4      4
===================================
  Hits       2670   2670
  Misses     1265   1265
  Partials      4      4

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable