Fix sidebar support for empty links (/doc/ trailing slash issue)

There was a hard-coded /doc/ prepended to every path before, but now we start
with /doc and add a second slash only if something comes after.
This is a quick fix, but this problem stems from the sidebar.json setup still having influence in many places of the site. Ideally it should be just be the canonical ToC and have nothing to do with link generation, but that's a problem for another time.
fixes #1264

thanks @rogermparent 🙏


Swift 4 support

Do you have a branch for Swift 4 and Xcode 9?

Same. Would love an update for Swift 4.

+1

+1

+1

+1

+1

I've just quickly created a swift-4 branch. Everything seems to be working as expected. Let me know if you have issues.

+1

I changed the AlamofireObjectMapper dependency to swift4 branch, clean the project and build it but there were some problem yet with ObjectMapper in file IntegerOperators.swift related to Swift 4 migration. I had to edit it and works fine, thanks!
To point to swift4's branch using Pod:

pod 'AlamofireObjectMapper', :git ='https://github.com/tristanhimmelman/AlamofireObjectMapper.git', :branch => 'swift-4'

@tristanhimmelman I use AlamofireObjectMapper as a core dependency in one of my own pods which means pointing to a particular git repo and branch won't work. Any chance you can release a Swift 4 release? 😄

The swift4 branch is almost ready to merge into master however I'm seeing a few travis build issues that seem related to release builds. If anybody has the time to test the branch and see if release builds are working within your project that would be much appreciated.

@tristanhimmelman thanks for the update. I would test if I could but unfortunately, podspecs don't allow you to point to a separate branch. They require you to target a specific tagged release.

Actually you can. See this from CocoaPods documentation:
pod 'Alamofire', :git => 'https://github.com/Alamofire/Alamofire.git', :branch => 'dev'

@tristanhimmelman If this were my Podfile, then yes I could. But a podspec and a podfile are two completely different things. See here

@tristanhimmelman No problem 😄 I'm not in a huge rush right now, but it would nice by the end of the year to eventually convert everything over. I'll patiently wait until then. 👍

The swift 4 version has now been released!

@tristanhimmelman awesome, thanks a bunch! 👍


cmd/gofmt: gofmt produces invalid code

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
play.golang.org
What operating system and processor architecture are you using (go env)?
I don't know.
What did you do?
I formatted the following program https://play.golang.org/p/MyGD0azump
package main

import (
	"fmt"
)

func main() {
	var i int
	fmt.Println(); /**/ i++
}

What did you expect to see?
A program that compiles.
What did you see instead?
; after fmt.Println() is dropped which is syntax error.

seems to work ok at tip.
$ cat tf.go
package main
import "fmt"
func main() {
var i int
fmt.Println() /**/
i++
}
$ go version
go version devel +eae657e Mon Feb 27 15:18:44 2017 +0000 linux/amd64

I don't understand what the playground gofmt is doing. When I run my local Go 1.8 gofmt (linux/amd64), I get correct output:
￼package main

import "fmt"

func main() {
        var i int
        fmt.Println() /**/
        i++
}

Same here. Works fine at tip, but on playground I get:
9:21: expected ';', found 'IDENT' i (and 1 more errors)

but the source is not even changed. Incorrect version of gofmt for the playground?

@griesemer I think you have "imports" checked on the playground.
I also got that error with goimports locally, but after I updated goimports it ran without error and gave the same output as gofmt.

@cespare Indeed - thanks. This bug does exist in 1.7 (need to check 1.8). I believe this is an issue I have fixed a while back. We may need to update the playground.

I believe this was fixed by https://go-review.googlesource.com/33016 .

It looks like gofmt on the playground is not up-to-date. @broady ?

It should be. It uses x/tools from the release branch. That CL should have made it in. I'll check.

OK, this is a problem - App Engine is still on Go 1.6, and the playground imports go/format directly, which means we're stuck on Go 1.6's format package.
The best fix is probably to move the formatter from App Engine standard to the sandbox (which runs 1.8).
Other fixes:

Vendor in the new formatter
Move the entire frontend off App Engine standard.

Waiting for 1.8 on app engine seems sensible. This doesn't seem time-critical.

Wait for 1.8 to be available on App Engine standard.

Moving off App Engine [standard] SGTM.

Wait for 1.8 to be available on App Engine standard.

Can this issue be fixed with a simple config change at this point?
Per https://cloud.google.com/appengine/docs/standard/go/release-notes#june_27_2017:

This release adds beta support for go1.8. To use Go 1.8, set api_version: go1.8 in your app.yaml configuration file.

Yes, I'll re-deploy the playground tomorrow. Thanks for the ping.
On Nov 29, 2017 8:04 PM, "Bryan C. Mills"<EMAIL_ADDRESS>wrote:

Wait for 1.8 to be available on App Engine standard.
Can this issue be fixed with a simple config change at this point?
Per https://cloud.google.com/appengine/docs/standard/go/
release-notes#june_27_2017:
This release adds beta support for go1.8. To use Go 1.8, set api_version:
go1.8 in your app.yaml configuration file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/19310#issuecomment-348076501, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABhllZc6DYCqo9t9ONqsWXCWB_IBvDrks5s7ik3gaJpZM4MNqXh
.

Done. Still correct to move everything off GAE standard.


killSignal behaviour

Why killSignal cannot be configured using .fsw.yml and it is being forced to SIGKILL?

which system you are using.  linux  mac or windows?

more details, your information provided are too inficient

insufficient

Signal can be configured.

Yes, but Signal it works only when we edit and save something.
When we press CTRL+C it uses killSignal and sends SIGKILL .
By doing this my program only receives the proper signal notify when I edit/save something, but not when I press CTRL+C using fsw.

yes, you are right, when edit something, program accept signal, only reload, sometime not quit. But when press CTRL+C fswatch exited, so at that moment, it is better to clean the environment which mean kill all running program. That's why send SIGKILL

Right, but why can't this be an option to the user?
At I mentioned here https://github.com/codeskyblue/fswatch/issues/12#issuecomment-230768549, my program is not stopping properly and because of that I can't use fsw (which is a wonderful too) for develop.
Can I propose a PR?

year, add an option seems a good way, pr is welcome.


Add words starting with letter "N"

Create a folder for "N" and add words.
Refer Contribution.md for more details on how to contribute.
Comment the words you'll be adding if you're are working on this issue to avoid conflicts.
Add reference to this issue i.e Issue #107 in your pull request description.

Adding nexus, nebula

Adding necessary, navy

Adding nostalgia

adding nausea

@Showndarya #322 added Nausea


Support a list of most recent messages

The main screen for mobile WhatsApp and mobile Skype show the most recent messages. Make that the default screen for ClearKeep.

Should we replace the current screen with this new one?
Currently, we have a list of servers, group chat, and direct messages in the selected server. If we just display the most recent messages, a new design is probably necessary.


Doesn't work on Android 10

When it starts up on Android 10, it asks for a password that doesn't exist. And when you reinstall the app, if you add a remote, it says "error creating remote". Under about, it says Rclone Version: -1 meaning something about the update is breaking rclone itself.
I'm using the Essential PH-1 on Android 10.

The rclone version contained in rcloneExplorer <= v1.7.4 is not compatible with Android due to problems with TLS memory layout. And also there's a new security restriction on Android 10 that requires a few changes in rcloneExplorer.
The version showing up as -1 just means that it does not run at all.
You can try my build v1.7.5 though. And  a preview version with better Android 10 support should also appear there later this month.

I tried both
rcloneExplorer-1.7.5-armv8a-release.apk
and
rcloneExplorer-1.7.5-fatapk-release.apk
and both of them still had the rclone -1 bug.

Why did they change this on Android anyway? Anyways, I tried the test release, and so far, it's working, but as you said, the streaming service doesn't work on this build. Thanks for the release! :D

I've released a new proper version which should address all known issues. If you discover any new ones, please report them over there to avoid spamming this issue tracker with potentially non-applicable issues.
Streaming now also works on Android 10, although you need to use a third party media player because the default app refuses to cooperate.

@x0b please do state that you are redirecting users to your own fork.


How to programmatically submit the tags?

I wanted to submit using a button (maybe from input decoration), so that the user has another option instead of just the keyboard to submit, is that possible?
I needed to use a form out of the tags to do that now.

@f2acode thanks for the report. in the next releases I will add this feature

Is this feature already added @Dn-a ?


CommandError: Could not load shell runner: 'IPython Notebook'.

I am using django 4.2 abd python 3.10.
OS: Windows WSL (Linux subsystem on a windows machine)
This works:
./manage.py shell_plus --ipython

But not this:
./manage.py shell_plus --notebook

Error:
Traceback (most recent call last):
  File "/home/florent/github/web_api/.venv/lib/python3.10/site-packages/django_extensions/management/commands/shell_plus.py", line 281, in get_notebook
    from notebook.notebookapp import NotebookApp
ModuleNotFoundError: No module named 'notebook.notebookapp'

CommandError: Could not load shell runner: 'IPython Notebook'.

pip list:
ipython                           8.14.0
ipython-genutils                  0.2.0
jupyter                           1.0.0
jupyter_client                    8.3.0
jupyter-console                   6.6.3
jupyter_core                      5.3.1
jupyter-events                    0.7.0
jupyter-lsp                       2.2.0
jupyter_server                    2.7.2
jupyter_server_terminals          0.4.4
jupyterlab                        4.0.5
jupyterlab-pygments               0.2.2
jupyterlab_server                 2.24.0
jupyterlab-widgets

I was able to temporarily fix that by using old version of jupyter_client:

jupyter_client==7.4.8

also getting this issue, and it continues to present after downgrading jupyer_client ... I have the following:
ipython==8.15.0
ipython-genutils==0.2.0

jupyter==1.0.0
jupyter-console==6.6.3
jupyter-events==0.7.0
jupyter-lsp==2.2.0
jupyter_client==7.4.8  # downgraded from 8.3.1
jupyter_core==5.3.1
jupyter_server==2.7.3
jupyter_server_terminals==0.4.4
jupyterlab==4.0.5
jupyterlab-pygments==0.2.2
jupyterlab-widgets==3.0.8
jupyterlab_server==2.24.0

notebook==7.0.3  # it looks like the issue is here??
notebook_shim==0.2.3

yes, --lab does work ...  but its quite a jump -- this django-extensions should be updated for it, no?

I solved the issue downgrading notebook with this command
pip install notebook==6.5.6
Then using the command
python manage.py shell_plus --notebook
work well for me.

PyCharm or VSCode can use Notebook 7 out of the box. For Django I only need to set projects settings. This is a shame Notebook 7 cannot run from the terminal (it should open a browser)
import os
os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'myproject.settings')
os.environ["DJANGO_ALLOW_ASYNC_UNSAFE"] = "true"

There is a workaround. Instead of running ./manage.py shell_plus --notebook you can run in jupyter-lab command instead. It will open a new browser window. Now, to get access to Django context.
# First run:
import os, sys
import django
PROJECTPATH = '/path/to/your/djangoproject'
sys.path.insert(0, PROJECTPATH)
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "djangoproject.settings")
os.environ["DJANGO_ALLOW_ASYNC_UNSAFE"] = "true"
os.chdir(PROJECTPATH)
django.setup()

# and now you can run any your code, e.g.

from django.conf import settings
print(settings.DATABASES)

I had the same issue. I solved it by downgrading these packages:
notebook==6.5.4
traitlets==5.9.0
ipython==8.10.0


Automatically inserting JSX closing element in TypeScript JSX file

Currently, when users type non self-closing JSX tag, they will have to type corresponding closing JSX tag. In this situation, our language service can help the users by automatically insert the corresponding JSX tag. The newly inserted tag should respect existing format and If the matching closing tag exists, the closing tag should not be insert.
var x =
 [insert by language-service]

var y =

[insert by language-service]

var z =

     [insert by language-service]

@mhegazy I was thinking we would do this as a "formatting" edit, rather than in the VS layer. Thoughts?

Well, i think this more akin of doc comment scaffolding, and brace completion, the host needs to ask about it. formatting could be disabled, and or not invoked if you just moved the cursor..

As part of that it would nice to have two additional improvements to JSX/TSX experience that already is supported by HTML editor.

Automatically change closing tag while opening tag is changing.
Wrap with
 (Shift + Alt + W)

Does it mean that you have no plans to implement this feature?https://visualstudio.uservoice.com/forums/121579-visual-studio-ide/suggestions/12584319-provide-automatic-tag-closing-in-jsx-tsx

Any updates on this issue?

This is quite an annoying bug and makes Visual Studio 2019 pretty much useless. Only way I have found to get around this was to find a copy of VS2017 where it still worked. When is MS going to figure out that its the users that keep these products going, stop telling us what to use and not to use, please fix this feature.

Not sure if this is a separate feature or related, but I also wish that the closing tag would rename along with the opening tag like they do in html and cshtml files in VS.

Its been nearly 4 years since this issue was opened. Any updates on whether it will be taken up at all?

I was able to get this somewhat working, I found that if you escape out of the initial context menu (press esc) after entering
</ then hit CTRL + Space then it will insert the closing tag

. For some reason they added an extra key stroke to finish the autocomplete.

This is quite an annoying bug and makes Visual Studio 2019 pretty much useless. Only way I have found to get around this was to find a copy of VS2017 where it still worked. When is MS going to figure out that its the users that keep these products going, stop telling us what to use and not to use, please fix this feature.

I'm on VS 2017 but this doesn't work for me in tsx files.

Does this affect VSCode on js files too?

bump. ^^^ still a problem with VS2019.
shouldn't the premium IDE have an auto close on HTML tags in JSX/TSX files???

Does tsserver support auto-closing JSX tags?

I believe this worked before: https://github.com/Microsoft/TypeScript/issues/15897 🙂
Does anyone know how it got broken?

Bumping again 🙂  Autocomplete of JSX closing tags in Visual Studio 2019 is broken, which, IMHO, seems like it should be a pretty high priority item 😉
@RyanCavanaugh Sorry to tag you personally, but would you be the person to look into this?

Sorry, but just following up on this. @mhegazy, do you perhaps know who we should contact about this? It's an important issue for Visual Studio, I think 🙂

I'd like to bump this as well. If there's anyone who is able to find a fix--I've tried multiple typescript extension versions.
I've also noted that Visual Studio 2019 Pro is unable to import React from 'react' for newly created files. I have to restart the IDE for the reference to be resolved.

cc @uniqueiniquity

Hi @Reckoning47 - I'm sorry you're experiencing this issue with Visual Studio 2019.
Could you please use the Report A Problem functionality in Visual Studio to provide a recording of the issue?
Thank you!

The screen recording does not pick up the autocomplete window, but I was able to capture the essence of what I need. I have autoclosing tags enabled, yet they do not autoclose or even suggest to close the element correctly. The Report A Problem page redirects to this issue.

The issue that I'm seeing is slightly different, but I think it might still be related to this 🙂

Create a new .jsx file
Add a return() statement, so that you can return some HTML.
Add an opening tag, such as

Type </di and autocomplete: The closing tag that you began typing (</di) is transformed into an opening tag (
), and the / is lost. That is, when the closing tag is autocompleted, it gets converted into an opening tag.

I've reported a problem at https://developercommunity.visualstudio.com/t/autocomplete-in-jsx-files-changes-closing-tags-int/1478145?from=email . It includes a recording of the problem.
I'm seeing this issue in the latest version of Visual Studio 2019.
The issue appears to also have been reported here: https://developercommunity.visualstudio.com/t/When-I-wrote-tsx-tags-are-not-closing-au/1106328

This is broken for TSServer too. I don't get completion for JSX elements inside Atom, which uses TSServer.

Hi @Reckoning47 - I'm sorry you're experiencing this issue with Visual Studio 2019. Could you please use the Report A Problem functionality in Visual Studio to provide a recording of the issue? Thank you!

Visual Studio feedback team has kicked this back over to the TypeScript team. This issue has been on-going for several years now! I pay thousands a year to get a premium IDE with these features, and yet time and again, I have to resort to using a free product - from the same company - in order to be productive with my development. I am not alone in this issue. Please, someone take responsibility for this and resolve it, as soon as possible! This has been going on for too long.

Solved it !!!
I don't know how can I record it, but simply said
in Visual Studio (Community at least)
Tools => Options => Text Editor => JavaScript/TypeScript => Intellisense
uncheck the box "Only use Tab or Enter to Commit"
hope this works and makes your day

True! It works for me using VS 2022.
To clarify, unchecking "Only use Tab or Enter to Commit" will help here:

</

But not here

Wow, thanks for that fix, @mk-16!! ^_^
To anyone who's experiencing this issue, please upvote the two Visual Studio bug reports about this 🙂

https://developercommunity.visualstudio.com/t/When-I-wrote-tsx-tags-are-not-closing-au/1106328
https://developercommunity.visualstudio.com/t/autocomplete-in-jsx-files-changes-closing-tags-int/1478145?from=email

@uniqueiniquity, You assigned this to @rakatyal. Is that still correct? 🙂
There are two items in this Github issue:

Feature request: Make it so that VS automatically inserts closing tags.
Bug report: The autocomplete for the closing tag is wrong (e.g. It autocompletes with
 when it should autocomplete with
)

Would it be helpful for us to split the bug off into a separate issue?
Thanks 🙂


Implement BackendStyle for &BackendStyle

This is a requirement for https://github.com/38/plotters/pull/185.

https://github.com/38/plotters/pull/185 Could be merged without this.


Ell not tracking invocation chain between nested calls

`ell.init(store="logdir/test_joke")
ell.complex(model="gpt-4o-mini", temperature=2, max_tokens=50)
def suggest_jokes():
TOPIC_PROMPT = """
Suggest some funny topics for a joke.
"""
return TOPIC_PROMPT
ell.complex(model="gpt-4o-mini", temperature=2, max_tokens=50)
def select_joke(topics: str):
SELECT_TOPIC_PROMPT = """
From the following topics, select one that would make the funniest joke: {topics}
"""
return SELECT_TOPIC_PROMPT.format(topics=topics)
@ell.complex(model="gpt-4o-mini", temperature=2, max_tokens=20)
def tell_joke():
"""
Generate a joke using the language model.
"""
JOKE_PROMPT = """
Tell me a short, clever joke about {subject}.
The joke should be witty and make people smile.
"""
suggestions = suggest_jokes()
selected = select_joke(suggestions)
return JOKE_PROMPT.format(subject=select_joke(suggest_jokes()))
`
Ell-studio only shows the first call tell_joke()

@JohnPeng47 can you clarify if the bug is that this only happens when the functions are called inline?
it looks like you wrote them on separate lines / assigned them to variables above then commented them out , maybe to debug it. Did that work?


Are these Docs still correct?

Hi there,
it feels that this Docs are outdated. The URL Structures often name URIs like "qnamaker/v5.0-preview.2", but the Term "qnamaker" has been replaced already, and "preview.2" also seems outdated.
It is furthermore not matching the (sample) URLs from "Language Studio", where other Structures are used/shown.
Furthermore, I cannot see any KBID from Resources I created in Language Studio, but are needed in the REST Descriptions here. In Language Studio, only the Name is used.
Can you help here?
Thanks!
Christoph

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5abc52f0-1148-c8be-92aa-7ec2df0985bd
Version Independent ID: c4686dbf-759e-a9ce-21f4-7e34d58d41c3
Content: Quickstart: Use SDK to create and manage knowledge base - custom question answering - Azure Cognitive Services
Content Source: articles/cognitive-services/language-service/question-answering/quickstart/sdk.md
Service: cognitive-services
Sub-service: language-service
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@boredom2 Thanks for the feedback! We will review and update accordingly.

I have found multiple issues in their docs that lead to either outdated step-by-steps and 'simple' code examples that throw errors. I hope that these docs can be updated to display correct information

Thanks, @PatrickFarley Could you please help to update the document.

#reassign:mrbullwinkle

@boredom2 Apologies for the delay in response to your GitHub Issue. This issue was routed to the wrong person.
You are correct, when we initially announced question answering at Ignite we were still reliant on some of the SDK packages/docs that were released at Build last year. The new question answering SDK/API packages have now been released, and the quickstart docs have been updated accordingly.
In addition to the updated quickstart content there is content related to the new APIs located here:

Answers API
Authoring API
cURL based Authoring API examples
Prebuilt API

#please-close

Thank you!


⚠ File access has degraded performance

In 11bbad9, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 503
Response time: 15123 ms

Resolved: File access performance has improved in 9bf8b64 after 19 minutes.


pick up latest hidal-go

pick up latest-hidal go, which uses the official mongo driver

This change is

Can you please rebase on the current master instead of merging it? Commits in master have a bit different hash because the way how Github rebases things on merge.

will do.


OTP26 - Get CA certificates for SSL connection

https://github.com/ryanwinchester/tmi.ex/issues/20

Thanks.
I have this fixed in a branch I've been working on but it will be a while before I can merge that one to main.

Is there a chance to have land this in main before the big rewrite?

This is merged into main already. I don't remember if there is a release with it yet, but I am pushing a release tonight

v0.7.0 pushed


Fix encoding in forms

Fix #27

Can you please explain to me what this pull request changes specifically and why you feel the changes are necessary.

I was working with some forms. I had to add some unicode data like "Nuñez" but the following error showed up:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/ubuntu/apurata/app/scripts/fetch_sbs_data.py", line 85, in fetch_sbs_data
    ret, html = get_data_from_sbs(data, proxy=proxy, tries=10)
  File "/home/ubuntu/apurata/app/lib/sbs.py", line 140, in get_data_from_sbs
    html_text = get_sbs_html(data, tries, proxy=proxy)
  File "/home/ubuntu/apurata/app/lib/sbs.py", line 56, in get_sbs_html
    ).set(data["last_name_m"].encode('utf-8'))
  File "/usr/local/lib/python2.7/dist-packages/webkit_server.py", line 93, in set
    self._invoke("set", value)
  File "/usr/local/lib/python2.7/dist-packages/webkit_server.py", line 207, in _invoke
    return self.client.issue_node_cmd(cmd, "false", self.node_id, *args)
  File "/usr/local/lib/python2.7/dist-packages/webkit_server.py", line 377, in issue_node_cmd
    return self.conn.issue_command("Node", *args)
  File "/usr/local/lib/python2.7/dist-packages/webkit_server.py", line 518, in issue_command
    self._sock.sendall(arg.encode("utf-8"))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2: ordinal not in range(128)


Add menuWidth & expose align props in ComboBox and SearchAutocomplete

Closes #5430
Hello, this PR adds a new prop menuWidth to both ComboBox and SearchAutocomplete React Spectrum components. This prop is identical to that of Picker's, which allows the user to specify the width of the popover to their preference.
While adding the prop, I noticed the align part of placement prop for Popover used in both ComboBox and SearchAutocomplete was fixed to end. This unfortunately results in the exact opposite positioning to Picker's popover when the popover width is wider than the trigger element. So to better align with Picker's behavior, I exposed an additional prop align and set its default to start in both ComboBox and SearchAutocomplete. There may be a reason for having 'end' align for both of these components that I'm not aware of, so I'd like a confirmation from the core team about this.
Thanks.
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[x] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
Combobox
story

go to http://localhost:9003/?path=/story/combobox--default&providerSwitcher-express=false&strict=true
test the new prop menuWidth using 'width' and 'menuWidth' controls in that story.

docs

go to http://localhost:1234/react-spectrum/ComboBox.html#props
check if the props menuWidth and align are listed with proper descriptions.

SearchAutocomplete
story

go to http://localhost:9003/?path=/story/searchautocomplete--default&providerSwitcher-express=false&strict=true
test the new prop menuWidth using 'width' and 'menuWidth' controls in that story.

docs

go to http://localhost:1234/react-spectrum/SearchAutocomplete.html#props
check if the props menuWidth and align are listed with proper descriptions.

🧢 Your Project:

GET_BUILD

GET_BUILD


Set LimitOrder size to optional

Size isn't returned when bet_target_type is BACKERS_PROFIT.

Let me know if you want more tests on this

Coverage remained the same at 92.103% when pulling 7ff44c968e2db23360cc1bb32a0d94d1853fe4ed on foulkesjohn:master into bfb823d32f5d392c579ae721ee7e690e15c6c8d1 on liampauling:master.


Update Abseil to fix MSVC compile error

Currently, MSVC address sanitizer may not be enabled during compilation and cause compilation error. This PR updates Abseil to include the fix of https://github.com/tensorflow/tensorflow/issues/61435.

There are no new commits to review. The blocker here is an internal breakage.

If there still have Abseil-related breakage, that means someone needs to check which corresponding code is required to change.

This was for @gbaned who keeps asking me to review the PR

This was for @gbaned who keeps asking me to review the PR

Thank you very much @mihaimaruseac

Can you also update the lts_20230125 symbols in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/def_file_filter/def_file_filter.py.tpl ? Without that it doesn't link.

Import didn't affect any internal file

This looks strange. Might be an infra issue or the files has moved?


Invalid content property throwing errors

I think I've caused/found a failure mode by setting the property "content": "&sbBmsB(...).sha256" as mentioned in this thread.  I'm currently unclear on the severity of this bug, or whether my experiment is causing problems for others on the network. I'm getting two errors on master:
Error: public_key must be a buffer of size crypto_scalarmult_BYTES
    at exports.crypto_scalarmult (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/sodium-chloride/index.js:118:8)
    at Object.exports.decrypt.exports.multibox_open (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/private-box/index.js:60:16)
    at exports.unbox (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/ssb-keys/index.js:157:16)
    at Array.main_unboxer (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/secure-scuttlebutt/minimal.js:60:49)
    at unbox (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/secure-scuttlebutt/minimal.js:21:36)
    at Object.decode (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/secure-scuttlebutt/minimal.js:68:14)
    at /home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/flumelog-offset/inject.js:45:22
    at /home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/flumelog-offset/frame/recoverable.js:48:11
    at /home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/aligned-block-file/blocks.js:74:11
    at get (/home/christianbundy/.node_modules/lib/node_modules/scuttlebot/node_modules/aligned-block-file/blocks.js:29:7)

Error: bad p size
    at Object.nacl.scalarMult (/home/christianbundy/Source/patchwork/node_modules/tweetnacl/nacl-fast.js:2202:51)
    at exports.crypto_scalarmult (/home/christianbundy/Source/patchwork/node_modules/sodium-browserify-tweetnacl/index.js:76:31)
    at Object.exports.decrypt.exports.multibox_open (/home/christianbundy/Source/patchwork/node_modules/private-box/index.js:60:16)
    at exports.unbox (/home/christianbundy/Source/patchwork/node_modules/ssb-keys/index.js:157:16)
    at Array.main_unboxer (/home/christianbundy/Source/patchwork/node_modules/secure-scuttlebutt/minimal.js:60:49)
    at unbox (/home/christianbundy/Source/patchwork/node_modules/secure-scuttlebutt/minimal.js:21:36)
    at Object.decode (/home/christianbundy/Source/patchwork/node_modules/secure-scuttlebutt/minimal.js:68:14)
    at /home/christianbundy/Source/patchwork/node_modules/flumelog-offset/inject.js:76:29
    at /home/christianbundy/Source/patchwork/node_modules/flumelog-offset/frame/recoverable.js:48:11
    at /home/christianbundy/Source/patchwork/node_modules/aligned-block-file/blocks.js:74:11

I think we may be able to resolve this bug by wrapping ssbKeys.unbox() in a try...catch block, or wrapping it here so that unbox errors can be handled without anything catching fire.

Looks like this likely is not breaking SSB for others, it's instead just crashing other instances of sbot on my network as they're trying to decrypt the non-encrypted string. The result is that my message isn't being replicated, although I believe it is still a valid message. I think my options are:

Reset my feed and lose my most recent ~30 posts.
Wait until a bugfix is merged and remain unreplicated until others upgrade their client(s).

:thinking:
Maybe there's some way to cherry-pick that post and delete it from my feed?

guessing you already rewound? I got this
$ sbot createHistoryStream --id @+oaWWDs8g73EZFUMfW37R/ULtFEjwKN/DczvdYihjbU=.ed25519 --limit 1 --sequence 4884
{
  "key": "%P9zniL4UHLj9eCPGA59vZi70NNgl8r6wx9SBujiuyIY=.sha256",
  "value": {
    "previous": "%mfW9YauWJFrfmyglCVzQ2NN+q7i2bd6iNiXCpgfxmqo=.sha256",
    "sequence": 4884,
    "author"<EMAIL_ADDRESS>    "timestamp":<PHONE_NUMBER>645,
    "hash": "sha256",
    "content": {
      "type": "chess_move",
      "ply": 19,
      "root": "%Hc6wouM2eztGqBg37QXFXgYqXlMSWLBGdg4pSN4o3xw=.sha256",
      "orig": "d1",
      "dest": "e2",
      "pgnMove": "Ke2",
      "fen": "2kr1b1r/ppp2ppp/2n5/3Bpb2/4n3/2N1BN2/PPP1KPPP/R6R b - - 7 10",
      "branch": "%bfx7kmHkz2jMZi8Ch+Fw7lpxNsm4Z/8tYlcZrIkb3k8=.sha256"
    },
    "signature": "JZnhixVRMo4ubTuDWxo5Q8vYFux7/h4WpfoywdoMxt7oGPw/QRvOogQJ0Li1AHlhwBwyjJubCxdvrAyTABbDAA==.sig.ed25519"
  },
  "timestamp":<PHONE_NUMBER>787
}

Yeah, I took the output from createHistoryStream and added all of my posts without the funky one. Maybe this is a Scuttlebot problem instead? Here's how I can reproduce locally:

Create a completely new feed (@Q0SqHwaRFKV3LgDdxqkKBluG8oIjZdFzN2fN6z0vFVs=.ed25519)
Join a pub.
Patch secure-scuttlebutt and ssb-validate.
Run sbot publish '&blob'

Here's the diff for ssb-validate (patched 3.0.9):
diff --git a/index.js b/index.js
index b0bcd21..61e4448 100644
--- a/index.js
+++ b/index.js
@@ -37,8 +37,12 @@ function isEncrypted (str) {
   return isString(str) && /^[0-9A-Za-z\/+]+={0,2}\.box/.test(str)
 }

+function isBlob( str) {
+  return isString(str) && str.indexOf('&') === 0;
+}
+
 var isInvalidContent = exports.isInvalidContent = function (content) {
-  if(!isEncrypted(content)) {
+  if(!isEncrypted(content) && !isBlob(content)) {
     var type = content.type
     if (!(isString(type) && type.length <= 52 && type.length >= 3)) {
       return new Error('type must be a string' +
@@ -54,7 +58,7 @@ var isInvalidShape = exports.isInvalidShape = function (msg) {
     !isObject(msg) ||
     !isInteger(msg.sequence) ||
     !isFeedId(msg.author) ||
-    !(isObject(msg.content) || isEncrypted(msg.content))
+    !(isObject(msg.content) || isEncrypted(msg.content) || isBlob(msg.content))
   )
     return new Error('message has invalid properties:'+JSON.stringify(msg, null, 2))

@@ -196,7 +200,7 @@ exports.validate = function (state, hmac_key, feed) {
 exports.create = function (state, keys, hmac_key, content, timestamp) {
   if(timestamp == null || isNaN(+timestamp)) throw new Error('timestamp must be provided')
   state = flatState(state)
-  if(!isObject(content) && !isEncrypted(content))
+  if(!isObject(content) && !isEncrypted(content) && !isBlob(content))
     throw new Error('invalid message content, must be object or encrypted string')

When I run createHistoryStream locally it shows the entire feed correctly, including the &blob message. When I look from the perspective of another instance (like my pub) it doesn't show the last message. I've followed the test profile from my main account, so you should be able to see it (although the &blob content doesn't replicate).

Feed (click to expand)
{
  "key": "%AbujaxR69c0h9oKGUambEbXkkDs6x66W/08iqV73aBI=.sha256",
  "value": {
    "previous": null,
    "author"<EMAIL_ADDRESS>    "sequence": 1,
    "timestamp":<PHONE_NUMBER>139,
    "hash": "sha256",
    "content": {
      "type": "contact",
      "contact"<EMAIL_ADDRESS>      "following": true
    },
    "signature": "qeSLV927tyTg7JXjB8yQ9IXV5vsRSKpHa3HinHosa6fcwNv0k6yludSb19Mm7qUPeAV5Uj8cahS5aNVUtoGKBQ==.sig.ed25519"
  },
  "timestamp":<PHONE_NUMBER>206
}

{
  "key": "%WL6EqEwMk4TqCLKfKS5BMBDobi47ML/JVGAAm+NlnoQ=.sha256",
  "value": {
    "previous": "%AbujaxR69c0h9oKGUambEbXkkDs6x66W/08iqV73aBI=.sha256",
    "author"<EMAIL_ADDRESS>    "sequence": 2,
    "timestamp":<PHONE_NUMBER>697,
    "hash": "sha256",
    "content": {
      "type": "pub",
      "address": {
        "host": "libra.fraction.io",
        "port": 8008,
        "key"<EMAIL_ADDRESS>      }
    },
    "signature": "MaoRuUm5oI97RJYUMf1hWR9udVLH62nSX4BwOq7d0WNfGl93xqaXYExMH5EYkjZ5SJuMhRTqJ+2hltxnwdFtAQ==.sig.ed25519"
  },
  "timestamp":<PHONE_NUMBER>762
}

{
  "key": "%DPlK9GIdIPEaSIKzzlNqtsBQ2JgAf0wcwwzCW2oYD8w=.sha256",
  "value": {
    "previous": "%WL6EqEwMk4TqCLKfKS5BMBDobi47ML/JVGAAm+NlnoQ=.sha256",
    "author"<EMAIL_ADDRESS>    "sequence": 3,
    "timestamp":<PHONE_NUMBER>939,
    "hash": "sha256",
    "content": {
      "type": "contact",
      "contact"<EMAIL_ADDRESS>      "following": true,
      "autofollow": true
    },
    "signature": "B67cSFitlbQoB65fC8o/lNe2wHf3hzUpE94Xa4Ce2ihGWorSx1te2hSLYv5EGuJ238J0wcsdFEDv4XRbqmn9Bw==.sig.ed25519"
  },
  "timestamp":<PHONE_NUMBER>995
}

{
  "key": "%OKqk7WKQggxGqwbGk+BbbCdpcH3p3MV1rDPE+gvJE8g=.sha256",
  "value": {
    "previous": "%DPlK9GIdIPEaSIKzzlNqtsBQ2JgAf0wcwwzCW2oYD8w=.sha256",
    "sequence": 4,
    "author"<EMAIL_ADDRESS>    "timestamp":<PHONE_NUMBER>656,
    "hash": "sha256",
    "content": "&sbBmsB7XWvmIzkBzreYcuzPpLtpeCMDIs6n/OJGSC1U=.sha256",
    "signature": "8kdZKsM9T9bt86B47gOmgOp+Xzx1TRC8rw09ih22a91w6tR8c+2Dkwo0V/xfMIucL2K3ZvQliwJJuEva8h9TCw==.sig.ed25519"
  },
  "timestamp":<PHONE_NUMBER>677
}

Oh, I think your test just clicked for me -- is your point that ssb-validate is saying "that's an invalid message" and refusing to replicate? I was under the impression that content could be any arbitrary value so long as it conformed to JSON, but if that's not the case then it makes sense why it isn't being replicated.

@christianbundy yeah, I would have thought that your scuttlebot would refuse to even store that message - but it does seem that others receiving it did. Probably the reason it was accepted is that there might be some legacy stuff about messages you create locally?

rejecting invalid messages would be a good test case for http://github.com/ssbc/ssb-integration-tests

Also closing in favor of https://github.com/ssbc/ssb-keys/pull/46.


Updating markers on map

Hi guys,
wondering if you could help me with a slight issue I have. I have made a planner board on one page and people can input country data on it and then I have created a map on another page, which plots a marker on where they have selected, and that all works, but if I edit a country that doesn't update the map until I stop running the script. Please can I have some pointers?
I have created it with folium, and used pandas and geopy and MongoDB.
any suggestions would be greatly appreciated
countries = mongo.db.country.find()
map_obj = folium.Map(location=[53.49, -2.24], zoom_start=5)
url = requests.get('https://ipinfo.io/')
@app.route('/my_map')
def my_map():
global map_obj
return map_obj.get_root().render()
@app.route('/travel_map')
def travel_map():
global map_obj
data = url.json()
my_loc = data['loc'].split(',')
folium.Marker(location=my_loc, popup="I am here").add_to(map_obj)
fg = folium.FeatureGroup(name="travel_map")
specific_country = mongo.db.country.find_one()
for count in countries:
    df = pd.DataFrame({'name': count['country_name']}, index=[0])
    geocode = RateLimiter(geolocator.geocode, min_delay_seconds=1)
    df['location'] = df['name'].apply(geocode)
    df['point'] = df['location'].apply(lambda loc: tuple(loc.point) if loc else None)
    fg.add_child(folium.Marker(location=df['point'][0][:-1], popup=count['country_name'], icon=folium.Icon(color='purple')))
    map_obj.add_child(fg)

return render_template('map.html', specific_country=specific_country)

I'm sorry but I'm going to close this.
As stated in CONTRIBUTING.md, questions should be asked at Stack Overflow.
Moreover, the question you're asking is too specific to your application and I believe that the issue you're having is not caused by geopy.


Not sure why it's not working

Hi there, I've just installed this extension and have made a personal access token as per instructions.
I've then tried making a link to GH repo file and pull request... No pop up or embedded thing appears.
I've tried restarting obsidian. I'm not sure how to debug further. Is there a way I can see that the extension is happy with the personal access token? Is there something I've missed as to how to trigger the embedded bit.
Thanks again for making this extension. I believe when it works it will be an elegant solution.
EDIT/TLDR: I was being scilly. I wasn't in read mode.

Okay, progress made (through using reading mode), I now have a thing popping up... unfortunately it has an error.
Error loading GitHub embedInvalidCharacterError: Failed to execute 'atob
' on 'Window': The string to be decoded is not correctly encoded.

Still not sure how to debug from here.

Okay, progress made (through using reading mode), I now have a thing popping up... unfortunately it has an error.
Error loading GitHub embedInvalidCharacterError: Failed to execute 'atob ' on 'Window': The string to be decoded is not correctly encoded.

Still not sure how to debug from here.

Is this a private repo? You might need to setup your token to access private repos if so.

This issue should probably be closed, but I'll mention that it should be made clear in the Settings page (not just the main page) that you must be in "reader" mode for previews to show; this wasn't obvious for me...

This issue should probably be closed, but I'll mention that it should be made clear in the Settings page (not just the main page) that you must be in "reader" mode for previews to show; this wasn't obvious for me...

Good call. Could you make an issue for that? I'll try to make that more clear until we support editor mode!
Also, @LipJ01 I'm going to close this issue for now. Let me know if the problem is still happening after adjusting your token's permissions and we can reopen!


Added help, extended debugging, added a package filter, added mode for metadata check only

Having spent the past 72 hours struggling to recover a CalyxOS backup onto a GrapheneOS phone, this tool was invaluable.  Thank you for creating it!
To troubleshoot issues and generally learn how Seedvault is supposed to work, I added more debugging messages.  Eventually, I started adding some convenient features and decided it was worth offering up.
Since I was searching across multiple backups, trying to test mnemonic phrases and find certain app data, I added a "--check" flag to verify when I had the right mnemonic and a "--package" flag to extract only the needed package.
While I was at it, I added "--debug" so it can be either an environment variable or a command-line option.  Plus a "--help" flag and detailed output.
Let it be known that this is the first time I've written Golang and had it actually compile.  So please be gentle.  :sweat_smile:

Here's an example / test run:  (possibly also a mini-tutorial if anyone else is trying to salvage their text messages):
$ ./extract --help
usage: extract [PATH] [MNEMONIC] [optional]
    PATH      should be a 13-digit folder name (inside .SeedVaultAndroidBackup)
    MNEMONIC  should be a twelve word phrase

    Optional arguments include:
       --check    confirms that the backup metadata is valid, but does not extract the data
       --list     lists the package names only, but does not extract the data
       --debug    enables excessive amounts of output *INCLUDING SENSITIVE DATA, LIKE KEYS AND PHRASES*
       --package  specifies a Android package name -- all others will be skipped

    Example usage:
         extract my_backups/.SeedVaultAndroidBackup/1708344900209 'buzz float culture lake paper season amused rain marine promote coyote mechanic' --list
         extract my_backups/.SeedVaultAndroidBackup/1708344900209 'buzz float culture lake paper season amused rain marine promote coyote mechanic' --check
         extract my_backups/.SeedVaultAndroidBackup/1708344900209 'buzz float culture lake paper season amused rain marine promote coyote mechanic' --package com.android.contacts

$ export PHRASE="buzz float culture lake paper season amused rain marine promote coyote mechanic"

$ export BACKUPS="/mnt/backups/pixel"

$ ./extract $BACKUPS/.SeedVaultAndroidBackup/1708344900209 "$PHRASE" --check
CHECK-MODE ENABLED: extract on '1708344900209' stopped before deploying 179 packages

$ ./extract $BACKUPS/.SeedVaultAndroidBackup/1708344900209 "$PHRASE" --list --package com.android.providers.telephony
    com.android.providers.telephony

$ ./extract $BACKUPS/.SeedVaultAndroidBackup/1708344900209 "$PHRASE" --package com.android.providers.telephony
    extracting com.android.providers.telephony.tar

$ ls *.tar
com.android.providers.telephony.tar

$ tar xvf com.android.providers.telephony.tar
apps/com.android.providers.telephony/_manifest
apps/com.android.providers.telephony/d_f/000000_sms_backup
apps/com.android.providers.telephony/d_f/000001_mms_backup

$ cd apps/com.android.providers.telephony/d_f

$ python3 -c "import zlib; print(zlib.decompress(open('000000_sms_backup','rb').read()))" > 000000_sms_backup.json

(Note: filenames and mnemonic phrases have been changed to protect the innocent)


wrong behaviour on the opposite direction

If you select moving the mouse down it works as expected, but if you move the mouse up, some times you end up with the last line (the upper one) selected in a different column or even the entire line selected.

Perhaps this is related to this issue, but i noticed that when I selected text in the reverse (bottom to top, right to left) direction, the top line would flicker for me. OSX atom 1.74 / SSCS 1.5.1

@bigfive Wasn't this fixed by #93?
BTW, any idea when that will be released?

@RyanZim @bigfive This was fixed by #93 but unfortunately the package is still on Version 1.5.1. If you wanna get the fix then you need to get it from the head (for example by doing: apm install bigfive/atom-sublime-select). then it works.

On both OS X and Ubuntu I was prompted to upgrade this package today, to version 1.6.0, and it fixed this issue on both OSes.

@mscaff0 @bigfive Can you close as per @jdw1996?

@bigfive @jdw1996 thank you for pushing versoin 1.6.0 today. works as well for me.


cache download is significantly slower on Mac agents than Linux agents

On Linux Im seeing cache download speeds between 59-92mb/s. Cache takes 1 min to download

on Mac agents the cache download speeds are 1.2mb/s and i'm only 68% of the way through the job after 29 minutes.

Same here, it makes the cache quite literally useless because that's the point of it. 😓

I've posted a detailed how to reproduce here https://github.com/actions/cache/issues/631#issuecomment-1333021422

@farzonl, this download issue is actually related to Azure SDK, and not macOs Runner. We are tracking it here.

@penchef, slow downloads is something I'd agree could be related to macOS runners. I believe there are some issues already open talking about the slowness of macOs runners - https://github.com/actions/runner-images/issues/6547 , https://github.com/actions/runner-images/issues/1336

Please reopen a new issue in that case @sidekick-eimantas


Added Umple templates for Java, build defaulting to JET

This pull request contains the final Umple templates for Java.
As requested, the build will default to using JET, which will result in 19 failed tests, 16 in Ruby and 3 in Java. Most are due to JET including extra spaces, although some are due to it not adding enough blank lines.

It has failed on Running cruise.umple.implementation.AssociationBothSidesSortedTest in both CI environments

@Diusrex It is failing on the BothSidesSorted because you included the fixes for the tests that are only valid if UmpleTL is active! But UmpleTL is not active. We have to modify the PR to exclude those three changed files for now, and put them back in when we activate UmpleTl

Also, I can't figure out why you have reverted the building of Ruby, PhP and Sql in codegen
Right now I am testing this PR with java templates activated

Ignore my last comment.
Note that I have just merged #792 so there could be slight conflicts with this. I think what I am going to do is just merge this one ... have it fail, and then blast things through with another PR that will solve the problem so I can do the release. I have tested this with UmpleTL activated and it is fine.


How to make unit test?

Is there any methods to test the right execution of ussd code?

Not sure I understand your question. The only thing that this plugin is doing is calling Android's sendUssdRequest so I don't know how could could test that in a unit test.


Feature request - auto favorite filters

Hi,
I like your app a lot, thanks for your good work. One feature I miss from Kuroba is the ability to use filters (just as in the existing "Autohide" feature) to automatically favorite threads. For example, a filter searching "dashchan" on /g/ to add those threads to my favorites automatically.
Use case: there are a few subjects I like to follow on many boards (but don't care about the board as a whole) and without this feature I have to go to each of those boards, go to search feature and search my keywords manually to find and watch those threads.
Thanks for the app and I hope you consider this feature

Is this a "filter watching"? I heard these words before, but didn't have any ideas what do they mean.
How does it works? Do you need to open the board manually to check for new threads, or it should work in background somehow?

Yes in the background if possible so you don't have to switch to each board you have filters set up for. I can see this would be quite a lot of activity in the background so I'm not sure how Kuroba does this but it's a very good feature.

It would be awesome if it could be implemented


Suggestion: Use Prettier to format the HTML

At work, I've built a solution to display server-side errors on the client using the onRecoverableError callback from React 18.
I've extended that solution to display a diff on hydration errors based on this package, so thank you very much for sharing it.
A different approach I used was to format the HTML using prettier instead of beautify. I was getting a lot of false positives with beautify due to different things like HTML comments (<!--$-->), semicolons... So my diff was always huge. Using prettier, it's much smaller and there are only some false positives involving inline style attributes.
It might be good to explore this approach for the library itself. Here is a code snippet:
import prettier from 'prettier';
import parserHtml from 'prettier/parser-html';

const prettierHtmlOptions: prettier.Options = {
  parser: 'html',
  plugins: [parserHtml],
  tabWidth: 2,
};

prettier.format(value, prettierHtmlOptions);

@samijaber Hi, would this be a good first issue/beginner issue? Wouldn't attempting it and try to help out!

@lucaliebenberg go for it!

@samijaber thanks, I shall give it a go!

@samijaber hi Sam, I have cloned the repo and branched off. I have swapped out the beuatify usages and have replaced it with the prettier implementation similar to what @arthurdenner previously said.
How am I able to open the PR, as it seems my git is denied

not sure what issue you're facing, you should be able to use this view https://github.com/BuilderIO/hydration-overlay/compare
to take your fork's branch and make a PR against the main branch of this project.


Doesn't seem to like github.com/holiman/uint256

I've implemented the necessary interface on the uint256 library in https://github.com/holiman/uint256/pull/126, but running this generator against a struct containing those types generates invalid code, trying to cast these types into []uint64 instead of calling the interface methods. No idea what's happening, can't parse this code with 0 comments.
/github.com/ethereum/go-ethereum/core/types/tx_blob_enc.go:66:29: cannot convert c.Value (variable of type *uint256.Int) to type []uint64

	// Field 6: Value
	if len([]uint64(c.Value)) != 4 {
		return nil, ssz.ErrBytesLength
	}
	for _, o := range []uint64(c.Value) {
		dst = ssz.MarshalUint64(dst, o)
	}

No idea why the above happens, it should just call MarshalSSZTo?

This was fixed by https://github.com/OffchainLabs/methodical-ssz/pull/9


Support lazy.nvim configuration

Describe the solution you'd like
It would be nice if there was native support for configuring this plugin using the default plugin spec of lazy.nvim as it is very popular and lots of people are using it.
It provides for passing options directly to a plugin, rather than polluting the _G.{variable} global namespace with extra variables.
Additional context
Examples
My current lazy config for this plugin
{
    'AntonVanAssche/music-controls.nvim',
    dependencies = { 'rcarriga/nvim-notify' },
    keys = {
      { '<localleader>j', '<CMD>MusicPlay<CR>', desc = 'Music - play/pause' },
      { '<localleader>k', '<CMD>MusicNext<CR>', desc = 'Music - next track' },
      { '<localleader>l', '<CMD>MusicPrev<CR>', desc = 'Music - prev track' },
      { '<localleader>;', '<CMD>MusicCurrent<CR>', desc = 'Music - current track' },
    },
    config = function()
      _G.music_controls_default_player = 'spotify'
    end,
}

What it would look like using lazy spec
{
    'AntonVanAssche/music-controls.nvim',
    dependencies = { 'rcarriga/nvim-notify' },
    keys = {
       -- user keymaps here
    },
    opts = {
       default_player = 'spotify'
    },
}

Thanks!!

Hi @sjclayton,
I've added a your feature request in the opts-setup branch (see commit: https://github.com/AntonVanAssche/music-controls.nvim/commit/72d9cf30dd59f58ca4ae665cbaa7df4c5b8d6cc9). Feel free to test it before I merge it into the master branch.

Changes related to documentation have also been added to the same commit.

@AntonVanAssche
Every thing looks good...  only one thing I noticed was on line 3 in the plugin's init.lua that the require call for notify should probably be wrapped inside a pcall, so vim.notify = pcall(require('notify')()) as to prevent the plugin from throwing an error if the user happens to not have nvim-notify installed, if you are going to be removing it as an optional dependency for your plugin, which your update to the docs seems to indicate.
I have not had the time yet to test the new implementation fully however, as I am in the middle of doing a major rewrite on my config.
Thanks for implementing this!

Every thing looks good... only one thing I noticed was on line 3 in the plugin's init.lua that the require call for notify should probably be wrapped inside a pcall, so vim.notify = pcall(require('notify')()) as to prevent the plugin from throwing an error if the user happens to not have nvim-notify installed, if you are going to be removing it as a dependency for your plugin, which your update to the docs seems to indicate.

This was not the intention, I modified the commit to include the dependency again. 😅
Thanks for noticing!

Tested, it's all good to merge.

Hi @dougreese,
This is certainly useful. If you want, feel free to open a PR and add it to the README.
Thank you for using this plugin!


issue163 reset on explore page

I was playing around and considering that I don't know the code very well. Please review carefully :)
I have modified the behavior for the reset button on the explore page (issue number 163)

Nice! You could move collectionId inside the if stmt to avoid the ternary op, but I'll do it when I merge.


Text mistake

At the bottom of the page I found a mistake. There must be "Wininit"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e39de773-2483-f94c-45aa-32b6af9775a1
Version Independent ID: 03ba7ec3-9c97-5572-3e41-9ffd0ce916f0
Content: chkdsk
Content Source: WindowsServerDocs/administration/windows-commands/chkdsk.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: alalve

#assign:xelu86

Hey @iarua,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change has been made correcting winnit > wininit through its entirety. Changes will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day. #please-close


[posix] Fixed a race condition that generate SPI latency

SPI_INT falling edge is not detected when it occurs between CheckInterrupt and FD_SET.
See more details here: https://github.com/orgs/openthread/discussions/8698

Closing stale PR.


Invalid IP error

This is strange, same module installed on some Sugar Enterprise instances works fine, bit on few others we get this error, even though they are all the exact same version 9.x
**Invalid Credentials** You are attempting to authenticate from an invalid IP
(2a00:1098:0:80:1000:61:1:1) or platform
(base).

See screenshot
Any ideas to point me in right direction appreciated.

Hey Vincent,
Are you sure the ip restriction list is the same between the instances? Also, are there any notable differences between the stacks that work and the stacks that don't like the php version?

Hi Gerald, thanks for reaching out.
Stack could be different.
Shall I provide a phpinfo.html for one of the non working instances if that helps?

if you can provide an export of your IP restrictions and just let me know the PHP versions for the instances that aren't working, that should be enough.

Attached phpinfo and IP restriction export - thank you in advance
phpinfo.zip
IPRestrictions-notworking.xlsx

Just in case it helps to compare 2 stacks, this one is another instance with different PHP version that is giving same error
phpinfo.zip

Hi Vincent,
Between the export and your screenshot, it looks like your IP is drastically different than what that validation is expecting. You have an IPv4 address in your validation but the IP in your screenshot is IPv6. To solve this, I would likely just add the IPv6 address to the list of allowed IP addresses - otherwise, you would need to investigate your network and that server to identify why it's using IPv6.

The IPv6 in the error message seems to belong to the hosting provider.
Not sure why their setup would sop his module checking IPv4 addresses
I don't suppose this module could be adapted to work with these situations, just in case IPv6 becomes more popular?

I don't believe the problem here is between IPv4 vs IPv6 validations as you should be able to set validations for either. If you are setting an IPv6 validation range and it's not working, please let me know.
The way the module works is to check for the IP addresses found in $_SERVER:
https://github.com/sugarcrm/IPRestrictionManager/blob/master/src/SugarModules/modules/IRM_IPRestrictionManager/IRM_IPRestrictionManager.php#L71
On your server, it appears that $_SERVER['REMOTE_ADDR'] is the only source for an IP which is why we are getting that address. It's trying to validate your IPv4 range against an IPv6 address. Ultimately you would need to figure out why $_SERVER['HTTP_CLIENT_IP'] isn't being set on the server. I would certainly be open to any suggestions on how else this module could obtain the requestors IP address from the server.

hi Gerald,
I passed your last reply to the hosting company, and reply I got today was:
''Can this work on X-Forwarded-For?''
thanks again for your help on trying to solve this one, hopefully the solution will help others.

Hi Vincent,
Can you have someone at the hosting company replace the getIpAddress() function in
./modules/IRM_IPRestrictionManager/IRM_IPRestrictionManager.php with the function below and let me know if it solves the issue?
`public function getIpAddress()
{
$ip = '';
    $headerKeys = array(
        'HTTP_CLIENT_IP',
        'HTTP_X_FORWARDED_FOR',
        'HTTP_X_FORWARDED',
        'HTTP_FORWARDED_FOR',
        'HTTP_FORWARDED',
        'REMOTE_ADDR',
    );

    foreach ($headerKeys as $headerKey) {
        $replacedKey = str_replace('_', '-', ltrim($headerKey, 'HTTP_'));
        if (isset($_SERVER[$headerKey]) && !empty($_SERVER[$headerKey])) {
            $ip = $_SERVER[$headerKey];
            break;
        } elseif (isset($_SERVER[$replacedKey]) && !empty($_SERVER[$replacedKey])) {
            $ip = $_SERVER[$replacedKey];
            break;
        }
    }

    return $ip;
}`

Hi Vincent,
Any updates on this?

hi @geraldclark
sorry, didn't see you asked for an update, my apologies, all worked fine, think it was only 1 user IP v6 that was causing issue.


On the new build dashboard decorate devicelab tests that can be flaky without breaking the build

Use case
I reverted https://github.com/flutter/flutter/commit/adec6977be800690d81cfc81cd07eb5037f4317f because I thought it had broken the build, but it was marked isFlaky in the manifest.  In the new dashboard there's no difference between failing and "flakable" (tree still open), and just failing.
Proposal
Make these two cases visually different.

The build dashboard shows a question mark on a task that is marked flaky. The material icons may have failed to download if there was no visual indicator for the difference in a task and a flaky task.

Hm, I don't think I saw a "?" at the time, but now I do.
Can we add some "Flaky: true" text to the menu?


Enable ingesting preview builds of pylance

I've changed the logic in PreBuild.ps1 to no longer rely on npm's behavior when specifying "latest" for the version. "Latest" only seems to pull latest stable, which is what we want most of the time. But if there's a stable hotfix, "latest" won't pull it, which is bad.
Here's how the new logic works:

If the user specifies a specific pylance version, we try to install it. In this case, pylanceReleaseType is ignored.
If the user specifies "latest", we look for the latest version that matches the specified pylanceReleaseType. We can tell by the patch number.
Finally, we tag the build with either Pylance Stable or Pylance Preview.

This new tag will be used to control triggering of our release pipeline. We will only want to trigger releases (which insert into VS) on builds that are tagged with Pylance Stable.

The release pipeline change isn't visible in this PR because it's done directly in azdo. That pipeline is at https://devdiv.visualstudio.com/DevDiv/_releaseDefinition?definitionId=2762&_a=environments-editor-preview

On the pylance side, was the changed done to push all stable, hot fix stable and prerelease to the msft_consumption feed?

On the pylance side, was the changed done to push all stable, hot fix stable and prerelease to the msft_consumption feed?

Actually, no change was needed here. Erik told me we already do this, and I verified it myself as well. If you run the following command from your repo, you can see all the stable, hotfix, and preview versions of pylance: npm view @pylance/pylance versions

On the pylance side, was the changed done to push all stable, hot fix stable and prerelease to the msft_consumption feed?

Actually, no change was needed here. Erik told me we already do this, and I verified it myself as well. If you run the following command from your repo, you can see all the stable, hotfix, and preview versions of pylance: npm view @pylance/pylance versions

I see, but when the pylance release pipeline triggers PTVS build pipeline to run, it will provide the argument that specifies stable or prerelease right?
The end result is that the PTVS build pipeline will run for all new Pylance release, but the PTVS release pipeline will only be triggered by stable Pylance, is my understanding correct?

On the pylance side, was the changed done to push all stable, hot fix stable and prerelease to the msft_consumption feed?

Actually, no change was needed here. Erik told me we already do this, and I verified it myself as well. If you run the following command from your repo, you can see all the stable, hotfix, and preview versions of pylance: npm view @pylance/pylance versions

I see, but when the pylance release pipeline triggers PTVS build pipeline to run, it will provide the argument that specifies stable or prerelease right?
The end result is that the PTVS build pipeline will run for all new Pylance release, but the PTVS release pipeline will only be triggered by stable Pylance, is my understanding correct?

Correct. 😄


minDate and maxDate in config don't work with custom parseDate/formatDate/dateFormat

Expected Behavior
I expect to be able to set a custom dateFormat and a minDate or maxDate in the config and have the control update correctly.
Current Behavior
We're using MomentJS, so we've overridden parseDate and formatDate to be able to reuse existing date format strings that are used elsewhere in the app. When only setting defaultDate, this works as expected. When setting minDate or maxDate in the config, however, the min/max value is not properly evaluated nor is the defaultDate value.
Possible Solution
Based on looking at parseConfig(), it looks like the min/max values are evaluated before any custom date format is applied. In fact, if I supply minDate in the default "Y-m-d" format the control then behaves as expected.
Steps to Reproduce (for bugs)
CodePen: https://codepen.io/iamthechad/pen/rjXrXR?editors=1010

This had to do with the order of options.
While not a solution, if you had parseDate and formatDate at the top of config, it would've worked :smirk:
Thanks for reporting the issue. :+1:


Introduce more build checks

This solves #18
Regarding the ffwd-module -> ffwd-api, this is the convention we have in other projects that has an API. And module is a generic keyword in Maven which would make it confusing.

+1


Legacy browser support(without Proxy)

After looking into the source code of Solid, we found mergeProps and splitProps need Proxy support.
Is it possible to use Solid with browsers don't support Proxy? Because we have users using Safari Mobile 9 on iOS or Chrome < 49 on Android.
I know there's proxy-polyfill provided by chrome team. But it's lack some of features which Solid depends on.

mergeProps is used by spread in JSX. The others are based on your own usage. Non-Proxy versions wouldn't fully work. The properties on the source objects couldn't change and for splitProps the rest object wouldn't work.
I never built Solid in a non-proxy world to be fair. In 2016 when I started I figured by the time anyone used it browsers like Internet Explorer would be dead etc.

So there's no way to rescue those users who are still using old version browsers, unless the developers carefully write code and avoid using spread and rest operators.

So there's no way to rescue those users who are still using old version browsers, unless the developers carefully write code and avoid using spread and rest operators.

You can still use babel to transpile the end result into something that will work in older browsers. The performance will be worse, though, so it would make sense to run it only if necessary and use the modern version whenever possible.

There is a Proxy polyfill that looks promising — https://github.com/GoogleChrome/proxy-polyfill — although I haven't used it myself. But as @atk mentioned, you'll likely need to use a transpiler like babel to generate JS bundles, especially for legacy browsers. That will also inject polyfills or transpile out things like queueMicrotask too.
Solid is great and very forward-thinking, but TBH it wouldn't be my first choice when targeting old browser engines.

As @atk mentioned, you'll likely need to use a transpiler like babel to generate JS bundles anyway, especially for legacy browsers. That will also inject polyfills or transpile out things like queueMicrotask too.
If you were determined to use Solid you could write custom ESLint rules to prevent using spread on JSX elements or stores + write tests to verify no new Proxy in the output JS bundles.
Solid is great and very forward-thinking, but TBH it wouldn't be my first choice when targeting old browser engines.


Test 1_1 fails when user namespaces are enabled

When user namespaces are enabled as per test 2_8, this causes test 1_1 to fail because the Docker Root Dir is set to for example: /var/lib/docker/808080:808080.
This adds a test to see if userns is enabled and uses the dirname utility to get the parent directory, which should be the mount point.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:dginther/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Hi @dginther, there's a discussion going on at https://github.com/docker/docker-bench-security/issues/332#issuecomment-448495838 and is kind of related to this.
Maybe we should add a similiar test for overlay etc, but that could get messy fast.

I noticed that conversation, and I saw there were similar issues, figured I'd take a stab at a solution.
perhaps it would be better to find a solution that determines whether the Docker Root Dir is on the same filesystem as the root filesystem, and PASS if it is not?

@konstruktoid Thought about this a lot today and came up with a different approach. Take a look and see if this might be a better way to do things?

Thanks, but could you run a shellcheck and try to make it a bit more POSIX?
$ shellcheck -x --format gcc tests/1_host_configuration.sh
tests/1_host_configuration.sh:22:30: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/1_host_configuration.sh:23:36: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/1_host_configuration.sh:24:17: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/1_host_configuration.sh:25:14: warning: In POSIX sh, arrays are undefined. [SC2039]
tests/1_host_configuration.sh:27:3: warning: In POSIX sh, arithmetic for loops are undefined. [SC2039]
tests/1_host_configuration.sh:27:11: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/1_host_configuration.sh:27:25: warning: In POSIX sh, -- is undefined. [SC2039]
tests/1_host_configuration.sh:29:44: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/1_host_configuration.sh:32:13: warning: In POSIX sh, array references are undefined. [SC2039]
tests/1_host_configuration.sh:33:22: warning: In POSIX sh, == in place of = is undefined. [SC2039]
tests/1_host_configuration.sh:40:6: warning: In POSIX sh, [[ ]] is undefined. [SC2039]

the more I look at this code the less I feel like I am barking up the right tree with this test.
I'm not sure there is a good way to determine this programmatically, without checking to see if the homedir is set the way it is because of user namespaces or overlay.
Edge cases abound. I see originally it looked to see if $DOCKER_HOME was in fstab, but even that doesn't really give a good way of making this work.


Fix inherited message sent before Connack

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 14 (85.71%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 98.619%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server.go
12
14
85.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
5069

Relevant Lines:
5140

💛  - Coveralls

This works, but I think there is a simpler implementation that will solve this issue - please see #147 and review

You're correct. I forgot the existing client is only deleted later on.

Okay - I'll close this one and merge #147


⚠ MyAnonaMouse has degraded performance

In 5934612, MyAnonaMouse ($MAM) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: MyAnonaMouse performance has improved in 368b9ed.


Optimistic Ethereum not working

I have tested the new UniSwap Optimistic Ethereum and here is the sequence of events on the newest version (19/07/21) on iPhone 6e. These might be multiple issues, but I am posting the whole process to analyze here and then we can split it.

The wallet detects the tokens twice

The wallet doesn't connect at all via WalletConnect in Chrome on iOS (on Android connects the Ethereum network, even though its disabled in Active Networks)

The first step is good - the wallet detects the tokens and calculates correctly the expected swapping amounts

The wallet pull expected gas cost of congested Ethereum network instead of OE

When attempted to adjust the screen popps up with Ethereum mainnet gas calculations

I have tried 10 different values here, from the minimum to the maximum and the next error is always the same.

After confirming the adjusted gas prices we get

I have tried slippage from AUTO to 10% and makes no difference. Same error. I was  unable to complete a transaction.
I dont know if it would help, but when I tested on Coinbase wallet I go an error the first time which you can see here:
https://optimistic.etherscan.io/tx/0x56281fd57be0e794907d9d6c4b6edca5633715cec84fe5d3c2a406d4d33d0ef9
In CB Wallet, after increasing the slippage to 5% the transaction went through.
For a reference you can see the Android issue here: https://github.com/AlphaWallet/alpha-wallet-android/issues/1930

Going to look at it when I’m back, but can you share which networks are enabled in Settings > Select Active Networks?

@hieronymus4826

The wallet detects the tokens twice

#3020

The wallet doesn't connect at all via WalletConnect in Chrome on iOS (on Android connects the Ethereum network, even though its disabled in Active Networks)

A few things here:

I can't figure out how to connect to Optimistic on https://app.uniswap.org/#/swap. Is there a toggle in the site? When I use WalletConnect, the connection is always for Ethereum (not Optimistic)
Connecting sometimes doesn't work, but sometimes it works consecutively. It's still possible that it's a problem with the app, but there's a good chacne it's the dapp too. But we should definitely show a better, or more informative message when it hasn't connected successfully after a while. Maybe ask the user to try again or something. Created https://github.com/AlphaWallet/alpha-wallet-ios/issues/3022

The wallet pull expected gas cost of congested Ethereum network instead of OE

#3023. Also stop allow user to change the gas price/limit.

After confirming the adjusted gas prices we get [slippage etc]

Not sure about this. Seems like it's an issue with the dapp unless we are packing the transaction incorrectly (which is quite bad). Could you give it a go again and see if it's the dapp.
If nothing goes wrong, the 2 PRs will be in next build end of the week.

@hboon I have the same problem when using Uniswap.
https://user-images.githubusercontent.com/51817359/140880367-528e3a76-f91f-4aac-822d-f087a5ae4f4c.mp4

Closing for now


Mark frontend server spans as synthetic when coming from loadgen

Changes
This change will change the way synthetic requests work:

frontend service will no longer restart the trace
frontend-proxy will be visible in all traces
loadgen will be visible in all synthetic traces

This will ensure that service-graphs can correctly be built and we dont artificially hide services, but instead a trace will contain all the hops.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[x] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the [docs][]

Related: #1180

If we add this change we will drop the example for linked traces.

I am sure we can come up with a better one. The current state is hiding too much behind the span link.
I tried looking if we could configure envoy to restart and link, but to no avail :-/

We split the traces to showcase trace linking early in the demo's development. Though the traces look nicer when not linked, we specifically try to showcase the OpenTelemetry functionality this PR is removing.

@puckpuck I think we it's less about looks, I found it to be confusing when the service graph didn't contain the frontend-proxy. I think we can probably highlight this capability in a better place and I'd be happy to add it somewhere else.
Can you think of a better place that doesn't hide a critical piece of the puzzle? Maybe in a downstream message consumer?

@puckpuck I think we it's less about looks, I found it to be confusing when the service graph and trace didn't contain the frontend-proxy. I think we can probably highlight this capability in a better place and I'd be happy to add it somewhere else.
Can you think of a better place that doesn't hide a critical piece of the puzzle? Maybe in a downstream message consumer?

Quoting the OTel docs here, it seems that the link would be a better fit for the message queue indeed:

Span Links
Links exist so that you can associate one span with one or more spans, implying a causal relationship. For example, let’s say we have a distributed system where some operations are tracked by a trace.
In response to some of these operations, an additional operation is queued to be executed, but its execution is asynchronous. We can track this subsequent operation with a trace as well.
We would like to associate the trace for the subsequent operations with the first trace, but we cannot predict when the subsequent operations will start. We need to associate these two traces, so we will use a span link.
You can link the last span from the first trace to the first span in the second trace. Now, they are causally associated with one another.
Links are optional but serve as a good way to associate trace spans with one another.

I'd be okay with that change.

I'm a little hesitant to remove something (child spans for accounting and frauddetection) from our existing traces, but not completely against the idea.
I think it makes sense to have an issue to discuss a better spot for span links and hold off on this PR until we get that resolved and implemented.

Vendor support for span link visualization is patchy although we should encourage more representation. Does jaeger display span links well or is just an attribute?

Jaeger does support Span Links. Honeycomb does as well.

Cool. I’m okay with the change

Dynatrace also supports it

Conflicts resolved.

@cedricziel, did you see this comment?
https://github.com/open-telemetry/opentelemetry-demo/pull/1181#issuecomment-1785533329

Ahh. Dropped the ball here, sorry. Thanks @julianocosta89 !


unsupported protocol scheme ""

I have nginx with vts and using the exporter I see this in the logs
fetchHTTP failed Get /status/format/json: unsupported protocol scheme ""

I can manually go to the /status/format/json endpoint and see the json data. Here's a sample
{"hostName":test-2rb6h","nginxVersion":"1.13.1","loadMsec":1497388530496,"nowMsec":1497388857639,"connections":{"active":1,"reading":0,"writing":1,"waiting":0,"accepted":20,"handled":20,"requests":317},"sharedZones":{"name":"ngx_http_vhost_traffic_status","maxSize":1048575,"usedSize":2441,"usedNode":1},"serverZones":{"test":{"requestCounter":316,"inBytes":102925,"outBytes":901605,"responses":{"1xx":0,"2xx":316,
"3xx":0,"4xx":0,"5xx":0,"miss":0,"bypass":0,"expired":0,"stale":0,"updating":0,"revalidated":0,"hit":0,"scarce":0},"requestMsec":0,"requestMsecs":{"times":[1497388770070,1497388771072,1497388772070,1497388773072,1497388774071,1497388775071,1497388776071,1497388777071,1497388778070,1497388779071,1497388780073,1497388781071,1497388782071,1497388783071,1497388784071,1497388785071,1497388786071,1497388787071,1497388788071,1497
388789071,1497388790071,1497388791072,1497388792071,1497388793072,1497388794071,1497388795071,1497388796072,1497388797071,1497388798071,1497388799072,1497388800071,1497388801071,1497388802072,1497388803071,1497388804071,1497388805071,1497388806071,1497388807070,1497388808070,1497388809072,1497388810070,1497388811072,1497388812071,1497388813077,1497388814071,1497388815071,1497388816071,1497388817071,1497388818071,1497388819
072,1497388820071,1497388821071,1497388822071,1497388823071,1497388824078,1497388825071,1497388826076,1497388827073,1497388828071,1497388829071,1497388830071,1497388831071,1497388856221],"msecs":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]},"overCounts":{"maxIntegerSize":18446744073709551615,"requestCounter":0,"inBytes":0,"outBytes":0,"1xx":
0,"2xx":0,"3xx":0,"4xx":0,"5xx":0,"miss":0,"bypass":0,"expired":0,"stale":0,"updating":0,"revalidated":0,"hit":0,"scarce":0}},"*":{"requestCounter":316,"inBytes":102925,"outBytes":901605,"responses":{"1xx":0,"2xx":316,"3xx":0,"4xx":0,"5xx":0,"miss":0,"bypass":0,"expired":0,"stale":0,"updating":0,"revalidated":0,"hit":0,"scarce":0},"requestMsec":0,"requestMsecs":{"times":[],"msecs":[]},"overCounts":{"maxIntegerSize":1844674
4073709551615,"requestCounter":0,"inBytes":0,"outBytes":0,"1xx":0,"2xx":0,"3xx":0,"4xx":0,"5xx":0,"miss":0,"bypass":0,"expired":0,"stale":0,"updating":0,"revalidated":0,"hit":0,"scarce":0}}}}

The metrics endpoint only shows
# TYPE nginx_vts_exporter_build_info gauge
nginx_vts_exporter_build_info{branch="fix-docker-error",goversion="go1.8",revision="0f3dbb44a86340d65bf3d6abbcc0ee88663cb419",version="0.4"} 1

I'm still troubleshooting but wanted to open an issue as there appears to be some configuration I've set up that doesn't work.

I just started the same two containers on my local host manually and didn't have the same issue. There must be something different about when running these containers in kubernetes that isn't working.
If I exec into the vts-exporter pod I can curl localhost/status/format/json without issue. I'm still trying to figure out what the issue is.

So it appears that the NGINX_HOST isn't getting set in the dockerfile. When I look at the running process in the container I can see the uri doesn't have the $NGINX_HOST variable
nginx-vts-exporter -nginx.scrape_uri=/status/format/json -telemetry.address :9913 -telemetry.endpoint /metrics -metrics.namespace nginx

I tried setting NGINX_HOST but it still didn't pick it up in the entrypoint script. I then set NGINX_STATUS to the full uri http://localhost/status/format/json and this works now.
I'm not exactly sure why this wouldn't work in kubernetes but works in vanilla docker but I figured out a way to get it to work. Closing this now and hopefully someone else can reference it in the future.


Site CSS makes it less usable on ultrawide monitors

Hey, great resource you have here! But there's some weird stuff done in the CSS that makes things go absolutely goofy on ultrawide monitors.
It looks like the developer tested the styles for ultrawide monitors like this.

And that seems fine, but when that's actually on my monitor, it looks like this.

The font size that is in my URL bar, or in the dev tools, or on the tab are perfectly optimal for reading.
I actually have to shrink the screen to make it readable, like this.

It looks like the problem is this file. Removing that and the reference here would fix the problem. I really think that users can be trusted to adjust their scaling to what's comfortable to them.

Correction, Github sent me the wrong way due to it not getting along with Git submodule.
So I guess the fix actually needs to be implemented in the docura/docura repo. However, I'll leave this here because once that is fixed, this submodule hash will need to be updated... I think.

Refer https://github.com/docura/docura/issues/1#issuecomment-1281148608
Fixed in https://github.com/docura/docura/issues/1


useLocalePath remove query from string url

Environment
node 18.15
Reproduction
need reproduction
Describe the bug
when i use localePath with parameter is stringUrl has query, return url is missing this query.
ex:
input url : /test-change-default-color-123/women's-standard-t-shirt?color=royal&size=xl
output url -  /test-change-default-color-123/women's-standard-t-shirt
Additional context
No response
Logs
No response

close due to non-active.
if you would have still issue, please open the new issue.
Thanks!


Test suite improvements

Wondering if you'd be open to improving the test suite. I'm interested in developing an automated test suite with unit and integration tests, likely using Nox and Pytest; one that could be easily incorporated into both local development workflows and a build pipeline.

That sounds good to me!

Closing this.  We have implemented tests in grib2io and grib2io-interp using pytest.


Build error on master

I cloned the repo, ran npm install and then npm build. I got no output. After that I did:
[tobias@Tobias-MBP:xxxx/node_modules/navigo on master]
% WEBPACK_ENV=build ./node_modules/.bin/webpack
Hash: b8b3bb7531cc9e722568
Version: webpack 1.12.12
Time: 75ms
    + 1 hidden modules

ERROR in ./src/index.js
Module parse failed: /Users/tobias/Workspace/PHPStorm/nextlease/nextlease-embeddable-client/node_modules/navigo/src/index.js Line 341: Unexpected token
You may need an appropriate loader to handle this file type.
| };
|
| export default Navigo;
|

Using Node 6.10.0.

Thanks for reporting. I'm planning some time today to cover last couple of issues.

Thank you. You are great!
I have a upcoming PR but I could not test it yet. I'll submit it as a WIP

Hm ... just tested your scenario. Fresh clone npm install and then npm run build. I'm using node 6.7.0 and it works fine. Can you please try running npm run build instead of npm build?

Thank you. It is working.


sql downloads - 50km seems to be default gridSize for EEA grids but isn't supported by GBIF_MGRSCode

https://www.eea.europa.eu/en/datahub/datahubitem-view/3c362237-daa4-45e2-8c16-aaadfb1a003b
(download doesn't currently work)

gridSize
The grid size in metres of the EEA Reference Grid. Must be 25, 100, 250, 1000, 10000 or 100000.

Other grids are available at other scales, for example here at 10km
https://sdi.eea.europa.eu/data/93315b78-089d-43a5-ac76-b3df627b2e4cf

I used 25, 100, 250, 1000, 10000 or 100000 as that's the values given in the EEA Reference Grid specification
I will add 50km.  @peterdesmet, @qgroom, let me know if that's inappropriate.

I can't see any problem with this, though such large grid squares don't seem that useful for analysis of biodiversity data.


sleepy-puppy does not send email notification

I have followed the quick tutorial here after i successfully setup the sleepy-puppy. however sleepy-puppy does not send me a notification if the xss payload is triggered. I look into the logs and it seems there is a error in File "/apps/sleepy-puppy/sleepypuppy/collector/views.py", line 201,
sleepylog.txt

just for update. i am using digitalocean.

Sleepy Puppy leverages AWS for email notifications, however this can be disabled if you would rather use your own SMTP server.
In the root of sleepy-puppy, simply change the following configuration setting:
# Email server configuration
# SES Options:
EMAILS_USE_SES = True
SES_REGION = 'us-east-1'

Set EMAILS_USE_SES to False and configure the SMTP settings below in the same configuration file.
Please reopen this issue if you have any other questions.


Orchestrator promoting a replica as master even where there is significant lag.

Hi,
We have a 3 node Ec2/Centos/MySQL Instance. 1 Primary and 2 Replicas. MySQL Version is 5.6.7 and orchestrator is 3.1.4.
We have semi-sync replication enabled.
Over the weekend OPTIMIZE table was running on 3 big tables sequentially along with bunch of other purges. There was a lag due to this on the replicas. However after few hours the master died and orchestrator promoted Node 2 with 12 hours of replication delay as new master. We lost 12 hours of data !!!
I recreated the same issue in test to the best I could.
3 Node cluster with semi-sync enabled. Node 1 Master, Node 2, 3 replicas
-Stop SQL_THREAD on Node 2 and Node 3
-Initiate some transactions on Node 1. They will go through because IO_THREAD is still up.
-Kill -9 mysql on Node 1.
-Watch Orchestrator promote one of the replicas as new master even with lag.
-Check the transactions started in step 2. They will be TOTALLY MISSING on the new master and the replica.
-Start MySQL Node 1.
I figured this could be because when SQL_THREAD is down, the Seconds_Behind_Master is NULL when you run show slave status\G; I have not configured anything for SlaveLagQuery in orchestrator.conf.json, is that the reason why orchestrator ignores the lag and promotes a replica ? But I read somewhere that if this is not defined it will look in Seconds_Behind_Master but in my case, it will be NULL because SQL_THREAD was down.
How do I fix this ?  Any help is greatly appreciated !!!

Contents of /etc/orchestrator.conf.json :
{
  "Debug": false,
  "ListenAddress": ":3308",
  "MySQLTopologyUser": "orchestrator",
  "MySQLTopologyPassword": "xxxxx",
  "MySQLTopologySSLSkipVerify": true,
  "BackendDB": "sqlite",
  "SQLite3DataFile": "/usr/local/orchestrator/orchestrator.sqlite3",
  "MySQLConnectTimeoutSeconds": 1,
  "DefaultInstancePort": 3307,
  "DiscoverByShowSlaveHosts": true,
  "HostnameResolveMethod": "default",
  "MySQLHostnameResolveMethod": "@@report_host",
  "SlaveLagQuery": "",
  "DetectClusterAliasQuery": "SELECT 'abc-18172'",
  "DetectClusterDomainQuery": "",
  "DetectInstanceAliasQuery": "SELECT SUBSTRING_INDEX(@@hostname, '.', 1)",
  "DetectSemiSyncEnforcedQuery": "",
  "StatusEndpoint": "/api/status",
  "StatusSimpleHealth": true,
  "RecoveryPeriodBlockSeconds": 5,
  "RecoverMasterClusterFilters": [
    "*"
  ],
  "RecoverIntermediateMasterClusterFilters": [
    "*"
  ],
  "OnFailureDetectionProcesses": [
    "echo $(date -u \"+%F %T %Z\") - 'Detected {failureType} on {failureCluster}. Affected replicas: {countSlaves}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log"
  ],
  "PreFailoverProcesses": [
    "echo $(date -u \"+%F %T %Z\") - 'Will recover from {failureType} on {failureCluster}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log"
  ],
  "PostFailoverProcesses": [
    "echo $(date -u \"+%F %T %Z\") - '(for all types) Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log",
    "/usr/local/apps/mysql-failover/after-failover.sh {failedHost} {failedPort} {successorHost} {successorPort}"
  ],
  "PostUnsuccessfulFailoverProcesses": [
    "echo $(date -u \"+%F %T %Z\") - 'Unsuccessful failover process for {failureType} on {failureCluster}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log"
  ],
  "PostMasterFailoverProcesses": [
    "echo $(date -u \"+%F %T %Z\") - 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Promoted: {successorHost}:{successorPort}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log"
  ],
  "PostIntermediateMasterFailoverProcesses": [
    "echo $(date -u \"+%F %T %Z\") - 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' >> /usr/local/apps/orchestrator/logs/orchestrator-recovery.log"

 ],
  "RaftEnabled": true,
  "RaftDataDir": "/var/lib/orchestrator",
  "RaftBind": "xxx.xx.xx.xxx",
  "DefaultRaftPort": 3309,
  "RaftNodes": [
    "xxx.xx.xx.xxx", "yyy.yy.yy.yyy", "zzz.zz.zz.zzz"
  ],
  "GraphitePollSeconds": 60,
  "GraphiteAddr": "localhost:9109",
  "GraphitePath": "orchestrator"
}

Hi, a few things:

I figured this could be because when SQL_THREAD is down, the Seconds_Behind_Master is NULL

Use ReplicationLagQuery, https://github.com/openark/orchestrator/blob/master/docs/configuration-discovery-classifying.md#replication-lag, along with a heartbeat mechanism. The issue with Seconds_Behind_Master: NULL is unfortunately a common source for trouble. By injecting your own heartbeats and by monitoring the heartbeat through ReplicationLagQuery, you completely avoid the issue of NULL.
Consider setting FailMasterPromotionOnLagMinutes, https://github.com/openark/orchestrator/blob/master/docs/configuration-recovery.md#promotion-actions
or FailMasterPromotionIfSQLThreadNotUpToDate
or DelayMasterPromotionIfSQLThreadNotUpToDate
General suggestion: be very cautious about using OPTIMIZE TABLE. It makes a blockgin, complete rebuild of the table.

At the very least run OPTIMIZE LOCAL TABLE so that the command is not writen to the binary log (and then apply on each replica individually)
My suggestion: use an online schema change tool (pt-online-schema-change or gh-ost) to ALTER TABLE your_table ENGINE=InnoDB. This emulates the OPTIMIZE command, but does so online.

I tried #3 that you suggested - "FailMasterPromotionIfSQLThreadNotUpToDate": true,

Did you configure a heartbeat mechanism? What was the lag at time of failover/promotion?

I haven't set up the heartbeat mechanism yet, I was trying to use either FailMasterPromotionIfSQLThreadNotUpToDate and/or DelayMasterPromotionIfSQLThreadNotUpToDate to get this working.
[root@node1 logs]# tail -f orchestrator-recovery.log
2021-04-27 01:56:41 UTC - Detected AllMasterSlavesNotReplicating on node1:3307. Affected replicas: 2 << Even after detecting AllMasterSlavesNot replicating, why did the orchestrator promote a replica with lag as master ?
2021-04-27 02:00:07 UTC - Detected DeadMaster on node1:3307. Affected replicas: 2
2021-04-27 02:00:07 UTC - Will recover from DeadMaster on node1:3307
2021-04-27 02:00:09 UTC - Recovered from DeadMaster on node1:3307. Failed: node1:3307; Promoted: node2:3307
2021-04-27 02:00:09 UTC - (for all types) Recovered from DeadMaster on node1:3307. Failed: node1:3307; Successor: node2:3307
I was trying to add a script to PreFailoverProcess. Logic in that is.. if SECONDS_BEHIND_MASTER is NULL or slave_SQL_thread is NOT running, do NOT promote that node as master. When I tested this logic, it detects the condition, but I don't know how to make it quit the whole promotion process, it recognizes the condition but proceeds to failover anyways.

Per documentation, if you exit a pre failover hook with nonzero exit code, the failover aborts.

Thanks Shlomi-noach. Yes that part worked. Now I notice another issue, not sure if it's related to my change.
When the master and orchestrator leader run on the same node, if master is shutdown then orchestrator does not promote another node as master, it indefinitely waits for the master on node1 to come up. As a workaround, If I restart the orchestrator then another node gets promoted as master.

If the issue is solved, then please close it and open a new one, providing all necessary logs and data.

Intent of this issue was to add a preFailover hook and it worked. Closing this issue now. Thanks


Install Location Change

Is it possible to install it on any other Drive than C because the existing installation of Windows has left me with 44 GB of space. I'd like to install it on my Main OS not VM plus also on D Drive
Any ideas as to how ?

@PjAwasthi09 I think the best option would be to do a custom install and use the Lite profile, and then before you install go into the profile file and change the RAW_TOOLS_DIR variable to be something on the D: drive and that would install a good amount of tools onto D instead of C.
For what its worth, the recommended disk sizes include the size of windows. If you look at the profiles table in the link above, the Default profile will take 40 GB of space with windows.. So we install about 20 GB of tools.. If you have 44 GB left, you should be good. I would recommend also if you are going to be installing onto bare metal that you use the Nested V profile because that will install Kali and Docker for you. Also, I would recommend going through the tools in the json file and removing things you dont think are necessary for what you want to do (you can always install them later)

Ok Thanks for the reply 😊