Prometheus exporter for queue status

I'm starting to "prometheus all the things" in our rails application. They have support for ruby garbage collector, rails, puma, activerecord, etc, would this project be open to support on the semantic logger operational metrics?
I'd love to get stats like

Count of all log lines processed
Count of all rejected log lines
Size of queues
Thoughts on other properties to instrument?

I'm using: https://github.com/discourse/prometheus_exporter
I could author instrumentation for semantic logger but I'm not sure where to include it. I could put it in this code base? Or would you prefer it's a third party repo?
Perhaps this library could make a SemanticLogger.stats property like they do on Puma? I'm looking at https://github.com/puma/puma/blob/64c0153cd0bd2bb0fe85258e17dad538067c6484/lib/puma.rb#L28

Yes, adding stats directly to Semantic Logger would be a useful addition. Just be sure that it is thread safe and does not slow down each of the concurrent appenders. Some appenders have their own queues and worker threads too.


CSharpExpressionPrinter: Wrap expression in parenthesis

Wrap default parameter expressions in parentheses to ensure whole expressions are casted instead of only the first operand.
This fixes the case when the C++ source contains enum flags ored with each other as default parameters.
For example, this code
			status_t			StartWatching(BMessenger target,
									uint32 eventMask
										= B_REQUEST_LAUNCHED
											| B_REQUEST_QUIT) const;

gets incorrectly translated to:
        public int StartWatching(global::Haiku.App.BMessenger target, uint eventMask = (uint) global::Haiku.App.WatchingRequestFlags.B_REQUEST_LAUNCHED | global::Haiku.App.WatchingRequestFlags.B_REQUEST_QUIT)

which causes an error:
/home/trung/cppsharp/generated/App.cs(9986,88): error CS0019: Operator '|' cannot be applied to operands of type 'uint' and 'WatchingRequestFlags' [/home/trung/cppsharp/HaikuApiGenerator.csproj]

Wrapping with a pair of parentheses should fix this issue:
        public int StartWatching(global::Haiku.App.BMessenger target, uint eventMask = (uint) (global::Haiku.App.WatchingRequestFlags.B_REQUEST_LAUNCHED | global::Haiku.App.WatchingRequestFlags.B_REQUEST_QUIT))

Can you add a test to https://github.com/mono/CppSharp/blob/main/tests/dotnet/Common/Common.h?

Done. Also added a corresponding function in Common.cpp.


Add the ability to specify --runtime options in the container creation

Hi, I've finished the job implementing "runtime" in portainer.
docker run -d  --runtime=nvidia tensorflow/tensorflow:1.6.0-gpu-py3

I am about to make a pull request. Please add me into the contributor.

Hi @ru1996
Thanks for opening this issue ! Please open a pull request from your fork, it works fine as well.


Genericize consumer builder API.

Uses Into<String> and IntoIterator<Item=_> to genericize the builder API.
This is in fact a breaking API change, unfortunately. Consider this example:
let builder = Consumer::from_hosts(Default::default());

This will not compile without generics specified on the argument in this PR. Before, it would work. Something to consider when merging. However, you should no longer need to call to_owned()/String::from(_)/etc on builder arguments.
The examples still need to be adjusted to take advantage of this.
Resolves #120

this looks great to me! many thanks!

may i ask you to extend this to KafkaClient::new/new_secure as well as Producer::from_hosts for the sake of consistency?
also, would it be possible to update the documentation (rustdoc) to avoid the calls to .to_owned()?
can you also update the examples?

btw1: i wouldn't be concerned about the public api breakage for the case you've found. this is still backwards compatible, since making a call to Consumer::from_hosts(Default::default()); makes no sense (i would immediately lead to NoHostReachable and/or UnknownSuchTopicOrPartition errors as soon as interacting with kafka-rust). in other words, i doubt there are users using Default::default() to specify the bootstrap hosts. so far it seems OK with me to release this as part of the current 0.5.x.
btw2: the only unfortunate effect i can see is that a passed-in Vec<String> of the "bootstrap" hosts gets allocated once more in existing code. given that creating KafkaClients, Consumers, and/or Producers is very likely not on any critical path, i'm absolutely fine with this for the provided flexibility.
so far, once more many thanks!

It's probably worth putting into the changelog just to make sure people are aware, i.e. there may be be a practical purpose to .with_group(Default::default()) (empty group name being groupless consumption), or there may be non-trivial situations where type inference fails.
For the Vec reallocation, yes, I don't think there will be a way to work around that problem without impl specialization. But it shouldn't matter that much. There is a practical usefulness of being able to choose between slices, arrays, vecs, and other iterables, yeah.
I will work on the KafkaClient and Producer APIs when I have some free time today.

ah ... yes, you are right about .with_group(..); will put a note to the release notes.

This is a little bit more complicated than I was expecting it to be, because Deref doesn't work in the context of From/Into well, and such &["host1", "host2"][..] is not convertible to Vec<String> when using IntoIterator and Into. It's a bit of an language ergonomics issue. I'm going to close this and attempt it when I have more time to work on this. Sorry for the inconvenience.

hm, that's a pity! :(


Add alternative syntax (*) support

Add alternative syntax (*) support
Some improve stream op

Fix #1.
I will add synlink or same later.


Show error

… found

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

@BrianBlum, @sanbhatt, Fixed AMS show commands when resource not found.

@Juliehzl

Hi all,
My last day with AMS is Monday, September 30th. Could everybody expedite the review process?
Thanks
Jinlin

@haroldrandom please help with this PR.

The command's tyle is not in line with Command Guidelines， closed until fixed.
Feel free to reopen and open a fresh new one

@haroldrandom, when you say that the command's style is not in line with the Command Guidelines, do you mean that the commands should return None when a resource is not found?

Sorry, I made a mistake, the style is fine. I will review your code ASAP.

@BrianBlum Sorry for the late reply. Our team is too busy to other things the other day, just focusing to switch to close PRs just now. We are so sorry about your PR not reviewed in time.
This code looks fine to me. But just confilicts there due to long time no merge, some bugs may fixed.
Again, sorry about that.
Could you please make sure that this changes are okay with the latest commit of dev branch by rebasing your code? (I am afraid a lack of knowledge about AMS module of me cannot resolve the confilts that involved in this month.)
If rebase is fine, then I will start to merge it. Thanks~

@haroldrandom, I'll take another look at this PR. I was using the production CLI yesterday and it looks like it addresses the same issues that this PR was trying to address, namely, posting a message if a resource is not found. If there are any gaps, I'll submit a new PR.

@haroldrandom how about this PR ?

@BrianBlum Any update?

Closed as discussion. Feel free to reopen.


Editorial review of DCGM

What does this PR do?
Editorial reviews for the original PR: https://github.com/DataDog/integrations-core/pull/14589
Motivation
The PR had to be merged before I had a chance to review it.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Unfreezing and merging because this won't get shipped with the agent, and anyway we haven't branched off the release yet.


[RFC] Checkbox implementation

Im thinking on the implementation of the checkbox functionality, and ended in this idea:

work with an array of options, like select field
options array will contain id and label (each option)
getValue will return an array of checked ids

Well, let me know what you think about

Should we use the same component for checkbox and radio? I mean, something like select that we can have multiple or not.

I thought about it, and make some sense.
One concern about it is when I have a single option and want a checkbox, like an "Accept terms...". In that option, Ill have a component with only one option with a multiple property to allow checkbox.
Obviously, it is fully customizable.
Ill publish an PR with it soon and than we discuss more

PR #27
Some rules:

returns for multiple selection (checkboxes) are undefined or an array
returns for single selection (radios) are undefined or an string
if only one option is specified, checkbox will be used
labels are optional

I was thinking about this issue and the way unform works now. Basically unform only supports having one ref per form element, but what if we supported multiple refs per element and then the result comes in one array?
We could pass something like:
registerField({ name: fieldName, ref: [ref1, ref2, ref3], path: "value" });

Then Unform could translate this value to: [1, 2, 3].
What do you think?

Well, in my opinion, the actual solution (only one ref) is better.
If we have to pass multiple refs, maybe we have to pass multiple path too.
Why not a getValue function like before or something like that?

With the actual implementation with registerField inside useEffect getValue was not returning the actual value of the element so instead of using it, we changed to this ref approach.
Accepting multiple refs doesn't need multiple paths tho, since all the refs can have the same path to value.
I don't know, but with refs we have zero rerenders in React, i like this approach.

What do you guys think about it? I mean by adding multiple refs to one form element, so checkbox component will look like this:
registerField({
  name: fieldName,
  ref: [ref1, ref2, ref3],
  path: "value"
});

The main problem here is that every checkbox has a value, but they are not always selected, and we need to get the value only from selected ones, so parseValue couldn't do this job as he only receives the value itself, not the input reference.
Maybe parseValue could receive ref as a second parameter to search for selected property inside the checkbox?

Now, speaking about the implementation itself, maybe we could have a Choice (i don't like this name) component that is responsible for both checkbox and radios, so checkbox when multiple, radio when single, but maybe we could have and Boolean component that only renders a checkbox alone in case of "Accept terms" or "Change password".
Can you share your thoughts about this RFC @jpdemagalhaes and @pellizzetti?

Hi, I tried to put your idea in place
Can you check this this branch to see if it fits your idea?
I added multiple refs to a field and an optional method to extract value from refs (getValues).
I think that the parseValues have another context (maybe concat values to backend, convert strings to numbers, etc...)
ps.: I dont like Choice name too, but I have no better name for now.

@rfbezerra Great! Maybe you can send a PR and we can discuss more about the implementation there?

About the name, how about we call Switch?

OMG! All that I need. When will this be released?

@jeancabral, it was released yesterday, in v1.6.1  🎉  If you want to use, do not forget to upgrade to the correct version. I am also closing this issue due to the fact it was merged in #110.


Fix openapi-gen

What this PR does / why we need it:
While upgrading to go1.13 we broke generating in staging/. This PR disable modules(in this one case) so packages will be matched.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @rmohr @davidvossel

While upgrading to go1.13 we broke generating in staging/. This PR disable modules(in this one case) so packages will be matched.

@xpivarc can we get a little more details around how this solves the problem?

I tested this and can confirm it did fix the issue for me.

@davidvossel Sorry for being late... Since go1.13 uses modules go $target ./...   thought it's in a module and the wildcard ./... didn't match client-go/api/v1 files/packages.


Feature request.

How to remove port number and index.php for production use. I also tiring understand how to add database to the OJS. I think making a good wiki or add database in docker file will help. I am just testing docker with ojs and i found it will be helpful for many who wants to use docker for ojs.
I am not a coder i am a ojs maintainer for a journal.

yes, I thing my docker compose example will help you


Fix success comment for fabric8-analytics/f8a-hpf-insights

Fixes the "MISSING_IMAGE_NAME" issue: https://github.com/fabric8-analytics/f8a-hpf-insights/pull/15#issuecomment-399834723.


Add RemoteCertificateValidationCallback to ActiveMQ

Discussed in https://github.com/MassTransit/MassTransit/discussions/4681

Originally posted by rsr-maersk October  2, 2023
Referring to this PR last year: https://github.com/MassTransit/MassTransit/pull/4682
I require setting RemoteCertificateValidationCallback due to how my current customer handles its certificates.
I am happy to share any more details if you want.
I will deliver a PR soon and would love your input.

I'll review it once it has been submitted.

It does not look like the NSMConnectionFactory exposes any SSL configuration. Are you familiar with this ConnectionFactory for ActiveMQ @phatboyg ?

No, I am not, which is why I never did anything with the previous PR that didn't do anything either.

After some digging, I discovered you cannot set this callback function using this ConnectionFactory.
Luckily I found another setting that fulfilled my requirements.
Adding my solution for any future readers;
I needed to set up an SSL connection with my broker who has a self-signed certificate. When i tried this without providing any extra settings i just got the following error:
The remote certificate was rejected by the provided RemoteCertificateValidationCallback. , hence why I wanted to override this callback to provide custom logic for solving this.
But after digging more into the Apache.NMS.ActiveMQ library, I found out that passing transport.brokerCertFilename in the transport options would trigger a function specifically for validating self-signed certificates. By passing the public certificate in this parameter, I managed to get it to work.
var transportOptions = new List<KeyValuePair<string, string>> {new ("transport.brokerCertFilename", activeMqSettings.BrokerCertificateFilePath)};
Any change to this repo is not required, so i will close this issue :-)


Bug fixes + more credit (Thank you!)

Hello! I wanted to just thank you (and fix some bugs lol) for continuing this project.
Changes

Fixed the background in HelpState.hx
Added you into the credits in-game (See LoadingState.hx:55)
Made it so the name you input in MainMenuState.hx saves to the game save
Fixed 2 issues that caused crashes in Plant.hx (It still crashes because something is null, I'm assuming it's the animation)

GitHub is angering me, I hope this did what I think it did


Maybe a bug

I did some fuzzing on the 0.21b for the purpose of research and I found the program crashed because of invoking load_kids many times. After I analysed the sample pdf and backtrace, I found the xref was modified, causing the recursive invocation and making esp surpass the range of stack. Just like below.
[#0] 0x7ffff7a8ebbc → _int_malloc(av=0x7ffff7dd1b20 <main_arena>, bytes=0x201)
[#1] 0x7ffff7a902b0 → _int_realloc(av=0x7ffff7dd1b20 <main_arena>, oldp=0x655890, oldsize=0x110, nb=0x210)
[#2] 0x7ffff7a91839 → __GI___libc_realloc(oldmem=0x6558a0, bytes=0x200)
[#3] 0x404c17 → get_object(fp=0x609010, obj_id=0x4, xref=0x6092c0, size=0x0, is_stream=0x7fffff7ff254)
[#4] 0x404e76 → load_kids(fp=0x609010, pages_id=0x4, xref=0x6092c0)
[#5] 0x404fc5 → load_kids(fp=0x609010, pages_id=0x6, xref=0x6092c0)
[#6] 0x404fc5 → load_kids(fp=0x609010, pages_id=0x6, xref=0x6092c0)
[#7] 0x404fc5 → load_kids(fp=0x609010, pages_id=0x6, xref=0x6092c0)
[#8] 0x404fc5 → load_kids(fp=0x609010, pages_id=0x6, xref=0x6092c0)
[#9] 0x404fc5 → load_kids(fp=0x609010, pages_id=0x6, xref=0x6092c0)

obj 3 has 2 kids and load_kids next locates the obj 4 and obj 6 according to xref.
3 0 obj
<<
/Type /Pages
/Count 2
/Kids [ 4 0 R 6 0 R ]
>>
endobj

However xref is modified and the offset of obj 6 is 152 analysed from atol instead of 1522 in normal sample. So when invoking load_kid with kid_id=6, it actually goes back to obj 3 with some data before /Kids ruined.
xref
0 11
0000000000 65535 f
0000000019 00000 n
0000000093 00000 n
0000000147 00000 n // obj 3
0000000222 00000 n
0000000390 00000 n
000000152² 00000 n // obj 6
0000001690 00000 n
0000002423 00000 n
0800002456 00000 n
0000002574 00000 n

So it's better to check before invoking atol, making sure the characters are legal or use some algorithms to detect the recursive solution.

A PoC: sample.pdf

Thanks for the POC and bug report.  This definitely looks to be a problem.  I can try to get a patch up for this, but not sure when.

I have a fixed branch that I need to run through my tests.  The kid page functionality was not active, so I've removed it.  I'd prefer to rewrite that logic if I do choose to make use of the kid pages in a future release.  But for now, it's unused.  Also, your bug report was super helpful and well described! Thanks a ton for that! https://github.com/enferex/pdfresurrect/tree/remove-kidpage-loading

I have a fixed branch that I need to run through my tests. The kid page functionality was not active, so I've removed it. I'd prefer to rewrite that logic if I do choose to make use of the kid pages in a future release. But for now, it's unused. Also, your bug report was super helpful and well described! Thanks a ton for that! https://github.com/enferex/pdfresurrect/tree/remove-kidpage-loading

No problem. :-)

I'll also give you a shout out in the contributors file (aka AUTHORS).


Filters broken with mongoid field alias

I am using rails_admin with mongoid. When using mongoid's :as options, filters in rails_admin stop working.
For example, the following works as expected:
class A
    include Mongoid::Document
    field :long_name, :type => String
    rails_admin do
        list do
            filters [ :long_name ]
            field :long_name
        end
    end
end

While this does not:
class A
    include Mongoid::Document
    field :long_name, :as => :l, :type => String
    rails_admin do
        list do
            filters [ :long_name ]
            field :long_name
        end
    end
end

The name of the field has changed from :long_name to :l, :long_name is now stored in field.options[:as]. Mongoid maps between both names transparently, rails_admin does not. A workaround exists:
class A
    include Mongoid::Document
    field :long_name, :as => :l, :type => String
    rails_admin do
        list do
            filters [ :l ]
            field :l
        end
    end
end

For better readability and consistency with mongoid's behavior, rails_admin should   map between field names and aliases. It should be possible to use either the field name or the alias everywhere.
I would like to provide a pull request, if you can point me in the right direction. Is there a central place in rails_admin's mongoid adapter where field name resolution is taking place? Where should I start looking, or how would you go about improving this?

Dup of #1745.


User does not get an error dialog when opening the manual is not supported

On my current (new) system, opening the manual fails with this error:
Exception in thread "Thread-7" java.lang.UnsupportedOperationException: The BROWSE action is not supported on the current platform!
	at java.awt.Desktop.checkActionSupport(Desktop.java:225)
	at java.awt.Desktop.browse(Desktop.java:381)
	at at.fhtw.mcs.controller.RootController.lambda$13(RootController.java:608)
	at java.lang.Thread.run(Thread.java:745)

The user should get our regular error dialog in this case.

Fortunately this was only a matter of adding another condition before trying to open the browser.


No GL850G available

Hello, since I cannot find a GL850G anywhere, do you know any drop-in replacements for that part?
Thank you~!

https://octopart.com/search?q=GL850G
Looks like there are 10s of thousands in stock around the world.


Is this project still under maintenance?

Is there an existing issue for this?

[X] I have searched the existing issues

Version
master
Description of the issue
Our dev-team want to move from azure-iot-sdk-c to Azure Iot Middleware for FreeRTOS or azure-sdk-for-c to save resourcess on our embedded target. Now we are not sure if this is the right choice because there is no commit in the last year. The last release is mor than 2 years ago. Is this project still under maintenance?
@danewalton i saw you in the video. Can you tell use something about that? Which SDK would you recommend on an embedded target like the esp32?
Expected behavior
No response
Steps to reproduce the issue
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

We also have concern about following remark under porting mqtt: THIS FEATURE IS IN PREVIEW AND THE API IS SUBJECT TO CHANGE

Yes it is. Is there anything particular you need?

THIS FEATURE IS IN PREVIEW AND THE API IS SUBJECT TO CHANGE

This is referring to the MQTT abstraction layer feature and not the SDK. Currently we don't fully support swapping out the MQTT layer from CoreMQTT.

Also, please note, this is a freeRTOS wapper for the actual embedded IoT SDK. This SDK handles the freeRTOS interaction. The IoT hub features are implemented and exposed on the IoT Hub SDK.
https://github.com/Azure/azure-sdk-for-c

closing this issue


🐛 Submission of Treasury Gov action fails

Area
Proposal Pillar
Domain
preview.gov.tools
Which wallet were you using?
Eternal
Context
Submitting a treasury withdrawal proposal as Gov Action currently fails with the following console log.
index-bf5a9cfe.js:90 TypeError: Cannot read properties of undefined (reading 'forEach')
    at Object.buildTreasuryGovernanceAction (index-bf5a9cfe.js:414:50234)
    at app.cjs-df80b02d.js:139:140290
    at M2 (app.cjs-df80b02d.js:85:12569)
    at Generator.<anonymous> (app.cjs-df80b02d.js:85:14053)
    at Generator.next (app.cjs-df80b02d.js:85:13032)
    at _s2 (app.cjs-df80b02d.js:85:10225)
    at F (app.cjs-df80b02d.js:85:10436)

Here is a screenshot of submission:

Steps to reproduce

Create a normal treasury withdrawal proposal
From the proposal, try submitting as Governance action
Follow the guided form to download and host the metadata data.jsonld and fill in the metadata URL
Click submit to submit the govenance action.
Nothing happens on the UI after the progress spinner disappears.
Check console

Actual behavior
Submission of the treasury withdrawal proposal as governance action leads to a progress spinner which disappears and nothing happens.
Expected behavior
User should have been asked to sign the transaction and the treasury withdrawal governance action should have been successfully submitted.
Related issue:

https://github.com/IntersectMBO/govtool/issues/1845

That is on the pillar side.
API of the builder has changed to support multiple addresses which is not yet supported in pdf-ui-v0.5.1.
Here is the documentation on how to build that transaction:
https://github.com/IntersectMBO/govtool/wiki/How-to-submit-a-Governance-Action-using-GovTool


python 3 + "setup.py test" fails at test_shared_data_middleware

Hi,
While packaging werkzeug for python 3 for Arch Linux, I encountered an error when running setup.py test. The error only happens when building in a chroot (like we do when building official packages).
test_shared_data_middleware (werkzeug.testsuite.wsgi.WSGIUtilsTestCase) ... ERROR
test_shareddatamiddleware_get_file_loader (werkzeug.testsuite.wsgi.WSGIUtilsTestCase) ... ok

======================================================================
ERROR: test_shared_data_middleware (werkzeug.testsuite.wsgi.WSGIUtilsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/python-werkzeug/src/python-werkzeug-0.9.1/werkzeug/testsuite/wsgi.py", line 36, in test_shared_data_middleware
    with open(path.join(test_dir, to_native(u'\xe4\xf6\xfc', 'utf-8')), 'w') as test_file:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 15-17: ordinal not in range(128)

----------------------------------------------------------------------
Ran 317 tests in 1.662s

FAILED (errors=1)

To reproduce the error on Arch Linux, the following should do the trick:
sudo pacman -S devtools base-devel subversion
svn checkout --depth=empty svn://svn.archlinux.org/community
cd community
svn up python-werkzeug
cd python-werkzeug
sudo extra-x86_64-build

When built with makepkg instead, the test seems to pass.

Commenting in the "check" function in the PKGBUILD should do the trick.
Can confirm that this is still an issue.    Wait for command to complete.  If
        the exit code was zero then return, otherwise raise
        CalledProcessError.  The CalledProcessError object will have the
        return code in the returncode attribute.

        The arguments are the same as for the call function.  Example:

        check_call(["ls", "-l"])
        """
        retcode = call(*popenargs, **kwargs)
        if retcode:
            cmd = kwargs.get("args")
            if cmd is None:
                cmd = popenargs[0]
>           raise CalledProcessError(retcode, cmd)
E           subprocess.CalledProcessError: Command '['python', '/tmp/pytest-0/test_monkeypached_sleep0/app/test.py']' returned non-zero exit status 1

/usr/lib/python3.4/subprocess.py:561: CalledProcessError
----------------------------- Captured stderr call -----------------------------
Traceback (most recent call last):
  File "/tmp/pytest-0/test_monkeypached_sleep0/app/test.py", line 11, in <module>
    from werkzeug._reloader import ReloaderLoop
ImportError: No module named 'werkzeug'
_________________________ test_shared_data_middleware __________________________

tmpdir = local('/tmp/pytest-0/test_shared_data_middleware0')

    def test_shared_data_middleware(tmpdir):
        def null_application(environ, start_response):
            start_response('404 NOT FOUND', [('Content-Type', 'text/plain')])
            yield b'NOT FOUND'

        test_dir = str(tmpdir)
>       with open(path.join(test_dir, to_native(u'\xe4\xf6\xfc', 'utf-8')), 'w') as test_file:
            test_file.write(u'FOUND')
E           UnicodeEncodeError: 'ascii' codec can't encode characters in position 43-45: ordinal not in range(128)

tests/test_wsgi.py:36: UnicodeEncodeError
=============== 3 failed, 405 passed, 10 skipped in 3.44 seconds ===============

Yeah the problem is that LANG is either missing or set to an ASCII encoding. Overriding it should do the trick. There's not much we can do about this, Python 3 completely breaks down in ASCII + Unix envs.

LANG=C when the package is building (added echo $LANG to the PKGBUILD to check).

Yup, try to set it to LANG=en_US.UTF-8 or really anything that ends with .UTF-8. Or better: Inherit the variable from the outer env (to verify that Werkzeug works well on this particular system).

I see. Would it be possible to disable the tests if LANG is set to C, or would that be a too dirty workaround?

I think we could definetly show a better error message for that situation, but as said, a better idea is to inherit the LANG variable from outside the chroot.
Skipping the tests feels kinda weird and implicit if the user already chose to run those.

I've reopened this regarding the better error message.

LANG=C tox -e py3,py2 doesn't fail, but does output a clear warning about forcing UTF-8 for the filesystem encoding.


obs: Do not wait on excluded packages

In case a package in obs is excluded ie no longer being built,
do not wait for it to be built. Wait as long as there are packages
being built or blocked on others to be built.
Fixes #815
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

/AzurePipelines run

/test

/AzurePipelines run

/test


[ops] Smoke test for router/sequencer with config

Use docker-compose to run router and sequencer and make sure they come up and router can ping the sequencer.

Done in https://github.com/connext/nxtp/pull/921


tlock-go: 3 dependencies have vulnerabilities

Have looked into this - all are transitive dependencies from drand/drand. Curiously, tlock pulls in the whole of drand rather than just the client, and running go get github.com/drand/drand/client seems to do this.
Updating the downstream dependency on quic-go requires an update to a libp2p lib, which I've raised a PR for here

actually quic-go has already been upgraded in newer versions of drand. I've raised a PR to update tlock-go deps here: https://github.com/drand/tlock/pull/58

fixed in #58


Project maintainability

Hello,
I was wondering if this project is still maintained. If not, could you give me some directions towards any relatively similar ongoing project?
Thanks,
Ricardo

9 months late but I've created a new project called cloudproxy - https://github.com/claffin/cloudproxy.
It is similar to scrapoxy and I started it for the very reason that this project seems abandoned.

Thanks!
Duplicate of https://github.com/fabienvauchelles/scrapoxy/issues/209


HAML + gettext conversion - the rest

The last erb->haml conversion.
(Except for ./assets/javascripts/dynatree_1.2.4/skin-cfme/ui.dynatree.css.erb, ./assets/stylesheets/template.css.erb, and PR#1710)
Please note that none of the ldap* files in this batch were actually tested, because they are not reachable at the moment.

I have restarted the travis, now green. Also the code looks good.
@romanblanco, @jzigmund : you did work witn @himdel on finding these in the UI. Can you verify the changes in the UI, and drop me here a note, please?

Rebased, fixed the user_type asssignment, and snuck in a random fix to @skateman's _report_list - assuming no = _("Yes") was not really intentional.
Some changes from @romanblanco will be coming shortly.

@martinpovolny Checked my part. Found some issues and discussed with @himdel. Should be OK now.

Added fixes from rblanco, some missing gettext and useless assignment removal elsewhere...
We still have a few files with something like if condition ||<newline> which haml-lint carps about (unexpected kEND), I'll check these out and add here too.

OK.. about if condition ||<newline>...
- if foo ||
- bar
  output

is fine, however, haml-lint can't handle it.
OTOH

if foo ||
bar
output

Is wrong (outputs bar).
I fixed the 1 file which was wrong, but not to haml-lint's satisfaction. Now we can either fix haml-lint/RuboCop or merge the lines in these conditions. @skateman ? Anyone?
Only 3 files are affected:
layouts/_dhtmlxlayout_explorer.html.haml
95:    - if (@layout == "chargeback" && (x_node == "root"                                               ||
96:    -     x_active_tree == :cb_assignments_tree || (x_active_tree == :cb_reports_tree && !@report))) ||
97-    -    ["miq_capacity_bottlenecks"].include?(@layout)
98-      #{layoutb_name}.cells("a").collapse();

layouts/_adv_search_footer.html.haml
37:      - if (session[:userrole] == "super_administrator" || session[:userrole] == "administrator") ||
38-      -    (session[:userrole] != "super_administrator" && session[:userrole] != "administrator" &&
39-      -    @edit[@expkey][:selected][:typ] == "user")

miq_ae_class/_class_props.html.haml
2:  - if x_node.split('-')[0] == "aec" || params[:pressed] ||
3:  -    ["field_select","field_accept","field_delete"].include?(params[:action]) ||
4-  -    (x_node.split('-')[0] == "aen" && params[:button] == "reset")
5-    - if !@in_a_form_props

(in vm_common/_console_vmrc.html.haml it's in :javascript block and therefore fine)


FE-Assignment-1

Metric
Value

alert_status
:white_check_mark: OK

bugs
3

code_smells
4

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


remove -it from example, as it's not needed for redis

Adding -it on a "detached" (-d) container is needed
if the container's main process expects a TTY attached to keep
running.
It's not needed for a redis container, so we can remove it here
fixes https://github.com/docker/docker.github.io/issues/10632

@usha-mandya PTAL


how to do unit test

I try to test Login.js (https://github.com/marmelab/admin-on-rest/blob/master/src/mui/auth/Login.js) as follow but it's not work:
import { shallow } from 'enzyme';
import expect from 'expect';
import configureStore from 'redux-mock-store';

const mockStore = configureStore();
const initialState = {
    locale: 'en',
};
const messages = {
    en: {
        aaa: 'bbb',
    },
};
const store = mockStore(initialState);
const context = {
    store,
    locale: 'en',
    translate: f => (f),
};
let container;

describe('<Login /> test', () => {
    beforeEach(() => {
     container = shallow(<Login />, {context});
    });

    it('=> should render itself & children', () => {
        expect(container.length).toEqual(1); // this work
        expect(container.find('form').length).toEqual(1); // not work
        expect(container.find('RaisedButton').length).toEqual(1); // not work
    });
});

how to do unit test on Login.js and similar components?

The admin-on-rest core team doesn't provide support or advice on debugging your own project. We need to focus on writing documentation, fixing bugs, and adding new features.
Instead, we've decided to offload that charge to the community, by moving support to StackOverflow. Ask your question there, you will find helpful people (sometimes from the core team, too). Besides, the response to your question will be easy to find for future developers with a similar problem.
And once you get a response, please continue to hang out on the admin-on-rest channel in StackOverflow. That way, you can help newcomers and share your expertise.
http://stackoverflow.com/questions/tagged/admin-on-rest


Add apiserver heartbeat with conntrack

:warning: :warning: aanm note to reviewers / backporters: This fixes a bug that needs to be backported to 1.7/1.6 but we should only do it after heavily testing it.
Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin.
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Adding a periodic heartbeat to check for stale connections to the apiserver. If a request takes too long then client-go's conntrack dialer close connections function is called for all client types.
Fixes: #9792
When running in Kubernetes, Cilium will run a periodic heartbeat and close all open Kubernetes client connections if the active connections become unresponsive.

This change is

@aanm I think it might make sense to use context.WithTimeout to achieve a heartbeat timeout. I notice that client-go has added supporting context.Context very recently upstream. When does the forked client-go get changes merged in, is this something I could do?

Coverage decreased (-0.009%) to 44.546% when pulling e37155263b143673a95baac3adfd26bcb6f66b81 on tom-hadlaw-hs:conntrack into 46300783b166ac13300d78113e99a2a6e1cbf534 on cilium:master.

@aanm I think it might make sense to use context.WithTimeout to achieve a heartbeat timeout. I notice that client-go has added supporting context.Context very recently upstream. When does the forked client-go get changes merged in, is this something I could do?

The context.WithTimeout could fail for other reasons, e.g. the server was overloaded to serve the request, in this case it would be better to not try to create a new connection or we will overload the server even more.
Adding support for context.Context in Cilium so it can be used with kubernetes library is very welcome.

@aanm Yeah, it's a bit tricky as a network connection silently failing causes calls to apiserver to hang for as long as the kernel doesn't time out the connection. I'm not sure if using context.WithTimeout would solve this issue but i'll play around with it. I'm wondering if that's just a side effect of client-go's retry logic built on top of golangs net libraries.
Adding a flag makes sense, I'll add that.
Kubelet seems to just use a basic client so I'm actually not sure if/how it would avoid the same situation we're seeing. I'll look into it deeper to find out. Currently it just uses context.TODO().

For reference, heres where the Kubelet performs its heartbeat: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_node_status.go#L423
What are your thoughts about a flag that enables/disables the heartbeat feature?

I decided to use the underlying client-go rest client to just request the healthz endpoint, instead of making actual resource requests, as I'm worried this could be adding too much load on the apiserver with a sufficiently sized cluster.
It deviates with kubelet's implementation of this but as far as I can tell their approach doesn't actually solve the issue described in that thread.

@aanm I just re-ran the upgrade process test, I can no longer reproduce this issue using this method. It seems as though Amazon might've changed the behavior of their rollout process.
After the upgrade completes, cilium-agent pods restart with the following message:
error: http2: server sent GOAWAY and closed the connection; LastStreamID=3, ErrCode=NO_ERROR, debug=""
So it looks like Amazon is trying to prevent similar issues from happening by notifying that the connection is about to close.
Note: I've been testing my changes by adding IP table rules blocking traffic to kubernetes service endpoints, which functionally appears to do the same thing as EKS.

I also wanted to mention that I've found an issue/PR on golang net library itself which seeks add application layer pinging on http2 connections to fix issues such as this one. This would likely be the ideal solution to all this, whenever that change is released.

test-me-please

Rebased the branch, seems like the Ginko tests where failing to provision test servers when it last failed.

test-me-please

Tests where failing on a documentation diff test, should be solved now @aanm

test-me-please

01:12:13      runtime: ../operator/cilium-operator --cmdref /tmp/tmp.lIHAuZ3tWZ
01:12:13      runtime: make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/Documentation'
01:12:13      runtime: diff -x '*.rst' -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.lIHAuZ3tWZ/cilium-agent.md
01:12:13      runtime: 108c108
01:12:13      runtime: <       --k8s-heartbeat-timeout                         Configures the timeout for api-server heartbeat, set to 0 to disable (default 30s)
01:12:13      runtime: ---
01:12:13      runtime: >       --k8s-heartbeat-timeout duration                Timeout for k8s heartbeat (default 30s)
01:12:13      runtime: diff -x '*.rst' -r ./Documentation/cmdref/cilium-operator.md /tmp/tmp.lIHAuZ3tWZ/cilium-operator.md
01:12:13      runtime: 41c41
01:12:13      runtime: <       --k8s-heartbeat-timeout                   Configures the timeout for api-server heartbeat, set to 0 to disable (default 30s)
01:12:13      runtime: ---
01:12:13      runtime: >       --k8s-heartbeat-timeout duration          Timeout for k8s heartbeat (default 30s)
01:12:13      runtime: Detected a difference in the cmdref directory
01:12:13      runtime: diff -r: diff -r ./Documentation/cmdref/cilium-agent.md /tmp/tmp.lIHAuZ3tWZ/cilium-agent.md
01:12:13      runtime: 108c108
01:12:13      runtime: <       --k8s-heartbeat-timeout                         Configures the timeout for api-server heartbeat, set to 0 to disable (default 30s)
01:12:13      runtime: ---
01:12:13      runtime: >       --k8s-heartbeat-timeout duration                Timeout for k8s heartbeat (default 30s)
01:12:13      runtime: diff -r ./Documentation/cmdref/cilium-operator.md /tmp/tmp.lIHAuZ3tWZ/cilium-operator.md
01:12:13      runtime: 41c41
01:12:13      runtime: <       --k8s-heartbeat-timeout                   Configures the timeout for api-server heartbeat, set to 0 to disable (default 30s)
01:12:13      runtime: ---
01:12:13      runtime: >       --k8s-heartbeat-timeout duration          Timeout for k8s heartbeat (default 30s)
01:12:13      runtime: Only in ./Documentation/cmdref: cli_index.rst
01:12:13      runtime: Only in ./Documentation/cmdref: index.rst
01:12:13      runtime: Only in ./Documentation/cmdref: kvstore.rst

@tom-hadlaw-hs this still requires documentation updates.

I hope that fixes it, I'm having trouble running the postcheck tests locally to verify

test-me-please

test-me-please

test-me-please


Write conventions for naming icons

Good one.
We now use more of a mix. I think I like the idea of naming the icons what is is presenting, we already do for a lot of icons, instead of naming it to the function or purpose of the icon.

that means we'll have to rename a lot of icons (e.g. settings, edit)

@delnyn sort of true. This solution can have a big impact

or we can just write a naming convention without changing the name of the existing icons

Done in #1518.
See: https://lucide.dev/guide/design/icon-design-guide#naming-conventions


Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.7

Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.7:display-plugin-updates (default) on project crs-catalog-core: Execution default of goal org.codehaus.mojo:versions-maven-plugin:2.7:display-plugin-updates failed. NullPointerException -> [Help 1]
Getting above error on running maven clean install
The plugin in pom.xml is

org.codehaus.mojo
versions-maven-plugin
2.7

compile

display-dependency-updates
display-plugin-updates

The latest version of plugin is 2.17.0 please try it.
Please also provide a stack output with executing mvn -e ....
As usual the minimal project which can reproduce issue will be appreciated.

Please reopen when you have the same issue with the latest version of plugin


sst tunnel install can't find sudoers.d

sudo sst tunnel install --print-logs

time=2024-10-14T22:39:16.190+02:00 level=INFO msg="checking for pulumi" path=/root/.config/sst/bin/pulumi
time=2024-10-14T22:39:17.521+02:00 level=INFO msg="checking for bun" path=/root/.config/sst/bin/bun
time=2024-10-14T22:39:17.523+02:00 level=INFO msg="bun install"
⠋  Updating dependencies...time=2024-10-14T22:39:17.523+02:00 level=INFO msg="bun downloading" url=https://github.com/oven-sh/bun/releases//download/bun-v1.1.29/bun-linux-x64-baseline.zip
time=2024-10-14T22:39:25.484+02:00 level=ERROR msg="exited with error" err="open /etc/sudoers.d/sst-zvictor: no such file or directory"
✕  Unexpected error occurred. Please run with --print-logs or check .sst/log/sst.log if available.

I'm running sst v3.2.16 on NixOS 24.05.
This error is most likely related to NixOS's architecture.

This issue is not only in NixOS.
I am trying to run my setup in a container, so that I can finally deploy my application outside of my dev machine, but the error persists there as well.
Dockerfile
FROM node:lts-bookworm

ARG SST_VERSION
ENV SST_VERSION=${SST_VERSION:-latest}

RUN npm install --global sst@${SST_VERSION}

RUN sst tunnel install --print-logs

CMD ["sst"]

Build Output
...

STEP 5/6: RUN sst tunnel install --print-logs
time=2024-10-31T09:29:58.588Z level=INFO msg="checking for pulumi" path=/root/.config/sst/bin/pulumi
time=2024-10-31T09:29:58.588Z level=INFO msg="pulumi install"
time=2024-10-31T09:29:58.588Z level=INFO msg="pulumi downloading" url=https://github.com/pulumi/pulumi/releases/download/v3.136.1/pulumi-v3.136.1-linux-x64.tar.gz
time=2024-10-31T09:30:25.277Z level=INFO msg="checking for bun" path=/root/.config/sst/bin/bun
time=2024-10-31T09:30:25.278Z level=INFO msg="bun install"
time=2024-10-31T09:30:25.278Z level=INFO msg="bun downloading" url=https://github.com/oven-sh/bun/releases//download/bun-v1.1.30/bun-linux-x64-baseline.zip
time=2024-10-31T09:30:34.212Z level=INFO msg="creating sudoers file" path=/etc/sudoers.d/sst-
time=2024-10-31T09:30:34.212Z level=INFO msg="sudoers entry" entry=" ALL=(ALL) NOPASSWD:SETENV: /opt/sst/sst1 tunnel start *\n"
time=2024-10-31T09:30:34.212Z level=ERROR msg="exited with error" err="open /etc/sudoers.d/sst-: no such file or directory"
✕  Unexpected error occurred. Please run with --print-logs or check .sst/log/sst.log if available.Error: building at STEP "RUN sst tunnel install --print-logs": while running runtime: exit status 1

Is this fixed?

No, it's not fixed!
i have moved from NixOS to Ubuntu containers in order to avoid this issue, but still with no success.
I have documented my most recent attempt at https://discord.com/channels/983865673656705025/1300501887216390186/1302026195914985522 and I was planning on elaborating more here later on.

Ah yeah
So we never intended to have the tunnel work inside a container or in CI. Is that what you are trying to do?

I first tried to figure out what sst tunnel  does by reading the code,    hoping I could patch my environment to fit sst  needs, but I failed on that. Network setups have never been my strongest skill.
I then tried using distrobox to patch the environment more easily, but that also just made things more complicated.
Finally, I tried setting up the  tunnels inside docker hoping that I would be able to at least understand better what sst tunnels is trying to do and how it changes the environment.
Even if I don't succeed in  properly running the  tunnels from the container, I would already be satisfied if I could get a grasp of how it works, and with that understand what to improve in the host environment.

In short: I am using containers just because they are more easily controlled.
Things like podman diff <layerId> show me what was changed in the system with a given command.
The final goal has never been to run sst from the container

For anyone in NixOS wanting to install the tunnel, you need to add this to your config:
security.sudo.extraRules = [
  {
    users = [ "<your-user>" ];
    commands = [
      { command = "/opt/sst/sst1 tunnel start *"; options = [ "NOPASSWD" "SETENV" ]; }
    ];
  }
];

@jayair The PR #5015 contains the snippet above and should allow us to close this issue.
I still can't run the tunnels properly, but I think there are other bug reports covering that.
This issue should remain only about tunnel install and permission errors running sst tunnel start, which are solved by #5015.


Fix coveralls

Coverage increased (+4.1%) to 97.884% when pulling 0da37559c6ce0d4a38e73ecf127110cf4a980b3b on fix-coveralls into 3e107a0909383266442acce73bccc9b2be288679 on master.


Plugin doesnt skip the cutscenes in msq roulette

this days i been doing msq roulette, but  the cinematics are still playing

this days i been doing msq roulette, but the cinematics are still playing

Late reply, it seems that UI mods will hinder it from working in my experience. :)


Dashboard Template: Search Icon Misalignment on Mobile

Resizing browser to a more mobile layout/size, the Search icon does not position properly.  Pulled it up on Samsung s7 Edge w Android, same result.  See image/screen capture:
https://drive.google.com/open?id=0ByJ_bX8GebiKWE5NUUFSb0J0c3M

Duplicate with #4912

Thanks, @maximiliankukla. Closing in favour of #4912.


Request to join Pattern House!

GitHub username -  sanviii
I would like to join your organization so that I can learn your way of doing stuff and start off with my open source journey!
I am good with HTML , CSS , JS , Bootstrap and Python.

Invite has been sent! Welcome to PatternHouse

@aryashah2k My invite is expired. Could you please share it again?

sent a new one!

thank you!
On Fri, 14 Jan 2022 at 16:41, Arya Shah @.***> wrote:

sent a new one!
—
Reply to this email directly, view it on GitHub
https://github.com/openAOD/Join_PatternHouse/issues/41#issuecomment-1013027164,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVOQHIUOOJ5DQAISZL2YMILUWAAH3ANCNFSM5LEX4Z5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


fix(parquet): Schema Evolution

https://github.com/facebookincubator/velox/pull/10517 broke schema evolution.
Velox crashes with an out of range vector access when the table schema has
fewer columns compared to the Parquet file schema.
This PR fixes this.
Fixes: https://github.com/facebookincubator/velox/pull/11589

CC: @agrawalreetika

@Yuhta can you please take a look at this? Thanks.

thanks @Yuhta !


Support for intl 0.17.0

Describe the bug

To Reproduce
Velovity_x supports 0.16.1 and a lot of other packages depend on the latest intl package which causes a lot of compatibility issues with other packages.

We will update it soon

Fixed in version - ^2.4.0-nullsafety.0


Refactor Angular module structure

This PR includes first refactoring of the Angular module structure.
Modules

[ ] @madwau: File-Upload, Modeling
[ ] @ungaralex: Programming, Code-Editor (Lazy)
[ ] @jpbernius: Text, Course
[ ] @krusche: Quiz

Required changes for all modules:

Adapt module to folder structure
Combine smaller modules into larger ones
Split too large modules into smaller ones
Remove all entryComponents and providers definitions
Reduce the number of exported components in a module
Change the client routes to allow easier navigation and to allow lazy loading

Routes:

Students
/courses (until now overview)
/courses/{courseId}/exercises (until now e.g. overview/1/exercises)
/courses/{courseId}/exercises/{exerciseId} (until now e.g. overview/1/exercises/696)
Participate —> e.g. /courses/{courseId}/${exerciseType}-exercises/{exerciseId}

Instructors / Tutors
Assess —> /course-management/{courseId}/${exerciseType}-exercises/{exerciseId)/…
Manage —> /course-management/{courseId}/${exerciseType}-exercises/{exerciseId)/…

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

I refactored all routes for programming exercises. You can find all management related components under course-management/:courseId/programing-exercises/:exerciseId/.... This also allows us to easily switch to lazy loading since I moved all commonly used components (programming-exercise for the overview, instructions-render, actions) to their own modules.
The code editor is now split between the student and instructor version with both having a common dependency to the ArtemisCodeEditorModule. This results in one more chunk to load since a user cannot just load the whole editor any more, but needs to also fetch the instructor/student specific components. Users don't need to load the common module twice! E.g. if an instructor already opened the student version and the navigates to the course administration and the instructor editor, he only has to fetch the small instructor code-editor components.
Size of the new code-editor chunks (gzipped):

Common editor: 50KB
Instructor: 6KB
Student: 3.5KB

We cannot reallly circumvent this additional chunk since we now have two different routes for instructors and students for the code editor:

Instructor: course-management/:courseId/programming-exercises/:exerciseId/code-editor/:participationId
Student: courses/:courseId/programming-exercises/:exerciseId/code-editor/:participationId


Static code analysis

A type checking system would have prevented  #3858
I am a huge fan of typescript but flowtype from Facebook https://flowtype.org/ is perhaps better fitting the code base.
Best would be a Travis check in the long run.

I agree! see #3744


Integrate HTTPD into the Reference Application

Blocker:  Cognito needs HTTPS endpoint for Management Console

we have certs and domains, this should not be blocked any longer.

"Reference application" is now the Management Console, right @galenatjpl  ?

@rtapella Yes, the "reference application" is now the Management Console.  I'm also tagging @ramesh-maddegoda and @mike-gangl  here on this confirmation comment.

We recently proved that the Management Console was able to come up and work within this structure. Closing this ticket, as it was proven to work.


add htlc solidity contracts

Codecov Report

Merging #144 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #144   +/-   ##
=========================================
  Coverage     33.78%   33.78%
  Complexity      540      540
=========================================
  Files           152      152
  Lines          4748     4748
  Branches        347      347
=========================================
  Hits           1604     1604
  Misses         3024     3024
  Partials        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395c39a...af24668. Read the comment docs.

Codecov Report

Merging #144 into dev will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #144      +/-   ##
============================================
- Coverage     33.78%   33.75%   -0.03%
+ Complexity      540      539       -1
============================================
  Files           152      152
  Lines          4748     4749       +1
  Branches        347      347
============================================
- Hits           1604     1603       -1
- Misses         3024     3025       +1
- Partials        120      121       +1

Impacted Files
Coverage Δ
Complexity Δ

.../wecross/stub/jdchain/JDChainContractResource.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)
:arrow_up:

.../java/com/webank/wecross/peer/PeerSeqCallback.java
63.15% <0.00%> (ø)
3.00% <0.00%> (ø%)
:arrow_up:

...java/com/webank/wecross/peer/PeerInfoCallback.java
63.15% <0.00%> (ø)
3.00% <0.00%> (ø%)
:arrow_up:


Only Default Media Receiver marks when played on Google Nest Hub Max.

What version of Music Assistant has the issue?
2.1.0b14
What version of the Home Assistant Integration have you got installed?
2024.6.2
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Only Default Media Receiver marks when played on Google Nest Hub Max.
How do I set it up to see song information and cover images on my Google Nest Hub Max?
The music provider added YouTube music.
And I added a home assistant to the plug-in provider.
Finally, I added a home assistant media player as a player provider, and I selected Google Nest Hub Max and Google Home Mini from the player entity.
This is the end of my setup, and I ran a playlist on YouTube Music.
The music played normally, but only the Default Media Receiver message appeared for information about the music.
Please review my settings.
How to reproduce
The music provider added YouTube music.
And I added a home assistant to the plug-in provider.
Finally, I added a home assistant media player as a player provider, and I selected Google Nest Hub Max and Google Home Mini from the player entity.
This is the end of my setup, and I ran a playlist on YouTube Music.
The music played normally, but only the Default Media Receiver message appeared for information about the music.
Music Providers
YouTube music
Player Providers

home assistant to the plug-in provider
Google Nest Hub Max and Google Home Mini (Not Chromecast)

Full log output
2024-07-10 00:36:38.414 INFO (MainThread) [music_assistant] Starting Music Assistant Server (d42e88873e1d4d63b310ce4357efa7dc) version 2.1.0b14 - HA add-on: True - Safe mode: False
2024-07-10 00:36:38.423 INFO (MainThread) [music_assistant.cache] Initializing cache controller...
2024-07-10 00:36:39.089 INFO (MainThread) [music_assistant.music] Using a sync interval of 180 minutes.
2024-07-10 00:36:39.351 INFO (MainThread) [music_assistant.streams] Detected ffmpeg version 6.0.1 with libsoxr support
2024-07-10 00:36:39.351 INFO (MainThread) [music_assistant.streams] Starting server on  <IP_ADDRESS>:8097 - base url: http://<IP_ADDRESS>:8097
2024-07-10 00:36:39.357 INFO (MainThread) [music_assistant.webserver] Starting server on  <IP_ADDRESS>:8095 - base url: http://<IP_ADDRESS>:8095
2024-07-10 00:36:39.445 INFO (MainThread) [music_assistant] Loaded metadata provider MusicBrainz Metadata provider
2024-07-10 00:36:39.446 INFO (MainThread) [music_assistant] Loaded metadata provider fanart.tv Metadata provider
2024-07-10 00:36:39.446 INFO (MainThread) [music_assistant] Loaded music provider Music Assistant
2024-07-10 00:36:39.446 INFO (MainThread) [music_assistant] Loaded metadata provider TheAudioDB Metadata provider
2024-07-10 00:36:39.571 INFO (MainThread) [music_assistant.music] Sync task for Music Assistant completed
2024-07-10 00:36:47.540 WARNING (MainThread) [music_assistant.metadata] ko is not a valid language
2024-07-10 00:37:17.214 INFO (MainThread) [music_assistant] Loaded music provider YouTube Music
2024-07-10 00:37:19.014 INFO (MainThread) [music_assistant.music] Sync task for YouTube Music completed
2024-07-10 00:37:31.533 INFO (MainThread) [music_assistant] Loaded plugin provider Home Assistant
2024-07-10 00:37:39.612 INFO (MainThread) [music_assistant] Loaded player provider Home Assistant MediaPlayers
2024-07-10 00:37:39.707 INFO (MainThread) [music_assistant.players] Player registered: media_player.googlehome1267/Mini
2024-07-10 00:37:39.709 INFO (MainThread) [music_assistant.players] Player registered: media_player.maegseu/Max
2024-07-10 00:38:02.994 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:38:38.231 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:42:01.573 INFO (MainThread) [music_assistant] Loaded player provider Chromecast
2024-07-10 00:42:03.870 INFO (MainThread) [music_assistant.players] Player registered: f9567dce-1751-e1cf-37f5-b01fd51bbaca/Mini
2024-07-10 00:42:04.045 INFO (MainThread) [music_assistant.players] Player registered: 41de3193-9f22-e62c-f603-358b1e2d772b/Max
2024-07-10 00:42:41.960 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:43:20.119 INFO (MainThread) [music_assistant.players] Player removed: Mini
2024-07-10 00:43:20.121 INFO (MainThread) [music_assistant.players] Player removed: Max
2024-07-10 00:43:39.659 INFO (MainThread) [music_assistant] Loaded player provider Home Assistant MediaPlayers
2024-07-10 00:43:39.724 INFO (MainThread) [music_assistant.players] Player registered: media_player.ytube_music_player/ytube_music_player
2024-07-10 00:43:58.724 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play: Resume queue requested but queue ytube_music_player is empty
2024-07-10 00:44:45.955 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:45:27.886 INFO (MainThread) [music_assistant] Loaded player provider Home Assistant MediaPlayers
2024-07-10 00:45:27.954 INFO (MainThread) [music_assistant.players] Player removed: ytube_music_player
2024-07-10 00:46:51.850 WARNING (MainThread) [music_assistant.metadata] ko is not a valid language
2024-07-10 00:47:18.089 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:47:22.152 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 00:57:31.419 WARNING (MainThread) [music_assistant.metadata] ko_kr is not a valid language
2024-07-10 01:00:29.319 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:01:37.437 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:02:40.031 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:10:19.789 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:13:48.347 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:16:39.676 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:22:02.921 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/favorites/remove_item: invalid literal for int() with base 10: 'MPREb_iG5q5DIdhdA'
2024-07-10 01:22:04.247 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/favorites/add_item: artist not found in library: 2
2024-07-10 01:22:30.441 ERROR (MainThread) [music_assistant.webserver] Error handling message: player_queues/play_media: No playable items found
2024-07-10 01:22:44.645 ERROR (MainThread) [music_assistant.webserver] Error handling message: music/refresh_item: artist not found in library: 2
2024-07-10 01:23:14.623 WARNING (MainThread) [music_assistant.metadata] ko_kr is not a valid language
2024-07-10 01:27:45.861 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:28:34.129 WARNING (MainThread) [music_assistant.metadata] ko_kr is not a valid language
2024-07-10 01:29:51.516 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:32:34.704 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 634, in _metadata_scanner
await self._update_album_metadata(album)
File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/metadata.py", line 465, in _update_album_metadata
await self.mass.music.artists.update_item_in_library(album.item_id, album)
File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/base.py", line 150, in update_item_in_library
await self._update_library_item(item_id, update, overwrite=overwrite)
File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/artists.py", line 339, in _update_library_item
cur_item = await self.get_library_item(db_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/music_assistant/server/controllers/media/base.py", line 358, in get_library_item
raise MediaNotFoundError(msg)
music_assistant.common.models.errors.MediaNotFoundError: artist not found in library: 2
2024-07-10 01:38:11.874 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:40:00.296 WARNING (MainThread) [music_assistant.metadata] ko_kr is not a valid language
2024-07-10 01:42:42.873 WARNING (MainThread) [music_assistant.metadata] ko_kr is not a valid language
2024-07-10 01:44:26.668 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:47:40.380 INFO (MainThread) [music_assistant.streams] Start Queue Flow stream for Queue Max - crossfade: False
2024-07-10 01:53:30.236 WARNING (MainThread) [music_assistant.metadata] ko is not a valid language
Additional information
No response
What version of Home Assistant Core are your running
2024.7.1
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

You missed an important part in our documentation that says that you should use the builtin player providers to get all functionality. Use Home Assistant players only as last resort if there is no native provider available.
So add the Chromecast player provider to MA and use those players to get all functionality

You missed an important part in our documentation that says that you should use the builtin player providers to get all functionality. Use Home Assistant players only as last resort if there is no native provider available.
So add the Chromecast player provider to MA and use those players to get all functionality

Thank you.
I missed an important phrase.
I set it the way you said it, and I saw the title and cover image!


Changed method names with reserved words. Change concatenation by formatted strings (sprintf)

Changed method names with reserved words.
Change concatenation by formatted strings (sprintf)

Er, this looks like mostly reformatting, and not consistent with our style guide,
What needed changing or is being improved??

not to be too picky, but we expect commits to be GPG-signed :)


Can't withdraw all funds from LMSR liquidity pool

Is the error message incorrect? What is the expected behaviour?

Withdrawal should succeed and the pool be destroyed.


docker image

Hello everyone,
this is merely a suggestion to offer mojito as a docker image on docker hub to make testing/evaluation easier.

Yes, it is a good suggestion!
I'm going to work on a docker image soon to deploy Mojito for translationcommons.org. I'll share it once finished.
Else did you get a chance to install using brew?

Thanks!
I'm on Ubuntu/Windows, so I haven't been able to try that yet. I think I will either wait for the docker image, or try to run it on docker myself.

Here is my (dirty) take on a Dockerfile:
`
FROM ubuntu:16.04
RUN apt-get update && apt-get install -y software-properties-common
ENV LANG en_US.UTF-8
RUN locale-gen $LANG
RUN add-apt-repository ppa:openjdk-r/ppa
RUN apt-get update && apt-get install -y openjdk-8-jdk
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/
RUN export JAVA_HOME
RUN apt-get install -y build-essential curl git python-setuptools ruby git
RUN git clone https://github.com/Linuxbrew/brew.git ~/.linuxbrew
RUN ~/.linuxbrew/bin/brew tap box/mojito
RUN ~/.linuxbrew/bin/brew install mojito-cli
RUN ~/.linuxbrew/bin/brew install mojito-webapp
RUN ln -s ~/.linuxbrew/Cellar/mojito-webapp/0.56/bin/mojito-webapp /usr/bin
EXPOSE 8080
CMD ["mojito-webapp"]
`
I'm sure there are better ways to do it, but it works for now.
use it with:
docker build -t mojito . docker run -d -p 8080:8080 mojito

Thanks @ppa-covis  for sharing!  It is a good starting point, I'll look at adding Mysql. I'm going to work on that probably end of next week.


Add unsafe sub- type definitions

TypeScript Version: 2.8.3
Search Terms:

explicit cast
require cast
unsafe type

Code
function queryOutsideWorld(queryName) : unsafe {
   // ... some fetch() or RPC call
  // ... some JSON.parse()
  // ... extract body with random interface
  return someRandomData
}

// fail
let data = queryOutsideWorld('user-profile')

// ok
let data: UserProfile = queryOutsideWorld('user-profile')

Related Issues:
#10715
#22716
#9999
I've read similar issues and the closest one is the unknown type #10715. However I believe there is room for a less complex solution.
Currently if I fetch something from the outside world I must do some kind of runtime validation and cast to a known type / interface. If I start looking for common functionality I will be forced to create functions and even libraries that must return any but I would like a way return a value and force the programmer to do an explicit cast.
In my example I've used a new type keyword as a basic example, but I would rather like to have something where I can define unsafe subtypes such has:
// global.d.ts
type Unsafe extends any as unsafe
type RiskyAny extends any;

if (process.env.NODE_ENV === 'production') {
  type RiskyAny extends any as unsafe;
}

This would enable a second case. I want to prototype code/ideas in a non very strict environment, and only increase the typing-strictness later, if/when the library "matures". There is code that is OK to have type any in development, but in production (or at a more mature version) it will have to go away before other any types

looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/10715


Absolute number of failures instead of rate?

failureRateThreshold is a percentage. I'd like the circuit-breaker to be triggered immediately after the first failure... Could it be possible to have an absolute value for the failures, rater than a rate?

(version 0.2 had the very useful maxFailures)

Hi, the new Version does not support it anymore, because it the previous solution not good when the backend system is just unreliable for a short time and not down. You can either use the old version or you could set ringBufferSizeInHalfOpenState(1) and ringBufferSizeInClosedState(1) .
The previous maxFailures=3 could be ringBufferSizeInHalfOpenState(3) and ringBufferSizeInClosedState(3) and failureRateThreshold(100) .

OK, thanks for the explanation!

You are welcome

I'm sorry for reopening, but I think there is something wrong...
In order to get same behaviour as in previous maxFailures(N), I have to do .ringBufferSizeInHalfOpenState(1).ringBufferSizeInClosedState(N), and not include failureRateThreshold(100).
This passes:
	@Test
	public void testCircuitBreakerBehaviour() throws InterruptedException {
		CircuitBreakerRegistry registry = CircuitBreakerRegistry.ofDefaults();
		int times = 3;
		int waitSeconds = 2;
		CircuitBreakerConfig config = CircuitBreakerConfig.custom().ringBufferSizeInHalfOpenState(1)
				.ringBufferSizeInClosedState(times).waitDurationInOpenState(Duration.ofMillis(WAIT_TIME)).build();
		CircuitBreaker circuitBreaker = registry.circuitBreaker("something", config);
		for (int i = 0; i < times; i++) {
			assertTrue("Circuit-breaker call should be permitted", circuitBreaker.isCallPermitted());
			circuitBreaker.recordFailure(new RuntimeException("Fail! " + i));
		}
		assertFalse("Circuit-breaker call should not be permitted", circuitBreaker.isCallPermitted());
		Thread.sleep(TimeUnit.SECONDS.toMillis(waitSeconds));
		assertTrue("Circuit-breaker call should be permitted", circuitBreaker.isCallPermitted());
	}

whereas this (following your instructions above) doesn't:
	@Test
	public void testCircuitBreakerBehaviour() throws InterruptedException {
		CircuitBreakerRegistry registry = CircuitBreakerRegistry.ofDefaults();
		int times = 3;
		int waitSeconds = 2;
		CircuitBreakerConfig config = CircuitBreakerConfig.custom().ringBufferSizeInHalfOpenState(times)
				.failureRateThreshold(100).ringBufferSizeInClosedState(times)
				.waitDurationInOpenState(Duration.ofMillis(WAIT_TIME)).build();
		CircuitBreaker circuitBreaker = registry.circuitBreaker("something", config);
		for (int i = 0; i < times; i++) {
			assertTrue("Circuit-breaker call should be permitted", circuitBreaker.isCallPermitted());
			circuitBreaker.recordFailure(new RuntimeException("Fail! " + i));
		}
		assertFalse("Circuit-breaker call should not be permitted", circuitBreaker.isCallPermitted());
		Thread.sleep(TimeUnit.SECONDS.toMillis(waitSeconds));
		assertTrue("Circuit-breaker call should be permitted", circuitBreaker.isCallPermitted());
	}

Thx. You are right. Right now the CB changes to OPEN state when the failure rate is above (>) the threshold, but it should be above or equal (>=).

ah! so with 99 it will work as I expect :+1:

But I will change that behavior in the next version.
Your behavior is more intuitive.

I published a 0.5.0-SNAPSHOT if you want to test the version.

0.5.0 has been released


Error: 'NoneType' is not iterable on python3.6 -m pipenv --python python3.6

Hi, I am running pipenv inside my docker (official 3.6.2 debian stretch from python ).
I get the following error when running python3.6 -m pipenv --python:
  File "/root/.local/lib/python3.6/site-packages/pipenv/cli.py", line 517, in ensure_project
    if project.required_python_version:
  File "/root/.local/lib/python3.6/site-packages/pipenv/project.py", line 54, in required_python_version
    required = self.parsed_pipfile.get('requires', {}).get('python_full_version')
  File "/root/.local/lib/python3.6/site-packages/pipenv/project.py", line 188, in parsed_pipfile
    for package in data.get(section):
TypeError: 'NoneType' object is not iterable

This does not happen locally on my mac.
If I add an empty [dev-dependencies] to my Pipfile, I get no error.
Any idea why this happens?

thanks of the bug report!


Migrate AppLifecycleState.hidden

See https://docs.flutter.dev/release/breaking-changes/add-applifecyclestate-hidden

@softkot Thank You!


distinctOn and Embedded

`distinctOn' doesn't generate proper SQL when used with embedded classes.
E. g. distinctOn(_.emb.id) generates DISTINCT ON (a.id) instead of DISTINCT ON (a.embid) so the query fails at runtime with column does not exist.
As a workaround I just use .distinctOn(_ => infix"embid")

@DGolubets I think this is the same as https://github.com/zio/zio-quill/issues/2556 which was fixed in https://github.com/zio/zio-quill/pull/2583 and released with 4.4.0. Could you please double-check if it's still happening?

Closing as no answer. @DGolubets Could you tell us if v4.4.0 fixed this issue, please?


How to change the single track volume like setVolume methods of wavesurfer.js

I tried to change the volume property of the audios  and tracks of the Multitrack object，but the sound doesn't change.
I need to customize to set the volume, how can I do this.

You can set the volume in your track settings, e.g.:
const tracks = [
   {
      id: 1,
      draggable: false,
      startPosition: 14, // start time relative to the entire multitrack
      url: '/examples/audio/librivox.mp3',
      fadeInEnd: 5,
      fadeOutStart: 250,
      volume: 1,
  }
]

It's currently not possible to dynamically set the volume because each wavesurfer has an Envelope plugin enabled. This plugin essentially hijacks the volume control and doesn't allow changing it via code. I've filed an issue here to fix this: https://github.com/katspaugh/wavesurfer.js/issues/2995

@v1ada you can now call setVolume like this:
const volume = 0.5
multitrack.wavesurfers.forEach((wavesurfer) => wavesurfer.setVolume(volume))

Cheers!

@v1ada你现在可以setVolume这样调用：
const volume = 0.5
multitrack.wavesurfers.forEach((wavesurfer) => wavesurfer.setVolume(volume))

干杯!

Thanks for the answer to my question!
In my use, I found that the updatePosition method always adjusts the volume to 1.
https://github.com/katspaugh/wavesurfer-multitrack/blob/0269575286ff2c8d0eee47fb5c97767d2b458db4/src/multitrack.ts#L331C100-L331C100
I had to change it to const newVolume = newTime >= (track.startCue || 0) && newTime < (track.endCue || Infinity) ? audio.volume : 0

@v1ada你现在可以setVolume这样调用：
const volume = 0.5
multitrack.wavesurfers.forEach((wavesurfer) => wavesurfer.setVolume(volume))

干杯!

Thanks for the answer to my question!
In my use, I found that the updatePosition method always adjusts the volume to 1.
https://github.com/katspaugh/wavesurfer-multitrack/blob/0269575286ff2c8d0eee47fb5c97767d2b458db4/src/multitrack.ts#L331C7-L331C105
I had to change it to const newVolume = newTime >= (track.startCue || 0) && newTime < (track.endCue || Infinity) ? audio.volume : 0

@v1ada你现在可以setVolume这样调用：
const volume = 0.5
multitrack.wavesurfers.forEach((wavesurfer) => wavesurfer.setVolume(volume))

干杯！

@v1ada你现在可以setVolume这样调用：
const volume = 0.5
multitrack.wavesurfers.forEach((wavesurfer) => wavesurfer.setVolume(volume))

干杯!

Thanks for the answer to my question, this can work!
In my use, I found that the updatePosition method always adjusts the volume to 1.
https://github.com/katspaugh/wavesurfer-multitrack/blob/0269575286ff2c8d0eee47fb5c97767d2b458db4/src/multitrack.ts#L331C7-L331C105
I had to change it to
const newVolume = newTime >= (track.startCue || 0) && newTime < (track.endCue || Infinity) ? audio.volume : 0

That's a good fix, please do make a PR.

That's a good fix, please do make a PR.
I make a new PR, please check it out.


Page would benefit from a git repo

This page would benefit from having a git repo with the exact contents of the function project folder that is expected to deploy. There aren't a whole lot of good tutorials on V2 Python Durable Functions. We've had a few try these instructions and they aren't working exactly as written.
Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 53a281e3-ce27-a305-40bb-1299e854547b
Version Independent ID: 7f54fe69-fd8c-8f5e-fa7d-2fa5681c290b
Content: Create your first durable function in Azure using Python
Content Source: articles/azure-functions/durable/quickstart-python-vscode.md
Service: azure-functions
Sub-service: durable
GitHub Login: @davidmrdavid
Microsoft Alias: glenga

@jsperson
Thanks for your feedback! We will investigate and update as appropriate.

Not sure if this will make it back to the appropriate folks, but I’d like to temper my comments. I spent a long time figuring out durable functions today and I was really tired by the end. Please excuse my tone.
The document is technically correct based on my end of day results. I did not think that it was at the time as I didn’t think my function was working. This is based on the results of the deployment as well as the output. I think that a bit more about how to exercise the function - as a separate document section would be more helpful than any of my issue comments.
Good work you all and thank you!
On Jan 12, 2024 at 22:33 -0600, RamanathanChinnappan @.***>, wrote:

@jsperson
Thanks for your feedback! We will investigate and update as appropriate.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @jsperson - thanks very much for your feedback and follow up. We acknowledge that docs around Python v2 need more work. One thing that I wanted to clarify so we can improve the docs is what do you mean by how to exercise the function?
Also, if your time allows, I'd love to chat with you - I'm a PM working on DF. I think learning about your experience with DF would be very helpful for us when figuring out how to improve the current Python experience. You can grab a meeting with us here. Thanks!


Added implementation for Tuple with up to 3 items

As far as I could tell Tuple is not implemented (I get Not Implemented errors when I use it). This isn't really a complete pull request.  I added the implementation for Tuple but I'm not sure if I did it the way you guys would like me to do it.  Could you just look over this and let me know if I'm on the right track and if I am I'll finish the implementation for up to 8 or 9 items.  Thanks

This seems right to me, can you add one or two tests for it? They don't need to be complicated.

I have implemented the Tuple class which can now create any tuple of any size if the developer follows the Tuple class creation rules for c#.  I also added in the Tuple.Create method which means the Tuple class should now be completely usable if I didn't miss anything.


Bot is attempting to use a server other than the configured one

Describe the bug
Bot is not using the server from config.json - It's trying to use another server that the bot is in.
To Reproduce
Steps to reproduce the behavior:

This is my part of my config:

"discord": {
    "token": "Redacted",
    "guild": "557863115283234837",
    "createChannels": true
  },
  "channels": {
    "command": "557865770365747200",
    "error": "557865749008482316"
  },
  "checkUpdates": true

It tries to join another Guild (Server) -<PHONE_NUMBER>21285633

You can see this in the error log below:
 SUCCESS  2019-03-20 06:20:56  › Worker process 5112 started.
  START   2019-03-20 06:20:56  › Gzipping old logs...
 SUCCESS  2019-03-20 06:20:56  › All old logs gzipped, starting Miscord
  INFO    2019-03-20 06:20:56 getConfig › Using config at /root/.config/Miscord/config.json
  START   2019-03-20 06:20:56  › Launching Miscord v4.7.1
  START   2019-03-20 06:20:56 login › Logging in...
  INFO    2019-03-20 06:20:56 login › logLevel 'info'
  INFO    2019-03-20 06:20:56 updateNotifier › Checking for updates...
  START   2019-03-20 06:20:56 discord › login › Logging in to Discord...
 SUCCESS  2019-03-20 06:20:57 discord › login › Logged in to Discord
  ERROR   2019-03-20 06:20:57 errorHandler ›  { DiscordAPIError: Missing Permissions
    at item.request.gen.end (/usr/lib/node_modules/miscord/node_modules/discord.js/src/client/rest/RequestHandlers/Sequential.js:79:15)
    at then (/usr/lib/node_modules/miscord/node_modules/snekfetch/src/index.js:215:21)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7) name: 'DiscordAPIError', message: 'Missing Permissions', path: '/api/v7/guilds/517962440521285633/webhooks', code: 50013, method: 'GET' }

  WARN    2019-03-20 06:20:57 errorHandler › Logs from NPM are unnecessary and don't give much information.
  Miscord logs folder:
  /root/.config/Miscord/logs
  ERROR   2019-03-20 06:20:57  › Worker process 5112 died (1, null).
  FATAL   2019-03-20 06:20:57  › Process crashed less than 2 seconds since the last launch, exiting.

Specifically, '/api/v7/guilds/517962440521285633/webhooks'.
Specifications:

OS:
Ubuntu

Version:
4.7.1

Node.js version:
v8.11.3

I've had the same issue previously after I migrated the bots hosting server. No amounts of kicking/readding the bot or adding admin rights fixed it. Managed to temporarily resolve the issue by creating a new discord bot.

Fixed in https://github.com/miscord/miscord/commit/11eda8890fb565566a5064cdbed9cf9da3b399b9, I'll close the issue once it's released


[Feature]: Option to hide UI elements (Tab bar and Side bar)

Feature description
Right now, I can't hide the tab bar and sidebar in the terminal. I like a clean look, and these take up alot of space. I can open new tabs with Cmd:t and switch between them with Cmd:[ and Cmd:], so I don’t need to see the tab bar all the time. Currently, there are no key bindings for opening new blocks or widgets, but that’s a separate issue. Right now, they’re just taking up space on my screen.

Implementation Suggestion
It would be helpful to have options to hide the tab bar and sidebar separately. I’d like to use key bindings to toggle them on and off (I don’t have specific key bindings in mind, so any options would work for me.)
Anything else?
No response

trying to figure out at what level of configuration to apply this.  a global option (in settings.json), at a workspace level, or at a tab level (or all of the above)?

@sawka all of the above 😄


ARROW-7136: [Rust] Added caching to the docker image

This allow us to build the crate without having to re-build nor download all its dependencies at the expense of a larger (build) image.
Here I am extending the ideas of a non-workspace rust project to a workspace rust project. See here for a long discussion on the issue. Essentially, it is not easy to do this atm with cargo.
IMO I think that this is worth it, but I need your help to judge it; it incurs some maintenance (duplication of configurations).

Some benchmarks:

Current: 19m with image caching; 21m without image caching
This PR: ~8m with image caching; 13m without image caching

(~8 assumes 1m download time of the image vs the current 40s, due to bigger image size)
2m:20s are used to build the current layers in both cases
In this PR, 2m40s is used to compile rust dependencies (within docker build). The remaining difference is explained by the second commit on this PR, which was causing a complete cache miss of all built dependencies by one of the executions.
Small drill-down:

build project (all workspaces + small dependencies): 3m
build of cargo check --all-targets --no-default-features: 40s
build of cargo test --features simd: 1m:30s
build of examples: ~40s

Overall, I think that there is not so much more to save; it is mostly about building our own code.

Thanks @jorgecarleitao, it looks like a nice improvement. Currently I'm working on the next release candidate, but I'll take a look at it afterwards.

Just started to experiment with this change locally. If you don't mind I'm going to push a couple of little changes to better align with the docker-compose setup.

@jorgecarleitao could you please enable "Allow edits from maintainers" checkbox? I'm rejected to push to your branch.

@jorgecarleitao could you please enable "Allow edits from maintainers" checkbox? I'm rejected to push to your branch.

ups, sorry about that. Fixed. Thanks a lot for helping out on this PR; much appreciated.

Executed a couple of runs on a beefy machine:

Before my patch: 3m56.235s
Tried without a mounted build volume: 3m42.993s
First run with a mounted build volume : 4m14.134s
First run with a mounted build volume: 1m23.795s

LGTM your changes, @kszucs .

Executed a couple of runs on a beefy machine:
* Before my patch: 3m56.235s

* Tried without a mounted build volume: 3m42.993s

* First run with a mounted build volume : 4m14.134s

* First run with a mounted build volume: 1m23.795s

did you run it before this whole PR, just for the sake of sanity checking this whole PR.

I did, on master the build takes 4m31.312s. The machine has 40 cores and gigabit network, so depending on the dependency-tree's width and the bandwidth the overall improvement might be better on a smaller machine.
It may worth to remove the mounted volume to have better cold build times on the CI. I'm going to add three CI configurations to check the improvements on GHA directly.

Master - 19m 32s (including docker pull)
No Cache - 13m 28s
Download Cache - 13m 43s
Download and Build Cache - 12m 20s
Download and Build Cache on a Volume - 9m 8s
See build logs here.
The environment variables may not work as expected, but still an improvement over the current master (even if we add the 5 minute build time which we won't need to pay after the docker image gets updated).
I'm going to finalize the PR.

@kszucs , thank you very much for all the improvements and integration that you've made here. Really useful and appreciated!


Improve Login and Sign Up Page UI

Dear Authors, The login and sign up page UI is not matching up with the whole website.
Kindly, Assign this issue to me under GSSoC'24

Assigned!

Any Updates @nishantharkut

Dear sir, I would make the changes by tomorrow morning, the GSSoC'24 contributions will start from today 8 pm.
Thank You sir for the patience and sorry sir for the delay.
Will give PR's by tomorrow

Okay!


init() got an unexpected keyword argument 'chunker' while using customized chunker

I also tried the demo in readme, same err appears. Could you please help me?

Can you try with the first level of the dict removed, so just
pdf_add_config = {
    "chunk_size": 200,
    ...

Linking #251

Can you try with the first level of the dict removed, so just
pdf_add_config = {
    "chunk_size": 200,
    ...

Linking #251

I tried but it has the following error ...

I think you need to say AddConfig(chunker=**pdf_add_config). I made a PR #270 that should simplify this issue.

chunker=**pdf_add_config

it says it is not the correct syntax, and if i remove the **, then it would say unexpected key argument "chunker" again...

I think you need to say AddConfig(chunker=**pdf_add_config). I made a PR #270 that should simplify this issue.

me and my colleague found a temporary solution by having code as below,
from typing import Callable, Optional
from embedchain.config.BaseConfig import BaseConfig
class ChunkerConfig(BaseConfig):
"""
Config for the chunker used in add method
"""
def __init__(
    self,
    chunk_size: Optional[int] = 4000,
    chunk_overlap: Optional[int] = 200,
    length_function: Optional[Callable[[str], int]] = len,
):
    self.chunk_size = chunk_size
    self.chunk_overlap = chunk_overlap
    self.length_function = length_function

from embedchain.config.AddConfig import *
chunker = {
"chunk_size": 200,
"chunk_overlap": 20,
"length_function": len
}
cc = ChunkerConfig(**chunker)
ac = AddConfig()
dir(AddConfig)
ac.chunker = cc
print(ac.chunker.chunk_size)
pdf_url = 'https://www.rogers.com/cms/pdf/en/Consumer_SUG_V20.pdf' #online resources
chat_bot.add('pdf_file', pdf_url, config=ac)
This seems to work but it generate the same number of chunks (total 55 for this file) no matter which chunk_size we config.
We indeed remember to clear the db by delete everything under it every time before we change the chunk_size paramater. But it still output the same number of chunks....


webkitAudioContext does not have close method in Safari 7.0.5

The fix to issue #2237 calls AudioContext.close in SoundManager.destroy. However, this method does not exist in older versions of Safari (have not tried the newest version).
A possible workaround would be to guard the call:
if (this.context.close) { 	this.context.close(); }

Thanks. Fixed in dev.


[Breaking] Change Prevent to PureC and convert 'select' to mapStateToProps

Change Prevent to be React's PureComponent instead of using shallowEqual
Simplify interface to resemble redux mapStateToProps instead of string array, enabling more complex extraction from the state (rather than only 1 level under state, which limits the "prevention").

Really interesting we could try this way


Upgrade to v3.41.0 of the Google Beta Terraform Provider

Fixes: #452

@leezen / @justinvp / @mikhailshilkov so I have been through all the fields that are breaking and they are actual breakages. These are things that changes in the upstream API specs that the module gets generated from (i.e. MagicModules)
I think there are going to be more of these in the coming weeks as they are all being attributes to "refactoring"
I am not sure what is the best way to proceed with this and would like some input - this should be a breaking change and thus a major version bump...

@stack72 A couple thoughts:

Give the number and impact of the breaking changes, I do think this will need to be a major version bump.
Are there any significant functionality improvements in this release? If not, would it make sense to hold a week or two longer to capture more of the breaking changes you expect to come?


Plinko README.md

Created a readme doc for CC 62 Plinko. This has a table of links to other repos of this same project.

Thank you!


Cubes Without Borders

Is your request related to a problem? Please describe if so.
Currently Additive is using Borderless Mining for its borderless fullscreen feature, however it's not easy to toggle as it requires the user to navigate to the mod menu and then search for borderless fullscreen, while you can toggle borderless fullscreen in the video settings with Cubes Without Borders.
Describe the mod you'd like to add, remove, or change
Replace Borderless Mining with Cubes Without Borders.
List alternative mods or solutions you've considered
None
Additional context
An additional context would be that Fabulously Optimized removed Borderless Mining in favor of Cubes Without Borders and that is how I've gotten to know this mod in the first place.

Doesn’t borderless mining have a config setting to do this? I think I have it off by default

after a quick look in the FO thread i think it’s reasonable to add this and replace borderless mining 👍


Quick access: editor symbols

Refs: https://github.com/microsoft/vscode/issues/69955

[ ] anyOS: @jrieken
[x] anyOS @roblourens

Complexity: 2

Quick open is now using the quick input widget that leverages our new tree widget. All quick open providers have been rewritten from scratch.
All of the existing commands for driving quick open have been preserved. Everything should work as before with some additional features as noted in the test plan.
Note: configure "workbench.quickOpen.closeOnFocusLost": false to make testing easier by keeping quick open opened even if you navigate somewhere else.

verify you can see, filter and navigate to symbols of the active editor when typing @ in quick open
verify you see a symbol icon the reflects its kind
verify that grouping by kind still works when using @: as prefix
verify the symbol gets revealed in the background while selecting items
verify the decorations are getting cleared when you cancel or navigate to a symbol
verify the symbols update when you switch editors while quick open is visible
verify you get a good meaningful default entry when no editor is opened or the active editor does not provide any symbols
verify that you can narrow down symbols by container if you type the container name after a space (e.g. type foo bar to find all symbols that have foo in their label and bar in their description
verify this works on the right hand side of a diff editor when invoked there

verify that you can narrow down symbols by container if you type the container name after a space (e.g. type foo bar to find all symbols that have foo in their label and bar in their description

What is a "container" here? I can't search for methods inside a certain class name, for example. I never get results if I have a space in the query.

@roblourens the container if present will be shown as "description" label in smaller letters next to the label


Support for video compression defence in PyTorch-specific attacks

Description
This pull request adds support for VideoCompression preprocessing in PyTorch-specific attacks.
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Codecov Report

Merging #1201 (3325f25) into dev_1.7.1 (cb98391) will decrease coverage by 43.34%.
The diff coverage is 35.00%.

@@              Coverage Diff               @@
##           dev_1.7.1    #1201       +/-   ##
==============================================
- Coverage      63.65%   20.30%   -43.35%
==============================================
  Files            229      230        +1
  Lines          21108    21136       +28
  Branches        3947     3950        +3
==============================================
- Hits           13436     4292     -9144
- Misses          6076    16579    +10503
+ Partials        1596      265     -1331

Impacted Files
Coverage Δ

...defences/preprocessor/video_compression_pytorch.py
33.33% <33.33%> (ø)

art/defences/preprocessor/__init__.py
100.00% <100.00%> (ø)

art/wrappers/wrapper.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/wrappers/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/poisoning/perturbations/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...essing/expectation_over_transformation/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/wrappers/query_efficient_bb.py
0.00% <0.00%> (-95.84%)
:arrow_down:

...formation/natural_corruptions/zoom_blur/pytorch.py
0.00% <0.00%> (-88.58%)
:arrow_down:

...mation/natural_corruptions/zoom_blur/tensorflow.py
0.00% <0.00%> (-87.88%)
:arrow_down:

...rt/defences/detector/poison/clustering_analyzer.py
8.22% <0.00%> (-86.71%)
:arrow_down:

... and 153 more


Fix RoPE data type issue for gpt_neox and stablelm (#177)

Internal implementation for RoPE changed so that if one of parameters data type is FP32, the op will be performed in FP32 data type. To force the op to bf16, need to convert all parameters data type to bf16 before RoPE is called.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mandy-li I believe the RoPE implementation changed because of https://habana.atlassian.net/servicedesk/customer/portal/1/HS-1574.
Can you confirm that you reach a perplexity of about 8 or 9 with this PR when you run
GAUDI2_CI=1 RUN_SLOW=1 pytest tests/test_examples.py -v -s -k "neox"

with 1.16?

@regisss , good point. i didn't know this jira when i worked on the type casting. The reason why we have this PR is because our QA reported perf regression for StableLM and gpt-neox inference. So how about we only explicitly cast sin/cos to bf16 in the inference and leave training to use default behavior (i.e RoPE in fp32)?

If that produces good results at inference then yes let's do that

created https://github.com/huggingface/optimum-habana/pull/999, close this one


unhandle error

Describe the bug
Unhandled Thrown Error!
Cannot read properties of undefined (reading 'mode')
TypeError: Cannot read properties of undefined (reading 'mode')
at J (http://my.site:8000/assets/Auth-6c3f0140.js:1:391)
at n7 (http://my.site:8000/assets/index-7a6dd5c0.js:77:19518)
at S8 (http://my.site:8000/assets/index-7a6dd5c0.js:79:3139)
at JC (http://my.site:8000/assets/index-7a6dd5c0.js:79:44490)
at KC (http://my.site:8000/assets/index-7a6dd5c0.js:79:39724)
at $z (http://my.site:8000/assets/index-7a6dd5c0.js:79:39652)
at X4 (http://my.site:8000/assets/index-7a6dd5c0.js:79:39506)
at $8 (http://my.site:8000/assets/index-7a6dd5c0.js:79:35874)
at UC (http://my.site:8000/assets/index-7a6dd5c0.js:79:34825)
at x (http://my.site:8000/assets/index-7a6dd5c0.js:64:1559)
💿 Hey developer 👋
You can provide a way better UX than this when your app throws errors by providing your own errorElement props on
Steps to reproduce
open mysite
Screenshots or additional context
No response

i run a old version


fix typo in real_amplitude.py

Summary
Correct small typo in real_amplitude.py file.
Fixes #10340
Details and comments
Erased repeated "of"

Thanks to you for the quick review and response on the issue! A pleasure helping out (even on little things)
I have also opened an issue on the Qiskit textbook repo regarding Bersntein-Vazirani if you can check it out :)


Update README.md

Am I doing this RGHT??

This isn't a typo. That's what's in the code, since each hand has only four knuckles to show when forming a fist, the "knuckle tats" for the right first could only be "RGHT"