6.0 GA checklist

[ ] Go over all the breaking changes again to make absolutely sure we have not missed anything - @codebrain (see https://github.com/elastic/elasticsearch-net/issues/2923)

[ ] Go over all the current [Obsolete()] and make sure they are still relevant. @codebrain
[ ] Apply new [Obsolete()] where they make sense. @codebrain

[ ] Go over all the TODO's in the code base and make sure we tackled everything we can.
[ ] Internalize our JSON.NET dependency (https://github.com/elastic/elasticsearch-net/tree/feature/dependencies-scrub) - @Mpdreamz

[ ] pending results of previous branch make sure the new NEST.Json.Net package is part of the build.
[ ] reserve the NEST prefix on Nuget

[ ] Generate a binary breaking changes document like we did for 2.x and 5.x.
[ ] Go over issues that would affect 6.0.0 e.g. #2840 @russcam
[x] Regenerate documentation - @russcam

missing features

[x] Index sorting (PR is open: https://github.com/elastic/elasticsearch-net/pull/2910)

We are looking to migrate our cluster to 6.0.
Will the latest stable NEST work against 6.0? Or would it be safer to wait for NEST 6? Are there any rough timelines?

Hey @andrewrimmer, the latest stable NEST 5.x on nuget is not tested or supported with 6.0. The 6.0.0-alpha1 package was tested against 6.0.0-alpha1 Elasticsearch, however, there have been quite a few changes in Elasticsearch since that release.
We're working on the 6.0.0 release of the client as the highest priority right now, and expect to GA release hopefully this week or next, so long as we don't find any showstoppers! In the meantime and if you're eager to get going with NEST 6.x, we have the canary releases on MyGet, which will contain the latest from master (they start from 6.1.0-<prerelease> as canary always assumes it's the next minor).

Thanks @russcam.
I have given 6.1 a try but when I do a basic index operation I get "ProtocolViolationException: When performing a write operation with AllowWriteStreamBuffering set to false, you must either set ContentLength to a non-negative number or set SendChunked to true.". Should I be reporting this as an issue or is this just part and parcel of using the pre-release canary release?

Please report as a bug @kbandrew, relates to #2891. Does this happen on all requests?

@russcam this happens on all requests and is using a brand new installation of Elasticsearch 6 and a hello world index & search example. Swapping out NEST 6.1 with the latest 5.5 stable release makes it work without any code changes.
I will create an issue for it.

Thank you @kbandrew; I'll fix it today 👍

Smart. I will keep an eye out for the next canary release and will re-test.

Any news on this?
What is the current expected GA/RC release date? We would like to plan the migration to ES 6.

Hey @neotek, we are looking to publish a 6.0.0-beta1 to nuget shortly. This beta is very near to what we anticipate the GA release will be, but we wuld like to publish it to nuget in order to garner wider feedback. We do also publish CI canary releases to MyGet if you're keen to get your hands on the bleeding edge.

Hey @russcam, thanks. We then try as soon as the beta1 is released.

Added release notes for 6.0

How to fix this please
On 06 Feb 2018 10:25, "Martijn Laarman"<EMAIL_ADDRESS>wrote:

Closed #2903 https://github.com/elastic/elasticsearch-net/issues/2903.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/elastic/elasticsearch-net/issues/2903#event-1459577057,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AigUNnIjsEnE5yGTGo6UZyPdhF19bhlBks5tSAyTgaJpZM4QgKrX
.

@ghavaun  it's not clear what you're asking to fix. If there's an issue, please open a new issue and describe what it is.


BUG: extra elements in top of booklist for swapping and double occurrence of email in swapping of booklist webpage

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
There are extra elements in top of booklist in booklist for swapping section and there is double occurrence of email in swapping of booklist webpage.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 i have fixed the issue and created the pull request for the same please assign this issue to me and merge my pull request under gssoc label


Only index ingress objects matching ingress.class

Indexes are used to maintain relationshipd between object (the graph of
objects).  Only index ingress objects containing matching ingress.class
to avoid attempting to maning ingress objects that don't match class.
closes #124

Codecov Report

Merging #125 into master will increase coverage by 0.08%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   57.25%   57.34%   +0.08%
==========================================
  Files          15       15
  Lines        1006     1008       +2
==========================================
+ Hits          576      578       +2
  Misses        411      411
  Partials       19       19

Impacted Files
Coverage Δ

internal/argotunnel/informer.go
56.41% <84%> (+1.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da48c85...cbf474f. Read the comment docs.


Android: events are no longer received after reload from bundler

First, thank you for your work on providing this package, it is much appreciated!
Issue
On Android, after a reload from the bundler, the keyboard events are no longer received. Steps to reproduce:

Build and start the example Android app from this repo.
Go to "3. Events".
Activate the text input. A notification is displayed that the keyboard is shown. Hide the keyboard, and a corresponding hide notification is shown.
Reload the app from the bundler, e.g. by pressing Cmd/Ctrl+M or via the dev menu.
Now repeat from step 2 above, but note that no notifications are displayed, indicating that no events are received.

Expected behaviour is that events are still received after a reload.
Platform information

Desktop OS: macOS 13.1
Device/OS: Android emulator/API level 31, Huawei P10/Android 7.0, and others.
RN version: 0.70.5
RN architecture: default from example app
JS engine: default from example app
Library version: 1.4.2

I have not built the example app for iOS, but the events are working properly in the app where the problem was discovered. This seems to be Android specific.

Thanks @rikardg
I will have a look on the problem!

I'm able to reproduce a problem. Looking for a solution 👀

@rikardg would you mind to check if https://github.com/kirillzyusko/react-native-keyboard-controller/pull/114 fixes the issue?
I've tested locally and everything seems to be working fine after these changes, but just want to ask double confirmation 🙂

HI!
The unmodified example from the repository works now. 👍
However, if I move the text input to the front page so that there is no screen navigation before it is displayed, it doesn't work for me on API level 28 and 24. It seems like the first show event is not received after a reload. However, the following hide event as well as subsequent show/hide events are all received. I've tested on:

Android 7 (24, physical device): first event not received.
Android 9 (28, physical device and emulator): first event not received.
Android 12 (31, emulator): first event is received.

To reproduce:

Build and run app with the modified App.tsx below.

Reload app.
Focus text input. On Android 7 and 9 (at least), the first show event doesn't give a notification. Check that subsequent events are received (they are for me).

My modified App.tsx:
import 'react-native-gesture-handler';

import * as React from 'react';
import { KeyboardProvider } from 'react-native-keyboard-controller';
import {
  SafeAreaProvider,
  initialWindowMetrics,
} from 'react-native-safe-area-context';
import Events from './screens/Examples/Events';

const spacerStyle = { marginVertical: 50 };

export default function App() {
  return (
    <SafeAreaProvider initialMetrics={initialWindowMetrics} style={spacerStyle}>
      <KeyboardProvider statusBarTranslucent>
        <Events />
      </KeyboardProvider>
    </SafeAreaProvider>
  );
}

@rikardg okay, thanks. I will try to test your example tomorrow 👍
Thanks for great explanation of the issue 😊

Hi @rikardg
I merged one PR and created a new one (https://github.com/kirillzyusko/react-native-keyboard-controller/pull/117), since the issue looks similar from dev perspective, but has absolutely different fixes and I would like to keep them separate just for more transparency
Could you please check if https://github.com/kirillzyusko/react-native-keyboard-controller/pull/117 fixes the problem?
I've rebased this branch on latest main branch, so it has both fixes. Hopefully everything should work fine 😊

Hi,
I've tested on a few different Android versions now (API level 24/physical, 31/33/emulator) with both the modified example from above as well as the app I'm working on. Works perfectly everywhere. So 👍 from me.
Thank you for fixing this so quickly!

@rikardg awesome! Then I will merge PR and will release 1.4.3 in the beginning of next week☺

Closed since https://github.com/kirillzyusko/react-native-keyboard-controller/releases/tag/1.4.3 has been published.


Change dependency output into a list by provider

Right now, the dependencies from all providers are output in the same list or tree.
For instance, if java provider provides dep2 and dep3, while the go provider gives dep1. The current output looks like:
- dep1
- dep2
- dep3

We should separate them by providers like so:
- provider: java
  dependencies:
  - dep2
  - dep3
- provider: golang
  dependencies:
  - dep1

This will also help populate the language field in the UI

We also need to update this to be per file that was gotten, I feel like this is going to be a bigger change so removing good first issue for now. @pranavgaikwad we can add it back if you feel strongly.


[improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder

Fixes #22041
Motivation
See #22041 . Currently, when using the asynchronous interfaces of the Pulsar Admin client, there's no backpressure by the client itself and the client will keep on opening new connections to the broker to fulfill the in-progress requests.
Eventually, the broker will hit the maxHttpServerConnections limit, which is 2048.
It's better to limit the number of connections from a single client. This PR sets the limit to 16 connections per host.
The limit isn't called connectionsPerBroker since admin operations usually target a cluster address.
Modification

add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder
also modify the default connectionMaxIdleSeconds from 60 seconds to 25 seconds

some firewalls/NATs have a timeout of 30 seconds and that's why 25 seconds is a better default - common firewall/NAT idle timeout is 60 seconds and since the check isn't absolute, a better default is 25 seconds to ensure that connections don't die because of firewall/NAT timeouts

bump jersey.version to 2.42 since there's a change included that enables cancelling operations

cancellation can be used in later PRs to cancel queued operations, that will be useful for some use cases such as namespace deletion.

add Spotify completable-futures dependency

includes ConcurrencyReducer class that is needed to implement the maxConnectionPerHost so that pending operations are queued outside of AsyncHttpClient

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

the setMaxConnectionsPerHost in async http client doesn't seem to behave as expected. Will check the errors
  Caused by: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. Failed reason: Too many connections: 16
  	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:332)
  	at java.base/java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:674)
  	at java.base/java.util.concurrent.CompletableFuture.orApplyStage(CompletableFuture.java:1601)
  	at java.base/java.util.concurrent.CompletableFuture.applyToEither(CompletableFuture.java:2261)
  	at org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector.retryOrTimeOut(AsyncHttpConnector.java:275)
  	at org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector.apply(AsyncHttpConnector.java:234)

There's a problem with backpressure handling with async requests in the Pulsar code base.
Since this PR limits the Pulsar Admin client to 16 connections per host, it now shows up problems.
The namespace unloading is a good example:
https://github.com/apache/pulsar/blob/d7d54522933b63f6a74ec7139c6dedebe8ad9149/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L829-L841
All bundles in the namespace are unloaded at once without limiting concurrency.
There was a dev mailing list discussion about backpressure and Pulsar Admin API implementation in https://lists.apache.org/thread/03w6x9zsgx11mqcp5m4k4n27cyqmp271 . However we didn't come across resolving the problem.
The solution for the namespace unloading issue is to have a way to limit the outstanding CompletableFutures that are in progress and use that as a way to "backpressure" the sending of new requests. The current solution of sending out all requests and then waiting for the results is a problematic solution since it doesn't use any sort of feedback from the system to adjust the speed. In other words, there's currently no proper backpressure solution for async Pulsar Admin calls within Pulsar broker.
I'll experiment with some ways to add backpressure to cases where a large amount of async calls are triggered and then results are waited.

Another location without proper backpressure is namespace deletion:
https://github.com/apache/pulsar/blob/d7d54522933b63f6a74ec7139c6dedebe8ad9149/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L282-L293

example of creating partitions:
https://github.com/apache/pulsar/blob/50121e7f7be541f45bb6dc976f51e30658b1cb8d/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L162-L171
This would need backpressure too. Let's say if you create a 100 partition topic, the broker might open 100 HTTP connections to create the topic partitions concurrently. This is problematic when the brokers are under heavy load.

Looks like https://github.com/spotify/completable-futures/blob/master/src/main/java/com/spotify/futures/ConcurrencyReducer.java could be a useful solution to leverage.

Noticed that there's a solution to run 1-by-1 using https://github.com/apache/pulsar/blob/ed599673c7e60ab5bb02e1fb0615a7ff8e5d6430/pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java#L179-L210 . However, I think that ConcurrencyReducer would be a better solution for most use cases.

Another challenge is to cancel work that is queued in the system, but not waited by any clients.
Newer Jersey clients have support for this. I noticed commit https://github.com/eclipse-ee4j/jersey/commit/96028068b6379ad923cf26ab018f372f3ea040f6 in Jersey.
When the system is overloaded, request processing might be very slow so that clients get timeouts and retry requests.
This will add more work to the system unless there's a solution that cancels the timed out tasks. That's why addressing this is also important part of the solution.

Codecov Report
Attention: Patch coverage is 65.41353% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (bbc6224) to head (7b2b93a).
Report is 501 commits behind head on master.

Files
Patch %
Lines

...client/admin/internal/http/AsyncHttpConnector.java
64.28%
17 Missing and 13 partials :warning:

...he/pulsar/client/admin/internal/FunctionsImpl.java
26.66%
11 Missing :warning:

.../client/admin/internal/PulsarAdminBuilderImpl.java
60.00%
3 Missing and 1 partial :warning:

...che/pulsar/client/admin/internal/PackagesImpl.java
92.30%
0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22541      +/-   ##
============================================
+ Coverage     73.57%   74.57%   +0.99%
- Complexity    32624    34106    +1482
============================================
  Files          1877     1919      +42
  Lines        139502   144228    +4726
  Branches      15299    15774     +475
============================================
+ Hits         102638   107552    +4914
+ Misses        28908    28442     -466
- Partials       7956     8234     +278

Flag
Coverage Δ

inttests
27.86% <40.60%> (+3.28%)
:arrow_up:

systests
24.76% <42.10%> (+0.43%)
:arrow_up:

unittests
73.92% <65.41%> (+1.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../pulsar/client/admin/internal/PulsarAdminImpl.java
78.09% <100.00%> (+0.42%)
:arrow_up:

...apache/pulsar/client/admin/internal/SinksImpl.java
61.00% <100.00%> (ø)

...ache/pulsar/client/admin/internal/SourcesImpl.java
54.10% <100.00%> (ø)

.../org/apache/pulsar/client/impl/ConnectionPool.java
75.48% <ø> (+0.96%)
:arrow_up:

...lsar/client/impl/conf/ClientConfigurationData.java
96.72% <100.00%> (+0.02%)
:arrow_up:

...che/pulsar/client/admin/internal/PackagesImpl.java
79.06% <92.30%> (-0.72%)
:arrow_down:

.../client/admin/internal/PulsarAdminBuilderImpl.java
75.78% <60.00%> (-9.35%)
:arrow_down:

...he/pulsar/client/admin/internal/FunctionsImpl.java
44.92% <26.66%> (+0.74%)
:arrow_up:

...client/admin/internal/http/AsyncHttpConnector.java
78.36% <64.28%> (-8.06%)
:arrow_down:

... and 489 files with indirect coverage changes


Migrate Playwright fixture to Vite by default

This changes the default compiler option for createFixture to be "vite" and provides a basic Vite config by default. To support this, we've deprecated the config option on createFixture since it's coupled to the old remix.config.js format, which also means we've added a dedicated singleFetch flag.

Closing in favour of https://github.com/remix-run/react-router/pull/11395.


Mail recepients with German umlaut are not accepted

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/7654
User: @renecatharsis
Created On: 2015-12-21T12:08:38Z
Updated At: 2016-02-13T15:34:02Z
Body
Hi,
since ZF v2.4.x, I cannot send any mails to recepients containing German umlauts in their mail address.
For exmaple<EMAIL_ADDRESS>Encoding is set to UTF-8 on Zend\Mail\Message object.
The following expection is thrown:
#0 foobar\vendor\zendframework\zend-mail\src\Header\AbstractAddressList.php(114<EMAIL_ADDRESS>#1 foobar\vendor\zendframework\zend-mail\src\Header\AbstractAddressList.php(158): Zend\Mail\Header\AbstractAddressList->getFieldValue(true)
#2 foobar\vendor\zendframework\zend-mail\src\Headers.php(422): Zend\Mail\Header\AbstractAddressList->toString()
#3 foobar\vendor\zendframework\zend-mail\src\Transport\Smtp.php(332): Zend\Mail\Headers->toString()
#4 foobar\vendor\zendframework\zend-mail\src\Transport\Smtp.php(238): Zend\Mail\Transport\Smtp->prepareHeaders(Object(Zend\Mail\Message))
#5 foobar\vendor\Solar\library\Solar\Mail\Mail.php(144): Zend\Mail\Transport\Smtp->send(Object(Zend\Mail\Message))
#6 foobar\vendor\Solar\library\Solar\Client\AbstractClient.php(249): Solar\Mail\Mail->sendSmtp('processrevenuec...', Array, true, '')
#7 foobar\modules\eonde\Processrevenuecheck.php(73<EMAIL_ADDRESS>'', Array)
#8 foobar\vendor\Solar\library\Solar\Bootstrap\Bootstrap.php(248): modules\eonde\Processrevenuecheck->run()
#9 foobar\index.php(80): Solar\Bootstrap\Bootstrap->getResponse()
#10 {main}```

Umlauts work fine with the subject and body.
Also, the value passes the \Zend\Validate\EmailAddress validator.
It might be related to this issue although I cannot gain any workaround from it:
https://github.com/zendframework/zf2/issues/7501

Update:
Seems like RFC6531 was implemented in zend-validate but not yet zend-mail.

---

That's because this is not possible without support for SMTPUTF8 from RFC 6581. UTF-8 in headers and body are handled using 8BITMIME, but that has no bearing on the SMTP layer.


require an update of japanese trained data

I tried to run the OCR on an image with ¥ symbols and the engine was totally unable to match any of them. It usually translated them into "\ く".
The ¥ were "" for a UNC path (because on Japanese Windows, all the \ are replaced by ¥)
Also, all the number (except 0) were translated into their circled version.
For example:
1 -> ①
2 -> ②
3 -> ③
...
Japanese uses circled number some times (often compare to the rest of the world) but not that often. Number should still be translated into their normal form.
I think that these issues come from the training data that did not include ¥ and has as input number that were circled in the expected result.
I am quite a noob in ML and I do not know if I can and how to extract source data from traineddata file.

You can try the Japanese.traineddata from the best or fast repo.

a

You can try the Japanese.traineddata from the best or fast repo.

Do you mean jpn.traineddata? isn't it?

https://github.com/tesseract-ocr/tessdata_fast/tree/master/script
https://github.com/tesseract-ocr/tessdata_best/tree/master/script


Tests script are getting included in production build

The issue is exactly the same as https://github.com/facebook/create-react-app/issues/4857 for<EMAIL_ADDRESS>

Please fill in the issue template and provide a reproducible example.

Describe the bug
I've my put the test files (or tests folders) next to the component code they are testing, so that relative imports appear shorter as per the recommendation
After i run react-scripts build, i see that all the tests folders and their stubs are included in the build file called [number].[hash].chunk.js
I don't want to send all my test files to the browser as part of the chunk.
Did you try recovering your dependencies?
Yes.
Which terms did you search for in User Guide?
--exclude, build --exclude
Environment
Model Name:	MacBook Pro
Model Identifier:	MacBookPro14,3
Processor Name:	Intel Core i7
Processor Speed:	2.8 GHz
Number of Processors:	1
Total Number of Cores:	4
L2 Cache (per Core):	256 KB
L3 Cache:	6 MB
Hyper-Threading Technology:	Enabled
Memory:	16 GB
Steps to reproduce

Use create-react-app to create an application and source code in src dir and add tests under src/ folder as below:

2. Now perform a production build via yarn run build
3. Load your app in the browser and check the bundle.js in chrome debugger. You will find references to all of your tests there as below:

Expected behavior
We should not have __tests__ or tests folder include in the production bundle
Actual behavior
All the tests under __tests__ and tests are also getting included in production bundle.js

Closing this as It's working as expected.
After the depth investigation, i realized that all my stubs files were bundled. I had the stub file with the name stub.json under the __tests__ folder,  that's the reason they got bundled with the chunk.js. i had to rename that to stub.spec.js to ignore being bundled.


chore: update manage.py as per django 3

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[ ] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Update manage.py file as per django 3.
See thread here for context.
How did you test this code?
Ran python manage.py migrate to make sure it still behaves as we expect.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bda59f5) 95.91% compared to head (8ccd26f) 18.18%.

Files
Patch %
Lines

api/manage.py
0.00%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3403       +/-   ##
===========================================
- Coverage   95.91%   18.18%   -77.73%
===========================================
  Files        1079      998       -81
  Lines       33476    29221     -4255
===========================================
- Hits        32109     5315    -26794
- Misses       1367    23906    +22539

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Introduce CompositeUserRepository #196

Introduce CompositeUserRepository #196

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

merged
https://github.com/Haulmont/jmix-core/commit/9627bdec9c115966a64f163cef02bf64d13ca40e
https://github.com/Haulmont/jmix-core/commit/4e74c686d499f122268a8321cc841b371f27efb9


Error during load:  null value in column "STMNT_STATUS" violates not-null constraint

django.db.utils.IntegrityError: null value in column "STMNT_STATUS" violates not-null constraint
DETAIL:  Failing row contains (726563, 1018846, 868856, null, F497, 0, 2002-07-12, 10006, null, 2001, DBARRICK, 11003, 11003, null, null, null, null).

Hehe. Many more to come!


acr build

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az acr build
Errors:
The command failed with an unexpected error. Here is the traceback:
'NoneType' object is not callable
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 657, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 691, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/acr/build.py", line 109, in acr_build
    variant=platform_variant
TypeError: 'NoneType' object is not callable

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az acr build --registry {} --image {} {}

Expected Behavior
Environment Summary
Linux-5.4.0-1055-azure-x86_64-with-debian-10.2 (Cloud Shell)
Python 3.6.10
Installer: DEB

azure-cli 2.26.0 *

Extensions:
ai-examples 0.2.5
ssh 0.1.5

Additional Context

route to service team

Thanks for reporting it and sorry for the inconvenience.
2.26.1 has been released to address the issue.
https://docs.microsoft.com/en-us/cli/azure/release-notes-azure-cli?tabs=azure-cli
Please upgrade to the latest version of Azure CLI to resolve this issue.

Since you are already using cloud shell, the az command in cloud shell has been upgraded to 2.27.0 so that there is no action from your side.


Take precedence of NODE_PATH when resolving node_modules directories

Summary

This aligns Jest with the behaviour of Node where it takes precedence of NODE_PATH over resolving modules relative to node_modules.
Test plan
yolo

Codecov Report

Merging #4453 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4453   +/-   ##
=======================================
  Coverage   56.74%   56.74%
=======================================
  Files         189      189
  Lines        6485     6485
  Branches        3        3
=======================================
  Hits         3680     3680
  Misses       2804     2804
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-resolve/src/node_modules_paths.js
5.88% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b484db...1814193. Read the comment docs.

@kittens - Can you provide a bit more context on this change?
We bisected jest module resolution errors to this commit, specifically for our team members whose NODE_PATH variable contains one or more paths that don't exist on their system. Before this change, the nonexistent paths would be further down the resolution paths array and the error wouldn't occur. In a related note, jest should probably skip resolving modules in nonexistent directories instead of fail with the following error:
Test suite failed to run

Cannot find module 'lodash/isPlainObject' from 'createStore.js'

  at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:192:17)
  at Object.<anonymous> (node_modules/redux/lib/createStore.js:7:22)


Improving BinarySearchTree's Add method

Removed unnecessary elses. Created extra constant for Node key for better understanding.

Nice


parserOptions#project for TS parser breaks ESLint stage

Describe the bug
parserOptions#project breaks extension functionality for TS projects. For all the steps below output for Prettier ESLint is completely silent.
To Reproduce

Have parserOptions: { project: './tsconfig.json' } in eslintrc.json in TypeScript project
Restart VSCode

Try to format any .ts file via extension - same result as I would've run just Prettier (I tested). Though ESLint extension does show errors.
Try to format any .js file via extension - result as expected
Try to format same file prettier-eslint-cli via command, e.g. yarn run prettier-eslint src/some_file.ts --write - result as expected

Remove parserOptions: { project: './tsconfig.json' } from eslintrc.json (and rules required to it)
Restart VSCode

Try to format any .ts file via extension - result as expected (except for removed rules of course)

Example

This is working example repo: https://github.com/Hetch3t/eslint-config-serenity
This is not: https://github.com/Hetch3t/eslint-config-serenity/tree/failing-project-ts
This is PR: https://github.com/Hetch3t/eslint-config-serenity/pull/4/files

Versions (please complete the following information):

VS Code Prettier ESLint extension: 5.0.4
Visual Studio Code: 1.73.1
Node: 18.13.0
Package Manager: yarn 1.22.19
prettier: 2.8.3
eslint: 8.32.0
prettier-eslint: 15.0.1
@typescript-eslint/eslint-plugin: 5.48.2
@typescript-eslint/parser: 5.48.2

System Specifications (please complete the following information):

OS: MacOS Ventura 13.1
Processor: 2,6 GHz 6-Core Intel Core i7
RAM Size: 16 GB

@Hetch3t Try the js extension again and make sure your project matches the values found in this example .eslintrc.js file
https://github.com/idahogurl/vs-code-prettier-eslint/blob/c387cdaaa1a82f47c83edfb09c03ae10372bb7f8/examples/typescript/.eslintrc.js#L5-L8

@idahogurl :
Setting the tsconfigRootDir fixed it! Closing.


Time is not accessed by pylance

so i have this code for my game but it says "time not accessed by pylance" when i hover over the time

That means Pylance thinks you're not using it in that file. From the screenshot, that looks to be true to me, but it could be used in code off the screen.
What's the entire contents of the file?

Thank you, do you want me to send u the entire code
On Mon, Apr 3, 2023 at 9:45 PM Rich Chiodo @.***> wrote:

That means Pylance thinks you're not using it in that file. From the
screenshot, that looks to be true to me, but it could be used in code off
the screen.
What's the entire contents of the file?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/pylance-release/issues/4180#issuecomment-1494612540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYOSSL7QNFOSMBMCJKS3Z5DW7LZS3ANCNFSM6AAAAAAWPMEVUY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes, pylance is correct. You are not referencing the time module anywhere. You can remove it from the file and the game will still run.
Perhaps you thought this was a reference to time?
clock = pygame.time.Clock

That's actually a reference to the pygame submodule, called pygame.time. If that's confusing, this might help: https://docs.python.org/3/tutorial/modules.html#packages

Awesome, thanks!
On Wed, Apr 5, 2023 at 9:41 PM Rich Chiodo @.***> wrote:

Closed #4180 https://github.com/microsoft/pylance-release/issues/4180
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/pylance-release/issues/4180#event-8937023333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYOSSLZ7QZL6XHQMVQC6GYTW7WKUNANCNFSM6AAAAAAWPMEVUY
.
You are receiving this because you authored the thread.Message ID:
@.***>

but its staying only for a mili second
not any longer it comes and vinishes
On Thu, Apr 6, 2023 at 1:01 PM Terugu Varshith @.***>
wrote:

Awesome, thanks!
On Wed, Apr 5, 2023 at 9:41 PM Rich Chiodo @.***>
wrote:

Closed #4180 https://github.com/microsoft/pylance-release/issues/4180
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/pylance-release/issues/4180#event-8937023333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYOSSLZ7QZL6XHQMVQC6GYTW7WKUNANCNFSM6AAAAAAWPMEVUY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Conversion error from CMS347v4

Information

OS & version:  Windows Server running latest version of QPP-Converter-tool v14.5.0
Java version: (Run $ java -version.)
Docker version if using: (Run $ docker -v.)

Expected behavior
Testing qpp convert on 2021 MIPS file including eCQM CMS 347v4 and expecting valid conversion
Actual behavior
QPP convert on file including 347v4 is generating error on NUM and DENEX with message
"CT - The electronic measure id: CMS347v4 requires a NUMER with the correct UUID of 17D080CB-6211-4E3E-AD9A-DFA623DD6F42. Here is a link to the IG containing all the valid measure ids: https://ecqi.healthit.gov/sites/default/files/2021-CMS-QRDA-III-Eligible-Clinicians-and-EP-IG-v1.3.pdf#page=40",
The file to be converted includes the appropriate populations and UUID according to eCQM specs and the UUID table included in the EP IG, Section 6
Steps to reproduce
Convert MIPS.xml file attached to case
Other details
error.json included from conversion
CMS347v4-QPP-Convert-Issue.zip
Thank you

@johnmahoneyASC just a follow up that this issue has been fixed. Feel free to open an issue if any problems still occur.


Error joining room: You are not invited to this room

Sometimes the bot does not join a room following an invite. It seems to be a timing problem depending on server/federation delays and/or delays caused by other bots in the room.
We have 2 federating homeservers. One is used by people and the other one is used for bots (incl. matrix-reminder-bot). When the bot is invited while there are other bots in the room already, there is some chance that the bot does not join, leaving the invite hanging. The log shows that the bot tries to join 6 times (and then gives up?):
2020-11-16 19:02:20,341 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 0): You are not invited to this room.
2020-11-16 19:02:20,361 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 1): You are not invited to this room.
2020-11-16 19:02:20,379 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 2): You are not invited to this room.
2020-11-16 19:02:20,399 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 0): You are not invited to this room.
2020-11-16 19:02:20,439 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 1): You are not invited to this room.
2020-11-16 19:02:20,456 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 2): You are not invited to this room.

During debugging, I noticed that increasing the log level from INFO to DEBUG helped (probably decreasing the rate at which the bot attempts to join). If no other bots are in the room, matrix-reminder-bot usually joins on the first attempt. Other bots (maubot) join more reliable but after a noticeable delay.
Version: 0.2.0

mautrix-python seems to use more attempts with await asyncio.sleep(wait, loop=self.loop) and increasing wait after each attempt.

If the homeserver has rate limits for room joins, the bot seems to hit these limits under the conditions described in this issue.
Example using Synapse default config for rate limiting (configured on the homeserver of the bot):
#rc_joins:
#  local:
#    per_second: 0.1
#    burst_count: 3

produces the following errors (for one invite):
2020-11-16 19:58:04,291 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 0): You are not invited to this room.
2020-11-16 19:58:04,319 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 1): You are not invited to this room.
2020-11-16 19:58:04,343 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 2): You are not invited to this room.
2020-11-16 19:58:04,391 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 0): Too Many Requests
2020-11-16 19:58:04,423 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 1): Too Many Requests
2020-11-16 19:58:04,450 | matrix_reminder_bot.callbacks [ERROR] Error joining room !qPbnVtRXCcsEeDsiJJ:phys.ethz.ch (attempt 2): Too Many Requests

Switching to a simple exponential backoff model would likely be much smarter than the immediate retries we have today. Thank you for the detailed issue!


dyndns result matching

TL;DR
It would be helpful if DDNS on verbose would somehow accurately print why the result matching failed.
Detailed description
I debugged today a case where the DDNS Result Match didn't work. So I enabled verbose login and I think the logging is not enough:
here is the error message in question:
https://github.com/opnsense/plugins/blob/c6fbdd45fc4f1c2f5da804d735e1855bc6afdd27/dns/dyndns/src/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc#L1117
This produces error messages like this in the log:
opnsense: /services_dyndns_edit.php: Dynamic DNS: (Error) Result did not match.

It would be helpful to add maybe a log entry what was expected and what it actually was:
So I added something like this:
$status = "Dynamic DNS: (Error) Result did not match. ({$this->_dnsResultMatch} != {$data})";

which produces that something like this:
opnsense: /services_dyndns_edit.php: Dynamic DNS: (Error) Result did not match. (good XXX.248.XX.XX != good XXX.248.XX.XX)

This could be enough but in my case there was a extra space between good and the IP so I only saw that when I started to print the strings as array with print_r
opnsense: /services_dyndns_edit.php: arr m: Array ( [0] => g [1] => o [2] => o [3] => d [4] => [5] => [6] => X [7] => X [8] => X [9] => . [10] => 2 [11] => 4 [12] => 8 [13] => . [14] => X [15] => X [16] => . [17] => X [18] => X )

Contributor missing, sorry.


Add QA, NER, Targeted sentiment and Generation tasks, Llama and Alpaca formats and instructions and whitespace augmentor

New augmentor: augmentors.augment_whitespace_prefix_and_suffix_task_input
New format: formats.alpaca_instruct
New instruction: instructions.models.alpaca, instructions.models.japanese_llama
New tasks: tasks.generation, tasks.ner.single_entity_type, tasks.ner.all_entity_types, tasks.qa.contextual.abstractive, tasks.targeted_sentiment_extraction.single_sentiment_class, tasks.targeted_sentiment_extraction.all_sentiment_classes
Renamed tasks: tasks.qa.contextual -> tasks.qa.contextual.extractive
Update metric for task tasks.qa.open

See the little change I suggested. Do you think the existing templates should be adjusted to the new naming convention in a separate PR?

added your change.
Do you mean existing templates? Or the new templates in this PR?


Dev#1.1 - fixes

The first patch of this series parses the output of app_info_print (which is line-based, similar in structure to json, and easily parsed by bash) and extracts the buildid of the public branch.
I then use pidof instead of ps/grep to match on executable name
Many distributions don't have lsof installed by default, so I have replaced that with netstat.
I have added server output logging.  Unfortunately this won't show if the server aborted or segfaulted.
Instead of grabbing the PID of the process using ps and grep and killing the resulting PID, this uses killall to kill the process by executable path.
I found a typo I made in the path modification for the init scripts, so I have fixed that.
The install script now also modifies the new config file to match the requested install user.

Sorry, looks like I need to rebase this.

yup I have implemented something already

@klightspeed I have rebased the 1.2 inside 1.1 (they was just minor edits) be sure to get the latest commits


Crashing during the editor

Description
What steps will reproduce the problem?

Type into the editor window
That's it!

I was just editing code!
Traceback
  File "/home/alex/code/development_tools/anaconda3/envs/keras_tf2/lib/python3.7/site-packages/spyder/plugins/completion/fallback/actor.py", line 155, in handle_msg
    msg['current_word'])
  File "/home/alex/code/development_tools/anaconda3/envs/keras_tf2/lib/python3.7/site-packages/spyder/plugins/completion/fallback/actor.py", line 62, in tokenize
    valid = is_prefix_valid(text, offset, language)
  File "/home/alex/code/development_tools/anaconda3/envs/keras_tf2/lib/python3.7/site-packages/spyder/plugins/completion/fallback/utils.py", line 125, in is_prefix_valid
    current_pos_text = text[offset - utf16_diff - 1]
IndexError: string index out of range

Versions

Spyder version: 4.1.2
Python version: 3.7.7
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Linux 5.3.0-46-generic

Dependencies

# Mandatory:
atomicwrites >=1.2.0           :  1.3.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.3.0 (OK)
diff_match_patch >=20181111    :  20181111 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.13.0 (OK)
jedi =0.15.2                   :  0.15.2 (OK)
keyring                        :  None (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  0.9.2 (OK)
parso =0.5.2                   :  0.5.2 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.0 (OK)
pygments >=2.0                 :  2.6.1 (OK)
pylint >=0.25                  :  2.4.4 (OK)
pyls >=0.31.9;<0.32.0          :  0.31.9 (OK)
qdarkstyle >=2.8               :  2.8 (OK)
qtawesome >=0.5.7              :  0.7.0 (OK)
qtconsole >=4.6.0              :  4.7.2 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
rtree >=0.8.3                  :  0.9.3 (OK)
sphinx >=0.6.6                 :  2.4.4 (OK)
spyder_kernels >=1.9.0;<1.10.0 :  1.9.0 (OK)
watchdog                       :  None (OK)
xdg >=0.26                     :  0.26 (OK)
zmq >=17                       :  18.1.1 (OK)

# Optional:
cython >=0.21                  :  None (OK)
matplotlib >=2.0.0             :  3.1.3 (OK)
numpy >=1.7                    :  1.18.1 (OK)
pandas >=0.13.1                :  1.0.3 (OK)
scipy >=0.17.0                 :  1.4.1 (OK)
sympy >=0.7.3                  :  None (OK)

Duplicate of #12266

We've been unable to reproduce this problem and no one has been able to give us a reproducible example (and no, simply writing in the editor doesn't generate it).

@ccordoba12 Hi - I know the bug report was rubbish!
I have no idea what has caused the issue - but it has happened a couple of times to me. Closing Spyder down and reopening seems to make it go away. It has happened across multiple files, and I haven't seen a trend to the issue.
If I can replicate the problem, then I'll post more information.
Regards,
Alex


Please confirm license

Thanks for the library, looks great!  I might be able to help by adding more useful RF keywords via pull requests.
One issue that's blocking us using this library is that the licensing may be too prohibitive.
LICENSE file in the code reports:
GNU Affero General Public License v3.0
On PyPi it is listed as:
MIT License (MIT)
Please confirm which license model you are using.
Thanks

Thankyou! I had no idea, I will change it immediately. Ive been in between different projects and this might explain the lack of visibility. Ill be changing it shortly.

Confirm BSD License. will change in Pypi shortly

License has now been updated to MIT which matches PyPi.  I will close this issue now, thanks.


cocoapods: 1.7.4 -> 1.7.5

Motivation for this change
https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.5
This update is necessary for using CocoaPods with Xcode 11 beta 4.
Also update cocoapods-beta to match.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Just a simple gem update.

Thanks!


range requests (resume) only work if request.Filename is explicitly set

I'm using grab for the first time, and I've written a function that takes a directory and a list of URLs, and uses grab to download the specified URLs to the directory, in parallel. Unless I'm doing something wrong (quite possible) range request headers don't seem to be added to my requests.
If I interrupt a download, and then start it again, the existing files do not resume downloading where they left off, regardless of how I set request.NoResume.
With request.NoResume = false, the download is transferred again from the beginning, but the destination file is not truncated. Its size does not change until the downloaded data exceeds the size of the existing file. But all of the file data is downloaded from the server from byte 0, regardless of the size of the existing destination file. I know that it is downloading from 0, because I see the incoming traffic in iftop, and because of what I see in the http headers (see below).
With request.NoResume = true, the behavior is the same, except that the destination file is truncated as soon as the file download begins.
I fired up Wireshark to investigate the requests going over the wire. In response to grab's initial HEAD request for the file, nginx correctly responds with Accept-Ranges: bytes, but the following GET request from grab does not contain a Range header of any kind.
HEAD /images/xxxxx.box HTTP/1.1
Host: image-build-201.xxxxx.org
User-Agent: pogos

HTTP/1.1 200 OK
Server: nginx/1.12.2
Date: Wed, 16 May 2018 21:10:46 GMT
Content-Type: application/octet-stream
Content-Length:<PHONE_NUMBER>
Last-Modified: Wed, 16 May 2018 18:07:18 GMT
Connection: keep-alive
ETag: "5afc7356-611c53b8"
Accept-Ranges: bytes

GET /images/xxxxx.box HTTP/1.1
Host: image-build-201.xxxxx.org
User-Agent: pogos
Accept-Encoding: gzip

I have only tested this using the batch request mode, so I don't know if this also affects requests made synchronously.
I am using grab v2.0.0 with this code. If I'm "doing it wrong," please let me know.

This is a bug. If resume is not supported, the destination file should be truncated. In any case, this should work without you having to set filename. I'll look into this, thank you!


Create Prime.cpp

Pull Request
Prime Number Code
This is the code which is use to find out the prime numbers from 1 to given input limit.
The Approach is easily understandable  from the code itself.
There is no specific dependency needed as such  for the code any standard compiler can run this code easily.
Put check marks:
Have you made changes in README file ?
NO

[Y] Added problem & solution under correct topic.
[N] Specified Space & Time complexity.
[Y] Specified difficulty level, tag & Note(if any).

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[N] Test A
[N] Test B

Make sure all below guidelines are followed else PR will get Reject:

[Y ] My code follows the style guidelines of this project
[Y] I have performed a self-review of my own code
[N] I have commented my code so that it is easy to understand
[N] I have made corresponding changes to the documentation
[Y] My changes generate no new warnings
[Y] Any dependent changes have been merged and published in downstream modules

@divshacker is this a Leetcode problem ?

No this is not a leet code problem .
I have added a prime number finding program. This is not a leet code program
On Sat 24 Oct, 2020, 10:28 AM Gourav Rusiya<EMAIL_ADDRESS>wrote:

@divshacker https://github.com/divshacker is this a Leetcode problem ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codedecks-in/LeetCode-Solutions/pull/117#issuecomment-715692848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANDYLS6EXD4IB3B44BDMLFDSMJNHPANCNFSM4S4WHPQQ
.

@divshacker Check this repository README
This is all about Leetcode problems. We will not except any such random program.
Rejecting this PR

OK Thank You
On Sat, Oct 24, 2020 at 1:39 PM Gourav Rusiya<EMAIL_ADDRESS>wrote:

Closed #117 https://github.com/codedecks-in/LeetCode-Solutions/pull/117.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codedecks-in/LeetCode-Solutions/pull/117#event-3916510386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANDYLSZ6ZSTAV6KPJXKF4MDSMKDTXANCNFSM4S4WHPQQ
.


Noisy TCP traffic between two pods

Describe the bug
We see a lot of strange TCP behaviors (Out-of-order, Retransmission, Dup ACK) when making an HTTP request between two pods both on the same node.
Expected
A clean TCP dialog without all out-of-order, retransmission, etc...
Actual behavior
We see a lot of strange TCP behaviors (Out-of-order, Retransmission, Dup ACK) when making an HTTP request between two pods both on the same node.
Versions:

Cluster deployed via VMware Tanzu (TKGS): v1.22.9---vmware.1-tkg.1.cc71bc8
Antrea version: localhost:5000/vmware.io/antrea/antrea-photon:v1.2.3_vmware.3
Kubernetes version: Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.9+vmware.1", GitCommit:"21eeb4527eefb360eb251addc358cea6997e8335", GitTreeState:"clean", BuildDate:"2022-05-04T00:13:17Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
Linux kernel version on the Kubernetes Nodes: Linux antrea-k8s-of-workers-xjnv9-67b94b447-czf8b 4.19.225-3.ph3 #1-photon SMP Thu Jan 27 20:45:09 UTC 2022 x86_64 GNU/Linux

Additional context
Our TanzuKubernetesCluster config
apiVersion: run.tanzu.vmware.com/v1alpha2 #TKG API endpoint
kind: TanzuKubernetesCluster #required parameter
metadata:
  name: antrea-k8s-of #cluster name, user-defined
  namespace: supervisor-ns-antrea-k8s-of #supervisor namespace
spec:
  topology:
    controlPlane:
      replicas: 1 #number of control plane nodes
      storageClass: tanzu-qual #storageclass for control plane
      tkr:
        reference:
          name: v1.22.9---vmware.1-tkg.1.cc71bc8
      vmClass: best-effort-small #vmclass for control plane nodes
    nodePools:
    - name: workers
      replicas: 1 #number of worker nodes
      storageClass: tanzu-qual #storageclass for worker nodes
      tkr:
        reference:
          name: v1.22.9---vmware.1-tkg.1.cc71bc8
      vmClass: best-effort-small #vmclass for worker nodes
  settings:
    network:
      cni:
        name: antrea
      pods:
        cidrBlocks: ["<IP_ADDRESS>/18"]
      services:
        cidrBlocks: ["<IP_ADDRESS>/18"]

For our test we are using a cluster with a single controlPlane and a single node. We are launching an HTTP request between two pods on the same node. One pod listens HTTP requests with python embedded server. The other pod calls the first pod with a curl.
The HTTP server is on pod with IP <IP_ADDRESS>. The curl is launched from pod with IP <IP_ADDRESS>. The tcpdump is launched from the node where pods are running.
Python server cmd: python3 -m http.server 9200
Curl cmd: curl http://<IP_ADDRESS>:9200
TCPdump cmd: tcpdump -i any -w dump.cap host <IP_ADDRESS> and port 9200
Screenshot of wireshark:

TCPdump capture file:
dumptanzu.zip

As seen with VMware support, doing the dump specifying the pod interface resolve the problem of duplicate tcp packets.


$(...).datetimepicker is not a function

Hi,
I'm loading in both jQuery and jquery-datetimepicker through npm as such:
// Foundation seems to misbehave if we don't do it this way.
window.$ = window.jQuery = require('jquery');

var datetimepicker = require('jquery-datetimepicker');

Then, in our document.ready():
$('#datetimepicker').datetimepicker({
    format:'MM-DD-YYYY h:mm a',
    formatTime:'h:mm a',
    formatDate:'DD.MM.YYYY'
});

However, this call gives us the error $(...).datetimepicker is not a function.
What am I doing wrong? This was working fine no more than a week ago, I ran an npm install and I think it must've updated the datetimepicker, because now it's failing.
For reference, I'm using jQuery 2.1.4, and jquery-datetimepicker is 2.5.1.

Seems very similar to this other issue:
https://github.com/xdan/datetimepicker/issues/396

bump? Any word on this?

You guys copied the wrong code. Go into the build folder and grab the jquery.datetimepicker.full.js
It should fix it! :)

It seems fixed in https://github.com/xdan/datetimepicker/pull/399

This caused me quite the headache this evening.
I'm trying to use node.js with browserify to define all my JS dependencies and package everything up into one file. I couldn't get this to work for this library. I always got the $(...).datetimepicker is not a function error. No matter which of the JS files in the repo I tried to require.
Looking over the jquery.datetimepicker.full.js file it looks like jquery.mousewheel is concatenated to the end of the file. This (I think) causes the module.exports to reference the mousewheel factory, not the datetimepicker factory.
I've got this working by separating the php-date-formatter, jquery.mousewheel, and jquery.datetimepicker into separate files in my code base (so they're not installed via npm anymore). I then had to modify the php-date-formatter.js by adding module.exports=DateFormatter to the end of the file.
So now when I need to use the date time picker I have this:
var $ = require('jquery');
window.DateFormatter = require("../vendor/php-date-formatter");
require("../vendor/mousewheel")($);
require("../vendor/datetimepicker")($);

I'm not really a node.js guy so if there's a better way to do any of this, I'd be grateful for the advice.

@WilliamMayor I agree with your analysis. There is a branch of php-date-formatter which has a commonjs, amd and browser export header (https://github.com/kartik-v/php-date-formatter/tree/closure). I was able to keep my dependencies managed by npm by doing the following:
installing...
npm install jquery-datetimepicker
npm install https://github.com/kartik-v/php-date-formatter.git#closure

included in code...
DateFormatter = require('php-date-formatter')($);
require('jquery-mousewheel/jquery.mousewheel.js')($);
require('jquery-datetimepicker/jquery.datetimepicker.js')($);

Hope this helps someone save some time.

I had the same problem, I've solved it loading datetimepicker via the scripts loader.
First of all, install the package:
npm install --save-dev script-loader
and require datetimepicker as following:
require('script!jquery-datetimepicker');
Hope this is helpful.


Pressing enter in both Select Interpreter to start Jupyter server and Specify local or remote Jupyter server for connections is being ignored

Environment data

VS Code version: <IP_ADDRESS>

Jupyter Extension version (available under the Extensions sidebar): v2020.11.372831992

Python Extension version (available under the Extensions sidebar): v2020.11.371526539

OS (Windows | Mac | Linux distro) and version: Windows 2004

Python and/or Anaconda version: 3.8.3

Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX

Jupyter server running: N/A

Expected behaviour
Pressing enter in both Select Interpreter to start Jupyter server and Specify local or remote Jupyter server for connections takes my remote URI.
Actual behaviour
Pressing enter in both Select Interpreter to start Jupyter server and Specify local or remote Jupyter server for connections is being ignored and the input box stays open.
Steps to reproduce:
Open Command Palette search for commands above, enter some URI and try to press enter.
Logs
No output in output panel.

Ok, this seems to be broken to the ground hurting the overall UX.
I found following workaround for others driving by and as a note for myself since getting it up and running is complicted:

Start your local Jupyter, even if you don't need it, you need it to be there just to get started
Look that default interpreter and server are set to local ones using the command palette menu
Run a random code piece, so that the interactive tab opens and runs the code locally, doesn't matter if the code works, in my case usually some libs are missing I have on my server
In the interactive tab click on the Jupyter server info top right and only there and NOT in the command palette
Set the remote server and enter should hopefully work this time

Hi @205g0, I am not able to reproduce this issue at this time. Could you please provide a gif showing us what is happening?
If you need a tool, ScreenToGif works pretty well. https://www.screentogif.com/

We think this is probably a VS Code issue.

@205g0 when you run into this issue next time, could you please run a troubleshooting command "Developer: Toggle Keyboard Shortcuts Troubleshooting" and then repeat the * Select Interpreter* steps again, and lastly share the log from the outputs panel? This can help us understand which component is hijacking the enter key.

The same issue is happening to me as well. After some trial and error I found out that the extension tries to write "jupyter.jupyterServerType": "remote" to .vscode/settings.json but fails when no workspace is open.
Workaround: Open a workspace/folder first
If you need any more details, just let me know.

I had the same issue as well, the problem turned out to be that the OS I was using (Linux Manjaro KDE) did not have Gnome Keyring installed (ofc it doesn't, it's KDE) and that seems to be a required package.

Thanks for looking into this and apologies for my late reply. I couldn't reproduce my issue anymore. Now, I can directly open the select remote server dialogue, click existing, add my server URI and press enter. Feel free to close this issue, I will observe this and come back with more info if I encounter this problem again.

Moving this back to new triage as info has been provided. Sorry about the issue here, but a fix might be a bit slow coming as most of the team is out over the holidays.

Validated. For 'Select Interpreter to start Jupyter server' and 'Specify local or remote server for connections', hitting enter with a quickpick item selected results in that selection being taken and advancing to the next step in the multistep quickpick.

Validated. For 'Select Interpreter to start Jupyter server' and 'Specify local or remote server for connections', hitting enter with a quickpick item selected results in that selection being taken and advancing to the next step in the multistep quickpick.

The same issue is happening to me as well. After some trial and error I found out that the extension tries to write "jupyter.jupyterServerType": "remote" to .vscode/settings.json but fails when no workspace is open.
Workaround: Open a workspace/folder first
If you need any more details, just let me know.

yep I made it by changing but idw how it works


Support stream idle timeout.

Fixes https://github.com/containerd/cri/issues/1057.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

What do you think about adding stream timeout to the pod spec to move the default from a kublet/dockershim hidden (from CRI) flag to a pod request?

@mikebrow It is a daemon wide configuration. I don't think we should make it per pod.
And it is too low level to be part of "pod spec" which is the user facing api. I think a daemon configuration is good enough.
If we really want, we can support Kubernetes component config (similar with Kubelet dynamic config).

Yes to Kubernetes component config. I think that would work.


Kubeflow UI not responding and dex-auth ERROR

As suggested in https://github.com/canonical/bundle-kubeflow/issues/450 - Creating new Issue ticket for below
Not able to create Notebook Server

dex-auth ERROR:

Appreciate any help on how to fix these issues...
Config settings:
$ microk8s kubectl patch role -n kubeflow istio-ingressgateway-operator -p '{"apiVersion":"rbac.authorization.k8s.io/v1","kind":"Role","metadata":{"name":"istio-ingressgateway-operator"},"rules":[{"apiGroups":[""],"resources":[""],"verbs":["*"]}]}'
role.rbac.authorization.k8s.io/istio-ingressgateway-operator patched
$juju config dex-auth public-url=http://<IP_ADDRESS>.nip.io
$juju config oidc-gatekeeper public-url=http://<IP_ADDRESS>.nip.io

@natalian98  Please find the details below
snap info microk8s
tacking = 1.21/stable

microk8s status

kubectl get svc -A | grep istio
External IP not assigned

From the microk8s status output I can see that metallb wasn't enabled, which is why the istio service's external ip is pending.
Try running microk8s enable metallb:<IP_ADDRESS>-<IP_ADDRESS> and the loadbalancer should get it assigned, allowing you to configure and access the dashboard using the nip.io link.
If problems persist, please attach juju logs. They can be retrieved using juju debug-log --replay.

Regarding the problem accessing the notebook creation page (the first screenshot), I think this will be resolved if we get the regular access through the gateway figured out.  This looks familiar, although I can't remember exactly how to reproduce it.  I think it has to do with accessing the dashboard directly instead of through the gateway (I think coming in through the gateway attaches a user identity to the dashboard access, and without that things don't work right)

I think this should be sorted out with the metalb fix, so I am closing this issue.  Please reopen though if it is still relevant.  Thanks!


Fullscreen handler not setup properly for Firefox

Describe the bug
Firefox is refusing to put slides into fullscreen mode:

Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler.

To Reproduce

Open in Firefox
Use the shortcut to enter fullscreen mode (depends on branch)
Check console for error

Expected behaviour
Enter fullscreen mode.
Additional context
Fullscreen works in Chromium & Webkit browsers.

I thought 70a0411 might fix this, but it did not. Do we need a 'shorter lived' listener specifically for the fullscreen request? This is supposed to happen 'within 1s' - and it clearly is, so there must be some other issue?


Why do notifications use JSON-LD?

Note that the message format could also be negotiated by clients; either during the initial negotiation phase (#296), or when setting up the WebSocket connection. There is probably a preference for the initial negotiation phase in order to not surprise clients after they have made their choice of channel.

Servers can indeed advertise their capability to accept client's preferred serialization for the notifications by including the notify:accept ( https://solidproject.org/TR/2022/notifications-protocol-20220509#feature-accept ) as part of the notification channel's notify:feature set.

Is there anything outstanding in this issue before closing?

Note that this issue was part of my series of questions to clarify the design; I've interviewed @acoburn and written his response. I was purely documenting/scribing here and have no concerns.


mcbackup failes to authenticate to rcon

I think that the RCON_HOST which is set to localhost is incorrect and should point to the rcon service: https://github.com/itzg/minecraft-server-charts/blob/master/charts/minecraft/templates/deployment.yaml#L358-L359
These are the logs of the mc-backup container:
╰─❯ k logs svc/minecraft-minecraft minecraft-minecraft-mc-backup -f
time="2024-10-30T14:08:42Z" level=info msg="Skipping uid/gid change since current user is not root"
2024-10-30T14:08:42+0000 INFO Repository already initialized
2024-10-30T14:08:42+0000 INFO Checking for stale locks
2024-10-30T14:08:42+0000 INFO Checking repo integrity
2024-10-30T14:08:43+0000 INFO waiting initial delay of 2m...
2024-10-30T14:10:43+0000 INFO waiting for rcon readiness...
2024-10-30T14:10:43+0000 ERROR Unable to execute rcon-cli save-on - try 0/5. Retrying in 10s
2024-10-30T14:10:43+0000 ERROR Failure reason: 2024/10/30 14:10:43 Failed to connect to RCON serverrcon: authentication failed
2024-10-30T14:10:53+0000 ERROR Unable to execute rcon-cli save-on - try 1/5. Retrying in 10s
2024-10-30T14:10:53+0000 ERROR Failure reason: 2024/10/30 14:10:53 Failed to connect to RCON serverrcon: authentication failed
2024-10-30T14:11:03+0000 ERROR Unable to execute rcon-cli save-on - try 2/5. Retrying in 10s
2024-10-30T14:11:03+0000 ERROR Failure reason: 2024/10/30 14:11:03 Failed to connect to RCON serverrcon: authentication failed
2024-10-30T14:11:13+0000 ERROR Unable to execute rcon-cli save-on - try 3/5. Retrying in 10s
2024-10-30T14:11:13+0000 ERROR Failure reason: 2024/10/30 14:11:13 Failed to connect to RCON serverrcon: authentication failed
2024-10-30T14:11:23+0000 ERROR Unable to execute rcon-cli save-on - try 4/5. Retrying in 10s
2024-10-30T14:11:23+0000 ERROR Failure reason: 2024/10/30 14:11:23 Failed to connect to RCON serverrcon: authentication failed
2024-10-30T14:11:33+0000 ERROR Unable to execute rcon-cli save-on - try 5/5. Retrying in 10s
2024-10-30T14:11:33+0000 ERROR Failure reason: 2024/10/30 14:11:33 Failed to connect to RCON serverrcon: authentication failed

The backup container runs as a sidecar with the Minecraft server in the same pod, so localhost is correct.
If you look again at the logs it says the reason
Failure reason: 2024/10/30 14:10:43 Failed to connect to RCON serverrcon: authentication failed

oops! you were right!
thank you!


CONTRIBUTING: add description about adding tests

Add description about adding tests to CONTRIBUTING.md.

Ideally most functionalities should be covered by both unit tests and functional tests. This means, every time when you add a new functionality, you should also add unit tests, which is stored in SRC_test.go, as well as a functional test, located under directory ./functional/.
Note that when adding a unit test under a new directory, you need to make sure that the new directory must be added to TESTABLE in ./test. Without doing that, CI cannot run the new unit tests at all. Even build errors cannot be automatically detected.

LGTM

Merged https://github.com/coreos/fleet/pull/1605. Thanks.


error when running 'java' is not recognized...

I recently found this project, but am a bit confused.  When running dependency-check.bat from the command line, I'm getting the error "'java' is not recognized as an internal or external command, operable program or batch file."
Does dependency-check require Java?  I don't have Java on my PC, but would like to run dependency-check against some .NET software.

Dependency-Check, the tool itself, is written in Java and requires a Java Runtime Environment to be installed on your machine. Dependency-Check is not limited to scanning Java dependencies. It can scan dependencies written for Python, Node.js, and of course .NET including .exe, .dll, and NuGet.

Thanks for the info, Steve.


Fix LDAP attribute case sensitivity issue

Fixes an issue described in #1317 where attributes with upper-cased characters were not mapped correctly.

Thanks for this @dfanara.
Just one question, I understand that the casing will need to be lowercase for accessing the response from the LDAP query but I see this change will also lower-case the attribute in the query itself. Will that be an issue?
Just wondering if it would safer to leave the casing for the query and convert to lower-case only when reading the result (In the getUserResponseProperty function maybe).

As of this change I believe this pull request is now redundant.
Thanks again @dfanara for offering this pull request.


Adds openssh-clients package installation.

Issue: https://github.com/rancher/rancher/issues/43115
Rancher images currently being built no longer run due to the missing package openssh-clients. jail.sh uses the ssh binary when running and causes Rancher to exit if it does not exist.
The package is missing since git-core which was being installed by rancher no longer requires openssh-clients.
2 Root causes of this issue are

Rancher does not explicitly install versions of the following pakacgesgcc binutils glibc-devel-static ca-certificates git-core wget curl unzip tar vim less file xz gzip sed gawk iproute2 iptables
jq skopeo

Rancher does not explicitly install openssh-clients.

This PR attempts to fix the issue by addressing point number 2.

/backport v2.7.x

/backport v2.7.x


Changes to expose config broke "null-ls"

Description
Hi,
Changes from https://github.com/neovim/nvim-lspconfig/pull/1479 broke null-ls from loading. Setting packer to the specific commit just before it (10ad0cca1b83713ed98ed4cb7ea60f2ea8e55c49) makes it work again.
I saw that this was documented as a breaking change but don't know if the author needs to do something to support the change or lspconfig needs to workaround cases like it.
cc: @mjlbach
Neovim version
NVIM v0.6.0-dev+635-ga31e7523f
Build type: Release
LuaJIT 2.1.0-beta3
Nvim-lspconfig version
b2d302f1609a8267f4b855d8853fba65669aa8e5
Operating system and version
Debian Unstable
Affected language servers
null-ls
Steps to reproduce

Use the latest (as of right now) lspconfig
Install and use null-ls as described in its README page
Try to open neovim

Actual behavior
A lot of Cannot access configuration for null-ls. Ensure this server is listed in server_configurations.md or added as a custom server. messages
Expected behavior
No errors and null-ls working
Minimal config
local on_windows = vim.loop.os_uname().version:match("Windows")

local function join_paths(...)
    local path_sep = on_windows and "\\" or "/"
    local result = table.concat({ ... }, path_sep)
    return result
end

vim.cmd([[set runtimepath=$VIMRUNTIME]])

local temp_dir
if on_windows then
    temp_dir = vim.loop.os_getenv("TEMP")
else
    temp_dir = "/tmp"
end

vim.cmd("set packpath=" .. join_paths(temp_dir, "nvim", "site"))

local package_root = join_paths(temp_dir, "nvim", "site", "pack")
local install_path = join_paths(package_root, "packer", "start", "packer.nvim")
local compile_path = join_paths(install_path, "plugin", "packer_compiled.lua")

local function load_plugins()
    require("packer").startup({
        {
            "wbthomason/packer.nvim",
            "neovim/nvim-lspconfig",
            "jose-elias-alvarez/null-ls.nvim",
        },
        config = {
            package_root = package_root,
            compile_path = compile_path,
        },
    })
end

_G.load_config = function()
    vim.lsp.set_log_level("trace")
    if vim.fn.has("nvim-0.5.1") == 1 then
        require("vim.lsp.log").set_format_func(vim.inspect)
    end
    local nvim_lsp = require("lspconfig")
    local on_attach = function(_, bufnr)
        local function buf_set_keymap(...)
            vim.api.nvim_buf_set_keymap(bufnr, ...)
        end
        local function buf_set_option(...)
            vim.api.nvim_buf_set_option(bufnr, ...)
        end

        buf_set_option("omnifunc", "v:lua.vim.lsp.omnifunc")

        -- Mappings.
        local opts = { noremap = true, silent = true }
        buf_set_keymap("n", "gD", "<Cmd>lua vim.lsp.buf.declaration()<CR>", opts)
        buf_set_keymap("n", "gd", "<Cmd>lua vim.lsp.buf.definition()<CR>", opts)
        buf_set_keymap("n", "K", "<Cmd>lua vim.lsp.buf.hover()<CR>", opts)
        buf_set_keymap("n", "gi", "<cmd>lua vim.lsp.buf.implementation()<CR>", opts)
        buf_set_keymap("n", "<C-k>", "<cmd>lua vim.lsp.buf.signature_help()<CR>", opts)
        buf_set_keymap("n", "<space>wa", "<cmd>lua vim.lsp.buf.add_workspace_folder()<CR>", opts)
        buf_set_keymap("n", "<space>wr", "<cmd>lua vim.lsp.buf.remove_workspace_folder()<CR>", opts)
        buf_set_keymap("n", "<space>wl", "<cmd>lua print(vim.inspect(vim.lsp.buf.list_workspace_folders()))<CR>", opts)
        buf_set_keymap("n", "<space>D", "<cmd>lua vim.lsp.buf.type_definition()<CR>", opts)
        buf_set_keymap("n", "<space>rn", "<cmd>lua vim.lsp.buf.rename()<CR>", opts)
        buf_set_keymap("n", "gr", "<cmd>lua vim.lsp.buf.references()<CR>", opts)
        buf_set_keymap("n", "<space>e", "<cmd>lua vim.lsp.diagnostic.show_line_diagnostics()<CR>", opts)
        buf_set_keymap("n", "[d", "<cmd>lua vim.lsp.diagnostic.goto_prev()<CR>", opts)
        buf_set_keymap("n", "]d", "<cmd>lua vim.lsp.diagnostic.goto_next()<CR>", opts)
        buf_set_keymap("n", "<space>q", "<cmd>lua vim.lsp.diagnostic.set_loclist()<CR>", opts)
    end

    -- Add the server that troubles you here
    local name = "null-ls"
    if not name then
        print("You have not defined a server name, please edit minimal_init.lua")
    end
    if not nvim_lsp[name].document_config.default_config.cmd then
        print([[You have not defined a server default cmd for a server
      that requires it please edit minimal_init.lua]])
    end

    require(name).config({
        sources = {
            require("null-ls").builtins.formatting.stylua,
            require("null-ls").builtins.completion.spell,
        },
    })
    nvim_lsp[name].setup({
        on_attach = on_attach,
    })

    print(
        [[You can find your log at $HOME/.cache/nvim/lsp.log. Please paste in a github issue under a details tag as described in the issue template.]]
    )
end

if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system({ "git", "clone", "https://github.com/wbthomason/packer.nvim", install_path })
    load_plugins()
    require("packer").sync()
    vim.cmd([[autocmd User PackerComplete ++once lua load_config()]])
else
    load_plugins()
    require("packer").sync()
    _G.load_config()
end

Health check
lspconfig: require("lspconfig.health").check()

INFO: pyright: configuration checked.
INFO: tsserver: configuration checked.
INFO: eslint: configuration checked.
INFO: vimls: configuration checked.
INFO: cssls: configuration checked.
INFO: bashls: configuration checked.
INFO: dockerls: configuration checked.
INFO: yamlls: configuration checked.
INFO: jsonls: configuration checked.
INFO: sumneko_lua: configuration checked.
INFO: html: configuration checked.

obs. null-ls not displayed here but before the change it was showing as "configuration checked"
LSP log
n/a

Yes, that's an issue with null-ls, see https://github.com/jose-elias-alvarez/null-ls.nvim/issues/378

no ig it's not an issue with null-ls
my personal setup broke and lspmanager also broke

it 100% is and was fixed by https://github.com/jose-elias-alvarez/null-ls.nvim/commit/f3a4a14652c85f5bf637d9f3c6dfde2eb5e3d7fc

If other plugins (and configs) made use of internal implementation details that should not be considered public API, these of course could also be broken and need to be adapted.

I don't know what's the problem, what you changed and what was with null-ls
I only know I don't use null-ls and I get an error

Well, if it's a separate issue than null-ls (which is what this issue is about), you should examine your config.

it always worked before updating nvim-lspconfig

and I get exactly the same error
Cannot access configuration for ls_emmet. Ensure this server is listed in `server_configurations.md` or
 added as a custom server.

the error message is extremely explicit, replace ls_emmet with emmet_ls

packer.nvim: Error running config for nvim-lspconfig: ...pack/packer/opt/nvim-lspconfig/lua/lspconfig/configs.lua:10: attempt to index local 'config_def' (a nil value)

Come on, don't hijack unrelated issues. Ask on chat or open your own.


Update readme.md

Generalize the way to import the dashboards.

@microsoft-github-policy-service agree
Kind Regards,
Ali
Advance notice of leave: 9th – 11th Feb 2024

From: microsoft-github-policy-service[bot] @.>
Sent: Saturday, March 16, 2024 12:12 PM
To: microsoft/Dynamics-365-FastTrack-Implementation-Assets @.>
Cc: Ali Adamu @.>; Mention @.>
Subject: Re: [microsoft/Dynamics-365-FastTrack-Implementation-Assets] Update readme.md (PR #316)
@AliAAdamuhttps://github.com/AliAAdamu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Dynamics-365-FastTrack-Implementation-Assets/pull/316#issuecomment-2001952521, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGNKOGCGYJI4ODAIZJTIJ7DYYQSLRAVCNFSM6AAAAABEZHQN7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBRHE2TENJSGE.
You are receiving this because you were mentioned.Message ID: @.***>

Added "Errors" dashboard

Added "Forms" dashboard

Correction in the "Forms" dashboard

Correction in the "Forms" dashboard


Clean up Imports, Capitalize Enum members, Refactor

This is mostly a cleanup of the library to make using the library more obvious for developers.

[x] In example.py there are too many imports... try to restrict it to

import hidparser

[ ] Consider renaming the library import to hid since parser implies it's used for parsing, and not creating or using descriptors.

[ ] Enum members should be capitalized. Although python libraries itself son't follow this rule, in PEP 8 Constants it recommends all-caps with underscores.

From 6888558ec273e09f297039f8737b1603a2bfdbb8

For code style consistency, clases that inhert Enum now ahve capitialised members as they represent constant values.
However, when they are used for creating members in Collections, they are converted to lowercase for code readability and consistency


Add error dictionary

Define a map that has an error code mapped to an object that holds technicalMessage and humanizedMessage to be used on view layer packages.

Thoughts on supporting internalization? I think all that's necessary on our part is to allow an optional error dictionary to be passed in.

Mmmm true. Merge in with our dictionary.

not relevant at this point.


I've been trying to make this work with firebase

Using in conjunction with https://github.com/rmmmp/emberfire-utils#storage-manipulations
The major problem is trying to integrate with the file.upload() method, as I'm required to do this to upload to firebase: this.get('firebaseUtil').uploadFile(`images/${filename}`, file.blob).then(...). I'm trying to figure out how to integrate this two together, but I can't seem to make it work, any idea on how to do it?

I managed to make it work with this
const progressBar = function(snapshot) {
  const progress = (snapshot.bytesTransferred / snapshot.totalBytes) * 100;

  set(file, 'loaded', snapshot.bytesTransferred);
  set(file, 'size', snapshot.totalBytes);
  set(file, 'progress', progress);

  if (progress === 100) set(file, 'state', 'uploaded');
}

as uploadFile can also accept a method with the path and file to handle the progress, I pass progressBar and just handle the file state.
This works but it's not a very elegant solution, it would be nice to allow the user to use his own uploader method in cases like this.

Anyway, I'm closing this. I hope this can help in case someone searchs for how to do it :)

Hmm. This is a bit tricky, since you're uploading over a different protocol (possibly). Your solution looks ok here- you don't need to use the upload method, but it does provide an easier way to upload for 95% of use cases that I've worked with. (I'm not sure how many apps use a different transport mechanism for uploading files other than XMLHttpRequests)


[TASK] Restructure HybridModel class

Issue Description
A new model entity "LogicalModel" will be implemented. The LogicalModel utilizes control functions or fault tree/event tree to manage the selection and execution of different models (i.e. ExternalModel, ROMs, Codes). Both LogicalModel and current HybridModel share some common functionalities. In this case, a new base class will be created for both entities. First, we are planing to restructure the HybridModel entity, and create the base class for it. Second, after the restructure, the LogicalModel entity will be created. In addition, since HybridModel and EnsembleModel entities also share some common functionalities when interact with models. A common module to handle the interactions with models will also be created.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

@alfoa @PaulTalbot-INL @mandd Please take a look at this issue, and all comments are really appreciated.

This looks consistent with our team discussions to me. I like the idea of a "model handler helper" entity more than trying to build it into any of the base classes 👍

Closure checklist passed...
Closure approved via #1232


Change comparison in partitions to include equals

Description of changes:
A warning is raised during partitioning when the number of canonical nodes is equal to the number of samples. It is my understanding that this should be valid (one sample per node), and that issues only occur when the number of samples is less than the number of canonical nodes. Apologies if my understanding is incorrect here.
The simple fix is to the change the comparison to be >= rather than >
Merge Checklist:
Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the contributor guidelines
[ ] This is a documentation change or typo fix. If so, skip the rest of this checklist.
[x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
[x] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

[ ] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[ ] I ran the tests locally to make sure it pass. (check out testing)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

I didn't realise this would break the tests (I made the change in the browser). If this change makes sense I'll happily go and alter the tests as appropriate.

I've now updated the code such that the tests pass but the warning is not raised for the edge case: num_canonical_nodes == num_samples and num_canonical_nodes > num_physical_nodes.


Question: preprompt same as system message?

As the title says, I want to set a system message but I'm not sure. I like the raw input field of gpt4all, character cards are a bit cryptic to me.
Actually, I need ChatML for openhermes.
I also don't know if I need to indicate the new line after user or if that's added automatically.
Well forget everything above and let's change this to a bug report because the preprompt can't be even changed, even saving the json, editing it manually and loading it again won't work. And there isn't a workaround because the maid prepomt is automatically added as soon as you create a new character, so there is no way of getting rid of it.

Yeah pre-prompt is the same as system message.
Ill get around to ChatML at some point
The new line is added automatically
Ill look into your issue with character card preprompts

@GameOverFlowChart Ok when this build completes give it a shot and see if your issue is fixed?
https://github.com/MaidFoundation/maid/actions/runs/7115145566

Yes, this worked. It seems like the json import still doesn't change that field (or I edited the json wrong) but I can simply change that field in the app and even turn it empty. And I tested it by asking the model if it's a maid. The answer was no.


very slow with nerdtree side panel

with nerdtree side panel opened, moving in file is VERY slow.
good after close side panel, good after disable the plugin, so looks like a bug.
I see a few similar issues reported earlier, but I don't see any solution.
is this by design, or are there any known workaround?
thanks!

+1

I have to say sorry that it does can be very slow if you open a large directory. You can try to set g:NERDTreeGitStatusUpdateOnWrite and g:NERDTreeGitStatusUpdateOnCursorHold to 0 to disable live update.