NullReferenceException calling connect-microsoftTeams using certificate authentication

When executing the lines below I  get a NullReferenceException.
I am using the 1.1.10-Preview version of the MicrosoftTeams powershell module, if I run Excactly the same using the 1.1.6 general release version it works fine.
I am trying the prerelease version to see if an other problem is solved in the prerelease version. (trying to to use new-csonlinesession in combination with the connect-microsoftteams using certificate #7154 )
$tenantID = 'MyownTenantname.onmicrosoft.com'
$appID = 'My-Correct-AppID'
Connect-MicrosoftTeams -CertificateThumbprint MyCertificateThumb -ApplicationId $appID -TenantId $tenantID
Connect-MicrosoftTeams : Object reference not set to an instance of an object.
At line:1 char:1

Connect-MicrosoftTeams -CertificateThumbprint MyCertificateThumb ...

  + CategoryInfo          : AuthenticationError: (:) [Connect-MicrosoftTeams], NullReferenceException
  + FullyQualifiedErrorId : Connect-MicrosoftTeams,Microsoft.TeamsCmdlets.Powershell.Connect.ConnectMicrosoftTeams

Connect-MicrosoftTeams : Object reference not set to an instance of an object.
At line:1 char:1

Connect-MicrosoftTeams -CertificateThumbprint MyCertificateThumb ...

  + CategoryInfo          : NotSpecified: (:) [Connect-MicrosoftTeams], NullReferenceException
  + FullyQualifiedErrorId : System.NullReferenceException,Microsoft.TeamsCmdlets.Powershell.Connect.ConnectMicrosoftTeams

Hello @BoBladm how are you? Hope you are doing good.
Here, we are limited to documentation issues. The best, in this case, would be to either open a support request or raise an idea here so it reaches the team behind the development of the Teams PowerShell module, new versions of the module are constantly being released and I am pretty sure the team will welcome any feedback to improve it.
I hope this gets you in the right direction to answer your inquiry.
Thank you

Hello @BoBladm how are you? Hope you are doing good.
Here, we are limited to documentation issues. The best, in this case, would be to either open a support request or raise an idea here so it reaches the team behind the development of the Teams PowerShell module, new versions of the module are constantly being released and I am pretty sure the team will welcome any feedback to improve it.
I hope this gets you in the right direction to answer your inquiry.
Thank you

@get-itips Thank you very much for the contribution and sharing this explanation. @BoBladm Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Made compatible as an ESP-IDF component.

Thanks for this faster sin/cos. Works perfect with my POV project.
That said, I'm using ESP-IDF (no arduino) for my project.  Your core code is compatible with the ESP-IDF framework, except for a few very minor details. The #include "Arduino.h" for example.
Here is the code changes I had to make to make your library work with ESP-IDF.
Quite trivial IMO, and I think you'd be able to include some or all of these changes into your code.
You're welcome to just take the changes as you see them, and add them manually, or merge this PR.. what ever works for you.

Thanks for this addition. I started a build and will look into it later today (its morning here).
If it does not break the code, similar changes might be interesting for a lot of my libraries

Build looks OK, but I see a possible problem in the future
#ifdef ESP_PLATFORM
#define boolean bool
#endif

This define might conflict if it is done twice somewhere.
Better solution is that I use boolean instead of bool (in all my libs)
boolean compiles for Arduino, just tested in develop branch.

looking at the code I see the table isinTable8[] which can be read as "is in table" where I meant "integer sin table"
So I'll add that to my todo - just call them sinTable8[].


git bash terminal issue

Issue Type: Feature Request
when i started terminal there is close immediatly what i do
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.17134

What's in your settings.json file? Do you get a notification when it happens and does anything show up in the console (Help > toggle developer tools)?


docs: add <RenderOnce>

What is it?
fixes #2403

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

@manucorporat as @shairez asked on https://github.com/BuilderIO/qwik/pull/2452#discussion_r1096531526: is there any good use case for this component and should it be documented? thanks once again 🙏

Thank you very much!!

thanks @zanettin
@manucorporat when would we want to use <RenderOnce> ? (we need to add a use case to the documentation IMO)


Authorisation with Heroku

Hi there,
I have built an app locally using spotipy (thanks for your awesome code!) and I'm trying to push it online with Heroku. I use the util.prompt_for_user_token() function to authorise the user_playlist_create function. Since the util function requires a command line raw input I can't understand how it will work when I push it online - can you a suggest a way that I can by pass this problem?
Many thanks!
Issy

I had the same problem in https://github.com/arska/srf2spotify#usage:

run locally once to do the authentication
copy the contents of .cache-spotifyusername into a config variable and a local .env file for testing, e.g. SPOTIPY_CACHE='{"access_token": ...}'
create a small launch script that does:
#!/bin/sh
echo $SPOTIPY_CACHE > .cache-spotifyusername
python yourapp.py

Follow this example to use spotipy in an API https://github.com/plamere/spotipy/blob/master/examples/app.py


[New Feature]Add animation effects to  Higress website for enhanced user experience

"Add animation effects to Higress website: include fade-in on page load and smooth transitions between sections for enhanced user experience"
https://github.com/user-attachments/assets/d047a4e2-4f32-4407-a764-b456638dadf7

Add AOS animations to  website

Integrated AOS (Animate On Scroll) library
Applied animations to various sections of the site
Improved user experience with smooth scroll effects
link：https://github.com/openyurtio/openyurt.io/issues/441

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Azure DevEx Architecture Board: Review of Multivariate Anomaly Detection

New SDK Review meeting has been requested.
Service Name: Multivariate Anomaly Detection
Review Created By: Laurent Mazuel
Review Date: 4/17/2023 4:05 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: Javascript, Java, .NET, Python,
Description: Anomaly Detector GA for //build/, final review before release.
Detailed meeting information and documents provided can be accessed here

Meeting updated by Laurent Mazuel
Service Name: Multivariate Anomaly Detection
Review Created By: Laurent Mazuel
Review Date: 04/17/2023 04:05 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: .NET, Java, Javascript, Python,
Description: Anomaly Detector GA for //build/, final review before release.
Detailed meeting information and documents provided can be accessed here

As per email discussion, tests should be reviewed as well for adherence to the DPG SDK guidelines.

The Python APIview linked here does not show the diff for Multivariate anomaly detection, and is only showing the diff since the last beta. Could we please get the correct diff since the last GA so that it can be properly reviewed?

.NET is also using an incorrect ApiView listing for just one of the PRs.  We'll use the automatic listing at https://apiview.dev/Assemblies/Review/0eacd79245e14c6fa88d5991aac2e02f instead.


[boost] boostorg-cobalt-boost build failure with C++ 17

Operating system
Windows 11
Compiler
MSVC
Steps to reproduce the behavior
vcpkg install boost

Failure logs
> vcpkg install boost
...
-- Downloading https://github.com/boostorg/cobalt/archive/boost-1.84.0.tar.gz -> boostorg-cobalt-boost-1.84.0.tar.gz...
-- Cleaning sources at C:/path/to/vcpkg/buildtrees/boost-cobalt/src/ost-1.84.0-f1b8232bac.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/path/to/vcpkg/downloads/boostorg-cobalt-boost-1.84.0.tar.gz
-- Using source at C:/path/to/vcpkg/buildtrees/boost-cobalt/src/ost-1.84.0-f1b8232bac.clean
-- Including C:/path/to/vcpkg/ports/boost-cobalt/b2-options.cmake
-- Found external ninja('1.11.0').
-- Getting CMake variables for x64-windows-cpp17
-- Configuring x64-windows-cpp17
-- Building x64-windows-cpp17-dbg
-- Building x64-windows-cpp17-rel
CMake Error at installed/x64-windows-cpp17/share/boost-build/boost-modular-build.cmake:196 (message):
  No libraries were produced.  This indicates a failure while building the
  boost library.
Call Stack (most recent call first):
  ports/boost-cobalt/portfile.cmake:17 (boost_modular_build)
  scripts/ports.cmake:175 (include)

error: building boost-cobalt:x64-windows-cpp17 failed with: BUILD_FAILED
Elapsed time to handle boost-cobalt:x64-windows-cpp17: 5.1 s
...

triplet: x64-windows-cpp17.cmake
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_CXX_FLAGS "/std:c++17")
set(VCPKG_C_FLAGS "/std:c17")

Thanks for posting this issue, could you plesa refer to this issue https://github.com/microsoft/vcpkg/issues/33288 ?

CMake Error at installed/x64-windows-cpp17/share/boost-build/boost-modular-build.cmake:196 as below:
if(NOT EXISTS "${CURRENT_PACKAGES_DIR}/lib")
    message(FATAL_ERROR "No libraries were produced. This indicates a failure while building the boost library.")
endif()

No complie or link error, but lack of the lib directory.

@playgithub
Could you please run the following command and try again? :)
./vcpkg remove boost-uninstall:x64-windows-cpp17 --recurse

Reproduce this issue locally on x64-windows.

@playgithub Could you please run the following command and try again? :)
./vcpkg remove boost-uninstall:x64-windows-cpp17 --recurse

With the env vars below
VCPKG_DEFAULT_HOST_TRIPLET x64-windows-cpp17
VCPKG_DEFAULT_TRIPLET x64-windows-cpp17

Tried as below
vcpkg remove boost-uninstall:x64-windows-cpp17 --recurse
vcpkg install boost

Got the same error

How long would it be fixed?

@playgithub
Do you have the generated lib in folder \vcpkg\installed\x64-windows-cpp17\lib?

Do you have the generated lib in folder \vcpkg\installed\x64-windows-cpp17\lib?

For the bug blocks my work, I've switched to Linux, so I can't test it now.

Do you have the generated lib in folder \vcpkg\installed\x64-windows-cpp17\lib?

Yes

Will there be any target date for this ?
We are having same issue for 'x64-linux' and cannot do anything without the fix.

@achmad-agus
Sorry for the late reply, for boost-cobalt, both vcpkg and upstream have a C++ standard requirement of 20 for the build.
vcpkg: https://github.com/microsoft/vcpkg/blob/5fa0f075ea51f305b627ecd5e050a363707353ff/ports/boost-cobalt/b2-options.cmake#L1
Upstream:
https://github.com/boostorg/cobalt/blob/820f9c3906c236e6fd316cba4736c87e16b4eacb/build/Jamfile#L54

If the error message would have told this, it would save a lot of time.
Thanks


unable to connect to TM1py with Nginx https non standard url

The standard URL has https://servername:port/api/v1.. for us the onpremise uses nginx setup and has the https://servername:port/tm1/test/
The connection is refused with 404 or 401 as the default behaviour points to api/v1 ...
how to change the default behaviour and use /tm1/test in restservice.py,etc...

Hi @SatyaDnv,
does it work if you provide the base_url parameter instead:
from TM1py import TM1Service

with TM1Service(base_url="https://localhost:12354", user="admin", password="apple") as tm1:
    print(tm1.server.get_product_version())

Thank you for the response.
No. It sends 404 not found exception.

what request do you do against nginx to get the $metadata document in the browser?
Without a proxy you would do this:
https//localhost:12354/api/v1/$metadata

The following request response is working well. however, TM1py is 404 not found error.
sConnection_String = 'https://servername:8001/tm1/dev/dashboards'
sCube_Name = 'detailed'
sPrivate_View_Name = 'reportview'
sRequest = sConnection_String + "/Cubes('" + sCube_Name + "')"
"/Views('" + sPrivate_View_Name + "') /tm1.Execute?"
"$expand=Axes($expand=Hierarchies($select=Name),Tuples($expand=Members($select=Name))),Cells($select=Ordinal,Value)"
response = requests.post(sRequest,
json='Content-type: application/json; charset=utf-8',
auth=HttpNegotiateAuth()
)
print(response.json())

https//server0:12354/api/v1/$metadata gaves me response of xml of metadata

Please upgrade to the new feature branch and see if it works now through nginx:
pip uninstall tm1py
pip install https://github.com/cubewise-code/tm1py/archive/refs/heads/featue/change-base-url-to-include-api-v1.zip

as base_url provide: "https://servername:8001/tm1/dev/dashboards"

I think the only solution is to re-map the delegation of your Nginx.
Instead of delegating requests to https://localhost:12354/api/v1/... it needs to delegate to https://localhost:12354/...

With 741. i recieve following error.
ERROR:
No response returned from URL: 'https://servername:8001/tm1/dev/dashboards/api/v1/Configuration/ProductVersion/$value'. Please double check your address and port number in the URL.


Proposed solution for namespaced orgs

Critical Changes
Changes

Correct a bug in how the set_organization_wide_defaults task operated in namespaced scratch orgs.

Issues Closed

Marking this PR "in progress" because I've identified a potential issue in ProfileGrantAllAccess I need to explore further.


Fix bug in unicode encoding and include macOS-specific files into .gi…

…tignore.

Ah, the classic DS Store


[Feature] Introduce graceful decommission for shuffle server

When shuffle servers needed to decommission are included in exclude-node-files, we hope shuffle server will exit by its own when all apps finished.
Draft PR: #85

Why don't we reuse the issue #80? In my opinion, it's duplicate issue.

Sorry i miss previous issue. Merge this topic to #80


STDIN support?

I know this has been mentioned before, but having support for terminal input, like input() in Python, would be awesome. Is there any plans for implementing this is the near future?

This is a duplicate of #98

Well, that person hasn't posted back at all since then, nor has a fork kof the repo on their profile, and I'm not one for CoffeeScript, or I would help

Sure, but the issue itself should be followed along in #98 regardless. Closing this one to simplify issues.


gh-185 Integrate web-api-client with web-portal-client over Axios

change mock client to axios

@whiteadam2, your PR has conflicts, you also need to resolve them, so I can merge


2D structures not showing

When I have tried viewing the 23S and 16S Mycoplasma bovis 2D structures I receive the following error message:
"There was an error. Let us know if the problem persists by raising an issue on GitHub."

Thank you for reaching out to us. I just took a quick look and found this sequence: https://rnacentral.org/rna/URS00022109E4/28903 is showing the problem you mention. Is this the sequence you were looking at? We will look into the issue and try to resolve it for you. Thanks!

In the meantime, please feel free to use the R2DT web application to analyse the sequences you are interested in. For example, for URS00022109E4_28903 the sequence page shows an error, but the web application shows a secondary structure as expected:
https://rnacentral.org/r2dt?jobid=r2dt-R20220119-102425-0097-95300304-p2m

Hi @VMJarocki, you should be able to see the 2D structures now, please clear your cache and try again. In case you still get an error message, send me the URL so I can debug

All good now 😊
Cheers!
[photo]
Veronica Jarocki PhD
Research Associate, ithree institute, UTS
+61 411888474tel:+61 411888474 |<EMAIL_ADDRESS>@.http://www.linkedin.com/in/veronica-jarocki-a13863160
@.http://twitter.com/VMJarocki
From: Carlos Eduardo Ribas @.>
Sent: Thursday, 20 January 2022 4:48 AM
To: RNAcentral/r2dt-web @.>
Cc: Veronica Jarocki @.>; Mention @.>
Subject: Re: [RNAcentral/r2dt-web] 2D structures not showing (Issue #4)
Hi @VMJarockihttps://github.com/VMJarocki, you should be able to see the 2D structures now, please clear your cache and try again. In case you still get an error message, send me the URL so I can debug
—
Reply to this email directly, view it on GitHubhttps://github.com/RNAcentral/r2dt-web/issues/4#issuecomment-1016713669, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJFJYKE4TSUZ7JKEXM5TFKDUW32MXANCNFSM5MIJ5APQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>UTS CRICOS Provider Code: 00099F DISCLAIMER: This email message and any accompanying attachments may contain confidential information. If you are not the intended recipient, do not read, use, disseminate, distribute or copy this message or attachments. If you have received this message in error, please notify the sender immediately and delete this message. Any views expressed in this message are those of the individual sender, except where the sender expressly, and with authority, states them to be the views of the University of Technology Sydney. Before opening any attachments, please check them for viruses and defects. Think. Green. Do. Please consider the environment before printing this email.

Perfect, thanks @VMJarocki. Feel free to reach out if you run into any problems in the future.


Are there plans to create more modules besides music?

Or is the idea for developers to create their own by extending the core module?

We are certainly open to including more modules that are in-line with schema.org. What category do you have in mind?

I was thinking Movie

Sorry for the delayed response. Circling back to this after being reminded after another conversation about potential users of the COALA IP spec. I think it makes sense to have a variety of submodules that fulfill various category specific functionalities, we just have been building towards our own usecase which is music up to this point. If you plan to extend it with a movie module please keep us in the loop and feel free to open a PR and we'd be happy to review / include the changes. Thanks!

Will do! Thanks


Fixed bug of area white view

Resolves #91.

Looks fine

This would also have the effect of only just fitting the data in on the y-axis, I'm not sure this is desirable?


Odd output of pub in Git Bash and Cygwin on Windows

goderbauer@eseidel0-w MINGW64 /c/src/flutter/dev/tools (master)
$ pub.bat get
find: ‘>     bin [’: No such file or directory
Resolving dependencies...
Got dependencies!

The output find: ‘>     bin [’: No such file or directory seems odd. Other than that, it seems to work as expected.

Related: https://github.com/flutter/flutter/issues/8860.

Has this changed w/ the new windows stdout/err work?

Has this changed w/ the new windows stdout/err work?

Nope. Previous Dart versions also had the same problem.

This issue was moved to dart-lang/pub#1540


ZK PUT API doesn't support large payload

Seems that we set the payload as a query param in PUT API, which makes it part or URL. The large payload will easily exceed the URL length limit, which prevents updating a large payload.
@mayankshriv @kishoreg

It should be a payload instead of a query param.
We can make data optional, and add a payload to this API. If payload is not available, use the data for backward-compatibility

yes, we can make the backend change then fix the UI.
@shahsank3t

Yes, I can make the UI side changes once we have backend changes done.

I would love to work on it, please point me to the class

@galalen Thanks for volunteering. Please take a look at ZookeeperResource.java and add payload to the putData() method


[libpquv] Initial port

Initial libpquv port

I would suggest to add the CONFIG keyword to find_package/find_dependency(libuv). It avoids surprises with third-party find modules suddenly appearing in CMAKE_MODULE_PATH.

Done.

In general, I would avoid to add packages which haven't been updated in five years. Who will fix it when it blocks a libpq update?

Sorry, I cannot say for sure if the library is unmaintained. I just see there are no updates for 5 years but I have not tried to contact the author till now. I will do it by sending him the patches necessary to integrate into Vcpkg but first I want to finalize these patches. If you agree to merge the port. Otherwise I have to support the port locally for me because I am using the library in personal projects.

The vcpkg team discussed this and we don't feel right with adding a dead-on-arrival package to the main registry.
If you want to be able to install this library through vcpkg, I suggest creating your own custom registry and listing it in our public registries collection for other people to discover it.

@vicroms, I understand your concerns, it's ok. Thank you for your effort to review the port anyway :)
I am closing the pull request.


Drawer not following CSS with newest update

Morning Piotr,
Unironically loving the updates we've been getting on this, but on the latest drawer update. I believe I still have default colors for it, black but slightly transparent. Its a sleek look ngl. But now it appears blue-ish and slightly transparent. I have confirmed it is selected to use preset-0, and the following is the code for that file and a screenshot of what it looks like now.
  window {
      background-color: rgba (20, 20, 20, 0.95);
      color: #eeeeee
  }

  /* search entry */
  entry {
      background-color: rgba (0, 0, 0, 0.2)
  }

  button, image {
      background: none;
      border: none
  }

  button:hover {
      background-color: rgba (255, 255, 255, 0.1)
  }

  /* in case you wanted to give category buttons a different look */
  #category-button {
      margin: 0 10px 0 10px
  }

  #pinned-box {
      padding-bottom: 5px;
      border-bottom: 1px dotted gray
  }

  #files-box {
      padding: 5px;
      border: 1px dotted gray;
      border-radius: 15px
  }

Not sure if this is caused by something I did but it shouldn't be as I haven't been making any changes in this area at all lately. Thanks for providing this great suite!

But now it appears blue-ish and slightly transparent.

This looks like the default drawer.css.


Dataclasses treated as external module in py37-plus mode

the --pyXX-plus modes are only for removing __future__ / six imports
the actual detection of modules is based on the interpreter which is running.  If you're running reorder-python-imports using a python3.6 interpreter then it will be classified as third party
If you're using it through pre-commit, you may want to utilize language_version / default_language_version to select an appropriate version of python

Thank you for your prompt response. I was confused and confirmed it works correctly when executed with python3.7. I also pressed enter before filling the details in GitHub UI.

Cheers! Thanks for the issue


tour: Missing Return

Context: https://tour.golang.org/moretypes/18
after run this error appear:
tmp/sandbox056513425/main.go:6:1: missing return at end of function
if I run it in offline tour that package is not found error appears.

It is an exercise, please read the notes. You must make it work by writing code.

Yep, must be fixed, as requested by the text. Closing here.


Problem with enum in viewState

Sometime moxy generated viewState with wrong type for enums.
In my case:

I have a class Salary with inner Enum classes.
I have an interface of view SalaryBaseView inherited from BaseView

@StateStrategyType(OneExecutionStateStrategy::class)
interface SalaryBaseView: BaseView{
    fun showBottomDialog(salaryId: Long, type: Salary.Type, items: List<SalaryReferenceMethod>)

    fun openInputEmailDialog(id: String)
}

From SalaryBaseView inherited SalaryPaymentDetailView

@StateStrategyType(AddToEndSingleStrategy::class)
interface SalaryPaymentDetailView : SalaryBaseView {

    fun initListeners()

    fun setTitleToolbar(name: String)
....e.t.c.

SalaryPaymentDetailView doesn't use Salary in functions.
Problem appears in generated viewState SalaryPaymentDetailView$$State, Salary.Type replaced on Salary$Type in compile time.
Trace of error:
....\presentation\view\SalaryPaymentDetailView$$State.java:11: error: cannot find symbol
import ....\model.Salary$Type;
^
symbol:   class Salary$Type
location: package ...\presentation\view\SalaryPaymentDetailView$$State.java:289: error: cannot find symbol
public void showBottomDialog(long arg0, Salary$Type arg1,
^
symbol:   class Salary$Type
location: class SalaryPaymentDetailView$$State...\presentation\view\SalaryPaymentDetailView$$State.java:698: error: cannot find symbol
public final Salary$Type arg1;
^
symbol:   class Salary$Type
location: class SalaryPaymentDetailView$$State.ShowBottomDialogCommand...\presentation\view\SalaryPaymentDetailView$$State.java:702: error: cannot find symbol
ShowBottomDialogCommand(long arg0, Salary$Type arg1, List<? extends SalaryReferenceMethod> arg2) {
^
symbol:   class Salary$Type
location: class SalaryPaymentDetailView$$State.ShowBottomDialogCommand...\presentation\view\SalaryCardDetailView$$State.java:10: error: cannot find symbol
Same error was in 2.0.2 and 2.1.2

This is definitely a cool bug, will fix that in the next version, thanks for reporting!

The same behaviour appears when we use kotlin nested classes (not only enums)
For example, we have such method in a view: fun drawPolygonGeoZone(zone: GeoZone.Polygon)
The dot sometimes is replaced with "$": drawPolygonGeoZone(GeoZone$Polygon arg0) in the generated viewState


Undefined behaviour while quitting with custom export template

Godot version:
3.1.1 stable
OS/device including version:
Windows 10 (1803)
Issue description:
When quitting via SceneTree.quit() or pressing the X button to close with a custom export template made with the command below the application seems to crash
Steps to reproduce:
Compile the 3.1 branch with the following command:

scons C=gcc CXX=g++ platform=windows tools=no disable_3d=yes disable_advanced_gui=yes module_bmp_enabled=no module_bullet_enabled=no module_csg_enabled=no module_dds_enabled=no module_enet_enabled=no module_etc_enabled=no module_gdnative_enabled=no module_gridmap_enabled=no module_hdr_enabled=no module_mbedtls_enabled=no module_mobile_vr_enabled=no module_opus_enabled=no module_pvr_enabled=no module_recast_enabled=no module_regex_enabled=no module_squish_enabled=no module_tga_enabled=no module_thekla_unwrap_enabled=no module_tinyexr_enabled=no module_webm_enabled=no module_websocket_enabled=no target=release debug_symbols=no bits=64 use_mingw=yes use_lto=yes
and
strip bin/godot.windows.opt.64.exe
Then copy the executable and replace the %USERPROFILE%\AppData\Roaming\Godot\templates\3.1.1.stable\windows_64_release.exe by this new one (also remember to change the executable's name)
Then create an empty project and export it with Export with Debug unchecked.
Open the game and close it
Minimal reproduction project:
Any project

EDIT: I recompiled removing all "disable" s and the game closed correctly.
scons C=gcc CXX=g++ platform=windows tools=no target=release debug_symbols=no bits=64 use_mingw=yes use_lto=yes

You can't mix different versions like that.
The current 3.1 branch is not the 3.1.1 release, it has many more commits for what will become the 3.1.2 release eventually.
If you want to use a custom built template from the 3.1 branch, you should also use a custom built editor from the same commit. Or you can compile the 3.1.1-stable tag instead.

@akien-mga Omg sorry I didn't notice that :/
But I repeated the same steps following your suggestion and it keeps crashing when quitting :/

@akien-mga It's something related to disable_3d=yes, this flag is causing the crash... I tested without it and the game closed correctly.
I'll see if I can fix it


Implement PartialEq + Eq for channel

As the title says, would it possible/acceptable to implement PartialEq and Eq for the channel types?
I'm wrapping a Sender in another type which I would like to implement Eq for. If approved I'll take a look at implementing it.

To me to most logical would be if two Senders send to the same Receiver they should compare equal. For Receiver they are equal when the receive from the same queue.
In my use case I just want to know if two channels send to the same receiver. Alternatively this could be implemented as a method, something like send_to_same_receiver(&self, other: &Self) -> bool.

I'm use channels to back communication between actors, using the actor model. And I would like to know whether or not I'm communication to the same actor given two (or more) channels.

This sounds reasonable to me. In fact, previous versions of crossbeam-channel allowed comparisons between senders and receivers (even s == r), but then I removed comparisons in 0.3 with a conservative intention of adding them later in a possibly different form: https://docs.rs/crossbeam-channel/0.2.6/crossbeam_channel/struct.Sender.html
Golang allows comparing senders to senders and receivers to receivers, but cannot compare a sender to a receiver. I think we should follow suit and just add impls for sender-sender and receiver-receiver comparison.

@stjepang Ok I'll try to send a pr today.

I'm implemented it for all channels but the never flavour. It is implemented as
pub struct Channel<T> {
    _marker: PhantomData<T>,
}

So there is not a lot to compare... Want to make this a special case that always returns false?

So there is not a lot to compare... Want to make this a special case that always returns false?

Well, I suppose the following should work:
let r = never::<T>();
assert_eq!(r, r);

So by that logic, perhaps we should always return true?

@stjepang but then assert_eq!(never::<T>(), never::<T>()); is also true, which seems odd.

@Thomasdezeeuw
How do you feel about implementing only PartialEq? If I can draw a parallel to floating point numbers, then never channels are sort of like NaN values and really should return false when compared to themselves?

I'm ok with only implementing PartialEq. Should never channels then always return false, to match NAN?

use std::f64::NAN;

fn main() {
    assert_eq!(0.0, 0.0);
    assert_ne!(0.0, NAN);
    assert_eq!(NAN, NAN); // fails.
}

(playground)

Yeah, that seems reasonable to me, although I'm not 100% sure so having another pair of eyes to look at this would be good. @BurntSushi Any thoughts on this?

Personally, I still don't really understand why someone would want to compare channels, and I feel like I didn't really get a complete answer to that question.
Putting that aside, I'm not sure I understand why we can't make never channels comparable in the same way that non-never channels are comparable. I see above that the internal implementation is just a PhantomData, so that they may not be comparable in their current form, but what stops us from changing them so that they are comparable?
For example, I'd expect the following to pass:
let recv1 = never::<()>();
let recv2 = never::<()>();

assert_ne!(recv1, recv2);
assert_eq!(recv1, recv1.clone());

But the latter will not pass if "never" channels are given NaN semantics. In general, NaN represents a significant complication in the practical use of floating point numbers, so if we can avoid introducing NaN-like concepts elsewhere, then I think we should.

@BurntSushi I agree that NaN semantics for comparing are complicated and I would like to avoid them as well. But how do you propose to change the never channel to make them comparable?

@Thomasdezeeuw
I suppose we could add a field to the never channel that distinguishes different instances:
pub struct Channel<T> {
    inner: AtomicCell<Option<Box<u8>>>,
    _marker: PhantomData<T>,
}

The inner field gets lazily initialized to Some(Box::new(0u8)) on comparison. The address of the allocated byte can be used to compare channels.

@stjepang allocating seems a high price to pay to me, but I don't see many better solutions. The only other thing I can think of is having a static counter to get unique ids for each never channel. But I don't have any benchmark numbers of allocating 1 byte vs increasing a shared, global counter.

Never channels are only used to arbitrarily disable cases in select! so I doubt anyone is ever going to compare them. :)

@stjepang Ok then I'll use your approach.

@stjepang I've encountered a couple of problems with the design. Because the inner part is lazily set we need to set it when cloning. But since Option<Box<u8>> is not Copy we can't get the actual pointer from AtomicCell.
So instead I tried it with an AtomicUsize and a global counter, that is lazily set on clone (and only on clone). I think this can be done with AtomicPtr as well but that would get complicated with de-allocation.

Is there a practical problem with making all never() channels always compare true?
Intuitively one can imagine that there is only one "never channel" allocated somewhere behind the scenes, which never() merely returns a reference to.

@glaebhoerl I agree, that was my first reaction to this problem too.
@Thomasdezeeuw, let's just return true when comparing never() channels? Do you find @glaebhoerl's argument convincing?

@stjepang I'm fine with always returning true, @BurntSushi are you ok with that to?

Without looking at concrete use cases (of which I've still seen none in any convincing detail for implementing PartialEq at all in the first place, and this request for more detail appears to continue to be ignored, but I'm not sure why), it's pretty hard to say. It certainly seems viable to say "all never channels are regarded as equivalent," but I could just as easily see someone being surprised by that in the future.

@BurntSushi I've given my use case, I don't know how much more detail you want from that. Is fairly simple, there is one producer and multiple consumers can register themselves with the producer and I want to keep the list of consumers unique, thus I need to be able to compare channels (well senders).
I've made a note about comparing two never channels in the documentation of the never function, hopefully this prevents surprises but I do agree with your point.

Is fairly simple, there is one producer and multiple consumers can register themselves with the producer and I want to keep the list of consumers unique, thus I need to be able to compare channels (well senders).

Sure, but I don't see why that requires channel equality. It just seems weird to me to ascribe equality semantics to channels like this. For example, in your original comment, you said:

I'm wrapping a Sender in another type which I would like to implement Eq for. If approved I'll take a look at implementing it.

But I don't think you need a channel to implement Eq for this. You can implement your own equality semantics with much the same way that channels would do it themselves internally.

In my use case I just want to know if two channels send to the same receiver. Alternatively this could be implemented as a method, something like send_to_same_receiver(&self, other: &Self) -> bool.

I guess I would prefer this route instead of implementing Eq.
With all that said, reflecting on this, I don't think I feel that strongly. It just feels weird.

It's hard to intuit why another might find something weird when oneself does not, but let me try to reflect on why I don't find it weird -- equality for shared mutable objects in many languages is defined as address-equality: objects in general in Java/C#, refs in ML, IORefs in Haskell, std::shared_ptr. (I wish I could cite Rust itself here! Niko has mentioned that he believes Eq for Cell being defined as contents-equality was a mistake, and I agree.)
Channels are but a slightly more sophisticated form of shared mutable object, so extending it to them only feels a short distance away. In general, for types which "have identity", the natural Eq impl is the one which tests if they are "the same one". (Incidentally, Haskell's Chan type also has this; I haven't checked other languages.) Maybe the thing which throws one for a loop here is the Sender/Receiver split, so that the identity being compared is actually that of the internal queue, which is hidden?

@glaebhoerl Thanks for that perspective. I think that might assuage my feeling a bit. I think I actually find address-equality itself to be strange, where contents-equality makes a lot more sense to me. (For example, I'm having trouble understanding the perspective that Eq on Cell shouldn't be defined as contents-equality.) So in that respect, it makes sense why I'm finding Eq on channels to be weird.
This also reminds me of what my initial reaction to this issue was: I would have thought equality between two channels to mean something like, "at that specific moment in time, the internal queue of both channels contain the same elements." That's why my first question was asking what "equality" on channels actually means. In retrospect, address-equality makes a lot more sense, but you don't actually see a lot of that in Rust (and I've been under the impression that that's a good thing), which is maybe why it feels so weird to me.

I think the intuition there is that == should always be a "pure function" -- it shouldn't ever touch shared mutable state. (An address is just a value, and == on it will always give the same result; the contents at that address are s.m.s., and then == will give different results depending on when you ask.) A truly egregious example of this being violated is Java's URL.equals() actually doing a DNS lookup to determine if the hosts resolve to the same IP address! Now that one's obviously and flagrantly "Wrong", but it's a similar flavor of wrong, just more extreme. In Haskell the type of == prevents it from accessing shared mutable state ("IO"), so address-equality is the only possible choice.

but you don't actually see a lot of that in Rust (and I've been under the impression that that's a good thing)

It generally is; using address-equality to distinguish normal data that isn't shared-mutable is also a flavor of wrong, and Rust does well to avoid it (though it could've been stronger about it by making cast-to-raw-ptr unsafe).
(I'm trying to explain it other than by pointing to, "Haskell does it this way, therefore it is right", and feel like I'm mostly failing. Oh well, better than nothing hopefully...)

@glaebhoerl Thanks for the explanation. It definitely helps. I'll keep noodling on it.
In any case, for this particular issue, I don't strongly object to the current course. (Implementing Eq using address equality and considering all never channels equivalent.)

Another possibility is to do something similar to ThreadId:
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct ChannelId(usize);

impl<T> Receiver<T> {
    pub fn id(&self) -> ChannelId;
}

impl<T> Sender<T> {
    pub fn id(&self) -> ChannelId;
}

The ID would internally be just a usize, a unique identifier for the channel of this particular type. All heap-allocated channels would be identified by the pointer address, while the "never" channels would be identified by 0.

@BurntSushi, @glaebhoerl Thanks for the discussion, I now understand both points of view.
I think we have three possible APIs:

PartialEq,
special method, and
ChannelId

// PartialEq, Eq.
sender1 == sender2;

// Special method, modelled after `LocalWaker::will_wake`.
sender1.will_send_to(&sender2);
sender1.same_channel(&sender2);
// Or an alternative method name.

// ChannelId, modelled after `ThreadId`.
sender1.id() == sender2.id();
// Bonus of `ChannelId` is that we can compare senders with receivers (I think).
sender1.id() == receiver2.id();

@stjepang Do you have any ideas for future API for ChannelId?
Also have you thought about the lifetime of ChanneldId? Since the inner usize comes from a pointer, the pointer can be reused resulting in false positives.

@Thomasdezeeuw Thanks for the overview of all the options!

Do you have any ideas for future API for ChannelId?

I don't have in mind anything beside what was sketched out in my last comment - that's pretty much it.

Also have you thought about the lifetime of ChanneldId? Since the inner usize comes from a pointer, the pointer can be reused resulting in false positives.

Well, just like with ThreadId, the identifier is something that is valid only while the channel is alive. The moment the channel is destroyed, the ID becomes meaningless and might indeed produce false positives.
You're making a fair point, but we shouldn't fret over the issue, I think. If IDs work well for threads, they should work for channels too...

So I think there are three questions left to answer:

What is the best API to "determine whether two senders send to the same receiver"?
Same as above but then for receivers.
Should the API support determining if a sender is sending to a receiver?

Any thoughts?

Also have you thought about the lifetime of ChanneldId? Since the inner usize comes from a pointer, the pointer can be reused resulting in false positives.

Well, just like with ThreadId, the identifier is something that is valid only while the channel is alive. The moment the channel is destroyed, the ID becomes meaningless and might indeed produce false positives.
You're making a fair point, but we shouldn't fret over the issue, I think. If IDs work well for threads, they should work for channels too...

@stjepang  I don't know too much about the "uniqueness" of ThreadId, however memory address can easily be reused. I don't want to following code to fail, but in a single threaded application it could with an allocator that reuses memory addresses.
let (s, _) = unbounded();
let id1 = s.id();
drop(s);
let (s, _) = unbounded();
let id2 = s.id();
asser_ne!(id1, id2);

@BurntSushi, @glaebhoerl, @stjepang it's been two weeks, any preferences in the API possibilities I proposed in https://github.com/crossbeam-rs/crossbeam/issues/319#issuecomment-462388472?

I think I personally like the explicit method, e.g., same_channel. The intended semantics are IMO clearer. But I honestly don't have a super strong preference here. I think @glaebhoerl somewhat assuaged me of my concerns here.

I like the same_channel idea too. If I may draw another parallel, it also reminds me of Arc::ptr_eq.
Not 100% sure if I'm sold on the same_channel name yet, but we can throw a few ideas around and pick one. Here are some more: same_sender, sender_eq, eq_sender, channel_eq.

Some ideas
sender1.sends_to(&sender2);

// Special method, modelled after `LocalWaker::will_wake`.
sender1.will_send_to(&sender2);
sender1.same_channel(&sender2);
// Or an alternative method name.

(Ignore my previous, now deleted comment.)
Some ideas.
sender1.same_sender(&sender2);
sender1.same_receiver(&sender2);
sender1.same_channel(&sender2);
sender1.same_target(&sender2);
sender1.sender_eq(&sender2);
sender1.eq_sender(&sender2);
sender1.channel_eq(&sender2);

And for senders and receiver, if we want that.
sender.sends_to(&receiver);
sender.will_send_to(&receiver);

I think my preference goes to sender1.same_receiver(&sender2).

I've updates #320 to use same_channel.

Thanks everybody for the reviews and discussions.

@BurntSushi There is a long and somewhat dense article (from 1993!) that goes into a lot of detail about this (and gives many examples of why their equality is correct):
http://home.pipeline.com/~hbaker1/ObjectIdentity.html
It lists these three requirements for equality:

objects retain their identity throughout their lifetime--identity is constant and immutable;
object identity is preserved by the basic value-transmission operations of the programming language--binding, argument-passing, value-returning, and assignment;
objects with the same identity are operationally equivalent.

Basically, if two objects are equal, they should remain equal. And moving objects around (e.g. putting them into data structures) shouldn't change their equality.
That's really important in practice!
For example, BTreeMap has a requirement that sorting is stable. If you violate that, then your impl of Ord is wrong.
Similarly, HashMap has a requirement that Eq and Hash are pure:

It is a logic error for a key to be modified in such a way that the key's hash, as determined by the Hash trait, or its equality, as determined by the Eq trait, changes while it is in the map. This is normally only possible through Cell, RefCell, global state, I/O, or unsafe code.

Note that it specifically calls out Cell and RefCell, because their equality isn't pure!
If Cell and RefCell compared equality by reference, then they would work perfectly fine with HashMap. But because they compare by value, now they can break if you use them as a key in a HashMap.
So the basic principle is: immutable things should always compare by value. Mutable things should always compare by reference.
This guarantees that equality is well behaved under every circumstance (including when using HashMap/BTreeMap, but also in other situations too).
Some languages (like Haskell) do that correctly. Most languages (including Rust) get it wrong, so they end up with equality bugs (like using Cell in a HashMap).

Some languages (like Haskell) do that correctly. Most languages (including Rust) get it wrong, so they end up with equality bugs (like using Cell in a HashMap).

Happy to be wrong if it means this program always prints true:
fn main() {
    let x = "foo".to_string();
    let y = "foo".to_string();
    println!("{:?}", x == y);
}

Some languages (like Haskell) do that correctly. Most languages (including Rust) get it wrong, so they end up with equality bugs (like using Cell in a HashMap).

Happy to be wrong if it means this program always prints true:
fn main() {
    let x = "foo".to_string();
    let y = "foo".to_string();
    println!("{:?}", x == y);
}


Nodeinfo tests?

Should we test that as well? If so, what needs testing?

It should probably be tested if it's supported by an implementation. The primary use case is for aggregating instance statistics and high-level metadata (for fediverse crawlers). It's not required for federation per se and a nontrivial number of instances do not support it.
Possible tests:

Correct content-type for the JRD and the version-specific nodeinfo data.
Validate nodeinfo response per the version-specific nodeinfo JSON Schema
Check that a server can handle non-nodeinfo links in the nodeinfo JRD (e.g., "application actor" links).

My guess is that a majority of instances will fail one or more of these tests. Possible failure cases:

Uses application/json for JRD
Adds values for properties like protocol that are not valid per the schemas
Assumes nodeinfo JRD only contains nodeinfo links.


Total Cache removes roles from $current_user

User bhamrick from the W3TC support forum on wordpress.org reported the following bug:

I’m trying to use the plugin Woocommerce CSV importer which enforces permissions by relying on the roles array on the $current_user object, as many other plugins do. W3 Total Cache is removing my ‘administrator’ role so $current_user->roles becomes an empty array. There are no actual DB changes, it just changes the value at runtime.
This looks to be an old bug, there’s a thread about the same issue from a year ago:
https://wordpress.org/support/topic/bug-w3tc-breaks-plugins-that-need-the-current-users-role/

I looked into it, and seems the bug has been there for more than a year.
The problem is with accessing the global variable $current_user and changing its fields when using array_shift.
A simple fix would be to replace array_shift() with reset() as mentioned in the linked thread above.
Taking it a step further, perhaps we should stop using the global variables altogether and get the $current_user by using:
$current_user = wp_get_current_user();

Is there any argument for using the global variable instead of calling the function? Maybe an overhead cost in execution time?

@charlesLF thanks for your time!
i think the best option change:
global $current_user;

with:
$current_user = wp_get_current_user();

everywhere...

I agree.
I will prepare a pull request with the required changes.

Hi guys!  I always forget to check this "Issues" area ;P
Great idea to use wp_get_current_user() since i get a sense the wp dev crew will eventually want all plugin/themes to use it and not its global equivalent.
Curious, @charlesLF  my coding knowledge is likely still rusty but if i am not mistaken by using:
$current_user = wp_get_current_user();
The returned object will still directly reference back to the global class object and so its roles array member variable  will still get changed (globally) by array_shift().  Correct me if i'm wrong.
So, if i'm right then the change might still need a slight tweak.  More specifically, the existing line:
$role = array_shift( $current_user->roles );
would need to be changed to something like:
$role = array_values( $current_user->roles )[0];
in the following files:
Line 936: lib/W3/Plugin/Cdn.php
Line 114: lib/W3/Plugin/NewRelic.php
Line 750: lib/W3/Plugin/TotalCache.php
I decided not to use php's reset() because if other plugins/themes were to make use of the array pointer via functions like next() or prev() then an unexpected reset() by w3tc could possibly disturb there expectations.
Again, i could be wrong about needing this tweak so i wanted to discuss it here first. :)

Have you time to made a PR?

Yup..happy to do it.  I will also do the same for the others.


Changing the TTS voice

I have 'Ryan Neural' set as my assistant voice but the TTS speech comes out as a female American (not that there's anything wrong with that).
How is the TTS voice set to be the same as the assistant voice?

Has nothing to do with the onju at all, but i do know the answer. Are you using tts.speak like this?
'''yaml
service: tts.speak
data:
media_player_entity_id: media_player.bedroom_speaker
message: "Testing 123"
target:
entity_id: tts.piper
'''
It'll use the voice configured in the piper add-on settings.


Develop upstream sync 231030

Unit test failures
https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/6261
https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/6260
https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/6264

retest Ubuntu-CPU please!

reset Ubuntu-CPU please!

retest Ubuntu-CPU please


NIFI-2675 fixed NPE in template generation

Reviewing...

The fix looks like it solves the issue. I imported the webcrawler.xml template from NiFi templates and configured the controller services, then exported the template successfully. Without further instructions on how to reproduce the NullPointerException, I believe this is fixed.

@andrewmlim and I verified this and it is fixed. +1. Will merge.


Replace uuid variable that was empty with one with the actual UUID

Description
The benchmark_uuid was not in use anywhere and never set by the test so when it would go to compare the uuid of the running test would be empty. Replaced this with the UUID set for the run.
Fixes

closing since this fix is outdated , we no longer use the compare_uperf_uuid var or the assign uuid function.


Add a way to collect logs from kestrel running inside IISExpress

It should make debugging functional tests easier
@pranavkm @davidfowl @Tratcher

Representative failure:
http://aspnetci/viewLog.html?buildId=275192&tab=buildResultsDiv&buildTypeId=XPlat_Windows_Win7_Universe


Test Notification when only 1 approval

Test Notification when only 1 approval

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.001 ETH (3.79 USD @ $3793.7/ETH)  attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin's Discord
$0 more funded OSS Work available on the Gitcoin Issue Explorer

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.
These users each claimed they can complete the work by 264 years, 11 months from now.
Please review their action plans below:
1) nutrina-test has applied to start work (Funders only: approve worker | reject worker).
The quick brown fox jumps very high
Learn more on the Gitcoin Issue Details page.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.001 ETH   attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin's Discord
$0 more funded OSS Work available on the Gitcoin Issue Explorer


OgmiosEpochService getProtocolParams does not return some params

Not sure if it's an issue,
But
        var ogmiosProtoParams = ogmiosEpochService.getProtocolParameters().getValue();```

Does not return all params, eg

`minFeeRefScriptCostPerByte=null`

This causes tx balancing to fail.

Thanks @nemo83. This is a bug. The minFeeRefScriptCostPerByte is currently missing in the Ogmios backend service implementation, as well as in Koios.
So, the reference script fee will only work with the Blockfrost backend in version 0.6.0-beta1.
Workaround for now:
You can manually set minFeeRefScriptCostPerByte=15 after retrieving the protocol parameters from the backend provider.
We will fix this in the next release.

Thanks for confirming this. Let me know if you need any help in getting this done. I just wanted to be sure it was an actual issue (and not me mis-using the library)

I will fix this as part of the following PR as there is also a dependency with cost model
https://github.com/bloxbean/cardano-client-lib/pull/418

I will fix this as part of the following PR as there is also a dependency with cost model
#418

oh interesting, I thought there were issues w/ costs models too, but could not pin point to it. happy to hear you're on top of things! and thanks for fixing ogmios too.


Make more helper functions to navigate the component tree

So while there are functions to navigate one level of component tree, there should be also functions which navigate multiple levels, do it recursively. Imagine a jQuery selectors for selecting ancestor or descendant components.
The issue is that often you would want to find the first component matching some condition, not all of them. So it might be good to provide this as an iterator?
We should also document this and explain proposed use (finding by matching on some property and not number of levels, accessing components' state/public API). Explain that moving across data contexts is fragile and that better is to move between components and then call .data() on them (or any other state, reactive field).

So maybe static methods could be passed down to children automatically, and with them being aware of their parents, they could just invoke parent to whom method belongs with it's state.

If you're going after what react.js is doing.


flutter run doesn't handle failure on the device during file upload

Exception from flutter run: HttpException: Connection closed before full header was received, uri = http://<IP_ADDRESS>:8100
dart:io                                          _HttpClient.putUrl
package:flutter_tools/src/devfs.dart 225         _DevFSHttpWriter._scheduleWrite.<async>
===== asynchronous gap ===========================
dart:async                                       Future.Future.microtask
package:flutter_tools/src/devfs.dart             _DevFSHttpWriter._scheduleWrite
package:flutter_tools/src/devfs.dart 218         _DevFSHttpWriter._scheduleWrites
package:flutter_tools/src/devfs.dart 206         _DevFSHttpWriter.write.<async>
===== asynchronous gap ===========================
dart:async                                       Future.Future.microtask
package:flutter_tools/src/devfs.dart             _DevFSHttpWriter.write
package:flutter_tools/src/devfs.dart 387         DevFS.update.<async>
dart:async                                       _SyncCompleter.complete
package:flutter_tools/src/devfs.dart 540         DevFS._scanDirectory.<async>
===== asynchronous gap ===========================
dart:async                                       _asyncThenWrapperHelper
package:flutter_tools/src/devfs.dart             DevFS.update
package:flutter_tools/src/hot.dart 357           HotRunner._updateDevFS.<async>
===== asynchronous gap ===========================
dart:async                                       Future.Future.microtask
package:flutter_tools/src/hot.dart               HotRunner._updateDevFS
package:flutter_tools/src/hot.dart 290           HotRunner._run.<async>
dart:async                                       _SyncCompleter.complete
package:flutter_tools/src/hot.dart 412           HotRunner._launchFromDevFS.<async>
dart:async                                       _SyncCompleter.complete
package:flutter_tools/src/vmservice.dart 937     FlutterView.runFromSource.<async>
===== asynchronous gap ===========================
dart:async                                       _asyncThenWrapperHelper
package:flutter_tools/src/hot.dart               HotRunner._run
package:flutter_tools/src/hot.dart 150           HotRunner.run.<fn>
package:stack_trace                              Chain.capture
package:flutter_tools/src/hot.dart 149           HotRunner.run
package:flutter_tools/src/commands/run.dart 221  RunCommand.runCommand.<async>

cc @johnmccutchan

This was fixed before I left for Munich. But reverted by @tvolkert due to an unrelated iOS breakage. @tvolkert can I reland my fixes?

The fix has already been re-applied in #6472

Excellent. Thanks!


minphony false positives

Please don't enforce a PHONY declaration for tasks that are not declared in our Makefiles.
That is, if clean isn't even implemented, then it should not be marked PHONY. Same goes for test and all.
One could argue that all, test, and clean are idiomatic tasks that every Makefile should implement. While I personally useful default tasks, TDD, and practical cleanup tasks, even so, I think that would be an overbearing rule to inflict on users.
Hmm, looks like the minphony rule can't even be disabled by checkmake.ini? It is to cry.

Falls under the title, but different from OP: I do have a required target and minphony is telling me that I do not.
Knowing nothing about how the parser works, the only thing I can think of that could be confusing it is that the phony target has a real target for a prerequisite.
.PHONY : reqs container_rebuild container_update test test-now print
# ...
test : tests/.last_test
tests/.last_test : $(PY_SRC_FILES)
    cd tests; poetry run pytest . && touch .last_test

checkmake Makefile
    RULE              DESCRIPTION             FILE NAME   LINE NUMBER

  minphony   Missing required phony target    Makefile    0
             "all"
  minphony   Missing required phony target    Makefile    0
             "clean"
  minphony   Missing required phony target    Makefile    0
             "test"

Plug:
https://github.com/mcandre/unmake

PR #88 was meant to close issue #86, but I think it would also at least somewhat address this one, as well.
See also issue #72 as well.


Replaced runtime with NPM modules

All runtime exports are now pointing to their NPM modules.
SkyAppTestModule cannot be moved to a UMD module due to how it is modified by Builder.

Codecov Report

Merging #456 into master will increase coverage by 0.67%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #456      +/-   ##
========================================
+ Coverage   99.32%   100%   +0.67%
========================================
  Files          73     52      -21
  Lines        1931   1609     -322
  Branches      305    236      -69
========================================
- Hits         1918   1609     -309
+ Misses         13      0      -13

Flag
Coverage Δ

#builder
100% <100%> (ø)
:arrow_up:

#runtime
100% <ø> (+4.39%)
:arrow_up:

#srcapp
100% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

config/webpack/alias-builder.js
100% <100%> (ø)
:arrow_up:

src/app/app.component.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9403b...2c91b8a. Read the comment docs.

Codecov Report

Merging #456 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #456      +/-   ##
========================================
+ Coverage   99.42%   100%   +0.57%
========================================
  Files          71     53      -18
  Lines        1924   1640     -284
  Branches      306    240      -66
========================================
- Hits         1913   1640     -273
+ Misses         11      0      -11

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
100% <ø> (+4.01%)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83efdd8...e12b9c7. Read the comment docs.

Codecov Report

Merging #456 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #456      +/-   ##
========================================
+ Coverage   99.42%   100%   +0.57%
========================================
  Files          71     53      -18
  Lines        1924   1640     -284
  Branches      306    240      -66
========================================
- Hits         1913   1640     -273
+ Misses         11      0      -11

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
100% <ø> (+4.01%)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83efdd8...e12b9c7. Read the comment docs.

@Blackbaud-BobbyEarl This is ready for a final look, when you have the time.


Clarify that we do not want patch context blobs

as requested in https://github.com/microsoft/vcpkg/pull/27514/files#r1013392020

I disagree with this proposal. When working with patches against libraries, it is more trivial for me to apply a set of patches to the library's repo and use format-patch to export the the patches again after I have fixed whatever problem there is. If a bare diff is used, an extra step is required to create commits for each and every single diff file. This will make maintaining ports, such as the python3 port, much more difficult for me. Adding such a barrier will make it more difficult for me to contribute to this project in my limited time.

#27558 shows how much git noise the extra headers adds on every update.

#27558 shows how much git noise the extra headers adds on every update.

Please note that the PR cited is currently a draft. I intend to back out the noisy patch changes before marking it ready for review.

It would be nice to describe how this can be achieved with minimum effort (based on git, diff or even post-processing diffs, e.g. downloaded from github).

then use format-patch to export the the patches again

git diff instead of git format-patch should do the right thing? Example:
PS C:\Dev\vcpkg> git format-patch HEAD~1 --stdout
From 4ae435b1c9e05f9ce1e254870cc520fcbddfd198 Mon Sep 17 00:00:00 2001
From: Billy O'Neal<EMAIL_ADDRESS>Date: Fri, 4 Nov 2022 11:42:27 -0700
Subject: [PATCH] wip

---
 ports/libtorch/vcpkg.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ports/libtorch/vcpkg.json b/ports/libtorch/vcpkg.json
index 6cba06c05..b3a547a2a 100644
--- a/ports/libtorch/vcpkg.json
+++ b/ports/libtorch/vcpkg.json
@@ -3,7 +3,7 @@
   "version-semver": "1.10.0",
   "description": "Tensors and Dynamic neural networks in Python with strong GPU acceleration",
   "homepage": "https://pytorch.org/",
-  "supports": "x64 & (osx | linux)",
+  "supports": "x64",
   "dependencies": [
     "cpuinfo",
     "eigen3",
--
2.38.1.windows.1

PS C:\Dev\vcpkg> git diff HEAD~1
diff --git a/ports/libtorch/vcpkg.json b/ports/libtorch/vcpkg.json
index 6cba06c05..b3a547a2a 100644
--- a/ports/libtorch/vcpkg.json
+++ b/ports/libtorch/vcpkg.json
@@ -3,7 +3,7 @@
   "version-semver": "1.10.0",
   "description": "Tensors and Dynamic neural networks in Python with strong GPU acceleration",
   "homepage": "https://pytorch.org/",
-  "supports": "x64 & (osx | linux)",
+  "supports": "x64",
   "dependencies": [
     "cpuinfo",
     "eigen3",
PS C:\Dev\vcpkg>

It would be nice to describe how this can be achieved with minimum effort (based on git, diff or even post-processing diffs, e.g. downloaded from github).

Just run git diff. For a patch downloaded from github I think you can just chop off up to and including the ---.

Just run git diff. For a patch downloaded from github I think you can just chop off up to and including the ---.

Worth documenting?

Worth documenting?

I mean, it's already
what https://github.com/microsoft/vcpkg/blob/master/docs/examples/patching.md says to do.

Worth documenting?

I mean, it's already what https://github.com/microsoft/vcpkg/blob/master/docs/examples/patching.md says to do.

True, but the doc there mentions this as an example to do this and the new policy doc here doesn't reference it as best practice, some hints to connect the dots could help.

@Hoikas. Can you not simply store your patches with headers somewhere else and just remove the headers when adding them to the vcpkg main repo?

That requires manually doing work on every single patch, which bring us back to my original complaint. I don't see a need for the extra work to handle each individual patch when there's a ready made format that applies everything in one step. I don't see a good reason why committing a patch header is impermissible if the unnecessary noise is not committed. That is to say, changes to the got version and line numbers are not committed. The proposal by @BillyONeal in this PR only seems to address one aspect of what I view of as the real problem: minimizing unnecessary changes to be reviewed. I intend to do that by ensuring my final PRs do not contain changes to the context lines, such as the line numbers and hashes.

We want to more thoroughly consider @Hoikas ' feedback. Closing this for now but it may come back.


output graphics as png (not only pdf)

As is the visualizations are all output as PDF files.  It would be helpful to have PNG files available also.

PDF graphics were chosen since they are not lossy (like png and other image formats).  Since it is good to be able to zoom in to see the individual points, pdf (or other vector graphics) are better.  PDFs are not particularly friendly for including inside other documents or presentations, so we might be able to find another vector graphic format.


Clear out rich text editor when text is manually removed in all forms when fields are not required

Clear out rich text editor when text is manually removed in all forms when fields are not required

Added conditional statements to clear out elements in rich text fields when fields do not contain user content.

complete

issue resolved


Custom metrics

Allow to monitor custom configured metrics, eg:

gzip bundle size for one or multiple files

This would be a great addition, can we somehow help? 🤔


updating the reset_database() method to work in Postgres

We need to update the reset_database() method to work in postgres and we also need to have the option to call the method at the beginning and at the end of the code
Benefit: This will give us a way to clear the psql database after running HoloClean many times
Cost: 4 hours

Done with PR #219


Drop grpc 3.7 testing version

Overview

Older version of grpc for Python 3.7 testing is conflicting with latest grpc versions when installed, so drop it in favor of just testing supported versions of Python on the latest grpc version.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.30%. Comparing base (7d6da2c) to head (cab276d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   81.34%   81.30%   -0.05%
==========================================
  Files         198      198
  Lines       21682    21682
  Branches     3431     3431
==========================================
- Hits        17638    17629       -9
- Misses       2917     2920       +3
- Partials     1127     1133       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] the same Incremental card keeps reappearing each time the queue instead of the others IE cards, when skipping the card with right arrow

Hello,
Despite having multiple rems tagged with IE, in the Queue if I skip cards with the right arrow keystorke, it's the same incremental card that keeps coming back every time.
(This particular card has a priority of 10, similar to most of the other incremental REMs.)
I expected that the incremental REMs would follow one after the other when skipped with the right arrow. Isn’t that how it’s supposed to work?
Is there anything I can try to solve this? If not is there another way to skip an incremental card without having this behavior?
I illustrated the problem in the video below:
PS: my Flashcard Ratio is 2.
https://github.com/user-attachments/assets/760a040d-8a4e-4b45-8758-56268551f5f7
Thanks a lot!

I think I’ve figured it out! The issue was that the randomness setting was at the minimum. Once I increased it, I was able to skip my incremental cards as usual.


Draft function for applications

I would like to see a feature that allows applications to be created as a draft before they are submitted to the supervisor. This way, you can also use the tool including the calendar function for vacation planning.
It should be possible to delete drafts completely. It might also make sense to have a setting that controls the visibility for colleagues (so that you can coordinate within the team when you are still planning vacations together).

Hey @LiaraAlis,
thanks for your feedback. It feels like this is a function very similar to https://github.com/urlaubsverwaltung/urlaubsverwaltung/issues/2029 or? Is it a duplicate of it?

@derTobsch I think it's exactly the same, just expressed differently. I haven't found this yet, so thanks for the tip. I think we can close this ticket here as a duplicate.


Beta FreeCodeCamp Challenges

I've been using the beta version of the new freecodecamp for a few days now and I am loving the updates. I think a good improvement would be to have the next challenge already loaded with the before results instead of having to click on the "Run test" before starting it.

@noone396 thanks for reporting. Closing in favor of older issue https://github.com/freeCodeCamp/freeCodeCamp/issues/12923


move from Selenium to Playwright?

This is annoying: https://github.com/PyBites-Open-Source/pybites-carbon/issues/5 and I wonder if this would not be an issue with Playwright ...

Can this use SeleniumBase instead? Driver download is automated/included

Sure thing, the "driver getting out of sync" is the main concern for me here. If you do decide to take this up, let's close this issue and work on #5 - thanks!

Thanks @amandanelson! Your PR https://github.com/PyBites-Open-Source/pybites-carbon/pull/13 fixes this too, no need to go with Playwright for now.

Ran into the mismatch chrome browser and driver versions the other day, let's move Playwright, it seems more robust ...


Add new firebase token

Fix for:
⚠  Your CLI authentication needs to be updated to take advantage of new features.
⚠  Please run firebase login --reauth
Error: An unexpected error has occurred.

Coverage remained the same at 41.601% when pulling bed4c24fc10975d1def1211087dccc51da644415 on bjornreppen:firebase-token into e6c2cb013531df1eab3f3a5497f7c9b29e776b8b on Artsdatabanken:master.


deployment update improved code quality

for QA
this improvements provides no behaviour changes, so you need to check that cli command uffizzi preview update deployment-DEPLOYMENT_ID PATH_TO_COMPOSE_FILE works as it worked before


Glowing-home-page

Glowing Effect
#134
What does this pull request do?

This pull request enhances the user experience of your website

What is the relevant issue link:

Improves the simplicity of the website

Screenshot if applicable

Any additional information?

If want to improve or add any feature on your website then comment me

Thanks
@Arshdeep-13

Hi @Evavic44
I have added the issue as you told me. So, please refer to it.
Thanks for your time


Does it allow to disable virtual memory?

The generated kernel prints virtual_addr, does it allow to disable virtual memory? Because implicitly adding these features makes a kernel not so lightweight.

Is it the QEMU Seabios output? Perhaps, I mistook the output as from this bootloader.

Blog os is written for 64bit x86 (x86_64), which does not allow disabling paging. Only 16bit and 32bit x86 allow disabling it. If you try entering long mode with paging disabled you will get a #GP fault (general protection fault).


Update utilities.py

Changed the output of the send_help function to be easier to understand.

Thanks. @SillySam


Vue3 Workload create page is showing form validation errors prematurely

Describe the bug
The initial workload creation screen, where users select which type of workload they want to create, appears to be running form validation and showing the user errors about inputs which are not yet visible. When the errors are clicked, instead of going away, more appear.
To Reproduce

Navigate to the cluster explorer (local or downstream doesn't matter)
Select 'workloads' from the navigation, and hit 'create'

Result

The workload type selection screen shows form validation errors, which cannot be cleared

Expected Result

No form validation until the actual form loads.

Screenshots
https://github.com/user-attachments/assets/ba4c1ab0-611e-4663-8f03-001b3c5c5b0e

Same issue in Service page

E2E coverage looks good. PO follow guidelines. Closing


Importing anchor Succeeds with 0 anchors

Overview
在MixedRealityToolkit-unity的sharing模块中，通过以下代码在Hololens客户端上传Anchor
WorldAnchorTransferBatch watb = new WorldAnchorTransferBatch();
Debug.Log("exporting " + exportingAnchorName);
watb.AddWorldAnchor(exportingAnchorName, worldAnchor);
WorldAnchorTransferBatch.ExportAsync(watb, WriteBuffer, ExportComplete);
其中：
private void WriteBuffer(byte[] data)
{
exportingAnchorBytes.AddRange(data);
//private List exportingAnchorBytes = new List();
}
在另一个Hololens的客户端：
通过WorldAnchorTransferBatch.ImportAsync(anchorData, ImportComplete);导入Anchor
Expected Behavior
Actual Behavior
使用WorldAnchorTransferBatch.ImportAsync导入worldAnchor时，SerializationCompletionReason为succeeded,但是WorldAnchorTransferBatch实例GetAllIds得到的数组长度为0，怎么回事？如何解决？
Steps to reproduce
(Links to sample github project preferred)
Unity Editor Version
unity2017.2.0f3
Mixed Reality Toolkit Release Version
MixedRealityToolkit-Unity-1.Dev.2017.2.0

I've seen this issue many times, and I don't think it's an problem particular to the MRTK, What we've ended up doing is looking for this result and treating it as an error, just as if the CompletionReason was a negative result. Additionally, when importing anchors we also setup some timers to trigger an error if the anchor hasn't located within some interval. This is an important part of the process since importing the anchor is just one step. Locating the anchor and placing the hologram is another.
On the anchor export side I do something similar: if the exported anchor is less than 1MB I assume the spatial map is incomplete and the user needs to update the map or reposition the hologram.

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Out-of-the-box support for running tasks in parallel

Might be tricky to visualize with listr.

How about bundling a parallel task runner like npm-run-all?

Hey @uetchy. Thanks for your feedback.
Yes, I think you could just use npm-run-all right now, but it wouldn't visualize properly which tasks are run.
The problems are right now:

How to make it work with underlying Listr package which only supports running things serially
What should the syntax look like for JSON task files. Two ways possible I can come up with:

Special built-in command: run-p task1 task2
Object with magic keys (kind-of ugly I think): `{ $parallel: ['task1', 'task2'] }

Feedback is always welcome :)

This seems like good news: SamVerschueren/listr#18!


jdk 8,the permanent generation has been deprecated

in jdk 8,the permanent space has been deprecated,so suggest correct it with MetaspaceSize,how about that ,buddy?

:white_check_mark: Build finished in 4m 34s
Build command:
mvn clean verify -B -e -Daudit -amd -pl assemblies/static

:exclamation: No tests found!
:information_source:  This is an automatic message

Fixed under BISERVER-12852 (that handled several other files).


Client-Side Library Implementation

Finished my first pass.  Exciting!

Update on the progress: I've written the code to use NewConnectionWithTransport, but now I'm having weird flaky tests. Among the five tests, only the first three passes. But if I disable the first three, the last two would also pass sometimes (but not always). I'm still investigating this - I believe it might be some connection settings issue.

https://github.com/keybase/search/tree/bugfix
I'm now officially stuck.
I now only enable part of the TestDeleteFile test, and everything works fine. But once I uncomment lines 180-192 in client_test.go, the test becomes flaky, as sometimes the CreateClient would return an error
--- FAIL: TestDeleteFile (0.03s)
	client_test.go:81: error when creating the client: dial tcp <IP_ADDRESS>:8022: connect: cannot assign requested address

Originally I thought I got this error because of too many connections, but in this case I'm only opening one single connection. Also, that part is not even in the commented-out code... I'm utterly confused. I think it's highly possible that I'm missing something obvious here. I should probably save time by dealing with this bug later until you have time to take a quick look.

@jxguan: I thought you weren't going to use any TCP connections during the client-side tests?  What happened to implementing a simple test server that implements the search server interface?
Anyway, you're probably hitting something like this, where the previous TCP connection to the server is still in TIME_WAIT: https://stackoverflow.com/questions/26019164/too-many-time-wait-connections-getting-cannot-assign-requested-address, probably because the client is shutting down the TCP connection.  It's probably not easy to have the server shut down the connection, so I'd say you should get rid of the need for a TCP connection altogether.

I see. Yeah I've written the fake test server and use that in all the tests. But that seems unable to test the CreateClient function. So I was using the old tests to check that my implementation using NewConnectionWithTransport would work. So is there any proper way to test the updated CreateClient part?

I see, I was looking in the bugfix branch.  I would refactor CreateClient into a helper function  that takes a SearchServerInterface, and then you can have a much more limited constructor that creates a connection and constructs a client, and then passes it to the helper function.  Then your tests can use the same helper, but just pass in a fake server instead.  That'll get most of the test coverage, without involving TCP.

K I think I've fixed the issues. Would be great to have a second pass before merging.

Looks good to me mod comments, thanks!


Roles are not handled appropriate for project settings

The following is an example where a superuser could not select a project in their project list because they were in a role:
https://community.projectredcap.org/questions/81166/auto-record-generation-not-show-transfer-project-i.html?

We should likely implement a fix using ExternalModules::getUserRights() instead of our own manually query like we have now.  If there's some reason we need to use our own query, Chris Kadolph suggested one in that community post.


Implement io.WriteCloser to allow flushing logs

Implement io.WriteCloser to allow flushing logs

Implement io.WriteCloser to allow flushing logs

Nice one


feat: add signOnly flag and logic for add/remove key/service

What issue is this PR fixing
Closes #1373
What is being changed
Due to constraints within the secure MetaMask Snap context, it is not possible to invoke the didManagerAdd(Remove)Service or didManagerAdd(Remove)Key methods on the did-manager successfully. Refer here for the list of blocked RPC methods.
As outlined in the referenced issue, the changes proposed herein allow for the transaction to be signed only, through the addition of a new signOnly flag within one agent (in the demonstration case, by an agent in the constrained MetaMask Snap environment), and then submitted from another context (for example via the ethers.InfuraProvider in another context).
Quality
Check all that apply:

[x] I want these changes to be integrated
[x] I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
[x] I allow my PR to be updated by the reviewers (to speed up the review process).
[ ] I added unit tests.
[ ] I added integration tests.
[x] I did not add automated tests because I first want to have the code reviewed by the maintainers, to get their feedback on the approach, and am happy to add tests as part of the final PR.

Details
I have successfully tested this (with the did-ethr-provider on the sepolia testnet).

This looks much better than before!
I think we are missing a couple of things before we can merge this:

tests to validate the new behavior
(optional, but highly recommended) even more simplification of the code:

We now have 3 paths for adding/removing an attribute:

a. sign and send a transaction directly. (default case)
b. sign a message using one key and sign and/or send a transaction using another key (metaIdentifierKeyId)
c. sign a message using one key (signOnly param)

Ideally, we would use the functionality from c. as a first step in b.

Hi @mirceanis. I have pushed some tests up which cover the introduced signOnly behaviour. Just a few points to clarify:

The tests require an INFURA_API_KEY because the provider needs to be instantiated with a network RPC url. I noticed there are some existing tests which have been commented out, and which include an InfuraApiKey variable (perhaps these tests have been disabled for the same reason?)
I can write additional tests, noting there presently are none, but want to check with you first about secrets/env variables, as these could be setup at the repo level, or you may already have some approach.
Overall add/remove key/service have tests applied and these can be expanded upon, perhaps in a new PR, just let me know your thoughts.
I agree that the code can be simplified, there is one caveat however, as you see that the final else block does not require a sigature (eth_sendTransaction as opposed to eth_sendRawTransaction). This means that the logic is not as straight forward as simply returning out if the signOnly flag is present. That being said, if you are ok with a conditional block within the else statement, I am ok to proceed. Actually, on a side note, this is where I picked up on the behaviour of the ethr-did-resolver because where no signature is provided it works at present, it is only where a signature is provided that it fails (pertaining to the other PR).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.97%. Comparing base (1c6627c) to head (4db3a2d).
Report is 4 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1389      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.01%
==========================================
  Files         176      176
  Lines       27695    27730      +35
  Branches     2201     2204       +3
==========================================
+ Hits        24912    24949      +37
+ Misses       2783     2781       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Map CRSR keys for Wordstar

Wordstar expects CTRL character keycodes for cursor movement. While these are accessible through CTRL-[A-Z] keys, mapping cursor UP/DN and L/R like they are done on a commodore 64 would be a nice enhancement.
ToDo: Screenshot wordstar ctrl shortcuts, get values for shift+cursor keys

Fixed in https://github.com/Alex-Kw/c64-rc2014-Keyboard/commit/4ae85ac17a56710f304104a979994af91d7a9f88


IOS textfield focus

When user click on search button search field appears but it is not focused. Any solution of this ?

There’s really not nearly enough information in this issue to be able to say anything helpful. Please describe the problem in more detail (element, version, platform, code, jsbin/fiddle reproducing the issue), so we can help. Thanks!
Also, usage questions like this are better handled in our Gitter chat or #vaadin Polymer Slack channel.


Framework not built when using Carthage

I expected to see a AlamofireObjectMapper.framework file but can only see the frameworks for Alamofire and ObjectMapper.framework.
Below is the contents of my Cartfile
github "Alamofire/Alamofire" >= 1.2
github "tristanhimmelman/AlamofireObjectMapper" ~> 0.4

+1

I think this has been fixed no?

Yes this should no longer be an issue. Please target the latest version of:
github "tristanhimmelman/AlamofireObjectMapper" ~> 0.6


Relaxing pydantic requirements

Hi @tcompa
I have seen that switching to pydantic v2 #592 still has some issues. But I have encountered a couple of critical installation issues with packages depending on pydantic>2 while trying to create new tasks (for example, https://github.com/bioimage-io/spec-bioimage-io that requires pydantic>=2.6.3, 3).
Would it be an option to use the legacy pydantic.v1 like in https://github.com/napari/napari/pull/6358 until there is a good solution for V2 and, in the meantime, update the requirements for fractal-tasks-core?

For context, we use Pydantic for three parts of fractal-tasks-core

We define models for objects to be used within the core library and/or tasks (including for task arguments - see point 3).
We validate arguments of the task functions, with the validate_arguments decorator
We generate JSON Schemas for the task arguments, with the core functionality being the one in this block https://github.com/fractal-analytics-platform/fractal-tasks-core/blob/243b3f43fde234be77d3469866938d9ae803ef58/fractal_tasks_core/dev/lib_args_schemas.py#L230-L235

Would it be an option to use the legacy pydantic.v1 like in https://github.com/napari/napari/pull/6358 until there is a good solution for V2 and, in the meantime, update the requirements for fractal-tasks-core?

Yes, I think this should work. We would bump the required version e.g. to >=2.0.0, and replace all current imports with pydantic.v1. Note that the three items above would still all work in Pydantic V1. This means that if spec-bioimage-io defines a Pydantic V2 model that you may want to use for a task argument, it's not guaranteed that it will work. If V2 models are only used internally, within spec-bioimage-io, then I don't think there will be issues.
Whether this intermediate step makes sense mostly depends on when we plan to tackle #592. For the record, preparing #737 was not a crazy amount of work (there are a bunch of validators that need to be ported to the new style, and https://github.com/pydantic/bump-pydantic also helped). There is a single critical point which concerns point 3 above, but the rest is mostly repetitive work..

Thanks for the clarification. In both problematic dependencies I have, pydantic is only used internally. So it won't be exposed to fractal-tasks-core validation/schema generation.
The only issue I can foresee is that if not properly documented, this can be confusing for task creators. They might be tempted to use V2 models in their tasks.
@jluethi, what's your opinion on this issue?
If we decide to take the intermediate step, I can prepare a PR. It should be fairly straightforward, and I will see more of the fractal code base.

@lorenzocerrone Is this urgent or can we review on Wednesday on how best to proceed?
My takeaway would be: I'm generally in favor of moving us to actually use Pydantic V2 in tasks core.
We will need to ensure that the manifest building works for Pydantic V1 & v2 at least for a certain transition phase though, as the current task packages by other people may also use Pydantic V1.
If we can have a good way of switching fractal tasks core to Pydantic V2 while maintaining this backwards compatibility, I'd be in favor of this being focused on instead of the pydantic.v1 imports. Maybe also a good way to have deeper fractal task core discussion between @tcompa & @lorenzocerrone :)
If we see this transition to be tricky, then I'm fine with first building pydantic.v1 version of fractal-tasks-core.

The most recent versions of Pydantic V1 now also offer the possibility of doing from pydantic.v1 import ..., to simplify the V2 transition (see https://docs.pydantic.dev/1.10/changelog).
I think this is helpful for us, and we could proceed as follows:

Bump the Pydantic requirement to ==1.10.16 (which is likely the last V1 version).
Replace all imports with pydantic.v1.
Check that all tests pass.
Change the Pydantic requirement to accept both ==1.10.16 and >=2.7.0 (or any other recent 2.X version).
Update Pydantic to V2 in poetry.lock, and check that all tests pass.

This allows us to unlock the dependency constraint, while keeping fractal-tasks-core fully in Pydantic V1 and with not version-specific code. The next step is then #592, which means that:

The core-library and tasks will fully move to Pydantic V2
Manifest building will work both for generating pydantic_v1 schemas (by using pydantic.v1 imports and the current logic) and pydantic_v2 schemas (by using a new logic similar to the one I tested in #737).
Manifest building for fractal-tasks-core itself will use the pydantic_v2 option. Other packages can specify this by setting args_schema_version, or we can infer it at runtime by looking at the installed Pydantic version.

What would not be supported is the following scenario

I have a task package with Pydantic V1 models, also used as argument
I want to build the manifest with Pydantic V2

Another non-supported use case (possibly more critical) would be

I re-use some of the fractal-tasks-core input models, which will be (after #592) written in Pydantic V2, and I need these models when building my manifest.
I want to stick to Pydantic V1 for my package dependency and internal models.

This was closed with #765


Resample such that mu-map is centered at x, y = (0, 0)

Somewhat solves #18
Don't actually accept this PR, I left lots of junk in the commit.
I am just including as it may be a useful reference for hackathon.

The key change was:
+  MuMapImageType::PointType outputOrigin;
+  outputOrigin[0] = -static_cast<float>(outputSize[0]) * outputSpacing[0] / 2.;
+  outputOrigin[1] = -static_cast<float>(outputSize[1]) * outputSpacing[1] / 2.;
+  // outputOrigin[0] = _inputImage->GetOrigin()[0];
+  // outputOrigin[1] = _inputImage->GetOrigin()[1];
+  outputOrigin[2] = _inputImage->GetOrigin()[2];

i.e., the umap should be centered transaxially.


Highlight IP Address information on non-interactive events

The goal is to highlight what IP Address information gets displayed on Azure AD Sign-in logs for non-interactive events performed by confidential clients.

@shlipsey3
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@court72 I thought that my linked PR would fix the requested edits. I couldn't edit inline so made the change in a separate PR. Not sure why it didn't sync up. It's my first time trying this method.

#please-close


support  format

support <script lang="ts" src="./vue.ts"></script> format

@Muscipular Please check the result of CI build and fix the lint errors 🙏

done. but not test case here :D

Is anyone alive there? This functionality would be very useful

I just found a simpler solution. https://github.com/ktsn/vuetype/commit/e35079dd04aae171932ae0aeef28c3838c8b10fe
Thank you for your contribution, anyway!

awesome!
btw, the watch mode support auto generate *.d.ts when *.vue or *.ts file changed? i'm not testing yet, maybe cause a bug.

Ah, I didn't realize about that, thanks for pointing it out!
I just made an update for that #18


stdlib: Adopt ExtensionImportVisibility experimental feature

Adopt the ExtensionImportVisibility feature when building the all standard library modules so that we're dogfooding the feature. Not very surprisingly, given their low dependency footprint, this has no effect on the sources of any of the stdlib modules.
Also, round out the test coverage for ExtensionImportVisibility by adding Obj-C interop tests and specifically testing AnyObject lookup. It turns out that AnyObject already filters out extension/category members that were not directly imported so the flag has no effect on it. We could potentially improve the diagnostics for AnyObject lookup misses that could be fixed by adding an import but that seems like a nice-to-have improvement we can do later.

@swift-ci please smoke test


WSL: Add version switching

This adds fetching release versions, and implements the version switching.

The GitHub mac CI runners look dead (it's stuck on getting a runner); force-merging.


Speed up DeduplicateAoEStep

Switch the implementation from using Array.find to a map for faster lookups.
Using https://xivanalysis.com/fflogs/LJkKTn8aWzPcxvZC/15/14 the time using Chromium's Performance tab goes from ~6s to ~14ms

Added unit tests and marked this as ready for review again, tested the unit tests on a cherry-picked branch and they currently pass.
  If we still decide it's worth having the unit tests we can open a fresh PR for them at a later date. Closing.


module system with not working with laravel 5.6 (routes)

Hi
I just did a fresh install of larvel, composer etc. I noticed they changed path for the routes.php file and also renamed it web.php.
This doesnt seem to work at all with the modular system since each module contain its own route file. The default laravel route is loaded and if i remove it i get an error. I really dont have a work around for this.
Are there any solutions to this?

Sorry, it seems i missunderstod a concept. It does seem to work. Sorry.

No worries, I'll close it down. 👍


Allow to override WM_CLASS by command line argument or env variable

The implementation reported in issue 145455 by the user @thejavascriptman is still necessary, because the lack of it makes the user experience bad that needs two or more different VSCode instances in the same development environment.
I transcribe below the statement of that demand, because the need remains current:

Please allow to override the window class name (WM_CLASS) of the VS Code window. Current behaviour is to use a single window class (code for the official build or code-oss for the open source build), this can be seen with xprop on Linux.
If the user passes the --user-data-dir and --extensions-dir arguments to create/use a new "profile", all VS Code windows will be attached, meaning that the last VS Code instance will be launched when using .desktop files (because both "profiles" would share the same window class).
By having a custom window class it would be possible to detach the VS Code windows as well as to specify a custom icon for each VS Code "profile" inside a .desktop file.

Merging to https://github.com/microsoft/vscode/issues/145455