Model validation code is not called

🐛 Bug
My defined methods for validation_step as well as validation_epoch_end do not seem to get called.
To Reproduce
Just call the provided code sample. Python should show the NotImplementedError. Instead the model completes 'successfully'.
Code sample
import pytorch_lightning as pl
import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.utils.data import DataLoader

class Dataset(torch.utils.data.IterableDataset):
    def __init__(self):
        super().__init__()

    def __iter__(self):
        def get_sample():
            for _ in range(5):
                yield torch.randn(20)
        return get_sample()

    def __len__(self):
        return 5

class Model(pl.LightningModule):
    def __init__(self):
        super().__init__()

        self.enc = nn.Linear(20, 10)
        self.dec = nn.Linear(10, 20)

    def forward(self, x):
        x = self.enc(x)
        x = F.relu(x)
        x = self.dec(x)
        return x

    def training_step(self, batch, batchIdx):
        x = self.forward(batch)
        return {'loss': torch.mean(x)}

    def validation_step(self, batch, batchIdx):
        raise NotImplementedError()
        x = self.forward(batch)
        return {'val_loss': torch.mean(x)}

    def validation_epoch_end(self, outputs):
        return {'val_loss': torch.mean(torch.stack([x['val_loss'] for x in outputs]))}

    def configure_optimizers(self):
        return torch.optim.AdamW(self.parameters())

if __name__ == '__main__':
    trainer = pl.Trainer(num_sanity_val_steps=0)

    net = Model()
    dataset = Dataset()

    trainer.fit(net, train_dataloader=DataLoader(dataset, batch_size=8, num_workers=0), val_dataloaders=DataLoader(dataset, batch_size=8, num_workers=0))

Expected behavior
Instead, I'd expect the code sample above to fail.
Environment
Collecting environment information...
PyTorch version: 1.5.1+cu101
Is debug build: No
CUDA used to build PyTorch: 10.1

OS: Gentoo Base System release 2.7
GCC version: (Gentoo 9.3.0 p1) 9.3.0
CMake version: version 3.17.3

Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.1.243
GPU models and configuration: GPU 0: GeForce GT 730
Nvidia driver version: 440.82
cuDNN version: /opt/cuda/targets/x86_64-linux/lib/libcudnn.so.7.6.5

Versions of relevant libraries:
[pip3] numpy==1.19.0
[pip3] pytorch-lightning==0.8.1
[pip3] torch==1.5.1+cu101
[pip3] torchvision==0.6.1+cu101
[conda] Could not collect

As a note, the validation code is called twice when leaving out the num_sanity_val_steps=0 parameter. After the two sanity runs, it is not called anymore.

Your dataset is wrong. That's causing the issue.
DataLoader(dataset, batch_size=8, num_workers=0, drop_last=True)

since your batch size and dataset length don't work out well.

Changing the dataset to produce 128 samples does not change this either:
import pytorch_lightning as pl
import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.utils.data import DataLoader

class Dataset(torch.utils.data.IterableDataset):
    def __init__(self):
        super().__init__()

    def __iter__(self):
        def get_sample():
            for _ in range(128):
                yield torch.randn(20)
        return get_sample()

    def __len__(self):
        return 128

class Model(pl.LightningModule):
    def __init__(self):
        super().__init__()

        self.enc = nn.Linear(20, 10)
        self.dec = nn.Linear(10, 20)

    def forward(self, x):
        x = self.enc(x)
        x = F.relu(x)
        x = self.dec(x)
        return x

    def training_step(self, batch, batchIdx):
        x = self.forward(batch)
        return {'loss': torch.mean(x)}

    def validation_step(self, batch, batchIdx):
        raise NotImplementedError()
        x = self.forward(batch)
        return {'val_loss': torch.mean(x)}

    def validation_epoch_end(self, outputs):
        return {'val_loss': torch.mean(torch.stack([x['val_loss'] for x in outputs]))}

    def configure_optimizers(self):
        return torch.optim.AdamW(self.parameters())

if __name__ == '__main__':
    trainer = pl.Trainer(num_sanity_val_steps=0)

    net = Model()
    dataset = Dataset()

    trainer.fit(net, train_dataloader=DataLoader(dataset, batch_size=8, num_workers=0), val_dataloaders=DataLoader(dataset, batch_size=8, num_workers=0))

> python main.py
GPU available: True, used: False
TPU available: False, using: 0 TPU cores

  | Name | Type   | Params
--------------------------------
0 | enc  | Linear | 210
1 | dec  | Linear | 220
/home/constantin/.virtualenvs/tensor/lib64/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:25: UserWarning: The dataloader, train dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 8 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
/home/constantin/.virtualenvs/tensor/lib64/python3.6/site-packages/pytorch_lightning/utilities/distributed.py:25: UserWarning: The dataloader, val dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 8 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  warnings.warn(*args, **kwargs)
Epoch 1000:   6%|███████████████████████▊                                                                                | 16/256 [00:00<00:00, 1252.80it/s, loss=-2894.485, v_num=7]
>

Also changing the drop_last option does not make any difference (on 128 samples).
Could we please reopen this, @williamFalcon ?

Same. I have to set the validation to a minimal number... I can't train on all the data and leave validation out when training with TPU, it hangs after first epoch. To narrow it down, this is a problem with TPU because it works fine with CPU and GPU.

Same problem here. I use val_dataloader method of 'pl.LightningModule', but this method is never called. So I specify trainer.fit(model, val_dataloaders=model.val_dataloader()), and set break points in validataion_step function, but it's also never called....

@Steve-Tod Can you check the spelling on your validation_step function? If you copy pasted, then it's slightly off. It is kind of annoying that misspellings here create silent errors.

Any update on this?

Any update on this?

@SamPusegaonkar What's your issue? Cannot reproduce the behaviour in the description of this issue. Could you create another issue since this is quite outdated?

https://github.com/Lightning-AI/lightning/discussions/13726#discussioncomment-3182709
Please check out this

I have the same issue. My validation_step is just not called. Snipped of code:
    def validation_step(self, batch, batch_idx):

        # Shape: (batch size, 1, 2)
        initial_positions = batch['initial_positions']
        # Shape: (batch size, trajectory length, 2)
        positions = batch['positions']
        # Shape: (batch size, trajectory length, 2)
        velocities = batch['velocities']

        rnn_activations = self.forward(
            initial_positions=initial_positions,
            velocities=velocities)

And
trainer = pl.Trainer(
    max_epochs=10,
    min_epochs=5,
    check_val_every_n_epoch=1,  # default
    # precision
    # log_every_n_steps=50,
    # overfit_batches=1  # useful for debugging
)
trainer.fit(
    model=system,
    train_dataloaders=trajectory_dataloader)

I my case, Lightning skip validation when I set a limit_train_batches larger than available batchs.

I my case, Lightning skip validation when I set a limit_train_batches larger than available batches.

Thanks! Help me debug my issues. It's annoying because it doesn't throw any warning.

I my case, Lightning skip validation when I set a limit_train_batches larger than available batches.

This inspired me to solve my issue! Turned out that my length of my customized sampler is longer than actual batches. After I corrected the len() of my batchsampler, it works!!!!


hgt files not found

Hi mate,
I'm trying this project, but don't found some files like N04E001.hgt
How to reproduce:
I looking for the elevation of lat, lng = 41.7323687,0.3103932
When I debug the project, I found that you navigate to
http://www.imagico.de/map/dem_json.php?date=&lon=1&lat=4&lonE=1&latE=4&vf=1
And hav the follow result:
[{"name":"B31.zip","title":"","link":"http://www.viewfinderpanoramas.org/dem3/B31.zip","date":"2012-05-28","lon_start":"0","lat_start":"4","lon_end":"6","lat_end":"8","type":"2"}]
Inside the http://www.viewfinderpanoramas.org/dem3/B31.zip don't exist the N04E001.hgt
Do you have other source hgt file repository?
Do you think about use the Mapzen on AWS files?
https://aws.amazon.com/es/public-datasets/terrain/
Exist any bug in the code?
I see on your elevation-service project that's working ok
In this service all run ok
https://github.com/perliedman/elevation-service
thanks of lot
Claudio

Hi @mrcheidel,
thanks for the report, and also great work with the investigation into this issue!
I've seen similar reports before, but haven't found the time to dig into it, but from what you're saying, it does look like a problem with Imagico's search service, that returns a result that does not include the actual tile. At least from what you write, it doesn't sound like an issue with node-hgt, but I can't say for certain.
I have look into using Mapzen/AWS Terrain tiles, I think for the future it would be a much better option, but I haven't implemented it myself. I would be very happy to include a new downloader for AWS terrain tiles to replace the default in TileSet. At the moment it doesn't look like I will find the time to do it myself any time soon.


Bulk check/uncheck all keys in the config

Is your feature request related to a problem? Please describe.
As a user, I want to add problematic keys gradually. To do that, on the configuration page, I should uncheck each key individually. That takes time and annoys me.
Describe the solution you'd like
I propose to add a new checkbox in the header row of the keys table that will check/uncheck all keys altogether.

Describe alternatives you've considered
This control could be placed under the table as a button or checkbox similar to Set ALL

您的邮件已收到，谢谢！


Update ethereum/tests fixture to v11.1 and update .gitignore

Update ethereum/tests to latest v11.1 release commit hash
Cute Animal Picture

Wow, are these real trie bugs? Kind of looks like it.

Wow, are these real trie bugs? Kind of looks like it.

Thankfully not 😅 . Nothing to see here.


Different title and text for ToF sensor block

also added and updated some tooltips in this pull-request


Overhaul styling, theme and branding

I'd like to check this renders neatly on mobile, I had a few issues with the footer and nav positioning when I last looked.


code

When will the code be released?

The code will released this week on https://github.com/ucas-vg/PointTinyBenchmark and this repository will be deleted.


Epic S-7: As a user, I want to be able to connect my calendar to set my next scheduled destination.

As a user, I want to be able to connect my calendar to set my next scheduled destination.
Acceptance Criteria:

[x] Given that I am in the schedule menu, when I press on directions from one of my courses, then I should get directions on the map to my course’s room destination.

Covered through #28 #29 via PR #127


Yellow + Bold not working

My code, ${Chalk.yellow.bold([WARN] =>)}, does not work. It defaults to the bold gray. Everything else (underline, etc.) works with yellow.

Code? Screenshot? Operating system? Terminal program (iTerm, terminal.app, command prompt)?
The fact millions of people use our package every day without any problems doesn't help us narrow down your specific problem without much more information.

Code:
client.log = function log(text, type) {
  if (!type) console.log(`${Chalk.cyan(`[${moment().format('YYYY-MM-DD HH:mm:ss')}]:`)} ${Chalk.bold(`[INFO] =>`)} ${text}`);
}

Screenshot: https://owo.solutions/ebb3d3.png (first pic is underline, second is bold.)
MacOS.
iTerm2.

I'm on iTerm2 and Mac os. Works fine for me.

Could you try creating a new iTerm2 profile (just an empty one, don't duplicate it) and trying you test again?
Also, could you do FORCE_COLOR=1 node /path/to/your/program.js | cat -v and show the output here?

^[[36m[2017-04-30 16:11:36]:^[[39m ^[[33m^[[1m[WARN] =>^[[22m^[[39m Ready.
`
That's what force color returns.

Seems like using Solarized Dark is what messed me up.


post editor style bar position

it would be useful to make the position of the style bar fixed, so it doesnt scroll up. this way you can edit styles even when on the bottom of the post

Yeah this is the case while editing, but I forgot to fix it in the post creator thingy :)


Enable NuGet auditing in CI/CD pipeline

https://learn.microsoft.com/en-us/nuget/concepts/auditing-packages
<Project>
    <PropertyGroup>
        <NuGetAudit>true</NuGetAudit>
        <NuGetAuditMode>all</NuGetAuditMode>
        <NuGetAuditLevel>low</NuGetAuditLevel>
    </PropertyGroup>
<Project>

I think this feature is most useful in apps which consume this package
As part of the build process for this package, the best way to check for vulnerable packages we consume is probably just to run the following command in our CI system:
dotnet list package --vulnerable


Add Three-Line List support to List v2 Component

Specs: https://material.google.com/components/lists.html#lists-specs

Pre-emptive Strategy: Set hard-coded height values on secondary text element, and use text-overflow: ellipses;. Document how this works so as not to surprise end users.

Superceded by https://github.com/material-components/material-components-web/issues/31


test-branch/execute-job/wrong-commit-sha-on-pr/170c9a6a-0865-49bf-9644-3f9a0d0d0e31

PR for testing c2e8fb14f39b7fa36306888e70790c8b96519691

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Cleanup StartBlockListener Function And Add Better Test

Refactor StartBlockListener function as it was getting quite large, and it was hard to test. This breaks out the actual circuit break checking logic into its own function, allowing isolated testing, while making it easier to read.

Codecov Report

Merging #10 (c168a9f) into master (858bcfc) will increase coverage by 1.74%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   67.73%   69.47%   +1.74%
==========================================
  Files          16       16
  Lines         908      901       -7
==========================================
+ Hits          615      626      +11
+ Misses        210      192      -18
  Partials       83       83

Impacted Files
Coverage Δ

service/service.go
52.51% <36.84%> (+6.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858bcfc...c168a9f. Read the comment docs.

Ignoring the build failure as it is a problem that occasionally happens with inufra, and one that we gracefully handle during operation.


Round 7 - Daily Intake Report - Character Updates

Change pkg to Pkg
Change gr (grams) to g

When a food is displayed in the Daily Intake Report and I swipe to the left over the nutrient content of that food, the protein, carb, and fat are still displayed as gm instead of g.  Also, when sorting foods by protein, carb, or fat in the Food Inventory, they still appear as gm instead of g.

Working on this!
CC @coderReview

@szwart, this defect has been fixed. Please delete the old version and re-install from the same install link.

Hi @szwart, just checking in. Can we close this?

Fixed.


Add Package Group Check

In the webman check [DIR] command, package groups should be checked in addition to packages.
Package groups should be parsed in strict mode, then the checker should make sure each listed package exists as a yaml recipe in the pkgs directory.

Implemented


Two dimensional scroll DiagonalDragBehavior.free not works on Flutter Web desktop

Steps to reproduce
DiagonalDragBehavior.free doesn't work when i use macbook trackpad to scroll diagonal. Work as expected on mac but not in browser.
Expected results
Scroll diagonally
Actual results
Scroll one Axis
Code sample
two_dimensional_scrollables package example: https://github.com/flutter/packages/tree/main/packages/two_dimensional_scrollables/example
Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/62325868/f3de01a7-f9db-4f9a-a71f-d8dc60a09475
https://github.com/flutter/flutter/assets/62325868/04778459-073a-49f5-8b94-6f4164d6d3ec
[Upload media here]

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.5 23F79 darwin-arm64, locale en-VN)
    • Flutter version 3.22.0 on channel stable at /Users/daiduong/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (3 weeks ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/daiduong/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (5 available)
    • fhihung.iphone (mobile)         • 00008030-00096989013B802E            • ios            • iOS 17.5 21F79
    • iPhone 15 (mobile)              • 5C4A1F0D-F559-4081-A128-E095694A0EED • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 125.0.6422.112
    ! Error: Browsing on the local area network for mayvees. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for Duyên’s iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for 5pk. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for Lisa (2). Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for Duong phone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@definev
I tried the plugin example using latest stable running on mac + chrome and used two fingers to scroll diagonally via trackpad with which I seem to be able to scroll properly ?
https://github.com/flutter/flutter/assets/67046386/d38fe813-7859-41d5-bf61-fb0a55e0e436
Also check https://github.com/flutter/flutter/issues/144982 and https://github.com/flutter/flutter/issues/147488 for further reference.

No it's difference when you scroll horizontally it stick to horizontal and cannot scroll vertical at the same time. Vice versa with vertical. But in the mac app you can do it. I wrap it in Listener widget to listen pointer event, in the mac app they doesn't produce anything but in chrome it produces:
event: _TransformedPointerScaleEvent#ba6fc(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#4d166(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#51b6e(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#20af8(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#24cce(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#5e1a9(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#5976e(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#cd760(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#c49af(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#bd16f(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#02e2c(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#8297e(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#437a2(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#58da5(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#c39fd(position: Offset(210.0, 556.0))
event: _TransformedPointerScaleEvent#89619(position: Offset(210.0, 556.0))

https://github.com/flutter/flutter/assets/62325868/04778459-073a-49f5-8b94-6f4164d6d3ec

Thanks for the update. Seeing the same behavior as reported specifically on web.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.22.0, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.22.0 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (5 days ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.23.0-12.0.pre.7, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.23.0-12.0.pre.7 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 35ae519140 (2 hours ago), 2024-05-29 00:33:07 -0400
    • Engine revision b26e1b023c
    • Dart version 3.5.0 (build 3.5.0-191.0.dev)
    • DevTools version 2.36.0-dev.10
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

This is because web cannot identify trackpads right now, so when the input it received it is treated the same as a scroll wheel. We are tracking this in https://github.com/flutter/flutter/issues/139990
Since this is not specific to the TableView, I am going to close this to refer to that issue.


Read/write timeout

Hi, trying to use your library, can't understand how to add read/write timeout, because in blocking mode it blocks infinitely

I assume this is with the seqpacket types and not the extension traits for stream and datagram sockets?
I hadn't thought about timeouts! I'll add it some point. (as well as take_error() and peek() which I see are also missing.)

After many rounds of testing (mostly adapting tests to different operating systems), timeout methods have been released in 0.2.1.


[api-freeze] Verify operator API is frozen

Backwards compatibility of GA APIs
What constitutes a backwards compatible API?

Fields can not be removed (this also means you can’t rename a field)
Serialized defaults can not change.  Unserialized defaults in operators can change over time.
Behavior (meaning) of a field can not change.  This means that old fields must be maintained even if new fields supercede them.
New fields can be introduced that supercede existing fields, but values in the existing fields must be respected when present.

Other things that should be considered “API”

Names of singleton CRs in openshift-config (user-provided) and openshift-config-managed (operator-provided) namespaces that are used for cross-communication of components
Names / namespaces of Services used for cross-communication of components
Annotations and labels used for cross-communication of components

/assign @dmage

@dmage there are a few areas of concern with the API:

A TODO regarding the "Removed" status type: https://github.com/openshift/cluster-image-registry-operator/blob/master/pkg/apis/imageregistry/v1/types.go#L49-L51
Storage types for Azure, GCS, and Swift/OpenStack are present. These won't be ready for GA until 4.2 at minimum. https://github.com/openshift/cluster-image-registry-operator/blob/master/pkg/apis/imageregistry/v1/types.go#L194-L209
We have a catch-all "Filesystem" storage. https://github.com/openshift/cluster-image-registry-operator/blob/master/pkg/apis/imageregistry/v1/types.go#L221 IMO we should do one of two things here:
a) Keep, but rename to "UnsupportedFilesystem" to make it clear that we do not provide support.
b) Remove, and add an API field that allows EmptyDir storage for libvirt

@bparees @jwforres @openshift/sig-developer-experience fyi

Moved to https://bugzilla.redhat.com/show_bug.cgi?id=1700487


runelite-client: add chat recolor plugin

Thanks aloot guys for the hard work you made me able to enjoy runescape again!!! <3


Dropdown title wraps text

If selected option text is wider then the dropdown title span element, the text wraps and shows outside the dropdown label.

Good catch - we'll look into it!

Looks like this one was fixed by #229! Let us know if you notice anything else!


WFLY-8708 move standalone-load-balancer.xml to the config directory

why do we need this change? it just adds clutter to distro and extra work for testsuite (stupid xslt stuff)

For consistency with domain.xml.
In terms of the test suite time it would be better if this XSLT was only applied to the files that are actually needed for a given module.


[SPARK-16887] Add SPARK_DIST_CLASSPATH to LAUNCH_CLASSPATH

What changes were proposed in this pull request?
To deploy Spark, it can be pretty convenient to put all jars (spark jars, hadoop jars, and other libs' jars) that we want to include in the classpath of Spark in the same dir, which may not be spark's assembly dir. So, I am proposing to also add SPARK_DIST_CLASSPATH to the LAUNCH_CLASSPATH.

Test build #63203 has started for PR 14492 at commit ffc0e4a.

@yhuai can you explain the use case you're trying to cover here with an example?
LAUNCH_CLASSPATH is the classpath of the launcher process (the process that creates the command line to then run the SparkSubmit class). The launcher itself already adds SPARK_DIST_CLASSPATH to Spark's classpath:
https://github.com/apache/spark/blob/d6dc12ef0146ae409834c78737c116050961f350/launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java#L204
    addToClassPath(cp, getenv("HADOOP_CONF_DIR"));
    addToClassPath(cp, getenv("YARN_CONF_DIR"));
    addToClassPath(cp, getenv("SPARK_DIST_CLASSPATH"));

Sure. This change is for putting Spark jars in a different dir than the default dir in spark/assembly or spark/jars. So, in this case, the main class is not in SPARK_JARS_DIR.

But what's the goal of that? If there's nothing in $SPARK_HOME/jars, why not create a symlink instead to the location where the jars are?
The change itself doesn't really cause any problems, I just don't understand the need.

More specifically, the Spark distribution has the jars needed by the launcher in $SPARK_HOME/jars, so basically this is extra code in Spark to support non-standard distributions.

Test build #63203 has finished for PR 14492 at commit ffc0e4a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63203/
Test PASSed.

Merged build finished. Test PASSed.

That's a good point. Let me close this.


made changes for 'extension arrows' and ratio='autot'

All tests pass.

@mcenerney1 shouldn't we be getting new baselines?


PGN variations support

first of all thanks for creating this package.
I'm not sure rather that's what your package is supposed to provide but I'd like to see more pgn support.
You could take inspiration from https://www.overleaf.com/learn/latex/Chess_notation (the latex chess package I currently use).
It would be nice if you can do something similar:
\documentclass{article}
\usepackage{xskak}
\begin{document}
\newchessgame
\mainline{1.e4 e5 2.Nf3 Nc6 3.Bb5}

\chessboard

\mainline{3...a6}

A variant \variation{3...Nf6} is used here to show a \texttt{\string\variation} command.

\mainline{4.Ba4}

\chessboard
\end{document}

I'm currently working on PGN support. I will likely release the next version of the package, including the game function, when PGN is supported (should not be too long to implement). If you have an urgent need for the game function, I can create a release sooner.

I finally added support for importing for the portable game notation format (which itself support variations) in efe0364e859736aa4d37f860001d3de33d5391f4.
I may look into variations later, but I'm not sure how to expose those in a user-friendly way.


Fix crash changing from a larger page size to a smaller one

Related Issue
Haven't found an issue in this repo yet.
Description
When using remote data loading with paging and you reduce the the rows per page (from 20 to 15), the app will crash because it will try to render 20 items at a row page size of 15 before data is loaded and emptyRowCount will be -5 which crashes when trying to do Array(-5)
Impacted Areas in Application
List general components of the application that this PR will affect:
Fixed a possible crash when changing page size.
Additional Notes
This is a bug fix.

Would it be possible for you to add a test to cover this use case as well?

Would it be possible for you to add a test to cover this use case as well?

I am not familiar with creating tests here, but I can try, mostly it's mocking remote loading and changing page size to a lower value.

Yes and I will merge it. You could copy one of the tests files and mock the data call.
It would be great if you could create a new PR at one point for this to make the whole project more stable, but no rush.


feat: support optional parent project name/id for Dependency-Track SBOM upload

Currently, you can configure the dependency-track integration to auto-create a project in Dependency-Track when uploading an SBOM. However, this auto-created project will just be at the top level of the hierarchy in Dependency-Track. For instances with many projects it can be useful to group them in a parent/child hierarchy. This requires passing an identifier for the parent project to the /api/v1/bom when submitting an SBOM which currently isn't supported in Chainloop.
Example project hierarchy in Dependency-Track:

I might be able to find the time to submit a PR for this if this feature would be desirable and a PR welcome?

hi @sedan07, thanks for posting the issue!
This is indeed a very useful feature, and we love contributions :)
Just some clarification. Chainloop allows you, as you mentioned, to attach a dependency-track project to a workflow, and this project can be either.

an existing one:  projectID
an existing or new one: projectName

┌───────────────────────────────────────────────────────────────────────────────────────────┐
│ Attachment inputs                                                                         │
├─────────────┬────────┬──────────┬─────────────────────────────────────────────────────────┤
│ FIELD       │ TYPE   │ REQUIRED │ DESCRIPTION                                             │
├─────────────┼────────┼──────────┼─────────────────────────────────────────────────────────┤
│ projectID   │ string │ no       │ The ID of the existing project to send the SBOMs to     │
│ projectName │ string │ no       │ The name of the project to create and send the SBOMs to │
└─────────────┴────────┴──────────┴─────────────────────────────────────────────────────────┘

The new parentID parameter will work in combination with projectName only, correct?
It also seems the parent can be provided either by name or id. Should we implement parentName as well? My gut feeling says that supporting parentID is the way to go for now, but I am curious about your use case.
Where to start
I know documentation could be better, so I'll try to point to the right places in the codebase to start with. I can also assist with the implementation if you want. You can find me in Discord.
This kind of functionality is implemented as a fanOut plugin, and specifically the DependencyTrack plugin can be found here
To add new parameters (i.e ParentID) to the attachment phase, you need to update this struct
https://github.com/chainloop-dev/chainloop/blob/3096036fa8ced1e38caf99e4bd06c523934c23b0/app/controlplane/plugins/core/dependency-track/v1/extension.go#L45-L49
Once you do that, the user will have the option to provide such parameter using the chainloop CLI during attachment as shown here, basically --opt parentID=deadbeef
You can then retrieve such value in the plugin https://github.com/chainloop-dev/chainloop/blob/3096036fa8ced1e38caf99e4bd06c523934c23b0/app/controlplane/plugins/core/dependency-track/v1/extension.go#L122
and in there make sure to extend validateAttachment so it checks that the parent project exists, similarly of the validation that we do for the regular project
https://github.com/chainloop-dev/chainloop/blob/3096036fa8ced1e38caf99e4bd06c523934c23b0/app/controlplane/plugins/core/dependency-track/v1/extension.go#L278
Finally, update the client and the execution phase to send these new parameters
https://github.com/chainloop-dev/chainloop/blob/3096036fa8ced1e38caf99e4bd06c523934c23b0/app/controlplane/plugins/core/dependency-track/v1/extension.go#L166
And that's it, don't forget to bump the plugin version and we are off to the races :)
https://github.com/chainloop-dev/chainloop/blob/3096036fa8ced1e38caf99e4bd06c523934c23b0/app/controlplane/plugins/core/dependency-track/v1/extension.go#L68
Thanks again!

@migmartri thanks for the detailed breakdown of the changes required. I can certainly do these.

I know documentation could be better

So far actually I've been pleasantly surprised by the quality of the contribution documentation and local dev setup for a relatively young project.

Great! Looking forward to the contribution. As I said, I am more than happy to assist, jump on a call, anything; you can find me here or in Discord.

So far actually I've been pleasantly surprised by the quality of the contribution documentation and local dev setup for a relatively young project.

Glad to hear 😊

hi @sedan07
I just noticed that we've not documented this feature yet in https://docs.chainloop.dev/guides/dependency-track/
Is this something that you'd be interested in?
The source code of the docs are also in this repo https://github.com/chainloop-dev/chainloop/tree/main/docs.
Since I noticed it's not documented, to run the docs site locally you'd do
# install dependencies
yarn install

# and run the site
yarn run docusaurus start

Thanks!

@migmartri I'd actually planned to update the docs then it completely slipped my mind. Yes I can sort that out.

@migmartri I'd actually planned to update the docs then it completely slipped my mind. Yes I can sort that out.

Thank you :)

@sedan07, the documentation changes are now up again. Thanks!


merge upstream (1b738f8699da71c550b1b3f0732677db7ddfab4d)

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

going to merge in local


Folder lat modified upon saving file

Request feature for modifying last modified of parent folder upon saving file too.
This will be easier for coders to know which folders contain files which have been modified recently.

	"explorer.sortOrder": "modified"

You misunderstood what I need and closed the file.
Upon saving a file in Folder A, I need the Folder A modified time to be updated as well.


make internal shared funcs and structs pub(crate)

While reviewing the latest Goose docs I noticed it's a bit cluttered with functions and structures that aren't useful to consumers of the Goose library. In those cases I've changed their scope from pub to pub(crate) thereby removing them from the documentation.

@LionsAd In theory everything I've re-scoped was useless to libraries using Goose, but technically this changes the exposed UI. Is it important I increment the version to 0.12 to reflect this?


Update specs2-core to 5.5.2

About this PR
📦 Updates org.specs2:specs2-core from 5.0.7 to 5.5.2
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.specs2", artifactId = "specs2-core" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #247.


Tree Structure

Hi!
I would like to store a tree structure in LiteDB.
Before i have used Postgres for this.
In Postgres exists the Data Type "ltree", which allows to query a path and/or his childs very easy.
https://www.postgresql.org/docs/9.6/static/ltree.html
Its possible to query for all Childlevels or only for a few Childlevels.
Is there anything in LiteDB which works nearly the same?
Or maybe is there a better solution for this?

Hi @windischb, nice data structure, I never saw anything like that. There is no direct way in LiteDB. If this structure is a string data you can only use query as normal string (=, >, <, like, contains, ....).
In v4 its possible use some expression functions to split this string and query better using index. But is not that powerfull as ltree datatype in Postgres

Ok, thanks!
I'll try to find another efficent way for Tree Structures...

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


Trying to play an mp4 video...

Hi,
Please, can you make an example using a local mp4 video, i can-t make it working...
{ url:"".$dir.$file."", duration:6000, mute:true, alignY:0, isVideo:true }
Thanks in advance.
Alex.

This works for me with a local file:
        $.backstretch([
			{ url: "movie.mp4", duration: 6000, mute: true, alignY: 0, isVideo: true }
        ]);

I would check a couple things -

Are the $dir and $file variables creating the correct path?
Will the file you're trying to use play in the browser?


InProcPravegaCluster with TLS not working

Problem description
While addressing the fix for the issue https://github.com/pravega/flink-connectors/issues/216, I have noticed that the InProcPravegaCluster that we use for system test case is not working properly when TLS and auth are enabled. However, the TlsEnabledInProcPravegaClusterTest from Pravega repository is working (which also uses the  InProcPravegaCluster).
However if the system test cases are executed against a StandAlone Pravega cluster (with TLS and auth ON), the test cases are passing. So It is not clear if there is any additional dependency that is missing in the connector project (in comparison to Pravega) which is causing this trouble.
Problem location
System test case in connector with TLS and auth ON.
io.pravega.connectors.flink.utils.SetupUtils
Suggestions for an improvement

Closed https://github.com/pravega/flink-connectors/pull/217


Probably wrong name of example dataset in Distances tutorial

Report
Description
In the Distances Tutorial Notebook, the used example dataset pt.dt.example_dataset() is not available:
Observed behaviour
adata = pt.dt.distance_example_data()
raises
AttributeError: module 'pertpy.data' has no attribute 'distance_example_data'
from the data module, it appears the correct name is distance_example, so the line should be probably
Suggested fix
adata = pt.dt.distance_example()
If the dataset has changed together with the name, maybe there'd be more to consider, not sure about that.
Related Session Info
pertpy 0.6.0
Version information
No response

Sorry. Fixed! May or may not render on the docs soon but you already figured it out :)


make install does not install matlab or python components

The make install command from the Makefile does not install the matlab or python components

Related to #271 and other future wrappers


spl-token-cli: Bump to 2.0.16

In order to have recent changes on spl-token-cli, just a simple bump to 2.0.16 to permit an update on crates!

After trying to use it by building master on my local env, I had some issues trying to creating token, accounts, etc So I think it's not ready to bump!

This was done in #3360


Add tool.mypy.overrides to pyproject.toml

This PR is an alternative to https://github.com/MarcoGorelli/cookiecutter-polars-plugins/pull/11. I Personally prefer this option to avoid cluttering the project directory.
Fixes the mypy error below, that happens when the available Polars version doesn't have polars.utils.udfs.
test/__init__.py:16: error: Cannot find implementation or library stub for module named "polars.utils.udfs"  [import-not-found]
test/__init__.py:16: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 5 source files)

Thanks for maintaining this!
Just a mypy-related note, Polars is now throwing a deprecation warning when you import from type_aliases. To try to avoid having that every time my plugin is imported, I included a try-exception (here), but mypy complains that the modules are being imported twice (even though they actually aren't).
Not sure if you're planning to deal with the depreciation warning in this repo, but if you do, let me know if you find a better solution! Mypy proved to be a big headache for a such small project like mine.


Update Submodules

Updates the commits to latest main for picknik_accessories, picknik_registration, ros2_robotiq_gripper  since we just merged some more PRs into them and they were on old commits or branches anyways.

We could repoint our repo to humble, but why are there 2 branches (main and humble) for the robotiq_gripper if it's our fork? Because of that I think we need to fix this package on main, even if it's not a true rolling main.


How to know that RUN's are completed

How do we come to know that Runs are completed and ready for review .
sonobuoy status
PLUGIN		STATUS		COUNT
e2e		running		1
systemd_logs	complete	9
Sonobuoy is still running. Runs can take up to 60 minutes.
as of now i m running sonobuoy logs -f

There is a hardstop timeout at 5400 seconds after the run starts (by default), otherwise, keep running status every now and again to see if it says complete.

Closing this issue, as the status is denotes 'completed' and there is a log as well.


Added aptly::api

I’ve added a basic class to provide Aptly’s REST API as an Upstart service.

Hi @wilrnh; thanks for the PR. We'll review it and get back to you shortly.

@wilrnh I really like this PR, but it would be even greater - and in a good state to merge - with a few tests. Are you okay with writing some for this? Let me know if you'd like any help or have any Qs!

Hi, @wilrnh
Thanks for adding the tests and removing the author line.
Could you rebase to remove the merge commit?
Due to the unique way that github works could you make a comment when you've done that and pushed so that we can see its happened.
Once you've rebased we will almost certainly merge this.

Hey @rjw1, I just rebased the merge commit out (my bad!) Thanks for merging this in!

:+1:

released to the forge as 0.3.0


max-brightness not working

Hi, I am on Manjaro, Nvidia 1050 Ti, HP Pavilion 15 Gaming + Philips 223V monitor.
Used "icc-brightness-gnome-git" package to install from AUR.
When I try this command : brightness max-brightness I get errors.
➜  ~ icc-brightness brightness max-brightness
Traceback (most recent call last):
  File "/usr/bin/icc-brightness", line 157, in <module>
    main()
  File "/usr/bin/icc-brightness", line 148, in main
    brightness = int(sys.argv[1])
ValueError: invalid literal for int() with base 10: 'brightness'

icc-brightness watch command is working. It's little jumpy, but it's fine. Could be smoother.

As the last line of the error message says - please consider using int values.
Example: icc-brightness 80 100 will set the brightness to 80%


Add AutoProcessor registration

UV 0.4 doesn't currently register the processor.

@petersalas will you update the two files (ultravox_processin.py and config.json) or should I?

Oh I see -- do you have the other changes we need for from_pretrained?

Done.


rangy-highlighter partial un-highlight supported?

Unless I'm missing something, I don't see that this feature is supported in the rangy highlighter.
Example:  select some text and call highlightSelection().  Then select a portion of the highlighted text and call unhighlightSelection().  What happens is it will find any highlights that intersect with what you've selected (our 1 and only highlight in this example) and then remove the whole thing.
I'm happy to submit a PR to add partial unhighlight ability, but first thought I'd see if anyone else has done this and/or if this project is still being maintained?  Thanks,

Just an FYI, I have a PR ready for this.

The PR.


[ci] Skip Android webview FTL tests on stable

These tests crash on stable due to
https://github.com/flutter/flutter/issues/96661 now that 2.10 has been
released to stable.
Fixes out-of-band tree closure from the 2.10 release.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

(This will need to land in red to fix the submit-queue check)

Still failing?
https://console.firebase.google.com/project/flutter-cirrus/testlab/histories/bh.1ddca77c39c73e39/matrices/8305578407344643451

🤦🏻
Thanks.

No problem! I hope this goes through now :D

Landing on red to fix tree.


Azurite SAS blob upload does not work with Python lib.

Which service(blob, file, queue, table) does this issue concern?
blob
Which version of the Azurite was used?
latest Docker image
$ docker run -p 10000:10000 -v files:/data mcr.microsoft.com/azure-storage/azurite -v
v12.19.0
$ docker images --digests | grep azure
mcr.microsoft.com/azure-storage/azurite     latest                                           sha256:8c9aea2abaa0f21d8b5256cb713f2319dbc3f0af38ae4d477eaf7d377eb879db   058b0a78da98
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
DockerHub
What's the Node.js version?
running docker
What problem was encountered?
Azurite SAS blob upload does not work with Python lib.
Exception is produced: azure.core.exceptions.ServiceRequestError: Failed to parse
Same link works with HTTP call.
Steps to reproduce the issue?
Run
import uuid
from azure.storage.blob import generate_blob_sas, BlobSasPermissions
from azure.storage.blob import BlobServiceClient, upload_blob_to_url
from datetime import datetime, timedelta

host = 'http://localhost:10000'
account_key = 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=='
connect_str = f'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey={account_key};BlobEndpoint={host}/devstoreaccount1;'

blob_service_client = BlobServiceClient.from_connection_string(connect_str)
container_name = "quickstart" + str(uuid.uuid4())
container_client = blob_service_client.create_container(container_name)

PERMIT_ALL = BlobSasPermissions(read=True, add=True, create=True, write=True, delete=True, delete_previous_version=True, tag=True)

blob_client = blob_service_client.get_blob_client(container=container_name, blob='fname')
blob_sas_token = generate_blob_sas(
                blob_client.account_name,
                blob_client.container_name,
                blob_client.blob_name,
                account_key=account_key,
                permission=PERMIT_ALL,
                expiry=datetime.utcnow() + timedelta(hours=1),
            )

blob_url = f"{host}/{blob_client.account_name}/{blob_client.container_name}/" \
           f"{blob_client.blob_name}?{blob_sas_token}"

print(blob_url)
response = upload_blob_to_url(blob_url, b'content')
print(response)

After 90 second timeout you will get error:
http://localhost:10000/devstoreaccount1/quickstartda073f14-4a40-48fc-9168-639edac25860/fname?se=2021-04-28T03%3A44%3A25Z&sp=racwdxt&sv=2020-02-10&sr=b&sig=i8Id55OvUzE52QFsDVRlCgd7DtCqpBJhA%2Bdd%2BuXUKzM%3D
Traceback (most recent call last):
  File "test_upload.py", line 30, in <module>
    response = upload_blob_to_url(blob_url, b'content')
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/__init__.py", line 113, in upload_blob_to_url
    return client.upload_blob(data=data, blob_type=BlobType.BlockBlob, **kwargs)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/tracing/decorator.py", line 83, in wrapper_use_tracer
    return func(*args, **kwargs)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_blob_client.py", line 539, in upload_blob
    return upload_block_blob(**options)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_upload_helpers.py", line 95, in upload_block_blob
    return client.upload(
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_generated/operations/_block_blob_operations.py", line 217, in upload
    pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 216, in run
    return first_node.send(pipeline_request)  # type: ignore
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  [Previous line repeated 2 more times]
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/policies/_redirect.py", line 158, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_shared/policies.py", line 515, in send
    raise err
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_shared/policies.py", line 489, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/storage/blob/_shared/policies.py", line 290, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 76, in send
    response = self.next.send(request)
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/_base.py", line 108, in send
    self._sender.send(request.http_request, **request.context.options),
  File "/Users/vashu1/Library/Python/3.8/lib/python/site-packages/azure/core/pipeline/transport/_requests_basic.py", line 285, in send
    raise error
azure.core.exceptions.ServiceRequestError: Failed to parse: http://localhost:10000/devstoreaccount1/quickstartda073f14-4a40-48fc-9168-639edac25860/fname?se=2021-04-28T03%3A44%3A25Z&sp=racwdxt&sv=2020-02-10&sr=b&sig=i8Id55OvUzE52QFsDVRlCgd7DtCqpBJhA%2Bdd%2BuXUKzM%3D

Have you found a mitigation/solution?
Uploading file to Azurite via HTTP API
import requests
from datetime import datetime
import uuid

def upload_blob_to_sas(sas, data):
    x = requests.put(
        sas,
        data=data,
        headers={
            'Content-Type': 'application/octet-stream',
            'Content-Length': str(len(data)),
            'x-ms-version': '2020-02-10',
            'x-ms-blob-type': 'BlockBlob',
            'If-None-Match': '*',
            'User-Agent': 'azsdk-python-storage-blob/12.6.0 Python/3.8.9 (macOS-10.15.7-x86_64-i386-64bit)',
            'x-ms-date': datetime.utcnow().strftime("%a, %d %b %Y %H:%M:%S GMT"),
            'x-ms-client-request-id': str(uuid.uuid4()),
        }
    )
    return x

@vashu1
As you can upload the file to Azurite in another way, it looks Azurite works.
Would you please check what's the different of the request send to Azurite in the 2 ways?
Do you use the same blob endpoint, same sas in the 2 ways?
Besides that, would you please share the Azurite debug log for this issue if any?

@vashu1
I will close this issue as not hear from you from a long time.
Feel free to contact us again if you need any further assistance on Azurite.


UglifyJS warnings

Hi, there are some warnings on your code:
Condition always true [./~/pivottable/dist/pivot.js:9,0]
Dropping unreachable code [./~/pivottable/dist/pivot.js:11,5]
Dropping side-effect-free statement [./~/jquery-ui/jquery-ui.js:9273,0]
Condition always true [./~/pivottable/dist/gchart_renderers.js:5,0]
Dropping unreachable code [./~/pivottable/dist/gchart_renderers.js:7,5]
Condition always true [./~/pivottable/dist/export_renderers.js:5,0]
Dropping unreachable code [./~/pivottable/dist/export_renderers.js:7,5]
Condition always true [./~/pivottable/dist/pivot.es.js:5,0]
Dropping unreachable code [./~/pivottable/dist/pivot.es.js:7,5]

Thanks! These are normal I think... The ones in the first few lines of each file are likely due to the Universal Module Definition pattern (https://github.com/umdjs/umd) and the one from jQuery is not something I can fix :)


mkr.market isn't availible via some internet providers.

Some internet-providers in Russia doesn't load the page at all. I've been made to use VPN or proxy. My friend in Austria has the same issue.
There are no errors at browsers, they just show "The connection has timed out" notification after couple of minutes loading.

And http://maker-market.surge.sh is available.

@sant9ga in the future, we will not use mkr.market anymore. You should try the new website oasisdex.com . Also, as soon as it is possible to register a .eth domain on the ENS, we will remove mkr.market and oasisdex.com. If you have any problems, please also contact us on chat.makerdao.com.


1429 sync course to find

Context
nothing easy is left
Changes proposed in this pull request
wip
Guidance to review
structure, concept, ideas
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 [L] Serialize course to sync with search-and-compare


Moved ClusteringManagementServiceTest (and ClusterService.isConnected())

This PR is to move ClusteringManagementServiceTest from management module to clustered/it-tests module. This move required:

To switch to Galvan instead of passthrough
To make clustered/it-tests depend on the management libraries
To add additional server libs when starting galvan through sysprops (see gradle files)
To add the ability for services to know when the cluster service is (not) connected (see below...)

I run after some issues: several times, at cache manager close, if the cluster service stops BEFORE the management services, then the management scheduled threads are not aware of the closing of the underlying connection, and a lot of error stacktraces are printed each second because of a failure in sending notifications or stats to voltron.
So I added ClusteringService.isConnected()  so that dependant services can check if there exists a connection to a cluster.
For @gibsong : if you need to test some clustered stats, you can make your tests extends AbstractClusteringManagementTest. This class starts a cluster with all the management services wired, and also provides access to sendManagementCallToCollectStats() if you need to start statistic collector, plus a consumer if you need to access the stats sent to voltron by the Ehcache collector service.

test this please

@ljacomet @chrisdennis : are you ok with the first commit (ClusteringService.isConnected()) ?

Makes sense, is SPI so not too critical ... although that technically means this PR needs to wait for Ehcache 3.2.0-SNAPSHOT on master.

Do you know when 3.2.0-SNAPSHOT will be set on master ?
It is not critical for M&M byt @gibsong was waiting for this refactor to be able to write some tests regarding clustered stats (which needs also to have the management layer setup for galvan).

@anthonydahanne @ljacomet : The build should pass when Terracotta-OSS/terracotta-platform#147 will be merged and tc-plaform 5.0.6.beta7 will be released

tc-platform 5.0.6.beta7 released.
test this please

LGTM


New samples from kotlin-web-site

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/c102c6ae75cde7a819c28a4d22ef88129f857e62
Files:
docs/topics/sealed-classes.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/673c3a4b812e88505ebb565b5da86cbe3ac5d067
Files:
docs/topics/numbers.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/617d45a37ed56ad8127626d0279544888e529d51
Files:
docs/topics/iterators.md

New samples in a repository https://github.com/Kotlin/kotlin-by-example
Files:

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/44f2bdd7e29103e1c066f4e2b043365ac8b920fd
Files:
docs/topics/strings.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/ebed9fcf2bfaf98142bcae018470472d5be4a2b8
Files:
docs/topics/test-page.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/9f6f6c3cc0409262e50d8b72019ae7498ad2e8db
Files:
docs/topics/basic-syntax.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/a4c272491b185b4640ccc694baa140be0b2af709
Files:
docs/topics/k2-compiler-guide.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/7e5e16268aea290e7ef8d218e5918f7897dfd9fe
Files:
docs/topics/whatsnew-eap.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/96fddab8e226044b74ef6e27f28216def2b6b883
Files:
docs/topics/k2-compiler-migration-guide.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Files:
docs/topics/tour/kotlin-tour-null-safety.md
docs/topics/typecasts.md
docs/topics/collection-grouping.md
docs/topics/tour/kotlin-tour-functions.md
docs/topics/whatsnew20.md
docs/topics/tour/kotlin-tour-classes.md
docs/topics/delegation.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/d2b6eaa09161f0b2fed2450ecb3e1e16c3528ed4
Files:
docs/topics/exceptions.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Files:
docs/topics/basic-syntax.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Files:
docs/topics/basic-syntax.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/1ef645dc749686ee2e9d1a66c30f4d4ef055f211
Files:
docs/topics/null-safety.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/a587a1a2846937f5dea7da141c00f6a3e37687d6
Files:
docs/topics/null-safety.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Files:
docs/topics/whatsnew11.md
docs/topics/jvm/java-to-kotlin-collections-guide.md
docs/topics/basic-syntax.md


Support for auto long primary key

Currently, @PrimaryKey(auto = true) is only supported for primitive integer, as stated in the documentation:

Tell Orma that the primary key is automatically assigned if the primary key is a primitive integer type. If true, any value you set to this column will be ignored in {@code INSERT}.

Why not add support for long, since SQLite returns long values when inserting?

You can use long, short and byte as well as int for @PrimaryKey.
Sorry to my poor English. How should I describe about it? "if the primary key is primitive integers`" is better?

I would explicitly write the compatible types, because "primitive integer" in java is "int".

Tell Orma that the primary key is automatically assigned if its java type is either "int", "long", "short" or "byte".


Set up GitHub Pages and deploy the docs

The project now has the workflows to deploy the documentation to a branch called gh-pages, but we need to perform the first deployment and set up the repo to use GitHub Pages by following these instructions. Once the GitHub Pages is set up please update the repo's About section to display the new link.

[x] Deployment to the gh-pages branch
[x] Set up GitHub Pages

Instructions

[!WARNING]
Before starting with the process, you need to add a new branch called gh-pages. This branch needs to have that name to ensure the workflows can deploy successfully. You can create it manually, or, in case you have the new workflows, it will be created automatically after the first deployment (Better option).

Once you have the branch gh-pages created, you can follow the following steps:

Navigate to your site's repository
Click Settings
Go to Pages
Select Deploy from a branch, under the Source section on Build and deployment
Select the gh-pages branch and the / (root) folder in the Branch section on Build and deployment

The default URL where you can find your site is https://qiskit-extensions.github.io/mthree
For further information, you can see the GitHub Pages Quickstart and https://github.com/Qiskit/ecosystem/issues/578.

https://qiskit-extensions.github.io/mthree/


unrealistic memory allocated by streaming on modified q17 with date as group key

Describe the bug
Increased up to 500GB over 3 hours. This is just a screenshot of a quick repro, in a short window of time:

To Reproduce
CREATE SINK nexmark_q17 AS
    SELECT auction,
           CAST(date_time AS DATE)                           AS day,
           count(*)                                                   AS total_bids,
           count(*) filter (where price < 10000)                      AS rank1_bids,
           count(*) filter (where price >= 10000 and price < 1000000) AS rank2_bids,
           count(*) filter (where price >= 1000000)                   AS rank3_bids,
           min(price)                                                 AS min_price,
           max(price)                                                 AS max_price,
           avg(price)                                                 AS avg_price,
           sum(price)                                                 AS sum_price
    FROM bid
    GROUP BY auction, CAST(date_time AS DATE)
    WITH ( connector = 'blackhole', format = 'append_only', force_append_only = 'true');

Expected behavior
We need to set a cap on this in our bench environments. How is streaming memory allocated? I was under the impression it just use the machine's RAM, and won't exceed until 500GB.
Should not use so much memory too, just few hundred MB according to similar q17 query memory profiles.
Additional context
Ctrl-f from memory allocated by streaming:
grafana.pdf
Machine:

C5.2x large. (16 GB RAM 8 vCPU)
Linux

Another anomaly I encountered. This benchmark took 3 hours but didn't finish, even with a nearly 2x throughput of 380,000r/s compared to normal q17.
On the other hand, with normal q17, throughput was just 210,000r/s, but it finished in an hour and a half.

just to confirm. is the throughput of bid?

Another anomaly I encountered. This benchmark took 3 hours but didn't finish, even with a nearly 2x throughput of 380,000r/s compared to normal q17.
On the other hand, with normal q17, throughput was just 210,000r/s, but it finished in an hour and a half.

just to confirm. is the throughput of bid?

Source throughput. Can take a look at the grafana pdf. Although its truncated, it has the same figures.

This benchmark took 3 hours but didn't finish

Is it deployed by risedev? not kube-bench
And it didn't crash halfway and recovered, did it?

This benchmark took 3 hours but didn't finish

Is it deployed by risedev? not kube-bench And it didn't crash halfway and recovered, did it?

Yes, risedev with configurations listed here: https://github.com/risingwavelabs/flink-bench/blob/nexmark/standalone/scripts/risedev-profiles.user.yml

Another anomaly I encountered. This benchmark took 3 hours but didn't finish, even with a nearly 2x throughput of 380,000r/s compared to normal q17.
On the other hand, with normal q17, throughput was just 210,000r/s, but it finished in an hour and a half.

just to confirm. is the throughput of bid?

Source throughput. Can take a look at the grafana pdf. Although its truncated, it has the same figures.

And it didn't crash halfway and recovered, did it?

Sorry I missed the second question. But I don't think so. The source throughput was consistently above 300,000r/s just before I killed it.

New grafana + heap profile: https://www.notion.so/risingwave-labs/15bd2d5182e94df7ad54077aa7abbb7b?pvs=4.

I'm a little confused by the figure 500GB. How can the memory usage reach 500G when the EC2 has only 16 GB RAM

+1 confused. Is this an issue of statistics?

+1 confused. Is this an issue of statistics?

That seems to be the issue. Let me update to issue title to reflect that.
The other anomaly is why it took so long to run, >3 hours instead of 1.5 hours.
The strange thing is that other similar queries, e.g. unmodified q17 does not have this issue, the memory profile looks normal:

https://www.notion.so/risingwave-labs/bd7f2868eead4ba7ae637309a3e5f014?pvs=4

Same issue on the following query:
CREATE SINK nexmark_q17 AS
    SELECT auction,
           count(*)                                                   AS total_bids,
           count(*) filter (where price < 10000)                      AS rank1_bids,
           count(*) filter (where price >= 10000 and price < 1000000) AS rank2_bids,
           count(*) filter (where price >= 1000000)                   AS rank3_bids,
           min(price)                                                 AS min_price,
           max(price)                                                 AS max_price,
           avg(price)                                                 AS avg_price,
           sum(price)                                                 AS sum_price
    FROM bid
    GROUP BY auction
    WITH ( connector = 'blackhole' );

Does each source split has input incoming?
Is it possibly related to #8451 (comment), I am not entirely sure about the context though

I think not if we do not define the watermark on the source. The watermark here is the streaming system’s watermark instead of the watermark in memory management

Encountered in q5 too.

I'm a little confused by the figure 500GB. How can the memory usage reach 500G when the EC2 has only 16 GB RAM

It's possible since virtual memory space is more than physical memory.

Can anyone else reproduce this? Or observe this phenomenon? Seems like on different machines with the same specs I can't reproduce it again 😕.

Spawning a new machine to try and reproduce the same results.
Taking a closer look, maybe there's some other difference...


How can I get latest shipped changes of v4?

Hi,
As you said before, in official blog post (Bootstrap 4.3.0, 11 Feb 2019), there is a "v4-dev" branch for tracking v4 development changes, and a new "master" branch for next major release (v5) developments.
Now, my question is:
How can I get latest shipped changes (marked as backport-to-v4) of Project v4.3.2?
The "v4-dev" branch has not been updated since 19 days ago (until today: 15 Apr 2019).
I apologize, I'm not good in English.

Just checkout the v4-dev branch git clone https://github.com/twbs/bootstrap.git -b v4-dev. There's a PR pending with further v4 updates, but it needs some time before merged.

I am confused...😜
Does it mean there are shipped changes on "Project v4.3.2" but they have not been merged to "v4-dev" branch yet?
Why they have been marked as shipped?!

No, v4-dev only includes merged stuff.

"shipped" means it's released. v.3.2 is not shipped yet. it's the one that's now in progress, and will be shipped next.

No, v4-dev only includes merged stuff.

Ok, Thanks.

"shipped" means it's released. v.3.2 is not shipped yet. it's the one that's now in progress, and will be shipped next.

I understand now (I hope so...).
It seems some BS's development approaches have changed for v4.3.2.
In near past (before 4.3.2 project), I remember, there was 4 or 5 task columns in project page, and when a task had been moved to the last column, I could tracked it as committed in branch's history; But now, tasks of last column, have not merged to v4-dev branch yet.
This made me confused.


Add "ctrl" as valid input to scrollWheelZoom Map option

Checklist

[X] I've searched through the plugins to make sure this feature isn't already available, or think it shouldn't require a plugin.
[X] I've searched through the current issues to make sure this feature hasn't been requested already.
[X] I agree to follow the Code of Conduct that this project adheres to.

Motivation
I am currently building an interactive map using leaflet. The experience has been fantastic. I am now trying to disable the scrolling zoom behavior, as my map covers a majority of the viewport. However, I still want to retain the "pinch gesture" behavior. On a mac, this is handled as a "Ctrl + scrollwheel" event.
Suggested solution
Add "ctrl" as a valid input for the scrollWheelZoom Map option by adding the following snippet to the top of the  _onWheelScroll(e) handler located at src/map/handler/Map.ScrollWheelZoom.js:
// Handle "ctrl" option
  if (map.options.scrollWheelZoom === 'ctrl') {
    // Allow zooming only if Ctrl key is pressed (indicating a pinch gesture)
    if (!e.ctrlKey) {
      return; // Ignore the scroll event if it's not a pinch gesture
    }
}

Alternatives considered
No response

Can i work on this?


Improve Share text

Edit text when users share their profile link

This seems like a good place to start. I believe I need the real firebase creds to get started right?

Hey @kevinamick you're more than welcome!
I can hook you up with the FB creds. Wanna join the Slack so we can chat more?
https://join.slack.com/t/contacttracingapp/shared_invite/zt-dc6x0qxg-epi0LpT8zJM~VL3ss365Fg

@kevinamick Files you need are here: https://github.com/ContactTracing-app/Frontend/blob/master/src/app/ShareView/IconList.tsx
@pongponk is drafting the new string…

This is me on Contact Tracing App. Join me so we can keep each other safe {link}

Closed with #54


Activate plugin for unsaved buffers

It would be great if the plugin could be activated for unsaved buffers - that way, users can quickly count words from text inserted e.g. from the clipboard.

That sounds like a great addition, PR welcome :)
On Fri, Sep 18, 2015 at 10:36 AM, Clemens Brunner<EMAIL_ADDRESS>wrote:

It would be great if the plugin could be activated for unsaved buffers -
that way, users can quickly count words from text inserted e.g. from the
clipboard.
—
Reply to this email directly or view it on GitHub
https://github.com/nesQuick/atom-wordcount/issues/42.

Huge thanks to @smaxtastic for adding it, I'm going to bump a new version asap :+1:

Awesome, thanks @smaxtastic!


Chore/response headers

Requires #58 to be merged first as it builds on top of it.

Coverage decreased (-2.4%) to 86.957% when pulling d2f4eddd283dfc8836c76d79442c5f7dd734472e on chore/response-headers into 19fb718dd1e0bba3d84754c76b2ca31dba283497 on master.


Candidate Issues for stabilization sprint

We plan to have a minor sprint for stabilization, the purpose of the sprint is to work on tech debt, bugs, CICD, etc. No new features are expected. By introducing this minor sprint, we give everyone a pause for the next big release, enjoy the minor sprint =)!
https://github.com/microsoft/nni/labels/v2.9.1
Release manager: @Louis-J
Release start date: TBD
Feature freeze date (at most 30 days): 10.14
Code freeze date: 10.17
First test package (1 week since feature freeze): 10.18
Release date (3 weeks since feature freeze): TBD 11.14
Training Service

[x] p0 - Does not support non-English path ~12/10 #5164  @Lijiaoa , bugbash: complete
[ ] p2 - #5064

HPO

[x] p0 - WebSocket connection may broken during long run ~12/10 #5166  @Lijiaoa , bugbash: complete
[x] p1 - Make anneal optional  ~13/10 #5165 @Bonytu , bugbash: complete
[ ] p0 - lag after long run
[ ] p2 - Assessor.trial_end() is not invoked if no metrics sent
[ ] p2 - Make REST timeout configurable

NAS

[x] p0 - Dedup for evolution search #5092 @ultmaster reviewing @liuzhe-lz , bugbash: complete
[x] p0 - #5117 #5135 @ultmaster reviewing @J-shang , bugbash: complete
[x] p0 - [nas] fix issue introduced by the trial recovery feature #5109 ~30/9 @QuanluZhang  reviewing @ultmaster, bugbash: complete
[x] #5119 @ultmaster  ~10/10 reviewing @QuanluZhang , bugbash: complete

Model Compression

[x] p1 - verify issue #3514, fix if there are any problems @J-shang @Louis-J , bugbash: complete

ModelSpeedup

[x] p0 - speedup rand_like_with_shape is easy to overflow when dtype=torch.int8. @J-shang  ~30/9 waiting for #5138 pr: #5140 Pruning detectron2's Faster R-CNN #4875 #5136 @J-shang ~28/9 pr: #5140 reviewing @QuanluZhang , bugbash: complete
[ ] p2 - Autoinfer can not deal with some op, sparsity cannot propagate through these ops, like torch.nn.functional.interpolate @J-shang move to 3.0
[x] p0 - torch._C.parse_schema in pytorch < 1.9.0 do not produce enough information. Writing a schema parser needed #5131  @Louis-J  ~25/9 reviewing @J-shang , bugbash: complete
[x] p0 - a bug in speedup propagate: executing random_init the view tensors causes error. #5018 @Louis-J  reviewing
https://pytorch.org/docs/stable/tensor_view.html#tensor-views @J-shang , bugbash: complete
[ ] p1 - a bug in speedup replace_module: #4991. @Louis-J ~10/10
[ ] p2 - refactor the inference process in speedup: in 'speedup support list/dict inputspeedup doesn't support list/dict input', #5107, solving #4998 #5097 #5130 @Louis-J
[ ] p2 - ~~speedup doesn't support registered buffer. @Louis-J
[ ] p2 - speedup get correct masks in cpu but wrong masks in gpu. #4945 @Louis-J

WebUI

[x] p0 - HPO experiment hyper-parameters page error. · Issue #5127 ~28/9 reviewing @liuzhe-lz , bugbash: complete
[x] p0 - #3549 ~30/9 @Louis-J , bugbash: complete

NAS

#5119
#5117
#5092

p1 - a bug in speedup replace_module: https://github.com/microsoft/nni/issues/4991. @Louis-J ~10/10
any progress in this？


Improve release process in the contributing guide

CI checks are failing for an unrelated reason relating to MapBox access tokens, which is being fixed elsewhere. Therefore I'm going to land this pull request despite lack of greenery.


Unknown column type "timestamp" requested

Laravel Version: 5.3.24
PHP Version: 7.0.12
Database Driver & Version: 10.1.19-MariaDB

Description:
When trying to update a column with the type of timestamp, it fails with this exception:
[Doctrine\DBAL\DBALException]
  Unknown column type "timestamp" requested. Any Doctrine type that you use has to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the known types with \Doctrine\DB
  AL\Types\Type::getTypesMap(). If this error occurs during database introspection then you might have forgot to register all database types for a Doctrine Type. Use AbstractPlatform#registerDoctrine
  TypeMapping() or have your custom types implement Type#getMappedDatabaseTypes(). If the type name is empty you might have a problem with the cache or forgot some mapping information.

Steps To Reproduce:

Get clean install of Laravel running laravel new migration-test
Make new migration file php artisan make:migration test --table=users
Add this line of code to it: $table->timestamp('created_at')->change();
Run php artisan migrate

FIX
Doctrine refuses to support MySQL-specific column types like this. So therefor I created a Laravel Package to fix it.

This is an issue with doctrine, if you check the issues history in this repo you'll find many similar reports, it all depends on what doctrine supported/haven't supported yet/won't support.

I wanted to change all timestamps to nullable as due to the change in how the timestamp column type acts, I'm unable to perform migrations. I decided to attempt to change the columns but I'm told that I need to install doctrine/dbal. After doing so, it tells me timestamp isn't a valid column type.
So as a result, I have to change each column manually as I can't use a migration to do so.
What's the deal with this? I need to take a break because I'm fuming that not only did MySQL implement a breaking change but Laravel won't even let you rectify the issue.

@JTallis As @themsaid says, this is an issue with doctrine/dbal, not with Laravel itself.

For those who installed the Package created by OP and wanted to change a timestamp into nullable (just like I did) like:
$table->timestamp('ClaimedAt')->nullable()->change();

and encountered this error:
Syntax error or access violation: 1067 Invalid default value for 'ClaimedAt' (SQL: ALTER TABLE my_table CHANGE ClaimedAt ClaimedAt TIMESTAMP NULL DEFAULT 'CURRENT_TIMESTAMP')

All you have to do is add a default value:
 $table->timestamp('ClaimedAt')->nullable()->default(null)->change();

and it should work.
Reverting it from nullable to use the current timestamp doesn't need to call default tho:
$table->timestamp('ClaimedAt')->nullable(false)->change();

should work.
Just sharing it here just in case someone is searching for the same question.

For everyone who is still coming across this issue via Google or something, there currently is an official way to support this. See this part of the docs.
Basically, you need to add the following to your config/database.php file:
'dbal' => [
    'types' => [
        'timestamp' => TimestampType::class,
    ],
],

For everyone who is still coming across this issue via Google or something, there currently is an official way to support this. See this part of the docs.
Basically, you need to add the following to your config/database.php file:
'dbal' => [
    'types' => [
        'timestamp' => TimestampType::class,
    ],
],

Make sure you add use Illuminate\Database\DBAL\TimestampType; as well ;)

use Illuminate\Database\DBAL\TimestampType;
'dbal' => [
'types' => [
'timestamp' => TimestampType::class,
],
],

use Illuminate\Database\DBAL\TimestampType;

'dbal' => [
    'types' => [
        'timestamp' => TimestampType::class,
    ],
],

I am wondering why this hasn't been added by default in the config file?!?

@tjodalv Likely because Laravel 11 removed the dependency on DBAL by default.


Include boundary scores in JSON download

Include metadata e.g. local authority from geojson -- see if there's a link for id

Remember attribution re: LA boundaries

Provide all scores rather than top 10.

{ id, name, count }

done still need to add in ids though: #50


Highlighting comments makes them unreadable

When selecting comments they become unreadable.
All three dark modes:

Light Mode

Is there a way to dynamically change comment colour based on highlight to account?

Hey 👋, thanks for raising this.
On my installation, the highlights currently look like this:
Mocha

Latte

which don't seem nearly as bad as the highlights raised in your issue. Could you please screenshot your settings like mine down below?
The path is File > Settings > Editor > Color Scheme > General
Within the highlight box, it should be Editor > Selection Foreground

Hi please find attached for both latte and mocha. No settings have been changed and the restore defaults setting is not selectable as nothing has been changed.

Sorry realised I hadn't applied mocha but the contents are still the same

Huh that's quite interesting, I can reproduce it on my local installation now but when debugging the code (running another IDE for development)... it works as expected o.o
I think I'll need to do some extra digging on this!

This should be closed with the release of `v2.0.2!
Please allow up to 2 business days for it to appear on the marketplace! If you can't wait, you can download the jar from the release and import it into your IDE. Thanks again for raising this!


cant download with brightcove format

brightcove format isnt downloading , with this link:
http://reshet.tv/Shows/Survivor/videomarklist,241903/
WARNING: Falling back on generic information extractor.
[generic] videomarklist,241903: Downloading webpage
[generic] videomarklist,241903: Extracting information
[download] Destination: _-.unknown_video
[download] 100% of 109.16KiB in 00:00

Superseded by #7652


preTokenGenerator Lambda code gets replaced with older code on (unrelated) amplify push

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
12.1.1
What operating system are you using?
Pop Os
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
no
Describe the bug
I noticed that code of my preTokenGenerator Lambda somehow changes to older code, when I do amplify push that does not add any changes to this Lambdas code. I see this when I download the deployment package of the preTokenGenerator Lambda.
When I do an arbitrary change (add a row change for example) and do amplify push, the function gets updated correctly. However when I add a change to another function and do amplify push -y, I see how older version of my code gets applied to the preTokenGenerator Lambda, even though amplify status too shows no change. From CloudTrail I can see that the preTokenGenerator Lambda gets updated (UpdateFunctionCode20150331v2) as a part of the amplify push, that should not have changed anything in this function. amplify status at this point still shows no changes, but when I actually check the code in Cloud, it has changed.
The preTokenGenerator Lambda is added to the project with CLI using the update auth flow, where I add Pre Token Generation trigger.
This now seems to happen consistently to me. Pre token generator Lambda gets somehow reverted to older version as soon as I do amplify push changing some other function, but not it.
Expected behavior
The Lambda with no changes should remain as it is.
Reproduction steps

Have a Pre Token Generator Lambda trigger, added with update auth flow
Make a change that does not affect this Lambda
Old code somehow gets applied to the function in the Cloud
Still at this point amplify status shows no changes.

Project Identifier
f59e77335650fce92677ec2970143a9b
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

My problem was that locally my team-provider-info.json pointed to an older release for the preTokenGenerator Lambda. I was not aware that it indicates which code gets released, and I had formed a habit of often just discarding changes in that file.


Error when complie

[ERROR] Failed to execute goal on project fingernft-api: Could not resolve dependencies for project com.fingerchar:fingernft-api:jar:0.1.0: Could not find artifact com.fingerchar:fingerchar-encry:jar:0.1.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
How can i fix these error

缺少jar包原因  文件我已经传上去了 重新pull试试

I have uploaded the file because of the lack of jar package and try to pull again.
Got it, thank you


Mouse gestures don't respond

Description of the new feature / enhancement
Mouse scroll gestures are supposed to work in the app.
Scenario when this would be used?
Generally when you need to scroll within the app.
Supporting information
No response

@niels9001 I thought this was fixed?

@Berops423 Is that happening in all apps or only in Settings?

It’s happening in the entire app.
From: Niels Laute @.>
Sent: Wednesday, January 11, 2023 1:46 PM
To: microsoft/PowerToys @.>
Cc: Berops @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] Mouse gestures don't respond (Issue #23212)
@Berops423https://github.com/Berops423 Is that happening in all apps or only in Settings?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/23212#issuecomment-1378776584, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANADLJWPQNDF6KBWCSN4MALWR22SPANCNFSM6AAAAAATUXXHEQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

I don’t think so, I am using the latest version of Powetoys, and it is still an issue.
From: Aaron Junker @.>
Sent: Wednesday, January 11, 2023 1:39 PM
To: microsoft/PowerToys @.>
Cc: Berops @.>; Author @.>
Subject: Re: [microsoft/PowerToys] Mouse gestures don't respond (Issue #23212)
@niels9001https://github.com/niels9001 I thought this was fixed?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/23212#issuecomment-1378766099, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANADLJSD6J2A3XGQPVZ6NL3WR2ZWLANCNFSM6AAAAAATUXXHEQ.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Same here.
To be specific, my scroll wheel does nothing when PowerToys settings, Peek, or possibly other components too are foreground.
Not even attempting to scroll a background window, which I have enabled (Windows Settings, Mouse, “Scroll inactive windows when hovering over them”).
In contrast, Windows Terminal is not affected.

OP’s problem can also instead be

#20961
#26629

Can you verify this is still an issue with v0.83.0 /needinfo


feat(apk): Created a new Android APK

PR related to this trello task --> https://trello.com/c/PsnAIhTr

:tada: This PR is included in version 1.6.0 :tada:
Your semantic-release bot :package::rocket:


Adding JSON/UTF-8 encoding property to hub message

Tested deployment of updated zip package in Azure portal.

looks great :)


Make attached deposit for adding a proposal equal to the proposal bond

This PR addresses https://github.com/near-daos/sputnik-dao-contract/issues/158.

Beautiful, thank you


nuxt vulnerable to Cross-site Scripting in navigateTo if used after SSR  v2.0

Describe the feature
nuxt vulnerable to Cross-site Scripting in navigateTo if used after SSR
v2.0 Can it be upgraded and repaired?
Additional information

[x] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[x] Read the contribution guide.
[x] Check existing discussions and issues.

Nuxt 2 reached End of Life.

On December 31st, 2023, Vue 2 will reach End of Life (EOL), and Nuxt 2 will follow on June 30th, 2024.

After that date, Nuxt 2 will continue to be available on the NPM package manager, but will no longer receive updates, such as security and browser compatibility fixes.

See more on https://v2.nuxt.com/lts


Add how to add a recipe documentation

Part of https://github.com/ESMValGroup/ESMValTool/issues/2786.
Add instructions on how to add a recipe to the recipe test workflow, to the documentation

@alistairsellar notes for this:
Adding a recipe to RTW:

Check it works offline on Jasmin (which should have complete set of obs and model data)

Offline means outside the RTW
Run with time and check time & mem at the end (esmvaltool provides memory estimate)

Get it running offline on Met Office: download obs and model data
Document memory and time on each platform in
Stop RTW on Met Office & Jasmin
Add to RTW on Met Office (update start date to today) & run
When compare fails:

copy output from $HOME/cylc-run/recipe_test_workflow/runN/share/cycle// to KGO directory (see opt/rose-suite-metoffice.conf)
then chmod a+w

Re-trigger compare task
If it succeeds, commit and push
Pull on jasmin and run
When compare fails:

copy output to /gws/nopw/j04/esmeval/KGO/
then chmod a+w

During completion of issue https://github.com/ESMValGroup/ESMValTool/issues/3608 using Alistair's instructions, i made some modifications to them to start shaping them further into final instructions. Hopefully they're helpful:

Run "esmvaltool run <recipename.yml>" (if it raises error about missing data, then data will need to be retrieved so it can be run).

Run the same on jasmin.

Take note of output of time and memory taken to run for both by checking cylc review .

Use "cylc stop" to stop the running rtw workflows.

Add the recipe to the RTW flow.cylc file.

Add time/memory usage to the metoffice.cylc and jasmin.cylc if they are larger than the defaults, this can be found in "job.time" in cylc review.

Run the workflow with cylc vip -O metoffice (it will fail).

Locate it's run folder.

Copy the output of that recipe run from that cycle (run/share/bin/cycle into KGO rootpath folder (KGO_ROOT_PATH="/data/users/esmval/KGO").
cp -r <directory of recipe from it's cycle in run directory>

Cd to KGO folder.

Use "chmod a+w  on recipe you've just added in KGO folder.

Run RTW again.

If the workflow now succeeds, commit and push.