Keyboard Manager and PowerToys Run requests/feedback

Keyboard Manager
Please give us the option to use single key shortcuts and one key = multiple keypresses remapping, as you can do on both Linux and macOS.
When I read that there were a keyboard manager and remapping function in PowerToys I got very excited, I've been waiting for this since the launch of Windows 10, but I'm pretty disappointed with it, function-wise, so far.
Since the launch of Windows 10, I've been wanting the standard function of the Windows key press to be remapped to the function of Win+Tab, but you can't use a single key for multiple key presses, you're forced to choose the Windows key plus another key.
So, I can't create a remapping or shortcut like "Win = Win+Tab" (and then Win+Tab = Win).
This is supposed to be for power users, yet, so far, it's no different from every other macro/remapping application out there for gaming.
Razer Synapse, Logitech keyboard/mouse software, and even AutoHotkey can do better than this, but something like AHK isn't safe in regards to gaming, as it might get you banned, so you have to disable and re-enable it every time you launch and exit online games.
PowerToys Run
I've been using Wox up until PowerToys Run came out, and Wox is even credited under Run's attribution section, which makes me wonder, why aren't the standard Wox settings included in Run?
Whenever I pressed Alt+Space in Wox, the search field was clear, which is something you could disable in the Wox settings, but in Run, you're given no other options than how many results it shows and changing the shortcut for opening Run.
Please give us more options, something like what Wox had.
Start Menu
I know that it is wishful thinking that you'll ever add this, but please, for the love of (the PC) god, let us disable the start menu!!!
When using macOS and different Linux distros alongside Windows 10, the start menu feels so outdated.
At least give us the option to customize it further. My best-case scenario would be a simple button that opened the power function menu (sleep, shut down, restart), I don't need shortcuts to apps or folders, when I want to open an app I use Run (previously Wox) and when I want to open a folder, I open it through File Explorer or a custom keyboard shortcut.
I never, and I mean NEVER use the start menu, and with PowerToys Run (and Wox before that) I don't use the Win+s search function (or the taskbar search icon/box for that matter), it's 100% obsolete for me, so the start menu has absolutely no use for me.
If possible, I would have disabled it years ago and I'd much rather have the Windows key single press have a function that's relevant instead of being wasted on a little empty pop-up menu in the corner that I never use.
Comments
When all of that is said, I wanna thank you guys for bringing back PowerToys, and actually listening to feedback, these tools are great and will only improve as you add more functions! Great job to everyone working on this! 😄 👍

It's partially connected with #3894

per template, one topic per issue else stuff is too hard to close.  For the top issue, that was done added in with #3290


istioctl experimental: change the short of the precheck subcommand to start with uppercase

…etter
Please provide a description of this PR:
When we execute istioctl experimental -h, the help short is shown as follows. Except for the short of precheck, all the other subcommands start with uppercase letters. This pr modifiers it
xperimental commands that may be modified or deprecated

Usage:
  istioctl experimental [command]

Aliases:
  experimental, x, exp

Available Commands:
  add-to-mesh          Add workloads into Istio service mesh
  authz                Inspect Istio AuthorizationPolicy
  config               Configure istioctl defaults
  create-remote-secret Create a secret with credentials to allow Istio to access remote Kubernetes apiservers
  describe             Describe resource and related Istio configuration
  envoy-stats          Retrieves Envoy metrics in the specified pod
  injector             List sidecar injector and sidecar versions
  internal-debug       Retrieves the debug information of istio
  kube-uninject        Uninject Envoy sidecar from Kubernetes pod resources
  metrics              Prints the metrics for the specified workload(s) when running in Kubernetes.
  precheck             check whether Istio can safely be installed or upgrade
  proxy-status         Retrieves the synchronization status of each Envoy in the mesh
  remote-clusters      Lists the remote clusters each istiod instance is connected to.
  remove-from-mesh     Remove workloads from Istio service mesh
  revision             Provide insight into various revisions (istiod, gateways) installed in the cluster
  uninstall            Uninstall Istio from a cluster (uninstall has graduated. Use `istioctl uninstall`)
  version              Prints out build version information
  wait                 Wait for an Istio resource
  workload             Commands to assist in configuring and deploying workloads running on VMs and other non-Kubernetes environments

Hi @Fish-pro. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@Fish-pro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
44acc732eb6e4093793018e61009a47ea79f8912
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes


fix: fieldset copy func loss index set

construction fieldset bug

I don't think it fix root of the issue as few lines up  in code:
_vec = definition;

So probably issue is somewhere else but I may be wrong, can you elaborate on that ?

I don't think it fix root of the issue as few lines up in code:
_vec = definition;

So probably issue is somewhere else but I may be wrong, can you elaborate on that ?

in Field file the _index is private, so you can't set this prop, i find FieldSet(Field* definition) construct func set the index ,other don`t set, so if you construct by FieldSet(const FieldSet& source),the index is lost

Thank you for the explanation :+1:


Move Jeff Duda's MODE stats to METcalcpy

Currently the code for Jeff Duda's MODE stats lives in METexpress, but it should more correctly live in METcalcpy. I've already gotten everything into the correct format, accepting the same arguments that the rest of the METcalcpy statistical functions do, but I missed the code freeze deadline, so they will have to be moved once METcalcpy is open for development again.

Missed code freeze for METcalcpy for 5.0.0.  In next release.


Add method from 0.12 to syn::Attribute to minimize breaking change impact

This change preemptively adds syn::Attribute::meta_item(&self) -> Option<syn::MetaItem> to 0.11.x. At the moment, it always returns Some, but when 0.12 is released it may begin returning None in cases that MetaItem parsing fails. This is intended to go out as 0.11.12.

I think that we should probably word this as parse_meta_item  to point out that it's not zero-cost.

Calling it parse_meta_item suggests to me that it would return some Result type, rather than an Option. I'm not attached to the name, but I'd like to write some code that won't break when 0.12 ships.

I'd personally prefer a Result type to be honest.

Thanks. This design is going to change as we revamp syn to operate on Macros 2.0-style tokens rather than strings, so the API currently in master probably won't end up in 0.12 after all.

@dtolnay is there anywhere I can plug in on that discussion?

#142 and https://github.com/alexcrichton/syn and #rust-libs.


Add persistLanguage setting to web-ui account settings

This PR adds new setting to web ui account settings.
This settings enable users to decide if they want to persist the language in the backend and then no matter which device they use the web-ui it always use the same language.
If they decide not to persist language The web ui will use the query string locale parameter (that sent from the login page via url).
If there is no value from the qs the system will use the persisted value, and if there is no persisted value it will stay the same as before this PR.
Resolves: #1393 .

@sgratch

IMHO you don't need any changes here. The locale discovered by our intl scripts will be used as Redux store default. If localeFromUrl was detected then it will be used automatically (because locale from local storage should be cleared after disabling persistence)

Should we remove the locale property from the backend and local storage or just ignore it in case of disabling the persistLocale property?
In our last conversation we talked about ignoring the backend property...

@bamsalem
Few issues/comments:
Reset option issues (now that it's merged):

Does persist have a default value and should be reset as part of reset settings?
The Language menu option is still supporting reset option even if persist is disabled - and once clicking on reset, remote locale is saved/persisted. We need to ignore locale in case of persist=false or always set locale to default once setting persist=false.

IMHO Persist Language should have a default value and it should be true, so we should not ignore the language on reset.

Others:

When enabling the persist language before the save, the language menu is still disabled.

Fixed.

when disabling the persist locale and saving it, the save and reset settings buttons are both enabled.

I cant' reproduce it van you please review it after the latest changes and let me know if it's still reproduced?

When login for the first time after restart with persist = false, the language menu displays current selected language (why needed?) and language is saved/persisted.

After adding default value for persistLocale it should store the data because it should persist the locale and now I changed this code so it should not happen: https://github.com/bamsalem/ovirt-web-ui/blob/persist-language-task/src/sagas/options.js#L149-L155

I missed that part which we decided to avoid  saveLocaleToLocalStorage for both modes (persisted=true/fasle). I thought we remove local and remote storage only in case of persist=false.

we decided to avoid using local storage because it should be used only for error to fetch the locales from the backend,
in any other case it will replace the value from localStorage with the backend value, and can make confusion.

@bamsalem

Please fix the main comment based on up to date design

After playing a bit with persist=false and true, an extra "do not disturb" field appears. For reproducing, enable the persist locale and change the language and then apply (save) both:

Reset option issues (now that it's merged):

Does persist have a default value and should be reset as part of reset settings?
The Language menu option is still supporting reset option even if persist is disabled - and once clicking on reset, remote locale is saved/persisted. We need to ignore locale in case of persist=false or always set locale to default once setting persist=false.

IMHO Persist Language should have a default value and it should be true, so we should not ignore the language on reset.

Now when clicking on reset while persist=false, the actual used locale is changed to the one set via the url parameter and not the default English:

Others:

When enabling the persist language before the save, the language menu is still disabled.

Fixed.

+1, looks ok now

when disabling the persist locale and saving it, the save and reset settings buttons are both enabled.

I cant' reproduce it van you please review it after the latest changes and let me know if it's still reproduced?

It is still reproduced (mainly after reset), trying to record such a scenario.

When login for the first time after restart with persist = false, the language menu displays current selected language (why needed?) and language is saved/persisted.

After adding default value for persistLocale it should store the data because it should persist the locale and now I changed this code so it should not happen: https://github.com/bamsalem/ovirt-web-ui/blob/persist-language-task/src/sagas/options.js#L149-L155

+1, looks ok now

I missed that part which we decided to avoid  saveLocaleToLocalStorage for both modes (persisted=true/fasle). I thought we remove local and remote storage only in case of persist=false.

we decided to avoid using local storage because it should be used only for error to fetch the locales from the backend,
in any other case it will replace the value from localStorage with the backend value, and can make confusion.

But how we'll handle errors on fetching backend data in current case without the local storage?
Anyway, in case of a browser running 4.4.6 and then upgrading to 4.4.7, the local storage locale is never deleted.

Changes:

keep the language enabled when persistence is disabled. Reasons:

there is no link between server side persistence and ability to
change language in general. Merging both functionalities requires
extra effort to explain this to the user i.e. property should be
named similar to "Persist and enable language change".
leaving language active solves some corner cases i.e. when user
changed the language and toggled persistence flag at the same time

explicitly delete "options" property from local storage to clean-up
unused data
export inferred locale asynchronously to prevent overlapping
with current saveGlobalOptions saga

keep the language enabled when  persistence is disabled

In that case we need to indicate that changing the language is somehow not persistent otherwise it's confusing

It's the same case as with notifications. The locale is saved in the Redux store but not persisted on the server.

In addition I encountered 3 wrong scenarios:

It seems that all 3 were caused by the same issue -  locale being set to quickly (before persistLocale).

keep the language enabled when  persistence is disabled

In that case we need to indicate that changing the language is somehow not persistent otherwise it's confusing

It's the same case as with notifications. The locale is saved in the Redux store but not persisted on the server.

Yes and no. Technically it is the same. But from user perspective, changing the notification is always non persistent. But when changing the language, it depends on the language-persist settings which is on a different section so FMPOV it is confusing. If we always enable changing the locale, we somehow need to indicate if it's going to be persistent or not without the need to check the advanced section every time.

In addition I encountered 3 wrong scenarios:

It seems that all 3 were caused by the same issue - locale being set to quickly (before persistLocale).

Issue 1 is solved but 2-3 are still reproduced. We need to decide if this is the correct design: after reset settings is applied, should we treat it as after 1st login (url locale might be enforced) or should we store the default English locale and avoid setting the locale read from url?

A new issue found:
Reading the following locales from url fails: ?locale=pt_BR, ?locale=zh_CN

It's the same case as with notifications. The locale is saved in the Redux store but not persisted on the server.

Yes and no. Technically it is the same. But from user perspective, changing the notification is always non persistent. But when changing the language, it depends on the language-persist settings which is on a different section so FMPOV it is confusing. If we always enable changing the locale, we somehow need to indicate if it's going to be persistent or not without the need to check the advanced section every time.

What solution do you suggest?

-A new issue found:
Reading the following locales from url fails: ?locale=pt_BR, ?locale=zh_CN

This is not a regression (checked on commit https://github.com/oVirt/ovirt-web-ui/commit/c4b08d262f71283f4c1e1a5c3400ad5658eb635d)

@sgratch

When locale is set to English default and persist=false and then reset settings is done, the English locale new property is not created as it should, only persistLocale is updated to true.
When login with persist=false and locale used by url and then set "reset options", only the vmPortal.persistLocale is set to true while locale property=English is not created as part of reset settings. This leads to strange behaviors.

Issue 1 is solved but 2-3 are still reproduced.

Hopefully fixed (this time).
I was able to reproduce scenario 1 in a very specific use case only:

start with locale stored on the server side
disable persistence (this used to delete the option on the server but did not clear the ID in Redux)
during the same browser session reset options - this triggers regular save so existing ID was used
saving locale property failed due to invalid ID

After scenario 1 was fixed I was no longer able to reproduce scenario 2.

We need to decide if this is the correct design: after reset settings is applied, should we treat it as after 1st login (url locale might be enforced) or should we store the default English locale and avoid setting the locale read from url?

IMHO default state should be the same for all scenarios so English locale should be used.

@rszwajko

Yes and no. Technically it is the same. But from user perspective, changing the notification is always non persistent. But when changing the language, it depends on the language-persist settings which is on a different section so FMPOV it is confusing. If we always enable changing the locale, we somehow need to indicate if it's going to be persistent or not without the need to check the advanced section every time.

What solution do you suggest?

We can either add a tooltip in case the persist=false for notifying the user or maybe just add a successful operation message instead of "Changes to settings saved successfully!" for language only, e,g "Changes to language setting is not saved in the server"

-A new issue found:
Reading the following locales from url fails: ?locale=pt_BR, ?locale=zh_CN

This is not a regression (checked on commit c4b08d2)

Correct, let's open a separate issue for this.

issue 1 is solved but 2-3 are still reproduced.

Hopefully fixed (this time).

LGTM

IMHO default state should be the same for all scenarios so English locale should be used.

+1

@sgratch

We can either add a tooltip in case the persist=false for notifying the user

Done. Please check the screenshot below.

LGTM


Specify language version

Changing the CSharpOptions LanguageVersion from 'Latest' to 'CSharp7_3' adds the TargetFramework assembly attribute to the compiled plugin file specifying that it uses the .Net Framework version 4.8. Not super important, but without that it was causing dnSpy to load the latest .Net Core assemblies when I was trying to debug my plugins, which had weird side-effects. Nothing critical, feel free to ignore this if you want as this issue no longer affects me personally.

We can't limit the C# version of plugins. Maybe try adding TargetFrameworkAttribute to your plugin or something?


Global Admins do not have sufficient permissions to translate some fields

As a Global Admin, when trying to translate an existing campaign on thor, I'm seeing this message and an uneditable field "This field has been disabled because you do not have sufficient permissions to edit it." Even though these fields should be translatable per #4835
Seeing it for field_solution_copy, field_solution_support, field_pre_step_copy, field_photo_step, and field_post_step_copy.

Here is the user: https://thor.dosomething.org/user/3118757
Here are example campaigns: https://thor.dosomething.org/node/3316/edit/add/en/en-global and https://thor.dosomething.org/node/5651/edit/en-global.

We can work around this for launch by making people administrators instead of Global Admins. So making this 1.1.

Also seeing it for FAQ Answer fields and During/After tip copy fields.

Translation is enabled for these fields (see bottom portion of the screenshot)

@deadlybutter I think I was wrong about the field collections, they all look like long text fields, checkout if we did something special for field_secondary_call_to_action  that's a long text that also has translation enabled, does it work?


Indexed property support for all types including Float and Double

Realm should provide indexed property support for all types. The documentation states that only String and Int properties are supported: https://realm.io/docs/swift/latest/api/Classes/Object.html#/s:ZFC10RealmSwift6Object17indexedPropertiesFMS0_FT_GSaSS_

Thanks for the feature request @florianreinhart! We're already tracking this issue as #2188, so I'll be closing this one as a duplicate. Let's continue the conversation there.
Until we add support for this, can you share the use case that prompted you to look for Float and Double indexing? Indexing only really helps speed up certain types of queries relying on the indexed column, but otherwise doesn't expose any additional functionality. Everything you can do with an indexed property you can do without indexing. If you found a particular query to be slower than you needed, please post it here and we may be able to optimize it by other means.
Thanks!


Jamaica number flagged as invalid but correct on the NANP

Hi.
The following number is returned as 'INVALID' but i have clients telling me that this is a valid mobile number.
I've had a quick check on the NANP and they also tell me the range is a valid range for Digicel Jamaica.
Country/region affected : JAMAICA
Example number(s) affected :<PHONE_NUMBER>0
The phone number range(s) to which the issue applies : Unsure
The type of the number(s) : Mobile
The cost, if applicable: N/A
Supporting evidence - NPAnxxsource.com/nalennd.php
Any info would be appreciated.
Thanks.

@IainSutherland,
We can't connect to +1<PHONE_NUMBER>. Please provide any working number from this range.
We are not able to find any official evidences or similar numbers online.
https://www.nationalnanpa.com/reports/reports_npa.html
https://www.google.co.in/#q=site:JM+"%2B1+876+25"
We are not sure of the information present in npanxxsource.com.
Can you please provide any authoritative evidence for this 258 range? For example, government or phone carrier documentation released to the public.

Hi.
Thanks for getting back to me so quick.
When I call that number +18762588340 it rings but I get put through to a
messaging service so it seemed like a live number to me.
We check with you guys first and then against the NANP (
http://www.npanxxsource.com/nalennd.php) and usually if you say that it's
an invalid number the NANP will also tell us something like that number
entered is not a valid code or is inactive.
For this number I get:
Line From876 258-0000
Line To876 258-9999
Wireless BlockYes
NXX TypeDedicated to Cellular
Portable BlockNo
1,000 Block PoolingNo
Block ContaminatedNo
Block RetainedNo
Date Activated2010-04-10
Last Modified2010-04-10

Common NameClaro Jamaica Limited*
OCN001A
OCN TypeWIRELESS
NameCentennial Digital Jamaica Limited
AbbreviationCENTL DIG. JAMAICA
DBACentennial Digital Jamaica Limited
FKAParadise Wireless

AddressPO Box 71514
CitySan Juan
StatePR
Zip00936-8614
CountryJM
That's the only evidence I can find unfortunately. But I will keep looking
and see if I can find anything else.
Thanks,
Iain
On 12 August 2016 at 09:37, penmetsaa<EMAIL_ADDRESS>wrote:

@IainSutherland https://github.com/IainSutherland,
We can't connect to +1<PHONE_NUMBER>. Please provide any working number
from this range.
We are not able to find any official evidences or similar numbers online.
https://www.nationalnanpa.com/reports/reports_npa.html
https://www.google.co.in/#q=site:JM+"%2B1+876+25"
We are not sure of the information present in npanxxsource.com.
Can you please provide any authoritative evidence for this 258 range? For
example, government or phone carrier documentation released to the public.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1262#issuecomment-239391764,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARsI6K0Ohl0Sh_nvNN48M0VfDT-ZM5mmks5qfDDLgaJpZM4JiMdl
.

--
Iain Sutherland
Ops Director
3G Telecommunications Limited
t: 01133 910781
m: 07540 822872
Skype : iain_sutherland1

Hi.
The example number provided just called me so must be an active number. (I
guess they rang me back having seen a missed call from me from earlier).
This is the only proof this is a valid number I have got at the moment.
Thanks,
Iain
On 12 August 2016 at 09:49, Iain Sutherland<EMAIL_ADDRESS>wrote:

Hi.
Thanks for getting back to me so quick.
When I call that number +18762588340 it rings but I get put through to a
messaging service so it seemed like a live number to me.
We check with you guys first and then against the NANP (
http://www.npanxxsource.com/nalennd.php) and usually if you say that it's
an invalid number the NANP will also tell us something like that number
entered is not a valid code or is inactive.
For this number I get:
Line From876 258-0000
Line To876 258-9999
Wireless BlockYes
NXX TypeDedicated to Cellular
Portable BlockNo
1,000 Block PoolingNo
Block ContaminatedNo
Block RetainedNo
Date Activated2010-04-10
Last Modified2010-04-10

Common NameClaro Jamaica Limited*
OCN001A
OCN TypeWIRELESS
NameCentennial Digital Jamaica Limited
AbbreviationCENTL DIG. JAMAICA
DBACentennial Digital Jamaica Limited
FKAParadise Wireless

AddressPO Box 71514
CitySan Juan
StatePR
Zip00936-8614
CountryJM
That's the only evidence I can find unfortunately. But I will keep looking
and see if I can find anything else.
Thanks,
Iain
On 12 August 2016 at 09:37, penmetsaa<EMAIL_ADDRESS>wrote:

@IainSutherland https://github.com/IainSutherland,
We can't connect to +1<PHONE_NUMBER>. Please provide any working number
from this range.
We are not able to find any official evidences or similar numbers online.
https://www.nationalnanpa.com/reports/reports_npa.html
https://www.google.co.in/#q=site:JM+"%2B1+876+25"
We are not sure of the information present in npanxxsource.com.
Can you please provide any authoritative evidence for this 258 range? For
example, government or phone carrier documentation released to the public.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1262#issuecomment-239391764,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARsI6K0Ohl0Sh_nvNN48M0VfDT-ZM5mmks5qfDDLgaJpZM4JiMdl
.

--
Iain Sutherland
Ops Director
3G Telecommunications Limited
t: 01133 910781
m: 07540 822872
Skype : iain_sutherland1

--
Iain Sutherland
Ops Director
3G Telecommunications Limited
t: 01133 910781
m: 07540 822872
Skype : iain_sutherland1

@IainSutherland
Thank you for taking the time to improve libphonenumber!
We are also able to connect to the above number now. Not sure why we are not able to connect to the number earlier. (May be we called from landline earlier)
We've accepted this issue and will fix this in an upcoming release.
http://www.npanxxsource.com/nalennd.php is not good enough source to update carrier details. We were not able to find any other evidence that this 258 range belongs to DigiCel.
Please share any supporting evidence (for example, a national numbering plan,
announcements from mobile carriers, news articles) so that we can update the
carrier details as well. Please see our contribution
guidelines

Fixed in 7.6.0.


Reduced CV list stopped updating?

Server-side, missing new items since around a month

Are you talking about the google sheet list or the esgst server list? There are new games added to the google sheet for reduced CV, but the list is missing a lot of games. Not sure how to check if the server updates his list.
Two examples of reduced CV games the google sheet is missing (but both are on the server list):

On the other hand the server is also missing some reduced CV games (which are on the google sheet):

So whether the server is online or not when you sync you are missing some games...

The sheet list should be updating normally, not sure why it's missing games.
But yeah, the server hasn't updated in a while due to some problems while migrating the server. I had a few busy weeks with university, but the semester is finally over (\o/), so I'll look into it today.

Just updated the server list. New items effective since November 1: https://rafaelgssa.com/esgst/games/rcv?date_after=2019-11-01&show_name=true

I checked a few games and everything seems to be fine. Thanks @rafaelgssa

Can you update it manually every now and then until you fix the cron issue? About once a week or so would already help a good deal, and it doesn't have to be a fixed schedule.

Looks like I won't be able to fix the issue in the server. The new server that I'm using uses Node.js instead of PHP and it doesn't have the option to set cron jobs for Node.js.
But, I found a way to keep it automatic by creating a task on Windows that runs the script through SSH. \o/
So it's back to normal. It's updating right now, so it should be done in about half an hour.

Looks like the spreadsheet is missing all the March adds, and by consequence the list is also missing them.
Whee. :P
As of this time, https://www.sgtools.info/lastbundled still lists all of them, so they're still mostly human-trackable. Mostly.

I haven't received any failure reports from Google Sheets, but the server is updating right now. Even though it's almost automatic, it looks like the connection expires every now and then, so I still have to manually fix it every once in a while.

It's less ideal than not breaking at all, but at least it's (if I get it right) a simple fix. :)
Thanks!

Not working again for about a week now.

Sorry, I forgot again, I have to figure out a way to make this fully automatic again. hehe

Anything added since the last sync a week ago seems to be missing, so whatever you did seems to have worked just that once and not stayed (semi-)automatic.
Is it just me or is it breaking more and more often?

I recently moved back to Linux and I haven't set up the automated tasks yet.

Ok. Cron jobs are re-configured on Linux and everything is automated again. I added a new parameter that shows you the recently added games: https://rafaelgssa.com/esgst/games/rcv?format_array=true&show_recent=true
There are also new fields in the output that are useful for knowing when the last update happened:

last_update_from_sg: Last full update (goes through all pages in https://www.steamgifts.com/bundle-games and should happen once per week)
last_update_from_sgtools: Last partial update (gets additions from https://www.sgtools.info/lastbundled and should happen every 6 hours)

I hope this finally fixes any issues.

The spreadsheet is also most likely going to be deprecated. The server is becoming more stable and the Patreon income also seems to be stable, so I don't see a reason for keeping the spreadsheet, as it's slower anyway.


Checking VectorSpace dimension in PCATransform.transform

This PR also addresses https://github.com/ma-ath/subspyces/issues/15


Is the settings.yml file reloaded on change?

I've found that after changing settings I need to run the "Reload Window" command to restart VSCode otherwise my changes to the remotes are not picked up from settings.yml.

Yep, it's broken!

I've found the issue! I'm using vscode.workspace.createFileSystemWatcher and found this in vscode source code:
// 1.64.x behaviour change: given the new support to watch any folder
// we start to ignore events outside the workspace when only a string
// pattern is provided to avoid sending events to extensions that are
// unexpected.

Since settings.yml is outside the workspace the extension doesn't get the events...


Cannot use alternative simulation runner with sanitycheck

So now when we have finally mdb runner implemented (see https://github.com/zephyrproject-rtos/zephyr/pull/24806) it's possible to use it for instantiation of nSIM-driven simulation instead of previously used arc-nsim runner. It's not that it solves any problem or is really required but given we will use it by default with MetaWare toolchain (once it gets merged) IMHO it's good to have is as generic as possible and if so have a way to use it with nsim_* plaforms.
And while it works perfectly fine for a single app or test this way:
west build -b nsim_hs samples/hello_world/
west flash -r mdb

The seem to be no simple way to run the sanitycheck script with mdb runner.
The first thing that comes to my mind is:
./scripts/sanitycheck --west-runner=mdb --platform nsim_em --test samples/hello_world/sample.basic.helloworld

But it says ERROR   - west-runner requires west-flash to be enabled. Ok let's add --west-flash:
./scripts/sanitycheck --west-runner=mdb --west-flash=mdb --platform nsim_em --test samples/hello_world/sample.basic.helloworld

now ERROR   - west-flash requires device-testing to be enabled. And only when we add --device-testing it starts to work:
 ./scripts/sanitycheck --west-runner=mdb --west-flash=mdb --device-testing --platform nsim_em --test samples/hello_world/sample.basic.helloworld
INFO    - JOBS: 48
INFO    - Building initial testcase list...
INFO    - 1 test configurations selected, 0 configurations discarded due to filters.

Device testing on:

| Platform   | ID   | Serial device   |
|------------|------|-----------------|

INFO    - Adding tasks to the queue...
INFO    - Total complete:    1/   1  100%  skipped:    0, failed:    0
INFO    - 1 of 1 tests passed (100.00%), 0 failed, 0 skipped with 0 warnings in 22.13 seconds
INFO    - In total 1 test cases were executed on 1 out of total 253 platforms (0.40%)
INFO    - 1 tests executed on platforms, 0 tests were only built.

Hardware distribution summary:

| Board   | ID   | Counter   |
|---------|------|-----------|

But now we sometime see funny messages about target device being busy:
DEBUG   - run test: nsim_hs_smp/tests/kernel/workq/work_queue_api/kernel.workqueue.api
DEBUG   - Waiting for device nsim_hs_smp to become available
DEBUG   - Waiting for device nsim_hs_smp to become available
DEBUG   - Waiting for device nsim_hs_smp to become available

which obviously makes no sense as we're talking about simulated target which we may have as many instances as we'd like.
What's even funnier if I try the same style execution of the sanitycheck but with our default arc-nsim in both --west-runner && --west-flash it will behave in the same way asking for --device-testing.
Probably I'm doing something wrong or do I?

@galak, @nashif any hints on how to use an alternative simulation runner?
BTW I guess soon it will become even more interesting as binaries for qemu_arc_{em|hs} will soon be compatible with nsim_{em|hs} (and vice versa) and so we'll be able to use mdb, arc-nsim & qemu runners with nsim_{em|hs} as well as with qemu_arc_{em|hs} equally well.

The main issue here is that we use flash with nsim to run a simulator, this is not something we do for example with qemu. Try to "flash" qemu, it is not supported.
nsim uses a different handler in sanitycheck than the one used for real devices, it just call a binary and does not use west directly, instead it uses 'make run' which calls west based on what was configured for the board.
i have an idea how to improve this, will submit a PR soon.

With all of my fixes (#29130) to MDB runner it is working now.

With all of my fixes (#29130) to MDB runner it is working now.


Zombies in Spain?

I see it too. Here's what's happening: Spain has stopped reporting historical data, so on the 24-25 of May the data for Spain starts coming from a different source (ECDC) which has different baseline numbers.
It's tricky because the ECDC data source does not have regional data, test counts and hospitalization information, so we can't just remove the old data source. Further, ECDC has clearly erroneous data for Spain in March. I'll try to setup the data pipeline to ignore national deceased counts from the official source and get them only from the ECDC, maybe those are a little more consistent.

Unfortunately, even the ECDC data appears to have the drop of ~2K in deaths. It must be an adjustment in the way the deaths were being counted (it would be the second time a big adjustment is made by this reporting country, the first one was in April for the way they counted positive tests).
I don't think there's a good way to deal with this problem. You either take the drop as the true value, or you adjust the data to keep it monotonically increasing but deviating from the official counts. Adjustments in the way metrics are computed are not uncommon, but they typically occur in count of confirmed cases and the change is smaller than 7%.
This is why we now provide both the "new_deceased" and "total_deceased" columns. If you want to ignore bogus values, use the "new_deceased" and skip negative values. If you want to keep the graphs as close to the official reporting as possible, use "total_deceased" but keep in mind that adjustments can happen.

Ok, thanks.

Closing for now, feel free to reopen if there's something else we need to do on our end


Add additional models

Hello @robbibt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pyTMD/io/model.py:

Line 213:39: E231 missing whitespace after ','
Line 247:39: E231 missing whitespace after ','


Added Custom Hook to get screen-size for responsiveness

🛠 Fixes Issue

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Try and fix the conflicts


Webchat stuck on "WEB_CHAT/SET_REFERENCE_GRAMMAR_ID"

Version:
latest using: https://cdn.botframework.com/botframework-webchat/latest/webchat.js
Describe the bug
We have a webchat window on our website that can be minimized/reopened (this keeps the same token, if still valid) or closed/reopened (this ensures we retrieve a new token). Our bot should greet us when we dispatch an event to the bot. When following a specific pattern, the webchat sticks on the "WEB_CHAT/SET_REFERENCE_GRAMMAR_ID" action and our bot does not greet us with our welcome message.
Steps to reproduce

Using the attached code, create an html file. - be sure to update the secret
Open the file in Chrome
Click on "Open Chat"
Click on "Minimize Chat"
Click on "Open Chat"
Click on "Close Chat"
Open developer console
Click on "Open Chat"

Expected behavior
You will not be greeted and, in the developer console, the last action written is ">>> HTML DISPATCH action: WEB_CHAT/SET_REFERENCE_GRAMMAR_ID"
Additional context
If you move the below line of code from the "closeChat" function to the "minimizeChat" function, the bot will properly greet us.
store.dispatch({type: 'DIRECT_LINE/DISCONNECT'});
simpleNoSecret.txt
[Bug]

@corinagum : Can you take a look?

@waltec888, Please take a look at our minimizable Web Chat sample. sample 06.a. This is using React.
For recomposing the UI, Web Chat only officially supports doing so via React, seen on our README.md
For further implementation questions, I recommend taking this conversation to Stack Overflow.


Test github integration

Testing github integration
Aha! Link: https://influxdb.aha.io/features/ENT2-25

open


Optimize ut for serialization model.

Integrate the unit test of the serialization module, code reuse.
Remove redundant unit tests and pojo classes.
Remove the useless pojo class in the common module.

related issue:
https://github.com/apache/incubator-dubbo/issues/2623

Codecov Report

Merging #2632 into master will decrease coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2632      +/-   ##
============================================
- Coverage     55.16%   54.58%   -0.58%
+ Complexity     5293     5077     -216
============================================
  Files           571      540      -31
  Lines         25521    25009     -512
  Branches       4532     4514      -18
============================================
- Hits          14078    13651     -427
+ Misses         9338     9273      -65
+ Partials       2105     2085      -20

Impacted Files
Coverage Δ
Complexity Δ

...dubbo/common/status/support/LoadStatusChecker.java
46.15% <0%> (-13.85%)
2% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyClient.java
72.88% <0%> (-10.17%)
12% <0%> (-1%)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-4.17%)
3% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

...he/dubbo/registry/multicast/MulticastRegistry.java
55.6% <0%> (-1.73%)
35% <0%> (-3%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...ache/dubbo/remoting/transport/mina/MinaClient.java
56.92% <0%> (-1.54%)
8% <0%> (-1%)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
77.2% <0%> (-1.48%)
29% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
58.33% <0%> (-0.84%)
30% <0%> (-1%)

...n/serialize/kryo/utils/ThreadLocalKryoFactory.java

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccce69e...6d9a8a5. Read the comment docs.

I'm happy to have a issue to investigate configuration issue for coverage stuff.

I agree.

@lovepoem @htynkn
I will send an email to ask other people in the community.
Maybe someone else has had a similar experience?

@htynkn @lovepoem
The unit test coverage of the response is now accurate, please check again.

It's LGTM.

Look Good To Me


refactor and remove time usage as it is no longer necessary

This is meant to be suggestions. Feel free to just take whatever you want, which might be nothing.
There isn't exactly a convention for naming generics-related stuff yet, but several packages, such as x/exp/slices, have pairs of functions for things that make sense to use with operators, one that uses the operators and one that allows the user to specify a function. This refactors to follow that pseudo-convention by renaming NewOrdInterval() to just NewInterval() and removing NewTimeInterval() completely. In lieu of that last one, an example has been added to the godoc comment for NewIntervalFunc() demonstrating how to deal with time.Times with a single-line function that the user can just provide if necessary. This removes the dependency on the time package, too.
While it would be nice, unfortunately, NewIntervalFunc(t1, t2, time.Time.Sub) is not possible because time.Time.Sub() returns a time.Duration, not an int, but maybe golang/go#21498 will get added in Go 1.19 or 1.20, which will simplify it. As a hacky alternative, it is also possible to do something like the following in order to allow direct usage of time.Time.Sub, though the code seems kind of... Well, it works, at any rate, but I don't really recommend it:
func NewIntervalFunc[T any, C constraints.Signed](x, y T, cmp func(T, T) C) Interval[T] {
	wrapper := func(t1, t2 T) int { return int(cmp(t1, t2)) }
	if cmp(x, y) < 0 {
		return Interval[T]{x, y, wrapper}
	}
	return Interval[T]{y, x, wrapper}
}

// Now it's possible to simply call NewIntervalFunc(t1, t2, time.Time.Sub) directly.

The pull request also moves Relation, its one method, and the Relation constants into a new file to make rampart.go a bit easier to read.

Thanks a lot for the contribution, your suggestions look good to me. I'll publish a new version with your changes as of v1.0.0


How to reply HTML message

How to reply HTML message:
****
google

@shine7430 Which chat network are you using?


Fix/contribution repository differentiation

Fixes https://github.com/microsoft/TypeScript-Website/issues/2534

[x] Fixes Incorrect internationalization contribution URL
[x] Adds utility functions to improve code readability and reuse

Thanks for sending this PR. Per #2804, I'm going to preemptively close this; the localization project is likely to be getting frozen and I'd like to get our PR count down to focus on the reduced scope described in that issue.


USHIFT-4746: Describe the resource after failed Oc Wait

/test e2e-aws-tests-arm

/cherrypick release-4.17


missing recent releases (> 0.2.0)

Recent versions are not being published on PyPI anymore (see https://pypi.org/project/neurokit/#history, most recent there is 0.2.0 which was added Sept 5th 2017), and new versions are not tagged here on GitHub either (see https://github.com/neuropsychology/NeuroKit.py/releases).
Based on current master, it seems like the latest version is 0.2.7 which corresponds to commit bba8ed9 (since that's where the version bump was done). But that doesn't include the bug fix from 8f166ad which was done shortly after...
Can you please i) tag releases on GitHub, ii) push releases to PyPI?
Letting people install straight from master without proper versioning results in a lot of confusion, which is easy to avoid by tagging releases.

@boegel You're absolutely right, I'll try to do the requested updates ASAP

@DominiqueMakowski Thank you very much!
Can you clarify which commit should be considered version 0.2.7?

All commits done after the version bump should be considered 0.2.7 (in spite of the merging of a pre-0.2.7 branch issue)

OK, so I'll go with current master (5dfa41d) as 0.2.7.


cannot import name 'gto' from 'pyscf' (unknown location)

Hi, I recently installed pyscf on windows using GitHub repository (I have some problem with the pip install pyscf). But whenever I am trying to use the pyscf it's showing an error named "cannot import name 'gto' from 'pyscf' (unknown location)". I then added the top pyscf directory to PYTHONPATH but the ipython in terminal showing a new issue named "module 'os' has no attribute 'sysconf'". Another one is that the notebook is not reflecting the change I have made to the Path. All screenshots are attached. I am stuck with these for 1 week; need urgent help.
Thank You
Himadri

PySCF does not support windows systems at the moment, you may use the windows subsystem for linux.
The os.sysconf error is because it doesn't exist on windows. You may try comment out the line CLOCK_TICKS = os.sysconf("SC_CLK_TCK"), and replace the line PAGESIZE = os.sysconf("SC_PAGE_SIZE") with PAGESIZE = mmap.PAGESIZE. But there may be other errors.

PySCF does not support windows systems at the moment, you may use the windows subsystem for linux. The os.sysconf error is because it doesn't exist on windows. You may try comment out the line CLOCK_TICKS = os.sysconf("SC_CLK_TCK"), and replace the line PAGESIZE = os.sysconf("SC_PAGE_SIZE") with PAGESIZE = mmap.PAGESIZE. But there may be other errors.

I see. Can you please point out why the updated path is not showing in the notebook?

Maybe this is related.

Thanks. It worked.

Hi @Lost-Volt , thanks for posting the issue here. Has it been answered? Then the issue can be closed.

Hi @Lost-Volt , thanks for posting the issue here. Has it been answered? Then the issue can be closed.

Yes the issue has been resolved. Can be closed now.


Update app name/link on Installation page

The description on installation page still shows old probot/configurer. (GtiHub account > Seetings > Applications > Setings > Configure)
Shouldn't be probot/settings ? :smiley_cat:

Thanks @whizark, I've updated it!


Missing fileToPDF.fileTypesList in every translation

The placeholder for fileToPDF.fileTypesList is missing in every translation files (included the template messages_en-GB.properties one). This could be placed in each .properties file or it could be placed directly in file-to-pdf.html.
There is also a messages.properties file which, however, never seems to be called in which the only reference is just fileToPDF.fileTypesList

Seems the defaulting functionality must have changed, I will add this direct to html since it doesn't need translation, thanks for pointing this out


sendLocalReply:call modify_headers before call encode_headers

To fix https://github.com/envoyproxy/envoy/issues/12690
If ext_authz response status is "denied", the response headers may be copied to the client response.  But if local_reply_config" is specified, "content-type" and "content-length" should be generated from the local_reply_config`.  But due to a bug, these two headers are overridden by the ext_authz response headers.
Detail changes:
ext_authz passes "modify_headers" to http::Utilitty::sendLocalReply(), but it is used in encode_headers function.
http::Utilitty::sendLocalReply() sets "Content-Type" and "Content-Length" headers, then call the encode_headers function. In ext_authz use case,  encode_headers functions has modify_headers function that may modify Content-Type and Content-Length headers.
Risk Level: Low
Testing:  Added integration test.
Docs Changes: N/A
Release Notes: N/A
Fixes #12690

Oops, seems like you need to merge main?

Assigning to @alyssawilk to take a quick look.

@alyssawilk PTAL

@alyssawilk PTAL

@dio any final thoughts and @mattklein123 want to take a look or you good with my LGTM?


CodeMirror SQL highlighting shows {}'s as errors

We are also missing some of the newer keywords like Qualify and Having. Is there a good way to pull a list of keywords with a DuckDB script where we could build a DuckDB-specific dialect for CodeMirror?
Thanks!

This will give you the list of keywords:
select * from duckdb_keywords();

I added curry braces to rouge a while back, but it takes a while for things to propagate.

@Alex-Monahan how do you feel about switching the docs site to a GitHub actions based build? Would mean we could just fix this right away, rather than wait ages for the bugfix to propogate

@Alex-Monahan how do you feel about switching the docs site to a GitHub actions based build? Would mean we could just fix this right away, rather than wait ages for the bugfix to propogate

Hmm, I don't know how different that would be from today! Would it impact local testing at all or could I still run jekyll serve on my local? If I can still do that, I don't see a reason why not!

@Alex-Monahan how do you feel about switching the docs site to a GitHub actions based build? Would mean we could just fix this right away, rather than wait ages for the bugfix to propogate

Hmm, I don't know how different that would be from today! Would it impact local testing at all or could I still run jekyll serve on my local? If I can still do that, I don't see a reason why not!

It wouldn't change anything for you locally no, just change how the deployed version is built slightly (technically it's already being built by GitHub Actions anyway, see https://github.blog/2022-08-10-github-pages-now-uses-actions-by-default/) it would just mean we can choose which versions of libraries it's built with, eg, rouge!
The only thing it would need from @hannes or @Mytherin is to flip the setting to support it (once the github action is configured in the repo)

That sounds good to me

Sounds great, thank you!