systemd/cpi.service: Add sysinit.target dependency to make sure /var is created

Noticed on RHEL CoreOS that the CPI service failed to start with :
"Cannot access lock file: /var/lock/cpictl.lock"
This was a timing issue where /var was not created yet and the symlink to /run/lock
was not present. Adding this as a suggestion from @cgwalters to fix this. This fix has been
tested with RHEL CoreOS.
Signed-off-by: Prashanth Sundararaman<EMAIL_ADDRESS>

/cc @sharkcz

/cc @stefan-haberland


Multistore issues

In the console , i am getting the issues
http://prntscr.com/me7s4q
Please check the screenshot

with the version of the ps_linklist module is v3.0.4
I can set footer links per store, its normal?


fix(toolchain): multiple fixes for cxx cross build and on macOS

Summary

Fix macOS build by using cc_shared_library but hide after an alias and not turned on outside macOS.
Pass basic cc and ld flags to cross compilers, noticably (the below changes doesn't apply to non-cross builds, however they are already set by Bazel in those environments):

Decreases opt flags from default -O3 to -O2
Add security flags like -U_FORTIFY_SOURCE, -fstack-protector etc (please check sources for full list of flags)
Link to stdc++

Use a cleaner interface and remove the wrapper for cross tool path resolving.

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

https://github.com/Kong/kong/actions/runs/8845026358/job/24288452825?pr=12945

good run https://github.com/Kong/kong/actions/runs/8846615210/job/24292964007?pr=12945

Thanks for the effort @fffonion .


Using csi-cephfs-fyre playbook on a new FYRE cluster: (PVC's in Pending)

OCP version 4.6.1
Verified all pods were running in the rook-ceph namespace.
PVCs created using csi-cephfs are stuck in Pending state.

Output from playbook
csi-cephfs-playbook-log.txt

If this is repeatable, you may need to get common-services involved.
The install process has been working fine without common-services, it may be just your particular scenario with installing Common Services that is breaking. I don't install commnon services.
I just finished using the play to install onto a fyre cluster and was able to create a PVC without problems.
I am not a rook/ceph expert, just wrappered in ansible play around an example install process the rook/ceph team provides in the repo to do the install of it.
General rook/ceph problems would have to go out to those supporting the repo https://github.com/rook/rook.

I have just created a NEW Fyre cluster and used the play to install.
I tried to create 3 PVCs, one for each storage class. They stay in pending.

@wkrapohl would you be able to login to my cluster to check it is as you expect?

As you simply asking for to much storage? By default you only get 600G.

I asked for 1G each for the PVCs
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  annotations:
    volume.beta.kubernetes.io/storage-provisioner: rook-ceph.rbd.csi.ceph.com
  selfLink: /api/v1/namespaces/rook-ceph/persistentvolumeclaims/my-ceph-block-claim
  resourceVersion: '56770'
  name: my-ceph-block-claim
  uid: b8435cc3-54b5-4e82-b0ab-6b9fccb480a6
  creationTimestamp: '2020-12-09T16:28:53Z'
  managedFields:
    - manager: Mozilla
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:53Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:spec':
          'f:accessModes': {}
          'f:resources':
            'f:requests':
              .: {}
              'f:storage': {}
          'f:storageClassName': {}
          'f:volumeMode': {}
        'f:status':
          'f:phase': {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:53Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            .: {}
            'f:volume.beta.kubernetes.io/storage-provisioner': {}
  namespace: rook-ceph
  finalizers:
    - kubernetes.io/pvc-protection
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: rook-ceph-block
  volumeMode: Filesystem
status:
  phase: Pending

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  annotations:
    volume.beta.kubernetes.io/storage-provisioner: rook-ceph.cephfs.csi.ceph.com
  selfLink: /api/v1/namespaces/rook-ceph/persistentvolumeclaims/my-csi-cephfs-claim
  resourceVersion: '56615'
  name: my-csi-cephfs-claim
  uid: 27f739b6-f5ab-4830-9f79-90a97cdaa304
  creationTimestamp: '2020-12-09T16:28:31Z'
  managedFields:
    - manager: Mozilla
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:31Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:spec':
          'f:accessModes': {}
          'f:resources':
            'f:requests':
              .: {}
              'f:storage': {}
          'f:storageClassName': {}
          'f:volumeMode': {}
        'f:status':
          'f:phase': {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:31Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            .: {}
            'f:volume.beta.kubernetes.io/storage-provisioner': {}
  namespace: rook-ceph
  finalizers:
    - kubernetes.io/pvc-protection
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: csi-cephfs
  volumeMode: Filesystem
status:
  phase: Pending

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  annotations:
    volume.beta.kubernetes.io/storage-provisioner: rook-ceph.cephfs.csi.ceph.com
  selfLink: /api/v1/namespaces/rook-ceph/persistentvolumeclaims/my-rook-cephfs-claim
  resourceVersion: '56415'
  name: my-rook-cephfs-claim
  uid: 88ab91e7-90c8-4177-8d31-0c64e9cb4e4d
  creationTimestamp: '2020-12-09T16:28:04Z'
  managedFields:
    - manager: Mozilla
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:04Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:spec':
          'f:accessModes': {}
          'f:resources':
            'f:requests':
              .: {}
              'f:storage': {}
          'f:storageClassName': {}
          'f:volumeMode': {}
        'f:status':
          'f:phase': {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: v1
      time: '2020-12-09T16:28:04Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:annotations':
            .: {}
            'f:volume.beta.kubernetes.io/storage-provisioner': {}
  namespace: rook-ceph
  finalizers:
    - kubernetes.io/pvc-protection
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: rook-cephfs
  volumeMode: Filesystem
status:
  phase: Pending

Where is the managed-nfs-storage sc coming from? Is it causing a problem? I do not have that on my clusters.

We have used the managed-nfs-storage sc successfully in the past before trying to use the csi sc.
I have removed the managed-nfs-storage sc but still they stay in pending.

I will rebuild the cluster without managed-nfs-storage sc, and see what happens.

Just install csi-cephfs onto my new 4.7 nightly fyre cluster
All pods running
[root@waltx47test-inf ~]# oc get po -n rook-ceph
NAME                                                              READY   STATUS      RESTARTS   AGE
csi-cephfsplugin-dv4jt                                            3/3     Running     0          8m53s
csi-cephfsplugin-k9zkb                                            3/3     Running     0          8m53s
csi-cephfsplugin-provisioner-5c65b94c8d-plx66                     6/6     Running     3          8m53s
csi-cephfsplugin-provisioner-5c65b94c8d-rdvbw                     6/6     Running     0          8m53s
csi-cephfsplugin-wdfk5                                            3/3     Running     0          8m53s
csi-rbdplugin-jlsck                                               3/3     Running     0          8m54s
csi-rbdplugin-km6gb                                               3/3     Running     0          8m54s
csi-rbdplugin-provisioner-569c75558-ggtcl                         6/6     Running     3          8m54s
csi-rbdplugin-provisioner-569c75558-l5txz                         6/6     Running     0          8m54s
csi-rbdplugin-r9zw5                                               3/3     Running     0          8m54s
rook-ceph-crashcollector-worker0.waltx47test.cp.fyre.ibm.c9g95b   1/1     Running     0          6m52s
rook-ceph-crashcollector-worker1.waltx47test.cp.fyre.ibm.cblcvd   1/1     Running     0          8m41s
rook-ceph-crashcollector-worker2.waltx47test.cp.fyre.ibm.crs2bk   1/1     Running     0          6m53s
rook-ceph-mds-myfs-a-5b75847949-gpc4h                             1/1     Running     0          6m54s
rook-ceph-mds-myfs-b-6c66d447c5-jq6pv                             1/1     Running     0          6m53s
rook-ceph-mgr-a-5fbf7b484f-q8thh                                  1/1     Running     0          7m26s
rook-ceph-mon-a-69dcd46b9b-fr5sv                                  1/1     Running     0          8m41s
rook-ceph-mon-b-6dd7885c4f-q9fdx                                  1/1     Running     0          8m32s
rook-ceph-mon-c-78944d795-7wpjx                                   1/1     Running     0          7m57s
rook-ceph-operator-59cbfb7c7c-z27qz                               1/1     Running     0          10m
rook-ceph-osd-0-5479587b8d-8hn7z                                  1/1     Running     0          7m16s
rook-ceph-osd-1-76d7df897b-pjn2c                                  1/1     Running     0          7m15s
rook-ceph-osd-2-b68c78cb9-bsd6z                                   1/1     Running     0          7m15s
rook-ceph-osd-prepare-worker0.waltx47test.cp.fyre.ibm.com-gvdm8   0/1     Completed   0          7m24s
rook-ceph-osd-prepare-worker1.waltx47test.cp.fyre.ibm.com-4jz8z   0/1     Completed   0          7m24s
rook-ceph-osd-prepare-worker2.waltx47test.cp.fyre.ibm.com-58cdc   0/1     Completed   0          7m24s
rook-discover-6dt7s                                               1/1     Running     0          9m48s
rook-discover-qsz6k                                               1/1     Running     0          9m48s
rook-discover-rxpzw                                               1/1     Running     0          9m48s
[root@waltx47test-inf ~]#

Storage classes are
[root@waltx47test-inf ~]# oc get sc
NAME                   PROVISIONER                     RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
csi-cephfs (default)   rook-ceph.cephfs.csi.ceph.com   Delete          Immediate           true                   11m
rook-ceph-block        rook-ceph.rbd.csi.ceph.com      Delete          Immediate           true                   11m
rook-cephfs            rook-ceph.cephfs.csi.ceph.com   Delete          Immediate           true                   11m

PVCs created are
[root@waltx47test-inf ~]# oc get pvc -n rook-ceph
NAME         STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
walt-ceph    Bound    pvc-7fbcc445-5f45-4cdf-8be5-37afbbcc7b14   1Gi        RWO            csi-cephfs        5m18s
walt-ceph2   Bound    pvc-eae95c01-e1eb-4714-96b8-ec60a12f14e4   1Gi        RWX            csi-cephfs        5m
walt-ceph3   Bound    pvc-d885802a-a54d-4f4d-9d32-3405db2cb5f2   1Gi        RWO            rook-ceph-block   4m35s
walt-ceph4   Bound    pvc-997f829f-624a-4802-a239-2e68424926ef   1Gi        RWX            rook-cephfs       4m13s

Thanks for the output. I will try to replicate.

Still have same problem.
I'm using OCP 4.6.6
[root@ib-sc-class-inf ~]# oc get po -n rook-ceph
NAME                                                              READY   STATUS      RESTARTS   AGE
csi-cephfsplugin-2d4z7                                            3/3     Running     0          5m5s
csi-cephfsplugin-5rxgl                                            3/3     Running     0          5m5s
csi-cephfsplugin-bln9s                                            3/3     Running     0          5m5s
csi-cephfsplugin-dxx48                                            3/3     Running     0          5m5s
csi-cephfsplugin-grqzc                                            3/3     Running     0          5m5s
csi-cephfsplugin-n4rdx                                            3/3     Running     0          5m5s
csi-cephfsplugin-pbjr7                                            3/3     Running     0          5m5s
csi-cephfsplugin-provisioner-5c65b94c8d-p7p92                     6/6     Running     0          5m5s
csi-cephfsplugin-provisioner-5c65b94c8d-pnmwl                     6/6     Running     0          5m5s
csi-rbdplugin-2zzkh                                               3/3     Running     0          5m6s
csi-rbdplugin-48gxq                                               3/3     Running     0          5m6s
csi-rbdplugin-7nzcm                                               3/3     Running     0          5m6s
csi-rbdplugin-8nc85                                               3/3     Running     0          5m6s
csi-rbdplugin-jtfrh                                               3/3     Running     0          5m6s
csi-rbdplugin-provisioner-569c75558-7mbdp                         6/6     Running     0          5m6s
csi-rbdplugin-provisioner-569c75558-prxl8                         6/6     Running     0          5m6s
csi-rbdplugin-q7snz                                               3/3     Running     0          5m6s
csi-rbdplugin-rs5lv                                               3/3     Running     0          5m6s
rook-ceph-crashcollector-worker1.ib-sc-class.cp.fyre.ibm.c7dnzm   1/1     Running     0          2m4s
rook-ceph-crashcollector-worker4.ib-sc-class.cp.fyre.ibm.c2rls2   1/1     Running     0          2m3s
rook-ceph-crashcollector-worker6.ib-sc-class.cp.fyre.ibm.c8tbth   1/1     Running     0          2m43s
rook-ceph-mds-myfs-a-5bd85bc445-qsp6j                             1/1     Running     0          2m4s
rook-ceph-mds-myfs-b-56b9c448c9-52vrd                             1/1     Running     0          2m3s
rook-ceph-mgr-a-55c6859669-zglzv                                  1/1     Running     0          2m43s
rook-ceph-mon-a-777f788b8c-6t2jn                                  1/1     Running     0          4m11s
rook-ceph-mon-b-6877d999c4-lbvq7                                  1/1     Running     0          3m45s
rook-ceph-mon-c-544bc95fdf-blwh5                                  1/1     Running     0          3m14s
rook-ceph-operator-59cbfb7c7c-dwg9h                               1/1     Running     0          6m22s
rook-ceph-osd-prepare-worker0.ib-sc-class.cp.fyre.ibm.com-xwkxh   0/1     Completed   0          2m42s
rook-ceph-osd-prepare-worker1.ib-sc-class.cp.fyre.ibm.com-c89m6   0/1     Completed   0          2m41s
rook-ceph-osd-prepare-worker2.ib-sc-class.cp.fyre.ibm.com-b2gjq   0/1     Completed   0          2m41s
rook-ceph-osd-prepare-worker3.ib-sc-class.cp.fyre.ibm.com-r8wwl   0/1     Completed   0          2m41s
rook-ceph-osd-prepare-worker4.ib-sc-class.cp.fyre.ibm.com-rxrp8   0/1     Completed   0          2m40s
rook-ceph-osd-prepare-worker5.ib-sc-class.cp.fyre.ibm.com-n94km   0/1     Completed   0          2m40s
rook-ceph-osd-prepare-worker6.ib-sc-class.cp.fyre.ibm.com-p9rl5   0/1     Completed   0          2m39s
rook-discover-4hqg8                                               1/1     Running     0          5m58s
rook-discover-949f4                                               1/1     Running     0          5m58s
rook-discover-9qrbn                                               1/1     Running     0          5m58s
rook-discover-dld2z                                               1/1     Running     0          5m58s
rook-discover-xkp8z                                               1/1     Running     0          5m58s
rook-discover-xlffq                                               1/1     Running     0          5m58s
rook-discover-xm85s                                               1/1     Running     0          5m58s

[root@ib-sc-class-inf ~]# oc get sc
NAME                   PROVISIONER                     RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
csi-cephfs (default)   rook-ceph.cephfs.csi.ceph.com   Delete          Immediate           true                   38m
rook-ceph-block        rook-ceph.rbd.csi.ceph.com      Delete          Immediate           true                   38m
rook-cephfs            rook-ceph.cephfs.csi.ceph.com   Delete          Immediate           true                   38m

[root@ib-sc-class-inf ~]# oc get pvc -n rook-ceph
NAME   STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
ceph   Pending                                      csi-cephfs     3m23s

Error in events is
failed to provision volume with StorageClass "csi-cephfs": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-ea08f962-2c43-4cc9-bb47-9a3d6397d7fc already exists

I assume your are using a fyre api of some sort to create a cluster with 7 workers. Did you have a worker stanza that included an additional disk. The vdb additional disk is what is used by default for csi-ceph
  ],  "worker": [
    {
      "count": "7",
      "cpu": "8",
      "memory": "32",
      "additional_disk": [
        "300"
      ]
    }
  ]

Yes we are using ansible to deploy into fyre
We have this.
"worker": [
    {
      "count": "{{ fyre_worker_quantity }}",
      "cpu": "{{ fyre_worker_cpu }}",
      "memory": "{{ fyre_worker_memory }}",
      "additional_disk": [
      ]
    }

Yes, you need an additional disk  on all your worker nodes. As I stated, the vdb drive that gets created when you specify an additional disk with a value is what csi-cephfs uses to allocate storage against.
Are you using the community ansible play to create a fyre instance (https://github.com/IBM/community-automation/tree/master/ansible/request-ocp-fyre-play)? The community ansible play will create a 300G additional drive with every fyre cluster.

Thank you for confirming.
We have our own automation to deploy into fyre at the moment. I will see if adding the 300G value resolves the issue.
If not we can look at using the community automation play to deploy.

We also have this play that will do it all, 1) Create fyre cluster, 2) Install csi-ceph 3) Install Common-Services. This can be configured in many ways and we can work with you to customize for your needs. Here is the play https://github.com/IBM/community-automation/tree/master/ansible/request-ocp-cs-install-fyre-play.
We would really like to get teams using our https://github.com/IBM/community-automation for their automation so we have one place to go for automation, an not have every team writing their own.

Thanks for your help.
The PVCs are now working.
[root@ib-sc-vdb-inf ~]# oc get po -n rook-ceph
NAME                                                              READY   STATUS      RESTARTS   AGE
csi-cephfsplugin-75ntr                                            3/3     Running     0          11m
csi-cephfsplugin-bw5qq                                            3/3     Running     0          11m
csi-cephfsplugin-provisioner-5c65b94c8d-dfbp5                     6/6     Running     0          11m
csi-cephfsplugin-provisioner-5c65b94c8d-jd869                     6/6     Running     0          11m
csi-cephfsplugin-r4vzl                                            3/3     Running     0          11m
csi-rbdplugin-j8jjr                                               3/3     Running     0          11m
csi-rbdplugin-km95j                                               3/3     Running     0          11m
csi-rbdplugin-provisioner-569c75558-msgx6                         6/6     Running     0          11m
csi-rbdplugin-provisioner-569c75558-mvtpx                         6/6     Running     0          11m
csi-rbdplugin-pslsf                                               3/3     Running     0          11m
rook-ceph-crashcollector-worker0.ib-sc-vdb.cp.fyre.ibm.com6sh6b   1/1     Running     0          10m
rook-ceph-crashcollector-worker1.ib-sc-vdb.cp.fyre.ibm.com8sxqh   1/1     Running     0          9m35s
rook-ceph-crashcollector-worker2.ib-sc-vdb.cp.fyre.ibm.comgwxkv   1/1     Running     0          9m36s
rook-ceph-mds-myfs-a-6f8f656d97-z6b62                             1/1     Running     0          9m36s
rook-ceph-mds-myfs-b-8584f8ff9f-5rtp4                             1/1     Running     0          9m35s
rook-ceph-mgr-a-6fb5b5fc65-6dncd                                  1/1     Running     0          9m59s
rook-ceph-mon-a-586874dbf-l86bs                                   1/1     Running     0          11m
rook-ceph-mon-b-77c44b7c88-7kkhr                                  1/1     Running     0          11m
rook-ceph-mon-c-59f65b646f-qf75l                                  1/1     Running     0          10m
rook-ceph-operator-59cbfb7c7c-wxr6h                               1/1     Running     0          12m
rook-ceph-osd-0-b58fddcb4-zqk2q                                   1/1     Running     0          9m50s
rook-ceph-osd-1-7754fb8d97-st55w                                  1/1     Running     0          9m47s
rook-ceph-osd-2-9c757f4cd-ck5vt                                   1/1     Running     0          9m48s
rook-ceph-osd-prepare-worker0.ib-sc-vdb.cp.fyre.ibm.com-ndtkz     0/1     Completed   0          9m58s
rook-ceph-osd-prepare-worker1.ib-sc-vdb.cp.fyre.ibm.com-2zq9b     0/1     Completed   0          9m57s
rook-ceph-osd-prepare-worker2.ib-sc-vdb.cp.fyre.ibm.com-wxxq2     0/1     Completed   0          9m57s
rook-discover-bgtmq                                               1/1     Running     0          12m
rook-discover-cqd8r                                               1/1     Running     0          12m
rook-discover-gdqf6                                               1/1     Running     0          12m
[root@ib-sc-vdb-inf ~]#
[root@ib-sc-vdb-inf ~]# oc get pvc -n rook-ceph
NAME       STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
my-ceph    Bound    pvc-f3bfa3c4-1dc4-496e-81dd-21dd4319ddfd   1Gi        RWO            csi-cephfs        74s
my-ceph2   Bound    pvc-86c6911c-96ce-46e3-ba3b-96d0e94a2f6b   1Gi        RWX            csi-cephfs        51s
my-ceph3   Bound    pvc-51d5eed4-0ed2-4394-b229-91fa42e2a9a1   1Gi        RWO            rook-ceph-block   31s
my-ceph4   Bound    pvc-dc1f0ebe-e1e9-4624-8a88-2e495658c24d   1Gi        RWX            rook-cephfs       12s


Overridable test timeout

Problem
Running test locally e.g. on a busy machine might occasionally fail due to go tests builtin default timeout of ten minutes.
Proposed solution
Change the test targets in Makefile to include an overridable go test default value, e.g. via environment variable:
...
test-tasks:
   go test -v -count=1 -timeout $${ODS_TESTTIMEOUT:-10m} ./test/tasks/...
.PHONY: test-tasks
...

:+1:
10 minutes is quite short, maybe a longer default timeout would be better? 20min maybe? That said, IIRC I picked the low timeout to detect changes that accidentally cause long test times.


PDI-8990- HttpPost step in kettle doesn't build post with specified encoding

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/httppost/HTTPPOST.java
  engine/test-src/org/pentaho/di/trans/steps/httppost/HTTPPOSTIT.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -2.02%:small_red_triangle_down:
Complexity Change: -2.13%:small_red_triangle_down:
Instruction Change: -.34%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.28%:small_red_triangle_down:
Complexity Change: -.78%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.08%:small_red_triangle_down:
Complexity Change: -2.11%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change:  + .06%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.33%:small_red_triangle_down:
Complexity Change: -1.85%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.httppost.HTTPPOST

Branch Change:  + 11.68%
Complexity Change:  + 10.96%
Instruction Change:  + 12.70%
Line Change:  + 14.60%
Method Change:  + 23.33%

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/httppost/HTTPPOST.java
  engine/test-src/org/pentaho/di/trans/steps/httppost/HTTPPOSTIT.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.27%:small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.70%:small_red_triangle_down:
Complexity Change: -3.08%:small_red_triangle_down:
Instruction Change: -.75%:small_red_triangle_down:
Line Change: -.89%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .63%
Complexity Change:  + .40%
Instruction Change:  + .49%
Line Change:  + .23%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.BaseStep

Branch Change: -.29%:small_red_triangle_down:
Complexity Change: -.18%:small_red_triangle_down:
Instruction Change: -.05%:small_red_triangle_down:
Line Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.httppost.HTTPPOST

Branch Change:  + 11.58%
Complexity Change:  + 11.25%
Instruction Change:  + 12.59%
Line Change:  + 14.44%
Method Change:  + 23.33%

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/httppost/HTTPPOST.java
  engine/test-src/org/pentaho/di/trans/steps/httppost/HTTPPOSTIT.java

Newly Broken Tests:
org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization:
:red_circle: java.lang.RuntimeException
java.lang.RuntimeException: Error validating dateFormatLocale
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.validateLoadedMeta(LoadSaveTester.java:176)
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.testRepoRoundTrip(LoadSaveTester.java:248)
	at org.pentaho.di.trans.steps.loadsave.LoadSaveTester.testSerialization(LoadSaveTester.java:183)
	at org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization(TextFileInputMetaLoadSaveTest.java:167)
Caused by:

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.70%:small_red_triangle_down:
Complexity Change: -3.08%:small_red_triangle_down:
Instruction Change: -.75%:small_red_triangle_down:
Line Change: -.89%:small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change:  + 1.28%
Complexity Change:  + .78%
Instruction Change:  + .08%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapinput.LDAPInputMeta

Branch Change: -1.61%:small_red_triangle_down:
Complexity Change: -.97%:small_red_triangle_down:
Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.19%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.httppost.HTTPPOST

Branch Change:  + 11.68%
Complexity Change:  + 10.96%
Instruction Change:  + 12.63%
Line Change:  + 14.17%
Method Change:  + 23.33%

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/httppost/HTTPPOST.java
  engine/test-src/org/pentaho/di/trans/steps/httppost/HTTPPOSTIT.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.trans.step.StepMeta

Instruction Change:  + .19%
Line Change:  + .27%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%
Instruction Change:  + .14%
Line Change:  + .37%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change:  + .06%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change:  + .14%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.BaseStep

Complexity Change:  + .18%
Instruction Change:  + .20%
Line Change:  + .38%
Method Change:  + .49%

org.pentaho.di.trans.steps.httppost.HTTPPOST

Branch Change:  + 11.68%
Complexity Change:  + 10.96%
Instruction Change:  + 12.63%
Line Change:  + 14.17%
Method Change:  + 23.33%


Ambiguous use of 'subscript'

Hi,
I'm installing Realm (0.97.0) as a "Dynamic Framework" in my Swift 2.1.1 project. (Drag RealmSwift.framework and Realm.framework from the ios/swift-2.1.1... directory to the “Embedded Binaries” section.)
So far, so good.
But after I create a class that is of type Object (say: class Account: Object {...}) my project does not compile anymore. The error is:

As soon as I remove that class (class Account: Object {...}), my project builds again.
Do you have any idea what the problem may be?
Thanks.

Realm is only involved very indirectly here, maybe just because it depends on Foundation even.
In any case, subscripting AnyObject is ambiguous because AnyObject doesn't allow subscripting. You likely either want to pass JSON: NSArray as a parameter to persistUserIDAndToken or cast JSON to a subscriptable type in the function: let JSON = JSON as! NSArray or similar.

Yes, that is probably true. The workaround would be:
...(JSON: **NSDictionary**) {
let userId = JSON.objectForKey("id")!
...
}

I just wanted to understand why the problem manifests itself only when Realm is added to the project.
(Anyway, the workaround is there, if this is something that wouldn't/shouldn't be fixed in Realm, I think it's safe to close it.)
Thanks.

I just wanted to understand why the problem manifests itself only when Realm is added to the project.

Probably due to how Swift resolves ambiguous function references, including subscripts.
In any case, I'm closing this as you understand that this isn't a Realm issue.


ffdshow-x86_32 should be deprecated

ffdshow-x86_32 is managed by chocolatey user, but not in this repo (lost in migration from purity's repo?)
Since the title is
ffdshow tryouts (forced 32-bit)
this package should probably be deprecated since we should be able to
choco install ffdshow --forcex86

I see it was removed from repo about a month ago https://github.com/chocolatey/chocolatey-coreteampackages/commit/b50df163caed5961b1dde6d8d0b1f1ad5111d694

@dtgm happy to take your guidance on this.  What do you need from me?

I should of tagged @TomOne to ask why he removed the pkg without deprecating. Thought maybe he forgot to push it or something.


I cannot debug Cortana App

I just downloaded this package today, and when trying to test out the included cortana app (JS), selected x64 as my target cpu, and hit debug on my "local machine", i get the following error:
"the debugger cannot continue running the process. unable to start debugging"
What should i do?

This is a problem with Visual Studio.

I took a brand new machine, installed Windows 10, then installed Visual Studio (include Web development tools, included by default I think). So this is not a problem with the samples; it's a problem with Visual Studio. Maybe you can ask on a Visual Studio forum.

i was able to debug it too, with brand new windows 10 and Cortana.
However, I couldn't figure out a way to change the relative references to "Microsoft.WinJS.4.0". Say I copied one project out of the sample folder, and wanted to have my own project in another folder. The new project doesn't compile because the link to "Microsoft.WinJS.4.0" has changed. But how do I fix it?? I couldn't find a config option from VS 2015. The "Microsoft.WinJS.4.0" folder is full of "placeholder" files.

It sounds like you unzipped just one sample instead of unzipping the entire repo. As noted in the instructions, you have to unzip the entire repo because of cross-references to shared content (such as Microsoft.WinJS).

You cannot copy the sample project to another solution. The sample projects are linked to other parts of the repo, as noted in the README. Furthermore, copying the project does not regenerate things that are supposed to be unique (like project GUIDs). If you want a private copy of a project, create a new project from the Visual Studio "New Project" menu, then copy/paste the code from the original project that you want to put into the new project.

Got it!Thanks! I just got stuck with how-to-unlink-the-shared-content part in VS 2015. I ended up creating a brand new project.


cigien: Watch alfarajioil.com

cigien requests the watch of the watch_keyword alfarajioil\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

alfarajioil\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


python3 compatibility

Hello. I modified python-gcm a bit to make it compatible with python3. All tests have passed for both python2.7 and python3.3. I hope this helps.

@geeknam, any chance this could be merged?

Hey guys, I'm keen on getting this merged. It would be awesome if someone could update this PR so I can cleanly merge it. Any volunteers?

I am. I'll rebase the branch over the new master and create a new PR for this. Will be ready tomorrow :)

I need  python 3 compliant version also. Thank you.

In my opinion, using requests and replacing urllib and urllib2 will definitely be a good move here.
Benefits:

requests is python 3 compatible
using requests would make the code cleaner
everyone is familiar with requests, requests is more human friendly

https://github.com/geeknam/python-gcm/pull/60 fixes this


Only show popover on load if element is in view

Fix for issue #153 , this change will cause the popover to show only if it is in the current viewport.

@dnoler wouldn't this disable the feature to show on load for popover beyond the viewport?  maybe this fix is on the Bootstrap/jQuery side?

@robmcguinness Right, this means we won't show the block if its outside the viewport. Otherwise, it gets shown at the edge of the screen, out of place. If we want to support popovers this way, we'll need to make a change to the Bootstrap code and/or CSS

gonna try and fix this in v2. it's not a widely used feature.


SSL Error: https://api.coinbase.com/v2/accounts does not support SSL

I get this by following the accounts example in the README.
Error: SSL Error: https://api.coinbase.com/v2/accounts does not support SSL
    at Request.onRequestResponse (request.js:844)
    at module.exports.EventEmitter.emit (events.js:81)
    at module.exports.ClientRequest._connect (request.js:235)
    at request.js:128

new client({
  strictSSL: false
})

I find it odd that false is not the default.

I just ran into this as well. I'm a little confused. Why would any API not support SSL? And why would you ever want a client that doesn't requrie SSL?


amplify mock api not working with subscriptions

How did you install the Amplify CLI?
npm install -g @aws-amplify/cli
If applicable, what version of Node.js are you using?
v21.5.0
Amplify CLI Version
12.10.1
What operating system are you using?
Arch Linux
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Describe the bug
When using mock for the backend
$ amplify mock api
With the following subscription:
useEffect(() => {
  const subscription = client
    .graphql({ query: subscriptions.onCreateTodo })
    .subscribe({
      next: ({ data }) => console.log(data),
      error: (error) => console.warn(error)
    });
  return () => subscription.unsubscribe();
}, []);

And the following schema:
type Todo @model {
  id: ID!
  name: String!
  description: String
}

fails with error:
index.ts:69 WebSocket connection to 'wss://<IP_ADDRESS>:20002/graphql/realtime?header=LONG_CODE_TRUCATED&payload=e30=' failed:

Expected behavior
Testing api locally with mock should work. I've tried this in other projects with differing schema's but all fail with the same error. Broke this problem down to it's basics for bug report.
Reproduction steps

npx create-react-app test_amplify
cd test_amplify
amplify init
amplify add api (Accepting defaults)
npm install aws-amplify
Write the subscription code above in App.js
amplify mock api
npm run start

Project Identifier
2ebfbe4ebc7ed43fb28d4bdadd09d8be
Log output

# Put your logs below this line

Additional information
Similiar to issue 555 and 122 but different output and they are resolved with version updates. Also, I'm not sure if the local protocol should be ws:// rather than wss://, but I thought it worth pointing out.
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Is there any movement on this?

I've been emailing them on same issue, seems it is blocked by another PR


Remove usage of sqlite variables to prevent "too many SQL variables" error

The line WHERE alternatename_lemmatized IN (''' + ','.join('?' for x in possible_geonames) + ''')
led to errors when annotating text on Windows.
I replaced the '?' with the escaped geonames to prevent the error.

Looks good, thanks!


Static attributes will be removed in FactoryBot 5.0 - Updating the Readme

FactoryBot threw a deprecation warning when I copied the example from the
readme:
  DEPRECATION WARNING: Static attributes will be removed in FactoryBot 5.0. Please use dynamic
  attributes instead by wrapping the attribute value in a block:

  to {<EMAIL_ADDRESS><EMAIL_ADDRESS>:token=>"to_user", :host=>"email.com", :name=>nil}] }

This updated the readme to use dynamic attributes.
Also: Sorry for not opening an issue first, I had already written the copy change in my code so it seemed easier :)

Thanks!


roadmap

Following @mattymo work on full containerized maybe it's time to decide if we go that way.
Past issues:

node restart (to be tested)
reload services (apiserver,...)


Added easy Winget Installation README.md

This PR adds an easy way to install VSCode on Windows

Please consider submitting this to https://github.com/microsoft/vscode-docs instead, as we have a page on Windows installation instructions there: https://code.visualstudio.com/docs/setup/windows


Incorrect parse of type synonyms with with generics

The following code does not parse with 1.5.0-beta:
interface Editable<T> { editable: T }
interface Static<T> { static: T; }
type Entity<T> = Editable<T> | Static<T>;

The compiler seems to think that Entity is a function and the right hand side of the type synoym declaration is its body.

Works in master branch. I believe type aliases with generic type parameters are only in 1.6


chore/version: prepare for 0.3.1 release

@homu r+

:pushpin: Commit 69dc770 has been approved by MichaelHirn

:hourglass: Testing commit 69dc770 with merge 6d0851f...

:sunny: Test successful - status


Final transformation updates

These are a final set of dashboard updates as we reach the end of transition.

PAYE and Your Tax Account have now passed their live service assessments
Add a link to the Redundancy Payments service from the home page
Add a video about the end of transformation which has now gone live

Will merge here and request review on the designprinciples repo.


Hosting

What's our plan for hosting?

[x] Save details about each deployed instance #126
[x] Configure webhook for Jekyll deployment #127
[x] Configure web server for publishing live #128

All the things are checked, but this doesn’t feel done. May need to close this ticket and open a more targeted one.


SQL syntax highlight in strings

https://github.com/microsoft/vscode/issues/1751 this is the only related issue I found, but it's scope is huge.
I was thinking whether a simple (eg. regex based) syntax highlight for strings and f-strings containing SQL would be possible in pylance (instead of the universal injectibility of any languange). It works well in eg. PyCharm.
I don't expect SQL syntax check or SQL format options which a SQL language flavor aware plugin would be able to do, just some basic detection of literals, functions and ANSI keywords.

Moving this issue to discussion as an enhancement request for comments and upvotes.


chore(bindings/java): improve OpenDALException tests and docs

This refers to https://github.com/apache/incubator-opendal/issues/2339


Mention lookup type differences

TypeScript's lookup types are quite a bit more powerful. The examples in the 2.1 release notes are not possible in flow yet.

Thanks. Could you file a PR mentioning this?


Consider providing an option for case-insensitive param names

We've received a question for whether armeria provides a way to accept case-insensitive param names.
Ref: https://line-armeria.slack.com/archives/C1NGPBUH2/p1643756335733629
We may need to find a way to add support for case-insensitive keys in ServiceRequestContext#queryParams and ServiceRequestContext#pathParams

We probably need to add an option for this to ServiceConfig.


Adding a Custom Location to a proxy host takes it offline

Are you in the right place?

Yes

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug

I installed NPM from docker hub latest. I add a proxy host to forward traffic to a host on my network on port 8080. It works ok. I managed also to add a Letencrypt SSL certificate without any issue. I can reach my site with the domain name.
If I try to add a custom location for instance for /myapp and point it to another IP on same network as previous and port 9090 it takes proxy host offline after saving

Nginx Proxy Manager Version
v2.11.1
This appears to have happened in the past. https://github.com/NginxProxyManager/nginx-proxy-manager/issues/929
Joao

I am facing the same issue

Had the same issue, posted on reddit about it and using version 2.10.4 fixes it.

I have the same problem with anything after v2.10.4. Running docker in a Ubuntu 20.04.6 VM. A custom location can't be saved regardless of how trivial it is. Revert to 2.10.4 and it works. https://www.reddit.com/r/nginxproxymanager/comments/1aoab3v/cant_save_custom_locations_with_a_npm_later_than/

I am not running Nginx Proxy Manager, but rather in a Debian 12 LXC Container in Proxmox via the Proxmox Helper Scripts. This is what fixed the issue for me, and it may well fix it for you too. You will just need to find the correct file (I am not sure if the file structure is different when you deploy via Docker)
I had to delete the very first line {% include "_hsts_map.conf" %} from the /app/templates/_locations.conf file. After deleting it, I rebooted the Nginx Proxy Manager LXC Container, deleted the custom location, and re-added it. The host is no longer offline, and the custom location works.

I have same problem using version 2.11.1
error:
nginx: [emerg] "map" directive is not allowed here in /data/nginx/proxy_host/24.conf:53
nginx: configuration file /etc/nginx/nginx.conf test file

Fixed problem by pulling jc21/nginx-proxy-manager:github-pr-3478. I can add/edit/save locations now without taking the host offline.

Fixed problem by pulling jc21/nginx-proxy-manager:github-pr-3478. I can add/edit/save locations now without taking the host offline.
How does one pull a specifc PR? My solution was to essentially do exactly this, but manually inside my install by navigating to, and editing that file. I didn't know that it was possible to deploy a specific PR ^^

I edited my config.yml to include:
image: 'jc21/nginx-proxy-manager:github-pr-3478'
You can also pull directly with docker as in:
docker pull jc21/nginx-proxy-manager:github-pr-3478

What do you mean by "custom configuration"? fwiw I'm still using github-pr-3478, waiting for NPM to release something newer than the January release that does not have this fixed merge in. Apparently the merge has been done but there's no new NPM yet.

If you don't want to use the custom pr branch, you can also use docker.io/jc21/nginx-proxy-manager:github-develop image

I have been struggling  with custom locations for hours...what is going on whit this issue.
I don't what to brink my nginx..so ill wait for for a new release. Any news on this?

Has this been fixed in the latest update?

Downloaded the new 2.11.2 release and now I can add/edit custom locations again.


style(app): fix chevron location and nav text alignment

Adjust chevron location to stick to the right side of the nav panel.
Center the text in the nav menu with the icon.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

GitHub release
v1.1.1

Your semantic-release bot :package::rocket:


fix: send client bundle in the initial response

Both rsc and Counter.tsx fetching start immediately.


K8SPG-120 keep backups and PVC by default

Test name
Status

init-deploy
failed

demand-backup
failed

data-migration-gcs
passed

scaling
failed

recreate
failed

affinity
failed

monitoring
passed

scheduled-backup
failed

self-healing
passed

operator-self-healing
passed

clone-cluster
passed

tls-check
passed

upgrade
passed

commit: https://github.com/percona/percona-postgresql-operator/pull/153/commits/ff3b63894af3b41281c855eb4958a2a796299051
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-pgo-apiserver
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-pgo-event
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-pgo-rmdata
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-pgo-scheduler
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-postgres-operator
image: perconalab/percona-postgresql-operator:PR-153-ff3b6389-pgo-deployer

Test name
Status

demand-backup
failed

init-deploy
failed

data-migration-gcs
passed

scaling
failed

recreate
failed

affinity
failed

monitoring
passed

scheduled-backup
failed

self-healing
passed

operator-self-healing
passed

clone-cluster
passed

tls-check
passed

upgrade
passed

commit: https://github.com/percona/percona-postgresql-operator/pull/153/commits/25fa1fb54d34725542ca71c6bede146600f73f17
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-pgo-apiserver
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-pgo-event
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-pgo-rmdata
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-pgo-scheduler
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-postgres-operator
image: perconalab/percona-postgresql-operator:PR-153-25fa1fb5-pgo-deployer

Test name
Status

demand-backup
passed

init-deploy
passed

data-migration-gcs
passed

scaling
passed

recreate
passed

affinity
passed

monitoring
passed

scheduled-backup
failed

self-healing
passed

operator-self-healing
passed

clone-cluster
passed

tls-check
failed

upgrade
failed

commit: https://github.com/percona/percona-postgresql-operator/pull/153/commits/83673b77c657e37e737fe46d5d120754d91959c5
image: perconalab/percona-postgresql-operator:PR-153-83673b77-pgo-apiserver
image: perconalab/percona-postgresql-operator:PR-153-83673b77-pgo-event
image: perconalab/percona-postgresql-operator:PR-153-83673b77-pgo-rmdata
image: perconalab/percona-postgresql-operator:PR-153-83673b77-pgo-scheduler
image: perconalab/percona-postgresql-operator:PR-153-83673b77-postgres-operator
image: perconalab/percona-postgresql-operator:PR-153-83673b77-pgo-deployer

Test name
Status

demand-backup
passed

init-deploy
passed

data-migration-gcs
passed

scaling
passed

recreate
passed

affinity
passed

monitoring
passed

scheduled-backup
passed

self-healing
passed

operator-self-healing
passed

clone-cluster
passed

tls-check
passed

upgrade
passed

users
passed

commit: https://github.com/percona/percona-postgresql-operator/pull/153/commits/f36863108ad0ab542d79529e286f9c6491d46715
image: perconalab/percona-postgresql-operator:PR-153-f3686310-pgo-apiserver
image: perconalab/percona-postgresql-operator:PR-153-f3686310-pgo-event
image: perconalab/percona-postgresql-operator:PR-153-f3686310-pgo-rmdata
image: perconalab/percona-postgresql-operator:PR-153-f3686310-pgo-scheduler
image: perconalab/percona-postgresql-operator:PR-153-f3686310-postgres-operator
image: perconalab/percona-postgresql-operator:PR-153-f3686310-pgo-deployer


Feat/fix table text

This should fix:

the incorrect heading of plural case for adjectives
at sign [@] - uho, uško [@] ухо, ушко [@]. Translations to other languages are corrupted in formating and content since @ is a special symbol

https://github.com/scherebedov/interslavic/raw/0b9644f7ccaccab56ee0b79a97317fe8faed5058/docs/assets/ui-example-wrong-plural.png


Feature/velocity interpolation

Status
DEVELOPMENT
Description
Change the speed control value to linear interpolation. #1328
The changes are as follows.
Embed the target speed in waypoint with velocity_set and refer to that value with pure_pursuit and output it.
⇒ Calculate the target speed with pure_pursuit and output it.

Todos

[x] Tests
[ ] Documentation

Steps to Test or Reproduce
Compare speed control during vehicle braking.
/wf_sim can be easily checked.

Before:

After:

Porting of the function from velocity_set to pure_pursuit has been completed.

Sorry, resolved conflicts and pushed --force.


sort filter names in policy editor

On the policy editor page ("Add/Delete Filter on Policies" ), please alphabetically sort the filter names.

done


Replace google::cloud::optional<> with absl::optional<>

Assuming we merge googleapis/google-cloud-cpp#685.  The google::cloud::optional<T> should be replaced by absl::optional<T> when we start using Abseil again, or with std::optional<T> when we only support C++17 and higher.

Closing this because we have no specific Abseil plans at this point, and once we do, replacing optional will be a banner item that we won't forget. No need to drag this issue along forever.


[1.3.0-RC1] java.lang.OutOfMemoryError: Metaspace

I'm not sure if I should submit another ticket, but when I tried to compile BeanPuree with sbt 1.3.0-RC1 I've got OutOfMemoryError:
java.lang.OutOfMemoryError: Metaspace
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)

Everything works fine with 1.2.8.
Steps to reproduce:

get beanpuree https://github.com/limansky/beanpuree
set sbt version to 1.3.0-RC1
sbt
+test

Originally posted by @limansky in https://github.com/sbt/sbt/issues/4681#issuecomment-493146377

I wasn't able to reproduce this either locally or on Travis - https://travis-ci.org/limansky/beanpuree/builds/533456390

I was able to reproduce on my machine.

Travis uses
java
-Xms2048M
-Xmx2048M
-Xss6M
-XX:MaxPermSize=512M

could you post your mem settings?

ethanatkins@Ethans-MacBook-ProZ:~/work/oss/sbt/community/beanpuree$ sbt -Dsbt.version=1.3.0-RC1 -v
[process_args] java_version = '11'
[copyRt] java9_rt = '/Users/ethanatkins/.sbt/0.13/java9-rt-ext-oracle_corporation_11_0_2/rt.jar'
Executing command line:
java
-Xms1024m
-Xmx1024m
-XX:ReservedCodeCacheSize=128m
-XX:MaxMetaspaceSize=256m
-XX:+UseParallelGC
-XX:+HeapDumpOnOutOfMemoryError
-Dscala.ext.dirs=/Users/ethanatkins/.sbt/0.13/java9-rt-ext-oracle_corporation_11_0_2
-jar
/usr/local/Cellar/sbt/1.2.8/libexec/bin/sbt-launch.jar
-Dsbt.version=1.3.0-RC1

I usually have "-XX:MaxMetaspaceSize=512m" added to my SBT_OPTS, but I disabled that for testing.

ok. I can reproduce this too when I unset my JAVA_OPTS and SBT_OPTS.
$ SBT_OPTS="-Xms1024M -Xmx1024M -Xss2M" sbt -v
```

also works, so in addition to sbt 1.3.0 using too much metaspace, maybe the fact that `-XX:MaxMetaspaceSize` is specified at all by the script is a problem?

I did notice that if I ran java -jar sbt-launch.jar directly, I didn't have the issue.

That being said, I looked at a heap dump and the eclipse memory analyzer did report a leak.

I got this error locally too, but when I started SBT like sbt -mem 4096 it didn't fail any more.
The cause of this issue is sensitive to SBT configuration.

@eatkins and I discussed this at length in sbt meeting today.
There are various small workarounds we can try to reduce the pressure on Metaspace (a space in the native heap of Java Virtual Machine where class metadata is stored), but we agreed that we need to remove the use of -XX:MaxMetaspaceSize from launchers and launch scripts since it aggravates the problem by putting an arbitrary limit.
The problem in the short term might be that build users will continue to run sbt script from sbt 1.2.8 etc. In those cases, a workaround might be to specify -XX:MaxMetaspaceSize equaling the total heap.

So, it is not a leak, but it just requires more memory than 1.2.8?

Not necessarily. Metaspace is a native memory region in the jvm. We have very little insight into what is occupying memory in there or if that memory is even used. I have detected very little difference in process heap, virtual or resident memory utilization comparing 1.2.8 and 1.3.0. In spite of that, 1.3.0 will require a much higher value for MaxMetaspaceSize or it will crash. We do not fully understand why that is, but the jvm default for MaxMetaspaceSize is unlimited so we decided it made sense to revert to the default.

One potential explanation is that sbt 1.3.0 loads more number of classes for whatever reasons, and require higher water mark. This could be because we introduced lm-coursier with shaded third-party libraries, different ClassLoader mechanisms, etc. But that pressure on Metaspace might be a temporary thing during task execution (this is consistent with it getting triggered by +test), and it may or may not matter in the grand scheme of things.

Removed MaxMetaspaceSize in https://github.com/sbt/sbt-launcher-package/pull/268

Fixed in https://github.com/sbt/sbt/pull/4729


completions/zsh: Improve caching behaviour

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This addresses #5839 and a few related issues:

Eliminate reliance on external utility calls for cache invalidation
Update cache policy to also invalidate if cache file is >=2 weeks old or if tap indexes are non-existent
Do not override any cache policy the user might already have set
Handle default cache policy determination as early as possible to ensure that a default is set appropriately for all helpers (this will mostly be useful if other helpers need caching in the future)

It's notoriously hard to test zsh completion functions, so if anyone feels like double-checking my work that would be pretty cool.
I noticed some other issues with this function too; i'll try to get around to making separate PRs for them

Thanks so much for your first contribution!  You rock, @okdana!


Fix AbstractMetadataReportTest and AbstractMetadataReportFactoryTest

What is the purpose of the change
Fix AbstractMetadataReportTest and AbstractMetadataReportFactoryTest

Please fix uts

ProtobufTypeBuilderTest.java:
        assertThat(getTypeName(propertiesMap.get("doubleMap"), types),
                equalTo("java.util.Map<java.lang.String,org.apache.dubbo.metadata.definition.protobuf.model.GooglePB$PhoneNumber>"));

==>  GooglePB.PhoneNumber

Codecov Report

Merging #8807 (87b2afa) into 3.0 (401e6eb) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                3.0    #8807      +/-   ##
============================================
- Coverage     63.27%   63.26%   -0.02%
+ Complexity      313      312       -1
============================================
  Files          1182     1188       +6
  Lines         50259    50411     +152
  Branches       7522     7506      -16
============================================
+ Hits          31802    31892      +90
- Misses        14973    15019      +46
- Partials       3484     3500      +16

Impacted Files
Coverage Δ

...che/dubbo/metadata/definition/util/ClassUtils.java
71.66% <0.00%> (+6.66%)
:arrow_up:

...bo/metadata/definition/builder/MapTypeBuilder.java
72.41% <100.00%> (ø)

...etadata/report/support/AbstractMetadataReport.java
66.50% <100.00%> (+5.74%)
:arrow_up:

...he/dubbo/rpc/protocol/tri/TripleClientHandler.java
37.50% <0.00%> (-25.58%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-13.80%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

.../dubbo/common/utils/ClassLoaderResourceLoader.java
66.66% <0.00%> (-11.72%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-10.87%)
:arrow_down:

... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401e6eb...87b2afa. Read the comment docs.


Provide install target

For distribution it would be helpful to have an install target in CMake, currently ninja install fails with ninja: error: unknown target 'install', did you mean 'test/all'.

This issue is not only relevant for Python.
It would be very helpful if one could just add duckdb to arbitrary cmake projects by, for example, doing the following:
ExternalProject_Add(
    duckdb_ep
    URL "https://github.com/cwida/duckdb/archive/v0.2.0.tar.gz"
    PREFIX "${CMAKE_BINARY_DIR}/third_party/duckdb"
    INSTALL_DIR "${CMAKE_BINARY_DIR}/third_party/duckdb/install"
    CMAKE_ARGS
        -G${CMAKE_GENERATOR}
        -DCMAKE_CXX_STANDARD=17
        -DCMAKE_CXX_FLAGS=-std=c++17
        -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
        -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
        -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
        -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH}
        -DCMAKE_BUILD_TYPE=Release
        -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>
    DOWNLOAD_COMMAND ""
    UPDATE_COMMAND ""
    BUILD_BYPRODUCTS
        <INSTALL_DIR>/lib/libduckdb.a
)

ExternalProject_Get_Property(duckdb_ep install_dir)
set(DUCKDB_INCLUDE_DIR ${install_dir}/include)
set(DUCKDB_LIBRARY_PATH ${install_dir}/lib/libduckdb.a)
file(MAKE_DIRECTORY ${DUCKDB_INCLUDE_DIR})

add_library(duckdb STATIC IMPORTED)
set_property(TARGET duckdb PROPERTY IMPORTED_LOCATION ${DUCKDB_LIBRARY_PATH})
set_property(TARGET duckdb APPEND PROPERTY INTERFACE_INCLUDE_DIRECTORIES ${DUCKDB_INCLUDE_DIR})

add_dependencies(duckdb duckdb_ep)

And install target eliminates the need to manually gather the libraries + the include directory.

@ankoh @xhochy happy to add this, what needs to be done? "Just" an install target?

@hannesmuehleisen It would just be cmake install.
But I think this is better done after #229 since people will easily mess up their global header directories otherwise.
I can open a PR once #229 is resolved.

Thanks! I will do the header rework once I get the buffermanager branch merged, I will let you know.

@ankoh @Mytherin moved the headers, it would be great if you could send that PR :)

Test it with the following CMakeLists.txt.
cmake_minimum_required(VERSION 3.13)
project(foo)

find_package(DuckDB REQUIRED EXACT 0.1.1)
find_package(Threads REQUIRED)

add_executable(main main.cc)
target_link_libraries(main duckdb Threads::Threads)

Or as ExternalProject:
include(ExternalProject)

ExternalProject_Add(
    duckdb_ep
    PREFIX "${CMAKE_BINARY_DIR}/third_party/duckdb"
    SOURCE_DIR "${CMAKE_SOURCE_DIR}/third_party/duckdb"
    INSTALL_DIR "${CMAKE_BINARY_DIR}/third_party/duckdb/install"
    CMAKE_ARGS
        -G${CMAKE_GENERATOR}
        -DCMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL}
        -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
        -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
        -DCMAKE_CXX_FLAGS=-std=c++17
        -DCMAKE_CXX_STANDARD=17
        -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
        -DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/third_party/duckdb/install
        -DCMAKE_MODULE_PATH=${CMAKE_MODULE_PATH}
        -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
    DOWNLOAD_COMMAND ""
    UPDATE_COMMAND ""
    BUILD_COMMAND ${CMAKE_MAKE_PROGRAM} -j${CMAKE_BUILD_PARALLEL_LEVEL} duckdb_static miniz re2 hyperloglog pg_query
    BUILD_BYPRODUCTS
        <INSTALL_DIR>/lib/libduckdb_static.a
        <INSTALL_DIR>/lib/libhyperloglog.a
        <INSTALL_DIR>/lib/libminiz.a
        <INSTALL_DIR>/lib/libpg_query.a
        <INSTALL_DIR>/lib/libre2.a
)

ExternalProject_Get_Property(duckdb_ep INSTALL_DIR)
set(DUCKDB_LIBRARY_PATH "${INSTALL_DIR}/lib/libduckdb_static.a")
set(DUCKDB_INCLUDE_DIR "${INSTALL_DIR}/include")
file(MAKE_DIRECTORY ${DUCKDB_INCLUDE_DIR})

add_library(duckdb STATIC IMPORTED)
set_property(TARGET duckdb PROPERTY IMPORTED_LOCATION ${DUCKDB_LIBRARY_PATH})
set_property(TARGET duckdb APPEND PROPERTY INTERFACE_INCLUDE_DIRECTORIES ${DUCKDB_INCLUDE_DIR})
target_link_libraries(duckdb
    INTERFACE "${INSTALL_DIR}/lib/libduckdb_static.a"
    INTERFACE "${INSTALL_DIR}/lib/libhyperloglog.a"
    INTERFACE "${INSTALL_DIR}/lib/libminiz.a"
    INTERFACE "${INSTALL_DIR}/lib/libpg_query.a"
    INTERFACE "${INSTALL_DIR}/lib/libre2.a"
)
add_dependencies(duckdb duckdb_ep)

Should give:
-- Install configuration: "Release"
-- Installing: /home/kohn/.local/lib/libduckdb.so
-- Installing: /home/kohn/.local/lib/libduckdb_static.a
-- Installing: /home/kohn/.local/lib/libpg_query.a
-- Installing: /home/kohn/.local/lib/libhyperloglog.a
-- Installing: /home/kohn/.local/lib/libre2.a
-- Installing: /home/kohn/.local/lib/libminiz.a
-- Up-to-date: /home/kohn/.local/include/duckdb
-- Up-to-date: /home/kohn/.local/include/duckdb/common
-- Up-to-date: /home/kohn/.local/include/duckdb/common/helper.hpp
-- Up-to-date: /home/kohn/.local/include/duckdb/common/serializer
-- Up-to-date: /home/kohn/.local/include/duckdb/common/serializer/buffered_file_writer.hpp
... all the headers
-- Up-to-date: /home/kohn/.local/include/duckdb/planner/expression_iterator.hpp
-- Up-to-date: /home/kohn/.local/include/duckdb.hpp
-- Up-to-date: /home/kohn/.local/include/duckdb.h
-- Installing: /home/kohn/.local/lib/cmake/DuckDB/DuckDBConfig.cmake
-- Installing: /home/kohn/.local/lib/cmake/DuckDB/DuckDBConfigVersion.cmake
-- Installing: /home/kohn/.local/lib/cmake/DuckDB/DuckDBTargets.cmake
-- Installing: /home/kohn/.local/lib/cmake/DuckDB/DuckDBTargets-release.cmake

Many things are directly taken from the CMake wiki:
https://gitlab.kitware.com/cmake/community/wikis/doc/tutorials/How-to-create-a-ProjectConfig.cmake-file

@hannesmuehleisen @Mytherin I fixed the cmake install for cmake versions < 3.13.
I noticed that both, the R package as well as the python package selectively copy files out of the source tree.
I disabled the cmake package export if the template files are not present rather than copying the unrelated cmake templates around.
They should probably use the cmake install target at some point.

@ankoh the packages will switch to the amalgamation i think.

Ah ok! May I ask why? Amalgamation does not eliminate the need to ship pre-compiled libraries after all. So wouldn't that just replace the parallel compilaton of the 70 or so cpp files with a single-threaded compilation of a 60k LOC file?

Well it saves us from shipping the build scripts and depend on cmake availability on the target. A big no-no for example for R packages.

Ah my bad!
I didn't realize that both packages need to compile DuckDB on their own, that's unfortunate.
I, however, would still advocate a non-algamated package for the C++ users since projects can just use precompiled libraries + find_package or parallel builds with ExternalProject_Add.

Great work, thanks a lot!


Polygon hole

Is there any way to make a hole in Polygon graphics?

I made a donut and worked around this by using the https://www.codeandweb.com/physicseditor drawing a horseshoe shape with a 1px gap.

The short answer is 'no', but you can definitely do as Weedshaker suggested and create a polygon that almost closes, but doesn't quite (so the final points don't get eliminated during decomposition)


Website TODO

Please open a separate PR for each of these:

[x] fix mobile newsletter subscription @mfilej
[ ] target _blank on external links (has to be GA tracked!)
[ ] fix mobile menu dropdown
[ ] prettify them tables http://www.rug.si/donations/
[ ] custom 404 like we had before
[ ] A place for sponsors / partners / supporters / advertisers
[ ] Add OpenGraph meta-data and test with Facebook Linter

Anyone can contribute, including you

Moved into separate issues that can be assigned to people.


adventure should run with less logging, for performance purposes

I just realised we run a bunch of throughput measurements with logging set to debug...that's probably not ideal. I don't think it makes much difference but why not (I performed a quick test with with INFO my throughput changed from 942Kb/sec to 985 which is most likely noise but who knows).

:+1:


Redirection even when the user interacts with the app

Hi!
Could you help me please?
invalidateSessionForUserInactiviity is triggered even when there is a user activity session.

Hi, can you please post your code for better understanding of the issue

I finally solved the problem.
I should specify the userActivityDebounceDuration attribute to a shorter time, in my use case
Thanks a lot!

I finally solved the problem. I should specify the userActivityDebounceDuration attribute to a shorter time, in my use case Thanks a lot!

I'm Also facing the same issue. what you fixed in your code.


can't find zlib 1.2.8

native.new_http_archive(
name = "zlib_archive",
url = "http://zlib.net/zlib-1.2.8.tar.gz",
sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
strip_prefix = "zlib-1.2.8",
build_file = str(Label("//:zlib.BUILD")),
)
1.2.10 is released

Fixed in https://github.com/tensorflow/tensorflow/commit/1e317b1f7dc5ccf04fc51ac96d97f5bdaefa9af9


Dependency from rmw_cyclonedds_cpp on fastrtps via rmw_dds_common

I think this created a build mess by introducing a dependency on FastRTPS.
colcon graph --packages-up-to rmw_cyclonedds_cpp --packages-above fastrtps
fastrtps                         +**.......
rosidl_typesupport_fastrtps_cpp   +*..***..
rosidl_typesupport_fastrtps_c      +*..**..
rosidl_typesupport_c                +****..
rosidl_generator_py                  + **..
rosidl_typesupport_cpp                +**..
rosidl_default_generators              + *
rosidl_default_runtime                  +*.
rmw_dds_common                           +*
rmw_cyclonedds_cpp                        +

Originally posted by @rotu in https://github.com/ros2/rmw_cyclonedds/pull/145#issuecomment-618729057

The graph shows all dependencies considered for the topological order. That includes group dependencies.
There is no direct dependency on FastRTPS in this package which you can verify by looking at the package manifest.
So you might want to take a step back describing what the problem is you are having and then finding the actual reason for it.

There is a transitive dependency on FastRTPS.
Before https://github.com/ros2/rmw_cyclonedds/pull/145, fastrtps wasn't being built as part of rmw_cyclonedds_cpp CI: https://github.com/ros2/rmw_cyclonedds/runs/596733361?check_suite_focus=true
Afterwards, it was: https://github.com/ros2/rmw_cyclonedds/runs/609354227?check_suite_focus=true#step:4:3049

The order comes from the fact that this package contains messages and therefore depends on all type support packages. There is no explicit dependency on FastRTPS. You can easily verify that by building RMW CycloneDDS in a workspace without FastRTPS.

@rotu it doesn't add a dependency.
rmw_dds_common depends on rosidl_default_generators, which has a group dependency in typesupport packages.
For that reason, if rosidl_typesupport_fastrtps_c or rosidl_typesupport_fastrtps_cpp is present in your workspace, colcon will build them before rmw_dds_common (and of course, it will build fastrtps before too, as it's a dependency of those packages).
But that doesn't mean they are a required dependency.
If you want to avoid building fastrtps in the github actions used in rmw_cyclonedds, what you can do is to add an AMENT_IGNORE file in rosidl_typesupport_fastrtps, or avoid checking out it.

Okay. It seems like I'm confusing two concepts: the list of "required dependencies" and the build order in which those packages must be built. What is the proper way to tell whether something is a "required dependency" versus an optional one?
@thomas-moulard It seems action-ros-ci makes the same mistake:
https://github.com/ros-tooling/action-ros-ci/blob/b22b3bdcfe5914903491fc7ee9a7a94efa33e2c5/src/action-ros-ci.ts#L221-L229
It also seems action-ros-ci doesn't have the same logic to disable RMW packages, which perhaps should be moved to the rmw package in some way instead of being living in CI:
https://github.com/ros2/ci/blob/9ce633a9411e964e2c54c2940da4e566388efbd0/ros2_batch_job/__main__.py#L699-L743

required dependency

IIUC, group dependencies (which are marked with group_depend tag), are always optional.
I don't know if we have another special tag for optional dependencies, I think we don't.
I'm not sure of how the ros ci actions can be configured, but having a way of ignoring specific packages/repositories sounds like a good idea.

group dependencies (which are marked with group_depend tag), are always optional.
That would be a good thing to clarify in https://www.ros.org/reps/rep-0149.html#dependency-groups and/or add an 'optional' flag on dependencies.

having a way of ignoring specific packages/repositories sounds like a good idea
I think that makes sense. Right now there's not spot for "additional colcon args" like there is on Travis.u

It also might be a good idea to add an option to to select a single rosidl implementation, like RMW_IMPLEMENTATION_DISABLE_RUNTIME_SELECTION for rmw backends.

It also might be a good idea to either share this option with rosidl or add a new option to change only use certain typesupports.

This is not something we are planning to implement. The user chooses what they want by what is in a workspace (and not ignored during the build).
Since there doesn't seem to be an issue in this repository I am going to close the ticket. Please feel free to continue commenting.

This is not something we are planning to implement.

What's the rationale for allowing building without dynamic RMW selection and why doesn't it apply to typesupports?
Oops. I didn't realize that excluding other implementations from rmw_implementation does not exclude them from --packages-up-to rmw_implementation so the benefits of such a feature would not be as great as I hoped.

The user chooses what they want by what is in a workspace (and not ignored during the build).

What would be the correct way to tell colcon build to ignore all packages not required rmw_cyclonedds?

What would be the correct way to tell colcon build to ignore all packages not required rmw_cyclonedds?

Something like --packages-ignore-regex .*fastrtps.* .*connext.*

What would be the correct way to tell colcon build to ignore all packages not required rmw_cyclonedds?

Something like --packages-ignore-regex .*fastrtps.* .*connext.*

That ignores fastrtps and connext, it doesn't filter based on rmw_cyclonedds_cpp's package requirements. In general, it seems like a pretty core feature of a build tool to be able to figure out which packages some package depends on...

it seems like a pretty core feature of a build tool to be able to figure out which packages some package depends on...

Please feel free to describe how colcon should determine that based on the available information from the package manifests.

A package's required dependencies seems to be the transitive closure of its Dependency tags, excluding its Group dependency tags (which as @ivanpauno said above, are always optional).

Group dependencies are not necessarily optional. There are cases where you e.g. need at least one of package from the group in order to work properly. That semantic isn't encoded in the manifest because the community wasn't able to reach a consensus when this was proposed (I don't have a link to that discussion at hand).
Therefore I don't think an option to just ignore group dependencies is sufficient.

Group dependencies are not necessarily optional.

This is a great point.

rmw_dds_common depends on rosidl_default_generators, which has a group dependency in typesupport packages.

The group dependency mentioned above needs AT LEAST one package.
For rmw_cyclonedds_cpp, only rosidl_typesupport_introspection_cpp is needed.
For rmw_fastrtps_cpp, only rosidl_typesupport_fastrtps_cpp is needed.
I don't think that information can be encapsulated in a package.xml (i.e. I don't think that https://github.com/ros-infrastructure/rep/issues/252 can provide a solution).
IMO, the only way to have a minimal build for one specific rmw implementation is to delete the others from the workspace.

You're right that my suggested fixes for https://github.com/ros-infrastructure/rep/issues/252 would not fully encode the dependency "at least one of...".
It would enable replacing this part of the build process:
rosdep install ... --skip-keys "console_bridge fastcdr fastrtps libopensplice67 libopensplice69 rti-connext-dds-5.3.1 urdfdom_headers"
with something like:
rosdep install ... --disable-optional
It is possible to do this today with e.g. <member_of_group condition='($DISABLE_OPTIONAL != 1) or ($ENABLE_CONNEXT == 1)'>.
You're right that today, the only way to have a minimal build is to delete packages. I don't think we should settle for that status quo.

FYI: here's the proposed fix in the cyclone rmw.
https://github.com/ros2/rmw_cyclonedds/pull/168


Setting Filename using cfg file

Description of proposed feature
Having a manim.cfg in a folder should be enough for manim to run. For example, users can run manim . in that folder and the .cfg file should contain the file name. Also, running manim some.cfg should also work. Doing this would simply make it so that people no need to remember the file name 😉 instead they would move to their workspace (say a folder) and then run manim . which should get the file name from the manim.cfg present in the folder and render that. This would help me a lot though.
How can the new feature be used?
Supporting the command
manim .

and
manim

also
manim my.cfg

for passing custom configuration files.
Additional comments
I have seen this it the pip tries to do when we do pip install ..

There are three things to do here:

Right now, the input file name is a obligatory command line argument. For this to work, it should be optional. (This will add to our argparse woes...)

The ManimConfig should hold a reference to the input file. This is already possible.

__main__.py must read the input file from the ManimConfig, and not from the command line arguments.

I am marking this as "good first issue".

@leotrs @naveen521kk Im planning on doing this as a first issue(if that's fine by you?).

assigning you :)

Unassigned due to inactivity.

I'll give it a go


AmazonSES construct has changed

Latest 1.x aws sdk for php no longer support this sintax:
new \AmazonSES(
$this->config->amazon->AWSAccessKeyId,
$this->config->amazon->AWSSecretKey
);
It should be replaced with something like this:
new \AmazonSES(array(
"key"=>$this->config->amazon->AWSAccessKeyId,
"secret"=>$this->config->amazon->AWSSecretKey
));

New syntax for AmazonSES looks
$this->amazonSes = new \AmazonSES(
                [
                    'key'    => $this->config->amazon->AWSAccessKeyId,
                    'secret' => $this->config->amazon->AWSSecretKey
                ]
            );

Maybe this issue can be closed?


[Event Parameter Change] Report 393 - "Suggest Vendor Payments" - Procedure "MakeGenJnlLines" - Event OnMakeGenJnlLinesOnBeforeTempPaymentBufferInsert

Dear ALAppExtensions team,
we would like the parameter PayableVendLedgEntry added to the following event.
Report 393 - "Suggest Vendor Payments" - Procedure "MakeGenJnlLines" - Event OnMakeGenJnlLinesOnBeforeTempPaymentBufferInsert
Original:

[IntegrationEvent(false, false)]
local procedure OnMakeGenJnlLinesOnBeforeTempPaymentBufferInsert(var TempPaymentBuffer: Record "Payment Buffer" temporary; VendorLederEntry: Record "Vendor Ledger Entry")
begin
end;

Change: Added Parameter PayableVendLedgEntry

[IntegrationEvent(false, false)]
local procedure OnMakeGenJnlLinesOnBeforeTempPaymentBufferInsert(var TempPaymentBuffer: Record "Payment Buffer" temporary; VendorLederEntry: Record "Vendor Ledger Entry"; PayableVendLedgEntry : TEMPORARY Record "Payable Vendor Ledger Entry")
begin
end;

Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47656.


NO-ISSUE: Add CLI logging infrastructure

Description
This patch adds to the command line tool a logging infrastructure based on the zap and logr libraries.
Type of change
Please select the appropriate options:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

Testing
Tested manually and with the included unit tests.
Checklist

[x] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[ ] A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
[ ] PRs should not be merged unless positively reviewed.

@flaper87 please review.


add domain aware logging to poolmanager

this also involved making a str method for RecentlyUsedContainer, however I couldn't find an easy way to complete the debug log info as requested.
One of my attempts at #881. I would consider at most one of the two (#897).

Thanks for this! For my part I'd prefer #897.

Yea, I think I've been convinced that #897 is the way to go. :) Thank you for both proposals!


feat: add option to support DBSTAT

This option enable support to DBSTAT Virtual Table

Any update to this PR?


S3 Auth plugin does not work for consecutive spaces in header

According to https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
"To create the canonical headers list, convert all header names to lowercase and remove leading spaces and trailing spaces. Convert sequential spaces in the header value to a single space."
Traffic server does not remove sequential spaces from values what in our case leads to different headers signatures calculated by traffic server and minio server we use and 403 error.

fixed by #8579


Gameplay API

There should be a framework layer that provides a simple gameplay API. Similar to how UE handles this, I think the best course of action would be to make a "GameInstance" and other such classes that a game using this engine could inherit from.

This will be the setup:
The engine will create a World. After engine creation, we will initalize the world's game mode via a templated argument that takes the types of game mode and other

class World : Singleton
There will be exactly one World at any given time in the engine.

LoadLevel - Create a new level based off a file.
Begin -
Tick(float dt) - Update any active levels
An array of current levels

class GameMode : public NonCopyable

Load from an INI file and have the following data:
Path to this game mode's starting level
Any other game mode things that we want to be able to tweak per-game (this kind of thing would be added in the future)

class Level : public NonCopyable
A level will hold any active actors/objects in the engine. Levels will be loaded from JSON for now for easy editing, but eventually they should be assets/packaged files.

Create(std::string FilePath) - Creates a new level based on the given file info.
 Tick(float dt) - Updates active actors in the level
PostLoad - Called after the level has been created and all objects from the level file were created.
Unload - Destroy any actors that are not marked as persistent
BSP/Spatial partitioning for actor ticks that will have us only update based on the player position.
Array of pointers to active actors

class Player : public Actor/object
The player will represent the current player in the game. It will be an override of an actor/object and have some special input components and things on it. This will come later.

This is all done, now we just need an object system that we can use and have levels load.


bug(gatsby-plugin-fastify): Splat route causing 404 page and duplication of pathPrefix

Describe the bug
Splat route not registering on client-side navigation and shows a 404 page. On a hard refresh path prefix is duplicated in url.
To Reproduce
I've created a demo of the issue here: https://github.com/pea/gatsby-fastify
Steps

Run https://github.com/pea/gatsby-fastify
Go to http://localhost:5000/uk/
Click on One Product
Observe 404 page
Hard refresh the page
Observe url is http://localhost:5000/uk/uk/one-product and the page reads Slug: uk/one-product

Expected behavior
On hard refresh the url should remain http://localhost:5000/uk/one-product and the page should read Slug: one-product
System Info
System:
OS: macOS 13.0.1
CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.12.1 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.19.2 - /usr/local/bin/npm
Browsers:
Chrome: 108.0.5359.98
Firefox: 107.0.1
Safari: 16.1
npmPackages:
gatsby: ^4.25.0 => 4.25.0
gatsby-plugin-fastify: ^0.12.0 => 0.12.0
npmGlobalPackages:
gatsby-cli: 5.2.0

Hey @pea! I was working on another feature a couple weeks back and think I actually ran across this and just assumed it was my new code breaking things. I'm not sure when I can get to this. Are you interested in making a PR to resolve and add tests?

With the announcement of the Gatsby Adapters spec, we'll be discontinuing any work on this plugin. Should the need for a performant node server still be needed, this work can continue under the official spec as gatsby-adapter-fastify.


Update SSH config and have a bit of a tidy

@timmow @carolinegreen @leenagupte @robyoung - I changed your files.

I'm happy with my manifest changes

Yes, I'm happy too.


[SMALLFIX] Adding missing javadoc

@aaudiber

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8175/
Test PASSed.


Microsurvey Sample

As shown in the "Transitioning to the App Model" panel at Ignite 2015, here is a web part that can be flexibly provisioned in several ways. The web part presents a "microsurvey" - a single question that users can answer and then see the overall responses in place. It now includes custom New, Display, and Edit list forms as well as the web part and settings page.
This sample can be provisioned as a SharePoint Hosted Add-in, as a "drag-and-drop" solution (a user drags the files into place manually), or in a centrally managed environment such as an organization with dozens or thousands of project or team sites.
In addition to being useful to end users, the sample demonstrates:

how to write code that is reusable as a SP Hosted App, drag and drop app, or centrally hosted scripts
how to write a solution that provisions its own SharePoint storage in JavaScript
how to do remote provisioning with the "desired state" pattern, so the script can be re-run to upgrade when the app is versioned
how to provision lists with custom forms that won't break when the out of the box forms change
how to write an AngularJS "widget" (web part) that allows more than one copy on a page, and shares the page with other AngularJS code
how to use the PnP PowerShell commands to deploy a widget and custom site settings page

Hi @BobGerman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Closing due to targeting master branch.


Live tests should create a new Key Vault each time if environment variable is unset

Live tests often fail because of deleted, non-purged keys that get left behind. To avoid this problem, we should create a new Key Vault in global test setup each time and delete it when done if the AZURE_KEYVAULT_URL environment variable is unset.
This should help live test reliability.

Adding KeyVault label back, even though this is cross-service.

This is mostly fixed by #9127.

@danieljurek should we generalize this as part of our original MQ work? There was some discussion about it, but I'm not finding any open issues in this or azure-sdk repos.

Do we even want to do this?

At one point we did. I did find #9062 that is tracking this. Some service teams felt pretty strongly this should "just work" when running tests.

This has been resolved with our new test-resources.json solution where live test resources are created and destroyed for each live run.