Compability issue with python 3.11

Hi, love the extension! There appears to a compability issue with python 3.11, running the following:

python 3.11
pygls 1.0.2
Visual Studio Code
vscode-nastran v1.0.1

When hovering over a keyword I get the following error in VSCode:
Traceback (most recent call last):
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\site-packages\pygls\protocol.py", line 270, in _execute_request_callback
    self._send_response(msg_id, result=future.result())
                                       ^^^^^^^^^^^^^^^
  File "c:\Users\abc\.vscode\extensions\mbakke.vscode-nastran-1.0.1\server\server.py", line 120, in hovers
    card = re.match(REGEX_KEY[section], line)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\__init__.py", line 166, in match
    return _compile(pattern, flags).match(string)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\__init__.py", line 294, in _compile
    p = _compiler.compile(pattern, flags)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\_compiler.py", line 743, in compile
    p = _parser.parse(p, flags)
        ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\_parser.py", line 980, in parse
    p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\_parser.py", line 455, in _parse_sub
    itemsappend(_parse(source, state, verbose, nested + 1,
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abc\AppData\Local\Programs\Python\Python311\Lib\re\_parser.py", line 841, in _parse
    raise source.error('global flags not at the start '
re.error: global flags not at the start of the expression at position 4
[Error - 6:53:53 PM] Request textDocument/hover failed.
  Message: re.error: global flags not at the start of the expression at position 4
  Code: -32602

Looking at https://docs.python.org/3/library/re.html it appears some changes have been made to the regex library in Python 3.11, could one of these changes be causing the above issue? I.e. the input argument REGEX_KEY[section] of the re.match call in server.py is no longer valid in 3.11.

Fix would be to change each regex in vscode-nastran/syntaxes/nastran.json  "^\\s*(?i)(PATTERN)" -> "^(?i)\\s*(PATTERN)". Change in python 3.11 regex is that:

Hey @FGHaider , well written issue and solution in #18. Thanks for the contribution!
I am going to incorporate a few more simple things (CONTRIBUTING.md per #16 and a CODE_OF_CONDUCT.md) before I push an update to visual studio marketplace. You can expect a v1.0.2 in the next couple days.


Multiple handlers

Is it possible to set up multiple handlers? I like the router solution, but in a modular setup it doesn't make much sense to have all routes for all entities in one handlers.
I'd like to have multiple handlers, that I can register to the server.
Any ideas/hints to achieve this with the current code? If not possible, possibly a feature request?
TiA!

No I think it's not possible. The setHandler method is like this:
https://github.com/oktal/pistache/blob/bc52382d9de1b2bd180a40a1889ba0ef4dd37545/src/server/endpoint.cc#L60-L62
and handler is just a shared pointer:
https://github.com/oktal/pistache/blob/bc52382d9de1b2bd180a40a1889ba0ef4dd37545/include/pistache/endpoint.h#L145
There is not a handler queue or some structure that could iterate over handlers.


The Search Guard license key is not valid for this cluster. Please contact your system administrator.

Search Guard and Elasticsearch version >> ES 6.1.2 SG 6.1.2-22
JVM version and operating system version >> JVM .8.0_112-b15 ... OS Centos 6 Kernel 2.6.32-696.6.3.el6.x86_64
Number of nodes in your cluster >> 54
Description of the bug >> Applied SG license as provided by vendor... through both API and sg_config.yml

Still showing >> The Search Guard license key is not valid for this cluster. Please contact your system administrator.

Pls file an issue here: support.search-guard.com
or send us details via E-mail to info(at)search-guard(dot)com

@lanerjo friendly ping

Closing due to inactivity


Make .to (expected changed value) accept a block

Hi there!
I have a feature request which hopefully isn't a dupe. Was hard to google.
I use .to change {...}.from(x).to(y) a lot. Occasionally I need the second .to to accept a block instead of a value.
Something like:
expect {...}.to change {...}.from(x).to{...}
Sample use case
Imagine a capybara spec for an ajax functionality. The ajax widget creates a MyModel (an ActiveRecord object) and displays its generated id on screen.
One could test it with:
expect {
  find("#the_widget").click # capybara api
}.to change {
  find("#the_id").value # capybara api
}.from("").to(MyModel.last.id.to_s)

This snippet would not work, because at the time RSpec reads this ruby code, MyModel.last.id.to_s will have a different value than seconds later, when find("#the_widget").click is executed.
So I'd want to solve it by making .to accept a block:
expect {
  find("#the_widget").click # capybara api
}.to change {
  find("#the_id").value # capybara api
}.from("").to {
  MyModel.last.id.to_s
}

The point being that the call to this .to block is deferred until the very last moment.

I hope my example was clear enough and that you find the feature worth it.
Cheers - Victor

You can pass any object that implements === to from or to.  This includes things like regular expressions, ranges, and RSpec matchers,  It also includes 1-arg lambdas:
expect {
  find("#the_widget").click # capybara api
}.to change {
  find("#the_id").value # capybara api
}.from("").to(lambda { |id| id == MyModel.last.id.to_s })

Good enough - thanks much!
Victor

I'm not sure accepting lambdas/procs is an ideal API.
Sometimes they work as expected, but often I get these:
expected result to have changed to #<Proc:0x007f8cbbbfa398>, but is now "€8.006,41"
One can understand this error - a proc is an object like any other, so RSpec can feel tempted to compare the proc with a string, instead of invoking the proc.
Two real failing examples:

}.from(old_value).to(lambda { |v| v == new_value.format })
.from(old_id).to(->(id){ id == MyModel.last.id.to_s })

Any idea on how to get them to work?
Would appreciate if we reopen the issue.
Cheers - Victor

Can you provide a reproducible example of a case that isn't working as you expect?

I couldn't get it to fail:
RSpec.describe 'change to lambda' do
  it do
    @a = 0
    expect { @a = 1 }
      .to change { @a }.to(->(_a) { @a })
      .and change { @a }.to(lambda { |_a| @a })
  end
end

Let's close for now, since there's no clear reproduction example.

Seems to fail when the value is defined in let or let!;
let(:a) { 0 }
it do
  expect { a = 1 }.to change { a }.to(-> { a })
end

# Failure/Error: expect { a = 1 }.to change { a }.to(-> { a })
#        expected `a` to have changed to #<Proc:0x00007ffff4d5e0c0 /file.rb:3 (lambda)>, but did not change

You are likely running into variable shadowing / precedence rules there, a = 1 assigns a local variable called a within the block which you've set to one, but the change block and to lambda are not in the same scope so they see the method a, you can't change let values.


No matching function swap() when using robin_map::emplace()

Hello, @Tessil,
I might be missing something in the documentation but I figured I would ping you on this. Basing my work on the few differences between the robin_map and the unordered_map, I don't understand why the following code does not compile:
#include <unordered_map>
#include "external/tsl/robin_map.h"

struct SomeStruct {
  int val_;

  SomeStruct() : val_(0) {  }
  SomeStruct(int val) : val_(val) {  }
  SomeStruct& operator=(const SomeStruct&) = delete; // Comment this out and it compiles
};

int main(int argc, char *argv[]) {
  std::unordered_map<int, SomeStruct> unordered_map;
  unordered_map.emplace(std::piecewise_construct, std::forward_as_tuple(1), std::forward_as_tuple());

  tsl::robin_map<int, SomeStruct> robin_map;
  robin_map.emplace(std::piecewise_construct, std::forward_as_tuple(1), std::forward_as_tuple());
}

I get the following error:
error: no matching function for call to ‘swap(SomeStruct&, SomeStruct&)’
  swap(second, __p.second);

Keeping the assignment operator by not explicitly deleting it gets rid of the issue but I want to have it disabled. Any idea why emplace would need it in the robin_map?
(Also, I am using C++ 11)
Thanks in advance! :)

Hello,
Thank you for the report.
The problem comes from the fact that by deleting the copy assignment operator, you also disable the implicit move constructor and move operator which in turn makes the type not swappable by default.
The copy constructor and copy operator are not required but the used types must be swappable. They must also be copy and/or move constructible. I added this information in the README and the API.
It isn't possible with robin hood hashing and open-addressing to avoid this as on insertion we sometime have to 'steal' the bucket of an already present value and move the value of the 'stolen' bucket further away.

@Tessil,
Thank you for the explanation and thank you for creating this project 👍.


python 3.6 no longer supported

SAM not working anymore with Python 3.6, need to upgrade to 3.7. When I did, the pymongo also changed, the new version has different parameters for ssl_ca, I fixed that manually but still does not work

Hi. Thank you for raising this, we'll review and update in due course.


UI mask Issue in IE11 Angular 1.3.0

ui mask is not triggered when one number from the input field. it gets fired from second delete.
Ex : input<PHONE_NUMBER>
Delete one number : (999) 999 999 - still valid
Delete second number : (999) 999 99 - Invalid.
This is happening only in IE11 and with Angular latest version

UI.Utils modules was split in individuals repositories. If still valid, please consider re-submitting on its dedicated repository: https://github.com/angular-ui/ui-mask
See the README for details.


[Task]: upgrade Beam dependency to 2.59.0

What needs to happen?
upgrade Beam dependency to 2.59.0
Issue Priority
Priority: 2
Issue Component
Component: Beam

.take-issue


Postgres data connector crashes on types: Json, Point, Money

Describe the bug
Postgres data connector crashes on types: Json, Point, Money:
thread 'main' panicked at crates/arrow_sql_gen/src/postgres.rs:517:14:
not implemented: Unsupported column type Json
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
To Reproduce
Connect to a Postgres database with a table configured with the fields above
Expected behavior
Database is queryable.  If not supported, the database should not crash.

I will solve this problem.

Hey @hcrypto7  I was looking into this before seeing your comment, anyway a few thoughts regarding the issue:
First, clickhouse and mysql also have the similar issue so perhaps we should fix them as well? or make this into smaller issues/PRs.
https://github.com/spiceai/spiceai/blob/50733d0b524ef4aec33f2d7a328acc901fd2be2c/crates/arrow_sql_gen/src/clickhouse.rs#L530-L532
https://github.com/spiceai/spiceai/blob/50733d0b524ef4aec33f2d7a328acc901fd2be2c/crates/arrow_sql_gen/src/mysql.rs#L465-L467
https://github.com/spiceai/spiceai/blob/50733d0b524ef4aec33f2d7a328acc901fd2be2c/crates/arrow_sql_gen/src/mysql.rs#L411-L413
Second, clickhouse has a snafu error for this kind of problem so maybe we should do something similar to that?
https://github.com/spiceai/spiceai/blob/50733d0b524ef4aec33f2d7a328acc901fd2be2c/crates/arrow_sql_gen/src/clickhouse.rs#L77-L79
Last, postgres implementation has a tricky case for NUMERIC so keep it in mind if you want to refactor the code.
https://github.com/spiceai/spiceai/blob/50733d0b524ef4aec33f2d7a328acc901fd2be2c/crates/arrow_sql_gen/src/postgres.rs#L569-L570

I think it's a good idea to make it a smaller issue/PR.

FYI the Postgres/MySQL Table Providers were moved to https://github.com/datafusion-contrib/datafusion-table-providers, so they will need to be fixed there first.

@hcrypto7 - How are you coming along on this?

Fix Json type in datafusion table providers:https://github.com/datafusion-contrib/datafusion-table-providers/pull/40
Postgres:

Spice:

Fix Point type in datafusion table providers: https://github.com/datafusion-contrib/datafusion-table-providers/pull/49
Postgres:

Spice:

Fix Money Type in datafusion table providers.
Since there's no arrow data type of money, while postgres Money is sent as an i64 of the lowest denomination of money in the underlying bindings. The money will be converted into lowest denomination in i64, and stored in arrow i64 array, to ensure the integrity of the actual cash value.
Examples:

USD(cent)

Postrges

Spice

CNY(cent)

Postrges

Spice

JPY(yen)

Postrges

Spice


[UI] Integrating CASL into Meshery UI

Notes for Reviewers

This is just the initialization for CASL.js
The ability file is not yet created.

Signed commits

[x] Yes, I signed my commits.

🤩

@theBeginner86 i guess after this implementation we can enable our cloud extensions to show in meshery right

@theBeginner86 i guess after this implementation we can enable our cloud extensions to show in meshery right

Yeah

Once, we make the small updates that Aabid and I have mentioned above.
Then we can move forward with this PR.
In next PR, you can create an Redux Toolkit Slice to store and update abilities. And then pass them as injected props to UserAccountExtension point in Meshery UI 👍


Expose optical frame in CameraSensor to be used by DepthCameraSensor

Summary
I was using DepthCameraSensor along with the ros_gz_bridge and noticed that the point cloud could not be visualized in rviz because the optical frame was not being assigned to the message being produced by this package.

This looks good now as far as the message containing the correct frame_id if set optical frame.

Rerunning the Ubuntu CI. I think it had an infra issue.


Input data set

Hello, might it be possible to provide some sample generic input data set? - I was thinking about adjusting your code to just DSC input data and therefore some generic input data would be very helpful to get the code running. Thanks!

Hello, here is some DSC data, recieved at 3, 5, 10 K/min. Inside files you can find 4 columns: time (s), temperature (C), DSC signal with corrected baseline and raw DSC signal. Note that process is not one step so you'll not see any constant Ea.
I didn't implement DSC data processing in scripts. There is only DSC plotting, so feel free to modify code for your purposes.
Now i am focused on model based approach so there is no updates since october.
DSC-3.csv
DSC-5.csv
DSC-10.csv


Possibility to pass a kms key to configure secretsEncryption

It is generally recommended to use a KMS key so that Kubernetes secrets are encrypted before stored in etcd database.
It would be great that by default eksdemo uses that feature

Looks like eksctl supports this at cluster creation time
# kms-cluster.yaml
# A cluster with KMS encryption enabled
---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: kms-cluster
  region: us-west-2

managedNodeGroups:
- name: ng
# more config

secretsEncryption:
  # KMS key used for envelope encryption of Kubernetes secrets
  keyARN: arn:aws:kms:us-west-2:<account>:key/<key>

source: https://eksctl.io/usage/kms-encryption/
So likely this will require adding an eksdemo command to create a KMS key and a flag for eksdemo create cluster
@allamand does that address the ask here?

Or ... to save time ... if the flag is present in cluster creation eksdemo can create key using a naming convention and then use the key to avoid having to copy/paste the key ARN in the command line
@allamand thoughts?

that's my though, maybe eksdemo create a key and alias it with cluster-name ?

@allamand Please check out the PR attached to this issue that will add secret encryption. Here is an example of how you might use it.
eksdemo create kms-key my-key
eksdemo create cluster blue --encrypt-secrets my-key

You pass the KMS Key Alias to the --encrypt-secrets flag and it will lookup the key ARN and add it to the cluster.yaml file passed to eksctl to create the cluster.

perfect, Thanks @aaroniscode


Migrating from version 1.4.5 to 2.3.6 maps does not show and app is broken. (Sample project provided)

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report
[ ] feature request

If you choose 'problem or bug report', please select OS:  (check one with "x")

[x ] Android
[ x] iOS

cordova information:  (run $> cordova plugin list)
cordova-plugin-googlemaps 2.3.6 "cordova-plugin-googlemaps

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
Current behavior:

If we migrate in config.xml from version 1.4.5 to 2.3.6, buttons in html pages are not clickable anymore and map is white. Reverting back to 1.4.5 and everything works just fine.
Expected behavior:

Same as the version 1.4.5, the map should have shown and the button is clickable.
Screen capture or video record:

Related code, data or error log (please format your code or data):
I created specially for your a whole sample project, with a readme.md file where you will find everything.
I invited you, this is a private repo call "cordova-gmap-sample-error".
Thank you for your help. If we have to pay for your support, please send an estimate and invoice
Regards.

I recommend you to recreate bland new project

This is a brand new project, let's take a look to the private repository I gave it to you.
Please have a look to the repo I share with you, I take the time to prepare that for you. I need an answer please. If you want money we can pay, we are a delivery company in Canada using your plugin into our app we need this to work with our platform.
It seems there is a problem with the transition management with the last version of your plugin.
Thank you.

This thread moved to private repository. I close this thread.


Remove bare-metal dependency from generated crates

The only dependency on bare-metal was the implementation of the Nr
trait which has been removed from version 1.0.0
(rust-embedded/bare-metal#32).
Closes #453
Signed-off-by: Daniel Egger<EMAIL_ADDRESS>

r? @Disasm
(rust_highfive has picked a reviewer for you, use r? to override)

We still want the Interrupt enum on Cortex-M to impl cortex_m::interrupt::Nr, otherwise it can't be used with the cortex-m NVIC methods. The difference is moving to an Nr trait defined by each architecture crate instead of defined in bare-metal, at least as I understood it.

We still want the Interrupt enum on Cortex-M to impl cortex_m::interrupt::Nr, otherwise it can't be used with the cortex-m NVIC methods. The difference is moving to an Nr trait defined by each architecture crate instead of defined in bare-metal, at least as I understood it.

I see, so we need architecture dependent implementations instead? However I don't see those yet on the horizon, even cortex-m doesn't seem to have that yet: https://github.com/rust-embedded/cortex-m/blob/b70c25a9b887fc19ce94a9789a34c1a036186c76/src/interrupt.rs#L5
I have no problem keeping this open for now but we should come up with a definitive plan how we're going to adress that.

I don't think this is a problem for svd2rust; we simply use cortex_m::interrupt::Nr and impl Nr as before; when cortex-m swaps to bare-metal 1.0 it will add its own Nr trait instead of exporting the bare_metal one, and svd2rust PACs will eventually update to use cortex-m 1.0 without needing any other Nr-related changes. I expect the same thing to work out for the other architectures.
For today, we should be able to just start using the re-exported Nr available in each architecture crate instead of the bare-metal one.

I don't think this is a problem for svd2rust; we simply use cortex_m::interrupt::Nr and impl Nr as before

Isn't that a contradiction? If the generated PACs need to use cortex_m::interrupt::Nr that is a problem for svd2rust since it needs to generate the code to do exactly that.
So if I'm reading you right the change needs to be redone to use the architecture specific re-export of interrupt::Nr?
Alternatively, couldn't the architecture specific crates implement this trait themselves if we're already defining it there? The big thing which hasn't been able in the beginning but was added later is the #[repr(u8)] on the enum so it is actually possibly to externally figure out the associated interrupt numbers. Or even get rid of the Nr trait and let the routines take an interrupt by enum kind instead of something with a bound to the Nr trait.

Sorry, I meant it's not a problem for svd2rust since it's possible for svd2rust to generate PACs which use the arch crate Nr trait and implement it, which will then keep working with the arch crate interrupt methods.
You're right though, we could also change the arch crates to not use Nr in their methods and instead take raw u8s, or somehow take an Interrupt enum (but how would they get the right type?). I think one of the reasons to split this is that some architectures may need a larger type than a u8 to identify the interrupt. Removing Nr was @jonas-schievink's change, perhaps he remembers what we intended to do in the arch specific crates?

Uhm, well the signature of Nr was:
pub unsafe trait Nr {
    /// Returns the number associated with an interrupt.
    fn nr(&self) -> u8;
}

so basically up to recently you only had three options to use that anyway:

Take a the interrupt number by u8 directly and let someone else use the nr method to get that (or in more recent versions simply cast it to u8)
Have your function take a T: Nr parameter and call nr yourself on that
Have your function take a parameter of PAC-specific enum type Interrupt and cast to u8

Option 3 would still work and seems the most natural to me. We could even change the repr in the PAC to something else than u8 if required and things would still work since only the architecture needs to know whtat to cast to. I do think using the interrupt name is most natural anyway (unless of course someone decides to not name them so we have to come up with names like Interrupt116 😅).

Looks good to me, however highfive still thinks I'm in the tools team :)

Have your function take a parameter of PAC-specific enum type Interrupt and cast to u8

How can cortex_m::peripheral::NVIC::request<I: Nr>(interrupt: I) use the PAC-specific enum type?

Have your function take a parameter of PAC-specific enum type Interrupt and cast to u8

How can cortex_m::peripheral::NVIC::request<I: Nr>(interrupt: I) use the PAC-specific enum type?

No idea yet, marker Trait?. OTOH I just checked and the only place where the ominous Nr trait is even used is https://github.com/rust-embedded/cortex-m/blob/master/src/peripheral/nvic.rs which makes it rather dubious. Instead of having such a unprotected trait we could as well use something like cortex_m::peripheral::NVIC::request<I: Into<u8>>(interrupt: I) which has the added benefit of allowing someone to pass an interrupt number directly rather than having to crate a newtype and implement Nr on that.

Wouldn't a marker trait just be Nr, defined in cortex-m and implemented for enum Interrupt by svd2rust in the PAC?

we could as well use something like cortex_m::peripheral::NVIC::request<I: Into>(interrupt: I)

This seems fine too, though I don't know if allowing users to pass a u8 is an "advantage" when they "should" be passing an Interrupt variant from their PAC.

Wouldn't a marker trait just be Nr, defined in cortex-m and implemented for enum Interrupt by svd2rust in the PAC?

I'd define the marker trait in the PAC and leave out the useless nr method.

This seems fine too, though I don't know if allowing users to pass a u8 is an "advantage" when they "should" be passing an Interrupt variant from their PAC.

Well, the Nr trait does not provide that guarantee anyway since it is public. Nr is just a bespoke Into<u8>. With the obvious disadvantage that whenever u8 doesn't cut the mustard for an architecture anymore, the Nr trait (as-is) would be working against us.

To summarise the discussion from today's meeting about this, we decided:

Arch crates such as cortex-m will define a new InterruptNumber trait
The trait will be unsafe as it has certain preconditions required for memory safety: each variant in an enum that implements the trait must map to a unique integer and must always map to the same integer, to ensure nested interrupt enable/disable calls with the same variant perform the correct action
svd2rust will generate implementations of these arch-specific crates for each supported arch: the implementations will probably look just like the current Nr implementation

This is a breaking change across the bare-metal/arch crate/svd2rust/PAC ecosystem so we'll have to manage it with the various 1.0 releases we have planned.

As discussed in todays meeting this is blocked on a cortex-m release. Once that is done we'll move over the ARM target from bare-metal to cortex-m and keep other targets on the old bare-metal for the time being.

As discussed in todays meeting this is blocked on a cortex-m release. Once that is done we'll move over the ARM target from bare-metal to cortex-m and keep other targets on the old bare-metal for the time being.

Additionally, it sounds like msp430 doesn't use the Nr implementation at all, so we can probably remove it without replacement.

My proposal for MSP430 is to:

Remove the Nr trait.

Keep the Interrupt enum, and change the docstring of Interrupt to the following to signify intent:
#[doc = r"Enumeration of all the interrupts. This enum is seldom used in application or library crates. It is present primarily for documenting the device's implemented interrupts."]

From this weeks discussion: Didn't get to it, will look into making the changes for MSP430 and Cortex-M soon, RISC-V is still pending on input from the team.

Same for RISC-V I think: remove the Nr trait, keep the Interrupt enum. One can always use as u8 instead of .nr().

Well, for MSP430 we're only keeping it for documentation purposes. For Cortex-M they're actually used and in general the assumption would be that it makes sense to copy what Cortex-M is doing...

The Interrupt struct is useful for RISC-V, because interrupt controller operates with interrupt numbers, so we need to convert interrupt names and numbers back and forth.

@Disasm The question was not about the Interrupt enum but about the replacement or necessity of the Nr implementation. As mentiond in new code https://github.com/rust-embedded/cortex-m/blob/master/src/interrupt.rs#L5-L24 (PR: https://github.com/rust-embedded/cortex-m/pull/241) and https://github.com/rust-embedded/svd2rust/pull/455#issuecomment-655191376 as well as in the meeting the conclusion was that it might be helpful to not use the conversion to a plain number directly but have a new unsafe trait and document the invariants which must be upheld.

@therealprof Thanks for clarification. Indeed, we could do something like this for RISC-V, but right at the moment such Nr-like trait is useless for this arch. All interrupt controllers in RISC-V chips are different, even those that are "compliant". Because of this, there is no common driver for these controllers and no need for a separate trait on riscv/riscv-rt level.

I think we can close this, right?

I think we can close this, right?


Adding viewport meta header to getting started tpl

Adding viewport meta header to getting started tpl in order to enable proper mobile support, which materialize does nicely

Good idea, thanks!


[CSSimplify] Exploaded tuple argument should assume param's label if …

…first element doesn't have one
If tuple doesn't have a label for its first element and parameter does,
let's assume parameter's label to aid argument matching.
For example:
func test(val: Int, _: String) {}

test(val: (42, "")) // expands into `(val: 42, "")`

Resolves: rdar://106775969

@swift-ci please test


Proposal to add "go.mod" file to Go exercises

I would like to propose for each Go exercise that there should be a "go.mod" file included. The exercises aren't added into GOPATH by default and without a "go.mod" file the Visual Studio Code Go extension fails to function correctly (Not running gofmt for example, which was the issue I was having).
These exercises don't have dependencies they need to manage, but the following Q&A supports that it is still a good idea to have a "go.mod" file:
Should I still add a gomod file if I do not have any dependencies?
What do you think? Is this a good idea? Thanks.

Is there not already a go.mod file added when you download a new exercise? I just ran exercism download --exercise=error-handling --track=go from VSCode and the exercise contains a go.mod file under the error-handling directory.
The VSCode go extension also works correctly. For reference, I am running a linux subsystem on Windows 10.
This issue should be closed.

Correct. We added them a while back.


Mid size insert account

What's wrong
#464

We'll have more idea what utilities we should add after we have the devnet runnnig


where is the consensus?

Maybe you should try to adapt PBFT or other consensus mechanism, you may fork this repo and send a pull request. :)

can chang-chain use in your project??

why you close my issue？If i leave harbin i will open the link。

I will let him notice your disloyalty.


Allow merging of json_schema_extra for annotated fields

Change Summary
Allow merging of json_schema_extra with priority given to fields defined later 😄.
Related issue number
Fix #7686
Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[x] Unit tests for the changes exist
[x] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Please review

Closing for now as this isn't a change we're looking to add (due to the breaking behavior). Happy to revisit later if there's more general support.


static inline functions are not within extern C

Hi all,
Actually the complete sds.h is not inside an extern C {. This causes issues when hiredis is included in C++.
Why not put the extern C at the top of hiredis.h?
https://github.com/redis/hiredis/blob/master/hiredis.h#L107-L109
Thanks,
Rik

I am using hiredis with g++ without any problem.
What problem do you have exactly?

I'm compiling my code with -Wold-style-cast and -Werror, now I need to make an exception for every file where hiredis is included.

@rikvdh You can use this way to include hiredis.h
extern "C" {
#include "hiredis/hiredis.h"
}


Update msg.c

Typedef for msglen_t missing in header files.Thus, unsigned long proposed as solution, that fix the issue when compiling with lua5.3 on OpenBSD 7.5 amd64 arch.

Thank you for the report and the PR.
Rather than guess at the underlying type, and potentially throw warnings on other compilers, it would be better to add a check_type feature to the configure table in https://github.com/gvvaughan/luke/blob/master/lib/luke/configure.lua#L285 so that we can  #define msglen_t unsigned long for C libraries that don't provide a proper msglen_t.
Would you be interested in working on that?

I would rather suggest a different approach, since the error is at compile time and only in msg.c source file, I suggest to add a patch to define msglen_t as unsigned long when the symbol is not found. Thus, I will open a new pull request and close this one instead. Regards.


Import third_party Go package github.com/lib/pq [phab:D699]

Created by schroederc at 2016-02-08 22:33:02:
This will be used for an experimental Postgres serving backend

shahms wrote at 2016-02-08 22:35:30:
Can we not just do this as a new_git_repository() in our WORKSPACE?

schroederc wrote at 2016-02-08 22:39:53:

! In (earlier comment), shahms wrote:
Can we not just do this as a new_git_repository() in our WORKSPACE?

Possibly.  I'm not sure how stable that API is, but from past experience, it'll be changed and break us.  I'd rather stick with the current approach for now.
I'll look into using new_git_repository() in a future refactoring.

shahms wrote at 2016-02-08 23:52:13:
We really do need to revisit our external dependency story.  Aside from "core" dependencies like LLVM, copying them all into our repo isn't scalable.

shahms accepted this revision at 2016-02-08 23:52:13

schroederc closed via commit ec173bd1806a51b424ed5814966c7aec61981225 at 2016-02-09 00:30:20


Azure Retail Pricing API

Describe the bug
We can't get any premium storage pricing by Azure Retail Pricing API, like premium file storage or premium blob storage. And Azure Retail Pricing API have no detail document introduce value of property.
To Reproduce
https://prices.azure.com/api/retail/prices?$filter=serviceFamily eq 'Storage' and armRegionName eq 'eastus2'

@tcbjc Please contact product support at https://azure.microsoft.com/en-us/support/options/


Incorrect function overload in argument type with ThisType

🔎 Search Terms

function overload
ThisType
this

🕗 Version & Regression Information

This is a crash

⏯ Playground Link
https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIHt3IN4ChnJwBcyAzmFKAOa4C+uAJhAgDZxQowCuICYw6EMm4gADAAp2VEuICUyALwA+ZOPzIAZGkzqtAFQAWwUnoCeABwgAeDOiW5ZskgDd0wBo2ZsOwnnwFCIhJSMrrIAArs-HAsNpj2BPpGJhbWtvaOLm4euEHieAD0BcgAegD86sTIAOQAjNV0srk8EnKKKvm4RaUVBFV1DbSOXcUAAmCkALQQAB6WfNNQUOhQzWLibcqqhcXllSS1jU1AA
💻 Code
interface Foo {
  a: string
}
declare function fun0(arg: () => (
  & Foo
  & ThisType<Foo>
)): void
declare function fun0(arg: (
  & Partial<Foo>
  & ThisType<Foo>
)): void

fun0({
// ^? function fun0(arg: (Partial<Foo> & ThisType<Foo>)): void (+1 overload)
  a: '1'
})
fun0(() => ({
// ^? function fun0(arg: () => (Foo & ThisType<Foo>)): void (+1 overload)
  a: '1'
}))
// @ts-expect-error
fun0(() => ({
// ^? function fun0(arg: (Partial<Foo> & ThisType<Foo>)): void (+1 overload)
  a: 1
}))

When I intersect ThisType with a type similar to {} and use it as a function argument, it will always resolve to this declaration.
🙁 Actual behavior
overload to function fun0(arg: (Partial<Foo> & ThisType<Foo>)): void (+1 overload)
🙂 Expected behavior
overload to function fun0(arg: () => (Partial<Foo> & ThisType<Foo>)): void (+1 overload)
Additional information about the issue
When I comment ThisType intesection, it works.

none of those are errors:
interface Foo {
  a: string;
}
declare function fun0(arg: Partial<Foo> & ThisType<Foo>): void;

fun0(() => ({
  a: "1",
}));
fun0(() => ({
  a: 1,
}));
fun0(function () {
  this.a; // errors
  return {
    a: 1,
  };
});

I understand the situation you're describing, but I believe that a {} type, even when intersected with ThisType, should maintain its original logic and remain unchanged, just as if there were no ThisType involved.
Just as I demonstrated in the "Additional information about the issue"

Here, we can see that there is actually a more accurate type error message for this type, but it is being ignored in favor of finding a best possible match instead of alerting us to this error during compilation. I believe this behavior is not quite appropriate.

It seems like it behaves somewhat as expected, but I still believe this is an issue that should be fixed.

the interface acts like any empty interface.

More minimally:
interface Foo { a: string }

// No error, but should
const m1: Partial<Foo> & ThisType<{ x: string }> = () => null;

// Correctly errors
const m2: Partial<Foo> = () => null;


Refine GitHub crawling

Think about further data we might want to grab from the GitHub repository while we're at it. Maybe do further content analysis:

Are there contribution guidelines?
What's the README structure? Are there some keywords? Is it worth it to process this using an NLP model?

Does it contain emojis?

Issues: What is the closing rate? How long does it take for an issue to be closed?


Revert allowing for multiple accounts

After playing around with this funcionality, it looks like the tradeoff adds a lot of complexity that's not really worth the effort. It's way easier to just run as many exporters as you need/want, each with its own configuration.
So, reverting back to the original code design.

Even cooler to have less code to maintain 😎 🚀


would be great if list was table-based with "last commit date" and "number of stars" column.

That would really help me decide on which ones to look at. Not interested at all in projects that haven't been updated in over a year.

https://docs.google.com/spreadsheets/d/1VEEehS7VYrvvn1cLEyE6R04ryD_QP2qjN7VQHKTFfNs is a table with features


Upgraded to epicsa-python 0.0.2

Upgraded epicsa-climate-api to epicsa-python 0.0.2.
There are no functional changes to the new version of epicsa-python, it just has a different version number.
I also upgraded the README to show how to check that the correct version of epicsa-python is installed.

@chrismclarke Please could you review/merge? thanks

@chrismclarke I upgraded the R pacakages so that this PR is using the latest version of all the epicsa packages.
I did some testing and everything seems to function as it should (i.e. the endpoints return the same results as calling the R functions in RStudio).
This PR is ready for your review/merge.
Thanks

@ChrisMarsh82
I think this PR might be a bit old/outdated now, appears the main intended changes have already been merged/superceded so all that's left if some readme updates. I'm gonna close here and we can always migrate the readme updates to a fresh PR to save constantly pinging @lloyddewit with updates


tests: add test for headers in compute

add test for headers
make error message more descriptive for https://github.com/googleapis/java-compute/issues/573

@vam-google please review

@vam-google @georgiyekkert Thank you.


@svgr/webpack: Add React Runtime Option

Simplifies the fix for #653, and should hopefully smooth things over for people not using babel in their projects

Might not be needed...

Hi @BeeeQueue, what was the reason for closing it and it not being needed? Is there some other approach to solving the issue?

I figured i could use output options for svgr instead, but iirc neither that or this fixed the issue i was having

I'm not familiar with the output options much, but, what was the issue you were running into? I was actually looking for the very fix you had to pass in the runtime option.

Any way you could still get this merged in? :)

The options I'm referring to is jsx-runtime, if @gregberge wants to merge this they can open it again (I think)

Ah ok yeah, that makes sense. For me jsx-runtime solved part of the issue as it still was required to be passed into babel.
Any possibility of geteting this merged in @gregberge? Or do you recommend an alternative route? My comments were in #653

Hi @gregberge, just checking-in again to see if this is something you'd possibly consider to merge in?


General bug

I'm having an issue when using this alongside streamdeck
I've assigned a hotkey switch, so when pressed it will open ppInk, when pressed again it will close it.

After that I can't do anything and it messes up my config file and have to start again

I'm having an issue when using this alongside streamdeck
I've assigned a hotkey switch, so when pressed it will open ppInk, when pressed again it will close it.

After that I can't do anything and it messes up my config file and have to start again

Can you please send the failing config file you have modified ?
Also, Can you describe how you've got a second crash

What I meant is that it resets my config file. I'm trying to reproduce this again

I got another error, I can confirm that I didn't use streamdeck with it on this time

A memory leak has been found. A beta version has been submitted last post of #75. However I'm not sure it is your issue. Can you please send the config.ini you are using
Thx

Here is the config file
config.txt
Renamed to txt

Have you been able to test the version from #75 ?

Problem is I'm not able to reproduce this bug to confirm, let me use it a bit more with the beta and report back when it happens again

Shall I close this issue and reopen again if it happens ?

Agree with your approach


Plin 3658 revert json merge

https://skuidify.atlassian.net/browse/PLIN-3658

yall... this is a massive conflict and this should be resolved using v1.0.0...

please take a look at sort.go in the new PLIN-3600 branch


Recursive tag creation on Page

I haven't tested on Articles yet.
Locally, in development, when I create a Page and tag it "foo, bar", the two tags are created.
If I edit that page, then save, the tags are duplicated. "foo, foo, bar, bar".
This happens with each successive update.

@withoutboats

I know what this is, will have a PR in a few minutes.


Port ArrayRepeat to functions-array subcrate

Which issue does this PR close?
Closes #9565.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic https://github.com/apache/arrow-datafusion/issues/9285:
1- ArrayRepeat is ported to functions-array subcrate,
2- Minor cleanup by removing redundant package definitions.
Are these changes tested?
Yes, all array.slt based array_repeat tests are passed.
Are there any user-facing changes?
No

cargo test (win64) build stage is failed due to:
error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)

Is it possible to re-trigger the build?

cargo test (win64) build stage is failed due to:
error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)

Is it possible to re-trigger the build?

I had re-run it once, but the same error is occured.

@jayzhan211 Thanks for triggering the build and merge.


JsonSerializationException - CosmosDbStorage.ReadAsync: Cannot populate JSON object onto type 'Microsoft.Graph.CallParticipantsCollectionPage'

Version
4.2.
Describe the bug
The exception throws upon the ReadAsync of CosmosDbStorage
IDictionary<string, object> items = await _storage.ReadAsync(new[] { fullStorageKey }, cancellationToken).ConfigureAwait(false);

Detail exception message as below:

Exception caught: 'Newtonsoft.Json.JsonSerializationException' in System.Private.CoreLib.dll ("Cannot populate JSON object onto type 'Microsoft.Graph.CallParticipantsCollectionPage'. Path 'participants.$type'.") Exception caught: 'Newtonsoft.Json.JsonSerializationException' in System.Private.CoreLib.dll ("Cannot populate JSON object onto type 'Microsoft.Graph.CallParticipantsCollectionPage'. Path 'participants.$type'.")

After reading the following source code, seems like it gets some trouble while trying to understand the corresponding JsonContractType of the Microsoft.Graph.CallParticipantsCollectionPage, however, I'm not 100% sure it's a bug or just I need do some special setting.
It would be appreciated if there is any workaround can make the CosmosDbStorage be able to read the item I stored into cosmos DB that has property of Microsoft.Graph.CallParticipantsCollectionPage type exists.
https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs
public class CallParticipantsCollectionPage : CollectionPage<Participant>, ICallParticipantsCollectionPage, ICollectionPage<Participant>, IList<Participant>, ICollection<Participant>, IEnumerable<Participant>, IEnumerable

                "participants": {
                    "$type": "Microsoft.Graph.CallParticipantsCollectionPage, Microsoft.Graph.Communications.Core.Calls",
                    "$values": [
                        {
                            "$type": "Microsoft.Graph.Participant, Microsoft.Graph.Communications.Core.Calls",
                            "info": {
                                "$type": "Microsoft.Graph.ParticipantInfo, Microsoft.Graph.Communications.Core.Calls",
                                "identity": {
                                    "$type": "Microsoft.Graph.IdentitySet, Microsoft.Graph",
                                    "application": {
                                        "$type": "Microsoft.Graph.Identity, Microsoft.Graph",
                                        "id": "37af506a-8b24-4fca-a359-f3b887500000",
                                        "tenantId": "80dfc884-160d-455b-8e52-476de0700000"
                                    }
                                },
                                "endpointType": "default"
                            },
                            "mediaStreams": {
                                "$type": "System.Collections.Generic.List`1[[Microsoft.Graph.MediaStream, Microsoft.Graph.Communications.Core.Calls]], System.Private.CoreLib",
                                "$values": [
                                    {
                                        "$type": "Microsoft.Graph.MediaStream, Microsoft.Graph.Communications.Core.Calls",
                                        "mediaType": "audio",
                                        "sourceId": "1",
                                        "direction": "sendReceive",
                                        "serverMuted": false
                                    }
                                ]
                            },
                            "isMuted": false,
                            "isInLobby": false,
                            "id": "5528d3db-8e6a-4ae2-a86b-571e6300000"
                        }
                    ]
                },

@dawwa Can you include enough of your code that will allow me to repro this or a link to your repo? Is that last code block the data you're trying to store and retrieve?
I wouldn't expect any changes to be made to CosmosDbStorage, especially for custom usage not related to BotState, since it's going to be deprecated soon. You can always create your own storage class, if needed.
That being said, I'm happy to troubleshoot this and search for a workaround.
Your best bet would be to pass in a different serializer

@dawwa Do you still need help with this?

@dawwa I'm going to close this issue due to inactivity. Feel free to re-open if needed.


Fix csv 4.0

Fixes the issue with certain CR fields being removed after upgrading to v4.0.0

hey @pb82 can you send on the catalogsource? i'd like to try it out with OLM

@HubertStefanski the following CatalogSource can be used to verify the changes:
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: grafana-operator-manifests
  namespace: grafana
spec:
  sourceType: grpc
  image: quay.io/pb82/grafana-operator-index:v4.0.0

To verify the whole migration:

Install v3.10.3 from OperatorHub
Install Grafana, some dashboards and data sources
Uninstall the Grafana Operator
Install v4.0.0 using this CatalogSource (create the CatalogSource inside the same namespace, after a minute or two you should see a new category in the Operatorhub page in OpenShift).
Verify that all dashboards and datasources are still there and are reconciled.
Verify that all configuration options are still there and managed.

@pb82 I'm still unsuccessful in getting it to work, the OLM deployment hangs on pending waiting for requirementsNotMet, the operator pod also doesn't spin up, let's sync the next day and try and figure this out, not sure why this is happening when yours works, perhaps it could be something specific to what my ROSA cluster is running

Adding some more context, looks like some auth resources are missing, trying to figure out why,
 message: one or more requirements couldn't be found
  phase: Pending
  reason: RequirementsNotMet
  requirementStatus:
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      message: CRD is present and Established condition is true
      name: grafanadashboards.integreatly.org
      status: Present
      uuid: 2e1ed639-faf0-472b-b828-8695fd634bef
      version: v1
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      message: CRD is present and Established condition is true
      name: grafanadatasources.integreatly.org
      status: Present
      uuid: 1b178053-7bd9-4f9c-8351-0293742b910c
      version: v1
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      message: CRD is present and Established condition is true
      name: grafanas.integreatly.org
      status: Present
      uuid: 6f3621f8-912f-4c8e-85a0-60ff9f1d96ea
      version: v1
    - dependents:
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            namespaced
            rule:{"verbs":["get","list","watch","create","update","patch","delete"],"apiGroups":["","coordination.k8s.io"],"resources":["configmaps","leases"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            namespaced
            rule:{"verbs":["create","patch"],"apiGroups":[""],"resources":["events"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":[""],"resources":["configmaps","persistentvolumeclaims","secrets","serviceaccounts","services"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","get","list","watch"],"apiGroups":[""],"resources":["events"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["get","list","watch"],"apiGroups":[""],"resources":["pods"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["apps","extensions"],"resources":["deployments","deployments/finalizers"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["integreatly.org"],"resources":["grafanadashboards"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["get","patch","update"],"apiGroups":["integreatly.org"],"resources":["grafanadashboards/status"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["integreatly.org"],"resources":["grafanadatasources"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["get","patch","update"],"apiGroups":["integreatly.org"],"resources":["grafanadatasources/status"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["integreatly.org"],"resources":["grafanas","grafanas/finalizers"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["get","patch","update"],"apiGroups":["integreatly.org"],"resources":["grafanas/status"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["networking.k8s.io"],"resources":["ingresses"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["route.openshift.io"],"resources":["routes"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create"],"apiGroups":["authentication.k8s.io"],"resources":["tokenreviews"]}
          status: NotSatisfied
          version: v1
        - group: rbac.authorization.k8s.io
          kind: PolicyRule
          message: >-
            cluster
            rule:{"verbs":["create"],"apiGroups":["authorization.k8s.io"],"resources":["subjectaccessreviews"]}
          status: NotSatisfied
          version: v1
      group: ''
      kind: ServiceAccount
      message: Policy rule not satisfied for service account
      name: default
      status: PresentNotSatisfied
      version: v1

@Bobbins228 the missing custom dashboards are expected because the Grafana pod gets restarted and those dashboards only exist on the pod unless an external database is used.

@pb82 Okay my bad everything works just fine, nice work Peter.


Vue component change the z-index

Version
2.2.4
Reproduction link
https://jsfiddle.net/Roam/hcswpjcb/1/
Steps to reproduce

Just make a vue component，write z-index in style
Run command: npm  run dev，everything fine
Run command: 'npm run build`，what a mess...my z-index value changed

I think the z-index value shouldn't be changed，because we may use the third party plugin like jQuery plugin which could use z-index. In this condition, the z-index calculation is unnecessary, and make mistakes.
What is expected?
keep my z-index value
What is actually happening?
my z-index changed

External styles are not affected by Vue. Also this is not a repro 😑

This is actually an issue for the webpack CLI template - I have turned off unsafe optimizations in the latest template.


[REQUEST]Remove Banned/Bad proxies from the proxylist

Is your feature request related to a problem? Please describe.
when you use all proxies in the runner then they all get refreshed again even if  some of them are bad or banned proxies
Describe the solution you'd like
if the proxies are saved in a dynamic array you can make a for loop that checks if the proxy has banned/bad status if yes then remove that from the list  if not keep it in the refresh list.
and you could trigger that for loop maybe by putting the loop in a if statement that triggers the for loop only when "total proxies"==0 or if its possible you remove them instantly when they get the bad/banned status
Describe alternatives you've considered
i heard that the proxies are saved on a databases or something from pure. i dont know how databases work but maybe you can sent a request to remove proxies that had the bad/banned status in the runner.

The proxies are used until all of them are banned, so doing what you suggest would mean deleting all the proxies. You should rather set up a reload API instead.


Adding stopping criteria unit-test

In GitLab by @cmastalli on Nov 15, 2018, 10:51

In GitLab by @nmansard on Nov 15, 2018, 11:48
@cmastalli started to work on this issue and should be the one taking this task. Refer to him if you would like to take the lead on this task.

In GitLab by @cmastalli on Nov 27, 2018, 17:41
Qu represents the gradient of a DDP interval given an updated Hessian of the Value function Vxx_p. If Vxx_p provides a good estimation of the problem, then we can assume that Qu is the gradient of our OC problem.
Instead Qu.T * Quu^-1 * Qu represents the progression of the optimization. In fact, this is used as Armijo rule.
General speaking, we could use the norm of Qu as stopping criteria. However, I see cases where this value is very small (around 10^-5) and still there is a significant improvement, i.e. value of  Qu.T * Quu^-1 * Qu (around 10^-3).
We could have use both values as stopping criteria, @nmansard do you think this is a good idea? or just make complex our code.

In GitLab by @cmastalli on Dec 3, 2018, 13:20
mentioned in merge request !27

In GitLab by @cmastalli on Dec 3, 2018, 13:34
I included an simple test for stopping criteria in the LQR case (!27). Basically, I build and solve a KKT problem for LQR problem. Then I checked that the gradient of the Lagrangian is equals zero.
Note that this test only works for linear system with quadratic cost functions.
Please check the code here: https://gepgitlab.laas.fr/loco-3d/cddp/blob/devel/unittest/ddp.py#L98
Do you think we need a test for nonlinear systems? @nmansard

In GitLab by @cmastalli on Dec 3, 2018, 13:37
assigned to @cmastalli

In GitLab by @nmansard on Dec 4, 2018, 07:58
We have the jacobian of the constraint to be (with explicit x0 variable and constraint x0=x0ref):
J = [   I             0              ]
[ -fx   I        -fu             ]
[     -fx   I         -fu        ]
[           ...          ...     ]

The transpose multiplies one lambda per timestep from 0 to T, and produces one "equality" per x and one per u. Looking only at the part of J^T corresponding to x, we have one main diagonal of I and a subdiagonal of -fx. Hence:
lambda_T = - lx_T
and recursively
lambda_t - fx^T lambda_t+1 = - lx_t+1
This recurence is just the same as the recurence on the Vx, so lambda_t = Vx_t.

In GitLab by @cmastalli on Dec 6, 2018, 17:39
I implemented an unit-test for stopping criteria in LQR problems. After solving the analogous KKT problem, I computed the gradient of the Lagrangian from the multipliers (see https://gepgitlab.laas.fr/loco-3d/cddp/blob/topic/unittest/unittest/ddp.py#L104). Then I check that its norm is equals to zero.

In GitLab by @cmastalli on Dec 6, 2018, 17:49
I will close this task since it's been merged in !29.

In GitLab by @cmastalli on Dec 6, 2018, 17:49
closed


Fix standard-IA pattern matching to remove it from reco calculations

Issue #, if available: #9
Description of changes:
Updated regex and unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

unit and functional tests pass with new billing data with S-IA usage.

Added --version to reco tool. v1.1.0 has the fix for this issue. Going to merge this in now.


[5.3] Performance issue when calling Eloquent model getAttribute() thousands times

Laravel Version: 5.3
PHP Version: 5.5
Database Driver & Version: MySQL 5.5, using PDO Mysql

Description:
Hi,
It's not really an issue i've but a question. Unfortunately i've to deal with old server in hardware as well as php version. Upgrading is not really an option.
I'm using eloquent and on a large page, i fetch about 1 000 eloquent models and also have a very huge view which calls a lot of attributes of these models. The performance are not that terrible, about 1.4s to load, but could be improved. When profiling the page, i found that most of the execution time is spent on Illuminate\Database\Eloquent\Model::__get() (and others method behind such as hasCast(), ...) which is called about 11 0000 times.
Behind __get(), a lot of method are called much more such as hasCasts(), hasMutator(), ... and here relies the bottleneck.
Is it necessary to call these method each time we want to get an attribute ?
Cast, mutator, accessor and others stuff checked by __get() method are defined once on the class and are never redefined if i'm correct. So is there any potentiel issue to cache the result of __get() the first time and remove the attribute from the cache when calling __set() ?
This very simple trick reduced the numebr of method call and the page load time (between 30 and 40%) :
use Illuminate\Database\Eloquent\Model;

class CachedModel extends Model
{
    protected $cache = [];
    public function __get($name)
    {
        if (!isset($this->cache[$name])) {
            $this->cache[$name] = parent::__get($name);
        }

        return $this->cache[$name];
    }

    public function __set($name, $value)
    {
        if (isset($this->cache[$name])) {
            unset($this->cache[$name]);
        }

        parent::__set($name, $value);
    }
}

Thanks for your response.

That depends on how you use it, if you simply call the property 1 time then caching is meaningless. Anyway, feel free to propose a PR with the changes proposed and for performance issues like this I recommend that you attach some profiling information.


Refine pig[gy-bank]/additional animal icons

Related to #988, #1234, crab and waves-shark-fin in #1393, and spider/-web in #1495.
beetle-scarab matches bug-* icons in #988.

bear-face: cute but to big
butter-fly: the antenna don't have 2px gap
cat-big: not cute :/
cat: I liked the old version
dog: I liked the old version
frog: hard to identify, I confused the nose holes with the eyes
owl: big fan :owl:, maybe slightly big but pretty great anyway :+1:
pig & piggy-bank: I'm not a fan of the old version nor the changes

I also prefer kemie's cat and dog icons, they're simpler and cleaner, yours aren't bad either, but I think the originals are a better fit for Lucide.
Also throwing in some animal icons from my drafts. Emphasis on drafts, some of these are pretty rough and/or have guideline violations:

https://www.figma.com/file/bCInvFWeG11jvpR14O7goR/lucide%2Fanimals?type=design&node-id=0%3A1&mode=design&t=vK5XOX8OFZ2q1gJu-1

This PR is merged to the lab branch. This PR does not match our PR template, which requires valid use cases. To move on we merged this PR to the lab branch, which will be moved to a separate repo in the future.


Can't assemble netherrack

self explanatory

In the blacklist file to make sure you won't assemble the nether

There's a list of blocks that won't assemble normally as they're part of the ground. This prevents you from assembling the entire universe accidentally. You'll have to add the netherrack after it's assembled.


Failed transactions seem to persist changes for snowflake database

Description
Failed transactions seem to persist changes of the queries above the one that failed when a select is executed, but in fact it does not happen.
Example: -- have been put in the steps to reproduce
assume that all values for "col" are 0
Begin
Begin Transaction;
update table set col = 1 where ID = 1
update table set col = 2 where ID = 'foo' -- fails
update table set col = 1 where  ID = 3
Commit;
End;
Select col from table where id = 1 ---> Shows col value to be 1
Right click on the connection -> *invalidate/reconnect to database *
Select col from table where id = 1 ---> Shows the actual value previous of the transaction execution (0 which is correct)
DBeaver Version
22.2.2, 20...., 21...
Operating System
Windows 10, Windows 11
Database and driver

Database: Snowflake
Driver: snowflake_jdbc
Libraries: snowflake-jdbc-3.13.6.jar

Steps to reproduce

assume that all values for "col" are 0

execute a failing transaction inside BEGIN/END keywords
Begin
Begin Transaction;
update table set col = 1 where ID = 1
update table set col = 2 where ID = 'foo' -- fails
update table set col = 1 where  ID = 3
Commit;
End;

Select on the updated items before the failed query (value is the updated one, incorrect since transaction failed)
Select col from table where id = 1 ---> Shows col value to be 1

Right click on the connection -> *invalidate/reconnect to database *

Perform the previous select
Select col from table where id = 1 ---> Shows the actual value previous of the transaction execution (0 which is correct)

Additional context
No response

Hello @tudorpop9,
How exactly are you executing that block?
I suggest selecting it and pressing the Ctrl+Enter shortcut.

There have been no updates on the issue for a long time.
If it is still actual for you - feel free to reopen it with additional info.


design(TextInput): final design review for TextInput component

closes #239
The TextInput component was already dev verified https://github.com/cfpb/design-system-react/issues/239.
Final Design Review of TextInput Component
Verify TextInput component to be used in the component library
Link: https://deploy-preview-279--cfpb-design-system-react.netlify.app/?path=/docs/components-verified-text-inputs--overview
Context
See https://cfpb.github.io/design-system/components/text-inputs
Verification checklist
For existing components
Verify the CFPB Design System (React) component against the CFPB Design System

[x] Has component intro text copied from the DS page
[x] Has source link to component's DS page (ex - Source: https://cfpb.github.io/design-system/components/banner-notification)
[x] Each DS variant is implemented as a separate story

[x] Story name should be sentence case (ex. List Link => List link)
[x] Naming is consistent with the DS
[x] Same component names, same placeholder text, etc.

[x] Order of stories matches between DS/DSR
[x] Component is built correctly

[x] Visually compare DSR implementation to DS
[x] Verify that DS classes (organisms, molecules, atoms) are used, as opposed to styles defined in DSR

[x] Manual visual review has been conducted and component has passed this review

#### For new components
- [ ] All steps for existing components plus the following steps
- [ ] The new component has been added to the CFPB Design System OR
- [ ] The CFPB Design System maintainers have been alerted that there is a new component that must be added to the system
- [ ] Documentation has been written for the new component (this is not a blocker for moving a component to verified)
Run accessibility checks

[x] Component is keyboard-friendly (navigable with tab, space, enter, arrow keys, etc.)
[x] Component does not introduce new errors or warnings in WAVE
[x] Component is screen reader friendly (screen reader testing demo)

[x] Is all the meaningful visual information and text of the component conveyed by the screen reader? (text, non-decorative image descriptions, etc.)
[x] When interacting with the component using a screen reader, do you have all the information you need to use it? (selected vs unselected, button vs link, expanded vs collapsed, etc.)
[x] Does the component have similar screen reader behavior as the sample components in WCAG, the CFPB design system, WebAIM, or similar accessibility examples?

[x] For reference: CFPB manual web accessibility audit

Verify component unit tests

[x] Verify component unit tests are implemented and passing - 85% or greater (ex: yarn vitest Button)

Conduct PR review

[ ] The component has been reviewed and approved by UI, UX, and FEWD

Verify component

[ ] Move component to verified in Storybook

Heyo! Did Natalia already look at this to get it verified?

@shindigira
How would you like me to approach the verification of this component? We have pending DS changes to the hover colors for the different status states. Should we complete those changes before or after verifying?
In the DSR we show the different states for the standard text input as individual stories. For the status (Success, Warning, Error) we don't include stories for the states (Default, Hover, Focus). Should we include stories for these states?

@shindigira
As we discussed I'd like to group this component as follows:
Sidebar menu text:
Text inputs

Overview
Enabled
Hover
Focus
Disabled
Success
Warning
Error
Full width
With button
Button inside
Button inside (with button)

For Text area input, we discussed making it a separate component in the DSR. Can we do that as a part of this? Does the DS include state styling for Text area input? It's not visualized on the DS page but if it's in the code I'd like to pull it out/itemize it in the DSR.

@shindigira
This looks good.
@billhimmelsbach or @meissadia what are your thoughts on making Text area a separate component in the DSR? Text input and Text area input both live under "Text inputs" (same page) in the DS.  If we decide to do that we can go ahead and open a ticket since this will be needed for the forms work we will likely be doing.


Update Set-SPEnterpriseSearchQueryScope.md

Formatted example

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Set-SPEnterpriseSearchQueryScope.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Issue Fetching Updates in Game Mode

I see that the "latest" branch is selected by default in the Game Mode update menu. Unfortunately, clicking "Check for updates" causes an error which Steam will report, but does not detail what the error is.

The gamemode updater is just a wrapper for ublue-update, if you run that in a terminal do you get any errors?
Good time to also check rpm-ostree status and make sure you're on the :latest branch.

Also worth noting that as of today, Game Mode only shows a "System Update Channel" set to "Stable" under the "Beta Participation" section. No longer is there two sections like before, one for Steam and one for the OS. I wonder if that is a change on Valve's side.

Do you have developer options turned on and "show advanced update channel" toggled in game mode? That's the only way those showup.

Was this ever solved for you? Having the same problem with my Bazzite install at the moment.

Did a fresh install last month and the issue still persists for me sadly

I was thinking about doing a fresh install, but I can see that it's not guaranteed to solve the issue, so I'll wait for a while and see if there are other solutions to the problem.

Same issue here on fresh install update error in game mode.

I'm having the same error in game mode. Running ublue-update I receive no errors yet still unable to update.


Equation-oriented formulation

Develop an equation-oriented model formulation for centrifugal compressors.
Key elements to include:

Conservation of mass at each station

Conservation of rothalpy in each component

Velocity triangle calculations

Calculation of fluid properties with CoolProp:

Should we use enthalpy-entropy function calls as for the axial-turbine model?
Should we use pressure-enthalpy function calls only to be able to use look-up-tables easily?

Boundary conditions:

Stagnation pressure/temperature at inlet

Inlet mass flow rate (subsonic flow without choking)

Exit pressure or "throttle valve" boundary conditions for cases with choking in the future

Hi,
I would like to discuss some approaches for modeling the vaneless diffuser space. If I remember correctly from our meeting we planned to use the conservation of angular momentum with a loss term:
$$r_{in}c_{\theta, in} = r_{out}c_{\theta, out} + \Delta AM $$
Is this used in combination with a correlation for the pressure or enthalpy loss? I see Meroni presented an equation for calculating the exit static pressure:
$$p_{out} = p_{in} + CP(p_{0,in} - p_{in})$$
while in the Oh and Chaowei paper use a correlation for the enthalpy loss:
$$\Delta h = C_pT_{0,in} \left[\frac{p_{out}}{p_{0, out}}^{\frac{\gamma - 1}{\gamma}} - \frac{p_{out}}{p_{0, in}}^{\frac{\gamma - 1}{\gamma}}\right]$$

See dev_projects/centrifugal_compressor/model_development.md
I think that it makes sense to use the conservation of angular momentum with a loss term. This term can be calculated as a function of the friction factor.
For the losses, I suggest to use the enthalpy loss coefficient and calculate its value based also on the friction factor. I think that using the loss coefficient would is better ("closer to the physics") than the approaches using the diffuser effectiveness ($C_p$)

The framework for the Equation-Oriented approach is implemented. Equations for the following components are implemented:

Impeller
Vaneless diffuser
Vaned diffuser
Volute

The boundary conditions include the total inlet state, mass flow rate, rotational speed and inlet absolute flow angle. The model evaluates the equations for each component given these boundary condition, and accumulates the residual equations.
The independent variables and residuals for each component:

Impeller

Independents: $[v_\mathrm{in}, w_\mathrm{out}, s_\mathrm{out}, \beta_\mathrm{out}]$
Residuals: $[ \Delta m_\mathrm{in}, \Delta m_\mathrm{out}, \Delta Y_\mathrm{out}, \Delta v_{\theta ,s}]$

Vaneless diffuser:

Independents: $[w_\mathrm{out}, s_\mathrm{out}, \alpha_\mathrm{out}]$
Residuals: $[\Delta m_\mathrm{out}, \Delta Y_\mathrm{out}, \Delta AM]$

Vaned diffuser:

Independents: $[w_\mathrm{out}, s_\mathrm{out}]$
Residuals: $[\Delta m_\mathrm{out}, \Delta Y_\mathrm{out}]$

Volute:

Independents: $[w_\mathrm{out}, s_\mathrm{out}]$
Residuals: $[\Delta m_\mathrm{out}, \Delta Y_\mathrm{out}]$

For now, the calculations are done using enthalpy-entropy function calls.
Choking calculations will further add independent/residuals. See own task.
Nomenclature

$\Delta v_{\theta ,s}$: slip velocity residual, difference between slip velocity calculated by the given relative flow angle, and the slip velocity calculated by the slip model.
$\Delta AM$: Difference in angular momentum due to losses.


Distance grab stops working if a snapped object gets destroyed in script

NOTE: Any issue that does not follow the below template will be immediately closed and not re-opened until the template structure is adhered to.

Pre-check

Do not use the issues tracker for help or support, instead try the official Slack channel, official forum or Stack Overflow.
Do a quick search and make sure the issue has not already been raised, if it has then add to the existing issue if required.

Environment

Code source:
Code version:
Platform version:
3rd party dependencies:

Steps to reproduce

Attach a script to Snapped event which programmatically unsnaps the object and then tries to destroy it in a coroutine
Grab and drop a ball into the snap zone to the left
Try to distance grab another ball

VRTK.Tutorials.VRBowling.zip
Expected behavior
Distance grab should continue working
Current behavior
It is not
Note: As a workaround you can deactivate the object and then destroy it after a delay like 2 seconds - waiting for an end of frame is not enough

These instructions need updating as its not possible to recreate the issue without using a custom scene.

I think this is the same issue as if you disable a gameobject before untouching it. I've recreated this using snap zones in the spaceship escape room.

A workaround is to move the object out of touch before disabling/destroying it then waiting a frame or a second before doing the disabling. but it should be fixed as a going concern.

to move the object out of touch before disabling/destroying it
So to summarize the workaround if I got you right:

Disable the dragged object renderer
Move the dragged object to some void point (away from any colliders)
Wait for a frame
Destroy the object

This is what I did for the workaround which seemed to work for me
https://youtu.be/Z5w4AAd15EA?t=1101

Pull request with potential fix: https://github.com/ExtendRealityLtd/Tilia.Interactions.PointerInteractors.Unity/pull/224

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v2.1.0
GitHub release

Your semantic-release bot :package::rocket:


fix: Example of rules for workload resources in Readme

Description

Relates to https://github.com/kubewarden/kubewarden-controller/issues/611

Fix rules example in readme for all workload resources. We instruct users to use the example in the readme for all workload resources. metadata.yml only targets pods and is unchanged.
Test

Additional Information
Tradeoff

Potential improvement

Released as 0.2.9.


Most(If not all) items doesn't get dropped as an item when broken with valid methods.

Wrench also doesn't work.
I didn't test all of them but this should be enough.

Fixed in version 0.1.1. Thanks for reporting!


CIT: Support SSH connections to hosts that block SHA1

The SSH tests in CIT use Go to establish SSH connections:
https://github.com/GoogleCloudPlatform/guest-test-infra/blob/99181c466e5d93095615cfc52edfa16499e71292/imagetest/utils/test_utils.go#L192
While running CIT against Ubuntu 22.04, I observed that the SSH tests were failing:
	<testsuite name="ssh-daily-ubuntu-2204-jammy-v20220415" tests="5" failures="2" errors="0" disabled="0" skipped="0" time="0">
		<testcase classname="ssh-daily-ubuntu-2204-jammy-v20220415" name="TestMatchingKeysInGuestAttributes" time="0.02"></testcase>
		<testcase classname="ssh-daily-ubuntu-2204-jammy-v20220415" name="TestHostKeysAreUnique" time="60.2">
			<failure type="">    host_key_test.go:59: connect to remote host at<PHONE_NUMBER>249076651
    host_key_test.go:62: user test-user failed ssh to target host, vm2-ssh-3jtbh, err ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain</failure>
		</testcase>
		<testcase classname="ssh-daily-ubuntu-2204-jammy-v20220415" name="TestSSHInstanceKey" time="60.14">
			<failure type="">    image_ssh_test.go:33: connect to remote host at<PHONE_NUMBER>390562509
    image_ssh_test.go:36: user test-user failed ssh to target host, vm2-ssh-3jtbh, err ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain</failure>
		</testcase>
		<testcase classname="ssh-daily-ubuntu-2204-jammy-v20220415" name="TestEmptyTest" time="0"></testcase>
		<testcase classname="ssh-daily-ubuntu-2204-jammy-v20220415" name="TestHostKeysNotOverrideAfterAgentRestart" time="0.12"></testcase>
	</testsuite>

This occurred since Ubuntu 22.04 updated to an OpenSSH version that blocks connections that use SHA-1: https://www.openssh.com/releasenotes.html
This PR updates the golang.org/x/crypto dependency, which brings in their PR to support SHA-2 keys: https://github.com/golang/go/issues/37278
It also does the following:

Creates a go.mod file in the imagetest directory
Updates the container build configurations to build relative to this directory

/hold
so the main issue here is we need to confirm changing the shared go.mod doesn't break any of the containers, and if it does, we'll have to create per-project go modules either for the old or the new

so the main issue here is we need to confirm changing the shared go.mod doesn't break any of the containers, and if it does, we'll have to create per-project go modules either for the old or the new

@hopkiw
Ahh, this creates a new go.mod and leaves the old one unchanged.

/unhold


Moving cluster to new framework part

Moving cluster to new framework part
In order to see diff please look on second commit

/lgtm
/approve

/hold

@tsorya I opened a new ticket -
OCM-3740 | availability zones default in cluster_resource and cluster_rosa_classic


Bug: flow doesn't understand setting nullable properties

type Obj = {
  doot: ?() => void
};

var obj: Obj = {doot: null};

obj.doot = function() {}
// this triggers two flow errors
// ----
// error| call of method doot
// || Function cannot be called on possibly null value
// error| null
// ---
// error| call of method doot
// || Function cannot be called on possibly undefined value
// error| undefined
obj.doot();

Using a top-level variable, on the other hand, works fine:
var thing: ?() => void = null;

thing = function() {}
// this does not trigger a flow error
thing();

It also fails in the es6 class case (which is where I noticed the problem). See all the code on tryflow:
http://tryflow.org/?ex=2#97e488c2ac95b8ec04d59bcc17b53e99

@bhosmer fixed this with https://github.com/facebook/flow/commit/ef8ece919a4dbfde08cbb2c68c0335df2535aa8d and it will be out in the next release!

Fixed in 0.14


Fix issue where editing a Nunjucks variable/tag didn't update environment variables

This is a small PR that fixes behavior when setting environment variables via the tag/variable modal.
Reproduction steps:

Create a new environment
Add a property whose value is a variable (e.g. I used a timestamp)
Create a request using the new property, observe the request is using your property correctly
Edit the environment again, and click the value to open the tag modal
Change the value to something different/invalid, close the modal by clicking Done
Close the environment modal by clicking Done
Observe the property in your request did not change

This is somewhat of a naive solution, so I'm open to suggestions to fix this better.  Notably, why is this component not simply saving onChange if there are no errors instead of onBlur if there are no errors?

We save onBlur because saving onChange will cause all the background components to re-render on every keypress.

We save onBlur because saving onChange will cause all the background components to re-render on every keypress.

Thanks for the insight.  I've modified the PR to change the CodeEditor instead to call OnBlur when something changes but it isn't in focus.  Let me know what you think.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as the editor has been updated


Add loglevel to the benchmarks

See https://github.com/pimterry/loglevel
I didn't know about this one!

Perhaps sutra would be interesting to bench too - https://github.com/matthewmueller/sutra


removed chart version from volume claim label

fix for https://github.com/vmware/harbor/issues/4902

Coverage remained the same at 64.512% when pulling bc935620025c77d18215abdc43398bfaaf348432 on draeron:issues/#4902-volumeclaim-labels into cf79e9ee8d311a9e2e2294045fd954a0bf18a48c on vmware:master.

@draeron, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@jessehu agreement is stuck at my company's legal department limbo

Hi @draeron – thanks for the contribution. Clearing out old PRs and issues and not sure if this is still needed; let me know.
Thanks!


loss_dummy and loss_dummy1 are always 0

Why are loss_dummy and loss_dummy1 always 0 during my training?

hi, @Shiqh00 , they are used to solve torch sync training issues and are not used (that is why they are called dummy). please do not take care of that


Add validation endpoint to Chef Server.

Add validation endpoint to Chef Server.
We sometimes have the need to be able to determine if a request signed
with a client key is valid.  This adds an endpoint
/organizations/ORGNAME/validate/PATH that accepts a forwarded post,
and checks the signing as if it were sent to the PATH resource (PATH
can be any resource string). If the request validates, it returns 200,
and some potentially useful data. If it doesn't it returns 401 like
any other request with a bad signature.

[x] Verify it works with the nginx code
[x] Add RAML docs
[x] Wait for chef server release to finish.
[x] Rebase/Squash

Overall I like this idea as I've wanted this feature for a while so that add-ons don't need to do the "go to the principals endpoint, then do the auth yourself" dance.  A few high level questions and comments:

Do we have a planned use for this currently or is this just scratching an itch?
If we have a planned use, did we consider whether to implement this RFC instead: https://github.com/chef/chef-rfc/blob/master/rfc038-token-authentication.md

Passing Wilson build: http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/288/downstreambuildview/

As a follow up, I just remembered that we now have raml docs for API endpoints, perhaps we should add some docs for this endpoint once we are done with the nginx-side feature?

@stevendanna It would make sense, yes. However, we should probably discuss if this endpoint is ever going to be outside facing, or if it's just an internal thing to nginx offloading signed header authn for other services... So we'd maybe rather just document the external API endpoint that is going to be protected by this? 🤔

LGTM?

Rebased and squashed... ✅


Build with container not working

After release I pushed in v2.2.0, the project can not build with container any more. I was aware this problem. Because lack of time, I will improve build method by container as soon as possible. Until that time, please use Overleaf or try to build with text-live library.
Thank you.

This bug fixed in release v.2.3.0


LR Schedulers

Give user the option to train the model with more LR schedulers such as

One Cycle Policy
StepLR

Will have 2 milestones

Update training server code [Handled by @rvk007]
Show changes in frontend [Handled by @shan18]

Frontend updated in 7092a5ed5359c04e4d2bef5c42d2a11622fb68bc

Completed backend changes in 3dfd3c3f85cc6752959d9d7007b3b2bb27d28586


Add vm ds

See https://github.com/pryorda/vmware_exporter/issues/278 : VM: expose vmpathname datastore as label

Codecov Report

Merging #279 (97f6c72) into main (802240c) will increase coverage by 1.24%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   80.29%   81.54%   +1.24%
==========================================
  Files           4        4
  Lines         873      883      +10
==========================================
+ Hits          701      720      +19
+ Misses        172      163       -9

Impacted Files
Coverage Δ

vmware_exporter/defer.py
97.22% <ø> (ø)

vmware_exporter/helpers.py
72.72% <20.00%> (+11.53%)
:arrow_up:

vmware_exporter/vmware_exporter.py
81.36% <93.10%> (+0.27%)
:arrow_up:

vmware_exporter/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a202941...97f6c72. Read the comment docs.


Improve Bokeh Camera Display

There is a Bokeh version of the CameraDisplay in ctapipe.visualization.bokeh.CameraDisplay now that is much faster than the default MatPlotLib one, and is better suited for interactive use (the matplotlib version is better for making nice PDFs, etc).  However, it's currently not used very often since it's not friendly to use in a notebook, and doesn't have as nice a display as the default one.
Here I have created an example notebook that demonstrates that we can do it as nicely as the MatPlotLib version, and have it work in a Jupyter Notebook (also in Jupyter Lab).
https://gist.github.com/kosack/aceb8b6a8c6ab616767759ca48609063
Download this notebook and run it to try it out (it doesn't work via GitHub's notebook renderer)
The resulting display looks like this,  handles both hexagonal and square pixels, and updates at > 30 frames per second on my laptop, making it really nice for interactive functions using ipywidgets.interact():

Zooming works properly and in real-time:

Right now the code is just a proof-of-concept snippet, but I think we could use it to improve the current implementation and automatically push updates to a Notebook for realtime use.  That might break the functionality of the current non-notebook version, which so far is only used in ctapipe-event-viewer, which could be modified to be a fully in-notebook display, not a separate application. Or we can make it work in both cases.
A further development would be to make ctapipe.visualization.CameraDisplay be just an  dummy class that instantiates either an mpl.CameraDisplay or Bokeh.CameraDisplay upon request (either by delegation, or subclassing).

At this point we could then also think about making these two libraries optional dependencies (matplotlib and bokeh). At least one of them should be optional as both are pretty hefty (but matplotlib is more widely used at the moment.)

incomplete, but perhaps more useful example
import numpy as np
import bokeh
from bokeh.io import output_notebook, push_notebook, show
from bokeh.plotting import figure
from ctapipe.instrument import CameraGeometry

def _generate_polygon_vertices(order=6, x=0, y=0, size=1.0, theta0=0.0):
    """
    returns the vertices of a regular polygon of order `order`,
    centered at `(x,y)`, with size `size` and rotation angle `theta0` in deg.
    """
    angles = (np.linspace(0.0, 360.0, order + 1) + theta0) * np.pi / 180.0
    return size * np.cos(angles) + x, size * np.sin(angles) + y

def _generate_bokeh_multi_polygon_arrays(geom, order=6):
    pixel_polys_x = []
    pixel_polys_y = []
    for pix_x, pix_y, pix_area in zip(
        geom.pix_x.value, geom.pix_y.value, geom.pix_area.value
    ):
        vx, vy = _generate_polygon_vertices(
            order=order,
            x=pix_x,
            y=pix_y,
            size=np.sqrt(pix_area * 2) * 3 ** (-3 / 4),  # only for hexagon
            theta0=geom.pix_rotation.deg + 180 / order,
        )
        pixel_polys_x.append([[vx]])
        pixel_polys_y.append([[vy]])
    return pixel_polys_x, pixel_polys_y

class CameraDisplay:
    """
    CameraDisplay implementation in Bokeh
    """

    def __init__(self, geom: CameraGeometry, use_notebook=True, autoshow=True):

        self._geom = geom
        self._use_notebook = use_notebook
        self._handle = None

        order = 6 if geom.pix_type == "hexagonal" else 4
        xs, ys = _generate_bokeh_multi_polygon_arrays(geom, order=order)

        self.datasource = bokeh.plotting.ColumnDataSource(
            data=dict(
                poly_xs=xs,
                poly_ys=ys,
                image=np.ones_like(geom.pix_x.value).astype(np.float),
            )
        )

        self._color_mapper = bokeh.models.mappers.LinearColorMapper(
            palette=bokeh.palettes.Viridis256, low=-10, high=40
        )

        self.figure = figure(
            title=f"{geom} ({geom.frame.__class__.__name__})",
            match_aspect=True,
            aspect_scale=1,
        )
        # nmodifies the BoxZoomTool. May be better way to get it than by index
        self.figure.toolbar.tools[2].match_aspect = True
        self._setup_camera(geom)

        if use_notebook:
            output_notebook()

        if autoshow:
            self._handle = show(self.figure, notebook_handle=use_notebook)

    def _setup_camera(self, geom):
        self._pixels = self.figure.multi_polygons(
            xs="poly_xs",
            ys="poly_ys",
            fill_color=bokeh.transform.transform("image", self._color_mapper),
            line_color=None,
            source=self.datasource,
        )
        self._color_bar = bokeh.models.ColorBar(
            color_mapper=self._color_mapper,
            label_standoff=12,
            border_line_color=None,
            location=(0, 0),
        )
        self.figure.add_layout(self._color_bar, "right")

    def update(self):
        if self._use_notebook and self._handle:
            push_notebook(self._handle)

    def rescale(self, percent=100):
        self._color_mapper.update(
            low=self.datasource.data["image"].min(),
            high=(percent / 100) * self.datasource.data["image"].max(),
        )

    def set_geom_and_image(self, geom, image):
        self.geom = geom
        self.image = image

    @property
    def geom(self):
        return self._geom

    @geom.setter
    def geom(self, new_geom):
        self._geom = new_geom

    @property
    def image(self,):
        return self.datasource.data["image"]

    @image.setter
    def image(self, new_image):
        self.datasource.data["image"] = new_image
        self.update()

The vertices can even be broadcasted to avoid those loops;.

Probably easy, but I do not manage to do it: how could one make the high-low ends of the color scale change when bin contents change? I tried adding those to the datasource, but one cannot add single values, only arrays of length = # of pixels.

I don't know how to do it in JS in the finished html, but in python you need to update the low and high attributes of the color mapper like so:
# initial code
cmap = LinearColorMapper('Inferno256', low=image.min(), high=image.max())

# update to next event:

def update_image(new_img):
    # replace image data in datasource with new image
    source.patch({'image': [(slice(None), new_img)]})

    # update color mapper
    cmap.low = new_img.min()
    cmap.high = new_img.max()

Also implemented in #1494


Doughnut Sample

Hi
tanks for your amazing library
i cant find doughnut sample
where is that?

thats in pie charts!

thats was in pie charts library!
https://github.com/i-schuetz/PieCharts


add list slicing method s🍨 🔪❗

fixes #206

Looks good to me! Thanks! I'll merge it later when I have more time.


centos rpm is a dead link

http://mirror.centos.org/centos/7/os/x86_64/Packages/glibc-2.17-307.el7.1.x86_64.rpm is dead
i replaced it with https://linuxsoft.cern.ch/cern/centos/7/updates/x86_64/Packages/Packages/glibc-2.17-307.el7.1.x86_64.rpm
suggesting local rpm files being added through docker build as a replacement to the curls

Thanks for reporting this! I agree that refactoring to be less fragile is a good idea.
#8 should fix things for the moment.

Thanks for reporting this! I agree that refactoring to be less fragile is a good idea.
#8 should fix things for the moment.


Add "search-result" DM command

It will treat the given tweet as a search result.
It will useful after I find out new tweets manually and maintain the response keywords.

This depends on https://github.com/piroor/tweet.sh/issues/1

Done.


Predict the winner

Enter your question -
Two players are playing a game with a given array of size n. Both players make their turn alternatively. In each turn, a player will pick the array element from either end and add it to their score. Assuming both players play this game optimally, we need to tell if player 1 wins or not. If there is a tie then player 1 wins.
Enter link to the question(if question belongs to any online platform) -
https://leetcode.com/problems/predict-the-winner/
Tags for the question(eg - Array, Basic, Stack, etc.) -
Dynamic programming, Google interview

@SarthakKeshari could you please assign this to me?

@ravi0213,
Kindly add your solution to "leetcode" folder
Deadline - 06/10/2021


bump .NET SDK to v6.0.200

bah - the repo we're testing against (dotnet/format) doesn't seem to be regularly updated/released in order to support newer SDKs.
We could pick another one, or add a fake test project to this repo?

bah - the repo we're testing against (dotnet/format) doesn't seem to be regularly updated/released in order to support newer SDKs.
We could pick another one, or add a fake test project to this repo?

either way -- whatever you'd prefer!  (though if dotnet/format will not work after this upgrade maybe we should wait?)

Yep, there's several related issues in their repo so let's wait and see. Feel free to close this in the meantime.
Would the ability to have pluggable / selectable language versions be something to investigate down the line, or is that out of scope for the free tier?

I think that would be best done as a feature to pre-commit itself (make language_version work)

I'm bumping to .net 7 so closing this out!


[Bug] Cannot compile alloy-json-abi at 0.8.9

Component
json-abi
What version of Alloy are you on?
0.8.9
Operating System
macOS (Apple Silicon)
Describe the bug
I updated to 0.8.9 and cannot compile due to errors inside alloy-json-abi.
Here's the output when building:

Duplicate of https://github.com/alloy-rs/core/issues/778. See https://github.com/alloy-rs/core/issues/778#issuecomment-2428939631.


Fix references to not existing struct items

It looks like rst_cpu_n was removed in: https://github.com/lowRISC/opentitan/pull/11239 and sw_rst_regen was renamed to sw_rst_regwen in: https://github.com/lowRISC/opentitan/pull/8358

@GregAC Is there anything I can do to help you with the review? Thanks.

Apologies for not looking at this earlier @kamilrakoczy, unfortunately we're currently not merging any RTL changes into the master branch. Though I am surprised this isn't picked up by our existing linting and testing.
I think the rstmgr.sv file this alters: https://github.com/lowRISC/opentitan/blob/master/hw/ip/rstmgr/rtl/rstmgr.sv isn't actually used at top-level at least (i.e. when building an earlgrey design), with https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip/rstmgr/rtl/autogen/rstmgr.sv being used instead. Perhaps the rstmgr.sv that's under ip/ is only used in block-level DV, though again I'm a little surprised we haven't seen issues there also because we're lacking this fix.
@msfschaffner @matutem any light you can shed on the above?

@GregAC is correct, the correct file is under hw/top_earlgrey.
Unfortunately we haven't fully migrated our templated IPs yet to use the ipgen meachanism, and that means that there are still some files in the tree that use an "example" configuration. I am closing this since we are going to clean this up as part of https://github.com/lowRISC/opentitan/issues/8440.


TELEWORK: Remove Menu Tabs for Manager

User Story
As a manager (reviewer), I want to only see the menu tabs that are relevant to me so I don't confused or enter areas that which would constitute a privacy breach.
Tasks

[x]  Remove Forms, Applications, and Dashboards tabs from view for reviewers in the production and test environment

Acceptance Criteria

[x] Inability to see  Forms, Applications, and Dashboards tabs from view when logged into the production and test environments as a reviewer

See #338 which is similar

Check if this a duplicate

update to requirement to not remove "Forms tab"

Not seeing this in any environment

![image.png]
(https://images.zenhubusercontent.com/61e5ab4a9a5a1e4bd27a92b8/08973cbf-9b8e-499b-8671-5a599123ccf3
)

Tested successfully in TEST. Waiting on this change to be pushed to PROD and do a final review before closing ticket

Successfully tested in PROD with Lee-Ann and Josh.


Incorrect balance formatting on Send screen accounts list

-The values here need to be fixed as a part of the new Send flow.

@cakesoft-swati Sorry if I'm missing something, but could you please elaborate on how the view above is broken and how it needs to be fixed?

The value shown there is in sats but shows $ as the currency.

@antuz123 I see. So the value should be converted to dollars instead? We might also want to have it correspond to the users current preference for displaying fiat currency or BTC.

The value is in sats and should show B symbol.
Yes it should be as per user preference. This is the case everywhere in the app.

-Verified this issue on staging app version 1.3.1(162)