Kitematic issues

I expect this may be because you aren't running a mysql container for cachet to link to.

Should Docker be using Postgres though?

Yeh, it should be using postgres.

Should probably be the default on line 37 & 38 in entrypoint.sh then?

It should if we're installing Postgres.

Hmm the docker-compose.yml should be pulling Postgres and NGINX images as well and setting the ENV variables needed. I don't use Kitematic myself so I am not sure how docker-compose support works exactly.

@jbrooksuk I just downloaded Kitematic, it doesn't appear to have native docker-compose support, so you will need to run docker-compose up from the Docker CLI.
Once up and running the containers do show up in Kitematic:

Okay. Is there anyway that we can get that to work? Kitematic lists Cachet, but it doesn't work, so it's a bit weird.

https://github.com/docker/kitematic/issues/137
Until kitematic ships docker-compose support in the GUI, not a lot we can do.
Only way it would work straight out of Kitematic would be to put everything into a single image (Postgres and all).
Essentially any Docker image that uses best practices for one service per container cannot be run via kitematic without going to CLI. The official Wordpress image for example requires a linked MySQL image, which would need to be launched manually or through Docker compose on the CLI for it to work.
Kitematic is lacking too many Docker ecosystem features currently. It is fine for people new to docker, but is not something suited for real production use.
Sent from my iPhone

On May 28, 2016, at 1:14 AM, James Brooks<EMAIL_ADDRESS>wrote:
Okay. Is there anyway that we can get that to work? Kitematic lists Cachet, but it doesn't work, so it's a bit weird.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

We could probably add some logic to the startup to look for a linked DB container, and display a better warning if one is not present.

After digging into this a bit more this is not really something we can fix on our side beyond making the error message more user friendly. (Personally I would rather have the raw error displayed though)
Looking at the popular Wordpress Docker image, the behavior is very much the same when launching out of Kitematic's UI:

Going to go ahead and close this out as wontfix

No problem! :)


Updates for Advanced Highlighted Content Web Part

Category

[ ] Content fix
[x] New article

Contents of the Pull Request
Updates to Advanced Highlighted Content Web Part, added to index, TOC, and CHANGELOG

Docs Build status updates of commit 1503f1f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.vscode/settings.json
:white_check_mark:Succeeded

CHANGELOG.md
:white_check_mark:Succeeded

Community/TOC.md
:white_check_mark:Succeeded
View

Community/highlighted-content-web-part.md
:white_check_mark:Succeeded
View

Community/includes/content-disclaimer.md
:white_check_mark:Succeeded
View

Community/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


WIP - GRANT-330 & GRANT-331 - populate detail fields

WIP

Looks like fields with keys like radios and checkboxes display the key instead of label as a value.
For example, here:

should be "Regional district" I feel like

Phone and email missing in Section 1

Looks like fields with keys like radios and checkboxes display the key instead of label as a value. For example, here:  should be "Regional district" I feel like

const organizeFieldsetData = (e: any, formData: any, componentKey?: any) => {
  return e?.components
    ?.filter((i: any) => !NOT_TO_BE_RENDERED.includes(i.type))
    .map((c: any) => {
      if (Array.isArray(c.rows) && c.rows.length > 0) {
        return c.rows?.map((r: any) =>
          renderGeneralField(r[1].components[0], formData, componentKey),
        );
      } else {
        switch (c.type) {
          case 'columns':
            return c.columns?.map((eachCol: any) =>
              eachCol?.components?.map((ec: any) => renderGeneralField(ec, formData, componentKey)),
            );

          case 'simpleradios':
          case 'simpleradioadvanced':
            return renderRadioValue(c, formData, componentKey);

          default:
            return renderGeneralField(c, formData, componentKey);
        }
      }
    });
};

const renderRadioValue = (e: any, data: any, container?: any) => {
  const label = e.properties?.portalWording ?? e.label;
  const value = data[container][e.key];

  return (

      {label}
      {`${
        e.values?.find((item: any) => item.value === value)?.label ?? '-'
      }`}

  );
};

Phone and email missing in Section 1

switch (c.type) {
          case 'columns':
          case 'simplecols2':
            return c.columns?.map((eachCol: any) =>
              eachCol?.components?.map((ec: any) => renderGeneralField(ec, formData, componentKey)),
            );

          case 'simpleradios':
          case 'simpleradioadvanced':
            return renderRadioValue(c, formData, componentKey);

          default:
            return renderGeneralField(c, formData, componentKey);
        }

Let's change the branch to summary table. I'm sorry, I think it's best to keep cleanup branch in review for now.
I made a PR only for changing where this PR points to, as well fixing some of the rendering values. Please take a look here: https://github.com/bcgov/BCAT/pull/19

Let's change the branch to summary table. I'm sorry, I think it's best to keep cleanup branch in review for now. I made a PR only for changing where this PR points to, as well fixing some of the rendering values. Please take a look here: #19

ok, I'll close this


Testing FS pipelines on "prod"

As of testing on this date almost all FreeSurfer jobs scheduled to galena fail ultimately. Retests include sending to e2 and also testing locally on swarm.


Remove dependency exclusions from open-metadata-implementation/user-interfaces/ui-chassis/ui-chassis-spring/pom.xml

Remove dependency exclusions from open-metadata-implementation/user-interfaces/ui-chassis/ui-chassis-spring/pom.xml (if we can)
Is there a particular reason we are doing the exclusion here? Just want to check it isn't masking any version dependency issues
_Originally posted by @planetf1 in https://github.com/render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjIwNjU4MjgzOnYy/pull_request_review_threads/discussion

the current exclusions look appropriate. so closing.


rav1e_config_set_mastering_display arguments aren't C-ABI safe

The current nightly rustc is marking it as faulty eventually and cbindgen will reject it soon.
It should take a *const rav1e::ChromaticityPoint instead.

https://github.com/eqrion/cbindgen/pull/545 would make it nicer.


Window showing current x and y spline equation

Not going to do this.  The Spline is actually a function of the generator and therefore not known by the GUI application.


Implement FromStr / something that allows storing byte slices / yoke for KernelObject

Currently, KernelObject could be used like this:
let elf = fs::read(&kernel_path)?;
let object =
	KernelObject::parse(&elf).map_err(...)?;

However, I asked around (after having worked on https://github.com/hermit-os/uhyve/pull/725/) as to how I could prevent the "use-after-free" warning that prevented me from storing the object object in the UhyveVm struct - and the problem seems to be that we depend on references that get "destroyed" soon afterwards:
https://github.com/hermit-os/hermit-entry/blob/5c87198c45a6b870f14db618bc56375e251aee4f/src/elf.rs#L32-L35
A potential solution could be implementing something similar to the following trait: https://doc.rust-lang.org/std/str/trait.FromStr.html

This is not yet possible without using raw pointer manually (which we should not do):

https://github.com/unicode-org/icu4x/issues/2095
https://github.com/rust-lang/unsafe-code-guidelines/issues/326

We can keep this issue open for the future, but currently there is nothing we can do. I'd suggest keeping only the Vec around and reparsing it if necessary. The overhead should not be too bad.
In Uhyve, parsing ahead of time should also become unnecessary once C applications become relocatable.


monitoring: enable ICMP probes from the blackbox exporter

There are two parts to enabling ICMP probes:

Add the icmp module to the blackbox exporter configuration.
Adjust the securityContext for the blackbox-exporter container to allow sending pings.

For (1), override the default kube-prometheus ConfigMap and add the icmp module.
For (2), patch the Deployment securityContext values to run as root with only the NET_RAW capability.
References:

https://github.com/prometheus-operator/kube-prometheus/blob/v0.9.0/jsonnet/kube-prometheus/components/blackbox-exporter.libsonnet#L169-L175
https://github.com/prometheus-operator/kube-prometheus/blob/v0.9.0/docs/blackbox-exporter.md?plain=1#L43
https://github.com/prometheus-operator/kube-prometheus/pull/778#discussion_r521955739

bors r+


⚠ Nebulance has degraded performance

In b79ee91, Nebulance ($NBL) experienced degraded performance:

HTTP code: 200
Response time: 2183 ms

Resolved: Nebulance performance has improved in e47bf4d after 6 minutes.


Update Coffea version to 0.7.22

A new Coffea version has been detected.
Updated Dockerfiles to use 0.7.22.

shall we?

@lgray I am going now quickly fix small issue with dispatching to docker-coffea-dask repo and then I will hit the merge :)


docs: add links to forecast-actual format repos

The actual location of the links is in limbo for a bit, and ideally we'd be regenerating this, but the static version would also be useful.

Ope, that's what I get for moving too quick. It should be down to just the actual change.

Could you add Ryan's script to the repo? And update the reference to it on the "About" page.

script added; the link won't be usable until we merge this into main.


JAV-501 Public key authentication between consumer and provider

As a developer, I need to have authentication in service provider to protect the microservice from unauthorized access

Changes Unknown when pulling cf76cbe1acfc73003041260b7ec14bd3f070fa8e on coolhongluo:serviceauth_rsatoken into ** on ServiceComb:master**.

Coverage decreased (-0.06%) to 86.904% when pulling 2ee157cfa8b37cf44b6591dcaeb136814f08b0f2 on coolhongluo:serviceauth_rsatoken into 47414d0a61cbde901168bc79229161bfbbf39e85 on ServiceComb:master.

Coverage decreased (-0.1%) to 86.886% when pulling d66a9a5d69d31ae2dd3756562448d5a7c0327b44 on coolhongluo:serviceauth_rsatoken into 7ddf34517b85baab694532ea0b0f0fa292895859 on ServiceComb:master.


remote_file's source attribute does not support DelayedEvaluators

I am opening this issue, as CHEF-5162 does not seem to be fixed in the latest chef-client, although it was in the changelog for 11.14.2. This is a chef-shell output of the same test case from the original ticket (https://tickets.opscode.com/browse/CHEF-5162)
This is the chef-shell.
Chef Version: 11.16.0
http://www.opscode.com/chef
http://docs.opscode.com/
run `help' for help, `exit' or ^D to quit.

Ohai2u vagrant@localhost!
chef > recipe_mode
chef:recipe > remote_file "/tmp/g2" do
chef:recipe > source lazy {"http://www.google.com"}
chef:recipe ?> end
Chef::Exceptions::InvalidRemoteFileURI: #<Chef::DelayedEvaluator:0x00000003a2d188@(irb#1):2> is not a valid `source` parameter for remote_file. `source` must be an absolute URI or an array of URIs.
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/resource/remote_file.rb:138:in `block in validate_source'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/resource/remote_file.rb:136:in `each'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/resource/remote_file.rb:136:in `validate_source'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/resource/remote_file.rb:128:in `after_created'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/dsl/recipe.rb:139:in `build_resource'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/dsl/recipe.rb:85:in `declare_resource'
	from /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.0/lib/chef/dsl/recipe.rb:41:in `method_missing'
	from (irb#1):1

This is still not working on 12.0.3.
                      ================================================================================

                      Chef::Exceptions::InvalidRemoteFileURI
                      --------------------------------------
                      #<Chef::DelayedEvaluator:0x00000004f6be78@/var/chef/cache/cookbooks/quickbuild-mspot/recipes/_common.rb:44> is not a valid `source` parameter for remote_file. `source` must be an absolute URI or an array of URIs.

@albertsj1 Can you run that in debug mode and provide more of the stacktrace?

@albertsj1 Never mind, looks like the same issue identified above, for some reason I thought the fix for this had been merged.

This should be resolved now.


Fix incorrect dangling Javadoc used for license, Javadoc errors, address lint warnings

Summary:
This changes was part of another PR and was split out for clarity purposes.  It contains a few lint warning fixes and javadoc error fixes to improve the overall quality of the library.
Changes:

Fix incorrect usage of Javadoc used for licenses at the top of source code files.
Fix a couple javadoc errors that would fail to build javadoc correctly.
Address 2 lint warnings that are calculated usages of methods that are either deprecated or cause a lint warning.

Ready to merge I think

Thank you @barnhill!


Update vmware-azure-deploy-configuration-server.md

Adjusting VMWare to VMware for consistency.

@sbkuehn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fix resource listing for lambdaVersionCleanup when using a cloudformation stack with lots of resources

DescribeStackResources limits to 100 resources
Use ListStackResources instead of DescribeStackResources

Please check if the PR fulfills these requirements

[*] The commit message describes your change
[*] Tests for the changes have been added if possible (for bug fixes / features)
[*] Docs have been added / updated (for bug fixes / features)
[*] Changes are mentioned in the changelog (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix

What is the current behavior? (You can also link to an open issue here)
large stacks have resources ignored

What is the new behavior (if this is a feature change)?
Uses the paginated cloudformation API

Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
no

Other information:

Code looks good but there are failing tests


Update json-smart dependency to fix CVE-2021-27568

New version of json-smart has just been released. Please update this dependency as it fixes critical security violation CVE-2021-27568.
Might be duplicate of: https://github.com/json-path/JsonPath/issues/676

Fixed in 2.6.0


Allow usage of 2FA on Gateway

I've been using assh for quite some time now and really love it. I get the server IP's from AWS CLI by using the servers name as the host.
But now we have a new project which requires 2FA be enabled on the Gateway and I can't send the code because it's not being asked for.
Is there a workaround already for something like this or would assh need to be changed to support this?

I had wrong tempalte config and it was not working because if that :)


Provide development mode

zend-development-mode has been a popular feature of Apigility, and a popular standalone module. Unfortunately, its architecture uses the MVC <-> console integration, which is problematic in the streamlined skeleton, which does not include that out-of-the-box.
This patch creates development-mode as as standalone script in the project bin/ directory. Additionally, we add the config/modules.config.php, to push modules into a separate file, and config/development.config.php.dist, to provide a basic structure for segregated configuration. Finally, the bootstrap is updated to test for the presence of config/development.config.php and merge its contents with the application configuration.
Usage is:
$ ./bin/development-mode enable

Or, to disable:
$ ./bin/development-mode disable

Ping @akrabat - thoughts? The other direction I could take is to do a v3 release of zend-development-mode that just ships this script, instead of acting as a module, and require that in the ZF skeleton.

The code in development-mode is quite long.... Wouldn't be nicer to write a class and create new instance with $argv?
class DevelopmentMode {
    public function __construct(array $argv)
    {
        ...
    }
}

new DevelopmentMode($argv);

I don't like this procedural style...

I don't like this procedural style...

Matter of preference. I don't care either way; this was relatively easy, and didn't require mixing a class and a script in a single file, or pushing a class into the skeleton source tree. If we were to do move this into zend-development-mode, I'd likely switch to a class, however.

Alternate version available in https://github.com/zfcampus/zf-development-mode/pull/19 (pinging @webimpress and @akrabat)

I've updated this pull request to use zf-development-mode v3, and added several composer script aliases to simplify working with it.

Was afk all week. +1 from me, though note typo in README.


add xma to get_all

Codecov Report
Patch coverage: 14.28% and project coverage change: -0.55% :warning:

Comparison is base (eb6a47c) 39.44% compared to head (d9289fe) 38.89%.

:exclamation: Current head d9289fe differs from pull request most recent head 89a3362. Consider uploading reports for the commit 89a3362 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   39.44%   38.89%   -0.55%
==========================================
  Files          19       19
  Lines        1179     1198      +19
==========================================
+ Hits          465      466       +1
- Misses        668      686      +18
  Partials       46       46

Files Changed
Coverage Δ

internal/handler/wallet/get_all_assets.go
10.63% <10.00%> (-3.65%)
:arrow_down:

internal/handler/wallet/api.go
90.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't craft IC2 items

Minecraft version & Mod Version:
MC1.10.2
Cyclic 1.10.24
Single player or Server:
Single player
Describe problem (what you were doing / what happened):
I put an recipe of an IC2 item into the upgraded inventory craft but it can't output the result.
Crash log (if any):
Not crashed.
(If this is a suggestion and not a bug report, delete all this and just write your suggestion!)

so the same recipe works in a crafting table but not inventory? super weird

The same recipe works invanilla crafting table, vanilla 2x2 inventory crafting grid,  AE2 ME crafting terminal, IC2's own workbench and crafter, and RFTools crafter. But not work on the Cyclic inventory 3x3 crafting grid.

Yep i confirmed this is happening still, ONLY with IC2 recipes and only in this one specific inventory screen.  Other mods such as EnderIO or thermal work fine in this screen.  Spans across all minecraft versions i just tagged.
I tried a few things but im still not 100% sure on the fix.

Also happens in Silent Gems, finally found a fix coming soon to 1.12 . (https://github.com/SilentChaos512/SilentGems/issues/251)

Fix version Cyclic-1.12.2-1.10.0


Problematic interaction between MigrationsSqlGenerator and new type mapper

I have an Npgsql test failing in both preview1 and preview2, tracking it down points to the following code in MigrationsSqlGenerator:
return (clrType == typeof(string)
#pragma warning disable 618
            ? Dependencies.TypeMapper.StringMapper?.FindMapping(unicode ?? true, keyOrIndex, maxLength)?.StoreType
            : clrType == typeof(byte[])
                ? Dependencies.TypeMapper.ByteArrayMapper?.FindMapping(rowVersion, keyOrIndex, maxLength)?.StoreType
                : null)
#pragma warning restore 618
        ?? Dependencies.CoreTypeMapper.GetMapping(clrType).StoreType;

This code is responsible for finding the type mapping when there's no Property for it. If the old type mapper is used, everything seems to be OK and the StringMapper and ByteArrayMapper correctly receive maxLength, unicode and the other facets. However, with the new type mapper, only the clrType is passed and the other information is lost. Thus, if an AlterColumnOperator with a MaxLength of 30 is executed without a Property, the max length will not be passed into the type mapper and will be lost.
It seems like the code here should be constructing a RelationalTypeMappingInfo, populating it with everything, and passing that to the typemapper.

It seems like the code here should be constructing a RelationalTypeMappingInfo, populating it with everything, and passing that to the typemapper.

👍

@roji @bricelam I think I had the pragmas in there while I was working on this so I didn't have to tackle the migrations stuff while getting the rest to work, and I obviously then forgot I did this!


Exception handling in futures is clumsy.

This issue was originally filed by<EMAIL_ADDRESS>
* Requires me to register two handlers

Can't use try/catch
Ability to omit an exception handler is problematic: see issue #1115

What about
someAsyncMethod().then((result) {
  try {
    print(result.value);
  } catch (SomeException e) {
    print("Oh no, error!");
  }
});
'result' could be the original Future object, or some Completion<T> object (which would probably play nicer with a unified event/future async model)

No plans to change the Future design in this way.
Each handler on a future is notified individually, there is no "after all handlers are notified" time that you can use. You can add new handlers to a future after it has completed.
The onComplete will not swallow errors unless a new error is introduced. In that way it works the same as a try/finally where the finally-block throws.
You can now either use async functions to use try/catch on awaited futures, or you can use Result.capture from package:async to capture the result of a future into a single object that can hold either a value or an exception.


Add huggingface support for inferring audio/image columns.

Codecov Report

Merging #307 (af64fdc) into main (2c30122) will decrease coverage by 0.22%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   67.26%   67.05%   -0.22%
==========================================
  Files         209      209
  Lines       11809    11800       -9
  Branches     1761     1718      -43
==========================================
- Hits         7943     7912      -31
- Misses       3450     3473      +23
+ Partials      416      415       -1

Flag
Coverage Δ

unittests
67.05% <25.00%> (-0.22%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

meerkat/columns/deferred/file.py
65.08% <ø> (ø)

meerkat/dataframe.py
72.98% <22.58%> (-2.59%)
:arrow_down:

meerkat/interactive/formatter/__init__.py
100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


changes for using latest shopware flex template

Bug fix: the theme is missing on deployed version. Compiling the theme in the sw:deploy task fixes it. Another fix: in CI systems there is no way to compile the theme locally since a database connection is needed. Adding the theme compile skip option at the build-js.sh fixes it as well.

What exactly was not working? I don't understand from this issue here.
The recipe was implemented having this site in mind: build SW without DB, or alternatively this one official PaaS documentation. Building should happen locally and it was working without a database connection before, because the mentioned files were obtained from the server. From what I understand, you have disabled part of the building? When will building the theme happen now?
From what I see at the moment, I think merging this PR broke things, and without further explanation I think it should be reverted.
@antonmedv @Schrank

Unfortunately I'm not using the shopware recipe at the moment, but a very old version which works for us.
@xavgru12 did you follow any of the mentioned links by @UlrichThomasGabor? Because to build it locally you need to adjust your configuration.
I tend to revert it but add a paragraph to the config about the two links Ulrich provided, so people see in the recipe how to use it. Any comments on this idea?

Sounds good to me.

When will building the theme happen now?

I just saw that you added a remote task for that. While I guess this is working, it is in my opinion unnecessary to compile the theme on each deployed instance, when all data is already available to compile locally (saves time and energy).
Without further explanation on what problem this issue is actually solving, I would still vote for a revert.

I have followed the guide of compiling without Database connection.
Using without database connection, I had to skip the theme compilation as it was described in the guide.
This resulted in the deployed version not having the theme compiled. Adding the remote task resolves this.

You are referring to the last part?
https://developer.shopware.com/docs/guides/hosting/installation-updates/deployments/build-w-o-db.html#partially-compiling-the-storefront
This is optional. You can add that via a switch, but I don't think it is good practice to change the behavior for everyone.

Compiling the storefront without database does not work for me following the guide. Using the theme skip works fine, however.

Feel free to open an issue or ask on Stackoverflow or SW Slack for help, if you encounter problems with the setup. You can also change your recipe locally (redefine the tasks). But in my opinion, the standard case should be the default one. It is definitely working, since we are using this process for 2 years now or something like that.


ci(workspace): add husky hook

optimize CI by

[ ] PR lint diff files against target branch
[ ] pre-commit lint staged

is full lint (all files) ever required?
I agree with the following

This “we shall lint everything” concept is hardcore for developers, but not really agile for business. As my scrum master once told me: it is very likely this section will be refactor or removed before we really need to maintain it; we may end up waste time to correct the lint errors in this section for nothing. This is not align with business value.

https://seeliang.medium.com/how-to-update-lint-without-lint-the-whole-project-841150aa59b0#:~:text=This “we shall,with business value.
Pit falls -

a scenario where lint rules are updated will not catch unchanged files that don't meet the new code standard
following this scenario can lead to authors touch files and get lint errors thrown on, as far as they know, a pristine code

following a discussion on node-tooling here's a great answer

lint checks can NOT just run on changed files; eslint-plugin-import checks imports across files, and tsc is also a “lint check” that runs across files
iow, the ONLY way you can safely run on a subset is if you have 100% certainty of the dependency graph, and you test all changed things, PLUS all things that depend on them
and since that’s very difficult to know without applying a lot of constraints to the codebase, and since the cost of running checks on the entire codebase is minimal (for example, for eslint, use jest-runner-eslint - airbnb dropped lint time from 22 minutes to 2 by adding that) it’s just not worth the complexity
focusing on ideological wastefulness is actively harmful. focus on actual problems instead.

@YonatanKra familiar with jest-runner-eslint?

Husky fails to install on docker image with Node 16. see nodejs/docker-node#1598


Servers MAY use the HTTP ETag header

Servers MAY use the HTTP ETag header with a strong validator for RDF bearing representations in order to encourage clients to opt-in to using the If-Match header in their requests.

Optional but we already have an interface related to ETags. Currently nothing is done yet with the conditions though as mentioned in #17 .

Resolved in #913, will be released in v2.0.0


bug: loading, success/error and recipe result is hidden behind sign up modal

Not really a bug but when scraping as a guest user the loading, success/error messages and the actual result is hidden behind the sign up modal:

While decluttering
Result

What do you think about refactor the pop up banner to not be a pop up but just a section on the landing page? Then it will no longer be in the way of the result, either keeping it underneath or removing it on result.


ARTEMIS-2210 PagingStore creation is not properly synchronized

In PagingManagerImpl#getPageStore() the operations on the map 'stores'
are not synchronzed and it's possible that more than one paging store is
created for one address.

The fix is so obvious that I decide not to provide a test. :)

@gaohoward The synchronized block will block any threads attempting to both getting and creating a paging store, while a chm::get is lock-free ie won't block any threads and chm::computeIfAbsent is locked on per-segment basis (that means that depends on the number of segments and how the hashing of the keys will distribute the entries into the segment.
Putting a synchronized like this will prevent any threads to do anything on an hot-path, blocking each others: my advice is to keep chm::get lock-free (as it is now) and into newStore(storeName) use chm::computeIfAbsent to avoid duplicates creatings of PagingStore instances.
This should keep the scalability as it is now without allocating unnecessary instances. wdyt?

@franz1981 ok, make sense. I'll change it. thx.

@franz1981 I've update the branch, can you take a look? thx.

Looks fine to me buddy, just change the title, because no sync is happening anymore ;)

@franz1981 Title changed. Thanks mate!


Add Serge Matveenko to author list

Selected Reviewer: @hramezani

please review

@Kludex and @sydney-runkle are missing.
Also, not sure should we keep Terry in list?


Suggestion: Chinese and Russian romanization

First of all thank you for the Romaji, I wanted it for so loooong!
I'd like to know if it'd be possible to do the same thing for Chinese and Russian cyrilics?
Russian would be easy it's pretty straight forward if I'm not mistaken, however Chinese would probably be near impossible (c.f. the other issue I opened about Romaji).

Yea I am very much on your side here. Chinese would definitely be at least as difficult as Japanese, only without me being able to verify the results easily.
And yea cyrillics should be very straight forward!
Lets see what I can do when I have time :)


I18n.js requiresmoment which is a devDependency

https://github.com/JSxMachina/react-i18nify/blob/master/src/lib/I18n.js#L118
moment is required but defined as a devDependency in package.json.
This method is internally used within <Localize /> component.
In a project where moment itself is not included, it cause compilation warnings.

WARNING in ./node_modules/react-i18nify/build/lib/I18n.js
Module not found: Error: Can't resolve 'moment' in '/[...]/node_modules/react-i18nify/build/lib'
@ ./node_modules/react-i18nify/build/lib/I18n.js 131:21-38
@ ./node_modules/react-i18nify/build/index.js
@ ./node_modules/react-redux-i18n/build/index.js
@ ./src/app.js

Quickfix : set moment as a dependency instead of a devDependency in package.json.
I can propose a PR for that, but I wanted to discuss about it first.
moment.js (+ locales, + timezone) is quite a huge library, consuming {most of the time} un-necessary bandwidth.
The point of including it is to use its format() method, which is IMO quite an overkill here.
An alternative would be to use the lighter date-fns library : https://date-fns.org/, from which we can easily import the format() method only. I am pretty sure it would massively reduce the compiled width of every project using react-i18nify :)
Think about it as lodash for dates.
Source code would obviously need a few adjustments :
// Using moment.js
const moment = require('moment');
require('moment/min/locales'); // Should it actually be imported by react-i18nify itself or should it be the responsibility of the project ?!

// _localize()
try {
  return moment(
    value,
    options.parseFormat,
    this._locale,
    Boolean(options.strictParse),
  ).format(this.t(options.dateFormat));
} catch (e) {
  console.error('moment.js error', e);
  return '';
}

--->
// Using date-fns
import format from 'date-fns/format'
import parse from 'date-fns/parse'
import 'date-fns/esm/locale' // Should it actually be imported by react-i18nify itself or should it be the responsibility of the project ?!

// _localize()
try {
  return format(
    parse(value),
    this.t(options.dateFormat),
    {
      locale: this._locale
    }
  );
} catch (e) {
  console.error('date-fns error', e);
  return '';
}

Pros  (of using date-fns instead of momentjs)

Modular library and selected imports (es6-ready) : massive reduction of bundle size
Manipulate native Date objects

Cons

No "parseFormat" option (date-fns/parse accepts complete ISO 8601 formats as well as partial implementations)

(But I can't really see in which case a non-standard "parseFormat" has an interest here?)
What do you think about that?

No need for a quick-fix, moment is currently a peer-dependency, meaning you have to install it yourself.
Using date-fns instead of moment would be awesome though, would be happy to see a PR for that!

Really sorry about that, completely missed the peerDependency here...
About date-fns, one other con is that it does not seem to know specific localized formats.
For instance format(new Date(), 'LTS') will not work.
In the meantime, I was thinking, maybe the best way would be to write some kind of generic interface allowing people to choose if they prefer moment.js or date-fns themselves (defaulting to moment.js to preserve BC).
However I am not sure how to do that in JavaScript ; I'll dig into it!

Please have a look at how I check for moment.js in the last version (1.11.10). Maybe we can extend this and also check for date-fns? In this way, they hopefully also don't have to be peer dependencies.

Thanks for the tip, it this seems brillant (even though I didn't test it yet) :)
I'll try to submit the PR later in the afternoon

Actually it seems that multiple people have issues with compilers and moment.js being conditional or missing. So I'm thinking that probably it's the best to only support date-fns, but then as a non-optional normal dependency. What do you think?

Performance wise, it seems the best option we have...
However, thinking about it, I am not sure about :

display formats
supported languages

At this point, if we make such a change, it could be for a new major version, because it might cause small BC problems because of the points listed above...
Didn't had time to dig into a conditional dependency at the moment but I will take it tomorrow. Maybe I'll found something interesting?!

What about :
https://stackoverflow.com/a/46543835
But maybe you already got that one?

Coming here from #28.
I agree that that switching to date-fns would most likely cause a lot of bc issues. It might be a good idea to think about it in the future. Otherwise, perhaps including a time library of your choice via a plugin for  component could work, too.
The try/catch and conditional loading solution is good, problem is that it results in warnings. I think what we should do is find a way to suppress those warnings.

Hey @rkrv, thanks for your input ;

perhaps including a time library of your choice via a plugin for component could work, too

Do you have an idea how to build this in practice?
I just came up with a theory at the moment.

// Localize.js
export default class Localize extends Component {}

// LocalizeDateFns.js
export default class LocalizeDateFns extends Localize {
  // Conditional import date-fns
}

// LocalizeMomentJs
export default class LocalizeMomentJs extends Localize {
  // Conditional import moment.js
}

// Somewhere in your code...
import Localize from './LocalizeMomentJs';

However, now that I think about it...
moment.js is imported in I18n.js in the _localize method. <Translate /> component does not use this method.
It would make sense to split the functionality in I18n.js so that <Translate /> does not know about this dependency.
I am guilty myself, though, since I use I18n.t() directly somewhere else in the project. I recognize that there are people using I18n.l(), so splitting it up would be a hassle.
What if perhaps you were able to import only the locales you need? Right now all of them are imported, which is too much.

Well, as far as I am concerned, I would actually vote to remove the locales import from this project and let users import it themselves... But this would be definitely highly BC breaking!
Interesting thought to build 2 different components, didn't think about that actually...
But then we would have to split I18n.js
@gerbenmeyer what do you think?

Problem is that if you use I18n.t(), then you inherit the moment.js import with it, too. I think the solution @gerbenmeyer went with is good, we just need to improve it so that it doesn't throw warnings.

As conditional imports give warnings, we basically have two options: 1) revert back to always importing moment + locales, or 2) do something breaking.
I would prefer to do something breaking then. The best option in my opinion in that case is to switch to date-fns. This doesn't break that much (only things like 'LTS' won't work anymore), but would cause the bundle to be a lot smaller, which is valuable for many people.
And in this way we also create the option to have a LocalizeMoment component later on. This could even be a separate package.

Another thing to keep in mind are supported locales :

date-fns : 32 main locales
moment.js : 120 locales (if we count all variations of "en-GB", "en-US", "fr-FR", "fr-CA" etc.)

Actually @gerbenmeyer I think it would be better that 1.X.X versions of react-i18nify does not include BC breaks or compilation warnings.
If we wish to evolve in another direction, wether it is to switch to date-fns or to support multiple libraries, I think we should start working on another main version.
react-i18nify has been downloaded > 151k times in 2017 (according to NPM), BC changes should be not taken too easily ;)
https://npm-stat.com/charts.html?package=react-i18nify&from=2016-01-01&to=2018-02-06
That being said, I'm ready to commit myself into working on another major version (even though I cannot support that charge all by myself, especially maintenance).
It would obviously require some documentation as well if that's the decision we make.
Despite react-redux-i18n, do you know which other packages are already distributing react-i18nify?
It might be interesting to get some insights from the eco-system, what do you think?

My idea would be to revert back to always importing moment + locales in 1.X.X (so to be not breaking, and fix all warnings), and switch to date-fns in version 2.X.X.

Agreed! :)
I this case, I think we can close this issue for now, I open a PR for a 2.X.X version on which we can continue to discuss this furthermore.

Actually I can't open a PR without commits. Is it something you can do @gerbenmeyer?
Otherwise I will open one as soon as I can come with something interesting :)

Cool, I'll revert the optional moment in 1.X.X

Isn't the normal flow to fork, commit, and then PR?

Probably, opening a PR without commit was just in order to continue the discussion, but as you prefer. We can discuss after commits as well :)

I didn't even know that was an option :stuck_out_tongue:

Just to note it somewhere, date-fns is currently working on a 2.0.0 (currently alpha-7) version which includes localized formats aswell.
I'll follow that :)
https://date-fns.org/v2.0.0-alpha.7/docs/format

Just want to add a data point to this discussion. I wanted to remove unnecessary moment locales from my webpack bundle, and in order to confirm the result I ran an analysis on that bundle:

As you can see, I am getting both the locales I left in and the minified locales.js file due to the way that react-i18nify currently loads the locales. The real kick in the teeth is that moment isn't even a direct dependency of my project at all, it's just a dependency of several dependencies.

Thanks for the screen @lyleunderwood, I had that in mind as well, this is why I think react-i18nify should not include any locale itself by default.
However, removing it would be a BC break, therefore I think such evolution should be made in the coming 2.0.0 branch.
Hopefully I will be able to propose some starting point this week or the one after... (I am a bit busy at the moment).

@flo-sch Until then I will probably put together a fork which just removes the offending line to use for my own purposes.
Keep up the good work, all!

Sure, you can always do that ;)

Actually @lyleunderwood, as you are using webpack, have you tried the ContextReplacementPlugin?
It might be a quick fix solving your issue?
It works for me with<EMAIL_ADDRESS>not sure about version 2 but it's worth trying it IMO :)
However is that it requires you to set the available locales in the webpack config... But adding locales is probably not supposed to change on a daily basis.
// webpack.config.js

module.export = {
    // ...
    plugins: [
        new webpack.ContextReplacementPlugin(/moment[\/\\]locale$/, /en-gb|fr|de|es|it|ja|ko|zh-cn/),
        // ...
    ]
};

@flo-sch Coming here from https://github.com/iamakulov/moment-locales-webpack-plugin/issues/4 – JFYI, MomentLocalesPlugin already uses ContextReplacementPlugin under the hood, so that won’t help :/
As far as I understand, the problem here is that locales are not only included in full, but included twice. On the @lyleunderwood’s size, this can be fixed by either of:

using MomentLocalesPlugin (or ContextReplacementPlugin) to strip locales included as separate files + forking the repo to remove the moment/min/locales import

using MomentLocalesPlugin (or ContextReplacementPlugin) to strip locales included as separate files + using IgnorePlugin to prevent webpack from bundling the moment/min/locales import.

In the latter case, the plugin usage might look like this (I haven’t tested this though):
// webpack.config.js
module.exports = {
  plugins: [
    new webpack.IgnorePlugin(/moment\/min\/locales/, /react-i18nify/),
  ]
}

@iamakulov

This does the trick, thanks! Reduces my bundle size from over 1M to ~600K.

I'll note, however, that moment.js is still shockingly large.

For those who're interested, I started working on v2 of react-i18nify, in which moment.js has been replaced with date-fns. Feel free to check out the v2 branch or to install it with the next tag npm i react-i18nfiy@next and let me know what you think.

Nice! I gave up on the conditional build with webpack unfortunately, did not found the way the compile with either moment or date-fns :(

NB<EMAIL_ADDRESS>not yet released, according to last issues, could be soon?

Just released v2 of this library, which doesn't use moment, but date-fns v2 instead!


Frequent crashes followed by inability to reopen the window (on Windows 11)

Description
On Windows 11 I've been facing frequent crashing of the app followed by the window failing to open on successive attempts to open the app. This failure is observed as an auto-crash as soon as the window launches upon the clicking of the app icon. Please resolve this soon as it is already hindering my work (and probably many others) frequently.
Steps To Reproduce
No response
Expected behavior

The app shouldn't crash during normal browsing activity.
The app shouldn't crash as soon as it is launched. If it does, it should "temporarily" start in safe-mode (and "temporarily" reset itself to the default settings that are sure to work)

Files Version
<IP_ADDRESS>
Windows Version
10.0.22000.348
Relevant Assets/Logs
debug.log
debug_fulltrust.log

@navedrasul is this still an issue in the preview version? https://files.community/download/preview


抖音好像无法解析了

如题

Hi I just make a new realease fixed this issue, please see the note below:
https://github.com/Evil0ctal/Douyin_TikTok_Download_API/releases/tag/V3.2.1
Thank you all, and have a nice day ❤


adding django CMS release script (will be used starting 3.9.0 release)

Description
This PR adds an script to automate the release process. This will be used for 3.9.0 and onward (will auto-merge this before starting the actual release cycle)
Checklist

[x ] I have opened this pull request against develop
[x] I have updated the CHANGELOG.rst
[x] I have added or modified the tests when changing logic
[x] I have read the contribution guidelines  and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@FinalAngel  @NicolaiRidani  for visibility (I'll merge this before starting 3.9 as this is the actual process used to create the release :) )
This file may change during the release cycle (debugging/improvement as I use it), but that's fine as it is standalone.

Since I am waiting on Django 3.2 integration review/merge, I am also taking the time to polish/refine the script.

separated some useful pieces for translation management
narrowing the translation pull-in to clean the release
likely play with gh (github cli client) to generate automatically the PR if I have enough time.

=> done and merged


Core recycler conveyor belts are set up wrong

Description

The belts leading to the recycler need to be rotated 180
Reproduction

Screenshots

Additional context

wait actually? I swore it was fine

I'll check it next time i update the map


Sharer of Costs Specification - Review-SRS-Team6

Hi Team9,
The SRS is really well done and easy to follow, Figure 2 (usecase diagram) was especially useful to reference when reading the document!
Regarding section 7.5 "Formal Specification of Cost Management System", the function $S$ and set $U$ seems slightly misdefined:

For example, I think the statement:

For users not in $U_i$

was probably meant to be

If a user $u$ does not share the cost of some item $i$, that is $u \not\in $S(i)$, then $P(i, u) = 0$

This would make more sense since $U$ must contain all users, and the intended message here is "if a user is not a sharer, they owe 0 dollars on that item". It would also make use of $S$, which isn't used anywhere else in the document from my understanding.
Marking TA: @samm82

fixed


Create forms should populate ID

after a create form successfully adds a new record, it should populate it's ID field, so that it's usuable in a normal rails controller flow:
  form = NewDataForm.build(data_params)

  form.save
  if form.success?
    redirect_to data_path(form)
  else
    render :new, form: form
  end
end

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9555850-create-forms-should-populate-id?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github).

presently, I have to dig in for form.result.value[:id] to get the show-page redirect that's standard rails controller flow.

Actually I think the proper way of doing this is unwrapping the result and using whatever the command returned. We can wrap it up as an object too (this is a missing interface in Form though).
So, something like this would be much nicer:
form = NewDataForm.build(data_params).save

if form.success?
  data_object = form.something_that_returns_the_created_data_object
  redirect_to data_path(object)
else
  render :new, form: form
end

...or we could make sure that to_key works with a saved form but that's even more mutability in the form object so meeeh.

This looks like it'll blend in really well with #185, once that's in place.
Although I think getting something in place for a 0.3.1 release might still be a good idea, even if it gets updated once rom-0.7.0 goes out.

Yep we should push 0.3.1 with those changes merged
On Tue 24 Mar 2015 at 15:14 Chris Flipse<EMAIL_ADDRESS>wrote:

This looks like it'll blend in really well with #185
https://github.com/rom-rb/rom/issues/185, once that's in place.
Although I think getting something in place for a 0.3.1 release might
still be a good idea, even if it gets updated once rom-0.7.0 goes out.
—
Reply to this email directly or view it on GitHub
https://github.com/rom-rb/rom/issues/181#issuecomment-85512384.

with #187 merged in we could extend form dsl to support something like that:
class CreateUserForm < ROM::Form
  # this would make Form generate a command registry tailored to return entities using :entity mapper
  commands users: :create, as: :entity

  # rest of the stuff
end

Yup.  I'll work on wiring that up.
Saw on gittr that you're hoping for a 0.6.1 release sometime this week?

@cflipse yes, wrap things up before Thursday and release on Friday

work in progress:  https://github.com/cflipse/rom-rails/tree/result-data-object
In some sense, this feels a bit clunky to me, acutally poking through it.  The suggested API breaks, so I'm starting from a simpler point, and once the basics are down, I can try and shift up to it.  But in looking at it, I'm thinking it might be simpler and more consistent to do something more like:
  result = form.save
  object = result.as(:entity)

but that requires the result to know about the relation, and it's mapping, and that might be pushing information too far down.
I'm pausing here because it's late and I'm tired; I won't likely get a chance to poke at this again until Thursday, late ... more likely Friday evening.

yep makes sense to start as simple as possible :)

Question: is :entity here a magic static keyword or an entity defined before?

it's the registered name of a mapper.


Migrate to Go 1.13 and gomodules

Coverage remained the same at 93.831% when pulling 1fac7a2fccfed409d238c5a14b5035f573388e9e on update_1.13 into 637c82f407d7945ad7a4e856f8dc73f10c82a0a8 on master.


nixos/darkhttpd: module to enable darkhttpd

Motivation for this change
I've had this one sitting around for quite a while.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@Infinisil , you're good with the current state?

Ping? Other than the thing mentioned above, this looks good to me

Are there any updates on this pull request, please?

@GrahamcOfBorg eval

@GrahamcOfBorg eval

I ripped out the package option as the jury is still out on that. The rest should be fine.


API for Java

Hi,
Can you make a Java API for Easymc? I would really love it!
Thx

Hi, unfortunately I have since abandoned this project. Even if I were still to be working on it, I would not be coding an API in it for Java, since I really don't like coding in Java. Maybe Kotlin. Thanks for taking interest!


Don't show unspecified country element with no count.

Codecov Report

Merging #134 into develop will decrease coverage by 0.23%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           develop    #134      +/-   ##
==========================================
- Coverage    98.03%   97.8%   -0.24%
==========================================
  Files           22      22
  Lines          408     410       +2
==========================================
+ Hits           400     401       +1
- Misses           8       9       +1

Impacted Files
Coverage Δ

web/olga/analytics/views.py
99.12% <50%> (-0.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b3c44...653e2f2. Read the comment docs.


Other discrepencies with 2.0 spec

Catch all for anything in the code needing to be caught up to on the 2.0 spec

selection sequence numbers should be sequentail in the contest.
"The first selectable option in the list has option index 1." (p.17)

Fixed in PR #378

Hashing strings (5.1.4)
"When an input to the function H is a string s, it is encoded as a byte array b(s, len(s)) using UTF-8
encoding. Here, len(s) is the length of the UTF-8 encoding of the string s in bytes."
But we are just using String.encodeToByteArray().
Works as long as we are consistent, but will break vs conformant  implentation.

Preencryption verification is not complete.

verifyConfirmationChain Err(readEncryptedBallotChain path 'testOut/cliWorkflow/electionRecord/encrypted_ballots/device42/ballot_chain.json' does not exist)

Since ContestData format is not specfied, we will disagree with the rust library.


Incorrect panic msg during log.Panic()

have:
panic: (*logrus.Entry) (0xddc300,0xc42019e700)

want
panic: some error happened.

where some error happened is msg that was logged.

I see you have pushed a fix to your fork. Do you want to add a test case and open a PR?

Hi @dmathieu!
If sir @sirupsen will approve proposed solution, i will.
Also we can format original message with logrus Entry to print struct data too if needed.

@mkorolyov @dmathieu can accept your solution if you open a PR :)

All right, I've been looking a bit further into this, and your solution doesn't work because we expect an entry to be sent to panic.
https://github.com/sirupsen/logrus/blob/master/example_basic_test.go#L26
This seems to be so that you can recover from the panic and inspect the full entry.
Though I'd agree that panicking with a struct is weird. So I'd be tempted to say that we should always panic the formatted message, not the fully entry.
@seiffert any opinion?

sorry guys for delay, leak of time, will add PR with formatted msg a little bit later

@sirupsen Hey, could you pls take a look?

Hello you have 2 PRs concerning this issue #742 and #623.
Which one shoudl I look at ?

Ok it seems it is #742

I wonder if this is what we really want to do, it will change the return  value of a recover call.

Any update on this?  To me, it doesn't make any sense to pass a logrus Entry to a panic statement. Passing the Entry.Message would be much more meaningful and help debugging. Thanks!

Making this change is an interface break regarding 1.0 api, we can't merge that lightly.
We can also argue that returning a string is better than returning the full entry which contains much more information.

There is a potential middle ground, although it still breaks the current API: if logrus.Entry implemented fmt.Stringer by removing the error return value from its String() function then panic() would log the message as expected and people who wanted to recover and inspect the Entry object could still do so. Implementing error would also work, but that would require changing the Error(...interface{}) function which is probably used more than String() (string, error)
I couldn't find any code calling the String() (string, error) function inside logrus, but it would still be a breaking change in case other people are calling it.


Format of the custom section

The general idea behind this tool is that source languages will encode data into a custom section of the wasm binary which the wasm-bindgen tool will decode and remove, using it to generate appropriate JS bindings.
Currently, however, this isn't what happens! Instead we shove data into a static as rustc doesn't expose a way to emit data into a custom section as-is. Additionally the static is just a totally random encoding that I got working, it's not principled at all. We should fix that!
I think it's relatively uncontroversial to use a custom section to communicate this information, and we'll continue to work around rustc's lack of ability to emit a custom section in the meantime and will otherwise take advantage of the ability to do this in rustc as soon as it becomes available! In the meantime, though, I think it may be useful to discuss the custom format as well.
Right now the wasm-bindgen-cli-shared crate shows off effectively what's encoded right now, the top-level entry being a Program and a wasm binary has multiple Program instances. That is, however, only what the bindgen tool currently uses and will likely change over time both in requirements and breadth. In that sense, does it makes sense to lock down a binary format just yet? Or maybe we can lock down an extensible format like JSON which you can easily add keys to over time?
One thing I definitely want to do in the near term is to version the wasm-bindgen information in the sense that if the CLI installed at a particular git rev finds information produced by a different git rev then it should immediately generate an error saying they're out of sync (as it's so unstable). Eventually this'll probably get removed and we'll want to have the producer and consumer versioned separately, but that may be awhile!
In any case, this is all just some off-the-cuff thinking, I'd love to hear others' thoughts on this too!

cc @ashleygwilliams @lukewagner

Just from a quick glance at wasm-bindgen-cli-shared, it looks like you're in the right space.  Walking over this carefully to see if we could map each bindgen type to a C++ signature would be useful at some point, but probably later.  It sounds like, especially with versioning, you'll be able to iterate on the details of this custom section for while to come.

As of today the custom section is a bunch of JSON blobs of this schema prefixed with a binary 4 byte length so they can be concatenated

As an example here is what the output of the comments example looks like
gist

There is another problem with this approach. Consider this code:
#[wam_bindgen]
pub fn main() {
    web_sys::Window::alert_with_message("Hello world! (alert)");
    web_sys::console::log_1(&"Hello world! (console.log)".into());
}

It works fine. But, if you try to remove out call to alert, like so:
#[wam_bindgen]
pub fn main() {
    web_sys::console::log_1(&"Hello world! (console.log)".into());
}

Then it will compile, CLI will not produce any errors, but it will throw exception like these in runtime:
LinkError: import object field '__widl_f_log_1_' is not a Function

Uncaught (in promise) LinkError: WebAssembly Instantiation: Import #0 module="./wasmtest" function="__widl_f_log_1_" error: function import requires a callable

It turns out that there are no mentions of the __widl_f_log_1_ function (it meant to act like a proxy: it is called from WASM, and then it calls the target function, console.log in this case) in the JS file produced by CLI at all, that is why browsers fail to find the import.
CLI uses a custom section stored in a WASM file (that is an only input of it) to store a list of functions for which such proxy functions in JS should be generated. The custom section is emitted while expanding macros in the Rust compiler. It is done here: https://github.com/rustwasm/wasm-bindgen/blob/15654591074b3895c61401e638ef26d41d3066a9/crates/backend/src/codegen.rs#L111-L118
But, if you try the check WASM file, you will see that there is no __wasm_bindgen_unstable section for web-sys in it, only ones for js-sys, while in the WASM binary for the first example both will present.
I think that this happens when you do not use anything that is in web-sys itself, only in methods from submodules. To confirm that this is true, I have done some testing.
Unzip the test.zip file. It contains two crates: test123 and test456, the former depends on the later. Try to build test123 for the WASM target architecture (cd test123 and cargo build --target wasm32-unknown-unknown). Then do wasm2wat -v target/wasm32-unknown-unknown/debug/test123.wasm | grep -A 1 __wasm_bindgen_unstable. As you can see, the binary actually has the __wasm_bindgen_unstable section:
  BeginCustomSection('__wasm_bindgen_unstable', size: 27)
  EndCustomSection

Then comment out the test456::m(); line and repeat last steps. The output of the grep command will be empty.
I believe that it means that 2 examples in the begging correspond to these ones for this simple test:
#[no_mangle]
pub extern fn main() {
    test456::n::m();
    test456::m();
}

#[no_mangle]
pub extern fn main() {
    test456::n::m();
}

Thanks for the investigation there @afdw! I don't think it's necessarily related to the format of the custom section though (this issue) and should be fixed by https://github.com/rustwasm/wasm-bindgen/pull/846 in any case!

I am curious of there would be any interest in moving to formalize this against something like Estree?

Perhaps! Right now though it's pretty ad-hoc so it may not be worth formalizing too much. If we were to actually formalize it, though, that sounds good to me!


🚀 Feature: github.com/host & /branch annotation to help support multiple github enterprises environments

🔖 Feature description
The available project-slug is useful because you're able to get the organization along with the repository name. What we don't know is ... what is the host? GitHub integrations have GitHub Enterprise support through server host properties.
I found that adding an additional annotation to entities can help eliminate the guess.
cisco.com/host: ghe.somewhere.com

Between that annotation and the project-slug it's enough to create a URL to the repository for use in custom template actions or in custom GitHub plugins.
The only other thing to consider is for a GitHub URL it's basically <host>/<org>/<repo> and the branch. Based on GitHub Api schema I'd also propose a default_branch identifier. Something like:
cisco.com/default-branch: main

It looks like this "missing piece" has been an issue for others if I'm understanding the comments from the end of the file at https://github.com/coder/backstage-plugins/blob/main/plugins/backstage-plugin-devcontainers-backend/src/processors/DevcontainersProcessor.ts#L219
🎤 Context
Supporting Enterprise environments with thousands of repositories spread across multiple GitHub Enterprise (GHE) hosts most plugins don't take advantage of the ScmAuthApi to merge multiple providers (GitHub Enterprise for me) into a single interface. It's also been hit or miss on whether or not plugins support not just a single instance of GHE but potentially dozens.
What has helped me was a host annotation but branch is also important as a unique identifier to the source code. Based on that I'd propose to provide two additional GitHub Annotations:
cisco.com/host
cisco.com/branch

Could go either way but keeping with GitHub Api's schema response they used default_branch so keeping context close to home. For non-default branch could see branch to be able to provide ability to target tags feature branches on entities.
✌ Possible Implementation
Addition of two new Well Known Annotations for GitHub:
cisco.com/host
cisco.com/branch

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

The backstage.io/source-location is a widely used annotation that I think serves this use-case well too. It keep track of both where the entity is hosted and optionally which branch it's on. Ideally you're able to use that without any further additions.

@Rugvip the problem I ran into with source-location is in a large enterprise with hundreds of GitHub orgs across dozens of GHE servers was enabling access to the repos to keep catalog data updated and current. As a tradeoff we created a "phone book" repository that contained catalog data in a shared space that points outwards to the resources.
For those services defined in a shared repo the source-location is the repo containing the entity definitions and not the actual GitHub repo where the service code is located.
In that case the source-location becomes the source of the metadata that's where the necessity to have support for pointing the GitHub integrations, through annotations, to the "source" repo of the service.

@CiscoRob with a phone book repo pattern you'd still actually want to point source-location to where the actual source code of the component resides. The backstage.io/managed-by-location is the annotation that keeps track of where the entity is defined. Afaik you can explicitly define the source-location annotation with the correct location of the source code, and the catalog processing should not override that.


Remove dependency on SQLite.swift

SQLiteSwift is doing rather minimal work in the SQLiteStorageEngine, and was added because I was building a prototype to see the performance of an SQLite-backed StorageEngine. Now that the concept has been proven out quite successfully I'd like to remove the dependency, though I don't have the time to do so at the moment so Bodega can be a free-standing solution without depending on any other libraries.
I'd be very happy to accept help if someone has the expertise to convert the handful of queries that make up the read/write/delete operations in SQLiteStorageEngine, and willing to offer help if you run into any issues. 🙇🏻♂

Hi, I was about to open an issue on Boutique to ask it, but I think it's more relevant here:
I have some viewModels using @Stored(in:) to access the database data.
The problem I'm hitting is that unit tests tend to fail easily when the whole suite is running (as the persistence of mocks happen during integration tests): is there an option to enable Sqlite in-memory database, or could be added after this work?
Or alternatively, do you recommend any strategy to test components with @Stored properties?


fix License & Credit texts extending outside

Related Issues
Close #1204
Summary

We will set the fixed text width and English font size on the main_menu>about>license page and main_menu>about>credits page.

I checked the bug has been resolved. Thank you for your contribution!


Prompt before deleting an address.

As a user am used to getting that extra worning, when am about taking a potentially bad action.
So am suggesting that there should be a dialogue box telling me that I should ensure I have my keys before deleting my address.

Hi, This issue should be fixed on the next release and is currently in the develop branch under commit d3364cb02a3e5f8908ac18e4adf7565315042d9c


MultiPass is not working when used on startup pages

If I add pages with HTTP authentication to On Startup asking Chrome to Open a specific page or set of pages in the Settings when I start Chrome. MultiPass do not work.
If I remove this pages from the On Startup in Chrome and just type the URL or use the bookmark the regex kick in and MultiPass is working correctly.
I am running: Chrome Version 64.0.3282.167 (Official Build) (64-bit) on Linux Gnome Version 3.22.2 on Linux Debian 9.3

Closing this as it seems there is no solution to fix it :/


Check sufficient utxo confirmations exist before submitting send request

I tried sending funds with collaberative transaction enabled.
The interface indicated that a CoinJoin was in progress...
After some time, the 'Joining...' status indicator disapeared from the dashboard.
The CoinJoin was not successful.
After some time, I realised it was most likely because the UTXO being spent was still unconfirmed.
My suggestion is to add a check, prior to processing the send request, to verify that the UTXO(s) being spent have sufficient confirmations.

This is also mentioned in #66: "Prevent user from starting taker with insufficient funds"

Might be that a taker operation is started and then aborted - either unconfirmed or too little funds available (takes 60s to be resolved)

Informational feedback to the user generally needs a lot of improvement  - currently, a collaborative transaction can fail anytime without feedback - regardless if the coins are confirmed or unconfirmed.


Trying to re-order a Draggable column over non draggable (Reorderable column over non reorderable column) leads to duplication of the column

I have few columns which are frozen left and non draggable (or non reorderable) Example: A B C and rest columns at the right are draggable (or reorderable) Ex D E F.
For Ex
A   B   C    D  E  F
I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
When I try to reorder a draggable column over the non draggable one the source column gets duplicated and the target column becomes invisible.
If i reorder the draggable column with a draggable one , it works fine.
In our example : If i try to reorder D E F with each other it works fine. Since A B and C are non draggable I can't move them. The problem occurs when i try to drag either of D E F over A B or C
Expected behavior
If i try to drag D over A ... Both D and A should stay intact. There should be no duplication of any column.
Please tell us about your environment:
Windows 08

Table version: 0.8.x
11.1.5

Angular version: 2.0.x
4.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

+1 , I also experienced this.
Reproduction steps:

View the pinning demo at https://swimlane.github.io/ngx-datatable/#pinning
Drag the Gender column onto the Name column (you might have to do it twice)
Observe empty and duplicated columns


Convert from apischema to pydantic

After https://github.com/dls-controls/scanspec/issues/52

done #85


docker-compose in docker

I have docker-compose installed on the server like this:
$ docker-compose --version
docker-compose version 1.8.1, build 878cff1
$ which docker-compose
/usr/local/bin/docker-compose

I start my docker container like this:
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock myservice:latest

and myservice:lastest is built from
FROM docker:latest

inside the container I call a bash script that does docker things..and all works fine.
I also want to call docker-compose and have it use the docker-compose on the host in the same as docker does.
Not sure how to do this.....any ideas?
Thanks
Matt

figured it out....here's the answer to help anyone that is trying to do the same thing.
Inside the bash script running in the container you run docker-compose as a container rather than try to use the docker-compose on the host.
Like this:
docker run --rm  -v /var/run/docker.sock:/var/run/docker.sock -v /home:/home -w /home docker/compose:1.11.2 -f docker-compose-you-want-to-run.yml  up -d --no-recreate
make sure you copy docker-compose-you-want-to-run.yml into /home first.


Inline code is displayed as block with Coy theme

As can be seen in the “Remove initial line feed” plugin page. With the default theme:

With Coy:

@tshedor?

I ran into the same issue today.
A quick fix is available by adding the following CSS code:
:not(pre) > code[class*="language-"] {
    display: inline;
}

Fixed by #725.


Create zoom box/magnifying glass

Create a second pdf viewer at a larger scale that sits on top of the current viewer but is clipped to a smaller size with the transform origin set to the mouse.

I might try this one - hoping you haven't already starting working on it @courtneypattison!

Please do! I haven’t touched it. I think people will be really happy about this one!

So I learned that pdfjs doesn’t do any sort of optimization or partial rendering. That means that an additional zoom box will always be a full second render. I think we might still be ok here, as these pdfs aren’t typically very full of information, but it’s something to think about. Tiling pdfs won’t fully re-render because we can control which page is rendered based on mouse position.
I’ve started this but it could take me awhile. My nights have been pretty busy lately!

No rush! It sucks that pdfjs doesn’t have any optimizations for this case but I have a feeling the performance will be ok. Also, this is making me remember an idea, maybe we should start auto removing margins. The margins on some of these PDFs are wild.

Are you thinking of using imageData for this? Check the location of the farthest left/top non-background data, and the farthest right/bottom and provide a smaller crop (canvas size) with a predetermined margin?

I might put a brief pause on this, until the new matrix transformations are in place. I'm thinking those changes are going to affect how I determine coordinates of the zoom box.

I think that’s a good idea.
Also, I should probably mention that I’m planning on merging the beta branch into main weekly on Monday/Tuesday to have a more consistent schedule and not be fighting fires all week. Open to suggestions if anyone has other ideas though!

That's up to you. I will likely only be able to help bug fix on weekends, and even that is going to start getting dicey for me soon. So I probably shouldn't be the reference on how you do your schedule. Whatever works for you!

Okie doke, good to know! I was thinking Monday/Tuesday because PP has the most activity on the weekend so I don't want to break things for people on their weekend sewing days lol. I think I'll go with the flow for this release since there's a few things to be completed before it's ready to go.

Once #154 is merged I think the codebase will be in a good place for a feature like this. I changed the 'perspective' matrix so that using transformPoint/s with it will give you results in the same coordinate system as the transformSettings matrix (unit of measure coords), so you won't have to mess with multiplying or dividing by ptDensity as much. The only major change I could forsee would be changing tranformSettings to just be a Matrix, but that wouldn't really mess with the logic too much really.

For avoiding confusion with how manual calibration works with a user specific calibration zoom, I suggest any zoom type of feature be called "Scale" not Zoom.
So accurate is "100% scale", then whatever you choose how to do it, typing or presets, the wording should be "120% scale", "90% scale", etc.
People will love this, and it will be just like printing at a different scale than actual/100%.

@sashasewist I'm not sure if this is the right place, but I saw you commented about using Scale instead of Zoom for scaling the PDFs. I love that idea! This feature is a little bit different. It's for making a little magnifying glass that could be used for reading text and looking a lines when stitching overlapping PDFs. I'm going to reopen another issue that was closed for adding zooming to the whole PDF. I think it's time to tackle that one because quite a few questions for PP in the group have to do with scaling nowadays.


Lidar Reader Patch

It seems that the current lidar data file reader (pytsg.parse_tsg.read_hires_dat()) doesn't quite match the file structure of the *_hires.dat files, and the amendments in this PR should provide a general solution which fits at least the current generation of instruments.
Additionally:

a per_spectra keyword argument is added to this function, allowing (by default) the return of one profilometer sample per spectra rather than multiple, making it easier to view these side-by-side. The same or similar keyword argument could optionally be added as to pytsg.parse_tsg.read_package() and then passed into read_hires_dat() if you see particular value in the higher resolution data.
an unused io import is removed.

Thanks @BenFGA, this is shaping up to be a super useful package!


Sync: fix Reduced / No CV sync

[ ] Reduced CV
[x] No CV

Should I add a new ticket for a more elegant failure mode? Simply refusing to fail the RCV/NCV update and carrying on with the rest isn't my idea of elegant failure.

No, I'll fix everything in this issue.


Allow module/class constants access in macro controls

module Module
  CONSTANT = 42
end

macro use_constant
  {% if Module.CONSTANT == 42 %}
    true
  {% else %}
    false
  {% end %}
end

p use_constant  # should print `true`

Error: Syntax error in eval:6: expecting any of these tokens: IDENT, +, -, *, /, %, |, &, ^, **, <<, <, <=, ==, !=, =~, !~, >>, >, >=, <=>, ===, [], []=, []?, [ (not 'CONST')
Using Crystal 0.21.0: https://carc.in/#/r/1otp

This does work, its just the syntax for accessing constants is Type::CONSTANT.

https://carc.in/#/r/1otz

Oh yes of course, too tired maybe... Thanks


Use fastprogress

Checklist

[x] Passes pre-commit run --all-files

[ ] Tests added / passed

supersedes #237

Just gave it a quick go and got some mixed results. The progressbar stays in one piece, but appears in between my messages.

I could totally live with this though.

The progressbar stays in one piece, but appears in between my messages.

I will investigate this before merging, and will let you know if there's any workaround.

@jbusecke, I may have found a solution for your problem.
When you get a chance, can you try replacing your print statements with
print(..., end=' ')

I am going to merge this for now. We can revisit it if any other issues show up


Use trimmed filename so readers can infer format.

The current ResourceFactory implementation takes care to remove any .open extension, so that 'mid-write' WARCs can be used. However, when attempting to parse it uses the original filename, which means the readers cannot infer the format correctly from the extension.
This patch just switched to using the filename without '.open' on the end, and so allows the readers to cope with both compressed and uncompressed archive files.

Thanks, and apologies for forgetting the release note.


New contribution by EdithGaspar

Hello!
Thanks for the opportunity to contribute at this project for Hacktoberfest. This is my first participation in Hacktoberfest and it was a pleasure to contribute to your project.

Hello!
Thanks for the opportunity to contribute at this project for Hacktoberfest. This is my first participation in Hacktoberfest and it was a pleasure to contribute to your project.

You're welcome

Thanks for your contributions :)


[Bug] Dependency<EMAIL_ADDRESS>cannot be resolved

Describe the bug
While trying to install Application Insights JavaScript SDK using npm i --save @microsoft/applicationinsights-web, npm gave me the error npm ERR! 404 Not Found - GET https://registry.npmjs.org/@nevware21%2ftools-pre-proc - Not found.
After doing some digging, it seems that the newly released version (0.2.5) of ts-async introduces this issue. Running npm install<EMAIL_ADDRESS>--save results in:
> npm install<EMAIL_ADDRESS>--save
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN node_modules/webpack
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/@angular-devkit/build-angular
npm WARN     peer<EMAIL_ADDRESS>|| >= 12.0.0" from<EMAIL_ADDRESS>npm WARN     node_modules/@storybook/angular
npm WARN     2 more (jest-preset-angular, the root project)
npm WARN   51 more (@angular-devkit/build-webpack, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>|| ^3.0.0 || ^4.0.0" from<EMAIL_ADDRESS>npm WARN node_modules/webpack-filter-warnings-plugin
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/@storybook/builder-webpack4
npm WARN
npm WARN Conflicting peer dependency<EMAIL_ADDRESS>npm WARN node_modules/webpack
npm WARN   peer<EMAIL_ADDRESS>|| ^3.0.0 || ^4.0.0" from<EMAIL_ADDRESS>npm WARN   node_modules/webpack-filter-warnings-plugin
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN     node_modules/@storybook/builder-webpack4
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@nevware21%2ftools-pre-proc - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in: C:\Users\mike\AppData\Local\npm-cache\_logs\2023-06-12T08_29_17_183Z-debug-0.log

While running npm install<EMAIL_ADDRESS>--save does correctly install ts-async.
Desktop (please complete the following information):

OS: Windows 11
Npm: 9.7.1
Node: v16.13.2

To Reproduce
Steps to reproduce the behavior:

Run npm install<EMAIL_ADDRESS>--save
See error above.

Expected behavior
I expected npm to be able to install the package and it's dependencies.

Thanks, looks like I left this in dependencies -- moving to devDependencies

#67

Release PR committed, and internal build/release process started -- should be available in less than an hour (hopefully 30 mins)


PNG error

There is the bug with setjmp, longjmp when it opens a broken PNG file.

It occurred because png_setjmp function should be always the inline one because it calls setjmp function and there is the registers space on the stack which is changed later. When an error occurs longjmp restores that stack pointer and all the registers get the changed values.


prisma/seed.js generated with invalid module access

What version of Remix are you using?
1.7.5
Steps to Reproduce

 npx @remix-run/dev create project-name

? What type of app do you want to create? A pre-configured stack ready for production
? Which Stack do you want? (Learn more about these stacks: 'https://remix.run/stacks') Indie
? TypeScript or JavaScript? JavaScript
? Do you want me to run `npm install`? Yes

then fix package.json "prisma": {     "seed": "node  prisma/seed.js"   } by dropping --require tsconfig-paths/register as this is a JavaScript not a TS project
Expected Behavior
it should work
Actual Behavior
TypeError: Cannot read properties of undefined (reading 'hash')
    at seed (/Users/stefanpenner/src/stefanpenner/lcc-live/prisma/seed.js:14:39)

the generated module code is:
const bcrypt = require("bcryptjs").default;
...
const hashedPassword = await bcrypt.hash("racheliscool", 10);
...

but  the .default appears incorrect, as it is undefined, the following change makes it work
const bcrypt = require("bcryptjs")

Duplicate of #164

@machour yup it is, thanks.


Separate test classes into individual files

Fix #000 (<-- Add issue number here)
IMPORTANT: Each pull request (PR) should resolve an issue. Please create the issue if it hasn't been created, unless you're fixing typos or making minor changes to documentation or infrastructure. In that case, just leave the issue number as #000.
Details
If the PR title isn't enough to describe your PR, please provide details here.
Checks
Make sure these boxes are checked before your PR is ready to be reviewed and merged. Thanks!

[x] PR is concisely and descriptively titled 📑 and links to the original issue 🔗.
[x] Code is in uniquely-named feature branch and has no merge conflicts 📁.
[x] Tests pass -- look for a green checkbox ✔ a few minutes after opening your PR.
[ ] @mentions of the person or team responsible for reviewing proposed changes. By default, use @BadwaterBay/reviewers.
[ ] (Optional) Screenshots/GIFs are attached 📎 in case of UI updates.

We're happy to help you get this ready. Don't be afraid to ask for help, and don't be discouraged if your tests fail at first.

Thank you for contributing to this project!

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   59.44%   59.44%
=======================================
  Files           5        5
  Lines         143      143
  Branches        8        8
=======================================
  Hits           85       85
  Misses         56       56
  Partials        2        2

Impacted Files
Coverage Δ

src/core/create_distance_matrix.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340ac69...edd951b. Read the comment docs.


travis: PHP 7.0 nightly added

Any chance you could get TravisCI to build the extensions and run the test suite?

I'm not sure what do you mean. Could you elaborate?

The PHP extensions needed for the test fail during build time: https://travis-ci.org/reactphp/react/jobs/59153786#L493-L494

I see. It's probably due to development version of PHP 7. For this reason I've added to allowed failures.
When it's ready (stable or with working extensions), it could be moved out of this section.


bug: Theme changing button appears two times.

The button for the changing theme from  dark mode to light or light mode to dark appears two times there is need to remove that button from the one place.

Is the issue resolved?

Solved


Format tooltip

The heading on the tooltip was very large; I must have forgotten to merge some css somewhere back there.
Looking more normal now:

Can you also make the changes in
viz/us-healthcare-system-capacity? That is the main code that the maps/ is autogenerated from (not a great process but the one we have right now)

Please take another look, I added these changes to the viz directory.


isolate the db file

For now, if I open multiple nvim and with different session, if I save bookmark, the db file will cover each other that leading to conflicts.
So add API to reset the db file path.
for example in my nvim lua to open different json db for different session.
local function restore_bookmark()
  local cwd = vim.fn.getcwd()
  require('bookmarks').api.reset_new_db_path(cwd)
end

local opts = {
  post_restore_cmds = { restore_bookmark },
}

require('auto-session').setup(opts)

Please help to check if the cache is removed and the function is working as expected when you working at multiple nvim instances

ok，I will pull and test

test ok


[BUG] It will make a problem when set column print area

🐛 Bug Report

I created a new xlsx file without any content, but only set some column for a print area.
like this:

Lib version: 4.0.1
MS Excel version: 2016
Steps To Reproduce

import { Workbook } from 'exceljs'

async function createWorkbook () {
  const workbook = new Workbook()

  await workbook.xlsx.readFile('a-template-excel-path.xlsx')
  await workbook.xlsx.writeFile('other-or-new-excel.xlsx')
}

The expected behaviour:

Open the export excel then I got popup like this.

EN: Some contents in this file are found to be defective. Whether try to recover as much content as we can. If you trust where the file came from, click 'yes'.
There will be no such problem if use a limited area for a print area, like this:

Possible solution (optional, but very helpful):
One more, all exported xlsx files will prompt me to save on the first exist (without any change), and it will be about 4k larger after the first save.

Same issue here!


Add skid buffer to AXI IF

Add skid buffer to AXI IF.
https://zipcpu.com/blog/2019/05/22/skidbuffer.html
This is feedback from @ZipCPU. Thank you!

done


Wandb fails when run on a server

Hi, I've been using Wandb locally for awhile now using pytorch-lighthing, and it has all worked well. I have just moved my code to a cluster, and now I'm having an issue with the url that wandb is trying to access:
Instead of calling : https://api.wandb.ai/graphql  it's trying to call {proxy_url}/graphql
File "versions/slot_att_local/lib/python3.8/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/client.py", line 60, in _get_result
return self.transport.execute(document, *args, **kwargs)
File ".pyenv/versions/slot_att_local/lib/python3.8/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/transport/requests.py", line 39, in execute
request.raise_for_status()
File "/.pyenv/versions/slot_att_local/lib/python3.8/site-packages/requests/models.py", line 1021, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://hpc-proxy00.city.ac.uk:3128/graphql
Do you have any ideas what I'm doing wrong or what I should change ?

Hi @CatarauCorina, do you access your local instance at http://hpc-proxy00.city.ac.uk:3128 ? If this is the URL where you are hosting your instance then this should be the endpoint where graphQL queries should be pointed. Also, I noticed this URL is http and not https. Is it possible that you have a load balancer or anything in front of the instance that won't accept http traffic?
Thank you,
Nate

@CatarauCorina, if you are trying to log runs to wandb.ai, you may need to re-login. I would try wandb login --cloud --relogin which should allow you to log to wandb.ai rather than the proxy address. If that doesn't work can you check what your env variables are set to and make sure your WANDB_BASE_URL is not set?

@CatarauCorina Since we didn't hear from you, we will be closing this issue. Feel free to re-open if you still experiencing this issue


Add Nuget logo file

PR to update nuspec to point to the logo will come separately.
Part 1 of #149

Why does it look like Swagger but not like OpenAPI?

@sergey-tihon Good question. We might have to think this through a bit more. I'll close this PR for now and will send out a new PR when ready.