Additional parameter for flet.fastapi.app to customize upload_endpoint_path

Make upload_endpoint_path customizable from flet.fastapi.app
Current implementation of the Flet app with FastAPI support does not allow to add custom endpoint for uploading files from FilePicker component. It is only possible via specific environment variable. In that case there is no flexibility.
Solution

By adding an additional parameter upload_endpoint_path to the app() function in the flet.fastapi and providing it to the FletApp() instance will solve the problem.
This will not affect the flow of the application and add one more possibility to setup the upload_endpoint_path from the FastAPI main

Example of the change
def app(
    session_handler: Union[Callable[[Page], Awaitable], Callable[[Page], None]],
    proxy_path: Optional[str] = None,
    assets_dir: Optional[str] = None,
    app_name: Optional[str] = None,
    app_short_name: Optional[str] = None,
    app_description: Optional[str] = None,
    web_renderer: WebRenderer = WebRenderer.CANVAS_KIT,
    use_color_emoji: bool = False,
    route_url_strategy: str = "path",
    upload_dir: Optional[str] = None,
    upload_endpoint_path: Optional[str] = None,  # Added there
    max_upload_size: Optional[int] = None,
    secret_key: Optional[str] = None,
    session_timeout_seconds: int = DEFAULT_FLET_SESSION_TIMEOUT,
    oauth_state_timeout_seconds: int = DEFAULT_FLET_OAUTH_STATE_TIMEOUT,
):
...

    fastapi_app = FastAPI()

    @fastapi_app.websocket(f"/{websocket_endpoint}")
    async def app_handler(websocket: WebSocket):
        await FletApp(
            asyncio.get_running_loop(),
            session_handler,
            session_timeout_seconds=session_timeout_seconds,
            oauth_state_timeout_seconds=oauth_state_timeout_seconds,
            upload_endpoint_path=upload_endpoint_path,  # Added there
            secret_key=secret_key,
        ).handle(websocket)

And also considering to remove an unnecessary if check in this part of the app.py:
    if upload_dir:

        @fastapi_app.put(f"/{upload_endpoint}")
        async def upload_handler(request: Request):
            # if not upload_dir:  <- Remove it, because the top check is present
            #    return
            await FletUpload(
                upload_dir=upload_dir,
                max_upload_size=max_upload_size,

Will you mind opening a PR to share your idea?

Sure, I will open a PR :)

@timok19 , @ndonkoHenri
This is how I am doing it currently. User selected file is uploaded into the dynamically created folder based on user input via variable session_area_path.
@app.put("/upload")
async def flet_uploads(request: Request):
await FletUpload(session_area_path+"/").handle(request)
if file_picker.result is not None and file_picker.result.files is not None:
upload_url=""
for f in file_picker.result.files:
uf.append(
FilePickerUploadFile(
f.name,
upload_url=page.get_upload_url(f.name, 600),
)
)
print(f'upload_url from call to get_upload_url() using {f.name}={upload_url}')
pdffile=f.name ## this would work since we are picking up only one file.
        file_picker.upload(uf)

Is this method incorrect?

@timok19 , @ndonkoHenri
This is how I am doing it currently. User selected file is uploaded into the dynamically created folder based on user input via variable session_area_path.
@app.put("/upload")
async def flet_uploads(request: Request):
await FletUpload(session_area_path+"/").handle(request)
if file_picker.result is not None and file_picker.result.files is not None: upload_url="" for f in file_picker.result.files: uf.append( FilePickerUploadFile( f.name, upload_url=page.get_upload_url(f.name, 600), ) ) print(f'upload_url from call to get_upload_url() using {f.name}={upload_url}') pdffile=f.name ## this would work since we are picking up only one file.
        file_picker.upload(uf)

Is this method incorrect?

Your method is working and seems ok for the basic purpose, but the topic is about an endpoint path modification on backend (FastAPI). What if you want to make a POST request on a specific endpoint? For example, it can be an endpoint that will be generated each time based on a new browser session etc.

@timok19 Got this.
Thank you.


install_requires

tox and pytest is only used for test, so it should not be install_requires. Instead, it can be added to extras_require. So, users don't need to install it.
See https://stackoverflow.com/a/27271396/9567349

ok, thanks!

setup.py modified on master


Update Issue - 49873639

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 76.0

Operating System
Windows 7

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


RD-2583 Fix installation with ssl_enabled: false

Currently, installing a cluster with ssl_enabled: false fails because the manager installation requires the CA key.
This PR fixes this by providing it.

This is a workaround to fix the installation of a 6.0.0 cluster when ssl_enabled is set to false.
The real solution is to fix the code on cloudify-manager-install, and this is done here https://github.com/cloudify-cosmo/cloudify-manager-install/pull/1181

We require the users to provide both the CA key and CA certificate in case they want to use their own certificates, but the CA key is only necessary when ssl_enabled is set to false. I implemented it this way to avoid overcomplicating the configuration file and writing a comment such as: "Please provide the CA key only if ssl_enable is set to off".


"phpdoc_to_property_type" must support a confg option to convert only non-union type

Bug report
class ConfigTrait
{
    /**
     * @param string|array $files  One or more filenames
     */
-    public function readConfig($files = ['config.php'], string $format = 'php')
+    public function readConfig(array $files = ['config.php'], string $format = 'php')
    {
    }

is not supported in php 7.4, a config option must be support - or better, CS Fixer should support some configuration option like "minimal php version"
as the fix is even not 1:1 (union type is not honored at all), I propose to fix the rule to not relate union type at all

A "minimal php version" option would not help, the change is wrong here, array is not compatible with string|array, no matter the version of PHP.
I assumed you meant phpdoc_to_param_type rather than phpdoc_to_property_type but I was not able to reproduce the issue though, please provide information as requested in the issue report template (PHP version, PHP CS Fixer version, your configuration, ...).

I cannot reproduce this on ~latest, please follow the issue template so we have the details needed to debug this. If we've details to work from/reproduce than I'm happy to reopen the issue.

@SpacePossum  , i was facing same issue in past, already fixed indeed ;)


Milk Teas and Mocha Coffee all hard require FD Milk Bottles, and do not also accept Neapolitan ones.

As Neapolitan milk bottles overwrite the recipe of FD milk, disabling that, this makes getting these a bit of an.. issue.

I'll check it later.


Support dynamic framework/xcframework in Virtualized file system

Goal is to have VFS info correctly surface for static/dynamic frameworks, static library and xcframework in this PR.
Changes made

Introduce a new attr for vfs_overlay rule to pass in content of swiftmodule. Right now the asusmption is that .swiftmodule is really a dir that contains .swiftinterface and .swiftdoc. This fixes normal static/dynamic framework not expressing swiftmodules in VFS
In current _xcframework macro, added one more select which encapsulates the vfs overlay info that is based on the platform settings passed in.

How to test
Will add tests in future as we want to ensure VFS works for downstream project first as a standalone feature
TODO

[x] Rename swiftmodule -> swiftmodule_contents
[X] Handle the case when .swiftmodule is just a binary?  -> We now assume .swiftmodule binary is under .swiftmodule dir

@gyfelton I'm wondering if there is any tests that we an add here to ensure this is working. Today there isn't a test for swiftmodules or xcframeworks and it looks like the PR is fixing both

@jerrymarino I need to rebase to make sure it works with the relative path VFS overlay u created.
So please redo the review as it now is properly rebased.
I also apply your fix of umbrella header one in and it does not affect the success build

@thiagohmcruz can take a second look? that issue was not really a issue after all :)


Drain Account safe-app enhancements

Description
A list of enhancements for the Drain account app.
Note: This list of improvements is just a general idea of what we could improve for this app moving forward. Probably will need to be refined and grouped in different tasks :)
Enhancement 1
Improve recipient field so that it is the same that is used used though the safe. Able to select recipients from the address book, QR + ENS support, etc.

Enhancement 2
Unrealistic asset amount + values displayed 0 after performing account drain.
I see a couple of problems setting everything to 0 after a drain:
-Excluded assets are still shown as drained.
-Account is not necessarily drained instantly. It takes a while to execute all smart contracts + drain action might need confirmation from more safe owners.

We should think of a way to make this process more user friendly.
Enhancement 3
Hovering to asset, Amount and Value headers imply that an order by filter can be applied which is not the case. I think we should get rid of the arrows.

Enhancement 4
On Drain review screen:

specify that the address we are sending the funds to is a smart contract address when more than one asset is drained. A drain is a critical operation so seeing an address different to the one specified recipient itself can be scary for users.

Change the Send 0 eth to into something more generic, like send all/selected assets to:

Enhancement 5
When any asset is excluded from the drain, change the 'transfer everything' text in the button to something like 'transfer selected assets'.

Enhancement 6
When all available assets are excluded, make transfer everything button greyed out and not clickable.

this should be a part of https://github.com/gnosis/safe-react-apps


Several broken commands using forward slash

Windows Terminal version
1.19.240226003
Windows build number
10.0.19045.4170
Other Software
No response
Steps to reproduce

Open a Terminal tab in Command Prompt
(note: it seems that in Terminal-PowerShell the commands work normally, although not all of them have been tested, possibly due to modern APIs?)

Enter commands using forward slash to directories using quotation marks (eg. md "C:/folder1/folder2")

See some commands work (eg. md, mkdir, rd, rmdir)

See some commands partially work:
OK --> dir "C:/folder1/"
NOT OKAY (File not found, although it exists) --> dir "C:/folder1/text.txt"

See some commands not working:
type "C:/folder1/text.txt"

Expected Behavior
Although Windows uses backslash for directories, it also works with forward slash, whether in the Windows Explorer address bar or the Command Prompt. In the case of the terminal, just use quotation marks (e.g. "C:/temp/another/folder"), quotes are also used for directories with spaces (e.g. "C:\folder with spaces").
This is done for compatibility reasons, as well as issues like WSL and Sudo for Windows.
Several prompt commands in Terminal work, but some don't work and others display wrong information.
This clearly shows that it is a bug, after all, if support for forward slash did not exist, not a single command would work.
Actual Behavior
Test results copied from: https://stackoverflow.com/a/10526678
C:\>md "c:/temp/"

C:\>REM The forward slash works with MD!

C:\>echo hello world 1>>"c:/temp/test.txt"

C:\>REM Redirection works with forward slashes!

C:\>type "c:\temp\test.txt"
hello world

C:\>REM Of course TYPE works with back slashes

C:\>type "c:/temp/test.txt"
The system cannot find the file specified.

C:\>REM But forward slash version fails

C:\>type "c:/temp\test.txt"
hello world

C:\>REM But TYPE works with forward slash as long as last slash is back slash

C:\>dir "c:/temp/test.txt"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

File Not Found

C:\>REM Note how DIR lists the directory with a \, yet fails to find any files

C:\>dir "c:/temp/*"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

File Not Found

C:\>REM DIR Still fails with forward slashes

C:\>dir "c:/temp/"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

05/09/2012  09:58 PM    <DIR>          .
05/09/2012  09:58 PM    <DIR>          ..
05/09/2012  09:58 PM                13 test.txt
               1 File(s)             13 bytes
               2 Dir(s)  337,001,615,360 bytes free

C:\>REM But forward slash works if no file is specified!

C:\>dir "c:/temp\test.txt"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

05/09/2012  09:58 PM                13 test.txt
               1 File(s)             13 bytes
               0 Dir(s)  337,001,615,360 bytes free

C:\>REM And DIR works with forward slash as long as last slash is back slash

C:\>REM Now add another folder to the path hierarchy

C:\>md "c:/temp/temp/"

C:\>REM Still can create folder using forward slashes

C:\>copy "c:/temp/test.txt" "c:/temp/temp/"
The system cannot find the file specified.
        0 file(s) copied.

C:\>REM Failed to copy with forward slashes

C:\>copy "c:/temp\test.txt" "c:/temp/temp/"
        1 file(s) copied.

C:\>REM But forward slash works if last slash before file name is back slash

C:\>REM Rerun some past tests

C:\>type "c:/temp/test.txt"
The system cannot find the file specified.

C:\>REM Good - it still fails

C:\>dir "c:/temp/test.txt"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

05/09/2012  09:58 PM                13 test.txt
               1 File(s)             13 bytes
               0 Dir(s)  337,001,615,360 bytes free

C:\>REM What is going on?! :( Why did that seem to work now?
C:\>REM More on that later.

C:\>REM Now test the new folder

C:\>type "c:/temp/temp/test.txt"
The system cannot find the file specified.

C:\>REM Forward slashes still fail with TYPE

C:\>type "c:/temp/temp\test.txt"
hello world

C:\>REM But forward slash still works as long as last slash is back slash

C:\>dir "c:/temp/temp/*"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp\temp

File Not Found

C:\>REM Again, forward slashes fail, but directory path is listed properly

C:\>dir "c:/temp/temp/"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp\temp

05/09/2012  09:58 PM    <DIR>          .
05/09/2012  09:58 PM    <DIR>          ..
05/09/2012  09:58 PM                13 test.txt
               1 File(s)             13 bytes
               2 Dir(s)  337,001,615,360 bytes free

C:\>REM And again it works if no file is specified

C:\>dir "c:/temp/temp\test.txt"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp\temp

05/09/2012  09:58 PM                13 test.txt
               1 File(s)             13 bytes
               0 Dir(s)  337,001,615,360 bytes free

C:\>REM Again forward slashes work as long as last slash is back slash

Here is a case that clearly demonstrates a bug.
c:\>dir /s /a-d temp
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

05/10/2012  08:01 AM                13 test.txt
               1 File(s)             13 bytes

 Directory of c:\temp\temp

05/10/2012  07:57 AM                10 test.txt
               1 File(s)             10 bytes

     Total Files Listed:
               2 File(s)             23 bytes
               0 Dir(s)  337,325,191,168 bytes free

c:\>REM Note the different file sizes found in each directory

c:\>dir "c:/temp/test.txt"
 Volume in drive C is OS
 Volume Serial Number is EE2C-5A11

 Directory of c:\temp

05/10/2012  07:57 AM                10 test.txt
               1 File(s)             10 bytes
               0 Dir(s)  337,325,191,168 bytes free

c:\>REM It is listing the wrong file!

Words from the original test author:
One can debate whether Windows CMD is "supposed" to support forward slashes. But that last result is a bug! Even if there is operator error in using a forward slash, Windows should not give that result.

Yep, that does look like some funky behavior in CMD. Alas, CMD is a pretty dated shell that's not being actively maintained. It's got a lot of rough edges, and for back-compat reasons, we won't be updating cmd.exe anytime soon. If you want a modern, updated shell on Windows, you should try out PowerShell 7.
Sorry about that!


Documentation is incorrect to generate a client library

swagger file is a dead link. its now unclear how to generate a client for other languages.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09901557-99b5-3776-56bb-9cc148f7c93f
Version Independent ID: 1e0c11e1-7d7c-99ab-afc2-5da53824361e
Content: Key concepts in the Bot Connector service and Bot State service - Bot Service
Content Source: articles/rest-api/bot-framework-rest-connector-concepts.md
Service: bot-service
Product: bot-framework
GitHub Login: @RobStand
Microsoft Alias: kamrani

Checking it now. Will get back to you soon.


Help to start

Hi,
I am a new user of homebridge.
I set some plugin but I have some problem with Harmony.
I see my activity on Homebridge but not in HomeKit.
Somebody could help me?
Thanks

Hi,
You have to add in home app your device manually . (Add device, enter code which is presented in the log )

Ok Thanks


fix(auth)!: 拆分getUser为独立的认证系统能力

经过进一步考虑，发现getUser应该是一个独立的认证系统能力。有的认证系统不支持创建用户，但是支持查询用户是否存在，比如SSH。有的认证系统支持创建用户，但是不支持查询用户是否存在，比如一些机构的内部认证系统，内部认证系统基本不会给接入者随便查询任意用户的能力。所以getUser应该不是和创建用户的绑定的接口，而是一个独立的能力。

Codecov Report
Base: 64.38% // Head: 64.60% // Increases project coverage by +0.22% :tada:

Coverage data is based on head (f0fdc18) compared to base (9315a08).
Patch coverage: 75.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   64.38%   64.60%   +0.22%
==========================================
  Files          99      100       +1
  Lines        2802     2811       +9
  Branches      349      348       -1
==========================================
+ Hits         1804     1816      +12
+ Misses        953      950       -3
  Partials       45       45

Impacted Files
Coverage Δ

apps/auth/src/routes/capabilities.ts
75.00% <ø> (ø)

apps/auth/src/routes/getUser.ts
84.61% <50.00%> (ø)

apps/auth/src/auth/ldap/createUser.ts
67.85% <67.85%> (ø)

libs/auth/src/getUser.ts
85.71% <85.71%> (ø)

apps/auth/src/auth/ldap/index.ts
46.87% <100.00%> (-9.92%)
:arrow_down:

apps/auth/src/auth/ssh/index.ts
67.85% <100.00%> (+8.76%)
:arrow_up:

apps/auth/src/routes/createUser.ts
83.33% <100.00%> (ø)

libs/auth/src/createUser.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Usernames containing +  cannot be autoprovisioned

Describe the bug
Usernames containing +  cannot be autoprovisioned
Steps to reproduce
Steps to reproduce the behavior:

Run a deployment using keycloak.
Set realm login to use email as username (not required, can just set the username to contain +)
Register a user using + in the local part<EMAIL_ADDRESS>Sign-in to oCIS

Expected behavior
Login to oCIS should occur.
Actual behavior
Login Error.
Your user session is invalid or has expired.
If you like to login with a different user please proceed to exit.
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Error creating user"}
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Autoprovisioning user failed"}
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Could not get user by claim"}
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Error creating user"}
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Autoprovisioning user failed"}
{"level":"error","service":"proxy","error":"500 Internal Server Error","time":"2022-07-01T16:59:23Z","message":"Could not get user by claim"}

Setup
owncloud/ocis:2.0.0-beta.4
https://owncloud.dev/ocis/deployment/ocis_keycloak/
Originally changed realm login to use email as username.

Just some notes because I can't work on this for the next two weeks.
So the issue is here: https://github.com/cs3org/reva/blob/0b65112600ccfd07504c8927d96c7a1e9ac85e7b/pkg/utils/ldap/identity.go#L534
We aren't escaping the memberName correctly which results in this error when parsing the filter:
LDAP Result Code 201 "Filter Compile Error": ldap: invalid characters for escape in filter: encoding/hex: invalid byte: U+002B '+' (&(objectclass=groupOfNames)(member=uid=corby\+,ou=users,o=libregraph-idm))
Our filter looks like this (&(objectclass=groupOfNames)(member=uid=corby\\5c+,ou=users,o=libregraph-idm)) but the parser expects (&(objectclass=groupOfNames)(member=uid=corby\\2B,ou=users,o=libregraph-idm))"
My temporary change to check the fix was this:
func (i *Identity) getGroupMemberFilter(memberName string) string {
      return fmt.Sprintf("(&%s(objectclass=%s)(%s=%s))",
          i.Group.Filter,
          i.Group.Objectclass,
          i.Group.Schema.Member,
~         strings.ReplaceAll(memberName, "+", "2B"),
      )
  }

With that change logging into oCIS was possible.

Fix has been merged into ocis with: #4132

Actually it still doesn't fully work. :sob: let's reopen...


Just a question on how it works...

When you load up a world in the application, does it actually load the chunks? If so, do they remain loaded? I would recommend(If this is the case) that you have them immediately unload so the despawn timer doesn't continue counting down.

Thanks for your feedback. This tool just reads the world files, it never writes anything, so the despawn timer will not be affected.


fix: bump Julia compat to 1.10 in DI and DIT

Versions

Bump Julia compat in DI and DIT to 1.10 (fix #597)
Bump DI to v0.6.17
Bump DIT to v0.8.5

[!CAUTION]
Need to backport these changes in the general registry

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.00%. Comparing base (2fee793) to head (abaafc9).

:exclamation:  There is a different number of reports uploaded between BASE (2fee793) and HEAD (abaafc9). Click for more details.
HEAD has 41 uploads less than BASE

Flag
BASE (2fee793)
HEAD (abaafc9)

DI
34
1

DIT
8
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #598       +/-   ##
===========================================
- Coverage   97.63%   11.00%   -86.64%
===========================================
  Files         110       76       -34
  Lines        5377     3336     -2041
===========================================
- Hits         5250      367     -4883
- Misses        127     2969     +2842

Flag
Coverage Δ

DI
11.00% <ø> (-87.75%)
:arrow_down:

DIT
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: GLTF loading multithreading

What does this PR change?
Fixes https://github.com/decentraland/unity-renderer/issues/1687
Related PR https://github.com/decentraland/unity-renderer/pull/1761
How to test
This branch is best tested using the launcher in developer mode
Set branch as feat/multithreading
Add params DISABLE_ASSET_BUNDLES&DISABLE_WEARABLE_ASSET_BUNDLES to avoid AssetBundles
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Deprecating this PR as it was used for testing new builds


Update reserved port from 10008 to 10011

Signed-off-by: Efereyan Karen Simisola<EMAIL_ADDRESS>Description
This PR fixes #54
Notes for Reviewers
Signed commits

[x ] Yes, I signed my commits.

@leecalcote and @crustyy kindly review my PR. Now, I will go and update the Meshery docs to reflect the network  port being used here

@leecalcote thanks. Im just about to go sleep


[Tagging] Add missing comment, missing space, and convert tag fields into sets.

We use tags solely for membership testing, hence it makes sense to internally represent them using Sets. This makes some of the error handling work for the tag constraint less clunky and verbose.

@musanimu done, thanks for the +1!


Rethink ABI practices

Our ABI usage mostly relies on two things:

hopes and prayers
using the heap

Reason being we bump ABI when the layout changes, not the size (e.g. appending to a class)
Solutions:

wrap internal data structures in a struct passed to a unique_ptr
only expose public data and every object has to be created by the lib, making it a subclass
mark an ABI break every time a class is expanded

ref https://github.com/hyprwm/hyprpaper/issues/225 https://github.com/hyprwm/hyprutils/issues/23 https://github.com/hyprwm/Hyprland/issues/8813 https://github.com/hyprwm/Hyprland/issues/8797
cc @fufexan @outfoxxed @gulafaran
(this also applies to all other hypr* libs)

in the meantime, I'll make a breaking update to HU to nicely tell packagers to rebuild.

I don't think ABI actually matters that much for now. We have tools such as hyprpm and nix that handle it, and the expectation that abi will break on every update.
Personally I think the lack of a stable API is far more of an actual issue, though I am aware that isn't happening.

this is not about hyprpm xd

Mb, misread
I'm not a fan of PIMPL, though it is a potential solution. I think its better suited to projects actually attempting to keep a stable API and ABI, and the subclass thing sounds confusing and probably annoying to work with.
That leaves marking an ABI break, which seems fine to me, because the ABI is breaking.

That leaves marking an ABI break, which seems fine to me, because the ABI is breaking.

As a maintainer of a package, I would prefer a stable ABI. Breaking the ABI requires a rebuild for everything depending on that package. There's 12 other projects from hypr that depend on hyprutils, which I all had to rebuild today to make sure they use the correct library

That leaves marking an ABI break, which seems fine to me, because the ABI is breaking.

As a maintainer of a package, I would prefer a stable ABI. Breaking the ABI requires a rebuild for everything depending on that package. There's 12 other projects from hypr that depend on hyprutils, which I all had to rebuild today to make sure they use the correct library

There isn't automated tooling for this?

That leaves marking an ABI break, which seems fine to me, because the ABI is breaking.

As a maintainer of a package, I would prefer a stable ABI. Breaking the ABI requires a rebuild for everything depending on that package. There's 12 other projects from hypr that depend on hyprutils, which I all had to rebuild today to make sure they use the correct library

There isn't automated tooling for this?

The CI (launchpad.net) performs the build and publishes the package, but I had to trigger the rebuild, there is no automated process for that to my knowledge, at least for Ubuntu/Debian

"don't break the ABI" is easier said than done, especially since our software is not designed with a stable ABI in mind as the top priority, but more like ease of development.
As a package maintainer, you will have to deal with this one way or another. Perhaps you should consider making a quick task to rebuild all dependents of a package?

I'm not saying to completely avoid it, what you did is fine to me. I have set up some scripts.

and the expectation that abi will break on every update.

I just wanted to mention that breaking for no reason is going to be annoying quickly


Provisioning TEOC Site / Set-ExecutionPolicy

Running into issue with Deployment / step 5: Provisioning.  I'm unable to execute 'Set-ExecutionPolicy' in powershell, getting error:
> Set-ExecutionPolicy: Operation is not supported on this platform.
Possibly running into this because i'm running pwsh on macos? Any workarounds?
Overall, great documentation on the installation process!

@eendrulat,
Thanks for your interest in the app.
Please allow us some time. We will get back to you ASAP.

@eendrulat,
Set-ExecutionPolicy command should be executed only when Execution Policy is set to restricted and for non-windows computer it is unrestricted by default.
You can validate this by executing below command.
Get-ExecutionPolicy
Please skip this step and continue with provisioning the site.
Please let us know if you need any further assistance.

@eendrulat,
Please let us know if you need more information on this.
If not, Can we close this issue?

Yes you close the issue, thanks
On Tue, Apr 12, 2022 at 1:44 AM ashrirao @.***> wrote:

@eendrulat https://github.com/eendrulat,
Please let us know if you need more information on this.
If not, Can we close this issue?
—
Reply to this email directly, view it on GitHub
https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/issues/8#issuecomment-1096099011,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEAZZUWOQ5OHSKG4AQZF7LVEUESZANCNFSM5SZKSMNQ
.
You are receiving this because you were mentioned.Message ID:
<OfficeDev/microsoft-teams-emergency-operations-center/issues/8/1096099011
@github.com>


openssl for cli

on top of #302
@jystic

👍 I am good with change, will talk offline about testing/deployment.

🎱 would like to see comparison numbers


Update "discoveryType" Param to "orgDiscoveryType"

Purpose

Since orgDiscoveryType is more descriptive and meaningful, newly introduced discoveryType param is changed to orgDiscoveryType.
If in future, email domain based organization discovery capability is extended to discover the organization of the user based on different user attributes other than email domain,orgDiscoveryType query param can be used to pass in the relevant discovery type.

Related Issues

https://github.com/wso2/product-is/issues/20953

Related PRs

https://github.com/wso2-extensions/identity-auth-organization-login/pull/45
https://github.com/wso2-extensions/identity-auth-organization-login/pull/46
https://github.com/wso2/identity-apps/pull/6805

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10676400274

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10676400274
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10677365532

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10677365532
Status: success


Added isotope dictionary

Expanded isotope dictionary to include more isotopes

Thanks Max, for extending the list of supported isotopes in mrsimulator, and including the two new keywords quadrupole_moment, and atomic_number. The code, however, does not import the said two keywords. Could you also update the spectrum.py file to include the two keywords and add respective tests.

Added keywords quadrupole_moment, and atomic_number to spectrum.py and added test for the parsing of the two new keywords.


One of the two volume servers that contain data returns error: invalid character '\x1f' and MIME type error

Hi,
I have 3 volume servers and 1 master node, I've created a collection name "Animated_2tacopy_count" with count=1 and replication=001
I upload my file with following command:

sweed@dev10:~$./weedfs/weed upload -collection=Animated_2tacopy_count=1 -dir="/home/sweed/animate.mp4
[{"fileName":"animate.mp4","fileUrl":"<IP_ADDRESS>:8081/22,1d9ff15aa7","fid":"22,1d9ff15aa7","size":178481324}]

when I'm asking Master for my file, it return volume servers randomly:
sweed@dev10:~$ curl -I  <IP_ADDRESS>:9333/22,24dbfea5ed
HTTP/1.1 308 Permanent Redirect
Content-Type: text/html; charset=utf-8
Location: http://<IP_ADDRESS>:8081/22,24dbfea5ed
Date: Thu, 31 Dec 2020 15:06:08 GMT

sweed@dev10:~$ curl -I  <IP_ADDRESS>:9333/22,24dbfea5ed
HTTP/1.1 308 Permanent Redirect
Content-Type: text/html; charset=utf-8
Location: http://<IP_ADDRESS>:8081/22,24dbfea5ed
Date: Thu, 31 Dec 2020 15:06:09 GMT

But in browser I can't see my file from volume serevr <IP_ADDRESS> but In another volume server "<IP_ADDRESS>" everything is ok,
actully when browser returns the ip address of 200.22 I can see my file but when it return 200.21 I have mime type error:

And in journalctl of server 200.21 I have this error:
Dec 31 18:23:50 dev11 seaweedfs-volume[20791]: I1231 18:23:50 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

Dec 31 18:25:30 dev11 seaweedfs-volume[20791]: I1231 18:25:30 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value
Dec 31 18:25:37 dev11 seaweedfs-volume[20791]: I1231 18:25:37 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

Dec 31 18:25:48 dev11 seaweedfs-volume[20791]: I1231 18:25:48 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

Dec 31 18:26:29 dev11 seaweedfs-volume[20791]: I1231 18:26:29 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value
Dec 31 18:26:40 dev11 seaweedfs-volume[20791]: I1231 18:26:40 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

Dec 31 18:26:42 dev11 seaweedfs-volume[20791]: I1231 18:26:42 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value
Dec 31 18:26:43 dev11 seaweedfs-volume[20791]: I1231 18:26:43 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

Dec 31 18:27:03 dev11 seaweedfs-volume[20791]: I1231 18:27:03 20791 volume_server_handlers_read.go:187] load chunked manifest (/22,24dbfea5ed) error: invalid character '\x1f' looking for beginning of value

I've created a collection name "Animated_2tacopy_count" with count=1 and replication=001

How did you do that?

sweed@dev10:~$./weedfs/weed upload -collection=Animated_2tacopy_count=1 -dir="/home/sweed/animate.mp4

Seems there is an extra =1 in the command line? And missing the end quote for -dir?
Need to have a reproducible case.

I've created a collection name "Animated_2tacopy_count" with count=1 and replication=001

How did you do that?

sweed@dev10:~$./weedfs/weed upload -collection=Animated_2tacopy_count=1 -dir="/home/sweed/animate.mp4

Seems there is an extra =1 in the command line? And missing the end quote for -dir?
Need to have a reproducible case.

Hi,
I tested it with new and clear collection:
Step1:
I've created a new collection with following command:
> curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_2volume"

So now I have 2 volume on 2 of 3 servers
Step2:
I've uploaded my file:
./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

It uploaded on my servers( <IP_ADDRESS> and <IP_ADDRESS>)
When I want to see my video on 200.23 it shows it very well but on 200.21 I have problem:

and on volume server 200.11 journal-ctl I have this error:
Jan 02 10:00:54 dev11 seaweedfs-volume[20791]: I0102 10:00:54 20791 volume_server_handlers_read.go:187] load chunked manifest (/29,2ca38757d4) error: invalid character '\x1f' looking for beginning of value

Hi,
I tested it with new and clear collection:
Step1:
I've created a new collection with following command:
> curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_2volume"

So now I have 2 volume on 2 of 3 servers
Step2:
I've uploaded my file:
./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

It uploaded on my servers( <IP_ADDRESS> and <IP_ADDRESS>)
When I want to see my video on 200.23 it shows it very well but on 200.21 I have problem:

and on volume server 200.11 journal-ctl I have this error:
Jan 02 10:00:54 dev11 seaweedfs-volume[20791]: I0102 10:00:54 20791 volume_server_handlers_read.go:187] load chunked manifest (/29,2ca38757d4) error: invalid character '\x1f' looking for beginning of value

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

But I've define replication in Master:
1../weed master -mdir="/home/sweedfs/master" -port=9333 -defaultReplication=001
And I define replication when I wanted to create volume with "/vol/grow":
2.> curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_2volume"

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

But I've define replication in Master:
1../weed master -mdir="/home/sweedfs/master" -port=9333 -defaultReplication=001
And I define replication when I wanted to create volume with "/vol/grow":
2.> curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_2volume"

Added code to read default collection from master. https://github.com/chrislusf/seaweedfs/commit/4250a3a67510dda9fe9d6e38d4ea617c97c4c214

Added code to read default collection from master. https://github.com/chrislusf/seaweedfs/commit/4250a3a67510dda9fe9d6e38d4ea617c97c4c214

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

I still have problem even when I'm defining replication in "weed upload":
Please look at my steps:
Step1: I create a collection with replication=001 :
sweed@dev10:~$ curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_define_rep001" {"count":2}
step2: then I upload my file using weed upload with defining "-replication=001"
sweed@dev10:~$ ./weedfs/weed upload -collection="fault_test_define_rep001" -dir="/home/animate.mp4" -replication=001

[{"fileName":"animate.mp4","fileUrl":"<IP_ADDRESS>:8081/192,a6384143af","fid":"192,a6384143af","size":178481324}]

please notice to this url fileUrl":"<IP_ADDRESS>:8081
It is server  200.22
Step3: curl fid from master to find all replica: one rep is  200.22 and another is 200.23
sweed@dev10:~$ curl -I <IP_ADDRESS>:9333/192,a6384143af
Location: http://<IP_ADDRESS>:8081/192,a6384143af

sweed@dev10:~$ curl -I <IP_ADDRESS>:9333/192,a6384143af
Location: http://<IP_ADDRESS>:8081/192,a6384143af

Step4: Downloading file:
From 200.22 (Its OK) 187MB
sweed@dev10:~$ wget http://<IP_ADDRESS>:8081/192,a6384143af
--2021-01-03 11:49:56--  http://<IP_ADDRESS>:8081/192,a6384143af
Connecting to <IP_ADDRESS>:8081... connected.
HTTP request sent, awaiting response... 200 OK
Length: 178481324 (170M) [video/mp4]
Saving to: ‘192,a6384143af.1’

192,a6384143af.1                  100%[============================================================>] 170.21M   187MB/s    in 0.9s

2021-01-03 11:49:57 (187 MB/s) - ‘192,a6384143af.1’ saved [178481324/178481324]

From 200.23 (Its NOT OK) 15.7MB
sweed@dev10:~$ wget http://<IP_ADDRESS>:8081/192,a6384143af
--2021-01-03 11:49:38--  http://<IP_ADDRESS>:8081/192,a6384143af
Connecting to <IP_ADDRESS>:8081... connected.
HTTP request sent, awaiting response... 200 OK
Length: 211 [video/mp4]
Saving to: ‘192,a6384143af’

192,a6384143af                    100%[============================================================>]     211  --.-KB/s    in 0s

2021-01-03 11:49:38 (15.7 MB/s) - ‘192,a6384143af’ saved [211/211]

./weedfs/weed upload -collection="fault_test_2volume" -dir="/home/animate.mp4"

This command did not have replication specified, so it used replication=000.
One collection can also have multiple types of replications.
I suppose the above weed upload command will generate at least 3 file ids. One of them is the chunk manifest. The other two or more are the chunks. The one you showed error is the second half of the mp3 file.

I still have problem even when I'm defining replication in "weed upload":
Please look at my steps:
Step1: I create a collection with replication=001 :
sweed@dev10:~$ curl "http://localhost:9333/vol/grow?replication=001&count=1&collection=fault_test_define_rep001" {"count":2}
step2: then I upload my file using weed upload with defining "-replication=001"
sweed@dev10:~$ ./weedfs/weed upload -collection="fault_test_define_rep001" -dir="/home/animate.mp4" -replication=001

[{"fileName":"animate.mp4","fileUrl":"<IP_ADDRESS>:8081/192,a6384143af","fid":"192,a6384143af","size":178481324}]

please notice to this url fileUrl":"<IP_ADDRESS>:8081
It is server  200.22
Step3: curl fid from master to find all replica: one rep is  200.22 and another is 200.23
sweed@dev10:~$ curl -I <IP_ADDRESS>:9333/192,a6384143af
Location: http://<IP_ADDRESS>:8081/192,a6384143af

sweed@dev10:~$ curl -I <IP_ADDRESS>:9333/192,a6384143af
Location: http://<IP_ADDRESS>:8081/192,a6384143af

Step4: Downloading file:
From 200.22 (Its OK) 187MB
sweed@dev10:~$ wget http://<IP_ADDRESS>:8081/192,a6384143af
--2021-01-03 11:49:56--  http://<IP_ADDRESS>:8081/192,a6384143af
Connecting to <IP_ADDRESS>:8081... connected.
HTTP request sent, awaiting response... 200 OK
Length: 178481324 (170M) [video/mp4]
Saving to: ‘192,a6384143af.1’

192,a6384143af.1                  100%[============================================================>] 170.21M   187MB/s    in 0.9s

2021-01-03 11:49:57 (187 MB/s) - ‘192,a6384143af.1’ saved [178481324/178481324]

From 200.23 (Its NOT OK) 15.7MB
sweed@dev10:~$ wget http://<IP_ADDRESS>:8081/192,a6384143af
--2021-01-03 11:49:38--  http://<IP_ADDRESS>:8081/192,a6384143af
Connecting to <IP_ADDRESS>:8081... connected.
HTTP request sent, awaiting response... 200 OK
Length: 211 [video/mp4]
Saving to: ‘192,a6384143af’

192,a6384143af                    100%[============================================================>]     211  --.-KB/s    in 0s

2021-01-03 11:49:38 (15.7 MB/s) - ‘192,a6384143af’ saved [211/211]

Thanks! Found the problem and added a fix. The manifest file was compressed but not detected.

Thanks! Found the problem and added a fix. The manifest file was compressed but not detected.


[C++] There is a problem with clang-format regular matching.

Describe the bug, including details regarding any error messages, version, and platform.
On my mac system, the version information is
➜  ~ clang-format -version
Homebrew clang-format version 16.0.4

if we use ^clang-format, we can't match.
find_clang_tool(clang-format CLANG_FORMAT_BIN
                "^clang-format version ${ARROW_CLANG_TOOLS_VERSION_ESCAPED}")

Component(s)
C++

Isn't that matches[1] in find_clang_tool[2]?
[1] https://cmake.org/cmake/help/latest/command/if.html#matches
[2] https://github.com/apache/arrow/blob/main/cpp/cmake_modules/FindClangTools.cmake#L61C38-L61C59

https://github.com/apache/arrow/blob/main/cpp/cmake_modules/FindClangTools.cmake#L61C38-L61C59

I got
-- clang-tidy found at /usr/local/opt/llvm/bin/clang-tidy
-- clang-format found, but version did not match "^clang-format version 16"
-- clang-format 16 not found

cmake version is
cmake version 3.18.2

I think it is prefix Homebrew


[SWOC'24] Contributor Section Added

Fixes Issue🛠

Closes #67
Description👨💻

Enlist all the contributors on the main website
Showcase them into a hexagonal grid structure of all the contributors
Or in honeycomb like structure

Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅

By merging this pull request 🧑💻
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

@Rakesh9100 please review this pr and requested to merge this pr under SWOC'24

Pls resolve the conflicts @Avdhesh-Varshney

@Rakesh9100 please again review this pr, conflicts are resolved!


how can i display the value of a variable in the ionicToast ?

var secondMethod = function(someStuff) {
var len = someStuff.length;
ionicToast.show('Updating number of values  {{len}}  in the database','middle', false, 1000);

Did you try ?
var len = someStuff.length;
ionicToast.show('Updating number of values' + len + 'in the database','middle', false, 1000);```

It's done thanks
Best Regards,
Jay

On Mar 1, 2017, at 11:51 PM, Sanket Tajane<EMAIL_ADDRESS>wrote:
Did you try ?
var len = someStuff.length;
ionicToast.show('Updating number of values' + len + 'in the database','middle', false, 1000);```
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


bug: unable to signInWithCredential using plugin with angular fire

Plugin version: ^0.3.11
Platform(s): iOS
Current behavior: At a loss as to what's going on. Google sign in is successful and giving a result with an idToken, but calling this.afAuth.signInWithCredential never resolves. I'm not sure if I'm passing a bad object or what. I'm using this plugin with firebase and angular fire:
"@angular/fire": "^7.1.1",
"@robingenz/capacitor-firebase-authentication": "^0.3.11",
"firebase": "^9.5.0",

Expected behavior: signInWithCredential resolves
Steps to reproduce:
    const result = await FirebaseAuthentication.signInWithGoogle();
    console.log('[login] signed in', result);
    const credential = GoogleAuthProvider.credential(result.credential?.idToken);

    this.afAuth.signInWithCredential(credential).then(uc => {
      console.log('[login] success: ', uc);
    }, err => {
      console.log('[login] error: ', err);
    }).catch(err => console.log('[login] cred caught error', err));

Other information:
Possibly not a bug with this plugin, but really not sure what's going on here. Found some similar issues googling around to no resolve and hoping someone else has ideas.
Capacitor doctor:
💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 3.3.2
  @capacitor/core: 3.3.2
  @capacitor/android: 3.3.2
  @capacitor/ios: 3.3.2

Installed Dependencies:

  @capacitor/cli: 3.2.5
  @capacitor/core: 3.2.5
  @capacitor/android: 3.2.5
  @capacitor/ios: 3.2.5

[success] iOS looking great! 👌
[success] Android looking great! 👌

Hi @mpkasp,
thank you for your request and for filling out the issue template.
This issue seems like a duplicate of #78. For this reason, I am closing this Issue.
This was apparently the solution: https://github.com/robingenz/capacitor-firebase-authentication/issues/78#issuecomment-924055336
Let me know if that helps you.

Ok, dove a bit deeper & it looked like the difference of using Angular Fire may be the culprit because I tore it out and now that I'm using the js firebase SDK directly everything seems to be working now.
Hopefully this helps someone else.

Thank you for this update.
https://github.com/angular/angularfire/issues/2979#issuecomment-940910213 shows how this works with Angular Fire.

Thanks, I fought with that briefly to no avail and ended up just pulling out angular fire - wasn't too bad fortunately due to abstraction :)


rotate each sticker to a fixed angle

rotate each sticker to a fixed angle
how can we rotate individual sticker to a fixed angle say 90 degree or 180 degree
stickerView.zoomAndRotateCurrentSticker();
and
stickerView.zoomAndRotateSticker();
require motion event
how can we just pass an angle to the method to rotate the stickers

That is not possible in this version.
you have to identify matrix of current sticker then after apply your angle in that matrix and set matrix to that sticker.
this is the only way to rotate sticker.


Feature request: allow multiple paths for packageDefaultDependenciesDirectory

I can currently set the location of "node_modules" like this:
# user settings
{
  ...
  "solidity.packageDefaultDependenciesDirectory": "node_modules"
  ...
}

The structure of my repo looks like this:

root

packages

package1

contracts

package2

contracts

Since I'm using yarn workspaces, most of my third-party contracts are cached at the root. vscode-solidity has no trouble with those contracts.
However, sometimes I have to use the nohoist feature, which moves the contracts down below in "package1", "package2", etc. When that happens, I get this error:
Source<EMAIL_ADDRESS>not found; File import callback not supported

This could be solved by allowing multiple (glob) paths in the packageDefaultDependenciesDirectory user setting. Example:
# user settings
{
  ...
  "solidity.packageDefaultDependenciesDirectories": [
    "node_modules",
    "packages/package1/node_modules",
    "packages/package2/node_modules"
  ]
  ...
}

Hi @PaulRBerg,
Obviously order of preference is important.. and you could end up using dappsys libraries with zeppelin. I will do some experimentation and see how it goes.

Thank you @juanfranblanco 😊

Hi @juanfranblanco , just my thoughts on this: Truffle resolves the import dependencies as it should be, how hard is to copy the module resolution mechanism from there?
This issue is apparently recurrent in time (#31) the solution to add a packageDefaultDependenciesDirectory just solves the problem partially.
In my opinion a consistent solution should be using the same resolution system that truffle or any other linter uses to resolve the imports in the target file
Or as @PaulRBerg proposes, an array of paths, but that will still be too much constrained to specific projects...
Another solution would be to allow using globs in the path, that would be a more generic and valid solution as well.
The main issue is that nowadays mono-repo project structures are quite common, and those repos normally have a set of dependencies installed directly into the root node_modules and other set of deps eventually installed into local node_modules subfolders for nested packages. Truffle is handling this situation correctly, so the key should be there.
I tried to struggle and change some code in the extension myself, should it be modified into initialiseProject function from projectService.ts ? I would like to help with this but I am not very familiar with this project structure and code.

The paths need to support also the DappHub / Dappsys structure as used by Maker, so the multiple path array could solve the problem. https://github.com/dapphub

Although as we have seen in DappSys, we have a path + contractFolder, hence there are two settings. So it is going to need an array of these objects containing both values.
Other thought is that imports will need to be resolved before hand, ie do they exists before rewriting them.
Many years ago Christian (solidity) and I discuss the pattern. Which mainly for Libraries the import does not start with any ".", this indicates that these need to be resolved using the library mechanism.

Is this resolved yet? My imports are all flagging as not found, despite existing and compiling, resulting not linting or other error detection (because this error is a show stopper for processing the rest of the file).

Truffle resolves the import dependencies as it should be, how hard is to copy the module resolution mechanism from there?

Truffle's path resolver is actually pretty modular and published as a separate npm package:

https://www.npmjs.com/package/@truffle/resolver
https://github.com/trufflesuite/truffle/tree/develop/packages/resolver

Maybe it would be possible to just use it as a dependency?
I think it might even accomodate the dappsys use case. For example the support for npm is just one of resolver's modules. It should be possible to write one for handling the lib/ directory too.

@cameel It will be much easier to extend it to use array paths for dependencies than adding a dependency to truffle. As usual making sure that it does not break current deployments.

Edit: And yes I have not got around to do it, as most people just use node_modules as the main dependency folder.

Yeah, agreed on that, a path list is definitely simpler and easier to maintain than a full-blown resolver. The downside though is that with some less common project layouts (like node_modules not at the root or not using node_modules at all) some people seem confused about how to configure the extension. Using a ready-made resolver would help with that, but of course at the additional cost of having to manage the dependency. Looks like you're thinking about introducing a project file instead (https://github.com/juanfranblanco/vscode-solidity/issues/51#issuecomment-851175360), preferably in a format shared with other tools, and I think that would be a great solution too.
Incidentally, we'll soon be adding a similar feature in the Solidity compiler and we went for a path list solution too: https://github.com/ethereum/solidity/issues/11409. In our case it's motivated by not wanting to make too many assumptions about how projects are structured so there won't even be any defaults other than the working directory. The compiler itself should be agnostic about that.
BTW, for anyone wondering about this, the compiler feature is only for command-line usage with an import callback so unfortunately it will not be of any help here - this extension uses Standard JSON input without a callback.

most people just use node_modules as the main dependency folder.

Just wanted to add some nuance here since I've been digging into this exact topic recently :) That's generally true but only because the ecosystem is close to a monoculture now in that regard. People use almost exclusively JS-based tools (i.e Truffle or Hardhat) but there are also some less popular tools that do not rely on npm and thus do not use node_modules. For example Brownie installs packages globally, in ~/.brownie/packages while dapp-tools relies on symlinks within project root. Even with Truffle a single node_modules located at the project root is not universal. You can have a global node_modules or even use both. You can also install packages from EthPM or even import interfaces generated automatically from JSON files with abi-to-sol. node_modules/ is a reasonable default right now but I hope that it does not start being treated as a universal standard. That would be a significant hurdle for non-JS frameworks.

@kerloom for this you can use remappings

@kerloom there is also now specific remapping settings for unix / windows so these can be shared globally in a specific location, working directory


Add font and background

Hi looks nice :) However you seem to have committed some autogenerated files? If you have time can you update the pull request without the files and also fix the merge conflict that occured because we merged an earlier pull request ;)


Saving the PPT as PDF?

Hi @gitbrent ,
Is there a way i can save the PPT as PDF?

Hi @phavanagi ,
Thanks for the question.
The library generates lots of XML, then exports it (PPTX file, stream, etc.), so i'm not aware of an easy way to convert that to PDF off-hand...

Thanks @gitbrent , if you come to know of any way, kindly let me know.

Will do.

@phavanagi @gitbrent Were you able to find a way to save the PPT as PDF?

+1 for this feature or workaround.

+1 for this feature

+1 for this feature

Appreciate all the +1 comments, but this library is designed to create PowerPoints, not PDFs...
If anyone finds a way to bolt on jsPDF or something, please let us know, but PDF functionality will not be included natively as its way outside the scope of the library.


Send-payment command is holding and doesn't output any payment ID

After executing the following command:
coda client send-payment -amount 10 -fee 0.1 -receiver $RECEIVER -sender $SENDER

The command just stays on hold and doesn't output any payment ID.
Git SHA-1: [DIRTY]757342b6cef510f13cb5ad2fbad97518d6df45df

I have the same problem!

@gnosed or @jnuno98:
If either of you are still able to recreate this bug, it would be really great if you can recreate this condition, let your node run for a few seconds, and then run coda advanced export-logs and attach the tar file it generates to this issue. I'm trying to recreate this locally, but so far I haven't been able to get into the state where the command does not return. With the logs, I may be able to figure out what is going on internally in your daemons.
Thanks in advance.

I will do it tomorrow morning and send it to you.
London timezone
On Thu, 19 Nov 2020, 23:54 Nathan Holland<EMAIL_ADDRESS>wrote:

@gnosed https://github.com/gnosed or @jnuno98
https://github.com/jnuno98:
If either of you are still able to recreate this bug, it would be really
great if you can recreate this condition, let your node run for a few
seconds, and then run coda advanced export-logs and attach the tar file
it generates to this issue. I'm trying to recreate this locally, but so far
I haven't been able to get into the state where the command does not
return. With the logs, I may be able to figure out what is going on
internally in your daemons.
Thanks in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MinaProtocol/mina/issues/6764#issuecomment-730710547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYJBOAYGNH44ZPG2MQB4VLSQWV3RANCNFSM4T3FC3QA
.

I think this is the likely culprit https://github.com/MinaProtocol/mina/blob/develop/src/lib/network_pool/network_pool_base.ml#L106.
If this pipe is already full when you submit your transaction, the pipe would drop the transaction (as well as the callback that the client is listening to for transaction status, thus the hang). Will need to think on the best way to resolve this, as making this pipe crash or sync on overwrites seems dangerous as well. We may be able to do something smarter for internally submitted transactions at least, giving them some priority if the network is over saturated with transaction broadcasts.

My node crashed in between and didn't output any crash report  -_- but this is another isssue
@nholland94 No way, to reproduce the bug.
I tried again, now the command is holding for some minutes and dispatches the payment correctly.
It is certainly due to the saturated network?

that command coda advanced export-logs doesn't work.
I've made a new transactions and it just doesn't do anything after 15 minutes...
Also, my node is running for 9 hours and is still in "catchup"
Global number of accounts:       1029 Block height:                    2 Max observed block length:       324 Local uptime:                    9h58m50s Ledger Merkle root:              jwbsTYmyYdNkCbZ5n31bwXFsFQtrE5GCwahayT879TFLV9QbqtL Protocol state hash:             3NKvH5ETQXZDaVbCFiYPzqcSNaWygADLnLRFnvFAsonBEvAKA3X2 Chain id:                        ef95774fb2ed657da61bfc40a8a148a9c9a202476b539aaf915e6cd81d1ef268 Git SHA-1:                       [DIRTY]757342b6cef510f13cb5ad2fbad97518d6df45df Configuration directory:         /root/.coda-config Peers:                           36 (<IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:10507 5. 188.159.227:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:10001 <IP_ADDRESS>:8302  <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:10503 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302  <IP_ADDRESS>:10001 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 195.20 1.82.50:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 108.61. 217.20:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 <IP_ADDRESS>:8302 168.119.2 45.252:8302 <IP_ADDRESS>:10401) User_commands sent:              0 SNARK worker:                    None SNARK work fee:                  25000000 Sync status:                     Catchup Block producers running:         1 (B62qkGWTdjfFP4PmHpp5EjNgZXXJrDxH3t2B5rdYbSAeS1k5au8ZjKK) Best tip consensus time:         epoch=0, slot=915 Next block will be produced in:  in 1.053d Consensus time now:              epoch=0, slot=1052 Consensus mechanism:             proof_of_stake Consensus configuration:                  Delta:                     0         k:                         290         Slots per epoch:           7140         Slot duration:             3m         Epoch duration:            14d21h         Genesis state timestamp:   2020-11-18 07:11:20.000000Z         Acceptable network delay:  3m

#6852 being merged should mitigate this issue. I'm logging #6900 as a followup to actually prioritize locally submitted txns, but with #6852, the cli should no longer hang indefinitely, and it should give feedback to the user about the issue. Closing this for now, please log a new issue if this occurs again in the next release we do.


Athena group

This pull request implements a simple utility for working with Athena project files in Larch (as library, not CLI), mainly targeted to Jupyter users, as recent requests (#264, and Ifeffit mailing list). Here what is introduced:

Added HTML representation to Group showing attributes and types.
Added AthenaGroup, a Group object exposing the  groups attribute to users (instead of the private _athena_groups dictionary). It has an HTML representation for showing the groups.
A sel flag (0/1) is introduced as helper for indicating if a group is selected or not. It result useful for those users who want to loop over the groups.`
The selection flag is shown in the HTML representation when  AthenaGroup().show_sel = True (default is False).
Added a Jupyter notebook UI for renaming or selecting groups in an AthenaGroup (requires ipywidgets).
Added an example of notebook showing the usage.

@newville feel free to comment/modify or merge if you like it.

@maurov  I'm OK with the _repr_html_ method.
I'm less sure about the IPython widgets, especially about them being here.   Maybe there should be a separate folder where the ipython widgets should be, with a dedicated "open Athena Project and select/rename datasets"  in ipython/jupyter?

@newville, the Jupyter UI for editing the name and selection of groups is removed now (PR description updated). I may create a separate module with a Jupyter UI in the future.
I have kept the sel attribute as helper for the users who want to loop over the groups, but it is not shown by default.

@maurov  Thanks!  I think the "sel" flag is a fine idea.    I'll look into why this is failing tests (I suspect unrelated to the PR itself) and then hope to merge within a few days, that is if you're happy with it and no one else raises any objections.

@newville what about merging and closing this request?

@maurov  ok, thanks for the reminder, merging now.


Implement validation class-validator

For class validation @pleerock has implemented an awesome typescript package - https://github.com/pleerock/class-validator
Checklist

[x] Install class-validator
[ ] Implement default validations on the ResourceController
[ ] Create @ValidatePayload(m:ModelStatic, options?: ValidationOptions) middleware decorator
[ ] Verify that the @Validate custom decorator works with our DI. (https://github.com/pleerock/class-validator#using-service-container)
[ ] Consider extending class-validator to handle async validation

before extending class validator make sure you aren't implementing a common-scenario behaviour that can be included in class validator itself.

Yea sure - in this case I'm remapping the internal exception to my own exceptions that extends an HttpRestException, which has a few extra methods specific to my framework.

On 21 Jun 2016, at 3:47 PM, Umed Khudoiberdiev<EMAIL_ADDRESS>wrote:
before extending class validator make sure you aren't implementing a common-scenario behaviour that can be included in class validator itself.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/ubiquits/ubiquits/issues/72#issuecomment-227463387, or mute the thread https://github.com/notifications/unsubscribe/AAsCaRj15EVAHw_huQiyxQ8wq_6zg1fuks5qN_l_gaJpZM4I6ja7.

@pleerock yea I'll fork & PR if its a feature that's not dependent on this platform.


Do not strip content-encoding header, fixes gh-3059

According to https://tools.ietf.org/html/draft-ietf-httpbis-p1-messaging-14#section-7.1.3 (mentioned by @spencergibb at this comment) header Content-Encoding should not be stripped.
Fixes #3059 and addresses point mentioned on #3008

@mdiniz Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@mdiniz Thank you for signing the Contributor License Agreement!

I think we should also take care of the content-length header as well, see https://github.com/spring-cloud/spring-cloud-netflix/issues/3008#issuecomment-403938914

@ryanjbaxter I'm not sure this PR should deal with Content-Length as well.
It's clear that Transfer-Encoding should always be removed, as it's a hop-by-hop header (it already does that). Content-Length should never be removed, as it's not a hop-by-hop header.
However, just excluding Content-Length from the method isIncludedHeader (as I did to Content-Encoding) throws a number of errors on other tests (Failures: 36, Errors: 13).
I would rather merge this as it is, since it's very focused on Content-Encoding, and then address Content-Length and all these test fixes on a separate PR a little later.

It seems there is more logic involved with Content-Lenth
https://github.com/spring-cloud/spring-cloud-netflix/issues/3008#issuecomment-402439995


Coder: expanded method coders are without expander triangles

Due to the recent changes in #3626, there are no expanders in expanded method coders without self-objects:


Fix #54

I guess the performance lost is due to allocating way bigger buffer? It might be best to subtract the offset as well?

It looks like that's the cause of the performance issue, but should be fixed in https://github.com/christopher-hesse/blobfile/commit/21d577004a706cc1b19d6edaa308109d086d6d5f thanks for the PR!  I will fix the buffer size here to use the minimum in a separate commit (though it should have only a very minor impact on performance now)


Missing example of blocking data for Gazetteer or record linking models.

Could any one provide an example of how to use Gazetteer og Record linking with large datasets? Especially the part about Blocking data.

Duplicate of #23


Run tests on each commit

Add action job to run tests with BDDSM to check commit status. When any test failed build should fail with red status

@sergio-fry can I do this?

@fartem we have already a PR #34 . Could you approve it?


[executor] compare local compute result with chunk before comparing w…

…ith the final ledger_info
Motivation
there's a problem in execute_and_commit_chunk
let's say we're at version 100, receive a sync request to 600, first chunk comes with TransactionListWithProof[101-350] with LedgerInfo[version:600],
we verify the TransactionListWithProof matches LedgerInfo[version:600]
execute txns [101-350]
commit txns [101-350]
But we never verify the local execute result matches TransactionListWithProof
This PR fixes the problem to find out the unmatched results before reaching the final ledger info to be committed.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
CI

I know it's probably hard, but is it possible to have a test so that someone won't delete those code again?

I'll see whether test can be added.

@zekun000 I don't think it is necessary to match the local accumulator match the proof and it is verify complicated. Since we matched every txn_info, verifying the state_tree is matched, it is pretty enough to avoid fork.

no, as we saw from the case yesterday, it's not enough.
txn 1-4 are different but since txn 5, all the executed txn info matches both proof the local result but it's still a fork.

@zekun000 discussed offline. Will add that.

@bors-libra r+

:pushpin: Commit d9aa591 has been approved by lightmark

:hourglass: Testing commit d9aa591ba2386445849e50b6b4c315e5047be861 with merge 3dc457eff5693b9e580d99818ffda5c67249e5d1...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: lightmark
Pushing 3dc457eff5693b9e580d99818ffda5c67249e5d1 to master...


Support the Compass Service

I think this is a great dev kit for your product, but support for determining direction doesn't exist! Native pebble app can access a compass service that provides this information. Pebble.js should too.
The forums have their theories to explain why support doesn't exist, but I am opening this issue to get an answer.
This is just an enhancement request.

Thanks for posting! It's true, accel and compass are better suited as C projects, but rest assured I will add support anyway.
The real reason is that there's only myself behind pebble.js, and Thomas to make it more developer friendly, partly because of the warning at the very top of the documentation. The API makes things very easy, but at a great cost. Developing pebble.js means accepting the implications of that warning. Regardless, I'm happy to take feature requests, and making a Github issue is the best way to log one as you've done. Development has been slower since I've been busy as of late -- maybe the truest reason -- but it's not at a grinding halt!
I will look into adding a Compass API after writing the documentation for the Wakeup API, another API that was previously missing.

Hey thanks for the quick response! We are going to write our app in C now. Good luck with this project!

I would still very much love if the Compass API could be implemented for PebbleJS! It would be a sweet enhancement for the app I'm currently working on


DOCSP-4379 Validate and clarify intro in README

Ran through the steps in README to validate their current accuracy
Some improvements/clarifications made

Staged:
https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-4379-readme/sdk/swift/index.html

Linting passed, evg otherwise broken until Xcode 10.2 installed. Merging.


typo in documentation INSTALLING.md

$HARDWARE -> this refers to the hardware-specific configuration (disks, kernel, boot, etc). This loads the hardware-specific configuration from /hosts/$HOST/default.nix
should be?
$HARDWARE -> this refers to the hardware-specific configuration (disks, kernel, boot, etc). This loads the hardware-specific configuration from /hardware/$HARDWARE/default.nix
thanks for your config by the way!

I completely missed that! Thanks :)


a long awaited pull request to add actions to the package without code duplication

i wrote little explanation and upload a proof of concept mov file
refrences issues: #40 #18

sorry for the formatting issues

Thanks for the PR! Will inspect further
But at first glance I see you've published Nova source code.
I believe that would violate the terms & conditions

Ah OK sorry about that didn't know that's wrong,  should I close the pull request?

@SerjoA yeah sorry..  if you want to brainstorm another approach im on discord or even the issues
I appreciate the attempt :)

the problem is, the way its built right now, its either duplicate action login inside your package or touch nova code
because the refresh of action events happens in nova code, and i already saw previously, i had 3 options, all 3 are bad, and all 3 involve some code duplication and 2 of them is touching nova source code


[e2e test] change kindest version to v1.26.4

[e2e test] change kindest version to v1.26.4
What type of PR is this?
/kind-cleanup
What this PR does / why we need it:
for update kindest node version
Which issue(s) this PR fixes:
change log:
1 e2e.sh KIND_VERSION change to  v1.26.4
2 offline-e2e.sh KIND_VERSION change to  v1.26.4
3 util::install_kind $kind_version=v0.19.0
https://github.com/kubernetes-sigs/kind/releases

Special notes for your reviewer:
checked:
e2e-schedule pass
auto-offline install kubean success in kind cluster

/lgtm

/lgtm


[opentelemetry-collector] Fix cluster role for k8sattributes

Fix https://github.com/open-telemetry/opentelemetry-helm-charts/issues/800
The issue is basically new version of k8sattribute processor doesn't depend on parsing names using regex, but actually asks k8s for Replicasets to see owner references.

@povilasv sweet, can you also get the k8sattributeprocessor's readme update to reflect the new RBAC requirements?


Fix circular dependencies

Circular dependencies left me with a nasty bug I discovered in #536 (why it's taken me so long to get tests passing in that PR). It took forever to figure out that this actually was a circular dependency issue. Modules were seemingly imported multiple times and certain exported values within the module were undefined. I refactored the api code a bit to not need circular dependencies any more.
While I was trying to figure out what was going on, I also upgraded all packages in case there was an issue in babel or sth. I upgraded the linter during that time and started fixing linter issues - so that's why there are a few random changes. I'll be submitting another PR soon with all packages upgraded and the full linter changes (some 300+ changes or sth).
This PR is a WIP because I haven't yet tested out how the code works for real - I just finally got tests passing. However, I recommend this PR get merged as soon as possible because the bugs I saw in #536 could show up for anyone at any time because there are circular dependencies in our code right now.
Also, there's some weird stuff going on locally where this test keeps failing:
) renders the projected time of the first backup when its window is < $NOW
     linodes/components/Linode renderBackupStatus
12 10 2016 22:31:00.533:WARN [reporter]: SourceMap position not found for trace: undefined
     expected 'In ~an hour' to equal 'In ~a day'
AssertionError@webpack:///~/assertion-error/index.js:74:0 <- test/index.js:303:25
assert@webpack:///~/chai/lib/chai/assertion.js:107:0 <- test/index.js:4635:32
assertEqual@webpack:///~/chai/lib/chai/core/assertions.js:487:0 <- test/index.js:5152:19
webpack:///~/chai/lib/chai/utils/addMethod.js:41:0 <- test/index.js:4222:31
test/index.js:104379:9517

I do not understand - it even fails on master (with no changes) locally here. @na3d @abemassry @briansteffens Can anyone corroborate?

Coverage increased (+0.008%) to 89.039% when pulling 2804837a4171c6140ad169485fe1e0f22203f104 on eatonphil:fix-circular-dependencies into d284e64d2dd82b355732ee35589bb24f6aa1f505 on linode:master.

Coverage increased (+0.008%) to 89.039% when pulling 63f2dc546497f44444121a2b5a0abe7b65a1fa54 on eatonphil:fix-circular-dependencies into d284e64d2dd82b355732ee35589bb24f6aa1f505 on linode:master.

Things look good to me from a brief run-though of the actual site.

Thanks!


Fix building url for imported from azure images

Let's add this commit https://github.com/heartexlabs/label-studio/commit/fe32a796126d391a650e8d973be4495ed26913e0 and run test for the current fix


Inverse dmxInput

I had an issue where some equipment puts out inverted DMX. While flipping the A and B cables is an easy fix, i found this annoying to do and wanted a software solution. So i made one :)

Bump @jostlowe

Sorry for the late handling of this issue. Nice work :)


[#2135, #2136] Add multiple inline editors to items & display chat description

Adds multiple inline editors into items to allow editing normal description, unidentified description, and chat text. When the edit button is clicked the editor replaces the whole tab giving plenty of space to write.
https://github.com/foundryvtt/dnd5e/assets/19979839/09eb8de2-5b2b-409c-830c-5b9d3e559e50
This also will display the chat text in created chat messages rather than the default description if it is provided.
Closes #2135
Closes #2136

My artistic skills are offensive, but hear me out. Rather than elongating the description field possibly thrice over vertically, can we split it horizontally?

@Fyorl I merged your accordion changes in, with the collapseOthers set to false based on popular opinion. I also added a transition to margin-bottom to avoid that little jump that was happening :).


RuntimeError: mat1 and mat2 shapes cannot be multiplied (3584x7 and 25088x4096)

I am trying two different images and I am getting this error, this is the size of the two images after loading them:
torch.Size([1, 3, 400, 444])
torch.Size([1, 3, 400, 444])

The error message shows the dimension shapes of the two matrices can't be multiplied. The matrix multiplication requires the shapes to be (m,n) and (n, p),


AND-234 Made Continue button sticky so the traveller switch cannot be…

… missed
Description
Screenshots 📸
Show/Hide content

How Has This Been Tested? 👨🔬
See the screenshot
What Has Not Been Tested? 🙅🏻♂
Checklist ✅

[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have checked all visual changes in both light and dark mode.

But now the button is not placed on the bottom as it is designed for regular screens with enough space.


Automate the installation of required packages

It would be nice to automate the installation of required packages when developers render the book locally. I have added a few lines of code within the NEFSC yellowtail example to automatically install missing packages.
However, duplicating this code for each case study may be redundant. Maybe we can explore an alternative solution to include a DESCRIPTION file and utilize the {attachment} package to install missing dependencies. See examples here.

thanks @Bai-Li-NOAA ! I had the same thought about not duplicating the code - I tried to put it in the index file but I am not sure of the order of compilation of the bookdown. I was thinking of turning it into a package, but if just adding a DESCRIPTION file lets us manage without the package step that seems even better!

Great, I will explore the DESCRIPTION approach and provide updates on my progress here.


proposal: move attributes nodes to html/attribute

Tbh the Attr and El suffixes bother me alot. What do you think about moving attributes to /html/attribute package and removing the suffixes, You can then just use a regular import and use a.MyAttribute I did not look into this much as I only just found this library but it's something which stood out and annoyed me...

I had that originally. Then you can't dot-import both packages unfortunately, because you'll have the name clash again.
(And it would be a big breaking change.)

Dot-imports shouldn't be used anyway although I'm sure many out there like them (Perhaps yourself?). It's an opinionated subject, just like my dislike for the El and Attr suffixes. It sounds like you don't want to make this change (back) so I will close this issue due to incompatible opinion.


Rename NthValue::{first_value,last_value,nth_value} to satisfy clippy in Rust 1.55

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/985
Rationale for this change
CI should be clean
What changes are included in this PR?
I tried to port the changes from  @Igosuki in #910  to minimize merge conflicts
Are there any user-facing changes?
function names change in NthValue

I am going to merge this in to get CI green on master again; The actual change has already been discussed in the context of https://github.com/apache/arrow-datafusion/pull/910#discussion_r697964506 so I think there is consensus


Speedup metadata tests

Fixes one item from #1029
Splits the metadata template tests between DB read only tests and DB read write tests (so it saves time since it does not have to rebuild the database in each test).
I just wanted to move tests around, but I fixed a couple of small issues:

MetadataTemplate no longer has a create function so I removed the test (it was a leftover)
to_dataframe is not a classmethod so it does not need the _check_subclass class and by extension it does not need a test on MetadataTemplate
Delete did not had the call to _check_subclass, so I added it and a test on MetadataTemplate

Since this is a performance PR, some times:
Now:
$ nosetests qiita_db/metadata_template/test/
............../Users/jose/qiime_software/QiiTa/qiita_db/metadata_template/util.py:103: QiitaDBWarning: Sample names were already prefixed with the study id.
  QiitaDBWarning)
../Users/jose/qiime_software/QiiTa/qiita_db/metadata_template/util.py:103: QiitaDBWarning: Sample names were already prefixed with the study id.
  QiitaDBWarning)
....................................................................................................................................................
----------------------------------------------------------------------
Ran 164 tests in 61.491s

OK

Before:
$ nosetests qiita_db/metadata_template/test/
......................................./Users/jose/qiime_software/QiiTa/qiita_db/metadata_template/util.py:103: QiitaDBWarning: Sample names were already prefixed with the study id.
  QiitaDBWarning)
../Users/jose/qiime_software/QiiTa/qiita_db/metadata_template/util.py:103: QiitaDBWarning: Sample names were already prefixed with the study id.
  QiitaDBWarning)
............................................................................................................................
----------------------------------------------------------------------
Ran 165 tests in 163.808s

OK

Any future PR on the metadata template depends on this one, since this reduces developer time (less time on tests, more time coding), so a fast review/merge is appreciated.

:+1: if tests pass

Coverage decreased (-0.02%) to 79.22% when pulling d900e7b70f03981e35e62141d7d1455c988d2b8e on josenavas:speedup-metadata-tests into 0a047797cea88567d88ffda259465235c1aa916c on biocore:master.

:+1: looks really good.
Thanks for adding such nice description to the PR, as a reviewer it makes it a lot easier to know upfront what are the specifics that you'll be looking at.

Done, thanks!
Yeah, I think if we are all starting doing this, specially in "complex" PR, it will facilitate the reviewer work.

:+1:, excellent, ready to be merged as soon as tests complete.

Coverage decreased (-0.02%) to 79.22% when pulling 0e6c86d6bc0615ceb9f206e5731bc1065b777fcc on josenavas:speedup-metadata-tests into 0a047797cea88567d88ffda259465235c1aa916c on biocore:master.


Add MonitorCustomConfig support to Smart Agent Receiver

These changes address the first remaining item detailed in https://github.com/signalfx/splunk-otel-collector/pull/53#issue-549208453.  In most cases they allow users to c/p SA monitor configs to corresponding smartagent receiver config blocks, which will be later used by the receiver to invoke the applicable monitor factories.  In cases where config tag* values are maps with case sensitive strings, this implementation does not correctly translate since the Collector config is based on viper, which destroys all record of tag key cases.  A translation approach for these cases will be implemented when necessary, though the majority of use cases are not planned to be supported by the Smart Agent Receiver (e.g. in-monitor metric transformations).
At a high level this implementation works similarly to the Smart Agent's dynamic config functionality, and is based on the reflection package to create and populate custom monitor config content from the provided yaml.  It uses a custom viper unmarshaller and the central SA monitor registration maps to meet this end.
Also including required go modules replace directives to import the agent and a required windows test job environment correction.

@jrcamp mind giving this a look w/ your SA expertise when possible?

@jrcamp mind giving this a look w/ your SA expertise when possible?


Pixel coordinates to geo coordinates

…el coordinates into geo coordinates based on the geodata extracted from geotiff image.