[Feature]: Refactor Curp State

Description about the feature
Currently, the state of our curp server is filled with many things. It is very maintainable since we will soon add persistent support to the project. And a big lock of state is not efficient either. We should refactor curp's state now.
In addition, we need to add index to our log entry since it will be utilized when snapshot is enabled.
Approach
We can divide the state into following sections:

PersistedState that needs to be persisted on disk: term, voted_for.
VolatileState that stores only in memory: commitIndex, lastApplied, leader_id, next_index, match_index, and timeout utils.
Logs that needs to be persisted on disk.

Other structures that exist in current State are all shared references. They can be moved out into a new structure called Shared.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Releated to #73

Closed in favor of #169.


Check push reply ends in a NUL byte

We blindly cut off the last byte
https://github.com/robur-coop/miragevpn/blob/8d701302114b41fe1f7ac43e0d3da0ed01fe6d9a/src/engine.ml#L581-L587
Thinking about it for a bit we should maybe use Cc_message for push replies as well? And maybe the server can send an EXIT message before we receive a push reply and we don't handle that.

Originally reported in https://github.com/robur-coop/miragevpn/pull/279#discussion_r1778294852


Strengthen address space pointer checks

Add negative tests for address space casts.

Formatting violations should be ignored here.

Reviewing

Reviewing


Deep create request fails with error

This issue is just a place holder for an issue created in the internal repo.

Documentation was improved.

Documentation was improved.

https://sap.github.io/cloud-sdk/docs/js/features/odata/use-odata-v4-type-safe-client-for-javascript-typescript#deep-create

https://sap.github.io/cloud-sdk/docs/js/features/odata/use-odata-v4-type-safe-client-for-javascript-typescript#deep-create


Add check adk_key is defined in game.project

Just update readme about sdk_key_android - no way to validate in runtime (build fails without this key), no way to add Defold Editor prebuild-hook in extension (available in project only)


modefied the pp build for ckpt adaptation

This pr is same as #795 .

I will rerun the CI this night.

@Gy-Lu just run these failed case locally and post a snapshot here. We will merge you PR.

@Gy-Lu just run these failed case locally and post a snapshot here. We will merge you PR.

OK

@Gy-Lu did you check the unit tests of the failed cases?

@Gy-Lu did you check the unit tests of the failed cases?

Yes. But I think I should do more tests to ensure it works well.
I will turn this pr into draft.

@feifeibear @ver217
Hi, I have updated the PP builder for ckpt.
And fixed the bug when num_chunk=1 with interleaved PP.
Here is the unit test.


fix(sdk): fix attach in offline mode and unify offline and online mode during init

…xisting run (#5144)
Fixes WB-NNNN
Fixes #NNNN
Description
What does the PR do?
TODO:

[x] unify deliver_run and publish_run
[x] move attach handling from sender to handler
[x] unify offline_run and online_run in the run class

Testing
How was this PR tested?
Checklist

[ ] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Ensure PR title compliance with the conventional commits standards

/suggest-title


Cannot find idl file if it's in non-related folder

I have a bit strange project struct... :)
For example, I have:

/root

/mylib

/source

/mylib.idl

/project

CMakeLists.txt with add_idl

So I use add_idl(mylibIDL ${CMAKE_SOURCE_DIR}/mylib/source/mylib.idl).
Now, look at
${CMAKE_SOURCE_DIR}/mylib/source/mylib.idl
function(add_idl _target _idlfile) and then at
https://github.com/apriorit/FindIDL/blob/master/cmake/FindIDL.cmake#L19
COMMAND midl.exe ARGS /${MIDL_ARCH} /env ${MIDL_ARCH} /nologo ${CMAKE_CURRENT_LIST_DIR}/${_idlfile}
If we expand ${_idlfile} here it will become
COMMAND midl.exe ARGS /${MIDL_ARCH} /env ${MIDL_ARCH} /nologo ${CMAKE_CURRENT_LIST_DIR}/${CMAKE_SOURCE_DIR}/mylib/source/mylib.idl
Now we have a problem :)

Thanks for the report! We'll check it.


setTextVisibility on shaka.extern.TextDisplayer

In the process of implementing a custom rendering of subtitles I'm implementing my own TextDisplayer.
However, in the implementation of setTextVisibility am I supposed to disable the text track as well by calling player.setTextTrackVisibility or something? Cause I'm getting a bit confused regarding why this function exists at all on the interface. Related concern regarding isTextVisible()... I guess my point is why are these functions required by the interface when shaka-player already supports hiding and showing subtitles by default?
Cause to me append, remove and destroy should be enough for implementing the interface? And if I for whatever reason need to care about the visibility of the subtitles then I could just get that from the internal player state?
I might not have a full understanding of how this works yet so I'm sorry if this question is stupid!

Thanks for that response. Makes stuffs a lot clearer!
I guess I got confused also because seems player.getTextTracks() always seems to return a active == true track. So I thought perhaps I'm responsible for deactivating that track, but then now I saw this piece of code. But I did notice like you said that if I turned off subtitles by calling player.setTextTrackVisibility(false) then they were no longer streamed.

Glad to help! Please reach out in the future if you have more questions :)


Implement support for tlogserver

A tlogserver connects to a storagecluster and takes config simular to the nbdserver.
An nbdserver connects to a tlogserver.
We have decided to run 1 tlogserver per vm, so the tlogserver will run on the same container as the nbdserver for the vm.

verified that tlog server is running ,
but can't verify it works well due to this issue :
https://github.com/zero-os/0-orchestrator/issues/430

error when creating vm with vdisk which has storage cluster and tlog cluster
[Mon19 15:20] - RunStep.py          :84  :j.atyourservice.server         - INFO     - runstep 2: error                   │···········································
[Mon19 15:20] - Run.py              :108 :j.atyourservice.server         - ERROR    - error during execution of step 2 in│···········································
 run cc512292afc24d69ab41ffc0c9717aed                                                                                │···········································
Error of job: tlogserver!vm4 (install):                                                                                │···········································
*TRACEBACK*********************************************************************************                              │···········································
Traceback (most recent call last):                                                                                │···········································
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run                                                │···········································
    result = self.fn(*self.args, **self.kwargs)                                                                          │···········································
  File "/tmp/actions/tlogserver/8266fb56f6911e6c6c2132f23caf3989.py", line 73, in install                                │···········································
    container.node.client.nft.open_port(port)                                                                            │···········································
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 1927, in open_port                   │···········································
    return self._client.json('nft.open_port', args)                                                                      │···········································
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 543, in json                         │···········································
    result = self.sync(command, arguments)                                                                               │···········································
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 533, in sync                         │···········································
    raise RuntimeError('invalid response: %s' % result.state, result)                                                    │···········································
RuntimeError: ('invalid response: ERROR', STATE: ERROR                                                                   │···········································
STDOUT:                                                                                │···········································
                                                                                │···········································
STDERR:                                                                                │···········································
                                                                                │···········································
DATA:                                                                                │···········································
"rule exists"                                                                                │···········································
)                                                                                │···········································

software version
orchestrator : master : b495ca2

blocked on https://github.com/zero-os/0-orchestrator/issues/430

software version
orchestrator : master : 4da49fb6


Why not implement the standard harmonic mean distance calculation as paper said?

I read the code, and see that the distance calculation is not standard harmonic mean distance.
As below, the distance will update only if distance > i / d, this will introduce some difference when test with the example in figure 4 in your paper. By this mean, the distances for 3 node in the figure will be 2, 3, 8/3. While the harmonic mean distances for 3 node in the figure are 3/4, 1, 3/4.

Why did you choose this means?
Is there any problem?
if d != 0 and (distance == -1 or distance > i / d) :
distance = i / d
https://github.com/aflgo/aflgo/blob/d98ad6519717a9f339d2bad5bd2164107afe7297/scripts/distance.py#L55

The paper says AFLGo is using harmonic mean distance which is

But, actually implementation shows

The multiplied number of reachable target functions to increase distance for caller functions.
It makes sense since the caller function would be 'further' from the target location than the callee function, but I think they should mention them since it will affect directing...

In Figure4 the harmonic mean is calculated as  1/(1/2 + 1/2)， but it should be like:

The implementation in code is right （the "n" in numerator）.
Something else in code which is a bit different from the paper, "+1" was added to denominator, maybe is to avoid the div 0.
And the final basic blocks's distance is  the average of each situation, instead of  considering in different situations as Formula 2 in paper. I guess this is to take more situations into consideration, instead of merely the shortest distance.
The line you pointed is to calculate the mininum distance, as there may be several nodes returned from find_nodes().(not sure)


blocks overlaps with the toolbar when it doesn't have any categories.

Expected Behavior
blocks in the workspace should not overlap with the toolbar.
Actual Behavior
blocks in the workspace can overlap with the toolbar when the toolbar doesn't have any categories and empty
Steps to Reproduce

set up a toolbar without any categories and place some blocks in the workspace.
resize the window smaller and notice blocks in the work space now shifts over and overlaps with the empty toolbar.
when the window is resized larger again, the blocks remains overlapped with the toolbar.

Operating System and Browser
Mac OS 10.11.6 chrome 55.0.2883.95

Is this one that maybe you'd want to tag with "help wanted"? This is effecting us and we might have some time to look into it.

Can you attach a screenshot?

Sure @MichaelZawadzki happy to accept a PR on this if it helps you out. As @rachel-fenichel mentioned it would be great to see a screenshot or (better yet) a GIF of the behavior described.

@MichaelZawadzki @ChuckDeng Actually, before you dig into the code I think it would be helpful to better describe the issue. I think @rachel-fenichel and I are still fairly unclear on the behavior you are experiencing.

The issue is quite easy to reproduce on the vertical playground. It occurs only on the "Simple" toolbox and not on the "Categories" toolbox. This can be reproduced on either the vertical playground file inside the project, or even on the hosted version here: https://utils.asun.co/scratch-blocks/tests/vertical_playground.html
The steps are pretty much like Chuck described but let me try to be more detailed:

Load up the vertical playground
Switch over to the "Simple" toolbox (using the dropdown on the left).
Drag any block onto the workspace
Grab right side of the browser window (to enable resize) and drag left to make the browser window really tiny.
Now drag the border back to normal.
Observe that the block now overlaps the toolbox (screenshot below).

We know that you guys are mainly concerned with the "Categories" case, while we care about the "Simple" toolbox case, which is why we thought we could help here.
Chuck was saying to me that the layout logic depends on the "category" toolbox to handle this layout logic. It seems in the case where there are no categories (aka no toolbox defined) this is when the bug occurs. I'm guessing something in Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_ doesn't handle this case properly... but it'll be a dive to figure this out.
Also, as I was typing this up I realized that this is a more general bug around the horizontal scrollbar. So, for reproduction, notice that the horizontal toolbar for the "simple" toolbox is messed up! It doesn't take the flyout into account! This means you don't need to drag the window to reproduce this bug, you can simply drag the bottom scrollbar to get the block to go over the flyout. So the core bug seems to be that the horizontal scrollbar doesn't honor the flyout in the no category "simple" case.
So for this alternative way to get the bug, the steps would be:

Load up the vertical playground
Switch over to the "Simple" toolbox (using the dropdown on the left).
Drag any block onto the workspace
Grab horizontal scrollbar and scroll around to the extreme's.
Observe that the block is allowed to overlap the toolbox. You can easily reach a case that looks like the original screenshot above.

Let me know if you guys have any specific questions or if something is still unclear.

Thanks for the details.
It looks like the flyout has the wrong z-index in the simple (always-open) case.  I've checked and that doesn't happen on upstream blockly.
Fixing that probably is a css change rather than a code change.
The second issue is the horizontal scrollbar in the simple case.  We're aware that it doesn't respect the flyout.  This is because the flyout can change size as the user edits fields on blocks in the flyout, which would lead to repositioning the scrollbar, which would probably trigger a relayout, and so on.  This is a lower priority issue for us; it also exists upstream.


a lib ical depend on just do not suppurt net45

any solution to use ical.net in my net45 project?
thanks

Use v2.


Transactions

We should have all the pieces to get transactions working:

Snapshots achieved by MVCC
Atomicity achieved by Batch

Possible API
let keyspace = TxKeyspace::open(options)?;

let tx = keyspace.tx();
tx.get(key);
tx.insert(newkey, newvalue);
tx.commit()?;

Single-writer transactions will land in 1.1.0


Fix an incorrect autocorrect for FactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method name and first argument are not on same line

Fix: #1442
This PR is following cases where the method name and the first argument are different line are not considered offense.
create(
  :user
)
build(
  :user,
  name: 'foo'
)

This is because the absence of parentheses will result in a syntax error.
create
  :user

build
  :user,
  name: 'foo'

In that case, the following modification would be necessary, and we have chosen not to make it an offense here, since we would have to suppress either offense if there is a length limit in Layout/LineLength, etc.
create :user

build :user,
  name: 'foo'

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

I think this is fine for a bugfix. We can consider the IgnoreMultiline in a separate PR.

@bquorning I take your last comment as an approval.
@ydah Thank you!


Inconsistent API between functionCall and viewFunction.

Describe the bug
Same as title.
To Reproduce
Try viewFunction with syntax like this:
const token = await contractAccount.viewFunction({
	contractId,
	methodName: 'nft_token',
	args: {
		token_id,
	}
})

Expected behavior
Expect them both to accept the POJO syntax e.g. { contractId, methodName, args, ...}
Screenshots

Just going to second this, I hit the same issue. It's killer when your'e trying to figure out what's wrong, you end up rolling the dice and going to the deprecated version.


Add documentation about cert authentication

Waiting to merge until the next release of vsphere. We should then add a note to those properties to document the version at which they were introduced.


Error 500 when starting a compute job

Describe the bug
Error 500 when starting a compute job using ocean.compute.start() function.
To Reproduce
Code structure follow the example
https://github.com/oceanprotocol/ocean.js/blob/feature/example/example/src/commands.ts#L213
Value of the function
start(
'did:op:aB17c494EA9954CBa9C6F7D3C445c890E56eb001',
'0xd88e04dc9cfd637b9c72233a4aa7b6f748d6784f3fbb851c3718bdc6e2d1ad29',
'0xaB17c494EA9954CBa9C6F7D3C445c890E56eb001',
consumerAccount: [Account Object],
'did:op:6004D9FcA374E84Ad60EDeAba8A83ac43038F6Ed',
null,
null,
'1',
'compute',
'0x672a7195173161d335b885422b7694d3af42fdb4085a21e65d36bd1ae7050ca5',
'0x6004D9FcA374E84Ad60EDeAba8A83ac43038F6Ed'
)
Error:

POST | https://provider.data-marketplace.io/api/v1/services/compute?documentId=did:op:aB17c494EA9954CBa9C6F7D3C445c890E56eb001&signature=0x2500363f962c021940f6cc16c0dcadc984cba1edd29d029052f16f51ccc8da7b6259dd9c58dd67d493a0a28d4435394d0dc08621533ec3ab7d41813f3c3935d41c&output={"publishAlgorithmLog":false,"publishOutput":false}&algorithmDid=did:op:6004D9FcA374E84Ad60EDeAba8A83ac43038F6Ed&consumerAddress=0x1aEF750253B4954B42C980D99856d32474B2C3db,0x1aEF750253B4954B42C980D99856d32474B2C3db&transferTxId=0xd88e04dc9cfd637b9c72233a4aa7b6f748d6784f3fbb851c3718bdc6e2d1ad29&algorithmTransferTxId=0x672a7195173161d335b885422b7694d3af42fdb4085a21e65d36bd1ae7050ca5&algorithmDataToken=0x6004D9FcA374E84Ad60EDeAba8A83ac43038F6Ed&serviceId=1&serviceType=compute&dataToken=0xaB17c494EA9954CBa9C6F7D3C445c890E56eb001

the linked example folder and code is a draft not meant for production. We do not support Compute-to-data in its full flow right now and there are so many untested moving parts with it outside of ocean.js so that it would be hard to investigate anything related to this issue here. So closing for now until we officially support Compute-to-data together with v3 components


with f64 values and interactive editing

Describe the bug
Big picture:

I have several input fields for f64 type and combined those are used to compute some value from an equation
I also want to have a button "load example data" which sets values (other than the default values at form startup)

Not sure this is a bug or me using the signals/input typs wrong.
question
Example Input() uses only a f64 and updates itself on changes. This breaks editing, as going from "1.2" (with backspace) rewrites the number to "1" instead of "1.".
Question: Is using signals in a loop a bad thing?
the code
pub fn Input() -> impl IntoView {
    let input_float = create_rw_signal(1.0);
    view! {

input2

Using american f64 float notation type internally and externally. No conversion from , into "." so only use american notation!

Enter: 1.23, then backspace yields 1.2 (which is ok), hit backspace again, yields 1 instead of 1.

Problem: the "." is removed when it should not

        <input data-testid="Input2" type="number" inputmode="decimal" lang="us-US"  on:input=move |ev| {
            let old_value = input_float.get();
            let input: String = event_target_value(&ev);
            info!("input = {}", input);
            match input.parse::<f64>() {
              Ok(v) => {
                if v != old_value {
                  input_float.set(v);
                  info!("input_float = {}", input_float.get());
                }
              },
              Err(e) => info!("{}: zz not parsable", e)
            }
          }
          prop:value={ move || input_float.get() } />

        You selected: { move || input_float.get()
        }

    }
}

I think I understand using european vs. us number formatting. I need to use the browser locale setting, or something similar to this code:
<input data-testid="Input2" type="number" inputmode="decimal" lang="us-US" on:input=move |ev| {
https://stackoverflow.com/questions/13412204/localization-of-input-type-number
I'll update the question to make it shorter now.

The way I typically do this is using a String for the input value, and then a derived signal parsing the value into f64.
let (value, set_value) = create_signal(String::new());
let num: Signal<Option<f64>> = Signal::derive(move || value.with(|value| value.parse().ok()));

Nevermind, I also just came across this issue!
I found this PR for React: https://github.com/facebook/react/pull/7359
In my case I'm going to use uncontrolled inputs to let my browser control the value.

I do not think this is a bug in Leptos. Specifically, when you use prop:value you are saying, "every time input_float changes, set the .value field of the input to the value of input_float".
If I just open up the example and pull the input into the console, input.value = "1.0" sets the text to "1.0", and input.value = 1.0 sets the text to "1".
Using an uncontrolled input (so, not using prop:value) should work, and using a string signal for prop:value should work. But otherwise this is just the browser doing what the browser does.

@tqwewe thanks for pointing out how to modify the  input value directly!
        let input: web_sys::HtmlInputElement = event_target(&ev);
        let value = input.value_as_number();

@gbj thanks for clearifications. i will decouple the f64 value from the prop:value and use a string instead!
i do this now:

on:focus i rewrite the 1.000.000,73 number into 1000000,73 (EU notation) and the user can edit this number. once he is finished the
on:blur converts it into a f64 and also updates the input_element.set_value(xxx) string
on:input i try to parse it into f64 and if successful i update the outgoing signal value

thanks so much!

This is the code I think i'll use:
Internally it uses a String so I can even have incomplete values like: "1,".
When compared to using a float as internal value I had this problem: Say you were editing 1,2 into 1,3 and you would remove the 3 at the end, it would auto-correct into 1 instead of 1, so one would always have to enter ,3 instead of just 3. Hard to explain. But for whoever cares, this is the code I think works nice:
pub fn Input4() -> impl IntoView {
    // float experiments
    let input_string = create_rw_signal(String::new());
    let output_float = create_rw_signal(1.0);
    let input_focus: RwSignal<bool> = create_rw_signal(false);
    view! {

input4

With focus events: Using the same f64 type internally and as signal externally

        <input data-testid="Input4" type="text"
          on:focusin=move |ev| {
            input_focus.set(true);
            info!("input_focus = {}", input_focus.get());

            let z = input_string.get();
            // remove " t" from string
            let z = z.trim_end_matches(" t");
            input_string.set(format!("{}", z));

          }
          on:focusout=move |ev| {
            input_focus.set(false);
            info!("input_focus = {}", input_focus.get());
            let z = input_string.get();
            input_string.set(format!("{} t", z));
          }
          on:input=move |ev| {
            let input: String = event_target_value(&ev);
            input_string.set(input);
          }
          prop:value = move || {
            let zz = input_string.get().parse::<f64>();
            match zz {
              Ok(v) => {
                  output_float.set(v);
                  info!("out1put_float = {}", output_float.get());
              },
              Err(e) => info!("{}: zz n1ot parsable", e)
            }
            input_string.get()
            }
        />

        input_string: { move || input_string.get()}

        output_float: { move || output_float.get()}

        <button on:click=move |_| {
                input_string.set("1.23".to_string());
                //output_float.set(1.23);
              }
        >Reset</button>
    }
}


Consider moving module to voxpupuli

node_encrypt seems to have gained a lot of traction recently and there's a number of organisations I've seen that now rely on it.
I wondered what your thoughts @binford2k would be on approaching @voxpupuli to see if they'd be interested in assisting with it's development?
Another option is to see if @puppet would consider supporting the module or it's functionality in core Puppet, but that would result in people having to log Jira tickets for problems etc... which is a bit annoying.

https://voxpupuli.org

I don't have a problem with the idea, but I don't know that they'd want to own responsibility for something that alters catalog internals. @bastelfreak was wondering if you'd be willing to maintain it?
My long term goal for this module has always been to get the functionality into the Sensitive type and then freeze this for older versions. For now, I'll see if I can allocate company time to work on this, maybe even get it into the test matrix.

@binford2k That never happened.  Is migration something you'd still consider?

Absolutely. The consensus last time was that there was a little concern about owning something that mucked with catalog internals, but I don't have any misgivings on my side. As soon as y'all want it, it's yours.


allow to specify if an objective is convex to skip part of the test_s…

…olver

Codecov Report

Merging #203 (6da08bd) into master (daf2bdc) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   63.51%   63.53%   +0.02%
==========================================
  Files          41       41
  Lines        2061     2068       +7
  Branches      344      344
==========================================
+ Hits         1309     1314       +5
- Misses        656      659       +3
+ Partials       96       95       -1


[Bug] diagnosticMode": "workspace" is broken in new release

Environment data

Language Server version: 2022.9.20
OS and version: Ubuntu20.04
Python version (& distribution if applicable, e.g. Anaconda): python 3.8.10

Code Snippet
"python.analysis.diagnosticMode": "workspace",

Repro Steps

1, Open a workspace with python files with problems.
2. Update from 2022.9.10 to 2022.9.20 and reload VSCode.
Expected behavior
To analyse the workspace like before.
Actual behavior
The workspace is not analyzed./ No files are found?(See logs below)
Logs

Python language Server logs:
2022.9.10:
[Info] (177277) Assuming Python version 3.8
[Info] (177277) Assuming Python platform Linux
[Info] (177277) Searching for source files
[Info] (177277) Found 33 source files
[Info] (177277) Background analysis(3) root directory: /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist
[Info] (177277) Background analysis(3) started
[Info] (177277) No configuration file found.
[Info] (177277) No pyproject.toml file found.

2022.9.20:
[Info] (178480) Assuming Python version 3.8
[Info] (178480) Assuming Python platform Linux
[Info] (178480) Searching for source files
[Info] (178480) No source files found.
[Info] (178480) No configuration file found.
[Info] (178480) No pyproject.toml file found.

Based on the logs, I would conclude that something has changed in how the files are searched?

+1, Vscode's "go to symbol" is also broken. Going one release down fixes it.

Was just going to say that I'm experiencing the same thing. Go to Symbol in Workspace does not work. I stepped down a release for now to resolve the issue.

Can you provide us some logs as described in the troubleshooting guide?
and settings you have for pylance?

I would guess that the underlying cause could be the same as for #3348.
I think that are all relevant settings:
    "python.languageServer": "Pylance", // Pyright
    "python.analysis.typeCheckingMode": "strict",
    "python.analysis.diagnosticSeverityOverrides": {
        "reportMissingTypeStubs": "information",
        "reportUnnecessaryTypeIgnoreComment": "information",
    },
    "python.analysis.completeFunctionParens": true,
    "python.analysis.diagnosticMode": "workspace",

Full Log 2022.9.20

[Info] (209178) Pylance language server 2022.9.20 (pyright 95c059fa) starting
[Info] (209178) Server root directory: /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.20/dist
[Info] (209178) Starting service instance "<project>"
[Info] (209178) Notebook support: LSP
[Info] (209178) Interactive window support: LSP
[Info] (209178) No configuration file found.
[Info] (209178) pyproject.toml file found at /workspaces/<project>.
[Info] (209178) Setting pythonPath for service "<project>": "/bin/python3"
[Info] (209178) Loading pyproject.toml file at /workspaces/<project>/pyproject.toml
[Error - 9:45:56 PM] (209178) Pyproject file "/workspaces/<project>/pyproject.toml" is missing "[tool.pyright]" section.
[Warn] (209178) stubPath /workspaces/<project>/typings is not a valid directory.
[Info] (209178) Assuming Python version 3.8
[Info] (209178) Assuming Python platform Linux
[Info] (209178) Search paths for /workspaces/<project>
[Info] (209178)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.20/dist/typeshed-fallback/stdlib
[Info] (209178)   /workspaces/<project>
[Info] (209178)   /workspaces
[Info] (209178)   /workspaces/<project>/typings
[Info] (209178)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.20/dist/typeshed-fallback/stubs/...
[Info] (209178)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.20/dist/bundled/stubs
[Info] (209178)   /usr/lib/python3.8
[Info] (209178)   /usr/lib/python3.8/lib-dynload
[Info] (209178)   /usr/local/lib/python3.8/dist-packages
[Info] (209178)   /usr/lib/python3/dist-packages
[Info] (209178) Adding fs watcher for library directories:
 /usr/lib/python3.8
/usr/lib/python3.8/lib-dynload
/usr/local/lib/python3.8/dist-packages
/usr/lib/python3/dist-packages
[Info] (209178) Searching for source files
[Info] (209178) No source files found.
[Info] (209178) Background analysis(1) root directory: /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.20/dist
[Info] (209178) Background analysis(1) started
(209178) Background analysis message: setConfigOptions
(209178) Background analysis message: setImportResolver
(209178) Background analysis message: ensurePartialStubPackages
(209178) Background analysis message: setTrackedFiles
(209178) Background analysis message: markAllFilesDirty
(209178) Background analysis message: analyze

Full Log 2022.9.10

[Info] (211053) Pylance language server 2022.9.10 (pyright aba41864) starting
[Info] (211053) Server root directory: /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist
[Info] (211053) Starting service instance "<project>"
[Info] (211053) Notebook support: LSP
[Info] (211053) Interactive window support: LSP
[Info] (211053) No configuration file found.
[Info] (211053) pyproject.toml file found at /workspaces/<project>.
[Info] (211053) Setting pythonPath for service "<project>": "/bin/python3"
[Info] (211053) Loading pyproject.toml file at /workspaces/<project>/pyproject.toml
[Error - 9:52:23 PM] (211053) Pyproject file "/workspaces/<project>/pyproject.toml" is missing "[tool.pyright]" section.
[Warn] (211053) stubPath /workspaces/<project>/typings is not a valid directory.
[Info] (211053) Assuming Python version 3.8
[Info] (211053) Assuming Python platform Linux
[Info] (211053) Search paths for /workspaces/<project>
[Info] (211053)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist/typeshed-fallback/stdlib
[Info] (211053)   /workspaces/<project>
[Info] (211053)   /workspaces
[Info] (211053)   /workspaces/<project>/typings
[Info] (211053)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist/typeshed-fallback/stubs/...
[Info] (211053)   /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist/bundled/stubs
[Info] (211053)   /usr/lib/python3.8
[Info] (211053)   /usr/lib/python3.8/lib-dynload
[Info] (211053)   /usr/local/lib/python3.8/dist-packages
[Info] (211053)   /usr/lib/python3/dist-packages
[Info] (211053) Adding fs watcher for library directories:
 /usr/lib/python3.8
/usr/lib/python3.8/lib-dynload
/usr/local/lib/python3.8/dist-packages
/usr/lib/python3/dist-packages
[Info] (211053) Adding fs watcher for directories:
 /workspaces/<project>
[Info] (211053) Searching for source files
[Info] (211053) Found 32 source files
[Info] (211053) Background analysis(1) root directory: /home/<user>/.vscode-server/extensions/ms-python.vscode-pylance-2022.9.10/dist
[Info] (211053) Background analysis(1) started
(211053) Background analysis message: setConfigOptions
(211053) Background analysis message: setImportResolver
(211053) Background analysis message: ensurePartialStubPackages
(211053) Background analysis message: setTrackedFiles
(211053) Background analysis message: markAllFilesDirty
(211053) Background analysis message: analyze
(211053) [BG(1)] analyzing: ....(cut logs here)

it is a dup of https://github.com/microsoft/pylance-release/issues/3348

@alkatar21, it looks like you switched projects/directories? The most recent log says that we found a pyproject.toml file which would would cause you to hit #3348. But the original log file says, "No pyproject.toml file found."
Are you seeing issues in scenarios where there is no pyproject.toml? If so, can you provide a more verbose log from that scenario?

@debonte Sorry, that was a mistake of mine I realized while writing the last comment. This is a multiroot workspace project and I had forgotten to remove one additional root while creating the ticket. That belongs to a different root. The project is the same only a few commits later. I forgot to save the updated description.

If you're only seeing this when a pyproject.toml file is present, then this is #3348. I'm not sure based on your last comment if that's the case or not. Can you clarify?

In the project there is a pyproject.toml.
I just deleted pyproject.toml and reloaded the window, now it works as expected. So the pyproject.toml triggers the problem, yes.

Can confirm, deleting pyproject.toml fixed it for me too.


SpecClient HowTo/GettingStarted docs

The HowTo and GettingStarted notebooks (and html versions) for the specClient interface.  Note these will not work as-is until the specClient is merged into the 'datalab' client and deployed to gp12.  Before that, get the 'specClient.py' from the 'specserver' repo and modify the "from dl import specClient as spec" line to just "import specClient as spec".

I used this to get specClient.py:
try:
    from dl import specClient as spec         # primary spectral data client interface
except ImportError:
    import os, sys
    sys.path.insert(0, os.path.join(os.environ['HOME'], 'specserver'))
    import specClient as spec

if you need it for your tests.

Just a quick add-on to one of Ben's comments: please use the NB template for general outline / layout of a notebook:
https://github.com/noaodatalab/notebooks-latest/blob/master/DataLabNotebookTemplate.ipynb

Getting Started notebook

Add the following to datasets : ['sdss_dr16']
Change the 'disclaimers1.php' link to 'disclaimers.php'
I'm not sure why but the Summary, Disclaimer & attribution, Authentication, and Querying for spectra hyperlinks under Table of Contents didn't work for me
Under Authentication, remove any mention of 'token'. The cell should just be:

#authClient.login(input("Enter user name: (+ENTER) "),getpass("Enter password: (+ENTER) "))
authClient.whoAmI()

Remove the following imports since they are not used in this notebook:

import pandas as pd
from IPython.display import Image
from dl.helpers.utils import convert

Under 'Querying for spectra', first paragraph last sentence misspelled identifers "ientifiers"

How to use notebook

Under 'Summary', the API documentation link gives me a 404 error (since it doesn't exist yet?)
Change 'disclaimers1.php' to 'disclaimers.php'
Remove the following from imports since it is not used in this notebook:
import pandas as pd

My comments provided via email (too lengthy for here).

Without replying to each comment individually I'll say that each of the point has been addressed, and thank you for the comments.  The one thing not addressed are the comments that the HowTo is too long and that there is redundant information between the two notebooks.  I've added a 'References' section where each notebook points to the other, however I believe they each serve a different purpose and should be able to stand alone.  For example, 'contexts' are described in the HowTo and I think it would be confusing/annoying to have to lookup what they are in a GettingStarted doc in another part of the notebooks directory.  The only logical way to split up the (I don't consider too) lengthy HowTo would be to have separate Intro/Query/Access notebooks, but again I think these are distinct from the GettingStarted.
The repo has been updated with changes and the specClient.py change added to each of your notebook directories.  Server-side changes are deployed to gp06.

On Mon, Jan 4, 2021 at 5:09 PM Stephanie Juneau<EMAIL_ADDRESS>wrote:

@stephjuneau requested changes on this pull request.
Minor comments on "Getting Started with Spectra":
1- http://datalab.noao.edu/disclaimers.php --> noirlab

Changed.  ALso made 'https', similar changes to HowTo
2- In the Summary, add that the science case notebook is called

"EmLineGalaxies_SpectraStack.ipynb"

Done

3- Under "Imports"
For saving query results in virtual [storage] <-- missing a word

You may have an old notebook, this was previously fixed.

4- Under "Querying for Spectra"
"an array of idkkjentifiers" <-- typo

Fixed

5- Under "Preview Plots"
It may be confusing that displaying the png for the single spectrum
preview has some cyan frame with numbers that seem to be pixel sizes. Not
urgent but would check how to avoid it showing like this.

Fixed.  There was some additional styling in the HowTo that was removed.

Also would be nice to see some wavelength values and know whether the
Preview can be called optionally in rest frame or in observed frame
(depending on the use case, I can think of either one being desirable).

I tried this before, the problem being the text was generally unreadable,
and if it was made large enough to read the file size became an issue.  The
fix may be do add some custom labelling or a plotPreview() method that uses
the pylot labels.  Either way would require regenerating all the previews
so I'd consider it a future feature enhancement. I created an issue so it
isn't forgotten.

For the grid preview, would be nice to print in the notebook cell how many
entries are in "id_list" so that the users can figure out how many pages
there can go through. Also, can the user save the PNGs for future
reference? If that's in the longer HowTo, then referring to that would be
helpful.

I added a print of the number of images and an example of using the save()
method to save the PNG to a file to each notebook.  Also created a ticket
to do better annotation later.
Thanks for the comments!  I've updated the 'specserver' branch of the
'notebooks-latest' repo.
-Mike

On Mon, Jan 4, 2021 at 5:09 PM Stephanie Juneau<EMAIL_ADDRESS>wrote:

@stephjuneau requested changes on this pull request.
Minor comments on "Getting Started with Spectra":
1- http://datalab.noao.edu/disclaimers.php --> noirlab

Changed.  ALso made 'https', similar changes to HowTo
2- In the Summary, add that the science case notebook is called

"EmLineGalaxies_SpectraStack.ipynb"

Done

3- Under "Imports"
For saving query results in virtual [storage] <-- missing a word

You may have an old notebook, this was previously fixed.

4- Under "Querying for Spectra"
"an array of idkkjentifiers" <-- typo

Fixed

5- Under "Preview Plots"
It may be confusing that displaying the png for the single spectrum
preview has some cyan frame with numbers that seem to be pixel sizes. Not
urgent but would check how to avoid it showing like this.

Fixed.  There was some additional styling in the HowTo that was removed.

Also would be nice to see some wavelength values and know whether the
Preview can be called optionally in rest frame or in observed frame
(depending on the use case, I can think of either one being desirable).

I tried this before, the problem being the text was generally unreadable,
and if it was made large enough to read the file size became an issue.  The
fix may be do add some custom labelling or a plotPreview() method that uses
the pylot labels.  Either way would require regenerating all the previews
so I'd consider it a future feature enhancement. I created an issue so it
isn't forgotten.

For the grid preview, would be nice to print in the notebook cell how many
entries are in "id_list" so that the users can figure out how many pages
there can go through. Also, can the user save the PNGs for future
reference? If that's in the longer HowTo, then referring to that would be
helpful.

I added a print of the number of images and an example of using the save()
method to save the PNG to a file to each notebook.  Also created a ticket
to do better annotation later.
Thanks for the comments!  I've updated the 'specserver' branch of the
'notebooks-latest' repo.
-Mike


Issue reproducing retrieval results using API and hugging face implementation

Hi, I tried replicating the audio to text retrieval results using the PyPI library and the hugging face implementation, however the obtained numbers do not match with those reported in the paper.
For the hugging face implementation, I use ClapTextModelWithProjection and ClapAudioModelWithProjection. I obtain the similarity score by performing cosine similarity and sort the retrieved texts by similarity score.
Similarly for the PyPI library implementation, I use get_audio_embedding_from_data and get_text_embedding and follow the same procedure as above.
The model is initialized as following:
model = laion_clap.CLAP_Module(enable_fusion=enable_fusion)
model.load_ckpt()

I am using Clotho version 2.1 evaluation split from here and AudioCaps val split from google drive link in repository
Could you please help me understand what could be the issue?

Hi,
I would recommend using this github implementation to evaluate the model. Also, for clotho dataset, for one audio there are 5 text labels. Thus, the metric calculation is a bit different. Please refer to our implementation of evaluation in here: https://github.com/LAION-AI/CLAP/blob/main/src/laion_clap/training/train.py#L577

@Aafiya-H were you able to reproduce the results with the github repo?


Missing a line break before closing ``` in accessible view

Found testing https://github.com/microsoft/vscode/issues/213941

Looks good now


Feature/remove pandas

Remove pandas dependencies for mango.table and mango.processing
Function use pandas if it is installed and alternative function if it is not.

Codecov Report

Merging #52 (93df9ba) into development (93df9ba) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 93df9ba differs from pull request most recent head 8d46d33. Consider uploading reports for the commit 8d46d33 to get more accurate results

@@             Coverage Diff              @@
##           development      #52   +/-   ##
============================================
  Coverage        76.78%   76.78%
============================================
  Files               31       31
  Lines             1331     1331
============================================
  Hits              1022     1022
  Misses             309      309

Flag
Coverage Δ

unit-tests
76.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix protobuff issue (WIP)

Just another attempt to address the protobuf issue. Draft until its tested if it works.
First PR job passed: https://build.osrfoundation.org/job/ign_gazebo-pr-win/3312/
Rebuild: https://build.osrfoundation.org/job/ign_gazebo-pr-win/3322/
🦟 Bug fix
Fixes #
Summary

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Another retry: https://build.osrfoundation.org/job/ign_gazebo-pr-win/3324/

After feedback in original issue:

WIndows

Yes, I will close it, this is a leftover, and this issue was addressed properly some time ago, thanks!


[Safe Apps] ENS Manager App - Design

Figma project: https://www.figma.com/proto/ZARPklDSkwpLKsN2wYUoVe/Gnosis-Safe-APP-ENS?node-id=23%3A6&scaling=min-zoom


Error in markAsRead for Fan Pages (maybe due to a permissions issue?)

Hi I'm getting the following error when executing markAsRead
ERR! Error in markAsRead { __ar: 1,
ERR! Error in markAsRead   __sf: 'i0',
ERR! Error in markAsRead   error: 1357031,
ERR! Error in markAsRead   errorSummary: 'Este contenido ya no está disponible',
ERR! Error in markAsRead   errorDescription: 'El contenido solicitado no puede mostrarse en este momento. Puede que no esté disponible, que el enlace que hayas pulsado haya caducado o que no tengas permiso para ver esta página.',
ERR! Error in markAsRead   payload: null,
ERR! Error in markAsRead   bootloadable: {},
ERR! Error in markAsRead   ixData: {},
ERR! Error in markAsRead   lid: '6382249397858049269' }

the code is very basic, as follows:
var stopListening = api.listen(function(err, event) {
        if(err) return console.error(err);
        switch(event.type) {
			case "message":
				api.markAsRead(event.threadID, function(err) {
					//if(err) console.log(err);
				});
				 // redirect the message to my app server
				break;
			case "event":
				console.log(event.type);
				break;
        }
    });

As expected, messages are not being marked as read, when I check the Fan Page messages board.
Is there any kind of permissions I need to give my Fan Page so the call to markAsRead don't return this errors? or should I be checking something somewhere else?
Thanks for your help!

Mmmh it could be that markAsRead is broken for pages. Can you reply to messages from the page?

Yes, I can send and receive messages normally, but I keep getting the same error for each message sent by a customer. Is there any chance that this can be fixed? Where should I look in the code for this? I don't have much knowledge about facebook API, but I could at least take a look at it. Thanks for your quick response!

I see. Try commenting this line https://github.com/Schmavery/facebook-chat-api/blob/11311dc41fd3b1f3ea4aac0f38056438fb0f62d9/src/markAsRead.js#L17 inside your node_modules and see if that changes anything.
If you open chrome, go to your page (where you see all of the messages you've received), open the dev console, then go to network tab (and hit record) you'll see all of the requests that the browser's sending. Log in with another account in another tab and send a message to the page.
Check the request that you make when you receive the message, you should see a URL like https://www.facebook.com/ajax/mercury/change_read_status.php?dpr=2. Click on it and look at the form data that is sent alongside the request and see if there's any difference between than and what we're sending in markAsRead.

I'll do it when I have some free time (I hope this week). I first need to finish what I'm doing before the deadline xD. I'll let you know as soon as I've tested it.

Continue conversation in #500

Oh sorry this is for markAsRead. Let's not hijack the other conversation then.
Is this still happening?


Set TCP_USER_TIMEOUT socket option

clean pick of https://github.com/openshift/library-go/pull/926 and https://github.com/openshift/library-go/pull/944. I only removed klog/v2

/assign @sttts

/lgtm
/approve

/cherry-pick release-4.4

/cherry-pick release-4.4


sliding to end at anchor point during short tap in collapsed mode

I can move from collapsed mode to anchored mode and expanded mode, but when my activity is collapsed mode, I do a short tab on visible view and SlidingUpPanel opens to expanded mode, but this behavour is not wanted.
How to open just in anchored mode ?
    <com.sothree.slidinguppanel.SlidingUpPanelLayout xmlns:sothree="http://schemas.android.com/apk/res-auto"
        android:id="@+id/sliding_layout"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:gravity="bottom"
        sothree:umanoAnchorPoint="0.5"
        sothree:umanoDragView="@+id/map_sliding_layout"
        sothree:umanoInitialState="hidden"
        sothree:umanoPanelHeight="35dp"
        sothree:umanoParalaxOffset="150dp"
        sothree:umanoShadowHeight="4dp" >

Thank you !

Please try version 3.0.0 and see if it's still an issue. The API changed a bit.

Thank you for your fast response.
I updated to 3.0.0 with any problem and tested my behavior but unfortunately the issue still exists.

If you don't want to expand the panel on click, you can set an onClickListener on the panel, and do nothing inside of it.


Working with namespaced keywords

Say you have a shape like so:
[{:a/a 1 :a/b 2}
 {:b/a 3 :b/b 4}
 {:c/a 5 :c/b 6}]

How do you collect the keywords regardless of namespace?

I'm not clear on what you're trying to do. What's the output you want to receive?

Apologies for the ambiguity. This is the output I'd like to receive:
[1 3 5]

I'd imagine the solution would involve something that looks like:
(defn ignore-keyword-ns [k]
  (keyword (name k)))
(select [ALL ignore-keyword-ns]
  [{:a/a 1 :a/b 2}
   {:b/a 3 :b/b 4}
   {:c/a 5 :c/b 6}])

There's no way to do this without scanning over all the keys. You can do this with this path:
(select [ALL ALL (selected? FIRST (view name) #(= "a" %)) LAST]
  [{:a/a 1 :a/b 2}
   {:b/a 3 :b/b 4}
   {:c/a 5 :c/b 6}]
  )

You can factor out "ignoring a key's namespace" as its own reusable navigator like this:
(use 'com.rpl.specter)
(use 'com.rpl.specter.macros)

(def ignore-key-ns
  (comp-paths
    ALL
    (selected?
      FIRST
      (view name)
      (paramsfn [target] [n] (= n (name target))))
    LAST
    ))

(select [ALL (ignore-key-ns :a)]
  [{:a/a 1 :a/b 2}
   {:b/a 3 :b/b 4}
   {:c/a 5 :c/b 6}]
  )

Thanks for your answer! This seems to be exactly what I need. What does view exactly do? It doesn't seem to be documented in specter.cljx or the readme.

It navigates to the result of running that function on that value.

Got it. Thanks, man :D


[TF mobile] change toolchain to clang

Change toolchain to clang, GCC Deprecated on Android ndk
https://android.googlesource.com/platform/ndk/+/master/docs/Roadmap.md

Nagging Reviewer @andrehentz: It has been 14 days with no activity and the awaiting review label was assigned. Can you please take a look?

Nagging Reviewer @andrehentz: It has been 29 days with no activity and the awaiting review label was assigned. Can you please take a look?

Nagging Reviewer @andrehentz: It has been 44 days with no activity and the awaiting review label was assigned. Can you please take a look?

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 59 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 74 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 89 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 104 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 119 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 134 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 149 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 164 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @andrehentz: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 182 days with no activity and the awaiting review label has been applied.

Sorry I missed this! I'll approve the change but you might have to rebase.

@andrehentz rebase to new master head?

@case540  Do I need to do something else?


Updated skills added a dice roller, fixed preview

Update 1.0.5 Fixed the order of skills to be alphabetical, added an Asset dice roller, and fixed the preview image

This branch has conflicts with the current version of the sheet. Could you please resolve those so that I can merge this? Thanks!

Sorry about that, I have resolved the conflicts, Thank you


[OTA] Update nerveshub server url

update nerves_hub app config to use nerveshub.farm.bot

Just tried this and it was a bit more complex than just updating app env. Gonna move back to post v8

Closing for now. This would only be possible if hosting our own instance of NervesHub


P3 "left entry" very slow

32 threads on a 2990wx, ramdisk, 970 evo+ in raid0
others seem to be getting more consistent speeds between left and right entries, 50s+/- for either one.

P3-2 is writing the left entries to RAM disk, but also the final plot to tmp_dir. Usually P3-2 is faster because it's not reading from tmp_dir, like P3-1. P3-1 Table 2 is always a bit slower because it has to do phase 2 work on table 1.
It's possible that during phase 1 your SSDs were able to trim enough space for phase 2, but then in phase 3 they ran out of trimmed space which will cause write speeds to go down a lot...
Also it's possible you're running out of RAM, phase 3 needs about 80GB of that RAM disk (40GB thereof is table 7 from phase 2, which is read at the end of phase 3).

P3-2 is writing the left entries to RAM disk, but also the final plot to tmp_dir. Usually P3-2 is faster because it's not reading from tmp_dir, like P3-1. P3-1 Table 2 is always a bit slower because it has to do phase 2 work on table 1.
It's possible that during phase 1 your SSDs were able to trim enough space for phase 2, but then in phase 3 they ran out of trimmed space which will cause write speeds to go down a lot...
Also it's possible you're running out of RAM, phase 3 needs about 80GB of that RAM disk (40GB thereof is table 7 from phase 2, which is read at the end of phase 3).

SSD are empty. Sustained write speeds for each separately ~1700mbps after cache, so I'm fairly certain it isn't that. IOTOP is only showing ~50mbps of writes at any point in p3 that I've observed so they're far from saturated
Not running out of ram, 188gb installed, 110 for the ramdisk

Can you run top -H during P3-2 and show me a snapshot?

That's from P3-1 of the next table 3, improving the merge thread is on the ToDo list.
When you see P3-1 on the terminal, that means it's currently processing P3-2.

Can you run top -H during P3-2 and show me a snapshot?

i've checked my NVME are performing as expected, maybe some of them aren't quite, but i've tried it on a few temp drives, raid and non-raid and performance is... consistent in as much as it's bad on all of them, no matter how fast or slow they benchmark post-cache.

That's pretty bad indeed, those two threads at the top are the bottleneck of phase 3 stage 2, one of them should be close to 100% with that many threads. But they aren't, which means the bottleneck is somewhere else...
Try reducing the number of threads, maybe the other threads are stealing CPU time from those two critical ones.

Also, experiencing same sub for phase 4, others get ~60 seconds, mine takes some 430 seconds, at about 25-30mbps write

yeah phase 4 is very similar to phase 3...

what seems to be slow for you is the final plot creation, which happens in phase 3 stage 2 and phase 4...
there is a lot going on there, which I didn't code myself, just copied from chiapos.

I guess I'll be able to test if it's CPU related tomorrow, hopefully that's the answer even though it means I'll be selling it. No idea why it would be, but would explain the somewhat disappointing overall plotting I've experienced if that's what it turns out to be.

#89 might fix your performance issue

P3-2 is now 30% faster on my machine. But it could make a bigger difference on your machine, since now there is much less context switching going on.

Lol, did another test and this time it was slower... I think there is trap, once it falls into it it never recovers. Fixing it now..

P3-2 is now 30% faster on my machine. But it could make a bigger difference on your machine, since now there is much less context switching going on.

Oh man it's so much better! Only run one plot but so far looks great
P3-1 maybe a smidge slower but great overall p3-1 50s, p3-2 35s, 630 total, shaved off about 10 mins
P4 still abysmal, almost 600 seconds

yeah P4 doesn't have the optimization yet

P3-1 table 7 is a bit special, it reads about 2.5 times more data from phase 2 output (40GB vs <16GB for the other tables).

Ah I know what might be happening... since I split the "slice" thread into two threads (besides another optimization, passing data in much bigger chunks) it's now possible for them to end up on two different CPUs! And that is going to kill performance... but if you're lucky it's a lot faster.

As in, 2 different CPU in a multi socket system? Probably a similarish potential pitfall for me with NUMA nodes on a single socket , but not an issue for most people with a normal setup?

Yes

check latest master, should be even faster now, P4 also optimized


Set FELIX_ROUTETABLERANGE to 31-250 for AWS CNI

AWS CNI will create routing tables with indexes from 2-15, so this
configuration will instruct Felix to no longer manage routing tables
in the range AWS CNI is using.
Description
This change fixes this bug.
I'm unsure yet whether this change should be applied only for EKS with AWS CNI, or for all AWS CNI environments. I suspect this will be a problem on all AWS CNI environments.
I have not tested this fix yet, just putting it up for early feedback.
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

From what I can tell, we only need to worry about EKS clusters here (AWS doesn't seem to support using this CNI outside of EKS). This is hinted at by banzai, which wont let you provision an AWS/Kubeadm cluster with anything other than CalicoCNI

Deployed this fix to an EKS cluster. Prior to patch, I observed these ip rule deletions:
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2
Deleted 1536:   from <IP_ADDRESS> to <IP_ADDRESS>/16 lookup 2

Post-patch, no-such deletions.

This is important to get in I think as right now without this, EKS is simply broken once felix starts programming overlapping routing tables with EKS such as wireguard, egress, per-host proxy etc. The downside with this approach is that with upgrades there will be orphaned tables to be manually cleaned up. I am not sure if there is a better solution. Right now wireguard cannot work on EKS with AWS CNI with this bug.
I would be happy to go with this for now but up to operator maintainers cc @tmjd

Afraid I'm not an Operator maintainer; you need Erik or Casey

What i don't understand is the impact of this change on currently functioning clusters? This will change a value that was previously the default, is it (possibly) going to break or cause issues on an already existing cluster when they update to the operator with this change? I don't think saying people that upgrade will need to clean up orphaned tables is good enough.
Should we consider an alternative of adding to the documentation when enabling wireguard, egress, per-host proxy to include setting the configuration through FelixConfiguration. I'd rather have an issue when people are taking a deliberate action to enable a feature to adjust the configuration rather than it be a change in behavior on upgrade and potentially cause issues then.

What I see from testing is that without FELIX_ROUTETABLERANGE set to something like 31-250, as soon as they exceed 5-6 pods, the node will get a second ENI assigned by AWS CNI, and it will use a table index of 2. Immediately I'm seeing that Felix will consider that this change must be removed since it did not sanction it. This is without even using Wireguard at all.
I'm surprised that this hasn't been raised by customers though?
Erik I see what you're saying, is there any way in the operator to make a change like in this PR, but have it only applied on install of new clusters rather than for existing ones?
Without this change we'd need to update the docs to advise setting the configuration through FelixConfiguration for all AWS CNI clusters, not just those using Wireguard. I completely see your point though, at least if they're setting it manually they can do it when it suits them, and are prepared to do any required cleanup.

There isn't a way to make this happen for only new clusters. We would have to add it to the operator Installation API and the only action we could do would be to set a default but since the field wouldn't exist on current installations we would default it on upgrade also.
I think someone mentioned possibly adding something to Felix to clean up old Felix tables, is that a real possibility?

I was asking @fasaxc about Felix cleaning up the tables and it would be pretty messy and error-prone, since Felix no longer knows the table indexes to remove it would have to try and identify the rules and tables by other means.

What I see from testing is that without FELIX_ROUTETABLERANGE set to something like 31-250, as soon as they exceed 5-6 pods, the node will get a second ENI assigned by AWS CNI, and it will use a table index of 2. Immediately I'm seeing that Felix will consider that this change must be removed since it did not sanction it.

I think this is the swinger for me.  It seems that it's broken already!  I'm inclined to get the fix out there with a release note.  I think the vast majority of EKS operator users are ahead of us.  Changing this now will inconvenience a few (who had broken clusters anyway) but it'll save the vast majority of users who haven't switched top operator yet.


Replace Draftail with EditorJS

I want to merge this change because it improves rich text editor 🎉
PR intended to be tested with API branch: master
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-916 Switch CMS to Editor.js


Updated banners and added directory placeholders

Updated banners and added data directory placeholders

@holeung  I don't think Jamie is online, feel free to merge this pull request :)


Universe Selection not working properly when use another currency from USD

Expected Behavior

Work without any exception.
Actual Behavior

Give an error. Please look at the second attachment.
Potential Solution

I looked at engine code that handles algorithms and didn't understand what is the problem.
Reproducing the Problem

Please look at the first attachment. The left side is working and the right side is not.
System Information

Windows 10 and Lean is the latest version.
Checklist

[x] I have completely filled out this template
[X] I have confirmed that this issue exists on the current master branch
[X] I have confirmed that this is not a duplicate issue by searching issues

[X] I have provided detailed steps to reproduce the issue

<!--- Template inspired by https://github.com/stevemao/github-issue-templates --
![Code](https://user-images.githubusercontent.com/640271/143367014-f9c116ac-81b4-406f-83fa-5c3e1b36d310.png)
![Error](https://user-images.githubusercontent.com/640271/143367034-cf42552a-6b58-4d49-b1c8-68a19600a6cf.png)
>

Today I try to test above algorithms (user universe vs manual universe selection model) on quantconnect.com. And as I expected, I see same error messages on algorithm lab same as local copy of LEAN. Below error message and stacktrace from quantconnect.com:
Error Message: Algorithm.Initialize() Error: No conversion path found between source currency BTC and destination currency USDT Stack Trace: System.ArgumentException: No conversion path found between source currency BTC and destination currency USDT
at QuantConnect.Securities.CurrencyConversion.SecurityCurrencyConversion.LinearSearch(String sourceCurrency, String destinationCurrency, IList1 existingSecurities, IEnumerable1 potentialSymbols, Func2 makeNewSecurity) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/CurrencyConversion/SecurityCurrencyConversion.cs:line 223    at QuantConnect.Securities.Cash.EnsureCurrencyDataFeed(SecurityManager securities, SubscriptionManager subscriptions, IReadOnlyDictionary2 marketMap, SecurityChanges changes, ISecurityService securityService, String accountCurrency, Resolution defaultResolution) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/Cash.cs:line 292
at QuantConnect.Securities.CashBook.EnsureCurrencyDataFeeds(SecurityManager securities, SubscriptionManager subscriptions, IReadOnlyDictionary`2 marketMap, SecurityChanges changes, ISecurityService securityService, Resolution defaultResolution) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/CashBook.cs:line 119
at QuantConnect.Lean.Engine.DataFeeds.CurrencySubscriptionDataConfigManager.EnsureCurrencySubscriptionDataConfigs(SecurityChanges securityChanges, IBrokerageModel brokerageModel) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/DataFeeds/CurrencySubscriptionDataConfigManager.cs:line 140
at QuantConnect.Lean.Engine.Setup.BaseSetupHandler.SetupCurrencyConversions(IAlgorithm algorithm, UniverseSelection universeSelection) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Setup/BaseSetupHandler.cs:line 57
at QuantConnect.Lean.Engine.Setup.BacktestingSetupHandler.Setup(SetupHandlerParameters parameters) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Setup/BacktestingSetupHandler.cs:line 217
at QuantConnect.Lean.Engine.Engine.Run(AlgorithmNodePacket job, AlgorithmManager manager, String assemblyPath, WorkerThread workerThread) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Engine.cs:line 227
Stacktrace: System.ArgumentException: No conversion path found between source currency BTC and destination currency USDT
at QuantConnect.Securities.CurrencyConversion.SecurityCurrencyConversion.LinearSearch(String sourceCurrency, String destinationCurrency, IList1 existingSecurities, IEnumerable1 potentialSymbols, Func2 makeNewSecurity) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/CurrencyConversion/SecurityCurrencyConversion.cs:line 223    at QuantConnect.Securities.Cash.EnsureCurrencyDataFeed(SecurityManager securities, SubscriptionManager subscriptions, IReadOnlyDictionary2 marketMap, SecurityChanges changes, ISecurityService securityService, String accountCurrency, Resolution defaultResolution) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/Cash.cs:line 292
at QuantConnect.Securities.CashBook.EnsureCurrencyDataFeeds(SecurityManager securities, SubscriptionManager subscriptions, IReadOnlyDictionary`2 marketMap, SecurityChanges changes, ISecurityService securityService, Resolution defaultResolution) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Common/Securities/CashBook.cs:line 119
at QuantConnect.Lean.Engine.DataFeeds.CurrencySubscriptionDataConfigManager.EnsureCurrencySubscriptionDataConfigs(SecurityChanges securityChanges, IBrokerageModel brokerageModel) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/DataFeeds/CurrencySubscriptionDataConfigManager.cs:line 140
at QuantConnect.Lean.Engine.Setup.BaseSetupHandler.SetupCurrencyConversions(IAlgorithm algorithm, UniverseSelection universeSelection) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Setup/BaseSetupHandler.cs:line 57
at QuantConnect.Lean.Engine.Setup.BacktestingSetupHandler.Setup(SetupHandlerParameters parameters) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Setup/BacktestingSetupHandler.cs:line 217
at QuantConnect.Lean.Engine.Engine.Run(AlgorithmNodePacket job, AlgorithmManager manager, String assemblyPath, WorkerThread workerThread) in /LeanCloud/CI.Builder/bin/Debug/src/QuantConnect/Lean/Engine/Engine.cs:line 227
I'm wondering if this is a bug or is it my fault?

Hey @aytacasan!

No conversion path found between source currency BTC and destination currency USDT

Have you tried specifying SetBrokerageModel(BrokerageName.Binance) else Lean using the default brokerage model will use GDAX as default crypto market, where the BTCUSDT pair does not exist

Yes, I try that and still there is an error. Below code from quantconnect.com -> algorithm lab;
`
namespace QuantConnect.Algorithm.CSharp
{
public class CalculatingVioletAnguilline : QCAlgorithm
{
    public override void Initialize()
    {
    	SetAccountCurrency("USDT");	// Set Account Currency
    	SetCash(1000000);			// Set Strategy Cash

        SetStartDate(2018, 08, 17);	// Set Start Date
        SetEndDate(2021, 11, 15);	// Set End Date

        var tickers = new string[]
        {
        	"ADAUSDT", "BNBUSDT", "BTCUSDT",
        	"ETHUSDT", "LTCUSDT", "SOLUSDT"
        };

        //foreach (var ticker in tickers)
        //{
        //	AddCrypto(ticker, Resolution.Daily, Market.Binance);
        //}

        var symbols = new List<Symbol>();
        foreach (var ticker in tickers)
        {
        	symbols.Add(QuantConnect.Symbol.Create(ticker, SecurityType.Crypto, Market.Binance));
        }

        UniverseSettings.Resolution = Resolution.Daily;
        SetUniverseSelection(new ManualUniverseSelectionModel(symbols));

        SetBenchmark("BTCUSDT");
        SetBrokerageModel(BrokerageName.Binance);
    }

    /// OnData event is the primary entry point for your algorithm. Each new data point will be pumped in here.
    /// Slice object keyed by symbol containing the stock data
    public override void OnData(Slice data)
    {
        // if (!Portfolio.Invested)
        // {
        //    SetHoldings("SPY", 1);
        //    Debug("Purchased Stock");
        //}
    }

}

}
`

Hey @aytacasan!
SetBrokerageModel(BrokerageName.Binance); is throwing an exception, binance only support cash account types for now, using SetBrokerageModel(BrokerageName.Binance, AccountType.Cash); will do the trick.
Underlying issue solved by https://github.com/QuantConnect/Lean/pull/6092 is that algorithm setup would report the second error (No conversion path found between source currency) because it was still using GDAX as crypto market (because it failed at SetBrokerageModel(BrokerageName.Binance);), after the PR it will report the first error asking you to use AccountType.Cash
Thanks for the report!

Hi @Martin-Molinero,
I see and changed above sample code line from
SetBrokerageModel(BrokerageName.Binance);
to
SetBrokerageModel(BrokerageName.Binance, AccountType.Cash);
then add below lines under SetUniverseSelection(new ManualUniverseSelectionModel(symbols));
   SetAlpha(new ConstantAlphaModel(InsightType.Price, InsightDirection.Up, TimeSpan.FromDays(365)));     SetPortfolioConstruction(new EqualWeightingPortfolioConstructionModel());     SetExecution(new ImmediateExecutionModel());     SetRiskManagement(new NullRiskManagementModel());
Receive an error : During the algorithm initialization, the following exception has occurred: Non null IExecutionModel and IPortfolioConstructionModel are currently unsuitable for Cash Modeled brokerages (e.g. GDAX) and may result in unexpected trades. To prevent possible user error we've restricted them to Margin trading. You can select margin account types with SetBrokerage( ... AccountType.Margin). Or please set them to NullExecutionModel, NullPortfolioConstructionModel in Framework.cs:line 79 Non null IExecutionModel and IPortfolioConstructionModel are currently unsuitable for Cash Modeled brokerages (e.g. GDAX) and may result in unexpected trades. To prevent possible user error we've restricted them to Margin trading. You can select margin account types with SetBrokerage( ... AccountType.Margin). Or please set them to NullExecutionModel, NullPortfolioConstructionModel.
What is that mean? we should not use framework feature with cash accounts? Because without execution and portfolio construction, algorithm is meaningless. Am i missing something?


Fixing missing re-export

cyw::ScanOptions

Seems solved:

CI fails because that struct is now public without docs. could you add some?

Formmat failed. I'm on it

I executed rustfmt.exe .\lib.rs but I'm getting an error because I'm not on nightly channel. So formmating seems not working. Also with VSCode isn't doing anything:

try cargo +nightly fmt in the cyw43 dir

Ok, so passing --edition 2021 made it work. As I supposed, was an alphabetical order issue.

thanks!


[Off-canvas] long list menu is cutted

How can we reproduce this bug?

make a long list menu itens ( like 40 li - item - /li )

What did you expect to happen?
i think that menu height iss fixed because itens is there but was cutted.

An example would really help here. Can you add it to this codepen and post it here? http://codepen.io/rafibomb/pen/gPxVBd

I made demo - looks like you can scroll to get the menu items that are off screen. http://codepen.io/rafibomb/pen/adxRoP
If you see there is still an issue, please open a new issue with an example so we can dig into it. Thanks!


ESC key press behaviours

When alternator masks used, I met some minor problems with ESC keypress noting here;

If undoOnEscape: true(default) option is used, if ESC pressed, it is evaulated as entry and second mask is activated by adding +.
If undoOnEscape: false, above problem is fixed but in both case cursor moves to end.

https://jsfiddle.net/newmangreen/gqjytw9u/
Expecting;
ESC keypress should be skipped if no entry done while keeping cursor position.

@newmangreen ,
Thx for reporting.


Trouble compiling for 64bit OSX

I've added this to a framework for an OS X & iOS app, however i'm having trouble building it for the App Stores.
I get the error ld: symbol(s) not found for architecture arm64 when trying to build for iOS and a similar x86_64 error for OS X.
Is there a reason this wouldn't compile for 64 bit?
Thanks

I need more information... This error can occur for many reasons.


[bug] Graphql Shutting Down When Running Query

Describe the bug
When I run the following query IsDependencyQ2  in the graphql playground I get the error "internal system error”.
fragment allIsDependencyTree on IsDependency {
  id
  justification
  package {
    id
    type
    namespaces {
      id
      namespace
      names {
        id
        name
        versions {
          id
          version
          qualifiers {
            key
            value
          }
          subpath
        }
      }
    }
  }
  dependencyPackage {
    id
    type
    namespaces {
      id
      namespace
      names {
        id
        name
        versions {
          id
          version
          qualifiers {
            key
            value
          }
          subpath
        }
      }
    }
  }
  dependencyType
  versionRange
  origin
  collector
}

query IsDependencyQ1 {
  IsDependency(isDependencySpec: {
    dependencyPackage: {
      id: 1006
    }
  }) {
    ...allIsDependencyTree
  }
}

query IsDependencyQ2 {
  IsDependency(isDependencySpec: {
    dependencyPackage: {
      type: "golang"
      name: "net"
    }
  }) {
    ...allIsDependencyTree
  }
}

When ever I run IsDependencyQ2 my graphql shuts down. If I run any other type of query, like IsDependencyQ1 then it doesn’t quit.
Screenshots
What I am getting when the graphql shuts down:
➜  guac git:(main) go run ./cmd/guacgql --gql-debug
{"level":"info","ts":1703714313.5010402,"caller":"logging/logger.go:70","msg":"Logging at info level"}
{"level":"info","ts":1703714313.5012429,"caller":"cli/init.go:67","msg":"Using config file: /Users/nathannaveen/go/src/github.com/nathannaveen/guac/guac.yaml"}
{"level":"info","ts":1703714313.5014,"caller":"cmd/server.go:97","msg":"connect to http://localhost:8080/ for GraphQL playground"}
{"level":"info","ts":1703714313.5014532,"caller":"cmd/server.go:101","msg":"starting server"}
runtime error: invalid memory address or nil pointer dereference

goroutine 774453 [running]:
runtime/debug.Stack()
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/runtime/debug/stack.go:24 +0x64
runtime/debug.PrintStack()
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/runtime/debug/stack.go:16 +0x1c
github.com/99designs/gqlgen/graphql.DefaultRecover({0x1f?, 0x16?}, {0x105e6bae0?, 0x106f76670?})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/recovery.go:17 +0x70
github.com/99designs/gqlgen/graphql.(*OperationContext).Recover(0x14000762238?, {0x1060bc8f8, 0x140045daab0}, {0x105e6bae0?, 0x106f76670?})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/context_operation.go:124 +0x44
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query_IsDependency.func1()
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:5540 +0x68
panic({0x105e6bae0?, 0x106f76670?})
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/runtime/panic.go:914 +0x218
github.com/guacsec/guac/pkg/assembler/backends/keyvalue.(*demoClient).exactPackageName(0x1056b002d?, {0x1060bc8f8, 0x140045daab0}, 0x140025a32c0)
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/backends/keyvalue/pkg.go:962 +0x140
github.com/guacsec/guac/pkg/assembler/backends/keyvalue.(*demoClient).IsDependency(0x14000016960, {0x1060bc8f8, 0x140045daab0}, 0x14010b97bc0)
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/backends/keyvalue/isDependency.go:182 +0x580
github.com/guacsec/guac/pkg/assembler/graphql/resolvers.(*queryResolver).IsDependency(0x1400438c9a8, {0x1060bc8f8, 0x140045daab0}, {0x0, 0x0, 0x140025a32c0, 0x0, 0x0, 0x0, 0x0, ...})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/resolvers/isDependency.resolvers.go:35 +0xc0
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query_IsDependency.func2({0x1060bc8f8?, 0x140045daab0})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:5546 +0x120
github.com/99designs/gqlgen/graphql/executor.processExtensions.func4({0x1060bc8f8?, 0x140045daab0?}, 0x140043809a0?)
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/executor/extensions.go:72 +0x2c
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query_IsDependency(0x14001f87400, {0x1060bc8f8, 0x140045da870}, {0x140043979e0, {0x14004f129d0, 0x1, 0x1}, 0x0})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:5544 +0x1a4
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query.func40({0x1060bc8f8?, 0x140045da870?}, 0x140025a3270)
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:7424 +0x94
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query.func41.1({0x1060bc8f8?, 0x140045da870?})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:7433 +0x34
github.com/99designs/gqlgen/graphql/executor.processExtensions.func3({0x1060bc8f8?, 0x140045da870?}, 0x10?)
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/executor/extensions.go:69 +0x2c
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query.func41({0x1060bc8f8, 0x140045da870})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:7432 +0xa4
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query.func42({0x14000762bb8?, 0x105452d0c?})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:7436 +0x30
github.com/99designs/gqlgen/graphql.(*FieldSet).Dispatch(0x140025a3270, {0x1060bc8f8?, 0x140045da810?})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/fieldset.go:41 +0xa8
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executionContext)._Query(0x14001f87400, {0x1060bc8f8, 0x140045da7b0}, {0x14008387b90, 0x1, 0x1})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/artifact.generated.go:7757 +0x4640
github.com/guacsec/guac/pkg/assembler/graphql/generated.(*executableSchema).Exec.func1({0x1060bc8f8, 0x140045da780})
	/Users/nathannaveen/go/src/github.com/nathannaveen/guac/pkg/assembler/graphql/generated/root_.generated.go:2740 +0x1fc
github.com/99designs/gqlgen/graphql/executor.(*Executor).DispatchOperation.func1.1.1({0x1060bc8f8, 0x140045da780})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/executor/executor.go:120 +0x2c
github.com/99designs/gqlgen/graphql/executor.processExtensions.func2({0x1060bc8f8?, 0x140045da780?}, 0x105d9b660?)
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/executor/extensions.go:66 +0x2c
github.com/99designs/gqlgen/graphql/executor.(*Executor).DispatchOperation.func1.1({0x1060bc8f8, 0x140045da6c0})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/executor/executor.go:119 +0x108
github.com/99designs/gqlgen/graphql/handler/transport.POST.Do({0x1060bc930?}, {0x1060b9440?, 0x1400338e000}, 0x14005b46100, {0x1060b9500, 0x140006b6280})
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/handler/transport/http_post.go:91 +0x45c
github.com/99designs/gqlgen/graphql/handler.(*Server).ServeHTTP(0x1400071b080, {0x1060b9440, 0x1400338e000}, 0x14005b46100)
	/Users/nathannaveen/go/pkg/mod/github.com/99designs/gqlgen@v0.17.41/graphql/handler/server.go:122 +0x1fc
net/http.(*ServeMux).ServeHTTP(0x10?, {0x1060b9440, 0x1400338e000}, 0x14005b46000)
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/net/http/server.go:2514 +0x144
net/http.serverHandler.ServeHTTP({0x1060b51c8?}, {0x1060b9440?, 0x1400338e000?}, 0x6?)
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/net/http/server.go:2938 +0xbc
net/http.(*conn).serve(0x14004396000, {0x1060bc8f8, 0x1400002c1b0})
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/net/http/server.go:2009 +0x518
created by net/http.(*Server).Serve in goroutine 7
	/opt/homebrew/Cellar/go/1.21.4/libexec/src/net/http/server.go:3086 +0x4cc

GUAC version
Guac v0.3.0

Looking at the stacktrace, looks like this is related to #1565 / #1606
When doing the backedge searching for verb queries, if the verb can be connected to either pkg-name or pkg-version the logic skips the backedge search most of the time.
For IsDep, it used to be only pkg-version for the pkg and pkg-name for the depPkg, so it would do the backedge search. I believe it is still trying the backedge search for depPkg, but is probably not correct somewhere.
To be like other verbs, we could remove the backedge search on depPkg for IsDep, OR we could figure out how to do the backedge search correctly on queries for verbs that have fields that can link to either pkg-name or pkg-version.

Hi @nathannaveen it looks like some fixes have been merged, can you see if you can reproduce this again?

Yes, the bug is fixed, I just forgot to close the issue.


Issues in Response

Hey,
This is regarding the daily backup and the issues is "I am not getting the Response object as they should be"
The two Response object I am getting is

BackupSummaries.
ResponseMetadata (Instead of LastEvaluatedBackupArn).

All the calculation is based on LastEvaluatedBackupArn response which i am not getting, Could you please help me out to identify the root cause for this issue?

I'm having the same problem!


Upgrade the template code snippets to v3.0.0 [Tutorial: Prepare to build a dApp]

The tutorial in "Prepare to build a dApp" section mentions "You should already have version v3.0.0 of the Substrate Developer Hub Node Template", but it seems the code snippets are still from v2.0.0 which are not compatible with v3.0.0 and makes the pallet template fail to compile for node template v3.0.0. Apparently the frame_system::Trait module has been renamed to  frame_system::Config in v3.0.0.

[ ] Are the audience and objective of the document clear? E.g. a document for developers that should teach them about transaction fees.
[ ] Is the writing:

[ ] Clear: No jargon.
[ ] Precise: No ambiguous meanings.
[ ] Concise: Free of superfluous detail.

[ ] Does it follow our style guide?
[ ] If this is a new page, does the PR include the appropriate infrastructure, e.g. adding the page to a sidebar?
[ ] Build the page ($ cd website && yarn start). Does it render properly? E.g. no funny lists or formatting.
[ ] Do links go to rustdocs or devhub articles rather than code?
[ ] If this PR addresses an issue in the queue, have you referenced it in the description?

As a note, with Substrate v3.0 we also introduced a new Macro Syntax: https://github.com/paritytech/substrate/discussions/7788
Documentation does not yet cover this, as it might require a bunch of work to fix up, but eventually we will use this for everything. You may notice some other PRs which are updating our existing pallets to use this new macro system. It is worth your time to learn this too, in addition to the old macro.


Multiple recipients from mail service

I'm trying to setup multiple recipients to the SmtpReceiverAddress, but none of comma, semicolon or space works for seperation. Is it possible to add multiple recipients, or is it locked to only one receiver as is?

I'm afraid it's not possible at the moment, but it shouldn't be too hard to change the code to allow this.

FYI, as of v<IP_ADDRESS>1 this is now supported.


Use os.stat to get the size instead of reading the file in memory

Here the entire file is read, that's a very expensive operation and can easily hit a MemoryError.
https://github.com/F5Networks/f5-common-python/blob/0a16f6e10b29ba3bca1f1dabf9a6f8f5b438296c/f5/bigip/mixins.py#L272
To get the size, it might be better off to do:
import os
def _upload(self, fileinterface, **kwargs):
        size = os.stat(fileinterface.name).st_size

Wanted to bounce this idea before I created a PR. Let me know if this fix makes sense, will create a PR for this.

@sanathkumarbs so long as it meets two requirements

does it return the same value
is it more performant (faster, less memory, etc)

if the above are true, send the PR.

@sanathkumarbs do you still need this if so can you send a PR ?


Ord: minimum / maximum

e.g.
const minimum = <A>(ord: Ord<A>): ((xs: NonEmptyArray<A>) => A) => NEA.fold(getMeetSemigroup(ord))

Like Haskell's minimum and maximum, but total.

https://github.com/samhh/fp-ts-std/commit/4cb4fbab65272d790e8749c7da0af8dca7c4b499

https://github.com/samhh/fp-ts-std/commit/4cb4fbab65272d790e8749c7da0af8dca7c4b499


Wasm bindgen tests in ci/cd

We currently have one wasm_bindgen_test: https://github.com/penumbra-zone/penumbra/blob/main/crates/wasm/tests/test_build.rs#L38C7-L39 that extensively tests the wasm-crate's build methods.
We additionally need:

Documentation. There appears to be a specific command needed to run this test: https://github.com/penumbra-zone/penumbra/pull/3407. We should add some background info + instructions on running this test in the wasm-crate's readme.
Add test to CI/CD. Upon pull requests, we should be running this test as well. This will need the addition of a new github action workflow file.

Additionally, implement assertion checks instead of manually comparing the equality of the transaction outputs as part of the CI/CD integration.


experimental_data_editor throws error with date column

Describe the bug
With the code below, I get the following traceback (which I can't seem to select to copy-and-paste, is this a known issue?)

Environment
{
"marimo": "0.9.8",
"OS": "Linux",
"OS Version": "<IP_ADDRESS>-microsoft-standard-WSL2",
"Processor": "x86_64",
"Python Version": "3.12.5",
"Binaries": {
"Browser": "--",
"Node": "v20.16.0"
},
"Dependencies": {
"click": "8.1.7",
"importlib-resources": "6.4.5",
"jedi": "0.19.1",
"markdown": "3.7",
"pygments": "2.18.0",
"pymdown-extensions": "10.11.2",
"ruff": "0.6.9",
"starlette": "0.39.2",
"tomlkit": "0.13.2",
"typing-extensions": "4.12.2",
"uvicorn": "0.31.1",
"websockets": "12.0"
},
"Optional Dependencies": {
"altair": "5.2.0",
"duckdb": "1.1.1",
"ibis-framework": "9.5.0",
"pandas": "2.2.3",
"polars": "1.9.0",
"pyarrow": "17.0.0"
}
}
Code to reproduce
import polars as pl
import marimo
from datetime import date

data_editor = marimo.ui.experimental_data_editor
df = pl.DataFrame({'a': [1,2,3], 'b': [date(2020,1,1), date(2020,1,2), date(2020,1,3)]})
data_editor(df)
# then, try editing a date

I accidentally introduced that bug selection prevention bug (fix in a PR).
I'll look at supporting dates


Week 1 - Containerized service is not available in this repository

Here is mentioned that containerized service is available for this repo, but the link leads to 404

Hi @seVladimirs I forgot to make the package public, totally my fault. Please go and try again!


vimix-gtk-themes: 2020-02-24 -> 2020-11-28

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/vinceliuice/vimix-gtk-themes/releases.
meta.description for vimix-gtk-themes is: "Flat Material Design theme for GTK based desktop environments"
meta.homepage for vimix-gtk-themes is: "https://github.com/vinceliuice/vimix-gtk-themes"
meta.changelog for vimix-gtk-themes is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/a712b6d6c2227db8426ba20760d8cdb3

du listing: https://gist.github.com/16d07916204b70970c71c31dd6e80457

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
vimix-gtk-themes

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/64mr2wjqzsvddaq0s7k2fhb8dzs6b6qs-vimix-gtk-themes-2020-11-28 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vimix-gtk-themes https://github.com/r-ryantm/nixpkgs/archive/e6af3bb5edb119defbda5a3d14ea118f897b8bbb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/64mr2wjqzsvddaq0s7k2fhb8dzs6b6qs-vimix-gtk-themes-2020-11-28
ls -la /nix/store/64mr2wjqzsvddaq0s7k2fhb8dzs6b6qs-vimix-gtk-themes-2020-11-28/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

vimix-gtk-themes

Maintainer pings
cc @romildo for testing.

Result of nixpkgs-review pr 105579 run on x86_64-darwin 1

1 package marked as broken and skipped:

vimix-gtk-themes


poor performance compared to simple size, head, tail and inode pre filtering

I have a 633.9GiB dataset in one fs and try this project on it. it looks it take more than 5 minutes ( I didn't finish it)
I write a simple single thread python script and just filter with file into (size, head bytes, tail bytes) then filter the same inode, there are only 9GiB files to do a full hash 🤔
Then I try this project, it seems that it need to hash 40GB files
INFO:pydupes:Size filter reduced file count to: 20 (40.2GiB)

Late response, but that log statement is only referring to the size filter, not necessarily what is hashed. I didn't add an explicit log on the sum of what needs to be hashed since that requires a pass over all the files to completed.


bug: import not resolved with edition = 2023_11

Problem
Compiling a simple project with a single Starknet contract fails due to an unresolved import.
scarb build
   Compiling yikes v0.1.0 (/Users/m/projects/tmp/yikes/Scarb.toml)
error: Item `yikes::interfaces::IERC20` is not visible in this context.
 --> /Users/m/projects/tmp/yikes/src/token.cairo:3:28
    use yikes::interfaces::IERC20::IERC20;
                           ^****^

error: Item `yikes::interfaces::IERC20::IERC20` is not visible in this context.
 --> /Users/m/projects/tmp/yikes/src/token.cairo:3:36
    use yikes::interfaces::IERC20::IERC20;
                                   ^****^

error: could not compile `yikes` due to previous error

Since the project is spread over multiple files, I've created a gist with all the relevant code. Hope that helps. This is the project structure:
.
├── Scarb.lock
├── Scarb.toml
└── src
    ├── interfaces
    │   └── IERC20.cairo
    ├── lib.cairo
    └── token.cairo

When I comment out the edition = "2023_11" directive in Scarb.toml, the project compiles just fine. Hence I'm not really sure if this is a Scarb of Cairo issue - please let me know if I should open a bug report in the Cairo repo.
Steps
No response
Possible Solution(s)
No response
Notes
No response
Version
scarb --version
scarb 2.6.3 (e6f921dfd 2024-03-13)
cairo: 2.6.3 (https://crates.io/crates/cairo-lang-compiler/2.6.3)
sierra: 1.5.0

Oh, I figured it out. It's because of missing pub modifiers 🤦


Remove redirects from chooser

The license chooser URLs for images link to an old URL that has since been redirected. For example, the CC BY-SA 4.0 license icon redirects from https://i.creativecommons.org/l/by-sa/4.0/88x31.png to the current URL, which is https://licensebuttons.net/l/by-sa/4.0/88x31.png.
We should update the chooser to output the new URLs since search engines may penalize URL redirects.
(this was reported in an email from a user sent to info@)

I would like to contribute to this issue.

Hello, Is this issue still open? I would like to work on this one.

@CapriciousRebel you are welcome to work on this, but we will be launching an updated version of the chooser very soon and this issue will no longer be relevant.