All Buttons requires double click to trigger click event

Problem description
When using any button component, safari only triggers the click event when I double click a button
Example
Here's my custom component:
const LinkedAction = () => (
  <FlatButton onClick={() => { alert('foo'); }}>
     Do Something
  </FlatButton>
);

Versions

Material-UI: 0.15.1
React: 15.0.1
Browser: safari 9 and saafari 9.1 tech preview

@aahan96 I updated the title and description, since this happens with all buttons, even when not using <Link />

If I replace onClick by onTouchTap, it works as expected (first click)
const LinkedAction = () => (
  <FlatButton onTouchTap={() => { alert('foo'); }}>
     Do Something
  </FlatButton>
);

Why did you close this? This should work with onClick as a normal button does. Using onTouchTap is kind of a hack.

Why did you close this?||Because you figured out what you were doing wrong. 😄

@luisrudge It is similar to the issue #4421. onClick doesn't work properly on Safari. It is not a MUI bug. There have been many posts regarding this issue. That's why onTouchTap is preferred on Safari. Most of the people have to do this work around

@mbrookes I'm not doing anything wrong. onClick is simply not working with MUI buttons.

@aahan96 well, onClick works great with the native <button />  component. How come this is not a MUI bug?

I came here to report the same issue, I just noticed this in Safari.
I've been wanting to phase out onTouchTap since the 200(?) millisecond delay after a tap is no longer an issue on mobile devices. It shouldn't take two clicks on (in my particular case) an IconButton to trigger an onClick.

Are there any news about this?

Same here. Can we reopen this issue? Why is this closed?

I'm using a RaisedButton inside the form, this might be a workaround, but you won't sacrifice the ripple and doesn't require extra efforts, I just put onTouchTap={()=>{}} in my RaisedButton attributes and it worked. I'm using "material-ui": "^0.15.4" and "react": "^15.0.0", hope this will help you for the moment

Yeah I'm running into this now on Google Chrome as well. Can we reopen this?

You can try with onMouseUp, it should avoid this bug.
plus, IMHO, It's more appropriate than onClick cause when you use onMouseUp, the event is fired only if user release the mouse over the button's zone which allow him to cancel his action just by releasing outside the button, UX things.
But onClick still need to be fixed

@sovanna thank you for the tip! I will use onMouseUp for now, but yeah, it will be nice to have onClick fixed.
Btw, maybe we can try to contribute and fix it by ourselves?

yep @riseremi, we can try :)

It would be good to re-open this as an issue that still needs to be fixed, encouraging others to step in and offer a PR. I feel that if you add an onClick function to a component, then it should be called when that component is clicked, consistently in all browsers.

Still not functioning as expected, should we open a new issue?

Just started running into this, do I really have to refactor everything for desktop + mobile Safari to use onTouchTap? Sigh.

this is bullshit. i am removing the package from my project

@timothyallan It is in the docs: http://www.material-ui.com/#/get-started/installation, and unless you're using notepad or textedit, your editor should have global search-and-replace:
[Shift-Command-F]
Find: onClick
Replace: onTouchTap
[Replace All]
Blam! 💥 Done. 🚀
And onTouchTap goes away in next. 🎉

Cool, thanks @mbrookes That's much nicer than saying RTFM :) Global search/replace isn't going to fly with this project unfortunately, so I'll start hunting them down... and then swap them back out after the tap event dependancy is removed!

I have this issue in Chrome also. onTouchTap is not an acceptable fix, as its avoiding the issue. If its a regular html button element its fine, but wrapping it in a React Component seems to cause the errors.

Is onTouchTap still needed at this point?

@ffxsam it works without the onTouchTap.
I am testing it on the latest beta of High Sierra's Safari

I'm getting some errors even with onTouchTap, a modal opens/closes, had to use onMouseUp

I also confirm the issue in all browsers with latest MUI on React 16, onTouchTap, onClick, and onMouseUp do not fix it.

Any news on this?

I found a solution to many of the issues with my mdl components (getmdl.io) was to simply review my usage of event.preventDefault() and to add:
componentDidUpdate(){
        try{
            window.componentHandler.upgradeDom();
        } catch (err) {
            console.warn('Attempted upgrade of DOM before ready!');
        }
    }

To any presentation component to restore the default JS behaviour.

The only way I can get consistent click behavior in Chrome, still, with Material UI 3.5.1 is to use onMouseUp on all my buttons. onClick requires 2 clicks.

I just used onMouseDown in React. It worked perfectly.

I just used onMouseDown in React. It worked perfectly.

Same for me thanks for the workaround.

It seems like this issue went away for me once I set the disableRipple attribute.

I have a theory:
if you click the button after clicking on anywhere in the screen... this issue does not happen
and it mainly happens with me in the login screen and forms.
based on it, I think that the issue is NOT in the button ... it's in the input fields. is seems to have some sort of built-in clickAway listener that when you do your first click, it captures the click.
I'm working on finding a workaround for this bug. if I find something better than what's above, I will update this comment

Facing same in chrome.

Facing same in chrome.

Is it something related when we are using the form ( using react-hook-form, the handler on onSubmit), because I have the same type=" button" i.e. cancel button which works fine on a single click, but when clicking on type="submit" button, it had to click twice.
Note: it's Dialog Component in which I am using this form.

Seem to be working on a single click,
I had to remove an extra validation which in result to extra click.
All good!!!

I was working today and encounter this problem, in my case if you're using something like formik o react hook form they render everytime when the input change. so create a new button, in my case i just wrapped my custom button with react.memo, hope this help to someone

This started happening again specifically in Firefox, Opera is fine. In particular, Firefox prints the following warning to the console on the first click:
Element.setCapture() is deprecated. Use Element.setPointerCapture() instead. For more help https://developer.mozilla.org/docs/Web/API/Element/setPointerCapture touch-simulator.js:219:19
Interestingly, when using the Firefox Devtools' Responsive Design Mode this isn't an issue at all, though the warning is still printed.

I'm also running into this issue with Firefox now. Does anyone have an actual fix for it, or is the only solution just accessibility-breaking changes?

try to memoize the button, maybe its rendering twice

FWIW, removing the ripple effect worked for me.

Still need to press icon buttons 2 times in some cases...


State list is empty

Hello,  the state filter cannot work because it can find no states. Roscd flexbe_states works.

I have also tried reinstalled FlexBE (the latest version),  but problem remains the same.  Available state and behavior is empty in Flex App. I don't known why. Please help.

Thanks in advance!

Is the workspace sourced in your bashrc? Does this also happen when your run
roscd flexbe_states
rosrun flexbe_app run_app -o  # in the same terminal

In general, the way that the FlexBE App looks for state packages is the same that is used for roscd, so I am not sure what might be the problem here. The only difference is that only ROS packages which export "flexbe_states" in their package.xml are listed.

I once had a similar "states not found" issue after I changed the catkin package name of a flexbe states package. Everything worked fine again after I changed the name back.
To my understanding this happened, because the python module path was different from the catkin package name of my state package and this code relies on them being the same:
https://github.com/FlexBE/flexbe_app/blob/master/src/ros/ros.js#L108

That's an interesting observation and could indeed be related. I will look
further into this.

The workspace is sourced.  This also happens when I follow your steps.

I uninstalled ubuntu16.04, installed ubuntu18.04 and ROS melodic, now flexbe state is all right.

Well, I will leave here my query and also my answer to the problem about this issue.
In melody is working fine. But my goal was to run it in Kinetic. I tried my best to just run the example behavior, but it said that it is unable to find state definition for;
LogState
and WaitState,
If you have any solution about this problem, I would be more than grateful.
//////////////////////////////////////
Answer
////////
Clone the following repo
flexbe_app
flexbe_behavior_engine
generic_flexbe_states
Create a demo using:
rosrun flexbe_widget create_repo ur_robot
Install ros packages by:
sudo apt-get install ros-kinetic-flexbe-*
And finally
roslaunch flexbe_app flexbe_full.launch
With those steps I was able to use the example behavior in order to test the installation. The goal is to use FlexBe in kinetic since the following

state :
https://github.com/CNURobotics/flexible_manipulation
seems to be suitable for my application. I did try with melody, but i could not compile successfully since it is developed in ROS kinetic.
Best regards,
Cesar

Still not sure what could be the issue for not finding states in kinetic...
Regardless of this, @Sinchiguano I would recommend you to use melodic if possible. @dcconner any idea why flexible_manipulation would not work in melodic?

In case it happens again to someone that no state definitions are found, can you please try the following steps:

Make sure that the FlexBE App is on the latest version, preferably checkout the develop branch
Go to "Configuration"
Select the "Python" state parser
Click "Force Discover"
Let me know what happens

I had a similar issue where FlexBE couldn't find the states provided by the flexbe_behavior_engine/flexbe_states package. States provided by other packages (e.g. generic_flexbe_states) were found. The suggestion in https://github.com/FlexBE/flexbe_app/issues/42#issuecomment-581047186 solved the issue.

We will be releasing a melodic version of the flexible_manipulation package in the next week or so.  Apologies for missing the earlier tag.
Making note of above comment about need for catkin package and module names to be the same


Stuck at ==> default: Ign http://archive.ubuntu.com trusty/universe Translation-en_US

Hi,
I'm using Vagrant on Windows to install Portia
But it always stuck at ==> default: Ign http://archive.ubuntu.com trusty/universe Translation-en_US
I've left it for 3 hours and it's still not working
Any idea how to bypass the error?

I've just run:
git clone git@github.com:scrapinghub/portia.git
cd portia
git checkout develop
cd portiaui
npm install && bower install && ember build
cd ..
mkdir -p data/projects
vagrant up

Everything works as expected when I visited <IP_ADDRESS>:9001


Run only the "live" tests on a scheduled basis

Some of the tests do not consume live data from the web. Therefore, there is no reason for running them without a code change.

[x] #137
[x] #138
[x] #139
[x] #140

All done - just check tomorrow that #144 works and close the issue.

Works as expected:
https://github.com/jond01/xil/actions/runs/6684102920/job/18161012544


Hero image options won't take effects

admin -> site -> pages -> home -> theme -> hero image options
Whether to check any of checkboxes in there (Full viewport height, Invert colors....), none of them is taking effect, checked console, the proper classes are not added in the rendered html.
change to another background image is OK, only those 4 options won't work.
cache disabled and cleaned

Hi,
Do you have a widget defined for this page on the hero position ?

yes, the widget and hero actually is there, but rendered as by default options, no inverted color, normal height, etc., checked the rendered html code, the proper classes have not been added, like uk-height-viewpoint, uk-text-invert....

Yep, i can confirm this @	0.11.2
There must be an error somewhere!
I'm not familar with the structure and building mechanism... but, i found some problems.
Nr. 1: set a hero-image => $event['hero_image'] in Theme-index.php is not set / empty!
Nr. 2: select any checkbox you want => $params['classes.navbar'] / $params['classes.sticky'] in Theme-template.php is not set / empty!
It seems, that the ACP Config doenst get to the index, the index isnt reading that values and the default values from the index arent available at template.php...
I found the Problem, because the navbar doenst get the class and stickys.
Then, i tried the Hero Thing and that doesnt work, too!

Are you using version 0.11.0 of the One-Theme (must be updated separately)?

Ah... It works ;)
The Source of the Problem was, that the Repo Error blocked the Update Button at the Theme-Settings... There was no Info about an available Update...
With a short look in the gitter chat, i found the answer for that... and then, everything starts working again!
Thank you!

@DarthDestroyer could be where the problem is, thanks, will be keep informed if the problem still there in v1.0


JSX let foo=<div /> doesn't parse

It needs to have a space between = and <.
Related: #856

I think this might be okay for now. (Or at least fixing it may not be worth the trouble in the short term as long as we can get a better error message from mernhir).

Bumping this because this means you can't pass them as props
<Foo bar=<Baz /> />


[html] auto close add > after /

ISSUE:
Currently VSCode do provide auto closing tag support but we can make it better.
LIke currently open any HTML file. If I write <img/ -> then it should autocomplete that to <img/> but it does not. Else autoclosing is nice.
Major IDEs provide this feature and it really helps code faster.
Does this issue occur when all extensions are disabled?: Yes

VS Code Version: latest 1.77.3
OS Version: windows 10

I implemented that and tried it out.
The problem is with users that don't expect the feature. They still type > and end with two >>. We can try to detect that, but currently don't have a way to undo or to intercept the user typing.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

I implemented that and tried it out. The problem is with users that don't expect the feature. They still type > and end with two >>. We can try to detect that, but currently don't have a way to undo or to intercept the user typing.

Users don't expect the feature bevause it is currently not there. It is there in Webstorm and users know it is there. These are just small things that editor should do for us instead of us manually. Of all the cases I know, everyone will use > after a / for closing tag. Then why do it manually everytime. You can make it an optional feature in insiders build. But please just test this out.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Automatically refresh when change in file(s) are detected?

I use http-server for local development and love it. Just wondering if there are any plans to have it automatically reserve files in which a change is detected. Not a major issue, just a question/enhancement request.

It seems this will only possible by either injecting a client-side script into all html pages or requiring the installation of a browser extension.

Some documentation about restarting http-server on file change may be added by #527

Since there's no server-side cache, this is already supported. Please re-open if this isn't the case.

Maybe @alexkolson thinks about live reloading/refresh browser ?  (on file change)
(my answer is more a missing feature, than an issue)
I use an othe npm package as a live watcher (and proxy)
browser-sync start --proxy "<IP_ADDRESS>:8080" --files "."
If is not what you searching, sorry for reopening
thanks


add munged income data as json file. add server route /zip/:code to acce...

...ss this data by zipcode

Looks good


Add @muxi and @makdharma as owners of ObjC related files

Please run tools/mkowners/mkowners.py to satisfy sanity (would be great if you could merge #11826 beforehand, since that PR is actually needed for this to work)

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

#11826 is now merged: you should be able to sync to head and run the tool to update this such that sanity will pass.

Looks like this is triggering a mkowners bug... will fix and figure out how to integrate.


Style/SymbolArray autocorrect breaks :[]

here's the diff resulting from the autocorrect:
-      direct_access_methods = Enumerable.instance_methods + [ :[], :each, :each_index, :empty? ]
+      direct_access_methods = Enumerable.instance_methods + %i{\[\] each each_index empty?}

and those expressions are not equivalent:
% pry
[1] pry(main)> [ :[], :each, :each_index, :empty? ]
=> [:[], :each, :each_index, :empty?]
[2] pry(main)> %i{\[\] each each_index empty?}
=> [:"\\[\\]", :each, :each_index, :empty?]

% NOEXEC_DISABLE=1 rubocop --version
0.72.0

not entirely unsurprisingly :[]= also gets broken.

I cannot reproduce by the default settings. Could you show a .rubocop.yml for this auto-correct?

I'm using rubocop --only  Style/SymbolArray so I don't think the contents of the .rubocop.yml matters?
The contents of the .rubocop.yml though is:
llCops:
  Exclude:
    - "spec/data/**/*"
    - "vendor/**/*"
    - "pkg/**/*"
    - "chef-config/pkg/**/*"
    - "habitat/**/*"
Security/Eval:
  Enabled: false
Lint/UselessAssignment:
  Enabled: false
Lint/DeprecatedClassMethods:
  Enabled: false
Lint/ParenthesesAsGroupedExpression:
  Enabled: false
Lint/AmbiguousRegexpLiteral:
  Enabled: false
Lint/AssignmentInCondition:
  Enabled: false
Lint/AmbiguousBlockAssociation:
  Enabled: false
Lint/UnneededSplatExpansion:
  Enabled: false
Lint/ShadowingOuterLocalVariable:
  Enabled: false
Lint/EmptyWhen:
  Enabled: false
Lint/IneffectiveAccessModifier:
  Enabled: false
Lint/ShadowedException:
  Enabled: false
Layout/AlignHash:
  Enabled: true
  EnforcedLastArgumentHashStyle: ignore_implicit

I can reproduce it with a configuration of Style/PercentLiteralDelimiters cop.
Style/PercentLiteralDelimiters:
  PreferredDelimiters:
    default: '{}'

I guess you have the cop's setting in some .rubocop.yml.
Can you confirm your .rubocop.yml? You can use rubocop --debug to display configuration files that are used by rubocop. I guess it includes another .rubocop.yml.

yeah, i just figured out the same thing.
i don't quite understand how it was picking it up but:
Style/PercentLiteralDelimiters:
  Enabled: true
  PreferredDelimiters:
    '%':  '{}'
    '%i': '{}'
    '%I': '{}'
    '%q': '{}'
    '%Q': '{}'
    '%r': '{}'
    '%s': '{}'
    '%w': '{}'
    '%W': '{}'
    '%x': '{}'

Actually its possible I ran that in isolation with --only and then saw the %i[]s were added and then fixed the PercentLiteralDelimiters with a global run with autocorrect on against those rules.  Although one way or another there's an autocorrect bug here, possibly two, since when the PercentLiteralDelimiters change any escaped old delimiter should become unescaped.

This is actually a problem in Style/PercentLiteralDelimiters and relates to https://github.com/rubocop-hq/rubocop/issues/4363. The fix back then only covered the %w case correctly, but not %i.
I can reproduce the problem using the input
%i[\[\] each each_index empty?]

with this configuration:
Style/PercentLiteralDelimiters:
  Enabled: true
  PreferredDelimiters:
    '%i': '{}'

I am going a add a PR for fixing this in a minute.


Issue with latest version on 1.21.1 neoforge

https://mclo.gs/NoXT8Sc

welp that was not intended... I'll find a way to fix it, although it may take a few hours

alright

It did not take a few hours. The fix has just been released on curseforge, modrinth and github

Alright,ty!


exclude tests from liberty

@pjbreaux
What issues does this address?
Fixes #518
What's this change do?
This change will create a new exclude directory that has yaml file for list of exclude tests for each target. Name of the symbol file get passed as an argument to run_neutron_lbaas script.
Where should the reviewer start?
Starting from systest/Makefile you can see all the yaml files' names were added for each target. Then in the exclude dir there is a file with the same name specified in the make file. Then Makefile will call run_neutron_lbaas script and passes the exact file name for test exclude list to --meta option.

After chatting with matt, I think there are a few more tests to exclude in overcloud. These are all the scenario tests in l7, but that will only be applicable on the mitaka branch. So we can merge this change in here, and when we merge up to mitaka, we can exclude the l7 and esd scenario tests.


Fix error catching

SDK was not showing errors correctly.
Now errors are logged in the console
when HTTP status is 4XX (Client Error).
Other minor changes:
-Update gradle version
Trello: https://trello.com/c/6cIC2ofP/813-1-5-android-sdk-maintenance

Looks good.

Thanks! I'll merge and release tomorrow first thing in the morning...


Replace deprecated command

Command az appservice web create is deprecating and will be removed
in future releases. Use 'az webapp create' instead according to cli warning.

@simonaco,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@rick-Anderson Please review these proposed changes. Thanks.

#sign-off


[DO NOT MERGE] New blog about features

What are you changing in this pull request and why?
Migrate blog over to git/Markdown per slack thread
Reach out to @nghi-ly for merging details.
Checklist

[x] I have reviewed the Content style guide so my content adheres to these guidelines.
[x] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.

ADDING new blog page:

[x] Provide a unique filename for new pages

There are a couple of back-to-back sections that begin with "Now that we've...". Since these appear to be steps in sequence, it may be beneficial to the reader to present them in a numbered order.
1. ABC
...
5. XYZ


Removing border_radii in custom child module

Problem Description
I'm making a module which needs to have a option for border styling, so I used the advanced border field. However I don't want to give the user a option to define a border radius. Is there a way to disable this option, like the use_background_image for example? I couldn't find this option myself.
If there is no such option I would recreate the border styling myself. But I can't seem to use icons from the border styles tab. Like this example from Border.php file for example 'icon' => 'border-top'. Now I know that some icons in tabbed subtoggles need this line of code: 'bb_icons_support' => true. This however does not seem to work for the border icons. If someone knows more about this it would be much appreciated.
Also I'm working in a child-module.
Screenshot and/or gif

It also looks like $this->advanced_fields = array('border') in the child module takes the parameters of its parent module as default, even if there is a default defined.

I believe there is currently no setting to disable parts of the border settings as it is possible with other settings. You could however simply build your own composite setting to only show a color field, a width range slider and the type of the border

Thanks for the reaction. And I already did.


New command: spo file version remove

Usage
m365 spo file version remove [options]
Description
Removes a specific version of a file
Options

Option
Description

-w, --webUrl <webUrl>
The URL of the site where the file is located

--versionLabel <versionLabel>
Version label of version which will be removed

-u, --fileUrl [fileUrl]
The server-relative URL of the file to retrieve. Specify either fileUrl or fileId but not both

--fileId [fileId]
The UniqueId (GUID) of the file to retrieve. Specify either fileUrl or fileId but not both

--confirm
When specified do not prompt for confirmation

Examples
Removes file specified version from version history by file id
m365 spo file version remove --webUrl https://contoso.sharepoint.com/sites/project-x --versionLabel "0.1" --fileId 'b2307a39-e878-458b-bc90-03bc578531d6'

Removes file specified version from version history by file url without confirmation
m365 spo file version remove --webUrl https://contoso.sharepoint.com/sites/project-x  --versionLabel "0.1" --fileUrl '/sites/project-x/documents/Test1.docx' --confirm

Additional Info
we may reuse spo file get command with asListItem option to get the item id and then we may use the following to remove by label (endpoint fill with test data)
/_api/web/Lists/getbytitle('Documents')/items(18)/versions/DeleteByLabel('1.0')

@pnp/cli-for-microsoft-365-maintainers  any comments?

Looks good to me 👍

When using api api/web/Lists/getbytitle('Documents')/items(18)/versions/DeleteByLabel('1.0') it results in an error message stating Cannot find resource for the request DeleteByLabel
the correct api for deleting a version is /_api/Web/GetFileByServerRelativePath(decodedurl='/Shared Documents/Document.docx')/versions/DeleteByLabel('1.0')

Thanks @nicodecleyre for the double check 🤩.
I missed the file in my endpoint. I will correct the spec

One small remark is that versionLabel should be called label according to our naming convention.

One small remark is that versionLabel should be called label according to our naming convention.

Thanks for the reminder 👍.
I updated the spec here as well

Opening this up 💪

Can i work on this? :blush:

Can i work on this? :blush:

All yours 👍


[CamModels] Add extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests: Searching for "cammodels" repo-wide yielded no code or issue results
[x] Checked the code with flake8: Yes, on Python 3.6. Do I need to run it on other versions too?

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Extractor Info
Adds a new extractor for CamModels.com streaming video. Golden path example for a live stream:
$ python3 -m youtube_dl -F https://www.cammodels.com/cam/AutumnKnight/
[CamModels] AutumnKnight: Downloading webpage
[CamModels] AutumnKnight: Downloading JSON metadata
[info] Available formats for AutumnKnight:
format code  extension  resolution note
256          flv        256x144     160k video@ 111k, audio@ 49k
654          flv        654x368     782k video@ 700k, audio@ 82k
1280         flv        1280x720   1736k video@1657k, audio@ 79k (best)

Current Limitations
I left the test case _TEST commented out. If you uncomment it and run python3 test/test_download.py TestDownload.test_CamModels, it passes vacuously, similar to the (useless) test code in chaturbate.py.
Suggestions on how to meaningfully end-to-end test a streaming service where streams may or may not exist at a given time would be appreciated!

Read

adding new extractor tutorial and youtube-dl coding conventions sections

and fix all issues.

@dstftw

Deleted the useless test
Deleted the optional metafields (ext and age_limit)
Made all regex searches non-fatal, with appropriate ExtractorErrors being thrown
Added fallback logic for parsing out video links using regexes, in the event they change their JSON response schema

@dstftw I think I've fixed your review suggestions? For the headers question, I added a code comment explaining that their servers reject requests when a common User-Agent isn't supplied.


basho-patches

Some riak_test tests (e.g. ensemble_remove_node - https://github.com/basho/riak_test/blob/develop-2.9/tests/ensemble_basic2.erl) require a patch that survives restart using rt_intercept:add_and_save/2.
This add and save uses the basho_patches folder, which is required to be in the code path of the node.  However this is no longer in the code path in develop-3.0.
The mkdir command in rebar.config https://github.com/basho/riak/blob/8a257eea9c5cd351aea41d0e59bf1b7149f52cd0/rebar.config#L76 has been switched to riak-patches.  However, although switching that back to basho-patches will create the path in make devrel, it will not add the path to the code_path (i.e. if you start a node and then call code_get_path() from riak remote_console it is not included).
Is this a relx issue?
@martincox might you be able to take a look?

@martinsumner it's a side effect of moving away from the runner in node_package. It's on my todo.

Sorry, what's the official stance on this? I find code in 3.0.1 referring to basho-patches in riak-admin and riak-debug but the installed directory is only called lib/patches and I am not seeing a lib/riak-patches folder anywhere. If somebody can confirm what the official name is, I'm happy to update the above two files in /rel/files/bin/ to use the right name.

https://github.com/basho/riak/pull/1089


Revert "Changes for RemoteID and RemoteIDType (#19)"

This reverts commit<PHONE_NUMBER>fdc4fdf13aee9391ccd80b17fff9bb.
Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Manually updated database schema to make this work w/o reverting the commit for the related PR.


Feature/Use custom patterns url

I recall reading somewhere that the future goal of this container is to download a tar/zip file of configuration but wasn't sure if that was going to include custom patterns or how far down the track that change will be.
For the time being I have added the mechanism to pull in a custom pattern file which get stored in /opt/logstash/patterns/custom similar to how the logstash.conf is pulled on container run.

@aidan- thanks for this PR. I appreciate it. You're right about a future goal being a more robust way of managing logstash config files. The proposal is in issue #49. It is pretty hot for me and at the top of my to-do list. I am working on it now.
The way that feature is going to work is any asset (*.tar, *.war, *.git, etc) passed to LOGSTASH_CONFIG_URL will be downloaded and stored in /opt/logstash/conf.d. Correct me if I'm wrong, but, based on your PR, /opt/logstash/conf.d isn't the conventional location to store custom pattern files.
One thing you mentioned in your comment was your PR possibly being a temporarily solution while the bigger config feature is fleshed out. Is not having the ability to store patterns a blocker for you currently? If it is, then we can work towards getting it pulled in. If not, it might make sense to work through the bigger config management feature.

Correct, generally patterns are stored in /opt/logstash/patterns (where my PR puts the custom file) rather than the conf.d directory.  However, the Grok filter allows you to define a patterns directory as one of its options (see grok#patterns_dir) so you could include custom patterns in the future asset archive functionality and just ensure the logstash config glob excludes those files (eg, --config /op/logstash/conf.d/*.conf).
I only referred to my PR as a possible 'temporary' solution as I was not sure what scope the future config archive feature was going to cover or how far away it was.  For me personally, a custom pattern feature is critical so we have been building a modified container with this PR applied to fill our requirements.

@aidan- now we're getting somewhere. I think optionally including a patterns directory in the assets downloaded from LOGSTASH_CONFIG_URL will work really well. Additionally, the downloaded directory could include inputs, outputs, filters, etc.
I started a logstash-configs project last year for testing config downloads. That project can be used to test this new functionality.
I created a feature/config-download-refactor branch last night to track this feature. I'll merge in what I have so far either tomorrow or this weekend and we can see how far that gets us.

@pblittle sounds good.  I will have a play/test once the changes have been merged in.

@aidan- I haven't forgotten about this feature. It's up as soon as I ship #58.

@aidan-, sorry, I thought I left a comment in your PR. This functionality should be taken care of in the 0.16.0 release. You can find the implementation details in the documentation.
I'm going to close this PR for now. Please reopen or create a new issue if this doesn't fit the bill. Thanks again for your original PR that inspired this feature. I appreciate it.


HEAD response can include Content-Length header

StaticFiles tests are failing because of this.
@halter73 @mikeharder @Tratcher

:shipit: b


Adds missing files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 59 (38.98%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.7%) to 27.668%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/intent.go
2
10
20.0%

background/notes.go
0
28
0.0%

Files with Coverage Reduction
New Missed Lines
%

background/notes.go
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.7%

Covered Lines:
407

Relevant Lines:
1471

💛  - Coveralls


Improve metric rendering graph

...drop in the metric values is a misunderstanding of the data shown ...

I would like to propose a way to prevent this misunderstanding from occurring, at least partially:

visually show that this segment is incomplete
so no-one would misunderstand it for complete and freak out
render an approximate "forecast" value
2 min passed of 5-min grain? forecast that sum be 2.5x of what you measured so far

It wont fix 1-min grain on 5-min collectors, but everything else will look less dramatic.
It also partly compensates for you other implementation shortcoming of feeding logs in (long) intervals rather than "as you go". For contrast, none of this happens on any metric graph in GCP, and data is available seconds after the fact. So I believe you can show graphs well too. 🚀
Looking forward to discuss and brainstorm together. 😉

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a821027e-7ff2-4053-dee2-983656ff915b
Version Independent ID: 56805e6c-5c17-526a-775e-32c10e05206d
Content: Troubleshooting Azure Monitor metric charts - Azure Monitor
Content Source: articles/azure-monitor/essentials/metrics-troubleshoot.md
Service: azure-monitor
Sub-service: essentials
GitHub Login: @vgorbenko
Microsoft Alias: edbaynash

@Tbohunek
Thanks for your feedback! We will investigate and update as appropriate.

Hi @Tbohunek,
We appreciate your insights and help in improving the product.
I'm closing this issue here as I have opened an internal work item to suggest this change.
#please-close

#please-reopen

#please-close

Was anything done to reduce customer confusion? Looks like a no. :(


SystemJSBuilder lazy loading config

Hi everyone,
First of all thanks for the great work, i was searching for a starter with gulp in mind and this one is very good.
I had a review of what the seed currently provides, and i didn't find any configuration about SystemJSBuilder working with lazy loaded component routes. So I gave it a try but i'm currently stuck on this (it's working well with dev config and SystemJS).
Is there any plan to include a config related to this feature or any guidelines in the wiki?
Such a thing would IMHO help using the full features of the current angular router.

You can take a look at already closed issues related to this question. The seed doesn't officially support lazy loading, although a lot of people have already used it in production.
Implementing lazy loading which works in the general case (for all users) is not a trivial task with the current toolset available. Although I have implementation in a fork of the seed for a project that I'm working on, I'll prefer to not push it in the seed. You can find it in a discussion here.

Thanks for the quick feedback i'll take a look at that

plz your problem is resolved. I have same help


Huge Memory Usage & Memory Leak on .NET Core version

Describe the bug
It looks like https://github.com/AvaloniaUI/Avalonia/issues/3983 is not fixed and the problem is still available in the latest avalonia version (0.10.0)
Quote from issue 3983:

My simple window with no logic at all went from ~150 MB in idle (which is still more 3x what a comparable Electron project uses), to ~ 450 MB after resizing.
A simple window in 0.9.x used ~ 16MB on my system for comparison, which I think is great. However the memory usage in the previews is clearly unacceptable...

I would like to add some points of clarifications - this issue only presents if you target .NET Core and not presents on .NET Framework.
This bug is also presents on .NET Core WPF.
==============
I've prepared a Test solution and added 6 empty projects there (4 for Avalonia and 2 for WPF).
For all Avalonia projects I used AvaloniaApp Template from https://github.com/AvaloniaUI/avalonia-dotnet-templates/ and changed target framework for other 3 projects.
Also I've created WPF .NET Framework 4.8 and WPF .NET 5 apps.
Here are the tests of their memory usage (I've used https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer for it)
Avalonia IDLE

Avalonia after resizing

Notice, that after resizing apps usually grows in memory up to 5 times (500+ mb) and after few seconds reduced to ~200 mb
For example, WPF:
WPF IDLE

WPF After Resizing

So, as you can see, when you target your Avalonia App (or even WPF app) to any version on .NET Core(didn't test versions before 3, btw), it takes up to 3 times more memory and leads to extra memory leaks when user resize a window.
I've attached the testing solution with projects to this issue.
AvaloniaTest.zip
To Reproduce
Just open projects from my example solution and check its memory usage.
Or create new Avalonia project using template in the link above.
Desktop (please complete the following information):

OS: Windows 10
Version 1909

@AnImperialMan thanks, we have been chasing this for a long time, and never realised what you found that, only .NET Core / 5 and that WPF is also affected.
I wonder if WPF repo has any issues opened for this. Id imagine the root cause may be similar.

Feel free to file an issue against dotnet/wpf or dotnet/runtime 🙂

It looks like adding this to AppBuilder solves the problem

            .With(new Win32PlatformOptions
            {
                AllowEglInitialization=false
            }

It hides the problem because the issue is related to GPU rendering.

@AnImperialMan can you also add the repro code to the WPF issue I have opened here.
It seems that there may be some kind of way that .net core is configured or optimised in terms of memory allocation that could be causing this.

@EgorBo filed against dotnet/wpf

@EgorBo filed against dotnet/wpf

you can also try to create issue on dotnet/runtime if you want

I've tested the AvaloniaNet5 repro on my Windows 8.1 PC, on start the app uses 52MB and resizing it actually brings that down to 30MB. (I'm using the latest 5.0.201 x64 SDK). With WPF5.0 it starts at 37MB and slightly grows to 44MB on resize.

@MichalPetryka possibly its dependent on what graphics card... did you use process explorer to check the memory or task manager?

@MichalPetryka possibly its dependent on what graphics card... did you use process explorer to check the memory or task manager?

More likely its dependent on OS. Can someone with Win 8.1 or Win7 try to test it?

@MichalPetryka possibly its dependent on what graphics card... did you use process explorer to check the memory or task manager?

I've used an AMD GPU and Task Manager, but I've also tested ProcessExplorer and JetBrains dotMemory now and got some interesting results:
Avalonia task manager on start:

Avalonia task manager after resize:

Avalonia process explorer on start:

Avalonia process explorer after resize:

Avalonia dotMemory on start:

Avalonia dotMemory after resize:

And as I suspected, the decrease is caused by the GC getting triggered:

WPF task manager on start:

WPF task manager after resize:

WPF process explorer on start:

WPF process explorer after resize:

WPF dotMemory on start:

WPF dotMemory after resize:

And whats interesting, a resize also causes a GC there, but it actually doesn't decrease the total usage:

TLDR Process Explorer and dotMemory give noticeably higher values and the tell us that WPF has practiacally no change on resize.

@MichalPetryka possibly its dependent on what graphics card... did you use process explorer to check the memory or task manager?

More likely its dependent on OS. Can someone with Win 8.1 or Win7 try to test it?

Yeah I'd also assume so, the only issue with testing is that iirc AllowEglInitialization is false by default on Windows 7 and true on 8, 8.1 and 10 so testing 7 would require some configuration changes.
I'd try it on my Win 10 laptops but I currently don't have dotMemory installled on them.

Tested on a Win 10 2004 x64 laptop with a Nvidia GeForce 940MX, the issue also doesn't reproduce there, with both Avalonia and WPF. Maybe it's fixed in the latest .Net 5 build?

Tested on a Win 10 2004 x64 laptop with a Nvidia GeForce 940MX, the issue also doesn't reproduce there, with both Avalonia and WPF. Maybe it's fixed in the latest .Net 5 build?

Try to test in on .NET Core 3.1 also
Btw, my GPU is GTX 1660 Ti and CPU is Ryzen 5 1600X. My colleague GPU is Gtx 1080 Ti. We both have this issue.
And no, I've just tested on the latest .NET 5 SDK (5.0.201) and the bug is still reproducable

Tested on a Win 10 2004 x64 laptop with a Nvidia GeForce 940MX, the issue also doesn't reproduce there, with both Avalonia and WPF. Maybe it's fixed in the latest .Net 5 build?

Try to test in on .NET Core 3.1 also
Btw, my GPU is GTX 1660 Ti and CPU is Ryzen 5 1600X. My colleague GPU is Gtx 1080 Ti. We both have this issue.
And no, I've just tested on the latest .NET 5 SDK (5.0.201) and the bug is still reproducable

Same behaviour on both Win 8.1 and 10 with .NET Core 3.1. Also, I've noticed that the laptop actually runs the app on the Intel iGPU and for some reason refuses to use the Nvidia one even if i set it in both system settings and Nvidia panel.

Tested on a Win 10 2004 x64 laptop with a Nvidia GeForce 940MX, the issue also doesn't reproduce there, with both Avalonia and WPF. Maybe it's fixed in the latest .Net 5 build?

Try to test in on .NET Core 3.1 also
Btw, my GPU is GTX 1660 Ti and CPU is Ryzen 5 1600X. My colleague GPU is Gtx 1080 Ti. We both have this issue.
And no, I've just tested on the latest .NET 5 SDK (5.0.201) and the bug is still reproducable

Same behaviour on both Win 8.1 and 10 with .NET Core 3.1. Also, I've noticed that the laptop actually runs the app on the Intel iGPU and for some reason refuses to use the Nvidia one even if i set it in both system settings and Nvidia panel.

it may be related to NVIDIA only so. Need to more people with NVIDIA and AMD to approve or reject this theory...

Hello,
My SDK is dotnet 5.0.202 and I'm talking about the repro.
First, I'll try to help you with my situation, a PC with integrated GPU (Intel 630) and discrete GPU (NVIDIA GTX 1050)
I don't have any memory leak with both graphics cards, but I noticed the ram usage with
dotnet publish -c Release

Intel 630: 100 MB
Nvidia: 50 MB, when spamming resize, it increases until 62MB and that's all, no more

Now, I'd like to give more informations on RAM depending on the build flags. (obtained with Intel 630, the "faulty ?")
dotnet publish -c Release

100 MB RAM usage

dotnet publish -c Release -r win-x64 --self-contained=false

54 MB RAM usage

dotnet publish -c Release -r win-x64 --self-contained=false /p:PublishReadyToRun=true

37 MB RAM usage

I hope these informations (if you didn't already know that) will help you.
Regarding interpretations,
I guess the lib is using the same backend as .NET Framework (4.8) when a RID is specified (especially win-x64, since Framework can only target Windows)
Ready2Run improves a lot the startup time (dropping it from 2.5 sec to ~1 sec)
Furthermore, I didn't really check, but publishing in Single File (with extraction or not, without self contain) doesn't decrease startup time, it seems to even improve it (but well, it'd be strange)

I noticed the memory issue was well, but was also wondering about the CPU usage.
With the basic/empty "app" template, and disabling EGL/GPU, I found the CPU usage to constantly be at 7%.
With EGL/GPU enabled, it was ~1.5% constantly with the increase in intel_gpu_top going from 7% (idle) to 21% (running enabled, compared to 18% running with EGL/GPU disabled).
For some reason, it would seem there's constant rendering going on.

I have noticed that this UnManaged memory keep on adding and never getting release. Even though I have implemented IDisposable in both User control and ViewModel.
If we Navigate between two views (user control) memory going up in MB, sometime 2 MB.
Another observation is that a open ComboBox and memory going up by Mbs.
I am not sure why GC.Collect() not freeing memory even after explicit call.

Hello, is this issue still happening on .NET 6 and 7?


i- prefix

All,
Jim started a conversation on debugle about the i- prefix. I took what Jim sent and made several changes to the webpage:

Under the DOSUUB tab, we added https://tekinged.com/gramma...
We added the 'i-' prefix as a word you can lookup: https://tekinged.com/?looku...
Both the above links also include a link to an audio recording of Masaharu Tmodrang and Jim Geselbrecht discussing this very topic: https://tekinged.com/mp3s/i...

Jim, I think it is probably always a prefix and the usages as a suffix are just incorrect spellings. As we know, Palauan vocalization tends to blend sounds and Palauan speakers often move letters from one word to another when they write Palauan. Therefore I did edit your text a bit to make it only a prefix.

Jim,
I would love to link to your individual songs on this page: https://hellaholler.com/ouchacha/PalauanSongs.html. Can you add anchors so I can link directly to the songs like 'Doki Doki' please? That'd be awesome.


The dlv will hang when input "step" command at the beginning of debugging.

What version of Delve are you using (dlv version)?
# dlv version
Delve Debugger
Version: 0.11.0-alpha
Build:

What version of Go are you using? (go version)?
go version go1.6.3 linux/amd64
What operating system and processor architecture are you using?
linux/amd64
What is the problem?
When debugging a program, if press s directly, the dlv will hang there, like this:
# dlv exec ./swarmd
Type 'help' for list of commands.
(dlv) s

Maybe it is better to prompt something instead of hanging.

#603 should improve this.

This doesn't happen anymore, the behavior of step/next/stepout may be counter-intuitive, but it is correct.


A List of Questions and Quick Observations for JobSet

Hiya! I'm using JobSet in the Flux Operator, and have some discussion / feedback:
NonIndexedJob should support headless service
I'm creating a design with a leader and workers (a listing of two under the JobSet) and for the leader, I wanted to generate the headless service. But it gave me an error early on that I needed to use an IndexedJob. Is there a reason to not be able to create the service for a non-indexed job?
Pod names are long bois
The names for the pods for the jobset are really long! The shorter ones for just having an indexed job are really much nicer to look at / query (e.g., flux-sample-0-xxxx) - could there be some way to reduce the length of the name? I would suspect it's about namespacing it to the jobset -> replicatedjob -> job but it's coming at the cost of the user experience I think.
Creation time is slow
I'm not sure why, but I noticed that the time that I apply the minicluster.yaml (that creates the jobset) to then see the pods appear is fairly long, at least longer than if I just created the Indexed Job. This could just be an artifact of needing to use JobSet from a separate operator... or MiniKube being slow again (my computer is burning my legs right now so it might be that too!) :laughing:
Suspend makes it hard to debug
When I started with suspend: true I never saw any pods, and I think this is because it fails the JobSet on any failure. We might eventually want this to Complete pods, although with the new design we probably don't need it anymore. I'll leave it off for now because I didn't like my JobSet suspending without me being able to debug!
Networking - allow me to set (shared) name?
It would be nice if two replicated jobs could be put under the same networking space - I actually couldn't get it working for the worker/broker to see one another. It wasn't a limit of the networking, but flux expects the result of hostname to be findable in the network, and since that isn't a FQDN for our cluster we did a hack to define a common default connect address (shown below). The problem is that there can only be one, but with two ReplicatedJob I have two! So either the broker doesn't see the worker or vice versa. I could talk to the Flux devs about if it's possible to allow two, but that theoretically would mean two checks and it's not ideal.
I tried disabling the network, and created the service on my own, to be shared between the pods, and to get that working I had to use a new selector job-group instead of job-name that needs to be unique. That seems to work nicely, but we aren't getting anything from JobSet. I'll include the broker.toml config that we are using (and now working with JobSet and creating our own service) if you are interested:
[bootstrap]
curve_cert = "/etc/curve/curve.cert"
default_port = 8050
default_bind = "tcp://eth0:%p"

# These are the only two that matter - I can only put one global network name here
default_connect = "tcp://%h.flux-service.flux-operator.svc.cluster.local:%p"

# And the hosts here are checked under that namespace (so two doesn't work)
hosts = [
        { host="minicluster-flux-sample-broker-0-0, minicluster-flux-sample-worker-0-[0-2]"},
]

I also tried giving the two ReplicatedJobs the same Name, but that wasn't allowed. Per my suggestion (in the title) above, I wonder if different metadata-> Name could be allowed to be under the same service name? Maybe we could have:
Network: &jobset.Network{
    Name: "flux-servicei",
    EnableDNSHostnames: &enableDNSHostnames,
},

And this would reproduce what I've manually created here. Aside from that - it was really fun testing this out! I learned a lot how to get this custom operator to be seen by mine, which came down to adding to the schema and the rbacs, and I really enjoyed trying out JobSet for the first time :partying_face: ! The work I did can be seen in https://github.com/flux-framework/flux-operator/pull/164/files#diff-21f0c3fe3a7f139c41d8288276b7493d269c34740b8dc6322b9c55514318c9e6. Looking forward to more discussion here!

Suspend makes it hard to debug
When I started with suspend: true I never saw any pods, and I think this is because it fails the JobSet on any failure. We might eventually want this to Complete pods, although with the new design we probably don't need it anymore. I'll leave it off for now because I didn't like my JobSet suspending without me being able to debug!

Suspend is really only useful if you intend to use in with Kueue or you are implementing some kind of queueing system.  Suspend is saying that you want to create the jobset object and put it into some queue.  And once you have capacity, then you will resume your object.  I think for you creating it without the suspend field set should default to false which is the behavior you'd want.

Gotcha - that makes total sense! I should probably go back and make sure it's exposed for the user to set (or the developer user)... need to think about where is best to put it.

I'm creating a design with a leader and workers (a listing of two under the JobSet) and for the leader, I wanted to generate the headless service. But it gave me an error early on that I needed to use an IndexedJob. Is there a reason to not be able to create the service for a non-indexed job?

Creating a headless is needed to establish a stable network identity for the pods; in indexed job the hostname is stable (-); non-indexed jobs however create pods with hostnames equal to the pod name, which is random (-). So my question, why would you want to create a headless service for a non-indexed job? how would you address the pods?

The names for the pods for the jobset are really long! The shorter ones for just having an indexed job are really much nicer to look at / query (e.g., flux-sample-0-xxxx) - could there be some way to reduce the length of the name? I would suspect it's about namespacing it to the jobset -> replicatedjob -> job but it's coming at the cost of the user experience I think.

That is a good point, but I don't think we have a lot of options here, we have to have the jobset name, the replicatedJob name and the index as part of the pod name, otherwise we can't guarantee that it will be unique and predictable.

Networking - allow me to set (shared) name?

Allowing to specify the domain name makes sense. Do you want to open a feature request?

I'm not sure why, but I noticed that the time that I apply the minicluster.yaml (that creates the jobset) to then see the pods appear is fairly long, at least longer than if I just created the Indexed Job. This could just be an artifact of needing to use JobSet from a separate operator... or MiniKube being slow again (my computer is burning my legs right now so it might be that too!) 😆

That is strange, JobSet really doesn't do much, should be much lighter weight than for example what the job controller does. It could be that the jobset controller is configured with very little resources though.

Creating a headless is needed to establish a stable network identity for the pods; in indexed job the hostname is stable (-); non-indexed jobs however create pods with hostnames equal to the pod name, which is random (-). So my question, why would you want to create a headless service for a non-indexed job? how would you address the pods?

Why can't the non indexed name allowed to be given a hostname that I decide? As a user, I'm creating a single pod that I want to be part of the larger network. It felt weird to do it the most natural or intuitive way, and then get this error, and then artificially put it in indexed mode to "make it work!" I don't totally mind hitting this error and then making a one pod indexed job, but what is the index for? It seems more natural that you would just let me create a non indexed job with a stable name and networking.

That is a good point, but I don't think we have a lot of options here, we have to have the jobset name, the replicatedJob name and the index as part of the pod name, otherwise we can't guarantee that it will be unique and predictable.

Haha, yes this is what I suspected! I think I can probably try to shorten my names too.

Allowing to specify the domain name makes sense. Do you want to open a feature request?

Yes, absolutely.

That is strange, JobSet really doesn't do much, should be much lighter weight than for example what the job controller does. It could be that the jobset controller is configured with very little resources though.

Totally possible given my janky computer. If/when we get into testing and comparison (I think the key feature we'd be waiting for is being able to specify topology) I promise I'll run it on a production cluster!

Why can't the non indexed name allowed to be given a hostname that I decide? As a user, I'm creating a single pod that I want to be part of the larger network. It felt weird to do it the most natural or intuitive way, and then get this error, and then artificially put it in indexed mode to "make it work!" I don't totally mind hitting this error and then making a one pod indexed job, but what is the index for? It seems more natural that you would just let me create a non indexed job with a stable name and networking.

ok, I didn't think of the one pod job case, I guess that make sense. We can relax the validation. I opened https://github.com/kubernetes-sigs/jobset/issues/138

@vsoch thanks a lot for the feedback, I think we captured all the issues raised here? can we close this one?

OK if I test things out and give you an update? Worst case I should have time later today or this weekend.

okay I tested out the single pod job with networking - it worked but just not for our use case, details! https://github.com/kubernetes-sigs/jobset/issues/138#issuecomment-1555309877 and it looks like this issue hasn't been worked on yet: https://github.com/kubernetes-sigs/jobset/issues/136 but the issue is open so I'm happy to close here. Thanks everyone!
And please let me know if there are new stuffs to test or that you want feedback on.

Thanks! This also just merged https://github.com/kubernetes-sigs/jobset/pull/124

oh sweet!! I really wanted to try that out (haven't ever tried out any policy) - going to try it now!

@ahg-g - probably a stupid question - how would I use a non-release of the code here (e.g., what worked for me is to reference  sigs.k8s.io/jobset v0.1.3 as when I gave the github URI it corrected me to use that). Is there a dirty / development release or similar I can reference?

ohh I think I know what I can try - changing the URI to be the repository in the go.mod, etc. files. I'll try that!

We have the latest development version published: https://github.com/kubernetes-sigs/jobset/blob/main/docs/setup/install.md#install-the-latest-development-version

@ahg-g that works to install to my cluster, but to develop (and add, for example, SuccessPolicy to the Flux operator code) I can't build without the correct module in go.mod:
#0 78.21 controllers/flux/jobset.go:38:26: undefined: jobset.SuccessPolicy
#0 78.21 controllers/flux/jobset.go:39:34: undefined: jobset.OperatorAny
#0 79.79 # flux-framework/flux-operator/controllers/flux
#0 79.79 vet: controllers/flux/jobset.go:38:26: undefined: jobset.SuccessPolicy
#0 79.93 make: *** [Makefile:140: vet] Error 1
------

So then if I try to build with the GItHub address:
$ go get "github.com/kubernetes-sigs/jobset/api/v1alpha1"
go<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: sigs.k8s.io/jobset
                but was required as: github.com/kubernetes-sigs/jobset

Is there another option or a detail I'm missing?

oh!! This!!
$ go get sigs.k8s.io/jobset@main

Will let you know if it works fully!

slurm-sample-slurm-sample-database-0-0.slurm-service.slurm-operator.svc.cluster.local

Why do you name the replicatedJobName slurm-sample-database? just db should be enough, the jobset name has the context, and the first part becomes slurm-sample-db-0-0;
This reduces the name to 66, but again, nothing much we can do about this in jobset.
The rest, the part slurm-service.slurm-operator.svc.cluster.local, jobset doesn't control.

For my final set of names, I had to use:
slurm-sample-db-0-0.slurm-svc.slurm-operator.svc.cluster.local # this is a database
slurm-sample-s-0-0.slurm-svc.slurm-operator.svc.cluster.local # this is a login or controller node
slurm-sample-d-0-0.slurm-svc.slurm-operator.svc.cluster.local # this is a daemon node
slurm-sample-w-0-0.slurm-svc.slurm-operator.svc.cluster.local # worker 1
slurm-sample-w-0-1.slurm-svc.slurm-operator.svc.cluster.local # worker 2

And the only reason the service name is shortened is because I shortened it - I think the jobset would have made a service that has (by default) a longer name (but if we allow customizing the subdomain this would fix that!)
The above could still break if the namespace or job name gets longer. It just feels a bit fragile (and will lead to errors for the user when they accidentally choose a name too long) that would be nicer to just avoid. I also would have wanted those names to be understandable - aside from "db" that is fairly well understood, for the others, having to reduce them to one letter pretty much strips the meaning. I wish there was a way to encode the job name "slurm-sample" somewhere outside of the actual name that goes to DNS (and hits this rule), because I'd really like to have just:
database-0-0.slurm-svc.slurm-operator.svc.cluster.local
slurm-control-0-0.slurm-svc.slurm-operator.svc.cluster.local
slurm-daemon-0-0.slurm-svc.slurm-operator.svc.cluster.local
worker-0-0.slurm-svc.slurm-operator.svc.cluster.local
worker-0-1.slurm-svc.slurm-operator.svc.cluster.local

Anyway I got it working with the single letters, but maybe something to think about on the back brain burner!

We can add the subdomain once we move it to the jobsetspec with a default to the jobsetname.


feat: backend support for atlas publication lists (#411)

Needs to be rebased once #412 is merged

Hi @hunterckx, I merged #410, so this needs a rebase. Cheers, D


Migrate legacy code to modern frameworks season

Rabbit season

Failed Test
Failure Summary
Logs

Test_BadRequest
failure_message: Failedfailure_text: === RUN   Test_BadRequest    api_test.go:53: Bad request sent to API--- FAIL: Test_BadRequest (0.00s)
Logs ↗

Flaky Test
Failure Summary
Logs

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

Test_UnsupportedMediaType
failure_message: Failedfailure_text: === RUN   Test_UnsupportedMediaType    api_test.go:74: Unsupported media type provided--- FAIL: Test_Unsu...
Logs ↗

... and 1 more

View Full Report ↗ ⋅ Docs


Feature Request: Dis/enabling single conditions

like cooldown and spells, it would be nice to be able to disable or enable single conditions. This would help testing.
Regards and a good WotLK start.

This has been added for the next release

Fixed in 1.4.3


[DOCFIX] Update Azure-Data-Lake-Gen2.md

or we have two pages titled as Azure-Data-Lake

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.5 please


Fixup cargo install's help message

r? @nrc
(rust_highfive has picked a reviewer for you, use r? to override)

@bors r=ehuss

:pushpin: Commit 930e6d8b0ac3dc3c4d37f551d6d387565e4a467e has been approved by ehuss

:sunny: Test successful - status-appveyor, status-travis
Approved by: ehuss
Pushing 15e3b5a3c89409f568dc14dddc70164b0d3ef37a to master...


TextField, TextFormField and Button resizing not working in Flutter Web

Currently the responsive framework is not resizing the TextField's, TextFormField's and Button's in Flutter Web at version ^0.0.8.
Is this a known issue? Is there any fix coming?
Thank you.

Can you please provide me a sample?
I just used the Responsive Framework last night on my website with TextFields and Buttons and they scaled perfectly,
https://codelessly.com

I've the following:

And if I do it smaller:

It doesn't resize.
ResponsiveBreakpoints:
builder: (context, widget) => ResponsiveWrapper.builder(
            BouncingScrollWrapper.builder(context, widget),
            maxWidth: 1440,
            defaultScale: true,
            breakpoints: [
              ResponsiveBreakpoint.resize(425, name: MOBILE),
              ResponsiveBreakpoint.resize(800, name: TABLET),
              ResponsiveBreakpoint.resize(1000, name: DESKTOP),
            ]
          )

Can you try setting the breakpoint to autoScale?
ResponsiveBreakpoint.**autoScale**(425, name: MOBILE),
ResponsiveBreakpoint.resize(800, name: TABLET),
ResponsiveBreakpoint.resize(1000, name: DESKTOP),

Can you try setting the breakpoint to autoScale?
ResponsiveBreakpoint.**autoScale**(425, name: MOBILE),
ResponsiveBreakpoint.resize(800, name: TABLET),
ResponsiveBreakpoint.resize(1000, name: DESKTOP),

I will run some tests to exactly know what's going on and in the case that I found out that the error is coming from the responsive framework I will open a thread with a detailed description, thank you for your patience.


Update DbwNode.cpp

Removed the ID_HMI_GLOBAL_ENABLE_REPORT case because it is no longer included in the dbc file.

#34


rm logRW.Write() in logging middleware. That method is not overriden …

…so we do not need it

Codecov Report
Base: 71.72% // Head: 72.41% // Increases project coverage by +0.68% :tada:

Coverage data is based on head (a4bf854) compared to base (0f54b58).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   71.72%   72.41%   +0.68%
==========================================
  Files          33       33
  Lines        2338     2244      -94
==========================================
- Hits         1677     1625      -52
+ Misses        578      536      -42
  Partials       83       83

Impacted Files
Coverage Δ

middleware/log.go
77.55% <50.00%> (+0.24%)
:arrow_up:

server/tls_conf.go
48.78% <0.00%> (-0.26%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Spurious PLE1300 error with 0.0.283

After upgrading v0.0.281 → v0.0.282 (https://github.com/codespell-project/codespell/pull/3011) we see what we think is a spurious PLE1300 error:

Minimal code snippet:s = "{0}{1:{width}}".format("a", "1", width=15)

The command invoked:$ ruff --select PLE file.py
file.py:1:5: PLE1300 Unsupported format character '}'
Found 1 error.
$

The current Ruff settings: no pyproject.toml file
The current Ruff version:$ ruff --version
ruff 0.0.283
$

The Format String Syntax documentation states:

A format_spec field can also include nested replacement fields within it. These nested replacement fields may contain a field name, conversion flag and format specification, but deeper nesting is not allowed.

This is probably related to #6171

Perhaps I don't understand how pre-commit checks work. Out file .pre-commit-config.yaml  contains:
  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: v0.0.282
    hooks:
      - id: ruff
``

But yes, you're right about it:
$ pip install --force-reinstall --user ruff==0.0.281
Collecting ruff==0.0.281
  Downloading ruff-0.0.281-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.6/5.6 MB 11.0 MB/s eta 0:00:00
Installing collected packages: ruff
  Attempting uninstall: ruff
    Found existing installation: ruff 0.0.283
    Uninstalling ruff-0.0.283:
      Successfully uninstalled ruff-0.0.283
Successfully installed ruff-0.0.281

[notice] A new release of pip is available: 23.1.2 -> 23.2.1
[notice] To update, run: python3 -m pip install --upgrade pip
$
$ ruff --select PLE file.py
$
$ pip install --force-reinstall --user ruff==0.0.282
Collecting ruff==0.0.282
  Downloading ruff-0.0.282-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.6/5.6 MB 12.6 MB/s eta 0:00:00
Installing collected packages: ruff
  Attempting uninstall: ruff
    Found existing installation: ruff 0.0.281
    Uninstalling ruff-0.0.281:
      Successfully uninstalled ruff-0.0.281
Successfully installed ruff-0.0.282

[notice] A new release of pip is available: 23.1.2 -> 23.2.1
[notice] To update, run: python3 -m pip install --upgrade pip
$
$ ruff --select PLE file.py
$
$ pip install --force-reinstall --user ruff==0.0.283
Collecting ruff==0.0.283
  Using cached ruff-0.0.283-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.7 MB)
Installing collected packages: ruff
  Attempting uninstall: ruff
    Found existing installation: ruff 0.0.282
    Uninstalling ruff-0.0.282:
      Successfully uninstalled ruff-0.0.282
Successfully installed ruff-0.0.283

[notice] A new release of pip is available: 23.1.2 -> 23.2.1
[notice] To update, run: python3 -m pip install --upgrade pip
$
$ ruff --select PLE file.py
file.py:1:5: PLE1300 Unsupported format character '}'
Found 1 error.
$

I keep getting issues with pre-commit, whether in CI jobs or on my own computer.

pre-commit

ruff v0.0.283 is getting picked up by an unpinned ruff dev dependency running in a separate CI job. pre-commit is running v0.0.282 as specified.

Thanks! I'll take a look at the format string parser. I wonder if we were silently parsing this incorrectly the whole time, and the rule just brought it to light, or if the changes to the parser from https://github.com/astral-sh/ruff/pull/6171 were erroneous.

I think the parser doesn't quite support this, it'll need to be improved. (The rule was new in v0.0.283.)

This is still broken unfortunately. test.py:
import sys

number = 1234.56
print("{0:.{prec}g}".format(number, prec=sys.float_info.dig))

Ruff output:
$ ruff --select PLE1300 --isolated test.py
test.py:4:7: PLE1300 Unsupported format character 'g'
Found 1 error.

Ruff version:
$ ruff --version
ruff 0.0.285

@tdulcet Perhaps you should open a new issue, since this one has been automatically closed.

I have opened #6767 as a follow-up to this ticket.


Help. "Requesting activation (personal license). Unclassified error occured while trying to activate license."

Hello Webbertakken!
I love you are building Unity CI plugins.  I am working on trying to get my build process to work on my game but I've come across this problem.  I hope this is the right place to ask for help. There is nothing in the game repo yet btw...
On the build log I'm getting this. Which seems like it can not activate the license properly.
Successfully tagged unity-builder:2020.1.3f1-mac
/usr/bin/docker run --workdir /github/workspace --rm --env UNITY_LICENSE --env UNITY_LICENSE_FILE --env UNITY_EMAIL --env UNITY_PASSWORD --env UNITY_SERIAL --env UNITY_VERSION=2020.1.3f1 --env PROJECT_PATH=. --env BUILD_TARGET=StandaloneOSX --env BUILD_NAME=StandaloneOSX --env BUILD_PATH=build/StandaloneOSX --env BUILD_FILE=StandaloneOSX --env BUILD_METHOD= --env VERSION=0.0.16 --env ANDROID_VERSION_CODE=16 --env ANDROID_KEYSTORE_NAME= --env ANDROID_KEYSTORE_BASE64= --env ANDROID_KEYSTORE_PASS= --env ANDROID_KEYALIAS_NAME= --env ANDROID_KEYALIAS_PASS= --env CUSTOM_PARAMETERS= --env HOME=/github/home --env GITHUB_REF --env GITHUB_SHA --env GITHUB_REPOSITORY --env GITHUB_ACTOR --env GITHUB_WORKFLOW --env GITHUB_HEAD_REF --env GITHUB_BASE_REF --env GITHUB_EVENT_NAME --env GITHUB_WORKSPACE=/github/workspace --env GITHUB_ACTION --env GITHUB_EVENT_PATH --env RUNNER_OS --env RUNNER_TOOL_CACHE --env RUNNER_TEMP --env RUNNER_WORKSPACE --volume /var/run/docker.sock:/var/run/docker.sock --volume /home/runner/work/_temp/_github_home:/github/home --volume /home/runner/work/_temp/_github_workflow:/github/workflow --volume /home/runner/work/Outlight/Outlight:/github/workspace unity-builder:2020.1.3f1-mac
Requesting activation (personal license)
Unclassified error occured while trying to activate license.
Exit code was: 1
Error: The process '/usr/bin/docker' failed with exit code 1

My Github Action script is here: https://github.com/bautrey37/Outlight/blob/main/.github/workflows/main.yml
For the UNITY_LICENSE, I am using my serial key on my organization in Unity. I have a Unity Pro license from being a student.  I hope that this CI workflow is applicable to this license type. I'm not completely sure if this is the right license to use for the secret.

Hi @bautrey37 and thank you for reporting your issue with Unity Builder.

For the UNITY_LICENSE, I am using my serial key on my organization in Unity.

Is there a special reason you're doing this? Because the readme never tells you to do that, and out of the box this is not expected to work.

Thanks for responding! It seems though I only read the Getting started part and not the next section of Activation.  I don't know why, I guess I assumed that Getting started was all that I needed and I wasn't knowledgable about Unity licenses in how to activate them.  I thought you just go online and find it like in other licenss.
When I activate my license, I get two options to choose from plus or pro and personal. I got them both, but on my profile, it says I have Unity Pro subscription.  Honestly, I have no idea what the difference but the personal seems to be the classic free license. The instructions don't mention this part.  I think it might not matter for this Unity CI, but I feel like the instructions should mention this part.
On the step of copy the contents your license file into it. of section Converting into a license, I feel like it should say,
copy the entire XML contents of your license file into it.
Because when it said content, I thought it means to go inside and find the license key, such as the  contents. But that is not the case.
Now on my build, it is able to find my license correctly.  But now it says, Segmentation fault (core dumped).  I remember seeing something like in some other issues on Github. Do you know what to do next?
https://github.com/bautrey37/Outlight/runs/1205833929?check_suite_focus=true

I feel like it should say,
copy the entire XML contents of your license file into it.

Documentation can definitely be improved, feel free to open a pull request 👍

Now on my build, it is able to find my license correctly. But now it says, Segmentation fault (core dumped). I remember seeing something like in some other issues on Github. Do you know what to do next?

You may also search here:
https://gitlab.com/gableroux/unity3d-gitlab-ci-example/-/issues?scope=all&utf8=✓&state=all&search=Segmentation+fault+(core+dumped).
I'll close this issue because initial activation issue is now solved by reading the documentation. Feel free to open a new issue with more details specific to your Segmentation fault (core dumped) error. (Ex; full build log, unity version, a link to your project if it's open source, the things you've tried so far, etc).
Good luck! 🎉

Ok no problem. Thanks for the help. I'm working on a PR for the doc update.

https://github.com/Unity-CI/Website/pull/41

See also https://github.com/webbertakken/unity-builder/issues/135 to solve your problem.


Could matter-js run in WebWorker ?

If it could , is there an example for it ?
Thanks

I tried a simple example , it could run.
I don't when the example become complex , whether still could run correct.

Hey, I was wondering, how do you send instructions to the webworker?

run matter.js in webworker.
pass data with  postMessage & ArrayBuffer

Sorry, I know that postMessage and ArrayBuffer can be used to send instructions. What I meant is how do you interface it with matter-js?
What does the messages or the array buffer look like?

I custom a protocol for a arraybuffer.
arraybuffer[0] is cmd flag . in the webworker , Accord to different cmd , do different case.
And there is another arraybuffer save the engine's all bodies. (just position, angle, vertex)


Enable RedundantMerge cop

For discussion.
Followup to https://github.com/capistrano/capistrano/pull/1594

Makes sense. :+1:


translate Referencing Values with Refs

Thanks for your review 🙌 I've submitted your requests.

Merge ediyorum @yunusemredilber hocam


iOS10 support

First of all, I'd like to thank you for excellent work done. Could you please share your thoughts about upcoming iOS10 support? I expect that Apple guys would do some new changes into backup encryption algorithms. Do you've any expectations on that? Do you need some help in progressing this project (and may be porting to Python)? I suppose that the speed of new iOS version adoption is a key for this project success.

Hi. Contrary to what some believe, I don't know that much about iOS. I still don't own an iPhone. I'm just going to wait until iOS 10 arrives before working with it. That is if I do indeed have the spare time to work with it.
That being said the iOS 8 -> 9 jump was huge due to the migration to CloudKit. Most of our coding here revolves around CloudKit. I'm not expecting such huge changes going in iOS 10. But no doubt Apple will break things for us again.
If you want to port the project to Python that would be brilliant. The reason I've been tidying up code, as opposed to piling on features is to try and make it easier for others to port. The last of the demons is the download engine which I'm re-coding, though it works well it's a horrible convoluted mess.
If you are interested in porting, let me know and I can make suggestions has to how you could approach it.

I'm agree that clean up code is a good way to help with porting. If you interested, I could upgrade one of our devices to iOS 10 (it is already available for developers), create an iCloud backup and see what happened with retrieval attempt :)

I've been testing all of the new updates against my personal device running iOS 10. It shouldn't be considered an extensive test. Everyone should be able to upgrade their devices to iOS 10 as part of the public beta test, if you'd like.

Thank you Matthew for your note! Did you try to run InflatableDonkey against iOS10 iCloud backup?

Good news! I've installed iOS10 (latest beta) and successfully retrieved backup. At least photos, viber and whatsapp data properly downloaded and readable. Cant believe Apple does not break things in iOS 10, may be they would with public release :)

@ajlyakhov thank you for the update! Hopefully we won't see too much in the way of change for a public release.

@horrorho could you please suggest if there are some method I could check why my latest snapshot does not appear in a list of snapshots? I'm looking at iOS10 updates and if they influence on InflatableDonkey ability to retrieve backups. After latest update, I see backups up to 6th of August when iOS10 latest update been installed.

I don't have access to iOS 10 backups at present, so it might be difficult to assist if the problem isn't trivial to solve.
As a first step could you try this step from a previous issue. Be careful to filter out the reply as explained.

Seems like it was an issue with non-completed backup as you supposed. Today, I've got a yesterday's snapshot and that is fine. Could you please suggest if you could give me some suggestions regarding porting of your code into python? At least I need to evaluate complexity and time frame needed to complete that.

Thank you for the feedback, I'm glad you got it figured.
As for the Python porting time frame and complexity, it's a difficult question to answer. I don't work in IT so I don't really have a concept of how quickly projects move along outside of my own personal experience. Excluding the Protobuf auto-generated classes, there are about 25k lines of code. Most of it in fairly small classes of a few hundred lines at most. As you would expect there is a fair amount of crypto and IO code.
The biggest issue is that a lot of the protocols are undocumented, they are my distilled interpretation of what the Apple  binaries are doing. However it shouldn't be hard to pick up what's going on by examining the code.
You definitely want to fiddle with the logging configuration to dump out what's going on under the hood. For full trace logging and headers we can substitute in:
    <logger name="com.github.horrorho.inflatabledonkey" level="trace" additivity="false">
        <appender-ref ref="STDOUT" />
    </logger>

    <logger name="org.apache.http.headers" level="debug" additivity="false">
        <appender-ref ref="STDOUT" />
    </logger>

As to where to start? I'd strip out the frills and follow the code/ logging flow. So authentication, escrow keys and so forth. If it doesn't work, you can try again comparing your http client-server responses with what InflatableDonkey is telling you it's doing.
However, you MUST get the escrow SRP exchange working properly before you use it on live servers, otherwise you can potentially lock out the account. Hopefully you can find a nice Python library to get it done which will save you coding it as I have done.
I've had a few individuals express an interest in porting to Python. I have suggested they open a ticket asking if others would also be interested and possibly getting a group effort going. As of yet, nobody has done so.
:octocat:

Thank you for intro. As I understood from your latest project update, you plan to put this project on hold. Could you please suggest if you'd be able to answer some questions as I still have a serious plans to port your work in some form into python? I'm thinking about some kind of library without any download threading implementation and other complexities but focus on decryption and filtering. That future library should be used to implement end-user tools.

@ajlyakhov if I were to recode this project I would do things very differently. But as it is we have:

Core CloudKit layer:

Authentication.

CloudKitty - Talks to CloudKit servers and returns various records. Based on protobuf.

PCS - Handles the decryption of CloudKit records. It starts off with a key bag we unlock with an SRP exchange. This key bag is then used to decrypt records, which may be nested within zones that have additional encrypted keys. I've tried to document the various methods used along with links to RFCs. It's crypto heavy but just be glad you didn't have to sit there and reverse engineer it from binaries like I did.

This core can be used to power various tools. InflatableDonkey uses it to retrieve iCloud backups (PCS_BACKUP). I also have a hacked version of InflatableDonkey that uses this core to retrieve cloud photos (HYPERION).
Other services are:
    PCS_MASTERKEY(1), // MasterKey
    BLADERUNNER(2), // iCloudDrive
    HYPERION(3), // Photos
    LIVERPOOL(4), // CloudKit
    PCS_ESCROW(5), // Escrow
    PCS_FDE(6), // FDE
    PIANOMOVER(7), // Maildrop
    PCS_BACKUP(8), // Backup
    PCS_NOTES(9), // Notes
    PCS_IMESSAGE(10), // iMessage
    FELDSPAR(11), // News

iCloud backup (PCS_BACKUP) retrieval layer

Query for devices, snapshots and assets.

Authorize and download assets. Files are created from encrypted chunks which are stored on third party servers. This returns us a list of urls to get these chunks from and how to decrypt/ piece those chunks together. The process is similar to iOS 8 but with improved encryption mechanics.

Data Protection. Files may be encrypted. To decrypt them we need retrieve, unlock and then use another key bag. Files are encrypted using AES-CBC or AES-XTS, see Disk_encryption_theory.

iCloud photos (HYPERION) retrieval layer (unpublished hacked InflatableDonkey).

Create a sync and retrieve a list of photos assets.

Authorize and download assets. No additional decryption is required.

I was considering pulling out the core layer and forming a separate project. As a side note, I've seen some naughty third party recovery tools VMProtect hacked Apple binaries instead of writing their own core layer. I guess they were thinking no one would notice...
There is a lot going on and I could easily write a little book on this with lots of unpublished/ secret information. Maybe I should do that.

@ajlyakhov 'I'm thinking about some kind of library without any download threading implementation and other complexities but focus on decryption and filtering. That future library should be used to implement end-user tools.'
To clarify further. I would consider writing a core layer as described above first. Then you can provide additional tool layers on top of that.
The easiest approach would be to drive Windows Apple dlls directly as other third party tools are doing, but this would obviously tie you into the Windows platform. I do have a C++ tool that does this that I created as part of my research process to spy on client server calls. It can download iOS 9 backups, minus Data Protection which I never implemented. However, I been reluctant to acknowledge it's existence or to provide specific details.

If you write core layer that would be awesome and really speed up dev process. I'd prefer never ever stick to windows OS. All my development run on Linux based systems. But I agree that it is interesting idea to reuse Apple binaries to simplify adoption to Apple updates. We could experiment with vine for that.

@ajlyakhov To clarify, the core layer code is already present in InflatableDonkey. It doesn't need to be written. I was considering pulling it out as a separate project so it could be reused. However it's a time issue and I'm not actually sure anyone would know what to do with it.

Honorable sir @horrorho, could you please publish the "unpublished hacked InflatableDonkey"?

@SmoothAF I have a number of private tools that I don't have plans to release. However if you have an open source project that requires assistance then I may be able to help.

Stale issue. Closing.


Fix Grid width is wrong in responsive mode

The column width should be 100% in responsive mode

before

after

Hi @jiaming0708,
Unfortunately I'm unable to reproduce this:

Anything missing on my end?

The note content is too long, making the width overflow, check the element width via the inspect
you can remove/mark the note column to reproduce this issue

Thanks! In this case maybe we should simply move the tbody rules inside the table rules:
> table {
    table-layout: auto;
    display: block;

    > tbody {
        display: block;
    }
}

ok, changed the code, https://github.com/radzenhq/radzen-blazor/pull/584/commits/b4c642caf3f0f43d0f2842babcf08f3013d1fd92


add pep/8 mode

Hey there,
This PR adds a mode for the Pep/8 assembly language.
Example:

Signed-off-by: Alexandre Terrasa<EMAIL_ADDRESS>

Hi. We're not accepting new modes into the main distribution. The recommended way to distribute a mode is to put it on NPM as a separate package, along the lines of the Elixir mode.


chore: move dev deps into project.optional-dependencies

While doing 4.4.0 release build, seeing bunch of dev deps pulled in, thus updating the pyproject.toml.

Yeah, I was thinking of doing this. However, I think you might need to tell tox that it needs to install that extra now for tests to work, and should probably note something about it in CONTRIBUTING.md or one of those dev docs.


introduce /sexp endpoint that prints out the ast

During development I found myself wanting to inspect the abstract syntax tree before compilation. This introduces a new /sexp endpoint that prints that out.
Example output:
➜  ~ curl -i -XPOST<EMAIL_ADDRESS>localhost:9292/sexp
HTTP/1.1 100 Continue

HTTP/1.1 200 OK
Content-Type: application/text
Vary: Accept-Encoding
X-Content-Type-Options: nosniff
Content-Length: 45386

[:script,
 [[:trace,
   :header,
   [:cmds,
    [[:raw,
      "#!/bin/bash\n" +
      "if [[ -s //etc/profile ]]; then\n" +
      "  source //etc/profile\n" +
      "fi\n" +
      "\n" +
      "if [[ -s $HOME/.bash_profile ]] ; then\n" +
      "  source $HOME/.bash_profile\n" +
      "fi\n" +

...

     [:raw, "travis_run_after_success"],
     [:raw, "travis_run_after_failure"],
     [:raw, "travis_run_after_script"],
     [:raw, "travis_run_finish"]]]],
  [:raw,
   "echo -e \"\\nDone. Your build exited with $TRAVIS_TEST_RESULT.\"\n" +
   "\n" +
   "travis_terminate $TRAVIS_TEST_RESULT\n"]]]

I also introduced a raise e to prevent all errors from resulting in "There was an error in the .travis.yml file from which we could not recover." during development -- it prints the returns a stack trace instead.
refs https://github.com/travis-ci/reliability/issues/142

Works on staging, I think this is good to ship!


Autocomplete always give input fullwidth=true which is not preferred

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://stackblitz.com/edit/react-zc5u5j?file=demo.js
Steps:

create <Autocomplete/> with a <TextField/> as inner input.
see the render result.
inspect React props with React Dev Tools.

Current behavior 😯
The <Autocomplete/> is full width, even if I didn't specify fullwidth prop.
After inspecting the props of <TextField/>, I found that <Autocomplete/> always pass fullwidth={true} to inner input component, which is unexpected.

Expected behavior 🤔
It should not be fullwidth if I din't tell it to be. This makes the component more predictable.
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

You're right, the fullWidth prop on the Autocomplete seems to only add the .MuiAutocomplete-fullWidth class on the root element and does not control the actual input.
This was done in #19805. @oliviertassinari, the description of the PR doesn't explain why this was done this way. Do you still remember anything about this PR?

I would like to work on this bug. @michaldudak

Changing this behavior will break existing layouts. We can work on it when preparing v6.


Create "queriers" and promote "mutators" as the preferred way to get data server-side instead of the connector

Is your feature request related to a problem? Please describe.
The connector is meant for database communication, as an ORM.
But it cannot include Vulcan security checks.
Describe the solution you'd like

[ ] Create "queriers", similar to "mutators", that get the data + run basic security check. See example of the user API route: it doesn't respect permissions because its bypassing permission filtering. Mutators/queriers are the default way to get standard data, connector should only be used for custom mutations/resolvers
[ ] Make the syntax more attractive, for instance expose closures within the model so  createMutator({ model: Users,...}) becomes Users.create = (params) => createMutator({model: Users, ...params}). Same goes for hooks by the way (useMulti<UserType>({model: "Users"}) => useMultiUsers(...).

Describe alternatives you've considered
Putting callbacks within the connector, at the db level. But that will never be sufficient, as the connector is always specific to the underlying technology.

Connector should only be used when creating a custom mutation/resolver, that do not fit the basic crud operations.
For instance, see account management feature: we use the UserConnector, and StorableTokenConnector => we should use "queriers" and "mutators" instead so that callbacks are correctly applied.

After more investigation:

we are supposed to use "DataSources" in order to have the best performances for a request
DataSources must be recreated on a per request basis
They have to be defined in user land, we cannot create them automatically => that's because the user is responsible for implementing any custom method that will let them use the underlying Mongo collection as they want.
We will have to figure how to include them in Vulcan: should they be passed to the "Connector" for instance? A datasource has to know the underlying db so probably yes
They have to be passed to "mutators" and "queriers" => even when there is no request context per se, for instance when seeding the data or when creating a raw Express server, we should still be able to create a Graphql-like context. This context is extremely useful to have a consistent code and performant Mongo access via data sources.


Instead of adding a CR to the end of the command every time, just add it...

... in the executed bytes
This should fix issue #27 and all other problem cases where an OBD command is inited outside a loop and then run consecutively too many times (usually 4-14, depending on adapter).
The reason was of course that there was a new CR added to the command every time the sendCommand() was run, and by the book a CR always resends the previous OBD command then.

Nice catch! Thanks @jjlaine


Remove sidecar when instance is deleted

Fixes #443
I tested and the sidecar was not deleted
I think this is due to the fact that the Kubernetes GC does not delete the sidecar because is part of the pod, also is on the deployment template, which is not a child of the jaeger CR.
This PR implements some logic to "un-inject" the sidecar on the deployment. (but not on existing pods. should we do that??). I used a finalizer here.
@pavolloffay  @jpkrohling  Could you please review? Thank you!!

I cannot get the desired patch coverage, two small lines that test does not cover, not sure what else I can do. I think this is ready for review.

@pavolloffay Do you think we need to scan pods for remove sidecars or just deployments?

Any updates on this?

@jpkrohling This was ready for revision and merge, I had a question about scanning pods for deleted, in this PR I only scan deployments, but pods still remains with sidecars.
Also I have a problem with the coverage, for this PR is 90.69% but the target is 91.7%, This is due error lines that I can't reach on tests. Is there any advice on this?

but pods still remains with sidecars

If you scan the deployments, you can check if their PodTemplate have a sidecar pointing to a non-existing Jaeger installation (check the annotation value). In that case, you can remove the container and the annotation.

but pods still remains with sidecars

If you scan the deployments, you can check if their PodTemplate have a sidecar pointing to a non-existing Jaeger installation (check the annotation value). In that case, you can remove the container and the annotation.

I mean, new pods does not have the sidecars, but old pods yes. If you scale down the deployment and then scale up again, the new pods does not have the sidecars.

@jpkrohling Ok, after some tests I see that  I cannot update pod containers , is not allowed, if I can do it kubernetes replies with "pod updates may not add or remove containers" error.
But I think is not necessary because I relies on roll-up deployment feature, which update the pods according to certain policy.
Said that and if you don't have any other observation I think this is ready, I don't know why the codecov/path is reporting too low.....

@jpkrohling rebased :)

@jpkrohling I hope not having more typos :flushed: All requested changes are done!

Thanks, @rubenvp8510!
@kevinearls, @jkandasa do you think it might be good to add an e2e test for this one?


Prepare 4.2 schema datasets for feature development and testing

Context:
In order for the eng team to test and develop the spatial feature, we'll need 1 to 3 datasets on schema 4.2
DoD:

Work with Nik and DP team on adding spatial data related 4.2 schema to 1 to 3 datasets from DP
Update the development dataset pbmc3k.cxg to have schema 4.2 conforming spatial data OR replace pbmc3k.cxg with a dataset that has schema 4.2 confirming spatial data
Engineers can spin up local Explorer development env with a dataset that has 4.2 schema spatial data

@kaloster FYI - @sidneymbell will help us find the datasets we'll use for UXR after the MVP is done. So please work with her to see if any of the datasets she comes up with can be used as our development/testing
One consideration I have is that whatever dataset we decide to use for development/testing, we might need to reduce its size, if possible, so hopefully it's not too big for Github storage and loading in GHA, etc.
https://docs.google.com/document/d/1URHq2EQ94BRrtnfKklUhl_mcPmVvPpkYpjIKewaIBPY/edit?disco=AAABFW-2lWc
Thank you!

@kaloster should we add an item to make sure the new spatial dataset works on port 3000 too? I'm thinking since the ticket includes e2e tests all passing, it'd be given that it has to work on 3000 😆 What do you think?
Thank you!

Hey team! Please add your planning poker estimate with Zenhub @kaloster @seve

I'd recommend collaborating with @jychien to get a dataset that implements new visium requirements once we finalize.