Segmentation fault during auth

Describe the bug
When i try to connect to my work-pc with xfreerdp >= 3.0, the client dies with a segmentation fault.
Connecting to a VM for example works fine.
My work-pc was migrated from On-Premise AD via VPN to Azure
To Reproduce
Unclear - try to connect to a machine that is configured like mine :(
Expected behavior
A successful connection
Screenshots
n/a
Application details

FreeRDP version (xfreerdp /version)
3.1.0, latest from git as of 2024-01-11 19:00
Command line used
xfreerdp Arbeit-duo.rdp /u:$username /monitors:0,1 -grab-keyboard   /p:$PW
Output of xfreerdp /buildconfig

buildconfig
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: *************************************************
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: This build is using [debug] build options:
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_ALL=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_CAPABILITIES=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_CERTIFICATE=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_CHANNELS=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_CLIPRDR=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_CODECS=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_DVC=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_KBD=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_LICENSE=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_NEGO=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_NLA=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RAIL=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RDP=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RDPDR=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RDPEI=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RDPGFX=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_REDIR=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RFX=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_RINGBUFFER=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_SCARD=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_SND=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_SVC=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_TIMEZONE=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_TRANSPORT=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_TSG=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_WND=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_X11=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_X11_LOCAL_MOVESIZE=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: * 'WITH_DEBUG_XV=ON'
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]:
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: [debug] build options might leak sensitive information (credentials, ...)
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.core.rdp] - [log_build_warn][0x5641aa5c09c0]: *************************************************
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.client.common] - [freerdp_client_populate_settings_from_rdp_file]: Got networkautodetect:i:0 and bandwidthautodetect:i:1. Correcting to networkautodetect:i:1
[07:17:14:329] [20992:00005200] [WARN][com.freerdp.client.common] - [freerdp_client_populate_settings_from_rdp_file]: Add networkautodetect:i:1 to your RDP file to eliminate this warning.
[07:17:14:329] [20992:00005200] [DEBUG][com.freerdp.client.common] - [freerdp_client_settings_parse_command_line]: This is 3.1.1-dev0 Build configuration: BUILD_TESTING=OFF WINPR_HAVE_AIO_H=1 WINPR_HAVE_EXECINFO_BACKTRACE=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS_FD=1 WINPR_HAVE_EXECINFO_HEADER=1 WINPR_HAVE_FCNTL_H=1 WINPR_HAVE_GETLOGIN_R=1 WINPR_HAVE_GETPWUID_R=1 WINPR_HAVE_INTTYPES_H=1 WINPR_HAVE_POLL_H=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIBS= WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL=1 WINPR_HAVE_STDBOOL_H=1 WINPR_HAVE_STDINT_H=1 WINPR_HAVE_STRNDUP=1 WINPR_HAVE_SYSLOG_H=1 WINPR_HAVE_SYS_EVENTFD_H=1 WINPR_HAVE_SYS_FILIO_H= WINPR_HAVE_SYS_SELECT_H=1 WINPR_HAVE_SYS_SOCKIO_H= WINPR_HAVE_SYS_TIMERFD_H=1 WINPR_HAVE_TM_GMTOFF=1 WINPR_HAVE_UNISTD_H=1 WINPR_HAVE_UNWIND_H=1 WITH_AAD=ON WITH_ADD_PLUGIN_TO_RPATH=OFF WITH_ALSA=ON WITH_BINARY_VERSIONING=OFF WITH_CAIRO=OFF WITH_CCACHE=OFF WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CLIENT_SDL=ON WITH_CLIENT_SDL_AVAILABLE=1 WITH_CUPS=ON WITH_DEBUG_ALL=ON WITH_DEBUG_CAPABILITIES=ON WITH_DEBUG_CERTIFICATE=ON WITH_DEBUG_CHANNELS=ON WITH_DEBUG_CLIPRDR=ON WITH_DEBUG_CODECS=ON WITH_DEBUG_DVC=ON WITH_DEBUG_EVENTS=OFF WITH_DEBUG_KBD=ON WITH_DEBUG_LICENSE=ON WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=ON WITH_DEBUG_NLA=ON WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=ON WITH_DEBUG_RDP=ON WITH_DEBUG_RDPDR=ON WITH_DEBUG_RDPEI=ON WITH_DEBUG_RDPGFX=ON WITH_DEBUG_REDIR=ON WITH_DEBUG_RFX=ON WITH_DEBUG_RINGBUFFER=ON WITH_DEBUG_SCARD=ON WITH_DEBUG_SCHANNEL=OFF WITH_DEBUG_SDL_EVENTS=OFF WITH_DEBUG_SDL_KBD_EVENTS=OFF WITH_DEBUG_SND=ON WITH_DEBUG_SVC=ON WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=ON WITH_DEBUG_TRANSPORT=ON WITH_DEBUG_TSG=ON WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=ON WITH_DEBUG_X11=ON WITH_DEBUG_X11_LOCAL_MOVESIZE=ON WITH_DEBUG_XV=ON WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_DSP_FFMPEG_AVAILABLE=1 WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=ON WITH_FREERDP_DEPRECATED=OFF WITH_FREERDP_DEPRECATED_COMMANDLINE=ON WITH_FUSE=ON WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSTREAMER_1_0=OFF WITH_INTERNAL_MD4=OFF WITH_INTERNAL_MD5=OFF WITH_INTERNAL_RC4=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_KRB5=ON WITH_KRB5_NO_NTLM_FALLBACK=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBRESSL=OFF WITH_LIBSYSTEMD=OFF WITH_LODEPNG=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_NATIVE_SSPI=OFF WITH_NEON=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSSL=ON WITH_OPUS=OFF WITH_OSS=OFF WITH_PCSC=OFF WITH_PKCS11=OFF WITH_POLL=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=ON WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SDL_IMAGE_DIALOGS=OFF WITH_SDL_LINK_SHARED=ON WITH_SERVER=OFF WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_EMULATE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SMARTCARD_PCSC=ON WITH_SOXR=OFF WITH_SSE2=OFF WITH_SWSCALE=ON WITH_SYSTEMD=OFF WITH_THIRD_PARTY=OFF WITH_UNICODE_BUILTIN=OFF WITH_URIPARSER=OFF WITH_VAAPI=OFF WITH_VAAPI_AVAILABLE=1 WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_VERBOSE_WINPR_ASSERT=ON WITH_VIDEO_FFMPEG=ON WITH_VIDEO_FFMPEG_AVAILABLE=1 WITH_WAYLAND=ON WITH_WEBVIEW=OFF WITH_WINPR_DEPRECATED=OFF WITH_WINPR_TOOLS=ON WITH_WIN_CONSOLE=ON WITH_X11=ON WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=OFF WITH_XRANDR=ON WITH_XRENDER=ON WITH_XV=ON
Build type:          RelWithDebInfo
CFLAGS:              -O -pipe -march=x86-64 -Wall -Wpedantic -Wno-padded -Wno-cast-align -Wno-declaration-after-statement -fPIC -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -fno-omit-frame-pointer
Compiler:            GNU, 12.3.1
Target architecture: x64

OS version connecting to (server side)
Windows 11 Professional
If available the log output from a run with /log-level:trace 2>&1 | tee log.txt

log
[...]
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.client.common.cmdline] - [freerdp_client_load_static_channel_addin]: loading channelEx rdpdr
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.client.common.cmdline] - [freerdp_client_load_static_channel_addin]: loading channelEx rdpsnd
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.channels.channels.cliprdr.client] - [cliprdr_VirtualChannelEntryEx]: VirtualChannelEntryEx
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.client.common.cmdline] - [freerdp_client_load_static_channel_addin]: loading channelEx cliprdr
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.channels.drdynvc.client] - [drdynvc_VirtualChannelEntryEx]: VirtualChannelEntryEx
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.client.common.cmdline] - [freerdp_client_load_static_channel_addin]: loading channelEx drdynvc
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.primitives] - [primitives_autodetect_best]: primitives benchmark: only one backend, skipping...
[07:17:14:345] [20992:00005201] [DEBUG][com.freerdp.primitives] - [primitives_autodetect_best]: primitives autodetect, using generic
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_set_negotiation_enabled]: Enabling security layer negotiation: TRUE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_set_restricted_admin_mode_required]: Enabling restricted admin mode: FALSE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_rdp]: Enabling RDP security: TRUE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_tls]: Enabling TLS security: TRUE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_nla]: Enabling NLA security: TRUE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_ext]: Enabling NLA extended security: FALSE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_rdstls]: Enabling RDSTLS security: FALSE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_enable_aad]: Enabling RDS AAD security: FALSE
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core.rdp] - [rdp_client_transition_to_state][0x5641aa5c09c0]: CONNECTION_STATE_INITIAL --> CONNECTION_STATE_NEGO
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core] - [freerdp_tcp_is_hostname_resolvable]: resetting error state
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core] - [freerdp_tcp_default_connect]: resetting error state
[07:17:14:357] [20992:00005201] [DEBUG][com.freerdp.core] - [freerdp_tcp_default_connect]: connecting to peer <IP_ADDRESS>
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_init]: ringbuffer_init(0x7f9e3803c4a0)
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_connect]: state: NEGO_STATE_NLA
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_attempt_nla]: Attempting NLA security
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_send_negotiation_request]: RequestedProtocols: 3
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_write]: ringbuffer_write(0x7f9e3803c4a0): sz: 61
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_peek]: ringbuffer_peek(0x7f9e3803c4a0): sz: 61
[07:17:14:360] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_commit_read_bytes]: ringbuffer_commit_read_bytes(0x7f9e3803c4a0): sz: 61
[07:17:14:367] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_process_negotiation_response]: RDP_NEG_RSP::flags = { [0x1f] |EXTENDED_CLIENT_DATA_SUPPORTED|DYNVC_GFX_PROTOCOL_SUPPORTED|RDP_NEGRSP_RESERVED|RESTRICTED_ADMIN_MODE_SUPPORTED|REDIRECTED_AUTHENTICATION_MODE_SUPPORTED }
[07:17:14:367] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_recv]: selected_protocol: 2
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_attempt_nla]: state: NEGO_STATE_FINAL
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_connect]: Negotiated NLA security
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.core.nego] - [nego_try_connect]: nego_security_connect with PROTOCOL_HYBRID
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_write]: ringbuffer_write(0x7f9e3803c4a0): sz: 319
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_peek]: ringbuffer_peek(0x7f9e3803c4a0): sz: 319
[07:17:14:368] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_commit_read_bytes]: ringbuffer_commit_read_bytes(0x7f9e3803c4a0): sz: 319
[07:17:14:369] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_write]: ringbuffer_write(0x7f9e3803c4a0): sz: 318
[07:17:14:369] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_peek]: ringbuffer_peek(0x7f9e3803c4a0): sz: 318
[07:17:14:369] [20992:00005201] [DEBUG][com.freerdp.utils.ringbuffer] - [ringbuffer_commit_read_bytes]: ringbuffer_commit_read_bytes(0x7f9e3803c4a0): sz: 318
[07:17:14:371] [20992:00005201] [DEBUG][com.freerdp.core.nla] - [nla_set_early_user_auth]: Early User Auth active: false
[07:17:14:371] [20992:00005201] [DEBUG][com.freerdp.core.nla] - [nla_set_state]: -- NLA_STATE_INITIAL   --> NLA_STATE_INITIAL
[07:17:14:371] [20992:00005201] [DEBUG][com.winpr.sspi] - [InitSecurityInterfaceExA]: InitSecurityInterfaceExA
[07:17:14:371] [20992:00005201] [DEBUG][com.freerdp.core.auth] - [credssp_auth_init]: Using package: Negotiate (cbMaxToken: 12256 bytes)
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [fatal_handler]: Caught signal 'Segmentation fault' [11]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 0: /usr/bin/../lib64/libwinpr3.so.3(winpr_backtrace+0x4b) [0x7f9e477dc1c5]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 1: /usr/bin/../lib64/libwinpr3.so.3(winpr_log_backtrace_ex+0x30) [0x7f9e477ddf8b]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 2: /usr/bin/../lib64/libwinpr3.so.3(winpr_log_backtrace+0x1e) [0x7f9e477de0b7]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 3: /usr/bin/../lib64/libfreerdp3.so.3(+0x46c73) [0x7f9e479fdc73]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 4: /lib64/libc.so.6(+0x398c0) [0x7f9e475f98c0]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 5: /usr/bin/../lib64/../lib64/libkrb5.so.3(+0x82393) [0x7f9e45807393]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 6: /usr/bin/../lib64/../lib64/libkrb5.so.3(profile_clear_relation+0x65) [0x7f9e45807795]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 7: /usr/bin/../lib64/libwinpr3.so.3(+0x8f260) [0x7f9e47800260]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 8: /usr/bin/../lib64/libwinpr3.so.3(+0x92dc3) [0x7f9e47803dc3]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 9: /usr/bin/../lib64/libwinpr3.so.3(+0x995ef) [0x7f9e4780a5ef]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 10: /usr/bin/../lib64/libfreerdp3.so.3(+0x167b99) [0x7f9e47b1eb99]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 11: /usr/bin/../lib64/libfreerdp3.so.3(+0xb54de) [0x7f9e47a6c4de]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 12: /usr/bin/../lib64/libfreerdp3.so.3(+0x13b76e) [0x7f9e47af276e]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 13: /usr/bin/../lib64/libfreerdp3.so.3(+0xbe15d) [0x7f9e47a7515d]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 14: /usr/bin/../lib64/libfreerdp3.so.3(+0x11045e) [0x7f9e47ac745e]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 15: /usr/bin/../lib64/libfreerdp3.so.3(freerdp_connect+0x478) [0x7f9e47aa7311]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 16: xfreerdp(+0x232c6) [0x5641a9ef22c6]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 17: /usr/bin/../lib64/libwinpr3.so.3(+0x82fc7) [0x7f9e477f3fc7]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 18: /lib64/libc.so.6(+0x87bcc) [0x7f9e47647bcc]
[07:17:14:371] [20992:00005201] [ERROR][com.freerdp.utils.signal] - [winpr_log_backtrace_ex]: 19: /lib64/libc.so.6(+0xf9138) [0x7f9e476b9138]

If you built it yourself add some notes which tag/commit/branch you have used, also your cmake parameters and
compiler can help

Both 3.1.0 and the latest git-version
Build type:          RelWithDebInfo
CFLAGS:              -O -pipe -march=x86-64 -Wall -Wpedantic -Wno-padded -Wno-cast-align -Wno-declaration-after-statement -fPIC -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -fno-omit-frame-pointer
Compiler:            GNU, 12.3.1
Target architecture: x64
Environment (please complete the following information):

OS: Linux
Version/Distribution: Gentoo
Architecture: amd64 (Ryzen 7700X)

ok, since you build yourself:

can you reproduce this issue?
can you build with Debug (e.g. CMAKE_BUILD_TYPE=Debug and run this in a debugger to get some useful function names?
The only function I can identify is profile_clear_relation so is your kerberos properly set up?

Yes, with every version > 2.1.1 - with 2.1.1 there are no problems

2/3. I was able to build this in CLion and got the following call stack:

Since this works for older versions and from windows, it is at least set up in a way that usually works - other than that, i don't know since this is managed by my company.
I don't know the expected values here, but "profile" in krb5glue seems to be NULL
4. This was pulled in via the default configuration of my gentoo ebuild, so this was not a concious decision.
mit-krb5-1.20.1

@jdarmetzki ok, I can´t find any issue with our code here and the function crashing is in mit-krb5.
you might get further if you could also build mit-krb5 in debug mode.

I did that, and it seems the crash is in prof_set.c in the function rw_setup, in this line: https://github.com/krb5/krb5/blob/5b00197227231943bd2305328c8260dd0b0dbcf0/src/util/profile/prof_set.c#L40
since profile->first_file is null.

Ok, if i create a /etc/krb5.conf from the example distributed with mit-krb5, the crash is gone but auth fails.
[12:59:56:528] [1174:00000497] [ERROR][com.winpr.sspi.Kerberos] - [kerberos_log_msg]: Invalid argument
[12:59:56:528] [1174:00000497] [ERROR][com.winpr.sspi.Kerberos] - [kerberos_log_msg]: Invalid argument
[12:59:56:528] [1174:00000497] [ERROR][com.freerdp.core.auth] - [credssp_auth_setup_client]: Fatal error setting credential attributes
[12:59:56:528] [1174:00000497] [ERROR][com.freerdp.core.transport] - [transport_connect_nla]: NLA begin failed
[12:59:56:528] [1174:00000497] [ERROR][com.freerdp.core] - [transport_connect_nla]: ERRCONNECT_AUTHENTICATION_FAILED [0x00020009]

Is there any way to get the improper kerberos support from freerdp2 back? I honestly don't really want to learn how to configure this on my private machine just so i can rdp to my work-pc which is a domain member.

@jdarmetzki you can compile without.
but there seems to be something very wrong on your setup, the kerberos support (I´ve enabled it on my test builds too, no configuration whatsoever on my current machine) just tries to find the realm or valid ticket and if not  falls back to NTLM auth.

@jdarmetzki what are your arguments for connecting? did check the error message and you should not enter that code path if you do not set explicit kerberos stuff...

anyway, mailed the mit-kerberos project, as that is (also) a bug in their error handling.

I guess the problem is as follow:

By default, gentoo installs no krb5.conf, only a krb5.conf.example. In this state, freerdp crashes because there are no files in the profile.
When i rename the example file to krb5 conf, the included values (MIT-Related stuff as defaults) lead to the invalid argument output
when i replace the krb5.conf with an empty file, the fallback to ntlm seems to work

Thank you for your support, it was an interesting journey :)
If this was my code i'd probably add a check for profile->first_file=NULL until upstream fixes their stuff

@jdarmetzki can not do, the structure is opaque.

issue now tracked upstream: https://krbdev.mit.edu/rt/Ticket/Display.html?id=9110

Speaking as the MIT krb5 maintainer: while this is definitely an upstream bug, I'm not sure the FreeRDP code ever does what it intends to, because krb5_init_context_profile() copies the file references of the supplied profile object, not the in-memory relation tree.  I'm not sure there is currently a way to implement this feature without writing a file to disk or messing around with krb5_set_kdc_send_hook() or krb5_init_creds_step().

@fifthdegree  and maybe @hardening can you have a look?

We do in fact write the (modified) config to a temporary file, then load it using profile_init_path. It's a bit of a hack though, Greg, perhaps you'd consider exposing a way to set the kdc hostname/url directly?

While working on the upstream fix for this, I noticed a potential issue with the FreeRDP code: after modifying the profile handle it gets from krb5_get_profile(), it calls profile_release().  There are two problems with this:

profile_release() will attempt to flush the changes to the backing file.  So if this code is run as root, it will overwrite /etc/krb5.conf (removing comments and includes).

Due to a separate upstream bug, if flushing the changes to the backing file fails (the usual case), the in-memory copy of the file data will be leaked.

You probably want to use profile_abandon() in both of the places where you currently use profile_release().
I am considering a behavior change where profile_release() and profile_abandon() do the same thing, and an explicit profile_flush() is required to rewrite the backing file.  I think that would be safer behavior, but it could conceivably break some existing code.  (It's probably obvious that the profile read-write APIs aren't heavily used given how broken they are, but I know they are used in Solaris.)


[stress testing] Prevent secret logging from resource group deployment results

If any ARM template outputs or parameters container connection strings, etc. they will get printed in the container logs. This will hide stdout from the deployment.

/check-enforcer override


About training hardware

Hi,
Thank you for your great work and code releases!
May I ask how many gpus were used in your K400 training?
Thank you!

Hi,
The results reported in the paper were produced on a single node with 16 V100 gpus.
Kind regards


Add missing entries to php-confi-directives.data

Fixes failing curl calls from NFKUWKBD.
@theMiddleBlue I'm not entirely sure that all of these directives pose security threats. But they were part of the original report and @azurit put them into the curl calls.

seems legit. I wonder if we're missing a t:urlDecodeUni on 933120 since this:
https://github.com/coreruleset/coreruleset/blob/ca290b338997b9e120ac294e6839272a1f5966ee/rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf#L133
I'm worried about all tests works on Apache and not on Nginx, am I wrong?

nope, it works as expected on both... just tested it on sandbox:
$ curl -s 'http://sandbox.coreruleset.org/?var=unserialize_max_depth%3dtrue' \
  -H 'x-backend: nginx' \
  -H 'x-format-output: txt-matched-rules' \
  -H 'x-crs-paranoia-level: 4' \
  -H 'x-crs-version: pullrequest-3028'

933120 PL1 PHP Injection Attack: Configuration Directive Found
949110 PL1 Inbound Anomaly Score Exceeded (Total Score: 5)

$ curl -s 'http://sandbox.coreruleset.org/?var=unserialize_max_depth%3dtrue' \
  -H 'x-backend: apache' \
  -H 'x-format-output: txt-matched-rules' \
  -H 'x-crs-paranoia-level: 4' \
  -H 'x-crs-version: pullrequest-3028'

933120 PL1 PHP Injection Attack: Configuration Directive Found
949110 PL1 Inbound Anomaly Score Exceeded (Total Score: 5)
980170 PL1 Anomaly Scores: (Inbound Scores: blocking=5, detection=5, per_pl=5-0-0-0, threshold=5) - (Outbound Scores: blocking=0, detection=0, per_pl=0-0-0-0, threshold=4) - (SQLI=0, XSS=0, RFI=0, LFI=0, RCE=0, PHPI=5, HTTP=0, SESS=0)

@theMiddleBlue Can you give your approval?

Thank you for the PR @theseion and the review @theMiddleBlue. Merging now.


MD5 mismatch error

Recently @hongsudt reported that a user of hers in Australia has continued to see the md5 mismatch error that we were seeing before, documented here.
Information from @karlcz from slack channel:

FYI the errors all seem to be on the final POST on the upload job and the logs seem to show a race condition where this request is happening before one or more chunks have completed their upload.

many of the chunks for this user show elapsed times around 1.5 seconds which is not too bad but the logs show plenty of reordering of requests i.e. the chunk completion sequence looks like:   1, 2, 6, 8, 7, 5, (POST happens out of order here), 3, 4, 0

Note: default chunk size is 5MB

@hongsudt the fix we discussed on Friday has been merged into master for ermrestJS.


Address TODO items in SparkSQLExprMapper

I addressed the reviews on a branch that is based on the union types branch to avoid another merge. Will move the changes over once we know what will happen to union types.

If union types are merged, then this PR is replaced by https://github.com/opencypher/cypher-for-apache-spark/pull/884

Comments are addressed here: https://github.com/opencypher/cypher-for-apache-spark/pull/884
Motivation: This one was rebased on the union types PR and avoids additional merges, as the modified classes have a lot of overlap.


Check in Cloud Job Discovery client code samples

CJD is about to get Public beta launch so we would like to have our samples checked in as other projects.

May some one attach kokoro:run label?

Hi,
I have update the samples and add more comments. Let me know if I have missed something. Thank you.

Yes, part of them are duplicates. I think current set should be enough.

Is there anything else should I improve?

OK, I just realized that I forgot to upload the new added files yesterday. Now it should be complete.

May some one attach kokoro:run label?

The test failed due to the reason:
Line does not match expected header line of '^\W+*?\W*Copyright 20\d\d Google Inc.$'.
However,  I were told that I should use Google LLC
Should I change it back?

That's strange, because the commit to check for LLC or Inc. should have been released in shared-configuration:1.0.10 - https://github.com/GoogleCloudPlatform/java-repo-tools/commits/master
Kurtis, is it possible that commit didn't actually make it into that version?

@dzlier-gcp It made it in - the tests just ran on the wrong version. @xinyunh0929 bumped the version in 62650eeb76d131d6ec1e8b15a08d6d22a94b8802.
I re-triggered the tests and it is passing now.

Oh perfect, thanks Kurt!

@dzlier-gcp Kokoro won't run automatically for code submitted by users outside the GoogleCloudPlatform github org. In these cases it requires manual approval before running by adding the kokoro:run label.

Kokoro tests are passed. How could I merge the code?

Done

That is good to know though, that explains why the test still failed.


[Power Support] Enable weaveworks scope on Power.

Observed this particular test  was failing on ppc64le architecture. Added the test failure log below,
walker_linux_test.go:97:
                +++ have
                @@ -32,7 +32,7 @@
                   Cmdline: (string) (len=15) "curl google.com",
                   Threads: (int) 1,
                   Jiffies: (uint64) 0,
                -  RSSBytes: (uint64) 8192,
                +  RSSBytes: (uint64) 131072,
                   RSSBytesLimit: (uint64) 2048,
                   OpenFilesCount: (int) 3,
                   OpenFilesLimit: (uint64) 32768,

Hence modified the value for RSSBytes to accept variable value which is computed based on pageSize instead of hard-coded values, as suggested by Adam Harrison over slack channel.
I have verified this patch on x86 setup as well and all the tests pass there.  Please provide your comments/suggestions on this.
Thanks,
Meghali

Note there is a lint failure in this PR.

Yes, @bboreham , I am looking into this. I am expecting my build-changes should get this resolved.

@meghalidhoble Please run make lint locally to verify linting issues.

Please run gofmt -s -w probe/process/walker_linux_test.go then update the PR.  This should clear the lint error.

Thanks @bboreham , your suggestion helped to resolve the failure.

Please put into each commit message a description of the changes.
Some tips here
"code changes made" is not a useful description.

Hi @bboreham, @satyamz ,
Can we please merge this PR if no more modification is needed?

Hi @bboreham ,
I have addressed most of your comments and have pushed a few new code changes, Could you please take a look and let me know if any comments/suggestions?

Hi @bboreham , squashed all the commits to a single commit, with all the implementation details for each file being modified. Please take a look.

Sadly, it is inappropriate to directly modify anything in the tools directory because it is a vendored copy of https://github.com/weaveworks/build-tools.  Need to modify it upstream and then bring that commit in.
I'm sure this is maddening.
I might just change it to do nothing if it can't find shfmt, as is done for shellcheck, rather than have an architecture-specific test.

Hi @bboreham ,
I have addressed the concern raised for tools directory changes, hence I have removed the architecture specific changes. Sorry for multiple commits, I will squash those commits and will combine to a single commit. Let me know if these changes look ok.

Multiple commits is fine as long as they all form a progression and are all self-explanatory.
However the issue is that to change a file under the tools directory in this repo you need to change it in https://github.com/weaveworks/build-tools first and then do a git subtree to update the directory in this repo, as described in tools/README.md.

Hi @bboreham , I have raised a pull request at build-tools repo with the lint changes, once those changes are approved, I will run git subtree to update the directory in this repo.

Thanks!


test(build): frontend reproducibility

Motivation
Reproducible builds are important if Oisy Wallet ever gets decentralized. That way, anyone can verify that a proposed version matches the content of the proposal and, by extension, what will be executed.
Changes
Similarly to the NNS dapp, provide a script to test the reproducibility of the frontend builds (on the same machine) by running npm run build consecutively and comparing the list of files generated, their names, and their SHA values.
In addition, as in Juno, provide a GitHub Action to execute the script on demand or during a release.

For my info, is it intentional to not provide an extension to the script file? For example ".sh"

You are right it's more consistent to append the extension given that all our scripts do so. Thanks.


Deactivated Users Should Be Redirected

Redirect deactivated users to index if they are still logged in.

Deactivated users are redirected.

Bug is fixed.


fix(SDKManager): Unity 2018 Requires "None" Device to Be Last

As it is right now "None" will be put at the top of the list in
Player Settings > XR Devices > VR Enabled Devices. In 2017 this
seemed be bypassed by default, but in 2018 the assumed intent is to
not start in VR mode.
This fix puts "None" last when the settings are auto managed.

the assumed intent is to not start in VR mode

This is also the case for any other Unity version. This is exactly what VRTK is intending.
VRTK is using the SDK Setups you configure in the SDK Manager's list for it one by one, top to bottom and therefore wants None first.
Nothing changed with Unity 2018 here and this PR actually breaks the SDK switching VRTK does.

Oh sorry about that. Closing.


DOTA GC Never sending welcome message

I just ran into this issue... The GC never responds with welcome, it's just stuck on sending "ClientHello" over and over.

This probably isn't a node-dota2 bug but just Valve saying "no" to the bot.

It sounds like an unintended behaviour that can be handled in the library. I assumed by posting this here, you were making note of this behaviour in the expectation that the library would be updated to better handle it.
Let me know if I miss-interpreted this.

That was my intention, yes. We need to more elegantly handle this than spamming ClientHello I think

In my fork I just fire a hello timeout whenever this happens.
Can we do some testing to see what causes this and if it's possible to get around it?

Done with #66.


Change filetype for codeql

@pwntester I think we need only 56ddadd commit.

For some reason, when I push my branch with only one commit, it create this PR with all commits :(
Can you cherry pick it or merge the PR since the final result will be the same


Pass through soft fonts over conpty

Summary of the Pull Request
This PR introduces a mechanism for passing through downloadable soft
fonts to the conpty client, so that we can support DRCS (Dynamically
Redefinable Character Sets) in Windows Terminal.
References
Soft fonts were first implemented in conhost (with the GDI renderer) in
PR #10011, and were implemented in the DX renderer in PR #13362.
PR Checklist

[ ] Closes #xxx
[x] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated.
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not
checked, I'm ready to accept this work might be rejected in favor of a
different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
The way this works is by passing through the DECDLD sequence
containing the font definition, but with the character set ID patched
to use a hardcoded value (this is to make sure it's not going to
override the default character set). At the same time we send through an
SCS sequence to map this character set into the G1 table so we can
easily activate it.
We still need to process the DECDLD sequence locally, though, since
the initial character set mapping take place on the host side. This gets
the DRCS characters into our buffer as PUA Unicode characters. Then when
the VT engine needs to output these characters, it masks them with 7F
to map them back to ASCII, and outputs an SO control to activate the
soft font in the conpty client.
Validation Steps Performed
I've manually tested with a number of soft fonts and applications that
make use of soft fonts. But if you're testing with the VT320 fonts from
the vt100.net collection, note that you'll need to enable the ISO-2022
coding system first, since they use 8-bit C1 controls.

This is so clever! I'm excited to review it. Thanks!


Docs are still using Deps.autorun()

This makes me feel a bit like this package is outdated. If it is not, I would recommend to update the docs to Tracker.autorun().

It's not outdated. Just the docs.

Fixed.

Fine! :-)


Release: 2.6.0

We should also bump the version of the grpc-web plugin since it has incurred some feature creep due to the merging of the external plugins into the codebase.
New Features added between v2.5.1 and 2.6.x

GRPC Web

New schema feature allow_origin_header

Note: There may be other plugins that were merged in to the codebase that had fixes requiring version bumps as well, but this is the last one that I noticed while testing version compatibility.
diff --git a/kong/plugins/grpc-web/handler.lua b/kong/plugins/grpc-web/handler.lua
index d2d5e7bfa..a17cb096c 100644
--- a/kong/plugins/grpc-web/handler.lua
+++ b/kong/plugins/grpc-web/handler.lua
@@ -22,7 +22,7 @@ local kong_service_request_set_raw_body = kong.service.request.set_raw_body

 local grpc_web = {
   PRIORITY = 3,
-  VERSION = '0.2.0',
+  VERSION = '0.3.0',
 }

@mikefero  Thanks, pushed the grpc-web bump into the branch


Slight rewording of the restriction on using go get

Much nicer. I still have to add a FAQ about this


Allow use of podman or buildah by using the BUILD_COMMAND variable

This is required to allow:

build with RHEL8 (which has not docker anymore)
build multistage to get rid of dumb-init

/assign @waveywaves
/assign @gabemontero

/test e2e-aws-jenkins

/retest

/test images

/lgtm

/unassign @gabemontero


Wrong id is decoded for JOINed table results

In case of:
Build.query(on: req).join(\BuildTag.buildId, to: \Build.id)

I get BuildTag.id in my result objects

Tests PR https://github.com/vapor/fluent-postgresql/pull/111

Quick fix is to rename the id column of your JOIN model:
/// Join table between Apps and Tags
public final class BuildTag: PostgreSQLUUIDModel {

    public typealias Left = Build
    public typealias Right = Tag

    public static var leftIDKey: WritableKeyPath<BuildTag, DbIdentifier> {
        return \.buildId
    }

    public static var rightIDKey: WritableKeyPath<BuildTag, DbIdentifier> {
        return \.tagId
    }

    public var id: UUID?
    public var buildId: UUID
    public var tagId: UUID

    enum CodingKeys: String, CodingKey {
        case id = "join_id"
        case buildId = "build_id"
        case tagId = "tag_id"
    }

}

I'm seeing the same thing in very similar code.

The issue is described more in-depth here: https://github.com/vapor/fluent-postgres-driver/pull/114
To solve this problem you can run releaseCachedConnections(on:...) causing the schema lookup information to be refreshed.
This is no longer a problem in Fluent 4 since column aliases are used, i.e.:
SELECT id AS todos_id FROM todos


Disable double click to open link

Is possible to disable the double click to open link. In many log files types there's no such links and I use to double click to select full words for copy and paste.
May be a new setting can be added to disable this feature.
Greets.

Hi, I added use_link option to control link on/off. check up v1.2.0. use
it well ~
2017-05-29 21:33 GMT+09:00 TommyTheBlackbird<EMAIL_ADDRESS>
Is possible to disable the double click to open link. In many log files
types there's no such links and I use to double click to select full words
for copy and paste.
May be a new setting can be added to disable this feature.
Greets.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/poucotm/Log-Highlight/issues/6, or mute the thread
https://github.com/notifications/unsubscribe-auth/ASUglUxEkCaEaLPzqe6AtEVjRX_0z9cSks5r-rsEgaJpZM4NpQcJ
.

Is it a global setting o per severity basis? I'm trying 1.2.0 right now with use_link: false but it still opens a new tab when a link is detected in the same line.
Thanks.

Did you try to close log file and sublime and re-open it ?
2017-05-29 23:42 GMT+09:00 TommyTheBlackbird<EMAIL_ADDRESS>
Is it a global setting o per severity basis? I'm trying 1.2.0 right now
with use_link: false but it still opens a new tab when a link is detected
in the same line.
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poucotm/Log-Highlight/issues/6#issuecomment-304678271,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASUglYiaaHOfdWh20BXN_fq_ZaG7zmT9ks5r-tlPgaJpZM4NpQcJ
.

Closing and re-opening worked :thumbsup:


Update to support strictBuiltinIteratorReturn

This contains several updates to ensure vscode is forwards compatible with https://github.com/microsoft/TypeScript/pull/58243, which uses a stricter return type for built-in iterators under the new strictBuiltinIteratorReturn option, which is enabled by default when building with strict.

I've filed this as a Draft PR in the event there are any other changes to https://github.com/microsoft/TypeScript/pull/58243 that must be addressed. Once that PR has merged, I will mark this PR as "Ready for review".

Looks like the TS side of the change got merged and is present in the most recent nightly. Marking as ready for review so we can pick up the latest TS nightly for building VS Code


I feel like the Vsphere driver is in a beta state

I feel like I'm just constantly running into esoteric issues with little to no output from debugging things like:
Waiting for VMware Tools to come online
even if boot2docker has vmwaretools, ok so I switch to rancheros (which no docs even say that's supported) and that works so it does indeed seem to be an issue with boot2docker, and I get that's a separate project, but if it's integral to the usage of docker machine and vsphere, then it seems it's just not a primetime product. Which is ok, but I'm burning a lot of time trying things that just don't work. I feel like vsphere needs a beta tag or something. Like a need to indicate that it's just not amazing.
Then now I'm getting exit status 255 at different commands and other random esoteric failures. It's just hyper painful. I see sporadic reports of similar issues with little to no resolution. It's all open source and it's all free so thats ok. No one owes you anything, but a label or some warning that it's lack luster would be nice.

The problem seems to be boot2docker has no interfaces up to get DHCP from --vmwarevsphere-network


EM to PX & PX to EM converter

Describe the tool
Tool for converting em values to px, or px to em vice versa
Why do you want this tool?
To quickly convert em unit to px, or vice versa
Additional context
Category: Dev tools
Tool name: EM to PX convertor

[x] Would you like to work on it?

I have started working on this tool!!

#18 added size converter


Add Gradle wrapper for running DITA-OT

This will let us take advantage of the Gradle Daemon, which will significantly reduce build times for transformations after the first one.
Some preliminary numbers:
# `bench` is a shell script that runs a command N times and times it.

# Ant:
bench 25 ant -lib lib:resources -f build.xml -Dargs.input=$PWD/samples/hierarchy.ditamap \
  -Dtranstype=xhtml
...
      216.64 real       552.38 user        24.49 sys

# Gradle:
bench 25 gradle --info build
…
      93.66 real        56.09 user         5.02 sys

In other words, over 25 runs, the execution time drops to less than a half.
(The Gradle build task simply calls Ant with the same parameters as above.)
EDIT: I have the Gradle daemon enabled by default via the GRADLE_OPTS environment variable. Otherwise, if you want to test this yourself, you can do the same or pass the --daemon flag to Gradle.

The DITA-OT Gradle plugin probably fills this need. Closing this one.


Xcode style // MARK: - comments.

The minimap in Xcode has been undergoing many interesting overhauls over the years. There are many interesting things that can be incorporated into the vscode. One thing is the ability to mark places and then they become visible in the minimap:

Over the years I have seen many different tricks to make this happen. I once seen a repository that had comments with titles rendered in ASCII art in huge fonts so that they could be visible in the mini map. And the approach has been my extension that provides tools to create linens to bold them in the source code:

While these solutions work, Xcode provides a comment called mark where you can say // MARK: - title and it becomes rendered as one of these titles, which is more impressive:

Once you define these marks, they are rendered on the editor, and in the minimap. The minimap lets you jump to marks, and clearly see them. I think this would be an especially useful feature that vscode really must have.
P.S. Although the idea is nice, the // MARK: - title really isn't nice. If we could have something like // mark: title or other things equally simple that can be really nice.

Please watch progress on #190759

/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Add Solaris support

Hi, when trying to build sigstore on Solaris, I've hit an issue with webbrowser-rs not supporting it (as it needs the home crate). This minor change solves that issue.
Tests are green:
running 5 tests
test test_open_chrome ... ignored
test test_open_firefox ... ignored
test test_open_safari ... ignored
test test_open_webpositive ... ignored
test os::tests_xdg::test_xdg_open_local_file ... ok

test result: ok. 1 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 1.01s

     Running tests/common.rs (target/debug/deps/common-368bc0ade2ab6989)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_android.rs (target/debug/deps/test_android-bae4723d08ac0efc)

running 3 tests
test tests::test_android ... ignored
test tests::test_non_existence_safari ... ok
test tests::test_existence_default ... ok

test result: ok. 2 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.32s

     Running tests/test_ios.rs (target/debug/deps/test_ios-33d0202a2a5f4b1a)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_macos.rs (target/debug/deps/test_macos-b7ccf04782123dd3)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_unix.rs (target/debug/deps/test_unix-67ee6936302778a0)

running 6 tests
test tests::test_non_existence_safari ... ok
test tests::test_existence_default ... ok
test tests::test_local_file_abs_path ... ok
test tests::test_local_file_uri ... ok
test tests::test_local_file_rel_path ... ok
test tests::test_open_default ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 28.11s

     Running tests/test_wasm.rs (target/debug/deps/test_wasm-17a823806d32e01b)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/test_windows.rs (target/debug/deps/test_windows-2aa956fe49cdf6c8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests webbrowser

running 5 tests
test src/lib.rs - open (line 253) - compile ... ok
test src/lib.rs - open (line 260) - compile ... ok
test src/lib.rs - (line 7) - compile ... ok
test src/lib.rs - open_browser (line 275) - compile ... ok
test src/lib.rs - open_browser_with_options (line 293) - compile ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.13s

Thanks for helping expand the platform coverage. And also for the test report.

This is now out as v1.0.3


Sectioned content

Make content split into sections, and de-branded

also considering renaming the repo to atomistic-cookbook which is less generic


A thank you, a formal request for comment and a caution

Dear TomJo2000
I apologise in advance for posting this as an issue in your .dotfiles repository, but I had a significant challenge identifying an appropriate channel to initiate correspondence.
I note not only your prodigious contribution, but extensive maintenance, of a number of software projects I use daily and have so done, for a considerable number of years. For that, your dedication and sacrifice, I thank you. Your undertakings are honourable. Most of all, I love bash, zsh and Termux and its ecosystem.
Yesterday, I am ashamed to say, I got into an impassioned and protracted Termux GitHub repository flamewar with a Termux GitHub repository administrator, with administative privileges of the 'Termux' user-account, over censorship and the posting of ** significantly edited ** content generated with the assistance of three (3) GenAI LLMs, tendered with the best of intentions and in good faith. It is my considered opinion, that what I contributed prior to the flamewar, provided significant value to the 'termux-packages' repository discussion in question and the Termux community in general. I consider unfounded and ill-informed censorship dangerous, unconscionable and ill-founded and contrary to FOSS philosophy.
Is there a Termux community protocol and policy statement on censorship of open discourse on Termux public repositories? Is their a grievance process? You are directly contributing to this project and its ecosystem and the extended community and as such, bear a public responsibility to due process and probity. You are clearly a FOSS community leader. As such, I formally entreat your considered determination and response to this matter. Your opinion is greatly valued.
I await your advice.
Thanking you in anticipation
Beauford A. Stenberg
P. S. I have learnt a lot from your .zshrc and thank you for making it public. I too am currently splitting my config into modules. Your symbolic annotations legend is a mark of brilliance. You are cited in my .zshrc as a formative influence.

Quite frankly I have tried to write a response to this a couple times over the last week and I've come to the conclusion that I'm just gonna respond to what I feel warrants a response, and I'll leave the rest unaddressed.

I apologise in advance for posting this as an issue in your .dotfiles repository, but I had a significant challenge identifying an appropriate channel to initiate correspondence.

I appreciate that you recognize that bringing your concerns to me in the form of an issue on my dotfiles repository is unusual, but since you feel this strongly about the situation this setting will suffice.

I am ashamed to say, I got into an impassioned and protracted Termux GitHub repository flamewar with a Termux GitHub repository administrator, with administative privileges of the 'Termux' user-account, over censorship and the posting of ** significantly edited ** content generated with the assistance of three (3) GenAI LLMs, tendered with the best of intentions and in good faith. It is my considered opinion, that what I contributed prior to the flamewar, provided significant value to the 'termux-packages' repository discussion in question and the Termux community in general.

Quite frankly the exact details of the incident are not relevant to the decision to bar you from commenting on further discussions on Termux repositories.
We took the moderating decision to bar you from further participation is discussions on the termux-packages repository after what we have perceived as repeated disruptive conduct.
We are not a government or public sector entity and are free to moderate our repositories how we see fit.

I consider unfounded and ill-informed censorship dangerous, unconscionable and ill-founded and contrary to FOSS philosophy.

While I can appreciate the sentiment behind this concern participation in any open source project is a privilege, not a right, and it may be revoked at the discretion of the project maintainers.

Is there a Termux community protocol and policy statement on censorship of open discourse on Termux public repositories? Is their a grievance process? You are directly contributing to this project and its ecosystem and the extended community and as such, bear a public responsibility to due process and probity. You are clearly a FOSS community leader. As such, I formally entreat your considered determination and response to this matter. Your opinion is greatly valued.

I attempt to the best of my abilities to follow the guidelines of the Contributor Covenant Code of Conduct in my interactions as a maintainer of the Termux project.
Though this has not currently been officially adopted and our current moderation process on the project level is somewhat more informal.
Adopting a formal code of conduct is something that has been discussed previously but doesn't currently have a deadline attached.

I note not only your prodigious contribution, but extensive maintenance, of a number of software projects I use daily and have so done, for a considerable number of years. For that, your dedication and sacrifice, I thank you. Your undertakings are honourable. Most of all, I love bash, zsh and Termux and its ecosystem.
[...]
P. S. I have learnt a lot from your .zshrc and thank you for making it public. I too am currently splitting my config into modules. Your symbolic annotations legend is a mark of brilliance. You are cited in my .zshrc as a formative influence.

I am glad you find my contributions helpful and you are of course free to use, study, modify and redistribute them, in full or in part, as they best suit you.
I apologize if my actions in handling this situation, or my sentiments expressed in this response came off as overly harsh.
As this is my private dotfiles repo I would prefer to close this issue.


refreshToken function is printing logs to console

Issue
The catch block in the refreshToken function prints logs to console. This happens immediately when coming to a login page because it tries to find a refresh token when one hasn't been obtained yet.
Relevant Code
// Get a new access token using the refresh token.
const refreshToken = async (backendURL?: string) => {
  const url = `${backendURL ?? "/api"}/auth/token`;

  try {
    const response = await fetch(url, {
      method: "POST",
      credentials: "include",
    });

    // Exit if response isn't 200.
    if (!response.ok) return;

    // Get tokens.
    const { access_token, id_token, expires_in } = await response.json();
    if (!access_token || !id_token) return;

    const userInfo = decodeJWT(access_token);

    dispatch({
      type: REFRESH_TOKEN,
      payload: { accessToken: access_token, idToken: id_token, userInfo },
    });

    // Re-call refreshToken 15 seconds before expiry.
    setTimeout(() => refreshToken(), (expires_in - 15) * 1000);
  } catch (error) {
    console.error(error);
  }
};

Suggestion
Hide any console outputs behind the DEBUG environment variable.

Fixed in https://github.com/bcgov/citz-imb-kc-react/pull/9
We can't use environment variables in the frontend, but maybe in the future I will add a debug prop to KeycloakProvider.


managed plugin build failure seen intermittently on CI

CI failure: https://ci.vmware.run/vmware/docker-volume-vsphere/916
Plugin build error in CI
== building Docker image, unpacking to ./rootfs and creating plugin...
cp ../build/docker-volume-vsphere .
docker build -q -t cnastorage/docker-volume-vsphere:rootfs .
sha256:e469eadcdaa1269638f90ff957c9c75484a2594dc99249f21e21020013e7bf50
docker create —name tempContainer cnastorage/docker-volume-vsphere:rootfs
7ec9fd5c146ac950144f219f1ceb3c164decc36f607afe6f8891a6a4f753f013
mkdir -p /tmp/plugin/rootfs
docker export  tempContainer  | tar -x -C /tmp/plugin/rootfs
sh: 0: getcwd() failed: No such file or directory
cp config.json docker-volume-vsphere /tmp/plugin
cp: cannot stat 'config.json': No such file or directory
cp: cannot stat 'docker-volume-vsphere': No such file or directory
Makefile:95: recipe for target 'plugin' failed
make: *** [plugin] Error 1
scp: /tmp/docker-volume-vsphere/build: No such file or directory
sh: 0: Can't open /tmp/docker-volume-vsphere/build/plugin_sanity_test.sh
bash: line 0: cd: /tmp/docker-volume-vsphere/plugin: No such file or directory
make: *** No rule to make target 'push'.  Stop

/CC @govint @msterin

There is a possibility of the race condition due to drone CI system. We are consuming 8 drone workers and validate-and-serialize.sh is responsible to make them serial by making sure only one CI run is possible any given time.
There is likely to be an issue more than one worker node ends up getting running at the same time and might be causing the issue.
As a next step more logging should be added to debug the issue further.
Meanwhile I will also find out how to control multiple simultaneous drone runs.
/CC @msterin

Note: the failed runs have the following from validate-and-serialize.sh : Mark Sterin: govc: Error caused by file /vmfs/volumes/57564dec-d9876af8-b29e-0cc47ac34f38/docker-volume-vsphere/ongoing/910

I am using this issue to investigate further to resolve race issue on CI run. First, I will send out a PR containing some additional log statement that helps debugging further.


[AutoPR] mediaservices/resource-manager

Created to accumulate context: mediaservices/resource-manager

(message created by the CI based on PR content)

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/mediaservices/resource-manager/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/blob/master/specification/mediaservices/resource-manager/readme.md for you!!!

Nothing to rebuild, this PR is up to date

Codecov Report

Merging #4647 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #4647      +/-   ##
==========================================
+ Coverage   49.49%   49.49%   +<.01%
==========================================
  Files        6341     6342       +1
  Lines      177577   177593      +16
==========================================
+ Hits        87889    87900      +11
- Misses      89688    89693       +5

Impacted Files
Coverage Δ

...els/streaming_policy_widevine_configuration_py3.py
66.66% <ø> (ø)
:arrow_up:

...zure-mgmt-media/azure/mgmt/media/models/job_py3.py
35.71% <ø> (ø)
:arrow_up:

...ure/mgmt/media/models/audio_analyzer_preset_py3.py
66.66% <ø> (ø)
:arrow_up:

...e-mgmt-media/azure/mgmt/media/models/preset_py3.py
75% <ø> (ø)
:arrow_up:

...edia/azure/mgmt/media/models/job_input_http_py3.py
62.5% <ø> (ø)
:arrow_up:

...edia/azure/mgmt/media/models/job_input_clip_py3.py
60% <ø> (ø)
:arrow_up:

...s/streaming_policy_play_ready_configuration_py3.py
57.14% <ø> (ø)
:arrow_up:

...ls/streaming_policy_fair_play_configuration_py3.py
62.5% <ø> (ø)
:arrow_up:

...dia/models/built_in_standard_encoder_preset_py3.py
62.5% <ø> (ø)
:arrow_up:

...dia/azure/mgmt/media/models/job_input_asset_py3.py
62.5% <ø> (ø)
:arrow_up:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874ca27...a6d7bbd. Read the comment docs.


[NoNuke] Multiple issues and feedbacks

Hey Alex
Been testing NoNuke, and here are the findings,
Issues

nonuke gets triggered when the config is set to false - which shouldn't happen.
Most of the time it isn't even triggering on mod actions, till you restart the bot a couple of times which means it's not getting injected - No error on the console.
For the DM that a user gets, can you remove the info on (X events in X seconds part), since that's something you don't want to share as the user will find a way to bypass it [..for exceeding {number} mod actions in {X} seconds]
Sometimes it throws an error saying - it can't remove roles due to not having proper perms, when it did remove and it had perms.
It doesn't respect what action you pick ONCE an action gets registered to cog's config, for example - when the action was set to strips and then you change the action to any of notify/kick/ban - it will still strip the roles from the user until you restart or reload the cog.

Feedback/Suggestion

For nonuke overload it would be amazing to have an option to individually select or pass the overload number for each "mod action".
So one option for kick/bans, one option for channel change, etc and you can pass different overload numbers for each one, more customizability per se.
Punish un-whitelisted users/admins giving dangerous perms (moderation perms, manage channel/server, manage permissions, webhook perms, etc) to other members (like wick) and strip their roles and the bot they may have used to give the role and strip the roles to the user who they tried on.
Punish un-whitelisted users/admins giving dangerous perms to ANY of the server roles.

Could we have an option where you get to select your main channels & roles & and the bot will monitor them,

Main roles - are the roles that people get when they join the server so any base role.
Main channels - are the channels that possess the most threat, where people chat the most, so your main chat channel.

The idea is to monitor and protect the main roles including @everyone from getting dangerous permissions. The same goes for main channels - to protect these channels' @everyone & main roles from getting dangerous channel permissions.
These are well-respected anti-nuke features that will make the cog way more useful than it already is.
It's an amazing cog and has a HUGE potential to be one of THE most needed cogs so thank you for making it.

The issues you have mentioned should now be fixed. the cog has been refactored to improve readability and use the audit log entry listener more efficiently.
As for the Feedback/Suggestions, I have little interest in adding any of that right now. NoNuke was never meant to be used as training wheels for server owners, but rather just a streamlined anti-nuke cog.

For the suggestion part, it's ALL part of the antinuke process per se & especially since now it already listens to the dangerous_perms on on_guild_role_update so, I feel those would have made the cog even better but no worries if you don't feel like it, not to mention it would take some times to implement such stuff

As for the update, after testing found a couple of things,
Since nonuke can't take action on users who's higher than the bot's highest role in role hierarchy (which is fine) nor does it send any response (in the logging channel) that - "it couldn't get triggered due to bla bla... " so

nonuke action - In the help embed it should include a warning something like -

I'm unable to take action on users with roles higher than mine in the hierarchy. Therefore, please ensure that my role is positioned above all staff roles.
(So that users can know that it's their fault that the bot didn't trigger)

2nd thing is, there's no way to know who are the whitelisted users. so,

nonuke view - could show the whitelisted users.

Whitelisted users are now displayed in the view command. Also actions already show in the logs if they fail like role stripping.


fix DOHIP config to allow ipv6 and domains

The doh-ip config item was designed only for ipv4 IP address, but however DOH queries are not only IPs, it can be a  domain.  According to rfc8484, the request is a http POST request to an address like https://dnsserver.example.net/dns-query
This is how the babolivier/go-doh-client implimented to use the Host value:
https://github.com/babolivier/go-doh-client/blob/a76cff4cb8b631ae9cc87d980d379694115c3862/http.go#L14-L21
Thus our doh-ip should allow the form of domain servers, like dns.google, ipv6 servers [2606:4700:4700::64], or customed server like <IP_ADDRESS>:7777

In the original implimentation, user cannot use an IPv6 server:
if config doh-ip = 2606:4700:4700::64，the config valids but in the DOH resolve they construct the POST to http://2606:4700:4700::64/dns-query, it's an invalid URL, DOH fails.
if config doh-ip = [2606:4700:4700::64], the way url constructs, but our program don't reconizes it as an IP. DOH fail.

Thanks for your effort! I feel myself awkwardly but I would like to reject a part on allowing a domain here.
Here is my rationale: the goal of the network abstraction in mtg is to encapsulate how traffic flows through the proxy outside. If we set a proxy there, then no bytes should escape. If proxy is set, then each octet should flow through this proxy. This is a reason why DOH is introduced in a first place. DNS is UDP protocol and most of the proxy implementations do not allow UDP tunneling. So, we have to have DNS over TCP so SOCKS5 and HTTP/HTTPS could be used.
If we speak on DOH, then bootstrapping phase has a "chicken and egg" problem: all requests for DNS queries should go via DOH. But how to resolve an IP if DNS host is set as a hostname? That's why we need to have bootstrap servers there: they are going to be used to resolve DOH's IP address at the time of the first request. But this will complexify a configuration. If we setup DOH as IP, then there is no need to resolve anything and 0 bytes will escape a proxy. In other words, no system DNS resolver will be used.
So, this constraint was set explicitly with a purpose I hopefully explained.
And thanks for the pointing out to the issue about IPv6. If you could concentrate on it only, it would be really helpful!

@9seconds
I agree, the DOH also have similar concern that they make the DOH server provide both domain and IP address protected TLS certificates.
Also it occurs to me that there is a much easier solution for an IPv6 address DOH in mtg, see PR #223 , I will close this one.


Fix Menu Insert convertion

Makes callback not become string
(also DeleteAll -> Delete in Menu_ex7.ah2, silly me)

is there a new test that can be added that shows that new callback/nonstring conversion?

It was part of Menu_ex7 but I added a focused example in Menu_ex8


new put api added

In this, I have added the put api for the post request of analyze_img_file here first we have to add the data through post api and then with the help of put api we can change the orignal data and we can also see the changes of old and new file #16

Can you create a different POST API which is simpler (text bases) and add PUT API for it.

Can you create a different POST API which is simpler (text bases) and add PUT API for it.

I have done the work you have asked, so please review it once more

I have done the changes you have asked, sorry for above code and please review it

The second file was added by mistake so ignore it, I have also removed the changes from commit

Merging this change will delete case_convert.py from main repo.
Make a fresh branch .. make only changes in the required file and raise a new PR.


Wrong number of arguments or invalid property assignments

I have a JSON-document. I am trying to parse it and facing an issue of wrong number of arguments...

When I am watching the expression, I can see the value:

but when I am trying to put this value into the cell, I am facing the issue of the wrong number of arguments...
JSON-document is as follows:

I identified the issue but I don't know how resolve it. I can't construct a right if-statement!
if I use Item("resolvedBy")<>empty then it works for the first line but doesn't work for the second becuase this key contains other keys.
if I use Item("resolvedBy")("display")<>empty it works for the second line but not for the first because there is no key "resolvedBy" in the first line.

Empty only apply to non object data types.
Yet, your item hold a dictionary.
Try with the IsEmpty() function.

ParseJsonwill never give empty values in the structure.
I don't see a resolvedBy key group until item 4.
You will have a similar problem with the resolution key group.
Test for keys inDictionariesusing Item.Exists(key)
So, IF resolvedBy is always present with resolution, you can do something like:
    Dim keygroup As Dictionary
    If Item.Exists("resolution") Then
        Set keygroup = Item("resolvedBy")
        Sheets(1).Cells(i, 6) = keygroup("display")
        Set keygroup = Item("resolution")
        Sheets(1).Cells(i, 12) = keygroup("display")
      End If

If this solves your problem, please close your issue here.

IsEmpty()

It helped.

Final solution that worked:
If IsEmpty(Item("kanalObrasenia")) = False Then Sheets(1).Cells(i, 2).Value = Item("kanalObrasenia")(1)
If IsEmpty(Item("kontaktnoeLico")) = False Then Sheets(1).Cells(i, 3).Value = Item("kontaktnoeLico")
If IsEmpty(Item("klient")) = False Then Sheets(1).Cells(i, 4).Value = Item("klient")
If IsEmpty(Item("telefon")) = False Then Sheets(1).Cells(i, 5).Value = Item("telefon")
If IsEmpty(Item("email")) = False Then Sheets(1).Cells(i, 6).Value = Item("email")
If IsEmpty(Item("createdBy")) = False Then Sheets(1).Cells(i, 7).Value = Item("createdBy")("display")
If IsEmpty(Item("components")) = False Then Sheets(1).Cells(i, 8).Value = Item("components")(1)("display")
If IsEmpty(Item("tipZadac")) = False Then Sheets(1).Cells(i, 9).Value = Item("tipZadac")(1)


support scala3 on unix-domain connector

part of #126

@He-Pin I'll have to do this PR again. I was fixing up your merge of the mqtt-streaming fix and my forced push happened after you merged this. I was trying to keep all these squashed on merge so that each commit on scala3 is one PR.

@He-Pin I'll have to do this PR again. I was fixing up your merge of the mqtt-streaming fix and my forced push happened after you merged this. I was trying to keep all these squashed on merge so that each commit on scala3 is one PR.

i see, i missed there are two commits


Key Error 'event'

@receiver(webhook_event)
def handle_all(sender, event_type, data, **kwargs):
	print "Testing HEAD"
	if event_type == 'inbound':
		cdata = data['msg']['to'][0][0].split('@')[0].split('~')
		cuuid = cdata[0]
		hotel_id = cdata[1]
		client = Client.objects.get(uuid=cuuid)
		connection.set_tenant(client)
		try:
			attachments = data['msg']['attachments']
			akeys = attachments.keys()
			for k in akeys:
				data = attachments[k]['content']

				ie = InEmail.objects.create(odata=data)
				import_data_to_models.delay(client.id, hotel_id, ie.id)
		except:
			pass
	else:
		try:
			metadata = data['msg']['metadata']
			client = Client.objects.get(uuid=metadata['client'])
			connection.set_tenant(client)
			oe = OutEmail.objects.get(uuid=metadata['oe'])
			oe.data = data
			oe.oe_type = event_type
			oe.save()
			print "Testing Done"
		except:
			pass

I'm getting a key error Event occasionally.
```

return view_func(*args, **kwargs)
File "/Users/andrewfam/.virtualenvs/snagfin/lib/python2.7/site-packages/django/utils/decorators.py", line 30, in bound_func
return func.get(self, type(self))(*args2, **kwargs2)
File "/Users/andrewfam/.virtualenvs/snagfin/lib/python2.7/site-packages/djrill/views.py", line 67, in dispatch
request, *args, **kwargs)
File "/Users/andrewfam/.virtualenvs/snagfin/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
return handler(request, *args, **kwargs)
File "/Users/andrewfam/.virtualenvs/snagfin/lib/python2.7/site-packages/djrill/views.py", line 82, in post
sender=None, event_type=event['event'], data=event)
KeyError: 'event'

It looks like this could occur if your Mandrill webhook is configured to send whitelist/blacklist sync events.
The sync events webhook didn't exist when webhook support was added to Djrill, and it seems to not follow the format of the earlier message and inbound event webhooks that both use an 'event' key to identify their types.
We'll need to update Djrill to handle sync events. In the meantime, a workaround is to un-check the "Rejection Whitelist Changes" and "Rejection Blacklist Changes" triggers for the Djrill webhook in your Mandrill webhooks config: https://mandrillapp.com/settings/webhooks. (There's an "edit" command for an existing webhook hiding in the arrow next to "send test".)
(If you don't have the rejection blacklist/whitelist triggers set, then there's some other problem with Mandrill sending out-of-spec data. If that's the case, it would be helpful to see the event object from the line that's failing.)

Thanks for this i'll check it out


Interactive UI for discovering services and setting up port-forwarding

Is your feature request related to a problem? Please describe.
During development I often need to make ad-hoc requests to a service running in my cluster
Describe the solution you'd like
I would like Monokle to show me a list of available services (similar to what kubectl get services does) and provide a simple UI for starting/stopping port-forwards for any/each of these on my local machine
Describe alternatives you've considered
none
Additional context
none

Any plans on taking this up?

Any plans on prioritizing this?


Adds format and extent to RecordDetail component

Adds format and extent to records component, fixes #156

Looks good! It makes sense to just call out the non-document stuff.


feature: CircleCI new flow

What kind of change does this PR introduce? (check at least one)

[x] Build-related changes

Does this PR introduce a breaking change? (check one)
Not a breaking change, but from this point on codeship is not supported out of the box.
Did you test your solution?

Was tested within CircleCI

Problem Description
Migrating from codeship to circleci.
Solution Description
Main Branch flow

PR Flow

Side Effects, Risks, Impact

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-53f45a3.generator.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-e59f697.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-22f45dd.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-34de3e8.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-f3cc74a.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-f7e9c7e.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-2253155.dev.devops-boilerplate.jam3.cloud.jam3.net

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-eab918c.dev.devops-boilerplate.jam3.cloud.jam3.net

@DonghyukJacobJang I will try to fill them this month, instead of just being "test". Let's just merge it and iterate from here

[AUTOMATED] Latest version has been pushed to preview.
Preview deployed at https://preview-cf6fd7b.dev.devops-boilerplate.jam3.cloud.jam3.net


add Linux support

Hi there!
Im just found you plugin for gulp fonts convertation, but when i try to use it, it returns me a message "We are missing some required...". As i am a linux user and i don't have brew package manager, i started looking for this dependencies in apt and npm repos. Fontforge, ttfautohint and ttf2eot i found without problems, but batik-ttf2svg is realy hard to install on linux, so i keept looking for alternatives and found this: https://github.com/qdsang/ttf2svg Looks like this plugin converts fonts as good as batik-ttf2svg does. So i made little changes in your plugin and implemented ttf2svg as a solution for linux os. Please, take a look.

Thanks @LamerVK. It's easy for me to forget platforms I'm not using. I am also adding successful committers as managers of the project as a policy now. Feel free to ignore the invite if you like -or- you may want to push a version bump ☺.
Thanks again for your contribution.

Hi!
Can you update plugin on npm, because when I install it from npm, I get an old version without Linux support)


Coverage is broken

https://travis-ci.org/rexim/pacman.el/jobs/83185932#L350

From the notes in the official undercover.el repo https://github.com/sviridov/undercover.el

it based on edebug and can have some issues with macros coverage

Some info from official Emacs Lisp reference on instrumenting macros:

http://www.gnu.org/software/emacs/manual/html_node/elisp/Instrumenting-Macro-Calls.html#Instrumenting-Macro-Calls


Updating Exports Limits to be a table

Changing Export Limits to a table and updating content to with at little more detail.

@markjjo and @mahage-msft

@markjjo and @mahage-msft

@marstev PR merged

@marstev PR merged


General issues with converting from conda to pixi

Problem description
Hello Pixi devs,
I have listed some issues that i have faced when testing moving to pixi from conda.

The install script should have an option to explicity specify the pixi install location. Defaulting to $HOME is fine but in corporate environments the home folder is very limited in space/locked down/automatic cleanup etc and generally the dev tools are installed on local drives (e.g /scratch).  I solved it by setting the PIXI_HOME env variable, but this is information is not readily apparent in the documentation.
Also related to the above point, the PIXI_HOME could be automatically set by pixi when an install loation is specified
The auto complete  magic echo 'eval "$(pixi completion --shell bash)"' >> ~/.bashrc is appended to the end of the .bashrc  file. This is fine for cases where the file doesn't contain conda activation block but for cases where a conda activation block is present, the modifications should be above this section since conda recommends it's data should be at the end of the file. To be specific, it would be good if pixi related changes are made above the following lines to reduce friction in moving from conda

# >>> conda initialize >>>
# !! Contents within this block are managed by 'conda init' !!

After installation, the pixi activation is added to bash_profile and not .bashrc, this will result in non login shells not having pixi avaialble. Conda adds to .bashrc and not to bash_profile
After installation i tried to use the recommended method to import a conda env with the command pixi init --import environment.yml and i got the following error

  × The current system has a mismatching virtual package. The project requires '__linux' to be at least version '5.10' but the system has version
  │ '3.10.0'

I searched the issues and found that the following needs to be set which is not readily apparent in the documentation. If i have made any mistakes, please feel free to correct me.
[system-requirements]
linux="3.10.0'"

If you ask why the version is so low, we use RHEL-7.9 and this is generally the standard in HPC, Uni / Research institutes. And soon it will be upgraded to RHEL-8.9 which has the version  RHEL 8.9 | 4.18.0-513.5.1.el8_9 .  Conda packages are built with the conda compilers which themselves have very low glibc requirements right? so the packages installed by pixi via conda should have no issues with these uname versions. I t would be good if the above error is removed and the required block directly added to the pixi.toml

The most important of all, to connect to internet the machines use proxy and also a custom ca-certificate. This is configured in the .condarc file via the proxy setting and also via conda config --set ssl_verify <pathToYourFile>.crt . There is no possiblity for the users to update these settings globally. It would be good if pixi also would use the same/similar configuration for connection. As of now, the install works only when i am not in the office network. I have also detailed the erros for this in https://github.com/prefix-dev/pixi/issues/1035.

Thanks for your awesome tool. I am testing this and working with it successfully in for home office setting and hope to be able to use it also in office setting.

Thank you @vigneshmanick, this is really useful information, I'll take a more in depth look later and probably move some items into issues or PR's!

@ruben-arts i have some further points regarding the issue. Would you prefer that i update the issue description here or create another ?

Please update it here, I don't think we've gotten around creating individual issues out of them yet :) Thanks for all the testing!

Have updated the description and might add more points as and when i face them.

Talking about requirements.txt, it would be useful to be able to pixi add requirements.txt or pixi init --import requirements.txt

I have a problem related to this issue: PATH is modified by the Pixi install script only in .bashrc, and in most systems .bashrc is configured not to work in non-interactive shells, which means I can't execute remote commands such as ssh myhost pixi global add blabla, as they are executed in non-interactive shells.
The Pixi install script should modify PATH not only in non-login startup files as it does now (.bashrc, .zshrc, etc.), but also in login startup files (.profile, .bash_profile, .zlogin, etc.). I'd suggest following the logic used by userpath, which is a standard tool for doing such things.

I investigated it a bit more, and it turns out that it is annoyingly hard to properly add something to PATH so that it works in all typical circumstances. Basically we want the PATH to be updated in both interactive and non-interactive shells, we should add the appropriate commands:

in bash: to the beginning of .bashrc (before the check if shell is interactive, which is usually at the top of the file)
in tcsh: to the beginning of .tcshrc (before the check if shell is interactive, which is usually at the top of the file)
in zsh: to .zshenv (which is always executed, unlike .zshrc, which is only executed by interactive shells)

In other shells, such as fish and xonsh, the rc files are always executed, so appropriate commands can probably be added to the end of the rc file.
I can submit a PR if needed.

for bash you could use $BASH_ENV to set values for non-interactive shells. I don't think it's a good idea to put any values before the check for interactive/non interactive is done. Generally all values in bashrc are set after this check and pixi is no exception here.

I agree, however it would still be better for the Pixi installer to update .zshenv instead of .zshrc.


Continuing PyWavelets development on PyPi

Hi @nigma, as you may have seen on my repo the activity has further picked up and we've decided to start creating new releases: https://github.com/rgommers/pywt/issues/61. We're planning on doing a v0.3.0 release which is fully backwards compatible and with Python 3.x support this weekend. And quickly after that a v0.4.0 with more new features and refactoring.
Our question is whether you are okay with giving us (one or more of me, @kwohlfahrt, @grlee77 and @aaren) access to https://pypi.python.org/pypi/PyWavelets so we can put those releases there. That would be friendlier to users than renaming the repo and making it really a fork.

My PyPi username is rgommers if you'd like to give me access.
At all: please add your PyPi username here as well if you'd like to get access.

And let me extend the request to ReadTheDocs - would be nice to be able to update that as well. I guess that needs pointing readthedocs to my repo and giving me permissions for pywavelets.readthedocs.org

Hi @rgommers, that sounds great and thanks for taking over the development of this project.
I'm more that happy to give you access to PyPI, ReadTheDocs and other resources.
I already sent you an invite to PyPI. Please let me know if you can log in and see the project details there.
I'll need your ReadTheDocs username in order to add you to the maintainers list.
Let me know if there is anyone else I should send invites to.
Is there anything else I can help with? Do you need access to this repository? I was thinking that I should perhaps move it to an organization account as it is still getting a lot of traffic.

@nigma fantastic, thanks! I do have access on PyPi now. The PyPi access also gives access to http://pythonhosted.org/PyWavelets/ it looks like.
For ReadTheDocs my username is also rgommers.
Access to this repo so I can close issues and close/merge PRs may be useful as well. Starting an organization repo is a good idea, however I think it would be better to move my repo to that org rather than yours, because mine already has accumulated a lot more issues and PRs.

There's also http://www.pybytes.com/pywavelets/, which is by now simply a copy of what's on ReadTheDocs and pythonhosted.org. Does it add anything to keep that site? It may be easier to just remove all references to it from the docs....

Got access on ReadTheDocs, thanks @nigma

And got access to this repo as well. Plus you joined the new PyWavelets org. So all set here!

Except for your opinion on http://www.pybytes.com/pywavelets. The Wavelet Browser that is also on that site is nice, but the pywavelets part of the site is a third copy that would be best phased out imho.

I'm updating the readme in this project to let the people know about the new home.
Yes, what's left on my side is to update the pybytes.com/pywavelets and redirect to readthedocs. I'd like to put proper redirects there or temporarily upload a copy of the new docs so people visiting the site from google (a couple thousand unique visitors a month) don't get a nasty 404.
We should also clean up some of the wording and highlight the new maintainers in the readme and docs. Please feel free to make any changes as you see suitable.

New repo location: https://github.com/PyWavelets/pywt (10 minutes young).

Proper redirects sounds good to me.

In https://github.com/PyWavelets/pywt/pull/73 I changed the docs and in https://github.com/PyWavelets/pywt/pull/79 I added release notes for v0.3.0 with some explanation of the repo move and history. Will update now for rgommers -> PyWavelets and then it's pretty much done I think.

Closing this, all done a long time ago.


MM-22754 Fix for missing closing bracket

Summary
Adding the missing bracket in translation files
Ticket Link
https://mattermost.atlassian.net/browse/MM-22754

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4988.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

@sudheerDev
I am seeing an error on this test server when using alt+click  to mark a post as unread. The change on this PR is minimal and I am not sure it's related to this error. I checked master.test server and the alt+click doesn't error there.
I am including 3 screenshots from chrome, firefox and safari

@jgilliam17 Naah, Not related but thanks for pointing them out. I think the errors are based on the latest changes to master so probably not updated on the test server yet.

Thanks @sudheerDev
Otherwise - all looks good!
And thanks @nevyangelova for a quick follow up on commented errors.

Test server destroyed


[FEATURE REQUEST] Please add batch mode

Hi XyLe-GBP,
I want to convert a lot of files to at3, but doing so 1 by 1 is tooo slow. If I drag and drop many files, I got an error:

Fixed an error when encoding multiple files in an update.
If the problem still exists, please write here.

It is ok now, thanks!


Add Test to Catch Missing Permissions

This PR adds a test that checks that at least one user (admin) has all the permissions for the TO API routes. It will catch #6603 and #6609 with a test failure.
Note: until #6609 is fixed, the TO API tests on this PR will fail.

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?
Run the TO API tests and verify they pass.

PR submission checklist

[x] This PR has tests
[ ] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

The definition of the "admin" Role is that it has all Permissions past, present, and future. The set of Permissions afforded to the "admin" Role isn't even checked by Traffic Ops, so this is testing unintended behavior.
For example: The year is 2024, and I'm adding Foos as a new object to the Traffic Ops API. Foos are not related to any existing objects, and don't affect them in any way. Which users should be granted the FOO:READ and FOO:CREATE Permissions?
The intended answer is "none" and an "admin"-Role user will be responsible for doling out those new Permissions to whatever Roles need them. That's why we enforce an "admin" Role must exist, and why we treat it specially the way we do.


Including CodeCracker

include CodeCracker analyser.

@carloscds : Thanks for your contribution! The author, @kuhlenh, has been notified to review your proposed change.

@kendrahavens @mavasani Is this okay to include?

Hi @carloscds, could you give a brief description of why this change should be included here? Forgive me, I'm not too familiar with the CodeCracker project. There are many analyzer packs in the ecosystem that we could link to in our docs, but I don't think the docs are the best discoverability mechanism for the hundreds of options out there.
@jinujoseph @sharwell In case, you have input on this as well.

@kendrahavens CodeCracker it's one of fist project about Roslyn Anayzers. Microsoft already use it in many events and @sharwell know this project. You can seek more about at https://github.com/code-cracker/code-cracker

Thanks @carloscds. We can add it then!
My minor concern was this doc could become overloaded with external links and make discovering the built-in tools (the main purpose of docs.microsoft.com) more difficult. That's definitely not a worry at this stage so we can add the link you suggest.

@kendrahavens Thanks, for me CodeCracker is the same of StyleCopAnalyzers, for example.

@carloscds Yep that was my view as well


Local store publishes

user's publishes are stored in local storage, and displayed below the publish tool on the home page
updated the css for links site-wide.  Still need to do a BEM overhaul

will be replaced by PR #170


add: new package pdf_beamtime

As of now, the new package pdf_beamline only constructs the obstacle environment.
TODO: refactor the code in pick_place_server.cpp to a header-class style format.
TODO: separate the obstacle creation into an independent node.
Note: There are commits related to the hello-world package I changed initially that have polluted the pull request.

Test are failing because the test containers are inadequate. @maffettone will fix in a future PR. Looks good to get moving!


Link in "Generate Random Fractions with JavaScript" challenge leads to 404

Describe your problem and how to reproduce it:
Just visit this page here:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/generate-random-fractions-with-javascript
and click the "Storing Values with the Equal Operator" link. It leads to a 404 page.
The correct link should be this one:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/storing-values-with-the-assignment-operator/
Add a Link to the page with the problem:
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: 72.0.3626.121
Operating System: Mac OS 10.14.3

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@coinfreakgr can you check if this issue is there in our beta site - www.freecodecamp.rocks

Problem not replicable in the latest build of rocks. I'm closing this issue. @coinfreakgr the fix would soon be shipped to production. Thanks for opening the issue


TimeZone problem with check_availability

Hi,
Having an interesting problem which I cannot solve, would appreciate any feedback:
[1] pry(#<#<Class:0x007fd082dcde80>>)> slots = date.schedule.occurrences_between(date.schedule.start_time,date.schedule.end_time + 23.hour)
=> [2017-03-01 09:00:00 +0200, 2017-03-01 10:00:00 +0200, 2017-03-01 11:00:00 +0200, 2017-03-01 12:00:00 +0200, 2017-03-01 15:00:00 +0200, 2017-03-01 16:00:00 +0200, 2017-03-01 17:00:00 +0200]

Above, I get the available slots for a day, and they are returned in the correct timezone and all looks good. Further info on these "slots":
[3] pry(#<#<Class:0x007fd082dcde80>>)> slots.last
=> 2017-03-01 17:00:00 +0200
[4] pry(#<#<Class:0x007fd082dcde80>>)> slots.last.zone
=> "SAST"
[5] pry(#<#<Class:0x007fd082dcde80>>)>

I then do an availability check on one of the slots, and I see the below. Note the line Datetime('2017-03-01T15:00:00Z')) - this is 2 hours BEHIND the slot.last timezone it showed above.
[2] pry(#<#<Class:0x007fd082dcde80>>)> date.check_availability(time: slots.last, amount: 1)
   (0.1ms)  SELECT COUNT(*) FROM "acts_as_bookable_bookings" WHERE "acts_as_bookable_bookings"."bookable_id" = ? AND (Datetime(time) = Datetime('2017-03-01T15:00:00Z'))  [["bookable_id", 17]]
=> true
[3] pry(#<#<Class:0x007fd082dcde80>>)>

Some further examination of timezones in use are:
[5] pry(#<#<Class:0x007fd082dcde80>>)> Time.now
=> 2017-03-01 11:22:44 +0200

[6] pry(#<#<Class:0x007fd082dcde80>>)> Time.now.zone
=> "SAST"
[7] pry(#<#<Class:0x007fd082dcde80>>)>

Any ideas on how I can get these timezones to align?

Semi obvious now that I see it but I was creating my bookables with +0200 timezone, and I should have done it in UTC.
I converted my bookable creation to UTC:
IceCube::Schedule.new(date.utc, duration: 45.minutes)


refactor: rename bitDepth to depth

closes #444

Would it be simpler to remap bitDepth to depth when passing the options to fast-png?

Would it be simpler to remap bitDepth to depth when passing the options to fast-png?

Simpler but mainly non-breaking

You can merge with main to get rid of the CI errors

Can you please add a test that would fail before the fix?

You fix the encodePng function, so the test should execute that function, not the one from fast-png directly.

So the image must be converted to 8 bits first ? Since the encodePng function only accepts a prop of type Image where bitDepth is mandatory (so we can't test directly with the default value of fast-png)

I don't see why it would have to be converted to 8 bits first. bitDepth is mandatory, but its value doesn't have to be 8.

Oh, okay I had misunderstood this

Can you please add a test that would fail before the fix?

I thought I should write a test that shows the previous error

You should write a test that pass with the fix and doesn't pass without the fix.

The previous error was that the attribute depth in fast-png wasn't getting any value from img since it was named bitDepth
But now bitDepth is renamed to depth inside encodePng, so I don't see how I could go back to the error in the test

You're correct, and that's not what I'm asking.
Somehow I'm not making myself clear but I don't know how to say it differently 😕


Add multifle predicate token_by_regex/2

This would take a tag atom and a regex expression, and generate tokens with the given tag if they match the regex. E.g.:
user:token_by_regex(keyword, "(class|if|then|end)").

:- tokenize("class foo", Token), Token = [keyword(class), spc(' '), word(foo)].

Suggested by @Anniepoo in the context of making user-extensible token rules.

This should be on hold, since #24 may supersede.


Provide an alternative to Icon.add

Is your feature request related to a problem? Please describe.
Normally, when we use icons in our components, we will import the specific icon and use it directly, e.g.
import AssignmentIcon from '@material-ui/icons/Assignment';

<AssignmentIcon />

EDS requires pre-registering the icons via Icon.add, which means we have to maintain this list in our project separately from the component that uses it, and doesn't feel particularly developer-friendly.
Describe the solution you'd like
I would like to avoid using Icon.add. The simplest option that occurs to me is to have a data property to Icon where we can pass the object imported from eds-icons, e.g.
import { save } from '@equinor/eds-icons';

<Icon data={save} />

Alternatively. provide pre-defined components for each icon, like material-ui. The latter option seems like a lot of work unless it was automatically generated.
Describe alternatives you've considered
Currently, we have just written a wrapper for Icon that automatically invokes Icon.add for us via hooks.

Good suggestions! 👍
We had a long discussions about how to do the Icon component api during development (#177) We landed on the Font Awesome approach because most of the times you have a set of icons you use for application and thats it. Although everyone have different preferences and use-cases that might need a different approach.
We are leaning more towards the data prop approach, as this would make it easier to compose the icon as needed to match any use-case or preference when consuming <Icon>


ui: Fix groupaction for nw cleanup and Notify when groupaction fails

Description
Fixes https://github.com/apache/cloudstack/issues/6330
Shows cleanup when restarting a network in group action irrespective of the type of network
Also throws an error notification when a group action fails
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6333 (SL-JID-1489)