feat: call known lineage variants

Description

TODO:

[ ] Instruct varlociraptor to keep the added INFO fields in the candidate VCF.

Related Issue

Checklist

[x] I've formatted the PR title in accordance with the structure of the conventional commit messages.
[x] I've updated the code style using snakefmt workflow/ and black workflow/ if needed.
[ ] I've updated or supplemented the documentation as needed.
[x] I've read the CODE_OF_CONDUCT.md document.
[x] I've read the CONTRIBUTING.md guide.

There could be a bug in the table. I`ve downloaded the report from the ci (https://github.com/IKIM-Essen/uncovar/suites/4854581277/artifacts/138042043) and noticed the following:
Some variants occur twice in the table, e.g. ORF1a:G3676- in the Illumina test sample.
Moreover, the green checkmarks are not consistent in these two occurrences.
First occurrence of ORF1a:G3676-:

Second occurrence of ORF1a:G3676-:

There should be only one occurrence in the table per variant, should it?

P.S.: I would vote to move the Lineage Name to the Header. Else it is not shown when scrolling down the table.

The problem with putting the lineage name in the header (as it was before) is, that we can't use the standardized headers in the Stylesheet for formatting, as they're changing dynamically 😕
Repeating occurrence of several mutations is not as planned. Maybe that comes from whatever reformatting I did, I'll check

Could it be that the html table is broken? At least in the CI this is generated:


lock node_modules when running

you can do two pnpm install's at the same time at the same project, though it will probably break things along the way. a lockfile will solve this.

I think the lockfile should lock the store rather then the store because the store can be shared between several packages. Also it should lock during uninstall as well


Patch for /port/port.h

Original issue 145 created by zhaowb on 2013-02-06T13:05:12.000Z:
include port/port_win.h when LEVELDB_PLATFORM_WINDOWS is defined

Not a supported branch.


Fix/issues 302

Description
Please explain the changes you've made
change private property
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@codding-y PTAL
@yanzhangpeng resolve conflict


aarch64 tests no longer running on CI

As of https://github.com/bytecodealliance/wasmtime/pull/2936 all our tests do is print out QEMU's version and then exit. Apparently if you have QEMU_VERSION set in the environment then qemu just exits out early. Who knew!
Wanted to open an issue for this so we don't forget, but I'm currently testing some other CI changes and hope to post a fix soon.

That is quite the qemu feature. Thanks for noticing this!


Chore: generate numerical IDs for docs articles

Rationale: the non-numerical IDs look like garbled words,. my brain keeps trying to parse them which trips me up ever so slightly each time I glance at the url.

since we'll be re-working most of the docs, shall we re-generate everything using the new IDs?

since we'll be re-working most of the docs, shall we re-generate everything using the new IDs?

I would prefer not, we have managed to not break URLs so far, and I think it's worth continuing. We will actually keep most of the current 0.2 articles under the new "CUE SDK" brand.


KETTLE-71: Jenkins pipeline for Kettle

Opening a new PR under me since the previous one couldn't be merged before @gtirloni's last day.

@amb26 This adds CI based on Jenkins for Kettle, as Buildkite was deemed unsuitable.


[AutoDiff] Remove upstreamed tensorflow branch tests.

Remove upstreamed tensorflow branch derived conformances tests for
Differentiable and AdditiveArithmetic.
These were upstreamed in test/AutoDiff/Sema/DerivedConformances.

Merging without testing since the target branch is tensorflow-stage.
Changes will be tested before merging to tensorflow.


Example from readme fails to operate

I'm submitting a ...

[X] bug report

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
Example from readme fails to operate. Browser console shows a lot of errors:
[Vue warn]: The "data" option should be a function that returns a per-instance value in component definitions.
[Vue warn]: Property or method "schema" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
Property or method "model" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
[Vue warn]: Property or method "formOptions" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Just follow your readme

What is the expected behavior?
Demo form shown + no errors in browser console, I suppose; idk what is meant to be expected behaviour of the demo from your readme to be honest.

What is the motivation / use case for changing the behavior?
Up to the maintainers of the package

Please tell us about your environment:

Version: 2.2.2
Browser: Chrome 66.0.3359.181 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
Language: ES6 transpiled, I suppose.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
N/A

Please provide more detail, outline the steps you took... please provide your code.

I am also finding the same behaviour - init a project using vue-cli, add a new component testform.vue, copy the sample code in from here and see the same errors in the console.
I also think the code needs to import validator from "vue-form-generator"

I had something similar starting from the gitbooks example usage. To get it working I needed to:

add in import Vue from 'vue';
change validators.string to VueFormGenerator.validators.string
move the whole formOptions object down beyond the next } (as currently it is wrongly a member of the schema object)
(optionally) add in import 'vue-form-generator/dist/vfg.css';

Thanks for what looks like a useful system, and I look forward to using it fully.

For completeness note that, as the docs indicate, for usage in a local component, I replaced:
import Vue from 'vue';
Vue.use(VueFormGenerator);

by (after the export default {:
  name: 'SampleForm',
  components: {
    'vue-form-generator': VueFormGenerator.component,
  },

I’m working on the docs over the holiday, so I’ll try this out and see about getting it updated.
We’ve migrated the docs on GitBooks to a GitHub repro (vue-form-generator-docs), so feel free to submit a PR with changes.

@trickidicki PR #571 should resolve the README.md example

@PeterC66 the GitBooks docs have been moved to https://vue-generators.gitbook.io/vue-generators/
I've fixed the sample code in the usage section (as well as the README.md in the main project)
The updated examples should work with @vue/cli 3.x projects (tested with 3.0.1 and 3.2.1)


[QST] can we first filter then join?

https://github.com/NVIDIA/spark-rapids/blob/df00904433514930a2dbbdd8ae3ec9043dc3dc3d/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/GpuHashJoin.scala#L257
https://github.com/NVIDIA/spark-rapids/blob/df00904433514930a2dbbdd8ae3ec9043dc3dc3d/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/GpuHashJoin.scala#L258
https://github.com/NVIDIA/spark-rapids/blob/df00904433514930a2dbbdd8ae3ec9043dc3dc3d/shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/GpuHashJoin.scala#L268

Spark already does a filter push down as a part of join optimization.  If a conditional only involves one side of a join then it is pushed down before the join.  In other cases it cannot be pushed down so the filter happens after the join.  In fact filtering after the join only works for Inner joins because for all other joins you may need to evaluate the conditional for all combinations of matching keys to see if the condition will allow or exclude the row from being created.
We are working with cudf to be able to push the conditional into the join so we can reduce the amount of data that is materialized and increase conditional joins to include non-inner joins.  But that is not likely to show up until the 0.16 release of cudf at the earliest.


[tx] Update SQL materialized views when schema assertions are installed or altered

I just didn't get to this in #170.  This ticket tracks updating the SQL materialized views (ident, schema, and potentially parts) and the Mentat Schema in response to :db/ident, :db.install/attribute and :db.alter/attribute assertions.  (For bonus marks, also handle :db.install/partition.)
There's some light magic required to handle altering attributes.  We can either convert values, or assert that there are no values, or ...

Heh, I broke this into #294 and #295, which are a little more detailed.


Added Github, Reddit & Telegram to the icons

I missed the , from web3uikit/src/components/Icon/collection.tsx(224,5):  it caused this error syntax error TS1005: ',' expected.
I have now included it in the fix


Error if messed with Slider then goes back into simple mode

When changing transparency with the slider in advanced then going back to simple mode an error that prevents the pack from being made happens

I think this is fixed in the 1.3 update.


Database Migration - Users

The long-awaited migration!

It has become apparent that this should be handled gradually instead of all at once. Thus I am closing this pull request with no merge.


minuteInterval is not working in 'time' mode

Hello, I am using the time picker but the minuteInterval is not working for me both on default and spinner displays.
  const [isTimePickerVisible, setIsTimePickerVisible] = useState(false);
  const [minuteInterval, setMinuteInterval] = useState(5);

 {isTimePickerVisible && (
              <DateTimePicker
                mode="time"
                value={new Date()}
                is24Hour={true}
                minuteInterval={minuteInterval}
                display='default'
                onChange={(event, date) => {
                  setIsTimePickerVisible(false);
                  if (date != undefined) {
                    let hours = date.getHours();
                    let minutes = date.getMinutes();
                    //const seconds = time.getSeconds();
                    if(hours<7 || hours > 16 || (hours === 16 && minutes !== 0))
                    {
                      wrongWorkingHoursAlert();
                    }
                      else{
                    if (hours.toString().length !== 2) hours = "0" + hours;
                    if (minutes.toString().length !== 2)
                      minutes = "0" + minutes;
                    setTimeString(hours + ":" + minutes);
                      }
                  }
                }}
              />
            )}

Would like to know if I am doing somthing wrong since I do not see any report about this issue.
Thanks.
Using Expo
RN Version: 0.62.2
OS: Android emulator and phone ( not checked on ios yet )
Library version: 2.6.1

@ShayGit Can you test this on 2.6.0 and tell us you the issue there, as well? It'd be greatly appreciated!

@ShayGit Can you test this on 2.6.0 and tell us you the issue there, as well? It'd be greatly appreciated!

Still not working on 2.6.0, maybe it is related to expo compatibility?
I am getting this warning:
Some of your project's dependencies are not compatible with currently installed expo package version:
 - @react-native-community/datetimepicker - expected version range: 2.4.0 - actual version installed: ^2.6.0
Your project may not work correctly until you install the correct versions of the packages.
To install the correct versions of these packages, please run: expo install [package-name ...]

The latest version in the expo is 2.4.3 according this PR and the implementation of the feature is in the 2.5.0 according the CHANGELOG need to update in the expo the datetimepicker version

:tada: This issue has been resolved in version 2.6.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@vonovak Still not working in 3.0.1 (not using Expo)

@spyshower yes, your edit is correct. We cannot control values that can be selected, so we correct the value after selection.
if this does not work for someone, please open a new issue according to the template, thanks


[Accessibility][ScreenReader]: Going back to text elements with shift-tab reads the element you just tabbed from.

Screenshots

Version
v4
Describe the bug
Actual: With JAWS ON, pressing keyboard tab to arrive at actionable links such as "Coronavirus/Covid-19 How to protect yourself and get care link" and other links,  JAWS announces "No" button for each link label.
Expected:  JAWS should announce "Coronavirus/Covid-19 How to protect yourself and get care link"  (instead of "No" button)
Additional context

[Bug]

This is fixed in #3287.


Feature/merge from drawio

Add second argument for addMouseWheelListener
Because I see code from jgraph/drawio and build of /etc/mxgraph/mxClient
https://github.com/jgraph/drawio/blob/master/src/main/webapp/js/mxgraph/EditorUi.js#L2097

The mx2 repo is behind, we'll create a new release asap to add this argument.


Does it support the automatic mode of react 17?

💬 Questions and Help
In react 17, new transforms have been added.
In react 17, the import React from "react" declaration is no longer required. So in my project, I removed the import React from "react" declaration from the svgr template. Then I got the error React is not defined.
export const template: any = (
  { template }: any,
  _: any,
  { componentName, props, jsx }: any,
): any => template.ast`
    import React from 'react'; // i want to remove this declaration
    import { Icon } from '. /ui/Icon';

    const ${componentName} = (${props}) => ${jsx}
    ${componentName}.defaultProps = Icon.defaultProps;
    export default Icon.withComponent(${componentName});
  `;

Is it possible that svgr does not support react 17?

Hello @harxki, https://github.com/gregberge/svgr/pull/613 takes care of it. Not released yet, but will be part of the next v6-alpha.

@harxki released as alpha, interested by your feedback!

@gregberge
Thanks for the release.
I've tried it in my project and I'm getting the following error.
ModuleBuildError: Module build failed (from ./node_modules/@svgr/webpack/dist/index.js):
TypeError: convert__default.default is not a function

The following is a template.
// "@svgr/webpack": "6.0.0-alpha.2"

export const svgrTemplate: any = (
  { template }: any,
  _: any,
  { componentName, props, jsx }: any,
): any => template.ast`
    import { Icon } from '../../components/ui/Icon';

    const ${componentName} = (${props}) => ${jsx}
    ${componentName}.defaultProps = Icon.defaultProps;
    export default Icon.withComponent(${componentName});
  `;

Try to upgrade every packages and to use the new templates API. In releases you will find details about it.


Start updating this again

srsly, it's been like two years
Maybe set an official start date of October or something

You can do it!

Duplicate of #99


python312Packages.macholib: init at 1.16.3

Description of changes
Adds https://github.com/ronaldoussoren/macholib which is required for other python binarys/applications eg. pyinstaller.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am testingnixpkgs-review right now

I am testingnixpkgs-review right now.

I am going to wait until ofborg builds (aka going to asleep) it so it doesn't take a long time for testing.

If you need me to I could squash my commits?

Squashed all of my commits.

Result of nixpkgs-review pr 344926 run on aarch64-darwin 1

4 packages built:

python311Packages.macholib
python311Packages.macholib.dist
python312Packages.macholib
python312Packages.macholib.dist

Just added testing and fix available platforms.

It would be great if you could split it into two commits, one for adding yourself to the maintainers list and one for adding the package. Sorry about the fuzz with the commit stuff

I have done both testing with sandbox to true and with it true.

It would be great if you could split it into two commits, one for adding yourself to the maintainers list and one for adding the package. Sorry about the fuzz with the commit stuff

Well it's squashed how could I un-squash it?

There are several ways, but the first way that comes to mind is git reset --soft HEAD~1 to undo the current commit and keep the changes in the staging area, then make two new commits

There are several ways, but the first way that comes to mind is git reset --soft HEAD~1 to undo the current commit and keep the changes in the staging area, then make two new commits

There are several ways, but the first way that comes to mind is git reset --soft HEAD~1 to undo the current commit and keep the changes in the staging area, then make two new commits

I asked in matrix as well but apparently there is a too called git-revise when you do git revise -i <commit-hash> it gives you an interactive persion to pick, sqrash, index & etc.

That probably works just as well too :)

That probably works just as well too :)

There separated the commits.


Adds support for different typed adjusted arrays and adds an EarningsCalendar loader

Moves most of AdjustedArray back into Python. The window iterator is
the only part that's performance-intensive.

Adds a bootleg templating system for creating specialized versions of
AdjustedArrayWindow for each concrete type we care about.

Adds support for differently dtyped terms in pipeline. This allows us
to use datetime64s which are needed in the EarningsCalendar.

Adds EarningsCalendar dataset for the next and previous earnings
announcements in pipeline.

Adds in memory loader for EarningsCalendar.

Adds blaze loader for EarningsCalendar.

other than the small comments your changes look good to merge.

This is ready to merge here.  Waiting on downstream compat changes.


Rewrite & Images

I'm seeing an issue with --rewrite in the latest version where image data is malformed. I updated the rewrite wildcard syntax which worked fine but then I noticed all the images would come back malformed and not render. Reverting back to v2 fixed the issue.

Fixed and released in lws-rewrite v2.0.4, please re-install local-web-server v3 to pick up the change - thanks for letting me know. 👍

Awesome, I'll test soon.


Allow publishing to npm

This PR adds publishing to NPM as part of the build chain. I've made a small repo showing how to use the built artefacts: https://github.com/pbugnion/dash-bootstrap-components-examples . This is released as 0.2.6-alpha1.
The distribution pushed to NPM is different from the distribution used by dash-renderer to build the components when dbc is used through Python. This is because dash-renderer expects its modules to be available on the window object (e.g. dash-bootstrap-components is available at window["dash_bootstrap_components/_components"]). However, when using a dash-bootstrap-components as a library in other JS components, the library needs to be made available through other import mechanisms (typically CommonJS, so basically import and export declarations work).
Practically, this translates into two separate output sections for the webpack configuration. The bundle used by dash-renderer is created with libraryTarget: window. The bundle used by other libraries is created with libraryTarget: umd (UMD is a superset of CommonJS). For the new UMD definition, I mostly copied Reactstrap's configuration.
To work, this requires PR #104.

Actually, before I merge this -- @tcbegley it'd be great to check that you can still create releases. We will need to do the following, I think:

You should create an account on NPM if you don't have one already
I presumably can then add you
You need to run npm login on any computer that you plan to push to NPM from. This writes an .npmrc file in your home directory that has an authorisation token. (on SherlockML, you only need to do this once, not once per server, since your home directory is persistent).
Try pushing 0.2.6-alpha2.

Sorry for the delay, I've successfully published to npm without issue. Happy for you to merge when ready.

Great! Will merge this and do a release tomorrow.


duplicate shift

Fixes #issue_number
What was changed?
Here, describe what part of the application you changed (e.g. login page, database, etc.). If possible, mention what specific components were added, removed, or modified.
Why was it changed?
Here, describe the issue that you are fixing with this code, and why your code fixes it.
How was it changed?
Here, get into detail about what files you modified, and talk about the most important lines in regards to fixing the issue.
Screenshots that show the changes (if applicable):

Fixes #21
What was changed?
Modify adding the shift to check if there are any overlapping in the shift timings.
Why was it changed?
The server should not allow the same user to sign up for the same shift more than one time or to sign up for a work-shift that overlaps with another shift that the same user is scheduled to work.
How was it changed?
Changed workshift_add_use_case and workshift_add_multiple_use_case methods along with POST api call.
Screenshots that show the changes (if applicable):

I selected two identical shifts through the client side app and submitted my request to sign up. The server showed the following errors:
<IP_ADDRESS> - - [04/Dec/2023 10:36:59] "POST /shifts HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 1478, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 1458, in wsgi_app
    response = self.handle_exception(e)
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask_cors/extension.py", line 176, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 1455, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 869, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask_cors/extension.py", line 176, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 867, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask/app.py", line 852, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/Users/holdenerea/repos/shelter_volunteers/server/venv/lib/python3.9/site-packages/flask_cors/decorator.py", line 130, in wrapped_function
    resp = make_response(f(*args, **kwargs))
  File "/Users/holdenerea/repos/shelter_volunteers/server/application/rest/work_shift.py", line 145, in work_shifts
    add_responses = workshift_add_multiple_use_case(repo,
  File "/Users/holdenerea/repos/shelter_volunteers/server/use_cases/add_workshifts.py", line 26, in workshift_add_multiple_use_case
    add_response = workshift_add_use_case(repo, work_shift, existing_shifts)
  File "/Users/holdenerea/repos/shelter_volunteers/server/use_cases/add_workshifts.py", line 12, in workshift_add_use_case
    if shift_already_exists(new_shift, existing_shifts):
  File "/Users/holdenerea/repos/shelter_volunteers/server/use_cases/add_workshifts.py", line 42, in shift_already_exists
    existing_start = convert_timestamp_to_datetime(shift.start_time)
AttributeError: 'dict' object has no attribute 'start_time'

Then, I submitted those shifts again and it seemed to work. The server response is 409, and one of the shifts was successfully added.
If there is a conflict in selected shifts, I think we shouldn't add any shifts, but respond to the client with details about the conflict. @AbhilashKotha @loganwyas what are your thoughts on this?

@Sai9797 This issue still needs to be addressed.
Also, as we discussed after your presentation, the response to the request to add shifts should contain a list of shift ids (the ids that were sent with the request) and status (added or not), and an error message (if shift was not added), detailing why the shift was not added. For example, an example response payload could be:
{
   {
      "id": "abc",
      "success": true,
   },
   {
      "id": "xyz",
      "success": false,
      "error": "You are signed up for another shift at this time"
   },
}

I do think that not signing up any shifts if a conflict occurs would be best. Also, I don't know if this is something that has already been addressed or would be better for a separate issue, but do we want to have something (either on the client side or the server side) that prevents conflicting shifts within the same request (where none of them have been added to the server yet)?

We can directly prevent adding it to the selection instead of taking them to the next step and showing an error.

We can directly prevent adding it to the selection instead of taking them to the next step and showing an error.

I agree, we can and should do that. However, server should prevent addition of any conflicting shifts, regardless of how the conflict is created. Whether it's two conflicting shifts in the request (even though we'll prevent it from the client side) or if it's a request to sign up for a shift, that conflicts with an existing shift.

I think we should stick to the server-side validation with PR and create a new issue for client side

I think we should stick to the server-side validation with PR and create a new issue for client side

I agree with you here.


Problems with child elements

Hey,
First of all: thank you for this library, it think the idea is awesome!
However I cannot make child elements work, like in your demo (the "my-complex-component" example).
I have created a reproduction here: https://codesandbox.io/s/react-webcomponentify-child-elements-b0j6t?file=/src/Test.js
Maybe I am just misunderstanding something. Any help would be appreciated!
Cheers

that works fine with preact but not with react. Here in this example app preact is used and it works https://github.com/a7ul/webcomponents-with-react-webcomponentify/blob/master/package.json
but once you try to replace preact with react - it fails


Update README.md

doc update

I just want to say thank you to @corinagum for the lightening fast turn around on this! Literally less than 10 minutes passed between the customer requesting this update and this PR being opened. ❤

Ok, 2 tests are failing due to MockBot changes. I'll get those fixed in my AC PR and then re-run CI here for merge.

/azp run

Passing on azure dev ops, so I am merging this issue


semi-auto can't derive enc/dec for case classes with fields with tagged types

Hey folks,
I have a weird interaction between shapeless tagged types and semi automatic derivation for case classes. I created a minimal example which can be found here: http://scastie.org/29940
The values e1 to e3 are only there to show that the buildling blocks for the automatic derivation seem to be in place and should not affect the derivation.
Maybe I'm just doing something wrong with tagged types or circe?
Greetings :)

I am also facing the same issue, hitting this only when upgraded to 2.12.1, was working fine for scala 2.11.8

@felher This looks similar to https://github.com/circe/circe/issues/220

I have the encoders explicitly defined above the semiauto for the case class using the tagged types and it is not working either. Example below:

type EmailAddress = String @@ EmailAddressTag
type Password = String @@ PasswordTag
final case class CustomerRegistrationEntity(email: EmailAddress, password: Password)

object Encoders {
  implicit val emailEncoder: Encoder[EmailAddress] = Encoder.encodeString.contramap(identity)
  implicit val passwordEncoder: Encoder[Password] = Encoder.encodeString.contramap(identity)

  implicit val encodeCustomerRegistrationEntity: Encoder[CustomerRegistrationEntity] = deriveEncoder(Lazy.mkLazy[DerivedObjectEncoder[CustomerRegistrationEntity]])
}

Still getting an Unable to derive io.circe.generic.encoding.DerivedObjectEncoder[de.zalando.warhol.customerdata.api.model.CustomerRegistrationEntity]

@fthomas Yeah, it does. The fix for this one might actually fix #220 too, since it seems to be a problem with circe, refined and type tags, and this is a problem with just circe and type tags :)

This is stopping me to move to scala 2.12, any ideas for a workaround would be greatly appreciated (manual codec is not a real option for me)

@javierarrieta Does explicitly putting instances into scope for the refined types work? It's annoying but it seems to be fine for me on 2.12:
import eu.timepit.refined.numeric.Positive
import io.circe.Encoder
import io.circe.generic.auto._
import io.circe.refined.refinedEncoder
import shapeless.tag.@@

implicit val positiveIntEncoder: Encoder[Int @@ Positive] = refinedEncoder

case class Foo(i: Int @@ Positive)

Encoder[Foo]

I have created a reproducible example https://github.com/javierarrieta/circe-refined/blob/master/src/main/scala/javierarrieta/circe/refined.scala

@travisbrown it works when you have a single type-tagged argument but fails when there are more.

Is there any hope this can be fixed in near future? Or there are some compiler limitations/problems?

Okay, I've tracked the difference between 2.11 and 2.12 down to a change in the way the RefinedType extractor works. I'll try to get a fix together today.

Wow, so cool, thanks a lot!


reboot issue

Im not sure its something with my sdkconfig or lately something has been changed. Im getting this errors and sometimes esp32 just does not start (WindowOverflow4 and UserExceptionVector). :
load:0x40080000,len:8908
0x40080000: _WindowOverflow4 at D:/msys32/home/imper/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

entry 0x400803b4
0x400803b4: _UserExceptionVector at ??:?

I (350) cpu_start: Pro cpu up.
I (350) cpu_start: Starting app cpu, entry point is 0x40081174
0x40081174: call_start_cpu1 at D:/msys32/home/imper/esp/esp-idf/components/esp32/cpu_start.c:225

This leads to idf_monitor decoding ROM bootloader "entry 0x40080xxx" message as one of the exception vectors, which looks scary to users.

https://github.com/espressif/esp-idf/commit/5551b3f61628fc815293cb6e93d32bf2dfe6a141

Ther may be a problem but it is not related to those 2 logs

Maybe it is or maybe its not, to be honest i dont feel comfort when i see you answering my posts.


does fluentd in_tail plugin support date-formated path?

I use the in_tail plugin to watch the log file, while the log file path is generated in date-formated like /data/logs/nginx/2017-05-10/2017-05-10-15/xxx.log, so I wonder if fluentd support   date-formated path in in_tail plugin like the following conf ?
 <source>
  @type tail
  path /data/logs/nginx/yyyy-mm/yyyy-mm-hh/access.log
  pos_file /tmp/access.log.pos
  tag nginx.access
  format none
  time_format %d/%b/%Y:%H:%M:%S %z
</source>

http://docs.fluentd.org/v0.12/articles/in_tail#path-required


fix for issue#10213

replace Assertions with Assumptions
What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10413 (bf9a48d) into 3.0 (4b55862) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.0   #10413      +/-   ##
============================================
- Coverage     65.66%   65.39%   -0.27%
+ Complexity      319      318       -1
============================================
  Files          1234     1234
  Lines         53916    53881      -35
  Branches       8155     8126      -29
============================================
- Hits          35402    35234     -168
- Misses        14664    14770     +106
- Partials       3850     3877      +27

Impacted Files
Coverage Δ

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
44.28% <0.00%> (-25.72%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-25.00%)
:arrow_down:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
65.78% <0.00%> (-21.06%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...che/dubbo/registry/client/NopServiceDiscovery.java
44.44% <0.00%> (-11.12%)
:arrow_down:

...va/org/apache/dubbo/remoting/TimeoutException.java
22.22% <0.00%> (-11.12%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../common/threadpool/serial/SerializingExecutor.java
70.37% <0.00%> (-7.41%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
80.35% <0.00%> (-6.72%)
:arrow_down:

... and 53 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Empty workshop titles showing up

At 09:28 UK time on 2015-10-16, two workshops were showing up blank in the "upcoming" list on the web site:

I think this was because "Venue" was blank for 2015-11-11-northwestern and 2015-11-11-nyu-med; I've added venue names for both, but:

AMY should complain about missing venue names (or we should use something else as the title of the event when displaying on the website).

Our build script should check for empty venue names and... skip the workshop?  Report an error?  Something.

Hm - the two workshops at the University of Miami (2015-11-19-umiami-R and 2015-11-05-umiami-Python) were also missing venue information.  The former was showing up as one of the blank lines; the latter didn't appear in the upcoming workshop list at all.  I've filled in venue information for both - @maneesha please check that all four of the workshops mentioned in this issue are actually supposed to be published.

The issue has multiple sides to it.

In AMY, we mark events as published when they have URL and starting date.
In site, we trust whatever AMY gives us…

Maybe we should only publish workshops that have a full location as well?

@gvwilson 2015-11-05-umiami-Python is missing URL that's why it's not showing up on the site.

Mark as published with URL, start date, and venue
Better checking in web site as well.
Something big and bright on the Event page and in the dashboard and
on all_events to show published/unpublished.

@maneesha is there a website for 2015-11-05-umiami-Python yet?

@gvwilson: can you elaborate on 2. and 3.?
For the list of unpublished events we have "Unpublished" in the dashboard, and "Status - Unpublished" filter in "All Events".

2015-11-05-umiami-Python does not yet have a github page.  It's in the "unpublished" column in AMY as it should be.
AMY is set up to publish once it has a github page and a date.  However, sometimes we get a github page before the exact location is confirmed.  I'll record the github page in AMY knowing the instructor will update it once the host confirms the location.  I think this is why this is happening.
Maybe we can a third condition (has location) to published?

Maybe we can a third condition (has location) to published?

I think this is a good idea. However, there's slight implementation issue. We have 5 fields for location: venue, address, latitude, longitude, country. Should we require all 5 of them to be filled up (+ start date + URL)?

Sorry I missed this earlier.
Lat/Lon are calculated fields, yes?
So I would say the other three should be filled in and lat/lon should be generated in order for a workshop to be published.

@maneesha no, lat/long aren't calculated, but they are populated from the workshop's website by "import/update from URL" feature. Does that change your opinion?
Missing lat/long means no marker on the workshops map.

Then I think I'd say that Location must have all 5 fields to be complete.
A related question - if the 2 character country code is on the github page can that be used to populate the Country field when doing the import from URL?

@gvwilson do you agree to include Event.address, Event.latitude and Event.longitude to the list of fields that must be complete in order for the event to be considered published?
@maneesha that feature (filling up Country with "Import from URL") is already implemented, but I just found out that there's a number of bugs related to it. Let me add a GH issue for that.
The "Update from URL" part works as long as the remote URL is reachable.

I think it's up to @maneesha and @jduckles - when do they want workshops
to show up on the main website?


[Bug]: collection.delete( ) deletes all the data when called with empty list of ids.

What happened?
when calling collection.delete() with empty list of ids(collection.delete(ids=[])) it deletes all the ids in the database.
code to reproduce:
client = chromadb.Client()

collection = client.get_or_create_collection("test")

collection.add(
    documents=["doc4", "doc5", "doc6", "doc7", "doc8"],
    ids=["id4", "id5", "id6", "id7", "id8"],
)
print(collection.get(include=[]))
collection.delete(ids=[])

print("After Delete")
print(collection.get(include=[]))

Versions
chroma version - 0.3.23
python version - 3.10.10
Relevant log output
No embedding_function provided, using default embedding function: SentenceTransformerEmbeddingFunction
{'ids': ['id4', 'id5', 'id6', 'id7', 'id8'], 'embeddings': None, 'documents': None, 'metadatas': None}
After Delete
{'ids': [], 'embeddings': None, 'documents': None, 'metadatas': None}

@Satyam-79 this is currently the expected behavior. what do you think it should do ergonomically?

@Satyam-79 I could see that... I also think that if you want to blow away a collection, you might as well do client.delete_collection.
@HammadB what do you think about this breaking change?

I like it! We should error - it should not be possible to blow up your data

Ok so to clarify - we want to implement a breaking change where if you pass nothing to .delete() it throws an error.
Additionally if you pass an empty array of ids - it should delete nothing. Also confirm that if you pass an empty object to where or where_document - it should also do nothing.

Should we:

Make one of ids or where clauses required so an empty delete is a python error
For an empty array just do nothing

probably just do nothing now that you say it.

Hi !
It seems a nice move to protect from unexpected data blow up. Additionally is it possible to add a truncate() function that will delete all rows with same usage?
My motivation is that i use delete() with the current expected behavior (after test, account deletion etc.) and i believe full deletion has  a valid use case.

That is fair - we should probably introduce an environment flag in settings and for example - allow this in dev but not prod

id prefer to avoid env specific behaivor... we could always do collection.delete(all=True) ....

That is true - In #589 @levand introduces reset() as env specific - do we want to change that?

@HammadB does https://github.com/chroma-core/chroma/commit/c4484caaa0676a54540f322cf9735e3a8e033cfc close this?

Stumbled here by looking for a way to "delete all documents" without an ID -- what is the new method given that an empty array no longer deletes everything?

If you try to use just .delete() you'll see this error message
 You must provide either ids, where, or where_document to delete. If
                you want to delete all data in a collection you can delete the
                collection itself using the delete_collection method. Or alternatively,
                you can get() all the relevant ids and then delete them.

Can delete the collection and recreating it work for your use case

@jeffchuber thanks. That’s what I did (delete the collection). In my case, with langchain, I created a client and a collection, and passed that to the langchain Chroma object.

This is no longer the behavior. Closing this out.

I also have one doubt when I delete a particular colleciton
the file associated with is not getting deleted from vdb directory how can I handle it
and also the name of the files are very different


Prometheus # TYPE for some metrics wrong

The following metrics show # TYPE gauge instead of # TYPE <metric_name> gauge .
last_update_start
last_update_duration
last_update_done
serial

I will provide a PR for this.

FYI #161 actually fixed #154. #156 did not :)

Might be a version thing. #156 made my Prometheus installation go green again.

Hum, I tried with a current master and cargo build and cargo build --release. Prometheus was 2.10.0 fresh from prometheus.io. Only after I pulled again with #161 merged did prometheus stop erroring out on routinators /metrics.
As I'm new to building rust software might have been some error on my side, I don't know.

Nono, this is my laziness. I was testing with Prometheus 1.5.2 (which seems to be the version that Debian Stretch has). Should have also tested with latest Prometheus.


Non-null type assertions shouldn't affect optional chaining

cc @ahejlsberg

TypeScript Version:  3.7.x-dev.20191101

Search Terms:
Code
const a = document.querySelector('_')?.textContent!;

Expected behavior:
Type of a is string | undefined.
Actual behavior:
Type of a is string.
This means document.querySelector('_').textContent! is valid and these are the equivalent to document.querySelector('_')!.textContent!.
Playground Link: http://www.typescriptlang.org/play/?ts=3.8.0-dev.20191101&ssl=1&ssc=53&pln=2&pc=23#code/MYewdgzgLgBAhjAvDAJiYBXAtgUzFAOgEcMcAnATwGUcAbHYKEMgCgHIB9NgSgH4CoOAB5QAwuEH4AhAG4gA
Related Issues:

Another case.
// b must be `ChildNode | 0` but actualy `ChildNode`
const b = document.querySelector('_')?.firstChild! ?? 0;

Memes aside, if the goal here is simply to remove the null possibility for textContent only, that's probably going to be difficult in general because ! applies to the entire expression and the compiler can't distinguish between T | undefined | undefined and T | undefined.  By the time the compiler sees the !, the two levels of null possibility have already collapsed down to one.

This is the same as if you had written
const _a = document.querySelector('_')?.textContent;
const a = _a!;

IOW ! applies to the entire operand expression, not just the property access

Can't you notice the problem that there is no way to infer the actual type string | null from document.querySelector('_')?.textContent even when using !? ! became useless with many cases using optional chaining.

Optional chaining covers common use cases with terse expressions.  If you really need to go deep detail about each part of your expression; if it's important for your use case to distinguish when querySelector returns undefined vs when textContent returns null; then just break it out into separate statements and test each one.

@falsandtru you'll have to get a time machine and take it up with TC39 in 2017, I guess. ?. won't propagate a null value and TS represents that

@RyanCavanaugh Then I just replace null with undefined. Anyway the essential problem is the same. When developers introduce optional chaining, currently TypeScript forces developers to explicitly write the expected type in some cases like document.querySelector('_')?.textContent as string | undefined.
The question is TypeScript won't resolve the new problem that optional chaining sometimes makes type inference to be impossible to infer the actual type?


Fix: Add coverage for ReflectionContainer, fix bugs

This PR

[x] asserts that ReflectionContainer checks if class exists
[x] removes the previously implemented ImmutableContainerAwareInterface
[x] asserts that ReflectionContainer instantiates class without constructor
[x] returns an instance of the class if it doesn't have a constructor
[x] asserts that ReflectionContainer instantiates class with constructor
[x] fetches dependency from injected container or self

Was hoping to release on Friday but got a little delayed, will take a look at these tonight and get merged before I tag the release. Thanks @localheinz

@philipobenito
No worries, I mean: CLAIRE DANES SMILED!


Johnpecker 6 day's ago

Johnpecker 6 day's ago
Coding
Originally posted by @Abhi9737 in https://github.com/github/docs/issues/14207#issuecomment-1019535828

@Abhi9737  in #14207
(Comment

Computer coding is so much fun!


⚠ SceneTime has degraded performance

In 44be49a, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 5437 ms

Resolved: SceneTime performance has improved in 9cdd81d after 6 minutes.


Fix nonunified

The previous name(Visual Studio Team Services, Microsoft Team Foundation Server) and the new name (Azure DevOps, Azure DevOps Server) are mixed. So, I unified it into a new name.
Typo: Azure virtual machine -> Azure Virtual Machine

@changeworld : Thanks for your contribution! The author, @tomarcher, has been notified to review your proposed change.

Thank you for your contribution.
Metadata - The older terms are used in the metadata description to aid in discoverability (for people searching for the older terms).
Azure virtual machine casing - The casing is correct for this context as "an Azure virtual machine" refers to an instance of a virtual machine; not a brand.
#please-close


dnn-image-cropper should expose the filename

Currently it only exposes the image data but in some situations it may be useful to know the filename that was dropped into its' inner dnn-dropzone as an event

Fixed in #1041


Fix crash on rendered frame copy used by SceneView recorder

In current implementation SurfaceCopier makes copy using SceneLifecycleObserver.onFrame(), which is wrong and causing instant crash.
Considering Filament documentation copyFrame() should be called after a frame is rendered using render but before endFrame is called.

Hi!
Thank you for the pull request! We'll take this into consideration after the big changes for the version 1.0.0 are merged by Thomas.


A variant of unsorted_bin_attack that works with small allocations

I needed something similar to unsorted_bin_attack that would work with a 64 byte allocation, so I developed this. I am not sure if this is already a known technique, so I am hoping that you can tell me if it is.

It is a known technique. To my best knowledge, it was first made public on hitcon ctf 2019.
We don't have it here. And I'm glad it is finally here.


Redo price vector estimation

Changes estimate_price to return a BigRational.
Moves estimate_prices to PriceEstimating.

Left estimate_price_as_f64 since it has a bit of boilerplate that needs to be repeated in several places.


imod.ipdf.read fails on zero row associated files

In GitLab by @Huite on Mar 8, 2022, 16:23
A valid IPF may contain nrow=0, but this currently crashes the read function.

In GitLab by @Huite on Mar 16, 2022, 17:25
mentioned in commit ab568862930b4fbf8ba51e2441b675ee0e225251


Fix a small typo in modernized-folderbrowserdialog.md

Fix a small typo.

closing and reopening for a fresh build.

closing and reopening for a fresh build.


Click on a long line of nulls

Open this file, then put caret at the end of text
XXX.txt

What was the problem, I can't repeat?

Fixed.


Input with ng-model as default transclude keeps validators alive

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
Report a bug
What is the current behavior?
When using multi slot transclusion, if an input element with ng-model is being used as the default\fallback, when replace with trascluded content, validators from the default input are still present and are preventing the form from being valid.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
I think it is explained well above.
What is the expected behavior?
The validators should be destroyed in the $destroy function of the NgModelController
What is the motivation / use case for changing the behavior?
Explained aboe
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
angular 1.5.6
chrome 51.0.2704.84
Mac osx El Capitan
I just started using the multi slot transclusion and since it is new, i don't believe this ever worked before.
Other information (e.g. stacktraces, related issues, suggestions how to fix)
for now i used ng-if on the default input as a workaround and checked for transcluded slot existance.

Can you please post a demo in a plnkr or similar?

Can you please send me an angular-ready environment in plnkr or similar?
I will complete the rest.

http://plnkr.co/edit/pxbd3dTVtBpPnnqF6wEF

There you go:
http://plnkr.co/edit/RlFUZDrEMwde2Zv4PFrw?p=preview
Thanks!


Problems with writing to file

Hi
I have task which saves the data to file, it's a logger:
https://github.com/stefunkk/OpenStill/blob/master/src/StillDataTask.cpp
Which saves the data using SPIFFS:
https://github.com/stefunkk/OpenStill/blob/master/src/FileService.cpp
File file = _fs.open(path, "a");
file.print(content);
file.close();
But I'm getting strange behavior inside a file, instead of having nice structure line by line sometimes it adds strange characters at the end, and everything is mixed up, like here:
22.500000;22.500000;22.750000;22.687500;яяя22.500000;22.500000;22.750000;22.687500;0
22.500000;22.500000;22.750000;22.687500;яяя22.500000;22.500000;22.750000;22.687500;0
22.500000;22.500000;22.750000;22.625000;0
22.500000;23.000000;22.750000;22.625000;яяя22.500000;22.500000;22.750000;22.625000;яяя
Is it possible that this behavior is caused by asynchronous processing?

Please could you raise issues with isolated examples, when you point us to a large project we cannot help you to debug that. We have already provided you a lot of assistance in a prior incident in LiquidCrystalIO. We are a small company and cannot keep providing you this level of coding assistance free of charge.
Whenever writing anything asynchronous, you need to consider how the data is shared, and how you will avoid things being overwritten, deleted, etc. This is part of writing any large solution, especially in C++.
Is this even a valid format string with an un-escaped % in it? I would look there first.
%f;%f;%f;%f;%i%\n

Dave I really appreciate your help and understand your point of view. If you send me paypal link I can buy you a beer for wasting time on previous issue ... i feel really bad about it.
I will try to keep examples small for future, hope that helps.
https://pastebin.com/in9vWs92
My results:
(...begining was pretty ok, but after 20 sec...)
0;0;0;0;���0;0;0;0;���0;0;0;0;0
0;0;0;0;0
0;0;0;0;���0;0;0;0;���0;0;0;0;0

If i flash same code with arduino instead of platformio problem disappear

Code without TaskManagerIO library still broken on PlatformIO, so for sure it's not a TaskMangagerIO fault. My bad again. You can close the bug.
https://pastebin.com/U0SGbEiA

Thanks for letting me know. Don't worry about the last one BTW.
Line 63 Serial.println(fileRead.readString());
Looks deeply suspicious somehow, who owns that readString memory, it's probably passed to you by reference, and that ref may be gone by the time you use it, maybe try reading into a char array (such as char[200]) and see if that fixes it


Notifications for the web version

What  you think of implementing the html5 notifications to the web version?
Also create a store module named app for example is needed for store some settings for the web app scope, like apiKey and notification settings (on /off  etc) and other settings that come in the future because that goes beyond the responsability of player store module
I look forward to your reply, thanks

Notifications can be implemented by adapting the app version because both use html5,
we need only ask to user if we can show notifications (on electron it is enabled by default)


Check for existence of clsact qdisc when call to create fails

The code currently ignores the error when creating the clsact qdisc assuming that if there's an error, it must already exist.
https://github.com/bpfd-dev/bpfd/blob/main/bpfd/src/multiprog/tc.rs#L122
However, if another user has added the ingress qdisc, the call would also fail, but the subsequent attempt to add our dispatcher program to the clsact qdisc would fail.
So, if we get an error on the create call, we need to handle it in some way.  Options include:

Use the existing ingress qdisc instead and only support ingress attachments on the given interface
Return an error
Delete the ingress qdisc and add clsact

I'm currently leaning toward 1. because it allows for better cooperation with other apps that are already running.

I've been looking into the issue. If another user has added the ingress qdisc, I guess we can assume that this user will manage the qdisc. I'm wondering if, following option 1, our program might be in an unknown state after the qdisc is deleted. This could mean that our BPF programs attached to the ingress qdisc would be removed unexpectedly. Then, I believe we can't rely on that. Does it make sense?

@navarrothiago thanks for looking at this.  It is true that if the other user/program deletes the qdisc, any programs we've attached will get deleted.  That's also true if we are using clsact and another user deletes it without us knowing.  In any case, it's probably safer for us to go with option 2 and return an error if the ingress qdisc already exists because that means that another user is already active on the system.  We may also want to check for the clsact qdisc before blindly adding it.  I'm not sure whether this is possible, but another thought is that it would be good if we could get notified if a clsact qdisc is deleted.  That would at least allow us to clean up our state and report an error.
Also, this illustrates some of the challenges we can have when multiple applications are managing their eBPF programs independently.  I.e., it's easy for them to step on each other.

@anfredette, could you assign the issue to me?


feat: introduce splunk semantic-release-action

patch set-output command
replace cycjimmy/semantic-release-action with splunk/semantic-release-action

Fix pre-commit

:tada: This PR is included in version 3.7.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Leaderboard - Hit the API

In this part of my Leaderboard app, I implemented the sending and receiving data from/to Leaderboard API feature.
Project Requirements

Read the Leaderboard API documentation and learn how to use it.
Create a new game using the API (Add the name of your choice).
Saved the ID returned by API after creating the game.
Implement Refresh button functionality to get all scores from API, and parse received JSON data.
Implement Submit button functionality to save a created score in the API.
Use arrow functions instead of the function keyword.
Use async, await features to consume the API.

General Requirements

Use Gitflow
Document the work in a professional way
Follow best JavaScript practices
Check linter errors
Open a Pull Request and Ask for review

@AshakaE
Thank you so much


Run more then one user in the same computer

Hi,
i want to know what is the best way to run more then one bot in same computer.
its was worked before the update but now i think i getting soft ban becouse i logged from the same ip.
please write me what is the right way to run more then one bot from same computer..
thank you

I'm running multiple users by creating multiple clones of this repo, each running in their own virtualenv

I just create one more config-User2.json file and use the same virtualenv in another console.
Once in virtualenv, I use command ./run.sh ./configs/config-User2.json

i need to open new folder og PokemonGo-Bot for each user ?
i using virtualenv too but i dont understand how it work perfectly....

You can just run in different terminals:
python pokecli.py -u user1 -p pass1
python pokecli.py -u user2 -p pass2

its working but when i run 7 users all are get softban i think or the bot stoping to work.. no catching pokes and move from pokestop to the other and i not get the loot.. it write that i need rest.
there way to use proxy server to login ?

#3022 like in this case.

ya getting same issue here
on side note method i use for running multiple sessions is through screen.
allows scripts to run even after the terminal or ssh connection is closed.
screen -ls to display al open screens
screen -S [SCREEN_RAME_HERE] to create a screen
screen -r [SCREEN_RAME_HERE] to reattach to a running screen.
exit while in screen to close the screen session


feat: Introduce structured log metadata to Deployment logging (Non-Errors)

What this PR does / Why we need it:
Introduced structured log metadata (env, coordinate) to non-error deployment logging.
Special notes for your reviewer:
Please review #1049 first!
Does this PR introduce a user-facing change?

lgtm :) @UnseenWizzard
Two notes:

I see a lot of direct log.XXX calls in packages that are potential candidates for living in a library scope(client,....). I think we need to get rid of this way of calling the logger there and make the logger injectable.
Nit: some of the methods in the client interfaces have a context as the first argument, others do not. Maybe it is just worth adding context argument to the others as well (even if it is not used right now....)

Both are things to look at later tho :)

Two notes:

I see a lot of direct log.XXX calls in packages that are potential candidates for living in a library scope(client,....). I think we need to get rid of this way of calling the logger there and make the logger injectable.

Nit: some of the methods in the client interfaces have a context as the first argument, others do not. Maybe it is just worth adding context argument to the others as well (even if it is not used right now....)

Agree @warber, both make sense as a library improvement followup.
Do you feel actually passing the logger would be reasonable? Else we pull the logger through all method interfaces...
It feels a bit off for the context as it's shared and not call-path/goroutine specific..

Do you feel actually passing the logger would be reasonable? Else we pull the logger through all method interfaces...

I think it should be injectable via the constructor of the clients first, e.g., automation.NewClient(url,c, WithLogger(...)) where possible and then either be used inside the struct directly or handed over to the functions that need to log something as an arg.
Also, if I think about it from a library perspective, it would be easier for the user if (s)he would not need to think about adding the right fields to the context but the library code sets up the logger with additional information inferred from the other arguments given to the called functionality. Things like that actually reinforce our first idea that maybe the library code shouldn't do any logging at all :man_shrugging:
So i maybe we would need to reiterate a bit on the desired design and behavior when we start extracting out the library parts....


Fixes/gh issue 518 Maintenance page

Copy and tests updated for service down page.

route: /maintenance
Not too sure about the naming - but does it matter? Will gladly update if required.
@mattmb @dan-palmer @Demwunz

@cleargif that looks good to me :-)

:-1:

smiley faces and thumbs down. Hmmm. @TrentDSD thoughts?

At most this feature is a static page, i.e. 503.html in /public. There is no need for a controller or markdown. A controller has no advantages and introduces code that @dan-palmer or myself to maintain.
Honestly this has no business being in the app itself whatsoever. It should be something in an S3 bucket shared amongst all services.

Closing. Feature will be added in a new PR.


Hurley.default not being respected

The README says that one can:
# Change it globally.
Hurley.default = Hurley::Query::Flat

Although this is not implemented (or has been removed). In order to globally change it, I had to monkey patch:
module Hurley
  class Query
    def self.default
      @default ||= Flat
    end
  end
end

Fixed in f47cc9fd008f98f8597bb3e16acfa15c86b115d7. Though if I was smart I would've done this before shipping v0.2 :)


chore: change firefox version to 36

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch, not the main branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

To be on the safe side, first change the firefox version to 36.


Druid watermark initial contribution

This extension is a self-contained new service which tracks the "watermark" progression of data through a Druid deployment. The original author was @clintropolis .

A "watermark" is some indicator for how far along or complete data is in event time. This particular implementation comes with a few interesting ways to be able to monitor when data processing has progressed along certain stages.

[x] Watermarks self-contained extension
[ ] Determine if watermarks should be part of core Druid with extension points
[x] Docker file for web frontend to api
[x]  Basic README files
[ ] Website helper files and examples
[ ] Fixup tests. They are failing to register the api paths correctly.

I'll add website friendly files if the community thinks this one would be handy to adopt. I also would like to know if this is handy enough to be in core druid, or if it should just stay as an extension.
stable
The stable_* series of watermarks indicate when data is believed to be contiguous for a set of time. An example of which is when real-time tasks have handed off all segments to historical nodes for a particular series of time.
batch
The batch_* series of watermarks indicate when data has been filled by a batch job. The detector for this watermark series is kind of hacky since it just looks for partition specs which are commonly created from batch jobs.
low
The *_low series of watermarks indicates the lowest contiguous timestamp. It will not skip over gaps in data unless manually overridden.
high
the *_high series of watermarks indicates the furthest along in time timestamp. So looking in history behind a *_low should yield contiguous data until mintime, and any split between *_low and *_high is a good indicator for missing data.
We've been using this extension in production for quite a while now and it has worked pretty well.

bump to defeat stale bot, I've been meaning to have a look here but have been too busy

It's interesting, I wonder what do we need to merge this PR, just fix the conflicts or there's more?

It's interesting, I wonder what do we need to merge this PR, just fix the conflicts or there's more?


organize excel output

Here's a screenshot of the nicely-formatted data

Okay.  I actually combined the Shapefile and Excel data now instead of just leaving them separate!  Here it is:

Confirmed working on my machine and Dan's machine


Lost semi-colon in Vue.js source code

Hi 佑,
Thanks for your work, Vue is fantastic! But....
why not add a ";" to end each line of source code? when the code is compressed it appears to be a problem.

Just look at Code style and No semicolons unless necessary.
I haven't issues with minimized Vue sources. How can we reproduce it?

I don't write semicolons because they are not necessary.
https://github.com/yyx990803/semi#why

Thanks for the sharing.
I'm using total.js with vue, and there is a built-in JS compressor in total.js, so there'll be a problem after webpack all code (including Vue), all the JS code in one line without semi-colon, and the browser will be blocked. It seems the compressor didn't insert semicolon at all.
After webpack vue code, I tried to use YUI compressor(and then tried uglify) to compress the generated code, but it still didn't work util I modified the source code of total.js to avoid using the built-in compressor.
For a better solution, I used the semi to add semicolon to vue, and everything came back to normal.
Cheers.

It seems the compressor didn't insert semicolon at all.

I would consider that broken.  It does not follow the javascript standard.
I would file an issue in the repo.
On Sat, Aug 8, 2015 at 7:58 PM, Charlie Li<EMAIL_ADDRESS>wrote:

Thanks for the sharing.
I'm using total.js with vue, and there is a built-in JS compressor in
total.js, so there'll be a problem after webpack all code (including Vue),
all the JS code in one line without semi-colon, and the browser will be
blocked. It seems the compressor didn't insert semicolon at all.
After webpack vue code, I tried to use YUI compressor(and then tried
uglify) to compress the generated code, but it still didn't work util I
modified the source code of total.js to avoid using the built-in compressor.
For a better solution, I used the semi to add semicolon to vue, and
everything came back to normal.
Cheers.
—
Reply to this email directly or view it on GitHub
https://github.com/yyx990803/vue/issues/1132#issuecomment-129097549.

I believe that semicolons makes the code more readable, especially for developers that are accustomed to other programming languages such php, java, c/c++;
Furtherless even when semicolons are not needed the engine use a feature called "semicolon insertion". So the engine recognizes that a semicolon is needed and automatically adds it. They are still needed in the final code, they are just automatically inserted when missing;
So why not just add them in the 1st place? :-) ;
From emca specs;
When, as a Script or Module is parsed from left to right, a token (called the offending token) is encountered  that is not allowed by any production of the grammar, then a semicolon is automatically inserted before the  offending token if one or more of the following conditions is true:;
it sounds to me  like the missing semicolon is corrected and a normal script should have it, not that the semicolon is not needed;
;
I am sure this is due to my personal developer experience, but if i don't see a ";", even if i use daily project with no-semicolon style guideline,  i still tend to look to the next line to see what's going on. :-) ;
....of course since the engine allows it anybody can use whichever style they prefer;
kind regards;
oh i forgot this... ;

http://slides.com/evanyou/semicolons#/

@yyx990803
Thanks i already read it, and of course many similar posts when people also like to insult each other :-)
i was only offering my POV on th matter and examining word by word emca specs.
The reason i tend to use semicolons is about (!about!) the same that i have for declaring variables at the beginning of a function. The engine will automatically hoist any declaration, but the code is more clear when putting them just there where they will "end up" before being interpreted :-).

if a semicolon is needed it will be automatically inserted.
if a var is declared its declaration will be automatically hoisted.

the final interpreted code will have missing ; in place and hoisted declarations
it's called ASI not ASR ("R"emoval of unnecessary ;)...so the valid final statement after ASI will have its ";", not the other way around.
For some reason some js developers will tell you (1) to put your var declarations at top to reflect the final code interpretation, but also tell you (!2) to avoid semicolons. So in one case they tell you to NOT rely of automation while in the other case they tell you to DO so.
since js allows both forms: having something like PSR for Javascript would be good, at least a for the eyes/brain not having to adjust coding style when switching form 1 project to another.
outside the scope of the discussion (and the fun of it :-) )
i believe that ASI leads to more uncertainty than not having it: i've always hated the return statement behaviour of js.....the developer should decide when the statement ends...but hey...that's the way it is...
...and....one final note....
;
just kidding...;
kind regards and thank you so much for VUE.JS

The whole point is that readability is subjective and neither approach is technically superior or "more correct". There's simply no point in complaining about whether other people's code uses it or not.

I agree with you and i am not complaining! Maybe I wasn't clear (all the ; were just for fun). I was just expressing my point of view, the reason why i prefer not omitting semicolons and move all declarations on top and why a common style guideline among developers could be useful. PHP standard group has been very useful to te community. You can write php code in many ways but opening 10 different frameworks code and seeing the same style it's very helpful and saves you more than some time.

@pine3ree As for my personal experience, I liked using semi because I come from a C/C++ background but after trying the no semi style I found it faster to code with and more readable.

@posva same here, but i still prefer using it. As @yyx990803 says  it's a matter of personal preference.
What i wanted to say it's that emca specs states that certain js statements must end with a semicolon. If you do not add it, the interpreter will add it for you before evaluation.
this:
var a = 1 + 2
++a

are not valid js statements, but you are allowed to write code in that way.
js ASI will transform them into a valid statements
var a = 1 + 2;
++a;

the specs do not says that the ";" are removed from previous expressions because not needed, but that they are automatically added when missing.
quoting emca 11.9:
Certain ECMAScript statements MUST be terminated with semicolons (...). Such semicolons MAY always appear explicitly in the source text. For convenience, however, such semicolons MAY be omitted from the source text in certain situations. These situations are described by saying that semicolons are automatically inserted into the source code token stream in those situations.
so we MAY do things the way we are more comfortable :-)
quoting again:
In the circumstance that an assignment statement must begin with a left parenthesis, it is a good idea for the programmer to provide an explicit semicolon at the end of the preceding statement rather than to rely on automatic semicolon insertion.
just quoting the specs: ...at the end of the preciding statement...
again there is no must and many projects adds it at the beginning of next statement. It is fine!!! I've always use this technique when combining many scripts into one.
it's fine for me reading code relying on ASI, many big projects are using it, but It feels more natural to me to add it in my own code just because the other programming language i use do not provide ASI.
If i start omitting ; as a rule in js i am sure that sooner or later i will forget some in PHP/C++ or even in a multiple SQL query.
kind regards

@pine3ree I guess we should avoid using ++a (or even a++) because Python doesn't like them. (Well they're just philosophies and conventions enforced by language designers.)

@fnlctrl
nope, again misunderstood. I am saying that you should do whatever you prefer. I just stated a few simple things.

my personal preference (and some of the reasons behind it)
quoting emca specs

Other than that I've never said to anyone what they should do....if you find me the line i will correct it because it's not what i intended.
They only thing i was complaining about (this is a general topic, it has nothing to do with this project's community) is the fact that some js developers tells you to put declaration on top because the engine put them there and so it's more clear to have them there but at the same time they tell you to avoid ; even if the engine adds them. I believe that you should either advice to use both, forbid both or allow people to choose for themselves. But not advice to use one and not to use the other, because the reason behind both is the same: writing code closer to how is interpreted.
Nobody should not feel sorry or more right than others for not using semicolons the same way nobody should feel sorry or more right for using them.
Pls let stop this! I don't want this silly thing to turn into a religious struggle or spaghetti vs fettuccine.
I just explained why i like fettuccine (well i like spaghetti as well).

I'm not interested in this conversation and I don't think it belongs here. Feel free to discuss semicolons elsewhere.


Missing 'typer' and 'libcst' dependencies.

Describe the Bug
I noticed that when running the 'strawberry codegen' command, the required dependencies.
This caused the command to fail with a 'ModuleNotFoundError.' As a workaround, I installed these dependencies manually to resolve the issue.
System Information

Operating system: Ubuntu 23.04
Python version: 3.11.4
Strawberry version (if applicable): 0.205.0

Steps to Reproduce

Install Strawberry.

pipenv install strawberry-graphql==0.205.0

Attempt to run the 'strawberry codegen' command.

strawberry codegen --schema schema --output-dir . -p python query.graphql

Observe the 'ModuleNotFoundError' related to missing dependencies.

Expected Behavior
The 'strawberry codegen' command should run successfully without missing dependencies.

@DaudLN you can install all the cli dependencies by installing strawberry-graphql[cli] 😊
we've done it this way so you don't install dependencies that you might not need

Thank you Patrick
On Fri, 25 Aug 2023 at 10:58, Patrick Arminio @.***>
wrote:

@DaudLN https://github.com/DaudLN you can install all the cli
dependencies by installing strawberry-graphql[cli] 😊
we've done it this way so you don't install dependencies that you might
not need
—
Reply to this email directly, view it on GitHub
https://github.com/strawberry-graphql/strawberry/issues/3056#issuecomment-1692934996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT6MNQR2RBRQVD5227PUHQDXXBLJ7ANCNFSM6AAAAAA36D66SI
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'll close then! 😊


Be looser on singletumblr igset

This lets jobs grab video iframes and offsite links that aren't Tumblr blogs (except custom domains).

Ran validate_db.py locally for verification as the test suite isn't operational at the moment.


First Name and Last Name TextField lose focus after each type

I have to update the name by a character type follow with a mouse click for every character. Demonstration below:
Operating system: Windows 10 Pro 64-bit (10.0, Build 19041)
https://user-images.githubusercontent.com/43837352/109900351-cfb5c900-7cc9-11eb-96ea-ab16b715726c.mp4

This issue also occurs in the Windows build.

This is fixed in the latest version, 1.1.2, thanks for the report! Please re-open if you can still reproduce.


SPO Cmdlets in SharePoint-Server repo

The documentation for the cmdlets ConvertTo-SPOMigrationEncryptedPackage.md and ConvertTo-SPOMigrationTargetedPackage.md should be moved out of the sharepoint-server repo as they are only deployed with the SharePoint Online Management Shell.

Fixed now. Thx for reporting.


Helm chart deployment can cause

What you expected to happen?
What happened?

How to reproduce it?

Anything else we need to know?

Versions:

$ weave version
$ docker version
$ uname -a
$ kubectl version

Logs:
$ docker logs weave

or, if using Kubernetes:
$ kubectl logs -n kube-system <weave-net-pod> weave

Network:

$ ip route
$ ip -4 -o addr
$ sudo iptables-save

Looks like you replaced this with #3798, choosing not to supply any of the requested information.


Review Oss-health-metrics and related for criteria and status info

We should review the OSS-health-metrics work, especially the Growth-Maturity-Decline metrics and related materials:

https://github.com/chaoss/wg-gmd
https://lists.linuxfoundation.org/pipermail/oss-health-metrics/

Nadia Eghbal also has an interesting post: Methodologies for measuring project health.
We could add some measurement values to the criteria, and/or try to calculate & display some metrics and show them to people who view the project page as a way to help them ascertain project help.
@GeorgLink is involved in this and Oss-health-metrics, so he can answer questions if there's a confusion...!

Yes, happy to help and bridge between the projects.

OSS-health-metrics is the mailing list of the CHAOSS project. The Growth-Maturity-Decline (GMD) metrics are maintained and implemented by its own workgroup.  Everyone is invited to join these meetings and ask questions, get feedback, or simply listen in.
The GMD workgroup meets every other week. The next call will be on Wednesday, August 15th at 18:00 CEST (9am PDT).
Information about upcoming calls and how to connect are available at https://chaoss.community/participate/


x/telemetry/godev/cmd/telemetrygodev: test fails when run in a standalone module

Go version
6e7aee5f6bdcf2823be358d6e4452b5e2fafb8ed
Output of go env in your module/workspace:
N/A

What did you do?
https://build.golang.org/log/a1fcb0cfb4ce3595205204cea723c2d7a5c447e5
What did you see happen?
2024/01/22 21:17:02 open ../../../config/config.json: no such file or directory
FAIL	golang.org/x/telemetry/godev/cmd/telemetrygodev	0.278s

Note that the android builder runs tests by copying the entire module containing the package to the builder, similar to running go test on the package from outside of its module.
The replace directive added in https://go.dev/cl/499918 causes the golang.org/x/telemetry/godev module to depend on an invalid version of golang.org/x/telemetry, but if you also go get a valid version of that module, the failure is also reproducible on any platform by running the test from the module cache:

$ go version
go version devel go1.23-b4e7d630 Wed Jan 24 07:25:25 2024 +0000 linux/amd64

$ go mod init example
go: creating new go.mod: module example

$ go get -t golang.org/x/telemetry/godev/cmd/telemetrygodev@master golang.org/x/telemetry@master
go: downloading golang.org/x/telemetry v0.0.0-20240123174154-00d1ee814984
go: downloading golang.org/x/telemetry/godev v0.0.0-20240123174154-00d1ee814984
go: downloading github.com/yuin/goldmark v1.5.4
go: downloading github.com/yuin/goldmark-meta v1.1.0
go: downloading golang.org/x/mod v0.14.0
go: downloading golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63
go: downloading cloud.google.com/go/storage v1.30.1
go: downloading google.golang.org/api v0.149.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading cloud.google.com/go v0.110.8
go: downloading google.golang.org/grpc v1.59.0
go: downloading cloud.google.com/go/compute/metadata v0.2.3
go: downloading github.com/google/uuid v1.4.0
go: downloading cloud.google.com/go/iam v1.1.3
go: downloading golang.org/x/oauth2 v0.13.0
go: downloading github.com/googleapis/gax-go/v2 v2.12.0
go: downloading google.golang.org/genproto v0.0.0-20231016165738-49dd2c1f3d0b
go: downloading google.golang.org/protobuf v1.31.0
go: downloading cloud.google.com/go/compute v1.23.1
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20231016165738-49dd2c1f3d0b
go: downloading go.opencensus.io v0.24.0
go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20231016165738-49dd2c1f3d0b
go: downloading google.golang.org/appengine v1.6.7
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading golang.org/x/net v0.17.0
go: downloading github.com/golang/protobuf v1.5.3
go: downloading golang.org/x/sys v0.16.0
go: downloading golang.org/x/text v0.13.0
go: downloading github.com/googleapis/enterprise-certificate-proxy v0.3.2
go: downloading github.com/google/s2a-go v0.1.7
go: downloading golang.org/x/sync v0.4.0
go: downloading golang.org/x/crypto v0.14.0
go: added cloud.google.com/go v0.110.8
go: added cloud.google.com/go/compute v1.23.1
go: added cloud.google.com/go/compute/metadata v0.2.3
go: added cloud.google.com/go/iam v1.1.3
go: added cloud.google.com/go/storage v1.30.1
go: added github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: added github.com/golang/protobuf v1.5.3
go: added github.com/google/s2a-go v0.1.7
go: added github.com/google/uuid v1.4.0
go: added github.com/googleapis/enterprise-certificate-proxy v0.3.2
go: added github.com/googleapis/gax-go/v2 v2.12.0
go: added github.com/yuin/goldmark v1.5.4
go: added github.com/yuin/goldmark-meta v1.1.0
go: added go.opencensus.io v0.24.0
go: added golang.org/x/crypto v0.14.0
go: added golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63
go: added golang.org/x/mod v0.14.0
go: added golang.org/x/net v0.17.0
go: added golang.org/x/oauth2 v0.13.0
go: added golang.org/x/sync v0.4.0
go: added golang.org/x/sys v0.16.0
go: added golang.org/x/telemetry v0.0.0-20240123174154-00d1ee814984
go: added golang.org/x/telemetry/godev v0.0.0-20240123174154-00d1ee814984
go: added golang.org/x/text v0.13.0
go: added golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: added google.golang.org/api v0.149.0
go: added google.golang.org/appengine v1.6.7
go: added google.golang.org/genproto v0.0.0-20231016165738-49dd2c1f3d0b
go: added google.golang.org/genproto/googleapis/api v0.0.0-20231016165738-49dd2c1f3d0b
go: added google.golang.org/genproto/googleapis/rpc v0.0.0-20231016165738-49dd2c1f3d0b
go: added google.golang.org/grpc v1.59.0
go: added google.golang.org/protobuf v1.31.0
go: added gopkg.in/yaml.v2 v2.4.0

$ go test golang.org/x/telemetry/godev/cmd/telemetrygodev
2024/01/24 09:46:05 open ../../../config/config.json: no such file or directory
FAIL    golang.org/x/telemetry/godev/cmd/telemetrygodev 0.090s
FAIL

Per https://github.com/golang/go/issues/34352#issuecomment-1650335903 the test failure should also be reproducible on the LUCI builders, but for some reason it is not — no failures are showing up on https://ci.chromium.org/p/golang/g/x-telemetry-gotip/console. I will follow up on that separately.
What did you expect to see?
All tests passing, including when run from within the module cache.

Reopened #34352 for the missing LUCI builder coverage.

The test failure was introduced in https://go.dev/cl/556860 (attn @findleyr @hyangah).

The module is not intended to run as a standalone module. It is tightly coupled with the x/telemetry module and the intention is to test the three modules in the repo are consistent.
There is also no reason to run any tests in this module on android. I think the right fix is to disable the tests in unintended platform completely.

If it is tightly coupled with x/telemetry, would it make sense to combine the two modules back into one so that it doesn't start failing once #34352 is fixed?
(What is the value of keeping the nested godev module separate?)

If it is tightly coupled with x/telemetry, would it make sense to combine the two modules back into one so that it doesn't start failing once https://github.com/golang/go/issues/34352 is fixed?

The go toolchains will depend on x/telemetry (and uploader pulls into x/telemetry/config) and we don't want all the dependencies of x/telemetry/godev pulled into the go command.
x/telemetry/config and x/telemetry/godev are built and deployed together.

Module graph pruning should prevent the dependencies of x/telemetry/godev from being pulled up to the cmd module.
We already rely on that, for example, to prune out the dependency on rsc.io/pdf from the golang.org/x/arch module.

Is there a reason that we need to run telemetry.go.dev on android?
This is a result of a long discussion to keep the x/telemetry module minimal and small. (no typescript or media files in the module people need to import).

FWIW, I don't think it matters in this test (see the trivial fix), but agree that we don't need to test the godev sub module on anything but linux. However, this is probably unnecessarily complicated to configure on the builders: we definitely want to run x/telemetry module tests on all platforms.
We can skip non-target platforms in our tests of the godev module as necessary. But it's not necessary in this case.

I am more concerned about the impact on fixing #34352 than about running on Android in particular.
An exemption to allow x/telemetry tests to fail when run from the module cache would add yet another special case to consider in maintaining the builders going forward, and we have already been having trouble keeping up with builder maintenance for quite some time.
For comparison, consider golang.org/x/tools/internal/testenv#NeedsLocalXTools, which skips cross-module tests in x/tools where appropriate.

As our project portfolio grows, I think we need to reevaluate the requirements of #34352. Not all Go modules our team is working on are intended to be hosting packages and tools that can be gettable or installed on by external users.
For this specific issue, I think we can just fix the tests.


CDF table of Frodo 1344 different from specification

The CDF table in frodo1344.c has 7 entries amongst which one is 32765.
I noted that in the latest specification, table A.4 has only six elements. 32765 is missing.
Is that a typo in the specification or the implementation? (Or have I misunderstood something?)
Also in noise.c where the CDF table is used:
for (j = 0; j < (unsigned int)(CDF_TABLE_LEN - 1); j++) {
the for loop does not use the last element of the CDF table. Is that intentional?

It's a typo in Table A.4 in the specification. For FrodoKEM-1344, entry Tx(5) should be 32765 and entry Tx(6) should be 32767. This will be corrected.
And indeed, the last element in the CDF table is never accessed in the implementation.


Support for Driver classes present in Thread Context Class Loader

Environment

Getting "Failed to load class of driverClassName {}" when hikari jar is present in parent classloader(tomcat shared lib) and the driver class is present in Thread context class loader(individual webapps) when the pool is initialized.

Looks like the problem is in setDriverClassName of HikariConfig, it is expecting the driver class to be present in the same classloader from which hikari classes are loaded.

HikariCP version: x.x.x

@udayshnk Looks like it should try the thread context classloader in the catch block.  Can to give me a pull request?

@brettwooldridge unfortunately my machine doesn't have java8 installed to work on dev branch. We were using 2.4.x release in our project.

@udayshnk Sorry about that, we usually build the Java 7 artifact with Java 8 (using a 1.7 compilation target).  I just pushed a change to the 2.4.x branch to build on Java 7.

Fixed.

@brettwooldridge sorry i am bit new to github environment. I cannot find the commit in 2.4.x branch, are there any review comments or is the commit fine for you.
Also if the commit is merged into 2.4.x branch, i think it can be cherry picked to dev branch as well and when could i expect the next 2.4.x public release.

@udayshnk This is the commit (also linked above).  I'll try to cut a release in the next few days.

Hi @brettwooldridge could you please cut the 2.4.12 release

@udayshnk Ok.  It is 5:00am now here in Tokyo, so I'm going to bed, but I will do so sometime tomorrow.

Hi @brettwooldridge request you to please cut the 2.4.12 release. Sorry for the inconvenience caused we are in need of the fix in our setup

Oh wait, I don't know why this was closed.  Your code was never merged.  I have a number of comments on your pull request that were never addressed.  If you correct those issue, then squash the commits into a single commit, I can merge the change and release a 2.4.12 build.

Hi @brettwooldridge, i don't see any review comments can you please help me. Here is the screenshot of what i see in the pull request

Did you follow the linked text in my comment?  Comments are on the pull request.

For what it's worth, I also see no comments on the pull request linked above (#881). It's the only open pull request with no comments, according to the pull request tab.

@brettwooldridge i did follow the link, i don't see any comments

@udayshnk You must be signed into github to see comments:

@udayshnk Try it now.  The review comments were not "submitted".

Thanks @brettwooldridge, i am able to see the comments now, will fix them and send you the updated patch

Hi @brettwooldridge when can we expect 2.4.12 release. Also pushed the commit to dev branch too,it can be merged if needed

@udayshnk HikariCP v2.4.12 has been released.

Thanks a lot @brettwooldridge, was eagerly waiting for this release


Assume traditional router when router_flavor is missing

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
#3935 introduced a check for router_flavor in Admin API config: https://github.com/Kong/kubernetes-ingress-controller/blob/ed051792ae2f2e6db2dfc3946f0416aa6abd1e45/internal/manager/utils/kongconfig/root.go#L49-L52
This check returns an error when this key is missing: https://github.com/Kong/kubernetes-ingress-controller/blob/ed051792ae2f2e6db2dfc3946f0416aa6abd1e45/internal/manager/utils/kongconfig/root.go#L106.
This means that Gateway versions which do not include said config field are breaking the KIC <-> Gateway integration.
We're OK in terms of compatibility because https://docs.konghq.com/kubernetes-ingress-controller/latest/references/version-compatibility/ states that KIC 2.7 and above is compatible with GW 3.0+ but we could improve this by assuming we work with traditional router when that field is missing.
Related issue: https://github.com/Kong/kubernetes-ingress-controller/issues/4062
Expected Behavior
No response
Steps To Reproduce
No response
Kong Ingress Controller version
No response
Kubernetes version
No response
Anything else?
No response

KIC 2.7 is compatible with GW 2.0+ - we should have a fallback

I misinterpreted the table 🤦 You're right. In that case I believe we can assume that if the field is missing we assume traditional and use that.

@pmalek I think it is OK if Kong 3.0+ could guarantee that it contains the router_flavor field. If not we may assume traditional for 3.0- and tradtional_compatible for 3.0+.


Tag system

remove duplicate tag code on user and project profile.
create tag directive for all kinds of tags.
tag for blog.
change tag bubble color from #eee to #ddeeff.
#eee is the same color as the background color of blog post.

feature of tag for blog:
1.tags will only get save when user trigger submit post.
2. remove the "+" button  -------------      on the editblog page for tag.
| new tag |  +   <-----removed
--------------
Whenever + is hit, submit will be triggerred, user forced to exit blog edit popup. Problem did not occur when hitting enter for the same functionality.
edit blog:

blogs:

Honorable mention: @SaswatB
fixes: #580

@SaswatB ?

@agundy what need to be fixed?

@agundy ?


Add new environment variables to reference

These variables were added by https://github.com/Lullabot/tugboat/pull/3829

Yes, I added the *_REF variables for consistency and clarity. The other variables are sticking around so we don't break anything that currently uses them.


transfer-hook: Unable to use seed to generate an ExtraAccountMeta that isn't a PDA

Problem
Currently, to generate a non-PDA account (a regular account) for a transfer hook, you can only use the ExtraAccountMeta::new_with_pubkey method. This method requires a static public key as input, which means the public key must be predetermined and unchanging.
However, there are scenarios where we might want to generate a non-PDA account dynamically. This means creating an account whose public key is determined at runtime based on other account data in the instruction.
For example,
authority that can be derived from the source_fee_account data cannot be created using ExtraAccountMeta::new_with_pubkey
pub struct TransferHookCtx<'info> {
    #[account(
        token::mint = mint,
        token::authority = owner,
    )]
    pub source_token: InterfaceAccount<'info, TokenAccount>,
    /// CHECK:
    pub mint: AccountInfo<'info>,
    #[account(
        token::mint = mint,
    )]
    pub destination_token: InterfaceAccount<'info, TokenAccount>,
    /// CHECK: source token account owner, can be SystemAccount or PDA owned by another program
    pub owner: UncheckedAccount<'info>,
    /// CHECK: ExtraAccountMetaList Account,
    #[account(
        seeds = [b"extra-account-metas", mint.key().as_ref()],
        bump
    )]
    pub extra_account_meta_list: UncheckedAccount<'info>,
    pub associated_token_program: Program<'info, AssociatedToken>,
    pub token_program: Interface<'info, TokenInterface>,
    pub system_program:  Program<'info, System>,
    #[account(mut)]
    pub source_fee_account: Account<'info, FeeAccount>,
    #[account(
        mut,
        seeds = [b"pda_authority", mint.key().as_ref()],
        bump
    )]
    /// CHECK:
    pub pda_authority: SystemAccount<'info>,
    /// CHECK:
    pub authority: AccountInfo<'info>,
    #[account(
        init_if_needed,
	payer = payer,
	associated_token::authority = authority,
	associated_token::mint = mint,
    )]
    pub token_account: InterfaceAccount<'info, TokenAccount>
}

This is an excellent point, and has come up in some of our discussions. What do you think @buffalojoec ?

Just to clarify, you're talking about an example like below, right?
Say we have an account with the following state.
struct Config {
    authority: Pubkey,
    /* ... */
}

You want to be able to specify an extra account meta whose key is stored in the Config account's authority field?

Yup. I'm mainly interested in using pubkeys inside an account data. Not sure if there's any use cases to do the same for instruction data/ account keys tho.

Ok cool. It's likely that the solution to account data can just be used for the other use cases, too.
Yeah we've discussed this a bit. Originally I suggested support for something along these lines, but I think I was after something even more generic, not account/instruction data.
I think we can support this. We'll just have to add another means for validation at the account resolution level.
For example, static addresses are easy to evaluate (==), and for PDAs we have the Seed variants which provide instructions for the resolution step to validate the provided address using the seed instructions.
I think we'd just need a simple as_ref() check on the provided address to compare against some slice of data. We'll also need new instructions similar to Seed that devs can use to initialize such an extra account configuration.
Maybe something like this?
enum KeyFromData {
    AccountData {
        account_index: u8,
        start_index: u8,
        length: u8,
    },
    InstructionData {
        start_index: u8,
        length: u8,
    },
}

What do you think?
P.S. Now might be a good time to extend some index configs to use larger integers, like usize or u64, for large instruction data.


react-demo-client is currently an iframe in the docs site - we could try to embed the React directly?

@raxxius tagging you here again for issue-tracking!

Addressed in digital growth charts react client issue 91 it's the same problem
https://github.com/rcpch/digital-growth-charts-react-client/issues/91
Probably worth closing one of the two issues.