update azure PowerShell modules to latest versions

az modules are outdated.
should be:
Az.Account module 2.10.1
az.eventgrid  module 1.4.0

Hi @dbzowkakpmguk,
Thank you for your report! The following modules are populated from the machine environment - could you please specify what type of agent you use - hosted / self-hosted.

Hello,
Thank you for coming back to me.
Here is a screen scrape:
@.***
Agent spec is:
Windows-latest.
From: Maksim Petrov @.>
Sent: 16 September 2022 17:56
To: microsoft/azure-pipelines-agent @.>
Cc: Bzowka, Dariusz @.>; Mention @.>
Subject: [EXTERNAL] Re: [microsoft/azure-pipelines-agent] update azure PowerShell modules to latest versions (Issue #3968)
Hi @dbzowkakpmgukhttps://urldefense.com/v3/__https:/github.com/dbzowkakpmguk__;!!E1R1dd1bLLODlQ4!B0FtameE8eTqGTsM-eqgHqm-h0S35FWS5ly1gdu_tlLSIYiziGZYSQcKe5OFXpQK4z0YviobpiZ6XWuM-ft_8-DOvaAJT3W1Hw$,
Thank you for your report! The following modules are populated from the machine environment - could you please specify what type of agent you use - hosted / self-hosted?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/microsoft/azure-pipelines-agent/issues/3968*issuecomment-1249582937__;Iw!!E1R1dd1bLLODlQ4!B0FtameE8eTqGTsM-eqgHqm-h0S35FWS5ly1gdu_tlLSIYiziGZYSQcKe5OFXpQK4z0YviobpiZ6XWuM-ft_8-DOvaBqgRVkqg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A2FF7NB3AFUOKHP6X3D6X53V6SRAHANCNFSM6AAAAAAQOIFV3I__;!!E1R1dd1bLLODlQ4!B0FtameE8eTqGTsM-eqgHqm-h0S35FWS5ly1gdu_tlLSIYiziGZYSQcKe5OFXpQK4z0YviobpiZ6XWuM-ft_8-DOvaBMqNUy9Q$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
This email has been sent by and on behalf of one or more of KPMG LLP, KPMG Audit plc, KPMG Resource Centre Private Limited or a company under the control of KPMG LLP, including KPMG United Kingdom plc and KPMG UK Limited (together, "KPMG"). This email, and any attachments, is confidential and may be privileged or otherwise protected from disclosure. It is intended solely for the stated addressee(s) and access to it by any other person is unauthorised. If you are not the intended recipient, you must not disclose, copy, circulate or in any other way use or rely on the information contained herein. If you have received this email in error, please inform us immediately and delete all copies of it. Any communications made with KPMG may be monitored and a record may be kept of any communication. Any opinion or advice contained herein is subject to the terms and conditions set out in your KPMG LLP client engagement letter.
A list of members of KPMG LLP is open for inspection at KPMG's registered office.
KPMG LLP (registered no. OC301540) is a limited liability partnership registered in England and Wales. Each of KPMG Audit plc (registered no. 03110745), KPMG United Kingdom plc (registered no. 03513178) and KPMG UK Limited (registered no. 03580549) are companies registered in England and Wales. Each entity's registered office is at 15 Canada Square, London, E14 5GL.
For full details of our professional regulation please refer to https://home.kpmg/uk/en/home/misc/regulatory-information.html https://home.kpmg/uk/en/home/misc/regulatory-information.html
To understand how we respect and protect your personal data, please see our online privacy policy at www.kpmg.co.uk/privacy http://www.kpmg.co.uk/privacy.　To opt-out of marketing communications from KPMG in the UK, please email @.*** @.***>

any update ?

this is what I have on agent:
agent:
2022-10-12T14:19:54.4424718Z Agent name: 'Hosted Agent'
2022-10-12T14:19:54.4425350Z Agent machine name: 'WIN-1G03HQFUVT5'
2022-10-12T14:19:54.4425656Z Current agent version: '2.211.0'
2022-10-12T14:19:54.4558061Z ##[group]Operating System
2022-10-12T14:19:54.4558727Z Microsoft Windows Server 2022
2022-10-12T14:19:54.4559151Z 10.0.20348
2022-10-12T14:19:54.4559473Z Datacenter
2022-10-12T14:19:54.4559853Z ##[endgroup]
2022-10-12T14:19:54.4560220Z ##[group]Runner Image
2022-10-12T14:19:54.4560653Z Image: windows-2022
2022-10-12T14:19:54.4560989Z Version: 20221002.2
2022-10-12T14:19:54.4561406Z Included Software: https://github.com/actions/runner-images/blob/win22/20221002.2/images/win/Windows2022-Readme.md
2022-10-12T14:19:54.4561926Z Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20221002.2
2022-10-12T14:19:54.4562272Z ##[endgroup]
2022-10-12T14:19:54.4562497Z ##[group]Runner Image Provisioner
2022-10-12T14:19:54.4563142Z <IP_ADDRESS>-main-20220916-1
2022-10-12T14:19:54.4563580Z ##[endgroup]
2022-10-12T14:19:54.4564870Z Current image version: '20221002.2'
2022-10-12T14:19:54.4574155Z Agent running as: 'VssAdministrator'
2022-10-12T14:19:54.4584796Z Prepare release directory.
powershell:
2022-10-12T14:20:31.4837895Z Name                           Value
2022-10-12T14:20:31.4848012Z ----                           -----
2022-10-12T14:20:31.4885958Z PSVersion                      5.1.20348.859
2022-10-12T14:20:31.4910078Z PSEdition                      Desktop
2022-10-12T14:20:31.4946480Z PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
2022-10-12T14:20:31.4948253Z BuildVersion                   10.0.20348.859
2022-10-12T14:20:31.4949283Z CLRVersion                     4.0.30319.42000
2022-10-12T14:20:31.4950334Z WSManStackVersion              3.0
2022-10-12T14:20:31.4951358Z PSRemotingProtocolVersion      2.3
2022-10-12T14:20:31.4952431Z SerializationVersion           <IP_ADDRESS>
windows:
2022-10-12T14:20:34.8204861Z WindowsBuildLabEx                                       : 20348.1.amd64fre.fe_release.210507-1500
2022-10-12T14:20:34.8217085Z WindowsCurrentVersion                                   : 6.3
2022-10-12T14:20:34.8218174Z WindowsEditionId                                        : ServerDatacenter
2022-10-12T14:20:34.8219144Z WindowsInstallationType                                 : Server
2022-10-12T14:20:34.8220522Z WindowsInstallDateFromRegistry                          : 10/11/2022 6:40:24 PM
2022-10-12T14:20:34.8223697Z WindowsProductId                                        : 00454-60000-00001-AA077
2022-10-12T14:20:34.8224849Z WindowsProductName                                      : Windows Server 2022 Datacenter
OS.Version:
2022-10-12T14:20:34.8888555Z Major         : 10
2022-10-12T14:20:34.8892108Z Minor         : 0
2022-10-12T14:20:34.8894235Z Build         : 20348
2022-10-12T14:20:34.8898276Z Revision      : 0
2022-10-12T14:20:34.8899002Z MajorRevision : 0
2022-10-12T14:20:34.8899542Z MinorRevision : 0
Az.Account:
2022-10-12T14:20:34.9003893Z Name              : Az.Accounts
2022-10-12T14:20:34.9006524Z Path              : C:\Modules\az_7.5.0\Az.Accounts\2.9.1\Az.Accounts.psm1
2022-10-12T14:20:34.9074155Z Description       : Microsoft Azure PowerShell - Accounts credential management cmdlets for Azure Resource Manager in
2022-10-12T14:20:34.9075949Z                     Windows PowerShell and PowerShell Core.
2022-10-12T14:20:34.9077303Z
2022-10-12T14:20:34.9167761Z                     For more information on account credential management, please visit the following:
2022-10-12T14:20:34.9185585Z                     https://docs.microsoft.com/powershell/azure/authenticate-azureps
2022-10-12T14:20:34.9186719Z Guid              : 17a2feff-488b-47f9-8729-e2cec094624c
2022-10-12T14:20:34.9187289Z Version           : 2.9.1
2022-10-12T14:20:34.9187685Z ModuleBase        : C:\Modules\az_7.5.0\Az.Accounts\2.9.1
but the latest az.account is:
Script     2.10.1                Az.Accounts

any update on that ?

Az version is 7.5.0 - that's a bit outdated - even the current wiki does not allow you to view such an old version. Would you mind updating the whole package?

@Kaloszer if I only know how :)

Hi @dbzowkakpmguk - sorry for the delayed response,
The AZ modules are populated during the VM image generation - https://github.com/actions/runner-images/blob/5dd62e7a08dcaede9085450c86c4643f482f9803/images/win/toolsets/toolset-2022.json#L88, and this repo is related to the AzDO tasks and their execution, so could you please create an issue for https://github.com/actions/runner-images repo?

https://github.com/actions/runner-images/issues/6650


Why  is the default separator not ','

see https://www.ietf.org/rfc/rfc4180.txt

The design choice for that has been elaborated here: http://csveed.org/rfc4180.html#fixed-symbols

Is there an easier way to use comma instead of semi-colon that doesn't require constructor setup in classes?  Rethorical question maybe as possibly the answer is that we provide a property file drive way to setup defaults across entire usage within a project.  Seems like a good idea to me.

That good work, or could provide 2 factory method comma() and semicolon() to make it more explicit.

BuilderPattern option.  I'll take a look at implementing something like that unless anyone else wants to chip in some time ;)


Can someone make a wiki for new developer to use this?

Please, for god sake.. I am confused with the readme file.. What is going on?

@chiqors thanks for looking at the plug-in. Can you develop a bit. Did you look at the documentation in the docs folder and at the application starters referenced in the readme.
Which framework do you want to use ?

i am developing application based on quasar framework. I would love to use this plugin. But, i don't know where to start.

@chiqors I do not know the quasar framework but it is based on Vue framework so look at the vue-sqlite-app-starter  and vue-sqlite-app this will help you to start. Are you looking for native app ( iOS, Android) or Electron. The Web part of the plug-in has been made to help for a quick test implementation before to move to native.

i am looking for native app, android with the help of capacitor

@chiqors I assume that you do not want to use Ionic/Vue so may be you can look at https://github.com/jepiqueau/vue-capacitor-sqlite-issue137 it could help you to start

@chiqors did you succeed to do something ?

i guess so.. i mught need to learn more of how sqlite work with js

@chiqors ok if you have any question you are welcome. Some developers have successfully use it with Quasar.

To be honest, the documentation is really really confusing. Event for experienced developers. For example: When using the createConnection() method, you need to specify several parameters. The third is called mode. I'm scanning through the documentation to find a hint on what exactly this mode is, and which values I can give it. Until now, I had no luck....

@tobiasmuecksch did you look at the API.md under the docs folder. There are also application staters for different frameworks which will guide you under https://github.com/jepiqueau. But all the links to the statère apps are also in the readme.md file

Sure I did. And I really appreciate the work, there massive amounts of stuff. But it is very complicated. For now I don't want a predefined singleton service. All I need to understand the core concepts is some examples about:

How to create a connection
How to setup a database
How to query a database
How does the versioning and upgrading work?
Some best practices and advices (for example should a close a connection after every query, or can I leave them open for ever and re-use them)

I do understand, that most of these questions can be answered by looking at the provided demo code, but because the code very complicated, it takes hours to find even the simplest information.
In the meantime I found out, that mode can have these values: ["encryption", "secret", "newsecret"], but what is the difference? What das each value mean? Do I even have to provide that value if I set the encryption parameter to false?

@tobiasmuecksch what is the framework you intent to use ?

In the end, I will use ionic/angular/cap3.
But I want to understand this plugin without any framework related information as far as possible. I only want to know how to use it with simple TypeScript. No singleton services or anything else. I want to create my own service.

The best introduction I could think of would look like this (just pseudo code, I know that most of it is wrong):

import {CapacitorSQLite} form '@capacitor/sqlite';

// Establish connection
const connection = new CapacitorSQLite();

// Setup database
json = '{ .... }'; // shortened
connection.setupDatabase({databasename: 'users', schema: json, version: 2})
connection.addUpgrade({databasename: 'users', statements: [{query: 'UPDATE TABLE'}], version: 2});

// get database specific connection
const database = connection.openDatabase({databasename: 'users', version: 2});

// Query the database
const result = await database.query('SELECT * FROM users WHERE username = ?', ['bob']);


new tokenFile-option

In a special use-case, each port requires its own (predefined) token. In this case, you can pass a token file containing a token for each port. If the port is missing or the token is wrong, a tunnel is rejected. See token.json for file format.

If the token file is used and the client has the right to use the port, any existing connection will be removed beforehand.

To prevent a required Internet port from being used as a relay port, the relay port is also defined in the token file.


Use detached variants of sign/verify functions

crypto_sign_ed25519_detached and crypto_sign_ed25519_verify_detached
are used in SigningKey and VerifyKey to avoid extra allocations
(Util.merge/Util.prependZeros calls).
Compatible with libsodium >= 1.0.3.
Fixes #72.

@grossws thank you. Landed here https://github.com/abstractj/kalium/commit/c4b41be4930b54c431c782fba0f425ae6c7bf007

@abstractj, thanks for merging & rolling new release)


Bug: Broken type exports since 2.2.2

Prerequisites

[X] I have searched the repository’s issues and Kinde community to ensure my issue isn’t a duplicate
[X] I have checked the latest version of the library to replicate my issue
[X] I have read the contributing guidelines
[X] I agree to the terms within the code of conduct

Describe the issue
Since v2.2.2 the type exports have changed, which breaks my integration and it no longer seems possible to import certain types, especially KindeAccessToken, KindeIdToken and KindeUser that were previously exposed through import type { KindeAccessToken, KindeIdToken, KindeUser } from '@kinde-oss/kinde-auth-nextjs/types';
Those types now live in dist/types.d.ts but there is no export for those in package.json and they do not seem to be re-exported through any other exports listed there.
It'd be great if you could expose them again or provide information how we can still access them. I would not consider this a minor change unless those types were never meant to be exposed.
Library URL
https://github.com/kinde-oss/kinde-auth-nextjs
Library version
2.2.2
Operating system(s)
macOS
Operating system version(s)
14.2.1
Further environment details
No response
Reproducible test case URL
No response
Additional information
No response

Thanks for reporting, will address this ASAP

@bastiankistner What package manager are you using?
I have just tried this using npm and it works ok, however it doesn't work with pnpm.
I want to make sure I address all cases for cause.

Can you install the @beta version and see if this solves for you?  My checks appeared to work.

@bastiankistner Fix has been released in 2.2.3.  Thank you for your patience.


blackmatter_ransomware

BlackMatter Ransomware Detections

Add DefaultUser And Password In Registry
Auto Admin Logon Registry Entry

Analytic Story
add analytic Story

Known Services Killed by Ransomware
Modification Of Wallpaper
Ransomware Notes bulk creation

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Auto Admin Logon Registry Entry :white_check_mark:

diskUsage: 532480
runDuration: 8.145s
scanCount: 10962

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Add DefaultUser And Password In Registry :white_check_mark:

diskUsage: 524288
runDuration: 7.238s
scanCount: 10962

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Bcdedit Command Back To Normal Mode Boot :white_check_mark:

diskUsage: 593920
runDuration: 2.656s
scanCount: 3

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Change To Safe Mode With Network Config :white_check_mark:

diskUsage: 598016
runDuration: 2.699s
scanCount: 12

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
SchCache Change By App Connect And Create ADSI Object :white_check_mark:

diskUsage: 176128
runDuration: 1.7530000000000001s
scanCount: 6


spring-cloud-etcd-config

I've recently started working to spring-cloud-etcd-* then I've discovered this incubator project.
My code is hosted on my profile https://github.com/lburgazzoli/lb-spring and I did some changes to make it similar to this project as I'd more than happy to contribute the spring-cloud-etcd-config implementation if you like it, let me know if you want me to send a PR

Pull requests are welcome!

Firs PR done: https://github.com/spring-cloud-incubator/spring-cloud-etcd/pull/2

fixed via 05cfc99504e28f655d24bb3f3abf59249c3da7f1


Status bar is hidden when providing cancelCallback to SpinnerDialog.show in Android 10

First of all, love this plugin so thank you for developing it!
I'm seeing a weird little issue when using in Android 10, if I call SpinnerDialog.show and provide a cancelCallback, the status bar is hidden (and the app becomes full screen) whilst the dialog is visible, and reappears when the dialog disappears. If I do not provide a callback then the status bar is never hidden.
I'm not an Android developer, but I did have a look at the ProgressDialogCallback class but did not see any obvious reason why this behaviour might occur, it is certainly not being deliberately hidden in the code as far as I can tell. Happy to provide a pull request if you can point me in the right direction, any ideas?

Closing as the issue was being caused by a different plugin, not this one.


Initial scene not shown

Here is my simple code
 class RootApp extends Component { 	  render() { 	    return ( 	      <Router> 	        <Scene key="root" hideNavBar> 	          <Scene key="pageOne" component={PageOne} title="PageTwo" initial /> 	          <Scene key="pageTwo" component={PageTwo} title="PageTwo" duration={1}/> 	        </Scene> 	      </Router> 	    ) 	  } 	}
And After I run it on simulator I see a blank screen though PageOne is imported and contains simple text that is never shown.
I am quite new to react and react native, could you, please, tell me what can be the problem?
Thanks.

react-native-router-flux v3.35.0
react-native v0.31.0
react 15.2.1

Sorry, I fixed it. Seemed to be some unmet dependancy issue.
Thanks anyway

I'll close this issue since it was resolved.

In my app this problem also happened.How do you resolve it?

Hi YazhouMiao.
As I mentioned earlier, it was dependancy issues, so, if you still have that problem, use those versions:
"react": "~15.2.1",
"react-native": "0.31.0",
"react-native-router-flux": "3.35.0"
With those versions it works for sure.
Hope this helps.


Unable to load LTTNG trace with floating point fields

I have recorded a couple basic trace events in WSL using LTTNG, and when I try to load that trace directory in WPA GUI, I get an error about one of my floating point event fields. When I remove all the floating point fields and use integers instead, it works and the trace loads. Is there support for floating fields?
I am using binaries I got internally (). I was having trouble using binaries I got from this github.

Then a separate issue. When I did get the trace to load using integers, I didn't see the fields loaded in WPA. Is this something that should be working?

Thanks!

We will start looking into this @KyleStorck. Can you send a repro trace?

Partial working support here - https://github.com/microsoft/Microsoft-Performance-Tools-Linux/tree/user/ivberg/Fix11_LTTngFloatingPointTraceLoadIssue

Then a separate issue. When I did get the trace to load using integers, I didn't see the fields loaded in WPA. Is this something that should be working?

Yes that is desired be working but it looks unrelated to this float issue (as you said repro's on int). Not sure if this ever worked but I did try a few WPA versions and some older traces that seemed to have the same behavior not showing the fields values. LTTngDriver cmd-line accessed/displayed the fields fine so this is likely a separate UI issue we will need to work on.


Multiple Return-Path headers are not being processed correctly

Go to your Gmail account<EMAIL_ADDRESS>On settings page enable autoforwarding to<EMAIL_ADDRESS>Send some email to<EMAIL_ADDRESS>Fetch forwarded copy from<EMAIL_ADDRESS>When in raw email the top-one "Return-Path" header points to Gmail account from which forward action has been performed then Mail.new(raw_forwarded_email).header['return-path'] returns original one and the top one is marked as "unparsed value", which is wrong IMHO. The top one should be treated as valid.

@ZipoKing could you kindly share the original email message?

@jeremy sample test email: https://gist.github.com/ZipoKing/f6a572e092dc8dfc050e6bff2ee8f0b1
I've set autofrowarding within<EMAIL_ADDRESS>account to email in devmail.onepagecrm.eu domain which is handled by Amazon SES. In this case I've sent email from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>which then has been forwarded by Gmail to target account. Doing Mail.new(raw_email).header['return-path'] returns original sender<EMAIL_ADDRESS>instead of the top one related to<EMAIL_ADDRESS>Checked both on version 2.7.0 and 2.7.1rc1

Note that your MTA should be removing the earlier Return-Path header when it relays the message, leaving a single header to parse. Looks like SES is a special case, maybe? Unclear about its behavior.
Agreed that Mail should be parsing the top header when more than one is present, in any case.

@jeremy yes I have found this as well but RFC document itself says that it is obsoleted by RFC2822 and there (https://tools.ietf.org/html/rfc2822#section-3.6.7) does not say anything that it must be only 1 Return-Path element. Moreover, Section 4.4 of RFC2821 mentioned there says:

When the delivery SMTP server makes the "final delivery" of a
message, it inserts a return-path line at the beginning of the mail
data.  This use of return-path is required; mail systems MUST support
it.  The return-path line preserves the information in the  from the MAIL command.  Here, final delivery means the message
has left the SMTP environment.  Normally, this would mean it had been
delivered to the destination user or an associated mail drop, but in
some cases it may be further processed and transmitted by another
mail system.

So from what I understand there may be multiple Return-Path elements and the top one should be used as the final one. (Also AFAIR MTAs do not modify any existing email headers and just adding their own on the top of old ones)


Block argument unpacking overwrites local variable

def foo
  yield({2, 3})
end

x = 1
foo do |(x, y)|
end
puts x # => 2 (expected: 1)

This is because the above code is syntax sugar for:
x = 1
foo do |tmp|
  x, y = tmp
end

Regular block arguments have a different behaviour, they don't overwrite local variables.
The fix is to do something smarter than just syntax sugar.

Can't we just reuse the code for macro variables here?


Dev/1.0.0

@it-hms This does not yet include the mentioned injection of an argument to indicate that the multi-loader started the application. I have already begun parallel work to add that in a follow-up PR alongside testing against relevant applications to ensure the argument is handled correctly.

What is the performance like? I dont think i saw any documentation mentioning any limitations.

I didn't do any explicit performance testing, but in general, there should be no hit. Once each main() is invoked, the multi-loader itself finishes. Aside from the event handler thread it creates, which a connector would do anyways, the multi-loader itself shouldn't be doing anything.

@TomKimsey @oliver-walker-hms I will add a class SCAppArgsParser to the extensions library which connectors can use to detect if launched by the multi-loader. For example, new SCAppArgsParser(args).getStartedByMultiLoader().
In the event a connector detects the multi-loader launched it, it must not:

Enable auto-restart functionality, or
Create an event handler

What is the performance like? I dont think i saw any documentation mentioning any limitations.

I didn't do any explicit performance testing, but in general, there should be no hit. Once each main() is invoked, the multi-loader itself finishes. Aside from the event handler thread it creates, which a connector would do anyways, the multi-loader itself shouldn't be doing anything.

This is more of a concern regarding the fact that even one connector is a lot for the flexy. If someone wanted to run two at once i would think that would risk the jvm becoming unstable.

The idea is that this wouldn't be used by multiple connector applications (although it could be done). The ideal use case is a connector paired with a Java IO server.

What is the performance like? I dont think i saw any documentation mentioning any limitations.

I didn't do any explicit performance testing, but in general, there should be no hit. Once each main() is invoked, the multi-loader itself finishes. Aside from the event handler thread it creates, which a connector would do anyways, the multi-loader itself shouldn't be doing anything.

This is more of a concern regarding the fact that even one connector is a lot for the flexy. If someone wanted to run two at once i would think that would risk the jvm becoming unstable.

The idea is that this wouldn't be used by multiple connector applications (although it could be done). The ideal use case is a connector paired with a Java IO server.

Yeah, i think its probably just important to note the intention. If someone sees this they may be tempted to run two connector apps at once. I think just a warning and/or statement of intent would be helpful in the readme. Something like "Please be aware of the additional processing load that running multiple java applications will put on the JVM. Overloading the JVM may result in instability of the JVM."


Fix suggester score parsing

This fixes issue #493.
I am not fully aware of the necessary fields that the type elastic.SearchSuggestionOption should have or not have, so I did not change anything else, though this likely hints that the block should be refactored to whatever the field names have been renamed to in the latest version of ElasticSearch.
Thank you for your help on this @olivere.

Turns out that only the phrase suggester outputs its score to the score field, while completion suggesters, and possibly others, use _score. This causes a regression and should not be merged until a better solution is found.


buftype_exclude ignored: still seeing indent guides

I'm on the lua branch, I have the following settings configured:
vim.g.indent_blankline_char = "┊"
vim.g.indent_blankline_filetype_exclude = { 'help' }
vim.g.indent_blankline_buftype_exclude = { 'terminal', 'nofile', 'packer'}
vim.g.indent_blankline_char_highlight = 'LineNr'

Yet I'm still getting indent guides in my packer window:

I also tried toggling indent guides with :IndentBlanklineDisable/:IndentBlanklineRefresh and :redraw but was not able to clear the lines.
This previously used to work, so I'm not sure if something has changed. I can bisect at some point but wanted to open the issue.

I am not that familiar with packer.nvim, but wouldn't packer be the filetype, not the buftype?
Can you confirm that it is buftype, set buftype
Also not sure why IndentBlanklineDisable wouldn't work :thinking:

I am not that familiar with packer.nvim, but wouldn't packer be the filetype, not the buftype?

Oof that was it, I feel like this used to work so not sure what happened.

Also not sure why IndentBlanklineDisable wouldn't work

Yes, that confused me as well, but I'll close since the main issue was a mistake on my part :) Sorry for the noise!


Calendar is navigating to wrong week when switching to Week Scope (firstWeekday = 2)

Problem
Calendar is navigating to wrong week when switching to Week Scope (when firstWeekday = 2)
Steps to reproduce

Calendar is set to 'Monday first week day'

calendar.setScope(.week, animated: true)
calendar.firstWeekday = 2

Select last day of week, Sunday.
Switch to Week scope:
calendar.locale = Locale(identifier: "ru_RU")
Notice that next week is selected:
Selected day: https://take.ms/YjREq
After shifting to week mode: https://take.ms/yk50q

Integration method.cocoapods
Device modal and iOS version.  Simulator iPhoneX, iPhone 6 (real)
Xcode version.  e.g. Xcode 10.2.1
FSCalendar version. FSCalendar

I was trying to make "dirty fix" by pointing calendar to previous day. But no success. It was scrolling 1 week backwards. calendar.setCurrentPage(previousDay, animated: false)

hi. You can take a look to my solution : https://github.com/WenchaoD/FSCalendar/issues/1100


The parameter 'n' in ChatOpenAI only creates one completion

System Info
Langchain version: 0.0.190
Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Initialize chat and message and specify n = 2
chat = ChatOpenAI(model="gpt-3.5-turbo", n=2)
prompt_template = ChatPromptTemplate.from_template("Write a 10 words poem.")
message = prompt_template.format_messages()
Get the response
response = chat(message)
Only one completion is obtained even though n specified as 2.

Expected behavior
The number of response contents should align with the n we specified in ChatOpenAI instantiation.

Generated by a 🤖
Answer
To get multiple completions, you should use the generate method instead of directly calling the chat object with a message. Replace the following lines:
response = chat(message)

with:
response = chat.generate([[message]])

This will give you the desired number of completions specified by the n parameter
Source

tests/integration_tests/chat_models/test_openai.py

This response is meant to be helpful and save users time. It is not meant to be a precise solution.
Please leave a 👍 if this is helpful and 👎 if it is irrelevant

@devstein Thank you so much for your reply and reference. It solved my issue. btw, if n > 2, then we can use
responses = chat._generate([message])


load the graph after swift package update to show any errors

motivation: swift package udpate succeeds today even if the graph is broken (e.g. cyclic dependency), which only surfaces when running swift build or other operations that load the graph
chnages: load the graph and emit any errors after update is run

@swift-ci please smoke test

This is a great fix!  I'm curious though because I'm tracking the opposite problem in a Radar, where updating through libSwiftPM seems to already reload the package graph and therefore the secondary one is superfluous.  I had thought that was because update always reloaded the package graph, but there's clearly some nuance here.  This looks good but I will want to understand why we're seeing different behavior through libSwiftPM.

This is a great fix! I'm curious though because I'm tracking the opposite problem in a Radar, where updating through libSwiftPM seems to already reload the package graph and therefore the secondary one is superfluous. I had thought that was because update always reloaded the package graph, but there's clearly some nuance here. This looks good but I will want to understand why we're seeing different behavior through libSwiftPM.

okay lets see what you find and then decide if/when to merge this one

This is a great fix! I'm curious though because I'm tracking the opposite problem in a Radar, where updating through libSwiftPM seems to already reload the package graph and therefore the secondary one is superfluous. I had thought that was because update always reloaded the package graph, but there's clearly some nuance here. This looks good but I will want to understand why we're seeing different behavior through libSwiftPM.

okay lets see what you find and then decide if/when to merge this one

This clearly fixes the problem from the CLI so I don't think that investigation should block merging this one.  If it turns out that a lower-level fix is needed, then that can easily modify this code as well.  It was more of an expression of surprise rather than concern about this change.

@swift-ci please smoke test

CI is currently down, investigating issue with large number of request from unknown IP address.

@swift-ci please smoke test

@swift-ci please smoke test


osu-stable won't install

https://pastebin.com/iedDdjLN

I'm not sure the problem is with kerberos, as there are many other errors that are not about it.

yeah

okay i can install it with bottles using this tut: https://osu.ppy.sh/community/forums/topics/1576494?n=1
but its technically still not fixed so im not gonna close this issue just yet

I think i have the same error. https://pastebin.com/YkE9aaZ3
Also the osu! updater opened and shows
Hi!
An error occurred! Please check your internet connection.

thank god it wasn't just me that have this issue :moyai:

just slightly :v


Migrate code to new PyTorch Versions

New versions of PyTorch changed some of the used parameters, wrappers or ways to do things. In this PL those errors and warnings obtained with the current PyTorch version are fixed:

retain_variables is now named  retain_graph [14f2a421ce757df18ded9ecaddf9c71c586a936e].
Variable is no longer required and is marked as Deprecated [f998b55f1710fb1e56d15a125aa146f7761af18b].
Custom classes that inherit from Function now follow an static pattern for both forward and backward passes [34ca303b534694ca49bab6b9e1ec8a8e422a720f].

Merged. Awesome!


Making the download_checkpoint pass even if the downloaded file isn't extracted into a new directory

The download_checkpoint function assumes that the file will be extracted into a new directory but that isn't always the case.

Thanks. LGTM.

Not sure what this codecov failure means. Can we still merge?

Not sure what this codecov failure means. Can we still merge?

It is weird that codecov/patch appears again ... Let me investigate this at first.


Add support to Table to allow components that extend Column

This change allows the Table component to accept children that directly extend the Column component.
This allows me to create many Column types I can use directly in a Table, making code reuse simpler.
Creating custom columns
// Changing the default cellDataGetter to use lodash's `get` function
const cellDataGetter = ({ dataKey, rowData }) => {
  return get(rowData, dataKey);
};

export class GetColumn extends Column {
  static defaultProps = {
    ...Column.defaultProps,
    cellDataGetter: cellDataGetter,
  };
}

// Adding a column to render links using `react-router`
const cellLinkRenderer = ({ cellData, rowData }) => {
  if ('to' in rowData) {
    let linkUrl = rowData.to;
    if (typeof rowData.to === 'function') {
      linkUrl = rowData.to({ rowData, cellData });
    }
    return (<Link to={ linkUrl }>{ cellData }</Link>);
  }
  return cellData;
};

export class LinkColumn extends Column {
  static defaultProps = {
    ...Column.defaultProps,
    cellRenderer: cellLinkRenderer,
  };
}

Using custom columns
const list = [{ node: { name: 'foo' }, link: '/bar' }];

<Table
  height={100}
  width={100}
  rowCount={list.length}
  rowGetter={({ index }) => list[index]}
>
  <GetColumn
    label="Name"
    dataKey="node.name"
    width={50}
  />
  <LinkColumn
    label="More info"
    dataKey="link"
    width={50}
  />
</Table>

This feature has been released in version 9.10.0. Thank you for contributing!

Is there a way to do this with composition instead of inheritance?  Seems like Table component is very strict on only accepting instance of Column

Not currently.
https://github.com/bvaughn/react-virtualized/blob/master/source/Table/Table.js#L30-L38

@bvaughn - Would you be against changing this to PropTypes.node ?  Is there something from making this change?

It just doesn't feel super compelling to me. I guess I'm not really against the idea but I don't intend to make the change b'c I don't see it as a pressing need and I'm super strapped for time.

that's fair -  It's already an awesome package :).
I will submit a PR for this, you can decide later if this makes sense to include it or not in a future release. Thanks for this package!

After digging into the code a bit more, I realized columnData is a prop that could be used to pass in more variables to cellRenderer.  Makes the need for composition less.  Maybe I missed it, but this wasn't very clear in the Columns doc.


TableView Lagging with Very Long texts + Truncated

Hi , I've tested your lib in very long text and lags so bad while scrolling , Tableview has more than 15 item types and works just fine without a single lag when switching back to normal UILabel with more than 1000 items in the table , so its the lib problem I guess , any solution ? also I've to mention that even the label doesn't have any Hashtag,Link,Username but it lags anyway + half of the text isn't even shown and its just empty when using ActiveLabel with long texts which is again working well with UILabel .
** : this is happening in a RTL language (Persian)
tested on Simulator iOS 11 Swift 4 , iphone 6s iOS 11 , iphone 6s Plus iOS 11 , Xcode 9 latest version
lib version : 0.9.0

This is an interesting find both on the length and performance being different in RTL languages. Is this app available for download?
Note 1. Even without any hashtags/URLs/mentions the library still does the regex lookup. So, unless you manually turn off those options (if you don't need them) it will be kind of the same.
Note 2. There are one too many variables in this problem. Loading 1000 items in the UITableView and long text in the UILable make it hard to diagnose. Is it possible to reduce the number of cells to something like 100? Also, have a number of lines set to make sure it won't go to wild as the text gets longer the library has more text to go through.

@maziyarpanahi  its not available for download , in fact i realized that UILabel in UITableview is laggy anyway with long non english text even with plain Swift UILabel and being digging for months and couldn't find any solution to that

It's a good catch @Mahan3340,
Do you think to make everything the same length and having a read more button/link at the end of the text will help? And of course, you should collapse the long text when user taps on another text to see more. This way you always have one long text in the UITableView.

@maziyarpanahi  its a messaging app so its not like a good idea to have read more button , and also its not that lengthy its just 400 500 char text so its  few lines fully visible in a screen

OK, then that is weird! 400-500 characters is not a very long text. Just to be absolutely sure, can you please add these text to an array of strings and load it from there. I want to be sure there is no network/update loop somewhere in the process. In fact, can you create a new UITableViewController and do it there, just be to sure there is nothing being called a few times every time there is a cell being visible.

@maziyarpanahi yea its weird , actually I've tested this , created a new VC with a simple Table with cells containing just Label , the only thing that was being called repeatedly when cells became visible was to set the text ! at first I tested it with similar texts ( all cells the same ) and it was smooth no matter how lengthy they were , then I used different texts for each cell and the lag started :-/

@maziyarpanahi I finally managed to solve this issues , the problem is that ios Default system fonts or any other fonts that are meant to support English (but can render other languages too, such as Persian) can't render other languages well , so what I had to do was to simply use a font that is meant to support Persian like "B Nazanin" , "IRANSans" , ... which they can render English too , in this way the lag is completely gone and scrolling is as smooth as it should be

Wow! I would have never thought about rendering fonts with support for RTL languages in a million years! Great catch @Mahan3340 and cheers!


How to focus DOM Node after using ReactDOM.findDOMNode?

After upgrading to flow 0.41.0, we're getting flow errors about calling focus() on the return value from ReactDOM.findDOMNode because the definition now states that the return value is null | Element | Text. After verifying it's not null, how do I correctly refine its type from Element | Text to Element so I can call focus() on it?

Also, how would one refine from Element to HTMLElement, which is where focus() and other useful methods/properties are?

Just following up, it looks like the only way to get from React.findDOMNode to an HTMLElement is by casting to any. At least, that's what the findDOMNode function in React does itself.
I assume flow is capable (although it's not yet implemented) of knowing that inside of if (elementOrText.nodeType === 1), it can be refined as Element instead of Text, which would have nodeType === 3. Is that true? However, even if we can refine it to Element properly, we'd need a similar way of refining from Element to HTMLElement.
For large codebases that use findDOMNode in multiple places, it seems like the best approach would be to have a utility function that casts to any and back to HTMLElement, maybe something like this:
export function findHTMLElement(node: null | Element | Text): null | HTMLElement {
  if (node && node.nodeType === 1) {
    return (node: any);
  }
  return null;
}

Does this seem reasonable? Or do you think there is a better way of dealing with findDOMNode?

Further, our use case requires properties from HTMLMediaElement:
class Audio extends Component {
  playSound() {
    ReactDOM.findDOMNode(this).play()
  }

  render() {
    return (
      <audio
        autoPlay={ false }
        src="sound.mp3"
      />
    )
  }
}

@echenley This is actually the correct behavior. There is not enough type information to know what the type of ReactDOM.findDOMNode(this) should be. Plus the component may or may not be mounted so it's an optional.
Do something like this:
playSound() {
  const el = ReactDOM.findDOMNode(this);
  el && el.play && el.play();
}

@nmn Ah, interesting, thanks. Looks like you also have to check that typeof audioEl.play === 'function'.

@echenley See updated comment. The instanceof check is good enough.

Excellent, thanks!

Cool, thanks for providing a solution, @nmn


Fix npm 3.x issues and fix package.json main file

Current version not installed correctly using npm 3.x, removed preinstall script from package.json
Fixed missing index-node.js main file, removed index-browser.js, using only index.js as main file

I guess they expect this https://olingo.apache.org/contribute.html


building with mingw 8.1.0, static library is missing dgetri?

In the MacPython/openblas-libs repo we build with mingw v8.1.0 on windows. There seems to be a problem with the test.f90 compilation, it cannot link, with the error that dgetri is not exported from the library. Indeed, if I do objdump -x |grep dgetr (in gitbash) I do not see it, but I do see traces of it:
$ objdump -x /c/opt/64/lib/libopenblas_v0.3.11-gcc_8_1_0.dll.a |grep dgetr
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 dgetrs_
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_dgetrs_
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 dgetrs
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_dgetrs
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 dgetrf_
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_dgetrf_
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 dgetrf
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_dgetrf
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrs_work
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrs_work
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrs
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrs
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetri_work
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetri_work
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetri
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetri
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrf_work
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrf_work
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrf2_work
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrf2_work
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrf2
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrf2
[  5](sec  1)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 LAPACKE_dgetrf
[  6](sec  3)(fl 0x00)(ty   0)(scl   2) (nx 0) 0x0000000000000000 __imp_LAPACKE_dgetrf

This code used to work, I wonder what changed.

I see the travis run on linux also errors, with missing symbols when linking. Maybe there is a problem with the commands we use on windows and linux. Should we update them somehow?

xref MacPython/openblas-libs#43

I think isuruf just fixed that for me in #2919, seems I had left some copypaste mistakes in the lapack makefiles

Thanks. #2919 fixes the windows builds (including the 64-bit interface one), but  the linux ones built using the 64-bit interface still are broken. These add INTERFACE64=1 SYMBOLSUFFIX=64_ to the make arguments, perhaps some of our scripts need updating?

it seems like a problem in make test in exports/Makefile with the linktest.c compilation

Please try latest commit on develop. https://github.com/xianyi/OpenBLAS/pull/2909 should fix that.

There may be an additional problem with the gensymbol script - I fear my former self switched to calling the lapackobjs2... variables
lapack2objs... at some point (or something like that, I am just getting ready to debug this - nightmare fuel)

Are we sure #2909 doesn't fix it? I had the same problem which was fixed by #2909.

I didn't mean to pressure you. It is fine if it takes a few days to get right. This was a big release.

Yes, you are right. There are missing symbols comparing develop against 0.3.10. Here's a list https://gist.github.com/isuruf/9974570e586c959447c0aca893ef4ddd


Add containers for connected components

Refactor the UI components into UI packages. The UI components and their stories remain, but we add connected components that render using redux state. Follow these Storybook docs to maintain stories and provide the containers at runtime.

closing this as part of merging #196


ODS Docker image

Created Docker image for ODS.
Updated the README with additional installation instructions.
With this setup, we could execute ODS as containers rather than having to run it as a standalone service on a host machine.
A huge benefit will be the scaling functionality provided by Docker which we can explore in future to support larger volumes of requests.
I have been learning Docker over the past few days and was able to come up with this setup which is optimal according to me. Being new to this technology, I may be wrong.
If anyone has suggestions for improving it, please pitch in.
Note to Reviewers -
Ensure you install Docker and follow the instructions to start ODS. If you are unable to complete the setup or face any issues, please ping me on slack.
Please approve the PR only if you are able to access ODS on your web browser after starting the Docker containers.

Is there a way that we can automate the process of spinning up of the database using something like a Makefile?

@RyChrome I don't think I completely understand what you are trying to suggest.
Also, I am not sure if a Makefile can be run on Windows machines. Would require additional utility installations.
The docker-compose file includes functionality for starting up MongoDB as well. If you run it, both MongoDB and ODS start up.
I have set up the dependency in a way that ODS Maven process starts up only after MongoDB is up and running.
If you are suggesting something different than this, please provide more details.

Anyone planning to review this PR? Pending since 8 days.

Will do it tonight
with regards,
Aashish
On Mon, Jun 17, 2019, 7:27 AM Linus Castelino<EMAIL_ADDRESS>wrote:

Anyone planning to review this PR? Pending since 8 days.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/didclab/onedatashare-spring/pull/160?email_source=notifications&email_token=AB4MMI3NCFNNLT3NQP5RY4LP25YLFA5CNFSM4HWIL2UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX233DQ#issuecomment-502644110,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4MMIY3LGGRJEHEM7JWHHDP25YLFANCNFSM4HWIL2UA
.


The list generates incorrect SQL query for a Materialised View's Model

I have created a materialised view named awards_reports on table named awards.
In rails_admin I have added a model for AwardsReport. Now when I try to click on Awards reports in the navigation the following error comes up:
AwardsReport Load (1.1ms)  SELECT  "awards_reports".* FROM "awards_reports" ORDER BY awards_reports. desc LIMIT $1 OFFSET $2  [["LIMIT", 20], ["OFFSET", 0]]
Rendered /usr/local/lib/ruby/gems/2.3.0/gems/rails_admin-1.2.0/app/views/rails_admin/main/index.html.haml within layouts/rails_admin/application (40.9ms)
Completed 500 Internal Server Error in 782ms (ActiveRecord: 11.3ms)
ActionView::Template::Error (PG::UndefinedColumn: ERROR:  column awards_reports.desc does not exist
LINE 1: ..."awards_reports".* FROM "awards_reports" ORDER BY awards_rep...
^
: SELECT  "awards_reports".* FROM "awards_reports" ORDER BY awards_reports. desc LIMIT $1 OFFSET $2):
89:             %th.other.right.shrink= "..."
 FROM "awards_reports" ORDER BY awards_reports. desc LIMIT $1 OFFSET $2  [["LIMIT", 20], ["OFFSET", 0]] query.
Instead if the query was SELECT  "awards_reports".* FROM "awards_reports" ORDER BY awards_reports.id desc LIMIT $1 OFFSET $2  [["LIMIT", 20], ["OFFSET", 0]] the problem would not have occurred.

This happens when exporting as well.  In my case, index is fine, but no submitting an export.
Mysql2::Error: Unknown column 'view_table.' in 'order clause': SELECT view_table.* FROM view_table ORDER BY view_table.`` ASC LIMIT 1000


from pytorch_lightning.core.lightning import LightningModule

In the latest pytorch-lightning, LightningModule is directly accessible from core, and the current torchsynth code gives an import error

@arlorostirolla -- thanks for raising the issue. Will look into this. We're relying on some LightningModule methods that have been removed in more recent versions of PTL so it unfortunately may not be a quick fix.
In the meantime, it should work with an older version of PTL. I was using pytorch_lightning==1.5.10 the other day and it was working.

@jorshi @arlorostirolla this is currently fixed I believe and can be closed, if you work from main (not pypi).
Or, from pypi, just change the import to import lightning


gss_wrap/gss_unwrap should work on connection without NEGOTIATE_SEAL

Let's start with a bit of a background.
RFC 2222 originally specified the GSSAPI SASL mechanism for authentication. It didn't specifically tie the mechanism to Kerberos unlike the later RFC 4752 revision. As a last step of the authentication exchange the server sends a token with supported protection schemes and maximum token size to the client. This is encoded with GSS_Wrap API with conf_flag == 0. The client decodes it with GSS_Unwrap, chooses the preferred protection for rest of communication, and then encodes the reply with GSS_Wrap and sends it back to server.
Microsoft Exchange implements this mechanism for authentication to SMTP, IMAP and POP3 services. It works with Negotiate, Kerberos and NTLM protocols. The NTLM one is particularly tricky because the semantics for GSS_Warp/GSS_Unwrap are not fully covered by the specifications. So I went ahead, set up an Exchange server with Windows AD and tested what is really sent on the wire.

In case NEGOTIATE_SEAL is negotiated in the initial authentication the gss-ntlmssp library is already interoperable. The conf_flag is ignored (not a surprise since NTLM doesn't have a way to transmit the flag on the wire like Kerberos does), sealing and signing is applied.
In case NEGOTIATE_SEAL is NOT negotiated and NEGOTIATE_SIGN+NEGOTIATE_KEY_EXHANGE were negotiated the tokens should still be sealed with the computed key and signed. gss-ntlmssp currently doesn't implement that.
I didn't check the behavior for other flag combinations yet. I am not particularly interested in them because anything without MIC calculation downgrades the security beyond a point where latest Windows versions may reject it.

Notably, I would expect the GSS_Wrap behavior to align with the behavior of the EncryptMessage (NTLM) API on Windows with the data buffer not having the SECBUFFER_READONLY flag and the conf_flag flag matching the SECQOP_WRAP_NO_ENCRYPT flag. That means always sealing the data (at least for NTLM2 w/ key exchange) and ignoring the conf_flag flag.
Confusingly, the NegotiateStream specification is also defined in terms of GSS_Wrap/GSS_Unwrap methods. Unlike the SMTP authentication it behaves differently on NTLM where it sends the messages as <signature token><unsealed message> if NEGOTIATE_SEAL was not specified. This difference is caused by a special NTLM code path in the NegotiateStream code that passes the SECBUFFER_READONLY flag to the EncryptMessage/DecryptMessage methods. The equivalent GSSAPI transformation is to call gss_get_mic to produce the <signature token> and use gss_verify_mic to verify it. This cannot be expressed with GSS_Wrap/GSS_Unwrap directly.

@filipnavara I finally came around to take a second good look at this.
So it seem the main issue here is my return of ENOSUP when NTLMSSP_NEGOTIATE_SEAL is not negotiated.
In this case I should check if NEGOTIATE_SIGN and NEGOTIATE_KEY_EXCHANGE are instead set and continue as normal calling ntlmv2-sign ... but in order to do that I would need a seal_handle, so I need to always create a seal handle regardless of negotiated flags.
Is this what you are suggesting?

And of curse if NEGOTIATE_SIGN is set we are already guaranteed to have a seal_handle ... so this is just about removing the flag check from ntlm_seal and ntlm_unseal ...

Is this what you are suggesting?

Yep

And of curse if NEGOTIATE_SIGN is set we are already guaranteed to have a seal_handle ... so this is just about removing the flag check from ntlm_seal and ntlm_unseal ...

I think so.

@filipnavara should this be conditional to anything?
I have a specific test to check thet gss_wrap does fail if NTLMSSP_SEAL is not negotiated, which obviously now fails.
I guess I should always ignore that/
Or should I check the gss and ntlm flags disjointly and fail if GSS_GONF_FLAG us not set ignoring the NTLM level negotiate flags?

Oh wait, I should juts apply the signature, but not seal the content, perhaps ?

NVM my last comment. It sounds like what we are doing here is that if the app ask to gss_wrap something we wrap it regardless of what we negotiated with the peer.
So basically we take these flags just as advisory and if the peer can't handle the message ... well too bad.

should this be conditional to anything?

Good question. Unfortunately I don't have a good answer to that at the moment. If you have seal_handle then it should work and do sealing with the computed key.

Oh wait, I should juts apply the signature, but not seal the content, perhaps ?

If you have seal_handle then it should do sealing regardles of NTLMSSP_NEGOTIATE_SEAL. The experiments I did on Windows showed that it didn't just copy plain text data.
I am not sure what should be the behavior if you don't have seal_handle. The option is either to fail with ENOTSUP (like implemented today) or to copy the plain text verbatim. I can do some experiments on Windows to see what EncryptMessage API does in that case but I am generally fine with keeping the current behavior in that case (ENOTSUP).

seal_handle is always generated regardless, so I am just going to return EINVAL if it is missing.
As for behavior, I'll let applications just gss_wrap all they want.
If they really just want a signature GSSAPI requires they use gss_get_mic() already, so the application retains all the options.
Flags can also be checked by applications so they have all the tools needed to decide whether to use gss_warp() or just gss_get_mic() if the protocol requires a choice be made.

Btw I wonder if any of the dotnet test suite can be easily run in a container w/o rebuilding all of it, I think it might be a good idea to run at least some dotnet tests when I change gssntlmssp to insure things don't break.
Alternatively if you can schedule a weekly(?) run in dotnet CI when gssntlmssp changes, and pested me if ntlm related tests fails that could also be an option :-)

The dotnet test suites actually have very small coverage right now so it's likely not worth the effort, at least not yet. Some of the tests require complex Docker setup. I started working on expanding them and making it all easier to run but it's pretty slow effort so far. That said, I am aware that there is interest in the area of sharing the testing infrastructure and I regularly discuss that both with the .NET Networking team and other people working on various libraries in the ecosystem...


Tail logs by optional app name

Tailing is implemented already, however it would be nice if you didn't need to cd around to switch apps.

meh for now


Support for tex/latex syntax in Wiki pages?

Is it possible to add support for (a subset of) TeX/LaTeX to the Wiki pages of projects, e.g., like MediaWiki http://en.wikipedia.org/wiki/Help:Displaying_a_formula MediaWiki does? This would be of great help in math/physics projects (at the very least).
If this feature already exists, I couldn't find a note in documentation for it, and neither of the common syntaxes for TeX have shown up properly in preview. E.g. either of
$x^2$
$$x^2$$
<math>x^2</math>
\(x^2\)

should show up as x2.

@mbudisic We do not currently support LateX/MathJax in the Wiki. We are currently working on significant frontend changes to the wiki, so we will evaluate possible solutions to this. Thanks for the suggestion!

I'm glad to hear that this is an area of active development. As an intermediate solution, any support for equations, e.g., AsciiMathML, would serve the community.
Thanks for listening!

Thanks for your input.
@rliebz and @icereval : Please take this into consideration as you work on the wiki changes.

@WenTingZhu, in further working on her javascript skills, is going to try to integrate mathjax and the rendered wiki to support a minimal version of latex/mathml.


Dev Contact

Dev Contact

Hey, what's up? How can I help you?

you already finalized the program?

I currently don't have any features that I want to add to the Skript. if you want to add something you can suggest it and feel free to open a pull request.

@Crypteys if you have any more questions feel free to write me. i'm closing this for now


Tree: Add icon support for nodes on tree component. Closes #15997

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

please resolve conflicts, e.g. rebase dev

please resolve conflicts, e.g. rebase dev

Resolved. @iamkun


Add Baillien Large Model Integration for es-king 增加百炼大模型对接

Description:
This pull request introduces a significant enhancement to the es-king project. I have integrated the Baillien large model to enable automatic generation and population of Elasticsearch query statements.
Motivation:
The goal of this addition is to improve the efficiency and ease of working with Elasticsearch within the es-king project. By leveraging the power of the Baillien large model, developers can now generate complex ES queries more quickly and accurately, reducing the time and effort required for manual query construction.
Details of Changes:
Implemented the necessary interfaces and code to connect with the Baillien large model.
Added functionality to take user input (if applicable) and use the model to generate appropriate Elasticsearch query statements.
Ensured proper error handling and validation of generated queries.
Testing:
I have conducted thorough testing to ensure the new functionality works as expected. This includes testing various input scenarios and verifying that the generated queries are valid and return accurate results when executed against an Elasticsearch instance.
Compatibility:
The integration is designed to be compatible with the existing architecture of the es-king project and should not cause any disruptions to existing functionality.
Reviewers:
I kindly request reviewers to pay particular attention to the following aspects:
The correctness and efficiency of the query generation process.
Compatibility with different versions of Elasticsearch.
Any potential performance impacts.
Thank you for considering this pull request. I look forward to your feedback and contributions to further improve the es-king project.

请看 #17


specify language in markdown code tags

brings colors to code examples in readme

Build is failing due to signature validation in my CI. Thanks for helping!


Oblivion post-deploy script not working correctly

Hi, oblivion-post-deploy script copies plugins.txt file from "$HOME/.vortex-linux/compatdata/pfx/drive_c/users/steamuser/AppData/Local/Oblivion/" into  game installations Local folder. That folder however already contains Plugins.txt file with a capital letter. Because of this, instead of one file that directory has plugins.txt next to Plugins.txt and the game defaults to using Plugins.txt.
This causes any mods that use plugins to not load correctly.
As a workaround, deleting Plugins.txt fixes the problem completely. A permanent solution would perhaps be to delete existing plugins.txt from the directory regardless of case?

I've heard of this issue happening with Skyrim too - not entirely sure where the Plugins.txt is coming from, though.

Latest update should've fixed. Feel free to re-open if it hasn't.


Go-to-definition not working for iOS app

Hello,
As an iOS developer, I've exclusively utilized Xcode for app development. However, I'm interested in experimenting with a combined Xcode and Visual Studio Code environment. In this setup, I would use Visual Studio Code for coding purposes, while relying on Xcode for building and running to simulator. I'm encountering an issue with your extension where the "go to definition" feature doesn't seem to function properly. I noticed that it operates correctly when both AClass and BClass are contained within the same file, but it fails when they are in separate files. I'm building the project successfully using xcodebuild, and have of course tried disabling/enabling extensions, restarting vscode, and all the other things you can find on stack overflow and so on.
I would greatly appreciate your assistance or advice.
import Foundation

class AClass {
    func printsomething() {
        print("hello")
    }
}

class BClass {
    func printsomething() {
        let aClass = AClass() // "No definition found for 'AClass'" when in separate file
        aClass.printsomething()
    }
}

Best regards,
Jannica

Go to definition requires a built project. Your best bet is to setup a separate Swift package for the majority of your project which you should be able to compile in VSCode.
You also need to set the target platform using command Swift: Select Target Platform. This should ensure you are compiling for the correct SDK.
None of this is officially supported as Apple doesn't support building iOS apps outside of Xcode.

I see.. thank you for your answer!


Histogram bounds

@chriddyp fix for histogram bounds

@BRONSOLO can you re-run those images tests? or add a new image test with that case?

Yep! I reran the tests - the trouble was the test example was always using the same random data and always succeeding. I'll update the example.


Fix oci rootfs+bundle handling

Coverage decreased (-0.06%) to 67.303% when pulling e060dcd96f606f44e8c606d012cc719ca5fa69e2 on jodh-intel:fix-oci-rootfs+bundle-handling into cd7c5862e606f6d17d324e1ee8bb546b33baad30 on containers:master.

@sameo I would like you to take a look at this change because it does not follow what we did before with the Annotations in the Pod structure.
The thing is that the bundle path should be retrieved from the annotation stored inside the pod. But in the same time virtcontainers cannot be aware about those specific keys for annotations, meaning we cannot retrieve this from virtcontainers itself.
I can see two options here:

Either you are okay with the way this PR adds a new field Bundle to ContainerStatus and ContainerConfig. This means you think a bundle is generic enough to be re-used by another runtime implementation.
Or you think this should be runtime specific, and retrieved from the runtime itself, meaning that we need StatusPod() to return a handle on *Pod. We can keep the PodStatus structure returned which is generic, and the handle to *Pod would be helpful to get annotations previously stored.

@jodh-intel @sboeuf The ContainerConfig and PodConfig structures should be kept as specification agnostic as possible. So for passing OCI specific data down to virtcontainers from oci/utils.go we should use Annotations, as we did for Pods.
At the same time we want to avoid returning raw Pod pointers back to the status callers because they're still at least one step away from being able to interpret the status call results. So I don't mind adding container specifications sections to the status structures. For example we'd have:
type OCIStatus struct {
       Bundle string
}

type ContainerStatus {
[...]
     OCI OCIStatus
}

The PodConfig and ContainerConfig structures are input to virtcontainers and we should avoid putting e.g. OCI specific stuff in there as it could be quite confusing. ContainerStatus is an output from virtcontainers and callers can only worry about the non empty sections/fields.

@sameo I like the idea, but there is still one thing which is not consistent, that is the annotation key to use. Indeed, the key in the hash table to retrieve an annotation has been set by the runtime implementation. In our case, and to be more specific, it is set by the pkg/oci/utils.go from virtcontainers repo. This key is private to the oci package, therefore I guess we should make this public.
But globally, this is not the purpose with annotations I think. I mean that Annotations have been added to allow any runtime to store some specific data that virtcontainers is not even aware of. In that case, it would be asking to the runtime to store those annotations but then virtcontainers would be responsible to retrieve them. What do you think ?

@jodh-intel pointed out that my initial proposal would lead to either:

A circular dependency as virtcontainers would have to use the pkg/oci/utils.go package

or

Having to implement some private but OCI specific functions in virtcontainers.

@jodh-intel suggested that we add some spec callback to our PodConfig structure. I think it's the right approach but I'd like to extend it a bit further:

In virtcontainers, define a spec.go:SpecHandler interface. For example:

type SpecHandler interface {
        PodStatus(pod Pod) interface{}
        ContainerStatus(pod Pod, container Container) interface{}
}

Add a SpecHandler field to PodConfig
Add a SpecStatus interface{} field to ContainerStatus
When calling StatusContainer(), do something along those lines:

func StatusContainer(podID, containerID string) (ContainerStatus, error) {
[...]
if pod.SpecHandler != nil {
   contStatus.SpecStatus = pod.SpecHandler.ContainerStatus(pod, container)
}

In pkg/oci/utils.go, implement an OCI specific virtcontainers SpecHandler. The OCIStatus structure could also be kept in pkg/oci/utils.go
From any OCI runtime implementation, optionally add pkg/oci/utils.go:OCISpecHandler to the PodConfig it creates.

@sameo - this sounds good to me. I'll start work on a SpecHandler PR based on your design ...

After some productive IRC brainstorming with @jodh-intel, we came up to the conclusion that an easier and simpler solution would be to add Pod and Container Annotations to respectively the PodStatus and ContainerStatus structures.

@jodh-intel I think this PR is not relevant anymore because #228 has been merged. Please close it if this is the case.

Yep - it is merged now, so closing.


CLI command capture verbosity option

Is your feature request related to a problem?
I was in a meeting with Josh Kallman and Madison Martin, and neither of them had heard of our command capture in VisIt. I gave them a little demo, and they both seemed very excited to start using it. They also both seemed very surprised at the verbosity of the command capture and were wondering if we could enhance this feature with some kind of option that allows users to turn off this verbosity (only show attributes that were actually changed).

There are 2 things driving this request. Making it easier to learn the CLI from command recording. The second is just to reduce the amount of text to copy.
There are issues here, such as defaults may change over time and people may have different defaults.
This should definitely be an option and not the default.


Terminal showing a blank screen

After Installing this my Terminal all of a sudden became faulty.
It shows a blank screen, and when I end the git process in Activity Monitor I get stuck at this screen all of a sudden.

…Did you make your entire home folder a git repository? :fearful:

Follow https://github.com/mathiasbynens/dotfiles#installation next time.

What should I do now?

That depends on what exactly you did in the first place. rm -rf ~/.git would be a start.

I did the whole installation process from my user directory.

rm -rf ~/.git just saved me


Fixed: Tomcat exceptions in Atmosphere when session expires

[x] joeferner
[x] diegogrz
[x] mwizeman sfeng88
[ ] joeybrk372 rygim jharwig EvanOxfeld

Tomcat deletes the session before Atmosphere's disconnect gets called
causing the user's id to not be found resulting in an exception thrown.
The user's session count is depricated by web/web-base/src/main/java/org/visallo/web/SessionUser.java
valueUnbound
Testing:
Login as a user and let the session expire. This should not throw an exception and exceptions should not show up in the log.
CHANGELOG
Fixed: Tomcat exceptions in Atmosphere when session expires

@joeferner Is the issue logging only or do the Tomcat exceptions cause incorrect behavior?

@EvanOxfeld This PR fixes the logging issue. Trying to get rid of all the ERROR logging so I can actually monitor the logs.

Sounds like a good plan. 👍  Just making sure this change isn't needed in the 3.1 branch.


[FEATURE] add typing indication

Description
Would be nice if a user can see if the person they are chatting with is typing or not.
Placing it under the anonymous user text, would be the best place
Screenshots

It's great having you contribute to this project by creating an issue Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:


1920x1080@30hz Video delay too much

hi, I test on Raspberry3 Model B, and use : node server-rpi.js,
i set raspivid input 1920x1080@30hz,When i browser video ,it have a very big delay.
Any advise for this ?
Thank you so much.

even i user 1024*768, the picture have Mosaic，but the cpu useage is only :28%,
i use wlan to connect pi with my pc, the net i think is ok, so i really confused.

I have no rpi at this time, so i cannot help you a lot, yet i think your should try to lower the bitrate and force the baseline profile in raspivid command line parameters
See --profile baseline and --bitrate ??? https://www.raspberrypi.org/documentation/raspbian/applications/camera.md

don't send me these mails,ok?
At 2017-01-14 20:45:06, "François Leurent"<EMAIL_ADDRESS>wrote:
I have no rpi at this time, so i cannot help you a lot, yet i think your should try to lower the bitrate and force the baseline profile in raspivid command line parameters
See --profile baseline and --bitrate ??? https://www.raspberrypi.org/documentation/raspbian/applications/camera.md
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@weicool888 , you received a mail because you "watch" this repository and asked to receive mail when someone create activity in it. Unwatch h264-live-player or toggle mail notification from github web interface.

hi,François, thank you for your reply.
The "--profile" is default "baseline",but I don't think it's Raspi issue,please take a look at the bellow picture,it's raspi's cpu usage，I use wlan to connect pc with the pi,so it can't be the network speed issue,
could you tell me where have the limit ? any parameter could be refine for it ? Thank you so much.

@szhansen I got this issue too when streamed video from raspberry pi. Guess it might be problem in fps or decode in browser.
Did you fix this?

@szhansen did you fix this problem? works fine in size 720X1080，but other size phone failed。


[Accordion] Foundation overrides id and aria-labelledby information

How can we reproduce this bug?

Create an accordion list with AngularJS ng-repeat
Check the id and aria-labelledby which are overridden by "panelname-label"
Even hardcoding it, doesnt resolve the problem

Code Sample

{{ questions.question }}

                {{ questions.answer }}

Is there a known issue with this?

Hi,
We've just been having exactly the same problem.
We need to use the ID attribute for link tracking in Site Catalyst but it's being over written by the Foundation tabs component.
Please can this component use a different attribute.  Users shold be able to specify their own id's or at least specify what attribute to use in the config.
Kind regards,
Jason

Oversight on my part, most plugins check for an id, and if none is found, apply one where necessary. The id attribute is required for most aria attributes, which is why the js is applying on in the first place. I'll get this fixed to check first before overwriting any preexisting ids. Looks like tabs and accordion both need the check.

@Saifadin your stuff should be good. The ids being assigned are checked first here:
this.$tabs.each(function(idx, el){
      var $el = $(el),
          $content = $el.find('[data-tab-content]'),
          id = $content[0].id || Foundation.GetYoDigits(6, 'accordion'), // <-- if you already have an id applied, it won't overwrite it.
          linkId = el.id || id + '-label';

So the issue may be initialization order, i.e. waiting for Angular to finish loading that scope and within a digest cycle, calling $(document).foundation()

for tabs: c2cb63f

Thanks @zurbchris for your answer.
I am actually loading foundation in the directive after the code like this:

but it seems like foundation is being loaded before that, I dont know at which point exactly

You'll probably need to use a DOMContentLoaded event or tap into the $watch/$apply/$digest callback system to wait for NG to finish it's business before you pop $('#foo').foundation().

I see I'll have to try that in the morning at work, but putting that aside, if foundation generates its id-labels, shouldn't it be still working? In the rendered html tha  tag has id="panel1-label" and the  aria-labelledby="panel1-label".
It still doesnt collapse up and down

Can you create a codepen or fiddle to replicate, or at least a stack trace if there's an error? I can't think of why it wouldn't run, unless NG is swallowing the event listeners.

Yeah here you are, maybe you can help figuring it out.
https://codepen.io/anon/pen/xZPMxE

Fixed: https://codepen.io/zurbchris/pen/GoOzJd
this is the code added to your controller:
window.onload = function(){
    $(document).foundation();
  }

Foundation was never initialized in the example you linked.

Okay I'll try that out and come back to you guys!

Now the id i set is taken, but the accordion is still not working. It's written in the exact same way.

Here I screenshoted the generated output in Google Chrome
http://imgur.com/G3MBEJd

So after some testing with my colleagues we came to this conclusion:
It seems like the accordion is rendered correctly, but somehow the trigger for the opening and closing is not reacting (no error message in the console either).
Another thing we noticed that this code sample from the Docs is also not working although if we copy the HTML of one of the examples it is working. Something is wrong with the declarations.

    Accordion 1

      Panel 1. Lorem ipsum dolor

multiple calls to $(document).foundation(); shouldn't cause problems, as it just ignores, (and logs a warning to the console), elements with previously initiated plugins.
I'm flummoxed by the thing not working though. Do me a favor in your dev build and drop this in somewhere after ng is done rendering the accordion, if you haven't done something similar already:
$('a', '.accordion').on('click', function(e){
  console.log(e.target, e.currentTarget);
});

I just want to verify the click handlers are firing at all, and since my codepen above works, I'm trying to debug an app remotely. I've updated my codepen to reflect the request, and it works there as well.

The click handlers are not fired at all.
I will have to look at it later, right now we had to take the hardcoding measure in the index.html until I find a permanent solution. It is kinda weird that although i start foundation multiple times it is not triggered at all.

I think I can narrow it down now after some testing.
The issues lays in the ng-repeat function, in a directive of AngularJS. Somehow some functions load faster then others and block each other.
It happens with the Accordion and with the Dropdown Menu. Weirdly tabs don't have this problem. I even load $(document).foundation(); so often that i get a warning, that it is already loaded for some elements.
So it's probably like this:

directive is loaded
foundation is initialized
menu is generated through ng-repeat
thats it

Hope this can help clarify

@Saifadin Dunno if you nailed this down but perhaps you could trigger a function (which initialized Foundation) on the $last of ng-repeat ??

I solved this problem a week ago, when it came up, by writing that part as a directive and using the controller to call $document.foundation();
The controller of a directive is called when the directive is fully loaded, thats why it works. Took a while to solve ^^
Osamah Aldoaiss
Chief Editor Midaad, Frontend Developer, Designer
Bergfeldstr. 2
38122 Braunschweig
+49<PHONE_NUMBER>4
www.aldoaiss.de

On 25.06.2016, at 18:18, Joe Watkins<EMAIL_ADDRESS>wrote:
@Saifadin Dunno if you nailed this down but perhaps you could trigger a function (which initialized Foundation) on the $last of ng-repeat ??

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Saifadin can you please create a codepen of your working code. I am having the exact same issue and and can't seem to get it working. Thank you so much!

@Saifadin can you please create a codepen of your working code. I am having the exact same issue and and can't seem to get it working. Thank you so much!

@jmathur5 Sure, the final solution was, that I waited for document.ready and called it out of the controller.
See: http://codepen.io/Saifadin/pen/xqEZXO

Thank you!!!!! @Saifadin

Trying to figure out the state of this issue... it looks like the issue of overriding values was resolved, and the remaining issue was enabling foundation after an angular render, is that correct?  Can we close this?


ricci tensor simplification

Fixes #494
@ritzvik please review !!!

Please review. @ritzvik
Thank you

Looks good.
Merging :)


Add support for RTCP Extended Reports

Description
This patch adds baseline support for RTCP extended reports, as defined
in RFC 3611, including the baseline seven report block types it
describes. This patch also adds some introspection-based support
functions to provide semi-automated marshaling and unmarshaling of
arbitrary structures, and automated stringifying of Packet structures,
so as to greatly simplify adding the other 27 report types.
Reference issue
Fixes #8

Yeah, I see the uint64 errors on 32-bit architectures. It's going to take a little bit to figure out how to fix this.

@adamroach LGTM! I would put packebuffer in internal/packetbuffer.
The introspection is really cool, saves us lots on LoC. Do you think it works ok for the following cases?

Error handling. If something goes wrong do users get  errors they can quickly grep/jumpto for?
Security. Do you see any cases where crafted packets could cause a negative impact/cause introspection to get stuck?
Maintenance. Do you think the complexity will make users less likely to contribute in the future?
Learning. Do you think the code is a good resource for others to learn from?

If you think this is a good path for us to down is it worth migrating the other RTCP packets to packetbuffer ?

The way you handle padding is so cool, really great idea.
 	_              uint8

@adamroach LGTM! I would put packebuffer in internal/packetbuffer.

It's not clear how to do this: packet_buffer.go uses errors from errors.go; if I put it in github.com/pion/rtcp/internal, then I need to include that from extended_report.go, but I also need to include github.com/pion/rtcp from packet_buffer.go, at which point we have a circular dependency that upsets the compiler. I'm still new to go, so maybe there's a known working pattern that we can employ here, but it's not entirely obvious what that might be.

The introspection is really cool, saves us lots on LoC.

Thanks. when considering the really large catalog of Extended Report types, the prospect of doing manual marshaling and unmarshaling seemed incredibly daunting, which is why I chose this approach. (I also suspect this is part of why issue #8 remained open for so long.)

Do you think it works ok for the following cases?

Error handling. If something goes wrong do users get  errors they can quickly grep/jumpto for?

It depends on which audience you're talking about. For pion contributors adding new code that uses packetBuffer, there's there are two new errors that they might hit during development, and to any extent that the message isn't self-explanatory, they may have to look into the code a bit.
For developers using pion to write applications, there's really only one error they should ever see out of this code, and that's errWrongMarshalSize, which should be pretty self-explanatory.

Security. Do you see any cases where crafted packets could cause a negative impact/cause introspection to get stuck?

It seems really unlikely. The introspective parser uses the packet structure to drive its behavior, using the received bytes only as input. It's basically a recursive depth-first tree traversal, which is guaranteed to always complete. (The one exception is if someone defines a packet that contains a slice of a struct that in turn contains no members, but this would always cause an infinite loop, which would be caught at testing time -- it wouldn't make it into production code, and isn't dependent on the input data.)
Aside from that mechanism, the code is fundamentally copying bytes into values, the same way that manual unmarshling code does. It shouldn't be any more or less vulnerable to exploitation in that regard. (E.g., packets that specify a length field that goes beyond the end of the packet -- this introspection approach is somewhat better in that regard, insamuch as there are a small number of places that one needs to check for such an issue, and you can audit them by casual inspection. With manual demarshaling, you need to check every place that makes use of a length field to ensure that the subsequent operations don't run off the end of the buffer.)

Maintenance. Do you think the complexity will make users less likely to contribute in the future?

My hope is that the packetBuffer will make contribution of new RTCP formats easier and less complex. The process of writing code that manually places and manually retrieves values from a byte buffer is tedious and error-prone. With the availability of packetBuffer, this becomes the far more straightforward task of defining a struct with the right fields, and then using packetBuffer to implement marshaling and unmarshaling (which should be a fairly small amount of code). For those packets that implement things like bitfield packing, there's a bit more to it than that, but not by much (and certainly much less code than doing a full marshal/demarshal by hand).

Learning. Do you think the code is a good resource for others to learn from?

I'm really not sure. I'm still familiarizing myself with go idioms, and so there might be some approaches in this code that wouldn't be teaching folks the right habits. Maybe after it's had a few more eyes on it to verify that it's reasonably idiomatic, sure -- introspection is a powerful tool; and the reflect package documentation ranges from confusing to incomplete, so the code does at least have value in the context of "here's something that actually works."

If you think this is a good path for us to down is it worth migrating the other RTCP packets to packetbuffer? Or reflecting on the points above is handwritten code better. If we go with/without packetbuffer it doesn't have to happen in this commit. I am ok with merging this code today either way.

I think it's worth considering. I'll note that the current implementation doesn't include cases for strings, floats, or arrays, which you'd need for some of the existing RTCP packets. Those wouldn't be particularly tricky to add, but it's groundwork that would need to happen before porting other packet types over (or, at least, at the same time as doing so).
In terms of my own next steps -- this scratches a specific itch that I had (I need ReceiverReferenceTimeReportBlock and DLRRReportBlock so that I can calculate RTT for receive-only peer connections), but it was a fun exercise, and I'd like to prove out the approach (when I get some additional cycles) by adding the rest of the IANA-registered Extended Report report types. After that, if there's interest, I'll look at adding the types necessary to implement the rest of the RTCP packets with this approach.

@adamroach Thanks for the thoughtful response!
We could do a new errors.go in internal/packetbuffer. The package is so small right now I don't think it matters. I say merge it!
Would love to see everything migrated to packetbuffer eventually. I just worry about us falling into the Lava Flow trap where some packets will be terse (with your new system) and others will be verbose with unique bugs.
Really great work on this, really appreciate all the work you are putting in :)


Mark required fields in New Appointment/Edit Appointment

🚀 Feature Proposal
Mark required fields with the *.
The following fields are required:

Patient
Start Date
End Date

Labels have the ability to be marked as required: https://components.hospitalrun.io/?path=/story/label--label.
Motivation
Fields that are required should be marked as required so the user is aware that the field is required before saving.

can I take this?

I've assigned this to you @rubencgt


pg:copy Error:       undefined method `resource_name' for nil:NilClass (NoMethodError)

Similar to issue #1837, but the apparent resolution there will not work for me as my postgres databases do not appear to the have the "color" urls associated with them.
It may be that I just have the syntax wrong still.
I am trying to copy the database from one application to another. These are test apps - so I have not left them lying around. They were created with heroku apps:create and the hobby-dev postgres database addon.
Thanks.
 !    Heroku client internal error.
 !    Search for help at: https://help.heroku.com
 !    Or report a bug at: https://github.com/heroku/heroku/issues/new

    Error:       undefined method `resource_name' for nil:NilClass (NoMethodError)
    Command:     heroku pg:copy postgres://snzaiodracumwc:oDDjy9BV1z6D01LhOW6cLE2ayx@ec2-75-101-143-150.compute-1.amazonaws.com:5432/d6lto4o6njs2o2 postgres://yjzsyetqglxkeg:YdVTWhKCCNXEnTZYGrwXkDSIP5@ec2-75-101-143-150.compute-1.amazonaws.com:5432/d48et7sta7apr9 --app kubedapp2-tcdev-273 --confirm d48et7sta7apr9
    Plugins:     heroku-oauth
    Version:     heroku-toolbelt/3.42.25 (x86_64-darwin10.8.0) ruby/1.9.3
    Error ID:    3a0fcb375b5c413ca619d04b586a0809

Here is the stack trace from my CLI log:
Heroku client internal error.
undefined method `resource_name' for nil:NilClass
/Users/tcdev/.heroku/client/lib/heroku/client/heroku_postgresql.rb:39:in `resource_name'
/Users/tcdev/.heroku/client/lib/heroku/client/heroku_postgresql.rb:139:in `pg_copy'
/Users/tcdev/.heroku/client/lib/heroku/command/pg_backups.rb:48:in `copy'
/Users/tcdev/.heroku/client/lib/heroku/command.rb:212:in `run'
/Users/tcdev/.heroku/client/lib/heroku/cli.rb:30:in `start'
/usr/bin/heroku:24:in `<main>'

actually this usually means you have a ruby that isn't compiled right. Try reinstalling ruby and/or the toolbelt.


Why execution time increases?

Hi everybody, I'm working on OMOPSO algorithm and something strange happens: at the initial time there are a lot of it/s but when the execution time increases there is a decreases of the it/s. I'm working on a very power cpu with 32 core and I've set the multiprocessevaluator but it takes too long to finish. Is it the right behaviour? How cold I increase the execution speed?

Which problem are you solving and how have you configured OMOPSO?.
Just have into account that OMOPSO uses an external archive to store the non-dominated solutions found during the search. When that archive becomes full, a procedure to remove the worst solution (in the case of OMOPSO, an EpsilonDominanceComparator is used) is applied. If the archive size is large, this can take time; furthermore, this is a sequential step, so adding more cores will not help.

Which problem are you solving and how have you configured OMOPSO?.
Just have into account that OMOPSO uses an external archive to store the non-dominated solutions found during the search. When that archive becomes full, a procedure to remove the worst solution (in the case of OMOPSO, an EpsilonDominanceComparator is used) is applied. If the archive size is large, this can take time; furthermore, this is a sequential step, so adding more cores will not help.

I'm trying to estimate parameters for an epidemiologica compartment model. I've used the configuration present in the documentation, just changing swarm size( in order to keep it between 5 times and 10 times the dimensionality of my problem) and changing the number of iteration. The epsilon value suggested is epsilon=0.0075, maybe I could divide it by 10 in order to keep the archive small?

I'm trying to estimate parameters for an epidemiologica compartment model. I've used the configuration present in the documentation, just changing swarm size( in order to keep it between 5 times and 10 times the dimensionality of my problem) and changing the number of iteration. The epsilon value suggested is epsilon=0.0075, maybe I could divide it by 10 in order to keep the archive small?

Have you checked the size of the archive using that epsilon value?

Have you checked the size of the archive using that epsilon value?

algorithm = OMOPSO(     problem=problem,     swarm_size=swarm_size,     epsilon=0.0075,     uniform_mutation=UniformMutation(probability=mutation_probability, perturbation=0.5),     non_uniform_mutation=NonUniformMutation(mutation_probability, perturbation=0.5,                                             max_iterations=int(max_evaluations / swarm_size)),     leaders=CrowdingDistanceArchive(100),     termination_criterion=StoppingByEvaluations(max=max_evaluations) )
This is the code that I run, how can I check the size of the archive?

algorithm = OMOPSO(     problem=problem,     swarm_size=swarm_size,     epsilon=0.0075,     uniform_mutation=UniformMutation(probability=mutation_probability, perturbation=0.5),     non_uniform_mutation=NonUniformMutation(mutation_probability, perturbation=0.5,                                             max_iterations=int(max_evaluations / swarm_size)),     leaders=CrowdingDistanceArchive(100),     termination_criterion=StoppingByEvaluations(max=max_evaluations) )
This is the code that I run, how can I check the size of the archive?

The size of the leaders archive is 100, so it seems ok. Have you tried SMPSO instead of OMOPSO?

The size of the leaders archive is 100, so it seems ok. Have you tried SMPSO instead of OMOPSO?

no, which are the main differences?

no, which are the main differences?

SMPSO is based on OMOPSO, but it does not use epsilon dominance (https://ieeexplore.ieee.org/document/4938830). It can produce more accurate fronts than OMOPSO when dealing with multi-frontal problems (as, for example, ZDT4).

SMPSO is based on OMOPSO, but it does not use epsilon dominance (https://ieeexplore.ieee.org/document/4938830). It can produce more accurate fronts than OMOPSO when dealing with multi-frontal problems (as, for example, ZDT4).

Ok, thanks. I'll try it.

Ok, thanks. I'll try it.


AuthInfo is an encoded token

How to fix this error
"The "your" value in an AuthInfo is an encoded token that must not appear for the "Digest" scheme and must not be followed by additional parameters"

Are you copying and pasting the following as is into the command window?
setenv("OPENAI_API_KEY","your API key here")
Please replace "your API key here" with your actual API key.

Thank you.
On Fri, Apr 14, 2023 at 11:11 AM Toshiaki Takeuchi @.***>
wrote:

Closed #7 https://github.com/toshiakit/MatGPT/issues/7 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/toshiakit/MatGPT/issues/7#event-9008888608, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANIPJAA576KTJ6L67I27G63XBFSKXANCNFSM6AAAAAAW6AXANI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
BR
Hatem Enaami


Avoid NPE if broker yet not started

make listConnectedClients method safe for all broker states
Formaly, there is nothing to restrict one to call clients listing (server.listConnectedClients()) immediatelly after constructing instance using new Server();. In this case caller will get NulPointerException which may ruin the runtime.
This PR fixes that.

I've make changes in code in accordance to your suggestions in the code review.

Entirely agree. Commited.


Two charts screw each other up in Internet Explorer

I've got a page with a bar chart and a line chart that need to get updated frequently. However, the first time I destroy and recreate the charts, the bar chart's tooltips stop working and the bars are also not painted with the right values. The line chart seems to work fine.
I've found that this only occurs in Internet Explorer. Oddly, no errors show up on the console, so perhaps I'm using the library wrong or IE handles something differently. Here's a fiddle that illustrates the issue. Run it, and use the 'Refresh Charts' button to destroy and recreate both charts. Notice everything works fine in Chrome and Firefox. In IE11, the issue occurs. I'm on the latest version of IE11: 11.0.9600.18125
https://jsfiddle.net/ftqy0Lzb/5/

Interesting issue. I can replicate the IE11 but not in edge. I tried taking out the call to creating the line chart and it worked fine.
I turned off animations for the bar chart and it also worked fine. It must be something in the animation system. @tannerlinsley any thoughts?

Other than an internal issue in Inteenet explorer, I can't see or think of anything that would cause this

I had the same issue. I tried to diagnose but it is deep in Chart.js.
The only workaround I found is to disable the animation.
Chart.defaults.global.animation.duration = 0;

Retested this with the latest from the v2.0-dev branch, Works fine on IE 11.162.10586.0
Updated fiddle: https://jsfiddle.net/qtrsr82j/


Roku: inconsistent placeholder art being used within the app

Moved from https://github.com/plexinc/konvergo/issues/396
Device: Roku (dev kit)
Current behavior: Placeholder art design is different for songs and artists. Additionally, playlist cover art is completely blank.

moved to the other roku repo.


Fix import

Disclaimer: I've been doing iOS for a grand total of three days and I'm really, really bad at it.
Having installed EZAudio with cocoapods, this line was failing with 'EZAudioPlot.h' file not found. Upon changing it from #import "EZAudioPlot.h" to #import "EZAudio/EZAudioPlot.h", it builds fine.

Thanks!

Thank you, @zhxnlai!