Add replica cluster support

Hi!
I have made a few modifications to Cluster class to enable the support for replication cluster (which is intended to solve: https://github.com/luin/ioredis/issues/387).
I tried it in a project which I have a Redis cluster setup which doesn't use sharding but replication (master-slave full replicas) and it seems to work properly.
I would very much appreciate feedback about this feature and my resolution and I hope this branch gets merged some day so that we can all benefit from it and gets maintained.

Thank you for the pull request! Could you give us more details of which problem this pr is intended to solve? I revisited #387 but read-write splitting is already supported in the Cluster mode.

The problem is with read-write splitting in Cluster mode with replication (not with sharded clusters, nor sentinel). When in cluster mode, it always tries to search for a slot to which a command has to be sent, and if the cluster is a replication one (not sharding), it fails because all slots are in all nodes.

The problem is with read-write splitting in Cluster mode with replication (not with sharded clusters, nor sentinel). When in cluster mode, it always tries to search for a slot to which a command has to be sent, and if the cluster is a replication one (not sharding), it fails because all slots are in all nodes.

Its not a cluster - its a replicated single machine setup. Master - Slave, which should use sentinel for monitoring and automatic failover. It seems there is confusion over a cluster and sentinel.
@mvaker what you are referring to is a sentinel based setup (should be)

Hello! Thanks for your early comments.
It is not a Sentinel based setup, we are using this setup (cluster mode dissbled):
http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/Replication.Redis-RedisCluster.html
http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/AutoFailover.html
It does pretty much the same as sentinel but amazon provides it all itself (failover, monitor, etc). So it's a redis cluster without sharding (or with all shards in the same node), but since it's elasticache it's not sentinel based.
I have not tried the sentinel client here, but I understand it won't work either because no sentinel commands are available.
I think that the best approach is to use the cluster mode to keep track of existing nodes and connection pool, while sending reads to random reader (slave) instances.
Thank you!

BTW my resolution in this PR is a little bit "dirty" and I know this can probably be done better (maybe a separate class or client..). It was just a quick approach to see if it worked and hear what are your thoughts about it.

Hi, any thoughts on this? Have you checked my last comments? I would appreciate very much any comments. Thank you.

Would love to see that. Don't need sentinel and no cluster. Just read-only slaves for 90% of the load but need to get the 10% writes to the master @luin
My usecase: frontend nodes are too far away for cluster, so latency is high. Solution: have a slave per frontend-instance and speed up the whole thing for reads.

This is a much needed feature! The AWS non-clustered approach is much better for write heavy workflows than clustering because AWS only supports on-the-fly resizing for non-clustered Redis.

@mvaker You should probably rename this PR to "Add AWS non-clustered replication support" for clarity. This is not clustering.

hi @luin, I would like to discuss again this PR, so clearly this is a missing feature in this library and other people have proved it being useful for them. Thanks a lot!

Sorry for the late response. I've been thinking about whether this feature should be in a separate module since ioredis is focused on the official Redis features instead of the platform-specified ones.

@luin The problem is the assumption that either Sentinel or Cluster mode are used if replication is used. Redis supports replication without Sentinel or Cluster mode but ioredis does not and therefore does not support read/write splitting for the following 3 use cases:

Vanilla Redis without Sentinel but with master/slave replication (which is perfectly valid for read heavy workloads)
Redis Enterprise
AWS ElastiCache in non-cluster mode
While I haven't looked into the contents of the PR, I think the feature is well within the scope of scenarios ioredis should support natively.

This is particularly useful if you just have heavy read or pub/sub flow on a local machine and need more cores to process the subscriptions.

@mvaker I said you should probably rename this PR to "Add AWS non-clustered replication support" but I think that is misleading, my fault. Instead, "Add support for non-clustered replication without Sentinel" is probably more accurate. While AWS is a use case, there are other use cases where this PR is quite useful. @STRML just brought up yet another use case.
@luin I use Redis Enterprise and ioredis (hosted on AWS lol). At some point, I am going to have more read traffic on a single key than a single shard in Redis Enterprise can handle. So adding another shard to the Redis Enterprise cluster will not help. I will have to create a read replica of the cluster so the same key is stored on different shards. The replication is managed by Redis Enterprise, not Sentinel. Having ioredis support this natively would be very nice :)

Hey @luin, what's your current feeling about this pull request? Do you think it will get merged into the source eventually or are you rather inclined towards the separate modules solution?
We are currently stuck with a cluster that is not managed by sentinel and need to use read/write splitting quite soon. If this pull request might get merged soon, we would like to use the introduced feature. Otherwise we will have to split reading and writing manually by using different clients.

Any news?

 That way, the adapter doesn't have to know anything (this logic is brittle, particularly in regards to reconnects).

Is there any chance that these use-case described in this issue will be one day supported ?
This redis chart https://github.com/helm/charts/tree/master/stable/redis also support replication cluster.
https://redis.io/topics/replication


[Translate] RU

I made a Russian translation. Please include it with the next version of the module.
ru.json

Thanks! Added in v0.9.3.


DitherFade material layer causes serious artifact with forward rendering / MSAA

Enable forward shading by check the Forward Shading box under Edit -> Project Settings -> Engine - Rendering -> Forward Renderer.
Change "Anti-Aliasing Method" to "Multisample Anti-Aliasing (MSAA)" under Edit -> Project Settings -> Engine - Rendering -> DEfault Settings)

You'll see serious dithering artifacts in all Cesium objects, while objects that user other materials look fine:

Deleting the DitherFade layer from our default material fixes the problem. We're using an engine-provided material node that is meant for temporal AA, but it's not clear why it fails so badly with MSAA.
Originally reported on the forum:
https://community.cesium.com/t/forward-rendering-msaa-black-squares-and-dithering-artifacts-on-terrain/24149

#1414 doesn't address this. I think that it has to do with the fact that the "DitherTemporal AA" node that we use, doesn't have good defaults when Temporal AA isn't enabled. So it's stuck on a permanent dither pattern. You can actually kind of see that pattern in the material function preview:

We could possibly account for the current AA mode by querying it, and passing a flag into the material indicating whether or not to use dithering. But because the user could possibly change it, we'd need to constantly check for updates to that setting. So something like this (taken from RendererScene.cpp):
static auto* CVarAntiAliasingMethod = IConsoleManager::Get().FindTConsoleVariableDataInt(TEXT("r.AntiAliasingMethod"));
static int32 CachedAntiAliasingMethod = CVarAntiAliasingMethod->GetValueOnGameThread();
const int32 AntiAliasingMethod = CVarAntiAliasingMethod->GetValueOnGameThread();
if (AntiAliasingMethod != CachedAntiAliasingMethod) {
     // ...
}

But I'm concerned about doing it this way because it seems like things can commonly override the project's default AA method? From SceneView.cpp:
// see EAntiAliasingMethod
static TAutoConsoleVariable<int32> CVarDefaultAntiAliasing(
	TEXT("r.AntiAliasingMethod"),
	4,
	TEXT("Engine default (project setting) for AntiAliasingMethod is (postprocess volume/camera/game setting still can override)\n")
	TEXT(" 0: off (no anti-aliasing)\n")
	TEXT(" 1: Fast Approximate Anti-Aliasing (FXAA)\n")
	TEXT(" 2: Temporal Anti-Aliasing (TAA)\n")
	TEXT(" 3: Multisample Anti-Aliasing (MSAA, Only available on the desktop forward renderer)\n")
	TEXT(" 4: Temporal Super-Resolution (TSR, Default)"),
	ECVF_RenderThreadSafe);

And I can't really tell where a post process volume / camera / game setting override would make a difference, but it does make me nervous to try and make this change.
I think a better change instead would be a UseLODTransitions parameter, and set it to 1 for Enable LOD Transitions = true, 0 otherwise. So people who don't use LOD transitions at all won't even have to worry about this material layer. As long as people keep this setting disabled, changing the AA mode won't make a difference. If they try to enable LOD transitions for a non-temporal AA mode, then that's moreso user error.


Add ncPTX topos + ci-trigger

Also update size of instances for ci-trigger to reflect new ixia cpu requirements: https://github.com/openconfig/kne/pull/428

Pull Request Functional Test Report for #2189 / b3fc0501ad29189a9ad30f8840625ec9effd6b15
No tests identified for validation.
Help

This SGTM except for the go fmt error.


MultiOgar Binary!

noice

Tell me when you're done, I can merge it for you

@AlexandriteErikParacelsus I finished when I opened the pull request XD

@Tyler3D What's in the file? Is it just src compressed into an exe?

@Megabyte918 And the modules

@Megabyte918 I tested it. It works

@Tyler3D This is a good idea and its convenient and all... but theres a lot of problems with it.
1.) You can't edit configs, since gameserver.ini is located within the exe
2.) It will have to stay constantly updated, since theres so many commits and updates all the time, I will have to download and re-compress the newest version into an exe, or else whoever decides to run it with the exe will be using an outdated version.
3.) It takes away from the point of having a repo. Why have a repo when you can just compress the whole thing to an exe? Then it becomes less open-source, people can't edit files as they please, and theres basically no point in going to the repo in the first place if you can just download and run the exe.
4.) People who make tutorials and other videos such as those on how to make private servers can just download and distribute the exe file to their viewers, rather than link the repo. People won't know this repo exists if theres an exe going around, this could also lead to some malicious software being distributed.


Release 23.4.0

Can you please release 23.4.0 or outline what PRs are needed?

We are working on this.  It's undergoing our QA process right now and will be released if it passes without any known issues.
In the meantime, 23.4.0-beta1 packages are the exact same ones undergoing QA and will likely be identical to what we release, so feel free to use them!


Broadcast changes to clients

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@sumantfordev You need to fill out the Issue template, not just the title.


Calendar years instead of "year ended"

The column names in the annual financial statements (the years) are occasionally off. For example, ticker DPZ filed their 10K for fiscal year 2020 on Jan 3, 2021 (see here; their fiscal year end is the Sunday closest to Dec 31). This results in 2020 data being reported as 2021. Same thing for the following year.
In financial_statements.py, date = value['date'][:4] could be replaced with date = value['calendarYear'] in all three functions, and this would solve the issue. In this case I would also recommend not deleting date — del value['date'] — since the user might also be interested in the fiscal year end date.
Lastly, and maybe this should be a separate issue, it seems unintuitive to have the year columns represented as a string instead of an integer. Wrapping the suggestion above in int() is an easy fix.
Figured I would mention these here in case I am missing something, but I'm happy to create a pull request if there are no objections.

Hi @van-alfen, unfortunately I have no time to work on this myself so feel free to PR! It makes sense what you are saying, I believe at the time I created the package there was no calendarYear value.


Speed tags are not resolved in HistoryRow

As shown below.

https://github.com/coppolaemilio/dialogic/pull/1341

https://github.com/coppolaemilio/dialogic/pull/1344

Merged it in! Thanks alot for the contribution!


feat: add b256<->u256 from impls

converting hash types to u256 is incredibly annoying.
ethereum-types solved this via a BigendianHash trait
https://github.com/paritytech/parity-common/blob/27b17c0d5d32ebf384dd4b535d9045598904519d/ethereum-types/src/hash.rs#L18
however, I really would like to have From impls instead, so you don't have to do.
U256::from_be_bytes(b256.0) or U256::from_be_bytes(b256.to_fixed_bytes())

From impl looks better


Remove TypeResolver

I added it while writing the refactoring, but now it's just a dumb alias that brings nothing to the game.

Please make a comment here if you intend to work on this issue. Thank you!

Fixed in #91.


Upgrade underscore.string to fix vulnerability

The warning info: https://www.npmjs.com/advisories/745/versions

We're not using unescapeHTML so we're fine but I'll land and release this in a patch version


How to toggle field based on options selected.

I have three radio buttons based on ENUM with options from 1 to 3. When the radio button option is clicked i need the value updating in a textbox Score according to:
Score textbox vlaue = ENUM1 * ENUM2 * ENUM3
When Score is over 8 want to make it visible :
this.form.ExtraDesc.getGridField().toggle(true);
I have done this in afterLoadEntity:
var mScore: number;
mScore = (i * j * k);
this.form.Score.value = mScore;
But doesn't work dynamically, have to save it first.
I tried making a function updateScore in EditDialog calling it when radio buttons are changed but it didn't work.

you can put function  updateScore in ondialogopen


Feature/resume from tablemap pos

This is the bug fix to prevent resuming without table_map event. When the process is down during middle of multiple row events, kodama will resume from the position of row event, which causes missing table map error.
To avoid this, the position file is saved only at the following checkpoints in this change.

Next position of QueryEvent
Position at RotateEvent
Position at TableMapEvent

Also I introduced "processed position file" which stores the latest processed event position(only necessary events) and is used for preventing processing processed events when resuming.
To use this feature, Kodama::Client#processed_binlog_position_file needs to be set in start method block. As for compatibility, since this option is optional, kodama will work with old implementation.
Kodama::Client.start(:host => 'localhost', :username => 'root') do |c|
  c.binlog_position_file = 'position.log'
  # Set processed position file path here
  c.processed_binlog_position_file = 'processed_position.log'

  c.on_row_event do |event|
    worker.perform(event)
  end
end

Looks good!

FYI: I made change along with our discussion

Rename "processed" with "sent" for all api and variables for the convenience
Refactored process_event method no to use "case+when" statement twice. Instead, I added "if processable" statement for each "when" block.
Call callback on rotate even during resuming. It is because we're using on_rotate event to get the binlog position.


build: add rust-toolchain file

This file will specify the current nightly version we are targeting and hopefully reduce the number of times we have to point people to use the correct compiler version. The shell.nix was updated to use this file. I have used the old format of rust-toolchain since the new TOML format is currently not supported by the rust nix overlay that we use in shell.nix.

AFAICT this is the current version we use in CI.

Works on my nix box. I am all for this as it reduces the barriers for external contributors.

So compiles everything with the nightly compiler?
This is a changing behavior of the current way of building.

Agreed, we probably need to settle on some standard for this. FWIW I'm in favor of just using one toolchain, i.e. either stable with RUSTC_BOOSTRAP hack, or just use nightly for everything.

This file would also not be automatically changed when we add a new CI image.
Imo we should find a proper way on how we track the rust version entirely in git, aka dropping the installation of rust in the CI image for example and not start adding more and more locations that are loosely coupled.

Ideally the CI image would just read from this file (or some other file that comes from the repo). As an optimization the CI image could have the latest version already downloaded, but when this file changes it should download it always (until the image gets updated).
I will close this for now.

Ideally the CI image would just read from this file (or some other file that comes from the repo).

That already worked with your change here.
I think we may could directly remove rust from the image. AFAIK all gha jobs also download rust in every run.

Can substrate build on stable rust? I don't know why wasm-builder require a nightly version.
https://github.com/paritytech/substrate/tree/master/utils/wasm-builder

See the tracking issue: https://github.com/paritytech/substrate/issues/1252


Create Tolgee CLI

Create CLI which should:

[ ] Export data from Tolgee to specific dir
[ ] Import data to Tolgee using Import endpoints
[ ] Analyse code for unused keys / keys missing in Tolgee

I guess this one can be closed now https://github.com/tolgee/tolgee-cli exists :)

It still doesn't export the data and it's not published in npm, so I wouldn't close it yet. :)

Hey I would like to work on this feature.
Reference : Aviyel
Could you please assign it to me
Thanx

Hi there! Actually, there is a Repo for that, which is already prepared for further work! If you would like to dig in, I can create some issues there.
https://github.com/tolgee/tolgee-cli

Comment there, and I can assign some to you.
https://github.com/tolgee/tolgee-cli/issues

It's done in separate repo.


Keep track of initial options in compiled program

This allows us to fix an issue where searching via firstMatch or matches(of:) would only start searches at a character index, even when a regex has Unicode scalar semantics.

@swift-ci Please test


README issue

Index works fine without README or HEAD
after adding both or either one of them, it keeps loading and doesnt work
it was fine few days ago
plz fix it

If it doesn't contain any sensitive data, could you share the link to the index(live version)?
and also, please provide me the worker code without these(any sensitive) values: [client_id, client_secret,  refresh token, crypt password, and root ids]
I just want to review your settings. You can use https://gist.github.com to share your worker code

I think the issue is when navigating to root /0:/  the site now, It will stuck on loading It wont load, also rendering of HEAD & README, It doesn't work now.
V1.4.0

Fixed!
Please use the latest index.js file.
The problem was occurred due to the changes in the library used for rendering markdown: https://github.com/markedjs/marked/releases/tag/v4.0.0

Fixed!
Please use the latest index.js file.
The problem was occurred due to the changes in the library used for rendering markdown: https://github.com/markedjs/marked/releases/tag/v4.0.0

I tested it in v1.4.1 and its fixed.
@cheems could you please add icons to todo list 😁


Add statement metadata to event payloads (MySQL)

What does this PR do?

Add metadata about a SQL statement in the event payloads. More information regarding these changes can be found in the agent PR.
Agent: https://github.com/DataDog/datadog-agent/pull/10042
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Closed in favor of a simplified approach: https://github.com/DataDog/integrations-core/pull/10880


Fixed issue in Elfsquad Data connector

"Swagger and Change Validation" failed, but this is intentional. We are still in the process of testing and validating the connector.


Add latex .tex icons

Latex extension has over 1.5M installs. I would love to see vscode honor .tex files with icons.

Closing based on https://github.com/Microsoft/vscode/issues/60699#issuecomment-429208011


Close tab/disconnect any player = Crash server

Video: Sorry lag ;D
https://streamable.com/x2mbr

@DeadLord1337 #492 (comment)

@DeadLord1337 https://github.com/Megabyte918/MultiOgar-Edited/issues/492#issuecomment-277460015

thx


Document etcd troubleshooting steps

Etcd is required to be up and running for both CloudFoundry and Kubernetes.  Occasionally during upgrades Etcd will lose consensus across the cluster.  In order to restore service in a timely fashion, we should document how to efficiently restore the cluster.
Acceptance Criteria:
As a operations team member, we can refer to documentation which describes:

[ ] Restore etcd from a specific node with a known good version
[ ] Join other nodes to the node with known good data
[x] Initialize entire cluster

To reset an entire cluster to a known good state you can do the following:
Run monit stop etcd on all cluster members.
Then run export DIR=/var/vcap/store/etcd && rm -fr  $DIR && mkdir $DIR && chown vcap:vcap $DIR && chmod 755 $DIR && monit start etcd on each cluster member (one at a time, in order).

So is that all we need, or does this need to be captured somewhere else/account for other scenarios?

That's how to reset etcd to a blank state, if we need to restore data you'd follow the upstream documentation: https://coreos.com/etcd/docs/latest/admin_guide.html#disaster-recovery (which I've verified works in the etcd bosh deployment).  If we want to update our docs somewhere to link to those etcd docs, I'm happy to do so.

It sounds like that's all we'd have to do to mark this one complete... Is that right?


fix: args issue in init of App class (#3140)

Remove passing *args to base __init__() in App.
Remove *args from signature.
Details in related issue.

(fix): remove '*args' from 'init()' method of 'App', update docstrings and .pyi accordingly

All Submissions:

[x] Have you followed the guidelines stated in CONTRIBUTING.md file?
[x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

New Feature Submission:

[x] Does your submission pass the tests?
[x] Have you linted your code locally prior to submission?

Changes To Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

@masenf
And thanks to you for making such a great framework!


support for fetch !!

Is there any global feature in fetch which can be executed after any response arrived .

No, there is not a callback nor an event you can subscribe to equivalent to jQuery's global ajaxComplete. I personally find this to be a big ommision of the fetch spec. But, if you have such a feature idea, you should search for existing discussions or open a new one in the official repository, rather than here. Thanks!


Remove obsolete version string from compose yamls

Description

Avoids warning when executing docker compose commands

Closes #1771
By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

/merge


plugins/tmux-navigator: port to mkVimPlugin & update available options

This PR ports tmux-navigator to the new mkVimPlugin system and adds missing options.
The option documentation was re-written using the docs in upstream's README.
I have some questions on the best way to approach some stuff:

Is there a way to add additional documentation to the actual plugin module?

It'd be useful to document that tmux keybinds need to be configured separately.
Or possibly include actually how to do this?

What type should save_on_switch use?

Is there a way to map better named enum values to 1 & 2?
Is this even desired?

Should I add myself to maintainers?

You will need to format your code by running nix fmt

Ok for me.
I'll let @traxys proof-read as he'll have an external look.


Make dat sync consistent with other commands

The dat <link> <dest> is extremely useful when dealing with dats on servers since it is idempotent, but noticed we haven't documented it anywhere
Either we should document it or make sync do the same thing.
Currently the documented approaches forces you to clone first which disables upload and implies that you know what state the dat was in before you ran the command, which is tricky when you just wanna automate syncing

I'd suggest, we change it to do the following:

Have dat sync behave exactly as dat <link>
Have dat clone be the same as dat sync but exit once done
Have dat pull be the same as dat sync but exit once done and fail if the dat is not there

Introduce --no-upload and --no-download to disable upload and download.

Definitely need to document dat <link> <dest> and dat <dir>! I'll add that to the usage now. Still in the process of updating readme docs but I'll put that on the list.

I'd suggest, we change it to do the following:

Have dat sync behave exactly as dat <link>
Have dat clone be the same as dat sync but exit once done, and fail if it cannot find peers
Have dat pull be the same as dat sync but exit once done, fail if it cannot find peers, and fail if the dat is not there

Sounds good! This is how it's supposed to work, are these commands not doing that?

Introduce --no-upload and --no-download to disable upload and download.

I turned on the --upload option in clone and pull to fix #783. But I can make these global options. We should separate out the announce from upload as well (https://github.com/datproject/dat-node/issues/150)

Both clone and pull should call .leave on discovery-swarm when done as well to announce from the disc network

I can add this, but not quite sure what this means =).

i cannot run "dat sync  " if i havent cloned the dat

tldr; dat sync needs to run share/create directly.
We can probably get rid of the src/commands/sync.js totally. It'd help make options more consistent.

Currently the documented approaches forces you to clone first which disables upload

dat clone --help
Clone a remote Dat archive

Usage: dat clone <link> [download-folder]
    --dir, -d             set the directory for Dat
    --port                port to use for connections (default: 3282)
    --utp                 use utp for discovery (default: true)
    --http                serve dat over http (default port: 8080)
    --sparse              download only requested data (default: false)
    --up                  throttle upload bandwidth (1024, 1kb, 2mb, etc.)
    --down                throttle download bandwidth (1024, 1kb, 2mb, etc.)
    --empty               Do not download files by default. Files must be synced manually. (default: false)
    --upload              announce your address on link (improves connection capability) and upload data to other downloaders. (default: true)
    --show-key, -k        print out the dat key (default: false)

It seems it says that --upload is on by default?

This will be fixed by #1173


[DX] warn if netlify.toml has "function" instead of "functions"

- Do you want to request a feature or report a bug?
feature
as above
found in @DavidWells' workshop

+1 Might get slightly complex with all of the different contexts.

Closing as stale


Update deprecated calls

Travis builds are failing:

Now fine, PHP 5.3 failures are #654

Maybe is it an idea to combine #654 en this PR in one PR to get functional tests?

@tvbeek  Agreed. @kylekatarnls please merge my changes from the PR into yours and then let's merge this one.

OK, I will make #654 pass all tests (actually it fails due to strlen bug in PHP 5.3) then I will merge it here and close #654.


Is there a way to manually add DLC or games without the manager deleting it?

I want to add some of the unobtainable payday 2 dlcs but every i add it to Applist, and run greenluma it ends up just deleting that file. I can't use normal greenluma cause it keeps on saying "CreateProcess error" so i have to rely on this. Please help

The manager's profiles are stored in %localappdata%\GLR_Manager\Profiles, you can add the extra DLCs to the list there


Document the use of  vscode-nls with webpack

The point of difficulty is in-code use of localize for constructing localised messages.
The question has been raised on Stack Overflow but here are some more details.
In the absence of webpack a trace into this call
const localize = nls.config({ messageFormat: nls.MessageFormat.file })();

reveals that the loader passes a filepath to loadMessageBundle(file)
With webpack this the parameter is undefined. The consequence of this is that things are initialised differently, so a different method is called when I invoke localize, and the default value (the second string parameter passed to localize) is always returned.
Breakpointing the start of loadMessageBundle(file) in an extension that is not bundled (the vscode-nls sample) allows a look at the call stack. The call stack eventually disappears into helper.js inside node.
With webpack in play, the value of this parameter is undefined.
I suspect the problem is that the files generated into the out folder by gulp build are not bundled. They don't even exist in the source so they can't be referenced statically. I have no idea how to convince webpack to include them, or whether this is the whole of the problem.

We should add an example demonstrating how this works.

vscode-nls is deprecated in favor of http://github.com/microsoft/vscode-l10n so closing this.


We have to renumber Articles to match IDs on OldCantus

On OldCantus, we have an article at /article/712586. The same article has url /article/36 on NewCantus. So, in general, article url's copied from OldCantus don't seem like they will resolve correctly.

Yes, you can ask Marisa or you can do them yourself.
Thank you.
On Jun 7, 2023, at 05:42, Jacob deGroot-Maggetti @.***> wrote:

When I set up the articles app about a year ago, I remember it being decided that we would not preserve article ids from OldCantus to New. @fujinagahttps://github.com/fujinaga, would you like me/someone to go through and manually renumber these, for backwards compatibility? There are about 40 of them.
—
Reply to this email directly, view it on GitHubhttps://github.com/DDMAL/CantusDB/issues/675#issuecomment-1579419338, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH342KNEUVT3LSIDOB4NADXJ6I2TANCNFSM6AAAAAAYXIEIAQ.
You are receiving this because you were mentioned.Message ID: @.***>

Now that we have /node/ redirects set up, we need to attend to this.

I finished this yesterday! Articles are properly renumbered on both staging and production!


Extend tests/arch/arm test suite to Cortex-A and Cortex-R

Is your enhancement proposal related to a problem? Please describe.
tests/arch/arm test suite family verifies ARCH code for the ARM Cortex-M architecture. Some of the tests are specific
to Cortex-M features, while other tests are more generic and should be extended, to cover the remaining Cortex-R and
Cortex-A supported architectures.
Describe the solution you'd like

tests/arch/arm/arm_thread_swap
tests/arch/arm/arm_interrupt
tests/arch/arm/arm_irq_vector_table

should be extended (with possible re-design or code duplication) to verify these features in Cortex-R and Cortex-A.

Why is this medium priority?


Fix block_svg for firefox

getBBox does not work with hidden elements in Firefox. https://bugzilla.mozilla.org/show_bug.cgi?id=528969
This is a targeted fix to fix https://studio.code.org/s/coursec-2019/stage/16/puzzle/6, but we should probably look into whether this is causing more widespread issues with Blockly labs on Firefox

do we need to do something manual to bump blockly to 3.5.8? i see we're pulling that version into code-dot-org, but i'm not sure how that version gets published

I ran npm version patch from the master branch of blockly locally, which created https://github.com/code-dot-org/blockly/commit/4250a4249c64037b8f1f4e95346f17cfd09e0a96


Paste Event button next to + Add Event

Sometimes you have to past but there is no event to paste before/after so a paste event button would be making things much easier

Hi @morphoice If you hold "Alt" ("Option" on Mac), the "Add Event" button becomes a "Paste Event" button. Does this do what you need?

brilliant, thank you!


[BUG] Error when downloading cqlsh via astra-cli

Describe the bug
Attempting to access an astra database via cqlsh, via the astra-cli, fails with an error message, and doesn't start the session.
To Reproduce
Steps to reproduce the behavior:

Install astra-cli according to: https://awesome-astra.github.io/docs/pages/astra/astra-cli/#12-installation-on-linux
Run astra setup and provide valid application token
Running astra db cqlsh db_name leads to error:

[ERROR] INTERNAL_ERROR: Error in HTTP Request: HttpEntity

Expected behavior
Similar output as shown in https://awesome-astra.github.io/docs/pages/astra/astra-cli/#38-cqlsh
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.59
MSRDC version: 1.2.4677
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.2715
Additional context
Add any other context about the problem here.

Upon further investigation, it seems access to the cql shell is not possible via clientId and token anymore. It's either clientId and clientSecret (which astra-cli does not use), or just the token, with a user called 'token'.
Tested by running the cqlsh binary installed by astra-cli (~/.astra/cqlsh-astra/bin/cqlsh) with these two authentication methods.


No mobile view for iPhone 6s

The responsiveness of the sidemenu layout works great on desktops, but on iPhone or when using the developer tools in chrome smaller mobile views are not displayed as mobile but as normal desktop views with a viewport width of 960px.
I have the problem in my app and in the online demo app. here is screenshot of an iPhone 6s:

I could fix that issue by adding the annotation line
@Viewport("user-scalable=no,initial-scale=1.0")
to my UI class.

Looks like the @Viewport annotation did not work the way I thought it would. But yes, that's the annotation I should have in the UI as well. Need to test and fix it this weekend.


The default recipe creates a group using the user value

Looking at the default recipe, when creating the system group for logstash it uses the user value instead of the group:
roup 'logstash group' do
  group_name node['logstash']['user']
  action :create
  system true
end

Should be:
roup 'logstash group' do
  group_name node['logstash']['group']
  action :create
  system true
end

And I just want to say thank you for this cookbook, I tried a bunch of others and they were so complicated to use, this one has helped me a lot to get started!

Fix in 0.2.2


Adding support for RFC3339 dates with only the date part

RFC 3399 does not exist. RFC 3339 is the one used here: https://tools.ietf.org/html/rfc3339

@wolpi Thanky you! You could vote the JIRA if interested :)
The tests are in this file:
https://github.com/andrea-ligios/struts/blob/d95fc63992f3892519d970b07052776e0401003a/core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java
The test could be added in the testDateConversion() method, the code should be:
Date dateRfc3339 = (Date) converter.convertValue(context, null, null, null, "2001-01-10", Date.class);
assertEquals(date, dateRfc3339);

Could you add it to that file ? I'm just new to the whole thing (Git, GitHub, etc...). Thanks


Shadows not rendered correctly

Hi,
I have an issue where subviews with a layer.shadowPath are not rendered correctly during snapshot testing but work fine when running the app. This results in all snapshot reference images not having proper shadows. Here is a sample project that reproduces it
This is the expected view controller when I run the app:

And this is the snapshot created by a SnapshotTesting

I have a ShadowView that adds a content view as a subview and a shadowContainer view used to cast the shadow:
import UIKit
import Foundation

public struct Shadow {
    let x: CGFloat
    let y: CGFloat
    let blur: CGFloat
    let spread: CGFloat
    let opacity: CGFloat

    public static var shadow8: Shadow {
        return Shadow(
            x: 2,
            y: 2,
            blur: 0,
            spread: 0,
            opacity: 1
        )
    }
}

public final class ShadowView: UIView {
    private let shadowContainer = UIView()
    private let content: UIView
    private let shadow: Shadow

    public init(shadow: Shadow = .shadow8, content: UIView) {
        self.content = content
        self.shadow = shadow
        super.init(frame: .zero)
        backgroundColor = .clear
        setupLayout(shadow)
        setupTheme()
        setupShadow(shadow)
    }

    @available(*, unavailable)
    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }

    private func setupLayout(_ shadow: Shadow) {
        addSubview(content)
        content.translatesAutoresizingMaskIntoConstraints = false
        NSLayoutConstraint.activate([
            content.topAnchor.constraint(equalTo: topAnchor),
            content.leadingAnchor.constraint(equalTo: leadingAnchor),
            bottomAnchor.constraint(equalTo: content.bottomAnchor),
            trailingAnchor.constraint(equalTo: content.trailingAnchor)
            ])

        insertSubview(shadowContainer, at: 0)
        shadowContainer.translatesAutoresizingMaskIntoConstraints = false
        NSLayoutConstraint.activate([
            shadowContainer.topAnchor.constraint(equalTo: content.topAnchor, constant: -shadow.spread),
            shadowContainer.rightAnchor.constraint(equalTo: content.rightAnchor, constant: shadow.spread),
            shadowContainer.bottomAnchor.constraint(equalTo: content.bottomAnchor, constant: shadow.spread),
            shadowContainer.leftAnchor.constraint(equalTo: content.leftAnchor, constant: -shadow.spread)
        ])
    }

    private func setupTheme() {
        self.shadowContainer.layer.shadowColor = UIColor.black.cgColor
    }

    private func setupShadow(_ shadow: Shadow) {
        shadowContainer.backgroundColor = .clear
        shadowContainer.layer.shadowOpacity = Float(shadow.opacity)
        shadowContainer.layer.shadowOffset = CGSize(width: shadow.x, height: shadow.y)
        shadowContainer.layer.shadowRadius = shadow.blur / 2.0
        shadowContainer.layer.shadowColor = UIColor.black.cgColor
    }

    override public func layoutSubviews() {
        super.layoutSubviews()
        shadowContainer.layer.shadowPath = UIBezierPath(roundedRect: shadowContainer.bounds, cornerRadius: 0).cgPath
    }
}

Then in a view controller:
class ColorView: UIView {

    init(backgroundColor: UIColor) {
        super.init(frame: .zero)
        self.backgroundColor = backgroundColor
    }

    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}
class ViewController: UIViewController {

    let contentView = ShadowView(content: ColorView(backgroundColor: .red))

    override func viewDidLoad() {
        super.viewDidLoad()
        view.backgroundColor = .white
        view.addSubview(contentView)
    }
    override func viewDidLayoutSubviews() {
        contentView.frame = CGRect(x: 50, y: 50, width: 200, height: 70)
    }
}

The snapshot tests are then simply:
class ViewControllerTests: XCTestCase {

    func test_viewController() {
        let vc = ViewController()
        assertSnapshot(matching: vc, as: .image(on: .iPhone8))
    }

    func test_view() {
        let view = ShadowView(content: ColorView(backgroundColor: .red))
        assertSnapshot(matching: view, as: .image(size: .init(width: 200, height: 70)))
    }
}

The solution seems to be to use drawHierarchyInKeyWindow: true
assertSnapshot(matching: vc, as: .image(drawHierarchyInKeyWindow: true))

nevertheless this parameter is not exposed when using device configurations
assertSnapshot(matching: vc, as: .image(on: .iPhone8))

I'm investigating this as we have some issue on iOS 13 using drawHierarchyInKeyWindow: true (different references in different machines).
Seems like layer.render(in: ctx.cgContext) won't render the shadow when the background of the view is clear (so shadowPath is used). If we add a non-clear background color to the view that has a shadow then it's shown

Goes for blur() too: with (drawHierarchyInKeyWindow: true) blur() renders correctly, without it, it does not.

Going to close this as the solutions suggested by others should fix! This is an unfortunate limitation of Apple's APIs, but whenever you want to accurately render some of these effects, you must:

Test in a host application
Use drawHierarchyInKeyWindow

Seems I'm unable to test using swift package since I can't use a host application:
https://forums.swift.org/t/host-application-for-spm-tests/24363/18


Question about existing Branches

Hi @szepeviktor
Right now we have two branches:

master
w3tc-0-9-5

master
As we are all aware, this branch is the default for this repository.  What isn't made clear to visitors (without reading the ReadMe -- which i am updating) is that master is specific to the 0.9.4.x generation of W3TC fix updates.
w3tc-0-9-5
This branch, as the name suggests, is home to the 0.9.5.x generation of W3TC fix updates.

Both branches fill different voids for two sets of users.  The first branch, master, is for those who, for one reason or another, are unable to upgrade to 0.9.5.x and so, prefer to stick with this legacy version but still yearn for updates, security patches, and new features.
The other group, the ones using w3tc-0-9-5, want the latest build but still wish for updates, patches, and new features.
Question 1
Because most visitors will not be aware of this, would it be better to create a new branch (from master) called version-0.9.4.x and then delete master?  And also rename w3tc-0-9-5 to version-0.9.5.x?  This way we have two distinctly different but similarly named branches: version-0.9.4.x and version-0.9.5.x making it clearer what they both are about.
I will be revising the README.md file to make mention of the two generations and include links to their respective latest zip releases but just wanted to ask about this.
Question 2
I was thinking the zips would have this naming convention:
w3-total-cache-fixed-(for-0.9.4.x-users).zip
w3-total-cache-fixed-(for-0.9.5.x-users).zip
Inside this zip (and therefore, extracted) it would conform to WP style and have a folder named after the exact directory name the plugin needs to be, which is: w3-total-cache-fixed (so no renaming is required).  Is that okay or is it still best that the zip be simply called w3-total-cache-fixed.zip for both branches?  I figured postfixing the extra part at the end of the zip would make it clearer which zip was for which audience.
Thanks for your input
Kimberly :octocat:

+1 for moving master to a more distinct branch of its own, and merging 0.9.5 into master, as the default RELEASE code.
Also i think this project should be renamed&called w3-total-cache-ce  (as community edition) because this branch is much more then just applying small fix/changes to the original code base.

Please rename them yourselves
https://gist.github.com/lttlrck/9628955
then I delete the leftover.
Please consider chosing v0.9.5.x and v0.9.4.x
There have to be a default branch. Is it Ok to set the v0.9.5.x branch as default?

v0.9.4.x is stable. v0.9.5.x have tons of bugs. For me the default branch is the stable and ready for producton v0.9.4.x

Thanks guys... will do

@szepeviktor  ok there are now two branches v0.9.4.x and v0.9.5.x ... the only thing left to do is for you to select the default branch.  As the others mentioned, because of stability, it's probably better to set the default branch as v0.9.4.x for now.  But i can see v0.9.5.x being the default in due time.  Btw, don't forget to delete the master branch after the switch.

Done.
https://github.com/szepeviktor/w3-total-cache-fixed/branches


Re-write mono module editor code in C#

I forgot to commit one file, will fix soon.

Alright, 9th time should be the charm. CI should be happy now...

Alright, 9th time is the charm. CI should be happy now...

Thanks!


API: DC frames and progressive rendering

DC frames can be used to have progressive DC, i.e. 1:16, 1:32, etc previews can be obtained from a partial bitstream before the full 1:8 DC image is available.
However, in the API, DC frames do not lead to a JXL_DEC_FRAME event since they're not a regular frame. You have to wait for the next frame is reached in the bitstream, which will likely be a regular frame that uses the DC frame as its DC, before image output gets set up and progressive flushing can start happening.
So only when the whole DC frame has been loaded, something will be shown. This is not optimal.
It would be better if we could already produce a JXL_DEC_FRAME event when the DC frame is encountered, and start showing previews of the DC whenever a need_more_input + flush happens afterwards.

JXL_DEC_FRAME event is only for complete image frames, which a DC frame is not; so producing a JXL_DEC_FRAME would not be correct.
This falls into the category of progressive events that are not yet a fully rendered frame but some point where the user may decide to render (flush) something. Passes would also fall here. We discussed about this a while back, and the idea was to create new events that you can subscribe to for progressive decoding, but there was still some wiggle room to decide which events would trigger it.


inlay hints seem to cause errors

see this error message:
Error detected while processing CursorHold Autocommands for "*.go":
Error executing lua callback: /usr/share/nvim/runtime/lua/vim/lsp/util.lua:2017: attempt to get length of local 'line' (a nil value)
stack traceback:
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:2017: in function 'character_offset'
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:1940: in function 'make_given_range_params'
        ...are/nvim/site/pack/packer/start/go.nvim/lua/go/inlay.lua:40: in function 'get_params'
        ...are/nvim/site/pack/packer/start/go.nvim/lua/go/inlay.lua:274: in function 'set_inlay_hints'
        ...are/nvim/site/pack/packer/start/go.nvim/lua/go/inlay.lua:27: in function <...are/nvim/site/pack/packer/start/go.nvim/lua/go/inlay.lua:26>

It just breaks at some point, after the error occured for the first time, it'll keep happening on cursor hold. I don't know what causes the breakage though.
Regards

Seems the result of following function is nil
  local line = get_line(buf, row)
It seems to be a known neovim bug
https://github.com/neovim/neovim/issues/17615
From the description, seems the buf pointing to a file that no longer exists. Is that what happened? e.g. .go file removed (by git checkout another branch), or it is a temporary buffer?

Nothing removed, nor a temporary buffer.

I saw similar thing when I use dap to debug the code. I suspect it is an upstream error.

I was just about to post this exact same issue.
I can replicate this anytime by going into a .go file and removing the end of a file, for instance if I have this:
func a() {
  ...
}

func b() {
  ...
}

func c() {
  ...
}

Removing the whole function c and saving the file will trigger the error, and it keeps popping up until neovim is restarted or the deletion is undone so that the function is back in the file again.

@ray-x I just pulled your new commit into my plugin, at least for me it seems to have fixed the problem, the error doesn't appear when deleting something at the end of a file anymore. Fantastic!


Remove iterator from collection in favour of fetchAll

This is a step towards moving from arcs.sdk.jvm.CollectionImpl to arcs.core.storage.handle.CollectionImpl and  arcs.sdk.jvm.SingletonImpl to arcs.core.storage.handle.SingletonImpl.

Closed as mentioned by @csilvestrini


Fixes

Small fixes, in particular for issue #777
Fixed issue #777 (Excessive creation of TraceThreads)
Improved logging for finding PDBs slightly (now prints SOMETHING even if you hit a PDB cache).
Fixed a bug where a PDB was not being found because the last lookup had different PDB
lookup options set.
Responded to issue #766 about the fact that StartTrace does not set the handle to invalid if it fails.
Do a bit better at categorizing threads a .NET ThreadPool threads (or I/O threadpool threads).
@sharwell

I accidentally included TraceEvent.cs, but it has only whitespace changes.  Ignore it.

👍


Update Course Modules to Sawtooth 1.2

Module 3: add a bullet on PBFT
Module 2: Fix typo: s/the the/the/
Add .docx source files

Signed-off-by: danintel<EMAIL_ADDRESS>

The bullet I added to module 3, p. 10, on PBFT, is:
●	PBFT, a leader-based, non-forking consensus algorithm with finality that provides Byzantine Fault Tolerance (BFT). Ideal for smaller, consortium-style networks that do not require open membership.

This PR has documentation changes for Sawtooth 1.1 and 1.2.
Code changes to upgrade to Sawtooth 1.2 are in a separate PR #32

I fixed the formatting on module 3, pp. 6/7. It needed a page break.
I added RAFT to the glossary under Consensus

I pushed the changes above, so it should be ready to approve. Thanks for the review.

Anne, can you approve this?


Debug view: Sort "Paused on ..." threads to the top

When debugging and one thread hits a breakpoint, I'd like for the explicitly stopped thread to be shown at the top of the threads list.
✅ Wanted

The thread I care about is first in the list
Most of the stack for my thread is visible

This way my thread would get more space by default, at the expense of the other threads which I don't care about.

🚨 Current

The thread I care about is last in the list
Most of the stack for my thread is not visible

I'm not sure about this. It means that threads will be changing their order every time they stop/continue, won't that be a little annoying/confusing?
If this is just about being able to see more of the callstack when you pause, then we should change that by changing how the list is scrolled in this scenario, not by changing the order of the threads.

In the end this is subjective of course so I can't say what's really right, but speaking for myself only, my debugging sessions mostly look like this:

Put a breakpoint somewhere
Launch the program
Hit the breakpoint
Examine thoroughly what the stopped thread is doing
Maybe single step or run the stopped thread some more until it stops again
Done, maybe or maybe not relaunch the whole program from start

So in my most common scenario:

Only one thread is important to me
Having that one at the top would make sense
I mostly don't care about any of the other threads or what order they are in

But again, even if sorting the most important thread to the top would help me, this is subjective and I can't say what's actually right.

Actually, IMO the best thing is what IntelliJ is doing, to show only one thread stack and have a dropdown for picking which thread.
First time I saw this I thought it was silly, but after having used it for a while I realized I almost never care about more than one thread anyway and this is a good way to remove clutter from the threads list.
For my suggestion in this issue, picking the most important thread and showing that at the top:

Is not as good as having a dropdown...
... but provides most of the I-care-mostly-about-one-thread-anyway value...
... while being easy to implement.

So I see my suggestion here as a good bang-for-the-buck step in the right direction.

Thanks for your thoughts, I think there's probably room for improvement. I don't want to do what intelliJ does, I like seeing multiple threads and I don't want to invent a new level of UI for this.
One thing that bugs me about the original idea is threads reordering based on whether they are paused. Threads will pause and resume as you step normally through code, and that could lead to UI churn and reordering during normal stepping. I think that maybe if sorting is based on pause state, I'd want it to sort recently paused threads to the top, which would require us to remember which threads were last paused, and track that. Maybe there is room for a "sort order" setting to let the user decide how to sort threads.
However currently I think that we are showing threads in the order that they were returned by the debug adapter, and the DA might be doing something like adding new threads to the bottom of the list, or sorting most "relevant" threads to the top already, and that is also a nice way to order them.
I think a way to address your original issue without reinventing anything would be to try to reveal more of the callstack when we focus a thread. Basically to try to scroll the callstack into view when we pause. That could lead to a better experience regardless of sort order. I would take a PR that does this if it doesn't break the experience in any other way, however I know that the code that manages the focused list item is a bit tricky.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Place actions over the cell content

Hi, first of all, thanks for this great library.
I am trying to figure out if it is possible to reveal the action items on top of the table cell, without it sliding to the left? Any ideas how that could be achieved?
Thank you.

Thanks. Not possible without modification to core implementation. Feel free to fork and try it.


Migrated to swift 3 for OSX

Migrated to swift 3 for OSX

Thanks for the contribution. What version off the toolchain are you using?

Also, have you filled out a CLA to consider your PR?

@hang-h Hi Hang, we're reviewing our PRs. Can you please file the CLA soon, or we may need to close this PR due to inactivity? Thank you.

Fixed upstream.  Thanks for contribution anyway.


docs: document Prometheus tag/label parsing behaviour

Affected Components

[ ] Content & Marketing
[ ] Pricing
[ ] Test
[ ] Docs
[ ] Learn
[ ] Other

Pre-Requisites

[ ] Code is linted (npm run lint)

Notes for the Reviewer
Please see for more context https://github.com/checkly/checkly-backend/pull/5911
Prometheus label keys should only contain a limited set of characters (docs):

Labels may contain ASCII letters, numbers, as well as underscores. They must match the regex [a-zA-Z_][a-zA-Z0-9_]*.

This PR encourages users to only use valid characters in the label name.

@clample maybe explicitly also link to the prometheus spec? https://prometheus.io/docs/concepts/data_model/

Thanks Tim, I agree. I've updated this to link back to Prometheus.


Port EditableText to Scrollable2

@Hixie

(The failing test is skipped on MacOS.  I'll need to look in the office tomorrow.)


Support for Path objects for db paths

Simple PR, just modified the CachedSession to be able to accept a Path object from pathlib for the database path argument. If there's something else I need to do please let me know.

Sorry unfortunately I'm going to be really busy for the foreseeable future. If someone else wants to take this on they can or this can be closed.

Sorry unfortunately I'm going to be really busy for the foreseeable future. If someone else wants to take this on they can or this can be closed.

No problem, I can make those changes.

No problem, I can make those changes.

Merged in #938


Leaflet 怎么把 D3 渲染的结果能都跟地图叠加准确

d3 path

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Bootstrap
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
TypeScript
D3
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropiate repo.


fix: cleanup after moving the bigquery code

These are changes that should have been part of
https://github.com/googleapis/google-cloud-cpp/pull/3808 but jgm forgot
to run the clang-tidy build locally.

This change is

Here and in the other .bzl files, I think it would be nicer to change the source CMakeLists.txt file to override the copyright year and leave this file was it was. Thoughts?

SGTM. Done.


filter: add ratelimit log

Commit Message: add ratelimt log
Additional Description:
add some log to help debug ratelimt filter, in following cases specially:

ratelimt Status Error due when timeout was set to small, refer to istio PR
call grpc server onFailure

Risk Level: Low
Testing: manual testing
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Please add signature for every commit by git commit -s.

/wait

/wait

do we still wait something else?

Is the CI is passing the DCO and the format check?

You will need to apply the DCO on the first commit (follow the instructions here) which would require rewritting the git history of your PR.
Also take a look at https://dev.azure.com/cncf/envoy/_build/results?buildId=87580&view=logs&j=55bc2ab9-36c1-5ab8-58a6-8c258728eeff&t=33b57bf9-ef13-58c8-bc2b-f804aeb16d39 which indicates that you have some format errors

Please add signature for every commit by git commit -s.

And we need to format this code by tools/code_format/check_format.py fix.

These are the remaining problems.

Please add signature for every commit by git commit -s.

And we need to format this code by tools/code_format/check_format.py fix.

These are the remaining problems.

All checks have passed.

Thanks, small comment.
/wait

@mattklein123 please check the code again


what is duckdb-go-api?

Hello,
Could you please explain a little on the usage of code about duckdb-go-api? What is it? How can I get it? Would it be possible to use marcboeker/go-duckdb instead?
Thanks!

Hi @dawsondong!
At this stage, this repo (goofy-duck) is a proof of concept for writing Go duckdb extensions using the C API instead of the C++ interface. Without the need to write any C code, without cgo. I am not completely there yet, as seen by the C code here: https://github.com/taniabogatsch/goofy-duck/blob/d0737d3097e8baa9d982dc97c8dd0d2047337606/my_addition.go#L4
duckdb-go-api is a lightweight Go wrapper for duckdb's C API functions. In its current state, it is far from any official wrapper, and I mainly use it for the goofy-duck proof of concept.
It differs from go-duckdb because it does not implement Go's SQL driver interface. It only wraps the C API functions in Go functions. Conceptionally, this means that (at some more distant point in time) go-duckdb could use these wrapper functions to replace most of its C code. However, they are not a substitute for each other.

Thanks @taniabogatsch ,
I see now on your saying. Finally, I made all work! Good start!


bin/transform-gisaid address #103 strain name bug

this is an attempt to fix a #103
where the strain names output
by bin/transform were not consistent
across metadata and fasta output files.
Since this was only an issue when
--sorted-fasta was not passed, this
addresses the issue by adding logic
to use strain names from the transformed
metadata list (to match the metadata output)
when writing out an unsorted fasta.
Testing
Tested locally with bin/local-ingest-gisaid --transform which resulted in a clean diff (instructions for diff to illustrate the bug are in #103).
Also tested memory usage (only once) using /usr/bin/time -l pipenv run bin/local-ingest-gisaid --transform which showed  only a ~28MB increase when running transform (as in bin/local-ingest-gisaid) with this commit compared to running without. This seems to avoid the larger scale (~5.5GB) increase of using --sorted-fasta.

The check here fails because it is trying to access a file on aws according to the name of this branch and that file only exists without the branch name prefix. It should not fail in that way when we merge.


--autonumber-size for playlist_index

Does playlist_index have an equivalent to --autonumber-size? Just as I don't need so many zeros with autonumber, I'd like to only use 2 digits when using playlist_index in my output template.

%(playlist_index)02d.


Could this be adapted to work with other games?

Left 4 Dead 2?
CSGO?

Potentially but I don't see the point. Definitely is out of scope of this project

Certain aspects of the tool could work on other games, but it's definitely not a priority, and not something I intend to spend time on. If someone else wanted to expand support though, they should be able to without too much work.

fair enough


[Bug] Unable to control camera on secondary monitor

Reproductible:
Requirements:

Have Primary Monitor at 4K resolution
Have a Secondary Monitor at 4K resolution
Have the official Turtle-WoW client with the executable patched via this tool with the default settings

Steps:

Start WoW
Log into the realm
Choose a character to play with
Once you are in the game world, max the settings and lower the UI scaling. Disable VSync and keep WoW in Windowed mode + Maximized (no border) at native 3840 x 2160 resolution
(Optionally) Restart WoW
Move the WoW client to the secondary monitor by invoking the Windows built-in shortcut for this (WinKey + SHIFT + LArrow/RArrow) depending on the position of the secondary monitor
Attempt to move the character by using the regular WASD + RClick
Notice the camera goes crazy and pivot even moves from the character

The other patcher listed on the Turtle-WoW forums work fine when doing this (source code is also there in the forum post), although it's not as detailed as this one here.

I'm having the same issue.
I disabled all settings in CMD, and the issue still exists :O
vanilla-tweaks.exe -o WoW_tweaked.exe --no-quickloot --no-soundchannels --no-fov --no-farclip --no-frilldistance --no-nameplatedistance --no-largeaddressaware --no-sound-in-background WoW.exe
Furthermore, the issue only happens when the game is fullscreen, or the windowed game is very close to the full size of the screen.
If I have the game windowed and at about 85% size of the screen its fine...

Renaming the exe is sadly not an option as the game will reject the login due to "corrupted files".

Sorry for the multiple posts, I'm writing these as I am testing some stuff.
I don't normally use Windows for anything programming related, but looks like there is a diff tool on Windows called fc.
I ran it to compare the two exe files, here is the ouput
fc /B WoW.exe WoW_tweaked.exe
Comparing files WoW.exe and WOW_TWEAKED.EXE
FC: no differences encountered

The /B flag is apparently for comparing binary files.
Note that I turned off all tweaks as per above post, and indeed the binary seems to be unmodified (which I guess is good).
This makes your theory about GPU drivers somewhat more likely.

Its funny that it seems to check some kind of hash of the WoW.exe file, even if that's not the file being executed... if we can circumvent that, as in make it generate the hash off of a different file, that might solve the problem.

Solved it I think!
At 0045DF30 in WoW.exe it seems to do the checksum change. The line is Followed by some stuff about a ChecksumExecutables.cpp, so I think I'm right on the money here.
The original content is
00 00 00 00 57 6F 57 2E 65 78 65 00 00 00 00 00

which reads as ����WoW.exe����� (� being often displayed as a . in hex readers I think...)
Changing this to below value (which is ����WoW2.exe����)
00 00 00 00 57 6F 57 32 2E 65 78 65 00 00 00 00

solved the issue for me.

Note that you your backup unmodified WoW.exe has to be renamed to WoW2.exe for this.

Seeing as they apparently use this as an anti-cheat, it surprised me how easy it was to circumvent...

It probably isn't meant to be an anticheat but rather just a general integrity check for file corruption. I suspect it would be enough to compute CRC for the executable after we apply the patches and then patch that in somewhere.
I'll try and get around to looking into this Soon™, but I've been quite busy (and also lazy) the past couple of months. In the mean time you may be able to work around this by adding the tweaked executable into your GPU drivers somewhere and making sure it uses the same driver profile as WoW.exe does. I don't really remember how that works because it's been some years since I last had to deal with GPU drivers on Windows.

This should be part of the patcher itself. I have reported as an issue to be integrated in a later release of this patcher.

I took a look at this a couple of days ago and it isn't going to be as easy to fix as I had hoped. The checksum verification described by @derpda above probably has something to do with updating the game, and the checksum it compares against is loaded at runtime (maybe sent by server, I didn't check), so patching it statically isn't trivial.

Testing this on Turtle WoW, I'm not having any trouble connecting to the server and playing the game when WoW_tweaked.exe is renamed to WoW.exe. Perhaps the error only happens when there is a patch to be downloaded?

我想解决了！ 在0045DF30WoW.exe 中，它似乎进行了校验和更改。该行后面是一些关于 ChecksumExecutables.cpp 的内容，所以我认为我在这里是对的。 原来的内容是
00 00 00 00 57 6F 57 2E 65 78 65 00 00 00 00 00

其阅读作����WoW.exe�����（我认为经常显示为.十六进制阅读器...） 将其更改为低于值（即����WoW2.exe����）
00 00 00 00 57 6F 57 32 2E 65 78 65 00 00 00 00

为我解决了这个问题。

请注意，因此，您的备份未修改的 WoW.exe 必须重命名为 WoW2.exe。

看到他们显然将其设置为反作弊手段，让我惊讶的是，绕过它是多么容易……

Can you show me how to fix the damage problem


Add autodiscovery for type generation

It is possible for us to find all the types used by a Crux app by starting with the top-level type implementing the App trait and registering the Event, ViewModel and all the capability operations and their outputs. That is the total set of types which we will be sending across the FFI boundary (including all the types used within those types).
In this way we can avoid listing all the types manually and reduce the build.rs of the shared_type crates to a single line (and eventually hopefully remove it altogether).
To do

[x] Basic scanning of the App type
[ ] Macro generated walking of the Capabilities struct
[ ] Bridge machinery types (Request, EffectFfi, etc.)

Current dependencies on/for this PR:

master

PR #105   👈

This comment was auto-generated by Graphite.


Regex in rule definition doesn't like escaped dots

SUMMARY
An escaped dot \. regex pattern within a rule definition throws an error when registering the pack.
ISSUE TYPE
Bug Report
STACKSTORM VERSION
Paste the output of st2 3.0.1, on Python 2.7.6:
OS / ENVIRONMENT / INSTALL METHOD
Ubuntu 14.04 Docker Container.  The pack was both installed as python2 and using the python3 option.
STEPS TO REPRODUCE

Create a new rules with the criterea

  trigger.action_ref:
    type: "regex"
    pattern: "[^(.*\.create_alert|.*\.process-failed-job|ostk_deploy\..*|ostk_auto_approve\..*)]"

Register the pack
st2 pack register [pack]

EXPECTED RESULTS
I expect the pack to register.
ACTUAL RESULTS
# st2 pack register ostk_common
ERROR: 400 Client Error: Bad Request
MESSAGE: Failed to register rule "/opt/stackstorm/packs.dev/ostk_common/rules/failed-job-monitor-v2.yaml" from pack "ostk_common": while scanning a double-quoted scalar
  in "/opt/stackstorm/packs.dev/ostk_common/rules/failed-job-monitor-v2.yaml", line 19, column 14
found unknown escape character '.'
  in "/opt/stackstorm/packs.dev/ostk_common/rules/failed-job-monitor-v2.yaml", line 19, column 21 for url: http://<IP_ADDRESS>:9101/v1/packs/register

Removing the escaped dot \. allows the pack to register.

The error seems to be YAML parser related. We updated pyyaml dependency in 3.0.0. Does this functionality / notation work in v3.0.0 or older versions?
On a related note, did you try escaping \, so \\ instead of \?

Looks like wrapping it with single quotes ' allowed the pack to register after all.

Yes, it looks like the issue is related to the change in the rule definition (it's likely that a single quote was used in the past and recently it was changed to double quote). This functionality in YAML parse didn't change in any of the recent versions so it should be the same with older StackStorm version.
Having said that, I do think it would be good for us to update our code to throw more user-friendly error in such scenarios.
Perhaps something along the lines of: "YAML validation error: . If you are using single backslash (\) in your YAML definition file, make sure it's either quoted using single quotes (') or escaped using another \ (\\). If you don't do that, YAML parser will treat it as a YAML escape sequence. For example: attribute: '\d+' instead of attribute: "\d+.

Reported for U14 and still applies to U18/U20 and st2 v3.5.0


Staging next that includes gcc8

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

elfutils failure for aarach64 https://hydra.nixos.org/build/99978054

@GrahamcOfBorg eval

@vcunat can you cancel the staging-next builds of all but the last evaluation?

OK, I also triggered an evaluation, as I can see ~5k rebuilds per platform since the last one.

Thanks. Note python-unstable builds the exact same revision as staging-next now.

Oh, I looked wrong, I was one evaluation behind.  Anyway, only current version is being built now.

@grahamc any idea how to get Hydra job-management rights to @FRidh?

ghc on darwin shows a problem around sphinx, I suppose?
make -C utils/haddock/doc html SPHINX_BUILD=/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/bin/sphinx-build
/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/bin/sphinx-build -b html . .build-html
Traceback (most recent call last):
  File "/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/bin/.sphinx-build-wrapped", line 7, in <module>
    from sphinx.cmd.build import main
  File "/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/lib/python3.7/site-packages/sphinx/cmd/build.py", line 25, in <module>
    from sphinx.application import Sphinx
  File "/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/lib/python3.7/site-packages/sphinx/application.py", line 38, in <module>
    from sphinx.registry import SphinxComponentRegistry
  File "/nix/store/xd97694caj013pbf54mi3gnhk3jw5qga-python3.7-sphinx-1.8.3/lib/python3.7/site-packages/sphinx/registry.py", line 19, in <module>
    from pkg_resources import iter_entry_points
ModuleNotFoundError: No module named 'pkg_resources'

That's a regression from f7e28bf5d8181926e600a222cb70180519d09726. Looking at the changeset setuptools is no longer propagated and thus no longer added to the wrapper/injected. While this is desirable long-term, I did not intend to do this right now because this will cause more run-time issues. I can push a fix directly but this will cause a whole new rebuild again.

I've pushed a fix for specifically sphinx but not buildPython* in general. Depending on the amount of runtime failures we encounter we can always fix it there.

Any idea whether this is still attempted for 19.09?

@disassembler mentioned on Discourse the branch-off was postponed till tomorrow so we can get this in. I think later tonight we should simply merge, despite a chance in regressions.

Jobs here can be cancelled https://hydra.nixos.org/jobset/nixpkgs/python-unstable

Cancelled.  staging-next is showing ~1k regressions against "trunk" already, though much of that might be some random failures.  Perhaps it depends whether "we" specifically want this change in 19.09 (or more precisely, whether the release managers do).

Qt 4 is broken on staging-next, that's causing the x86_64-linux failures. Aarch64 is also having more regressions.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-19-09-feature-freeze/3707/14

@vcunat this PR for Qt48 and gcc8 ? https://github.com/NixOS/nixpkgs/pull/67246

That change was merged into gcc8 branch but I can't see it in staging-next :-/

Maybe gcc8 got force-pushed removing it

No, see comments on https://github.com/NixOS/nixpkgs/pull/63132

@vcunat will you merge gcc-8 or shall I?

I can't make it today.

OK. Now gcc-8 is in (5f4734b1dd8410d5287fe0f22b9c0f30850a2fc3).

Would you consider picking #68096 for this iteration of staging next as well? It seems to be fairly low impact on the overall systems besides the extra rebuilds. Having this through staging would help us having it accepted for 19.09.

Oh, I wondered if this release should only get one large feature merged on the last day (which is past the planned fork-off date), but apparently we end up the same on every release :-)

proposed eval fix https://github.com/NixOS/nixpkgs/pull/68324

It seems this merge broke building my builds with musl (due to a new [-Werror=attribute-alias] error appearing when glibc is being built with musl):
https://github.com/nh2/static-haskell-nix/issues/56

It seems this merge broke building my builds with musl

PR to fix it: #71480


Chore/implement feedback

What does this PR do?
Implement feedback
Description of Task to be completed?
-Improve readme to include license, contribution guide and FAQs
-Use object destructuring,
-Improve input validation on the backend
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions:

Changes Unknown when pulling 2a719fce1b1be6a5f8fea159c712d17b24c38fa9 on chore/implement-feedback into ** on develop**.


Can not open Grib files from Nomands

I am trying to read in a file from https://nomads.ncep.noaa.gov
I can read all multigrid files like here
but my script fails to read files from other links that are supposed to be Grib files
such as files from here
and fails with the error below
Exception has occurred: exceptions.ValueError
no matches found
  File "/buio/buio/pygrib.pyx", line 610, in pygrib.open.select

or from here
I use this python script to read the files.
I guess the format must be different?

The script you reference uses netcdf4-python to read the nomads dataset, not pygrib.  pygrib is for reading grib files on a local disk - if you want to read remote opendap datasets use netcdf4-python.

Thanks for the comment, there are two scripts and I refer to the second. Also, I have the files stored locally...


Question about forms not having icons

Hello, so while using the API found out that 2 forms of darmanitan doesn't have any icons
https://pokeapi.co/api/v2/pokemon/10174/
and
https://pokeapi.co/api/v2/pokemon/10175/
Maybe it's because they doesn't exist in the game but in web page broken image are showing

Hi, what do you mean by:

in web page broken image are showing

?

I wanted to say "aren't showing"


handle non-us language environments properly

If used on a machine with non-us or C language settings the used git command fails to parse since it does not output the desired strings.
Added a LANG=C environment making the git command output predictable.

Thanks for this, and sorry for being slow to reply - have been on holiday abroad for two weeks and only just saw it.
Will review tonight and merge as long as I can understand it!

Are you sure this is actually necessary? Looking at https://github.com/git/git/blob/d67f9d5e8fd2c165304153a87fd96054d2b74981/builtin/clean.c#L31 it seems that this message is not localized, and I can't reproduce it being different by changing my system language to e.g. Turkish, Russian or German.

Using OS X and ArchLinux on multiple boxes the message was found to be localized.
Using LANG=C has no negative side effects, it just ensures english language messages.

Good enough for me. Thanks for the contribution and sorry it took me so long to get around to merging it.


[WIP] Save by managers

Feedback from code deep dive.... trying to use the managers' save methods instead of copying files around.
Signed-off-by: Richard Edgar<EMAIL_ADDRESS>

OK, so this doesn't work as a drop-in replacement. Also note that the 'save' call on the manager is technically a private method.

OK, so this doesn't work as a drop-in replacement. Also note that the 'save' call on the manager is technically a private method.

What is the error that you see while doing this? it should technically work looking at the code.

The issue is the contract between the tool and gather components. This takes the form of the contents of the output port. Calling _save() on the manager doesn't give quite the same directory structure (I think that my current implementation does a little more unwrapping), so the gather component isn't copying the right things around. This is obviously fixable (although not incrementally, since all the tool components would have to change at once), but since we have something working right now, I'm not sure that it's worthwhile. The gather component is always going to have to know about the directory layout in order to reassemble things, and for the tool components, the question becomes whether it's better for them to call a private method and not have to rearrange the files, or to use a public method, and have to do the copy. I can see the argument for changing, but I think there are much more important issues right now.


webpack-dev-server

webpack  'webpack-dev-server' is not recognized as an internal or external command,
operable program or batch file.
OS windows 8.1 x64
node v6.9.1
npm 3.10.9

Do npm i -g webpack in cmd and try again.

tried and also tried npm i -g webpack-dev-server

Just webpack in cmd gives that error too?

@miecio1212 Could you give this try on an earlier node version? There are some cases where some packages loose functionality if node releases some breaking changes.

Closing for now. Feel free to comment back.


Finish lazy constraints

Finish moving over to lazily-created constraints for all kinds of constraints. This is all NFC, but finally kills off the "create a constraint just to immediately simplify it" code path entirely in the solver.

@swift-ci please smoke test and merge

Nice!


Commandlet Wrappers

Fixes #41
Changes proposed in this pull request:

Create abstract base class UnrealCommandlet
Handle use of commandlets with UnrealEngine and UnrealProject objects
Create DerivedDataCache, ImportAssets, and UpdateGameProject commandlet wrappers
Migrate importsettings wrappers to live with importassets commandlet wrapper

@nhaines-pro

Codecov Report

Merging #42 (319e2f4) into main (c333577) will decrease coverage by 7.13%.
The diff coverage is 1.66%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   70.50%   63.37%   -7.14%
==========================================
  Files          15       18       +3
  Lines        1553     1731     +178
  Branches      309      352      +43
==========================================
+ Hits         1095     1097       +2
- Misses        408      583     +175
- Partials       50       51       +1

Impacted Files
Coverage Δ

src/crazyhusk/commandlet/base.py
0.00% <0.00%> (ø)

src/crazyhusk/commandlet/deriveddatacache.py
0.00% <0.00%> (ø)

src/crazyhusk/commandlet/importassets.py
0.00% <0.00%> (ø)

src/crazyhusk/commandlet/updategameproject.py
0.00% <0.00%> (ø)

src/crazyhusk/engine.py
66.96% <9.09%> (-2.00%)
:arrow_down:

src/crazyhusk/project.py
62.79% <12.50%> (-3.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c333577...319e2f4. Read the comment docs.


Substitute the use of lambda functions by list comprehension

Code Pull Requests
In this pull request, I propose to change the use of lambda functions in test_neuropod.py by list comprehension to gain a little more readability.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Alberto Carmona seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks like there was a new version of Pandas released today that broke the CI.  I'll take a look and let you know when a fix has landed.

Looks like there was a new version of Pandas released today that broke the CI. I'll take a look and let you know when a fix has landed.

Thanks @tgaddair, for taking a look at it :)

Just landed the work around @milyiyo, can you rebase off master and force push?

i think the code is fine, but yes please merge master or rebase so that CI can run and we are sure there are no issues.
Thanks for contributing anyway @milyiyo :)


SPFX Tenant Wide Extension: Exclude/Disable extension for select sites

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[X] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Issue description
I have some tenant wide extensions that I would like to disable or remove from a handful of SharePoint sites.  Is this at all possible or is there a better recommended approach to achieving my need?

@Anonimiss - unfortunately no.
You can either enable it globally, or site by site.
One of the options to achieve your goal could be some "config" list or file that you could read during onInit and make decision if the extension should be visible/active on this or that site.


Video shows blank / black screen but audio plays on some devices

I am using youtube_player_flutter: ^8.1.2 and Flutter (Channel stable, 3.10.5).
It happens on some devices. Especially below SDK level 26

I also get a blank screen on tv devices running Android SKD 7 and below

I have the same issues on amazon fire OS 6

Same here, in FireOS.

Did you guys ever figure out a fix for this?


Delete user endpoint

It is best to merge dynamic-dispatch-fake first, but this is ready for review.

The coveralls branch needs to be merged before this, and then master merged in here.


PR: Catch leaks

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/app/tests/test_mainwindow.py:

Line 371:80: E501 line too long (82 > 79 characters)

@impact27, could you describe what you're trying to achieve here? Also, where exactly are you fixing issue #17213 in this PR? Sorry, but I can't easily spot that.

The goal here is to check that no file or process is opened in a test and not closed. While working on this I noticed https://github.com/spyder-ide/spyder/issues/17213. This bug is caused by closing the stdout and stderr file without stopping the restarter. The restarter therefore tries to restart the kernel, but can’t access the files, as they are closed.


mit-scheme does not work

See homebrew/homebrew#33375 (fix in commit https://github.com/Homebrew/homebrew/commit/8c30f0bb124d5b5ecee132649b17b98df5cb4f79 but not in this repo), affects file https://github.com/homebrew/homebrew-x11/blob/master/mit-scheme.rb.

Can you clarify? The inreplace fix you pointed to is included in the X11 formula here.

Hmm… that's strange. I ran brew update and cleared the cache, but I still get the following error:
$ brew install mit-scheme
==> Installing mit-scheme from homebrew/homebrew-x11
==> Downloading http://ftpmirror.gnu.org/mit-scheme/stable.pkg/9.2/mit-scheme-c-9.2.tar.gz
######################################################################## 100.0%
Error: inreplace failed
lib/include/configure:
  expected replacement of "/usr/local" with #<Pathname:/…shortened…/homebrew/Cellar/mit-scheme/9.2>

(Yeah, my brew isn't in /usr/local, but that shouldn't be an issue?)

It shouldn't be, but Ruby seems to think it is. Anything show up on brew doctor?

Outdated XQuartz is the only thing that seems relevant, but I doubt this has anything to do with that.

Would be surprised. What is your prefix? brew config will show it and a bunch of other details that could be useful. Is it a real prefix or a symlink elsewhere?

$ brew config
HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/Homebrew/homebrew.git
HEAD: 1f2c60618edc2f947fbc2ca8d1f9378d2b428b2b
Last commit: 12 hours ago
HOMEBREW_PREFIX: [~]/my_bin/homebrew
HOMEBREW_CELLAR: [~]/my_bin/homebrew/Cellar
CPU: quad-core 64-bit ivybridge
OS X: 10.9.5-x86_64
Xcode: 5.1.1
CLT: N/A
Clang: 5.1 build 503
X11: 2.7.6 => /opt/X11
System Ruby: 2.0.0-p481
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby
Java: 1.7.0_75

Does your Homebrew prefix actually have a tilde in the path or have you shortened that? @jacknagel Any known issues with underscores in the prefix path?

It's a full /Users/… path, I redacted the login name when I pasted it.

I've been running into the same thing. I had to drop lib/include/configure from the list of files patched by inreplace to get anywhere building this.

I've attempted to whip this formula into better shape. See #84.

Hello everyone!
I'm trying to install mit-scheme but I'm getting this error:
==> etc/make-liarc.sh --disable-debug --prefix=/usr/local/Cellar/mit-scheme/9.2 --mandir=/usr/local/Cellar/mit-scheme/9.2/shar
checking size of uintptr_t... 0
checking size of intmax_t... 0
checking size of uintmax_t... 0
configure: error: SIZEOF_CHAR is not 1
configure: error: ./configure failed for microcode```

brew config

HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/Homebrew/homebrew
HEAD: 3feb508602a1caa0dd57092e27ef5968974a3538
Last commit: 30 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: quad-core 64-bit ivybridge
OS X: 10.10.3-x86_64
Xcode: N/A
CLT: <IP_ADDRESS>.1.1431401888
Clang: 6.1 build 602
X11: 2.7.7 => /opt/X11
System Ruby: 2.0.0-p481
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /Users/ozeron/.rbenv/shims/ruby => /Users/ozeron/.rbenv/versions/2.2.2/bin/ruby
Java: N/A```
Can you help me to fix it, please!

@ozeron: See issue #84.

@L2G I've just checked it out. I don't get what I should change, so I used a code from that commit in formula. I get same error SIZEOF_CHAR is not 1 on etc/make-liarc.sh

@ozeron: What I meant to say is that I'm working on getting the mit-scheme formula to function properly, but it's not there yet; #84 shows the latest work that's been done.

@l2g Oh... I'll keep my fingers crossed:)

Should be resolved by https://github.com/Homebrew/homebrew-x11/commit/9506f453158cf28d45d40a537878a075670e8539.


Add FD as a restriction into create time section

Fixing issue:
https://github.com/MicrosoftDocs/azure-docs/issues/108952

#sign-off

#sign-off

In review.
The PR Review team is reviewing your PR. As part of this process, we might make minor changes.
Don't make any commits during this review. When we finish, we’ll tag the PR creator in a comment if we find issues we can't address.
#label:"review-in-progress"
#assign: @denrea

#sign-off

Close/reopen in attempt to add proper labels


Lovelace UI Editor Suggestions and Oversights.

Just started using the UI editor for Lovelace today and short of stating good job, I wanted to point out a few things I noticed from a UX perspective.
Obvious Omissions:

Tab Order - There needs to be a simple way to reorder tabs. At present the only way I can see to do this is to delete all of the tabs and start building them again from scratch. From a UX perspective this is horrible.

Tab View Variables - There seem to be some omissions in the Tab Creation window, like Panel and Background

Moving Cards Between Tabs - There should be a way to move and or copy Cards from one tab to another. I am aware that I can open a card, copy the code, create a new card in another tab and paste the code. This feels sloppy from a UX perspective though. Reminds me of that old trope of designers vs developers.

Next release adds Moving cards between Tabs.
We have plans to add Duplicating of cards.
Good Catch on the Tab View Variables
Will look into Moving Views

Closing this as some things are done, others are worked on.


fix: (V2) Android build problem for static minSdkVersion

What
This PR fixes Android build for a static minSdkVersion.
Changes
This PR changes minSdkVersion value from 21 to getExtOrIntegerDefault('minSdkVersion')
Tested on
Android with this config (RN 0.71.13):
buildToolsVersion = "33.0.0"
minSdkVersion = 23
compileSdkVersion = 33
targetSdkVersion = 33

Related issues
stemyke comment #1814

Nice!

Hey sorry for long radio silence here but thanks for your PR! We no longer have this code so this is obsolete I think.. sorry!


Adding riss in createVerificationSignatureRequest

This PR adds riss to the createVerificationSignatureRequest
Specs are here:
https://github.com/uport-project/specs/blob/develop/messages/verificationreq.md

thanks @simonas-notcat !


Dont cd back if sink changes dir

I ran into a issue when fiddling with a provider for changing directories, where the enable_rooter function reverted the changes.

Thanks!


Additional contact - styling, field widget bugs

This fixes #1575.
This fixes #1573.
As it turned out, the underlying "Additional contact" widget (Select2TagWidget) doesn't save data in a correct format, and then it doesn't display it in a correct format.
This PR fixes the bugs in Select2TagWidget and also provides a very simple migration, that updates incorrectly saved data on production.

I'm not merging this PR yet because I'm waiting for feedback from @Talishask (https://github.com/carpentries/amy/issues/1575#issuecomment-569656420).


Check for updates on the patterns

Compare ApplicationPattern v1.0.0_spec with v2.0.0 and check for need for updating patterns in RegistryOffice v2.0.0.
Examples:

release numbers   (covered in issue #134)
uuids
?

Done


Update unit file for resources and task max

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #2601 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2601   +/-   ##
=======================================
  Coverage   44.03%   44.03%
=======================================
  Files          94       94
  Lines       10235    10235
=======================================
  Hits         4507     4507
  Misses       5008     5008
  Partials      720      720

Flag
Coverage Δ

#linux
47.48% <ø> (ø)
:arrow_up:

#windows
40.66% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777cc50...4972e3f. Read the comment docs.

LGTM


Improve iOS client build

https://github.com/cvet/fonline/tree/iOSBuild

It's take some SDL workarounds but done.

And yes, with this improvement also was upgraded SDL to version 2.0.9.


fix(helpers): condition to check if we reached the end of the carousel for translateX

This PR fixes the following bug :

As you can see the right arrow is still displayed when we reach the end of the carousel.
You can reproduce this bug with this configuration:
{
  "noOfChildren": 4,
  "wrapperStyle": {
    "padding": "0 60px",
    "maxWidth": 763,
    "margin": "0 auto"
  },
  "componentProps": {
    "infiniteLoop": false,
    "activePosition": "left",
    "numberOfCards": 1.8,
    "slidesToScroll": 1.8
  }
}

Its not working with typescript

Could not find a declaration file for module 'react-items-carousel'. 'c:/Projects/Leximind/leximid-dashboard/node_modules/react-items-carousel/dist/react-items-carousel.js' implicitly has an 'any' type.
Try npm i --save-dev @types/react-items-carousel if it exists or add a new declaration (.d.ts) file containing declare module 'react-items-carousel';


Put Ivadomed/Datasets Versions Inside Config

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[x] I've assigned a reviewer

PR contents

[x] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[x] I've added relevant tests for my contribution
[x] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Put Ivadomed version and dataset versions inside config json file. Note during testing, we download the datasets beforehand (release packages, inside the ivadomed folder) so the sha I got was the head for the ivadomed folder for the datasets, same as version_log file. But if you were to have a real dataset, I believe it would get the repo/commit of the real dataset
Linked issues

resolves #167

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 34 (94.12%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 79.229%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ivadomed/utils.py
28
30
93.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
4707

Relevant Lines:
5941

💛  - Coveralls

Thanks, @cakester. I will take a look this weekend.


Cancellation tests are failing with --browser option for 3.0.0

$ node tools/test --run=cancel.js --browser

failing in browser as there is no Promise.config({cancellation:true}), and I don't see any appropriate place where to put it.

Cancellation is still under construction in 3.0, browser tests will be fixed when it's done

Are you planning to change any significant part of its api? Seems that all cancellation tests are passing now and they are much more detailed than I've expected. Even if 'forget' semantics is a far future, the current use cases (found in tests) looks way better than what we have now. I'd like to develop a d.ts for the 3.0.0 and update a DefinetelyTyped/Bluebird repository that is now seriously outdated.

No the api won't change but what remains to be done is interop testing with timers, Promise.join, Promise.using and Promise.coroutine. These features probably don't work with cancellation at all in 3.0 because I haven't implemented interop yet.


Best way for always online

Is any way to set bot always online ?
Disabling screensaver and setting phone display always on - working. But is any other way?

Run Android in a virtual machine.

Who are you asking? Somehow I got a mail about this, but I haven't posted in this issue?

@schoerg I'm asking @mikeeremin because an actual open browser would help, you are probably receiving this because you are subscribed to this thread.. It says the reason on the very last but one line of the e-mail.

Yes I know, but I don't know why I'm subscribed. I can vaguely remember posting here ... or at least reading about it.

Has anyone found a way to keep online?


[FLINK-3242] Also Set User-specified StateBackend without Checkpointing

Before, the user-specified StateBackedn would not be set when generating the
JobGraph if checkpointing was disabled.

Critical fix.
+1 to merge for both 1.0 and 0.10 branches

Merging this...