Is resnet.py intended to work with the example configuration?

Running through the README verbatim and using the togo configuration successfully produces data.npz, but running the resnet.py example with that data produces this error:
~/p/maps〉python3 resnet.py
Using TensorFlow backend.
x_train shape: (8, 256, 256, 3)
8 train samples
3 test samples
class_weight {0: 1, 1: 0.0}
2018-04-13 10:58:18.219381: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
Traceback (most recent call last):
  File "resnet.py", line 83, in <module>
    workers=4)
  File "/usr/local/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/keras/engine/training.py", line 2160, in fit_generator
    val_x, val_y, val_sample_weight)
  File "/usr/local/lib/python3.6/site-packages/keras/engine/training.py", line 1480, in _standardize_user_data
    exception_prefix='target')
  File "/usr/local/lib/python3.6/site-packages/keras/engine/training.py", line 123, in _standardize_input_data
    str(data_shape))
ValueError: Error when checking target: expected fc1000 to have shape (2,) but got array with shape (3,)

I'm not sure whether resnet.py is intended to work with the togo configuration. If not that, is there a configuration that produces data that works with resnet.py?

@tmcw the example resnet was written to work with this example. The example configuration creates one extra class (which would be my guess as to what specifically causes the error). Should we add a note around this somewhere in the docs?

Closing per the other one - no longer working with that particularly observable-related usecase!


GPII-2336: Release 1.0.3 and update versioning to be "forward facing"...

See GPII-2336 for details.

Just to summarize, immediately after cutting 1.0.3, I realised that I should have put in Avtar's "doc fix", which would also fix the same broken link on the npm listing.  In attempting to fix that, I forgot to merge his changes, and so ended up having to publish two versions to actually fix the link.  Thus, 1.0.5 is the latest release, and 1.0.6 is now the "future facing" version.  Sorry for any confusion.


Is typing? feature request

It'd be amazing if this has the little ellipses when the other person is typing. It'd be carbon-copy Facebook Messenger/iMessage!

I think that can be resolved only by Facebook not by this app. Plus, AFAIK the app does have this feature

Yes, it does have this feature. If you don't see it then most probably it's the other person's fault. I, for example, can block a certain URL/API endpoint so the app can't request it, thus can't report my status. See if it works with different people.


set log context for script

follow up https://github.com/oscard0m/octoherd-script-watch-unwatch-or-ignore/pull/1#discussion_r588973902
Basically before
https://github.com/octoherd/cli/blob/309a72c7141115805278cfd99a0b4ee7d4b4c092/index.js#L101
Add a line
octokit.log.setContext({
  repository: {
    id,
    owner,
    name
  }
})

Opening PR, but blocked by this issue:
https://github.com/octoherd/octokit/issues/6


Fixed #6615 -- Removed depreciation warnings for imp package

Based on issue #6615

Coverage remained the same at 78.215% when pulling c5412a215ee69192213ced28f74edba33b93b929 on vThaian:remove-depreciation-warning into 91cd10c4a786cc431d2e4c26cb80a7c86584b738 on divio:develop.


Fix wrong link pointing towards non-fungible-tokens

https://docs.onflow.org/cadence/tutorial/04-non-fungible-tokens/

To reproduce this error, go to this link https://docs.onflow.org/, click the tutorial dropdown, and click Create Non-fungible-tokens (NFT)

correct link: https://docs.onflow.org/cadence/tutorial/05-non-fungible-tokens-1/


Add the function to add, edit and delete Home-visit date and time

For example, a patient with home-visit date and time: 2022-10-11T15:30,  2022-11-10T17:00,  2022-12-10T12:00
To delete all date and time:

edit dt/
edit dti/
edit dt/ dti/

To delete specific date and time:
eg :  to delete 2022-11-10T17:00

edit dti/2
edit dti/2 dt/

To add date and time to the existing list:

edit dt/2023-01-10T16:00
edit dt/2023-01-10T16:00 dti/
So now the date and time will become 2022-10-11T15:30,  2022-11-10T17:00,  2022-12-10T12:00, 2023-01-10T16:00

To change a specific date and time in the existing list:

edit dt/2022-10-29T15:00 dti/1
So now the date and time will become 2022-10-29T15:00,  2022-11-10T17:00,  2022-12-10T12:00, 2023-01-10T16:00

Throw exception when type in index that is larger than the current list size
Throw exception when provide both dt and dti but dti provided is more than dt provided

Codecov Report

Merging #79 (2945c6d) into master (62b2088) will increase coverage by 0.44%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     73.34%   73.79%   +0.44%
- Complexity      503      540      +37
============================================
  Files            80       81       +1
  Lines          1557     1633      +76
  Branches        181      209      +28
============================================
+ Hits           1142     1205      +63
- Misses          355      358       +3
- Partials         60       70      +10

Impacted Files
Coverage Δ

...n/java/seedu/address/commons/core/index/Index.java
100.00% <ø> (ø)

...a/seedu/address/model/person/UniquePersonList.java
92.68% <ø> (-0.18%)
:arrow_down:

...ess/commons/core/index/ReverseIndexComparator.java
50.00% <50.00%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
84.07% <80.70%> (-2.34%)
:arrow_down:

.../seedu/address/logic/parser/EditCommandParser.java
86.66% <87.50%> (+10.99%)
:arrow_up:

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.90% <100.00%> (+0.90%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
98.52% <100.00%> (+0.14%)
:arrow_up:

...rc/main/java/seedu/address/model/person/Nurse.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...main/java/seedu/address/model/person/DateTime.java
75.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Some regex not working in filter via property

i need to filter some changed files in specific directory but the applied regex not working even I tested on https://regex101.com/

label: "payment"
files:

"feature/wallet/.*"

  - "(.*?)\/(addressbook|travelrules|walletsigning)\/.*"

I am having the same issue and it only happens on the files property

@mytrancoinhako, @Mar0xy: As this GitHub Action is written in Go (Golang), handling regular expressions (Regex) requires a bit of extra care. Specifically, you'll need to escape special characters using double backslashes. This is because the backslash in Go strings is an escape character and therefore must be escaped itself.
Here's an example that should work:
- label: "File"
  files:
    - ".*\\/subfolder\\/.*\\.md"

To clarify this, I've submitted PR (#129) that updates the documentation accordingly.

Thanks @philippwaller , a while back I added this note to the docs on this topic, it has a link to https://regex101.com with the golang flavour which is needed to match the behaviour in the action. The tests and docs update made by @philippwaller should make this clearer.
I will close this issue for now but let me know if the issue is solved for you.

Related to/duplicate of #105


Open VSX Listing: Signing the Publisher Agreement

Thank you for being part of the Open VSX community by adding your extensions to the Open VSX Registry. Please note that the service was recently transferred to the Eclipse Foundation and urgent action on your part is needed so we can continue to list your extensions. To ensure uninterrupted service, please sign the Eclipse Publisher Agreement on or before January 8, 2021. If not signed by that date, your extensions will be delisted and will no longer appear on the site nor be available via the API. If you sign at a later date, your extensions will then be re-activated. The signing process is explained in the Wiki (steps 1 and 2).
Please also note that all extensions MUST have a license in order to be listed.
More details are in these recent blog posts:
https://blogs.eclipse.org/post/brian-king/open-vsx-registry-under-new-management
https://blogs.eclipse.org/post/brian-king/new-era-open-vsx-registry
Today, there’s growing momentum around open source tools and technologies that support Visual Studio (VS) Code extensions. Leading global organizations are adopting these tools and technologies. This momentum has spurred demand for a marketplace without restrictions and limitations. Thanks for joining us on this journey as we continue to build the Open VSX community. We look forward to continued innovation from you in 2021!

Hi @spoenemann, thanks for drawing attention. Even though three days are a really short time for such an announcement, I've just signed the publisher agreement. I haven't found any unexpected conditions and I know that the Eclipse Foundation is strongly focused on the open source community.

Hi @spoenemann, thanks for drawing attention. Even though three days are a really short time for such an announcement, I've just signed the publisher agreement. I haven't found any unexpected conditions and I know that the Eclipse Foundation is strongly focused on the open source community.

I'm sorry this has taken you by surprise. We tried to spread information on the transfer as early as possible. The first blog post mentioned above was published in early November.

I'm sorry this has taken you by surprise. We tried to spread information on the transfer as early as possible. The first blog post mentioned above was published in early November.


Emulating Animated.loop()

I would like to loop an animation that isn't going back and forth like the examples you provide. Is there a way to simulate a loop, ie. when an animation completes start over at the initial settings?

I'm not sure that would work (but I am welcome to being proven wrong) because if I set the values in animate back to initial it'll produce the back and forth animation I don't want. Correct?
I'm currently building a ConfettiOverlay where each piece of confetti is a Motion.View. I have them "fall" from above a View to below it (with overflow: 'hidden' and would love to recycle the pieces without needing to the management of removing and adding pieces of confetti from the parent.
I'm new to RN and don't have a lot of experience with the Animated API, so all I can say at the moment is that for my use case, an API of a loop: boolean prop would work for me. Set loop={true} on Motion.View and when the animation completes, put the Motion.View back to its initial state and start animating again.

Ah ok, I see what you mean. It's possible you could set the transition to duration 0 while resetting it to make it not animate during the reset:
transition={{
    type: 'timing',
    duration: 0
}}

But I haven't actually tested that. It's late here in Singapore so I'll test that and think about it some more tomorrow.

I tested that idea and it does work as I think you described. So when a piece of confetti is ready to drop, reset it with no transition to the starting position and wait a frame for it to update, then animate it to the target position.
Does that work?

Yeah, that would be great. That's what I would expect a loop to do based on what the Animated.loop API says: https://reactnative.dev/docs/animated#loop
Thanks for exploring this and sorry for the slow reply. I try to avoid the laptop over the weekend.

Looks like the loop method has an iterations option, which could be a cool feature to add. And if you need help with a PR, that's fine. Just point me in the right direction. I could spare some work time to help make this change.
We are using this at my work for a design system. I'm using Motion under the hood to make our primitives optionally animatable and really appreciate that the API means the consumers of the system don't have to manage Animated.Values all over the place.

I'm pretty swamped right now so a PR would be great! Or I can try to get to it this weekend.
I think let's add a loop: number prop to the MotionTransition in Interfaces.ts that represents the number of iterations. Make it a base interface that MotionTransitionTween and MotionTransitionSpring extend?
Then in createMotionComponent.ts where it calls Animated.spring/Animated.timing check for the loop prop on the transitionForKey and wrap the animation in a loop?

And use -1 for infinite looping?

And use -1 for infinite looping?

Yes exactly, to match the Animated behavior.


Future Request ： Supporting network environments with only IPv6 public network and has no IPv4 public network

There are no plans for this, sorry.

sorry to kick in like this but openvpn works with just ipv6, so whats stopping you from implementing this ?
Its such a shame as most home networks only have access to a public ipv6 and some ipv4 thats Carrier-Grade NAT (Unusable)


Scanning for Kits on WSL with clang 11 installed fails to detect clang.

Issue Type: Bug
Linux Ubuntu 20.04 under WSL2, fresh install.
Freshly installed Clang-11 and clang, clang++ symlinks via sudo apt install clang clang-11. Running clang, clang++ etc work from commandline. It is in the path as well. Scanning for kits refuses to notice clang whatsoever, only picking up gcc.
Extension version: 1.4.1
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard

What is the output of clang -v for you?

I'm not sure what it was when I wrote this yesterday and had been using apt
packages.
But now I deinstalled those and built clang because I needed newer features
for C++20. Nonetheless, kit scanning still fails to look for it.
Here's the output now when running clang -v:
clang version 11.0.0 (https://github.com/llvm/llvm-project.git 425fb21e03b0ec1cac40a415b6417ff5ba04d076) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/local/bin Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/8 Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9 Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9 Candidate multilib: .;@m64 Selected multilib: .;@m64
On Wed, Jul 1, 2020 at 9:26 AM Bob Brown<EMAIL_ADDRESS>wrote:

What is the output of clang -v for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-cmake-tools/issues/1342#issuecomment-652520283,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ52TEUCRUIEXSASRJHTZNDRZNPUFANCNFSM4OM6RIVA
.

Thanks. This output looks normal, so I'm not sure why it wouldn't pick it up.  We'll need to give WSL2 a try and see what's going on there.  Are you able to make it work by adding your own kit?
  {
    "name": "clang 11",
    "compilers": {
      "C": "<path/to/clang>",
      "CXX": "<path/to/clang++>"
    }
  }

I was indeed able to do that. To be clear, this also happened on WSL1. I
tried to upgrade everything to get less broken.
On Mon, Jul 6, 2020 at 10:13 AM Bob Brown<EMAIL_ADDRESS>wrote:

Thanks. This output looks normal, so I'm not sure why it wouldn't pick it
up. We'll need to give WSL2 a try and see what's going on there. Are you
able to make it work by adding your own kit?
{
"name": "clang 11",
"compilers": {
"C": "<path/to/clang>",
"CXX": "<path/to/clang++>"
}
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-cmake-tools/issues/1342#issuecomment-654362246,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ52TER3GDEKOQPGJJ2BPCLR2IA4TANCNFSM4OM6RIVA
.

Thanks for the update.  We have WSL1 already and can try there.

I am having the same issue with native linux:
❯ clang -v
clang version 11.0.0
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/10
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/7
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/9
Found candidate GCC installation: /usr/lib64/gcc/x86_64-suse-linux/10
Found candidate GCC installation: /usr/lib64/gcc/x86_64-suse-linux/7
Found candidate GCC installation: /usr/lib64/gcc/x86_64-suse-linux/9
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/10
Candidate multilib: .;@m64
Selected multilib: .;@m64

same issue with arch linux clang install, running cmake-tools  1.5.3
2021-01-18T13:42:15.967Z [debug] [kit] Bad Clang binary /usr/bin/clang -v output: clang version 11.0.0
✗ clang -v
clang version 11.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64

same issue with arch linux clang install, running cmake-tools  1.5.3
2021-01-18T13:42:15.967Z [debug] [kit] Bad Clang binary /usr/bin/clang -v output: clang version 11.0.0
✗ clang -v
clang version 11.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64

2021-01-23T21:04:59.892Z [debug] [kit] Bad Clang binary /usr/bin/clang -v output: clang version 11.0.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64

2021-01-23T21:04:59.892Z [debug] [kit] Bad Clang binary /usr/bin/clang -v output: clang version 11.0.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0
Found candidate GCC installation: /usr/lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/10.2.0
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64

We almost have CMake Tools 1.6.0 release out the door. Until then, if you want, you can also verify if this problem has been fixed correctly by installing the vsix built here: https://github.com/microsoft/vscode-cmake-tools/actions/runs/557242002#artifacts.


Performance Deviations in Brax

Comparing HalfCheetah in Brax (via gym.make and then wrapped as here: https://github.com/google/brax/blob/main/notebooks/training_torch.ipynb) vs in CARL makes a big difference in return even when the context is kept static. Do we do any unexpected reward normalization? Does the way we reset the env make a difference compared to theirs (as we actually update the simluation)?

Update: this is likely not a CARL bug, the return looks the same even when I remove the base CarlEnv (i.e. what's left is a gym.Wrapper that inits the env but has no other functions). The interactions is very strange nonetheless, maybe there are casting issues somewhere along the way?
Documenting debugging so far (all on Halfcheetah):

checked example notebook vs same code with CARL version
removed context update, behavior persists
replaced init with gym.make as in notebook, behavior persists
removed carl env from the inheritance chain, behavior persists
removed getattr function in the now gym.Wrapper of CARLHalfcheetah, behavior persists

Next steps:

move env creation out of init
states to see if anything is visible in the values there

Help and input are welcome!

Seems like a lot of the performance difference was introduced later in my pipeline - turns out casting the actions/obs often through many wrappers is probably not optimal to keep everything consistent. So I guess we don't really need to do anything, we should just be aware that different inits + carl wrapping + x will produce different learning curves (not necessarily worse, just slightly different shapes.


feat: Faster JSON dumps in format_message with msgspec

This is a draft PR to assist discussion and testing related to Issue #1046
msgspec requires python 3.8 and above.  Issue #1659 is tracking removing support for python 3.7 from the SDK.

:books: Documentation preview :books:: https://meltano-sdk--1784.org.readthedocs.build/en/1784/

Thanks for pulling this together @BuzzCutNorman .

If msgspec is faster and is now supporting the standard output of decimals correctly now, I would like to throw my support behind this PR. The author of msgspec has written the decimal support in specifically for Meltano at our request. The output should be the same as the standard json dumps but a lot faster.
There is an option to output decimal as strings as required for fuller support by certain targets and/or ensuring precision - thinking the informal Singer Decimal specification.
I know a number of the taps that myself and @mjsqu maintain have the ability to output in either decimal form or strings based on a setting and have hints when singer decimal records are used for the target to decode the string decimal.

@BuzzCutNorman thanks you so much for taking to benchmark the JSON serde library alternatives and creating this PR (and the others)!
This seems to require us dropping support for Python 3.7, or doing the work of adding the logic to use simplejson in 3.7 and msspec in all newer versions but that seems unnecessarily complicated.
We've already planned to drop 3.7 (#1659, #1837) for the v1 release, so this PR would have to be merged after that.
The timeline for that is still unclear but I'll update you as soon as things start moving faster in that direction.

@edgarrmondragon A little more time to refine this I think is a good thing.  There are some items that I need some assistance with.

msgspec wants us to reuse an Encoder.  I created it where I found it worked but I don't know if that is the best place for it.  https://jcristharif.com/msgspec/perf-tips.html#reuse-encoders-decoders

msgspec does return the encoded json as a bytes string.  Currently I am decoding it to a str but I also found you can point that result to stdout.buffer and the target side is able to read from stdin as a string.  I don't know what scenario is best to go with.

@edgarrmondragon A little more time to refine this I think is a good thing. There are some items that I need some assistance with.

msgspec recommends reusing an Encoder.  I created it where I found it worked but I don't know if that is the best place for it.  jcristharif.com/msgspec/perf-tips.html#reuse-encoders-decoders

@BuzzCutNorman I think it makes sense where it is now. There are other places where we encode JSON data, e.g. for JSON lines batches but I don't think they're in scope for now.

msgspec does return the encoded json as a bytes string.  Currently I am decoding it to a str but I also found you can write json bytes strting to stdout.buffer and the target side is able to read from stdin as a string.  I don't know what scenario is best to go with.

I think going with the raw bytes produced by msspec is probably better, if just for the slight performance penalty of decoding before writing to stdout but also because it's likely safer.

@edgarrmondragon I updated format_message to return a bytes string and write_message to write to  sys.stdout.buffer.  The pytest tests and testing framework were updated to allow for sys.stdout.buffer.write.  In io_base.py the SingerReader class method listen was updated to pull from sys.stdin.buffer and deserialize_json updated to utilize msgspec to deserialize lines.  I have not found a way to reproduce the parse_float option currently used as of yet.

I was able to change float to Decimal using msgspec.  The key is you need to generate a Struct from SCHEMA messages.  The code is not elegant but working.  If anyone has time, please take a look and let me know what you think.

Hi @BuzzCutNorman ,
I have added msgspec to the traditional singer-python frameworks used by some non-SDK taps. I am seeing some good performance from doing this.  https://github.com/s7clarke10/pipelinewise-singer-python

Hi @s7clarke10 ,
That is great news.  Thanks for sharing how you are using msgspec in singer-python.  I will defiantly be looking it over to see how you leveraged msgspec.

Hi @s7clarke10 ,
That is great news. Thanks for sharing how you are using msgspec in singer-python. I will defiantly be looking it over to see how you leveraged msgspec.

For testing this I have created a branch on pipelinewise-tap-oracle to use msgspec.
Of note is the use of a boolean config setting use_singer_decimal in the tap. As a user of a tap, I have a choice whether I wish to have decimal and float data emitted as a string - "use_singer_decimal": true (to avoid precision loss), or in their native formats for backwards compatibility. It seems to work well, and produces the same results when I was using orjson.
If that setting is omitted it will out default to outputting decimals and floats in their lossy native format - important for backwards compatibility.

@edgarrmondragon, I have a question on how I should deal with the SCHEMA found in  singer_sdk\testing\target_test_streams\optional_attributes.singer .  In the SCHEMA message there is the required field which has a list of fields.  Should I assume the fields not listed could be null.  If that is the case should I also to update the SCHEMA message's properties for optional from "optional": {"type": "string"} to "optional": {"type": ["string","null"]} before passing it on to the target?

@edgarrmondragon, I have a question on how I should deal with the SCHEMA found in singer_sdk\testing\target_test_streams\optional_attributes.singer . In the SCHEMA message there is the required field which has a list of fields. Should I assume the fields not listed could be null?

TL;DR yes!
Strictly speaking there's probably a distinction to be made between missing and null fields, e.g. a string field could be missing but not nullable but for the purposes of moving data it's equivalent and better communicated by the Singer catalog's inclusion and selection metadata.

@edgarrmondragon

Strictly speaking there's probably a distinction to be made between missing and null fields, e.g. a string field could be missing but not nullable

I used the UNSET type to achieve that distinction.  During the runtime creation of a struct from the schema message I set all fields that could be null or missing have a default value of UNSET.  I then remove all items in the record dictionary that have UNSET as a value.  While I use t.Optional to union the python data type with null so null values are allowed.

@edgarrmondragon Yesterday I finished updating the decoder in io_base.py to use the new float_hook argument that was added in msgspec 0.18.0.  The float_hook addition drastically reduced the amount of code changes needed in the SingerReader class to utilize msgspec.

@edgarrmondragon, I was wondering since there is a SingerReader class in singer_sdk.io_base. What do you think of a SingerWriter class being added to that file and moving  the msgspec encoder, write_message(), and format_message there from singer_sdk._singerlib.messages.   All the stdin and stdout methods, msgspec encoder, and msgspec decoder would be in one file.  Then SingerWriter could be added as an inherited class of Tap just like SingerReader is an inherited class of Target.  The additions to singer_sdk.io_base might something like this.
import msgspec
from singer_sdk._singerlib import Message, SingerMessageType

encoder = msgspec.json.Encoder(enc_hook=str, decimal_format="number")
msg_buffer = bytearray(64)

class SingerWriter:
    """Interface for all plugins writting Singer messages to stdout."""

    def format_message(self, message: Message) -> bytes:
        """Format a message as a JSON string.

        Args:
            message: The message to format.

        Returns:
            The formatted message.
        """
        encoder.encode_into(message.to_dict(), msg_buffer)
        msg_buffer.extend(b"\n")
        return msg_buffer

    def write_message(self, message: Message) -> None:
        """Write a message to stdout.

        Args:
            message: The message to write.
        """
        sys.stdout.buffer.write(self.format_message(message))
        sys.stdout.flush()

@edgarrmondragon, I was wondering since there is a SingerReader class in singer_sdk.io_base. What do you think of a SingerWriter class being added to that file and moving the msgspec encoder, write_message(), and format_message there from singer_sdk._singerlib.messages. All the stdin and stdout methods, msgspec encoder, and msgspec decoder would be in one file. Then SingerWriter could be added as an inherited class of Tap just like SingerReader is an inherited class of Target. The additions to singer_sdk.io_base might something like this.
import msgspec
from singer_sdk._singerlib import Message, SingerMessageType

encoder = msgspec.json.Encoder(enc_hook=str, decimal_format="number")
msg_buffer = bytearray(64)

class SingerWriter:
    """Interface for all plugins writting Singer messages to stdout."""

    def format_message(self, message: Message) -> bytes:
        """Format a message as a JSON string.

        Args:
            message: The message to format.

        Returns:
            The formatted message.
        """
        encoder.encode_into(message.to_dict(), msg_buffer)
        msg_buffer.extend(b"\n")
        return msg_buffer

    def write_message(self, message: Message) -> None:
        """Write a message to stdout.

        Args:
            message: The message to write.
        """
        sys.stdout.buffer.write(self.format_message(message))
        sys.stdout.flush()

@BuzzCutNorman Yeah, I like the symmetry of that 👍

@BuzzCutNorman Yeah, I like the symmetry of that 👍
@edgarrmondragon I just finished adding the SingerWriter class to io_base.  Please take a look when you get a chance.

@BuzzCutNorman Yeah, I like the symmetry of that 👍

@edgarrmondragon I just finished adding the SingerWriter class to io_base. Please take a look when you get a chance.

@BuzzCutNorman If it's not too much effort, would be willing to split that into it's own PR? Would make it easier to review both this PR and that change alone, and allow us to ship it earlier.

@BuzzCutNorman Yeah, I like the symmetry of that 👍

@edgarrmondragon I just finished adding the SingerWriter class to io_base. Please take a look when you get a chance.

@BuzzCutNorman If it's not too much effort, would be willing to split that into it's own PR? Would make it easier to review both this PR and that change alone, and allow us to ship it earlier.

@edgarrmondragon I split out of the SingerWriter related changes into PR #2058.

@edgarrmondragon I believe this PR is passing all the tests now.  I did have to setup xfail for a few legacy tests.  They run fine alone but fail when run with all the tests.  I know this PR cannot be added until python 3.7 support is dropped so when you think it best, please give it a review.

@edgarrmondragon Yay!! 🥳there are lightning bolts ⚡ in the CodSpeed Performace Analysis report for the new JSON encode decode test.

@edgarrmondragon I merged SDK 0.35.0a3 alpha which had PR #2143, which dropped Python 3.7, merged into it.  That was the only perquisite for this PR.

@edgarrmondragon I found where I caused the issue in io_base.py.  I changed @Final decorator for SingerWriter.listen to @t.final and pytest is happy 😃 now 🥳

Just curious, what happened with the msgspec work to speed up serialization?

Just curious, what happened with the msgspec work to speed up serialization?

I still need to come up with a plan to add this with the least amount of disruption, maybe starting with opt-in.

Just curious, what happened with the msgspec work to speed up serialization?

I still need to come up with a plan to add this with the least amount of disruption, maybe starting with opt-in.

@edgarrmondragon,  I am happy to help break this PR into smaller PRs that can be merged in any order you would like.  Please just let me know how I can assist with the process.

Just curious, what happened with the msgspec work to speed up serialization?

I still need to come up with a plan to add this with the least amount of disruption, maybe starting with opt-in.

@edgarrmondragon, I am happy to help break this PR into smaller PRs that can be merged in any order you would like. Please just let me know how I can assist with the process.

Thanks @BuzzCutNorman! I'll take some time this week to go through this and #2259 to see where it makes sense to split and have a reasonable package layout.

@edgarrmondragon I am thinking it is time to close this PR since you have two very good PRs in the works and to be honest this PR is a bit of a mess. WDYT?

I'm happy to close but give you proper credit in what ends up getting merged. Thanks @BuzzCutNorman!


Link to page
https://next-intl-docs.vercel.app/docs/environments/actions-metadata-route-handlers#sitemap
Describe the problem
The sitemap example on the doc is not the same than in the exemple on the code. The exemple in the code work for me but the code into the doc make a double language into url:
Good code :
https://github.dev/amannn/next-intl/blob/e79dd7e6d070702e56d0bf303be0af12a0981cb9/examples/example-app-router/src/app/sitemap.ts

Thanks a bunch for noticing, a fixed version should be up in a minute!


Can I write some markdown doc for examples? I want to make some pr .

Newer like me, Cause a lot of time to run the first example.

In java, I know a plugin that can auto gen markdown doc call "doc view"; Can I write more details by rust comment  and then gen doc by plugin?

Welcome to submit pull requests


uninstall leaves behind context menu item

edit: I just realized this repo is for plugins not the actual console. please delete this issue. I have previously tried to contact the dev but no response

after uninstall, context menu in folder context still has a now blank icon with "hyper" as the text. searching hkroot\*\shellex\contextmenuhandlers yields nothing. any idea on how to remove it? and update the uninstall script to remove it?

@ksurl why did you close your issue?

edit: I just realized this repo is for plugins not the actual console. please delete this issue. I have previously tried to contact the dev but no response

I think that's why. First sentence.

didnt catch edit note in the start of the post

@ksurl It might not work for you, but I solved it by re-installing and uninstalling.

@darahak I was able to delete it from a different registry path. got the fix from here


Drift Detector for Kubernetes app is showing out-of-sync for app that is using Secret manifest with stringData

What happened:
This is caused because the originally applied Secret manifest was using stringData field but the returned resource from K8s has been converted to the string field` by Kubernetes.
https://kubernetes.io/docs/concepts/configuration/secret/#overview-of-secrets
What you expected to happen:
How to reproduce it:
Environment:

piped version:
control-plane version:
Others:

/assign @Hosshii


add compat for plot deps

Codecov Report

Merging #34 (818bbd9) into main (d14e957) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   84.41%   84.34%   -0.08%
==========================================
  Files           5        5
  Lines         494      479      -15
==========================================
- Hits          417      404      -13
+ Misses         77       75       -2

Impacted Files
Coverage Δ

src/plot.jl
57.69% <0.00%> (-1.57%)
:arrow_down:

src/enmap_ops.jl
90.18% <0.00%> (-0.35%)
:arrow_down:

src/transforms.jl
91.34% <0.00%> (-0.09%)
:arrow_down:

src/enmap_geom.jl
100.00% <0.00%> (ø)

src/enmap.jl
74.50% <0.00%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14e957...818bbd9. Read the comment docs.


added example code to list out some of the schemes

Should have an edge case condition where if number isn't 1, 2 or 3 it shouldn't execute the third option.


Commits that fall under two+ labels are duped

Issue
If my commit message has keywords that map to multiple labels, bugs and features for instance, the commit will show up under both labels in the release notes. While we agreed this was not a bug, it would be nice to include an option to enable/disable this behavior.
The real question is what label will take preference if it does fall under multiple labels, which I believe is worth a discussion. Imo - we should honor the first label grepped.
Brain dumping here but I think this means we will need to keep a record of the commit SHA and disallow it from being added to the release note file if it has already been added. Implementation will have a cost to performance because we will need to do some sort of check against commits already in the log and will likely be O(n) at best.

Assigning to you for now @dvmonroe to make sure you see this. Feel free to remove the assign after we talk and one of us can tackle it depending on who has bandwidth (which will likely be me before you)

All great points @andrewmcodes . I think there can be a way here to check the commits we've already logged to our tmp.md file in memory as we discussed.  I think you're on a good track. Reach out if I can help.


[e2e]: container push branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3570697779
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.push.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.push.branch1.default.slsa3.yml
Trigger: push
Branch: branch1
Date: Tue Nov 29 03:21:02 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3571411170
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.push.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.push.branch1.default.slsa3.yml
Trigger: push
Branch: branch1
Date: Tue Nov 29 05:53:38 UTC 2022


Default exports per folder

What was the reasoning behind throwing an error in queries/index.ts and components/index.ts?
https://github.com/RoamJS/roamjs-components/blob/a6cbd49608bd0f70b5a8ab1e7e9de6af94aafb85/src/queries/index.ts#L1-L5
vs
https://github.com/RoamJS/roamjs-components/blob/a6cbd49608bd0f70b5a8ab1e7e9de6af94aafb85/src/dom/index.ts#L1-L5
https://github.com/RoamJS/roamjs-components/blob/a6cbd49608bd0f70b5a8ab1e7e9de6af94aafb85/src/date/index.ts#L1-L3
Bundle size?  or something else?
Going forward, should the following be kept up to date with the default exports?
dom/index.ts
date/index.ts
util/index.ts
writes/index.ts
While queries/index.ts and components/index.ts remain as granular imports?

Mostly bundle size. Exporting everything through an index file means all functions are included instead of importing the function you care about directly.
This may be less relevant depending on how esbuild does dead code elimination nowadays


Try to parse full dates from spreadsheets; make dates optional in v1

Description
We'll want to change the spreadsheets' guidance for how to input
dates, but for now, it's easy enough to parse all the date formats
that people have input.
I chose this datetime library because it's designed to resemble
java.time, which is the most sensible datetime library I've used.
Separately, it's now pretty clear to me that it doesn't make sense to
have the date fields be required in the v1 API -- most state
incentives don't have dates defined, and so far we've just been
hardcoding in start_date: 2023 and end_date: 2024 even for
incentives that do define their own dates. (Fortunately the frontend
isn't even reading them.) So they're now optional.
Test Plan
yarn lint and yarn test.
I ran the spreadsheet-to-JSON script on AZ, CO, and VT, which are the
only ones that have any incentives with dates in them, and made sure
there were no failures due to unparseable dates. AZ and CO succeeded;
changes are reflected here. VT failed for unrelated reasons; will look
into that separately.
Added an unparseable date to an incentive in the CO sheet and made
sure the script output that row as invalid.

Somehow I missed that a bunch of other states had dates populated, even though I wrote a little script to check them... weird.
I think the followup work is (a) update the spreadsheet template to require the pseudo-ISO-8601 date format, (b) change all the dates in existing spreadsheets, which is going to be a pain, and (c) update the script to require the pseudo-ISO-8601 format.

Somehow I missed that a bunch of other states had dates populated, even though I wrote a little script to check them... weird.
I think the followup work is (a) update the spreadsheet template to require the pseudo-ISO-8601 date format, (b) change all the dates in existing spreadsheets, which is going to be a pain, and (c) update the script to require the pseudo-ISO-8601 format.

It might make sense to do that just to get it over with, but if you punt for a bit, the eventual json-back-to-spreadsheet flow will take care of it.
If so, you could:

move the date standardization you've written here from data-refiner.ts into spreadsheet-standardizer.ts. That way the dates are converted on their way into the CollectedIncentive schema, and it's an ajv schema error if they're in a format that is unconvertable. If they're convertable, they don't need to be changed.
once we have a working json-back-to-spreadsheet flow, then running spreadsheet-to-json will make the date canonical and then json-to-spreadsheet will write the canonical date back to spreadsheet, letting us replace the old sheets.


Bug some of the tests in the report are not being executed.

we have "spec/requests/api/artists_spec.rb": 5.043759346008301, in the report but its not actually executed in our CI. I was wondering is there a way to check what's the files being executed?(is it only possible to look through the output in the CI pipeline) And we do find that the problem is fixed after we regenerate the report again so not sure what's wrong(the line in the report was updated). By the way we are using minitest.

There is 400 lines in or report and the test being executed is only 329. So I was wondering if there is a way to figure out which one are skipped automatically

As I can see from the code is it because of the sorting of how the reported test are read from the report? maybe we need a sort there also?

As I can see from the code is it because of the sorting of how the reported test are read from the report? maybe we need a sort there also?

Could you provide link to the part of the code you mean?

I was wondering is there a way to check what's the files being executed?(is it only possible to look through the output in the CI pipeline)

You can run bundle exec rake knapsack:minitest and see knapsack logger output with list of tests that are going to be executed.  Leftover tests are those not in knapsack report yet.
https://github.com/ArturT/knapsack/blob/master/lib/knapsack/runners/minitest_runner.rb#L8

There is 400 lines in our report and the test being executed is only 329(405 executed, 329 actual all others seems to be duplicate as from the output). So I was wondering if there is a way to figure out which one are skipped automatically.

If you removed or renamed the file spec/requests/api/artists_spec.rb from your repository then knapsack won't run it because it checks whether the test file found in the knapsack report actually exists.
If test file exists in test directory but not in knapsack report then the test file will be run (it's called leftover test).
If you want to track newly added or renamed test files just try https://knapsackpro.com for a few week or so and compare results with what you have now.

The file is there and its in the report but its not executed(from the output on CI, no pipeline have it) and from the output I get from the CI, i found that there are some files that are running multiple times across different nodes. The line I talked about is https://github.com/ArturT/knapsack/blob/516aedd5ecf3bd0c900ca00e9da22d139e0f7d1d/lib/knapsack/distributors/leftover_distributor.rb#L5
From what I get the total number of test that got ran is correct but as there is so many duplicate a lot are actually skipped(for the output of file name that get executed 76 duplicates are there).

Do you use custom pattern KNAPSACK_TEST_FILE_PATTERN?

Do you see duplicated files in knapsack report json?

You could fork gem and try add uniq here report.keys.uniq
https://github.com/ArturT/knapsack/blob/516aedd5ecf3bd0c900ca00e9da22d139e0f7d1d/lib/knapsack/distributors/leftover_distributor.rb#L5 and see how it works for you.

We have KNAPSACK_TEST_FILE_PATTERN="spec/**{,/*/**}/*_spec.rb" no duplicate in the report.json file

Thanks for your help got it fixed.

Adding report.keys.uniq solved the problem? https://github.com/Vydia/knapsack/commit/566ef35123f8f8839067db27f36ce5435088e22d
Could you provide more context about the investigation you did? Is there a real bug in the gem then I'd like to fix that. If not then what was the root of your problem then?

some of the configuration for running the test was wrong so however one of the pipeline is not executed on the CI. Its not a real bug.

OK. Thank you!


Add feature to allow use native-tls

Some architectures (like ppc64el, riscv64) don't have ring support (rustls currently uses ring), add feature to allow fend to compile on these architectures.

I've now implemented it like this:
cargo build --no-default-features:
ureq is fully disabled and fend will show an error message when trying to download currencies
cargo build (default features), or equivalently cargo build --no-default-features --features rustls:
use rustls to fetch currencies
cargo build --features native-tls, or equivalently cargo build --no-default-features --features native-tls:
use native-tls to fetch currencies

Let me know if this works for you, then I'll merge the PR :)

@printfn Works for me!


component including '' (preact-redux) replaced while rendering with merge

This issue might related to #276 and #260 or might be an issue to preact-redux.
dependence:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
environment:

Chrome Version 52

Here is the example:

${ssrHtml}

class ChildComponent extends Component {
  render() {
    return
child
;
  }
}
const Child = connect(reducer)(ChildComponent);

class App extends Component {
  render() {
    return (

      <Provider store={store}>
        <Child />
      </Provider>

);
  }
}
// delay 7s to see what happen while client-side rendering with merge
setTimeout(function() {
  render(
    <App />,
    document.getElementById('container'),
    document.getElementById('my-app')
  );
}, 7000);

While client-side rendering with merge, <App> compared with DOM #my-app:
                  |

               |

  <Provider store={store}>      |
child

child
            |
  </Provider>                   |

                          |

Here is what we see in Chrome DevTool 7s after server rendering:

Full example on CodePen. Much clear on the github-page (not found image request twice).

@csbun Yikes!  This is due to how Preact tracks ownership of high order children.  It looks like there might be a case here for switching to the innermost child owning the generated DOM.

I've got a fix! 💃

Should I update preact or preact-redux?

Not yet, still testing.

The latest raft of updates (about to be released as 6.1) fix this!

Fix released in 6.1! https://codepen.io/developit/pen/ozZYPK

Great!


consul_join_wan definition is not working

Hello!
I am trying to specify consul_join_wan, but the values I define don't appear to get picked up. The result is also a mangled config.json file.
To reproduce, define the following variable:
  vars:
    consul_join_wan:
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"

Please let me know if you have any questions.
Thanks,
-yash

See also the comments here:
https://github.com/brianshumate/ansible-consul/commit/5fdbf3fda106e174113bd49b8dda6d6c9e2a5731#diff-ca5bb9e516febbc560d531ce7f8b87e3


Show commit js bug

gitea:1.11.5
chrome:80.0.3987.163

Need to backport part of https://github.com/go-gitea/gitea/commit/fd094eea959a235654b7591da066dcbbee11fc25.


No results at "Server listening on http://<IP_ADDRESS>:8050"

I'm on Windows using Docker tool box.
When I run docker run -it -p 8050:8050 --rm scrapinghub/splash, I receive the message Server listening on http://<IP_ADDRESS>:8050,as it should be. But when I go to the address, the only thing that returns is ERR_ADDRESS_INVALID, the page isn't loading.
I try to search for this problem, changing the SPLASH_URL on my settings.py according to my Docker IP adress, but still with no sucess. The reason I'm intereseting in fixing this issue on my machine is because when I crawl with my spider, it just does nothing, i.e., the logging info returns:
 [scrapy.extensions.logstats] INFO: Crawled 0 pages (at 0 pages/min), scraped 0 items (at 0 items/min)
Any ideias on how I messed this up? Thanks!

I've managed to understand the problem.
I have to change my SPLASH_URL  to my docker-engine ip. I didn't help-me me with the logging problem, but at least helped me to uderstand the causes from the ERR_ADDRESS_INVALID. Now I can debbug my code knowing that Scrappy is running perfectly normal.
StackOverflow helped me resolving this issue.

I also resolve the problem in the log message. I was calling my fuction as start_request, when I should use start_requests, at plural.

Shall we close this issue, then?

Yes


build-toolchain: Use the same behavior on macOS as we do on Linux

The default is to run no tests. If you want to run tests you need to pass -t (--test).

This is a follow-up to #15424

@swift-ci Please smoke test


Rename autocfg probe method to _foo to avoid dead code warning

If rayon is built in a configuration with warnings as error (e.g., RUSTFLAGS=-Dwarnings), then the probe will fail even though the compiler does have the necessary const generic support.

This is fine, although I must say I'm generally not a fan of RUSTFLAGS=-Dwarnings.
(We'll probably start applying --cap-lints to avoid such problems...)
bors r+

The failure is not your fault -- I'm looking into what changed on nightly...

https://github.com/rust-lang/rust/issues/88038#issuecomment-1125494273

That should be fixed by #935.
bors retry


Let WM wait for connection to succeed

Added a while loop to check when Wifi Manager connects to internet

Thanks for your PR. But I don't think it's necessary.
The autoconnect() already has the autoconnect waiting loop
while (millis() - startedAt < 10000)
{
  //delay(100);
  delay(200);

  if (WiFi.status() == WL_CONNECTED)
  {
    float waited = (millis() - startedAt);

    LOGWARN1(F("Connected after waiting (s) :"), waited / 1000);
    LOGWARN1(F("Local ip ="), WiFi.localIP());

    return true;
  }
}

also the while forever loop while(WiFi.status() != WL_CONNECTED) is not good as sometimes, the system loop()  still needs to run even if no WiFi.
This is the minimal example, just to show how you can minimize an example, and not expected to be used. It;s better to use the full-fledge example for your use cases.
Please don't hesitate to post other PRs if you find out bugs or enhancements. Very good for a undergrad Student as yourself to participate and contribute. Keep up the good work and sure you'll have a great future.

Thanks for the compliments I look forward to contributing more if I can!


Add test for dict compatibility for Workflow objects

Add test that makes sure it can be serialized just like a dict does by performing json.dumps on a workflow object and make sure it matches the serialization of a plain dict.

Also check running it through pymongo's bson function.


[terra-toggle]: Update terra-toggle animation to use 'ease-out' easing.

Summary

Updated the animation on terra-toggle from ease to ease-out.
https://developers.google.com/web/fundamentals/design-and-ux/animations/the-basics-of-easing?hl=en#ease-out_animations
Internal terra-toggle uses the react-animate-height component to perform toggle-animation when isAnimate is defined, by default, the 'ease' transition effect applied to the animation.
Added an 'ease-out' easing prop to the react-animate-height component to perform the ease-out transition effect on animation.

Closes #2890
Deployment Link

https://terra-core-deployed-pr-2890.herokuapp.com/
Testing

Ran and updated the jest tests.
Additional Details

Thank you for contributing to Terra.
@cerner/terra

@manjusr Thank you for the contribution!! 🎉

@manjusr i'm not sure why the travis build isn't starting. can you push emily's suggested change to see if we can re-trigger the build?

Thank you for the contribution!!

It is my pleasure to contribute here.

@manjusr i'm not sure why the travis build isn't starting. can you push emily's suggested change to see if we can re-trigger the build?

@yuderekyu I could see the Travis build after committing the changes. Thanks for your timely help!!

Thanks for the contribution @manjusr !


not able to create acl group for consumer

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
we have deployed kong as ingress controller in our EKS cluster with db-less mode, and it works well.
what we are trying to do is to setup a basic authentication mechanism so that only certain consumer can access certain api.
The plugin we are using is acl and key-auth, however I can't find a way to configure the acl group to consumer mapping.
According to the doc, it can be configured either via API or declarative configuration, since we try to manage everything using CRD is there an option that we can create acl group using CRD?
Expected Behavior
able to create acl group using CRD
Steps To Reproduce
1. create `key-auth` plugin

 apiVersion: configuration.konghq.com/v1
 kind: KongPlugin
 metadata:
   name: key-auth
   namespace: apps
 plugin: key-auth
 config:
   key_names:
   - apikey

create acl plugin

apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: acl-fake-api
  namespace: apps
plugin: acl
config:
  allow:
  - fake-api
  hide_groups_header: true

create consumer

apiVersion: configuration.konghq.com/v1
kind: KongConsumer
metadata:
  name: fake-consumer
  namespace: kong
  annotations:
      kubernetes.io/ingress.class: kong
username: fake-consumer
credentials:
 - fake-consumer-key
consumerGroups:
  - fake-group

where should i create the acl group that maps to consumer?

### Kong Ingress Controller version

```shell
kong/kubernetes-ingress-controller:3.0
kong/kong-gateway:3.4

Kubernetes version
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"5835544ca568b757a8ecae5c153f317e5736700e", GitTreeState:"clean", BuildDate:"2022-09-21T14:33:49Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"27+", GitVersion:"v1.27.7-eks-4f4795d", GitCommit:"3719c8491f81867f591e895a43b4f5aab4145794", GitTreeState:"clean", BuildDate:"2023-10-20T23:21:04Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"}

Anything else?
No response

i think i have missed the documentation here https://docs.konghq.com/kubernetes-ingress-controller/latest/plugins/acl/
The acl to consumer mapping can be created using secret
apiVersion: v1
data:
  group: cHJvZHVjdC1hcGk=
  kongCredType: YWNs
kind: Secret
metadata:
  name: acl-product-api-group
  namespace: kong
  labels:
    konghq.com/credential: acl

then, add the group to the consumer credentials
apiVersion: configuration.konghq.com/v1
kind: KongConsumer
metadata:
  name: consumer-one
  namespace: kong
  annotations:
      kubernetes.io/ingress.class: kong
username: consumer-one
credentials:
 - consumer-one-key
 - acl-product-api-group
consumerGroups:
  - group-one


Missing step in Playwright-Gitpod Setup guide

Describe the Issue
In "Playwright-Gitpod Setup" section of "How to add Playwright" tests page, it's missing the step: cd to e2e directory, readers can be confusing and run the command in the root directory, this will cause error
Affected Page
https://contribute.freecodecamp.org/#/how-to-add-playwright-tests?id=playwright-gitpod-setup
Steps to Reproduce

Go to "How to add Playwright tests" page, "Playwright-Gitpod Setup" section: https://contribute.freecodecamp.org/#/how-to-add-playwright-tests?id=playwright-gitpod-setup
In step 3, you can see the missing step: cd to e2e directory (this step is in How to Run Tests section)

Recommended fix or suggestions
Update the doc to add the missing step
Screenshots

An issue with the https://github.com/freeCodeCamp/freeCodeCamp/labels/first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum

To close this, add cd e2e within the same codeblock as the npx playwright test text. The file to change is located within the docs/ directory. Only the English file should be changed.

updated the documentation part of playwright tests

If you've made a fix, you can open a PR @sudheerdivyakolu. Let us know if you need any help.

I'm new to contributing and I really don't know a thing about how to do it
or its working
Please help me in my learning
On Tue, 2 Jan 2024, 21:59 Tom, @.***> wrote:

If you've made a fix, you can open a PR
https://contribute.freecodecamp.org/#/how-to-open-a-pull-request
@sudheerdivyakolu https://github.com/sudheerdivyakolu. Let us know if
you need any help.
—
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/52881#issuecomment-1874252818,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2HUUUEKGZTZQUIA7G2DE7LYMQYWZAVCNFSM6AAAAABBKA3ZNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGI2TEOBRHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sudheerdivyakolu You can read this guide: https://contribute.freecodecamp.org/#/how-to-setup-freecodecamp-locally


Import AddressBase to offline table and then swap the table names

AddressBaseImporter now:

imports all given csv files in one go into an offline table with no indexes
copies index defs over from the live table
swaps the live & offline table names and renames the indexes to be consistent

This last stop is done in one transaction (Postgres has transactional schema changes), so the live table is completely unaffected by an ongoing import, and the name swap happens atomically.
The full import of ~29m rows now runs in ~39mins on my macbookpro, although it will be slower on live

squished the commit history down to two logical steps.

Thanks Al! :sparkle:


New icons for characters not working

          ![Screenshot from 2023-12-27 19-56-30](https://github.com/M3-org/CharacterStudio/assets/32600939/16e66d2e-0d6a-4833-9ccc-fb09c7af65f8)

new branch not making icons of the characters
Originally posted by @madjin in https://github.com/M3-org/CharacterStudio/issues/80#issuecomment-1870771423

just tested latest version, issue still persists with old background

fixed in #108 (close after merge)

Closing after merge, should be working now


LEFT JOIN with json_build_object field not working with null values.

Bug Description
When I try to do a LEFT JOIN where there might be no rows, SQLX doesn't take the field as nullable. Even when the field in the  struct to decode to is nullable. I tried using AS "last_message?" but still sqlx says the field is not nullable.
Minimal Reproduction
My struct is
#[serde(rename_all = "camelCase")]
#[derivative(Default)]
pub struct Room {
    pub id: String,
    pub name: String,
    pub owner_id: String,
    pub image: Option<String>,
    pub owner_username: String,

    #[serde(default)]
    pub owner: Option<PartialUser>,

    #[serde(default)]
    pub receiver: Option<PartialUser>,

    pub to_username: Option<String>,
    pub is_direct: bool,
    pub owner_name: Option<String>,

    pub last_message: Option<SimpleWsMessage>, ///The issue is here

    #[derivative(Default(value = "chrono::offset::Utc::now()"))]
    pub created_at: DateTime<Utc>,
    #[derivative(Default(value = "chrono::offset::Utc::now()"))]
    pub last_update: DateTime<Utc>,

    pub member_ids: Vec<String>,
    pub is_deleted: bool,
}

My query is,
let result : Vec<Room>= sqlx::query_as(
            r#"

            SELECT
    ROOM.* as room,
    json_build_object(
        'id', owner.id,
        'username', owner.username,
        'name', owner.name,
        'pfp', owner.pfp,
        'isAuthorized', owner.is_authorized,
        'createdAt', owner.created_at,
        'lastUpdate', owner.last_update,
        'lastLogon', owner.last_logon,
        'localeId', owner.locale_id,
        'role', owner.role

    ) AS owner,
    json_build_object(
        'id', receiver.id,
        'username', receiver.username,
        'name', owner.name,
        'pfp', owner.pfp,
        'isAuthorized', owner.is_authorized,
        'createdAt', owner.created_at,
        'lastUpdate', owner.last_update,
        'lastLogon', owner.last_logon,
        'localeId', owner.locale_id,
        'role', owner.role
    ) AS receiver,

    json_build_object(
        'uuid', latest_message.uuid,
        'content', latest_message.content,
        'authorUsername', latest_message.author_username,
        'messageType', latest_message.message_type
    ) AS "last_message?" ///Tried overriding nullability

FROM
    ROOM
INNER JOIN
    chatter AS owner ON room.owner_id = owner.id
LEFT JOIN
    chatter AS receiver ON room.to_username = receiver.username
LEFT JOIN (
    SELECT
        DISTINCT ON (room) room,
        uuid,
        content,
        message_type,
        author_username
    FROM
        message
    ORDER BY
        room, timestamp DESC
) AS latest_message ON latest_message.room = ROOM.id
        WHERE owner_id = $1 OR $1 = ANY(member_ids) AND is_deleted = false ORDER BY room.last_update DESC LIMIT 10;

        "#
            )
            .bind(user_id)
            .fetch_all(pool)
            .await?;

error occurred while decoding column "last_message": unexpected null; try decoding as an `Option`

CASE
      WHEN latest_message.uuid IS NULL THEN NULL
      ELSE json_build_object(
            'uuid', latest_message.uuid,
            'content', latest_message.content,
            'authorUsername', latest_message.author_username,
            'messageType', latest_message.message_type
       )
END AS "last_message"

Doing this gives the same 'unexpected null' error too.
Info

SQLx version: 0.7
SQLx features enabled: ["uuid", "postgres"]
Database server and version: Postgres 16
Operating system: Debian 12
rustc --version: rustc 1.75.0 (82e1608df 2023-12-21)

This works in the psql terminal
CASE
            WHEN latest_message.uuid IS NULL THEN NULL
            ELSE json_build_object(
                'uuid', latest_message.uuid,
                'content', latest_message.content,
                'authorUsername', latest_message.author_username,
                'messageType', latest_message.message_type
            )
       END AS "last_message"

This says cannot find column
 json_build_object(
                'uuid', latest_message.uuid,
                'content', latest_message.content,
                'authorUsername', latest_message.author_username,
                'messageType', latest_message.message_type
            ) AS "last_message?"

The former example gives correct results in psql query from terminal. But gives this error
error occurred while decoding column "last_message": unexpected null; try decoding as an Option``

I'm running into the same bug


ParResponseFetchApiClientFilter does not resolve client_id correctly

ParResponseFetchApiClientFilter resolves the client_id by expecting a Request Form parameter of the same name.
This param is only present when the client is using tls_client_auth, for private_key_jwt this param is not supplied.
Currently, the filter works for private_key_jwt because there is a bug in AM (https://bugster.forgerock.org/jira/browse/OPENAM-21910) which makes the form param mandatory for all requests.
ParResponseFetchApiClientFilter needs to be fixed to resolve the client_id correctly, otherwise it will break when AM fixes the bug.

The client_id should be extracted from the request object JWT cliend_id claim.


Function to enable commands

Added the function to enable commands based on the disable one

This was added by Ao in #16 so unfortunately, I have to refuse this one.


Improve indentation of inline snapshots

This fixes #28
Not happy with the choice of character yet (│) which seems to have some bad drawing artifacts in vscode.

@dtolnay what do you think of this indentation style?

Looks good to me! Seems to render correctly in vim and Firefox on Linux. Firefox on Android draws the vertical bar 1.5 columns wide in its monospace font which is odd but perfectly readable.

The extra width is also what vscode shows me. My terminal also gets a bit funky. Will to around with some alternative characters maybe that are less likely to be overwide.

At least for my use ⋮ seems to work better. Trying this now


Add template functions

Description of Changes
Please check that the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Add a changelog entry (for non-trivial bug fixes / features)
[ ] CI passes

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
3.0345325
-0.7931738
28.599676
-0.413929

1
5000
7.775998
-1.0519123
41.2205
+0.7416496

1
10000
13.069195
-0.948472
52.00283
-2.555088

1
10000
13.569379
-0.44828796
53.08486
-1.4730568

1
50000
57.93423
-0.108695984
206.72562
+38.363678

1
100000
104.87287
-3.327034
276.23236
-3.736786

10
100
5.1725864
+0.4655733
31.218212
+0.004983902

10
100
5.03457
+0.3275571
30.897224
-0.3160038

10
500
9.276021
-1.0689545
38.251347
-1.9016724

10
1000
15.327847
+0.2413845
54.2896
+3.4014015

10
5000
63.17062
-4.056118
149.4771
-2.3581696

10
5000
65.881
-1.3457413
201.73734
+49.90207

10
10000
116.75259
-16.86567
330.24112
-4.8153076


lcov 2.0 introduced

Summary: Version of LCOV changed from 1.14 to 2.0 to fix problem with function coverage
Type: Fix
Test Plan: UT
Jira: RIALTO-32

https://jenkins.code.rdkcentral.com/job/github-triggered/35448/ started

https://jenkins.code.rdkcentral.com/job/build-component/73480/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/3255/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/6243/ started.

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/14579/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/14580/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/14585/


Permissions

Description
Right now anyone is able to delete any student from the /student route.
I think only the actual owner/user should have the permission to delete.
So i would like to fix that.
Screenshots

Additional information
No response
What browser are you seeing the problem on?
Chrome
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

assigning to you @TusharKumarChopra, you can start working on it.


Incorrent time for sending

https://github.com/CurrencyCloud/currencycloud-php/blob/52368ffded98f3f72ff35739c202360d90061f9d/src/EntryPoint/TransactionsEntryPoint.php#L80
Server don't support full datetime format, only date format it support

Hi @fiamma06, the return value signifies the settlement has occurred on the date but no specific time has been recorded. When/if downstream providers return specific settlement times  the return value will include it.


SARAALERT-1240: Update patient updated_at upon modification of associated records

Description
Jira Ticket: SARAALERT-1240
Adding/updating any associated records (labs, close contacts, histories, etc) with a Patient should prevent the patient from being purge eligible
Important Changes
Please list important files (meaning substantial or integral to the PR) along with a list of the general changes that should be highlighted for reviewers.
example_file.js

Example change (ex: refactored import function)

Testing
This fix was tested on the following browsers (submitter must check all those that apply):

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] IE11

Please describe the tests needed to verify your changes. Provide instructions for reproducing these tests. List any relevant details for your test configuration.

Could you please change the target of this to be 1.24.0?

@timwongj Base branch was changed to 1.24.0. Can you rebase off of 1.24.0?

Looks good to me. One small comment on test name. Please squash the commits when you get a chance.

squashed


enable IPv6 cidr in microk8s

Hi
Recently we have started testing our apps in IPv6 env .  We require our microk8s dev stations to support Dual Stack or IPv6 .  I couldn't find any documentation or reference online .
Need some guidance whether adding IPv6 support to existing microk8s or scratch installing it .
Thanks,
Leon

Hi Leon. We haven't looked into IPv6 on MicroK8s yet. If you give me a set of steps/questions you need help with to enable IPv6 I might be able to guide you through. @johnsca knows more on what IPv6 needs.

Basically , how to add create the microk8s with IPv6 CIDR . if possible .

how to add create the microk8s with IPv6 CIDR

I'm looking to run microk8s with IPv6. And if possible with no IPv4

I'm looking to run microk8s with IPv6. And if possible with no IPv4

This is also my use-case; I'm not aware of a technical reason for needing to use IPv4 (for my use case!) and solely using IPv6 has certain advantages (public addresses everywhere with access controlled by firewalls, no risk of RFC1918 clashes, etc.).
I'm surprised that IPv6 isn't something that's been looked into - the first IPv6 RFC was published 25 years ago this month so it's not exactly a new technology!

I concur with the other people.
It's 2021, 90s tech should be implemented by now.
Kubernetes supports it, as does Calico. Now just microk8s needs to set the options.
https://docs.projectcalico.org/networking/ipv6

I concur with the other people.
It's 2021, 90s tech should be implemented by now.
Kubernetes supports it, as does Calico. Now just microk8s needs to set the options.
https://docs.projectcalico.org/networking/ipv6

I don't know whether this is useful to anyone, I didn't take this further because I ran into other problems:
You can enable dual stack editing the arguments in /var/snap/microk8s/current/args/ e.g. /var/snap/microk8s/current/args/kube-proxy:
--feature-gates="IPv6DualStack=true"
--service-cluster-ip-range=<IP_ADDRESS>/24,fd41:7f05:4867:9983::/108

Required arguments: https://kubernetes.io/docs/concepts/services-networking/dual-stack/

You can edit the settings for Calico in the kube-system namespace, there's daemonset/calico-node and configmaps/calico-config.
Details: https://docs.projectcalico.org/networking/ipv6#enable-dual-stack
I was able to get MicroK8S to start up and IPs were allocated when configuring a service with this included in the spec.
spec:
  ipFamilies:
  - IPv4
  - IPv6
  ipFamilyPolicy: RequireDualStack

I was unable to reach the service via IPv6 though. I didn't get to the bottom of this, but it could be the host's peculiar IPv6 settings (no default route for IPv6 and Calico says it requires a default route). Despite IPv6 not working, IPv4 continued to work fine.

I don't know whether this is useful to anyone, I didn't take this further because I ran into other problems:
You can enable dual stack editing the arguments in /var/snap/microk8s/current/args/ e.g. /var/snap/microk8s/current/args/kube-proxy:
--feature-gates="IPv6DualStack=true"
--service-cluster-ip-range=<IP_ADDRESS>/24,fd41:7f05:4867:9983::/108

Required arguments: https://kubernetes.io/docs/concepts/services-networking/dual-stack/

You can edit the settings for Calico in the kube-system namespace, there's daemonset/calico-node and configmaps/calico-config.
Details: https://docs.projectcalico.org/networking/ipv6#enable-dual-stack
I was able to get MicroK8S to start up and IPs were allocated when configuring a service with this included in the spec.
spec:
  ipFamilies:
  - IPv4
  - IPv6
  ipFamilyPolicy: RequireDualStack

I was unable to reach the service via IPv6 though. I didn't get to the bottom of this, but it could be the host's peculiar IPv6 settings (no default route for IPv6 and Calico says it requires a default route). Despite IPv6 not working, IPv4 continued to work fine.

Not strictly related to this bug, but may be a suitable workaround for anyone that needs dual stack for external clients but not inside the cluster itself.
On daemonset/nginx-ingress-microk8s-controller in the ingress namespace, you can set .spec.template.spec.hostNetwork to true.
I'm unsure whether there are any other considerations, but may be worth exploring further.
Idea from https://github.com/leblancd/kube-v6/tree/master/dual-stack-ingress

Not strictly related to this bug, but may be a suitable workaround for anyone that needs dual stack for external clients but not inside the cluster itself.
On daemonset/nginx-ingress-microk8s-controller in the ingress namespace, you can set .spec.template.spec.hostNetwork to true.
I'm unsure whether there are any other considerations, but may be worth exploring further.
Idea from https://github.com/leblancd/kube-v6/tree/master/dual-stack-ingress

Hi, I could configure microk8s with IPv6  dual stack and it works great!
Here are the detailed instructions: https://discuss.kubernetes.io/t/microk8s-ipv6-dualstack-how-to/14507
The steps are similar to @mmulqueen comments and other docs, with the following additions:

enable net.ipv6.conf.all.forwarding via sysctl and apply firewall configs
install calicoctl  to enable natOutgoing (egress traffic)
deploy the service using IPv6 "only"

Working on Ubuntu desktop 16.04, 18.04 and Ubuntu server 20.04 (AWS EC2)
Could you confirm these are the correct steps?
BTW, it would be great if calicoctl could be added to the snap (it could event be used as a kubectl plugin)
I could help to enhance the docs and/or provide more testing about this topic.
If this has a chance to get included in microk8s, let me know and I can work in a PR.
Thanks for microk8s!

Hi, I could configure microk8s with IPv6  dual stack and it works great!
Here are the detailed instructions: https://discuss.kubernetes.io/t/microk8s-ipv6-dualstack-how-to/14507
The steps are similar to @mmulqueen comments and other docs, with the following additions:

enable net.ipv6.conf.all.forwarding via sysctl and apply firewall configs
install calicoctl  to enable natOutgoing (egress traffic)
deploy the service using IPv6 "only"

Working on Ubuntu desktop 16.04, 18.04 and Ubuntu server 20.04 (AWS EC2)
Could you confirm these are the correct steps?
BTW, it would be great if calicoctl could be added to the snap (it could event be used as a kubectl plugin)
I could help to enhance the docs and/or provide more testing about this topic.
If this has a chance to get included in microk8s, let me know and I can work in a PR.
Thanks for microk8s!

Very nice work @reingart, thank you!
@evilnick @chris-sanders should we promote this?

Very nice work @reingart, thank you!
@evilnick @chris-sanders should we promote this?

@reingart I think your contributions on a microk8s feature/addon to enable IPv6 would be very welcome.

Any news on this? Missing IPv6 support makes this unusable for my use cases.

Any news on this? I've tried implementing the details linked to in https://github.com/canonical/microk8s/issues/1343#issuecomment-762630371 in my Ansible playbooks, but just crashing against a wall every time. It would be good to have microk8s just start with dual-stack activated and no need to mess around in the configuration.

Would be lovely to finally get IPv6 natively in microk8s without manual hacking.
Can this one please be escalated in the team somewhere?

Hey,
I got this banner today when I logged into my Ubuntu server via SSH:

Strictly confined Kubernetes makes edge and IoT secure. Learn how MicroK8s
just raised the bar for easy, resilient and secure K8s cluster deployment.
https://ubuntu.com/engage/secure-kubernetes-at-the-edge

Could you raise the bar in this area too?
Can it be as easy as:

microk8s enable ipv6

Or simply enable them by default for new installs.
I try not to be annoying, but the IPv4 situations are worst now than the year this issue was created; the auction price skyrocketed.
I deployed microk8s on IPv6-only hosts; I know we can't even download microk8s from the snap store via IPv6, we can't microk8s join over IPv6, and the cluster won't setup without outgoing IPv4 connections.
Basically, microk8s can't officially support IPv6 for now, but this (issue) is the area that can be done first.
I can release IPv4 addresses for some of my servers that only access IPv6-enabled API. (Not the ingress ones)
And by deploying IPv6-enabled APIs myself, I hope to enable some people out there to do the same.
It will ease the situation, despite we still need Dual Stack ingress for the foreseeable future.
It's been three years, and we only get a hackish solution with no official support.
Let me nag you guys a little; the issue needs more attention and prioritization.

Hello, writing a comment to remove the "stale" tag as I don't believe this issue has been resolved by the team.


chore(resume): update "work" to match last schema

Same as #71, though that one got misteriously merged :ghost:

Current dependencies on/for this PR:

main

PR #72

PR #73   👈
PR #71

This comment was auto-generated by Graphite.


Rename ProjectReunion -> WindowsAppSDK

Update the repository per the name change (only some docs were changed before, now change the rest - DLLs, etc).
Naming rules:

"Windows App SDK" -- docs/displayname/comments/etc and if spaces are legal
"WindowsAppSDK" -- everything else
"WinAppSDK" -- can be used in some exceptional cases if necesary (i.e. length limits)
So sweep through the repository changing e.g. "Project Reunion" -> "Windows App SDK", "ProjectReunion" -> "WindowsAppSDK" plus case variations e.g. PROJECTREUNION_FOO -> WINDOWSAPPSDK_FOO.

This change applies to filenames as well as content.
NOTE: This only changes this repository. The aggregator pipeline also needs changes to match. That'll be a separate PR to the build system (i.e. not here).
Internal source code references weren't strictly required for this task but identifying the artifacts needing changes and all their related references and machinery is complicated, so it was easier to just do a full pass through the repository and update everything. As a perk we won't have folks asking 10 years from now "This code says Project Reunion. What is that?" :-)
This doesn't change any mention of Reunion in the ADO repository's backend definitions. The build pipelines are all *.yml so were updated, but if the ADO build definition says Reunion it'll need ES changes to the ADO instance.
There are a few references left:
#1 build\Helix\RunTestsInHelix.proj
<HelixSource>pr/reunion/$(BUILD_SOURCEBRANCH)/</HelixSource> references a backend artifact (branch?)
@alexlamtest for follow up after this PR completes
#2 dev\MRTCore\mrt\Microsoft.Windows.ApplicationModel.Resources\src\Microsoft.Windows.ApplicationModel.Resources.vcxproj
#3 dev\MRTCore\mrt\Microsoft.Windows.ApplicationModel.Resources\src\packages.config
'reunion' appears in version namaes for FrameworkUDK e.g.
<package id="Microsoft.FrameworkUdk.amd64fre" version="10.0.21363.1000-210416-1731.co-release-svc-reunion2104" targetFramework="native" />

This should go away when newer FrameworkUDK's are adopted
@axelandrejs @BenJKuhn for follow up
#4 dev\VSIX\Directory.Build.props
<RestoreSources Condition="'$(RestoreSources)'==''">
            https://pkgs.dev.azure.com/microsoft/ProjectReunion/_packaging/Project.Reunion.nuget.internal/nuget/v3/index.json

This will go away when the NuGet feed's name is changed.
@BenJKuhn for follow up
#5 installer\dev\console.cpp
There's a reference to https://aka.ms/ProjectReunionInstaller which should be https://aka.ms/WindowsAppSDKInstaller but that doesn't resolve. Can be updated at a future data once the URL's available.
@dkbennett @zaryaf for follow up
#6 README.md
*Previously known as Project Reunion*. is a historical reference which expected (the only one that should stay, at least for the foreseeable future).

/azp run

assets (pngs) need new artwork

assets (pngs) need new artwork

@andrewleader's got it covered in a follow up PR

@pmpurifoy merged in latest main with your additions. Please double-check I didn't fat-finger something

/azp run

Thanks for doing this Howard!
Regarding this:

#1 build\Helix\RunTestsInHelix.proj
pr/reunion/$(BUILD_SOURCEBRANCH)/ references a backend artifact (branch?)
@alexlamtest for follow up after this PR completes

This can be changed to:
<HelixSource>pr/WindowsAppSDK/$(BUILD_SOURCEBRANCH)/</HelixSource>
But, TBH, I don't think it matters too much as long as it starts with pr/.
If you want I can do this in a follow-up PR.

Thanks for doing this Howard!
Regarding this:

#1 build\Helix\RunTestsInHelix.proj
pr/reunion/$(BUILD_SOURCEBRANCH)/ references a backend artifact (branch?)
@alexlamtest
        Alex Lam (APPX)
        FTE for follow up after this PR completes

This can be changed to:
<HelixSource>pr/WindowsAppSDK/$(BUILD_SOURCEBRANCH)/</HelixSource>
But, TBH, I don't think it matters too much as long as it starts with pr/.
If you want I can do this in a follow-up PR.

Best to handle in a follow up PR.


Build failed with an exception in Cordova 12

When I add the plugin to my project with: cordova plugin add https://github.com/FWiner/cordova-plugin-android-background-mode and try to build it, I get the following error:
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:36: error: cannot find symbol
import android.support.v4.app.NotificationCompat;
                             ^
  symbol:   class NotificationCompat
  location: package android.support.v4.app
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:38: error: cannot find symbol
  import android.support.v4.app.NotificationManagerCompat;
                               ^
  symbol:   class NotificationManagerCompat
  location: package android.support.v4.app
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:346: error: package NotificationCompat does not exist
    private void setColor(NotificationCompat.Builder notification,
                                            ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                          ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                                                                        ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                     ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                                                                ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:230: error: package NotificationCompat does not exist
                    new NotificationCompat.BigTextStyle().bigText(text));
                                          ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
    ^
  symbol:   class NotificationManagerCompat
  location: class BackgroundModeExt
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
                                             ^
  symbol:   variable NotificationManagerCompat
  location: class BackgroundModeExt
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
10 errors

FAILURE: Build failed with an exception.

Cordova version: 12
Please let me know if more information is required. Thanks!

When I add the plugin to my project with: cordova plugin add https://github.com/FWiner/cordova-plugin-android-background-mode and try to build it, I get the following error:
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:36: error: cannot find symbol
import android.support.v4.app.NotificationCompat;
                             ^
  symbol:   class NotificationCompat
  location: package android.support.v4.app
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:38: error: cannot find symbol
  import android.support.v4.app.NotificationManagerCompat;
                               ^
  symbol:   class NotificationManagerCompat
  location: package android.support.v4.app
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:346: error: package NotificationCompat does not exist
    private void setColor(NotificationCompat.Builder notification,
                                            ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                          ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                                                                        ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                     ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                                                                ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:230: error: package NotificationCompat does not exist
                    new NotificationCompat.BigTextStyle().bigText(text));
                                          ^
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
    ^
  symbol:   class NotificationManagerCompat
  location: class BackgroundModeExt
/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
                                             ^
  symbol:   variable NotificationManagerCompat
  location: class BackgroundModeExt
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
10 errors

FAILURE: Build failed with an exception.

Cordova version: 12
Please let me know if more information is required. Thanks!

Hi dariov , i was tried to install this plugin to a clear cordova project(cordova version 12 , cordova-android 12), it seems like work fine.  Can you post the specific screenshots of the errors and the plugin list?

Hi @FWiner, thanks for answering, here are the steps to reproduce the problem:
Create an empty app:
cordova create hello com.example.hello HelloWorld
Add the Android platform:
cordova platform add android
Check requirements (optional):
cordova requirements

Requirements check results for android:
Java JDK: installed 17.0.10
Android SDK: installed true
Android target: installed android-34,android-33
Gradle: installed /usr/share/java/gradle/bin/gradle

Add the background plugin:
cordova plugin add https://github.com/FWiner/cordova-plugin-android-background-mode
Check the plugin list (optional):
cordova plugin list
cordova-plugin-background-mode 0.7.3 "BackgroundMode"
cordova-plugin-device 2.1.0 "Device"

Try to build the project for Android:
cordova build android
Checking Java JDK and Android SDK versions
ANDROID_HOME=~/Android/Sdk (recommended setting)
ANDROID_SDK_ROOT=undefined (DEPRECATED)
Using Android SDK: ~/Android/Sdk
Subproject Path: CordovaLib
Subproject Path: app

> Task :app:compileDebugJavaWithJavac FAILED
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:36: error: cannot find symbol
import android.support.v4.app.NotificationCompat;
                             ^
  symbol:   class NotificationCompat
  location: package android.support.v4.app
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:38: error: cannot find symbol
  import android.support.v4.app.NotificationManagerCompat;
                               ^
  symbol:   class NotificationManagerCompat
  location: package android.support.v4.app
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:346: error: package NotificationCompat does not exist
    private void setColor(NotificationCompat.Builder notification,
                                            ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                          ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:204: error: package NotificationCompat does not exist
        NotificationCompat.Builder notification = new NotificationCompat.Builder(context, CHANNEL_ID)
                                                                        ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                     ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:220: error: package NotificationCompat.Action does not exist
            NotificationCompat.Action.Builder closeAction = new NotificationCompat.Action.Builder(getIconResId(closeIconName), settings.optString("closeTitle", "Close"), closeIntent);
                                                                                ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/ForegroundService.java:230: error: package NotificationCompat does not exist
                    new NotificationCompat.BigTextStyle().bigText(text));
                                          ^
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
    ^
  symbol:   class NotificationManagerCompat
  location: class BackgroundModeExt
~/hello/platforms/android/app/src/main/java/de/appplant/cordova/plugin/background/BackgroundModeExt.java:341: error: cannot find symbol
    NotificationManagerCompat notification = NotificationManagerCompat.from(activity);
                                             ^
  symbol:   variable NotificationManagerCompat
  location: class BackgroundModeExt
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
10 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 737ms
27 actionable tasks: 1 executed, 26 up-to-date
Command failed with exit code 1: ~/hello/platforms/android/gradlew -b ~/hello/platforms/android/build.gradle cdvBuildDebug

If I remove the plugin:
cordova plugin remove cordova-plugin-background-mode
Uninstalling 1 dependent plugins.
Uninstalling cordova-plugin-device from android
Uninstalling cordova-plugin-background-mode from android
Subproject Path: CordovaLib
Subproject Path: app
Removing "cordova-plugin-background-mode"
Removing cordova-plugin-background-mode from package.json

And then try to build, it build correctly:
cordova build android
Checking Java JDK and Android SDK versions
ANDROID_HOME=~/Android/Sdk (recommended setting)
ANDROID_SDK_ROOT=undefined (DEPRECATED)
Using Android SDK: ~/Android/Sdk
Subproject Path: CordovaLib
Subproject Path: app

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1s
50 actionable tasks: 13 executed, 37 up-to-date
Built the following apk(s):
        ~/hello/platforms/android/app/build/outputs/apk/debug/app-debug.apk

Thanks for your time and effort, have a nice day/night...

Hi @dariov1988 , i double checked my local project and this issue was found in cordova version  > 10, i think this link can help you, please try to build after modifying in Android Studio, if the error disappears, I will update the question in the next days.

I had this error too andchanging:
import android.support.v4.app
to
import androidx.core.app
helped me.