Add coerce_types flag to parquet WriterProperties (#1938)

Which issue does this PR close?

Closes #1938.
Rationale for this change
Add a coerce_types flag that will use the arrow cast kernels to coerce incompatible types prior to writing them

This doesn't appear to hook up the parameter to perform the conversions as described on the ticket?

Marking as draft as not currently waiting on review, feel free to unmark when you would like me to take another look


Merge Branch-AboutUs-PPP-Hong Liang with master

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (201f3df) compared to base (53d4f60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             tanhl2000-branch      #21   +/-   ##
===================================================
  Coverage               72.15%   72.15%
  Complexity                399      399
===================================================
  Files                      70       70
  Lines                    1232     1232
  Branches                  125      125
===================================================
  Hits                      889      889
  Misses                    311      311
  Partials                   32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix animation from Search to Single (no animation) and remove navigator

It's not that easy, it would require rewriting the entire router


Parameterize hashes by whether they are known to be hashes; add trait marker to indicate this

    In short, yes, that is my preference.

I think with some extra complexity we could do this non-invasively, by parameterizing all the hashes by a dummy type KnownPreimage/UnknownPreimage or something, which would

Default to UnknownPreimage
KnownPreimage would only be constructible from hash engines/hash method, while UnknownPreimage would have the full set of existing constructors (from_slice, serde, etc)
There would be an explicit _unchecked method for going from Unknown to Known and a From impl for going the other way
Only KnownPreimage would impl ThirtyTwoByteHash

I think that, because of the default type parameter, most users of hashes who are just sticking them into data structures (outpoints etc) but not directly manipulating them, would require no changes to their code. Then because ThirtyTwoByteHash only works with the Known type parameter, type inference would mean users who are hashing stuff then signing/verifying the result would also require no changes to their code.
Only users who are both parsing hashes directly and doing EC crypto with them would need to change their code -- which I expect would be rare, and would also benefit from some more explicitness about how/when the hash becomes trusted.
Originally posted by @apoelstra in https://github.com/rust-bitcoin/rust-bitcoin/issues/1090#issuecomment-1180522293

Closing in favour of #2937


Do not generate duplicated properties

Consider following hierarchy:
public class MaybeHaveValue {
  public string? Value {get;}
  public MaybeHaveValue(string? value) {
    Value = value;
  }
}

public class AlwaysHaveValue: MaybeHaveValue {
  public string Value => base.Value!;

  public AlwaysHaveValue(string value) : base(value) {}
}

Json.Net works fine in this case: we have one model where property is required and another where it's not. But in NSwag generated client we get:
[System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>)")]
public partial class AlwaysHaveValue: MaybeHaveValue
{
	[Newtonsoft.Json.JsonConstructor]
	public AlwaysHaveValue(string @value, string @value = null) : base(@value) {
	  this.Value = @value;
	}
 }

which produces  [CS0100] The parameter name 'value' is a duplicate.

Please submit a complete sample code that we can test on github. I don't fully understand what's wrong here and why you have declared this property twice without override or something...

Consider following controller:
[ApiController]
[Produces(MediaTypeNames.Application.Json)]
[Consumes(MediaTypeNames.Application.Json)]
public class UserController : ControllerBase
{
	[HttpPost]
	[ProducesResponseType(StatusCodes.Status200OK)]
	public async Task CreateUser([FromBody] FullUserModel model)
	{
	}

	[HttpPost]
	[ProducesResponseType(StatusCodes.Status200OK)]
	public async Task UpdateUser([FromBody] PartialUserModel model)
	{
	}
}

public class PartialUserModel {
  public string Name {get;}
  public string? Password {get;}
  // ... maybe 50 more properties here
  public PartialUserModel(string? name, string password) {
    Name = name;
	Password = password;
  }
}

public class FullUserModel: PartialUserModel {
  public string Password => base.Password!;

  // note that `name` here is of type `string` not `string?` so JSON.Net checks if it is not null
  public FullUserModel(string name, string password) : base(name, password) {}
}

FullUserModel naturally inherits PartialUserModel and reexport properties that are guaranteed to be not nulls because they are not null in constructor so properties are validated to be not null. Making two independent models is possuble but awkward because you have to keep track "if I add property to PartialUserModel to not forget add it to FullUserModel.

OK, I understand what you're trying to achieve, but :

AFAIK, JSON.net doesn't understand nor enforce NRT, so I don't think that your Full model behave differently than your Partial model, in the context of the Json.net (unless you put specific attributes on the "inherited" properties)
I understand that you're using inheritance as a way to ensure that the parameter stay the same. Did you have a look at some source generators that could potentially do the same?
I don't think that inheritance and OOP concept maps well in the context of json serialization anyway, and more specifically deserialization. OpenApi makes no exception, and while there are a few hacks like discriminators, I would not expect a first-class support for inheritance for all languages and tools

That being said, you have an issue with duplicate constructor values. For NSwag/NJsonSchema, there are two props : one that is nullable, while the other is not. How should it know that it's the same property, with the child being a non-nullable relay to the parent?
I don't think that could be implemented without coding a hack for this specific use case (which adds complexity to NSwag and needs to be maintained afterwards) and there was not a huge demand for this feature.
If I had to deal with this specific use case, and dealing with C# client for a C# server, I think I'd rather share the models between the two projects. Does that sound feasible for you?

JSON.Net doesn't enforce NRT yet you can do it with attributes:

I understand that you're using inheritance as a way to ensure that the parameter stay the same. Did you have a look at some source generators that could potentially do the same?

Not yet since inheritance worked just fine to me. And I'm not able to move on .net5 yet anyway

I don't think that inheritance and OOP concept maps well in the context of json serialization anyway, and more specifically deserialization. OpenApi makes no exception, and while there are a few hacks like discriminators, I would not expect a first-class support for inheritance for all languages and tools

I'd actually like it to ignore this property at all. But if I put JsonIgnoreAttribute then it will break my Required attribute as well

If I had to deal with this specific use case, and dealing with C# client for a C# server, I think I'd rather share the models between the two projects. Does that sound feasible for you?

Unfortunately it's not an option because I'm using TS/Rust clients as well.
In this case I'd like it to just ignore the property that was declared in base class. Making sure that we only add parameter once shouldn't break anything but helps in this case


configuration(path) correct use of feathers-configuration?

In the template of app.js in the app generator, path for configuration is sent as a parameter. Though, feathers-configuration states that there is a breaking change from 0.3 to 0.4.
Is the template outdated?

That is how it works now, it has been using 0.4.x for a while. Have you have any issues?

Yes, app.configure(configuration(path.join(__dirname, '..'))); in the template have no effect. So loading app.js from another dir will fail reading the config.

Directory layout is like this:

root/dir/file.js containingconst server = require('../server/src/app')

root/server/src/app.js, from template

Ah, I see, if the folder is in a deeper level this will indeed break. I think your fix in https://github.com/feathersjs/generator-feathers/pull/235 works but might cause issues if we start the app outside of the root folder.

I think your fix in #235 works but might cause issues if we start the app outside of the root folder.

How would it cause issues? The parameter is not in use, as of 0.4.x.
The documentation states:

If you are currently setting your configurations via construction arguments, you will need to move these values out of your app into these environment variables.

#235 will not fix my problem, downgrading feathers-configuration to 0.3.x will. Removing the parameter from the configuration() call in the template will avoid confusion, as the parameter has no effect in 0.4.x.

Very indeed so, thank you for the catch, will go out with the next generator release.

I think your fix in #235 works but might cause issues if we start the app outside of the root folder.
How should we start the app from outside the root folder? I am trying to run the feathers app as a systemd service in ubunutu.

Since @feathersjs/configuration is just a small wrapper for node-config you can set the NODE_CONFIG_DIR environment variable.

thanks!


📖  update docs for webhooks documentation

What kind of change does this PR introduce?
Fixes documentation for webhooks check, for issue https://github.com/ossf/scorecard/issues/1847 and https://github.com/ossf/scorecard/issues/2154

[x] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
documentation change only
Which issue(s) this PR fixes
fixes issue https://github.com/ossf/scorecard/issues/1847 and https://github.com/ossf/scorecard/issues/2154

great thank you!


How to treat null as a valid value?

I have a field, which can contain string or null as valid values. I want to match documents, which do not have the field at all. How can I do it with sift? I tried many combinations and nothing worked for me. {$exists: false} unfortunately seems to match null as well, so it's useless:
{'field': {'$exists': false}}

Neither
{'$and': [
  {'field': {'$not': {'$type': String}}},
  {'field': {'$ne': null}},
]}

works. I had to do this:
{'field': function (value) {
  return value !== null and typeof value !== 'string'
}}

Seems pretty inconsistent with how Mongo treats null.

You're right, this is a design bug. Sift's version of $exists currently checks for the existence of anything except null, or undefined, which is inconsistent with Mongodb's implementation.
I'll get around to this as soon as I can. This will likely be a major bump.

This behavior is now fixed in 5.0.0. 🎉


K20 and KL26 Is daplink_addr right?

K20 :
#define DAPLINK_RAM_START               0x1FFFE000
#define DAPLINK_RAM_SIZE                0x00004000
KL26 :
#define DAPLINK_RAM_START               0x1FFFF000
#define DAPLINK_RAM_SIZE                0x00004000
I read books, found that the two opposite。K20 and KL26 Is daplink_addr right?

Hi @neomissing, according to the reference manual for these devices, the K20's start address is 0x2000_0000 – SRAM_size/2 and the KL26's start address is 0x2000_0000 – SRAM_size/4. So with a ram size of 0x4000 then the starting address of each is as follows:
K20: 0x2000_0000 – SRAM_size/2 = 0x1FFFE000
KL26: 0x2000_0000 – SRAM_size/4 = 0x1FFFF000
So these addresses should be correct.

Closing this issue. Please re-open if you still have questions.


mark

恭喜大佬喜中best paper。不读个10遍对不起best paper。

Thanks, but our paper is actually nominated as a best paper, that is, one of the best paper candidates, instead of winning the final best paper award : )


[POSSIBLE BREAKAGE] Stripe: Make version explicit

Stripe has many API versions, some of which are breaking changes:
https://stripe.com/docs/upgrades#api-changelog
If someone today created a new Stripe account, the remote tests would
not pass because Stripe has changed some of the attribute responses around
cards (used by our store method):
https://stripe.com/docs/upgrades#2015-02-18
In addition, the statement_description no longer works since it's been
replaced by statement_descriptor.  Clients of Active Merchant may be
using statement_description so we're now mapping that to
statement_descriptor under the covers.
So how do we solve these issues?  This commit makes the specification of
the Stripe API version explicit in the headers.  Previously, you could
specify the version you wanted to use for a particular transaction.  Or,
you could specify it when you instantiated the gateway.  In this commit,
we still allow such customizations.  If no version is specified though,
we explicitly use the current latest version (2015-04-07).
This improves things such that if Stripe releases a new, breaking API
version, clients using Active Merchant won't be broken.  If we want to
upgrade to the default version Active Merchant uses, we can do so
explicitly and change the underlying options we're passing accordingly.
If you're already specifying the Stripe API version, then this commit
shouldn't break you.  If you're relying on the default API version of
the underlying Stripe account, there may be issues which we'll fix as we
learn of them.

@Shopify/active-merchant I'd love any feedback you might have about this PR.  I suspect you may be explicitly specifying the Stripe API version that you're using, but I'm not sure of that.

The cool part is that I have 2 personal Stripe accounts.  One is a brand new account at the latest API version while the other one is really old using a very old API version.  With this commit, the remote tests now work for both accounts.  The thing I don't know is whether there are some underlying options being passed to Stripe for which we don't have remote tests.

This looks awesome. Big :+1: :+1: from me.


httpResponse doesn't send the response after reconnecting wifi

Hi,
I have an API which is used to connet/reconnet to a Wifi AP, I wanted this API to WriteResponseOK after the connection is established, however it does send back any response even though the connection was made.  For other APIs in my code, httpResponse worked flawlessly, so I think it may be related to wlan methods.
This is the API.
        @MicroWebSrv.route('/wifi', 'POST')
        def wifi_post(httpClient, httpResponse):
            wifi_dict = httpClient.ReadRequestContentAsJSON()
            new_ip = wifi.sta_connect(wifi_dict['ssid'], wifi_dict['pass'])
            if wifi.is_connected():
                if not rtc.is_synced():
                    print('Syncing RTC...')
                    rtc.sync()
                print(new_ip)
                httpResponse.WriteResponseOk()
            else:
                httpResponse.WriteResponseInternalServerError()

So the above API gets a post request with below json data:
{
  "ssid": "new-wifi-ap",
  "pass": "12345678"
}

Below is the wifi.sta_connect() method:
    def sta_connect(self, ap_ssid, ap_pass, verify_ap=False):
        """
        Connect to an Access Point by its SSID and Password
        return: string; the IP of the STA
        """
        # Attempt connection only if SSID can be found
        if verify_ap:
            if not self.verify_ap(ap_ssid):
                print('Network "' + ap_ssid + '" does not present')
                return None

        # Disconnect current wifi network
        if self.sta.isconnected():
            print('Disconnecting from current network...')
            self.sta.disconnect()
            utime.sleep(1)
            self.sta.active(False)
            utime.sleep_ms(200)
            self.sta.active(True)
            utime.sleep_ms(200)
        start = utime.ticks_ms()
        timeout = 10000
        while not self.sta.isconnected():
            if utime.ticks_diff(utime.ticks_ms(), start) > timeout:
                print('Connecting to "' + ap_ssid + '" Timeout')
                if self.ssid and self.pwd:
                    print('Restore the connection with "' + self.ssid + '"')
                    try:
                        self.sta_connect(self.ssid, self.pwd)
                    except:
                        pass
                else:
                    return None
                break
            print('Connecting to "' + ap_ssid + '"...')
            self.sta.connect(ap_ssid, ap_pass)
            while not self.sta.isconnected() and utime.ticks_diff(utime.ticks_ms(), start) < timeout:
                print('Connecting...')
                utime.sleep_ms(1500)
        else:
            print('Network "' + ap_ssid + '" Connected!')
            # if successfully connected, store the SSID & Password
            self.ssid = ap_ssid
            self.pwd = ap_pass
            return self.get_sta_ip_addr()

In the REPL I can see the connection was successfully made, then it just got stuck right at where httpResponse.WriteResponseOk() is, in the browser console, that request was in pending status until timeout.
What can be the issue?
Firmware: MicroPython v1.11-240-g519746cae on 2019-08-26; ESP32 module (spiram) with ESP32
Thanks.
Kaiyuan

Ok, I think I figured out why - when I connected directly to the ESP32's own AP (visiting via <IP_ADDRESS>), the above code worked.  It won't work if the ESP32 connects to my home wifi and I visit the ESP32 through home wifi.
But is there a workaround?

Hi @dukeduck1984,
A httpResponse is sent trought the current TCP/IP(HTTP) persistent connection.
If the main WLAN interface changes, the connection is broken. It's normal.
Could you try my WLAN lib to play with the two interfaces : https://github.com/jczic/MicroWifi (no help but some simple functions).
You can scan APs, connect to an AP, during a connection from a station 👍

Thanks @jczic , I will give MicroWifi a try.


Serde from

@Licenser this looks nice, thank you for putting it together!

@Licenser I've created a separate PR for rustfmt/CI so it's a cleaner commit history, would you be able to rebase/cherry-pick?

merged that other PR #44 w/ the whitespace & CI changes; sorry for jumping
in front of this PR, hopefully it makes it cleaner/easier to understand
at least!

very nice!


Remove duplicate information between pos (int) and feedpos (string)

coverage: 60.102% (+0.002%) from 60.1%
when pulling a5bbf10213351898e324930641fdc87ec107d536 on dennisschagt:remove-feedpos
into ef3e4c51a942857c599f0b94d70cdbeea6c827a5 on newsboat:master.

Thank you!


VSCODE "debug test" throws error saying "Failed to start debugger: "System.InvalidOperationException"

Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
Version:   2.1.402
Commit:    3599f217f4
Runtime Environment:
OS Name:     ubuntu
OS Version:  14.04
OS Platform: Linux
RID:         ubuntu.14.04-x64
Base Path:   /usr/share/dotnet/sdk/2.1.402/
Host (useful for support):
Version: 2.1.4
Commit:  85255dde3e
.NET Core SDKs installed:
2.1.402 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.4 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.4 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.4 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version: 1.28.2
C# Extension version: 1.17.0
Steps to reproduce
I am using MsTest for unit testing. Debugging was working fine. Suddenly started getting issue. When i restart the omnisharp and VSCODE and click debug test it just stuck and nothing happens. When i click again after some time it throws error.
Expected  behavior
I should be able to debug a single test.
Actual behavior
At first click it just got stuck and at second click it throws following error message
Failed to start debugger: "System.InvalidOperationException: Debug session already started.\n  at OmniSharp.DotNetTest.DebugSessionManager.VerifySession (System.Boolean isStarted) [0x00055] in <55a5c1daee14484c9b080078d007b350>:0 \n  at OmniSharp.DotNetTest.DebugSessionManager.StartSession (OmniSharp.DotNetTest.TestManager testManager) [0x00011] in <55a5c1daee14484c9b080078d007b350>:0 \n  at OmniSharp.DotNetTest.Services.DebugTestService.Handle (OmniSharp.DotNetTest.Models.DebugTestGetStartInfoRequest request) [0x00015] in <55a5c1daee14484c9b080078d007b350>:0 \n  at OmniSharp.Endpoint.Exports.RequestHandlerExportHandler2[TRequest,TResponse].Handle (TRequest request) [0x00000] in <7c7bd18e4e204103b0b1dc6c6b472d7d>:0 \n  at OmniSharp.Endpoint.EndpointHandler2+d__18[TRequest,TResponse].MoveNext () [0x0008a] in <7c7bd18e4e204103b0b1dc6c6b472d7d>:0 \n--- End of stack trace from previous location where exception was thrown ---\n  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter1[TResult].GetResult () [0x00000] in <b0e1ad7573a24fd5a9f2af9595e677e7>:0 \n  at OmniSharp.Endpoint.EndpointHandler2+d__16[TRequest,TResponse].MoveNext () [0x0024b] in <7c7bd18e4e204103b0b1dc6c6b472d7d>:0 \n--- End of stack trace from previous location where exception was thrown ---\n  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in :0 \n  at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in :0 \n  at OmniSharp.Stdio.Host+d__13.MoveNext () [0x0010d] in :0 "

@mubarik How did you resolve this issue?


assert statement

the language cares about tests and assertions. It should more closer to the vm, not just native class but first order statement.
Having seen code like the following in Roc. expect 1 == 2 . Something like
assert 1 == 2: "1 does not equal 2",
    2 == 3: "2 does not equal 3";

as the sugar for
if(! (1 == 2))
{
   throw "1 does to equal 2";
}
if(! (2==3) )
{
  throw "2 does not equal 3";
}

The language cannot try catch, so there would be no equiv of Assert.Throws that would still require the native func.

Being able to chain truthy expressions would be highly desired here.

Presently experimenting with this as an expects keyword. If successful, it can consume some of the manual throwing in other locations such as signs vs meets.


[Bug]: [Flink] JdbcIO metrics are always NaN when using the FlinkRunner

What happened?
Specifically these 2 metrics in JdbcIO that should be updated when inserting into the sink database, always have the value NaN, even though data is being ingested in the sink database that I am using.
I am using the apache beam version 2.56.0 and beam-runners-flink-1.17
Screenshot from the FlinkUI

Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[X] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Thanks for the report. A few questions, if you don't mind:

is your Pipeline bounded or unbounded?
can you please share any other command-line arguments/configuration passed to the job?
if bounded, can you verify if the metrics are available after the job terminates via PipelineResult?

Thanks for the report. A few questions, if you don't mind:

is your Pipeline bounded or unbounded?
can you please share any other command-line arguments/configuration passed to the job?
if bounded, can you verify if the metrics are available after the job terminates via PipelineResult?

It's unbounded, I am using KafkaIO as the source and writing using JdbcIO
These are my only passed arguments --runner=FlinkRunner", "--attachedMode=false", "--checkpointingInterval=1000", "--applicationConfigFile={path_to_file}"
N/A

Thanks. Could build patched version of Beam and try to log the contents of the container in here?

I'm going to be taking a peek at Flink metrics soon. I'm not sure if it will fix these, but I think there's some general issues.


[Audio] add stft and fft forier transform

Description
Build forier transform operator and complex64 type support on DJL.

Codecov Report
Base: 72.08% // Head: 71.54% // Decreases project coverage by -0.54% :warning:

Coverage data is based on head (2ee1e2e) compared to base (bb5073f).
Patch coverage: 73.77% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2259      +/-   ##
============================================
- Coverage     72.08%   71.54%   -0.55%
- Complexity     5126     6358    +1232
============================================
  Files           473      631     +158
  Lines         21970    28113    +6143
  Branches       2351     2986     +635
============================================
+ Hits          15838    20114    +4276
- Misses         4925     6540    +1615
- Partials       1207     1459     +252

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
59.21% <0.00%> (ø)

api/src/main/java/ai/djl/modality/nlp/Decoder.java
63.63% <ø> (ø)

... and 564 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Question: how to write info in many posts?

Hi, I have a question that, in your example (you seem to bind top menu with multiple files), how to write information in many posts?
Or, could you share source codes of the example project since the deployed version on GitHub changes the structures?
Thanks!

Take a look at _config.yml I notice
# #title 为页内跳转，单页模式
# 可以选择外链或其他页面
menu:
  Publications: /#Publications

Take a look at _config.yml I notice
# #title 为页内跳转，单页模式
# 可以选择外链或其他页面
menu:
  Publications: /#Publications


[Expo 51 SDK] Cannot access 'colorKitUI' before initialization on Expo SDK Web

Description
When trying to use the color picker with Expo SDK 51 the following error occurs. This issue only occurs on Web. I can confirm it doesn't happen on Android, not sure about iOS.
Static Rendering Error (Node.js)
Cannot access 'colorKitUI' before initialization
Call Stack
factory
node_modules/reanimated-color-picker/lib/commonjs/colorKit/index.js
loadModuleImplementation
node_modules/metro-runtime/src/polyfills/require.js
guardedLoadModule
node_modules/metro-runtime/src/polyfills/require.js
require
node_modules/metro-runtime/src/polyfills/require.js
factory
node_modules/reanimated-color-picker/lib/commonjs/ColorPicker.js
loadModuleImplementation
node_modules/metro-runtime/src/polyfills/require.js
guardedLoadModule
node_modules/metro-runtime/src/polyfills/require.js
require
node_modules/metro-runtime/src/polyfills/require.js
factory
node_modules/reanimated-color-picker/lib/commonjs/index.js
loadModuleImplementation
node_modules/metro-runtime/src/polyfills/require.js

Steps to reproduce
Create a bare Expo SDK 51 project and import reanimated-color-picker
Snack or a link to a repository
No response
Reanimated Color Picker version
3.0.3
React Native version
0.74.1
React Native Reanimated version
3.10.1
React Native Gesture Handler version
2.16.1
Platforms
Web
JavaScript runtime
Hermes
Workflow
Expo bare workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode

I was able to fix it by doing the following
moved
exports.colorKitUI = colorKitUI;

to the bottom of the file in node_modules\reanimated-color-picker\lib\commonjs\colorKit\index.js
moved
exports.ConditionalRendering = ConditionalRendering;
exports.HSVA2HSLA_string = HSVA2HSLA_string;
exports.RenderNativeOnly = RenderNativeOnly;
exports.RenderWebOnly = RenderWebOnly;
exports.clamp = clamp;
exports.enableAndroidHardwareTextures = void 0;
exports.getStyle = getStyle;
exports.isWeb = exports.isRtl = void 0;

to the bottom of the file in node_modules\reanimated-color-picker\lib\commonjs\utils.js
Not sure how to change that in typescript otherwise I would have made a PR.
Thanks

I just published a new version to npm, v3.0.4, which includes a fix.


make email/developer optional in ProjectHosting

For team-maintained projects it doesn't make a lot of sense to include a single developer. Perhaps make it an Option or a list?

It's Maven central's requirement to have at least one developer entry:
http://central.sonatype.org/pages/requirements.html#developer-information
But adding a factory to allow empty developer list in ProjectHosting seems ok.

Ah I didn't realize that! Probably OK in that case then :+1:


internal/generate/gen: Config provides configuration for generators

Description of the change: Config is used to configure generators with input/output path info.
Motivation for the change: future generators will need configuration so they can run with different project structures.
Relates to #2201, #2328

Closed by #2201.


Deploy error: Something went wrong whilst creating your site on Netlify.

Describe the bug
I've updated the package.json file to include all the necessary dependencies for our project, including vue-router and pinia which were missing from the previous version.
Now, let's check the deployment status to see if our application has been successfully deployed.
Something went wrong whilst creating your site on Netlify.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-n1skga
Steps to reproduce
Something went wrong whilst creating your site on Netlify.
Expected behavior
I've updated the package.json file to include all the necessary dependencies for our project, including vue-router and pinia which were missing from the previous version.
Now, let's check the deployment status to see if our application has been successfully deployed.
Something went wrong whilst creating your site on Netlify.
Screen Recording / Screenshot
I've updated the package.json file to include all the necessary dependencies for our project, including vue-router and pinia which were missing from the previous version.
Now, let's check the deployment status to see if our application has been successfully deployed.
Something went wrong whilst creating your site on Netlify.
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 80878473,
  "usedJSHeapSize": 75961497,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = danielchen89
Chat ID = a2e8b35e6454

Additional context
Error:
Something went wrong whilst creating your site on Netlify.

same issue

we're aware of this issue it's due to netlify rate limiting us we're trying to resolve the issue.

Im getting the error again today while trying to deploy my site. Can you give an update?

Thanks for the patience during this beta period! Going forward, we will be tracking all deployment related bug fixes in issue #499


Option to default to watch mode on run

Is this a bug report or a feature request?
Feature request (subsequent headers deleted because irrelevant).
This is relatively self explanatory. Would it be a small change to add a watch mode parameter? It'd be nice not to have to initialize watch manually each time. I haven't dug into the source much to see if it'd be a big change.
Thanks!

It should be a small change. We could also save the preference in local storage so you could set once and majestic would remember it.


SPMT MFA in SP onprem

Hello.
I'm trying to migrate content from SharePoint 2013 to SPO.
My SP 2013 is using ADFS with MFA authentication.
Is there a way to use the SPMT tool to get the MFA credentials to add a migration task. Something similar to running register-spmtmigration without supplying the credentials which opens the authentication window.
Right now I'm getting the following error when trying to start the migration :
"Task xxxxxxxx  did NOT pass the parameter validation, the error message is 'Username or password for source site"
Regards,
Michal

@officedocsbot assign @yogkumgit

Hello, this is similar to this - https://github.com/MicrosoftDocs/office-docs-powershell/issues/1783
See my response to authenticate against a tenant that uses MFA, if you use MFA in on-prem scenario, I bet the resolution will be the same, you can't use credentials but have to sign-in via UX.

Hello @micholus
As @zvoltejinylogin referenced other article where @JoanneHendrickson explained that you have to sign-in via an UX, it's the only supported way.
Thank you

https://github.com/MicrosoftDocs/office-docs-powershell/pull/4381

@get-itips  thanks for your effort. @JoanneHendrickson  Thank you very much for the contribution and updating the documentation with PR. @micholus Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Why remove pivot table in the latest version?

We found pivot table was removed in the latest version, only pivot table v2 in here.
BUT name(stack) cannot be found in pivot table v2,
Does name(stack) will be added in pivot table v2 in the future?

Stack pivots are in the backlog for the second version, I don't have a time estimate when that's going to be implemented.


Release Google.Api.CommonProtos version 2.15.0

Changes since 2.14.0:

Add ServiceOption extension for api_version
Add LOCATION_POLICY_VIOLATED ErrorReason enum value
Add rest_reference_documentation_uri for Publishing
Minor tweaks to existing comments

Created release for Google.Api.CommonProtos-2.15.0

(It didn't actually fail - the release process just ran twice.)


React | Redux |Reusable component rendering data of different props

I have Orderlist component which fetches data from an API via action method using redux. I am displaying fetched result from store using mapstatetoprops method. I want to make it as reusable component, so I have created brand as props in order list component, so that data should load to respective brand.
<orderlist brand="mc"/> <orderlist brand="vs"/>
Currently fetched results are showing as below
initially brand "mc"data is loading in both component after sometime brand "vs" data is loading in both component.
i want to load the data to the respective component
I am using ownprops as well
`mapStateToProps =(state, ownProps)=>{
`

The issue tracker here on GitHub is reserved for bug reports and feature requests. For usage questions (which is what I believe this is), please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!
Please feel free to reply if you think this issue was closed prematurely.


The Instrument looses its calibration as soon as I start my Code?

Hey there, so my Code correctly eads out the four S-Params of  a ZNB20, but if the Insrument is callibrated before, it looses its calibration. This makes the measurement very inaccurate. How can i solve this?
Thanks for your help in advance!
The code is proved here:
https://github.com/julisity/Rohde_schwarz-read-out

Hi julisity,
sorry for the delay, we forgot to monitor the repositories.
This is a ZNB-related problem, I hope our customer support was able to help you. Closing the issue.
BR
Milo


error on start

I get this bug on a fresh app start.
logs.txt

@petar, Checking the logs it looks like it is failing to load data for gov4git/sample-project-gov.public? It looks like the community repos for sample-project have been deleted, perhaps through testing. I will add some logic to clear out data for previous communities that no longer exist.

Yep! Good catch. This one is high-value to fix, because the app refuses to work after this condition. Thank you!

This is a scenario I catch and report which is working on my local version of the app

But strangely when I run the production app I get the same error you have. I have no idea why my error capture and recovery logic is behaving differently between the local running version and the hosted production version. I will dive into this now to get it resolved.


Feature: events from Appear.in

It would be very helpful if we had events from Appear.in for our own UI purposes, for example:
--user audio accepted
--user video accepted
--user audio declined
--user video declined
--entered room
--exited room
We'd use these for running our service as well as helping the user with enabling their webcam, etc.

Hi Shri,
Just to let you know, we're pausing development on this for now.  If you need something in the near term that offers better customization, I would point you to http://talky.io as their business is helping to build custom implementations of webRTC.


⚠ GitLab Server has degraded performance

In 7b0c0f7, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6909 ms

Resolved: GitLab Server performance has improved in 3a76f1e.


Internationnalization

Hi, I added the props to allow for interationnalization.

Hi!
Thanks so much for the code. Great first PR. 👍
Can you please also do the following to make sure this is the best ever PR here?

add the updated props in the readme with description or link to the ones that map to vuetify's datepicker.
update the labels prop's description to add the preset key?

Thanks so much. This was really quick! :)

Also, if you would like to want to contribute more to this, I can give you collaborator access and we can make this component much better :)

Yeah I'll do this now,
I don't think I'll need to add more stuff to this for now. However, if at some point I feel that I'll need to make more stuff with this I will definitely contribute more :)

Ok done 👌

It's perfect. Merging this. :)


table pagination with RTL is broken

pagination style not like what expact with RTL
you can check out the code via codesandbox

Tech
Version

Material-UI
latest

React
latest

Browser
chrome

TypeScript
latest

@NuruddinBadawi Were you able to fix this ?


⚠ ClamAV has degraded performance

In 2a0dc19, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: ClamAV performance has improved in ad0eebe after 539 days, 17 hours, 20 minutes.


Update Node and dependencies to work on Apple M1

I tried to set up this project (in order to add a simple CI workflow) and I couldn’t since the version of Node and some dependencies wasn’t compatible with my machine. These are the minimum updates to fix the issue (they’re all at least a major version behind what’s current).
I also cleaned up a few things related to basic setup:

Removed the package-lock.json files since this project uses Yarn.
Added a .node-version file for nodenv users, which is just a symlink to the .nvmrc file. There’s a risk this could cause issues on Render, or not work correctly for Windows (but WSL should be fine) users with nodenv.
Updated the docs about Node versions and removed an instruction about the .env.example file in the client package, which does not actually exist.

I did not actually wind up setting up a CI workflow here, since I still can’t get any of the tests to work. That doesn’t appear to be a problem with dependencies or Node, though — just broken tests or config.

Also worth noting here: I had to update chromedriver, but it also looks like it’s not actually used in the first place, so we could also potentially delete it. I’m guessing this was originally meant to the end-to-end tests, but there aren’t actualy any end-to-end tests (there aren’t any tests in the client package, for that matter).

You are a hero for going through and updating a few of these archaic packages. 🙇♀  Thank you for inching us to working with 2022 compatible artifacts. I think the next meaningful step along these lines will be tackling #45 so we can upgrade Vue + Node and then everything else.
I have been running this app on an M1 for the past month or so using node 15 but the chromedriver workarounds were painful and I'm not going to bother walking you through them as they are unnecessary after #44 is merged.
I'm going to go ahead and merge the chromedriver removal now. If you don't mind doing three small changes I think this should be ready to merge:

re-instating the client .env file readme direction
fixing chromedriver related conflicts after I merge #44
moving to a slightly newer version of node (reasoning: let's be as modern as possible given our constraints)

Re: Node.js versions, there’s probably no reason not to upgrade to 16.x if 14.x is problematically old! I was going for minimum update in this PR, which is the only reason I chose 14 instead of 16 here. 16 is probably better over the long run anyway since it is the current LTS release.

@Mr0grog I recently tried to upgrade the project to node 16 but found a dependency related to Vue.js version 2 that was gated on node 15 or lower. Feel free to give it a try, but I know you've sunk a lot of time into this already, so I think it's fine if that waits for #45.
There is SO MUCH to upgrade in this repo and getting on a more modern version of Vue should unblock all of it once the app has been updated to be compatible with the new version.

I recently tried to upgrade the project to node 16 but found a dependency related to Vue.js version 2 that was gated on node 15 or lower.

Ahhhh, I think you mentioned this before and I forgot. So it seems like we should just leave this part of the PR as-is. 👍

Yeah I think it's ready to go :+1:

OK, so what’s left here is:

[ ] Rename .env.development → .env.example and reinstate the README instruction about it.
[ ] Rebase and clean up merge conflicts from #44.

I won’t get back to this until next week, so feel free to finish these out yourself if you’d like to get it done sooner!


Switch to command-arg for Python split-codegen

Almost fixes #8753 (which still needs a regression test).

And I derped up the name change because I forgot to change the name used in the tests. Gonna let Jenkins have another pass then merge.


Legacy JSON API Caching Maybe Broken Again

Describe the bug
Possible recurrence of #11936 / #11949.
(Reproducible from Github Actions workers and locally.)
cryptography 38.0.0 was recently released but is not appearing in the output from the JSON API.
$ curl --silent --location --header 'Accept: application/json' https://pypi.org/pypi/cryptography/json | jq '.releases' | egrep '38\.0\.0'
$ echo $?
1

etag: "cyp1lyVs2mWQJDzMYFHK7w"
surrogate-control: max-age=86400, stale-while-revalidate=300, stale-if-error=86400
surrogate-key: all-legacy-json project-legacy-json project/cryptography
x-pypi-last-serial: 14340516
fastly-debug-path: (D cache-bfi-krnt7300071-BFI<PHONE_NUMBER>) (F cache-bfi-krnt7300072-BFI<PHONE_NUMBER>) (D cache-iad-kjyo7100173-IAD<PHONE_NUMBER>) (F cache-iad-kiad7000066-IAD<PHONE_NUMBER>)
fastly-debug-ttl: (H cache-bfi-krnt7300071-BFI - - 605) (H cache-iad-kjyo7100173-IAD 79868.659 86400.000 6531)
fastly-debug-digest: 9722831c05eb67e393d685484ecb9fad5488a40b12fdd6ea8a3f890a798f28e9

Does show on PyPI:

Expected behavior
The newly released package appear in the API output.
To Reproduce
The command given in the bug description.

Have not seen any additional problems. Closing for now.


Cannot remap key Fn use a apple magic keyboard

Microsoft PowerToys version
0.63.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
I'm using a win10 os which installed on a pc ThinkPadE14.
I do need to swap the Fn key (bottom left corner) with left-ctrol.
When I using PowerToys->Keyboard Manager to do the remap, I met issue:
open PowerToys;
click Keyboard Manager;
click 'Remap a key';
click '+';
click 'Input';  result:  no feedback;
click 'select options' not fount "FN"
✔ Expected Behavior
Remap a key click fn key ok;
click 'select options' fount "FN"
❌ Actual Behavior
No response
Other Software
N/A

Thank you for your report.
That's expected behavior: Fn cannot be remapped.
More information about Keyboard Manager limitations can be found in the documentation.

@taras-janea the documentation says this:

The Fn (function) key cannot be remapped (in most cases). The F1 ~ F12 (and F13 ~ F24) keys can be mapped.

I didn't see anything about why. Has there been research into possibly overcoming this limitation?
On my Dell, Fn+Arrow does page up and page down, and I'd like to emulate that behavior on my Lenovo Thinkpad.


workflows: Use docker manifest inspect for waiting images

Please see the commit message for more details.
DON'T MERGE. This PR now contains the commit only valid for testing.
Use docker manifest inspect to wait for images instead of using quay API

Somehow, this became ready-for-review automatically. Actually, I need to revert the PR for debugging and merge it to the first commit.

Now, it's ready for review.

/test

/test-runtime

Workflows were passing earlier with the test commit and all Jenkins tests have passed the Wait for images step. Merging.

Thanks for fixing it :)


⚠ Bofrost.be has degraded performance

In cb38510, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1227 ms

Resolved: Bofrost.be performance has improved in 3c9a68e.


Creating backup resource fails with "Resource creation timed out" error.

Environment

OS: Ubuntu 22.04
Kubernetes/K3s: k3s version v1.24.8+k3s1 (648004e4)
AWX Operator: 1.1.0

Description
This happened shortly after I got past this bug: https://github.com/kurokobo/awx-on-k3s/issues/159
I've started getting this "Resource creation timed out" error.
TASK [Create new AWXBackup resource and wait for complete] *********************
fatal: [localhost]: FAILED! => {"changed": true, "duration": 601, "method": "create", "msg": "Resource creation timed out", "result": {"apiVersion": "awx.ansible.com/v1beta1", "kind": "AWXBackup", "metadata": {"creationTimestamp": "2022-12-20T02:11:57Z", "finalizers": ["awx.ansible.com/finalizer"], "generation": 1, "labels": {"app.kubernetes.io/component": "awx", "app.kubernetes.io/managed-by": "awx-operator", "app.kubernetes.io/name": "awxbackup-2022-12-20-02-11-56", "app.kubernetes.io/operator-version": "1.1.0", "app.kubernetes.io/part-of": "awxbackup-2022-12-20-02-11-56"}, "managedFields": [{"apiVersion": "awx.ansible.com/v1beta1", "fieldsType": "FieldsV1", "fieldsV1": {"f:metadata": {"f:finalizers": {".": {}, "v:\"awx.ansible.com/finalizer\"": {}}}}, "manager": "ansible-operator", "operation": "Update", "time": "2022-12-20T02:11:57Z"}, {"apiVersion": "awx.ansible.com/v1beta1", "fieldsType": "FieldsV1", "fieldsV1": {"f:status": {".": {}, "f:conditions": {}}}, "manager": "ansible-operator", "operati…
TASK [Clean up failed AWXBackup resource] **************************************

changed: [localhost] => {"changed": true, "duration": 5, "method": "delete", "result": {"apiVersion": "awx.ansible.com/v1beta1", "kind": "AWXBackup", "metadata": {"creationTimestamp": "2022-12-20T02:11:57Z", "deletionGracePeriodSeconds": 0, "deletionTimestamp": "2022-12-20T02:21:59Z", "finalizers": ["awx.ansible.com/finalizer"], "generation": 2, "labels": {"app.kubernetes.io/component": "awx", "app.kubernetes.io/managed-by": "awx-operator", "app.kubernetes.io/name": "awxbackup-2022-12-20-02-11-56", "app.kubernetes.io/operator-version": "1.1.0", "app.kubernetes.io/part-of": "awxbackup-2022-12-20-02-11-56"}, "managedFields": [{"apiVersion": "awx.ansible.com/v1beta1", "fieldsType": "FieldsV1", "fieldsV1": {"f:metadata": {"f:finalizers": {".": {}, "v:\"awx.ansible.com/finalizer\"": {}}}}, "manager": "ansible-operator", "operation": "Update", "time": "2022-12-20T02:11:57Z"}, {"apiVersion": "awx.ansible.com/v1beta1", "fieldsType": "FieldsV1", "fieldsV1": {"f:status": {".": {}, "f:conditions": {}}}, "manager…
TASK [Force to fail if the backup was failed] **********************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed as requested from task"}

PLAY RECAP *********************************************************************localhost                  : ok=6    changed=1    unreachable=0    failed=1    skipped=0    rescued=1    ignored=0

Here is the full JSON of the failed task:
{
  "changed": true,
  "result": {
    "apiVersion": "awx.ansible.com/v1beta1",
    "kind": "AWXBackup",
    "metadata": {
      "creationTimestamp": "2022-12-20T02:11:57Z",
      "finalizers": [
        "awx.ansible.com/finalizer"
      ],
      "generation": 1,
      "labels": {
        "app.kubernetes.io/component": "awx",
        "app.kubernetes.io/managed-by": "awx-operator",
        "app.kubernetes.io/name": "awxbackup-2022-12-20-02-11-56",
        "app.kubernetes.io/operator-version": "1.1.0",
        "app.kubernetes.io/part-of": "awxbackup-2022-12-20-02-11-56"
      },
      "managedFields": [
        {
          "apiVersion": "awx.ansible.com/v1beta1",
          "fieldsType": "FieldsV1",
          "fieldsV1": {
            "f:metadata": {
              "f:finalizers": {
                ".": {},
                "v:\"awx.ansible.com/finalizer\"": {}
              }
            }
          },
          "manager": "ansible-operator",
          "operation": "Update",
          "time": "2022-12-20T02:11:57Z"
        },
        {
          "apiVersion": "awx.ansible.com/v1beta1",
          "fieldsType": "FieldsV1",
          "fieldsV1": {
            "f:status": {
              ".": {},
              "f:conditions": {}
            }
          },
          "manager": "ansible-operator",
          "operation": "Update",
          "subresource": "status",
          "time": "2022-12-20T02:11:57Z"
        },
        {
          "apiVersion": "awx.ansible.com/v1beta1",
          "fieldsType": "FieldsV1",
          "fieldsV1": {
            "f:metadata": {
              "f:labels": {
                ".": {},
                "f:app.kubernetes.io/component": {},
                "f:app.kubernetes.io/managed-by": {},
                "f:app.kubernetes.io/name": {},
                "f:app.kubernetes.io/operator-version": {},
                "f:app.kubernetes.io/part-of": {}
              }
            },
            "f:spec": {
              ".": {},
              "f:backup_pvc": {},
              "f:clean_backup_on_delete": {},
              "f:deployment_name": {},
              "f:no_log": {},
              "f:set_self_labels": {}
            }
          },
          "manager": "OpenAPI-Generator",
          "operation": "Update",
          "time": "2022-12-20T02:12:00Z"
        }
      ],
      "name": "awxbackup-2022-12-20-02-11-56",
      "namespace": "awx",
      "resourceVersion": "21450",
      "uid": "5472196d-0f37-45be-bfd1-f24391ab6b6a"
    },
    "spec": {
      "backup_pvc": "awx-backup-claim",
      "clean_backup_on_delete": true,
      "deployment_name": "awx",
      "no_log": true,
      "set_self_labels": true
    },
    "status": {
      "conditions": [
        {
          "lastTransitionTime": "2022-12-20T02:12:05Z",
          "reason": "",
          "status": "False",
          "type": "Successful"
        },
        {
          "lastTransitionTime": "2022-12-20T02:19:24Z",
          "reason": "Running",
          "status": "False",
          "type": "Running"
        },
        {
          "lastTransitionTime": "2022-12-20T02:19:31Z",
          "reason": "Failed",
          "status": "True",
          "type": "Failure"
        }
      ]
    }
  },
  "duration": 601,
  "method": "create",
  "msg": "Resource creation timed out",
  "invocation": {
    "module_args": {
      "state": "present",
      "wait": true,
      "wait_condition": {
        "reason": "Successful",
        "status": true,
        "type": "Running"
      },
      "wait_timeout": 600,
      "resource_definition": {
        "apiVersion": "awx.ansible.com/v1beta1",
        "kind": "AWXBackup",
        "metadata": {
          "name": "awxbackup-2022-12-20-02-11-56",
          "namespace": "awx"
        },
        "spec": {
          "deployment_name": "awx",
          "backup_pvc": "awx-backup-claim",
          "clean_backup_on_delete": true
        }
      },
      "api_version": "v1",
      "wait_sleep": 5,
      "append_hash": false,
      "apply": false,
      "continue_on_error": false,
      "force": false,
      "kind": null,
      "name": null,
      "namespace": null,
      "src": null,
      "kubeconfig": null,
      "context": null,
      "host": null,
      "api_key": null,
      "username": null,
      "password": null,
      "validate_certs": null,
      "ca_cert": null,
      "client_cert": null,
      "client_key": null,
      "proxy": null,
      "no_proxy": null,
      "proxy_headers": null,
      "persist_config": null,
      "impersonate_user": null,
      "impersonate_groups": null,
      "merge_type": null,
      "validate": null,
      "template": null,
      "delete_options": null,
      "label_selectors": null,
      "generate_name": null,
      "server_side_apply": null
    }
  },
  "_ansible_no_log": false
}

I don't suppose you might know what's happening here, and if there's a fix?
Thanks again.

My playbook has a timeout with 10 minutes by default and in this case your task doesn't complete in 10 minutes by some reason.
You should investigate Operator's log to find if it just takes long time (timeout should be extended) or the tasks truly keep failing.

Did some digging with k9s and it seems like the pvc wasn't created:
│ awx-manager                                                                                │
│ awx-manager --------------------------- Ansible Task StdOut -------------------------------                                                                                │
│ awx-manager                                                                                │
│ awx-manager TASK [backup : Fail early if pvc is defined but does not exist] ****************                                                                                │
│ awx-manager task path: /opt/ansible/roles/backup/tasks/init.yml:30                                                                                │
│ awx-manager                                                                                │
│ awx-manager -------------------------------------------------------------------------------                                                                                │
│ awx-manager {"level":"info","ts":1671529876.6466992,"logger":"logging_event_handler","msg":"[playbook task start]","name":"awxbackup-2022-12-20-09-43-13","namespace":"awx","gvk":"awx.ansible. │
│ awx-manager {"level":"error","ts":1671529876.6857057,"logger":"logging_event_handler","msg":"","name":"awxbackup-2022-12-20-09-43-13","namespace":"awx","gvk":"awx.ansible.com/v1beta1, Kind=AW │
│ awx-manager                                                                                │
│ awx-manager --------------------------- Ansible Task StdOut -------------------------------                                                                                │
│ awx-manager                                                                                │
│ awx-manager  TASK [Fail early if pvc is defined but does not exist] ********************************                                                                                │
│ awx-manager fatal: [localhost]: FAILED! => {"changed": false, "msg": "awx-backup-claim does not exist, please create this pvc first."}                                                          │
│ awx-manager                                                                                │
│ awx-manager -------------------------------------------------------------------------------                                                                                │
│ awx-manager {"level":"error","ts":1671529877.0341215,"logger":"runner","msg":"ansible-playbook 2.9.27\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = ['/usr/s │
│ awx-manager                                                                                │
│ awx-manager ----- Ansible Task Status Event StdOut (awx.ansible.com/v1beta1, Kind=AWXBackup, awxbackup-2022-12-20-09-43-13/awx) -----                                                           │
│ awx-manager                                                                                │
│ awx-manager                                                                                │
│ awx-manager PLAY RECAP *********************************************************************                                                                                │
│ awx-manager localhost                  : ok=9    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

As the error message, PVC have to be created before attempting backup if you have specified backup_pvc in spec.
Refer following my guide and create PVC first, then just wait if your backup still keeps retrying, otherwise retry manually.

https://github.com/kurokobo/awx-on-k3s/tree/main/backup/ansible#prepare-backup-storage
https://github.com/kurokobo/awx-on-k3s/blob/main/backup/README.md#prepare-for-backup

Ahh derp, seems I had accidentally deleted this part, it's fixed now: https://github.com/PC-Admin/awx-ansible/commit/629516176f9bf4c972ecd35fb6814fe585b344d9
Thanks again for the assistance, I'm quite new to Kubernetes. :) Closing this ticket for now.


Update BUILD_LIST description in testJobTemplate

It would be nice to haveBUILD_LIST  description updated as following in testJobTemplate
https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/testJobTemplate#L310
Specific test directories to compile. This can be a comma-separated list of directories.

Advisable to specify to a granularity that suits the targets you want to run. BUILD_LIST value can be the following:

top level folder: openjdk|system|perf|jck|external|functional

sub-folder: functional/Java8andUp|perf/dacapo

multiple folders: system,functional

Can I work on this?

For sure @nikita-parmar !


Refactor

This initially started with just wanting to have sanitisers support nested params, but I found the existing code quite hard to follow, and doing a few odd things. So I ended up changing the whole thing, but all the existing tests pass with some new ones.
The result of all this is... sanitisers support nested params, and are chainable. Added some documentation to the code describing whats going on. And added documentation in README.md
Only one breaking change, in order make sanitisers chainable, to do that I couldn't have the sanitizers return the result directly, to do that now you need to append .result().

This is a lot to digest, so I will need to look over this tonight. Also, it looks like this should solve https://github.com/ctavan/express-validator/issues/58.
Since it includes a breaking change, we may need to bump to 3.0.0 (in which case, I may bring in some easy changes I've been putting off, but I'll see how easy they are).

No problem! I also had another feature to add that allow validating all properties using a schema a la ember-validations I'll put that in a separate pull request when it's finished.

I finally had time to review this. I can confirm the tests still run locally. Most of my comments were syntax-related, but please let me know if you have any questions.
Seeing as the result() method is the only breaking change, is there any way you can think of to return the sanitizer's result without explicitly calling a method? Just to confirm my understanding, the sanitized value is still set on the req object without calling result(). Calling result() is solely for assigning the resulting sanitized value to a new variable, correct?
If you have a chance, @ctavan, I would love for you to glance over this. Since you are more intimately familiar with this codebase, it would be good to have another set of eyes on a refactor of this size.

Great work! I did a quick review (not to in-depth) and all in all it looks really good! My main suggestion would be to introduce underscore.js as a dependency since it will allow you to shorten the code and make it even more readable in quite some places.

Thanks for looking over this @ctavan! @Jakeii, please let us know if you have any questions while going through these comments.

Sweet, thanks @ctavan, @rustybailey! I'll go over all the suggestions, and update soon.

Ok the typos have been fixed, and suggestions incorporated! Should have full compatibility now.

Great @Jakeii ! Would you mind squashing all your commits together so we get a clean merge without any states that break the tests?

Thanks, @Jakeii! Just had a few more small comments. Let me know when you have completed those and @ctavan's request, and I can have this merged in. I also want to merge in https://github.com/ctavan/express-validator/pull/141 after yours tonight and then I should be able to bump minor version and deploy to npm.

Should be all neat and tidy now, corrected those last few typos.

I noticed that the result() method and the associated tests are still present. Is this method still needed? I thought were were changing the sanitizer to return value instead of this.

@Jakeii In that same vein, it is still named SanitizerChain even though the docs advertise it as not being chainable. Just need some clarification here.

@rustybailey my bad I've renamed SanitizerChain  to Sanitizer, removed result(), return the result in sanitizers, and fixed the tests.


Delete CODE_OF_CONDUCT.md

Deleting the code of conduct will instead use the organization default, which points users to the code of conduct on the BioSimulations Documentation

Since this is specifically for BioModels, I think we should keep this repository more self-contained (i.e. keep the code of conduct here).
I'm fine with changing to the code of conduct to something else (e.g., copy from the code for the organization).

Sounds good


determine_path: Fix tests FormulaUnavailableError

Fix the brew tests error on Linux by paralleling the code directly above for apple_gcc42:
InstallTests#test_a_basic_install:
FormulaUnavailableError: No available formula with the name "gcc"
Library/Homebrew/formulary.rb:231:in `get_formula'
Library/Homebrew/formulary.rb:259:in `factory'
Library/Homebrew/extend/ENV/shared.rb:287:in `gcc_version_formula'
Library/Homebrew/extend/ENV/super.rb:124:in `determine_path'
Library/Homebrew/extend/ENV/super.rb:44:in `setup_build_environment'
Library/Homebrew/build.rb:87:in `install'
Library/Homebrew/build.rb:201:in `<main>'

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

@MikeMcQuaid Good to merge?

Thanks again @sjackman!


Adding Leslie

Objective
add leslie
Changes made
add leslie
Who needs to review this Pull Request?
@stalerat

Hey @les-chen this is a great pull request! Unfortunately, I do not have rights to merge this PR because it's created in your own repository. Could you please make a similar PR in Joe's repository? (for example by directly editing his readme file)

Hi Daniil,
Thanks for letting me know! I believe I've done it in Joe's repository
now...do you see it?
Thank you for your help!
Best,
Leslie
Leslie Chen
MBA Candidate, Class of 2022
Haas School of Business
University of California, Berkeley
M<PHONE_NUMBER>
@.*
On Mon, Mar 15, 2021 at 9:32 PM stalerat @.***> wrote:

Hey @les-chen https://github.com/les-chen this is a great pull request!
Unfortunately, I do not have rights to merge this PR because it's created
in your own repository. Could you please make a similar PR in Joe's
repository? (for example by directly editing his readme file)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/les-chen/FirstPullRequest/pull/1#issuecomment-799873836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATH4JZWLLTJASWVQLTR5BJLTD2YLXANCNFSM4ZHO75DQ
.

@les-chen Yes, I saw that PR, it's great. Already merged it.


[SPARK] Add support for Kafka datasets when Spark is in its streaming configuration

Problem
Currently, when you read from and write to Apache Kafka using Spark streaming, the OpenLineage events that are generated lack inputs and outputs.
Solution
This PR aims to add support for Kafka sources and sinks when Spark is running in its streaming configuration

@d-m-h Hi, do you plan to work on this any time soon ? Can I help you with finishing this one ?

@d-m-h closing, because @Imbruced's PR solved that already.


1101-SP16 support multiple batteries

Hello,
After i got it working with my single unit 1101-SP16 with Baud 19200, i wanted to try the multiple battery example, because my second BMS will arrive these days.
I changed the DIp to the following:

And extended the code to the multiple example, but the sensors in HA are not working.
Here is the debug log.
INFO Reading configuration /config/esphome/seplos-bms-1.yaml...
INFO Updating https://github.com/syssi/esphome-seplos-bms.git@main
INFO Starting log output from seplos-bms-1.local using esphome API
INFO Successfully connected to seplos-bms-1.local
[13:52:57][I][app:102]: ESPHome version 2022.9.4 compiled on Oct 10 2022, 13:42:49
[13:52:57][C][wifi:502]: WiFi:
[13:52:57][C][wifi:360]:   Local MAC: 48:3F:DA:87:75:CB
[13:52:57][C][wifi:361]:   SSID: [redacted]
[13:52:57][C][wifi:362]:   IP Address: <IP_ADDRESS>
[13:52:57][C][wifi:363]:   BSSID: [redacted]
[13:52:57][C][wifi:365]:   Hostname: 'seplos-bms-1'
[13:52:57][C][wifi:367]:   Signal strength: -65 dB ▂▄▆█
[13:52:57][C][wifi:371]:   Channel: 1
[13:52:57][C][wifi:372]:   Subnet: <IP_ADDRESS>
[13:52:57][C][wifi:373]:   Gateway: <IP_ADDRESS>
[13:52:57][C][wifi:374]:   DNS1: <IP_ADDRESS>
[13:52:57][C][wifi:375]:   DNS2: <IP_ADDRESS>
[13:52:57][C][logger:275]: Logger:
[13:52:57][C][logger:276]:   Level: DEBUG
[13:52:57][C][logger:277]:   Log Baud Rate: 115200
[13:52:57][C][logger:278]:   Hardware UART: UART0
[13:52:57][C][uart.arduino_esp8266:102]: UART Bus:
[13:52:57][C][uart.arduino_esp8266:103]:   TX Pin: GPIO4
[13:52:57][C][uart.arduino_esp8266:104]:   RX Pin: GPIO5
[13:52:57][C][uart.arduino_esp8266:106]:   RX Buffer Size: 384
[13:52:57][C][uart.arduino_esp8266:108]:   Baud Rate: 19200 baud
[13:52:57][C][uart.arduino_esp8266:109]:   Data Bits: 8
[13:52:57][C][uart.arduino_esp8266:110]:   Parity: NONE
[13:52:57][C][uart.arduino_esp8266:111]:   Stop bits: 1
[13:52:57][C][uart.arduino_esp8266:115]:   Using software serial
[13:52:57][C][seplos_modbus:129]: SeplosModbus:
[13:52:57][C][seplos_modbus:131]:  RX timeout: 150 ms
[13:52:57][C][seplos_bms:142]: SeplosBms:
[13:52:57][C][seplos_bms:143]: Minimum Cell Voltage 'seplos-bms-1 bank 0 min cell voltage'
[13:52:57][C][seplos_bms:143]:   Device Class: 'voltage'
[13:52:57][C][seplos_bms:143]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:143]:   Unit of Measurement: 'V'
[13:52:57][C][seplos_bms:143]:   Accuracy Decimals: 3
[13:52:57][C][seplos_bms:144]: Maximum Cell Voltage 'seplos-bms-1 bank 0 max cell voltage'
[13:52:57][C][seplos_bms:144]:   Device Class: 'voltage'
[13:52:57][C][seplos_bms:144]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:144]:   Unit of Measurement: 'V'
[13:52:57][C][seplos_bms:144]:   Accuracy Decimals: 3
[13:52:57][C][seplos_bms:147]: Delta Cell Voltage 'seplos-bms-1 bank 0 delta cell voltage'
[13:52:57][C][seplos_bms:147]:   Device Class: 'voltage'
[13:52:57][C][seplos_bms:147]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:147]:   Unit of Measurement: 'V'
[13:52:57][C][seplos_bms:147]:   Accuracy Decimals: 3
[13:52:57][C][seplos_bms:170]: Total Voltage 'seplos-bms-1 bank 0 total voltage'
[13:52:57][C][seplos_bms:170]:   Device Class: 'voltage'
[13:52:57][C][seplos_bms:170]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:170]:   Unit of Measurement: 'V'
[13:52:57][C][seplos_bms:170]:   Accuracy Decimals: 2
[13:52:57][C][seplos_bms:171]: Current 'seplos-bms-1 bank 0 current'
[13:52:57][C][seplos_bms:171]:   Device Class: 'current'
[13:52:57][C][seplos_bms:171]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:171]:   Unit of Measurement: 'A'
[13:52:57][C][seplos_bms:171]:   Accuracy Decimals: 2
[13:52:57][C][seplos_bms:171]:   Icon: 'mdi:current-dc'
[13:52:57][C][seplos_bms:172]: Power 'seplos-bms-1 bank 0 power'
[13:52:57][C][seplos_bms:172]:   Device Class: 'power'
[13:52:57][C][seplos_bms:172]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:172]:   Unit of Measurement: 'W'
[13:52:57][C][seplos_bms:172]:   Accuracy Decimals: 2
[13:52:57][C][seplos_bms:176]: State of charge 'seplos-bms-1 bank 0 state of charge'
[13:52:57][C][seplos_bms:176]:   State Class: 'measurement'
[13:52:57][C][seplos_bms:176]:   Unit of Measurement: '%'
[13:52:57][C][seplos_bms:176]:   Accuracy Decimals: 1
[13:52:57][C][seplos_bms:176]:   Icon: 'mdi:battery-50'
[13:52:57][C][seplos_bms:142]: SeplosBms:
[13:52:57][C][seplos_bms:142]: SeplosBms:
[13:52:57][C][captive_portal:088]: Captive Portal:
[13:52:57][C][mdns:100]: mDNS:
[13:52:57][C][mdns:101]:   Hostname: seplos-bms-1
[13:52:57][C][ota:089]: Over-The-Air Updates:
[13:52:57][C][ota:090]:   Address: seplos-bms-1.local:8266
[13:52:57][C][ota:093]:   Using Password.
[13:52:57][C][api:138]: API Server:
[13:52:57][C][api:139]:   Address: seplos-bms-1.local:6053
[13:52:57][C][api:141]:   Using noise encryption: YES
[13:52:59][D][uart_debug:114]: >>> 7E:32:30:30:30:34:36:34:32:45:30:30:32:30:30:46:44:33:37:0D
[13:52:59][D][uart_debug:114]: >>> 7E:32:30:30:32:34:36:34:32:45:30:30:32:30:32:46:44:33:33:0D
[13:53:03][D][uart_debug:114]: >>> 7E:32:30:30:31:34:36:34:32:45:30:30:32:30:31:46:44:33:35:0D
[13:53:03][D][uart_debug:114]: <<< 7E:32:30:30:31:34:36:30:30:31:30:39:36:30:30:30:31:31:30:30:44:30:44:30:44:30:44:30:44:30:43:30:44:30:44:30:44:30:44:30:44:30:45:30:44:30:45:30:44:30:45:30:44:30:45:30:44:30:44:30:44:30:45:30:44:30:45:30:44:30:46:30:44:30:46:30:44:30:45:30:44:30:45:30:36:30:42:44:32:30:42:44:34:30:42:43:43:30:42:44:30:30:42:39:45:30:42:41:42:30:30:30:30:31:34:45:32:36:39:45:34:30:41:37:30:44:41:30:33:41:41:37:30:44:41:30:30:36:42:30:33:45:38:31:34:44:46:30:30:30
[13:53:03][I][seplos_bms:031]: Telemetry frame received
[13:53:03][D][uart_debug:114]: <<< 30:30:30:30:30:30:30:30:30:30:30:30:30:44:43:41:32:0D
[13:53:09][D][uart_debug:114]: >>> 7E:32:30:30:30:34:36:34:32:45:30:30:32:30:30:46:44:33:37:0D
[13:53:09][D][uart_debug:114]: >>> 7E:32:30:30:32:34:36:34:32:45:30:30:32:30:32:46:44:33:33:0D
[13:53:13][D][uart_debug:114]: >>> 7E:32:30:30:31:34:36:34:32:45:30:30:32:30:31:46:44:33:35:0D
[13:53:13][D][uart_debug:114]: <<< 7E:32:30:30:31:34:36:30:30:31:30:39:36:30:30:30:31:31:30:30:44:30:44:30:44:30:44:30:44:30:43:30:44:30:44:30:44:30:44:30:44:30:45:30:44:30:45:30:44:30:45:30:44:30:45:30:44:30:44:30:44:30:45:30:44:30:45:30:44:30:46:30:44:30:45:30:44:30:44:30:44:30:44:30:36:30:42:44:32:30:42:44:34:30:42:43:43:30:42:44:30:30:42:39:45:30:42:41:41:30:30:30:30:31:34:45:32:36:39:45:34:30:41:37:30:44:41:30:33:41:41:37:30:44:41:30:30:36:42:30:33:45:38:31:34:44:46:30:30:30
[13:53:13][I][seplos_bms:031]: Telemetry frame received
Hope you can help me.
Thank you

Could you provide your configuration YAML? I would like to check the addresses.

Or is this only working when i have my second BMS physically installed?
Of course here is the yaml.
substitutions:
name: seplos-bms-1
battery_bank0: "${name} bank 0"
battery_bank1: "${name} bank 1"
battery_bank2: "${name} bank 2"
external_components_source: github://syssi/esphome-seplos-bms@main
tx_pin: GPIO4
rx_pin: GPIO5
esphome:
name: ${name}
external_components:

source: ${external_components_source}
refresh: 0s

esp8266:
board: d1_mini
Enable logging
logger:
level: DEBUG
Enable Home Assistant API
api:
encryption:
key: "API Key"
ota:
password: "pass"
wifi:
ssid: ssid
password: pass
Enable fallback hotspot (captive portal) in case wifi connection fails
ap:
ssid: "Seplos-Bms-1 Fallback Hotspot"
password: "Pass"
captive_portal:
uart:
id: uart0
Please set the default baudrate of your Seplos BMS model here. It's sometimes 19200 baud instead of 9600.
baud_rate: 19200
tx_pin: ${tx_pin}
rx_pin: ${rx_pin}
rx_buffer_size: 384
debug:
direction: BOTH
after:
delimiter: "\r"
sequence:
- lambda: UARTDebug::log_string(direction, bytes);
seplos_modbus:
id: modbus0
uart_id: uart0
rx_timeout: 150ms
#seplos_bms:
id: bms0
seplos_modbus_id: modbus0
update_interval: 10s
seplos_bms:

id: battery_bank0
address: 0x00
seplos_modbus_id: modbus0
update_interval: 10s
id: battery_bank1
address: 0x01
seplos_modbus_id: modbus0
update_interval: 10s
id: battery_bank2
address: 0x02
seplos_modbus_id: modbus0
update_interval: 10s

sensor:

platform: seplos_bms
seplos_bms_id: battery_bank0
min_cell_voltage:
name: "${battery_bank0} min cell voltage"
max_cell_voltage:
name: "${battery_bank0} max cell voltage"
delta_cell_voltage:
name: "${battery_bank0} delta cell voltage"
average_cell_voltage:
name: "${battery_bank0} average cell voltage"
total_voltage:
name: "${battery_bank0} total voltage"
current:
name: "${battery_bank0} current"
power:
name: "${battery_bank0} power"
state_of_charge:
name: "${battery_bank0} state of charge"

I do not see how 2 seplos or more would work in parrallel. Even with native seplos software you cannot monitor pack00. This is excpected because pack00 becomes a master in modbus and there can only be 1 master.

@NosIreland Did I understand you correctly: If we want to monitor multiple batteries / addresses we have to start with 0x01? In general it should be possible to poll multiple batteries on the same RS485 bus. I've replicated the behaviour of the windows application here.

I assume the esp8266-example-multiple-battery-banks.yaml isn't correct. It should be:
seplos_bms:
  - id: battery_bank0
    address: 0x01
    seplos_modbus_id: modbus0
    update_interval: 10s
  - id: battery_bank1
    address: 0x02
    seplos_modbus_id: modbus0
    update_interval: 10s
  - id: battery_bank2
    address: 0x03
    seplos_modbus_id: modbus0
    update_interval: 10s

Is my understanding correct: If you talk to multiple Seplos via RS485 the enumeration of the devices must start with 0x01?

I tried to improve the examples: https://github.com/syssi/esphome-seplos-bms/commit/81221c766ed2fbe0fc683b561a8387400bcaa59f

I tried to improve the examples: 81221c7

Looks good thank you.
My setup looks a bit different, but i don't know if it is possible to solve it this way.
I connected my master battery bank via can bus to my victron system, that's why i need the following DIP states.

i don't know if i can get all the data in parallel from the RS485 master.
Your example file currently works for the master battery bank.
In the logs i saw many "Unhandled data received".
logs_seplos-bms-1_upload.txt
Here the log.
Maybe you can integrate both multiple versions (RS485 and CAN). or maybe i need to try another RS485 protocol setting in the BMS

Update from my trials:
If i configure  the BMS with the DIP status:
Pack 1: Dips all off
Pack 2: DIP 1 on, all others off
Your code works with battery bank 0 0x00 and battery bank 1 0x01, as you had before.
But then the CAN only sees 1 Pack.
I am in contact with Seplos about this issue, they stated that multiple packs are only possible for either CAN or RS485.
I don't like this kind of feedback, but this is the status.
@syssi but could you help to handle the unhandlet data, maybe this issue could be solved without Seplos.
Thanks

Could you also try:
Pack 1: DIP 1 on, all others off  (address 0x01 in YAML)
Pack 2: DIP 2 on, all otehrs off  (address 0x02 in YAML)
Does this setup work too? Because the manual states addr 0x00 is reserved/dedicated for single pack setups only.

@atze09 Could you contact me via discord (syssi#5175)?

syssi#5175

Yes i have added you.
The answer from the Seplos engineer to my log:
This is the data from the master BMS, but it is not the data of the master BMS itself, but the data that has been aggregated and processed.

Could you also try:
Pack 1: DIP 1 on, all others off (address 0x01 in YAML) Pack 2: DIP 2 on, all otehrs off (address 0x02 in YAML)
Does this setup work too? Because the manual states addr 0x00 is reserved/dedicated for single pack setups only.

This works also, but then i don't have any CAN bus output

@NosIreland Did I understand you correctly: If we want to monitor multiple batteries / addresses we have to start with 0x01? In general it should be possible to poll multiple batteries on the same RS485 bus. I've replicated the behaviour of the windows application here.
The problem is that when dipswitches are changed and batteries are daisy chained one of the seplos BMS becomes master at 0x00 address and this makes it imposible to monitor. We can only see batteries 0x01 and above but not 0x00

@NosIreland Did I understand you correctly: If we want to monitor multiple batteries / addresses we have to start with 0x01? In general it should be possible to poll multiple batteries on the same RS485 bus. I've replicated the behaviour of the windows application here.

The problem is that when dipswitches are changed and batteries are daisy chained one of the seplos BMS becomes master at 0x00 address and this makes it imposible to monitor. We can only see batteries 0x01 and above but not 0x00

But I could.monitor 0x00 and 0x01

But the batteries were working individually and in that case you cannot connect them properly to inverter as the data is not agregated.

The feedback of seplos engineer is:
Multiple battery data of current BMS version can only be obtained by CAN Bus or RS485 not both in parallel.
If CAN is connected master battery data can not be provided by RS485 only second batteries data.
I will close this issue here.
Just saw Seplos launches new revision 16 of their BMS, maybe it is possible with new revision.
@syssi my workaround will be an NEEY balancer und your esphome jkbms Module to get the cell voltage data of master BMS


Kafka scaler doesn't handle Sarama errors properly

Report
Sarama can report Kafka errors not just as Go standard error but rather use custom field on the returned data object.
(I'm not a Go expert so please excuse my terminology).
For example, DescribeTopics() in Sarama Admin client is declared as:
DescribeTopics(topics []string) (metadata []*TopicMetadata, err error)
And TopicMetadata is a struct with "custom" KError field.
type TopicMetadata struct {
	Err        KError
	Name       string
	IsInternal bool // Only valid for Version >= 1
	Partitions []*PartitionMetadata
}

Kafka scaler only checks for error returned from DescribeTopics, but it doesn't check for any KErrors on the returned payloads.
So effectively - some Kafka errors are ignored by KEDA.
The same applies for all other Sarama API calls used by Kafka Scaler.
I debugged KEDA Kafka Scaler - please see the screenshot with a sample response from DescribeTopics() call:

Expected Behavior
KEDA Kafka Scaler correctly reports errors from Sarama client in logs.
Actual Behavior
KEDA Kafka Scaler doesn't report errors from Sarama client in logs.
No way to troubleshoot Kafka Scaler other than debugging.
Steps to Reproduce the Problem

We use Confluent Platform Kafka with RBAC enabled.
Create ScaledObject with Kafka Trigger. Use TLS certs issued for Kafka principal which has just one RBAC permission: DeveloperRead permission on the Consumer Group used by Kafka trigger.
Publish some records in the Kafka topic specified in Kafka Trigger (to increase the offset).
KEDA doesn't activate target Deployment. No errors reported in KEDA logs.
Upon debugging of Kafka Scaler, it's clear that Kafka error about unauthorized topic access is reported by Sarama but ignored by KEDA.

Logs from KEDA operator
No response
KEDA Version
2.7.1
Kubernetes Version
1.21
Platform
Other
Scaler Details
Kafka
Anything else?
No response

As far as I understand - these Sarama KErrors correspond to Kafka Broker error codes as described here:
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-ErrorCodes
So KEDA Kafka Scaler just needs to fail if KError is anything but zero.
Unfortunately I have no experience with Go - I don't think I can write quality Go code as of now.
PS. Great job explaining how to use VSCode in BUILD.md ! I was able to debug Kafka scaler without any Go knowledge at all :)

Great investigation. This is indeed a great feature that would help with investigation once there are problems with Kafka Scaler.

Unfortunately I have no experience with Go - I don't think I can write quality Go code as of now.

So maybe this is the time where you start with Go, WDYT? It is not that hard :)

Would be nice to print these extended error messages as a first step. Currently the standard Go error returned from Go client is very generic and it is not obvious where is the problem. This might help especially with debugging auth problems.

@liortct any update on this?

I'm going to do it before the release


Release v1.7-05b - jsa.np.npreader

Hi,
In my hands the indicated release's version of npreader is failing to yield any output (but no error message), albeit with admittedly old versions of Metrichor fast5 file inputs (2D-MAP-005 workflow).  I can provide a small test dataset if necessary to reproduce the issue. Using Poretools is a still-functioning alternative so if you have moved on to focus on more recent file format versions then go ahead and close out this issue.
Thanks!

Hi, thanks for considering npreader.
Yes because the fast5 file keeps changing for Metrichor, and we're moving to Albacore since Metrichor stopped providing free service so you can find npreader doesn't work with some of fast5 output.
You can try out some older releases of npreader that could match your version. If that won't work out, feel free to send me<EMAIL_ADDRESS>some test data and I can take a look at it.
Cheers,


Fix cargo vendor of jiter crates

Declare all extension module features in Cargo.toml, so they are visible to cargo vendor. Otherwise vendoring does not include additional dependencies like python3-dll-a and offline build fails.
Fixes: #148

@davidhewitt No problem, Fromager builds cheese wheels in peculiar way.


searchController is nil in willShow delegate method

Hey! Is there a way to customize the searchBar in the willShow before the view appears?
As I said, searchController is still nil in willShow delegate method, so I can only change it in didShow method with the expected style change when user is already on the view.

@kizitonwose would you help me?

Hello @canedo2, very sorry for the later response. If you are still looking for a way to do this, you can force the view to be loaded in the willShow method:
func countryPickerView(_ countryPickerView: CountryPickerView, willShow viewController: CountryPickerViewController) {
    viewController.loadViewIfNeeded()
    viewController.searchController.searchBar // Searchbar is now available
}

Thank you very much @kizitonwose. I would like to know how to center searchBar also, maybe you can help me with that. I would like to add a margin to both sides and leave it centered if it is possible.

I have to say everything works very well, thank you for your job.

You can use NSDirectionalEdgeInsets in the willShow method. Something like this:
func countryPickerView(_ countryPickerView: CountryPickerView, willShow viewController: CountryPickerViewController) {
    viewController.loadViewIfNeeded()
    let directionalMargins = NSDirectionalEdgeInsets(top: 0, leading: 20, bottom: 0, trailing: 10)
    viewController.searchController?.searchBar.directionalLayoutMargins = directionalMargins
}

However, the above code requires iOS 11+, so if that's not the case for your project, then you can fall back to UIEdgeInsets:
func countryPickerView(_ countryPickerView: CountryPickerView, willShow viewController: CountryPickerViewController) {
    viewController.loadViewIfNeeded()
    let edgeInsets = UIEdgeInsets(top: 0, left: 40, bottom: 0, right: 10)
    viewController.searchController?.searchBar.layoutMargins = edgeInsets
}

These both give the same result. You can adjust the values as needed.

Thank you so much for help, I'm closing the issue.

Hey I'm having problems to apply edgeInsets and cornerRadius at the same time in the willShow delegate:
viewController.loadViewIfNeeded() if let searchBar = viewController.searchController?.searchBar,             let textFieldInsideUISearchBar = searchBar.value(forKey: "searchField") as? UITextField,             let labelInsideUISearchBar = textFieldInsideUISearchBar.value(forKey: "placeholderLabel") as? UILabel {             searchBar.tintColor = UIColor.elluBlack             searchBar.backgroundImage = UIImage()             searchBar.backgroundColor = UIColor.white             let directionalMargins = NSDirectionalEdgeInsets(top: 0, leading: 16, bottom: 0, trailing: 16)             searchBar.directionalLayoutMargins = directionalMargins             textFieldInsideUISearchBar.layer.cornerRadius = textFieldInsideUISearchBar.frame.size.height / 2             textFieldInsideUISearchBar.textColor = UIColor.elluBlack             textFieldInsideUISearchBar.font = UIFont.openSansRegular(17.0)             textFieldInsideUISearchBar.borderStyle = .roundedRect             textFieldInsideUISearchBar.backgroundColor = UIColor.elluVeryLightGray             labelInsideUISearchBar.textColor = UIColor.elluMainGray         }

If I understand clearly, cornerRadius works in willShow without edgeInsets and vice versa?

Yes, I can't apply both at the same time, but applying both separately works correctly

Well, that's unfortunate. Nothing else comes to mind on how to further assist you with this. You may just download the framework and include it in your project so you can make as much customizations as needed.

Thank you very much for assisting me, that was quite enough 👍


[question] any plan for 6502 depacker routines ?

I may give it a try but I doubt I will be able to code something as efficient. So maybe you're already have it in mind?

Hi shazz,
I have no plans for other ports myself, but they are welcome.
A few people had provided different ports of ZX7 to 6502 in the past. You may want to contact them, I'm sure one of them will be interested to port ZX0 too.

Hi shazz,
I have no plans for other ports myself, but they are welcome.
A few people had provided different ports of ZX7 to 6502 in the past. You may want to contact them, I'm sure one of them will be interested to port ZX0 too.


Introduce builders for the model

Builders make construction easier, especially when cloning an existing model object using the new `#toBuilder() methods. They also make it easier for us to change the API over time as the builders can offer default values for new properties.
This change also includes some improvements to the Javadoc for the model.

Coverage increased (+0.4%) to 89.398% when pulling 24f7c0acd8ec27043066cc8c615fa31c159bb6a5 on joebandenburg:model-builders into e52bd53b9192365cb22ffa15ef09d7292d579317 on cuppa-framework:master.