Native Video component for Android and iOS

Will there be a Native Video component for Android and iOS in the pipeline?
I've searched through all of the available components and none seem to deliver a native video player, iOS seems to have more support than Android. Just wondering if this will be considered?
Embedding WebViews just complicates things further with functionality, performance, styling etc...
Would be really awesome to have something  like <VideoAndroid> and <VideoIOS>

Check out https://github.com/brentvatne/react-native-video. It is quite good.

@facebook-github-bot answered

Closing this issue as @jsierles says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.


issue-metrics test 11 (roi-dashboard)

Description
Some description
Spec
What it do. Acceptance criteria and all that.
Copilot Prompts
A few statements or questions for Copilot
Target Date:  📆

Branch: issue-902


[Removal]: Obedient Neon Parrot

Hotspot Name
Obedient-Neon-Parrot
Hotspot b58 Address
11NbLU5DszXirT7QX4dWFFCDq5eiwGWNg79qqzWeDEECWfjr81X
Discord Handle
Sea123#3201
Hotspot Manufacturer
PantherX
Removal Reason
I bought this hotspot on the second hand market on March 26, 2022, total 10 hotspots, but not notice it was included in the denylist, I am buying the machine now to put it in the actual location, and did it right Deployment, without any cheating, please help me get removed from the denylist, thank you!
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Helium Team
Thank you very much for your contribution to the healthy development of the network. As a victim of buying banned hotspots, I sincerely hope that you can help us solve the problem of hotspots being included in the denylist. I have deployed the machine correctly, please help me Detected, and lifted the denylist, thanks again!

LOL wtf. you putting an indoor rated hotspot in the balcony, took a photo, and call it the day? This is really low effort trying to convince us your are not a cheater. Btw at least turn on the machine to make it more legit... All these pantherX hotspots you have posted will remain on denylist.


Fetch for domian objects that in ValueObject types doesn't work

Describe the bug
For example, we have class that has value object type property
public class DomainClass1 : AuditPersistentDomainObjectBase
{
    public virtual Component? Component { get; set; }
}

// where Component is
public class Component : ValueObject
{
    public virtual DomainClass2? DomainClass2 { get; protected set; }
}

And fetch for this classes structure doesn't work, inspite on Nnhibernate Support.
...
bll.GetUnsecureQueryable(f => f.SelectNested(x => x.Component ).Select(x => x!.DomainClass2)).ToList();
...

As result low performance and big amount of useless requests.
To Reproduce
For reproducing use same classes structure as described above
Expected behavior
Fetch must work, amount of requests to database must decrease

I don't think it's relate to GenGen repo :)
could you clarify please ?

I don't think it's relates to GenGen repo :) could you clarify please ?

Lol, please excuse me))


Added some styling to the form, also corrected the spellings from the…

… request form
Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Styling and spellings
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes #1
Added some css styling to the donator form
Added some corrections to the laptop request form
Checklist:

[x] My code follows the style guidelines of this project
[x] I have carefully reviewed my own code
[ ] I have commented my code
[x] I have updated any documentation

@shieldo , @gregdyke , @theseafaringturtle please review my code. I have only made changes to make the form easier to read following Abed's css styling.

LGTM!


Email address can sometimes go through if it's not valid

ex: something@gmail can, at least in some cases, get through the validation. It fails after that because Salesforce can't make a contact with it.

Another example is something@yahoocom.
It appears that the browser validation is less strict than the Salesforce validation.

Need to fix this issue on the server side. Figure out where Python is checking for valid email, and make that as strict as Salesforce validation is.

Because Stripe will flag invalid emails and we can catch them on the client, this is fixed in 9ba37456d9248b5ff2feeace3967b0e241e115df.


Implement signed integer NOT operator for new ACIR gen

Problem
ACIR gen of signed integer NOT operator is a todo
Happy Case
It is implemented
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

@guipublic can you also look into modifying brillig to match this too -- it currently assumes that the input is a boolean


[Chore] Update code paths in saltcorn-cli/README.md

Hello Tom! I hope you are doing fine. It's wonderful to see the increased activity in Saltcorn community.
I'm currently trying to get familiar with the whole project structure and hope that I may be able to take a few tickets.
However, when I was troubleshooting the deployment steps on my local machine, I came across this issue when I try to reach the corresponding code through readme, the project structure may have changed since it was initially added. Nevertheless, I probably should not update this file manually, considering we may have a small tool for updating all the package versions across all saltcorn files, and it is better to point the PR to a dev branch other than master.
Best regards,
Zihao

Hello @Atozzio! Good to hear form you! sorry that I misses this PR, will look now. Hope all is well with you!

@glutamate Apologies! I just got back from vacation.
I have update the oclif config and tested the urls by running the "prepack" command. It should work this time!
Also, I am planning to pick some random tickets from the issues list, are there any urgent ones or some tasks in the roadmap that seems to be beginner-friendly? I can start with them.

Do you mind rerun the failed job? The failed pytest case has passed locally, and we did not change any 2FA stuff in this PR.

Thank you, merged. @Atozzio are you still interested in security? We could talk about doing some interesting projects in there, like getting scanners into CI and improving the python security test suite


Weird drop down behavior in Reasons filter

Reasons drop down v stops working (nothing happens on clicking) after adding 2 reasons
If you add and remove reasons, then clicking on drop down gives no list

cc @kepta

Might be related to #51.

cc: @manoharuss who's been facing the same issue.

This is a bit tricky to fix. Deferring for later.

@tridip1931 can you take a look at this one?

Debugging
I believe this is the issue of the react-select library.
It kinda messes up when using Async
It also does not work in the Official Demo Page

Any thoughts on this?
cc:/ @kepta @batpad


Enhance connectivity Layer

[ ] Support minimal amount of udp ports
[ ] Improve connectivity and NAT logic

relates to #88


Custom server container registry

solves #712

@adriangonz is it all good now? please let me know if anything else is needed.

All looks good! Thanks for making the changes @saeid93 !


word topic representation

Hi jhlau, thanks for sharing your implementation.
You've provided way to obtain the document-topic representation, but I wonder where can I obtain the word-topic representation? For example if there are 128 topics, each word-topic representation has length=128, and all word-topic representations are saved in a vocab file of something like that.
Thanks!

--output_topic argument from tdlm_test.py will do the job.

--output_topic argument from tdlm_test.py will do the job.
Hi,
I see this argument in  tdlm_test.py
parser.add_argument("--output_topic", help="output file to save the topics (prints top-N words of each topic)")
It's like this argument will print relevant words for each topic. The word-topic representation for one word should be a vector with length=num_topics. And if the vocabulary contains n words, I'm expecting a matrix with dim= (n, num_topics) as the word-topic representation.

I see. You'll have to modify the code to get word-topic distribution. You can see how topic-word is generated here: https://github.com/jhlau/topically-driven-language-model/blob/master/tdlm_model.py#L146 (you'll need to transpose the matrix before you do the softmax at line 149, so you get a probability distribution over topics for each word).


cyanrip: init at 0.7.0

Motivation for this change
cyanrip: init at 0.7.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132071 at f9b4c9a3 run on x86_64-linux 1

1 package built successfully:

cyanrip

1 suggestion:

warning: meson-cmake
Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.
Near pkgs/applications/audio/cyanrip/default.nix:25:3:
   |
25 |   nativeBuildInputs = [ meson ninja pkg-config cmake ];
   |   ^


Online documentation for 1.7 still have cups-polld man page

Version: Web Site
CUPS.org User: relovett
https://www.cups.org/documentation.php/doc-1.7/man-cups-polld.html
There is documentation for the nonexistent BrowsePoll option and cups-polld daemon in 1.7.
https://www.cups.org/documentation.php?VERSION=1.7&INDEX=0&Q=
There is no documentation for cups-browsed{,.conf} available.
I was trying to find information on BrowseDeny for 1.7.

Removed.


Fixed "setState on unmounted component"

Although an unmount mechanism is implemented, we still get the "setState on unmounted component" error.
We have managed to find the problem lying in a typo of the lifecycle method name.
Instead of "componentWillUnMount" it should be "componentWillUnmount".
With this, the error disappears.

Thank you!


pull request for e2e test at 12/30/2016 02:56:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove *.la files

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The recipe license should not include the word "License".


D8: Program type already present: R

🐛 Bug Report
I am unable to run flutter run, due to the error :

D8: Program type already present: R

This is the full error from the terminal:

What went wrong:
Execution failed for task ':app:transformClassesWithMultidexlistForDebug'.
com.android.build.api.transform.TransformException: Error while generating the main dex list:
Error while merging dex archives:
Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: R

Reproduction steps
Configuration
This is my pubspec.yaml:
environment:
  sdk: ">=2.2.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  firebase_core: ^0.4.0+3
  cloud_firestore: ^0.12.3
  firebase_storage: ^3.0.1
  firebase_auth: ^0.11.1+6
  google_sign_in: ^4.0.2
  geolocator: ^5.0.0
  image_picker: ^0.6.0+8
  path: ^1.6.2
  cupertino_icons: ^0.1.2
  font_awesome_flutter: ^8.4.0

dev_dependencies:
  flutter_test:
    sdk: flutter

This is my app/build.gradle
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    compileSdkVersion 28

    lintOptions {
        disable 'InvalidPackage'
    }

    defaultConfig {
        multiDexEnabled true
        applicationId "com.example.app"
        minSdkVersion 16
        targetSdkVersion 28

        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }
}

flutter {
    source '../..'
}

dependencies {
    implementation 'android.arch.lifecycle:extensions:1.1.1'
    implementation "android.arch.core:runtime:1.1.1"
    implementation "android.arch.core:common:1.1.1"
    compile 'com.android.support:multidex:1.0.0'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'

}
apply plugin: 'com.google.gms.google-services'  // Google Play services Gradle plugin

Version: 5.0
OS: Windows 10
Platform:

[ ] :robot: Android

I was able to solve this issue by downgrading the gradle version in android/build.gradle.
before:
classpath 'com.android.tools.build:gradle:3.3.0'
after:
classpath 'com.android.tools.build:gradle:3.2.1'


How to Mock - Moq

I have a Request Handler that gets a IMediator injected via constructor injection (Autofac).  The request handler under test conditionally calls other Send messages internally.  I am trying to Mock the mediator injected using Moq and ensure that the send calls happen as expected.  I am unable to find examples of how to do this.  Can you provide and assistance or references as how to Mock the mediator to verify that the send call is made?
Thanks,
Brian

I dunno, I've never mocked the mediator.

@brianstanforth I think I understand what you're looking for. Here's one way to test that the Send method was called using Moq:
var fakeMediator = new Mock<IMediator>();
var fakedResult = new TestResult("blarg");
var mediator = new NestedMediator(fakeMediator.Object);

mediator.Send(new TestRequest());

fakeMediator.Verify(x => x.Send(It.IsAny<TestRequest>()));

Is this what you're looking to do? If not, can you share what you're trying, I have experience with both libraries. (Just never together)

@ChrisMissal That worked perfectly.  Thanks for your help!

Any updated information on this. I'd like to Moq my Mediators on v8.0.0, and the handlers no longer have a Imediatior as a parameter, so the above example does not apply.

Can you be more specific?  Mocking mediator would mean the handlers would not be called (instead the mock would be) and the handlers have never had IMediator as a parameter.

So I followed this example on stackoverflow () and the one above. In either one I need to pass the fakeMediator.Object - either to the Handler (1) or the NestedMediator (2) (which in my case is injected from the DI Services). This is where my confusion comes from, and why it looks like things has changed.

Passing the fakeMediator.Object to the Handler does not work as it expects the DbContext and IConfigurationProvider.
public Handler(ApplicationDbContext db, IConfigurationProvider configuration)
Mocking these seem comprehensive, so I am fairly certain that is not the right approach.

I have no idea on how to pass the fakeMediator.Object to the NestedMediator, or how to get it injected to my test.

I have no idea either - we don't mock MediatR in our tests.

I found a way to mock MediatR, when the nested mediator is not readily available. It is pretty simple actually:
//Arrange
var mediator = new Mock<IMediator>();
mediator.Setup(m => m.Send(It.IsAny<QueryModel>(), It.IsAny<CancellationToken>())).ReturnsAsync(It.IsAny<ExpectedResultModel>());

//Act
await mediator.Object.Send(new QueryModel());

//Assert
mediator.Verify(x => x.Send(It.IsAny<QueryModel>(), It.IsAny<CancellationToken>()));
}

I found a way to mock MediatR, when the nested mediator is not readily available. It is pretty simple actually, as I just use the mocked object with a setup that tells what is expected from a given query or command:
//Arrange
var mediator = new Mock<IMediator>();
mediator.Setup(m => m.Send(It.IsAny<QueryModel>(), It.IsAny<CancellationToken>())).ReturnsAsync(It.IsAny<ExpectedResultModel>());

//Act
await mediator.Object.Send(new QueryModel());

//Assert
mediator.Verify(x => x.Send(It.IsAny<QueryModel>(), It.IsAny<CancellationToken>()));

But this doesn't actually mock the Handler, right? I tested it and it seems Ok but I'm not sure if this is a legit test case..

Mocking the IMediator interface is only useful if you are unit testing the caller (most likely the controller for web projects).  You can unit test handlers just as you would any other service with dependencies.

Jimmy tends to do more of integration tests where the code is run as it would be run in production (or as close to it) and even connects to the database to inject data and run tests.  Unit testing is reserved for rich domain models in his projects.

here is a great video from one of his talks if you want more deets https://www.youtube.com/watch?v=v4jrYMsYSco

Mocking the IMediator interface is only useful if you are unit testing the caller (most likely the controller for web projects). You can unit test handlers just as you would any other service with dependencies.

It is possible in thicscase to test handlers for validation exceptions (becasue now validators are strictly related with invoking Mediator.Send method as one element of a behaviour pipeline)? Or unit testing is pointless in case of using CQRS/MediatR and better option is to just create integration tests ?

Unit testing isn't pointless but if your pipeline consists of complex business logic and validation then when unit testing the handlers alone you would have to assume that is in place and only unit test with valid data.  The validators can be unit tested themselves, but this is definitely why integration tests on the whole pipeline can be easier.

I've mocked it out OK, decided to use a callback on my test to record the command that was sent so that I can test the values sent by the sender of the command  are what I expected....
mockMediator.Setup(x => x.Send(It.IsAny<IRequest>(), It.IsAny()))
.Callback<IRequest, CancellationToken>((req, token) => commandSent = req as MyCommand)
.Returns(() => Task.FromResult(true));
Obviously you'd have to tweak that a bit and you could ditch the call back entirely if you didn't want it, or use verify


Post gets cut off if "<" or ">" are in the sent post

As the title says, you are unable to send "<" or ">" in a post.
The post is sent through, but anything after the "<" or ">" is cut off.
For example:
group.sendPost("Syntax: setcmd <command> <response>") will only send "Syntax: setcmd " as a message.
Edit: Did some testing and it seems this can be fixed by removing the if not html: on line 215 (and thus removing a tab on line 216)

If you go into your RecvPost definition and add:
if self.user == user: return
if post.post[0] == ".":   ##Here is the Prefix part
data = post.post[1:].split(" ", 1)
if len(data) > 1:
cmd, args = data[0], data[1]
else:
cmd, args = data[0], ""
You can use a command like in ch.py but without having to worry about the setcmd part. That's how I figured it out easier. Plus, it means you can do:
if cmd == "say" and len(args) > 0:
group.sendPost(args)
Hope I help you at all in figuring it out. :)

If you would like to test it out feel free to use my chlib base bot located in http://justarandomplaceyo.chatango.com

I already do that. I don't think you understand the issue.
Have your bot do this:
group.sendPost("this part will get sent<and this part won\'t")
Then you will see what the issue is.

Yeah I see what you mean. I missed that totally during my coding. More than likely the reason it is not sending is because when you use the > symbol it expects it to be the end of a html code as in: This is bolded text. For some reason with my version of chlib it doesn't send anything with what you had. Once I changed it to say  It sends perfectly fine. What you could try is when you send the command encase it in Apostrophes which as far as I know is how the commands are done.

This is due to the way chatango parses HTML in messages. In reality, it's only a problem with bots and custom clients because the default clients escape html in messages before sending them. By default, ch.py does this as well, but it is easy to disable allowing you to send html in messages.
This feature is disabled by default in chlib.py, if you want to enable it, causing all posts to (by default) escape html, you can change html=True to html=False in the group.sendPost definition on line 213
This will cause all messages to escape html by default, thus <font>, <br>, <b>, etc. will not work, and will show the html code in the message itself, but also <something>, <3, <Post post> will show, which would be the desired result.
If you expect a commands output to often contain < or > that are not html, you can disable html for an individual message by sending html=False as an argument to the group.sendPost function, this will effectively convert all < and > to < and > respectively, which appear in posts as < and >, but do not parse their content as html. Example:
group.sendPost("This is a <Post post>", html=False)
Also, the reason removing if not html: on line 215 fixes this, is that you are forcing the following line (which normally only occurs if you tell the function to not use html, hence "if not html:") to escape the html. If you always want the html to be escaped, this "works", but is not the proper method, the proper way would be to, again, change html=True to html=False in line 213, which would allow you to force html to work by sending html=True as an argument to the group.sendPost function.

Seems nothing needs to be done here, closing


Prometheus port annotation on service is using wrong port

Description
The service generated alongside with every function is nicely specifying annotations for prometheus based discovers.
However, the port specified in the annotations is pointing to the service port. It should be the targetPort. A scrape will fail using the specified port.
It should be like:
    prometheus.io/path: /metrics
    prometheus.io/port: "8080"
    prometheus.io/scrape: "true"

Expected result
Discovered metric endpoint based on prometheus annotations will return data

Actual result
Endpoint cannot be called

Steps to reproduce

Follow https://github.com/kyma-project/examples/blob/main/prometheus/prometheus.md to setup prometheus discovery.
Create a function
Go to the prometheus dashboard and see if the function is listed as a healthy target

Troubleshooting

Scraping function metrics works for me with PR #508.
During testing I observed that the service_name resource attribute of a function is set to <function-name>.<namespace>. We are currently attempting to unify this and removing the namespace since it is a separate attribute. For instance, here for Istio.

The service.name topic is already addressed with https://github.com/kyma-project/serverless/pull/503

I documented more findings on the initial  service name issue.

metrics port is fixed for new functions.
For existing functions we should add a logic into the serverless controller that would recreate k8s service with proper service port annotations.
We believe recreating service is easier than editing annotations as annotations are not to be edited ( by kubernetes client).


Roof Surfaces Double Geometries on QGIS: WHY?

Yooooooooo
I'm not that suave in my understanding of CityJSON models. What I did was filter out roof surfaces as an attribute of interest.
This is what I get:

Yes, the pale green is a nice touch, but upon calculating roof surface values through a DSM model, I realised there were duplicate geometries. So, I isolated the double geometries:

If semantic roof values are basically points and lines transformed on a coordinate, why are there double geometries present in the data? Is this just on QGIS or is this also the case on CityJSON?

Yo @misonishiki!
First of all, welcome to the CityJSON world. 🙏
I am not entirely sure that I understand your question. Semantic roof values aren't points or lines. They are attributes attached to the polygons of the roofs themselves.
I am, also, not sure why you are getting duplicate geometries. You said you filtered for roof surfaces only? Keep in mind that, whilst the data are 3D QGIS processing cannot cope with it correctly most of the times so it treats the geometries as 2D. So, if you left there both roof and ground surfaces, QGIS might be treating them as duplicates (because they have the same 2D projection).
Which model is this one? Could you possibly share the data? You might, also, want to inspect the geometry itself in 3D through ninja, to get a better understanding of how the geometry is stored.

Thanks for clarifying.
I just downloaded the dataset and checked and couldn't find any duplicate geometries. Here are my steps:

Import the dataset from the processing toolbox with the following parameters:

processing.run("cityjsonloader:loadcityjson", {'INPUT':'/Users/liberostelios/Downloads/3dbag_v210908_fd2cee53_3693.json','DIVIDE_BY_OBJECT_TYPE':False,'LOD_AS':2,'LOAD_SEMANTIC_SURFACES':True,'STYLE_BY_SEMANTIC_SURFACES':False,'SRID':QgsCoordinateReferenceSystem('EPSG:28992'),'BBOX':None,'OBJECT_TYPE':[]})

Extract by attribute (only for the LoD2.2 layer):

processing.run("native:extractbyattribute", {'INPUT':'memory://MultiPolygon?crs=EPSG:28992&uid={299850c6-62b8-48ca-80ce-023336c01264}','FIELD':'surface.type','OPERATOR':0,'VALUE':'RoofSurface','OUTPUT':'TEMPORARY_OUTPUT'})

Delete duplicate geometries:

processing.run("native:deleteduplicategeometries", {'INPUT':'memory://MultiPolygon?crs=EPSG:28992&field=uid:string(0,0)&field=type:string(0,0)&field=parents:string(1000,0)&field=children:string(1000,0)&field=attribute.dak_type:string(0,0)&field=attribute.data_area:string(0,0)&field=attribute.data_coverage:string(0,0)&field=attribute.documentnummer:string(0,0)&field=attribute.geconstateerd:string(0,0)&field=attribute.gid:string(0,0)&field=attribute.h_dak_50p:string(0,0)&field=attribute.h_dak_70p:string(0,0)&field=attribute.h_dak_max:string(0,0)&field=attribute.h_dak_min:string(0,0)&field=attribute.h_maaiveld:string(0,0)&field=attribute.identificatie:string(0,0)&field=attribute.kas_warenhuis:string(0,0)&field=attribute.lod11_replace:string(0,0)&field=attribute.ondergronds_type:string(0,0)&field=attribute.oorspronkelijkbouwjaar:string(0,0)&field=attribute.pw_actueel:string(0,0)&field=attribute.pw_bron:string(0,0)&field=attribute.reconstructie_methode:string(0,0)&field=attribute.reconstruction_skipped:string(0,0)&field=attribute.rmse_lod12:string(0,0)&field=attribute.rmse_lod13:string(0,0)&field=attribute.rmse_lod22:string(0,0)&field=attribute.rn:string(0,0)&field=attribute.status:string(0,0)&field=attribute.t_run:string(0,0)&field=attribute.val3dity_codes_lod12:string(0,0)&field=attribute.val3dity_codes_lod13:string(0,0)&field=attribute.val3dity_codes_lod22:string(0,0)&field=attribute.voorkomenidentificatie:string(0,0)&field=lod:string(0,0)&field=surface.type:string(0,0)&field=surface.on_footprint_edge:string(0,0)&uid={6510ee43-46fe-4a82-bf8e-4a5f01317a45}','OUTPUT':'TEMPORARY_OUTPUT'})

I got 3805 geometries for the whole tile after extracting only the roof surfaces and same number of features after I deleted the duplicates. Can you reproduce?

Step 1: Uploading

And then got a python error! already...damn. :(

You are right, I just checked. There seems to be an issue with QGIS 3.24.3 on macOS. Not sure if this has something to do with the plugin or the specific release of QGIS. I'll investigate this. Thanks for figuring it out.
Regarding the original issue, though, I can reproduce the same results as I posted before even going through the old dialog import way, that I suppose you used before. This is what I get:

Yes! I also get 3805 <3 Will try the operation once more to see the surface area, thanks Stelios! Not sure if it'll be the further operations that may create double geometries but I'll keep you updated if so

Awesome! Glad that I was helpful. 🙏
Yes, please, if you can find out which part of your workflow created the duplicates I'd be interested to know.
Also, please be aware that you cannot trust QGIS's area function as it only computes the 2D area of a geometry (i.e., the area of the projected polygon on the horizontal plane).
Here is the difference between a true 3D area calculation (on the left) and QGIS's original area calculation (on the right) for the specific model:

If you want to know how I calculated the 3D area, I have this prototype plugin of 3D operations that I've built last summer which I can share with you. Please, feel free to contact me about this. If you have another way to compute the area in 3D, I'd be curious to know it.


Change the way JEI integration works

Right now, JEI transfer integration works even if you don't have all the available items in your system. In a vanilla crafting table, it shows the red overlay on items you're missing, and doesn't let you click the button. Both are useful, so I suggest a comprimise. Allow people to always click the button as you can right now, but also display the red overlay to show what you're missing in the system. You might have to contact mezz to see if this is possible with JEI currently, or if he can change something to make it possible.

I prefer the way how it currently works, just blocking the transfering when something is missing is annoying IMHO (maybe the player wants to schedule an autocraft AFTER they've autofilled items?).

IS it possible to display red overlay on items in JEI but not block "+" icon? Would be super-mega useful, few people we play together are complaining on this...

I don't think so.


[TODO OSPO Ambassador] Request - Jose Rodriguez

TODO OSPO Ambassador Request
This is an issue created to request to become an OSPO Ambassador. If you (as individual) are interested to apply, please make sure you have (1) read the TODO OSPO Ambassador Program documentation
and (2) fulfil the requirements from the Pre-submission checklist.
Pre-submission checklist:

[ X ] I am 18 years of age or older
[ X ] I abide the TODO Code Of Conduct
[ X ] I abide the LF antitrust policy
[ X ] I Confirm I meet AT LEAST ONE of the criteria documented at TODO OSPO Ambassador Program documentation

Contact Information
We would need the following information about you to get in contact if elected:

Jose Rodriguez Roa
Cuemby LLC
<EMAIL_ADDRESS>dagoshe
(Optional) Frediverse Handle

Current involvement in TODO Community
Who are you?

[ X ] An active contributor to a TODO initiative (OSPOlogy, OSPO Landscape, Website, OSPO Book, etc)
[ X ] A representative from a TODO General Member or OSPO Associate organization
[ X ] An OSPO Local Organizer and/or OSPOlogy Organizer
[ X ] An active leader in the TODO community with a minimum of 1 year of experience in:

Organizing events (virtual/in-person)
Speaking at events
Mentoring others
Creating content (e.g., blogs, videos, etc.)

REQUIRED: What do you expect from TODO Group as an TODO OSPO Ambassador? Whow would you help the community to thrive?
This is a very important section to understand how you would like to help the OSPO Ecosystem and engage in the TODO community.
Here you can also provide links to resources (blogs on OSPOs, Community calls and/or OSPOlogy live micro-conferences where you participated, etc)

@anajsana correcting the email -<EMAIL_ADDRESS>

Hello Jose! Thank you for your interest in becoming a TODO OSPO Ambassador. Our Steering Committee will review this request and will get back to you ASAP.
One section that I noticed that is missing is the last question: What do you expect from TODO Group as a TODO OSPO Ambassador? How would you help the community to thrive?
Could you please complete this section before sending this to our SC? This is a very important section to understand how you would like to help the OSPO Ecosystem and engage in the TODO community.
Thank you!

Thank you for your response, Jose. Would you please provide links or other information on your contributions to TODO Group?

Dear Leslie,
I'm excited to share that our journey in the program has just begun, and it's already shaping up to be a transformative experience, not just for us, but for the entire Open Source Community in Latin America. One of our standout contributions is the launch of the first in-person Kubernetes Community Days (KCD) in the region. This event marks a significant milestone in our commitment to nurturing a vibrant tech community (4 KCD more and 6 Ambassadores in the region https://www.youtube.com/watch?v=nA4acN-Xc0M). https://www.youtube.com/watch?v=wc7Qtba6pzw&list=PLj6h78yzYM2NGlhxZ1P0JXujDJWy-rMLU&index=31
A core focus of our initiative is to foster Diversity, Equity, and Inclusion (DEI) in the Latin American tech landscape. We're passionate about creating an inclusive environment where diverse voices are heard and valued. Our goal is to bring together over 1000 companies, forming a tech community that not only embraces DEI but also actively promotes the principles of Open Source. ( KCD El Salvador and this community https://www.cuemby.com/rise-up-fintech
We're also dedicated to facilitating knowledge sharing and engagement through live and online events each month. These events are designed to be interactive, informative, and inclusive, providing a platform for learning, collaboration, and innovation. https://lnkd.in/ga7gyrxz
On the technical front, in partnership with Cuemby, we're making significant strides in developing an open-source platform based on Kubernetes. This endeavor is not just about building technology; it's about creating a unique community project that resonates with our values of inclusion and accessibility. One of the exciting features we're working on is a module specifically designed for color-blind developers, ensuring that our platform is accessible and user-friendly for all.
As we move forward with these initiatives, we're enthusiastic about the potential impact and positive change we can bring to the tech community in Latin America. We believe that by working together, we can create a more inclusive, diverse, and innovative technological future. Please let me know how may I help with the ecosystem in the region and further more build up more and more community.
Thank you for your support and encouragement as we embark on this exciting journey.
Best regards
Jose Rodriguez

On 22/11/2023, at 5:35 AM, Leslie Hawthorn @.***> wrote:
Thank you for your response, Jose. Would you please provide links or other information on your contributions to TODO Group?
—
Reply to this email directly, view it on GitHub https://github.com/todogroup/governance/issues/297#issuecomment-1822510298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX2FX77SQ4MSGRYWR5ILH2DYFXIPPAVCNFSM6AAAAAA7K4XBFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSGUYTAMRZHA.
You are receiving this because you authored the thread.

@lhawthorn also to give some context and with regards to specific contributions to TODO / OSPOs, Cuemby recently became member and exploring ways to help contribute and increase participation. The most recent activity where Jose participated was as a speaker at the first OSPOlogyLive NA Legal edition and attended the recent OSPOlogy webinars and engaged in conversations with the speakers.
My understanding is that @dagoshe (please correct me if I'm wrong) would like to start local meetups to activate OSPO adoption in LATAM regions as a way to contribute to the TODO and its community.
@dagoshe I do have one question about how would you advocate the message of why open source people/strategy/ community engagement and the set up of an OSPO (or similar open source initiative) is necessary at an organizational level. Are you planning to include the OSPO message / TODO best practices talks in the existing cloud native meet-ups? 🙂  Thanks!

Exactly Ana, thank you for clarifying, and to respond your answer is would be advocating for open source at the organizational level involves highlighting its role in driving innovation and collaboration. An Open Source Program Office (OSPO) is key in guiding these efforts, ensuring compliance and effective community engagement as of today no one is doing in the region.
We're excited to integrate OSPO and TODO best practices into our cloud native meet-ups. These discussions will enrich our community's understanding of implementing and managing open source initiatives, fostering a culture of shared knowledge and growth, as I wrote on a previous email I im constant contact of companies in Latam or that have an intention of landing in the region (Spain-Germany-Israel) in which some how I embed the message and the principles of the lInux Foundation.
Looking forward to exploring these vital topics in our upcoming sessions!
Best regards,

On 22/11/2023, at 11:18 AM, Ana Jimenez Santamaria @.***> wrote:
I do have one question about how would you advocate the message of why open source people/strategy/ community engagement and the set up of an OSPO (or similar open source initiative) is necessary at an organizational level. Are you planning to include the OSPO message / TODO best practices talks in the existing cloud native meet-ups? 🙂 Thanks!

@lhawthorn when possible, could you please check @dagoshe last message and accept/decline the TODO ambassador request based on the answers provided? 🙂 Thank you!

Congratulations @dagoshe ! We are proud to inform that we can continue with the process and start the onboarding as our new TODO Ambassador. You will receive more details via email today.


Allow .src in dev-contrib and community-meta

Relevant Issues
Closes #1032

Description

Renamed some Channel constants so that it's clearer what they're referring to
Added community-meta to Channel constants
Added support for .src in dev-contrib and community-meta via the @whitelist_override decorator.

NB: Currently untested
Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the contributing guidelines?

Fix them file conflicts and we'll be good.


Incorrect output of 'success' upon a failure in conn-ack step

Crate
relayer and relayer-cli
Summary of Bug
tx raw conn-ack reports success whereas the command failed
Steps to Reproduce
Run the conn-ack step twice with reverse chain/clients:

cargo run --bin relayer -- -c config.toml tx raw conn-init ibc-0 ibc-1 07-tendermint-10 07-tendermint-10 default-conn default-conn
cargo run --bin relayer -- -c config.toml tx raw conn-try ibc-1 ibc-0 07-tendermint-10 07-tendermint-10 default-conn connection-6
cargo run --bin relayer -- -c config.toml tx raw conn-ack ibc-0 ibc-1 07-tendermint-10 07-tendermint-10 connection-6 connection-4
cargo run --bin relayer -- -c config.toml tx raw conn-ack ibc-1 ibc-0 07-tendermint-10 07-tendermint-10 connection-4 connection-6

At the fourth step, the output incorrectly states status=success but plainly there is an error:
{"status":"success","result":[{"ChainError":"deliver_tx reports error: log=Log(\"failed to execute message; message index: 1: connection handshake open ack failed: failed connection state verification for client (07-tendermint-10): chained membership proof failed to verify membership of value: 0A1030372D74656E6465726D696E742D313012230A0131120D4F524445525F4F524445524544120F4F524445525F554E4F524445524544180222270A1030372D74656E6465726D696E742D3130120C636F6E6E656374696F6E2D341A050A03696263 in subroot F43B7FEBB61F70CA3DE046194938E85F698E0847E96046DE0618AA52BF8ADC5C at index 0. Please ensure the path and value are both correct.: invalid proof\")"}]}

The raw output I originally used to observe this bug is below:
[2021-01-28 15:24:08] [   DEBUG] --- cargo run --bin relayer -- -c config.toml tx raw conn-init ibc-0 ibc-1 07-tendermint-10 07-tendermint-10 default-conn default-conn

[2021-01-28 15:24:16] [   DEBUG] --- {"status":"success","result":[{"OpenInitConnection":{"client_id":"07-tendermint-10","connection_id":"connection-6","counterparty_client_id":"07-tendermint-10","counterparty_connection_id":null,"height":"1"}}]}
[2021-01-28 15:24:16] [    INFO] --- ConnOpen init submitted to ibc-0 and obtained connection id connection-6
[2021-01-28 15:24:16] [   DEBUG] --- cargo run --bin relayer -- -c config.toml tx raw conn-try ibc-1 ibc-0 07-tendermint-10 07-tendermint-10 default-conn connection-6
[2021-01-28 15:24:19] [   DEBUG] --- {"status":"success","result":[{"OpenTryConnection":{"client_id":"07-tendermint-10","connection_id":"connection-4","counterparty_client_id":"07-tendermint-10","counterparty_connection_id":"connection-6","height":"1"}}]}
[2021-01-28 15:24:19] [    INFO] --- ConnOpen try submitted to ibc-1 and obtained connection id connection-4
[2021-01-28 15:24:19] [   DEBUG] --- cargo run --bin relayer -- -c config.toml tx raw conn-ack ibc-0 ibc-1 07-tendermint-10 07-tendermint-10 connection-6 connection-4
[2021-01-28 15:24:23] [   DEBUG] --- {"status":"success","result":[{"OpenAckConnection":{"client_id":"07-tendermint-10","connection_id":"connection-6","counterparty_client_id":"07-tendermint-10","counterparty_connection_id":"connection-4","height":"1"}}]}
[2021-01-28 15:24:23] [    INFO] --- ConnOpen ack submitted to ibc-0 and obtained connection id connection-6
[2021-01-28 15:24:23] [   DEBUG] --- cargo run --bin relayer -- -c config.toml tx raw conn-ack ibc-1 ibc-0 07-tendermint-10 07-tendermint-10 connection-4 connection-6
[2021-01-28 15:24:26] [   DEBUG] --- {"status":"success","result":[{"ChainError":"deliver_tx reports error: log=Log(\"failed to execute message; message index: 1: connection handshake open ack failed: failed connection state verification for client (07-tendermint-10): chained membership proof failed to verify membership of value: 0A1030372D74656E6465726D696E742D313012230A0131120D4F524445525F4F524445524544120F4F524445525F554E4F524445524544180222270A1030372D74656E6465726D696E742D3130120C636F6E6E656374696F6E2D341A050A03696263 in subroot F43B7FEBB61F70CA3DE046194938E85F698E0847E96046DE0618AA52BF8ADC5C at index 0. Please ensure the path and value are both correct.: invalid proof\")"}]}

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[x] Appropriate milestone (priority) applied
[x] Appropriate contributors tagged
[x] Contributor assigned/self-assigned

Yes, we were just debugging this with @cezarad now. She was about to open an issue :) It happens for all connection methods. We need to do the same as we do in channels, something like:
        match result {
            IBCEvent::OpenTryConnection(_) => Ok(result),
            IBCEvent::ChainError(e) => {
                Err(ConnectionError::Failed(format!("tx response error: {}", e)))
            }
            _ => panic!("internal error"),
        }

Yes, we were just debugging this with @cezarad now. She was about to open an issue :) It happens for all connection methods. We need to do the same as we do in channels, something like:
        match result {
            IBCEvent::OpenTryConnection(_) => Ok(result),
            IBCEvent::ChainError(e) => {
                Err(ConnectionError::Failed(format!("tx response error: {}", e)))
            }
            _ => panic!("internal error"),
        }


Links and table of content seems broken.

Hello @calcmogul,
When opening the latest version of the book, I see the following in the page selector:

In a previous version, I could see that:

And the table of content was present (it's empty in the latest version):

I rapidly looked at the changes, but I could not find the origin of the bug.

A recent version of Ghostscript seems to be causing the issue because the uncompressed PDF looks fine.


Modifications to ServiceMonitor or it's dependencies not triggering reload

What did you do?
Set up Prometheus Operator and got it running. It was difficult to debug because the operator did not respond in a manner that I expected.
What did you expect to see?
If I create a ServiceMonitor that cannot result in a target being generated, it should generate log errors. If I change anything to do with a ServiceMonitor (including it's Service or Endpoint), the changes should regenerate immediately
What did you see instead? Under which circumstances?

If the ServiceMonitor dependencies were insufficient to generate the Prometheus target, the process silently fails.
Making changes to these dependencies (Service, Endpoint, etc) does not cause the configuration to regenerate.
Even if a change is made directly to a ServiceMonitor, it is only picked up every three minutes (at least on my machine). (This may be a misconfiguration on my end.)

Environment
# uname -a
Linux node.example.com 4.20.3-1.el7.elrepo.x86_64 #1 SMP Wed Jan 16 19:37:14 EST 2019 x86_64 x86_64 x86_64 GNU/Linux`
# cat /etc/redhat-release
CentOS Linux release 7.6.1810 (Core)
# cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"

Prometheus Operator version:

quay.io/coreos/prometheus-operator:v0.25.0
quay.io/coreos/prometheus-config-reloader:v0.25.0
quay.io/coreos/configmap-reload:v0.0.1

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:54:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:43:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind: kubeadm

If the ServiceMonitor dependencies were insufficient to generate the Prometheus target, the process silently fails.

Could you be more specific about this? If you specify the selector in a Service object incorrectly, that also "silently" fails, how is this different, or how would you have expected it to work. So far the community has accepted this pretty well, as it works like all the rest of Kubernetes: with label selectors.
We would like to add some better diagnostics, such as a status in the ServiceMonitor, the only difficulty this brings with it, is the Prometheus Operator has to communicate with the Prometheus server, and we need to make sure this happens in a secure way. We definitely want to work on this, but it's a larger effort.

Making changes to these dependencies (Service, Endpoint, etc) does not cause the configuration to regenerate.

This is because Prometheus itself discovers these, the configuration just tells it how to pick exactly those that you want.

Even if a change is made directly to a ServiceMonitor, it is only picked up every three minutes (at least on my machine). (This may be a misconfiguration on my end.)

This is unfortunately because of how Kubernetes works. When you update a secret/configmap it takes up to 5 minutes for this configmap/secret to be re-mounted into the running pod/container.

Could you be more specific about this? If you specify the selector in a Service object incorrectly, that also "silently" fails, how is this different, or how would you have expected it to work. So far the community has accepted this pretty well, as it works like all the rest of Kubernetes: with label selectors.

Sure. I appreciate that things are passable as they stand, my notes on the issue were just what I found difficult to connect. Sometimes that's harder to see one one has gotten used to a system, so I thought I would share.

If I create a ServiceMonitor that cannot result in a target being generated, it should generate log errors.

What I mean by this is it would be beneficial if the target could be preflighted before the configuration is sent off to Prometheus. If the connection to the target could not be made by the controller, a warning could be generated. Of course, there are endless configurations and network policies, so the configuration shouldn't fail, but if it was able to automate a warning, users could be more productive.

If I change anything to do with a ServiceMonitor (including it's Service or Endpoint), the changes should regenerate immediately

This is unfortunately because of how Kubernetes works. When you update a secret/configmap it takes up to 5 minutes for this configmap/secret to be re-mounted into the running pod/container.

Couldn't a watch be placed on the resource through the API endpoint? I haven't written one yet, but it does seem possible.

I don't think a pre-flight is realistic for various reasons, but we do definitely need some status information on targets discovered by a ServiceMonitor, I think how we gather that is a detail. I have some ideas in mind, I hope we can get to this rather sooner than later, I agree and understand this is a missing piece for ServiceMonitor's UX.

Couldn't a watch be placed on the resource through the API endpoint? I haven't written one yet, but it does seem possible.

Yes this is possible, but has various scalability implications. My idea about this is that if we had a secure channel between the Prometheus Operator and the Prometheus servers (which doesn't exist today, but seems viable) then we could build a similar level trigger as the kubelets with the apiserver to update Prometheus servers and communicate status back and forth. This would make the Prometheus Operator somewhat similar to how vitess works. This is a pretty significant effort, but I think the right one.

Great, thanks for the consideration, @brancz. I definitely didn't want to create more work or dwell on solutions where I have no experience, just provide feedback on the most difficult part of the deployment experience. Even little hints like "checking again in X minutes" could give users who bothered to look at the logs the feedback they needed to be successful.

I agree, the log lines are very sparse even in debug mode there's nothing telling us why our servicemonitors have been ignored.  That's just mean really.  In our particular case I know it's reading the servicemonitor, but the secret is no longer being updated, there's no log saying "writing prometheus config of x scrape targets" or anything along these lines that would help me debug the issue, even in debug mode.

I still think the UX deserves to be worked on here.

Please remove the stale label again.

This sounds similar to #3335.


Crash in WebSocketServer

06-05 21:35:54.308  8994  9063 E Native.AGFilterSafebrowsing: [Thread-30] Download failed: failed to read from SSL connection (6) (from https://sb.adtidy.org/safebrowsing-lookup
-hash.html?prefixes=88981E62/BC9A8F2B)
06-05 21:35:54.310  8994  9063 E Native.AGFilterSafebrowsing: [Thread-31] failed to download safebrowsing list match information from safebrowsing api -- some internal error hap
pened (status code 1)
06-05 21:35:54.310  8994  9063 D Native.AGWebSocketServer: [Thread-32] *5: HTTP response: 200 OK  body=[0]
06-05 21:35:54.311  8994  9063 D Native.AGWebSocketServer: [Thread-33] *5: output: 108
06-05 21:35:54.312  8994  9063 D Native.AGWebSocketServer: [Thread-34] *6: Reusing connection 0x7f76359c80 for client <IP_ADDRESS>:41455 fd 230
06-05 21:35:54.313  8994  9063 D Native.AGWebSocketServer: [Thread-35] *6: parsing HTTP headers: +0
06-05 21:35:54.319  8994  9063 F libc    : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 9063 (Thread-35)

Depends on #314


How to make options modal appear below the icon

The default behavior is that the options modal (e.g. speed options) appears above the player. However, this isn't really desirable in some cases such as when you're only using the audio player and there is no video. Is there any way to make the options modal appear below the player?

Not really. It might be possible to override the current behavior with css, but this would require changing in a lot of places to get the arrow right too, and you'd likely need js to figure out how much to offset with (not sure about this). And ultimately it wouldn't really solve the problem imo.
As long as your page can be scrolled there's no telling which way is better until the menu is actually shown. Stuff like dynamic sorting and "infinite scroll" (tumblr scroll) makes it even harder. Changing the direction for all players may work for you if you know your player is always at the top on all devices, but even in that case it may overflow. It can happen for video too.

There's a whole library for handling this (https://popper.js.org/), but obviously adding that would increase the build size.


Update to GDAL 3.8.0/PyYAML 6.0.1

This version of PyYAML contains a Cython < 3
build dep.
This fixes CVE-2020-14343.

Based on what I can see, the same tests fail with the same errors as the latest commit to main did.


Disable every skin except user's, scrolling

Hi!

I would like to propose a button/checkbox similar to the 'No Skins' button, but instead it disables every skin except of the user's skin.

I wonder if I'm alone with this issue - I want to disable all enemy/teammate skins to make spells more visible, but I don't want to disable my own. This leads to me clicking 'No Skins' at the start of each game, and then resetting my own skin to my own liking.

Also, could something be done so that when I scroll through a list of skins to choose (inside R3nzSKin window) my League camera doesn't zoom in or out? It's a bit annoying. The scrollbar on the right is really narrow and hard to click on.

Do i need to install new injector every new patch? If so, will my selected skins for champions reset? Where are they stored?

Thanks for creating this amazing app.

The no skin feature no longer resets the appearance of the local player. 7111a4f270d96ae0e42418d212df0fab16387cb6
R3nzSkin cannot block user input.
You can use any injector you want with R3nzSkin. also the config file is located at documents\R3nzSkin.

Thanks! To be honest now that I think about it, wouldn't it be even better if that feature was a checkbox so it would be saved between games? So that user wouldn't need to click it every game (I assume if user clicks 'No skin', he does that every game)


Request: add thelivingtrove.com to the filter

URL: https://thelivingtrove.com/weetangera/opengl-projection-matrix-tutorial.php
Evidence: ?
Website is an amalgamation of keywords and fragments to cheat the search engine.

Thanks a lot!


how to use FileDownloadFormatter attribute

hi volkanceylan, could you pls give us a example about FileDownloadFormatter. Is it about download function in row ?

use the search functionality in issues: FileDownloadFormatter


MapTileApproximater keep requesting and expiring scaled tiles

Issue Type
[ x ] Question
[ x ] Bug
[ ] Improvement
[ ] Build system related
[ x ] Performance
[ ] Documentation
MapTileApproximater keep requesting and expiring scaled tiles nonstop, when no provider can return a tile successfully
https://github.com/osmdroid/osmdroid/blob/d08366238d32291d22e84e698e0177392e49fbb1/osmdroid-android/src/main/java/org/osmdroid/tileprovider/modules/MapTileModuleProviderBase.java#L299
It hopes other provider will be able to get the tile in native zoom, so it make the scaled tile expires and fires up new request. But in a hopeless situation it just dry up all your cores to loop itself forever.
Version of osmdroid the issue relates to:
6.1.2

I wouldn't call it a bug: it works the way it's supposed too. In limit cases, I do understand that it may need some improvement, though.
Another point: it doesn't "loop forever", it just works when needed. If your map is still, there's no reason why the tiles should be refreshed and the approximation computed - am I correct?
That being said, we need several things.
What is a "hopeless situation", and who says so?
Typically, for instance it could be a "no internet" situation. Or "slow internet".
In first approach let's say it's a "no internet": it's easier to detect.
We already detect that, either with NetworkAvailabilityCheck or more precisely with MapTileProviderBasic.isDowngradedMode.
And we already take that into consideration in MapTileProviderArray.getMapTile: if we find a tile in the memory cache and if we are in downgraded mode, we consider that the tile is good enough, even if it's expired or scaled.
@treenewbee I guess what you want is already more or less covered in terms of "downgrade mode" code. The problem might be with the memory cache being emptied too often. What if you expand your memory cache: would that help? Something like providerArray.getTileCache().ensureCapacity(50). Could you try that?

So I have two providers in MapTileProviderArray: one is completely offline provider extends MapTileModuleProviderBase with limited native zoom, another is MapTileApproximater to scale when out of native zoom.
So I think the issue is I am using MapTileProviderArray but not overriding isDowngradedMode, so even when map is completely still, the tile requests are firing up non-stop when out of native zoom.
Then maybe isDowngradedMode should be abstract so people will know it needs to be implemented.
I was looking at OfflineTileProvider as an example, which does not implement isDowngradeMode either. So I would suspect it will also suffering the same looping forever issue.

The way you describe it, your code is very similar to OfflineTileProvider, am I correct?
You're right, OfflineTileProvider should override isDowngradedMode and return true.
But we cannot make isDowngradedMode abstract, for consistency reasons with all osmdroid user historical code.
I don't understand why non-stop tile requests actually fire on a still map. Do you have a code example of your provider array?

Yes I am doing very similar to OfflineTileProvider:
class Array(pTileSource: ITileSource?, pRegisterReceiver: IRegisterReceiver?) :
    MapTileProviderArray(pTileSource, pRegisterReceiver) {
    init {
        val provider = Provider(4, 20)
        mTileProviderList.add(provider)
        val approximater = MapTileApproximater()
        approximater.addProvider(provider)
        mTileProviderList.add(MapTileApproximater())
    }
}

I think it keeps looping because:
The tile is not ExpirableBitmapDrawable.UP_TO_DATE and isDowngradedMode is false, so the scaled tile got back into the queue.
https://github.com/osmdroid/osmdroid/blob/d08366238d32291d22e84e698e0177392e49fbb1/osmdroid-android/src/main/java/org/osmdroid/tileprovider/MapTileProviderArray.java#L136
The next round basically the same, Provider is out of native zoom so failed. MapTileApproximater got yet another scaled tile so expired, then it keeps looping.

@treenewbee I've just tested:

you're right - as it is, OfflineTileProvider can run an endless loop searching for approximations
but everything works great with no endless loop (approximation are computed only once on a still map) with the forementioned

@Override
protected boolean isDowngradedMode(long pMapTileIndex) {
	return true;
}

@treenewbee Isn't everything fine if you override isDowngradedMode?

Yes, implementing isDowngradedMode fixed the issue, everything is working as expected.


[FR] Allow using special characters in names of parameters (templates)

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

Problem statement
When adding parameter templates it's not possible to use any characters other than [a-z][A-Z][0-9]. I only started adding templates for transistors and operational amplifiers and I already have 114 necessary parameters. Given that I cannot use ",.()[]{}/*", it's impossible to write hints into the parameter names. For example,now I need a parameter with unreadable name "dVbrdss divided by dTj". If I could insert symbols for derivation and slash, everyone would know what I mean. Or if I could add "(dependence of breakdown voltage on junction temperature)", it would also be obvious. Obviously, I can't since parentheses are disallowed so all I could get is unreadable and even more mysterious junk.
Suggested solution
Allow using any ASCII characters (OK, no BEL and other funny things) in names of parameters.
Even better, allow UTF-8 entry.
Describe alternatives you've considered
At least allow usage of ",.()[]{}/*" in names of parameters since these are often required for electronic components.
Examples of other systems
Well, in Inventree, you can write those symbols just about anywhere including the parameter values, just not their names. So if it already works in most of Inventree, it could work here as well.
Do you want to develop this?

[ ] I want to develop this.

What a about a new field hints or description for a parameter template? This could then be visible on hover or an own column in the table.

That's a possibility. But doesn't solve the issue that there are many parameters which use "/()" symbols, whether it's some coefficient or a note which describes conditions of test. Not being able to write subscripts is also a pain, but one which electrical engineers have to deal with everyday. And also, there is only 2 ways how to separate parts of parameter name, either space or mixing large and small characters. At least having parentheses would help.
Here is an example of some of parameters I use to show how problematic this may be for using InvenTree for electric components (currently, I have 120 separate parameters and that's maybe 1% of my stock being recorded).

We are happy with looking at PRs @MR-DOS .
The current system is a result of frontend collisions but if you come up with a solution it could be done. Validation is done here but the real challenge is to not break the frontend
https://github.com/inventree/InvenTree/blob/a3392ea4b1675c0439157ccf1e065a801942e2c5/InvenTree/part/models.py#L2370
All ASCII or UTF8 characters are not going to happen - that would be a security concern.

Well, this is a slightly embarrasing situation. That function really doesn't handle text correctly in any way. It allows the use of ASCII control characters, ":;" and DEL. It also has no abilities to block UTF-8.
So, now that we know that UTF-8 works, maybe we could also drop some of that false sense of security and allow the normal ASCII characters? After all... values of parameters can have all characters, why not names of parameters? Is it really handled so differently?
But for me, I have a working solution. Not good, but working. Imitating symbols I need with similar UTF-8 symbols.

@MR-DOS I don't think we are talking about the same security issues. ASCII characters per se are no issue. There is a specific subset that could be used to run XSS attacks. And those security measures work on stable:

The only thing embarrassing here is your tone in a free - as in beer - project with NO warranty or monetary charges.

You are free to look into the code and discover that the names are used as references in JS.
If you do not have a productive change in mind I do not see this getting any work from my side. Maybe someone else is willing to pick this up.

Well, sorry for my tone. But if the XSS script is a concern in name of the parameter, why not in its value?

There is also protection against XSS in the value fields. I attached a screenshot of that too now.
Nearly every field is tested for XSS before entry into the database. This is part of the general model setup. SQL unsafe special control characters are also generally escaped.

Sorry for my tone.
OK, I will leave with using UTF-8 to emulate the forbidden characters.
Still, I would think that if at least "<>" are forbidden, then no HTML tag for XSS injection can be created and thus the other symbols could be allowed. After all, ":;" are considered to be harmless in that function while they are also used and necessary in some XSS code. But I may be wrong, never worked with JS / SQL and so on.
I had a somewhat productive change in mind (depends on point of view) - making Inventree parameters useable for parameters of electronic components without a lot of head scratching. If that can't be, OK, just wanted to know. I first searched the documentation, but could not find any mention of these artificial limits which was mainly why I wanted to find out why it behaves so.
And thanks for the tip to read the whole codebase before asking. Will do that next time.

@MR-DOS an update to what characters are allowed here would be fine. I'm going to re-open this as a I think it is a valid development target. Would you be willing to work on this?
I would also suggest that we add a "description" field for the PartParameter model as suggested by @wolflu05
On a related note - I have a parallel PR for removing non-printable characters on the client side: https://github.com/inventree/InvenTree/pull/3591

The question from my side is, why are you permit the usage of <> instead of escaping them and use the id for reference?

@SchrodingersGat Hi. Sadly, I specialise on hardware and don't consider myself a good programmer. Given that this issue revolves around security holes in XSS / JS /SQL (which I know nothing about), I believe any modification from my side would probably lead to severe hazards. If it were good old embedded system programming, I'd happily give a helping hand :-)
I tested some of the non-printable ASCII characters and they usually show in the editing field, but do not show up once saved. Some cannot even be inserted, probably due to the nature of the editing field (like LF).
The description field sounds like a good idea for me.

@wolflu05 this is a grown system, it was originally implemented this way. The limited resources are currently spent on more pressing issues.


Add save_manager.gd

Not much of a priority for now but this would permit to store high scores and other stuff that might come later.
I was thinking of including @bojidar-bg 's one made for top-down-inertia ( here )

well, I've already done that some time ago


Make _getImageFromDynamic public

Thank you for the awesome package.
I used it for my tool to quickly find the icon from the screenshot.
But the screenshot is not transparent background like the icon, so I need a way to make these images have the same background.
It's nice if you can public _getImageFromDynamic so I can use it to get Image and apply some filter before comparing.

Hey @XuanTung95 Sorry for the late response, thank you for using our package! Just to verify, you want to apply some filters to the image before the comparison correct?

Hi @krlaa, Yes, I want to get the Image first, then apply filters to get Image2, then use Image2 to compare.

@XuanTung95 Hey glad to hear back from you. In your situation we recommend you using the image library to apply your filters. Then pass that 'Image' object to our library. If you look at the documentation of our package the input source can be the type of 'Image'

@krlaa yeah I know,
I want to use the _getImageFromDynamic() method from your library to get the Image first. Could you public it?
The filter part is not related to this ticket.

Hey @XuanTung95, if you'd like to use some functionality from _getImageFromDynamic(), feel free to copy it from our repo.


fix the bug for typo dicts rather than dict

Sorry for the confusion. I don't know why it pulled requests for twice. I found errors when I run the colab and fixed this issue.


[ECO-656] Support exporting/importing private keys in PEM format.

As the title said.
Previously, we export key pair in base64 encoded, and Clarity has updated to support PEM format, we should do it as well in Singer.
Here is the related PR of Çlairty: https://github.com/CasperLabs/clarity/pull/14

bors r+

bors r-

bors r+


getDraftForNarrow selector [nfc]: Return undefined for none-found.

It seems useful for callers to be able to distinguish between "no
draft found for this narrow" and "empty-string draft found for this
narrow".

Seems sensible.
We should in this case make sure that also when we're clearing a draft, we remove it from the map rather than writing back ''. I think the main case of that is here:
  handleMessageChange = (message: string) => {
    this.setState({ message, isMenuExpanded: false });
    const { dispatch, narrow } = this.props;
    dispatch(sendTypingStart(narrow));
    dispatch(draftUpdate(narrow, message));
  };

in the case where message -- i.e. the just-updated contents of the message input -- is empty; not sure if there are others.

I think the reducer code will remove the draft from state if it's been cleared:
const draftUpdate = (state, action) => {
  const narrowStr = keyFromNarrow(action.narrow);

  if (action.content.trim().length === 0) {
    // New content is blank; delete the draft.
    if (!state[narrowStr]) {
      return state;
    }
    const newState = { ...state };
    delete newState[narrowStr];
    return newState;
  }

  return state[narrowStr] === action.content ? state : { ...state, [narrowStr]: action.content };
};

But possibly the reducer shouldn't be where that happens, and dispatchers should signal clearing a draft by (e.g.) sending undefined or even using a new kind of action like DRAFT_CLEAR.
If the reducer doesn't recognize draft-clearing, dispatchers will have to (this is currently the only one).
Since Flow can't distinguish a cleared-draft string (e.g., the empty string) from a non-cleared-draft string, it's not likely to help ensure we do the right thing anywhere, I think. That makes me look to the reducer, as one central place where we have to get it right, but I'm not sure that's what we'd normally do in circumstances where Flow helps more.

What's the case where we want to have a blank-string draft hanging around? It seems sensible to explicitly make this optional, in general, but I'm curious if there's a usecase here, or if it's just doing it since it feels right.


Remove promise middleware

https://github.com/reactGo/reactGo/issues/731
We no longer need this guy!

lgtm except versioning - shouldn't this be a 2.0 change? You can always rebrand the 2.0 project as "next", then we just make breaking changes as needed for a little while :)

Fair enough, we've been on 1.7.x for ageeeess now. I like the idea of next. Have renamed project and branch lol!

hooray!


version: update non-v1beta1 resources to v1alpha3

Description of your changes

Does as title suggests.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the dependencies in app.yaml to include any new role permissions.

do these links get updated automatically?

https://crossplane.io/docs/master/api/crossplaneio/stack-gcp/storage-gcp-crossplane-io-v1alpha3.html#BucketClass should be a working link once we run crossdocs for this release, so we should update the link to v1alpha3 in this repo.

@negz done for each of the stacks


mini.indentscope highlights on multiple windows

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.indentscope
Description
If you open two windows on the same buffer indentscope highlights on both as you move around. I'm using LazyVim.
https://user-images.githubusercontent.com/1597820/222766656-d58e3140-876a-4636-ab95-7969f7196582.mp4
Neovim version
0.8.3
Steps to reproduce

nvim -nu minimal.lua
...

Expected behavior
Only highlight the active window?
Actual behavior
Highlighting every window with the same buffer.

Thanks for the issue!
Unfortunately, this is impossible with current Neovim capabilities. The reason is that highlighting functionality (as is designed) is done with extended marks (a.k.a extmarks, see :h extmark). They are tied to the buffer and there is (currently at least) no way to show them only in some windows. And there seems to be no interest to implement it right now.
Closing this as there is nothing can be done here before new functionality is added to Neovim.


Update generated code

It would appear rustfmt changed formatting slightly.

Awesome, thanks for tackling this chore!


laser_filters: 2.0.6-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository laser_filters to 2.0.6-1:

upstream repository: https://github.com/ros-perception/laser_filters.git
release repository: https://github.com/ros2-gbp/laser_filters-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 2.0.5-1

laser_filters
* Added declaration of parameters
* Reduce computation cost of ScanShadowsFilter
* Update scan_to_cloud_filter_chain.cpp
  As of Eloquent a timer interface is required for the tf buffer.
  https://docs.ros.org/en/galactic/Releases/Release-Eloquent-Elusor.html#tf2-buffer
* Contributors: Atsushi Watanabe, Jon Binney, Jonathan Binney, Riccardo Tornese, brandonbeggs

Oops, didn't mean to add doc. Will fix and open a new PR


integer vs float values in Video/PixelAspectRatio

Hello,
I use a rule where it should be ensured that the Video/PixelAspectRatio is 1. It is defined as value "1.000" because there are other rules within other contexts using values like "1.067". Anyway. In a test video I got a failure because mediaconch reports an integer value of "1" and the rule will fail with "1.000". See attached screenshot.
I am using mediaconch 17.03.

It is a bug with some files e.g. with containers not having pixel aspect ratio metadata, because one of the raw stream parser (used in case the container has no pixel aspect ratio) was not setting correctly the corresponding field.
Fix on the way.

In next snapshot tomorrow and next official release.

BTW @art1pirat which OS and version are you using. Looks like the default does not have the fail/pass Unicode chars.

Hi Jerome,
On Thu, 20 Apr 2017 06:03:52 -0700
Jérôme Martinez<EMAIL_ADDRESS>wrote:

BTW @art1pirat which OS and version are you using. Looks like the
default does not have the fail/pass Unicode chars.

I am using GNU/Linux Debian-Jessie, amd64
With best regards
Andreas
--
Dipl. Inf. (FH) Andreas Romeyke, http://andreas-romeyke.de/


A bunch of improvements to the project

General Improvements

Added support for doas and regular su to all scripts
Removed sudo from requirements everywhere
Fixed spelling of AUR
Updated Linutil binary

Removal of Obsolete Packages
I added a script that automatically removes Obsolete Packages (orphans) from your system.
Currently, it supports:

Debian (APT)
Fedora (DNF)
Arch (Pacman)
OpenSUSE (zypper)
Gentoo (Portage)
Void (XBPS)
NixOS and other systems with Nix
Slackware (SlackPKG)
Alpine (APK)

Project README
I added a bunch of userful information to the Project's README, such as:

Linutil's current features
Currently Supported Systems
How to contribute to the project

I also added myself to the credits ;)
List.rs
In addition to adding the obsolete package remover to list.rs, I also made it so that the scripts that are cURLed from the web (e.g. mybash) are piped to sh instead of being ran with bash -c. This makes it so that they don't rely on bash.
System Update Script
Added support for:

Gentoo (Portage)
Void (XBPS)
NixOS and other systems with Nix
Slackware (SlackPKG)
Alpine (APK)

Common Script
Added other package managers as an example:

XBPS
Nix
SlackPKG
APK
Eopkg
YUM
Rad
KISS

Love a lot of the ideas but these really need to be seperate PRs. there are conflicts with some of the updates so it is best to break out each big fix into it's own pr. Ex. Orphan PR, list.rs fixes, change sudo to SUDOCMD.


Corepack less strict

Adopt COREPACK_ENABLE_STRICT=0 for CI since we regularly toggle between package managers in our tests.

The tests fail consistently, so it's related in some way. I haven't actually tried to repro, this is low priority for me. (Assumed it would just sail through CI.)

Closing this one - we haven't seemed to need it for the past 5 months so I think we're ok for now. But we can always revisit.


Add myself to contributors list

Description
Added myself to contributors list, I am an author of Codepipelines integration
https://github.com/raycast/extensions/blob/main/extensions/amazon-aws/src/codepipelines.tsx
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the metadata folder

All good 👍


fix(helm): Wait for CRDs to reach established state for crd_install hook

What this PR does / why we need it:
There is a race condition in the crd_install hook implementation, where there is a chance a CRD is not yet ready by the time CRs are being created. This is reported in issue #4925. This change makes sure CRDs installed through the crd_install hook reaches the established state before the hook is considered complete.
Fixes #4925
Special notes for your reviewer:
Unit-testing code in the kubernetes client is difficult, as the builder/infos is tightly coupled with the API server. I will look into how to improve testing for this part of the codebase, but I would like to separate it from this PR.
If applicable:

[x] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Two more issues opened that should get fixed by this PR
https://github.com/coreos/prometheus-operator/issues/2432
https://github.com/helm/charts/issues/11702

I tested this with the test chart+script I wrote to reproduce #5375 - the issue still occurs.

CRDs with helm, and in particular trying to deploy prometheus-operator chart is completely broken until something like this gets merged down.

@bacongobbler, I'm pretty surprised this didn't make it into Helm 2.13.0. Are you able to offer a timescale on when we can see this in a release of Helm? I have a number of charts I want to use that are completely broken until this can be resolved....

What's the holdup of this? Anything we can do to help moving this forward?

Any PR size/L or higher needs two maintainers to sign off. I'll see if I can but one of the other maintainers to take a look at this before the 2.14 release. Sorry for the delay on this one!

@bacongobbler, that would be massively appreciated.

Getting the conflict resolved and this landed would be great :-)

I'd say, the conflict is not the main problem. Please have a look at my comment above. I build and deployed tiller with this PR applied and it did not solved the issue (see https://github.com/helm/helm/issues/5375).

I have rebased the PR so the conflict should be resolved.
@micw Your issue is actually a separate one from what is being addressed in this PR. This fixes the issue where the installed CRD is not ready at the point where CRs are created.
Your issue is that the deletion of the CRD through the hook-delete-policy hook has not completed when the crd-install hook tries to install the same CRD. Based on the error message, it sounds like the deletion timestamp has been set, but the resource is not yet removed from etcd. From just a quick look at the code that does the deletion, I think it needs to poll for the resource to be fully removed from etcd before the delete hook should be considered complete. I will try to find time to make a separate fix for this issue.

Any updates? Can this be merged?

@Morriz see my comment above

I'll be reviewing this soon

@thomastaylor312 I know you're busy, but I, too, am hoping this can get reviewed sooner rather than later. MEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.

+1 to that, anything we can help with?

Is there a time estimate to port this change to Helm v3?
Thanks for this!

@guilledipa thanks for the reminder! We missed labeling this with the needs v3 label so we can make sure to come back around and port it over

This was implemented in Helm 3 by #6332


Update refined, refined-cats, ... to 0.9.15

Updates

eu.timepit:refined
eu.timepit:refined-cats
eu.timepit:refined-scalacheck

from 0.9.14 to 0.9.15.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "eu.timepit" } ]

labels: library-update, semver-patch

Codecov Report

Merging #1246 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1246   +/-   ##
=======================================
  Coverage   81.07%   81.07%
=======================================
  Files          55       55
  Lines        1009     1009
  Branches       42       42
=======================================
  Hits          818      818
  Misses        191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0e764...479eb01. Read the comment docs.


create an AssetPreview component for use on Channel and Popular pages

This component should load the image for images and load a thumbnail (for videos).
Ideally this component would load a thumbnail for GIFs too, but that will require adding thumbnails for GIFs (https://github.com/lbryio/spee.ch/issues/346).

if we store the image/thumbnail width and height in the database so that they are available at render time, we can get get masonry to render a lot faster.

On the channel page, the asset preview should show a fallback image or warning if the asset does not load properly


There is no metadata available, please update to Dubbo2.7, or check your config center configuration in application.properties

Environment

Dubbo version: 2.7.5
Spring Boot version: 2.2.2.RELEASE
Dubbo Admin version : dubbo-admin-0.2.0
Operating System version: windows 10
Java version: jdk1.8.0_212

Steps to reproduce this issue

Service Provider config :

spring:
  application:
    name: dubbo-provider
dubbo:
  protocol:
    port: -1
    name: dubbo
#  registry:
#    address: zookeeper://<IP_ADDRESS>:2181
#    simplified: true
#  metadata-report:
#    address: zookeeper://<IP_ADDRESS>:2181
  config-center:
    address: zookeeper://<IP_ADDRESS>:2181
  scan:
    base-packages: dubbo.provider.service.impl

Zookeeper config :

Serivce Consumer config :

spring:
  application:
    name: dubbo-consumer

dubbo:
  config-center:
    address: zookeeper://<IP_ADDRESS>:2181
  protocol:
    port: -1
    name: dubbo
  consumer:
    check: false
    timeout: 15000

Pls. provide [https://github.com/seedscoder/dubbo-demo.git] to reproduce this issue.
Expected Result
I want to use the metadata capabilities provided by dubbo 2.7.5
Actual Result

fixed in 2.7.6


fix(cloudflare): split Set-Cookie header into multiple headers

🔗 Linked issue
#988
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[  x ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Splits Set-Cookie for each upstream header provided.
Resolves #988
📝 Checklist

[  x ] I have linked an issue or discussion.
[  x ] I have updated the documentation accordingly.

I suppose that these changes should be applied also to other presets where .join(',') used.

I checked codebase a little bit deeper and i think that it should be changed on unenv level and response.headers (which is HeadersObject) should implement Headers instead of { [key: string]: string | string[] | undefined }; and with this we will need to make such transformations on preset level.

Hello, @pi0. I also pushed to this PR change for not caching 404 responses if its asset directory, can you check it too please

Hello, @pi0 any updates on it? Issue with Set-Cookie header and 404 caching its making Nuxt absolutely unusuable with Cloudlare Workers

Hey @oleghalin,
I just saw this PR because I have the same problems with Nuxt on CF Workers, which is soo annoying.
I noticed that the new h3 version used in nitro now exports the splitCookeString function, so maybe you can remove the set-cookie-parser dependency and this PR can move forward.

Hello, @pi0. I just just updated my PR and dropped third-party dep

Hey, @pi0. I suppose that it makes many problems for all users who use CF workers to deploy, can you take a look on it? It solves 2 big problems with caching and cookies

+1 I had the same bug that bothered me for days，it's not just about nitro.routeRules, proxyRequest has the same bug

@oleghalin This is on my radar, apologies for the delay. Can you provide me with a reproduction ? I would like to see if this behaviour affects the other cloudflare presets too.

Not sure why you need reproduction, Set-Cookie header should be merged into one because browsers read each Set-Cookie header and set 1 cookie per each Set-Cookie header, as soon as there is only 1 header delimited by coma it will write only first cookie. As I know Vercel and node server parse it on their end and thats why it works, but it doesn't work for CF.

Thanks for the additional information and the PR.
A reproduction is useful to test the proposed changes. Without one, it takes more maintainer time to review and get things merged.


Add exception for CONV assays

CONV assays are derived from the same "raw" file. However,  only unique raw files are allowed when checked by check_metadata_samples, except for the Emory assays (which have the same problem). Add exception for CONV assays

Types of CONV:

Glucagon_Plate
Insulin_Plate
Cortisol_plasma

After discussion with Mike, these are the proposed suggestions:

Essentially, I suggest changing the assay names to have an IMM_ prefix when analytes are measured by immunoassay. These are ones that have multiple samples per raw_file (those shown in red). Only three new assay names would be needed, namely IMM_GLC, IMM_INS, and IMM_CRT, which would apply to both human and rat data, but with different experimentalDetails. (Note that IMM_INS for rat has only insulin, but for HUMAN is a multiplex immunoassay, with two metabolic hormones, insulin and leptin.)
In this schema, CONV would be reserved for data from our clinical analyzer, which produces unique raw_files for samples, which can have multiple analytes (in blue). CONV could thus fall into the usual QC as other MoTrPAC assays. Previous Batches of these data have been successfully QCed using earlier versions of MotrpacBicQC. (One Batch below has only CK, having been requested more than a year after the five other CONV measurements. I expect in the future to run all CONV analytes in the same Batch.)

Action items:

[ ] Allow redundant raw files associated with samples for any IMM_* assay
[ ] Require only one raw file per sample for CONV assays (remove exception)


Integration Test - Release - 2018/07/25 03:45:08

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

csidevdocs-public/IntegrationTest/BuildIntegartionTestFiles/ChangeSentToAuthor.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Re-introduce Ruby 2.3 support and test Jekyll 3.7+

Since we're not using Ruby 2.4 specific syntax, we can safely relax constraints on Ruby Version.
Other changes include:

Add jekyll as a runtime_dependency
Remove superfluous gemspec specifications
Test with Jekyll 4.0 pre-release
Correct whitespace alteration in Jekyll::Gist::GistTag

@jekyllbot: merge +fix


Configure coverage reports.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fa3a28c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   55.71%
=========================================
  Files             ?       17
  Lines             ?      341
  Branches          ?       15
=========================================
  Hits              ?      190
  Misses            ?      147
  Partials          ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3a28c...ca431d6. Read the comment docs.


How to Timeout on c.Expect()?

This is really useful, but debugging an expect scenario is pretty harsh right now, you just end up with a hang in the middle of a test, which is not good.

Is there a way to provide a timeout to c.Expect()? Is that easy to implement? It wasn't obvious to me with a casual review. I'm quite surprised it doesn't have that by default.
It's super important to be able to see what's going on in the whole expect scenario, and it seems completely obscured at this point. Suggestions about how to debug c.Expect()?

Thanks for doing this and maintaining it!

Hi @rfay, I usually make sure I follow up all my github notifications but somehow this one was missed, sorry!

Is there a way to provide a timeout to c.Expect()? Is that easy to implement? It wasn't obvious to me with a casual review. I'm quite surprised it doesn't have that by default.

I understand that tcl-expect have timeouts, and at one point go-expect had something like c.Expect(expect.String("Something"), expect.WithTimeout(time.Second) available but I feel they are inherently racy and there usually is a non-racy way of writing the same thing. Do you have an example where you will find this useful?

It's super important to be able to see what's going on in the whole expect scenario, and it seems completely obscured at this point. Suggestions about how to debug c.Expect()?

Yes you can use the options expect.WithExpectObserver and expect.WithSendObserver to understand what's causing your tests to fail. I haven't had the time to introduce default options for those to go-expect but you would write something like this:
func expectNoError(t *testing.T) expect.ConsoleOpt {
	return expect.WithExpectObserver(
		func(matcher expect.Matcher, buf string, err error) {
			if matcher == nil && err != nil {
				t.Errorf("Error occured while matching %q: %s\n%s", buf, err, string(debug.Stack()))
			} else if err != nil {
				t.Errorf("Failed to find %v in %q: %s\n%s", matcher.Criteria(), buf, err, string(debug.Stack()))
			}
		},
	)
}

func sendNoError(t *testing.T) expect.ConsoleOpt {
	return expect.WithSendObserver(
		func(msg string, n int, err error) {
			if err != nil {
				t.Errorf("Failed to send %q: %s\n%s", msg, err, string(debug.Stack()))
			}
			if len(msg) != n {
				t.Errorf("Only sent %d of %d bytes for %q\n%s", n, len(msg), msg, string(debug.Stack()))
			}
		},
	)
}

func TestSomething(t *testing.T) {
    c, err := expect.NewConsole(expect.WithStdin(ptm), expect.WithStdout(term, f, tf), expect.WithCloser(pts, ptm, tf), expectNoError(t), sendNoError(t))

}

Thanks so much for these suggestions. The basic problem is that nearly any test you can imagine can result in un-debuggable results, which can (and very often do) include hangs, meaning you don't even find out until go test kills it, and then you have no information. And... as you mention it's difficult to debug interactively.  At this point, we don't envision being able to use go-expect at all just because it appears to be a maintenance nightmare. It works for the most trivial of situations, where the thing you're testing is completely predictable, but when anything goes wrong, there's no way out.
It looks like the Observer is a good way to gather some info. But in the situation here, it doesn't do any good because you don't get it until something lets the process go.
In our case, over in survey, we tried to test our binary, but something completely caused the stdio to fail, and nothing about the survey.Input functionality worked in a test environment. I was able to experiment successfully with altering/extending survey's tests (using go-expect) (https://github.com/rfay/survey/blob/8673f66923e6f3de1c2468a3158f84184b2423df/select_examples_test.go#L144) but completely failed with trying the same thing running our binary (ddev) https://github.com/rfay/survey/blob/8673f66923e6f3de1c2468a3158f84184b2423df/select_examples_test.go#L249 - Survey's terminal interaction seemed not to work at all with it and I couldn't figure out any path forward.

You can follow the output without waiting for the go test timeout. For example, you can multiplex the stdout to a file on disk which you can tail to follow along.
func TestSomething(t *testing.T) {
	logFileName := fmt.Sprintf("%s.log", t.Name())
	logFile, err := os.OpenFile(logFileName, os.O_APPEND|os.O_WRONLY|os.O_CREATE, 0600)
	require.NoError(t, err)
	defer logFile.Close()

	c, state, err := vt10x.NewVT10XConsole(expect.WithStdout(logFile))
	// In a separate terminal you can `tail -f <test-name>.log`.
}

A test suite we wrote for an internal product at Netflix executes all these tests in parallel t.Parallel(), with each go test go-routine spawning its own virtual terminal to test the interactive application. Perhaps we can write some utility in go-expect that creates a temporary serial console so you can do something like screen <test-name>tty? I'm open to ideas.
I wrote a simple example for ddev that works on OSX / Linux. Unfortunately I don't have a Windows machine to test this: https://github.com/hinshun/ddevexpect

Wow, thanks so much for that. Now that I've got the PR that adds survey wrapped (except for testing) I'm going to circle back around and take a look at your example and pursue this a bit farther. Thanks so much!

Oh, and to react to the rest, yes, ddev runs and is tested on Windows and Linux and macOS.
winpty works great (as a helper binary, and it's bundled with git-bash) but I'm not sure how or whether it would help go-expect, but it's the standard way to run a winpty docker run -it <something> bash for example.
But yeah, any testing technique we use has to work with macOS, Windows, and Linux.

@hinshun Does that mean that https://github.com/hinshun/vt10x is also incompatible with Windows, so couldn't be used for testing there either?

No, vt10x is decoupled from ptys so it should work on Windows. That said, I don't own a Windows machine so I haven't tested it.

Excellent, thanks!