Legacy (SDF wrapper-based) KafkaIO reader degrades when Kafka poll latency is hign

Beam has two KafkaIO source implementations now:

a modern one implemented as a Splittable DoFn (SDF), and
a (deprecated) legacy one implemented as an SDF wrapper over an UnboundedSource and KafkaUnboundedReader classes.

We found that the legacy KafkaIO source can not provide good throughput when the latency of calls to Kafka Consumer.poll becomes high. The degradation is very sharp: a pipeline that drops elements immediately after reading them from source was only able to read about 100-1000 qps per Kafka partition. The Kafka cluster was overprovisioned but was in a remote network and had poll latency about 30ms.
First problem that may be addressed in the scope of this bug is that there's very little visibility into the Kafka source now. We had to add extra logging to understand the issue with the pipeline above, or even see the poll latency.
We believe that the cause of throughput degradation is poor choice of the RECORDS_DEQUEUE_POLL_TIMEOUT and RECORDS_ENQUEUE_POLL_TIMEOUT especially the former one which is now 10ms.
These are timeouts for popping and pushing elements from/to the availableRecordsQueue .  This is a synchronous queue (i.e. blocking, without buffering) used to hand records fetched from Kafka between two loops:

The consumerPollLoop that polls data via a Kafka Consumer if there's no pending data already, and offers it to the availableRecordsQueue otherwise. It also does offset checkpointing but this is irrelevant to our case.
The beam UnboundedSourceAsSDFWrapperFn message processing loop. It's a bit complicated, but the important part is that it would call the nextBatch function repeatedly until an attempt to fetch an element from the avaliableRecordsQueue times out. After the timeout, it returns the control to the worker and it may take relatively long time until the loop is scheduled again.

This is what we think is happening when the poll latency is high:

consumerPollLoop fetches data bundle from Kafka via poll() and offers it to the avaliableRecordsQueue
message processing loop fetches bundle from avaliableRecordsQueue and unblocks the consumerPollLoop
consumerPollLoop calls poll() again
message processing loop completes processing the bundle BEFORE the poll() call above completes, and tries to fetch next bundle from avaliableRecordsQueue.
fetch from avaliableRecordsQueue has a very short timeout (10ms) and if it expires before the pending poll() in the consumerPollLoop completes the message processing loop will believe there's no fresh data in Kafka and exit. All the time until the message processing loop is rescheduled is wasted.

Imported from Jira BEAM-14111. Original Jira may contain additional context.
Reported by: dmitryor.

Not sure what version of the legacy IO connector this issue is referring to but I see the same performance issues in the latest version of the connector. I have a topic partition in Kafka with 100 million messages on it but for some reason, this connector maxs out at 7k msgs/sec. I’ve ruled out the possibility of my code and no matter what Kafka consumer configuration I use, the performance is the same. There’s definitely something sub optimal inside the unbounded reader.


Yolo achievement!

GO!

please try in your own repo ;)

Is it worked?

Is it worked?

 Then, create a PR to main branch and merge ... Done, new YOLO achievement earned!


Simple example usage fails on fresh install of Python 3.7.2 (AttributeError: 'NoneType' object has no attribute 'text')

This is running on Windows with Python 3 and a fresh install of scholarly from GitHub.
Python 3.7.2 (tags/v3.7.2:9a3ffc0492, Dec 23 2018, 23:09:28) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import scholarly
>>> print(next(scholarly.search_author('Steven A. Cholewiak')))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\hackr\Python64\Python372\lib\site-packages\scholarly\scholarly.py", line 110, in _search_citation_soup
    yield Author(row)
  File "C:\Users\hackr\Python64\Python372\lib\site-packages\scholarly\scholarly.py", line 226, in __init__
    self.name = __data.find('h3', class_='gsc_oai_name').text
AttributeError: 'NoneType' object has no attribute 'text'

I am closing this because I found the same problem in another open Issue:
https://github.com/OrganicIrradiation/scholarly/issues/37


Only Sync Newly Added

I have synced a folder to my remote server but I want to remove the files in the local folder and only upload new stuff I put in it without deleting old stuff that's already there. How can I do this?

Nevermind


Intellisense not working on Linux Mint 18.2 with Unity 2017.2

Environment data
dotnet --info output:
.NET Command Line Tools (2.0.2)
Product Information:
Version:            2.0.2
Commit SHA-1 hash:  a04b4bf512
Runtime Environment:
OS Name:     linuxmint
OS Version:  18.2
OS Platform: Linux
RID:         linux-x64
Base Path:   /usr/share/dotnet/sdk/2.0.2/
Microsoft .NET Core Shared Framework Host
Version  : 2.0.0
Build    : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d
VS Code version: 1.18.0
C# Extension version: 1.13.0
Steps to reproduce

Open Unity Editor (latest Linux version)
Open C# Project
See errors in output log

Expected  behavior
No errors and intellisense to work for Unity.
Actual behavior
Starting OmniSharp server at 11/9/2017, 7:13:01 PM
    Target: /home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/unitysimpleroom.sln

OmniSharp server started wth Mono
    Path: /home/ideo/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/OmniSharp.exe
    PID: 9616

[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 15.0 - "/usr/lib/mono/msbuild/15.0/bin"
            2: StandAlone 15.0 - "/home/ideo/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/msbuild/15.0/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 15.0 - "/usr/lib/mono/msbuild/15.0/bin"
            CscToolPath = /home/ideo/.vscode/extensions/ms-vscode.csharp-1.13.0/.omnisharp/omnisharp/msbuild/15.0/Bin/Roslyn
            CscToolExe = csc.exe
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Initializing in /home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Auto package restore: False
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Update workspace context
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Resolving projects references
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Detecting projects in '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/unitysimpleroom.sln'.
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Loading project: /home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp.csproj
[warn]: OmniSharp.MSBuild.MSBuildProjectSystem
        Failed to load project file '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp.csproj'.
/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp.csproj(1,1)
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
  at OmniSharp.MSBuild.MSBuildProjectSystem.LoadProject (System.String projectFilePath) [0x00038] in <b33b7bcd685c4ae4bb5069e4d26c1bf0>:0

[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Loading project: /home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor.csproj
[warn]: OmniSharp.MSBuild.MSBuildProjectSystem
        Failed to load project file '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor.csproj'.
/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor.csproj(1,1)
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
  at OmniSharp.MSBuild.MSBuildProjectSystem.LoadProject (System.String projectFilePath) [0x00038] in <b33b7bcd685c4ae4bb5069e4d26c1bf0>:0

[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        Loading project: /home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor-firstpass.csproj
[warn]: OmniSharp.MSBuild.MSBuildProjectSystem
        Failed to load project file '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor-firstpass.csproj'.
/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom/Assembly-CSharp-Editor-firstpass.csproj(1,1)
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
File name: 'Microsoft.Build, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
  at OmniSharp.MSBuild.MSBuildProjectSystem.LoadProject (System.String projectFilePath) [0x00038] in <b33b7bcd685c4ae4bb5069e4d26c1bf0>:0

[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.Stdio.Program
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.Stdio.Program
        Configuration finished.
[info]: OmniSharp.Stdio.Program
        Omnisharp server running using Stdio at location '/home/ideo/Documents/workspaces/unity_workspace/unitysimpleroom' on host 9536.

** Everything worked great before update to 1.18.0 **
update: I have to notice: VSCode integration plugin for Unity doesn't work anymore.

This looks the same as https://github.com/OmniSharp/omnisharp-vscode/issues/1847. Try running sudo apt-get install msbuild

Everything get work!
Thank you :)

Not a problem. Good luck!


Generator Params vs. TypeGen Params

Currently, the Generator constructor requires that the Params provided to the Generator match the Params provided to the TypeGen. There are cases where you would like the Generator to take additional parameters over the TypeGen. For example, consider a line buffer.
The line buffer needs to know at least 5 things: the width and height of the taps you want, the width of the image, the height of the image, and the bits per pixel. On the other hand, the type of the line buffer is very easily represented, it is just a single pixel in, and width*height pixels out. The TypeGen does not require any knowledge about the width and height of the image.
Instead, I propose that the Parameters provided to the Generator be a superset of the Parameters provided to the TypeGen.

An argument against would be we would need to know the image width in order to know the delay of a module, but I'm going to disagree with that by saying the delay of a module should be a property of a module, not a property of its interface.
I'm open to hear what anyone else thinks.

I think this is good and allows typegens to be able to be used by a larger set of generators.


chore(resources): move SP and AA to KMS Drive

site.aegee.org is temporarily offline, so this is the best time to comply more to the DPPS

Ignore the failed yamllint, will be fixed in #959

:tada: This PR is included in version 1.27.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SVG looks bad in Luna

maybe use PNG instead.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8223874-svg-looks-bad-in-luna?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github).

can you add a height: auto with developers tools (f12) on the logo and tell me what happens ?

nothing happens. with height: 100px; it looks like it should.

Ha, that's pretty bad indeed. :) It looks like we can add height: 66px (since that's the natural height at 454px wide, the max width).

I won't be that simpler because of responsive, I'm working on it.

Ok, using
<object data="images/logotype.svg" type="image/svg+xml"></object>

seems to do the trick, but we're losing the altattribute.
@cassidyjames If the image has fixed dimension, why couldn't we use a .png instead ?

There's a simpler solution:
#logotype {
    background-image:url(/images/logotype.svg);
    max-width: 100%;
    width: 454px;
}

The problem is that it needs to be embedded directly on the page in order
to be dynamically colored using the CSS fill attribute.
On Feb 5, 2015 12:15 PM, "Sam Hewitt"<EMAIL_ADDRESS>wrote:

There's a simpler solution:
#logotype {
background-image:url(/images/logotype.svg);
max-width: 100%;
width: 454px;
}
—
Reply to this email directly or view it on GitHub
https://github.com/elementary/mvp/issues/338#issuecomment-73107636.

so @cassidyjames, I will use an object tag, so it will be fillable.

@KeitIG sorry I just now got back to this.
Sorry, but you're wrong... you cannot use a linked CSS file in the site to set the fill when it's embedded using <object>. Go change the fill on the body { } rule in the CSS and see how the logotype doesn't change its color, but the logomark (which is not embedded in an object) does.

The whole point of using an SVG is that it's scalable and will pick up the text (when we're sure to always use both fill: and color: in the stylesheet).

I'm checking that.

@lewisgoddard I need your advice on this one. Is <?php include('images/logotype.svg'); ?> would bother you (semantically) ?
I you're ok with this, consider it fixed.

@KeitIG I don't understand how that will fix the problem.
We can't use PNGs, JPEGs, or Objects because they don't support fill, and <img src="thing.svg"> doesn't scale correctly in WebKit 1.x.
Does embedding the SVG in <svg ... ></svg> fix the scaling problem?
If include works, that's not semantically incorrect, just a bit unusual. Maybe comment following:
<?php
    // Embed the SVG to fix scaling in WebKit 1.x,
    // while preserving CSS options for the image.
    include('images/logotype.svg');
?>

Including the svg file with PHP seems the best option so.

So long as it fixes the scaling issue and doesn't break fill support, I'd merge that.

http://beta.elementary.io/branch/logotype-include/ is available for testing.
Should be fully responsive and remain fill compatible (proven by the fact the logo is red).

Sorry for haven't done that, I don't really have free time these days

That's okay, wasn't too much work.


[ApolloPagination] Fix memory leak in GraphQLQueryPager's Publisher implementation

We've detected a memory leak in the implementation of the Publisher protocol within GraphQLQueryPager.
Instead of treating this as a custom publisher – which the previous implementation certainly did – we just pare it down and forward to the internal publisher property.
A special thank you to @esahmed21 for confirming the leak and making note that it didn't exist in the previous version.

[!NOTE]
Why am I electing to call subscribe(_:) instead of receive(_:)?
subscribe(_:) in Combine has some additional observation logic that gets triggered before it forwards a subscription, which will ultimately invoke receive(subscription:) directly. That logic is important, as it prevents memory cycles & other unexpected outcomes. Apple's Combine docs include the incredible line: /// Always call this function instead of Publisher/receive(subscriber:)

@calvincestari I'm struggling to think of a way, as Publisher has no public property that details its subscribers.
The net impact of the previous code was that pager's deinit was never called when a UIViewController gets deinitialized.
My first thought was that we could test this by:

Declaring a UIViewController that owns a GraphQLQueryPager. The view controller subscribes to results.
Deinitialize the UIViewController
Ensure that the GraphQLQueryPager gets deinitialized

The problem is that we can't store an external reference to that pager, or we'll tick its reference count up and it won't deinit. 😬
I'll noodle on it some more.

I'm struggling to think of a way, as Publisher has no public property that details its subscribers.

I agree, it's a tricky one. My comment was a question of whether it's even possible, rather than "I think we should add a test".

I'm struggling to think of a way, as Publisher has no public property that details its subscribers.

I agree, it's a tricky one. My comment was a question of whether it's even possible, rather than "I think we should add a test".

I hear ya – but I really do wonder if it's possible 🤔

You can test this by storing it in a weak property, then setting the original reference to it to nil and checking that the weak var is now also nil.

You can test this by storing it in a weak property, then setting the original reference to it to nil and checking that the weak var is now also nil.

I've tried something like this:
  #if os(iOS)
  func test_deinitCalled_combinePublisher() {
    var vc: TestViewController? = TestViewController(client: client)
    weak var pager = vc?.pager
    XCTAssertNotNil(vc?.pager)
    vc = nil
    XCTAssertNil(pager)
  }
  #endif

But this seems to return a pass-result with both implementations.


feat: cuda miner support 2

Review Type Requested (choose one):

[ ] Glance - superficial check (from domain experts)
[ ] Logic - thorough check (from everybody doing review)

more context in https://github.com/Lilypad-Tech/lilypad/pull/167.
this branch clean the commit
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: add_link_here
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)

integration test passed


gotop: 1.5.0 -> 1.7.1

Motivation for this change
main motivation: having it up to date.
side-question: is someone aware of a go modules to deps.nix method? I used go2nix but I don't think this consults go.mod yet.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution  of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gotop


Unavoidable deprecated warnings

When compiling the simple test programs found in the wiki, I get spammed by the following warning:
/usr/local/include/compute/boost/compute/command_queue.hpp:1219:19: warning: ‘cl_int clEnqueueMarker(cl_command_queue, _cl_event**)’ is deprecated [-Wdeprecated-declarations]
             ret = clEnqueueMarker(m_queue, &event_.get());
                   ^

That function is not used, in fact clEnqueueMarker is not even found in the imports of the output binary. I believe you should define CL_USE_DEPRECATED_OPENCL_1_1_APIS in the headers somewhere.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26528106-unavoidable-deprecated-warnings?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github).

Yeah, it's because we need to check device's OpenCL version during the runtime. Otherwise, if somebody includes OpenCL 1.2 headers and device supports only 1.1 version, the wrong function would be called.
I think defining CL_USE_DEPRECATED_OPENCL_1_1_APIS (and also *_1_0_APIS, *_1_2_APIS) in CMakeLists.txt files for tests, examples and benchmarks is not a bad idea (not in the main CMakeLists.txt). Option in main CMakeLists.txt can be add for this (with default ON).

Closing, please re-open if you see more deprecated warnings.


How to pass a hyperlink to 'description'

In config.toml, in [params], is it possible to wrap a hyperlink in there?

I just pushed an update for this. You can use markdown syntax now, i.e. [name](url).


improved definition of pointed functor

After reading https://stackoverflow.com/questions/39179830/how-to-use-pointed-functor-properly
I thought we should make the definition less wrong.

I think when I wrote the original I was looking at the "Pointed" typeclass in haskell which doesn't have a requirement of functor so I didn't think that it was necessary. And in a way it's not. I type is pointed if any value can be lifted into it but intuitively a type is only a pointed functor if it's both pointed and a functor.


test: combine to travis jobs

Fixes #4018

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

travis is green here.


Incorrect EXPECTED_GO_VERSION in 4.0.1 'branch'

https://github.com/stackrox/stackrox/blob/f303f4adc072f61d01f7eb015feb0ae75f17b78b/EXPECTED_GO_VERSION#LL1
If I clone 4.0.1 'branch', go version is stated incorrectly:
git clone --depth 1 --branch 4.0.1 https://github.com/stackrox/stackrox
cat stackrox/EXPECTED_GO_VERSION
**go1.19.4**

It's supposed to be go1.20.3. I'd guess the reason is that 4.0.1 doesn't exist as a branch, it's rather a tag.
Is it possible to update the tagged EXPECTED_GO_VERSION retrospectively? Would it be a good idea to re-visit branching strategy to link it to releases and to make it inclusive of all the artefacts?

I think, the situation you are observing is correct. Versions 4.0.0 and 4.0.1 run on Go 1.19.4, whereas 4.0.2 runs on 1.19.9. Note, that there is only one branch for the 4.0 version; the patches (4.0.z) are available as tags.
I hope my answer from #6246 provides some additional explanation.


WARN (DUPLICATED EVENT)

[17:53:08 WARN]: [Multiverse-Core] "Multiverse-Core v4.2.2-b812" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [dumptruckman, Rigby, fernferret, lithium3141, main--].

It's Deprecated, not Duplicated. And this warning can be safely ignored, see #2000.

It's Deprecated, not Duplicated. And this warning can be safely ignored, see #2000.


Option to specify latitude/longitude

A "GPS" button could be shown if the picture does not have coordinates info already. Getting the coordinates automatically (with a preference to disable that feature for privacy reason) would be OK too.
A map showing the location would be wonderful, even more so if it allows to touch the real location (GPS is often wrong, or I might want to pinpoint the object itself rather than the location I shot it from)

Seems to be implemented in the latest release, closing this issue, feel free to re-open if I have misunderstood

This feature is not present in the latest release, I have never seen this being implemented (but I could be wrong so please let me know if this is actually available).
The latest release only contains a feature that opens your map app at the location of the picture. It does not allow to pick a better location.

@nicolas-raoul @madhurgupta10 Can I work on this issue?

@Ayan-10 Yes thanks! :-)

Hey @nicolas-raoul @madhurgupta10 , I am done with the "update coordinate feature" part of this feature. I put a dummy latitude and longitude for implementation and testing the coordinate update API calls. You can see this feature working in the video I attached.
https://user-images.githubusercontent.com/71203077/118808134-c4d10480-b8c6-11eb-8568-85e382c75598.mp4

@nicolas-raoul @madhurgupta10 Now I was thinking about making a location picker from where user will get their preferable location if they click on the FAB. (Now the app this feature is working on a dummy location). For creating this part of the feature I can use google play-services-location and google maps API key. Should I move forward with this idea of implementation?
If you have any suggestion of creating this part of this feature. You are welcome.
Thanks.

When I created this issue I mostly had in mind the upload wizard (set the location of the picture you upload), but editing the location of an already uploaded picture is a good feature to have, too. Feel free to switch to developing for the wizard (merit: higher priority), or keep developing for editing (merit: keep the work you have done), as you wish :-)
We want our app to work even on devices where Play Services is not installed. I wonder what would be the best way to proceed here. How about using the same map technology as the Nearby feature is using? https://docs.mapbox.com/android/plugins/examples/place-picker/

@nicolas-raoul Ok I understand. I will implement both of the features (upload wizard and edit). As I am almost done implementing this feature, I will make a PR for this. Then I will work on the upload wizrad.
Actually, This is a subtask of my this year's GSoC proposal. My proposal did not get selected for this year. So I decided to implement all of the tasks that I proposed to do in my this year's GSoC proposal.

Thanks for sharing this mapbox. This will be a great way to implement the location picker feature.
One more thing. Can you little elaborate me about the upload wizard that you mentioned. You meant that there should be a feature in the app that will allow user to upload location while uploading image. Am I right?

Wonderful! If you want to focus on editing, feel free. But if you want to try on the upload wizard too, here is how I would suggest to implement that UI part:
Can you see the map icon below (blue squarish button)?
Right now, it opens the location with an intent, which means the default map app opens (for instance Google Maps).
I suggest modifying the UI so that this button opens a Mapbox map showing the location, with two buttons at the bottom:

"View in map app"
"Modify location" <- this one lets the user pick the location. Once picked, the button could be hidden and a "Confirm" button shown instead, that would go back to the screen below while remembering the edited location (to be used in the location template and location-based category suggestions).

Minor detail, I would suggest a pencil icon here rather than the "sight" icon:

Thanks for guiding @nicolas-raoul . I am fully done with implementing the edit coordinates feature. I want to make PR now. Should I create a separate issue for that because As you said this issue is not about the feature that I implemented. I think creating an issue for this particular feature will be better.

Wonderful!
Don't worry, it should be fine here to have a single PR for this issue + an extra but very related feature.

@nicolas-raoul I made the PR of the edit coordinates feature. Please check out #4418 .

@nicolas-raoul I am almost done with implementing this feature. I used the location picker for picking the location. Now, after implementing it. The feature is working like this

Click the blue map icon.
Show a dialog containing two buttons "View in map app" and "Modify location".
"View in map app"  the default map app opens to show the location.
"Modify location" Location picker opens with showing the current location (If available) and if the user changes their location and presses the tick button. The location will change. Otherwise, It will remain the same location.

Is it ok? If you want to make me any change here. Please let me know.

@Ayan-10 Sounds good! 🙂

If I understand this correctly, @Ayan-10's work right now is to only allow editing the corrdinates of an image which already has location information associated with it. In that case, ...

"Modify location" Location picker opens with showing the current location (If available

... I feel it might be less helpful for "Modify location" to initially show the current location. It would be better to start with the location coordinates in the image. We could indeed show the "Locate me" bull's eye icon to easily go to the current location if you feel that would be necessary. I'm not sure if it is necessary but let's just not start with the current location, though 🙂

@sivaraam Sorry for not being clear. Hereby saying "current location" I mean current image location. What you are proposing me to do I said the same thing in the above comment. Hope now I can express my point correctly.

@nicolas-raoul What should I write in the message section?

Sorry here is what I had in mind, a bit more than a popup:

Seeing this, the user can decide whether they want to modify the location or not. Ideally it could be the same activity as the edition activity, with the buttons hiding (and other UI dynamic modifications) when needed, so that the user does not lose their zoom/position.


Prefer .js files over .wasm files

Bug report

What is the current behavior?
Assume we have a .js file and a .wasm file with the same file name in the same directory. When importing the file (without file extension), webpack will prefer the wasm file over the js file.
If the current behavior is a bug, please provide the steps to reproduce.
Provide an a.js file and an a.wasm file in the same directory with index.js:
require('./a')

Inspecting the webpack output bundle yields that webpack tries to bundle a.wasm instead of a.js.

What is the expected behavior?
Webpack should prefer the .js file over the .wasm file for compatibility.

Other relevant information:
webpack version:  4.8.3
Node.js version: 8.9.1
Operating System: Windows 10
Additional tools: -

There are multiple ways to solve this:

This is my favorite solution: always specify the extension
Override resolve.extensions in you configuration to specify your favorite order


gnu-config: 2023-09-19 -> 2024-01-01

Description of changes

Update version of gnu-config to latest version.
Motivated by work on new GHC Javascript backend, which uses the "javascript-unknown-ghcjs" tuple, which isn't recognized by the current version of gnu-config.
Targeting staging due to mass rebuild.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[x] Attempted, but stopped due to mass rebuild.

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

LGTM


Translation sync and render

Instead of auto scroll, I've added click to scroll functionality i.e when the user clicks on a text node, the translation panel automatically scrolls to the corresponding translation. Let me know your thoughts on this.

Looks great, @suheb--thanks!


A valid ReactComponent must be returned.

I may be missing something, but I can't seem to get a component up and running with the current setup I have.
Here's what it looks like, based on the example provided to create a LineChart:
React   = require('react')
ReactD3 = require('react-d3-components')

LineChart = React.createFactory(ReactD3.LineChart)

module.exports = React.createClass
  displayName: 'LineChartDemo'

  render: ->
    data = [
        {
        label: 'somethingA',
        values: [{x: 0, y: 2}, {x: 1.3, y: 5}, {x: 3, y: 6}, {x: 3.5, y: 6.5}, {x: 4, y: 6}, {x: 4.5, y: 6}, {x: 5, y: 7}, {x: 5.5, y: 8}]
        },
        {
        label: 'somethingB',
        values: [{x: 0, y: 3}, {x: 1.3, y: 4}, {x: 3, y: 7}, {x: 3.5, y: 8}, {x: 4, y: 7}, {x: 4.5, y: 7}, {x: 5, y: 7.8}, {x: 5.5, y: 9}]
        }
    ]

    return LineChart
      data: data
      width: 400
      height: 400
      margin: {top: 10, bottom: 50, left: 50, right: 10}

But I can't seem to get a valid ReactComponent out of this. I get this error:
Uncaught Error: Invariant Violation: LineChart.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.
Is this an issue others have run into? Or maybe I'm missing a step?

Actually, I seem to have figured out what was going on... It looks like it didn't have anything to do with CoffeeScript, or not creating a component correctly. It had to do with a discrepancy of React versions.
For my application I am using React 0.13.3. react-d3-components has React listed as a peerDependency with version 0.14.0. So when I installed this, a new version of React was pulled in along with it, which has no knowledge of the components the global react has created. So when I tried using your components, I kept getting that error message:
Uncaught Error: Invariant Violation: LineChart.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.
It's a pretty cryptic message given the cause of it, but as soon as I removed /react-d3-components/node_modules/react/, the LineChart displayed perfectly.
Is there a reason react 0.14.0 was listed? It seems to work fine with this earlier version. Might be worth listing a range of acceptable react versions instead of just one?

Good idea and sorry for the trouble! I am sorry I must have missed this issue during christmas holiday >_<

The reason react 0.14.0 was listed is because of some attribute that is used in line charts and only available from 0.14.

Okay - no worries! I figured everything out (mostly just learned how peerDepencies work) so it wasn't really an issue anymore. Might be worth putting a note somewhere in case someone else runs into it as it took quite a while to figure out what was going on.


[Request] List an alternative to Bismuth window decorations in documentation

Hi, ever since upgrading to KDE Plasma 6, I was quite annoyed that my Bismuth window decorations were absent. As such, I went to the trouble of finding an alternative, which I have now packaged on the AUR, which is sourced from Natalie Clarius' repo (works @ KDE).
I was thinking that it would be a nice addition to indicate this resource somewhere in the README / documentation, as in my opinion it provides an important part of the "tiling window manager feeling" in Plasma. Thanks for your consideration.
On another note, thank you very much for your work on Polonium. It's one of the main reasons as to why I enjoy using Plasma so much.

@lobroc thanks! Would you mind including (or making another package, given the naming, for) the titlebar variants?

Hi, I've created a new package which includes all the decorations at this location. People can therefore choose between everything or only the frame decoration. :+1:

@lobroc thanks a lot!

The problem with mentioning anything is that then people will ask for support on it. If the script breaks, people will ask here, if people can't install it they will ask here. If I maintained the window decorations I might mention it as an option, but I don't so I don't feel qualified to put it on the readme. Even the AUR package isn't mentioned anywhere other than stating that it's unofficial maybe.


Cannot seem to add validation

Does this library support validation of input?
I can't seem to add it in

There is no direct support for input at all.  The doco provides an example for doing input but it is only very basic.  Doing input and providing validation is left up to the developer.
This is an implementation question. Please ask over on the #react-table Slack channel (badge at the top of the README in the doco). Thanks.


ClipTokenizer error on Android

Greetings!
Loading a model with CLIPTokenizer on Android, using the latest release:
implementation 'com.microsoft.onnxruntime:onnxruntime-extensions-android:0.7.0'

and initializing the session like in SuperResolution example code:
val sessionOptions: OrtSession.SessionOptions = OrtSession.SessionOptions()
sessionOptions.registerCustomOpLibrary(OrtxPackage.getLibraryPath())
val session = ortEnv.createSession(model, sessionOptions)

throws an error:
Caused by: ai.onnxruntime.OrtException: Error code - ORT_FAIL - message: Fatal error: ai.onnx.contrib:CLIPTokenizer(-1) is not a registered function/op

Loading the same model with Python package built from rel-0.7 with similar initialization works fine:
so = ort.SessionOptions()
so.register_custom_ops_library(get_library_path())
sess = ort.InferenceSession(model.SerializeToString(), so)

What could be the cause of this error?

The current android package only contains a few of operators for the sake of the package size. Can you build the package from source by yourself?
https://github.com/microsoft/onnxruntime-extensions/blob/main/docs/development.md

Thank you for the answer! I will try building the package from source.


[POC] Move plugin and command names to the typelevel

This is more of a POC than finished code, but hopefully it can help to start a discussion if we want to move in that direction.
Now let me explain my motivation for doing this:
In the current state servant knows pretty much nothing about our api. All it knows is that there are two routes, but it doesn’t know which plugins exists. That means that all the nice stuff servant brings us, like auto generated bindings is pretty much useless. In particular I played around with servant-swagger which works but the documentation it generates is useless for that exact reason (pinging @tobiasgwaaler since he wanted to work on that).
With this approach we get at least the plugins and the commands correctly documented although we can and probably should take this further so the parameters a command receives are also somewhere on the typelevel so that servant-swagger can just pick them up and use them instead of saying that it needs an object.
Another cool idea would be to reuse that same type to generate the documentation and possibly also for the json stdio although I’m less sure how useful it is there. In general the servant approach seems to be to declare the API once and then generate the rest from it which I kinda like. @rvion might be interested in that since we wanted to go for code generation. Afaik there is not yet a python backend for servant but as soon as someone adds that you should be able to get bindings for the http backend for free.
Now to the downsides:

It adds complexity (although it was a lot of fun :)), I don’t have a problem with that but it might scare off beginners.
We now have three places where we have lists of plugins (PluginList and pluginList once in the documentation generator and once here). Even worse we have an additional list of command names here. Not sure how much effort we should put into fixing that until we have figured out #25 (which we can hopefully do rather soon). An upside of duplicating the command names is that at least for the servant backend (and once we use that type for the other backends also there) it allows selectively disabling certain commands.  However I can’t come up with a reason why you would want to do that right now.

What worries me most about this is that we break modularity. If someone wants to add a private plugin, say to access some proprietary company resources, then they have to fork hie and add their commands in to the master type.
Conceptually it is interesting, but I wonder if the benefits it brings are worth the cost.
Not that I am against it, just very wary,

What worries me most about this is that we break modularity. If someone wants to add a private plugin, say to access some proprietary company resources, then they have to fork hie and add their commands in to the master type.
Conceptually it is interesting, but I wonder if the benefits it brings are worth the cost.
Not that I am against it, just very wary,

Thanks for noting that I somehow thought that I was working in the executable. I know moved it to the executable so it’s at least not worse than the previous state when it comes to what you have to recompile. It might make sense to create a separate package for the executable anyway since we can then more easily share configuration without running into circular dependencies.

Thanks for noting that I somehow thought that I was working in the executable. I know moved it to the executable so it’s at least not worse than the previous state when it comes to what you have to recompile. It might make sense to create a separate package for the executable anyway since we can then more easily share configuration without running into circular dependencies.

Can we have the list of commands come out of the plugin, rather than being listed in the app?
e.g.
type PluginList = '[ 'PluginType "applyrefact" ApplyRefactListType
                           ...

Can we have the list of commands come out of the plugin, rather than being listed in the app?
e.g.
type PluginList = '[ 'PluginType "applyrefact" ApplyRefactListType
                           ...

I am pretty sure we can, I just didn’t want to put too much time into it if we decide not to go for this approach. I’ll give it a try later. If we don’t manage to remove the duplication between plugins and PluginList with enough type level hackery we could always go for template haskell. but I doubt we’ll have to resort to that.

I am pretty sure we can, I just didn’t want to put too much time into it if we decide not to go for this approach. I’ll give it a try later. If we don’t manage to remove the duplication between plugins and PluginList with enough type level hackery we could always go for template haskell. but I doubt we’ll have to resort to that.

I managed to get rid of the duplication so now all the plugin and command names are only declared once. It adds a bit of complexity but it wasn’t as bad as I expected it to be. Also somebody who actually knows what they’re doing will probably be able to make it a bit nicer :)

I managed to get rid of the duplication so now all the plugin and command names are only declared once. It adds a bit of complexity but it wasn’t as bad as I expected it to be. Also somebody who actually knows what they’re doing will probably be able to make it a bit nicer :)

One more thing to note here, this relies on PartialTypeSignatures to avoid repeating plugin and command names. Imho this is a perfect usecase for PartialTypeSignatures since the types here are not so much intended for human reading as they are for servant, but there might be objections

One more thing to note here, this relies on PartialTypeSignatures to avoid repeating plugin and command names. Imho this is a perfect usecase for PartialTypeSignatures since the types here are not so much intended for human reading as they are for servant, but there might be objections

My 2 cents: I understand the requirement, and having swagger integration will be great, but I fear the complexity for aspiring plugin writers. Heck, I have no idea what singleton types are or why I should care (-:. Maybe we should investigate how we can dynamically query plugins and generate the documentation?

My understanding is that this is a kind of magic layer above the plugin
that causes the type stuff to happen. So no great burden on plugin writers.
On Mon, Jan 4, 2016 at 11:19 PM, JP Moresmau<EMAIL_ADDRESS>wrote:

My 2 cents: I understand the requirement, and having swagger integration
will be great, but I fear the complexity for aspiring plugin writers. Heck,
I have no idea what singleton types are or why I should care (-:. Maybe we
should investigate how we can dynamically query plugins and generate the
documentation?
—
Reply to this email directly or view it on GitHub
https://github.com/haskell/haskell-ide-engine/pull/152#issuecomment-168812118
.

OK, understood.

@JPMoresmau I share your concern, but let’s take a look how the complexity increases by taking a look at a reasonably complex example: ghcmod.
What changed?

You have to use an underscore in a type signature for PartialTypeSignatures, imho that’s not really more complex.
You have to replace buildCommand by buildCommand' which is only necessary because I haven’t gotten around to cleaning it up, so that’s no increase in complexity.
You have to use (Proxy :: Proxy "string") instead of "string", now that’s definitely an increase in complexity, but it’s not too bad imho, especially if we document that.
You need to use the singleton variants of types, all that means for the user is to use a slightly different name, I also don’t think that increases the complexity noticeably.
You need to use Vinyl Recs instead of standard lists, again that’s an increase in complexity, but you don’t need to know anything about how they work or what they are except that the equivalent of : is :& and the equivalent of [] is RNil. Again we should document this, but at least to me (I am obviously biased) it doesn’t look too bad.

Regarding the actual types for use in Leksah. All types should be convertable to the old version (we actually use them still everywhere except for servant) so depending on what exactly you do in Leksah (I haven’t gotten around to looking at the code) it should require very little changes.

I think I’m done with the cleanup but I’ve probably forgotten some stuff (that’s why we review PRs :)).
We should definitely wait until @JPMoresmau gets some time to take a look at it from the leksah side, but then we can hopefully merge it rather soon as large PRs such as this one tend to get out of date pretty quickly.
Obviously not everyone is familiar with fancy typelevel magic (in fact I wasn’t really before I tried this) so if you are confused by parts please tell me and I’ll try to explain it to you and add a comment for future readers :)

the only change I had to make to get the code in Leksah to compile and work was changed CommandDescriptor to UntaggedCommandDescriptor. So I guess we're good. Unless maybe renaming these two things so that the type alias has the shortest name would be better?

@JPMoresmau Thanks for testing it. Let me explain the naming. In most cases the previous name now refers to a parametric version, e.g. CommandDescriptor is parametrized by the type for the contexts and the params. Then there is UntaggedCommandDescriptor which simply instantiates that type with lists and TaggedCommandDescriptor (which I actually forgot, I just added it) which instantiates that type using Vinyl records. I suppose I could rename the parametric one to GenericCommandDescriptor and the one using lists to CommandDescriptor but I’m not really sure if this is better. However if you and @alanz prefer this, I’ll obviously change this.

I think the normal usage case (for plugin writers/IDE integrators) should be the natural name, the internal plumbing names can be longer.

@alanz Plugin writers and IDE integrators (which in this case is limited to IDEs written in haskell) use different things here, in particular plugin writers need to use the tagged versions because the types we use in servant have to come from somewhere and the IDEs (meaning Leksah) use the simple types. One of them needs to use a longer name. Note that the data constructor is the same for both types, the only thing different is the type synonym (which doesn’t need to be used, you can always manually expand it). Now I’m not opposed to changing CommandDescriptor to GenericCommandDescriptor, but then we should imho also change the name of the data constructor since it’s confusing if they don’t correspond to the type name. However if we do that it gets even more confusing since then IDEs use CommandDescriptor as a type, but GenericCommandDescriptor as a data constructor. I am not sure if this really improves the situation.

Since github doesn’t send mails for new commits: I just updated this pr to be mergable again.

Well done, quite an effort
On Thu, Jan 7, 2016 at 10:55 PM, Moritz Kiefer<EMAIL_ADDRESS>wrote:

Merged #152 https://github.com/haskell/haskell-ide-engine/pull/152.
—
Reply to this email directly or view it on GitHub
https://github.com/haskell/haskell-ide-engine/pull/152#event-508717334.

Thanks.


httpserver.requests[-1].json raises ClientDisconnected

I am using the following code in my test:
httpserver.serve_content('SUCCESS')
function_that_does_a_post_request()
received_request = httpserver.requests[-1]
assert received_request.json == {'mock': 'data'}

during the last instruction, I get the following exception:
../venv/lib/python3.9/site-packages/werkzeug/wrappers/request.py:561: in json
    return self.get_json()
../venv/lib/python3.9/site-packages/werkzeug/wrappers/request.py:611: in get_json
    data = self.get_data(cache=cache)
../venv/lib/python3.9/site-packages/werkzeug/wrappers/request.py:423: in get_data
    rv = self.stream.read()
../venv/lib/python3.9/site-packages/werkzeug/wsgi.py:829: in readall
    data = self.read(1024 * 64)
../venv/lib/python3.9/site-packages/werkzeug/wsgi.py:796: in readinto
    self.on_disconnect(error=e)

../venv/lib/python3.9/site-packages/werkzeug/wsgi.py:751: ClientDisconnected

werkzeug.exceptions.ClientDisconnected: 400 Bad Request: The browser (or proxy) sent a request that this server could not understand.

Now for the weird part: I set the PyCharm debugger to have a break point at the instruction that stores the request in httpserver. Inside the debugger, I was able to read the json as expected. Continuing from there into my test, the exception did not occur and it was possible to read the json as normal.
My suspicion is that the request's payload isn't read from the network interface unless needed (I don't really know the libraries that well here). This makes sense as most requests don't need to be stored like httpserver does. So when we try to read the payload after the connection object is long gone, this leads to that error.
A quick fix would be to manually call request.json inside the previously linked function.

Thanks for the detailed report and the suggestion!
I think calling request.json() wouldn't necessarily work in general because not every request body is going to be valid JSON, right? But I assume there should be some equivalent that reads the raw data, and that should probably do the trick. (I don't know the Request API offhand 😅) I'll figure out the details when I get a chance - maybe over the weekend - or if you happen to find a good fix before I do, I'm always happy to accept a PR.

After a quick look I figured out two things:

The request.data property is the more generic one you may want to use here
Internally, it uses the get_data() method on the object, which does have caching functionality implemented, so it seems to confirm my suspicion

I'll create a pull request.


The titles of the blocks do not use boldface

The titles of the blocks do not use boldface when using the EAFIT Beamer theme.

Any news on it?

@asr  Please check:
https://github.com/alejogm0520/latexEAFIT/commit/dc0d1325f430fa95c25edcb505983e716de96d9d

Thanks!


Layout inheritance

Hey! Great templating language here! Feels very familiar from the Rails world. :-D
I was wondering if there are any layout inheritance feature implemented:
Eg.
base.html.slim:
doctype html
html{lang="en"}
  head
    title My App
  body
      = render @view_module, @view_template, assigns

app.html.slim:
= render layout: 'head' do
  = render ComponentView, "navbar.html", conn: @conn
  = render @view_module, @view_template, assigns
  = render ComponentView, "footer.html", conn: @conn

Cheers

up ?

@augnustin no need to bump issues, we get to issues when we've got availability 😁
You should be able to call render/3 in Slime, have you tried it?


[IT] Feedback for: https://developers.google.com/web/fundamentals/getting-started/?hl=it

"Start Your Site with Web Starter Kit" in https://developers.google.com/web/fundamentals/getting-started/?hl=it and all its subsections are not translated in Italian, whereas the right section is available in Italian too.

Yep, we didn't have the resources to do it all, but we needed some critical
pages translated.
P
On Sun, 1 Mar 2015 16:06 trimalcione<EMAIL_ADDRESS>wrote:

"Start Your Site with Web Starter Kit" of
https://developers.google.com/web/fundamentals/getting-started/?hl=it and
all its subsections are not translated in Italian, whereas the right
section is available in Italian too.
—
Reply to this email directly or view it on GitHub
https://github.com/google/WebFundamentals/issues/1154.


exp/orderbook: Optimize in memory path finding

PR Checklist
PR Structure

[ x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot

Thoroughness

[x ] This PR adds tests for the most critical parts of the new functionality or fixes.
[x] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[x] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ x] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
When profiling the in memory path finding implementation I determined
that "math/big" operations was a significant bottleneck. Removing those operations resulted in an 8x improvement
Goal and scope
Improve performance of in memory path finding
Summary of changes

remove use of big.NewRat in edges.go
remove use of big.Int in price/main.go

Known limitations & issues
N / A
What shouldn't be reviewed
N / A

it looks like bits.Mul64,  bits.Div64, and bits.Add64 are only supported in go 1.12 or higher. The current release of golang is 1.13

it looks like bits.Mul64, bits.Div64, and bits.Add64 are only supported in go 1.12 or higher. The current release of golang is 1.13

8x speed improvement sounds awesome and would be great to ship it ASAP. Maybe build tags could help? Go versions before 1.12 can use the old code and 1.12+ the new better code. https://medium.com/@theckman/version-constraints-and-go-c9309be15773

it looks like bits.Mul64, bits.Div64, and bits.Add64 are only supported in go 1.12 or higher. The current release of golang is 1.13

8x speed improvement sounds awesome and would be great to ship it ASAP. Maybe build tags could help? Go versions before 1.12 can use the old code and 1.12+ the new better code. https://medium.com/@theckman/version-constraints-and-go-c9309be15773

good idea, I'll look into this tomorrow!

@bartekn can you take another look? I've updated the pr to have two implementations: one for go 1.12+ and one for go 1.10/1.11


jax.random.truncated_normal generates -inf

Values should be truncated  to [-100, 100] and most of the time it works. However for the seed in the example below it generates -inf.
import jax.numpy as jn
import jax.random as jr
import jax
import jaxlib

jax.__version__
# '0.2.1'
jaxlib.__version__
# '0.1.55'

print(jr.truncated_normal(jn.array([41787198,<PHONE_NUMBER>], 'uint32'), shape=(10000, 32), lower=-100, upper=100).min())
# -inf

As it happens I fixed this yesterday: https://github.com/google/jax/pull/4548
It isn't in a jax release yet.


Mention GitHub student pack in Coveralls

Coveralls is now part of the GitHub student developer pack.

Coverage remained the same at 86.957% when pulling 9fee4b3a0b17e4cd8ded3979b45339bef99f812e on zkotti:coveralls into 2ce57d7bffffe95290a7d4eb3150eadd3cfddd92 on AntonisGkortzis:master.


crossgen2 fails with 139 exit code on Arm64

This is causing a failure in the VMR for .NET 9 Preview 1 when building the installer repo. It fails in the Ubuntu2204Arm64_Offline_MsftSdk_arm64 job (example build [internal link]).
Error:
/vmr/src/installer/src/redist/targets/Crossgen.targets(163,5): error MSB6006: "crossgen2" exited with code 139. [/vmr/src/installer/src/redist/redist.csproj]

Here is a binlog:
sourcebuild.installer.zip
We need this resolved for .NET 9 Preview 1.

@jkoritzinsky - Can you help investigate? This was working recently and regressed.

I can try but I don't have a Linux ARM64 machine. Do you know the first VMR build that this broke in? I'll see if I can narrow down where the failure from.

It looks like the most recent passing build was https://dev.azure.com/dnceng/internal/_build/results?buildId=2359219&view=results and the first failing build was https://dev.azure.com/dnceng/internal/_build/results?buildId=2359821&view=results.
The runtime range of commits between these two is https://github.com/dotnet/runtime/compare/8accd8073a44f5835b39e0584f17d1aff1771121...e99836a899bdb97be5afbbed8d90573ee5635b30
The commits that pop out to me as possibly causing crossgen2 crashes are:

https://github.com/dotnet/runtime/commit/205ef031e0fe5152dede0bd9f99d0f6f9e7f1e45
https://github.com/dotnet/runtime/commit/d00587db256d5684ba7458225c35a06347b487eb

I think the second is more likely than the first.
cc: @EgorBo

Checking now

It's getting a different error now and failing with error code 134:
/vmr/src/installer/src/redist/targets/Crossgen.targets(172,5): *** stack smashing detected ***: terminated [/vmr/src/installer/src/redist/redist.csproj]

binlog
Failing build (internal link)

It's consistency failing but not always failing with the same error. The two errors mentioned in this issue above are all I've seen so far.

Interestingly, the build succeeded in this recent run (internal link). But I'm not sure I trust that the issue is resolved. Is it perhaps an intermittent issue? The source changes that exist between the two builds don't include any runtime changes at all.

Yes, it is possible that the failure is intermittent given your sample with the 134 exit code. It's likely a native corruption somewhere in crossgen2. If this is using a live crossgen2 (which I think it is), then it could be anywhere in the JIT, GC, or CoreCLR runtime. This also means it could have appeared before the first instance during the time frame where the build was failing before getting to installer, which makes this harder to diagnose...

There's been 3 other builds since that one that passed and they've all failed.

@MichaelSimons is there an easy way to test a build with a runtime change reverted? We might see some benefit at just looking at a build with each of those two commits that Jeremy identified reverted

@mthalman I see you're testing a revert of @EgorBo 's change here: https://dev.azure.com/dnceng/internal/_build?definitionId=1219. Could you also test a revert of https://github.com/dotnet/runtime/commit/205ef031e0fe5152dede0bd9f99d0f6f9e7f1e45 in parallel just to be comprehensive in our checking? (It seems unlikely to be the problem; it should have only deleted unused code)

Oh, I guess @EgorBo triggered those runs; @EgorBo maybe you could trigger runs with Jakob's change reverted?

So current status: I am pretty sure it's not https://github.com/dotnet/runtime/commit/d00587db256d5684ba7458225c35a06347b487eb although it looked like it was because several runs with the revert were green but it turned out the error doesn't always manifest.
I've reproduced it locally but when it failed and I extracted the exact crossgen command and ran it again:
/home/egorbo/dotnet-dotnet/src/installer/artifacts/sb/package-cache/microsoft.netcore.app.crossgen2.ubuntu.20.04-arm64/9.0.0-preview.1.24073.11/tools/crossgen2 \
"/home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/sdk/9.0.100-preview.1.24075.1/FSharp/FSharp.Compiler.Service.dll" \
-o "/tmp/bxhyzqnu.o3h/FSharp.Compiler.Service.dll" \
--targetarch arm64 \
-r /home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/sdk/9.0.100-preview.1.24075.1/FSharp/runtimes/win/lib/net9.0/*.dll \
-r /home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/sdk/9.0.100-preview.1.24075.1/FSharp/*.dll \
-r /home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.1.24073.11/*.dll

it failed with:
Unhandled exception. System.CommandLine.CommandLineException: Multiple input files matching same simple name /home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/sdk/9.0.100-preview.1.24075.1/FSharp/FSharp.Compiler.Service.dll /home/egorbo/dotnet-dotnet/src/installer/artifacts/bin/redist/Release/dotnet/sdk/9.0.100-preview.1.24075.1/FSharp/FSharp.Compiler.Service.dll
   at System.CommandLine.Helpers.AppendExpandedPaths(Dictionary`2, String, Boolean)
   at System.CommandLine.Helpers.BuildPathDictionary(IReadOnlyList`1, Boolean)
   at System.CommandLine.CliArgument`1.<>c__DisplayClass8_0.<set_CustomParser>b__0(ArgumentResult argumentResult, Object& parsedValue)
   at System.CommandLine.Parsing.ArgumentResult.ValidateAndConvert(Boolean)
   at System.CommandLine.Parsing.CommandResult.ValidateArguments(Boolean)
   at System.CommandLine.Parsing.ParseOperation.Validate()
   at System.CommandLine.Parsing.ParseOperation.Parse()
   at System.CommandLine.Parsing.CliParser.Parse(CliCommand, IReadOnlyList`1, String , CliConfiguration )
   at System.CommandLine.CliConfiguration.Invoke(String[])
   at ILCompiler.Program.Main(String[])
run.sh: line 7: 1979606 Aborted                 (core dumped)

with error code 134.
So it could be some high-level issue in crossgen/its config or it's still could be a codegen bug that changed crossgen's behaviour?

The latest main VMR is red on a crossgen failure that I didn't find in this issue, so linking it in case its related or might help (source)
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB6006: "crossgen2" exited with code 139. [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018: The "Crossgen" task failed unexpectedly. [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018: System.IO.IOException: Directory not empty : '/tmp/xinmgcn5.ilw' [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018:    at System.IO.FileSystem.RemoveEmptyDirectory(String fullPath, Boolean topLevel, Boolean throwWhenNotEmpty) [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Crossgen.Execute() in /_/src/installer/src/core-sdk-tasks/Crossgen.cs:line 81 [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/vmr/src/installer/src/redist/redist.csproj]
    /vmr/src/installer/src/redist/targets/Crossgen.targets(181,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/vmr/src/installer/src/redist/redist.csproj]

Long story short: the issue was handled offline and it turned out that the issue was introduced in https://github.com/dotnet/runtime/pull/96969 and the fix (revert) is https://github.com/dotnet/runtime/pull/97679 (although, it's probably reverted only from release/9.0p1 branch?)

although, it's probably reverted only from release/9.0p1 branch?

Yes, and the latest VMR builds for release/9.0 are green (source).
main is still failing in the same Ubuntu leg as before with the exception linked above. Since the original issue was about preview-1 and the exceptions seem to be different, should we open a different one for tracking the failure in main?

although, it's probably reverted only from release/9.0p1 branch?

Yes, and the latest VMR builds for release/9.0 are green (source).
main is still failing in the same Ubuntu leg as before with the exception linked above. Since the original issue was about preview-1 and the exceptions seem to be different, should we open a different one for tracking the failure in main?

It's not a separate issue. The fix wasn't applied to main. See https://github.com/dotnet/runtime/pull/97679#issuecomment-1921182993

Should be fixed by https://github.com/dotnet/runtime/pull/97817

I'm not sure that the changes in https://github.com/dotnet/runtime/pull/97817 fixed the issue. Either that or there's another related issue. This change finally flowed into the VMR on Friday and the build right after it came in failed in the Arm64 build leg when calling crossgen2. This time it was during the _CreateR2RImages target. Related build (internal link). The build after it passed however. But we previously saw inconsistent results for this issue as well. I'm running a full build again to get a another data point.

The new build passed as well. I'm going to close this and hope things are ok. I'll reopen if it pops up again.

@mthalman - I ran from the tip around noon today and encountered the error. Build link (internal). It's possible that the change hadn't flowed in yet (parent commit was https://dev.azure.com/dnceng/internal/_git/dotnet-dotnet/commit/b07c6879698f9df26ae94f8d9c3e63b721242207?refName=refs%2Fheads%2Fdev%2Fellahathaway%2Ftest), but I wanted to make you aware.

Yep, it's still happening and is intermittent. Pinging @janvorli since the changes in https://github.com/dotnet/runtime/pull/97817 don't seem to be sufficient. It's gotten farther in the build than before but now fails when invoking crossgen2 as part of creating R2R images. Again, this is still limited to the Arm64 build leg.
/vmr/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net9.0/Microsoft.NET.CrossGen.targets(469,5): error MSB6006: "/vmr/.dotnet/dotnet" exited with code 139. [/vmr/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]
    OutputProperties
        _ReadyToRunCompilerExitCode = 139
        _ReadyToRunWarningsDetected = False

pipeline run
binlog

@mthalman can you please share repro instructions with me? I am not familiar with the source build and while I have tried to mimic what I've seen in the ci log, I am not sure if I did it right.
I am building it on a physical arm64 linux device with Ubuntu 22.04, so I am not using docker. The commands I've tried to use were:
./prep.sh
BUILD_SOURCEVERSION=220c455bc727ab0a8bdd9feb61f474a605d30339 ./build.sh --ci --clean-while-building --prepareMachine --source-only

(I have used the current main for build, so I've changed the 220c455bc727ab0a8bdd9feb61f474a605d30339 to the commit hash of my checkout)

It should be enough to just run these commands:
./prep.sh
./build.sh --sb

Depending on how much disk space you have available, you may need to run --clean-while-building which cleans up repo outputs after they're done building successfully. That cleans up binaries but leaves logs.

@mthalman my build keeps failing due to this:
CSC : error CS1566: Error reading resource '_framework/blazor.web.js' -- 'Could not find a part of the path '/home/janvorli/git/dotnet/src/aspnetcore/src/Components/Web.JS/dist/Release/blazor.web.js'.' [/home/janvorli/git/dotnet/src/aspnetcore/src/Components/Endpoints/src/Microsoft.AspNetCore.Components.Endpoints.csproj] [/home/janvorli/git/dotnet/repo-projects/aspnetcore.proj]
I've tried several times, even with git clean -xdf in between. Any idea what is wrong?

That looks related to not having the latest source. Have you pulled latest from main branch of the VMR? That error was relevant in an older commit but was fixed by https://github.com/dotnet/installer/pull/18641/commits/90ccc0ca4d42e91029a392fa210fdca06447b50b in https://github.com/dotnet/installer/pull/18641.
Oh, and you'll also need to run it in with the --online switch to avoid https://github.com/dotnet/source-build/issues/4129.

I did a fresh clone today, I didn't have that repo locally. I am on this commit:
commit dc4df39f794e6b9c565d721986b71a056288b812 (HEAD -> main, origin/main, origin/HEAD)
Merge: 55519d6838 85d7a9e37c
Author: dotnet-maestro[bot]<EMAIL_ADDRESS>Date:   Fri Feb 16 13:18:50 2024 +0000

    [Recursive sync] installer / 6d1abb7 → 9b54914

    Updated repositories:
      - installer / 6d1abb7 → 9b54914
        https://github.com/dotnet/installer/compare/6d1abb74140d80b81d4f482a49332d55f89468d7..9b54914494e95df2d6e72803dfe7d2193cdebb22
      - aspire / 8ec92cb → b2107ab
        https://github.com/dotnet/aspire/compare/8ec92cbc5fbcba7a677fb52aaa4b0118f1ed17f4..b2107ab9a2b96b609f16997525f694f587e3018e

    [[ commit created by automation ]]

I've synced to the latest state now again and I am retrying.

Interesting. Well that might be another issue with Arm then. Since this is failing in the build of the aspnetcore repo, it means you passed the point of the crossgen failure in the runtime repo (runtime builds before aspnetcore). So this means you're not repro'ing the issue. Be aware that this is an intermittent issue so you may need to build several times to get it. To get a fresh VMR to start over from, I execute git clean -fdx and git checkout -- .

Ok, I'll ignore that error then and just retry a clean build.

I don't think this has anything to do with R2R itself. The failure in the linked issue is due to an unhandled exception. The error message is:
      Unhandled exception. System.CommandLine.CommandLineException: Target OS 'centos' is not supported
         at System.CommandLine.Helpers.GetTargetOS(String) in /_/src/runtime/src/coreclr/tools/Common/CommandLineHelpers.cs:line 84
         at System.CommandLine.CliArgument`1.<>c__DisplayClass8_0.<set_CustomParser>b__0(ArgumentResult argumentResult, Object& parsedValue)
         at System.CommandLine.Parsing.ArgumentResult.ValidateAndConvert(Boolean)
         at System.CommandLine.Parsing.CommandResult.ValidateOptions(Boolean)
         at System.CommandLine.Parsing.CommandResult.Validate(Boolean)
         at System.CommandLine.Parsing.ParseOperation.Validate()
         at System.CommandLine.Parsing.ParseOperation.Parse()
         at System.CommandLine.Parsing.CliParser.Parse(CliCommand, IReadOnlyList`1, String , CliConfiguration )
         at System.CommandLine.CliConfiguration.Invoke(String[])
         at ILCompiler.Program.Main(String[]) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler/Program.cs:line 753

@agocke the Ubuntu run seems to be failing with 139 during crossgen2 run though.

Ah, you're right I was lookihg at a different log

I don't think this has anything to do with R2R itself. The failure in the linked issue is due to an unhandled exception. The error message is:
      Unhandled exception. System.CommandLine.CommandLineException: Target OS 'centos' is not supported
         at System.CommandLine.Helpers.GetTargetOS(String) in /_/src/runtime/src/coreclr/tools/Common/CommandLineHelpers.cs:line 84
         at System.CommandLine.CliArgument`1.<>c__DisplayClass8_0.<set_CustomParser>b__0(ArgumentResult argumentResult, Object& parsedValue)
         at System.CommandLine.Parsing.ArgumentResult.ValidateAndConvert(Boolean)
         at System.CommandLine.Parsing.CommandResult.ValidateOptions(Boolean)
         at System.CommandLine.Parsing.CommandResult.Validate(Boolean)
         at System.CommandLine.Parsing.ParseOperation.Validate()
         at System.CommandLine.Parsing.ParseOperation.Parse()
         at System.CommandLine.Parsing.CliParser.Parse(CliCommand, IReadOnlyList`1, String , CliConfiguration )
         at System.CommandLine.CliConfiguration.Invoke(String[])
         at ILCompiler.Program.Main(String[]) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler/Program.cs:line 753

That was a separate issue (identified in https://github.com/dotnet/source-build/issues/4111#issuecomment-1938755018), that has since been fixed.

@mthalman mystery solved. It is not a new issue. The thing is that crossgen doesn't use the current build of runtime, but rather an older version (it uses the dotnet sdk in the .dotnet folder). In this case, it used version 9.0.0-preview.2.24080.1 built from commit d40c654c274fe4f4afe66328f0599130f3eb2ea6 that predates the fix in main by two days.

Ok, I'll update the VMR to use a more recent SDK and check the results.

This is continuing to be an issue. The most recent related error that I've seen is in runtime:
/vmr/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net9.0/Microsoft.NET.CrossGen.targets(357,5): error NETSDK1096: Optimizing assemblies for performance failed. You can either exclude the failing assemblies from being optimized, or set the PublishReadyToRun property to false. [/vmr/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]
Link to build (internal link)

The bootstrap work to resolve this is still pending.

This should be fixed by https://github.com/dotnet/installer/pull/18763

Hi,
I also started to hit this issue, just under FreeBSD, could I ask for some info what was the issue and/or which commit fixed that?

Reopening this because it's not yet resolved for source build in the VMR. We're still waiting for a bootstrap of the VMR onto an SDK build which contains the fix for this issue. But that's currently blocked on https://github.com/dotnet/source-build/issues/4206.

Hi, I also started to hit this issue, just under FreeBSD, could I ask for some info what was the issue and/or which commit fixed that?

@sec - This is the fix: https://github.com/dotnet/runtime/pull/97817. But it's not enough to have the fix in the source that you're currently building. You need to build with an SDK that has this fix. That's what we're currently working towards for the VMR, to get it bootstrapped with an SDK that has this fix in it. That will allow builds to work using that SDK.

@mthalman Thanks for the info. If I get it correctly, I should wait for your work to be done, then I can crosscompile SDK for FreeBSD and use it as bootstrap for preview-2, which should be fine. BUT, as looking at this, it's a bug in libunwind - which under FreeBSD is taken from ports - looking in there I've already found https://github.com/libunwind/libunwind/issues/715 - this should also be fixed otherwise I will still hit this in future :)

The fix was flowed into the VMR with https://github.com/dotnet/installer/pull/19145


Property should have a from_yaml

To be consistent, since the YAML has actually a property level. The schema of the property should be built from the from_yaml of the property as well.

moved parameter creation all to Property


style(store): translate Chinese comment to English

as title.

Considering the large number of files, can be split into multiple PRs...
Using a more effective translator and matching method...

close by #2623 and #2624


[Feature] Static or CDN version.

Started working with ethjs recently and one of the pain points was including it for online examples,
( had to use the one from one of the sample files) and couldn't make one with browserify. It also feels like this should be included front and center since  your landing page states "Only 103 kB minified!"
Thanks

We should totally push this to a CDN, do you have any in mind?
Sent from my iPhone

On Oct 19, 2017, at 2:17 PM, Keno Leon<EMAIL_ADDRESS>wrote:
Started working with ethjs recently and one of the pain points was including it for online examples,
( had to use the one from one of the sample files) and couldn't make one with browserify. It also feels like this should be included front and center since your landing page states "Only 103 kB minified!"
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

https://cdnjs.com/ hosts lots of oss libs

@SilentCicero +1 on cdnjs although they make you go through some loops:
https://github.com/cdnjs/cdnjs/blob/master/CONTRIBUTING.md
In all honesty I would settle for a sanctioned ethjs-min.js somewhere in the repo I can include in projects.

JsDelivr automatically provides a CDN link for github projects. I've been using this path for testing codepens etc<EMAIL_ADDRESS>I'm not sure this is endorsed by the maintainer or not. Could include it in the readme but I imagine you would want to be sure of security standards of this CDN beforehand

@monokh I'll include this in the readme, thanks!


Unable to add Camera accessory after failed (Add Accessory)

I’ve run into a small problem:
I have a few Nest Cams. Have been able to get your plugin up and running, and was able to add most of my Nest Cams to HomeKit using the Home.app. Unfortunately two of the Nest Cams failed when trying to add them, and now they’re not showing up as available when I try the “Add Accessory” process again. I can see from homebridge output that the plugin is exposing them as available, but they don’t show up in Home.app when I try to Add them.
How can I make the missing Cameras appear again so I can add them? They were there before the Adding failed (HomeKit Error: “Could not add Accessory”).
Hope someone can help.

I had

Same issue


Published resources cannot be overriden

I have published fort views to my app and they cannot be overridden as per Laravel documentation.
I wanted to change the blade layout template that Rinvex Fort is extending to another one and it seems to ignore the published views that I modify and still use the ones in the fort package instead of the published ones in /resources/views/vendors/rinv....
What could be the problem?
I saw this  on laracast, but can't figure out if fort has a class alias that I am not seeing... Fort is using loadViewFrom() as expected, but still nothing is happening. My guess is that the directory to which it is being published to isn't correct.
This goes for the config file as well... the configuration isn't merging at all.

Well, that means you didn't register the Fort service provider in your app.php config file within $providers array. Have you?
Rinvex\Fort\Providers\FortServiceProvider::class,

It's registered, fort is actually running and we love it. The change was in the software we are making. I used different layout files for different purposes and wanted authentication to use another layout file that's not app.blade.php. So when the change was done, it was expected that publishing the views would enable us to do an override of the default layout that was being used by fort, but nothing was working. We then updated fort for other reasons (backend implementation 👍) and still this same issue wasn't addressed, probably unknown. This was noticed even with configuration as well, we had to put it in config/app.php as a workaround earlier... Generally speaking all published fort resources, language, views and configuration (except for DB migrations), are not being picked up by Laravel. All other published packages are working well on doing that.

Investigated right now, and seems to be true.. Just few minutes to make sure what's wrong & fix it in a quick update.. 👍

Wow that was a good fix. Care to explain what was wrong?
Something else came up from that fix, minor I think. Let me create a separate issue for it.

I know this is an old issue, and I maybe I don't remember what was the case, but from what I see in the fix there was a wrong views namespace. Hope this helps.


Expired key for deb.asc files

Hi,
the key for signing and verifying the install files is expired.
Steps to reproduce:

Install the key

gpg --recv-key 18AD5014C99EF7E3BA5F6CE950BDD3E0FC8A365E
gpg: key 50BDD3E0FC8A365E: 7 signatures not checked due to missing keys
gpg: key 50BDD3E0FC8A365E: "CoreOS Application Signing Key<EMAIL_ADDRESS>not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

Download the .deb files

curl -L https://github.com/rkt/rkt/releases/download/v1.30.0/rkt_1.30.0-1_amd64.deb -o /tmp/rkt.deb
curl -L https://github.com/rkt/rkt/releases/download/v1.30.0/rkt_1.30.0-1_amd64.deb.asc -o /tmp/rkt.deb.asc

Try to verify

gpg --verify /tmp/rkt.deb.asc
gpg: assuming signed data in '/tmp/rkt.deb'
gpg: Signature made Mon 16 Apr 2018 11:50:05 AM CEST
gpg:                using RSA key 5B1053CE38EA2E0FEB956C0595BC5E3F3F1B2C87
gpg: Good signature from "CoreOS Application Signing Key<EMAIL_ADDRESS>[unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 18AD 5014 C99E F7E3 BA5F  6CE9 50BD D3E0 FC8A 365E
     Subkey fingerprint: 5B10 53CE 38EA 2E0F EB95  6C05 95BC 5E3F 3F1B 2C87

@ajeddeloh is working on it!

I'm curious about the project and wanted to try out rkt on my Ubuntu system. I also came across this issue with the expired key for the Debian package.
Any luck signing the package with a new key? What's the story?
Thanks for your time!

@darrenkearney grab the new pubkey from https://coreos.com/security/ and it should be valid. We extended the subkeys still in use, the only one we didn't was the matchbox subkey, but those are now signed by dalton's personal key.

rkt packages are also in the official Debian repository where they are signed with current distro key(s).

Thanks folks!


Cannot get on a second rocket seat

Minecraft Version:
1.10.2
Advanced Rocketry Version:
1.2.5a
LibVulpes Version:
is this the latest curseforge build?
Yes
Explain issue in detail:
When I travel from my homeworld to a moon... and I build a second spaceport there with a second rocket, I cannot sit on that rocket as if it would not have a seat.
This happend to me multiple times:
Once when I had one rocket with a seat and build a second spaceport with a second rocket
Second time when I traveled to a moon, lost the rocket on landing (it felt into void, I saved myself using jetpack) and so built a new one on a new spaceport.
In both cases the second rocket was the same as the first one, had guidance computer and seat... except I could not board this rocket for some reason. Do you have some advice what to do in such a case? I am trying combinations of assemble/disassamble, replacing the Rocket Assembler, restarting the Saved Game and the whole Minecraft, but so far I have no pattern how to fix it.
I tried several rockets... from the second cosmodrom, none accept passangers.
From the first cosmodrom however, it acceps passangers as normal.

Can you send screenshots of the rockets that are not working?

Sure thing... just, that is the same skeletal rocket I use in the whole pack... Engines + Fuel Tanks + 1 Guidance Computer + 1 Seat... And the Same rocket works from cosmodrome 1... and does not work from cosmodrome 2. Today I will try to find out what is the mod/setting constelation, which is causing this... I will send you the screenshots in few minutes.

Ok, did some trials...and I figured out following: The Cosmoport 2 Location is wrong for some reason.
All ships I launched from it disapeared and did not arrived into their destination... Also All ships with seat did not registered as passanger ships. I was able to force the ships to land back by breaking n placing on random places the Rocket Assembler of this SpacePort.
Then i tried different locaton (SpacePort 3) and the ship was registered as passanger there and worked.... so I was thinking that maybe the height is wrong (SpacePort 2 was on Y=150 and SpacePort 3 on common Y=70) So I built SpacePort4 on Y=170... but this one also worked.
So I have no clue and I did not figured out how to make that SpacePort2 to work. But now I know that moving it can help, which is good enough for me now.
A pro po, when I link with linker 2 SpacePorts, each in a different Dimension, can I force a rocket if i flies from the first to the other dimension use exactly those spaceports? Which block do I Link with the Linker in such a case?

I did have this issue on 1.7.10 server (about the seat).
Usually, just disassembling the rocket and putting the seat to some other place on the rocket helps to fix it.

I'm almost wondering if there's invisible blocks or something.  Try opening it in MCedit or something maybe?
@EasterncheesE are there any patterns?  Does it only happen if the seat is the topmost block for instance?

Hello. Not, actually, i cannot find any system in this bug. Sometimes it's the topmost block, sometimes it's not.
Also, there are no invisible blocks in the rocket.
As for my server, the issue happens pretty rarely and is always fixed by moving the seat to other place.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Glitch when exiting ranger shell

Problem Summary
When using ranger file manager, exiting a shell created in ranger causes ranger to become unresponsive. It works fine in for me with zplug 2.3.3.
System Information

uname -a
Linux vm.local 4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 07:24:34 CET 2016 x86_64 GNU/Linux

zsh version
zsh 5.3 (x86_64-unknown-linux-gnu)

zplug version/commit
2.4.0

Minimal zshrc
   source ~/.zplug/init.zsh

   zplug load --verbose

Steps to Reproduce

Start ranger
Press Shift+S to open a shell
type exit

Let me know if you need more info, thanks.

It can not be reproduced with that zshrc

Hmm, not sure what's causing it then, I've tried it with a bare zshrc and have tried python 2 and 3 ranger, tried though Putty and TTY console via Hyper-V. I've also noticed it causes ranger to use 100% CPU. I'll keep using 2.3.3 until a newer version works for me, thank you.

Sorry, I did not understand properly. Is ranger a CLI manager, not a shell?

Yes, ranger is a CLI file manager and one of its features is to open a shell in the current directory. When exiting that shell, ranger should reactivate but it seems to freeze. The website for ranger is http://ranger.nongnu.org/

Hmm, I want to reproduce but I cannot install ranger ... 😢

I can! but maybe I cannot reproduce your prob...

Run ./ranger.py to start ranger
Type Shift-S to open a new shell within ranger process
Run exit command

And ranger continues to work as normal? Hmm, mine stops responding...I can't do anything, e.g. press Shift-S again to open another shell.

retest please

retest please

retest please

retest please

retest please

retest please

sorry for the necrobump, but i'm on 2.4.2 and i have this issue

@Alkeryn This project looks to be inactive, I now use antibody

@brynedwards I ended up using antigen ^


Refactor nanops

[x] Closes #2230
[x] Tests added
[x] Tests passed
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

In #2230, the addition of min_count keywords for our reduction methods was discussed, but
our duck_array_ops module is becoming messy (mainly due to nan-aggregation methods for dask, bottleneck and numpy) and it looks a little hard to maintain them.
I tried to refactor them by moving nan-aggregation methods to nanops module.
I think I still need to take care of more edge cases, but I appreciate any comment for the current implementation.
Note:
In my implementation, bottleneck is not used when skipna=False.
bottleneck would be advantageous when skipna=True as numpy needs to copy the entire array once, but I think numpy's method is still OK if skipna=False.

Very nice!

In my implementation, bottleneck is not used when skipna=False.
bottleneck would be advantageous when skipna=True as numpy needs to copy the entire array once, but I think numpy's method is still OK if skipna=False.

I think this is correct -- bottleneck does not speed up non-NaN skipping functions.

I think it would make sense to restructure this a little bit to have two well defined layers:

A module of bottleneck/numpy functions that act on numpy arrays only.
A module of functions that act on numpy or dask arrays (or these could be moved into duck_array_ops).

Could you explain more detail about this idea?

A module of bottleneck/numpy functions that act on numpy arrays only.
A module of functions that act on numpy or dask arrays (or these could be moved into duck_array_ops).

Could you explain more detail about this idea?

OK, let me try:

On numpy arrays, we use bottleneck eqiuvalents of numpy functions when possible because bottleneck is faster than numpy
On dask arrays, we use dask equivalents of numpy functions.
We also want to add some extra features on top of what numpy/dask/bottleneck provide, e.g., handling of min_count

We could implement this with:

nputils.nansum() is equivalent to numpy.nansum() but uses bottleneck.nansum() internally instead when possible.
duck_array_ops.nansum() uses numpy_nansum() or dask.array.nansum(), based upon the type of the inputs.
duck_array_ops.sum() uses numpy.sum() or dask.array.sum(), based upon the type of the inputs.
duck_array_ops.sum_with_mincount() adds mincount and skipna support and is used in the Dataset.sum() implementation. Its is written using duck_array_ops.nansum(), duck_array_ops.sum(), duck_array_ops.where() and duck_array_ops.isnull().

Hello from me hopefully contributing some needfull things.
At first, I would like to comment that I checked out your code.
I ran the following code example:
``

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!IT SEEMS TO BE A BUG!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
If I do the resample process using the old nomenclature:
data_aggreg = data["TOT_PREC"].resample(dim="time",how="sum",freq="M")
it works.
DO we have a bug in xarray?

Okay. Using the resample-nomenclature I tried to compare the results with your modified code and with the tagged version 0.10.7. I did not saw any nan's in the resampled fields although I expect to have over water only nan's.

@shoyer , thanks for the details. I think I understood your idea.
This sounds a cleaner solution.
I will update the code again, but it will take some more days (or a week).

Thanks, @rpnaut .
Actually, I'm changing the code also around sum. So it looks my change caused the bug you reported.
I think we do not have a good test coverage around the dataset.reduction.
I will add the test also. Thanks again for the testing :)

I think this is ready for another review.

Thanks, @fujiisoup .
I have good news and i have bad news. Your min_count argument still seems to work only if using the new syntax for resample, i.e. data.resample($dim=$freq).sum()

To wrap it up. Your implementation works for timeseries - data. There is something strange with time-space data, which should be fixed. If this is fixed, it is worth to test in my evaluation environment.
Do you have a feeling, why the new syntax is giving such strange behaviour? Shall we put the bug onto the issue list?
And maybe, it would be interesting to have in the future the min_count argument also available for datasets and not only dataarrays.

I noticed min_count is working also on resampled object.
Your issue might be for the API of resample.

Can anyone give further review?

Thanks, @shoyer.
All done.

Thanks for the review. Merging.

Hi,
just to let you know that .std() does not accept the ddof keyword anymore (it worked in 0.10.8)
Should I open a new bugreport?

Thanks, @st-bender, for the bug report.
I copied your comment to #2440.


3-Methyl-3-ethyldecane (CHEBI:165738)

Please annotate 3-Methyl-3-ethyldecane (CHEBI:165738)
CAS 17312-66-2
Literature references:
PMID: 32988551
https://doi.org/10.1016/j.indcrop.2012.04.056
https://doi.org/10.1016/j.foodcont.2020.107473
Link:
https://spectrabase.com/spectrum/6avCF8CI7v

Now checked.


[DOCUMENT-1004] Improve docstring for the fail() function.

#fixes: https://tickets.puppetlabs.com/browse/DOCUMENT-1004
The documentation  for the fail() function should mention what it does with its parameters.

Can one of the admins verify this patch?

Hi @pillarsdotnet, thanks for helping out with the docs! In order for this to pass our tests on Travis, could you please update the commit message to begin with (docs)? Thanks!

@jtappa Done.

@jtappa Looks like it passed tests.


Data.Some.Church does not export withSome

newtype Some tag = S
    { -- | Eliminator.
      withSome :: forall r. (forall a. tag a -> r) -> r
    }

Oops my bad. Thanks.


reconciliation loop poc

reconciliation loop poc
few things not working still
I will add my testing manifests next

I will work on tests because they will help be certain some stuff actually works


Add typst-http-api

An simple docker containing an API to compile typst markup.
It allow developers to self-host this docker container and consume the api to compile typst documents As A Service. Since the python code use the rust bindings under the hood the compilation is very fast and does not consume a lot of resources. It can even be hosted on PAAS such as render.com for free.
Repo URL: https://github.com/slashformotion/typst-http-api

Thanks for the awesome contribution @slashformotion !