portfolio: 0.69.1 -> 0.70.1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why did you close?

Portfolio seems to crash with the same reason as in https://github.com/NixOS/nixpkgs/issues/330889 . I initially thought it's related to updating. After reading further comments I saw that also older versions are already affected.
So I started to try to bisect what is causing the crash.
But haven't yet found time to fully went through.
Die to that I kept the PR closed as maybe someone else has time to take a look.
As the other issue was closed today, it might also be already solved (idk).
I can check later and reopen with 0.7.3 if it's working again.

I attempted to update portfolio to version 0.70.3 on top of the current master branch, but the issue still persists.


BuildStream fails to cache a file w/ mode 0000

Basically, whenever a file exists w/ a mode of 0000 in a directory that BuildStream will try to cache, the job BuildStream is executing will fail.
I can reproduce this with the following versions. It didn't used to happen with older versions of bst2 (or bst1 for that matter)

BuildStream 2.1.0
/usr/local/lib64/python3.11/site-packages/buildstream/subprojects/buildbox/buildbox-casd 1.0.0-0-g824ee5f

Here's a trivial reproducer element:
kind: manual

build-depends:
- buildsystems/base.bst # Basic CLI environment

config:
  install-commands:
  - touch %{install-root}/foo
  - chmod 000 %{install-root}/foo

If you try to build this element, you'll get the following failure (TL;DR: it's a permission denied error trying to access /buildsteream-install/foo in the container)
2023-12-11T18:03:34.906-0500 [1542603:140399133368256] [buildboxcommon_runner.cpp:437] [ERROR] [actionDigest=b763e5057f3167fb391ded391c34753b52287a66021277b4fe025ce3d75947f6/178] Error executing command: std::runtime_error exception thrown at [buildboxcommon_localcasstageddirectory.cpp:124], errMsg = "Error capturing "buildstream/carbonOS/test.bst/../../../buildstream-install" in "/var/home/adrian/.cache/buildstream/cas/staging/cas-tmpdirTeNNPU": System error in `make_nesteddirectory()` for path "buildstream/carbonOS/test.bst/../../../buildstream-install": std::system_error exception thrown at [buildboxcommon_merklize.cpp:69] [system:13], errMsg = "Failed to open path "foo"", errno : Permission denied"
[00:00:00] FAILURE test.bst: Running commands
[00:00:01] FAILURE [6371c55b] test.bst: buildbox-run failed with returncode 1

An alternative way to trigger it looks something like the following. The failure will happen right after all the integration commands finish running for bst build test2.bst or bst shell --build test2.bst
# test1.bst
kind: stack

depends:
- buildsystems/base.bst

public:
  bst:
    integration-commands:
    - touch /foo
    - chmod 000 /foo

# test2.bst
# <...>

build-depends:
- test1.bst
# <...>

# <...>

The way I actually triggered this in my carbonOS build is an element that runs systemd-sysusers as an integration command. This command creates the files /etc/shadow and /etc/gshadow inside of the container, which BuildStream will try to capture. However, /etc/shadow and /etc/gshadow typically have their mode set to 0000. So, when systemd-sysusers creates the file like this, we get the failure. My workaround for now is to set the integration commands like so:
# <...>
      integration-commands:
      - systemd-sysusers
      - chmod 400 %{sysconfdir}/{,g}shadow
# <...>

This is really interesting. Thanks for the report!
TLDR; AFAICT this is a bug in buildbox-fuse or buildbox-casd @juergbi do you know which needs the issue raised?
Long story:
A tiny nit is that bst does not use a container as such, its using buildbox and boublewrap, but its not far off a container lol
Another note is that buildbox records the build into the cache which uses the google REAPI formate only store the execution bit. FileNode
So just fixing the crash will not allow for your use case..
You may note that the cache can store more info in the optional NodeProperties @juergbi explained to me that this optional data will be correctly staged but that buildbox does not record this optional info.
I would like to add this extra info also, i have had a look at buildbox recently but i have not made much progress.
related issues include https://github.com/apache/buildstream/issues/1790 https://github.com/apache/buildstream/issues/1792 https://github.com/apache/buildstream/issues/1413

AFAICT this is a bug in buildbox-fuse or buildbox-casd

I agree. I suspect buildbox-fuse. However, I'm opening the issue here, in BuildStream, because I have no idea what to report to buildbox. My bug report to them would amount to "when I do this in bst I get this error from buildbox-fuse". My reproducer exists in BuildStream. Hence the bug report here.

A tiny nit is that bst does not use a container as such

Sure it's not a docker container but it's still a container. It has the behavior of a container anyway. And Bubblewrap is a container runtime (just ask Flatpak :slightly_smiling_face:)

Which only stores the execution bit by mandate

That's extremely silly

That's extremely silly

YES
Its why elements like
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/elements/vm/minimal/qemu-u-boot.bst?ref_type=heads have to have the "systemd config" in the same element as the packaging, "genimage"
It would be much more re-usable and simpler if the "systemd config"  could go in one element and then the "genimage" in another.
Now that NodeProperties  has been added to the FileNode im hoping we can get over this limitation soon

To be fair, NodeProperties sounds seriously dangerous to implement without being opt-in. BuildStream needs a place to be able to break cache keys when it's done. (so cached artifacts with different permissions are not considered equivalent)

To be fair, NodeProperties sounds seriously dangerous to implement without being opt-in.

Capture of NodeProperties is already opt-in (supported for mtime) and I definitely agree, they must remain opt-in.

To be fair, NodeProperties sounds seriously dangerous to implement without being opt-in.

It would need to be opt in for both casd and bst..
I did look into the casd part of the task but i didnt get very far.


Form Xfce maintainer team

Issue description
worldofpeace was previously maintainer of xfce und now there is no maintainer for most parts
https://github.com/NixOS/nixpkgs/pull/121780
if you care about xfce on nixos, you should form a maintainer team like i do with https://github.com/NixOS/nixpkgs/issues/121827 for pantheon
Technical details

[x] Create GitHub Team (Xfce)
[x] Create a Label for all known issues (6.topic: xfce)
[x] Create a GitHub Project (kanban board) (Xfce)
[x] Create team in maintainers/team-list.nix (https://github.com/NixOS/nixpkgs/pull/147797)
[ ]  Add more maintainers

Edited to include details

Can we go ahead and form the Xfce team?

@davidak @jtojnar
I am creating a Project for Xfce in the nixpkgs repository. Which Project Template should be used: None, Basic kanban, Automated kanban, Automated kanban with reviews, or Bug triage ?

For the main project, we use Automated kanban + extra “Ready to review” column. For versions, we use Automated kanban + extra “Nice to have” column (To-do but not a merge blocker).
What project organization you want to choose depends on your workflow.

Add more maintainers

There are 3 members now and xfce is very up to date, assuming this is done


feat(useRafLoop): rework the hook

Description

Reworked the hook so it do not causing parent component re-render.
Also closes #1090
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

@Belco90 you may notice that all stop and start methods are called without act, if these methods would cause parent re-render react-hooks-testing-library should throw an error - there is none.

:tada: This PR is included in version 14.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add 'config/offset' for Tuya Smart TRV HY369

Can not exclude unneeded commits from this. But they are do nothing, so may be it's ok


Migrate to spring-boot 2.x

Spring Boot is now at 2.0.x as of creation of this ticket, and the Spring Framework is at 5.0.x.  Is there a plan to update the solace-java-spring-boot project to be compatible with these newer frameworks?

Hi mbelling,
Yes there are plans to update the project. I will let you know once there is a date for the updates.
Regards,
Michael

The current project builds against 1.4 that is EOLed for quite some time. 2.0.x is EOLed as well so please consider building against  2.1.x or even trying the 2.2.x milestones. A good strategy for this project is that have a release lifecycle that somehow matches the Spring Boot generation. Does not have to be an exact match of course as this project can work just fine with 2.0.x, 2.1.x and 2.2x depending on the use of the API.

Sure, we'll have at least 2.1.x in the next release, will check 2.2.x


semantic release

Add semantic-release
Use node 16
Add semantic-release config
Do not lint release config
Use semantic-release in github action

This is cool


Cholesky does not throw exception with complex diagonal entries

The Cholesky decomposition is only defined for Hermitian positive-definite matrices, and in particular matrices with real diagonal entries. If a matrix with complex diagonal entries is passed, the cholesky routines silently ignore the complex parts.
Example:
>>> import numpy as np
>>> np.linalg.cholesky([[9+5j]])
array([[ 3.+0.j]])
>>> from scipy import linalg
>>> linalg.cholesky
(array([[ 3.+0.j]]), False)

In some cases (e.g. negative diagonals) an exception is thrown, and in other cases (e.g. non-symmetric matrices, see #2337) an exception is not thrown. I guess all of the exceptions emanate from LAPACK *potrf, and a complex diagonal entry doesn't trigger an exception there.
Nonetheless, MATLAB does raise an error on matrices with complex diagonals:
>>> chol(9+5j)
Error using chol
Matrix must be positive definite with real diagonal.

Regardless of whether or not this is something that needs to be fixed, I thought it worth reporting the issue.
See https://github.com/statsmodels/statsmodels/issues/2514 for some discussion about this in the context of complex-step derivatives.

In general, all routines that expect input with certain properties
(triangular, hermitian, symmetric, etc) assume them without checking
they are satisfied.

Thanks, I guess we'll just leave it at that then.


MINIFICPP-30: Add support for regex with Multiple file mode

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Submitting as a draft to allow test prior to marking it ready for review.

Just had a quick first look, I didn't spot anything suspicious, although there is one question that made me wonder when I saw this ticket first: what's gonna happen in case the user specifies a regex that includes a file and it's rollovers, too?
If we decide to let that happen as we don't aim to be bulletproof, that's fair for me, but at least state in docs to keep an eye on this.


fix: keep node name and location in sync

Fixes #3591

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-10 of 10 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 22.07%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/lib/ZwaveClient.ts
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
3763

Relevant Lines:
18129

💛  - Coveralls


Add Uniswap Interface gnosis safe app

Name/Description
Uniswap Interface
Type

New addition

Compatible Networks
- Mainnet
- Rinkeby
- Kovan
- Ropsten
- Goerli
- Optimism
- Optimistic Kovan
- Arbitrum One
- Arbitrum Rinkeby

Code for review
https://github.com/Uniswap/uniswap-interface/pull/2096
IPFS hash/App URL
https://app.uniswap.org
Desired date
Any date

Thanks for your contribution! The app has been added


How AKS handles potential conflict of IP addresses of a provate load balancer and pods?

I want to have a private load balancer with the annotation service.beta.kubernetes.io/azure-load-balancer-internal: "true" and set a specific IP address for the load balancer in the Kubernetes subnet (not specifying another subnet).
Is there a risk, that some pod will "occupy" my selected IP address and the Load Balancer will not be created?
I have some deployments and services released, I want to add more.
I am using Azure CNI plugin.
Should I use kubenet plugin or have a separate subnet when using Azure CNI?
Please add an explicit note about how the system handles potential conflict.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25afcc19-0998-3583-f6d8-e2a619c0e071
Version Independent ID: 7629191a-6b3b-fb22-8b70-fa84fd785f38
Content: Create an internal load balancer - Azure Kubernetes Service
Content Source: articles/aks/internal-lb.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Actually I've tested that it fails with "PrivateIPAddressIsAllocated" error when trying to create the load balancer. Please update the documentation.

@piotrgwiazda Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thank you @piotrgwiazda for the feedback.
I have updated the article to address your feedback and the changes should be available soon.


Use event delegation?

I noticed the library adds a new copy of each event listener to the document element for each instance of Choices on the page.
This could be made more performant by leveraging a simple event delegation system.

O__O
Yeah, that would be nice, i did not expect this one.


Git push hangs when remote requires credentials

I'm working with an internal GitHub installation that requires me to add username & password with every push. In terminal this works fine, but in VS Code it I don't get any prompts and the operation hangs. I can continue to use VS Code, but not the Git features until I restart.
Here's a snippet of the Git output from VS Code.
git add -A -- .
git commit --quiet --allow-empty-message --file - --all
git show HEAD:gulpfile.js
git show HEAD:src/app/common/permissionSets.factory.js
git show HEAD:gulpfile.js
git show HEAD:src/app/common/permissionSets.factory.js
git push

What OS are you on? Which Code version?

D'oh. That would of course be helpful :)
OSX Yosemite 10.10.5
Code 0.10.9 (0.10.9)
Thanks!

Using a .netrc file for auth may be a workaround for this.

That, or a credential store. But Code should prompt for credentials...

Closing due to inactivity.


Character name as variable in response option results in malformed response text

Describe the bug
When using shortened version of writing a response option where you write character name followed with response text on the same line and writing the character name as a variable will result in the character name being added at the end of the text with some of the response repeated.
Example:
# in some referenced global script set the variable
name = "Character1"

{{name}}: Here is a thing you can do
- {{name}}: That's good to hear!
- {{name}}: That's definitely news

Result:
DialogueResponse.text = "That's good to hear!Character1good to hear"
However, writing the responses in "long-form" works as expected:
{{name}}: Here is a thing you can do
- That's good to hear!
   {{name}}: That's good to hear!
- That's definitely news
   {{name}}: That's definitely news

Affected version

Dialogue Manager version: 2.38.0
Godot version: 4.2.2

Expected behavior
Response prompt should not include character name from a variable in the malformed response text.

When I use your example dialogue it appears to work for me (except I renamed name to player_name because name is already a property of Node):

Can you verify your Dialogue Manager version is 2.38.0?

That's weird :) Because here I am attaching minimal reproduction project, where I isolated the issue.
dialogue_manager_issue_553.zip

Yeah you're missing the line that was added to fix this issue a little while ago: https://github.com/nathanhoad/godot_dialogue_manager/blob/main/addons/dialogue_manager/dialogue_manager.gd#L145
That does present a different problem though - somehow the swapping of files on update isn't working properly any more.

Actually, to the MRP the plugin was obtained through asset store. So there was no update path. Therefore I am guessing the fix is missing in the released version?

 Here I was about to tear the auto-update apart trying to find out why it wasn't working.
I'll do a release now. Thanks for pointing me to the actual problem 👍

I just released v2.39.0 and verified that upgrading fixes the issue in that MRP project.

Great, I am glad I could help. Thank you for the great plugin!


refactor(version): version info support update by package.json

PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Issue Number
None.
What is the new behavior?
version information updated by package.json file automatically.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information

Thanks, this is a good improvement.

Now,  we could just use npm version [patch | minor | major] to make to version tag, and it'll automatically update version infomation in MQTT X
@ysfscream


Docker build stability improvements

Hi! Sorry to bother you again.
Previously I was facing docker build issue #3226 due to upstream AdoptOpenJDK, which is rare though.
After AdoptOpenJDK has fixed the issue, the build is okay. But today I found that the build failed again - upstream issue, but with Canonical, Ubuntu has release a newer package of python-pip and in Dockerfile we're still using the old one 9.0.1-2.3~ubuntu<IP_ADDRESS> .
apt changelog python-pip
python-pip (9.0.1-2.3~ubuntu<IP_ADDRESS>) bionic-security; urgency=medium

  * SECURITY UPDATE: directory traversal on pip install
    - debian/patches/CVE-2019-20916.patch: prevent pip install <url> from
      permitting directory traversal
    - CVE-2019-20916

 -- Emilia Torino<EMAIL_ADDRESS>Thu, 22 Oct 2020 11:40:50 -0300

python-pip (9.0.1-2.3~ubuntu<IP_ADDRESS>) bionic-security; urgency=medium

  * No change rebuild to pull in security fixes for urllib3

 -- Marc Deslauriers<EMAIL_ADDRESS>Fri, 02 Oct 2020 06:59:10 -0400

root@d0fcd479391b:/# apt install python-pip=9.0.1-2.3~ubuntu<IP_ADDRESS>
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Version '9.0.1-2.3~ubuntu<IP_ADDRESS>' for 'python-pip' was not found

root@d0fcd479391b:/# apt install python-pip=9.0.1-2.3~ubuntu<IP_ADDRESS>
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:

My concern is, do we still need to lock the version? Since Canonical may release another newer version package with newer Ubuntu patches, our attempt to  lock the version is fatigue and unstable sometime, the docker build may fail at any time.
Apart from python-pip, I can see there are some other Ubuntu packages - and what about them?
Approach to solve this problem
And the approach to solve this problem, remove version lock for python-pip python3-pip or just update version to 9.0.1-2.3~ubuntu<IP_ADDRESS> as a temp fix? I can submit a PR if necessary.

But today I found that the build failed again - upstream issue, but with Canonical, Ubuntu has release a newer package of python-pip and in Dockerfile we're still using the old one 9.0.1-2.3~ubuntu<IP_ADDRESS> .

Actually, we had switched away from Debian Sid as a base image towards Ubuntu exactly because of that problem: Debian Sid was removing packages way too frequently. For Sid that was understandable, but actually I was assuming that Ubuntu would not remove any old packages at all, but only additionally publish newer versions. I'm surprised that this is obviously not the case.

My concern is, do we still need to lock the version?

Probably not, at least not for everything that we're locking right now.
But I was just looking into the Docker build, and for me it still builds fine...

Thank you @sschuberth for such good explanations!
Seems like Ubuntu or its upstream Debian will remove older versions for their own reason.

But I was just looking into the Docker build, and for me it still builds fine...

Maybe this is cause by mirror you used? I'm using official mirror.
root@9dc8cbd54fdd:/# cat /etc/issue
Ubuntu 18.04.5 LTS \n \l

root@9dc8cbd54fdd:/#
root@9dc8cbd54fdd:/# apt install python3-pip=9.0.1-2.3~ubuntu<IP_ADDRESS>
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Version '9.0.1-2.3~ubuntu<IP_ADDRESS>' for 'python3-pip' was not found
root@9dc8cbd54fdd:/# apt install python3-pip=9.0.1-2.3~ubuntu<IP_ADDRESS>
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  binutils binutils-common binutils-x86-64-linux-gnu build-essential

``


Create a list of high prio bugs (Customer video)

Log issues

Clone link needs to clone the project

List has been created, not flagged.
Should be flagged and on Jacob's desk this week. Monday 9/12

@cullophid still needs to edit a video and will share it Friday 20th


docs/api

Showcase page instructions added for:

cURL
data-cli

New API instructions added in docs/features/api

remove npm start dev from package.json and  fix instructions for developers.

P.S.
The code in the views/_instructions.html looks weird becouse of nunjucks template render, which adds redundant paddings, when there is line-breaks in the template :(
https://github.com/datahq/datahub-qa/issues/157
https://github.com/datahq/frontend/issues/224

Re instructions:

I think data-cli should be the first one in the list and cURL is the second (and then comes R etc.)

If you take a look at the screenshot below, you can see that:

there is missing full stop after the first sentence
link to the installation instructions doesn't look good, e.g., let's have some message before the link: "You can find information about how to install data-cli here".

Re cURL instructions, can we use /r/ links instead of full pkgstore URLs?

@AcckiyGerman we've just moved /docs section to https://github.com/datahq/content so can you please move docs/features/api.md into there

@anuveyatsu

can we use /r/ links instead of full pkgstore URLs?

Something like this might work
{% for resource in dataset.resources %}
curl https://datahub.io/.../r/{{   resource.path.split('/').slice(-1)[0]   }}
{% endfor %}

But it returns https://datahub.io/core/finance-vix/r/vix-daily_csv.csv
While it should be https://datahub.io/core/finance-vix/r/vix-daily.csv
So I see two solutions:

add the /r/ link into the descriptor
remove this _csv, _json suffixes from
forget about that, as user will just copy/paste the curl <path> so it is not a big deal, if the path looks a bit ugly.


[ci skip] Fix name of ForeignKeyChecks

Description
Docs have the wrong names for foreign key methods.
I think I was supposed to use [ci skip] on the commit but trying it here anyways...
Checklist:

[ ] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[X] User guide updated
[ ] Conforms to style guide

i see that travis-ci is hard at work, so am guessing that [ci skip] in the PR title doesn't help :(
Live & learn (me too)

Whoops, yeah I remembered too late. Dance for me Travis!

[ci skip] used to work well. Had kind of forgotten about it until recently. However - as of January 6th there was a very strange bug. Not sure if it ever got resolved or if that's what is happening here...

That thread references [ci skip], [ci-skip], and [skip ci] 😮


logic around ImageId and version

I think there is a misconception around ImageId and version in manifests. I understand why there is both but the fact that sometimes it's version and sometimes it's is imageId that is required cause problems.
Especially around dependencies, today I don't know how to create a build workflow.
example:
I have my.com/aci-es:0.1 and my.com/pod-es-log:0.1 that have the first one as a dependency.
The dependency is set with imageName and ImageId. Maybe I can get around this by calculating the hash of aci-es and set it dynamically into the manifest of pod-el-log, which is already a problem, but not the biggest.
But when I will go to prod and try to run pod-es-log I don't see how RKT will discover the right version of aci-es since discovery is done by Version.

Found that I can set the version in labels instead of image name.

It seems the imageId is mandatory, so It still apply.

@n0rad Can you provide a concrete example of how this is a problem? The imageID isn't really discoverable so it is mostly useful for content verification of dependencies.

That's exactly my point, currently ImageID is mandatory in pod manifest and shouldn't, since we cannot do discovery by ImageID.
Currently to be able to run a pod, you have to have the images already available in the local storage.
But If I download the pod manifest on an empty prod machine and try to run it, rkt have to fetch the images of the pod (and should do it using name+version), without any imageID.

@n0rad ImageID is mandatory at final pod execution time but not necessarily when using a pod manifest as a deployment template. For example, https://github.com/appc/spec/blob/master/examples/pod_template.json#L13 compared to https://github.com/appc/spec/blob/master/examples/pod_runtime.json#L37 - in this case we can imagine that the implementation which use the template manifest as an input (as rkt can) proceeded to discover the backup image basedon its labels and then reify the manifest with the image ID. Does this answer your question?

Ok, I think I got it why ImageID is mandatory in the spec.
Now It seems RKT is not processing the discovery to transform the template to runtime.

https://github.com/coreos/rkt/issues/1316


Blend modes lighter/darker color incorrectly compose

I also come across this problem, my version num is 1.8.30， and the psd file is https://drive.google.com/file/d/1SsQ-YRUytXARaTAcI1d66SZ8bBsHsSBm/view?usp=sharing and it show out like this

when i remove the group which has the mask layer, it show right, I want to know the problem.
right pic

Originally posted by @yoyoshuang in https://github.com/psd-tools/psd-tools/issues/135#issuecomment-542626964

This error happens because solid color fill layer (Color overlay) has darker color blend mode, which is not yet supported on psd-tools

Different blend mode works, such as darken.
import psd_tools
psd = psd_tools.PSDImage.open('V2.psd')
psd[3][1].blend_mode = psd_tools.constants.BlendMode.DARKEN
image = psd.compose(force=True)
image

The problem is that, there is no good documentation (and its math) on how lighter/darker color blending modes are implemented within photoshop.

All image processing operations can be performed with "Numpy" or "Opencv". I think you should give priority to layer write support.
Photoshop blending formulas;
http://www.simplefilter.de/en/basics/mixmods.html
http://www.deepskycolors.com/archive/2010/04/21/formulas-for-Photoshop-blending-modes.html
The following process is more effective than psd-tools;
Save the file as .ora with Krita > Read ora layers with python > Do something with layers > Write ora file.

Relevant #49
Blending formula
https://wwwimages2.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_1-7.pdf


Adding Typings + EPERM error on Windows

This PR adds typings, for use with typescript.
Example usage:
import DataStore = require('data-store')
const store = new DataStore({ path: 'config.json' })

After some issues on Windows, I've added a fix to this PR:
The error I've encountered is
"EPERM: operation not permitted, mkdir 'C:'", thrown from index.js:401:26.
By adding the existsSync before the mkdirSync, we avoid trying to create folders that already exist.

thanks for the PR @nytamin! If you have a moment, could you do me a favor and check to see if the following works instead?
Update handleError to the following (and remove fs.existsSync()):
function handleError(dir, opts = {}) {
  return (err) => {
    if (['EEXIST', 'EISDIR', 'EPERM'].includes(err.code)) return;
    if (path.dirname(dir) === dir || !opts.fs.statSync(dir).isDirectory()) {
      throw err;
    }
  };
}

The reason I want to avoid using fs.existsSync is that it creates an extra stat call, which means we'd hit the fs twice for every directly segment. If this was async, it would feel more natural, since we'd just check to see if an error came back or a stat object, but we don't have the luxury with sync.
Anyway, the double-fs-hit probably isn't a big deal, especially since the it's only done when the store is created. If you don't have time to check I'll just publish as-is.
Thanks for the PR!

I can confirm that your snippet works on my setup (Windows 10, v17134), although I'm wondering whether silencing EPERM might cause other issues in the long run?
Say if for some reason the application doesn't have write access to the directory, then that would be a EPERM error we do want to throw.
Anyway, thanks for this library! It's a must-have in the toolbox :)

Thanks, and sorry for the late reply. I'm in the process of moving to a new house, I'll be glad when it's over lol.

I'm wondering whether silencing EPERM might cause other issues in the long run?

If we were doing this async, we would ignore the EPERM error anyway, since it indicates that the directory already exists. Or, we could do fs.statSync() but IMHO it's not necessary for the following reason(s).

Say if for some reason the application doesn't have write access to the directory, then that would be a EPERM error we do want to throw.

The handleError logic will still throw the error if the problem file path is not a directory. IMHO this is sufficient, because if the EPERM error isn't directly related to the directory already existing, then the store will attempt to write the data to a file, in which case any other problems would be exposed by fs.writeFileSync() when trying to write to the store data path.

@nytamin I just pushed up a patch with improvements from our discussion. My concern about adding fs.existsSync() is that it would be try for a non-directory filepath anyway, which will only "punt" the error when fs.mkdirSync tries to create a directory over the file path.
Please let me know if you have any issue. thanks again!


⚠ Bofrost.at has degraded performance

In 1c62ffd, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1488 ms

Resolved: Bofrost.at performance has improved in ccab480.


Can you support the BatchCount parameter?

and Image2Video method

What is your use-case for an batch-count parameter? I don't see any advantage over just a loop and multiple generations. But the parameter would add extra clutter to the interface and introduce some challenges freeing the native memory.
Image2Video is not supported in stable-diffusion.cpp so far. It was worked on in https://github.com/leejet/stable-diffusion.cpp/pull/236 but never got merged.

Does BatchSize support it?

No

Why is there no judgment on null for _parameter in the Initialize method

What do you mean? The _parameter-Field is not nullable, that's also runtime checked when passing it in the constructor.

I see that you don't need to _parameter parameters only when using Upscale


Allow duplicate id's in OSMData class as long as data identical

Allows creating OSMData classes from composite datasets with overlapping but identical data

Thank you for the request! I think I faced this problem before. The fix is really nice!


Remove asset commitment from note input

This PR removes the ASSETS_HASH from advice stack in the prologue. In order to get the nullifier the computed assets hash was used instead.
Related issue: #704

Thank you! All looks good! But looking through the code, it seems to me that the previous implementation was a bit more clear (mostly because we could just say adv_pipe hperm adv_pipe hperm to save note details to memory and compute the note nullifier. So, I'm inclined to keep things as they were and will close this PR and related issue.


chore(CI): build a portable binary in CI for different CPU architectures

What this PR does / why we need it?
This PR tries to:

fix https://github.com/axonweb3/axon/issues/1387
fix Illegal instruction issues recorded in https://github.com/axonweb3/axon/issues/1374

PORTABLE=1: This flag is used to build a portable binary that can run on different machines with different CPU architectures. It disables the use of CPU-specific optimizations and generates code that is compatible with a wide range of CPUs

USE_SSE=1: This flag enables the use of SSE instructions, which are a set of CPU instructions that can perform multiple operations on multiple data elements in parallel. SSE instructions can significantly improve performance for certain types of computations, such as multimedia processing

What is the impact of this PR?
No Breaking Change
CI Settings

CI Usage
Tip: Check the CI you want to run below, and then comment /run-ci.
CI Switch

[x] Web3 Compatible Tests
[x] OCT 1-5 And 12-15
[x] OCT 6-10
[x] OCT 11
[x] OCT 16-19
[x] v3 Core Tests

CI Description

CI Name
Description

Web3 Compatible Test
Test the Web3 compatibility of Axon

v3 Core Test
Run the compatibility tests provided by Uniswap V3

OCT 1-5 | 6-10 | 11 | 12-15 | 16-19
Run the compatibility tests provided by OpenZeppelin

/run-ci

Why should we use -march=native? I thought the change would be to make ckb-rocksdb use a more portable CPU feature set.

rustc -C target-cpu=help
Available CPUs for this target:
    native         - Select the CPU of the current host

Using -march=native may cause the same issue that cached objects may use instructions that the current host doesn't support. We should change rocksdb to not use -march=native, not change rust to use -march=native.

Ckb-rocksdb uses PORTABLE=1, USE_SSE=1 by default so this change isn't necessary. If there are runners that  don't support avx2, we should use the portable feature of ckb-rocksdb to disable avx2.


LeetHub is not working on new Leetcode website But able to create new repos

Describe the bug
LeetCode website is updated and now when we submit the questions the extension is not working.
To Reproduce
Steps to reproduce the behavior:
1.Go to leetcode.com
2.submit a question
3.check if it updates in github
4.but leethub is able to manipulate our repos
Expected behavior
My github repo should have been updated but it is not.
Additional context
The extension works perfectly when i manually switch to old version from settings on leetcode website.

yes this issue is really critical


[qt5] Explicitly avoid compiling qt dependencies that could be available in vcpkg

…
To avoid problems such as the one described in https://github.com/Microsoft/vcpkg/issues/412 .
If a particular dependency is actually needed, it can be added -qt-<dep> or `-system- to use the vcpkg version, see https://github.com/Microsoft/vcpkg/issues/455 .

Hi @traversaro, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks for the PR!
(I bumped the qt5 version)


Create CODEOWNERS

#145 @Zjjc123 do you want to also be CC'd on PR's?

Closes #145 forgot

#145 @Zjjc123 do you want to also be CC'd on PR's?

Yeah that would be great

@Zjjc123 g2g?


fix: removed extra region from stack defintion file

Description
Addresses Issue-10400
Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

golangci-lint is failing in pipeline but passed in local -

/run pipeline

Getting error in pipeline

/run pipeline

@imprateeksh There are no code changes in this PR. It seems the change your trying to make was already done in https://github.com/terraform-ibm-modules/dev-rag/pull/26


Looking up sensor ID when adding

Is your feature request related to a problem? Please describe.
Thanks for your great work! I have a minor suggestion:
When adding a sensor to the integration I need to know or lookup the needed level ID.
Describe the solution you'd like
It would be great amd very helpful to have a search box, where I could type the name or location of the level and it would fill the level ID automatically from the list in Github.
Describe alternatives you've considered
No response
Additional context
No response

Hello @nraeth i thought of something similar my self, but i don't have any clou if and how it would be possible to implement this feature.

Hi @nraeth, i lately stumbled over an easy to solution for this enhancement. From v1.0.2 on the user can search/select the pegel via a combobox.
For more details:
https://github.com/stephan192/hochwasserportal/pull/58
https://github.com/stephan192/lhpapi/pull/30


Support for shorthand module/module resolution?

As my applications grow in size I start placing components in sub folders. Simplified:
app
  |_ components
    |_  app
      |_ header
        |_ header.ts
        |_ header.html
      |_ sidebar
        |_ sidebar.ts
        |_ sidebar.html
      |_ app.ts
      |_ app.html

If I want to import the sidebar or header components from the app component, I currently have to do:
import { HeaderComponent } from './header/header';
import { SidebarComponent } from './sidebar/sidebar';

As you can see this gets a bit repetitive, and I'd prefer to simply use:
import { HeaderComponent } from './header';
import { SidebarComponent } from './sidebar';

If the typescript module resolver is smart enough to look for an index.ts file in the header subfolder in these cases, could we add a rule to also have it look for a file which is the same name as the folder, or would that conflict with other resolve rules?
The reason I don't want to rename my files to index.ts within the subfolders is because it makes jumping to those files and keeping track of which one is which when you have several index.ts files open a hassle.
Alternatively, would it possible to accomplish this by using the new paths and baseDir resolution scheme?

If you're using Node-style resolution (e.g. CommonJS), then you should be able to rename each of those index.ts at the top level and import them the way you'd like. Does that solve your problem?

Hi @DanielRosenwasser , thanks for the quick reply.
I am using "moduleResolution": "node",, but it doesn't seem to be working as I get errors Cannot find module app/header

@adambuczynski I usually use the re-export pattern to solve this particular problem. So my components folder would contain a file with the contents
export * from './app';
export * from 'app/header';
export * from 'app/sidebar';

@aluanhaddad thanks for the suggestion. That would work well for nested shared components, I'll give that approach a try.
However, for my particular usecase where I only need the header and sidebar components from within the app component it seems like overkill.

Consider using path mapping for module resolution added in TS 2.0, see https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#path-mapping for more details.


Module Alpha Version

Includes a basic module implementation, offering the infrastructure to make individual features far easier to implement while offering a way to deploy the code as a module via the PSGallery.
This changes in a major way:

Where data is stored
How the user interacts with rules and policies
How the entire AppLocker policy build process is executed

It also offers the basic code infrastructure for automated tests and publishing via the PSGallery.

@FriedrichWeinmann can you fix the merge conflict.

Heya Shivay,
I can resolve them, but it needs a lot more work before it is ready to merge!
You'll have noticed that this PR wasn't exactly created yesterday and it was originally intended as a POC to get approval for the layout before fully migrating over existing code.
So merging the current state doesn't cut it, as it requires a full conversion first (and catching up to the last 1.5 years of changes)
Happy to do all that, so long as it actually is desired. Will be a breaking change and fundamentally change (in my opinion: improve) the user experience.


Observation form map js - refactor no jQuery, add system test

Prep for Rails 7

coverage: 94.435%. remained the same when pulling 9085fe6071d882687947a317a4961e1e19491fb8 on nimmo-obs-form-map-js into 7e7d7839ad48109c538092164fa63325af1f3f88 on main.


Fix TextEdit Select crash

Fix #29538

p_from_line also causes crash when negative. You should add it to the condition too.

Thanks!


Parser: Introduce T! macro

Closes #81.

Interesting to learn that the code is (re-)generated when running tests.


Terminal & SSH add-on doc issues - network access via ssh.

I noticed some where around version 8.4 of the newly renamed "Terminal & SSH" add-on, I lost network ssh access. I now get "connection refused".
It looks like there is a new “Network” dialog box that needs to be updated and is not mentioned in the docs. By default it says 22/tcp, with “disabled” in the input field (greyed out). The Column header is “Host”. This is a bit ambiguous, since I thought it wanted to know what host interface to listen on (<IP_ADDRESS> vs <IP_ADDRESS>).
To (re)enable ssh access via the network, you need to enter the port number ‘22’ or what ever port you want to use. This will map that port from the hassio host into the running “Terminal & SSH” container. I believe a restart of the add-on is then needed so the container can get restarted with the docker -p equivalent.
Suggestions:

If the intended default config is that out of the box there is only terminal access from within the web browser than than should be very explicitly documented.   (It seems to me I installed an ssh add-on, not a web terminal add-on, so no longer having ssh access from the network was surprising.)
The doc/readme for the add-on should have an easy to find section on "Enabling SSH access from the network".
The "Network" dialog box, should have more information about what its purpose is:

Title could be something less ambiguous than "Network",  like "SSH Network Access"
The column heading Host should be changed to Host Port in my opinion to be clearer about what's needed.
Ideally it should indicate that a restart of the add-on is required after changing the Host Port.

The updated official "Terminal & SSH" add-on looks like a nice enhancement.  Thank you for all your work on this.     (It was disconcerting to no longer have any ssh access and not have any clues in the docs.)

If the intended default config is that out of the box there is only terminal access from within the web browser than than should be very explicitly documented.

Feel free to improve the documentation by opening up a PR.

It seems to me I installed an ssh add-on, not a web terminal add-on, so no longer having ssh access from the network was surprising.

Things change from time to time, sorry to hear you don't agree, nevertheless, in general, this is received as an improvement by the community.

The doc/readme for the add-on should have an easy to find section on "Enabling SSH access from the network".

That is kinda the same thing as you pointed out in your first suggestion. Feel free to open up a PR to help us to improve it.

The "Network" dialog box, should have more information about what its purpose is

That I agree on, we should add the ports_description configuration parameter to the add-on configuration.

The column heading Host should be changed to Host Port in my opinion to be clearer about what's needed.

That is not a suggestion for this repository. Feel free to open up a suggestion on our frontend repository: https://github.com/home-assistant/home-assistant-polymer.

Ideally it should indicate that a restart of the add-on is required after changing the Host Port.

Every change in the add-on frontend requires a restart...

If the intended default config is that out of the box there is only terminal access from within the web browser than than should be very explicitly documented.

Feel free to improve the documentation by opening up a PR.

He really shouldn't have to. Whoever had the idea to make such a big change to the default behavior to the addon really should take a few minutes to update the documentation, as well. I agree with rct, this really is a breaking change.

It seems to me I installed an ssh add-on, not a web terminal add-on, so no longer having ssh access from the network was surprising.

Things change from time to time, sorry to hear you don't agree, nevertheless, in general, this is received as an improvement by the community.

He's not saying that he necessarily disagrees with the change, just that it came as a surprise when he went to use his normal setup and SSH all-of-a-sudden stopped working for him. Changing the default access to a web terminal-only interface likely is inherently safer for users, and may be a good direction to go. However, it should be listed described in the changelog, as well as documentation. The current latest entry in the changelog (which is not currently under a version number) states only "Support to use only web terminal without SSH server", but nothing that states that this is going to be the default setup and that your existing configuration will be broken by updating to 8.4.

OMG. I lose one hour to figure it out that is the port number :(
Change the desc.
Thank you rct for help

I just submitted #1126 that simply re-enables network ssh access until this change can be better considered.
Please consider merging this soon so that more people don't lose time on this.
@frenck - This wasn't a small change.  If you consider the case that someone who installed the 'SSH server' add-on, updates it and then find without any warning they've lost ssh access then that's a big breaking change.  This change disabled the functionality that this add-on was advertised to provide,

@rct Thanks for the PR, it was considered and discussed carefully, so that statement is a bit condescending.
Hence, your PR should not be merged IMHO.
I agree the documentation could be better, which I encouraged.

Finally understood why this was not working anymore, should have been documented without any doubt. Thank you @rct for raising this issue, without it I was probably still searching.

thank you! I spent half an hour scratching my head of why this had stopped working

thanks, at least I'm not the only one who spent an hour to understand why I can't connect :)

I had the same problem but managed to get it working

I had no idea why my ssh attemps were refused after updating and the meaning of that 22/tcp field wasn't clear (at least it did not explain the issue).
Headed here and found the solution so no extra hair loss.. ;)
The idea of transferring old users settings is great, hope a fixed version will come out soon so people won't be hit with that.

@rct many thanks for taking the time to respond to the SSH issue (including on the other place).
I've just caught up on the comments having been away for a few days, but I can see you've helped me and several others by taking the time to post.  Thank you for your time and support.

A BIG thank you also from me, nowhere it was explain this breaking change.
Thank you @rct !

@rct Thank you so much to arise and solve the problem.
I was going crazy with nmap scans, changing keys... I have been spending hours just trying to solve this.

If the intended default config is that out of the box there is only terminal access from within the web browser than than should be very explicitly documented. (It seems to me I installed an ssh add-on, not a web terminal add-on, so no longer having ssh access from the network was surprising.)

I completely agree with this, changes like this one must be explicit to the user base.

The column heading Host should be changed to Host Port in my opinion to be clearer about what's needed.
Again I agree.

@pvizeli - I'm sorry but this issue should not have gotten closed. This issue is able the doc for the add-on. As far as I can tell the docs have not been fixed.
I see you are logging a message now which gives a clue.  Though the message isn't very clear.  The tense is wrong.
I think the log message might be clearer if instead of
SSH port is disabled. Prevent start of SSH server.
It reads:
SSH host network port not set.  SSH network access is disabled.
As far as the docs for this add-on they no longer match the functionality of the add-on

Home Assistant Add-on: SSH server
Allow logging in remotely to Home Assistant using SSH or just the web terminal with Ingress.

I think it should be something like:

Home Assistant Add-on: SSH server
Allow logging in to Home Assistant via a web terminal built in to the UI.  Optionally, an SSH server can be enabled which allows logging in over the network via SSH.

SSH port is disabled. Prevent start of SSH server.

is must give users a clue how to enable it.

Yes! I have no clue how to enable it. The UI only allows me to change the value of the field, currently set to 'disabled', but if I set it to 'enabled', and hit save, the UI changes the field back to 'disabled'.

How am I meant to enable the port?

Yes! I have no clue how to enable it. The UI only allows me to change the value of the field, currently set to 'disabled', but if I set it to 'enabled', and hit save, the UI changes the field back to 'disabled'.

How am I meant to enable the port?

@anachronox99 Enter the port number that you'd like to have the SSH server listen on in that line, then click Save, and finally restart the addon.

Yes! I have no clue how to enable it. The UI only allows me to change the value of the field, currently set to 'disabled', but if I set it to 'enabled', and hit save, the UI changes the field back to 'disabled'.

How am I meant to enable the port?

@anachronox99 Enter the port number that you'd like to have the SSH server listen on in that line, then click Save, and finally restart the addon.

Thanks! I now understand that the field is meant for entering the port number to be enabled. This is not obvious. I notice the original ticket has been closed by #1156 , which simply logs a warning message to the console. IMHO that's not a sufficient fix for this issue, a breaking change like this also requires an update to the installation documentation, and preferably an improvement to this UI

@anachronox99 I totally agree.

Just spent 30 minutes getting this SSH thing to work. Google brought me here and then it got clear i need to enter a port number. Makes sense now i think about it, but should be clearly stated in the docs or just default to 22 and leave it configurable for those who need it.

I've upgraded the SSH add-on and had no clue how to make it work again. I'd never ever think I was supposed to set "host" field to 22. Terrible UX.

I too was very confused by this. Thanks @rct for clearing it up.

#&?*! Just got a corrupted SD card on my RPi3 because I had to pull the plug to reboot it (frontend was not accessible and SSH too)... I always check the changelog before updating addons, but I clearly missed this one.

thank you VERY much @rct


GridContainer does not position and resize its children in a grid

Godot version
v4.1.stable.official.970459615
System information
MacBook Pro - macOS 13.3.1
Issue description
I am having an hard time with layouts in general, and in this case specifically with GridContainer.
I tried to recreate the same example shown in the docs:

I create the same node tree, but the result looks different:

I expect that the GridContainer would size its child nodes to fit the available space in 2 equally sized columns. As you can see, the buttons are not resized at all.
This is even worst when the child node is a custom layout. The GridContainer does not reside its children and they all have a 0px width, making the scene look empty.
Steps to reproduce
Try to recreate the example in the docs in a new Godot project should be enough to test the issue.
Minimal reproduction project
N/A

You need to enable set alignment with Expand flag (in the menu at the top toolbar).

After some attempts at changing the expand values of both container and child nodes I was able to achieve horizontal stretching:

The idea is to have Horizontal alignment set to fill and expand for child nodes (no need on the container):

@KoBeWi Is this correct?

Yes.

Great! Thanks @KoBeWi
Extra note: In my case I wanted the horizontal layout to stretch (expand), while keeping the same height vertically. This can be achieved by setting a Custom Minimum Size in Layout for child nodes:


Port scenario_sequence to ROS2

There was no rclcpp code, so this amounted to porting the build file and cleaning up the dependencies and headers.

good job. Did you have the change to use thie pkg yet from another one to see if everything links correctly?

Not yet

@esteve We're good to merge here


Activity chart loading indefinitely

The activity chart is not displayed. Instead, only the text "Loading activity chart ..." appears.
System information

Wakapi version 2.10.4
Operating system

If Linux: which distro? Ubuntu 22.04.3 LTS
If Docker: which image and tag? ghcr.io/muety/wakapi:2.10.4

Database Postgres

Console Log:
[wakapi]   | 2024-01-30T05:20:17.720464191Z [INFO ] [request] status=404, method=GET, uri=/api/activity/chart/name.svg?dark&noattr, duration=480.402µs, bytes=0, addr=<IP_ADDRESS>:56658, user=name

Could you provide the full URL of the activity chart as well your username, please? That would help me debug this.

My username is bestlinuxgamers and the full non-generic error is:
[INFO ] [request] status=404, method=GET, uri=/api/activity/chart/bestlinuxgamers.svg?dark&noattr, duration=458.502µs, bytes=0, addr=<IP_ADDRESS>:59678, user=bestlinuxgamers

Very strange, honestly I have no idea how this comes about. Can you please check if there are any errors in the browser console? Also, can you check if restarting the server or using a different browser helps? Are the summary charts displayed properly?

There is only the 404 error from trying to load the chart in the browser console. On Google Chrome (instead of Firefox) there is the same issue and the error in the browser console. I've restarted the docker container multiple times and my whole host server too. It didn't make a difference. The charts are not displayed properly (see #600).

Found and fixed the issue. Was my bad, sorry :man_facepalming:. Fix will be available with next release.


cmd/objdump:  unsupported architecture for ppc64/ppc64le

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
go version devel +c63dbd8 Thu Mar 10 18:35:10 2016 +0000 linux/ppc64le
Doesn't work on any earlier versions either.

What operating system and processor architecture are you using (go env)?
ppc64le

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
go tool objdump a.out

What did you expect to see?
A disassembly of the program.

What did you see instead?
objdump: disassemble a.out: unsupported architecture

I've seen a CL for this from Minux a while ago but haven't seen any recent updates.
If this was started but needs finishing I could help with that.

@minux?

Duplicate. Merged into #9039.


fix failing tests: removed some broken code

This is the cause of failing tests. Attempt to overload methods on namedtuple with that of builtin tuple with attribute __unicode__ is not needed. tuple and namedtuple do not have a __unicode__ method

Please merge stuff like this into 2.9-maintenance, and that branch into master


⚠ Secret Website 3 has degraded performance

In 0e64835, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3044 ms

Resolved: Secret Website 3 performance has improved in 05b7d9d.


feat: set tcp proxy listener buffer

Part of: #1048

Em... I just tried on v1.1.0, seems not work for me. I add a BackendTrafficPolicy but the per_connection_buffer_limit_bytes is still 32KB

Add a knob to make per_connection_buffer_limit_bytes configurable #2600

cc @yaelSchechter


Convert from PData To MySQL (#209 didn't help)

I know #209 already asked this, but I was wondering how easy it would be to do this. I already dumped the sv.db 'playerpdata' table and filtered out the Pointshop specific things, but now I'm trying to figure out what I need to change as it's in a slightly different format than what MySQL needs (for example: INSERT INTO "playerpdata" VALUES('3804972992[PS_Items]','{"skull_follower":{"Equipped":false,"Modifiers":[]},"anger":{"Equipped":true,"Modifiers":[]},"jumppackowner":{"Equipped":true,"Modifiers":[]},"greenblood":{"Equipped":true,"Modifiers":[]},"armor":{"Equipped":true,"Modifiers":[]}}'); INSERT INTO "playerpdata" VALUES('3804972992[PS_Points]','999958111');
(can you tell that's me :D)
Anyways, that's a different format than the 'VALUES( uid, points, items )' from MySQL. What specifically do I need to change?


ClassAnalysis.get_xref_to() and from() return empty dictionaries, had to call Analysis.create_xref() manually

Hello,
While trying to xref from ClassAnalysis, I was getting empty dictionaries and also the list of methods was empty.  Below is the code snippet:
apk = APK(path_to_apk)
vm = DalvikVMFormat(apk.get_dex())  #
vmx = Analysis(vm)  # Analysis object
#vmx.create_xref() #Without this cx.xref* and cx.methods are empty
classes = vm.get_classes() # ClassDefItem object

for class_ in classes[:1]:
    cx = vmx.get_class_analysis(class_.get_name()) # ClassAnalysis object

    print(class_.get_name())
    print(cx.get_xref_from().values())
    print(cx.get_xref_to().values())
    print(len(cx.get_methods()))
    print(len(class_.get_methods()))

I don't know if this is something forgotten by the developers or left due to some reason. I was expecting that all the objects of ClassAnalysis in an Analysis object would be properly populated.

You have to do vmx.create_xref().
if you want to create per class's xref, you should be customize this source.

Yeah but I don't want to customize important parts of code because I want it to be compatible with the anrdoguard version that is living here.
This post was just for information so that if someone is missing the point like me, they can see it here.


Adding Display States to Docs

Let me know if this is the correct place for this or if there is a better place for this.

Sorry, I missed this one. Thank you!


fix: make PageTable handle multiple files

Currently, PageTable assumes there are fields 0..num_columns, where num_columns is the total number of columns in the dataset. This works for new files added, because we always write 0..(max_field_id + 1) entries in the page table, but it breaks for old data files who have fewer fields. This is why after merge we can read the new columns (in the new files), but not the old columns. Also, because the PageTable is cached, we could read while using the same instance of LanceDataset, but as soon as we loaded in a new session, the PageTables would be re-read and break.
This PR modifies the PageTable format slightly so that the fields start at the minimum field id in that file's schema. This is backwards compatible for all tables that only have one data file per fragment, but breaks tables that have more than one file. However, seeing as the latter case is broken already, I think this breaking change is fine.
Closes #1331.

Is it possible to delete columns from a dataset? Will that still be handled?

I don't think we expose this yet, but we plan to allow that.
We should define the semantics better in a future PR. Basically, similar to how there is a distinction of "physical rows" and "logical rows" (that is, after deletions are applied), we should consider the schema of the dataset the logical schema, while the list of field ids in fragments should be considered physical and includes removed columns.


resolved ts stucks for 2 hours when upgrade cluster from v7.1.4 to master

What did you do?

Upgrade a TiDB cluster from v7.1.4 to v8.0, cluster with titan on. cluster size: 84TB, 27 TiKV, 3 CDC node. 2 changefeed running replicating 4000 tables, workload is around 40 - 50MB/s.

What did you expect to see?

CDC lag should be normal during rolling upgrade.

What did you see instead?
CDC resolved ts and checkpoint ts lag keeps increasing after cluster upgrade, and up to 2 hours. Resolved ts lag back to normal about 20m after cluster upgrade is finished.

The issue arises from the slow speed of the incremental scan in TiKV. We are continually working to improve the incremental scan speed.

Close since not reproducible


Widget count issues

Describe the bug
The widget (<script src="https://opencollective.com/SLUG/banner.js"></script>) seems to be incorrectly counting all organizations that have donated to a collective as a sponsor, but not showing the organization under sponsors or backers.
To Reproduce
Steps to reproduce the behavior:

Use the widget code from https://opencollective.com/SLUG/edit/export (in my case I'm testing for https://opencollective.com/linuxserver at https://lsio.nemplex.com/donate )
Put the code in an HTML page (any plain old HTML works fine)
The page displays the widget as described above (incorrectly)

Expected behavior
The widget should either:

Display Organizations and Individuals separately OR
Display tiers separately (probably not just backers and sponsors)

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Google Chrome
Version 78

Smartphone (please complete the following information):

Device: Moto z3
OS: Android 9
Browser Google Chrome
Version 78

@nemchik Thank you for the report!
Seems the widget is displaying Organizations and Individuals separately, which looks like a correct behavior if I compare to the collective page.

The organizations count looks good
The individuals count doesn't seem to match. It's just because only the top 15 individuals are displayed. There is no total count given in the collective page to compare, but I'm assuming the "36" figure is correct in the end.
The terms "Become a sponsor" and "Become a backer" are confusing and needs to be updated. They could be replaced by "Contribute as an Organization" or "Contribute as an Individual" to use updated terminologies. Or just "Contribute" as a shorter version.

Re: counts
I agree the numbers look correct. The count isn't really the issue (sorry for the misleading title, feel free to edit).
Re: terminology
I would agree "contribute as ..." Or just "contribute" makes sense.
The issue I was trying to point out can be seen in the screenshot and demo link above; organizations are counted correctly but not shown, and are listed next to the become a sponsor section.

This does not seem to be resolved. The widget is currently displaying an organization that seemed to make an ad-hoc contribution as a sponsor here:

The amount contributed is not the amount designated for the sponsor tier.
I'm pointing this out to reference https://opencollective.com/linuxserver
My organization on OpenCollective https://opencollective.com/dockstarter is one of the 2 counted in the screenshot, but not displayed in the widget anywhere. DockSTARTer is a backer of LinuxServer and is setup for recurring contributions. Salesforce https://opencollective.com/salesforce is showing as a sponsor but has not donated in the sponsor tier OR the backer tier (from what I can tell - it looks to have been a one time contribution). We both show up in the SVG for organizations https://opencollective.com/linuxserver/organizations.svg?width=600 which is good.
So as I understand the first screenshot:

A count of all organizations regardless of tier is shown (2)
Large cards for organizations that have contributed without using a predefined tier are then shown as if they were sponsors (and for LSIO only one is shown at the moment, Salesforce)
A count of all individuals regardless of tier is shown (91)
Avatars for all individuals regardless of tier are shown.

This seems very confusing. I may be incorrect about the exact way (tier) that Salesforce donated to LSIO (I don't have access to see that), but there are a few scenarios that don't really clear anything up:

Salesforce somehow donated at the sponsor tier for an amount different than the tier describes
Salesforce donated at the backer tier and is displayed as a sponsor (but DockSTARTer is not)
Something else that maybe I'm not understanding.

I don't really care about the specifics about my collective being displayed, but the inconsistencies and confusion about what is actually being displayed would apply to anyone using the widget.

Most of the confusion is about the wording which is not appropriate. This was explained in:
https://github.com/opencollective/opencollective/issues/2593#issuecomment-552865967

The terms "Become a sponsor" and "Become a backer" are confusing and needs to be updated. They could be replaced by "Contribute as an Organization" or "Contribute as an Individual" to use updated terminologies. Or just "Contribute" as a shorter version.

These are NOT "tiers" which are displayed but "types" (individual and organization). Changing the copy should fix that confusion.
Also, DockSTARTer is not an "Organization" but a "Collective", this is why it's not appearing together with Organizations in some places. It's a problem that we're surfacing "Organizations" and "Individuals" and missing "Collectives". It's why we've taken small steps to feature Collectives together with Organizations in some places (t's definitely not helping clarification but it's better than nothing). It's why you're seeing DockSTARTer featured next to Salesforce in https://opencollective.com/linuxserver and why you're seeing it in the image at https://opencollective.com/linuxserver/organizations.svg.

I will update the copy
I will add Collectives together with Organizations in the banner at https://opencollective.com//linuxserver/banner.html

PR pending: https://github.com/opencollective/opencollective-frontend/pull/3522

Thank you for all of that explanation, it clarifies A LOT!

@nemchik Changes are live! Let me know if it works for you and if we can close this issue.

Sorry I did not see your reply sooner. I can confirm that this is working as expected now! Thanks!


Type instantiation is excessively deep and possibly infinite

The error occurs in the following situations:
// Works perfectly until `{8}` part
hydrateText("{1}, {2}, {3}, {4}, {5}, {6}, {7}, {8}", {});

// Works perfectly until `9` part
hydrateText("123456789", {}, { prefix: "", suffix: "" });

Related to recursive variables retrieving.
Basic example.
TypeScript issue: microsoft/TypeScript/issues/37613

According to this comment, it is not possible to get rid of this problem completely.
Known issues section has an advice how to avoid it, so closing this issue.


feat: Added printing support for tickets

Fixes #1006
@iamareebjamal Updated screenshot.
Screenshots for the change:

Print icon is too big and not contained in a button

There is @sridharjajoo If there is png of standard material icon, there must be vector. Vice versa may not be true

@iamareebjamal Kindly review

Update screenshots

I have updated the screenshot. Kindly check

The button is still not present

Please color it material blue

Also, make the icon white

Please update screenshot
Also, can you post the print document UI from EventBrite

@iamareebjamal

Updated the screenshot above.

Following is the UI which eventbrite follows for the printing of documents. Sadly I cannot go further as I neither have a star nor a zebra printer.

This is order printer. I had doubts as to why someone would need to print a ticket because it does not have any specific information in it
Please work on showing the order details and print them instead

Ok, I'll work on that issue as well. So should I close this P.R? Or if possible can it be merged?

This can be converted into the needed PR

@iamareebjamal It seems eventbrite has it and if it is implemented already, we could support both ticket and order printing.

Ok @sridharjajoo. Please open an issue for order printing


Merging all the services repositories into one?

As the title says, should the master server and services repositories be in this repository? (cso2-master-services or cso2-master-server)
cc: @GEEKiDoS @DebugBios @organnerx

I think cso2-master-services rather than cso2-master-server would be a good way to inform the integrated problem.

Sounds like you will update cso2-master-services?
I think the master server and services repositories should be in this repository

Depending on what are you planning to do next. In many cases I prefer to have everything in one place.
But in this case, when you have different modules, you better to not merge them and leave it as it is. They all have different ideas and functionality. The current structure is optimal for a project like this.

I was thinking on creating a new chat service, and continue splitting
whatever is left on cso2-master-server (create a channel service and
move all the user logic in here to users service).
A 12 de outubro de 2019 19:09:46 WEST, organnerx
<EMAIL_ADDRESS>escreveu:
Depending on what are you planning to do next. In many cases I
prefer to have everything in one place.
But in this case, when you have different modules, you better to not
merge them and leave it as it is. They all have different ideas and
functionality. The current structure is optimal for a project like this.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/L-Leite/cso2-master-services/issues/22?email_source=notifications&email_token=ABFZOTVAV2MAKVQZLYERJVDQOIHGVA5CNFSM4JADF752YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCFGSQ#issuecomment-541348682>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFZOTVZCGSCAVSB3FMTSV3QOIHGVANCNFSM4JADF75Q>.

I think chat service is an important function. And I prefer to have everything in one place.

cso2-master-server is good for packet sending and receiving, but it is not necessary to split it in as many services, as many packets you have. I think you can leave basic services that should be in the game by default and small ones inside the master server: channels, rooms, game start; maybe even add: broadcast, daily mission, tutorial, shop. But chat system location is depend on how much code and logic it have. If you think it should be moved to a new repository then its fine.

you can divide them into main services and user information services，and you can fix these problems on user services.


Handle WP/IF in such a way to allow nested calls.

If caller of kexec_init() has WP=0, keep an extra sched_pin() refcount.

@marcan do you get auto-notified of these? :P

If I am, I'm sure he does.


added styles for section structure

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #31
Test URLs:

Before: https://main--sunstar--hlxsites.hlx.live/_drafts/sagar/structure

After: https://31-about-us-structure-page-styling--sunstar--hlxsites.hlx.live/_drafts/sagar/structure

[ ]  If you are adding a new block or a variation to an existing block, has it been added in the block-library ?

it is a old PR. will be creating a new pr with latest changes


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit 3485f79:
:clock10: Full build: the average full build time is 7 min(s) 48 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 3485f79:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update to svelte 4

Any plans on updating this package to svelte version 4?

FWIW, #97 addresses this partially.

fixed on v2.2.5


Discover secondary files for inputs (#211)

Should address #211
I only fixed this in the CWL 1.0 bindings.  I wanted to get feedback on my approach before doing anything else.

This PR doesn't actually seem to solve the issue.  The timing of the bindings.preprocess step seems to prevent the secondaryFiles field from being set at the right point.

This is cool. We need to add this in other bindings as well.


Results and logs documentation

Hi,
I am trying to run this lib and its strategy samples.
is there more doc on the logs that are printed after backtester is done, I would like to understand the performance of a stategy and it's not very clear or explained in code/readme/manual.
Alternatively is the a project/UI tool/open source that uses the lib and you can point me to it?
For example, i get these log prints when running:
(demeter)  strategy-example (master) ✗ python3 12_constant_Interval.py
2023-10-18 17:58:15,790 - INFO - data has been prepared
2023-10-18 17:58:15,791 - INFO - init strategy...
2023-10-18 17:58:15,793 - INFO - start main loop...
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████| 15840/15840 [00:06<00:00, 2588.13it/s]
2023-10-18 17:58:21,940 - INFO - main loop finished
2023-10-18 17:58:22,042 - INFO - Broker
Asset amounts
usdc      :0                        eth       :0.0707372737666261654660170258
Markets
uni_market(UniLpMarket)
token0    :usdc                     token1    :eth                      fee       :0.0500                   is 0 base :True
positions
lower_tick  upper_tick                       pending0                          pending1        liquidity
0      201318      203819  11.25578570434480907228378585  0.006292688370498359591955467510<PHONE_NUMBER>47826
2023-10-18 17:58:22,042 - INFO - Account Status
2023-10-18 17:58:22,042 - INFO -                                          net_value usdc                             eth           uni_market_net_value       uni_market_base_uncollected         uni_market_quote_uncollected    uni_market_base_in_position    uni_market_quote_in_position  uni_market_position_count
2022-08-05 00:00:00  1999.502335313296790636961503    0  0.0707372737666261654660170258  1885.735520583365642398358784  0.002317256849493052428779442252     1.122703402876110291885239120E-8<PHONE_NUMBER>999993698541062311   0.551036957449638596322551911                          1
2022-08-05 00:01:00  1999.503159161726183291339706    0  0.0707372737666261654660170258  1885.736344431795035052736987  0.002376082206750144045744816348     4.868986665685556989979950670E-7<PHONE_NUMBER>999993698541062311   0.551036957449638596322551911                          1
2022-08-05 00:02:00  1999.505414272171702021080411    0  0.0707372737666261654660170258  1885.738599542240553782477692  0.002376082206750144045744816348  0.000001889068230138732202928621405<PHONE_NUMBER>999993698541062311   0.551036957449638596322551911                          1
2022-08-05 00:03:00  2000.010042428917993894827471    0  0.0707372737666261654660170258  1886.186332913802682057146282  0.007769810024119111652365549753  0.000001954612027542642486319156519  1003.389977568857216796791728  0.5486188742034648538134621155                          1
2022-08-05 00:04:00  2000.011791998832975502438095    0  0.0707372737666261654660170258  1886.188082483717663664756906  0.008514742480334209166075439656  0.000002578957475953257275966616112  1003.389977568857216796791728  0.5486188742034648538134621155                          1
...                                            ...  ...                             ...                            ...                               ...                                  ...                            ...                             ...                        ...
2022-08-15 23:55:00  2097.331940403029013849406112    0  0.0707372737666261654660170258  1962.511694511516152630184097     11.25578570434480907228378585     0.006292688370498359591955467510  1939.262489379837990181000271                               0                          1
2022-08-15 23:56:00  2097.331940403029013849406112    0  0.0707372737666261654660170258  1962.511694511516152630184097     11.25578570434480907228378585     0.006292688370498359591955467510  1939.262489379837990181000271                               0                          1
2022-08-15 23:57:00  2097.185207452937580868677203    0  0.0707372737666261654660170258  1962.499707685831809325579027     11.25578570434480907228378585     0.006292688370498359591955467510  1939.262489379837990181000271                               0                          1
2022-08-15 23:58:00  2096.950739708552203283392838    0  0.0707372737666261654660170258  1962.480553678645302295496506     11.25578570434480907228378585     0.006292688370498359591955467510  1939.262489379837990181000271                               0                          1
2022-08-15 23:59:00  2096.950739708552203283392838    0  0.0707372737666261654660170258  1962.480553678645302295496506     11.25578570434480907228378585     0.006292688370498359591955467510  1939.262489379837990181000271                               0                          1
[15840 rows x 9 columns]
2023-10-18 17:58:22,049 - INFO - Backtesting finished, execute time 6.25815224647522s
Thanks.

Well, sorry for the lack of document, some design has updated but the document is not updated coordinatily. But we are planning to improve it. In version 0.3.0 release, documents and comments will be refined.
for the example you provided. It has the following sections.

Broker: asset balance of broker. that's the "cash" you own
Markets:  We consider an pool as a market, you can set several market like usdc/eth pool, dai/usdc pool
uni_market is one of those pool, from the sample strategy code, you will find it's a usdc/eth pool,
positions shows the position you hold in the end.
Account Status: Changes in funding during the backtesting period, includes:

net_value: total net value
usdc: token amount you are holding
eth: token amount you are holding
uni_market_net_value: net value in this pool
uni_market_base_uncollected, uni_market_quote_uncollected: uncollected fee in position
uni_market_base_in_position uni_market_quote_in_position: base and quote token amount in this pool (calculated through liquidity)

hope those will help.


Missing data in Get5

I'm not quite sure where the problem occurs, but I find that Get5 can control the server via RCON just fine. But when a match is over, the data is not updated in Get5, in fact, no data about the match comes in.
Since all documentation about Get5 is about Sourcemod, I don't even know if I need to install anything. All matches run fine and can be started without any problems. The only thing that indicates errors is the below from the log.

[MatchZy] [ExecuteChangedConvars] Execing: get5_web_api_url "https://get5.domain.dk/api"
[MatchZy] [ExecuteChangedConvars] Execing: get5_check_auths "1"
Unknown command 'get5_web_api_url'!
Unknown command 'get5_check_auths'!

I hope you can help!

Hey!
According to the logs, get5_web_api_url command is being sent to the server, but it should be sending get5_remote_log_url
This means either you're using an older version of G5API, or it is not able to detect the server properly
So you can follow these 2 steps:

Remove and re-add server in you Get5 Panel
If the above step doesn't work, re-install the latest version of G5V and G5API (MatchZy works with the latest one only).
If you need help installing the latest version, you can install it using docker following the steps mentioned here:
https://shobhit-pathak.github.io/MatchZy/get5/#using-docker

Thanks!

I followed your instructions and it didn't work, even after reinstalling servers and get5. But out of the blue, it suddenly worked. Thanks for a great project!


Check if a project has complete packages of files including .scm, .bk…

…y and .yail before building.
Fixes #1035

Build finished.


Update README on design kit repo

Update README on https://github.com/IBM/carbon-design-kit

QA the page

[ ] make sure links point to the right place
[ ] make sure content is up to date.


fix: APPLICS-650 - Accessibility Audit report: Remediation tasks - project updates FO

https://pins-ds.atlassian.net/browse/APPLICS-650?atlOrigin=eyJpIjoiNDgxOTJlNmM0ZjA3NGFkOWJjMGI4YzUyYjQzN2M3NmIiLCJwIjoiaiJ9
Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Magic pen

Closes #54
Requires some testing / bug hunting. There's bugs for sure simply because how it is hacked together through different kinds of application hacking interfaces, actually there's even few actual more or less useful programming interfaces.
All planned nodes not implemented yet but many signs and other nodes are, see list: #54 .
So far I've not checked if feather pen is okay, and maybe should change wield texture to something bit cleaner.
I think inventory texture is fine for both feather and graphite variants.
Also mod.conf is not compatible with https://github.com/minetest/contentdb/issues/243
Next release would be lua debugging tools anyway, not this one.
But when merging this add issue as reminder if ContentDB ticket is still open.

Pasting over 300k content (copied from book) to road_signs:
2020-11-07 18:45:37: ACTION[Server]: SX uses metatool:magic_pen, pointing at [node under=-175,10,21 above=-175,10,22]
2020-11-07 18:45:38: ERROR[Server]: In thread 7fd300f4b700:
2020-11-07 18:45:38: ERROR[Server]: /build/minetest-6u0nkv/minetest-5.3.0/src/script/cpp_api/s_base.cpp:8c: static int ScriptApiBase::luaPanic(lua_State*): A fatal error occurred: LUA PANIC: unprotected error in call to Lua API (not enough memory)

World.mt for context

Transfer from digistuff:panel and digilines:lcd to homedecor:book_blue works.
I can't apply text to the displays, but I guess this is intended behavior.

@6r1d yes it is intended behavior, quote from issue #54

Allow reading text content from any node that displays text or contains text.
Allow writing to nodes that can be written without special tools.

What about travelnets? I can copy station group and name, but I can't apply them to either new or working travelnet.
By the way, I'm using Sokomine's version of Travelnet, there might be forks that function differently.

What about travelnets? I can copy station group and name, but I can't apply them to either new or working travelnet.
By the way, I'm using Sokomine's version of Travelnet, there might be forks that function differently.

Travelnet copy function seems to be broken, it was actually intended to copy network name and full text list of travelnet names in that network.
Not sure if applying travelnet, owner and network to single travelnet is better than allowing to copy list of connected travelnet names without ability to apply any data for travelnets. Because applying data to another travelnet will not work if there is already travelnet with same name in network.
It could be used to move travelnets:

Copy travelnet name, owner and network to tool memory.
Remove travelnet and place it again to some different location.
Apply copied data to new travelnet to easily place it back to original network and with same name.

Or it could be used to copy list of travelnets in network to books, posters, etc.

Copy travelnet name, owner and network to tool memory.
Apply copied data to poster or book

That is pick one situation, not sure which is more useful but probably travelnet data cloning is not really that important and therefore maybe should do read only (copy list of travelnets in network), allow writing only to books/posters/signs/etc. but not to travelnets.
So options would be either to fix copying list of travelnet names or implement applying copied travelnet data to actual travelnet boxes.

Added Lua controller / lua tube comment parsing and fixed travelnet network reading, no write support added for travelnets.
Only owner can copy travelnet targets with coordinates, anyone can copy targets without coordinates.

Not sure if applying travelnet, owner and network to single travelnet is better than allowing to copy list of connected travelnet names without ability to apply any data for travelnets. Because applying data to another travelnet will not work if there is already travelnet with same name in network.

I don't think it is required to apply to travelnet. Being able to copy to book is great. Mostly at least the name will change when I re-place travelnet.


OkHttpConnector: Enforce use of TLSv1.2 to match current Github and Github Enterprise TLS support.

On Feb 8, 2018, Github changed their TLS settings to be 1.2 only.
Most recent Jenkins installs are OK as Java 1.8 defaults to TLS 1.2, however some people see intermittent
or continuous failures with connecting to Github in a variety of configurations:
e.g. https://issues.jenkins-ci.org/browse/JENKINS-49761?jql=project %3D JENKINS AND component %3D github-api-plugin
This PR creates a new TLS v1.2 only SSLContext and attaches its socket factory to the urlFactory passed to OkHttpConnector, which is used by most Github plugins in Jenkins.

CC @KostyaSha @lanwen @stephenc who maintain the dependent plugins

@oleg-nenashev i don't maintain it since cloudbees ....
lanwen is not maintaing github-api-plugin, there is nothing on github-plugin side

Well, I added you to CC so that you know where to redirect the issues 🤷♂

@kohsuke Do you agree if I merge this PR and cut a release?

Are there plans to cut a new version of the plugin?


High CPU Usage and Performance Issues with Long Chat Threads

Description:
I want to highlight a significant performance issue that affects many users of the OpenWeb UI, especially those interacting with long chat threads. As mentioned in issue #3620, I've noticed that the application exhibits substantial lag and high CPU usage when handling extensive conversations, which is becoming a blocker for my daily usage of this otherwise excellent product.
Problem:
The performance of the UI deteriorates significantly in chats with long threads, leading to:
High CPU Usage:  My machine’s fan ramps up due to the CPU workload, indicating potential overheating concerns.
Long Wait Times:  The chat interface often becomes unresponsive, necessitating users to wait for the UI to catch up or restart their browsers.
Rapid Chat Growth:  When engaging with the Whisper interface, it doesn't take long to build a lengthy conversation. After about 10 minutes of back-and-forth dialogue, the chat can grow quickly, leading to substantial CPU usage.

Requested Solution:
Rather than considering this an enhancement, this is a fundamental issue that deserves urgent attention:
Prioritize Optimization:  Address the performance bottlenecks associated with long chat threads.
Consider Features for Mitigation:  A shallow clone feature that retains only the last few exchanges could help ease the burdens on system resources.

As a regular user who utilizes this fantastic tool multiple times a day, I appreciate all the hard work and dedication that has gone into developing it. However, this performance issue is causing frustrations that impact my experience. It would be wonderful to see this addressed, as it greatly affects usability.
Thank you for your attention to this matter! I'm looking forward to any improvements that can be made.

Closing in favour of https://github.com/open-webui/open-webui/issues/3620
I agree 100% and I've been trying to investigate this issue, and will try to allocate my effort into resolving this when I have more time but I'd appreciate some help from the community here!


[BUG]: Uncaught Error Error: Frame not initialized when using React StrictMode

What happened?
I have a React app with a custom payment integration that implements the "collect payment details before creating an intent" flow. It works beautifully,  until I wrap the entire app with <StrictMode>.
The error below appears after <PaymentElement> renders (before any attempt to submit a payment).
It is not trivial to set up a reproduction; any pointers I should look into based on the information here?
I'm using the latest versions of stripe-js and react-stripe-js.
Uncaught Error Error: Frame not initialized.
    at Oe.canMakePayment (js.stripe.com/v3:1:563073)
    at d._canMakePaymentForBackingLibrary (js.stripe.com/v3:1:592280)
    at <anonymous> (js.stripe.com/v3:1:594032)
    at <anonymous> (js.stripe.com/v3:1:170767)
    --- Promise.then ---
    at Jt (js.stripe.com/v3:1:271518)
    at $t (js.stripe.com/v3:1:280238)
    at Vn (js.stripe.com/v3:1:327793)
    at t (js.stripe.com/v3:1:333121)
    at <anonymous> (js.stripe.com/v3:1:346437)
    at <anonymous> (js.stripe.com/v3:1:101702)
    at <anonymous> (localhost꞉3000/node_modules/.vite/deps/@stripe_react-stripe-js.js?v=d113817b:622:33)
    at commitHookEffectListMount (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:16904:34)
    at commitLayoutEffectOnFiber (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:16992:23)
    at commitLayoutMountEffects_complete (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17976:17)
    at commitLayoutEffects_begin (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17965:15)
    at commitLayoutEffects_begin (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17946:19)
    at commitLayoutEffects_begin (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17946:19)
    at commitLayoutEffects_begin (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17946:19)
    at commitLayoutEffects (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:17916:11)
    at commitRootImpl (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19349:13)
    at commitRoot (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19273:13)
    at finishConcurrentRender (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:18801:15)
    at performConcurrentWorkOnRoot (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:18714:15)
    at workLoop (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:197:42)
    at flushWork (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:176:22)
    at performWorkUntilDeadline (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:384:29)
    --- postMessage ---
    at schedulePerformWorkUntilDeadline (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:407:18)
    at requestHostCallback (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:418:13)
    at unstable_scheduleCallback (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:330:15)
    at scheduleCallback$1 (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19822:22)
    at ensureRootIsScheduled (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:18648:31)
    at scheduleUpdateOnFiber (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:18558:13)
    at dispatchSetState (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:13026:15)
    at safeSetContext2 (localhost꞉3000/node_modules/.vite/deps/@stripe_react-stripe-js.js?v=d113817b:307:7)
    at <anonymous> (localhost꞉3000/node_modules/.vite/deps/@stripe_react-stripe-js.js?v=d113817b:319:11)
    --- Promise.then ---
    at <anonymous> (localhost꞉3000/node_modules/.vite/deps/@stripe_react-stripe-js.js?v=d113817b:317:28)
    at commitHookEffectListMount (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:16904:34)
    at invokePassiveEffectMountInDEV (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:18320:19)
    at invokeEffectsInDev (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19697:19)
    at commitDoubleInvokeEffectsInDEV (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19682:15)
    at flushPassiveEffectsImpl (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19499:13)
    at flushPassiveEffects (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19443:22)
    at <anonymous> (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:19324:17)
    at workLoop (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:197:42)
    at flushWork (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:176:22)
    at performWorkUntilDeadline (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:384:29)
    --- postMessage ---
    at schedulePerformWorkUntilDeadline (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:407:18)
    at performWorkUntilDeadline (localhost꞉3000/node_modules/.vite/deps/chunk-ENBTKYLN.js?v=704b1d1b:387:17)
v3:1
Oe.canMakePayment @ js.stripe.com/v3:1:563073```

### Environment

_No response_

### Reproduction

_No response_

Hey there, this is more relevant to @stripe/react-stripe-js specifically, but the short answer is that we don't support StrictMode. If you want to evaluate other parts of your app using Strict Mode, you'll need to apply that lower in the tree or otherwise exempt any Elements components from it.
You can read a bit about the reasoning in this reply to a previous issue on that repo: https://github.com/stripe/react-stripe-js/issues/256#issuecomment-1044792410