Generate .spec files for already existing components / services

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

@angular/cli: 1.4.2
node: 8.1.3
os: darwin x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.4.2
@angular/compiler-cli: 4.3.6
typescript: 2.4.2
Repro steps.

The log given by the failure.

Desired functionality.

I want to generate a .spec file for already existing component / service that does not have a spec yet / has an outdated spec. More on the usecase https://stackoverflow.com/q/46276055/1990451
Mention any other details that might be useful.

A small addition: would be incredibly perfect if the just created .spec.ts files would have mocks for the every injected item according to the methods / properties that are used in the unit being tested :)

Right now, specs are directly tied to the unit they're testing (component/service) and as of now there are no plans to support this, but leaving this open for discussion purposes.

+1

Yes generating a spec file after we already generated our component and modified it.
ng g component your-component --spec-only

What I do to generate the spec file for an already existing component:
ng generate component [name]

And then answer "no" to the "Overwrite ... ?" questions regarding already existing, non-spec, files.

@michaelbazos it doesn't work, it simply notifies that the component already exists.

I'd like to add my vote for this.
Even if it was only able to create the "[object] works!" type test, it would still save on boilerplate.

@darkbasic Indeed, just updated my version of angular-cli to 1.6.0, and it seems no file is generated if any of the [component | template | spec | stylesheet] already exists. Previously I was on 1.4.x, and it used to create non existing files, and ask for already existing ones.

So, it's a misdocumented feature then? @Brocco can you confirm it's the right way to do stuff?

Agreeing with this. I'm currently reconstructing a project and the previous devs manually deleted spec files, my afternoon's very long.

+1 from me. Refactoring unconventional tests to work with Wallaby and could really use this feature.

+1

+1

+1

+1

+1

+1

+1

I created a pull request implementing the feature https://github.com/angular/devkit/pull/938 .
Allows to create specs for component, directive, module, service, pipe, guard (based on corresponding components) by running
ng g spec my-component.component

or as a file (more convenient because files normally already exist and it is easier to point to the file)
ng g spec /my/project/app/src/blah/my-component.component.ts

Please review.

+1

+1

For anyone still looking for a solution to this:
https://www.npmjs.com/package/angular-spec-generator
This seemed to work fairly well for me.

As an outcome of the pull request: the custom schematic as a standalone library ngx-spec. Please check and share your feelings there.
@Brocco I leave the thread open as a reference for the future RFC / standard.

I think this should be possible without installing a additional node package

+1
I think this should be possible without installing a additional node package

+1

+1

+1

+1

my whole dev team

+1

+1

+1

+1 why does this not exist...

+1

+1

+1

Ich bin derzeit nicht im Büro. Ich kehre zurück am  02.05.2019.
Ich werde Ihre Nachricht nach meiner Rückkehr beantworten.
Bei dringenden Angelegenheiten bitte an folgende Personen wenden:
Webframework: Gernot Binder
Widgetsystem: Rainer Neunteufel
Mein ELBA Architektur: Peter Anderle
Mein ELBA ZVKK: Gerhard Weinberger
PSD2: Harald Mülleder
Die Rückmeldung bezieht sich auf ein Mail mit folgendem Thema:
Re: [angular/angular-cli] Generate .spec files for already existing
components / services (#7727)

Gesendet (c) GRZ/RACON Linz 2019 Agent 'Abwesenheit'

Raiffeisen Software GmbH
Firmenbuchnummer: 86804d, Landesgericht Linz
DVR: 0572934, UID: ATU 36961105
Der Austausch von Nachrichten mit dem oben angeführten Absender via E-Mail
dient ausschließlich Informationszwecken. Rechtsgeschäftliche Erklärungen
dürfen über dieses Medium nicht ausgetauscht werden.
Correspondence with above mentioned sender via e-mail is only for
information purposes. This medium is not to be used for the exchange of
legally-binding communications.

I realize this thread is a bit dated, however I've just run into this myself (wishing for a ng g spec type of functionality). That said, if anyone else runs across this and is looking for a simple way to do this, I've found this project to fill the hole for now https://github.com/allenhwkim/ngentest

Something I do is...
generate component COMPONENT-NAME --force
then in GIT revert the items that got overwritten

this simple thing still not in?

Ich bin derzeit nicht im Büro. Ich kehre zurück am  08.07.2019.
Ich werde Ihre Nachricht nach meiner Rückkehr beantworten.
Die Rückmeldung bezieht sich auf ein Mail mit folgendem Thema:
Re: [angular/angular-cli] Generate .spec files for already existing
components / services (#7727)

Gesendet (c) GRZ/RACON Linz 2019 Agent 'Abwesenheit'

Raiffeisen Software GmbH
Firmenbuchnummer: 86804d, Landesgericht Linz
DVR: 0572934, UID: ATU 36961105
Der Austausch von Nachrichten mit dem oben angeführten Absender via E-Mail
dient ausschließlich Informationszwecken. Rechtsgeschäftliche Erklärungen
dürfen über dieses Medium nicht ausgetauscht werden.
Correspondence with above mentioned sender via e-mail is only for
information purposes. This medium is not to be used for the exchange of
legally-binding communications.

+1

+1

+1

+1

+1 & +whole dev team

I found I wanted to do this. In the end I just generated a new component with a spec called something very similar to the real component, then renamed the spec and deleted the new component.

+1


Flow type components

 Issue by landonreed
Tuesday Aug 21, 2018 at 17:02 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/pull/235

Add flow typing to library (nearly) all components.  Notable components this avoids are some of the modal components, which need to be refactored altogether because they rely heavily on refs and accept state/props through their open method, and the Settings components, which should see a refactor in #41.
This PR raises the flow coverage to a semi-respectable 76%.

landonreed included the following code: https://github.com/catalogueglobal/datatools-ui/pull/235/commits

 Comment by codecov-io
Tuesday Aug 21, 2018 at 17:45 GMT

Codecov Report

Merging #235 into dev will decrease coverage by 0.05%.
The diff coverage is 0.38%.

@@           Coverage Diff            @@
##             dev    #235      +/-   ##
========================================
- Coverage    3.6%   3.55%   -0.06%
========================================
  Files        327     325       -2
  Lines      11839   12035     +196
  Branches    4202    4297      +95
========================================
+ Hits         427     428       +1
- Misses      9373    9526     +153
- Partials    2039    2081      +42

Impacted Files
Coverage Δ

lib/editor/reducers/index.js
0% <ø> (ø)
:arrow_up:

lib/admin/reducers/organizations.js
27.77% <ø> (ø)
:arrow_up:

lib/editor/reducers/settings.js
29.41% <ø> (ø)
:arrow_up:

lib/alerts/reducers/alerts.js
10.95% <ø> (ø)
:arrow_up:

lib/editor/reducers/mapState.js
28.57% <ø> (ø)
:arrow_up:

lib/signs/containers/ActiveSignEditor.js
0% <ø> (ø)
:arrow_up:

lib/manager/containers/ActiveFeedSourceViewer.js
0% <ø> (ø)
:arrow_up:

lib/manager/actions/status.js
0% <ø> (ø)
:arrow_up:

lib/manager/components/ProjectsList.js
0% <ø> (ø)
:arrow_up:

lib/editor/util/map.js
10% <ø> (ø)
:arrow_up:

... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ccc70...17fd1cf. Read the comment docs.

 Comment by landonreed
Thursday Aug 23, 2018 at 18:07 GMT

OK, @evansiroky.  I've addressed all of your comments.  Good to merge?


Cumulative ExponentialHistogram resets start time each collection

What happened?
Cumulative ExponentialHistogram points have their startTime reset each collection. E.g.
// current incorrect behavior

t0-------t1                   first collection
         t1-------t2          second collection
--------------------------> t

// instead of correct behavior

t0-------t1                    first collection
t0-----------------t2          second collection
--------------------------> t

Steps to Reproduce
https://github.com/open-telemetry/opentelemetry-js/pull/3930
Expected Result
The startTime should be the same each MetricReader collection for the same metric. The tests in linked PR draft should pass.
Actual Result
The startTime resets each collection (like a delta temporality) while the value continues to grow cumulatively. The linked PR test fails.
Additional Details
Looks like the merge function is not merging the start times: https://github.com/open-telemetry/opentelemetry-js/blob/74393ac6397dcb130b9d5dae35354a2bf9a0d2c3/packages/sdk-metrics/src/aggregator/ExponentialHistogram.ts#LL219C33-L219C33
OpenTelemetry Setup Code
No response
package.json
No response
Relevant log output
No response

I'm happy to submit a PR for this btw, I think i already found the fix.

Hi @aabmass, thanks for reporting this.
A PR to fix this would be very welcome :slightly_smiling_face:


loading player with custom header field support

Is there any support for custom headers? I want to init player using AVAsset, not using URL.
TIA.

pod "5.6.0", I add new function.
Try it!
self.mmPlayerLayer.set(asset: <#T##AVURLAsset?#>)


Add Single-Assignment C (SaC) compiler image

With this PR I'd like to add the build configuration to create a glot image for the SaC compiler.
I've successful built and run an image locally.
The SaC package(s) are being pulled in from https://github.com/cxandru/sac-nix (currently my fork, see below), which is setup as a nix flake. I'm using flake-compat as a shim, which lets me import the package derivation into the image build instructions, I'm not 100% sure if this is OK to do (nix doesn't complain, but it does feel a bit weird). I'm open to any suggestions on how to improve this.
ToDo:

[x]  update coderunner.nix to pull in latest commit (waiting on https://github.com/glotcode/code-runner/pull/1 to be merged).
[x] update sac.nix to pull from https://github.com/cxandru/sac-nix (instead of my fork); waiting on merge

added ref for https://github.com/cxandru/sac-nix now, the PR is complete as far as I can tell.

Cool, thanks. I will try to get this deployed within the week.

Cool, thanks. I will try to get this deployed within the week.

Awesome!!!! Thank you!

I got sick so the deployment was delayed, but it is now live on glot.io.
Thanks again for your contribution :)

Hi @prasmussen, thanks! I hope you're doing better!


If hidden then shown Animation does not work

Hi there, nice project, I've learned so much from it, now I am trying out to show a spinner only if a certain condition happens and what I am seeing is that if is behind an IsVisible the animation does not work.
As an example I am putting here the xaml I use
    IsVisible="{Binding !CanClickGenerate}"
    Value="fa-spinner"
    Animation="Pulse"/>

for some reason once that bool flips, I can see the icon but it is not animated, I also tried wrapping it in a Panel to avoid touching Icon itself but it didn't work
<Panel Margin="0,30,0,0"
    IsVisible="{Binding !CanClickGenerate}">
    <i:Icon FontSize="20"
        Value="fa-spinner"
        Animation="Pulse"/>
</Panel>

using it by itself works just fine
<i:Icon FontSize="20"
    Value="fa-spinner"
    Animation="Pulse"/>

So I don't really know what the problem is or whether this is a bug

I will look into it.
Maybe you could try an animation on another object than an icon to verify there is no bug in Avalonia itself?

will try it out, if you want I can share an example project

Nice. An example project would help me. Thanks.

I was trying to compose an example and it works fine, I think the problem is in my app, as I am running an async task and I thought the dispatcher would run it in another thread instead it locks the UI thread and prevents the animation to run.
I am toggling a bool when I click a button to show the icon and animate it, and somethings happens like this
GenerateTeams = ReactiveCommand.CreateFromTask(() =>
        {
            CanClickGenerate = false;
            Dispatcher.UIThread.InvokeAsync(() =>
            {
                // a task that might take 1 second
                CanClickGenerate = true;
            }, DispatcherPriority.Background);

            return Task.CompletedTask;

        }, canGenerate);

I thought the dispatcher would run it somewhere else, maybe I misread the docs of avalonia, but it looks like it is not your issue man, thanks anyway


Switch to Deluged from Transmission

https://www.howtogeek.com/142044/how-to-turn-a-raspberry-pi-into-an-always-on-bittorrent-box/

https://github.com/linuxserver/docker-deluge/blob/master/Dockerfile

https://github.com/jakexks/docker-deluge-seedbox
https://github.com/aostanin/docker-deluge
https://github.com/linuxserver/docker-deluge
https://github.com/MarvAmBass/docker-deluge
https://github.com/manicmonkey/deluge-download


Not compatible with recent julia

Hello
Seismic.jl is not compatible with the fairly recent julia version 6.2.0 or any late ones due to the use of the package Grid.jl that is outdated and unmaintained (last update was in 2016).

I noticed it I m trying to revamping all to stable 1.0 but other things got
on my way
Sent from my iPhone
On Aug 24, 2018, at 8:42 AM, Mathias Louboutin<EMAIL_ADDRESS>wrote:
Hello
Seismic.jl is not compatible with the fairly recent julia version 6.2.0 or
any late ones due to the use of the package Grid.jl that is outdated and
unmaintained (last update was in 2016).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SeismicJulia/Seismic.jl/issues/59, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEdueWYaOT6Ep4MMAG3gZZ7leHJNT0Weks5uUBDqgaJpZM4WLefl
.

Hello Mathias,
This might have happened because you are not using the last version of
Seismic.jl. Please run Pkg.checkout("Seismic") to stay updated to the
last version of the repository, as stated in
https://github.com/SeismicJulia/Seismic.jl under the* Installation *
instructions.
Regards,
Juan
On Fri, 24 Aug 2018 at 11:42, Mathias Louboutin<EMAIL_ADDRESS>wrote:

Hello
Seismic.jl is not compatible with the fairly recent julia version 6.2.0
or any late ones due to the use of the package Grid.jl that is outdated
and unmaintained (last update was in 2016).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SeismicJulia/Seismic.jl/issues/59, or mute the thread
https://github.com/notifications/unsubscribe-auth/AMa6o2W3d3hd-8_8ILch4DQt9H6nE_a0ks5uUBDqgaJpZM4WLefl
.

Yes Mathias, you are right, the last registered version is outdated, sorry
about that.
Regards,
Juan
On Fri, 24 Aug 2018 at 15:24, Mathias Louboutin<EMAIL_ADDRESS>wrote:

Please run Pkg.checkout("Seismic") to stay updated to the
last version of the repository
This indeed fixed it. However the registered version (Pkg.add) is
outdated as it shouldn't require an extra checkout.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SeismicJulia/Seismic.jl/issues/59#issuecomment-415842730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMa6o13047vnWcvpSzZrTLjRW8RP1RyDks5uUET2gaJpZM4WLefl
.


No support for EKS in helm

Cert-Manager and Trust-Manager both use ValidatingWebhookConfiguration as part of their helm deployments, however cert-manager has specifically got support for AWS EKS, where these webhooks require hostnetwork: true to be set. This is because the EKS control plane sits apart from the rest of the cluster. Cert-manager documents the config changes needed to work in EKS but currently the Trust-Manager helm chart neither supports these changes nor documents how it can done. Without these changes, it is currently not possible to have a stable deployment of trust-manager on AWS EKS.
if deploying right now, you would see errors like the following:
cannot patch "cert-bundle" with kind Bundle: Internal error occurred: failed calling webhook "trust.cert-manager.io": failed to call webhook: Post "https://trust-manager.default.svc:443/validate?timeout=5s": Address is not allowed

The helm chart's webhook should be changed to allow a hostNetwork flag to be added so that EKS can be supported, which should also bring the chart in line with the cert-manager helm chart..

@ChevronTango Just to be completely clear, this is only necessary if using a non-standard CNI with EKS. We've been using this on EKS for sometime without hostnetworking turned on using the standard VPC CNI.

@ChevronTango Just to be completely clear, this is only necessary if using a non-standard CNI with EKS. We've been using this on EKS for sometime without hostnetworking turned on using the standard VPC CNI.

Ahh yes. Quite right. Good distinction to make!

I believe this issue is resolved by https://github.com/cert-manager/trust-manager/pull/156.
/close


Added check for token.escaped in heading tok()

I ran into this problem while trying to add anchor tags to token.text for headings. I noticed that any HTML added to token.text was being escaped by default. It seems like this could be easily fixed by adding in a check for token.escaped before calling inline.lexer.
I'll make a quick pull request for headings, but my guess is that this kind of check should be done anywhere you're using inline.lexer as someone may want to add HTML to token.text before parsing.
Quick side note: the code token.type does seem to do this check, not sure if it was a conscious decision to leave it out everywhere else.

Closing due to staleness and merge conflicts. See #956


Change Optimizer while training, after a certain number of steps?

I am working on machine translation, using seq2seq model in Tensorflow. I am aware that once the graph has been established, it cannot be modified during training.
What if I want to change the optimizer from SGD to Adam after certain global steps?
How should the code be?
Thanks a lot.

From https://www.tensorflow.org/versions/r0.11/resources/index.html:

For help and support, technical or algorithmic questions, please submit your questions to Stack Overflow: https://stackoverflow.com/questions/tagged/tensorflow. You may also find answers in our FAQ, our glossary, or in the shapes, sizes and types guide. Please do not use the mailing list or issue tracker for support.

I am also looking for the answer to this question. I am trying to change the var_list provided to the minimize() function after some iterations. I am trying to implement a two step finetuning, where for first 50 iterations, I will be training the last layer and after that finetuning the whole network.


typo - missing word

Under the header:
"Working with partially indexed items"
There is a missing word
"In cases when you need to examine partially items to validate that they don't contain relevant information,"
should read
"In cases when you need to examine partially indexed items to validate that they don't contain relevant information,"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6580cdcf-280e-215c-f4a0-d778b501946f
Version Independent ID: 3f88be2e-6413-c8e7-f234-f62a74075a2d
Content: Investigating partially indexed items in eDiscovery - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/investigating-partially-indexed-items-in-ediscovery.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@exactmike Thanks for catching this. I will fix it today.


Allow foreign functions to be called with empty byte arrays

Prior to this fix, the included test would panic when indexing into the empty byte array.
--- FAIL: TestHostCall_ForeignFunction (0.00s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 35 [running]:
testing.tRunner.func1.2({0x11ae4a0, 0xc000156228})
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1209 +0x24e
testing.tRunner.func1()
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1212 +0x218
panic({0x11ae4a0, 0xc000156228})
	/usr/local/Cellar/go/1.17.5/libexec/src/runtime/panic.go:1038 +0x215
github.com/tetratelabs/proxy-wasm-go-sdk/proxywasm.CallForeignFunction({0x11bfef7, 0x8}, {0x135d130, 0x0, 0x474})
	/Users/jmulcahy/Projects/proxy-wasm-go-sdk/proxywasm/hostcall.go:587 +0x130
github.com/tetratelabs/proxy-wasm-go-sdk/proxywasm.TestHostCall_ForeignFunction(0x0)
	/Users/jmulcahy/Projects/proxy-wasm-go-sdk/proxywasm/hostcall_test.go:41 +0x6c
testing.tRunner(0xc000105a00, 0x11d20a8)
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1306 +0x35a

thanks @jamesmulcahy, could you fix the test?
--- FAIL: TestHostCall_ForeignFunction (0.00s)
    hostcall_test.go:44:
        	Error Trace:	hostcall_test.go:44
        	Error:      	Not equal:
        	            	expected: string("")
        	            	actual  : []uint8([]byte(nil))
        	Test:       	TestHostCall_ForeignFunction

@mathetake Whoops, yes - of course.  Fixed in next push!

@jamesmulcahy thank you for the contribution! 💯  🕺


fix(linter): allow whitespace control characters in no-control-regex

#6140  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on  Graphite


Syntax highlighting for null conditional operator in JS ES7 showing error

I am working on a React Native project using Babel ES7. They now support using the null conditional operator (ie. object?.key), however when I write this code, VSCode tells me that it will cause an error. When I run the code, it works as expected with no errors. This issue is purely with the syntax highlighting.

VSCode Version: 1.33.1
OS Version: MacOS 10.14.4

Steps to Reproduce:

Open VSCode
Create new react app (create-react-app sample-app)
Try the null conditional syntax, noting the error text highlighting
Run the app and see that the new syntax actually works

Does this issue occur when all extensions are disabled?: Yes
I have also tried using some Babel ES7 plugins for syntax highlighting to see if that would help. Here's what I've tried:

https://marketplace.visualstudio.com/items?itemName=dzannotti.vscode-babel-coloring
https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

Tracked upstream by https://github.com/Microsoft/TypeScript/issues/16


[client-preset] FragmentType returns type never using client-preset 4.0.0

Which packages are impacted by your issue?
@graphql-codegen/client-preset
Describe the bug
Hi everyone, thank you for this great package!
We have been using codegen for a while now and recently updated the client-preset from 2.0.0 to 4.0.0 - now a lot of TypeScript errors are popping up across our react/next.js application. The errors could be found in every component that used fragments or that passed the fragment information down to a different component. Upon further inspection I was able to figure out that FragmentType is now returning never like in the screenshot below

It's still possible to access the information inside the fragment with useFragment, but the type is now unknown

Your Example Website or App
private repo
Steps to Reproduce the Bug or Issue

Follow the guide to create fragments
My fragment is similar to this:

const UserInfoFragment = graphql(/* GraphQL */ `
  fragment UserInfoFragment on User {
    id
    profile {
      id
      firstName
      lastName
    }
  }
`);

Type it using FragmentType<typeof UserInfoFragment>
Hover over the type or use two-slash queries
See type never

Expected behavior
Before we updated the client-preset, FragmentType did return the correct type information

Screenshots or Videos
No response
Platform

OS: macOS
NodeJS: v18.16.0
graphql version: 16.6.0
@graphql-codegen/* version(s):

cli: 4.0.1
client-preset: 4.0.0

While trying for a quick fix I also tried re-adding @graphql-codegen/typescript and @graphql-codegen/typescript-urql but this did not help.
Codegen Config File
schema: supergraph.graphql
documents: [utils/**/*.ts, pages/**/*.tsx, components/**/*.tsx, hooks/*.ts]
generates:
  gql/:
    preset: 'client'
    plugins: []
    config:
      dedupeFragments: true

Additional context
In the fragment-masking.ts file I found this error:

I'm pretty sure that no one in our team touched this file, so this might have happened on updating the client-preset version.

Which version of @graphql-typed-document-node/core do you use?
You need to use the latest version (v3.2.0) to use DocumentTypeDecoration .
(check out the CHANGELOG)

@tnyo43 Thanks for the running, found two different versions in the lockfile (3.2.0 and 3.1.1). Apparently TS did not recognize v3.2.0.
Was able to resolve this by adding the correct version to the resolutions in the package.json file!


[IMPROVEMENT] Connective, use urlTemplate for configurable url

Add the ability to use a configurable host url so customers can connect to their own Connective eSignatures environment

Please check the following conditions for your PR.

[x] apiDefinition.swagger.json is validated using paconn validate command.
[x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

Not sure why the swagger validation failed, because I made no changes to that file.
Also, I got this in mail:

Anything I need to do?

@YannickRe I'll go ahead and re-run the check. If it fails again, we'll dig deeper into what is going wrong. You can disregard any emails about it.

@dougelliott It seems like this still failed, but the error message is kind of non-descriptive... Anything I can do on my end?

@YannickRe Sorry about that, we'll take a look on our side and see what's happening.

@YannickRe Sorry about the trouble with the validation error. I was able to reproduce on my end and fixed by specifying UTF-8 encoding setting in the validation pipeline. I pushed this fix to the dev branch. Can you please update the dev branch from your git clone and merge the dev branch to your branch?
From your local copy of the source do the following:
git checkout dev
git pull
git checkout connective-urlTemplate
git merge dev
git push

@mamurshe This seems to have done the trick, thank you for the investigative action and happy it wasn't me 😉
@pmarzouk-cnve Sorry about this, but it seems like you need to re-approve this change...
@dougelliott Thanks for taking action! We really like to get this change out in to the world 🙂


[HELP] Get a child widget from a Notebook page

I have a Notebook with Listbox as child for every page.
When I try to get a child for current page I get only base class Widget.
This Widget has GtkListBox name but it hasn't any functionality of ListBox.
let current_page_index = my_notebook.current_page();  let current_page_child =                         my_notebook.nth_page(current_page_index).unwrap();
It hasn't append() function which I need, for example.
How can I get fully functional ListBox child from Notebook current page?

You have to cast the gtk::Widget as gtk::ListBox. let listbox = current_page_child.downcast::<gtk::ListBox>().unwrap()


README lacks an import in Usage > groovy-example ??

Excuses in advance if I'm missing something...
I'm trying to follow the Usage section in the README, the Groovy section
My problem is: I can't make the plugin work without adding this line
import java.text.SimpleDateFormat
without that line I get
unable to resolve class SimpleDateFormat
when running (for instance) ./gradlew patchChangelog
For reference my build.gradle is included below
/*
 * This file was generated by the Gradle 'init' task.
 *
 * This generated file contains a sample Groovy application project to get you started.
 * For more details take a look at the 'Building Java & JVM projects' chapter in the Gradle
 * User Manual available at https://docs.gradle.org/7.0/userguide/building_java_projects.html
 */

import org.jetbrains.changelog.ExtensionsKt
import java.text.SimpleDateFormat // <--- THIS IS THE LINE I HAVE TO INSERT!

plugins {
    // Apply the groovy Plugin to add support for Groovy.
    id 'groovy'

    // Apply the application plugin to add support for building a CLI application in Java.
    id 'application'

    id 'org.jetbrains.changelog' version '1.3.1'
}

apply plugin: 'org.jetbrains.changelog'

repositories {
    // Use Maven Central for resolving dependencies.
    mavenCentral()
}

dependencies {
    // Use the latest Groovy version for building this library
    implementation 'org.codehaus.groovy:groovy-all:3.0.7'

    // This dependency is used by the application.
    implementation 'com.google.guava:guava:30.0-jre'

    // Use the awesome Spock testing and specification framework even with Java
    testImplementation 'org.spockframework:spock-core:2.0-M4-groovy-3.0'
    testImplementation 'junit:junit:4.13.1'
}

application {
    // Define the main class for the application.
    mainClass = 'Changelogging.App'
}

changelog {
    version = projectVersion
    path = "./CHANGELOG.md"
    header = "[${-> version.get()}] - ${new SimpleDateFormat("yyyy-MM-dd").format(new Date())}"
    headerParserRegex = ~/(\d+\.\d+.\d+)/
    itemPrefix = "-"
    keepUnreleasedSection = true
    unreleasedTerm = "[Unreleased]"
    groups = ["Added", "Changed", "Deprecated", "Removed", "Fixed", "Security"]
}

tasks.named('test') {
    // Use junit platform for unit tests.
    useJUnitPlatform()
}

If you agree that the import is missing, will you please add it?

Thanks and sorry for delay


Unable to assign BGP models to custom fields

NetBox version
4.0.9 with BGP plugin 0.13.2
Describe the bug
When creating a new custom field via the Netbox UI it's not possible to select any of the BGP models for assignment.
To Reproduce
Steps to reproduce the behavior:

Go to /extras/custom-fields/add/ on your Netbox install
Try selecting a BGP plugin model from the Object types dropdown
See that none of the BGP models can be selected

Expected behavior
I expect to be able to assign custom fields to some of the BGP models, mostly sessions where the custom fields are documented in the API.
Screenshots
n/a
Additional context
n/a

I'm not able to reproduce your issue, would you mind to share further information ?

I'm also not able to replicate this. I'm removing the label bug for now pending further information.

I have this problem too but it is inconsistent as @mraerino mentions.
Netbox:	4.0.11
Netbox BGP:	0.13.3
In my local instance running these versions (and with prod database imported) I don't experience this at all and can make custom fields on the BGP plugin without any problem. However in our production and test environments I experience this problem as described - the BGP plugin objects are not searchable. For a workaround I could create the custom field using API without any issue.

I've set this to pending close  (as is the primary issue) as there's no easy way to replicate it - it would literally need a copy of databases to see why this occurs - its something database related.

@cruse1977 ah interesting, the order I give the plugins matters for me. I am also running with the netbox secrets plugins (2.0.3), if that config line reads PLUGINS = ["netbox_bgp", "netbox_secrets"] then I can see BGP objects ok for tags and custom fields, if netbox secrets is given first then I can't. In both instances I can see netbox secrets objects ok.

So the other case I'm aware of - also had netbox-secrets as the penultimate plugin prior to the one with model issues, so thats two cases.

Closing this issue out - its not an issue with BGP, more likely secrets.


Creating dye shops will consume one of the dye in hand

The shop will still be created, but a dye is consumed to color the black text on the shop. Perhaps an event cancellation will fix?

Fixed.


Failed to retrieve data, the repo or collector is most likey misconfigured

I'm using gitlab-scm-collector. the widget work fine with private and public repositories. but I got 404 ERROR while using nested gitlab group http://gitlab.company.com/someting1/something2/myprpject.git
2019-10-04 16:41:00,016 [taskScheduler-1] INFO  c.c.d.gitlab.GitlabUrlUtility - ---> Gitlab commits URI: https://gitlab.company.com/api/v4/projects/someting1%2Fsometing2/repository/commits/?ref_name=master&since=2019-10-04T15:03:30.652Z&per_page=100
2019-10-04 16:41:00,032 [taskScheduler-1] ERROR c.c.d.c.GitlabGitCollectorTask - Failed to retrieve data, the repo or collector is most likey misconfigured:
org.springframework.web.client.HttpClientErrorException: 404 Not Found

I meet this problem today, have you solved this problem ?

I meet this problem today, have you solved this problem ?

Hi @waterzhu until the PR is approved you can just apply the small patch on File src/main/java/com/capitalone/dashboard/gitlab/GitlabUrlUtility.java and replace line 418 by repoName = String.join("%2F", urlParts);. Will do the job ;)


Does Projects support relations?

Does Obsidian Projects support relations like DB Folder? I can't seem to find the option for this.

Unfortunately, Projects doesn't support anything... related to that 😈 Puns aside though, could you describe the feature a bit more? I haven't been using DBFolder that much.

I can't speak to DB Folder's implementation much, but if it's Notion-like, I would assume a Relation is a reference to one or more rows in another project/table, and a Rollup is a summary of a field of those rows. For example:
Table 1: team members

Name
Favourite number

James
23

Yusuf
13

Riko
17

Table 2: tasks

Task
Assigned team members
Lowest favourite number

Design
Yusuf, Riko
13

Development
Riko, James
17

Sales
Yusuf
13

Here, "Assigned team members" is a relation: it references a number of rows in table 1 (it might format visually as the Name field of those rows, but it function as a reference to the rows themselves). The "Lowest favourite number" is a rollup: it takes the previously defined relation field, Assigned team members, selects a field from the related rows (here, favourite number) and then computes a summary on them (here, the minimum).
That summary could just be identity if one external row is related (eg. Who is the lead for this task, and what is their favourite number?), or it could be some other aggregation function if several external rows are related to each row in the current project (eg. Who are all the team members assigned to this task, and what is the lowest of their favourite numbers?).

I hope to release more analytical tools in the future, but each row will likely still refer to a note.
Here are some ideas I've had:

Derived fields: Create transient fields that are computations of other fields. While I was initially thinking of things like creating a duration field from two dates, I don't see what the value of each cell could be an aggregated value, say from another project.
Aggregated fields: For example, in the Table view, you could display the sum for a number field at the bottom of the column, or the number of unique values in a string field.

Fair! To clarify, when I say that a Relation refers to an external row, I don't mean that it would necessarily change the structure of the row it's in. A row could still be backed by a single note; it's more a question of how the relation field is modelled. At its most basic, it could be a list of links to other notes.

I don't mean that it would necessarily change the structure of the row it's in.

Then it sounds like it would definitely be possible and within the scope of the plugin.
I'll close this issue since the question in OP has been answered. If you (or anyone else) be interested in something like this, please create a feature request. If possible, since relations is a rather big area, I'd appreciate feature requests describing more specific features.


feat: activations with webhooks

Allow WebHooks to be added in the eda server that can be shared with different activations.
Support for HMAC and token authentication.
https://docs.google.com/document/d/1YJ5yQPKXNO7_Nqa_QEJ_NwXS-u6ZE-rLBx6tnM10Wxo/edit

@mkanoor what's the rbac settings for webhooks? do you need to pre-seed them into DB? I missed it when adding the source model.

Migrations are not sync.

Updated

This should go in devel (or wait a time)
Also an internal jira ticket for tracking would be good.

Minor comment on create_initial_data.py file; I see that it has gotten way too large with the addition of webhook stuff and I wonder if we can split it up; we could do 3 separate commands for creating credential types, roles and webhook related stuff. Then we can have create_initial_data call these commands. I don't mean to block this PR, and this could be improved in a follow up PR as time allows but definitely something to think about. Thoughts? @mkanoor

@Dostonbek1 time permitting we can do that in a separate PR we would have to move all the credential types into a separate  file.

The e2e tests are passing https://github.com/ansible/eda-server/actions/runs/10190209744


default port 8953 for remote-control

It seems better to make default port number for remote-control correspond to that of IANA ub-dns-control 8953/tcp now that almost four years passed since 1.4.11 released in which new default for the control-port config setting contained, plus this puppet module does not specify any unbound versions.

Great, thank you.


Docs update? Linux compiler should support C++11 ==> C++14

Hi, just got a bit confused by the installation docs until I looked at what binding.gyp was doing, as it's a bit contradictory. They say

The code requires a gcc compiler supporting C++11 for linux.

I had pre-C++14 g++-4.8, that came with my distro (Ub 14.04-based). I've now updated to the current [C++14-supporting] g++-4.9 after the npm install failed with an error telling me about
  g++: error: unrecognized command line option ‘-std=c++14’

If I've got the wrong idea then apologies, but I might have cottoned on a bit sooner had the docs said "you need a compiler supporting C++14". Is it a typo // needs updating to reflect changes in the package?
Again, I might be wrong, but from looking at this are Macs also using C++14 compilers (so should the same edit be made to the OS X installation instructions)?

You can change to -std=c++11 for a build
It is a bit confusing because that was an experiment to see if it would compile with c++14 and I was looking to experiment with some code.  But the current code should build with c++11.
Yet if you have 4.9 it should build with -std=c++14 as well.

Ah, ok! I thought that might have worked but... felt like it made more sense to fix the error message rather than edit the binding.gyp on that hunch. Will leave it with you then :+1:

I'm working on producing prebuilts and will publish some updates.


README.md is outdated

The current README file does not mention using a form-control class on the target field, but when not used, script throws error: show-errors element has no child input elements with a 'name' attribute and a 'form-control' class
.

Using .form-control class on a checkbox, ie. requiring a user to check that they agree with your terms and conditions, it's invalid bootstrap code for a checkbox. So the result is the checkbox has style applied to it that makes it look really messed up (appears gigantic and with a shadow border). Therefore, angular-bootstrap-show-errors should not rely on a form-control class being present.

Checkbox without .form-control class:

+1. Facing the same issue.

+1 here, anyone found a workaround for the checkboxes problem?

Current workaround: Manually add the has-error class:
<form name="myFormName">

                <input type="checkbox" name="myCheckboxName"/>>
                My checkbox text

</form>

Up:
link is dead:

See the Bootstrap Form Validation Done Right in AngularJS blog post to read about the benefits of using this directive.


setup of the project

This adds a pyproject.toml (see What the heck is pyproject.toml for its purpose) and moves the metadata from setup.py to setup.cfg. With that, the only reason we still need setup.py is for editable installs (python -m pip install -e .).
For versions, both pint and xarray rely on setuptools_scm, which uses the repository's tags to provide a version. Should we use it, too?

This adds a pyproject.toml (see What the heck is pyproject.toml for its purpose)

Thank you for this. I haven't really set up all the CI and versioning stuff from scratch before, so I appreciate your help.

uses the repository's tags to provide a version

That sounds good, but where do we set the tags?
Separately, I've added tests with azure (copying xarray), but I'm having 2 issues:

Black formatting is creating code that flake8 doesn't like, but I guess I'll just remove the flake8 check.
The python3.8 checks are failing
It's currently downloading the test environments using pip but I guess we should use conda? pip is currently pointing to Pint's master branch too.

Tags are a git feature (mostly used for releasing). See xarray's HOW_TO_RELEASE.md file for an example.

black formatting is creating code that flake8 doesn't like

we can set ignores in setup.cfg (or pyproject.toml?). xarray has quite a list of ignores, we can go through each of them and see if that works out.

The python3.8 checks are failing

That's because there does not seem to be a py38 wheel for python, yet. We could switch to conda, which does not have that problem (though it is a bit slower than pip with wheels). Installing from github is possible with the pip section in conda's environment files.
Also, could you add a upstream-dev CI? It is really useful as a early warning system for breaking changes in the dependencies.

also, for the CI setup: since he did the setup for xarray, maybe @shoyer can guide you with that?

okay, now flake8 and black don't complain anymore and running python setup.py sdist bdist_wheel works, too
Should we merge this?

gentle ping, @TomNicholas

Thanks @keewis, this looks okay to me, if you're happy with this working do you want to just merge it and we can add other features like an upstream-dev CI in later?

yes, that's fine.

before I merge: what should be our preferred merge option? Github offers normal merge, squash merge and rebase merge. To keep a linear history on master, squash merge is the simplest but some history is lost (not sure if that's important, though).
If we decide on one, could you disable the others so accidentally using another option is impossible?

Great. I vote squash merge, as it's works well for xarray, and I've never seen an example where I would have preferred to keep that history. I'll disable the others now.

thanks, @TomNicholas


Tower block game

Describe the Feature you want to end

i want to add this tower block game
Expected behavior

Screenshots (optional)

https://github.com/pranjay-poddar/Dev-Geeks/assets/120590200/a1aa6e76-1bfc-430b-a274-0bed5f3a07f7
Additional context (optional )

@MohitGupta121  @TusharKesarwani  please assign this to me

@MohitGupta121  @TusharKesarwani  please assign this to me


Add service.name attribute automatically when logsEngine=otel and autodetect.istio=true

Is your feature request related to a problem? Please describe.
We need the service.name attribute to be created automatically for istio logs when setting logsEngine: otel and autodetect.istio=true. This is a known limitation per the advanced configs docs and prevents an easy path to deploying the collector without fluentd while also having istio correlation between cloud and o11y.
Describe the solution you'd like
I'd like to see this functionality added so that we do not have to choose between otel scalability and istio correlation.
Describe alternatives you've considered
I will try to manipulate the pipeline manually to add that attribute
Additional context
No response

Resolved by https://github.com/signalfx/splunk-otel-collector-chart/pull/825


Support for Snapshot Serengeti and Chicago WW type interface

@camallen @aliburchard @chrislintott I've heard that a classifying interface like that used in Snapshot Serengeti and Chicago Wildlife Watch is in the works for Panoptes. What's the timeline look like that for that? I ask because I just got a query from someone who has camera trap images and wants to talk to me about how to do something like Snapshot Serengeti. I know Panoptes is expected to go public in May; will this include an animal-classifying interface? Or is that further down the line? (If so, how far?)

Isn't it just a multiple-choice question with a bunch of possible answers?

Best guess (if you want to do more than just a decision tree), late summer.
Chris

On 14 Apr 2015, at 16:39, Edward Paget<EMAIL_ADDRESS>wrote:
Isn't it just a multiple-choice question with a bunch of possible answers?
—
Reply to this email directly or view it on GitHub https://github.com/zooniverse/Panoptes/issues/742#issuecomment-92915880.

@chrislintott Thanks!


Make tracer spline errors more verbose

This catches the case where the tracer redshift support is wider than the interal background spline. This is mostly useful to prevent opaque error in calculator mode. A similar check should probably be made for the power spectrum as well.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
24 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 97.03%

Files with Coverage Reduction
New Missed Lines
%

pyccl/tracers.py
24
89.8%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4410

Relevant Lines:
4545

💛  - Coveralls

Also, could we add a unit test that makes this fail?

Added a unit test. _get_spline1d_array just copies the memory of the C-level spline data, so should be negligible in terms of computational effort. On the other hand it shouldn't be necessary. Maybe I'll add a a_min and a_max to the cosmo.data C-struct for bookkeeping.

Thanks a lot!
I'm happy to approve this without the C-level logging of amin/max as soon as the final tests pass.


Thv/degree lowering hardening

Add tests that degree lowering and code generator for constraint evaluation is deterministic and does not change unintentionally.

Something funky is happening with the test table::master_table::tests::air_constraints_evaluators_have_not_changed which I can't explain. CI is failing with
expected:<PHONE_NUMBER>5351585926·x² +<PHONE_NUMBER>8545093804·x +<PHONE_NUMBER>6905394900)
observed:<PHONE_NUMBER>5170095309·x² +<PHONE_NUMBER>8076455036·x +<PHONE_NUMBER>3754412580)

whereas on my desktop computer I get
expected:<PHONE_NUMBER>5351585926·x² +<PHONE_NUMBER>8545093804·x +<PHONE_NUMBER>6905394900)
observed:<PHONE_NUMBER>8739234229·x² +<PHONE_NUMBER>9868624302·x +<PHONE_NUMBER>9229477187)

and both are obviously different from my laptop which produced the expected value. Any ideas as to what might cause this?

On my desktop at home, I get:
expected:<PHONE_NUMBER>5351585926·x² +<PHONE_NUMBER>8545093804·x +<PHONE_NUMBER>6905394900)
observed:<PHONE_NUMBER>5170095309·x² +<PHONE_NUMBER>8076455036·x +<PHONE_NUMBER>3754412580)

Would it make sense to also add a proptest like node_substitution_is_complete_and_sound for a DualRowIndicator type?

Correction: on my laptop I get this failure:
expected:<PHONE_NUMBER>5351585926·x² +<PHONE_NUMBER>8545093804·x +<PHONE_NUMBER>6905394900)
observed:<PHONE_NUMBER>5170095309·x² +<PHONE_NUMBER>8076455036·x +<PHONE_NUMBER>3754412580)

which agrees with CI and @Sword-Smith's machine.
Mysteries:

why did my desktop produce a different result?
why did my laptop produce a different result in the past?

For the record, applying just the first commit (9e5db866063a6527366be62616611d74db1ef416) of setting opt-level=3 generates this failure:
expected:<PHONE_NUMBER>5351585926·x² +<PHONE_NUMBER>8545093804·x +<PHONE_NUMBER>6905394900)
observed:<PHONE_NUMBER>8739234229·x² +<PHONE_NUMBER>9868624302·x +<PHONE_NUMBER>9229477187)

which agrees with the failure before setting the opt-level. So this compiler optimization does not seem to change anything.

@jan-ferdinand: All checks pass. Any further requested changes?

BTW: I can confirm that all tests pass on my desktop machine as well.

All comments are resolved now (I think).

All comments are resolved now (I think).

I'm still wondering about the following points:

Can the code in the various num_ functions be de-duplicated? (review comment)
Is there a copy-paste error in the docstring for num_nodes? (review comment)
Is the method how the various num_ things are computed relevant? (review comment)
Can the hidden relationship between node types in the multicircuit strategy be removed by changing which node types are supplied? (review comment)

I think I've answered all your questions. Any further remarks / requests?

No further requests. Happy to have this test in. :+1:


scope() function to support multi-scope modules

Is your feature request related to a problem? Please describe.
Some resources support multiple scopes, like Cost Management budgets and scheduled actions. The modules for these features are identical, except for any specific handling around the scope. In some cases, we need specific logic based on the scope ID, but this requires different logic for each scope:
// For subscriptions...
var scopeId = subscription().id
// For resource groups...
var scopeId = resourceGroup().id
// For management groups...
var scopeId = managementGroup().id

Since these functions all work differently for each scope, it's not possible to reuse the same code for each scoped module.
Describe the solution you'd like
Create a scope() function that is an alias for the scope the deployment is run for.

Also related to #4698


CI Lint/Test/Test262 workflow

This is a different approach to:
https://github.com/Agoric/SES-beta/pull/15
It resolves this issues:

Use Lerna to avoid the need to order the manually workspaces at the top level.
Use Lerna to also use the same tool as the developer would use.
Remove the no-bail option.
Provide individual job results in the PR checks (lint, test, test262)
Reduce the verbosity of test output (different reporter)
Simplify test dependencies in compartment-shim

I've made everything fail fast, so it's always the last line of a job. Example:
https://github.com/Agoric/SES-beta/runs/458829297?check_suite_focus=true


Detect the difference between never-asked-for-the-permission to previously asked-and-denied

Question
Hi, it used to be that if a permission hasn’t been requested in the past, and it’s now being checked for, the result would be 'undetermined'. I upgraded now to v2, and it seems it was unified with 'denied'
How can I tell the difference between these two different states, when asked/check for the first time? not sure about Android, but at least on iOS, the old way matched the iOS way (being able to tell between these two)

Sorry, my bad. Missed the 'blocked'

@oferRounds did you get things working by using 'blocked' as a proxy for 'undetermined'? I'm having trouble deciphering the iOS flowchart on the README. it seems we'll bet 'blocked' if:
Checking permissions:

the permission is 'not requestable'

Requesting permissions:

the request was denied (seems like this case should instead be 'denied')

I just want to check if the system prompt has been shown or not. I know the info is accessible natively but it seems convoluted here.


Fix incorrect application of factors in raster.resample

Hi Brian,
I discovered, that the re-sampling factor was incorrectly applied to new affine transformation in Raster.resample(). See extended test.
Once discovered it was an easy fix.
I discovered another issue (and created a simple patch). The condition in raster.py:53 generated invalid geometries for type Multipolygon if they only contained a single feature.
I did not create test for this one yet.
Thanks for the good work,
Falk

Hey Falk, thanks for taking the time to track this problem down. Can you go ahead and file a separate pull request for the MultiPolygon->NDArray issue? FYI, your current patch does not work since GetGeometryName() should be a method call, not attribute access.
After dropping that commit, this looks good to me. Let's streamline this test case a little though. It would be good to remove the magic number 2 in favor of a variable and we can utilize the affine object in a single assert, like:
self.assertEqual(output.affine.scale,
                           tuple(x * factor for x in self.ds.affine.scale))


Rat pet

Adds rat as a pet type.
Rats roam around and jump when hovered over.
They can chase a ball, but don't climb on walls.
There are three rat colors

gray
white with red eyes
brown (mixed brown head and white body)

Related to issue #28

@tonybaloney maybe you missed the notification about this pull request changing status from draft, so I added a mention.

Thanks. I'm on holiday for a few weeks. I'll take a look when I'm back

Codecov Report

Merging #332 (e41ed2f) into master (24a589b) will increase coverage by 0.27%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   16.91%   17.19%   +0.27%
==========================================
  Files          20       21       +1
  Lines        1129     1140      +11
  Branches      152      152
==========================================
+ Hits          191      196       +5
- Misses        929      935       +6
  Partials        9        9

Impacted Files
Coverage Δ

src/common/types.ts
71.42% <ø> (ø)

src/panel/pets.ts
20.58% <33.33%> (+0.38%)
:arrow_up:

src/panel/pets/rat.ts
50.00% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I fixed an error in the merged package.json that caused the pipelines to fail,

Love it. 👍🏻


EFCore generate wrong sql when using UseRowNumberForPaging under concurrency requests

The SQL EFCore generated is as below.
exec sp_executesql N'SELECT [t0].[AutoID], [t0].[CreateTime], [t0].[HrefType], [t0].[HrefUrl], [t0].[IdentityID], [t0].[ImgUrl], [t0].[IsDel], [t0].[AutoID], [t0].[MenuType], [t0].[MerchID], [t0].[ModifyTime], [t0].[OrderAsc], [t0].[SchoolID], [t0].[Title], [t0].[CreateTime], [t0].[HrefType], [t0].[HrefUrl], [t0].[IdentityID], [t0].[ImgUrl], [t0].[IsDel], [t0].[MenuType], [t0].[MerchID], [t0].[ModifyTime], [t0].[OrderAsc], [t0].[SchoolID], [t0].[Title]
FROM (
    SELECT [t].[AutoID], [t].[CreateTime], [t].[HrefType], [t].[HrefUrl], [t].[IdentityID], [t].[ImgUrl], [t].[IsDel], [t].[MenuType], [t].[MerchID], [t].[ModifyTime], [t].[OrderAsc], [t].[SchoolID], [t].[Title], ROW_NUMBER() OVER(ORDER BY [t].[OrderAsc]) AS [__RowNumber__]
    FROM [T_Menu] AS [t]
    WHERE (([t].[IsDel] = 0) AND ([t].[SchoolID] = @__schoolid_0)) AND ([t].[MenuType] = @__req_TypeID_1)
) AS [t0]
(
    SELECT [t].[AutoID], [t].[CreateTime], [t].[HrefType], [t].[HrefUrl], [t].[IdentityID], [t].[ImgUrl], [t].[IsDel], [t].[MenuType], [t].[MerchID], [t].[ModifyTime], [t].[OrderAsc], [t].[SchoolID], [t].[Title], ROW_NUMBER() OVER(ORDER BY [t].[OrderAsc]) AS [__RowNumber__]
    FROM [T_Menu] AS [t]
    WHERE (([t].[IsDel] = 0) AND ([t].[SchoolID] = @__schoolid_0)) AND ([t].[MenuType] = @__req_TypeID_1)
) AS [t0]
WHERE (([t0].[__RowNumber__] > @__p_2) AND ([t0].[__RowNumber__] <= (@__p_2 + @__p_3))) AND ([t0].[__RowNumber__] <= (@__p_2 + @__p_3))',N'@__schoolid_0 uniqueidentifier,@__req_TypeID_1 int,@__p_2 int,@__p_3 int',@__schoolid_0='545E4B15-8427-41F8-95BD-421A9B1F2FCA',@__req_TypeID_1=1,@__p_2=0,@__p_3=20

In concurrency case, the issue can be reproduced with high change. The sql EFCore generated are different for same query and many of them are wrong.
Steps to reproduce
Create dbContext with codes below.
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
 {
            if (!optionsBuilder.IsConfigured)
            {
                optionsBuilder.UseSqlServer("Server=.;Database=mydatabase;user id=sa;password=123456;", options => options.UseRowNumberForPaging());
            }
 }

Start two threads and generate new DbContext and call query in each thread. The query is as below.
dbContext.Set<TMenu>().Where(t => t.SchoolId == Guid.Parse("545E4B15-8427-41F8-95BD-421A9B1F2FCA") && t.MenuType == typeId) .OrderBy(t => t.OrderAsc).Skip(0).Take(20);

Further technical details
EF Core version: (2.1.1) (The issue can be reproduced under 2.1.4)
Database Provider: (e.g. Microsoft.EntityFrameworkCore.SqlServer)
Operating system: Windows 10 Pro
IDE: (e.g. Visual Studio 2017 15.7.4)

@hbwang518 Could you please comment on issue #13959 and let us know why you are using RowNumberForPaging?

I believe I may be running into the same problem - in certain high volume cases we start getting errors like:
The multi-part identifier "t.__RowNumber__" could not be bound. The multi-part identifier "t.__RowNumber__" could not be bound.
They only get cleared by recycling the entire site.
SQL 2008 R2
EF Core version: 2.2.3

Do you have any news on this issue? I got the same error when testing my application with the UseRowNumberForPaging flag set to true. I need to use that flag because one of the installations of my application needs to target Sql Server 2008, and the OFFSET and FETCH keywords that EFCore otherwise generates are obviously not compatible with that version...

I just discovered this issue after updating my apps to 2.2.3.
Any fix available?

@mailivore This issue is in the Backlog milestone. This means that it is not going to happen for the 3.0 release. We will re-assess the backlog following the 3.0 release and consider this item at that time. However, keep in mind that there are many other high priority features with which it will be competing for resources.
Also, I'm curious if you're planning to continue using SQL Server 2008 after it is out of support next month?

@ajcvickers Sorry for jumping in, but as I said last month I have the same issue and I'm following the discussion.

Also, I'm curious if you're planning to continue using SQL Server 2008 after it is out of support next month?

In my case that's not in my hands, my application will be deployed at my client's premise. They have plans to migrate to a newer version of SQL Server but it won't happen before this fall in the best case (and I'm pretty sure it will take much more time), and in the meantime they are not able to use my application because of this bug...

Not in my hands also.
A migration will certainly occur but not before many months.
I wrote some ugly raw SQL to get rid of the Skip() and Take() functions.
I'll take a look later after SQL Server migration to change it back to a more readable form.

@aiscrim @mailivore Thanks for the info.

@ajcvickers
RowNumberPagingExpressionVisitor in SqlServerQuerySqlGenerator's constructor leads to races in SelectExpression: if you have 2+ same "skip/take" queries executing in parallel at the same time, RowNumberPagingExpressionVisitor modifies the same SelectExpression object in 2+ threads which leads to an exception or invalid sql generated.
I do not know reasons why RowNumberPagingExpressionVisitor was put in SqlServerQuerySqlGenerator but probably it would be better to move it to the query compilation stage as everything (except parameters?) related to queries should be immutable at the sql generation stage.
As for now there is a simple fix for the issue: using a clone of SelectExpression to pass into a sql generator
https://github.com/aspnet/EntityFrameworkCore/commit/3319ccabd93f7b8763f30bcb207d37faf24fced2
also RowNumberPagingExpressionVisitor in SqlServerQuerySqlGenerator leads to races in RelationalQueryCompilationContext (generation of unique table names) as it is unsafe to access SelectExpression's _queryCompilationContext field outside of the query compiler:
https://github.com/aspnet/EntityFrameworkCore/blob/260b7f4fe0e8de07339448b4a2d2e5a10b577946/src/EFCore.Relational/Query/Expressions/SelectExpression.cs#L41-L42

@andreichuk If you have root-caused the issue, then would you consider submitting a pull request for the fix?

@ajcvickers  any chance to have a new version with the fix released before 3.0? I have tested my code with 2.2.5 version only

@andreichuk This isn't currently planned for 3.0, but if we get a PR that fixes the issue then that could still make it in.

This functionality hasn't been ported to 3.0 yet.
Cloning SelectExpression is not correct fix.
In 3.0 we are going to move this processing to compilation phase in ShapedQueryOptimizingExpressionVisitor.

@OpenSpacesAndPlaces
After 4 months, I encountered the same problem as you. In version 2.2.6, did you find a solution to this problem, except restart the site?

@EzrealJ
If the problem occurs, restarting is the only fix.|
The only real mitigation, while keeping the same code in play, would be to prevent duplicate simultaneous requests by custom memory caching or something along those lines.
IMO, probably the best fix if you don't have a heavy dependency on dynamics would be just to use like: raw SQL, Store Procedures, or DB Functions.
For small datasets, paging in in-memory after generating the full data might be an option.
TLDR:  You're looking for a work-around that best fits your use-case.
Hope this helps!

@OpenSpacesAndPlaces
I m very sorry that there is no way to solve it, but I am very grateful to you for taking the time to answer my questions.

Why isn't the method UseRowNumberForPaging() at least marked as obsolete with an error? It still exists and just doesn't do anything. I spent a bunch of time updating a project only to find out at runtime that I can't actually update after all. If i saw immediately that this method is no longer supported it would have saved me some time.

Closing old issue as this is no longer something we intend to implement.


HDDS-3725. Ozone sh volume client support quota option.

What changes were proposed in this pull request?
Currently, Ozone's support for Quota is incomplete, and currently only supports setting volume capacity Quota by command. The Quota setting based on quantity is not yet supported. The purpose of this PR is to support this.
In addition, the current Quota setting does not take effect. HDDS-541 gives all the work needed to perfect Quota.
This PR is a subtask of HDDS-541. Design documentation for Ozone Quota:
https://docs.google.com/document/d/1ohbGn5N7FN6OD15xMShHH2SrtZRYx0-zUf9vjatn_OM/edit
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3725
How was this patch tested?
Added UT.

Codecov Report

Merging #1233 into master will increase coverage by 0.03%.
The diff coverage is 68.25%.

@@             Coverage Diff              @@
##             master    #1233      +/-   ##
============================================
+ Coverage     73.60%   73.64%   +0.03%
- Complexity    10070    10083      +13
============================================
  Files           978      974       -4
  Lines         49924    50010      +86
  Branches       4853     4862       +9
============================================
+ Hits          36749    36832      +83
- Misses        10847    10853       +6
+ Partials       2328     2325       -3

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/org/apache/hadoop/hdds/StringUtils.java
76.31% <0.00%> (-2.07%)
10.00 <0.00> (ø)

...main/java/org/apache/hadoop/ozone/OzoneConsts.java
81.81% <0.00%> (-3.90%)
1.00 <0.00> (ø)

...hadoop/ozone/om/protocol/OzoneManagerProtocol.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../java/org/apache/hadoop/ozone/om/OzoneManager.java
67.72% <0.00%> (-0.05%)
202.00 <0.00> (ø)

.../org/apache/hadoop/ozone/om/VolumeManagerImpl.java
13.52% <0.00%> (-0.05%)
7.00 <0.00> (ø)

...java/org/apache/hadoop/hdds/client/OzoneQuota.java
53.01% <46.80%> (+13.32%)
10.00 <10.00> (+2.00)

...hadoop/ozone/shell/volume/UpdateVolumeHandler.java
70.00% <80.00%> (+11.66%)
2.00 <0.00> (ø)

.../org/apache/hadoop/ozone/client/rpc/RpcClient.java
86.35% <86.66%> (-0.20%)
78.00 <1.00> (ø)

...va/org/apache/hadoop/ozone/client/OzoneVolume.java
84.44% <93.75%> (+0.91%)
21.00 <8.00> (+1.00)

...ava/org/apache/hadoop/ozone/client/VolumeArgs.java
100.00% <100.00%> (ø)
8.00 <2.00> (+1.00)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402a427...a2c5317. Read the comment docs.

Thanks @cxorm for your review. I have fixed all the problems mentioned above. The command line display has also changed(As shows below).  Could you please take another look？

Thanks @captainzmc for the work.
Overall the functionalily-part is good and some suggestions is added inline, test-related-part would be reviewd soon.
Here I have two Questions IMHO.
(1) Could we let the variable-pair be consistent ?
I think it would better to use one of (storagespaceQuota/ namespaceQuota) and (quotaInBytes/ quotaInCounts).
If it have other purpose to use both, please let me know.
(2) Would we add limitation of creating volume and bucket in later patch ?
I deployed this patch on my machine, and created volume without setting both of quota.
I found that the storage of volume exceeds my local-storage.
And I found we could create bucket even if the quota of bucket is -1.

Sorry for my careless huge "Add single comment" yesterday.
There are Test-related-part and API-backward-compatibility-part to be reviewed. (If anyone continue reviewing after this comment.)

Thanks @captainzmc for the work.
Overall the functionality-part is good and some suggestions is added inline, test-related-part would be reviewed soon.
Here I have two Questions IMHO.
(1) Could we let the variable-pair be consistent ?
I think it would better to use one of (storagespaceQuota/ namespaceQuota) and (quotaInBytes/ quotaInCounts).
If it have other purpose to use both, please let me know.
(2) Would we add limitation of creating volume and bucket in later patch ?
I deployed this patch on my machine, and created volume without setting both of quota.
I found that the storage of volume exceeds my local-storage.
And I found we could create bucket even if the quota of bucket is -1.

Thanks for @cxorm 's feedback.

I will revise the unified naming and other review issues as soon as possible.
Currently, quota can only be set, but does not take effect. This task lists plans and designs. I will continue to improve this part in the future.

Thanks for @cxorm 's review. I had revised the review issues. Could you take another look？

Update PR, like HDDS-3991, Ignore protobuf lock files.
Hi @cxorm. Previous issues has been solved. Could you help take another look？

hi @xiaoyuyao @arp7 This is the subtask of HDDS-541 Ozone Quota Support. Could you help review it？

Update PR, like HDDS-3991, Ignore protobuf lock files.
Hi @cxorm. Previous issues has been solved. Could you help take another look？

Sorry for late reply, I would take another look.

Thanks @captainzmc for working on this patch.
This review is about test.
Some suggestions are added inline.

Thanks for @cxorm’s  review. Fixed review issues.

Thanks @captainzmc for working on this.
This review is mainly about API, and related suggestions are added inline.
Also, there is discussion on naming parameter of CLI in design-doc.

Hi yisheng, I have replied in design-Doc. We've talked about this before. Finally, we refer to the parameter of HDFS quota so as to maximize retention of user habits.

Had fixed issues as HDDS-4129 suggested. CC @ChenSammi.

Thank you @captainzmc for updating the PR.
Could you rebase it with latest master branch ?
This PR looks good to me, +1 (cc @ChenSammi )

Thanks for @ChenSammi 's review, the issues has been fixed.

LGTM +1.
Thanks @captainzmc for the contribution and @cxorm for review the patch.


Recent refactor

Hi Alex
As discussed previously here are the project restructuring commits.

Merged, thanks @mike-williams.


Adding the latest sdk version.

This Pull Request:

Updates the sdk version such that we have the latest UpdateTypes as part of the ingest image.

Nice one!
Does this not need updating too?

Ahh yes and an integation test fix it looks like 👎


Validate that undefined opcodes don't disassemble

This should be easy to do in the disassembly test.

All done, easy peasy.


Add Deployment step missing in docs

Novice question: Spend half an hour stuck with this error:
Error: Command 'codepush release -a xxx/YYY -c ./platforms/android/app/src/main/assets/www --description "Fix translates" -t v1.2.0-a' failed with exception "Error "Unexpected token D in JSON at position 0" occurred in deserializing the responseBody - "Deployment "Staging" does not exist." for the default response."

Error: Command 'codepush release -a xxx/YYY -c ./platforms/android/app/src/main/assets/www --description "Fix translates" -t v1.2.0-a -d Store' failed with exception "Error "Unexpected token D in JSON at position 0" occurred in deserializing the responseBody - "Deployment "Store" does not exist." for the default response."

First intent was a confusion as I thought it had to do with app "Release Type" in appcenter settings (really confusing...)
At the end I discovered that I had to add the deployment manually:
appcenter codepush deployment add Staging

Additionally, at this moment I still don't understand what is "Release Type". Found some documentation on docs but it only describes the different types, not what it is used for...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2c2bd47-97e3-abc8-fbdd-305f0c631827
Version Independent ID: 318718e7-a38a-7cc5-01a4-7ce0153c4398
Content: Releasing CodePush updates using the App Center CLI - Visual Studio App Center
Content Source: docs/distribution/codepush/cli.md
Service: vs-appcenter
Sub-service: app-center-distribute
GitHub Login: @Zakeelm
Microsoft Alias: zakeelm

When you go to the appcenter.ms  dashboard.
Distribute -> CodePush -> Get started and create Default Deployments


Unexpected error

when I input username and password,  login,  shown :Unexpected error.
pls help me,  the username and pw is correct.

+1 same issue, seems that Garmin now requires an email-based code in addition to username and password.

In the readme, it states that 2 factor authentication isn't yet supported, so if you've enabled it, you won't be able to use this integration. Unfortunately, there's no way to revert once you've enabled 2 factor authentication. The integration works fine if you haven't enabled 2fa.

Thanks, perhaps we can change the subject of this into a feature request for 2 factor auth for those of us that enabled it? It does send the 2 factor email upon registration in HA so the code is delivered.

Will try to add this feature, needs a bit of a rewrite though

https://github.com/cyberjunky/home-assistant-garmin_connect/issues/117

Closed because added to parent ticket https://github.com/cyberjunky/home-assistant-garmin_connect/issues/117


Losing internet connection causes the bot to loop through the autoplaylist

Please make sure these boxes are checked (put an 'x' inside them) before creating the issue.

[ x ] I am using Python 3.5 or higher (run python --version on the command line)
[ x ] I have followed the official guides to install the bot for my system
[ x ] I have updated my dependencies to the latest version using the appropriate update_dependencies script
[ x ] I am running version 1.9.6_1 of MusicBot

Description of issue
Losing internet connection causes the bot to loop through the autoplaylist after reconnecting but not playing any songs. Also when there is no connection the bot seems to remove the songs that couldn't be downloaded from the autoplaylist which isn't ideal.
Aditional information

I am running the bot on a Raspberry Pi 3

Steps to reproduce

Start bot
Disable internet connection

Log file
musicbot.log

An option has been added to turn off the removing from autoplaylist behaviour in https://github.com/Just-Some-Bots/MusicBot/commit/3910cc6d601a97bbc6d6dd8284aabf478bfc0afa.

Closing because Option was added to stop this.


Maximize issue on WSLg

Version
Microsoft Windows [Version 10.0.22000.527]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Debian 9.13
Other Software
CLion 2021.3.2
Repro Steps
Not sure exactly, but I start CLion, maximize and demaximize through the day, then I left it open for a while and tried to maximize once more.
Also, this is not the first time this has happened, but I'm not sure what happened the other times.
Expected Behavior
View pane would be normal.
Actual Behavior
Cant see the right border of the window, see attached:

Diagnostic Logs
No response

Mentioned in #214

Had this happen with firefox today. I had just opened WSL, and this was the first time pressing maximize:

This looks like #619


Add Support for Do Not Disturb

Add "Enable Do Not Disturb during Pomodoro" option under Notifications
Enables toggling the Do Not Disturb option in Notification Center.
Enables DND when Pomodoro timer starts
Disables DND when Pomodoro timer completes

This implementation should satisfy #45, but I would appreciate feedback.
CC @mtavkhelidze @ccidral @dvntucker @dzindra

Looks! The only thing is that UI window lookes a bit skewed.

Looking forward for this feature

Looking forward for this feature

I would love to see this merged. Is @dvntucker or another maintainer still around to accept it?

Please, Squash-Merge it.

Sorry guys I'll try to find some time to merge this PR this week but I can't promise anything.

I can try to bring it up to date if needed. I'd love to have this in officially

@kevinold Thanks so much, that would be wonderful. I'll do my best to commit to a date to review and merge your PR. I'd say Feb 21st 🤞🏻

Guys, could I help with getting this released?

It's been forever since I last played with native MacOS apps, so it would probably take forever for me to setup everything and test this PR. If anyone can verify that this PR is building and working properly, I'll take your word for it and merge it.


Please invite me to the community

Name
David Kim
Discord Username (if applicable)
David Kim#6905
Additional Context
Hi guys! My name is David Kim, and I live in Las Vegas right now. I was originally worked in Finance/Accounting industry. But my investment in Cryptocurrency was a huge turning point in my life that led me to change my career to the tech industry as a coder, and I love it! I was a Front-end developer in my previous experience, but I can also code in the back-end. And I am learning solidity and doing a couple of solidity tutorials as well : ) I am super excited to join this community!

Welcome here @hyomiTheTech 🎉


Auth SPA example

This example adds a new example to show how to get a CARTO OAuth Token in a SPA.
It's a very common use case that unblocks many of our users and it was not documented in any place. This example opens the door to integrating CARTO into other applications/frameworks that our customers are using.

LGTM @alasarr. The only thing I'm not sure about is the place to put this new example.
Should we have a /examples folder, to host this under it instead of root level (/examples/auth-spa)?. We do have for other categories, like deck.gl or gmaps...

LGTM @alasarr. The only thing I'm not sure about is the place to put this new example.

We're doing a revamp of developer docs. I'm working with @ernesmb @srtena and @moimart on this. You will love it :). I will share as soon as we have a draft.


Beautify the settings page

Beautify the settings page.
Use jsdelivr CDN to load jQuery and jquery-observe.

Thanks for your PR. I've added the source code for the settings page to my repository. I think it would be better if you included the css directly to that page.

I think so.I couldn’t find the source code of the setting page before, so I put it in this script.


Importing apt29.ps1

I am experiencing this error when I try importing apt29.ps1. What do I do? I've already set the execution policy to bypass

Any help?

try setting your execution policy to unrestricted

I set it to unrestricted and have been debugging it for a while now. Antivirus detected the below and I've allowed it, but still haven't been successful in running the script

@DillonSingh,
I had a same issue - problem is that you downloaded file with htmp tags which is not needed.
Please create new .ps1 file and take code from here:
https://raw.githubusercontent.com/carbonblack/tau-tools/master/threat_emulation/Invoke-APT29/apt29.ps1
And use that file during the test.
Hope this will help you as it helped to me. :)


Replace requirejs with webpack to enable ES6+ and non-AMD modules

Build with Webpack instead of requirejs, allowing us to mix AMD with more other/standard module formats (💥  🏅  @oshoham !)
add babelify so that we can use ES6+
add @for <className> to satisfy the YUIDoc build step in p5.js repo (cc @Spongman, thought you might have insight on this in case there is anything we're missing https://github.com/processing/p5.js-sound/commit/be9410a54fa5119ede1579e3a2337ab943090d15 )

TO DO (perhaps in a separate PR):

[ ] make we are following best practices for authoring libraries with Webpack https://webpack.js.org/guides/author-libraries

Some relevant issues:
https://github.com/processing/p5.js-sound/issues/228#issuecomment-373515799
#348
#345


Adding @jonparrott's sphinx-docstring-typing module.

This allows usage of Python 3.5+ typing module, which is very helpful.
Note that the changes to source docstrings are likely bugs in sphinx-docstring-typing, so that may be addressed on that project.
@jonparrott This is marked "don't merge" right now because I want to check with you what the issues actually are with the source docstrings.

https://github.com/jonparrott/sphinx-docstring-typing/blob/master/tests/test_sphinx_docstring_typing.py
On Thu, Jun 22, 2017 at 8:58 AM Danny Hermes<EMAIL_ADDRESS>wrote:

@dhermes commented on this pull request.
In vision/google/cloud/proto/vision/v1/text_annotation_pb2.py
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3518#discussion_r123551571
:

@@ -558,13 +558,14 @@
DESCRIPTOR = _TEXTANNOTATION,
module = 'google.cloud.proto.vision.v1.text_annotation_pb2'
,

doc = """TextAnnotation contains a structured representation of OCR extracted
text. The hierarchy of an OCR extracted text structure is like this:
TextAnnotation -> Page -> Block -> Paragraph -> Word -> Symbol Each

doc = """TextAnnotation contains a structured representation of OCR extracted text.

I would be, could you point me to the unit test module / file that needs
updating?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3518#discussion_r123551571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc76AfvOvGXlN67EX7kAs99m4_MJwks5sGo8tgaJpZM4OBxyA
.

Just sent https://github.com/jonparrott/sphinx-docstring-typing/pull/5

Friendly poke. I would like to either move the needle on this or close it.

I would also like to move the needle on it.
In the current form sphinx-docstring-typing probably isn't suitable for our use. It uses no semantic meaning of docstring text when doing replacements, so it can make things like TextFooBar turn into very broken Sphinx reST because of the presence of Text

sphinx-docstring-typing probably needs some form of real parser instead of using clever regexes.

Okay. Dropping this for now.


Rule to catch "undesirable" implicit cast(?) in -contains, -icontains, -ccontains

Summary of the new feature
The construction ($true, 'foo') -contains 'bar' returns $true.  I think this is because 'bar' is being implicitly converted to a Boolean when being compared to $true; and [Boolean]'bar' is $true and, while I get why it's happening (now I've examined it), it feels (to me) like it might be suitably surprising to others, at first glance.  A rule to capture this undesirable conversion might therefore be useful.
I'm not sure if there are any other implict conversions which would be undesirable, or if it would apply other operators, but this one certainly bit me today.
Proposed technical implementation details (optional)
Examples of this "undesirable" conversion (so should trigger the warning) are:

($true, 'foo') -contains 'bar' → $true
($true, 2) -contains 1 → $true
($false, 2) -contains 0 → $true
('foo', (1 -eq 1)) -contains 'bar' → $true (esoteric, but still possibly surprising)

Examples of maybe-"desirable" conversions (so should not trigger the warning) might be:

('1', 2, 3) -contains 1 → $true
(1, 2, 3) -contains '1' → $true
([DateTime]::Today, 2, 3) -contains '2022-02-18T00:00:00.000' → $true

It may be only be the comparison to a boolean value that is the fundamental issue here.  Perhaps it applies to any equality-based operator with an explicit boolean value as either operand, (e.g. maybe if ($foo -eq $true) should trigger; where if ($foo) would not).  I doubt it should (nor reasonably could) fire for comparisons with variables set to $true.  Ift would be nice if it could catch the esoteric cases, but not at the expense of rule complexity.
Perhaps comparison of boolean to literal value is a valid summary/codifier.
I have no familiarity with PSScriptAnalyzer rules, so I can't tell if this is something that is straightforward or not, or if implementing would be too far-reaching.  It just feels like too big a gotcha not to have something try and call it out.
What is the latest version of PSScriptAnalyzer at the point of writing
PS> Get-Command -Noun ScriptAnalyzer*

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Get-ScriptAnalyzerRule                             1.20.0     PSScriptAnalyzer
Cmdlet          Invoke-ScriptAnalyzer                              1.20.0     PSScriptAnalyzer

(...as installed by VSCode Powershell extension)

Thanks for the detailed issue @jimbobmcgee! One work around for this is [string[]]($true, 'foo') -contains 'bar' -> False
The contents of the collection are a runtime thing, so PSScriptAnalyzer might not know if there is a bool or not in the collection until runtime. This makes creating a rule sorta complicated. It can only catch cases where $true is in the left hand side of -contains, since we won't have certainty for what is contained on the left side until runtime. For now we are going to mark this issue as answered as we don't really have a path towards implementation.


handlebars to JSX converter would be big right now.

Jade has a transpiler: https://github.com/jadejs/react-jade
The JSX debate needs to be put to rest by giving developers the option to use whatever templating option they want. I'm not sure what's the most popular, but I always thought it was Handlebars.
Is this in the works?

The htmlbars project's goal is to take the handlebars syntax and expose it
in a virtual dom. I believe development there is primarily driven by the
Ember teams, but it's entirely possible that that could be adapted to work
with React's virtual dom.
Handlebars proper won't support this though as we actively focus on being
unaware of what content we are generating and adding HTML semantics would
require large breaking changes for every helper, etc.
On Wed, Dec 2, 2015 at 3:59 PM James Gillmore<EMAIL_ADDRESS>wrote:

Jade has a transpiler: https://github.com/jadejs/react-jade
The JSX debate needs to be put to rest by giving developers the option to
use whatever templating option they want. I'm not sure what's the most
popular, but I always thought it was Handlebars.
Is this in the works?
—
Reply to this email directly or view it on GitHub
https://github.com/wycats/handlebars.js/issues/1142.

ic. what about an official addon/extension package that converts to JSX. I mean it just IS such a big opportunity that will be missed out because of semantics. Coming directly from handlebars would have a major impact than a bunch of shoddy community packages that will crop up (and already in the works, but struggling to become feature complete).

The complexity is the same in that you have to become aware of two languages, handlebars and html and this project actively avoids that. If you feel that there are community projects that are close to doing what you want to see but aren't there yet, why not spend some time getting them up to snuff? Community projects are a good thing, which is why we actively link to anyone who requests that we do so in our readme.

One major issue I have with handlebars is having no idea which variables are defined. With jsx/hyperscript, I don't have to wonder about this at all, once I understand how the html syntax transpiles over to javascript code.
Another major issue I have with handlebars is the sheer unique-ness of it's syntax. It's a whole new language. JSX, on the other hand, is simply an obvious mixing of some html syntax into javascript. I can't just do collection.map or array.filter - I have to lookup some unique syntax in the docs on emberjs.com. There's no standard either. The whole rest of the javascript ecosystem seems to have come to gather around jsx.

The JavaScript ecosystem has not gathered around JSX; the React community has.


Add custom field to Node Record

PR Description
Adds a custom field to Node Record object and API to update it through Discovery System.
Fixed Issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use new_syntax_error in main.rs

I missed these usages of syntax error when I created vm.new_syntax_error function in #829.

Codecov Report

Merging #837 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   63.18%   63.18%   -0.01%
==========================================
  Files          87       87
  Lines       14371    14368       -3
  Branches     3251     3251
==========================================
- Hits         9080     9078       -2
+ Misses       3158     3155       -3
- Partials     2133     2135       +2

Impacted Files
Coverage Δ

src/main.rs
20.53% <0%> (+0.53%)
:arrow_up:

vm/src/vm.rs
71.06% <0%> (-0.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78db5ea...2248635. Read the comment docs.


update devcontainer to .net 8

updates to .NET 8 based on the updated devcontainer/dotnet. As there is no tag 0-8.0, I switched to 1-8.0.

@microsoft-github-policy-service agree

@bamurtaugh would you be able to help approve as part of Community PR Approvals? Thanks!


Font weight is permanently bold after latest update just like in #214390

Same as reported a couple of months ago, in #214390 the font bold issue is back.

Please help fix this again. Super hard to work with this.
cc: @deepak1556

VS Code Version:
OS Version:
Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.5.0

/duplicate of #224496 which is currently pinned to the top of the Issues page.

Same issue, same font. Goes also back to months ago...


External URLs open as a blank tab in the Flatpak version

The Flatpak version of the TB Launcher is installed on the clean Ubuntu 22.10 and selected as default browser (verified with xdg-settings check default-web-browser). When trying to open some link from another application, it causes the browser to start, but the website itself does not open in it. Looks like something is preventing the URL to be passed to the browser. The problem does not affect Brave browser, also installed as a Flatpak in the same system.

i have the same issue


”Ciumești” is listed in the drop-down menu

Description:
"Ciumești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Ciumești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Ciumești, SATU MARE".


[Migration] Remove internal MacOS folders from imported ZIPs

As observed on several MacOS machines, ZIPs imported into the migration perspective contain an internal MacOS folder that in some projects results in a slowdown of the whole migration as its files are being processed. We should strip the MacOS folder in Dirigible's TransportRestService.

Closed in https://github.com/eclipse/dirigible/pull/1726


Fix convnet example

convnet example seems to be broken.
$ go build -o convnet ./examples/convnet/
# gorgonia.org/gorgonia/examples/convnet
examples/convnet/main.go:219:37: undefined: cost

https://github.com/gorgonia/gorgonia/blob/cb4f110a9c3a9bbc51339bf8042b039169160ed3/examples/convnet/main.go#L219-L220
So I fix this error. The source code at v0.9.0-beta is following:
https://github.com/gorgonia/gorgonia/blob/978b1c3c0f795d09d0710238cb5f82853b99a460/examples/convnet/main.go#L219-L220

Coverage remained the same at 63.973% when pulling 2c82856d6e7c260360b1f34467d8482218347531 on c-bata:fix-convnet-example into cb4f110a9c3a9bbc51339bf8042b039169160ed3 on gorgonia:master.

Thanks, LGTM.


pt_BR Translation

As i said on wp-cli/wp-cli#3065 there goes translation for Brazilian Portuguese for the home page.

💯 Thanks!


Example of destory

It would be great to have an example of how to use the os.destroy() functionality, it is not clear from your documentation.

It's pretty straight forward. In all snippets os is the OnScreen instance:
const os = new OnScreen();

os.on('.selector', () => {});
os.destroy();

I was referring to the following scenario:

You assign the on enter for a set of elements, ".selector"
When a specific element from the set has entered the viewport, perform the "doIt" function
Remove the "enter" event for the element from the specific element from the set, only for the element that has finished loading, not the entire ".selector"

The implementation of that scenario is up to the developer. I would suggest having some kind of flag that you check while running the "doIt" function…
const os = new OnScreen();

os.on('enter', '.selector', (element) => {
    if (!element.entered) {
        // Write whatever you want to do with the `element`

        // Set the flag so this code block won't run next time the `element` enters the viewport
        element.entered = true;
    }
});

In the above snippet element is an instance of DOMElement. I added a new property to the element object to track if it entered the viewport before. If you don't want to add properties to element you could add a new attribute instead:
os.on('enter', '.selector', (element) => {
    if (!element.getAttribute('entered')) {
        // Write whatever you want to do with the `element`

        // Set the flag so this code block won't run next time the `element` enters the viewport
        element.setAttribute('entered', true);
    }
});

In your scenario, .destroy() isn't needed at all. What .destroy() does is removing the event listener from the window (or HTMLElement if you're using a different container) object. Once you remove the event listener you can add again it using .attach().


HBASE-23582 Unbalanced braces in string representation of table descriptor

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 24s
master passed

+1 :green_heart:
compile
0m 27s
master passed

+1 :green_heart:
checkstyle
0m 34s
master passed

+1 :green_heart:
shadedjars
4m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

+0 :ok:
spotbugs
1m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  9s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 59s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 53s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 22s
the patch passed

+1 :green_heart:
findbugs
1m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

49m 49s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-943/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/943

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 99d265ccf3ed 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-943/out/precommit/personality/provided.sh

git revision
master / de87d72bb4

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-943/1/testReport/

Max. process+thread count
296 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-943/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Remove (potential) pirated contents from screencast

The screencast at 00:04 location contains files which looks like pirated contents.
Can we please remove it and replace with some other content?

Why do you care?


Add save-template in new submission page

Coverage remained the same at 34.02% when pulling 4bd8eaf723ab675f4592ee46d98e3346c28e8855 on mintao/new-save-template into 1f97a1914fed516f38eeaa857885ae21a71c6951 on master.