GDPR Requirements

Shopify recently added information about additional webhooks that are going to be required by all apps: https://help.shopify.com/api/guides/gdpr-resources
They are shop/redact& customers/redact and the urls for them will be set in the app info panel.
Should we include sensible defaults for these in the package?

+1
btw: https://help.shopify.com/api/app-store/listing-in-the-app-store/data-and-user-privacy/privacy-policy-template

On second thought, I suppose we should just leave it as it is. The laravel-shopify package doesn't seem to store any personally identifiable pieces of store data. I think the developer should handle this on their own. I don't see what this package should do to cater to this except maybe mentioning it in the installation process. Or, possibly at the very most, creating a simple placeholder job for the dev to fill out on their own.

Yeah there's so many conflicting things I'm reading. I think that's the
best action. I'll work on a solution for the week.
On Mon, May 28, 2018, 7:48 AM Nathan Pope<EMAIL_ADDRESS>wrote:

On second thought, I suppose we should just leave it as it is. The
laravel-shopify package doesn't seem to store any personally identifiable
pieces of store data. I think the developer should handle this on their
own. I don't see what this package should do to cater to this except maybe
mentioning it in the installation process. Or, possibly at the very most,
creating a simple placeholder job for the dev to fill out on their own.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-392505709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOhsYvxLLBVgxVHicrHfppEpgP4kjks5t2-P_gaJpZM4UJ9LN
.

Closing for now as it doesn't seem that any changes are required.

Thanks @ncpope, made a wiki entry for this instead here.

As per your wiki entry, we need to set the entry in the config/shopify-app.php file.
However, if we try to install the webhooks, we get this error from shopify :
Client error: `POST https://my-shop.myshopify.com/admin/webhooks.json`
resulted in a `422 Unprocessable Entity` response:
{"errors":{"topic":["Invalid topic specified. Topics allowed: app\/uninstalled,
collections\/create, collections\/delete (truncated...)

And as per the API reference https://help.shopify.com/api/reference/events/webhook you can only set shop/update hook.
shop/redact and costumer/redact should be set in the App info tab in your app on the Shopify Partners portal. (Source).

Oh that's how it works? It's a setting? Will check this sorry
On Thu, May 31, 2018, 4:37 PM Marc-Antoine Brodeur, <
<EMAIL_ADDRESS>wrote:

As per your wiki entry, we need to set the entry in the
config/shopify-app.php file.
However, if we try to install the webhooks, we get this error from shopify
:
Client error: POST https://my-shop.myshopify.com/admin/webhooks.json https://my-shop.myshopify.com/admin/webhooks.json
resulted in a 422 Unprocessable Entity response:
{"errors":{"topic":["Invalid topic specified. Topics allowed: app/uninstalled,
collections/create, collections/delete (truncated...)
And as per the API reference
https://help.shopify.com/api/reference/events/webhook you can only set
shop/update hook.
shop/redact and costumer/redact should be set in the App info tab in your
app on the Shopify Partners portal. (Source
https://help.shopify.com/api/guides/gdpr-resources#mandatory-webhooks).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-393671661,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOsiukUeA_3ACGMZVhmCKItx7mw1aks5t4FSegaJpZM4UJ9LN
.

Yes, we still need to be able to respond to the redact webhooks but we don't need to subscribe to them.  The way you have the webhook controller designed, we can follow the same naming convention as the other webhooks including creating the corresponding jobs but don't need to enter them in the webhooks config.

Makes sense.. let me try and adjust.
On Thu, May 31, 2018, 5:07 PM Brian Kidd<EMAIL_ADDRESS>wrote:

Yes, we still need to be able to respond to the redact webhooks but we
don't need to subscribe to them. The way you have the webhook controller
designed, we can follow the same naming convention as the other webhooks
including creating the corresponding jobs but don't need to enter them in
the webhooks config.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-393680651,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOge6Ho7qCy_H0KmMHL9tOSdDZc_Mks5t4FuIgaJpZM4UJ9LN
.

@brianakidd  Thank you; adjusted.

I have added  costumer/redact webhook in our   App info tab.Please check the shared screenshot link:https://www.screencast.com/t/c4wtuUUGW6nc
But i am unable to get the webhook response after that i have tried to create this webhook through postman   and get this error
https://www.screencast.com/t/iDz7yRpDB
https://www.screencast.com/t/iDz7yRpDB
please help me

@SignatureForum  I don't believe this is an issue with the package. Where does the URL go to that you have specified? The error you're getting is from Shopify iteself.

I have added costumer/redact webhook in our App info tab.Please check the shared screenshot link:https://www.screencast.com/t/c4wtuUUGW6nc
Here is the rout url
https://user-images.githubusercontent.com/3440763/43856894-351449fc-9b63-11e8-831e-f0372df7105c.png
https://user-images.githubusercontent.com/3440763/43856741-d594202e-9b62-11e8-93ae-96955207a9ca.png
But i am unable to get the webhook response after that i have tried to create this webhook through postman and get this error
https://www.screencast.com/t/iDz7yRpDB
https://www.screencast.com/t/iDz7yRpDB
please help me

@SignatureForum I am unsure. This is not an error from the package but Shopify itself. What URL are you running in postman

You don't need to put in the webhooks into admin settings if I remember.. I
think this fires by Shopify itself. I don't support GDPR internally for the
package, but if there's an issue with the doc which tries to have some
guidelines I can look at that for sure.
On Wed., Aug. 15, 2018, 12:54 p.m. Paul Canning<EMAIL_ADDRESS>wrote:

I'm still getting the 422 error mentioned by @mabrodeur
https://github.com/mabrodeur . How do I fix it?
I followed the wiki, adding both GDPR hooks and added them in the app
settings console and my shopify-app config file.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-413232723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOhlejnXWjvYg5DCl_aofPler-Ilnks5uRD0RgaJpZM4UJ9LN
.

Sorry to exapand on the above, you enter the url into your app settings
admin, not the Shopify admin. And Shopify should fire it.. but yes if
there's an error in what's laid out in the doc I can certainly adjust.
On Wed., Aug. 15, 2018, 1:16 p.m. Tyler King<EMAIL_ADDRESS>wrote:

You don't need to put in the webhooks into admin settings if I remember..
I think this fires by Shopify itself. I don't support GDPR internally for
the package, but if there's an issue with the doc which tries to have some
guidelines I can look at that for sure.
On Wed., Aug. 15, 2018, 12:54 p.m. Paul Canning<EMAIL_ADDRESS>wrote:

I'm still getting the 422 error mentioned by @mabrodeur
https://github.com/mabrodeur . How do I fix it?
I followed the wiki, adding both GDPR hooks and added them in the app
settings console and my shopify-app config file.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-413232723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOhlejnXWjvYg5DCl_aofPler-Ilnks5uRD0RgaJpZM4UJ9LN
.

Sorry to expand on the above, you enter the url into your app settings admin, not the Shopify admin.

The thing is, the hooks are required by Shopify, it states it right there in the app settings page

Required webhooks to manage requests to erase customer personal information.

Yes they're required but after some discussion and thoughts on this issue
when it first came up, I decided I did not want to internally support this.
There could be an array of things someone needs to delete from database
entries to files, depending on the app, I could provide a base job to
extend, but it ended up being something I didn't feel comfortable providing
support for.
On Wed., Aug. 15, 2018, 1:37 p.m. Paul Canning<EMAIL_ADDRESS>wrote:

Sorry to expand on the above, you enter the url into your app settings
admin, not the Shopify admin.
The thing is, the hooks are required by Shopify, it states it right there
in the app settings page
Required webhooks to manage requests to erase customer personal
information.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-413246215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOvr7BUU3qD97FjqWQF53Jbj6K0A5ks5uREdQgaJpZM4UJ9LN
.

I removed them in the App settings (oddly, whilst required, you can save the form without them) and I'm still getting the following error when trying to install the app:

Client error: POST https://my-shop.myshopify.com/admin/webhooks.json resulted in a 422 Unprocessable Entity response: {"errors":{"topic":["Invalid topic specified. Topics allowed: app/uninstalled, collections/create, collections/delete (truncated...)

Oddly, if i go back into the shop, the app has been installed, but has not gone through the billing process.

Did you setup a webhook in the config/shopify-app file? Seems like it found
a webhook, tried to push it to your shop but the topic was bad.
On Wed., Aug. 15, 2018, 2:01 p.m. Paul Canning<EMAIL_ADDRESS>wrote:

I removed them in the App settings (oddly, whilst required, you can save
the form without them) and I'm still getting the following error when
trying to install the app:
Client error: POST https://my-shop.myshopify.com/admin/webhooks.json
resulted in a 422 Unprocessable Entity response:
{"errors":{"topic":["Invalid topic specified. Topics allowed:
app/uninstalled, collections/create, collections/delete (truncated...)
Oddly, if i go back into the shop, the app has been installed, but has not
gone through the billing process.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-413253993,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOuwCW-uPC-p9chaOXQjnypFp3DQzks5uREzQgaJpZM4UJ9LN
.

Yes, I followed the instructions spat out by the console:
php artisan shopify-app:make:webhook CustomersRedactJob customers/redact
Job created successfully.
Don't forget to register the webhook in config/shopify-app.php. Example:

    'webhooks' => [
        [
            'topic' => 'customers/redact',
            'address' => 'https://your-domain.com/webhook/customers-redact'
        ]
    ]

I think this is the issue. You will need to remove these instructions.

Ah! Yes.. I'll make a note for GDPR that it's not required to do this... Or
remove the instructions all together; not sure what's a better option there.
On Wed., Aug. 15, 2018, 2:07 p.m. Paul Canning<EMAIL_ADDRESS>wrote:

Yes, I followed the instructions spat out by the console:
php artisan shopify-app:make:webhook CustomersRedactJob customers/redact
Job created successfully.
Don't forget to register the webhook in config/shopify-app.php. Example:
'webhooks' => [
    [
        'topic' => 'customers/redact',
        'address' => 'https://your-domain.com/webhook/customers-redact'
    ]
]

I think this is the issue. You will need to remove these instructions.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/26#issuecomment-413256141,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTuOhBEPvEwj0T7a80dfKY1GHZNQ0Ifks5uRE5IgaJpZM4UJ9LN
.

Just thought I should mention that we might want to add to the wiki that there is an additional GDPR requirement.
When a shops customer requests their data from a shop, there will be a request sent to the app. It's required that the app to send any related data it has directly to the customer.
More info here: https://help.shopify.com/en/api/guides/gdpr-resources
See: customers/data_request

Ah thats a new one! @ncpope Thanks, I'll reformat the entire wiki entry to help better guide this.

Hey guys this might be a little off topic but what should I do when my app does not read or store any customer data? The related text fields in the app settings are required.
Should I provide "dummy" webhooks that just return status code 200?

I dont think its off-topic. It seems it requires a response of 200 for the redact store & customer, but the new data_request it does not say anything.
In cases for customer, I would assume a 200 is fine, maybe with a message on the body (Shopify may store it?)

thanks @ohmybrew sorry to re-open the issue but I just noticed the additional requirement since I'm trying to get my app compliant before the 25th and I was double checking everything.
@tobiasdalhof It looks like you don't need to do anything for customer related data if your app doesn't access customer data. My app doesn't store any customer data either but I just created the hooks, just in case. Shopify has a tendency to change these types of requirements so I figured I would just do all of them now just in case.

Shopify has a tendency to change these types of requirements

Indeed.
I will replicate a lot of info in Shopify's GDPR into a revised wiki entry and link it for the install wiki entry so people are aware of the requirements.

Wiki entry reformatted to show all types of GDPR webhooks, explanations, payloads, expected responses, activation, and more.

Hi Sir/Madam,
I try to install my first shopify app but i seem error with webhooks configuration.
Error:  https://snag.gy/a5fQcq.jpg
shopify-app.php: https://snag.gy/rZlx06.jpg
Please help and thanks

@sovoeun have you add write_orders scope in SHOPIFY_API_SCOPES ?

@hakimihamdan88 Can you show maybe a bit because i not sure.


Cannot build .NET app

Hi,
Tell me if I'm missing something - but I'm getting errors trying to build a .NET app using this builder.
$ pack build hello --builder paketobuildpacks/dotnet-core-sdk

latest: Pulling from paketobuildpacks/dotnet-core-sdk
Digest: sha256:3baceaeb9ebcf93286033bbf2946b852b536a34adb1fa118c4ef07e10373c6d2
Status: Image is up to date for paketobuildpacks/dotnet-core-sdk:latest
ERROR: failed to build: invalid builder paketobuildpacks/dotnet-core-sdk: builder index.docker.io/paketobuildpacks/dotnet-core-sdk:latest missing label io.buildpacks.builder.metadata -- try recreating builder

@johnkors Ah, try the buildpack prefixed with docker.io, so it looks like --buildpack docker.io/paketobuildpacks/dotnet-core
I'm surprised we need that.. I swear I've done without the docker prefix many times before but I did encounter the same issue locally just now when I tried it

What error do you get when you use the builder?

I think I need help setting up the configuration for it to work. The build fails locating project references (dependencies).
Ex:
src/
- src/app/app.csproj
- src/other/other.csproj

Here app.csproj contains a ref to other.csproj thru a ProjectReference.

Running pack from the /src/app/ folder fails the build, since the build context is isolated to the /src/app folder.
Running it on a sln is not currently supported if I understood you in another ticket.

Is there a way thru config to run pack, so I can run it from the /src folder and specify the project to build/publish explicitly?

In that case, you'll need to set the BP_DOTNET_PROJECT_PATH environment variable to src/app to tell the buildpack which project to look at as the root

Great. It's interesting that your build time increased by 5X. Do you notice any speed-up in your rebuilds? The buildpacks do have the benefit of performing some cache optimizations for your rebuilds.
I also wonder how much of that time might be related to downloading the full stack image/full builder. The full builder specifically has a lot of buildpacks, and a plethora of OS-level packages to accommodate builds for a large set of different languages. We also ship a buildpackless version of the full builder, so it has all the same OS-level packages, but no buildpacks, and then you may provide your own buildpack (since you know you definitely want .NET Core).
That'd look like
pack build hello \
 --builder paketobuildpacks/builder:buildpackless-full \
--buildpack paketo-buildpacks/dotnet-core
 -e BP_DOTNET_PROJECT_PATH=./src/MyWebApp

@johnkors is this issue resolved for you now?

Yes, thanks!

Great! I'm going to close this issue out, but happy to continue the conversation about increases in build speed if needed!


[BUG] Bloxstrap FPS FFlag doesn't bypass Roblox's included unlocker

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?
I have Bloxstrap's FPS limit set to 600, yet in-game FPS is still hard-capped at 240 as per the escape menu's settings.

I'm not going to suggest FFlags that bypass the 240 hard limit, instead I'm going to give you a more easier way that doesn't involve FastFlags. Make sure your DFIntTaskSchedulerTargetFps is set to 0 (default). Go to %localappdata%\Roblox and open the file named 'GlobalBasicSettings_13.xml' and find the variable "FramerateCap." Changing this variable's value will change your in-game fps cap.

It's not supposed to go past 240.


bash: command not found

ADD ISSUE DESCRIPTION HERE
Version: 1.80.1
Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces
Extension version: 2023.12.0

I am doing  problem set for a course that I am taking. I have followed the given instructions however, when ever I enter HELLO in the terminal after running the python indoor.py i get bash: command not found.

The issue does not seem to be related to Python extension but how to use Python in terminal in general, hence I have to close this. If the desired output here is to print "HELLO", you can do so within the script print('HELLO'). I encourage you to ask this in stack overflow with screenshots.

I have the same problem


flatten-array is missing project.clj

As the title suggests, the flatten-array exercism is missing it's project.clj file.

Created #146 to address.

#146 merged; issue done.


Fix Slider overlay behavior when hovering on the thumb on desktop.

This is part of  Update Slider to support Material 3.
fixes https://github.com/flutter/flutter/issues/113367
This PR fixes the following issues
(this is compared to https://material-components.github.io/material-web/demos/slider/)
1. Unfocused Slider shows thumb overlay when hovering outside the thumb.
When Slider is not in focus, It should only show overlay when the pointer is hovering on the thumb.
Before

After

2.  The thumb overlay disappears when clicking on the Slider.
When you click to change the Slider value, it should get focus and the overlay should remain until Slider is unfocused
Before

After

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl - could you verify that the new highlight behavior is M3-correct? It LGTM, just wanted to make sure.

This LGTM. The overlaid indicator should remain visible as well, is that the case?

This LGTM. The overlaid indicator should remain visible as well, is that the case?

That makes sense if Slider is discrete or showValueIndicator: ShowValueIndicator.always, the value indicator should remain visible.

It should also remain visible when focused, if it appears when the slider lobe is clicked.


Clean up nupkg files left in tools folder

Once resolved, these nupkg packages are not currently being used.  They are simply taking up space in our AppVeyor Cache entitlement, so let's clear them out.

Hmm, well that didn't go very well...

@pascalberger Will continue to look into this one as well, as I think this will save a fair bit of space as well.


Make README.md consistent

Because it hurts my eyes and brain.

@famoraes :laughing: I forgot we had to be NO useful for this project! :disappointed:


Broken link

Submitter: Kristin Boye

I suggest the following changes:
The link to the Sample metadata translation table is not working in the About... section

Hi Kristin,
Thanks for letting us know. Link has been updated.


Are there other more generic applications of sadde-free Newton method?

Hi,
I am wondering if there are other applications of this method other than on neural networks. Perhaps like finding the global minimum of a multidimensional function?
Thank you,
Li

This method would be applicable to minimizing other functions than neural networks. However, like gradient descent, it will find a local minimum. It has no way to know when that is not a global minimum.


Send shareable error report to front

As agreed in the call from last week (or maybe 2 weeks ago?), we'll still create the shareable error report in the backend and append this to the end of the ignition HTML.
This will ensure that the ignition page can still be rendered as fast as possible, and that we don't have to copy over all the stripping logic to JS.
You can just add it as a comment in the blade here, and I'll make sure it finds its way to the share component in React 👍
https://github.com/spatie/ignition/blob/68a6b91eb7e2592239a552dfb85768a8b1a2c925/resources/views/errorPage.php#L50

Added it as shareableReport in window.data 👍


Would it be possible to add sort by "stars growth"

Hey folks 👋
I find the way that you're displaying the growth of stars by product very interesting and very useful 🎉 I'm wondering if it's possible to add sorting by "stars growth" to the sort dropdown 🤔
I took a quick look at the implementation and it seems a bit complicated at first glance. If it is something that you think might be interesting to add then I might take another look at it 👍

The plan has been to implement the same sorting we have on headlesscms.org - that site also uses React Static, just hasn't been updated for trending sort: https://github.com/netlify/headlesscms.org


implementation of InfectionService and minor changes to Config and Hu…

and minor changes to Config and Human Models to adapt to InfectionService.

It would be great if you could edit the findHumanAtPosition function in a way, that it could return multiple human entities. With that change and an added loop. We would have resolved the issue of multiple people standing in once cell 👍🏻
I think afterwards we can merge the PR 👍🏻

Ok will do as soon as possible.


Multiple trees with manual sort

Hello. Thank you for your work.
Can two trees be used with manual sorting?
I couldn't do it now.

@dimitriiy
It does not work well now due to the following defects
I plan to address them with high priority.
https://github.com/minop1205/react-dnd-treeview/issues/185
Sorry, but I'm going to close this one because the Issue is duplicated.


Add gcovr config file

It helps to simple do:
bash-5.2$ gcovr .
lines: 17.2% (36 out of 209)
functions: 9.7% (3 out of 31)
branches: 7.8% (49 out of 628)
calls: 0.0% (0 out of 0)
bash-5.2$

Codecov Report
Patch coverage has no change and project coverage change: -21.20% :warning:

Comparison is base (d19d892) 24.70% compared to head (18b5c97) 3.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #67       +/-   ##
==========================================
- Coverage   24.70%   3.50%   -21.20%
==========================================
  Files           6       3        -3
  Lines         251     171       -80
  Branches      142      77       -65
==========================================
- Hits           62       6       -56
+ Misses        181     165       -16
+ Partials        8       0        -8

Flag
Coverage Δ

Linux
3.50% <ø> (-12.93%)
:arrow_down:

Windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Extract all methods' parameters from a class to a union type

class TestClass {
    private field: string = "";

    func1(a: number): string {
        return a.toString();
    }

    func2(b: boolean): boolean[] {
        return [b, true, false];
    }
}

type MethodParams<Class extends abstract new (...args: any) => any, Member = Class[keyof Class]> =
    Member extends (...args: any[]) => any
        ? Parameters<Member>
        : never;

type Result = MethodParams<typeof TestClass>; // never

but Result inferred as never, not number | boolean as expected

You should use the instance type TestClass instead of the class type type TestClas as in TypeScript you could only get the prototype property in the later one.
Class[keyof Class], represents the instance type, equals with InstanceType<Class> here.

Updated code sample:
class TestClass {
  private field: string = '';

  func1(a: number): string {
    return a.toString();
  }

  func2(b: boolean): boolean[] {
    return [b, true, false];
  }
}

type MethodParams<
  Class extends abstract new (...args: any) => any,
  Members = InstanceType<Class>
> = {
  [K in keyof Members]: Members[K] extends (...args: any[]) => any
    ? Parameters<Members[K]>[0]
    : never;
}[keyof Members];

type Result = MethodParams<typeof TestClass>;

Or use instance type directly:
// Or extends object if you want this tool type more generic
type MethodParams<Class extends InstanceType<typeof TestClass>> = {
  [K in keyof Class]: Class[K] extends (...args: any) => any
    ? Parameters<Class[K]>[0]
    : never;
}[keyof Class];

type Result = MethodParams<TestClass>;

🤔 i notice that InstanceType just infer the matched type, when i navigate into TS sourcecode
**
 * Obtain the return type of a constructor function type
 */
type InstanceType<T extends abstract new (...args: any) => any> = T extends abstract new (...args: any) => infer R ? R : any;

still confused at this part

Class[keyof Class], represents the instance type, equals with InstanceType<Class> here.


DEA review: Define "making avilalable" in the DEA

an ensure that the term is used constantly thought the document

we think that the term does not need a definition as it is used constantly throughout the DEA.


[conformance-testing] Create GitHub Actions workflow to report conformance test suite results

Involves creating a workflow that runs the conformance tests and reports back the failing and passing tests. Should also compare the results with the target branch (similar to codecov comparing coverage).

Would be good for the generated conformance report to also show which tests pass or fail between runs. The cargo test outputs the number of passing and failing but looking at the delta for these numbers could be misleading as there could be some tests that previously passed but are now failing.


OnRenameColumns Handler Ignored

Hi,
In the below code sample, any idea why hander OnRenameColumns isn't used to handle the Table.RenameColumns operation? If it were used (and it seems like it should be), then the resulting table should contain values "Flag", "Was", "Set". However, instead, the table contains "Flag", "Unset".
In contrast, if the operation being performed is changed to Table.Skip, then handler OnSkip is used, resulting in values "Flag", "Was", "Set" being output, as expected.
let
  GetData = (flag as logical) =>
    if flag
    then #table(type table[X = text], {{ "Flag" }, { "Was" }, { "Set" } })
    else #table(type table[Name = text], {{ "Flag" }, { "Unset" }}),
  MyDataSource = GetView(false),
  GetView = (flag) =>
    Table.View(
	    null,
	    [
	      GetType = () => Value.Type(GetRows()),
	      GetRows = () => GetData(flag),
              OnRenameColumns = (details as list) => @GetView(true),
              OnSkip = (count as number) => @GetView(true)
	    ]
	  )
in
  Table.RenameColumns(MyDataSource, {{"Name", "X"}}) // flag not set - 2 rows returned, column name = "X"
  //Table.Skip(MyDataSource, 10000) // flag set - 3 rows returned, column name = "Name"

Thank you,
Ben

Thank you, @CurtHagenlocher! This is very helpful.
I guess I hadn't tried loading it into the data model. :-)
Merry Christmas!


proposed component: data-driven fly-out component

a simple fly-out that is driven by DisplayItemModel [docs]

this one should use a shadow-DOM slot as a fallback

the Material modal drawer takes one pretty far, old boy

:book: https://github.com/material-components/material-components-web/tree/master/packages/mdc-drawer


Lookup resource names in additional answer segment

This PR looks up the name from each answer in the additional records segment and returns any address records that it finds there.  If the name does not appear in the additional records, then it is returned as-is (which was the previous behavior).

Your changes look good to me but this library could use some minor additional refactoring:

dnspython is not pinned in setup.py.
theres no testing instructions in the project.

@pianoman19372 you should not pin a libraries dependencies unless it's a very wide pin in which case it'd make for a fairly useless pin.


Project setup

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b710e91). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      2
  Lines             ?      6
  Branches          ?      0
=======================================
  Hits              ?      6
  Misses            ?      0
  Partials          ?      0


Backport: Reduce the size of some public structs

We should backport https://code.videolan.org/videolan/dav1d/-/merge_requests/1540.  This reduces the size of a bunch of the public types, so our conversions will be faster/smaller, and it makes many of them more Rusty, to the point where we can make the Rav1d* and Dav1d* types the same for some of them (e.x. Dav1dContentLightLevel).
This also means we will target compatibility with DAV1D_API_VERSION 7.0.0.
For Rav1d* types that haven't been rustified yet, we should backport these changes to the Rav1d* types, too.

This also means we will target compatibility with dav1d 7.0.0.

I'm confused. Isn't dav1d currently on version 1.2.1?

This also means we will target compatibility with dav1d 7.0.0.

I'm confused. Isn't dav1d currently on version 1.2.1?

Hmm, I might've misread that.  They updated the version of something.  It might be supposed to be dav1d 1.3.0 instead.

This also means we will target compatibility with dav1d 7.0.0.

I'm confused. Isn't dav1d currently on version 1.2.1?

@thedataking, I think there's a separate DAV1D_API_VERSION from the dav1d version.  We're currently on 6.8.0 (see meson.build)


Add new Python tool for common log parser

New common log parser tool
This pull request is to add a new common log parser tool to this repository.   It includes a README to describe what the parser is and what it does.

Reviewed the changes / additions in this PR, and it looks good.


NetworkManager[1307]:   [1710263657.2248] dns-mgr: init: ns mode 'unbound' was removed. Update your configuration

Describe the bug
I see the following warning in my syslog: NetworkManager[1307]: <warn>  [1710263657.2248] dns-mgr: init: ns mode 'unbound' was removed. Update your configuration
I guess it has got to do with me setting unbound as my dns resolver, but it is listed as an option for networking.networkmanager.dns , so i don’t understand why the log warning says that it has been removed.
In my configuration.nix i've set:
networking = {
    hostName = "nixos";
    nameservers = ["<IP_ADDRESS>" "::1"];
    dhcpcd = {
      wait = "if-carrier-up";
      extraConfig = "nohook resolv.conf noarp";
    };
    networkmanager = {
      enable = true;
      plugins = lib.mkForce [];
      dns = "unbound";
      wifi.backend = "iwd";
      wifi.powersave = true;
    };
  };

  services.unbound = {
    enable = true;
    enableRootTrustAnchor = true;
    settings = {
      server = {
        verbosity = "0";
        cache-min-ttl = "300";
        cache-max-ttl = "86400";
        use-syslog = "yes";
        hide-identity = "yes";
        hide-version = "yes";
        harden-short-bufsize = "yes";
        harden-large-queries = "yes";
        harden-glue = "yes";
        harden-dnssec-stripped = "yes";
        harden-below-nxdomain = "yes";
        harden-referral-path = "yes";
        harden-algo-downgrade = "yes";
        ip-freebind = "no";
        qname-minimisation = "yes";
        use-caps-for-id = "yes";
        prefetch = "yes";
        prefetch-key = "yes";
        rrset-roundrobin = "yes";
        minimal-responses = "yes";
        tls-cert-bundle = "/etc/ssl/certs/ca-certificates.crt";
      };
      remote-control.control-enable = false;
    };
  };

Steps To Reproduce
Steps to reproduce the behavior:

Set the above settings in configuration.nix

Expected behavior
I don't understand the severity of the warning but i guess it shouldn't be there.
Additional context
Also open on discourse
Notify maintainers
@Janik-Haag

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.7.9, NixOS, 24.05 (Uakari), 24.05pre594677.3030f185ba6a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Upstream dropped unbound almost a year ago https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/5da17c689be5e66ea2f63dea6f1846625e652998 but I guess no one bothered, I'll drop the unbound option.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-networkmanager-1303-warn-1709934611-6366-dns-mgr-init-ns-mode-unbound-was-removed-update-your-configuration/41038/2


uv: 0.1.4 -> 0.1.5

Description of changes
Diff: https://github.com/astral-sh/uv/compare/0.1.4...0.1.5
cc @marsam

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 289959 run on x86_64-linux 1

2 packages built:

uv
uv.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3472

Result of nixpkgs-review pr 289959 run on x86_64-linux 1

2 packages built:

uv
uv.dist

Result of nixpkgs-review pr 289959 run on x86_64-darwin 1

2 packages built:

uv
uv.dist

Binary tested on x86_64-linux and x86_64-darwin. Everything seems to work :+1:


[v3] Fix font codegen tests

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR helps fix ~7-8 tests we had that were not passing the proper font data, thus introducing failing tests. They originally failed and looked like this:

But now pass as-expected

What is the current behavior? (You can also link to an open issue here)

This PR fixes said tests

What is the new behavior (if this is a feature change)?

N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

I noticed there's still a failing text codegen test after this change, but it seems to be due to a changed number in the string output:

Is this expected behavior? Should we update the tests with the code's output string? Is the code wrong and we need to fix the codegen logic?

Perfect, thanks @crutchcorn
The reason for the extra failing test is because the added dummy font is now causing the avatar font index to be 1 higher than it was previously. The \002\002 portion of the string is setting the font to index=2 (previously index=1). I've just pushed a fix for this

Good stuff @chrismaltby
Seems like we only have one failing test now:
Summary of all failing tests
 FAIL  test/store/features/entities/entitiesState.test.ts (26.554 s)
  ● Should be able to add custom event

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 7

    - Array []
    + Array [
    +   Object {
    +     "args": Object {},
    +     "command": "EVENT_END",
    +     "id": "6f8cb3f7-2afe-47fa-b3f2-cf6aaa0c81a2",
    +   },
    + ]

      1543 |   expect(
      1544 |     newState.customEvents.entities[action.payload.customEventId]?.script
    > 1545 |   ).toEqual([]);
           |     ^
      1546 | });
      1547 |
      1548 | test("Editing a custom event name should propagate to instances of the event", () => {

      at Object.<anonymous> (test/store/features/entities/entitiesState.test.ts:1545:5)

Test Suites: 1 failed, 116 passed, 117 total

https://app.circleci.com/pipelines/github/chrismaltby/gb-studio/1320/workflows/c0bef236-b393-48bf-a2af-aebf3f480ddd/jobs/4640
I wasn't sure what to do with this test, maybe this is something you can help debug?


Add Strimzi 0.17.0 to Upstream Community Operators

This PR updates the Strimzi operator in Community Operators to 0.17.0. This was tested on OCP4 and Minikube manuallywith my custom repository as well as with our test suite and all seems to work well. (this follows up on #1432 which added 0.17.0 to community operators).
Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Note: I think the CI failures are expected given how our operator works. I have tested it manually, so it would be great if we can just merge it. Thanks.

@scholzj Hi, our tooling have problem with one of our test.
Test which faling is : Writing Into CRs Has An Effect it has some problem with updating the operator cr.

@ssimk0 The problem in our case is that the different CRDs have relationships among them. So trying to deploy them randomly from the examples does not always yield any results. Which is why this failed. I have tested these things manually and it works fine.


Update release-notes.md

@JasonGerend : Thanks for your contribution! The author(s) have been notified to review your proposed change. @nnamuhcs

@sidrb-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. @nnamuhcs

@JasonGerend : Thanks for your contribution! The author(s) have been notified to review your proposed change. @nnamuhcs

#sign-off


Can't play because of loader sub asset

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

The editor should currently disable remap to use the material inside the model


Readme: note that py3 annotations are available

as of v1.0.7, merged in #74

Thanks for your keen eye!


Changing country code reset all values in the field

When I change country code it reset all value, instead it should change only country code.
Steps

edit phone number field
change country

Observe

country code is changed and phone number is wiped

Expected

only the country code changes and leaves rest of number

Fixed in https://github.com/viclafouch/mui-tel-input/releases/tag/v2.1.0


⚠ ODIGDesigns has degraded performance

In c0e559a, ODIGDesigns (https://www.odigdesigns.com.au) experienced degraded performance:

HTTP code: 200
Response time: 9452 ms

Resolved: ODIGDesigns performance has improved in b19fb2c.


rubocops/patches: Make more GitHub patch locations enforce revisions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

We recently deleted a load of old Homebrew/formula-patches patches for non-existent core formulae (https://github.com/Homebrew/formula-patches/pull/283). This is a good action to take. Users should always be able to retrieve the patch once it's been deleted from the repo, if the formula they continue to use specifies a git revision to pull from, not just master.
The code to detect master formulae was already here, so this adds another GitHub host to the detection: raw.githubusercontent.com as that's what the current patches that use master (https://github.com/Homebrew/homebrew-core/pull/51329) link to.
Fixes https://github.com/Homebrew/homebrew-core/issues/51313.

Example brew audit output:
dbxml:
  * C: 23: col 17: GitHub/Gist patches should specify a revision:
      https://raw.githubusercontent.com/Homebrew/formula-patches/master/dbxml/c%2B%2B11.patch
Error: 1 problem in 1 formula detected

Great work here, thanks @issyl0!


[QUERY] - Dead Letter queue message publish and consume with spring boot

Hi Team,
I am looking for info on could we publish and consume message to azure bus dead letter queue with artificat spring-cloud-azure-starter-servicebus-jms ?.   or with any other spring boot azure libraries ?.

Hi @das-devi , you could  try with spring-cloud-azure-starter-integration-servicebus library, refer to https://learn.microsoft.com/azure/developer/java/spring-framework/spring-integration-support#service-bus-message-headers


Correcting entry in Multiple Resource Types

We can use field selectors across multiple resource types. The field selectors can be used for single resource types too.

/kind cleanup

Page preview:
https://deploy-preview-28119--kubernetes-io-master-staging.netlify.app/docs/concepts/overview/working-with-objects/field-selectors/#multiple-resource-types

/lgtm
/approve


is bare git on dropbox really a problem? [cf article]

http://edinburghhacklab.com/2012/11/when-git-on-dropbox-conflicts-no-problem/

Yes, it really is a problem. I've written a blog post about it here.
In the single user case, with enough time between updates or with fast syncing, it is unlikely that you'll have problems that you can't recover from (as long as you understand git internals… you'll need to go mucking around in the .git folder). However, git-remote-dropbox was really built for the multi-user case -- to make it so that you can have a shared folder and then have multiple people concurrently using the "git server" safely. In the multi-user setting, just sticking a bare repository in Dropbox can actually result in data loss. Even in the single user setting, it's a lot nicer to use git-remote-dropbox, which just works, rather than using a method that kinda sorta works but might break at any time and require repair.
The article says:

Every commit is stored in the subdirectory .git/objects under its SHA-1 hash. This means its extremely unlikely that the commit data will collide. Cool!

Yes. You're not going to have SHA1 collisions. But that's not the real problem. Saying "every [object] is stored in the subdirectory .git/objects under its SHA-1 hash" is only true to first approximation. Git's not that simple. It doesn't just store all the objects separately in the filesystem, each independently addressed by its SHA1. One thing it does is that it implements an optimization called packfiles. If multiple clients are packing files differently, this may do weird things when you synchronize.  If multiple people push a ref, there's a conflicted copy created, and some changes are "lost" (hidden, but still there as loose objects), the associated objects can actually be deleted as a result of garbage collection.
So yes, bare Git on Dropbox seems to work okay for the most part, except when it doesn't.

I'm assuming this is resolved, feel free to reopen if you have any other questions.
I guess this information would be good to put somewhere (maybe the wiki or something?), but I'm not going to do anything with it for now.


Load raven-js from NPM instead of Bower

Since ember-cli 2.11 made Bower optional and ember-cli 2.13 has removed Bower completely from new projects, this PR leverages the fact that raven-js is available via NPM.

The default blueprint will add raven-js as an NPM package instead of a Bower package.
To avoid breaking changes for existing users, index.js will look for the NPM package first, fall back to the Bower package second, and then rely on CDN configuration third.

Oops, I didn't notice #66 before I did this for our own project's benefit. If that PR is preferred, feel free to close this one. I look forward to our Bowerless future either way 😄

#66 is blocked by Fastboot compatibility issues. I would love to see this one gets merged and released first so we can get rid of Bower as early as possible! :D

@tchak Can you review this PR please? It contains some of the stuff you created in PR #66, but diff between the versions is not null though 🙂

this is obsolete now that #81 was merged


Err when trying to build the editor without its required modules

See https://github.com/godotengine/godot/issues/74546#issuecomment-1471481747. I didn't add the same check for the text server being disabled, because you can extend it with a third party module instead, and I don't think we can detect that there is no text server implementation whatsoever during this validation step.

I really like what is done here but i think there is way more modules that are needed for the editor not to crash. I tried a bit but with only the two modules checked here plus the text server and it crashes. So tried to find which ones are needed but could only find that it needed a language (added gdscript). After that vulkan driver complains about no pipeline being set.
Not sure which module is needed for the pipeline and the driver part of the source code is too hard for me.

This check used to exist (still does in 3.x) but was removed in 951a1016d3c381252d2d32131c1ad1ec68a2b190, possibly as an oversight. CC @Faless
Makes sense to add back.

I really like what is done here but i think there is way more modules that are needed for the editor not to crash. I tried a bit, with only the two modules checked here plus the text server, it crashes. So tried to find which ones are needed but could only find that it needed a language (added gdscript). After that vulkan driver complains about no pipeline being set.
Not sure which module is needed for the pipeline and the driver part of the source code is too hard for me.

The editor should be able to run without GDScript, as long as you're not trying to run GDScript code. So if it doesn't, this should be fixed.
Likewise for rendering, it should work in headless mode if no valid renderer is compiled, so this would be worth looking into separately.

Makes sense to add back.

Do you want me to try and restore it as it was, without hardcoding these two specific dependencies?

Yeah I think the old format was a bit more flexible to add more modules to the array.
In theory the module dependency graph added by Fabio could be used for this too but since the editor isn't a module, it doesn't run this check.

Okay, made the changes. The output looks something like this now:
scons: Reading SConscript files ...
Found MSVC version 14.2, arch x86_64
Building for platform "windows", architecture "x86_64", target "editor".
NOTE: Developer build, with debug optimization level and debug symbols (unless overridden).
Disabling 'editor' module as the following dependencies are not satisfied: freetype, svg
Not all modules required by editor builds are enabled.

Thanks!

Cherry-picked for 4.0.3.


Fix error in /W3 /W4 C4244

Fixes #4611
The previous description is slightly misleading as for /W4 they use types int, but for /W3 they use __int64 and unsigned int. Since the sign of the types used are a little specific, one may be a little confused whether it affects both signed and unsigned counter-parts. Made that part clearer and demonstrated that in the examples. Fixed the error highlighted in issue 4611 and reflowed some content.
Hi @TylerMSFT, I hope it is alright to take up issues already assigned to you. Do let me know if that is undesirable. Thanks.

@TylerMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @rageking8, thank you for taking this one on. I made a couple small adjustments.
It's ok to take items assigned to me, as long as they don't have an 'in-progress' tag on them.

#sign-off


Enable oidc flow for kubectl-gs login without opening a browser window

Description:
kubectl-gs oidc flow should not force opening a browser window on environments where it is not supported during automation on machine to machine events (CICD.. etc)

Joe pointed to https://github.com/giantswarm/leviathan for an example of oidc without a browser window

@gawertm we think this is in bigmac

fake idp exists e.g.https://github.com/healthify/fake_idp/tree/main or https://github.com/navikt/mock-oauth2-server
maybe we could use local ldap database? https://dexidp.io/docs/connectors/ldap/
we need to define a clear test case we want to cover and which parts we want to mock
we should talk to tinkerers about test scenarios
let's look at options for the device flow. Is it possible to somehow select a specific connector directly, if by only supplying a single one?
what are the implications of the structured auth config in kubernetes 1.28, what can we do when there is no dex?


Not working in Firefox

I can't seem to get this to work in Firefox latest (OSX latest).
The following example works in Chrome & Safari but not FF. It seems to fail silently:
https://plnkr.co/edit/8fiXfQXHUE7dbvTT0TTT?p=preview
Thoughts?

Is this still an issue for you @trakout?

I can see that there are some major inconsistencies in behaviour on Firefox.

@ggoodman Yep, unfortunately still an issue (within my project & the above plunkr eg, which is a quick example of how I'm using it).
Running FF 47.0.1 on on Mac OS 10.11.4.

You can try the solution proposed on
Adding e.originalEvent.dataTransfer.setData('text', 'anything'); on handleDragStart fixed it for me on FF 48.0 OSX 10.11.1.

@tefdos good catch, that fixes it for me. I didn't reference originalEvent -- MDN documentation does not seem to mention it either, so it was just e.dataTransfer.setData('text', 'anything');.
@ggoodman I've added the 1-liner in #13 -- line 71.

Fixed in 137d301336d7d88eb52b4aa2121da54019861dce. Please use 3.0.2.
Major bump to account for new behaviour whereby the element's .text() will be set as a text dataTransfer entry if no other items or files were added by user code.

This is still an issue in Firefox.

@jziggas I'll open if you can show me some sort of reproduction. My own use of this library isn't having any issues on latest FF.

I can't get https://plnkr.co/edit/LjGsvoGzoWoEQFu74tOU?p=preview to work in FF.
In my own app I can seem to reliably reproduce an issue when you do a sort of double click while dragging - it looks like onDragEnd is never called because the drop containers are still highlighted and you can't drag any more items.

AngularJS on Firefox appears to block the use of DOM elements in expressions. By default angular-drag-drop will set the element itself as the drag data. An easy way out is the set custom drag data using the drag-data="scopeReference" property.
I've modified your example to use drag-data="'Drag Me'" in this fork of your plunk and have tested this.

Although it wasn't in the plunk, I do already have drag-data="" set in my app to move objects around.

Actually in your plunkr I can still repro the issue where dragging stops working.

http://recordit.co/vF1Qdu5ybT


Powertoys Run - Does Nothing when I try to launch

Microsoft PowerToys version
0.71.0
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
Reports version 0.71.0.
Tried running as Admin - doesn't fix.
I've tried disabling all the Plugins except one - tried JUST Winget and JUST Window Walker.
Powertoys Run does not launch with either the ALT:space shortcut or the menu (single-click in Notification Tray)
✔ Expected Behavior
A pop-up menu that I could use to select/search Winget.
❌ Actual Behavior
Nothing. No dialog is presented to the user.
PowerToysReport_2023-07-17-21-08-05.zip
Other Software
N/A.
PowerToysReport_2023-07-17-21-08-05.zip

When is someone likely to be assigned to this issue?

Progress. Latest version v0.72.0 now shows the search box. Unfortunately, the Winget command I was interested in, is now missing!


feat: optional custom amplify domain

Issue #, if available:
https://github.com/aws-samples/iam-identity-center-team/issues/32
Replaces https://github.com/aws-samples/iam-identity-center-team/pull/87
Description of changes:

parameters.js is the main change, so the callback and logout URLs are set to the custom amplify domain.
integration.sh updated to show custom domain when setting up/updating IIC app.
template.yml wondered if it should also create AmplifyDomain, but seems like that setup can be quite specific (subdomains, include root, auto create) so took it back out. Can revisit if needed / can be standard setup

Have tested the changes to parameters.js and integration.sh (although with some additional bits not in the PR for custom cognito domains as well), but have a slightly different setup (deploy.sh/update.sh/template.yml).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

re-open PR

@roseo1 thanks for your contribution. This has now been merged as part of a separate PR


Optimizers update

Hi,
As said in the title, this PR mainly includes updates on optimizers.py. Detailed explanations:

Following the suggestions in this PR.

Making rmsprop, adadelta save optimizer variables. No need for saving variables in sgd (only need grad in each update).
Making rmsprop, adadelta and sgd not copy grads to GPU.

Other updates

translate.py indent fix (2 spaces to 4 spaces), which bothered me for a long time...
readme. Explanation for --device-list should be multi-processing decoding, rather than multi-thread decoding. Sorry for the mistake.

Please refer to the file changes to see if anything wrong.

Thank you

thanks, pulling this in!


python311Packages.mypy-boto3-*: updates

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 297551 run on x86_64-linux 1

60 packages built:

aws-sam-cli
aws-sam-cli.dist
pacu
pacu.dist
python311Packages.boto3-stubs
python311Packages.boto3-stubs.dist
python311Packages.botocore-stubs
python311Packages.botocore-stubs.dist
python311Packages.dsnap
python311Packages.dsnap.dist
python311Packages.mypy-boto3-accessanalyzer
python311Packages.mypy-boto3-accessanalyzer.dist
python311Packages.mypy-boto3-cloudformation
python311Packages.mypy-boto3-cloudformation.dist
python311Packages.mypy-boto3-codebuild
python311Packages.mypy-boto3-codebuild.dist
python311Packages.mypy-boto3-connect
python311Packages.mypy-boto3-connect.dist
python311Packages.mypy-boto3-dynamodb
python311Packages.mypy-boto3-dynamodb.dist
python311Packages.mypy-boto3-ec2
python311Packages.mypy-boto3-ec2.dist
python311Packages.mypy-boto3-finspace
python311Packages.mypy-boto3-finspace.dist
python311Packages.mypy-boto3-logs
python311Packages.mypy-boto3-logs.dist
python311Packages.mypy-boto3-managedblockchain-query
python311Packages.mypy-boto3-managedblockchain-query.dist
python311Packages.mypy-boto3-savingsplans
python311Packages.mypy-boto3-savingsplans.dist
python311Packages.types-aiobotocore
python311Packages.types-aiobotocore.dist
python312Packages.boto3-stubs
python312Packages.boto3-stubs.dist
python312Packages.botocore-stubs
python312Packages.botocore-stubs.dist
python312Packages.dsnap
python312Packages.dsnap.dist
python312Packages.mypy-boto3-accessanalyzer
python312Packages.mypy-boto3-accessanalyzer.dist
python312Packages.mypy-boto3-cloudformation
python312Packages.mypy-boto3-cloudformation.dist
python312Packages.mypy-boto3-codebuild
python312Packages.mypy-boto3-codebuild.dist
python312Packages.mypy-boto3-connect
python312Packages.mypy-boto3-connect.dist
python312Packages.mypy-boto3-dynamodb
python312Packages.mypy-boto3-dynamodb.dist
python312Packages.mypy-boto3-ec2
python312Packages.mypy-boto3-ec2.dist
python312Packages.mypy-boto3-finspace
python312Packages.mypy-boto3-finspace.dist
python312Packages.mypy-boto3-logs
python312Packages.mypy-boto3-logs.dist
python312Packages.mypy-boto3-managedblockchain-query
python312Packages.mypy-boto3-managedblockchain-query.dist
python312Packages.mypy-boto3-savingsplans
python312Packages.mypy-boto3-savingsplans.dist
python312Packages.types-aiobotocore
python312Packages.types-aiobotocore.dist


Codemirror onChange messes up undo/redo history when emiting an event

  codeChange = new EventEmitter<string>();

    this.editor.on('change', (editor: CodeMirror.Editor, _change) => {
      this.codeChange.emit(editor.getValue());
    });

I'm using CodeMirror with Angular and emiting an event whenever the text inside the editor changes. Something is with the emit function is causing the undo/redo buttons to get messed up. Now I have to call the undo/redo functions twice and character-by-character, instead of the normal behavior.

Something is with the emit function

Since I don't have the emit function, it's hard for me to diagnose this. Just calling getValue on change events doesn't produce the effect you describe. Can you create a minimal script that demonstrates the problem?

Example repo created: https://github.com/benkonz/codemirror-history-example

Nevermind, I figured out what the problem was. When I setup the two way data-binding with the codemirror editor text, the editor text was getting set to the old text every time a change was made to the editor in addition to the new text added, so the undo stack had a duplicate copy of the text after every change. I just removed the two-way data binding with the editor code and it is working a lot better

Example repo created: https://github.com/benkonz/codemirror-history-example

@benkonz I'm also working Codemirror with Angular and facing a similar issue. Could please invite/share this repo with me?

@HenonoaH Sorry! I deleted the repository when I figured out the issue... It's been a while since I encountered this issue, and I don't quite remember specifically what I did to fix it (outside the comment I left). I can take another look at the commit I made to fix the issue this weekend.


Orbit line renderer tweak

Feature
LineRenderer.endColor should be tint with 0 alpha, instead of white with 0 alpha. This will make the lines retain their color as they fade out, which looks prettier and is what base game does.
Context
No response

Implemented in https://github.com/xen-42/outer-wilds-new-horizons/commit/c7c781e2cdd936795582fc9ca0291652d9c296a3


Windows' logo instead of Micosoft's

Sorry to be picky
but the current logo image on top of README.md is the logo of Microsoft
and Windows has its own one like this

Windows

Hey, I've thought about designing one like this as well but couldn't find the solution. if you can help me find one would be great! :)


🚀 Feature: Make backstage-cli extensible

🔖 Feature description
Provide extension points to backstage-cli in order to reuse some of its infra for custom goals. In particular, I'd like to configure my own plugin templates with injected best practices. For example, setup Material UI 5 instead of 4 which comes from default template when bootstraping FE plugin.
🎤 Context
Material UI migration highlighted need for custom templates as default ones always come with inherent delay. There may be more examples of customizations for backstage-cli in general and its templates in particular. The reasoning is very similar to Scaffolder, which backstage-cli new mimics on a repo level.
Well, it's technically possible and to some may be even more applicable to use Scaffolder templates for this. That's their main goal - bootstrapping component with best practices baked in.
However I'd argue that it's a bit of overkill for plain code generation of Backstage plugins as it also requires to have them catalogued, which may not be desired by some companies (for example, because those plugins could be private to the Backstage repo and may confuse devs when mixed with public reusable components).
Furthermore, backstage-cli new is the go-to solution for plugin development so it makes sense to build on top of it to keep the flow familiar.
✌ Possible Implementation
The simplest solution would probably be the specific folder structure in your Backstage monorepo where custom templates are stored. Then this is read by the backstage-cli and displayed as option, maybe with some configuration file to select only subset of options, etc.
More complicated, but versatile option would be a plugin architecture when extra templates come from some npm packages, that can be wired as devDependencies. backstage-cli would scan for them, recognise and load all the extensions. This would allow to separate those extensions from main monorepo if someone chooses so, or even share those packages publicly for open source use.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Some related links as this has come before but is still a good idea!
https://github.com/backstage/backstage/issues/14585
https://github.com/backstage/backstage/issues/15818

Just wanted to say that this is something that we've been wanting to add, but don't have the capacity to design or implement. If anyone wants to take on driving this we can help out with guidance.


Improve Nats tests

Remove Polly and use WaitForText instead.

Is this feature complete?

[X] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[X] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[X] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[X] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[X] No

/azp run

/azp run

/azp run


Error Unrecognized command

./tezos-client activate account alias with tz1hPDF4r3T4GAapdHhe4wNcAuN4vG9rVfkX.json
gives:
Error:
  Unrecognized command.
  Did you mean one of the following?
    activate protocol <version> with fitness <fitness> and key <password> and parameters <parameters> [--timestamp <date>]

Zeronet node is having lots of:
Jul 15 05:00:58 - p2p.maintenance: Too few connections (0)
ps aux | grep tezos-node   shows the node is running:
leo       22436  1.2  1.5<PHONE_NUMBER> 257308 pts/0 Sl+ 05:20   0:01 ./tezos-node run --rpc-addr <IP_ADDRESS>:8732
leo       22559  0.0  0.0  14352  1056 pts/2    S+   05:21   0:00 grep --color=auto tezos-node

Needed to add peers with --peer  from tzscan.io


[feature] Add cri-o pre-built binaries tar

Hi all, Is there any pre-built binary files for the release? like as cri-containerd release.

Not yet, we're working on that but we have Rpms and debs for fedora/ubuntu/centos so best for now would be to install from your package manager

@runcom Okay, thanks you for your help!

also, consider a tarball with CRI-O isn't something you really want as crio is a dynamic binary and it's really unlikely that works on every os. We might need to some help on this :confused:

@runcom  Yes, I can try to help this request!

@lsm5 Can you update this ISSUE with locations for rpms for Centos and then close.

Every release contains the phrase "Please try out the release binaries and report any issues", but no binaries are linked :(

No action for quite a while.  If community wants static binaries then we will accept PRs.  Until then I will close this.  Reopen if you disagree.

Just a datapoint. I've been using containerd more of late, as they provide exactly this while cri-o doesnt. Better yet would be centos rpms, but neither runtime provides those.

Not sure why this issue closed but i would gladly help out. I would personally LOVE to see pre-built binaries under "releases".

Just a datapoint. I've been using containerd more of late, as they provide exactly this while cri-o doesnt. Better yet would be centos rpms, but neither runtime provides those.

Hmm, centos PaaS SIG does provide those: https://cbs.centos.org/koji/packageinfo?packageID=5695
Also: https://cbs.centos.org/repos/paas7-crio-113-candidate/x86_64/os/Packages/ and
https://cbs.centos.org/repos/paas7-crio-112-candidate/x86_64/os/Packages/
I have a TODO to create 1.14 repos.

I don't think centos base would have those rpms though, since those are not shipped in RHEL to begin with.

Does https://cbs.centos.org/koji/packageinfo?packageID=5695 feed into a repo?
I'm kind of reluctant to use packages out of any repo with 'candidate' in its title.

On Tue, Apr 09, 2019 at 08:42:01AM -0700, kfox1111 wrote:

Does https://cbs.centos.org/koji/packageinfo?packageID=5695 feed into a repo?
I'm kind of reluctant to use packages out of any repo with 'candidate' in its title.

I'll have those flow into -testing and -release and get them synced on
buildlogs.c.o
--
Lokesh
IRC, GitHub: lsm5
GPG: 0xC7C3A0DD
https://keybase.io/lsm5


feat: Deno Build Tool

This adds a basic deno build tool that can be run with deno run start ./configs -o ./out allowing configurations to be written in yaml.

This is going to be superseeded by a new system built around snow once we are done that.


Question about leaving and re-entering.

Hi,
I am using crossterm backend. TUI is only used for draw calls, otherwise I setup my terminal using crossterm
let mut stdout = io::stdout();
execute!(stdout, terminal::EnterAlternateScreen).unwrap();
execute!(stdout, cursor::Hide).unwrap();
execute!(stdout, terminal::Clear(terminal::ClearType::All)).unwrap();
terminal::enable_raw_mode().unwrap();

I'm trying to open a file using $EDITOR. I tried to disable alternatescreen and rawmode before opening up the $EDITOR and restoring them after but after quitting the $EDITOR. I can only see changes rendering to the screen.
How can I re-render everything back after quitting the $EDITOR?
EDIT: Got it working by looking at the source. It seems it is always diffing the buffers, but I want to re draw everything. I added an empty draw() call to get the diff result to be everything. This feels like a workaround, should this be supported?

This is a case I haven't thought of to be honest :). I think one of the issue is that terminal.clear does not keep the internal buffers in sync. Would the changes in #360 help you ?

Looks like #360 would fix it.

Ok I merged it to master. Let me know if you manage to play with this and if this effectively fix your issue.

I tested it and it's fixed.


Add badge to MyBinder for example notebooks

Expected Behavior
Example can be run on MyBinder without any installation.
We need to check how to best deal with the GPy dependency here.
Actual Behavior
Currently not possible because repo is private.

works.


Remove usage of jackson in sdk-common ingress client

Remove the other usage of jackson in sdk-common, depends on https://github.com/restatedev/restate/pull/1542

This is outdated


make away notifications configurable

We just relaunched https://irc.darwin.network/ on Oragono v0.9.0. Things are going great except for a few hiccups. In particular, some users are having issues with irssi spamming them with away notifications:
13:38 -!- AWAY Away
13:41 -!- AWAY
13:50 -!- AWAY
13:53 -!- AWAY Away
13:56 -!- AWAY Away
13:57 -!- AWAY
14:01 -!- AWAY Away

I think these are coming from here:
https://github.com/oragono/oragono/blob/02cd620bd4f918ee745582525902e36ea60e540a/irc/server.go#L1707
Would you take a PR that introduced a config flag to turn these off?

I've had a chat with one of the irssi devs about this and we've worked out it's a bug – they shouldn't be receiving these messages unless they specifically ask for them, and they're not asking for them. I'll dig further into exactly what's going on here and push a commit to fix it, thanks for the yell!

Turns out this is a bug with how we discover which clients to send away-notify and similar! This commit fixes it: a78a8f1130715773c42b68876da03141f8af75bb (thanks to @dequis for helping track this down, as well as a few other bugs which are now patched in master).

The users say this is indeed fixed :-)

Awesome, thanks again for reporting this :)


doc: provide maxBins/minBinSize/binningStrategy description

I think maxBins and minBinSize descriptions should have been added before. Would be great if someone could double-check.
The binningStrategy description is new and should certainly be added.

Moved common options to the common description. I have also sorted the parameters alphabetically to make the table easier to navigate.


Fix pytest file discovery

At the moment, files are filtered from pytestArgs before test discovery is run. This is unexpected for a user and could lead to issues:

Not all tests will be found
Given a file tree and pytestArgs

tests/
├── dir
│   └── test_b.py
├── helpers
│   └── test_c.py
└── test_a.py

    "python.testing.pytestArgs": [
        "tests/dir",
        "tests/helpers/test_c.py",
    ],

tests/helpers/test_c.py would be filtered and only tests inside of tests/dir would be discovered.

pytest discovery failing completely
In large projects it's possible that different test subfolders require different dependencies via conftest.py. Not all of them might be installed. If the desire was to only discover tests in tests/dir/test_b.py, having that argument filtered would mean that discovery is run from root and thus all conftest.py files are loaded. If the test is inside a subfolder, it's possible to work around it by removing the filename. However that doesn't work for tests inside the root test directory.

Hi @cdce8p, thank you for your contribution!
Could you open a bug against the repo with the same description as what you've put here (title could be something along the lines of "Pytest test discovery failing when pytestArgs contains filepaths"), and add a news entry to your PR?
Thanks!

Could you open a bug against the repo with the same description as what you've put here (title could be something along the lines of "Pytest test discovery failing when pytestArgs contains filepaths"), and update the news entry to your PR?

Done 🙂 One other thing, I wasn't sure if a test would makes sense here. I couldn't find an existing one and all the PR is doing is to remove a filter.


abortOnRetry and proxy for http.js

I took the liberty to build a "solution" for request abortion (e.g. autocomplete example)
And also add a proxy property for http.js (e.g. inside company's proxy)

bump, any comment?

please merge the proxy option!

@msangui Thank you for the PR and sorry for the delay! Could you please submit a separate PR for the proxy feature? I will be happy to merge it. We have not decided on how to abort requests yet, so I would not mix these changes.

@msangui I've just merged the proxy related changes. Thank you again!

How do we configure the proxy options?

@so4pmaker not yet. Hope it will be released soon. I'll also update the docs. In short, you just need to set proxy config parameter as follows:
axios.defaults.proxy = {
  host: 'foobar.com',
  port: 8888
};

or
axios.get(url, { proxy: { host: 'foobar.com', port: 8888 } });

or
var instance = axios.create({ proxy: { host: 'foobar.com', port: 8888 } });

great to see this merged :D
If you need any help/ideas on aborting count me in.

Is this still not in the ./dist?

I guess what I did doesn't follow the wished guidelines or ideas.
The abort feature is a must, IMHO.

Is it already merged? How to use the proxy option?
I tried:
axios.defaults.proxy = {
  host: '<IP_ADDRESS>',
  port: 8888
};

<IP_ADDRESS>:8888 is Fiddler, however when I tried axios.get('http://test.com') it goes to http://test.com:8888 and never go though the local proxy?

Closing as axios supports request cancellation now.


Strange correlation between how you import shared lib's aliases declared in the package.json "exports" and mf plugin

Repro on stackblitz
We encountered some strange behaviour when started migrating from webpack + mf onto vite + mf using this plugin. Repro (link above) contains 3 projects that represent a host, a remote app and a shared library. The shared library explicitly provides access to its exports by declaring them in the 'exports' section of its package.json.
The problems started when we encountered some circular dependencies inside the shared lib (you can see them if you take a look at files shared/src/utils/now.js & shared/src/circ/foo.js). The thing is, tools like madge don't consider this to be circular dependencies. But if you run script dev:remote from the root package.json, you'll see that the remote serve is broken, Vue app is not being created, and there are no errors in the console.
The further you go the weirder it gets: if you fix the import in the files above and add them, for example, '. xxx' at the end of the string, like import {getState} from 'shared/utils.xxx' (I reserved such aliases in the 'exports' section of the shared lib's package.json) and restart the script - it will start working! You can go further and also run dev:host to see how remote application will be loaded dynamically by the host & they will share the same state from the shared lib (shared/src/utils/getState.js):

But if you start using such import paths (some-path + .xxx) outside of the shared lib in the host & and in the remote - they lose their shared state:

You can also delete creation of mf/vite plugin from vite configs and see that the remote starts working just fine (no need to rewrite import paths from the shared), but of course you'll lose module federation feature in this case.
Can anyone explain what's going on here and how to fix it?

I haven’t been able to reproduce the same result as you; I can’t even display the page properly.

It seems to be related to the "shared": "file:../shared" configuration

Hi, @zhangHongEn, thanks for your reply

I haven’t been able to reproduce the same result as you; I can’t even display the page properly.

I updated repro, so now it works from the beginning. Run dev:remote from the root package.json to see that the remote app is built & previewed and then abort this behaviour by changing the import path in the files shared/src/utils/now.js or shared/src/circ/foo.js. Just delete '.xxx' from the end of the string, e.g. import {getState} from 'shared/utils.xxx' -> import {getState} from 'shared/utils', restart dev:remote and you will see a blank page without the created Vue application.

It seems to be related to the "shared": "file:../shared" configuration

Unfortunately, this is not the root of the problem, because our IRL 'shared' library is a published npm package, and that's where we started to struggle.
If you're wondering why you even need to bother with this issue, I'll point out that Vite doesn't have any problems with solving circular dependencies, but the plugin apparently does. You can verify this if you remove the useViteFederation function call from the vite.config.js remote project (the plugin instance is created there) and restart the dev:remote script. You will see that the project is built and served without problems

@sirAbramstone I think this issue will take quite a bit of time. Sorry, but I won’t be able to look at it until next week.

Although I’m not sure if it will work, you might try shared: ["npmpkg/"]


Modify historical returns to allow compounding

Hi @robertmartin8,
This PR resolves #85
I have manually tested the code comprehensively with a wide range of values but have not been able to use pytest for the same because of some encoding errors that kept popping up on my system.
Since this was a relatively small fix, I have made the PR on the basis of this manual testing itself.

@gauravsofat
Thanks for the initial PR! I am going to need to test your code on my local machine. In particular, I am interested to know how the performance of your lambda compares with direct operation on the pandas series
result = (1+returns.mean())**frequency

I will figure it out, add a test, and push it along with a bunch of other changes that I am making. Will credit you somewhere in the docs :)

Thanks guys, I completely agree with your suggestions. Closing this PR in accordance with the same.


us default eval query if no query is specified in rel def

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

relationship.GetDefaultEvaluationQuery undefined (type "github.com/layer5io/meshkit/models/meshmodel/core/v1alpha2".RelationshipDefinition has no field or method GetDefaultEvaluationQuery)

relationship.GetDefaultEvaluationQuery undefined (type "github.com/layer5io/meshkit/models/meshmodel/core/v1alpha2".RelationshipDefinition has no field or method GetDefaultEvaluationQuery)

depends on mesh kit release, have some PRs in mesh kit will release the library and bump in meshery


PLAT-8636-use-internal-docker-mirror

Closes PLAT-8636.

superseded by https://wahanda.atlassian.net/browse/PLAT-8715


Python scripts do not work. PythonAPI CARLA 0.9.6 in Docker

Hi. I am using CARLA 0.9.6 + Apollo 5.0 in Docker from this tutorial: https://github.com/AuroAi/carla_apollo_bridge
ubuntu 20.04
I am not being able to run the python scripts which modify the simulator scenario , the script **python examples/spawn_npc.py -n 50 --host <IP_ADDRESS>" for example returns me the following error:
destroying 0 vehicles
done.
Traceback (most recent call last):
  File "spawn_npc.py", line 205, in <module>
    main()
  File "spawn_npc.py", line 192, in main
    client.apply_batch([carla.command.DestroyActor(x) for x in vehicles_list])
RuntimeError: rpc::timeout: Timeout of 20000ms while connecting to localhost:2000

I have already changed the port to 2001, 2002 nothing happens. I have also tried to change the client timeout, increasing to 10.0 and even to 200.000 and get the same error.
I am sure it is not a machine calculation issue (lack of CPU) because I am running in a very powerful machine in the cloud (AWS)
I have also launched the script:
python util/config.py -m Town04 --host <IP_ADDRESS>
The town changes, however not before the simulator (pygame) crashes and close, when open again the simulator changed.
I have already checked the network communication, and my localhost is receiving data from carla-server simulator IP:

In addition the port 2000 seems to be released, not blocked:

Is it a docker issue? I have runned the CARLA server container with all authorization possible flags:
docker run  -it --rm  --privileged -v /tmp/.X11-unix:/tmp/.X11-unix:rw -v /usr/lib/nvidia:/usr/lib/nvidia --device /dev/dri -e SDL_VIDEO_GL_DRIVER= libGL.so.1.7.0 -e DISPLAY=$DISPLAY -e NVIDIA_VISIBLE_DEVICES=all -e  NVIDIA_DRIVER_CAPABILITIES=all --gpus=all --name=carla-server --net=host -d carlasim/carla:0.9.6
Can someone help ?
thanks in advance...

1-The port <IP_ADDRESS> instead the grep command say that is the right-one or my docker (carla-server), actually is not.
2- Set the timeout to 20.0
3- Used localhost and port 2000
My examples/spawn.py file
`#!/usr/bin/env python
Copyright (c) 2019 Computer Vision Center (CVC) at the Universitat Autonoma de
Barcelona (UAB).

This work is licensed under the terms of the MIT license.
For a copy, see https://opensource.org/licenses/MIT.
"""Spawn NPCs into the simulation"""
import glob
import os
import sys
try:
sys.path.append(glob.glob('../carla/dist/carla-*%d.%d-%s.egg' % (
sys.version_info.major,
sys.version_info.minor,
'win-amd64' if os.name == 'nt' else 'linux-x86_64'))[0])
except IndexError:
pass
import carla
import argparse
import logging
import random
def main():
argparser = argparse.ArgumentParser(
description=doc)
argparser.add_argument(
'--host',
metavar='H',
default='localhost',
help='IP of the host server (default: localhost)')
argparser.add_argument(
'-p', '--port',
metavar='P',
default=2000,
type=int,
help='TCP port to listen to (default: 2000)')
argparser.add_argument(
'-n', '--number-of-vehicles',
metavar='N',
default=10,
type=int,
help='number of vehicles (default: 10)')
argparser.add_argument(
'-w', '--number-of-walkers',
metavar='W',
default=50,
type=int,
help='number of walkers (default: 50)')
argparser.add_argument(
'--safe',
action='store_true',
help='avoid spawning vehicles prone to accidents')
argparser.add_argument(
'--filterv',
metavar='PATTERN',
default='vehicle.',
help='vehicles filter (default: "vehicle.")')
argparser.add_argument(
'--filterw',
metavar='PATTERN',
default='walker.pedestrian.',
help='pedestrians filter (default: "walker.pedestrian.")')
args = argparser.parse_args()
logging.basicConfig(format='%(levelname)s: %(message)s', level=logging.INFO)

vehicles_list = []
walkers_list = []
all_id = []
client = carla.Client(args.host, args.port)
#client = carla.Client('localhost', 2000)
client.set_timeout(20.0)

try:

    world = client.get_world()
    blueprints = world.get_blueprint_library().filter(args.filterv)
    blueprintsWalkers = world.get_blueprint_library().filter(args.filterw)

    if args.safe:
        blueprints = [x for x in blueprints if int(x.get_attribute('number_of_wheels')) == 4]
        blueprints = [x for x in blueprints if not x.id.endswith('isetta')]
        blueprints = [x for x in blueprints if not x.id.endswith('carlacola')]

    spawn_points = world.get_map().get_spawn_points()
    number_of_spawn_points = len(spawn_points)

    if args.number_of_vehicles < number_of_spawn_points:
        random.shuffle(spawn_points)
    elif args.number_of_vehicles > number_of_spawn_points:
        msg = 'requested %d vehicles, but could only find %d spawn points'
        logging.warning(msg, args.number_of_vehicles, number_of_spawn_points)
        args.number_of_vehicles = number_of_spawn_points

    # @todo cannot import these directly.
    SpawnActor = carla.command.SpawnActor
    SetAutopilot = carla.command.SetAutopilot
    FutureActor = carla.command.FutureActor

    # --------------
    # Spawn vehicles
    # --------------
    batch = []
    for n, transform in enumerate(spawn_points):
        if n >= args.number_of_vehicles:
            break
        blueprint = random.choice(blueprints)
        if blueprint.has_attribute('color'):
            color = random.choice(blueprint.get_attribute('color').recommended_values)
            blueprint.set_attribute('color', color)
        if blueprint.has_attribute('driver_id'):
            driver_id = random.choice(blueprint.get_attribute('driver_id').recommended_values)
            blueprint.set_attribute('driver_id', driver_id)
        blueprint.set_attribute('role_name', 'autopilot')
        batch.append(SpawnActor(blueprint, transform).then(SetAutopilot(FutureActor, True)))

    for response in client.apply_batch_sync(batch):
        if response.error:
            logging.error(response.error)
        else:
            vehicles_list.append(response.actor_id)

    # -------------
    # Spawn Walkers
    # -------------
    # 1. take all the random locations to spawn
    spawn_points = []
    for i in range(args.number_of_walkers):
        spawn_point = carla.Transform()
        loc = world.get_random_location_from_navigation()
        if (loc != None):
            spawn_point.location = loc
            spawn_points.append(spawn_point)
    # 2. we spawn the walker object
    batch = []
    for spawn_point in spawn_points:
        walker_bp = random.choice(blueprintsWalkers)
        # set as not invencible
        if walker_bp.has_attribute('is_invincible'):
            walker_bp.set_attribute('is_invincible', 'false')
        batch.append(SpawnActor(walker_bp, spawn_point))
    results = client.apply_batch_sync(batch, True)
    for i in range(len(results)):
        if results[i].error:
            logging.error(results[i].error)
        else:
            walkers_list.append({"id": results[i].actor_id})
    # 3. we spawn the walker controller
    batch = []
    walker_controller_bp = world.get_blueprint_library().find('controller.ai.walker')
    for i in range(len(walkers_list)):
        batch.append(SpawnActor(walker_controller_bp, carla.Transform(), walkers_list[i]["id"]))
    results = client.apply_batch_sync(batch, True)
    for i in range(len(results)):
        if results[i].error:
            logging.error(results[i].error)
        else:
            walkers_list[i]["con"] = results[i].actor_id
    # 4. we put altogether the walkers and controllers id to get the objects from their id
    for i in range(len(walkers_list)):
        all_id.append(walkers_list[i]["con"])
        all_id.append(walkers_list[i]["id"])
    all_actors = world.get_actors(all_id)

    # wait for a tick to ensure client receives the last transform of the walkers we have just created
    world.wait_for_tick()

    # 5. initialize each controller and set target to walk to (list is [controler, actor, controller, actor ...])
    for i in range(0, len(all_id), 2):
        # start walker
        all_actors[i].start()
        # set walk to random point
        all_actors[i].go_to_location(world.get_random_location_from_navigation())
        # random max speed
        all_actors[i].set_max_speed(1 + random.random())    # max speed between 1 and 2 (default is 1.4 m/s)

    print('spawned %d vehicles and %d walkers, press Ctrl+C to exit.' % (len(vehicles_list), len(walkers_list)))

    while True:
        world.wait_for_tick()

finally:

    print('\ndestroying %d vehicles' % len(vehicles_list))
    client.apply_batch([carla.command.DestroyActor(x) for x in vehicles_list])

    # stop walker controllers (list is [controler, actor, controller, actor ...])
    for i in range(0, len(all_id), 2):
        all_actors[i].stop()

    print('\ndestroying %d walkers' % len(walkers_list))
    client.apply_batch([carla.command.DestroyActor(x) for x in all_id])

if name == 'main':
try:
    main()
except KeyboardInterrupt:
    pass
finally:
    print('\ndone.')`

4 -I have cyber/setup.bash file I changed again from IP: <IP_ADDRESS> to <IP_ADDRESS>
5 - Sourced the bashrc
6- runner:
python examples/spawn_npc.py -n 50 --host <IP_ADDRESS>
Finally worked:


Incremental source generator for actors

Description
Converted the Actor source generator into an IncrementalSourceGenerator to ease the future definition of new generation pipeline for other objects (E.g: https://github.com/dapr/dotnet-sdk/issues/1305#issuecomment-2234152155)
It also add a null check for actorProxy parameter passed in generated Actor ctor, definition of AnalyzerReleases.Shipped.md and AnalyzerReleases.Unshipped.md diagnostics, remove deprecated nugets.
Issue reference
_
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@KrylixZA really thank for taking time to review my pr.

@WhitWaldo I have resolved the conflicts with the Master, do you have time to look at this branch?


Added "-subset". Fixes #105

The "-subset" option allows a lerger tree to be compared to a smaller tree by excluding individuals that only exist on the left side.
Hide individuals that are the same in the gedcomdiff index.
Show the birth/death dates of individuals for their headings in case all of that vital information does not show below.

This change is

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   91.72%   91.72%
=======================================
  Files          28       28
  Lines        1172     1172
=======================================
  Hits         1075     1075
  Misses         86       86
  Partials       11       11

Impacted Files
Coverage Δ

date_node.go
89.36% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5eee92...56774c4. Read the comment docs.


dont use MVector

Codecov Report

Merging #193 (45e8a2f) into main (4223b45) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   89.97%   89.97%
=======================================
  Files          40       40
  Lines        1067     1067
=======================================
  Hits          960      960
  Misses        107      107

Impacted Files
Coverage Δ

src/Materials/IsotropicLinearElastic.jl
100.00% <ø> (ø)

src/StructuralAnalyses/StaticState.jl
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Question: whats the best way to have same environment outside of appcenter?

We are running builds in Appcenter, and it is a container that has following installed: https://github.com/actions/virtual-environments/blob/master/images/macos/macos-10.15-Readme.md
For the sake of verifiable/reproducible builds, how do we prepare same environment outside of Appcenter? I suppose there is no dockerfile for it, but is it available as image on Azure cloud?

Hello,
Yep, App Center uses this image to run builds.
You can use Azure DevOps  or GitHub Actions to run builds on the same environment. You just need to specify macos-10.15 image in your pipeline. See related documentation how it can be done.
As for the running same environment outside Azure DevOps and GitHub Actions. Unfortunately, we don't upload this image to Azure Cloud due to legal issues.

@maxim-lobanov thanks!
Say, if I have a laptop with macOS 10.15, is there a script that installs this software..?

Unfortunately, not. Source code for MacOS image-generation is not public yet. We are planning to open source it soon but no ETA for now. You can track the updates via #774


docs(RELEASE.md): switch to 3 releases per year

What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR updates the RELEASE.md doc reflecting the new release cycle as discussed by Falco's maintainers.
Starting from now, we plan to release 3 times per year.
Thanks to @fntlnz @leodido @kris-nova @mstemm
/milestone 0.30.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


polymc: Fix hash

i forgor 💀
Maintainer edit: Follow-up to https://github.com/Calinou/scoop-games/pull/594.

I fixed the hash in https://github.com/Calinou/scoop-games/commit/1ee29be845a7993e78532818dd13b136d686d9dc, should be good to go now.


Add pyproject.toml for Custom Node Registry

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:

[ ] Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
[ ] Write a short the description.
[ ] Merge the separate Github Actions PR and run the workflow.
If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

hey @tudal, wanted to send a small nudge and ask if you had any questions!

@tudal, wondering if there's any way we can support you on this PR!


Can any1 tell me, how get notification automatically whenever i upload a document of Firebase Storage

Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository file a Github issue.

If you are filing an issue about FCM in the background make sure to read #4 and #89 first!

For general technical questions, post a question on StackOverflow tagged appropriately.
For general Firebase discussion, use the firebase-talk google group
For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel

Step 2: Describe your environment

Android device: _____
Android OS version: _____
Google Play Services version: _____
Firebase/Play Services SDK version: _____

Step 3: Describe the problem:
Steps to reproduce:

Observed Results:

What happened?  This could be a description, logcat output, etc.

Expected Results:

What did you expect to happen?

Relevant Code:
// TODO(you): code here to reproduce the problem

@anki29 closing this since there is no information in the issue template.
Check out Cloud Functions and set up a trigger based on Cloud Storage.