Allow extending eclipsehelp

Description
currently you check
INDEX_TYPE_ECLIPSEHELP.equals(transtype)
and
transtype.equals(INDEX_TYPE_ECLIPSEHELP)
but then if I create my eclipsehelp plugin, transtype becomes my_eclipsehelp and suddenly a lot of features are disabled
Possible Solution
     transtype.contains(INDEX_TYPE_ECLIPSEHELP)

Sorry, misunderstood. Thought the issue was with plug-in–specific code. Restored.

thank you :)

added a pull request to clarify what I mean :)
it's my first so if you have any comments, please share


Colored Internal terminal

Nice extension, just need support colors in the window like internal terminal for vs, this help a lot for watched tasks like webpack watch

I'm not sure Visual Studio API allows you to color the output. If you find something I'm open to suggestion !


Apply type auto guessing feature to datasource ingestion

Is your feature request related to a problem? Please describe.
When I import a CSV file in dataprep, the column types are automatically set by appropriate rules. I wish the datasource ingestion have the same behavior.
Describe the solution you'd like
Add the same feature. (hopefully reuse the data preparation's code)
Moreover, the role of the columns (dim/measure) might be set automatically too.
I suggest that the numeric columns to be measures by default.
IMPORTANT : Mis-guessing is not a big pain for dataprep because you can change the rule or add another rule to fix it, but for datasource ingestion, it could be troublesome, for example, if the data have lots of number-like codes. So I suggest a checkbox that controls the auto type conversion feature.
Describe alternatives you've considered
After implementing the metadata management feature (TBD), the types in the metadata should override the guess.
Additional context
Related code is in PrepDatasetFileService.getResponseMapFromCsv().

@joohokim1 I would like to move the common guessing logic in PrepDatasetFileService.getResponseMapFromCsv() to the common package.

@kyungtaak I'll find the way when we work on this issue later.


Store coming module in logger class

May be helpful

Closed after PR - https://github.com/serengil/LightPHE/pull/14


Autorest Regen Preview to 3.0.0-alpha.20240228.4 by Michael Nash from refs/pull/4298/head

Triggered from https://github.com/Azure/autorest.csharp/pull/4298

API change check
API changes are not detected in this pull request.


Schema validation failed: Data path "" should NOT have additional properties

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Area
- [ ] devkit
- [x] schematics

Versions
Angular CLI: 6.0.8
Node: 8.11.2
OS: win32 x64
Angular: 6.0.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.8.3

Repro steps

Add projects/architect/<section>/options/invalid options to options in angular.json eg"build": {
       "builder": "@angular-devkit/build-angular:browser",
       "options": {
         "invalid": "value",
         ...
       }
}

Run ng build

Actual functionality
Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(invalid).

Desired functionality
Schema validation failed with the following errors:
  Data path "path/to/invalid/option" should NOT have additional properties(invalid).

I have a kind a similar issue but when I run ng serve  :
Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(watch).

Furthermore there is no watch property in my angular.json
packages version of my project :
Angular CLI: 6.0.8
Node: 10.1.0
OS: darwin x64
Angular: 6.0.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.8
@angular-devkit/build-angular      0.6.8
@angular-devkit/build-ng-packagr   0.6.8
@angular-devkit/build-optimizer    0.6.8
@angular-devkit/core               0.6.8
@angular-devkit/schematics         0.6.8
@angular/cdk                       6.3.2
@angular/cli                       6.0.8
@angular/material                  6.3.2
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.8
@schematics/angular                0.6.8
@schematics/update                 0.6.8
ng-packagr                         3.0.3
rxjs                               6.2.1
typescript                         2.7.2
webpack                            4.8.3

Confirming the issue, getting the following error
Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(port).

Though in my case I really specified nonexistent  property, it would be nice for angular-cli to refer to it correctly.
PS: package versions
Angular CLI: 6.0.8
Node: 10.9.0
OS: darwin x64
Angular: 6.1.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.3.0
typescript                        2.7.2
webpack                           4.8.3

So it looks like the npm package is out of date compared to master.  The npm package is on 0.0.2 and the github repo version is 1.0.0.  I installed it using the yarn add -D isaacplmann/ngx-cypress-builder#master but am now getting Could not find module "ngx-cypress-builder" because I don't think the files are compiled.  @isaacplmann might help if we get the npm package udpated.

@jordandlaman why are you commenting on this issue?  If you run into a problem with ngx-cypress-builder, file an issue here:
https://github.com/isaacplmann/ngx-cypress-builder

@ernie58 I would have responded a lot faster, if you filed an issue directly on my repo

Was just trying to point people in the right direction.  That was the second thing I was going to do.  Issue filed.

Sorry, thanks.  I'll take a look.

Check if your apps angular.json file is valid and any changes you made to that file are correct

Check if your apps angular.json file is valid and any changes you made to that file are correct

For anyone having this problem while updating Ionic from 3 to 4: I had to remove "es5BrowserSupport": true from angular.json

Schema validation failed with the following errors:
[ng]   Data path "" should NOT have additional properties(es5BrowserSupport).
[ERROR] ng has unexpectedly closed (exit code 1).

For anyone having this problem while updating Ionic from 3 to 4: I had to remove "es5BrowserSupport": true from angular.json

But if I'm removing that I'm getting the below error
[ng]
[ng] Error: tsconfig.json(18,7): error TS6046: Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'esnext', 'dom', 'dom.iterable', 'webworker', 'scripthost', 'es2015.core', 'es2015.collection', 'es2015.generator', 'es2015.iterable', 'es2015.promise', 'es2015.proxy', 'es2015.reflect', 'es2015.symbol', 'es2015.symbol.wellknown', 'es2016.array.include', 'es2017.object', 'es2017.sharedmemory', 'es2017.string', 'es2017.intl', 'esnext.asynciterable'.
[ng]     at AngularCompilerPlugin._setupOptions (D:\ionic-pdf-master4\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:108:19)
[ng]     at new AngularCompilerPlugin (D:\ionic-pdf-master4\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:61:14)
[ng]     at _createAotPlugin (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\src\angular-cli-files\models\webpack-configs\typescript.js:41:12)
[ng]     at Object.getNonAotConfig (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\src\angular-cli-files\models\webpack-configs\typescript.js:47:19)
[ng]     at BrowserBuilder.buildWebpackConfig (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\src\browser\index.js:82:37)
[ng]     at DevServerBuilder.buildWebpackConfig (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\src\dev-server\index.js:111:46)
[ng]     at MergeMapSubscriber.check_port_1.checkPort.pipe.operators_1.concatMap [as project] (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\src\dev-server\index.js:38:40)
[ng]     at MergeMapSubscriber._tryNext (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\operators\mergeMap.js:69:27)
[ng]     at MergeMapSubscriber._next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\operators\mergeMap.js:59:18)
[ng]     at MergeMapSubscriber.Subscriber.next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\Subscriber.js:66:18)
[ng]     at TapSubscriber._next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\operators\tap.js:65:26)
[ng]     at TapSubscriber.Subscriber.next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\Subscriber.js:66:18)
[ng]     at MergeMapSubscriber.notifyNext (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\operators\mergeMap.js:92:26)
[ng]     at InnerSubscriber._next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\InnerSubscriber.js:28:21)
[ng]     at InnerSubscriber.Subscriber.next (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\Subscriber.js:66:18)
[ng]     at Object.complete (D:\ionic-pdf-master4\node_modules\@angular-devkit\build-angular\node_modules\rxjs\internal\observable\forkJoin.js:57:40)

[ERROR] ng has unexpectedly closed (exit code 1).

I posted a fix to a similar schema validation error in #14338
Based on these two answers on StackOverflow also related to schema validation errors :

https://stackoverflow.com/q/56542518/8245387
https://stackoverflow.com/a/56537342/8245387

Updated package.json from "@angular-devkit/build-angular": "^0.800.1" to "^0.12.4"
Run npm install

See if that works.

Please note that 0.12.4 is significantly older than 0.800.1.

Having similar kind of problem:
ng e2e
An unhandled exception occurred: Schema validation failed with the following errors:
  Data path ".projects['log-server-js']" should NOT have additional properties(i18n).
See "C:\Users\Felian\AppData\Local\Temp\ng-vHDlEJ\angular-errors.log" for further details.

where log-server-js is a project name and angular.json have addition for i18n:
"projects": {
    "log-server-js": {
      "projectType": "application",
      "schematics": {},
      "root": "",
      "sourceRoot": "src",
      "prefix": "app",
      "i18n": {
        "sourceLocale": "en-US",
        "locales": {
          "ru": "src/locale/messages.ru.xlf"
        }
      },
...

How to make it work?

check your project and is equal to defaultProject in angular.json

Apart from the error message not telling WHERE the problem is, it does tell you WHAT the problem is. I fixed one error and it gave me the next, which I fixed and so on.
Angular 11 with latest packages including "@angular-devkit/build-angular": "^0.1100.2"
For me it was my angular.json e2e lint where I had to change
from this
                "lint": {
                    "builder": "@angular-eslint/builder:lint",
                    "options": {
                        "tsConfig": "e2e/tsconfig.e2e.json",
                        "exclude": ["**/node_modules/**"]
                    }
                }

to this
                "lint": {
                    "builder": "@angular-eslint/builder:lint",
                    "options": {
                        "lintFilePatterns": ["e2e/**/*.ts", "e2e/**/*.html"]
                    }
                }

I cant set allowedCommonJsDependencies as described here: https://angular.io/guide/build#configuring-commonjs-dependencies :

Schema validation failed with the following errors:
Data path "" should NOT have additional properties(allowedCommonJsDependencies).

Version:
Angular CLI: 11.2.3
Node: 15.6.0
OS: darwin x64

Angular: 11.2.4
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1102.3
@angular-devkit/build-angular   0.1102.3
@angular-devkit/core            11.2.3
@angular-devkit/schematics      11.2.3
@angular/cli                    11.2.3
@schematics/angular             11.2.3
@schematics/update              0.1102.3
ng-packagr                      11.2.4
rxjs                            6.6.3
typescript                      4.0.7

In angular.json I had:
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html"
            ],
            "tsConfig": [
              "projects/px-visualizations/tsconfig.lib.json",
              "projects/px-visualizations/tsconfig.spec.json"
            ],
            "exclude": [
              "**/node_modules/**"
            ]
          }

and got

Schema validation failed with the following errors:
Data path "" should NOT have additional properties(tsConfig).

After upgrading from tslint to eslint. Luckely I was able to find this change in source control. It would be really helpful for the error to explain which invalid items are the issue.
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html"
            ]
          }

Fixed it. But I had no way other than guessing and reviewing source control to determine what the issue was.

I cant set allowedCommonJsDependencies as described here: https://angular.io/guide/build#configuring-commonjs-dependencies :

Schema validation failed with the following errors:
Data path "" should NOT have additional properties(allowedCommonJsDependencies).

Version:
Angular CLI: 11.2.3
Node: 15.6.0
OS: darwin x64

Angular: 11.2.4
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1102.3
@angular-devkit/build-angular   0.1102.3
@angular-devkit/core            11.2.3
@angular-devkit/schematics      11.2.3
@angular/cli                    11.2.3
@schematics/angular             11.2.3
@schematics/update              0.1102.3
ng-packagr                      11.2.4
rxjs                            6.6.3
typescript                      4.0.7

Has same error when using as builder angular-builders/custom-webpack:dev-server or angular-builders/custom-webpack:browser

Same error. Fixed by change schematics in angular.json
was
     "schematics": {         "@schematics/angular:component": {             "prefix": "app",             "styleext": "css"         },         "@schematics/angular:directive": {             "prefix": "app"         }     }
now
    "schematics": {         "@schematics/angular:component": {             "prefix": "app"         },         "@schematics/angular:directive": {             "prefix": "app"         }     }
it was mistake in word "styleext" - Intellij idea complain and highlight it. So after fix command : "ng g c component --skip-tests" became works properly

In angular.json I had:
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html"
            ],
            "tsConfig": [
              "projects/px-visualizations/tsconfig.lib.json",
              "projects/px-visualizations/tsconfig.spec.json"
            ],
            "exclude": [
              "**/node_modules/**"
            ]
          }

and got

Schema validation failed with the following errors:
Data path "" should NOT have additional properties(tsConfig).

After upgrading from tslint to eslint. Luckely I was able to find this change in source control. It would be really helpful for the error to explain which invalid items are the issue.
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html"
            ]
          }

Fixed it. But I had no way other than guessing and reviewing source control to determine what the issue was.

I agree with @tamusjroyce above that the resolution to any error like this, is to simply remove declaring the variable that is being complained about in the source control in between the round brackets.
E.g., the error for me was as follows:
Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(exclude).

This means that the property defined an a JSON object titled exclude in angular.json (as noted below) is invalid like so:
<project>/angular.json:
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html"
            ],
            "exclude": [
              "**/node_modules/**"
            ]
          }
        }

Removing the exclude definition, after my project was converted from using TSlint to ESLint, resolved the error message. Similar is to be said for issues other people had with other properties above like tsconfig or allowedCommonJsDependencies  or es5BrowserSupport.
Cheers! :)

I had the same issue and for me the fix was to remove the buildOptimizer, vendorChunk from the build.configurations in angular.json.
So this:
"development": {
    "buildOptimizer": false,
    "vendorChunk": true,
    "optimization": false,
    "extractLicenses": false,
    "sourceMap": true,
    "namedChunks": true
}

Becomes this:
"development": {
    "optimization": false,
    "extractLicenses": false,
    "sourceMap": true,
    "namedChunks": true
}


Update to Kubernetes v1.11.1

Update to Kubernetes v1.11.1
Make next upgrades easier using variables for versions numbers.
Improve a couple of upgrade related bugs

At the moment upgrading from v1.10.x will not work because of:
https://github.com/kubernetes/kubernetes/issues/65863#issuecomment-403038727
But it is possible to start a fresh v1.11.1 cluster.
We have to implement in the playbook this stuff:
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-11/

@ctrlaltdel I wrote an upgrade playbook and I managed to upgrade successfully from v1.10.3 to v1.11.1
However please test this before merging because I really need a review of this upgrade procedure. Also @RdL87 might be interested in testing this upgrade procedure.
I confirm fresh installation of v1.11.1 just works.


Add open_request_count/1

We could add a function that returns the number of open (in-flight) requests. In HTTP/1 this tells the number of pipelined requests. In HTTP/2 this tells the number of open streams and is useful for either checking how many streams you can open and also for testing that we close streams correctly without using the internal structure of the connection in tests.

@ericmj how can we do this in HTTP/2, where we have both client-initiated streams and server-initiated streams? The spec says that only client-initiated streams count towards the server max concurrent streams limit, so I think users would mostly be interested in that. But maybe we should make the count of server-initiated streams accessible too?

Yeah, should make both available or document that it is only for client initiated requests.

@ericmj any preference? I think I would go with client-initiated only for now, given that's the semantics of HTTP/1 and given that clients probably won't care about how many server-initiated requests there are since it doesn't affect how many the clients can open.

Sounds good.


Add accessibility features

When notie is presenting any variation of alert, user should be able to tab through the buttons/inputs.

I see that this was opened in 2018, has there been any updates?


Editing a patient in a different facility moves the patient to the new Facility

Background
This may be a bug introduced when adding facility ids in the urls
Original PR: https://github.com/CDCgov/prime-simplereport/pull/342
Original issue: https://github.com/CDCgov/prime-simplereport/pull/342
Bug (sorry for the potato quality, github only supports 10mb uploads)

Steps to Recreate (you can try it in the demo app)

Go to People and select a patient to edit
While on the edit page, change the facility in the dropdown in the header
Bug 1: you still can edit the patient despite being in a different facility. This is a side effect of the hack
If you edit the patient and press save, a success alert appears (not shown in the above gif). You are redirected to the people page of the facility you changed to
Bug 2: if you change back to the original facility and go to people, the patient is gone.

Probably existed before: https://github.com/CDCgov/prime-simplereport/blob/main/frontend/src/app/patients/PatientForm.jsx#L164

Currently we associate people with a facility by the drop down in the header.  It is an unexpected behavior to have the dropdown in the header effect the person form

this seems closely tied to https://github.com/CDCgov/prime-simplereport/issues/404

@katiealoisi @hmyers-cms  can we add a quick UI fix to the edit patient page? I'm thinking something like a drop down that let's you select:
All Faciliites
Facility Name 1
Facility Name 2
Facility Name 3
So it's clear you can only select one option, and the person is either at all facilities or only one (this is a technical limitation for now.)

Engineering ready prototype is now updated, and here is a screenshot for good measure

related backend work: https://github.com/CDCgov/prime-simplereport/issues/452

@hmyers-cms @aliciabeckett-gov Some questions and confirmations:

When creating a new patient, what should the facility be set to? The current facility, or something like "- Select -" to require a positive choice?
The shot Heather posted above shows "all facilities", I think that may be a feature that's hard to implement. Maybe @timothybest-usds and I can work out how that would be implemented in the backend, but other than setting that field to null I can't think of an easy value to use. You could get pretty close by creating a facility that included any roving employees. Also if we have a magic group that doesn't belong to a facility i'm not sure when we'd display those, do all facilities get to see those people and their tests?

@hmyers-cms @aliciabeckett-gov Some questions and confirmations:

When creating a new patient, what should the facility be set to? The current facility, or something like "- Select -" to require a positive choice?

Something like "-Select-" and require a positive choice.

The shot Heather posted above shows "all facilities", I think that may be a feature that's hard to implement. Maybe @timothybest-usds and I can work out how that would be implemented in the backend, but other than setting that field to null I can't think of an easy value to use. You could get pretty close by creating a facility that included any roving employees. Also if we have a magic group that doesn't belong to a facility i'm not sure when we'd display those, do all facilities get to see those people and their tests?

I believe we agreed a person can either be at one facility, or at all facilities on the backend. @benwarfield-usds and @TimBest to confirm.

It is correct that the current data model only supports a person belonging to a facility (facilityId equals the facility id)or all facilities (facilityId = null)

It is correct that the current data model only supports a person belonging to a facility (facilityId equals the facility id)or all facilities (facilityId = null)

@timothybest-usds @hmyers-cms I have some questions about this. The Type and Facility are both marked optional. At the moment we only allow Staff to use the All Facilities choice. It brings up some strange situations that I don't think we've defined.
At this very instant the PR has both as being required and only Staff can be All Facilities. Is that okay? The most lenient thing I can think of would be that we don't need to know Type (it would indeed be optional) and we assign a person to All Facilities by default.

@timothybest-usds @hmyers-cms I have some questions about this. The Type and Facility are both marked optional. At the moment we only allow Staff to use the All Facilities choice. It brings up some strange situations that I don't think we've defined.
At this very instant the PR has both as being required and only Staff can be All Facilities. Is that okay? The most lenient thing I can think of would be that we don't need to know Type (it would indeed be optional) and we assign a person to All Facilities by default.

I think we should remove the Staff restriction and go with the most lenient option. I think the staff rule applies to Via Elegenate but probably doesn't makes sense for a school where a student can visit any facility

I think we should remove the Staff restriction and go with the most lenient option. I think the staff rule applies to Via Elegenate but probably doesn't makes sense for a school where a student can visit any facility

Another option would be to assign them to the current facility by default but allow them to change it. In general I'd prefer the approach that minimizes clicks without encouraging mistakes but that's better called by @hmyers-cms .

Another option would be to assign them to the current facility by default but allow them to change it. In general I'd prefer the approach that minimizes clicks without encouraging mistakes but that's better called by @hmyers-cms .

Heather and I talked on Slack. For now at least:

Facility is required and Patient Type is optional.
Any Patient Type can be assigned to All Facilities.
No default for Facility, they need to affirmatively choose one.

Heather and I talked on Slack. For now at least:

Facility is required and Patient Type is optional.
Any Patient Type can be assigned to All Facilities.
No default for Facility, they need to affirmatively choose one.

@hmyers-cms we should think about what default we want if there's a batch CSV upload of new users for a new site, or a user is self registering.

@hmyers-cms we should think about what default we want if there's a batch CSV upload of new users for a new site, or a user is self registering.


[SPIKE] Scope work to integrate Nominatim search for searching on the map

Summary
We would like to integrate BOTH a free/open source search component and a more robust search component into the CEJST map. We should scope the work to integrate Nominatim and another to be determined paid service. We would plan on making the paid search available on the CEJST public site.
Here is the research done to date on options:
https://github.com/usds/justice40-tool/issues/402
Dev Tasks
What will trigger the app to switch from one solution to the other?
API

[x] understand query params and options for sending data to Nominatum API
[ ] understand various ways the return data can be sent
[ ] data-fetch client investigation, axios vs swr vs fetch vs react-query

Search UI component

[x] display the search field
[x] truss has a search component with intl - limited options on what to display
[x] can trigger action on search
[ ] trigger Nominatum on search
[ ] intl search button text (if that UI component is chosen)
[ ] search should be disabled if service is down via /status endpoint
[ ] loading screen? nice to have
[ ] typeahead? nice to have
[ ] cache historical searches? nice to have

Map

[x] pan map pan based on lat/long
[ ] pans based on search

Tasks
API

[ ] understand query params and options for sending data to Nominatum API
[ ] understand various ways the return data can be sent

Search UI component

[ ] display the search field
[ ] typeahead? Make this optional
[ ] truss has a search component with intl

Map

[ ] once payload is received how should the map pan to results?

I also like the small variant option.
For placeholder text, I would suggest "Find address or place"
As for the query versus structured search, @katherinedm-usds has a good list of search terms that we can test and compare results.
@KameronKerger @glennettec @katherinedm-usds open to discussion on this, obvs.


emul: emul_bmi160: Remove unused bus_label

The bus_label is not used and is using DT_INST_BUS_LABEL which is
now deprecated and thus causes an error when running CI.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Note: Simon isn't available. I'd recommend @yperess


Only call GetSecret on secrets which are not disable

KeyVaultClient throws when calling GetSecret on a secret ID which is disabled.
Need to guard against this case in Provider load
added enabled=True attributes to all current tests
added test case to ensure secret with null attributes, or null or false disabled value is ignored

Addresses #771

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Clean Code]: add type aliases instead of plain 'string' types

Is your feature request related to a problem? Please describe.
When reading the code and especially the type declarations in meta/types it's quite difficult to follow the logic for example:
type RepoMetadata struct {
	Name string
	Tags map[string]Descriptor

	Statistics map[string]DescriptorStatistics
        ...
}

It's not trivial to understand what the string for Tags map[string]Descriptor or Statistics map[string]DescriptorStatistics refers to.
Describe the solution you'd like
We can use this Go feature to declare a type alias:
type RepoName       = string
type ManifestDifest = string

[!IMPORTANT]
To not be confused with the type declaration:
type RepoName string

This solution comes with 0 cost, it's just a code documentation feature.
Describe alternatives you've considered
No response
Additional context
No response

Fixed in #2043


Example using spread operator on object literals

Attached is my Hacktoberfest contribution (from Quincy Larson's article).

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you @fcarlone  for your contribution and congratulations on your first PR merge to this repo! 🎉


NetFilter basic tunning

Hello, we are enabling NetFilter on compute nodes in following conf file:
https://github.com/OpenNebula/one/blob/master/share/etc/sysctl.d/bridge-nf-call.conf
Will be good to include some basic netfilter tunning, because on hight traffic sites netfilter is bottleneck and I consider virt-host as high traffic. So what about including some shorter tcp timeouts?
Something like this?
# default 10
net.netfilter.nf_conntrack_tcp_timeout_close = 1

# default 60
net.netfilter.nf_conntrack_tcp_timeout_close_wait = 6

# default 432000
net.netfilter.nf_conntrack_tcp_timeout_established = 600

# default 120
net.netfilter.nf_conntrack_tcp_timeout_fin_wait = 12

# default 30
net.netfilter.nf_conntrack_tcp_timeout_last_ack = 3

# default 300
net.netfilter.nf_conntrack_tcp_timeout_max_retrans = 30

# default 60
net.netfilter.nf_conntrack_tcp_timeout_syn_recv = 6

# default 120
net.netfilter.nf_conntrack_tcp_timeout_syn_sent = 12

# default 120
net.netfilter.nf_conntrack_tcp_timeout_time_wait = 12

# default 300
net.netfilter.nf_conntrack_tcp_timeout_unacknowledged = 30

Hi feldsam,
I think this is a good suggestion, however not sure about doing this by default. I'm going to move this issue to the documentation, and include this hints in the network/tunning guides

makes sense


Move dates to comment body

By moving the dates to the comment body, they're always displayed. At the moment, they're only displayed if the user turns on "Show all events".
This also includes a refactoring to use the TimeConstraint code for ContentAdviceRequests, which builds on the first commit. This second bit could be split off if needed.

@benilovj quite right - see https://github.com/alphagov/gds_zendesk/pull/23


ListTile Background Color Appears outside of ListView bounds.

When setting **tileColor** for a **ListTile** Widget, the **tileColor** appears outside the **ListView** bounds, on top of any neighboring Widget that doesn't have a **backgroundColor**.
I think this needs to be fixed. because setting a Background Color for every neighboring Widget as a workaround is not always very convenient to do!
This same issue applies to the splashColor of the **ListTile** when tapping it.

Hi @hakamdev, Thanks for filing the issue. I verified on stable 2.5.3 and it seems to set the tileColor within the bounds.  Please share a minimal and complete reproducible code sample and on which platform is this issue reproducible?

code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

/// This is the main application widget.
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const MyStatelessWidget(),
      ),
    );
  }
}

class MyStatelessWidget extends StatelessWidget {
  const MyStatelessWidget({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return ListView.builder(itemBuilder: (context, index) {
      return Padding(
        padding: const EdgeInsets.all(8.0),
        child: ListTile(
          tileColor: Colors.red,
          leading: const Icon(Icons.star),
          title: Text('Title $index'),
          subtitle: Text('Subtitle $index'),
          trailing: Icon(Icons.more_vert),
        ),
      );
    });
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-arm, locale en-GB)
    • Flutter version 2.5.3 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.1, Build version 13A1030d
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.61.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • B622CBB7-F906-4FA7-8F49-FACEAAC905AB • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.0.1 21A559
      darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome
      96.0.4664.55

• No issues found!

Thanks

I'm also having the same issue. I'm running this code in Apple simulator iOS 15 iPhone 13. Here's a sample code I just wrote
`void main() {
runApp(const Issue());
}
class Issue extends StatelessWidget {
const Issue({Key? key}) : super(key: key);
ListTile createTile(String titleText, int index) {
return ListTile(
title: Text(titleText),
leading: Icon(Icons.book),
tileColor: index.isEven ? Colors.grey : Colors.blueGrey,
);
}
@override
Widget build(BuildContext context) {
return MaterialApp(
home: SafeArea(
child: Scaffold(
body: Column(
children: [
Text('Sample Sample Sample'),
Text('Sample Sample Sample'),
Text('Sample Sample Sample'),
Text('Sample Sample Sample'),
ListTile(
title: Text('Some Text'),
trailing: Icon(Icons.airplay),
),
Expanded(
child: ListView(
scrollDirection: Axis.vertical,
shrinkWrap: true,
children: [
ListTile(
title: Text('Tile Text'),
leading: Icon(Icons.book),
tileColor: Colors.grey,
),
ListTile(
title: Text('Tile Text 2'),
leading: Icon(Icons.book),
tileColor: Colors.blueGrey,
),
              ],
            ),
          ),
        ],
      ),
    ),
  ),
);

}
}
`

@hakamdev thanks for the code sample I was able to reproduce the issue.

It looks like this is same as https://github.com/flutter/flutter/issues/86584,  Closing this issue as a duplicate , if you disagree feel free to write in the comments and I will reopen it.
Thank you.

Can confirm according to the issue #86584 if you wrap the ListTile with a Card widget it can be workaround to omit this issue.


Visual Concept Sliders training is not working properly.

I am following the readme and trying to train the visual concept slider(eye).
But when I try to generate an image after the training is done, it generates a mess. Am I missing something?

Here is the pair image I prepared.
python trainscripts/imagesliders/train_lora-scale.py --name "eyeslider" --rank 4 --alpha 1 --config_file "trainscripts/imagesliders/data/config_2.yaml" --folder_main "datasets/eyesize/" --folders "bigsize, smallsize" --scales "1, -1"
bigsize

smallsize

I found the cause: LR was too high. By lowering it from 0.0002 to 0.00001, I was able to transform just the parts I wanted without distorting the overall style.  I was wondering if you could share the settings you used for the training, such as LR and optimizer? Thanks!
https://github.com/rohitgandikota/sliders/assets/8006000/46320438-4444-4cf0-80cb-d2048fb7647d

Oh awesome! We used the default parameters as provided in the repository. Glad you could get your custom dataset working! Closing this issue since it is resolved!
The slider looks amazing!!!


Extract liquidation recovery handling to a separate function and unit test it

In this PR we extract logic for handling liquidation recovery to a separate function so we are able to cover it with unit tests.
The tests are focused on testing the logic with different states of bitcoin connection. It's expected that if bitcoin connection fails the process moves on and completes based on the local data.
For the time being the signers are generated with TSS protocol but it would be awesome to load them from test data. Unfortunatelly I was not able to get it working in the limited time frame so leaving it as is.
The tests are failing due to the https://github.com/keep-network/keep-ecdsa/issues/840.
Depends on: https://github.com/keep-network/keep-ecdsa/issues/840

Okay - I'm good here. I highlighted a spelling mistake, but we can definitely fix that in a follow-up PR


Modal: The bottom focus border of form element is cut off

Info
If you have a form element directly above the actions slot, the bottom focus border doesn't appear.
<goa-button (_click)="onClick()">
  Show Modal
</goa-button>
<goa-modal heading="New Item" [open]="isOpen" (_close)="onClose()">

    Your progress will not be saved.

  <goa-dropdown name="someName" value="abc123">
    <goa-dropdown-item *ngFor="let fruit of fruits" [value]="fruit.value" [label]="fruit.label" />
  </goa-dropdown>

    <goa-button-group alignment="end">
      <goa-button type="tertiary" (_click)="onClose()">
        Cancel
      </goa-button>
      <goa-button type="primary" (_click)="onClose()">
        Exit
      </goa-button>
    </goa-button-group>

</goa-modal>

Acceptance Criteria

The focus border should be fully visible on all form elements inside a modal

:tada: This issue has been resolved in version 1.17.0-alpha.94 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0-alpha.37 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.25.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.24.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


(maint) Move rake runtime dependency

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3395/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3396/

@lucywyman given that we can't introduce this with version 11 because puppet itself is pinned to 10, can you change this to be on version 10? Not sure if any of the implementation from @ferglor was dependent on that version...

Changed!

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3412/


Blank page

I tried uploading dir to my website, but it's just a blank page

doing this doesn't show anything?
https://{YOUR_DOMAIN}/{YOUR_PATH}/?site_id=xvideos&video_id=59934029
example
https://appsdev.cyou/xv-ph-rt/api/?site_id=xvideos&video_id=59934029
check if you have any error_log file and send its content here, please.

if failure again, open a new issue


.Net: Rename AzureChatCompletion to AzureOpenAIChatCompletion (and other types)

[!IMPORTANT]
Labeled Urgent because it may require a breaking change.

We have OpenAIChatCompletion and AzureChatCompletion, and OpenAIRequestSettings which appears to be what should be used with both.  Should AzureChatCompletion (and related types) be renamed to have AzureOpenAI instead of Azure as the prefix? Will AzureChatCompletion work with everything "Azure" in the future and not just the "AzureOpenAI" service?  Will someone seeing they need to pass an AIRequestSettings to work with AzureChatCompletion know that it's the OpenAIRequestSettings they need to use even though there's no Azure in the name?

The existing Azure Chat/Text completion connectors should make it clear that they're only for OpenAI

Looking at this again, why do the AzureOpenAIXx types/methods even need to exist? Isn't everything identical between the AzureOpenAIXx and OpenAIXx types, including implementation down to the OpenAIClient being used. and the only difference is whether an endpoint is supplied to the ctor?

why do the AzureOpenAIXx types/methods even need to exist

@stephentoub Even taking into account that for both Azure OpenAI and OpenAI services we use the same Azure .NET SDK, we need to remember that these are separately hosted services with different configuration. Each service has its own deployment model, retry strategy, throttling etc. I think it's good to differentiate them by .NET types, rather than passed settings in constructor. Also, there are things like AzureChatCompletionWithData, which extends Azure OpenAI functionality, while on OpenAI side there are things like "Function Calling" and potential features in the future.
But I 100% agree that Azure* types should be renamed to AzureOpenAI* types for better understanding.

But I 100% agree that Azure* types should be renamed to AzureOpenAI* types for better understanding.

👍

while on OpenAI side there are things like "Function Calling"

That exists in Azure OpenAI as well.

I don't feel super strongly about consolidating them. Having two completely separate type hierarchices, sets of extension methods, etc., is just extra work for anyone trying to be portable across OpenAI and Azure OpenAI, which is unfortunate given that at the end of the day they end up using the exact same OpenAIClient under the covers, share all of the same code to get there, etc. It seems like unnecessary friction.  If we really believe there's going to be divergence in the future that would make consolidation problematic, ok... but I'd be curious what we think that'll be given that OpenAIClient is servicing both.

Ideally, I would use separate SDKs as these are separate services. But taking into account that we use only one, maybe it makes sense to have one type to handle both services.
On Python side, AzureChatCompletion inherits OpenAIChatCompletion:
https://github.com/microsoft/semantic-kernel/blob/f10d90f8f0524d59f25a7700475d90067055580c/python/semantic_kernel/connectors/ai/open_ai/services/azure_chat_completion.py#L12-L15
In case we will have just one type to work with Azure OpenAI and OpenAI, we will have to differentiate both services somehow inside that type, for example for logging. It's important to see in logs which service responds and how.

We can find a middle ground here: keep the SK public API (WithAzureChatCompletionService, WithOpenAIChatCompletionService) as it is today but consolidate the connectors into one. Later, we can always add another connector in case of divergence without impacting SK consumer code.


Alpine Errors

Describe the bug
Any inputs (BelongsToSelect, DateTimePicker) that require alpine result in javascript errors.
Alpine Error: "ReferenceError: dateTimePicker is not defined"
To reproduce
Steps to reproduce the behavior:

Install Filament
Create a Resource
Add a DateTimePicker to the form schema
Navigate to form
View the errors in the browser console

Expected behavior
A usable input
Screenshots

Context

Package version: 1.6.4
Livewire version: 2.4.0
Laravel version: 8.32.1
Browser: Safari
Server OS: Laravel Homestead
PHP version: 7.4.4
Database: MySQL 8.0.20

Additional details
I don't see any instructions to setup Alpine although I already had it in my package.json

@jfsullivan Can't reproduce using the steps you mentioned above. Have you got a repo with a valid reproduction? It might also be worth trying a view:clear and hard refresh.

Hi, I can't reproduce this either, so I'm gonna close this due to lack of response.

Issue resolved.  I had a custom Blade directive called 'pushonce' already defined in my AppServiceProvider that was conflicting/overriding the one used in Filament.  This resulted in the Form scripts never getting to the page.


[Question] Is there any way to catch all ZodiosErros like Axios interceptors do?

I was trying to achieve this with plugins but with no success, neither response nor error middlewares caught that.
The use case for that would be to show a user-friendly error message for all schemas validation errors. Since this is not something the user must know what exactly causes, so I was planning to show a generic error message to all ZodiosErros.
And in this case, I'm using only Zodios client because the API is built with C# so I don't have a complete guarantee that the responses will always be matching my schema definition.

Hello,
not with current version. as validation is made as a plugin itself. And has higher priority.


[Question]

Question
a script to check dependencies license.
when release a new version, we should check dependencies license one by one with eyes now. so i see dubbo done this in a script[1][2], so rise this question.
[1]  https://github.com/apache/dubbo/issues/3840
[2]  https://github.com/apache/dubbo/pull/3941

i think maybe add this license check

ok,  i will switch this to a task.


Rewrite tests for routes.js in client-side

Test expectations can probably be reused from existing routes tests

N/A because of react component. Need to write react tests now.


Ensure absent labels remain absent

Note lack of labels on the non-edge axes of this plot with shared axes, which matches the matplotlib behavior:

Thanks!


Getting banned

For past 1 week, all of the numbers I'm using are getting banned after few hours i log in using this library, I'm not using proxy & running 4 bots on same vps, can anyone tell me what's wrong here? Should I use proxies or something else?

are you sending AD messages, spam, to a number which they don't have you in there contact list?

And what do you mean by banned m you can not use WhatsApp any more on those numbers!

@SchulteMK What do you think?
do we need to run each number on its own proxy!

are you sending AD messages, spam, to a number which they don't have you in there contact list?

No, the bot only works in groups & only send msg on Cammands,

And what do you mean by banned m you can not use WhatsApp any more on those numbers!

Yes, i email them & they reopened 1 account but after i login again, they banned it after 3 hours & they aren't replying.

Do you email WhatsApp?
Well, I think working with groups is kind of spammy since your message arrive to more than the recipient at the same time.
Let see if you use a proxy what is the result!
can you test the API with a proxy!

Do you email WhatsApp?
Well, I think working with groups is kind of spammy since your message arrives to more than one recipient at the same time.
Let see if you use a proxy what is the result!
can you test the API with a proxy!

Yes i did sent email to whatsapps & this was their response

& sure I'll test it with a proxy & reply here here, but here is the thing, i just switched my vps ip 3 days ago but even after that, they banned all my accounts. So I was wondering if the causes is that i have too many groups & desided to make an account which have 10 groups, & to my sprise it got banned after 30 minutes 😅😅 so I'm lost here, is it the ai i setup 1 month ago cause of the or something else? Thanks for your help tho

Well, that is very serious. I am not sure if this related to the IP address.
I think there is a problem with the API which it does send a client version, but WhatsApp chrome (i think) it does not send any
https://github.com/Rhymen/go-whatsapp/issues/429
I am not sure.
but WhatsApp is talking about something unofficial! I am not sure if that including chrome, but I am sure if you invite people to the groups and they don't have your number in there address bock, you will get banned, and I can see how this happened.
I am 80% sure it is how you use the API if you are replaying as an auto responder. then you will have no problem
even if you use the official android and invite users to your group and they don't have your number in their address book. this is the key. you will get banned after some time.
What I am sure  about is the following:
Your device is who sent the message at the end, not the API. the API sends the message to your device, then your device who takes the lead to send the message.
So Whatsapp doesn't care about the WebClient, at the end your device who sent the messages.
I am not sure if you are using the official WhatsApp Application or the altered one.
Using a proxy ,,,,, I do not quite sure about that, since I go with the idea that your "activity" is suspicious to WhatsApp!

Whatsapp will ban every one if they want to but as long as we are using the lib to REPLAY to who sent us or send messages to who have our NUMBER without spamming by sending a lot of messages.  to a lot of distance at the same time.
Again, I am not sure and I would be very happy if @SchulteMK shares what he think about this!

Well I'm thinking about #429 too & searching if there's a way but i still doesn't understand how we got that.

but WhatsApp is talking about something unofficial! I am not sure if that including chrome, but I am sure if you invite people to the groups and they don't have your number in there address bock, you will get banned, and I can see how this happened.
Hmm i kinda a disagree with you here, i already tried to invite only my friends to use bot but still lead to issues but if i go & chat in other group with my unban account it works fine, it's been 3 days & that account is still active.
I am 80% sure it is how you use the API if you are replaying as an auto responder. then you will have no problem
even if you use the official android and invite users to your group and they don't have your number in their address book. this is the key. you will get banned after some time.
What I am sure about is the following:
Your device is who sent the message at the end, not the API. the API sends the message to your device, then your device who takes the lead to send the message.
So you're saying it's the phone I'm using the issue here? Cuz I'm using honor 8x with official whatsapp i don't see why they have the issue with this device since its fully supported.
So Whatsapp doesn't care about the WebClient, at the end your device who sent the messages.
I am not sure if you are using the official WhatsApp Application or the altered one.

I'm using official whatsapp business since the mod one keep crashing. So for now, i won't use proxies since it's confirmed that it's nothing to do with ip & wait for @SchulteMK to share his thoughts.

The problem is clear,
You are inviting a lot of users to a group, WhatsApp adds those users to the group.
Now we are not sure if your phone number available on the user's contact list since you can invite someone even if he doesn't have your phone number in his contact list.
Now you send a message to the group. let's say you have 100 users in the group.
or maybe you have 10 groups each one has 10 users invited.
You want some how-to send Advertisement, I am not sure ...

I am 100% sure this is the problem, and I will tell you why there is a lot of users who uses this API and
https://github.com/sigalor/whatsapp-web-reveng
A lot...
Me my self using this API with more than 7 numbers. BUT I NEVER DO GROUPS.
if there is a problem with the API, believe or not you will find a looooot of issues talking about banning numbers.
I am not sure what you are doing,
You can contact me directly<EMAIL_ADDRESS>if you like to take privately

Me my self using this API with more than 7 numbers. BUT I NEVER DO GROUPS.
You think it's the groups which caused this issue? I mean groups are meant for public purposes, around 95% groups on whatsapp are strangers.

if there is a problem with the API, believe or not you will find a looooot of issues talking about banning numbers.
That's why i started this issue
I am not sure what you are doing,
You can contact me directly<EMAIL_ADDRESS>if you like to take privately
Check your email

I am not sure if it related to API , but today i note this
[checkNewVersion]./main
Client has version 0.4.2080
Server has version 2.2033.7
New major detected 2
And there is no clientvirsion sent via chorme!
@Rhymen @SchulteMK

Hi
I also got the same issue, actually what I have noticed is that this library is not handling well the read messages scenario, I'm pushing for reading the messages but they're getting flagged as errored.
Whatsapp didn't ban my number yet but the read structure of the messages need to be well sorted out so the final status of the messages doesn't stay errored out. This is what's occuring with a very simple example and Whatsapp ends up banning the IP or server folders for a while so we don't continue the testing and everything else.
This should be addressed from how the library works on flagging these messages that's very important step.
I'm moving away from this library as I had another one working fine and I'm actually surprised with this result here.
I was using it to learn Golang and all but guess I have to go back to the good and old NodeJS :).

Hi ,
@ramonck First of all, we are a community not a private company and we don't expect that kind of talk, you have a problem then show it to us with the logs and some codes to understand what you do.
Such talk is totally unacceptable because society tries to provide the best assistance.
I have great relationships with @ Ased2235 and he told me that the problem is not related to Go lib in any way, it is related to the massive report of his number because he managed to use lib to manage groups, and some bad people don't like his successes, so they report his number. Anyone can report a number!

I'm moving away from this library as I had another one working fine and I'm actually surprised with this result here.

Are you threatening community! you are free to do whatever you want to do.
But It would be nice if you tell the name of the node.js lib so we can contact the author to see if we have any error to fix it.
Bear in mind that the Go is much more powerful than nodeJs I'm talking about RAM / CPU / IO usage.
NodeJs is a great platform, but Go is more fast than it.
You are welcome to share you experience and how you got the  "MessageStatus = 0" since i never have this problem!

@SchulteMK , as you can see we need to be more interactive with the community and improve the lib as much as we can, one problem is the version updates and each time we have to add the version by hand which is a problem. why don't we add a method to check the version once we start the API?

Hi @beshoo why am I threatening the community? I'm just being honest on my words that is it.
You are taking things too personally I believe I don't have any strong feelings about any specific technology or library.
But I totally agree with you about speed, the Golang is great in terms of speed is comparable with C++ from my experience so far.
I'm not sure that the version number is an issue, I followed your suggestion in the other issue you opened about updating the version number in the session.go file and that's how I handled it.
There should be some built in default in the message parsing for example the HandlerTextMessage is always trying to parse everything so maybe having another prebuilt function were you're already filtering the MessageStatus and only dealing with the new messages is probably a good idea to only work and fetch the new messages.
Another idea for this library here is basically making sure that there's always the message "read" on the output of this same pre-built function, Whatsapp needs a clean way out of the message read notification and my issue yesterday was that.
I can share here my code for yesterday but it's in another computer so it will be later on tonight.

You are taking things too personally
We spend hours upon hours testing and sharing talks and PL, at least show some respect to what @SchulteMK and others did. it is a very hard job.

It is not related to any technology we are open to anyone and we like to share the info.
But you are just talking! why don't you show steps that I can follow to have this error?
I am not sure what is your text handler! show it to us! it is not that big deal.
I agree with you that the lib has slow update progress, but it is all done, and once any great problem appears, such as QR not working, I guarantee to you that all members will be on board within one hour even in holidays.
I see how much love in this lib that is why your words breakthrough!
Now. what I need from you is the following.
show us steps to reproduce the error.
Regarding banning the number.
I believe if something not correct with Whatsapp you will not log in at all. but I believe it has to follow the version each day.
If you know GO it will be great if you make a method to check the version (which already available in the example directory)
and utilize the version once we start the lib.

Hmm as far as I noticed, it's not related to this library, as i tried node one & i still got banned. So i think it's users who is reporting to our numbers & whatsapps noticed that we aren't using official OS.

Hi @beshoo why am I threatening the community? I'm just being honest on my words that is it.
I'm not sure that the version number is an issue, I followed your suggestion in the other issue you opened about updating the version number in the session.go file and that's how I handled it.
As far as me & @beshoo confirmed, banning is not related to that but we can always use the latest version as there's no harm in it either way.

As for threatening, i think we all have different options so it's better to leave it alone rather than arguing with each other, we'll learn more from becoming friends rather than arguing about it.

Yes I don't understand why, I can program from PHP to C++ to Java.. to NodeJS and now a days learning Golang so actually I'm not sure why the hard feelings, I respect the work that people have put into any library and in no means I mean to disrespect anyone at all really so if you felt that way @beshoo I'm sorry but sometimes I just say what I feel and maybe it might have sounded bad for you but that was not my intent at all my idea is just to share what I have seen in other places and help you guys out that's always the idea to help.

Great respect to you, it is just misunderstanding, l am sorry as well.
Lets focus on the problem, let me see the steps..
Regard
On Fri, 18 Sep 2020, 5:16 pm Ramon Lima<EMAIL_ADDRESS>wrote:

Yes I don't understand why, I can program from PHP to C++ to Java.. to
NodeJS and now a days learning Golang so actually I'm not sure why the hard
feelings, I respect the work that people have put into any library and in
no means I mean to disrespect anyone at all really so if you felt that way
@beshoo https://github.com/beshoo I'm sorry but sometimes I just say
what I feel and maybe it might have sounded bad for you but that was not my
intent at all my idea is just to share what I have seen in other places and
help you guys out that's always the idea to help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Rhymen/go-whatsapp/issues/430#issuecomment-694894540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDLT2ZLG7U6CZXZT6OZIUDSGNTR7ANCNFSM4P67ACYQ
.

Yes no problem it's life.
Regarding the issue this is what I see was my issue to gettting "blocked" but they didn't block my IP as I originally stated actually they do another type of block I don't remember the name exactly but they sort of pin that from this specific session connection to not reconnection.
Because using my device was all normal and all it was just that web session connectivity.
I'm not using any proxy or anything just playing around here and all with the code.
The code that created the flagging ban from the web session after executing 3 times:
func (h *waHandler) HandleTextMessage(message whatsapp.TextMessage) {
		msg := whatsapp.TextMessage{
			Info: whatsapp.MessageInfo{
				RemoteJid: message.Info.RemoteJid,
			},
			Text: "Hello response :)",
		}

		_, err := h.c.Send(msg)
		if err != nil {
			fmt.Fprintf(os.Stderr, "error sending message: %v", err)
		}
}

After I identified the issue of sending too many return messages at the sametime because there was no filtering I created an if to actually filter out and only send when it made sense, but I still saw too many returns and saw that a couple of the messages had to Status = 0 so I also added the filtering out the 0 status messages. But when I got to this step I was already on my 3rd tryout and the library has already sent the same reply message 15 - 20 times.
func (h *waHandler) HandleTextMessage(message whatsapp.TextMessage) {
	if message.Info.FromMe == false && message.Info.Status != 3 && message.Info.Status != 0 {
		fmt.Printf("%v", message.Info.Status)

		h.c.Read(message.Info.RemoteJid, message.Info.Id)

		msg := whatsapp.TextMessage{
			Info: whatsapp.MessageInfo{
				RemoteJid: message.Info.RemoteJid,
			},
			Text: "Hello response :)",
		}

		_, err := h.c.Send(msg)
		if err != nil {
			fmt.Fprintf(os.Stderr, "error sending message: %v", err)
		}
	}
}

After this last version I'm finally filtering and only responding to what makes sense but I'm still not sure if just the Read is enough to satisfy the MessageStatus requirement so I really wanted to understand this step of the library on the mechanic of the session if I should of done maybe some "typing" before hand or maybe put some timeout since the response time is crazy fast?

The weird thing now is that I just tried another library here on the same machine and it worked there's no block there, that's very weird stuff trying to understand what the block is actually.
The block continues with a new "git clone" from the library, weird stuff, going to examples folder and running the receiveMessages.
On the other library it worked fine now from the same machine, weird.. haha crazy stuff.

h.c.Read(message.Info.RemoteJid, message.Info.Id)
This is your problem, in my script, I only read what i need to, and please do this

var StartTime = uint64(time.Now().Unix()) // once you start the API we save the start time
func (h *waHandler) HandleTextMessage(message whatsapp.TextMessage) {

if  message.Info.Timestamp  < StartTime  {
                return // we ignore all old messages so you do not send reeds to an old messages over and over
        }

	if message.Info.FromMe == false && message.Info.Status != 3 && message.Info.Status != 0 {
		fmt.Printf("%v", message.Info.Status)

		h.c.Read(message.Info.RemoteJid, message.Info.Id)

		msg := whatsapp.TextMessage{
			Info: whatsapp.MessageInfo{
				RemoteJid: message.Info.RemoteJid,
			},
			Text: "Hello response :)",
		}

		_, err := h.c.Send(msg)
		if err != nil {
			fmt.Fprintf(os.Stderr, "error sending message: %v", err)
		}
	}
}

You need to remove the  Message status 4 as well

h.c.Read(message.Info.RemoteJid, message.Info.Id)

This is your problem, in my script, I only read what I need to.
check this updated version of your code, it sends typing as well as read! please fix the handler and the connection parm.
var StartTime = uint64(time.Now().Unix()) // once you start the API we save the start time
func (h *waHandler) HandleTextMessage(message whatsapp.TextMessage) {
	if message.Info.FromMe == false && message.Info.Timestamp  > StartTime {
	fmt.Printf("%v", message.Info.Status)
	h.c.Read(message.Info.RemoteJid, message.Info.Id)
	time.Sleep(500 * time.Millisecond)
	_, err = h.c.Presence(message.Info.RemoteJid, wa.PresenceComposing)
        if err != nil {
                log.Infof("Send Text Presence %v", err)
                return err
        }
        time.Sleep(100 * time.Millisecond)
		msg := whatsapp.TextMessage{
			Info: whatsapp.MessageInfo{
				RemoteJid: message.Info.RemoteJid,
			},
			Text: "Hello response :)",
		}
		_, err := h.c.Send(msg)
		if err != nil {
			fmt.Fprintf(os.Stderr, "error sending message: %v", err)
		}
	}
}

hmm i don't think this is the issues here as i never used Read so as far i know there's nothing wrong with this lib as i already told @beshoo that there's 2 bots which i'm using for 1 year but never got banned once.

Hi all, about this topic, i have one problem, begin started from +- 1 month.
I have +- 60 VPS running this lib, using interface like Whatsapp web, but multi-user, chatbot, etc..
My problem is, on numbers with more messages traffic, the Whatsapp cant works on device.
The devices not receveid messagens, and not send too.
On device, show is connected on "whatsapp web", but on de the lib not see this, and not work.
The most stranger is that point, at smartphone messages not down. And, if i send message from another device, out of system, the message is show only one 'tic', like message only receveid only by whatsapp server.
Somebody  see somelike this!?
Sorry my bad english..

Unfortunately, I can not understand your English. Sorry...
But try to use WhatsApp business, since it designed to auto reply on a way
status.
Regard
On Tue, 6 Oct 2020, 12:06 am Tiago Oliveira de Jesus, <
<EMAIL_ADDRESS>wrote:

Hi all, about this topic, i have one problem, begin started from +- 1
month.
I have +- 60 VPS running this lib, using interface like Whatsapp web, but
multi-user, chatbot, etc..
My problem is, on numbers with more messages traffic, the Whatsapp cant
works on device.
The devices not receveid messagens, and not send too.
On device, show is connected on "whatsapp web", but on de the lib not see
this, and not work.
The most stranger is that point, at smartphone messages not down. And, if
i send message from another device, out of system, the message is show only
one 'tic', like message only receveid only by whatsapp server.
Somebody see somelike this!?
Sorry my bad english..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Rhymen/go-whatsapp/issues/430#issuecomment-703888650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDLT23SGKFVZVFOBAT24R3SJIYMBANCNFSM4P67ACYQ
.

Okay, I'll try with Google ..
I have + - 60 vps running the library, we created an interface similar to whatsapp web, but with features like multi-users, chatbot, automatic responses, among others.
It happens that in instances with more traffic, something like 2000 messages per day, for about 1 month, it seems that Whatsapp does a type of blocking, causing no message to be delivered to the number connected in the system.
In some cases, this number, through the device, is able to send messages, but receives nothing.
It shows on the screen of the device, as if it were connected to the system, but through the library, no .. Go says it was not possible to connect.
After about + - 5 hours, the "block" is undone and the messages are returned to the number.
Has anyone had this problem?
[] s

Great, now it is more clear, Thanks Goole :)
I think 2000 messages per day is something that may bring attention to the number.
I advise you to test whatsap business application, it designed to send a lot of messages at the same time;
More to say is the timeframe between messages, I believe the 2000 message is a big number to handle per day by WhatsApp.

Update, Are you using a proxy of you are counting on the server IP address?
I advise you to use a proxy with each number.

In fact, most numbers are using whatsapp business anyway.
As for the proxy, no, I'm not using ... what software do you use for proxy?
In fact, when the problem occurs, I tried to change the IP, change the instance, change the data center and even, the provider of iaas .. sometimes it works again, but for a few minutes.
It seems to me more like a number block, not the server / ip.
[] s

Once the number in the red zone you can not depend on changing the proxy.
I advise you to use a proxy for each number. you can search the API and learn how to use a proxy.

Mow many numbers on the same VPS are running?

How many numbers on the same VPS are running?

Only one

Then it is your massive amount of messages.
Regard
On Tue, 6 Oct 2020, 4:12 pm Tiago Oliveira de Jesus, <
<EMAIL_ADDRESS>wrote:

How many numbers on the same VPS are running?
Only one
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Rhymen/go-whatsapp/issues/430#issuecomment-704258948,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDLT246J5DMWF2GHMXWRMLSJMJTBANCNFSM4P67ACYQ
.

@beshoo How many messages do you recommend to send, say on a per hour basis, given that the messages sent by the bot would mostly be in response to what the user sent?

How many numbers on the same VPS are running?

Only one

Well i disagree, as I'm running 7 numbers & 3 of them never got ban if ppl don't report them. I noticed this when i added bot in friend's groups & ask them to spam & it didn't got banned note that bot send over 100 msg/hour but i did the same thing in other groups & got banned in 3 days.
Here's the few tips i think will useful for you guys:
Don't make bot active 24/7, close it for at least few hours per day
Limit 150 groups per number, This is i confirmed after getting few bans
Use gb whatsapp, i can't say if this will work for sure but i seen someone suggesting that ao it's worth a shot.

Well i disagree, as I'm running 7 numbers & 3 of them never got ban if ppl don't report them. I noticed this when i added bot in friend's groups & ask them to spam & it didn't got banned note that bot send over 100 msg/hour but i did the same thing in other groups & got banned in 3 days.
Here's the few tips i think will useful for you guys:
Don't make bot active 24/7, close it for at least few hours per day
Limit 150 groups per number, This is i confirmed after getting few bans
Use gb whatsapp, i can't say if this will work for sure but i seen someone suggesting that ao it's worth a shot.

I was looking into creating as many groups as possible (500+) per number. Won't be spamming anyone. Users would join via the invite link and the bot would reply to their messages. Would you still not recommend creating 150+ groups per number?

Well i disagree, as I'm running 7 numbers & 3 of them never got ban if ppl don't report them. I noticed this when i added bot in friend's groups & ask them to spam & it didn't got banned note that bot send over 100 msg/hour but i did the same thing in other groups & got banned in 3 days.
Here's the few tips i think will useful for you guys:
Don't make bot active 24/7, close it for at least few hours per day
Limit 150 groups per number, This is i confirmed after getting few bans
Use gb whatsapp, i can't say if this will work for sure but i seen someone suggesting that ao it's worth a shot.

I was looking into creating as many groups as possible (500+) per number. Won't be spamming anyone. Users would join via the invite link and the bot would reply to their messages. Would you still not recommend creating 150+ groups per number?

Yes, my bot is exactly the same as discord so ye. If you have more groups then use multiple numbers & use database to link them.

@Ased2235 is all the number use the same phone ?

@Ased2235 is all the number use the same phone ?

No, we ran on different phones but you can run 3 bots per device if you want.

Hello I was banned from WhatsApp for a channel that is dedicated to banning people, something I can do


Adds wallrj to OWNERS file

Signed-off-by: JoshVanL<EMAIL_ADDRESS>/assign @munnerz

/lgtm
/release-note-none


Decide when to build Docker containers (e.g. tag vs commit)

For example:
https://github.com/open-contracting/spoonbill-web/blob/main/.github/workflows/push.yaml
https://github.com/open-contracting/spoonbill-web/blob/main/docker-compose.deploy.yaml

If we decide not to use tags, I'll delete all the tags in the other repos (pelican-frontend, pelican-backend, kingfisher-process, kingfisher-collect) to avoid confusing future developers.

As with everything, this is up to your taste and current needs. Thinking aloud about tag advantages:

"should be deployable" and "is deployable" are in a real world quite different things:) (we don't have to go far i.e. last change where users weren't able to login into the admin interface and have been practically cut out. In theory, everything was deployable)
tags allow you to easily return to the older version in case of "something is broken" (each build tags image with :latest and :tag_version tags)
tags allow you to easily deploy staging/test environments
aligned tags can be used to sync versions in multi-component environments (i.e. data-registry needs a special version of kingfisher-process)

On the other side:
Tags are too complicated a too heavy for our current needs.
All the arguments are relevant to me, but I'm not able to decide as I'm not in your shoes. With tags (and few rules behind those), you can easily achieve a very robust development/production infrastructure. But, maybe it's not a real need, just overengineering.

I think we can maybe go somewhere in the middle. Instead of tagging for each build (which is just extra work across multiple repositories), we discussed:

Building to a different Docker tag for non-main branches (e.g. to be able to test a branch in staging). If we use a constant tag (like "develop"), then different branches will clobber each other. We can instead use the branch name as the tag. To clean up old images, we can maybe use https://github.com/bots-house/ghcr-delete-image-action/issues
In case we introduce a breaking change on the main branch, we can maybe store a constant in the workflow, so that instead of latest, it builds v1, and then before a breaking change, we change it to v2. That way, in a hypothetical scenario, Process and Pelican can stay on v1 on the helpdesk server, but change to v2 for the data registry.

The example in GitHub's docs use docker/metadata-action, which determines tags/labels automatically based on branches, tags, PRs, etc.

Alright, I'll leave this as-is, as it's not so hard to add a tag, and it might make some future problems easier.


Fix statements inside IF only if the END is missing

Fixes #226

Codecov Report

Merging #229 (892f437) into main (a1652d1) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   96.18%   96.42%   +0.23%
==========================================
  Files          31       31
  Lines        1811     1819       +8
==========================================
+ Hits         1742     1754      +12
+ Misses         69       65       -4

Impacted Files
Coverage Δ

robotidy/transformers/AddMissingEnd.py
96.87% <100.00%> (+9.37%)
:arrow_up:

robotidy/files.py
94.50% <0.00%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1652d1...892f437. Read the comment docs.


Revert "Allow to use higher version boost in MacOS"

Reverts EOSIO/eos#2576
Boost 1.67 is causing test failures on debug build. Boost bug has been submitted: https://svn.boost.org/trac10/ticket/13533

Reverting this doesn't help because 1.67 is still installed. @pacificcode is going to put in a better fix.

So @pacificcode , what's the current status of this ?

@InfoHunter https://github.com/EOSIO/eos/pull/2599 switches back to Boost 1.66 while we wait for Boost to fix their bug.


[#2524] Refactor TransactionCounter

[#2524]

Refactor TransactionCounter

Codecov Report

Merging #2672 into master will increase coverage by <.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
+ Coverage   40.97%   40.98%   +<.01%
==========================================
  Files        1762     1762
  Lines       61268    61276       +8
  Branches     8600     8601       +1
==========================================
+ Hits        25106    25114       +8
  Misses      36162    36162

Impacted Files
Coverage Δ

...nt/profiler/context/DefaultTransactionCounter.java
94.44% <100%> (+8.73%)
:white_check_mark:

...ercorp/pinpoint/profiler/context/DefaultTrace.java
62.66% <50%> (ø)
:white_check_mark:

...itor/codahale/tps/metric/TransactionMetricSet.java
95% <95.23%> (-1.56%)
:x:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
88.05% <0%> (-1.5%)
:x:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
73.61% <0%> (-0.7%)
:x:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
77.9% <0%> (ø)
:white_check_mark:

.../profiler/sender/StandbySpanStreamDataStorage.java
81.35% <0%> (+1.69%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d8340...11926c4. Read the comment docs.


Plugins without Permission nodes

Hi,
I have been looking for hours for this and haven't found anything.
im using a few sponge plugins that don't have permission nodes.
Is there a way to allow a certain user/group to have all permissions.
example; when joining the server you have 0 perms and you have to assign them user permission nodes.
is there a way to give users access to all permissions and from there blacklist permissions instead of whitelisting.
Thanks,

That's in fact terrible practice. You rather want people to not have permissions to things they should have permissions to, than them having permissions to thing they should not have to, as they easily might damage the server that way if you just forget to blacklist one permission.
But reagrdless, using the * wildcard is the way to go.
I also don't understand what exactly the plugins with no permissions have to do with that question.


python/error/decimal_to_binary.py

Find the errors in the code and correct them

Can you please assign this issue?

can you assign me this issue?


IPv6 Route Advertisement RDNSS lifetime is too short per RFC recommendation.

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
IPv6 Route Advertisement RDNSS lifetime is too short per RFC recommendation.
RFC8106 5.1 says RDNSS Lifetime "SHOULD by default be at least 3 * MaxRtrAdvInterval"
additonally

The rationale of the default value of the Lifetime field is as
follows.  The Router Lifetime field, set by AdvDefaultLifetime,
has the default of 3 * MaxRtrAdvInterval as specified in
[RFC4861], so such a default or a larger default can allow for
the reliability of DNS options even under the loss of RAs on
links with a relatively high rate of packet loss.  Note that
the ratio of AdvDefaultLifetime to MaxRtrAdvInterval is the
number of unsolicited multicast RAs sent by the router.  Since
the DNS option entries can survive for at most three
consecutive losses of RAs containing DNS options, the default
value of the Lifetime lets the DNS option entries be resilient
to packet-loss environments.

To Reproduce
Simply enable Router Advertisements with DNS server configured
Expected behavior
RDNSS Lifetime should be 3 times the Maximum Interval
Describe alternatives you considered
OPNsense should add to the radvd config:
AdvRDNSSLifetime 3060
this would go in the same block at the RDNSS changing
RDNSS 2001:470:****:1::3 2001:470:****:2::8 { };
to
         RDNSS 2001:470:****:1::3 2001:470:****:2::8 {
         AdvRDNSSLifetime 3060
         };

In this case 3060 is 3 times 1020, my configured Maximum Interval
Relevant log files
RA from Packet Cap

Internet Control Message Protocol v6
Type: Router Advertisement (134)
Code: 0
Checksum: 0xa4b8 [correct]
[Checksum Status: Good]
Cur hop limit: 64
Flags: 0xc0, Managed address configuration, Other configuration, Prf (Default Router Preference): Medium
Router lifetime (s): 3060
Reachable time (ms): 0
Retrans timer (ms): 0
ICMPv6 Option (Prefix information : 2001:470::1::/64)
ICMPv6 Option (Prefix information : fda9:26a9:1c47:1::/64)
Type: Prefix information (3)
Length: 4 (32 bytes)
Prefix Length: 64
Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
Valid Lifetime: 86400
Preferred Lifetime: 14400
Reserved
Prefix: fda9:26a9:1c47:1::
ICMPv6 Option (Route Information : Medium ::/0)
Type: Route Information (24)
Length: 3 (24 bytes)
Prefix Length: 0
Flag: 0x00, Route Preference: Medium
Route Lifetime: 3060
Prefix: ::
ICMPv6 Option (Recursive DNS Server 2001:470::1::3 2001:470::2::8)
Type: Recursive DNS Server (25)
Length: 5 (40 bytes)
Reserved
Lifetime: 1020
Recursive DNS Servers: 2001:470::1::3
Recursive DNS Servers: 2001:470:****:2::8
ICMPv6 Option (DNS Search List Option napshome.local)
Type: DNS Search List Option (31)
Length: 3 (24 bytes)
Reserved
Lifetime: 1020
Domain Names: napshome.local
ICMPv6 Option (MTU : 1500)
Type: MTU (5)
Length: 1 (8 bytes)
Reserved
MTU: 1500
ICMPv6 Option (Source link-layer address : 00:15:5d:01:f1:12)
Type: Source link-layer address (1)
Length: 1 (8 bytes)
Link-layer address: Microsof_01:f1:12 (00:15:5d:01:f1:12)

Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 21.1.3_3-amd64FreeBSD 12.1-RELEASE-p14-HBSDOpenSSL 1.1.1j 16 Feb 2021
Windows Server 2019 Hyper-V, AMD Ryzen 9 3950X, 4GB RAm

Thanks for you report. radvd.conf still claims:
Default: 2*MaxRtrAdvInterval

And we validate the advanced value according to this manual page. I don't mind bumping the value validation, but what is the upper bound then if 3*MaxRtrAdvInterval is the default -- is it also the maximum value?
Cheers,
Franco

Thanks for your report. radvd.conf still claims:
Default: 2*MaxRtrAdvInterval

Yes, that is claimed, but that is not reality. I was involved in the "other" group with this same issue. radvd is simply using the MaxRtrAdvInterval as is.
I have 1020 set in my config for the MaxRtrAdvInterval, and you can see 1020 is used for the RDNSS lifetime as well.
RFC says this could be set to "infinity" (Max 32bit Value), but if this is going to be left unconfigurable which should be fine, then the default miniimum recomendation of 3 * MaxRtrAdvInterval  should be sufficient.

And we validate the advanced value according to this manual page. I don't mind bumping the value validation, but what is the

What do you mean by this?
Right now this is that my radvd conf has.

interface igb1 {
AdvSendAdvert on;
MinRtrAdvInterval 510;
MaxRtrAdvInterval 1020;
AdvLinkMTU 1500;
AdvDefaultPreference medium;
AdvManagedFlag on;
AdvOtherConfigFlag on;
prefix 2001:470::1::/64 {
DeprecatePrefix off;
AdvOnLink on;
AdvAutonomous on;
};
prefix fda9:26a9:1c47:1::/64 {
DeprecatePrefix off;
AdvOnLink on;
AdvAutonomous on;
};
route ::/0 {
RemoveRoute off;
};
RDNSS 2001:470::1::3 2001:470:****:2::8 {
};
DNSSL napshome.local {
};
};

This is what this part need to look like to fix this. Again MaxRtrAdvInterval * 3 = 3060

};
RDNSS 2001:470::1::3 2001:470::2::8 {
AdvRDNSSLifetime 3060
};

@fichtner, bumping the value validation for the advanced options makes sense. 👍
@Napsterbater, regarding the defaults, wouldn't it be better to raise an radvd issue?
https://github.com/radvd-project/radvd/issues

So the last question is if radvd accepts values outside the interval it documents, otherwise the whole request doesn’t make sense until radvd is patched.

Yes it does. This is already been implemented on other platforms. Hence why I've made the suggestion here.
If the radvd config is generated with the change I'm suggested it will solve the problem. You can manually add that to the config And it will work.
That one line just needs to be added to the RDNSS section in the value Just needs to be based on the max advertisement interval whether that be the default if it wasn't manually set or whatever the user set.
And just to be clear I'm not suggesting any changes to the max advertisement interval in case that was unclear. This only affects the RDNSS section of the config.

Defaults have been changed in radvd master: radvd-project/radvd#151
I removed the bounds for the advanced options in #4893 and tried 86400 seconds. Works fine with the current radvd 2.19.
@Napsterbater, if you need a larger AdvRDNSSLifetime now, you may try opnsense-patch cf873b5 and specify the desired value in the advanced options.


feat: introduce maxEntrySize, for enabling error message truncation

introduces the configuration setting maxEntrySize which, if set, will make a best effort to truncate text log entries, such that they don't result in an exception, see:
https://cloud.google.com/logging/quotas
Note: as follow up, we should set this option to 256,000 on logging-bunyan, and logging-winston.
fixes #427

What are the units of maxEntrySize?

@xtellurian I assume you sorted this out but for anyone else, it's bytes
https://github.com/googleapis/nodejs-logging-bunyan/blob/34a278c724f9bfcf1511e22b7deb234007f713bf/src/index.ts#L204


Add reported_dt to flaw drafts

This PR adds the reported_dt field to flaws created by collectors. reported_dt is set according to created_dt.
Fixes OSIDB-2771

@dmonzonis These flaws serve as drafts for the VM team and are intended for triage. They often contain incomplete data, but we cannot require all validations to pass because we want to preserve every flaw.


Create CONTRIBUTING.md with guidelines

Write down guidelines to show how to contribute with CloudEvents' JavaScript SDK

@fabiojose should I change my PRs to base off of the develop branch?

Off course @playground-julia!
But is not required.


[WIP] Code implementation of Conv-LoRA

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Great work! One real quick question, have you tried conv-lora on standard text tasks instead of image/SAM tasks? If so, how was it? If havnt tried, do you think it is a more general-purpose PEFT method, or it is more of a SAM/CV-specific approach? Thanks a lot!

Thank you for your question. While I haven't tried text tasks yet, my understanding is that Conv-LoRA is primarily designed for image tasks.
Conv-LoRA incorporates local priors into image features at appropriate scales, considering potential variations in object scale. This involves interpolating image features to larger scales than default and subsequently employing convolution operations for injecting local priors. In our paper, we find that interpolating features to larger scales for local prior injection is more beneficial, given that features in the Vision Transformer (ViT) are downscaled by a factor (e.g., 16) from the original continuous image.
However, texts are 1-D discrete sequences and lack a concept akin to "object scale". Consequently, considering the feature processing in Conv-LoRA and its motivation, it is unsuitable for text tasks.


[WIP] [playground][file] Feature: Playground link sharing

Description
Adds a share button to the playground's ActionToolbar which will create a #doc= URL that includes a compressed and serialized document. The plugin also has an effect that will set the editor state from this document and clear history on initial load. It changes the URL when the share button is clicked as well, I just copied the typescript playground UX for this, I think it's done as a fallback for if the clipboard.writeText fails.
I added the following new exports to @lexical/file to support this feature:

type SerializedDocument
serializedDocumentFromEditorState
editorStateFromSerializedDocument

TODO:

[ ] tests
[ ] a proper flash message UX

Test plan

TODO

@zurfyx any thoughts on this before I finish up the UI and tests?

this is pretty cool - I'm not sure how useful it will be for real-life debugging, but I might be wrong and there's certainly no harm. Curious if you had particular use cases/debugging friction points in mind.
Another area of exploration might be the test generator - I think it's defunct and never worked super-well, but the idea was to be able to start "recording mode" and it would generate an e2e test for you as you interacted with the playground editor.

@acywatson I picked it off the roadmap 🤷♂ Thinking about debugging use cases I think it is actually pretty useful because you can make a link to the playground from an issue with the state required to repro an issue (so long as history isn't involved in the bug). You can also use it to demonstrate a playground state that shows off a new node or feature. It's also in just about every other playground site.

@acywatson I picked it off the roadmap 🤷♂ Thinking about debugging use cases I think it is actually pretty useful because you can make a link to the playground from an issue with the state required to repro an issue (so long as history isn't involved in the bug). You can also use it to demonstrate a playground state that shows off a new node or feature. It's also in just about every other playground site.

Makes sense!

so long as history isn't involved in the bug

I suspect most issues actually involve a sequence of interactions against a particular initial state, but at least it gets us that initial state.
Once again, no objections to this at all, more just thinking about what could be a next step to making it even easier to create shareable repros and further reduce triage/maintenance overhead.


Quaternion values are not updated when modified outside the inspector

Thanks so much for this great plugin :100:
I noticed that when manipulating Transforms manually, the changes to the rotation are not updated (changes to Quat in general). I tried both WorldInspectorPlugin and InspectorPlugin. Notice the rotation not updating

Above is small change to examples/transform.rs to rotate and translate the cube and set data.transform from the cube's transform
fn rotate_and_translate(mut query: Query<&mut Transform, With<Cube>>) {
    query.single_mut().rotation *= Quat::from_rotation_y(0.01);
    query.single_mut().translation += 0.0001;
}

fn update(mut data: ResMut<Data>, mut query: Query<(&Cube, &mut Transform)>) {
    for (_, mut transform) in query.iter_mut() {
        data.transform = *transform;
    }
}

Looking at the code, from what I can tell, it is likely related to the fact that they are cached, maybe without updating context.id(). As long as the value can change outside the inspector, I am not sure what the correct solution is.
If it is important to avoid the recalculation (?), keeping track instead whether the raw Quat value has changed instead? Apologies if this is not correct -- could the problem be that context.id() should have changed? Not familiar with egui and how to use Id.
            QuatDisplay::Euler => {
                let mut euler_angles = ui
                    .memory()
                    .data
                    .get_temp_mut_or_insert_with(context.id(), || {
                        Euler(Vec3::from(self.to_euler(EulerRot::XYZ)))
                    })
                    .0;

                let changed = euler_angles.ui(ui, Default::default(), context);
                if changed {
                    *self = Quat::from_euler(
                        EulerRot::XYZ,
                        euler_angles.x,
                        euler_angles.y,
                        euler_angles.z,
                    );
                    ui.memory()
                        .data
                        .insert_temp(context.id(), Euler(euler_angles));
                }
                changed
            }

The reason for caching the euler angles is that going from quat -> euler angles -> quat every frame leads to very unstable results. I pushed a change that will compare the intermediate value to the actual value and if they don't match update the intermediate one, so now external changes should be properly handled.
Can you verify that the fix works by setting
[patch.crates-io]
bevy-inspector-egui = { git = "https://github.com/jakobhellermann/bevy-inspector-egui" }

in your Cargo.toml?

The reason for caching the euler angles is that going from quat -> euler angles -> quat every frame leads to very unstable results.

Very interesting -- fwiw, I just removed the caching yesterday and failed to observe these cases. To clarify, without caching, you wouldn't do the full conversion quat -> euler angles -> quat every frame

quat -> euler angles every frame to display the values in the inspector
euler angles -> quat only on changes, e.g. if changed is true

I pushed a change that will compare the intermediate value to the actual value and if they don't match update the intermediate one, so now external changes should be properly handled.

I just tried it locally -- amazing! :100:  Thank you so much for the swift fix, much appreciated!


Keyboard opacity strategy: stricter check of pressed keys

Problem
Pressing option + cmd + 1 (which toggles the navigator) also triggered the keyboard opacity strategy, since it didn't check which keys were pressed strictly enough.
Solution
Check both modifiers and keys pressed when determining the fithness of keyboardSetOpacityStrategy

I've just tested it with all sorts of keyboard combos, both ones that get picked up by the editor as well as ones that get picked up by the OS. Opacity-via-keyboard looks to behave correctly now!


73 schema 1.1.2

Closes #73.
Update to schema version 1.1.2. Include new Contact & ID Annotators.

@tschaffter I am apparently not authorized to merge