dotnet interactive graceful quit

dotnet interactive should be able to terminate with exit code 0 if that is required by the application that owns it.
Different integrations could possibly have different enduser gestures to trigger such command.
The proposal consists in adding an api command that will initiate the shutdown of the dotnet interactive process with an exit code of 0
When Quit is issued dotnet interactive performs the dispose patterns so that kernels and any other component registered for disposal have the opportunity to clean up.
The handler of  the command prevents any other queued command from being executed and the context is completed, finally Environment.Exit(0) is done.

I like this idea of asking dotnet-interactive to try to shutdown gracefully.  In our extension we register a a disposable with the kernel and cleaning this up before shutting down would be greatly appreciated.
Having a separate command to shut down the kernel would also help in our extension scenario.  We add a middleware to the kernel and would not want the middleware run if a shutdown command is issued.  Currently we only run our middleware if the command is of type SubmitCode and having a separate command type to shutdown would help.
kernelBase.AddMiddleware(async (command, context, next) =>
{
    if (command is SubmitCode)
...

@suhsteve do you think that disposable objects in code submission should have the opportunity to be involved with the disposal of kernels?
That would make sure that any user created resource is properly disposed when dotnet-interactive quits

This makes very good sense.

I think it'd be a nice to have if it could do that as well.


Add network sets resource

Description

Add a GlobalNetworkSet resource type, which contains a set of CIDRs.  The set can have labels attached, and (once updated) Felix will include the CIDRs in policy.
Todos

[ ] Check if there's anything that needs to be done to disable namespacing
[x] Tests
[ ] Documentation
[ ] Release note

Release Note

Introduces NetworkSets which allow Calico policies to select sets of IP networks via label selectors

Release note covered here: https://github.com/projectcalico/calico/pull/1630


[BEAM-9246] Introducing google-http-client.version property in Java archetype

Fixes https://issues.apache.org/jira/browse/BEAM-9246 .

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

retest this please

Run Dataflow PostRelease

We'll see during the next run for the nightly snapshot. This is definitely an improvement.

We'll see during the next run for the nightly snapshot. This is definitely an improvement.

Agreed, thanks for the prompt fix Tomo.

@lukecwik and @ibzib, Thank you.


Support for reference LSP API

This PR add support for reference LSP API.
The reference API implementation leverage the reference resolvers leveraged for navigation (goTo), doing a reverse lookup to find all the navigations that reached a given declaration.  The lookup can be expensive since it goes thru all the references in the project, hence the move to Stream rather than list to better manage the number of items in memory that we anyways will discard as they are no in-scope for the user request (ie - reference that are not for the given delcaration).
Given source information can be missed or be incorrect, there is a switch to Optional on all the reference resolver methods, allowing to handle centrally if a source information is invalid, and preventing exceptions when computing either goTo or references.
Below how the feature behave on VSCode

/easyCLA

/easycla


use venv for Tensile create on Linux

if found use virtual env on Linux for Tensile create command match what has been done on Windows
Utilizes python updates added during initial install, e.g. rocBLAS build

@ellosel I first looked at rocBLAS side but as we just call directly the cmake function TensileCreateLibraryFiles this is simpler and it still is the client who sets up the vars/hooks to enable the virtual env use.   It also matches what was required and in use windows, so for now think it should suffice unless there are known user conflicts.   I assume any cmake defined virtualenv (implicit function argument) would be valid for use here, otherwise it could be a new argument to TensileCreateLibraryFiles.

If this doesn't cause problems would like to merge as need to cherry pick to 6.3 branch to fix installation on new OS.


W3CWebSocket doesn't handle connection failures messages

The W3CWebSocket implementation catches the 'connectFailed' event from the client with the following function :
this._client.on('connectFailed', function() {
    onConnectFailed.call(self);
});

The client emits error events like this:
function handleRequestError(error) {
    self._req = null;
    self.emit('connectFailed', error);
}

The error passed to the W3CWebSocket  is not transmitted further down, it make errors harder to identify when coding. Is it made on purpose ?

Yes, it is on purpose, to match the W3C specification. In the spec, there is no detail given about the exact failure cause.


Understanding the log determinant

A point of confusion for me: in do_one_regression_at_fixed_scatter, a quantity called "logdet_Cinv" is calculated, which is the determinant of the log of the Cinv matrix. In do_one_regression, this quantity is subtracted from sum(chi*chi) during the calculation of chi2. @davidwhogg , I was wondering if you could explain why this happens. Thanks!

Actually it is the log of the determinant of Cinv.
Look up (on Wikipedia, maybe) the "multivariate gaussian".  The likelihood we have is the log of a multivariate gaussian probability density function for the data.


image_transport_plugins: 1.9.3-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository image_transport_plugins to 1.9.3-0:

upstream repository: https://github.com/ros-perception/image_transport_plugins.git
release repository: https://github.com/ros-gbp/image_transport_plugins-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: null

compressed_depth_image_transport
* Refactor the codec into its own .h and .cpp.
* remove useless tf dependencies
* Contributors: Mac Mason, Vincent Rabaud

compressed_image_transport
* remove useless tf dependencies
* Using cfg-defined constants
* Changed flag name, and corrected typo in flag use.
* using IMREAD flags.
* Updated for indigo-devel
* Contributors: Cedric Pradalier, Vincent Rabaud

image_transport_plugins

No changes

theora_image_transport
* remove useless tf dependencies
* Contributors: Vincent Rabaud

And just coz it´s the best mix ever: https://www.youtube.com/watch?v=05LG-Fnq6lI

Not sure I'd say it's the best mix ever

what is the best mix ever then ?????? (except for a cucumber mojito of course)

https://www.youtube.com/watch?v=WBi-3vqiHlk


EXDF transformations when booting from XIVLauncher?

I noticed that EXDF transformations only load when XIVAlexander itself loads FFXIV (by restarting it through XIVAlexander). But when it does that, it does not load Dalamud injections. On top of that, it is inconvenient to launch FFXIV via XIVLauncher and then have to manually restart it and have XIVAlexander re-apply the transformations every time.
So, my question is, is there a way to launch via XIVLauncher (which also launches all my other tools), have the transformations applied, and still get Dalamud injected? or is that impossible?

Does installing xivalex via loader not work in your case?

Oh, I have been just loading it alongside FFXIV all this time via XIVLauncher. I completely didn't notice that it can be installed to load with FFXIV. That fixes it! Thanks again!


Fix: Unexpected Panic in Inference graph when it fails to create http request

What this PR does / why we need it:
Add  Error handling
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3078
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Only add  Error handling , no need test plan.
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

This is already being handled here https://github.com/kserve/kserve/pull/3079
Returning error here won't fix the IG's response code. It needed but more handling that as been added here https://github.com/kserve/kserve/pull/3039

This is already being handled here #3079 Returning error here won't fix the IG's response code. It needed but more handling that as been added here #3039

@rachitchauhan43 I checked on your PR #3039, and the critical part is STILL not handled as well.
the root cause of issue #3078 is when the serviceUrl is not legit,  NewRequest would throw an error (as specified here https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/net/http/request.go;l=856) and that error should be properly handled.

@HAO2167 : Makes sense. I was able to reproduce this and on logging the error really helps. It looks like this:
{"level":"error","ts":"2023-08-21T15:07:31-07:00","logger":"InferenceGraphRouter","msg":"An error occurred while preparing request object with serviceUrl.","serviceUrl":"http://single-3.default.{$your-domain}/switch","error":"parse \"http://single-3.default.{$your-domain}/switch\": invalid character \"{\" in host name","stacktrace":"...."}

Can you please add a unit test case as well for this ?

ok， I will add a unit test case.

@rachitchauhan43 I have already added a  unit test case.

@HAO2167 : can you fix DCO check ?

/assign @njhill

@njhill please help me check this pull request , thanks!

@yuzisun I've rebased the master  and pushed it again. Please help me retest. I hope this can be merged soon. Thanks!

/lgtm
/approve

@yuzisun I've rebased the master and pushed it again. Please help me retest. That would be great if this PR got merged soon. I can't wait for my first contribution.

@yuzisun I've rebased the master and pushed it again. Please help me retest. That would be great if this PR got merged soon. I can't wait for my first contribution.

Merged! Thanks for the fix


Documentation $enable-flex Needs Improvement

The documentation is confusing for newcomers looking to get started with sass and flexbox. Currently the documentation says:

Open the _variables.scss file and find the $enable-flex variable.
Change it from false to true.
Recompile, and done!

This is where it gets confusing: Most of us are using task managers like gulp or grunt, and dependency manages like bower. In my case I'm @import "bootstrap"; in my style.scss file. This leaves to questions which I think the documentation needs improvement:
To properly override this variable do I need go into bower_compoonents/bootstrap/scss/ _variables.scss and change it there or do I need to create that file in: /public/assets/sass/ _variables.scss with 1 variable $enable-flex: true
I wouldn't mind updating documentation if I knew this answer myself.

The documentation should suggest modifying _custom.scss instead. The Getting Started > Options section was updated, but not flexbox.
You can also create your own _custom.scss file and @import it before you @import bootstrap;.

If flex is the only thing you need enabled, you could always try @import "bootstrap-flex", but I can't guarantee that will work.

razh, that worked. :) I created a _custom.scss and @import before. Worked perfectly. :)

We're, uh, removing the option entirely. 😆 Won't be an issue anymore with #21389—we're going all in on flexbox.


[BUG] Unable to attach become of leaking mount

Describe the bug (🐛 if you encounter this issue)
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Perform '....'
See error

Expected behavior
First I check the current mounts
 mount | grep /plugins
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/publish/pvc-c65b6f5a-5722-4146-8c21-204210a05076/ad2d12d2-14ab-4e32-ba5a-685704e31f51 type devtmpfs (rw,nosuid,noexec,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-c65b6f5a-5722-4146-8c21-204210a05076/dev/ad2d12d2-14ab-4e32-ba5a-685704e31f51 type devtmpfs (rw,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/publish/pvc-35df1757-f209-44d5-adad-defe5f8abfd3/354fb482-e619-4060-b820-f564905b90f3 type devtmpfs (rw,nosuid,noexec,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-35df1757-f209-44d5-adad-defe5f8abfd3/dev/354fb482-e619-4060-b820-f564905b90f3 type devtmpfs (rw,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/publish/pvc-5245d792-840a-40b2-b78b-190044caa46b/012267b5-cfbe-40a1-a968-33f7c980375b type devtmpfs (rw,nosuid,noexec,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)
dev on /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-5245d792-840a-40b2-b78b-190044caa46b/dev/012267b5-cfbe-40a1-a968-33f7c980375b type devtmpfs (rw,relatime,size=10240k,nr_inodes=248418,mode=755,inode64)

One of the mount seem dose not have any PVC associated to anymore
master2 [~]# kubectl get pvc -A | grep c65b6f5a

I unmount it manually
master2 [~]# umount  /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/publish/pvc-c65b6f5a-5722-4146-8c21-204210a05076/ad2d12d2-14ab-4e32-ba5a-685704e31f51

In case if I see a detach PVC has his problem, this PVC will never able to mount this node.
Log or Support bundle
If applicable, add the Longhorn managers' log or support bundle when the issue happens.
You can generate a Support Bundle using the link at the footer of the Longhorn UI.
Environment

Longhorn version: 1.4.1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s

Number of management node in the cluster: 3
Number of worker node in the cluster: 4

Node config

OS type and version: ubuntu 22
CPU per node: x86_64
Memory per node:  32G
Disk type(e.g. SSD/NVMe): ssd
Network bandwidth between the nodes: 10G

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 50

Additional context
Add any other context about the problem here.

Could you check about volume attaching/detaching or CSI events?
Providing the support bundle will be helpful to analyze the root cause,
Does one volume (ex: pvc-c65b6f5a-5722-4146-8c21-204210a05076) unable to attach affect other volumes (ex: pvc-35df1757-f209-44d5-adad-defe5f8abfd3) leaking mount?


vimeo videos issue

To watch the fullscreen version of the videos you need to have to create a vimeo account and log in. can the videos not be opened up so you do not need to have to log in to watch in full screen. (I can watch in small version on web page but would be better in larger format)

This is not an issue of the SCR, so closing.


Date component allows some weird characters

The Date component allows users to input some non-numeric characterse, ., + and -

Related: https://github.com/alphagov/govuk-frontend/pull/117
Hanna if you could take a look, that would be ace!

These are all allowable characters for a numeric field. See here for discussion on letter "e".

Hi Gemma,
Assigning this to you to review. Let me know if there are any more actions for me here.
Thanks,
Hanna

Yes we can close - this markup no longer exists in GOV.UK Frontend.


Output for mixer is incorrect

STL file does match design placed on grid no matter the configuration set for the mixer.

Fix in progress; have temporarily disabled this functionality to remove confusion. Please use SVGs for now.


wrong translation for recommendation filter

use OS with English menus
go to the motion list

result: there is a German word:

Invalid, I had a custom translation.


Insert failed: Data too long for column 'link' at row 1

When submitting a dynamic URL with long path we get the error "Insert failed: Data too long for column 'link' at row 1". Please advise.

You get this error because I have set a limit on url length.
This limit is subjective and if you want you can change it by changing the length of the link attribute in the "dynamic_qrcodes" sql table


[T2A2-A5][T04-A1] Murray Chen

All the commits combined into one pr, am not sure how to separate them.
Ready for Review though.

@mchen14 please rename your pull request according to the right team name,

for the next tutorial onwards, make separate pull requests for each activity.

just to clarify, how does the tutorial label go? I put T04-A1 because I'm on team A1 in Tutorial group 4; is that not correct?

No. That is not correct.
If you attended the tutorial you would know that we assigned tutorial and team ID based on the tutorial slot. E.g. Wednesday 9 am tutorial is identified using W09.
Even if you haven't you should take a look a the module website which has clear instructions on how the tutorials are referenced.

:+1:


CHANGE_BEHAVIOR_OUT_IN and CHANGE_BEHAVIOR_IN paramerters for new ChangeText().setChangeBehavior() changes color from original

I have textview which has a text that changes on click its color value is #FF1D9ECB, on click I call
TransitionManager.beginDelayedTransition(container, new ChangeText().setChangeBehavior(ChangeText.CHANGE_BEHAVIOR_OUT_IN));
The animation of the text fading out the old text and fading in the new text happens nicely but the original blue color(hex value given above) changes to become green color.
Why does this happen? it doesnt happen for CHANGE_BEHAVIOUR_OUT which I am using for now but I want the behaviour of CHANGE_BEHAVIOR_OUT_IN without the color change.
I am using version 1.7.3 of the library

Hi,
It was indeed the bug. I fixed it and released in 1.7.4. Thanks
I also created a framework bug for that typo in the code:
https://issuetracker.google.com/issues/62422305


For a 0.15.6 release

#447

Codecov Report

Merging #448 (fcd501b) into master (17d3bbb) will decrease coverage by 2.43%.
The diff coverage is n/a.

:exclamation: Current head fcd501b differs from pull request most recent head b1c9877. Consider uploading reports for the commit b1c9877 to get more accurate results

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   74.95%   72.52%   -2.44%
==========================================
  Files          12       12
  Lines        1022      837     -185
==========================================
- Hits          766      607     -159
+ Misses        256      230      -26

Impacted Files
Coverage Δ

src/registry/src/info_dict.jl
75.00% <0.00%> (-25.00%)
:arrow_down:

src/model_search.jl
70.93% <0.00%> (-3.07%)
:arrow_down:

src/builtins/Transformers.jl
93.73% <0.00%> (-2.70%)
:arrow_down:

src/builtins/Constant.jl
60.71% <0.00%> (-2.15%)
:arrow_down:

src/utilities.jl
13.79% <0.00%> (-1.36%)
:arrow_down:

src/builtins/ThresholdPredictors.jl
87.95% <0.00%> (-0.29%)
:arrow_down:

src/GaussianProcesses.jl
0.00% <0.00%> (ø)

src/registry/src/Registry.jl
0.00% <0.00%> (ø)

src/registry/src/check_registry.jl
0.00% <0.00%> (ø)

src/metadata.jl
80.00% <0.00%> (+0.21%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d3bbb...b1c9877. Read the comment docs.


db: Create a place in the db to store logs

Log event are received from the rfid readers in json format
e.g.
{"cmd":"log","type":"access","time":1616946502,"isKnown":"true","access":"Always","username":"Joe Shmo","uid":"23b6234","door":"esp-rfid"}

We may want to have some kind of mechanism that rotates the table so that we don't put too much data in.
https://www.postgresql.org/docs/8.2/ddl-partitioning.html

This is done


Add JSRT API for externalizing ArrayBuffers

This API gives the host control of an ArrayBuffer's lifetime

Should you provide isExternelize function as well from completeness?

I considered this, but there is no way to tell the type of array buffer now, e.g. whether an array was created with JsCreateExternalArrayBuffer or JsCreateArrayBuffer, so it didn't seem like it was necessary.


我想照着您的代码自己实现一份bitarray，如果最后成功了会加上mit协议，可以吗

很荣幸可以看到这份代码。

Of course, this project is open sourced, so you can copy and/or modify it as long as you follow the MIT license.
(I can't read/write Chinese, so I read it with Google Translate. I may have misunderstood the intent of your question.)

Thanks，you understand is right。


e2e: add etcd backup operator test

add an e2e test for etcd backup operator:

spawn etcd backup operator pod.
create etcd cluster.
invoke a backup cr for the etcd cluster.
verify that backup status shows succeeded.

cc/ @hongchaodeng @hasbro17

via https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator-e2eslow-pr/785/
22:05:02 time="2017-10-27T22:04:57Z" level=info msg="etcd operator created successfully"
22:05:02 time="2017-10-27T22:05:02Z" level=error msg="fail to setup framework: failed to create etcd backup operator: failed to wait pod running: unexpected pod status.phase: Failed"


Issue with Gist badge

I tried to use the badge related to Gist for my profile (actually, I have no public Gists).
Link
I retrieved this error:
{   "message": "An error occured while processing your request, please create an issue on https://github.com/puf17640/git-badges/issues and give as much detail as you can. Thanks!" }
So I opened the issue. Is this issue triggered by the lack of public Gists on my profile? What do you think about that?
Thank you for your badges; they are really nice!

I've met this problem too. It seems that the gists' api will not respond when the requested user has no gists. This may lead to the problem of the badge.

This is fixed in the rewrite


Update loader design document

Update loader design document to remove discussion of runtime file locking/unlocking APIs, now removed in PR #38.

This is the html build from loader design source files, with changes made in gitlab MR1268.

Corresponding MR merged internally as well.


test: adds tests for atlas data lake

NODE-2691

@mbroadst I've put out a fix for all the things mentioned here except for a viable solution to the contradictory ping exceptions.


Serious bug in code word2vec.

When you calculate the _expTable, in file Word2Vec.cs line 88 you use a bad issued integer division, and this yields always 0 if  the numerator is less than numerator, which is always true, revise the calculated Exptable, all elements are the same. The solution is simple and is casting the ExpTableSize to double:
(other more elegant is to precompute is and define as a double constant, but this is used only on initialization) Also I would have done this as a static table, so if you use the class in a library more than once, you don't need to recalc the exptable every time (provided sizes are the same)
code from line 86 (aprox.)
for (var i = 0; i < ExpTableSize; i++)
            {
                _expTable[i] = (float)Math.Exp((i / (double)ExpTableSize * 2 - 1) * MaxExp); // Precompute the exp() table
                _expTable[i] = _expTable[i] / (_expTable[i] + 1); // Precompute f(x) = x / (x + 1)
            }

NOTE: this kind of errors (integer divisions rendered as integer, and thought as floating point) are rather common on porting from C++, be careful, I am still searching the code for them!

I have fixed and committed a new Push - Thank You for pointing out this error.
Gunt


wlr/taskbar won't exec on-update when all windows are closed

I have a custom global title bar looks like:
"custom/title": {
"exec": "echo get the active window title",
"signal": 18
}
and I set wlr/taskbar on-update to "pkill -RTMIN+18 waybar" in order to update the title

but when I close all windows it still shows previous active window title.
I wonder is there a better way to do this?

I can confirm this. My impression is that only change of active window is really triggering on-update, but I could be mistaken. Right now I'm not sure where to start with troubleshooting. Even in a nested session it's tricky to do anything without any window present. ;)
You ask if there is a better way to do this, that depends on your compositor. Which is it?
E.g. in sway, I can subscribe to window events, and use this subscription in a continuous worker shell script to output json whenever an event arrives. But for sway I'd rather use sway/window. :p
If your compositor has anything like an IPC interface with events I'd probably explore that.


Is there any way to clear cached results from the select2 dropdown?

Creating a JSBin would be rather hard for my problem, but I will try to explain it the best as I can, and later will try to get a JSBin example together also.
Basically, I have two select2 instances on a page, an ajax sourced one, and a simple one. The two are connected, meaning that when I use the ajax sourced one, it fetches the data selected in the simple select2, and sends it with the ajax request, so that only a subset of the data is returned by the ajax (the data that is relevant to the situation).
My problem is, that when I open the ajax sourced select2, for a split second, before loading starts, the previously displayed result set is visible. But if in the meantime, the simple select2 was changed, the data displayed for that split second is not relevant any more. Worse by this, the data is not only displayed, but if I am quick enough (or if my server is slow enough to retrieve the data from the ajax), the irrelevant data can still be selected.
Is there any way, on how I could clear those cached results from the ajax sourced select box? I could hook an event listener to the simple select, that when it changes data, this clearing function should run, but I didn't find any method in the docs, that deals with clearing the data from the dropdown.

up

have the same issue and use results.clear() work for me
on simple select change clear the select ajax select2 results
...
$('#simple-select').on('change', function(){
    $('#select2Ajax').data('select2').results.clear()
})
...


Changes for bevy 0.11-dev

This is a draft version of the changes needed for this project to work with bevy-main.
The main change is the new add_systems, which now takes the schedule pattern as a first parameter and a tuple of systems as the second. add_system (singular) is now deprecated.
Another breaking change was flipping the y coordinate for consistency. This means we can remove the inverted mouse in the process_input_system.
Will add more to this draft if there are further breaking changes.

Thanks for doing this! I've noticed when running the ui example in this fork, it panics with
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/egui_node.rs:47:73

which corresponds to this line
let render_device = render_world.get_resource::<RenderDevice>().unwrap();

bevy_egui expects to find a RenderDevice resource, but there is none. The problem is limited to 0.11.0-dev (running on upstream main, the ui example works as expected).
I haven't been able to figure out what's going on. (Maybe in bevy-0.11.0-dev, inserting the RenderDevice resource happens at a later scheduler phase?

I haven't been able to figure out what's going on. (Maybe in bevy-0.11.0-dev, inserting the RenderDevice resource happens at a later scheduler phase?

I believe this is correct, In the lib.rs I changed the
    // Line 587
    .init_resource::<egui_node::EguiPipeline>()
    .init_resource::<SpecializedRenderPipelines<EguiPipeline>>()
    .init_resource::<EguiTransforms>()

resources to be added by another system with the ExtractSchedule schedule, fixes the RenderDevice resource being None; but I do have another potentially unrelated bug where the fonts aren't rendering anymore, but maybe this insight helps a bit for now.

@diinki brilliant! This worked for me. @josekoalas in case it's helpful, this commit is what gets ui working for me: https://github.com/imalsogreg/bevy_egui/commit/0393b7c68ddd12061f8790f007592961686baea3
(I didn't think very carefully about the naming)

@diinki @imalsogreg I was playing around with both of your changes on bevy main but with webgpu and wasm and everything works great... just one thing :)
There's an error with the color attachment setup in the render pipeline pass.
This commit got it working:
seabassjh@7ee68d3
Tested in Chrome Stable version 114.
Hopefully someone can reproduce this error and fix on their machine!

I'd like to mention that this commit changed the name of schedule::apply_system_buffers to schedule::apply_deferred.
This commit causes more necessary changes in lib.rs ( just change the name of apply_system_buffers everywhere to apply_deferred c: ).
I'll update my fork to work with the latest version of Bevy in a bit, if anyone wonders which commits would fix the bugs as well :p

I'll close it as #188 has been merged. But thank you for your work!


Decouple make and docker

Building Benthos through docker-compose or docker currently doesn't work, as it requires running make to solve dependencies.
(My setup: benthos is a git submodule in my project repo, I use docker-compose to build it from the root directory with some more components)
This is effectively decoupling Dockerfile and Makefile, allowing docker build to work without invoking make.
Hope it fits the project.

Hey @Tapuzi, I'm in favour of removing the need for vendoring but ideally we'd need to replace it with something else, otherwise we'd end up re-downloading modules any time there's a minor code change.
I'm a bit rusty on docker stuff, but I believe there's a few different approaches to solving this, either we can add a layer to the build that contains only go.mod and go.sum and does the download, and that'll therefore only be rebuilt when those files change. Or alternatively we don't do a download within the docker build but we copy the mod cache from the host machine, either as an explicit copy or as a volume.

Good points.
I want to offer another solution:
To solve the issue in my projects, first I copy the dependency file and install the deps, then copy the entire directory.
So if go.mod file is left unchanged, docker build uses the previously cached layer with installed modules. Should look like this:
COPY go.mod /go/src/github.com/Jeffail/benthos/
RUN go mod tidy; go mod vendor
COPY . /go/src/github.com/Jeffail/benthos/

(I find this more elegant than multi stage builds, as it keeps things simple and only relies on docker's build cache.)
Please let me know what you prefer implemented.

I am setting up a version with my proposed solution for now, and I have some minor issues to solve.
(I think they are minor)

Hey.
After reading a bit about go module management, I propose this solution.
I was not enough aware of how go manages dependencies, so please disregard nonsense I may have said previously. (not sure how much of it came out).
This patch should reuse a cached module layer in case go.mod and go.sum are unchanged, so it relies on them being in sync at the build branch, i.e. make deps or go tidy, behaves well with the defined CI.
There is an additional optimization option here:
I read a bit about some build optimizations that can be made.
The article mentions a small additional enhancement that can help speed the build process - caching the build directory. This approach can also be used for go's module cache.
I didn't include it because personally I think it's not a good idea, as a Docker user, because it requires some additional work from Docker users before running docker build that I find unintuitive and a bit frightening. So... its a bit different for each OS (requires user intervention which is bad), generally requires make to be installed and some environment variable to be set.
(in my experience, I expect docker build to work out of the box; Docker, however, in their docs say this new thing is the future "since version 18.09"... and I don't trust their docs.)
This is what an unsuspecting Docker user may stumble into with this option:

So now he will have to visit (!) a webpage (!!) instead of pressing enter.
Anyway if you feel this option is good for Benthos, I offer to implement it as well, its pretty simple, just let me know. (reference)

Thanks @Tapuzi, this looks like the ideal solution!


Build error attempt to build pcl:arm-linux

Package: pcl:arm-linux
Vcpkg version: 2020.01.17-unknownhash
ninja: build stopped: subcommand failed.
No other details provided in build error log or dbg-out log

@spmuske00, does this still be a problem for you?

This issue hasn’t been updated more than 3 months, if it is still an issue, please reopen this issue.


Skillstry1

Morning Girls,
I ask you four to check this pull request because in it, i did the JS partition.
when you have time, please can you check the request. Maybe is a little bit messy.
To summarize, what I did was:
-JS partitions,
-Skills Max changed,
-Skills check and unckeck done.

maybe you will also see, that the data icons appears, but doesnt dessapeared, don't worry, everything is ok, and the data goes to JSON. I'm just trying to do it in a more intuitive way by leaving the icons, so that they disappear when writing in a field.

Thanks girls,
have a nice day.

I've checked the code and it's functioning wonderfully.
Thank you for the amazing job you've done.


Remove I2C and Update API and RDK in revolution pi module

@thegreatco I may have fixed the build issues :)

Can I merge this in or no?


Concatenating two pandas.Series objects results in modin.pandas.dataframe

System information

OS Platform and Distribution:  Windows 10 WSL with Ubuntu 18.04.3 LTS
Modin installed from (source or binary): conda pip install modin
Modin version: modin==0.6.3
Python version: Python 3.6.6
Exact command to reproduce:

import pandas
import modin.pandas as pd
s1 = pandas.Series(['a', 'b']) # type(s1) pandas.core.series.Series
s2 = pandas.Series(['X', 'Y']) # type(s2) pandas.core.series.Series
s = pd.concat([s1, s2], axis=0)
type(s) # modin.pandas.dataframe.DataFrame

Describe the problem

In the original script using pandas I have a pandas.DataFrame, where I take two pandas.Series and concatinate them on axis=0. The resulting series is then used as input for parameter data={'name': my_series} in the pandas.DataFrame(...) command.
While substituing pandas with modin.pandas, the two columns taken from modin.pandas.DataFrame, being pandas.Series objects, are concatinated not into modin.pandas.Series but into modin.pandas.DataFrame which then breaks the skript.
Source code / logs

Hi @fritz-morgendorfer, thanks for posting !
I suggest you either use modin or pandas as each supports its own Dataframe and Series operations
import modin.pandas as pd

s1 = pd.Series(['a', 'b'])  # type(s1) modin.pandas.series.Series
s2 = pd.Series(['X', 'Y'])  # type(s2) modin.pandas.series.Series
s = pd.concat([s1, s2], axis=0)     # type(s) modin.pandas.series.Series

In case you have pandas.Series as input, you can convert them to modin.Series and later concat into modin.Series
s1 = pd.Series(pandas.Series(['a', 'b']))
s2 = pd.Series(pandas.Series(['X', 'Y']))
s = pd.concat([s1, s2], axis=0)

Let me know if this solves the issues

Thanks for the response. I was just wondering if it is possible to really change just one line of code in my existing project to enjoy all the benefits. I woundn't like to change anything more than the import statement. While it is obviously not yet the case with the project under consideration, the proposed solution would help if I were working on new code.
The two pandas.Series objects appear as a result of some operations on modin.pandas.dataframe that are just not yet implemented in modin, so I guess this is an issue of the current state of the project.

When working only with modin this is not an expected behavior.
Could you please share which operations on modin.pandas.dataframe resulted in pandas.Series?

@fritz-morgendorfer Is there a groupby that produces these pandas.Series objects? There was a case where we defaulted to pandas but did not return to a modin.pandas.Series for groupby, but that was fixed in #908.


Filter in explorer

The filter as designed in Figma various to the one that we currently have in :https://explorer-git-feat-microblocks-blockstack.vercel.app/transactions
Creating this ticket for the purpose of tracking and confirmation

between the design and actual state

I'll close this issue for now since we won't work on it


(PUP-7880) Ensure log message attributes are UTF-8

Log message objects contain attributes other than the string
message itself, which may be concatenated to form the actual string
to write when the handle method of each instance of
Puppet::Util::Log::Destination is executed.
For instance, the :console destination and :file destination may
concatenate the @source and @message of a Log message.

While Puppet began coercing log messages to UTF-8 as part of
c47be2d3b3d002f02cbed6edee8dfee119152b46 it didn't also coerce the
source.
In many circumstances, Ruby is happy to concatenate UTF-8 strings
with strings of other encodings that only use 7-bit ASCII characters
that are consistent amongst all encodings.
However, it is also possible under certain circumstances to
generate a @source and @message that are of different encodings
that cannot be concatenated.
In such cases, attempts to log will result in Puppet crashing with
an error like:
Error: Failed to apply catalog: incompatible character encodings: IBM437 and UTF-8

Such a failure occurs when running the following manifest through
Cygwin:

     file { "c:/temp":
       ensure => directory
     }

     file { "c:/temp/unicode_dir_ㅀㅅㅶㅅㅲㅂㅄㅉㅑㅧㅩㅙㅘ":
       ensure  => directory,
       require => File['c:/temp']
     }

     user { "bob":
       ensure     => present,
       groups     => 'Users',
       managehome => true,
       password   => "L0v3Pupp3t!"
     }

     acl { "c:/temp/unicode_dir_ㅀㅅㅶㅅㅲㅂㅄㅉㅑㅧㅩㅙㅘ":
       permissions => [
         { identity => 'bob', rights => ['full']  },
       ],
     }

Log destinations should have already had their messages groomed
so that both the @source and @message attributes are uniformly
in UTF-8, so that specific log implementations like :console and
:file don't have to be aware of any additional string coercing
behavior.

Add tests demonstrating the problem, noting that the :console
log destination is being used specifically as it has special
behavior when calling handle for generating actual messages.

Nice

approved pending travis/appveyor

I have run against the ACL module tests that were failing with:
PUPPET_AGENT_SHA=381a34773d5857b7b26e0a8e8576b95bdb64937d PUPPET_AGENT_SUITE_VERSION=<IP_ADDRESS>.g381a347 PUPPET_INSTALL_TYPE=agent bundle exec beaker --options-file acceptance/.beaker-git.cfg --hosts hosts.yaml --tests acceptance/tests/parameter_target/add_perms_to_unicode_file.rb,acceptance/tests/parameter_target/add_perms_to_unicode_dir.rb

Results (took a while as I was actively debugging):
      Test Suite: tests @ 2017-08-25 15:25:18 -0700

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 302.81 seconds
      Average Test Time: 151.40 seconds
              Attempted: 2
                 Passed: 2
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 2

To follow-up on why I was able to run the manifest successfully locally, while not through Beaker / Cygwin.  The Beaker / Cygwin situation was using puppet apply and taking a UTF-8 manifest and pushing it over stdin.  When pushed over stdin, the input was  treated as IBM437 instead of UTF-8 as would be parsed from a manifest.  As a result, things get wacky quickly.
I'm going to update those tests to scp a manifest file over, rather than pushing it out over stdin -- but this PR merge need not wait for that.

CLA signed by all contributors.


Install Java 11 JDK on Red Hat OSes

This fixes https://github.com/voxpupuli/puppet-jenkins/pull/1053 and also some other things that have broken by now.

I do wonder if we need to mention anything about this in the docs.


Dynamic Pipeline stalls

Hi,
I wanted to run a simple hello world program in the dynamic pipeline of Proteus but the core somewhere stalls. Running the same program on the static version yields the expected results.
Therefore my question before spending further time debugging: is the dynamic pipeline supposed to run properly or is it work in progress?
As reference I'll attach the elf of the program, the expected output is:
$ ./sim/build/sim ../PROT-RUN/program.bin
Factorial is 3628800
End of execution
Progam has exited with code:0x0

hello.elf.zip

Hello, thanks for submitting an issue!
The dynamic pipeline is supposed to have the same functionality as the static pipeline. When converting your program to a binary file with riscv32-unknown-elf-objcopy -O binary hello.elf hello_github.bin and then running it with either simulator (both the static pipeline obtained with make -C tests CORE=riscv.CoreExtMem and the dynamic obtained with make -C tests CORE=riscv.CoreDynamicExtMem), I get the same output as you:
$ ./sim/build/static hello_github.bin
Factorial is 3628800
End of execution
Progam has exited with code:0x0
^C
$ ./ProteusCore/sim/build/dynamic hello_github.bin
Factorial is 3628800
End of execution
Progam has exited with code:0x0
^C

Note, however, that in both cases, I had to force cancel the simulation, it did not stop at the end of the program. Maybe the reason you don't see the output for the dynamic pipeline is related to this, and it's just a buffering issue? (The dynamic simulation can also take longer than the static pipeline, due to the complexity of the hardware.)
For stopping the simulation, see here. This should also happen automatically (as far as I know) for C programs compiled with the RISC-V toolchain, e.g.,:
lui     ra, 0x10000
li      sp, 4
sb      sp, 0(ra)

Let me know if you figure this out or need further assistance!

I know that the FW does not stop, it has been 'reused' from another system.
Actually I did check the waveform and saw that the dynamic pipeline did miss as function return...
What version of Scala/sbt/SpinaHDL/verilator are you using? In the past I found cases where verilator had issues simulating SpinlaHDL generated constructs...

Can you try using our Docker container? For me it also works with that version, and that should be easier to reproduce.
For information, the versions in the container are:
root@proteus:/proteus# sbt --version
sbt version in this project: 1.8.0
sbt script version: 1.8.2
root@proteus:/proteus# verilator --version
Verilator 4.038 2020-07-11 rev v4.036-114-g0cd4a57ad

The Scala and SpinalHDL versions are stored in build.sbt.

THX for the quick reply, this helped a log to sort out potential issues and brought me to the root cause.
I tried to set the ibusLatency of the fetcher to 1 which works for the static pipeline but not fopr the dynamic one. Is there any limitation on the range?

Great that you found the root cause! I'm not aware of any such limitation, this sounds like a bug.
You're definitely very welcome to try to find a fix and I will try to help, but I'll only have time in a week or two to look into this in more detail.

I finally started looking into this: to me it appears that setting ibusLatency = 1 breaks both the static and the dynamic pipeline (which is not unexpected, as the Fetcher plugin is shared among them), I will investigate the cause further.
Not sure if this issue is still relevant for you, but I'll let you know when it's fixed :)

Fixed by c7a6c62d2313240f946c5dca9118bcff9f4a8644

THX for fixing this, it is still relevant for us. I will check quite likely next week...


Reimplement embed_migrations! using Macros 1.1

There wasn't a ton of code that could be shared between the old crate
and the new one, as the majority of the lines of code are just the setup
of the structs and functions used, which need to go into the respective
quote macro. In order to share that code, it'd have to be moved into
Diesel proper and out of the macro output, which I want to avoid. Since
the syntex crate will be removed once Macros 1.1 is stable, we can live
with the duplication for now.
This is based on code from #470, and I've committed as the author of that PR.

@killercup Review?


Where is the paper?

Hi could you please tell us where I can  find the paper?

The paper has been submit to arxiv today, just wait for a while. I will add link of paper once released.

Thanks very much for the quick reply！


Replays in the vault fail to load more often than not

Starting replays (particularly larger team games) from the vault will very often start the game but then give an error and just leave FA on the menu.
The errors given look like this:
java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: 'init_fafbeta.lua' could be found.
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(Unknown Source)
at com.faforever.client.task.CompletableTask.lambda$new$1(CompletableTask.java:17)
at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
at javafx.base/javafx.event.Event.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.EventHelper.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.Task.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.Task.setState(Unknown Source)
at javafx.graphics/javafx.concurrent.Task$TaskCallable.lambda$call$2(Unknown Source)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$9(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.IllegalArgumentException: 'init_fafbeta.lua' could be found.
at org.springframework.util.Assert.isTrue(Assert.java:118)
at com.faforever.client.patch.SimpleHttpFeaturedModUpdaterTask.call(SimpleHttpFeaturedModUpdaterTask.java:83)
at com.faforever.client.patch.SimpleHttpFeaturedModUpdaterTask.call(SimpleHttpFeaturedModUpdaterTask.java:26)
at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
... 1 more
To Reproduce
Start a replay from the vault such as this one: "https://content.faforever.com/faf/vault/replay_vault/replay.php?id=11183892"

The vault has become sentient. This is how it all starts! 😱

Can u give an example of a game with regular faf as well or does it only aplly to faf beta?

And I get the same error for your replay

The replay u sent has malformatted info in it as it seems the replay file says it is a faf game the server says it is a faf beta game, I cosider that replay file as broken

This seems to be based on bad replay data. Also #1866 should fix issues although may still desync

This seems to be based on bad replay data. Also #1866 should fix issues although may still desync


Cleaned up consensus time in graphql

Put the Slot and Epoch modules into it's own file
Removed the mli file for Consensus_stake_hooks because the

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet.
Explain your changes here.
Explain how you tested your changes here.
Checklist:

[ ] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Closes #0000
Closes #0000

Removed the mli file for Consensus_stake_hooks because the

This sentence in the description is incomplete. Why did you remove the mli?


Add PGO version to benchmarks

Is your feature request related to a problem? Please describe.
Hi, I ran the benchmarks yesterday on my machine (Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz) and did a quick experiment with PGO. The wallclock results are even more impressive and are eventually worth adding to the benchmark section.
Describe the solution you'd like
Make user aware of PGO, link the section in Rust documentation and add some additional estimates of benchmarks.
Additional context
Two examples with least and most improvements. I have seen a consistent improvement for all benchmarks, especially for the parallelized version.
Matrix multiplication (f32)

 with PGO    w/o PGO

    n       faer  faer(par)    ndarray   nalgebra      eigen
   32        1µs      828ns      1.4µs      1.7µs      812ns
   64      4.8µs      4.8µs      7.3µs      9.5µs      4.6µs
   96     14.9µs     15.5µs     18.9µs     29.6µs      8.3µs
  128     36.6µs     21.8µs     43.3µs     67.5µs     21.7µs
  192      115µs       39µs     42.7µs    221.9µs     31.4µs
  256    272.5µs     80.2µs    133.7µs    513.3µs     81.6µs
  384    910.1µs    247.4µs    223.8µs      1.7ms    179.3µs
  512      2.3ms    530.9µs    610.9µs        4ms    574.6µs
  640      4.4ms    998.5µs      1.1ms      7.8ms    895.4µs
  768      7.5ms      1.6ms      1.4ms     13.4ms      1.3ms
  896     12.2ms      2.7ms      2.6ms     21.5ms      2.6ms
 1024     18.9ms        4ms      4.1ms     32.2ms      3.5ms

    n       faer  faer(par)    ndarray   nalgebra      eigen
   32      1.3µs      1.1µs      1.5µs      1.9µs      811ns
   64      5.5µs      5.4µs      7.4µs      9.9µs      4.3µs
   96     15.9µs     56.4µs     20.1µs     30.5µs      8.3µs
  128     38.9µs     64.6µs     43.7µs     69.3µs     21.7µs
  192    118.1µs     80.4µs     42.6µs    222.7µs     31.5µs
  256    278.5µs    114.1µs    133.3µs    512.1µs     81.2µs
  384    936.1µs    330.9µs    226.2µs      1.7ms    179.1µs
  512      2.3ms    636.4µs    590.5µs        4ms    570.3µs
  640      4.4ms      1.2ms      1.1ms      7.8ms      895µs
  768      7.5ms      1.9ms      1.4ms     13.4ms      1.3ms
  896     12.6ms      3.1ms      2.6ms     21.4ms      2.6ms
 1024     18.6ms      4.5ms      4.8ms     32.1ms      3.5ms

Thin matrix singular value decomposition (f32)

 with PGO    w/o PGO

    n       faer  faer(par)    ndarray   nalgebra      eigen
   32    942.2µs      1.3ms      5.8ms      2.8ms      1.7ms
   64      2.6ms      3.2ms       16ms     10.9ms      5.3ms
   96      5.2ms      6.2ms     29.6ms     24.6ms     11.4ms
  128      8.2ms        9ms     45.8ms     43.2ms     17.6ms
  192     16.6ms     16.1ms     64.3ms     98.3ms     36.1ms
  256     27.7ms     24.6ms     94.2ms    185.1ms     61.6ms
  384     57.8ms     44.5ms    147.2ms      445ms      118ms
  512    102.9ms     68.6ms    222.5ms    926.3ms    201.8ms
  640    160.9ms     93.9ms    295.2ms      1.53s    311.4ms
  768    236.9ms      127ms    368.9ms      2.49s    602.2ms
  896    328.2ms      166ms    469.9ms      3.65s    611.1ms
 1024    453.5ms    215.1ms    732.9ms      6.07s    808.6ms

    n       faer  faer(par)    ndarray   nalgebra      eigen
   32      1.5ms      2.5ms      5.7ms      3.1ms      1.7ms
   64      4.3ms      6.2ms     16.2ms     11.5ms      5.1ms
   96      8.3ms     13.9ms     29.6ms     25.5ms     10.8ms
  128     13.4ms     21.7ms     43.7ms     45.3ms     17.6ms
  192     27.4ms     43.9ms     73.1ms    102.8ms     34.4ms
  256     45.8ms       72ms     94.5ms    194.1ms     54.4ms
  384     94.6ms    128.7ms    147.9ms    451.9ms    112.9ms
  512    166.7ms    210.5ms    219.9ms    962.4ms    190.5ms
  640    258.1ms    313.3ms    288.2ms      1.53s      299ms
  768    385.5ms    443.6ms    367.1ms       2.5s      431ms
  896    526.4ms    578.5ms    466.4ms      3.61s      596ms
 1024    708.7ms      739ms    719.9ms      6.19s    789.8ms

f64_pgo.txt
f64_wo_pgo.txt
f32_wo_pgo.txt
f32_pgo.txt

that's impressive. ideally i'd want to take the non-pgo code and manually optimize it so that it's as fast as the pgo code. so this gives us a new avenue for improvement. i'll try experimenting around with this

ah no I had the profile generation environment variable set during the baseline run. Now the results are looking more reasonable within the normal 10% improvement margin. That is what I would expect and the point mentioning it for benchmarks is now much weaker. Sorry for the noise


fix payload digest for chunked response in test warc

exposes https://github.com/webrecorder/warcio/issues/74

sha1 computed like so:
$ warcio extract --payload test/data/example-iana.org-chunked.warc 405 | sha1sum
8846f23ce943a3b70089f86345626778cd93f11e  -

Sorry I don't have a fix for the bug :)

Bug reports lacking a fix are welcome, but pull requests are more for things that don't break the build! Also, can you please respond to the thread in #74 as to why an extremely disruptive change should be made that invalidates all digests compute before the change? Any actual fix is going to need to support old-style-but-valid and new-style-and-valid digests.

Also, can you please respond to the thread in #74 as to why an extremely disruptive change should be made that invalidates all digests compute befored the change?

I didn't think there was any controversy about interpretation of the warc spec. The first comment on #74 spells it out clearly and concisely (thanks @JustAnotherArchivist).
This change doesn't affect "all digests". It only affects records with tranfer-encoded payloads. I fail to see how this is "extremely disruptive"? It's not about old-style vs new-style. The fact that we're here debating this is ironic because the test warc that this pull request applies to was written by warcprox. The original warcprox code had this bug in payload digest calculation and I fixed the bug in 2017.
There are lots of warcs out there with incorrect payload digests (on chunked http responses), and lots of warcs out with correct payload digests. Given that, we should follow the spec going forward.

Bug reports lacking a fix are welcome, but pull requests are more for things that don't break the build!

Fair enough. The failing test could be commented out until the fix is in place, I suppose?


Add a custom route to the Router object

I am trying to add my own route with my own controller to the Router object but with no success.
I cannot find any code exmple for that in the documentation. However I did manage to found one here
My use case is a custom component that needs to preview a record which is related to the current one. I tried to use a method from the sequelize's DAL layer (in the component), but an exception has risen: Error: Element Type invalid... No name was provided for external module {nodejs_module_name} in output.globals - guessing {nodejs_module_name} . With that said, the main problem with my implementation imo is a nodeJs function that isn't bundled into the component.
I'm wondering if the referenced issue can be helpful by creating an API endpoint for sequelize's DAL operations.

Not sure I understand but you should be able to add routes using your server framework, e. g. express:
adminRouter.get(<path>, <handler)

I tried to use a method from the sequelize's DAL layer (in the component)

Sequelize is not a frontend/browser library so it's normal it throws that error.


Add minified versions of css

There is a minified version of script, but no minified css.

Update: it is in fact minified, but the filename doesn't reflect it. The .min suffix should be added


Signature extraction failed

➜  Downloads  youtube-dl --verbose -x "https://www.youtube.com/watch?v=3JV74i4yvcA"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', '-x', 'https://www.youtube.com/watch?v=3JV74i4yvcA']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.10.24
[debug] Python version 3.5.0 - Linux-4.1.12-1-ck-x86_64-with-arch
[debug] exe versions: ffmpeg 2.8.1, ffprobe 2.8.1, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 3JV74i4yvcA: Downloading webpage
[youtube] 3JV74i4yvcA: Downloading video info webpage
[youtube] 3JV74i4yvcA: Extracting video information
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {22} signature length 40.44, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 661, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 291, in extract
    return self._real_extract(url)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1345, in _real_extract
    encrypted_sig, video_id, player_url, age_gate)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 827, in _decrypt_signature
    'Signature extraction failed: ' + tb, cause=e)
youtube_dl.utils.ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Same thing here
http://pastebin.com/Gr7JuH8K

You are indeed using an outdated version of youtube-dl. See our FAQ if you need help updating.


fixed links to section requirements within all slides

Links to internal training material, pointed to by entries in the "Requirements" section of many training's slides, were broken. This fixes the issue.
Example:
In the Quality control slides, page #2 links to the required introductory material using the following link
https://galaxyproject.github.io/training-material/introduction/
instead of
https://galaxyproject.github.io/training-material/topics/introduction/

Thanks @nsoranzo. I have rebased, and left package.json and package-lock.json as they were

Thanks @bagnacan, looks like I missed these in a previous refactor. Great catch!


CallbackRequests are no longer re-used, so adjust code accordingly

This class no longer has a need for a Clear since it is now only cleared at destruction, and thus some members are now also implicitly destructed and no longer need a clear invocation. Likewise, the Setup is now simpler since much initialization can be moved to default initializers. Some members can now be const.
(The previous code had relics from when the CallbackRequest structure was re-used across calls.)

Thanks for the prompt review! Rebasing before merger.


SonarCloudでカバレッジも確認するための対応

Codecov Report

Merging #32 (7f9e59c) into main (f3dd3ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   97.24%   97.24%
=======================================
  Files           6        6
  Lines         145      145
  Branches       20       21    +1
=======================================
  Hits          141      141
  Misses          4        4

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Search not working

Was basically wondering what do i need to remove from the script to not disable search?

Hello! You can use Restore Scripts to restore Windows Search functionality. Restore scripts are located in Debloater's folder or you can find them here!
You have to edit out these parts of the code

If you still experience problems, please let me know :smiley:


chore: update stale action schedule

✔ Checklist:

[ ] Commit messages have been written in Conventional Commits format;
[ ] This PR has been added to CHANGELOG.md (at the top of the list);
[ ] Tests for the changes have been added (for bug fixes / features).

Codecov Report

Merging #34 (84a32e4) into main (61c0464) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   93.89%   93.89%
=======================================
  Files           9        9
  Lines         573      573
=======================================
  Hits          538      538
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c0464...84a32e4. Read the comment docs.


[r-apt][r-rig] set PIP_BREAK_SYSTEM_PACKAGES=1 when installing pip packages

Close #162

Some tests on Debian 12 are failed because of lack of support by rig (r-lib/rig#162).

It seems r2u has an error (eddelbuettel/r2u#38).


Suppress warning in chefspec with chef 12.4

This PR will suppress following warning when running chefspec with chef 12.4:
WARN: You are overriding windows_package on {:os=>"windows"} with Chef::Resource::WindowsCookbookPackage: used to be Chef::Resource::Wi
ndowsPackage. Use override: true if this is what you intended.

For information, from Chef12.4, it gives warning when you are replacing DSL provided by another resource or provider class:
class X < Chef::Resource
  provides :file
end
class Y < Chef::Resource
  provides :file
end

This will emit a warning that Y is overriding X. To disable the warning, use override: true:
class X < Chef::Resource
  provides :file
end
class Y < Chef::Resource
  provides :file, override: true
end

reference:
https://www.chef.io/blog/2015/06/24/chef-client-12-4-0-released/

:+1: to clear out these warnings

@ksubrama, @lamont-granquist is there something I can do for this PR to be merged?
Our jenkins output is filed with this warning until this get merged. Though I could set windows cookbook to point my fork in Berksfile for now, I feel using official cookbook is cleaner solution.

yes that is the fix

My test didn't actually test the thing I wanted with Chef 11, verifying it now

:+1:  to clear these warnings


How can I create multiple instances of the cropper?

Hello,
I want to create multiple instances of the cropper.
How can I achieve this?
Thank you,
Bilal

https://github.com/fengyuanchen/cropper/blob/master/examples/multiple-croppers.html

I'm asking for multiple instance in the same image.

It's impossible to do that...


[Bug]: Function with multiline statement adds \n and fails

Terraform CLI Version
1.9.4
Terraform Provider Version
0.95.0
Terraform Configuration
resource "snowflake_function" "TEST_PARSER_VOLATILE_FUNC" {
  database = local.databases[var.DATABASE]
  schema = snowflake_schema.TEST_PARSER.name
  name = "VOLATILE_FUNC"

  arguments {
    name = "D"
    type = "DATE"
  }

  return_type = "TABLE (\"EVENT_DATE\" DATE, \"CITY\" VARCHAR(16777216), \"TEMPERATURE\" NUMBER(38,0))"
  language = "sql"

  statement = <<-EOT
AS '
SELECT d, ''New York'', 65.0
UNION ALL
SELECT d, ''Los Angeles'', 69.0
';
EOT
}

Category
category:resource
Object type(s)
resource:function
Expected Behavior

  # snowflake_function.TEST_PARSER_VOLATILE_FUNC will be created
  + resource "snowflake_function" "TEST_PARSER_VOLATILE_FUNC" {
      + comment              = "user-defined function"
      + database             = "DB_DPT_DEV_STG"
      + fully_qualified_name = (known after apply)
      + id                   = (known after apply)
      + is_secure            = false
      + language             = "sql"
      + name                 = "VOLATILE_FUNC"
      + null_input_behavior  = "CALLED ON NULL INPUT"

      + return_type          = "TABLE (\"EVENT_DATE\" DATE, \"CITY\" VARCHAR(16777216), \"TEMPERATURE\" NUMBER(38,0))"
      + schema               = "TEST_PARSER"
      + statement            = <<-EOT
            AS '
            SELECT d, ''New York'', 65.0
            UNION ALL
            SELECT d, ''Los Angeles'', 69.0
            ';
        EOT

      + arguments {
          + name = "D"
          + type = "DATE"
        }
    }

Actual Behavior
provider adds a return_behavior defaulted to VOLATILE.

  # snowflake_function.TEST_PARSER_VOLATILE_FUNC will be created
  + resource "snowflake_function" "TEST_PARSER_VOLATILE_FUNC" {
      + comment              = "user-defined function"
      + database             = "DB_DPT_DEV_STG"
      + fully_qualified_name = (known after apply)
      + id                   = (known after apply)
      + is_secure            = false
      + language             = "sql"
      + name                 = "VOLATILE_FUNC"
      + null_input_behavior  = "CALLED ON NULL INPUT"
      + return_behavior      = "VOLATILE"
      + return_type          = "TABLE (\"EVENT_DATE\" DATE, \"CITY\" VARCHAR(16777216), \"TEMPERATURE\" NUMBER(38,0))"
      + schema               = "TEST_PARSER"
      + statement            = <<-EOT
            AS '
            SELECT d, ''New York'', 65.0
            UNION ALL
            SELECT d, ''Los Angeles'', 69.0
            ';
        EOT

      + arguments {
          + name = "D"
          + type = "DATE"
        }
    }

Apply fails
│ Error: 001003 (42000): SQL compilation error:
│ syntax error line 1 at position 86 unexpected 'VOLATILE'.
│
│   with snowflake_function.TEST_PARSER_VOLATILE_FUNC,
│   on test_parser.functions.volatile_func.tf line 1, in resource "snowflake_function" "TEST_PARSER_VOLATILE_FUNC":
│    1: resource "snowflake_function" "TEST_PARSER_VOLATILE_FUNC" {
│
╵

Steps to Reproduce

Copy Configuration
update database and schema params
run apply

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
No response
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Hi @epmenard-ia 👋
You closed this issue. Is it still relevant? Functions are currently being reworked, so we'll take a look at this issue then.
cc @sfc-gh-asawicki

Hi, turns out extensive testing changed the source of the issue so I closed it. I’ll open a new one regarding the actual problem, thanks for the follow up!
From: Jakub Michalak @.>
Sent: September 19, 2024 4:08 AM
To: Snowflake-Labs/terraform-provider-snowflake @.>
Cc: Ménard, Eric Pierre @.>; Mention @.>
Subject: Re: [Snowflake-Labs/terraform-provider-snowflake] [Bug]: Function with multiline statement adds \n and fails (Issue #3089)
!!Attention COURRIEL EXTERNE/EXTERNAL EMAIL
Hi @epmenard-iahttps://urldefense.com/v3/__https:/github.com/epmenard-ia__;!!C_xIDw!swjlGWMRvb3pkC3UyOlB9ezus6Uejzdo2mJqBJ1oAdPMbRYURWU7xGQgTWS_6cTCnWcw5Y4EOuMG89S_yC5792CAMhzWAA$ 👋
You closed this issue. Is it still relevant? Functions are currently being reworked, so we'll take a look at this issue then.
cc @sfc-gh-asawickihttps://urldefense.com/v3/__https:/github.com/sfc-gh-asawicki__;!!C_xIDw!swjlGWMRvb3pkC3UyOlB9ezus6Uejzdo2mJqBJ1oAdPMbRYURWU7xGQgTWS_6cTCnWcw5Y4EOuMG89S_yC5792C7ewicsA$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3089*issuecomment-2360280336__;Iw!!C_xIDw!swjlGWMRvb3pkC3UyOlB9ezus6Uejzdo2mJqBJ1oAdPMbRYURWU7xGQgTWS_6cTCnWcw5Y4EOuMG89S_yC5792AYPKnr7A$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BLMSRXXEXFQZCEZRC4RPEPDZXKA6PAVCNFSM6AAAAABOOG75TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQGI4DAMZTGY__;!!C_xIDw!swjlGWMRvb3pkC3UyOlB9ezus6Uejzdo2mJqBJ1oAdPMbRYURWU7xGQgTWS_6cTCnWcw5Y4EOuMG89S_yC5792AvCz7P1w$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Accept async functions for StreamExt::map() and others

The StreamExt::map(), StreamExt::filter_map() in the futures crate accepts async functions which resolve to an <T>/Option<T>, whereas the same methods in the futures-lite crate accept normal functions which are meant to return <T>/Option<T>. (there are other similar methods as well)
I don't know if this is by design or a mistake, but since this crate is supposed to be fully compatible with the futures crate, I think these methods should be changed accordingly.

The current behavior is what was intended by the original author of this crate.
https://github.com/rust-lang/futures-rs/issues/1987#issuecomment-661028051

since this crate is supposed to be fully compatible with the futures crate

Full compatibility is about traits such as streams, not about method signatures. Readme also says:

fixes minor warts in its API, fills in some obvious gaps

The usual strategy is to use the then() combinator to evaluate an async closure, and then use the result of that in filter_map(), map() etc.


Priy1289/feature layer dictionary renderer

android sample for feature layer dictionary renderer.

Thanks for the review @TADraeseke. my bad, I missed the reformat code, before pushing to branch.

@TADraeseke changes requested were done. Thank you!


Lazyxds Not Work

Describe the bug
A clear and concise description of what the bug is.
After Deploying Lazyxds,Adding The Service Of productpage Annotation (lazy-xds: "true"),The EDS Of productpage Should Not have Other Service's EDS. Thanks.
To Reproduce
Steps to reproduce the behavior:

Deploy The Lazyxds:

Pods Running

3.Annotation
Productpage  Service :

bookinfo namespace:

Productpage  Pod‘s  EDS:

EDS Has Other EDS Info.
Logs
lazyxds:
lazyxds.log
egressgateway-lazyxds:
egressgateway.log

ENV：
1、k8s Version

2、Istio Version

The ConfigMap lazyxds-als-bootstrap:

The Service lazyxds.istio-system is What? Not The Service In istio-system.

@liyongxian  lazyxds has been moved into a standalone repo here: https://github.com/aeraki-mesh/lazyxds
Could you please move this issue to that repod?


[CoreKit-Swift] Update the personal sign implementation

please resolve the conflicts

Closing since the changes were pushed with Auth0 PR.


[Fix] Fixed coupon discount

Se inhabilita descuentos cuando hay procesadora y no hay descuento para que no de la posibilidad al usuario de ingresar un código de descuentos.

Codecov Report

:exclamation: No coverage uploaded for pull request base (fix/beta-30@f6e5876). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             fix/beta-30     #948   +/-   ##
==============================================
  Coverage               ?   31.51%
==============================================
  Files                  ?      356
  Lines                  ?    17187
  Branches               ?     1567
==============================================
  Hits                   ?     5416
  Misses                 ?    11127
  Partials               ?      644

Impacted Files
Coverage Δ

.../main/java/com/mercadopago/core/CheckoutStore.java
32.25% <ø> (ø)

.../com/mercadopago/presenters/CheckoutPresenter.java
59.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e5876...497cd63. Read the comment docs.


could not execute template SQL

Description
While using Prest to working with an existing SQL script(under foo folder), it informs issues as below. I tried to double-check in document and somewhere else to clarify, but not sure what's wrong. Hope you can take a look at it and give ideas to solve
URL to run
http://<IP_ADDRESS>:6000/_QUERIES/foo/some_get?field1=bar
Config file:
location = "./queries/"
SQL file:
SELECT * FROM table WHERE name = "{{.field1}}";
Error(using Postman tool to test):
{
    "error": "could not parse script foo/some_get, could not execute template template: queries\\foo\\some_get.read.sql: \"queries\\\\foo\\\\some_get.read.sql\" is an incomplete or empty template"
}

Windows7 Structure folder:
--prest
--------queries
----------------foo

pREST version (or commit ref): 0.3.4
PostgreSQL version: 11.1
Operating system: Windows 7 , Windows 8.1
API testing tool: Postman

Remove ; in the end and it works

Feel free to reopen if it don’t work

I have the same problem. Some solution?

Same problem here under W10, with or without trailing semicolon ... :-(

@felipeweb please consider reopening this issue!

Do you want to send a PR? @palevi67 or @vmaravind96


Added gameidea.org under 'General' category

The website is not specific to a particular sub-domain and is more general in nature; but more focused on shaders and general mechanics such as inventory, movement, and so on.
Does the website qualify to be in this awesome-repository?

Apologies, this website does not meet the quality standard of other resources. In general, this list aims to be light on tutorials, instead focusing on offering broader subject knowledge.
Appreciate your work though - perhaps it would be better suited for one of the other awesome lists in the gaming category?


Could not get master / access token [!]

Describe the bug

If i fill in my account details and press on "send" then i get the error:
"Username/Password is incorrect. If your Google Account has 2FA enabled, generate an app password (https://myaccount.google.com/apppasswords). If authentication still fails, please refer to https://github.com/leikoilja/ha-google-home#troubleshooting"
I tried logging in with both my application password an my real password. They both didn't work. I have 2fa enabled but when I used my real credentials, it took way longer for the error to show up (THE FIRST TIME!).
Version of the integration
If you are unsure about the version check the github release here.

v1.11.1

Logs

Logger: glocaltokens.client
Source: custom_components/google_home/api.py:75
integration: google_home (documentation, issues)
First occurred: 14:26:33 (5 events)
Last logged: 14:31:08

[!] Could not get master token.

Logger: custom_components.google_home
Source: custom_components/google_home/config_flow.py:132
integration: google_home (documentation, issues)
First occurred: 14:26:33 (5 events)
Last logged: 14:31:08

I have tried it via a docker container on a Ubuntu VM but it still fails!

I have this problem, too, and when running through the troubleshooting steps I was playing with that get_tokens.py script from the other person and in the def _get_android_id() I found what might be the problem.
That function checks if the lowest bit of the high byte is set or not, and if set it throws and error and cannot continue.
Change the first line of that function to
mac_int = getmac() ; print(">MAC: {0:012x}/{0:048b} {1:08b}".format(mac_int, (mac_int>>40)))

And you can see if that might be happening to you, too.
@DurgNomis-drol  @leikoilja
Does glocaltokens make a similar check for a set bit in the pseudo-MAC obtained?

2024-08-01 13:02:56.070 ERROR (MainThread) [custom_components.google_home]
2024-08-01 13:03:39.652 WARNING (SyncWorker_2) [custom_components.sinope] Error code: 7ffc (None or invalid value for dfc60000), Data:(550015004102269322520a0100dfc60000070802000002fc7f19)
2024-08-01 13:03:44.809 WARNING (Recorder) [homeassistant.components.recorder.db_schema] State attributes for sensor.sm_p610_active_notification_count exceed maximum size of 16384 bytes. This can cause database performance issues; Attributes will not be stored
2024-08-01 13:03:55.862 DEBUG (MainThread) [glocaltokens.client] Initializing new GLocalAuthenticationTokens instance.
2024-08-01 13:03:55.862 DEBUG (MainThread) [glocaltokens.client] Set GLocalAuthenticationTokens client access_token, homegraph, access_token_date and homegraph_date to None
2024-08-01 13:03:55.862 DEBUG (MainThread) [glocaltokens.client] Set GLocalAuthenticationTokens client username to "c<redacted>", password to "<redacted>", master_token to "None" and android_id to None
2024-08-01 13:03:55.863 DEBUG (SyncWorker_31) [glocaltokens.client] There is no stored master_token, logging in using username and password
2024-08-01 13:03:55.863 DEBUG (SyncWorker_31) [glocaltokens.client] There is no stored android_id, generating a new one
2024-08-01 13:03:55.863 DEBUG (SyncWorker_31) [glocaltokens.client] Generating android id...
2024-08-01 13:03:55.863 DEBUG (SyncWorker_31) [glocaltokens.client] Generated android id: b45323626d4e9787
2024-08-01 13:03:56.071 ERROR (SyncWorker_31) [glocaltokens.client] [!] Could not get master token.
2024-08-01 13:03:56.071 DEBUG (SyncWorker_31) [glocaltokens.client] Request response: {'Error': 'BadAuthentication'}
2024-08-01 13:03:56.072 ERROR (MainThread) [custom_components.google_home]

Removed the check for that bit, still couldn't get the master token.

there were numerous BadAuthentication issues previously reported see this and so far there is no consistent answer to what is causing it. Most likely it happens on google side when and how they are rejecting authentication.
What I suggest you do is get a master token instead and then use it for the integration. See this section for details on how to get the master token. Let us know if that resolves your issue

@leikoilja That's how I was trying to get the master token. I tried all those ways.

@mrussak, you dont need RPi to run docker image for getting master token. run it on your regular machine, get the master token (it's not changing unless you change your acc password). and then use the master token when setting up ha-google-home integration in HA

I have similar issue and I am not able to get it working. I get the floowing error with the docker:
[*] Getting master token...
{'Error': 'BadAuthentication'}
[!] Could not get master token.
[*] Master token: None

[*] Getting access token...
{'Error': 'BadAuthentication'}
[!] Could not get access token.
[*] Access token: None

Tried also with manual install with the same result.

[!] Could not get master token.
[*] Master token: None

[*] Getting access token...
[!] Could not get access token.
[*] Access token: None

[*] Done.

[!] Could not get master token.
[*] Master token: None

[*] Getting access token...
[!] Could not get access token.
[*] Access token: None

[*] Done.

Hello ! I use another solution than HA (Jeedom) but which uses same API to get master and access tokens to track the alarms and timers of my google homes.
I get exactly the same behavior as detailed by @mrussak :
root@debianTonio:/var/www/html/plugins/ghlocal/resources# python3 /var/www/html/plugins/ghlocal/core/class/../../resources/get_tokens_verbose.py<EMAIL_ADDRESS>xxxxxxxxxxxxxx True DEBUG:glocaltokens.client:Initializing new GLocalAuthenticationTokens instance. DEBUG:glocaltokens.client:Set GLocalAuthenticationTokens client access_token, homegraph, access_token_date and homegraph_date to None DEBUG:glocaltokens.client:Set GLocalAuthenticationTokens client username to "a<redacted>", password to "<redacted>", master_token to "None" and android_id to None DEBUG:glocaltokens.client:There is no stored master_token, logging in using username and password DEBUG:glocaltokens.client:There is no stored android_id, generating a new one DEBUG:glocaltokens.client:Generating android id... DEBUG:glocaltokens.client:Generated android id: d3e233381e693276 ERROR:glocaltokens.client:[!] Could not get master token. DEBUG:glocaltokens.client:Request response: {'Error': 'NeedsBrowser', 'Url': 'https://accounts.google.com/signin/continue?sarp=1&scc=1&continue=https://accounts.google.com/o/android/auth?hl%3Den_us%26xoauth_display_name%3DAndroid%2BLogin%2BService%26source%3DAndroid%2BLogin&plt=AKgnsbu2LrQj_nFyBTUd8kjYvE55a2jPxqTSXdCi82HAU1-uhuaC_Aq04mX9j8NUBOVsD39HsHHbJ78hU7sclkEJBqYGhZ1EB4ZM0NA52Lj5nHka_r6ohFpl2Cf80p4FyokZRQ6SEt7B', 'ErrorDetail': 'To access your account, you must sign in on the web. Touch Next to start browser sign-in.'} None
I have reported an issue on the glocaltokens repo
I was wondering if it could come from incompatibility of versions of python modules...
Anyways, please let me know if you have resolved this issue or if at least you have progressed in its investigation.
Thank you

have the same issue

Good to hear that I'm not the only one... I was feeling lonely !
In fact, I've installed Home Assistant to test google-home HACS repo.
in the doc it is said:
Master token Due to authentication issues with google credentials alone it may be required to get the master token separately and provide it during the setup process. This can be done using this script
But it definitely doesn't work when only email and app password is set...
If it is still working for someone, please tell us how... It's maybe due to recent google home api...
Thanks

But it definitely doesn't work when only email and app password is set...
If it is still working for someone, please tell us how... It's maybe due to recent google home api... Thanks

@TonioBDS ,
I set this up last week, and ran into the same issues it sounds like you are. The email and app password alone would not work. I then ran the script to get a "master token" and that worked, I got the master token from the script, and it was the correct character count, but it still would not work.
I then restarted the whole system I have HA running on in Proxmox, and then it took the master token on the first try. This integration has been running fine since then.
I would suggest trying to restart whatever you have HA running on, and not just restarting HA from inside the HA menus, and see if that helps.

Thanks a lot for your feedback @afs5327, I run HA OS on a VM in my synology NAS.
I'll try the following in that order then:

restart the VM and retry (meaning with only email and app password)
try to run the script to get a master token and give it another try with the master token field filled

But I have question about that: I understood that the master token was changing periodically.
Do you confirm that or is it only linked to the app password such that it will remain OK as long as the app password does?
Or, did you find a way to automatize the master token regeneration?
Thanks again !

No problem, @TonioBDS, let me know if that sorts it out for you!
I have not had to change the master token yet, so if it does change, it lasts for more than a week.
Make sure the MT you get is exactly 233 characters.
I'm mostly a Windows guy, and this thread helped me make it from Windows.

Hello,
For info, a full reboot did not work.
To get my master token I choose the solution to install a docker on my Synology NAS through the Container app based on image https://github.com/Brephlas/dockerfile_breph-ha-google-home_get-token.
Very simple to use : I just opened a terminal and entered the command python3 get_tokens.py and voilà !
However, for info my master token from aas_et/ to = is only 223 characters long, not 233 as mentionned above and on other forums.
Anyways it works in HA : all my devices are now detected.
I don't know how long it will last but thank you very much to all of you, you gave me the courage to try harder. It's been 15 days I was struggling with that f*** master token !

I had to put masterpwd on 1 single line.
I also have 223 characters.
But it worked

So I had a catastrophic crash which meant I had to rebuild my Debian server that boots from a ZFS pool that runs Docker on which I had Home Assistant. On a whim I decided to delete the old app password, something I had done 7 times previously trying to get this integration to work. Yes, I add numbers to the names of the app passwords when I re-make them to keep track of things like that.
And this time using the docker image method I was able to get a master token.
Don't ask me why, I'd done all these steps multiple times before, deleting and creating a new app password each time and all that.
Maybe I sacrificed enough chickens while rebuilding the server.

So I had a catastrophic crash which meant I had to rebuild my Debian server that boots from a ZFS pool that runs Docker on which I had Home Assistant. On a whim I decided to delete the old app password, something I had done 7 times previously trying to get this integration to work. Yes, I add numbers to the names of the app passwords when I re-make them to keep track of things like that.
And this time using the docker image method I was able to get a master token.
Don't ask me why, I'd done all these steps multiple times before, deleting and creating a new app password each time and all that.
Maybe I sacrificed enough chickens while rebuilding the server.

thanks for reporting back, @CoryAlbrecht. and happy to hear it went smoother for you this time around

Hello,
For info, a full reboot did not work. To get my master token I choose the solution to install a docker on my Synology NAS through the Container app based on image https://github.com/Brephlas/dockerfile_breph-ha-google-home_get-token. Very simple to use : I just opened a terminal and entered the command python3 get_tokens.py and voilà !
However, for info my master token from aas_et/ to = is only 223 characters long, not 233 as mentionned above and on other forums. Anyways it works in HA : all my devices are now detected. I don't know how long it will last but thank you very much to all of you, you gave me the courage to try harder. It's been 15 days I was struggling with that f*** master token !

I have managed to get the master password using this solution as well.
Unraid Terminal:
docker run -it --name ha-google-get-token breph/ha-google-home_get-token /bin/bash
python3 get_tokens.py

So yea, this works.  (I had to enable the terminal first, easy button click in the upcoming window)
Copy paste docker run -it --name ha-google-get-token breph/ha-google-home_get-token /bin/bash and hit enter and let it do its thing (download and stuff)
type python3 get_tokens.py
Enter your google mail with @gmail.com
create a App Password (my default password did not work) at https://myaccount.google.com/apppasswords. Name does not matter
Copy the password to an editor, remove the spaces, copy it into the docker command line where it asks for the password
Copy the generated master token in an editor again, remove the "new line" so the token is in one line.
Now you have a working master token. Use it in the google home config together with your username (again with @gmail.com... why they call it username in the first place?)

(again with @gmail.com... why they call it username in the first place?)

My guess is because some countries use "GoogleMail.com" instead of "GMail.com". Also, if you're using a GSuite account, you'll need the domain portion. As for why they don't just say "EMail address" then, that I don't know, lol
Glad it's working for you! Sorry to hear you wrestled with it for so long. I worry dread when Google makes changes that break even this workaround. For Music Assistant to work with YouTube Music, the work around is pulling a cookie from the browser, heh

4. docker run -it --name ha-google-get-token breph/ha-google-home_get-token /bin/bash

got the master token, but gives me a master token is invalid error still.  Not sure what i'm doing wrong!

docker run -it --name ha-google-get-token breph/ha-google-home_get-token /bin/bash

got the master token, but gives me a master token is invalid error still. Not sure what i'm doing wrong!

N\m... tried a different app password and it worked this time!

So yea, this works.  (I had to enable the terminal first, easy button click in the upcoming window)
Copy paste docker run -it --name ha-google-get-token breph/ha-google-home_get-token /bin/bash and hit enter and let it do its thing (download and stuff)
type python3 get_tokens.py
Enter your google mail with @gmail.com
create a App Password (my default password did not work) at https://myaccount.google.com/apppasswords. Name does not matter
Copy the password to an editor, remove the spaces, copy it into the docker command line where it asks for the password
Copy the generated master token in an editor again, remove the "new line" so the token is in one line.
Now you have a working master token. Use it in the google home config together with your username (again with @gmail.com... why they call it username in the first place?)

thank you whoever you are. it worked after months !


Building new provider for Fabric Answers and Firebase

Hey Dal,
I'm pretty new to all those podspec and static libraries stuff, so I got bumped by the fact that I can't include Fabric module in my (your =) ) pod, even if the mentioned framework exists in the project. So I asked on SO, maybe you can help, too.
http://stackoverflow.com/questions/42472928/cannot-import-module-from-another-pod
I understood, you have the same issue with GA.
Thanks.

Bump )

Sorry, didn't see this until now! Will have a look!

Both Answers and Firebase are implemented as of 0.5.0.


feature: allow wrapping for the lazy window

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
with smaller screens / higher font size the lazy window often looks like this, making the hard to read due to the formatting

Describe the solution you'd like
being able to set nowrap for the lazy window. Scrolling a bit to the side to read the commits you are interested in really would not be a big deal.
This could potentially also make sense as a configuration option for lazy, or even as a default, but also does not need to be. Being able to set nowrap at all would already make this far more readable
Describe alternatives you've considered

I set set nowrap in the lazy window, but it barely changed anything, potentially cause lazy already does add some line breaks?
I already increased the width of the lazy window to the 100%
well, decreasing font size, which does not really work well (bad eyes etc.)

Additional context
No response

It's not possible as of now since the text actually contains whitespace... However I would also really like to be able to set nowrap even though I know @folke has said that he does not plan to change this behaviour...

related:

[ ] https://github.com/folke/lazy.nvim/issues/223
[ ] https://github.com/folke/lazy.nvim/issues/174

I'll make it configurable

I made some impeovements to the default wrapping behavior and made it configurable with config.ui.wrap


feat: hookup sending patient referral form via SMS

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

51 of 57 (89.47%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 82.278%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/clinical/infrastructure/services/advantage/service.go
25
31
80.65%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
7591

Relevant Lines:
9226

💛  - Coveralls


SA1108: BlockStatementsMustNotContainEmbeddedComments

http://www.stylecop.com/docs/SA1108.html

grabbed

Ok, one thing to discuss. Originally, this diagnostic is not reported for declarations (method, class, namespace etc). So this code is valid (tested on stylecop <IP_ADDRESS>):
   public class IndexTests
//aa
{
    public int Prop
    //aa
    {
        get
        //bb
        {
            return 0;
        }

        set
        //cc
        {

        }
    }
  }

I think we need to decide whether we are going to follow StyleCop understanding of this diagnostic or we are going to extend it, so declarations are also included.

For this I suggest implementing it the way it's written, and following the pattern of #536 for the extension.