Remove userPhoto.aspx reference in Akamai CDN as it is available out of the box now with AFD CDN as Akamai CDN user photo retires

Remove userPhoto.aspx reference in Akamai CDN as it is available out of the box now with AFD CDN as Akamai CDN user photo retires

Docs Build status updates of commit d790363:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/enterprise/use-microsoft-365-cdn-with-spo.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 16cf97d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/enterprise/use-microsoft-365-cdn-with-spo.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 16cf97d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/enterprise/use-microsoft-365-cdn-with-spo.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9b4b940:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/enterprise/use-microsoft-365-cdn-with-spo.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9509f52:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/enterprise/use-microsoft-365-cdn-with-spo.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Cant set MYSQL_ROOT_HOST

Hi,
Im trying to set MYSQL_ROOT_HOST but whatever I do it is always set to <IP_ADDRESS> and I thing its probably related to
https://github.com/colinmollenhour/mariadb-galera-swarm/blob/8a1627360820a1b33cdbae9072a44234b5a49d7d/start.sh#L219
Shouldnt it be if ! [ -z "$MYSQL_ROOT_HOST" ]; then ?
So only if MYSQL_ROOT_HOST is empty it will be <IP_ADDRESS>

The -z test is true if the string is zero length so I think that line is correct. Are you sure the environment variable is passing through properly?

@TheGreatDoc
Use it like this:
version: '3.4'

services:
  seed:
    image: colinmollenhour/mariadb-galera-swarm:10.4.11-2020-01-06
    environment:
[...]
      - MYSQL_ROOT_HOST=%
      - DEFAULT_TIME_ZONE=Europe/Budapest
      - NODE_ADDRESS=^10.0.*.*
    networks:
      - db_network
    command: seed
    volumes:
      - mysql-data:/var/lib/mysql


Enya/cov ignore registry

Description

Add 'registry_utils' as one of files should be ignored in test coverage report since it's only used by '_feature_registry_purview' which is deprecated.

How was this PR tested?

Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Make sure to clarify your proposed changes.

Need to solve conflicts with main first


Convert docoutline to TypeScript

Summary
This PR implements the following

[x] Convert docoutline.js module to TypeScript
[x] Convert nav_store.js module to TypeScript
[x] Convert onMount in OutlineHeader to an async function
[x] Re-organize imports in routes

Test plan (required)
The documentation outlines should render as they did before.

An aside ( not important to this change ) - some of the changes here are basically formatting preferences - we should probably have eslint / prettier / whatever tooling set up and configured with an opinated version of what "our style" is, and let this tooling enforce this style.

Totally agree. We should make coding style clear to set expectations. 💯
The project has eslint set up to enforce some style guidelines, such as no semicolons and single quotes. But it would be great to add import ordering and other style guidelines to that.


Diff behaviour not as expected - preact unmounting then remounting the same DOM nodes even when there is a key

I have found that preact is unecessarily tearing down and rebuilding DOM nodes even when a key is used (example codepen)
In this case even though the key is supplied almost all of the DOM nodes are being removed and then added again even though only three are changed
EDIT
TO be clear it is expected that the components are being rerendered, but the issue is that all of the DOM nodes (not virtual dom) are being removed and then re-added again
(before changing the document):

(after changing the document):

After debugging I eventually found that each time the new document was selected the span elements (in the real DOM) inside the content were being removed and then added again, and the weird thing is that the spans that are being removed are exactly the same as the spans that are being added (as in they were the same instance)
Expected Behaviour
Only a few DOM nodes will be changed (as keys are supplied and most of the vdom remains the same)
Actual Behaviour
All of the DOM nodes are being removed and then re-added again

Just as a side note so you dont get confused I am providing the key attribute as well as the data-key attribute for debugging

It’s because you are intentionally switching
component(oldDocument<->newDocument). A component change will definitely
tear down the old one and setup the new one.
On Sat, Mar 31, 2018 at 06:45 PandaSandStudio<EMAIL_ADDRESS>wrote:

Just as a side note so you dont get confused I am providing the key
attribute as well as the data-key attribute for debugging
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact/issues/1052#issuecomment-377684097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK3Wt70H7Ql086-EOZUXxGpdPWUgD906ks5tj14zgaJpZM4TCa4G
.

I'm sorry if I misunderstand, but I'm not switching out the component I'm switching out the property. The issue isn't that the Document component is being re-rendered it is that all of the DOM nodes in the document (not the vdom) are being removed and then re-added again even though I am providing a key and the vdom is barely changing.

For clarity I edited the original question

Yes I see your point. My previous comment is wrong. Will investigate this
later
On Sat, Mar 31, 2018 at 20:10 PandaSandStudio<EMAIL_ADDRESS>wrote:

For clarity I edited the original question
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact/issues/1052#issuecomment-377732646,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK3Wt8jONuT35_F9nG7_L68cNG6Zch4wks5tkBrigaJpZM4TCa4G
.

NOTE I have created a new pen and changed the text of the elements to help with debugging
I have found that when preact is diffing, if the original html is like this:
111
2.0
2.1
2.2
333
444
555
666
777
888

and the new HTML is this:
111
<IP_ADDRESS>
333
444
555
666
777
888

Then preact will carry out the following operations (in the order provided)

Which I believe means that for some reason preact moves the spans which are after
2.2

(aka the ones with text 333,444,555,etc.) to before
2.1

and then deletes
2.1

and
2.2

and then sets the text of
2.0

to <IP_ADDRESS>
Which seems very unecessary (note that this doesnt happen in react - react just removes 2.1 and 2.2 and sets the text of 2.0 to <IP_ADDRESS>)
Here is the codepen for reference (when you switch from First to Second by clicking you should see the operations printed to the console)

This is indeed a bug. Preact cannot correctly handle removing multiple children from non-end position. If you remove just one child from any position, or multiple children from the end of the list, they both work fine.
I think there is already one ticket tracking this and I have not found it yet

IIRC that but only affects unkeyed children.

@developit  I think this is different from the unkeyed children bug.
This one is because this line:
https://github.com/developit/preact/blob/master/src/vdom/diff.js#L227
So if there are multiple children to be removed, nextSibling would not work and the above line would not be truthy. So instead of just removing these children, we first insert their following children before them, then remove them at the end.
The unkeyed children bug is plucking the same node type existing children results in unnecessary diffing work.
Right?

@yaodingyd you're right, I was conflating the two.  I wonder if we can check against the keyed child map within that conditional...

@developit I'm thinking if we could have another map of keyed vnodes and when originalchild has a key, check against this map. If returns undefined then remove f

Has there been any movement on this? I'm encountering the same bug (originally referenced in #1069). Is there anything blocking? I'm not super familiar with internal workings of Preact, but if there's something I can do to help in my spare time I'd be glad to! :slightly_smiling_face:

That's great news! Is there a timeline for that release?

I'm experiencing the same problem. I have a CSS entry animation on my child nodes and reordering them triggers the animation again :(

Good news: Just tried the snippet in the original post with the code in master and I can't reproduce the issue anymore :tada: :+1:


Binding nullable int to input causes null reference exception

Minimal repro steps
Consider this Blazor page:
<input @bind(TestInt) />

@functions
{
    public int? TestInt { get; set; }

}

Expected result
Page should render without exceptions
Actual result
A nullref exception is thrown:
SCRIPT5022: System.NullReferenceException: Object reference not set to an instance of an object.
  at Microsoft.AspNetCore.Blazor.RenderTree.RenderTreeBuilder.AddAttribute (System.Int32 sequence, System.String name, System.Object value) <0x169c870 + 0x0005c> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Datack.Blazor.Pages.Data.Index.BuildRenderTree (Microsoft.AspNetCore.Blazor.RenderTree.RenderTreeBuilder builder) <0x1977930 + 0x000dc> in <cd4fad1f0c094e678f0f1612015bbf56>:0
  at (wrapper delegate-invoke) <Module>.invoke_void_RenderTreeBuilder(Microsoft.AspNetCore.Blazor.RenderTree.RenderTreeBuilder)
  at Microsoft.AspNetCore.Blazor.Rendering.ComponentState.RenderIntoBatch (Microsoft.AspNetCore.Blazor.Rendering.RenderBatchBuilder batchBuilder, Microsoft.AspNetCore.Blazor.RenderFragment renderFragment) <0x16964f8 + 0x0006c> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Rendering.Renderer.RenderInExistingBatch (Microsoft.AspNetCore.Blazor.Rendering.RenderQueueEntry renderQueueEntry) <0x16960a0 + 0x00040> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Rendering.Renderer.ProcessRenderQueue () <0x16931b8 + 0x00048> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Rendering.Renderer.AddToRenderQueue (System.Int32 componentId, Microsoft.AspNetCore.Blazor.RenderFragment renderFragment) <0x16923d0 + 0x00068> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Components.RenderHandle.Render (Microsoft.AspNetCore.Blazor.RenderFragment renderFragment) <0x16920b8 + 0x00036> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Routing.Router.Refresh () <0x17672a0 + 0x00130> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at Microsoft.AspNetCore.Blazor.Routing.Router.OnLocationChanged (System.Object sender, System.String newAbsoluteUri) <0x1974c90 + 0x0002c> in <6f55c2fa30114054ab77a67cb3b359ec>:0
  at (wrapper delegate-invoke) System.EventHandler`1[System.String].invoke_void_object_TEventArgs(object,string)
  at (wrapper delegate-invoke) System.EventHandler`1[System.String].invoke_void_object_TEventArgs(object,string)
  at Microsoft.AspNetCore.Blazor.Browser.Services.BrowserUriHelper.NotifyLocationChanged (System.String newAbsoluteUri) <0x1974b00 + 0x00026> in <aa678c00565443a1a03daf9fa7da0de1>:0

Further technical details
Build: 0.1
OS: Windows 10 Pro
Browser: Edge
Making the nullable int non-nullable wil fix this.
So this does work as expected:
<input @bind(TestInt) />

@functions
{
    public int TestInt { get; set; }

}

Helpful info!
Currently i'm trying to make working selectable list or it call maybe drop-down list (I'm back-end developer). Anyway, can't make it working with drop-down list if drop-down list items is dynamic get data from server.
This is enum drop-down list working great:

                     <select class="form-control" @bind(_user.UserType)>                         @foreach (var userType in Enum.GetValues(typeof(UserType)))                         {                             <option>@userType</option>                         }                     </select>

This one is struggling:

                     <select class="form-control" @bind(_user.Additional1)>                         @foreach (var company in _companies) // _companies is List<Company> Company object contain Id and name                         {                             <option value=<EMAIL_ADDRESS>                       }                     </select>

Also possible that i'm just doing it wrong (I guess it 90% possibility)

This issue appears for any non string binding that is null, the code that causing this is
https://github.com/aspnet/Blazor/blob/0b3b84f1db4c628bd5c37a16c9c22f236e85d3ad/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs#L138
The exception occurs because calling .ToString() obviously NRE's on null, so the fix could be as easy as adding ?.
For string, null works as there's a different overload.

The interesting part is that AttributeValue declared object which makes ToString seem redundant https://github.com/aspnet/Blazor/blob/0b3b84f1db4c628bd5c37a16c9c22f236e85d3ad/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeFrame.cs#L90
but JS assumes it to be always string https://github.com/aspnet/Blazor/blob/0b3b84f1db4c628bd5c37a16c9c22f236e85d3ad/src/Microsoft.AspNetCore.Blazor.Browser.JS/src/Rendering/RenderTreeFrame.ts#L21
This odd design appears to be for https://github.com/aspnet/Blazor/blob/0b3b84f1db4c628bd5c37a16c9c22f236e85d3ad/src/Microsoft.AspNetCore.Blazor/RenderTree/RenderTreeBuilder.cs#L140-L143

Tested this on 0.2 and that throws a decent understandable exception, so closing this.

I feel like this is a hole.  If someone uses entity framework to bind to a database, it will force them to create new entities taking care of nulls.  Would love to see some configuration that allows treating nulls as "" for strings and nulls as 0 for ints. I don't want to get into a philosophical discussion on why they aren't equal.  In my mind I realize that but the application has to deal with it somehow, and I would prefer to handle it globally not field by field.
If I have a nullable string in a database and I want to bind using blazor I don't like having to do some type of extension method to solve this over and over.
public static string NoNull(this string value)
{
string rc = "";
if (value != null)
{
rc = value;
}
return rc;
}

"I don't want to get into a philosophical discussion"
I think that's unavoidable when dealing with nulls, especially true of numbers in a financial system- zero returns is very different to no returns.
That said, I agree completely that the ability to bind to nullable fields would be helpful but I'd want my nulls preserved on any round trip, not turned into empty strings/zeros.
Something along the lines of  TargetNullValue or IValueConverter would be very helpful, especially as a lot of people will be coming to this from a WPF/SL background.


Release 1.1.12 of backstage-plugin-github-insights is an empty package

When trying to update plugins in my backstage instance this afternoon, I discovered broken imports after updating this plugin to 1.1.12.  1.1.11 still works properly.  According to the NPM package registry, the previous version of the plugin was about 200KB, and the new version is just over 17KB.  I think the package for the 1.1.12 version is broken or missing some pieces.

That is definitely strange, thank you for reporting, we will check this @jmgrimes

That is definitely strange, thank you for reporting and letting us know about the issue. We will check what could have happened @jmgrimes

@jmgrimes version 1.1.14 is out and this shouldn't be an issue anymore. There were some problems with the published 1.1.12 version, so thank you once again for reporting this :)


Fix Gatekeeper namespace creation detection

There's a newline or some whitespace in there that the equality wasn't catching
Followup to:

https://github.com/stolostron/governance-policy-framework/pull/445

/cherry-pick release-2.6
/cherry-pick release-2.5
/cherry-pick release-2.4

/cherry-pick release-2.5

/cherry-pick release-2.4

The CI is passing, and this PR is ready for review.


ceph-nfs: use mkdir instead of /usr/bin/mkdir

On Ubuntu mkdir lives in /bin and not in /usr/bin

Closed in favor of #3675 (because of inactivity)

@guits Thank you for the takeover and solution. At the moment I am not able to work through any open points.


Exception stops users from changing date range when dashboard contains datatable

When changing the date range js throws an exception. PR to follow
Uncaught TypeError: Cannot read property 'isDataTable' of undefined

PR #15

Confirmed fixed and merged. Thanks!

No Problem!


Decide on a template or design

@fvcproductions Let's add links to templates or designs here, just in case others want to weight in

For Hugo, all themes are listed out here: https://themes.gohugo.io/
These stuck out to me:

https://themes.gohugo.io/hugo-split-theme/
https://themes.gohugo.io/hugo-icon/

We haven't an update on this for a while so my plan moving forward will be to just take the existing design that we have and try and apply that as best as possible to the beta website.
Hope that works!


Selected page should be remembered during pagination

When paginating through videos and you watch a video your place in the paginated video list should be remembered.

Closed via eb9264317bd9a04cfe3a8556e6c15223e10ffe69


Task crashing for cron with "@reboot"

When Cron is trigged on reboot, the task runs properly and exits. But after sometime this error shows up in log and executes the task again
[error] Task #PID<0.6628.0> started from Quantum terminating
** (MatchError) no match of right hand side value: ["@reboot"]
    (quantum) lib/quantum/executor.ex:31: Quantum.Executor.execute/2
    (elixir) lib/task/supervised.ex:74: Task.Supervised.do_apply/2
    (elixir) lib/task/supervised.ex:50: Task.Supervised.reply/3
    (stdlib) proc_lib.erl:239: :proc_lib.init_p_do_apply/3
Function: &Quantum.Executor.execute/2

Using this on Elixir 1.1.1, Phoenix 1.0.4

@wicliff Thanks for reporting!
I have fixed this in #58.
An updated version of Quantum will be released shortly after it is merged.

:+1:
That is quick work! Appreciate the library, nicely done.

Good catch @wicliff and speedy fix @c-rack!

Updated version 1.6.1 including the bugfix has been published to hex.pm:
https://hex.pm/packages/quantum


feat: Add support for hwb

Summary

Changelog

[CATEGORY] [TYPE] - Message
Test Plan

/rebase

Tracked on https://github.com/facebook/react-native/commit/ac1fe3b7eb8e16f5feddeeac846ff70080dc119e


[es-dev-server]: node resolution with yarn workspaces goes out of the root directory

I'm trying to create a mono repo using yarn workspaces, with an example directory where I want to run es-dev-server.

root
  |
  |__ example
  |          |_ node_modules (empty as everything has been hoisted)
  |          |_ Trying to run es-dev-server here
  |
  |___ node_modules
             |_ This is the actual place where `import "anything"` resolves to

When I try to run es-dev-server it gives the error
Error compiling: Import "tslib" resolved to the file "/home/viks/root/node_modules/tslib/tslib.es6.js" which is outside the web server root, and cannot be served by es-dev-server. Install the module locally in the current project, or expand the root directory. If this is a symlink or if you used npm link, you can run es-dev-server with the --preserve-symlinks option
I'm using yarn and don't want to fallback to using npm with npm link. Changing the rootDir is also cumbersome since too many paths have to be adjusted in a non-trivial manner.
Can we get an option to specify a separate workspaceRoot that default to rootDir but can be above rootDir if needed?

I've thought about this a lot, but I'm not sure what the correct solution is.
Remember that when serving an unbundled application, all files are requested individually and thus need to be accessible.
For example if you serve a monorepo, with a root-dir packages/package-a and import something from packages/package-a/node_modules/foo/foo.js the browser request is node_modules/foo/foo.js.
If you import something from node_modules/tslib/tslib.js what should the browser request URL be? It can't be node_modules/tslib/tslib.js because it would look for packages/package-a/node_modules/tslib/tslib.js.
We need some way to let es-dev-server know it's a special type of request, for example:

/__es-dev-server-monorepo/root/node_modules/tslib/tslib.js
/node_modules/tslib/tslib.js?es-dev-server-monorepo=root
/node_modules/tslib/tslib.js?es-dev-server-root-dir=/Users/MyUsername/Workspace/my-project/

But we would need to be careful around handling edge cases, and make it understandable for developers.
My main concern is that none if this would work with a regular web server, and es-dev-server tries to emulate that experience with just some helpers to improve DX. The node resolve logic will eventually be replaced by https://github.com/WICG/import-maps which won't be able to support this either.

Another possible solution is to allow specifying several directories es-dev-server can serve files from. When requesting a file, it will go through the directories in order until it finds a file. Browserify does something similar (https://browsersync.io/docs/options#option-serveStatic) (@ruphin suggested this before)

Using lerna for monorepo package management also presents this issue.

@daneah yes and no... if you set the root directory to the root if your repository there is no issue. You need to be able to serve the files you want to use.

@daneah yes and no... if you set the root directory to the root if your repository there is no issue. You need to be able to serve the files you want to use.

Roger that, we were ultimately able to get things working by doing this 👍🏼

We had some discussions in the team about the multiple directories, but not everyone was quite convinced :)

As reference and continuing with @daneah conversation what we are doing with lerna is to link two local packages. In the local package B we install a local package like:
 "dependencies": {
    "my-local-package": "latest"
  },

And we try to import that local package:
import 'my-local-package/dist/button/my-button.js';

That my-local-package is a symlink to the lerna local package and is inside node_modules. With that configuration es-dev-server can't resolve the path but if we change the symlink copying the entire package it works. I assume that that's because the symlink works but the resolution of that symlink is not accesible.

es-dev-server has an option to configure how you want symlinks to behave.
It can preserve them so that you can resolve symlinks. This can cause duplicate loading if you symlinks the same file from multiple locations.
It can also follow symlinks, but then it does need to have access to the files it needs to serve from the symlinks.
In the end es-dev-server is a static file server, and it has to obey the law of the browser and file system paths. If anyone has an idea of how to improve this developer experience I'm open to hear it.

Well, thanks for the info @LarsDenBakker with the option --preserve-symlinks and managing local dependencies with lerna it worked like a charm 😂

Perhaps we need to make this more explicit in the docs.

same issue
I just run es-dev-server from root and address package in browser and its work fine for me
dont need to use lerna at all and I think yarn 1 workspace ir fine, if you need lerna for this case its better to witch to yarn2

This has been implemented in it's successor @web/dev-server


weak tls config on demo1

tls 1.0 etc

https://www.ssllabs.com/ssltest/analyze.html?d=demo1.sram.surf.nl

More fixes in https://github.com/SURFscz/SRAM-deploy/commit/779891445bf086882cd51530678c92939c74f3e6

tested:
 Testing protocols via sockets except NPN+ALPN

 SSLv2      not offered (OK)
 SSLv3      not offered (OK)
 TLS 1      not offered
 TLS 1.1    not offered
 TLS 1.2    not offered
 TLS 1.3    offered (OK): final
 NPN/SPDY   not offered
 ALPN/HTTP2 http/1.1 (offered)

 Testing cipher categories

 NULL ciphers (no encryption)                  not offered (OK)
 Anonymous NULL Ciphers (no authentication)    not offered (OK)
 Export ciphers (w/o ADH+NULL)                 not offered (OK)
 LOW: 64 Bit + DES, RC[2,4] (w/o export)       not offered (OK)
 Triple DES Ciphers / IDEA                     not offered
 Obsolete CBC ciphers (AES, ARIA etc.)         not offered
 Strong encryption (AEAD ciphers)              offered (OK)


Activating FakeFS in view tests leads to Missing Template errors in RSpec.

When I activate FakeFS in a before block in a view test, the test starts failing with an such as the following:
ActionView::MissingTemplate: Missing template  with {:locale=>[:en], :formats=>[:html, :text, :js, :css, :ics, :csv, :png, :jpeg, :gif, :bmp, :tiff, :mpeg, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip, :xls], :handlers=>[:erb, :builder, :haml]}. Searched in:

"/Users/xxx/code/xxx/app/views"

The error disappears if I do not activate FakeFS.

This is still a issue with the gem.


Inconsistency between Ansible documentation and Schemas?

Summary
The Ansible documentation says that it is possible to make imports conditional, but the schema disagrees.

You can apply conditions to import_playbook as well as to the other import_* statements.

Which one is correct?
Issue Type

Bug Report

Ansible and Ansible Lint details
$ ansible --version
ansible [core 2.12.5]
  config file = /workspaces/ansible/ansible.cfg
  configured module search path = ['/home/vscode/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vscode/.local/lib/python3.10/site-packages/ansible
  ansible collection location = /home/vscode/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/vscode/.local/bin/ansible
  python version = 3.10.2 (main, Feb  8 2022, 04:44:29) [GCC 10.2.1 20210110]
  jinja version = 3.1.2
  libyaml = True

$ ansible-lint --version
ansible-lint 6.2.1 using ansible 2.12.5

STEPS TO REPRODUCE
File content: playbook.yml
---
- hosts: localhost

- import_playbook: import_me.yml
  when: true

File content: import_me.yml
---
- hosts: localhost

Run the lint command and check the output.
$ ansible-lint
INFO     Set ANSIBLE_LIBRARY=/home/vscode/.cache/ansible-compat/9f86d0/modules:/home/vscode/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
INFO     Set ANSIBLE_COLLECTIONS_PATH=/home/vscode/.cache/ansible-compat/9f86d0/collections:/home/vscode/.ansible/collections:/usr/share/ansible/collections
INFO     Set ANSIBLE_ROLES_PATH=/home/vscode/.cache/ansible-compat/9f86d0/roles:/home/vscode/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles
INFO     Set ANSIBLE_LIBRARY=/home/vscode/.cache/ansible-compat/9f86d0/modules:/home/vscode/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
INFO     Set ANSIBLE_COLLECTIONS_PATH=/home/vscode/.cache/ansible-compat/9f86d0/collections:/home/vscode/.ansible/collections:/usr/share/ansible/collections
INFO     Set ANSIBLE_ROLES_PATH=/home/vscode/.cache/ansible-compat/9f86d0/roles:/home/vscode/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles
INFO     Discovered files to lint using: git ls-files --cached --others --exclude-standard -z
INFO     Excluded removed files using: git ls-files --deleted -z
INFO     Executing syntax check on playbook.yml (0.50s)
WARNING  Listing 1 violation(s) that are fatal
schema: 'when' does not match any of the regexes: '^(ansible\\.builtin\\.)?import_playbook$', 'name', 'vars' (schema[playbook])
playbook.yml:1  Returned errors will not include exact line numbers, but they will mention
the schema name being used as a tag, like ``playbook-schema``,
``tasks-schema``.

This rule is not skippable and stops further processing of the file.

Schema bugs should be reported towards (https://github.com/ansible/schemas) project instead of ansible-lint.

If incorrect schema was picked, you might want to either:

* move the file to standard location, so its file is detected correctly.
* use ``kinds:`` option in linter config to help it pick correct file type.

You can skip specific rules or tags by adding them to your configuration file:
# .config/ansible-lint.yml
warn_list:  # or 'skip_list' to silence them completely
  - experimental  # all rules tagged as experimental

Finished with 0 failure(s), 1 warning(s) on 3 files

Desired Behavior
ansible-lint and Ansible documentation agree on what is allowed
Actual Behavior
ansible-lint fails when making an import conditional.
Other info
N/A

If ansible's documentation is saying it's supported and that it's really working, I'm tempted to say it's missing support for that inside the schema.


discordcoreapi build failure

Host Environment

OS: linux
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install discordcoreapi
Failure logs
-Installing 1/1 discordcoreapi:x64-linux...
Building discordcoreapi[core]:x64-linux...
CMake Warning at ports/discordcoreapi/portfile.cmake:2 (message):
DiscordCoreAPI only supports g++ 11 on linux.
Call Stack (most recent call first):
scripts/ports.cmake:146 (include)
-- Using cached RealTimeChris-DiscordCoreAPI-2bcdb9565030a9184ef7ece382f21b17628ee980.tar.gz.
-- Cleaning sources at /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/silver/Desktop/silver/vcpkg/downloads/RealTimeChris-DiscordCoreAPI-2bcdb9565030a9184ef7ece382f21b17628ee980.tar.gz
-- Using source at /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
My Linux terminal is auto close after this output
-Please attach any additional failure logs mentioned in the console output.
install-x64-linux-dbg-out.log file content
[0/2] /home/silver/Desktop/silver/vcpkg/downloads/tools/cmake-3.22.2-linux/cmake-3.22.2-linux-x86_64/bin/cmake -P /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/x64-linux-dbg/CMakeFiles/VerifyGlobs.cmake
[1/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioEncoder.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioEncoder.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioEncoder.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/AudioEncoder.cpp
[2/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/DllMain.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/DllMain.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/DllMain.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/DllMain.cpp
[3/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/ErlPacker.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/ErlPacker.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/ErlPacker.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/ErlPacker.cpp
[4/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioDecoder.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioDecoder.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/AudioDecoder.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/AudioDecoder.cpp
[5/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/GuildScheduledEventEntities.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/GuildScheduledEventEntities.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/GuildScheduledEventEntities.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/GuildScheduledEventEntities.cpp
[6/35] /usr/bin/c++  -I/home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Include -isystem /home/silver/Desktop/silver/vcpkg/installed/x64-linux/include -fPIC -g -O3 -std=c++20 -MD -MT Library/CMakeFiles/DiscordCoreAPI.dir//Source/CommandController.cpp.o -MF Library/CMakeFiles/DiscordCoreAPI.dir//Source/CommandController.cpp.o.d -o Library/CMakeFiles/DiscordCoreAPI.dir//Source/CommandController.cpp.o -c /home/silver/Desktop/silver/vcpkg/buildtrees/discordcoreapi/src/17628ee980-d9e0e24742.clean/Source/CommandController.cpp

Thanks for posting this issue. Could you please remove the cache and rebuild this port? Please also run command ./bootstrap-vcpkg.sh and git pull to pull latest vcpkg.
-- Using cached RealTimeChris-DiscordCoreAPI-2bcdb9565030a9184ef7ece382f21b17628ee980.tar.gz.

Thanks for posting this issue. Could you please remove the cache and rebuild this port? Please also run command git pull and ./bootstrap-vcpkg.sh to pull latest vcpkg.
-- Using cached RealTimeChris-DiscordCoreAPI-2bcdb9565030a9184ef7ece382f21b17628ee980.tar.gz.

Let me try

@KK-Karan-Kumar Did your issue resolved?

@KK-Karan-Kumar Did your issue resolved?

Nope but it's working fine in other os i think it's my os problem 😑

Since this issue is not related with vcpkg, I am closing this issue for now.

@LilyWangLL ok have a great day ahead for development


Preserve keys order in json files

This is useful when storing backups in git, so that the diff between two
backups is minimal.

Good point, it also makes it easier to navigate through the file by hand.
Thanks for this!


Change repo urls. Add clear timers on unmount. Change bundle size limit.

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix minor typo in "Group keys"

As the description says.

Every table has a group key – a list of columns which for which every row in the table has the same value.

[x] Typos do not require signing the CLA
[x] Rebased/mergeable

thank you, @haxtibal


Retrying previous job - errors on coupled_diags or  acme_diags

directory:  /export/mccoy20/pRen/test_2017-09-14-Chris/
Tried to update process flow and acme_diags. May have messed up stuff.
Here is what I did

conda clean --all
conda install acme_diags -c acme -c conda-forge -c uvcdat
could not do that because it wanted to write to /usr/local , so abandoned that

conda create -n workflow -c acme -c conda-forge -c uvcdat  -c lukasz processflow
(not sure if I did the > conda create -n workflow -c acme -c conda-forge -c uvcdat  -c lukasz processflow
or not ??)

then run the script, it started fine, found the data, started on acme_diags, then showed error of a moment, then cleanly close the opened display (before I wrote the error :) . )
Here is the workflow.error:
Exception in thread monitor_job for coupled_diags:
Traceback (most recent call last):
File "/export/mccoy20/anaconda2/envs/workflow/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/export/mccoy20/anaconda2/envs/workflow/lib/python2.7/threading.py", line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "build/bdist.linux-x86_64/egg/lib/util.py", line 455, in monitor_job
job_id = job.execute(batch='slurm')
File "build/bdist.linux-x86_64/egg/jobs/CoupledDiagnostic.py", line 257, in execute
setup_status = self.setup_input_directory()
File "build/bdist.linux-x86_64/egg/jobs/CoupledDiagnostic.py", line 221, in setup_input_directory
loggig.error(msg)
NameError: global name 'loggig' is not defined
Exception in thread monitor_job for coupled_diags:
Traceback (most recent call last):
File "/export/mccoy20/anaconda2/envs/workflow/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/export/mccoy20/anaconda2/envs/workflow/lib/python2.7/threading.py", line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "build/bdist.linux-x86_64/egg/lib/util.py", line 455, in monitor_job
job_id = job.execute(batch='slurm')
File "build/bdist.linux-x86_64/egg/jobs/CoupledDiagnostic.py", line 257, in execute
setup_status = self.setup_input_directory()
File "build/bdist.linux-x86_64/egg/jobs/CoupledDiagnostic.py", line 221, in setup_input_directory
loggig.error(msg)
NameError: global name 'loggig' is not defined

Here is the email I got
One or more job failed
Execution state as of 27, Sep 2017 09:45
Running under process 179891
Year_set 1: 1980 - 1984
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
amwg -- 0: JobStatus.COMPLETED
acme_diags -- 541: JobStatus.FAILED

Year_set 2: 1985 - 1989
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
amwg -- 0: JobStatus.COMPLETED
acme_diags -- 543: JobStatus.FAILED

Year_set 3: 1990 - 1994
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
amwg -- 0: JobStatus.COMPLETED
acme_diags -- 545: JobStatus.FAILED

Year_set 4: 1995 - 1999
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
amwg -- 0: JobStatus.COMPLETED
acme_diags -- 546: JobStatus.FAILED

Year_set 5: 1980 - 1989
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
timeseries -- 0: JobStatus.COMPLETED
coupled_diags -- 0: JobStatus.VALID
amwg -- 0: JobStatus.COMPLETED
acme_diags -- 544: JobStatus.FAILED

Year_set 6: 1990 - 1999
status: SetStatus.FAILED

ncclimo -- 0: JobStatus.COMPLETED
timeseries -- 0: JobStatus.COMPLETED
coupled_diags -- 0: JobStatus.VALID
amwg -- 547: JobStatus.RUNNING
acme_diags -- 542: JobStatus.FAILED

Initializing year sets
Added 6 year sets to the queue
Initializing file list
Attempting connection to source endpoint
Endpoint is already activated and does not expire before the requested if_expires_in.
Connected
Running check for remote files
Found 1 new remote files, moving data from STREAMS: to STREAMS:
Timeseries already computed, skipping
Timeseries already computed, skipping
Ncclimo job already computed, skipping
Ncclimo job already computed, skipping
Ncclimo job already computed, skipping
Ncclimo job already computed, skipping
Ncclimo job already computed, skipping
Ncclimo job already computed, skipping
acme_diags id: 541 changed state to PENDING
Submitted acme_diags for year_set 1
acme_diags id: 542 changed state to PENDING
Submitted acme_diags for year_set 6
acme_diags id: 543 changed state to PENDING
Submitted acme_diags for year_set 2
acme_diags id: 544 changed state to PENDING
Submitted acme_diags for year_set 5
acme_diags id: 545 changed state to PENDING
Submitted acme_diags for year_set 3
acme_diags id: 546 changed state to PENDING
Submitted acme_diags for year_set 4
amwg id: 547 changed state to JobStatus.SUBMITTED
Submitted amwg for year_set 6
AMWG job already computed, skipping
AMWG job already computed, skipping
AMWG job already computed, skipping
AMWG job already computed, skipping
Setting up local hosting for amwg
AMWG job already computed, skipping
Setting up local hosting for amwg
Setting up local hosting for amwg
Setting up local hosting for amwg
Setting up local hosting for amwg
Job 541 has failed
Job 542 has failed
Job 543 has failed
Job 544 has failed
Job 545 has failed
Job 546 has failed
09:45 Transfer in progress  (1/1) [********************] 100.00%
amwg hosted at https://acme-viewer.llnl.gov/mccoy20/20170731.F20TR_ck10.ne30_ne30.edison/amwg/1995-1999/index.html
amwg hosted at https://acme-viewer.llnl.gov/mccoy20/20170731.F20TR_ck10.ne30_ne30.edison/amwg/1990-1994/index.html
amwg hosted at https://acme-viewer.llnl.gov/mccoy20/20170731.F20TR_ck10.ne30_ne30.edison/amwg/1980-1989/index.html
amwg hosted at https://acme-viewer.llnl.gov/mccoy20/20170731.F20TR_ck10.ne30_ne30.edison/amwg/1980-1984/index.html
amwg hosted at https://acme-viewer.llnl.gov/mccoy20/20170731.F20TR_ck10.ne30_ne30.edison/amwg/1985-1989/index.html

For the time being dont run with coupled_diags, theres at least one bug that Im not going to fix since I need to transition to the new a-prime version that just got released.


Add Bizable tracking script to Developer and OSS Site

New Relic recently bought some new attribution software that allows us to track all digital touches that a person makes across their customer journey.
We've already added this script to all NR sites owned by the web team and now we're working with other teams to get this script added to all other web-facing properties.
Here are instructions for adding the script for reference:

The script should ideally be hardcoded
Link to instructions including the script: https://docs.marketo.com/display/BIZ/Adding+Bizible+Script

If you have any questions please reach out to Hanne Venables<EMAIL_ADDRESS>and Nadilyn Espanola<EMAIL_ADDRESS>

@jerelmiller suggested we put this in the theme so it's easy to add to all sites.

Before the next MFF kicks off let's see if we can get this done


chore(cicd): remove unneseccary checkout branch

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Live Demo site is down

as the title says. okay if you have decided to remove the demo

It's working.


Add generator (A) should open the signature drawer

It should already do that.

Now it should open the signature drawer even if another drawer (e.g. Project) is open.


Using Warden to authenticate API: user remains authenticated across multiple requests.

We're using Warden to authenticate a Rails API and I've been running into an issue where a user remains authenticated across multiple requests.  As a result, the warden.authenticate! is never run after the first request, so a client could pass up an invalid token or no token and get access to endpoints it shouldn't.
My solution to this problem was to explicitly logout the user before authenticating a request, but this seems a bit hacky to me and I was wondering if there is a better option.
My Code
# routes.rb
Rails.application.routes.draw do
  # ...
    constraints AuthenticatedConstraint.new do
      resources :widgets
    end
  # ...
end

# AuthenticatedConstraint

class AuthenticatedConstraint
  def matches?(request)
    warden = request.env['warden']
    if warden
      warden.logout if warden.authenticated? # is there a better way to do this?
      warden.authenticate!(:token_authentication_strategy)
    end
  end
end

Warden::Strategies.add(:token_authentication_strategy, TokenAuthenticationStrategy)

# TokenAuthenticationStrategy

class TokenAuthenticationStrategy < ::Warden::Strategies::Base
  def valid?
    env['HTTP_AUTHORIZATION'].present?
  end

  def authenticate!
    user = User.for_authentication(token) # retrieves the user with that auth token
    if user
      success!(user)
    end
  end

  def token
    env['HTTP_AUTHORIZATION'].sub('Token token=', '')
  end
end

Any advice would be welcome.  Thank you!!

I think this has to do with this, namely that Warden serializes into the session and API requests are session-less.

Awesome, I'll take a look!

You should mark your strategy as store false to prevent saving into the session.

indeed this solves the issue, had the same problem and solved it in the same way.

Yes, this does, thank you!


FIx: DOMException thrown for PasswordError

Utilising the decryptMnemonic function, I noticed a DOMException is thrown on an incorrect password, rather than the PasswordException. Afaict, an incorrect pw will not reach the code written to handle bad inputs.

I think the legacy "triplesec" handling needs adjusted for this, per unit test failure Should decrypt legacy encrypted phrase, instead errored: Error: Unable to decrypt. Wrong password.


ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE

INFO interface: detail: Requirement already up-to-date: pip in /usr/local/lib/python3.6/site-packages (20.2.3)
INFO interface: detail:     repo: Requirement already up-to-date: pip in /usr/local/lib/python3.6/site-packages (20.2.3)
repo: Requirement already up-to-date: pip in /usr/local/lib/python3.6/site-packages (20.2.3)
INFO interface: detail: Collecting pexpect
INFO interface: detail:     repo: Collecting pexpect
repo: Collecting pexpect
INFO interface: detail:   Using cached pexpect-4.8.0-py2.py3-none-any.whl (59 kB)
INFO interface: detail:     repo:   Using cached pexpect-4.8.0-py2.py3-none-any.whl (59 kB)
repo:   Using cached pexpect-4.8.0-py2.py3-none-any.whl (59 kB)
DEBUG ssh: stderr: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
pexpect from https://files.pythonhosted.org/packages/39/7b/88dbb785881c28a102619d46423cb853b46dbccc70d3ac362d99773a78ce/pexpect-4.8.0-py2.py3-none-any.whl#sha256=0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937:
Expected sha256 0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937
Got        6927f1fa55c7b4e96e42f119d28b6ef2497f04dca57af5d987bce7fac49e599d
INFO interface: detail: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
pexpect from https://files.pythonhosted.org/packages/39/7b/88dbb785881c28a102619d46423cb853b46dbccc70d3ac362d99773a78ce/pexpect-4.8.0-py2.py3-none-any.whl#sha256=0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937:
Expected sha256 0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937
Got        6927f1fa55c7b4e96e42f119d28b6ef2497f04dca57af5d987bce7fac49e599d
INFO interface: detail:     repo: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
repo:     pexpect from https://files.pythonhosted.org/packages/39/7b/88dbb785881c28a102619d46423cb853b46dbccc70d3ac362d99773a78ce/pexpect-4.8.0-py2.py3-none-any.whl#sha256=0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937:
repo:         Expected sha256 0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937
repo:              Got        6927f1fa55c7b4e96e42f119d28b6ef2497f04dca57af5d987bce7fac49e599d
repo: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
repo:     pexpect from https://files.pythonhosted.org/packages/39/7b/88dbb785881c28a102619d46423cb853b46dbccc70d3ac362d99773a78ce/pexpect-4.8.0-py2.py3-none-any.whl#sha256=0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937:
repo:         Expected sha256 0b48a55dcb3c05f3329815901ea4fc1537514d6ba867a152b581d69ae3710937
repo:              Got        6927f1fa55c7b4e96e42f119d28b6ef2497f04dca57af5d987bce7fac49e599d
INFO interface: detail: Collecting ansible
INFO interface: detail:     repo: Collecting ansible
repo: Collecting ansible
INFO interface: detail:   Using cached ansible-2.9.13.tar.gz (14.3 MB)
INFO interface: detail:     repo:   Using cached ansible-2.9.13.tar.gz (14.3 MB)
repo:   Using cached ansible-2.9.13.tar.gz (14.3 MB)
DEBUG ssh: stderr: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
ansible from https://files.pythonhosted.org/packages/32/62/eec759cd8ac89a866df1aba91abf785486fed7774188a41f42f5c7326dcb/ansible-2.9.13.tar.gz#sha256=3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644:
Expected sha256 3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644
Got        571e251c0c3cf58a38e8b0bc5e3f45b7fd346064eedab4e5c54ba221baae2438
INFO interface: detail: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
ansible from https://files.pythonhosted.org/packages/32/62/eec759cd8ac89a866df1aba91abf785486fed7774188a41f42f5c7326dcb/ansible-2.9.13.tar.gz#sha256=3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644:
Expected sha256 3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644
Got        571e251c0c3cf58a38e8b0bc5e3f45b7fd346064eedab4e5c54ba221baae2438
INFO interface: detail:     repo: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
repo:     ansible from https://files.pythonhosted.org/packages/32/62/eec759cd8ac89a866df1aba91abf785486fed7774188a41f42f5c7326dcb/ansible-2.9.13.tar.gz#sha256=3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644:
repo:         Expected sha256 3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644
repo:              Got        571e251c0c3cf58a38e8b0bc5e3f45b7fd346064eedab4e5c54ba221baae2438
repo: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
repo:     ansible from https://files.pythonhosted.org/packages/32/62/eec759cd8ac89a866df1aba91abf785486fed7774188a41f42f5c7326dcb/ansible-2.9.13.tar.gz#sha256=3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644:
repo:         Expected sha256 3ab21588992fbfe9de3173aefd63da1267dc12892a60f5cfdc055fe19c549644
repo:              Got        571e251c0c3cf58a38e8b0bc5e3f45b7fd346064eedab4e5c54ba221baae2438
DEBUG ssh: Exit status: 1
ERROR warden: Error occurred: The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what

What host OS are you using? Are you using a VPN?

Hi, Windows, no VPN. Got the same error also when connected directly to the server and running pip install ansible. Also tried with --no-chache-dir option but with same result.

Have you tried destroying the environment and running vagrant up?

Yes, like 15 times :]] tried lot of stuff before raising this issue.

Give the dev branch a try as this has solved many problems previously encountered. Let me know if you continue to see issues on your end after trying


Copy/Paste line is not putting it to new line

Regression range: https://github.com/microsoft/vscode/compare/9ab88c7abc4d90e67c94ac341bc0fee7679c5556...70dcd62d397867fe03626f938139b834950a985c
Steps:

put cursor at end of line
copy & paste

🐛 the newline is not in the beginning

I'm quite sure this is caused by https://github.com/microsoft/vscode/commit/6384b9bcdf8f2b11988ad2339242955f400895be
In older builds it would bail here:

In the latest nightly of monaco editor, it doesn't.

As a temp fix, I'll make it so that if we are only pasting text and there are no external paste providers, we don't use the copy paste contribution at all and instead fall back to using the editor's copy paste logic
This, https://github.com/microsoft/vscode/issues/181550, and  #181486 are all a little tricky to handle with copy paste providers. Ideally the providers would not have to know about these special cases and we would just handle them automatically


[Autocomplete] Onclick event still fired in a disabled MenuItem

Hi,
I want to disable a menu item  when i have no result in renderSuggestion function for my autocomplete
but the menuitem still clickable.
  return (     <MenuItem component="div" disabled>       <div>         <span> no result </span>       </div>     </MenuItem>   );

Tech
Version

Material-UI
1.0.0-beta.16

React
16.0.0

browser

etc

I'm closing this issue as we are missing a reproduction example.
We have an example in the documentation where the menu item is disabled and doesn't tricker any click event.
https://github.com/callemall/material-ui/blob/b900165d76fdf954106602b98c10d2a5a099c17b/docs/src/pages/demos/menus/SimpleListMenu.js

disable menu item works in simple liste menu but it's not the case in autocomplete component https://material-ui-next.com/demos/autocomplete/#autocomplete  , the menu item component still fired   with disabled property.


Generate uuids so that editorial don't have to do that in the spreadsheet

Generates the person uuid from an MD5 hash of the tme identifier (matching the behaviour in the curated-authors-transformer) and the membership uuid from a combo of person and org uuids

:+1:


Adding travis testing and failing cast test

Simple travis testing of language features.  All I want to do is cast a float to an int.

More java options

I just added my integer arithmetic NPE, which only shows up when provenance is on.


Add method / statuse for Unauthorized (403)

Add additional extension method along with DomainOperationStatus states - Unauthorized (gets automatically converted to HTTP code 403).

Implemented in #5


FS-2940 - Fix yes no appearing only in English

https://dluhcdigital.atlassian.net/browse/FS-2940
Change description
Adding welsh option for yes No

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

Could you update the unit tests please to cover welsh? Probably here
https://github.com/communitiesuk/funding-service-design-utils/blob/15f31d65910b5b6df5abb93887965582ec697379/tests/test_mapping_application.py#L128

Added test for welsh scenario


add support for ledger nano s plus

fixes https://github.com/bitcoin-core/HWI/issues/595 by adding the nano s plus model id.
I am not familiar with this codebase, so maybe I am missing something, but it seemed as simple as adding this one line.
I only did two manual integration tests, just to see that hwi enumerate recognized my ledger nano s plus:
1st test: ledger nano s+ plugged in, but not unlocked
% hwi --expert --debug enumerate
DEBUG:ledgercomm:=> b001000000
DEBUG:ledgercomm:<=<PHONE_NUMBER>636f696e05322e302e340102 9000
DEBUG:ledgercomm:=> e105000000
DEBUG:ledgercomm:<=  6982
INFO:jade.tcp:Connecting to tcp:<IP_ADDRESS>:2222
DEBUG:root:Failed to connect to Jade simulator at tcp:<IP_ADDRESS>:2222
DEBUG:root:[Errno 61] Connection refused
[{"type": "ledger", "model": "ledger_nano_s_plus", "label": null, "path": "DevSrvsID:4295015068", "error": "Could not open client or get fingerprint information: ('0x6982', 'Error in command', '')", "code": -13}]

2nd test: ledger nano s+ plugged in and unlocked:
% hwi --expert --debug enumerate
DEBUG:ledgercomm:=> b001000000
DEBUG:ledgercomm:<=<PHONE_NUMBER>636f696e05322e302e340102 9000
DEBUG:ledgercomm:=> e105000000
DEBUG:ledgercomm:<= ... 9000
INFO:jade.tcp:Connecting to tcp:<IP_ADDRESS>:2222
DEBUG:root:Failed to connect to Jade simulator at tcp:<IP_ADDRESS>:2222
DEBUG:root:[Errno 61] Connection refused
[{"type": "ledger", "model": "ledger_nano_s_plus", "label": null, "path": "DevSrvsID:4295015068", "fingerprint": "...", "needs_pin_sent": false, "needs_passphrase_sent": false}]

(Note, fingerprint is redacted)
Let me know if there are any other tests I should run.
I am also not sure if i need to add the 0x0005 code to the LEDGER_LEGACY_PRODUCT_IDS dict as well?

You will also need to update the udev rules file with the latest from ledger

I am not familiar with this codebase, so maybe I am missing something, but it seemed as simple as adding this one line.

Pretty much. My understanding is that this is just like the Nano X - same protocol, just need to recognize the USB device, which this PR does.

I am also not sure if i need to add the 0x0005 code to the LEDGER_LEGACY_PRODUCT_IDS dict as well?

There's no legacy product id for it to have, so there is no need to add anything there.

awesome thanks for the guidance!
I added the udev rule (the ledger devs named it "Ledger Test" which seems off (should be ledger nano s +, no?)), but I left it identical to what they put in.

ACK 8874f3ae23db66acb62b571b2b708b4b7a839d16


Support for post-build scripts

Hi,
Thanks for sharing this!
Would you have any ideas on how to extend this to support post build scripts for MacOS? The AcceptExternalModificationsToPlayer option doesn't seem to be allowed for the MacOS target , and without it Unity seems to switch platform too early, skipping the postbuild scripts completely.
I've tried switching back to SwitchActiveBuildTarget (not async) and the same thing happens.
Thanks!

Looks like for 2021.3 support for modifying the xcode project for MacOS builds has been added. 👍


Display label number for each point on QC plot for label-based registration

Next to each blue point:

@jcohenadad Could you please give me more information about how to reproduce this graphic

just run sct_register_to_template with -v 2 and it will be generated there.


pre-commit: we need types_or for this

Run our own hook over CSS or JS or SVG.

I finally figured it out why it was not working properly 🎉


's used to display images with a fallback break keyboard navigation inside of RadioGroup

Provide a general summary of the issue here
I have the following JSX inside of a <Radio/>:
<object
      className={cn("aspect-square size-10 rounded object-cover", className)}
      width={Number(pass.avatar.width)}
      height={Number(pass.avatar.height)}
      data={pass.avatar.url}
      type={type}
      aria-label={pass.name}
      ref={forwardedRef}
      tabIndex={-1}
    >
      <img
        className={cn("aspect-square size-10 rounded object-cover", className)}
        width={Number(pass.avatar.width)}
        height={Number(pass.avatar.height)}
        src={pass.avatar.thumbnailUrl}
        alt={pass.name}
     />
</object>

This markup is used to implement images with a fallback as described here: https://blog.sentry.io/fallbacks-for-http-404-images-in-html-and-javascript/
When navigating with the keyboard across different <Radio/>'s inside of a <RadioGroup/>, the <object/>'s inside of each <Radio/> gets focused on rather than the the currently selected <Radio/>'s preceding/proceeding <Radio/>.
This is because <object/>'s are marked as focusable. I don't believe there is any way to mark <object/>'s as not focusable based on the code in getFocusableTreeWalker(). If there is a way to explicitly mark JSX elements as not focusable however, that would solve the issue.
Based on what I read from getFocusableTreeWalker() as well, setting a tabIndex of -1 to an element only marks the element as not tabbable which thus still causes this bug.
🤔 Expected Behavior?
That keyboard navigation across <Radio/>'s with <object/>'s representing images with fallbacks works.
😯 Current Behavior
Proceeding/preceding <Radio/>'s upon keyboard navigation do not properly get focused.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/p/devbox/dvzc8v?migrateFrom=fprxtz&layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clx17srml00063b6stwmynu23%2522%252C%2522sizes%2522%253A%255B71.9675925925926%252C28.032407407407405%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clx17srml00023b6sbvdb6yu9%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clx17srml00043b6savd7k50x%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clx17srml00053b6s7ajihjnl%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B62.44345812627669%252C37.55654187372331%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clx17srml00023b6sbvdb6yu9%2522%253A%257B%2522id%2522%253A%2522clx17srml00023b6sbvdb6yu9%2522%252C%2522activeTabId%2522%253A%2522clx17tju200aa3b6s3fjyiwyz%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clx17srml00013b6sq97i4c1l%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fpackage.json%2522%257D%252C%257B%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fpostcss.config.js%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A1%252C%2522endLineNumber%2522%253A1%252C%2522startColumn%2522%253Anull%252C%2522endColumn%2522%253Anull%257D%255D%252C%2522id%2522%253A%2522clx17tju200aa3b6s3fjyiwyz%2522%252C%2522mode%2522%253A%2522temporary%2522%257D%255D%257D%252C%2522clx17srml00053b6s7ajihjnl%2522%253A%257B%2522id%2522%253A%2522clx17srml00053b6s7ajihjnl%2522%252C%2522tabs%2522%253A%255B%257B%2522type%2522%253A%2522TASK_PORT%2522%252C%2522port%2522%253A5173%252C%2522taskId%2522%253A%2522Development%2522%252C%2522id%2522%253A%2522clx17uih600he3b6ss9gkyblg%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522activeTabId%2522%253A%2522clx17uih600he3b6ss9gkyblg%2522%257D%252C%2522clx17srml00043b6savd7k50x%2522%253A%257B%2522id%2522%253A%2522clx17srml00043b6savd7k50x%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clx17srml00033b6sfvxoysu7%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TERMINAL%2522%252C%2522shellId%2522%253A%2522clx17ss3a000adaf85mhlgjcm%2522%257D%252C%257B%2522type%2522%253A%2522TASK_LOG%2522%252C%2522taskId%2522%253A%2522Development%2522%252C%2522id%2522%253A%2522clx17tdx2007e3b6sl4ffimih%2522%252C%2522mode%2522%253A%2522permanent%2522%257D%255D%252C%2522activeTabId%2522%253A%2522clx17tdx2007e3b6sl4ffimih%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D
Version
react-aria 3.33.1, react-aria-components 1.2.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
Mac
🧢 Your Company/Team
Only1
🕷 Tracking Issue
No response

It looks like what needs to be done to check if an element is focusable/tabbable is a lot more complex than it seems vs. the checks in getFocusableTreeWalker(): https://allyjs.io/data-tables/focusable.html#object-element
In the specific case of RadioGroup though, I think the code could be amended to solely walk the tree for preceeding/proceeding <Radio/> items based on my cursory read of the ARIA RadioGroup spec.
https://www.w3.org/WAI/ARIA/apg/patterns/radio/
For Radio Groups Not Contained in a Toolbar

Right Arrow and Down Arrow: move focus to the next radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the last button, focus moves to the first button.
Left Arrow and Up Arrow: move focus to the previous radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the first button, focus moves to the last button.

For Radio Group Contained in a Toolbar

Right Arrow:
When focus is on a radio button and that radio button is not the last radio button in the radio group, moves focus to the next radio button.
When focus is on the last radio button in the radio group and that radio button is not the last element in the toolbar, moves focus to the next element in the toolbar.
When focus is on the last radio button in the radio group and that radio button is also the last element in the toolbar, moves focus to the first element in the toolbar.
Left Arrow:
When focus is on a radio button and that radio button is not the first radio button in the radio group, moves focus to the previous radio button.
When focus is on the first radio button in the radio group and that radio button is not the first element in the toolbar, moves focus to the previous element in the toolbar.
When focus is on the first radio button in the radio group and that radio button is also the first element in the toolbar, moves focus to the last element in the toolbar.
Down Arrow (optional): Moves focus to the next radio button in the radio group. If focus is on the last radio button in the radio group, moves focus to the first radio button in the group.
Up Arrow (optional): Moves focus to the previous radio button in the radio group. If focus is on the first radio button in the radio group, moves focus to the last radio button in the group.

Thanks for reporting that. I'm not sure why we explicitly allow for object to be focusable according to our tree walker. They don't appear to be focusable on their own in plain HTML
https://jsfiddle.net/v0c2kn5L/8/ It looks like they aren't focusable by keyboards even if a tab index is specified. They can be programmatically focused, but would need a tabIndex >= 0
I'll see if anyone on the team remembers more about this line
https://github.com/adobe/react-spectrum/blob/0c17289de18041e6f8b99df26a5a3ca922cc5145/packages/%40react-aria/focus/src/FocusScope.tsx#L279

Thanks for reporting that. I'm not sure why we explicitly allow for object to be focusable according to our tree walker. They don't appear to be focusable on their own in plain HTML
https://jsfiddle.net/v0c2kn5L/8/ It looks like they aren't focusable by keyboards even if a tab index is specified. They can be programmatically focused, but would need a tabIndex >= 0
I'll see if anyone on the team remembers more about this line
https://github.com/adobe/react-spectrum/blob/0c17289de18041e6f8b99df26a5a3ca922cc5145/packages/%40react-aria/focus/src/FocusScope.tsx#L279

It was more relevant in the age of plugins, but object tags are focusable depending on the element being rendered.


USE_IMAGE_MAGICK options should be ON by default since they are required for colors to appear correctly

Defaults of USE_IMAGE_MAGICK and OSPRAY_USE_IMAGE_MAGICK should be ON.

I'm adding big notices to the website demos now, obviously we will need to make this more intuitive.
Ideally we want to limit the number of default dependencies- the example apps are purely just for tutorial purposes, the OSPRay library itself does not require ImageMagick.  That said, it will obviously lead to a lot of confusion and headaches if our first tutorials require custom build options.  We will likely either bundle imagemagick with the binaries or try to find a header only library that can deal with the myriad of file types.  @jeffamstutz thoughts?

So what part is for tutorial purposes, the whole bin/ospGlutViewer or only parts of it? If the whole bin/ospGlutViewer and lib/libospray_commandline.so are for tutorial purposes, you should add the option BUILD_COMMAND_LINE_APPS, and make ImageMagic required only in this case. Otherwise you build a broken ospGlutViewer.

All the "apps" including ospGlutViewer are purely for tutorial/demo purposes, and are not particularly robust.  There are already cmake flags to control building them, which we could turn off by default.  That said, you are of course correct that they should work with the demo gallery examples out of the box, the imagemagick dependency was an omission on my part.

Just sync USE_IMAGE_MAGICK and OSPRAY_USE_IMAGE_MAGICK with OSPRAY_ENABLE_APPS then.

I have added a header only image library that will be built with the apps by default.  This should get the demos running with the binary releases by default.  Currently in devel and should be in next release.


TagRequest, contains an array of TagImages, which contains Tags

I am super hyped to see this! I am finishing up some work and will take a bit to check out the stuff in a bit :dancer:

WOOT Travis CI is working haha

OH PERFECT!  I GUESS THAT MEANS WE ARE GREAT WORK!
You will need to teach me how! :tada: :tada: :tada: :tada: :tada:


Implement asset flow for folder preprocessor

Start from a local folder, assume it is rclone'd from Dropbox (so there may be incomplete file states during the uploading). Ensure proper locking and handling of incomplete files.
Once the file is available in the sync folder, have preprocessor "manage state"* in the database, and process it into webhook infra.
The final state is that the cid'd file is uploaded to local filesystem and indexed in AuthAttr service, via the webhook implementation for folder sync.
*management of state means reliable processing. e.g. Start tracking the file as "uploading" during upload, "pending" while it is upload completed but being processed, and error states if cid-ing or other steps have failed, such as AuthAttr being offline, etc.
Dummy values for all attributes for now.

Some example metadata that's good to have (will add more)

[ ] File name
[ ] File size
[ ] File last modified time
[ ] File SHA-256 (backup for CID)

Handling incomplete files
Files are synced into a folder at the start of this process. These files may be large and take time to completely download into the folder. The "Sync Folder Preprocessor" must only start processing a file once it has been completely transferred.
There are broadly two ways of doing this. One is a lock file for the whole directory, that tells the preprocessor when an active file transfer is going on by existing, and that file transfer is complete by not existing.
The second method is to do file name filtering. For example incomplete files have a dot prefix or a .incomplete suffix, and the preprocessor is only looking for files that match *.jpg or whatever.
I am in favour of the second method when possible as it seems more versatile. For example it allows for an on-going sync daemon, whereas with the lock file the service (such as rclone) has to sync and then stop periodically. Consequentially the preprocessor would also have to stop.
What tools do:

Our MVP will be using rclone with Dropbox. By default rclone adds a .partial suffix to files it hasn't finished transferring.
Normal non-cloud transfers can be done with rsync, which gives temporary files a . prefix and a random suffix.

From these two providers it seems like we can use file name filtering as our way of preventing incomplete files from being picked up by the preprocessor.  It would likely have a few steps:

Always ignoring hidden files / dot files
Supporting a whitelist of file extensions
Always ignoring .partial files even if all file extensions are allowed


Fix code examples in README

Specify all required dependencies
Add missing db initialization line
Use anonymous type to make JSON example runnable

Codecov Report
Patch and project coverage have no change.

Comparison is base (19a3f1f) 93.36% compared to head (09b4774) 93.36%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   93.36%   93.36%
=======================================
  Files          77       77
  Lines        4566     4566
  Branches      422      422
=======================================
  Hits         4263     4263
  Misses        181      181
  Partials      122      122

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added MDWaterBox documentation to the README

Added the example of a standard run of MDWaterBox scenario to the README, highlighting the possible decision points that the user has control of. This is the first scenario documentation in README, so please give constructive feedback to set a gold standard to future scenarios

We should probably write our examples using the synchronous simulate, and have directly return an instance of the scenario output class.
You are missing a visualization, right?
Anything related to running simulations asynchronously and/or launching/choosing the machine group to run them should be in a separate section of the README, so we don't have to repeat this information for all scenarios.

I think that the simulate_async is the most important method I want the users to  know, since any meaningful simulations will take a lot of time, so the async is the natural choice.
I will add the viz section in a posterior PR;
I agree with this point, but was thinking to build the general section after every scenario is documented, in order to clearly see which is the common thread between them all.


Hosting improvements

Betterize Hosting Log https://github.com/aspnet/AspNetCore/pull/10102
Pool the HostingApplication.Context and HttpContext on all servers
/cc @halter73

Better for Kestrel, worse for all the servers that can't pool it...

Better for Kestrel, worse for all the servers that can't pool it...

Might be able to improve the other servers at the same time... Investigating

HttpSys was boxing the struct so allocating it anyway; have changed it not to box

Also shaves 32 bytes off the size of the ProcessRequests statemachine
 ; Assembly listing for method HttpProtocol:ProcessRequests(ref):ref:this
 ;
 ;  V00 this         [V00,T00] (  3,  3   )     ref  ->  rcx         this class-hnd
 ;  V01 arg1         [V01,T01] (  3,  3   )     ref  ->  rdx         class-hnd
-;  V02 loc0         [V02    ] (  7,  6.25)  struct (136) [rsp+0x20]   do-not-enreg[XSFB] must-init addr-exposed ld-addr-op
+;  V02 loc0         [V02    ] (  7,  6.25)  struct (104) [rsp+0x20]   do-not-enreg[XSFB] must-init addr-exposed ld-addr-op
 ;* V03 loc1         [V03    ] (  0,  0   )  struct ( 8) zero-ref    ld-addr-op
 ;  V04 OutArgs      [V04    ] (  1,  1   )  lclBlk (32) [rsp+0x00]   "OutgoingArgSpace"
 ;* V05 tmp1         [V05    ] (  0,  0   )  struct ( 8) zero-ref    ld-addr-op "Inline ldloca(s) first use temp"
 ;  V06 tmp2         [V06,T02] (  2,  4   )     ref  ->  rax         class-hnd "dup spill"
 ;  V07 tmp3         [V07,T03] (  4,  3.25)     ref  ->  rax
 ;* V08 tmp4         [V08    ] (  0,  0   )     ref  ->  zero-ref    V03.m_task(offs=0x00) P-INDEP "field V03.m_task (fldOffset=0x0)"
 ;* V09 tmp5         [V09    ] (  0,  0   )     ref  ->  zero-ref    V05.m_task(offs=0x00) P-INDEP "field V05.m_task (fldOffset=0x0)"
 ;
 ; Lcl frame size = 168

 G_M39292_IG01:
        57                   push     rdi
        56                   push     rsi
-       4881ECA8000000       sub      rsp, 168
+       4881EC88000000       sub      rsp, 136
        488BF1               mov      rsi, rcx
        488D7C2420           lea      rdi, [rsp+20H]
-       B922000000           mov      ecx, 34
+       B91A000000           mov      ecx, 26
        33C0                 xor      rax, rax
        F3AB                 rep stosd

And saves a bunch of stack copies from it

and

Better for Kestrel, worse for all the servers that can't pool it...

Enabled pooling of both the host Context and the HttpContext for all servers

Can do better

Better for Kestrel, worse for all the servers that can't pool it...

Might be able to improve the other servers at the same time... Investigating

HttpSys for 1M requests:

Allocates 34M objects rather than 54M objects (-20M, -37%)
Allocates 1.64GB rather than 7.83GB (-6.19GB, -79%)

Before

After

Looking at IIS

Splitting this up... first is https://github.com/aspnet/AspNetCore/pull/10283

Superceaded by https://github.com/aspnet/AspNetCore/pull/10319


⚠ Jenkins Plugins Artifactory has degraded performance

In 225a937, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1115 ms

Resolved: Jenkins Plugins Artifactory performance has improved in e02a0f3 after 12 minutes.


Why multiply 1.10?

Hi I looked to the test and have a question about why we need multiply expectedRate with 1.1?
https://github.com/lovasoa/bloomfilter/blob/7d022145d6dd631b69004b0e834908e333f60ed3/src/test/java/Test.java#L59

I wrote this code a long time ago, but this seems to be because the actual error rate asymptotically converges to what the formula gives when the number of elements in the filter is large. This is not an exact formula that gives the exact number of false positives whatever the elements are.


Improve documentation of quality metrics

Ideally this should have been caught by the NumpyDoc checks :(

Ideally this should have been caught by the NumpyDoc checks :(

Agreed, appreciate your work getting it up and running again.


Update runtimes workflow to don't break when a file doe not exists

Update runtimes workflow to don't break when a file doe not exists
Bug found here: https://github.com/opendatahub-io/notebooks/actions/runs/10610954620/job/29409452122#step:5:78

Is this truly a bug? I would expect that we simply don't list the missing files in the created list in the script. :thinking:

Well I found this when i triggered the gha for the 2023b where we don't have rocm files on the runtimes folder. In any case we still evaluate the outcome on the autogenerated pr!

I see... because we use just one GHA for different branches with different content, hm :thinking:


Mark points fix bounds

Fixes #9 ,
adds a font with a single oblique '!' char to test/ with.
add little borders around origin and the xadvance point.

Closing in favor of #12


[Bug]: "metadatas" is a mistake, "metadata" is already plural form

What happened?
"metadatas" is used in many places in the project but is a mistake, "metadata" is already plural form
Versions
N/A
Relevant log output
No response

Maybe an English mistake, but I feel like the plural distinction is useful in the codebase and helps with readability. Need to know if a function expects a single object of (metadata), or an array of metadata objects (metadatas)

Thank you for flagging @mlengle


how to mount additional volumes with runners

do runners support mounting additional volumes (PVC's and host volumes). I tried looking for additional documentation on this but found none. Trying a few things it does not seem to work. Any guidance that can be provided is helpful.

@acesir you closed this, was there an answer?

ahh I found it in CRD

I see how to attach an existing volume, but not a way to create a pvc at pod creation time


Added Registry FAQ page

What changed? Why?
Added in an FAQ for the Onchain Registry and edited the navbar to show the API docs and FAQ under a dropdown.
How has it been tested?
I ran the docs site and tested locally

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/2

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2


72 add export import permissions

Thanks for your work.
I just tested it and it doesn't seem to be working.
Steps :
I exported my current permissions and obtained a correctly formatted json.
I deleted and reinstalled the extension, imported the file, it says imported correctly but when I check the Preferences tab, there are no whitelisted operations.
Also, when nothing is whitelisted I think an empty json would be better than undefined.


scoop install git failed (2.6.1)

PS C:\Users\mathieu> scoop install git
installing git (2.6.1.windows.1)
loading https://github.com/git-for-windows/git/releases/download/v2.6.1.windows.1/PortableGit-2.6.1-64-bit.7z.exe#/dl.7z
 from cache...
checking hash...ok
extracting...done
creating shim for git
creating shim for gitk
creating shim for git-gui
% : Exception calling "ExpandString" with "1" argument(s): "Object reference not set to an instance of an object."
At C:\Users\mathieu\appdata\local\scoop\apps\scoop\current\lib\install.ps1:591 char:55
+         $manifest.env_set | gm -member noteproperty | % {
+                                                       ~~~
    + CategoryInfo          : NotSpecified: (:) [ForEach-Object], MethodInvocationException
    + FullyQualifiedErrorId : NullReferenceException,Microsoft.PowerShell.Commands.ForEachObjectCommand

I get a similar, but not exactly the same, error, when updating git:
creating shim for git
creating shim for gitk
creating shim for git-gui
Exception calling "ExpandString" with "1" argument(s): "Object reference not set to an instance of an object."
At C:\Users\Vidar Kongsli\appdata\local\scoop\apps\scoop\current\lib\core.ps1:9 char:5
+     $executionContext.invokeCommand.expandString($str)
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : NullReferenceException

running post-install script...
fatal: failed to stat '.': Permission denied
git was updated from 2.4.6.windows.1 to 2.6.1.windows.1

Do you get an error if you do a clean installation of git?

On a clean Win 2012 R2 box:
Windows PowerShell
Copyright (C) 2014 Microsoft Corporation. All rights reserved.

PS C:\Users\minion_admin> iex (new-object net.webclient).DownloadString('https://get.scoop.sh')
initializing...
downloading...
extracting...
creating shim...
adding ~\appdata\local\scoop\shims to your path
scoop was installed successfully!
type 'scoop help' for instructions
PS C:\Users\minion_admin> scoop install git
installing 7zip (9.38)
downloading http://www.7-zip.org/a/7z938-x64.msi...done
checking hash...ok
extracting...done
creating shim for 7z
7zip (9.38) was installed successfully!
installing openssh (5.4p1-1)
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Extension/openssh/openssh-5.4p1-1/openssh-5.4p1-1-msys-1.0
.13-bin.tar.lzma...done
checking hash...ok
extracting...done
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Extension/openssh/openssh-5.4p1-1/openssh-5.4p1-1-msys-1.0
.13-lic.tar.lzma...done
checking hash...ok
extracting...done
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Base/msys-core/msys-1.0.13-2/msysCORE-1.0.13-2-msys-1.0.13
-bin.tar.lzma...done
checking hash...ok
extracting...done
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Extension/zlib/zlib-1.2.3-2/zlib-1.2.3-2-msys-1.0.13-dll.t
ar.lzma...done
checking hash...ok
extracting...done
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Extension/minires/minires-1.02_1-2/libminires-1.02_1-2-msy
s-1.0.13-dll.tar.lzma...done
checking hash...ok
extracting...done
downloading http://ufpr.dl.sourceforge.net/project/mingw/MSYS/Extension/openssl/openssl-1.0.0-1/libopenssl-1.0.0-1-msys-
1.0.13-dll-100.tar.lzma...done
checking hash...ok
extracting...done
creating shim for scp
creating shim for sftp
creating shim for slogin
creating shim for ssh-add
creating shim for ssh-agent
creating shim for ssh-keygen
creating shim for ssh-keyscan
creating shim for ssh
openssh (5.4p1-1) was installed successfully!
installing git (2.6.1.windows.1)
downloading https://github.com/git-for-windows/git/releases/download/v2.6.1.windows.1/PortableGit-2.6.1-64-bit.7z.exe#/d
l.7z...done
checking hash...ok
extracting...done
creating shim for git
creating shim for gitk
creating shim for git-gui
% : Exception calling "ExpandString" with "1" argument(s): "Object reference not set to an instance of an object."
At C:\Users\minion_admin\appdata\local\scoop\apps\scoop\current\lib\install.ps1:591 char:55
+         $manifest.env_set | gm -member noteproperty | % {
+                                                       ~~~
    + CategoryInfo          : NotSpecified: (:) [ForEach-Object], MethodInvocationException
    + FullyQualifiedErrorId : NullReferenceException,Microsoft.PowerShell.Commands.ForEachObjectCommand
PS C:\Users\minion_admin>

When trying uninstall/install (on my Win 8.1 box):
$ scoop uninstall git
uninstalling git (2.6.1.windows.1)
removing shim for git
removing shim for gitk
removing shim for git-gui
removing older version, 1.9.4
removing older version, 1.9.5
removing older version, 1.9.5-preview20150319
removing older version, 2.4.6.windows.1
git was uninstalled
$ scoop install git
installing git (2.6.1.windows.1)
loading https://github.com/git-for-windows/git/releases/download/v2.6.1.windows.1/PortableGit-2.6.1-64-bit.7z.exe#/dl.7z from cache...
checking hash...ok
extracting...done
creating shim for git
creating shim for gitk
creating shim for git-gui
Exception calling "ExpandString" with "1" argument(s): "Object reference not set to an instance of an object."
At C:\Users\Vidar Kongsli\appdata\local\scoop\apps\scoop\current\lib\core.ps1:9 char:5
+     $executionContext.invokeCommand.expandString($str)
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : NullReferenceException

running post-install script...
git (2.6.1.windows.1) was installed successfully!
$

I'm hitting the same issue.
Windows 8.1, clean install (wiped my laptop a few days ago)
Powershell running without Administrator privileges.
PS C:\Users\Vinny> scoop uninstall git
uninstalling git (2.6.2.windows.1)
git was uninstalled
PS C:\Users\Vinny> scoop install git grep sed wget vim
installing git (2.6.2.windows.1)
loading https://github.com/git-for-windows/git/releases/download/v2.6.2.windows.1/PortableGit-2.6.2-64-bit.7z.exe#/dl.7z
 from cache...
checking hash...ok
extracting...done
creating shim for git
creating shim for gitk
creating shim for git-gui
% : Exception calling "ExpandString" with "1" argument(s): "Object reference not set to an instance of an object."
At C:\Users\Vinny\appdata\local\scoop\apps\scoop\current\lib\install.ps1:591 char:55
+         $manifest.env_set | gm -member noteproperty | % {
+                                                       ~~~
    + CategoryInfo          : NotSpecified: (:) [ForEach-Object], MethodInvocationException
    + FullyQualifiedErrorId : NullReferenceException,Microsoft.PowerShell.Commands.ForEachObjectCommand

PS C:\Users\Vinny> scoop uninstall git
uninstalling git (2.6.2.windows.1)
git was uninstalled
PS C:\Users\Vinny>

@lukesampson What is the member noteproperty and do you know why it would be returning null?

The noteproperty member type is like a dynamic property that was added to an object at runtime (as opposed to defined on the class itself). When Scoop uses convertfrom-json to parse manifests, it creates a PSCustomObject with some base methods like Equals and ToString and then all the JSON data as "note properties". gm -member NoteProperty is a way to just iterate on the dynamic properties.
The -member is a bit misleading here: the full parameter name is -memberType but Powershell expands the shortened -member to -memberType. So this code is supposed to get all dynamic properties of env_set of type NoteProperty and iterate on them.

As a workaround, people might want to install git19 for now.

I need git 2.x.
So is there a workaround ? Or a way to manually fix the scoop recipe and install it manually ?
Thanks!

Sorry about these problems. We haven't been able to repro the error but now you should be able to install Git 2 at least. If you need to use an SSH key with password with Git you'll need to run this separately:
scoop install openssh
[environment]::setenvironmentvariable('GIT_SSH', (resolve-path (scoop which ssh)), 'USER')

Sorry I opened a new issue related to git before reading this one. But I guess mine's a bit different, hash check failed. #558

Gonna close this as we haven't had any more issues since ec08121


feat(metadata): add id to contact types

Add ID to contact type in metadata api
Please Review
@aml-development/ozp-backend-team
Checklist

[ ] Read CONTRIBUTING.md
[ ] Write code to complete task
[ ] Python Code is PEP8 Compliant
[ ] Add unit tests for new code
[ ] All tests must pass before merging the pull request
[ ] At least 2 people reviewed code

:+1:  looks good

id is included in the contact_types results now :+1:


Move spec conformance test module to tests directory

Purpose
Move spec conformance test module

Codecov Report

Merging #13506 into spec-conformance-tests will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##             spec-conformance-tests   #13506      +/-   ##
============================================================
- Coverage                     60.17%   60.15%   -0.02%
  Complexity                      659      659
============================================================
  Files                          2153     2152       -1
  Lines                        104376   104270     -106
  Branches                      13361    13348      -13
============================================================
- Hits                          62806    62727      -79
+ Misses                        36306    36286      -20
+ Partials                       5264     5257       -7

Impacted Files
Coverage Δ
Complexity Δ

tool-plugins/vscode/src/core/extension.ts
19.48% <0%> (-6.74%)
0% <0%> (ø)

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
80.24% <0%> (-4.33%)
0% <0%> (ø)

...et/http/clientendpoint/CreateSimpleHttpClient.java
85.71% <0%> (-2.93%)
0% <0%> (ø)

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
50% <0%> (-1.67%)
0% <0%> (ø)

...lang/compiler/desugar/StreamsPreSelectDesuagr.java
94.84% <0%> (-1.39%)
0% <0%> (ø)

...inalang/compiler/desugar/StreamingCodeDesugar.java
96.37% <0%> (-0.36%)
0% <0%> (ø)

...mantics/analyzer/StreamsQuerySemanticAnalyzer.java
87.33% <0%> (-0.14%)
0% <0%> (ø)

...nalang/net/http/clientendpoint/InitGlobalPool.java

...e/src/main/java/org/ballerinalang/bre/bvm/BVM.java
81.28% <0%> (+0.03%)
0% <0%> (ø)
:arrow_down:

...nalang/langserver/signature/SignatureHelpUtil.java
88.81% <0%> (+0.58%)
0% <0%> (ø)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f617f...d1dfef0. Read the comment docs.


test(core): add failing test to generatePath, see #6171

this is a failing test to reproduce issue #6171
not sure how to fix it yet

We need to add the pretty option: https://github.com/pillarjs/path-to-regexp/tree/v1.7.0#compile-reverse-path-to-regexp

it works locally, we should rebuild on travis

Whoops! Thanks for that, Paul. Let's just get this merged in because it's the expected behavior.


Bug: Production error on resolveModel on field blur

The Problem
I have a react-redux-form field that fires an error on production when the field loses focus.

TypeError: Cannot read property '0' of undefined
at s (resolve-model.js:31)
at n.value (resolve-model.js:62)
at u (react-dom.production.min.js:130)

when I checked the model being passed to the control: when the field loses focus gets appended to 0 : userForm.postalCode.0.
My component having this configuration:
<Control
       component={Textbox.getNumericField}
       model={this.props.userForm.postalCode.model}
       maxLength={this.props.maxLength}
       placeholder={this.props.placeholder ? I18n.t(this.props.placeholder) : ''}
       tabIndex={this.props.tabIndex}
       disabled={this.props.disabled}
       onChange={this.props.onChange}
       onBlur={this.props.onBlur}
       updateOn={this.props.updateOn}
       debounce={DEBOUNCE_TIME}
     />

And the connect function is
const mapStateToProps = state => ({
  userForm: state.forms.userForm,
});

Notice :  Happens only on production with npm run build --production.
Update:
As intercepting the actions getting fired, I notices something weird on production that an action rrf/batch getting fired with a huge payload (24MB) .
Here is a snippet from the value field:
{
  type: 'rrf/batch',
  model: 'userForm.postalCode',
  actions: [
    {
      type: 'rrf/blur',
      model: 'userForm.postalCode'
    },
    {
      type: 'rrf/change',
      model: 'userForm.postalCode',
      value: [
        {
          dispatchConfig: {
            phasedRegistrationNames: {
              bubbled: 'onBlur',
              captured: 'onBlurCapture'
            },
            dependencies: [
              'topBlur'
            ]
          },
          _targetInst: {
            tag: 5,
            key: null,
            type: 'input',
            stateNode: {
              __reactInternalInstance$lnrmmrliyu: '[CIRCULAR]',
              __reactEventHandlers$lnrmmrliyu: {
                maxLength: 5,
                placeholder: '',
                tabIndex: 1,
                disabled: false,
                name: 'userForm.postalCode',
                type: 'text',
                value: '56070'
              },
              _wrapperState: {
                initialValue: '',
                controlled: true
              },
              value: '56070',
              _valueTracker: {}
            },
            'return': {
              tag: 2,
              key: null,
              stateNode: { ...

Seems to occur after the oldHandleBlur change was implemented in 1.16.8 https://github.com/davidkpiano/react-redux-form/commit/0f4051206c4964648a9fde1215172615504e1d80

If you know the probable fix, I'd be happy to pull in a PR.


disableImportsSorting not working

This is my current typescriptHero configuration:
  "typescriptHero.imports.disableImportsSorting": true,   "typescriptHero.imports.organizeOnSave": true,   "typescriptHero.imports.multiLineWrapThreshold": 100,
They all work except the  disableImportsSorting. It always sorts them. I just want the removal of unused imports.
Thanks!

I've been looking for an approach to organizing imports and really like this extension. The sorting feature is great but would like to turn that off. Is it possible to confirm this is an issue and/or suggest any work-arounds?
Much appreciated!


Cassandra Spring workshop 24/06/2021

Name: Alexander Cerda
Email<EMAIL_ADDRESS>Linkedin Profile: www.linkedin.com/in/alexander-cerda-koehler
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:

Looks good Alexander, thank you. Here's your badge -> https://api.badgr.io/public/assertions/a21J3BesSa-KKgOefEKwsQ?identity__email=alexanderjck%40gmail.com


Remove double  tag

As all included images already contain an opening tag for , a second one should not be added.

@jvdvegt, good catch.
Thank you for the PR, I will merge and add it to the next release.
The tests will fail because they contain the double SVG tag of the unfixed implementation.
I will fix it on my end.


Data sending rate limit

Data sending rate should be limited for all device types so the communication channel does not get overloaded which can cause delays in response.

I agree


Fix logged path to match checked path in loader

This is to fix a logged path missed in
8f5c1780706113c926bb7801db27dbae97d00fcf

@narfbg
“Fix whitespace in previous commit”, I Got it.
Thanks :rose:

@ftwbzhao That has nothing to do with this thread ... keep it on topic.