Stop sequence works not as intended in VLLM.

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_community.llms.vllm import VLLM

llm = VLLM(
    model="meta-llama/Meta-Llama-3.1-8B-Instruct",
    max_new_tokens=1024,
    temperature=0.2,
    top_p=0.95,
    top_k=50,
    dtype="float16",
    stop=["[END]"], # <--- Does not affect the output in any way.
    tensor_parallel_size=4,
    trust_remote_code=True,
    vllm_kwargs={
        "gpu_memory_utilization": 0.90,
        "seed": 42,
        "device": "cuda",
        "max_model_len": 16_000,
    },
)

# ~skip tokenizer creation~

SYSTEM = "Always surround your answer with [START] and [END] tags."
question = "Count from 1 to 10"
template = [{"role": "system", "content": f"{SYSTEM}"},
            {"role": "user", "content": "Question: {}".format(question)}]

prompt = tokenizer.apply_chat_template(template, tokenize=False, add_generation_prompt=False)

# First try
result_1= llm.invoke(prompt) # <-- Does not stop at [END] here. Includes it into the result.
print(f"Res 1 is: {result_1}")

# Second try
result_2= self.llm.invoke(prompt, stop=["[END]"]) # <-- Stops at [END]. Does not include it into the result.
print(f"Res 2 is: {result_2}")

Error Message and Stack Trace (if applicable)
No response
Description
The stop parameter in VLLM class does not affect the LLMs output generation.
I want the LLM to stop generating output after reaching the "[END]" sequence and not include this sequence into the output.
I've initialized the VLLM instance as per docs and set the stop sequence.
Then, I've tried to invoke the LLM with no additional params. And it DID NOT stop at the desired sequence and INCLUDED it into the output.
Then, I've invoked the LLM passing the stop explicitly. And this time it STOPPED after the desired sequence and DID NOT include it into the output.
I guess the reason is that at this line even if stop is within the _default_params, it gets overwritten to None if stop was not passed to the _generate method. So, basically, my stop sequence gets replaced with None.
The similar issue was reported in #22717 but no fix was done.
System Info
System Information
------------------
> OS:  Linux
> OS Version:  #40~22.04.3-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 30 17:30:19 UTC 2
> Python Version:  3.10.12 (main, Sep 11 2024, 15:47:36) [GCC 11.4.0]

Package Information
-------------------
> langchain_core: 0.2.29
> langchain: 0.2.12
> langchain_community: 0.2.11
> langsmith: 0.1.125
> langchain_text_splitters: 0.2.2

Optional packages not installed
-------------------------------
> langgraph
> langserve

Other Dependencies
------------------
> aiohttp: 3.10.5
> async-timeout: 4.0.3
> dataclasses-json: 0.6.7
> httpx: 0.27.0
> jsonpatch: 1.33
> numpy: 1.26.4
> orjson: 3.10.7
> packaging: 24.1
> pydantic: 2.9.2
> PyYAML: 6.0.2
> requests: 2.32.3
> SQLAlchemy: 2.0.35
> tenacity: 8.5.0
> typing-extensions: 4.12.2

Hey we're a group of students from University of Toronto and we can take a look into this.


⚠ Bofrost.be has degraded performance

In 5f65076, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1300 ms

Resolved: Bofrost.be performance has improved in d5dd26d after 6 minutes.


GET http://dsnfof.herokuapp.com/api/author/{author_uuid}/posts to remote servers

http://dsnfof.herokuapp.com/api/author/{author_uuid}/posts

[Note] Redundant for now.


Doesn't sound and crashes after unpligging the headphones

On Windows 10, when using the version downloaded from itch.io .
When I unplug the headphones, the OS automatically selects my screen speakers as the audio output device. RFXGen is still working, but not a sound will play.
If I try to close the application then, it will freeze, forcing me to kill it from the Task Manager.

That issue is related to audio context lost after device initialization. Audio devices are managed with OpenAL Soft... need to investigate it but doesn't seem to be an easy solution...

It depends on audio system, should be ok on latest release.

how to fix this problem?
I exp same problem.

Hi @Shufel, are you using latest rfxgen from itch.io?
What are your system specs (CPU, GPU, OS)?

Thanks to reply.
I solved this problem.
just my version is old. lol


ProxySsn con_id refactor

refactor all ProxySession to use the connection id logic and variable.

Should we call this Connection ID or Session ID?

Should we call this Connection ID or Session ID?

I'm not 100% sure but we may want to call it Session ID. On HTTP/1,2,3 sessions we can use Connection ID as Session ID, but in the future, a session might be resumed on a different connection, or another session might be started on the same connection.

Looks good to me aside from Bryan's comment about making the member variable private (or at least protected).

Should we call this Connection ID or Session ID?

I'm not 100% sure but we may want to call it Session ID. On HTTP/1,2,3 sessions we can use Connection ID as Session ID, but in the future, a session might be resumed on a different connection, or another session might be started on the same connection.

Even in that future scenario, we would need a Connection ID and a Session ID, right? So I think that confirms we should change this Session ID. I was also considering just ProxySession::id.

Even in that future scenario, we would need a Connection ID and a Session ID, right? So I think that confirms we should change this Session ID. I was also considering just ProxySession::id.

Yeah, ProxySession::id is fine with me.

Renamed to ProxySession::_id.
Renamed external references to ssn_id.

[approve ci]

[approve ci autest]

[approve ci autest]


Celery error when creating main VM

Hello,
I tried to recreate the main VM this morning and I got the following error:

TASK [celery : Start celery service] *******************************************
task path: /Users/felixveysseyre/.../HPCCloud-deploy/ansible/roles/celery/tasks/main.yml:13
fatal: [hpccloud-vm]: FAILED! => {"changed": false, "failed": true, "msg": "Traceback (most recent call last):\n  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main\n    "main", fname, loader, pkg_name)\n  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code\n    exec code in run_globals\n  File "/usr/local/lib/python2.7/dist-packages/celery/main.py", line 18, in \n    main()\n  File "/usr/local/lib/python2.7/dist-packages/celery/main.py", line 14, in main\n    _main()\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/celery.py", line 326, in main\n    cmd.execute_from_commandline(argv)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/celery.py", line 488, in execute_from_commandline\n    super(CeleryCommand, self).execute_from_commandline(argv)))\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 279, in execute_from_commandline\n    argv = self.setup_app_from_commandline(argv)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 481, in setup_app_from_commandline\n    self.app = self.find_app(app)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 503, in find_app\n    return find_app(app, symbol_by_name=self.symbol_by_name)\n  File "/usr/local/lib/python2.7/dist-packages/celery/app/utils.py", line 374, in find_app\n    symbol_by_name=symbol_by_name, imp=imp,\n  File "/usr/local/lib/python2.7/dist-packages/celery/app/utils.py", line 358, in find_app\n    sym = imp(app)\n  File "/usr/local/lib/python2.7/dist-packages/celery/utils/imports.py", line 101, in import_from_cwd\n    return imp(module, package=package)\n  File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module\n    import(name)\n  File "/opt/hpccloud/cumulus/cumulus/celery/init.py", line 22, in \n    from celery.datastructures import force_mapping\nImportError: No module named datastructures\nTraceback (most recent call last):\n  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main\n    "main", fname, loader, pkg_name)\n  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code\n    exec code in run_globals\n  File "/usr/local/lib/python2.7/dist-packages/celery/main.py", line 18, in \n    main()\n  File "/usr/local/lib/python2.7/dist-packages/celery/main.py", line 14, in main\n    _main()\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/celery.py", line 326, in main\n    cmd.execute_from_commandline(argv)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/celery.py", line 488, in execute_from_commandline\n    super(CeleryCommand, self).execute_from_commandline(argv)))\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 279, in execute_from_commandline\n    argv = self.setup_app_from_commandline(argv)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 481, in setup_app_from_commandline\n    self.app = self.find_app(app)\n  File "/usr/local/lib/python2.7/dist-packages/celery/bin/base.py", line 503, in find_app\n    return find_app(app, symbol_by_name=self.symbol_by_name)\n  File "/usr/local/lib/python2.7/dist-packages/celery/app/utils.py", line 374, in find_app\n    symbol_by_name=symbol_by_name, imp=imp,\n  File "/usr/local/lib/python2.7/dist-packages/celery/app/utils.py", line 358, in find_app\n    sym = imp(app)\n  File "/usr/local/lib/python2.7/dist-packages/celery/utils/imports.py", line 101, in import_from_cwd\n    return imp(module, package=package)\n  File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module\n    import(name)\n  File "/opt/hpccloud/cumulus/cumulus/celery/init.py", line 22, in \n    from celery.datastructures import force_mapping\nImportError: No module named datastructures\n"}

It seems that we are not able to import the datastructures from celery.
Thanks !

@felixveysseyre Can you run the following inside the failing vm and paste the result, thanks.
python
import celery
celery.__version__


Create hatchet tutorial materials

Topic ideas:

Graphframe, graph, and dataframe data structure
Reading in a dataset
Operations on graphframe, graph, dataframe
Pandas internal dataframe operations
Visualizing graph
Example analyses on graphframe, graph, and dataframe

Identify load imbalance
Compare multiple executions (single vs multi-core, multiple trials of same experiment)
Filter by library
Identify scaling bottlenecks
Compare across function implementations or hardware

Basic tutorial has been merged: 9b03fad


[spdlog] Update to 1.8.5

Describe the pull request

What does your PR fix? Upgrade spdlog to 1.8.5

Which triplets are supported/not supported? Have you updated the CI baseline?
Same triplets as before.

Does your PR follow the maintainer guide?
Yes.

@iko1, we have exist PR https://github.com/microsoft/vcpkg/pull/16870 to upgrade spdlog to 1.8.5. So close this PR.

This also contains changes related to #16273


adding the role that can be assumed during integration test

Review requested

@sdomme can you check this out please? I am not sure if `AWS: Ref: `` works via cfn-sphere.

I'm currently testing it out. The disadvantage is, user have to remove the extra role configuration, if they did not use the integration test. Otherwise they get a dummy role (maybe a security issue).
@esc Could it be a better idea to have a separate template which supports integration test environment?

Sounds good.
On 23 November 2015 10:46:27 CET, Sergej Domme<EMAIL_ADDRESS>wrote:

I'm currently testing it out. The disadvantage is, user have to remove
the extra role configuration, if they did not use the integration test.
Otherwise they get a dummy role (maybe a security issue).
@esc Could it be a better idea to have a separate template which
supports integration test environment?

Reply to this email directly or view it on GitHub:
https://github.com/ImmobilienScout24/crassus/pull/4#issuecomment-158889607

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I fixed the integration-test template, so it works with cfn-sphere now.
Also I split the template and configuration in a default and integration-test version, so user can decide which one to use to fit their requirements. (We need to deploy the integration-test one)
@esc review for review required :-)


[v2] auto configure from environment variables

Related #107 #105

PUBLIC_CLOUDINARY_CLOUD_NAME
PUBLIC_CLOUDINARY_API_KEY
PUBLIC_CLOUDINARY_PRIVATE_CDN
PUBLIC_CLOUDINARY_SECURE_DISTRIBUTION
PUBLIC_CLOUDINARY_UPLOAD_PRESET

Will be released in https://github.com/cloudinary-community/svelte-cloudinary/pull/112

nvm my testing wasn't quite accurate so reopening this


loading progress circle does not apply the theme color from local storage

I have implemented FluentDesignTheme with Blazor WASM and it's working fine, except for one thing: the app progress circle defined in app.css (svg class="loading-progress"> in index.html) is always displayed in the blue color even if the theme is set to Excel or Powerpoint. Does anyone know how to let the loading progress circle use the theme color from local storage ?

The css variables needed are not yet known at that time so they can't be used to style that ring.
If you know you are going to use Excel or PowerPoint accent color, you can hard code that value in the class you mentioned.


Switch to a newer version of HikariCP

We have a project with spring boot 2.1.4 and are using quartz 2.3.1. I wanted to switch our project to spring-boot-actuator/micrometer but ran into https://github.com/spring-projects/spring-boot/issues/16656 : Spring Boot Acuator needs a newer Hikari than the one Quartz uses (com.zaxxer:HikariCP-java7); Spring Boot uses com.zaxxer:HikariCP:3.2.0
Please update your depedency.

@snicoli So this will be fixed in 2.1.5?

If you take the time to follow the link I already gave, you can see yourself the PR was merged in 2.1.5

I'm using latest springboot 2.3.2, and have the same issue mentioned above and also in
https://github.com/spring-projects/spring-boot/issues/16489
With springboot 2.3.1 , I didn't get this error.
As a woraround I added to my dependency:
    implementation ('org.springframework.boot:spring-boot-starter-quartz') {
        exclude group: 'com.zaxxer', module: 'HikariCP-java7'
        // workaround for https://github.com/spring-projects/spring-boot/issues/16489
    }

Before this exclusion, I had the following dependencies:
+--- org.springframework.boot:spring-boot-starter-quartz -> 2.3.2.RELEASE
|    +--- org.springframework.boot:spring-boot-starter:2.3.2.RELEASE ()
|    +--- org.springframework:spring-context-support:5.2.8.RELEASE ()
|    +--- org.springframework:spring-tx:5.2.8.RELEASE (*)
|    --- org.quartz-scheduler:quartz:2.3.2
|         +--- com.mchange:mchange-commons-java:0.2.15
|         +--- com.zaxxer:HikariCP-java7:2.4.13
|         |    --- org.slf4j:slf4j-api:1.7.21 -> 1.7.30
|         --- org.slf4j:slf4j-api:1.7.7 -> 1.7.30
I'm not sure if that is an issue related to Quartz or to SpringBoot...

I'm not sure if that is an issue related to Quartz or to SpringBoot...

Not related to Quartz so please ignore this. This is taken care on our side, more info: https://github.com/spring-projects/spring-boot/issues/16489#issuecomment-664872466


[BugFix] Fix bug submit statement should show info

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #StarRocks/StarRocksTest#1175
Problem Summary(Required) ：

This bug was introduced in #11344, because After refactoring, I forgot to do special treatment to submit. Because submit is a special syntax, it is equivalent to create+execute, so it is easy to be ignored, so add a single test to avoid such problems in the early stage.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 1 / 3 (33.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/DDLStmtExecutor.java
1
3
33.33%
[729, 730]

run starrocks_admit_test


Pursuit move handling doesn't account for self-faint

Sample log:
|-activate|p1a: Swampert|move: Pursuit
|move|p2a: Scizor|Pursuit|p1a: Swampert|[from]Pursuit
|-damage|p1a: Swampert|210/291
|-damage|p2a: Scizor|0 fnt|[from] item: Life Orb
|switch|p1a: Bellossom|Bellossom, L88, F|97/275
|faint|p2a: Scizor
|
|-weather|SunnyDay|[upkeep]
|upkeep
...
Battle: p1: error: Error: Pokemon [them] haven't fainted yet

Add a flag interceptSwitch?: true to the UseMove BattleEvent to handle the [from]Pursuit suffix so that the useMove.ts parser knows when to yield back to the expectSwitch() parser (or a version of it that doesn't include intercept handling) in switchIn.ts and when to finish handling the move after the switch (e.g. handling faint messages).

Seems to be erroneous, can no longer reproduce.


Push notifications only working on local server not on AWS Problem with server URL?

When I put my app on AWS I replace the server url into the index.js. I have two apps going to one server but push notifications only works on a local server that has the same apps running on it. Here is what I have for the index.js.
api = new ParseServer({
 databaseURI: databaseUri || 'mongodb://url',//my url
 cloud:  __dirname + '/cloud/main.js',
 appId: 'Appid',
 masterKey: 'MasterKey', //Add your master key here. Keep it secret!
 serverURL: 'http://awsUrl/parse',  // Don't forget to change to https if needed
push: {
ios: {
pfx: 'Certificates.p12', // The filename of private key and certificate in PFX or PKCS12 format from disk
                         // cert: '', // If not using the .p12 format, the path to the certificate PEM to load from disk
                         // key: '', // If not using the .p12 format, the path to the private key PEM to load from disk
                         bundleId: 'com.3B.App', // The bundle identifier associate with your app
                         production: true // Specifies which environment to connect to: Production (if true) or Sandbox
                         }
                         },

                           // if the account lockout policy is set and there are more than `threshold` number of failed login attempts then the `login` api call returns error code `Parse.Error.OBJECT_NOT_FOUND` with error message `Your account is locked due to multiple failed login attempts. Please try again after <duration> minute(s)`. After `duration` minutes of no login attempts, the application will allow the user to try login again.
 accountLockout: {
   duration: 10, // duration policy setting determines the number of minutes that a locked-out account remains locked out before automatically becoming unlocked. Set it to a value greater than 0 and less than 100000.
   threshold: 30, // threshold policy setting determines the number of failed sign-in attempts that will cause a user account to be locked. Set it to an integer value greater than 0 and less than 1000.
 }

});
api2 = new ParseServer({
 databaseURI: databaseUri || 'mongodb://url',//my url
 cloud:  __dirname + '/cloud/main2.js',
 appId: 'AppId',
 masterKey: 'MasterKey', //Add your master key here. Keep it secret!
 serverURL: 'http://awsUrl/parse2',  // Don't forget to change to https if needed
push: {
ios: {
pfx: 'Certificates2.p12', // The filename of private key and certificate in PFX or PKCS12 format from disk
                         // cert: '', // If not using the .p12 format, the path to the certificate PEM to load from disk
                         // key: '', // If not using the .p12 format, the path to the private key PEM to load from disk
                         bundleId: 'com.3B.App', // The bundle identifier associate with your app
                         production: true // Specifies which environment to connect to: Production (if true) or Sandbox
                         }
                         },

                           // if the account lockout policy is set and there are more than `threshold` number of failed login attempts then the `login` api call returns error code `Parse.Error.OBJECT_NOT_FOUND` with error message `Your account is locked due to multiple failed login attempts. Please try again after <duration> minute(s)`. After `duration` minutes of no login attempts, the application will allow the user to try login again.
 accountLockout: {
   duration: 10, // duration policy setting determines the number of minutes that a locked-out account remains locked out before automatically becoming unlocked. Set it to a value greater than 0 and less than 100000.
   threshold: 30, // threshold policy setting determines the number of failed sign-in attempts that will cause a user account to be locked. Set it to an integer value greater than 0 and less than 1000.
 }

});
var mountPath = '/parse';
app.use(mountPath, api);

var mountPath2 = '/parse2';
app.use(mountPath2, api2);

The url and app id I put in my app and it works fine on both apps. Here is what I have in my could code.
Parse.Cloud.define("PushNotification", function(request, response) {
  console.log('sending push');

//tried this does not work.
//Parse.serverURL = 'http:/URL/parse';

 var queryInstallation = new Parse.Query(Parse.Installation);

                   Parse.Push.send({
                                   useMasterKey: true,
                                   where: queryInstallation,

                                   data: {
                                   alert: request.params.Message,
                                   badge: 0,
                                   sound: 'default'
                                   }
                                   }, {
                                   useMasterKey: true,
                                   success: function() {
                                   // Push sent!
                                   console.log('Push sent');
                                   response.success('success');

                                   },
error: function(error){
console.error(error);
response.error('Error push not sent ' + error);

                                   }

                                   });

});

It does not give off a error message it just has success. If there is any other information that I should be giving please let me know.

fyi, notifications work for us on aws.
In our config we use localhost for the server url in our production config.  I wish i could remember why off the top of my head if it comes back to me the rational, I'll add it here, but i suggest you try it.  We're running on a non standard port (so don't just copy and paste) our elb that front ends handles the https so we the url is just http....
serverURL: 'http://localhost:9091/parse',

Ok thanks


rustic.toml: dry-run not respected, but silently ignored

My rustic.toml has this part in it:
[...]

[forget]
dry-run = true
keep-hourly = 24
keep-daily = 30
keep-weekly = 52
keep-monthly = 60

[backup]

[...]

I ran rustic forget on the command line and expected it to use the --dry-run flag, but it didn't. Snapshots were removed. Is this flag not supported in a config file, or did I use it incorrectly?

The dry-run flag is actually not supported. I found it a bit counter-intuitive to put dry-run into a config file which I would suppose is a configuration for the every-day use. I'd rather put the forget retention options into the config file and run rustic forget -n - that's why it's not supported currently. But it can be added of course.
A problem is  that there is no error if you specify some wrong or unsupported options in the config file. I'll think about how to add this...

The dry-run flag is actually not supported. I found it a bit counter-intuitive to put dry-run into a config file which I would suppose is a configuration for the every-day use. I'd rather put the forget retention options into the config file and run rustic forget -n - that's why it's not supported currently. But it can be added of course.

I don't know if it would make sense for someone. I wanted to test some settings for cronjobs and expected all command line flags to be supported by the configuration file.

A problem is that there is no error if you specify some wrong or unsupported options in the config file. I'll think about how to add this...

Printing a warning for unsupported options (or typos!) would definitely be a plus!

I would like to keep the dry run behavior for now as it is, as I'm just thinking about putting it into the general options in the future and that would make a configuration file migration necessary - so I'd like to better prevent this.
But I've just added #462 which should fix the problem that you don't get feedback if a field in the TOML is not supported.

Awesome, thanks for the fast fix!


capture group not supported; use '(?:' instead of '('

Describe the bug
[rdlugyhe@rdlugyhe-thinkpadt14sgen2i rhbq-quarkus]$ vale sync
 SUCCESS  Downloaded package 'RedHat'
 SUCCESS  Downloaded package 'AsciiDoc'
Downloading packages [2/2] █████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 100% | 1s
[rdlugyhe@rdlugyhe-thinkpadt14sgen2i rhbq-quarkus]$ vale modules/proc_updating-quarkus.adoc
E201 Invalid value [/home/rdlugyhe/gitlab/rhbq-quarkus/.vale/styles/RedHat/TermsErrors.yml:22:4]:

  21    "(?<!self-)hosted engine|hosted-engine": self-hosted engine
  22*   "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal$1
  23    "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| instance?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal
  24    "[bB]asic [aA]uth": Basic HTTP authentication|Basic authentication

capture group not supported; use '(?:' instead of '('

Execution stopped with code 1.
[rdlugyhe@rdlugyhe-thinkpadt14sgen2i rhbq-quarkus]$

Examples:

This word or expression triggers an illegitimate vale alert.
This word or expression triggers an ambiguous vale alert.

To Reproduce
Steps to reproduce the behavior:

Add this word or expression:
Vale reports an illegitimate alert: error, warning, suggestion.

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context here.

@rolfedh the solution to this is to update your version of Vale to 3.7+

I guess we should document this dependency on Vale 3.7+

Thank you for reviewing and this issue and updating the documentation so quickly! You've successfully documented this dependency. I can't reproduce the issue with Vale 3.7+, so I'm closing this.


TestNG 7.4.0 throws an exception "The version of TestNG used does not support setting config failure policy to 'continue'"

TestNG Version 7.4.0

Note: only the latest version is supported

Expected behavior
Configfailurepolicy is configured as "continue" and tests should pass when run
Actual behavior
Error appears: The version of TestNG used does not support setting config failure policy to 'continue'.
Is the issue reproductible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[X] IntelliJ
[ ] NetBeans

Test case sample

Please, share the test case (as small as possible) which shows the issue
https://github.com/AsDmitrij/Continue.git

@AsDmitrij - This is a compatibility problem that Gradle is having with TestNG. I think you need to take this up with Gradle than with TestNG because Gradle is still referring to a method that was removed. Closing this issue since there's nothing to be done from TestNG side.
Here's the stacktrace when you run
./gradlew clean test --stacktrace

        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
Caused by: java.lang.NoSuchMethodException: org.testng.TestNG.setConfigFailurePolicy(java.lang.String)
        at org.gradle.api.internal.tasks.testing.testng.TestNGTestFramework.verifyMethodExists(TestNGTestFramework.java:108)
        ... 104 more

@krmahadevan I see that you already opened a Gradle issue related to this problem back in 2019. However, the issue has been ignored by the Gradle team and closed by the stale bot.
I assume that the Gradle team didn't fix it because Gradle uses reflection to call the setConfigFailurePolicy method. Having to choose the right method to call (depending on the TestNG version) and calling via reflection a method with a FailurePolicy parameter would make the code ugly. While this is no excuse for Gradle to let the bug unfixed, it would be nice if in this case TestNG would get rid of the problem by adding to TestNG.java a setConfigFailurePolicy convenience  method with the same signature as in older releases:
  public void setConfigFailurePolicy(String failurePolicy) {
    m_configFailurePolicy = XmlSuite.FailurePolicy.getValidPolicy(failurePolicy);
  }

What do you think?

@siordache No need to add a method for that. For integration projects like gradle, we already manage api changes via testng-team/testng-remote

Thanks, @juherr. I'm not familiar with testng-remote. Can you please explain how should one use it in order to get rid of the NoSuchMethodException when executing ./gradlew clean test?

@siordache testng-remote is our project that deals with the API changes. testng-eclipse uses it. It could be an option if we add setConfigFailurePolicy support and gradle integrates it.
I've no idea why gradle doesn't upgrade its usage of TestNG api.

Ok. thanks! I passed this information to the Gradle team.

@siordache - As a workaround, we can use the IAlterSuiteListener and override the alter method to set the configFailureAPolicy to continue suite.setConfigFailurePolicy(XmlSuite.FailurePolicy.CONTINUE) . I faced the same issue as you've mentioned and had to resort to this in order to continue.


Sort  "Product List" by amount of Vulnerabilities

Is your feature request related to a problem? Please describe
There might be "products" with many open vulnerabilities, I'd like to address those on a different level.
Describe the solution you'd like
As a user I'd like to sort the "Product List" by the amount of open vulnerabilities. The data is already shown in the table, but the table could not be sorted.
Describe alternatives you've considered
None.
Additional context

https://defectdojo.herokuapp.com/product

This might be solved by my Pull Request #1586
If it doesn't do what you expect when it's merged, let me know and I can tackle this

This is totally solved by #1586. Thanks for killing the fourth bird with a single stone!


[response needed] Update Category.php

Allows adding category images through REST API

Dear Contributor,
Thank you for your contribution to Shopware. We value your engagement.
Unfortunately we have to close all existing Pull Requests.
This is due to the new Shopware 5 Major Release and a restructuring of the branch names.
If your contribution is still relevant for Shopware 5, a new pull request is highly appreciated.
We are very sorry for this inconvenience.
Greetings from the Shopware Team.


Upgrade to the latest Kubernetes Client

Upgrade to the latest version of the kubernetes-client library and disable auto configuration.
Fixes: https://github.com/gocd/kubernetes-elastic-agents/issues/347

Thanks for this, will take a look. I'd been meaning to take a look at the client upgrade (I'd already done it on the sister kubernetes-secrets plugin but there was something in the changelog here that concerned me for some reason. Will take a look at your changes and try and recollect 😅

Thanks, made a couple of minor tweaks, but this seems to be working fine.

https://github.com/gocd/kubernetes-elastic-agents/releases/tag/v3.9.0-420

Thanks very much @chadlwilson!

FYI, the underlying bug in the client with auto config and automatic token refresh is fixed now, and I've intentionally re-enabled this to reduce config needs if the plugin in many cases in #386 - should have no effect on most folks, but if you want to give it a go it'd be appreciated.

Hey Chad, thanks for the heads up, sure we can give it a go shortly 👍

If youre interested in how they fixed the underlying bug you worked around, they introduced autoOauthToken independent of oauthToken so that any autorefeshed token from a provider or auto configuration would never be able to override a hard set token from the user.

FYI, the underlying bug in the client with auto config and automatic token refresh is fixed now, and I've intentionally re-enabled this to reduce config needs of the plugin in many cases in #386 - should have no effect on most folks, but if you want to give it a go it'd be appreciated.

I can confirm that kubernetes-elastic-agent 4.0.0-505 works well with no credential issues on GoCD 23.5.0.  Thanks all.


Example does not work

Something with "gridsize" is wrong:
> library(randomForest)
randomForest 4.6-12
Type rfNews() to see new features/changes/bug fixes.
> library(edarf)
>
> data(iris)
> data(swiss)
>
> ## classification
> fit <- randomForest(Species ~ ., iris)
> pd <- partial_dependence(fit, iris, c("Petal.Width", "Sepal.Length"))
Fehler in ifelse(gridsize >= nunique, nunique, gridsize) :
  Objekt 'gridsize' nicht gefunden
> pd_int <- partial_dependence(fit, iris, c("Petal.Width", "Sepal.Length"), interaction = TRUE)
Fehler in ifelse(gridsize >= nunique, nunique, gridsize) :
  Objekt 'gridsize' nicht gefunden
>
> ## Regression
> fit <- randomForest(Fertility ~ ., swiss)
> pd <- partial_dependence(fit, swiss, "Education")
Fehler in ifelse(gridsize >= nunique, nunique, gridsize) :
  Objekt 'gridsize' nicht gefunden
> pd_int <- partial_dependence(fit, swiss, c("Education", "Catholic"), interaction = TRUE)
Fehler in ifelse(gridsize >= nunique, nunique, gridsize) :
  Objekt 'gridsize' nicht gefunden

should be fixed now. i am not sure why travis didn't catch this, as it failed a local check. will look at the logs and figure that out. passed locally though.

travis config was messed up. fixed and don't think it will happen again.


Replace Travis with GitHub actions ?

Found this repository with GitHub actions for Maven after a quick search.  Might have to create something ourselves to use the Maven wrapper we have here in the Javalin repository.

Thanks a lot for looking into this @Playacem. Are you able to make a pull request for an action setup?

Sadly I am not in the GitHub actions beta yet, so I can't make a pull request. Will do a pull request when I have access and some time next week.

Great, looking forward to it!


kubernetes example

First pass at a Kubernetes example
Depends on https://github.com/dagger/dagger/pull/536

/cc @TomChv

I worry that our examples are inconsistent: voteapp and helloapp are names of apps, not specific to a particular infrastructure provider or use case, and have no companion guide. This app, in contrast, is named after a use case, and includes a detailed guide. Both are valid, but to have both together in the same repo is weird.

Agree about the detailed guide -- this is more of a scratch pad to prepare content for the docs.
I was under the impression that short term goal would be to move dagger/dagger/examples to dagger/examples, as it's weird to have two different places for examples (what goes into one vs the other? do we test them with a different infrastructure?).
Everything in dagger/dagger/examples is named after infrastructure providers and/or use cases: jamstack, kubernetes-app, kubernetes-aws, react, simple-s3 so we already have inconsistency that needs to be addressed.
I thought we could have a couple of "named apps" as generic tutorials (hello, vote) that showcase multi-provider examples, and then a long series of per stack/use-case examples. Otherwise we'll end up with a long list of not so meaningful names (e.g. todoapp would be the react+netlify example, next to hellogo, voteapp, helloapp) which I don't think make navigation/discovery easy. Plus, we might re-use the same app for multiple use cases, in different examples (e.g. "todoapp" might be used both in netlify and s3).
WDYT?

I was under the impression that short term goal would be to move dagger/dagger/examples to dagger/examples, as it's weird to have two different places for examples (what goes into one vs the other? do we test them with a different infrastructure?).

Yes it’s weird to have 2 places for examples. But it’s not a good idea to combine them, because they are very different.

The new examples are actual example apps: they show what using Dagger actually looks like in the context of a realistic project.

The original examples are mini-guides with lots of example code, and very little text. They can be used as a starting point for adding guides to the docs.

My suggestion is to remove the original examples in the short term, to avoid confusion, and gradually re-incorporate some of their contents in the docs.

Everything in dagger/dagger/examples is named after infrastructure providers and/or use cases: jamstack, kubernetes-app, kubernetes-aws, react, simple-s3 so we already have inconsistency that needs to be addressed.

Correct, incorporating original examples (mini-guides, really) into the new examples repo would create inconsistency. Which is why we shouldn’t incorporate them.

I thought we could have a couple of "named apps" as generic tutorials (hello, vote) that showcase multi-provider examples, and then a long series of per stack/use-case examples. Otherwise we'll end up with a long list of not so meaningful names (e.g. todoapp would be the react+netlify example, next to hellogo, voteapp, helloapp) which I don't think make navigation/discovery easy. Plus, we might re-use the same app for multiple use cases, in different examples (e.g. "todoapp" might be used both in netlify and s3).

So far we have 3 actual example apps:

Helloapp (static web page that says hello)
Voteapp (Docker’s voting app)
Hellogo (Sam’s Go web application that says hello)

These examples don’t need to map 1-to-1 to use cases and guides. How they map exactly is TBD, suggestions are welcome. We can also adjust the number of apps: if 3 is too many, we can remove one. If it’s not enough, we can add more.
The important point is that example apps are not guides or use cases.

These examples don’t need to map 1-to-1 to use cases and guides. How they map exactly is TBD, suggestions are welcome. We can also adjust the number of apps: if 3 is too many, we can remove one. If it’s not enough, we can add more.
The important point is that example apps are not guides or use cases.

I see -- so you envision dagger/examples to contain just sample applications, not use case examples.
In that case, where do we stash specific examples of use cases?
Basically something like this:
https://github.com/pulumi/examples/tree/master/kubernetes-ts-nginx
Or this:
https://github.com/hashicorp/waypoint-examples/tree/main/gcp/google-cloud-run/nodejs
With this approach (it's a sample app not specific to a particular use case), it doesn't make sense for me to include the kubernetes plan in examples/hellogo at all -- that same app can be deployed on Kubernetes, ECS, Cloud Run, Lambda and others, why only include a Kubernetes plan. Unless the plan supports every single deployment platform dagger supports, but that's not a realistic example and makes it much harder to comprehend.

I see -- so you envision dagger/examples to contain just sample applications, not use case examples.

I was picturing a hybrid: sample applications with pre-configured Dagger environments illustrating real-world uses of Dagger.

In that case, where do we stash specific examples of use cases?
Basically something like this:
https://github.com/pulumi/examples/tree/master/kubernetes-ts-nginx
Or this:
https://github.com/hashicorp/waypoint-examples/tree/main/gcp/google-cloud-run/nodejs

Good question, I agree it would be simplest if we could just follow the same pattern as Pulumi and Waypoint. But I think that we need a slightly different structure, because Dagger works differently. Specifically: 1) it’s very flexible, and 2) it’s embedded in an application (via gitflow). The combination of these two things make it harder to map tutorials to example apps 1-1.

Waypoint is embedded in an application, but it’s not very flexible. There is only one use case for Waypoint: “deploy stateless application in language X to platform Y”. For each value of X and Y, there is a tutorial and a corresponding example app, which are useful standalone.

Pulumi is very flexible, but it is not embedded in an application. Therefore, even though you can do many different things with Pulumi, it’s always in the context of a standalone Pulumi project. For example, “provision an S3 bucket and upload a file to it” makes sense as a standalone Pulumi example, because that’s how infrastructure engineers will use it. But it doesn’t make sense as a standalone Dagger example, because a realistic Dagger+S3 integration needs to take place in the context of an application (again, because of gitflow).

With this approach (it's a sample app not specific to a particular use case), it doesn't make sense for me to include the kubernetes plan in examples/hellogo at all -- that same app can be deployed on Kubernetes, ECS, Cloud Run, Lambda and others, why only include a Kubernetes plan. Unless the plan supports every single deployment platform dagger supports, but that's not a realistic example and makes it much harder to comprehend.

What is missing is a system to map multiple tutorials to one example app. So each tutorial can show you how to add a cool feature to your example. Maybe each tutorial adds a new dagger environment; or each tutorial adds content to a base dagger environment; I’m not sure. But I think this would be a better fit.
I hope this helps clarify my thinking.


Problem with Amazon Login

Everything seems to load and run without error but when I click Okay of the Amazon screen which provides connectivity to Alexa
When you click "Okay", we'll provide AlexaPi3:
Connectivity to Alexa so that you can interact with it using your voice.
I get the following error and nothing seems to help.
We're sorry!
An error occurred when we tried to process your request. Rest assured, we're already working on the problem and expect to resolve it shortly.
Go to Amazon.com's Home Page

After reviewing issue 12 I corrected the product if in creds.py and everything worked.

Yeah the ProductID catches a lot of people out (me included), will try and make sure the docs are improved in future versions :)


Spec: Define behavior when invalid ParticipantStatus is returned from participant methods

As we currently have as per Participant State Model two separate paths for LRA execution success - Complete and error - Compensate we have a duplicated states for every possible outcome depending on whether LRA is closing or cancelling. But this statuses are returned by end users so the specification should probably guard against potential errors. Consider for instance examples:
https://gist.github.com/xstefank/79a346f0ae988895684790d5a4d6db94
or something more probable:
https://gist.github.com/xstefank/6dc7ab62511a51a2cbecdcaaedd73ad3
My concern is that these situations should be handled in unified way so not that one implementation throws exception and other secretly transform state to its correct variant. Another option would be to model ParticipantStatus with only one state model (Finished, Finishing, FailedToFinish or similar).

There is already a note about this in the spec and it is also covered in the state model but the decision made at this morning's hangout is to add more text.
But note that the spec does cover the situation and it says the situation MUST be logged. Also note that we cannot write a TCK test for this since there is no API for obtaining the final status of compensators and LRAs. Each implementation should have their own private test to validate that the final states are correct (so in the first gist example the final state of the LRA which was asked to close would be FailedToClose)

I will add some text that just describes that invalid outcome must be logged and that it maps to FailedTo* states.


How do I stop form elements that are not visible from being validated?

I have a form with two parts, each inside a div.
I show and hide these divs based on a drop down.
How do I stop the form items inside the hidden div from being validated?
Or is there a better way for me to create this dynamic form?
Thanks,
Ben

Hi Team
I have been struggling with this for a while
In a nutshell All i have been trying to achieve is to  validate a select field with jqBootstrapValidation.
This is my html code below

1
2
3

Send Message

--
And this is the start of my javascript
$(function() {
$("#contactForm input,#contactForm textarea,#contactForm select").jqBootstrapValidation({
preventSubmit: true,
submitError: function($form, event, errors) {
// additional error messages or events
},
But i cant  get the  select fields to  validate
Please help with this

Hi @ReactiveRaven @cleentfaar
I am sure this is going to be very very simple for a Guru like you
In a nutshell All i have been trying to achieve is to  validate a select field with jqBootstrapValidation.
This is my html code below

                   <select class="form-control" id="choice" name="choice" required="required"  data-validation-required-message="Please Choose.">                     <option value="" disabled="disabled"></option>                     <option value="1">1</option>                     <option value="2">2</option>                     <option value="3">3</option>                  </select>

Here is my javascript
`$(function() {
$("#contactForm input,#contactForm textarea,#contactForm select").jqBootstrapValidation({
preventSubmit: true,
submitError: function($form, event, errors) {
// additional error messages or events
},`
So far i have not been able to get the select fields to validate as input and textarea
Any help will be appreciated here
Thanks


feat: add crvSUSD and crvLINK v1 to migration

Found address 0xC25a3A3b969415c80451098fa907EC722572917F in files app/containers/Vaults/migrationWhitelist.json. This address is from token crvPlain3andSUSD
Found address 0x5533ed0a3b83F70c3c4a1f69Ef5546D3D4713E44 in files app/containers/Vaults/migrationWhitelist.json. This address is from vault yvcrvPlain3andSUSD
Found address 0x5a770DbD3Ee6bAF2802D29a901Ef11501C44797A in files app/containers/Vaults/migrationWhitelist.json. This address is from vault yvCurve-sUSD
Found address 0xcee60cFa923170e4f8204AE08B4fA6A3F5656F3a in files app/containers/Vaults/migrationWhitelist.json. This address is from token linkCRV
Found address 0x96Ea6AF74Af09522fCB4c28C269C26F59a31ced6 in files app/containers/Vaults/migrationWhitelist.json. This address is from vault yvlinkCRV
Found address 0xf2db9a7c0ACd427A680D640F02d90f6186E71725 in files app/containers/Vaults/migrationWhitelist.json. This address is from vault yvCurve-LINK

Updated the custom order json to also contain the new vaults, looks good to me


List of input variables

For what I am doing, it would be useful if a Hist was able to return the list of basic variables used in all its axis expressions.
For example
Hist(bin("sqrt(x**2 + y**2)", 5, 0, 1), bin("arctan2(y, x)", 3, -math.pi, math.pi))

would return the list ["x", "y"]

>>> h = Hist(bin("sqrt(x**2 + y**2)", 5, 0, 1), bin("arctan2(y, x)", 3, -math.pi, math.pi))
>>> h.fields
['x', 'y']

That was quick :)


Update mkldnn link and fix syntaxwarning

Hi there,
In this PR, there are two tiny changes.

Update the link of MKLDNN
The new link of MKLDNN is https://github.com/oneapi-src/oneDNN
Fix the SyntaxWarning about is and is not in Python 3.8

/home/wkcn/proj/megengine/build/python_module/megengine/_internal/craniotome.py:311: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if cur is 0:
/home/wkcn/proj/megengine/build/python_module/megengine/core/function.py:49: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if isinstance(grads, Tensor) or grads is None or grads is 0:
/home/wkcn/proj/megengine/build/python_module/megengine/core/function.py:58: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  list(x._symvar if x is not None and x is not 0 else 0 for x in grads)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You may need to modify the ACKNOWLEDGMENTS file at the same time.

Hi @windreamer , I have updated the ACKNOWLEDGMENT.

@wkcn Please provide a better commit message, and try to put different changes into two commit, thx.
We prefer Conventional Commits.

@xxr3376 Thank you! I will organize them later.

Close it and re-commit two PRs : )


fix device selection for compilation language model in vlm

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


disable toggle?

i'm using bootstrap-datepicker and get into trouble.
when i click a day, it works well，but when i click the same day again. the select was canceled....
the online demo http://eternicode.github.io/bootstrap-datepicker/ works well. click again same day will keep the selection.......
i have read the docs and can't find anyway to disable toggle......

This is still broken in 1.6.4

@altinselimi Can you create a new issue for this with an example on 1.6.4 to reproduce the problem? Thanks!


[BEAM-11542] Add support for projecting GroupBy objects

This PR also adds an expect_error option to DeferredFrameTest._run_test. When true, _run_test will verify that our implementation raises the same error as pandas.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb

Ok, fixed the breakage for grouping a Series. PTAL @robertwb

Ok, fixed the breakage for grouping a Series. PTAL @robertwb


KAFKA-18084: Added usage for rollback state while SharePartition acquires records

About
SharePartition#acquire` does not honor the rollback state. This causes two issues.

leaked acquisitionLockTimeoutTask - SharePartition#acquirecreate a newacquisitionLockTimeoutTaskfor the "available" batch, however, the available batch in transition already has aacquisitionLockTimeoutTask, so the leaked acquisitionLockTimeoutTask` will corrupt the state later.

null acquisitionLockTimeoutTask in a "acquired" batch - this can be reproduced by following order.
a) the batch is in transition - current state is AVAILABLE and rollback state is ACQUIRED
b)SharePartition#rollbackOrProcessStateUpdates is processing RPC, so it does not call InFlightState#completeStateTransition
c)SharePartition#acquire assumes the batch is available, so it changes the state from AVAILABLE to ACQUIRED and create a new acquisitionLockTimeoutTask
d) SharePartition#rollbackOrProcessStateUpdates complete the RPC - it commit the state and cancel the acquisitionLockTimeoutTask - that means the batch is in ACQUIRED but it does not have acquisitionLockTimeoutTask
the next AcknowledgeRequest tries to update the state to ACKNOWLEDGED but it encounters NPE acquisitionLockTimeoutTask and then the request gets hanging until timeout

Testing
Added a unit test to verify the changed behaviour and tested with the help of originally present unit/integration tests for share consumers.

@adixitconfluent Thanks for the PR, but for my understanding when can this scenario happen? We take a lock in the acquire which means a single thread/client can have access. And acquire method is synchronous update hence state will be fully transitioned. How do we encounter this issue?

@adixitconfluent Thanks for the PR, but for my understanding when can this scenario happen? We take a lock in the acquire which means a single thread/client can have access. And acquire method is synchronous update hence state will be fully transitioned. How do we encounter this issue?

@apoorvmittal10, the issue can occur when the writeState RPC hasn't completed writing updates to the persister for AVAILABLE records which could result in leaked/null acquisitionLockTimeoutTask. Quoting the issue mentioned on the ticket for details-
SharePartition#acquire does not honor the rollback state [1][2]. This causes two issues.
a. leaked acquisitionLockTimeoutTask - SharePartition#acquirecreate a newacquisitionLockTimeoutTaskfor the "available" batch, however, the available batch in transition already has aacquisitionLockTimeoutTask, so the leaked acquisitionLockTimeoutTask` will corrupt the state later ...
b. null acquisitionLockTimeoutTask in a "acquired" batch - this can be reproduced by following order.
the batch is in transition - current state is AVAILABLE and rollback state is ACQUIRED
SharePartition#rollbackOrProcessStateUpdates is processing RPC, so it does not call InFlightState#completeStateTransition
SharePartition#acquire assumes the batch is available, so it changes the state from AVAILABLE to ACQUIRED and create a new acquisitionLockTimeoutTask (see a.)
SharePartition#rollbackOrProcessStateUpdates complete the RPC - it commit the state and cancel the acquisitionLockTimeoutTask - that means the batch is in ACQUIRED but it does not have acquisitionLockTimeoutTask
the next AcknowledgeRequest tries to update the state to ACKNOWLEDGED but it encounters NPE acquisitionLockTimeoutTask[3] and then the request gets hanging until timeout
[1] https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/server/share/SharePartition.java#L665
[2] https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/server/share/SharePartition.java#L646
[3] https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/server/share/SharePartition.java#L1663

@chia7712 can you please review this PR changes whenever you get some time. Thanks!

We can observe this scenario by running ShareConsumerTest.testExplicitAcknowledgeReleasePollAccept. This test case uses DefaultStatePersister and produces both leaked acquisitionLockTimeoutTask instance and null acquisitionLockTimeoutTask instance. This explains why testExplicitAcknowledgeReleasePollAccept with DefaultStatePersister is slow to close consumer, as the server is unable to respond due to the NPE.
testExplicitAcknowledgeReleasePollAccept(String).persister=org.apache.kafka.server.share.persister.NoOpShareStatePersister	testExplicitAcknowledgeReleasePollAccept(String)[1]	2.220s	passed
testExplicitAcknowledgeReleasePollAccept(String).persister=org.apache.kafka.server.share.persister.DefaultStatePersister	testExplicitAcknowledgeReleasePollAccept(String)[2]	37.992s	passed

...

[2024-12-01 19:45:47,417] WARN [ShareConsumer clientId=consumer-group1-4, groupId=group1] Consumer triggered an unsubscribe event to leave the group but couldn't complete it within 30000 ms. It will proceed to close. (org.apache.kafka.clients.consumer.internals.ShareConsumerImpl:889)

Just highlighting, with my current changes in this PR, the test times for both kind of persisters are comparable on my local machine.
kafka.test.api.ShareConsumerTest#testExplicitAcknowledgeReleasePollAccept org.apache.kafka.server.share.persister.NoOpShareStatePersister 4.259 sec
kafka.test.api.ShareConsumerTest#testExplicitAcknowledgeReleasePollAccept org.apache.kafka.server.share.persister.DefaultStatePersister 5.911 sec

@chia7712 @apoorvmittal10 please can you also review this PR if it needs changes or if its good to merge. Thanks!

Hi @chia7712 , I have resolved your comments. Please re-review when you can. Thanks!!

Hi @chia7712 , can you please re-review this PR now. Thanks!

can you please re-review this PR now. Thanks!

I will take a look later!


Use SI http adapter for http source module

Please see the discussion here

We would want to make the http source module fully backed by SI adapter; with this, there might be lot more options we would have to support and expose for module-option overrides.
The decision is to revisit the original PR from @ericbottard. Please refer to #13, #17, and #20 for more details.
There were number of requests ([XD-1746] (https://jira.spring.io/browse/XD-1746)) for a fully MVP aware http source module on the Spring XD project as well.

This issue was moved to spring-cloud/spring-cloud-stream-app-starters#65


fix: increase the eviction cost baseline value for do-not-disruptable pods

Fixes #N/A
Description
Karpenter manages the order for disruption based on the total disruption cost of the pods on a node. However, this does not take into account pods Karpenter can not evict due to the  karpenter.sh/do-not-disrupt: true. As a result, nodes that can't have all their pods evicted may be selected as candidates for disruption before nodes with equal or greater number of pods that are all evictable. When this occur, the unevictable node wastes the nodepool's disruption budget.
This change fixes that bug by increasing the base pod eviction cost for pods annotated with karpenter.sh/do-not-disrupt: true in Karpenter's simulation models.
How was this change tested?
Unit tests + real workloads in our clusters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Does this PR actually change anything behavior wise?
The only disruption method that cares about disruption cost is Consolidation, but we don't consider pods with do-not-disrupt for consolidation, only for Drift with TGP enabled. https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/disruption/types.go#L102, so this code path gets exercised, but doesn't actually change anything for drift or consolidation.

The only disruption method that cares about disruption cost is Consolidation, but we don't consider pods with do-not-disrupt for consolidation, only for Drift with TGP enabled. https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/disruption/types.go#L102, so this code path gets exercised, but doesn't actually change anything for drift or consolidation.

Huh. I opened this PR because we have been testing out various tweaks to Karpenter and I thought this one had an empirical impact from some of our metrics.
I added some more logging today and it looks like the it bears out the code you linked, the change here only affects the eventual disruption class, which doesn't sort candidates based on the disruption cost anyway. Which agrees with your point. So I'm not sure why we saw an improvement with this, possibly it was coincidental noise.


CloudEvent responses should try harder to be valid / semantically correct in the output messages

Copying headers from input to output of a Function is incredibly useful as a default, but as we know from experience with HTTP headers, the output sometimes needs to be sanitized or massaged to prevent issues. A Function that transforms a CloudEvent into another CloudEvent is really easy to write, but the output by default has some issues at present, mainly caused by copying headers without paying attention to their semantics. Let's look at the 4 mandatory headers (attributes) in a CloudEvent:

The ce-source is safe to copy, but the user might want to change it quite commonly.

The combination of ce-source and ce-id is supposed to be unique (globally). We could implement this easily just by copying the Messsage id over into the ce-id header.

The ce-type is often going to be used by the consumer to route the message to the next consumer. If we just blindly copy it, then you end up in an infinite loop, potentially. So copying ce-type is a bad default, but CloudEvents have to have a type. So we need a better default. E.g. appending the incoming type with the name of the function or something.

The ce-specversion is safe to copy, but the user might want a convenient way to flip it.

Where the user probably cares about things, providing a simple programming or configuration model for function registrations or implementations would make sense.

Related to #422

This has been addressed by defining CloudEventAttributesProvider which when configured as @Bean will be called by the framework to set Cloud Event attributes(headers) on the outgoing Message. The default strategy is also provided with the following rules.

id - generated UUID
type - name of the payload type
specversion - 1.0
source - the name of the application

@FunctionalInterface
public interface CloudEventAttributesProvider {
	/**
	 *
	 * @param attributes instance of {@link CloudEventAttributes}
	 */
	void generateDefaultCloudEventHeaders(CloudEventAttributes attributes);
}


Support for APM Per Request Policy

ISSUE TYPE

Feature Idea

AS3 BUILD/ VERSION
3.7+

BIGIP VERSION
version 13.1.1

##### SUMMARY
while we can attach a per session apm policy to a VS with

"policyIAM": {
"bigip": "/Common/my-APM-policy"
}

we are not able to attach a per request apm policy to a virtual server and need this functionality

##### EXPECTED RESULTS

have the ability to reference and existing per request apm policy on a virtual server

Are there any updates to AT-688? I am in need of this Per-Request-Policy via AS3 Declaration functionality

The feature is in development and will likely be available for the 3.23.0 release.

What is the ETA for the 3.23.0 release?

The 3.23.0 release is tentatively planned for mid-October.

This was resolved in the 3.23.0 release.


Personal page webparts do not load

Category

[ ] Question
[X] Bug
[ ] Enhancement

Expected or Desired Behavior
When viewing the Personal.aspx page I expect the web parts for meetings, tasks, personal contacts, personal email, recent sites and recent documents to load successfully and display their associated data.
Observed Behavior
The first web part loads, this is usually the meetings web part. The others don't load at all or else timeout with an error.
Steps to Reproduce

Run the provisioning/deploy.ps1 script
Go to the newly (successfully) provisioned site.
Click on the Personal link

the web parts should be there with their associated loading messages, the meetings web part will load and none of the rest will.

@tchagan I got the same issue. It looks like it only completes the first graph request for a calendar. It looks like the rest has a timeout.

@expiscornovus I've found that if I put on of the personal webparts on another page by itself, it works fine. If I then go to the Personal page the web parts seem to work fine too. I'm presuming that this is an authentication issue when more than one webpart on a page is using MS Graph. I read about this in another thread, there was a workaround but I also read that PnP folks were working on this issue.

I believe it is a bug...
details from Beau Camerons blog points to the following article.
https://github.com/SharePoint/sp-dev-docs/issues/1810
There is a work around but required rebuilding the package.
However the bug is being worked on.

This is indeed related to a bug in the underlying AAD auth model, which should be addressed partly in the SPFx v1.5 and fully in upcoming 1.6.


Adding Category data to Conditions table

PULL REQUEST
Summary
This adds a new column to the conditions table, category. This is an organizational structure that we need to organize our conditions to display like so:  https://www.figma.com/design/Iuw9me6kYftBF4WTCEsCZz/Query-Connector?node-id=475-18708&node-type=frame&t=Lcg6TdahnUvYPBsR-0
These are the categories we would end up with:

the three missing are ones we added. Here are my thoughts on how to handle:

Social Determinants of Health, which I believe we can remove from the DB given convo today
Cancer (Leukemia), which, probably fairly reasonably, could be coded to coded to be included in the Cancer category.
Newborn Screening, which could be Birth Defects and Infant Disorders? I don't see an immediately obvious one we would nest Newborn Screening under, otherwise. I can see an argument for it being standalone.

a few backend considerations: right now, we are mounting the CSV to be loaded. I mostly wanted to see what that would look like, but some other potential options that vary in cleanliness:

just use INSERT statements to create the temporary category_data table that needs to be merged with conditions.
this data in theory is only necessary for the display of data on the custom query page. We could just have a small script that transforms this into a JSON we reference to functionally display this data independent of the db.
we could read the data from an S3 bucket. This is probably a lot more work, but if we were uncomfortable committing this file as a standalone file to the repo, or if it introduces Terraform complications, that might provide some balance.

Related Issue
Fixes #68
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information
Anything else the review team should know?
Checklist

[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Looks fine to me as is, though I would probably be in the camp of just using INSERT statements to make that temporary table. I have no problem exposing this file publicly, but we probably aren't looking to do so. Mounting and S3 both seem like overkill to me, but that's more a stylistic and preference thing, I think--I would rather our DB product not establish the pattern of bringing in externally mounted volumes. I think the seeding/creation should be as self-contained as possible. I don't feel strongly either way, and I don't think anything here is blocking though!

I'm torn, I think I lean toward a bunch of INSERT statements also being fine. I think I'd probably want to add a script that can parse this CSV to write those INSERTs each time a new eRSD drops for some future-proofing (or, preferably, convince APHL to surface this data in the eRSD...).
happy to look into that option if we think it's cleaner.

@bamader definitely agree that ultimately all database creation should be handled in a single place (the work you and @m-goggins are doing). I totally forgot about this when reviewing. I'd propose that we move this along so that @robertandremitchell and @fzhao99 aren't blocked on their query building work, but eventually have this along with all other seeding handled at the app layer.

@DanPaseltiner That sounds good to me--approving with the idea that we revisit the conversation during broader DB creation!

@bamader definitely agree that ultimately all database creation should be handled in a single place (the work you and @m-goggins are doing). I totally forgot about this when reviewing. I'd propose that we move this along so that @robertandremitchell and @fzhao99 aren't blocked on their query building work, but eventually have this along with all other seeding handled at the app layer.

Makes sense to me. I've created a new issue in the backlog so that we don't lose track of that work (https://linear.app/skylight-cdc/issue/QUE-43/refactor-conditionscategory-migration), but I will work on getting this merged shortly (darn CI tests).
Thank you both for your review!

requesting a re-review since switching to INSERT over CSV. everything else should be the same.


Native consumer hits error backoff delay after topic EOF in end-to-end testing.

Good day!
I have been testing end-to-end performance of pykafka, similar to what is done in the EndToEndLatency test.
I have been very surprised that using rdkafka often made the latency considerably higher. Here is my test harness:
from time import time
from random import random
from os import getpid

from pykafka import KafkaClient
from pykafka.common import OffsetType

TIMEOUT = 6000
TOPIC = 'test'
KEY = 'key'

client = KafkaClient(
    zookeeper_hosts='localhost:2181',
    broker_version='0.10.2',
    socket_timeout_ms=TIMEOUT)
topic = client.topics[TOPIC]

def produce_and_consume(key, value, producer, consumer):
    producer.produce(value, key)
    while True:
        t = time()
        msg = consumer.consume()
        delta = time() - t
        if msg.partition_key != key:
            continue
        if msg.value != value:
            continue
        return delta

if __name__ == '__main__':
    num_seen = 0
    pid = getpid()
    producer = topic.get_producer(
        True,
        sync=True,
        retry_backoff_ms=10,
        linger_ms=1)
    producer.start()
    for use_lib in (True, False):
        deltas = []
        consumer = topic.get_simple_consumer(
            "a_group", use_lib,
            auto_commit_enable=False,
            auto_offset_reset=OffsetType.LATEST,
            fetch_wait_max_ms=0,
            # fetch_error_backoff_ms=1,
            consumer_timeout_ms=TIMEOUT)

        for i in range(20):
            value = "%d_%d" % (pid, i)
            delta = produce_and_consume(KEY, value, producer, consumer)
            deltas.append(delta)
        print "lib=%d, n=%d, low=%f, high=%f, avg=%f" % (
            use_lib, i, min(deltas), max(deltas),
            sum(deltas) / len(deltas))
        consumer.commit_offsets()
        consumer.stop()
    producer.stop()

Here are typical results:
lib=1, n=19, low=0.499292, high=1.004887, avg=0.526834
lib=0, n=19, low=0.000024, high=0.009366, avg=0.001291

This was done with kafka 0.10.2, pykafka 2.5.0 or 2.6.0.dev2, on MacOS 10.12.3.
After some analysis, I realized that we were almost always going through the recursive use of Consumer_consume following a RD_KAFKA_RESP_ERR__PARTITION_EOF here
(I am not sure why it hits EOF with a synced topic; I tried with native or non-native producers, but it has no impact. On an unrelated note, I wonder why the Topic.get_synced_producer always gives a non-native producer, is that intentional?)
After some more research, I found that this is a known feature of rdkafka: EOF is counted as an error and triggers the error backoff. See
https://github.com/edenhill/librdkafka/issues/1024
(even though we are not in the enable.partition.eof = false case, the rest of the discussion is relevant.)
I tried setting a low fetch.error.backoff.ms by adding that parameter to pykafka (commented parameter in my harness), and I got perfectly fine results with the rdkafka in that way.
It is a temporary solution, until the librdkafka issue is fixed, but it is the first one I have to propose at this point.

PS. this is what the temporary changes to pykafka could look like. It's missing documentation, testing etc., but the approach itself probably needs discussion anyway.

Thanks for digging into this, @maparent. It looks at a glance like your solution is appropriate here, but it could certainly use some explanatory documentation to help other users get around this issue.

I added documentation to the parameter and made a PR, tell me if you think it needs even more documentation (and where you think I should put it, if so.)
Regards

Thanks, I left a review on #663.


Maintenance status and roadmap of Express

Since expressing concern over the status of long-awaited features is frowned upon by the development team, I was wondering if there is an official roadmap in place for Express somewhere? This would help greatly in planning the long term strategies for those of us using Express in our own stacks.

Hi there! It seems like there are two questions here, so I will address them separately:
For the maintenance status: Express is still actively landing pull requests that are arriving that are complete. Keep in mind "Express" consists of all the repos in three orgs: expressjs, pillarjs, and jshttp. There are certainly some open PRs stalled out, and anyone who can lend a hand to them is more than welcome to contact the author of the PR to see what is going on.
For a roadmap, I would also love to see one! I have expressed my desire a lot to have someone join to help create one, but we so far have not had such a person. I have tried a bit to "roadmap" in a sense by keeping a checklist at the top of release PRs, but those only matter for releases that have a PR, not effective for future releases.
Can we count on you to help for either or these two items? If so, start commenting and helping right away! If you need someone to talk to to get started, let us know! We also have a triager system if you would like to get started in that way.
Have a great weekend, and I hope I have gotten your questions answered and I look forward to the possibility of another hand to help!


change to iOS-centric code in app.js

I found that the code you note that should be added to the app.js file throws an error, and am using this instead:
var application = require("application");

if(application.ios){

    var AppDelegate = UIResponder.extend({
    applicationDidFinishLaunchingWithOptions(application, launchOptions) {
        return FBSDKApplicationDelegate.sharedInstance().applicationDidFinishLaunchingWithOptions(application, launchOptions);
    },

    applicationOpenURLSourceApplicationAnnotation(application, url, sourceApplication, annotation) {
        return FBSDKApplicationDelegate.sharedInstance().applicationOpenURLSourceApplicationAnnotation(application, url, sourceApplication, annotation);
    },

    applicationDidBecomeActive(application) {
        FBSDKAppEvents.activateApp();
    }
}, {
    protocols: [UIApplicationDelegate]
});

    application.ios.delegate = AppDelegate;

}

Maybe is giving an error because I have a separate file for app.android and app.ios
I will add your fix to the readme. Also the applicationOpenURLSourceApplicationAnnotation method is great :-D I thought it was not possible to change that method on the Delegate via NativeScript. That solve the issue of always returning isCancelled ==true

Terrific! Thanks!


UI Root Not Working anymore due to MIME type restrictions

System information

Have I written custom code (as opposed to using zenbot vanilla): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04/Firefox 84.0 (64 bit)
Zenbot version (commit ref, or version): 4.1.0
Zenbot branch: unstable
NodeJS version: 10.19.0
Did I make any changes to conf-sample.js?: Yes

Describe the problem
Due to strict enforcement of MIME type matching, the UI root no longer works. This appears to have originated in Firefox version 72.0 where X-Content-Type-Options: nosniff was added to top level documents by default (source: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Content-Type-Options), mismatching the provided Content-Type of test/html for the JS bundles for the UI. This should be a simple fix consisting of updating the specified Content-Type from text/html to application/javascript.
I'd be more than happy to look into a fix for this, however, it looks like the echarts.bundle.js file required to make the dashboard work is transpiled/committed to the repo and the package.json does not contain the logic to build this. If you could please either help with a solution or point me in the right direction so I can work on it, that'd be great.

Hi,
I'm having some issues with the web GUI also.
Setup info:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Zenbot version (commit ref, or version): 4.1.4
Zenbot branch: unstable
NodeJS version: 12.18.2
Python version (when using a python script): -
Exact command to reproduce (include everything): npm install --unsafe-perm
Did I make any changes to conf-sample.js?: No

I think the problem is when the post_install.js script gets to line to start webpack it fails because -p option for webpack -p is deprecated in 5.11.1

The -p flag used to mean "production", maybe for 5.11.1 it should be "webpack --mode production"?
after changing this line in the post_install script the error changes to:

All this results to the Web GUI looking exactly like in issue https://github.com/DeviaVir/zenbot/issues/1581 (couldn't tag it) with the same errors in the browsers console:

Hi,
I'm having some issues with the web GUI also.
Setup info:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Zenbot version (commit ref, or version): 4.1.4
Zenbot branch: unstable
NodeJS version: 12.18.2
Python version (when using a python script): -
Exact command to reproduce (include everything): npm install --unsafe-perm
Did I make any changes to conf-sample.js?: No

I think the problem is when the post_install.js script gets to line to start webpack it fails because -p option for webpack -p is deprecated in 5.11.1

The -p flag used to mean "production", maybe for 5.11.1 it should be "webpack --mode production"?
after changing this line in the post_install script the error changes to:

All this results to the Web GUI looking exactly like in issue https://github.com/DeviaVir/zenbot/issues/1581 (couldn't tag it) with the same errors in the browsers console:

I'm having the same issue

I'm having the same issue

I've fixed the issues in the following pull request:
https://github.com/DeviaVir/zenbot/pull/2624
Let me know if there's any issues with the pull request.

I've fixed the issues in the following pull request:
https://github.com/DeviaVir/zenbot/pull/2624
Let me know if there's any issues with the pull request.


Not sending data upon restart

I've heard there is an iOS issue only regrading location service apps running in the background. Upon restart they don't automatically start location services. This seems to be happening with Traccar 1.3 for iOS, but works fine on Android.  Is there a way to set it to start when the phone boots up?

This would be a good feature, along with keeping the app running even when closed. I know that Apple's way of handling apps in their store is garbage, so it's understandable if you're not able to do so.

Unfortunately it's impossible. To be able to start at boot we need to declare VOIP permission and Apple would never approve the app because we don't use permission for its main intent.

Shucks, that's what I figured... Thanks anyway!


linux: add VSOCK struct and constants

Add struct sockaddr_vm and VMADDR_ constants to use VSOCK on Linux.
VSOCK is present since Linux 3.9

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+

:pushpin: Commit 4825678dee10f0bec113d6aee2893c028d1e1809 has been approved by gnzlbg

:hourglass: Testing commit 4825678dee10f0bec113d6aee2893c028d1e1809 with merge 8e4931b663eefd8bb757dd6ec23d9b2b37c4f2a4...

:broken_heart: Test failed - checks-travis

@bors: retry

:hourglass: Testing commit 4825678dee10f0bec113d6aee2893c028d1e1809 with merge 2026c866673a84ad0cd63ac2d73a4f4c2df277ac...

:sunny: Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 2026c866673a84ad0cd63ac2d73a4f4c2df277ac to master...


Lock riakc version just like riak_test

I'm not sure that putting this in master is the right thing to do, since I don't completely understand how this will affect testing of older versions of riak, ie 2.0.next. Since we were always pulling in the latest version of the client anyway, that may not matter, but we should at least think about it.

Generally it makes sense to have a branch on master. That said, it would be good to tag this and @basho_bench and riak_test, etc when actually testing a final release

Explicitly setting which rebar is used in basho-builds fixes this problem.


Reduce logspam from the health check services

Noticed this in /var/log/messages
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:12:58] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:12:59] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:12:59] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:00] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:00] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:00] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:01] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:02] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:02] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:03] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:03] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:03] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:04] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:05] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:05] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:06] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:06] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:06] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:07] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:08] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:08] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:09] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:09] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:09] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:10] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:11] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:11] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:12] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:12] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:12] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:13] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:14] "GET /status.json HTTP/1.1" 200 -
Sep 14 10:13:39 multinic-a-x9w3 python3[2811]: <IP_ADDRESS> - - [14/Sep/2020 10:13:14] "GET /status.json HTTP/1.1" 200 -

Likely as simple as updating the unit file
[Service
StandardOutput=null
StandardError=journal

Decided to keep this because it's nice to have in place to verify health checks are being received.  These messages aren't being sent to Stackdriver as far as I can tell.  Using a query with log_id("syslog") doesn't find them.


iOS: failed to download settings

I am getting this error:
failed to download settings

On ios. Any suggestions?

Have you sorted this out? This seems like a Fabric issue itself, going to close this for now.


Filtering of featured event card

No ticket
About these changes
The featured event card is meant to have the filtering applied, just like the other event cards, and should not be repeated in the list below.
This adds some extra queries to work with the featured card, if it has been added. It also moves more of the markup from the whats on template to the whats on listing include, so that the featured card can be updated with JavaScript.
How to check these changes
Add a few events to a whats on listing page, and also add a featured event. Check that the filtering behaves as you expect, and that the featured event is not repeated in the listing below.
Also check the page when there is no featured event selected.
You could also test that it works without JS by setting the FEATURE_DISABLE_JS_WHATS_ON_LISTING to True in your .env file (note that you need to run fab stop and fab start)
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer
[ ] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
[x] Ensured that PR includes only commits relevant to the ticket
[x] Waited for all CI jobs to pass before requesting a review
[ ] Added/updated tests and documentation where relevant

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

@jams2 this is ready for a re-review.
@jamesbiggs you'll want to also have a look because this changes the values for the filtered events that we are using in the template.

@jamesbiggs maybe you could deal with the last points on this and merge it now?


MD022 - Headings should be surrounded by blank lines

I'd like to configure this warning to:

Require a preceding empty line (as it already does)
Not requiring a following empty line

So this should be OK:
something

# Heading
more text

But this should not be OK:
something
# Heading
more text

The docs explain why you must have an empty line before the heading (kramdown), but only cites aesthetics for why you should have an empty line after the heading.
And as a lot of our markdown has no empty line after headings, and I actually like it this way, I'd like to be able to inform Markdownlint about this.
Regards /Johan

I feel like I have seen parsers have problems with this, so I won’t default it on - but it seems okay to add as an option. Thanks!

Is it possible to configure markdownlinter to force usage of 2 empty lines before headings and 1 after?

Not currently, but that seems like a reasonable thing to enable as part of addressing this issue.

Thank you for new feature!
But new problem show up. Applying this new rule will force to change other rule (multiple empty lines), and that will allow breaking its desired default value 1. As in .markdownlint.json:
{
  "no-multiple-blanks": {
    "maximum": 2         <------ We need to keep this to 1.
  },
  "blanks-around-headings": {
    "line-above": 2,
    "line-below": 1
  }
}

Desired would be only to override multiple-empty-line validation on validating heading lines.
Any way, thank you for the work on this feature.

Yes, I mention that consequence here: https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md022
Because rules are independent, I don’t see a good way to avoid this.

Related question, can we have heading-level rules for this? Probably makes sense to have a blank line after the H1, not necessarily headings lower than H4.

See #504


[core] remove wandb dependency

What does this PR do ?
This PR removes wandb dependency for trl
wandb run of this branch: https://wandb.ai/distill-bloom/trl/runs/360f7cdc?workspace=user-
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks! I will give it a try with tensorboard and merge if there is no issue

I can confirm everything works fine (single & multi-GPU with wandb and with tensorboard)  after 37aa98e for tensorboard, since I made some non-minor modifications could you have a second look? 🙏 thanks


Admin of Group can add and remove new members.

[ ] Implement Recycler View for all the members
[ ] can delete/remove the members from the list simultaneously
[ ] Edit group name, created at properties
[ ] disband the group (not possible if it have some notes saved)


[suggestion]  Hope to add configuration function

problem
For example, time formatting, custom data types, currency formatting, ignoring empty fields, and more
You can refer to the idea of Jackson ObjectiMapper.
Current code usage cases
Will use a lot of macros，
These are all repetitive codes and tasks that can be further optimized based on macros
#[derive(Serialize)]
pub struct User {
    pub username: String,
    pub nickname: Option<String>,
    pub login_ip: Option<String>,
    #[serde(with="date_format")]
    pub login_date: Option<NaiveDateTime>,
    pub remark: Option<String>
    #[serde(with = "date_format")]
    pub create_time: Option<NaiveDateTime>,
    #[serde(with = "date_format")]
    pub update_time: Option<NaiveDateTime>,
}

serde_json::to_string(&user)

When encountering a specified type, corresponding serialization processing should be done
I expect the improved code
#[derive(Serialize)]
pub struct User {
    pub username: String,
    pub nickname: Option<String>,
    pub login_ip: Option<String>,
    pub login_date: Option<NaiveDateTime>,
    pub remark: Option<String>
    pub create_time: Option<NaiveDateTime>,
    pub update_time: Option<NaiveDateTime>,
}

step1
create config；

let config  = {
    ignore_output_none: true,
    ....
}

Register serialization interpreter
config.typeSerRegs.insert(NaiveDateTime,  serDateFunc );
config.typeSerRegs.insert(Money,  serMoneyfunc )
config.typeSerRegs.insert(NaiveDate,  func )
....

step2  config params
serde_json::to_string(&user, &config)

OR

step2  OOP

let serdeJson = SerdeJson::new(config)

serdeJson::to_string(&user)

my test code
Add later

I think this could be neat, but I would prefer to leave it to a different library instead of building something into this crate.


:bug: Fix OPDS thumbnail endpoint

Fixes an issue where generated thumbnails aren't actually being loaded, rather the file is being opened. I also made a note for two items:

Improve a silly query
Support STRICT_OPDS configuration, which will convert any non-compliant OPDS images, rather than just always doing it

I will tackle both alongside the image serving work I plan to do this weekend
See Discord for additional context

Verified locally:
  2024-08-22T23:20:37.594117Z TRACE stump_server::routers::api::v1::media: Found generated media thumbnail, path: "/Users/aaronleopold/.stump/thumbnails/ddcda452-eb6f-43c9-aac3-181a64f72fa3.png", media_id: "ddcda452-eb6f-43c9-aac3-181a64f72fa3"
    at apps/server/src/routers/api/v1/media.rs:1031
    in tower_http::trace::make_span::request with method: GET, uri: /opds/v1.2/books/ddcda452-eb6f-43c9-aac3-181a64f72fa3/thumbnail, version: HTTP/1.1

  2024-08-22T23:20:37.594424Z TRACE stump_server::routers::opds::v1_2: OPDS legacy image detected, returning as-is


Matching prodigal call with methylation location

Hello,
It would be an interesting feature if the tool could use the prodigal output and methylation location to tell us, for example, if the promoter region is methylated, or if the methylation location is coding or non coding.
I think this would be specifically interesting in the analysis of differentially methylated regions (instead of consistently methylated motifs) where DNA methylation may play a role in gene expression. This could also be the place to link with methyltransferases that are found in annotate_rm but not associated with an rm system.

I do think that would be cool. Because our focus is mostly on RM and not roles for methylation in gene regulation, I don't plan to add this in the near term, so for the time being people will have to parse that result from the _sites table and their prodigal gff and analyze in the way they see fit.


Add page to describe the SDKs

See: https://github.com/casdoor?q=sdk&type=&language=&sort=
casdoor-js-sdk is for the browser side. Other SDKs are for server-side.

@sh1luo

@sh1luo

ok


Suggestion: add docs for zsh completions

Out of the box, Zsh completions don't work as you would expect.
Given a fresh install:
brew install zsh
brew install git
brew install hub

# Workaround to fix bug with hub completions.
# hub completions only work when this alias is set.
# https://github.com/github/hub/issues/1792#issuecomment-403413131
alias git=hub

When I type git pull-<tab>, it successfully completes to git pull-request.
However, completion does not work for subcommand arguments. For example, when I type git pull-request -<tab>, the arguments do not complete.
After some digging, I discovered that I had two sets of Zsh completions for Git (using the setup above, which I believe is the route most people will take):

Git's official completions (e.g. /usr/local/share/zsh/site-functions/_git)
Zsh's official Git completions (e.g. /usr/local/Cellar/zsh/5.6.2_1/share/zsh/functions/_git)

Both of these were on my $fpath.
I then discovered that the author of the Hub Zsh completions seems to advise the usage of Zsh's official Git completions, rather than Git's official completions: https://github.com/github/hub/pull/295#issuecomment-14324233
I removed Git's official completions with rm /usr/local/share/zsh/site-functions/_git and then Hub Zsh completions seemed to work as expected. That is, when I type git pull-request -<tab>, arguments do complete.
I would like to suggest that we clearly document this caveat—Hub Zsh completions only seem to fully work when using Zsh's official Git completions, rather than Git's official completions—along with instructions for how to use Zsh's official Git completions instead.
/cc @goodell

Thank you for reporting! Due to the nature of hub extending git, our completions (both zsh and bash) might be a bit of a mess at the moment, and your research helps greatly. ✨

I created a PR to improve the docs: https://github.com/github/hub/pull/1962


Fix spelling mistake

There is a spelling mistake in the cluster package, fix it in this patch.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:FreedomWangLi/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.


archive this project

Is this project active? Can we archive this project? By archiving, previously release assets will be untouched, but support will cease for this project going forward. If anyone has any reasons this project should not be archived, please comment by March 1st.

This project is a dependency of terra-core and needs to be moved wherever Terra is going.

Thanks for response. We can bundle this with Terra's plans then and archive on it's schedule.


Can't check dimensions of theta0 and sigma0

Another problem caused by the separation of parameters & options:
I'm currently writing a PestoSamplingClass. Problem: The dimension of parameter space is currently only stored in the parameter struct and thus not accessible within the setter methods of the sampling options where I'd like to check the dimensions. Any good ideas on how to transfer this information between both objects?

Yes, that is a problem for the parameter-dependent default options.
I did not come up with a satisfying solution yet. So far, some settings are checked in the getP*.m as for example in https://github.com/ICB-DCM/PESTO/blob/master/getMultiStarts.m#L107
One option would be to have an Options constructor taking the parameters to set default values.

I think making the check in getP* for now is a good idea indeed. Thank you!

We can set all parameter-dependent options to [] per default and add a class method .setDefaults(parameters) to be called at the beginning of getParameterSamples() etc. which initializes the parameter-dependent options if still empty. This way, we would have still all default options together in the class definition.


Shouldn't the lowest accuracy request the coarse location ?

Shouldn't the lowest accuracy request the coarse location ? I'm not sure how it works on ios so maybe it's a need to streamline the two ?
The use case is to do something like this:
if (serviceEnabled) get fine location
else get coarse location

After experimenting, I believe the above request is incorrect and both coarse and fine location require the service to be enabled.

I believe the above request is incorrect as serviceEnabled seems to check if network is enabled. I've trouble understanding why I'm getting a false result when wifi is enabled tho