Have a way to disable the extendRefs warning

What version of Ajv you are you using? 4.7.2
What problem do you want to solve? extendRefs warning about issue #260 is quite noisy.
What do you think is the correct solution to problem? Add a way to disable it.
Will you be able to implement it? Probably.
I'm working with an upstream schema that has $refs extended with additional keywords. I have extendRefs set to true and my log is now full of lines like this:
$ref: all keywords used in schema at path '.rule[' + i2 + ']' (it will change in the next major version, see issue #260)

Right now I'm working around it by setting console.log to a no-op while calling ajv.compile, but I'd prefer to have a configuration option to do it.

The purpose of the warning is to notify the users that the default behaviour will change in the next major version (in case the option is not specified). In your case, when the option extendRefs is explicitly set to true, the behaviour won't change so there is not need for the warning.
So we don't need an additional option, we can remove the warning in case the option is set to true (and keep it as is if the option is undefined).
I also noticed that the message contains path expression rather than the actual path (i2 should be replaced with the actual number in the message) - it should be fixed as well.

in 4.7.7


Environment Variables Issue

Issue Type: Bug
When you set env variables using settings.json , thay are not being accessed by the integrated terminal and same thins is working fine in version 1.55
VS Code version: Code 1.56.0 (cfa2e218100323074ac1948c885448fdf4de2a7f, 2021-05-04T22:09:06.405Z)
OS version: Windows_NT x64 10.0.19042

I am too facing this issue after upgrading to 1.56.0  Needed to revert back to 1.55.2 in order to make it work.


FancyZones should maximize window

📝 FancyZones should maximize window when Win+Up is pressed at some point
Since FancyZones overrides behaviour of Win+Arrows shortcuts, it would be nice to have one of replaced functions back - to be able to maximize window.
Expected behaviour:
When current window is in upper middle zone, Win+Up maximizes window.
Alternatively, from any zone, holding Win+Up maximizes window.
One can create a zone over the whole screen, but it screws up navigation between zones, and upper window border is thicker than when window is maximized.
Bonus feature:
From any zone, holding Win+Down minimizes that window.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@semioniy
add your comments to https://github.com/microsoft/PowerToys/issues/4795
Thanks.


Detect changes at any depth based on glob pattern

Is there a way to tell onchange to run for a .js file at any depth beneath some src/ folder?
Right now, running:
onchange src/**/*.js

only re-runs for files two levels deep, i.e. src/someFolder/file.js , but will not run for src/file.js or src/someFolder/anotherFolder/file.js.
I suppose this would work:
onchange 'src/*.js' 'src/**/*.js' 'src/**/**/*.js'

But that is a silly solution to the problem that would have to be updated every time a new level is introduced under src/. Thoughts?

This is should be how it works today, but because you aren't using quotes the files are probably being expanded by your shell and not onchange. Try putting your glob in quotes.

@blakeembrey you the man! 🎉

@joncursi Thanks, it's the type of thing that gets everyone the first time 😄


services not showing in services tab and otel-v1-apm-service-map is empty

I'm running collector -> dataprepper 1.0 -> AES 7.10
Looking at #45 I have reverted the data-prepper PR that changes the span schema and manually built a jar file.  This has fixed the origiinal issue of seeing no traces.  However, now I see no services. The otel-v1-apm-span-* indices contain data, but the otel-v1-apm-service-map is always empty.
I see nothing in the elasticsearch logs indicating mapping errors etc.
We're looking to migrate our org away from elastic-apm to opentelemetry/trace-analytics but need the ability to drill down based on service name.
The data-prepper shows that the service-map pipeline is processing events:
[service-map-pipeline-prepper-worker-3-thread-1] INFO com.amazon.dataprepper.pipeline.ProcessWorker - service-map-pipeline Worker: Processing 1 records from buffer
[entry-pipeline-prepper-worker-1-thread-1] INFO com.amazon.dataprepper.pipeline.ProcessWorker - entry-pipeline Worker: Processing 1 records from buffer
[entry-pipeline-prepper-worker-1-thread-1] DEBUG com.amazon.dataprepper.pipeline.ProcessWorker - Pipeline Worker: Submitting 1 processed records to sinks

Data-prepper config:
entry-pipeline:
  delay: "100"
  source:
    otel_trace_source:
      ssl: false
  sink:
    - pipeline:
        name: "raw-pipeline"
    - pipeline:
        name: "service-map-pipeline"
raw-pipeline:
  source:
    pipeline:
      name: "entry-pipeline"
  prepper:
    - otel_trace_raw_prepper:
  sink:
    - elasticsearch:
        hosts: ["${ELASTICSEARCH_HOST}" ]
        username: "${ELASTICSEARCH_USERNAME}"
        password: "${ELASTICSEARCH_PASSWORD}"
        trace_analytics_raw: true
service-map-pipeline:
  delay: "100"
  source:
    pipeline:
      name: "entry-pipeline"
  prepper:
    - service_map_stateful:
  sink:
    - elasticsearch:
        hosts: ["${ELASTICSEARCH_HOST}" ]
        username: "${ELASTICSEARCH_USERNAME}"
        password: "${ELASTICSEARCH_PASSWORD}"
        trace_analytics_service_map: true

Example span data:
{
    "name": "baz",
    "context": {
        "trace_id": "0x2bfe27e9786311bb5d417c957da798e5",
        "span_id": "0x48b3327412dfa8d5",
        "trace_state": "[]"
    },
    "kind": "SpanKind.INTERNAL",
    "parent_id": "0xf04395ec442bfcbb",
    "start_time": "2021-07-14T13:34:07.759899Z",
    "end_time": "2021-07-14T13:34:07.759978Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {},
    "events": [],
    "links": [],
    "resource": {
        "service.name": "ocal-app",
        "space": "platform",
        "org": "local"
    }
}
{
    "name": "bar",
    "context": {
        "trace_id": "0x2bfe27e9786311bb5d417c957da798e5",
        "span_id": "0xf04395ec442bfcbb",
        "trace_state": "[]"
    },
    "kind": "SpanKind.INTERNAL",
    "parent_id": "0xea98094123af9929",
    "start_time": "2021-07-14T13:34:07.759756Z",
    "end_time": "2021-07-14T13:34:07.760013Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {},
    "events": [],
    "links": [],
    "resource": {
        "service.name": "local-app",
        "space": "platform",
        "org": "local"
    }
}
{
    "name": "foo",
    "context": {
        "trace_id": "0x2bfe27e9786311bb5d417c957da798e5",
        "span_id": "0xea98094123af9929",
        "trace_state": "[]"
    },
    "kind": "SpanKind.INTERNAL",
    "parent_id": null,
    "start_time": "2021-07-14T13:34:07.759644Z",
    "end_time": "2021-07-14T13:34:07.760028Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {},
    "events": [],
    "links": [],
    "resource": {
        "service.name": "local-app",
        "space": "platform",
        "org": "local"
    }
}

Linking issue in data-prepper repo https://github.com/opendistro-for-elasticsearch/data-prepper/issues/720


Automated broken links check (Issue #236)

This adds the GitHub action for automated broken links check as described in issue #236.
In order to allow links to the nf-core/tools to be validated a config file was added.
Huge thanks to @gaurav-nelson for helping me to get this to work

Looks good, but no tests are actually done here, and you have conflicts to resolve.
Can you try to fix that?

I think it's actually working quite well, I think we should add that in the template, to check markdown in all pipelines as well.
But we do need to fix the links on this PR first, and the MD lint.
I think you still have some remnants of the conflicts in the installation.md file

@MaxUlysse I guess I need to practice a bit on how to solve merge conflicts. But I am on it.

I can see that, do use the output from the linting to help you:
Typically this:
https://github.com/nf-core/nf-co.re/pull/275/checks?check_run_id=438475883#step:5:4

Phew, checks now pass and  it looks like the merge conflicts are gone. Hope I didn't do anything stupid now 🙈 Thanks for having a look at this @MaxUlysse

@MaxUlysse there is already an open issue for it from the last hackathon https://github.com/nf-core/tools/issues/473

I totally forgot about it.

Sorry for the messy comments, doing whilst I'm in a meeting so a bit scattered!

Sorry for the messy comments, doing whilst I'm in a meeting so a bit scattered!

Thanks for the review @ewels 😃

=========================> MARKDOWN LINK CHECK <=========================

[✔] All links are good!

=========================================================================

Love it @gaurav-nelson!


chore: Update app screenshots in ReadMe

Update screenshots of new app version
Remove stale resources from screenshots directory

Fixes #1394

@iamareebjamal
I recommend not deleting the previous images. Even though the images are 20+ MBs in size deleting them will not do us any good. I mean the files will still exist in the git history and bloat the repository.
You need to remove the files from git history. If you delete the files now future developers will have no idea that images existed somewhere and won't be able to remove them from git history.
either leave the images as they are or godhead and solve #1290
(Just an opinion)

@the-dagger Please take a look


[app.client.chat_update] update only a small part of an existing message with JSON pointers.

Being able to edit/update an existing message with JSON pointers instead of replacing the whole message, would be very nice and easy if you only need to edit a bit of text, or edit an emoji or colour lets say.
Category (place an x in each of the [ ])

[x] slack_sdk.web.WebClient (sync/async) (Web API client)
[ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.socket_mode (Socket Mode client)
[ ] slack_sdk.audit_logs (Audit Logs API client)
[ ] slack_sdk.scim (SCIM API client)
[ ] slack_sdk.rtm (RTM client)
[ ] slack_sdk.signature (Request Signature Verifier)

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @rmnijgh, thanks for writing in!
Indeed, such a feature would be useful for some use cases but our platform team does not have any plans to enhance the API method in that way at least in the short term. Please bear with the current way to update messages. Thanks again for sharing this feedback!


throw new InvalidArgumentException('$pipeline is empty');

why is an exception thrown for an empty pipeline? Like db.test.aggregate([])?
db.test.aggregate([]) works fine directly in mongo
See https://github.com/mongodb/mongo-php-library/blob/master/src/Operation/Aggregate.php#L115

Sorry, one more addition, in the console:
db.test.aggregate()
is also valid, so perhaps the PHP method should have default array parameter:
public function __construct($databaseName, $collectionName, array $pipeline = [], array $options = [])
as well
Thanks

We'll take a look at this and contemplate a change for 1.2.0. I had some mental recollection that this was due to earlier versions of the CRUD specification, which also prohibits bulkWrite() from being called with no operations; however, I wasn't able to find specific mention of the aggregate pipeline. The non-empty pipeline requirement is also inconsistent across various language drivers (PHP isn't the only one with this behavior, but many others do allow empty pipelines).

Tracking in PHPLIB-281.


Fix command line/test mode

Before it was split into modules, you used to be able to call hopscotch from the command line with a URL to see what it would do. That code is still in Hopscotch.pm, but not callable. Lets fix that!

I have been reliably informed that I'm full of crap:
E: Passed malformed URL: hi```

🤷♂

I've also been reliably informed that this is "probably still worth fixing, lib/Hopscotch.pm looking at ARGV is janky". So lets do that sometime.


STS Patch Broke this mod

Missing class reference of STSSentry.
import com.megacrit.cardcrawl.core.STSSentry;
Is no longer in the base game as far as I can tell.
Looks like you only used it to find  the hostname?
Maybe InetAddress.getLocalHost().getHostName() can do the same?
Not sure if it matters but pom.xml basemod I think the groupid is:
basemod

https://github.com/Jazzer360/sts-weighted-paths/pull/2

Implemented the fix


Error with CNVkit

Hi Brad,
I'm experiencing the following error when trying cnvkit:
[2017-01-31T14:30Z] CNVkit coverage bin estimation
[2017-01-31T14:30Z] Estimated read length 76.0
[2017-01-31T14:31Z] Traceback (most recent call last):
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 158, in <module>
[2017-01-31T14:31Z]     fields = hybrid(rc_table, read_len, args.bam, targets, access)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 58, in hybrid
[2017-01-31T14:31Z]     anti_table = anti_table.assign(mapped=anti_table.mapped - target_reads)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 715, in wrapper
[2017-01-31T14:31Z]     result = wrap_results(safe_na_op(lvalues, rvalues))
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 676, in safe_na_op
[2017-01-31T14:31Z]     return na_op(lvalues, rvalues)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 652, in na_op
[2017-01-31T14:31Z]     raise_on_error=True, **eval_kwargs)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 210, in evaluate
[2017-01-31T14:31Z]     **eval_kwargs)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 121, in _evaluate_numexpr
[2017-01-31T14:31Z]     result = _evaluate_standard(op, op_str, a, b, raise_on_error)
[2017-01-31T14:31Z]   File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 63, in _evaluate_standard
[2017-01-31T14:31Z]     return op(a, b)
[2017-01-31T14:31Z] ValueError: operands could not be broadcast together with shapes (124,) (166,)
[2017-01-31T14:31Z] Uncaught exception occurred
Traceback (most recent call last):
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 22, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 102, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
CalledProcessError: Command 'set -o pipefail; export TMPDIR=/tmp/bcbio/tmpaYGlVa && /home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py /home/projects/bcbio_annotation/test_runs/cnvseq/work/align/t
Estimated read length 76.0
Traceback (most recent call last):
  File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 158, in <module>
    fields = hybrid(rc_table, read_len, args.bam, targets, access)
  File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 58, in hybrid
    anti_table = anti_table.assign(mapped=anti_table.mapped - target_reads)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 715, in wrapper
    result = wrap_results(safe_na_op(lvalues, rvalues))
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 676, in safe_na_op
    return na_op(lvalues, rvalues)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 652, in na_op
    raise_on_error=True, **eval_kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 210, in evaluate
    **eval_kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 121, in _evaluate_numexpr
    result = _evaluate_standard(op, op_str, a, b, raise_on_error)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 63, in _evaluate_standard
    return op(a, b)
ValueError: operands could not be broadcast together with shapes (124,) (166,)
' returned non-zero exit status 1
Traceback (most recent call last):
  File "/home/galaxy/bcbio-dev/anaconda/bin/bcbio_nextgen.py", line 234, in <module>
    main(**kwargs)
File "/home/galaxy/bcbio-dev/anaconda/bin/bcbio_nextgen.py", line 43, in main
    run_main(**kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 42, in run_main
    fc_dir, run_info_yaml)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 86, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 175, in variant2pipeline
    samples = structural.run(samples, run_parallel, "initial")
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/__init__.py", line 146, in run
    for xs in to_process.values()))
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"], batch_size=1)(joblib.delayed(fn)(x) for x in items):
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 804, in __call__
    while self.dispatch_one_batch(iterator):
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 662, in dispatch_one_batch
    self._dispatch(tasks)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 570, in _dispatch
    job = ImmediateComputeBatch(batch)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 183, in __init__
    self.results = batch()
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 72, in __call__
    return [func(*args, **kwargs) for func, args, kwargs in self.items]
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 51, in wrapper
    return apply(f, *args, **kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 244, in detect_sv
    return structural.detect_sv(*args)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/__init__.py", line 165, in detect_sv
    for svdata in caller_fn(items):
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 31, in run
    return _cnvkit_by_type(items, background)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 41, in _cnvkit_by_type
    return _run_cnvkit_single(items[0])
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 75, in _run_cnvkit_single
    ckouts = _run_cnvkit_shared([data], background)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 156, in _run_cnvkit_shared
    raw_work_dir, inputs[0])
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 320, in _cnvkit_targets
    bin_estimates = _cnvkit_coverage_bin_estimate(raw_target_bed, access_bed, cov_interval, work_dir, data)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/structural/cnvkit.py", line 345, in _cnvkit_coverage_bin_estimate
    do.run(_prep_cmd(cmd, tx_out_file), "CNVkit coverage bin estimation")
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 22, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 102, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command 'set -o pipefail; export TMPDIR=/tmp/bcbio/tmpaYGlVa && /home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py /home/projects/bcbio_annotation/test_runs/cnvseq/t
Estimated read length 76.0
Traceback (most recent call last):
  File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 158, in <module>
    fields = hybrid(rc_table, read_len, args.bam, targets, access)
  File "/home/galaxy/bcbio-dev/anaconda/bin/coverage_bin_size.py", line 58, in hybrid
    anti_table = anti_table.assign(mapped=anti_table.mapped - target_reads)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 715, in wrapper
    result = wrap_results(safe_na_op(lvalues, rvalues))
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 676, in safe_na_op
    return na_op(lvalues, rvalues)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 652, in na_op
    raise_on_error=True, **eval_kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 210, in evaluate
    **eval_kwargs)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 121, in _evaluate_numexpr
    result = _evaluate_standard(op, op_str, a, b, raise_on_error)
  File "/home/galaxy/bcbio-dev/anaconda/lib/python2.7/site-packages/pandas/computation/expressions.py", line 63, in _evaluate_standard
    return op(a, b)
ValueError: operands could not be broadcast together with shapes (124,) (166,)
' returned non-zero exit status 1

As always, I'm on the latest dev release.
Any idea what could be wrong?
Thanks!
M

I think this error is occurring where the set of chromosomes/contigs in the list of targets (your panel) is compared to the chromosomes/contigs in the reference genome (the FASTA file of sequences, via the "access" BED file calculated on the fly within bcbio). If these two sets of contig names are different, the script does try to extract the shared subset to ensure they match, but it looks like I didn't cover every possibility.
Is there anything unusual about either of those files in your setup? Is this the human reference genome?

Hi @etal,
Thanks for chiming in. We're not doing anything out of the ordinary here, just testing a single end fastq mapped to hg38, everything default, no frills. I'm not really familiar with the inner workings of CNVkit, so I probably won't be of much help. I would be nice to get it to work though.
Thanks again
M

So, the workaround here is to trim the target BED file to just the 24 canonical chromosomes -- it looks like you have either 124 or 166 targeted contigs in the BED file you used here.
I'll look into fixing the script to handle the original case.

Hi Eric,
Thanks for following up on this! I'll give it a shot using an alternate bed file. Based of your comment, I suppose the issue is caused by the hg38 build, which has a lot of alternate contigs.
Looking forward to the fix!
Cheers,
M

I've reproduced this issue and I'm working on a fix now.

Allright! Nice, thanks a lot!
M

This fix is released with CNVkit version 0.8.5 now. The script coverage_bin_size.py will work as before, but with these bugs fixed. The new autobin command is a superset of that functionality, and will also generate target and antitarget BED files, so bcbio-nextgen probably won't need to parse the output table once the new command is adopted. No need to transition immediately to the new command, but the script is now deprecated and will be removed in the 0.9 release.

Hi @etal
Great to hear, thanks!
@chapmanb how would you feel about about adopting the new command?
Thanks again,
M

CNVkit seems to work great since updating to the latest version. Thanks a lot @etal!
Cheers
M


storage: simple refactoring

What have you changed?
These are mostly simple code motion refactorings to split up a few big files and get rid of some utils modules.
What is the type of the changes?
Pick one of the following and delete the others:

Engineering (engineering change which doesn't change any feature or fix any issue)

PTAL @breeswish @youjiali1995 (I recommend reviewing each commit, they standalone and each is quite simple by itself)

@youjiali1995 @MyonKeminta rebased and comments addressed. Please take another look

Oh, something wrong in CI


Internal: Parallel coverage testing

This workflow implements a parallel approach. Here are the key changes and explanations:

We create separate directories for unit and feature tests to run them independently.
We run the unit and feature tests in separate steps. This allows them to run concurrently, speeding up the overall process.
We use phpcov to merge the coverage reports. This tool is part of the PHPUnit ecosystem and is designed for exactly this purpose.
The merged coverage report is then uploaded to Codecov.

graph TD
  A[Start] --> B[Set up PHP environment]
  B --> C[Checkout code to src directory]
  C --> D[Install dependencies in src]
  D --> E[Set testing environment]
  E --> F[Prepare test directories]
  F --> G[Copy src to unit_tests]
  F --> H[Copy src to feature_tests]
  G --> I[Run Unit Tests]
  H --> J[Run Feature Tests]
  I --> K[Generate Unit Test Coverage]
  J --> L[Generate Feature Test Coverage]
  K --> M[Merge Coverage Reports]
  L --> M
  M --> N[Upload to Codecov]
  N --> O[Ping statistics server]
  O --> P[End]
  style I fill:#f9f,stroke:#333,stroke-width:2px,color:#333
  style J fill:#f9f,stroke:#333,stroke-width:2px,color:#333
  style K fill:#ccf,stroke:#333,stroke-width:2px,color:#333
  style L fill:#ccf,stroke:#333,stroke-width:2px,color:#333
  style M fill:#fcc,stroke:#333,stroke-width:2px,color:#333

Baseline test execution time: https://github.com/hydephp/develop/pull/1928/commits/2337a942155d007381a612fe32455b00a5d4e0bf

Merging coverage adds a lot of complexity, so pivoting to do smoke tests in parallel as that's where the biggest pain point is anyway, and we don't need to assemble so much data.


ukvm-mirage: Immediate VCPU exit with exit_reason=0x8

When running the config_console example from the ukvm-mirage branch, using the provided Docker container to build, ukvm exits immediately from vcpu_loop() with run->exit_reason set to 8. This corresponds to KVM_EXIT_SHUTDOWN and is triggered on a triple fault of the VCPU.
Calling get_and_dump_sregs(vcpufd) before entering vcpu_loop() produces the following dump:
 cr0: 00000000e0000011   cr2:<PHONE_NUMBER>000000   cr3:<PHONE_NUMBER>009000
 cr4:<PHONE_NUMBER>000020   cr8:<PHONE_NUMBER>000000

 Segment registers:
 ------------------
 register  selector  base              limit     type  p dpl db s l g avl
 cs        0008<PHONE_NUMBER>000000  000fffff  0b    1 0   0  1 1 1 0
 ss        0010<PHONE_NUMBER>000000  000fffff  03    1 0   1  1 0 1 0
 ds        0010<PHONE_NUMBER>000000  000fffff  03    1 0   1  1 0 1 0
 es        0010<PHONE_NUMBER>000000  000fffff  03    1 0   1  1 0 1 0
 fs        0010<PHONE_NUMBER>000000  000fffff  03    1 0   1  1 0 1 0
 gs        0010<PHONE_NUMBER>000000  000fffff  03    1 0   1  1 0 1 0
 tr        0018<PHONE_NUMBER>002000  00000067  0b    1 0   0  0 0 0 0
 ldt       0000<PHONE_NUMBER>000000  0000ffff  02    1 0   0  0 0 0 0
 gdt<PHONE_NUMBER>000500  00000027
 idt<PHONE_NUMBER>001000  00000fff

This seems fine. I've also verified with gdb that the page table setup looks OK. Further, adding some debug code to call and dump KVM_GET_REGS after the KVM_RUN ioctl returns shows that the VCPU does not get past the first instruction in kernel_main().
My system is an Intel Sandy Bridge laptop, with an Intel Core i5-2540M CPU. VT-x and VT-d (IOMMU) are both enabled. I'm running Linux kernel version 4.1.20.

Trying the workaround suggested by @ricarkol to load kvm_intel with ept=0 does not work either. The only difference is I get a warning in the kernel log about KVM_SET_TSS_ADDR not being called. Enabling the commented out call in ukvm.c and rebuilding does not change anything either.
FWIW, this thread provides some explanation of KVM_SET_TSS_ADDR, if I'm reading it right it only matters for KVM guests running in real (well, vm86) mode?

A further data point: I tried rebooting with the stock Debian jessie kernel (3.16.0) and get exactly the same result, so it looks like we can rule out any KVM interface change (@djwillia mentioned he's also on 3.16).

Yes, the system registers match what I have on my working setup.  I have not yet been able to reproduce the problem.  The working setup is running an Intel Xeon X5675 with VT-x enabled and Linux kernel version 3.16.0.  Not sure if it's relevant or not, but how do you check VT-d status?
What about how the module is loaded?

Oops didn't mean to close!

VT-d is normally a BIOS setting. If your dmesg says anything about an IOMMU then that usually means its enabled.
 I've been testing with nested both enabled and disabled. The PLE stuff shouldn't matter.

Some more info. I'm running on an intel i5, these are teh results of these combinations:
kernel 4.3.3-1 with ept=ON        fail (exit_reason = 0x8)
kernel 4.3.3-1 with ept=OFF      fail (exit_reason = 0x8)
kernel 3.10.94 with ept=ON     fail (exit_reason = 0x8)
kernel 3.10.94 with ept=ON     pass

I just tried 3.16.0 with ept=OFF and that also fails.

Aha! One successful data point: I copied the binaries to a rather old and different machine (2x AMD Opteron 8356, kernel 3.2.0) and it works. So there's definitely something with my hardware that's triggering the problem.

And yet another one: Ubuntu 15.10 (kernel 4.2.0, AMD Opteron 3350 HE). Works. What's notable is that this is a much newer kernel, so it looks like it's something specific to my laptop that's triggering the problem.

Ok, I now have a machine that is also failing in the same way (kernel 3.16, Intel Xeon E5420).  I've run "kvmtest" successfully on that machine, so I'm going to look into what the difference is, which seems promising.  "kvmtest" is a really simple test of the KVM interface that you can find at http://lwn.net/Articles/658512/

Couple more datapoints with lkvm (kvmtool) with clear-container patches (https://github.com/clearlinux/kvmtool.gitwith branch=clear-patches). Could reproduce the same problem:
./lkvm run /usr/src/bzImage -d disk.img  # this is the regular path: vcpu starts in single mode. This works (in my laptop) for kernel 3.10 and kernel 4.3.
./lkvm run -k /usr/src/vmlinux -d disk.img # this is similar to what ukvm does: vcpu starts already in protected mode. This only works for kernel 3.10.

I've tested another machine, which works: 2015 vintage, Intel NUC w/ Core i7-5557U. Running freshly updated Debian testing (stretch), kernel 4.4.0 (4.4.6-1).

Got it: My laptop's CPU does not support 1GB pages (no pdpe1g present in /proc/cpuinfo, confirmed with x86info -a). The machines where it works for me do support it. See also Intel SDM vol. 3A, section 4.1.4 "Enumeration of Paging Features by CPUID".

I've addressed this in #8 by switching to 2MB pages for the guest which makes things work on my machine. Intel SDM 4.1.4 (referenced above) implies that if long mode (called IA-32e in their manuals) is supported then 2MB pages must also be supported, so this should work on all x86-64 processors.
@djwillia Please test and merge if you're happy with it. @ricarkol This should work on the kernel/machine combinations that were previously failing for you. If not, then your issue with VMENTRY is different to mine.

@mato Great job, that was fixed the issue on the machine I found that was failing too.  It seems like we may need to do a bit of hardware discovery.  I think it should be done in ukvm rather than in the guest.  CPU speed is a place that some "discovery" is happening, but it is a horrible hack:
https://github.com/djwillia/solo5/blob/ukvm-mirage/ukvm/ukvm.c#L687
It might make sense to have a little configuration script which figures out what we need to know and generates a header or something for ukvm.c   What do you think?

Let's discuss feature discovery in #9 so that we don't pollute this issue. We can close this one when @ricarkol confirms my change in #8 solves the problem for him.

it works!
        |      ___|

|  _ \  |  _ \ __ \
_ \ (   | | (   |  ) |
____/_/ _|__/____/
Solo5: new bindings
hello
world
hello
world
hello
world
hello
world
Kernel done.
Goodbye!
KVM_EXIT_HLT
0:04.75 elapsed
solo5@8dc1ae7fe74e:~/solo5$ uname -a
Linux 8dc1ae7fe74e 4.3.3-1.el6.elrepo.x86_64 #1 SMP Tue Dec 15 13:13:15 EST 2015 x86_64 x86_64 x86_64 GNU/Linux

Closing


open3d_ros: 0.1.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository open3d_ros to 0.1.0-1:

upstream repository: https://github.com/unr-arl/open3d_ros.git
release repository: https://github.com/unr-arl/open3d_ros-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.7
previous version for package: null

open3d_ros
* Initial working package
* Contributors: Nikhil Khedekar, Pranay Mathur

Closing as we are moving the code to a ros_perception repository https://github.com/ros-perception/perception_pcl/issues/291


HBASE-22459 Expose store reader reference count

Expose the reference count over a region's store file readers as a metric in region metrics and also as a new field in RegionLoad. This will make visible the reader reference count over all stores in the region to both metrics capture and anything that consumes ClusterStatus, like the shell's status command and the master UI.
Coprocessors that wrap scanners might leak them, which will leak readers. We log when this happens but in order to notice the increasing trend of reference counts you have to scrape log output. It would be better if this information is also available as a metric.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
57
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
256
master passed

+1
compile
198
master passed

+1
checkstyle
165
master passed

+1
shadedjars
279
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
588
master passed

+1
javadoc
133
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
251
the patch passed

+1
compile
207
the patch passed

+1
cc
207
the patch passed

+1
javac
207
the patch passed

-1
checkstyle
74
hbase-server: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
278
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1053
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.

+1
hbaseprotoc
191
the patch passed

+1
findbugs
601
the patch passed

+1
javadoc
125
the patch passed

_ Other Tests _

+1
unit
36
hbase-protocol-shaded in the patch passed.

+1
unit
29
hbase-hadoop-compat in the patch passed.

+1
unit
32
hbase-hadoop2-compat in the patch passed.

+1
unit
24
hbase-protocol in the patch passed.

+1
unit
193
hbase-client in the patch passed.

+1
unit
7747
hbase-server in the patch passed.

-1
unit
321
hbase-rest in the patch failed.

+1
asflicense
168
The patch does not generate ASF License warnings.

15361

Reason
Tests

Failed junit tests
hadoop.hbase.rest.model.TestStorageClusterStatusModel

hadoop.hbase.rest.TestSecureRESTServer

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/248

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  cc  hbaseprotoc

uname
Linux eed98d3cfd52 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 8e47c8e739

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/1/artifact/out/patch-unit-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/1/testReport/

Max. process+thread count
4887 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Bah need to fix TestStorageClusterStatusModel and maybe the other one. Back soon

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
52
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
242
master passed

+1
compile
168
master passed

+1
checkstyle
142
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
524
master passed

+1
javadoc
110
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
236
the patch passed

+1
compile
169
the patch passed

+1
cc
169
the patch passed

+1
javac
169
the patch passed

+1
checkstyle
142
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
986
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.

+1
hbaseprotoc
167
the patch passed

+1
findbugs
548
the patch passed

+1
javadoc
113
the patch passed

_ Other Tests _

+1
unit
37
hbase-protocol-shaded in the patch passed.

+1
unit
30
hbase-hadoop-compat in the patch passed.

+1
unit
36
hbase-hadoop2-compat in the patch passed.

+1
unit
24
hbase-protocol in the patch passed.

+1
unit
199
hbase-client in the patch passed.

-1
unit
14225
hbase-server in the patch failed.

+1
asflicense
177
The patch does not generate ASF License warnings.

22841

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestMasterReplication

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/248

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  cc  hbaseprotoc

uname
Linux 9b4edc2e79a8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 6b899ccbbc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/3/testReport/

Max. process+thread count
5024 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Other than Duo's comment , LGTM. +1

No problem, will remove from Store and leave in HStore only. Back soon.

TestMasterReplication issue does not seem related, but will check

Updated patch removes changes to Store.

Last version of patch got a clean precommit run on the JIRA. No reason to think the interface change in the latest patch would affect that.
https://issues.apache.org/jira/browse/HBASE-22459?focusedCommentId=16847138&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16847138

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
49
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
265
master passed

+1
compile
173
master passed

+1
checkstyle
146
master passed

+1
shadedjars
267
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
544
master passed

+1
javadoc
121
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
242
the patch passed

+1
compile
174
the patch passed

+1
cc
174
the patch passed

+1
javac
174
the patch passed

+1
checkstyle
147
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1004
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.

+1
hbaseprotoc
166
the patch passed

+1
findbugs
582
the patch passed

+1
javadoc
111
the patch passed

_ Other Tests _

+1
unit
36
hbase-protocol-shaded in the patch passed.

+1
unit
31
hbase-hadoop-compat in the patch passed.

+1
unit
36
hbase-hadoop2-compat in the patch passed.

+1
unit
24
hbase-protocol in the patch passed.

+1
unit
202
hbase-client in the patch passed.

-1
unit
15757
hbase-server in the patch failed.

+1
asflicense
154
The patch does not generate ASF License warnings.

20961

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide

hadoop.hbase.quotas.TestQuotaAdmin

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/248

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  cc  hbaseprotoc

uname
Linux f9c6cd2242b4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / ca00cbeed2

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/4/testReport/

Max. process+thread count
4950 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-248/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

+1

Thank you @Apache9 and @xcangCRM for the reviews!


Train with lmdb dataset

I want to train Master with LMDB dataset but I don't see any args related to image size. How can I train with fixed image size ?

@wenwenyu and how can I train with only one GPU

Hi, LmdbDataset has added img_w and img_h args. Training with one GPU can use debug model. e.g. python train.py -c configs/config.json -d 1 -dist false, and  -d specify which one gpu will be used.

how can I create a lmdb dataset to work with it. Maybe your key in lmdb file is quite different from that of deep-text-recognition-benchmark

Yes, the key in the lmdb file is different from that of deep-text-recognition-benchmark. Two ways to deal with this difference.

You can modify the key to adapt your lmdb dataset, including nSamples, image_key, and label_key

Refer to the example of creating lmdb dataset to satisfy our LmdbDataset

我有3个gpu在一个机器上怎么训练


Improved action buttons for chat code blocks

Our code block controls have been a problem in recent user testing. Code output in chat is important for anything that still relies on chat, which is most built-in commands, custom commands, and chat itself.
This is a basic building block that we need to get right to instil confidence and lovability. We also lag behind other leading extensions for the manipulating code blocks in chat.
Here's a new design for code block actions that replace our current "Copy" and "Insert at Cursor" buttons that appear on hover:

Figma:
https://www.figma.com/file/9112BsKsJc1BpO2j8XYwLL/🤖-Cody-VS-Code-[Main]?type=design&node-id=5110-7877&mode=design&t=KpUpBEhodg72KYQY-4

I've tightened up the spacing and added the standard quick pick-style dropshadow:

Also added a prototype to show the experience:
https://www.figma.com/file/9112BsKsJc1BpO2j8XYwLL/🤖-Cody-VS-Code-[Main]?type=design&node-id=5123-9170&mode=design&t=Ey1vVRTX2jpZjtT5-4
https://github.com/sourcegraph/cody/assets/153/43b26a92-bf7f-4274-b46c-573b11d96271

@toolmantim ah I see it now :) I was talking about the other one tho!

It's also only visible on hover, maybe that's why I couldn't see it at a glance on first use.

@yaosamo you found it! Luckily that should be covered by this change too, because the code is shared. But that variant wasn't included in this design because that App chat UI is on pause for the moment.

@abeatrix looks like we still have some things to clean up before this goes out in the next release, which I'll document here properly soon, but the things I've spotted are:

Disabled for insert at cursor if no file is open
Some kind of "Copied" feedback
Border colors look off on different themes

@toolmantim do you have a screen shot of the border colors that looks off?
it should be using the vscode color theme for the border:

@abeatrix yep, here you go! Sometimes the border color is different between the pre and the .container (themes: Abyss, Kimble Dark, Solarized Dark):

And often the border is a too bright, so perhaps we're using the wrong variable:

@toolmantim Since the changes for the improved code blocks are in, i've closed this main issue and created a new issue for the bug for the theme border color here: https://github.com/sourcegraph/cody/issues/1268


Added math module

Notes
I added a math module that has useful math function not included in love2d or Lua.
Also updated the lib.lua file to include the math module

Closed because of no response

Sorry for no response. I was a lil' busy, but thanks for the contribution! I really liked the module!
I will try to answer other pull requests and issues!

Do you grant me permission to add the code of the module (or maybe some functions) to the library?

Hey there!
No worries at all; life gets busy, and it's completely understandable. We're just excited to see you diving into your first real project—congrats on that! 🎉
It's awesome to hear that you liked the module! Don't stress about not having all the answers right now; everyone starts somewhere.
Take your time reviewing pull requests and addressing issues—it’s all part of the learning curve. And remember, the community is here to support you, so don’t hesitate to reach out if you ever need help navigating this process.
Keep up the amazing work, and no need to apologize. You're doing great! 😊
Also, this was my first pull request, so I’m just as excited as you are! 😄


Undefined is not an object (evaluating '_react2.PropTypes'.shape)

Hi, I'm using this library with node version 6.11.4 and npm version 4.6.1 with expo. I created my project using "create-react-native-command". On using this library, I'm always getting this error":

Undefined is not an object (evaluating '_react2.PropTypes'.shape)

I'm using it this way:
<ImageLoader
                               options={{
                                   src: item.imageUrl
                               }}>
                           </ImageLoader>

+1


fix(sqllab): prev shema/table options remained on fail

SUMMARY
Due to the difference between the data of the RDK query and currentData, an issue occurred in SQL Lab where, instead of showing an empty selection due to (permission) errors, the schema and table selector allowed the selection of previous database or schema options.
  data?: T // The latest returned result regardless of hook arg, if present
  currentData?: T // The latest returned result for the current hook arg, if present

As a result, it was possible to combine schema and table selections that do not actually exist, causing errors and potentially confusing users.
This commit addresses these issues by changing to currentData, ensuring that only results existing in the strictly selected database and schema are displayed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/user-attachments/assets/e7b06e9e-d091-4174-8fd7-62081be566ff
After:
https://github.com/user-attachments/assets/de84841f-5fd0-40d5-b021-502da1403022
TESTING INSTRUCTIONS
Select a db/schema/tables in Sql Lab page
Choose a db that doesn't allow to access the schemas
See the schema selection remained or not after db selection changed
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@supersetbot label 4.1

@michael-s-molina Please add this hotfix on 4.0 too.


GUI apps freeze and never launch on new windows 11 install

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows 11 Version 10.0.22000.258

Your Distribution version: [On Debian or Ubuntu run `lsb_release -r` in WSL]
Ubuntu 20.04

Your WSLg version: [Open 'Apps and Features' and check the version of 'Windows Subsystem for Linux GUI app support', e.g: <IP_ADDRESS>]
Windows Store Version
PS C:\> wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.29
Windows version: 10.0.22000.258
PS C:\> wsl --status
Default Distribution: Ubuntu
Default Version: 2
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.29
Windows version: 10.0.22000.258

Steps to reproduce
Install windows 11, install wsl, install ubuntu, try to run graphic app

WSL logs:

Attach WSLg logs from  /mnt/wslg

You can access the wslg logs using explorer at: \\wsl$\<Distro-Name>\mnt\wslg (e.g.: \\wsl$\Ubuntu-20.04\mnt\wslg)

pulseaudio.log
weston.log
versions.txt
stderr.log
wsl_debug_console.log
strace.log

Expected behavior
GUI apps
Actual behavior
GUI apps freeze
Also, NVIDIA deep learning works fine with GPU acceleration it's just GUI apps, they just freeze

ls /tmp/.X11-unix
X0

I'm getting a similar issue intermittently


How to set anchor box parameters?

Hi Chuanqi, appreciate your work!
I have a question, how can I set the number of defaut boxes?(For weiliu's SSD, its first priorbox layer has 4 defaut boxes instead of your 3.) It seems that if I want to change it, I need to rebuild the whole model.
Looking forward for your suggestions.

see gen.py:
def create_ssd_anchors(num_layers=6,
                       min_scale=0.2,
                       max_scale=0.95):
  box_specs_list = []
  scales = [min_scale + (max_scale - min_scale) * i / (num_layers - 1)
            for i in range(num_layers)] + [1.0]
  return zip(scales[:-1], scales[1:])


SocketInformation is not marked as serializable

Now we have DuplicateAndClone() supported (https://github.com/dotnet/runtime/issues/1760)
But the entire scenario would be needing to serialize SocketInformation to another process.
So should SocketInformation marked as serializable?

This issue was moved to dotnet/runtime#34596


Cannot import module poliastro.earth

I am trying to test the sample code provided by the docs for visualizing a ground-track of a satellite, but after installing poliastro and it's dependencies, I have trouble importing the module earth.
Please let me know if some info is missing, I'll be happy to provide it.
🐞 Problem
Sample Code
# Useful for defining quantities
from astropy import units as u

# Earth focused modules, ISS example orbit and time span generator
from poliastro.earth import EarthSatellite
from poliastro.earth.plotting import GroundtrackPlotter
from poliastro.examples import iss
from poliastro.util import time_range

# Build spacecraft instance
iss_spacecraft = EarthSatellite(iss, None)
t_span = time_range(iss.epoch - 1.5 * u.h, periods=150, end=iss.epoch + 1.5 * u.h)

# Generate an instance of the plotter, add title and show latlon grid
gp = GroundtrackPlotter()
gp.update_layout(title="International Space Station groundtrack")

# Plot previously defined EarthSatellite object
gp.plot(
    iss_spacecraft,
    t_span,
    label="ISS",
    color = "red",
    marker={"size": 10, "symbol": "triangle-right", "line": {"width": 1, "color": "black"}},
)

Traceback
Traceback (most recent call last):
  File "gt.py", line 5, in <module>
    from poliastro.earth import EarthSatellite
ModuleNotFoundError: No module named 'poliastro.earth'

pip freeze data
astropy==4.1
astroquery==0.4.1
beautifulsoup4==4.9.3
cached-property==1.5.2
certifi==2020.12.5
cffi==1.14.4
chardet==4.0.0
cryptography==3.3.1
cycler==0.10.0
html5lib==1.1
idna==2.10
importlib-metadata==3.3.0
jeepney==0.6.0
jplephem==2.15
keyring==21.8.0
kiwisolver==1.3.1
llvmlite==0.35.0
matplotlib==3.3.3
numba==0.52.0
numpy==1.19.4
pandas==1.1.5
Pillow==8.1.0
pkg-resources==0.0.0
plotly==4.14.1
poliastro==0.14.0
pycparser==2.20
pyparsing==2.4.7
python-dateutil==2.8.1
pytz==2020.5
requests==2.25.1
retrying==1.3.3
scipy==1.5.4
SecretStorage==3.3.0
six==1.15.0
soupsieve==2.1
typing-extensions==<IP_ADDRESS>
urllib3==1.26.2
webencodings==0.5.1
zipp==3.4.0

💡 Possible solutions
N/A
📋  Steps to solve the problem
N/A

Hi @lubeskih,
I see you are using poliastro==0.14.0 which does not include the poliastro.earth module. You were probably reading the latest documentation, which is built on top of the 0.15.dev0.
If you want to make use of previous sub-package and its utilities, you will need to install poliastro in "dev mode". A detailed description of the installation process can be found here.
Please, let us know if you find any kind of problem when following previous installation steps.

Hi @lubeskih,
I see you are using poliastro==0.14.0 which does not include the poliastro.earth module. You were probably reading the latest documentation, which is built on top of the 0.15.dev0.
If you want to make use of previous sub-package and its utilities, you will need to install poliastro in "dev mode". A detailed description of the installation process can be found here.
Please, let us know if you find any kind of problem when following previous installation steps.

@jorgepiloto, thank you very much! That did the trick for me. Closing this issue. :)

@jorgepiloto, thank you very much! That did the trick for me. Closing this issue. :)


fix: getting rid of astra in docker image name

Updating docker image name

The image itself as well as various languages need to be updated either.

The image itself as well as various languages need to be updated either.

I know, I intentionally use it as a reminder for you. 😏

The image itself as well as various languages need to be updated either.

I know, I intentionally use it as a reminder for you. 😏

here it is https://github.com/TEN-framework/TEN-Agent/pull/321

The image itself as well as various languages need to be updated either.

I know, I intentionally use it as a reminder for you. 😏

here it is #321

You the man.


Panel Handle Resize

Take into account mobile Safari footer when adding movement constraints for the panel position.

Closed by #33.


Support psr/http-message version 2

Description
Currently cannot require this package to applications using psr/http-message higher than 1.0:
typesense/typesense-php[v4.8.0, ..., v4.8.7] require psr/http-message ^1.0 -> found psr/http-message[1.0, 1.0.1, 1.1] but the package is fixed to 2.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command. Please expand the version constraint to allow it to be installed on systems that have http-message 2+.
Metadata
Typesense Version: latest
OS: Linux

Hi @kevinquillen
The issue was solved with this PR: https://github.com/typesense/typesense-php/releases/tag/v4.9.0
Please update to the latest version.


Print / Save Designs

Whereas most browsers have the functionality to print/save PDF this is probably a non-issue.

To be sure, there are two differing ideas of saving the design.  The initial idea here is that the user is able to save the drawing as a PDF etc.  A second idea for saving the design would be to output the Row information to a file which could then import the saved design.  Currently the program is capable of handling eight (8) rows.


Issue #2898: UHDM coverage point to empty source line

Issue #2898: UHDM coverage point to empty source line

Fixed +1 indexing issue with line management when evaluating multi-line macros
Added function to update include file info

@hs-apotell, excellent work! I was stuck for the last week trying to make progress on this and getting nowhere yet.


rancher-compose logs --lines option does not work

Rancher Version:
1.1.4
Docker Version:
1.10
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

Create and start a container
Use rancher-compose logs to get logs from that container
Use rancher-compose logs --lines="1000" to get more logs from that container

Results:
Same lines of logs (around 100) are returned not matter  --lines is used or not.
Expected:
According to Rancher Doc https://docs.rancher.com/rancher/v1.1/en/cattle/rancher-compose/commands/, more (or less) logs can be returned when --lines option is in use.
There are surely more logs in my test container because docker logs <test_container_id> will return much more logs

Sorry, totally duplicated with #4334
Before opened this issue, I searched issue list by keyword logs in title but that one used log so I missed :(


Only clear /dist on prod build

This is running everytime and sometimes I want to look at the /dist without having to rebuild =P
phenomic start clears the dist folder and doesn't need to.
Only the phenomic build should clear the dist.

/dist is not used in dev, so that can only create confusion to keep an out of date /dist folder during dev mode. Why do you want to keep /dist ?

In my dev workflow I typically only clear out dist or build folders
when I am building for production.
I sometimes want to reference/see the /dist files contents and have to
rebuild to see stuff.
It's also a pain when I'm showing more and more people phenomic and I try
to explain how the /content maps to /dist and demo hot-reloading etc
but that wipes out the /dist and I have to stop and rebuild and wait.
I want to be able to demo phenomic's local dev setup aka phenomic start
and show them the dist folder in 2 seconds instead of waiting for that
build =P
On Wed, Aug 31, 2016 at 1:07 PM, Maxime Thirouin<EMAIL_ADDRESS>wrote:

/dist is not used in dev, so that can only create confusion to keep an out
of date /dist folder during dev mode. Why do you want to keep /dist ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MoOx/phenomic/pull/696#issuecomment-243884418, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfMLk-kvLpgVThEGWjMoqMYsXJO3Ldks5qld70gaJpZM4Jx8bj
.

I don't think the outdated dist folder hurts anything by hanging around in local dev but maybe that's just my opinion. You should know you need to npm run build to deploy new changes.
Anywho, this is a convenience thing more than anything

On second thought, this seemed to be causing issues for me.
When /dist wasn't being removed. Local dev wasn't hot-reloading for some reason.  (not sure why)
Closing this.

I just left my computer. Will review and merge tomorrow then :)

The problem here, it that webpack-dev-server can serve dist before builded assets stored in memory...


[go] Undo some 1.12 overrides that now build with 1.13

Motivation for this change
Cleaning up some go1.12 overrides that don't work.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Change LGTM.
nixpkgs-review pr passed ok with 11 package built:
cockroachdb curlie git-lfs gobetween grpcui magnetico nomad terraform-full terraform-providers.elasticsearch terraform_0_11-full terragrunt
nixos/tests passed:

cockroachdb
magnetico

Can you reformat the commit message to start with treewide and not [go]?

Done.

Sorry - bad push closed this


Native pascal code for templates

The template engine is currently based off a parser and interpreter. This is pretty useful for many purposes especially where dynamic interpretation requirements exist. However, templates can take time to evaluate by the interpreter depending on the logic, even if it is in the order of ms, it is still suboptimal.
Once an app and templates are mature/ ready for release, some circumstances will allow for templates to be fixed. The benefit of the design, is that most of the template language constructs map onto Delphi language constructs. We can introduce a pre-processor code generation step that emits code that can be registered with the TTemplateRegistry, allowing for native compiled speed when it comes to output being generated. Even then, there can still be a fallback to interpretation if required.
This may have some implications:

<% require ('TType') %> becomes a requirement in a template so we can identify the type of data available so we can use native types. Otherwise, we need to revert to using variants which is less desirable.
max run time may become an optional feature. if you have tested your script, it could be disabled. the main implication is in loops actually in case there is some bad logic.
dev's CI or the IDE would need to call a command line app (sempare.template.nativegenerator) to generate the include file/unit.
might need to enforce a few other requirements regarding type management. e.g. ternary will need to enforce types returned from true/false evaluation to be of the same type.

comment below if interested. This may be available only to commercial supporters.

I've done a small proof of concept so far. I've been trying to see if I can do it with minimal changes. Actually - no changes are required to the parser at all. There may be some guidelines to how to write templates that can be native code. Further, my approach allows for native code to co-exist with interpreted code.
e.g.
unit: Model.pas contains:
type
  TIndex = record
    StartIdx : integer;
    EndIdx : integer;
  end;

Code gen on a template:
<% require 'Model.TIndex' %>
<% for i := StartIdx to EndIdx %>
   <% i %>
<% end %>

creates code:
unit MyTemplates;
interface
procedure InitTemplates;
implementation
uses
    Model,
    Sempare.Template,
    Sempare.Template.CodeGen;
procedure InitTemplates;
begin
    Template.Resolver.SetTemplate('for_in_1', TNativeTemplate.Create('for_in_1',
        procedure (const _AContext: INativeContext)
        begin
            var _LValue := _AContext.Value.AsType<Model.TIndex>();
            _AContext.Write(#13#10);
            for var i := _LValue.StartIdx to _LValue.EndIdx do begin
                _AContext.Write(#13#10'   ');
                _AContext.Write(_AContext.Encode(i));
                _AContext.Write(#13#10);
            end;
        end));
end;
{$IFNDEF DISABLE_SEMPARE_AUTO_INIT}
initialization
    InitTemplates;
{$ENDIF}
end.

All that is required is to include the unit in the project. The unit injects the native template into the template registry.
The nice thing in the above, the code generator uses the information from the <% requires 'Model.TIndex' %> to identify the TIndex record and then binds natively onto the parameters, without needing RTTI. So there is still a little RTTI in terms of the TValue, but it is just a container for the data payload.
Benchmark results:
Benchmark: Native template (Runs: 100000)
Done in 312ms
Benchmark: Interpreted template (Runs: 100000)
Done in 4348ms

That is almost 14 times faster! We sort of expect that, but nice to see the gain.


Document assets

The assets documentation in databroker has become so out of date that it's borderline anti-helpful. It should be updated and moved here, now that minting and inserting Resource documents is a more general concern across the suite of libraries, not just a databroker thing.

Closed by #136


Error handling incomplete for duplicate named functions

[X] Bug
[ ] Feature
[ ] Enhancement

Detailed Description
When creating a function that has the same name as an existing function the following error is surfaced.
Action:
dispatch create --file seed.yaml
[Code: 400] Bad request: store error when adding base image

Validate existing functions:
dispatch get functions
    NAME   |  IMAGE  | STATUS |         CREATED DATE
----------------------------------------------------------
  http-py  | python3 | READY  | Sat Jan  1 10:13:24 AEST 0000
  hello-py | python3 | READY  | Sat Jan  1 10:13:24 AEST 0000
  hello-js | nodejs6 | READY  | Sat Jan  1 10:13:24 AEST 0000

Check batch:
cat seed.yaml | grep http-py
name: http-py

The error ([Code: 400] Bad request: store error when adding base image) does not have any bearing on the actual error of unique function names.
Workaround: change name of function or delete existing named function.
Validate: dispatch get functions
Context
The error does not indicate what is wrong or why the function import failed.
A user will understand what the cause is and fix this.
Possible Implementation
Handle unique names to throw an error correction.
Complexity
Low due to known problem space - unique function names

[x ] Low - Simple enhancement or bug fix, no architectural changes or refactoring
[ ] Medium - Change requires some thought, but is relatively isolated
[ ] High - Significant architectural change or large refactor

Impact

[x ] Low - Annoyance, but does not impact business or functionality
[] Medium - Issue can be worked around, but is causing pain
[ ] High - Blocker

Your Environment

Dispatch CLI version (or git commit): latest
Dispatch Chart version (or image[s] tag):
Operating System and version: macos 10.13.3
Kubernetes version (and distribution): minikube 1.8.1
Etc (any other useful environmental information):

This is related to #183 but when using -f seed.yml you recieve a 400 opposed to a 500.


Route endpoints

In JDA 3.x, we now specify all Discord Routes. These are the routes left to be added.
Class can be seen here: link
Thanks to @MinnDevelopment for writing up this list.

[x] guilds/:guild_id/roles POST
[x] guilds/:guild_id/roles GET
[x] guilds/:guild_id/roles/:role_id GET
[x] guilds/:guild_id/roles/:role_id DELETE
[x] guilds/:guild_id/roles/:role_id PATCH
[x] guilds/:guild_id/invites GET
[ ] guilds/:guild_id/integrations GET
[ ] guilds/:guild_id/integrations POST                            // Create Guild integrations
[ ] guilds/:guild_id/integrations/:integration_id PATCH
[ ] guilds/:guild_id/integrations/:integration_id DELETE
[ ] guilds/:guild_id/integrations/:integration_id/sync POST
[ ] guilds/:guild_id/embed GET                                  //Guild Embed
[ ] guilds/:guild_id/embed PATCH
[ ] guilds/:guild_id/emojis GET
[x] guilds/:guild_id/webhooks GET // Get guild webhooks
[ ] webhooks/:webhook_id GET // Get Webhook
[x] webhooks/:webhook_id PATCH //Modify webhook
[x] webhooks/:webhook_id DELETE //Delete webhook
[ ] webhooks/:webhook_id/:webhook_token GET // Get webhook with token
[ ] webhooks/:webhook_id/:webhook_token PATCH //modify webhook with token
[ ] webhooks/:webhook_id/:webhook_token DELETE //Delete webhook with token
[ ] webhooks/:webhook_id/:webhook_token POST //Execture webhook
[ ] webhooks/:webhook_id/:webhook_token/slack POST //Execture slack webhook

Bot Only

[x] channel/:channel_id/messages/bulk-delete POST                 // Bulk delete(guild only)
[x] channel/:channel_id/messages/:message_id GET                  // Get Message By ID

Client Only

[ ] friend-suggestions GET // Get friend suggestions (displayed in the add friend tab)
[ ] track POST // Track endpoint
[x] guilds POST                                                   // Create guild, duh... {name: "fgh", region: "eu-central",  icon: null}
[x] guilds/:guild_id/delete POST                                  // Delete guild with 2fa code
[ ] guilds/:guild_id/ack POST                                   // Ack a guild
[x] guilds/:guild_id/emojis POST //Create emoji
[x] guilds/:guild_id/emojis/:id PATCH //Edit emoji
[x] guilds/:guild_id/emojis/:id DELETE //Remove emoji
[ ] users/:user_id/profile GET                                    // Get a user's profile
[ ] users/@me/connections GET                                     // Get Connections (twitch,steam,skype...)
[ ] users/@me/settings PATCH                                      // User-/Privacy Settings
[ ] users/@me/notes/:user_id PUT                                  // Notes
[ ] users/@me/guilds/:guild_id/settings PATCH                     // Notification Settings for a Guild
[ ] users/@me/mentions?limit=25&roles=true&everyone=false GET     // Recent Mentions
[ ] users/@me/mfa/codes POST                                      // Backup codes
[ ] users/@me/mfa/totp/disable POST                               // Disable 2FA
[ ] users/@me/mfa/totp/enable POST                                // Enable 2FA
[ ] users/@me/relationships POST                                  // Add Friend/ Block
[ ] users/@me/relationships GET                                   // Get Friends/Blocks/Incoming/Outgoing
[ ] users/@me/relationships/:user_id PUT                          // Get Relationship
[ ] users/@me/relationships/:user_id DELETE                       // Delete Block/Unfriend/Ignore Request/Cancel Outgoing
[ ] channels/:channel_id/recipients GET                           // Get Group members
[ ] channels/:channel_id/recipients/:user_id PUT                  // Add Group member by id
[ ] channels/:channel_id/recipients/:user_id GET                  // Group member by id
[ ] channels/:channel_id/recipients/:user_id DELETE               // Kick member
[ ] channels/:channel_id/messages/:messages_id/ack                // Ack a message
[ ] channels/:channel_id/call/ring POST //start call
[ ] channels/:channel_id/call/stop-ringing POST //deny call

guilds GET
should be
users/@me/guilds GET

guilds/:guild_id/channels/:channel_id PATCH Does not exist.
added guilds/:guild_id/channels PATCH. This is the batch channel position change endpoint.

RE: guilds/:guild_id/channels/:channel_id PATCH
Does not exist, I checked and it was 404.

guilds/:guild_id/invites POST
POST is not allowed for this endpoint. Use channels/:channel_id/invites POST instead.

Missing endpoint: guilds/:guild_id/integrations GET

So guilds/:guild_id/invites POST effectively does not exist, yes? That means that you can only create invites with channels/:channel_id/invites POST right?

guilds/:guild_id/invites exists but the only allowed method is GET.
POST returned status 405: Method not allowed
Creating an invite is only possible through the channels endpoint.

guilds/:guild_id DELETE is not used to delete a guild.
It is used to leave a guild.
Reason: 2FA Guild delete requires a code which has to be provided to guilds/:guild_id/delete using POST.

Emoji endpoints:
guilds/:guild_id/emojis POST //Create emoji
guilds/:guild_id/emojis/:id PATCH //Edit emoji
guilds/:guild_id/emojis/:id DELETE //Remove emoji
POST/PATCH body:
{"name":"abal","roles":["209445206016131073"]}
Note: name is required for POST.

 channel/:channel_id/messages/bulk_delete
should be
 channel/:channel_id/messages/bulk-delete
since the former one was deprecated
Also Bulk Delete is listed as PUT here while on discord docs it's POST.

Jake told me that bulk_delete would remain as such for the remainder of gateway v6, only switching when moving to v7, however if bulk-delete works for v6 as well I will switch.
Also, can i get a testing confirmation that it should be POST, not PUT?

No PUT returns status 405 while POST works. (Tested with both unversioned API endpoints)

We should compare this with the list provided in the official docs #219

I would like to get the rest of these into JDA during the 3.1 development cycle even if we aren't using them.

I will cross out any routes that we decide not to include like accepting invites

All routes from this list have now been implemented into JDA.

Can anyone explain how I would go about using this to send a DM to a user?

Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.


Implement search by Kernel ID

Transaction search should be by kernel id too (not only transactions id), fix empty screen state wording https://zpl.io/boMkRYv

Design:

Actual:

checked


refactor for double-entry accounting

See #3616 for initial thinking on this.

[ ] Implement business logic as triggers, with good Python test coverage.
[ ] Update payday.
[ ] Write a migration script that converts transfers, payments, and exchanges into journal entries.

:elephant: :fork_and_knife:

Hrm ... time to do a little spelunking.
What writes to and reads from the exchanges, payments, and transfers tables?

record_exchange and record_exchange_result.
sync_with_balanced looks like it can go away.
Related tickets: #2443 #3316 #2442 #2779 .

exchanges is referenced in notify_participants and update_stats during payday.

payday.sql builds a payday_payments table, and the Python side references payments as well.

I think we start with payments and then do exchanges.

After dropping the payments table in test:
22 failed, 442 passed, 75 xfailed in 47.60 seconds

I'm working on test_process_subscriptions. What does the journal look like for a subscription fulfillment during payday?

id
amount
debit
credit
parent
payday
route

3
10.00
cash
~user
null
1
1

4
10.00
~user
Team
null
1
null

(Let's keep parent just for state changes with asynchronous payments, refunds, and reversals.)
And how about payroll/owner distribution?

id
amount
debit
credit
payday
route

5
10.00
Team
~hannibal
1
null

See https://github.com/gratipay/gratipay.com/pull/3616#issuecomment-121063677 for payins, and https://github.com/gratipay/gratipay.com/pull/3616#issuecomment-121066354 for payouts.

Alright, I made it through one test. :-)
I actually feel pretty good about this approach. It took me a while to start getting comfortable with this table:

Debit
Credit

Asset
Increase
Decrease

Liability
Decrease
Increase

Income/Revenue
Decrease
Increase

Expense
Increase
Decrease

Equity/Capital
Decrease
Increase

But now that it's starting to sink in, I feel like this is really good for us. We're going to have real double-entry accounting! :D That feels like Doing It Right to me.

20 failed, 457 passed, 75 xfailed

We should have all of our actual escrow accounts in the chart of system accounts. Today that's New Alliance and PayPal. It takes a few days to move money between the two, so we should also have accounts for pending transfers.

56 failed, 423 passed, 75 xfailed

@kaguillera and I went around the horn on this here at Blue Canary. He has a bit of background in accounting and finance (@chrisdev could say even more, I'm sure ;-).
Regarding the two different schemas for representing journal entries, @kaguillera's advice is that accountants will expect the former (expanded) format, and will find the second (compact) format idiosyncratic and wrong. His advice is to use the compact format for our database schema since it makes more sense there (it's a simpler implementation of the accounting invariant that every debit has a corresponding credit), but to display our journal in the proper accounting format. Perhaps it would help to change the debit and credit columns to debiting and crediting to make clear that the journal table is slightly different (it includes extra fields, as well).
We also went through the chart of accounts on that comment together. Rather than a cash account and a single processing fee expenses account, we should have separate accounts for each place we're actually holding funds and pending transfer accounts for each (as suggested above), and also separate expense accounts for each one.
The journal needs to record everything that happens to Gratipay's escrow. As part of deploying this PR, we should reconstruct the journal back to the very beginning of Gratipay. Some of what's happened to our escrow is recorded in the three tables in our database, exchanges, transfers, and payments. The rest of what's happened to it is recorded outside of our database, in the history of the various accounts where we've held escrow, such as Balanced, New Alliance, and PayPal.
One of the purposes of the journal is to make auditing easier. Auditing means reconciling internally (ensuring that assets equal liabilities), reconciling externally (ensuring that our records line up with those of New Alliance, PayPal, etc.), and making sure we're on the up and up (no "$500 pencils," in @kaguillera's memorable phrase :moneybag: :pencil2:).
We will want to ensure the the journal as we reconstruct it is reconciled before we start writing to it.

I'm trying to figure out how to get financial accounts elsewhere into our chart of accounts and journal, rather than being a separate class of entity. This is what I'm starting with:

id (~=relative timestamp)
account
debit
credit

1
cash
10.00
null

2
~user
null
10.00

3
~user
0.59
null

4
processing fee revenues
null
0.59

Actually, let's start with this (subbing New Alliance for cash, per recent comments).

id (~=relative timestamp)
account
debit
credit

1
New Alliance
10.00
null

2
~user
null
10.00

3
~user
0.59
null

4
processing fee revenues
null
0.59

Actually, let's start with this (subbing New Alliance for cash, per recent comments).

id
account
debit
credit

1
New Alliance
10.00
null

2
~user
null
10.00

3
~user
0.59
null

4
processing fee revenues
null
0.59

We need some number of transactions/entry pairs preceding the New Alliance/~user pair.
Do we need to get have money into New Alliance before we flow money out of it?

In order to fold exchanges into journal, we need to somehow fold exchange_routes into the chart of accounts.
https://en.wikipedia.org/wiki/Chart_of_accounts

To: a friend in accounting

Good to run into you the other day!

Can I buy you lunch at K&N some day this week or next? How about this Thursday (July 23) or next Monday (July 27)?

In addition to generally catching up, I'd love to pick your brain about setting up a chart of accounts for the escrow for the crowdfunding company I'm running (Gratipay).

My friend works with ACS (I actually used to work with him there, so I'm not unfamiliar with ACS myself). I picked up a few tidbits from poking around ACS with him:

ACS uses the term "general ledger" for what I've been calling the journal.
ACS has transactions which are composed of one or more debits and credits.
Each transaction has a source which is separate from the accounts in the chart of accounts, as well as a reference number, a date, an explanation, a user, and a couple other things. Source is things like JRE (journal record entry) and CHK (check).
Each debit and credit has its own description.
Day to day activity takes place in "modules" like contributions, accounts payable, and accounts receivable.
Actions performed in the modules have some moderately obfuscated effect on the general ledger.
It seems that the reference number ties together the general ledger with information in the modules—the GL doesn't know about names of donors, for example, but a given $20 contribution will be available in both the GL and Contributions with a reference number tying them together.

The upshot is that we're building something roughly parallel to ACS. It'd be more helpful to talk to a designer or developer of (something like) ACS than a user of ACS.

I met with a CPA (https://github.com/gratipay/inside.gratipay.com/issues/285). Tidbits from our initial conversation:

We're on the right track here.
Modern accounting uses "[general] ledger" to refer to the entire list of transactions, while a "journal" is a partial record ("a payroll journal"). This confirms what my friend said the other day, too. s/journal/ledger
Transactions encompass one or more debits and credits.
The payment method (exchange route: CC, PayPal) wouldn't touch the chart of accounts; that could just be a variable in the ledger ("source/destination of funds").
PA has a statue against earning interest on escrow. It's aimed at lawyers.

Next steps:
[ ] map out all of the things we need to account for and how we currently account for them
[ ] refactor each thing in terms of double-entry accounting (chart of accounts + ledger)
[ ] meet with our CPA again to review our design

Thanks for the meeting today, Peter. I'm excited to work with you to design a system for Gratipay that follows proper accounting procedures. As a next step, could we schedule a two-hour meeting for the week of August 9? Monday or Wednesday morning would work best for me that week. Do either of those work for you?

Great meeting you today and I look forward to our next meeting.

Let me get back to you by tomorrow morning on the dates you mentioned.

Thanks

Putting a plan together here ... October 9 is our deadline we're working against. Stepping back, it's going to make more sense for us to focus on other balls in the air during August, and hit the accounting system refactor in September. Can I get in touch with you in a few weeks to schedule our next meeting for some time in early- to mid-September?

(because https://github.com/gratipay/inside.gratipay.com/issues/290#issuecomment-126128718)

Picking up in https://github.com/gratipay/gratipay.com/pull/3653.


updated the image transition

" Resolves #3 "
Fixed image sequencing to ensure proper circular navigation
Did  z-index to prevent image clashing behind center image
Optimized image visibility states  TO left, center, right positions
Verified smooth transitions when clicking left/right images
Confirmed no image overlapping occurs behind center image
Tested  rotation through all 5 images

Please do write : " Resolves #3 "

Yeah
Updated the description with Resolves #3
and even deployed to my branch named update-image-transition
I deployed it using the GitHub pages
The deployed link is https://priyansh-narang2308.github.io/TN-Tourism.github.io/

Yeah Updated the description with Resolves #3 and even deployed to my branch named update-image-transition I deployed it using the GitHub pages The deployed link is https://priyansh-narang2308.github.io/TN-Tourism.github.io/

Good Job !!

So will my bounties be updated?

So will my bounties be updated?

soon it will be updated.

/bounty 25 @priyansh-narang2308


Thresholding 4D Tensors

In https://github.com/NervanaSystems/distiller/blob/c2a429374f424ab357f55fd89d9d0d9289a570fe/distiller/thresholding.py#L90 Is the comparison operation Reversed?
My understanding is that, If the mean or the max is greater than the threshold, We would expect to have zeros in the mask.

Hi Vinu,
This is an interesting question, but the short answer is: no, the comparison operation is not reversed.  Following your question I've read thru the code again, and I think more documentation about the mask would help.
This is the code that uses the mask and you can see here:
https://github.com/NervanaSystems/distiller/blob/master/distiller/scheduler.py#L50
We element-wise multiply (in-place) the parameters tensor by the (binary) mask tensor.  This effectively removes (zeroes) coefficients that have a corresponding zero in same index in the mask, and leaves the other coefficients untouched.
When we threshold, for example in:
https://github.com/NervanaSystems/distiller/blob/master/distiller/thresholding.py#L122
We use (torch.gt)[https://pytorch.org/docs/stable/torch.html#torch.gt] which returns

A torch.ByteTensor containing a 1 at each location where comparison is true

https://github.com/NervanaSystems/distiller/blob/master/distiller/thresholding.py#L90:L91 can return a tensor of all 1's, or a None (which is what I chose to do).
I hope this clears things up.

Thanks!


Getting id of active node

Hi, in the full futuristic example found here, the onclick events for the buttoms have the node id hard coded:
  <button onclick='chart.setHighlighted("O-6162").render()'  class="btn btn-action-button waves-effect waves-light">
        <i class="fas fa-highlighter"></i> mark</button

Is there are way so that the last known active id, eg a node that has just been expanded, can be referenced in an onclick event? I might be missing something simple here, but any help would be appreciated.

I don't think that there is a straightforward way to do it.
As I can see you have two workarounds
Workaround . in the node update function add an additional custom event listener for the button content and save activeNode reference in external variable
 let activeNode;

 chart.nodeUpdate(function(){
   d3.select(this).select('.node-button-g').on('click.active-node',d=>{
      activeNode = d;
    })
})


[Android][Button Icon rendering] [Button icons size, too big and not controllable]

Platform
What platform is your issue or question related to? (Delete other platforms).

Android

Author or host
HOST
Version of SDK
1.2.6
Details
For icons placed on the left of the title in a button, the image appears too large and further the size is not controllable using the host config. The icons rendered on web are a lot smaller.
Following screenshots illustrate the issue. They are for the below mentioned Json
{ 	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json", 	"type": "AdaptiveCard", 	"version": "1.0", 	"body": [ 		{ 			"type": "TextBlock", 			"text": "This card's action will open a URL" 		} 	], 	"actions": [ 		{ 			"type": "Action.OpenUrl", 			"title": "Action.OpenUrl", 			"url": "https://adaptivecards.io", 			"iconUrl": "https://adaptivecards.io/content/cats/1.png" 		} 	] }
As rendered on web

As rendered on android

@almedina-ms can you please take a look to investigate? Thanks! @nesalang FYI.

Can it be in v1.2.6 @shalinijoshi19  pls. ?

Yes. @almedina-ms any update on this one?


envsubst: command not found

$ envsubst < config_files/pri_region_eksctl_template.yaml | eksctl create cluster -f -
When i run above, i get below error-
-bash: envsubst: command not found
Error: loading config file "-": Object 'Kind' is missing in ''

You may want to first install gettext. Pleaes add a note in the repo to install it-
sudo yum install -y gettext

Fixed.


[Bug]:  Opensearch build workflow flaky, creating multiple issues on Plugin repos

Describe the bug
When OS builds are triggered the workflow fails intermittently and cuts issue on plugin repos, the issues are then resolved in next run. When the next run happens a new issue is created.
129 issues have been cut so far https://github.com/opensearch-project/cross-cluster-replication/issues?q=is%3Aissue++[AUTOCUT]+Distribution+Build+Failed+for+cross-cluster-replication-3.0.0+
https://build.ci.opensearch.org/job/distribution-build-opensearch/8674/consoleFull
On CCR
* What went wrong:
Could not open settings generic class cache for settings file '/tmp/tmpf5abke27/cross-cluster-replication/settings.gradle' (/usr/share/opensearch/.gradle/caches/7.6.1/scripts/86cxd8y0mmz3g16wn40v6nbpn).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 64

on K-nn
* What went wrong:
Could not open settings generic class cache for settings file '/tmp/tmp4l9pm7bs/k-NN/settings.gradle' (/usr/share/opensearch/.gradle/caches/7.6.1/scripts/1b6isqorp8hfaws3ypmmtcmnx).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 64

Could you please confirm if the issues are actionable by plugin maintainers ?
How can we address the falky nature of this build ?
To reproduce

Expected behavior
No response
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

Hi @monusingh-1
The builds are not flaky but the way GH create issue is written is buggy. As per my analysis this is the culprit: https://github.com/opensearch-project/opensearch-build/blob/main/manifests/3.0.0/opensearch-3.0.0.yml#L9
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L645
Looks like our infra is building on different java versions for linux and windows.
Since plugins did not upgrade to jdk 20 everything fails on linux which is legit.
However, (I think and pretty sure) on windows it finds compatible java version and builds itself successfully closing all the GH issues for all below components that are and should be broken today:
++ scoop list jdk
++ grep 20
++ head -1
++ cut -d ' ' -f1
+ scoop reset openjdk14
Resetting openjdk14 (14.0.2-12).

2023-10-17 13:11:57 ERROR    Failed plugins are ['opensearch-reports', 'performance-analyzer', 'opensearch-observability', 'k-NN', 'neural-search', 'geospatial', 'cross-cluster-replication', 'sql', 'asynchronous-search']

@peterzhuamazon  created a PR to fix these recently. However, the failures are right. The error mentioned by you is java incompatible error (have seen that before).
Thanks!

I think the above PR the false positive. 3.0.0 is building right now https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/8677/pipeline/75 and I can see geospatial plugin failing on windows similar to linux (it was not happening before). Will create an issue to fix the GH creation logic.
Thanks!

Created issue to add more details to GH issue https://github.com/opensearch-project/opensearch-build/issues/4155
Closing this issue.