port existing code

From fish passage model, extract code/logic that:

finds intersection points
removes duplicates within a set threshold (currently 10m) within the same source
removes duplicates between sources, retaining crossing from the higher priority source
labels bridges
match output to existing output layer and transfer existing unique ids to new layer

This can probably all be rolled into a small number of sql files.
Note that DRA has changed, update to use transport_lines table

wrong issue tagged in commit


blackbox and upsert seems to be broken when used together

Lets say my schema is :
  data: {
    type: Object,
    blackbox: true
  },
  other_data : {
      type : String,
   }

and i attached it to meteor collection using collection2 atmosphere package.
Now im trying to perform upsert operation by :
myCollection.upsert({
   { 'data.id' : 'whatEverYouWant},
   { $set : { other_data : 'WhatAPerfectWorld' }}
})

i see error like this : Error: data.id is not allowed by the schema (data.id)
Any idea ?

You said in your schema that it's an object but in your example you are passing in a string?

@zenweasel
other_data is String but data is blackbox object. So expected effect of upsert operation in case of insert should be insert of :
{ data : {id : 'whatEverYouWant'}, {other_data : 'WhatAPerfectWorld'}}

Shouldn't the 'data.id' part also be in the $set operation?
myCollection.upsert(someIdOrSelector, {
  $set: {
    'data.id' : 'whatEverYouWant,
    other_data : 'WhatAPerfectWorld'
  }
});

The snippet you posted has a couple of syntax errors to begin with, so can you post the real code that isn't working for you?

@aldeed  why you added question label? Upsert throws schema error, when in fact document that should be inserted by upsert match the schema. Its huge bug.
@coagmano  there were by my mistake to many {} i adjusted, now snippet is ok.

@pociej It seems unlikely that this is a bug with this package. It appears that you're using collection2 package, so it could be a bug with that or with your code.
When you upsert, Collection2 modifies your modifier object before validating it, adding everything from the query to the $set, because that's what MongoDB does if it ends up doing an insert. But when I run a test for the resulting object against this package, it seems to be fine:
  it('issue 325', function () {
    const schema = new SimpleSchema({
      data: {
        type: Object,
        blackbox: true,
      },
      other_data: String,
    });

    expect(function () {
      schema.validate({
        $set: {
          'data.id': 'whatEverYouWant',
          other_data: 'WhatAPerfectWorld',
        },
      }, { modifier: true, upsert: true });
    }).toNotThrow();
  });

If this test exactly matches your code (blackbox is not misspelled, is properly set to true, etc.), then we'd have to dig into what the collection2 package is doing to see if there's a bug on that side. And of course make sure you're using the latest release of both packages.

So do you want me to open issue under collection2 repo? You are owner of both this and collection2 right @aldeed ? Should i create working reproduction minimal app?

@pociej A reproduction in a minimal app will be the quickest route to find a solution. Please post a link to the public repo for that here and then I'll let you know the best way to proceed from there.


An Ecommerce website for shoes

This is an E-commerce website for shoes

Ecommerce website for shoes which contains 5 pages

keep it up


Item automation should be able to insert and extract screen modules

Not really a "bug" per say but I don't see a reason why it shouldn't work.
Issue description:
Screen does not allow extraction of modules to ME storage bus
Steps to reproduce:
attach storage bus to a screen, try to use a terminal to pull modules out.
Versions:

Minecraft: 1.12
Forge: 2624
McJtyLib:2.6.5
RFTools:7.30
RFToolsControl:1.8.0

So it looks like items can go in, but can't come back out, and when they do go in, the screen doesn't update until you open its GUI. Does this match what you're seeing?

Indeed


Make $column and $gutter not use modular-scale

The modular-scale functions are just complicating what is essentially a 3 to 1 ratio. Adding the function is unnecessarily complicating the code.
$column: 3em !default;
$gutter: 1em !default;

:+1: There’s been chatter about decoupling Bourbon from Neat. There’s only a few small functions and mixins from Bourbon that Neat uses, all them are non-essential (related PR). Removing modular-scale would be trivial.

Really like this idea, and I’d be interested in helping. I was maintaining Straight Up, which was Neat without Bourbon, and it worked quite well. It’s nice to avoid the extra dependency if you’re using Autoprefixer.


Handle includes in pre- and post-deployment scripts (fixes #23)

I'm expecting there may be a lot of feedback and proposed changes here, as this goes beyond my comfort zone for dotnet development. I've broken this into a few commits in case we want to replace some of the work.

I've added a number of unit tests, but I think I'll look at adding a postdeployment script to one of the pipeline tests as well. I'll work on that while waiting for review.

@jeffrosenberg On reviewing it another time I found a couple of more things. Sorry about that ;).

@jmezach no problem!

@ErikEJ Can you take a look at this as well?

I will this evening

@jeffrosenberg Did you manage to add a test project to the CI pipeline so that we can make sure that works as expected on every change?

@jmezach I didn't add a new test project, but I did add two changes to TestProjectWithSDKRef that I think should be satisfactory for CI testing, let me know if you disagree.
https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/pull/61/files#diff-d8d31a2c069adda9b8a4b6d9ca05c661
https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/pull/61/files#diff-65850b3cc354d04c0e4395d2478e7161

@jeffrosenberg Ah, yes, that will work. I was looking for a change to the CI pipeline, but that isn't necessary if we added it to the existing project.
I guess we're good to go here then. Right @jeffrosenberg @ErikEJ?

I think so!

Agree :shipit:

Awesome. I'll get this merged and released as 1.8.0. Thanks again @jeffrosenberg for your work on this. This is probably our most requested feature currently ;).


Tab-content does not reload when switching components

When switching components in Storybook, the Zeplin tab does still show the Zeplin image of the previously selected component instead of reloading and showing the image of the currently selected component.
This behaviour starts to happen only when a Zeplin links/image has been selected via the dropdown and will remain until a manual page reload.

@kaiiiib Thanks for reporting this. It should be fixed with v1.3.0.


Manganoto not working

I downloaded the most recent version, manganoto still fails

You'll need to change the url for your manganato entries as they're on chapmanganato.to now instead of readmanganato.com


imp module pending deprecation warning

Hi I got this warning when using pysnmp
I use python3.5.6 with pysnmp 4.4.9
pysnmp/smi/builder.py:9: PendingDeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

This is something I've been seeing as well. There is probably just some old code that needs to be updated. Should be fairly straightforward since IIRC there aren't many differences between imp and importlib.

Commit https://github.com/etingof/pysnmp/commit/c3d6619176a108758e1c7f0622cb64766471b27d in the release-4.4.10 branch should have fixed this.


Simplify VrSdk

Do some of what is suggested in the comment. Simplify VrSdk to make further refactoring and development easier.
    //
    // The VrSdk is an abstraction over the actual VR hardware and SDK. It is responsible for:
    //
    //   * Initializating the VR system, cameras, controllers and associated state.
    //   * Providing hardware- and SDK-specific controls via a non-specific interface.
    //   * Providing abstract access to events sent from the SDK.
    //   * Exposing an interface to query Hardware and SDK capabilities.
    //
    // TODO: In its current form, the VrSdk is monolithic, though it should ultimately be
    // broken out into hardware- and SDK-specific modules, which can be loaded and unloaded at startup
    // or build time.
    //

    //   - Distribution
    //       - Build
    //           - SDK
    //           * Platform - Win32/64, Android, iOS.
    //           * Options
    //                * Experimental
    //           * Config
    //               * Develop
    //               * Profile
    //               * Release
    //       - Device
    //           - Overlay
    //           - Controller

The structure above is more modular. If there is a "distribution" above the SDK then the architecture can be specialised for a target store/platform, e.g. Store features/analytics/content. Additionally, multiple SDKs could be used for target builds whilst the OpenXR complications sort themselves out.

This has been partially done through the work of moving to UnityXR, but a few bits remain w.r.t monoscopic mode, and there's still controller specific choices made that should ideally be moved to some sort of abstract class. let's bump this issue to after xr_v2 is merged when we've got a new baseline.


Update UniformGridLayoutState.cs

Corrected implementation for
UniformGridLayout ItemsStretch Fill and Uniform
What does the pull request do?
Fixes the behavior for the use of remaining space in UniformGridLayout when ItemsStretch is set to Fill or Uniform.
Given this code:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="AvaloniaApplication2.MainWindow"
        Title="AvaloniaApplication2">
    <ScrollViewer HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
        <ItemsRepeater Name="m_Items">
            <ItemsRepeater.Layout>
                <UniformGridLayout Orientation="Horizontal"
                                   MinColumnSpacing="5"
                                   MinRowSpacing="5"
                                   MinItemHeight="210"
                                   MinItemWidth="210"
                                   ItemsStretch="Uniform" />
            </ItemsRepeater.Layout>
            <ItemsRepeater.ItemTemplate>
                <DataTemplate>
                    <Grid>
                        <Border CornerRadius="5" Background="{DynamicResource SystemAccentColor}">
                            <TextBlock HorizontalAlignment="Center" VerticalAlignment="Center" Text="{Binding}" />
                        </Border>
                    </Grid>
                </DataTemplate>
            </ItemsRepeater.ItemTemplate>
        </ItemsRepeater>
    </ScrollViewer>
</Window>

m_Items.Items = Enumerable.Range(1, 12).ToList();

This is the current behavior:

My understanding is that the black space to the right of items 4, 8 and 12 should not be there; rather it should be taken by all 12 of the items.
Please see my comment on the related issue for additional details.
Related issue
What is the current behavior?
See above screenshot.
What is the updated/expected behavior with this PR?
The above example will continuously have the 12 items take the full width of the window.
How was the solution implemented (if it's not obvious)?
Short code fix in UniformGridLayoutState::SetSize.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

N/A
Breaking changes
N/A
Obsoletions / Deprecations
N/A
Fixed issues
Fixes #7175

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: out4blood88 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

You can test this PR using the following package version. 11.0.999-cibuild0025765-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Here's the result of the same program using the above artifact:


[schema cli] correct arrays

There was a bug in the traverse code and it resulted in never printing array values.
Fix: https://github.com/knative/hack/issues/57

/lgtm

/approve


Add Travis CI integration, fix image spacing in docs

Adds .travis.yml with Coveralls integration
Fixes a spacing issue that wasn't worth its own PR

Ha! I inadvertently tested my check-docs test :)


allow external db

This changes allow for an external DB to be setup. In our case we have a managed DB from our cloud provider that we want to use.

Thank you!


Support for retrieving directories

Right now ipget bails with this dag node is a directory.

This works now that we're using https://github.com/noffle/fallback-ipfs-shell.


fp16 conv2d numerical inaccuracy

This is a blocker for true fp16 usage in onnx.
This inaccuracy is also exacerbated when the output is used as input for other ops
for instance this conv->elu->conv->... at the start of openpilot (output of elu is used as input for the next conv)
# 0: op "Conv" input shapes [(1, 12, 128, 256), (32, 12, 3, 3), (32,)] opt {'dilations': (1, 1), 'group': 1, 'kernel_shape': (3, 3), 'pads': (1, 1, 1, 1), 'strides': (2, 2)}
# 1: op "Elu" input shapes [(1, 32, 64, 128)] opt {'alpha': 1.0}
# 2: op "Conv" input shapes [(1, 32, 64, 128), (32, 1, 3, 3), (32,)] opt {'dilations': (1, 1), 'group': 32, 'kernel_shape': (3, 3), 'pads': (1, 1, 1, 1), 'strides': (1, 1)}
# 3: op "Elu" input shapes [(1, 32, 64, 128)] opt {'alpha': 1.0}
# 4: op "Conv" input shapes [(1, 32, 64, 128), (16, 32, 1, 1), (16,)] opt {'dilations': (1, 1), 'group': 1, 'kernel_shape': (1, 1), 'pads': (0, 0, 0, 0), 'strides': (1, 1)}
# 5: op "Conv" input shapes [(1, 16, 64, 128), (16, 1, 3, 3), (16,)] opt {'dilations': (1, 1), 'group': 16, 'kernel_shape': (3, 3), 'pads': (1, 1, 1, 1), 'strides': (1, 1)}
# 6: op "Elu" input shapes [(1, 16, 64, 128)] opt {'alpha': 1.0}
# 7: op "Conv" input shapes [(1, 16, 64, 128), (16, 16, 1, 1), (16,)] opt {'dilations': (1, 1), 'group': 1, 'kernel_shape': (1, 1), 'pads': (0, 0, 0, 0), 'strides': (1, 1)}
...

caught this using a little verifier I wrote where I compare outputs to torch onnx for each op
for openpilot in particular, after the 7th conv op, rtol=2e-3, atol=2e-3 (rtol atol for external_model_benchmark.py) is already violated.
not too sure whats the right thing to do here.

it might also be affected by hand_coded_optimization, i think these are better put into their own test file with more focus on numerical issues

is torch on gpu different from torch on cpu

Yeah it's about a rtol=1e-3 atol=1e-3 difference (tested on colab)

i think it's less of an issue if tinygrad in float matches tinygrad in half with small tol

it's rtol=2e-2, atol=2e-2 big :(

it might also be affected by hand_coded_optimization

Yeah there's also a smaller rtol=2e-3 atol=2e-3 difference

inaccuracies will probably accumulate as sizes get bigger also.


Model Y LR battery capacity incorrectly reporting after 1.28.5 update

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
After updating to 1.28.5 Battery Health reports battery capacity as 88kWh (up from ~78kWh) for both 'as new' and current. It was reporting correctly before the update. This is a Model Y LR 2024, Berlin build

I can provide any logs that are necessary, just not sure what I should provide at this point.
Expected Behavior
Battery capacity to be reported correctly (~78kWh)
Steps To Reproduce
No response
Relevant log output
eslamate-1  | 2024-03-28 10:47:06.494 car_id=1 [error] Error / :unknown
teslamate-1  | 2024-03-28 10:47:30.368 car_id=1 [info] Suspending logging
teslamate-1  | 2024-03-28 10:50:38.862 [info] Refreshing access token ...
teslamate-1  | 2024-03-28 10:50:39.252 [info] POST https://auth.tesla.com/oauth2/v3/token -> 200 (377.156 ms)
teslamate-1  | 2024-03-28 10:50:39.294 [info] Scheduling token refresh in 6 h
teslamate-1  | 2024-03-28 10:53:39.132 [notice]     :alarm_handler: {:clear, TeslaMate.Vehicles.Vehicle_1_api_error}
teslamate-1  | 2024-03-28 10:55:09.011 car_id=1 [info] Fetching vehicle state ...
teslamate-1  | 2024-03-28 10:55:09.290 car_id=1 [info] Start / :asleep
teslamate-1  | 2024-03-28 10:55:09.336 car_id=1 [info] Disconnecting ...
teslamate-1  | 2024-03-28 11:01:20.598 car_id=1 [info] Start / :online
teslamate-1  | 2024-03-28 11:01:20.667 car_id=1 [info] Connecting ...
teslamate-1  | 2024-03-28 11:04:21.821 car_id=1 [info] Suspending logging
teslamate-1  | 2024-03-28 11:13:32.293 [info] Streaming API: Vehicle offline
teslamate-1  | 2024-03-28 11:13:32.293 car_id=1 [warning] Stream reports vehicle as offline, fetching vehicle state ...
teslamate-1  | 2024-03-28 11:13:32.479 car_id=1 [info] Start / :offline
teslamate-1  | 2024-03-28 11:13:32.527 car_id=1 [info] Disconnecting ...
teslamate-1  | 2024-03-28 11:13:52.661 car_id=1 [info] Start / :asleep
teslamate-1  | 2024-03-28 11:50:15.972 [info] GET /
teslamate-1  | 2024-03-28 11:50:16.113 [info] Sent 200 in 132ms
teslamate-1  | 2024-03-28 11:50:21.021 [info] GET /settings
teslamate-1  | 2024-03-28 11:50:21.097 [info] Sent 200 in 76ms

Screenshots

Additional data
No response
Type of installation
Docker
Version
v1.28.5

Can you downgrade TeslaMate and provide a screenshot of 1.28.4 showing a different battery capacity?

Can you downgrade TeslaMate and provide a screenshot of 1.28.4 showing a different battery capacity?

Just tried that, unfortunately the incorrect capacity remained after the downgrade. Looks like the change is now stuck in the database/grafana? I only downgraded the teslamate instance though.

I only downgraded the teslamate instance though.

You need to downgrade teslamate grafana image to test with old dashboard.
@jheredianet can you look into this? Ty.

I only downgraded the teslamate instance though.

You need to downgrade teslamate grafana image to test with old dashboard.
@jheredianet can you look into this? Ty.

Downgraded both the grafana and teslamte instance, battery health appears to be normal now:

Downgraded both the grafana and teslamte instance, battery health appears to be normal now:

Thanks for testing and confirmation.
jheredianet will look into it

Downgraded both the Grafana and Teslamate instance, battery health appears to be normal now:

Hi, this is curious :-)

Is it the name of your car, or you have uncomplete data? Just in case verify that in your "cars" table you have only one car.
About the estimations, please could you show a screenshot of your "Efficiency dashboard", since all estimations comes from there, and please, just stay with the last version on Teslamate and Grafana.
If you could manage, please run this query and let me know what values do you get (assuming that your car_id is 1, if not change it accordantly):
	SELECT  		car_id,  		COALESCE(efficiency, (SELECT efficiency FROM cars WHERE id = 1) * 100.0) AS efficiency 	FROM ( 		SELECT  			(charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric * 100.0 AS efficiency, 			count(*) AS count, 			1 AS car_id  		FROM  charging_processes  		WHERE car_id = 1   			AND duration_min > 10   			AND end_battery_level <= 95   			AND start_rated_range_km IS NOT NULL   			AND end_rated_range_km IS NOT NULL   			AND charge_energy_added > 0.01 		GROUP BY  1 		ORDER BY  2 DESC, 1 DESC 		LIMIT 1 	) AS DerivatedEfficiency
With that information, I may try to dig further where is the misreading is coming from.

Downgraded both the Grafana and Teslamate instance, battery health appears to be normal now:

Hi, this is curious :-)
Is it the name of your car, or you have uncomplete data? Just in case verify that in your "cars" table you have only one car.
About the estimations, please could you show a screenshot of your "Efficiency dashboard", since all estimations comes from there, and please, just stay with the last version on Teslamate and Grafana.
If you could manage, please run this query and let me know what values do you get (assuming that your car_id is 1, if not change it accordantly):
SELECT car_id, COALESCE(efficiency, (SELECT efficiency FROM cars WHERE id = 1) * 100.0) AS efficiency FROM ( SELECT (charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric * 100.0 AS efficiency, count(*) AS count, 1 AS car_id FROM charging_processes WHERE car_id = 1 AND duration_min > 10 AND end_battery_level <= 95 AND start_rated_range_km IS NOT NULL AND end_rated_range_km IS NOT NULL AND charge_energy_added > 0.01 GROUP BY 1 ORDER BY 2 DESC, 1 DESC LIMIT 1 ) AS DerivatedEfficiency
With that information, I may try to dig further where is the misreading is coming from.

I only have one car to the best of my knowledge! Here's the output of 'SELECT * FROM cars;'
id |       eid       |       vid        | model | efficiency |     inserted_at     |     updated_at      |        vin        | name | trim_badging | settings_id |  exterior_color   | spoiler_type | wheel_type | display_priority | marketing_name
----+-----------------+------------------+-------+------------+---------------------+---------------------+-------------------+------+--------------+-------------+-------------------+--------------+------------+------------------+----------------
1 |<PHONE_NUMBER>57283 |<PHONE_NUMBER>741986 | Y     |     0.1491 | 2024-01-13 19:23:55 | 2024-01-26 11:32:05 | XP7Y************* |      | 74D          |           1 | MidnightCherryRed | None         | Apollo19   |                1 | LR AWD
(1 row)
I tried to run the query however received an error:
teslamate=# SELECT  car_id,  COALESCE(efficiency, (SELECT efficiency FROM cars WHERE id = 1) * 100.0) AS efficiency FROM ( SELECT  (charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric * 100.0 AS efficiency, count() AS count, 1 AS car_id  FROM  charging_processes  WHERE car_id = 1   AND duration_min > 10   AND end_battery_level <= 95   AND start_rated_range_km IS NOT NULL   AND end_rated_range_km IS NOT NULL   AND charge_energy_added > 0.01 GROUP BY  1 ORDER BY  2 DESC, 1 DESC LIMIT 1 ) AS DerivatedEfficiency
SELECT  car_id,  COALESCE(efficiency, (SELECT efficiency FROM cars WHERE id = 1) * 100.0) AS efficiency FROM ( SELECT  (charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric * 100.0 AS efficiency, count() AS count, 1 AS car_id  FROM  charging_processes  WHERE car_id = 1   AND duration_min > 10   AND end_battery_level <= 95   AND start_rated_range_km IS NOT NULL   AND end_rated_range_km IS NOT NULL   AND charge_energy_added > 0.01 GROUP BY  1 ORDER BY  2 DESC, 1 DESC LIMIT 1 ) AS DerivatedEfficiency;
ERROR:  syntax error at or near "SELECT"
LINE 2: SELECT  car_id,  COALESCE(efficiency, (SELECT efficiency FRO...
^
teslamate=#
I was trying to do it from terminal, I could try to connect to the database with SQL software, but I think I'll need to expose additional ports on my docker compose file?
Here is efficiency dashboard:

@jheredianet Here's results of the query you asked for

I only have one car to the best of my knowledge! Here's the output of 'SELECT * FROM cars;' id | eid | vid | model | efficiency | inserted_at | updated_at | vin | name | trim_badging | settings_id | exterior_color | spoiler_type | wheel_type | display_priority | marketing_name ----+-----------------+------------------+-------+------------+---------------------+---------------------+-------------------+------+--------------+-------------+-------------------+--------------+------------+------------------+---------------- 1 |<PHONE_NUMBER>57283 |<PHONE_NUMBER>741986 | Y | 0.1491 | 2024-01-13 19:23:55 | 2024-01-26 11:32:05 | XP7Y************* | | 74D | 1 | MidnightCherryRed | None | Apollo19 | 1 | LR AWD (1 row)

About this, you can see that your car name is empty:

You can edit the table to put the correct name (if you want, it's optional). At the moment the car was registered in your Tesla account, something must have happened that did not capture that information correctly.
About rest, let me analyze in your next post.

@jheredianet Here's results of the query you asked for

So, this is the wrong part, here you get 16.72 and in the efficiency dashboard 14.9 ....
Let me analyze further and I'll get back to you soon...

@AldasG I think I found the bug. Please could you run the following query?
SELECT      car_id, 		COALESCE(efficiency,  		(SELECT efficiency 			FROM cars WHERE id = 1) * 100) AS efficiency 	FROM ( 		SELECT ROUND((charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric, 3) * 100 as efficiency, 			COUNT(*) as count, 1 AS car_id  		FROM charging_processes 		WHERE car_id = 1 			AND duration_min > 10 			AND end_battery_level <= 95 			AND start_rated_range_km IS NOT NULL 			AND end_rated_range_km IS NOT NULL 			AND charge_energy_added > 0 		GROUP BY 1 		ORDER BY 2 DESC 		LIMIT 1 	) AS DerivatedEfficiency

SELECT car_id, COALESCE(efficiency, (SELECT efficiency FROM cars WHERE id = 1) * 100) AS efficiency FROM ( SELECT ROUND((charge_energy_added / NULLIF(end_rated_range_km - start_rated_range_km, 0))::numeric, 3) * 100 as efficiency, COUNT(*) as count, 1 AS car_id FROM charging_processes WHERE car_id = 1 AND duration_min > 10 AND end_battery_level <= 95 AND start_rated_range_km IS NOT NULL AND end_rated_range_km IS NOT NULL AND charge_energy_added > 0 GROUP BY 1 ORDER BY 2 DESC LIMIT 1 ) AS DerivatedEfficiency

Sure, here you go

Ok, now it's ok. I will make a PR with the fix. Thanks for reporting the bug.

Ok, now it's ok. I will make a PR with the fix. Thanks for reporting the bug.

Great, let me know if there’s anything else I can test out/provide


Unimplemented abstract methods don't raise error unless called

abstract class A
  abstract def a
end

class B < A
end

Compiles just fine even though B doesn't implement A's abstract method a. The error only shows up when you call a on B's instance. In my opinion, when a class inherits from another class, it should be obliged to implement it's methods. The current behavior may lead to bugs going undetected especially for libraries (where methods may not be called on every object in the library itself).
I know this may go against the language's philosophy and would like to hear opinions.

This is a valid enhancement.
We originally introduced abstract methods because in Ruby there's no such thing and people either: 1. document them in comments but it's not very nice or 2. implement them and raise "this method must be implemented" or a variant of that. In Ruby it doesn't matter much because it's always a runtime error. In Crystal we wanted to standarize this, so you document methods that must be implemented like this. However, we didn't add the "is implemented by all subclasses?" check because it might be expensive, but we don't know. I think it's worth trying adding it.
However, Object=~ is documented as abstract and not every class implements it, so I guess we'll have to document that somewhere else.

This strikes me with idea of having 2 levels of abstract methods:

could implement :method_a,
must implement :method_b.

Might be good or might be bad idea. Your thoughts?
On Jun 21, 2015 10:26 PM, "Ary Borenszweig"<EMAIL_ADDRESS>wrote:

This is a valid enhancement.
We originally introduced abstract methods because in Ruby there's no such
thing and people either: 1. document them in comments but it's not very
nice or 2. implement them and raise "this method must be implemented" or a
variant of that. In Ruby it doesn't matter much because it's always a
runtime error. In Crystal we wanted to standarize this, so you document
methods that must be implemented like this. However, we didn't add the "is
implemented by all subclasses?" check because it might be expensive, but we
don't know. I think it's worth trying adding it.
However, Object=~
http://crystal-lang.org/api/Object.html#%3D~(other)-instance-method
is documented as abstract and not every class implements it, so I guess
we'll have to document that somewhere else
http://crystal-lang.org/docs/syntax_and_semantics/operators.html.
—
Reply to this email directly or view it on GitHub
https://github.com/manastech/crystal/issues/835#issuecomment-113953438.

I'd say just redeclaring the abstract method should count as definition towards the parent, that way we don't need to add a keyword.

Please don't require all abstract methods to be implemented.  Many classes declare abstract methods that are not used aren't in the program.
Example:
BufferedIOMixin has read, write, flush, close, rewind as abstract methods.
Many times the specific instance will only need read OR write, not both.
Flush, close and rewind may not be used at all.
  Neither is useful and the source ends up cluttered.

@dhruvrajvanshi I reopened, this is a valid issue.
What @technorama is partially right, but not quite. For example if you have:
ios = [] of IO
ios.each &.write(...)

then the compiler will require all IO types to have that write method. So it makes sense that abstract methods are definitely implemented, even if not used in particular cases.

Can the compiler be made smarter?  Can the compiler base the abstract requirements on the actual subtypes used rather than just the declared type?
ios = [] of IO
ios << MyIO # only contains MyIO

I would argue in favor or forcing abstract methods to be implemented by subclasses. If you end up having empty methods in them, then you either really want to do nothing (which an empty method would make more clear than just not implenting it) or your code is too cluttered which in term would force you to clean it up more and make smaller, simpler structures.
I like Go's mentality on this, interfaces really only have that what they REALLY need. If they need more than what's there, you either have to check if you want to force everything to require the new functionality as well or create something else that has this extension.
Also, why do we have the power of a compiler and a statically type-checked language to find issues early and not use it?

Doing nothing is not clear.  Did the author mean do nothing or did he create a broken untested method just to satisfy the interface?  The latter may break at runtime if you depend on it.
Many tiny interfaces solves the problem but we don't have that.  We have IO which requires read AND write.  BufferedIOMixin requires a lot more.
Why not have a smarter compiler that can see if the methods are actually used before requiring their implementation?  To me that's a smart compiler - not making me work more.

I completely agree with @asterite, since, if I use IO object then I rely that I can use it for all IO operations and will not face with situation when my IO object cannot behave like IO because of its author forgot(or decide that it needless for that implementation) to implement some methods. Thus, for cases when I need only read,write operations, I think it's better just to separate interfaces(as an option), something like this:
abstract class MyBasicIO
    abstract def read
    abstract def write
end

abstract class MyIO < MyBasicIO
    abstract def flush
    abstract def close
    abstract def rewind
end

I think such behavior will be the great improvement comparing to Ruby

Splitting IO is a separate issue from implementing ALL abstract methods.

Requiring all abstract methods breaks duck typing.
Requiring all abstract methods does NOT guarantee the implementation works when the author doesn't use the extra methods he was forced to implement but never intends to use.

Please tell me how this fake implementation of rewind is better than only giving an error if a) an abstract implementation is missing AND b) the method is actually used.
def rewind
  nil
end

The above code can lead to data loss or corruption if the implementation fakes the rewind or seek methods.  Zip files require random access reading.  Reading from the wrong location will return junk and probably crash.  Writing to the wrong location will corrupt the file.
There is a PR that starts to split IO in to different modules/interfaces in #1428 .  Some of your concerns may be handled by that.  Mine aren't.

Okey, imagine I have such method:
def some_meth(io : IO)
    ...
    io.rewind
    ...
end

Then, if we pass IO object, for which rewind is not implemented, then we receive such exception: abstract def MyIO#rewind must be implemented by DontRewindItIO. But how it can help me as to user of this weird IO object? Maybe it's better to receive exception like this : You can't rewind it since ...., and programmer which implemented this IO class should be obligated to give sensible exception or better to find reasonable way to implement all IO operations. So, as for me, it's better explicitly raise exception
def rewind
    raise "You can't rewind it since ..."
end

How would you enforce that?
You can force someone to implement a method but you can't force them to implement it correctly, especially if they have no intention of testing it.  Maybe they will raise an exception if force to implement it, or maybe they will return true, false, nil, or other.  Maybe they will attempt to implement the method but be off by 1.  Maybe they will implement seek but forget to change the position attribute.  Maybe they forget to reset the read and write buffers.
There are so many things that can go wrong, it's best to NOT force implementation.  At least then you have an accurate error method and a chance of implementing it correctly.  A fake or malfunctioning functioning method could waste hours or days of your time debugging.

But in such case we can just write
abstract class IO end

In such case we receive: undefined method 'rewind' for DontRewindItIO
instead of: abstract def MyIO#rewind must be implemented by DontRewindItIO
And for user of this IO object it's actually all the same! Second variant is better for one who write this IO class, but for user both variants mean: "this object can't respond to rewind method". Moreover, it's weird behavior for any object of any type when some method from API is useless, I think it sign what you need redesign program.
Maybe they will raise an exception if force to implement it, or maybe they will return true, false, nil, or other. Maybe they will attempt to implement the method but be off by 1. Maybe they will implement seek but forget to change the position attribute. Maybe they forget to reset the read and write buffers. -  There is no programming language that can entirely save programmer from mistakes.

Your examples are not the same.  Best case scenarios are the same but worst case scenarios are very different.
If all methods are required
User's perspective if implemented correctly
Everything works.
User's libraries perspective if implemented incorrectly
Anything can go wrong.  Instead of a helpful "method missing" error the program may crash, refuse to compile for other reasons, corrupt data, fail nil checks or other.
Library developer's perspective
There is always an error.  They may put in junk just to make the error go away.  Worse they may add a method that is incorrect or doesn't work that they never test.
If methods are not required
User's perspective if implemented
Everything works.
User's perspective if not implemented
The user receives a method missing error.  At least he know what that means and can look in to writing a method.
Library developer's perspective
The library appears to work and they go on their way.  Good authors will fill in all available methods and raise when the operation is not possible.
When the author is experienced, thorough and writes complete tests both situations are the same.  When author quality is lacking the results are very different.

I think second variant (methods are not required) is good enough from perspective of dynamic programming language(here Ruby), but, as @kumpelblase2 has mentioned, why we can't use all benefits what can give us static typing? Why we should do those ugly(from my perspective) runtime-checks like
def meth(io : IO)
    if io.responds_to? :rewind # read, write, anything...
    ...
    end
    # or
    if io.is_a? RewindMeIO
    ...
    end
end

whereas we can use abilities of static typing and do like this:
first variant (methods are required)
module IO
   abstract def read
   abstract def write
   abstract def rewind
   ...
end

# IO for which rewind make no sense, and we deliberately
# create new IO type that can't be rewound
class SomeIOThatCannotBeRewoundIO
    include IO

    def read(...)
        reasonably implement this method
    end

    def rewind(...)
        raise "You can't rewind it since ..."
    end

    def write(...)
        reasonably implement this method
    end
    ...
end

# I don't need a common (full-fledged) IO object, I need
# some specific IO object that cannot be rewound, and I realize
# that 'rewind' SHOULD NOT BE USED HERE.
def some_meth(io : SomeIOThatCannotBeRewoundIO)
    ...
end
# or
# here compiler guaranties me (in compile time) that object in 'arr' can't be rewound(reasonably)
arr = [] as SomeIOThatCannotBeRewoundIO
arr.each &.rewind

I think it makes my code much more expressive and sensible, moreover, we no need make runtime-checking, all it's done in compile time. AFAIK, Crystal not aim to copy Ruby-style entirely, but instead take the better from the Ruby world and add good abilities that the static typing can provide
So, I think, programmer should not thoughtlessly stub needless methods(which is needless in its IO implementation), the new subclass(subtype) should have some meaning, and user of its those IOs should explicitly point out (if it necessary) what type of objects he need in his methods, instead of doing ugly runtime-checks or receiving abstract def MyIO#rewind must be implemented by DontRewindItIO.
If amount of stubbed methods in IO-implementation is huge then maybe API of IO is redundant, and we need separate interfaces(as I has mentioned earlier)

+1 for enforcing abstract method implementation. The worst thing right now is, that it's possible to think you've implemented an abstract method, when you actually have not. Be it a typo in the method name or a wrong arg or return type. I think enforcing it will simply enable us to write better, more robust code.
right now there's no benefit of abstract def foo over def foo end

Yes there is: documentation and better error messages, letting you know you must implement the method.

@asterite i must've missed the error messages. what do you mean?

http://play.crystal-lang.org/#/r/hdy

alright. that's good. sorry i missed that. probably wasn't trying to call the method


Vulkan portable implementation FFI

If #1102 brings us to a Vulkan-like API of the gfx_core, there is one interesting option to explore - create a C FFI layer that with Vulkan-like header (or better - an actual one from upstream) that would work with our core library.
This would allow any application targeting Vulkan to work on a variety of platforms, and will be solidly backed by our Rust implementation. Essentially, the Angle of the new era, taking on MoltenVK at the same time. The future has many use of such a layer ;)
Another absolutely crazy extension of this path is a possible use of vulkano as a high-level layer instead of gfx_render. It can just be an alternative, but convergence is great!

Wouldn't this need shader support too ?

Yes, via existing SPIRV-Cross library

On Apr 10, 2017, at 12:19, Thomas Koehler<EMAIL_ADDRESS>wrote:
Wouldn't this need shader support too ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It is happening in https://github.com/kvark/portability


dashboard: configure mgr backend before restart

We need to set the mgr dashboard server ip address before restarting the
dashboard module otherwise we can try to bind the dashboard module on an
already used address.
We already do this configuration for the dashboard port value and ssl
setup so we should do the same for server address too.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1851455
Signed-off-by: Dimitri Savineau<EMAIL_ADDRESS>

@fmount FYI

jenkins test centos-non_container-all_daemons


Hot exit: preserve unsaved edits on quitting Lapce

Is your feature request related to a problem? Please describe.
It's rather inconvenient if you have a bunch of unsaved edits in many tabs to have to save them all before quitting an editor. Especially so if you have temporary buffers where you'd need to use a file picker to save them to some file.
Describe the solution you'd like
Store unsaved edits in a database and restore it on program restart
(might also help avoiding loss if app crashes).
Describe alternatives you've considered
Saving before exiting
Additional context
You can check how great this feature is using, e.g., Sublime Text with its 'hot exit' option

related #2356

should be fixed in 0.4.0. https://github.com/lapce/lapce/releases/tag/v0.4.0

@dzhou121 it doesn't work. does it work on your machine?


Fix for clippy nightly.

See e.g. https://travis-ci.org/googlecartographer/point_cloud_viewer/jobs/591478379 why it failed in nightly.

Thanks for the review


Update wrapper to latest nightly

For the fixes required to run Gradle tests with the configuration cache enabled.
Signed-off-by: Rodrigo B. de Oliveira<EMAIL_ADDRESS>

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Rector raises Error "Child process timed out after 60 seconds"

I can't run rector process. If I specify a file, it works.
$ vendor/bin/rector process
  160/1912 [▓▓░░░░░░░░░░░░░░░░░░░░░░░░░░]   8%

 [ERROR] Could not process
         "/Users/kenji/work/codeigniter/CodeIgniter4/vendor/rector/rector/vendor/symplify/easy-paral
         lel/src/ValueObject/ParallelProcess.php" file, due to:
         "Child process timed out after 60 seconds". On line: 100

 [ERROR] Could not process some files, due to:
         "Reached system errors count limit of 20, exiting...".

rector 0.12.12
PHP 8.0.14

Workaround.
--- a/rector.php
+++ b/rector.php
@@ -59,7 +59,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {

     $parameters = $containerConfigurator->parameters();

-    $parameters->set(Option::PARALLEL, true);
+//    $parameters->set(Option::PARALLEL, true);
     // paths to refactor; solid alternative to CLI arguments
     $parameters->set(Option::PATHS, [__DIR__ . '/app', __DIR__ . '/system', __DIR__ . '/tests', __DIR__ . '/utils/Rector']);

It worked! Thanks!
$ vendor/bin/rector process
 688/688 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] Rector is done!

Thank you for verify, should be included in next rector release.

0.12.13 worked fine.


fix: rancher healthy not displayed

Signed-off-by: liuying<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #267 (2f549cf) into release-1.3 (cef056e) will not change coverage.
The diff coverage is n/a.


Add --include-internal flag

Add --include-internal flag to include internal folders.

Thanks @mx-psi !


[Task]: Explore code based workflow engines

Is there an existing issue for this?

[X] I have searched the existing issues

### Tasks
- [ ] N8N
- [ ] Temporal.io

Closing this task since it is no longer relevant


multibuild.yaml - riscv64 docker buildx consistently slow to build / hangs

Describe the bug
The riscv64 build often is slow or outright hangs and we usually have to rerun.
Steps to reproduce
Run a multibuild - see past multibuild runs for examples.
Expected behavior
We are able to build it in a timely manner so I don't have to decide between doing the following:

Releasing without risv64 and going back to add it
Wait for it to complete successfully

We probably shouldn't be packaging RISC-V as if it's production ready until we have stable OS targets (and maybe then also RISC-V support in the Docker Dart image).

@XavierChanth you mentioned that the BuildX builds were OK again. Should we drop this, or maybe split the RISC-V build away from the rest?

Yeah, I don't think it was anything we did wrong... I think it was something with the GHA runner.

OK. Next time I'm in that code I might modify it anyway now that we know how to test for latest releases (as I feel it would be better to only build RISC-V for release candidates).


DOC: exam of using a deprecated package in the "Retriever" tutorial

Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
There is a code example of using a deprecated package(langchain/document_loaders/web/cheerio) in the Retriever tutorial part.
Below is the current version of the document
import { RecursiveCharacterTextSplitter } from "langchain/text_splitter";
import { CheerioWebBaseLoader } from "langchain/document_loaders/web/cheerio";
import { MemoryVectorStore } from "langchain/vectorstores/memory";
import { OpenAIEmbeddings } from "@langchain/openai";

const loader = new CheerioWebBaseLoader(
  "https://docs.smith.langchain.com/user_guide"
);
const rawDocs = await loader.load();

const splitter = new RecursiveCharacterTextSplitter({
  chunkSize: 1000,
  chunkOverlap: 200,
});
const docs = await splitter.splitDocuments(rawDocs);

const vectorstore = await MemoryVectorStore.fromDocuments(
  docs,
  new OpenAIEmbeddings()
);
const retriever = vectorstore.asRetriever();

const retrieverResult = await retriever.getRelevantDocuments(
  "how to upload a dataset"
);
console.log(retrieverResult[0]);

/*
  Document {
    pageContent: "your application progresses through the beta testing phase, it's essential to continue collecting data to refine and improve its performance. LangSmith enables you to add runs as examples to datasets (from both the project page and within an annotation queue), expanding your test coverage on real-world scenarios. This is a key benefit in having your logging system and your evaluation/testing system in the same platform.ProductionClosely inspecting key data points, growing benchmarking datasets, annotating traces, and drilling down into important data in trace view are workflows you’ll also want to do once your app hits production. However, especially at the production stage, it’s crucial to get a high-level overview of application performance with respect to latency, cost, and feedback scores. This ensures that it's delivering desirable results at scale.Monitoring and A/B TestingLangSmith provides monitoring charts that allow you to track key metrics over time. You can expand to",
    metadata: {
      source: 'https://docs.smith.langchain.com/user_guide',
      loc: { lines: [Object] }
    }
  }
*/

Idea or request for content:
Could the document be updated as follows?
New package path:
As it is now:
import { CheerioWebBaseLoader } from "langchain/document_loaders/web/cheerio";

The updated version should be:
import { CheerioWebBaseLoader } from '@langchain/community/document_loaders/web/cheerio';

Using another method:
As it is now:
const retrieverResult = await retriever.getRelevantDocuments(
    "how to upload a dataset"
  );

The updated version should be:
const retrieverResult = await retriever.invoke('how to upload a dataset');"

@dosu thanks for the updated code example! Can I go ahead and open a PR to update the documentation with this revised version?


Use existing postal code for location or add new one.

When adding or editing an Organization, the address must contain a
postal code that has been added before (ie. in the PostalCodeGeo table).
The changes to OrganizationEditCommandHandler fetch  the added/edited
postal code OR adds the new postal code if not found. The unit tests in
OrganizationEditCommandHandlerTests test that changes to a location's
city/state are NOT copied over to exiting PostalCodeGeo records but ARE
copied to new ones.

This request is related to issues #337, 304, 306, and 249.
I would think that the "handler" changes belong in AllReady.Areas.Admin.Models.LocationExtensions.UpdateModel(), but the extension method doesn't have a database context.

@mgmccarthy A Location has a city property and a state property. A PostalCodeGeo also has these properties. Is there an authority to let us know if the city, say, of a location has to match the city of it's PostalCodeGeo? I had assumed that they did NOT have to be the same and that was why there was a City for a location and another for it's PostalCodeGeo. Along the same lines, if I change the City of a location without changing it's postal code, it shouldn't necessarily change the City of the PostalCodeGeo. The postal service can tell you the State and City for a postal code, but where I live, you could address the City as Agincourt, Scarborough, or Toronto and it would still get delivered reliably. Also, the primary key of PostalCodeGeo is it's postal code.
The larger issue, however, is that currently you can't add an Organization with an unrecognized postal code and so the OrganizationEditCommandHandler must be able to add a PostalCodeGeo when it comes accross a new one (unless PostalCodeGeo's can be managed somewhere else and the current behaviour of throwing an exception is correct).

@auroraocciduusadmin, thanks for the explanation. I don't know enough about this area of the system, so my comment was more out of curiosity and trying to learn the system. What you say makes sense, I didn't get the difference between a Location and a PostalCodeGeo.

Actually, I don't either...that's why I was asking about an authority. Is
there anything like a written spec for this project?
On Thu, Apr 7, 2016 at 3:17 PM, Michael McCarthy<EMAIL_ADDRESS>wrote:

@auroraocciduusadmin https://github.com/auroraocciduusadmin, thanks for
the explanation. I don't know enough about this area of the system, so my
comment was more out of curiosity and trying to learn the system. What you
say makes sense, I didn't get the difference between a Location and a
PostalCodeGeo.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/HTBox/allReady/pull/671#issuecomment-207055389

@auroraocciduusadmin, I'm not too sure if there is an authority for this either. It seems like there is a friction between allowing the creation of a Location with a PostCodeGeo that is not "validated" and creating any of the three entities that have Location:
Activity
Organization
Campaign
If there was an authority (maybe we'll have a fully validated and seeded PostCodeGeo table as part of the system as whole?), then we could chekc with that authority on the form page where we're allowing the creation of these entities.
I pinged a couple others on my comment so we'll see if anyone weighs in.

Thanks for the help.
The Organization page includes a drop-down for "country" that lists a lot of countries. I can't imagine seeding the PostalCodeGeo table with the postal codes from all countries.
The code in AllReady.Areas.Admin.Models.LocationExtensions.UpdateModel() creates a new PostalCodeGeo whenever it's called and assigns it the location being edited without any checks. So that leads me to believe that it's by design to add PostalCodeGeo's as needed.
In OrganizationEditCommandHandler.Handle I find:
_context.Update(organization.Location);
...that doesn't seem to cause the newly created PostalCodeGeo attached to the Location to be inserted. It looks like you have to call _context.PostalCodes.Add() somewhere to get the new one into the database. And if you're going to use Add(), it should be unique...thus the fetch.

I think we need a decision as to whether or not an organization is allowed to add postal codes, versus a system admin.  Looping in @tonysurma and/or @BillWagner again, as I don't have the answer to that one.

will review later today

@MisterJames @BillWagner @tonysurma, my two cents on this. Maybe the question we should be asking is:
"Is an Organization still useful to the system in any way if it's created without a postal code (validated or non-validated)"
If the Organization is pretty much useless if it's created without a postal code, then let's make that a "first-class citizen" in the system and enforce that on the UI responsible for creating an Organization.
As to whether or not the postal code is valid, can that be a different use case? For example, maybe we let and Organization get created requiring a postal code and there is a separate validating process for that postal code required on a different UI page. Until the postal code is validated, you can't really do anything with the organization.
Or maybe the validation of the postal code is an async process that is kicked off after the Org is created, and there is an email sent to the admin of the Org if there is a problem with the validity of the postal code? That way, they need to fix it before the Org becomes usable.
I don't know the "actor" that would be responsible for validating an Org's postal code, if it this is even a route that makes sense. I'm just offering some ideas here.
Most likely, I don't understand the business side/use cases/requirements of the project enough, so please forgive me if these seem like silly suggestions :wink:

So there is a high level spec but with organic growth in an OSS project form a big jumpstart you get things that implement assumptions that show their head later like this.
Thanks @auroraocciduusadmin for jumping into this.
I would like to suggest/ask that fix be to remove the PostalCodeGeo table, thus removing foreign keys and thus remove the issue hitting us that causes all the questions in all the associated issues.
You should totally be able to submit an org with whatever postal code you enter (just like we don't validation you spelled 'Chicgao' right) and that org is valid and will work.  As searching happens on location/other attributes you won't show up or show up weird and those can be fixed in the search parts of the system or by the user editing the database because they don't see themselves in search results.
This works for the system 'business' requirements.  Let me know if it causes any big concerns from an implementation point of view as you've seen it @auroraocciduusadmin
Thanks again

I just assumed that the classes were written with a special use for a postal code object in mind. I don't know what the business requirements are and the change I proposed was just a way for a user to be able to add an organization (or campaign or activity) which can't be done now. So basically, I don't have any special concerns aside from the ability to add an organization.

Great, so thinking we can accept this then as it removes the issue of the need to be prepopulated and then later we can eval if the whole geocodepostal thing is needed.  @MisterJames can you review If you haven't already but from the thread it looks like this is good to go.  Thx @auroraocciduusadmin

Yeup, we're good to go here. Thanks @auroraocciduusadmin!


fork sphinx-bootstrap-theme?

Just a heads up: sphinx_bootstrap_theme is going to break when sphinx 2.0 is released, because these lines will no longer be allowed --- building mne docs on current master of sphinx yields this (excerpt; most of traceback omitted for brevity):
  File "/opt/miniconda3/envs/mnedev/lib/python3.6/site-packages/sphinx_bootstrap_theme/bootstrap/layout.html", line 11, in top-level template code
    {% set script_files = script_files + [
  File "/opt/sphinx/sphinx/builders/html.py", line 137, in __add__
    ret += other
  File "/opt/sphinx/sphinx/builders/html.py", line 129, in __iadd__
    RemovedInSphinx30Warning, stacklevel=3)
sphinx.deprecation.RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.

This is potentially a problem because sphinx_bootstrap_theme hasn't had a commit in around 10 months. If it remains stale, then either mne needs to find a new theme, or mne-tools needs to fork the sphinx_bootstrap_theme repo, fix it, and set things up to install from our fork.

See https://github.com/ryan-roemer/sphinx-bootstrap-theme/pull/193, they are looking into merging

@larsoner this can be closed, yes?  ryan-roemer/sphinx-bootstrap-theme#193 has been merged.

Indeed


Fix incorrect options order in HAproxy 2.2.x

In the latest HAproxy version option httpchk must be located before http-check directive to allow L7 checks. Otherwise httpchk will be ignored. Source: https://www.haproxy.com/blog/announcing-haproxy-2-2/#health-check-overhaul
Sample config:
haproxy::backend { 'servers':
  mode => 'http',
  sort_options_alphabetic => false,
  options => {
    'option'  => [
      'httpchk',
    ],
    'http-check' => 'send meth HEAD uri /health ver HTTP/1.1 hdr Host test.local'
    'server' => [
       'srv1 <IP_ADDRESS>:80 check',
    ],
  },
}

The Result:
backend servers
   mode http
-  http-check send meth HEAD uri /health ver HTTP/1.1 hdr Host test.local
   option httpchk
+  http-check send meth HEAD uri /health ver HTTP/1.1 hdr Host test.local
   server srv1 <IP_ADDRESS>:80 check

Thanks for describing the issue and for the fix @pkaroluk!
The change looks good. One thought: from what you highlighted, we may want enforce sort_options_alphabetic to be false in haproxy::backend if options and http_check are defined? It sounds like there may be issues if we sorted alphabetically?

Well... from my perspective I can't find any good points to sort alphabetically backend's options by default, so it seems a good idea to set it false with HAProxy 2.2.

Closing / re-opening PR to kick tests off again due to timeout

Release checks on ABS (Puppet 6) passed:
Successful on 15 nodes: ["temporal-peace.delivery.puppetlabs.net, debian-8-x86_64", "gleeful-calcium.delivery.puppetlabs.net, debian-10-x86_64", "tender-troup.delivery.puppetlabs.net, centos-8-x86_64", "routine-pyramid.delivery.puppetlabs.net, ubuntu-1404-x86_64", "fore-flea.delivery.puppetlabs.net, ubuntu-2004-x86_64", "dang-possessive.delivery.puppetlabs.net, debian-9-x86_64", "rhythmic-syrup.delivery.puppetlabs.net, scientific-7-x86_64", "dearer-penance.delivery.puppetlabs.net, scientific-6-x86_64", "downright-reign.delivery.puppetlabs.net, ubuntu-1604-x86_64", "gala-experience.delivery.puppetlabs.net, redhat-7-x86_64", "fond-woodsmoke.delivery.puppetlabs.net, ubuntu-1804-x86_64", "internal-china.delivery.puppetlabs.net, centos-7-x86_64", "navy-gauge.delivery.puppetlabs.net, oracle-6-x86_64", "bad-aficionado.delivery.puppetlabs.net, centos-6-x86_64", "diurnal-marrow.delivery.puppetlabs.net, oracle-7-x86_64"]

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@176773d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage        ?   16.66%
=======================================
  Files           ?        1
  Lines           ?        6
  Branches        ?        0
=======================================
  Hits            ?        1
  Misses          ?        5
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176773d...07a819e. Read the comment docs.

Hi @pkaroluk, thank you for highlighting this and @sanfrancrisko, thank you for adding the necessary changes !


Consider making AsciiDocElement a functional interface

Currently the interface AsciiDocElement has a single method, allowing to do something like the following:
final AsciiDoc asciiDoc = new AsciiDoc( );
asciiDoc.addDocElement( ( ) -> "= Some header");

In order to make sure that code like this remains compatible, we should consider making AsciiDocElement a functional interface.

Agreed


Fix & make GET /relations stable

Fixes https://github.com/turt2live/matrix-bot-sdk/issues/263

incorrect docs fixed in https://github.com/turt2live/matrix-bot-sdk/commit/1db772e8d72fb62afa2c9e4924f91ececf17f32a


el-input mask feature?

Is there any feature or plan for input masking?
Something like https://text-mask.github.io/text-mask/
****-****-****-**** (Credit Card Number)
**/**/**** (Date)

Sorry, we have no such plan.

I also think this feature would be great. I tried to integrate other packages, but the v-directive doesn't get applied on the input element, but on the wrapper

👍 , I need too.
have any solve?


Implement contains

https://doc.rust-lang.org/std/option/enum.Option.html#method.contains
https://doc.rust-lang.org/std/result/enum.Result.html#method.contains
https://doc.rust-lang.org/std/result/enum.Result.html#method.contains_err

TODO

[ ] Implement contains operator for Maybe
[ ] Implement contains operator for Nullable
[ ] Implement contains operator for Undefinable
[x] #1604
[ ] Implement contains operator for PlainResult

Rust has dropped contains
https://github.com/rust-lang/rust/pull/108095

It's now named "is_some_and".

It's now named "is_some_and".

It’s filed as https://github.com/option-t/option-t/issues/1336


Add command read

This will start a local server (via serve) that processes the HTMLs and shows a web reader interface.

Doesn't sound like a good idea at the moment. Archiving.


feat: Add support to Python3.11

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 91.908%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
318

Relevant Lines:
346

💛  - Coveralls


[SIL] Fix incorrect handling of 'forwarding' when parsing SIL

The forwarding directive should be optional for SIL instructions. However, the current SIL parser put it as a requirement when there is a comma follows after the main instruction components, which conflicts with debug info directives (if there is any) like loc or scope. This patch teaches the parser to treat forwarding as an optional directive.

Resolves SR-14814.

@swift-ci test

Could you also add a new test case that covers the changes?

@swift-ci test

Could you also add a new test case that covers the changes?

Sorry I forgot about the test. Currently I only add minimum amount of test that just covers SR-14814. Please let me know if I should add tests to cover every affected instruction types.
Also, I though the test should come with the fix so I amend the changes with the original commit instead of making a new one. Please let me know if that's improper

Could you also add a new test case that covers the changes?

Sorry I forgot about the test. Currently I only add minimum amount of test that just covers SR-14814. Please let me know if I should add tests to cover every affected instruction types.

I think most important is that we have coverage of the line with the if (P.consumeIf(tok::comma) &&         P.Tok.is(tok::identifier) && P.Tok.getText() == "forwarding") { logic that you changed, so the test looks good to me!

Also, I though the test should come with the fix so I amend the changes with the original commit instead of making a new one. Please let me know if that's improper

When making edits to address review feedback, we usually just amend the commit and git-push -f it, which I think is exactly what you did! Thanks for updating the PR so quickly.

Build failed
Swift Test OS X Platform
Git Sha - e23157947e380e50d19c823320c94b70b02f871b

Make the test case more portable across 64/32-bit platforms.

@swift-ci test

@swift-ci test


Extension version: 1.0.2740
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T17:39:53.251Z)
OS version: Darwin x64 19.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz (4 x 1600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
6, 6, 7

Memory (System)
4.00GB (0.09GB free)

Process Argv
--crash-reporter-id 0d1b246e-e1be-4227-bfcd-2fc0bd009a87

Screen Reader
no

VM
0%

Agreed. Timeout is way too short!

Apologies for the inconvenience caused. Do you recall how if it was an hour for you too @travis-holter ?
This is part of an onging sev we're investigating. Please follow #3835 for updates

Thanks for the reply, have been having issues the past couple of days. We got kicked off about once an hour, but one time was much less (more like 20 mins)


ImportError: libolm.so.3: cannot open shared object file

Given pantalaimon is installed similarily to #4 and #5, libolm.so.3 finds itself in /usr/local/lib64/.
Unfortunately pantalaimon does not pick it up initially, and running it states:
Traceback (most recent call last):
  File "/home/ya/.local/bin/pantalaimon", line 11, in <module>
    load_entry_point('pantalaimon==0.1', 'console_scripts', 'pantalaimon')()
  File "/home/ya/.local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/ya/.local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2793, in load_entry_point
    return ep.load()
  File "/home/ya/.local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2411, in load
    return self.resolve()
  File "/home/ya/.local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2417, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/ya/.local/lib/python3.7/site-packages/pantalaimon-0.1-py3.7.egg/pantalaimon/daemon.py", line 14, in <module>
    from nio import (
  File "/home/ya/.local/lib/python3.7/site-packages/nio/__init__.py", line 2, in <module>
    from .client import *
  File "/home/ya/.local/lib/python3.7/site-packages/nio/client/__init__.py", line 3, in <module>
    from .base_client import Client, ClientConfig, logged_in, store_loaded
  File "/home/ya/.local/lib/python3.7/site-packages/nio/client/base_client.py", line 34, in <module>
    from ..crypto import Olm
  File "/home/ya/.local/lib/python3.7/site-packages/nio/crypto/__init__.py", line 1, in <module>
    from .sessions import (
  File "/home/ya/.local/lib/python3.7/site-packages/nio/crypto/sessions.py", line 18, in <module>
    import olm
  File "/home/ya/.local/lib/python3.7/site-packages/olm/__init__.py", line 12, in <module>
    from .utility import ed25519_verify, OlmVerifyError
  File "/home/ya/.local/lib/python3.7/site-packages/olm/utility.py", line 25, in <module>
    from _libolm import ffi, lib  # type: ignore
ImportError: libolm.so.3: cannot open shared object file: No such file or directory

This can be circumvented with passing the path to the olm library via the LD_LIBRARY_PATH environment variable. Depending on your environment, this can read
LD_LIBRARY_PATH=/usr/local/lib64/ pantalaimon https://matrix.host:443

and results in a running pantalaimon instance.

Yes, the library as usual needs to be found in your library path. The default location where libolm will be installed can and should be set with the standard make DESTDIR variable.

Which location would pantalaion expect the libolm.so.3 library in, other than its make install target?

That is entirely up to your system and its dynamic linker/loader. You can check out the man pages for ldconfig(8) and ld.so(8) if you are interested in the details.
My guess would be /usr/lib/.


Release Elemental Teal 5.4 before Rancher 2.7.7 release

Describe the solution you'd like:
[A clear and concise description of what you want to happen.]
Release Elemental Teal based on SLE Micro for Rancher 5.4
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Remaining work

[x] Run CI against Staging
[x] Test IBS artifacts
[x] Artifacts released in registry.suse.com
[x] Run CI against released artifacts
[x] Update release process docs to current state (confluence)

.


Circuit with identity gate fails to transpile to universal gate set

Environment

Qiskit Terra version: 0.19.1
Python version: 3.8
Operating system: Ubuntu 18.04.6 LTS

What is happening?
Circuit with an identity gate fails to transpile, when we want to translate it to another universal gate set. In this case I wanted to convert a larger circuit to the universal basis ['rx', 'ry', 'rz', 'p', 'cx'], and this should be possible thanks to the universality of this gate set as mentioned on Wikipedia with reference to Williams, Colin P. (2011), Williams, Colin P. (ed.), "Quantum Gates".
How can we reproduce the issue?
Run this snippet of code with the simplest circuit containing an identity gate:
import qiskit
from qiskit import QuantumCircuit, transpile
qc = QuantumCircuit(1)
qc.id(0)
qc.measure_all()
qc = transpile(qc, basis_gates=['rx', 'ry', 'rz', 'p', 'cx'], optimization_level=0)
qc.draw(fold=-1)

It raises the error: QiskitError: "Cannot unroll the circuit to the given basis, ['rx', 'ry', 'rz', 'p', 'cx']. Instruction id not found in equivalence library and no rule found to expand." It comes form the UnrollCustomDefinitions transformation pass.
This circuit transpilation works if we remove the identity; I double-check this also with an arbitrary larger circuit including and removing the identity operation. Another trivial way to make it work is to avoid the translation to the new universal set, thus by setting basis_gate=None, but this is probably not what we want, since a user should be able to transpile to the preferred universal gate set of her quantum computer.
What should happen?
I expected the circuit to transpile to the desired universal gate set without error(s), even if the circuit contains an identity gate (for whatever reason).
Any suggestions?
As a fix, we could remove all the identity gates before this UnrollCustomDefinitions pass, so that it doesn't fail in the conversion. This should be possible since the identity gate doesn't change the qubit state, behaving like a no operation (noop). Maybe we can add another basis pass which does exactly this.
(Orthogonal to this suggestion, I am wondering if this problem is the tip of a larger problem, since there is at least another issue ( #7393 ) that is somehow related to both the id and unroller.)

This is because id in Terra isn't actually an identity gate for legacy reasons, it (rather unintuitively) represents a delay cycle.  Both #7146 and #7403 would already fix this, but we can't merge them yet, because we still need to support the legacy behaviour until it's completely gone from our backends.  @kdk knows more about when this will be.
I'll close this as effectively a duplicate of known issues for tracking purposes, but we will implement a fix as soon as we can do it without breaking API stability.


Refactor CrateDetails: add yanked field to Release

This is another small refactor from working on #516.
Changes should be easier to check looking at them commit-by-commit.
Basically, the previous implementation had to query the database to determine the last successful build.
But most of the information needed is already present in releases. By also fetching the yanked data into Release we avoid doing an extra query.
Additionally, the yanked field will be useful later to improve latest_version(), see the issues mentioned by https://github.com/rust-lang/docs.rs/pull/559#issuecomment-573029453.
I will have to merge / rebase these changes on top of #559. But you can already take a look :)

Merged #559, time for that rebase :) I'm looking in the meantime.

I started looking at this, but in the middle I discovered that we in fact show yanked crates as if they were normal crates. With that in mind, I think we should wait to refactor yanked crates until that's fixed: #561

This PR doesn't change the behavior of last_successful_build. I have added some tests with
247d1e3  to pin down the expected results before changing the implementation.
So I don't think #561 should block this PR.
The current implementation will not show a last_successful_build warning if the build was successful (thanks to this if case: https://github.com/rust-lang/docs.rs/pull/560/files#diff-07b7024fe121ba3b5acf483a50bf3000R239).
I can update the tests to reflect this behavior? Now there is a comment saying we don't test for yanked release, since I didn't expect this to be relevant.

Hmm, I suppose as long as there's no change in behavior it doesn't hurt to go ahead. Please do update the tests.

Now there is a comment saying we don't test for yanked release, since I didn't expect this to be relevant.

I think I got yanked versions mixed up with blacklisted versions before: yanked is by the user, blacklisted is by the infra team (docs.rs or crates.io). Sorry about that.

I have added the asserts for yanked releases now.
The test expose that the behavior is a bit funky right now... in this test 0.0.4 is the most recent successful build, but since it is yanked other releases will point to 0.0.2 as last_successful_build... 🤔

I think I got yanked versions mixed up with blacklisted versions before: yanked is by the user, blacklisted is by the infra team (docs.rs or crates.io). Sorry about that.

No worries, it is pretty confusing 😅

The test expose that the behavior is a bit funky right now... in this test 0.0.4 is the most recent successful build, but since it is yanked other releases will point to 0.0.2 as last_successful_build...

That seems like the right behavior to me. Is there something you think we should do instead?

No, I think it's okay for now. It feels inconsistent since we don't mention anything on the yanked release, but we'll address that with #561 :)


Forge not correctly registering RPCs

Version Number and Operating System(s):
Git pulled on the 30/8/17 - Win 10
Expected behavior:
When each client connects they should have network instantiated prefabs created for them and RPCs should be registered.
Actual behavior:
From time to time Forge fails to spawn all instantiated prefabs and some RPCs wont work on others. It appears that the some RPCs are not registered.
Steps to reproduce:
Start a cubeforge server. Make a couple of changes to the world and then connect in about 10 clients. You will notice some of the players don't get the world state.
[Optional] Discord Username:
SmiggsGDog

Updated to detail that this issue is not only related to cubeforge.

Is this still an issue? Can this be closed now?

@phalasz I think this didn't get fixed yet.
I've had a same/similar problem as this issue, so made a fix for this:
https://github.com/BeardedManStudios/ForgeNetworkingRemastered/pull/270
the related issue as I guess: #107

Pretty sure this can be safely closed, since @PyeonggukLee 's fix #270 , was merged into the master branch

I think #107 is the identical one with this issue.


FEATURE - Create a Real Time Alert System

Describe the feature you want the app to have that it currently doesn't

Create a real time alert sheet, inspired from this video

Instead of being a custom alert like the video, use a sheet on the MainTabView that's in the BasicCarMaintenanceApp, using .presentationDetents([.medium, .large]) for the sheet looking UI
Make it so that the sheet can't be swiped down to be dismissed, a user must click the Dismiss button

Please follow the spec below and let @mikaelacaron know if you have any questions! (tag me in the comment, thanks)

Do this in multiple PRs, as shown below

Describe alternatives you've considered

N/A

Additional context

Get data from Firestore, alerts document, which will return an array of alerts. (call the model RealTimeAlert)

Filter by alerts where isOn is true (this is something that Mikaela will manually update in Firestore)
Use this structure (actionText and actionURL are optional)

UI - Creating the Alert (PR 1)

Use tool bar items for a Dismiss button on the leading edge
Layout the view as shown in the sketch below

Center all the elements
The action button should stretch the width of the screen with 24 padding on the left and right, and be at least 44 tall
When the user clicks on the action button, it should open Safari for whatever website is fetched for actionURL (that's in the Firestore response)
The sheet shouldn't dismiss when swiping down, a user should have to tap the Dismiss button

Functionality (PR 2)

On every launch of the app check if there's a message with isOn is true (only fetch where isOn is true, don't fetch all of the messages)

If you get a message back, show the returned alert on the MainTabView (this means it will be presented no matter what)

Save the id of the message to an array in user defaults  (AppStorage) called readRealTimeAlerts

Don't show the alert if the id of that alert has already been saved to readRealTimeAlerts (this is so the alert is not shown every time the user opens the app, it's only shown to them once)
⚠ I'm thinking save this to user defaults or using SwiftData, but does SwiftData really add any dependencies (like how CoreData did)? let me know in the comments!

If you don't get anything back, don't show an alert

Design

Make sure that the alert can scroll

Hi @mikaelacaron I'd like to work on this


HDDS-1948. S3 MPU can't be created with octet-stream content-type

This problem is reported offline by<EMAIL_ADDRESS>When aws-sdk-go is used to access to s3 gateway of Ozone it sends the Multi Part Upload initialize message with "application/octet-stream" Content-Type.
This Content-Type is missing from the aws-cli which is used to reimplement s3 endpoint.
The problem is that we use the same rest endpoint for initialize and complete Multipart Upload request. For the completion we need the CompleteMultipartUploadRequest parameter which is parsed from the body.
For initialize we have an empty body which can't be serialized to CompleteMultipartUploadRequest.
The workaround is to set a specific content type from a filter which help up to create two different REST method for initialize and completion message.
Here is an example to test (using bogus AWS credentials).
{code}
curl -H 'Host:yourhost' -H 'User-Agent:aws-sdk-go/1.15.11 (go1.11.2; linux; amd64)' -H 'Content-Length:0' -H 'Authorization:AWS4-HMAC-SHA256 Credential=qwe/20190809/ozone/s3/aws4_request, SignedHeaders=content-type;host;x-amz-acl;x-amz-content-sha256;x-amz-date;x-amz-storage-class, Signature=7726ed63990ba3f4f1f796d4ab263f5d9c3374528840f5e49d106dbef491f22c' -H 'Content-Type:application/octet-stream' -H 'X-Amz-Acl:private' -H 'X-Amz-Content-Sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855' -H 'X-Amz-Date:20190809T070142Z' -H 'X-Amz-Storage-Class:STANDARD' -H 'Accept-Encoding:gzip' -X POST 'http://localhost:9999/docker/docker/registry/v2/repositories/apache/ozone-runner/_uploads/2173f019-09c3-466b-bb7d-c31ce749d826/data?uploads
{code}
Without the patch it returns with HTTP 405 (Not supported Media Type).
See: https://issues.apache.org/jira/browse/HDDS-1948

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
593
trunk passed

+1
compile
375
trunk passed

+1
checkstyle
76
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
868
branch has no errors when building and testing our client artifacts.

+1
javadoc
170
trunk passed

0
spotbugs
423
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
620
trunk passed

_ Patch Compile Tests _

+1
mvninstall
551
the patch passed

+1
compile
376
the patch passed

+1
javac
376
the patch passed

+1
checkstyle
84
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
674
patch has no errors when building and testing our client artifacts.

+1
javadoc
168
the patch passed

+1
findbugs
632
the patch passed

_ Other Tests _

-1
unit
296
hadoop-hdds in the patch failed.

-1
unit
1766
hadoop-ozone in the patch failed.

+1
asflicense
56
The patch does not generate ASF License warnings.

7525

Reason
Tests

Failed junit tests
hadoop.hdds.scm.safemode.TestSCMSafeModeManager

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux be2ffc260e5d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fba222a

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/1/testReport/

Max. process+thread count
4900 (vs. ulimit of 5500)

modules
C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
641
trunk passed

+1
compile
370
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
192
branch has no errors when building and testing our client artifacts.

+1
javadoc
157
trunk passed

0
spotbugs
460
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
673
trunk passed

_ Patch Compile Tests _

+1
mvninstall
588
the patch passed

+1
compile
377
the patch passed

+1
javac
377
the patch passed

+1
checkstyle
70
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
768
patch has no errors when building and testing our client artifacts.

+1
javadoc
160
the patch passed

+1
findbugs
654
the patch passed

_ Other Tests _

+1
unit
292
hadoop-hdds in the patch passed.

-1
unit
198
hadoop-ozone in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

5420

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7226929f3727 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9b8359b

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/2/testReport/

Max. process+thread count
1289 (vs. ulimit of 5500)

modules
C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
56
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

-1
mvninstall
7
hadoop-hdds in trunk failed.

-1
mvninstall
27
hadoop-ozone in trunk failed.

+1
compile
418
trunk passed

+1
checkstyle
65
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
811
branch has no errors when building and testing our client artifacts.

+1
javadoc
156
trunk passed

0
spotbugs
439
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
643
trunk passed

_ Patch Compile Tests _

+1
mvninstall
573
the patch passed

+1
compile
373
the patch passed

+1
javac
373
the patch passed

+1
checkstyle
67
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
630
patch has no errors when building and testing our client artifacts.

+1
javadoc
148
the patch passed

+1
findbugs
629
the patch passed

_ Other Tests _

+1
unit
291
hadoop-hdds in the patch passed.

-1
unit
1848
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

6918

Reason
Tests

Failed junit tests
hadoop.ozone.container.server.TestSecureContainerServer

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7cf7b9774e06 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/artifact/out/branch-mvninstall-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/testReport/

Max. process+thread count
4675 (vs. ulimit of 5500)

modules
C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bq.  Some of the S3 tests are failing, can you verify if they are related, as failed tests are related to S3 MPU.
I tested locally and worked well. Let's wait for an other jenkins result...

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
120
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
744
trunk passed

+1
compile
438
trunk passed

+1
checkstyle
84
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1098
branch has no errors when building and testing our client artifacts.

+1
javadoc
208
trunk passed

0
spotbugs
518
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
772
trunk passed

_ Patch Compile Tests _

+1
mvninstall
678
the patch passed

+1
compile
453
the patch passed

+1
javac
453
the patch passed

+1
checkstyle
94
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
805
patch has no errors when building and testing our client artifacts.

+1
javadoc
164
the patch passed

+1
findbugs
688
the patch passed

_ Other Tests _

+1
unit
361
hadoop-hdds in the patch passed.

-1
unit
2309
hadoop-ozone in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

9245

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestContainerStateMachine

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.container.server.TestSecureContainerServer

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2a330f2e5a5b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 10ec31d

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/4/testReport/

Max. process+thread count
5344 (vs. ulimit of 5500)

modules
C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
77
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
672
trunk passed

+1
compile
464
trunk passed

+1
checkstyle
95
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1101
branch has no errors when building and testing our client artifacts.

+1
javadoc
206
trunk passed

0
spotbugs
516
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
760
trunk passed

_ Patch Compile Tests _

+1
mvninstall
688
the patch passed

+1
compile
447
the patch passed

+1
javac
447
the patch passed

+1
checkstyle
97
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
872
patch has no errors when building and testing our client artifacts.

+1
javadoc
210
the patch passed

+1
findbugs
835
the patch passed

_ Other Tests _

-1
unit
406
hadoop-hdds in the patch failed.

-1
unit
2257
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

9412

Reason
Tests

Failed junit tests
hadoop.hdds.scm.block.TestBlockManager

hadoop.hdds.scm.pipeline.TestSCMPipelineManager

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog

hadoop.ozone.container.server.TestSecureContainerServer

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.client.rpc.TestWatchForCommit

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1724feeb2378 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ee7c261

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/5/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/5/testReport/

Max. process+thread count
4803 (vs. ulimit of 5500)

modules
C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1266/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Autoformat confusable units

I've seen errors crop up from using the different micro and mu characters. Follow matching recommendations on which character to prefer for micro, ohm, and angstrom. References:

Section 22.2 Letterlike Symbols, subsection Unit Symbols, page 877 of The Unicode Standard, Version 15.0

Section 2.5 Duplicated Characters of Unicode Technical Report 25
SI brochure
https://github.com/unicode-org/icu/blob/main/icu4c/source/data/unidata/confusables.txt

Thanks for taking a look!
The VS Code list only contains "... characters (key) that are confusable with a basic ascii [0x20 to 0x7E] character (value)". https://github.com/hediet/vscode-unicode-data/blob/a2ee3e17acaad2957f910cf6c46f6ea2c6eae753/index.ts#L159
I wonder why they did that. Was it an easy starting point and they haven't been motivated to build it out further? Would a full table would be too slow in node.js? 🤷
I too am new to Unicode security, and am still trying to figure out how to apply domain name spoofing concepts to code linting and autoformatting. TR 39 suggested reading TR 36 first, where I found this:

While compatibility normalization and mixed-script detection can handle the majority of spoofing cases, they do not handle single-script confusables. https://www.unicode.org/reports/tr36/#Single_Script_Spoofing

So it seems like normalization comes first in the process, before mixed script or single script handling. The substitutions I'm adding are normalizations.
A longer discussion of normalization from TR 36:

Fortunately the design of IDN prevents a huge number of spoofing attacks. All conformant users of [IDNA2003] are required to process domain names to convert what are called compatibility-equivalent characters into a unique form using a process called compatibility normalization (NFKC)—for more information on this, see [UAX15]. This processing eliminates most possibilities for visual spoofing by mapping away a large number of visually confusable characters and sequences.

I believe we were concerned about increasing the size of the map here but with use of match it shouldn't matter anymore? @covracer would you be interested in updating with the latest changes on main and we can try to get this merged?

Thanks, and sorry for the extensive delay here.

Note to self: revisit these ecosystem changes today.

\cc @zanieb - Do you have an opinion on whether this should be a preview change...?

@charliermarsh looks like it creates new violations and it's not a bug fix so it should probably be preview?

Done in https://github.com/astral-sh/ruff/pull/8473.

Thanks! I've looked over the hits and made a best guess at how to proceed. Over time I'll try to test and submit Pull Requests.

examples/interaction/tools/subcoordinates_zoom.py:22:23: RUF001 String ...

I would suggest applying the fix for this abbreviation of microvolts in tooltip text.

pandas/_libs/tslibs/timedeltas.pyi:58:6: RUF001 String ...
pandas/tests/scalar/timedelta/test_constructors.py:306:25: RUF001 String ...

timedeltas.pyi and timedeltas.pyx list many aliases for microseconds (among other units). test_constructors.py tests using the aliases. I would suggest # noqa: RUF001.

pandas/core/indexes/base.py:5352:26: RUF003 Comment ...
pandas/core/indexes/base.py:5353:46: RUF003 Comment ...
pandas/core/indexes/base.py:5354:69: RUF003 Comment ...

This multiline comment documents performance analysis timings. I would suggest applying the fix.

pandas/tests/io/test_clipboard.py:67:34: RUF001 String ...

This is part of dict[str, list[str]] test data for utf8. ASCII and not-confusable Latin-1 Supplement characters are included alongside characters from higher Unicode blocks. I would suggest applying the fix.

zerver/tests/test_invite.py:1281:32: RUF001 String ...
zerver/tests/test_signup.py:1021:29: RUF001 String ...

These tests use the same copy+pasted string to test "non-ASCII characters", 3 from the Basic Latin block and 6 from the Latin-1 Supplement block (5 of which aren't flagged as confusable). Unless the project would like to begin testing characters from higher blocks, I would suggest dropping the character or adding # noqa: RUF001.

Bokeh updated in https://github.com/bokeh/bokeh/pull/13668

Thanks @covracer!


Switch @dcos_io to @dcos

We got @dcos from Twitter. Awesome.
So, we need to get all our links / content switched over to reference @dcos. We don't want to deploy it yet, we have to work out the timing with Twitter to make sure they have us switched first, but I'll work out the timing if someone else will get all of the pages updated, across the site, and ready to go, so we can merge at a moment's notice ..
Who wants this one? @ashenden or @pyronicide or @mhausenblas? First one to grab it gets it. :)

I got it

Changes made in this branch -- https://github.com/dcos/dcos-website/tree/feature/twitter-dcos
When we're ready I'll merge it in.

Thanks, @ashenden! I'll update this issue when I have a time.

@williamsaaron does that mean same credentials and account or new credentials and new account that is, I will to do the styling and profile setup again? If new account pls share credentials via OneLogin?

BTW, that's awesome :)

Not sure yet. I think they will do the switch of styling, etc. for us - just move everything including the followers from dcos_io to dcos, but I have to confirm.
We have the credentials for the account now, so the transition should happen today ..

@williamsaaron something we can do here? cc: @TimonVS

@williamsaaron, @kevinkalle, and @TimonVS I have a fix for this in the branch feature/twitter-dcos.  As soon as you say the word @williamsaaron we can merge this up live.

I will let you know as soon as the transfer is done. I'm talking to them daily ..

Planning this for next week @williamsaaron let us know when to make the change.


New config to hide motion meta information box on projector (Fixed #3588)

@normanjaeckel Please review later.