Top-level "Roads" feature?

In #542, @kianzarrin is augmenting the vanilla "Adjust Roads" UI to facilitate bulk application of TM:PE customisations along a named road.
As this will likely be a widely used feature, would it be worth adding a new "Roads" button to the TM:PE menu (see #523 for updated menu style) to make the "Adjust Roads" info view more prominent and easier to access?
It could become the de-facto "point and click" way to bulk apply TM:PE customisations to routes.
For example, users could apply things such as:

Junction setup - priority signs, junction restrictions, separate turning lanes, etc
Roundabout rules (if road is a closed loop)
Speed limits (a visual alternative to Shift key modifier in speed limit tool)

User would select (and optionally modify) the road, then click buttons to bulk apply common setups. Tweaks to the common setups could be set in mod options (see https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/issues/539#issuecomment-551866591 as an example).
Alternatively we could create our own UI panel to have complete control over the "look and feel". This could allow editing roads (that green dragable line thing) like vanilla, but in normal map mode perhaps? TM:PE overlays could be visible so user can see what's happening.
In addition, we could display info about the road such as:

Maintenance level
Traffic density/congestion/flow
Length of road (units depending on kmh vs. mph setting in mod options)
Anything else that's useful to know about "a named series of segments" (a road)

This is so cool. As for

Anything else that's useful to know about "a named series of segments" (a road)

I am not so sure about the logic that the game uses to have a named road. I think its better if we allow the user to select the road using the vanilla road adjust tool #542 which funny enough does not change what is "a named series of segments".

From what you mentioned in other issue, it sounds like the game concept of "named road" is literally just "road = find adjacent segments with the same name as the selected segment".
If so, it's such a shame that CO implemented it that way. For example, if they'd added "road" objects that list segments of the road, and it had the priority flag, that could then be used to make services (road maint, snow plough, water pumping, disaster response) prioritise those roads and adjacent buildings to keep them in full working order.
Regardless, there must be some way - even if determined on an as-needed basis - to get list of segments for "a named road", so hopefully we could still do some of that other stuff?

The ability to just click a road while toolbar is open (but no tool selected) replaces the need for a top-level Roads button (the road is the button hehe).

I still think the fact the priority tool setups up almost all other rules is a bit weird (new features = speed limits of roundabout, ban parking on roundabouts). I kind of shoved this functionally over there because I did not know where to put it.
Road selection Panel is heavy and slow interface and I much prefer to have a one click setup option as we have in priority tool but maybe a new tool for that leaving the road selection panel to do the more advanced stuff.


Bug 1813233: Bumping github.com/openshift/library-go

By bumping library-go we now bind to "tcp" network type instead of
"tcp4" as before.
This is needed in order to correctly bind our http servers on ipv6
clusters.

/hold
Until I discovered how to better tackle this.

No ipv6 support on 4.3 so this is not needed.


Force className to render as class

Currently, Readme indicates that passing className at a node will cause the rendered HTML to have the class attribute. I like this behavior since it's similar to React.
However, className is not currently being treated correctly:
html = require("html-chain")
html().add("div", { className: "hi" }).build()

This returns:

I've updated html.js so this works correctly. This should be a mostly non-breaking change since passing class directly will still work as well.

If you'd rather not make this change, the Readme should be updated instead.

Hiya, thanks for catching this! Originally className was planned to be used to keep it similar to the javascript Element interface, https://developer.mozilla.org/en-US/docs/Web/API/Element/className, although the similarity to React is something I'm fond of too. It was definitely intended as the readme indicates so this is a welcome fix.
I've taken a look and it's a pretty straight forward change, so I'll merge this now and will then fix the tests that should have caught this. Once that's done I'll publish it as 3.1.0 as it introduces the functionality for className to be used in place of class.
:+1: Cheers.

Just to let you know, 3.1.0 has now been published to NPM!

Thanks @maael!


Rename test_named_expression to name in CPython

I don't know if you want different error messages than CPython. (See the 'wrong error message' annotations in the test file.)

Hmm, yeah, that would probably be good/easy to fix. At least if it does get fixed now we'll notice by the unexepected success in CI.


Prevent scanning gitignored files

This MR updates the ggshield binaries to get the latest version, and uses the --use-gitignore ggshield option to prevent gitignored files from being scanned.
This MR has no tests for now as most of the behavior is tested in ggshield. However, we maybe could add an integration test for this. It would require test files, which could be set up using the method described here in the "Passing Arguments to the Extension Development Host" section. WDYT ?

Regarding tests, I think that we should add them. The more testing we have the more robust the app will be.
It might be tedious at first, but testing will (hopefully) get easier and easier...


T3k Llama 70B prefill and decode performance metrics

Measure and report stats that users will experience with different batch sizes, input prompt context lengths, and output generation lengths. For example:
prefill:

TTFT (time to first token)

decode:

throughput (tokens per second, or time per decode) across generation sequence. Throughput changes with context length, report full curve or some key points.

@skhorasganiTT this could be a ramp up task for you to start llama.


API users still available in Deploy control

You can still see the API user management screen using the deploy client by manually navigating to the 'manage-users' state.

Resolved by #52.


[Bug]: No such file or directory: 'settings.yaml'

Do you need to file an issue?

[ ] I have searched the existing issues and this bug is not already filed.
[ ] My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
[ ] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug
No response
Steps to reproduce
No response
Expected Behavior
No response
GraphRAG Config Used
# Paste your config here

Logs and screenshots
No response
Additional Information

GraphRAG Version:
Operating System:
Python Version:
Related Issues:

you didn't init project.


display preprocessing status of dataset

display preprocessing status of dataset on the preprocessing page
display progress (which image is currently being worked on, how many are complete as a percentage or w/e)

I think to address this short term I'll do it client side. I'm realizing now that when it comes to running preprocessing multiple times, we're not equipped to handle multiple runs, and we need to do a bit of a model refactor to accommodate for that (essentially, just adding a PreprocessingBatch model, that keeps track of separate runs of preprocessing).
But ignoring those issues for now, on a single run of preprocessing, client side tracking will suffice.


feat(bindings/C): implement capability

After implementing capability, the test framework for C is easier to implement. #3472
Two concerns along with this:

I think we need more documentions on the difference between full capabilities and native capabilities, the difference between them is not obvious to users. i.e. If they want to check the capabilities, should they use full/native?
Further work: we should replace all currently opendal_byte backed string like error message to leaked CString, which is more conventional for C. (This is my mistake at the very beginning 😢). I think this break the current API, so my plan would be changing this after our first release.

I think this break the current API, so my plan would be changing this after our first release.

Can you share more details about this decision? Why not change now instead?

If they want to check the capabilities, should they use full/native?

full tells users if they can do something.
native tells users if they can do something natively.

For example, s3 doesn't support blocking API natively, but they can do this after adding BlockingLayer.

I think this break the current API, so my plan would be changing this after our first release.

Can you share more details about this decision? Why not change now instead?

For example, now our error is backed by opendal_byte. Users typically use this by
opendal_byte *b = error->message;
for (int i = 0; i < b->len; ++I)
    printf("%s", b->data[i]);
opendal_byte_free(b)

But in the CString way, we are only giving a char*, user just do
char* msg = error->message:
printf(%s", msg);
free(msg);

This will break the current way of handling error, but it is more conventional

For example, now our error is backed by opendal_byte. Users typically use this by

You have the authority to make such changes as the committer of OpenDAL and code owner of OpenDAL C binding. You're empowered to suggest API changes when necessary.
The question I asked is about the timing: How about making those changes now before release, instead of after release?

You have the authority to make such changes as the committer of OpenDAL and code owner of OpenDAL C binding. You're empowered to suggest API changes when necessary.
The question I asked is about the timing: How about making those changes now before release, instead of after release?

Project like milvus is using c binding right now. Are they manually linking the library or building from source? I am not really sure about this.
My original thought is that they are building from source. If this is the case, changing the upstream code might break their code that is using stuff like error.
But if they just use the static library and previous header and manually link to that, changing it now will be fine.
Does that make sense to you?

Project like milvus is using c binding right now. Are they manually linking the library or building from source? I am not really sure about this.
My original thought is that they are building from source. If this is the case, changing the upstream code might break their code that is using stuff like error.

Your concern is correct. milvus is using OpenDAL via clone it directly:
# git clone https://github.com/jiaoew1991/opendal.git opendal
git clone https://github.com/apache/incubator-opendal.git opendal
cd opendal
# git checkout blocking-layer
if command -v cargo >/dev/null 2>&1; then
    echo "cargo exists"
else
    bash -c "curl https://sh.rustup.rs -sSf | sh -s -- -y" || { echo 'rustup install failed'; exit 1;}
    source $HOME/.cargo/env
fi
pushd bindings/c
cargo build || { echo 'opendal_c build failed'; exit 1; }
popd
mkdir -p ${ROOT_DIR}/internal/core/output/lib
mkdir -p ${ROOT_DIR}/internal/core/output/include
cp target/debug/libopendal_c.a ${ROOT_DIR}/internal/core/output/lib/libopendal_c.a
cp bindings/c/include/opendal.h ${ROOT_DIR}/internal/core/output/include/opendal.h

From: https://github.com/milvus-io/milvus/blob/bf2f62c1e7231bb2f7f3f27c5807439eb63b6918/scripts/3rdparty_build.sh#L66-L82
It's by design to allow break on main branch and users should not rely on our main branch. Perhaps we should transition to commit-based, then shift to tag-based after formally releasing opendal-c? @jiaoew1991

But if they just use the static library and previous header and manually link to that, changing it now will be fine.

I'm worried that we're still a long way from releasing our first version of opendal-c. We may need to implement more significant changes for opendal-c. We can't simply delay them all and wait for the next version.

Conclusion:

Users should depend on tag if we are released.
Users should depend on commit if we aren't released.
OpenDAL's main branch is by design to break APIs from time to time.

I agree with what @Xuanwo mentioned and prefer to make the string change before the release. (But I think we should do it in a separate PR, making it easier to review).
As for the test framework thing, I am gonna look into that later as well.
\cc @jiaoew1991, can you update the code in milvus to use the version by commit? Cuz we might break some APIs in the break.

But I think we should do it in a separate PR, making it easier to review

👍, Sure!

I agree with what @Xuanwo mentioned and prefer to make the string change before the release. (But I think we should do it in a separate PR, making it easier to review).
As for the test framework thing, I am gonna look into that later as well.
\cc @jiaoew1991, can you update the code in milvus to use the version by commit? Cuz we might break some APIs in the break.

I will choose a stable commit 😅


Problems installing on AIX and Solaris.

Ibm 1
`Recipe: blp-base::monit

monit[monit] action enable

poise_languages_static[/opt/monit-5.17.1] action install

execute[unpack archive] action nothing (skipped due to action :nothing)

remote_file[/var/chef/cache/monit-5.17.1-aix-ppc.tar.gz] action create

create new file /var/chef/cache/monit-5.17.1-aix-ppc.tar.gz
update content in file /var/chef/cache/monit-5.17.1-aix-ppc.tar.gz from none to 3c7e35
(new content is binary, diff output suppressed)
change mode from '' to '0644'
change owner from '' to '0'
change group from '' to '0'

execute[unpack archive] action run
================================================================================
Error executing action run on resource 'execute[unpack archive]'
Mixlib::ShellOut::ShellCommandFailed
Expected process to exit with [0], but received '1'
---- Begin output of ["tar", "--strip-components=1", "-xzvf", "/var/chef/cache/monit-5.17.1-aix-ppc.tar.gz"] ----
STDOUT:
STDERR: tar: illegal option -- -
Usage: tar -{c|r|t|u|x} [ -BdDEFhilmopRsUvwZ ] [ -Number ] [ -f TarFile ]
[ -b Blocks ] [ -S [ Feet ] | [ Feet@Density ] | [ Blocksb ] ]
[ -L InputList ] [-X ExcludeFile] [ -N Blocks ] [ -C Directory ] File ...
Usage: tar {c|r|t|u|x} [ bBdDEfFhilLXmNopRsSUvwZ[0-9] ]
[ Blocks ] [ TarFile ] [ InputList ] [ ExcludeFile ]
[ [ Feet ] | [ Feet@Density ] | [ Blocksb ] ] [-C Directory ] File ...
---- End output of ["tar", "--strip-components=1", "-xzvf", "/var/chef/cache/monit-5.17.1-aix-ppc.tar.gz"] ----
Ran ["tar", "--strip-components=1", "-xzvf", "/var/chef/cache/monit-5.17.1-aix-ppc.tar.gz"] returned 1
Cookbook Trace:
/var/chef/cache/cookbooks/poise/files/halite_gem/poise/helpers/notifying_block.rb:69:in notifying_block' /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/static/resource.rb:78:in action_install'
/var/chef/cache/cookbooks/poise/files/halite_gem/poise/helpers/notifying_block.rb:69:in notifying_block' /var/chef/cache/cookbooks/poise-monit/files/halite_gem/poise_monit/monit_providers/base.rb:36:in action_enable'`

Sundev1:
Sundev1 error


HipChat API v1 is deprecated

@joeybaker @JoeParrinello  happy to see what you have come up with, but it uses API v1 which is now deprecated, any plans to upgrade it to API v2
It would be great!!

Hi @sijojlouis. I no longer use hipchat. If you like, I'm happy to add you to this project and you can fix it for v2?

Hi @joeybaker, I would have loved to, but quite occupied as of now. In-case, I work on integrating this feature, will definitely update it here.


IRGen: Indirect_In_Constant inside of partial apply forwarders is now…

… assumed to be @guaranteed
Since closure captures are now @guaranteed. Previous to this fix we
assumed @owned which matched the old closure capture convention.
Neither version is proper of course:
The proper fix, I will follow up with, is that when the large loadable
types pass lowers @guaranteed/@owned to @indirect_in_constant it should
disambiguate to @indirect_in_constant_guaranteed/owned.
rdar://35674625

@swift-ci Please test

What's the difference between @in_constant and @in?

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - cac837548ddcc4349d0ba885f6193dd8cfa25f9b

Build failed
Swift Test Linux Platform
Git Sha - cac837548ddcc4349d0ba885f6193dd8cfa25f9b

Build failed
Swift Test OS X Platform
Git Sha - cac837548ddcc4349d0ba885f6193dd8cfa25f9b


Prevent wallet from deploying 2FA to account with existing contract

Problem
When NEAR Wallet has full access key to a contract, it allows to deploy 2FA contract on top of existing one and bricks the account
Expected Behavior
Wallet doesn't allow to deploy the 2FA if the account is a contract
Steps to reproduce

Open in Wallet an existing contract app
Press setup 2FA and setup it up
Observe that account didn't not correctly initialize but the full access key got removed and no way to restore account

FYI for everyone here -- the 'clear state' contract has been merged, and we are working on getting fixes in place this sprint. cc: @esaminu
We are handling two cases immediately:

When disabling 2FA, we will deploy the Clear State Core Contract first, call the clean() method on that contract to clear any existing multi-sig specific state, and then deploy our empty contract to the account once the state has been deleted successfully.
When enabling 2FA, we need to check two things:
(a) If the accounts code hash is not our empty contract or the 'all 1's' hash that is the default for new accounts that have never had a smart contract deployed to them, then we must throw an error and tell the user that we cannot deploy the 2FA contract to an account with an existing contract, thus avoiding deploying the multisig contract to an account that has an existing smart contract actively deployed to it.
(b) If the account contract hash is our 'empty contract' or the default 'all 1's' hash, then we still need to check the account for existing account state.  If there is existing state, then we should not deploy the 2FA contract to the account, because existing state may well not deserialize correctly and as a result, deploying the 2FA contract to an account with existing state could be a destructive change.

In the case of (2)(b) above, we could add a prompt for the user that asks them something like 'Do you want to clear existing smart contract state from your account? Click 'OK' to clear any existing smart contract state.'; if they click the button, we could follow the steps we added in (1) above (deploy clean up state contract, call clean() on it, then deploy our empty contract back to the account, which would unblock the user and allow them to deploy the 2FA contract to their account safely.

FYI I tested a time ago cleaning the state through the state-cleanup contract and got a bricked account after 2FA installed
https://explorer.mainnet.near.org/transactions/CHhmpRA3DNDaWjj3dHEpx7p2RweYimn8g8Mt3Nro7KkE

Does the newly deployed 2FA contract allow adding a new full access key?


Review styled-system implementation

Suggested by @PepijnSenders
https://jxnblk.com/styled-system/
could build on top of our styled-components
Let me know what you think @benj

Yes, I detailed the new behavior of the button component in https://github.com/OneArmyWorld/onearmy/pull/242
Yesterday I fell on this article about styled-system and I found it very interesting : https://medium.com/styled-components/build-better-component-libraries-with-styled-system-4951653d54ee
I really liked the approach and will definatelly keep it in mind for the futur

Hey @PepijnSenders, I tryied an implementation of styled-system last week, and that was a good experience. I liked the consistency that it gives to build the interface and I think it can be a good choice since a lot if different developers will work on the interface.
You can have a look on the new branch feature/styled-system-test
It makes a lot of sense for building the layout boxes, container, margins, etc but I'm a bit more confuse when styling an precise object like button, should I move all the css from for example src/components/Button/elements.js to the buttons object in the theme ?
if you can have a look and give me some feedback it would be nice, thanks !


feat: AU-2125: Delete atv docs from enviroment script

AU-2125

What was done

New version of the clean-env-for-testing.sh script, which will delete all documents (including submitted) from the ATV service.

How to install

Make sure your instance is up and running on correct branch.

git checkout feature/AU-2125-delete-atv-docs
make fresh

Run make drush-cr

How to test

[ ] Check e2e/.test_env for APP_ENV and make sure that it's the environment that you want to nuke.
[ ] Run bash clean-env.sh --draft to delete draft submissions
[ ] Run bash clean-env.sh to delete all documents.
[ ] Script should first get all ID and then delete these one by one.

deleted_documents.txt vois ehkä gitignoree


Set the default value of siteBanner to none

Fix #25
Also, if the original intent of the code below was to run only once, perhaps it would be better to use Ref, React has never guaranteed that useEffect will only be called once.
  React.useEffect(() => {
    const BannerFile =
      ConfigUtils.getPublishing(config).siteBanner === "custom"
        ? "BannerAlert.tsx"
        : "NoOp";
    logger.info({ ctx: "loading banner", BannerFile });
    BannerAlert = require(`../custom/${BannerFile}`).default;
  }, []);

Thank you for submitting the fix. I'll merge this. It will go out very soon.
Regarding useEffect, I'm don't have enough context on the decision. @jonathanyeung might have an answer. In any case, you are welcome to submit a PR for that in our main repo at https://github.com/dendronhq/dendron if you wish to do so :)


Delete .github/workflows directory

Github recently added the ability to auto-add issues to github projects natively through projects. We should move to using this tool so that we can avoid updating expiring PAT's.
I'm also deleting the workflow directory as a whole because the only workflow we are using was to add an issue to a github project through github actions.

Also we should keep the workflow dir in the repo for the backend because the workflow in projects only allow the ability to pull in one repo not multiple.


[WIP] General updates, fixes, and cleanup

This is still work in progress, as I am still making small changes and waiting for feedback as well. I also need to test this more as I have barely done so. It compiles and runs though.
I was taking a look over Prism as I was planning to use it soon and I realized there was some of what I needed missing. Before I went into the more in-depth changes I would like to submit, such as finishing some of your TODOs, I went through and fixed a few small issues that I or IntelliJ saw. I also noticed some of the Javadocs were lacking a little so I tried to add a bit to those as well, and that ended up making the majority of this pull request.
Some of these changes may not be desired, some may be unnecessary, some may be bad, or I may have followed the wrong style in places(do you have a style guide?) so please be harsh with my changes. I'll try to make any changes as soon I can once I get responses. I may have forgot some things as well. So if you see anything else that needs cleanup, feel free to point it out.
I will leave comments within the pull request code to explain my changes. I recommend looking at them through the "Files changed" tab due to being able to see all of the changes around the comment.

I have some more small changes I'd like to make, mainly in the Javadoc department, but I'm going to wait to see what you have to say about the changes so far.
Thanks.

Thanks, some of this stuff is certainly needed.
Can you start splitting related changes into specific PRs though? (For example, one for gradle updates/changes, one for license header fixes, etc). I would much rather review and merge changes separately rather than as one giant PR. Several things are trivial and can be merged ASAP but I don't want to hold and keep reviewing those for the larger changes.

@viveleroi Yeah I'll be happy to do that, I'll try to get it done by tomorrow. Would you say dependency updates belong in the Gradle update as there are no breaking changes?

Sure that works for me.

So far I have split this up into #77 #78 #79 #80 - I will continue more work tomorrow.

Now I have submitted #82 and #83 as well.


Add tdd-things-list-pagination-collection

Resolves: https://github.com/oeg-upm/wot-hive/issues/28
Please review and test since I'm not the greatest Java coder :-)
Would also be great to add this feature then to your implementation report to move 108: tdd-things-list-pagination-collection out of the "at risk" section.

Thanks - really appreciate it!

Thanks for contributing


Disable the video similarity feature

Hi, I always upload the same video titles, only with a different date. Unfortunately, this prevents me from uploading videos in non-interactive mode and it always rejects them due to similarity. Is there a way to disable the similarity feature? I would like to upload, for example, 15 2-hour videos without waiting for another question in interactive mode, if the video is the same as another, but let it run by itself.

Thank you, how do I do it on the GUI? (I'm using the exe on Windows).

You'd need to modify the code - free to submit a PR with a fix!
I don't have any personal motivation to work on this project but will merge PRs/release if others want to keep developing it :)

Implemented in v0.5:
https://github.com/beveradb/youtube-bulk-upload/releases/tag/v0.5.0


Use left/right arrow to move cursor when unselecting in LineEdit

-- this behavior matches TextEdit and other GUIs out there
-- my main use case was for the rename dialog (the filename portion is selected by
default, and usually, I want to change the end of the name, not the beginning)

I'm not sure what to do from this point.  Assign reviewers?  Make a bug report?

you don't need to do anything at this point. just give some time to maintainers.

Currently TextEdit does not do this, though would be cool to have over there as well.

Hmm.  Maybe I misquoted -- I did initially waste some time editing that class and finding it wasn't even what the Rename dialog was using :blush: .  It seems like other editors (e.g. numeric inputs, text editor, bbcode editor, etc. in the Inspector, as well as the full source editors, have this behavior already).
If it's not obvious, this is me getting my feet wet :)

Thanks!


Add destination address in form and GraphQL mutation

We need to add a form field that allows the user to specify the TZ address they want to mint a new NFT. This also needs to be implemented in the createNonFungibleToken mutation

Aren't the user going to mint new tokens to his own address?


include statement being ignored.

I have a file that starts with
{
include 'site.conf'
// more stuff
}
none of the data the give file is being imported. I have tried multiple variations of syntax on
https://github.com/lightbend/config/blob/master/HOCON.md#include-syntax
you mention that there is a include file syntax in your specification but give no direction as to what it is I assumed that it would be from the parent source but I guess not

After further examination, I was using HoconParser.Parse(), I see that one needs to provide a include callback.  It would be nice if this threw an exception instead of silently failing. It would cut back on PEBKAC in my case.

AFAIK its by design, consider to use INCLUDE REQUIRED instead

@holonsoftFounder care to exlain?


ci: add an action that checks for version

TODO

PR-Codex overview
This PR introduces a GitHub Actions workflow for testing third-party libraries. It schedules hourly checks for new versions of specified libraries (viem, web3, ethers) and compares them with the last known versions.
Detailed summary

Added a new workflow named Third party libraries testing workflow.
Configured the workflow to trigger on a schedule and manually via workflow_dispatch.
Created a job compare-versions to check for new library versions.
Set up a matrix strategy to handle multiple libraries.
Downloaded the last version of each library and fetched the current version using npm info.
Installed and validated the semver tool for version comparison.
Implemented logic to trigger tests if a new version is detected, with a placeholder for future test implementation.
Uploaded the fetched version as an artifact if a new version is found.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

awesome stuff @nicolasbrugneaux!

TODO before merging and after review: remove the on: pull_request trigger from the cronjob, it was used for testing

After lots of problem trying to have<EMAIL_ADDRESS>and<EMAIL_ADDRESS>coexist, we decided to move this package to its own repo
https://github.com/celo-org/developer-tooling-e2e


Emit invalidate event

The new release of https://github.com/moxystudio/webpack-sane-compiler added a new invalidate event. We should also support it.

Fixed in 7c68c411b7d1ce4c413b9c8433d450014a141261


[Enhancement] Eliminate internal information from exception or error message to FE to end user

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Problem Summary(Required) ：

Eliminate internal information from exception or error message to FE to end user
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-3.0


Null pointer overrides for "timestamp with time zone"

Go everything to work with  overrides except timestampz.
sqlc.yaml :
...
- db_type: "pg_catalog.timestamp"
go_type:
type: "time.Time"
pointer: true
nullable: true
- db_type: "pg_catalog.timestampz"
go_type:
type: "time.Time"
pointer: true
nullable: true
Table :
CREATE TABLE public.location
(
id uuid PRIMARY KEY DEFAULT uuid_generate_v1mc(),
updated_at timestamp with time zone default now(),
test timestamp default now()
);
Got this :
type Location struct {
ID        uuid.UUID
UpdatedAt sql.NullTime
Test      *time.Time
}
Expected: UpdatedAt *time.Time but does not work for some reason.

Solved. Just single quotes do the job!
...
- db_type: 'pg_catalog.timestamp'
go_type:
type: 'time.Time'
pointer: true
nullable: true
- db_type: 'pg_catalog.timestamptz'
go_type:
type: 'time.Time'
pointer: true
nullable: true


⚠ SceneTime has degraded performance

In bce7e33, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2550 ms

Resolved: SceneTime performance has improved in 3510bb4 after 6 minutes.


Rich editor - Link Input text color not readable

Package
filament/forms
Package Version
v2.0
Laravel Version
v9.19
Livewire Version
v2.10
PHP Version
8.1.3
Problem description
Hi,
if using the link-function of Rich editor in dark mode, you cannot read the input-value because the input-text-color is light and the input-field itself is a white field. It's a css-problem.

Expected behavior
I expect a dark  text-color in this link input-field or better a dark input-field, cause it looks nicer. ;)
Steps to reproduce
link-function of Rich editor in dark-mode
Reproduction repository
https://github.com/sbritz/filament-blog-demo.git
Relevant log output
No response

Fixed by #5216


Unable to register commands as expected

Thank you for creating a great framework. I'm using this framework to create PaperMC plugin commands.
I'm sorry for the consecutive days of posting.
I would like to implement a command the following:

/teleport <warpName>: Teleports the player who executed the command to the specified location.
/teleport <player> <warpName>: Teleports the specified player to the specified location.

To implement this, I wrote the following code (These are in onEnable):
final PaperCommandManager<CommandSender> manager;
try {
    manager = new PaperCommandManager<>(this, CommandExecutionCoordinator.SimpleCoordinator.simpleCoordinator(),
            Function.identity(), Function.identity());
} catch (Exception e) {
    e.printStackTrace();
    return;
}
Command.Builder<CommandSender> builder = manager.commandBuilder("teleport");
manager.command(builder
        .senderType(Player.class)
        .argument(StringArgument
            .<CommandSender>newBuilder("warpName")
            .withSuggestionsProvider(this::suggestWarpNames))
        .handler(this::teleport)
        .build());

manager.command(builder
    .argument(MultiplePlayerSelectorArgument
        .newBuilder("player"))
    .argument(StringArgument
        .<CommandSender>newBuilder("warpName")
        .withSuggestionsProvider(this::suggestWarpNames))
    .handler(this::teleport)
    .build());

However, when I run it, it shows an error when starting the server.
[18:42:09] [Server thread/ERROR]: Error occurred while enabling PLUGIN v0.0.1 (Is it up to date?)
cloud.commandframework.exceptions.AmbiguousNodeException: Ambiguous Node: warpName cannot be added as a child to teleport (All children: warpName, player)
	at cloud.commandframework.CommandTree.checkAmbiguity(CommandTree.java:833) ~[?:?]
	at java.lang.Iterable.forEach(Unknown Source) ~[?:1.8.0_281]
	at cloud.commandframework.CommandTree.checkAmbiguity(CommandTree.java:864) ~[?:?]
	at cloud.commandframework.CommandTree.verifyAndRegister(CommandTree.java:760) ~[?:?]
	at cloud.commandframework.CommandTree.insertCommand(CommandTree.java:705) ~[?:?]
	at cloud.commandframework.CommandManager.command(CommandManager.java:227) ~[?:?]
	at com.tomacheese.plugin.Main.onEnable(Main.java:66) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.16.5.jar:git-Paper-547]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[patched_1.16.5.jar:git-Paper-547]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.5.jar:git-Paper-547]
	at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501) ~[patched_1.16.5.jar:git-Paper-547]
	at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415) ~[patched_1.16.5.jar:git-Paper-547]
	at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:468) ~[patched_1.16.5.jar:git-Paper-547]
	at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:241) ~[patched_1.16.5.jar:git-Paper-547]
	at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:943) ~[patched_1.16.5.jar:git-Paper-547]
	at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.5.jar:git-Paper-547]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]

What can I do to fix this?
Sorry for the poor English. I look forward to your reply.

Don't worry about making new issues and your English is good!
This is a limitation with cloud and how it structures it's tree. For us it's impossible to know whether we should be parsing a  or a .
To work around it you could move the player after the warpname or make your own Warp argument that can parse either.
Let us know if you have any more questions ^^

Thanks for your quick reply.
In that case, it is a little off the main topic of the Issue, but is it possible to parse selectors such as @p and @a[distance=..3] with StringArgument?
Since StringArgument does not parse these selectors, we think it will be difficult to parse the selectors if we create our own arguments that can parse both.
If you can do it, I would appreciate it if you could tell me exactly how to implement it.

@broccolai I will reply because there is no response even after about a week and I can not reopen. I'm sorry to get in the way.
I look forward to your reply.


⚠ Bofrost.fr has degraded performance

In f8979cd, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1037 ms

Resolved: Bofrost.fr performance has improved in 39092c7 after 6 minutes.


Uncaught Error: Undefined constant "Akash\JobPlace\Setup\CART_PULSE_VERSION"

Hello, I decided to look at your project. but ran into this error: Uncaught Error: Undefined constant "Akash\JobPlace\Setup\CART_PULSE_VERSION"  includs/installer.php:65. Perhaps I made a mistake somewhere in the installation.
I just added it in the installer class and it worked. but I don't know what it should be

Is the issue fixed ?

@maniruzzamancse Yes, That was a issue for constant data which was used previously. That has bee removed now.

@maniruzzamancse Yes, That was a issue for constant data which was used previously. That has bee removed now.

Thank you.


Sort RPC docs by descending version

Split from #686

Unfortunately the changes in the menu won't take effect until #686 (no idea why):

Concept ACK

@Sjors this fixes the sort in the drop-down list (pipe syntax has never worked with for loops in any version of Liquid that I've used):
diff --git a/_includes/navigation.html b/_includes/navigation.html
index 4b383c3..e4e5072 100644
--- a/_includes/navigation.html
+++ b/_includes/navigation.html
@@ -34,9 +34,9 @@
                                   RPC Docs
                                 {% endif %}
                               {% endfor %}
-                              {% assign groups = site.doc | group_by:"btcversion" | sort_by: "btcversion" %}
+                              {% assign groups = site.doc | group_by:"btcversion" | sort: "btcversion" | reverse %}

-                                {% for group in groups | reverse %}
+                                {% for group in groups %}
                                   {% if group.name != "index" %}
                                     {% for article in group.items %}
                                       {% if article.name == "index" %}

That worked (also in combination with #686)

Tested ACK da28dc0959d78bacca465867ed88fdb897f89c49 . Thanks!


Fix the problem it does not work with MySQL

I think it is what you need for the issue #1. Though I have not tested, it should work with other databases.

Thanks for the PR! I vendored the wait-for-it script for faster github action load times.


[Addition]:

Hotspot b58 Addresses
112uLpR4hFcXNwyxpUaF2avm5Q3Jn3tbVnXwMDDhrTXojaaVqrK1
11bPUwMnuRLRoZ6jAygkfgDZoZ18MdbFnqvRTcGXADKGpoDKpG8
112UUL81vfyhLys2oft7pXTPmZ8TMbGQ2UDXU8azTRaUwwEiuhev
11E6RFFTHVLQtnxvinNnPWsMcE1k1e5yiyXWxPcYPZrEpUPLFp5
112mayUvW26RkmHx3p1X3RXcy2kwQ72vzx6BUUdPSwyRwVnnufUX
11wrDk8GztyK3F3kzQ8mSAchNaomCSKp8qz6wXsHfSCHWTMEiGb
1121ZmHEiC3Dr5REJKSsXtS4GXL8JzGtBWZ24k4iAhCZNgcnKqZJ
Discord Handle
Dhene#8769
Reason(s)
Impossible to witness beacons from this far.

Hi, I see at least 2 hotspots that are mine and 2 from my friend. Hotspots are located in Brussels and indeed, since 4-5 days rewards have increased significantly but we do not know what the reason is. Our hotspots are legit and have no modification. This is indeed not normal and has already been mentioned on Discord. Your list of hotspots contains legit hotspots and illegitimate ones. I suggest you take a bigger look because if you're really going that way, you will have to add most of the hotspots in Brussels very soon including mine and other ones which are completely legit. From what I may have understood, the cheaters are replaying beacons from the Netherlands here in Brussels, but they purposely do this to witness beacons for their hotspots but also other hotspots nearby which makes it nearly impossible to differentiate between the hotspots of the cheaters and legit hotspots. So right now you are also punishing hotspots that haven't done anything wrong.

We have taken into account this addition request in the next iteration of the denylist. Some or all of the Hotspots listed may be added to the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Add Order.by(List)

These are convenience methods, but useful ones.

I'm unclear on the benefit of the other methods

I have now dropped the commits which added those two methods.


Release 0.3.1

Not ready to merge, depends on #100

#100 is out of the way, so think we should roll this out.


编译失败

golang版本1.12.5
# github.com/tr3ee/go-rjsocks/core
..\core\handle.go:71:33: cannot use &fillLayer (type *RawLayer) as type gopacket.SerializableLayer in argument to h.send:
*RawLayer does not implement gopacket.SerializableLayer (missing LayerType method)
..\core\handle.go:95:39: cannot use &fillLayer (type *RawLayer) as type gopacket.SerializableLayer in argument to h.send:
*RawLayer does not implement gopacket.SerializableLayer (missing LayerType method)
..\core\handle.go:125:39: cannot use &fillLayer (type *RawLayer) as type gopacket.SerializableLayer in argument to h.send:
*RawLayer does not implement gopacket.SerializableLayer (missing LayerType method)
..\core\handle.go:169:33: cannot use &echo (type *RawLayer) as type gopacket.SerializableLayer in argument to h.send:
*RawLayer does not implement gopacket.SerializableLayer (missing LayerType method)

这是gopacket库升级之后接口不兼容导致的，预计在这个月内推出下个版本更新

使用gopacket.Payload代替RawLayer

酷👍有想法提交一个PR吗？
---原始邮件---
发件人<EMAIL_ADDRESS>发送时间: 2019年7月6日(星期六) 晚上10:45
收件人<EMAIL_ADDRESS>抄送: "Comment"comment<EMAIL_ADDRESS>主题: Re: [tr3ee/go-rjsocks] 编译失败 (#13)
使用gopacket.Payload代替RawLayer
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


pyelasticsearch: init at 1.4

Updated with a comment for why the tests are disabled. They require a running elasticsearch instance.


bug: python3.11 coroutine dependency broke

Overview
opentrons_simulate on python3.11 does not work due to coroutines being updated.
Steps to reproduce

Install python3.11
Install opentrons (pip install opentrons)
Run opentrons_simulate

Current behavior
[koeng@nuci3 pcr_bottleneck]$ opentrons_simulate
Traceback (most recent call last):
File "/home/koeng/.local/bin/opentrons_simulate", line 5, in
from opentrons.simulate import main
File "/home/koeng/.local/lib/python3.11/site-packages/opentrons/init.py", line 11, in
from opentrons.hardware_control import (
File "/home/koeng/.local/lib/python3.11/site-packages/opentrons/hardware_control/init.py", line 14, in
from .api import API
File "/home/koeng/.local/lib/python3.11/site-packages/opentrons/hardware_control/api.py", line 33, in
from .backends import Controller, Simulator
File "/home/koeng/.local/lib/python3.11/site-packages/opentrons/hardware_control/backends/init.py", line 1, in
from .controller import Controller
File "/home/koeng/.local/lib/python3.11/site-packages/opentrons/hardware_control/backends/controller.py", line 20, in
import aionotify  # type: ignore[import]
^^^^^^^^^^^^^^^^
File "/home/koeng/.local/lib/python3.11/site-packages/aionotify/init.py", line 5, in
from .base import Watcher
File "/home/koeng/.local/lib/python3.11/site-packages/aionotify/base.py", line 10, in
from . import aioutils
File "/home/koeng/.local/lib/python3.11/site-packages/aionotify/aioutils.py", line 122, in
@asyncio.coroutine
^^^^^^^^^^^^^^^^^
AttributeError: module 'asyncio' has no attribute 'coroutine'. Did you mean: 'coroutines'?
Expected behavior
Dependencies should be updated.
Operating system
Linux
System and robot setup or anything else?
No response

Thanks @Koeng101, this is on our radar internally, too. For Opentrons folks, please see RSS-172

This is an issue in the aionotify library, most likely not Opentrons (although both could be true). I opened an issue there: https://github.com/rbarrois/aionotify/issues/18

Opened a PR: https://github.com/rbarrois/aionotify/pull/19.
In the meantime, my fork (https://github.com/rickwierenga/aionotify) passes the tests. You should be able to use that to test this repo.

Hi, is there any update on this?

Hi any way around this? Need some help.

Hi!
There is a workaround (working on this in Support as well).
You can leverage a tool like Pyenv to switch Python versions and it should work!
Sorry, this is a bit of a tricky workaround. If you go into Support's queue we'll be able to provide a bit more specific back and forth.

Any updates here? Trying to automate some processes and this is a real sticking point; we need to use 3.11

Thanks @Koeng101, this is on our radar internally, too. For Opentrons folks, please see RSS-172

Has this been on the radar for over a year?

Is there a fix for this issue aside from downgrading to Python 3.10?

Doesn't seem to be. Also, to be clear (for the Opentrons folks), it's not just running opentrons_simulate that this breaks, which would be annoying but not that big of a deal--we've been trying to interface with multiple robots through one computer, and we can't import opentrons properly, so in order to get data off any robot, we have to write to text files and pass them back and forth, which takes much longer (up to several minutes instead of seconds) and is more computationally intensive and prone to errors. A long-term solution to this would be much appreciated.

I contacted Opentrons and was told I must downgrade Python for it to work. They linked this bug ticket from January 2022, which hilariously is flagged as "closed" with the "solution" of simply downgrading python versions. I guess they don't plan on ever fixing this.
https://github.com/Opentrons/opentrons/issues/9331

If this helps, we have HTTP API

Which might fit your goals more.
Can we talk through a bit more what you need in 3.11 so I can make a more compelling case for it?

Can we talk through a bit more what you need in 3.11

I want opentrons_simulate to work on the default installed version of python on the vast majority of systems. Like, yes, I can just run poetry or pyenv, but it complicates the systems and adds another dependency management step. The solution of "just delete python3.11 or use pyenv" ignores the fact that this is a very annoying customer-facing issue that has multiple people complaining about it.

while using the api does not strictly require any python version, it is practically necessary to import opentrons for the resource definitions. i understand there are ways to circumvent this, but it's not a great experience.
the fact that there is so much interest in this thread alone means it's worth solving. + you don't want to be stuck on 3.10 forever. asking users for specific motivations seems a distraction from doing the actual work, which shouldn't take that much time.

On our end, we've paired up robot control with many other of our internal systems and database in order to track errors, easily transfer complicated protocol information back and forth, etc, and so I would need to build pyenv into a complicated existing system. I write a lot of code, but I'm a biologist with very little formal programming training--I can definitely figure out how to make it work, but it would take me a few days to work out all the kinks. HTTP API looks really cool and useful, but is not at all integrated with our current system. Obviously I could use it, but again, this would take me several days of work, including learning the first thing about HTTP, which I currently know next to nothing about. Multiple days of work is a LOT for a bug that should be pretty easily fixed, or even just patched so opentrons can at least be imported on 3.11 without immediately breaking. And sure, if it was just me, I'd figure it out. But clearly there are a bunch of people here who are spending large chunks of their time trying to solve this issue for themselves--which is not that surprising to me, since the website documentation has a whole section designed for mid-level users recommending the use of opentrons_simulate despite needing a really annoying workaround to function. It could get fixed once now, or repeatedly cause customers relatively new to coding hours of work.


stretchly: 0.19.1 -> 0.21.0

Update stretchly to version 0.21.0.
I've changed this to use buildFHSUserEnv since I couldn't get this new version working with just patchelf.  Electron apps are a pain on Nix.
I also added an automatic update script that should work with nix-shell maintainers/scripts/update.nix --argstr package stretchly.

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build stretchly

I've been using this for a while now, and I haven't had any problems with it.


Added new floor: Mystery Floor and the connections

I added a mystery floor to the floors.
This includes:
-name: mystery_floor
-description: A river and some mysterious adjectives
-connection -up from the third floor
-up to the second_floor
-down to the cellar

Thanks for the feedback. I removed the possible Syntax Error and commited the changes.

@l4nz8 pull request ready to be merged

Good job


Bug: Tokens move errantly.

https://imgur.com/G4aAAVy
Reproduction steps:

Create NPC
Place NPC on canvas twice
Move NPC 1
Move NPC 2 relatively quickly in a random direction.

Result: NPC 2 will move onto NPC 1 in a direct line.
Game system: Pathfinder
Happens without integration activated as well.

Unfortunately I was unable to reproduce this bug so far. What version of Drag Ruler do you have installed?

We had a very similar issue to this occur last night for players in our Dungeon Crawl Classics game (in DCC all players start with four zero-level PCs in their control). It was only occurring for users with Player level permissions - Trusted Player (with access to all system and module settings) and GM did not experience this issue. Running 1.4.5

Can you observe any errors/wanings in the javascript console (press F12 to open it) when this bug happens?


fix Sesssion invalidate method dose not work after deserialisation

Wicket 6.x fails Session.invalidateNow() after deserialisation (For example, when using Oracle Coherence).
Session.destroy() uses sessionStore. But it is null after deserialisation because sessionStore is transient.

https://issues.apache.org/jira/browse/WICKET-6409

Thank you, @n1330 !


wrong subtitle timing

Sometimes the transcription misses the segments and stretches the segment after the missed segment to start of the segments
The timing error is not consistent it usually appears after the 40-second mark. This kind of error does not happen all the time
it is the trimmed version of the clip
https://github.com/jianfch/stable-ts/assets/109358640/6257d3a4-bac5-4b48-84cb-d492373d64e9
the ASS file show similar thing
Dialogue: 185,0:03:7.72,0:03:8.64,Default,,0,0,0,,I'm still wearing my
Dialogue: 186,0:03:8.64,0:03:9.50,Default,,0,0,0,,radioactive suit.
Dialogue: 187,0:03:10.10,0:03:11.08,Default,,0,0,0,,Did I mention I had that
Dialogue: 188,0:03:11.08,0:03:11.28,Default,,0,0,0,,on?
Dialogue: 189,0:03:11.82,0:03:12.06,Default,,0,0,0,,No?
Dialogue: 190,0:03:12.56,0:03:12.90,Default,,0,0,0,,I did.
Dialogue: 191,0:03:13.54,0:03:14.58,Default,,0,0,0,,The car is now dead as
Dialogue: 192,0:03:14.58,0:03:14.74,Default,,0,0,0,,Doc,
Dialogue: 193,0:03:15.26,0:03:16.34,Default,,0,0,0,,so I push it behind the
Dialogue: 194,0:03:16.34,0:03:17.20,Default,,0,0,0,,billboard for now.
Dialogue: 195,0:03:17.76,0:03:18.62,Default,,0,0,0,,I'm completely lost.
Dialogue: 196,0:03:19.22,0:03:20.52,Default,,0,0,0,,No idea what drugs the
Dialogue: 197,0:03:20.52,0:03:21.60,Default,,0,0,0,,old man slipped me this
Dialogue: 198,0:03:21.60,0:03:21.94,Default,,0,0,0,,time.
Dialogue: 199,0:03:22.58,0:03:23.60,Default,,0,0,0,,Maybe the same as last
Dialogue: 200,0:03:23.60,0:03:23.94,Default,,0,0,0,,night,
Dialogue: 201,0:03:24.24,0:03:25.28,Default,,0,0,0,,but this is the craziest
Dialogue: 202,0:03:25.28,0:03:25.36,Default,,0,0,0,,thing I've ever seen.

Dialogue: 207,0:03:45.54,0:03:46.36,Default,,0,0,0,,I run back into the
Dialogue: 208,0:03:46.36,0:03:46.64,Default,,0,0,0,,barn,

script I am using
model = stable_whisper.load_model(
        "base"
    )

sub_path = f"postaudio.ass"
        result = model.transcribe(f"postaudio.mp3", **options)  # type: ignore
        result: stable_whisper.WhisperResult = result.split_by_length(settings.config["subtitle"]["characters_at_time"])  # type: ignore
        result.to_ass(
            sub_path,
            tag=(r"{\1c&H34ebde&}", r"{\r}"), # not working also
            highlight_color=False, # type: ignore
            font_size=0,
            word_level=False,
            **sub_styling
        )

I again rain program to test after running the model again to predict
there is no missing segments(I have a script to text empty space b/w segments in json file)
stable-ts assets\temp\9tonul\audio.mp3 -o out.json
stable-ts out.json -o out.ass --max_chars 25

I reran the script and now other subtitle segments are missing.
Dialogue: 227,0:03:49.02,0:03:49.82,Default,,0,0,0,,I blast through that
Dialogue: 228,0:03:49.82,0:03:50.78,Default,,0,0,0,,wooden barn door like
Dialogue: 229,0:03:50.78,0:03:51.34,Default,,0,0,0,,it's plywood,
Dialogue: 230,0:03:51.86,0:03:53.22,Default,,0,0,0,,and fly past the old guy
Dialogue: 231,0:03:53.22,0:03:53.94,Default,,0,0,0,,and his family.
Dialogue: 232,0:03:55.54,0:04:22.32,Default,,0,0,0,,I walk into a diner.  <-------- this time with delay
Dialogue: 233,0:04:22.56,0:04:23.74,Default,,0,0,0,,I either meet him first,
Dialogue: 234,0:04:24.12,0:04:25.18,Default,,0,0,0,,a day later, or my young
Dialogue: 235,0:04:25.18,0:04:26.04,Default,,0,0,0,,man. My younger did next.
Dialogue: 236,0:04:26.42,0:04:27.46,Default,,0,0,0,,Dad's getting bullied by
Dialogue: 237,0:04:27.46,0:04:28.44,Default,,0,0,0,,a younger biff or about
Dialogue: 238,0:04:28.44,0:04:28.78,Default,,0,0,0,,to be,

The audio I ran the transcription on
https://github.com/jianfch/stable-ts/assets/109358640/7fe7b427-49ed-454f-ac28-a963187d940f

Also in lattest versions it is impossible to use
tag=(r"{\1c&H34ebde&}", r"{\r}"),

due to added changes that never allow the function which is responsible to use tags
I have a fix for that
def result_to_ass(result: (dict, list),
                  filepath: str = None,
                  segment_level=True,
                  word_level=True,
                  min_dur: float = 0.02,
                  tag: Tuple[str, str] = None,
                  font: str = None,
                  use_tag = True,
                  font_size: int = 24,
                  strip=True,
                  highlight_color: str = None,
                  karaoke=False,
                  reverse_text: Union[bool, tuple] = False,
                  **kwargs):
    """

    Generate Advanced SubStation Alpha (ASS) file from result to display segment-level and/or word-level timestamp.

    Note: ass file is used in the same way as srt, vtt, etc.

    string of content if no [filepath] is provided, else None

    """
    if highlight_color is None and (karaoke or (word_level and segment_level)):
        highlight_color = '00ff00'

    def segments2blocks(segments):
        fmt_style_dict = {'Name': 'Default', 'Fontname': 'Arial', 'Fontsize': '48', 'PrimaryColour': '&Hffffff',
                          'SecondaryColour': '&Hffffff', 'OutlineColour': '&H0', 'BackColour': '&H0', 'Bold': '0',
                          'Italic': '0', 'Underline': '0', 'StrikeOut': '0', 'ScaleX': '100', 'ScaleY': '100',
                          'Spacing': '0', 'Angle': '0', 'BorderStyle': '1', 'Outline': '1', 'Shadow': '0',
                          'Alignment': '2', 'MarginL': '10', 'MarginR': '10', 'MarginV': '10', 'Encoding': '0'}

        for k, v in filter(lambda x: 'colour' in x[0].lower() and not str(x[1]).startswith('&H'), kwargs.items()):
            kwargs[k] = f'&H{kwargs[k]}'

        fmt_style_dict.update((k, v) for k, v in kwargs.items() if k in fmt_style_dict)

        if highlight_color:
            fmt_style_dict['PrimaryColour'] = \
                highlight_color if highlight_color.startswith('&H') else f'&H{highlight_color}'

        if font:
            fmt_style_dict.update(Fontname=font)
        if font_size:
            fmt_style_dict.update(Fontsize=font_size)

        fmts = f'Format: {", ".join(map(str, fmt_style_dict.keys()))}'

        styles = f'Style: {",".join(map(str, fmt_style_dict.values()))}'

        sub_str = f'[Script Info]\nScriptType: v4.00+\nPlayResX: {kwargs.get("W","384")}\nPlayResY: {kwargs.get("H","288")}\nScaledBorderAndShadow: yes\n\n' \
                  f'[V4+ Styles]\n{fmts}\n{styles}\n\n' \
                  f'[Events]\nFormat: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text\n\n'

        sub_str += '\n'.join(segment2assblock(s, i, strip=strip) for i, s in enumerate(segments))

        return sub_str

    if tag is not None and karaoke:
        warnings.warn(f'[tag] is not support for [karaoke]=True; [tag] will be ignored.')

    return result_to_any(
        result=result,
        filepath=filepath,
        filetype='ass',
        segments2blocks=segments2blocks,
        segment_level=segment_level,
        word_level=word_level,
        min_dur=min_dur,
        tag=tag,
        default_tag=(r'{\1c' + f'{highlight_color}&' + '}', r'{\r}'),
        strip=strip,
        reverse_text=reverse_text,
        to_word_level_string_callback= None if use_tag else   (
            lambda s, t: to_ass_word_level_segments(s, t, karaoke=karaoke)
            if karaoke or (word_level and segment_level)
            else None
        )
    )

Thanks for pointing issue with result_to_ass(). tag should work as intended in latest commit. Note that tag is ignored if word_level=False.
I couldn't replicate the timing issue with audio clip you've provided using the default options. Do you know the arguments you passed into transcribe() with **options?

Yeah, I was using word_level=False to turn off effects otherwise, it will use the default green effect and the not-given tag.
the error happens randomly even when with same audio gives the right result and sometimes, it does not.  I also noticed if it ran from cli with JSON output it is less likely to give the errors.
The **options is "en" for language detection.
more info may help in recreating the error
No GPU was used, the base model was used,

if you try to transcribe multiple times then you may able to recreate the error. transcribing in python program cause errors most of the time for me.

This nondeterministic behavior might be due to the temperature fallback.
Use temperature=0 or --temperature_increment_on_fallback None for CLI to make it deterministic.

Sure I will try this

After testing multiple I can still having the issue

This time transcription had same line repeating 70% of the script

Also transcription on small audio works fine

Also, some results shows old behavior of making some empty delay and then stretching the other segment

Transcriptions with audio less than 60 sec are issued 1 out of 10 times and the one with the error was all last segments missing 10 seconds in which length of the audio was around 58 seconds

After testing multiple I am still having the issue (although much less)

If it is still not deterministic after setting temperature to 0, this issue is likely caused by factors outside of Stable-ts. It is like multiplying the same numbers but get different results each time. You can try it with just Whisper to see if you get similar behavior.

After testing with Whisper I am not getting any issue

The transcripts were all the exact same across hundreds of times I tested on my end with the audio you provided.
Also ran small test in colab and results were also consistent: https://colab.research.google.com/drive/1eqFZqXAIR_NNvgfI-SB-1Fqkd0GMOm2r?usp=sharing.

Is there any logger that I can use to get more info on why it is happening on my application ?

Can you share results as json files of a run with the issue and one without it?
If you're using version 2.9+, try to see if you can reproduce same issue with version 2.8.1. If the issue doesn't occur with 2.8.1, then it is likely a bug with 2.9.

Yes, I can send you raw JSON files.
I have tested on mostly 2.6.4 although tested newer versions I got the same issue.
I am now using vanilla Whisper with python dict to ass by stable-ts it is working fine for me.

The JSON could help narrow down the cause of the issue.
Have you tested the latest version 2.9.1? There were changes to how it chooses where it begins transcribing every audio chunk.


Improvements

Major Changes

added necessary Python library paths to make it usable on Linux
changed fixed-sized dialogs into resizable dialogs to prevent content clip

search/replace dialog
settings dialog

Minor Changes

added patterns of generated files to .gitignore
updated README.rst
fixed a typo in rstpad.pro

Thanks 👍  I'll look into this. Might take a while since a I don't have Qt setup at the moment.


Incorrect error location for uninitialized static consts

Enter the following code in the editor:
class C {
  C();
  static const int i;
}
Expected result: the error message "The const variable 'i' must be initialized" should appear at the site of the declaration of "i".
Observed result: the correct error message occurs, but it appears at the site of the declaration of the constructor, which makes no sense.
If the constructor is commented out, the error message jumps to the expected location.
I suspect that what's happening is that we're re-using the logic for determining where to report uninitialized final fields (they should be reported at the constructor site(s) if there are explicit constructors, and at the field site if there are no explicit constructors).  But this logic doesn't make sense for static consts.
Note that if "i" is changed to "final" rather than "static const", then the error changes to a warning ("The final variable 'i' must be initialized"), and the behavior would make sense, since final variables are typically initialized I suspect that we are erroneously re-using the logic

The analyzer now only reports the correct error.

The analyzer now only reports the correct error.


[WIP] Add verbose to NCA and MLKR

Fixes #67.
This PR adds a verbose argument for NCA and MLKR. Here is an example on a snippet.
from sklearn.datasets import load_digits
from metric_learn import NCA
dataset = load_digits()
X, y = dataset.data, dataset.target
nca = NCA(verbose=True, max_iter=5)
nca.fit(X, y)

Returns: UPDATE: Edited after commit https://github.com/metric-learn/metric-learn/pull/105/commits/8ca38b73f82555ccecbdce2b256e3321d22f8f71 that correct the training time
[NCA]
[NCA]  Iteration      Objective Value    Time(s)
[NCA] ------------------------------------------
[NCA]          0         1.436318e+03       0.20
[NCA]          1         1.770346e+03       0.23
[NCA]          2         1.777018e+03       0.22
[NCA]          3         1.779409e+03       0.22
[NCA]          4         1.781304e+03       0.23
[NCA]          5         1.782404e+03       0.22
/home/will/Code/metric-learn-bis/metric_learn/nca.py:113: ConvergenceWarning: [NCA] NCA did not converge: b'STOP: TOTAL NO. of ITERATIONS REACHED LIMIT'
  cls_name, opt_result.message), ConvergenceWarning)
[NCA] Training took     1.35s.

The code mostly comes from scikit-learn's NCA PR (https://github.com/scikit-learn/scikit-learn/pull/10058), and this verbose code in particular was taken mostly from scikit-learn's LMNN PR (https://github.com/scikit-learn/scikit-learn/pull/8602)
TODO:

[ ] Fix the convergence warning test for MLKR (related to #104)

I just noticed that the Conjugate Gradient method (used in MLKR) has a different way to count iterations: unlike L-BFGS-B, one iteration is not equal to one function call, so the way to print iteration number, objective and gradient, as done in this PR does not work for MLKR.
I was thinking I could maybe instead print the cost function for each function evaluation instead of each iteration, for MLKR ?
Or we could use L-BFGS-B for MLKR too ? @perimosocordiae was there a particular reason to use Conjugate Gradient ?
Looking into the documentation of  Conjugate Gradient https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.fmin_cg.html, at Notes they say that it works better if the function has a global minima, which I don't think there is, right ? (any rotation of an optimal transformation A would be optimal too because conserving distances)
@bellet any thought on that ?
Note: here is a thread that compares the two methods: https://scicomp.stackexchange.com/questions/507/bfgs-vs-conjugate-gradient-method

The MLKR paper says this about the optimization problem, after briefly describing a gradient descent algorithm:

Of course, other methods for minimizing (3) such as conjugate gradient, stochastic gradient or BFGS may also be used and might lead to faster convergence results.

The initial MLKR implementation by @dsquareindia used a hand-rolled gradient descent, and I later converted this to use scipy.optimize.minimize probably without thinking too hard about the choice of method.
So in summary: if you think L_BFGS-B will work better, feel free to try it out! :+1:

L-BFGS-B should also work well (maybe slightly better) at the cost of slightly higher memory. Maybe you can indeed give it a try, this would make it more consistent with NCA

Allright, we can go for L-BFGS-B for now (it can easily be changed in the future)
I just added a commit which also uses less features for the test of make_regression, making the task easier to train on hence making MLKR do really 2 iterations (and hitting max_iter in the test), and not stopping weirdly at the beginning (see https://github.com/metric-learn/metric-learn/issues/104)

Changing the underlying optimizer is a bit of a compatibility break, too, so I'm fine with making it explicit by changing the keyword arguments.

I just realized in fact L-BFGS-B also has an epsilon parameter, so maybe we want to keep it ? And also add it to NCA consequently ?

From my understanding, epsilon is useless here because you already provide a function to compute the exact gradient (this is also true for NCA)

Oh yes that's right
I'll provide a deprecation warning similar to the one in NCA and I think we'll be good to merge

I just realized that MLKR is introduced in master (will be introduced in the next release), so I guess actually we don't need any deprecation ?

Makes sense indeed :-) But need to fix the travis failure

Done


improve graphviz

[ ] use corner arrows instead of straight arrows

@Jelly298

using splines 'ortho' i got it working but the edges don't connect to the ports
https://github.com/gdsfactory/gdsfactory/pull/3351

I've reproduced the issue. Also found a similar issue here.
https://stackoverflow.com/questions/75953069/graphviz-edges-with-ortho-lines-not-aligning-with-ports
Working on the fix

Awesome, the new schematics look beautiful thanks to your PR, see


Question about L2 regularization(weight decay)

Hi ,
when I read your code,  for var in self.layers[0].vars.values() shows that the L2 regularization only contains vars of the first layer, why not all layers? I am confused about this.
def _loss(self):
    # Weight decay loss
    for var in self.layers[0].vars.values():
        self.loss += FLAGS.weight_decay * tf.nn.l2_loss(var)

    # Cross entropy error
    self.loss += masked_softmax_cross_entropy(self.outputs, self.placeholders['labels'],
                                              self.placeholders['labels_mask'])

Thanks!

We found that L2 loss only on the first layer sufficed for decent results
(as described in our ICLR 2017 paper). Of course you can place a
regularizer on all layers.
On Tue, Apr 23, 2019 at 11:22 AM agave233<EMAIL_ADDRESS>wrote:

Hi ,
when I read your code, for var in self.layers[0].vars.values() shows that
the L2 regularization only contains vars of the first layer, why not all
layers? I am confused about this.
def _loss(self):
# Weight decay loss
for var in self.layers[0].vars.values():
self.loss += FLAGS.weight_decay * tf.nn.l2_loss(var)
# Cross entropy error
self.loss += masked_softmax_cross_entropy(self.outputs, self.placeholders['labels'],
                                          self.placeholders['labels_mask'])

Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tkipf/gcn/issues/108, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYBYYAGY42RJK5F3Q6U4LTPR3INBANCNFSM4HHWD7HQ
.


[FLINK-3555] Web interface does not render job information properly

Before: When a window is minimized, the content turned out to be beyond

After::shipit:

Thank you for this patch.
Could you help us validate the changed behavior, for example attach a before/after screenshot of chrome or Safari that shows the difference?

@StephanEwen Sure.

@StephanEwen is it right?

Looks good, thanks for the nice animations!
Will merge this for 1.2 and 1.3 ...

Sorry, I have to take a step back here:
The changes you made were directly to the resulting CSS files. These files are generated by the web build scripts, so the changes have to be made to the original files. Otherwise they will be overwritten the next time somebody re-builds the web UI. See here: https://github.com/apache/flink/blob/master/flink-runtime-web/README.md
The change to flink-runtime-web/web-dashboard/web/css/index.css is easy t put into index.styl instead. However, the change in flink-runtime-web/web-dashboard/web/css/vendor.css overwrites a style that is pulled in as a dependency. Not sure how to handle this correctly.
@uce @sachingoel0101 ot @iampeter Can probably help here.

Imo, the best way to achieve the change equivalent to the change to vendor.css file would be to add a new class, say, .panel-body-flowable in index.styl which defines the overflow rule, and add this class to the elements wherever needed.

@bitchelov do you want to follow up on this pull request?

I agree with @sachingoel0101 as for overrriding classes from vendor.css

@StephanEwen yeah, sure im gonna finish this pr

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue.


Feature/readme

Adding a readme file to the DataScience package. Modified the probabilistic parser to use relative paths for easier usage by others.

LGTM

Very very nicely done, great documentation too! Major kudos !


New Package: lycheeverse.lychee 0.10.3

Resolves #91395
Related to lycheeverse/lychee#59

Has a runtime dependency on VCRedist2015+
Microsoft Reviewers: Open in CodeFlow

@msftbot dependencies

@msftbot reset feedback


[Mention The Feature]: Add complete tutorial page for creating pipeline for detecting phishing websites in projects page website

Is your feature request related to a problem? Please describe.
Analyze protocols , meta-dataa , architecture , url , domain , ports , anchors , traffic and various other features of given url and detect whether the given website is malicious or not
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
https://github.com/user-attachments/assets/31c1aedc-3de8-4076-abc4-d65d37faf994
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@DarshAgrawal14 this will be the last issue that i am gonna assign you.
Make sure to complete this.

hey @vivekvardhan2810 , if the repo is active till today evening , will it be alright right if i made few commits. actually i have been inactive for past few days due to exams and currently in need of PRs ..

yes @DarshAgrawal14 you can commit, till today.

thanks a lot

@DarshAgrawal14 have you done with the task.

yeah i just need a little more because this is a pipeline so it has URL feature extraction code along with model training and it is a bit difficult to explain the extraction part properly . just give me like 10 min and i will submit a PR.


Add OctoSQL to list of systems powered by DataFusion

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
https://github.com/cube2222/octosql

oops, misread the HN comment - this does not use DF


Update manifest.md

add a link to avoid extra work of contributor.

@Reset12138 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Feature request: Add comments for the samples

Motivation

Easier to understand especially for newcommers

Drawbacks

None really (except it takes time)

Rationale and alternatives
No response
Additional context
No response

I might be willing to spend some time on this as an easy-start contribution. However, as the issue is written, it's not very actionable. What kind of commenting would be most useful (for you, or in general)? Are you looking for API usage information, Rust<->Windows mapping, or run-of-the-mill code commenting?

Feel free to contribute comments for individual samples if something's unclear. The challenge with commenting the samples in general is that it depends on what you know about Windows and Rust and your unique background and experience.
I'm also working on a more complete guide to getting started that should help with explaining concepts:
https://kennykerr.ca/rust-getting-started/


EnvoyFilter applies only to Sidecar even though context is Any

Apply this EnvoyFilter:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: h2-control
spec:
  configPatches:
  - applyTo: CLUSTER
    patch:
      operation: MERGE
      value:
        http2_protocol_options:
          initial_stream_window_size: 65536
          initial_connection_window_size: 65536
  - applyTo: NETWORK_FILTER
    match:
      context: ANY
      listener:
        filterChain:
          filter:
            name: "envoy.http_connection_manager"
    patch:
      operation: MERGE
      value:
        typed_config:
          "@type": "type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager"
          http2_protocol_options:
            initial_stream_window_size: 65536
            initial_connection_window_size: 65536

Config dump for ingressgateway shows nothing, sidecar shows applied correctly

@howardjohn It is because the envoyfilter function on workload within the same ns. I think we should doc it clearly

oh yeah... :man_facepalming:


How to train model with existing model weights?

I am using colab to train model with two classes and 84 images with 5oo epochs , it suddenly crasshed after 8o epochs .How can i train my model using 8o epochs weights? Kindly help

which model are you using for training?

can you share your script?


trigger API when conversation is complete

Move the conditional API calling to the end of request handler. Prior the change, the handler fails to trigger API in some scenario (e.g. when there is no parameter involved and the conversation is complete).

parameter prompt is not working.


feat: use favorite name in the device list

Closes #860

Closes #860

Perfectly. Thank you. I would also recommend that you pay attention to #861. It sounds quite reasonable and should not pose any difficulties in implementation. Especially since similar topics have been raised many times before, and now with the introduction of Favorites, it is a rather logical development of the feature.

Hi, unfortunately, there is currently no way to verify the authenticity of the fingerprint (a random string that is used for favorites).
Actually, I have added the "Favorites" feature because of #250 where the discovery is not working properly.
Flutter (the framework to build LocalSend) currently does not allow to retrieve the SSL certificate by the sending device. This is needed to check if the fingerprint (which is the hash of the SSL certificate) is actually valid.
I could implement #861 but anyone with technical expertise can fake the fingerprint (and therefore the device name).

Hi, unfortunately, there is currently no way to verify the authenticity of the fingerprint (a random string that is used for favorites). Actually, I have added the "Favorites" feature because of #250 where the discovery is not working properly.
Flutter (the framework to build LocalSend) currently does not allow to retrieve the SSL certificate by the sending device. This is needed to check if the fingerprint (which is the hash of the SSL certificate) is actually valid.
I could implement #861 but anyone with technical expertise can fake the fingerprint (and therefore the device name).

Clearly. Sincerely grateful for the explanation. I thought something like a MAC address was used to identify the device and it would be possible to just compare the list. Sorry for any inconvenience. Thanks again.


Remove Section.code field?

@jaburgoyne , the Section object contains a code field, which is populated with a random integer between 0 and 99999. Do you remember what the purpose of this code was? Do you think it's still necessary? The only use I could think of was that it makes it harder to infer the link of a section, but it's also rather hard to guess the id (by which it is otherwise retrieved), and ids are unique.

I don't remember exactly, but I think it indeed had to do with some kind of mild security by obscurity. We were quite worried about potential geofencing requirements for a time, but licensing turned out to be easier than we expected.
Please check that this field is not used anywhere, but if it is not, you are free to get rid of it as far as I am concerned.


[FR] Add an option to support opening link in a popover via Hover Editor.

I think this way might provide the best experience.

Support this idea, and adding options for opening links in panes to the side.

I also support this idea


Environment variables unable to be overridden when nesting past four levels

Expected Behavior
Given an environment with variables nested more than four levels deep such as:
{
	"foo1": {
		"foo2": {
			"foo3": {
				"foo4": {
					"foo5": "bar"
				}
			}
		}
	}
}

and a sub-environment that overrides it:
{
	"foo1": {
		"foo2": {
			"foo3": {
				"foo4": {
					"foo5": "boo"
				}
			}
		}
	}
}

I should be able to refer to it inside of Insomnia using the following nunjuck: {{ _.foo1.foo2.foo3.foo4.foo5 }}
Actual Behavior
When I reference the nunjuck tag like {{ _.foo1.foo2.foo3.foo4.foo5 }}:

When I click on the tag to edit it, I get a screen like so (only allowing me to select to the fourth level):

So, if I select the fourth level and reference the nunjuck tag like {{ _.foo1.foo2.foo3.foo4 }}:

Reproduction Steps

Add a new base environment variable that is nested five levels deep, i.e.

{
	"foo1": {
		"foo2": {
			"foo3": {
				"foo4": {
					"foo5": "bar"
				}
			}
		}
	}
}

Add a new sub environment variable that overrided the nested variable, i.e.:

{
	"foo1": {
		"foo2": {
			"foo3": {
				"foo4": {
					"foo5": "boo"
				}
			}
		}
	}
}

Select to activate the new sub environment
Try to use the nested variable in a request
Notice that it cannot be used as expected:

When I reference the nunjuck tag like {{ _.foo1.foo2.foo3.foo4.foo5 }}:

When I click on the tag to edit it, I get a screen like so (only allowing me to select to the fourth level):

So, if I select the fourth level and reference the nunjuck tag like {{ _.foo1.foo2.foo3.foo4 }}:

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2022.5.1
What operating system are you using?
macOS
Operating System Version
macOS 12.4
Installation method
download
Last Known Working Insomnia version
No response

Hi @bbbco, thanks for reporting this!
We're currently focused on finalizing release 2022.6.0. We will look into community PRs as soon as possible, though it might take a while. In the meantime feel free to contribute other issues you find 👍


fix for jupyter 4.1.1

Hi,
first, thanks for the plugin.
I am using a rather new version of jupyter and found that the style that nbconvert creates within the html file is not applied for some of the pelican themes, such as pelican-bootstrap3.
One reason is that the nbconvert API may have changed slightly.
Also, the pygments output is wrapped in a pre-tag, which I add to the nbconvert css.
This is not a robust solution as it makes many assumptions and is not configurable, mostly because I am not familiar with all the tools :)
Please let me know what you think.
Thanks!

Thanks for the fix, i'll try it when i get a chance and merge it.


No Authorization Policy API Resources should not be listed as an option when assigning permissions to a role.

Describe the issue:
In the current console, even the no policy API resources are listed in the Select API Resource dropdown in the Assign permission tab.

How to reproduce:

Create a No policy API resource from API Resources.
Navigate to the Roles page and select a role.
Go to the Permissions tab.
click on the Select API Resource dropdown.

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: Mac
Database: MySQL
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

When creating an application audience role, the ideal behaviour should be only giving the APIs authorized under RBAC policy  to be assigned to the role. In organization audience roles, we can't do such thing since we don't know how the APIs are going to be authorized in different applications. For the application audience roles, we need to add the validation in UI for avoid the confusion that why APIs authorized under no policy should be assigned to the role. Also, we need to think whether we need to add this as a backend validation as well.


PHPUnit comparator breaks under PHPUnit 10/comparator 5

There was a breaking change going from sebastian/comparitor:4 to 5, which by default you'll pull in updating to PHPUnit 10.
At a glance, there are two adjustments:

don't call parent::construct
add : bool return type to accepts

I think the latter is fine for forward compatibility, but the former may require some hacking to get around the loss of constructor
I'll take a quick attempt at a PR to address this.

Fixed by #784.


config_file_path should be read from ENV

Hello!
I'm trying v2.25  on GKE.
config_file_path variable is hardcoded in docker_entrypoint.sh script.
Should be read from arguments, or ENV.
Thank you!

@diegosucaria, thanks for reaching out! Will discuss with the team about making config_file_path public and will circle back.
Thanks,
Rehana

Hi @diegosucaria, unfortunately, we will not be able to take this on at this time. Is this something you are interested in contributing?

Yes, for sure. it is a few lines change. But I haven't had the opportunity to review the contributing guide just yet.
Will do!

If you are using the latest Dockerfile you can override CONFIG_FILE_PATH with yours. It is set in the last stage


Unit tests (using pFunit)

I have started putting in the infrastructure for us to write some unit tests using pFunit.
Create simple unit tests for main functions

[ ] Make the cmake portable; I fought a bit, but I don't know enough cmake. We need to be able to link the include directories for ftorch. At the moment the library and include paths need to be specified.
[ ] Test torch_tensor_from_blob (WIP)
[ ]  Test torch_tensor_from_array

Other things using torch_module_forward could be better with an integration test since it will need a lot of setup code anyway.

tests/test_ftorch.pf gives a start of a unit test for torch_tensor_from_blob

Has this gone anywhere, or has it stagnated?
As far as I see it tests are the only thing preventing us from making a JOSS submission, and with at least 3 research projects using FTorch that are likely to publish soon this is now a matter of urgency.
For something minimal I was thinking we could have some CMake Test to build and run the SimpleNet example for a few different inputs and check the outputs are correct as an integration test.

There's a start here, but it got a bit stalled as I could use some help with the cmake. Perhaps someone is able to work with me on this? @TomMelt ?

Great, thanks @dorchard
Proposal from the morning is to briefly pause on this in favour of integration tests in # so we can make a JOSS submission, then return to this. We can certainly take a look and help with cmake, and the integration tests will use cmake so you might find those useful.

Hi @dorchard I'm more than happy to help with the CMake side of things. Let me know when is convenient.

@jwallwork23 I rebased off main for you.

Perhaps this PR could just set up the infrastructure and add tests for the tensor constructors and we could address writing unit tests for the rest of FTorch in a follow-up PR?

Interestingly, I needed to set the integer kind to get these tests working on my Ubuntu laptop, too (see https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/c30bc218440d641e52ead288abbf4dc5e13c9a93). I'll update this to follow @TomMelt's 32-bit int approach once #137 is merged.

[Rebased on top of main to bring in linting changes]

Thanks for the tips @TomMelt - with a few tweaks the tests now pass on Ubuntu. There's a build fail in the Windows CI, although I didn't edit the Windows CI workflow or the part of the CMakeLists that it errors at. Do you have any thoughts on what's gone wrong?
https://github.com/Cambridge-ICCS/FTorch/actions/runs/12351579042/job/34466833553?pr=76

Merged in the Windows fix from #207 in https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/23ce977bfa9068797a4f9be0ea183f6290e2f54a. Turned off unit testing for Windows in https://github.com/Cambridge-ICCS/FTorch/pull/76/commits/f1e9add826c8b02f87e6d53f1380d7d7b55f3521.

@dorchard I can't add you as a reviewer because you authored the initial commits, but any comments you have would be appreciated.

Went through this in the meeting today; up-to-date with main and ready for review.


bash completion broken on MacOS & bash < 4.4

Issue description
Since #4849 was merged, bash completion is no longer available for bash bundled with MacOS (bundled version is 3.2) and other environments where installed bash version < 4.4, due to the minimum bash version requirement described in the first line of the click docs here: https://click.palletsprojects.com/en/8.0.x/shell-completion/.
Expected result
Bash completion would continue to work on standard MacOS environments.
Actual result
Bash completion support is broken on MacOS with bundled bash:
Steps to replicate
$ uname -mprsv
Darwin 20.6.0 Darwin Kernel Version 20.6.0: Tue Oct 12 18:33:42 PDT 2021; root:xnu-7195.141.8~1/RELEASE_X86_64 x86_64 i386
$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)
Copyright (C) 2007 Free Software Foundation, Inc.
$ pipenv --version
pipenv, version 2021.11.9
$ eval "$(_PIPENV_COMPLETE=bash_source pipenv)"
Traceback (most recent call last):
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/bin/pipenv", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1057, in main
    self._main_shell_completion(extra, prog_name, complete_var)
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1132, in _main_shell_completion
    rv = shell_complete(self, ctx_args, prog_name, complete_var, instruction)
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 45, in shell_complete
    echo(comp.source())
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 324, in source
    self._check_version()
  File "/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv/vendor/click/shell_completion.py", line 312, in _check_version
    raise RuntimeError(
RuntimeError: Shell completion is not supported for Bash versions older than 4.4.

$ pipenv --support
Pipenv version: '2021.11.9'
Pipenv location: '/usr/local/Cellar/pipenv/2021.11.9/libexec/lib/python3.10/site-packages/pipenv'
Python location: '/usr/local/Cellar/pipenv/2021.11.9/libexec/bin/python3.10'
Python installations found:

3.9.7: /usr/local/bin/python3
3.9.7: /usr/local/bin/python3.9
3.9.5: /Users/milo/.pyenv/versions/3.9.5/bin/python3
3.8.12: /Users/milo/.pyenv/versions/3.8.12/bin/python3
3.8.9: /usr/bin/python3
3.7.11: /Users/milo/.pyenv/versions/3.7.11/bin/python3
2.7.16: /usr/bin/python
2.7.16: /usr/bin/python2
2.7.16: /usr/bin/python2.7
2.7.2: /usr/local/bin/jython

PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.10.0',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '20.6.0',
 'platform_system': 'Darwin',
 'platform_version': 'Darwin Kernel Version 20.6.0: Tue Oct 12 18:33:42 PDT '
                     '2021; root:xnu-7195.141.8~1/RELEASE_X86_64',
 'python_full_version': '3.10.0',
 'python_version': '3.10',
 'sys_platform': 'darwin'}

System environment variables:

PATH
NVM_INC
TERM_PROGRAM
PYENV_ROOT
NVM_CD_FLAGS
M2
SHELL
TERM
SHELLCHECK_OPTS
TMPDIR
GRADLE_HOME
TERM_PROGRAM_VERSION
TERM_SESSION_ID
ANSIBLE_VAULT_PASSWORD_FILE
NVM_DIR
JRE_HOME
USER
HUSKY_SKIP_INSTALL
SSH_AUTH_SOCK
JAVA7
JAVA8
BASH_SILENCE_DEPRECATION_WARNING
WORKON_HOME
OLD_PS1
_
__CFBundleIdentifier
PWD
HOMEBREW_GITHUB_API_TOKEN
JAVA_HOME
EDITOR
LANG
XPC_FLAGS
XPC_SERVICE_NAME
GPG_TTY
PYENV_SHELL
M2_HOME
SHLVL
HOME
GOROOT
JAVA11
LOGNAME
GROOVY_HOME
JAVA17
NVM_BIN
GOPATH
ANSIBLE_CONFIG
LPASS_CLIPBOARD_COMMAND
__CF_USER_TEXT_ENCODING
PIP_SHIMS_BASE_MODULE
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /usr/local/Cellar/pipenv/2021.11.9/libexec/tools:/Users/milo/.pyenv/shims:/Users/milo/.nvm/versions/node/v16.13.0/bin:/Users/milo/go/bin:/usr/local/opt/go/libexec/bin:/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
SHELL: /bin/bash
EDITOR: /usr/local/bin/vim
LANG: en_US.UTF-8
PWD: /Users/milo

Not much Pipenv can do here, as long as we depend on click to provide completion.